2026-03-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b4b39682cd9868fa725bc664aff94278d315bd04]

        Version 25.8.6.2, tag libreoffice-25.8.6.2

2026-03-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [79c029d478b25d55b1e83522d7af04dc904eefa0]

        bump product version to 25.8.6.2
        
        Change-Id: Idcabade08d11a76d40000882e649e813600fbd8f

2026-03-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [432b9e431b10652c80dad58eb96680350caa759d]

        ofz#490136913 Direct-leak
        
        this went wrong in:
        
        commit ab7c81f55621d7b0d1468c63305163016dd78837
        Date:   Wed Oct 4 15:42:27 2023 +0200
        
            ITEM: Get away from classic 'poolable' Item flag
        
        where the old pointer compare thing to detect this was a temp
        object to destroy was misidentied as something more complicated.
        
        Change-Id: Ica2fad036d5da54c5ebfeb2de5278b85db8f6247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 61a0ed0a8d34207e153cb2acf9bb29bf2e500a3c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201106
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 07624ef14e7bc100ba1af8c96651ac71cc49e953)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201907
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6eb760c9c87476541c37356f11e294eccba895a8]

        update credits
        
        Change-Id: I358e48a749bc981b24cce5bd21ee25b63d2771bf
        (cherry picked from commit 2a3fd9ca8ce1dd598ebe2c3d678d534b582a30b2)
        (cherry picked from commit f4b84ebb67bd408490a4baf737f2bb7068e69607)

2026-03-17  Patrick Luby  <guibmacdev@gmail.com>  [6f24a8a626f0acad917d015e8f70e961d0be2756]

        tdf#170864 Remove launch constraints from uri-encode executable
        
        The shell script in Resources/senddoc will fail to create a new
        e-mail in the Apple Mail application if MacOS/uri-encode is
        codesigned with launch constraints. So codesign MacOS/uri-encode
        without any launch constraints.
        
        Change-Id: I7bbeb783f713691bed61748615f0632162520e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201775
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit f1efb4d0e39271271b2db753a15fe9abe487896c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201914
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Dan Williams <dcbw@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [03531378b8a7b4324f0b6ed008a9d160463fefe9]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8-6'
          to fa8329e7d442079c66d3f8db5447c9ba9722d131
          - update translations for 25.8.6 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I32b08463fb138a98fee9cd05eab8abfe334608d4
            (cherry picked from commit 21f54fc901890a72b1009daeb0686bb2a4645fe8)
            
2026-03-17  Patrick Luby  <guibmacdev@gmail.com>  [bc430d22bcb13bbba72bb30eec6d105260203557]

        tdf#170740 only repost the same left mouse up event once
        
        Dragging a window's titlebar with the Option key pressed
        may trigger live resizing. Unlike normal live resizing,
        live resizing while Option-dragging a window needs
        left mouse up events to be dispatched to end live
        resizing. So if we keep reposting the same left mouse up
        event, LibreOffice will go into an infinite loop waiting
        for live resizing to end.
        
        Reposting last mouse up events is still needed to
        prevent tdf#155092 during normal live resizing so allow
        last mouse up events to be reposted but only once.
        
        The purpose of reposting is to skip native event
        dispatching during this pass and only let native timers
        run. This lets pending LibreOffice resizing and
        repainting timers run before the left mouse up event is
        dispatched.
        
        Change-Id: Ide2ec9988a8258cd1acf9852a61cfc4d4c1abdef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200957
        Reviewed-by: Dan Williams <dcbw@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit 7575bbe54a6afec3b289985593977579835cce3f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201195
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        (cherry picked from commit d655a441b66aac6e20776b41d05178593c6c991b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201225
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-17  Michael Stahl  <michael.stahl@collabora.com>  [b73172311a8a98875d88d4bb2a2791ef7a27a193]

        curl: add patches for CVE-2026-1965 CVE-2026-3783 CVE-2026-3784
        
        Change-Id: I8421831c20452ea84a67ff4c751f9eb9166b66d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201437
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit 4aa94dbcac28a521f23c91c1ab658d5973c8af36)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201452
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 84ce473ad99d402a925e067dcddc515c0e6ec572)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201499
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 716fee1873f159529bb3f5415084d671b1a4da3b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201502
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-17  Jim Raykowski  <raykowj@gmail.com>  [fc76b58cc28f0b9f2f00844af983faa13d06dcef]

        tdf#170067 SwNavigator: Unprotect section needs to ask for set password
        
        ...again
        
        Follow up patch to always ask for the password when unprotecting
        sections that have protection set with a password. The previous patch
        askes for the password only the first time.
        
        Change-Id: I54818151b8c5f43026d656065f85f2d736f98fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196049
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200845
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200948
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-17  Jim Raykowski  <raykowj@gmail.com>  [5f62cf8a6b0cd6d124f7865b4ae8f4776e9f2227]

        tdf#170067 SwNavigator: Unprotect section needs to ask for set password
        
        Makes unprotecting password protected sections from the Navigator
        Sections entries popup menu show the password dialog for password entry
        match before unprotect can be done.
        
        Change-Id: I1178a2254616a32ad33f6974071885e3021d1dcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196040
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200844
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200947
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [347809a66c13a8b232e67feb839f1b6e7958b08f]

        tdf#156893: in ScPrintFunc::DrawToDev, row count is not a hint
        
        Before this, the function created at most 1024 rows in ScTableInfo,
        which is OK for notmal pages, but is limiting whole sheet export.
        
        Change-Id: Ie1663147476f56e879673a7532ec9ae8bb28ac68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201204
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 015861bbf45e5cf901fec9c8394b3046ce27514c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201276
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit eabe86fb8f57457978bc224b9bc942239a3d25c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201283
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [703e0d196d7084f74288b072079cf9536ec8672d]

        tdf#169032 fix wrong/missing buildid hash in windows MSI packages
        
        while the ini files that are put into instdir are created by
        instsetoo_native/CustomTarget_setup.mk and work just fine in
        wsl-as-helper build environment, the files for installation sets are
        actually created by scp2 and the perl installer code.
        It fails to get the git hash/the command exits with error, so instead of
        doing a separate cd command with fancy redirections use git directly
        with the path argument.
        
        Change-Id: I9ced68c5ed9056e8fb140f7bcf1f07691c60115b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201049
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 14b2feffbc243e9b38e16ca35c6aaea3f9b28d1a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201060
        (cherry picked from commit ce33b733912b2c992f501af6b1fcf76e96096271)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201107
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [38e9dae7c19484c48c4180a16ad3e6fcf33a6c13]

        bump product version to 25.8.6.1.0+
        
        Change-Id: I695a00fc95428d119a1219c62a8fc5e7dbb7fa6a

2026-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f995629ffa3542acb5ac895869bb93434e63fabb]

        Branch libreoffice-25-8-6
        
        This is 'libreoffice-25-8-6' - the stable branch for the 25.8.6 release.
        Only very safe changes, reviewed by three people are allowed.
        
        If you want to commit more complicated fix for the next 25.8.x release,
        please use the 'libreoffice-25-8' branch.
        
        If you want to build something cool, unstable, and risky, use master.

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0d45681d747bb7f888fd509ebbc7618fd85b974]

        freetype: upgrade to 2.14.2
        
        Downloaded from https://download.savannah.gnu.org/releases/freetype/freetype-2.14.2.tar.xz
        
        Change-Id: I5f1896b71497be9b730c0725e23c48d3d1c893dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200776
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c9da599daf8ffdb198d364925649ed7729df7c89)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200818
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [7e561e10212ac0f0df6b675b1a1ad2e43fbe0213]

        postgresql: upgrade to 15.17
        
        Downloaded from https://ftp.postgresql.org/pub/source/v15.17/postgresql-15.17.tar.bz2
        
        Change-Id: I78152063d79af71864576d341405d7bd076ccd9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200455
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [61add900357f0d13a69272c918080c9579bfba69]

        Update git submodules
        
        * Update dictionaries from branch 'libreoffice-25-8'
          to e59dd6677411c75521ab4d67a0c12e159a276e02
          - upgrade Ukrainian dictionaries to 6.7.5
            
            Downloaded from https://github.com/brown-uk/dict_uk/releases/download/v6.7.5/hunspell-uk_UA_6.7.5.zip
            
            Change-Id: I2b877e57ef22d0f313d125dfb842311b3425744d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/200295
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            (cherry picked from commit 589a31b2c7e8a592270012e111a51a80d0176f6e)
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/200297
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2026-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [78569c954b4fed89d779e63d6a0e599c0cfb22cf]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to d2fe080124f849ae75ab4de3539ef3e854773aa9
          - update translations for 25.8.6 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I2ad145c602e0e941de68bf3e4200bc929b1beedd
            
2026-03-03  Michael Stahl  <michael.stahl@collabora.com>  [0897f51b79789b2ae6e99910a0b475cf7992b640]

        nss: upgrade to release 3.121
        
        Fixes CVE-2026-2781
        
        Change-Id: I49936c56638dc6ce2bc5d7cf7d591586d4c5924a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200787
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit e340bae8d3fb6b8d5ba4880e4853b975d48e8a8e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200823
        Tested-by: Jenkins

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d59c73b64991ecea8c1b11466785859d37b3352]

        nss: upgrade to 3.120
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_120_RTM/src/nss-3.120-with-nspr-4.38.2.tar.gz
        
        Change-Id: I710faca7e285ff4de9a86d8041a69d38f62e149c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197653
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200822

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [ddee63ad532569274fc8d0308b371ff3e2afcc27]

        nss: upgrade to 3.119.1
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_119_1_RTM/src/nss-3_119_1-with-nspr-4.38.2.tar.gz
        
        Change-Id: I281e1a7f7bb212e1e721deba6238f3bcc17795e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195436
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit a40ea776fe34d01682b4716d609e5b61d70226ae)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195912
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200821

2026-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [736eb9ce8449421500ca13d81fdb674ce4e142fe]

        fix nss/nspr build on intel macs
        
        regression from aba5f8016965e42075e68faa17ddfd3b3213247d
        
        nss' Darwin.mk uses uname -p to decide on the platform if CPU_ARCH is
        not set, and that still returns i386 on intel macs – in the old
        version that still worked since there was an additional ifdef USE_64
        check that then set it to x86_64, but that has since been removed and
        only the custom guards to not add additional -arch parameter to the
        compiler flags remain, resulting in the built to attempt a 32bit and
        that then fails when it comes to the assembly instructions:
        
        mpi/mpi_sse2.s:35:5: error: instruction requires: Not 64-bit mode
            push %ebp
            ^
        mpi/mpi_sse2.s:37:5: error: instruction requires: Not 64-bit mode
            push %edi
            ^
        mpi/mpi_sse2.s:38:5: error: instruction requires: Not 64-bit mode
            push %esi
            ^
        […]
        
        So don't rely on auto-detection and specify it explicitly as it was done
        for the other variants already, ironically also already for building for
        intel on arm. But the additional check whether it is building on arm is
        not necessary, our CPUNAME is sufficient already and that now
        superfluous bit can be removed.
        
        Change-Id: Ic467b06beb9b73e2d177eedede886681aa668b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195439
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Dan Williams <dcbw@libreoffice.org>
        (cherry picked from commit e11962c57a1a955f1509a653deea352583f3f77e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195490
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200820

2026-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c8706f7d07136e4c3ad1d1fb75833fb29a1a50c]

        nss: upgrade to 3.119
        
        * external/nss/connectx.patch.0 has been fixed upstream
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_119_RTM/src/nss-3.119-with-nspr-4.38.2.tar.gz
        
        Change-Id: I0477965c9ab62f21684278e5ed7860360521b270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit aba5f8016965e42075e68faa17ddfd3b3213247d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195312
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200819

2026-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc02f7e0f5a169536b1d9b7ecf3b5138fb52043e]

        tdf#168057: use RoleMapNS in PDF/UA-2
        
        This commit reverts my previous attempt at fixing the same issue
        commit 5dbf35a932bfa00e17f17b1f2337de7403754b8d
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Wed Feb 25 12:54:41 2026 +0100
        
            tdf#168057: Don't use aliases in StructElem when exporting to PDF/UA-2
        
        The unittest has been removed in the backport because
        the verapdf validator is only available in master
        
        Change-Id: I20ef86c780224909a7fa9414fea628415289af60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200350
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200352
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200390

2026-02-27  Zeki Bildirici  <kobzeci@gmail.com>  [46f5e4151ec2fb308960db31253f09351cfa8fd2]

        tdf#67544 Embed transition sound when Link is unchecked
        
        The Link checkbox in the sound file dialog was being ignored.
        When the user selects a sound file with Link unchecked, we now
        call avmedia::EmbedMedia() to copy the sound into the document
        package, matching the behavior of Insert -> Audio or Video.
        
        Change-Id: Id1c441ecd47c5fbc5bd285912fbf13a6c8346f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200083
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        (cherry picked from commit 507e1aeadf74cfa58ed30872a3bd858a96cbcb58)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200393
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-27  Saburo Yoshida  <sabr0libo@otkr.jp>  [33be472f8fe577b77fb04fec636423839288eee1]

        tdf#171009 svx: reset the no matches found error
        
        Change-Id: I0d23294e34e17facdc6c8f84795fb6786516a5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200424
        Reviewed-by: Saburo Yoshida <sabr0libo@otkr.jp>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit ddcba12df6b56702499f9789a5aa9a1ac05043fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200564
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-27  Khaled Hosny  <khaled@aliftype.com>  [82fa4b0966dd76923b2cce3fa5710dd920b27535]

        Parse hexadecimal escapes in vcl::filter::PDFNameElement
        
        We write these escapes rather liberally in COSWriter::appendName(), so we
        should parse them when reading.
        
        Change-Id: Ie9f7626de287fd5038ca198a7143a95c3471ce92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200446
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        (cherry picked from commit 247430c3edd811744f525d09da00035702cbbf6a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200500
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 235ea4b4c472f40977434c6437aab795f034a1dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200525

2026-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [2a0fa8b18afe6446b8e801a182ea0e8144291861]

        tdf#171041: avoid setting mbUsePrintSetting for automatic orientation
        
        Commit a67cd7b3cf03163f87811f7080cabc49750c4fd5 (tdf#155218 sc: fix
        different page orientation in print dialog, 2024-02-09) introduced
        Printer::SetUsePrintDialogSetting, used to change print settings to
        use what's configured in the dialog, instead of document.
        
        It was called unconditionally in PrintDialog::updatePageSize; but for
        automatic orientation, that breaks autodetection of the orientation
        in ScModelObj::getRenderer.
        
        This change only sets mbUsePrintSetting when the orientation in the
        dialog is not automatic.
        
        Change-Id: I0f7be0107e39e73bea8bc37a8f160f271f3242cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b7957bf31e05dc55015e41c9dfcaa7e26b533eef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200499
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-24  Saburo Yoshida  <sabr0libo@otkr.jp>  [2efd8b2c5b943973fd88c2bb1e7ec4cc4c713e1e]

        tdf#170448 PDF property characters were XML escaped multiple times
        
        e.g. apostrophe &amp;apos; --> &apos;
        
        Change-Id: I6bfedffef0244c945872438f2a9d74523bb717ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200027
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit e876be508061f9651a03f689fd2aea9451f7fc35)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200173
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200209

2026-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [eb46a8426f94b4bf03c2feead1d2f52da53d6635]

        tdf#167290: export CreationDate with DateTime format
        
        Otherwise, the validator fails with
        "The value of CreationDate entry from the document
        Info dictionary and its matching XMP property "xmp:CreateDate"
        are not equivalent
        (Info /CreationDate = D:20260220154049+01'00', XMP xmp:CreateDate = 2025-12-31T11:13:40.000+01)
        
        The call to osl_getDateTimeFromTimeValue was removed in
        commit 07ac61f2c67020ad2941462ea7081f06495bcb92
        Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Date:   Mon Aug 28 11:16:34 2023 +0300
        
            tdf#138792: PDF export: fix date of xmp:CreateDate
        
        for no apparent reason
        
        In libreoffice-26-2 and libreoffice-25-8 the test doesn't
        work because the verapdf validator is not implemented
        
        Change-Id: I4c6948769797a4e446239316de2857851b31565e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199886
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199908
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5fbac5fc4005772f0ba5164549f3807d1dd00f4]

        Resolves: tdf#170524 Lock in the start size request including scrollbar width
        
        Turn vertical scrollbar on by default, at dialog start measure width
        including the vertical scrollbar that might be needed later in the
        lifetime of the dialog even if it doesn't need it at startup time and
        lock that width in as the widget size request.
        
        That way it the scrollbar is needed later there is space for it without
        obscuring the text area.
        
        Change-Id: If4ad912d3d6eb6650ae1c891ffd7fdbbf12c0c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198691
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2026-02-20  Laurent Balland  <laurent.balland@mailo.fr>  [1ce819b051c04d8cfc201687cb62b8675124e4f2]

        tdf#170670 NumberFormat: fix blank width string treatment
        
        In case of 2 characters string text,
        with a delimiter as text and a blank width string like
        "-"_)
        the delimiter is now treated as text
        
        Add qa test with format of bug report:
        [>0]#,##0_);[<0](#,##0);"-"_)
        
        Change-Id: Idd4542bd186c6b6b348f6716bee2fd5055f2c83f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199314
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit fb07ca38af165b1e367aea04aa626e073b341c8f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199416
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 65fb77dc2c469370bd8486da662d8651f01ada15)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199797

2026-02-20  Justin Luth  <justin.luth@collabora.com>  [511b979fc48ecbd3a14529cdeba382edc22d3162]

        tdf#169487 tdf#169705: docx export: invalid values in a:chExt / a:off
        
        MS Office is not accepting values greater than 2147483647
        for 'x' and 'y' attributes inside a:off,
        or 'cx' and 'cy' attributes inside 'a:chExt'
        
        MSO was reporting those documents as corrupt.
        Specifically, attachment 72701 from bug 59153
        'WAD-Lab Manual.docx' aka fdo59153-1.docx
        
        Change-Id: I67dd47781098b0dfe9d12f75f591138d0e80c2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199569
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 55507043004d55816cdc238733a9f5c7a2240f2d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199582
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f5f9ab2ae10e05e07330cee765baa949a619e294)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199669

2026-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [4c656548afeda1bd5a2903b22a001fa24a8e6430]

        tdf#170910: exact match can also be rotated
        
        For Microsoft XPS Document Writer printer, the paper list is very
        logn, and contains duplicates (e.g., two portrait Letter), as well
        as rotated variants (e.g., landscape Letter).
        
        The code that looks for matching paper in setPaperSizes would find
        all elelemts with matching Paper value, regardless of orientation;
        and would use the last match. It happened, that for A4 and Letter,
        the last matches were landscape, so the perfect portrait-oriented
        matches would get skipped.
        
        This change checks orientation for exact matches as well; and will
        prefer the first found best match.
        
        Change-Id: Iaa93292ef60b94ab1f807b21e8a3494099c0b002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199841
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit d8a3c74a10e70bae243162cb08572a9c2f2552a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199889
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [9e54023fe79f6dc800050f0d8f133606c7f3157d]

        tdf#162488: do not assume printer drivers only providing portrait paper
        
        This assumption is false e.g. for Microsoft XPS Document Writer, where
        both portrait and landscape paper are in the list. The orientation and
        the size of the paper must be detected from the dimensions.
        
        Change-Id: Ibcfc68f64243ec144743a385f73586ca67f0cbe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199824
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 6171ccd8e6a4ee668fa526f8351e1b4e4fa0a0e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199877
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9b3401e8bfba1dc24b706dc1158cf40d662157bf]

        update credits
        
        Change-Id: Ib8574a58a0a4771296fe77aee9790ff857b222ba
        (cherry picked from commit 071b56225096e3fe053b2ccedcd4ced7bd71ec96)

2026-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [5b29b24af5c9ec8c7685d164e6c5038970f26eab]

        tdf#170892: don't call updatePageSize too early in printer selection
        
        It will be called in SelectOrientationHdl and SelectPaperSizeHdl.
        
        Change-Id: I9e288de2bf4568ef6afaeaf2bc9259d4eadc5918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199708
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199777
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199840

2026-02-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bca39a86c0a47064a443253d9719cbc4a0e8dd0]

        tdf#167636 GetOutputString should be using the scanner from LanguageData
        
        and not the shared one, bubble that around more explicitly
        
        Change-Id: Iff6462dafd2baa75253ad9929f9cbf53a178e9b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 693f44f9238a5cebee074fbe901687ac59a342f7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199806
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-20  Miklos Vajna  <vmiklos@collabora.com>  [2196b77d242e2422eb13ccd0b176f7ee4e5dd293]

        vcl: fix crash in Window::GetOutputSizePixel()
        
        gdb on the crashreport core dump:
        
        	#0  OutputDevice::GetOutputSizePixel (this=0x0) at include/vcl/outdev.hxx:324
        	#1  vcl::Window::GetOutputSizePixel (this=this@entry=0x5479f1e0) at vcl/source/window/window3.cxx:90
        	#2  0x0000733bcba58cca in vcl::RoadmapWizard::ImplPosCtrls (this=0x5479f1e0)
        	    at vcl/source/control/wizardmachine.cxx:135
        	#3  0x0000733bcba5c25d in vcl::RoadmapWizard::ImplHandleWizardLayoutTimerHdl (this=0x5479f1e0)
        	    at vcl/source/control/wizardmachine.cxx:129
        	#4  vcl::RoadmapWizard::LinkStubImplHandleWizardLayoutTimerHdl (instance=0x5479f1e0, data=<optimized out>)
        	    at vcl/source/control/wizardmachine.cxx:127
        	#5  0x0000733bc8df817d in Scheduler::CallbackTaskScheduling () at vcl/source/app/scheduler.cxx:585
        
        and
        
        	(gdb) up
        	#1  vcl::Window::GetOutputSizePixel (this=this@entry=0x5479f1e0) at vcl/source/window/window3.cxx:90
        	90      Size Window::GetOutputSizePixel() const { return GetOutDev()->GetOutputSizePixel(); }
        	(gdb) print mpWindowImpl
        	$2 = std::unique_ptr<WindowImpl> = {get() = 0x0}
        
        I.e. this is similar to commit e66599cc396a79e4fc0f59ee256148bc00ca6e15
        (vcl: fix crash in Window::ImplInvalidate(), 2025-11-18), you can't
        assume mpWindowImpl is a non-nullptr here.
        
        Change-Id: I09c93f568c96cf52369f4eef1798c84f230b880e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199556
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8f763a7644fc03eec6d723cb45945015c3f9832c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199561
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 8dd7dede5a54e36edb26c28391a1bd6f8265179f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199696
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f5dd322b21cc288f14dae5537ca29f55b299e71]

        zlib: upgrade to 1.3.2
        
        * werror-undef.patch partially reverts
        https://github.com/madler/zlib/commit/7108497fda9d4536a1afade7f42266e06dca4488
        so the build doesn't fail with
        In file included from /mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/workdir/UnpackedTarball/zlib/zlib.h:37,
                         from /mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/sal/rtl/crc.cxx:24:
        /mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/workdir/UnpackedTarball/zlib/zconf.h:446:5: error: "HAVE_UNISTD_H" is not defined, evaluates to 0 [-Werror=undef]
          446 | #if HAVE_UNISTD_H     /* may be set to #if 1 by ./configure */
              |     ^~~~~~~~~~~~~
        /mnt/4d311c06-5193-4f61-a3f6-53ca4d9ea1e1/libreoffice/workdir/UnpackedTarball/zlib/zconf.h:450:5: error: "HAVE_STDARG_H" is not defined, evaluates to 0 [-Werror=undef]
          450 | #if HAVE_STDARG_H     /* may be set to #if 1 by ./configure */
              |     ^~~~~~~~~~~~~
        cc1plus: all warnings being treated as errors
        
        Change-Id: I8f1dbaf627a573b9a5ff8c9f20061ec482b87c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199616
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 47edd83c63fee752404623553400a4754307bc30)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199630
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba56d1f0c9ece5df2f17e7166b4ee89155e54c43]

        tdf#170298 handle out of range value in EDATE function
        
        otherwise the code will get stuck in an infinite loop
        
        Change-Id: I5715df3e462f7cbde24bd6237fbd58d4c685272f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199525
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 08f940a22d202bb5ddc7d6d9be8c05275160b5e9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199688
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 16c5aa0d23f8834f7af9de3498188ef044416a35)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199784

2026-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [330fae366e018c9c24433b741a5fc666b82e3494]

        tdf#170681 qt avmedia: Don't fall back to QtFrameGrabber unless enabled
        
        Due to issues with QtFrameGrabber,
        
            commit 08533ca4e2526644b803c40c0c3d3c96f43762af
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 2 17:52:19 2025 +0200
        
                tdf#166055 avmedia qt: Use GStreamer frame grabber by default
        
        switched from using QtFrameGrabber by default to using
        the Gstreamer-based grabber by default.
        
        Since then, QtFrameGrabber is only used if either
        of these is true:
        
        1) explicitly enabled by setting the
           SAL_VCL_QT_USE_QT_FRAME_GRABBER environment
           variable
        2) no GStreamer-based grabber is returned by
           createPlatformFrameGrabber
        
        The tdf#170681 scenario of dragging and dropping
        an audio-only file from the gallery in Impress
        shows that 2) is also reached then because the
        preferred size of the audio-only file in
        Player::createFrameGrabber is empty, and thus no
        frame grabber is created.
        
        This apparently (at least in some configurations) results in
        the QtFrameGrabber problems like crashes that the
        above-mentioned commit was supposed to avoid,
        until they get addressed a different way.
        
        Therefore, adjust the logic to only create a
        QtFrameGrabber when explicitly enabled, i.e.
        for 1), but no longer for 2).
        
        Change-Id: Ic95303e812819a9c432543992773b334995ddd31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199356
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d7d542b198d4edb3938b69ff31f07c1b2d0d0fb4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199480
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae6f6d0fb76148fba88420504421b8d34ae9ec9f]

        Resolves: tdf#170463 width request of preview changes during editing
        
        so on clicking "1-10" and then increasing the "width" spinbutton
        value grows the width of the preview, increasing the width of the gtk
        version and crushing the content of the gen version.
        
        Shrink the width of the level selection area to it's natural width.
        Increase the initial width of the preview area by 50% to give it more
        space and stop resizing it on changes.
        
        Change-Id: Iec19b1ced2ec035740f5a173bb6c774fdd70efe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198917
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-19  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [0e138d248294007b50128a62aee08860ffda8845]

        tdf#168227 EMF+ Fix implementation of SetPageTransform
        
        The implementation of SetPageTransform was incorrectly overwriting mnMmX and mnMmY
        with calculated pixel values.
        
        These variables represent the Reference Device size from the EMF+ header and should
        remain constant. Overwriting them causes mappingChanged() to calculate an incorrect
        transformation matrix, as it relies on the original ratio between reference
        millimeters and pixels. This led to incorrect scaling and cumulative errors
        if multiple SetPageTransform records were present in the document.
        
        This patch ensures that header constants are preserved and the Page Scale
        is applied as a separate step in the transformation pipeline.
        
        Change-Id: I7a957f57894cc079292e8f93c119dd0fdb456fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199380
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit 8b002437fbe29d5bac7ab0358a4e838a140d4e3c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199408
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-13  Patrick Luby  <guibmacdev@gmail.com>  [3561aecabc5119bdbedd2dbd03707385e3335d6e]

        tdf#170149 Fix clicking on a character in the input method's popup window
        
        [self setMarkedText:selectedRange:replacementRange:] does not
        get called on macOS Tahoe. So when pressing and holding a key,
        the original character would never get selected and clicking
        on a replacement character in the input method's popup window
        would fail. Surprisingly, pressing a replacement character's
        number still worked.
        
        Also, make the following scenarios behave as close as possible
        to the TextEdit application whether or not there is any arrowing
        into the input method's popup window. I tested with Canadian and
        Japanese - Romaji keyboards:
        - Pressing the Escape or Return keys commits uncommitted text
        - Pressing the Delete key discards uncommitted text
        - Pressing the Backspace or Fn-Delete keys commits uncommitted text
        
        Change-Id: I7c3fdfecb4d1979d38e9f652bea8c7d66e6c9612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196239
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197054
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8e4041fa99196867b9c01576a3741f21583ecd51]

        update credits
        
        Change-Id: Ibb6000f99276ce4622e58d5144ffef1969694517
        (cherry picked from commit 71a936ab275c44e56db2dd9e9a9916b10ea70900)

2026-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [980f0d2a6a40082873e5b8a6428835fe042bd5ea]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 263c9c51093d0badfdea1595da76240456dd1c20
          - update translations for 25.8.5 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I2d2ffc7b356cc2ce8570ef25460c9c5e4e654e31
            
2026-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [63f6e03f0b0231bd140a7e74be7ea85e08ba0fef]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 011f1cd650749cb035ed377301f9e25c718ee76f
          - update translations for 25.8.5 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I00e90971096a8d9979c14d80e3e4111b4dc0671c
            
2026-02-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0d5883c5b11b331ce81987288d0d13b41bdf104]

        Update git submodules
        
        * Update dictionaries from branch 'libreoffice-25-8'
          to 483309d8f7f63b84551713c4856209ad9c551359
          - Upgrade Mongolian dictionary to 2026.01.18
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2026.01.18.zip
            
            Change-Id: I8820699b5b14133736f7908e50ac63863db81e64
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/199025
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            (cherry picked from commit cc1c1c0dee15dffd4e8e76a05d6445a80b5ea06a)
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/199027
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2026-02-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f9873e2773231c6fabcdb76995e386e2645aa07]

        postgresql: upgrade to 15.16
        
        Downloaded from https://ftp.postgresql.org/pub/source/v15.16/postgresql-15.16.tar.bz2
        
        Change-Id: I49833398147b87ed7c94e281f1d336756f26c0a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199292
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2026-02-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c78198dac2abb5bbabd2c98961503cdb10e8d992]

        Resolves: tdf#168710 don't use dark/light bg color when printing chart
        
        Change-Id: I0291a86744a5aa248a4174aa9e40aa646ddd0350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198910
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-12  Miklos Vajna  <vmiklos@collabora.com>  [ab78ef87b3351126613aff11147162465442c951]

        sw: fix crash in lcl_GetSwUndoId()
        
        gdb on the crashreport core dump:
        
        	#0  SwNodeIndex::GetNodes (this=0x0) at sw/inc/ndindex.hxx:117
        	#1  SwNodeIndex::SwNodeIndex (nDiff=..., rIdx=..., this=0x7ffc29a667f0) at sw/inc/ndindex.hxx:67
        	#2  SwNodeIndex::SwNodeIndex (nDiff=1, rIdx=..., this=0x7ffc29a667f0) at sw/inc/ndindex.hxx:65
        	#3  lcl_GetSwUndoId (pFrameFormat=0x53c5c4e0) at sw/source/core/undo/undobj1.cxx:409
        	#4  SwUndoDelLayFormat::SwUndoDelLayFormat (this=this@entry=0x5477eb40, pFormat=pFormat@entry=0x53c5c4e0)
        	    at sw/source/core/undo/undobj1.cxx:426
        
        I.e. it's possible that in lcl_GetSwUndoId(), rContent.GetContentIdx()
        returns a nullptr, so we can't unconditinally dereference that. Return
        early with a SwUndoId::DELLAYFMT in that case, matching what would
        happen if we would get a content index, which is not a graphic or OLE
        node.
        
        Change-Id: I0e6506ffc1506afe616d637571b181d2d6751e1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199123
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 85415041a469cee0389244276dbd0035f81861a0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199142
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5fe21951da1ffa9bffb9be4df8a5c2a37bb9ee3b]

        extend exotic protocol list
        
        Change-Id: Ie6df4dd171118ff53596bfc058223ea1f15c9e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199201
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2026-02-11  Weblate  <noreply@documentfoundation.org>  [98ad32fb3a2cdbd1ddd17f351f438c44aa76c6da]

        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ic14f23ce228c59f7d0d999826801c17db0b1b12e
        Co-authored-by: Adam Rak <kitynska@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/pl/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199093
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-10  Andras Timar  <andras.timar@collabora.com>  [a41e93d479a487e3527cfdfea1d73e01f96e2944]

        tdf#126965 emfio: fix opaque background on underlined text...
        
        when BkMode is TRANSPARENT
        
        In DrawText, the font's fill color was unconditionally set to maBkColor
        before checking the background mode. When BkMode is TRANSPARENT, VCL's
        underline rendering uses the font's fill color directly, ignoring the
        transparency flag, causing an unwanted opaque background behind
        underlined text.
        
        Set COL_TRANSPARENT as the fill color when BkMode is TRANSPARENT, and
        only use maBkColor when OPAQUE.
        
        Change-Id: I0e94d2a1beae8ce2feecb0f7c0f8e03b36d2d80a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198889
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit eddbe3b36d257ca2163c9e971fff47e29ccc0ccf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198919
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit b6a3a10140708380dc98a3ecb7437ac976bca393)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198950

2026-02-10  Miklos Vajna  <vmiklos@collabora.com>  [3289c19f5ef2d7d974886bd955777791976e9d66]

        sd: fix crash in AnalyzeRenderingRedirector
        
        gdb on the crashreport core dump:
        
        	#0  0x000071590be5da30 in o3tl::cow_wrapper<OutlinerParaObjData, o3tl::UnsafeRefCountingPolicy>::operator-> (this=<optimized out>)
        	    at include/o3tl/cow_wrapper.hxx:331
        	#1  OutlinerParaObject::Count (this=0x0) at editeng/source/outliner/outlobj.cxx:168
        	#2  0x00007158fd9ccb0a in sd::(anonymous namespace)::AnalyzeRenderingRedirector::createRedirectedPrimitive2DSequence (this=0x7ffc29a67820, rOriginal=..., rDisplayInfo=...)
        	    at sd/source/ui/tools/SlideshowLayerRenderer.cxx:550
        	#3  0x000071590d4469ee in sdr::contact::ViewObjectContact::getPrimitive2DSequence (this=this@entry=0x560c9e40, rDisplayInfo=...)
        	    at svx/source/sdr/contact/viewobjectcontact.cxx:477
        	#4  0x000071590d447109 in sdr::contact::ViewObjectContact::getPrimitive2DSequenceHierarchy (this=0x560c9e40, rDisplayInfo=..., rVisitor=...)
        	    at svx/source/sdr/contact/viewobjectcontact.cxx:551
        
        I.e. it's possible that in
        AnalyzeRenderingRedirector::createRedirectedPrimitive2DSequence(),
        pTextObject is non-nullptr but pTextObject->GetOutlinerParaObject() is
        nullptr, check for this.
        
        Change-Id: I1013809f134115fbeb56a9962d71380aaee17b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199059
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 7096036e38958a493fef7708677721cb3243bca6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199075
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [7668610fc7e478d4f3924250f6e97d301ab6fe14]

        libpng: upgrade to 1.6.55
        
        Downloaded from
        https://sourceforge.net/projects/libpng/files/libpng16/1.6.55/libpng-1.6.55.tar.xz/download
        
        Change-Id: Ieef76e5e408add87ffdccfbfacbedc3ef58a5aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199022
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit e8572b7d946834c0f7775b0489327f7b9f62c69d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/199052
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>

2026-02-10  Miklos Vajna  <vmiklos@collabora.com>  [ecf1801ade13829b715d31067c43b78a0986b4c5]

        sw: fix crash in SwFrameControlsManager::SetContentControlAliasButton()
        
        gdb backtrace on the crashreport's core dump:
        
        	#8  SwView::GetWrtShell (this=<optimized out>) at sw/inc/view.hxx:433
        	#9  SwFrameControlsManager::SetContentControlAliasButton (this=this@entry=0x53674d00, pContentControl=0x536d7210, aTopLeftPixel=...)
        	    at sw/source/uibase/docvw/FrameControlsManager.cxx:192
                ...
        	#19 0x000071084f165009 in SwWrtShell::GotoFieldmark (this=this@entry=0x552f4880, pMark=0x536d7e00)
        	    at sw/source/uibase/wrtsh/wrtsh3.cxx:227
        	#20 0x000071084f15d56b in SwWrtShell::SwWrtShell (this=this@entry=0x552f4880, rDoc=..., _pWin=<optimized out>, rShell=..., pViewOpt=pViewOpt@entry=0x7ffcab7ca2f0)
        	    at sw/source/uibase/wrtsh/wrtsh1.cxx:2118
        	#21 0x000071084e4a542c in SwView::SwView (this=this@entry=0x552f5180, _rFrame=..., pOldSh=pOldSh@entry=0x0)
        	    at include/rtl/ref.hxx:203
        	...
        	#29 0x000071085b272a05 in framework::LoadEnv::loadComponentFromURL (xLoader=..., xContext=..., sURL=..., sTarget=..., nSearchFlags=nSearchFlags@entry=0, lArgs=...)
        	    at framework/source/loadenv/loadenv.cxx:167
        
        I.e. the document on load may have form protection on, in which case it
        jumps to the first fillable form, and if that happens to be inside a
        content control that has an alias/title defined, we hit this, probably.
        
        The problem is that the SwView ctor is not finished at this stage, so
        the view has no writer shell:
        
        	(gdb) frame
        	#9  SwFrameControlsManager::SetContentControlAliasButton (this=this@entry=0x53674d00, pContentControl=0x536d7210, aTopLeftPixel=...)
        	    at sw/source/uibase/docvw/FrameControlsManager.cxx:192
        	192             const SwViewOption* pViewOpt = m_pEditWin->GetView().GetWrtShell().GetViewOptions();
        	(gdb) print m_pEditWin.m_rInnerRef.m_pBody.m_rView.m_pWrtShell
        	$5 = std::unique_ptr<SwWrtShell> = {get() = 0x0}
        
        Fix the problem by not assuming that the view has a writer shell set,
        which is usually true, except when the view creation is in progress.
        
        Change-Id: Ic7254e1ccbb9fdcafd94c04b829fae21a2322123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198530
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ba5a6c007dfda67463ad9099d493b36e57ddaf4c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198587
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2026-02-10  Weblate  <noreply@documentfoundation.org>  [a5ca6a435a1dd1c6daab78386f65f92e5ceb16de]

        android-viewer translated using Weblate
        
        German currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I4be002996f2b88ff21e7cc942c8ed33e7cf85a7e
        Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/de/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198930
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-05  Saburo Yoshida  <sabr0libo@otkr.jp>  [02fb87b389f0a4db74b149c790ea1b83af177dd4]

        tdf#169590 i18npool: Fix incorrect line breaking in CJK
        
        Since 5a03d511f46ecc05aab35bb29e714b46f5638b1b commit,
        ICU line breaking rules are now honored and Asian typography options
        for paragraph formats are now ignored.
        Respect cases where users apply a list that is different from the
        default forbidden character list, or cases where no forbidden character
        list is applied.
        
        Change-Id: I7d021c1dcb1e9722eb5f7ae6295b949641dcfe01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198442
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit b643c5c0ace3af80e2126a05f4df366d4a3166b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198740
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-02-05  Noel Grandin  <noelgrandin@gmail.com>  [8d97770bbab4b6c12bda84b545d216f813f1e885]

        tdf#168674 Assertion fires when editing a formula in formula bar in debug
        
        on Windows, this assert fires because we have a stack like:
        
         	editenglo.dll!ImpEditEngine::PaMtoEditCursor
        	editenglo.dll!ImpEditEngine::Command
            ....
         	sclo.dll!ScTabView::ActiveGrabFocus
         	sclo.dll!ScInputHandler::EnterHandler2
        
        where EnterHandler2 is disabling layout, but during the focus grab,
        on Windows, some  SalInputContext code is triggered, which then
        needs the layout.
        
        Change-Id: I14b213af57a8e78f3983f0fd96110888906b43d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit f6c809b021312dbda2964aa98beebb872bdbd81a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198704
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-04  Weblate  <noreply@documentfoundation.org>  [46469d2002d6f84283eecd0dbde6eacfdb58e455]

        android-viewer translated using Weblate
        
        Aragonese currently translated at 18.9% (22 of 116 strings)
        
        Change-Id: I74b032a4b05e8f1f26ce4fbd0d68f7ba532678db
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/an/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198680
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2026-02-03  Dan Williams  <dcbw@libreoffice.org>  [e9d9ea41b7a3dc6271b9b7fe173a94e96543030a]

        tdf#169971 fix call order of derived ThumbnailView UpdateColors() method
        
        Derived class' UpdateColors() methods should be called rather than the
        base class method, otherwise the derived classes can't set the colors
        they want. Fixes an error in the patch for tdf#169727.
        
        Change-Id: I2f5828a81f1e4732e171f43d7407244e3f6e25a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195942
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        (cherry picked from commit 5140e19a2d709339a986fa9fa1cf16ec185f444d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196103
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f8f854c580ec77edfee42136679883151128220a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198584
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e78e9550a74fa194b88dfaf0ba5b3cea2945c47b]

        uunxapi.cxx: add pre/postmac headers for sandboxed build
        
        side-effect of dec1441f716c7631622b9b3e32fdbc666502c006 that removed
        unnecessary Carbon.h headers and along with that the premac one that
        would have been applied also to sal/osl/unx/uunxapi.cxx
        
        Change-Id: I058e074d3ba7fb42d1ca70e497c6219820597119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198551
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit ab214fc9f3cd0c69756dbbdf181b3da93069d7e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198558

2026-02-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [0392e0444d682359ed7cad6af1581918b5256866]

        expat: upgrade to 2.7.4
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_4/expat-2.7.4.tar.xz
        
        Change-Id: I7058df85bf0fbac6608b83967b635382859e4db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198521
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 79631c2369df3dcd858abd725bb1c7fd1459652b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198532
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-02-01  Miklos Vajna  <vmiklos@collabora.com>  [f7a0346e41ecad5f2e738264c22c38e06cf9c9c6]

        editeng: fix crash in ImpEditEngine::GetXPos()
        
        gdb backtrace on the core file from the crashreport:
        
        	#5  0x0000000000afc0ee in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
        	#6  0x00007078315a78ff in std::vector<double, std::allocator<double> >::operator[] (this=<optimized out>, __n=<optimized out>)
        	    at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1140
        	#7  std::vector<double, std::allocator<double> >::operator[] (this=<optimized out>, __n=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1140
        	#8  ImpEditEngine::GetXPos (this=this@entry=0x3e8745e0, rParaPortion=..., rLine=..., nIndex=-18, bPreferPortionStart=<optimized out>)
        	    at editeng/source/editeng/impedit2.cxx:4303
        	#9  0x00007078315a79f6 in ImpEditEngine::GetEditCursor (this=this@entry=0x3e8745e0, rPortion=..., rLine=..., nIndex=<optimized out>, aFlags=aFlags@entry=...)
        	    at editeng/source/editeng/impedit2.cxx:3113
        
        and:
        
        	#8  ImpEditEngine::GetXPos (this=this@entry=0x3e8745e0, rParaPortion=..., rLine=..., nIndex=-18, bPreferPortionStart=<optimized out>)
        	    at editeng/source/editeng/impedit2.cxx:4303
        	4303            nPortionTextWidth = rLine.GetCharPosArray()[nTextPortionStart + rPortion.GetLen() - 1 - rLine.GetStart()];
        	(gdb) print rLine.maPositions
        	$1 = std::vector of length 1, capacity 1 = {171.307373046875}
        	(gdb) print nTextPortionStart
        	$2 = 0
        	(gdb) print rPortion
        	$3 = (const TextPortion &) @0x3b3cc250: {xExtraInfos = std::unique_ptr<ExtraPortionInfo> = {get() = 0x0}, nLen = 38, aOutSz = {<SizeTemplate<Size>> = {<SizeTemplateBase> = {<Pair> = {
        		  mnA = 5661, mnB = 344}, <No data fields>}, <No data fields>}, <No data fields>}, nKind = PortionKind::TEXT, nRightToLeftLevel = 0 '\000', nExtraValue = 0 u'\000'}
        	(gdb) print rLine
        	$4 = (const EditLine &) @0x3e968420: {maPositions = std::vector of length 1, capacity 1 = {171.307373046875}, maKashidaPositions = std::vector of length 0, capacity 0, mnTextWidth = 171,
        	  mnStartPosX = 3443, mnNextLinePosXDiff = 0, mnStart = 39, mnEnd = 40, mnStartPortion = 2, mnEndPortion = 2, mnHeight = 344, mnTextHeight = 344, mnMaxAscent = 265,
        	  mbHangingPunctuation = false, mbInvalid = true}
        
        Seeing nPortionTextWidth is updated conditionally, also require to only
        update if the array index would be inside the array bounds.
        
        Change-Id: I98adbc55187f0221534bc358755e51160cdb992b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198436
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d7c2f3dfe78c91cb7610cc71545f822481235595)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198439
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-30  Miklos Vajna  <vmiklos@collabora.com>  [6dbb577716acfcc909d4368109c5d95853bccb4d]

        sfx2: fix crash in SfxObjectShell::PostActivateEvent_Impl()
        
        gdb backtrace on the core file from the crashreport:
        
        	#0  0x00007078323c6c4e in std::__shared_ptr<SfxItemSet, (__gnu_cxx::_Lock_policy)2>::operator bool (this=<optimized out>)
        	    at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1670
        	#1  SfxMedium::GetItemSet (this=0x0) at sfx2/source/doc/docfile.cxx:3840
        	#2  0x0000707832428792 in SfxObjectShell::PostActivateEvent_Impl (this=0x3e357de0, pFrame=pFrame@entry=0x427b7460)
        	    at sfx2/source/doc/objmisc.cxx:933
        	#3  0x0000707832214661 in SfxApplication::SetViewFrame_Impl (this=0x3c0a39d0, pFrame=pFrame@entry=0x427b7460)
        	    at sfx2/source/appl/app.cxx:273
        	#4  0x000070783254804f in SfxViewFrame::SetViewFrame (pFrame=0x427b7460) at sfx2/source/view/viewfrm.cxx:3735
        
        and:
        
        	#2  0x0000707832428792 in SfxObjectShell::PostActivateEvent_Impl (this=0x3e357de0, pFrame=pFrame@entry=0x427b7460)
        	    at sfx2/source/doc/objmisc.cxx:933
        	933         const SfxBoolItem* pHiddenItem = pMedium->GetItemSet().GetItem(SID_HIDDEN, false);
        	(gdb) print pMedium
        	$1 = (SfxMedium *) 0x0
        
        Assume that no medium means the same as medium having no hiddem item.
        
        Change-Id: I6295cfd90d2a3d529fa5e915983578e6768a2244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198357
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 01d66be56971875a690f3e698093492e39485efa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198403
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [806d09e511ad82dc6c4b801b9ce9ee83cd201ed2]

        bump product version to 25.8.6.0.0+
        
        Change-Id: Iea78e063276605495d7efe37e94258d9c6109300

2026-01-28  Mike Kaganski  <mike.kaganski@collabora.com>  [01e4b2008da867ed85982cfb0b62ee1be51ae741]

        tdf#168054: Export all ODG pages to SVG from command line by default
        
        Regression from commit 58ba249df589b0c9f91667f2938bfa18d2a1ce61, which
        fixed obtaining controller, including command line scenario. Before it,
        no controller was found, and mSelectedPages was empty after a call to
        fillDrawImpressSelectedPages. Now the document's controller is found,
        and that puts the first page as the selection into mSelectedPages.
        
        This change uses ConversionRequestOrigin property, added to medium in
        DispatchWatcher::executeDispatchRequests, to detect that the export
        is initiated from command line. In that case, it is assumed that all
        pages should be exported.
        
        I don't really know why the behavior restored in this change is wanted.
        The result is all pages' objects overlapped. Even though SVG markup
        has the pages in separate 'g' elements, it doesn't look reasonable to
        have this result by default. Yet, as it was a pre-existing behavior,
        let's keep it this way for now.
        
        Change-Id: I6d6923e627df4282c61342210ee7d762ea08e2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195003
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit b152ca62b9fdb4a667440ae20e96612dcc12191e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195050
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6cfdd70e9aa72318d13f16fcb69941e5517198b]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 85b126e54b667ad6d5b8165b38688bd9626462d5
          - update translations for 25.8.5 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I7e44407fb8cfb333324c3e3422e04fcb6d0dfa8e
            
2026-01-28  Stephan Bergmann  <stephan.bergmann@collabora.com>  [6cb97ac7feee829b7ecd11ad2e76d4c846d40fd4]

        Avoid float-cast-overflow
        
        ...by completely getting rid of the code exhibiting UB and the helpless
        workaround from 2b27652d2d7bd675fa355fb904755bf5fb312348 "tdf#167892 fix hang
        formatting very small number on windows".
        
        TODO:  It is unclear to me whether using saturated values here is any better
        than using whatever random values came out of the original code that exhibited
        UB.  The whole algorithm probably needs to be replaced with something that
        actually works.
        
        (This was now reported with 4368272648f7264d4a2884db80bf5a100ab9d8ca
        "tdf#167892: svl_qa_cppunit: Add test" as
        
        > /svl/source/numbers/zformat.cxx:2886:52: runtime error: 1e+19 is outside the range of representable values of type 'long'
        >     #0 0x7f3f6da013eb in SvNumberformat::ImpGetFractionElements(double&, unsigned short, double&, long&, long&) const /svl/source/numbers/zformat.cxx:2886:52
        >     #1 0x7f3f6d9f84ee in SvNumberformat::ImpGetFractionOutput(double, unsigned short, bool, NativeNumberWrapper const&, rtl::OUStringBuffer&) const /svl/source/numbers/zformat.cxx:2961:5
        >     #2 0x7f3f6d9e472a in SvNumberformat::GetOutputString(double, rtl::OUString&, Color const**, NativeNumberWrapper const&, SvNFLanguageData const&, bool) const /svl/source/numbers/zformat.cxx:2676:21
        >     #3 0x7f3f6d8c37bc in SvNFEngine::GetPreviewString(SvNFLanguageData&, SvNFFormatData const&, NativeNumberWrapper const&, SvNFEngine::Accessor const&, rtl::OUString const&, double, rtl::OUString&, Color const**, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool) /svl/source/numbers/zforlist.cxx:2147:20
        >     #4 0x7f3f6d8c3ddb in SvNumberFormatter::GetPreviewString(rtl::OUString const&, double, rtl::OUString&, Color const**, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool) /svl/source/numbers/zforlist.cxx:2165:12
        >     #5 0x7f3f6ef90fd3 in (anonymous namespace)::Test::checkPreviewString(SvNumberFormatter&, rtl::OUString const&, double, o3tl::strong_int<unsigned short, LanguageTypeTag>, rtl::OUString const&) /svl/qa/unit/svl.cxx:462:21
        >     #6 0x7f3f6ef67f13 in (anonymous namespace)::Test::testUserDefinedNumberFormats() /svl/qa/unit/svl.cxx:1443:9
        
        <https://ci.libreoffice.org/job/lo_ubsan/3801/>.)
        
        Change-Id: Iff449629ee309f9513af02da9dfdf2505d6fe725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198278
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit aee7b9b8e08531ae01dd30f879c0c0872e60278d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198290
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ae4ca2634a83435a51a8736610a1e6bf7702af6]

        crashreporting: fix crash in SvxAppearanceTabPage::SvxAppearanceTabPage
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/ed1c2ca4-f71b-441a-8bf6-48fd965bdb77
        
        Get "Automatic" string using CuiResId instead
        
        Change-Id: Ib973e0139685c4e270a084fb9e878db8c14aace2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197111
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 7acfec5a8ad8534d4177750aa5b110b16b53378c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197177

2026-01-28  Justin Luth  <justin.luth@collabora.com>  [5fe1c8aa84506a9fa530d50034fc997c2a042357]

        tdf#170119 writerfilter: cont-sectPr w/ pgbrk == emulate bottomSpacing
        
        Technically this is a 25.2.6 regression from my
        commit 74c29345a7c179b048c157582a1145e381616e5c
        tdf#167657 writerfilter: only move sectPr bottomMargin after pageBreak
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188298
        
        It was just lucky before that it worked for that particular instance,
        and it only worked since 25.2.4...
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf170119_bottomSpacing
        
        Change-Id: I9d0ae90087d79887489357eaa00eeabe53bcb58c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196205
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 582c032aaa4524abf5b5a630400cf7ecdc2acf8a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196247
        (cherry picked from commit ed5aaa03906807c93fe6847f66f847007777174d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196869
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-28  Balazs Varga  <balazs.varga@collabora.com>  [eaaf3693cfb633777e924e2fea4222aa1ac22c8a]

        Related tdf#170027 - Crash when undoing shape drag with Alt pressed
        
        Partly revert and follow up of 0dc03683f9536123327963c170203addb8408930
        Since the shape names can be empty, better to not check the two shape
        names, otherwise the Alt drag will not work with those shapes. Since
        the alt draged shape is cloned, so a new shape was created, nothing else
        can be checked that the cloned and the original shape is the same or
        not. So just avoid crash at undo for the moment.
        
        Change-Id: I6cb86d776ddc9643919b9399bb2987b19d8bccf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196655
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen@collabora.com>
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit b10b28b6575b387ea4a7a0b91283690610158a2a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196831
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-28  Miklos Vajna  <vmiklos@collabora.com>  [74f710e13cc909e1f96bacf9333cf79034181c7d]

        sw: fix crash in SwXTextDocument::getDocumentSize()
        
        gdb on the crashreport core dump:
        
        	Program terminated with signal SIGSEGV, Segmentation fault.
        	#0  SwViewShell::GetLayout (this=0x0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1665
        
        and
        
        	#0  SwViewShell::GetLayout (this=0x0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1665
        	#1  0x000078c9268a799d in SwViewShell::GetDocSize (this=<optimized out>) at sw/source/core/view/viewsh.cxx:2320
        	#2  0x000078c926ca55e8 in non-virtual thunk to SwXTextDocument::getDocumentSize() () at sw/inc/unotxdoc.hxx:444
        	#3  0x000078c933bc4e16 in doc_getDocumentSize (pThis=0x8e8cc20, pWidth=0x7ffdd9b4c5e0, pHeight=0x7ffdd9b4c5e8)
        	    at desktop/source/lib/init.cxx:4626
        
        Fix it similar to what SwXTextDocument::setPart() does: don't assume
        that we still have a view shell by the time getDocumentSize() is called,
        a document teardown may be in progress where we still have a model, but
        no views anymore.
        
        Change-Id: Id2f5ac4bf08601a9664909f5a78322bf41998a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197062
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2771d029ccc9794e748a930bfcb2ff7ca6b132c1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197088
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c042cd362ea5697b893eaf74f3815e3f0b9463ec)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197127

2026-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce019c56e902b5c5115b31c21163a4daa14dd006]

        crashreporting: check xTextDoc in ExportContent_()
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/b4091e21-8d8c-48e8-818b-f05ac0aff040
        
        Change-Id: If5aaf56724331ec92c85dac2f8b5ce4ba55e4143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197935
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 6920e84063ba52955d0edb2169aa4c728881397e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198009
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae42171b7db3e867ea0009783e68bf8316804e8f]

        openssl: upgrade to 3.0.19
        
        Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.19/openssl-3.0.19.tar.gz
        
        Change-Id: Iffbfbf7c8d248b6f68e0b77613aca697190b98a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198217
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>

2026-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9208d74bcd7be6eec7791c4b864703d84df70744]

        tdf#167892: svl_qa_cppunit: Add test
        
        Change-Id: I56925b648518c8e3399e534e3c82eb9bc0bfa335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198192
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198200
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198203

2026-01-27  Noel Grandin  <noelgrandin@gmail.com>  [d0ea93173be54ea7aaa5f87dc4542ff5e0dd0922]

        tdf#167892 fix hang formatting very small number on windows
        
        Workaround undefined behaviour where llvm/gcc produces different
        code from MSVC, resulting in oscillation in this algorithm.
        
        regression from
          commit 44d17f8feca372acd41142d1b607d3360282bf30
          Author: Eike Rathke <erack@redhat.com>
          Date:   Tue Oct 13 21:41:45 2020 +0200
          Resolves: tdf#137453 Implicit conversion from sal_uInt64 to sal_Int32 is bad..
        
        Change-Id: I486e8caabcbf582cf94b47547efc89d1b206503e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198163
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198199
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198202

2026-01-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [daa3ae023917507e592415e8336b3a7e3de3687f]

        update credits
        
        Change-Id: I4fa0398e403d983e21e82390a19aa9b9992a9da7
        (cherry picked from commit 9807b7af87cb6ef4b78ebec7bb6cf17b9515521e)

2026-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3537eeaf33bf69e8cf52e0c2ada414c0fddddc77]

        crashreporting: check xObj
        
        like it's done a few lines above
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/978290ff-67d0-4ad4-afdc-b1e79a58b7c2
        
        Change-Id: Ic890513ba6f87b4172966ea004496cbaa755b2a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197941
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 0dde33310b5c53b42e56850422a36273e7d5f7e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198013
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-01-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [67ee916d32527ccb6e5aa0930d6aec463e665f3d]

        meson: allow building with the older of two installed versions of VS
        
        meson always queries for the -latest -prerelease version of Visual
        Studio using vswhere, ignoring the selection done in configure. This
        then clashes when trying to build with an older version of the compiler.
        
        That's an obvious hack that only works with the provided version of
        meson and a better fix would be to make that a meson commandline option
        or allow passing it via the ENV/have it guess from CC/CXX or similar.
        
        adjusted for different supported compiler versions on 25-8 branch
        
        Change-Id: I9bcbe26d9b1518b5effbf0be99329b8d2d4a0262
        (cherry picked from commit b1704fca1771c4a6697929461474ede69622c1cf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197944
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2026-01-27  Aron Budea  <aron.budea@collabora.com>  [b0510011e9857f418c02b838d9fdb5769a912c70]

        Related: tdf#169441 sw: Make old list bullet config load properly
        
        The load mechanism wasn't working correctly, and wouldn't
        load configured items, let's fix that for now.
        
        25.8 only, code will be rewritten in later versions.
        
        Change-Id: I142608eafb6275c69457067f249d7b5c52570c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197786
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2026-01-27  Aron Budea  <aron.budea@collabora.com>  [e3cfd5ead80eae2fa9f831079ee82a1e3b850012]

        tdf#169441 Revert "Use configured bullet symbol when clicking
        
        ...bullets button"
        
        Only in 25.8, return to old behavior.
        
        This reverts commit 626357f53c934e7f57dc80c3c83ad080767961f3.
        
        Change-Id: I24d12f12b4595adb428ce20b0ea3e748a23023bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197785
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2026-01-27  Aron Budea  <aron.budea@collabora.com>  [f9a643c8a650a07fa207b06f28e1514d2251ee1a]

        Revert "tdf#166229 sw: make bullet style change again...
        
        ...with list indentation level"
        
        Only in 25.8 to address tdf#169441.
        
        This reverts commit d32dd7675b36952dd38e6c9b7d280ff2c4008404.
        
        Prerequisite to revert 626357f53c934e7f57dc80c3c83ad080767961f3.
        
        Change-Id: I0e4aabf08a2ca4fcb63ff137a1a7937c0a3118f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197784
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2026-01-26  Regina Henschel  <rb.henschel@t-online.de>  [7dcefb46daff41549a178bb1ae24229d09261a88]

        tdf#159544 use top of parameter stack for COUNTIFS
        
        The evaluation of the fooIFS functions attempts to reduce the range to be
        examined so that empty cells at the end of a range are not examined. To
        do this, it uses the range at the bottom of the parameter stack. That
        works well, for example, with SUMIFS and AVERAGEIFS, because this range
        does not have an associated criterion, but instead contains the data to
        be summed up.
        
        In the case of COUNTIFS, however, all ranges have an associated criterion
        and such might query for empty cells. At the point in the process when
        the reduction takes place, the criteria are not yet known. Therefore,
        when the criteria are later resolved, the reduction is reversed in case
        the criterion queries for empty cells.
        
        The evaluation of ranges and criteria starts at the top of the parameter
        stack and goes then backwards. That means that the reduction was based
        on the range at the bottom of the stack, but the reversal of the
        reduction was based on the criterion at the top of the stack.
        
        The solution is to use the range of the parameter at the top of the
        stack to calculate the range reduction in the case of the COUNTIFS
        function.
        
        Change-Id: Ia451312b83ab73f52020edd204fb2e37997714e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198058
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 709bb398d0ed123e9bf52b98b46f27418bbddef5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198128
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-23  Miklos Vajna  <vmiklos@collabora.com>  [65803bb4c33d675fe357221f7c9102e5b3db6971]

        chart2: fix crash in OfPieChartDialogController::fillExtraControls()
        
        gdb backtrace on the core file:
        
        	#8  chart::OfPieChartDialogController::fillExtraControls (this=0x23c15020, xChartModel=..., xTemplateProps=...)
        	    at chart2/source/controller/dialogs/ChartTypeDialogController.cxx:841
        	#9  0x0000719b38a2076f in chart::ChartTypeTabPage::selectMainType (this=0x23948420)
        	    at chart2/source/controller/dialogs/tp_ChartType.cxx:272
        	#10 0x0000719b3b656103 in Link<weld::TreeView&, void>::Call (data=..., this=0x1fd52058)
        	    at include/tools/link.hxx:111
        
        and:
        
        	(gdb) print aValuesSeries
        	$1 = std::vector of length 0, capacity 0
        
        But leave the assert in place, so we have a chance to find the deeper
        problem in a debug build.
        
        Change-Id: Ic590c777a0a6fbe5fd188b6600c1de908c9a0910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197926
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 6126ef73a40675943b882f3e5b5e6c155485e68d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197948
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fb26dc53132bdd298b323d81f030f27884a4e363]

        tdf#166803 – wsl-as-helper: fix cross-compilation to aarch64
        
        649314399483331244538128149ebd0556166540 did fix building on aarch64
        natively, but in turn broke cross-compilation
        
        the problem in tdf#166803 is reproducible with VS2019, but not with
        VS2022, but that cannot be installed on our old baseline and in turn
        new baseline is using the wsl-as-helper method.
        So the patch is needed on the branch as well.
        
        Change-Id: I1c9a4eabe1489b3c4bab5c07cd1e62fe29992530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192910
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit 7855c25da38686ddcccb7feb8410f04ed620bc34)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197803

2026-01-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a17638c49ec623b3a385b5f3c32a15cae069af2f]

        tdf#169371 bundle visual studio crt on windows aarch64
        
        turns out that the merge module for x64 file actually also
        contains arm64 versions of the dlls.
        
        Change-Id: I8d8f5c848201eea28c95e62eebf4baca31f292d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197829
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 1b8f881bfd25ff3ca9d2ba937a6be43a9c7bfbd8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197910
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [78d7875ae1712e9d8f0ccaff5e45ad0d628c4060]

        NotoNaskhArabic: upgrade to 2.021
        
        Downloaded from https://github.com/notofonts/arabic/releases/download/NotoNaskhArabic-v2.021/NotoNaskhArabic-v2.021.zip
        
        Change-Id: I92276268401e3c18c49708329985bfa792dbcb69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197453
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f4bc7693009eb181844aed884281655637f118ad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197477
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9260fcd78ac7a8df87244521990805bd39df81ea]

        background color should start initialized to COL_AUTO
        
        Change-Id: I09ad8f22f7ea6236d4a0b2a842571c32c2d0684b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197743
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-23  Pranam Lashkari  <lpranam@collabora.com>  [e0ecd933786861afb8f479c621a052a1f29ab997]

        editeng: for automatic font color also check char background
        
        problem:
        in automatic color we only check doc color and background color(i.e: cell color)
        text can also have highlight color which also should be taken
        in cosideration when chosing automatic color
        
        Change-Id: I3689baa5cc95bc8d3b855251ae92c91a82102db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196403
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196604
        (cherry picked from commit c1e5d16513b663b86d62a3eeceda2c0c6cf0b23c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197742
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e2dfcfc0a15d45c8c9000b4e6b7883b2bf261c7]

        crashreporting: check GetViewShell()
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/a6b63eaa-ffe7-400e-8363-8c5dc665d59f
        
        Since
        commit 01b1e0f172c1912dac24337692d85a9caf637d9a
        Author: Heiko Tietze <tietze.heiko@gmail.com>
        Date:   Wed Mar 26 09:52:55 2025 +0100
        
            Resolves tdf#84375 - Commands to protect image size and position
        
        Change-Id: I75b7b82d369cad58e1e4ee0528be30399c9bb619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 10ce0a8084f94a00904d5d838a2a0df47a5be2ba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197698
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [45a9cfbbbd9e8d00d64e3945c300096d95965307]

        Revert "officeotron: tabIndex=-1 is invalid"
        
        This reverts commit 1bc98666e33c608d81c75fedcd51bba3745a32ed.
        
        It appears that the tabIndex==-1 is us deliberately disobeying the
        spec so that we can round-trip a value that MSOffice does not
        really care about.
        
        See
          commit 52d5f2e247e6b0a638fc0ec83f5dbc1cca30d1cd
          Author: Justin Luth <justin.luth@collabora.com>
          Date:   Wed Jan 25 16:29:55 2023 -0500
          tdf#151548 sw content controls: preserve tabIndex val="-1"
        
        Change-Id: I1383386ebc3d4d3f47ba427f33aa22215f10ac8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197794
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 21bba2556bb5b0476546142109045ba11107d61b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197852
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-22  Regina Henschel  <rb.henschel@t-online.de>  [5934e0cd11af994a095658ebbdf82cf21e419a79]

        tdf#170295 no reduced range if look for empty cells
        
        It solves tdf#170388 as well.
        If a query is horizontal, then the range the user has specified in the
        function is reduced to the columns, that are actually used in the
        sheet. This 'actually used columns' is a global known value of the
        sheet and need not be newly calculated for evaluating the function.
        
        This behavior is meaningful for performance reasons, for not to
        compare with cells known to be empty. But the query will return a
        wrong value if it queries for empty cells and the query range covers
        empty cells, that belong to columns that are not used.
        
        The patch distinguishes now between looking for empty cells or not,
        and reduces the range only in case of not looking for empty cells.
        
        This solves the wrong results of XLOOKUP(;range;...), and
        COUNTIF with criterion '=' and '<>'.
        
        The patch does not fix tdf#159544 because the implementation of
        COUNTIFS uses a different mechanism to reduce the query ranges.
        
        Change-Id: I944072dbe6ecbbf47ea1c1f683ad3ec4930338b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197703
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 4be8d9afe7ace4ef1289218edb92b9d422507c0f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197721
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 99c906812a5a27b440f4f4e90a2318303bf0bf9c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197801

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [0b3e5d686744f4119fc6c194a728a941f92bd9bc]

        officeotron: moveFromRangeStart must have a w:date attribute
        
        so just give it our null date
        
        Change-Id: I22bdd9ffd53dbe7d4608a759dfc9dd93c658f44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197426
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 232b4ff3d530080efe28b8212c44952a625f8bc9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197561
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197651

2026-01-20  Michael Stahl  <michael.stahl@collabora.com>  [4ad768c0d2a327a44f90c46842577cbcf6a4397e]

        curl: disable ipfs protocol, not needed
        
        Change-Id: Ie16206b6e853a130e51fbc664224091090f78ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197473
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit ae9260a063ec51ee87dc7b85d0bd48d982a12b95)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197573
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a61f371ee54ea2535c5333473a320a79bff2a7cb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197657
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 260e768e21a00fc4f8c97d575baef396b9db4d76)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197675

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad0f8a0aa2478cf199b8820c8239a1b4723b2757]

        officeotron: w:shd must have val attribute
        
        Change-Id: Ia4ec654a6ba6c341a89994ac7a5f6e575ae1defa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197591
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 6ebb696bebb04e2296a6dfcba769ec4bd3f8ed88)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197636
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f0cdf8d8412fc5088ac5657bbcc671507476641a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197649

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6719b653145a327e9bf1958f1c3d78a0ff826b2]

        officeotron: attribute signinginstructions should not have a namespace prefix
        
        we end up with
        
          <o:signatureline ... o:signinginstructions="Check the machines!"
        
        where the "o:" prefix on signinginstructions is incorrect.
        
        Just to be safe, when loading, try both the old and the new style.
        
        However, this does mean that creating such data on a new version of LO,
        and then sending it to someone with an old version of LO, this data will be lost.
        
        Change-Id: I3ec366a2de1ba4945aae1ff67656eda0868333e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197427
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit bf5cc0ae565fb3a11c4cb6b081f99f6daea26dfb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197562
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197646

2026-01-20  Mike Kaganski  <mike.kaganski@collabora.com>  [afe5809395480b0da18555092118dcd3a9ea239f]

        tdf#170396: implement SVG export support for dashed lines
        
        Commit b71d9a6d15cfb8a50afdea5ac064f40d84c561f8 (do not apply line dashing
        in drawinglayer (tdf#136957), 2021-04-29) made sure that metafiles pass
        dashing information in LineInfo of MetaPolyLineAction, instead of altering
        the polyline itself. Since SVG export ignored dashing information in
        MetaPolyLineAction, the exported lines were solid since that patch.
        
        This patch introduces respective export support, emitting stroke-dasharray
        attribute. As far as I see, it has exactly the same semantics, and renders
        correctly in chrome and firefox. It also imports OK into Draw.
        
        Ref: https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/stroke-dasharray
        
        Change-Id: Ifb634a4f3608ee5c2c76727ef4416b80f8f90709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197618
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit c103d337bd41eaa44b65accabe978fe542e41d06)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197639
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 1bc488dffee9f5415615c926028b0e95e989ae32)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197656

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e6271ae0979d7c8aa97704a92a7c4dfd60d7b28]

        officeotron: w:r inside w:pPr is invalid
        
        we end with the following in word/header1.xml:
        
        <w:hdr>
            <w:p>
                <w:pPr>
                    <w:pStyle w:val="Header"/>
                    <w:r>
                        <w:br w:type="page"/>
                    </w:r>
                    <w:rPr></w:rPr>
                </w:pPr>
        
        restrict the fix to the case of writing header data,
        just in case I missed some other case somewhere.
        
        Change-Id: I451480a075c55cafd016279d229dbf0698c01265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197425
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 821e808610a9710d4875bff65604f34aacf4a29c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197590
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197647

2026-01-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [d1bb1f2f2c682ae0bac555b9e30bd0d19e624274]

        Revert "tdf#168737 sw interdependent redlines, reject all: fix ignored format redlines"
        
        This reverts commit ebaab7c8aa64102ec7f507501dc421925f5927fb.
        
        Reason for revert: This is causing https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil to fail in libreoffice-25-8 branch with
        ======================================================================
        FAIL: test_reject_all_deletes_all_redlines (trackedChanges.trackedchanges.test_reject_all_deletes_all_redlines)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sw/qa/uitest/writer_tests/trackedChanges.py", line 626, in test_reject_all_deletes_all_redlines
            self.assertEqual(document.Redlines.Count, 0)
        AssertionError: 1 != 0
        
        Change-Id: I844a23a2fb6e30fc34c964edd37d1e47a3ae3f50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197669
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [51579ab2596669a998b91fe2166f393a05564ae7]

        officeotron: ordering of w:startOverride wrong
        
        we end up with
        
            <w:lvlOverride w:ilvl="0">
                <w:lvl w:ilvl="0">
                    ....
                </w:lvl>
                <w:startOverride w:val="1"/>
            </w:lvlOverride>
        
        but startOverride needs to come before w:lvl
        
        Change-Id: Ide251945b312d48101e277970f1a53fc52c8b5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197290
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197648

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [07fd22ccffb15097895eec845f28b8aa0f9b9fed]

        Revert "mso-test: invalid xdr:twoCellAnchor"
        
        This reverts commit 6b9794ea1c6c24d7c48a1b43a9302c51ea607215,
        because
        With this change, now these files are corrupt after a RT
        -forum-mso-en3-23097.docx
        -forum-mso-en4-364124.docx
        -forum-mso-en4-428907.docx
        -tdf104181-3.docx
        -tdf104181-6.docx
        
        Change-Id: Ib3010fbf0868897fbe8d1f325f3ccdd33475cf3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 2a7ee38519d9b1c3db6efe83ccff50a4af0593d2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197641
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [376394b5748ad9e709325b55102aa74d9bbb3fb2]

        officeotron: duplicate w:framePr under w:pPr
        
        we have duplicate data here
        
        <w:pPr>
            <w:pStyle w:val="Normal"/>
            <w:framePr w:hRule="exact" w:h="23" ...
            <w:framePr w:w="9923" w:h="910" w:y="568" ...
        
        Seems like the w:framePr has more useful info, so suppress the first framePr in this case.
        
        Change-Id: I7dfd7ced352b773c63a31e04f9ab0cdc82743942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197287
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197428
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197595

2026-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [afc4cf308b02a65b3396ea2e86296272e10b3c88]

        tdf#167737 chart renders text black on black in dark mode
        
        when there is no chart background and the document mode is to use a dark
        color for the document color.
        
        The intent of this function is to get a color that can be seen against
        the background. So:
        
        a) Always get the background the text is to be rendered on.
        b) We can consult svtools::FONTCOLOR as a potential foreground color,
        but reject it if it will not contrast against the background
        
        Change-Id: If441050423750fdf0a12f07dd686daf8f7e8b165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197109
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197201
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        (cherry picked from commit bb7152a06685c0710759c0a5701e636b192d76a2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197314

2026-01-20  Miklos Vajna  <vmiklos@collabora.com>  [ebaab7c8aa64102ec7f507501dc421925f5927fb]

        tdf#168737 sw interdependent redlines, reject all: fix ignored format redlines
        
        The bugdoc has two redlines: a format and a delete redline. Pressing
        "reject all" in the manage changes dialog doesn't reject the format
        redline.
        
        Seems this happens because of code added in commit
        9c4eef7d809ad7d283860c7b47b0f561aa240906 (tdf#52391 reject/clear
        formatting of format-only changes, 2019-01-29), which argued that
        rejection of format redlines isn't really implemented, so better if a
        "mass reject all" doesn't reject them, unless only format redlines are
        found in the document.  But in the meantime I worked on improving
        support for rejecting format redlines, most recently commit
        47cb60bc534104852a219426e3beb4c714b6cf07 (tdf#167761 sw format redline,
        char props: implement ODF import, 2025-08-18) added ODF import/export of
        these old direct character properties, so it now makes less sense to
        filter out format redlines while rejecting all of them.  Also, the
        matching toolbar button didn't ignore such format redlines.
        
        Fix the problem by simplifying SwRedlineAcceptDlg::CallAcceptReject():
        unless the redline data for the iterator says this item is disabled,
        always add it to the list of redlines, similar to what the "reject the
        selected redline(s)" case did already.
        
        Note that the original 2019 commit was less confusing, as it did change
        the label of the reject all button, but that was removed in commit
        2e1a38ceb6866248ec30f6fe58cd3adc1b910eec (tdf#146893 Rework Manage
        Changes dialog, 2022-01-24).
        
        Change-Id: I69e7247d068cea2a25cd46ad2d5b41fccfa54919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195772
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 8e513d30d1bd4c69e2e155e72f61897fc830adbb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195783
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195793

2026-01-20  Aron Budea  <aron.budea@collabora.com>  [8ff6697fd22764f2b72fc2086fc021fba8965ff7]

        tdf#142693 tdf#169419 sw: Limit page size exported to DOCX
        
        Based on what Word can roundtrip, which is 64K twips,
        even though that size (115 cm) can't be set via the UI.
        
        Officially 2.1.220 Part 1 Section 17.6.13 of [MS-OI29500]
        says 31680 twips, but let's keep to the value that works
        in practice.
        
        Don't adjust size on import, only on export, Writer can
        handle much larger sizes.
        
        446771fe3e91eb7d154e86b9c6a614374110e9ca was related.
        
        Change-Id: I88540e80f4e94fd8fc3703c18d8b151a7bd270e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194843
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit 714c2ee044b31f6974cbedc3f8cb3f80db475afc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197012
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197066

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b976fe00933f97892896d0e9a3f67b82ae807bcd]

        officeotron: tabIndex=-1 is invalid
        
        since the value is constrained by the spec to be unsigned.
        
        Change-Id: I9b40b6fc9634cbe5c0e848ba15c9ce7918b2f067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197291
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197431
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197597

2026-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [42f69aa7cbd2527536bb20c3320646485d23a159]

        officeotron: w:val attribute is required for w:shd
        
        we end up with
        
          <w:shd w:fill="548DD4"/>
        
        I forced a default value of "clear" in the absense of any better idea.
        
        Change-Id: I6e680f18aca3bc71743b42da4e152a664e9d9303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197289
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197596

2026-01-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [43d30b260e3317712aa9af0a8e734ed91a7f846c]

        reuse comphelper::rng::uniform_uint_distribution
        
        see also:
        
        commit 6d9228d6b14d968fa92df3ca018a555f8652e579
        Date:   Fri May 3 14:17:27 2024 +0100
        
            lok: reseed comphelper's random number generator on fork.
        
            Also avoid std::random_device it doesn't work in a COOL
            kit process.
        
        Change-Id: I0ea3607a689632bf75861d367db70ac6c7f40a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 0e439c7289a3a0679929a9baf7ee41c8f31e6d96)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197471
        (cherry picked from commit 2a807666a569930d349b6a1cc2d2cb1e8eca4319)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197598
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-19  Justin Luth  <justin.luth@collabora.com>  [fc8b2dd2520b1f90b01a09867260fd008c3f7b0b]

        tdf#170208 docx import: conjure up a tblInd if none is provided
        
        This has always been wrong for compat14,
        but some documents have accidentally 'looked right' at various times,
        most recently before 25.8.3
        commit a80d7ba9c01c8c5c95bf01960d969b82dc7edffc
        Author: Aron Budea on Mon Sep 29 14:59:18 2025 +0930
            tdf#168598 Fix for tdf#148578 should only apply to RTF
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191587
        
        This patch is based solely on experimentation.
        MS docuemntation gives no indication that it just makes up
        an 'indent from left' when none is provided.
        Even their errata documentation doesn't mention this.
        
        As noted in the bug report, this made-up value
        is different in Word 2024 than in Word 2010.
        Fortunately the 'modern' version is a simple calculation.
        
        make CppunitTest_sw_ooxmlexport8 CPPUNIT_TEST_NAME=testN780853
        make CppunitTest_sw_ooxmlfieldexport CPPUNIT_TEST_NAME=testfdo78886
        
        Change-Id: Iba59184b988a48fe4d7176e6d3b1000870c87dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196625
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit d0fbf21288d27833a3d3c6b95252c68bcedd1d5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197134
        (cherry picked from commit 459530b73eb5650b2c5651a513a2d1e3541e689c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197156
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-19  Justin Luth  <justin.luth@collabora.com>  [10de2a2a1d9fd1fe3bdf93228f9379f4efff110e]

        tdf#170208 docx import: shift table by cell margin, not style margin
        
        This has always been wrong,
        but some documents have accidentally 'looked right' at various times,
        most recently before 25.8.3
        commit a80d7ba9c01c8c5c95bf01960d969b82dc7edffc
        Author: Aron Budea on Mon Sep 29 14:59:18 2025 +0930
            tdf#168598 Fix for tdf#148578 should only apply to RTF
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191587
        
        make CppunitTest_sw_ooxmlfieldexport \
            CPPUNIT_TEST_NAME=testTdf158661_blockSDT
        
        Another nice example was nested-floating-table.docx
        
        Change-Id: Ie4e256dc0651ade8d302bf78646b2a5215414bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196462
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit a63534ef77c620c06d41be9ad29c283fe636bf7f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196587
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 53e53fa279c11ba28829164ca68a159e614368d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197121
        (cherry picked from commit 587c9ea7239d2c715975294d0b1d94b06550e74e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197133
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-19  Miklos Vajna  <vmiklos@collabora.com>  [b16ba5620674b6e3461e9fc9a11cdcf55faa5aae]

        ucb curl: don't verify peer in the isExemptVerifyHost() case
        
        Try to insert a https:// image URL into Writer when the URL's host is
        meant to be not verified, 'curl -k' works with the URL but insertion in
        Writer still fails.
        
        Turns out this is an expired self-signed certificate (in a local test
        env). Mechanism for not verifying SSL certs in the curl session was
        added in commit 2a5c998d4cdfd54ba65b93318292dab542beaabd (allow an
        exemption to be made for a specific host, 2024-08-23), but that results
        in an image insertion failure.
        
        Fix the problem by adapting the ucb/ code to do what
        <https://github.com/curl/curl/blob/470e26ff6eb55e8d18d6fa44104834e9d1f71274/src/config2setopts.c#L375>
        does for 'curl -k', also clear the CURLOPT_SSL_VERIFYPEER option.
        
        With this, inserting https:// images from my local test server works
        again in Writer.
        
        Change-Id: I0c52f6c0c0dfd6ebf0b4081a8088b623935a96f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197093
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2dcc1c95b5a7bebe508178dacdebfb506e7f6f98)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197131
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 50d9606fcff2c73a1a33c151a35fcf5b3d678436)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197167

2026-01-19  Noel Grandin  <noelgrandin@gmail.com>  [ccf6c63c946fa00b04e65d1ad47b25b0367e42ac]

        officeotron: fix order of sub-elements of tblCellMar and tblBorders
        
        Change-Id: I05b4cacb310cdb78f9683cdb0472de383432c6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196974
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a83869739c5ea8c3ac7d2f1515ffdfb874ccc597)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197110
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 8529f19183c6e1605e4334da992fbf094c1fcacc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197139

2026-01-19  Aron Budea  <aron.budea@collabora.com>  [62fe0d02a2fe474e75831a8e9a39b9e0b15ec180]

        sw: fix order of attributes in wp:anchor on export
        
        To match original DOCX in eg. tdf#169802 bugdoc.
        
        Change-Id: Ife68c293508bfed4f2a2b1d130e310390513981e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197312
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit b2dd08c6af51996f9fd2988f060d5c0f08e247c6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197412
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 0b23dd36718844112baf01f771a2d69ed221b770)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197418

2026-01-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [cabded5bde897bf627f1ede3e1835e18fadffd83]

        tdf#168132 Make sure ranges do not show as disabled in Calc's
        
        External Data dialog
        
        Change-Id: I5cc64cea920f778e33f0a3e28e082839ceb8314a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197509
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit c6028a9ce60f25027b2901e9cc03b3a8f8883810)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197520
        (cherry picked from commit 23c58b0b95ba30dbe67ab451f07ddc2ef9e2070e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197554
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [960e315c6ebdf5fb566b20c6a1936db07edc0d2a]

        Don't null-deref if pView is not present
        
        And default to COL_WHITE as view background if not present.
        
        Related: tdf#168710
        Change-Id: I184fb018d16ac83381b689093e751167bad2c2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197222
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1772c60c7a8b31edd1baebf60b0b589dc6d865df)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197254
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit a93fb25df806bb00f60fa652de066ab9420eb732)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197299

2026-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [12b8d0102ac9fca65706b810502610b51f1517ae]

        officeotron: fillcolor is not valid for framePr
        
        because of some generic code adding attributes to the flyAttrList, we end with:
        
        <w:pPr>
            ...
            <w:framePr fillcolor="#FF00FF"/>
        
        inside word/header1.xml, which is not valid.
        
        Unfortunately, the code structure here does not allow an elegant solution,
        we need a new virtual method to be able to get at the flyAttrList and clear it,
        to prevent attributes leaking into elements they are not meant for.
        
        Change-Id: I2bfd6b1afd78e722a29d79cf853a4678b7d0dea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197248
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit f748949b6ffe6e8ef2a7fd27c70669efe8ac3818)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197297
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 71928bd740832dbc75b856252edf999afd678d70)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197315

2026-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [83a0e11957864554bb43ec207701339c0d7e0398]

        crashreporting: fix crash in impl_createReferenceSizeProvider()
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/deb8f144-001b-4f79-9a7b-c0e8dd7d8c55
        
        Most likely after
        commit 76d296f7600bddf0b52fe2bd5522594551f10218
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Thu Apr 10 20:02:01 2025 +0200
        
            fold ChartModelHelper functions into ChartModel
        
        Change-Id: I959b1210254e741ac9dca492f2e70d86e86f3929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197083
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 76ef93a709bde90518b3809f35926aa284082ded)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197130
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-14  Michael Stahl  <michael.stahl@collabora.com>  [b474df5d28696927b3e7c28ba95a51f8d8943cba]

        libpng: upgrade to release 1.6.54
        
        Fixes CVE-2026-22695 CVE-2026-22801
        
        Change-Id: Id7c4c4d2ffa583ca1eeec23720a4ce74b819305f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197183
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 4e63ac95e1cce0c56e0277c6ecdade3ff43d1f96)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197190
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 85624a4ccc76cb300d1e05ebb6b5c69549c989ed)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197263
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b49bf7f726e03cd8c0e8ed1405f2565114438f0]

        officeotron says that o:spt needs to be numeric
        
        Change-Id: I9d2f995d7cdc2feae547b61e60f75ed608277386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197137
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit ad70c58224084f8f390cd01713f8fd03962680d0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197218
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197249

2026-01-13  Weblate  <noreply@documentfoundation.org>  [dc5b4a9905ae307fe5afc8d323439ff95b0b6757]

        android-viewer translated using Weblate
        
        Kazakh currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I9f3381d3663286520acd396a1b565f2de20697ea
        Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/kk/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197202
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-13  Michael Stahl  <michael.stahl@collabora.com>  [11b11141e23a92d8b51c9da8f3537e1cdf4e65d9]

        filter: XSLTFilter: unbreak XSLT2Transformer
        
        Creating the service fails:
        
          java.lang.ClassCastException: class com.sun.star.beans.NamedValue cannot be cast to class [Ljava.lang.Object; (com.sun.star.beans.NamedValue is in unnamed module of loader com.sun.star.lib.unoloader.UnoClassLoader @6ff3c5b5; [Ljava.lang.Object; is in module java.base of loader 'bootstrap')
          at com.sun.star.comp.xsltfilter.XSLTransformer.initialize(XSLTransformer.java:143)
          at com.sun.star.comp.loader.FactoryHelper$Factory.createInstanceWithArgumentsAndContext(FactoryHelper.java:271)
        
        because initialize gets a sequence<any> where the anys are NamedValues,
        but it expects a sequence<any> where the any is sequence<any> where the
        anys are NamedValues.
        
        (regression from commit d22f3b8c787b93c38925adf92af542362dbda3e6)
        
        Change-Id: I4fd13f3e04d79f7646e6bb31c8f0d35efd42ae69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197132
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit d92905f099992c48fc7ec0a6d0be5675d123b833)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197171
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a1e9ea688adec439500011541b36888570d6fc5]

        tdf#170283 crashed when opening a .ppt file
        
        Revert "no need to have duplicate m_nStorageType fields"
        This reverts commit 9a9bb1f212bb7eb40dcf34c15a3422e633fc195d.
        
        Change-Id: Ia471d291ebb99aea47c798cf923d7571711de356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 9b90b680e5703f58146c883fb33972a95951b446)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197163
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-13  Christopher Sherlock  <chris.sherlock79@gmail.com>  [6e473db9183c4c0868a751f5f5860d1d1a5a3128]

        vcl: fix error in ImplLogicToDevicePixel()
        
        In the logic for transforming Bezier curves, the calculation for the
        second control point (aC2) was accidentally assigning to the first
        control point variable (aC1).
        
        This left aC2 uninitialized (defaulting to 0,0) and corrupted aC1,
        causing Bezier curves to visually collapse towards the origin.
        
        Change-Id: I48572679e78146226dd09a011c57609fc1de3794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196520
        Reviewed-by: Dan Williams <dcbw@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 43759b2b1c7a64dfb84b7989490514caffd9ac6a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197165
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f780ef4aec380653b94d27593d8bc724d5ff4c6]

        lcms2: upgrade to 2.18
        
        0001-Mark-some-tables-as-const.patch.1 has been
        fixed upstream
        
        Downloaded from
        https://sourceforge.net/projects/lcms/files/lcms/2.18/lcms2-2.18.tar.gz/download
        
        Change-Id: Ie2191419c63fd6fdb478f91d573630e745a16d2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196926
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196969
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197074

2026-01-12  Weblate  <noreply@documentfoundation.org>  [34266ab7da4af01105be558030e15afa0134c435]

        android-viewer translated using Weblate
        
        Aragonese currently translated at 18.1% (21 of 116 strings)
        
        Change-Id: I365461c6d53eb51151d0c3a8e42058cba17a99b8
        
        android-viewer translated using Weblate
        
        Aragonese currently translated at 15.5% (18 of 116 strings)
        
        Change-Id: I6df2d4fbade86484049a38b1763a05e68778f121
        
        android-viewer translated using Weblate
        
        Kazakh currently translated at 29.3% (34 of 116 strings)
        
        Change-Id: I6687145034f917e246e982abc2a682cd60a5bd67
        
        android-viewer translated using Weblate
        
        Kazakh currently translated at 18.9% (22 of 116 strings)
        
        Change-Id: Ib15caa3f480291d0cf39402121a937aa01555211
        
        android-viewer translated using Weblate
        
        Aragonese currently translated at 3.4% (4 of 116 strings)
        
        Change-Id: I0c69296fdd55d21cb6047f47cf9e691251a40496
        
        Added translation for android-viewer using Weblate (Aragonese)
        
        Change-Id: I7c8da86b4ac8c30e281d9848a320b98b3e59318f
        
        android-viewer translated using Weblate
        
        Kazakh currently translated at 12.9% (15 of 116 strings)
        
        Change-Id: I63d66562b21094c97e5e17213a40361e4319b69a
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
        Co-authored-by: Languages add-on <noreply-addon-languages@weblate.org>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/an/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/kk/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196337
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2026-01-12  Noel Grandin  <noelgrandin@gmail.com>  [3c1fee24964c17533e756941f7caf8cbb730ce5d]

        officeotron: m:e element under m:d is required
        
        Change-Id: I4a0a8e25163565446845baffe6eb5a5556f2abb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196853
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 11642917f6234c02e741c27cd1d5f0d0d0f6206b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196967
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197077

2026-01-12  Miklos Vajna  <vmiklos@collabora.com>  [60703ae071b7fd5b94b426d245980b344d4aa7f5]

        Related: tdf#168751 sw interdependent redlines, format on del: fix del-on-fmt
        
        Open the bugdoc which has a <format>BBBCCCDDD</format> redline. Select
        CCC, press delete: now CCC is only covered by a delete redline instead
        of a format-on-delete redline.
        
        The trouble is in sw::DocumentRedlineManager::PreAppendDeleteRedline(),
        where rCtx.pRedl (format redline) initially covers BBBCCCDDD, but then
        it gets reduced to cover only BBB. We also create a pNew redline to
        cover only DDD. This gives Writer a way to set rCtx.pNewRedl's range to
        CCC without an overlap. The downside is that now reject-all doesn't
        modify the format of CCC anymore, so some unexpected boldness remains in
        the document.
        
        Fix this similar to how
        sw::DocumentRedlineManager::PreAppendForeignRedline()'s rCtx.eCmpPos ==
        SwComparePosition::Inside case works: except there PushData() is used to
        push the redline data "over" (before creating pNew), and here we use
        PushData() to push the redline data "under".
        
        This way UI creates a model where format is always on top of delete (and
        not the other way around), which is useful, since DOCX only has markup
        for that order and ODT explicitly says this order should be used in
        files.
        
        Change-Id: Ida640ad7bb99ed89faef306dac2b840ae3be53f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196918
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit dcccb89dd37cc8fee40d70eec434688a24b7d629)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196958
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 12cad7b5add0c8371be6eec525675cf64383e75d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/197067

2026-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [d09c2665f9ed7bb63f656a63bafcff4bcbad8541]

        crashreporting: avoid divide by zero
        
        Seen in https://crashreport.libreoffice.org/stats/signature/SvImpLBox::Paint(OutputDevice%20&,tools::Rectangle%20const%20&)
        
        Change-Id: Ia909a404181d1c13b8b67a62da2b684024fdfbbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195473
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 9ad42e4fc7d711b4308bcc20b178741536874a43)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195503
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [0a5f8141a5aa37bfdb7c639b18166b1ae547a3b6]

        tdf#169882: revert commit c799de145f7e289f31e3669646e5bd12814e6c5e
        
        (tdf#138518 sw: layout: avoid moving flys forward prematurely, 2021-04-22).
        
        That change made sure that if a fly tries to move its anchor forward, and
        there are more fly frames on this page anchored after this fly's anchor,
        then the anchor was not added to "moved forward frames" list that is used
        to prevent frames from moving backward. (Note that the problem is similar
        to the problem fixed by commit 02a1edc64bde14401899d0f026d49dbf125e3ffc -
        see its commit message for details.)
        
        Bugdoc for tdf#169882 has a table with a row having two cells, each with
        an image; the images require the row to move forward. For the first cell,
        layout moved the image forward (which caused the whole row to move), but
        didn't mark its anchor, because there was another fly "below this". Then
        the text succeeded moving back, creating a layout loop. Before the fix of
        tdf#166871 (which caused the regression addressed here), the optimization
        allowed the layout to skip the problem (but it was actually possible to
        trigger it in a different way).
        
        It could be possible to modify the code to special-case table rows. The
        code in SwObjectFormatterTextFrame::CheckMovedFwdCondition contained a
        similar condition for "on same page" case. But it seems that the whole
        workaround is now not needed. Reverting it keeps bugdoc from tdf#138518
        fixed, so avoid the fragile workaround. This change also reverts commit
        d9e38d5830ac278d7180b96fb6cefe3ee8ef6d76 (tdf#135220 sw: fix layout
        after SwUndoDelete), which keeps its steps behave correctly.
        
        Change-Id: I299e8f78b83c1d73402e548ea7f6cce1a2e5af0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195395
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195534

2026-01-12  Karthik Godha  <karthik.godha@collabora.com>  [add8878c5bf28e7daff76eda22ce785912ec08c9]

        tdf#169924: ODP -> PPTX export invalid animations
        
        When exporting animations in a slide, animations attached to
        shapes which are not in the slide are also being exported.
        
        Change-Id: I2dbc5cd5755ce6656a9fc2efa453c5837ffeaa6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195391
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 30d71445d40904fd7c47639575e3f7ffa499dcad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196541
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196670
        (cherry picked from commit e3d6fddc2e1384af1b5a6863722854d6608ab1eb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196901

2026-01-12  Karthik Godha  <karthik.godha@collabora.com>  [0c32b2d5a23acbf2a1ece3b38bc8db6fd8b16cf1]

        tdf#169941: ODP->PPTX exporting shape hyperlinks
        
        LO supports hyperlinks to shapes within the document. PowerPoint doesn't
        have this feature. Export of these shape hyperlinks is not handled.
        
        Now hyperlinks to shapes are converted to slides in which thy are
        present.
        
        Change-Id: I53f971c35a4f0f58532048b4041b0f35814b2715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195465
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ef58ed0184cfd362175d880f4efb3d297a3d2641)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196540
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196665
        (cherry picked from commit b93d0eca0f7bdb5aabbc2abf4fada51342f5ba42)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196880

2026-01-12  Karthik Godha  <karthik.godha@collabora.com>  [cdf095cec203f8ced45328559c09f1ef9777817d]

        tdf#170035:Add OOXML formula check for guidelist
        
        Add condition check to skip exported of internal names/equations to
        OOXML.
        
        Change-Id: I0c03bbaa7ea61dd4f526fc0476482571df7e7cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196209
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 0f0bb6ba234c371e1c5a6420ba1e441322c9c354)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196545
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196668
        (cherry picked from commit e412f35e266bd08fb1a6d9f5f2a82d7761ea6cec)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196862

2026-01-12  Karthik Godha  <karthik.godha@collabora.com>  [ef353879509bc2478adb4e5086a6c4b205edbaa1]

        tdf#169980: Fix ODP->PPTX export of stock chart
        
        In OOXML chart export in `c:stockChart` there are multiple `c:ser`
        elements with the same `c:idx` value.
        
        Change-Id: Id5c5983118214013a3610ae937b9893c479a0ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195657
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit c5b4614b927bd8056995d7d4adb07a4f0c965480)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196543
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196666
        (cherry picked from commit d4a7e5c7ada7692597f4127e43624419892b7205)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196842

2026-01-12  Noel Grandin  <noelgrandin@gmail.com>  [3689151b9f0577b6d79eee1abbd2cc7d556cedeb]

        officeotron: w:pPrChange is incomplete
        
        the schema says w:pPr is required under w:pPrChange.
        
        I dont understand the unit test I changed here, it was
        added with:
        
          commit c2c08b7d0e87f8cd1c97028c9363826f4bd22dcb
          Author: Adam Co <rattles2013@gmail.com>
          Date:   Mon Jan 13 13:55:05 2014 +0200
          Add unit-test for 'track changes - paragraph properties changed' preservation
        
        But seems to be asserting that we __dont__ preserve w:pPr,
        which makes no sense.
        
        So fix that.
        
        Change-Id: I536992bd3aec232f8dffda4f753c887148a877f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196786
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit a520104c86703c9a697166c1b8d703060435b59c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196943
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196964

2026-01-10  Regina Henschel  <rb.henschel@t-online.de>  [1fb6b5ceb2c51d9af1720d6420e7019722adb26a]

        tdf#131124 Handle ExtrudedCustomShape and FontWork
        
        ShellMode::ExtrudedCustomShape and ShellMode::FontWork were missing in
        the switch. Thus mxShapes and mxShape in the Export dialog were empty
        and maSize was zero.
        
        Change-Id: If4c2137ce85a0aef0613d9d79979cc9a58b5c115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196456
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit a8babea4ce7f07f969e58594ab5a5afc2d190e69)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196881
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196944

2026-01-10  Miklos Vajna  <vmiklos@collabora.com>  [fcc487c3fb3d3efa7eee851a79a8db8444e6f687]

        sw: fix crash in the ModelToViewHelper ctor
        
        gdb backtrace on the core file from the crash report:
        
        	#5  0x0000000000afc0ee in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
        	#6  0x0000727cd30229b1 in std::deque<std::pair<sw::mark::Fieldmark const*, bool>, std::allocator<std::pair<sw::mark::Fieldmark const*, bool> > >::pop_back (this=0x7ffc1ea0f8e0)
        	    at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_deque.h:1597
        	#7  std::deque<std::pair<sw::mark::Fieldmark const*, bool>, std::allocator<std::pair<sw::mark::Fieldmark const*, bool> > >::pop_back (this=0x7ffc1ea0f8e0)
        	    at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_deque.h:1597
        	#8  ModelToViewHelper::ModelToViewHelper (this=this@entry=0x7ffc1ea0fb40, rNode=..., pLayout=0x631dce00,
        	    eMode=eMode@entry=(ExpandMode::ExpandFields | ExpandMode::ExpandFootnote | ExpandMode::ReplaceMode | ExpandMode::HideFieldmarkCommands))
        	    at sw/source/core/txtnode/modeltoviewhelper.cxx:207
        	#9  0x0000727cd311cea2 in SwXFlatParagraphIterator::getNextPara (this=0x64417ab0)
        	    at sw/source/core/unocore/unoflatpara.cxx:485
        	...
        	#12 0x0000727cd2c23b4f in SwDoc::StartGrammarChecking (this=<optimized out>, bSkipStart=bSkipStart@entry=false)
        	    at sw/source/core/doc/docnew.cxx:184
        
        and:
        
        	(gdb) frame 8
        	#8  ModelToViewHelper::ModelToViewHelper (this=this@entry=0x7ffc1ea0fb40, rNode=..., pLayout=0x631dce00,
        	    eMode=eMode@entry=(ExpandMode::ExpandFields | ExpandMode::ExpandFootnote | ExpandMode::ReplaceMode | ExpandMode::HideFieldmarkCommands))
        	    at sw/source/core/txtnode/modeltoviewhelper.cxx:207
        	207                         startedFields.pop_back();
        	(gdb) print startedFields
        	$2 = std::deque with 0 elements
        
        We have no reproducer for this, but seems the grammar checker is somehow
        invoked on an inconsistent model where the start and end field mark
        dummy characters are not balanced. Leave the assert in place, so
        possibly a later debug build can find a reproducer; but also check for
        this to avoid a crash in product builds.
        
        Change-Id: Ic9696e32bf344b336800bfa475f506e3cc103ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196615
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2b089278f3732ea35b14cd4c577b6f496bfc0998)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196658
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 3e5248e32a87c441bce080b01bc5f4caf8794bbb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196861

2026-01-09  Pranam Lashkari  <lpranam@collabora.com>  [1529cee759293bd49042e771ad1778e0c833ce86]

        tdf#170171 math: allow equestions to end without opening brackets
        
        problem:
        some user complained equation not rendering correctly
        if it ended with opening brackets while it worked fine in MSO
        
        i.e: [0;+∞[
        
        Change-Id: Iccfbfd0782379985736cdc181479f167ca0beb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196197
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 7a4ea5e1e197798ec0c39c442bfc51397e00d1c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196303
        Tested-by: Jenkins
        (cherry picked from commit 966cbcaeea8d848b64eb59e980eac7cd543fcc5d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196876
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2026-01-08  Justin Luth  <justin.luth@collabora.com>  [1a3bf265c77bc5bb042168cb9d7d12eaaf87b70c]

        tdf#170003 writerfilter: no belowSpacing emulation with tables
        
        This patch fixes my 25.2.6
        commit 1326e09d019f05a82265f15c26288b4ffb7dc0c2
        tdf#167657 writerfilter: only move sectPr bottomMargin after pageBreak
        
        It turns out that m_xPreStartingRange is a bit of a disaster.
        First of all, it seems to be set even if gotoPreviousParagraph fails.
        That can't be a good thing.
        
        Secondly (and the problem for me), it jumps over tables,
        so if the page break happens after a table
        then I was applying the below spacing to an earlier paragraph.
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf170003_bottomSpacing
        
        Change-Id: I883dd397413001fafb000e1e90c0e6738b3b4c87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196143
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196439
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 10de457864f7069632c90ff041a9c0b971e9bc38)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196686
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-08  Justin Luth  <justin.luth@collabora.com>  [b812c5c45b43bb9cf07b7388a08f3152ed3995be]

        tdf#166945 Revert "tdf#111969 sw: ... last half-character for context menu"
        
        This reverts 24.8 commit 242f6985556af7aac77b68c6dfea20d4b32c5f52.
        The problem is that the context menu simply cannot know
        which choice the user will choose.
        Some actions DEPEND on the cursor being 'closest to the mouse point'
        and some actions DEPEND on the cursor being
        'inside the character run properties or field'.
        
        That 'mouse point at right click' is completely lost
        as soon as the mouse moves to chose something from the context menu,
        so it is not available to be re-used by SID_PASTE etc
        to re-position the cursor before executing the paste.
        
        The benefits of the now-being-reverted-patch do not
        dwarf the already-discovered-downsides,
        so I'm just reverting to extract myself from this situation.
        
        Change-Id: I03943cf899e1d18fb3e736d4cccea159abe7332e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196586
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit f656be88a35e1d4e51ddf131f1454acac4f03739)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196838

2026-01-08  Karthik Godha  <karthik.godha@collabora.com>  [5e2e73652b612e1ef04ef1bfd0dc936180e68aef]

        ODP -> PPTX export empty attrName element
        
        In OOXML export attrNameLst must contain at least one attrName element.
        Export of attrName is skipped if it's empty, this results in invalid
        schema. (ISO-IEC-29500 19.5.8)
        
        bug-file: ooo72169-1.odp
        
        Change-Id: I8ebf2b9752fc9e90c21339d7d9dd3507e2518fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195758
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 3f5d0e1425305507bf545c58d1ade11059960005)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196544
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196669
        (cherry picked from commit 576f11b495e2dc29f1f2e85eb9607165720e39cc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196843

2026-01-08  Karthik Godha  <karthik.godha@collabora.com>  [939cdbe62a6f141aad879f7f428eb5cd0361c1ae]

        tdf#169979: ODP->PPTX export missing p:pic element
        
        OLE objects when exported to PPTX should contain p:pic element in the
        XML. OLEs without graphic content don't export p:pic element, though
        this is a valid schema, PowerPoint doesn't accept this.
        
        Now empty p:pic element is exported for empty graphics
        
        Change-Id: Iac6fb988aa20e1bc9ae938d2a02dfc7b8dfae0c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195623
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 33a228978b109a05f05078bc430e9d61698798c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196542
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196667
        (cherry picked from commit 8c35a2d58b5d1a7326416a2c82a4f304bd23378f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196730

2026-01-07  Pranam Lashkari  <lpranam@collabora.com>  [bc1606b1516b5915c4f11e0f3fce9d9fe71ccb10]

        tdf#169843 math: OOXML set letter not interpreted correctly
        
        problem:
        OOXML has special property to define set names
        m:scr with value "double-struck" means text should be
        interpreted as set names and double-struck letters should be used
        
        Change-Id: I8acefb369694ae901fc4df2505a85d0691a2cb16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196199
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit f325e0de3447c0403656ebb2a2fe4789aa59e78e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196305
        Tested-by: Jenkins
        (cherry picked from commit d2dc364ca322f7331652a184a2a69d585b2615da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196559
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit e172a3343eae39b5d45bfb99fd88c51bfd9d7b01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196579

2026-01-07  Noel Grandin  <noelgrandin@gmail.com>  [d142a30607c0c02f12f140cd7df927013c6e6c77]

        officeotron: w:del in wrong order
        
        under the w:rPr element, w:del needs to come before w:lang
        
        Change-Id: I0bf6ddc554c44ef978b62565d5be664af406a693
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196624
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 40a68f926079cbe3082cacdabffac4846f342139)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196657
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196673

2026-01-07  Aron Budea  <aron.budea@collabora.com>  [063ca7de9b47cc92d1a5f10fae6e475e7693e165]

        tdf#170202 avoid exporting ANIMATIONPHYSICS node types
        
        Implement cbf102d4c1ba73519b49df0d43a87ebdf9267538 differently.
        
        After previous commit, tdf136301-1.odp still contained
        animation elements in slide1.xml when converted to PPTX, and
        couldn't be opened in PP.
        
        Set such nodes invalid instead to avoid processing them at all.
        
        Change-Id: I799026c389681b89792bb9765b8f81562743deb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196424
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit f3943837d75695bc351a55340addd362de33097b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196441
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 8a7dcdc302c50b1357fef90359922a58b24f5e51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196561

2026-01-07  Karthik Godha  <karthik.godha@collabora.com>  [6b5fbb953959beedc4ff3b0ea3de512559a6cfc5]

        tdf#169911: ODP -> PPTX export invalid animations
        
        Empty/invalid OLE objects are skipped PPTX export, but animations
        attached to these OLE objects are exported.
        
        Add the slide itself as target for these animations
        
        Change-Id: I1e594d607cc37f58c0e56357f8f8d42d9139bec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195306
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 064e42a069c9186919086904ced3100960bafb41)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196156
        Tested-by: Jenkins
        (cherry picked from commit d64f3e812bd6929b62d8c00b60b460aed2bf8e84)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196425
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c371757d0c5a418b9932a5a01389280ca41f3b8a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196431

2026-01-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [63f5048f0cfefa489054a18bafac2cd87ff2a6fb]

        NotoNaskhArabic: upgrade to 2.020
        
        Downloaded from https://github.com/notofonts/arabic/releases/download/NotoNaskhArabic-v2.020/NotoNaskhArabic-v2.020.zip
        
        Change-Id: Iea3547580ed2972da1b81b4d80f3e5b575bc5405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196300
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 90bf630fa2c612000cdc7128612c13088a22ce34)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196319
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2026-01-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [c645bdd228d0e47911a7adecd545ea32edf00d99]

        bump copyright year to 2026
        
        Change-Id: If9b398d338f0a99b400b58c0f4d095a9b9ca5e4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196417
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 963535158003fde54145ae57a8fb2594697fe23a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196430
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-12-30  László Németh  <nemeth@numbertext.org>  [3fdf13e7f9e0e053d11bfe477407ec9331160ef2]

        tdf#170140 lingucomponent: check words with non-ASCII apostrophe
        
        If the spelling dictionary contains them with non-ASCII apostrophe.
        
        Previously the words were checked only with apostrophes converted
        to their ASCII version, resulting continuous false alarms, despite
        the correct orthography in the document and in the spelling
        dictionary.
        
        Now the words are checked both with ASCII conversion and with
        the original non-ASCII apostrophes (because still there are
        UTF-8 dictionaries with ASCII apostrophes, moreover, dictionaries
        containing mixed apostrophes in the same dic file).
        
        Example words for the Hungarian dictionary: d’Arc, d’Alembert,
        McDonald’s (and their several recognized suffixed forms: d’Arcért,
        d’Arckal, d’Arcként, d’Arcnak, d’Arcot etc. etc.)
        
        Add unit tests for 1) break iterator and 2) spell checking with
        non-ASCII apostrophes.
        
        Change-Id: I24a570df41fa5aba2e7b67dde0db33377717dc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196248
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196283
        (cherry picked from commit 10d08d2ffead7597a44e0ce0cf4c5e98ffc29b22)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196309
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e1e6a947828db5073ec13ffac62f099ca92b661]

        NotoKufiArabic: upgrade to 2.110
        
        Downloaded from https://github.com/notofonts/arabic/releases/download/NotoKufiArabic-v2.110/NotoKufiArabic-v2.110.zip
        
        Change-Id: Ifd42416d741f2de9847da9c278218404876dbd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196297
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 9e7f751ef67cadbff7d270c77f5c8297e98462b9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196311
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [a74874de3e40ddbd68f7af26bc75b120d6a1dbb3]

        harfbuzz: upgrade to 12.3.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.3.0/harfbuzz-12.3.0.tar.xz
        
        Change-Id: I5e5ac046e586e8e0e0a1c797f56ec0e64c6a5e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196295
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 354f06cf8f512dbc4e7f4e0d70703b887269e1bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196314
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-29  László Németh  <nemeth@numbertext.org>  [bf46bb82fa3e56f72a481edc05873355a89ccddc]

        tdf#162514 i18npool: fix Hungarian ordinal numbers with affix
        
        Restores Hungarian break iterator by recognizing ordinal
        numbers with affixes, e.g. "50.-et" etc. (to spell checking
        bad forms, like "50.-at").
        
        Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700
        "tdf#49885 BreakIterator rule upgrades".
        
        Follow-up to commit f4fe6df6aa92573368c3fa0edb9fd03e64d9d059
        "tdf#162514 i18npool: Handle abbreviations in dictionary breakiterator"
        and commit 167bbe31c0620d6ca1c4640a81f2e759f8f65e6a
        "tdf#162514 i18npool: apply fix for Hungarian abbreviations, too".
        
        Change-Id: I6b6ea363a509a9d8af8330330f78cc23c210d107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196225
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        (cherry picked from commit 09b5b77e0242170149aa7abbd2ed1c4ff4d9f5b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196243
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit aca0543d65aa46c45d82487f061f479fdb5cf3a7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196265
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-28  László Németh  <nemeth@numbertext.org>  [be49bc3f64eb8bfcf54628e907c8bd6a5c50dae3]

        tdf#162514 i18npool: apply fix for Hungarian abbreviations, too
        
        Restores Hungarian abbreviation handling to spell checking by
        applying the fix for dict_word_hu.txt.
        
        Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700
        "tdf#49885 BreakIterator rule upgrades".
        
        Follow-up to commit f4fe6df6aa92573368c3fa0edb9fd03e64d9d059
        "tdf#162514 i18npool: Handle abbreviations in dictionary breakiterator".
        
        Change-Id: I83e30c831759ae896f1db2da697287b8c4dcd26b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196224
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        (cherry picked from commit 167bbe31c0620d6ca1c4640a81f2e759f8f65e6a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196231
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-27  Gülşah Köse  <gulsah.kose@collabora.com>  [42dcb90ed2fa5d5cb8fb413946ac22eec1890be4]

        tdf#169456 Fix the placeholder of master slide style issue
        
        In some cases we see the object in the slide has no fill syle directly but parent object
        in master slide can has fill style.
        
        We should apply the style to object in this case.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I0b061cfde4ac2067c84383764770f155564531a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195368
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 92b0bcb3136a77de97415b900a0e9b4a271715ae)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195672
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
        (cherry picked from commit 7ab8ed87dca177f22b162df5dfbba3052b82596d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195768

2025-12-24  karthik  <me@karthikreddy.org>  [d8d8c3e1f689f1352424d3aacb323e23c9f71e9e]

        Use correct progId for Draw OLE Objects
        
        This is related to commit 258face1158299af6c54c01f8f7a3c94006a7fdd
        
        Change-Id: Ib09fe15349113c389dcb867af11a06cad2108c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195882
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit f12ead65e2719ac71d222e535c15e15c1115971b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196195

2025-12-24  Aron Budea  <aron.budea@collabora.com>  [817e1c5289c353f20c9fdf148684b44b31790cab]

        tdf#170102 PP's Title and Content layout exported incorrectly
        
        In tdf#169825's fix I tried to correct the layout type
        corresponding to AUTOLAYOUT_OBJ, originating from PP's obj
        ST_SlideLayoutType to AUTOLAYOUT_TITLE_CONTENT, which had
        unexpected side-effects:
        PPTX->ODP->PPTX conversion of a 'Title, Content' layout added
        placeholder artifact.
        
        Revert that part of the change for now.
        
        Regression from eb338daa90afd569e1b86c058bb88a89fab6a557.
        
        Change-Id: I5ba7ee14c4ae3a3a336b051edee4ca8702b87397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196169
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit 04e5572c796b63da94aedbd07b2b7bd972422161)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196176
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-24  Balazs Varga  <balazs.varga@collabora.com>  [0dc03683f9536123327963c170203addb8408930]

        tdf#170027 - sd fix crash when undoing shape drag with Alt pressed
        
        Do not overwrite original shape during drag&drop with Alt,
        when we try to drag&drop the shape on the same shape,
        but create a new shape with new name, same as if we would drag&drop
        the object in general.
        
        Change-Id: I08b2197b3b9755455a165a566eb3452846c0f78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196097
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 9f980e021ff1a7613003e5c93ec49a37c5ca3420)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196178
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9ae7a09f8678258bde65f4634461c9b64e38eb39]

        ofz#471087908 Null-dereference READ
        
        Change-Id: Ibfa1947bae59feb6460997fb6966228a85a048e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196158
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit f1b58e691ee24a6a0f75607e39f0c978f09d0b0d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196180
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-24  Miklos Vajna  <vmiklos@collabora.com>  [2be5834a1ef7f9dd133433719b12ff0d65cb3318]

        tdf#168751 sw interdependent redlines, format on delete: fix unwanted combine
        
        The DOCX bugdoc has a format redline (mark as bold) + a delete redline,
        and these two overlap. Open the document in Writer, reject the delete
        redline, the boldness remains in the document, which is unexpected.
        
        The problem is an in case a format redline is created and that would be
        on top of an insert or delete from the same author, then we currently
        merge this into the insert/delete redline. The reason for this seems to
        be that search&replace inserts text to the document and then copies
        direct format from the insert position to the inserted text range, and
        this format should not show up on the UI, since the UI action was just
        to replace text. Another variant of this is autocorrect "make first
        character of the paragraph uppercase" in action, which is internally
        again a replace.
        
        Fix the problem by disabling combine of redlines in
        sw::DocumentRedlineManager::PreAppendFormatRedline(), in case we would
        do a combine and this is a format on delete. This way the format is
        rejected by the UI reject action and the unwanted format on insert still
        doesn't show up. The behavior was like this already in case the authors
        of the format and the delete redlines were different.
        
        Note that this tweak is not even important for the insert-then-format
        case: accept doesn't modify the body text and reject would remove text
        from the body text, so we get rid of the unwanted format anyway.
        
        Change-Id: Ib08b0c62c012f14801deae47a4b85d77e32fc1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196095
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit c25c52dd2286ad0aac86389574d3b3bd258b5b08)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196104
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 2e8b2844155887ebba0dbc012bee6bca4fe78f7c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196182

2025-12-23  Patrick Luby  <guibmacdev@gmail.com>  [2c47e504858b091468bcc04eadf90babe216e2f3]

        Revert: draw alpha bitmaps directly to print graphics on macOS
        
        This partially reverts commit fa3dd1c3a190fcbead9d39038a30f0fd306a1baa.
        Apparently, the special handling of alpha bitmaps when printing on macOS
        is no longer needed and the alpha blending code used on other platforms
        now works as expected on macOS.
        
        Change-Id: Ib72e57ec679971c8db06160ae0354c8ba45be91e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190496
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196114
        Reviewed-by: Dan Williams <dcbw@libreoffice.org>

2025-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [657721f194968d66a614ca7ac0e3bd5d72089d30]

        ofz#470644944 Null-dereference READ
        
        Change-Id: Ief869fc4237ca3052db84cac891079b7483d43e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit d71aeeadc20198121eed46daf4d5b10089279be2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196100
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-22  Karthik Godha  <karthik.godha@collabora.com>  [90d7dd49195a05b23e0a952f6984bcb26bec4e42]

        Sanitize font size read from XLS
        
        This is related to commit 28273e586b398e2ce181c4ce9e740949fad11876
        
        Change-Id: I182c27b6a9f796bf949246a2038c318dec755c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195831
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 50ef3ac17ab884fff1518d90d161b1e6d7bff8c0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195892
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2d273469ebe0c0e3c8a44b16690a218d367614ac)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196071
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-19  Justin Luth  <justin.luth@collabora.com>  [791bdef1573d7f5bb36e41aebb73436ac2ea2e14]

        tdf#170012 sc drwlayer: avoid crash on ODS save
        
        This fixes a crash since 7.1
        commit 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca
        
        Instead of trying to save as a broken SCA_CELL_RESIZE
        it will save as a SCA_PAGE anchored object.
        
        The crash was occuring when saving to ODS format.
        It would loop forever because of the invalid address
        that GetNonRotatedObjData got during RecalcPos
        when it had been created but never "initialized".
        
        (An earlier patchset tried to force initialization
        and assert that, but I got tons of asserts in unit tests
        because of detfunc's bCreate without
        ScDrawLayer::InitializeCellAnchoredObj).
        Plus, doing initialization correctly
        sounds incomprehensible based on a code read.
        
        [Unit test removed because it depends on xlsx
        importing correctly - which doesn't work in 25.8.]
        
        Change-Id: Ief717c8742d712bf2edec90f492fd258f9fd7741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195807
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit cbd9d23b7b953fdf53d66aaa072bab17db7905d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195873
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-18  Jeff Huang  <jeff.huang@ossii.com.tw>  [1cd303d206a06017fb9378a842beba53f8151c65]

        tdf#169920 Remove hardcoded DFKai-SB fix
        
        Commit 257bb11cbc5b1eb1f90014f528b9e7d6ccfeae86 introduced a compensation
        to glyph position miscalculation for DFKai-SB.
        
        After commit 6f4a949c07eb06345df08c722f8e59e97888a499, this causes over-
        compensation.
        
        This patch reverts commit 257bb11cbc5b1eb1f90014f528b9e7d6ccfeae86
        
        Co-authored-by: Firefly <firefly@ossii.com.tw>
        Change-Id: I0027f38d5eae58694c59b7590fc3315aae5deef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195347
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 005e787efec6c1e352e3cd17231d70508cd18d8e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195850
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-17  Miklos Vajna  <vmiklos@collabora.com>  [06c6975918df7b661cef0635ae09533dcfae1a34]

        sw: fix crash in SwFieldEditDlg's AddressHdl
        
        gdb in the core dump gives:
        	#0  0x000073b5e9fd6bb9 in SwFieldType::Which (this=<optimized out>) at sw/inc/fldbas.hxx:276
        	#1  SwField::GetTypeId (this=0x0) at sw/source/core/fields/fldbas.cxx:267
        	#2  0x000073b5e911faa4 in SwFieldEditDlg::AddressHdl (this=0x4a057e70) at sw/source/ui/fldui/fldedt.cxx:296
        	#3  0x000073b5f85de37c in std::function<void ()>::operator()() const (this=0x7fffed028930) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/std_function.h:587
        	#4  Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&) (this=<optimized out>, nEvent=nEvent@entry=VclEventId::ButtonClick, callHandler=...)
        	    at vcl/source/control/ctrl.cxx:311
        	#5  0x000073b5f85c16c8 in Button::Click (this=<optimized out>) at vcl/source/control/button.cxx:130
        
        and
        
        	#2  0x000073b5e911faa4 in SwFieldEditDlg::AddressHdl (this=0x4a057e70) at sw/source/ui/fldui/fldedt.cxx:296
        	296         if (pCurField->GetTypeId() == SwFieldTypesEnum::DocumentInfo)
        	(gdb) print pCurField
        	$2 = (SwField *) 0x0
        
        return early in case we don't have a valid pointer for the current field
        anymore.
        
        Change-Id: Ibc614cc825a0b14cd4f79060d35f6635eb0cdd55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195784
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit fbd29829a3f610f3f3040b38ad73d49c1268d24a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195792
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-16  Noel Grandin  <noelgrandin@gmail.com>  [e1607a1694015c4299fc07dfc64b27a5582feaa5]

        officeotron: elements under w:pPr element in wrong order
        
        re-use existing logic to make this output in spec-compliant order
        
        Change-Id: I5de88629295ee3eac1852fe67eedea4f1be7c087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195394
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 2b6e7bf5c0e9166fb10082267136ed6b899c7582)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195561
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195695

2025-12-16  Justin Luth  <justin.luth@collabora.com>  [e070494364f62e7d14ffcbfa87cafe708bacb1d6]

        tdf#169986 docx import: no sectPr belowSpacing to footnotes
        
        This fixes my 25.2.6 regression from
        commit 1326e09d019f05a82265f15c26288b4ffb7dc0c2
        Author: Justin Luth on Mon Jul 28 09:29:51 2025
            tdf#167657 only move sectPr bottomMargin after pageBreak
        
        Footnotes (and comments) are always a CloseSectionGroup disaster.
        The section's belowSpacing should never transfer
        into a footnote - it only applies to the body paragraphs.
        
        Interestingly, the unit test does NOT fail,
        even though 2 pages are clearly seen interactively.
        I include it simply for possible future benefit.
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf169986_bottomSpacing
        
        Change-Id: I848ccda2ce2bb84de951c6da8f4001d217b8b38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195683
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 01c39dcb622256a66bd11aaaa695729db9b27468)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195684
        (cherry picked from commit b5637481d060d01094e7ceef959744d96547cdbb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195686
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-13  Dan Williams  <dcbw@libreoffice.org>  [5b025a8fdc7e2e905aefa017aa05b02b5568fe66]

        tdf#169727 update ThumbnailView colors for system theme changes
        
        The ThumbnailView never updated cached colors after creation, leading to
        wrong background colors when the system theme changed while LO was
        running (eg between Dark/Light mode). Since subclasses need to override
        the parent class colors, we must first let subclasses update internal
        cached colors then copy those to the item attributes. Then during
        Paint() requery style settings to ensure our colors are up to date.
        
        Change-Id: I19bbfb296ba213cf7ad53eff8bd24fe291679184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195402
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        (cherry picked from commit 92b013bdb4d567b98bfcf42a0831abe42117691c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195599
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        (cherry picked from commit ded39ec772e6fc0c4d943e6ca0673a89d89493cc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195600

2025-12-13  Miklos Vajna  <vmiklos@collabora.com>  [7b0fae3d8a8c9d14bf4514818a70502e831b55bc]

        sfx2: fix uncaught exception in SfxViewShell::Activate()
        
        gdb backtrace on the core file from crashreport:
        	#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=123946821978048) at ./nptl/pthread_kill.c:44
        	#1  __pthread_kill_internal (signo=6, threadid=123946821978048) at ./nptl/pthread_kill.c:78
        	#2  __GI___pthread_kill (threadid=123946821978048, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
        	#3  0x000070ba9de42476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
        	#4  0x000070ba9de287f3 in __GI_abort () at ./stdlib/abort.c:79
        	#5  0x000070ba9e2a2b9e in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6
        	#6  0x000070ba9e2ae20c in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6
        	#7  0x000070ba9e2ae277 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6
        	#8  0x000070ba9e2ae4d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6
        	#9  0x000070ba9818129b in SfxBaseModel::MethodEntryCheck (this=<optimized out>, i_mustBeInitialized=<optimized out>)
        	    at sfx2/source/doc/sfxbasemodel.cxx:3069
        	#10 0x000070ba99e6c8cb in SfxModelGuard::SfxModelGuard (i_eState=SfxModelGuard::E_FULLY_ALIVE, i_rModel=..., this=0x7ffedd2f94f0)
        	    at sfx2/source/inc/docundomanager.hxx:76
        	#11 SfxBaseModel::setCurrentController (this=0x194e84b0, xCurrentController=...)
        	    at sfx2/source/doc/sfxbasemodel.cxx:1364
        	#12 0x000070ba99f6955a in SfxViewShell::Activate (this=0x2b084ed0, bMDI=<optimized out>)
        	    at sfx2/source/view/viewsh.cxx:2535
        
        And that std::terminate() prints:
        terminate called after throwing an instance of 'com::sun::star::lang::NotInitializedException'
        
        Fix the problem similar to what commit
        adadeaf98114ffdf9893e6c92a630f7e90597f62 (avoid terminate after
        unhandled exception, 2025-11-26) did, but here note that
        SfxViewShell::Activate() ignores the case when the object shell has no
        base model. So extend that and in case the object shell has a base
        model, but it's not initialized, do the same (ignore the problem that
        setCurrentController() could not finish successfully).
        
        This solves the high level problem that processing an user event on the
        main loop should not throw exceptions.
        
        Change-Id: Ibd6309d7de12964a35a914c16fabc5fc7f61b39b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195477
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit b9d6213d04c84b8d514be597d8c876caf9c48be9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195518
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-12  Miklos Vajna  <vmiklos@collabora.com>  [bf744d887f50d84670895d1dba750217e0126770]

        tdf#169680 DOCX import: fix unexpected stretched image
        
        Open the bugdoc, the music notes picture inside is not readable.
        
        This went wrong in commit edda1e5fc8113aa4744e32f97c96a3cc311485ca (DOCX
        import: lazy-read images without external headers, 2018-04-20), and
        later commit c3ce373227433f40d686847a22e78651bedbab24 (tdf#156593
        FILEOPEN OOXML: image shown in full instead of cropped, 2023-10-27)
        fixed a similar problem, this bugdoc is still bad.
        
        Note how the second commit looks for the .tiff extension, while this
        bugdoc has a .TIF image. Fix the problem by looking for both extensions,
        in a case-insensitive way.
        
        A future possibility would be to improve OInputCompStream's XPropertySet
        implementation, so next to its Compressed and Size properties, it would
        also expose the image/tiff MIME type, and then we would not have to
        guess content based on the file extension.
        
        Change-Id: I81519119bae698bf1cca34792fcf1aa6587b48a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195542
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a574572f3147179626061ebf1076540cc110b155)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195572
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-12  Noel Grandin  <noelgrandin@gmail.com>  [f19d30a41a7ab5094087107d0b1627d7e6bd48c4]

        officeotron: "0-00-00T00:00:00Z" is not a valid date
        
        similar to commit 8c5683ee74230931c9375a22981239ca1a2c1a2e
        
        Change-Id: I3de3e44ea4955a159d8e23932108d623fbb27c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195331
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f4ff6e8d27b44ac59c54eb130179b3da0e01a9e9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195362
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195536

2025-12-12  Noel Grandin  <noelgrandin@gmail.com>  [6630779e275e4c980d1a563a8428fd5dbfe4ac71]

        officeotron: w:spacing in wrong order
        
        found by converting the document in testNumberedList to docx,
        then running officeotron on it.
        
        Change-Id: I090b38a9a2e74dd8ec1c64aa818d976e319f59b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195333
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 31ed14cdc3880d3cd04fe70724ec62c286eca715)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195365
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195535

2025-12-12  Mike Kaganski  <mike.kaganski@collabora.com>  [35d08a001107e7012d9ed923864001d4ed161071]

        Fix test checking metafile's coordinates
        
        Respect the mapmode stored in the metafile, to enable it on all
        platforms. On my Windows system, it was
        
          <mapmode mapunit="MapRelative" x="-1065" y="-284" scalex="(1/1)" scaley="(1/1)"/>
        
        and on a Linux system, it was
        
          <mapmode mapunit="MapRelative" x="-284" y="-284" scalex="(1/1)" scaley="(1/1)"/>
        
        which explained the difference.
        
        Note that the metafile mapmode is obviously unstable. E.g., commit
        I299e8f78b83c1d73402e548ea7f6cce1a2e5af0d causes the uncorrected test
        fail on Linux with
        
         - Expected: 2306
         - Actual  : 4595
         - In <>, attribute 'x' of '//textarray[1]' incorrect value.
        
        But curiously, running the test *individually*, like
        
         make CppunitTest_sw_odfexport4 CPPUNIT_TEST_NAME=testTdf78510
        
        passes. So the change to mapmode is caused by some other test, which
        is worrying, but that mapmode change is not addressed in this patch.
        The fixed, more robust test will pass.
        
        Change-Id: Ib004fd89aa03be38ab83d7ef70e0d5e791987298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195421
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195504
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195533

2025-12-12  Aron Budea  <aron.budea@collabora.com>  [9ec6929930527e8a4eb4d9b97e72cdbcf91d1ca0]

        Revert "tdf#164141 Fix command button xls to xlsx convert problem."
        
        Exporting ActiveX objects is a big missing feature, and
        this was more of a workaround.
        
        The invalid export originating from
        fd238380ae7820f12ac1f7c52d0f7180a93f3ba3
        ...has later been resolved differently in:
        ab45b8d9959f8f392a10d0874c50f26b816a4da8
        
        This reverts commit ab62d75141192a73dcd6862e37753bc1c3f82576.
        
        Change-Id: I5e40759595e65a8778abbb521bdc146517afc949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184975
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195195
        Tested-by: Jenkins
        (cherry picked from commit 5c032407baf1952fab7a704b41b8ac8c18f978b0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195250
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-12  Aron Budea  <aron.budea@collabora.com>  [6df31d3c358027660a39f63e784915043128a6ac]

        tdf#166325 sw: use correct type when exporting scheme color to DOCX
        
        OOXML schemeClr element has a different type (ST_SchemeColorVal)
        compared to themeColor's ST_ThemeColor type, eg. dk1 instead
        of dark1, but commit baf179188d8b9e29188387fd4b7d887dd3168792
        mapped them to the same values on export, causing some affected
        files to become invalid.
        
        Change-Id: Iff63aea8943be905c9afbb68012db320cc94eeb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195346
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit d5136e0b6059435356351cf2c54af61401e45fc2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195507
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 43b74c0037b0d1b2ea2f4dc4faa42283addcf483)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195516

2025-12-12  Justin Luth  <justin.luth@collabora.com>  [877eedc73c0349b39b07e19e01fa2dca422448c8]

        tdf#169072 ms export: valid date years are 1601 - 9999 #2
        
        The dates in core.xml must fall in the range of 1601 - 9999.
        
        This applies to all MS files, not just DOCX.
        Plus, the entire concept of ISOIEC_29500_2008
        was wrongly implemented...
        
        make CppunitTest_sc_subsequent_export_test2 \
            CPPUNIT_TEST_NAME=testTdf169072_illegalDates
        
        Change-Id: I06ddc69ff79f1c8d744d97782617f8be257021a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195139
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit ef5846a1ea802f580508984baa6dc76d3d9d617f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195160
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195463
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [48b7c9fda2d0f6a356cad3810e4e35132debfaad]

        libjpeg-turbo: upgrade to 3.1.3
        
        Downloaded from https://github.com/libjpeg-turbo/libjpeg-turbo/archive/refs/tags/3.1.2.tar.gz
        
        Change-Id: Idf03d1ac8910f39843e4c6c75d264f445f5ff003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195430
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 870f682c386f858c44ce74ef3816f6df5c6c8c1d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195498
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [8b7650f6fd7b6e4442e16eb930a5cfc4c61773a3]

        tdf#167385 sw: Keep AnnotationWin menu up to date
        
        Since
        
            commit f075fa01cb4f74185f13eb0a8d7f84cf1f47af49
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 22 10:26:32 2023 +0200
        
                tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        , the menu button toggled handler is no more called before
        the menu shows (at least for the vcl/SalInstanceMenuButton
        implementation).
        
        Therefore, instead of relying on that handler, update the
        menu when initializing the AnnotationWin controls and in
        SwAnnotationWin::UpdateData instead, to make sure it stays
        up to date.
        
        Change-Id: I0fe42b633679488fa0d9262c8a840fbe0b93f76a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195376
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 9c9357a350d8e4ca532af36ea26a2fd90e6c9257)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195485
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-11  Justin Luth  <justin.luth@collabora.com>  [1167297d390fc955346b57c3808e0d6e6d315fa3]

        related tdf#165180 sc:don't export dateCompatibility - strict-xml only
        
        dateCompatibility is ignored by ECMA 1st edition (Excel 2007)
        and ISOIEC29500 (Excel 2010+).
        
        This effectively reverts
        25.8.4 commit 990075b66846e78257df7aaa43a23cecf4b7ec9d
        
        make CppunitTest_sc_subsequent_export_test2 \
            CPPUNIT_TEST_NAME=testTdf165180_date1904
        
        Change-Id: I1d3beb2d3d14d983ba83edb8b63d05f127a0eaf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194970
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 0c8944956f2d7bde41412668dca0e727de25f9f3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195115
        (cherry picked from commit ed02bb7938ddaa92e3b49772c73b8ade750b9e0a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195159
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-11  Justin Luth  <justin.luth@collabora.com>  [e16cb27e31d445cbc608be4c10ba4320f4cdf18b]

        related tdf#165180 oox: dateCompatibility not usable in LO
        
        This patch will be needed in order to round-trip
        the Excel 2010+ filter (ISOIEC_29500_2008).
        We can't use dateCompatibility because
        we don't have a "strict xml" filter.
        
        I've only triple checked this,
        so I can't be sure that I've got this right.
        
        WorkbookSettings::getNullDate is mostly dead code.
        
        getOoxFilter().getVersion() == oox::core::ISOIEC_29500_2008
        can only be true when the import filter is
            Calc Office Open XML Spreadsheet
        but that never happens because filterdetect.cxx
            if( rContentType == u"...spreadsheetml.sheet.main+xml")
                returns "MS Excel 2007 XML"_ustr;
        and calc_MS_Excel_2007_XML.xcu doesn't define
            <prop oor:name="FileFormatVersion"/>
        so it is considered to be a zero, which means that
             mxImpl->meVersion = OoxmlVersion( 0 );
        which is oox::core::ECMA_376_1ST_EDITION
        
        So getVersion for XLSX will never equal ISOIEC_29500_2008
        and thus the code this patch deletes has never been executed.
        
        Plus, our code was wrong. dateCompatibility only briefly
        made it into the ISO transitional standards before it disappeared.
        > mstahl:6:35 AM  we are puzzled by an attribute dateCompatibility
        > that is written by Calc since a commit
        > "Merged ooxml-sc-page-date.diff from ooo-build"
        > and was added to ECMA-376 3rd ed.
        > then removed (without explanation) from ECMA-376 4th ed.
        
        Excel only creates dateCompatibility when saving as "Strict Open XML",
        but we don't support OOXMLVariant::ISO_Strict.
        It seems to be ignored by Excel for non-strict formats.
        
        Plus, it wouldn't be needed by LO.
        Excel does not correctly display dates prior to Mar 1, 1900
        because it uses the old Lotus logic that treats
        1900 as a leap year, which it isn't.
        dateCompatibility="0" seems designed to tell Excel
        to consider Feb 29 1900 as an invalid date.
        LO never treats 1900 as a leap year (so no Feb 29, 1900),
        so our (accurate) dates do not match Excel.
        (That isn't a big deal because Excel starts at Jan 1 1900
         and is only wrong for the first two months,
         so we only don't match for the first 2 months of 1900.)
        
        Change-Id: I19ca19334e1f13da010bf09d4c5d9a32aea3a091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194969
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 5f9d0cf0ce3a9b06138bbab62fcd3e6c89c9e339)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195114
        (cherry picked from commit f591c12800aa63dba29230886712617c2e7eba7e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195158
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-11  Karthik Godha  <karthik.godha@collabora.com>  [f9d1c885bdb9ac4e3e60e443587c9c40ef3f998c]

        tdf#169539: PPT->PPTX Draw OLE object data loss
        
        Draw OLE objects are skipped during the export of PPTX.
        
        Change-Id: I21c328a3e322de9fc3d4a18030e53894e7fa2514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194216
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit f6b22383258d6ecd93193240b60d6124791d8699)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195047
        Tested-by: Jenkins
        (cherry picked from commit 258face1158299af6c54c01f8f7a3c94006a7fdd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195089
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [4823ca649caf2c026f36451c1ff32c5aed35583c]

        mso-test: import data has bad percentage value
        
        found by converting tdf34406-1.odp to pptx and running officeotron on the output
        
        INFO - Validating part "/ppt/slides/slide4.xml" using schema "29500T/pml.xsd" ...
        ERROR      - (slides/slide4.xml:2 col:24,296) cvc-datatype-valid.1.2.3:
        '-4900000' is not a valid value of union type 'ST_PositiveFixedPercentage'.
        
        The import data in content.xml looks like:
        
          <style:style style:name="ce8" style:family="table-cell">
            <style:graphic-properties draw:fill="solid" draw:fill-color="#808080"
              draw:opacity="-4900%"
        
        where the opacity value is wildly out of range. So validate on input.
        
        Change-Id: I1d9146a3f38f975a5e229f63e17fca6fb435439b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194950
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 80c58f15baf79f19b954b1199cbca9c2f3dcf8bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194958

2025-12-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d0ce8f5608f870f4fd609b1962744857ab9063be]

        update credits
        
        Change-Id: I937d81dd004004cb91f4b7ab625214fb0d1e42a2
        (cherry picked from commit 7736e497b24257280b44b8ba380ea155f072f46f)

2025-12-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6e1a2f203d7a19cb35fc588a01b6e4cc01f1e544]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to f96fdadd16f016f5fa4237442a807da8a348211a
          - update translations for 25.8.4 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: Ie50de3e431db801da3a34821a7337cc91b164c1a
            
2025-12-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [8be76364f4da0ca0003be46024cb1825310044ba]

        tdf#169730: partially revert the fix for tdf#168452
        
        Revert the problematic part from e5f0dad2b38d2a3902a9cd6b9d434abc206590a4
        "tdf#168452: support unicode-bidi in svg"
        until a better solution is found
        
        Change-Id: If21b0c38b5fd8bdade0538e4960353d156e17e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195307
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit d3df96b5482d10aa4c74c00d21fb3fcddeb6edd0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195352
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-12-10  Jaume Pujantell  <jaume.pujantell@collabora.com>  [d0d51c4e3ea68810280ac0db5fc9c0bf4c030743]

        sd: pptx: fix footer moving places for MSO
        
        In a pptx file with a slide master that has multiple slide layouts, the
        footer would loose properties when saved in LO and opened in MSO.
        This is due to the master de-duplicating logic that in trying to emulate
        pptx's natural way of dealing with master and layout slide it treats
        multiple Impress masters as equivalent. This is needed for most export
        functions, but when exporting an element from an Impress slide that
        references an Impress master (like a footer), we need to differentiate
        exactly which one of the equivalent masters it comes from to make the
        indices match.
        
        Change-Id: I815c3db54256d934b69108c7268f6d7642c33cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194190
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 0f21756af8e74b0dd3f25fe4234feb067430838b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195225
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        (cherry picked from commit f2736a8407ed006741a0d1f55b525e39783b29f1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195360
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-10  Aron Budea  <aron.budea@collabora.com>  [4c94b9a54162680fa99fb15dceb10c1e779fec3f]

        tdf#169825 AutoLayout can be incorrectly exported to PPTX
        
        ...as vertTitleAndTxOverChart, if ODP layout was
        AUTOLAYOUT_NOTES, causing corruption.
        
        PPTX export code directly matched LO's AutoLayout IDs to
        PPTX layout types (OOXML spec: 19.7.15 ST_SlideLayoutType
        (Slide Layout Type)) without conversion, as some don't have
        direct match, and need to be matched to blank layouts. This
        could result in PPTXes that can't be opened in PowerPoint.
        
        It could also result in PPTXes with wrong layout types when
        using LO's own vertical layouts. The files could still be
        opened in PP in this case.
        
        In addition, import code imported vertical PPTX layouts
        with wrong IDs, matching them to notes and handout autolayouts.
        
        Part of the mentioned behavior happened since
        bff76421e234df7246a7f49c71a11432f86e09d1.
        
        Change-Id: Iba7a50795979c22bc566aa2cd6ea4d82f7f9477e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195049
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit eb338daa90afd569e1b86c058bb88a89fab6a557)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195283
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-09  Jonathan Clark  <jonathan@libreoffice.org>  [dbde91402ed01ae7b81ce0da48aaa6fe4dc58dfe]

        tdf#169791 sw: Fix trampled ruby base text with adding selection
        
        Handling for non-contiguous selections in the Asian Phonetic Guide was
        broken by the change that introduced base text grouping. This change
        restores the lost functionality.
        
        Regression from
         commit 3d9b8701cb1751e4139ffa24f72bb836eb877fd1
         Author: Jonathan Clark <jonathan@libreoffice.org>
         Date:   Tue Sep 10 09:06:51 2024 -0600
        
        Change-Id: Id3129f370fa72ab180f41a9816f9cd4d8718f847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195112
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 1e275b2e0f07249a88d760b5a9c63a9589737d3e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195260
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-09  Andras Timar  <andras.timar@collabora.com>  [0428fbee5db4e8164df05d675cc68694ac340379]

        tdf#169871 fix wrong application of color mask
        
        nV5RedMask, nV5GreenMask and nV5BlueMask are valid only
        when used with 16-bpp or 32-bpp bitmap and the bitmap is
        not compressed.
        
        Change-Id: Ic6ca1364a12f9bc11d789e317428cd9c3e144873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195209
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 66e99dae35e8564c8325508f084f501dfff97213)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195248
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c57e447e8a27add4f5cfcb514896a5d8e11579be]

        mso-test: clamp page size to supported range
        
        found by converting ooo127565-1.odp to pptx and running officeotron on the output
        
        INFO - Validating part "/ppt/presentation.xml" using schema "29500T/pml.xsd" ...
        ERROR      - (ppt/presentation.xml:2 col:610) cvc-minInclusive-valid:
        Value '360363' is not facet-valid with respect to minInclusive '914400'
           for type 'ST_SlideSizeCoordinate'.
        ERROR      - (ppt/presentation.xml:2 col:610) cvc-attribute.3:
           The value '360363' of attribute 'cy' on element 'p:sldSz' is not valid
           with respect to its type, 'ST_SlideSizeCoordinate'.
        
        Change-Id: I461b9d07af7f3cda85d57c871a0d88fce977bf9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194957
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 7c92bd105adff1297d632b5f27b4a690e430356c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195012
        Tested-by: Jenkins
        (cherry picked from commit 782d44442f95fb61e05e78e79a788b9da4de67fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195247
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [9172acb07c3b4a27ce1faf12ad5a8bb2ab504562]

        libpng: upgrade to 1.6.53
        
        Downloaded from
        http://prdownloads.sourceforge.net/libpng/libpng-1.6.53.tar.xz?download
        
        Change-Id: I09a817614658880cf1d4e0a162597b2d675bc4e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195245
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 50b39ceb42dda3234e63eebf8d3baedac58ca0f6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195278
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-08  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [8110b0549045ac8bf22514076326a8bbc0803047]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 189f5aa8aff0ff2b3919cce70df65bba9175b929
          - Revert "ScriptForge case-sensitive keys in the Dictionary service"
            
            This reverts commit 4331489799ca3e2e1a0dbbd295f138620f2b136e.
            
            Reason for revert: Breaks string freeze.
            
            Change-Id: I93dccbd129dd6dba6e2c7e33e117bbf4c05e0a86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/195240
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-12-07  Jean-Pierre Ledure  <jp@ledure.be>  [1450b431ca7c2792dc263d339dca6c7319fb4508]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 4331489799ca3e2e1a0dbbd295f138620f2b136e
          - ScriptForge case-sensitive keys in the Dictionary service
            
            Update of help file according
             https://gerrit.libreoffice.org/c/core/+/173044
            
            Change-Id: If309899ce2c15d081d8085555ef473544d771ee6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/195187
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Tested-by: Jenkins
            (cherry picked from commit 246631c6fdb13e9a018c96c72abfc002a07a7f8e)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/195190
            
2025-12-06  Justin Luth  <justin.luth@collabora.com>  [2c92f1698a9d0a46ac5f350d9d3048261e6e9cfb]

        tdf#165207 xlsx/pptx: always use errata uri in docProps/core.xml
        
        This fixes a longstanding bug that has gone unnoticed
        since nobody saves to the "Office Open XML" filters
        and the problem is only seen in MS Office.
        
        So what does this patch fix?
        Basically, all of the meta-data was not being read by MS Office,
        which primarily means no create/modify dates, subject, title etc.
        Every time we saved to OOXML formats (except OOXML 2007),
        we caused MS Office to be incapable
        of understanding anything in docProps/core.xml.
        Telltale sign: when MS Office round-trips
        with an added docProps/core0.xml.
        
        The spec says that ISO 29500 formats should be using
            officedocuments/2006/relationships/metadata/core-properties
        and thus our untouched 2010-era coding
        specified all of that for export (and more recently for import).
        
        > 2.1.33 Part 1 Section 15.2.11.1, Core File Properties Part
        > The standard specifies a source relationship
        > for the Core File Properties part as follows:
        > .../officedocument/.../core-properties.
        > HOWEVER: Office uses the following source relationship
        > for the Core File Properties part:
        > .../package/.../core-properties.
        
        Thus reality is much different than the spec,
        so throw the spec out the window and always write
            package/2006/relationships/metadata/core-properties
        
        Bug 165207 doesn't affect LO in any way - it only affect MSOffice.
        If there was already a unit test writing out to _rels/.rels
        I would have added a test for this, but since there isn't
        I won't bother since I don't see any value in doing so.
        
        Change-Id: I582448adb568ecb630f2fd64712ce372875f71df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195014
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit de25c6c546afdb9be71bd3326af6a5e3f962edbf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195130
        (cherry picked from commit 43a8a5f15e281b169282b5683f4e982a7a88809c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195141
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-06  Karthik Godha  <karthik.godha@collabora.com>  [72cf28877a1b3c8c8acff58aac3d3ef8123185df]

        tdf#169781: PPTX legacy VML files are not imported
        
        Change-Id: Id6eeeab193ac0ed6ff60991508466ffd58005ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194875
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 76e2b197bd7b01c2af7f7ed780e8624c7c40e1fd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195048
        Tested-by: Jenkins
        (cherry picked from commit a547efb681d2da4de357a5d313ee82f925934dce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195090
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-06  Tamás Zolnai  <zolnaitamas2000@gmail.com>  [d02e838774952e6829d76749456e4e4b70c3d602]

        tdf#169807: Fix applying the original page line-spacing option
        
        The saved state of the page line-spacing checkbox was saved only when
        the dialog was first opened. However, the saved state should also be
        updated when a new state is applied to the document.
        
        Change-Id: Ie1e62904027012e57f0fc48c8951a82706f16d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194976
        Reviewed-by: Tamás Zolnai <zolnaitamas2000@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 1d444ea4e30888812657a751b9aa37cf9fd4a648)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195022
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [a19e355e2beb3353e7aa44775f78b6aaf2c3caf2]

        rhino: upgrade to 1.7.15.1
        
        Downloaded from https://github.com/mozilla/rhino/releases/download/Rhino1_7_15_1_Release/rhino-1.7.15.1.zip
        
        Change-Id: Iaa82aecc650a3c2db63c61329fd061f17af56bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194984
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194992
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-05  Noel Grandin  <noelgrandin@gmail.com>  [fe8a0686667c5d4e6bd963aed5d564e9d29d53a1]

        officeotron: fix use of path attribute in vml export
        
        which is only valid for v:shape elements
        
        Change-Id: If650f3073ff4687bcb90791bc8b15bf009d9c71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194483
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195059

2025-12-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [dbfa8ebabb24e0496aeb00c4e56e47819669360d]

        libxslt: upgrade to 1.1.45
        
        it fixes CVE-2025-11731
        
        external/libxslt/gnome-libxslt-bug-139-apple-fix.diff.1 has been
        fixed upstream
        
        Downloaded from https://download.gnome.org/sources/libxslt/1.1/libxslt-1.1.45.tar.xz
        
        Change-Id: If1acddfd1730faedfd015132c132a307509641c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194986
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit ed14fd4aa973326863d7eb7d7e7bb765d22f9c00)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194995
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [8f80681e0e9078a1c460315b0b630c4dee821b12]

        poppler: upgrade to 25.12
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.12.0.tar.xz
        
        Change-Id: I9add82731a4327bf2f48eeaada56b2909bdec906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194982
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 7a0cc0493fcedb44eff1bd41f6aea419dbc5109c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194994
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-12-04  Regina Henschel  <rb.henschel@t-online.de>  [f9e5580569e3ad705d19fe74faeedb56a9ecc4b2]

        tdf#169817 dataprovider insert to correct sheet
        
        Change-Id: I6bd0991cff314abff615371ddba3aa978a442df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194997
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        (cherry picked from commit 13625af3857ae00d341871767b29dbc629d578e0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195009
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-04  Michael Stahl  <michael.stahl@collabora.com>  [87fb7d767efa561d1ccba3b105b0bcad1ec1e595]

        libpng: upgrade to release 1.6.52
        
        Fixes CVE-2025-66293
        
        Change-Id: I1f0aefccf2b80d14e70b423381c121a97e510045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194979
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit f65e262ac15f247f9fabe6d60d3e69d269c68608)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194991
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 698e6705c06f91050a6ccde501a58dc11075daf1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195005
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-04  Karthik Godha  <karthik.godha@collabora.com>  [d0137bc8a96b5aa8bc6c0f7afb686580d3818192]

        tdf#169694: Fix PPTX OLE animations import
        
        When loading a PPTX file animations related to OLE objects are not
        imported properly.
        
        Change-Id: I4656ee3c855459acedbd850c1c2104b532d59308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194622
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit dc6a9c436dfca191fae67c31799e2b2d731551cf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194913
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194978

2025-12-04  Karthik Godha  <karthik.godha@collabora.com>  [d70455697d5e7dff38bb3f0ccc9b4b4c685156ca]

        tdf#169705: PPT -> PPTX invalid values in a:off
        
        PowerPoint is not accepting values greater than Int32 for 'x' and 'y'
        attributes inside 'a:off'
        
        Change-Id: I7929d385b916363d314b3d058184a11dc674247b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194679
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 2ec2ccc51c737d1fcf3b3136d7e8e22e86a827b1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194914
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194977

2025-12-04  Samuel Mehrbrodt  <samuel.mehrbrodt@collabora.com>  [a070a0fb11e895a3e06c336326befd4883f9b797]

        Implement XShapeGroup::enterGroup and ::leaveGroup
        
        has been a TODO item since initial import
        
        Also un-deprecate the XShapeGroup interface.
        There was no rationale given why it was deprecated and it seems
        the functionality is not available elsewhere.
        
        Change-Id: I8fd54d3732fd0ec1c54a2d1b2874e958a77b011e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194409
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        (cherry picked from commit c085b0bdf35a6e9a7f5e3fe94bf3f7f5204648dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194865
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>

2025-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa391cc2811e1efefcec02ccaaa9897252be69f2]

        tdf#169112 lockup when switching to notes view
        
        For reasons I dont understand we end up trying to create
        polygons with millions of points to render the wavy underline here.
        
        Just apply a fairly arbitrary exit to prevent that.
        
        regression from
          commit 79ab5c3775f8d0685585810583b84c0f4d49a1bf
          Author: Armin Le Grand (Collabora) <Armin.Le.Grand@me.com>
          Date:   Fri Aug 23 20:59:55 2024 +0200
          CairoSDPR: Let VclPixelProcessor2D use RedLining decompose
        
        Change-Id: I703eeeb0bd4a9987d9d355493ffd7fa8664c2d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit a07f2ddafcd157fb6161306e375e17c77782df53)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194096
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-03  Jean-Pierre Ledure  <jp@ledure.be>  [892064f39320994331d92b1b7d5f543afcfe92c6]

        ScriptForge Fix Watch close button of all dialogs
        
        Cfr. patch
           https://gerrit.libreoffice.org/c/core/+/184662
        
        Dialogs can either be stored in a library
        or created from scratch.
        
        When run in non-modal mode, the closing of
        a stored dialog with the window Close
        top-right cross was done by LO correctly
        in LO <= release 25.2.
        
        Since 25.8, both dialog created from scratch
        or stored in a library need a coded
        XTopWindowListener to have the job done.
        
        Since above-mentioned patch, SF activated
        a listener for on-the-fly dialogs only.
        
        Change-Id: I6fca927d2a2cea321eba5303d4ff3037f15b5841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194949
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        (cherry picked from commit a9e9c3b2e2ab63121573a1b832dd6ea105d3afc2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194953

2025-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9ded65195f40b55c2f185744cdcef37c3b133e2]

        officeotron: wrong ordering of elements under sdtPr
        
        Change-Id: Ib5ffffe959d0e58c9d3566d10880cc980c8fac99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194784
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194946

2025-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [13aefe6932282eaa318eb548bca2d9c930c87266]

        officeotron: wrong ordering of elements under sdtPr
        
        Change-Id: Idf3fa8d64f93a1b59321b7d0303e33e39254180d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194783
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194945

2025-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9cf3f70df2f1c7a99507ad503b7c57f28f3e5aa5]

        officeotron: wrong ordering of elements under sdtPr
        
        Change-Id: I302a7796f3794148d6c72ecb2295f291bdf807ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194782
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194944

2025-12-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [80353b254c2a75fbe4ab785ffa3f44a32b69b8c6]

        bump product version to 25.8.5.0.0+
        
        Change-Id: I6f2a733f3289477d94d0bd22e8b551bbfc69096e

2025-12-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [feb213a553f8a1bc8dbd983b79b042914097d47a]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 7a0fdb6651537cf3ffb9aee5ea6c5df36e029b23
          - update translations for 25.8.4 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I241043099c149e7e17ea81f98824bed4c0de1934
            
2025-12-01  Dennis Francis  <dennis.francis@collabora.com>  [9222acb014014a77faefb216681dca9fd17173a3]

        cool#13378: unit test
        
        Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
        Change-Id: Iefc327bf57c730a0f50e45745f5735b4349b7bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193826
        Tested-by: Jenkins
        (cherry picked from commit 011d3411b167e031a60bfdab1c947ec5633090de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193857
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-01  Regina Henschel  <rb.henschel@t-online.de>  [56e1b57bd921c2dcaa4bb5932b38ea6c93eb49bd]

        tdf#169077 dataproviderdlg setID expects mxEditID
        
        maID needs to contain the string from mxEditID. In content it needs to
        be the XPath to the desired table element in the imported source.
        You can see the use of this element in the already working unit test
        ScDataProvidersTest::testHTMLImport
        
        Change-Id: If4de7fa345205e5afc2d93a198d88b6788be3700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194789
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 9187f38b48956acc892fbf3e7fe0d1942fcfb6f2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194879
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-01  Gülşah Köse  <gulsah.kose@collabora.com>  [5c4603a058918114c41fa8b7ae189e7e10ef3d92]

        Revert "Prevent cursor invalidation if the cursor position doesn't change."
        
        This reverts commit a260cc52b2fae1382805b4389c95f29ed8671f42.
        This commit causes the view jump on writer.
        
        This commit originally merged for the following issue
        
        Open two writer documents side by side includes hyperlink
        Click the hyperilnk one of them and see hyperlink popup
        Type into the other document
        
        There was a glich on hyperlink popup in the first document
        
        Issue doesn't exist even without this patch. So we remove it completely.
        
        Change-Id: I8a341d66a963ed1943d9f666ba026d7eca240f08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192157
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193082
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit dbe29bc354105314e83edf7069ba34caf73956eb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194882
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-12-01  Aron Budea  <aron.budea@collabora.com>  [29aad31182b878620beb3b6f1de470f98c8251dc]

        tdf#169706 correct unit test and file name
        
        They were referring to the wrong bug report.
        
        Change-Id: I3bb14b0391db75235b34ffe0eb7a23cc484bba6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194838
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit 919b0984ed7bf5cfd599fbf0fcf613121026976e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194876
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [30af0dfd29c1e3c70ae30e2123b7549323870c12]

        tdf#168850, tdf#167075, tdf#169554: Revert "ScViewData: pass ScDocShell by ref"
        
        This reverts commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        
        Unfortunately I had to revert the fix for tdf#167075
        in ea940b7985921883f8f75009186cae24846b1bd4
        "tdf#169554: Revert "tdf#167075: init doc shell before pasting as png/bmp (take 2)""
        because of tdf#169554, which I can't reproduce, so
        reverting the original commit that introduced tdf#167075
        It also fixes other similar issues reported in Bugzilla
        
        Change-Id: I9fc4fac447a8779b3cde21987771792f718067b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194769
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [450652fac898abe541478a4c89b88da1902e6e62]

        Revert "ScViewData: simplify constructors"
        
        This reverts commit 52e3b2b040ac54c2a5661e3676b135170f028f50.
        
        Change-Id: Iefad29b38b1bd5fd4de46a06e491fb3ecc1cebdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194768
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [894dbe5208bb40b7be11f1880f42c6efaf5a76c4]

        tdf#169554: Revert "tdf#167075: init doc shell before pasting as png/bmp
        
        (take 2)"
        
        This reverts commit 671564bce4541244ad3d67b5b98899321176231e.
        
        I can't reproduce the issue on Windows nor on Linux
        but two people confirmed that
        671564bce4541244ad3d67b5b98899321176231e introduced
        the regression in the report
        
        Change-Id: Iead1e460b8280883128b84c1be67209bbb3c6f4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194767
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8c93c3becafb332ceaa65ceb0719a7005b0fff4]

        cid#1494598 Uninitialized scalar field
        
        Change-Id: I2ba162d1411aa01fe0d6b19379119944faebdb7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194816
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-11-29  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [85293b207b1eb977d48f1353975d28817a5872f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 51ddf00170f0a2611526f233010aab55a52eb829
          - tdf#169523 Fix ID and anchor link in VBA Objects help page
            
            Change-Id: I1b7992d3ca627d83f6d544546695a6a6752ae114
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/194821
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            (cherry picked from commit 809cbbbe8c8f4e53fec0088116b8e5bda24586fe)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/194822
            
2025-11-29  Michael Stahl  <michael.stahl@collabora.com>  [078ec0a15638c6a56b8f856ba2d3e80a4fdfcf40]

        tdf#136220 sw: text formatting: fix breaking line with multiple fields
        
        ... when there is an anchored object in the footer, and the last field
        fits only partially on the line.
        
        This stopped working with commit 8e3afdb5989d571410350f1d43fcf26492a4eaff
        removing the IsFooterFrame() check in SwTextFly::GetTop().
        
        Previously a new line below the last line that fits on the page started
        with the field rest portion, when the not-fitting line is deleted in
        SwTextIter::TruncLines() this caused pDel->IsRest() to be true and
        setting SetFollowField(true) which later caused the mbFieldFollow to be
        set in the follow text frame.
        
        Now the pDel->IsRest() is false because the line contains only a big fly
        portion due to the fly in the footer, and then SetFieldFollow(false) and
        the follow doesn't start with the rest of the field.
        
        There is a long standing bug in lcl_NeedsFieldRest() causing this, it
        simply doesn't work if there are multiple fields in a line, it
        erroneously considers the first field to be the last one in the line.
        
        Change-Id: I99e9f68e8e9f8019e4d22ce5d7874d4cdac285e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193474
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d2c387bc609a235406b5c6c434ac4cc06a268513)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193528
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-11-29  Michael Stahl  <michael.stahl@collabora.com>  [09a05c78d5a430ad229c6160261bdff1065be699]

        sw: fix SwDoc::IsInHeaderFooter() with flys
        
        If the node is in a fly, this can only print:
        
          sw/source/core/doc/doclay.cxx:1619: Found a FlySection but not a Format!
        
        This is a regression from commit
        e07feb9457f2ffb373ae69b73dda290140e4005f which used the wrong node's
        anchored objects: of course the fly is never anchored to itself, so this
        will never find anything.
        
        It turns out that there is already a function SwNode::GetFlyFormat()
        that can do most of the work, even using the layout to speed it up, so
        just use that to get the anchor.
        
        Change-Id: I7a22231f929175ed7c5c11724882b03890781cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193476
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193531
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-11-29  Michael Stahl  <michael.stahl@collabora.com>  [428cb59b16325cf86a7036aa923eb0a2088eaa57]

        sw: prevent anchoring SwXShape to its own textbox
        
        SwXShape::setPropertyValue() allows anchoring a shape to its own
        textbox; this actually happens in testTdf146955.
        
        Detect this and throw IllegalArgumentException.
        
        Also catch the exception in GraphicImport::lcl_attribute() so the test
        doesn't fail.
        
        Change-Id: I236e12384e07793e0cf3474fc92657967d9249f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193475
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193530
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [330dfec9c45e25229430eaef46f3553b20b50811]

        mariadb-connector-c: upgrade to 3.3.18
        
        Downloaded from https://dlm.mariadb.com/4516876/Connectors/c/connector-c-3.3.18/mariadb-connector-c-3.3.18-src.tar.gz
        
        Change-Id: I19c247a00673c06135ba5849727b741d18c7f3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194425
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194439
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-11-29  Michael Stahl  <michael.stahl@collabora.com>  [7072175b6e5fb6bb5c528a917c246091e19b599e]

        sw: prevent anchoring SwXFrame to itself
        
        ooo30979-1.doc, converted to rtf, then loaded by writerfilter will
        create a text frame anchored to its own 2nd paragraph, triggering:
        
          sw/source/core/doc/doclay.cxx:1591: bool SwDoc::IsInHeaderFooter(const SwNode&) const: Assertion `pNd != rAnchor.GetAnchorNode()' failed.
        
        Change-Id: I5d0ee2ea406273ca42a50047b40a6d8d8d759f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194121
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 99c7fea26120811dc045bc221f886ca2cca3f9d5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194213
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [49b93a65ae39f86b8d3f85e6f98a2f91a1a5cb18]

        update to officeotron-0.8.4.jar
        
        This reveals a problem with our export of the "dateCompatibility"
        attribute. We actually only want to write that out when targeting
        Word 2007, otherwise we want to use the more normal "date1904"
        attribute.
        
        Change-Id: I972bc7298ecf5026a76d109535a91c0c2544d08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194522
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Code-Style: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit efebbf0107c57a2c3c73251085b90d7e6c06d3b0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194787
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Jim Raykowski  <raykowj@gmail.com>  [d77c88b1e329d596bb3bf861c28e4b5e9a44069a]

        Fix assert in ShowWarning4Modifications
        
        Select some document text, Menu > Insert > Table of Contents and
        Index..., press Close, press Yes or No or X in the query dialog.
        
        results:
        
        vclptr.hxx:123: VclPtr<reference_type>::~VclPtr() [with reference_type
        = AbstractQueryDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef-
        >isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to
        call dispose()"' failed.
        
        stack:
        
        8  VclPtr<AbstractQueryDialog>::~VclPtr vclptr.hxx 123
        9  SwIndexMarkPane::ShowWarning4Modifications swuiidxmrk.cxx 763
        10 SwIndexMarkPane::CloseHdl swuiidxmrk.cxx 710
        
        Change-Id: I3b651fdd01a2e12c747540b48af0ec389d00dbf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194536
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit 7b30a180fb529d546b7f70e3bf4abc271371c81f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194758
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Aron Budea  <aron.budea@collabora.com>  [d93ff51910f2c61949460eecc6fe6c0348ca652b]

        tdf#169438 sd: reference to missing audio results in invalid PPTX
        
        In slideX.xml the 'p:sndTgt' element would be incomplete.
        
        Happened since d98d3e2a0bc087ec9157e8e32e9f0ea4207d36e2.
        
        Change-Id: I3af20cc95abb86db393b6e2a03af379b8dc51360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194706
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 0cf6caa3c267805dc99c8c138656f901879e80fa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194786
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Justin Luth  <jluth@mail.com>  [83e579322ec4137e7d1bb2d42938511b1eb19a03]

        UnoApiTest: Add enum for filter names (non-intrusive backport)
        
        This is a backport of 26.2 801dc48c6f7df686574c76e8ca67ac59dd1604f8
        and 6675e7893ebe8d59ed3975b1cbd4f3673e66e746
        to simplify backporting unit tests - allowing both new and old way.
        
        Change-Id: I4dad6f77853b53b74150dab0edaf41c5ff5b4f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194798
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Weblate  <noreply@documentfoundation.org>  [acbc817ef0cab58b0ce86b76b1c4025dc82822ea]

        android-viewer translated using Weblate
        
        Tagalog currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I472df192bbcbd38c40924851b0d6c5e48fb40495
        Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/tl/
        Translation: android-viewer/android-strings-25-8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194664
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [cca30ce7a043cdeab43ad2cf3b6bf92c574346c4]

        tdf#169399: try again when frames were moved forward by objects
        
        The problem in the bug document was caused by the extra call to
        SwFrame::OptCalc in SwLayAction::FormatLayout. It was there since
        initial import, as a shortcut; but its conditions were changed in
        commits 610c6f02b11b4b4c555a78b0feb2a1eb35159e39 (tdf#156724
        tdf#156722 tdf#156745 sw: layout: partially remove IsPaintLocked(),
        2023-08-14), 61a78a523a6131ff98b5d846368e5626fe58d99c (tdf#156724
        tdf#156722 sw: layout: remove IsPaintLocked() check, 2023-08-15).
        Commit c303981cfd95ce1c3881366023d5495ae2edce97 (tdf#156724 sw:
        layout: fix tables not splitting due to footnotes differently,
        2023-08-24) had dropped that code completely, but it was restored
        in commit 397d72e582c725d162c7e0b819dc6c0bb62e42b0 (Related:
        tdf#158986 sw floattable: fix unexpected page break with sections,
        2024-02-23), with more strict conditions. Its conditions were
        restricted in commit 607fcac441c7f3a7d3c169c19039e581d707f2bb
        (tdf#160067 sw floattable: fix missing move bwd of paras in split
        section frame, 2024-04-08). There, it was noted, that "probably a
        cleaner way would be to completely stop calculating content frames
        in SwLayAction::FormatLayout() and only do that in FormatContent()",
        which emphasizes the problematic nature of that code.
        
        I looked into restricting the conditions there more for the bug
        document, but failed to come with the working condition. So the
        change drops that code again, and tries to keep the bugs fixed by
        re-introduction of that code fixed.
        
        My understanding of the mechanism causing tdf#158986 is following:
        
        Document's SwLayouter keeps track of the nodes, which frames were
        moved forward by objects. This data will disallow those frames from
        moving backwards (see uses of SwLayouter::FrameMovedFwdByObjPos).
        
        The problem in the bug document comes from the fly attached to a
        paragraph inside a multicolumn section. During the iterative layout
        of the section, there is a stage where the height of the section is
        too small for the object, and its paragraph gets moved forward to
        a new page (together with some previous paragraphs). When layout
        finishes, the height of the section is enough, but the paragraph
        cannot move back, keeping the extra page.
        
        I tried hard to solve it in many less-bruteforce ways. The ideas
        included prevention of the wrong too small section height during
        layout (e.g., in lcl_FormatContentOfLayoutFrame); attempts to find
        a place where a specific "moved forward" record becomes obsolete
        and should be removed (tried to modify fly.cxx' CalcContent and
        SwObjectFormatterTextFrame::DoFormatObj); and modifications to let
        page body's resize code (called when a section's height is changed)
        to re-position the objects. But all these attempts produced layout
        loops.
        
        This change introduces a hack. In SwLayAction::Action, when the
        first call to InternalAction increases the number of frames that
        were moved forward, it clears the layouter entries, and tries once
        more. I hope that at some point, a better fix will be possible.
        
        Change-Id: I47315473982cb1fe5c8d77f7603cd24de08afa89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194712
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194759

2025-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [136bf6b24267945c9fffffdeacf2d3fb10ff427d]

        avoid terminate after unhandled exception
        
         #3  0x00007e29f0a42476 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
         #4  0x00007e29f0a287f3 in __GI_abort () at ./stdlib/abort.c:79
         #5  0x00007e29f0ea2b9e in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6
         #6  0x00007e29f0eae20c in ?? () from /lib/x86_64-linux-gnu/libstdc++.so.6
         #7  0x00007e29f0eae277 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6
         #8  0x00007e29f0eae4d8 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6
         #9  0x00007e29ead812a5 in SfxBaseModel::MethodEntryCheck (this=<optimized out>, i_mustBeInitialized=<optimized out>)
             at sfx2/source/doc/sfxbasemodel.cxx:3069
         #10 0x00007e29eca6d629 in SfxModelGuard::SfxModelGuard (i_eState=SfxModelGuard::E_FULLY_ALIVE, i_rModel=..., this=0x7ffc94a61ec0)
             at sfx2/source/inc/docundomanager.hxx:76
         #11 SfxBaseModel::getIdentifier (this=0x27ad5ab0)
             at sfx2/source/doc/sfxbasemodel.cxx:4015
         #12 0x00007e29ec098e03 in (anonymous namespace)::ModuleManager::implts_identify (this=0x328c9cc0, xComponent=...)
             at framework/source/services/modulemanager.cxx:327
         #13 0x00007e29ec0991f3 in (anonymous namespace)::ModuleManager::identify (this=0x328c9cc0, xModule=...)
             at framework/source/services/modulemanager.cxx:191
         #14 0x00007e29ecaa8e0e in sfx2::SfxNotebookBar::IsActive (bConsiderSingleToolbar=<optimized out>)
             at sfx2/source/notebookbar/SfxNotebookBar.cxx:324
         #15 0x00007e29ecaa95ab in sfx2::SfxNotebookBar::StateMethod (pSysWindow=0x36778bf0, xFrame=..., rUIFile=...,
             bReloadNotebookbar=<optimized out>)
             at sfx2/source/notebookbar/SfxNotebookBar.cxx:444
         #16 0x00007e29dd85707b in sd::DrawDocShell::GetState (this=0x367c3290, rSet=...)
             at sd/source/ui/docshell/docshell.cxx:327
         #17 0x00007e29ec8b67fe in SfxShell::GetSlotState (this=0x367c3290, nSlotId=nSlotId@entry=10338, pIF=<optimized out>,
            pIF@entry=0x0, pStateSet=pStateSet@entry=0x0)
        
        Change-Id: I13918818c04138848020ab8bdb646b0cb08f130a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Code-Style: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 10090f36de159d8e6886ddac3326253ea716d26f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194661
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [83df10daafc9f73cbfbce7e8172de957eb7390b2]

        mso-test: element p:sldSz has invalid cx and cy attribute
        
        found by converting tdf43054--1.odp to pptx and running officeotron on the output
        
        Validating part "/ppt/presentation.xml" using schema "29500T/pml.xsd" ...
        - (ppt/presentation.xml:2 col:1,116) cvc-minInclusive-valid:
        Value '900113' is not facet-valid with respect to minInclusive '914400' for type 'ST_SlideSizeCoordinate'.
        
        We get the slide size from the master page, and this page appears not to have any
        width or height values at all, so use a useful value in that case.
        
        Change-Id: I3624b4ba79ec4919655995c20d729b22ff443641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194701
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2d82d56d3f536ba2bbe0496c4f6488e61a2247cb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194752
        Tested-by: Jenkins
        (cherry picked from commit 7902c87f479afaa4f6955c6e933d98317fe5257f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194785
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [147f2fe0e46ef030ccee10581b97ffdce770b79f]

        fix typo: BLN -> BGN
        
        After
        commit 37d1cc071ba0cc7f9922c4409d0a014a722ebbce
        Author: Rene Engelhard <rene@rene-engelhard.de>
        Date:   Sat Aug 9 19:05:15 2025 +0200
        
            add EUR for Bulgaria/Lew
        
        Change-Id: I6679404cba0be0219bf7ede06297f9b1c990e8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194760
        Reviewed-by: Eike Rathke <lo@erack.de>
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194766

2025-11-28  Michael Stahl  <michael.stahl@collabora.com>  [5cc5e0a2cc9ee5b7ccef19589b4c2e4bbd78586f]

        tdf#168897 winaccessibility: fix JAWS crash with CAccTable
        
        stack:
        
         	UAccCOM.dll!ATL::CComObjectRootBase::OuterAddRef() Line 2631
         	UAccCOM.dll!ATL::CComContainedObject<CAccImage>::AddRef() Line 3719
         	AccEventCache.dll!00007ffd2039be28()
         	AccEventCache.dll!00007ffd20355677()
         	AccEventCache.dll!00007ffd20346d41()
         	AccEventCache.dll!00007ffd20347f9a()
         	AccEventCache.dll!00007ffd20338ba2()
         	AccEventCache.dll!00007ffd20380dd8()
         	AccEventCache.dll!00007ffd2037fd7b()
         	AccEventCache.dll!00007ffd2037f7ee()
         	AccEventCache.dll!00007ffd2037d9e6()
         	AccEventCache.dll!00007ffd2037d07f()
         		^ JAWS
         	GlobalHooksDispatcher.dll!00007ffd214daed4()
         	GlobalHooksDispatcher.dll!00007ffd214d8d84()
         	user32.dll!00007ffd492068ac()
         	ntdll.dll!00007ffd4ae71424()
         	win32u.dll!NtUserNotifyWinEvent()
         	winaccessibility.dll!AccObjectWinManager::NotifyAccEvent(com::sun::star::accessibility::XAccessible * pXAcc, UnoMSAAEvent eEvent) Line 182
                	^ selfAccObj looks very dead here but that is a red herring!
         	winaccessibility.dll!AccContainerEventListener::FireStateFocusedChange(bool enable) Line 351
         	winaccessibility.dll!AccContainerEventListener::SetComponentState(__int64 state, bool enable) Line 178
         	winaccessibility.dll!AccParagraphEventListener::SetComponentState(__int64 state, bool enable) Line 123
         	winaccessibility.dll!AccContainerEventListener::HandleStateChangedEvent(com::sun::star::uno::Any oldValue, com::sun::star::uno::Any newValue) Line 106
         	winaccessibility.dll!AccContainerEventListener::notifyEvent(const com::sun::star::accessibility::AccessibleEventObject & aEvent) Line 72
         	winaccessibility.dll!AccParagraphEventListener::notifyEvent(const com::sun::star::accessibility::AccessibleEventObject & aEvent) Line 77
         	comphelper.dll!comphelper::AccessibleEventNotifier::addEvent(const unsigned long _nClient, const com::sun::star::accessibility::AccessibleEventObject & _rEvent) Line 256
         	swlo.dll!SwAccessibleContext::FireAccessibleEvent(com::sun::star::accessibility::AccessibleEventObject & rEvent) Line 457
         	swlo.dll!SwAccessibleContext::FireStateChangedEvent(__int64 nState, bool bNewState) Line 478
         	swlo.dll!SwAccessibleParagraph::InvalidateFocus_() Line 397
         	swlo.dll!SwAccessibleContext::InvalidateFocus() Line 1314
         	swlo.dll!SwAccessibleMap::InvalidateFocus() Line 2695
         	swlo.dll!SwViewShell::InvalidateAccessibleFocus() Line 2597
         	swlo.dll!SwEditWin::GetFocus() Line 5569
         	vcllo.dll!vcl::Window::CompatGetFocus() Line 3891
         	vcllo.dll!vcl::Window::ImplGrabFocus(GetFocusFlags nFlags) Line 385
         	vcllo.dll!vcl::Window::GrabFocus() Line 2983
         	sfxlo.dll!SfxFrame::GrabFocusOnComponent_Impl() Line 650
        
        The problem is quite simply that CMAccessible::SmartQI() returns a
        pointer that is the result of querying the newly created COM aggregation
        for IID_IUnknown instead of the requested `iid` interface.
        
        Apparently the wrong result happens to work in many cases, but the
        CAccTable actually has 2 interfaces IAccessibleTable and
        IAccessibleTable2, and the COM aggravation for IAccessibleTable2 is the
        one that crashes; in this case the correct pointer is an offset of 8 to
        the start of CAccTable, while in the working cases there is no offset.
        
        So likely the bug was introduced by commits
        3b86569fcba210eb6570fabef7ff8abf6aff91f0 and
        d0e8e6e3cd51736583603e37f0ba2ff7bdf29f5c but only started to crash with
        839dbf9ecf9f8fbec7de983d1a2e16d7de6f868c.
        
        Change-Id: I7c7d295c8032b95fe7f64b8da4dd9bc3212563f9
        (cherry picked from commit 9502a9f76731afa0f5105e6d79b069222677f88d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194730
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit b2c03ef9c7f6886196d6bfaa57e2b64bdfe248ab)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194757
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-28  Michael Stahl  <michael.stahl@collabora.com>  [5251f4a13ad950e40d97ff24be23f11fb64bccd0]

        tdf#167362 sw: fix footnote hang with JAWS
        
        When moving the cursor to a line with a footnote, JAWS tries to retrieve
        the text attributes, gets an E_FAIL, but never gives up trying again.
        
        The problem is that some entirely undocumented magic number is stuffed
        into an uno::Any as `long` but the "CharEscapement" property is actually
        `short` and thus reading the property in
        AccessibleTextAttributeHelper::ConvertUnoToIAccessible2TextAttributes()
        throws and this is caught by CAccTextBase::get_attributes() and E_FAIL
        is returned.
        
        >	vcllo.dll!o3tl::doAccess<short>(const com::sun::star::uno::Any & any) Line 284
         	vcllo.dll!AccessibleTextAttributeHelper::ConvertUnoToIAccessible2TextAttributes(const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rUnoAttributes, IA2AttributeType eAttributeType) Line 271
         	vcllo.dll!AccessibleTextAttributeHelper::GetIAccessible2TextAttributes(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleText> xText, IA2AttributeType eAttributeType, long nOffset, long & rStartOffset, long & rEndOffset) Line 346
         	UAccCOM.dll!CAccTextBase::get_attributes(long offset, long * startOffset, long * endOffset, wchar_t * * textAttributes) Line 145
         	UAccCOM.dll!CAccText::get_attributes(long offset, long * startOffset, long * endOffset, wchar_t * * textAttributes) Line 54
         	FSDomNodeSymphony.dll!00007ff93f0fea12()
                    ^ JAWS
        
        Change-Id: I6c487f9d2db462b787034df3d5ba2f2822d14746
        (cherry picked from commit 776662481583935ca148930de1e91ea499c53b3a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194737
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e3a9530f294f9c978a46da43a4a1420644158984)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194756
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Michael Stahl  <michael.stahl@collabora.com>  [9aed505475b5ce85c9cd6c1baaec4c70d0cb6cc0]

        tdf#169314 configure: default to --without-system-libxml (Linux)
        
        Tragically libxml2 2.14 changed the SONAME to libxml2.so.16, breaking 25
        years of ABI compatibility.
        
        Debian sid and Ubuntu 25.10 both appear to ship only libxml2.so.16 with
        no compat package for libxml2.so.2
        
        configure has always defaulted to preferring system libxml on
        Linux/macOS but that used to be overridden for release builds before
        commit b20f17ce082f30b0a2afd0d311f63f6b2ad8a99a
        
        Change-Id: I7d9b27bd7334ae4ade8c9b58fcf2cd0f9f07fab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193735
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 8e52bae5c42f28eeb57944b21d0d7a80d701f844)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193970
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [fd7facf439be9e0f0e464205343c13cb5a68268f]

        tdf#80959: fix percent character escaping in dp_misc::(en|de)codeString
        
        The intention that these functions, that use % as a special character,
        escape existing % with another %, was documented in comments at both
        functions. But it had never been implemented properly.
        
        In encodeString, the code did wrong calculations, and wrote first
        special character (either %, or 0x00-0x0F) verbatim; and only then
        processed following characters according to the algorithm. That meant
        that an input with percent-encoded space, like
        
        Foo%20Bar
        
        was checked until the percent; then first four characters "Foo%" were
        copied to the resulting buffer; and then the rest of characters were
        sequentially checked for % or 0x00-0x0F (and none of them were). The
        result was unchanged "Foo%20Bar", instead of expected "Foo%%20Bar".
        
        In decodeString, despite the idea that %% must convert to %, the code
        didn't expect anything except 0-9 and A-F after the first %. As the
        result, an input string of "Foo%%20Bar" would become "Foo\EEBar", and
        "Foo%20Bar" would become "Foo\020Bar".
        
        This was that way since introduction of this code in AOO in commit
        65415c716863d17196eae2a4a7f86f2e0ba5c1b6 (#i118662# remove usage of
        BerkeleyDB in desktop module, 2011-12-12), ported to LO in commit
        daeed90f4586eb9533041fb89bee163a5193596c (re-base on ALv2 code.
        Includes:, 2012-11-19).
        
        This change fixes and unifies the logic of both of the functions.
        
        Change-Id: Ice5d078b007dbffacea247daaf81bde9c6386963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194066
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 5028a5f7564b8a2d8df626feb1a6a85ee8a65db3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194095
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [7ff5692e8e0cf95a17d9e8d88a2f89af52c086e6]

        tdf#168943: Handle non-multimarked mark data
        
        Add the respective code to ScTable::Apply, which somehow got lost in
        commit b5da114b67b29c91d16f2cb618cf30e7aa1b068d (Move code applying
        functor to selection from ScColumnData to ScTable, 2025-03-15).
        
        Change-Id: I0a9b6d9695a604c091eaca4c7b4e822c4e8c8781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194386
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194418

2025-11-27  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [fd1b7b7635fcddabafb3b6c4b27ebe5d5bac9e01]

        tdf#157211: don't limit range to data range when opening DB name dialog
        
        This behavior is not what the user expects and we don't
        need to init the mark block mode again. This is already
        taken care off by the GetDBData code.
        
        Change-Id: I58556642ae696e32065e76e68b9eaca082863dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194182
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 512edf27d5593b2123034c5797b2bee3b27bf307)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194238
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [114ab9c93d241a83da3e0842ddbccf004687d966]

        mso-test: invalid datetime in props
        
        This is using the test document from tdf119234-3.odt.
        When importing and exporting to DOCX, we generate an invalid entry in
          docprops/custom.xml
        because we dont know how to handle a DateTimeWithTimezone value..
        
        Change-Id: I79981f8a09db432730a9b0c1cf186305b0055923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193400
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 97cf170c20c7ff1e1b3820a769cd3167a57d0c46)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193600
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 5a9e966b323a1605976a53ca6bac750741036eba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193723
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [a62e6c819192d77251a9643dc229b82fcdcc6c91]

        tdf#158921: fix invalid OOXML during pivot table export
        
        Change-Id: Ie3f0fb7302c21d56fedff8db3f2b1c2b7a5805eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188079
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit b5837d2667c2be2c485753f9cf75e84032a15f74)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194211
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7439a873217eb75aa7256b5b4008d8e6324d27f9]

        a null mpDoc was seen here
        
        under windows
        
        Change-Id: I638a0bd77538db7200bdc2c705f51ec031bcdb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194548
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Code-Style: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit e257b5a28896f140c4b47c258491031a0bec06bb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194678
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Code-Style: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit ef93d3951da8a61543eac82baa99a977c8b70935)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194702
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-27  Regina Henschel  <rb.henschel@t-online.de>  [39948910b829d6ce93dd8fbc89095a3f772df0e9]

        tdf#169541 DataProvider avoid corrupt backreference
        
        If a document has defined more than one calcext:data-mapping element,
        the import builds a vector DataResources in the ExternalDataMapper.
        Error was, that not the current last item in the vector was refreshed
        but always the first one.
        
        If more than one DataResource exist, those before the last one have a
        corrupted backreference to the data provider. I have not found where
        this happens. Therefore, I now create in each refresh a new one. That
        is the same as done in the first refresh. If someone finds where it
        becomes corrupt it could be fixed differently. However, since the
        error causes a crash, we should use this solution in the meantime.
        
        Change-Id: If489c8e599bf44333c4936c608392c22d0f02d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194433
        Tested-by: Jenkins
        Code-Style: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194691

2025-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [6fa74808253dc1a8770234e971b775e3af202aed]

        CppunitTest_sc_dataprovider: re-enable testBaseImport test
        
        This is possible after my previous patch
        22a987d3eecd80a1f50c1b72cf5ce921f1151ad5
        "CppunitTest_sc_dataprovider: use gb_CppunitTest_use_rdb"
        
        Change-Id: Ibc73a0167479c9c3d77125f65a92cd2d1f74c9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194553
        Tested-by: Jenkins
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194690

2025-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c1dfad3bd6efd872c838d8ea1793b234336a0f1]

        CppunitTest_sc_dataprovider: use gb_CppunitTest_use_rdb
        
        Change-Id: I5aec844fbd5799acd62641050b57fd9fefc56b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194552
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194689

2025-11-26  Karthik Godha  <karthik.godha@collabora.com>  [12c639145df4450f7cba3abe0628ad016071a3a5]

        tdf#168843: Sanitize font size read from PPT
        
        Add validation checks for font size when importing a PPT. Minimum
        accepted value for font size is 100.
        
        Change-Id: I0c00705eafde1befe459cf8ba52ce32b1dbfbd5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193539
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 28273e586b398e2ce181c4ce9e740949fad11876)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194633
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 5f1043dab5435ae036bcbca288ca5c55d4bd930f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194651
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Aron Budea  <aron.budea@collabora.com>  [8af6771f8ec56185e15762ad1aac11177e8e3404]

        tdf#169675 sd: animation on 3D object results in invalid PPTX
        
        3D objects are only supported in ODP, and don't get exported
        to PPTX. Animations on them did get exported, resulting in
        invalid 'spid' (-1) and invalid OOXML.
        
        Reuse ShapeExport::IsShapeTypeKnown(...) introduced in
        ab45b8d9959f8f392a10d0874c50f26b816a4da8.
        Note the extra entries in
        PowerPointShapeExport::WriteUnknownShape(...), these are
        already covered by the second half of isValidTarget(...).
        
        Change-Id: Ieb1dc1475b036fe4f24d84cee17b9af544c5bb18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194543
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Code-Style: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2f32f2a9a84ff0d66b5dd608fb20fdeb7b7f99a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194638
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Noel Grandin  <noelgrandin@gmail.com>  [e3c8805ee47067c89a6430d2e6c9bba2b67e9239]

        officeotron: avoid writing <w:i/> twice
        
        Change-Id: I58f9d359aa66155e17686695642317948b839b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194527
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Code-Style: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194640
        Code-Style: Miklos Vajna <vmiklos@collabora.com>

2025-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [be883d564e9bb74e869f55e01950b81b70e2723e]

        android: Hide settings menu entry if there are no settings
        
        All settings displayed in the SettingsActivity
        are related to editing, and only displayed
        if the build includes the editing feature.
        
        Therefore, don't show the settings menu item when
        using a build config that doesn't include that feature,
        i.e. only show the item for the strippedUIEditing
        product flavor, but not the strippedUI or quest
        ones. For the latter two, an activity only displaying the
        "General" heading would be shown, but nothing
        else could be done, which was rather confusing.
        
        Change-Id: I2a1a616c1faee18583320ccb16e717dc933d6565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194534
        Code-Style: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 5bd9b087c24d29b76e7fac6a991ef6fda2ef8d9f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194541
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [494e3ed0c106ad0c6659b9ca570e4cd4f5511aa8]

        android: Have a single method for menu item (de)activation
        
        Instead of having one method that enables/disables a menu
        item and one that shows/hides it, let
        ToolbarController.setItemVisible take care of both.
        Use that method also where ToolbarController.enableMenuItem
        was used before and drop that now unused method.
        
        The way that hiding/disabling menu items was and is used
        is to do that when they are not applicable, in which case
        it seems reasonable to consistently both hide and disable
        them at the same time.
        
        Quoting from the MenuItem.setVisible doc [1]:
        
        > Sets the visibility of the menu item. Even if a menu item is not
        > visible, it may still be invoked via its shortcut (to completely disable
        > an item, set it to invisible and disabled).
        
        [1] https://developer.android.com/reference/android/view/MenuItem#setVisible(boolean)
        
        Change-Id: I5d05f5324a1fb5c69e38302b59b2ad56a45342ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194533
        Tested-by: Jenkins
        Code-Style: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 8d015346d0ac21da7a4908ea35d2f736e9a0cc97)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194540
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [4e5e23c995f7aaa13d90e036e6a7843def5f9edc]

        android: Set activity size for Meta Quest in new product flavor
        
        For Meta Quest devices running Horizon OS, it is required
        that the default activity size is set to 1024x640,
        see also [1].
        
        Add a new product flavor "quest" with an additional
        AndroidManifest_quest.xml that sets the corresponding
        attributes for the 2 main activities.
        
        Due to the manifest merge logic as described at [2],
        it is sufficient to only specify those extra
        attributes. The rest is taken from the main
        AndroidManifest.xml used for all build flavors.
        
        This makes the LibreOffice Viewer app on a Meta Quest 3
        VR headset open in the specified size in landscape mode,
        while it was previously opening in a smaller window in
        portrait mode.
        
        Also, disable the experimental editing mode for that product
        flavor, as it seems to be even more experimental when tested
        on a Meta Quest than on another Android device.
        (Document UI doesn't update while typing.)
        
        The build flavor can either manually be selected in
        Android Studio ("Build" -> "Select Build Variant")
        or specified for the gradle target, e.g.
        
            ./gradlew assembleQuestRelease
        
        [1] https://developers.meta.com/horizon/documentation/android-apps/panel-sizing
        [2] https://developer.android.com/build/manage-manifests#merge-manifests
        
        Change-Id: Ia2b234f50694553d2b3458e4c57e8bb1b1a5baa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194532
        Code-Style: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit b39da4be6fef36090f94ad5a6b19f602f65bfa9f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194539
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [f7ca9b187abe6d901fc331319698e73e052633ae]

        android: Deduplicate assets specification in build.gradle
        
        It's the same for both product flavors, so
        define it once for the main one that is the base
        for both of them, and all upcoming flavors, too.
        
        Change-Id: I0532332c0780bac5099a2d98601664b3cf709777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194531
        Tested-by: Jenkins
        Code-Style: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 72f7e3e5c5bccd0c21685e5e37751c1140cc6a87)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194538
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [18c9694ad3c27410bdef5e6aed9a4d6686dfce5b]

        android: Drop non-working fullUI build variant
        
        That build variant whose build could be triggered
        e.g. by running
        
            ./gradlew assembleFullUIRelease
        
        from `android/source` would fail to build for
        a long time already, like this:
        
          /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java:189: error: cannot find symbol
                  final boolean bEditingEnabled = BuildConfig.ALLOW_EDITING && preferences.getBoolean(LibreOfficeMainActivity.ENABLE_EXPERIMENTAL_PREFS_KEY, false);
                                                             ^
            symbol:   variable ALLOW_EDITING
            location: class BuildConfig
        
        In addition, it would be the default variant
        used by Android Studio, so in order to get
        a working build, it was always necessary to
        explicitly switch to another variant first
        (using "Build" -> "Select build variant").
        
        Drop it altogether, since it's unused.
        (It would include all of the .ui files
        in the APK while the other build variants
        explicitly specify what files to include.)
        
        Change-Id: I0a6096ec69897eb57f41c512e88a4c1a848480ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187623
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit ac43e554935bf6e39d3c15e31d9e3535a3e6449d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194529
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-26  Weblate  <noreply@documentfoundation.org>  [c274d43e79b4d85d3f9ebbce3db260d06e37fa73]

        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (116 of 116 strings)
        
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings-25-8/ast/
        Translation: android-viewer/android-strings-25-8
        Change-Id: Ibba53f0dfadd10c12b69b3bff366c689cd1775b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194498
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Code-Style: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-11-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fdc4cf238693b5a6f3c47f93f5f92c6aae329117]

        tdf#162711 - VBASupport requires banker’s rounding for integer conversions
        
        Change-Id: Ife3f7aae3ba094fe83a5eda6b3d50d9358cc1184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194286
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        (cherry picked from commit 76aafa18b7a81363a642c5b0ea381ea71c5e5185)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194485
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Code-Style: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-24  Michael Stahl  <michael.stahl@collabora.com>  [6e449a98d2d2bd3d03b9e01277b176b5dc552f50]

        libpng: upgrade to release 1.6.51
        
        Fixes CVE-2025-64505, CVE-2025-64506, CVE-2025-64720, CVE-2025-65018
        
        Change-Id: Id58827859de899aea020f43835f2b37bf262ed33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194421
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 313c6d0a0d8a65e23e06ebcae08e0249f9f0d749)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-24  Regina Henschel  <rb.henschel@t-online.de>  [a9cdf33f7c21a519dc53ee07b2df87c2137cdc50]

        tdf#169122 no TextWritingMode if GraphicWritingMode2
        
        TextWritingMode and ControlWritingMode are suppressed when
        ShapeWritingMode exists.
        With commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad we have in addition
        GraphicWritingMode2. Thus suppress them in that case too to avoid
        duplicate attributes.
        
        Change-Id: Ie7064e2dcea3a6dccc081f03bf027c1e7a261bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194371
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194417

2025-11-24  Karthik  <karthik.godha@collabora.com>  [0b94f192daf0b0d0b97432da411ba27000417df9]

        tdf#168736: Fix interop: PPT->PPTX images with internal-links
        
        When PPT files with pictures containing links to internal slides are
        saved as PPTX, it results in corrupted XML output.
        
        Change-Id: Ie5ec67d342d64e2412eb6979e6c2cb58d4a8f97a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193017
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit b19957e1bbd596462a6601847833c5435c57afd0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194234
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194435

2025-11-24  Karthik Godha  <karthik.godha@collabora.com>  [d7629d7f843e5a02c1188efc94cb44b66f576d8b]

        Impress Unit Test: Test to check proper export of TimeAnimateValue
        
        Test related to the following commit
        06df3ad0b2fa771757c90f53dd1f33265a3912dc
        
        Change-Id: I9256e94af6fb495ddb2694ee6b0a03243219fc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193232
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194434

2025-11-24  Justin Luth  <jluth@mail.com>  [45a0bb0d209d6b5ace519ed13de890f79e43fe9a]

        tdf#150150 Revert "draw Note mark before text for correct ZOrder"
        
        This reverts 5.0 commit 2d1abfff0156c17cdaabf27c01e92b5e3f0bbbf4.
        
        The comment marker is not nearly as obstructive
        as it was back in 5.0 days.
        
        Change-Id: Id5596be2ede154e5c9302a23853b5fcaf724c1c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194343
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194429

2025-11-24  Justin Luth  <jluth@mail.com>  [07e529abf77c582233587574b864c28387506ba9]

        tdf#166185 vcl PrinterController: auto orient in getRealPaperSize
        
        This patch fixes the situation
        when you print a landscape-page-styled document
        and chose a different paper size (i.e Letter -> Legal)
        'automatic orientation' no longer is portrait.
        
        This also allows some pages being in landscape mode
        while other pages are portrait.
        
        Change-Id: Iec22ab7a196a775a2a589ae3e9f76114e50db1c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192926
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit cae2ae964468b3aa5b773676a4c67b40e305725e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194427
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-11-24  Miklos Vajna  <vmiklos@collabora.com>  [79f08a9c2c001721019ad5a1957113c516a4f354]

        sd: fix crash in SdXImpressDocument::postMouseEvent()
        
        gdb trace on the core file:
        
        	#0  0x0000774df1e04d9d in SdrPageView::GetPage (this=0x0) at include/svx/svdpagv.hxx:167
        	#1  SdXImpressDocument::postMouseEvent (this=<optimized out>, nType=2, nX=<optimized out>, nY=<optimized out>, nCount=1, nButtons=0, nModifier=0)
        	    at sd/source/ui/unoidl/unomodel.cxx:4370
        	#2  0x0000774e00fbec12 in doc_postMouseEvent (pThis=0x3cd69250, nType=2, nX=-180, nY=2220, nCount=1, nButtons=0, nModifier=0)
        	    at desktop/source/lib/init.cxx:5661
        	#3  0x000000000058ab29 in lok::Document::postMouseEvent (nModifier=0, nButtons=0, nCount=<optimized out>, nY=<optimized out>, nX=<optimized out>, nType=<optimized out>,
        	    this=<optimized out>) at include/LibreOfficeKit/LibreOfficeKit.hxx:297
        
        Handle it similar to the nullptr sd Window just a bit later.
        
        Change-Id: I7a6e7dfc6971f266e1205ee3b92eb1ed5bae1025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194339
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2eee4d959840b100b193792e2c8d072254ad78b9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194419
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a253459637241a7cfedd44f67c249bbd4447d07c]

        tdf#158036 Incorrect positioning of rotated SVG text when padding is applied
        
        this path is no longer the default for gtk3 where the SDPR renderer is
        the default so there:
        
        export DISABLE_SYSTEM_DEPENDENT_PRIMITIVE_RENDERER=1
        
        is needed, though it is still the default for the gen backend, so that
        can be used too
        
        Change-Id: If64b7805ee4987ceab5af99decdf755280270e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194079
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 8e764204b49d0be0742ccad68bc6d1e2b8726875)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194164
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-24  Karthik Godha  <karthik.godha@collabora.com>  [59a62908e78833efefcf3b61cdcac1ad6bb1acef]

        tdf#169487: PPT->PPTX Fix export of a:ext
        
        In PPTX export `cx` and `cy` in a:ext can't be greater than
        2147483647
        
        Change-Id: I23ce1c79cda01c7ecd775eecb1d453f3e707bf9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194150
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit cc2de7418d6fce04e52e6bb70a3240e969946c5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194230
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194282
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-24  Karthik Godha  <karthik.godha@collabora.com>  [eea3114b44d5caf664522101e41e7096b6d6f208]

        tdf#169438: Fix PPT->PPTX audio in animations
        
        Don't export audio in animations which are not in use.
        
        Change-Id: I7c5f4e90b36d0c0104a95958c5508dc6b24b2a00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194018
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3e9a1086bd87e8a3edba9417cdfdc09ed1cad63d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194229
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194281
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a555a586027dec1397b48a842b30774aac277b4b]

        mso-test: invalid prstDash enum value
        
        found by converting tdf116793-7.odp to pptx and running officeotron on the output
        
        pptx does not support this border-line-style, and empty is not valid, so just pick something
        close.
        
        Change-Id: I72c299ad79c8d6f5d40ab7d21cda438b5c58134b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194271
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit d281d44f6a308b643fc18ad3efa6103589ada17d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 04ff6fe90911d7ab2d20ac282a0a698eba35f19d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194360
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [852980facf2d63bf6e23339141f7dd42699b7366]

        mso-test: invalid buAutoNum enum value
        
        found by converting tdf135078-1.odp to pptx and running officeotron on the output
        
        pptx does not support some of the combinations here, so choose the closest appropriate one.
        
        Change-Id: I6157c83d1a741f3590eb7db28ec9ac16f6ce80f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194252
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 74e53fa6f70ddb05e30766832868600798d20e65)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194302
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 8adad56b37c5dcf0fc598cc9e6d3c190ca4311b2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194316
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c596057f4e40dd7690e7dde0d46b26e356e961fd]

        change links in odk's index.html to use https
        
        Change-Id: I64abae18fdffa07028c8c9c8c63a3e09d76e41bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194277
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 16811bbe4566f5653d1ea6d674724ab9a224d76f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194315
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [30a282682a12987e4695ff03bbd3bd2e5b732ec6]

        postgresql: upgrade to 15.15
        
        Downloaded from https://ftp.postgresql.org/pub/source/v15.15/postgresql-15.15.tar.bz2
        
        Change-Id: Iff451dcc6f1f4dfaa763869056e610eee4a946d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193978
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 1b89a45baa7214977350ea6558b2c2f3af6c4a1a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194006
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [82724d3bc06b4e1e7fcca07185beef39ec3fc938]

        xmlsec: upgrade to 1.3.9
        
        Downloaded from https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.9.tar.gz
        
        Change-Id: If74dd92da3244357cc504902af481752bfa92e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193727
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 0971d4825c8bc817a0979494e0bf5deb09db1a42)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193734
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfcfc9991c92ad17ff13ffe207967a13dc228204]

        nss: upgrade to 3.118.1
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_118_1_RTM/src/nss-3.118.1-with-nspr-4.37.tar.gz
        
        Change-Id: I9e9dcfed8e8f047862ff07c1f87220a52e26ae77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194179
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 045bd3292b9db696b35e3983bec4a4c038c2b0a4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194186
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-11-21  Saburo Yoshida  <sabr0libo@otkr.jp>  [0d8a10559ad40177725894bd3061bb464f4d1038]

        tdf#169508: fix reversed accessibility options for footnotes/endnotes
        
        The accessibility check options were reversed for footnotes and endnotes.
        
        Change-Id: I8db6546551b26d79726724199886098c3c00873c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194258
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit e4867c607d94ca0be002177c36ea135249f2de08)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194309
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-20  Dennis Francis  <dennis.francis@collabora.com>  [ee633e9bb8b1e12e51eb3e939959193ee9b6ec31]

        cool#13378: fix oom with conditional formatting
        
        oom results when whole rows with conditional formatting is copied and
        pasted. This is because for every column in the row a listening
        'mpCache' is created and the doc-broadcaster has to accomodate them
        before exhausting all memory. See ctor of ScColorFormatCache.
        
        One particular reproducer is:
        1. Create a new Calc spreadsheet and enter a value in a cell, say 42.
        2. Select the whole sheet.
        3. Conditional > Manage > Add, and create a condition where cell value
           is equal to the value in the cell from step 1.
        4. Click on the row header containing 42 and copy that row and paste it
           onto another row.
        
        Conflicts:
        	sc/source/core/data/conditio.cxx
        
        Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
        Change-Id: Ifee510fe39131ed3c03febc3bed983f4962e546e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193589
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 5438e2fd66a0038a00692d2457d6c89b5bd14695)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193825
        Tested-by: Jenkins
        (cherry picked from commit 69aeb20d07a5b40e961e611b064e3f6a6cb261f9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193859
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-20  Noel Grandin  <noelgrandin@gmail.com>  [1958bd26aa71944579702e1b2878a3daa6115569]

        officeotron: ID is not valid attribute in vml shape
        
        triggered in test
          testFontworkColorGradientWord
        with a custom build that turns on officeotron validation.
        
        Change-Id: Ie259e75c5b9987097c77c2c68ab4494c42bc498a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193984
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194099

2025-11-20  Aron Budea  <aron.budea@collabora.com>  [5a22c7cd10014ec6919b19a00b2861e7be4ce8d0]

        tdf#169496 oox: hidden images in PPTX/XLSX shown after roundtrip
        
        Because 'hidden' attribute of 'cNvPr' wasn't exported.
        
        Change-Id: I5f8a79232e3b76f04269caae0631ba5b9710443a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194142
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit a913faf181afb8b8718711eba0ad0cceec961f01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194246
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-20  Noel Grandin  <noelgrandin@gmail.com>  [4c6ad20ea086d0b975d9b12c5ef755ec01d557cb]

        officeotron: Attribute 'val' must appear on element 'w:color'.
        
        triggered in test
            testTableStyleBorderExport
        with a custom build that turns on officeotron validation.
        
        Change-Id: I345a6a08635feeba9fa7fe820cafcea4cfce41f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194222
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit db5f310c43586372d5e03e567f8f9e1d86f70fb8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194245
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-20  Justin Luth  <justin.luth@collabora.com>  [fa1dbf94aa5bf4188137a00804241b8a22438237]

        tdf#168892 export xlsx: only customHeight when custom height
        
        If the default row height is specified as a customHeight,
        then (by default) none of the rows will resize any more
        when a cell is marked as wrap-text.
        
        Not good.
        
        This fixes my 25.2 regression
        commit 507c6fc66cda7c1022008b3d1d4c087540cb2d18
            tdf#124741 export xlsx: no defaultRowHeight without customHeight
        
        Perhaps if the word "unsynced" had some related meaning
        I might not have made this rather large mistake.
        
        make CppunitTest_sc_subsequent_export_test2 \
            CPPUNIT_TEST_NAME=testTdf121260
        
        Change-Id: I0982aab90ca2f49143ec12d9e72a2b5260d8f382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194225
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit eebbde753b9d0181980cf9567a8051005f4fd9e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194226

2025-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b6fd7ccf7dfdc9c344d3c0efab6fa942223f7a4]

        mso-test: cannot have empty childTnLst element
        
        found by converting tdf136301-1.odp to pptx and running officeotron on the output
        
        we do not currently support exporting ANIMATIONPHYSICS node types,
        so don't export a childTnLst element if we see one of those.
        
        Change-Id: I159fd4fe677198529782ad0b4890a1c0af3b1658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194165
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit d764cc96dc155acb64a991770f24c139516fc0e0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194201
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit cbf102d4c1ba73519b49df0d43a87ebdf9267538)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194210
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [496ad75786a460c3bbf248f1c436daeb996192cc]

        mso-test: invalid attribute values in srcRect
        
        found by converting tdf97212-1.odp to pptx and running officeotron on the output
        
        we end up with markup like:
            <a:srcRect l="INF" t="NaN" r="NaN" b="INF"/>
        
        Change-Id: I1780cd7b668351b6ced3cd52d557b4a57f959b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194153
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit bf8db30c20f4c599a53879c0564042b6c4dcb4b6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194200
        Tested-by: Jenkins
        (cherry picked from commit 0fa14f38a6538b57e18ee44873cdcc31a78cea5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194219
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [538d11d09c9063986a9744ad76122edc880afa1b]

        crashtesting --convert-to docx tdf134458-1.doc
        
        regression from
          commit 05f3ecbf1e1dac7f24b1dee80dd7054bf1557afe
          Author: Noel Grandin <noel.grandin@collabora.co.uk>
          Date:   Wed Oct 29 13:40:30 2025 +0200
          mso-test: fix duplicate w:rFonts elements under w:rPr
        
        Change-Id: Idda6b635fc8d034b01f21c9673ee8a8298d0a12c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193958
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 77906e1eb01e8fbbe62704bf272021cc0d545b16)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194007
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-19  Karthik Godha  <karthik.godha@collabora.com>  [5ca8e1c034444d876a9aa9dca82a27f7dce0c0ec]

        tdf#169401: PPT->PPTX exporting too many tabstops
        
        When exporting as PPTX we are exporting too many tabstops. According
        to CT_TextTabStopList, <tabLst> can't have more than 32 tabstops.
        
        Change-Id: Ia96afc566a8e94b7a938cd645d05f4318cc2f970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193860
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 07f6354e66772a4ddbcdff06e3a6c842c687b9dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194086
        Tested-by: Jenkins
        (cherry picked from commit 31f7e5adee4dc599987d169493bd260f84554203)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194108
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-19  Miklos Vajna  <vmiklos@collabora.com>  [11d0c7c510bc749e8d79fe9b13634e1518781edb]

        vcl: fix crash in Window::ImplInvalidate()
        
        Crashreport:
        
        	#0  0x00007377176d3ff5 in vcl::Window::ImplInvalidate (this=0x33912050, pRegion=0x0, nFlags=InvalidateFlags::NONE)
        	    at vcl/source/window/paint.cxx:787
        	#1  0x00007377176d0cb5 in vcl::Window::Invalidate (this=0x33912050, nFlags=InvalidateFlags::NONE)
        	    at vcl/source/window/paint.cxx:1148
        	#2  0x00007377177e0d26 in Edit::ImplInvalidateOrRepaint (this=<optimized out>) at vcl/source/control/edit.cxx:450
        	#3  0x00007377177e47c0 in Edit::ImplAlignAndPaint (this=0x33912050) at vcl/source/control/edit.cxx:1166
        	#4  Edit::ImplInsertText (this=0x33912050, rStr=..., pNewSel=0x7ffe6111c510, bIsUserInput=<optimized out>)
        	    at vcl/source/control/edit.cxx:881
        
        gdb on the coredump says mpWindowImpl in vcl::Window::ImplInvalidate()
        was nullptr.
        
        Change-Id: I06f99b5ede457c4487e97e8259890b29e54804d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194151
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit bddf5365102382fc9dcd47ca28edc229c25334db)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194212
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-18  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [d925471eca8d88c571777833f0aa6b9492b3b080]

        tdf#164334: fix OOXML export of cond format tomorrow condition
        
        Change-Id: I0ece55bb94b6b7086ab6c728d0bf416cc4f221e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194140
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 12def302eb518bec27bf8a6f6234ed88b945e2f5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194168
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-18  Michael Weghorn  <m.weghorn@posteo.de>  [22ca75e90b87c1b9c77e09b5d96a2b58424aff4b]

        tdf#169422 android: Adjust doc pos + zoom on window size change
        
        When the size of the app window for LibreOffice Viewer
        changes (e.g. because a user manually resized the
        window on a desktop device or when rotating a device),
        recalculate the document position and zoom factor
        to make proper use of the newly available space.
        
        On app window resize/rotation, GeckoLayerClient sends
        a LOEvent.SIZE_CHANGED event (see e.g.
        GeckoLayerClient.setViewportSize).
        In order to achieve the desired result, adjust the
        corresponding event handler to call LOKitThread.redraw
        with a `resetZoomAndPosition` param of true instead of
        false.
        
        Change-Id: I2a088975e6083ce72641c8e2ea9d111015fb50bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193967
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 95e6108c20f8035ec837ea852fc2285b9677d5f1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194019
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1430848dc84d447f230c8d11313416f9f495f75b]

        sync android translations with master
        
        Change-Id: Ia10f3e3ee019ab766976b65104eb364cb620ee68

2025-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [82ed25c9eeeef5551388d8171f13f733f8d7ee66]

        mso-test: emit w:sz in correct order in numbering xml
        
        When loading and then saving the document from moz#1197332-4,
        we end up with incorrect ordering of w:sz under w:rPr in numbering.xml
        
        Re-use our existing ordering logic to get the right order here.
        
        Change-Id: I218c52d36235a023d64420c41423daf09c87a89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193090
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit a2cb8cd8f680c0a8b7f04162573603b4449018c5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 25ad702447b849767446f8d59e03d3b623d7ad7f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194098
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-17  Justin Luth  <justin.luth@collabora.com>  [019cfd97f73618258fd18470609a4f874d6c7cbf]

        tdf#169413 docx export: don't write themes twice in w:rFonts
        
        A round-trip was reported as corrupt by both Writer and Word.
        
        This probably started in 6.0 with tdf#38778
        although a bibisect pointed to my 24.2 patch for tdf#108505.
        
        Although I'm not exactly sure what triggers this,
        grabBag was doubling up the bug report's conf12.docx
        w:cstheme in rFonts which looked like
            <w:rFonts w:cstheme="minorHAnsi"
                      w:cs="Calibri"
                      w:cstheme="minorHAnsi"/>
        and duplicate entries are invalid XML - even firefox complains.
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf169413_asciiTheme
        
        Change-Id: Id9561b940c2c536147422e10a8c1d37ea51c2e78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194057
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 9e8211b1c2a814880c0108b2122a6085be192b82)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194061

2025-11-16  Martin Srebotnjak  <miles@filmsi.net>  [27f44c4ef08625732e6e4ca1788059412f9f1dc8]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to e2887b636714ac1c1868d51f5d9850e9a533dfb4
          - Updated Slovenian translation
            
            Change-Id: I16936eefab8c841326a5f32ecaf449212ac8a23e
            
2025-11-13  Karthik Godha  <karthik.godha@collabora.com>  [da83c270853945276a65b9303746a5cb743d04ee]

        tdf#169274: Fix export of SDTs with DataBindings
        
        Run-level SDTs containing DataBinding properties are exported twice
        which results in corrupted XML
        
        Change-Id: I24bcdf76a5cac850257b36f5a042d5b61a74118d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193467
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit d2b7ec90d4d8a85091dc985092ba000b0acad540)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193737
        Tested-by: Jenkins
        (cherry picked from commit ea84f677ea0e8b206edb78f401a4aef9b8bccb41)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193994
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-13  Gabor Kelemen  <gabor.kelemen@collabora.com>  [05c99d105b3560822fa14d04849ab23553142670]

        tdf#169397 Don't crash if SecureURL setting is locked down
        
        Change-Id: I7525d46ded0eac7572e8e49809c85e3721586570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193844
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit a0b1ef4836ba9982e64420a33000de9877c8d600)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193871
        Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>

2025-11-13  Okhuomon Ajayi  <okhuomonajayi54@gmail.com>  [5bb12ef437c2b57ee0208cef0e65cc0ce186de87]

        tdf#129028: Prevent Infobar keys from reaching the document
        
        When the Infobar had focus, Delete, Backspace,
        arrows, and other keys still reached the document,
        causing unwanted edits/navigation. Override
        SfxInfoBarWindow::EventNotify so that only
        Tab/Space/Enter continue up to the parent,
        while every other key is consumed inside the Infobar.
        
        Change-Id: Ieb8d43849d3542ed115d6837d7d222dbf4e5ef31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193152
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 45b2c22d18c67c6da49789cbe5cd157874c7ba71)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193949
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8382087c0ca18938f308f25b1d1eda85e024fe07]

        tdf#68320 - Impress: include/exclude hidden pages in slide count field
        
        Include/exclude hidden pages in slide count field. This improves the count consistency in the slide sorter and in various printing situations, i.e., printing slides or handouts including hidden pages.
        
        Change-Id: I91950736f272695644aabc383d9f1e8fc17a22a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193572
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        (cherry picked from commit 968608eb1c65d96b54292d4926cdd0706ce594f4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193786
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-11  Karthik  <karthik.godha@collabora.com>  [e51d9cec479cbf101413c591439e343088f990ef]

        tdf#169088 Fix PPTX export of OLE animations
        
        Presentations with OLE animations when saved as PPTX can't be opened
        in PowerPoint.
        
        When exporting OLE animations, the target of the animation is set to
        the `pic` inside the OLE instead of OLE.
        
        Change-Id: Ic3e870fff2e896404960f475c67f44df0aef1860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193110
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit be36f4c40bb7b0c1b8ceb974c932a687f5c488be)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193736
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193791

2025-11-11  Neil Roberts  <bpeeluk@yahoo.co.uk>  [3a681cf1498da6ffba430cd06192290b8c5e2251]

        tdf#99619 Don’t add undo action when removing conn but not deleting
        
        Previously when undo is invoked to undo adding a connection between two
        tables OQueryTableView::RemoveConnection gets invoked which would end up
        trying to add another undo action which would re-add the connection when
        invoked. Because this happens during an undo invocation, the undo
        manager is disabled and instead the new undo action gets destroyed as
        soon as the first undo invocation completes. However, because the new
        action is a delete it tries to become the owner of the deleted
        connection. That means that when it’s destroyed it will call dispose on
        the connection. However, the original undo action also tries to become
        the owner of the connection even though it is now disposed so that it
        can put the connection back if redo is invoked on the action. In that
        case the first undo action would try to put back a connection which is
        already disposed which ultimately leads to a crash.
        
        In order to fix this, the RemoveConnection implementation now avoids
        adding the undo action if the bDelete parameter is false. As far as I
        can tell from inspecting the code the only way this can happen is if
        RemoveConnection is invoked from OQueryTableView::DropConnection and
        that only happens when applying the undo/redo actions. I think it
        semantically makes sense not to make an undo action for the removal when
        bDelete is false because the undo action assumes the connection is
        either currently linked to a table or it itself is the owner, which
        means that it will ultimately cause the connection to be deleted. If the
        connection being removed shouldn’t be deleted then it implies there is
        already another owner.
        
        Change-Id: I69976c7fa8f035f9d1613382e7d0698311cf4b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193761
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 2dde26dcaee48d37a508617515addce634d0c96c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193780
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-11  Gabor Kelemen  <gabor.kelemen@collabora.com>  [bf1772c1b9b17e2906e03656ad99ea423f988775]

        tdf#169367 Don't crash on dialog close if ShowTipOfTheDay is locked down
        
        Change-Id: Ib8ba4f24fdd5ba4ca4e10578fbc26d084bf0b0bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193745
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit ae6920c194e5eb0039f7ae3084ca5b7679ea8498)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193781
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [262d39f6cf40dd2f41e13662d861769b6eaa3c70]

        tdf#155855: fix pasting from CF_BITMAP
        
        It has been implemented in commit e9391ae8eb3d0a4edf977f0159ee7e07a0a95859
        (vcl113: #i111834# support pasting HBITMAP). But I fail to see how it
        could ever work, despite the OOo bug was verified.
        
        The problems were:
        
        1. MIME type added for CF_BITMAP was exactly the same as for CF_DIB. Given
        that the wanted flavor is passed to CDOTransferable::getTransferData in
        DataFlavor struct, which uses the MIME type string, which is only turned
        into CFormatEtc (encapsulating FORMATETC) in the function, it was never
        possible to request CF_BITMAP: always CF_DIB got requested.
        
        2. WinBITMAPToOOBMP used a call to GetBitmapDimensionEx to obtain the
        dimensions out of HBITMAP. But that function is only used together with
        SetBitmapDimensionEx; and the value that these two functions control is
        documented to be only usable by applications, not by the system, and it
        has nothing to do with the actual bitmap data stored in HBITMAP, it's a
        kind of custom metadata. Generally, GetBitmapDimensionEx returns (0, 0)
        for any bitmap in the clipboard. And then, it passed nullptr as HDC to
        GetDIBits, which is 100% guaranteed to fail.
        
        My theory is, that the CF_BITMAP-related code added in that patch always
        was a dead code, and it happened to work because the system has a feature
        of Synthesized Clipboard Formats, where CF_DIB will be created by system
        on demand - so the change allowed to find and map CF_BITMAP in clipboard
        to the MIME type shared with CF_DIB; then the MIME type was converted to
        CF_DIB; and its functional code path was used.
        
        However, this automatic generation of CF_DIB obviously doesn't happen in
        case of Windows Clipboard History. Request for CF_DIB fails, so we have
        to make the code for CF_BITMAP (the only data in the clipboard that the
        history provides for image data) work.
        
        This change adds a fallback to CDOTransferable::getClipboardData, that
        tries CF_BITMAP when CF_DIB was requested and has failed. It also fixes
        WinBITMAPToOOBMP.
        
        Change-Id: I7d5eb64cc378510d303686d2bab9c53129607980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193630
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 426a9af71d99c8610b28c3bf73fb8e3fd88e0a64)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193722
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-10  Karthik Godha  <karthik.godha@collabora.com>  [d5ee7dba9c826ef7c55760cf1bb27fdde176f972]

        tdf#169173 Fix import of dropdown SDTs in a table
        
        When we have nested run-level SDTs in the document, dropdown SDTs are
        not imported properly.
        
        Change-Id: I5aaa3f2c7900c6920da1acbb83690251d24233a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193289
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 3db40e042e5f13f7414b8c557a9069155a29dc79)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193749
        Tested-by: Jenkins
        (cherry picked from commit b9c04b6e94bf9c320a91bd1528cfb3932b2b2728)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193770
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Rene Engelhard  <rene@rene-engelhard.de>  [76b1cb71e7e437d1094fcfd795d145c31c1b2c5e]

        default to EUR for Bulgaria
        
        Bulgaria will switch to EUR 2026-01-01.
        
        Change-Id: I0ed47f1681c406af2e92cdd2fdfd0bdace7f8216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193656
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <lo@erack.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Aron Budea  <aron.budea@collabora.com>  [ac258f17f86ef23841980f08e1c3d97e9c46553c]

        tdf#168755 sd smartart: use unified ids for diagrams and shapes
        
        Diagrams (SmartArt) had their separate counters for ids, and
        when saving animation details, the shape to target wasn't
        found, resulting in tags like this, where negative spid
        is invalid:
        <p:spTgt spid="-1"/>
        
        See "19.5.72 spTgt (Shape Target)" in OOXML spec.
        
        Ids can't be completely unified, as it would affect naming
        in ppt/diagrams and on the UI to have large numbers
        (eg. in the 40-60 range), while users would expect them
        to start from 1.
        At least ids to "p:cNvPr" under "p:graphicFrame" should be
        unified.
        
        The large number is because shapes are numbered consecutively
        over all slides, while for the most part they could restart
        on each slide, changing that is not in scope for this fix.
        
        Change-Id: I9790036cc0743313e98f5926d4dc365c8051bd04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193479
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 2de71234b3829672505cf8f6222c27eaf4f0b7af)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193564
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [9297d151ffb1bf59cc5f9153f55cae0edb5d9d99]

        tdf#169320: Don't treat hidden-paragraph-mark as redline
        
        The "hidden paragraph mark" feature is implemented to match the
        feature of MS Word. In Writer, it is implemented using the same
        "merged paragraphs" machinery as redlines; and some code doesn't
        make distinction between the two.
        
        The code, that calculates a number string, uses three internal
        lists in SwTextNode to take redlines into account: mpNodeNum,
        mpNodeNumRLHidden, mpNodeNumOrig, which reflect the hierarchy
        effective for each mode. In "hidden redlines" mode, there are
        no removed elements in the respective list. Therefore, number
        string will be calculated from a different structure, and will
        differ from the string generated from the original structure.
        That is considered in SwTextFormatter::NewNumberPortion, which
        calls SwTextNode::GetNumString with SwListRedlineType::HIDDEN
        and SwListRedlineType::ORIGTEXT flags, compare the results, and
        add the original text in [] after the current text.
        
        Removal of elements hidden by redlines from mpNodeNumRLHidden
        happens in CheckParaRedlineMerge, which finds fidden nodes, and
        calls SwTextNode::RemoveFromListRLHidden for them. This change
        makes sure that it is not called, when a node is not hidden by
        a redline.
        
        Change-Id: I93bc2c47bfefca115c1cbe47e53c7b0f7a119e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193583
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 814a437a0dae0b5c07154844cd08563501807cb7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193725
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [75853a9a9e560a4a4a29e568d8240f6888d8a519]

        tdf#168788 return empty any for empty string for Numeric/Currency Controls
        
        which is what Formatted Controls do
        
        Change-Id: I7991a3e404bc2bef04bca62f52aa1ca8388b1f44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e1f30355de2251bf6ac2e069b1fd231bf9fd84aa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193720
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Justin Luth  <justin.luth@collabora.com>  [4e472c35a83d5c3c89948811bdd8fcac5e335d85]

        tdf#169072 ms export: valid date years are 1601 - 9999
        
        The dates in core.xml must fall in the range of 1601 - 9999.
        
        This applies to all docx files,
        and ECMA_376_1ST_EDITION (2007) versions of the other formats.
        
        No existing unit tests had ANY dates outside of that range.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf169072_illegalDates
        
        Change-Id: Ic2c81d13a1a8ed9d2ce29f7fea761900aa2f2d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193552
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 63bac9055e2e81e238af885c289e99b733d86d7a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193724
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Michael Weghorn  <m.weghorn@posteo.de>  [b60ebf9f6ee6ba86f99f074c7b70698b21797cd0]

        android: Only offer printing if device supports it
        
        Disable/hide the menu entry for printing if the
        device doesn't support printing.
        
        Quoting from the PrintManager doc [1]:
        
        > Requires the PackageManager#FEATURE_PRINTING feature which can be
        > detected using PackageManager.hasSystemFeature(String).
        
        [1] https://developer.android.com/reference/android/print/PrintManager
        
        Change-Id: I65dacb1f11b7ae3e36e5516cd1af26ed20d918e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 7e528bf6880a88975addd211216c8f170d47af27)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193717
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Michael Weghorn  <m.weghorn@posteo.de>  [bb6075fdb95d64e857975a9df442ed2439a7c778]

        android: Merge ToolBarController.{show,hide}Item
        
        Instead of having two methods doing almost the
        same, have a ToolBarController.setItemVisible that
        takes a boolean parameter and passes it to
        MenuItem.setVisible.
        
        Use it in one more place.
        
        Change-Id: Ia186910865c8d3903763fbbad999e06a1cc41946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193573
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 082b22735abd682d8022820929c46e45a02bafdf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193716
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [a3d06a7b83fce2bbd92b4ac401f35c8236ba453d]

        tdf#169278: handle css::bridge::oleautomation::Date in OnTime
        
        Similar to commit e90e4b81b049a9d7c36de8d7f0371e2da7c60c01 (tdf#167378:
        handle css::bridge::oleautomation::Date in CellValueSetter, 2025-07-04).
        
        Change-Id: Icce5ca2248895a1a386b005b9ce232e45aecd633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193625
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 11314c7387dcbb84c7ebcb3bae5c3cd6a83b6524)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193721
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [515aa2de6a9accd898c55ca559378f142d0b6502]

        mso-test: c:noMultiLvlLbl not valid for category axis
        
        This is using the test document from forum-mso-en4-58299.xls.
        
        Importing and exporting to XLSX and then running officeotron generates an error.
        
        The c:noMultiLvlLbl element is only valid for category axes, not date axes.
        
        Change-Id: If24941b9802a8e6e8f4e9243ad8f5cf07a85b1d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193527
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit cdf2a068a6c5f4d4d8051d845a08f9552b913079)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 1fa4d0e6c95bddecbcc63bc6622187a8be2ee48d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193565
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [83a8b73ab4046020cd6da5bf85b20c8c22948eba]

        mso-test: invalid xdr:twoCellAnchor
        
        This is using the test document from fdo73254-1.xls.
        
        Importing and exporting to XLSX and then running officeotron generates an error.
        
        The xdr:twoCellAnchor has mandatory subelements, so we cannot skip writing them,
        even if we have no graphic or media URL.
        
        The code I am removing seems to be from
            commit cbcffbaee204e9dfbdc2125dda73e36d77e9b844
            Author: Jan Holesovsky <kendy@collabora.com>
            Date:   Tue Sep 5 16:53:14 2017 +0200
            tdf#106867: Export videos in PPTX.
        
        Change-Id: Ie095bad8ea9bf92b553448205f00c9cacf42d513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193538
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 4158108427515dce8452dd1026a4f0412ce3ca9a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193570
        Tested-by: Jenkins
        (cherry picked from commit 6b9794ea1c6c24d7c48a1b43a9302c51ea607215)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193602
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-10  Samuel Mehrbrodt  <samuel.mehrbrodt@collabora.com>  [f2c92a806f6211f30644df9a3f141640130c29ca]

        tdf#168228 Don't replace styles unconditionally
        
        When using Autocorrect->Apply, styles were applied unconditionally.
        
        Add a second checkbox to allow disabling "Apply styles" in that case.
        
        Change-Id: I4891f906b5518f518f3ac3e256e21392ade3f824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190955
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        (cherry picked from commit 5bd1efb830400e1394d45f122faf7537e4451f33)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193714
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>

2025-11-07  Miklos Vajna  <vmiklos@collabora.com>  [0e9f3c631e97bc148ee5f26a7f3eab5468f15f72]

        tdf#168916 DOCX import, <w:wAfter>: make dummy paragraph less visible
        
        Load the bugdoc, Writer layout thinks there are floating tables here
        that need splitting, then layout fails to do that and it hangs:
        warn:legacy.osl:17593:17593:sw/source/core/layout/tabfrm.cxx:3365: debug assertion: <SwTabFrame::MakeAll()> - format of table lowers suppressed by fix i44910
        
        Checking what would be the expected output here, it turns out no actual
        splitting is happening in Word, but Writer thinks the table won't fit
        the page. This happens because the table row has a "wAfter" (spacing
        after last cell), and Writer uses an empty paragraph in that cell, using
        the default paragraph style (non-zero paragraph spacing, larger font
        size); while Word simply has no content in such a "fake cell".
        
        Fix the problem similar to what we already do for floating table anchor
        paragraphs in commit 86b0957cf18ea6705c8afa09bf4aae1fbb7db22e
        (tdf#167379 sw floattable: make dummy paragraph from DOCX import less
        visible, 2025-07-10), where we have the same problem that we want the
        empty paragraph to take ~no layout space.
        
        Once the table row has the correct height, Writer doesn't attempt to
        split the floating table, so it can't go wrong.
        
        Change-Id: I7fb2b859e72e5ec1b4b54d46c191ebfc5e8fcaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193257
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3a0b56e4b2b94fd9001ea7a95488142cd9d6186d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193271
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [732a501206bb2356e28a5fa0c27cebc43ef3b366]

        mso-test: order of c:numFmt element in chart.xml
        
        This is using the test document from tdf121279-1.odt.
        When importing and exporting to XLSX, the order of elements is wrong
        according to officeotron.
        Move some code around in ChartExport to get that right.
        
        Change-Id: Id09328520c05ebb35074b4bb451d08572a9c831e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193439
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 0a8060e6d5cf7a7f1ce4b54c6019bb56995e57f6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193481
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193536

2025-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0eacd988e7a1c28db0aa41f8384290f4ada3b15]

        mso-test: fix export of rotX
        
        This is using the test document from ooo72994-7.xls.
        
        Fix the export of the rotX value for 3D charts.
        We cannot easily map the value here, all we can do is clamp it.
        
        Change-Id: I1beba485c66babfbe03830c79b8b8c72a7560bfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193456
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 8758fa5ab4b8c99ab15334653c58651c6edd2e35)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193511
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 50ab8446cb17acc36922e794169574824f7b3387)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193534
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [97d4a305ece4a6e7d4933e0e456e071dfe04fba3]

        mso-test: escape text of vml element
        
        This is using the test document from ooo91342-1.xls.
        When importing and exporting to XLSX, we end up with an unescaped "&" character.
        
        Change-Id: Ieb578c42adf1eed2b29ef96af973c15d22b40e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193454
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 8df99b53bdf1d21076d008a2e4915b80cd6e2a61)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193510
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 39869d2a038aae60a90c432c6243d342f7d02863)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193533
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [361858d734c92ce26f58ad78a16ea5ca4a82c28e]

        mso-test: escape text of a:t element
        
        This is using the test document from tdf 111408-1.odt.
        When importing and exporting to XLSX, we end up with an unescaped "&" character.
        
        Change-Id: I25e8952049cc0f9665030b46e7d29d2397d9f9bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193448
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 47e2188d4bab1509d059c4df53df7f49324bea2d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193509
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 196b3fe18948b1c6b6afe78d171a62513bc21980)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193532
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-06  Miklos Vajna  <vmiklos@collabora.com>  [82bc33e819c3f8ac8e9ad2349f8a7a97374d5b2e]

        sw writerfilter: fix crash in DomainMapper_Impl::PushProperties()
        
        Crashreport signature:
        
        > program/libsw_writerfilterlo.so
        >       writerfilter::dmapper::ParagraphProperties::SetListId(int)
        >               sw/source/writerfilter/dmapper/PropertyMap.hxx:492
        > program/libsw_writerfilterlo.so
        >       std::__uniq_ptr_impl<writerfilter::dmapper::DomainMapper_Impl, o3tl::default_delete<writerfilter::dmapper::DomainMapper_Impl> >::_M_ptr() const
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191
        > program/libsw_writerfilterlo.so
        >       writerfilter::ooxml::OOXMLFastContextHandler::startParagraphGroup()
        >               sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:432
        > program/libsw_writerfilterlo.so
        >       writerfilter::ooxml::OOXMLFactory_wml::startAction(writerfilter::ooxml::OOXMLFastContextHandler*)
        >               workdir/CustomTarget/sw/source/writerfilter/ooxml/OOXMLFactory_wml.cxx:7950
        
        Where gdb (on the coredump) says pParaContext was nullptr in
        writerfilter::dmapper::DomainMapper_Impl::PushProperties().
        
        Change-Id: I5729f95526b9080bcab1f65f5c3aea571d55c4d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193463
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit bd4185449b074ad553123986d2670c233088d235)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193469
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [84405fa8c36e39d225e4a9067398c02bdb8243ca]

        mso-test: duplicate w:sz
        
        This is using the test document from tdf120515-1.odt.
        When importing and exporting to DOCX, we generate duplicate w:sz because
        we call WriteCollectedRunProperties() twice from EndRunProperties(),
        but we were not clearing m_oFontSize like we clear all the other
        accumulated data.
        
        Change-Id: I1397606cd1f374e395f29a479eff860c3ebe75b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193397
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit be8bad5cd6628d7353679045742476fa9dd66121)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193472
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 8278f03f9eb3bf121e138e7cd39a3c7076cdba53)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193495
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a22cd7868a887d27503907c1f1edd81aae553cb]

        harfbuzz: upgrade to 12.2.0
        
        * 0001-Fix-applying-synthetic-slight-to-glyph-origins-5629.patch.1
        has been fixed upstream
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.2.0/harfbuzz-12.2.0.tar.xz
        
        Change-Id: I61c8edc0286389fe476b9ba84e8eac8f19f2016a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193444
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f2557cfaae6e367973101c19f76848ec39a0e0c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193453
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [dcb108323e866fa9cafda685f0de9eb4adb21665]

        tdf#169158: Call FormatObjsAtFrame again, when at-page fly needs that
        
        Formatting a cell with non-default vertical alignment is done in two
        steps. In the end of the first step, SwContentNotify::ImplDestroy
        detects the difference of size/position of the table content, and the
        non-default vertical alignment, and invalidates the cell and its page.
        Then the next formatting would correct the size/position mismatch; it
        obviously relies on the second pass of formatting.
        
        In SwLayAction::InternalAction, the formatting loop did a single call
        to SwObjectFormatter::FormatObjsAtFrame, which formatted at-page fly
        objects, and then an inner loop which formatted the rest of the page
        content. In that inner loop, it performed validation of all flags,
        then called FormatContent, and checked the validity. That meant, that
        any invalidation that could happen in at-page objects formatting time
        would be lost. Then, there was nothing to indicate that the at-page
        objects could need a second formatting attempt; the outer loop could
        only run once, even when the at-page formatting needed another run.
        
        This change introduces a dedicated flag for at-page fly invalid state.
        It is checked in SwLayAction::InternalAction in a new loop, to make
        sure that SwObjectFormatter::FormatObjsAtFrame is repeated as needed.
        
        Change-Id: Id6f4fef10cc031af95c38f0074178405027c513d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193298
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 15c89cf1b72a7556af238d9b0a7d34017c6ec3ee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193325
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bed0442907e5d704e9eab81135ea8eade16448fd]

        update credits
        
        Change-Id: Ic382e9bc69385c1eb704341eefb08183cec8d9df
        (cherry picked from commit 2be216b83d7e7755a47575b3233fa287603b6fa8)

2025-11-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [14afb1af93adea81dbecc5c0c258ab98048bfe29]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to d22ab41bb76904ff6bcbe25ab70ba23bced8f58b
          - update translations for 25.8.3 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: If22a8d2459b5c47ce71348461ec2a1c9da3727f0
            
2025-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee7ae33267ebbac41c2e110b166928dc91f35475]

        poppler: upgrade to 25.11
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.11.0.tar.xz
        
        Change-Id: Id84db75ff8534fc520d8e3fdf6b5ef798331ab5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193434
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit d0d81540a7f1e4b2c0b7a305f9f64c518edec8c3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193440
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-05  Michael Stahl  <michael.stahl@collabora.com>  [4f2b3ccbe0b7ac494cd56f38ba6c8375f3e89898]

        sw: layout: when positioning SwSectionFrame, ignore dead prev sections
        
        The place where it went wrong was in a second layout iteration when
        after positioning some objects everything was moved down, in
        SwSectionFrame::SimpleFormat(), where an empty section frame 72 of the
        1st outer section was the prev of the 2nd outer section frame 73, and
        was itself not positioned properly.
        
        Apparently this empty section frame is inserted by InsertCnt_() but of
        course empty section frames can happen in other ways too.
        
        (reportedly regression from commit a85bd1bc9305af059d880ee422a656a3d9ce1b0b)
        
        Change-Id: I7513a2171fe4f3763f7b73b2e4368032e015c495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191410
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 528d5c8e0b9401ba945967e66775aea17aec7d00)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191718
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Michael Meeks  <michael.meeks@collabora.com>  [80aa6a38127882e15015b0ce5e9066f007671340]

        pptx export: re-order attributes to better match MSO.
        
        This helps to minimize the diff.
        
        Change-Id: I8a16932725094ca047350503f65c673fa85f8398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191943
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 1950a7fd912dd08f2555472871b944d551a5ad9a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193421
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Michael Meeks  <michael.meeks@collabora.com>  [d4d753f93a031791bfb9cd9ea5dfaba4bfdff7f4]

        oox: blurRad defaults to 0 in its users: outerShdw, innerShdw, and reflection
        
        Change-Id: I681a238398b82ac85eeb2c32f09d501488394706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192013
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 995e669b87a79aebdade412b5a01f237f8758f5a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193420
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Michael Meeks  <michael.meeks@collabora.com>  [d2cc2fea378d01eedf278278cdeb19754d3be4fa]

        oox: don't write empty cNvPr descriptions to reduce diff noise.
        
        Change-Id: I360dc8eb9dbfb618fff03c96d9447db21b5ddafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191997
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit daba89f6b6d53c10fbd380b3608fc80f25de1bc0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193419
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [d42d448c3a5702b989f6c6dbdae6b90c6f7524f0]

        mso-test: fix ordering of w:rFonts element when writing footer
        
        When loading and then saving the document from ooo94120-1.doc,
        the w:rFonts element is in the wrong order under the w:rPr element.
        
        Use our existing mechanism to enforce correct ordering.
        
        Change-Id: If6aa30ee3114e292456710449dbd0c675dd4c950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193323
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 5b105939807b8d5016aec65a173283134301cbc2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193350
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit dcf6f8729f2764d038e0dc929b37b4da0668965f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193366
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [fbef49982f2f4943685495cfdb150c46ce5b7527]

        tdf#169006 sc a11y: Keep keyboard focus in conditional formatting dlg
        
        In ScCondFormatList::AfterTypeListHdl, the existing
        ScCondFrmtEntry can be deleted, and with it, its combobox
        indicating the type, and a new ScCondFrmtEntry created
        to replace it.
        
        In the case that combobox was focused (which is usually
        the case, because ScCondFormatList::AfterTypeListHdl
        is the handler that gets called when the active entry
        changes), then make sure that its combobox for the
        type takes over/receives keyboard focus, so the user
        can continue in the "same" (from their perspective)
        place.
        
        While the case of gtk3 with native GTK widgets and
        qt6 with SAL_VCL_QT_USE_WELDED_WIDGETS=1 to use native
        Qt widgets would at least allow to move the keyboard
        focus to somewhere in the dialog using the Tab key
        previously, the vcl implementation would not allow
        this, breaking keyboard accessibility of the dialog
        altogether.
        
        Change-Id: Iaa3e087cda078678d1f160ce8a49938b27e6528c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193431
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 752adf6cc9d869bbcf34fcf09c80da502398cb81)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193432
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d74ce83da797b695d6005651f27619eec2077f28]

        tdf#164070 always install en-US UI localization on windows
        
        if en-US is not available, and the user didn't manually configure the UI
        language, adding another language (via means of mar updater for example)
        can cause that new language being used instead of the language the user
        had installed initially since there's no explicit default/fallback.
        
        Since any language that will be added in future is likely to not use a
        latin script/will be quite unfamliliar to the user, having en-US to rely
        on as a fallback is a much better experience.
        
        The problem occurs on systems where the selected UI language is not
        matching the windows language, so for new installations the user has to
        go to options and set the language manually. That in turn then will be
        an additional safeguard for further updates, since now there's a
        language explicitly configured and thus no reason for LO to "guess" what
        to use as default.
        
        Change-Id: I67dd9a9ddd9de3ce79eb9144eab06b6f10134c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193422
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit 51ccb1ead1c94e695489b1c494e4bf611d8b4b5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193426
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [de6709861507202144b1d91cda928d07d768626d]

        tdf#108791: also handle deletion of comments in Navigator
        
        We should also think, what to do with other cases like Backspace at
        the comment anchor, which still produces the unwanted result.
        
        Change-Id: I348ab1455aef54d7233870c6bab8ec89a93902d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193303
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e07d88403140455b8221045689632ca78922e6cf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193315
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-04  Gabor Kelemen  <gabor.kelemen@collabora.com>  [3f0bd67c431f1d1aa6583c6ff6f4b15602aeace4]

        tdf#169097 Add "Text along Path" command
        
        to connector objects context menu in Impress/Draw
        
        Change-Id: Iefdb46c3b6589d0b6ab4611717049d699082d4c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193123
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        (cherry picked from commit fdcc566a017e1b107723b8b40a18088e19a31f04)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193369
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-04  Karthik  <karthik.godha@collabora.com>  [680d341a1bab9eb28dd3980d47577a2f82afd7e2]

        impress: fix PPT->PPTX margin interoperability issue
        
        Saving a PPT file as PPTX could corrupt the output if the left margin
        was set too high. The margin value must not exceed 51206400 EMUs.
        ([ISO/IEC 29500-1] 20.1.10.72).
        
        The patch sets an upper limit on margin values during both PPT import
        and PPTX export.
        
        Change-Id: I59791059ed4805ec52133cd7926a1e752a18b701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192121
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 70f344e6376f572fa85a4c3f74228588ed2a6b63)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193073
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193418

2025-11-04  Michael Meeks  <michael.meeks@collabora.com>  [a2280b0a6364af7bdfd8cf2e15bf382b1fb0c838]

        oox: crop ST_TextIndentLevelType to maximum value of 8.
        
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Change-Id: I5994b4414a4ef79564a44a8a661498765fd4b125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191980
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193417
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d511a09d9bb6276cefc4cef5fd6795b84b382974]

        mso-test: c:dLbl element wrong order
        
        This is using the test document from ttdf92129-5.odt.
        When importing and exporting to DOCX, we were writing the dLbl before the numFormat
        element, instead of after it.
        
        Change-Id: I541688f2df4f879294ad56182db8eb1df6edf182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193344
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 5f3fca8a18aa697904a0310db22db6dab27fba67)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 320a5640dec289cc936b9de51a09760d33432acd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193389
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [90161b9cb2efedfaa65a59fb2e53626cdb9e65c5]

        mso-test: clamp a:cx and a:cy to >= 0
        
        When loading and then saving the document from ooo83929-3.doc,
        we end up with negative values here, which is not valid.
        
        Use our existing mechanism to enforce correct ordering.
        
        Change-Id: Id584e0bd1d2a2bfcca84b19517f426b0b7c5f510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193324
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ff30cc6a366f1cbaa4f038542d78842cbc90b039)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193362
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 7952978822858fedb580a4564f190223d767d6af)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193386
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [570c63d555ecab9f9edc00ec343e25d8580283e1]

        mso-test: duplicate sz element in styles.xml
        
        This is using the test document from tdf94682-1.odt.
        We want to write w:sz in multiple places, which creates duplicate elements,
        which officeotron rules invalid.
        Use our existing strategy of collecting data and then writing it at the
        end.
        This is not ideal, because who is say which one of the font-sizes is
        the most correct? But our existing unit tests seem to believe that the
        "last" writer of the value is correct, so this approach works.
        
        Change-Id: I5f720f0d2c5d3efb7c2aec5ec955cc761fbb980d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193341
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 1cc468155c526639c3f5362932effc12c5fad969)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193374
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 1d3ea5e7a4ea42390db29ed50bb426a663c86cc5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193387
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [7245a09d32410c3fb349724f1d78fa4a8171d05f]

        mso-test: fix duplicate w:rFonts elements under w:rPr
        
        When loading and then saving the document from forum-mso-de-56075.docx,
        we ended up with a duplicate rFonts element.
        
        The xml looked something like:
        
        <w:numbering ...
          <w:lvl w:ilvl="0">
              ...
              <w:rPr>
                  <w:rFonts w:ascii="Calibri" w:hAnsi="Calibri" w:cs="Calibri" w:hint="default"/>
                  <w:rFonts w:eastAsiaTheme="minorEastAsia"/>
              </w:rPr>
          </w:lvl>
        
        Change-Id: I958023fb0c9e40af5aec31b07628bb72b25e730e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193146
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit f6140a360dced4fc45816bd0605089110dd6835c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193336

2025-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [84681c65b2b101c7f86da4fe331f3208fc6cb053]

        tdf#167963: patch upstream fix
        
        See https://github.com/harfbuzz/harfbuzz/issues/5628
        
        Change-Id: I05bffb1d5e291bd2a5f92bb87aa49bd46d9dc6b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193182
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 68822e1bfe0ed83766f4166f8162aacc7e392191)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193189

2025-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [917e73ac2372b341dfde32eea64875df46e6fded]

        tdf#168672 Closing webdav documents is extremly slow
        
        Change-Id: I9b6c1cbd7ca4c1a8bcce589cbfda5604e66520f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193404
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ada7b49a5ab88711b5e2296ebc753fe042e53111]

        Related: tdf#168672 ; cid#1642989 Wait without held lock
        
        restore the lock at the end of SerfLockStore::stopTicker
        
        SerfLockStore::removeLockImpl calls this, and that is called
        by SerfLockStore::refreshLocks in a loop, so if it was unlocked
        at the end of the first loop, then its still unlocked on a 2nd
        loop.
        
        Probably doesn't matter as there's only a 2nd unlock attempt
        if m_aLockInfoMap.empty() which presumably can only happen once.
        
        Change-Id: Iede91b1b4ef9368bcf4e62cb85bf5a0c745e0ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189058
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 3f3aed00458d64bf32f5faa25c88f959430dea3a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193403
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Andras Timar  <andras.timar@collabora.com>  [bcdd61ad20635e8806993aca311a91c3cfdad6c3]

        vcl: check mpWindowImpl for nullptr
        
        Change-Id: Ib70e14cd791415f47772b1053200e9bab6925e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193372
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 4c63a86c88d54db5e69dc8502b6eeffa7f1e4417)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193393
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 5946f67e1db31926af92ea3d0d8eeb58978ea782)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193399
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b6549787410e11c536f41fe168a0f254458b7ad]

        mso-test: fix line style names
        
        When converting to docx the document from tdf100844-1.doc,
        the line style names are slightly wrong, according to officeotron.
        
        Change-Id: I19c5dac42e34b54ab9a83e6ffe29c3844f8ef553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193209
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 37d0b6934a461acb1336ceff45cf2547dca9e95d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193253
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193337

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [935d4d58ae50407cd9d7d3119d7ea176686d9d6b]

        mso-test: fix order of w:pStyle and w:rPr elements
        
        When loading and then saving the document from forum-mso-en-10184.docx,
        the ordering of elements under w:pPr was wrong in two different ways.
        
        Change-Id: Ia99b759a871d5d324ec4c6689de3eb5dcf9c4f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193142
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit a43482e27644e45bd13d6eed3f550e3843cc1e58)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193251
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193335

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [08258886e7e5c8e0737fe2bf367aba7f7d5a35e1]

        mso-test: emit w:sz in correct order in document.xml
        
        When loading and then saving the document from forum-mso-en4-364124.docx,
        we end up with incorrect ordering of w:sz under w:rPr in document.xml
        
        Re-use our existing ordering logic to get the right order here.
        
        Change-Id: Ide57bd44b59033cd8cd6e885e8b9578a87314856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193097
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 43e293e744bfe153d74e3f20cd4235636f51ef36)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193250
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193334

2025-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [8046bdb80f531db8a68cef9ad61889c9eb3f9b67]

        mso-test: fix order of webHidden element
        
        When loading and then saving the document from forum-mso-en-11578.docx,
        the w:webHidden element under the w:rPr element is in the wrong order.
        
        Change-Id: I56bf4e989d4d0345bb79a7f95860371085bd49bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193131
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 4f8e10e92d593019054f393467a6448aa478bfc8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193333

2025-11-04  Eike Rathke  <erack@erack.de>  [d7a749e3a6c7846c61a7bc17b1b852e0787fd18b]

        tdf#168665: Add Extremaduran (Spain) {ext-ES} [0x06B6] locale data
        
        Co-authored-by: Xisco Fauli <xiscofauli@libreoffice.org>
        
        Language list entry will follow in a separate commit to not taint
        the translations when backporting.
        
        Change-Id: Iedf3a6d27083592fecdfb3523ccdb522da784d10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192801
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <lo@erack.de>
        (cherry picked from commit 38a6aa74b6a917bbc4e511cae8bffbcba28c9fac)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193373
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-03  Balazs Varga  <balazs.varga@collabora.com>  [2d1f34d51ef0fd0f35323eb6507bdab684370f75]

        tdf#169160 - Fix after presentation minimizer works
        
        the file size is barely changed (from 1.6 Mb to ~1.2),
        comparing to older version with where we used awt::XBitmap
        and the file size changed from 1.6 Mb to ~0.3.
        
        Issue came up after commit:
        7243f7c706ceb49d6b3e4dfb8ff72ab43c65dd86
        
        co-author: Gabor Kelemen <gabor.kelemen@collabora.com>
        
        Change-Id: Id728abe61556c40d7dfb0f0f9e4fb7278639a691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 6998ed74d5e897312211bc8e3da243e00d0ede22)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193364
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-03  Neil Roberts  <bpeeluk@yahoo.co.uk>  [6f37e13706f5b0239862255929299d463fb1050b]

        tdf#166488 Fix local variable used to store char from SvxCharacterMap
        
        The SvxCharacterMap dialog is used to select a character and returns a
        32-bit Unicode codepoint via GetChar. When invoked from
        SvxBulletPickTabPage this was then being stored in a sal_Unicode
        variable so it would get truncated to 16-bit. This patch just fixes it
        to store the result in a sal_UCS4.
        
        Change-Id: I49984817388dc8d77284f18c085804bed049d740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 4888f6f3f59785d0e661b58060bd8458f866bf10)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193365
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-03  Aron Budea  <aron.budea@collabora.com>  [ac41c8f79bd00e14304d46425a3c2ee7df7bd7c7]

        OOXML: don't always export override entries in [Content_Types].xml
        
        No need to export if it's no different from the default.
        
        Also reorder defaults alphabetically, in same order as
        exported by original document producers (though not all
        of them are always added in MSO, which is not addressed
        in this change).
        
        Change-Id: I8526da5adc068f02e6da072961c82f4e75e3b984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193224
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit c15ba11a6ce334b2c0279704c379083858260686)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193352
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e32583e755e877fd1eb68049d6f26d54fd939fe]

        Resolves: tdf#144343 This isn't used to toggle navigator on/off
        
        but instead contains a SfxBoolItem which specifies if it should
        be shown or hidden and ChildWindowExecute takes care of deciding
        if that requires Toggling on or off.
        
        Change-Id: I2ad422041bb6f40f5b726111cf5ce35a32c39128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193339
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-03  Pranam Lashkari  <lpranam@collabora.com>  [f60a4baee3852184da95c2947c910b485225d5fb]

        tdf#168261: resume ScInputHandler even if error not displayed
        
        problem:
        regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
        when data validity dialog was not displayed, error function returned early
        this caused issue with cell invalid data cleaning and it was not possible
        to enter new data in any new cell
        
        to reproduce:
        select data validity as list and also disable error message showing
        enter the invalid data in the validity cell
        subsequently its not possible to type in any cells
        
        Change-Id: Ia2157ae57ca90dd9365daae7881640a00c3f1216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193141
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 65ca233db9a39fd251ffac46608bb2714949e894)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193356
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-03  Pranam Lashkari  <lpranam@collabora.com>  [d803223e55e5a762a6916e1c03459d931817ba70]

        tdf#167126: resume ScInputHandler even if error not displayed
        
        problem:
        regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
        when data validity dialog was not displayed, error function returned early
        this caused issue with cell invalid data cleaning and it was not possible
        to enter new data in any new cell
        
        Change-Id: I612ea8b9c651afba1095fc14726e5398484207f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193186
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 0b9b82f41a1ff4cbbed6a7148b77cbc3b00c9716)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193355
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc13249ddd6f92e367de16adca5f65adf36cedba]

        mso-test: fix w:date value format under w:comment
        
        When loading and then saving the document from forum-mso-de-128915.docx,
        we end up with a zero time value that officeotron does not like.
        
        Change-Id: Ib663d7982e583f9938fc13725161b75a16de4930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193150
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2842db97cf8058b54e15edcaa606585426b9d035)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193277

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1a5e69c51c95ae7f87d5a818555ed94116fefb9]

        mso-test: do not emit empty cryptAlgorithmSid attribute
        
        which is not valid.
        
        When loading and then saving the forum-mso-en4-551337.docx document.
        
        Change-Id: Id67844b25b264e937b3bcdbf7a9dcbea76c2cd40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193092
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit d2c71e9b6054fae66a553da869e752f8c55f76d5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193236
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193275

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [1871d8026cfd559642c7342aab54036cbf2830b6]

        mso-test: emit w:numFmt in correct order in numbering xml
        
        officeotron says:
        
          INFO - Validating part "/word/numbering.xml" using schema "29500T/wml.xsd" ...
          ERROR      - (numbering.xml:2 col:536) cvc-complex-type.2.4.a:
                      Invalid content was found starting with element 'w:numFmt'. One of '{
        
        when loading and then saving the forum-mso-en4-401306.docx document.
        
        Change-Id: I2c07b360169180fb8dcbf6a932df8e9e3de4158e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193093
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit ffd2c88ddedd28896cf546f3bb06a2a59253f25e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193238
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193276

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [680a1b97d842c441f6442d7ae60e73814a0e91b1]

        mso-test: fix ordering of w:lang element in table style
        
        When loading and then saving the document from forum-mso-de-131567.docx,
        the w:lang element is in the wrong order under the w:rPr element.
        
        Change-Id: I53d988097bb822f9dd9363114ebb33321584842c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193149
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 7b059f86dd5a2b01c99b354105edc12679e92cc6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193254
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193338

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d3bf55646b8bbf1843331ad7e845e92e802bf867]

        mso-test: remove path attribute from v:rect shape
        
        when loading and then saving the document from tdf#135569, we add a path attribute,
        which is not a valie attribute for a rect element,
        which causes ms-office to think the document is corrupt
        
        Change-Id: I7705fa9d3ed86bc3aa916db4603d40cef35086af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193038
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 7f0efca2ce1f02b7d9b8af57c6d70078a14f9b5f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193247
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193332
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [73f64b51d2283b6a9923781ef72fdceeb7e3d45b]

        mso-test: fix formatting of w:char attribute value
        
        When loading and then saving the document from forum-mso-en-14041.docx,
        we end up with a string like "1f" instead of "001f" for the hex value
        of the w:char attribute, which is incorrect.
        
        INFO - Validating part "/word/document.xml" using schema "29500T/wml.xsd" ...
        ERROR      - (word/document.xml:2 col:9 575) cvc-length-valid:
                       Value '43' with length = '1' is not facet-valid with respect to length '2' for type 'ST_ShortHexNumber'.
        ERROR      - (word/document.xml:2 col:9 575) cvc-attribute.3:
                    The value '43' of attribute 'w:char' on element 'w:sym' is not valid with respect to its type, 'ST_ShortHexNumber'.
        
        Change-Id: Iea72e0064f09f4aa9ceb28f61596743c5b6434f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193122
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2c9293526e822a8ef39ca77eb6a1f6ede6de9a92)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193246
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193331
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [c96933d95f1eee1018f893dfc08d9b5d52891201]

        tdf#165733: fix leap year detection BCE
        
        lcl_isLeapYear used a simple "is divisible" method to check if a given
        year is leap. But that didn't take BCE into account: we use historical
        numbering system, where before year 0001 was year -0001; and that year
        was leap.
        
        Use comphelper::date::getDaysInMonth for that, which is correct, and
        also deduplicates the code. Make sure that years beyond sal_Int16 are
        considered an error: they are not representable in css::util::Date,
        and comphelper::date::getDaysInMonth takes years as sal_Int16.
        
        Change-Id: I34f1ad4d5d03e05a7cf787f9997b04b1d705b583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193302
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 97bc8766e297c8d5c22b2f6d4bd7b6d7258782fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193314
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-11-03  Jaume Pujantell  <jaume.pujantell@collabora.com>  [fed5426a3a0058f630a7c418bb1ba0cb95caadd8]

        sw: reduce duplication of w:num items
        
        When saving to .docx format we create new w:num entries for lists even
        if equivalent entries already exist. This creates a lot of bloat in big
        documents that have heavy use of numbered lists. A document that can be
        saved with ~150 num entries can end up with ~2000. This causes
        compatibility issues with other software that doesn't expect such high
        number of numbering styles.
        
        Change-Id: Ie8667c0a6d98a77c7c429a9a2925d31ee19fd31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193164
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit aa0c3d7eab9a611f915b4262b37d34860f527bc7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193248
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193278

2025-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed8d978b6c1b341d5a8201a10eed378f10458499]

        mso-test: emit w:settings elements in correct places
        
        When loading and then saving the document from ooo#120405 ,
        we end up with incorrect ordering of some of the settings sub-elements.
        
        Re-structure the code here to match the schema ordering.
        Pull code related to each sub-element closer together,
        to make it easier to see when we need to emit an element.
        
        Change-Id: I4ef7c2f275911f1226b3c64fe12605de84cb418d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193083
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193242

2025-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d7371ba169aa1a59c39cadde7b4123cd6a2ca91]

        mso-test: emit framePr element in correct place
        
        when loading and then saving the document from tdf#112456,
        we end up with incorrect ordering of the framePr element,
        which causes ms-office to think the document is corrupt
        
        Change-Id: Ie8de5b94c3d4e71353a5c0783b05b0df3dfe6058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193049
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 58b7a5e4ac79d6bf0d38fe20b7571484aa24fa1e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193241

2025-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b2be7d4942a42ff21f68f2949625398e163b787]

        mso-test: emit w:hyphenationZone in correct place
        
        When loading and then saving the document from tdf#100072 ,
        we end up with incorrect ordering of the w:hyphenationZone element,
        which causes ms-office to think the document is corrupt
        
        Change-Id: Ic34407cbbfc61ed160d079c2cd20adefe3acf901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193081
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 632cdb7b7bbfd17e11e75a408f8adf51a979c8b2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193208
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193240
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [c19415c20ba0edce2d5f335fba0b788dc5280804]

        tdf#169090: Only change bookmark type to NUMITEM for paragraph PaMs
        
        In a real-world DOCX, using redlines, there was a bookmark with a name
        starting with "__RefNumPara__", positioned not in the para properties,
        but in the middle of a para text. Opening that DOCX in my debug build
        failed an assertion in ctor of CrossRefBookmark, which requires that
        IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark returns true.
        
        It makes sense that a NUMITEM bookmark expects a paragraph-wide PaM, so
        just reorder the checks in SwXBookmark::attachToRangeEx. Now it works
        for NUMITEM the same way as for HEADING.
        
        Change-Id: Ia33b54f138d7f61ee72dc3b5c270efdd0fec8068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193024
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0b3a4ee85ae264d96bb6dc221dbcf4c394108bff)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193039
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95a398a2aa009704f484662a7625b5cec7fff3e1]

        disable werror in external mythes
        
        avoid useless optimized gcc build warning of:
        error: 'void* __builtin_memcpy(void*, const void*, long unsigned int)' specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
        
        Change-Id: Iba277bedfa8061af6040891ae8d77c39454f983a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193157
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 7a44dac223f057b67e59415cd484d7f222bca06c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193217
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-30  Regina Henschel  <rb.henschel@t-online.de>  [4ff6d294eac41288bce19b377c0a8857b8cb4992]

        tdf#169019 write char not number, read col from 0
        
        Write: Separator as string not as number.
        Read: Column index starts at 0, although in dialog is starts at 1
        I have not checked the other transformations but only ColumnSplit.
        
        Change-Id: I37812a4b575a425981ed09257263c829bd2eefc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192929
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        (cherry picked from commit 48cf7f1123637be847140ef9acc49e8f5f056677)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193020
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0be055db710f3f917ce566a6909d58767c258ff8]

        tdf#169147: handle errors creating icu::RegexMatcher
        
        Regression after commit 38f731ff67142a423aa6f46dc3e92d094f86ffb1
        (tdf#160478: fix Basic LIKE operator, 2024-04-02).
        
        Change-Id: I4fae01e56cb91d54adba54c3787f576f60f8b1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193202
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 3ab2560526ba7b745889cf509241ff17d0638cc2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193220
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-30  Karthik  <karthik.godha@collabora.com>  [fabe470b421827d8087a614d1f790107f39bb754]

        tdf#168843: Sanitize font size read from PPT
        
        Add validation checks to SvxFontHeightItem, which is used when reading
        font size value from a PPT. In LO minimum accepted value for font size
        is 2pt.
        
        Change-Id: Ia027800bc52b797f6f0bf5b28e74ba38ba558d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192139
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit f4c3c126d9f43f0e8b066d1eda8669cbec6495fd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193076
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193194

2025-10-30  Karthik  <karthik.godha@collabora.com>  [3a3760e683c5cfefed383299b74e0d68f080c653]

        impress interop: PPT->PPTX invalid time value in <p:tmAbs>
        
        Saving a PPT file as PPTX could sometimes corrupt the output because of
        decimal ST_TLTime value.
        
        ST_TLTime should be unsigned int ([ISO/IEC 29500-1] 19.7.38).
        
        Change-Id: I2bfbec3a4970918e8c58b41c531799796e91668c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192138
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ec4a63decfe6c6613e3d3b7097359c26fa5b49c7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193072
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193193

2025-10-30  Karthik Godha  <karthik.godha@collabora.com>  [b113ba6359384b31025e09288df8a401510fb4a5]

        tdf#168786: Fix PPT->PPTX internal link leading nowhere
        
        When saving PPT files with invalid link targets to PPTX, it results in
        corrupted XML output.
        
        Remove links with empty targets during PPTX export.
        
        Change-Id: I4c0a413c5a9c479094b3f48eead6d3676e6cf804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192762
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 0318671fb187941726316442651911a96a80f2f4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193075
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193192

2025-10-30  Karthik  <karthik.godha@collabora.com>  [c9172d1aec35b9283eb24dc09675f084e5bd9adc]

        tdf#168736: Fix PPT->PPTX internal-link interoperability issue
        
        When PPT files with internal slide links are saved as PPTX, it results
        in corrupted XML output.
        
        Properly importing internal links when loading a PPT file fixes this
        issue. The fix follows PPTX standards for saving internal links.
        
        Change-Id: Ic554dae72e7089a005ed24dc697c3db17187cc83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192169
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 6faf26e5de4aa21980f2ee49253a5e0854d2e62d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193077
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193191

2025-10-30  Neil Roberts  <bpeeluk@yahoo.co.uk>  [77f893a63fdf9b444c28447da73c2e1a661b8396]

        tdf#75509 tdf#138409 Convert default value to double without formatter
        
        Since e6004bddfc8d7d41f4e17691eaeefd770c608a13 the default value for a
        table field is converted to a locale-independant format where the
        decimal separator is always “.” using OUString::number. However when
        loading the value back again to display in the text box the value was
        being parsed with the decimal separator of the table field. This will
        fail if the decimal separator in the format for the field is not “.”. To
        fix that this patch changes it to parse the string with
        OUString::toDouble instead.
        
        I think that tdf#75509 and tdf#138409 are the same bug. I think the
        commit mentioned above fixes part of the problem so that if you create a
        field with a default value that has decimal places then they will be
        used when creating a new row. However, if you then try to edit the field
        again then without this patch the default value will be reset to a blank
        string because the double parsing code doesn’t understand the “.” in the
        canonicalised string.
        
        Without this patch it’s also quite difficult to create such a field at
        all. Whenever you try to save the table after editing, the text box for
        the default value reloads the new value and triggers the parsing problem
        so it gets reset to a blank string. The only way I can get it to work is
        by selecting a different field before saving the table or closing the
        edit window. Somehow this problem must have slipped through the testing
        for the second bug so I don’t know if the testers did the steps
        described above or if the problem is backend dependant or something.
        
        Change-Id: Ic1d47893245e93322248542bf2decfdc34987771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 40ce74d57c7661a6bb556135c1304a87d92f0178)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193190
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-30  Karthik Godha  <karthik.godha@collabora.com>  [618daf04009ede9f6989e1739afbb1bec7ca474c]

        tdf#168773: PPT->PPTX incorrect background in XML
        
        While exporting to PPTX check whether BITMAP filltypes have graphic
        content before starting <p:bgPr> element
        
        Change-Id: I5dfd57538fbd3f8c834495ba76535c641b7fa06f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192795
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit c5eb2b9def1c1d189da71d8bb27f9fddd0a63ef7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193074
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193134

2025-10-30  Karthik  <karthik.godha@collabora.com>  [d9522e6b7828c76953fb52cf8ec2229bb9afee72]

        impress: fix PPT->PPTX time animate value interoperability issue
        
        Saving a PPT file as PPTX could sometimes corrupt the output because of
        negative animation time(ST_TLTimeAnimateValueTime).
        
        ST_TLTimeAnimateValueTime can't be negative ([ISO/IEC 29500-1] 19.7.39).
        
        The patch ensures that animation times values are non-negative during
        PPTX export
        
        Change-Id: I366a9acfc59231545737d67859dfcfd0a4beb886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192122
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8dce45fde0f23f2f3083b313676889016775d2aa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193078
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193133

2025-10-30  Karthik  <me@karthikreddy.org>  [f3c228aced4f71088d562610f2c99797ea5e7227]

        tdf#139331 Bug fix related to "Auto-Redact"
        
        Change-Id: I407239568fb7da948fe582f04673d4ef1b638b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189901
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 21f017a95b56a86a73e2712903141b069f55d939)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193061
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [da6b70633ac6bf78ce0a68022518396a2c650970]

        tdf#168314: check if xGraphic is empty, not Any
        
        Regression after commit 9d6e1594a298c9d41f3dc64ad80edf4b9868c2e8
        (Deduplicate and unify using vcl::GetBitmap, 2024-11-08).
        
        An Any with an empty graphic is not itself empty; such an any caused
        the outer check to succeed, and therefore its 'else' branch never
        executed, when it ought to.
        
        Change-Id: I97115c7f7dbab4ec54b5e999e4b47ecdc8874e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193161
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit a8216f500c223797b13976678924b76c5effec65)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193170
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-30  kallial  <aleksi@pullakahvit.fi>  [d4d6e7adfc4dc11077b6455d51f2590fd72212c1]

        tdf#160701 Change OpenPGP untrusted key dialog type from "Error" to
        
        "Warning"
        
        Change-Id: I626e7fa6861699d86490b63b8d3c1c7efc31206a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192586
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        (cherry picked from commit fc2948b208a847b12a80bdf0af0e32fb76961f72)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193125
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54aaa6a1e475921573f07d3e5a3a1f22018574bb]

        Resolves: tdf#165265 don't autoselect a font style
        
        If nothing was originally selected, then don't pick anything and leave
        the combobox empty so the search for style feature doesn't add any
        not-explicitly selected font styles by default.
        
        Continue to restore a previously selected style, favouring the last
        explicitly selected-by-user style.
        
        Change-Id: Iad04d80305029cc3bbe3e8500ced87085645f9f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193160
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e419d3927b62cbc90bbfd0f893adb268af38afdf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193171
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-29  Bayram Çiçek  <bayram.cicek@collabora.com>  [d80f7687753d1a784780f79b00f9c08ec4dc65f7]

        tdf#169115: sc: fix use-after-free bug in ScDocument::FillInfo
        
        backtrace:
        
        ==203082== Invalid read of size 8
        ==203082==    at 0x933730C: std::_Hashtable<unsigned short, std::pair<unsigned short const, SfxPoolItem const*>, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> >, std::__detail::_Select1st, std::equal_to<unsigned short>, std::hash<unsigned short>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::size() const (hashtable.h:662)
        ==203082==    by 0x933B57C: std::_Hashtable<unsigned short, std::pair<unsigned short const, SfxPoolItem const*>, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> >, std::__detail::_Select1st, std::equal_to<unsigned short>, std::hash<unsigned short>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_locate(unsigned short const&) const (hashtable.h:2264)
        ==203082==    by 0x9339895: std::_Hashtable<unsigned short, std::pair<unsigned short const, SfxPoolItem const*>, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> >, std::__detail::_Select1st, std::equal_to<unsigned short>, std::hash<unsigned short>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find(unsigned short const&) const (hashtable.h:1929)
        ==203082==    by 0x93380C6: std::__cxx1998::unordered_map<unsigned short, SfxPoolItem const*, std::hash<unsigned short>, std::equal_to<unsigned short>, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> > >::find(unsigned short const&) const (unordered_map.h:958)
        ==203082==    by 0x93367A4: std::__debug::unordered_map<unsigned short, SfxPoolItem const*, std::hash<unsigned short>, std::equal_to<unsigned short>, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> > >::find(unsigned short const&) const (unordered_map:635)
        ==203082==    by 0x9329A7D: SfxItemSet::Get(unsigned short, bool) const (itemset.cxx:922)
        ==203082==    by 0x22AB22AE: ScPatternAttr::GetItem(unsigned short) const (patattr.hxx:167)
        ==203082==    by 0x22AB7610: ScMergeAttr const& ScPatternAttr::GetItem<ScMergeAttr>(TypedWhichId<ScMergeAttr>) const (patattr.hxx:170)
        ==203082==    by 0x2305FEAE: lcl_GetMergeRange(short, int, unsigned long, ScDocument const*, RowInfo*, short, int, short, short&, int&, short&, int&) (fillinfo.cxx:110)
        ==203082==    by 0x230628A1: ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) (fillinfo.cxx:710)
        ==203082==    by 0x24216D6F: ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) (printfun.cxx:1610)
        ==203082==    by 0x2421B6FC: ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) (printfun.cxx:2329)
        ==203082==    by 0x2421D378: ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) (printfun.cxx:2741)
        ==203082==    by 0x23F9ABB4: ScModelObj::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (docuno.cxx:2824)
        ==203082==    by 0x2F7769C2: PDFExport::ExportSelection(vcl::pdf::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) (pdfexport.cxx:185)
        ==203082==    by 0x2F77C1AA: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:1180)
        ==203082==    by 0x2F793CBA: PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:182)
        ==203082==    by 0x2F794634: PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:247)
        ==203082==    by 0x87819F0: SfxObjectShell::ExportTo(SfxMedium&) (objstor.cxx:2908)
        ==203082==    by 0x877ADD8: SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) (objstor.cxx:1929)
        ==203082==    by 0x8784F5F: SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objstor.cxx:3421)
        ==203082==    by 0x8783956: SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objstor.cxx:3212)
        ==203082==    by 0x8758B98: SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objserv.cxx:323)
        ==203082==    by 0x87EC565: SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) (sfxbasemodel.cxx:3253)
        ==203082==    by 0x87E313A: SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1834)
        ==203082==    by 0x4A36155: desktop::DispatchWatcher::executeDispatchRequests(std::__debug::vector<desktop::DispatchWatcher::DispatchRequest, std::allocator<desktop::DispatchWatcher::DispatchRequest> > const&, bool, desktop::DispatchRequestFlags*) (dispatchwatcher.cxx:719)
        ==203082==    by 0x4A51E6E: desktop::RequestHandler::ExecuteCmdLineRequests(desktop::ProcessDocumentsRequest&, bool) (officeipcthread.cxx:1316)
        ==203082==    by 0x49F1B07: desktop::Desktop::OpenClients() (app.cxx:2221)
        ==203082==    by 0x49F0158: desktop::Desktop::OpenClients_Impl(void*) (app.cxx:1981)
        ==203082==    by 0x49EFF3E: desktop::Desktop::LinkStubOpenClients_Impl(void*, void*) (app.cxx:1965)
        ==203082==    by 0xDD827EE: Link<void*, void>::Call(void*) const (link.hxx:105)
        ==203082==    by 0xDD7F4DC: ImplHandleUserEvent(ImplSVEvent*) (winproc.cxx:2312)
        ==203082==    by 0xDD8181B: ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (winproc.cxx:2869)
        ==203082==    by 0xE862B5D: SalFrame::CallCallback(SalEvent, void const*) const (salframe.hxx:310)
        ==203082==    by 0xE8829B1: SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) (svpinst.cxx:291)
        ==203082==    by 0xE2EBFC0: SalUserEventList::DispatchUserEvents(bool)::{lambda()#1}::operator()() const (salusereventlist.cxx:119)
        ==203082==    by 0xE2EC299: SalUserEventList::DispatchUserEvents(bool) (salusereventlist.cxx:120)
        ==203082==    by 0xE8831CA: SvpSalInstance::ImplYield(bool, bool) (svpinst.cxx:444)
        ==203082==    by 0xE883611: SvpSalInstance::DoYield(bool, bool) (svpinst.cxx:523)
        ==203082==    by 0xE3A347C: ImplYield(bool, bool) (svapp.cxx:389)
        ==203082==    by 0xE3A4168: Application::Yield() (svapp.cxx:492)
        ==203082==    by 0xE3A2E8B: Application::Execute() (svapp.cxx:364)
        ==203082==    by 0x49EE737: desktop::Desktop::Main() (app.cxx:1681)
        ==203082==    by 0xE3CC959: ImplSVMain() (svmain.cxx:230)
        ==203082==    by 0xE3CCA1A: SVMain() (svmain.cxx:248)
        ==203082==    by 0x4A5AEEC: soffice_main (sofficemain.cxx:122)
        ==203082==    by 0x40009D0: sal_main (main.c:51)
        ==203082==    by 0x40009B6: main (main.c:49)
        ==203082==  Address 0x2c9fb388 is 120 bytes inside a block of size 224 free'd
        ==203082==    at 0x48508DD: operator delete(void*, unsigned long) (vg_replace_malloc.c:1181)
        ==203082==    by 0x231265C0: CellAttributeHelper::doUnregister(ScPatternAttr const&) (patattr.cxx:157)
        ==203082==    by 0x231277BE: CellAttributeHolder::setScPatternAttr(ScPatternAttr const*, bool) (patattr.cxx:362)
        ==203082==    by 0x22AB2499: ScAttrEntry::setScPatternAttr(ScPatternAttr const*, bool) (attarray.hxx:95)
        ==203082==    by 0x22AA826B: ScAttrArray::SetPatternAreaImpl(int, int, CellAttributeHolder const&, ScEditDataArray*) (attarray.cxx:574)
        ==203082==    by 0x22C0939A: ScAttrArray::SetPattern(int, CellAttributeHolder const&) (attarray.hxx:160)
        ==203082==    by 0x22BEFFA4: ScColumn::ApplyAttr(int, SfxPoolItem const&) (column.cxx:565)
        ==203082==    by 0x22C79299: ScColumn::SetNumberFormat(int, unsigned int) (column2.cxx:3301)
        ==203082==    by 0x231EE6EA: ScTable::SetNumberFormat(short, int, unsigned int) (table2.cxx:2331)
        ==203082==    by 0x22E4DCF0: ScDocument::SetNumberFormat(ScAddress const&, unsigned int) (document.cxx:3768)
        ==203082==    by 0x230755FF: ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (formulacell.cxx:2156)
        ==203082==    by 0x2307385F: ScFormulaCell::Interpret(int, int) (formulacell.cxx:1619)
        ==203082==    by 0x22CCD0F7: ScFormulaCell::MaybeInterpret() (formulacell.hxx:470)
        ==203082==    by 0x230776E9: ScFormulaCell::IsValue() (formulacell.cxx:2761)
        ==203082==    by 0x22D60AEC: lcl_GetCellContent(ScRefCellValue const&, bool, double&, rtl::OUString&, ScDocument const&) (conditio.cxx:774)
        ==203082==    by 0x22D6334B: ScConditionEntry::IsCellValid(ScRefCellValue const&, ScAddress const&) const (conditio.cxx:1273)
        ==203082==    by 0x22D66225: ScConditionalFormat::GetData(ScRefCellValue const&, ScAddress const&) const (conditio.cxx:1897)
        ==203082==    by 0x230608EA: (anonymous namespace)::handleConditionalFormat(ScConditionalFormatList&, o3tl::sorted_vector<unsigned int, std::less<unsigned int>, o3tl::find_unique> const&, ScCellInfo*, ScTableInfo*, ScStyleSheetPool*, ScAddress const&, bool&, bool&, bool) (fillinfo.cxx:293)
        ==203082==    by 0x23061EB3: ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) (fillinfo.cxx:564)
        ==203082==    by 0x24216D6F: ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) (printfun.cxx:1610)
        ==203082==    by 0x2421B6FC: ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) (printfun.cxx:2329)
        ==203082==    by 0x2421D378: ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) (printfun.cxx:2741)
        [...]
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I4dfd8fca4b799e8f0fae8563e7beaf781fb30d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193095
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 1bf9bbea96a0fb508bb3dc917e31362fe2c14e18)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193145

2025-10-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [465e7fddb34fe06d9464ee534c79a02dd72707d4]

        tdf#169108 - Create anonymous database range or data
        
        Create anonymous database range or data during the creation of a pivot table. Otherwise, the selection changes to a old autofilter areas and the pivot table cannot be created.
        
        Change-Id: If55b9d1204ab2ce2c3ee9a227bf0dbe1e222dbcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193096
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        (cherry picked from commit 2a50c7fbb85941a2c50ac01257af36f132b07006)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193137
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-29  Jonathan Clark  <jonathan@libreoffice.org>  [9301eb8efa519bff1f2f90cd0a2306e4a4e64fea]

        tdf#148991 sw: fix string corruption after IME dismiss
        
        Fixes an out-of-bounds substring copy when dismissing an IME in
        overwrite mode when the candidate text is longer than the original
        paragraph.
        
        Change-Id: I09032225f3a6d85043cc4c6fa5f2b1bfeafc3755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193103
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 2d32f9abd43e9308ebc14c9f12fa7440f1cc1654)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193111
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e8a3e5a502a4ee17e6b6141d1d7c967fc55c4a5]

        ReemKufi: upgrade to 2.0
        
        Adapt test (anonymous namespace)::testTdf66597_2::TestBody
        since Regular has been dropped from font’s full name
        see https://github.com/aliftype/reem-kufi/commit/19b763750f7d4b63377b8cd82252d73a48e18fbf
        
        Downloaded from https://github.com/aliftype/reem-kufi/releases/download/v2.0/ReemKufi-2.0.zip
        
        Change-Id: I92b7878b6b57e90474d81fb9b8a7cdced742e69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193028
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193100
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-27  Julien Nabet  <serval2412@yahoo.fr>  [97784a6c5bdcaa0920360b39cea105cdea9c291d]

        tdf#169079: Remove format type SQL from the Data Provider dialog
        
        Change-Id: I3a64d8d237599d379c3199c2a3efe26a889915e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193007
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit 7f4fbf32e62f4cb20f8448eee405fa9b15cd5587)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193019
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [670c5cee9d08c4ac4696e65ab550b97f8d590e29]

        tdf#164718: allow splitting multiline fields in SwTextFrame::FormatAdjust
        
        Commit 167be9363ea505b334aa595b273707d7d9217863 (tdf#160526, tdf#160549:
        fix split conditions at page start, 2024-04-11) had changed a condition
        to split at a line, disallowing it when the position stored in nEnd is
        equal to the start of the line. It turned out, that the multiline field
        portions are special; for all following portions, the line start is the
        position after the field placeholder character, and the length is zero.
        This change handles such fields into account.
        
        To check if this is a multiline field, it calls SwLineLayout::IsRest.
        The respective SwLineLayout::SetRest is only called in two places in
        SwTextFormatter::WhichFirstPortion. SwTextFormatInfo::SetRest is also
        called there, with nullptr as the argument, which explains why
        SwTextFormatInfo::GetRest didn't help in the pre-existing code in
        SwTextFrame::FormatAdjust.
        
        The split of the field is correct here. There is a different problem,
        that this split is undone later at some place, if widow/orphan control
        is not 0; that should be fixed separately.
        
        Change-Id: I3141a4ad4c1e8b3f5437d1fa63f0fd04cffcb297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192978
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b5533565c5c7250f1940ba80e03297fdbf78b435)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193016
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-27  Karthik Godha  <karthik.godha@collabora.com>  [eaef560633e0e2f83ba5188b24111db55a873741]

        tdf#168567: Fix import of SDTs with empty content
        
        regression from commit 7c4dba1deffd81f647a4a3be7a79f68f3bf9f1
        
        SDTs(content controls) with empty paragraph content are not properly
        imported.
        
        Change-Id: I340a060f03b419b3352fad2a8fb5ac3af043be54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192466
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 72a326b2899115860a87cfa55b82f745a76128da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192952
        Tested-by: Jenkins
        (cherry picked from commit 2444243cab5f49fdec77de332491e9ae5c57b0f4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192960
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-27  Stephan Bergmann  <stephan.bergmann@collabora.com>  [656a79ed1365851e7f8b0f3dacb29321c0264b6b]

        Fix presumed | vs. & typos
        
        ...introduced in 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c "Resolves: tdf#164920
        add scrollbar width to desired size if enabled" and causing
        
        > svx/source/tbxctrls/linectrl.cxx:435:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
        >   435 |     if (nBits | WB_VSCROLL)
        >       |         ~~~~~~^~~~~~~~~~~~
        > svx/source/tbxctrls/linectrl.cxx:576:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
        >   576 |     if (nBits | WB_VSCROLL)
        >       |         ~~~~~~^~~~~~~~~~~~
        
        Change-Id: I6f77cd30f3b98abb15afb665b336fba13d46ee01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192963
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit ad6e817e38545903f5fbbe11a2dcb033e5affead)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192968
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [216c31600970374b12a5f2aaf6d9f91098e1aa4c]

        update credits
        
        Change-Id: Id71076a39bde8f6c01283e207773f80b3acbb6e2
        (cherry picked from commit b65b00d904f8ae1c84c9dbdd9e6629080aee858a)

2025-10-24  Đoàn Trần Công Danh  <congdanhqx@gmail.com>  [1d15201503d2d17ddede4aade0ef4666e64f862b]

        Fix memory leak with poppler-25.10.0
        
        https://gerrit.libreoffice.org/c/core/+/192743, which fixes ftbfs with
        poppler 25.10.0, unfortunately introduced a memory leak when building
        with poppler 25.10.0 or later.  `pOwnerPasswordStr' and
        `pUserPasswordStr' ownership are supposed to be transfered to
        `pDocUnique', but is now orphaned.
        
        This change fix that said memory leak.
        
        Change-Id: I545d461c07f033b41a4276665483b44fa401a3bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192645
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 89841fc69446a597b24b978344cd3c8d656aae09)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192934

2025-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [74384758e93792d16bf4af712ba39b36d1c78c70]

        tdf#168858: drop workaround for hidden last section
        
        Commit bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903 (fdo#53210 SwDoc::UpdateExpFlds
        don't crash when hiding all sections, 2012-08-10) added an exception for a case
        where the last section was hidden, leaving no content on a page. That happened
        because hidden sections, unlike e.g. hidden paragraphs, didn't generate frames
        for layout. The workaround set the section's condition to "0", which prevented
        it from hiding. It wasn't robust: the problem could happen for nested sections,
        where the outer section was hidden, so the inner section got hidden even with
        its condition set like that. Also, the workaround could apply to sections that
        ended up not the only content on the page (maybe that happened at a moment when
        layout hadn't finished yet).
        
        Commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565 prerequisite: make
        hidden sections have zero-height frames, 2024-02-14) changed how sections are
        hidden, to follow what paragraphs do: they now create zero-height frames. That
        made the workaround unnecessary.
        
        This change reverts commit bb6bd1ff9cd3eecec7eb2cd7bd0a4dcef584c903.
        
        There is a (pre-existing) problem, that documents having only hidden content,
        like tdf168858_nested_hidden_section.fodt, open in read-only mode. It should
        be fixed in a separate change.
        
        Change-Id: Iac653baef0d17a2e7ec4e75acbf915f281daa9ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192902
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0856a6a4dfcb00c63fcc13c116f570a2d6c4ca57)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192916
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-24  Miklos Vajna  <vmiklos@collabora.com>  [48267890aa9567eb01bff87d8a3f69f8e0ad9997]

        Related: tdf#168916 DOCX import: handle page break from style on framed para
        
        Open a subset of the bugdoc, it's of two pages in Word, it's one page in
        Writer.
        
        What happens is that the paragraph that's at the top of page 2 in Word
        has a <w:framePr> property on it, so it forms a text frame, but it also
        inherits a <w:pageBreakBefore> via using the Heading 1 style and Word
        layout then handles this 'page break before' request.
        
        Fix the problem by extending a previous fix in this area: commit
        f6f53f76e15f5eecc5b6ce56e471c53cebfea8ad (tdf#123636 writerfilter:
        handle deferred breaks on frames, 2019-04-30) already tried to handle
        this, but it covered only the case when the page break property was set
        directly. Now this is also found via a style.
        
        The actual bugdoc needs more fixes, but this way at least we attempt to
        split floating tables at places where the expected result of that split
        is known, while previously we tried to split at the wrong positions, due
        to the loss of the page break.
        
        Change-Id: Icc24fcdb05a4375583917eb97b63f4a19dc4bd17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192834
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 1d833123014274a182ea42e92ca21e4ece736389)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192843
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8d4320a6420ea623f613203cc508a90e8d3c494]

        tdf#169015: GetOutlinerParaObject might return nullptr
        
        Regression from
        commit 43e511e642a2ce7026b30ea5c212940ff3eb522e
        Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        Date:   Fri Nov 29 02:10:21 2024 +0100
        
            tdf#88226 sd: fix cutting off the overflow text on the notes print page
        
        Change-Id: I4e25760afe4bd535d1accf8291f9cbb4457625ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192895
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 9a406c26e8b8d09b99c949192bc731ba6126cef0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192898
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-23  Jim Raykowski  <raykowj@gmail.com>  [6ec012e2eecb7c6359b2e16730ea90da32845f3c]

        tdf#168951 sd: fix crash when dragging an unnamed object from
        
        Navigator and dropping it in the Pages pane
        
        The patch prevents dropping of unnamed objects by checking
        SdTransferable::IsPageTransferable()
        
        Comment in SdPageObjsTLV::DoDrag():
        "For shapes without a user supplied name (the automatically created name
        does not count), a different drag and drop technique is used."
        
        std::shared_ptr<SdTransferable::UserData>
        Clipboard::CreateTransferableUserData (SdTransferable* pTransferable)
        if (nPageIndex == SDRPAGE_NOTFOUND) break;
        
        This is why SdTransferable::SetPageBookmarks does not get called and
        therefore mbPageTransferable is not set true.
        
        Change-Id: Ia4eddb6c384e6e73047a0cddd4cd59c20562aa5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192675
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit c78a692927ad85700e9121edecd32a263ba80a24)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192889
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dae5ca06276383df0799cf2c92df5e2bb8883be2]

        tdf#114068 allow to translate media control tooltips in navigator pane
        
        tooltips for play/pause/stop/repeat/mute were explicitly flagged as
        non-translatable for some reason. There is a media toolbar that has the
        same set of controls and there could be a way to share the strings, but
        they only are a handful, so not really worth a big refactoring of the UI
        files for that.
        
        Change-Id: Ia0e8e2bd664916392049df5cd537d51eb04005d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192873
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 74e55a3c756c1f3ce540bf7ab575ca40a334172d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192912
        Reviewed-by: Martin Srebotnjak <miles@filmsi.net>

2025-10-23  Michael Stahl  <michael.stahl@collabora.com>  [1bfdcb210f3bd01c9406a8710944be4911e2209a]

        libxslt: add patch for CVE-2025-10911
        
        Change-Id: I951aad2bff3911f685f73390e4f42ed29fe49b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192444
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit fca876c2c369b26244413fafe506acafb9d3b5bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192862
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-10-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a0f821d0206468cb18100ed31b8c1acfa87b9ef8]

        tdf#168953 File - Version... - Show does not wrap
        
        Change-Id: I4a38eeee835a9ee4e0adf86ea6822f3a370c4548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192878
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        (cherry picked from commit 2495aa94f5d3bc4c53ec263630f922d212b29a6e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192884

2025-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b67f5ec64c99cd47ab85adedb45396426018126b]

        tdf#168979 survive broken color percentile scales
        
        Change-Id: I3180d08272fd7355987f63f5379a044d98467cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192838
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192845

2025-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c43b3e019c5ea9b396a0cdd602137539387857d1]

        crash in GetPercentile with empty std::vector first arg
        
        /opt/collaboraoffice/program/../program/libsclo.so
                (anonymous namespace)::GetPercentile(std::vector<double, std::allocator<double> > const&, double)
                        sc/source/core/data/colorscale.cxx:624
        /opt/collaboraoffice/program/../program/libsclo.so
                __gnu_cxx::__normal_iterator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > const*, std::vector<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> >, std::allocator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > > > >::operator*() const
                        /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1096
        /opt/collaboraoffice/program/libscfiltlo.so
                ScHTMLExport::WriteCell(sc::ColumnBlockPosition&, short, int, short)
                        sc/source/filter/html/htmlexp.cxx:923
        /opt/collaboraoffice/program/libscfiltlo.so
                ScHTMLExport::WriteTables()
                        sc/source/filter/html/htmlexp.cxx:864
        /opt/collaboraoffice/program/libscfiltlo.so
                ScHTMLExport::WriteBody()
                        sc/source/filter/html/htmlexp.cxx:699
        /opt/collaboraoffice/program/libscfiltlo.so
                ScHTMLExport::Write()
                        sc/source/filter/html/htmlexp.cxx:313
        /opt/collaboraoffice/program/libscfiltlo.so
                rtl::OUString::operator=(rtl::OUString const&)
                        include/rtl/ustring.hxx:586
        /opt/collaboraoffice/program/../program/libsclo.so
                ErrCode::IgnoreWarning() const
                        include/comphelper/errcode.hxx:102 (discriminator 1)
        /opt/collaboraoffice/program/../program/libsclo.so
                rtl::OUString::~OUString()
                        include/rtl/ustring.hxx:546
        /opt/collaboraoffice/program/libmergedlo.so
                TransferableHelper::SetObject(void*, unsigned int, com::sun::star::datatransfer::DataFlavor const&)
                        vcl/source/treelist/transfer.cxx:912 (discriminator 1)
        /opt/collaboraoffice/program/../program/libsclo.so
                ScTransferObj::GetData(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&)
                        sc/source/ui/app/transobj.cxx:395
        
        ScColorScaleFormat::CalcValue is optimized out, but it has to be
        
        case COLORSCALE_PERCENTILE and getValues() must return an empty vector
        
        Change-Id: I2cf09f19edcb5f30c82eca02e2a0fe95e86c78db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192823
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192837
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192844
        Tested-by: Jenkins

2025-10-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [22f246255db99f68ead356a4074783950fe026c0]

        bump product version to 25.8.4.0.0+
        
        Change-Id: Ida31c66737db2596c339f42b425c31aed6ee3b32

2025-10-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a366c2e4aa71a416411ae0c40347ccf6f6ddcdaa]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 17df49cf269a1e1917dc5d4347db00a3dd92bab0
          - update translations for 25.8.3 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Ie174d7556325e998d0f7a2e9eb3bfcc9bb93ea6f
            
2025-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b77b59adca898565b88b38a0d5b6b51fcda52f1b]

        Resolves: tdf#164920 add scrollbar width to desired size if enabled
        
        Change-Id: Ib6e354d5a4a9076b81e6a26fe78bdd4994024ec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192810
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [fa68edb7bbe54c71b7c9507412b1812d2c20b0ff]

        a11y: Set mnemonic-widgets in password dialog again
        
        They were dropped in
        
            commit 1791a290a82591d5b0609502e86f07ed69acee5c
            Date:   Sun Mar 9 13:27:57 2025 +0530
        
                tdf#146947 Add show/reveal toggle to "Set Password" dialog
        
        for no apparent reason, resulting in the Orca
        screen reader no longer announcing the text
        of the label that describes what the entry
        is for.
        
        Example to trigger the dialog:
        
        * start Writer
        * "File" -> "Save As"
        * check the "Save with Password" checkbox
        * hit OK button
        
        Change-Id: Ifbb9c6e69254cf5f9439fcfd5347e845ba09f96a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192820
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 8ceea0574dbfd84d06ec367c44454e69a1ec5af3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192828
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9394454f9e79634d31562e26eb5d1fc868419f3f]

        nss: upgrade to 3.117
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_117_RTM/src/nss-3.117-with-nspr-4.37.tar.gz
        
        Change-Id: If381a7686a6d3db93e45778855ec74ee90be426b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192799
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit b168b52022d59e79dc2c3a9ebdb1b8b968b9c3e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192804
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [225263fb51e19032a0aa0fef93778308df648898]

        python3: upgrade to 3.11.14
        
        * Add external/python3/setuptools.patch.1 to deal with the space
        in Lib/setuptools/_vendor/jaraco/text/Lorem ipsum.txt
        
        Downloaded from https://www.python.org/ftp/python/3.11.14/Python-3.11.14.tar.xz
        
        Change-Id: I0fe4730ee26267e0042fb10b6ad78bbc21ca1ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192784
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e667fa90e602b89fa3d198897aa85c7cdd01cea]

        glm: upgrade to 1.0.2
        
        Downloaded from https://github.com/g-truc/glm/archive/refs/tags/1.0.2.zip
        
        Change-Id: I07b5bc3a63d0dbe196b38f81ef9329ac44c962cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192781
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit a6080387f85b0018c31060b05e0d223e1541e0f4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192794
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a96851ee7e3201d719a032d0f85c064eaa7a269e]

        poppler: upgrade to 25.10
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.10.0.tar.xz
        
        Change-Id: I05f89f4177312a148a5a15cd1f1b206d1dc01a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192743
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit ae83e577501c504f89b434606f05ff1d555729c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192754
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6315f9834a446b9d2ba831ac53781cc7bd5546e]

        libgpg-error: upgrade to 1.56
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.56.tar.bz2
        
        Change-Id: I6aeb7723e94cffe6bdcad8cd6af74891210c4d26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192709
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 802328a6055106d4bf1ecaba6db1b6cc473b96fd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192741
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [e6875a474b394a9d01bd6c05414d8e704f8bb29a]

        tdf#168980: don't use shape Z-order to identify shapes
        
        The problem was wrong identification of the shape type, because of
        unreliable use of fragile Z-order.
        
        XMLShapeExport::exportShape used xShape's Z-order to get the info
        collected for current xShape. Value of Z-order is calculated in
        SwXShape::getPropertyValue; it takes into account text boxes of
        shapes, which affects the correction in SwTextBoxHelper::getOrdNum.
        The correction results in several different objects returning the
        same Z-order. And in the specific document, the information that
        was collected for a rectangle object, was used for an object of
        different type.
        
        Instead of trying to find a smart way to continue using Z-order,
        this change uses XShape itself as the key into the map of info,
        similar to how XShapes objects are used as keys into ShapesInfos.
        
        Change-Id: Iacbc101623504db4290ad2c283351c4141b2d1b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0dc93fddcc751a28cfdb936f61bb6f0f4812e4b9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192805
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-21  Khaled Hosny  <khaled@aliftype.com>  [0704f03eca87491f87381a2fa995f1920bb19151]

        tdf#168884: Restore missing transparency in EMF files
        
        Revert unrelated changes from:
        
        commit 1bdf1e2d52a7fae3e1a58ddf15a7657df3d47004
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Thu Sep 25 16:33:09 2025 +0300
        
            tdf#168371: Disable ligatures in Impress/Draw with character spacing
        
        I added a new parameter to TextSimplePortionPrimitive2D constructor, and
        rTextFillColor that previously was using the default value had now to be
        explicitly set, but I should have used COL_TRANSPARENT as that is the
        default.
        
        Change-Id: Ie51e8f3f4c68a9539eb3f6cc77fb1e6cf44f673f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192779
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 1dce54d8fb070d3d4134317612c145a923497bb4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192788
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-21  Aron Budea  <aron.budea@collabora.com>  [30ca1deeebbdb3cf69816fe65401d91e36596717]

        tdf#168885 oox: save more of empty charts
        
        Otherwise Word will complain.
        Affected types: area, bar, bubble, line, stock.
        
        Regression from 3b4c11350a631e27345e87ecfe258d12983cbfbc.
        
        Change-Id: I56d533d9c55bae45240a1b51733ff60f47b1b2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192483
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192782

2025-10-21  Miklos Vajna  <vmiklos@collabora.com>  [7afa99daab032723aabdeea00d6d69cf97928434]

        tdf#166319 sw interdependent redlines: fix redo of direct reject for format
        
        Open the bugdoc, select the format part of the insert-then-format
        redline in the manage changes dialog, reject, undo, redo: the result is
        <ins>AAA</ins>BBB<ins>CCC</ins> instead of one big insert redline.
        Similarly, open the other bugdoc with a delete and a format redline in
        it, select the format part of the delete-then-format redline in the
        manage changes dialog, reject, undo, redo: the result is
        <del>AAA</del><format>BBB</format><del>CCC</del> instead of one big
        delete redline.
        
        What happens is that the UI action uses
        sw::DocumentRedlineManager::RejectRedlineRange(), while the redo uses
        sw::DocumentRedlineManager::RejectRedline(), and while the first
        supported direct accepts, the later did not.
        
        Fix the problem by:
        1) In sw::DocumentRedlineManager::RejectRedlineRange(), create the undo
           action with the correct depth & directness for direct rejects
        2) In DocumentRedlineManager::RejectRedline(), use use
           lcl_RejectOuterFormat() to directly reject a format redline instead
           of the usual lcl_AcceptRejectRedl(), which gives us matching behavior
           for the UI action & the redo.
        
        Writer's interdependent redlines are now in a reasonable state with
        this: actions for the redline under cursor work with ins/del when
        possible (looking "through" format); while the manage changes dialog
        still allows working on the format redline directly if that's wanted.
        
        Change-Id: Idb90dfbd86ac26ff51da8a34731ea75a48748bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192015
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192736

2025-10-21  Miklos Vajna  <vmiklos@collabora.com>  [fbec8ab124b58779567e14428238136baa1e84d6]

        tdf#166319 sw interdependent redlines: fix redo of accept for fmt on ins/del
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins> content, accepting the
        BB part "directly (via the sidebar or the manage changes dialog, so you
        accept the format, not the underlying insert), then undo, then redo
        resulted in <ins>AA</ins><format>BB</format><ins>CC</ins> instead of a
        single insert, as expected.
        
        What happens is that the UI action uses
        sw::DocumentRedlineManager::AcceptRedlineRange(), while the redo uses
        sw::DocumentRedlineManager::AcceptRedline(), and while the first
        supported direct accepts, the later did not.
        
        Fix the problem by:
        1) Extending SwUndoRedline with a flag to know if the accept/reject to
           be performed by redo should be a direct action or not
        2) Fixing sw::DocumentRedlineManager::AcceptRedlineRange() to create an
           undo action with the correct depth (should be 0, was 1) & save the
           direct flag into the undo action
        3) In sw::DocumentRedlineManager::AcceptRedline(), use
           lcl_AcceptOuterFormat() to accept a format redline directly instead
           of the usual lcl_AcceptRejectRedl().
        
        This also fixes the case where you have a format on top of a delete
        (instead of an insert).
        
        Change-Id: I78d7ae9eebf8525191a3d9b3a1731d80ad04a75b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191960
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192735

2025-10-21  Miklos Vajna  <vmiklos@collabora.com>  [772189ecaca99338672d94aeb1f34abb836b7f3e]

        tdf#166319 sw interdependent redlines: allow accept/reject for fmt on ins/del
        
        When a format redline is on top of an insert/delete and the uno command
        is dispatched to accept/reject the redline under cursor, then we always
        interact with the insert/delete, ignoring the format. This is usually
        wanted, but now there is no way to interact with the format redline,
        even if you would explicitly ask for it.
        
        Notice that the manage changes dialog/sidebar has a separate row for the
        format redline and the ins/del redline under it (at the same document
        model position), so that gives us a way to select the format redline
        explicitly and interact with it.
        
        Implement this by adding a "direct" mode to the edit shell's
        AcceptRedline() / RejectRedline().
        
        With this, all of the (insert or delete) then format, (accept or reject)
        on it case works in direct mode. Undo also works, redo still needs
        fixing.
        
        Change-Id: I7947cd6c7264773d51e63ccd7c45acb001a79d88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191592
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192734

2025-10-21  Jim Raykowski  <raykowj@gmail.com>  [55d72acdba8e55ff44da1534d7c9426fc89a6063]

        tdf#168929 fix cannot rename objects with CJK languages via Navigator
        
        Change-Id: I11fa5106d63b78a4aacb144ed70ac658607611a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192704
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit 4f053ee1b55faa9deec3cbf7cb88f265458b20e0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192739
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [b2947edc956ebd42b994ff08a96ec0fa43a2ec90]

        tdf#164677: separator properties in XMLTextColumnsPropertyHandler::equals
        
        When collecting autostyles, each added autostyle is compared with the
        already added ones. If all the properties match, new autostyle is not
        added, but an existing one is used.
        
        For text columns, the comparison procedure only compared things defined
        in XTextColumns interface, and ignored all properties of TextColumns
        service - so, styles only differing in those properties were considered
        identical, and only the first of them was saved and used for all cases.
        
        This had never been implemented properly; all versions I tested, did the
        same, so I doubt it was a regression. But indeed, it was a bug.
        
        Change-Id: I0042067499a904a66ffb10b4f4ce4115d86e6cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192639
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192684
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [fbb1d7bcba219685d789c2f4cdf348f8f7f8d696]

        related tdf#168511: bundle venv on mac too + Add test
        
        I missed it in
        commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Sep 23 10:07:26 2025 +0200
        
            tdf#168511: python3: bundle venv
        
        Change-Id: I180df8df27ece92aaa1feca379d280ff3f1ba2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191392
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191398

2025-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [ecda1df6a14e99d5713309b786ff9137dda4767e]

        tdf#168511: python3: bundle venv
        
        Change-Id: I5d4b03571099486b981f83b0487cdcbc4dd7a1a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191377
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191386

2025-10-20  Justin Luth  <jluth@mail.com>  [92307cad6a66f4fc891f566b9a40832971b198f4]

        tdf#162461 Revert "tdf#129924 docx import: set background color"
        
        This reverts 6.4.1 commit 9476dfe7d1b86b367966e7dedf67e11936c8d9d7
        
        Automatic font-color needs to be exported as automatic,
        not some hard-coded value based on some background whatever.
        
        There were lots of fixes related to "highlight" verses "shade"
        backgrounds in 7.x, so this hackery would be obsolete anyway.
        
        Change-Id: Ic62fe56c74cffd8c8475befe745e9fb1c227ec1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192518
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 74063178d58d30706c68003ee8ad8e6053f8df50)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192695
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [05d1d307e83431f2e1e649ffe3c1f0854b44d13a]

        tdf#168673: approx equality threshold no less than 1/2 15th significand
        
        01:26,47 is 0.001000810185185185, which has 16 significant decimals. It
        is converted to string as "0.00100081018518519" (15 significands).
        
        The problem was, that when criterion "=0.00100081018518519" is used to
        check value 0.001000810185185185, the two numbers differ in five least
        significant bits, but rtl_math_approxEqual uses 0x1p-48 to ignore last
        four bits only. This is a common problem for numbers close to 1.0E(N).
        
        This change introduces a second threshold, in addition to "only take
        into account 48 signigicant bits of mantissa": it calculates the value
        of half of 15th decimal unit of the smaller absolute value, and uses
        the greater of the two thresholds for the approximate equality.
        
        Change-Id: I2f98ab23c94ca3a2949c3762fbfb6ea563eef94b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191883
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d32c664c3df302b7107a70858aa55b11601225cf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192696
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [e2b2ecad7a0ffdf1e0c34ec70c1987698971cbad]

        tdf#165615 sw floattable, no overlap: avoid check against an own follow
        
        Load the bugdoc, the layuot loop control kicks in:
        warn:sw.layout:20117:20117:sw/source/core/layout/tabfrm.cxx:1853: LoopControl in SwContentFrame::CalcLowers
        and then the content is laid out on 3 pages, while it fits 2 pages in
        Word.
        
        What happens is that the document has an inline table, then a floating
        table inside that. The inner floating table has tblOverlap set to
        'never', and then things go wrong in
        SwToContentAnchoredObjectPosition::CalcOverlap().
        
        Fix the problem by checking if the two overlapping fly frames are
        actually next to each other in a split fly chain: if we're the precede
        of the other fly, then no need to worry about the overlap, that follow
        fly will move to the next page anyway.
        
        In theory this would be also interesting for toplevel floating tables,
        too -- but in practice CppunitTest_sw_core_layout's testSplitFlyHeader
        shows doing this in general would need more work, so just do this for
        floating tables which are inside tables.
        
        Change-Id: I4d0f1bd5229f8fbc3bb49af57f88fd6ef911cbfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192433
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 72e79a4d75cbbc8615fe9815bbbe9a38780ff856)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192717
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [153a8942c7c9070dbcbb398d90f126ea5ba1a775]

        tdf#162730 sw floattable: fix when inside an inline table, with hide mark
        
        Open the bugdoc, it has an outer inline table, then an inner floating
        table. The inner table is split, but both parts of it stay on page 1,
        leading to overlapping text.
        
        This document's outer table has a single row and a single cell, but the
        cell has a <w:hideMark> property. If that's missing, the inner floating
        table is split properly.
        
        Fix the problem by ignoring <w:hideMark> in case the cell's only content
        is a floating table: in this case setting the row's size type to "fix"
        would not be correct anyway.
        
        Regression from commit 2d43c34333076fad092f0cdc0f60f81580acdbee
        (Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at
        cell start, 2023-09-15).
        
        Change-Id: Ia9759a1c8ebaaa22b547a5ff250fa9dcf7ffbe4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192512
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 25ab6816990b688bf12004280664fb3810996f1c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192716
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [80850b7d086e2b0fc7f792130cce951d5d946573]

        tdf#167326: Let CalcHeightWithFlys take hidden frame state into account
        
        Table cells use that function to calculate the min cell height. In the
        bugdoc, sections inside a cell contained flys, and were hidden. When
        the min cell height was calculated, the sections' flys were considered,
        despite they were hidden.
        
        Change-Id: Ie5a8fb54a1c9fe21cc5f4d474bd24feabb660330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192232
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 0ba44065385cbee7c490cf4a97641c19edc79a63)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192713
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [58561ba4dea22e59b7a7fb36170d574cbbcae936]

        tdf#168817: don't emit hyperlink markup for Ruby portions
        
        It produced incorrect markup like
        
        <text:a ...><text:ruby ...><text:ruby-base>...</text:a></text:ruby-base><text:ruby-text>...</text:ruby-text></text:ruby>
        
        after commit c50fbdceafdd4b857954f098e38cae03e8bc6064 (tdf#148198: merge
        identical hyperlinks of adjacent text ranges on ODF export, 2022-07-18).
        
        Only the inner Text portions need an 'a' element.
        
        Change-Id: Ia5a0b671b5d454b0e9d4dab0295b57249db9f4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192249
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192683

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1aac67235256b90479de733d178bfe6a955a1888]

        OUStringLiteral -> OUString
        
        Change-Id: I124ab59b49493a0ca8b052b6f7c0347fae64e765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192252
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192729

2025-10-20  Jonathan Clark  <jonathan@libreoffice.org>  [768b67b1b727d93134dba1efd624000b57b653a2]

        tdf#166044 sw: Fix cont. footnotes repeating the dest page number
        
        Fixes an issue causing Writer to print the destination page number twice
        in footnotes with continuation notices that end in non-Latin text.
        
        This was happening due to subtle mismanagement of the m_bHasFollow flag.
        Continuation notices rely on this flag being unset to indicate the field
        portion responsible for printing the destination page number, but the
        layout algorithm was leaving this flag unset on two different portions.
        In Latin-only documents, this bug was hidden by SwLineLayout::CalcLine()
        removing the second portion, but this isn't possible when a script
        change is involved.
        
        Regression since commit 6c0105307efa15837e9e5287103995312f373b67
        (sw: fix stale SwNumberPortion follow flag)
        
        Change-Id: I94c6f7ca75a3cf844d3eff2640d63777ac026717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192464
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 23a0a5d5d2d004c85e6230040d4d1475e79f48fc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192726
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Justin Luth  <jluth@mail.com>  [482871586febdea7d5ccef815f8ad33ffb40c095]

        tdf#157365 sw: apply colorConfig change to SwModule
        
        This fixes a 7.6 regression from
        commit 1916d161902bdd52b8cfa5b29153c8f8c39fce52.
        
        Changes made were not immediately applying to new documents,
        and perhaps not even to the current document
        if the user also looked at SwModule options.
        
        Change-Id: I5fa21cac57ab1bbfc96b9d6d2b7f403b32103e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192410
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 2b0bc0ed83cc0ec03ea30570dc7538df22f303b1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192724
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [aa690147e302325bfbdc44c1fada42e7c59966e5]

        tdf#168777: Trailing space must show all decorations, also for ODF
        
        Commit 853e13f9146e83b959bc53152ec103470d55fb4f (tdf#57187: make sure
        to put trailing blanks to hole portion in narrow lines, 2023-12-30)
        caused a regression, where trailing whitespace lost its decorations.
        
        Commit a877c6ce97f73906c39cf800bc61d7d99847361c (tdf#164487: Introduce
        "Show underline" MS Word compatibility option, 2025-02-26) took care
        of the Word compatibility case, and introduced a compatibility flag
        matching respective flag in Word. It only handled underline, as the
        flag name in Word implied.
        
        It turns out, that (1) Word's flag, despite its name, controls all
        decorations of trailing writespace (highlignting, strike-out); and
        (2) before the original commit, Writer's default was to show all the
        decorations as well. Which means, that there is only one case when
        the decorations must be omitted: if "Word-compatible trailing blanks"
        is enabled, but "Underline Word-compatible trailing blanks" is off.
        
        This change is intended to show trailing space's underline, overline,
        strike-out, border, and highlighting correctly.
        
        Change-Id: I68d0aaaa0a7b9610ec817728bd4acad92ef26fe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192191
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b36f181bb71c395f9c48c6358bea550ac4767839)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192712
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Jonathan Clark  <jonathan@libreoffice.org>  [13c6bc02d4c60e6aa35ae2145db431cfe8ae6dba]

        tdf#72341 sw: Make inc/dec font size affect all scripts
        
        This change updates the FN_GROW_FONT_SIZE and FN_SHRINK_FONT_SIZE
        handlers to scale fonts for all script types, even if the
        currently-selected text does not contain a particular type.
        
        This fixes the reported issue that bullets in RTL context are not
        resized if a selected list item does not contain CTL characters. This
        also fixes the broader issue of inserted text not reflecting earlier
        size changes, simply because the script type for that inserted text
        wasn't present at the time.
        
        Change-Id: I881f0b90b5c3aecbbf2e40ee2ad6758de9c5bad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192459
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192725
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Aron Budea  <aron.budea@collabora.com>  [2c0f2c55ab43f39e54e8df9164665dd7544d8658]

        tdf#168921 sw: don't export user fields with empty names to DOCX
        
        Otherwise Word will complain.
        
        Started from ae5f469d3893de73850ccc369dbf426a4acd8f15.
        
        Change-Id: I223bcea33645e02972bc189eef0b913fc19b3b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192583
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit bd01fe073f0ef0eae54f6e9a6d4ecce68171d1c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192691
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [05a0f70a417dbe71ca7b580d6e62c0a7977a0c72]

        Some DDE fixes
        
        It seems that some DDE code was virtually never tested in our CI.
        That resulted in several unnoticed regressions.
        
        In commit 81b954718f0cdac6873927e869b3e41f863562e7
        (loplugin:unnecessaryvirtuals, 2015-06-09), DdeService::MakeTopic
        was made non-virtual. That broke its use on Windows, where a derived
        class used to override that method (which of course didn't use the
        'override' keyvord, hence went unnoticed).
        
        In commit 88e3b846b8a4bd4ce5507d1bc5441ee4167e5326 (remove some dead
        bits of DDE, 2016-04-06), DdeService::MakeTopic was finally dropped.
        
        In commit c026b936404bd052fc74283d3cc2e0727ec4edb9 (no need to
        allocate SfxDdeDocTopics_Impl separately, 2023-02-28), a check in
        SfxApplication::AddDdeTopic was changed from testing if pDocTopics
        were initialized to checking if they are empty. The new test made
        adding anything to the vector impossible.
        
        This change tried to make it functional again, and adds a (Windows-
        only) unit test.
        
        To enable unit test, we need an app name, so that DDE is initialized
        properly. Also, ImplDdeService::MakeTopic had a condition to exit
        early, when !Application::IsInExecute(). Here we allow to add it, if
        unit test is running.
        
        SfxDdeDocTopic_Impl::Put ismodified to store OUString to the Any -
        see ScByteSequenceToString::GetString. Without the change, UTF-16
        was treated as 8-bit-encoded string.
        
        theDdeInstData in svl/source/svdde/ddecli.cxx is now not a pointer,
        bus a function-local static. No need to delete it: it has nothing
        that needs to be released. Before, it could get destroyed too early,
        preventing DDE from working.
        
        DdeConnection::~DdeConnection could reliably deadlock, when it had
        a connection to the server in the same process; processEventsToIdle
        is called now to avoid that.
        
        DdeData ctor taking OUString is fixed: xImp->nData is bytes, not
        characters.
        
        Change-Id: I9a151eebc65a26b76c9f6134e97cd1f4d2e2b615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192690
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [7e0713ad8a2b06c9ffd5b5d83b2a28fe1d7012a4]

        sc: fix crash in SparklineGroupsContext::onCharacters()
        
        Fixes this assertion failure in a crash report:
        	/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1230: constexpr std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::back() [with _Tp = oox::xls::Sparkline; _Alloc = std::allocator<oox::xls::Sparkline>; reference = oox::xls::Sparkline&]: Assertion '!this->empty()' failed.
        
        Backtrace from gdb on the core:
        	#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
        	#1  0x00007f906206e7f1 in __GI_abort () at abort.c:79
        	#2  0x0000000000af43ee in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
        	#3  0x00007f904d07ff87 in std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>)
        	    at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
        	#4  std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
        	#5  oox::xls::SparklineGroupsContext::onCharacters(rtl::OUString const&) ()
        	    at sc/source/filter/oox/SparklineFragment.cxx:232
        	#6  0x00007f905cf0988a in oox::core::ContextHandler2Helper::processCollectedChars() ()
        	    at include/rtl/ustring.hxx:546
        	#7  0x00007f905cf09a05 in oox::core::ContextHandler2Helper::implEndElement (nElement=3475622, this=0x7f902403e880)
        	    at oox/source/core/contexthandler2.cxx:123
        
        gdb also points out that m_aSparklineGroups is non-empty.
        
        Change-Id: Ib368550f6db0ed7ce4fbe37e056cd416208e7fe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192424
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit cde426b7dbea32f93607130d13f108330a8b6275)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192721
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [7422b7b60631f0f43fad7781d9f4b0e7fb5a4fb8]

        sd: fix crash in SdDrawPagesAccess::remove()
        
        Crashreport signature:
        
        > kit-1853625-1853625 2025-10-05 16:19:13.871457 +0000 [ kitbroker_02b ] SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x100
        ...
        > program/libmergedlo.so
        >       SdrUndoPage::SdrUndoPage(SdrPage&)
        >               svx/source/svdraw/svdundo.cxx:1308
        > program/libmergedlo.so
        >       SdrUndoDelPage::SdrUndoDelPage(SdrPage&)
        >               svx/source/svdraw/svdundo.cxx:1383
        > program/libmergedlo.so
        >       std::_Head_base<0ul, SdrUndoAction*, false>::_Head_base<SdrUndoAction*&>(SdrUndoAction*&)
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/tuple:200
        > program/libsdlo.so
        >       SdDrawPagesAccess::remove(com::sun::star::uno::Reference<com::sun::star::drawing::XDrawPage> const&)
        >               sd/source/ui/unoidl/unomodel.cxx:5181 (discriminator 4)
        
        and gdb on the coredump says:
        
        > #5  0x000070373442496a in SdDrawPagesAccess::remove (this=0x6caee6e0, xPage=...)
        >     at /home/collabora/jenkins/workspace/build_core_co-25.04_for_online_snapshot/sd/source/ui/unoidl/unomodel.cxx:5181
        > 5181                        rDoc.AddUndo(rDoc.GetSdrUndoFactory().CreateUndoDeletePage(*pNotesPage));
        > (gdb) print pNotesPage
        > $5 = <optimized out>
        > (gdb) down
        > #4  SdrUndoFactory::CreateUndoDeletePage (this=<optimized out>, rPage=...) at /home/collabora/jenkins/workspace/build_core_co-25.04_for_online_snapshot/svx/source/svdraw/svdundo.cxx:1763
        > 1763        return std::make_unique<SdrUndoDelPage>(rPage);
        > (gdb) print &rPage
        > $6 = (SdrPage *) 0x0
        
        so check for the case when pNotesPage is nullptr.
        
        Change-Id: I1033d5196b329cb648fd27ac2633833a723f47a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191948
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 81c26f3c3f9c3b3672b6bbc34605d121ffaa1b72)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192718
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [8acfabf1f8bbb444d4fc3275a897da0aa0830e5e]

        tdf#168688 DOCX import: fix missing char props in field in header in ToC
        
        Regression from commit 6ee33d0772f991f04e97b5b61d7b11810a1b8ac0
        (tdf#104079 RTF import: fix handling fields inside TOC fields,
        2017-10-17), open the bugdoc, check the font size of "TEST" in the
        header, it should be 24pt, but it's 12pt.
        
        What happens is that the document ends with the table of contents DOCX
        field, so the section properties at the end of the document (including a
        reference to a header) get parsed while the ToC field is still open, so
        we think that m_xTOCMarkerCursor is in use, but it's for the body text
        and we're in the header, so it's not relevant.
        
        Fix the problem by moving m_xTOCMarkerCursor to m_StreamStateStack,
        where all state that should be stashed away & restored later belongs.
        This way the old tdf#104079 use-case keeps working and the new use-case
        gets fixed.
        
        Interestingly this xTOCMarkerCursor is not actually used as a cursor
        anymore and it just indicates if we're inside a ToC or not, but leave
        that unchanged in this commit.
        
        Change-Id: I1d1c9f55413d94dcde9e7c715bc9f9863f354dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192392
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 86d0a2f84d714da67d83fdba652540ebe1027382)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192720
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [8a8cf61700d08e166ff206f2d291a16f5f6662ee]

        tdf#167676: do not run updater tasks in headless mode
        
        Also reorder conditions to only check environment variables after normal
        registry settings.
        
        Change-Id: Idac6d7135da366dabf9285310d445925e9e4d1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192113
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 02f93a9d1763336eb655ec13d1cfd1e114246b34)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192711
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [fb8332fd4ac068835ba3a6557e8a67c5a5006559]

        tdf#167143: set text of the correct row
        
        Regression after commit 00e2762c664614a1b33f54dfc990ba29f0f81a07
        (Drop uses of css::uno::Sequence::getConstArray in cppuhelper ..
        cui, 2024-04-29).
        
        Change-Id: I9544160ee3857c3ef8322c85529f5ff6a4ce0e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192055
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f5cd16a252a73a3e594fc19eba365c52ec987fbb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192710
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Justin Luth  <jluth@mail.com>  [1b6d78398021ebaf59b7d1d3579aab1ba2242d1e]

        tdf#114343 titlepage: DoSpecialInsert (Alt-Enter) when necessary
        
        If the document starts with a TOC or a table,
        then the title page wizard (Format - Title page)
        fails to (properly) insert a page before.
        
        (note that while it DID insert a page before the TOC,
        that para-with-page-break is all still "part of the TOC"
        and so when the TOC is refreshed, the page break is lost.)
        
        make -srj1 UITest_writer_tests5 \
            UITEST_TEST_NAME=titlePageWizard3.tdf114343.test_tdf114343 \
            SAL_USE_VCLPLUGIN=gen
        
        make -srj1 UITest_writer_tests5 \
            UITEST_TEST_NAME=titlePageWizard3.tdf114343.test2_tdf114343 \
            SAL_USE_VCLPLUGIN=gen
        
        Change-Id: I0eb865259889601c0918096d8dd51fc50d0dca52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191164
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 932c8227717f44877d77659c444845d39f4156ce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191356
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Michael Stahl  <michael.stahl@collabora.com>  [015b61daec58227263bf05defe97a03c92762dc5]

        configure: openssl 3.0.18 evidently needs perl Time::Piece
        
        Can't locate Time/Piece.pm in @INC (you may need to install the Time::Piece module) (@INC entries checked: ...) at Makefile.in line 37.
        
        Change-Id: Ia47eeb971f7bf91972f46be46330f10e64682799
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191735
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 0622d8d160b54b120e3955b6b0e177a2a25ca0d1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191752
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8d5da57c259a3a3d09a0118846c75a269bf38cdf]

        Threaded import crash in ScDocument::ShrinkToDataArea
        
        since possibly(?) https://gerrit.libreoffice.org/c/core/+/180773
        
        one thread, importing sheet 0, uses ScDocument::ShrinkToDataArea
        for a range on sheet 1 while sheet 1 is importing on a different
        thread.
        
        Change-Id: Ia982e4c0af4859aacbca19420941f19ee85479eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191920
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 7a6ebc8be8f5df795d1c9e0cca1a740ee2b62b27)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191986
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1ef44db022c76ea28aa63aa3243a8660fb5d061c]

        tdf#168723: realloc should create the _correct_ size before access ;-)
        
        This is how commit 36df0b837b398f1011cb6f9fdf978a24125eee89 (INTEGRATION:
        CWS os47 (1.3.190); FILE MERGED, 2005-01-28) desctibed the same change
        in commitPage. The leftover's time came, just after 20 years.
        
        Change-Id: Id960f84349b8885811ad750d5956965d0ccf47b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191981
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 014612657286b8042580245773934c5a9433503b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192697
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [5219ea7b98bb35fc9f4ec39f25ebfafb7346bc25]

        tdf#168750: Make sure that class module is recognized on load
        
        The problem appeared, when a macro loaded a library with a class module,
        that had a public element (e.g., a function) with the same name, as used
        for a local variable in the macro without a prior DIM.
        
        Normally, there is a precaution in SbModule::Find, which hides the names
        in class modules. However, this precaution failed during load.
        
        The reason was, that the flag identifying the module as a class module
        was set only when the module got compiled. It turned out, that first, it
        is parsed in SbModule::SetSource32 only partially, with minimal work to
        recognize the names (and a few other small things). At this stage, it is
        not marked as class module yet; and when the clashing name is looked up,
        it gets found in the module. Then its value is requested; at this point,
        the module gets compiled, and the "class module" flag is set; then, if
        the class module element tries to use another name from the same module,
        it fails, which produces visible error message.
        
        This change makes sure, that the initial fast parse stage also checks
        Option ClassModule, to set it properly. Also it drops redundant variable
        bIsProxyModule from SbModule, because mnType already contains the needed
        type information. And lastly, it reorders SbModule::Find a bit, to avoid
        searching a module, only to discard the result immediately, because it's
        a class module.
        
        Change-Id: I8add9873bf31fb767b64d27a36aef8e3a89a0de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192075
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192689

2025-10-20  Miklos Vajna  <vmiklos@collabora.com>  [0ca27b0abb86898effe7d28d1e7786aa8027cd33]

        xmlsec: upgrade to 1.3.8
        
        Downloaded from
        <https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.8.tar.gz>.
        
        Remove 0001-const-up-xmlSecErrorsTable.patch, which is upstream already.
        
        Change-Id: I633ed7ecc90b8d798aa9ae03a4237fda4cf26b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192476
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit d56e6cc6ec7807155e56bb7c59aabe5f8f885beb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192688
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Aron Budea  <aron.budea@collabora.com>  [8602573b3b9509702d8df15128488e032e825c6e]

        tdf#168754 sd: escape comments exported to PPTX
        
        Change-Id: Ic0574980ec3d837f7747aaeb54fb8925aff2987f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192072
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit 6cab4cb50cf67a8dd595fffa107968cb1bd9fd18)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192083
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [2b8c4cdb286102a848a711259089ba87ef08d9ee]

        Related: tdf#168842 Don't truncate source precision in vcl::TextToValue
        
        When user enters a value like "2.54cm", and current input box is points,
        which has only one decimal digit, it does not make sense to apply that
        precision to the input string, making it mean "2.5cm" (and resulting in
        70.9 pt).
        
        This change adds a function to convert such strings to double, instead
        of sal_Int64; then the double is handled using vcl::ConvertDoubleValue,
        as before.
        
        Now entering "2.54cm" produces the expected 72.0 pt.
        
        This needed some OUString->u16string_view for loplugin:stringviewparam.
        
        Change-Id: I5afa4edada904c4d8b8bcd9df65243546cb6bd00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192663
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e05e6af1ee3af91ed59da5c30fbd38e12d1f3c37]

        tdf#167704 fix gallery themes not using translations
        
        regression from d81808ec15064e7655503253dddb8ebdc58b1b29
        
        it is not substr(startPos, endPos) but substr(startPos, length)
        so the code ended up with the whole remainder of the key: 'langCode]'
        instead of just 'langCode' and that broke the lookup.
        
        Change-Id: I33eddf566e2d453dff14c123fc6c8cda97382b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192573
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit 961439e8e6f7a5a179bcdd092254dd1f32a1c7c5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192672
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-19  Noel Grandin  <noelgrandin@gmail.com>  [0056bfa3fccc4f50ae0dccf70be01aed55583e93]

        tdf#168744 editting format of writer input field asserts
        
        Fixing two bugs here. To trigger these bugs, try to do:
          open bugdoc
          right-click -> edit fields
          and then change the selected date format
          and then click OK
        
        First I have to remove an assert added in:
           commit 99055ae98ef1fe67b8db4a8c3167a8acaeaac02f
           Author: Michael Stahl <michael.stahl@allotropia.de>
           Date:   Fri Feb 2 20:10:24 2024 +0100
           tdf#123968 sw: fix assert on importing ooo62823-1.sxw
        Which makes no sense, because we use those values all over
        the place in  SwSetExpField, and this assert does not
        seem to be related to the rest of that bugfix.
        
        Secondly, we have to fix a cast and then a check in
        SwFieldPage::InsertField.
        SwFieldTypesEnum::Input can, for better or worse, either
        refere to an SwInputField or an SwSetExpField, so we
        cannot cast to an SwInputField BEFORE we have checked if
        it is actually an SwInputField.
        Also the condition we were checking here is the wrong way
        to determine what kind of subclass this is.
        
        Change-Id: I92c0047a2a3662d3184aad2ec06f565e306d5407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192067
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 388af2c059533adb773fa9a4ebda577da523509c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192089
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-19  Justin Luth  <jluth@mail.com>  [26f5e07563f6f95dc2f9e00b9eb4315aa0e2951a]

        tdf#99205 sw options: don't lose automatic spell checking status
        
        This patch fixes Tools - Options - Writer
        from mistakenly turning off the automatic spell checking.
        
        The SwModule m_pUsrPrefs is created early,
        before a view has been created,
        so the default value of bOnlineSpell(false)
        might still be in effect.
        
        Since "ApplyItemSet" doesn't at all control IsOnlineSpell,
        pull the global value from the current view,
        so that we don't get a mistaken change in ApplyUsrPref
            if( !(*pSh->GetViewOptions() == *xViewOpt) )
            {
                //is maybe only a SwViewShell
                pSh->ApplyViewOptions( *xViewOpt );
        
        Change-Id: I761ce6c04ee45b7f228615be57bf6235c3e18fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192585
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit a2de588c344f24f8f2e359d6f2b736fc4fba0a80)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192667
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [fd3605fbcea46ca35bdeaaa5dd5f8a8b5016e0f9]

        linux_aarch64: Fix Android build with NDK 29
        
        An Android build including autogen options
        
            --with-android-ndk=$HOME/Android/Sdk/ndk/29.0.14206865
            --with-distro=LibreOfficeAndroidAarch64
        
        failed like this:
        
            .../bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:604:29: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'unsigned char *'
              604 |     __builtin___clear_cache(const_cast<unsigned char *>(begin), const_cast<unsigned char *>(end));
                  |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            1 error generated.
        
        Tweak the version check introduced in
        
            commit 28e542dc61d408f5807e8c94ed48c273146edbda
            Date:   Wed Apr 23 13:17:21 2025 +0200
        
                Avoid loplugin:redundantcast on macOS with recent LLVM 21 trunk
        
                ...including
                <https://github.com/llvm/llvm-project/commit/b6b025797245a5e5416b522df041252e3c4ff868>
                "Fix the signature for __builtin___clear_cache (#134376)", which now caused
        
                > bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:601:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
                >   601 |         reinterpret_cast<char *>(const_cast<unsigned char *>(begin)),
                >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                > bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:602:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
                >   602 |         reinterpret_cast<char *>(const_cast<unsigned char *>(end)));
                >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        to not expect the new signature for Android NDK <= 29,
        for which __clang_major__ is 21, but which doesn't have the
        relevant commit mentioned in the commit message quoted above.
        
        The NDK 29 release notes mention [1]:
        
        > Updated LLVM to clang-r563880c. See clang_source_info.md in the toolchain
        > directory for version information.
        
        ~/Android/Sdk/ndk/29.0.14206865/toolchains/llvm/prebuilt/linux-x86_64/clang_source_info.md
        contains this:
        
        > Base revision: [386af4a5c64ab75eaee2448dc38f2e34a40bfed0](https://github.com/llvm/llvm-project/commits/386af4a5c64ab75eaee2448dc38f2e34a40bfed0)
        
        That referenced llvm-projects commit
        386af4a5c64ab75eaee2448dc38f2e34a40bfed0 is indeed before
        the b6b025797245a5e5416b522df041252e3c4ff868 one mentioned
        above.
        
        [1] https://github.com/android/ndk/wiki/Changelog-r29
        
        Change-Id: I88419d0d8d47563d6d0d236dc17806979e56c831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192378
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 1ccb2ecd4e3e883e7a715b0b0f13c2e57d120b45)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192402
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7574ddff417e9767a7c1c1285fc50ee51f41caed]

        tdf#164927 allow Theme dialog to be customized in menu/toolbar
        
        Change-Id: I157474d2ff0bc060d717e373f98eb50729b8645c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192564
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit f1c96d118a29e4f406c88ca9202ec6b317c89df2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192599
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-19  Mike Kaganski  <mike.kaganski@collabora.com>  [d0b3b1086cf6fe7c8160bd08b69cf375b44a6b88]

        Related: tdf#168842 digits in GtkSpinButton, lost in SRC -> UI conversion
        
        The digits setting may only apply when the current unit is point: see
        SetFieldUnit, which special-handles the unit. So the omission of the
        setting went unnoticed for a long time.
        
        This is similar to commit 75b30f1d107f45aebbf9a0811b9d40f4b2bafdce
        (tdf#168842 Issue entering paragraph values in cm, when default is in
        points, 2025-10-15), and tried to handle the rest of omissions in UI.
        
        Change-Id: Ia348e29b268c5f49dc9eedc24262d30efbb8faa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192636
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f6df8fc72f9bcab541554cd98859304f34d19f21)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192659
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-17  Regina Henschel  <rb.henschel@t-online.de>  [3ba0ea447d88856da2e08db3ad3b12c0a7f622d3]

        tdf#168861 tooltip line wrap for length > 100 char
        
        The current threshold is 150 characters. However, this results in very
        wide normal tooltips that are hard to read. Therefore, the threshold is
        reduced to 100 characters. The value 100 was chosen because it is
        currently already used as threashold for cases where the text contains
        line breaks.
        
        If the tooltip length is smaller than 100 characters, the tooltip is
        displayed in a single line. This behavior does not change with this
        patch.
        
        The threshold was introduced for OOo bug i42424 to force a line wrap
        in the footnote balloon rectangle that is shown when you hover over
        a footnote anchor with the mouse.
        
        I don't know how to test the width of such a temporary tooltip
        rectangle in a unit test. Thus a unit test is missing.
        
        Change-Id: I7e4c47e5212f0af2510878ef2c3d6475d1d5ba46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192458
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 34612217f8a027b940169899eb5c5514155649df)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192570

2025-10-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6dacd3417222825e3bdfb1420fafcd4b2abe4eb5]

        tdf#168842 Issue entering paragraph values in cm, when default is in points
        
        Change-Id: Ib954a05bc9bea2db72b37da803a192f645e127b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192405
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 75b30f1d107f45aebbf9a0811b9d40f4b2bafdce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192422
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-10-13  Julien Nabet  <serval2412@yahoo.fr>  [7b00f09c09f24b403102decc1f205b51bdcbaeaf]

        Fix f5f228ea9d5abd24e6e6fc332b383894ec6d2d8c
        
        Only the first change was right.
        The other one is wrong, console log showed
        (soffice:82981): GLib-GObject-CRITICAL **: 20:52:50.810: g_object_new_is_valid_property: property 'label' for type 'GtkCheckButton' cannot be set twice
        
        Change-Id: Iab3528a6c181e2af20690977586395e52e0f3240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191515
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit ba6ae8bfdb3f92f5d8f702c40f1c281754378234)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192324
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-10-13  Mike Kaganski  <mike.kaganski@collabora.com>  [c5500e388884785cc7590832d321353467abcb6d]

        Deduplicate some code that clamps values
        
        Change-Id: I7581863235c93eacbffd3bea7fe2733a97395b17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192239
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit dc33e6bbcd3132036eff1069834348ea67de8cee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192257
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-12  Mike Kaganski  <mike.kaganski@collabora.com>  [4c9a19587ffe26606f7664ae6272767b20c32609]

        tdf#168709: set decimal digits for Page dialog's metric controls
        
        Regression after commit 7ba10e2d317a53763e1aff55a85546bfdac12fc5
        (Convert page format tab page to new widget UI, 2013-02-27).
        Before the change, in cui/source/tabpages/page.src there were
        'DecimalDigits' for all metric controls, set to 2. The commit
        didn't set any digits in the UI file that replaced page.src.
        
        The adjustment of the metric fields happens in SetFieldUnit; if
        the current unit is point, then the result of the adjustment will
        depend on the pre-set digits; when there was none, it stays none.
        
        This change restores 2 decimal digits in the UI.
        
        Change-Id: I98ed501825e1c9115f992441cbd28a089fe0a234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 81c707a4aa897d2793aa3f40dd08295ab7e019c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192255
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-12  Mike Kaganski  <mike.kaganski@collabora.com>  [bb821267b55541e515087b598054502ec450840b]

        tdf#168709: round double value instead of truncation
        
        Regression from commit cfff893b9c82843a90aac4ecdb3a3936721b74a0
        (Move unit conversion code to o3tl, and unify on that in more places,
        2021-02-14).
        
        Change-Id: If18e8537cd03d3fd516bd164c6a816f1bba38f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192235
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit dd544837226d9af2a777c145f91972fd0b755587)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192254
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f335e5b73193912a2ceda2e577093e80e98e27a7]

        ofz Use-of-uninitialized-value
        
        Change-Id: I3dfc1296e174d6751300991f214e99b09d745e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192189
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7796d3e5522f0cdb6508362cbd9b49255ec866cc]

        ofz Use-of-uninitialized-value
        
        Change-Id: I6a80b3e16f904d50e72c03bab25164e03f192a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192186
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-10  Heiko Tietze  <tietze.heiko@gmail.com>  [61fdfed5372c2e914ff735377a591d17451054aa]

        Resolves tdf#154443 - Use Colibre fallback for page shadow
        
        Change-Id: Ieadfbea52304686d6af609d7a211c74510f8a91b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192096
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        (cherry picked from commit fbbbc56214d4a1fa72bb2453ad0f321294ad8049)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192143
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-10  Dev Lo  <lodev@ossii.com.tw>  [e4063dc67bd79aa34d23de292b6b462d9339304f]

        tdf#146101 Filter Context prop in Notebookbar Extension tab and menu
        
        Shows correct icons in Extension tab, and correct extensions in the
        right-hand dropdown menu
        
        Change-Id: I6902fc3fe380841356d4c5753cb326df62305d11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191418
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        (cherry picked from commit f44eca0ace11a195b0516a6cadab9be0a4857331)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191995
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-07  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [f8a323604ed37f916236d3a8b640732b93a2a568]

        Resolves tdf#168610 - MacOS main icon should respond to icon style
        
        Requires some transparency that macOS can fill with dark/clear/tinted
        values. To achieve this, the white background of the main icon and its
        shadow was removed temporarily and the icon expanded to fill the space.
        
        Change-Id: Ib82b457c038ff237c7f3b60441ec915a91d040e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192008
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        (cherry picked from commit c1c340425d8c842e73f546b0803e026672c77fc6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192042
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-07  Patrick Luby  <guibmacdev@gmail.com>  [811a901f6242e9dd7d01a050ad9cb793a555a0d4]

        tdf#168711 Ignore marked text in -[SalFrameView selectedRange]
        
        While -[SalFrameView attributedSubstringForProposedRange:actualRange:]
        looks at marked text, -[SalFrameView selectedRange] should only return
        selected text.
        
        Change-Id: I8145f6d186cb4d17a50c545929bde3023caddd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191989
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 0f6d14dbe7f0f5a50a28ea8b796a8a97de756487)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192041
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cb0271065184716e247c222410878ce444cd2e58]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 8580a1686ad62f6cc2960447d96855315e3a1117
          - update translations for 25.8
            
            and force-fix errors using pocheck
            
            Change-Id: Iae167d1fe7905971d19ac26f99bcd6c34c3c155a
            
2025-10-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5a597640883526f80a466dcebbdc6d69ad6a61be]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to fee16ab5d16ee912ac40010c9ebed311ac5991ed
          - Revert "tdf#151551 Help Updates for Hyperlink Dialog"
            
            This reverts commit 10793e69187eaa6092dad7943dbf78b2e6f556f1
            
            Change-Id: I718176c8417becd3de44ce99b37fc1abc07b5046
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/191833
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            (cherry picked from commit 67cf1084e0f8897deb522fc9bd8b8a47776b2c02)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/191956
            
2025-10-06  Michael Stahl  <michael.stahl@collabora.com>  [dc06c589ef2a97a84570c4b14a9fbcc6670f13aa]

        tdf#167205 package: fix writing Zip64 local headers
        
        This would be reported on reading as an 8-byte gap at the position where
        a 32-bit DD for the entry would end.
        
        The problem is that if flag bit 3 is set, and the uncompressed size
        exceeds 2^32, writeDataDescriptor() will write 8-byte sizes, but the
        Zip64 extension header is missing - the latter should also write 0 even
        though the APPNOTE doens't appear to require it.
        
              4.3.9.2 [...] When extracting, if
              the zip64 extended information extra field is present for
              the file the compressed and uncompressed sizes will be 8
              byte values.
        
        Also make sure that the ZipEntry nSize member actually contains the
        uncompressed size, which is somewhat tricky, but is required in
        writeLOC() to check if Zip64 is needed.  (Assume that the DEFLATEd size
        is never larger than uncompressed, which is true for every XML file).
        
        Change-Id: I611e6ffda12d8e6953e9306dc4a4407be8e725a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit abfdc11fa45610f38d00999f66416c66a868426a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191719
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b124070e695649bb1480b32a15acfa606ee9738]

        openssl: upgrade to 3.0.18
        
        Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.18/openssl-3.0.18.tar.gz
        
        Change-Id: Ie24873924bf8a0f9d3edb37e4e69e2e64b25ce47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191693
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit b9abb977cbdc90ffc5c60ac5307cede571c168d7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191694
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-03  Michael Weghorn  <m.weghorn@posteo.de>  [f36e68a9085d02317997f64faedb685054d56589]

        tdf#168646 vcl: Forward unhandled tooltip event to base class
        
        In VclDrawingArea::RequestHelp, if the drawing area specific
        logic doesn't provide a tooltip text to show, call the base
        class implementation, instead of returning without doing
        anything.
        
        This ensures that the extended tip logic implemented in
        Window::RequestHelp is triggered as expected when
        those are enabled.
        
        Change-Id: I2918cc3377ec53e649d54cceaf0c9cb53effe58f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191801
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 9adbd5a71dca00de4d2323883a01ae4e7c02dc97)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191804
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-03  Jonathan Clark  <jonathan@libreoffice.org>  [dd6c84ccf72e02f921664b9954425b19793bc245]

        tdf#136663 sw: Remove extra spacing between Hangul and non-CJK scripts
        
        Previously, Writer would add a kern portion between any CJK text and any
        non-CJK text. This is the correct behavior for Chinese and Japanese,
        which add a small amount of extra space between CJ characters and
        non-CJK text as a typesetting convention. This behavior is not, however,
        a convention of Korean typesetting.
        
        This change corrects Writer so it no longer inserts this extra space if
        the involved CJK characters are Hangul.
        
        Change-Id: I711df97fca55cb8c26809ac5549871f2407bbfaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191756
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191761
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [426beb0fe20753ebc60c43149d27fe38d7d0257e]

        harfbuzz: upgrade to 12.1.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.1.0/harfbuzz-12.1.0.tar.xz
        
        Change-Id: I693d354139b8ce0e06b41dfb4a90381321762eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191767
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191792
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad1cc6c7e34dff03604a4ae5978d5efd8712d8ca]

        harfbuzz: upgrade to 12.0.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.0.0/harfbuzz-12.0.0.tar.xz
        
        Change-Id: Ib0010a2ef897b7c2ef5f75ba8eea15d2ecf365e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191631
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit e6bcb4ae0d958a53b40dfc0c88f4f7d7f98d677f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191640
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-10-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [87de4e9da06aa91e6bd92bbd2d4c0b81d22c5d7a]

        Revert "tdf#151551 Remove frame target option from Hyperlink dialog"
        
        This reverts commit 74147823a7c933c796239b00cd9bf89edb899eb3.
        
        The terminology in the dialog confused the reporter and implementers
        and a useful feature was accidentally removed. The feature may be
        simplified later, but let's first revert cleanly.
        
        Change-Id: I9eb567bda59e3ad88ddfa370d04d5d8e1f944aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191741
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit a2ed9aa09ad8d2601cf6198c8cd8647c08f09c16)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191765
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-02  Balazs Varga  <balazs.varga@collabora.com>  [83f80f46bfec8e023727db2d87c22876a2ddf6bd]

        tdf#168589 - sc fix xls import with subtotal function
        
        Check if the trimmed data range of Subtotal double references
        is valid otherwise do not trim.
        
        regression after: b89047a0f0100fb30121084cf42815aa792c1f88
        (tdf#164843 - sc optimize "SubTotal" function's reference ranges)
        
        Change-Id: I5f1fa4f67a685deb4a391e19e3acd9849b03c1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191691
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191760

2025-10-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [58f7ecbcf486672bc5c1dddd25cd0097113a8d51]

        update credits
        
        Change-Id: Ice1c1887ada55c21b7a9d1af86bb5315a3f7f70a
        (cherry picked from commit a1911bbebc9fbd949f81755cb7148d53e13948ed)

2025-10-01  Jean-Pierre Ledure  <jp@ledure.be>  [1c81dbad870c2befad699e14e3694d684cf3064d]

        ScriptForge fix tdf#168409 AccessibleContext
        
        Extract from above bug report:
         The accessibility UNO API is unpublished and
         for LibreOffice-internal use only and
         subject to change by design.
        
        The com.sub.star.accessibility.AccessibleContext
        service is used in ScriptForge to determine
        the location on the screen, in pixels, of
        next window subsets:
        (1) a Calc cell or cellrange
            => calc.XRectangle(range) property
        (2) a toolbarbutton in a docked toolbar
            => toolbar.ToolbarButtons(buttonname) method
        In both situations, SF offers a facility
        to display a well-positioned popup menu
        triggered by a mouse left-  or right-click.
        
        The situation of the API is as follows:
        - fully available in 25.2
        - partially available in 25.8
          (1) is not broken
          (2) is broken
        - fully vanished in 26.2
        
        The gradual phase-out of the API requires,
        to fix the bug, a tiered adaptation of
        the code.
        The choice is made to incorporate, where
        appropriate, a switch to the right code
        snippet based on the run LibreOffice version:
        25.2, 25.8 or 26.2.
        
        Now the behaviours in 25.2 and 25.8 are
        identical. In 26.2, a different location
        is returned for undocked toolbars.
        
        The solution used for 26.2 must be considered
        as still subject to change.
        The emergency is to fix the issue in 25.8,
        which is currently broken.
        
        With the actual patch, the compatibility
        between releases is restored, both in
        Basic and Pythonuser scripts, and does
        not need any documentation revision.
        
        Change-Id: I29b4ccca3f11eca39e5a1841d3cfd744d5eb1fe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191670
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191708
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-10-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [a7f25c21ecb29817343a253866479adb93c57970]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to beabc8d706ba792b668024e5ba652feed42c5b28
          - update translations for 25.8.2 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I388f345814db612a19ae52c95614e9a2c12de901
            
2025-10-01  Jim Raykowski  <raykowj@gmail.com>  [dd72fd35bbe35798026f2f22189e34e57cf6d65c]

        tdf#167405 Fix outline folding crash
        
        In this case one that happens on folding outline content when the
        document view is set to 'Web' and the Navigator is open.
        
        SwDocShell::Broadcast(SfxHint(SfxHintId::DocChanged)) in
        SwRootFrame::CheckViewLayout causes an update of the Navigator content
        tracking which when SwWrtShell::GetContentAtPos is called in
        SwContentTree::Update eventually fails an assert in
        objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
        with the assert message:
        
        "SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame(..) -
        found frame isn't a layout frame"
        
        stack at crash:
        
        objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
          environmentofanchoredobject.cxx 91
        objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition
          tocntntanchoredobjectposition.cxx 287
        SwFlyAtContentFrame::MakeObjPosfly cnt.cxx 1522
        SwFlyFreeFrame::MakeAll flylay.cxx 222
        SwFlyAtContentFrame::MakeAll flycnt.cxx 413
        SwFrame::PrepareMake calcmove.cxx 396
        SwFrame::Calc trvlfrm.cxx 1858
        SwFlyFrame::Calc fly.cxx 3438
        SwFlyFrame::GetModelPositionForViewPoint trvlfrm.cxx 567
        (anonymous namespace)::lcl_GetModelPositionForViewPoint_Objects
          trvlfrm.cxx 87
        SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 208
        SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 477
        SwCursorShell::GetContentAtPos crstrvl.cxx 1519
        SwContentTree::UpdateTracking content.cxx 4779
        SwContentTree::TimerUpdate content.cxx 4668
        SwContentTree::Notify content.cxx 4046
        SfxBroadcaster::Broadcast SfxBroadcaster.cxx 43
        SwRootFrame::CheckViewLayout pagechg.cxx 2515
        SwFrame::AdjustNeighbourhood wsfrm.cxx 1816
        SwLayoutFrame::ShrinkFrame wsfrm.cxx 3020
        SwFrame::Shrink wsfrm.cxx 1635
        SwContentFrame::Cut wsfrm.cxx 1390
        SwContentNode::DelFrames node.cxx 1552
        SwWrtShell::MakeOutlineContentVisible wrtsh1.cxx 2649
        SwWrtShell::InvalidateOutlineContentVisibility wrtsh1.cxx 2703
        SwEditWin::ToggleOutlineContentVisibility edtwin.cxx 7135
        
        Fixed by waiting to paint until after removal of content frames during
        InvalidateOutlineContentVisibility.
        
        Change-Id: I69fdf173763211f42c5079069e79253ccdc19d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191576
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit c2ad58945c22bf7c8e77c70fc66af1faf998ac54)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191705
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-10-01  Patrick Luby  <guibmacdev@gmail.com>  [078f04ac171034e42003b219b41a7522093ec4f5]

        tdf#168609 catch exceptions from SwXText::getString()
        
        Apparently, implementions of XTextRange::getString()
        such as SwXText::getString() can throw an exception.
        
        Change-Id: Ie23651bbc36466ec95a037142f760dd59c7d6417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191645
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit b86c16870251877962e986ec9d1418e1f376241f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191695
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-30  Jim Raykowski  <raykowj@gmail.com>  [63765c15a10cf41123c31b917d7aa9358405456b]

        tdf#168560 Sidebar Find: Select text on keyboard focus in find entry box
        
        Like with the find entry box in the F&R dialog there is a bit of glitch
        when using gtk VCL when the find text is not selected and is click on it
        becomes selected and then not selected.
        
        Change-Id: I879f85b676d737d03c4bb02069f5d80f385d343d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191600
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit 4f33bb0f672a450ee5f2a4fd502398f2008fd7a8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191650
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-30  Pranam Lashkari  <lpranam@collabora.com>  [7e9ef9557da52b219e2c7ce500345510f9cbbc9c]

        tdf#156263: fixes freeze after opening data validity dialog
        
        after making dialog async ScValidationRegisteredDlg was destroyed while
        dialog is still running causing undefined behaviour
        
        regression caused by 63b26e8e20f6a4eeb3117925b7a727f565e3a2dc
        
        Change-Id: Idef30f12b88c46cb30a01ffb12588bb11e279750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191105
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191116
        Tested-by: Jenkins
        (cherry picked from commit ef7151c271d14f623759f87d30e452f2e6d66664)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191652
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-09-30  Mike Kaganski  <mike.kaganski@collabora.com>  [665379874b65e963b8ebc39623dc25ffe5510a3c]

        tdf#96787 tdf#168603 Skip primary language list, when country-specific found
        
        ... but don't skip the [All] (LANGUAGE_UNDETERMINED) list. See bug 141773
        and commits ae56dc05b27f05ffcee99845d661a237e70a7a51 (tdf#96787: AutoCorrect:
        after deleting a replacement entry, it's still used, 2021-01-10) and
        50be3fa1f0f3b8870af5bda88b65f835ef37d77e (tdf#141773 AutoCorrect: fix broken
        [All] dictionaries, 2024-06-29).
        
        A separate issue is that the languags list in autocorrect options now lists
        [Multiple] and [Undetermined], which shouldn't be there (the latter is the
        same as [All]). It needs an own bug and a separate fix.
        
        Change-Id: I1de8879c892efec23ce976b9e450088a22fdd652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191643
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit a25c152abb31db437eb306f358ae71ab73d2e6ba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191651
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Aron Budea  <aron.budea@collabora.com>  [bd61271f10181fe6540264273753551779d4ac8a]

        tdf#168598 Fix for tdf#148578 should only apply to RTF
        
        It also affected DOCX files witch compatibilityMode
        not specified.
        
        Regression from 788cc6ff3b186ceb8f265e53b5482f808f6536f4
        
        Change-Id: I1368066800ce4e6f4caa1131b1b6cf3590d8b1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191587
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit a80d7ba9c01c8c5c95bf01960d969b82dc7edffc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191625
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Jim Raykowski  <raykowj@gmail.com>  [6157d6838a8af0d24658ba5d62192a72a6e0edfe]

        Assure folded outline button does not remain after outline
        
        level direct formatting is cleared
        
        Without this patch the fold button remains and a crash occurs if the
        button is pressed. The patch also assures folded outline content is
        shown for outlines set by a style after the RES_PARATR_GRABBAG
        "OutlineContentVisibleAttr" is reset.
        
        Change-Id: I5ee19ec972c3084f3ba64c11bda32932141c81f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191526
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit 7ceb7a58e1bb1aca85435ded158fa2e19c004bf7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191618
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Dan Williams  <dan@ioncontrol.co>  [c7958ac67987a0418a0401fd51f10a8b3ea114f5]

        connectivity/macab: avoid errors due to missing contacts.notes entitlement
        
        Accessing an address book contact's Note field requires an entitlement since
        Mac OS 13. Without that entitlement the following error occurs:
        
        CoreData: error: Unhandled error occurred during faulting: Error Domain=NSCocoaErrorDomain Code=134092 "(null)"
        
        It seems unlikely that the Note field functionality is widely used for
        anything the address book functionality is used for, so just ignore the
        field entirely.
        
        Signed-off-by: Dan Williams <dan@ioncontrol.co>
        Change-Id: I694f3ac40a8dccb49f51818dcdb3da7948f560d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191057
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 15ee3a463768810b438d558533a3baca0700d690)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191290
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Khaled Hosny  <khaled@aliftype.com>  [f1e35b8ffd498b2d390f50ae9816fe0d9c904a49]

        tdf#168371: Disable ligatures in Impress/Draw with character spacing
        
        This is follow up to commit:
        
        commit b9f0caad5d9e628f82d5148dfc7d2436d32817e2
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Tue Aug 23 04:13:28 2022 +0200
        
            tdf#66819: Disable ligatures with character spacing
        
        Even though editengine was applying letter spacing, when drawing with
        drawinglayer, letter spacing was not propagated which caused VCL to not
        disable the ligature features.
        
        Change-Id: Ia8bf2231478720262484a757e16fe5afec3cd28e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191512
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191627

2025-09-29  Miklos Vajna  <vmiklos@collabora.com>  [92cc08867f025cd62419f92e26a4d717575ac116]

        tdf#166338 vcl: avoid unwanted downscale in DrawTransformedBitmapEx()
        
        Open the Impress bugdoc, the "Annotated result:" image's "red cable"
        bitmap is sharp in edit mode, but is blurry when presenting.
        
        This went wrong in commit 7c94d7267bc8b5f43185204ab4953c4b188214bf
        (tdf#149943 vcl: fix pixelated PDF export and print for a rotated image,
        2022-08-03), which stopped changing the scale part of the transform
        matrix. The old problem was that the transform resulted in a downscale:
        debug:5739:5739: OutputDevice::DrawTransformedBitmapEx: aOriginalScale w,h is 226,100, aFullScale is (906.698,6277.69) -> for w, we go from 906 to 226
        
        The new use-case is that this transform used to upscale in the past,
        which preserved more pixels from the original bitmap:
        debug:5632:5632: OutputDevice::DrawTransformedBitmapEx: aOriginalScale w,h is 326,1125, aFullScale is (21.1276,76.1197) -> for w, we go from 21 to 326
        Fix the problem by conditionally restore the change of the scale in the
        transform matrix: only do it when we would upscale. This was the
        presented bitmap is sharp again, but the old use-case continues to work.
        
        The deeper problem is why slideshow goes via a metafile at all, but
        that's not changed here.
        
        Change-Id: I73ef426dc9d047a0231a700b0fe7ed0e4747d81b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191497
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit e81b948f90e66779e225d0dfb5e3ad1e6e80f289)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191599
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Balazs Varga  <balazs.varga@collabora.com>  [161311deff7d1efaa7cca1f06b74df4d1b5f7efb]

        tdf#140866 - sc fix cell comments disappear after ods saving
        
        They disappeared because before saving the file to ods
        some other drawing objects very copied and pasted on the sheet
        which caused a recalculation of all the cell anchored drawing object's
        anchor position with SetCellAnchoredFromPosition since commit:
        545737df40880875304bffc3f49800d1d2e99723
        No need to recalculate the cell anchor position of Caption objects
        since their anchor position is handled differently.
        
        Change-Id: I83d54075974d9a7c2676af23f285e621afe0d523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191548
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit d932a383766b6133ffe9ebf077f95cc328807b1b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191608
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ecb65b032dc169cda9e5beed2d2a61ab47619bdb]

        tdf#168599: don't create Any from a direct reference to an interface
        
        An overlook from commit 3cb0678a9cac9a681903b5a082d1c5dd5f25f665
        (fix dodgy DrawController::fireChangeLayer code, 2025-03-05).
        
        This goes through this ctor:
        
          template <typename T>
          inline Any::Any( T const & value )
          {
              ::uno_type_any_construct(
                  this, const_cast<T *>(&value),
                  ::cppu::getTypeFavourUnsigned(&value).getTypeLibType(),
                  cpp_acquire );
          }
        
        which gets a valid type for the value (typelib_TypeClass_INTERFACE),
        and then uses a raw pointer in uno_type_any_construct. This crashes
        (0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFF)
        because _copyConstructAnyFromData assumes typelib_TypeClass_INTERFACE
        case to have a pointer to pointer (a pointer to css::uno::Reference,
        which is itseld a lone pointer), with this stack:
        
          sdlo.dll!com::sun::star::uno::cpp_acquire(void * pCppI) Line 47
          cppu3.dll!cppu::_acquire(void * p, void(*)(void *) acquire) Line 70
          cppu3.dll!cppu::_copyConstructAnyFromData(_uno_Any * pDestAny, void * pSource, _typelib_TypeDescriptionReference * pType, _typelib_TypeDescription * pTypeDescr, void(*)(void *) acquire, _uno_Mapping * mapping) Line 243
          cppu3.dll!cppu::_copyConstructAny(_uno_Any * pDestAny, void * pSource, _typelib_TypeDescriptionReference * pType, _typelib_TypeDescription * pTypeDescr, void(*)(void *) acquire, _uno_Mapping * mapping) Line 284
          cppu3.dll!uno_type_any_construct(_uno_Any * pDest, void * pSource, _typelib_TypeDescriptionReference * pType, void(*)(void *) acquire) Line 69
          sdlo.dll!com::sun::star::uno::Any::Any<com::sun::star::drawing::XLayer>(const com::sun::star::drawing::XLayer & value) Line 68
          sdlo.dll!sd::DrawController::fireChangeLayer(const com::sun::star::uno::Reference<com::sun::star::drawing::XLayer> & xNewLayer) Line 473
          sdlo.dll!sd::DrawViewShell::SetActiveTabLayerIndex(int nIndex) Line 635
          sdlo.dll!sd::FuPoor::SwitchLayer(long nOffset) Line 1060
          sdlo.dll!sd::FuPoor::KeyInput(const KeyEvent & rKEvt) Line 493
          sdlo.dll!sd::FuDraw::KeyInput(const KeyEvent & rKEvt) Line 432
          sdlo.dll!sd::FuSelection::KeyInput(const KeyEvent & rKEvt) Line 1056
          sdlo.dll!sd::ViewShell::KeyInput(const KeyEvent & rKEvt, sd::Window * pWin) Line 530
          sdlo.dll!sd::DrawViewShell::KeyInput(const KeyEvent & rKEvt, sd::Window * pWin) Line 252
          sdlo.dll!sd::Window::KeyInput(const KeyEvent & rKEvt) Line 226
          vcllo.dll!ImplHandleKey(vcl::Window * pWindow, NotifyEventType nSVEvent, unsigned short nKeyCode, unsigned short nCharCode, unsigned short nRepeat, bool bForward) Line 1236
          vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2742
          vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 310
          vclplug_winlo.dll!ImplHandleKeyMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, __int64 & rResult) Line 4011
          vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5925
          vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 6226
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!CallWindowProcW()
          opengl32.dll!wglWndProc()
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 431
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 500
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 537
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 389
          vcllo.dll!Application::Yield() Line 492
          vcllo.dll!Application::Execute() Line 365
          sofficeapp.dll!desktop::Desktop::Main() Line 1682
          vcllo.dll!ImplSVMain() Line 230
          vcllo.dll!SVMain() Line 249
          sofficeapp.dll!soffice_main() Line 122
          soffice.bin!sal_main() Line 51
          soffice.bin!main(int argc, char * * argv) Line 49
          soffice.bin!invoke_main() Line 79
          soffice.bin!__scrt_common_main_seh() Line 288
          soffice.bin!__scrt_common_main() Line 331
          soffice.bin!mainCRTStartup(void * __formal) Line 17
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        Change-Id: Ib61823e74b260d262adbaa5d3d63232b599d3cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191593
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 16a0b42a4f79a20a2aaf8dd443c55b81a8084351)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191607
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Oliver Specht  <oliver.specht@cib.de>  [fd25b527b3c03f20050aad763b8eb18982f018c0]

        tdf#167973 Fixes case rotation in selection in multiple paragraphs
        
        Broken in commit b1170251fbca5b6b243902cf10695ab4c4c5642b because it checked
        the selection in a single paragraph only.
        
        Change-Id: If84aca87c9fee5750751cd91cb08372714f17eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191472
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>
        (cherry picked from commit bb496f5494a23c247c86fdf5ae65054908df44ce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191601
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [3d7003a7c1010ba50cb6442f407d2560d9aaf26a]

        tdf#168569: support date values in string pool
        
        Commit f45463d8e2bb0771ec1837d159ff98108b0047cf (tdf#93727 Support date
        literals in basic, 2017-05-24) introduced correct parsing of literals
        like #2025-09-26#. However, it didn't retain the value type; there was
        a discussion about that in gerrit, but no solution was found, and type
        was set to double.
        
        Later, a similar problem (storing type of value in compiled image) was
        fixed in commit 5eedb3beeaeed88de0d1ebd041a9f15ceea7e78c (tdf#142460:
        properly handle boolean values in string pool, 2021-06-25).
        
        This change reuses the same method to store date type using 'd' char in
        the string pool.
        
        Change-Id: I32e8497ece1f30980ba6d4fca248687b817348f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191555
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 22d7827c6695358e11ee06a5599b72a92ff0b2ac)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191595
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [f846899e0b6fc2ec9ab2b4a4f65d06549e3f0763]

        tdf#168561: fix Str function implementation
        
        1. If a string is passed as argument, it is returned without any changes.
        For that, SbRtl_Str checks argument type, skipping processing for string.
        
        2. Non-negative numbers are preceded by a blank space.
        That already was implemented.
        
        3. Negative numbers are preceded by a minus sign.
        That was done incorrectly - a space was added for any number.
        
        4. Dates are converted into locale-dependent strings.
        That wasn't done at all - dates were converted to strings representing
        the serial date. A check is implemented SbxValue::Format, to handle this.
        
        Additionally, Format function was improved to handle such input without
        format string (taking into account that it handles strings that can be
        converted to numbers differently).
        
        Change-Id: I5ac0429950e4ea8bf69b0091502b4e6dc1f4957d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191549
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 92878d3216aeaf0e5131c0c3fa1f8dc9ce67b5b4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191582
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5442778d975c1a6146ce6ff0c66a13c64dcab904]

        tdf#166895 Document Colors do not appear anymore in the color selection
        
        missed a spot where we are using surrogate functionality.
        
        Also rename ForEachCharacterBrushItem->ForEachCharacterBackgroundBrushItem to make it more obvious.
        
        Regression from
        
          commit 56d35ad0eaccd353c8acd2a259293199e233e8ec
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Mon Sep 9 17:14:43 2024 +0200
          RES_CHRATR_HIGHLIGHT does not need surrogate support
        
        and
        
          commit 08c58ac51962b65b57c5b76a45467d45807ef02d
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Mon Sep 16 21:04:59 2024 +0200
          dont use GetItemSurrogates for gathering SvxColorItem
        
        and
        
          commit b6a5cdc0f753c8ed6ed080f9189ac2e2601dce9d
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Tue Sep 17 20:19:06 2024 +020
          dont use GetItemSurrogates for gathering SvxBrushItem
        
        Change-Id: Id67d78aa82f8731555f06b23760c4ea8f0d8eeb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191317
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 50099a54cd32afd361810e3059af3b420741d41b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191352
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-27  Jim Raykowski  <raykowj@gmail.com>  [758eebe416aa26e61a02fb491406ad225bf36e02]

        tdf#168025 Fix style spotlight numbers in styles list do not always
        
        match style spotlight numbers in document view
        
        This is a partial revert of commit
        b5e366c97d813c65d477941d45ae55f7dff954ad
        
        Change-Id: I016f8039d9b8e228afe26231a565679320c1f726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191373
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit 3967cdfe862dd4d542ae50cf16c46a62ab17cfa0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191411
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-27  Laurent Balland  <laurent.balland@mailo.fr>  [a5dc5761eedf7dc8e33fc9cd2a0817c682c7270d]

        tdf#168571 Restore gradient in Candy template
        
        draw:fill-gradient-name requires draw:fill="gradient"
        
        Change-Id: I3646b683486317e804adccb9faf994742fe1fb0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191562
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins
        (cherry picked from commit 771a93e3be34dfbd77b4dbba407caa9677090488)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191569
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ab3bd933fa7c482ee7b3a970fa2013ea9b1fc9d]

        liblangtag: upgrade to 0.6.8
        
        0001-const-up-__lt_localealias_tables.patch.1 has been fixed
        upstream
        
        Downloaded from https://gitlab.com/-/project/74684761/uploads/9f74bd278e6edfbf1093605d38fb7a97/liblangtag-0.6.8.tar.bz2
        
        Change-Id: I4b171d98271921c959115a8fabdf20217350be5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191445
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 9bb3947fadb83712492a156b3477d82f2280a3b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191450
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1522ce4e0f929c77d7ae26868a2e7c482e276926]

        harfbuzz: upgrade to 11.5.1
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.5.1/harfbuzz-11.5.1.tar.xz
        
        Change-Id: I714b790bb241a48d6ffcf81fbf23853221530d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191382
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 122ca4944587c485889fc1680dab43949f4d9dce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191389
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe4196a5858282e0059e8f5e31c71f22899520d9]

        libetonyek: upgrade to 0.1.13
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: I29556afa131f622652b4fbc5b46e0c3c0e5b1bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191333
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 7290daa1e12c5e81ed8c2909cdb6a164bfb3c478)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191351
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d076e078e1f6f1a5899eb9f442fbcec5c762bcb]

        libvisio: upgrade to 0.1.10
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: Ida45f447bdd49bf4ee600e0f24a7bf4eb5cb0bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191403
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 63887d9aaa252ee1b1b066831b28b53867a8c67f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191412
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [bd246c04e4245aa2a75700dd1687e75746d6deb3]

        tiff: upgrade to 4.7.1
        
        Downloaded from https://download.osgeo.org/libtiff/tiff-4.7.1.tar.xz
        
        Change-Id: I9eda3018e55e771986968ffacf7081538baf432b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191142
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit b3a027d2b7273478773bd0d8624b70f9a48b0952)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191162
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [73a58ecd58ebe3a7275bb99eb19fd82113d0237f]

        expat: upgrade to 2.7.3
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_3/expat-2.7.3.tar.xz
        
        Change-Id: I2141a3d2881e693867b23ca56a1d6a929f17c4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191481
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 3bceab5b951aa45bc7ab1d86ebcfda8981d9693f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191496
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-25  Jim Raykowski  <raykowj@gmail.com>  [5b9e275838ec1cd08f1c1755de545b4f7f34c7d1]

        tdf#166713 Fix crash in lcl_FoldedOutlineNodeEndOfParaSplit
        
        by handling the case of a paragraph outline level set by direct
        formatting.
        
        Change-Id: Ida0c8f91f0fb0584b39c16b3ddf2201429c6943f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191471
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        (cherry picked from commit fd9ae53e39f3219474461d1e8e3220d8efdfcecb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191482
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-25  Mike Kaganski  <mike.kaganski@collabora.com>  [8566b6167c5f788bf5849a461e4a52f66b6e3682]

        tdf#168533: make sure to emit frame properties, when they changed
        
        ... because of popping state.
        
        In the RTF markup:
        
          \pard\pvpara\phpara\posx3500\posy0\absw3800\wraparound
          Frame 2\par
          {\pard Still frame 2}\par
        
        the frame is created first: the frame properties are collected, m_bNeedPap
        is set to true, and the frame settings are pushed in checkNeedPap, called
        from RTFDocumentImpl::text() when "Frame 2" text arrives; that resets
        m_bNeedPap. When checkNeedPap is called from \par handler code, m_bNeedPap
        is false, and it bails out.
        
        Then opening brace creates a new state on the stack; \pard resets all the
        paragraph properties to default, including frame properties; then text
        "Still frame 2" arrives, calling checkNeedPap, which doesn't send frame
        properties, because there's none at this moment; it resets m_bNeedPap.
        Then closing brace pops the state from stack, returning to the state with
        the frame properties; and \par handler in RTFDocumentImpl::dispatchSymbol
        calls checkNeedPap. But at this point, m_bNeedPap was still false, so it
        bailed out, and didn't send the frame properties - so in the end, the
        current paragraph never obtained frame properties, and got imported into
        the main text flow.
        
        This change makes sure, that whenever popping the state changes the frame
        properties, m_bNeedPap is set, to ensure emitting it when time comes.
        
        Change-Id: I61b95e2818a66f54d7026db3cbb85e92135807c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191439
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 202d41e0fb2432ca286953d5f7464289fcb52e30)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191453
        Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>

2025-09-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [6061ce779980d538c5c844cb5a9421e659e48536]

        lxml: upgrade to 6.0.2
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-6.0.2/lxml-6.0.2.tar.gz
        
        Change-Id: If3a32f2c34fe7742ce83fdb8051616c97b9674f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191311
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 0453e8493e96c006a45a0accda26251531fd0eed)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191328
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-09-24  Balazs Varga  <balazs.varga@collabora.com>  [3e528101c3593eedaea492d03831630b03e933dd]

        tdf#167042 - sc cell comments texts should not be deleted
        
        but the note text should be remembered in maNoteData to be able
        to later reconstruct a caption from it.
        
        Originally the bPreserveData was introduced and set to true in commit:
        b8b657123cc508c906622d20669507628c93e104
        (tdf#104967 preserve isolated notes data in clipboard when closing document)
        The original bugdoc from tdf#104967 was checked with this patch and
        had no crash with it.
        
        Change-Id: I3b6c56e4828c11c2cab0351c95dd4bcb5762d86e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191396
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit 01765ffe843953bbf7d1e2822512306d3776b3be)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191461
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [79b1860c23ead30dd230768012db72075f4c11f5]

        tdf#168478 - Use the previously found range rather than returning an empty one
        
        During the reset of a standard filter, if the correct boundaries are not
        selected, do not return an empty range. Instead, reuse the previously
        found range at the selection.
        
        Change-Id: I42a603a8a284036710b608a519abd781b90991e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191245
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 6f68c46d0aa5fe872de0dec8777d35ff91886043)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191421
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa88c843765ba5562010018241727b43a3d338eb]

        libvisio: upgrade to 0.1.9
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: I7b588ca176024055486f41ddcec1394f5971f97e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191320
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 1ac9e00df08f52c884a858180a0b1c14788ad4b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191334

2025-09-23  Balazs Varga  <balazs.varga@collabora.com>  [465f423e4995c8ecb1e981db16d2c6b7c11c28ba]

        tdf#168422 - Fix SUMPRODUCT calculation is broken in some cases
        
        Double refs with operators only trimmable in case of one root paramater.
        
        Follow up of: 969ddf72824942be9755a8d14482d6549a2231ce
        
        regression after commit: 969ddf72824942be9755a8d14482d6549a2231ce
        
        Change-Id: I87365efc5b7bc54bfdda4d33e4b5b9550d6e2602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191365
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit 22c0eb18f5dcaa76d4fc7a65e98e1d20589ced04)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191379
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-22  Laurent Balland  <laurent.balland@mailo.fr>  [d1e0f1ca1d9bbb810018df753f9529d3044c2f59]

        tdf#168444 Fix XML in content.xml
        
        <office:text> tag is not present in other languages
        removing it fix the bug
        
        Change-Id: I2aeae0ba5d254f2b271557369c2d1faf3204c2c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191244
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191324

2025-09-22  Laurent Balland  <laurent.balland@mailo.fr>  [8b83439dc0cc270a1eb517d3efb652293f1fbce8]

        Indentation of XML files in AutoText
        
        apply xmllint -- format to all XML files
        This will ease debugging of XML, like tdf#168444
        
        Change-Id: Iacb79990e49236e13490524f77460ebb0fec1653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191241
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191323

2025-09-21  Patrick Luby  <guibmacdev@gmail.com>  [2dc604d5dc088dd80c8254bf5e2bddd5acac3bf7]

        tdf#168375 return false if both KEY_MOD1 and KEY_MOD2 are pressed
        
        Previously ImpEditEngine::IsSimpleCharInput() returned false only
        if one of these modifiers is pressed. At least on macOS, pressing
        Command-Option with a character is not a simple character so return
        false if both modifiers are pressed.
        
        Change-Id: I7698a1ec3178b83c0a1d4e161915246cac08f0ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit ed45cdaef3d2807d0b9d6a4c08da375fc72024a6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191209
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-21  Justin Luth  <jluth@mail.com>  [a6091a34e6adcd5780564f55abba40ffd279faa9]

        tdf#166406 sw nbb: position LTR and RTL side by side
        
        The worst thing to do to a bug
        is to mark it as an easy hack.
        That just means it will never be solved.
        
        With the increased push to spotlight the NBB,
        these papercuts should be solved ASAP
        instead of languishing forever.
        
        Change-Id: I8e5736add29b7db26ada0d671bc00b86d1c45fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191208
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 369b726d308270679b792aa21c92bd0b308ec171)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191217
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-20  Jean-Pierre Ledure  <jp@ledure.be>  [445d1ece2922bd6cf278b35c62cef9bb51879417]

        ScriptForge fix tdf#168433 array.ImportFromCSVFile
        
        The import of a CSV-formatted file
        into an array fails when specific
        combinations of double quotes and
        commas (= delimiter) are present.
        
        The
          array.ImportFromCSVFile()
        method uses internally the
          string.SplitNotQuoted()
        method for parsing the input
        records.
        
        The latter method skips the delimiters
        located inside quoted strings.
        It was buggy and needed a revision.
        
        Documentation unchanged.
        
        Change-Id: Ie156455b99749c6a8e4f43f4d3c258772904848f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191227
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        (cherry picked from commit cf57cf042aaa863ff6a730e79df1df1a5dbefc9e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191229

2025-09-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [e5f0dad2b38d2a3902a9cd6b9d434abc206590a4]

        tdf#168452: support unicode-bidi in svg
        
        Before this change, getBiDiStrong() was never used
        to manipulate the text
        
        Change-Id: I9d6a2e8b79d27126902f2be84174c641ec71c28c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191123
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit f127f708f6ccc941beabaacc7be18daf478a79cd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191133
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1c9a034783686f5b4bcbd29b4025d0a43d9a5c83]

        Resolves: tdf#156739 implement dnd for menu/toolbar customization pages
        
        dubious as a regression, but can be done now regardless
        
        Change-Id: I67bc322cd63e65b5347b3e54651e3618d09a99b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190917
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f4e2563012ff091ee27999713063fc87cd01fe7e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190958
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-19  Noel Grandin  <noelgrandin@gmail.com>  [d3def5d2894170c5832418b5008896c5ad3b82bf]

        tdf#166483 special char dialog not available with mergedlibs build
        
        Change-Id: I08cc1fe82845cfea82150e332b0ea0ad597f6cda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 9f4304ff2dbb706a1160afd347e538e615e1290f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191191
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-19  Mike Kaganski  <mike.kaganski@collabora.com>  [1c78cb0673e117136212fea7b51adcf898ff94f5]

        tdf#168431: Release solar mutex when sending window message to main thread
        
        It started after commit 1e2e51607a163021ef1fb1fb0d217266bd448173 for some
        reason, but the problem is, that the caller code from some thread holds
        the solar mutex, and the code that handles the message in main VCL thread
        tries to lock solar mutex; and that didn't change.
        
        This change introduces some methods in WinSalInstance, that wrap calls to
        SendMessageW, and release solar mutex if the functions are not in the main
        thread.
        
        Change-Id: Iac8690acbd306273c92534c6d319cbdf4b799860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191147
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191183

2025-09-19  Noel Grandin  <noelgrandin@gmail.com>  [7be45c419d98c4b68bdf359adedd3be6aafc2fcf]

        inline Init/ReleaseFrameGraphicsDC
        
        which makes it much more obvious which logic belongs where.
        
        Which fixes leaking WinSalGraphics objects on on error paths.
        
        Change-Id: Ib08c5b365e993d46fdc38a56e20e12c2833a1f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191182

2025-09-19  Noel Grandin  <noelgrandin@gmail.com>  [2a93939b3535c6790eb475aab436a188ca294d01]

        remove mnCacheDCInUse
        
        Windows95 has not been supported for some time, we don't need this
        limitation anymore.
        
        Change-Id: I52a476bb1da4db8fc8e7a420f049c3f895549fa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187891
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191181

2025-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef0fd8bfab009f939432eb7f24bc6604dcc90caf]

        tdf#168344, tdf#166842 do not use FillColor==COL_TRANSPARENT...
        
        .. on OutputDevice if that OutputDevice does not support alpha
        
        Change-Id: I52f8a496127462deecba9cf6fd19f827466d16cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 878dd795378776253e6c49d58805a219e0b8c33e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191135
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-18  Miklos Vajna  <vmiklos@collabora.com>  [1f6b2a4d6db61f0ae0f00774b3104cf679c3db4d]

        tdf#168325 sw format redline, char style: improve recording
        
        Create a new Writer document with a single word in it, set the Emphasis character
        style on it, enable redline record, change char style to Strong
        Emphasis, save to ODT. The format redline refers to an automatic style,
        while it should refer to the old char style (Emphasis).
        
        This happens because the redline record for format redline works
        incorrectly: it not only records the char style (before changing the
        char style), but also the expanded value of the char style, which leads
        to the creation of an automatic style on ODT export. This doesn't happen
        if exporting an originally DOCX file to ODT.
        
        Fix the problem by explicitly asking for the current character
        properties in a way so that char styles are not expanded, when making a
        copy of the old formatting & storing it in a format redline.
        
        Also drop storing RSIDs in format redlines, they are not interesting and
        again would lead to unwanted creation of automatic styles.
        
        Change-Id: Idd34afb1f0570589254a9eb259af4fc3465aec22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191120
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 0c7eaa023a840a6f0967fe119463a936241a8130)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191138
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-18  Justin Luth  <jluth@mail.com>  [d24e8a20907bf3e861dad93456d0dea891c3b320]

        tdf#168377 sw: avoid crash in redlndlg - index out of range
        
        Everywhere else GetRedlinePos() is used
        it is checked against SwRedlineTable::npos
        to identify a valid index position.
        
        Change-Id: I46a52a9c7aadab4b1690562c0ba32027cd2dcd2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191121
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit c920581dc81e553a07d0cd27f5d218df39811b6d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191137
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-18  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [78373e24f4144df9c28e485e89dc86144752719c]

        Resolves tdf#168259 - Add "Show Again" checkbox to SaveAs query
        
        This backport also includes the follow-up commit
            Resolves tdf#168259 - Hide "Show Again" if readonly
        
        Change-Id: I60b034d43bfe7069319b6dc70b0b9e00cc5e1e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190553
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191158
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-09-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6cc399f63684da0967bd95f9678447110c00f15a]

        bump product version to 25.8.3.0.0+
        
        Change-Id: Iebaee6564dde714612e124d06c24225cf87f9384

2025-09-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c316dc790dc64dfd5d82774dd1f66574219bfaed]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 234344c9b22893272b6be8e30e6fb556a6d9e664
          - update translations for 25.8.2 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Ia769c987fe3a86ccccf9c46be051dcae1a1221e2
            
2025-09-17  Julien Nabet  <serval2412@yahoo.fr>  [cb8bf48260a43895cbb5b1c51e13ce9cdf53e69b]

        Related tdf#168265: ignore more comments line
        
        1) since 999 indicates a comment section, call DXFSkipLine in case of 999
        2) let's consider the case the beginning contains more than 1 comment
        
        Limit: we only sniff 256 bytes to detect the format so if comments are too long
        detection won't work
        
        Change-Id: I11a01db49d3faad68c7ab134be0f716767583185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190865
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit 829f59de4e44a5a2c9888e7ceef439809808f2c0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190870
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Patrick Luby  <guibmacdev@gmail.com>  [87f4a7b3838b6dc5bb740884b9e5132fb98e54f2]

        Fix HarfBuzz build breakage when building on macOS Tahoe
        
        Starting in Xcode 26, compiling with -D_LIBCPP_ENABLE_ASSERTIONS will
        fail due to a change made by Apple.
        
        HarfBuzz uses meson to define the macros needed to build HarfBuzz
        and meson 1.7.2 and 1.8.0 still emit -D_LIBCPP_ENABLE_ASSERTIONS.
        So upgrade the internal meson to 1.8.3 (i.e. the first version that
        is compatible with Xcode 26) and use the internal meson if building
        with Xcode 26 or higher and the external meson version is too old.
        
        Change-Id: I0d3545b0b1a22156179fec1382260adca1e9221c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188863
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 26c44f98d0ab203090d5b634853ec1177b6d1977)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190770

2025-09-17  Jonathan Clark  <jonathan@libreoffice.org>  [2ef84ee2e6856b5a4729f0f59f8c02f2e1106e9d]

        tdf#168424 editeng: Fix unsafe s/uint implicit cast in RTF parser
        
        The editeng RTF parser was round-tripping signed integers through a
        sal_uInt16 via implicit casts when populating SvxLRSpaceItem. This
        worked because such an implicit cast may convert signed numbers into
        their unsigned two's complement representation, and vice-versa.
        
        Unfortunately, a recent change to SvxLRSpaceItem replaced the final
        implicit uint-to-sint cast with an implicit uint-to-double one, which
        does not have the same properties.
        
        Change-Id: I80b1a36c47323309b33a8ddaee652c238a7530f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191052
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit c93d70db199cc7f89490cf9f34aa43ea67892c52)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191100
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [72dbdf4f967770e790ab31cb1b22b70686c61993]

        tdf#168423: Allow subnormals from strtod
        
        dtoa sets ERANGE with subnormals. We need to support these, so check
        for infinity and zero explicitly, and allow other results. NaNs can't
        appear here.
        
        Change-Id: I006a42ebff03b07d219b423c13bf8230348e1def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191071
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit a3aaa11db039675252fe9d5bc4a9d43be34940e8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191093
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-17  Dan Williams  <dan@ioncontrol.co>  [bc60c90e73b2e8d3c0bdfe6dad087ea5e51ac240]

        connectivity/macab: use CoreFoundation instead of Carbon
        
        The Mac address book connector doesn't actually use Carbon,
        so just import/link to CoreFoundation.
        
        Signed-off-by: Dan Williams <dan@ioncontrol.co>
        Change-Id: I17f42ba6a9355d45ed5c7c60214cb50d803ffbc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191051
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit 4dc20af89779241eeae85f61b32a9b1d85c6da3e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191094
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Dan Williams  <dan@ioncontrol.co>  [dec1441f716c7631622b9b3e32fdbc666502c006]

        vcl/sal: remove unecessary Mac OS includes and linkage to Carbon
        
        A number of places that #include <Carbon/Carbon.h> don't actually
        need it, but want CoreFoundation or other includes instead. We're
        trying to get rid of Carbon so let's make it clearer what really
        needs it still.
        
        Change-Id: Ief60b4324dccd936aa7def3ea2c685c393f9050a
        Signed-off-by: Dan Williams <dan@ioncontrol.co>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191030
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit db3d15e46324ef4fcb9aee0b760f923f9a4fa231)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191098
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [f374a9821b22e900ef6b05d652e4f2b0786b42dd]

        harfbuzz: upgrade to 11.5.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.5.0/harfbuzz-11.5.0.tar.xz
        
        Change-Id: I73db5e0de6c78898a8cca957c203b6e5961271c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190950
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c301b1e14bd5854f12b6b8ad2bed5ff7dd1d5821)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190957
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [48b650d50070cd1bff391aef53f781c16899d92d]

        sd: use SAL_RET_MAYBENULL in GetSlideSorter
        
        Change-Id: I2f71942aeaa7aa1cc78be69d63a94588099ad4d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190821
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190877
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b8479d71863b015d0d8bcbd292791f07857b2fa]

        tdf#168363: check SlideSorterViewShell
        
        After
        commit 7dddd449068d69ec2f47bfca2487f01fa7067fd0
        Author: Pranam Lashkari <lpranam@collabora.com>
        Date:   Tue Apr 15 21:19:43 2025 +0530
        
            sd: copy slides from instance to another
        
        Change-Id: I77a315981c0178144c985b29b4ebb733e42bd000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190820
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit fd10eb45fdb95f2fc3386ef7ee1423279d764ac3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190824
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d3eb682d30c4e7e37bc844109746b711343f025]

        mariadb-connector-c: upgrade to 3.3.17
        
        c23.patch.0 has been fixed upstream
        
        Downloaded from https://dlm.mariadb.com/4441363/Connectors/c/connector-c-3.3.17/mariadb-connector-c-3.3.17-src.tar.gz
        
        Change-Id: Idf813aa383f22b8ae22ac92e23fc0ffa78050f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190795
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190808
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [03a4361a7685ba2e104704c92ab09cc1b9cc648e]

        curl: patch CVE-2025-9086 and CVE-2025-10148
        
        More info in https://curl.se/docs/CVE-2025-9086.html
        and https://curl.se/docs/CVE-2025-10148.html
        
        Change-Id: Ib4993a00efdabf0baa3fe0e25c66d850f370572a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190741
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190751
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Julien Nabet  <serval2412@yahoo.fr>  [fc1b29c610274e636f317e36e4d8d39b16c54185]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 5ea29a8c84b5c4607092f92bf4c97106e1e6e2d0
          - tdf#167789: fix date format for COUPPCD result
            
            Change-Id: I8a131751ad4e329834b3a97d30fbbf46c317e4cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/188871
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            (cherry picked from commit 7db5e16a2bd98ea0c1cd4d9cbe1a00cf715461a8)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/190727
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [38b6906b5cd044cfd6f4ef594848f0a1f9952ee1]

        crashreport: avoid crash in InspectorTextPanel
        
        define FN_HIGHLIGHT_CHAR_DF in sfx2 like the
        other spotlight slots and rename it accordingly
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/a6200006-147e-4829-9293-93de0487133b
        
        Since
        commit 0d0e5c72e6344de48227b74846a6ff638b803c64
        Author: Karthik <me@karthikreddy.org>
        Date:   Mon Mar 10 13:34:39 2025 +0530
        
            tdf#160194 Add 3 checkboxes in Style InspectorPanel
        
        
        Change-Id: I108fcbf39c8f6879258c9804f7f5a15313d259ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190684
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 6fc54eea2f904a6704495f6b53fd5eff0dff1496)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190721
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5005923f103123a089ce24103cbe7b6d4627bac]

        expat: upgrade to 2.7.2
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_2/expat-2.7.2.tar.xz
        
        Change-Id: Icf4b730291dfecc039024360b36c2fe8adb247fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191047
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 953f1da9270dc10d4aa7852a91e22e4483751aba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191054
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [82975b83ecdac9256ee52bcd42b5cd394f8cb384]

        nss: upgrade to 3.116
        
        0001-Bug-1983399-lib-softtoken-sdb.c-sftkdbti.h-Align-sft.patch.1 has
        been fixed upstream
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_116_RTM/src/nss-3.116-with-nspr-4.37.tar.gz
        
        Change-Id: I61f7efe779c89ca00e6698dd834cf282ea43f5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190960
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c46712bcd7a6f811aa406f2db97d94d3d1b67350)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190969
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-09-17  Stephan Bergmann  <stephan.bergmann@collabora.com>  [fb9337d51a3988f9b09aaca567b205a6917b9b4e]

        external/freetype: Avoid signed-integer-overflow
        
        ...presumably after 981d8be918a7002ef4239244c8524dc73f0b5fd8 "freetype: upgrade
        to 2.14.1", causing e.g. CppunitTest_chart2_pivot_chart_test to fail with
        
        > workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:3708:31: runtime error: signed integer overflow: 2161 - -9223372036854775808 cannot be represented in type 'FT_Pos' (aka 'long')
        >  #0 in af_glyph_hints_apply_vertical_separation_adjustments at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:3708:31
        >  #1 in af_latin_hints_apply at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:5054:9
        >  #2 in af_loader_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afloader.c:411:17
        >  #3 in af_autofitter_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afmodule.c:498:13
        >  #4 in FT_Load_Glyph at workdir/UnpackedTarball/freetype/src/base/ftobjs.c:1055:19
        >  #5  at <null> (/lib64/libcairo.so.2 +0x9be4b)
        >  #6  at <null> (/lib64/libcairo.so.2 +0xa0df1)
        >  #7  at <null> (/lib64/libcairo.so.2 +0x528b6)
        >  #8  at <null> (/lib64/libcairo.so.2 +0x57184)
        >  #9  at <null> (/lib64/libcairo.so.2 +0x179f6)
        >  #10  at <null> (/lib64/libcairo.so.2 +0x1a5f7)
        >  #11  at <null> (/lib64/libcairo.so.2 +0x27459)
        >  #12  at <null> (/lib64/libcairo.so.2 +0x701c8)
        >  #13  at <null> (/lib64/libcairo.so.2 +0x22a8b)
        >  #14 in cairo_show_glyphs at <null> (/lib64/libcairo.so.2 +0x78a7d)
        >  #15 in CairoTextRender::ImplDrawTextLayout(_cairo*, Color const&, GenericSalLayout const&, CairoCommon*, bool) at vcl/unx/generic/gdi/cairotextrender.cxx:517:9
        >  #16 in CairoTextRender::DrawTextLayout(GenericSalLayout const&, SalGraphics const&) at vcl/unx/generic/gdi/cairotextrender.cxx:292:5
        >  #17 in SvpSalGraphics::DrawTextLayout(GenericSalLayout const&) at vcl/headless/svptext.cxx:74:23
        >  #18 in GenericSalLayout::DrawText(SalGraphics&) const at vcl/source/gdi/CommonSalLayout.cxx:314:18
        >  #19 in OutputDevice::ImplDrawTextDirect(SalLayout&, bool) at vcl/source/outdev/text.cxx:311:16
        >  #20 in OutputDevice::ImplDrawText(SalLayout&) at vcl/source/outdev/text.cxx:464:9
        >  #21 in OutputDevice::DrawTextArray(Point const&, rtl::OUString const&, std::span<double const, 18446744073709551615ul>, std::span<unsigned char const, 18446744073709551615ul>, int, int, SalLayoutFlags, SalLayoutGlyphs const*) at vcl/source/outdev/text.cxx:750:9
        >  #22 in ScOutputData::LayoutStringsImpl(bool, RowInfo*, short, int, unsigned long, std::optional<short>&, std::optional<short>&, short, std::__debug::vector<std::unique_ptr<ScPatternAttr, std::default_delete<ScPatternAttr>>, std::allocator<std::unique_ptr<ScPatternAttr, std::default_delete<ScPatternAttr>>>>&, ScPatternAttr const*&, SfxItemSet const*&, SvtScriptType&, ScDrawStringsVars&, bool&, long, long, bool, bool&, vcl::PDFExtOutDevData*, long, std::__debug::vector<double, std::allocator<double>>&) at sc/source/ui/view/output2.cxx:2248:28
        >  #23 in ScOutputData::LayoutStrings(bool) at sc/source/ui/view/output2.cxx:1565:17
        >  #24 in ScOutputData::DrawStrings(bool) at sc/source/ui/view/output2.cxx:1487:5
        >  #25 in ScPrintFunc::DrawToDev(ScDocument&, OutputDevice*, double, tools::Rectangle const&, ScViewData&, bool) at sc/source/ui/view/printfun.cxx:604:17
        >  #26 in ScDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short, bool) at sc/source/ui/docshell/docsh4.cxx:2656:9
        >  #27 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:204:5
        >  #28 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:151:9
        >  #29 in SfxObjectShell::CreatePreview_Impl(bool, bool, VirtualDevice*, GDIMetaFile*) const at sfx2/source/doc/objcont.cxx:201:40
        >  #30 in SfxObjectShell::GetPreviewBitmap() const at sfx2/source/doc/objcont.cxx:113:9
        >  #31 in SfxObjectShell::WriteThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::io::XStream> const&) at sfx2/source/doc/objstor.cxx:4157:29
        >  #32 in SfxObjectShell::GenerateAndStoreThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) at sfx2/source/doc/objstor.cxx:4112:33
        >  #33 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1839:19
        >  #34 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:3421:39
        >  #35 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:3212:9
        >  #36 in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t>>, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objserv.cxx:323:19
        >  #37 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3253:42
        >  #38 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1834:13
        >  #39 in UnoApiTest::saveWithParams(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:194:16
        >  #40 in UnoApiTest::save(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:178:5
        >  #41 in UnoApiTest::saveAndReload(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:199:5
        >  #42 in PivotChartTest::testRoundtrip() at chart2/qa/extras/PivotChartTest.cxx:354:5
        
        Change-Id: I6bb42532fce1291b4208108ab1898b94dda02e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191043
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit a8133d29ce58ab775319e837477c649489182d6d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191064
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb9d1f33d7ab595c67fe68c69993923cd006c8fb]

        freetype: upgrade to 2.14.1
        
        Downloaded from
        https://sourceforge.net/projects/freetype/files/freetype2/2.14.1/freetype-2.14.1.tar.xz/download
        
        Change-Id: I278d52399dbfe1e0895e481417dda493d35aeefa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190826
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 981d8be918a7002ef4239244c8524dc73f0b5fd8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190837
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [7de70bdfeb70075800535bdf173941ba8e5cdc38]

        tdf#168378: invert text anchor in RTL
        
        Change-Id: Ia9b7e526ab20cbcdb521f965a5a2dc0726894209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191018
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191031
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae88cf4bc2b69282509128663f54e8c836e15c01]

        tdf#168421: support RTL text direction in svg
        
        Change-Id: Iba8853d131bf88be3cc94003a73ffe545cf62004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190978
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 4efae74abc8e7cefe2d7d0c3c55653dc269b8727)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191004
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a0ec84c050855840f7a829dd7fe6e56fd72d960a]

        tdf#165846 - Ensure degrees of freedom (nu value) is greater than 0
        
        Change-Id: I900d0b5436bc9417e4f91eac1434c8ae79bd70a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190988
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins
        (cherry picked from commit dedaf2a87bca8b903fc42f441c7185921cf03312)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191048
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-17  Laurent Balland  <laurent.balland@mailo.fr>  [a2ca00636df4f3a709b061ce66fdd0b68a5ac62e]

        tdf#168318 Revert "Rezing SdrObject: Remove duplicate code"
        
        This reverts commit edd0991c3cc1c5ae439e33873c2567ee62d0e710.
        
        Reason for revert: unexpected behavior for rotated object (see tdf#168318)
        
        Change-Id: Ie83c8d35dba12ff7eca7429efb0ff195eacd205b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191041
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        (cherry picked from commit 183941f9e0668b0963e0157f2d9c414b58741fd6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191053
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [91b8c95717f343a47170d0316d46c5707905b7fc]

        cid#1665431 Dereference null return value
        
        Change-Id: Icba6d8bdc8f07c8125c7c4784f93c19dd7d1bd7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191000
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 33f5ab817202b06af061ee3866f3b4013bdbcd27)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191027
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-15  Michael Stahl  <michael.stahl@collabora.com>  [4666d701312615b43e698f67e3443dc1a13dcf20]

        sw: PDF export: fix crash on section in table in section
        
        soffice.bin: vcl/source/gdi/pdfextoutdevdata.cxx:798: void vcl::PDFExtOutDevData::EndStructureElement(): Assertion `mpGlobalSyncData->mCurrentStructElement != 0' failed.
        
        The problem is that the parent-opening code in
        SwTaggedPDFHelper::BeginBlockStructureElements() when called for a
        section in a table cell opens a section that is outside the table.
        
        In this case, there are actually 2 section frames, one containing the
        table and one in the table cell, so reopening the outer section frame
        that is already on the stack ends up restoring a 0 parent SE and that
        triggers the assert.
        
        (regression from commit d5f68529a79c615f989fcfeef248d887a6e10f5a)
        
        Change-Id: Idd5be655345f96e1c2de84c5623f6e1dba4aae1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190781
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 7a036a64581a96a05e4833611801ac304d75524f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190817
        Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>

2025-09-15  Jonathan Clark  <jonathan@libreoffice.org>  [6c35c61ff2e1ae0b238fbf578aff1188ba18dbf4]

        tdf#167873 i18npool: Port CJ brkitr customizations from ICU upstream
        
        Upstream ICU includes non-standard rule extensions for Chinese and
        Japanese, which add line breaking opportunities between U+201C/U+201D
        double quotation marks and leading/trailing CJK ideographs. This change
        backports those rule customizations, for correct layout of Simplified
        Chinese.
        
        Regression from:
        
            commit 5a03d511f46ecc05aab35bb29e714b46f5638b1b
            Author: Jonathan Clark <jonathan@libreoffice.org>
            Date:   Mon Apr 7 21:37:26 2025 -0600
            tdf#130592 i18npool: Fix incorrect line breaking in mixed CJK+Latin
        
        Change-Id: I3cf6c0cd23e38f9a89c98fdd6c6f665f175b676c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190904
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 01c934f7bc6ecc18d7efcbcfb1f58f05ebda3bef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190947
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [26e4e0393b1cce113a3a20436f77a6eb0ef8b350]

        Related: tdf#168355 Optimize the fix
        
        Inspired by the code I found in sw::HasPageBreakBefore, the change
        finds the frame that may provide the page description information
        once.
        
        Change-Id: Ie16b93d97e5a32e2991d68aa9c605fc0a411c1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit a11d059702b349f2ca520414b73785b127e8837a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190902
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f8aa0ff0e7eb08d5822858688dc525ec0201b09e]

        Resolves: tdf#168306 set current line width at popup time
        
        Change-Id: I82c8151566459d1429cd3b4517b43ace3fbeca60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 830a06afe26279edc3527ccdecb5c9e2b347cfd5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190935
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Miklos Vajna  <vmiklos@collabora.com>  [6de684d777ccfb2a1b6f43081ca7fb53115e21d0]

        tdf#168321 sw format redline, direct: fix ODF strict export
        
        Save the bugdoc in strict ODF, the exporter crashes due to an assertion
        failure.
        
        What happens is that strict ODF doesn't add the loext namespace alias to
        the alias list, so we crash when we would write an loext attribute.
        
        Fix the problem by simply throwing away the direct format of a format
        redline when saving to strict ODF, just to please the validator.
        
        If we're at it, also don't register the direct format of the format
        redline in the autostyle pool in that case, since it would be
        unreferenced anyway.
        
        Change-Id: I0de9ee114be9ef67f97716cf5fd9aaa9f8757683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190851
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 5248afb9b630b5902936ea8a2f5c87248cb36dd3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190871
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Jonathan Clark  <jonathan@libreoffice.org>  [01c95615899fbcf33b49b2833e709dec9de71632]

        tdf#168263 editeng: Fix wrong max ascent for text without ruby
        
        Editeng must adjust the maximum ascent of lines to accommodate ruby
        characters. This adjustment is only necessary when ruby characters are
        actually used, and the intention was to only apply the adjustment in
        that case. Unfortunately, due to an implementation error, this
        adjustment was instead performed for any line containing formatting.
        
        Change-Id: Ibd4ea3cda8b40c95f41f1d84b47155455a20a1cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190784
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit f166009a3b62e680c993d033a97e4a24a65ceaa1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190846
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [1860380514437f4115abdd5fa2a5138a40c10f6d]

        Use a bit more standard null date in lcl_normalizeDateTime
        
        This value is only used for dates comparison inside ODateTimeType;
        _getValue is used in OValueLimitedType_Base::_validate to comnpare
        to minimal and maximal cached values, and the latter are set using
        normalizeValue. The choice of null date is ~random, and in theory,
        we could just normalize using Date::GetAsNormalizedDays(), but the
        null date close enough to the actual dates has an upside of keepng
        enough precision for time part - so just use the most used epoch,
        which gives an optimized GetAsNormalizedDays, and hence, a faster
        operator-.
        
        Change-Id: I35723373107b2786633c7ddb3cfb82a7dcc4deaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190827
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 89b0b449d8f64aef0a15fe9d1485061a91da7150)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190859
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [8560e494a2263fdddb648073601b9e409556e76e]

        Use a bit more standard null date
        
        The two places in cellvalueconversion.cxx using the null date were
        introduced in commit a7e949673cda3f0e2abfa49b2c22735f33205d01
        (gridfixes: #i117265# use a NumberFormatter for converting cell
        values to text., 2012-09-14); they are used together, so that the
        code in lcl_convertDateToDays uses the same epoch as defined in
        the respective number formatter, and the obtained number value is
        only ever used inside convertToString in a call to the formatter's
        convertNumberToString. The old value was arbitrary; and the new
        value has some optimizations in the code (see Date::DateToDays and
        comphelper::date::convertDateToDaysNormalizing called from it).
        
        Change-Id: I9c050d26ace1cf3fccde579d0d91c00f26bb3fd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190788
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit c6af3d93b6f2603f7ea6c898742876198ca557e1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190858
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [38f5d984658c42c6d69b658d623bbeb64a94ce23]

        tdf#168355 Page break with page style with page number in table
        
        regression from
            commit 7d924018f3ea58050081936bde067391714a8bb5
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jul 19 10:44:10 2024 +0200
            don't use GetItemSurrogates in SwFrame::GetVirtPageNum
        
        Change-Id: Ibdc223842013ad11b56f402571f276de38a01f6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 46720a15474c6c6cfbbb78ff15b446fbd004120c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190855
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-12  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [be9d6e414e4b38dba5897a78d883e92d64b701bd]

        tdf#159306 WMF/EMF Fix PS_COSMETIC lines display
        
        Change-Id: I3a2572a76aae61bcf8552e4623168cd72411373a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190816
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit b33cc5a7388c1739ff4a02a84751800f3e3086ce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190845
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-11  Justin Luth  <jluth@mail.com>  [abdfd11e6b0dc814190e13a24bb78479a871aca2]

        tdf#142785 stashedFooter: fix copy/paste error
        
        Change-Id: I1455420a9bc8566648aee8972b47e0408e1255da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190811
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 0bcce63a97e0d51638746267e11c7a8f4936c9e2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190819
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-11  Andras Timar  <andras.timar@collabora.com>  [828197667b78b3b4e4b332d22832ace26a75de56]

        Fix git hash link in About box
        
        Change-Id: Ieccb41f3ca9909c452101883d4c295815ee9d185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184820
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ca33fc45edbc9e7f330f14513c53f83c73e78835)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188429
        Reviewed-by: guilhem <guilhem@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: guilhem <guilhem@libreoffice.org>
        (cherry picked from commit 680b8eca27d6e3a160a147caf8314a81c430c7b7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190789
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [8eeb11aba618d6333b254b05749bba9d6235827f]

        tdf#168252: fix "standard" date in SwDBField::FormatValue
        
        ... after commit 5b808448dc79e996efa7cb5082145d4e5803daa6 (Related:
        tdf#167591 Make STANDARD_DB_DATE more standard, 2025-07-21).
        
        Change-Id: I3bbe87c77aafb44cf53bc43613eeb3eb975b42f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190749
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 92f0eeef847bb8c980aef1760c3355df0e2e11ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190777
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [40f481b9c4d3cdcb5621002064ac89578ed6dece]

        tdf#168347: fix "standard" date in SwInsertDBColAutoPilot::DataToDoc (1)
        
        This fixes DB_Column::Type::COL_TEXT case.
        
        Change-Id: I2b758000b49ae8d1729f3ce61b066f5d0eeb434b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190756
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit cda403f39b5db9074917819e60a2e16744136c11)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190778
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9b34799cb351ad1d6e8567ce4a8f6e99006e7fb3]

        tdf#168349: fix "standard" date in SwInsertDBColAutoPilot::DataToDoc (3)
        
        This fixes bAsTable case.
        
        Change-Id: I48febf1def0198b9a7275fe4167e19287a0d1e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190758
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 24b2d4d00c8ed5cfc1d16000dd8a0048271e9c22)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190780
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [5968a8dea226aa5c23dcad5cccfbd41eac241e6e]

        tdf#168348: fix "standard" date in SwInsertDBColAutoPilot::DataToDoc (2)
        
        This fixes DB_Column::Type::COL_FIELD case.
        
        Change-Id: I1566f69bb38a2fda9a0c0c48d8662b7b4ddf3682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190757
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit d85d3c3c7ccced49e1f2d3d6c754310a1d44fefe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190779
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [f85cea0eaf76993cada69db255b76330e610e8df]

        poppler: upgrade to 25.09.1
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.09.1.tar.xz
        
        Change-Id: I665369d8e942af1ad81dad9368c5ba6e3e5fe4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190663
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 0563d0e3581b5029cfe9476d5b5313d6322c5e08)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190675
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [76c46996977814f5f0b2d5621d21740cf32b22a1]

        libatomic_ops: upgrade to 7.8.4
        
        Downloaded from https://github.com/bdwgc/libatomic_ops/releases/download/v7.8.4/libatomic_ops-7.8.4.tar.gz
        
        Change-Id: If970693689dd488b2e794582ccfaffcc97388c3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190672
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 7ca639f67bbf1c953b8e81d5e59c031fd4bb007d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190676
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [421f29ea481b5b75ddbb4fe4385cb20172d68f16]

        libxml2: upgrade to 2.14.6
        
        9de92ed78d8495527c5d7a4d0cc76c1f83768195.patch.1 has been fixed upstream
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.14/libxml2-2.14.6.tar.xz
        
        Change-Id: Ibfd34613bc74644830b2e45c32c16462e7c7bd32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190720
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 5e9caecd24636664d3de0a1eff06df540aa70fc4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190722
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-10  Michael Stahl  <michael.stahl@collabora.com>  [9e13361a61d773caff45b99301df771ea76d545a]

        tdf#166319 schema: limit change nesting to what is actually supported
        
        Change-Id: Ie574377ea9cdd90ed9261229abaca480b4010440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190738
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e21f78274d9620b05f43a520b3922a375b271a12)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190771
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-10  Julien Nabet  <serval2412@yahoo.fr>  [5389294d747f8ca3d964f126cab627eb89c4ec91]

        Related tdf#168265: fix DXFGroupReader::ReadF
        
        Change-Id: I9a316a2b01b7726e679cecb0121e650ee49d6ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190646
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit 1d6298f1c64a8ba6c6634335960d2b247d0d2f30)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190652
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-10  Julien Nabet  <serval2412@yahoo.fr>  [f9eacf3d535e3dac7c1f30a5f74f4ff7a77a94be]

        tdf#168265: pass comment (999) section to detect dxf file
        
        Change-Id: I6d54e4dcc578792bd122e24743f41c0049974a2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190632
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit b5044aa84af207dc44944c9ad51847b50e7f43b1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190653
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-10  Miklos Vajna  <vmiklos@collabora.com>  [e1e36df4fc2e7b8aaca82bbb00cfb9a414b0385a]

        tdf#167761 sw format redline, char style+direct: add ODT import
        
        Open the bugdoc, it contains a format redline that changes the character
        style from Strong to Quote and the font size from 24 to 36. Revert the
        redline, the char style goes back to Strong, but the font size is 12,
        not 24.
        
        The problem is that only the char style was imported in
        XMLRedlineImportHelper::InsertIntoDocument(), because direct formatting
        is only handled when we have no char style.
        
        Fix the problem by creating an empty item set earlier, similar to how
        lcl_SetRedline() does it in the UI code, then both the char style and
        direct format can go into that item set.
        
        The format redline's ODT/DOCX filter is now in a reasonable shape with
        this.
        
        Change-Id: I28e2a43e218a319045649612e7492821e72649b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190551
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit bbebb3908ff9a9c384a475737ead537906517387)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190556
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a9f2c97b50ea9a09b36c7017f24ec44e7179d9bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 3c31af841dcf3e598e298fd732e0dbef68f0f6ec
          - tdf#164395 Fix bookmarks in Appearance Help page
            
            Change-Id: I1b9c5a6de2a92f015fa4cb7af805dda5ebc8d4c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/190647
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            (cherry picked from commit 90b899e2b244457140c9084f69bd930a14715f27)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/190648
            Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [9cf9b26992d6fbf8f9090666145f929b950feae1]

        freetype: upgrade to 2.14.0
        
        Downloaded from
        https://sourceforge.net/projects/freetype/files/freetype2/2.14.0/freetype-2.14.0.tar.xz/download
        
        Change-Id: If11ce5186689702496754b4668fedbaed14ab287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190660
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit b732868bd612d3b046ab395d9db69b5d92b6f984)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190666
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-08  Samuel Mehrbrodt  <samuel.mehrbrodt@collabora.com>  [b51bf2b747533f540e9fbb746096d52cea182e1e]

        tdf#167897 Fix save/export directory preselection with empty user profile
        
        In the case of an empty user profile, the logic to display
        the correct directory was twisted.
        
        This also reverts the fix for tdf#165228
        since the root cause now has been fixed.
        
        Change-Id: I0e33c53b7e1d8a7366caad0e1375a2f95a3ae313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190655
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        (cherry picked from commit 67ea1fc544a0651e8da78531cfa3525f72c434ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190665
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-08  Miklos Vajna  <vmiklos@collabora.com>  [dccbc10c314b6d81b0f1480fdbe68d5668bb2f69]

        tdf#168221 DOCX import, altChunk: fix lost header/footer
        
        Open the bugdoc, first page should have a header, but it has no header.
        
        This went wrong in 32c322e9d037b29ded2297b400a2c596c042f1fa (DOCX
        import, altChunk: fix missing page break, 2020-10-26), the problem is
        that somewhat similar to copy&paste, the altChunk mechanism drops styles
        from the inner document: the section breaks in the middle of the
        document are wanted, but the final section break is not wanted.
        
        So fix the problem by restricting when
        SectionPropertyMap::CloseSectionGroup() sets the page style name:
        instead of always doing that for alt chunks, only do it for non-last
        section breaks.
        
        This keeps the old page break case working and fixes the new, lost
        header problem.
        
        Change-Id: I5fc2a3d0561795612d39e50d780c7f78757486e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190625
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 4607c8d67ec3583c5a3e017bf1fa6fc7514a1674)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190657
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [10f5e8a68080b2d04d2e07a72369d09f58b1f354]

        libjpeg-turbo: upgrade to 3.1.2
        
        Downloaded from https://github.com/libjpeg-turbo/libjpeg-turbo/archive/refs/tags/3.1.2.tar.gz
        
        Change-Id: I7c2916d73f55fb3f4f3a50e8eeffbaafc63dca6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190591
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 678a97e17782b0fd1fc779b10763ebce45bf8cf8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190602
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [7848e02819c007026952a3fdc9da0961333dc079]

        poppler: upgrade to 25.09.0
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.09.0.tar.xz
        
        Change-Id: Ic7f3abd64d129543dcdc370816a0d69e5a59be90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190513
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190523
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [27212d679af27c99faf6ddd3b4efc8c9390164cd]

        tdf#108791: Ignore deleted comments in redlines of non-native documents
        
        ODF (and its native applications) can properly handle redline data of
        deleted comments. Other formats (or rather, respective applications
        like MS Word) don't understand the "comment anchor deletion" markup,
        and show the deleted comment as normal.
        
        Commit 419b70b5d4db227509614bdea5b4b89bcf7a6032 (tdf#105485 DOCX: import
        deleted comments as deleted, 2019-08-26) had implemented correct round-
        trip of the redline through DOCX. However, since Word doesn't support
        that, it created a situation when users can't correctly collaborate on
        documents.
        
        This change introduces a special handling of all non-native file formats
        in Writer, where deletion of a comment is handled just as in Word: it is
        deleted immediately, instead of marking as deleted. This doesn't affect
        deleting ranges of text, which contain comments: they are handled by
        both Writer and Word correctly.
        
        The solution works without any compatibility flags. This allows to have
        consistent behavior (same types of files will work the same way on all
        systems), zero configuration, and maximum functionality using native
        formats, unaffected by any settings.
        
        Change-Id: I2f8d3caaecd78af38e11a1ab6900d0afd73ed614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190376
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 3bf75e92e9ea089b707cb4e163def156ad28f7e0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190542
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [831dc39f045b909b03dcff300c31986a06ad5502]

        tdf#168131: don't pick hybrid PDF, when normal PDF was detected
        
        When a standard PDF is dragged onto a spreadsheet, a matcher is
        created in ScViewFunc::PasteFile, with current document service.
        Inside GuessFilterControlDefaultUI call, queryTypeByDescriptor
        detects pdf_Portable_Document_Format type, and draw_pdf_import
        as filter. Detection in PDFDetector::detect checks for embedded
        hybrid stream, and if found, it would return one of "addstream"
        filter names; and when we get a simple "*_pdf_import", it means
        that hybrid PDF was not detected.
        
        But SfxFilterMatcher::GuessFilterControlDefaultUI tried to find
        a filter for the detected file type, that matches the document
        service. It listed all filters for the type, and found the only
        filter that matched Calc: calc_pdf_addstream_import, which is for
        hybrid PDFs.
        
        This change makes an explicit check, that when original detection
        was for a normal PDF, we don't pick hybrid PDF filter.
        
        Change-Id: Ibab8c9ccaf97637eebbf9f93b8618d9d5f2fe73d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190274
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit dfb5639721031bcc43905576e84a97bed512567e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190293
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [cdfed7bd0dc1124c925b3664ac5d9ff13c945121]

        sfx2: check SfxViewShell::Current()
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/4aabe4e5-c568-4fa8-bcbf-6fb787cd603a
        
        Regression after
        commit a4349c502eb2169b3f83d58e49a7871a341daf76
        Author: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        Date:   Thu Aug 7 10:51:48 2025 +0200
        
            tdf#167845 Don't preselect the template path
        
        Change-Id: If816b4d5aa8810028de682a79a2e37ac2855c250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190477
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2025-09-04  Neil Roberts  <bpeeluk@yahoo.co.uk>  [166e4c13b579fc43ba7144c0b78a1cde39d2df6c]

        tdf#121253 Remove the default menu new document shortcut keys on MacOS
        
        The default menu on MacOS is displayed when there are no windows or on a
        dialog box with no parent. Previously there were hardcoded shortcut keys
        to create new documents. As reported in tdf#121253, one of these is ⌘A
        which ends up being inconvenient because that is commonly used to select
        all the text in a text box. This had the effect that if you tried to use
        that shortcut in some dialogs then the dialog would seem to disappear
        and be replaced by the new database wizard.
        
        The hardcoded shortcuts were added in 6efdd1444810 which is a patch from
        January 2025. Before that the shortcuts were generated based on the menu
        item title. ⌘A ends up being used for the database because ⌘D is already
        used for a new Draw document and it just picked the next letter along.
        These shortcuts were added in 2008 with ba57ba32e8054ec.
        
        This patch removes the shortcuts for the default menu in both the copied
        version of the start center menu and the original default menu generated
        in code. It seems strange to have shortcuts for these only in the
        specific case of there being no window or when a few select dialog boxes
        are focused. If they were generally useful to people then surely it
        would make sense to add them to the start center menu as well. For
        people using non-English language packs the patch from January would
        have effectively changed the shortcut keys. If nobody has complained
        then it probably means they aren’t used.
        
        Change-Id: I6065c3daa4e288caa98d73a3f286935dc5bc07ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190522
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit 9d2da58ec93db75d2fcfce3dc001d9db0851e3c6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190567
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [641a0e3d9a668f38651831f2a99db02edd50f21e]

        tdf#168159 CRASH: deleting columns and undoing
        
        revert
           commit 68db5b64b8db405f9e6c0368836a8ee671b46830
           Author: Noel Grandin <noel.grandin@collabora.co.uk>
           Date:   Sat Jun 28 16:13:53 2025 +0200
           crashtesting ooo120243-1.ods
        and
           commit c8742f36fa2bdc9d23042378f5b587ccda8b54dd
           Author: Noel Grandin <noel.grandin@collabora.co.uk>
           Date:   Thu May 22 10:18:48 2025 +0200
           tdf#166684 reduce cost of CellAttributeHelper::registerAndCheck
        
        Change-Id: I4d4442c6927121e7f18e3e08eb1736fa94a896bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190539

2025-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe0f5564f4755272a79334418346ecb21282649a]

        tdf#168191 Incorrect labels of X-Axis in chart
        
        revert
            commit eeb8ca44ac7994c0552749e190a193a44c956769
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Apr 4 10:02:06 2025 +0200
            tdf#147874 slow sheet switching with large chart2 (2)
        
        Change-Id: I67dcea417be01982b769dd2bea387b4d29f0e732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190520
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 423f95aa13165c2c11c2314d43b8cb1d331b5af0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190537
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [654a6dd03dc687ddca67d09e69b3d47c32e7faeb]

        tdf#167753: Revert "slideshow: change transition drawing view to icon view"
        
        This reverts commit e4a1c45a0bad3677d0b131ef9c6ac6e3c4bdb03c.
        
        This patch also reverts a part of
        commit 5c4fac1e9f50832852e87452f3152f01b905f9e6
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Oct 16 13:19:05 2024 +0200
        
            loplugin:unusedmethods
        
        since some methods are needed now
        
        Change-Id: If2610349ac1aaecb03d1a2f1b6e3e8005c23eb77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190538
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-09-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [01a4db02715ff12bfed0425784eccfca9ac47d41]

        tdf#151710 Don't activate Enclose with characters by default
        
        It is disruptive for non-power users, who then have trouble
        finding how to turn it off.
        
        Change-Id: Ib0d849d93794f797aca03d68ead4ef605667aa9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190431
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0e087513de7158fb3dbc192425782e5654fbc08c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190505
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-02  Justin Luth  <jluth@mail.com>  [d94e5209fb8b429b1424ac37602538ba2de6ab2a]

        tdf#165852 Revert "simplify bookmark name calculation"
        
        This reverts 25.2 commit 0c6599ca14ff4ff63224a7e34e93eb30e1ce2adc,
        and commit bcf4b998741da342d8612dfa2ac8b9d5d95269d4.
        
        because rSh.SetCursorInHdFt can move to a different page/footer
        and thus rSh.GetVirtPageNum() will change value
        on even and odd footers.
        
        Change-Id: I2d29e5c9f7538c47c6e11c8e7432f5f8d880bf72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190507
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit e16da933cdfe52382274bb9493bcaa12f85d6426)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190508

2025-09-01  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [afc5873df922a9f72bb615fdeb38de22311b9651]

        tdf#103859 EMF Fix size of the corners in ROUNDRECT record
        
        After EMF_ROUNDRECT rendering comparison of Office 365 and
        Libreoffice, it appears that radius of corners in LO is twice too large.
        EMF_ROUNDRECT implementation has to be aligned and
        conversion from ellipse width and height to ellipse vertical
        and horizontal radius have been applied (values was divided by 2).
        
        After apply this patch the ROUNDRECT looks identical as in Office.
        
        The issue is also visible in previous version of LO (24.2.7).
        
        Change-Id: I861fcd0e8d8a39d946215cc08ecc95403cd23fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190391
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Jenkins
        (cherry picked from commit cd410d0f384b64cba3d5387943173ae045cae07f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190466
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-01  Justin Luth  <jluth@mail.com>  [17c702997ece4aeb401c8731e53e5b49acb12862]

        tdf#167760 tdf#162326 limit reset para list attrs on style apply
        
        Problem: applying any para style
        was removing all numbering or bullets.
        
        This fixes a 25.2 regression from
        commit 075560420a7aa238182e2d80dfe1c5fbaad3edbd
          tdf#162326 reset paragraph list attributes on style apply
        
        The problem is that bResetListAttrs was already set to true,
        but the conditions under which bResetListAttrs applies
        were changed by the above commit
        so now it affects situations it was never intended to match.
        
        Specifically, this was the condition that changed:
        -    && pFormat->GetItemState(RES_PARATR_NUMRULE) == SfxItemState::SET
        +    && pCNd->GetTextNode()->IsInList()
        
        So two changes need to happen here:
        1.) bResetListAttrs needs to only be set
        under the existing comment's stated condition (docst.cxx/doc.hxx)
        that the para style itself contains a numbering rule.
        
        2.) When the control key is held down,
        then bRestListAttrs needs to be set to true
        (which is the stated intention of the above commit).
        
        make CppunitTest_sw_uiwriter11 \
            CPPUNIT_TEST_NAME=testTdf167760_numberedPara
        
        Change-Id: Iae646124a8a434dd3b49a75caeae4bb360396a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190309
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190321

2025-09-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [fbae6c22441a73be63cb95d0a5416e6841f49008]

        harfbuzz: upgrade to 11.4.5
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.4.5/harfbuzz-11.4.5.tar.xz
        
        Change-Id: Id10f54f98afa9bf416f3214135e817db3f66e318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190468
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 0a49b03988dc1f3c5a2ea3065666b0f7c751aab4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190474
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8bb3402ec5c352ef6eb4e6424394ff2cda60f595]

        tdf#127978, tdf#132421 - Change URL encoding for filename
        
        Change URL encoding for the filename of the import ASCII dialog's title
        and of the navigator's tooltip. Otherwise, filenames including a hash
        don't display correctly.
        
        Change-Id: Ib2f56e77649184f53dd226f4a77e80d270770135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190240
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins
        (cherry picked from commit 930186296cabd00dc0fb1b11dd6bb1b5ef042da0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190269
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [16fa8cd1167770f539b112ec2c75caacd1228c47]

        tdf#168089 - Don't URL encode filename for the update links confirmation dialog
        
        Change-Id: I9f3b6b7ae342e64c60ee9bf635cd64d7eb32b226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190132
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        (cherry picked from commit 7039f8acee67cbf20a4ca2b11e8bec5ac8a94414)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190227
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0c1f476a5f87ab97d0f2355680482ffa315159d0]

        tdf#168066: implement Format property for Calc's URL field
        
        Inserting the field threw exception from SvxUnoTextBase::insertTextContent,
        because SvxFieldData::Create tried to access Format property of the field,
        which is documented in css::text::textfield::URL service. It is trivial to
        implement it, because the underlying SvxURLField already has it.
        
        Change-Id: I98ddb7ed554b4223922a9da7560a62a0202878b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190080
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 48dae1af66b227e72d58935d5719610c957da30d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190211
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [13eee625a31b5aa0c4bd7d52a7df9e897a093ba0]

        tdf#168181: process field backslash escaping properly
        
        For some reason, import code for HYPERLINK doesn't use vArguments from
        the top of DomainMapper_Impl::CloseFieldCommand, and instead, it calls
        pContext->GetCommandParts. But that gives escaped strings that must be
        unescaped separately, according to the spec. There was a code handling
        specifically file:/// URLs,  obviously to address the problem; but the
        processing must be universal, both at import and export.
        
        Change-Id: I4d91f1c14dd55077e73dca0141422ba4ebda83d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190388
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0863f0c4ed983b05c2d86cb42283518e38a77320)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190469
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [6a9c3def9e89fe400ea43931bff02f0c31491794]

        tdf#81003: override GetDate in SbUnoObject to handle oleautomation::Date
        
        Without that, there is no code to deliver that value. The call to
        SbxValue::Get will eventually get to the SbUnoObject containing a
        css::bridge::oleautomation::Date in struct info; and there it will
        find that the object's SbxValue points to itself, at which point,
        it will error out from SbxValue::TheRealValue.
        
        Change-Id: Ia08fb2a7b1bcd7292faf5a5719a4fad0054a3f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190384
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190470

2025-09-01  Miklos Vajna  <vmiklos@collabora.com>  [24791006efdbcc5ade51a0545f17229606393957]

        tdf#167761 sw format redline, char style+direct: add ODT export
        
        The bugdoc contains a format redline that changes the character style
        from Strong to Quote and the font size from 24 to 36. Exporting to ODT,
        loading the ODT and rejecting the redline, the font size is set to 24,
        but the character style is set to default instead of Strong.
        
        What happens is that the item set of the format redline contains the
        necessary SvxFontHeightItem, but contains no SwFormatCharFormat. This is
        because the ODT export writes no parents for char automatic styles,
        because char formatting outside the redline table has 2 pool items for
        such char formatting: a dedicated SwFormatCharFormat for the char style
        and a separate SwFormatAutoFormat for other char props, so the ODT
        export "knows" to ignore the autoformat parent and creates this markup:
        <text:span text:style-name="...named style..."><text:span text:style-name="...automatic style...">t</text:span></text:span>
        
        Fix the problem by explicitly exporting the parent style name when we
        write an automatic style that is referred from the redline table (and
        not from the body text). This is similar to what e.g. "frame" autostyles
        already do, which also have parents. The result is this markup:
            <style:style style:name="..." style:family="text" style:parent-style-name="Strong_20_Emphasis">
              <style:text-properties fo:font-size="24pt"/>
        ...
                  <text:format-change loext:style-name="...">
        which contains both the named character style name and the automatic
        style, describing the direct formatting.
        
        The ODT import side still needs fixing.
        
        Change-Id: I19a67cf5e2c538cfcfa1b13097241954667d2c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190181
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit c625247680cd5737723154b9a73c45e786611b44)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190215
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d16697fbf6a6653dc631ebd887147afe2bfba37d]

        tdf#143182: fix string handling in SbxValue::Format
        
        When a value is convertible to number, check if the format string
        is for numbers of text (in SbxValue::Format). If the value is not
        convertible to number, handle it according to the format string in
        printfmtstr.
        
        Change-Id: I6e11aeffd8dd8581ebc868762944e9d6d9393514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit a3597edb52b671e6095f96c8705cd458a50d8799)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190386
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0a5a25ffd4855c418a6c285b1b28b7e5fe504eb2]

        Introduce Repeated(U)Char for concatenation of N repeated characters
        
        ... and use in sw.
        
        Should replace padToLength, where the number of added characters is
        known in advance. Avoids creation of a string buffer for the task.
        
        Change-Id: I90450e37926335d74421c6e38385e4c441e535d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190341
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190392

2025-08-31  Julien Nabet  <serval2412@yahoo.fr>  [3db9979c937d510d27db2fe7408c8407079d5527]

        Fix invalid cast from 'GtkImage' to 'GtkLabel' in appearance.ui
        
        Change-Id: I35ce17d1ab7b4dcd2dcfe4ed1e6f51553f5e9418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190258
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit f5f228ea9d5abd24e6e6fc332b383894ec6d2d8c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190272
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-29  Kurt Nordback  <kurt.nordback@collabora.com>  [7d02d980fd365aa112354761f2dc81d7bc6a6e83]

        tdf#165552 - 'Number of lines' control missing
        
        Fix the chart type dialog and chart sidebar .ui files so that the
        'number of lines' entry for columns-and-lines is not overlapping with the
        'composite size' entry for of-pie (which doesn't cause a problem with gtk,
        but does cause a problem with vcl=gen).
        
        Change-Id: I90db47623b9b5699457e814c914690dc1e7f4bf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187885
        Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 2b4996dc8043dd6b0b2af4e0914caf6c83a2dc87)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190332
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-29  Stephan Bergmann  <stephan.bergmann@collabora.com>  [7a0dca6df4c1222c9a78b16a53cce027e8784b4e]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/807aa4d1d34008907e22fb2a0a26eaafbda00f87>
        "Allow accessing cups for printing"
        
        Change-Id: I3beef30b44247e2b93ab541bb525c27b5b3ea2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190198
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 61b48b37361fec72929f6e1a3ae3f670047a5c2f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190204

2025-08-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [a68d8f9df4ed4466ed61ee79ce5c1a2ebe8e6540]

        tdf#103859 EMF Improve interpolation of the EMR_ROUNDRECT by Bezier curve
        
        Change-Id: I9d297489415e2b36e9566aa358d5eb9a2e94c398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190146
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit dea3d83e9a039aaec88f5ecca32066582d1921df)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190336
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [342ed0bef6d5a86a4a2174f7eb320485e37b1e8a]

        nss: fix aarch64 build
        
        dbtool.obj : error LNK2048: relocation PAGEOFFSET_12L targeting 'sftkdb_known_attributes_size' (00007F3C) is invalid for the instruction (F9400108 at RVA 000017B8) at section 0xD offset 0x48, due to bad alignment of offset to target (F3C); expected to be 8 bytes aligned
        dbtool.obj : error LNK2048: relocation PAGEOFFSET_12L targeting 'sftkdb_known_attributes_size' (00007F3C) is invalid for the instruction (F9400108 at RVA 00001B20) at section 0xD offset 0x3B0, due to bad alignment of offset to target (F3C); expected to be 8 bytes aligned
        
        Change-Id: I7c5331d4976073a7a84575fec5f66db0f12d54cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190219
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 9653afbbe9ed5b124b2fc3186577c3788f664692)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190226
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-28  Armin Le Grand (collabora)  <Armin.LeGrand@collabora.com>  [e4ec4aa609e5a67ec5e3301822d79d90faec30e4]

        tdf#168002 CairoSDPR breaks SVG text layout
        
        SubpixelPositioning was until now activated when *any* MapMode was set,
        but there is another case this is needed: When a TextSimplePortionPrimitive2D is rendered by a SDPR.
        
        In that case a TextLayouterDevice is used (to isolate all Text-related
        stuff that should not be at OutputDevice) combined with a 'empty'
        OutDev -> no MapMode.
        
        The DXArray for Primitives (see that TextPrimitive) is defined in the
        Unit-Text_Coordinate-System, thus in (0..1) ranges. That allows to
        have the DXArray transformation-independent and thus re-usable and
        is used since the TextPrimitive was created.
        
        If there is a DXArray missing at the text Primitive (as is the case
        with SVG imported ones, but allowed in general) one gets automatically
        created during the SalLayout creation for rendering. Unfortunately there
        (see GenericSalLayout::LayoutText, usages of GetSubpixelPositioning) the
        coordinates get std::round'ed, so all up to that point correctly
        calculated metric information in that double-precision dependent coordinate space gets *shredded*.
        
        To avoid that, SubpixelPositioning  has to be activated. While this
        might be done in the future for all cases (SubpixelPositioning ==
        true), for now add this case for all usages of TextLayouterDevice to
        not break old stuff.
        
        NOTE: Due to higher precision I had to adapt some values for SVGIO
        tests: That is expected since higher precision leads to less-wide
        results internally. I checked testdocs that deviations are minimal and
        have better quality with SubpixelPositioning then before.
        
        Change-Id: Iab5aa6336cdb18224fd06472bf6badc9eb0fce3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189993
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins
        (cherry picked from commit ba462658d955b6d7909f9ffbdfd341f18aff2028)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190236
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [28ccc612254cb173d638d918c6550959a9c8c56b]

        harfbuzz: upgrade to 11.4.4
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.4.4/harfbuzz-11.4.4.tar.xz
        
        Change-Id: If9a22319c9d658b0874dbaf751745bd34cb212a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190210
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [91bbfbe4b97c2d4d5663d11722f62b7fb47659f6]

        language-subtag-registry: upgrade to 2025-08-25
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-08-25.tar.bz2 data/language-subtag-registry
        
        Change-Id: I9449678926ad9bdaa65d0dc1ac1b2af9c0483fcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190233
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bc798e31a274a920515a01954f2e09289632659e]

        bump product version to 25.8.2.0.0+
        
        Change-Id: Ia03edb8362efb9273bc528601021f6e3e259597f

2025-08-26  László Németh  <nemeth@numbertext.org>  [8a9aa8096e360856f911ae1011bc42fa70c4b8e4]

        tdf#167298 tdf#166113 sw word spacing: add word spacing indicator
        
        tdf#167298: As an advanced feature for typography and related
        development – including bug fixing –, add visualization for
        justified text lines with too big word spacing.
        
        tdf#166113: fix bInteropSmartJustify by adding bFullJustified
        to avoid unnecessary extra calculation for the last paragraph line.
        (Regression since commit 529755f0919217a84a12daad0fddfddd1124f0e9
        "tdf#166113 sw smart justify: adjust algorithm for interoperability",
        detected by the word spacing indicator).
        
        The red word spacing indicator line is positioned before
        the justified text line, and its width is the extra space
        of a space character over the maximum word spacing.
        
        For example, if the font-defined space width is 3 pt,
        the maximum word spacing is 150%, spaces expanded to 6 pt in
        the justified line results a 6 pt - 3 pt * 1.5 = 1.5 pt width
        word spacing indicator.
        
        To enable the word spacing indicator in a justified text,
        
        1) Open "Tools" -> Options" -> "Advanced" -> "Open Expert Configuration";
        
        2) search for "ShowWordSpacingIndicator";
        
        3) double-click on the config entry (or press Enter) to set it to True;
        
        4) Enable Formatting Marks (Control-F10).
        
        Follow-up to commit 5a48070f5904c51dc9e7bbad4213d802fd4bc89b
        "tdf#126154 sw offapi xmloff cui: add min/max word spacing"
        and commit 7d6696757dcdfa3cee481ac7795a91b2b47da363
        "tdf#159923 sw cui offapi xmloff: add custom word spacing".
        
        Change-Id: I315b5e6b8239f4fdc8e69eb45fc292b8d5891138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187199
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins
        (cherry picked from commit c05bc38067b2ab61ae919fb1fef1381343d03844)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187735
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d2f194f1314488c9f0d7c70bc193c45dfdcb51b2]

        update credits
        
        Change-Id: Ice34b576357aca3cdd4c193a80fc112e5dd811a9
        (cherry picked from commit b3b650d7f0af39250483e4c70bd382215aad7bc7)

2025-08-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [540837ed5eb0544beb43d7a8692b69ecd532eeea]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 1dc91db5ebadf4c350ac2279d31b9313665bedd9
          - update translations for 25.8.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Ic439ea5414d4a61a78000667d677b417ade81d63
            
2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [63d700dbdf8d36789f5ad819a2ba6d2a4570b070]

        crashreporting: sc: check GetDBData()
        
        it might return nullptr
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/9b83d1cc-1964-4e9d-a7b5-2f0ab4702303
        
        Change-Id: Ie4b538697842560f821d78c5fe5e135a517beb82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189586
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [e7644224f9a4ca3b24346c5967d4c82ebbbf814c]

        sc: use SAL_RET_MAYBENULL in GetDBData()
        
        Change-Id: Iaccf557056877128b4ba036ff43056816795874d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189587
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 8ffeca7af4302da21d33494342017c3737d540e1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189734
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [12f068d1f8740ba67ad4c9f3de85198157214c15]

        tdf#167075: init doc shell before pasting as png/bmp (take 2)
        
        Regression after
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        and
        
        commit 52e3b2b040ac54c2a5661e3676b135170f028f50
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 16:06:12 2025 +0200
        
            ScViewData: simplify constructors
        
        Change-Id: I6a709ab82f51c34a022c43d35b97f661e5c283e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189434
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 671564bce4541244ad3d67b5b98899321176231e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189443
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [12d7b6b42e30700c2ae877d62dbf102d3360d977]

        nss: upgrade to 3.115.1
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_115_1_RTM/src/nss-3.115.1-with-nspr-4.37.tar.gz
        
        Change-Id: Ie887520c9177bfca2a7aff78787f14109bb3c4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190053
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c8c339b1e15ee4ad4d9acbbbc4f77a7022ddb3c]

        lxml: upgrade to 6.0.1
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-6.0.1/lxml-6.0.1.tar.gz
        
        Change-Id: I3677360e0a14d839aad579d1d81f4152c640a311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190161
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d115a20984c128cf5f99c8e06e9f57ff47b205c]

        harfbuzz: upgrade to 11.4.3
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.4.3/harfbuzz-11.4.3.tar.xz
        
        Change-Id: Ib1d5033eb63c4ec5fba6816e692166b42ea08087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190157
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190165
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [d5446d7c6e59defb3c9abcf2a9545d13fdd4c887]

        tdf#168070: SwFindDocShell may need an interaction handler
        
        It may attempt to open the passed document, and then it would create
        an SfxMedium, that will define how to interact e.g. on errors. When
        caller has an interaction handler, it should pass it.
        
        Change-Id: Icd0881ecf31b1e1a4731e1776413c1f62803c256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190173
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit be6aa7ca0a3d9d444956c0e19a262a2ef91bdd5a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190188
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-25  Miklos Vajna  <vmiklos@collabora.com>  [df0dd5cf8fa74c07b0ca52673749f2f66208fdb8]

        tdf#167761 sw format redline, char style: fix missing encode in ODF filter
        
        Open the input DOCX, save to ODT, the named char style of the format
        redline is:
                  <text:format-change loext:style-name="Strong Emphasis">
        while it should be:
                  <text:format-change loext:style-name="Strong_20_Emphasis">
        
        This was not obviously a problem before, because both the import and the
        export failed to encode/decode, but it'll be a more noticable problem
        once we try to handle both direct format + char style, where autostyle
        parent names are encoded and this was not, leading to inconistency.
        
        Fix the problem similar to how it's handled for <text:span> elements for
        export in XMLTextParagraphExport::exportTextRangeSpan() and for import
        in XMLTextImportHelper::SetStyleAndAttrs(), by encoding/decoding on
        export/import.
        
        Also update sw/qa/filter/xml/data/format-char-style-change.odt, which
        had a bad style name, missing an encode before export.
        
        Change-Id: I2a9fae2c99c286d8c1c3a5e6af18f6f501e18089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190151
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 43104ad996bc9b292b66d9e605632407cb59c4c6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190175
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-25  Patrick Luby  <guibmacdev@gmail.com>  [128e2c009e4c13821bbe371e949eaf8a979bc2bb]

        tdf#111634 Eliminate some macOS Address Book driver memory leaks
        
        The memory leaks that have been eliminated were found using the
        steps in the following post:
        
        https://bugs.documentfoundation.org/show_bug.cgi?id=111634#c0
        
        Change-Id: Ifb4ec1837737fe5430ade571e1a45e0aa76078ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190100
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 67e05014a293eece25d781ace0af875b81dea2ad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190103
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-25  Justin Luth  <jluth@mail.com>  [999a132e30ca427ab67bbe6c647c5c2724639548]

        tdf#164500 writerfilter: make extra framePr anchor para tiny
        
        This reduces the layout impact of
        25.8 commit 575094675e7f6fb643e8cac61f06c14d2f79bcd5
        
        I initially just tried to make the paragraph simple (default),
        but that could still end up being overly large,
        so force a small size/margins/lineSpacing as well
        to make this added paragraph as inconspicuous as possible.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf164500_framePrBeforeTable2
        
        Change-Id: I0c91048d206037b3427c6aa4704d65bb9f677435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189702
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 041829c76877599ebf94c9b5bdfa94ec08132d9f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189727

2025-08-25  Justin Luth  <jluth@mail.com>  [5dde4060cc7ee51481106fbf4567e59353182e79]

        related tdf#167721 cui: allow negative values for firstLine
        
        When lcl_SetFontRelativeValue was calling
        rField.SetFontRelative(FieldUnit::FONT_CJK_ADVANCE),
        then SvxRelativeField::SetFontRelative would
        m_xSpinButton->set_range(bNegativeEnabled ? -9999 : 0, 9999)
        and bNegativeEnabled was false.
        
        Change-Id: I3068705c15c11a066301b1105f3959c982f5f824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189389
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 6c1b8cf820b41f7a579d5d9e7036a14d22567782)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189421

2025-08-25  Stephan Bergmann  <stephan.bergmann@collabora.com>  [ee515989c3ca1ee7c06fee2585a5a285f729b6d5]

        Update the reference rdbs to libreoffice-25.8.0.4
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-25.8.0.4/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        * css.lang.XSingleServiceFactory has been un-deprecated with
          4f03d1c23840b49d9af5080eaf9f59688685664f "css.lang.XSingleServiceFactory must
          not be @deprecated"
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-25.8.0.4/instdir/program/types.rdb \
         .../libreoffice-25.8.0.4/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        * css.i18n.GROUP_SEPARATOR_IN_NUMBER_3 is marked as "@since LibreOffice 25.2"
          but was only brought into libreoffice-25-2 with
          055b637ed9bdd02cd857664813a66afde51dfd0a "tdf#158867 offapi,i18npool,starmath:
          fix ',' in Math again" after libreoffice-25.2.0.3, for which point the
          previous type reference had been generated with
          aabf7c44ecdf7162eaa8ceead5fb7147218e6ffc "Update the reference rdbs to
          libreoffice-25.2.0.3"
        
        Change-Id: I387e20b3bc5955b60b8365f6a64604481f2e0de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190155
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit 50e82794f1a39c326bf807623241aff81b54cd59)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190167
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [cd8f79fc01173ce66e84bef7be6bc04912e59fb0]

        tdf#168096: reset selection each time GetUnoText is called
        
        ScCellObj represents the whole content of the cell; and its XText
        must always cover it all. However, implementation (ScCellTextObj)
        may get its "selection" (defining the actual range) out of sync,
        after created initially, if content is changed using other objects.
        It is a modification listener; but that doesn't help, because some
        methods may manually re-assign selection after the actual content
        change: see e.g. SvxUnoTextBase::insertString.
        
        This change resets the selection of the cell object each time its
        GetUnoText method is called. The EE_PARA_MAX value assigned to
        start.nPara causes the needed processing in CheckSelection.
        
        Change-Id: I94bc55ee3df7976dcaeaa9c4878059995e885e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190142
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190164

2025-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [d4fb438cf3f3375ff72209b994f040a92b5c68db]

        tdf#168073: generalize the fix to other XText methods
        
        ... that take XTextRange, and that should accept the cell itself
        
        Change-Id: Id9157b53521e22059825a6d86c814f334682a3c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190109
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190163

2025-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2bdf8d96a1356fc74ec271cdbb88954ae0d84240]

        This code is dead
        
        If getFromUnoTunnel<SvxUnoTextRangeBase> failed, there's no
        need to test getFromUnoTunnel<ScCellTextCursor>: it is derived
        from SvxUnoTextRangeBase, and will always fail.
        
        Change-Id: I9faac80c6d58ff8d5b84cdb6ab5682ffc06f6b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190093
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190162

2025-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [001977eac8a1a27892eb447d02271086845210a4]

        cid#1660010 Overflowed constant
        
        Change-Id: Ie8d50e3178713029197a1df3a80ce3319c0f77ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190107
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1cecf9f2a44ca597a69ec12732f9b86bb1fc1aba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190144
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-08-24  Noel Grandin  <noelgrandin@gmail.com>  [87adf182c7d66d9c18ca3d6e94f4c8592ad77301]

        tdf#168068 Bold/italic not functioning (2)
        
        regression from
            commit 6e16e1812292236ed61b637371f70459cf993b7f
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Apr 7 20:14:46 2025 +0200
            tdf#64991 exit some loops early
        
        Change-Id: Iae46edcd39c042a7e78f1d7c46e71c6258af7934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit cc09d5db6ed126037bfb476d24d2866c308c62d9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190140
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-24  Noel Grandin  <noelgrandin@gmail.com>  [f72b23deb73542c60984e8cc6390c62b8b9370c7]

        tdf#168008 XTextRangeCompare doesn't throw when ranges are in different texts
        
        regression from
            commit 27e9fd67260b8ad321cf0f8722e2db8a08473927
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 13 09:01:50 2024 +0200
            tdf#144208 speedup doc with lots of redline (7)
        
        Change-Id: I2df6a7c345735be84b459bab0bbfd874c991f6f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190092
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 14e542d58778963df461965f129286fc75459d3b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190096
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [8013104ecc2e1a297cb238024c9a6100b07ff84d]

        tdf#150229: increase maximum size of URLs for Excel file formats export
        
        The values (8192 characters for XLSX, 2083 characters for XLS) are from
        experiments. While 8192 looks legit, 2083 seems odd - but when I export
        an XLSX with 2084-character hyperlink to XLS, the end result misses the
        hyperlink completely.
        
        Change-Id: Iaf607063b624af93393609eb42feba62910d5254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190078
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f41c58ad4172729a2be261f0ccea01d741d61a2d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190098
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-24  Noel Grandin  <noelgrandin@gmail.com>  [b7d54ddc548f9df7058c8a1dc4df00691b74c35d]

        tdf#167812 font dropdown broken (2)
        
        Fix this some more.
        Using transparency, as in my first commit for this issue,
        means that we have to fill in the background for the list box
        entry before drawing the entry.
        
        Change-Id: Iee018473524eaa58bc3584fac3c136bfe01408d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 4bdcccaedb5f1be85784dffd70fc017d1ed2fc5b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190095
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-24  Noel Grandin  <noelgrandin@gmail.com>  [e154f90438506a6f7e4da3c1e53c0d28289463de]

        Revert "remove mpThreadGraphics from GDI backend"
        
        This reverts commit b5510122fd68e3d16117684f51062dfb03961b85.
        
        I was wrong, we need this for when out of process extensions
        call into vcl, which they will do not-the-main-thread.
        
        Unfortunately, the only unit test we have that exercises
        this is JunitTest_sfx2_complex and that test is not run
        on the Windows Jenkins boxes.
        
        Change-Id: I55582418c229a7064e27ebf408a9e719ef6dd8a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit fa5b29052dc5768048d7098a4829aa2a14ec35c7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190138
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-24  Noel Grandin  <noelgrandin@gmail.com>  [b38c44ee5a08bd4d3ea2e69a3a01fca63880e221]

        tdf#168068 Bold/italic not functioning
        
        regression from
            commit 6e16e1812292236ed61b637371f70459cf993b7f
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Apr 7 20:14:46 2025 +0200
            tdf#64991 exit some loops early
        
        Change-Id: I9167708bb8e6d3477b711f0ce773b0f9594e91c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190102
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 864bd25ae13c07037a818f51889cd7c578af850f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190139
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-23  Mike Kaganski  <mike.kaganski@collabora.com>  [1e040b72222012f9a5f1e47d19aaf0c0369e08ad]

        tdf#168073: check if xRange is this
        
        And use its own XText implementation object as the range. Also relax
        the call to getFromUnoTunnel, to request SvxUnoTextRangeBase that is
        actually wanted, not arbitrarily chosen ScCellTextCursor. This makes
        this optimized code to also handle ranges returned from ScCellObj's
        own getStart() / getEnd().
        
        Change-Id: I4f500b32790f2844fdd7f54818b79b8a29525475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190085
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a8ce5af575ea5e05eb7c349d50b4eb08cab983ff)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190097

2025-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [3c8a54698ef7ea11d17f564d273464640c5b02b9]

        Simplify sd::View::InsertData
        
        Let it return immediately where the job is done. To do that, move the
        cleanup actions to a ScopeGuard. That avoids overlooks where an early
        return skipped these actions by mistake.
        
        Change-Id: I8330afed43c70e8f4a3b15ac7ced44f61cc51e9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186522
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e933a61be0e796de415e53645a44dbcc1e8200fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190076
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3fa6bed062d7fd840eb75c18390e0384695af827]

        Resolves: tdf#156297 restore copy area optimization
        
        This reverts commit 344d90b20bdf95e9888f916672bbe51a5d700d02.
        "tdf#152094 don't attempt scroll paint optimization for devices with a mapmode"
        
        It slows calc scroll down too much, and things have moved on with text
        placement otherwise, so this hack is possibly redundant anyway.
        
        Change-Id: Ic4337e71ddd38250a1e5e305acb97b3f1a93f20c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190054
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit a6dc33e5b4af22ef150ca328ad67132e85ec3dbe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190061
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [98bb4a9de003948e08339167f5d9e13d3351d571]

        tdf#167774: sw_odfimport: Add test
        
        Change-Id: I781bd1bbae10f2ccc0660b39e976d99c72c4fee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190021
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 3d411a417db35c40e990c2cab09f65198ec0371b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190030

2025-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [68ea22378d5db5d2c51193a7d9771d4569d4e5aa]

        tdf#167812 Calc in Dark mode: font dropdown shows white rectangles (GTK3)
        
        regression from
            commit e0d4d178caff1414a9a21fa57f06bc8d4d2c389a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 13 15:03:05 2025 +0200
            Change alpha behavour of OutputDevice::SetFillColor
        
        Change-Id: Ifa34c795d2f69b6ef258757073c89f73ca64041a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 3275aca2e8eb44d7c167541e86455f50dae204b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190022
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Miklos Vajna  <vmiklos@collabora.com>  [5d30325108f80fbb6ac913b42e74a64a7e13bd72]

        tdf#167761 sw format redline, char style: implement ODF import
        
        Load the bugdoc, the format redline at the doc end has the Quote char
        style, reverting the redline should result in the Strong char style, but
        results in no character style.
        
        What happens is that XMLChangedRegionImportContext::SetChangeInfo()
        assumed that the style name of the format redline is always an automatic
        style, while it may be a named character style, too.
        
        Fix the problem by splitting the style name into two parts in
        XMLChangedRegionImportContext::SetChangeInfo() (named style, automatic
        style) and then work with that pair in
        XMLRedlineImportHelper::InsertIntoDocument(), similar to how
        XMLTextImportHelper::SetStyleAndAttrs() works for <text:span>'s style
        name.
        
        The ODF export worked already.
        
        Change-Id: I2fa1479a0d2463556e84be566967325584bc14f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189984
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 0ba6dd9eb3f342345663b12527a29425675d2078)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189995
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4fd88e4e04ecdb8266ba6112dffc988a8157775]

        tdf#167774 Writer shows font of defined style with 10,8 pt instead of 9 pt
        
        regression from
            commit ca65ed8a37847b334868b8cbf05f1ba77665d5aa
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Dec 24 12:28:29 2024 +0200
            move RES_FMT_CHG to SfxHint
        
        The important fix is in SwModify::SwClientNotify.
        
        The other changes are small things I picked up when going over the original patch, which
        likely don't make much different, but better safe than sorry.
        
        Change-Id: I65c79b60740dc7f1b711522db8d8682c69d632e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189998
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190020

2025-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fb32b7f21092b083abd8e6f4994159a5d1666b10]

        Resolves: tdf#150743 disable keep ratio is any value is zero
        
        can't divide by zero
        
        Change-Id: Ia6f60e1614a621cee7eaa6029cf0eefda32210bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189997
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 7d2b92d0e78751ac00d25dd312f7bc77abe96b4e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190001
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  افشین ‌  <afshin@libreoffice.org>  [423d7edf0d74735e221e4755c19223486ad878cb]

        tdf#164996 Optimize Persian (Farsi) AutoCorrect list
        
        In this patch, I have added some new incorrect Persian (Farsi) words
        and removed ~400 words that were not incorrect.
        
        The removed words were spelling variants and can not be considered
        incorrect.
        
        Change-Id: I06903519e72fcdee33574d80c71f6f301a30e05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189495
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        (cherry picked from commit 270e3677e026d7da7474e1a28dea98dd62c105f1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189986
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Miklos Vajna  <vmiklos@collabora.com>  [3baa9e363bee40c8cdcda4f3e2a4026929a23fd7]

        tdf#167761 sw format redline, char style: implement DOCX import
        
        Open the bugdoc, there should be a format redline that tracks the change
        of the char style from Strong to QuoteChar, but the doc model contains
        no redlines.
        
        What happens is that we try to handle character style as a character
        property, but SwUnoCursorHelper::makeRedline() uses
        SfxItemPropertySet::setPropertyValue() for CharStyleName, which calls
        into SwFormatCharFormat::PutValue(), which fails, so the redline is not
        created.
        
        Fix the problem by reusing lcl_setCharStyle(), that knows how to set the
        character style on an item set.
        
        The DOCX export worked already.
        
        Change-Id: I9479cadfdf6cb598cd4b11d49d851236c8ec09e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189918
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a6d8608595fd1ecfdff35c2003a28589ea1214ad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189978
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Balazs Varga  <balazs.varga@collabora.com>  [d7282fff1cac8057ca9ec86f45bd8114bcbbaf3e]

        tdf#168023 sc view: fix empty cell be not rotated with Text Orientation
        
        We should only do text rotation if we have text content in the cell.
        To test just open bugdoc in check if F1 cell borders are rotated or not.
        
        TODO: unit test
        
        Change-Id: Ie7a5dda8b81e3793300e6bc358540fa363568b91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189963
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 9e3cebf6c017b01ec917c818988db45aa9ac0b1d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189987
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b81b31964a0d8e8a7f8765d696931db3bd2d32fb]

        fix cairo null pointer deref
        
        when running with internal cairo and the gen backend
        
        Change-Id: Iec847b5f9fe97faefc1304e0e153ed81f8e1c9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189983
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 1f9fa0dd5b7fdf7aa5599bec6bcfa304e8654300)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189996
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a600022e08e0e51388116a079602362020307ad0]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 60cfb2fd043c291510527d4517adafcb65973f0a
          - update translations for 25.8.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I5fcce84921449ce710bc87289cb5f6f4c146ab8a
            
2025-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59a848d274538980cf73ff3ee3f8acf417330288]

        Resolves: tdf#167419 Changing the borders of a table doesn't refresh bottom
        
        The bottom border can remain un-refreshed. That border is outside the
        FrameArea of the table when the default CollapsingBorders is enabled.
        Add it in here for the last row when determining the area to repaint.
        
        Change-Id: I45cecd11e7d0d53905b3d6d6b3de83e1a28a468d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188480
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e9abbdd178d6a01f6ecd8642920c52902312e470)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189494
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-21  Miklos Vajna  <vmiklos@collabora.com>  [3b504086e2446d566749638882b4f73c7eeb1e3f]

        tdf#167761 sw format redline, char props: implement ODF import
        
        Load the bugdoc, save as ODF, open the ODF, revert the format redline,
        the font size should go from 36pt (new direct format) to 24pt (old
        direct format), but it goes to 12pt (doc default).
        
        What happens is that the format redline specifies the old direct format
        via <text:format-change loext:style-name="..."> (referring to an
        automatic character style), but this was not handled on import.
        
        Fix the problem by:
        1) Handling the new attribute in
           XMLChangedRegionImportContext::createFastChildContext()
        2) Looking up the already imported autostyle for the style name in
           XMLChangedRegionImportContext::SetChangeInfo()
        3) Creating a matching SwRedlineExtraData_FormatColl in
           XMLRedlineImportHelper::InsertIntoDocument() when the format redline
           is created in sw/ core.
        
        Note that this means we have two autostyle names at play, the first is
        T<number> and the second is effectively a pointer address as a string,
        like 3cb7b270; FindAutoCharStyle() mapping from the first to the second.
        Unfortunately both are just string references to the already imported
        autostyle.
        
        Change-Id: Ib0f18bad223f4320afe5aaa11ea713e610f6c029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189845
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189909

2025-08-21  Miklos Vajna  <vmiklos@collabora.com>  [a9a945547b26376b15d8dd3865d2dd54e576608a]

        tdf#167761 sw format redline: implement ODF export
        
        Load the bugdoc, revert the format redline, the font size should go from
        36pt (new direct format) to 24pt (old direct format), but it goes to
        12pt (doc default).
        
        What happens is that we have working DOCX import to store this in
        SwRedlineExtraData_FormatColl's item set, but the ODF import/export is
        missing.
        
        Add the ODT export by:
        1) Adding a new SwXRedlineAutoStyle that exposes the item set, assuming
           it contains character properties, and create this in
           SwXRedlinePortion::GetPropertyValue() if the RedlineAutoFormat property
           is requested.
        2) In XMLRedlineExport::ExportChangeAutoStyle(), write this item set as
           an autostyle.
        3) In XMLRedlineExport::ExportChangedRegion(), refer to this autostyle.
        
        Note that similar to delete redlines, the format redline contains the
        old formatting, the new formatting is directly in the document.
        
        Change-Id: Iedd7416e5eefc4814199d60c4a6b68dbb76136e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189672
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189908

2025-08-21  Mike Kaganski  <mike.kaganski@collabora.com>  [40f13a8fc7676f7ed0741b3b4c46d0c06637ce53]

        tdf#168010: introduce UseTrailingEmptyLinesInLayout compat option
        
        In PowerPoint, autoshrink text size is calculated the same way as in
        Impress, ignoring the empty lines block in the end. But when the text
        is positioned, these lines are taken into account, which may change
        position of texts aligned to bottom.
        
        Since this method of positioning text may change text placement very
        seriously, it can't be used unconditionally, and requires a compat
        flag, which is introduced here, only enabled for PPTX import, and in
        ODP documents having the option explicitly set.
        
        It is not used for other MS Office document types. I saw that Excel
        behaves similarly to PowerPoint, so maybe it makes sense to enable
        it for XLSX, too; on the other hand, MS Word works differently. Also
        I couldn't prepare a test document in binary PPT to test hehavior.
        The decisions about these file types should go in separate changes.
        
        Change-Id: Ie37f1d2b3393f9c52be89586c73df70b108190a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189935
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 425b55efaf1f04e8f91cb049a5820fcf61e678dd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189942
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-21  Mike Kaganski  <mike.kaganski@collabora.com>  [ab3d6fc0df510bee87e288b7b0c051173675048c]

        Use enumarray for SdrModel's compat flags
        
        Simplifies adding new flags
        
        Change-Id: I9db6fab29676f620107d3364d7318790e4512e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189910
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b2d3a4dd250ad6156f904d6b755a6faa4bfadd60)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189941
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6d21736aa3abaf6a44855d6839f05dace62eb7dd]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 5a7f97909944f209124f647ec539b5e9865d7465
          - Add LO25.8 video teaser
            
            Change-Id: I18b40bcb70c6a70fe9085951beabb16d7ab798be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/189938
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            (cherry picked from commit 635c0a59db2fd0efd7cc9010a5cc2e8feafd5619)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/189939
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2025-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3998282717db05cb7c37f8b19d2bf6d69e2e907f]

        Revert "cid#1660822 Different smart pointers managing same raw pointer"
        
        This reverts commit fae1a210dcc817862045e7db6edf9eabe60d7557 in
        the stable branch.
        
        Change-Id: Ic222d24a03a289a83cddbeb0008dcc321b9de33e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-08-20  Heiko Tietze  <tietze.heiko@gmail.com>  [6fb8f20900139856cbe06aeaa8985efb761aeb40]

        Resolves tdf#167952 - Null-pointer-use in Welcome dialog
        
        Change-Id: Ibc33b0e8cb93888a373ee0f27735ba276ee27960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189668
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        (cherry picked from commit 144e72591a61127a6d1e0f1a6bc9867a61e9b135)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189952
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [7450e3db03d7c09acf80124b460b6b9cef3d9b64]

        SwXRedline::getPropertyValue must throw on unknown property
        
        SwXRedlinePortion::GetPropertyValue didn't throw, so any name
        could be passed to the objects accessed by XRedlinesSupplier.
        
        Change-Id: I9fc93c065e887a0c3062ee54d6714aaf39a45126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186418
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189924

2025-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [fbf69202c071acf317bc6a9d549d35defb2c2df2]

        SwRangeRedline::GetDescr can be const
        
        Avoids some const_casts.
        And moving some code working with PaM to a separate function allowed
        to restructure it, and avoid initializing the description variable
        with non-trivial DenoteSpecialCharacters(rPaM.GetText().replace(...)),
        in cases when it had to be immediately replaced with something else.
        
        Change-Id: I3b213ca3daa31ae491f067a823443c70f6b1d22c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186415
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189925

2025-08-20  Miklos Vajna  <vmiklos@collabora.com>  [0c0d1ecd47237a80971e30cc315f41ddd1c8b621]

        tdf#167761 sw format redline: register the item set in the autostyle pool
        
        Load the DOCX bugdoc, save to ODT, open it, go to the 36pt font size
        format redline, click reject, should be 24th, but it's now 12pt instead.
        
        What happens is that SwRedlineExtraData_FormatColl SfxItemSet is not
        part of the autoformat mechanism, so the ODF markup can't even refer to
        it. So reject works correctly after DOCX open, but not after ODF
        roundtrip.
        
        The first step here is to replace the std::unique_ptr<SfxItemSet> with a
        shared pointer, similar to what SwFormatAutoFormat does for normal
        character direct formatting (the redline just stores the old direct
        formatting).
        
        This allows producing the std::shared_ptr<SfxItemSet> in the autostyle
        pool, so the ODF export will be able to export the old direct formatting
        as a next step (not yet done here.)
        
        Change-Id: I1f7a8083ce766bd2ec06bb8e19bfce0eaebfe405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189509
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189524

2025-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [48b2cf6caffc0e0c11dc7cc112d9f3e8c2de4488]

        cid#1660532 Overflowed constant
        
        Change-Id: Id0e494aa0465e6c04c7a8210597be891b734c461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189821
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit b60a410a90bbe5fce235b38a5a92022b5a9bcdee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189844
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-19  Justin Luth  <jluth@mail.com>  [104a7e6b50329450cf7757fbede0c8acc734fb1f]

        tdf#167721 docx export: don't spam *Chars=0
        
        I don't think we ever import this situation in DOCX
        (and no existing unit tests were found),
        but if a margin is stored in LO as FONT_CJK_ADVANCE 0.0
        then it is already written out as disabled,
        so a style that inherits that disabled item
        doesn't need to re-disable it.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_zeroCh
        
        Change-Id: Id6c90ca3e4704f2baf3619cce6470b517ea1772f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189637
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189652

2025-08-19  Justin Luth  <jluth@mail.com>  [3abee091cd10f634b00e3bca733f3deff1dafd86]

        tdf#167721 writerfilter: adjust disabled leftChars by hangingChars
        
        Sixth Problem - in a very inconsistent move, with hangingChars
        MS Word ignores the fact that w:leftChars=0 has been disabled,
        (or even never defined)
        and simply treats it as a zero margin,
        even if a w:left margin has been defined.
        
        I imagine this is actually a bug in MS Word.
        That bug is seen in MS Word 2003 / 2010
        and still exists in MS Word 2024.
        
        There are even weirder things happening with styles,
        but when I actually apply a style to a paragraph,
        then that paragraph gets different margin properties
        than what is shown for the style,
        so probably best not to attempt any changes to styles at all.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits
        
        Change-Id: I689853f631aa1cb5e144e43e75672b177fd81537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189437
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189554

2025-08-19  Justin Luth  <jluth@mail.com>  [8a11beb71eff1b4c7fa2a4b61394cec825e7a804]

        tdf#167721 writerfilter styles: adjust leftChars by hangingChars
        
        Fifth Problem - styles import needs to adjust the left margin
        just like the paragraph import does.
        
        The way MS implements "hanging"
        is that w:hanging defines where the first line starts
        and w:left defines how much further the remaining lines start.
        
        This is opposed to "firstLine"
        where w:firstLine defines the additional indent for the first line
        and w:left defines where the entire paragraph's indent.
        
        LO's implementation is much nicer, where the left margin
        always defines the entire paragraph's indent.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits
        
        Change-Id: I6ac4b49350d33d31d0948530910b4d4712bdc403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189269
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189553

2025-08-19  Justin Luth  <jluth@mail.com>  [8b097a952b556c3ba28e32658de702ae8c183c96]

        tdf#167721 docx export: add w:left=0 when w:leftChars=0
        
        Setting w:leftChars to zero means that it is disabled.
        It will use w:left instead.
        
        Since w:left could otherwise be inherited from the paragraph style,
        make sure that it is specified as zero.
        
        Change-Id: I9b14d96aae4b5128e3dc490a57022832eee9b2f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189268
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189552

2025-08-19  Justin Luth  <jluth@mail.com>  [5ff90b9dc4574e3c9de24801db9cfd66c1e24db9]

        tdf#167721 docx export: disable inherited leftChars when writing w:left
        
        There are two w:ind items that can affect the left margin,
        and leftChars has the priority.
        
        So if the parent style's left margin was written as a leftChars,
        then a non-leftChars w:left needs to also disable w:leftChars.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits3
        
        Change-Id: Ie0126ea5e5409907d4edc999ec13ac5f667aa682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189267
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189551

2025-08-19  Justin Luth  <jluth@mail.com>  [571b555a6fd8e1dfc12cf7f76d168bfb5dcbe044]

        tdf#167721 writerfilter styles: use provided w:left when leftChars=0
        
        Fourth Problem - styles need to apply either the value of w:leftChars
        or the value of w:left, but not both.
        
        If w:leftChars=0, then the style gets the value of w:left
        (either an implied 0, or else specified, but NOT inherited!)
        
        Otherwise, leftChars (which might be inherited) takes priority.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits2
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits3
        
        Change-Id: Ia19e48f57c6a716e3275df6261e7fb257f0cd788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188930
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189550

2025-08-19  Justin Luth  <jluth@mail.com>  [403c426c4bb602088ae4d8251ea7897a91dd8afe]

        tdf#167721 writerfilter: ensure w:left applied if w:leftChars=0
        
        Third problem - if leftChars is disabled,
        then w:left needs to be applied to the paragraph.
        
        If BOTH were defined as direct properties
          <ind w:left="1234" w:leftChars="100"/>
        then xTextAppend->finishParagraph has applied both
        of these properties to the paragraph,
        and it is somewhat ambiguous which one exists.
        (In my testing, PROP_PARA_LEFT_MARGIN_UNIT wins).
        
        So in this section of code, we are reviewing the situation
        and re-applying the appropriate property.
        In the special case when the disabled-leftChars property
        was written to the actual paragraph,
        the direct-or-inherited w:left needs to be
        rewritten onto the paragraph.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits2
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits3
        
        Change-Id: Ic36db6d4934876d800770fe8f3303c7eca06d532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189234
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189549

2025-08-19  Justin Luth  <jluth@mail.com>  [44ab5932c6d1a959f6120c807485a1184ccd0847]

        tdf#167721 writerfilter: don't adjust leftChars=0 by hangingChars
        
        Second problem - a zero value is a special case
        which "turns off" a previously defined w:leftChars
        and uses the w:left value instead (usually).
        
        Since it doesn't make sense to add a variable-length ic unit
        to a static-lengh unit (like cm), just ignore that situation.
        [NOTE: sometimes they do seem to need to be added together,
         the likely formula is 1 Ch * 100 == TWIP value.]
        
        Thought experiment: what if the hangingChars adjusts a leftChars
        so that the leftChars BECOMES a zero?
        It doesn't matter - we are only changing LO internals now.
        
        This patch prevents hangingChars
        from adjusting the left margin from the special zero-case.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits
        
        Change-Id: I3f2a379c6145c10eccbce1ce59969c4a59acc330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189233
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189548

2025-08-19  Justin Luth  <jluth@mail.com>  [9ffea9800ab1fca4229b308aacc4ee2f49fddb0d]

        tdf#167721 writerfilter: ic needs to inherit from parent para-style
        
        First problem - all 3 settings were set to 0 if no direct property,
        so there was no inheritance from parent styles.
        
        Note that it is important to record the zero case,
        otherwise you can't "stop" inheritance.
        (My first instinct was to not write any property when !nIntValue.)
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf167721_chUnits2
        
        Change-Id: I5f3dec002271f3401a126b1e55b78191dd622453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189232
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189547

2025-08-19  Justin Luth  <justin.luth@collabora.com>  [6b62fbaef464ebdceb2d03784f5726e81673abb7]

        tdf#164748 doc/x export: fix missing right/left only page break
        
        This patch improves on tdf#99120's round-tripping patch.
        
        LO 25.8's import patch for tdf#164748
        exposed this wrong export for even/odd section breaks.
        
        Previously it was masked because it was not
        IsPlausableSingleWordSection in MSWordExportBase::SectionProperties.
        
        make CppunitTest_sw_ooxmlexport5 \
            CPPUNIT_TEST_NAME=testHyperlinkContainingPlaceholderField
        
        Change-Id: I08be55c6581062eb0fa7f87c787923ca0a2e5f88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189887
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 7605edd81c32b55dd75fe5f718497678d0e10af5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189912
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4536c3d4230c0c52a0d05fb2e184b38b892bb385]

        Resolves: tdf#141033 make combobox max width the same as editboxes
        
        i.e. 30 chars wide, otherwise a long table name will stretch the
        page too wide to be useful
        
        Change-Id: I65151e864f178de0236cb35d133830c8bca95b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189808
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 9fc99321c11202aa92fe6b932c5afd38ffe81e31)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189843
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-19  Michael Weghorn  <m.weghorn@posteo.de>  [76db1af13b394c944876adddd8ddd6bc61a7557f]

        tdf#167930 gtk3 a11y: Keep caret pos when removing selection
        
        Don't always use an index of 0 for the start and end index
        of the new empty selection, but use the current caret position
        instead.
        
        This prevents the cursor from jumping to the beginning of
        a paragraph when removing a selection via the AT-SPI Text
        interface as decribed in tdf#167930:
        
        Example using Accerciser's IPython console with a sample
        Writer paragraph with text "abcdefghijk", with "efgh"
        initially selected.
        
        Previously (unexpected line marked with arrow):
        
            In [64]: text = acc.queryText()
            In [65]: text.caretOffset
            Out[65]: 8
            In [66]: text.getNSelections()
            Out[66]: 1
            In [67]: selection = text.getSelection(0)
            In [68]: selection[0]
            Out[68]: 4
            In [69]: selection[1]
            Out[69]: 8
            In [70]: text.removeSelection(0)
            Out[70]: True
            In [71]: text.caretOffset
        ->  Out[71]: 0
            In [72]: text.getNSelections()
            Out[72]: 0
        
        With this commit in place, the caret offset remains
        unchanged:
        
            In [74]: text = acc.queryText()
            In [75]: text.caretOffset
            Out[75]: 8
            In [76]: text.getNSelections()
            Out[76]: 1
            In [77]: selection = text.getSelection(0)
            In [78]: selection[0]
            Out[78]: 4
            In [79]: selection[1]
            Out[79]: 8
            In [80]: text.removeSelection(0)
            Out[80]: True
            In [81]: text.caretOffset
        ->  Out[81]: 8
            In [82]: text.getNSelections()
            Out[82]: 0
        
        There is also an XAccessibleTextSelection UNO interface
        that SwAccessibleParagraph implements that looks like
        it should be useful to implement the methods to
        add/remove/count selections, but it didn't work as
        expected in a quick test, so the implementation inside
        Writer would likely need to be fixed first if going
        that route.
        
        Change-Id: Ieca9dff66eef366bf2a3845e5fdb53b3bfa70df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189579
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 315c94c91adc6a9e79a78b304e8d2b95e2f45b80)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189609
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [11c6d25f6729028a0ea4ab106ec0f76ddf220846]

        tdf#166842 do not use FillColor==COL_TRANSPARENT...
        
        .. on OutputDevice if that OutputDevice does not support alpha
        
        Change-Id: Ic6e5e2637a30d4588866a10b1519a5ffec3ae21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187180
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 850a98962c0bbf6e11eb1a571a6160d896127167)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189896
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-19  Miklos Vajna  <vmiklos@collabora.com>  [1f86c64fbfd85471ade3cf9b69aa0f8dc4848775]

        CppunitTest_editeng_editeng: avoid gb_CppunitTest_use_library_objects
        
        It leads to ODR violation since 006c8f2d7517965657a9caca1fa7afd757f2f4c5
        (tdf#166882 - sd odf clipboard: fix missing copy/pasted graphic bullets,
        2025-07-30), see
        <https://gerrit.libreoffice.org/c/core/+/188532/7#message-87c0be80800615710c3411e7adf686c6ac1eb36f>.
        
        Change-Id: Ia9ef2fb970d05873d7d40f460c8ed09fb709e4c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188655
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189573

2025-08-19  Balazs Varga  <balazs.varga@collabora.com>  [c807f6f6ea5a6c8b36eb72c5f856dfdd046a9980]

        tdf#166882 - sd odf clipboard: fix missing copy/pasted graphic bullets
        
        Export/import to/from odf clipboard the bitmap of the graphic bullets
        numbering rules.
        
        This is a follow up commit of: 66ed51712bb323bba7d1a0b0d21b256e5f5f9ccf
        (Bug 128046 - List hierachy not maintained on copy'n'paste)
        
        With this extra patch we can also copy/paste the graphic bullets
        numbering rules together with their texts. However, this goes against
        the MS Office and OnlyOffice behaviour, where copying text/paragraphs
        only copies the text, not the list rules. So if we would just want to follow
        that way, it would be enough to remove UNO_NAME_NUMBERING_RULES, EE_PARA_NUMBULLET
        from SvxXMLTextImportComponentPropertyMap and SvxXMLTextExportComponentPropertyMap
        
        See more info in:
        https://bugs.documentfoundation.org/show_bug.cgi?id=166882#c5
        
        Change-Id: I3c0b7389adf0d8efee95cc94f02905c3600342c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188532
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189572

2025-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [a067cfd788121ad4042cf09acf62505caf38b66c]

        tdf#167988: sc: Add UITest
        
        Change-Id: I3ec74308d177bd0a338b346fbbdcf37a27f2cf28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189872
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-08-18  Michael Stahl  <michael.stahl@collabora.com>  [aa59a1b2b8379042d9423593eb4be7f354d1ec43]

        sw: prevent negative width SwTabLeftPortion
        
        This will eventually assert in SwTabPortion::Paint():
        
          sal/rtl/strtmpl.hxx:801: void rtl::str::new_WithLength(rtl_tString**, sal_Int32): Assertion `nLen >= 0' failed.
        
        Also move a comment from its current misleading position (this one is
        using TAB_OVER_SPACING).
        
        Change-Id: I0a8b347f7467fcd7176b75a5a7e5e672ad5e13d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189382
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3bfa151d6f834ef46f1f112ab670cc2d8af6de5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189682
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 790507731174466a8a041ff8052f2f703a73a524)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189873
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [51233dfa4adae23b720bf150b0a62b6459f4baf8]

        tdf#167988: Avoid re-asking the property value, when it has already...
        
        ...been obtained
        
        Change-Id: I0ba8382e8839ca47b86d5ae4671c30006a81441a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187447
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189859

2025-08-18  Justin Luth  <justin.luth@collabora.com>  [20b57f50b1bd6191595d6f3d9a663d04b3b67591]

        fix build: chart2 -Werror=maybe-uninitialized
        
        Not sure why only I'm picking this up on Ubuntu 24.04
        gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
        
        chart2/source/controller/main/ControllerCommandDispatch.cxx:786:49:
        error: ‘nFontWeight’ may be used uninitialized
        [-Werror=maybe-uninitialized]
          786 |                 bool bFontWeight = (nFontWeight > 100.0);
              |                                    ~~~~~~~~~~~~~^~~~~~~~
        libreoffice/chart2/source/controller/main/
        ControllerCommandDispatch.cxx:784:23:
        note: ‘nFontWeight’ was declared here
          784 |                 float nFontWeight;
        
        Added with commit 1160d5b29a9cdae5ec6126663e888b8e5c76aba4
        Author: Attila Szűcs on Thu Apr 24 11:13:08 2025 +0200
            Chart Font sidebar panel
        and commited on May 8.
        
        I'm sure I sucessfully compiled on this machine since May 8,
        but just now I did a make clean and hit this warning.
        I added to autogen.input: --with-distro=LibreOfficeFlatpak
        
        Anyway, now it compiles for me.
        
        Change-Id: I32cd286cdaa607bc4062e9238e9983fd8713f67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187125
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189858

2025-08-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [342ecfbd79e8b371f4ab8b3f58ec6c04b1a0c589]

        tdf#166947 properly fix windows installation sets for aarch64
        
        While https://learn.microsoft.com/en-us/windows/win32/msi/template-summary
        says that the value should be Arm64 for aarch64, the installsets created
        by the baseline fail to install/produce error 1620 on installation.
        The missing bit was that for that to work properly the msi summary
        information table must be at least schema version 500.
        
        That is mentioned here:
        https://learn.microsoft.com/en-us/windows/win32/msi/using-64-bit-windows-installer-packages
        
        Thanks a lot to Mike Kaganski for that pointer
        
        Change-Id: I5fc84f877c6af98c78107ff99920def7053a3950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189870
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-17  Jean-Pierre Ledure  <jp@ledure.be>  [247fab274e1bebd5474dc07ffd8d3a9fc9eab5e4]

        ScriptForge Fix case-sensitive Dictionary
        
        Incomplete implementation of the
        case-sensitivity of Basic dictionaries
        in
           CreateScriptService("Dictionary")
        
        Change-Id: Id12b50fb7b62322909622a19fa191d3110447dae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189792
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        (cherry picked from commit 6e15cf72864f5f66c59473ff86852bb8a2965a94)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189793

2025-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e621e5e651760a71807b2e971f633c49ce02f8b]

        postgresql: upgrade to 15.14
        
        Downloaded from https://ftp.postgresql.org/pub/source/v15.14/postgresql-15.14.tar.bz2
        
        Change-Id: I453e0ffe2bfb2516b646b7f62d97ef7852a2d5eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189646
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9ebc827fd71ab95faf5b523b20f8343682a762d]

        nss: upgrade to 3.115
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_115_RTM/src/nss-3.115-with-nspr-4.37.tar.gz
        
        Change-Id: I285043704622fa23a72bf5fd9932c20c2953d374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189729
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c2d0d27c6c132f6844b8eaaa8e3e05357f6c42d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189733
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-16  Balazs Varga  <balazs.varga@collabora.com>  [9920cf0642b175798afb319cc4b9d8b2bef4e67c]

        tdf#140027 - sc fix inserting rows before pivot table in row 1
        
        Do not copy flags except Scenario when we insert a new row before/
        after. Also remove hard attributes when we insert a very new first
        row on the sheet. (Same what MSO does.)
        
        Change-Id: Ia825683ab221f445b1c9977006b3f1cdffb2ea24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189614
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit f85188809d28dfe01ac8ed8b93e62e17f59773d2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189720
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [909488c67f5a8d50ad2b0ce7f90870776793013c]

        tdf#167956 crash opening a second document with tabbed notebookbar
        
        Revert
            commit 7359e9c742d35c999eb9add524052887805e7b26
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Wed Jun 11 12:35:14 2025 +0200
            tdf#166932 avoid O(n^2) loop in UpdateStylesList
        
        Rather surprising that the original patch worked at all,
        because SwStyleSheetIterator is returning a dummy SfxStyleSheetBase,
        which is updated on every call to SwStyleSheetIterator::Next
        and then freed when SwStyleSheetIterator destructs.
        
        Change-Id: I310731e659b5b1bf74f15918371fdd16934d4c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189634
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189725

2025-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [80bf0371d375859adc7b2dc175190f9d62a20411]

        tdf#167936 crash when opening document from UNO pipe (2)
        
        second attempt at this, the first commit did not catch all the places
        
        regression from
            commit a6ad198d097fb4a503c8d5831d484ff46721134b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Aug 17 13:19:54 2024 +0200
            tdf#158556 use more comphelper::ByteReader
        
        Change-Id: If3ab68f7cf147082ec296d6679d48f15ec0fdcb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189669
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit d0530c1627cab736cf4636b4983b7d2d1f6a8882)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189676
        (cherry picked from commit 1ee8eb866bc7a4ae23107e76af97ac2ab4120e49)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189719
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d3da3fa0146710e6f816df1ef7c787967f3b8bf]

        ofz#437531730 Segv on unknown address
        
        since:
        
        commit 1b68f859034ecc2342a772685d6563fa1ad71f7f
        Date:   Sun Aug 3 01:01:38 2025 +0200
        
            tdf#167616 EMF Add support for EMR_ANGLEARC record
        
        nPoints can be 0 here
        
        Change-Id: If9aa60e8abbf5e58f5224fe62b84163fbae55448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189643
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-08-14  Patrick Luby  <guibmacdev@gmail.com>  [8f749cd4b3b86e5becf91eb038a1de9d9bcff0ce]

        tdf#167916 Skip merging of the macabdrv1 library
        
        macabdrv1 symbols can't be loaded with --enable-mergelibs=more so
        leave it unmerged.
        
        Change-Id: If88059783ebc2be29a9011244947671891801cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189638
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [7a3ce14a4444d4a464676fe54a91169c215cd0dc]

        prevent crash during colorscale calculation
        
        This should fix https://crashreport.libreoffice.org/stats/signature/static%20double%20%60anonymous%20namespace'::GetPercentile(const%20class%20std::vector%3Cdouble,std::allocator%3Cdouble%3E%20%3E%20&%20const,%20double)
        
        Change-Id: Ifb4cc3a8120e9f85eb2029e88268e11f4ae2526a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189613
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 9d03d31dabc31902be18aa6b4905b155d06e3afa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189619
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac5ace88c8500988b9ed4727ff96b2547a0db2d0]

        tdf#167936 crash when opening document from UNO pipe
        
        regression from
            commit a6ad198d097fb4a503c8d5831d484ff46721134b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Aug 17 13:19:54 2024 +0200
            tdf#158556 use more comphelper::ByteReader
        
        Change-Id: I2cc14d0dbb0214dcf54938796eeeebefbd86bd88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189577
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 7e71af5af43da1f7a7cb0bc4d5319f277a67738a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189588
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [18b40b3964f9fc658abbb6cee1d6401842ffe36c]

        tdf#94259: don't use the non-existed chart view during import
        
        During the import process the chart view shapes don't exist yet
        and therefore trying to infer the title size from the chart shape
        can't work. Luckily for the axis titles we can reuse the title size
        that was stored in the file.
        
        There are still small differences in the positioning of various
        objects between Calc and Excel but these are unrelated to this
        problem.
        
        Change-Id: Ibe243e24f7bab3eedd06ee26037bcedeac48354e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189538
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 0bfca02bf492ec917633388aa01421a1e0dad31a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189566
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Michael Stahl  <michael.stahl@collabora.com>  [09d9b522a95f2f4007b8262d55bfc20766aa05cc]

        sw: Backspace/Delete hidden section must delete flys anchored therein
        
        During save to ODF this asserts, or later crashes:
            atrfrm.cxx:3810: void sw::CheckAnchoredFlyConsistency(const SwDoc&): Assertion `std::find(rFlys.begin(), rFlys.end(), pSpz) != rFlys.end()' failed.
        
        Initial idea was to fix this by changing SwWrtShell to not use the
        ArtificialSelection mode when a hidden section is selected - this fixes
        the initial problem but there is another one!
        
        Because ArtificialSelection is now also set in
        SwXTextRange::DeleteAndInsert() and SwXTextCursor::DeleteAndInsert(),
        the crash can also be reproduced by calling setString("nonempty") on a
        cursor that selects multiple nodes with an object anchored on a middle
        node.
        
        So better to fix this in SwUndoSaveContent::DelContentIndex() by moving
        the Replace check into the IsSelected functions, and to ignore *only*
        flys on the start and the end node of the selection, so flys anchored on
        the middle nodes are now deleted.
        
        In any case for Undo to work a SwHistoryHint must be created for these
        which ExcludeFlyAtStartEnd prevents so it's a different case.
        
        This covers all the initially intended use-cases of
        DelContentType::Replace, which actually only were 1-2 node selections
        anyway (limited by UI); the arbitrary-sized selection cases were from
        later re-uses of the flag for other use cases, and in both the Backspace
        and the API case the possibility of flys anchored on middle nodes was
        unfortunately missed.
        
        Currently SwUndoSaveContent::DelContentIndex() was the only caller of
        the IsSelected functions that could see a DelContentType::Replace.
        
        (regression from commit 85376a02348810812d515ee72140dbf56f2b6040)
        
        Change-Id: Ifc5aad47e80c638d4e7cb5f66c035fdf1e34b89f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188251
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>
        (cherry picked from commit 40d659647d3dbb5e316963968947272f0a71104d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189438
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [098270e2c013300d5a97ee2f5b39f29f735d99b0]

        cid#1660455 Overflowed constant
        
        Change-Id: Idebcb5b87d6720c2e1b468c73bc823656dfda59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189499
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 7e3950902feb78ea8545845f056a380495c7b2f3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189528
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-14  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [96cca31589adf074326bbb610c7f0841d05e1420]

        tdf#94627: handle range name references in formulas during XLSB import
        
        Change-Id: I9e4f66e633740950cb568a589fd461a2b737c157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189450
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189526

2025-08-14  Mike Kaganski  <mike.kaganski@collabora.com>  [f9914a8403317f84b22894fe972da029d1140614]

        tdf#167849: unit test
        
        After commit 87ef004115d07c16fe4899b3d423cc16a12a0fce (tdf#167849: don't
        release embedded fonts in WinSalGraphics::ClearDevFontCache, 2025-08-07).
        
        Change-Id: I4b2ff7e8c3a9bd71befe537d76308e18968c99c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189145
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189480

2025-08-14  Mike Kaganski  <mike.kaganski@collabora.com>  [6444867c41304fee4432bc50448fe48f61c5bf1c]

        Use Gdiplus::PrivateFontCollection to obtain family name from TTF
        
        This avoids the path length limitation of CreateScalableFontResourceW,
        which manifests e.g. in CI - see https://ci.libreoffice.org/job/gerrit_windows/203249/console:
        
          warn:vcl.fonts:3512:11352:vcl/win/gdi/salfont.cxx:962: CreateScalableFontResource failed for C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\tempdir\tesE8AE.tmp Manbow Solid0.ttf C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\CppunitTest\sw_uiwriter10.test.user\user\temp\embeddedfonts\fromdocs 0
          warn:vcl.fonts:3512:11352:vcl/win/gdi/salfont.cxx:994: error extracting font family from file:///C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CppunitTest/sw_uiwriter10.test.user/user/temp/embeddedfonts/fromdocs/Manbow Solid0.ttf
        
        The implementation is put into vcl/win/gdi/salgdi_gdiplus.cxx, because
        the GDI+ headers create conflicts when put into vcl/win/gdi/salfont.cxx;
        the file name of salgdi_gdiplus.cxx looked relevant (although I don't
        see any actual GDI+-related code there).
        
        By the way, this new implementation seems to also perform better: in a
        test, it finished in ~3 ms in a dbgutil build, while the previous code
        took about 8 ms in an optimized build.
        
        Change-Id: I95b09847e2fcba13489050d3a61a56776d8c8e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189186
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189527

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b236227976b3b5c78afc916ea4acefd4b4b8c58]

        cid#1659808 Overflowed constant
        
        Change-Id: Ifd0e263baa9c6d2e289d0a6e1be3498c43e27594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1d5a01da2f0e99d2a95ced541b9c4ee6d3fa6eff)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189525
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [07f1d12f67dfcd447a75dde2b96d7c1e76432e18]

        tdf#108244: generate note caption always at the beginning of the export
        
        Change-Id: I160f57cf43227e7a432536134da242a4b3053d4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189453
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit beeb2acc1c6ce3cf9b076b8e164fdbe79a0a7b51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189474
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa13ea790a6aa8462d9698d828638d637a4bfacc]

        cid#1660121 Resource leak
        
        and
        
        cid#1660097 Resource leak
        
        Change-Id: Ife9963022f93f1288439928156a10a10dc25da9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 96939c730332d4f65d02bd633bb0c8bf1bbad5d4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189491
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae0897f051e45a08c3d53c9973b9a8049eecc974]

        cid#1660391 Resource leak
        
        Change-Id: Iddabd4ab9c06f508bd328d34013d038ebc039020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188590
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 5bae1a972389eba54d2806171c226649a23c2a57)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189493
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [00f074d7187fd8eb1486fadaa14eb5e8132a96d2]

        cid#1660007 Overflowed constant
        
        Change-Id: I25ce37f3b792f21284a3b12c34eaeff9a378b37b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188718
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit cb78333ec14a7664f2fae9bd6a9ef6b32e45cfe0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189489
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [926d43c7cfef2e8c27aa5a83b74935665eaf3eb4]

        cid#1660282 Resource leak
        
        this all looks a bit error prone, but minimally fix this.
        
        Change-Id: Icfaf38c3c2028cc591f5c4bae0317587eccf5d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188591
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit c6d852d6ee54e3261103f253267bd676195b327a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189490
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Mike Kaganski  <mike.kaganski@collabora.com>  [6f6c4408bb9dd6e9bad72e76f9bb80110a534dfc]

        tdf#167849: don't release embedded fonts in WinSalGraphics::ClearDevFontCache
        
        Commit 8e63934c398dd5065f3589c8a7d1b3008f5514d1 (WIN separate LO shared and
        embedded fonts, 2019-07-05) made the call only release embedded fonts, not
        all temporary fonts. But embedded fonts must not be released there, too:
        they are not re-added back by anything. Therefore, any reload of font data
        drops all open documents' embedded fonts: this could be opening another
        document with embedded font, or a user installing a font in their system.
        
        Clearing embedded fonts itself could be a useful operation, performed when
        a document ownong the font is closed. But that must be implemented properly
        for all platforms, counting references for each such font; additionally, it
        could handle restricted fonts correctly, not showing them in font list.
        
        Change-Id: I239f15cef64c94522e70e17e295b572664317bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189100
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189479

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f09d83a7ac10374b0a81f30ec65cd551fcdb742d]

        cid#1660127 Resource leak
        
        Change-Id: I789793eecc6642f786edd43c30fb6a05feded4bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188819
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e6f5e1e45b882ac98f6d31882ebb6e950994d27d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189487
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b8315ebcef9143a6c00432c2982d47710a9d7ce]

        cid#1659773 Overflowed constant
        
        Change-Id: I4a559b64cca08fcf45716469807b3a40f0f65a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188711
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit b17ea316f2e23e1569aacebb719afa39b26e8b1f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189488
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fae1a210dcc817862045e7db6edf9eabe60d7557]

        cid#1660822 Different smart pointers managing same raw pointer
        
        and
        
        cid#1660800 Different smart pointers managing same raw pointer
        
        Change-Id: Ifea613279119ab411414b250a029e0e231b5def8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189486

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6f97dc4ff5249637650b256ffa7cbd80a151985]

        expand default argument of unusual SetPara method
        
        Change-Id: I8e6212f1e2b9905929e967ba3da1869d06c43d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189485

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f5dee7f91e47c435c13797ba5848a96fa481956e]

        cid#1659628 can only reach this line in the case of a caught exception
        
        so move it into that block protected by the rGuard.lock()
        
        Change-Id: I8e0bde5a7de6ec5428b405f734d6c8e54fb1645e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188994
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit a2bbf65bb44229cadd1bc325ef174322b625a36b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189483
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [62ec25eac3fdb06435750d323db3e1c693dfe682]

        cid#1660111 Overflowed constant
        
        Change-Id: I5afba320e5792d7b491d704c859e2b60a2b64f8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189274
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit d0b48fac7e8f73bd058c83d76580496be2c54fe6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189360
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30bdffb69d8dba0d453aefd488c7d04e58e78216]

        cid#1660214 Overflowed constant
        
        make types consistent here
        
        Change-Id: I9e0b44d53d0affa2220f956dcaef8a613ff51e7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e3a9f2bb2f370e76fe641e7de743bf3ed8fc00da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189482
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9855b5818f09d91e5af06a2223688e4fefc5309d]

        cid#1660359 Overflowed constant
        
        Change-Id: I8bfa4d1280f5173d811314ff6354e57db3d2fcba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189410
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 44ffdd91804336ba5bcdbad6a1bcc1747c86d504)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189481
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [447ab2b420d16b98c48809ee968c91136aa385c6]

        tdf#87058: handle column label references after inserting rows below title
        
        Change-Id: I49d066e6466b3bd1368903a150a596d8dc40226e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189425
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit d85334664cae22fa7bbc3852d260c0ca7ad704a2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189475
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Rene Engelhard  <rene@rene-engelhard.de>  [d57d3e9812159ff6e8df788049c8a903e1517b7b]

        add EUR for Bulgaria/Lew
        
        Bulgaria will join Eurozone 2026-01-01 at which time around the default
        needs to be switched
        
        see https://www.ecb.europa.eu/press/pr/date/2025/html/ecb.pr250708~b9676a9fa8.de.html for the conversion rate
        
        This is the < 26.2 version including the euro wizard (cf.
        b1a2f727ca99ecd3402d4b051b99cbfd24266e59)
        
        Change-Id: I840ddda4308549703c53f998812848888dd830f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189279
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-08-13  Rene Engelhard  <rene@rene-engelhard.de>  [61bf594223d8952b8db0267306192a55d3f92d9a]

        fix typo
        
        for completeness...
        
        Change-Id: Icdd61311498538d28fc27975dfe6bb20d9a0417b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189280
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2ef27823cacd4cf788b0d5236cf721bbce62fbe0]

        cid#1660069 Division or modulo by float zero
        
        and
        
        cid#1660394 Division or modulo by float zero
        
        Change-Id: I10b0b100ff3fe99682bf4e0da6bc9ef3e356a996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189257
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 56c55dceea7ddb15bf42e68d58a2eb23bb5bcd05)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189293
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d8f574027041ae58111df4252011b8c00d498ff]

        cid#1660410 Overflowed constant
        
        Change-Id: Ib1c9360df3667de3f99fde9520ee4eecc06cc502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189275
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit ef04435193dd01975446bfbb2f5384eab95ed898)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189361
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-13  Michael Stahl  <michael.stahl@collabora.com>  [8c6129cfe0669171d502d6662b2b4e31d8ac5ca0]

        tdf#167910 filter: xhtml: try to handle combinations of underline and overline
        
        Change-Id: I2dc735157d5278fb8e95881ef967443a48fee10f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189416
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189441

2025-08-13  Michael Stahl  <michael.stahl@collabora.com>  [809c6ea37f3a6b06569bdf3f9049bf2dd8238cc6]

        tdf#167910 filter: xhtml: simplistic conversion of overline to CSS
        
        Change-Id: Id577cf71cb383260c4c66ab929794c02911d01c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189415
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189440

2025-08-12  Michael Stahl  <michael.stahl@collabora.com>  [b75c382be45616a29ffc67cec47d8772e86a74b7]

        tdf#166953 writerfilter: add column width when adding extra cell
        
        It's not so obvious how the cell widths are set...
        
        1. The table gets USHRT_MAX as initial width
        2. All the cells in the table get USHRT_MAX/nCells as initial width
           (this is SwFrameSizeItem in box item set)
        3. Table property "Width" is set -> this scales all the box widths
        4. Row property "TableColumnSeparators" is set; this is *relative* widths
           to a hard-coded value of TableColumnRelativeSum=10000
        
        Evidently the result is bad if the number of separators is too low.
        
        (regression from commit 038473595ed266d15a788d8f97781cbaf066cfe7)
        
        Change-Id: Ie71889a074bff43d8f0c34ccefb4d30ed0a9f0c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188153
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 23e308d5e02ee45ef589d3fddf53dabaa12aadfe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188207
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189418

2025-08-12  Michael Stahl  <michael.stahl@collabora.com>  [a3821860987575d8daa4b676bdd1c8130a4943d0]

        sw: fix rounding problem in lcl_SetTableBoxWidths2()
        
        Prevents bunch of warnings like:
        
            swnewtable.cxx:2525: Line width differs from table width: 14148 current [0]: 14144
        
        Change-Id: Ic24096d91ad6646635038a06b74251e3bcbad134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188152
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 65987cb2f8ed6b6cf67032cbce4c5e58f2577803)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188202
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189417

2025-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54349933046250462e442461e2dd0f2f89819618]

        null deref of pActualSection seen
        
         #0  0x00007b8ff1659933 in std::__uniq_ptr_impl<SwActualSection, std::default_delete<SwActualSection> >::reset (
             __p=<error reading variable: Cannot access memory at address 0x0>, this=0x7fff18bf8ff8)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:201
         #1  std::unique_ptr<SwActualSection, std::default_delete<SwActualSection> >::reset (
             __p=<error reading variable: Cannot access memory at address 0x0>, this=0x7fff18bf8ff8)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:501
         #2  InsertCnt_ (pLay=<optimized out>, pLay@entry=0x5fad9100, pDoc=pDoc@entry=0x5e955800, nIndex=..., bPages=bPages@entry=false,
             nEndIndex=..., nEndIndex@entry=..., pPrv=<optimized out>, eMode=<optimized out>)
             at sw/source/core/layout/frmtool.cxx:1915
         #3  0x00007b8ff165ac01 in MakeFrames (pDoc=pDoc@entry=0x5e955800, rSttIdx=..., rEndIdx=...)
             at sw/source/core/layout/frmtool.cxx:2211
         #4  0x00007b8ff1862f31 in SwUndoDelete::UndoImpl (this=<optimized out>, rContext=...)
             at sw/source/core/undo/undel.cxx:1184
         #5  0x00007b8ff18645aa in SwUndo::UndoWithContext (this=0x62c9c1e0, rContext=...)
             at sw/source/core/undo/undobj.cxx:225
         #6  0x00007b8ffecc6f91 in SfxUndoManager::ImplUndo (this=0x5ea06758, i_contextOrNull=0x7fff18bf9580)
             at svl/source/undo/undo.cxx:732
         #7  0x00007b8ffecc7489 in SfxUndoManager::UndoWithContext (this=<optimized out>, i_context=...)
             at svl/source/undo/undo.cxx:682
         #8  0x00007b8ff184ddd8 in sw::UndoManager::impl_DoUndoRedo (this=0x5ea06750, undoOrRedo=sw::UndoManager::UndoOrRedoType::Undo,
             nUndoOffset=<optimized out>) at sw/source/core/undo/docundo.cxx:700
         #9  0x00007b8ff1591a3b in SwEditShell::Undo (this=this@entry=0x5eaf4900, nCount=nCount@entry=40, nOffset=nOffset@entry=0)
             at sw/source/core/edit/edundo.cxx:143
         #10 0x00007b8ff1f58262 in SwWrtShell::Do (this=this@entry=0x5eaf4900, eDoType=eDoType@entry=SwWrtShell::UNDO,
             nCnt=nCnt@entry=40, nOffset=<optimized out>) at sw/source/uibase/wrtsh/wrtundo.cxx:45
         #11 0x00007b8ff1d4934a in SwBaseShell::ExecUndo (this=<optimized out>, rReq=...)
             at sw/source/uibase/shells/basesh.cxx:669
         #12 0x00007b8ffe7fb3ef in SfxDispatcher::Call_Impl (this=0x5e9cb020, rShell=..., rSlot=..., rReq=..., bRecord=<optimized out>)
            at sfx2/source/control/dispatch.cxx:255
         #13 0x00007b8ffe802af7 in SfxDispatcher::Execute (this=0x5e9cb020, nSlot=<optimized out>,
             nCall=nCall@entry=SfxCallMode::SYNCHRON, pArgs=pArgs@entry=0x7fff18bf9ca0, pInternalArgs=pInternalArgs@entry=0x7fff18bf9c30,
             nModi=0) at sfx2/source/control/dispatch.cxx:813
        
        Change-Id: I3e3bd43f853521163581a7e2d575c1ebe7dc2bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189352
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 4d48d43a68b5cdda15092d0ae9b25d48bce6d1de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189405
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-12  Oliver Specht  <oliver.specht@cib.de>  [1ae15f53c03c966776c46ce4dc87aafea751337e]

        tdf#164676 fix modify handler in variables tab page
        
        Change-Id: Ifb5e71bd14b7938d714873616dd63794e8e1d87b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189393
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>
        (cherry picked from commit 2081fc359b25b7e4262880cccf7551a4632b3b35)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189420
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f05e09bd0e54dc0bd1102c15e2ee62a7a92d9fd]

        tdf#167901: Revert "tdf#167075: init doc shell before pasting as png/bmp"
        
        This reverts commit eb99e28a92517cac9534a6a52b9266777f735ce5.
        
        Reverting for now until I find a better solution, specially towards
        LibreOffice 25.8.0. The fix for tdf#167075 only works when working
        with one table but it crashes when working with more than one table,
        so it's better to have tdf#167075 reproducible than a crash
        
        I'll add a test in a follow-up commit
        
        Change-Id: I1407c430792f23ae51eafbe39ee52b13217842b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189380
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [9915e4469c8657592725432beae8638bb3f823f4]

        related tdf#167859: fix logic
        
        after
        commit 4862b5efbd6724d01e04b0951188f2a18c9362e8
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Fri Aug 8 10:51:41 2025 +0200
        
            tdf#167859: check xChartType
        
        Change-Id: I58ac276a21e6d6ef08b831fd723783ddb68410a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189364
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189375
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e7a3b308fdd787c7913197c397df5943fca8dc08]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 934e075aff11f8218091de6da6ac497ee002b188
          - update translations for 25.8.0 rc4
            
            and force-fix errors using pocheck
            
            Change-Id: I119a7ec7de74160aef23ac9ae3ee130800bd4f19
            
2025-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33e5950bd1549c0b2e45c00e209daa20910096bf]

        cid#1659737 Dereference after null check
        
        Change-Id: I2a3da97e7a9bceedb3b9940d5625010ab215fdaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189334
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1313be884c4ded639a5f53694c82a1cf2e77fe70)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189403
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-12  Stephan Bergmann  <stephan.bergmann@collabora.com>  [d4897dd10073a8e52ea5094183f20bbe749bfe88]

        Flatpak build needs --without-system-colamd now
        
        ...after e4dc378991002cdc64909af581053d588cc92a0a "implement
        --with-system-colamd (for internal lpsolve)"
        
        Change-Id: Ied16c6e9c9e80ea2c0f0df471fe03980f5cdcd4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189383
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
        (cherry picked from commit 2e87ee28fcf82e4235920402fc3e2ddd23cbff51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189388

2025-08-12  Regina Henschel  <rb.henschel@t-online.de>  [a98b1523141a8c3bed01ee9781f6b4844960bd73]

        tdf#166647 avoid duplicating slideshow user paint
        
        When a user enables 'mouse as pen' before starting the slideshow, then
        his paintings are saved as persistent shapes when he exits slideshow.
        These shapes were then converted back to paintings when the user starts
        the slideshow again, so that they are visible againg.
        
        But these old paintings were treated as new paintings when the user
        exits slideshow and were then saved again as shape to the page although
        the page contains these shapes already. Thus with every new start and
        exit of the slideshow the shapes were duplicated. Because the duplicates
        are at exactly the same place as the originals, you do not notice it
        immediately. But you can see the duplicates in the Navigator and notice
        it in the file size.
        
        The fix introduces a flag that is set at the paintings from the existing
        shapes when the slideshow is started. This flag is then used to skip those
        paintings from converting to shapes when slideshow is finished.
        
        Change-Id: I93324d157b1b802d7b8e24858034d2fdc5d71b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188364
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189365

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b285b73c6739d08fc6e422ff147e69c0c660390b]

        tdf#162342: workaround out-of-order context stack pop
        
        Turns out, the context stack is populated in one order, but emptied in
        another. Commit e63a75e00dcd797b0bd061add3c72dcb7b353007 (tdf#158586
        writerfilter: RTF import: fix \page \sect \skbnone, 2024-02-01) added
        yet another case, which resulted in m_pTopContext being empty at the
        moment when section properties should have been applied (see "needed
        for page properties" comment in DomainMapper::sprmWithProps; that code
        wasn't reached because of (!rContext) check above).
        
        But that isn't the only case; I tried to assert in non-RTF cases, and
        it fired in `make check`, too.
        
        So here is an UGLY HACK. I repair the stack when it's popped out of
        order. This pleads for a proper fix, but the effort will be far from
        trivial.
        
        Change-Id: I1a5c646188f3da4842d103b8edeb11b801fea830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188449
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189308

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [8a2d938e2dc9a8f080c96961489c0233d19ddc89]

        tdf#165564: refactor the "Removes additional spaces in export" part
        
        Commit 90ce84a5dd371c804af19e97896a5e19a3ebf8ca (tdf#165564 RTF:Fix
        export and import of footnotes/endnotes, 2025-05-08) workarounded
        an extra space added after \super keyword, when EndRunProperties()
        didn't produce an output. To do that, it introduced a return value
        from EndRunProperties, checked in TextFootnote_Impl.
        
        This change simplifies this, reverting a part of the said commit,
        which added that return value, in favor of dropping an unnecessary
        space after {\super, which was retained for some reason in commit
        49877dc91b2f91baa656facd462ac1b1e832f182 (sw:rtf - timely export
        of footnote char properties, 2017-08-24). There is no need in the
        space between keywords - only between the last keyword and text.
        
        Change-Id: If13bf760feb9cb42cb39fc7de39eed6944a869ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188432
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189307

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [320f2d4d55831127aa749f7858ac11ee3a504ffe]

        tdf#167569: Reimplement RTF character formatting output
        
        The rules for outputting character-level formatting to RTF are utterly
        convoluted. The formatting may be output in different context (like in
        style definitions, runs, etc.);  and it consists of two distinct parts:
        some keywords are independent of current run's script; other depend on
        the script, and may require either a "normal" keyword, like \fN, or an
        "associated" keyword, such as \afN.  The order of script group keyword
        blocks (\loch, \dbch, etc.) is also important.  It is documented (very
        poorly) in "Rich Text Format (RTF) Specification, Version 1.9.1", sect.
        Font (Character) Formatting Properties.
        
        Previously, we collected character formatting, encoded as RTF keywords,
        in the order of iteration of text properties in the export code.
        
        Commit f97af19460fbd7483a0e1c1d0137e814f5390e69
               tdf#137894 separate associated character properties
               2020-11-25
        had split keywords of different script groups into separate strings in
        an attempt to combine them eventually in a sane order according to the
        script. However, the buffers were still filled by the keywords as they
        appeared in iteration, when the script of the run was still unknown. A
        decision was to always emit \loch keywords as "normal", and all others
        as "associated" - which was wrong e.g. for RTL and CJK runs.  It could
        happen to look better in LibreOffice in some cases; but it would still
        look differently in Word. This can be seen in the bugdoc in tdf#141671,
        which looked OK in LO after the fix to that bug, but not in Word.
        
        This changes how we produce character formatting keywords.
        
        1. Character formatting is now collected separately from block-level;
        2. It is stored in an SfxItemSet, and newer properties overwrite older
           propertiew with the same which id, avoiding some redundancy;
        3. The generation of the actual RTF markup is therefore delayed, which
           means that the "current" position in the exported document (as seen
           e.g. by MSWordExportBase::HasItem) could change by that time. Since
           handling some properties needs other accompanying properties  (e.g.,
           handling RES_CHRATR_UNDERLINE needs RES_CHRATR_WORDLINEMODE), those
           accompanying items are collected together with the primary item.
        4. When collecting the accompanying data, side effects could appear if
           they are put into the same SfxItemSet.  E.g., RES_CHRATR_ESCAPEMENT
           needs RES_CHRATR_FONTSIZE;  but the latter, when present in the set,
           will itself create RTF markup for font size. So it must be added in
           a way to avoid output of its RTF markup, when the run itself has no
           explicit font size set. For that, a parent set is introduced; items
           stored there will be reachable, when "search in parent" is used.
        
        The function creating the resulting RTF markup tries to follow specs wrt
        the order and use of associated keywords for scripts. Of course, I could
        be wrong in the interpretation of the spec. At least some documents that
        I tested using Word seem to improve with this change.
        
        Change-Id: I3761c4c84f137be8ff9de0eec5ed8b229146325a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188420
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189306

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [5484fb8ef11d5dd843493f02e27cee3651156abe]

        Return sal_Int32 from RtfExport::GetColor, for ease of use
        
        sal_uInt16 requires explicit cast to convert / append to string.
        
        Change-Id: Iaa900a570f2c5e096415b5c17357484fd5b8f754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188052
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189305

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1749f616197fc10100ceacd974b4e45ce8a02bcd]

        tdf#167679: RTF already can export \brdrnone
        
        In commit f84b33275f6cce21e93e5dd20f3de5df84df0276 (tdf#129522
        ww8import/export: allow char shadow_NONE overrides, 2020-01-04),
        export of char shadow was implemented, which made CharBorder to
        be called for missing borderline. But it made an exception for
        RTF, because at that time, its code couldn't handle that.
        
        In commit eca3ce35fe9a346965a32f42d02cb6d3f5a3982f (tdf#129631
        writerfilter,sw: RTF import of invalid border..., 2022-08-11),
        RTF export got ability to handle that.
        
        Removal of the exception for RTF fixed missing export of "no
        border" and "no shadow" character formatting.
        
        Change-Id: I5f23b09558d32b403e0c26c727ee01f79374e54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188418
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189304

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [66a612ee153e64afd5fe7024555be960e56c0a89]

        tdf#167661: collect bullet fonts before exporting font table
        
        The problem was, that InitFontTable, used to collect all fonts used
        in the document, didn't handle bullets. When font table was written,
        some fonts needed for bullets could be still missing from it; only
        when writing list levels, these fonts were added to maFonts.
        
        It might seem that that is a bug in SwDoc::ForEachCharacterFontItem,
        called from InitFontTable. It might be; and maybe even needs to be
        addressed at some point (though I don't know which side effects it
        could have). But in the case of export to RTF, this wouldn't fix it
        completely, because there is some special processing of bullets in
        MSWordExportBase::SubstituteBullet, which might change the exported
        font name; therefore, it could happen to still be not covered by an
        iteration over actual document's fonts.
        
        1. Extract the code filling used numbering rules in GetNumberingId,
        into a separate function (EnsureUsedNumberingTable).
        
        2. Extract the code getting bullet string + font in NumberingLevel,
        into a separate function (GetNumberingLevelBulletStringAndFont).
        
        3. In wwFontHelper::InitFontTable, use these functions to iterate
        the used numbering rules, and handle fonts of these. To do that,
        let the function take an Export object.
        
        Change-Id: Ib7ecdeb9908cd3bd53346ccb035d623fa603db0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188277
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189303

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [77db5679983cc58603c2001a9b8dfcea7faa8574]

        tdf#167660: export \uN as signed 16-bit values
        
        This is as specified in Rich Text Format (RTF) Specification, Version 1.9.1,
        "Unicode RTF"; and this matches what Word outputs.
        
        Change-Id: Ia1b7c2dc40d5908a78a30ea249c1ec0a13945b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188257
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189302

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [d12b0a80f29bea869b0f9f109592e5401e9a53dc]

        tdf#167538, tdf#167540: better check if the line is dummy
        
        The check in SwTextFrame::PaintExtraData is made the same as in
        SwTextFormatter::CalcRealHeight (except for bNewLine, which was
        specific to the latter). It allows to recognize real dummy lines
        uniformly, and produce line numbering for trailing empty lines.
        
        Change-Id: If2bad4b998b0c48f8f79da52a081e6df7565eee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188016
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189301

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a84e0fd218ad6824326b980a63806d4684af29b0]

        tdf#167535: Ignore dummy anchor nodes in line numbering (take 2)
        
        Commit 441aed20b95ee40dec1df72fb8e8167d0e48c0c4 (tdf#167379 sw floattable:
        make dummy paragraph from DOCX import less visible, 2025-07-10) introduced
        dummy nodes as invisible anchors for floating tables without normal anchor
        nodes. These nodes are not part of actual content; use suppressLineNumbers
        property in OOXMLFastContextHandlerTextTable::lcl_startFastElement, which
        avoids their use in line numbering.
        
        Change-Id: Id1703c10ede6960499e08758c250d6d561d1f07f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188011
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189300

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [40ce124cc68248527b0c1ea5b5c7662132c0600a]

        tdf#167526: write floating tables anchored to dummy nodes immediately
        
        Commit 441aed20b95ee40dec1df72fb8e8167d0e48c0c4 (tdf#167379 sw floattable:
        make dummy paragraph from DOCX import less visible, 2025-07-10) introduced
        dummy nodes as invisible anchors for floating tables without normal anchor
        nodes. Commit c9851022d102a2abfc16c033c0249f24573300e7 took care to avoid
        their export to DOCX, not calling OutputTextNode in OutputContentNode for
        them, and handling their tables as soon as the next text node is handled.
        
        However, this didn't work, when the next node wasn't a text node. In that
        case, the dummy paragraph wasn't detected as such in CollectFloatingTables,
        and got exported as normal; and after reload, it appeared after its table.
        
        Fix that by making sure to write floating tables as soon as the dummy node
        is handled.
        
        1. Make previously static checkAndWriteFloatingTables a virtual method of
        AttributeOutputBase, implemented in DocxAttributeOutput.
        
        2. Let MSWordExportBase::OutputTextNode check if it handles a dummy node,
        and if so, call AttrOutput().CheckAndWriteFloatingTables, and return.
        
        3. Revert to calling OutputTextNode in MSWordExportBase::OutputContentNode
        unconditionally.
        
        This simplifies the logic a bit, avoiding the need to care about postponed
        actions, potentially in multiple places.
        
        Change-Id: I41b57103fc8b4522e3b5b1810389db078719b9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187975
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189299

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0aeaa35972a3915491ca288d201e30246bf916d8]

        tdf#167569: RTF: Export paragraph mark properties
        
        In commits:
        
            5ba30f588d6e41a13d68b1461345fca7a7ca61ac
            tdf#64222 sw: better DOCX import/export of paragraph marker formatting
            2019-09-17
        
            6e1c8bcec511444d2d51c5c5143be56d1900e5e6
            tdf#150613 sw: better DOC import of paragraph marker formatting
            2022-09-20
        
            6249858a8972aef077e0249bd93cfe8f01bce4d6
            sw: ODT import/export of DOCX's paragraph marker formatting
            2022-12-19
        
            a25eda715591cfa96136bcfd95360156516239d1
            tdf#131386 writerfilter: RTF import paragraph mark formatting
            2023-01-13
        
        import and export of paragraph marker (as defined by Word and its file formats)
        was implemented, except for export to RTF. This change implements the latter.
        
        Change-Id: I2208a416377be42d2e6c5d5042cb92bc8109b4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188084
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189296

2025-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [73e319b84a6c1ff7c4255aac5fcb1aa20f487196]

        tdf#167512: don't avoid resetting paragraphs' properties in fly
        
        Commit 5bbc027d5dae3472223538b13933ff821e027737 (cws-vmiklos01.diff:
        Better RTF export filter, 2010-09-17) introduced RtfAttributeOutput
        and its StartParagraphProperties, where output of \pard\plain was
        skipped when in fly. The reason likely was, that at that time, text
        boxes were output using an "old-style" method, where text box was
        purely a paragraph-level formatting. This created a problem: list
        settings weren't reset for following paragraphs, so lists continued
        incorrectly.
        
        Commit d53dd70b15f0e3f7c8a05a93f8fcd70e1147c1f7 (sw: rework RTF
        export of text frames, 2013-04-12) reimplemented text box export to
        use a "new-style" frames (using \shp ... \shptxt markup). This made
        it possible to restore resetting of paragraph properties, without
        breaking text boxes. This is done here.
        
        Change-Id: Idaabece2a658845906463c942aad45a142f87633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187920
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189295

2025-08-11  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [cdf04ce1474fdba48018752715202d86455b8238]

        tdf#103859 EMF Fix quality of EMR_ELLIPSE by using Bazier curve for drawing
        
        Change-Id: I7eaca22dac921229b4a88e07739d379948730bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189024
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Jenkins
        (cherry picked from commit ccf1476f70d39797f968444ac585c19b0edbff36)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189215
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d66e7ad9c66c979135cc648e649456792c3fb1ee]

        cid#1660818 Dereference null return value
        
        Change-Id: Iee0004db9ad48e8753c5570fe6c8ebc31b98fd1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 39f512b4e384b39730a637392ff48897eee21331)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189291
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f84f585c3eb5ade04d7f8f29564300669c5e5b3]

        cid#1660804 Dereference null return value
        
        Change-Id: Ib53ec6473809dc99ada574827a378a0ab7b664d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189264
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 1d3efa2ada37940200f3eed298c9f859a592ae77)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189289
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-10  Samuel Mehrbrodt  <samuel.mehrbrodt@collabora.com>  [ef51b4573d5475893e13723b35ccb8e08a903d50]

        tdf#167845 Don't preselect the template path
        
        When saving a doc which was based on a template,
        don't preselect the path where the template was stored.
        Instead, preselect the last used path from the Save dialog.
        
        Change-Id: I484e5a908cc739618683b6c2e2b4a7fda4a66232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189053
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@collabora.com>
        (cherry picked from commit a4349c502eb2169b3f83d58e49a7871a341daf76)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189072
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [71c6a452de79f7633ec9ae70b42114d58e313d8d]

        Fix a memory leak
        
        Value returned from CommandLineToArgvW must be disposed using LocalFree.
        
        Change-Id: I7abd2f3884620952aecd34bd66a9a1df63dfcb88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188225
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 12149d9f312d580d8c4b1b571d6dda0a6294101d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189298
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [8cc5eaffce520ce93e81e108c2c28dc301d06c8d]

        tdf#167875: check GetLower()
        
        After
        commit 1b03f6ea0362a38c6c4e5e767fcb5cf87ddd28dd
        Author: Ujjawal Kumar <randomforest33@gmail.com>
        Date:   Thu Mar 13 20:42:21 2025 +0530
        
            tdf#149825 Add command to insert a paragraph break before table
        
        Previously, I pushed a blind fix for it in
        commit 22a4e2df6f521a5baf1abfd9d4bf6da116933ed8
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Thu Aug 7 19:59:47 2025 +0200
        
            crashreporting: check Lower()
        
        Change-Id: Ied2e14224adcf71c0c438df13506e684136b7f6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189278
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 48ff1bbbe90001716e7421c5ebd30e2e635fe99e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189287
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [67f1a0df0cd597e5d2732a04f2f964d58813d58a]

        poppler: upgrade to 25.08
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.08.0.tar.xz
        
        Change-Id: Ifdc52a9b6d1412d3fe70baa2e9fb367a476c05fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189028
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 3fe840e33667c12d615774cd0a3a5aaa97f7b547)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189039
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [e6f843c1c5c2cb075ff0ae358735c5801e56f51f]

        tdf#167591: Convert date string to date early
        
        To insert a default value, ODatabaseForm gets its value from column
        properties, and passes to XColumnUpdate. The problem appeared when
        the default was a localized date string, like "20/07/25".
        
        The string was set as the value of a ORowSetValue; then, when its
        value was requested, its getDate() called DBTypeConversion::toDate,
        which only handles ISO date strings. But for correct conversion, not
        only the string is needed, but also its format key. This information
        is already lost at that point. The conversion failed, and the result
        date was invalid, somewhere in the beginning of CE.
        
        Try to overcome this problem by converting the default value from
        date string to date(time) where all the information is available.
        
        Change-Id: I73e96e433895da18cbf6145ffc26b16fa4844452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188093
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188682

2025-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [5633027b0d1af9c627d250b32284901d9bae20c7]

        Flatten ODatabaseForm::reset_impl a bit
        
        Change-Id: I47ad680ef80ed5ed40b329ff83d2c38506a64d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188085
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188681

2025-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [86c9b2166ab66882563839f06a8478b85274b109]

        Related: tdf#167591 Make STANDARD_DB_DATE more standard
        
        For some reason, STANDARD_DB_DATE was 1900-01-01, which differs from
        the most used epoch of 1899-12-30 (see e.g. the default initializer
        of ImpSvNumberformatScan). This was triggering tdf#167591, where the
        correction added two days of the difference to the date entered into
        the default value box.
        
        I couldn't find how/if this value could get exposed to API; so let's
        try to standardise it a bit.
        
        Change-Id: I9207cbe3a5a91ca63f3f97792da0c5ad2931ffa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188092
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188680

2025-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [ff73678db107abc1038cfe396e5cd9350e8d7a3c]

        tdf#167591: Only apply date correction, when sDefault wasn't date string
        
        The correction is needed to adjust a date in the data source's epoch
        to the epoch used by the control (and its formatter). These epochs
        may differ.
        
        The problem was, that when sDefault has a date string like "20/07/25"
        or "2025-07-20", the conversion from that string to double using the
        control's formatter already created the value in the required epoch;
        and the correction broke the value.
        
        Fix that by checking if the string was really a date string, and so
        the correction should be skipped.
        
        Change-Id: Ia1ba2b1b5dc88d66d524ff03fecc028f7ebf3336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188091
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188679

2025-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [a08750535c34a315adb5a6ada5f3af7187f066fe]

        zxcvbn-c: upgrade to 2.6
        
        * 0001-There-is-no-std-basic_string-int.patch.1 and 0001-use-const-for-these-arrays.patch.1
        are fixed uptream now
        
        Downloaded from https://github.com/tsyrogit/zxcvbn-c/archive/refs/tags/v2.5.tar.gz
        
        Change-Id: I80b2d5f2b9a6a6bb274f56098f72010291934b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189041
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189096
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [83cf3a8152e2fd025e925f3d3bc08eb2e6863639]

        libffi: upgrade to 3.5.2
        
        Downloaded from https://github.com/libffi/libffi/releases/download/v3.5.2/libffi-3.5.2.tar.gz
        
        Change-Id: I38f09c9821b13773bc816afc2d5f027fdf4b7964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189030
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit ed0414c4b8995cb62d577e9f1de5647660e597cf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189037
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [184a5a6453146ec15e63c649c383abceb8743599]

        crashreporting: check Lower()
        
        See https://crashreport.libreoffice.org/stats/signature/SwTableShell::GetState(SfxItemSet%20&)
        which is new in 25.8 after
        
        commit 1b03f6ea0362a38c6c4e5e767fcb5cf87ddd28dd
        Author: Ujjawal Kumar <randomforest33@gmail.com>
        Date:   Thu Mar 13 20:42:21 2025 +0530
        
            tdf#149825 Add command to insert a paragraph break before table
        
        I couldn't find a way to reproduce it but Lower() might return
        nullptr as it uses SAL_RET_MAYBENULL. why the MSVC Analyzer
        didn't flag it is a mistery to me though
        
        Change-Id: I3002ee170009cd460f3a9792c5b95d76ae1ca2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189129
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 22a4e2df6f521a5baf1abfd9d4bf6da116933ed8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189142
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-08  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [5b32c63c6569996acc39216f81520291f15c7659]

        tdf#103859 EMF Fix quality of EMR_ROUNDRECT by using Bazier curve for drawing
        
        As WMF and EMF is using integers and previous EMR_ROUNDRECT implementation
        used many small lines to display curves, it produces low quality curves.
        With this implementation using Bezier curves,
        EMR_ROUNDRECT images are scalable without any loss of quality.
        
        Change-Id: I3ef7f15ed9e3835065030bdf196b9bfa044d84a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189016
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit 05fd7ddeb2f7d506b6c94dfcdef12b9bdbf9e4e5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189090
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-08  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [6f1769122be69e31ce8a67c91a1d90430150fe47]

        tdf#167616 EMF Add support for EMR_ANGLEARC record
        
        Change-Id: Ic872f80b2a318ac7c0f3b0cbdb4ad285795989c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188865
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        (cherry picked from commit 1b68f859034ecc2342a772685d6563fa1ad71f7f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189091
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [1a8ac560d1227ff4531172b998cbda8f1a8bbfa1]

        tdf#167859: check xChartType
        
        before
        
        commit f355ddcbf2bf037263e336724829b5467b94ef40
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
        Date:   Sun Apr 13 11:36:05 2025 +0900
        
            chart2: fold isSupported* functions into ChartType
        
        ChartTypeHelper::isSupportingAxisPositioning,
        ChartTypeHelper::isSupportingBaseValue and
        ChartTypeHelper::isSupportingBaseValue
        checked if xChartType was not nullptr inside them
        
        TODO: add UItest for it.
        
        Change-Id: I908d41ccc88208ab57576bd6369590556aafcce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189172
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [eaddb0695a687fc6638337eeb82da73543d7ca0a]

        tdf#167075: init doc shell before pasting as png/bmp
        
        Regression after
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        and
        
        commit 52e3b2b040ac54c2a5661e3676b135170f028f50
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 16:06:12 2025 +0200
        
            ScViewData: simplify constructors
        
        Change-Id: I0b70bd4efe6cd18ca3c7a13e92469e09b4ed7914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189189
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f49de37d779d983b0c148e9f23d43466f940f23e]

        update credits
        
        Change-Id: I94a8fbf4ac62d9e308b07b1e091059ff412ba80a
        (cherry picked from commit 2950c046b3bc737f28b638fb25f9101c9117f1cd)

2025-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [297482ca3831eeef8cab403f8b7bb1d57dd5e1d1]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to ce3849d1421f3f0b1141a8d997691d5248406c61
          - update translations for 25.8.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: I53dbfd1c352d3e265c9b632396ba4aaf1b4531d1
            
2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [c1636be457d79a0c962ad096d297d800e642ab32]

        tdf#167466: drop background tab from Writer/Web options tree
        
        it started to crash after
        commit ca6b1677cc3d923f0c13b2253b48a0ea90485b41
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Jun 3 11:59:57 2025 +0200
        
            sw: no need to create a dummy attr pool
        
        because that target pool is nullptr in SfxItemPool::GetUserOrPoolDefaultItem
        now.
        
        After some testing, there are some reasons why I believe it should be
        dropped:
        * Although it's an Writer/Web option it only works on Web ( File - New -
          HTML document )
        * Even if set in a web document, it won't be exported to html. To do so,
        it has to be set in the Page Style dialog
        * The document background can be changed from the Apperance tab so
        basically this tab is duplicated now
        
        This issue would have be caught if tdf#49895 had a test.
        I will write a UItest in a follow-up commit
        
        Change-Id: I3087a6942b9e5406de936fdde47d4c9143be55e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187754
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam@collabora.com>
        (cherry picked from commit 08cb3671487b9e28a0bae3b133260e144d7e1160)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187769
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [64adff6911db606f564f9df30fa8efe1f793e7c8]

        Update git submodules
        
        * Update dictionaries from branch 'libreoffice-25-8'
          to 13b1eae6978ceb13b2e21183b91297671c928b03
          - Upgrade Mongolian dictionary to 2025.08.02
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2025.08.02.zip
            
            Change-Id: I0212ae403c048bcbc37c78e336275234152f2de3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/189106
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            (cherry picked from commit ea41884e9efeb6668c7d17462f6fa3dcb07f9def)
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/189107
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2025-08-07  Michael Stahl  <michael.stahl@collabora.com>  [00b2dd5faeb43ff50c84139a31892956a6a142d7]

        libxslt: add patch for CVE-2025-7424
        
        See https://gitlab.gnome.org/GNOME/libxslt/-/issues/139
        
        Change-Id: I68f01dcb6b540ddf3d2e74927ec21c0ca4fc865f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189105
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 0f59405c5b255e80707a550129045c3dadd3c46f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189125
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Michael Stahl  <michael.stahl@collabora.com>  [5b2f54ac15685a964d125e3eb550822d30a27bdc]

        libxml2: add upstream patch for CVE-2025-7425
        
        Change-Id: I84110fc1ed54eac4a0ce4d8b8070a031c761fb39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189104
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 88e2be781bc22f8500f57c84cec572ead8af32c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189122
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Eike Rathke  <erack@redhat.com>  [6600793f1e5a82a95c967951958ef6b78b16c24f]

        Resolves: tdf#167794 Rename secondary English function EFFECTIVE -> EFFECT
        
        ... to match en-US and ODFF. An oversight of tdf#100641 work.
        
        Change-Id: Ie97dd723bc465d141a9e00b461b0e9dc8022c036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189059
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        (cherry picked from commit 2f03e115d156ed122d9e92d6c7f722a8599edf01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189128
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Regina Henschel  <rb.henschel@t-online.de>  [4c85f87fb528ace3db87bd79977d7397bc91e6eb]

        tdf#167582 consider orientation of external lookup source
        
        This is a follow up to my 5c0961129820fbc9dc8ec12c8a43a352ef1856a3.
        Changing bVertical to (nResRow2 - nResRow1) > 0 has introduced a
        regression with LOOKUP with external references. They need the same
        change, thus I remove the restriction to inline array.
        
        LOOKUP with external references had wrong results for mixed orientation
        of lookup vector and result vector same as inline arrays. Only that
        mixed orientations are unusually for external references and thus the
        error was not detected before.
        
        Change-Id: I2fc6d58b7fc84ae81f39b76534dc4ca99bdd6f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188304
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189102

2025-08-07  Kurt Nordback  <kurt.nordback@collabora.com>  [77ad59130533d459572af9434bad4c36a7ee049d]

        tdf#167368 - Chart style index is not exported to OOXML
        
        Add support for style index export, and a CI test for this.
        
        Change-Id: Idb109ef705a6bf8338e18040d447c2806c0781ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187425
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 4313451fc77f641dc63a8b32edb03c6aa2636ae9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187767
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [d70c3f5b92134073c21e940bce3feb3e7b5efef5]

        OOXML handling of 1904 null date for charts with internal data provider
        
        Change-Id: Id7b70bd8d0f471fc56ffb3c8ce43a01a871491bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187835
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188702

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [f3c432ec2304f46d58ee0dcb1a23fb20d5d8ef14]

        tdf#151505: fix autofilter import in XLSB
        
        Change-Id: I880ba2f8ea384e092cd90d8b4fe2ad0356f6c1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187979
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188699

2025-08-07  Michael Stahl  <michael.stahl@collabora.com>  [ee3d6b675620f32d01cbe3934e337cfc26a5519d]

        tdf#167710 writerfilter: RTF import: ignore text in \revtbl
        
        Only text in groups in \revtbl is relevant. Same goes for \stylesheet.
        
        (regression from commit 82e17dbb2a16c7653a163139f0eea51faa4d46b8)
        
        Change-Id: I70a97f7815e1f83b10be7cf12ee5abcd6b662a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188705
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit b45ba94bf2d927d0306cdd0e885017735ae4b21e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188767
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [b3715bd480b44dfedb48b5f3a6ce6a5e2f3d431e]

        tdf#164014: export value filters through the value property to ODS
        
        Change-Id: Ia6f8a2d65d1f90488ae1c8d2ca5bb48fc772464d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188061
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 02431246070d3468a0360b212f96a4ea75cac52c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188701
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [9d80c4ee2a9b368236107375511b1880692ef5f2]

        tdf#122336: handle OOXML files with invalid cell refs better
        
        Change-Id: Ib1e95ea0254f04852eb4c1ac4f95a587a68a9b10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188059
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 2c171226eeac51c6082734dc854e9c045a963f04)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188696
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [d32d90ac556ce75e30e7ecf2d6b6eccbbf4de244]

        properly display autofilter buttons for XLSB on filtered columns
        
        The XLSB property has the inverted logic compared to the XLSX property
        
        XLSB: fNoBtn: 0 means "The AutoFilter button for this column will NOT
                        appear in the next column (1) after this one"
        
        XLSX: showButton: Flag indicating whether an application intended for
                            editing documents should show filtering interface
                            elements on this cell
        Change-Id: I440149e28cf31cd16b834cdcc9eb05be4af45fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187978
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188697

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [b00d8e4cf6e903a3dcd29133e79a3091dfaead29]

        tdf#167194 sw redline reinstate: fix handling of self-inserts
        
        Create an insert in a document, then Edit -> Track changes -> Reinstate,
        you get an empty document instead of an "insert-then-delete" as
        expected.
        
        This happens because
        sw::DocumentRedlineManager::PreAppendDeleteRedline() has a call to
        IsOwnRedline(), which compresses the insert and the delete, which is
        wanted in general for self-inserts, but not while reinstating.
        
        Fix the problem by disabling redline compression in
        SwEditShell::ReinstatePaM() for the insert case.
        
        This requires extending
        sw::DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl()
        which probably just wants to turn on redline recording, but dropped
        RedlineFlags::DontCombineRedlines while doing so.
        
        Change-Id: I629d4d65dc966af934c7ecc672925d0fc11a3ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188768
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit e545ada3501780ee6552bbfa19954794e0440d46)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189078
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [fb6334d69e3760b7e468ed22deee5eeb515002ab]

        Related: tdf#167222 sw floattable: fix split of fly and heading text fit check
        
        Open the bugdoc, the only floating table is at the top of page 4 in the
        document, while it's at the bottom of page 3 in Word.
        
        This time the layout decides in SwContentFrame::WouldFit_() that the
        floating table and its anchor text can't fit page 3 and instead of
        trying to split, it moves both to page 4.
        
        Fix the problem similar to what happens already in
        SwContentFrame::MakeAll() and SwTextFrameBreak, by ignoring "don't
        break" / "keep with next" when that would potentially result in not
        allowing a page break between the floating table and its anchor text.
        
        Also extract this "ignore value for split fly anchors" logic to a new
        SwContentFrame::IgnoringSplitFlyAnchor() to avoid duplication.
        
        Change-Id: Ic31f0e34c75d978b4d8b6cbe2451ee7e15ef2f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188604
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188695

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [50f86a8ead1186f6faa162b7a175b0bf3b42eb29]

        Related: tdf#167222 sw floattable: fix split of fly and its heading text w/ ftn
        
        Open the updated bugdoc, which now has a footnote as well: the table
        goes to page 2 in Word, but to page 3 in Writer.
        
        This time what seems to happen is that the footnote container results in
        less body frame space, so the entire floating table + anchor text moves
        to page 3 and never moves back, even after the footnote moved to page 3.
        
        Fix this by extending SwContentFrame::MakeAll() to be consistent with
        the SwTextFrameBreak ctor, so it also ignores "don't break" / "keep with
        next" when that would potentially result in not allowing a page break
        between the floating table and its anchor text.
        
        Change-Id: I3161fb6896909b32996fe83acd8d6772f7b66af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188469
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188694

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [36a9c3dfc80e0f30ef17684cb2427daa286daf90]

        Related: tdf#167222 sw floattable: fix split of fly and its 'keep' anchor text
        
        Open the bugdoc, the floating table is at the bottom of page 2 in Word,
        but it's at the top of page 3 in Writer.
        
        This is similar to commit b8009818d619bff16d19a0f589a733f78a46ec0b
        (tdf#167222 sw floattable: allow split of fly and its keep-together
        anchor text, 2025-07-14), but here an SwTextFrameBreak instance is
        created, IsBreakNow() is invoked multiple times: so by the time the
        first IsBreakNow() runs, m_bKeep is false, but later it gets turned on.
        
        Fix the problem by adapting SwTextFrameBreak::IsBreakNow() to be
        consistent with its ctor, which already turns off m_bKeep for split fly
        anchors. This makes sense, because otherwise it can happen that first
        IsBreakNow() is invoked with a text frame where the format is in
        progress and we're not yet ready to split, but later we could split, but
        we don't even try due to the changed m_bKeep flag.
        
        Change-Id: I5d122e60c7693614e6e4c1b90e83f622be18fb72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187989
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188693

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [67f14318f5c8f8219fb6f7d1f9c3debe45fe2834]

        tdf#166319 sw interdependent redlines: fix redo of reject of del-then-fmt's fmt
        
        The bugdoc has <del>AA<format>BB</format>CC</del>, go to the middle of
        BB, reject, undo, redo: there is no format redline in the document, but
        there should be one.
        
        This is similar to commit 0a33618f791995a6a67aad14cd7b65976ffd8eda
        (tdf#166319 sw interdependent redlines: fix redo of accept of
        ins-then-fmt's fmt, 2025-07-07), but there the context was accept of
        insert and here it's reject of delete.
        
        The undo action already knows how to only reject the underlying redline,
        so fix the problem in sw::DocumentRedlineManager::RejectRedlineRange()
        by correctly recording the UI action with depth = 1, which gives us
        working redo.
        
        The exec of the undo action's redo calls
        sw::DocumentRedlineManager::AcceptRedline(), which now calls the same
        lcl_DeleteInnerRedline() as the original UI action, so this looks
        consistent now.
        
        Change-Id: Id8983eff342e228ad3bfe2f8de0557c9d74b2a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188654
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 1ba53f5ebbd57b7baf72240784d18954688a09b9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188719
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Jonathan Clark  <jonathan@libreoffice.org>  [b5228a1880cdb4774deb2156e72890711a02b4bc]

        tdf#167740 vcl: Fix Win IME inserting stale composition after dismissal
        
        Related to tdf#155158: Previously, the Microsoft Pinyin IME failed to
        send WM_IME_ENDCOMPOSITION when dismissed during composition. As a
        result of this, LO became stuck in an IME input state (resulting in, for
        example, an invisible cursor). The fix for this bug was to treat
        dismissing the IME in this state as also ending composition.
        
        Unfortunately, in the case of the Windows 10 Microsoft Korean IME, this
        bug fix caused the last character to be repeated due to stale
        composition state. This change updates the previous fix to also clear
        this data prior to ending composition.
        
        Change-Id: I5b2906c54af495e238a8335cc9c21cb42f6f3beb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188754
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit af0da68b4176aaf6d2f6faed66446e5638f41c80)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189045
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5e73fee5fecceaf711cb2f74eb1ff7a26f2be29]

        cid#1660814 Dereference null return value
        
        Change-Id: I78d031b29feb278b2a5f2e0fdb5bb43bd8664831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188715
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 3e0e4d141bc0bb1f9ca5cd7766cd64c7ae16d4f5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189051
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [735ed9cc93b9fdcf85baa43f1d856a9ec469b941]

        cid#1660401 Explicit null dereferenced
        
        Change-Id: I61ffc09df3569119597a97e1eb96dc5096410396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188858
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit f0ae436a49560dd78686aa4723a8751f083e942b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189049
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [62df8eaee0d94dd347a10203499b714e6e1c658a]

        cid#1660815 Dereference null return value
        
        Change-Id: I47c9e02859f69df1f1849113fcb52a217eb26193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit f1d7cedf2cd656bb19c68d0797b536c56f0e2683)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189047
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a51a775ea87010286e6624b06e9805bcca2bb95f]

        cid#1660263 Explicit null dereferenced
        
        Change-Id: Id6d36908f93783b8b742e59861452cef00a43dca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188895
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 916d3500d1e7cc1ee62da902552ee747493b0abd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189048
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Mike Kaganski  <mike.kaganski@collabora.com>  [fdaba4f87e74fa452b591e6ad43cf627f208c04a]

        tdf#167599: check the result of UNO_QUERY
        
        Not all objects implement XServiceInfo. Any query must either be
        UNO_QUERY_THROW, or check its result after UNO_QUERY.
        
        Change-Id: I8b1d7c719c4a43a4d658957ad5a91181dc265186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188080
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 125053348935ab307978037abaa459acd509c4c7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188677
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Jonathan Clark  <jonathan@libreoffice.org>  [a8fe8c02a2d075e4ee4d316fb16126846418c168]

        tdf#167541 sw: Fix hang laying out textboxes with empty script hints
        
        Certain DOC files may contain zero-length sprmCIdctHint runs.
        Previously, the EE implementation of style:script-type was not robust
        against such zero-length spans and would loop infinitely upon
        encountering one.
        
        Change-Id: I7178a89b2688956482ceb790dd05523034019e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188020
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188685

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [f40515eefd466a58d207750f13d713a169c18b23]

        sw: fix crash in lcl_InnerCalcLayout()
        
        Crashreport signature:
        
        kit-32444-32444 2025-07-30 00:27:03.547433 +0000 [ kitbroker_7771 ] SIG   Fatal signal received: SIGSEGV code: 1 for address: 0xa8
        ...
        program/libswlo.so
              lcl_InnerCalcLayout(SwFrame*, long, bool)
                      sw/source/core/inc/rootfrm.hxx:217
        program/libswlo.so
              lcl_RecalcRow(SwRowFrame&, long)
                      sw/source/core/layout/tabfrm.cxx:1923
        program/libswlo.so
              SwTabFrame::MakeAll(OutputDevice*) [clone .localalias]
                      sw/source/core/inc/flowfrm.hxx:170
        program/libswlo.so
              SwFrame::PrepareMake(OutputDevice*)
                      sw/source/core/inc/frmtool.hxx:476
        
        and then gdb reports:
        
        	Program terminated with signal SIGSEGV, Segmentation fault.
        	#0  0x00007fa134d7e4c4 in SwRootFrame::GetCurrShell (this=<optimized out>) at sw/source/core/inc/rootfrm.hxx:217
        	217         SwViewShell *GetCurrShell() const { return mpCurrShell; }
        	(gdb) up
        	#1  lcl_InnerCalcLayout(SwFrame*, long, bool) () at sw/source/core/layout/tabfrm.cxx:1864
        	1864        vcl::RenderContext* pRenderContext = pFrame->getRootFrame()->GetCurrShell() ? pFrame->getRootFrame()->GetCurrShell()->GetOut() : nullptr;
        	(gdb) print pFrame
        	$2 = (SwFrame *) 0x0
        
        Change-Id: I78a02ec062ad1c9645dbcb2fe82a5ae732d1f060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188584
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 548adbdda062ce595b49939a617fcccf2cf212de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188675
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [0a7db57656df704bfed869f743c8669b29d0eebd]

        tdf#118668: handle wrong XLSX sheet visibility settings in line with Excel
        
        Change-Id: I97b3b894a66c3108d67e0c8ef3b6b77aea11f365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188060
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit 098a900142491477223e3340f29a15505efe99cc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188700
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Miklos Vajna  <vmiklos@collabora.com>  [e157146d6f4fae68bab3fc0275722f79f6db1480]

        oox: fix crash in the SlideFragmentHandler dtor
        
        Crashreport signature:
        
        > terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException'
        > program/libmergedlo.so
        >       oox::ppt::SlideFragmentHandler::~SlideFragmentHandler() [clone .cold]
        >               oox/source/ppt/slidefragmenthandler.cxx:70
        > program/libmergedlo.so
        >       oox::ppt::SlideFragmentHandler::~SlideFragmentHandler()
        >               include/cppuhelper/weak.hxx:91
        > program/libmergedlo.so
        >       oox::ppt::PresentationFragmentHandler::importSlide(unsigned int, bool, bool)
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:1070
        > program/libmergedlo.so
        >       oox::ppt::PresentationFragmentHandler::finalizeImport()
        >               oox/source/ppt/presentationfragmenthandler.cxx:645
        
        Aborting the entire PPTX import just because inserting some VML shapes
        failed sounds like going too far.
        
        Change-Id: Idfa1718185ac4716da5d5cbdb2bfe68f11badb9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188036
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit adc6db837691d791c53ef1c4b05fcaaad79c158f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188692
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-08-07  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [890b1e0b0cc14a40370a409927f9849fc2112b6a]

        tdf#157689: don't use workbook DB range for importing autofilters
        
        When there was just a global anonymous DB range the import using the
        global DB range made sense. With the per-sheet anonymous DB ranges
        we can avoid this indirection and should use the range specified
        in the autofilter entry.
        
        Change-Id: Icc4879257c1f93a0977f118a8f89b6c87a5f5b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187977
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188698

2025-08-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [79c9e89970bc3ff3db4125bcfe0f9de81caea069]

        nss: upgrade to 3.114
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_114_RTM/src/nss-3.114-with-nspr-4.37.tar.gz
        
        Change-Id: Id3c3d002790d92ca8f17c676ce447dae8c26e16b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188688
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 6cda2dbfbf5d855e6194cd530a6f66099279bd90)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188735
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2025-08-05  Rene Engelhard  <rene@rene-engelhard.de>  [535fd79212f9ef03eafa5eb9e00b201d39adec1a]

        implement --with-system-colamd (for internal lpsolve)
        
        using suitesparse. Tested with both suitesparse 5.12.0 (Debian stable,
        without pc) and 7.9.0 (Debian unstable, with .pc)
        
        Change-Id: I6e0d014455ea2dec111aa3380bd49bd586dfad0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182444
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit e4dc378991002cdc64909af581053d588cc92a0a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188939

2025-08-05  Rico Tzschichholz  <ricotz@ubuntu.com>  [61b66ebb4a46c75821997b4c9d8f102cf2625dcd]

        sd: Fix no matching function for call on armhf
        
        sd/qa/unit/tiledrendering/tiledrendering.cxx: In member function ‘void testSlideshowLayeredRendering::TestBody()’:
        sd/qa/unit/tiledrendering/tiledrendering.cxx:3033:5: error: no matching function for call to ‘assertEquals(int, sal_Int32&, CppUnit::SourceLine, const char [1])’
         3033 |     CPPUNIT_ASSERT_EQUAL(2000, nViewWidth);
              |     ^
        /usr/include/cppunit/TestAssert.h:161:6: note: candidate: ‘template<class T> void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&)’
          161 | void assertEquals( const T& expected,
              |      ^~~~~~~~~~~~
        /usr/include/cppunit/TestAssert.h:161:6: note:   template argument deduction/substitution failed:
        sd/qa/unit/tiledrendering/tiledrendering.cxx:3033:5: note:   deduced conflicting types for parameter ‘const T’ (‘int’ and ‘sal_Int32’ {aka ‘long int’})
         3033 |     CPPUNIT_ASSERT_EQUAL(2000, nViewWidth);
              |     ^
        
        Change-Id: Ie6c0f59207a9e953b491f4a1ac8a8a201efcea76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188222
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-08-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c731451c6fb4f72e5c5dcb56b928cd9722e04fb]

        language-subtag-registry: upgrade to 2025-07-15
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-07-15.tar.bz2 data/language-subtag-registry
        
        Change-Id: Id5edd75d4b8661734721dcae198a0b7692fa5aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188673
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 6619faf3ca445ae88639daa5762e36b3960dc000)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188731
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-08-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [150bf27c032f615453df8d5da71d86fa767c30de]

        harfbuzz: upgrade to 11.3.3
        
        * 0001-const-up-modifier_combining_marks.patch has been fixed
        upstream
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.3.3/harfbuzz-11.3.3.tar.xz
        
        Change-Id: Iaeba7ca2988cfc3b150003a0bc4169ab8bde5627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188691
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188745
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-08-04  Justin Luth  <justin.luth@collabora.com>  [c716de571f2f1abc7b27170729a2107a1f87e533]

        tdf#167770 writerfilter: zero out margin if left/right aligned
        
        Both shapes and graphics should be flush against the edge
        of the page/paragraph when they are right or left aligned.
        
        During layout, MS Word doesn't save space for "text wrapping"
        on the side where there can be no text,
        so this is best emulated by zeroing out what LO calls the "margin".
        This has been partially done since 2006,
        but now I'm trying to consistently cover all cases.
        
        This longstanding bug became more prominent in 24.8
        with commit eacf8dc7ab850f2d00bd4b327f830c55cf2a0d92
        Author: Justin Luth on Tue Mar 5 19:22:34 2024 -0500
          tdf#160049 dml import: use margins with left/right HoriOrientRelation
          Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164443
        
        For now, just keep it simple to see the bugfix changes.
        Later, this can be dedupped into a single function.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160049_anchorMargin2
        
        make CppunitTest_sw_ooxmlimport CPPUNIT_TEST_NAME=testTdf96218
        
        Change-Id: I62a2434212bd050922b74a0105ef30c8c4c3c393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188786
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188864
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>

2025-08-01  Justin Luth  <justin.luth@collabora.com>  [051e3f7490541e1a67111b7f8cf72fa5d2a1bb96]

        tdf#166553 writerfilter: don't force para style when IsSplitPara
        
        This patch fixes an old problem that now is more exposed
        due to 25.8's commit a993c7849f0cc43c05ea8a505e38b44badc7539c
        
        Of course when a new paragraph is started,
        the paragraph style needs to be reset to the default one.
        
        However, in the emulation case when we are forcefully splitting
        a single paragraph into two,
        then don't reset the current paragraph style.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf166553_paraStyleAfterBreak
        
        Change-Id: Iff6582d533cef2f1d815b3e7378e93880af9622b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188566
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit eafbbc41049045a89cdb86710a37553aeb8eba7b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188618

2025-07-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c52d247f3ad764a67bfd115a3d1549e6e8c0e6b3]

        tdf#143157 - Include expanded text in index fields
        
        Include expanded text in the tooltip of index fields.
        
        Change-Id: Ife87a4f09e3cc2511637bfbf5b2f44e6598bfbb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187293
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins
        (cherry picked from commit c0c84b9c394f63f53f7ea55cbe7f6808b78e7f46)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187539
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-31  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [6f6f0a388527a2e52c03bdacb71a14be5926a0c9]

        tdf#166596 replace animated image in first launch dialog with static
        
        one
        
        Change-Id: Ifcd2f2046623000e50914d6a79f50615c0330e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188015
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit c5750839461a6bdffd363bbba8333122f709dfb5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188648

2025-07-31  Jonathan Clark  <jonathan@libreoffice.org>  [384d3b319185f352771fea049b67e7f9df96ac09]

        tdf#167552 sw: Disable DOC handling of fDntBlnSbDbWid compat flag
        
        This change partially reverts the following commit:
        
        commit 6818bc55ff248c59f12b2e090139eff30fe949dd
            tdf#88908 sw: Add BalanceSpacesAndIdeographicSpaces compat option
        
        Specifically, this change disables the actual handling of the compat
        flag for DOC files. It continues to work correctly for DOCX files.
        
        We were parsing the compatibility flag correctly. However, there is some
        undocumented and as-yet unknown mechanism Word uses to control whether
        or not the fDntBlnSbDbWid value is effective for a particular document.
        I looked at all of the likely Dop fields across the sample documents I
        have available, but I couldn't see a pattern. Possibly this is based on
        a version field located elsewhere, or maybe it's even based on the size
        of the Dop structure itself.
        
        After spending time trying to reverse engineer this, I'm growing
        concerned that this hints at a general Copts masking mechanism built
        into Word that we don't implement, rather than something that affects
        this one compat flag in particular.
        
        Change-Id: I021c636c0a9c72c5489960221f5ecec7823bf566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188247
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 510cdadd6199c19406a021e1fb0cc29ce21b5e29)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188293
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-31  Michael Weghorn  <m.weghorn@posteo.de>  [d8745db2e830fc45288e412c0918b08dd1e22159]

        cui: Don't use "p" prefix for non-pointers
        
        Change-Id: I63be3cc6aa46b64f42c5e39a7cb7cebea2eba4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186451
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 8e6c53f057e48c0f5bf9c2ea14dd24e6cbd80209)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188649
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-07-29  Neil Fachin  <neilfachin@gmail.com>  [e12a65c151db69f93b8d26202d17ee3a9ddae063]

        tdf#155419 tdf#156477 PDF Export: emitCatalog fixes for OpenAction
        
        Modifies condition check in emitCatalog so that it does not add OpenAction
        when using default initial page and magnification settings for pdf export.
        Previous behavior always adds an OpenAction to pdfs on export which
        can cause them to be flagged as potentially malicious.
        
        Also changes behavior of FitWidth and FitVisible switch cases. Previously
        they were using hardcoded values for A4 documents, causing them to
        open to incorrect locations in pdf readers for other document sizes.
        Now uses "null" which preserves current vertical position.
        
        Change-Id: Id65841baf791be34be79647d2094dfb2c0bcdd60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188219
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 54b6ed66901d9dc25e8f1636aca08fb9f3d8b5c6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188517
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-28  Justin Luth  <justin.luth@collabora.com>  [1326e09d019f05a82265f15c26288b4ffb7dc0c2]

        tdf#167657 writerfilter: only move sectPr bottomMargin after pageBreak
        
        This fixes a 24.2.4 regression from
        my commit 5ff1fd13f1879105ecc0541c55f30cea32ae54f4.
        
        The problem was that I treated all sectPr's as page breaks,
        and that meant that the below spacing of the last paragraph
        before a continuous section break was being unintentionally changed.
        
        This is a bit tricky because at the time of the section break
        we have no idea WHY the new break started.
        Only MUCH LATER at the end of the entire section can we discover
        whether it was a page break instead of a continuous (or column) break.
        Thankfully someone has already calculated and stored
        "the last paragraph before this section started".
        
        A continuous section break's above and below spacing
        should have no direct effect on layout, but it does affect
        how much the next paragraph's top spacing collapses.
        
        TODO: somehow the below spacing from a continuous section break
        needs to reduce the top spacing from the following paragraph.
        At this point I can't imagine how this could reliably happen.
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf167657_sectPr_bottomSpacing
        
        Change-Id: Ifd908e2104f7e1efb86947dd88e7ea6874346d58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188298
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188299
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-07-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cf39db5b97e665c47271a5679518a2fa9941be74]

        bump product version to 25.8.1.0.0+
        
        Change-Id: Idefcd55fd611372ce75bfc023d998bef48bec30a

2025-07-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a9fcda96fdaf7d89956f0ddc2c4ff0f2a890ac7b]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 281389aa91181ddd833d9743abd0a6b6b99d7e0b
          - update translations for 25.8.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: Iea8c894aa02eaf0208b0ce0a9ca1a47ccb96e84f
            
2025-07-24  Mike Kaganski  <mike.kaganski@collabora.com>  [1ea7043dc6f0c20d17e57a0cc70d7fc1a96cae18]

        cool#12283: when diagram is selected, apply color to its wall
        
        This is the same as in ChartColorWrapper::operator().
        
        Change-Id: I1d80a35d9100a15e5eeda619fecb6f721f06ce13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187457
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 5e5ec014ab0b71250f0a2676d3947c596dd77716)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187472
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 16af48e4b8d2e945ffdac703903ff851da48cfb7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187498
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-07-24  Patrick Luby  <guibmacdev@gmail.com>  [b4e0e0c898fe3a3ec38b4a1ff06a33d65a31d141]

        tdf#166994 Don't remove image from cache too quickly
        
        While an animation is running, the same images are drawn in a
        repeating cycle but each frame is removed from the cache before
        it is drawn again.
        
        Blending a bitmap with an alpha channel can be very slow so
        it is much faster to keep all of the frames in the image cache.
        So, allow the image cache to temporarily increase in size by
        deferring removal of an image if it was cached within the last
        few seconds.
        
        Change-Id: I24d4b6a630671374227b60d6ee274443aee2332e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187790
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 45956f73bad4bb894f4e97c795700599ee281b54)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187817
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-07-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c779b32023326828e5c96983b7b02eb3128a6bd]

        libxml2: upgrade to 2.14.5
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.14/libxml2-2.14.5.tar.xz
        
        Change-Id: I4e2e3f19479ae3c28801f0aa92adf918d633b6d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187923
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 79034b63b142b3f8bcc5d13ab4a16c0e9c42587a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187929
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-07-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f2945942cd5f8e94e0b1edd4583cf39dc1dd6525]

        null deref of SfxViewShell
        
         #0  desktop::CallbackFlushHandler::enqueueUpdatedType (this=this@entry=0x34f1a860, type=3, viewShell=viewShell@entry=0x0, viewId=9) at libreoffice/desktop/source/lib/init.cxx:2474
         #1  0x00007f1d866182a4 in desktop::CallbackFlushHandler::enqueueUpdatedTypes (this=0x34f1a860) at libreoffice/desktop/source/lib/init.cxx:2437
         #2  0x00007f1d866184a0 in desktop::CallbackFlushHandler::invoke (this=0x34f1a860) at libreoffice/desktop/source/lib/init.cxx:2503
         #3  0x00007f1d87648db0 in Link<void*, void>::Call (data=<optimized out>, this=0x30d537e8) at libreoffice/include/tools/link.hxx:111
         #4  ImplHandleUserEvent (pSVEvent=0x30d537e0) at libreoffice/vcl/source/window/winproc.cxx:2285
         #5  ImplWindowFrameProc (_pWindow=<optimized out>, nEvent=SalEvent::UserEvent, pEvent=0x30d537e0) at libreoffice/vcl/source/window/winproc.cxx:2849
         #6  0x00007f1d87b3accc in SalFrame::CallCallback (pEvent=0x30d537e0, nEvent=SalEvent::UserEvent, this=0x38abd50) at libreoffice/vcl/inc/salframe.hxx:311
         #7  SvpSalInstance::ProcessEvent (this=0xe87940, aEvent=...) at libreoffice/vcl/headless/svpinst.cxx:272
         #8  0x00007f1d87937029 in operator() (__closure=<synthetic pointer>) at libreoffice/vcl/source/app/salusereventlist.cxx:119
         #9  SalUserEventList::DispatchUserEvents (this=this@entry=0xe87968, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at libreoffice/vcl/source/app/salusereventlist.cxx:120
         #10 0x00007f1d87b3b4d9 in SvpSalInstance::ImplYield (this=this@entry=0xe87940, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false)
             at libreoffice/vcl/headless/svpinst.cxx:425
        
        Change-Id: Id6961b300ce67f5cfcbb91284a84bf02edc6aec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187632
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 6034be914e4afdbdc330a6d1b43ff02cf966dacf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187661
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit cc93fa1d10c86d7bad938dcdbb671b5a8bd78def)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187673
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-07-24  Balazs Varga  <balazs.varga@collabora.com>  [3a6c72a553d89e1b0f80858fd603916d66182212]

        tdf#167468 - sc: fix XMATCH with mode=0 and searchdirection=-1
        
        returns wrong value.
        
        Off-by-one error during the calculation of the result with Reverse
        search mode.
        
        follow-up of XMatch implementation: c9245c153d349ee414fdd4f878fd10cbd8471cff
        
        Co-authored-by: Regina Henschel <rb.henschel@t-online.de>
        
        Change-Id: If77289d314f5960c19911c889f8d5b8eb0b839cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188019
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit 649346506b8ec0670e35d30c5e04358e40244c36)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188241
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-24  Patrick Luby  <guibmacdev@gmail.com>  [4bbef581d68b391a4de57cc36c85775635f324d6]

        tdf#167007 Add animated graphic to cache when prepared
        
        For some reason, after an animation has been swapped out by
        MemoryManager::loopAndReduceMemory(), the animation repeatedly
        creates a new ImpGraphic instance, swaps it in, but it never
        gets registered in the cache. Since it is not in the cache, new
        ImpGraphic instances get deleted almost immediately after they
        are created.
        
        So prevent immediate deletion by ensuring that animated
        ImpGraphic instances are registered when they are prepared.
        
        Change-Id: Ib721e0bc31d3eddc4ed4131d9d8dc8919eed7b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187836
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit eed9c590db8e94ddc5cc20bc25a779284c9b9249)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188234
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [59340251fa4c403c0659e0016ff1e606b829c669]

        tdf#159775: restore filename from URL on redirection
        
        Some github release URLs, like
        
        https://github.com/hanya/MRI/releases/download/v1.3.5/MRI-1.3.5.oxt
        
        get redirected to something like
        
        https://release-assets.githubusercontent.com/github-production-release-asset/3265966/eff2c80e-138d-4b06-8139-e433f4672379?...
        
        of which, 'eff2c80e-138d-4b06-8139-e433f4672379' is used as
        ucbhelper::Content's title. That is used to construct local
        filename in UpdateInstallDialog::Thread::download. Later in
        PackageRegistryImpl::bindPackage, the extension of the file
        will be used to detect the mediatype; if failed, operation
        will abort.
        
        Detect this situation, and restore the filename from URL.
        
        Change-Id: Ib95189ff35e07fd01c95f87827c6f620ebfe2fe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188114
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b729b0bb677bd2b82492b45806ed3ddd91d2234f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188188
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a858851b45b9e1bd4cb0b08142a9d8eeccf342d]

        related tdf#163903: fix hexadecimal LCID
        
        See https://gerrit.libreoffice.org/c/core/+/176735
        
        Change-Id: I09ca39b5358f469bb97b76ce04e79944095ad176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187862
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>
        (cherry picked from commit 51221018ea8c77d37bfb50ab59494f751f018483)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187871
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-20  Martin Srebotnjak  <miles@filmsi.net>  [5136f42ad575a11f5955bd8289bbc10425944b33]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to d72efbafbe988e13946b5b1d64c6e31e26e858a6
          - Updated Slovenian translation
            
            Change-Id: Ibaea1093eb9f79c0ce16634cc2c09ded516bb044
            
2025-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [e2272d311c8a7f2ac6eb8df3e222dec12d83b248]

        a11y: Set mnemonic widgets in print dialog
        
        This ensures that the corresponding a11y relation
        is set and e.g. the Orca screen reader announces
        the associated label when the "Number of copies"
        spin button or the "Include" combobox (for even/odd pages)
        receive focus.
        
        Change-Id: Id2399c87cf934d16addabd34ebf503baaf21121f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188039
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit b59d61f9091116b0a63232f264e52f601cf279fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188048
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-18  Hossein  <hossein@libreoffice.org>  [c6350e9d8ef5eae111bd5d841ca7110d59e975a3]

        tdf#80662 Fix display of JDK version number / path
        
        Previously, JDK version number and path were displayed as RTL in right
        to left mode of LibreOffice, in "Tools > Options > Advanced". The RTL UI
        can be activated by setting:
        
        SAL_RTL_ENABLED=1
        
        The fix uses an LRM and PDF Unicode characters around the text:
        https://en.wikipedia.org/wiki/Bidirectional_text
        
        This patch also fixes the display of JDK path, which had the same issue
        that was visible in the bug doc.
        
        Change-Id: I80b25821defd43355e5b271d0348dd70ef520440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187813
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        (cherry picked from commit 1a2523aa52c8237f784b4fe2d4689cbf7a02aed2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187880
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-17  Justin Luth  <justin.luth@collabora.com>  [952412154a4872d0f06a60c44506278924bb9c62]

        tdf#153684 spellcheck: ignore non-case character when !IsSpellUpperCase
        
        This fixes a 7.5 regression from
        commit ab0adac692b67fe7b63dee665607400c6a7e6c01
            Fix everything using XCharacterClassification::getStringType()...
        
        Prior to erack's commit, all of the character-type-flags were grouped
        together. So it could be a mix of UPPER, LOWER, and TITLE_CASE.
        IsUpper returned true if there was at least one UPPER and no LOWER.
            return      (nFlags & KCharacterType::UPPER)
                    && !(nFlags & KCharacterType::LOWER);
        
        Since it was a group of flags, any characters that were non-case
        (like a fullstop) did not affect the result of IsUpper.
        
        But when it was changed in 7.5 to
            return aCC.isUpper( rText, nPos, nLen );
        now every character needed to be considered to be upper-case,
        even if it was a non-case character.
        
        So this patch changes the logic back to the original state
        (more or less).
        The fly in the ointment are any Unicode characters
        that would be considered to be TITLE_CASE.
        Previously they were ignored (i.e. they didn't affect the outcome),
        but now I consider them to be non-uppercase.
        That seems to me to be the intent here anyway,
        so probably this implementation "fixes a bug"
        when a word consisted of a mixture of UPPER and TITLE_CASE chars.
        
        Change-Id: I7cf1d68bc3eb0a1a468da9e67ab54d1148f097aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187934
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 53a9cee01759ce54c4ee50468958531a360640f9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187936
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [d9236672b8d2928692c1948c99a8e6372dc9b2c2]

        tdf#167431: Add bitcoin currency
        
        Based on https://bugs.documentfoundation.org/show_bug.cgi?id=167431#c2
        
        Change-Id: Id90ad54651b6ee9be2462ec6884c93315695e8ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187865
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-07-16  Armin Le Grand (collabora)  <Armin.LeGrand@collabora.com>  [e09e660c74d5905dff5700c1017e481b608c3800]

        tdf#166734 CairoSDPR: use sub-pixel correct transformation
        
        When parts of the output need to be pre-rendered (e.g.
        transparencies) the temp target is of course pixel-aligned,
        bit the mapping for the rendering was not yet. Added that
        now. This could lead to sub-pixel displacements which are
        usually not recognizable, but also like here make the
        PixelSnap fail.
        
        Change-Id: I877987947bdcc7521580de9287894ca70b17763c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187928
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins
        (cherry picked from commit 15a5d633fec3c3c62870ab4168a1886796350031)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187958
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-07-15  Regina Henschel  <rb.henschel@t-online.de>  [054b38fd2eecc3279f117d34bd976f5dfc1a3883]

        tdf#167450 adapt sheet index in anchor to new pos
        
        When a sheet is copied to another document, the tab index might change.
        The tab index was not adapted in the anchor info in the shape, that are
        maStart and maEnd in m_pPlusData in SdrObject. That resulted in a wrong
        shape position after save and reload.
        
        Change-Id: If69dcc9067e1346e1e115adf3c5ca68a9423e250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187802
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 704dd0d279af6c1ace1bde61fec93e7c3a8d1035)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187924
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-15  Miklos Vajna  <vmiklos@collabora.com>  [c80832085d6606a082c7052d07262d95d20cb0db]

        tdf#166319 sw interdependent redlines: handle deleting a self ins-then-fmt
        
        The bugdoc has <ins>A<format>B</format>C</ins>, go to the end, delete C,
        result is <ins>A<format>B</format></ins> given that this was a
        self-insert, but the next delete results in <ins>A</ins><del>B</del>.
        
        The problem is that we have special code to deal with delete on
        self-insert (it's fine to just remove such content from the model), but
        this code won't handle insert-then-format as insert, while Word does.
        
        Fix the problem by extending
        DocumentRedlineManager::PreAppendDeleteRedline() to look "through" just
        format redlines to see the underlying insert.
        
        Note that the same is not needed for delete-then-format, since insert is
        always inserted next to an existing content or redlined content, so
        there is no overlap.
        
        Change-Id: I8b47839ffaa470714a5dd37722aa26ac0002c0bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187907
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f66d63da05dbe2f254ffaf428257684a38523f66)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187921
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-15  prrvchr  <prrvchr@gmail.com>  [f1f1445bb25d48289e77ec5e06da9a57502fa119]

        tdf#167495 Base need to close ResultSet after using it.
        
        I checked that this is where I saw Base open DatabaseMetData.getColumnVersion() as many times as there are columns in the ResultSet and never close them.
        
        Change-Id: I4aa371dc08826d864718285588a685a799eca607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187901
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 8fcd59e87065a44918714e5a26d99d303516b247)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187906
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-15  Jean-Pierre Ledure  <jp@ledure.be>  [69087b1c05a005f49f714cdc7be7df89e37458d9]

        ScriptForge (Form) Fix missing attributes
        
        When a FormControl instance is created
        triggered by an event with
           fc = CreateScriptService("FormEvent", event)
        a number of attributes are not
        (re)-initialized in the parent Form instance.
        
        They concern references to the form document
        container and to the database connection.
        
        The absences prevent from scripting easily
        (workarounds exist) operations on the form
        document (close, print, ...) or towards the
        database (read, sql, ...). In particular,
        this limits the reusability of scripts
        across >1 form documents.
        
        This is a bug. It is fixed with the actual change.
        
        Documentation may be left unchanged.
        Basic and Python scripts are impacted alike.
        
        Change-Id: I285148917174d5a046c11b15ea2a2581a23d4277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187854
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        (cherry picked from commit c2a5e575e5b1a317e30365d63f8b396d770e5d57)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187892

2025-07-15  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [37bee016829f47537555f424c955a1461f8563a1]

        tdf#148117: always export date chart axis with 1900 null date
        
        We currently don't support the import of the 1904 setting correctly and
        internally always use the 1900 reference. We should fix the import as
        well and then use the correct export.
        
        Change-Id: Idd69cf086d1dee14b92cebeeb1c51ece158a2955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187834
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187897

2025-07-15  Miklos Vajna  <vmiklos@collabora.com>  [7e97e094739901647c4ff59bccfb86bc8bc70d90]

        tdf#167222 sw floattable: allow split of fly and its keep-together anchor text
        
        Regression from commit 3eb6d764b3023500f2299d36bf1860bc8e67db9f (DOCX
        import: floating table with negative top margin has to be a fly frame,
        2022-01-21), open the bugdoc, notice that the floating table should be
        at the end of page 1 but is at the start of page 2.
        
        This happens because in general keep-together means no split should
        happen for all anchored objects and lines of a text frame, but Word
        allows floating tables to be split from the next regular paragraph in
        the document.
        
        Fix the problem by building on top of the work done in commit
        2d0a4ef1d83b8de6cb133970c2c35ae706fb058e (sw floattable: fix negative
        vertical offset handling on page boundary, 2023-06-20), which makes this
        split to "floating table" and "anchor text" pieces possible, but that
        didn't help here, since the anchor text node happened to be a heading,
        with both a split property set to false and a keep-with-next property
        set to true. Now we ignore both properties in case the paragraph is a
        floating table anchor, which means that in SwTextFrame::FormatAdjust(),
        rFrameBreak.IsBreakNow() can return true, resulting in a call to
        SplitFrame(), as needed.
        
        The behavior for other types of anchored objects is unchanged, those
        don't go to a separate page in Word, either.
        
        Change-Id: I48835f355fa5aeb09b1a92bd8cee7e06cd148240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187858
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 77f0dc4347b8802c56121ca1c5ef59209970214a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187873
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-14  Jonathan Clark  <jonathan@libreoffice.org>  [9824f9feb562424ddb478dee32c76aa85db5e90e]

        tdf#167297 sw: Add support for DOC/DOCX script type hinting
        
        Extends the Writer script type hinting mechanism to natively support
        DOC/DOCX script type hinting.
        
        Implements the OOXML w:hint attribute, in both import and export.
        
        Implements the DOC sprmCIdctHint property, in both import and export.
        This change also removes the previously-implemented IdctHint emulation,
        based on breaking the input text into smaller spans. Writer's script
        type hinting mechanism is sufficient to replace this code.
        
        Change-Id: I08f934358164dc5814bfac010d4fac9b3334f947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187755
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187771
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Miklos Vajna  <vmiklos@collabora.com>  [d7212eeeb2ec8a2072a33063e81ee4b27af8f031]

        tdf#167379 sw floattable: ignore dummy anchor nodes in DOCX export
        
        Open the bugdoc in Writer, looks OK, save to DOCX, open in Word: an
        unexpected paragraph appears between the two floating tables.
        
        What happens is that the DOCX import inserts dummy anchor paragraphs
        between floating tables, so we can maintain the invariant that each text
        node has at most one floating table anchored to it (which simplifies
        layout code), but then these dummy text nodes are not filtered out on
        the export side.
        
        Fix the problem by scanning the nodes array for such dummy nodes once at
        the start of the exporter, omitting such dummy nodes from the export
        result and write the affected floating tables when the next text node is
        written in the output.
        
        An alternative I considered is to leave
        MSWordExportBase::OutputContentNode() unchanged and just make some of
        the m_pSerializer calls conditional, so the dummy anchor node is missing
        from the export result. The problem is that it needed ~12 conditions and
        it would be easy to change the code in the future in a way that some
        part of the dummy node markup would be still emitted. So instead skip
        the entire text node and write the table with the next node.
        
        Change-Id: Ic15342d431a5c1e3086dc2029df6455ad675e13e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187696
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit c9851022d102a2abfc16c033c0249f24573300e7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187768
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [51d91b68ed1d6b3b5ba22913005cd1a9d3a635c1]

        tdf#166181: partial revert of 223a51801f0b75ae5036a8bcecc6eb81d99b113e
        
        A newly created follow row frame for a split row would be passed into
        lcl_GetHeightOfRows with Y position of 0, while the next row frames
        would have Y positions from their previous placement (below the last
        row frame kept on the previous page). Thus we can't use a difference
        between top ot first row and bottom of last row to get sum of heights.
        
        Change-Id: Ia96cd3ec488a6c3e6fb768fb1346bc8d61696118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187818
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 6a074bd78322d8a8ca3eddd5ea4d4edf8f796a80)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187856
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [ab3601c6d521629a38e0173ffb224d93bba38ab0]

        android: Update compile/targetSdkVersion to 35, disable edge-to-edge
        
        Update compileSdk and targetSdkVersion to 35 (Android 15).
        
        In a quick test, running the app seems fine in an API 36 (Android 16)
        AVD configured to use 16 KB Page Size, for which support was added
        in Android 15 [1].
        
        Changing the targetSdkVersion to 35 implies that edge-to-edge
        would now enabled by default [2]. That would result in the
        app par overlapping with the system bar and interaction would
        be broken. For now, avoid that by explicitly opting out of
        edge-to-edge support by setting
        android:windowOptOutEdgeToEdgeEnforcement for API versions >= 35
        in the LibreOfficeTheme used by all activities by now.
        
        Helpful article: [3]
        
        That won't work for targetSdkVersion 36 any more (see [4]),
        but at least helps to comply with the upcoming required
        targetSdkVersion of 35 in Google Play and gives some time
        to implement proper support for edge-to-edge
        for Android 16+ devices before increasing the targetSdkVersion
        further.
        
        Android Viewer works as expected in a quick test
        with an API 36 (Android 16) x86_64 AVD
        and an API 24 (Android 7) x86 AVD (with an additional
        local revert of commit 9d1e76f7da12353afc3d9479d3b2ecddbb2a71e6
        to prevent a deadlock when opening documents that is unrelated
        to this change here).
        
        [1] https://developer.android.com/about/versions/15/behavior-changes-all
        [2] https://developer.android.com/about/versions/15/behavior-changes-15#window-insets
        [3] https://medium.com/androiddevelopers/insets-handling-tips-for-android-15s-edge-to-edge-enforcement-872774e8839b
        [4] https://developer.android.com/about/versions/16/behavior-changes-16#edge-to-edge
        
        Change-Id: Id6d33bfbb7ca49c65e3875efb87c3c575be5f5ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187627
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 2b77994d455b8d066baf6b67c1820fbb736b538f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187694
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [2dc051b0f37503559b1bc5aa955bdf60032a8863]

        android: Use same theme for SettingsActivity
        
        Don't use another theme for the SettingsActivity
        than for the rest of the app.
        
        I don't see any big visual change when opening
        the activity at least in an API 36 (Android 16)
        AVD anyway (with an additional
        local revert of commit 9d1e76f7da12353afc3d9479d3b2ecddbb2a71e6
        to prevent a deadlock when opening documents that is unrelated
        to this change here)
        and this will simplify maintenance and
        adding support for targetSdkVersion 35 where edge-to-edge
        is enabled by default [1].
        
        [1] https://developer.android.com/about/versions/15/behavior-changes-15#window-insets
        
        Change-Id: I1e5dccfefe930d34a8b315df04a6f07f050a5b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187626
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 42ee4ef3a33d22cfea24d0e1956677c2a4068c2f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187693
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [0c3c561ca002c35a0c6ff0bdc6e5d85e1657746d]

        android: Consolidate custom themes
        
        LibreOfficeTheme.Base isn't used by itself,
        so no longer let LibreOfficeTheme derive from it,
        but derive from Theme.AppCompat.DayNight.NoActionBar
        directly.
        
        LibreOfficeTheme.Toolbar is equivalent, so drop it
        and switch all uses to LibreOfficeTheme instead.
        
        Change-Id: I9ad5ccb00bac94a20c17715780050fd8d300fa15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187625
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 7b42e56bf9dd1db0ed9175c3db928f1b0a48bcaf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187692
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [d83c1ba936bd25e6386ffdb3141e09dc350c66a0]

        android: Drop unused LibreOfficeTheme.NavigationView
        
        Unused since
        
            commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 6 14:26:06 2021 +0200
        
                android: Drop custom file abstraction + UI
        
        Change-Id: I01da7a0f2c2a0f5b28262984048a0328de0e846b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187624
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit d93a9e5868d4c54fc17d8881e1c01eb048642c35)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187691
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [4a985fae2303ba0ed266b14deeba92954ed8df2b]

        android lint: Drop redundant android:alignParent* attrs
        
        Address those lint warnings which would otherwise
        trigger build errors in a WIP branch updating
        compileSdkVersion and targetSdkVersion to 36.
        
        Regenerate android/source/lint-baseline.xml
        
        Change-Id: I0c3cbd10f6f177636a4960dd93674dde7c04b470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187576
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 56cc3fe11f66304502e2ffdf4400f1c74a51d0e7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187690
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [08e9c4bcff4880836f3a4c2eaa0de7a6a5c0ad1e]

        android lint: Drop redundant android:layout_margin{Left,Right} attrs
        
        Address those lint warnings which would otherwise
        trigger build errors in a WIP branch updating
        compileSdkVersion and targetSdkVersion to 36.
        
        Regenerate android/source/lint-baseline.xml
        
        Change-Id: I2f75a04898d38bf6661ba50bcdbe13677065f695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187575
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit dccae06f4f48afdaf007d3c9f20d18e5873548ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187689
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [5410178db099a2dbd0ff094e1e26848a013b8ecc]

        android lint: Always have Calc doc right of headers
        
        Address these 2 lint warnings which would otherwise
        trigger build errors in a WIP branch updating
        compileSdkVersion and targetSdkVersion to 36.
        
            <issue
                id="RtlHardcoded"
                message="Redundant attribute `layout_toRightOf`; already defining `layout_toEndOf` with `targetSdkVersion` 34"
                errorLine1="                    android:layout_toRightOf=&quot;@+id/calc_header_top_left&quot;"
                errorLine2="                    ~~~~~~~~~~~~~~~~~~~~~~~~">
                <location
                    file="res/layout/activity_main.xml"
                    line="78"
                    column="21"/>
            </issue>
        
            <issue
                id="RtlHardcoded"
                message="Redundant attribute `layout_toRightOf`; already defining `layout_toEndOf` with `targetSdkVersion` 34"
                errorLine1="                    android:layout_toRightOf=&quot;@+id/calc_header_row&quot;"
                errorLine2="                    ~~~~~~~~~~~~~~~~~~~~~~~~">
                <location
                    file="res/layout/activity_main.xml"
                    line="94"
                    column="21"/>
            </issue>
        
        Like the desktop version of LibreOffice, have the Calc doc
        always to the right of the headers, regardless of whether
        RTL or LTR is used, i.e. leave `android:layout_toRightOf` and
        drop the `layout_toEndOf` attribute.
        
        this triggers other lint warnings. Regenerate
        android/source/lint-baseline.xml to not fail the build
        on those.
        
        Change-Id: I4b3c1076d62a757164a3ae1953fe0c73ddc444c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit bda2ac31eeea60ca3e8a5b6057ee554df562f6d5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187688
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [aab5432c05efb9cbfcbb5627ef46540f78bc37c5]

        android: Port from deprecated ComponentActivity.onBackPressed (II)
        
        Port LibreOfficeUIActivity from overriding the deprecated
        androidx.ComponentActivity.onBackPressed method [1]
        and register a androidx.activity.OnBackPressedCallback [2].
        
        Overriding the deprecated API was already triggering a warning
        and that was turned into a build/lint error in a WIP branch updating the
        compileSdkVersion and targetSdkVersion to 36.
        
        Interaction when using the back button (or gesture)
        remains the same after enabling experimental editing option
        and clicking the "+" button to display the options to create
        new filesin a quick test (with an additional
        local revert of commit 9d1e76f7da12353afc3d9479d3b2ecddbb2a71e6
        to prevent a deadlock when opening documents that is unrelated
        to this change here).
        
        [1] https://developer.android.com/reference/androidx/activity/ComponentActivity#onBackPressed()
        [2] https://developer.android.com/reference/androidx/activity/OnBackPressedCallback
        
        Change-Id: Ie5e9f3be7321d40f43ebf584db367432afb70577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187573
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 354c70556b5656c586adf4c8cc0521687bd77e22)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187687
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [212de77c88d43ed373e35413deab714f453f64c2]

        android: Port from deprecated ComponentActivity.onBackPressed (I)
        
        Port LibreOfficeMainActivity from overriding the deprecated
        androidx.ComponentActivity.onBackPressed method [1]
        and register a androidx.activity.OnBackPressedCallback [2].
        
        Overriding the deprecated API was already triggering warning
        
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java:511: warning: [deprecation] onBackPressed() in ComponentActivity has been deprecated
                public void onBackPressed() {
                            ^
        and that was turned into a build/lint error in a WIP branch updating the
        compileSdkVersion and targetSdkVersion to 36:
        
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java:511: Error: onBackPressed is no longer called for back gestures; migrate to AndroidX's backward compatible OnBackPressedDispatcher [GestureBackNavigation]
                public void onBackPressed() {
                            ~~~~~~~~~~~~~
        
        Interaction when using the back button (or gesture)
        remains as before in a quick test (with an additional
        local revert of commit 9d1e76f7da12353afc3d9479d3b2ecddbb2a71e6
        to prevent a deadlock when opening documents that is unrelated
        to this change here).
        
        [1] https://developer.android.com/reference/androidx/activity/ComponentActivity#onBackPressed()
        [2] https://developer.android.com/reference/androidx/activity/OnBackPressedCallback
        
        Change-Id: Id5bde62fede7e0550a86bd0ba9bd1535a84003dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187572
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 9fa0ea06bc4f6be647ef4ac4d5bc1830bfc93ec4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187686
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [b7a54ec2f4c5dddef08d26e70ebbfba44ccb63ea]

        android: Update androidx.constraintlayout:constraintlayout to 2.2.1
        
        Change-Id: I810185a7004a7d66626654a30cb4123a1b67b875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187571
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 622b70aa5cf7d0e50d9c5280583b83a89841ebc7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187685
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [aefb889fdd683982f56af160f070dde0c9c131d4]

        android: Update Android Gradle Plugin to 8.11.0
        
        ... and gradle to 8.13, as suggested by Android Studio.
        
        Update the lint-baseline.xml file (by deleting it and running
        a build to have it regenerated, commit result).
        
        Change-Id: Ia7d4c5fde77e7b504066cef004003447b2780192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187569
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 728248837dd31260f3eea8cda15892945b4700bd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187684
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a9bf303dfb348265edf7c2c61fc3b8a6511fd5df]

        tdf#165156: limit hack for tdf#161508 even more
        
        Make oscillation detection only happen when !bSplitError, to not
        interfere with handling of the latter.
        
        Change-Id: I6c54e5026ba700522121f36a3e4fc5b91c37b2e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187801
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 8946628f0ce28d111c9dfcfbd73e30afac32c157)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187841
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-14  Markus Mohrhard  <markus.mohrhard@googlemail.com>  [be82073d8be8905d63ec79f8547c13d132f6274a]

        tdf#136754: handle pptx chart backgrounds provided by the themes correctly
        
        It seems that there is a small undocumented quirk in the OOXML spec
        regarding pptx files. The first 32 themes are handled as if they would
        be specifying a transparent background whereas the spec seems to agree
        with the xlsx/docx handling of using a solid background based on the
        theme colors.
        
        This corresponds to table 3 in 21.2.3.46 ST_Style of the OOXML spec.
        
        This commit also reverts the fix for tdf#60316.
        
        Change-Id: I4187b5740898435941647056a5820fa47a2b3dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187759
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        (cherry picked from commit 87350de8737ca91ba71b356ca9f33fea99e74591)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187843
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-14  Patrick Luby  <guibmacdev@gmail.com>  [fdd5dac96c0c7fa1050d5ec0bbb22e1078ef8556]

        Fix NSEvent memory leak
        
        DragSource instances retain an NSEvent but would never release it.
        
        Also, NSEvent instances are essentially immutable since all of their
        properties are read only. So just retain an existing NSEvent instead
        of making a new copy.
        
        Change-Id: I1a13cdc04f6b8a1bede6c831a04d6e8d152b8b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187781
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit e1a369bbfa2a56e902771aa66b15aa1832d40ec5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187785
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-13  Nagy Tibor  <tibor.nagy@collabora.com>  [a5c4cf44a46e5e7e7f0ccbbd17899e599dfcb837]

        Revert "sw: add fallback for page styles using UIName identifiers"
        
        This reverts commit 09804b8a8b6dd41e2e17ab25f5ce6b6d90b14633.
        
        Reason for revert: The issue was on the extension side.
        It used the UI name for the page style instead of the programmatic name.
        
        Change-Id: If0ac25c6bc1fe9e246fa16cf1646c5f94a363e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187679
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy@collabora.com>

2025-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [79dc0ebf6a7dd2757dcb3efc01d57e860816828c]

        tdf#167455: sw_odfimport: Add test
        
        Change-Id: I4a9df517f66ccdf394444c86cd783c201eb2ccae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187699
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-12  Patrick Luby  <guibmacdev@gmail.com>  [3a1ff39d026530b3bc5f75052822fe9480034cb5]

        tdf#159529 Use macOS font table memory directly instead of copying
        
        Per Apple's documentation, the CFDataRef returned by the
        CTFontCopyTable() function is "A retained reference to the
        font table data as a CFDataRef object. The table data is not
        actually copied; however, the data reference must be released."
        
        So, instead of making a copy of the CFDataRef's data, just use
        the CFDataRef's data pointer for the HarfBuzz blob and release
        the CFDataRef in the blob's destroy function.
        
        Change-Id: Ia670d036b20ca268b203eedcb1abbaad471d5384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187761
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187766
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [56c768bb35d99d029c696d8ce17b5098a2ce7daa]

        Revert "tdf#159529 clear hb_ot_face_t data after fetching 'sbix' and 'glyf' tables"
        
        This reverts commit af47a78e11d4819bb4b1ae1a1277babd10d815b7.
        
        Reason for revert: seems to cause regression/crash tdf#167455
        after the update to harfbuzz 11.2
        See also https://github.com/harfbuzz/harfbuzz/issues/5386 that confirms the crash to be related to the patch
        
        Change-Id: I359f716afbc8d94fbdb25e600827ac3c41c2ae0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187698
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187765
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-12  Khaled Hosny  <khaled@aliftype.com>  [466e73897ec8d38dc46676eeadfce22e166f1d0b]

        Don’t calculate text bounds needlessly in OutputDevice::GetTextArray()
        
        Calculating text bounds can be a costly operation (e.g. for fonts with
        CFF table since it has to be calculated from outlines), and leads to
        loading potentially large font tables (which is especially an issue on
        macOS where we copy font table data when loading, unlike other platforms
        where HarfBuzz mmap’s the file). It seems that the text bounds are only
        used in one place, so this change calculates the bounds only when
        requested.
        
        Change-Id: Ib9017a58dda30b4cc07ceec087cbf4ad45d56d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187683
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187764
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-12  Michael Stahl  <michael.stahl@collabora.com>  [87c0461b99d441ce5436180c6f5b0f3111bfedc7]

        tdf#166975 sw: fix DOCX export of list level format with repeated levels
        
        MSWordExportBase::NumberingLevel() would only replace each level's
        placeholder once in the format string; rework this so it iterates the
        whole format string.
        
        Change-Id: I7f375ac1f96f4fcbac51f7cba1cc67378f4edbb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187580
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 58db687fd96fcbb6a6b2909142df2fa01427add9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187635
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 55fbce80511a91d21fd8366f86786a0fb46b9357)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187681
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-12  Justin Luth  <justin.luth@collabora.com>  [23be40db1965b4ea40abef7b8a3f29680d0aa3c6]

        tdf#167358 Revert "tdf#156707 xmloff import: always provide ControlBorder
        
        ... property #2"
        
        This reverts my 25.2 commits d4dad2e181fd2dc30c3916fd59c05745023a51c8
        and 5a617f77ee803eb65051e93f659ef66433879052.
        
        Obviously this entire thing is just too broken
        for a simple guy like me to fix.
        
        It seems like each kind of control has its own definition
        of what should happen if the border is not specified.
        So much for ODF standardization of default style values...
        
        This makes it virtually impossible to force a setting at import time,
        and since styles (without specified fo:borders)
        could theoretically be shared between the different control types,
        it might also make it impossible to force an export as well?
        
        make CppunitTest_xmloff_style
        
        Change-Id: I0182878a16213ad2c7f06524fe85388aae86551f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187654
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit 0ad0fc985cc4b1c8f05df1e64752ae045127c051)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187700

2025-07-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1a006ca47bdf19a0d760c9522153cef0b905febe]

        update credits
        
        Change-Id: I709d0aa7b5aeaaf52510d268df40270c2ff6c1d8
        (cherry picked from commit cc651063eb41f751d40022bdb79ec1e641893909)

2025-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [6cdf407519e0c47b78073847943ad45289d631a6]

        libwebp: upgrade to 1.6.0
        
        Downloaded from https://storage.googleapis.com/downloads.webmproject.org/releases/webp/libwebp-1.6.0.tar.gz
        
        Change-Id: I77f3f8ca555f774f2c2b53ea41a8225f55be66f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187656
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [6747b0d80a9ae13229130b2867c5b938ba23ef5a]

        tdf#136753: Add Moldovan locale
        
        According to https://www.localeplanet.com/icu/ro-MD/index.html
        the short weekdays differ from ro-RO
        
        Change-Id: Ie1b9632d2b621e57f8e1040bca4996e4c1ee46c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187629
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187676
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [0868bc5d16daddc5d83bfb9f4bb062bdaa6edae2]

        related tdf#136753: fix Romanian's short weekdays
        
        Based on https://www.localeplanet.com/icu/ro-RO/index.html
        
        Also change "marţi" to "marți" as suggested in
        https://gerrit.libreoffice.org/c/core/+/187629/comment/06663c83_c0b8879b/
        
        Change-Id: Ia98b981229166f6ac731829525f04308d142f270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187636
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187675
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-11  Michael Stahl  <michael.stahl@collabora.com>  [71fcaee57b7c0d2a169c8764666572f38bc435f1]

        tdf#166975 sw: fix expansion of list level format with repeated levels
        
        SwNumRule::MakeNumString() would only replace each level's placeholder
        once in the format string; rework this so it iterates the whole format
        string.
        
        Change-Id: I1d0c5bf5c60c3003cc0257acfb69b37d209be617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186977
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e200c729797e7f3c19e958f9796a1d0fbae829d1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187020
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 1db81743594f7b858ff4d17c80a7366adee2b3fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187646
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-11  Kohei Yoshida  <kohei.yoshida@collabora.com>  [a67004f96ef4fd79be71c1d9f29341a60d49c8d3]

        Upgrade mdds to 3.1.0
        
        Change-Id: I449cc9a9654ddac143b33641ae955c393d404aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187605
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit e9632c5d3ab90a75d3615147e6ecec682f7bc15c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187671
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-11  Dr. David Alan Gilbert  <dave@treblig.org>  [5841c28ac114f2b664218fe2aa57bbd98fd3ec11]

        sdext,pdfimport: Fix stroke clipping
        
        The bounding clipping I added back in:
          abfbca271976 ("tdf#85428: Clip strokes")
        
        breaks 'thick' closed polygons, losing the closed flag.
        That's fixed by changing the bStroke flag to the clipper
        like done in svdpdf.cxx and svdfmtf.cxx
        
        This fixes the rendering of the top right box in:
          https://gitlab.freedesktop.org/poppler/poppler/-/issues/178
        
        Change-Id: Ib2ef27bef9860420b231cceaa2b0568c443d7f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187435
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        (cherry picked from commit 2f2f56f47f7ce8f7cdd581a6831ac9c3d7ce3be4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187672
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-11  Miklos Vajna  <vmiklos@collabora.com>  [3d3d51cd630ab45a61790be27e930e98c3e749e6]

        tdf#167379 sw floattable: make dummy paragraph from DOCX import less visible
        
        Open the bugdoc, the text C and D appears to have the same vertical
        position in Word, but D is shifted down in Writer.
        
        What happens is that since commit
        01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable: fix lost tables
        around a floating table from DOCX, 2023-06-05), an empty paragraph is
        inserted between two floating tables immediately following each other,
        to have a suitable anchor point for all floating tables. But it wasn't
        considered that the anchor point takes vertical space, which has an
        impact on layout.
        
        Fix the problem by keeping the empty paragraph in the model & layout
        (the split fly frame needs those), but setting the paragraph properties
        (spacing, line spacing) in a way that the created text frame has 0
        height, so it has no negative impact on the position of the text after
        the text frame.
        
        This is similar to what the DOC import does in
        WW8TabDesc::CreateSwTable(), though there we set the font size of the
        paragraph to 1pt, which improves the layout but still has a small
        impact. An alternative I considered is to set the "hidden" character
        property on the text node's item set, but that would create no text
        frame at all, so we would again have no anchor point for the floating
        table, so that would not work.
        
        Change-Id: Iceb2f51ad42028434822cb9c0701a7e6d6545845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187619
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 441aed20b95ee40dec1df72fb8e8167d0e48c0c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187645

2025-07-11  Jonathan Clark  <jonathan@libreoffice.org>  [34b35c4adb0176fc3b04f938f52485e531bd5a3a]

        tdf#64991 Remove unnecessary special case from IdctHint hack
        
        In order to emulate sprmCIdctHint support, the DOC importer uses a hack
        which splits the input text at script type changes and overrides fonts
        to make Writer's output match Word's.
        
        One special case in this algorithm was to override treatment of
        ASCII-range weak characters as Latin script. This special case had the
        unfortunate side effect of causing serious performance problems with
        non-Latin DOC files, as what would otherwise be treated as normal text
        was split into an excessive number of spans at any ASCII-range weak
        character (including space characters). This special case was also
        unnecessary, as our default implementation already handles these
        characters the same way Microsoft Word does.
        
        This change deletes that special case. This should resolve the
        performance issue, and shouldn't otherwise affect document layout.
        
        Since this hack was added, Writer has gained support for its own version
        of script type hinting. Currently, that implementation isn't perfectly
        compatible with DOC/DOCX, but in the future we should be able to delete
        this entire workaround and support sprmCIdctHint natively.
        
        Change-Id: I25ffe38efc963b8d569e2911c64a70852e22c679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187602
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 7ef1c437f30b0869a5b9fa33809bac2c6665ace3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187610
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fc3baba5ee80226c0f11232dbf07ce507d4f63d1]

        improve builddir!=srcdir detection with case-preserving filesystems
        
        on Windows and macOS autogen.sh could misdetect the build directory as
        being different from the source directory if the filesystem is
        case-preserving but not case-sensitive. e.g.
        
        cd ~/BuildDir ; ~/builddir/autogen.sh
        
        It is the same directory, but treated as a different one and thus
        autogen would create the module/Makefile files and also a link to the
        include directory. That however then ends up being a include/include
        link and that then fails the skia build.
        
        So use the same method to get both paths to avoid the problem.
        Change from cwd() to getcwd() since despite the documentation saying it
        would be the same, getcwd is actually returning the actual name as
        stored in the filesystem. Also use the module's chdir so that the PWD
        environment variable doesn't need to be set manually.
        
        Change-Id: I705dc584a91be9f63052bd1f72d4a0c4ba73f3ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187536
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        (cherry picked from commit 037de86626d2860969860d61d63f35e804f19c85)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187560
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [6fa6edff1f5191ce3ecb076f99b9320f8108cda8]

        related tdf#166813: improve pocheck script
        
        * Check the number of opening and closing parentheses,
        brackets and square brackets are the same
        * Check {&DialogHeading} and {&DialogDefaultBold} are
        at the beginning of the string.
        the translation here
        * Check [ProductName] is kept. It's just a warning
        so pocheck doesn't remove the translation here
        
        Change-Id: Ica06e22ec547375b84ed829da12178b5976b357c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 297dc9b6c52a9a2451c3ac7484ae484b9590fcc3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187630
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-10  Dr. David Alan Gilbert  <dave@treblig.org>  [116b72befc7db5424398fe7ce666cc9f8e87884f]

        sdext,pdfimport: Fix stroke opacity export
        
        updateStrokeColor was reading the Fill opacity not the stroke opacity.
        
        Fixes opacity of the top right box in:
          https://gitlab.freedesktop.org/poppler/poppler/-/issues/178
        
        Change-Id: Ie35d99a085df41b902185510b7801d58c409c532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187410
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        (cherry picked from commit 744b0b4634171841df24ec7a8094f95e12058048)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187611
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [17f99c0af73fbd497d7d258d83b4d40496a2a808]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to ecba6115bcd59dc8af4f0c3b29b6a986a5ca82d3
          - update translations for master/25.8.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: Ic56ae707dd61a28109f35d652e1f5e420a146941
            (cherry picked from commit 6fcf507b1c9eee02d307f987dfb3eea02dee5bf1)
            
2025-07-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a2efe54a1d813b852763479a351a1045bc5c9027]

        tdf#167409 set alt. text to the internal hyperlinks in a TOC
        
        The alt. text that is set is the TOC entry text.
        
        Change-Id: I8a9012cd7a6155f0672e0e8019ec1183d01cdcb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187556
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit e2be650d97765945538614463b9269acb164947c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187598
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-09  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [8c2bb1d14d350afbca228204c3b8aa29bac071d5]

        tdf#164970 Update .uno:ChangeTheme as per current themes implementation
        
        Before the themes rework, the document appearance and the application
        appearance were separately managed which is not the case now. Now themes
        map to appearance modes as follows:
        
            Custom theme -> AppearanceMode::AUTO
            Automatic    -> AppearanceMode::AUTO
            Light        -> AppearanceMode::LIGHT
            Dark         -> AppearanceMode::DARK
        
        The current implementation toggles between Light and Dark themes except
        for the case where the current theme is a custom theme.
        
        Change-Id: I6062924a36c7848794a7588cee157333fc3e5e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186233
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam@collabora.com>
        (cherry picked from commit 9645c6d4e5cd0841d9d9e474ce5f27cec8fcda1c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187579
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-07-09  Balazs Varga  <balazs.varga@collabora.com>  [411820caff6cbf01aa0affc01c11eefed02b9f98]

        tdf#167171 - fix MATCH function wrong result with inline arrays
        
        Better to use the original algorithm for searching in inline arrays.
        
        Regression from: f7039822c7ad3987326e1c20ea4a745c158f9682
        
        Change-Id: I4a80b7abda96006c16b3fd316225e8e24ace8c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187492
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
        (cherry picked from commit aa4b18b720746038206152689ef31231d474b8a4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187563
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [827b066d5d6f313585f62b2c06914c430ce5a787]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to f4f0ac39b1c0ddabc292c26b4edd6be37e7a0f9f
          - update translations for master/25.8.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I6d1a6dbc01f4c69cb3924ef620581520e5a328c5
            (cherry picked from commit 19544bd823de80857919822e0ee8535c46a946af)
            
2025-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [256737875d23442cb14c34d5168779e525c5f5e3]

        tdf#96151: Add Albanian locale
        
        Most of the information has been extracted from
        https://www.localeplanet.com/icu/sq-AL/index.html
        
        Jona Azizaj also helped to translate some strings.
        Thanks for that.
        
        Finally, many thanks to Eike Rathke for his valuable
        clues and reviews in gerrit on how to add a new locale
        
        Change-Id: Ibf762e7983f9e4aaf81ad8965f31d69fae0fd7ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186666
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        (cherry picked from commit 4e93d5a13c79fd1d027538ba7ec70574262d966b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187548
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [fcb8b7e6634bc8d4139798a5ff5bdadb2e2d1e05]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 654d3a08a1ae75d77fd7db252b068c7526aab4be
          - update translations for master/25.8.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: Id5436a18b16c5ab44ec71a73a5e49d9acbb1a340
            (cherry picked from commit c60899a361bfcf4a0eff6550bb685ace165527a8)
            
2025-07-08  Miklos Vajna  <vmiklos@collabora.com>  [5e1b3f3286d46421de83ec54a1f563ac82f1a76c]

        tdf#167229 sw floattable: fix missing cell background with redlines
        
        Open the DOCX file, the 3rd table should have a gray background in its
        B2 cell, but its background is white.
        
        It seems this happens because there are 2 floating tables before the
        table and the first floating table has a redline. Commit
        288db6eb47fbbd2b3ca34ffea0686d8ed8ed9be9 (tdf#132271 DOCX: import change
        tracking in floating tables, 2020-09-07) added special handling of
        redlines inside floating tables, and I moved that code around for
        SwFormatFlySplit in c50bf5a5daaae3d40f89ea0784a75a8a571c208d (sw
        floattable: remove no longer needed DOCX import heuristics, 2023-04-12).
        The trouble is that once these pending redlines are processed, nobody
        clears rFramedRedlines, so it gets processed also for a next floating
        table, which pollutes the state of the importer, which leads to missing
        cell properties for later tables.
        
        Fix the problem by clearing the redline list in
        DomainMapperTableHandler::endTable(), which restores the invariant that
        once the redline list is processed, it's cleared -- that was there in
        the old SectionPropertyMap::CloseSectionGroup() code before the
        SwFormatFlySplit work.
        
        An alternative I've considered is to just catch exceptions in
        BeforeConvertToTextFrame() when getting the TextTable and Cell
        properties, but that would still result in this unwanted behavior that a
        floattable-with-redlines has an influance on the next floattable.
        
        Change-Id: I9998a46d72a72172dffcf85bf96b3478d63c9269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187535
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit f124b25380a8ae9f5bbae7ca04772124a6572926)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187538
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-07  Miklos Vajna  <vmiklos@collabora.com>  [f78afc8cb33d866f1e97dae6784ddb816ce8dad6]

        tdf#166319 sw interdependent redlines: fix redo of accept of ins-then-fmt's fmt
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins>, go to middle of BB,
        accept, undo, redo: there is no format redline in the document, but
        there should be one.
        
        What happens is that the "accept" action creates an SwUndoAcceptRedline
        with the default depth = 0, but then it carefully calls
        lcl_DeleteInnerRedline() in
        sw::DocumentRedlineManager::AcceptRedlineRange() instead of a plain
        accept.
        
        The undo action already knows how to only accept the underlying redline,
        so fix the problem in sw::DocumentRedlineManager::AcceptRedlineRange()
        by correctly recording the UI action with depth = 1, which gives us both
        working undo & redo.
        
        The exec of the undo action's redo calls
        sw::DocumentRedlineManager::AcceptRedline(), which now calls the same
        lcl_DeleteInnerRedline() as the original UI action, so this looks
        consistent now.
        
        Change-Id: Ibb21c0745f3dd0aacec7cf7448c7c85245dbee69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187480
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d7bf3a17cb27da1a58163e9db657f0a8d8344901)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187493
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0fe97911197dbf72928d1fb53ecfad36cc9d7741]

        bump product version to 25.8.0.1.0+
        
        Change-Id: I743bbcdfb445e9e47d1ab83413aaac3ed92b6f9a

2025-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [4cab290de15aba542b64f26f2417d1d6a2920b11]

        Update git submodules
        
        * Update dictionaries from branch 'libreoffice-25-8'
          to 91336549281133e6847f610101b6afe87d954652
          - Upgrade Mongolian dictionary to 2025.07.04
            
            https: //github.com/bataak/dict-mn/archive/refs/tags/2025.07.04.zip
            Change-Id: I7446decb5b84639ef8505c69ba298afb8af4c450
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/187484
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            (cherry picked from commit 537912c9b3b8f1e79a3fe8750777023218c3df2c)
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/187485
            
2025-07-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [11f6e2093c94abf72f9795021a5f54c59418e991]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to bd755929b03232c097220de40114bbc068e99724
          - update translations for master/25.8.0 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I99719103c932e057b1f1d5a4382c556a67038f8d
            (cherry picked from commit c12263a6cf66b94845d40f3e3f960e34358cf11b)
            
2025-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [3de369a68b3b49bbdf78d5773bdbe20c2e703b99]

        poppler: upgrade to 25.07
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.07.0.tar.xz
        
        Change-Id: Ia38e14845351ba5300613fd4ecd055bea45150e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187429
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 406bcd8066cd94dfb2e39454fe32543eafd01428)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187434

2025-07-04  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [09804b8a8b6dd41e2e17ab25f5ce6b6d90b14633]

        sw: add fallback for page styles using UIName identifiers
        
        Change-Id: I3cbbaaa54784f1b11a34c7711df12770885ffb8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187354
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy@collabora.com>
        (cherry picked from commit edc6bd92c937aab0403c29e6f960da51cf5e75d2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187356

2025-07-04  Jonathan Clark  <jonathan@libreoffice.org>  [bb524f6e95c70021463a72de106bf4348f660acd]

        tdf#166339 skia: Tune font gamma to improve contrast
        
        Added platform-specific adjustments for font gamma curve and contrast.
        For most platforms, the default values from BUILD.gn are used. For
        Windows, the values are based on manual testing to subjectively recover
        as much contrast as possible while still reducing subpixel antialiasing
        artifacts to a reasonable level.
        
        Change-Id: If6898ed6eff3766bbb0ce3032fe7bb1fea13128a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187416
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 3a14edb8b3fd295190291c1371b76399aef50303)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187427
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e50e460a2eb590c33e1274f27bd0f4821166fa7c]

        column width missing in signature treeview column list
        
        which causes some problems.
        
        reproduce on desktop with:
        
        SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice xmlsecurity/qa/unit/signing/data/signatureline.odt
        and the column with heading "Signature type" appears blank unless you
        select the seperator between it and Description and move it, at which
        point "XAdES" appears
        
        while in lokit there is a out-of-bound crash:
        
         #8  0x00007f830d436902 in abort () from target:/lib64/libc.so.6
         #9  0x00007f830d6a84e9 in __gnu_debug::_Error_formatter::_M_error() const [clone .cold] () from target:/lib64/libstdc++.so.6
         #10 0x00007f830518aa13 in std::__debug::vector<std::unique_ptr<SvLBoxTab, std::default_delete<SvLBoxTab> >, std::allocator<std::unique_ptr<SvLBoxTab, std::default_delete<SvLBoxTab> > > >::operator[] (this=0x4e31dfa8, __n=6) at /usr/include/c++/14/debug/vector:517
         #11 0x00007f8305183b4d in SvTreeListBox::GetTab (this=0x4e31dbb0, pEntry=0x4e349e00, pItem=0x4b857ab0) at vcl/source/treelist/treelistbox.cxx:3203
         #12 0x00007f830513529c in lcl_DumpEntryAndSiblings (rJsonWriter=..., pEntry=0x4e349e00, pTabListBox=0x4e31dbb0, bCheckButtons=false)
             at vcl/source/treelist/svtabbx.cxx:102
         #13 0x00007f8305135f7b in SvTabListBox::DumpAsPropertyTree (this=0x4e31dbb0, rJsonWriter=...) at vcl/source/treelist/svtabbx.cxx:217
         #14 0x00007f830513868b in SvHeaderTabListBox::DumpAsPropertyTree (this=0x4e31dbb0, rJsonWriter=...) at vcl/source/treelist/svtabbx.cxx:647
         #15 0x00007f83058951b1 in JSDialogNotifyIdle::generateWidgetUpdate (this=0x4e32b530, pWindow=...) at vcl/jsdialog/jsdialogsender.cxx:111
        
        Change-Id: Ia617d18c9cdf1170f50cbda3082e548777196dcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187351
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 1cb5d4338d8467645494b5723b35aba031aea51b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187360
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 9e96f6977cee732d96b582cfb0622267c99fa454)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187371
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-04  SilverGreen93  <mihai.vasiliu.93@gmail.com>  [c5d042c66ea96ccf467a6f132cdf704c3e5f081c]

        tdf#167273: Fix typos in Theme Color Edit dialog
        
        Change-Id: I675b9fb8eb3e02e4630227868b60638d580ea6eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187118
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins
        (cherry picked from commit 53abfabf8f4080fde688789f966b70ef3caa387b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187396
        Reviewed-by: Mihai Vasiliu <mihai.vasiliu.93@gmail.com>

2025-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [ad76806524aae8c07481b0e4133c24f20c4fc687]

        tdf#167378: handle css::bridge::oleautomation::Date in CellValueSetter
        
        Commit 63e7a70ad1a6a8ec4190ab510f683d2fc9dea417 (tdf#164811: swap the
        "if IsCompatibility()" branches to match other places, 2025-01-23)
        made dates be passed as oleautomation::Date in VBA compatibility
        mode. These values were handled in CellValueGetter::processValue; but
        CellValueSetter::processValue lacked similar handling. This change
        fixes the omission.
        
        Change-Id: I8e97792f2014f16bf9a7520fcb6c46848d9fa938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187393
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e90e4b81b049a9d7c36de8d7f0371e2da7c60c01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187408
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [25fc475be265d44487f569c7b61a304eecb4ea9c]

        tdf#167080 macOS: fix opening PDFs in signed builds
        
        the parent-launch constraints worked for their intended purpose, but for
        the wrong reason. External launches weren't blocked because the parent
        didn't match the constraints, but because the parent didn't have stuff
        defined/stuff that the OS didn't recognize. And that then also blocked
        the xpdfimport helper, which is used to import PDFs into LibreOffice.
        
        The parent-constraints are set via the --launch-constraint-parent flag
        when running codesign, but was also added as an additional dict layer in
        the plist file, and that apparently is not valid, but still accepted.
        
        In Console.app, the block should be logged with
        
        c[4]p[2]m[1]e[0], (Constraint not matched)
        
        constraint identifier 4, i.e. launch constraint
        process identifier 2, i.e. related to the parent process
        match result 1, i.e. the launch constraints not matched
        error code 0, i.e. no error
        
        instead it was
        c[4]p[2]m[5]e[5], (parent-constraints)
        a generic parent-constraints error with
        match result 5, "The operating system couldn’t match the executable file
        with the constraint, because the constraint contains a non-optional fact
        that isn’t defined for the executable file."
        so far no difference to the expected validation error, but the
        error code is 5, "The launch constraint contains a fact that the
        operating system doesn’t recognize."
        So even LibreOffice itself didn't qualify as a parent process and the
        xpdfimport helper was blocked.
        
        see also:
        https://developer.apple.com/documentation/security/applying-launch-environment-and-library-constraints
        
        Change-Id: I0debdb87f04a69f58fcb543d027bdc3b9a4ea0cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187412
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        (cherry picked from commit 14b5fa6d6cadd8be1c62017c4d500903b4a6f386)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187415

2025-07-04  Kurt Nordback  <kurt.nordback@collabora.com>  [1abd106a51db4040ba50a58ca1c253c391b2c230]

        tdf#165742 Step 4.6: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from
        OOXML and re-export.
        
        Fix an existing bug in chart import, which results in the incorrect
        default value for stroke width on chart shapes. This was discovered
        in testing chartex and can be reproduced in a hand-edited pre-2016
        file (<c> namespace), but may not manifest there in practice since
        it appears MS Office may always output an explicit stroke width for
        pre-2016 charts.
        
        Change-Id: I458ae6ad0eaf28bf933c8ae0baed36e48df114b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186582
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit c8b26350d9aaf9cc8f8202ab66d199700f3be604)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187380
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [64dd4e00b83ea841c0ca4b8c793b9d99ed6913d0]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to a0190cd409b3425e84f437533357e24493981dbf
          - update translations for master/25.8
            
            and force-fix errors using pocheck
            
            Change-Id: Idc4579eddc641db5e817c38f8c65f033a31b44ed
            (cherry picked from commit 03101f782608a0ef33500fa4bed5ede18b774416)
            
          - update translations for master/25.8.0 RC1
            
            and force-fix errors using pocheck
            
            Change-Id: Ibf5ce39b9d60647ef6309aa492e3a7af10f09d53
            (cherry picked from commit 711561bb9108e4424245b7b47c6fecc47dd32707)
            
2025-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [1a049194638a715ecf7020401adfb3a8b8810a9b]

        fontconfig: fix build
        
        after
        commit 0798f0f6e00e6c099cdf45c8356739ea2cc214ff
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Thu Jul 3 15:57:20 2025 +0200
        
            fontconfig: upgrade to 2.17.1
        
        Change-Id: I226f53c1086ff86d53e85f3b2b3c6d74378b68ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187376
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-07-04  Jonathan Clark  <jonathan@libreoffice.org>  [d96e5bc3379fa3ae7119f49fd2083c882e551cbe]

        tdf#166339 vcl: Use gamma-corrected font rendering in Skia
        
        Reverts the following commit:
        
        commit 2b00d3deb2d637916c142ef03a5e31ac5189f314
        Date:   Tue Mar 17 16:09:08 2020 +0100
        
            do not use Skia's gamma correction for text
        
            Using SK_GAMMA_APPLY_TO_A8 seems to be Skia's build default, but
            it makes fonts harder to see (gray instead of black). With this change,
            Skia now looks to be pixel-perfect when compared with the gen VCL
            backend.
        
        This commit disabled gamma correction for text rendered by Skia under
        X11. Disabling gamma-correct rendering causes nasty artifacts, like
        fringing or text appearing as the wrong weight.
        
        The main consequence of this change is that GUI text may appear lighter
        than it does under backends that don't handle gamma correctly. Skia
        provides some parameters we can tune if needed, but it would be better
        to fix those backends instead.
        
        Change-Id: I6a4d90e33a57cbb397bcc9539a3c307a370c8b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187348
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 6e7860f021b27193b44f803b1e39f3508559bb47)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187357
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [cbc25a18675d83193cc72313389f08e5c07f038f]

        fontconfig: upgrade to 2.17.1
        
        Downloaded from https://gitlab.freedesktop.org/api/v4/projects/890/packages/generic/fontconfig/2.17.1/fontconfig-2.17.1.tar.xz
        
        Change-Id: I5a2235de014e73e020c2330536487e9446b35fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187338
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 0798f0f6e00e6c099cdf45c8356739ea2cc214ff)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187343

2025-07-03  Justin Luth  <jluth@mail.com>  [fca3052a08f0eb6ffe161c0eb3bb7ef8548351f2]

        tdf#161521 tdf#166305 docx export: fix page margins when mirrorMargins
        
        This patch is basically Oliver's original work
        that he reverted in tdf#165083.
        
        His problem was that he trusted Sections().CurrentSectionInfo()
        to be accurate in this context.
        I substituted m_pCurrentPageDesc.
        
        make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf153196
        
        Change-Id: Iedce7b6460664301f65f3ce2cf0a97c4e26194d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186696
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        (cherry picked from commit a4e7d0028efb8fa07d0877aff81fb406f9464fb4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186719
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [22f305abd226adabaf3340bbf8d286b904460b12]

        openssl: upgrade to 3.0.17
        
        Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.17/openssl-3.0.17.tar.gz
        
        Change-Id: I2b796bc9c6917ecc92032d011ef7a3c4bd266c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187326
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit e0e04ab7eb742b373fadd252c8de17f48177fef8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187334

2025-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [ba39f47385302c6cbbbb2a72fa5218dd1f82514d]

        sw: use SAL_RET_MAYBENULL in GetSfxViewShell()
        
        after
        commit 7ac9630d2258ae4b40917b79b38fa6cab0842078
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Tue Jul 1 09:24:54 2025 +0100
        
            null GetSfxViewShell() deref
        
        Change-Id: If7e5019cf49917d163b36fc1aab24de64e10c4ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187242
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 7768dd07b87c4e94365aceba1a8342d894dbc3d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187336

2025-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [817d32963f58cf9cc8d6624acec679d7af2b7fa3]

        tdf#167338 sw a11y: Set a11y names for envelope orientations
        
        Set the accessible name to the same strings as are
        already used for the tooltips.
        This makes screenreaders announce what these radio
        buttons are about, instead of just saying "radio button"
        for these items in the "Printer" tab of Writer's
        "Envelope" dialog ("Insert" -> "Envelope").
        
        Change-Id: Ie219cddedd1abcb98e3ad4b870b8f1fe50410827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187260
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 7e59eaaf2eb2690c870fcdf43160880f62fbfd6c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187262
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [354ddaa0f4ee3fde0be8bc65a5d0c4bfc620080f]

        libpng: upgrade to 1.6.50
        
        Downloaded from
        https://sourceforge.net/projects/libpng/files/libpng16/1.6.50/libpng-1.6.50.tar.xz/download
        
        Change-Id: I4906134e3343ab541b64e27d47d63519b5a49bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187310
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 9ffd4bf12d953159f68d509902112c8b43062a9b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187328

2025-07-03  Regina Henschel  <rb.henschel@t-online.de>  [f422d1366269a0fa611f7018dd73d933e7d2ca6e]

        tdf#167134 Allow different directions in LOOKUP
        
        ... for search vector and result vector when such vectors are given as
        inline array.
        
        AOO, Excel, Gnumeric and older LO versions allow it. Different
        directions are also possible if the vector is given by a cell range.
        
        The unintended change slipped in with commit
        5079e1fb668b31989672efc097c82ced6cbf4137.
        
        Besides the unit test for tdf#167134, I have added a second unit test
        about other situations that have inline arrays as parameter of LOOKUP.
        LO does currently not fail for them, but this test might prevent
        unintended behavior changes in the future. Such tests do not yet exist.
        
        Change-Id: I21dd6b75d54aa938dcffbd2375acc51d3168b904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187289
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        (cherry picked from commit 5c0961129820fbc9dc8ec12c8a43a352ef1856a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187302
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b6f61546283addf32488685813e60fa3214c2f5]

        use-after-free on deleted ViewShell
        
         #0  0x00007eef974b992d in __dynamic_cast () from /lib/x86_64-linux-gnu/libstdc++.so.6
         #1  0x00007eef83ffb326 in SdXImpressDocument::GetViewShell (this=this@entry=0x5511adc0)
             at sd/source/ui/unoidl/unomodel.cxx:3848
         #2  0x00007eef83ffb6dc in SdXImpressDocument::setClipboard (this=0x5511adc0, xClipboard=...)
             at sd/source/ui/unoidl/unomodel.cxx:4457
         #3  0x00007eef9336a4f8 in (anonymous namespace)::forceSetClipboardForCurrentView (pThis=<optimized out>)
             at desktop/source/lib/init.cxx:1379
        
        3848	    DrawViewShell* pViewSh = dynamic_cast<DrawViewShell*>(mpDocShell->GetViewShell());
        (gdb) print mbDisposed
        $1 = true
        
        an earlier sanitizer trace is:
        
        program/../program/libsdlo.so
            sd::DrawDocShell::GetViewShell()
                libreoffice/sd/source/ui/inc/DrawDocShell.hxx:109
        program/../program/libsdlo.so
            SdXImpressDocument::GetViewShell()
                libreoffice/sd/source/ui/unoidl/unomodel.cxx:3105
        program/../program/libsdlo.so
            SdXImpressDocument::setClipboard(com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard> const&)
                libreoffice/sd/source/ui/unoidl/unomodel.cxx:3676
        program/libmergedlo.so
            (anonymous namespace)::forceSetClipboardForCurrentView(_LibreOfficeKitDocument*)
                libreoffice/desktop/source/lib/init.cxx:1324
        program/libmergedlo.so
            doc_createViewWithOptions(_LibreOfficeKitDocument*, char const*)
                libreoffice/desktop/source/lib/init.cxx:6895
        /usr/bin/coolforkit
            lok::Document::createView(char const*)
                libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:549
        /usr/bin/coolforkit
            Document::load(std::shared_ptr<ChildSession> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
                kit/Kit.cpp:1912
        /usr/bin/coolforkit
            Document::onLoad(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)
                kit/Kit.cpp:1230
        /usr/bin/coolforkit
            ChildSession::loadDocument(StringVector const&)
                kit/ChildSession.cpp:905
        /usr/bin/coolforkit
            ChildSession::_handleInput(char const*, int)
                kit/ChildSession.cpp:297
        /usr/bin/coolforkit
            Session::handleMessage(std::vector<char, std::allocator<char> > const&)
                common/Session.cpp:288
        /usr/bin/coolforkit
            Document::forwardToChild(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::vector<char, std::allocator<char> > const&)
                kit/Kit.cpp:2048
        /usr/bin/coolforkit
            Document::drainQueue()
                kit/Kit.cpp:2271
        /usr/bin/coolforkit
            KitSocketPoll::drainQueue()
                kit/Kit.cpp:2668
        /usr/bin/coolforkit
            KitSocketPoll::kitPoll(int)
                kit/Kit.cpp:2747
        /usr/bin/coolforkit
            pollCallback(void*, int)
                kit/Kit.cpp:2838
        program/libmergedlo.so
            SvpSalInstance::ImplYield(bool, bool)
                libreoffice/vcl/headless/svpinst.cxx:430
        program/libmergedlo.so
            SvpSalInstance::DoYield(bool, bool)
                libreoffice/vcl/headless/svpinst.cxx:471
        program/libmergedlo.so
            ImplYield(bool, bool)
                libreoffice/vcl/source/app/svapp.cxx:396
        program/libmergedlo.so
            Application::Yield()
                libreoffice/vcl/source/app/svapp.cxx:480
        program/libmergedlo.so
            Application::Execute()
                libreoffice/vcl/source/app/svapp.cxx:374
        program/libmergedlo.so
            desktop::Desktop::Main()
                libreoffice/desktop/source/app/app.cxx:1605
        program/libmergedlo.so
            ImplSVMain()
                libreoffice/vcl/source/app/svmain.cxx:229
        program/libmergedlo.so
            soffice_main
                libreoffice/desktop/source/app/sofficemain.cxx:94
        program/libmergedlo.so
            lo_runLoop(_LibreOfficeKit*, int (*)(void*, int), void (*)(void*), void*)
                libreoffice/desktop/source/lib/init.cxx:7735
        /usr/bin/coolforkit
            lok::Office::runLoop(int (*)(void*, int), void (*)(void*), void*)
                libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:1128
        /usr/bin/coolforkit
            lokit_main(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, bool, bool, bool, bool, bool, unsigned long)
                kit/Kit.cpp:3495
        /usr/bin/coolforkit
            createLibreOfficeKit(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool, bool)
                kit/ForKit.cpp:450
        /usr/bin/coolforkit
            forkLibreOfficeKit(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)
                kit/ForKit.cpp:500
        /usr/bin/coolforkit
            forkit_main(int, char**)
                kit/ForKit.cpp:876
        /usr/bin/coolforkit
            main
                kit/forkit-main.cpp:19
        /lib64/libc.so.6
            __libc_start_main
                ??:?
        /usr/bin/coolforkit
            _start
                ??:?
        
        freed by thread T0 (kitbroker_011) here:
        /usr/bin/coolforkit
            operator delete(void*, unsigned long)
                /home/collabora/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_new_delete.cpp:172 (discriminator 5)
        program/libmergedlo.so
            SfxViewFrame::ReleaseObjectShell_Impl()
                libreoffice/sfx2/source/view/viewfrm.cxx:1167
        program/libmergedlo.so
            ~SfxViewFrame
                libreoffice/sfx2/source/view/viewfrm.cxx:1977
        program/libmergedlo.so
            SfxViewFrame::Close()
                libreoffice/sfx2/source/view/viewfrm.cxx:1189
        program/libmergedlo.so
            SfxFrame::DoClose_Impl()
                libreoffice/sfx2/source/view/frame.cxx:138
        
        Change-Id: Iec746b4473a20ba9c6b5e338f64f9f2380e2db13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187258
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 5de2f6822a06a92216b65cf241116404733f88ca)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187272
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [397695d6de0d36ee7b84954312c62d90c4d9acd5]

        null-deref of m_xChartDoc seen
        
         #0  0x00007d2c10f56497 in rtl::Reference<chart::Diagram>::Reference (handle=..., this=<optimized out>)
             at include/rtl/ref.hxx:79
         #1  chart::ReferenceSizeProvider::setValuesAtAllDataSeries (this=0x7ffce60d8d70)
             at chart2/source/tools/ReferenceSizeProvider.cxx:95
         #2  0x00007d2c10cd6a1f in chart::ChartController::impl_adaptDataSeriesAutoResize (this=<optimized out>)
             at chart2/source/controller/main/ChartController_Tools.cxx:192
         #3  0x00007d2c10cb3cec in operator() (nResult=<optimized out>, __closure=<optimized out>)
             at chart2/source/controller/main/ChartController.cxx:1672
         #4  std::__invoke_impl<void, chart::ChartController::executeDispatch_SourceData()::<lambda(int)>&, int> (__f=...)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/invoke.h:61
         #5  std::__invoke_r<void, chart::ChartController::executeDispatch_SourceData()::<lambda(int)>&, int> (__fn=...)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/invoke.h:111
         #6  std::_Function_handler<void(int), chart::ChartController::executeDispatch_SourceData()::<lambda(int)> >::_M_invoke(const std::_Any_data &, int &&) (__functor=..., __args#0=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/std_function.h:290
         #7  0x00007d2c134e2268 in std::function<void (int)>::operator()(int) const (__args#0=<optimized out>, this=0x7ffce60d8de0)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/std_function.h:591
         #8  Dialog::EndDialog (this=0x4abc7140, nResult=<optimized out>)
             at vcl/source/window/dialog.cxx:1213
        
        (gdb) print m_xChartDoc
        $3 = {m_pBody = 0x0}
        
        Change-Id: I6f2cdb176cf1acc7b000e24fa314a6cbe344a525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187277
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 08dd90f9a5b2f63999cc51fe72b48e1c26fca864)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187283
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Gülşah Köse  <gulsah.kose@collabora.com>  [f2f9c31cf8aa7127a902a2a2533d3760bd6cc3df]

        tdf#167082 Fix the missing style
        
        While we tracking change of the document, if action is delete and if it
        doesn't delete the whole node, we shoud use remaining text parts's
        style. If delete removes whole node we can use previous node' style.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Ie5cc40c12b9e2dad521ee35098630c94048d490f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187266
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit e3da51b84f58a1114fef0d9c5a2881eb05ad8f13)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187296
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-03  Jonathan Clark  <jonathan@libreoffice.org>  [8efaebbc54c3be7d76d9d0a9480f8d47473c65cf]

        tdf#166339 vcl: Removed Windows skia text gamma patch
        
        Reverts the following commit:
        
        commit 1ad3f6b8d9e0ef1e921c3ed5526ea352d67265cf
        Date:   Wed Mar 18 12:10:29 2020 +0100
        
            (do not) use SK_GAMMA_APPLY_TO_A8 also for Skia text on Windows
        
            This is the Windows variant of the SK_GAMMA_APPLY_TO_A8 disabling,
            again I don't quite understand why we need to disable this,
            but with this patch Skia text rendering on Windows seems to be
            pixel-perfect when compared with the VCL gen backend.
        
        The patch added by this commit disabled gamma correction for text
        rendered by Skia under Windows. Disabling gamma-correct rendering causes
        nasty artifacts, like fringing or text appearing as the wrong weight.
        
        Change-Id: I9116712f47e22398259ecc93b165879f0cf29563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187290
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit bfa28a257ae621747dddbb61f228705cf46079b8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187297
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b97e9372289c9418febd945951a39703c34be13f]

        tdf#163746 ODK API docs: place "optional" and "property" decorations
        
        closer to the definitions
        
        Change-Id: I29e3fdb57e5ee0acbbdd33fd2a9b2cb5f4e15736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187254
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        (cherry picked from commit b1fedaf2c150411a50cca5ba23033d3e0c3c42a6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187270
        Tested-by: Jenkins

2025-07-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d80c715c78e0b189344a272ab19478fc0f79f594]

        tdf#163747 ODK docs: CSS hack to add "unpublished" decoration
        
        Add an HTML_EXTRA_STYLESHEET setting to the Doxyfile of idl
        and remove HTML_TIMESTAMP = NO while at it (it is disabled by default
        since Doxygen 1.8.9).
        
        The hacky CSS rule is extra long due to the need to exclude
        *.idl File Reference pages from it.
        
        Change-Id: I848f6c216b68875fd032044f04ca72f5a5e2ed1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186595
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        (cherry picked from commit ddf77c92a59080f12603c1ecb5ea254a89a654d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187263
        Tested-by: Jenkins

2025-07-02  Khaled Hosny  <khaled@aliftype.com>  [302c6b987535f8ff1915be6a49ae3e651cc62661]

        tdf#126111: Don’t do glyph fallback for PUA codepoints
        
        Private Use Area codepoints are codepoints that Unicode reserves for
        private use, so they are typically tied to a specific font and a PUA
        code point in a different font can be a totally different symbol, so
        applying glyph fallback here is unlikely to give a sensible result.
        
        The bug documents in question misuse PUA codepoints not supported by the
        requested font to get an empty box (the font’s .notdef glyph), which
        would only happens if no glyph fallabck is done (or no font on the
        system supports this PUA code point).
        
        This fixes only the case when requested font is present and we do glyph
        fallback. If the requested font is missing, then we might still get PUA
        glyphs from the fallback font.
        
        Change-Id: I4688d098b40263e83bc9f2df1833cdc6286b7092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187012
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        (cherry picked from commit fcd817175711137c49793018dc9761f13326c863)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187135

2025-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [7e34c322d0e20f14b88d0fd18f200bfddc8dfb5d]

        nss: upgrade to 3.113.1
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_113_1_RTM/src/nss-3.113.1-with-nspr-4.36.tar.gz
        
        Change-Id: Ib5aed4732e2e4b98d6a3514a25b63a5eb32d8bf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187267
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-07-02  Kurt Nordback  <kurt.nordback@collabora.com>  [6161105b910df75bd60f23c0f7ed7924eca84376]

        tdf#165742 Step 4.4 follow-on: Fix a faulty assert
        
        In the earlier changes I introduced an assert that didn't properly consider
        a chart with multiple series. This is intended to fix that.
        
        Change-Id: I60f097ffae2e7f29aadc5bfaabc739c120be5fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187216
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 5427624c78f879ae83b5db1f5a0f67d3b4d04e2d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187223
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [f0d57a7df2452ed142b9aaa5511def521d26980a]

        crashtesting ooo120243-1.ods
        
        regression from
            commit c8742f36fa2bdc9d23042378f5b587ccda8b54dd
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 22 10:18:48 2025 +0200
            tdf#166684 reduce cost of CellAttributeHelper::registerAndCheck
        
        This is strictly speaking a workaround. I have no idea how improving the speed of
        searching ends up triggering a re-allocation of these data-structures.
        
        Change-Id: I13ac6d85aae7c56d1adfcabf1ca73381bfb81ac4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 68db5b64b8db405f9e6c0368836a8ee671b46830)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187164
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [42a0f7d838e4360fbb07a49fa310d0d5bc1813b1]

        tdf#167277: make LineNumberWindow and BreakPointWindow paint immediately
        
        ... on scroll. No idea why did it only show up with Vulkan; but for these
        windows, the immediate paint is the correct thing to do.
        
        The behavior of Paint wrt. SyncYOffset was changed: on invalidation, now
        it doesn't return from Paint, to avoid flicker (the background of windows
        is already erased; keeping it white until next paint can be noticed).
        
        Change-Id: I5d306122f4465ca4556cd5b8c69d5f047ce9b53f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187131
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 0a031b751a1b48260c33aa2fffd12dc075d0178d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187140
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [60146b4fe77013b044ae6a0a95a3a96e774da11c]

        Related: tdf#157738 use InterimItemWindow::GetFocus
        
        reuse the common Focus impl by enabling InitControlBase
        
        Change-Id: Ia281db9c685e25de268ebdfd35e095012e5fcfb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187158
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187171
        Tested-by: Jenkins

2025-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [8921083cf23707da59b71a7228a4d3d397c9cd19]

        tdf#167329: Make sure to invalidate inf flags properly
        
        Since commit b6bcc7ac278e0db22df02707789730ec123bf934 (tdf#166871:
        drop mnMaxParaPerPage hack, 2025-06-07), an assertion fails in some
        cases (see https://gerrit.libreoffice.org/c/core/+/186243/3#message-edb2ace35947927748d0bd37a36d95f2ddf67217 ).
        The call stack is:
         #19 __assert_fail in /lib64/libc.so.6
         #20 FindFrameInBody(SwAnchoredObject const&) at /home/caolan/LibreOffice/core/sw/source/core/layout/objectformattertxtfrm.cxx:605
         #21 SwObjectFormatterTextFrame::CheckMovedFwdCondition(SwAnchoredObject&, SwPageFrame const&, bool, unsigned int&, bool&, bool&) at /home/caolan/LibreOffice/core/sw/source/core/layout/objectformattertxtfrm.cxx:723 (discriminator 1)
         #22 SwFlyAtContentFrame::MakeAll(OutputDevice*) at /home/caolan/LibreOffice/core/sw/source/core/layout/flycnt.cxx:448 (discriminator 1)
         #23 SwFrame::PrepareMake(OutputDevice*) at /home/caolan/LibreOffice/core/sw/source/core/layout/calcmove.cxx:397
         #24 SwFrame::Calc(OutputDevice*) const at /home/caolan/LibreOffice/core/sw/source/core/layout/trvlfrm.cxx:1858
         #25 SwFlyFrame::Calc(OutputDevice*) const at /home/caolan/LibreOffice/core/sw/source/core/layout/fly.cxx:3441
         #26 SwObjectFormatter::FormatLayout_(SwLayoutFrame&) at /home/caolan/LibreOffice/core/sw/source/core/layout/objectformatter.cxx:210
        
        The problem is, that some frames don't get their flags invalidated
        on move, and then use some flag state possibly calculated outside
        of layout. E.g., creation of table in InsertCnt_ would add cells
        and insert their content in SwCellFrame ctor; during that, the cell
        has no upper, and any attempt of a lower to calculate its inf flags
        would set mbInfBody to false. In SwFlowFrame::PasteTree, pStart may
        also have inf flags inconsistent with the target position.
        
        This change makes SwFrame::InvalidateInfFlags also invalidate these
        flags in lowers (for layout frames), because obviously, when upper
        neest to update the flags, so should do lowers. This is similar to
        what was done in lcl_InvalidateInfFlags, which got simplified.
        
        Change-Id: Ic4898791bacef46415985b43f44fddfd533051f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187240
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 6a98a6fde70438fb189418ba722fc1ec907ec5ff)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187259
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a0c68c28f5102e4fd87ca03aa720fc69153d3fbb]

        null GetSfxViewShell() deref
        
         #0  0x00007d2c05299b40 in SwViewShell::SizeChgNotify (this=this@entry=0x3cd9f220) at sw/source/core/view/viewsh.cxx:1264
         #1  0x00007d2c04e7bfb8 in AdjustSizeChgNotify (pRoot=pRoot@entry=0x3c9a1af0) at sw/source/core/layout/pagechg.cxx:894
         #2  0x00007d2c04e7fa5d in SwRootFrame::CheckViewLayout (this=0x3c9a1af0, pViewOpt=pViewOpt@entry=0x0, pVisArea=pVisArea@entry=0x0)
             at sw/source/core/layout/pagechg.cxx:2490
         #3  0x00007d2c04e81819 in SwPageFrame::Paste (this=this@entry=0x3cf5c9b0, pParent=pParent@entry=0x3c9a1af0, pSibling=pSibling@entry=0x3cebf0d0)
             at sw/source/core/layout/pagechg.cxx:1010
         #4  0x00007d2c04e8498b in (anonymous namespace)::doInsertPage (pRoot=0x3c9a1af0, pRefSibling=0x7ffce60d5450, pFormat=<optimized out>, pDesc=<optimized out>, bFootnote=<optimized out>, pRefPage=0x7ffce60d5458)
             at sw/source/core/layout/pagechg.cxx:1396
         #5  0x00007d2c04e852a4 in SwFrame::InsertPage (this=this@entry=0x3cebe640, pPrevPage=0x3cebb780, bFootnote=bFootnote@entry=false)
             at sw/source/core/layout/pagechg.cxx:1475
         #6  0x00007d2c04eb3787 in SwFrame::GetNextSctLeaf (this=0x3cebe640, eMakePage=MAKEPAGE_INSERT) at sw/source/core/layout/sectfrm.cxx:1853
         #7  0x00007d2c04e35530 in SwFlowFrame::MoveFwd (this=this@entry=0x3cebe720, bMakePage=<optimized out>, bPageBreak=bPageBreak@entry=false, bMoveAlways=bMoveAlways@entry=false)
             at sw/source/core/layout/flowfrm.cxx:2148
         #8  0x00007d2c04e24732 in SwContentFrame::MakeAll (this=0x3cebe640) at sw/source/core/layout/calcmove.cxx:1930
         #9  0x00007d2c04e2184c in SwFrame::PrepareMake (this=0x3cebe640, pRenderContext=0x3c95db30) at sw/source/core/layout/calcmove.cxx:396
         #10 0x00007d2c04e3abe4 in CalcContent (pLay=pLay@entry=0x3ce01530, bNoColl=bNoColl@entry=false) at sw/source/core/layout/fly.cxx:1764
         #11 0x00007d2c04ee2079 in SwLayoutFrame::FormatWidthCols (this=this@entry=0x3ce01530, rAttrs=..., nBorder=nBorder@entry=0, nMinHeight=nMinHeight@entry=23)
             at sw/source/core/layout/wsfrm.cxx:4013
        
        (gdb) print mpSfxViewShell
        $3 = (SfxViewShell *) 0x0
        
        Change-Id: I2e0f21a442791260e8b79e38965c8da7e41656cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 7ac9630d2258ae4b40917b79b38fa6cab0842078)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187241
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ac4061b54c774e00e52bb5706f43e455459511bf]

        tdf#167165: check if node allows creating SwXTextRange
        
        Avoids warnings in debug console:
        
          warn:sw.core:23908:27188:sw/source/core/doc/docbm.cxx:590: MarkManager::makeMark(..) - refusing to create mark on non-textnode
          warn:sw.ui:23908:27188:sw/source/uibase/docvw/edtwin2.cxx:476: DBG_UNHANDLED_EXCEPTION in RequestHelp
              when: failed to retrieve hyperlink name exception: com.sun.star.uno.RuntimeException message: "range has no mark (table?) at C:/lo/core/sw/source/core/unocore/unoobj2.cxx:1498"
        
        Change-Id: I6261c402f837668b0851ce736c724ca2bb24d2b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186810
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e027fe45486bcdbadb65fa4d3e7be269367150cb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186942
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [b8df40c4fbef42c2c51258aaed03591b1ff0934c]

        tdf#167178: make sure to synchronize the tab in AdjustUpdatedRanges
        
        The change could adjust the tab in the aRanges; but aRange still has
        the original tab number. It needs to be updated.
        
        Regression after commit a0403b6eb25a99f6225e0f77f4b14d78f4045c9e
        (tdf#47479: Do not modify range of sheet / column / row in
        notifications, 2025-05-02).
        
        Change-Id: I248f5575ffc7fe388a65cb8bc0007ec72d9f2129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186906
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 1761796355277ba3a47143729e027a829802b4a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186926
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Kurt Nordback  <kurt.nordback@collabora.com>  [b5f3a27fef394c9b27e515f2efa226719dd9a517]

        tdf#165742 Step 4.5: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from
        OOXML and re-export.
        
        Additional support for title and axis import and export in chartex,
        plus one small added regression test.
        
        Change-Id: I96ae551623dfbbdc3792e0b882a875c1a6293a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186578
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit 41dcb22e68ac9bf9ef2b2de28d8578344f8b9583)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187061
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9774e2c75c3601ac2bd9bcd5f9eb85097e99645d]

        Resolves: tdf#157738 don't break mouse capture by grabbing focus
        
        if the parent has captured the mouse, then don't grab focus to
        another widget hierarchy
        
        Change-Id: Ide0bee2e34f5ff519d2c10162d88dbaa2be7a6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187159
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187170

2025-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a7e4d70072314957fd3484251f3775099097cd2a]

        tdf#149151: disambiguate method parameters and array indexes
        
        SbiRuntime::FindElement ends with a call to CheckArray(). The latter
        takes a variable, checks if that is an array and if it has parameters;
        and if both are true, tries to obtain an element of the array defined
        by the parameters as array indexes (using SbxDimArray::Get).
        
        The problem was, that the variable may actually be array; it may have
        parameters; but this array can be the result of a function call; the
        variable may be SbxMethod; and the parameters may be for the function,
        not array indexes.
        
        Specifically, the call like
        
          Iif(True, Array("A","B"), Array("B","A"))
        
        searched for an entity named Iif; found that it was a RTL method;
        prepared the arguments for it (consisting of four elements: 0 - the
        method itself; 1 - boolean True; 2 - array ["A", "B"]; 3 - array
        ["B", "A"]); the function executed, putting the correct value to the
        params[0], which was the method itself (so its value became an array);
        and finally, the SbxMethod variable with the array value got passed
        to CheckArray. The latter found out that it's an array, and that it
        has parameters (those four) - and tried to get the element, which
        index was defined by the parameters.
        
        Here comes the specifics of LibreOffice Basic's argument handling.
        SbxDimArray::Get only cares about first arguments expected by the
        array dimensions; it ignores the rest. Since the array was single-
        dimensional, it only considered parameter 1 (parameter 0 is, by
        convention, reserved for return value). That was a boolean. When it
        was False, its GetInteger returned 0; and finally, CheckArray took
        element 0 from the array, returning a scalar value, as if it was
        
          Iif(False, Array("A","B"), Array("B","A"))(0)
        
        But when the boolean was True, another Basic specific took place:
        its numerical value is -1; and trying to get element -1 from the
        array resulted in "Index out of defined range".
        
        This change disambiguates between the cases of array index, and
        function parameters, checking if the variable itself, and its 0th
        parameter are both SbxMethods. Then it doesn't try to treat the
        parameters as indexes into the array.
        
        Change-Id: I597f94a7e688c8bba12d87a1bd5871491c25cac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187145
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 99247bfc4e42652baddf606f90e31fb4d22006ab)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187165
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c71c712857d14747fc700594d6f6878b7bd6231b]

        crashtesting forum-mso-en4-307539.xlsx
        
        regression from
            commit 79322a7025bb6fd61928204f90230560b09b4ba9
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed May 21 15:28:41 2025 +0200
            tdf#166684 strip out some unnecessary UNO work
        
        Change-Id: Ifab9b928f6c4dd660e9bf3812a8f6e4c2cd73b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187160
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 8ebd114b91678d3cc4f1582fbe2ba4f7d479993e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187163
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [141f268dde71f29b89f103d620a2eadc150905fc]

        this signal_focus_in should be signal_focus_out
        
        Change-Id: I0658109df847c430089e201245c3f516a1264998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187116
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 27d008999ff78495c2b5da6ebc220c79ea09eb36)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187198
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-07-01  Michael Weghorn  <m.weghorn@posteo.de>  [025ae65c20d2c89ca05ce3ab5c9eb7fb185bfdfc]

        tdf#100876 sd a11y: Use pane title as a11y name
        
        TitledDockingWindow::m_sTitle is used for
        the title to display for that docking window. Also
        set it as an accessible name, so it is also available
        to assistive technologies.
        
        This e.g. makes clear when the "Slides" pane gets reached (its close
        button receives focus) in Impress when cycling through panes using
        the F6 key.
        
        Change-Id: I5e6221cdf5ee9365372c639db59b0156d278d4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187183
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 0e46139d181279be80774051b01f1c268de738de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187214
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-01  Michael Weghorn  <m.weghorn@posteo.de>  [fb82eca16431e0c6a3044a8c9aa1237c4fcf39e0]

        tdf#167296 sd a11y: Use better accessible role for slides view
        
        Don't use the DOCUMENT role for the slides view in Impress,
        as this is not the actual document, but only contains
        previews of the slides.
        Use the PANEL role instead.
        
        This also stops confusing the NVDA screen reader on Windows
        which was running into an exception trying to generate a text
        representation for the newly selected/focused slide when switching
        them. It now instead announce the accessible name/slide title as
        expected.
        
        Error/Backtrace seen with NVDA git master as of commit
        9e668b18fa397726382d3095656212de8d1b1d7e without this
        commit in place:
        
            ERROR - eventHandler.executeEvent (13:46:32.234) - MainThread (10300):
            error executing event: gainFocus on <NVDAObjects.IAccessible.IAccessible object at 0x0AEBDFF0> with extra args of {}
            Traceback (most recent call last):
              File "eventHandler.py", line 348, in executeEvent
                if isGainFocus and not doPreGainFocus(obj, sleepMode=sleepMode):
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "eventHandler.py", line 382, in doPreGainFocus
                if not api.setFocusObject(obj):
                       ^^^^^^^^^^^^^^^^^^^^^^^
              File "api.py", line 189, in setFocusObject
                setNavigatorObject(obj, isFocus=True)
              File "api.py", line 348, in setNavigatorObject
                review.setCurrentMode("document", False)
              File "review.py", line 140, in setCurrentMode
                pos = func(obj)
                      ^^^^^^^^^
              File "review.py", line 59, in getDocumentPosition
                pos = obj.treeInterceptor.makeTextInfo(obj)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "documentBase.py", line 76, in makeTextInfo
                return self.TextInfo(self, position)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "compoundDocuments.py", line 287, in __init__
                self._start = self._end = self._startObj.makeTextInfo(position)
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "documentBase.py", line 76, in makeTextInfo
                return self.TextInfo(self, position)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "textInfos\offsets.py", line 505, in __init__
                self._startOffset = self._endOffset = self._getCaretOffset()
                                                      ^^^^^^^^^^^^^^^^^^^^^^
              File "textInfos\offsets.py", line 267, in _getCaretOffset
                raise NotImplementedError
            NotImplementedError
        
        Change-Id: Iacf1ecd624088d7c8fe693f71b4d5ed264584bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187188
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit 697fadb8f4efdc09091088261ca1b43984c029b4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187215
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-07-01  Rene Engelhard  <rene@rene-engelhard.de>  [355911b97d4f6347f14d8529252c8f1cd8e6a5cf]

        deb#1100930 apparmor: allow /etc/paperspecs in program.soffice.bin
        
        as used by paperconf
        
        Change-Id: I56896abcd174da234b77fb7a250e1718bac08adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184172
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 8398a128160b557d979de37d11979f304926d686)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187166
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-30  Heiko Tietze  <tietze.heiko@gmail.com>  [3b1cc18a0d1caf64104f9962011a4781b90b915a]

        Resolves tdf#167219 - Invert infobar colors on dark background
        
        Change-Id: I592509bcdb74ef5ac88a1cab51c2ffc978a19ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187200
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-06-30  Michael Weghorn  <m.weghorn@posteo.de>  [221dd89ad4366306067d2eb6d534ade05401c214]

        tdf#167274 svx: Set drawing area for ImageMap dialog early
        
        For the gtk3 VCL plugin, calling weld::DrawingArea::set_size_request
        can trigger the creation of the corresponding a11y object,
        which wants to access the drawing area to determine its states.
        
        Therefore, call the base class implementation to set the
        drawing area right at the start of IMapWindow::SetDrawingArea,
        as is done elsewhere (e.g. in CuiGraphicPreviewWindow::SetDrawingArea).
        
        This fixes a crash with the below backtrace seen after
        
            commit 62b8ebe343ec49756fdbfddd0f22cb0b15296747
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 12 13:15:52 2025 +0100
        
                GraphCtrl a11y: Use comphelper::OAccessibleComponentHelper
        
        when opening the "Tools" -> "ImageMap" dialog in Impress or Writer
        with the gtk3 VCL plugin.
        
                Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
            0x00007ffff24b0634 in weld::CustomWidgetController::HasFocus (this=0x55555d7068e0) at include/vcl/customweld.hxx:67
            67          bool HasFocus() const { return m_pDrawingArea->has_focus(); }
            (gdb) bt
            #0  0x00007ffff24b0634 in weld::CustomWidgetController::HasFocus (this=0x55555d7068e0) at include/vcl/customweld.hxx:67
            #1  0x00007ffff24ada4a in SvxGraphCtrlAccessibleContext::getAccessibleStateSet (this=0x555558db29c0) at /home/michi/development/git/libreoffice/svx/source/accessibility/GraphCtlAccessibleContext.cxx:256
            #2  0x00007fffe62582d8 in atk_object_wrapper_new (rxAccessible=uno::Reference to (SvxGraphCtrlAccessibleContext *) 0x555558db2a10, parent=0x5555598c69a0, orig=0x555558dd9210)
                at /home/michi/development/git/libreoffice/vcl/unx/gtk3/a11y/atkwrapper.cxx:974
            #3  0x00007fffe62b15c4 in (anonymous namespace)::GtkInstanceDrawingArea::GetAtkObject (this=0x555558f99f60, pDefaultAccessible=0x555558dd9210) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:18964
            #4  0x00007fffe62b14ea in (anonymous namespace)::drawing_area_get_accessible (pWidget=0x55555d7192f0) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:23966
            #5  0x00007fffe5c131b5 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #6  0x00007ffff09b4950 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #7  0x00007ffff09c8d43 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #8  0x00007ffff09ca769 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #9  0x00007ffff09d05a6 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #10 0x00007ffff09d0663 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #11 0x00007ffff09b8b14 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #12 0x00007ffff09ba767 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #13 0x00007fffe62985f3 in (anonymous namespace)::GtkInstanceWidget::set_size_request (this=0x555558f99f60, nWidth=608, nHeight=383) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:3625
            #14 0x00007ffff2617c53 in IMapWindow::SetDrawingArea (this=0x55555d7068e0, pDrawingArea=0x555558f9a210) at /home/michi/development/git/libreoffice/svx/source/dialog/imapwnd.cxx:92
            #15 0x00007fffee96f280 in weld::CustomWeld::CustomWeld (this=0x5555598c6520, rBuilder=..., rDrawingId="container", rWidgetController=...) at /home/michi/development/git/libreoffice/vcl/source/app/customweld.cxx:28
            #16 0x00007ffff260c4b7 in SvxIMapDlg::SvxIMapDlg (this=0x555558838180, _pBindings=0x555556aadbd0, pCW=0x55555d6f5530, _pParent=0x55555d723e28) at /home/michi/development/git/libreoffice/svx/source/dialog/imapdlg.cxx:118
            #17 0x00007ffff2616b46 in std::_Construct<SvxIMapDlg, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (__p=0x555558838180, __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:119
            #18 0x00007ffff2616775 in std::allocator_traits<std::allocator<void> >::construct<SvxIMapDlg, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (__p=0x555558838180, __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/alloc_traits.h:706
            #19 std::_Sp_counted_ptr_inplace<SvxIMapDlg, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (this=0x555558838170, __a=..., __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:607
            #20 0x00007ffff26164ff in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<SvxIMapDlg, std::allocator<void>, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (this=0x7fffffff4158, __p=@0x7fffffff4150: 0x0, __a=..., __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:970
            #21 0x00007ffff261642c in std::__shared_ptr<SvxIMapDlg, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<void>, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (this=0x7fffffff4150, __tag=..., __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1713
            #22 0x00007ffff26163aa in std::shared_ptr<SvxIMapDlg>::shared_ptr<std::allocator<void>, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*>
                (this=0x7fffffff4150, __tag=..., __args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:463
            #23 0x00007ffff2612a49 in std::make_shared<SvxIMapDlg, SfxBindings*&, SvxIMapDlgChildWindow*, weld::Window*> (__args=@0x7fffffff4170: 0x555556aadbd0, __args=@0x7fffffff4148: 0x55555d6f5530, __args=@0x7fffffff4140: 0x55555d723e28)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:1007
            #24 0x00007ffff260bb7c in SvxIMapDlgChildWindow::SvxIMapDlgChildWindow (this=0x55555d6f5530, _pParent=0x5555576ad680, nId=10371, pBindings=0x555556aadbd0, pInfo=0x7fffffff43e8)
                at /home/michi/development/git/libreoffice/svx/source/dialog/imapdlg.cxx:89
            #25 0x00007ffff261290c in std::make_unique<SvxIMapDlgChildWindow, vcl::Window*&, unsigned short&, SfxBindings*&, SfxChildWinInfo*&>
                (__args=@0x7fffffff4230: 0x5555576ad680, __args=@0x7fffffff422e: 10371, __args=@0x7fffffff4220: 0x555556aadbd0, __args=@0x7fffffff4218: 0x7fffffff43e8)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:1077
            #26 0x00007ffff260b704 in SvxIMapDlgChildWindow::CreateImpl (pParent=0x5555576ad680, nId=10371, pBindings=0x555556aadbd0, pInfo=0x7fffffff43e8) at /home/michi/development/git/libreoffice/svx/source/dialog/imapdlg.cxx:59
            #27 0x00007ffff38c3b6f in SfxChildWindow::CreateChildWindow (nId=10371, pParent=0x5555576ad680, pBindings=0x555556aadbd0, rInfo=...) at /home/michi/development/git/libreoffice/sfx2/source/appl/childwin.cxx:242
            #28 0x00007ffff395f5bd in SfxWorkWindow::CreateChildWin_Impl (this=0x5555571433b0, pCW=0x55555864a020, bSetFocus=true) at /home/michi/development/git/libreoffice/sfx2/source/appl/workwin.cxx:1350
            #29 0x00007ffff3961853 in SfxWorkWindow::ToggleChildWindow_Impl (this=0x5555571433b0, nId=10371, bSetFocus=true) at /home/michi/development/git/libreoffice/sfx2/source/appl/workwin.cxx:1835
            #30 0x00007ffff403ba89 in SfxViewFrame::ToggleChildWindow (this=0x555557128f90, nId=10371) at /home/michi/development/git/libreoffice/sfx2/source/view/viewfrm.cxx:3695
            #31 0x00007fffbb6290d4 in sd::DrawViewShell::FuTemporary (this=0x55555728c010, rReq=...) at /home/michi/development/git/libreoffice/sd/source/ui/view/drviews2.cxx:3893
            #32 0x00007fffbb6949b5 in SfxStubDrawViewShellFuTemporary (pShell=0x55555728c010, rReq=...) at workdir/SdiTarget/sd/sdi/sdslots.hxx:1551
            #33 0x00007ffff39c8d1e in SfxDispatcher::Call_Impl (this=0x555556af3f30, rShell=..., rSlot=..., rReq=..., bRecord=true) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:256
            #34 0x00007ffff39cd5d6 in SfxDispatcher::Execute_ (this=0x555556af3f30, rShell=..., rSlot=..., rReq=..., eCallMode=SfxCallMode::RECORD) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:755
            #35 0x00007ffff39b59ee in SfxBindings::Execute_Impl (this=0x555556aadbd0, aReq=..., pSlot=0x7fffbb7c6270 <aDrawViewShellSlots_Impl+14400>, pShell=0x55555728c010)
                at /home/michi/development/git/libreoffice/sfx2/source/control/bindings.cxx:1046
            #36 0x00007ffff3a95e2d in SfxDispatchController_Impl::dispatch (this=0x555557e27950, aURL=..., aArgs=empty uno::Sequence, rListener=empty uno::Reference) at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:736
            #37 0x00007ffff3a948e4 in SfxOfficeDispatch::dispatch (this=0x555557e278b0, aURL=..., aArgs=empty uno::Sequence) at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:255
            #38 0x00007ffff4f0bd04 in framework::(anonymous namespace)::AsyncMenuExecute (data=0x5555588c6000) at /home/michi/development/git/libreoffice/framework/source/uielement/menubarmanager.cxx:790
            #39 0x00007fffee275a41 in Link<void*, void>::Call (this=0x55555d70f598, data=0x5555588c6000) at include/tools/link.hxx:105
            #40 0x00007fffee271c71 in ImplHandleUserEvent (pSVEvent=0x55555d70f590) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2285
            #41 0x00007fffee26eb9f in ImplWindowFrameProc (_pWindow=0x555556ba6530, nEvent=SalEvent::UserEvent, pEvent=0x55555d70f590) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2849
            #42 0x00007fffeee4638c in SalFrame::CallCallback (this=0x5555569908a0, nEvent=SalEvent::UserEvent, pEvent=0x55555d70f590) at vcl/inc/salframe.hxx:310
            #43 0x00007fffeee6ed1f in SalGenericDisplay::ProcessEvent (this=0x5555568f8ef0, aEvent=...) at /home/michi/development/git/libreoffice/vcl/unx/generic/app/gendisp.cxx:66
            #44 0x00007fffee97966d in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7fffffffb920) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:119
            #45 0x00007fffee97953b in SalUserEventList::DispatchUserEvents (this=0x5555568f8ef0, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:120
            #46 0x00007fffeee6ec75 in SalGenericDisplay::DispatchInternalEvent (this=0x5555568f8ef0, bHandleAllCurrentEvent=false) at /home/michi/development/git/libreoffice/vcl/unx/generic/app/gendisp.cxx:51
            #47 0x00007fffe62891ef in call_userEventFn (data=0x5555555b3ab0) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:827
            #48 0x00007fffe99043c5 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #49 0x00007fffe99065f7 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #50 0x00007fffe9906d60 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #51 0x00007fffe6287e6c in GtkSalData::Yield (this=0x5555555b3ab0, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:405
            #52 0x00007fffe628cf13 in GtkInstance::DoYield (this=0x5555555b3960, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:439
            #53 0x00007fffeea45406 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #54 0x00007fffeea44d1f in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #55 0x00007fffeea44b00 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #56 0x00007ffff7b29455 in desktop::Desktop::Main (this=0x7fffffffd660) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1678
            #57 0x00007fffeea6f1b6 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #58 0x00007fffeea70ca9 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #59 0x00007ffff7ba387a in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #60 0x00005555555559fd in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #61 0x00005555555559d7 in main (argc=2, argv=0x7fffffffd868) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: I9488a66c1512e41b37bcea0d4bb25a6733884976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187162
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        (cherry picked from commit fdffaac63c893694df950119790ace22972ec531)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187190
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [1d7f160f9a0f01ce74bf306a86bd9e8a9f291a7e]

        tdf#156061: fix UI strings for EmptyDbFieldHidesPara compat option
        
        Make it clear, that hiding only happens on merged documents generation.
        
        Change-Id: I95953a09e69e6754adc5010fdaa97215324a33c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187175
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e488d7190d53ae236ad5fc89a0c2577e7f564fc2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187184
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [91f79e292c263418d4171c86e062764bd7687b3f]

        tdf#167161: different ATTR_LANGUAGE_FORMAT mean different number formats
        
        Extend ScPatternAttr::HasNumberFormat to check ATTR_LANGUAGE_FORMAT
        when detecting different number formats, which will disable controls
        in SvxNumberFormatTabPage::Reset (see handling of pValFmtAttr there).
        Also invalidate ATTR_VALUE_FORMAT explicitly in ExecuteCellFormatDlg,
        when HasNumberFormat returned false.
        
        Change-Id: I7c415903e71149f4fabb98840fae36e2379d4830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186794
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186944

2025-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [f6959f2682d4b43464098c1ea4c12887fc276572]

        tdf#167062: fix ScPatternAttr::HasNumberFormat implementation
        
        It must only return false, when respective item is invalidated.
        
        See ScViewFunc::ApplyAttributes, which may avoid setting cell
        number format, when only language has changed; this may create
        cells having ATTR_LANGUAGE_FORMAT, but not ATTR_VALUE_FORMAT.
        This case must be handled as "having a number format", for the
        purposes of preparing item set for number format dialog. See
        ScTabViewShell::ExecuteCellFormatDlg, where it is checked and
        prepared.
        
        Change-Id: Ida0c8495ce582739a3ddfa0ced392b3d9c7651de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186793
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186943

2025-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [80b7ed400e9d76817427d172e81b0fa1f9c203d4]

        Revert "tdf#161264 don't hide paragraph with empty mail merge fields"
        
        This reverts commit dce68b5f9f286a8b6af42fcad1331d7e9bb07f4c. That
        commit tried to workaround tdf#156061, by basically disabling the
        feature that was intended to match an existing feature in MS Word.
        
        After commit ef3b11f811e1fd3852a22881d712afda03a0238f (tdf#156061:
        don't hide DB fields when not in mail merge, 2025-06-29), fixing
        tdf#156061 properly, Word documents should again have the feature
        enabled, as intended.
        
        I checked that tdf#159123 doesn't re-appear after this (at least on
        my system).
        
        Change-Id: I154e776fe56373fa021ff63e4fb3ac3c0815bb10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187151
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187168

2025-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0c0496b2902a00639e37ed57dd753a8445f9ef97]

        tdf#156061: don't hide DB fields when not in mail merge
        
        Original implementation (commit db04be037b611e296ef9f2542322c52ed82d7a2b
        tdf#35798: Hide empty Database fields' paragraphs (+ compat option),
        2018-05-20) made empty DB fields serve as "hidden paragraph" field,
        when the field text is empty. The feature is created for mail merge,
        where the generated documents adapt to varying set of data in each
        record.
        
        But that broke the case where documents having DB field are used in
        non-mailmerge context, like viewing/printing such documents. Users
        expect such documents to show the lines.
        
        This patch changes the behavior, so that empty DB field only hides
        paragraphs when mail merge is being performed. When the resulting
        document converts DB fields to static text, the hidden paragraphs
        get removed. But if the generated documents still have DB fields,
        then the paragraphs in it will not be hidden, when opened later.
        This matches user expectations, and behavior of other apps, better.
        This behavior change required to change respective unit tests in
        sw/qa/extras/mailmerge/mailmerge.cxx from *_FILE_* to *_SHELL_*:
        the latter creates a static-text output, while the former produces
        files with fields. (IMO, that is a bug.)
        
        Change-Id: Id796ad8fe413372377ce22d8da4931110718c8c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187150
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187167

2025-06-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84f722c99c5b017e1dd709f92c4bf09dd2d8fab9]

        Resolves: tdf#136943 limit combobox popups to max available below/above height
        
        If the popup won't fit either above/below then force the menu to scroll
        if it won't fit
        
        Change-Id: I03c051606ce29e2eba7046248e05c25fbdbded1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187096
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 794946c9a7bd876468c02fc6b254f4a2536b6a93)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187139
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-28  Michael Stahl  <michael.stahl@allotropia.de>  [f55ab60cff8b15aaf220fc3f75b0a35fe0b2c1ef]

        sw: Navigator: fix SwPostItContent::m_pField UAF
        
        ASAN reports UAF on SwPostItContent::m_pField and it's apparent that the
        only thing that removes a SwPostItContent from the Navigator is a timer.
        
        Clearly it becomes invalid when the SwFromatField that m_pField points
        to is destroyed, so implement a listener for this and try to add some
        null checks on uses to avoid crashing. (Doesn't look obvious how to
        remove it from the tree immediately.)
        
        Change-Id: Iad94ddb923f0126b5e6d76d0b77dc26043cefaba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186654
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        (cherry picked from commit 0322f4c69d7d615063e0f8f6a1b39b5fbfee81af)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186741
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-28  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [3cff0b3ff4f5f16a0bca2694134e7d2e511b7c79]

        tdf#166709 better to use TransparencePrimitive2D for metafile
        
        See comments in code & task.
        
        Change-Id: I6c34a86ab713130b427fd5efad83b7028a32bc19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186721
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186740
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-28  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [a514b0569ca1014d2060340457c32daf6b8dfbaf]

        tdf#166709 special handling of transparency for metafile/PDF
        
        For handling transparency for tiled bitmaps correctly in
        metafiles the newly added linear transparency is too much
        and leading to many single transprent bitmnaps. This is
        not wrong but too much data and bloating the metafile/PDF.
        For details and extensive explanations see text in commit.
        
        Change-Id: I255db614e0c9eb8cd5130abbdaef4eda1c398684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186630
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186739
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3389c9233a475f7b53b2621f645c752ec61dfc73]

        tdf#167135 Transparency setting page style area for image background
        
        regression from
            commit 1f61a2ec4e252d2eeccabd65a10650c8ee231a1b
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon May 26 13:26:19 2025 +0200
            tdf#166715 speed up transparent fill operation
        
        where I mistook "hasTransparency" to mean "does the bitmap have an alpha layer", instead of "there is an __additional__ alpha value applied to this bitmap"
        
        Change-Id: If89d95103fc13e7ce78e7056d0a53aa40d48cde2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187034
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 9c8368955b8f512d75268e7ed89e692fa9d1c930)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187063
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-28  Julien Nabet  <serval2412@yahoo.fr>  [80f7d8df4f5eb3176302dd95aad5ecdf55bb54f5]

        Fix error after 17a782a2a7387c35865dcfea77ef0872eb944af9
        
        fontconfig: upgrade to 2.17.0
        
        I had these errors:
        /home/julien/lo/libreoffice/instdir/program/gengal.bin: error while loading shared libraries: libfontconfig-lo.so.1.15.0: cannot open shared object file: No such file or directory
        make[1]: *** [/home/julien/lo/libreoffice/solenv/gbuild/Gallery.mk:57: /home/julien/lo/libreoffice/workdir/Gallery/backgrounds.done] Error 1
        make[1]: *** Attente des tâches non terminées....
        /home/julien/lo/libreoffice/instdir/program/gengal.bin: error while loading shared libraries: libfontconfig-lo.so.1.15.0: cannot open shared object file: No such file or directory
        make[1]: *** [/home/julien/lo/libreoffice/solenv/gbuild/Gallery.mk:57: /home/julien/lo/libreoffice/workdir/Gallery/sounds.done] Error 1
        make: *** [Makefile:302: build] Error 2
        
        Change-Id: I625373ec89f26bdcdca0db871a427f71b4ad0755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187136
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit 4fb133e47937015696c9ea932487c15fa88ed811)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187137

2025-06-28  Bayram Çiçek  <bayram.cicek@collabora.com>  [f20e7e2d4bc010be7b589a012f806e797d84d163]

        tdf#157596: add partly-deleted paragraphs to hidden list during fileopen
        
        - regression from commit 2413f213625253a9c2b1787b3b9fe859d724a9bd
        - if a paragraph is partly deleted, add it to the "hidden" list.
        - if we delete -at least- a single character from a paragraph (during Record Track Changes is enabled), Writer thinks the whole paragraph and the numbering is deleted. Therefore, the numbering of the paragraph does not get added to the hidden list.
        - this patch adds the partly-deleted paragraph numbering to the hidden list during fileopen.
        - added a unit test
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Ia8852eb7d61b57f15a037b2ffd3e6eec363f90af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186597
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
        (cherry picked from commit 8a0b5e43187e70c41e777875063b82c6e84c6fcf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187065

2025-06-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e23aa4dbb7512c79e8a6547b80b27c6eb943d37]

        lxml: upgrade to 6.0.0
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-6.0.0/lxml-6.0.0.tar.gz
        
        Change-Id: Ibdb78cec96f723623639bedb6afcea31e83d0385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187100
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 044312b5476b91714871c031437526c64a1093c2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187119

2025-06-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [e159aa515225f8cbc64ff18060b620a33e4d69ce]

        fontconfig: upgrade to 2.17.0
        
        Downloaded from https://gitlab.freedesktop.org/api/v4/projects/890/packages/generic/fontconfig/2.17.0/fontconfig-2.17.0.tar.xz
        
        Change-Id: I664c4b7f4087a613b3cc64355387679d0b474ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187091
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 17a782a2a7387c35865dcfea77ef0872eb944af9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187103

2025-06-27  Heiko Tietze  <tietze.heiko@gmail.com>  [7a59dcf7c73d5236df6f2c454f5f41a8cdb214e4]

        Resolves tdf#161492 - Consider tab width for dialog size
        
        Change-Id: Ia503ba49fcf6f9f3fb3abab34c1b95f62b0e6ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit c6b9c12d6a08d2f80f4a9b5d10b1be00e3b1d454)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187079
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a33c5a4298b6292871f818fc57275840c519af6c]

        tdf#167019 Conditional formatting is not handled properly
        
        regression from
            commit e2cc1f8a6bd27907800416a5396942a0c7ca56ce
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Feb 28 10:51:44 2025 +0200
            tdf#134864 speedup load of pathological conditional formats in XLS
        
        Change-Id: I9e9383e9ccb572e7cbca2b4f32c95213e6464a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187094
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit a67ab7ea6f090ee90871bfb97243b9cd66b44af4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187105
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-27  Michael Weghorn  <m.weghorn@posteo.de>  [6d9377d97654203e73907d5ac7245c0768d4ecb4]

        tdf#167261 vcl a11y: Reverse-cycle through panes on Shift+F6 again
        
        Moving focus to the previous pane using Shift+F6
        (i.e. moving focus in reverse direction as F6 does)
        as documented at [1] broke in
        
            commit 2ac51182e63c109bb44334f86b6ab3bcdf247494
            Date:   Tue Sep 10 10:14:51 2024 +0200
        
                Related tdf#146906 - Remove hard-coded access to split window
        
        Consider that key combination a cycle one again.
        The above commit was about removing the key combo Shift+Ctrl+F6.
        Adjust the check in TaskPaneList::IsCycleKey to exclude
        that combo, but not plain Shift+F6.
        
        [1] https://help.libreoffice.org/master/en-US/text/shared/guide/keyboard.html
        
        Change-Id: Ibafeb2f021b0f77e519275b5b76e6cdebec4dc60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187080
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 774d00472b179805b629a2b18af3692c5d5e0944)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187098
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [780e865517bc8ae798edde9d24cecb4a8254e516]

        tdf#167254: check if getCellCount gives zero
        
        Regression since commit 038473595ed266d15a788d8f97781cbaf066cfe7
        (tdf#152839 add fill cells to tables imported wrongly from RTF, 2024-10-11).
        
        Change-Id: Ie2da84eb358d291bcc584a86ae69843f13186c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187073
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187089

2025-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [36836b5466243c803e0011473bc1f5c2a81f55db]

        tdf#167255: workaround undefined order of module load
        
        The problem is, that there is no definition of resolution of name
        visibility, when names are defined in different modules. Before
        commit ea2a97438643a440e192dbe30d03988da65c6b18 (Simplify
        NameContainer, 2024-12-01), it happened to be the order in which
        modules were found in SfxLibraryContainer::init_Impl (it could be
        arbitrary in principle).
        
        The said commit changed NameContainer::getElementNames to return
        the names in ~arbitrary order (defined by specific unordered_map
        implementation).
        
        To workaround the current problem (when 'SBMAXAPPLCOUNT' defined
        in 'DialogModul' of 'ImportWizard' library is not visible in its
        'Language' module at library load time, specifically on Linux),
        just sort the library element names at its loading time. It will
        not create performance problem (it is a one-time sort over a small number of elements; having millions of modules in a single library
        is not realistic, and would create bigger problems elsewhere).
        
        Change-Id: I93e91ae5f4be12a1bf641fe2d29e0a161589b8af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187081
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e21c27ae301dc1a3d55563e0b7428adc189804bc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187092
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [85829c4c33e0f46ab71222732eeba7dc86fc6b38]

        tdf#167132: Reimplement SwWrtShell::InsertEnclosingChars
        
        It used IDocumentContentOperations::ReplaceRange, and that created a
        number of problems.
        
        1. The method is documented to only work in a single node. That meant,
        that trying to apply it on a selection over several paragraphs would
        make odd things: it would replace the selected part only of the first
        paragraph with the text of all the selected paragraphs, separated by
        hard line breaks (and enclosed in the requested characters). In debug
        builds, it would even fail an assert here.
        
        2. It would replace all the content of the selection with just text,
        removing objects.
        
        3. The implementation didn't check if the operation is permitted.
        
        4. The implementation didn't create a single undo operation, and for
        a multi-selection, the operation would create multiple "replace" undo
        entries.
        
        This change re-implements it, trying to address these shortcomings.
        - It checks if the operation is permitted, consistent with how other
        methods there do it.
        - It merges all changes inti a single undo operation (with a proper
        description).
        - It inserts the requested strings in the start and ent boundaries of
        the selection, without replacing it. In this case, the start poses a
        problem: insertion inherits the formatting from behind, so may give
        the result having different formatting compared to the first selected
        character. This is workarounded by inserting the start string after
        the first character initially; then copying it (with its formatting)
        to the correct place, and removing the temporary insertion.
        -
        
        Change-Id: Ie3bf4d961ff5de5d2687692dac230579a176b960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187072
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187088

2025-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [cab85b8cc7806d4f1ac2191b2e4d78a38f75812c]

        tdf#167133: Be prepared that frame's object's anchor may be null
        
        ... between the time the object was removed from the model, and the
        layout update.
        
        Change-Id: Ieb2f42c18794090cdc8786d5cffd9ae6e2b8f147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187071
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187087

2025-06-26  Jonathan Clark  <jonathan@libreoffice.org>  [70c3803c15d579d5a448e397b4c0988f71e20e2b]

        vcl: Improve test coverage for MultiSalLayout
        
        Added missing unit tests for text layout with fallback runs.
        
        Related: tdf#154104
        Related: tdf#163761
        Change-Id: I489691f7afaa24491ebd0a5660b08b0440ecbc7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187049
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 1394a23365a793c41fdc799d63d71aaa96510b02)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187069
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [006d198d7118e4cd13130f2e04abc3edf4521679]

        crash on deref xProperties[0]
        
         #0  0x00007d2c10cfed96 in chart::ControllerCommandDispatch::updateCommandAvailability (this=0x3de34be0)
             at chart2/source/controller/main/ControllerCommandDispatch.cxx:812
         #1  0x00007d2c10d01e7c in chart::ControllerCommandDispatch::modified (this=0x3de34be0, aEvent=...)
             at chart2/source/controller/main/ControllerCommandDispatch.cxx:1056
         #2  0x00007d2c10e4baa1 in comphelper::OInterfaceContainerHelper4<com::sun::star::util::XModifyListener>::NotifySingleListener<com::sun::star::lang::EventObject>::operator() (listener=...,
             this=0x7ffce60d8250) at include/comphelper/interfacecontainer4.hxx:319
         #3  comphelper::OInterfaceContainerHelper4<com::sun::star::util::XModifyListener>::forEach<comphelper::OInterfaceContainerHelper4<com::sun::star::util::XModifyListener>::NotifySingleListener<com::sun::star::lang::EventObject> > (this=<optimized out>, rGuard=..., func=...) at include/comphelper/interfacecontainer4.hxx:349
         #4  0x00007d2c10e46ad4 in comphelper::OInterfaceContainerHelper4<com::sun::star::util::XModifyListener>::notifyEach<com::sun::star::lang::EventObject> (Event=...,
             NotificationMethod=&virtual com::sun::star::util::XModifyListener::modified(com::sun::star::lang::EventObject const&), rGuard=..., this=0x3d096fa8)
             at include/comphelper/interfacecontainer4.hxx:409
         #5  chart::ChartModel::impl_notifyModifiedListeners (this=0x3d096e70) at chart2/source/model/main/ChartModel_Persistence.cxx:624
         #6  0x00007d2c10e46c5c in chart::ChartModel::setModified (this=0x3d096e70, bModified=<optimized out>)
            at chart2/source/model/main/ChartModel_Persistence.cxx:660
        
        (gdb) print xProperties[0]
        $3 = {<com::sun::star::uno::BaseReference> = {_pInterface = 0x0}, <No data fields>}
        
        Change-Id: I5225b24dcdeecd2e85e1f892f6b6463c0122fbce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187033
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit d0c5f49cc99eaec77071830dee3dc5284fffb925)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187062
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Jonathan Clark  <jonathan@libreoffice.org>  [67b4d58544865dcc5f0fed5e55cec5967c747dab]

        tdf#154104 Fix for overlapping chars in mixed-script fallback runs
        
        Fixed a bug inside MultiSalLayout::ImplAdjustMultiLayout() that caused
        improper position adjustment for single-glyph fallback runs.
        
        Change-Id: Ia79b0632b93f0fd06f31134588a4d7b00b825f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186984
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 836880d49b5eace490d94a80ab6e7177a4413095)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187059
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Jaume Pujantell  <jaume.pujantell@collabora.com>  [6a11cc0c82954ef1ed0cc0915fbfe548692b0ddd]

        tdf#166940 sw: in docx field import use to outer char props
        
        For RTF field import, to assign character properties top a field, the
        properties are assigned to the field mark characters and then added to
        the content string.
        
        For DOCX according to the standard the content can have arbitrary
        styles, but for now we only support plain strings for some fields. So,
        for those fields, we want to insert the content with the properties of
        the surrounding context. This was done by taking the character
        properties of the end field mark character, like used in RTF import.
        This works most of the time but fails for documents where those
        invisible characters have their own properties which shouldn't show up
        in the visible text.
        
        Instead, for DOCX, it makes more sense to take those properties from the
        first run of the field and apply it to the whole field result.
        
        Change-Id: I9287f7ed81c4cc2b5bbf65e7151ee3a8bcbd95d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186302
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit adc483d5f9256b7e10beed29bb63a7c582cab56e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186453
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        (cherry picked from commit ab1a81b1e3818deac87c21c1d98a546a23dd6ada)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186981
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Mike Kaganski  <mike.kaganski@collabora.com>  [211099533e01f74d3d364b54e40d94c6d3bbe37d]

        tdf#167165: catch possible exceptions when trying to get HyperLinkName
        
        The bugdoc has an image beneath the ToC. Moving the mouse cursor close
        to the ToC's page numbers, the tooltip is generated; but the position
        is over the image (aPos = {Node: {[75] {GrfNode}} Content: {0}}), and
        that's what an SwXTextRange is generated from: xRange->m_pMark = NULL.
        
        Trying to get its properties throws with this call stack:
          vcruntime140d.dll!_CxxThrowException(void * pExceptionObject, const _s__ThrowInfo * pThrowInfo) Line 79
          swlo.dll!SwXTextRange::getPropertyValue(const rtl::OUString & rPropertyName) Line 1498
          swlo.dll!SwEditWin::RequestHelp(const HelpEvent & rEvt) Line 456
          vcllo.dll!ImplHandleMouseHelpRequest(vcl::Window * pChild, const Point & rMousePos) Line 186
          vcllo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, NotifyEventType nSVEvent, bool bMouseLeave, __int64 nX, __int64 nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 738
          vcllo.dll!ImplHandleSalMouseMove(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 2330
          vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2663
          vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 310
          vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3322
        
        The exception wasn't caught, and crashed.
        
        Change-Id: I9e80c1fc5f78771fce2ec6fe047dfe3d37e0e60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186806
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit c9c96987c31efe7108d0588ef097e952d623238c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186937
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Mike Kaganski  <mike.kaganski@collabora.com>  [c0f2b94e176d163591d7e11ba5956744c2579f05]

        tdf#167185: make sure that cell width corrections don't accumulate
        
        The problem was, that several rows may share the same row definition,
        and the same RTFSprms in the current state. In commit
        d00181e8c1ead5020cc8fee47ee7af7fc5039552 (tdf#167169: postpone \trleftN
        processing until \row, 2025-06-23), RTFDocumentImpl::prepareProperties
        started to modify existing values inside table row sprms in place; and
        that resulted in accumulating changes, where each next row was getting
        more corrections of already corrected widths.
        
        This change copies the RTFSprms for correction, avoiding the problem.
        
        Change-Id: Ia199862c7b8983d93d2fce4898fb60bf8b4a1a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186890
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186940

2025-06-26  Mike Kaganski  <mike.kaganski@collabora.com>  [23e0ae1273bbba44c155e01315ab81121275cab8]

        tdf#167169: postpone \trleftN processing until \row
        
        ... where all the data: all \cellxN and \tblindN - are already known.
        The \tblind establishes the left indent; \trleft establishes what X
        coordinate will be at the leftmost table edge (i.e., \tblindN tells
        "shift table N twips to the right"; \trleftN tells "assume that the
        coordinate of this table's leftmost position is X"). Only when there
        is no \tblindN, the \trleftN also defines an indent. Handling all of
        that correctly is only possible at \row handler; especially because
        the RTF standard tells:
        
          <row> (<tbldef> <cell>+ <tbldef> \row) | (<tbldef> <cell>+ \row) | (<cell>+ <tbldef> \row)
        
          ...
        
          While Word 97 emitted the row properties (<tbldef>) at the beginning
          of the row, a reader should not assume that this is the case.
          Properties can be emitted at the end, and, in fact, Word 2002, Word
          2003, and Word 2007 do this.
        
        Note: there is a problem of inconsistencies in the documentation and
        implementation of \tblindN wrt. units: there is \tblindtypeN, which
        should define units used in \tblindN, and it is documented to use 0
        for "auto", 1 for "dxa" (=twips), 2 for "no width", and 3 for "pct"
        (fiftieths of a percent). However, in my testing, Word considered 3
        as twips, and ignored \tblindN when \tblindtypeN had other values.
        In Writer, \tblindtypeN is not handled. This needs a separate fix.
        
        Change-Id: If5c47571ca005b248d72ac7ab688c358f4f18e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186807
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186939

2025-06-26  Mike Kaganski  <mike.kaganski@collabora.com>  [922fc46fce72d6d4f3d12cfe92e23adc16ddb13c]

        tdf#121493: handle \trleftN after \cellxN
        
        I took an easy path, and just fixed the possible pre-existing value
        when \trleftN is handled. But the proper fix would be to avoid the
        cell widths calculations altogether, until \row is handled. At that
        point, all information is already gathered.
        
        Search for the first instance of LN_CT_TblGridBase_gridCol, that is
        not -1 (the special value inserted in RTFDocumentImpl::resetTableRowProperties,
        and used in DomainMapperTableManager::sprm); and if found, correct
        it by the calculated TRLeft value.
        When there was no previous \cellxN, correct rCurrentCellX.
        
        Change-Id: Ie6cf64d594e166abb1ed3e939207101d96f75c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186790
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186938

2025-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0c11a08ed4bea6405411d4e590ae819806b7613]

        tdf#165481 memory leak in Save AutoRecovery information
        
        regression from
          commit b8720d1e1f0842d52f1830c48ef7551b1868ae6f
          Author: Luboš Luňák <l.lunak@collabora.com>
          Date:   Fri Mar 25 12:42:58 2022 +0100
          fix ScTable::GetLastChangedCol() for unallocated columns
        
        Change-Id: I639ecc87839a9149c45583d524850db66769bfc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187003
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 0668573914ccf9f8611b38289471909c4d0f7888)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187017
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c66b8808ad5b6c004a5b06637184c50fa1799ad0]

        ofz#426843904 Null-dereference
        
        Change-Id: Ie2559e28938f142711ac5024a45a448b94a5d93f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186811
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit eb37c912b9554659bd3466f80fa24d9a18c3a274)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186934
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4857535b81afc2191c73a1cbddde003fe169c8f9]

        ofz#426843907 Stack-overflow
        
        Change-Id: I03f10968aaa32960bc6dfd2175a582ec1dd30918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186815
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit b6d240c4bab906f84c0ecefc2b4021b59ff368e4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186935
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Kurt Nordback  <kurt.nordback@collabora.com>  [d6a1c76b04853ddd1b93df55c7e40c396739b5ea]

        tdf#165742 Step 4.4: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from
        OOXML and re-export.
        
        Fix chartex parsing so as to properly handle series. This code considers
        the <cx:plotAreaRegion> tag to be equivalent to the chart 'type group'
        tags (<c:barChart>, <c:areaChart>, etc.). Therefore it allows use of the
        type group mechanisms in chartex, even though there is not strictly a
        tag for type group. This also includes a basic CI test for the
        ability to round-trip (OOXML -> LO -> OOXML) simple chartex content.
        
        Change-Id: Ibe96a239aa5329897b8e0652ce7388a7c398dda2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186298
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit ae939db6ed131b2488ca9ff81b53610838bff178)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186706
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-26  Julien Nabet  <serval2412@yahoo.fr>  [5780f21673be83c8d32857cccc36d37ef3d4edb5]

        tdf#167214: fix crash on save on PPTX with failed embedded fonts
        
        Change-Id: I80dd19161393284983e6f0018e35d0dfd22eefc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187005
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit c750db764108da6f94160df2f4a0a6768ffc3177)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187024

2025-06-26  Heiko Tietze  <tietze.heiko@gmail.com>  [7de4a9f479018e3bd8c4b59cb57b2870195edf18]

        Resolves tdf#166723 - Misleading use of the word "reinstate"
        
        Change-Id: Iccb79b4c5ee9a5e2ea633942c423ca2411e418ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186932
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit 7aae69d7c9fd4133234600a232cfc30785cc808c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187016

2025-06-26  Darshan Upadhyay  <darshan.upadhyay@collabora.com>  [6b6863553dc29c640cca692aeb5b4a1677d956c3]

        Revert "Broadcast the transition change"
        
        This reverts commit ba0ec3b5f6f2154205ad72ce444a48b4dfb9af88.
        
        Reason for revert: While the change in the transition variant does happen and is applied to the slide, the variant button does not change to the new variant. 
        
        Change-Id: I3f6072c139c4d18abf9a00fb019ceee249061681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185583
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 0621d14cb488ca024c86fb2069b7fd39016aff9c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185586
        Tested-by: Jenkins
        (cherry picked from commit 6f4e42d2b716101ddc90c938800ded47ae5ad0ce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186996
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-25  Julien Nabet  <serval2412@yahoo.fr>  [677543a8511cc5dd4e148cd0aa5879b8ddcbe78a]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 125a11f9479c1234eeb2a9136a5f914b90c0aef3
          - tdf#167182: Fix Fourier swapped arguments
            
            It concerns Polar and Inverse.
            
            Change-Id: If5a7b36545b6eb2dc7f095392f2a1528b30dba07
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/187000
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            (cherry picked from commit 48572394a6d89fe4472d3adce8b4b5ac35574b07)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/187006
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2025-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b79484e45106ce89b5f822c2b23d1cda8c7b7c7]

        language-subtag-registry: upgrade to 2025-06-23
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-06-23.tar.bz2 data/language-subtag-registry
        
        Change-Id: I76bae4838882e02440fbf967c339eeaafef44ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186948
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit eedfc2778efebb8435ade0c609f122e462a98fa5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186975

2025-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [bb31491ec72fb55d2f721d6392ecefc2a270998d]

        Resolves tdf#167111 - Help for the UI Picker
        
        Points to the not yet existing pages
        * cui/ui/uitabpage/UITabPage
        * cui/ui/toolbartabpage/ToolbarTabPage
        
        Change-Id: I6a5326ccd2e2cb9f536ae68c14eff9af4237ef27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186852
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        (cherry picked from commit ef272d90c40f983d70e08613ba1def3793d6550c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186945
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e3c7e2773d7e586f516fb9ce54987b6b079b728]

        tdf#167112 MATH: Elements sidebar is empty
        
        regression from
          commit 25f007984f91393dbc34adbd2bf59d8b4bae490a
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Tue Jun 10 18:20:18 2025 +0200
          tdf#166932 use BitmapEx in preview style cache instead of VirtualDevice
        
        Change-Id: I385c3428e97b68e3ce7429ffaf87ddfc81a547b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 2a6f4a2f4f5b1b61fb859b33fd889ad55fe4eee8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186931
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-25  Miklos Vajna  <vmiklos@collabora.com>  [009dc31a0317ce8027c47c6f740852c0f66d3039]

        tdf#166319 sw interdependent redlines: fix bad accept undo action for reject
        
        See
        <https://gerrit.libreoffice.org/c/core/+/186646/2#message-86a47ee78fb9a0c6d4a8e355a06c5c6931d66f6b>,
        a reject UI action resulted in an accept undo action, which was
        inconsistent.
        
        I added this in commit 8b5435d6e49c3d0237bc4a13ff5253dcb1c915f7
        (tdf#166319 sw interdependent redlines: fix undo of del on top of ins,
        2025-04-25), at that time SwUndoRejectRedline had no way to store
        hierarchical redlines.
        
        Fix the problem by asking for a hierarhical copy using the API added in
        commit 5f4ed6e34d71b578f5facef04d3a0ae2df81531b (tdf#166319 sw
        interdependent redlines: fix undo of reject of ins-then-del's del,
        2025-06-11): this way we don't need to create a fake accept undo action
        & the "underlying" redline data won't be lost, either.
        
        Change-Id: I92201881fb67e3eca95a805b6a0da3a166a863fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186840
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 76c2168a276f0996deeac08ce176525821fb056e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186933

2025-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [69cfa8a71faec56cd6f7708f14f5e3794827fc04]

        SfxBaseModel: allow repeated dispose()
        
        A crash seen at shutdown with this call stack:
        
          ucrtbased.dll!terminate() Line 59
          vcruntime140_1d.dll!FindHandler<__FrameHandler4>()	Unknown
          vcruntime140_1d.dll!__InternalCxxFrameHandler<class __FrameHandler4>(struct EHExceptionRecord *,unsigned __int64 *,struct _CONTEXT *,struct _xDISPATCHER_CONTEXT *,struct FH4::FuncInfo4 *,int,unsigned __int64 *,unsigned char)	Unknown
          vcruntime140_1d.dll!__InternalCxxFrameHandlerWrapper<class __FrameHandler4>(struct EHExceptionRecord *,unsigned __int64 *,struct _CONTEXT *,struct _xDISPATCHER_CONTEXT *,struct FH4::FuncInfo4 *,int,unsigned __int64 *,unsigned char)	Unknown
          vcruntime140_1d.dll!__CxxFrameHandler4()	Unknown
          ntdll.dll!RtlpExecuteHandlerForException()	Unknown
          ntdll.dll!RtlDispatchException()	Unknown
          ntdll.dll!RtlRaiseException()	Unknown
          KernelBase.dll!RaiseException()	Unknown
          vcruntime140d.dll!_CxxThrowException(void * pExceptionObject, const _s__ThrowInfo * pThrowInfo) Line 79
          sfxlo.dll!SfxBaseModel::MethodEntryCheck(const bool i_mustBeInitialized) Line 3065
          sfxlo.dll!SfxModelGuard::SfxModelGuard(const SfxBaseModel & i_rModel, const SfxModelGuard::AllowedModelState i_eState) Line 76
          sfxlo.dll!SfxBaseModel::dispose() Line 740
          cppuhelper3MSC.dll!cppu::`anonymous namespace'::ComponentContext::disposing(std::unique_lock<std::mutex> & rGuard) Line 423
          cppuhelper3MSC.dll!cppuhelper::WeakComponentImplHelperBase2::dispose() Line 27
          cppuhelper3MSC.dll!cppuhelper::WeakComponentImplHelper2<com::sun::star::uno::XComponentContext,com::sun::star::container::XNameContainer>::dispose() Line 87
          cppuhelper3MSC.dll!cppu::`anonymous namespace'::DisposingForwarder::disposing(const com::sun::star::lang::EventObject & __formal) Line 117
          cppuhelper3MSC.dll!cppuhelper::OInterfaceContainerHelper4<com::sun::star::lang::XEventListener>::disposeAndClear(std::unique_lock<std::mutex> & rGuard, const com::sun::star::lang::EventObject & rEvt) Line 402
          cppuhelper3MSC.dll!cppuhelper::WeakComponentImplHelperBase2::dispose() Line 31
          cppuhelper3MSC.dll!cppuhelper::WeakComponentImplHelper2<com::sun::star::uno::XComponentContext,com::sun::star::container::XNameContainer>::dispose() Line 87
          sofficeapp.dll!desktop::Desktop::DeInit() Line 606
          vcllo.dll!DeInitVCL() Line 530
          vcllo.dll!ImplSVMain() Line 244
          vcllo.dll!SVMain() Line 250
          sofficeapp.dll!soffice_main() Line 122
          soffice.bin!sal_main() Line 51	C
          soffice.bin!main(int argc, char * * argv) Line 49	C
          soffice.bin!invoke_main() Line 79
          soffice.bin!__scrt_common_main_seh() Line 288
          soffice.bin!__scrt_common_main() Line 331
          soffice.bin!mainCRTStartup(void * __formal) Line 17
          kernel32.dll!BaseThreadInitThunk()	Unknown
          ntdll.dll!RtlUserThreadStart()	Unknown
        
        where impl_isDisposed() returned true in SfxBaseModel::MethodEntryCheck.
        
        The documentation for XComponent::dispose() says:
        
        > The owner of an object calls this method to explicitly free all
        > resources kept by this object and thus break cyclic references.
        > ...
        > After this method has been called, the object should behave as
        > passive as possible, thus it should ignore all calls in case it
        > can comply with its specification
        > ...
        > For some objects no real owner can be identified, thus it can be
        > disposed from multiple reference holders. In this case the object
        > should be able to cope with multiple dispose()-calls (which are
        > inevitable in a multithreaded environment).
        
        Let's handle multiple dispose()-calls: this fulfils the "behave as
        passive as possible" requirement, because it complies with the
        specification: the repeated calls don't leave open resources and
        cyclic references after ignoring them; and also fits into the last
        clause.
        
        SfxModelGuard is not needed here. It was called with E_INITIALIZING,
        which means "do not throw in not initialized"; and that translates
        to "only throw when disposed". But that's exactly the state which
        we want to handle gracefully now.
        
        And SfxModelGuard uses SolarMutexClearableGuard; so we also should lock
        solar mutex here.
        
        Change-Id: I114e92257a9cf87e1e23018f296a1fa0f013877b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186917
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 9f215024f6a3909228ff50439782e5ffa30ddb14)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186925
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-25  Noel Grandin  <noelgrandin@gmail.com>  [e940a9e28f701dcef8309fbb507b619357fccb25]

        tdf#167152 PSD-Filews created by Photoshop will not be visible
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I995e5edef0e16a75b3ea702259753a480d825133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186854
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 33560caa34a6532fb27641c19d7cc3bb4dc33057)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186929
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-25  Justin Luth  <jluth@mail.com>  [d10c9d1d26cb1d7911deeafea44ce076535059d7]

        tdf#166092 writerfilter: exception killed critical settings
        
        I also took the opportunity to move one setting
        (that was placed directly into the DTOR)
        into where these things are normally stored in ApplyProperties
        (which is called just a bit earlier in that same DTOR).
        
        I tried setting an assert when this fails,
        but already hit
        sw/qa/writerfilter/filters-test/data/pass/CVE-2005-2964-1.rtf
        
        An earlier patchset contains the unit test.
        However, I did not include it because it takes a VERY long time
        to load in a debug environment,
        and it seems pointless to try to create a minimal document
        that still causes a very strange footnote exception.
        
        Change-Id: Ia2b38232e21149407bccceea4ac859d1f38426e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186856
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        (cherry picked from commit 0df64acd9190e36ad53f8fa111b0becf0893630b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186892

2025-06-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a9cf4d7eb7f4a0626528f93ae0e74583ef4859b]

        Resolves: tdf#160415 vcl popups misplaced under x11 gtk3
        
        revert:
        
        commit 698935c220131bc761eb9cf25e01fa91087a788e
            tdf#152155 vcl: fix gtk popup listbox positions on sidebar
        
        and implement an alternative fix for the original motivating problem
        under gtk3 x11
        
        Change-Id: I12eb41a232ba6588ff9eb933b475755cae68dcb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186901
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2025-06-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [840a43c98f8913eaa49e8ccd45519e4f43aa2999]

        linux_aarch64: loplugin:cstylecast in bridges
        
        /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:588:10: error: C-style cast from incomplete 'void *' to 'void (*)(const unsigned char *, const unsigned char *)' (BitCast) [loplugin:cstylecast]
               = (void (*)(unsigned char const *, unsigned char const *)) dlsym(
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        1 error generated.
        
        fix that by using reinterpret_cast instead (and also fix the indent of
        the lines)
        
        Change-Id: I06ee2b2ca350790e2f97435cd70e58acd7c2cf84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186334
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit ef4948bde237459a407a7deede6ab4e4e5b4551b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186363
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f4850a1a66b0f658cf23d46e1fc107d4d56cbba]

        tdf#166932 UpdateStylesList followup
        
        where I forgot to add an else statement. spotted by caolanm
        
        Change-Id: Ic228f081b1f07d4d7491c2ee5ecf7f46e64d4865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 7920c94ed85c648bc301e1d32171ffa20d056083)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186895
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-24  Jonathan Clark  <jonathan@libreoffice.org>  [2a3effb172c107e783e18307059a0337e31a9c7b]

        tdf#163761 Fix for tofu inside mixed-direction fallback runs in GUI text
        
        Fixed a bug inside MultiSalLayout::ImplAdjustMultiLayout() that caused
        tofu characters and improper position adjustment for certain UI text
        with bidi fallback runs. The root cause was an implementation error
        causing the current glyph index in the base layout to outpace the
        current fallback run.
        
        Regression from commit 9c2eb9c872bb10049fcb0217842b3bb849c27a22
        (tdf#373494: Correctly drop NotDef glyphs in mixed direction fallback runs)
        
        Change-Id: I7c16943866bdd465cc3c2c1f8540b38d2d4d529c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186720
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 7cafd6648d991d9f25466766042416e0c686074b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186738
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>

2025-06-23  Michael Stahl  <michael.stahl@allotropia.de>  [e289ec223a14460abb7e09fbdf6a868f0a1f71cf]

        tdf#166602 editeng: fix painting cursor in vertical text
        
        The size is relative to the top right.
        
        (regression from commit 34cf82953ccd260a05a1c3838178ba50314e2eef)
        
        Change-Id: Id0e63e40c580a4b700cc09b476bd8bc9f60aa368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186823
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        (cherry picked from commit 2cd2ea6cc012f1096494b4198cfbb3ea56859157)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186830
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-23  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ac2a682fff0ef3deb92f59824d0581f272b95f78]

        Update git submodules
        
        * Update helpcontent2 from branch 'libreoffice-25-8'
          to 69804ed9b03f9e8548c178174e1cfb2eaac9dcf2
          - remove extra tag character of Send menu path
            
            Change-Id: I5e16f091a6c3ae8a9951491cb6d39e6b678049e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186798
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            (cherry picked from commit 91823540c52442d1ec5a268d01ff0186ecb0a342)
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186841
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [502215d0cc0a07509dd3b75818cc086aae10134f]

        tdf#166978: replace HUGE_POSITIVE hack with proper upper invalidation
        
        The problem was, that the change of section's height (either to zero
        when hiding, or from zero to some height when showing) could keep its
        upper's size unchanged and valid. Invalidating the upper's size in
        SfxHintId::SwSectionHidden handler was not enough; in the following
        layout calculation, the upper sets its mbFrameAreaSizeValid to true
        before its lowers' calculation. Then, during their calculation:
        
        * If the section was hiding, SwFrame::MakeValidZeroHeight would fail
          in ShrinkFrame, then force its height to 0 in 'if (IsLayoutFrame())'
          block, and not notify upper;
        * If the section was showing, SwSectionFrame::Grow_ could see that
          the upper has space enough for the section (e.g., when there are
          more children after this section), and also not notify upper.
        
        The HUGE_POSITIVE hack allowed to force following re-layout in some
        cases; but the bugdoc failed when the cell was initially made very
        tall, and hat to split; then the section in it was shrinked to 0,and
        that didn't cause the merge with the follow.
        
        This fixes the problem by:
        1. Removing of the HUGE_POSITIVE hack;
        2. Invalidating upper cell frame in SwSectionFrame::Grow_, similar
           to commit ee57229154a91cf632871cfcb1eb9609908f3882 (Fix #88178#:
           Sectionframe in headerframe, don't grow without invalidation,
           2001-06-13);
        3. Invalidating layout frame's upper in SwFrame::MakeValidZeroHeight,
           when ShrinkFrame didn't make it 0-height.
        
        In #3, I decided to not check the upper's kind, for robustness; if
        needed, checks may be added in follow-ups, for specific problems.
        
        Change-Id: Iafdd1c41b52d2170d5dd2b3bc2cbc1a5f657c0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186779
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 4cfd0c99d1bd85a4927cb3b433b903cc26f5ef95)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186787

2025-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [c26a501a64671da16cef6687bb081356134935a9]

        tdf#167147: Support transparent fill color
        
        Change-Id: I5a38a52f2720f58bc2762d328fb6a5e4090c6dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186780
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 42e566654aa926caf51457b78a3b0dbb81b2f6a2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186781

2025-06-21  Heiko Tietze  <tietze.heiko@gmail.com>  [c492833621723344dc6b7c3204df443b6c5780d0]

        Resolves tdf#167092 - Remove irrelevant tooltip from UI picker dialog
        
        Change-Id: I230cd697b4d0ba3a00ff51ea184e5ccfe2d5c76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186732
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        (cherry picked from commit 39face07109e483ae61573d362ae6a2a4629dcc5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186753
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2025-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a56c6315c0b7969711e7da5d722d1f28c0e72ddf]

        tdf#167128: sw: Add UItest
        
        Change-Id: I9e7731b696e3e45903820dd2747ec958c2075e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186766
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit b5d94b9e26e6f2b30acb8a406bd7fb7bf8fe86ad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186775

2025-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [433a2da37a4bff45fe99cfde1d874fa41c769a32]

        tdf#167034 sd: Populate graphics bullet menu when creating dlg
        
        Since
        
            commit f075fa01cb4f74185f13eb0a8d7f84cf1f47af49
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 22 10:26:32 2023 +0200
        
                tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        , the menu button toggled handler is no more called before
        the menu shows (at least for the VCL implementation).
        
        Populate the menu entries in the SvxBulletAndPositionDlg
        ctor instead, to ensure they are present when the menu gets
        shown.
        
        Change-Id: I02c65f11bfb532ecfb6e91578d26ea9dfc2e31a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186771
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        (cherry picked from commit 94564497514c4419062d13abad057255df9f369d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186776

2025-06-20  Mike Kaganski  <mike.kaganski@collabora.com>  [baac4aadebf20fcd2b68a9e867534eab332b0976]

        tdf#167128: SwRedlineAcceptDlg: move enabling controls after selection
        
        It was done in InitAuthors, which was called before lcl_reselect;
        and therefore, opening the dialog would not see the selection, and
        not activate buttons properly.
        
        Now the "Accept" and "Reject" are active upon dialog opening, when
        there is a selection.
        
        This required extracting the respective code to a separate function.
        
        Change-Id: I3a02384b402312613fef4b2d3932d19c9b1acc19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186752
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186767

2025-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [8fffc33fe79c7643d0aaa045024f2fc2cc863cdf]

        nss: upgrade to 3.113
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_113_RTM/src/nss-3.113-with-nspr-4.36.tar.gz
        
        Change-Id: I9327a325fc2bdc1159c9dda1c8e54963b410e8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186735
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit d6efc1cd776393fc70a8dc0e2e1d6dc26df38035)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186763

2025-06-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bd90bfb91c2378f2e0aca502c44b5c6502da4170]

        tdf#117346 - Show current data range of the filter without selection
        
        After resetting the filter, show current data range of the filter with
        selection. This reset also the filter button.
        
        Change-Id: I3885e3d21ce3849abe4786621d0fc391b29f8b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186695
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        (cherry picked from commit 06135b1102d28ae1c2d95e52504e824a9847bf12)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186722
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-19  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [ba75d268f3688360e2d48e17e73902fc84f5751c]

        fix spellcheck dialog preventing replacement of "."
        
        There appears to be special logic for replacing words that end
        with a dot in the spellcheck dialog. Where the dot at the end is
        ignored during replacement.
        
        This special handling is only there for the spelldialog, i.e. it
        is not there if you try to do the replacement via the context
        menu or via IDocumentRedlineAccess.
        
        e.g. If the text with the error text is only "." and the
        replacement is "REPLACEMENT", clicking Correct button on the
        dialog ends up with "REPLACEMENT."
        
        Make it so that if the error text is just a dot, do not enforce
        having a dot at the end of the replacement. Since it is obvious
        the suggested replacement is for the dot.
        
        It feels to me like the whole special handling for dot was
        originally dictionary/suggestion error and was worked around in
        the wrong place.
        
        Change-Id: I65675ad18e5386f65ee978c0e92952bba29ae3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184495
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        (cherry picked from commit 0eea3f11f887e7722b16816eaa082ca33f340911)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186379
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-19  Michael Stahl  <michael.stahl@allotropia.de>  [0b2f300a359b314d3ec4daa0353cd165c3912626]

        tdf#159549 offapi: clarify docs of css::style::StyleFamily
        
        Change-Id: I5391968e93bb28f0c5fc2c41673d4c6df344bfa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186653
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        (cherry picked from commit c3974de96fb00ec4e5bddba8661c4b9ca1c1bdbd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186676

2025-06-19  Miklos Vajna  <vmiklos@collabora.com>  [313065a0a25d3d95b287c292b909e9a8a0627660]

        tdf#166319 sw interdependent redlines: fix redo of reject of del-then-fmt's del
        
        The bugdoc has <del>AA<format>BB</format>CC</del>, rejecting AA just
        leaves the BB format redline, undo works, but redo results in no
        redlines, while we again want a single format redline.
        
        The first problem was that the del-then-fmt redline's undo action was an
        SwUndoAcceptRedline, while the UI action was a reject. This was not a
        problem on undo, since both accept and reject has the undo code to
        restore a previous state, but redo will have to perform different
        actions (re-accept or re-reject).
        
        The second problem was that sw::DocumentRedlineManager::RejectRedline()
        assumed that rejecting an underlying redline (depth = 1, instead of the
        usual depth = 0) could be always implemented by accepting the redline,
        since that works for the insert/delete combination. Improve this, so in
        case we get a format-on-delete, then we again properly reject just the
        underlying redline, as the original UI action did.
        
        Change-Id: I846abcfa34a7d55709bc9af6e566a3e83d79d833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186700
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 5ed41ca44bee5122a9db4aa946f6e3ecd9432574)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186707

2025-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [d278df87154f85723e3bdd68c6780fb60100a835]

        Revert "tdf#165487 Always select a tab page by default"
        
        After
        commit eaa970c9b9d4d8e9e29e419791f7d0dceb7c4d8c
        Author: Heiko Tietze <tietze.heiko@gmail.com>
        Date:   Wed Jun 18 11:26:24 2025 +0200
        
            Resolves tdf#167066, relates tdf#165487 - Show first tab as fallback
        
        so it fixes
        https://bugs.documentfoundation.org/show_bug.cgi?id=165487#c16
        
        This reverts commit a91494780bb59afe8c971003e6b809f1e66df050.
        
        Change-Id: Id268a8aaff7c0df48b29bdf150a97dad8fa08d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186663
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit c8acf629967aed607aa639ef8fd00de67431168d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186674

2025-06-18  Heiko Tietze  <tietze.heiko@gmail.com>  [0d4280be21dbe203cb6254a35fd324c764dec63c]

        Resolves tdf#167066, relates tdf#165487 - Show first tab as fallback
        
        If the dialog runs for the first time, the viewoptions
        are empty and no tab would be active, crashing on Reset
        
        Change-Id: Ib889c17c5ef5876aa9e6e258d999f7e566aff514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186656
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit eaa970c9b9d4d8e9e29e419791f7d0dceb7c4d8c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186661
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Michael Stahl  <michael.stahl@allotropia.de>  [169050eab3700c3012c2b1583000a922442f153b]

        tdf#159549 tdf#166850 sw,xmloff: fix localised STYLEREF differently
        
        SwXTextField must for the "SourceName" property convert from ProgName to
        UIName on setting and reverse on getting, for consistency with the rest
        of the sw UNO services.
        
        This is annoyingly complicated because the "sPar1" of SwGetRefField is
        used for numerous other purposes, including a bookmark name.
        
        Revert writerfilter changes of commit 80877c7dc467bf5ad6b28ec1b2662db36fcf7542
        but keep the test.
        
        With de_DE locale we now get "Überschrift 1 (user)" cloned style (same
        as the reverted fix), and exported to ODF as "Überschrift 1"; the ODT
        works when loaded both with the same and a different locale.
        
        Unfortuantely an ODT created by versions on the 24.2 branch >= 24.2.4,
        which used to work being loaded in the same locale but not in a
        different one, stops working when loaded in the same locale with this,
        so add an incredibly ugly flag to SwDoc because no SvXMLImport etc can
        be accessed from SwGetRefField.
        
        Move testTdf160402 to the new ooxmlexport26 because it also failed with
        de_DE locale.
        (regression from commit e45f187870362ed4448f4a9fb96883b8431887fb)
        
        Change-Id: I6b7862f142d602544165d8b5a254bf8af28e527b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186228
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        (cherry picked from commit f5d48df7355ac7db3f3dd396eed1e7c57658ef7c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186626

2025-06-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [71dfc16dae3232024242e7d3c009a34a51f411a6]

        Related: tdf#166633 - sc fix wrong context menu for textboxes
        
        Remove unnecessary statement from else if.
        
        Change-Id: I91f2417404ecce1eefd056806fa1cc78a9267517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186625
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        (cherry picked from commit cf339d5f79551dec606e4872d2bb0307be382080)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186637
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d09352fc7a49e177375ce753f2cf99c89062ac9]

        tdf#167010: fix build when poppler is older than 25.2.0
        
        After
        commit 4f13305178c1bf88dffceb42ec15d0944b808a5c
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Wed Apr 2 16:27:00 2025 +0200
        
            poppler: upgrade to 25.04.0
        
        and the upstream commit
        commit 5d71c95d08aa0e097f711254e1c69ee0cf275328
        Author: Nelson Benítez León <nbenitezl@gmail.com>
        Date:   Sun Jan 5 21:33:23 2025 +0000
        
            Detect malformed Streams in Annot Appearances
        
        Change-Id: Id308aac0331a77aca88ebf8e31bf3aa0a688533a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186599
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 04b92e6eab3d58e90efa04165dec4f04e9131690)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186638

2025-06-18  Noel Grandin  <noelgrandin@gmail.com>  [be690ae0ef961c3721504a02fb36cf07c7a008af]

        tdf#166922 reduce memory usage in BufferedDecompositionFlusher
        
        which was keeping stuff alive for too long.
        
        regression from
            commit 8a17b7f0a679ebf21bcfb425186b205d996d129b
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Mar 13 18:37:54 2025 +0200
            tdf#131595 Improve drawinglayer flushing mechanism.
        
        Change-Id: I82c3e11d027b22a969d2ce786a0945fea2deb6b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit b17e0bb5cab4484905dc72172735725bf4460e8e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186406
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Noel Grandin  <noelgrandin@gmail.com>  [5f68287bc551d9bde7c5039180fa75d180ea0287]

        tdf#166932 avoid O(n^2) loop in UpdateStylesList
        
        Change-Id: I930ec5ae4229509a98d28bd7afe7124d29c827b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186366
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 7359e9c742d35c999eb9add524052887805e7b26)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186378
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Gökay Şatır  <gokaysatir@gmail.com>  [212718852a089c81811dcadabf277673fe06b682]

        cool#12147: Revive previous copy behaviour on load.
        
        We added some improvements for copying the comments along with their replies before. Which is done with commit:
        * https://gerrit.libreoffice.org/c/core/+/177396
        
        But it somehow broke docx export, when there are comments in file.
        
        TextNodes are copied while loading the document. And the error seems to occur in this phase.
        This commit keeps the previous behaviour while loading the file.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I80c343cbc4886f4277e38ff23553195cc8b1acfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186043
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186605
        Tested-by: Jenkins
        (cherry picked from commit e2d32fec07396a75754a8979db6108213df11114)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186620
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2d5f12ee874b3bc37531ba6b7baffe05afa5d4e7]

        tdf#160024 - a11y UI - better tautological string for a11y warning
        
        Based on the discussion in the bug ticket.
        
        Change-Id: Id15ecf21c4cd2d37956b12b1fec3735501571da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186416
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit 84a992e45b70d2c0c2f9c0c2d79605918ec3727e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186575
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [f05e8170d288d1fd2c801c4b62154ee95d3f6df3]

        tdf#166996: handle menu commands asynchronously
        
        Instead of doing that command by command, this change tries to do it
        globally, posting user event with the command data; it will run when
        event loop gets to it; the menu gets closed by that time.
        
        Change-Id: Ifdea666be8557a576dd6cd934898343631a3a95e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186470
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit e931c4e9399ba96054ed153204627579242a5cc6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186543
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1b483ccbff6a67618f8c58cf1b53fd31edf92733]

        tdf#166970 sw a11y fix missing no_alt warnings from sidebar
        
        Not all kind of shape objects were checked for "No alt text",
        but only a few one. Let's extend it with the other possible
        shape types in this patch.
        
        Change-Id: Id3bcf4992fc8f281ee4a32c569cba3590ae6c002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186413
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        (cherry picked from commit 8a5172f61d703e9ab28329466e3d42a0adb4e987)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186540
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b297dc8b22001e34f1caad0c4810329610716300]

        tdf#166968 A11Y sidebar hides direct formatting issues after PDF export
        
        Revert "prevent accessibility check from locking up the UI"
        
        This reverts commit e081e03342ca8c262403bd9febdc01151a2935be.
        
        Since it seems to cause problems.
        
        Change-Id: I278e51260bc921ff14ab6474a12bedf073ddc3dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186427
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit d73330a77fbf0b5d975d713fb28cac2a7be39495)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186448
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Regina Henschel  <rb.henschel@t-online.de>  [d11ef3ee76cc273ac68dc4028be0569b6dc8b86b]

        tdf#144743 Allow guide name with starting digit
        
        In OOXML, it is allowed for a guide name to start with a digit. The
        presetShapeDefinitions funnel, mathEqual, and mathNotEqual have such
        guides.
        
        If a formula uses such a guide, LO imported it as a number instead of
        a reference to the guide. The problem occurs with both prstGeom and
        custGeom.
        
        Change-Id: I7cda3be05d98c3101e84da0dcb01686a97baa77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186478
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        (cherry picked from commit 312ba0c7657807097ce4577072e533a4fcca329a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186552
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2239e2f813879b7b9a6a36350fd5d8d340a13388]

        Related: tdf#166968 - A11Y - remove unnecessary elements from the entries
        
        Need to remove all elements from entries before building up and populate the
        new issues. Otherwise we will have multiple elements.
        
        Change-Id: I3a391b8ccf91f14d8650861c39bc3561af6282ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        (cherry picked from commit 32501882c64e5abaefe2c979afb493b0e378e46a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186628
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Jonathan Clark  <jonathan@libreoffice.org>  [a64df17b7a922d8d9f1cd2358c9f2f78bc6fd6e8]

        tdf#119192 editeng: Fix for copy-and-paste using font from wrong script
        
        To minimize the size of the output RTF, Edit Engine only emits font
        attributes when either the font changes or when the script type changes.
        
        In the latter case, Edit Engine was previously writing font attributes
        inside a child scope, rather than the paragraph scope. Font changes
        related to a language change would thus apply only to the first run of
        characters in that language, while following runs would appear to use an
        arbitrary language.
        
        Change-Id: Iff38299bffaf3045cef5c6e71b8cab441ba0be39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186612
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit c28307fa99dae0322a3dca7ce0010d87c93ec85a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186636
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-18  Miklos Vajna  <vmiklos@collabora.com>  [d81328b59856d2b370110dd1d92a9cce27af34f0]

        tdf#167044 sw RTF import: fix bad image size in shape text
        
        Regression from commit 57d9cc81b058757421cd082e5dbe32a919716807
        (tdf#127806: RTF import: use shape dimensions for pib picture,
        2022-09-01), open the bugdoc, the icon image inside the shape should be
        about 0.37cm x 0.37cm, is about 14.98 cm x 12.66 cm.
        
        What happens is that \pict was assumed to be inside the property value
        of a shape, in which case both the shape and the picture can have a
        size, and the old use-case requires to ignore the inner size. The new
        use-case is two user-visible shapes: an outer text frame and an inner
        small icon image, inside shape text. The different sizes are wanted in
        this case.
        
        Fix the problem by conditionally going back to the old behavior of not
        inheriting size for the inner shape. The name of the destination at the
        top of the parser stack is different for the "in property value" and the
        "in shape text" cases, so this keeps the old use-case working while
        restores the wanted small size for the new use-case.
        
        Here the difference between the old and new size was so large that the
        end-user saw this as "the image was not visible previously".
        
        Change-Id: Ife93089b967fc26b7180775db8fc507a896d160b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186602
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e0e415ba89925a933f8a07e4a2524269bd5c7495)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186627

2025-06-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a74eada6b7e7f8b2c7319748a9c3b21b91a7b17]

        libxml2: upgrade to 2.14.4
        
        * 0001-parser-Fix-custom-SAX-parsers-without-cdataBlock-han.patch.1
        has been fixed upstream
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.14/libxml2-2.14.4.tar.xz
        
        Change-Id: Icd9ab0d96e8d9299716a16a967c424a565264d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186609
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-17  Miklos Vajna  <vmiklos@collabora.com>  [65177866f334d90c29a946efd4b530f80c071e5d]

        tdf#166319 sw interdependent redlines: redo of creating an ins-then-fmt redline
        
        The bugdoc has <ins>AABBCC</ins> in it, selecting BB, marking the
        selection as e.g. bold + undo + redo resulted in a plain format redline
        for BB instead of a hierarchical insert-then-format redline.
        
        Checking SwUndoAttr, its item set correctly tracks the boldness, also it
        tracks the own (format) redline in m_pRedlineData correctly, together
        with the pre-existing redline data in m_pRedlineSaveData. Also, checking
        how this works in the undo case, SwUndoAttr::UndoImpl() first deletes
        all redlines in the interesting text range and then restores the
        pre-existing redline using a call to SwUndo::SetSaveData(). In the bad
        case, what instead happens is that SwUndoAttr::redoAttribute() calls
        sw::DocumentContentOperationsManager::InsertItemSet() with redline
        tracking enabled, that creates a format redline, then we try to create
        our own format redline, and the last one wins, losing the underlying
        insert redline.
        
        Fix the problem by improving SwUndoAttr::redoAttribute() to also call
        SwUndo::SetSaveData() to re-create just the pre-existing insert redline:
        with this the following AppendRedline() will result in the correct
        insert-then-format hierarchical redline.
        
        Change-Id: I1e1a284c017f39c62dcc03b6b49463bac106f21b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186566
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit e06eb6b4a6176692d25c758121012473fe638043)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186574

2025-06-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [31d4f5624a7019dbd9a59b6769290db409e8236f]

        tdf#167023, tdf#167018: sw: Add UItest
        
        Change-Id: I81386e6b6f3052c07be3271cac31eb4194ef0bc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186551
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit f2e8141fdb80611dd2c27924ece8edd56e11a332)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186561

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [44f49131facf53632c6da66eb8ce2fdef734cb1d]

        tdf#167023: only try PasteSlidesFromSystemClipboard with correct descriptor
        
        PasteSlidesFromSystemClipboard seems to have some serious side effects,
        making following paste of different flavors fail. So check the object
        descriptor, which allows to avoid the problematic code for non-Impress
        objects. This also improves performance. But the underlying problem is
        not fixed here.
        
        Change-Id: I3c58c502900eb7c76b08b77945049bfa6a149182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186526
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186550

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [90dec68c914aed6529ce8bfde5b1df05bc74b6c6]

        Related: tdf#167018 Generalize and deduplicate Theme::FromAny
        
        Let it also handle a hypothetical non-UnoTheme implementation (it
        is possible to create these e.g. from Basic / Python code). When
        handling it, use theme name as color set name (there seems to be
        no UNO API to get color set name?). And use the same code for the
        creation of Theme from PropertyValue list.
        
        The check that enumrange<ThemeColorType> does not iterate through
        ThemeColorType::Unknown is redundant, since that value is outside
        of [0, LAST] range.
        
        Change-Id: Iae6770f196011deeb2a92d3b64af514fb6a53d06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186513
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186549

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4b62bbed3dc46461b4dde86ec9814c39663c1d02]

        tdf#167018: let Theme::FromAny handle XTheme
        
        It is created e.g. in XMLThemeContext dtor.
        
        The type of return of FromAny is changed to shared_ptr, which allows
        to return the result of UnoTheme::getTheme, and which matches the
        types used by all the function callers.
        
        Change-Id: Ie223e5663843be098e2da45cb04d825c72c372fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186508
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186548

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [e4ed2f1b835f23d4691c693e1deaae49426adab5]

        tdf#167018: throwing out of a dtor is fatal
        
        The exception was thrown with this stack:
        
          comphelper.dll!com::sun::star::lang::IllegalArgumentException::IllegalArgumentException(const rtl::OUString & Message_, const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & Context_, const short & ArgumentPosition_, std::source_location location) Line 39
          comphelper.dll!comphelper::SequenceAsHashMap::operator<<(const com::sun::star::uno::Any & aSource) Line 151
          comphelper.dll!comphelper::SequenceAsHashMap::SequenceAsHashMap(const com::sun::star::uno::Any & aSource) Line 109
          docmodello.dll!model::Theme::FromAny(const com::sun::star::uno::Any & rVal) Line 86
          sdlo.dll!SdXImpressDocument::setPropertyValue(const rtl::OUString & aPropertyName, const com::sun::star::uno::Any & aValue) Line 2879
          xolo.dll!XMLThemeContext::~XMLThemeContext() Line 57
          xolo.dll!XMLThemeContext::`scalar deleting destructor'(unsigned int)
          xolo.dll!SvXMLImportContext::release() Line 106
          xolo.dll!rtl::Reference<SvXMLImportContext>::~Reference<SvXMLImportContext>() Line 126
          xolo.dll!SvXMLImport::endFastElement(long Element) Line 889
          saxlo.dll!`anonymous namespace'::Entity::endElement() Line 515
          saxlo.dll!sax_fastparser::FastSaxParserImpl::consume(`anonymous-namespace'::EventList & rEventList) Line 1021
          saxlo.dll!sax_fastparser::FastSaxParserImpl::parseStream(const com::sun::star::xml::sax::InputSource & rStructSource) Line 860
          saxlo.dll!sax_fastparser::FastSaxParser::parseStream(const com::sun::star::xml::sax::InputSource & aInputSource) Line 1479
          xolo.dll!SvXMLImport::parseStream(const com::sun::star::xml::sax::InputSource & aInputSource) Line 528
          sdlo.dll!`anonymous namespace'::ReadThroughComponent(const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & xInputStream, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xModelComponent, const rtl::OUString & rStreamName, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const char * pFilterName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rFilterArguments, const rtl::OUString & rName, bool bMustBeSuccessful, bool bEncrypted) Line 226
          sdlo.dll!`anonymous namespace'::ReadThroughComponent(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> & xStorage, const com::sun::star::uno::Reference<com::sun::star::lang::XComponent> & xModelComponent, const char * pStreamName, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & rxContext, const char * pFilterName, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rFilterArguments, const rtl::OUString & rName, bool bMustBeSuccessful) Line 369
          sdlo.dll!SdXMLFilter::Import(ErrCode & nError) Line 615
          sdlo.dll!sd::DrawDocShell::Load(SfxMedium & rMedium) Line 295
          sfxlo.dll!SfxObjectShell::LoadOwnFormat(SfxMedium & rMedium) Line 3611
          sfxlo.dll!SfxObjectShell::DoLoad(SfxMedium * pMed) Line 712
          sdlo.dll!sd::slidesorter::controller::Clipboard::PasteSlidesFromSystemClipboard() Line 965
          sdlo.dll!sd::View::InsertData(const TransferableDataHelper & rDataHelper, const Point & rPos, char & rDnDAction, bool bDrag, SotClipboardFormatId nFormat, unsigned short nPage, o3tl::strong_int<short,SdrLayerIDTag> nLayer) Line 711
          sdlo.dll!sd::View::DoPaste(sd::Window * pWindow, bool __formal) Line 329
        
        Change-Id: I5eca1088c75aafd0151d778c4fc16becb1e579dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186507
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186547

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [66a3d04b5d5e1b968557c0eb656753a77831a87e]

        tdf#155835: copy current encoding into newly created substream state
        
        RTF is defined to copy the current state whenever a new destination
        appears. Before the change, RTFDocumentImpl::resolveSubstream didn't
        keep its current encoding in the child RTFDocumentImpl; that led to
        its m_aDefaultState having the default RTL_TEXTENCODING_MS_1252; and
        when the destination didn't define its own encoding (e.g. using \fN),
        the non-ASCII octets were treated incorrectly.
        
        I don't know if other members of m_aDefaultState should be set to
        parent's current state. In theory, this could even be a full copy.
        
        Change-Id: I6f53bfd519598b5a4b5cd1f04f13575a5aa1fa2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186499
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 41b1542326d4924730ffad51cd01399f3b6ca237)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186545
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-16  Regina Henschel  <rb.henschel@t-online.de>  [e93180fd98fa6adca27beafb8fc5352f8ba140b0]

        tdf#166428 accept stock charts with only low and high series
        
        A stock chart may consist of only series 'Low' and 'High' in UI. But
        the method MergeSeriesForStockChart() expects three series. The third
        one is for a series 'Close'. That corresponds to ODF. For this third
        series, LO writes a series without chart:values-cell-range-address. That
        is allowed in ODF.
        
        mbAllRangeAddressesAvailable is set to 'false' on import, because of
        this dummy series. Thus MergeSeriesForStockChart() was not executed.
        LO 24.8 has used as fallback, to generate the chart from the range
        stored in msChartAddress. This member gets its value from attribute
        table:cell-range-address of the chart:plot-area element.
        
        This attribute was already deprecated for long time and is now removed
        in ODF 1.4. Therefore the fallback does not work any longer for documents
        saved in ODF 1.4, which is the default for LO 25.x. Loading such chart in
        LO 25.x had lost all series.
        
        Fortunately it is not necessary to skip MergeSeriesForStockChart() if
        there is an empty series. The method can already handle it itself. The
        fallback would have not been necessary in LO 24.8.
        
        The patch changes the procedure so, that MergeSeriesForStockChart is
        called even if mbAllRangeAddressesAvailable is false. I don't know
        whether the fallback is used for other chart types in documents
        producted by older LO or OOo versions. Thus I have not changed the
        else-branch.
        
        Change-Id: I2f059cb1778cf84161cf08b35c27ef50a66aefe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186386
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        (cherry picked from commit af99860d42c672c3c47aab5e3b55f0bb52df4b4e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186409
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-16  Regina Henschel  <rb.henschel@t-online.de>  [d49fc1cfb76514e300a3670f18e751c0710d81a6]

        tdf#166664 adds missing erase in deleteSeries
        
        commit 84f7b840 has moved deleteSeries from DataSeriesHelper to
        ChartType. But the move has lost the actual erase.
        
        No unit test, because I don't know how to use a dialog in a test.
        
        Change-Id: I92dc1d2bdae0fe0d63b6c3b012b50b8c66032334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186512
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 3391dfad01efddb4bfd3b2bfef221a17ac11e43a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186541
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-16  Noel Grandin  <noelgrandin@gmail.com>  [be7ca6ab992406afc7841c33c7a6d8bfb4795185]

        tdf#166849 moving slide with keyboard does not update display
        
        regression from
            commit ad3fa69eeb89573c77feba64dab3380154a90953
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Sep 6 12:55:26 2024 +0200
            reduce time spent in RecalcPageNums when importing PDF
        
        Change-Id: Ic5b2e73a7871f2a89cbd38bef91ad09152304d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186472
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit cc99f7736e10c8290d34eeb96aa6a3b7fd63a212)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186542
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [9c1b1dd020576392b469d6bcec2b64b3c4aadff0]

        tdf#167006: OWriteStream needs to implement comphelper::ByteReader
        
        A crash seen with this call stack:
        
          package2.dll!ByteGrabber::ByteGrabber(const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & xIstream) Line 44++
          package2.dll!ZipFile::ZipFile(rtl::Reference<comphelper::RefCountedMutex> aMutexHolder, const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & xInput, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> xContext, bool bInitialise, bool bForceRecovery, ZipFile::Checks checks) Line 92++
          package2.dll!std::_Construct_in_place<ZipFile,rtl::Reference<comphelper::RefCountedMutex> &,com::sun::star::uno::Reference<com::sun::star::io::XInputStream> &,com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &,bool,bool,enum ZipFile::Checks>(ZipFile & _Obj, rtl::Reference<comphelper::RefCountedMutex> & <_Args_0>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & <_Args_1>, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & <_Args_2>, bool && <_Args_3>, bool && <_Args_4>, ZipFile::Checks && <_Args_5>) Line 476++
          package2.dll!std::_Optional_construct_base<ZipFile>::_Construct<rtl::Reference<comphelper::RefCountedMutex> &,com::sun::star::uno::Reference<com::sun::star::io::XInputStream> &,com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &,bool,bool,enum ZipFile::Checks>(rtl::Reference<comphelper::RefCountedMutex> & <_Args_0>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & <_Args_1>, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & <_Args_2>, bool && <_Args_3>, bool && <_Args_4>, ZipFile::Checks && <_Args_5>) Line 157++
          package2.dll!std::optional<ZipFile>::emplace<rtl::Reference<comphelper::RefCountedMutex> &,com::sun::star::uno::Reference<com::sun::star::io::XInputStream> &,com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> &,bool,bool,enum ZipFile::Checks>(rtl::Reference<comphelper::RefCountedMutex> & <_Args_0>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & <_Args_1>, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & <_Args_2>, bool && <_Args_3>, bool && <_Args_4>, ZipFile::Checks && <_Args_5>) Line 355++
          package2.dll!OZipFileAccess::initialize(const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aArguments) Line 243++
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & arguments) Line 728++
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, bool singletonRequest, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & arguments) Line 690++
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(const rtl::OUString & ServiceSpecifier, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & Arguments, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & Context) Line 1014++
          writerperfectlo.dll!writerperfect::WPXSvInputStream::isZip() Line 705++
          writerperfectlo.dll!writerperfect::WPXSvInputStream::isStructured() Line 489++
          mwaw.dll!MWAWInputStream::isStructured() Line 841++
          mwaw.dll!MWAWInputStream::unsplitInternalMergeStream() Line 574++
          mwaw.dll!MWAWInputStream::MWAWInputStream(librevenge::RVNGInputStream * inp, bool inverted, bool checkCompression) Line 79++
          mwaw.dll!MWAWDocument::isFileFormatSupported(librevenge::RVNGInputStream * input, MWAWDocument::Type & type, MWAWDocument::Kind & kind) Line 143++
          wpftwriterlo.dll!MWAWImportFilter::doDetectFormat(librevenge::RVNGInputStream & rInput, rtl::OUString & rTypeName) Line 50++
          wpftwriterlo.dll!writerperfect::detail::ImportFilterImpl<OdtGenerator>::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & Descriptor) Line 136++
          filterconfiglo.dll!filter::config::TypeDetection::impl_askDetectService(const rtl::OUString & sDetectService, utl::MediaDescriptor & rDescriptor) Line 1136++
          filterconfiglo.dll!filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor & rDescriptor, const std::vector<filter::config::FlatDetectionInfo,std::allocator<filter::config::FlatDetectionInfo>> & lFlatTypes, bool bAllowDeep, rtl::OUString & rLastChance) Line 1041++
          filterconfiglo.dll!filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lDescriptor, unsigned char bAllowDeep) Line 436++
          emboleobj.dll!OwnView_Impl::GetFilterNameFromExtentionAndInStream(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & xContext, std::basic_string_view<char16_t,std::char_traits<char16_t>> aNameWithExtention, const com::sun::star::uno::Reference<com::sun::star::io::XInputStream> & xInputStream) Line 207++
          emboleobj.dll!OleEmbeddedObject::TryToConvertToOOo(const com::sun::star::uno::Reference<com::sun::star::io::XStream> & xStream) Line 265++
          emboleobj.dll!OleEmbeddedObject::doVerb(long nVerbID) Line 908++
        
        where ByteGrabber ctor takes an instance of OWriteStream.
        
        Change-Id: Ic60fa1aa3e79848256273c761d132d6bb33c179a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186479
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 587e46e7bc7b2e8520e34b48fa7ef3f188964029)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186544
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [a065f3a753e547b56efcdcc2a6669356bd0ca9c8]

        tdf#166972: do not reset parameters in SbUnoObject::Notify
        
        Resetting parameters in this function was introduced in commit
        0b21b8b146fc4b982c7c9bbb866b9ff18a29332a (initial commit for vba blob
        ( not including container_control stuff ), 2010-10-06). Unfortunately,
        the reason for that is not explained.
        
        The problem that it creates is that this code gets called eventually
        from SbiRuntime::FindElement (which sets parameters using SetupArgs,
        then calls SbiRuntime::CheckArray in the end, which calls GetObject,
        which performs actual data access).
        
        In SbiRuntime::CheckArray, the immediate problem was, that parameters
        were referenced using a raw pointer; when the parageters were cleared
        in GetObject, the pointer got dangling.
        
        But it wasn't enough to use e.g. SbxArrayRef there, to keep the array
        alive; the object will be accessed later, and needs its parameters to
        work. On the other hand, it feels wrong to reinstate parameters after
        the call to GetObject in SbiRuntime::CheckArray (getting the object
        can run just any code path). So I chose to try and drop the resetting
        of parameters in SbUnoObject::Notify. Let's see, if something breaks.
        
        Change-Id: Icadfcfb8b7e5e87b2de46166963fd97532f8713c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186432
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit b038106e8d3b24d794bfec0aa4d6b42fc470c4e4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186438
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-16  Jaume Pujantell  <jaume.pujantell@collabora.com>  [5bfb41e13b59c882fc3e39c3b6e69c7038985283]

        tdf#166940 sw: defer line break in ref field
        
        In Writer ref fields contain only text strings and it does not support
        line breaks. So, to avoid misplacement of the content on load, we
        defer the breaks until after the field is finished.
        
        Change-Id: I3d9a78743deb0d4f7f187a5c59b58e74ae3b20d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186008
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit e0119fbf861af288e3efe55efcd9aa88adaff80f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186450
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        (cherry picked from commit aa689d596c44c1c51ab9345df5d063768936fe74)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186455
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-15  Julien Nabet  <serval2412@yahoo.fr>  [211c193b1c7391b4f1c1172214a90899de19b06a]

        Fix invalid cast from 'GtkImage' to 'GtkLabel' in bulletandposition.ui
        
        Change-Id: I961f3560c669eec4a1842f47bb3e8a7da5049589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186521
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit 3b49f5bcb56ca7120ac3d145291b0ae75bcf634d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186523

2025-06-14  Martin Srebotnjak  <miles@filmsi.net>  [63ea7d3139e32c688dc3690997f19ad74a6f2067]

        Update git submodules
        
        * Update translations from branch 'libreoffice-25-8'
          to 6dbcba8d5e73f6bf9178e29f126255bbbec07ddd
          - Updated Slovenian translation
            
            Change-Id: I28b56c7e06acfd0209e7e9d90ff5d5bcd1933225
            
2025-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [54ea623c76f5f739b56f820d52a0a784e3e73af6]

        tdf#166943: zero passed to AllowMoreInput means "no more input"
        
        Users of ToggleUnicodeCodepoint keep reading next characters to the left,
        until AllowMoreInput returns false (or selection ends). Attempting to
        read more characters to the left then there are, SwCursorShell::GetChar
        returns 0. This needs to be treated by AllowMoreInput as hard stop. It
        failed, when the previous character was a combining character.
        
        Change-Id: I203b150154e1948d4cebfd69442e30a076710f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186341
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 58a7c6ccfd3fa590460dba1ecbdef4483dcd5e08)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186350
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [40c5a2731abc5f17093624b162c2d5280a66c774]

        tdf#166669: make conditional formatting for duplicates case insensitive
        
        Change-Id: I991082fe4c4ad94c1c8ed10caae37eba5c0b8e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186471
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit a7354ccdba7a608f66b98b4e0025a11504d15f11)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186480

2025-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ac670709e9df15611ad8c2d83d8304e54334cc1]

        libpng: upgrade to 1.6.49
        
        Downloaded from
        https://sourceforge.net/projects/libpng/files/libpng16/1.6.49/libpng-1.6.49.tar.xz/download
        
        Change-Id: I499f8a3d191421fddfe34fcf7d190f1831177de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186458
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit a32b89d2857b3f15ebb2e72c2131037a28d56270)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186461

2025-06-13  Miklos Vajna  <vmiklos@collabora.com>  [7e9275be53e419f1ed25134c93d37c8059030c8c]

        tdf#166319 sw interdependent redlines: undo of creating an ins-then-fmt redline
        
        The bugdoc has <ins>AABBCC</ins> in it, selecting BB, marking the
        selection as e.g. bold + undo resulted in <ins>AA</ins>BB<ins>CC</ins>
        instead of the original <ins>AABBCC</ins>.
        
        What happened is that the created SwUndoAttr didn't record the deleted
        insert redline, so there was no chance to restore it. The same was
        working for the insert-then-delete case via SwUndoRedlineDelete, because
        that stored the direct delete redline as an SwRedlineData, and also
        stored the underlying insert redline inside SwRedlineSaveDatas.
        
        Fix the problem by extending the types of redlines we save in
        SwUndo::FillSaveDataForFormat(), so SwUndoAttr also saves the insert
        redline in its SwRedlineSaveDatas array, then undo starts to work.
        
        Redo still needs fixing, though.
        
        Change-Id: Ic436974f15633eabcc298f062e57183220a48b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186449
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 0566e8e1776921ecb26f0ddd0546ec10afeed8e0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186456

2025-06-13  László Németh  <nemeth@numbertext.org>  [333d908450a16150bef74cc61ccdae330048746d]

        tdf#166113 sw smart justify: fix tdf160170.py regression test
        
        Improved interoperability of smart justify has been changed line breaking.
        
        Regression since commit 529755f0919217a84a12daad0fddfddd1124f0e9
        
        Change-Id: Ib496d0d7b7856bef02b5692d76bdef1c004b3d67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186446
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>
        (cherry picked from commit 938022c445545a16010951515c88d6c45f138d70)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186452
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-13  Miklos Vajna  <vmiklos@collabora.com>  [625cdb2654e36da6f2dc5941e4e4d9d692b912ec]

        tdf#166319 sw interdependent redlines: add UI to create format inside insert
        
        The bugdoc has <ins>AABBCC</ins> in it, selecting BB and pressing e.g.
        bold simply applied the formatting without creating a redline, even if
        the change is from another user.
        
        This was working for the case when a delete redline is created on top of
        an insert one, but was broken for insert-then-format: simply code was
        missing to try to handle the non-IsOwnRedline() case.
        
        Fix the problem by extracting this "split existing redline as necessary,
        then turn the overlapping range into a hierarchical redline" logic from
        sw::DocumentRedlineManager::PreAppendDeleteRedline() into a new
        PreAppendForeignRedline(), and next to the old insert-then-delete case,
        also use it for insert-then-format and delete-then-format.
        
        The new PreAppendForeignRedline() has a single part where it deals with
        moves for insert-then-delete, disable that for insert-then-format, since
        that's not relevant. Undo still needs to be fixed. Finally keep the
        logic unchanged the own delete/insert + own format redline case for now,
        we want different behavior for insert-then-delete and insert-then-format
        in this case, so intentionally not sharing that.
        
        Change-Id: Ifd2903f39d92a1bee96de0a38976eb5111c49223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186423
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit eef0dfed817e40cd83e8ba8e290f45c224257f97)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186440

2025-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [3486101e4996fed94cd3153b7fe7b5fe4b6006ee]

        Revert "Resolves tdf#163008 - Vertical tabs with small icons"
        
        This reverts commit f14064478726b8b35d45654d0162616bf01959ba.
        
        Reason for revert: Vertical tab work is going to be in master only.
        Discussed in https://lists.freedesktop.org/archives/libreoffice/2025-June/093385.html
        
        Change-Id: I779e87bc46a2e0f92d4819fd35e24099c1aa7cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186421
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [01c02f3e3affec317bf5eb2de087dbe3dc556cc1]

        Revert "Related: tdf#163008 draw the selected tab using a push button on macOS"
        
        This reverts commit 6d4512517a31baf44fe38df7ed66414684b71088.
        
        Reason for revert: Vertical tab work is going to be in master only.
        Discussed in https://lists.freedesktop.org/archives/libreoffice/2025-June/093385.html
        
        Change-Id: I10902be6d24088916c961fd866771a94ff1a6adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186422
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c01d79b8d35b252817acc6a7618b283d00fcd0ff]

        tdf#164593 Revert "tdf#82716 Add initial implementation of the His.."
        
        This reverts commit 07ae0e5ada7cb595eb4815413a5bdd442c32a6ab.
        
        This is not ready for release in 25-8, so best to just remove it
        from this branch.
        
        (cherry picked from commit 9693f1461c7d78c7461f8bbd7f421ba8c3f8452b)
        
        Change-Id: Ifd4008d62f9816d995f97104ba432ebc8be89c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186407
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-12  Jonathan Clark  <jonathan@libreoffice.org>  [c2de81072653f84dfe8ed607501719a594b7fe5b]

        tdf#166012 Implemented GUI support for style:script-type
        
        Previously, when authoring documents containing multiple languages,
        certain characters (e.g. smart quotes) could use the wrong/undesired
        font. For example, if a Chinese word is quoted inside English text, the
        right quotation mark would use the Chinese font rather than the
        intuitively-expected English font. Users had no way to control this
        behavior.
        
        With this change, Writer will now set an appropriate style:script-type
        hint when the user manually specifies a language for a selection in the
        user interface. This can be used to quickly correct instances of the
        above problem.
        
        Change-Id: I6f8c924d230e3518272e2abb1cbea5e0e7451e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186394
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 1df13d7ff133837185e6412eeefb77dadd46d056)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186405
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cfa2fe4596854cb11471751402da0632fe4c5044]

        linux_aarch64 packaging: add ld-linux-aarch64.so.1 to allow list
        
        check-elf-dynamic-objects is meant as a safeguard to prevent adding
        unexpected dependencies on the created packages, add
        ld-linux-aarch64.so.1 to the list of always allowed deps to make the
        check happy when building packages for linux/aarch64 with epm
        
        Change-Id: I924251ef468a19ba7c5b3768c522561221cba01a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186335
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        (cherry picked from commit fd0bca914c05b059b89647b6be3ead9eec8afb95)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186364
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-12  Julien Nabet  <serval2412@yahoo.fr>  [3ab79096672111238a5a1b3c63f367d58ee41f33]

        Fix invalid cast from 'GtkImage' to 'GtkLabel' in appearance.ui
        
        Change-Id: I5a5bff162bc4c0fee22f58068a833e92db485787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186383
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        (cherry picked from commit dbf4e9ac30e9a63839cbdcf7881c6509c3c5396b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186387
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-12  Miklos Vajna  <vmiklos@collabora.com>  [10196214e11427802987f9d4d0a8100a76e15e08]

        tdf#166879 RTF export: handle section break right after a section
        
        The RTF file opens fine, but saving and opening in either Writer or Word
        loses the section break between the two paragraphs.
        
        What happens is that the first paragraph is in a Writer section, and the
        second paragraph has an SwFormatPageDesc associated with it. And
        RtfExport::OutputEndNode() only emits section breaks for end nodes if
        they are the end of a table.
        
        Fix the problem by also handling the end of Writer sections, similar to
        how it already works for the DOCX export since commit
        7060c7b642fdc0a369505e430652ee44205e7eed (tdf#95367 DOCX: allow r-t of
        changed first/follow sections, 2016-10-10).
        
        The original scenario was around saving a file for the 2nd time, the
        testcase includes a subset of Writer's own RTF export result, so just
        one import + export is needed.
        
        Change-Id: I5cbb9d1ac740158f798fa43c4357c23d8037ba27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186374
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 264ed42fd66359d8d92f6ef22d9c757514ffb4a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186382

2025-06-12  Miklos Vajna  <vmiklos@collabora.com>  [6dd4791fc8a795c2970f5c042f4ded664da39690]

        tdf#166319 sw interdependent redlines: fix undo of reject of ins-then-del's del
        
        The bugdoc has <ins>AA<del>BB</del>CC</ins> in it, rejecting BB + undo
        resulted in a plain delete redline for BB instead of a delete with an
        underlying insert.
        
        What happens is that the SwUndoRedline ctor only copied the "delete"
        redline data to the undo stack instaed of both "delete" and "insert",
        because copying the "next redline data" (i.e. insert) was decided based
        on the undo action type, so didn't happen for SwUndoId::REJECT_REDLINE,
        since commit b229d16cd94d31eb8cad043b54d2d421cf92ef70 (Related:
        i#123480 correct the previous made refactoring, 2014-03-04), which is a
        bit unclear, but the point is don't copy all redline data
        unconditionally.
        
        Fix the problem by extending SwUndoRedline with an explicit flag, so
        sw::DocumentRedlineManager::RejectRedlineRange() can opt in to request a
        copy of both redline data objects. This also simplifies
        RejectRedlineRange(), because now it can again create exactly one
        SwUndoRejectRedline instance on the undo stack.
        
        This also allows removing the previous workaround where a reject action
        created an SwUndoAcceptRedline to force the copy of both redline data
        instances.
        
        Change-Id: Ieb805b52c05b0dd4eb556c720fb941f3bb394bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186368
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 612ba7b2bc5d1d12c10287094263f6d31983a3d8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186377

2025-06-12  Patrick Luby  <guibmacdev@gmail.com>  [6d4512517a31baf44fe38df7ed66414684b71088]

        Related: tdf#163008 draw the selected tab using a push button on macOS
        
        On macOS, more closely match the vertical tab style of the
        sidebar in the System Settings application. As of macOS Sequoia,
        the sidebar only shows the default style push button for the
        selected tab. The unselected tabs are only text and images so
        no native control needs to be drawn for unselected tabs.
        
        Also, remove the vertical tab's 3D border.
        
        Change-Id: I0df77b7613e37897213ce656f894f324ebf2ba14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186340
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        (cherry picked from commit b9a390c5add74147bf8ed1b9b3658e7a36c20a66)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186392
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-11  Heiko Tietze  <tietze.heiko@gmail.com>  [f14064478726b8b35d45654d0162616bf01959ba]

        Resolves tdf#163008 - Vertical tabs with small icons
        
        GtkNotebook with the property groupname == "icons" arranges
        the content for large icons above text. The patch changes
        WB_DETAILS to WB_SMALLICON and optimzes the arrangement for
        horizontal layout with icons <32px
        
        The attribute enable-popup is false to suppress Gtk3's context
        menu for the available tabs as this menu is filled via the
        first item (at least the box as first item in a tab results
        in empty label)
        
        Change-Id: Ib575ad248aac304df27a9d1c2037d847cce167ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186191
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit b787dfcc08af0ae1358c69fe4fcbd50af4f444d5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186331
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-11  Heiko Tietze  <tietze.heiko@gmail.com>  [f06781989f6bbb74eefb46440bdcafaa54294c37]

        Related tdf#164970 - Rearrange Appearance UI
        
        Follow-up to 8b681af915a3e38aaf7010eafb70a2e4a9410ec4
        Fixes some minor issues with gtk3
        
        Change-Id: I0c6addd7e14f1b6bcc698d2ba96ce1dac55c05e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186357
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit 2838db22110527e3fabcd4a4da0982d5eb26a302)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186365
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0500bee1ad75dd50c1ee5fabb282dc54a864a61d]

        tdf#166939: Fix error in commit 36c41573ec7e47bd8c2b0f78210319c96088f164
        
        The order of arguments of std::distance is the opposite.
        
        Change-Id: Ia125f071449f0bba4375204413736267cee5f57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186370
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit 1ba380bc625f6a846b80bfdf2e2678788df49447)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186375

2025-06-11  Noel Grandin  <noelgrandin@gmail.com>  [25f007984f91393dbc34adbd2bf59d8b4bae490a]

        tdf#166932 use BitmapEx in preview style cache instead of VirtualDevice
        
        which reduces the number of open GDI handles we need
        
        Change-Id: I9620d120b9ec88d972908eb713560e414384dec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186333
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        (cherry picked from commit 8899ae01feb9b9088372d76a6d0562397174c89c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186352
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-11  Noel Grandin  <noelgrandin@gmail.com>  [087b82633eaa393cbe2bad55783af3894f85425f]

        tdf#166932 no need to use GlobalAlloc in BitmapEx
        
        which consumes a GDI handle for each bitmap, and can consequently
        sometimes use up a lot of handles.
        Just use the regular malloc/free.
        
        Change-Id: I19782ac16ff195644b4feb62848c1a95acf08021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 41ce88c0dc01211e2cc319890a069d04360c76eb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186361
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-11  Oscar Megía López  <megia.oscar@gmail.com>  [a493a9c5b8b3dea76dbb1ad73dd6a2d1a7a9df3c]

        tdf#166740 On Customize/Keyboard shortcuts added
        
        I have same issue in my spanish keyboard.
        
        I added all symbol keys that I could and now
        only a few symbols aren't recognized.
        
        I tested with:
        
        $ setxkbmap jp
        $ setxkbmap us
        $ setxkbmap es
        
        and now most of symbols work.
        
        Sometimes libreoffice goes to symbol on top instead key because
        shift key is pressed and symbol is key with shift.
        
        Change-Id: I4f0f663838ab4f9ee38644b6c687f1862d2cf8dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186096
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        (cherry picked from commit ea377c8ee35ce5511baadcfc75f1994c9abc33d9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186367

2025-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [c001a84fe9bfa79b8dcf15fdcaaaf654b4c01326]

        libffi: upgrade to 3.5.1
        
        Downloaded from https://github.com/libffi/libffi/releases/download/v3.5.1/libffi-3.5.1.tar.gz
        
        Change-Id: If5f32fcf24debb512ad2d91d3ce34bdab67ae3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186356
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        (cherry picked from commit 06e6ad094ea11f1aee0cb83debf6ce58eace9325)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186372

2025-06-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6c795ed5e622c03ac1219b8042a197747a68adb1]

        distclean generated sysui/desktop/macosx/LaunchConstraint.plist
        
        ...introduced with 22ab2bec717b44e85e110cd67175c2f3599264c2 "mac: add parent
        launch-constraint to packaged framework/helpers"
        
        Change-Id: I3305be40b6166586b23cb1c5976ef920af4f0ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186327
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 6696e63b9f05e1df1308cabb71c3a2840f5411da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186353
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-06-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b6b6b7ec3f4fee4695187bd372e2d60f0ecc6469]

        SfxEnumItemInterface::GetValueCount virtual method is unneeded
        
        It is used only for one class, and the place using it knows the
        specific type.
        
        Change-Id: I2331169e4844b92e14bcb3daea9a630d608b6341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186332
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186358

2025-06-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d1c5a69cdf47ebb1af65867dc882fd99b6355496]

        Avoid float-divide-by-zero
        
        ...during CppunitTest_sw_uiwriter6
        
        > /sw/source/core/text/portxt.cxx:496:54: runtime error: division by zero
        >     #0 0x7f3faa259544 in SwTextPortion::Format_(SwTextFormatInfo&) /sw/source/core/text/portxt.cxx:496:54
        >     #1 0x7f3faa264f98 in SwTextPortion::Format(SwTextFormatInfo&) /sw/source/core/text/portxt.cxx:705:12
        >     #2 0x7f3fa9f699c2 in SwTextFormatter::BuildPortions(SwTextFormatInfo&) /sw/source/core/text/itrform2.cxx:615:27
        >     #3 0x7f3fa9f9e70a in SwTextFormatter::FormatLine(o3tl::strong_int<int, Tag_TextFrameIndex>) /sw/source/core/text/itrform2.cxx:2078:9
        >     #4 0x7f3fa9d3b4e8 in SwTextFrame::FormatLine(SwTextFormatter&, bool) /sw/source/core/text/frmform.cxx:1460:44
        >     #5 0x7f3fa9d4addd in SwTextFrame::Format_(SwTextFormatter&, SwTextFormatInfo&, bool) /sw/source/core/text/frmform.cxx:1827:23
        >     #6 0x7f3fa9d508a7 in SwTextFrame::FormatImpl(OutputDevice*, SwParaPortion*, std::__debug::vector<SwAnchoredObject*, std::allocator<SwAnchoredObject*> >&) /sw/source/core/text/frmform.cxx:2018:5
        >     #7 0x7f3fa9d5712d in SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) /sw/source/core/text/frmform.cxx:2270:17
        >     #8 0x7f3fa8dd35a4 in SwContentFrame::MakeAll(OutputDevice*) /sw/source/core/layout/calcmove.cxx:1624:17
        >     #9 0x7f3fa8da3621 in SwFrame::OptPrepareMake() /sw/source/core/layout/calcmove.cxx:420:9
        >     #10 0x7f3fa91cc5d0 in SwFrame::OptCalc() const /sw/source/core/inc/frame.hxx:1123:37
        >     #11 0x7f3fa91afa95 in SwLayAction::FormatContent_(SwContentFrame const*, SwPageFrame const*) /sw/source/core/layout/layact.cxx:1997:19
        >     #12 0x7f3fa919afba in SwLayAction::FormatContent(SwPageFrame*) /sw/source/core/layout/layact.cxx:1818:13
        >     #13 0x7f3fa917f171 in SwLayAction::InternalAction(OutputDevice*) /sw/source/core/layout/layact.cxx:622:31
        >     #14 0x7f3fa91795e7 in SwLayAction::Action(OutputDevice*) /sw/source/core/layout/layact.cxx:397:5
        >     #15 0x7f3fabd82d01 in SwViewShell::ImplEndAction(bool) /sw/source/core/view/viewsh.cxx:348:17
        >     #16 0x7f3fabd80ce1 in SwViewShell::EndAction(bool) /sw/source/core/view/viewsh.cxx:295:9
        >     #17 0x7f3fa61c1184 in SwCursorShell::EndAction(bool) /sw/source/core/crsr/crsrsh.cxx:266:18
        >     #18 0x7f3fabd80671 in SwViewShell::EndAllAction() /sw/source/core/view/viewsh.cxx:282:23
        >     #19 0x7f3fa8585747 in SwEditShell::TransliterateText(TransliterationFlags) /sw/source/core/edit/editsh.cxx:1072:5
        >     #20 0x7f3fadf22817 in SwTextShell::ExecRotateTransliteration(SfxRequest&) /sw/source/uibase/shells/textsh.cxx:901:17
        >     #21 0x7f3fadf21e64 in SfxStubSwTextShellExecRotateTransliteration(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:3235:1
        >     #22 0x7f3fcb7fe85c in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:256:9
        >     #23 0x7f3fcb814465 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:755:9
        >     #24 0x7f3fcb79a417 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1046:22
        >     #25 0x7f3fcbbfda37 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:736:53
        >     #26 0x7f3fcbc003e1 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:271:16
        >     #27 0x7f3f7bfaedc6 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:164:30
        >     #28 0x7f3f7bfadc9b in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:121:16
        >     #29 0x7f3f7bfaf674 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
        >     #30 0x7f3f9c13c6ac in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:96:33
        >     #31 0x7f3fd95dba24 in testTdf157937::TestBody() /sw/qa/extras/uiwriter/uiwriter6.cxx:685:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3587/>) after
        529755f0919217a84a12daad0fddfddd1124f0e9 "tdf#166113 sw smart justify: adjust
        algorithm for interoperability", assuming that "0" was rather meant to be "1"
        
        Change-Id: Ife289c280ca3ba9c05eea315b82ffebec8e84845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186316
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>
        (cherry picked from commit c5ea665b417551368e5048f5aaee00ad09b2065f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186323
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-11  Julien Nabet  <serval2412@yahoo.fr>  [c693475ccbe810117133023f954364a4fca39418]

        Fix invalid cast from 'GtkImage' to 'GtkLabel' in sparklinedialog.ui
        
        Change-Id: Ia5aea6ef3432a9d09ce066b1f4af299083b7d743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186307
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit c580105fcb11386aaf10abb2e653a75a37d5bdcc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186320
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-11  Jonathan Clark  <jonathan@libreoffice.org>  [b37b2ed3efb4e3fc1417ce1008fe306211868bd0]

        tdf#166011 Implemented style:script-type
        
        Implemented the ODF 1.0 style:script-type text property. This property
        can be used by documents to influence which script type-dependent
        attributes are used when rendering certain characters.
        
        This implementation uses the following semantics:
        
        - If unset, the behavior is as it was in previous versions.
        - If set to latin, asian, or complex, those characters not mapped by the
          ODF standard to a script type are treated as latin, asian, or complex,
          respectively.
        - If set to ignore, all characters will be treated as latin. This value
          is intended to be used for interoperability with file formats that
          don't implement script types (e.g. HTML).
        
        Change-Id: If81a1390ee455fd971dea655d161d9c3f44fd08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186309
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        (cherry picked from commit 0b979c50b6fa72bae4344130e48f5503ac14a9c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186312
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-11  Mike Kaganski  <mike.kaganski@collabora.com>  [36c41573ec7e47bd8c2b0f78210319c96088f164]

        tdf#166939: Don't pass invalid starting index when creating a view
        
        A style name can be as short as one character; a two-character prefix
        can already be too long.
        
        Change-Id: I041894d8c68942a49aef399edaccbcd48522ae83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186328
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        (cherry picked from commit faab5ca6174e3e581661784216410e2bc88da081)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186343

2025-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [e0331f8f3698c95120d4db571b00e03a4cbd8fd6]

        tdf#123384: Add support for MOD formula
        
        Change-Id: I86d30d688b44f537bd42a4018f4ff4cbaa8b4d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186325
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        (cherry picked from commit 389325166a3357d7a4e557dc4c223fe0bb7aeadd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186329

2025-06-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [44d66d4ddb507cca76b71dbd25ca1ae323b866d0]

        Missing include (for SHRT_MIN/MAX)
        
        Change-Id: I1755b440515724315aa2e540fe3de4a473371dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186304
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 19c32b44fead600118377417012b111a4f238766)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186315
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d580a05e32cca7a51513c920cd86b6d5b310b52c]

        Missing include (for USHRT_MAX)
        
        Change-Id: I9d2a59fd198679c2a7a7ce124e2548f2add61d6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 6ebc3c540f2aa13363e3dcb32a44bfa2c7f66a9f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186313
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [047b8074d9f9edb2e9f3058b4380ca024b5713f8]

        Missing include (for LONG_MAX)
        
        Change-Id: I8f03310ab1b5da503670f77bf9c5211e956dd48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186305
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 0084c2b22ce26084df5a379135ba8ac174585ac0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186314
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [22ada6ad068393aec432ec51628a89bb5c36a83e]

        UITest_writer_tests8: use wait_until_property_is_updated in test_tdf145158
        
        According to https://bugs.documentfoundation.org/show_bug.cgi?id=145158#c20
        the issue is still reproducible after
        commit eb000710c54fcd6d00735bc74b0ffcc0f54c70e0
        Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Date:   Sun Jun 8 21:01:47 2025 +0200
        
            workaround timing issue in UITest_writer_tests8 test_tdf145158
        
        Change-Id: If771cd1ab795b7ea6690ddd8f41c9d98bd13ce50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186301
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: René Engelhard <rene@debian.org>
        (cherry picked from commit 7442c8463faea5a78af32972bc7283bb44eff78f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186311

2025-06-10  László Németh  <nemeth@numbertext.org>  [edb1e8f1a0fca2489b722877917283f616e3acd9]

        tdf#166113 sw smart justify: adjust algorithm for interoperability
        
        Skip space shrinking, if space expansion is closer (with a
        weight) to the desired (100%) word space.
        
        Import DOCX documents with 75% minimum word spacing,
        100% desired word spacing and 133% maximum word spacing.
        
        These changes cover MSO smart justify algorithm. Hyphenation and
        text portions may need future adjustments.
        
        Modify unit tests according to the changes:
        
        – testTdf126154, testTdf126154_minimum_shrinking,
          testTdf126154_portion: choose maximum word spacing, i.e.
          expansion instead of shrinking, according to the weighted
          distance from the desired word space;
        
        – testTdf163720: set desired word spacing to the minimum
          word spacing in the test document to get back the original
          regression test.
        
        Note: the previous algorithm for disabled hyphenation within
        the minimum and maximum word spacing range is replaced
        by optimization for the desired word spacing (temporarily).
        Interoperability analysis and custom more/less hyphenation
        can change this.
        
        Change-Id: Iec0582a497945743f97686743af5ff6609866abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186138
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        (cherry picked from commit 529755f0919217a84a12daad0fddfddd1124f0e9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186308
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [350555b5be0f4ac906ab3c330ec7312298831d22]

        fixup "cleanup msvcdll stuff"
        
        there were unstaged changes that should have been part of
        d39842d01b63143a4832be0e01a8b3c216afa9e7
        
        Change-Id: I80faa7e1a0c0572d8b96adbebe846a980e929fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186296
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [9e6a186e8d50e06c45573f3c11c6dcd9d47efa0a]

        Return Any(sal_uInt16) from CntUInt16Item::QueryValue
        
        At some point, obviously, it was changed to return a sal_Int32; at least,
        commit 8aa0b22b69a0051277c123bbec7ca20ee5a23063 (#99054# correct UINT16
        items to sal_Int16, 2002-05-06) mentioned that in a comment. But I could
        not find the actual change implementing that; the current code was like
        this since commit 70fd6a409ebdfce6c6c234e0e8d09b98176a1379 (INTEGRATION:
        CWS visibility03 (1.1.2); FILE ADDED, 2005-04-13).
        
        I don't see a reason to do this. Any(sal_uInt16) can extract its value
        into sal_Int32.
        
        This revealed a couple of properties, that used inconsistent underlying
        types, which was masked previously by the automatic conversion; now this
        change normalizes these.
        
        CntUInt16Item::PutValue continues to accept sal_Int32, because there may
        be users relying on that. ScModelTestBase::insertNewSheet was an example
        of that.
        
        Change-Id: Iebbcd197f6e20bb373b38dd6a47a072b8cd0ca11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186256
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit b2204eb7ed35c14dffc51e53391b3e505b5efd06)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186294
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8155816fbc40c9b67a326f6bc417f328969bc8f4]

        bump product version to 25.8.0.0.beta1+
        
        Change-Id: Ic17276be270d78b18f076e48643b6763187e6820

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c21e803568f30283d48ebe620579e2b2fb93d86e]

        Branch libreoffice-25-8
        
        This is 'libreoffice-25-8' - the stable branch for the 25.8.x releases.
        The commit rules are different according to the development phase:
        
        A. 25.8.0 beta phase:
        
           A. any bug fixes are allowed without review
           B. late features need approval by 3 people with different affiliation
        
        B. 25.8.0 rc phase and later:
        
           A. fixes need approval by one reviewer
           B. late features need approval by 3 more people with different affiliation
        
        IMPORTANT: Every developer is responsible for pushing the fixes into all
                  appropriate branches. Note that we do not plan any merge
                  from this branch to master or vice versa.
        
        Please, help use to make stable and usable release. If you want to build
        something cool, unstable, and risky, use master.

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [85fe6ee7440d871214cbd894e90f934e3ba6f208]

        Update git submodules
        
        * Update translations from branch 'master'
          to f6e8f362f25b746a3a07c12ab9901e84d0c4ba49
          - update translations for master/25.8.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I31dd46c96e41067f44b78a2bf52354a67385d0c7
            
2025-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [0daa3aa3400eabdb39bde43575358491e4cca5f0]

        libffi: upgrade to 3.5.0
        
        Downloaded from https://github.com/libffi/libffi/releases/download/v3.5.0/libffi-3.5.0.tar.gz
        
        Change-Id: Idf49997af9ec99b55fb4b09d71572d284be0ad73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186282
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [c5bdbaf6586e38fda377885d69f3fb980ef1f420]

        SvxEscapementItem does not need to be an SfxEnumItemInterface
        
        Change-Id: Ie194e42c4f4eef22df6cd290cf9ed2d228e2006a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186278
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bb26aa320fd8230f4105e8872b81612425400cc1]

        add Java-WebSocket to deps to the ridljar/libreoffice pom
        
        The dependency was introduced in
        8e246331f6f71320cfcc8defdd04e756a75f71cf but never was added to the
        maven pom
        
        Change-Id: Id12036c82ecf803a817054a618316a95a4c738ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181240
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [deae13d5a2ac2c6c29d1a97a606fecb495445289]

        make buck/javadoc happy on JDK 17
        
        previous versions just did print a warning, just like for other javadoc
        issues, but current versions of javadoc cause a hard failure
        
        Change-Id: Ib880128f75f44fab5f7570eb68ae32639453504a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181239
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [51c3e53796c9bbeae86bbb80e5b5c623f78d8394]

        Revert "checkExternalLibraries: check current libxml2 branch"
        
        This reverts commit 3874e6ef7d4e5fdb76e446ba1ba524a51572791f.
        
        it's not clear when libxml2 branches reach the end of life,
        so better to track the newest branches
        
        Change-Id: I41ec3fb2aedba6705cabcc924702ae83de428070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186279
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [260f1ab1483cf3269099b2e63652b8066025e1b5]

        libjpeg-turbo: upgrade to 3.1.1
        
        Downloaded from https://github.com/libjpeg-turbo/libjpeg-turbo/archive/refs/tags/3.1.1.tar.gz
        
        Change-Id: I3f49ed841a52cb227182c7f2bb2f150369a27d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186284
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [98a6324e64b4baab803f7bec197579127305fd46]

        SvxAdjustItem does not need to be an SfxEnumItemInterface
        
        Change-Id: I2913dfa62dc8515925c384f753583ecd6d55ca78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186277
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [eb000710c54fcd6d00735bc74b0ffcc0f54c70e0]

        workaround timing issue in UITest_writer_tests8 test_tdf145158
        
        related to tdf#145158 - the test can fail on slow or loaded machines
        since initially the control has the 2pt value, so when the test tries to
        check whether the size is 12pt, it might do so too early and the test
        will fail:
        
        ======================================================================
        FAIL: test_tdf145158 (tdf145158.tdf145158.test_tdf145158)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/sw/qa/uitest/writer_tests8/tdf145158.py", line 28, in test_tdf145158
            self.assertEqual("12 pt", get_state_as_dict(xFontsize)['Text'])
        AssertionError: '12 pt' != '2 pt'
        - 12 pt
        ? -
        + 2 pt
        
        ----------------------------------------------------------------------
        Ran 28 tests in 33.743s
        
        FAILED (failures=1, skipped=4)
        Tests run: 28
        Tests failed: 1
        Tests errors: 0
        Tests skipped: 4
        tearDown: calling terminate()...
        ...done
        
        Adding the waitUntilAllIdlesDispatched() call avoids this problem
        
        Change-Id: Ibb2aec7dfdab887ca75841e99d879402a020de3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186268
        Tested-by: Jenkins
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7e4f25966760d1e615d137254227097569eca342]

        linux aarch64: use -fsigned-char
        
        pretty much considering it a workaround, better fix would be to use
        explicit signed/unsigned variants, but this is what macOS/iOS also use
        already/what the code apparently expects.
        
        There doesn't seem to be a major issue, at least none covered by a make
        check, but there's at least one WaE issue in oox:
        oox/source/vml/vmlinputstream.cxx:45:18: error: result of comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-unsigned-zero-compare]
            return cChar >= 0 && cChar <= 32;
                   ~~~~~ ^  ~
        1 error generated.
        
        (hit by default with --enable-werror when using gcc (comparison is
        always true due to limited range of data type [-Werror=type-limits]),
        with clang you have to add -Wtautological-unsigned-zero-compare)
        
        Change-Id: Ib143b446bc842032e98c3d51d973bc0cd3bfcf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186271
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [feb5d010a69c8922574cb8b673f4c147a9bc0bd0]

        libxml2: replace deprecated lastError with xmlCtxtGetLastError
        
        Follow-up to
        commit e3b5e3aebcf178ccfbba3f7510062d5f2c5abb4a
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Wed Apr 23 13:38:50 2025 +0200
        
            libxml2: upgrade to 2.14.3
        
        Change-Id: I10acc368d9a0dd6db2f6569b2f174583d91dcf35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186285
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [67169626f18c0d0d83834cb7fe50f203f8c6b5ea]

        Simplify a bit, reusing existing more generic methods
        
        Change-Id: I052ae1fbcce3f2795faabd15d23b7f50dfa6e6f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186273
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ff055c9e1eb52a3f39938439fe5dcffa2ef455b5]

        SvxLineSpacingItem does not need to be an SfxEnumItemInterface
        
        Change-Id: Ic7c483b3ed4664a96da63cfdcd04d30cb87d50cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186276
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [49897bc7db53def96516d4d8629c6ad4c25618b1]

        SvxShadowItem does not need to be an SfxEnumItemInterface
        
        Change-Id: I3c946c526f07df8407b8e0e17c77eed17e55619d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186275
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [1fe5e87e77423196de337a7e91a2cb089b2eeaa2]

        Simplify a templatized function
        
        Change-Id: Ie10b1d4ec99962f4afd890cc3896013f0ded7599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186274
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b852ed9fc8b43cdc335c14aeb71c581daa7d98a7]

        Update git submodules
        
        * Update translations from branch 'master'
          to bcc22502dba9a187743e6e2c674e21e3249f45e6
          - update translations for master/25.8
            
            and force-fix errors using pocheck
            
            Change-Id: I2f6fc3ee474d84d13b39ad1b77d6024f00b0ebb8
            
2025-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b50b8c227a014c2f5590be6ff1a8e9d7594d2382]

        cid#1648524 silence Data race condition
        
        Change-Id: I7a1df9310558c0edc6fe783d0cd2969b7bfcd477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186264
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73ff549a3bdb7607fafa13013383f1b2997731bc]

        cid#1648523 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie74cec664345f9d7a5b2007127f95e96d640d1b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e9e4476e31fce3a9a1d8f55f5dba392950c6a0c9]

        cid#1648521 Logically dead code
        
        Change-Id: I5b9b8ef580047d05995061c2cc91a8ed9ae3a12b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186265
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [61d5f389a34eaa05c0cfef4d6ca820e0d21eb574]

        cid#1648517 Use of auto that causes a copy
        
        Change-Id: I73b3c32eb595589ea746be6cbcb818b4b6b3d4bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae274c8784c173856e70568c8b72db80a0de7e97]

        cid#1648516 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idc5ca5f0993087b7b860c561a120973db07b62f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186262
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [76a2cb7385f578c1596b3228d016647f00723721]

        Report property name for in the warning, for easier debugging
        
        Change-Id: I3863475f46bac78ebc85792bd47cd23906f39784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186259
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8976d3b4fbbedefa3be53b81688417f01369ac68]

        Reduce SAL_WARN noise for FillBitmapURL
        
        See commit 3341986547b69bcb4c38e4ccb2f0853a3a569bb5 (tdf#93998 toolkit:
        restore support for setting dialog background from shape, 2019-08-26),
        which restored getting value for URL properties, passing XBitmap there.
        
        Change-Id: Idd8f939f441c7245fc9c4bc457d268b8778b1256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186258
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [4189b4ebda4a0d2f45cf8e266f7c7be67b770929]

        Reduce SAL_WARN noise for void results
        
        Seen when loading a document as:
        
          warn:svx:8840:27520:svx/source/unodraw/unoshape.cxx:1870: SvxShape::GetAnyForItem() Return value has wrong Type, com.sun.star.beans.Pair<double,short> != void
        
        for e.g. ParaLeftMarginUnit.
        
        Change-Id: I03ea968aaf8a5e9a0a622a3e505398ab267d0889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186257
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [3226e5d4084dab74db3514e541af080ed10da784]

        Reduce noise for "duplicating" type ids
        
        Type ids may legitimately repeat, so no need to warn when the types
        are actually the same. I assume, that for actual error (e.g., shape
        ids duplicating), the objects will be different.
        
        Change-Id: I96bffeda584e80e81b9ef856cd438f2213d0e824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186260
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [0afee23ca1c1695b9c5cc717fbe6a92a90afa2cd]

        Downgrade a SAL_WARN to SAL_INFO
        
        This is a normal case; only selected ProgIds are handled by design.
        Others are used as is.
        
        Reduces noise like
        
          warn:writerfilter:25912:24788:sw/source/writerfilter/dmapper/OLEHandler.cxx:262: OLEHandler::getCLSID: unhandled m_sProgId: Acrobat.Document.DC
        
        Change-Id: I946e2281e5dae132429dfa839d1bda94d893063b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186255
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [fc504b2c81d9fa920706f4be880594194ab6cd2c]

        Reduce some SAL_WARN noise
        
        Seen this while loading a document:
          warn:svx:25912:24788:svx/source/unodraw/unoshape.cxx:1868: SvxShape::GetAnyForItem() Return value has wrong Type, com.sun.star.awt.Gradient != com.sun.star.awt.Gradient2
        
        Change-Id: I408db273244cec5412132ed7e2830ceffab8dd28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186254
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-08  Julien Nabet  <serval2412@yahoo.fr>  [95a7da99d8001403d55f5e96ea752fa4d8ad5566]

        cid#1648515: copy-paste error
        
        Change-Id: I26de8aed7ea40aa620cecac40d6b81d53f9cc08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186252
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-06-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fef47a8bcc8531e69ccea29f2db5929741e66a3e]

        tdf#146619 Remove unused headers from include/vcl/accessibility
        
        after recent refactorings
        
        Change-Id: Ia38fd586b31e9e58ee4977a3ed79de3a6b004fba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186072
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8b5a83f3ab4eb883cb57c4929f32a4151f07308c]

        tdf#146619 Remove unused headers from vcl/inc/accessibility
        
        and vcl/source/accessibility/ after recent refactoring work
        
        Change-Id: I0d519fc0c62e67f75c776184dec0b5221685ccf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186071
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [9727cf785945218a4f06562f4edb657551d25436]

        tdf#166862: fix reading data for CRC calculation
        
        Commit a6ad198d097fb4a503c8d5831d484ff46721134b made the size read
        from the grabber wrong for the last chunk: it wasn't decreased to
        the remaining size, but was still equal to nBlockSize. The grabber
        could read past the chunk, and the CRC was wrong. No idea why did
        that only hit this file - it seemed that any file larger than 32K
        and that was stored (i.e., any image) would trigger that path?
        
        Change-Id: I980dd701e54c4ed565173b5b90ed301bf9b5f719
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186241
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [2143c0a6949ee80c34ec6a8e2028fea2930dd947]

        Simplify getter/setter implementations
        
        For numeric types, they are made unified templates. In many cases,
        gotos were dropped, and the code was streamlined. Hopefully, this
        would make it at least a bit manageable.
        
        Change-Id: I63154d61fa6629d1431157ac382ec758f4f50074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186234
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [2f16890dafd2d5d90f5211c1f24c062dbc997851]

        Rename mxCkbAsOnce -> mxCkbMergeDelimiters for clarity
        
        Change-Id: I55d62211191c05094c9ebcb2caf50e8760dfdf17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [e0c00dc296a3c11f727c6c8b2724278b96085f4c]

        Document that an enum values are stored in config
        
        Change-Id: Ia97f5cbf90ba50f37d1e28e169916b25524f4ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186237
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [d16535788721238a423408ba59805f4bcacc4e12]

        [API CHANGE] tdf#166208: New "Encoding" property for text import / clipboard paste
        
        The problem appeared, because the existing CharSet property was storing
        the index of the selection in the encoding list box; and that meant, that
        any change in the list box content (different sorting; added elements)
        could suddenly make the selection wrong the next time. With introduction
        of the autodetection entry into the top of the list box in tdf#152336 (in
        commit 565b619d57a3b98b0826c4b49dee6606f9ae70e0), many people who had
        UTF-8 selected in the dialog previously, got UTF-7 instead; and many had
        not noticed the difference, thus seeing unexpected results after import.
        
        The said commit intended to force-select autodetection for the users who
        had not used the updated dialog yet; but the detection of that scenario
        was flawed, and didn't work (that was discussed, and respective code was
        dropped in commit ...).
        
        This change implements that idea. I decided to ignore the stored CharSet
        value; after the change, autodetection entry will be pre-selected at the
        first start of the dialog. This will be a minor annoyance for users who
        have already re-selected wanted encoding after previous upgrade; but it
        allows to resolve the bug for people upgrading from versions prior to
        25.2. Also, since new versions will not write to CharSet, it's possible
        to use a shared profile between old and new versions without breaking
        the encoding selection in either.
        
        Change-Id: I59640b16f703077b6fda44a34eadf2edbe8e6bf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186240
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [58dc72c6f29a3ad4cbea09803d6c568b96f80c08]

        Related: tdf#166208 Drop bBeforeDetection
        
        It was intended to detect the first use of the text import dialog
        after introduction of the automatic encoding detection feature.
        But since the schema for SeparatorType property, which was used
        for the detection, defined it as non-nillable, the property has
        a value always, so the detection is impossible. It means that the
        detection code may be removed.
        
        The detection, if it worked, would prevent tdf#166208; it would
        select automatic encoding detection, and prevent the shift of the
        old selection by one.
        
        Change-Id: I1ba661476531987633e0ed0a100bf798aa01a9f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186239
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [e8027d47d516e74b0631d99c584bc7bb301a3efb]

        Related: tdf#166208 Avoid C-style array and fixed index madness
        
        Here we deal with conditional length and set of elements in the two
        sequences (names, values).  This required a complex logic to handle
        them; and all the changes required accurate synchronization both in
        the code, and with the schema.  An example of a confusion from this
        is commit 19f3b72f34c487dc97d582712d21734a7e055fd5, which increased
        the size of the sequence returned from lcl_CreatePropertiesNames.
        
        Instead, use ConfigItem::GetNodeNames to get the defined names from
        schema.  This unifies the code for all eCall cases, by only reading
        and writing those values that exist in the respective config node's
        schema.
        
        Change-Id: I90fdaa603bb12dc554a4c2947dd7f3415af31f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b6bcc7ac278e0db22df02707789730ec123bf934]

        tdf#166871: drop mnMaxParaPerPage hack
        
        It was there since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62
        (initial import, 2000-09-18); and its idea was to use some heuristics
        to predict the likely number of pages (when there was no metadata, to
        use that number for progress indicator), and, most importantly, to
        predict the page breaks (where a paragraph must be moved to the next
        page, just because there are many paragraphs on this page already; it
        likely was considered an optimization).
        
        But that hack, in fact, creates page breaks in random places, and
        then requires moving stuff back; in some cases, the resulting layout
        was instable, and layout loop control triggered. And that broke the
        most straightforward way of arranging pages, from start to end.
        
        This change removes that hack. The speedup that the hack could
        potentially provide would be negligible, if at all; and the damage
        is real.
        
        I don't know if the following part of documentation comment for the
        constructor of SwLayHelper is still relevant after this change:
        
         "If there's no layout cache, the distribution to the pages is more
          a guess, but a guess with statistical background."
        
        testObjectCrossReference needed a fields update, for unclear reason.
        
        SwTabFrame::Split needed to be improvedto fix failing TestTdf150606,
        where a zero-height column body tried to layout its table; in this
        case, in SwTabFrame::Split pRow was pointing to Lower(), nRowCount
        was 0, nRepeat was 0, and bSplitRowAllowed was false -> it chose
        "bKeepNextRow" path, moved pRow to its next, split it, and a wrong
        single-cell table appeared on page 3. This seems to pre-exist, and
        only happened to be manifested in a test by the change.
        
        Change-Id: I2d203055e67b0155bcd719efb1f8a8b6a82b1156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186243
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [af8c52479064a72623f2d8eb9f479b741a2c735c]

        tdf#166875: Don't notify broadcaster from its disposing notification
        
        An assert failed in debugging, when closing print preview in Writer:
        
          ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 443
          comphelper.dll!`anonymous namespace'::implLookupClient(const unsigned long nClient, std::_List_iterator<std::_List_val<std::_List_simple_types<std::pair<unsigned long const ,comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>>>>> & rPos) Line 140
          comphelper.dll!comphelper::AccessibleEventNotifier::removeEventListener(const unsigned long _nClient, const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> & _rxListener) Line 229
          swlo.dll!SwAccessibleContext::removeAccessibleEventListener(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> & xListener) Line 746
          winaccessibility.dll!AccEventListener::RemoveMeFromBroadcaster(bool isNotifyDestroy) Line 262
          winaccessibility.dll!AccEventListener::disposing(const com::sun::star::lang::EventObject & __formal) Line 287
          comphelper.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear(std::unique_lock<std::mutex> & rGuard, const com::sun::star::lang::EventObject & rEvt) Line 492
          comphelper.dll!comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(const unsigned long _nClient, const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & _rxEventSource) Line 204
          swlo.dll!SwAccessibleContext::Dispose(bool bRecursive, bool bCanSkipInvisible) Line 1050
          swlo.dll!SwAccessibleMap::~SwAccessibleMap() Line 1571
          swlo.dll!SwAccessibleMap::`scalar deleting destructor'(unsigned int)
          swlo.dll!std::_Destroy_in_place<SwAccessibleMap>(SwAccessibleMap & _Obj) Line 324
          swlo.dll!std::_Ref_count_obj2<SwAccessibleMap>::_Destroy() Line 2118
          swlo.dll!std::_Ref_count_base::_Decref() Line 1161
          swlo.dll!std::_Ptr_base<SwAccessibleMap>::_Decref() Line 1385
          swlo.dll!std::shared_ptr<SwAccessibleMap>::~shared_ptr<SwAccessibleMap>() Line 1690
          swlo.dll!std::shared_ptr<SwAccessibleMap>::reset() Line 1737
          swlo.dll!SwViewShellImp::~SwViewShellImp() Line 108
          swlo.dll!SwViewShellImp::`scalar deleting destructor'(unsigned int)
          swlo.dll!std::default_delete<SwViewShellImp>::operator()(SwViewShellImp * _Ptr) Line 3309
          swlo.dll!std::unique_ptr<SwViewShellImp,std::default_delete<SwViewShellImp>>::reset(SwViewShellImp * _Ptr) Line 3471
          swlo.dll!SwViewShell::~SwViewShell() Line 324
          swlo.dll!SwViewShell::`scalar deleting destructor'(unsigned int)
          swlo.dll!SwPagePreview::~SwPagePreview() Line 1235
          swlo.dll!SwPagePreview::`vector deleting destructor'(unsigned int)
          sfxlo.dll!SfxViewFrame::SwitchToViewShell_Impl(unsigned short nViewIdOrNo, bool bIsIndex) Line 2690
        
        SwAccessibleContext::Dispose called revokeClientNotifyDisposing,
        which removed the SwAccessibleContext's id from its map, and then
        called disposing() for all listenera of the SwAccessibleContext.
        
        When one of the listeners, in its disposing(), tried to call
        broadcaster's removeAccessibleEventListener, this violated the
        API: XEventListener::disposing documentation directly prohibits
        calling any methods of the broadcaster.
        
        This was obviously a confusion, already present in commit
        a18bdb3bc05e761704cc345a66a9d642bc4f4a0a (Integrate branch of
        IAccessible2, 2013-11-19), where the semantics of disposing()
        was thought as "the listener is disposing", when in fact, it's
        broadcaster notification about broadcaster's disposal.
        
        Change-Id: Ib7f79b2214ffeedec6b4a4c75813e4ffa2d43270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186242
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [d98dafcde1e136d30419bc7624d42e5edbd6a95c]

        Drop an exclusion that seems obsolete
        
        During a debug session, I saw these warnings appearing all the time:
        
        > <SwFlowFrame::MovedBwd(..)> - incorrect next found.
        
        It turned out, that the code emitting them found tables, which were
        not in OSL_ENSURE's condition. It didnэt warn about tables prior to
        commit 960ef1a29fe441360f6b9536f4239656566f06cf (INTEGRATION: CWS
        swqbugfixes11 (1.43.40); FILE MERGED, 2005-01-05); the said commit
        added a condition to enter the search loop and eventual "is locked"
        check, which excluded the case when the initially found frame was
        a table. But it didn't handle the case of a table found in the loop.
        
        Adding such a check looks unreasonable now, when the code didn't
        need better filtering of tables in all these years. Before adding
        the table back to the condition of OSL_ENSURE (to silence the wrong
        warning), I checked if the whole change is indeed still needed. It
        turns out, that reverting the change completely does not break the
        bugdoc in i#38232, nor any unit tests. So it looks like this may be
        reverted as obsolete.
        
        Unfortunately, the bugdoc uses fonts that are unavailable in unit
        tests, and it's impossible to re-create the bug to prepare another
        test document, so no unit test.
        
        Change-Id: I3d451dd6ebd0d54fbef2f16c1406f7c2693e7cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186235
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [516257d52f2b7af136ca972dc42dfd75779d2be6]

        Simplify a bit
        
        Change-Id: I62306fe572717c807b68b8329e9c5b04c9935583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186158
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e24aa1d0f692cb6d64c00353356b0731e9afbadc]

        Resolves: tdf#146256 Base toolbar customization page displays wrong scope
        
        Customization for Base "Standard" toolbar is stored in document when
        the scope of "Base" appears to be selected in the UI.
        
        A regression from:
        
        commit ccb2b0078f07194befa61f1e3fd88e53ff236871
        CommitDate: Mon Mar 11 10:00:31 2019 +0100
        
            weld SvxMenuConfigPage/SvxToolbarConfigPage
        
        Change-Id: I18966e34ccd79c6eecb6e1b4c216caaef453f501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186231
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c1cca4609fed192c3b309c2955b82c2c236b088f]

        Related: tdf#146256 select base's "standard" toolbar by default
        
        in the customize dialog. The other modules select "standard" by default,
        but base's "standard" toolbar has a different resource url than the
        others.
        
        Change-Id: I0f53691f83bcaf78a681a2862c595f61fdfb16dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186230
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [75c371606d5aad23fab316ec74eedb59da7c29ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e6f7c59b2bf1d9717f46f204f45896a820a98d4e
          - tdf#154055 Review Writer Send menu commands Help
            
            Change-Id: I5592da98051e8acdf2b7d9364ea911c84a96fc85
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186229
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-06-06  Noel Grandin  <noelgrandin@gmail.com>  [78e89dd2169d04dad719b955951de85e01dd7668]

        tdf#166842 Use more OutputDevice::Push/Pop
        
        Which is more reliable when dealing with "no fill color".
        
        Change-Id: I88ee41a84416d55257e9649a1de9458b3cb6839d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186227
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-06-06  Noel Grandin  <noelgrandin@gmail.com>  [d55084f1021e48d5c2e4668e50bbc7410025225f]

        fix some lint-ui warning: adjustment used more than once
        
        Change-Id: I83d8f32489b1602af3a040ec4126ab72af8f87f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186188
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-06-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [e3b5e3aebcf178ccfbba3f7510062d5f2c5abb4a]

        libxml2: upgrade to 2.14.3
        
        * In https://gitlab.gnome.org/GNOME/libxml2/-/commit/712a31abe458eed75f0e2a442b35af58cf7091ca
        some members used by Libreoffice were marked as deprecated.
        Add deprecated.patch.0 to undeprecate them for now.
        Meanwhile
        https://gitlab.gnome.org/GNOME/libxml2/-/issues/936#note_2461334 has been
        opened to discuss it. The necessary code changes
        will be addressed in a follow-up commit
        
        * In https://gitlab.gnome.org/GNOME/libxml2/-/commit/bfe6af2eed38564693b35ac5aa60178068f34fbb
        main() was moved from xmllint.c to lintmain.c.
        Add makefile.msvc-entry-point.patch.0 to address that
        
        * 0001-parser-Fix-custom-SAX-parsers-without-cdataBlock-han.patch.1
        fixes https://gitlab.gnome.org/GNOME/libxml2/-/issues/934
        
        * Since https://gitlab.gnome.org/GNOME/libxml2/-/commit/f070acc56400410a3ad27f4df313526749364962
        android builds in Jenkins fail with "configure: error: libiconv not
        found"
        Run configure with --without-iconv. Same as in Windows
        
        * Adapt testLeadingTabHTML since The HTML parser normalizes newlines
        according to HTML5 now
        See https://gitlab.gnome.org/GNOME/libxml2/-/issues/938#note_2463720
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.14/libxml2-2.14.3.tar.xz
        
        Change-Id: Ie010c236f5dad5156f7f4204033d0c02928742ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184501
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-06  Michael Weghorn  <m.weghorn@posteo.de>  [ddf4ac2d77357154f1983b7338228c7fc0477bdf]

        android: Update Android Gradle Plugin to 8.10.1
        
        ... and gradle to 8.11.1, as suggested by Android Studio.
        
        Change-Id: Id6560eccfe321339dec43c8fdbca11739c2daec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186226
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-06  Noel Grandin  <noelgrandin@gmail.com>  [a485acb4508fbafbf64bba5f77f7d0f3f8372de1]

        convert script to python3
        
        Change-Id: I64ada5a5272fb197eaa95320c482aae55594ffe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186187
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-06-06  Heiko Tietze  <tietze.heiko@gmail.com>  [8b681af915a3e38aaf7010eafb70a2e4a9410ec4]

        Related tdf#164970 - Rearrange Appearance UI
        
        * More adequate control sizes
        * Positioning improved for design
        * Some redundant strings removed to make the dropdown smaller
        * Customization and icon size hidden in case of Welcome/WhatsNew
          per HideAdvancedControls flag
        
        Change-Id: I82b35b227d4a2d16205de689c8be69f42c117a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186224
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-06-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [777ff280670ddbeb4e68bdd2ef4a684e35a5fd66]

        sd: better way to check if a font is used for PPTX font embedding
        
        Check all the objects and style that is accosiated with the object
        if the font is used. This way we don't include fonts that are not
        actually used in the document. The isUsed on the document is not
        percise enough in this case.
        
        Change-Id: If11d80ffe04b28688698babb560ac0be84bbed12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185764
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit e888a6d9eb2af220a9c8c0a3483e37d1f53f628f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186223
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-06-06  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [ce0f1bee0596bdcf314b3c2ccd8b3ebdefc70557]

        tdf#164970 remove redundent wrapper functions over AppColorMode.
        
        these were relevant before themes rework when the document appearance
        and the application appearance were separate from each other. now they
        are interconnected, if the application is in dark mode, the document
        colors also change to dark, unless explicitly disabled in
        `Tools > Options > Appearance > Use white document background`.
        
        Change-Id: I928411f1acece1f375641119e8090f8d0389076b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186214
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [461b4743e4df1d178d07b67e87118ec25c86a1ff]

        Removed executable permission on file
        
        Change-Id: Ib838a52e787b28e4f4da04f8824dac9e5cc90ce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186213
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f15466274453fa48609de45c32fbcf7c0a6cf46e]

        Remove executable bits
        
        Change-Id: Ib57d2a618a6f32bf5a7c871d6d1b440dee1356fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186211
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb2752511efa64478c17ea525b8e19584b5dd253]

        Fix typo
        
        Change-Id: I408079a0300780ea9f4cb3819eee0dc973c428f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186220
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b926ef35afb8b4c6372723a4ae407025750ee6f2]

        null deref of empty AlphaMask
        
         (gdb) print mpReadTransparence.moAccess._M_payload._M_payload._M_value.mpBuffer
         $18 = (BitmapBuffer *) 0x0
        
         #0  BitmapReadAccess::GetScanline (this=<optimized out>, nY=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/optional:484
         #1  BitmapReadAccess::GetPixel (nX=<optimized out>, nY=<optimized out>, this=<optimized out>) at include/vcl/BitmapReadAccess.hxx:83
         #2  drawinglayer::texture::GeoTexSvxBitmapEx::impGetAlpha (this=this@entry=0x3a073610, rX=rX@entry=60, rY=rY@entry=420)
             at drawinglayer/source/texture/texture3d.cxx:111
         #3  0x00007f4cc4baba0e in drawinglayer::texture::GeoTexSvxBitmapEx::impGetAlpha (rY=420, rX=<optimized out>, this=0x3a073610)
             at drawinglayer/source/texture/texture3d.cxx:152
         #4  drawinglayer::texture::GeoTexSvxBitmapEx::modifyBColor (this=0x3a073610, rUV=..., rBColor=..., rfOpacity=@0x7f4cabbba638: 1)
             at drawinglayer/source/texture/texture3d.cxx:152
         #5  0x00007f4cc4ba9a31 in ZBufferRasterConverter3D::decideColorAndOpacity (this=this@entry=0x39db6260, rColor=...)
             at drawinglayer/source/processor3d/zbufferprocessor3d.cxx:119
         #6  0x00007f4cc4ba4d9c in ZBufferRasterConverter3D::processLineSpan (this=0x39db6260, rA=..., rB=..., nLine=<optimized out>, nSpanCount=<optimized out>)
             at drawinglayer/source/processor3d/zbufferprocessor3d.cxx:305
         #7  0x00007f4cc438d5f6 in basegfx::RasterConverter3D::rasterconvertB3DArea(int, int) ()
             at basegfx/source/raster/rasterconvert3d.cxx:129
         #8  0x00007f4cc4ba0ac7 in drawinglayer::processor3d::DefaultProcessor3D::impRenderPolyPolygonMaterialPrimitive3D(drawinglayer::primitive3d::PolyPolygonMaterialPrimitive3D const&) const ()
             at drawinglayer/source/processor3d/defaultprocessor3d.cxx:448
         #9  0x00007f4cc4b9fcc9 in drawinglayer::processor3d::BaseProcessor3D::process (this=this@entry=0x39da04c0, rSource=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_deque.h:263
         #10 0x00007f4cc4ba1ca0 in drawinglayer::processor3d::DefaultProcessor3D::impRenderBitmapTexturePrimitive3D(drawinglayer::primitive3d::BitmapTexturePrimitive3D const&) ()
             at drawinglayer/source/processor3d/defaultprocessor3d.cxx:263
         #11 0x00007f4cc4b9fcc9 in drawinglayer::processor3d::BaseProcessor3D::process (this=this@entry=0x39da04c0, rSource=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_deque.h:263
         #12 0x00007f4cc4ba2846 in drawinglayer::processor3d::DefaultProcessor3D::processBasePrimitive3D(drawinglayer::primitive3d::BasePrimitive3D const&) ()
             at include/drawinglayer/processor3d/baseprocessor3d.hxx:63
         #13 0x00007f4cc4b9fcc9 in drawinglayer::processor3d::BaseProcessor3D::process (this=0x39da04c0, rSource=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_deque.h:263
         #14 0x00007f4cc4b3a225 in drawinglayer::primitive2d::ScenePrimitive2D::Executor::doWork (this=0x39e13950) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:461
         #15 0x00007f4cc4868fe7 in comphelper::ThreadTask::exec() () at comphelper/source/misc/threadpool.cxx:319
         #16 0x00007f4cc4869c61 in comphelper::ThreadPool::ThreadWorker::execute (this=0x39e13aa0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:461
         #17 0x00007f4cc144f33f in salhelper::Thread::run() () at salhelper/source/thread.cxx:39
         #18 0x00007f4cc144fe94 in osl::threadFunc (param=0x39e13ab0) at include/osl/thread.hxx:189
         #19 0x00007f4cc14e0563 in osl_thread_start_Impl (pData=0x39120800) at sal/osl/unx/thread.cxx:237
         #20 0x00007f4ccae5f6db in start_thread (arg=0x7f4cabbcb700) at pthread_create.c:463
         #21 0x00007f4ccab8874f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
        
        Change-Id: Ic30b38dc1c53c9df551a282c6a057d042265419e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186222
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e2129be72b51d68f54cbcb4b0eeb391b504dd470]

        sd: write embedded fonts with a more descriptive name
        
        If MSO writes the name of fonts with a generic name like "font1",
        this doesn't mean that we need to do the same thing. Use a better
        more descriptive names of the fonts that include the font family
        name and the font type (regular, bold, italic,...).
        
        Test assert needed to be removed - much harder to test this now,
        but not really that critical.
        
        Change-Id: I96b9f6ee9d34fa7a030fdf0496ef4078bd3dc946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185763
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ff4ff571defc5e62c469799a05a562012fc40ec7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186168
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-06-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cdbd04b1da56b00e75ad04f65619793c0c354822]

        sd: enable "EmbedOnlyUsedFonts" at PPTX import
        
        If fonts are embedded in the imported PPTX document, also enable
        "EmbedOnlyUsedFonts" as MSO usually only embeds the fonts that are
        used.
        
        Change-Id: I6edc47ef793675017e8b127340535fd3d641fa55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185762
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3fb2c50e6639e1c6af2fac2b1ae3901c55885d80)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186167
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f63238bfbb804f2c042dec60771d22f351a87190]

        ofz#422643807 fix build failure
        
        Change-Id: I9438b0195bedbacec94af1fa436cb6f2f8a2dbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186217
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-06  Miklos Vajna  <vmiklos@collabora.com>  [82b24dd9748c6c0a2990e70bda0960ae26415390]

        tdf#166319 sw interdependent redlines: combine on reject of del-then-fmt's fmt
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, rejecting the
        redline under the cursor when it's inside BB resulted in rejecting BB,
        but not AA or CC.
        
        The problem is that the delete-then-format wasn't combined with the
        surrounding delete redlines.
        
        Fix the problem by extending the reverse combine code in
        sw::DocumentRedlineManager::RejectRedlineRange() to recognize
        delete-then-format when it recognized insert-then-format already.
        
        Also rename CanReverseCombineTypesForAccept() to communicate this is now
        used for reject purposes, too.
        
        Change-Id: I7832af605d09ce9a29dd10d68c1915e7f7becfbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186216
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-06-06  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [782131d3a3574290edbe3a15d7f85d7b99dcd3fb]

        StripPortions: Move tooling closer to EditEngine/Outliner
        
        EditEngine/Outliner::StripPortions is used with some lambda
        callbacks to convert Text to Primitives. The tooling for this
        is currently located in svx due to historical reasons (when I
        initially did that).
        
        An EditEngine/Outliner gets configured, this is dependent
        of the object type to handle (see TextBreakupHandler in svx
        and other places).
        
        Then the OutlinerParaObject gets set - the model data.
        EditEngine::StripPortions then initially uses
        ImpEditEngine::Paint which layouts all that and formats it.
        For all Text (or Graphics e.g. Bullets) those callbacks are
        used - if given. If not given it *still* does a direct paint
        to a given OutputDevice to stay compatible with legacy
        usages.
        
        Thus ImpEditEngine::Paint is currently kind of an hybrid: It
        needs to be capable of both: For Primitive creation it
        extracts data to DrawPortionInfo or DrawBulletInfo and calls
        the lambda callback where (e.g. in svx) the Primitives are
        created as needed based on that data.
        For Paint that data is used to Paint using the given
        OutputDevice.
        
        This means up to now for doing changes both had to be
        supported in that method which of course hosts the danger
        of getting unequal outputs when not being very careful.
        
        The DirectPaint is now rarely used (AFAIK only in some UI
        elements, e.g. WeldEditView stuff).
        
        The goal is to go in a direction where it would be possible
        to do those remaining Paint calls direcly inside ImpEditEngine
        using primitives, or - alternatively - change all remaining
        places to use a unified StripPortions method and send the
        result to a PrimitiveRenderer or buffer/resue it.
        
        This change is a 1st step to get the preconditions but does
        not change functionality yet. It moves that tooling to where
        it is used.
        
        Change-Id: I7225eab9a0dfd3d50cd3d1d8fe386dfb99ec42ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186045
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-06-06  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [c4b3f7a6f9e9f1856b76ed398f5e2cd2d65ea417]

        tdf#164970 remove misleading comment
        
        Change-Id: I9c0d8625ba998e5b0e272949615120bd0680e7dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186139
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-06-06  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [1125698bd2ae8b209f896b97d10c08df5655a690]

        tdf#164970 move icon appearance controls from view to appearance tab
        
        this patch also includes some adjustments in the appearance.ui file
        which improve the overall look of the ui
        
        Change-Id: Ica068979c25ab266ec2ebe307cc69a415851b1af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184708
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [e925155733c8324339f2b7280779e8a295797e18]

        tdf#165120: pip: include .txt files
        
        Change-Id: I06ce1fbfccf540113a918915488fa8a57527ce8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186208
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [665f2bf131a6a7359d36d16d531691c100a2dead]

        sc a11y: Use ImplInheritanceHelper for ScAccessibleCellBase
        
        Change-Id: I131a4b703277bcad5214b098c68fdfd050bf74f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186207
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [40f3e28c1dd75d3a3f09ccc66b461400a35ef151]

        sc a11y: Drop ScAccessiblePreviewCell::getImplementationId
        
        The base class implementation in
        ScAccessibleCellBase::getImplementationId does the same
        
        Change-Id: I066c57dbe04dc295436a6c795f2a1cc0b01820e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186206
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [016cb3c311b4bd3bb04793d19531f8fe35ab19b6]

        sc a11y: Use ImplInheritanceHelper
        
        ... and drop custom overrides of XInterface and XTypeProvider methods.
        
        Change-Id: Ic121c2d7fa674cce7e0cf358f41f2ececa4afa27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186205
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [61ed39eab97ad9204845c3b65a6ca1a63199ebb4]

        sc a11y: Make clearer ScAccessiblePreviewTable is cell parent
        
        Switch the ScAccessiblePreviewCell ctor param for parent
        from the generic XAccessible to ScAccessiblePreviewTable
        to make more obvious the the parent is always of that type.
        
        Change-Id: Idfb26e0f99343a23ca7e0659cd88a0871fee43d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186204
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e86a879508e55673b4f6d24ce84eb98b332da63]

        SwAttrPool: pass SwDoc by ref
        
        After
        commit ca6b1677cc3d923f0c13b2253b48a0ea90485b41
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Jun 3 11:59:57 2025 +0200
        
            sw: no need to create a dummy attr pool
        
        Change-Id: Iadc9df6ffab9f479355cd3e2c649a2d3f9c1dbfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186203
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-05  Oliver Specht  <oliver.specht@cib.de>  [80877c7dc467bf5ad6b28ec1b2662db36fcf7542]

        tdf#166850 Apply converted style name to StyleRef field
        
        As a result of e45f187870362ed4448f4a9fb96883b8431887fb the StyleRef
        field needs to use the modified style name with (suffix " (user)")
        The related JUnit test requires a German locale to detect the
        related issue. Otherwise there is no suffix that needs to be
        applied to the field.
        
        Change-Id: Iad4257568ad05900df63a6098ba81e926df701e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186150
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [6f5f4796823ac90298d245016fbd7e3c7117c63f]

        sc a11y: Return rtl::Reference, stop casting
        
        Casting to ScAccessibleCsvGrid is unnecessary, as
        only an XAccessible is needed, and that is already the
        case without casting at least now after
        
            Change-Id: Ia9f24ddebf6c67969c3bffcc7fb13ec0a37026b9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jun 4 11:00:48 2025 +0200
        
                sc a11y: Move XAccessible implementation to base class
        
        Change-Id: I5473e40202a16bf6a19380a1ba52fd1d204c88c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186192
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [da97bdaf8952e9739fc85a414ccdf2361821d7e1]

        sc a11y: Move XAccessible implementation to base class
        
        Let the ScAccessibleCsvControl base class implement
        the XAccessible interface, instead of doing so the
        same way in all subclasses separately.
        
        Change-Id: Ia9f24ddebf6c67969c3bffcc7fb13ec0a37026b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186184
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [3dd3fff576e6f7505e76e01399177fbff43441ac]

        sc preview: Use return value instead of out param
        
        Change-Id: Id25f5086fcbb87f35955cdd77d2a418f31276717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186198
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [5f250b05c4b22c7206db25b4f9d926ed8767dbe2]

        vcl a11y tests: Also test XAccessibleEventBroadcaster
        
        This was originally skipped in
        
            commit 132f22d9f6d58b4e3541ef3e8efe8ef7e3136a23
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Mar 15 20:23:02 2025 -0700
        
                tdf#157003 a11y: Replace AccessibleDropDownListBox Java with C++ test
        
        Quoting from the commit message:
        
        > The XAccessibleEventBroadcaster interface is no more
        > explicitly tested, since the XAccessibleEventBroadcasterTester
        > would require an XWindow again.
        
        However, an XWindow is no longer required since
        
            Change-Id: Iee77f293338f269a2ad7c631384d5e3797b06152
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jun 4 14:54:53 2025 +0200
        
                a11y tests: Use vcl::Window in XAccessibleEventBroadcasterTester
        
        , so add that test now.
        
        To run the test:
        
            make CppunitTest_vcl_a11y
        
        Change-Id: Id54dfcf249ad35bf63c0ab54492291fda60523b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186201
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-05  Michael Weghorn  <m.weghorn@posteo.de>  [f52b63ca5f9ee828af52e9e917ebe870bef17170]

        a11y tests: Use vcl::Window in XAccessibleEventBroadcasterTester
        
        ... instead of the toolkit counterpart, XWindow.
        This allows to use this also for vcl::Window
        based tests, without having to involve
        the UNO abstraction.
        
        Adjust AccessibleStatusBarTest accordingly to pass the
        vcl::Window associated with the XWindow.
        
        To run the test:
        
            make CppunitTest_toolkit_a11y
        
        Change-Id: Iee77f293338f269a2ad7c631384d5e3797b06152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186200
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-04  Patrick Luby  <guibmacdev@gmail.com>  [07f1edfe9d2dd6aaf9c50fdb680f55ddecb96f38]

        tdf#128600 Implement handling of macOS "Reverse Conversion" menu item
        
        When a Japanese keyboard is selected, the keyboard's "Reverse Conversion"
        menu item would silently fail when nil was returned by the unimplemented
        -[SalFrameView attributedSubstringForProposedRange:actualRange:].
        
        So return a valid string in that call using the following steps:
        1. If there is marked text, return the last marked text
        2. If LibreOffice is selected text, return the selected text
        
        Similar steps in the same order are in -[SalFrameView selectedRange].
        
        Limitations:
        1. "Reverse Conversion" with Japanese keyboards only edits the first
           non-whitespace chunk of selected text but I don't know how to adjust
           LibreOffice's selected range to match the substring that the input
           method will edit. This causes the entire LibreOffice selection to be
           overwritten by the substring so return nil if there is any whitespace
           in the selection.
        2. "Reverse Conversion" with Japanese keyboards when there is no text
           selected should select the convertible text chunk nearest to the
           cursor but I don't know how to retrieve unselected text and set the
           selection to a chunk of text.
        
        Change-Id: Ic8377ed7fd9db687061548a79062cfa033df758a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185741
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-06-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [49455ff2fefcc5528a081ae896491c46f4c984a4]

        svx: store a ref to SdrPage, not a pointer in SdrPageProperties
        
        The constructor already takes a reference to SdrPage, but for some
        reason we store a pointer and then later we check if the pointer
        is not nullptr in some cases, which shouldn't be required. This
        changes the the pointer to reference and it simplifies the code a
        bit.
        
        Change-Id: Ib49f514d95e52a078eb55f08bfaaa70fecbea083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186121
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-06-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0aa479cf55b290283a1399cb71dfcdfb866d7052]

        tdf#165712 - sd: fix too small line spacing between text lines
        
        in placeholders with shrink text on overflow
        
        Allowing less Line spacing reduction in case of 0.925 scaling, which
        would make our texts more readable when we are trying to shrink text
        on overflow. Instead of decreasing the line spacing to 80%, should be
        enough to decrease them to 90% and the font size should be decreased a bit more.
        With that we are a bit more closer to mimics MSO text scaling.
        
        Change-Id: Ie5a143cf7c0eeda30682850c59c1e6449a19234b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184704
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-06-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0e9091b6db0d6192a0369ddff71f05d37c29ce98]

        sd: PPTX embedded fonts - skip common fonts
        
        Skip embedding common fonts that are considered to be always
        available or are substituted for a metric compatible fonts in a
        LO or MSO.
        
        Change-Id: Ic970e25e464517fa44f446492c1fdfce29379c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185761
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 21a5a743f3663392798c16943a40c431af4f2dd1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186166
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-06-04  Miklos Vajna  <vmiklos@collabora.com>  [cc2babfa0a960c7d52ea7997aea19dcf10c12d08]

        sw interdependent redlines: fix nPamEndtNI -> nPamEndNI typo
        
        That extra 't' doesn't seem to have any meaning and is inconsistent
        with the content index & start node index naming.
        
        Change-Id: Ibd938aeb91ffa281f028d5d10309a1e0fda7c541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186190
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-06-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [2a00c4ce1edc6d09fc770f0af6ec4d823419afbb]

        tdf#166805 Escape characters in tooltips (qt5/qt6)
        
        Since we're using styles for tooltips in qt5/qt6, we need to escape the message that will be shown.
        
        Change-Id: I1441363980629fd01e176261d3a00ac3a79310ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186117
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b2440b3649aaccbdd39366a27a538c75d9280745]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f88bf40a9be9b3bfbf21fbd0e2677c009ad76dd
          - tdf#164296 Add information on compact pivot table layout.
            
            Change-Id: I48f66daf5e928cde6282ff2110966b22afdd0093
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186155
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [f393f38aac87da33df563f04cb5d035a067238ba]

        Avoid reading out of bounds
        
        ScAccessibleCsvRuler::getTextRange was implemented using
        raw pointers and offsets; that would allow reading beyond
        the buffer end.
        
        Change-Id: I6acb696f540146b99953b272c2f70963d10f5b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186161
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [81fe441ce3533285ee1a4265c5c289a19d15fb13]

        poppler: uggrade to 25.06
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.06.0.tar.xz
        
        Change-Id: I2a24b6126d24255ac89c9e1e218b86d275f698f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186182
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [b360fde668396742919b99ab33de13f1aa2f9bca]

        curl: upgrade to 8.14.1
        
        Downloaded from https://curl.se/download/curl-8.14.1.tar.xz
        
        Change-Id: I1ca0df875c21de4ce713433beabb79ab9e6ae7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186171
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [ca6b1677cc3d923f0c13b2253b48a0ea90485b41]

        sw: no need to create a dummy attr pool
        
        Since
        commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Mon Sep 18 16:15:01 2000 +0000
        
            initial import
        
        Change-Id: I3699ee17b11fdcb58646de312ccde5c7faf94cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [10e25ace0eaffe8f9ba8049702589dc363f2ff0b]

        python3: upgrade to 3.11.13
        
        downloaded from https://www.python.org/ftp/python/3.11.13/Python-3.11.13.tar.xz
        
        Change-Id: I2028223c1d5532019dc1221e6fd7ef64147a05f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186163
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e8aec9a7c33b827be06bad5155b4d820924885c0]

        Fix a failed assertion
        
        Seen when interacting with CSV import dialog, and selecting
        fixed width:
        
         ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444
         sclo.dll!rtl::OUStringBuffer::subView(long beginIndex, long count) Line 1671
         sclo.dll!ScAccessibleCsvRuler::getText() Line 424
         winaccessibility.dll!AccObject::SetValue(com::sun::star::uno::Any pAny) Line 379
         winaccessibility.dll!AccObject::UpdateValue() Line 349
         winaccessibility.dll!AccObject::UpdateAccessibleInfoFromUnoToMSAA() Line 759
         winaccessibility.dll!AccObjectWinManager::InsertAccObj(com::sun::star::accessibility::XAccessible * pXAcc, com::sun::star::accessibility::XAccessible * pParentXAcc, HWND__ * pWnd) Line 683
         winaccessibility.dll!AccEventListener::HandleChildChangedEvent(com::sun::star::uno::Any oldValue, com::sun::star::uno::Any newValue) Line 108
         winaccessibility.dll!AccEventListener::notifyEvent(const com::sun::star::accessibility::AccessibleEventObject & aEvent) Line 63
         winaccessibility.dll!AccContainerEventListener::notifyEvent(const com::sun::star::accessibility::AccessibleEventObject & aEvent) Line 94
         comphelper.dll!comphelper::AccessibleEventNotifier::addEvent(const unsigned long _nClient, const com::sun::star::accessibility::AccessibleEventObject & _rEvent) Line 256
         comphelper.dll!comphelper::OAccessibleComponentHelper::NotifyAccessibleEvent(const short _nEventId, const com::sun::star::uno::Any & _rOldValue, const com::sun::star::uno::Any & _rNewValue, long nIndexHint) Line 126
         vcllo.dll!VCLXAccessibleComponent::ProcessWindowChildEvent(const VclWindowEvent & rVclWindowEvent) Line 155
         vcllo.dll!VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent & rEvent) Line 114
         vcllo.dll!VCLXAccessibleComponent::LinkStubWindowChildEventListener(void * instance, VclWindowEvent & data) Line 104
         vcllo.dll!Link<VclWindowEvent &,void>::Call(VclWindowEvent & data) Line 105
         vcllo.dll!vcl::Window::CallEventListeners(VclEventId nEvent, void * pData) Line 299
         vcllo.dll!vcl::Window::ImplSetReallyVisible() Line 1329
         vcllo.dll!vcl::Window::Show(bool bVisible, ShowFlags nFlags) Line 2338
         vcllo.dll!SalInstanceWidget::show() Line 404
         vcllo.dll!weld::CustomWidgetController::Show() Line 65
         sclo.dll!ScCsvTableBox::InitControls() Line 118
         sclo.dll!ScCsvTableBox::Refresh() Line 77
         sclo.dll!ScCsvTableBox::SetFixedWidthMode() Line 104
         scuilo.dll!ScImportAsciiDlg::RbSepFix() Line 882
         scuilo.dll!ScImportAsciiDlg::RbSepFixHdl(weld::Toggleable & rButton) Line 891
         scuilo.dll!ScImportAsciiDlg::LinkStubRbSepFixHdl(void * instance, weld::Toggleable & data) Line 887
         vcllo.dll!Link<weld::Toggleable &,void>::Call(weld::Toggleable & data) Line 105
         vcllo.dll!weld::Toggleable::signal_toggled() Line 1595
         vcllo.dll!SalInstanceRadioButton::ToggleHdl(RadioButton & __formal) Line 3195
        
        Change-Id: I168fb05d91d42ccde22fa718787c22089d54d2cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186159
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [81426bf9eed87f7548699461061cdcf1fc21f226]

        ui-rules-enforcer: Check that menu item has an id
        
        See
        
            commit 616a3177da38d3db342593149ab2a9a94799cfe8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jun 3 12:01:12 2025 +0200
        
                basctl: Set menu item ID to fix gtk4 crash
        
        Prior to this commit, the newly introduced check
        would have failed with
        
            $ python3 ./bin/ui-rules-enforcer.py basctl/uiconfig/basicide/ui/sortmenu.ui
            Traceback (most recent call last):
              File "/home/michi/development/git/libreoffice/./bin/ui-rules-enforcer.py", line 647, in <module>
                enforce_menuitem_id(root)
                ~~~~~~~~~~~~~~~~~~~^^^^^^
              File "/home/michi/development/git/libreoffice/./bin/ui-rules-enforcer.py", line 611, in enforce_menuitem_id
                enforce_menuitem_id(child)
                ~~~~~~~~~~~~~~~~~~~^^^^^^^
              File "/home/michi/development/git/libreoffice/./bin/ui-rules-enforcer.py", line 611, in enforce_menuitem_id
                enforce_menuitem_id(child)
                ~~~~~~~~~~~~~~~~~~~^^^^^^^
              File "/home/michi/development/git/libreoffice/./bin/ui-rules-enforcer.py", line 614, in enforce_menuitem_id
                raise Exception(sys.argv[1] + ': menu item does not have an id set' , child.text)
            Exception: ('basctl/uiconfig/basicide/ui/sortmenu.ui: menu item does not have an id set', None)
        
        Change-Id: Ic31b0d08f0f981a89a6a6e27b4efe898f7753d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186160
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-06-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [379043962ea977677874fd6879714b6b9ba0b269]

        tdf#158803 Remove assignment to unused variable `document`
        
        Change-Id: Ie2ee2153bfe1a0192ea2e7f9d9731758ba84a588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186100
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [616a3177da38d3db342593149ab2a9a94799cfe8]

        basctl: Set menu item ID to fix gtk4 crash
        
        ConvertMenu in vcl/unx/gtk4/convert3to4.cxx
        assumes that each GtkMenuItem has an "id"
        attribute set. Therefore, set one here as well,
        to fix a crash seen for the following scenario
        in Writer with the gtk4 VCL plugin:
        
        * "Macros" -> "Organize Macros" -> "Basic"
        * right-click on entry in the "Existing Macros In: <module>" treeview
        
        Backtrace:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7ffff789e95c
            2 __pthread_kill_internal pthread_kill.c 89 0x7ffff789e9ff
            3 __GI_raise raise.c 26 0x7ffff7849cc2
            4 __GI_abort abort.c 73 0x7ffff78324ac
            5 __assert_fail_base assert.c 118 0x7ffff7832420
            6 com::sun::star::uno::Reference<com::sun::star::xml::dom::XNode>::operator-> Reference.h 387 0x7fffe6263f7b
            7 (anonymous namespace)::ConvertMenu convert3to4.cxx 239 0x7fffe625fda7
            8 (anonymous namespace)::ConvertMenu convert3to4.cxx 221 0x7fffe625fb3a
            9 (anonymous namespace)::Convert3To4 convert3to4.cxx 978 0x7fffe6256a15
            10 (anonymous namespace)::Convert3To4 convert3to4.cxx 1010 0x7fffe625726f
            11 builder_add_from_gtk3_file convert3to4.cxx 1578 0x7fffe624e6c2
            12 (anonymous namespace)::load_ui_file gtkinst.cxx 23922 0x7fffe62a886d
            13 (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder gtkinst.cxx 24338 0x7fffe62a852d
            14 std::make_unique<(anonymous namespace)::GtkInstanceBuilder, _GtkWidget *&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr), bool>(_GtkWidget *&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr)&&, bool&&) unique_ptr.h 1077 0x7fffe629221a
            15 GtkInstance::CreateBuilder gtkinst.cxx 25007 0x7fffe629211f
            16 Application::CreateBuilder builder.cxx 206 0x7fffee20c881
            17 basctl::MacroChooser::ContextMenuHdl macrodlg.cxx 788 0x7fff0d0a30b0
            18 basctl::MacroChooser::LinkStubContextMenuHdl macrodlg.cxx 783 0x7fff0d09cbbd
            19 Link<CommandEvent const&, bool>::Call link.hxx 105 0x7fffe6399886
            20 (anonymous namespace)::GtkInstanceTreeView::signal_popup_menu gtkinst.cxx 14297 0x7fffe62e367b
            21 (anonymous namespace)::GtkInstanceWidget::signal_button gtkinst.cxx 2957 0x7fffe62a1035
            22 (anonymous namespace)::GtkInstanceWidget::signalButtonPress gtkinst.cxx 2931 0x7fffe62a0e7a
            [...]
        
        At least a simple `git grep GtkMenuItem | grep -v 'id='`
        doesn't reveal any other cases with the same problem.
        
        Change-Id: I9d67ff638ee59a6e57a96a2a3ec24095be31d6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186145
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [090c71278810ec4e271a0c9cb9650f1504e31fe3]

        desktop: Declare var where it's used
        
        Change-Id: I2f293fe16a31a8d84e6b0f3032b881310bfc05bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186151
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [919f4a1430a6f1daba756b7f9f7615c3c9f603ae]

        tdf#166837 vcl: Unset terminate listener once it's been notified
        
        When the TransferHelper's TerminateListener gets notified
        that the desktop terminates, i.e. when
        TransferableHelper::TerminateListener::notifyTermination
        gets called, clear TransferableHelper::mxTerminateListener
        once it has done its job (flushing content to the clipboard).
        
        This prevents the TransferableHelper dtor from later trying
        to create a Desktop instance using Desktop::create (to
        remove the listener), which throws an exception because the
        desktop has already been terminated, as seen with the qt6 vcl
        plugin for the tdf#166837 scenario.
        
        Backtrace of how TransferableHelper::TerminateListener::notifyTermination
        was called:
        
            1  TransferableHelper::TerminateListener::notifyTermination            transfer.cxx         287  0x7f566e7300a4
            2  framework::Desktop::impl_sendTerminateToClipboard                   desktop.cxx          1611 0x7f5674decc1e
            3  framework::Desktop::terminate                                       desktop.cxx          281  0x7f5674debd0b
            4  SfxApplication::MiscExec_Impl                                       appserv.cxx          437  0x7f5673a9071a
            5  SfxStubSfxApplicationMiscExec_Impl                                  sfxslots.hxx         1300 0x7f5673a71f15
            6  SfxDispatcher::Call_Impl                                            dispatch.cxx         256  0x7f5673bc9d9e
            7  SfxDispatcher::PostMsgHandler                                       dispatch.cxx         997  0x7f5673bcf836
            8  SfxHintPoster::DoEvent_Impl                                         hintpost.cxx         74   0x7f56740cd0ec
            9  SfxHintPoster::LinkStubDoEvent_Impl                                 hintpost.cxx         54   0x7f56740cd02d
            10 Link<void *, void>::Call                                            link.hxx             105  0x7f566e47dde1
            11 ImplHandleUserEvent                                                 winproc.cxx          2285 0x7f566e47a011
            12 ImplWindowFrameProc                                                 winproc.cxx          2849 0x7f566e476f3f
            13 SalFrame::CallCallback                                              salframe.hxx         310  0x7f5665fd90ac
            14 QtInstance::ProcessEvent                                            QtInstance.cxx       594  0x7f5665ffb25f
            15 SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const salusereventlist.cxx 119  0x7f566eb851bd
            16 SalUserEventList::DispatchUserEvents                                salusereventlist.cxx 120  0x7f566eb8508b
            17 QtInstance::ImplYield                                               QtInstance.cxx       488  0x7f5665ff7a21
            18 QtInstance::DoYield                                                 QtInstance.cxx       510  0x7f5665ffadc1
            19 ImplYield                                                           svapp.cxx            385  0x7f566ec510d6
            20 Application::Yield                                                  svapp.cxx            488  0x7f566ec509ef
            21 Application::Execute                                                svapp.cxx            360  0x7f566ec507d0
            22 desktop::Desktop::Main                                              app.cxx              1680 0x7f5677b28e79
            23 ImplSVMain                                                          svmain.cxx           231  0x7f566ec7b066
            24 SVMain                                                              svmain.cxx           249  0x7f566ec7cb79
            25 soffice_main                                                        sofficemain.cxx      122  0x7f5677ba31da
            26 sal_main                                                            main.c               51   0x562d93f769fd
            27 main                                                                main.c               49   0x562d93f769d7
        
        Backtrace of how the exception was triggered later:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7f567789e95c
            2 __pthread_kill_internal pthread_kill.c 89 0x7f567789e9ff
            3 __GI_raise raise.c 26 0x7f5677849cc2
            4 __GI_abort abort.c 73 0x7f56778324ac
            5 ?? 0x7f56774a1a3d
            6 ?? 0x7f56774b344a
            7 std::terminate() 0x7f56774a15e9
            8 __clang_call_terminate 0x7f566e0b802e
            9 TransferableHelper::~TransferableHelper transfer.cxx 307 0x7f566e7304fc
            10 ScSelectionTransferObj::~ScSelectionTransferObj seltrans.cxx 163 0x7f563f2a5975
            11 ScSelectionTransferObj::~ScSelectionTransferObj seltrans.cxx 151 0x7f563f2a59f9
            12 cppu::OWeakObject::release weak.cxx 230 0x7f5675c30f65
            13 cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable2, com::sun::star::datatransfer::clipboard::XClipboardOwner, com::sun::star::datatransfer::dnd::XDragSourceListener>::release implbase.hxx 115 0x7f563f227e65
            14 com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference Reference.hxx 114 0x7f5665f902ba
            15 QtClipboard::~QtClipboard QtClipboard.hxx 30 0x7f5665f91590
            16 QtClipboard::~QtClipboard QtClipboard.hxx 30 0x7f5665f915e9
            17 cppu::OWeakObject::release weak.cxx 230 0x7f5675c30f65
            18 cppu::WeakComponentImplHelperBase::release implbase.cxx 86 0x7f5675b3dad6
            19 cppu::PartialWeakComponentImplHelper<com::sun::star::datatransfer::clipboard::XSystemClipboard, com::sun::star::datatransfer::clipboard::XFlushableClipboard, com::sun::star::lang::XServiceInfo>::release compbase.hxx 86 0x7f5665f91695
            20 com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>::~Reference Reference.hxx 114 0x7f5665f90afa
            21 std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>::~pair stl_pair.h 284 0x7f56660048ad
            22 std::destroy_at<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>> stl_construct.h 88 0x7f5666004885
            23 std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>, true>>>::destroy<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>> alloc_traits.h 599 0x7f56660047ab
            24 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>, true>>>::_M_deallocate_node hashtable_policy.h 2046 0x7f56660047ab
            25 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>, true>>>::_M_deallocate_nodes hashtable_policy.h 2068 0x7f5666004711
            26 std::_Hashtable<rtl::OUString, std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>>, std::__detail::_Select1st, std::equal_to<rtl::OUString>, std::hash<rtl::OUString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::clear hashtable.h 2588 0x7f566600463c
            27 std::_Hashtable<rtl::OUString, std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>, std::allocator<std::pair<rtl::OUString const, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>>, std::__detail::_Select1st, std::equal_to<rtl::OUString>, std::hash<rtl::OUString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>>::~_Hashtable hashtable.h 1671 0x7f56660045e9
            28 std::__cxx1998::unordered_map<rtl::OUString, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>::~unordered_map unordered_map.h 109 0x7f56660045a5
            29 std::unordered_map<rtl::OUString, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard>>::~unordered_map unordered_map 202 0x7f566600184d
            30 QtInstance::~QtInstance QtInstance.cxx 326 0x7f5665ff9774
            31 QtInstance::~QtInstance QtInstance.cxx 318 0x7f5665ff9809
            32 DestroySalInstance salplug.cxx 361 0x7f566eb83d04
            33 DeInitVCL svmain.cxx 599 0x7f566ec7ca95
            34 ImplSVMain svmain.cxx 242 0x7f566ec7b0bf
            35 SVMain svmain.cxx 249 0x7f566ec7cb79
            36 soffice_main sofficemain.cxx 122 0x7f5677ba31da
            37 sal_main main.c 51 0x562d93f769fd
            38 main main.c 49 0x562d93f769d7
        
        Change-Id: I92efa302395df884436201fb8262eeb0006c6db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186149
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [14c2c76474b93551195fab3b75d5ba42535c7f11]

        tdf#166837 vcl: Drop TransferableDataHelper_Impl
        
        Move its only member directly to
        TransferableDataHelper to simplify things.
        
        Change-Id: I82759ac25794192b6055fe9aa06c54327c0d5763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186148
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [d37fdb9ef2662e8dae5df864d93fe0ef9152f9b0]

        tdf#166837 vcl: Avoid some const_cast
        
        Make methods non-const instead of having
        const methods and const_cast'ing in them.
        
        Change-Id: I704da690e52b14645e8c535099221e9bcce2c713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186147
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [2c21266d195b407ca359d869f958257632579702]

        tdf#130857 qt weld: Implement submenu support
        
        This will be used e.g. for this menu with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1, once QtInstanceBuilder
        declares support for its .ui file
        ("modules/BasicIDE/ui/sortmenu.ui"):
        
        * "Macros" -> "Organize Macros" -> "Basic"
        * right-click on entry in the "Existing Macros In: <module>" treeview
        
        Change-Id: Ie47e791116f1f72b1fc61a042233cfbea7409030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186154
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-04  Michael Weghorn  <m.weghorn@posteo.de>  [61a6f20326e38f92f990842e8d558a05e083136e]

        tdf#130857 basctl: Use id of first radio item for group ID
        
        .. not the last lone. This helps the QtBuilder
        logic implemented in
        
            commit 5492c9bfa51ab45b936c6191066640608384c0e1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 11 10:24:33 2025 +0200
        
                tdf#130857 qt weld: Support "GtkRadioMenuItem"
        
        to find the group when needed, instead of triggering
        an assert in a test branch where support for that
        menu is declared for native Qt widgets with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        To trigger the menu from Writer:
        
        * "Macros" -> "Organize Macros" -> "Basic"
        * right-click on entry in the "Existing Macros In: <module>" treeview
        
        Change-Id: Id34b5d7efabbc29d732e414c20b487f65e6a0ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186153
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [82f027015e9086a29e802ce35722c0c23adf4fd5]

        tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
        
        not the result.
        
        Change-Id: Iade34a0fefe11801166349bcec64136ee108178d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177113
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c0a9836edfa8b9a5c313577edcc819632562a5d3]

        tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
        
        not the result.
        
        Change-Id: Ib754cbaca045b68651e663df8d7ba21f81da54b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177117
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [725527a54ebb85378673b461ec5f5dca2328a3dc]

        tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
        
        not the result.
        
        Change-Id: Ib7eaca6b715abe3f356d33bc88cb4a2383f57e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177119
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ec61bc74b8149ec1b692881ea4a35365bcb93bca]

        tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
        
        not the result.
        
        Change-Id: I6c0336f2e546568f0408febdb082ebb5d9d00e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177122
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2a296f8259ad08711ca1e112d555f4179638d632]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I333a22bf6d5367f9fd214d35fa323cf12d5cbade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175357
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1ede85d4cb7801b4a3599a9b06db34b1b5135cfa]

        tdf#158803 E402 Module level import not at top of file
        
        Change-Id: I818d91220892bbfa378f146a65c56cc94db86168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186104
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e30276aaa58bc01f6cb6c1c7fec1dd55509c838d]

        tdf#158803 F401 Remove unused imports
        
        Change-Id: I5ab83834731dad1ccc786b292ab2b48e81c44614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186105
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5881602e9961b45537537c03be0b8142bcae46cb]

        tdf#158803  Remove unused import
        
        Change-Id: Id16a76e6131b1588dcc8be3917d552138ed1f230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186102
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [02c47ca58a43876d386cee7cdafbab3f4510d602]

        tdf#158803 Statement ends with an unnecessary semicolon
        
        Change-Id: I48753412cf66ba64af917465767505fa4c494bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186103
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-03  asif196  <asifmohaideen123.dev@gmail.com>  [e6afe9d1bc118a9b83d7a7d275d33e4a3c902336]

        tdf#145160 Set default choice in Image Compression dialog per last format
        
        Currently the compression format selected by default in the compressed
        dialog box for an image depends on the option last selected by the user
        to compress an image except when it is opened for the first time after
        opening libreoffice in which case the `PNG Compression` option is
        selected. This happens regardless of the image format. This patch sets
        the default option based on the format of the image each time the dialog
        box is opened. If it is a JPG, then `JPEG Quality` will be chosen otherwise
        the 'PNG Compression' will be chosen.
        
        Change-Id: Ib8eb84b6b1e226f5bf6e98aa1e0477ffced9be73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180758
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-06-03  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [133754c65311f1ff6ffbae8452d7aa3e401b4202]

        tdf#164970 [API CHANGE] simplify theme schema
        
        when the feature (LibreOffice Themes) was released, there was a themes
        dropdown from where the user could change the theme, and the appearance
        radio buttons group which changed the appearance mode of the application
        
        to remain consistant with the two ways of changing application
        appearance, a colorscheme schema had Light and Dark entries for Light
        and Dark colors for the same entry so that when the user changes
        appearance radio buttons from Light to Dark, we could switch the colors.
        
        but that was really confusing, so as per the request tdf#164970, the ui
        was redesigned, and the appearance radio buttons were merged with the
        themes dropdown (see https://gerrit.libreoffice.org/c/core/+/184429).
        
        this patch cleans up the "Light and Dark" entries from theme schema
        and adds just a single entry per color "Color". one theme should have
        only one palette of colors, to keep things simple.
        
        Change-Id: Ic832169fb07c2a7e95bbb02e894ecd59a8ac4cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184545
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2025-06-03  Heiko Tietze  <tietze.heiko@gmail.com>  [47ef490e4244dc804502729b8c29206bf841f02b]

        Resolves tdf#132286, Related 165604 - Page/Column Preview
        
        Blank background showing the margins correctly
        and feedback for column line color (columns dialog only)
        
        Change-Id: I9f2a277e91ed7644d90cc12a5f1bfd0f4e97e0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186141
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [56771bc864465d22083e6eacf8de08ab3b9e0ffb]

        tdf#163614: sc_spreadsheet_functions_test: Add test
        
        Change-Id: Iedabae2864033858edcda4c26b776db515031b8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186142
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-03  SilverGreen93  <mihai.vasiliu.93@gmail.com>  [1e70df4d65149baafd05964a88d7455e4d6c422f]

        tdf#165838: Add sc_list_remove icons for light themes
        
        The sc_list_remove icon defaulted to Colibre versions for these themes. Add proper icons for them as well.
        
        Change-Id: Ia5ca8830e1a911cd7284b9611ee24dc0626937bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186075
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-06-03  Michael Weghorn  <m.weghorn@posteo.de>  [a1a0991282b4a4449dd200412ad5b49684a3363d]

        gtk3: Don't signal submenu activation
        
        Ignore the GtkMenuItem::activate [1] signal for menu items
        that have a submenu.
        
        The corresponding MenuHelper::signal_item_activate overrides
        that would be called would otherwise handle that activation
        as if a (leaf) menu item was activated by the user to trigger an
        action, while the signal already gets triggered simply
        when a menu item that has a submenu becomes selected/active
        and its submenu is shown.
        
        This addresses/prevents the
        
            warn:basctl.basicide:1948815:1948815:basctl/source/basicide/macrodlg.cxx:806: Unknown context menu action: ___object_1___
        
        warning seen when doing this in Writer:
        
        * "Macros" -> "Organize Macros" -> "Basic"
        * right-click on entry in the "Existing Macros In: <module>" treeview
        * hover over the "Sorting" menu entry
        * click somewhere outside the menu area to close/cancel/dismiss the menu
        
        This was previously triggered because
        GtkInstanceMenu::signal_item_activate called from
        MenuHelper::signalActivate would set GtkInstanceMenu::m_sActivated
        to the (auto-generated because not explicitly set) ID of the
        corresponding menu entry and the call to Menu::popup_at_rect in
        MacroChooser::ContextMenuHdl would then return that ID instead
        of an empty string (which would indicate that the user did
        not activate a menu item).
        
        Ignoring the signal aligns this with the behavior of the VCL
        implementation.
        
        Originally discussed in [2] where the same issue can be seen
        in a newly introduced use of the same menu elsewhere.
        
        [1] https://docs.gtk.org/gtk3/signal.MenuItem.activate.html
        [2] https://gerrit.libreoffice.org/c/core/+/179627/comment/c3ff25b7_9e668e51/
        
        Change-Id: Ieee476606410875d033d877e22e5c9606ff9a848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186134
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-03  SilverGreen93  <mihai.vasiliu.93@gmail.com>  [04744bbc9be4adca92eaba602b7a65c17f6b8dd7]

        tdf#165838: Fix Sukapura add remove icons
        
        Sukapura is a theme based on blue elements. The add and remove icons should also be blue.
        
        Change-Id: Ib2deae7c9396f6a85cdec2c7a4d63f94e3c11d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186076
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-06-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8157e4b56d02d8892d36265d99a53a603e95befd]

        Missing include (for TOOLS_WARN_EXCEPTION)
        
        ...after 6cf20bff7284f3c72fa74c3427115c61edecbe08 "find-unneeded-includes:
        handle IWYU warnings about Qt headers"
        
        Change-Id: I8849517d75e776e39509cd94c7d0e35d4d744dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186140
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0de0eeda82c9137e3dfa3cd2666aa92b56794fea]

        Fix typo
        
        Change-Id: I81a68dab5ad442a66c1511b2f17721e8052db183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186136
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23a17037a6007cc7e9a62b1845ad7566cd6e9063]

        Fix typo
        
        Change-Id: I32171f3c1454a7bbf976a2e643f00baea6954853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186137
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d129af3cd1cf5a0572134098d30e820e096b8df]

        create s_pDefaultBoxAutoFormat during preload
        
        600k+ saving per writer document
        
        Change-Id: I09637deff6bdfb41c61007ea964ba9cd52b39fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186067
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [022720488e10d25733ed785dc90e008300ecfcb4]

        rework getStyles a little to create a getComponentStyles function
        
        Change-Id: I0fed7f27100289e4934bcf818831a6cd4f2c1701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186066
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e53ab9ac6f3f2bd70829a142340006b89b2a1a75]

        make m_aAutoFormat copy on write
        
        Change-Id: I475821bca12037171ae0452a1ee6712524761096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45e1f8ea87f7bf3d540b707b4e5c8bfdcaa36bb3]

        split SwBoxAutoFormat into SwBoxAutoFormat and SwAutoFormatProps
        
        and make SwBoxAutoFormat own a SwAutoFormatProps. Leaving
        the generally mutable m_xAutoFormatUnoObject in SwBoxAutoFormat
        
        Change-Id: I3595d92aeb7f058de3a755633eebacc63fe6a9a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [17c692088d0629c870d21652df1b2603d747ec46]

        SwUndo: pass SwDoc by ref
        
        Change-Id: I928fe502ddcae2e1149862c9972cf30536bd0b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186131
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-06-02  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [b166bfdef9555c4d021551a91317a8831274ed05]

        tdf#114441 sal_uLong to better integer type
        
        Changed the type returned from the ‘InverseColorMap::GetBestPaletteIndex’ method.
        The data is stored in ‘sal_uInt8’ format.
        Converted to ‘sal_uInt16’ unnecessarily each time before use.
        
        Change-Id: I107f8d472a4d714e1d0b857f99835a58da8ca72e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185992
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-06-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6cf20bff7284f3c72fa74c3427115c61edecbe08]

        find-unneeded-includes: handle IWYU warnings about Qt headers
        
        Second try after https://gerrit.libreoffice.org/c/core/+/179708
        
        Skip all QT headers in the form of QtLib/QClass, clean the
        vcl/qt5 dir from LO-internal headers
        
        Change-Id: Icf9edd1f617adc06dcb6ba6bcc4aa0debc275ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186107
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-02  Miklos Vajna  <vmiklos@collabora.com>  [6860cde78169af464a83ed6b9aa20b03e3a53bd4]

        tdf#166795 sw: fix removing indent of para with num rule which isn't counted
        
        Go to the end of the bugdoc, press backspace to make the paragraph not
        counted in the bullet list, then press backspace again. The cursor
        should move to the left, but it stays unchanged.
        
        This went wrong in commit db115bec9254417ef7a3faf687478fe5424ab378
        (tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode,
        SwTextFormatColl, 2023-02-24). The split of SvxLRSpaceItem to 3 separate
        pool items is great when it comes to modeling style inheritance
        correctly, but this broke reducing the indent on backspace in the bugdoc
        case.
        
        Fix the problem by extending the range of pool items we fetch at the
        cursor position in SwWrtShell::TryRemoveIndent(), once both the first
        line and the text left margin is fetched, this starts to work again.
        
        Note that Word turns off the numbering on the first backspace, while
        Writer makes the paragraph not counted instead -- this difference is not
        changed here.
        
        Change-Id: I9ac07a99befd59a54b566e61ff1c00277942b52e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186130
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-06-02  Heiko Tietze  <tietze.heiko@gmail.com>  [557526a59c2491d94e2bc86d3a267a67ee5418ee]

        Resolves tdf#165604 - Make line style color depend on dialog background
        
        Feedback for the chosen line color should not be done at the line style
        dropdown but in the preview
        
        Change-Id: I8cac63eaf1e9c18cb9bed6db8dc899e2ba0eb6bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186129
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [d77a4927e34835160d64bf7249544a8ad6f43075]

        tdf#166767: sc_uicalc: Add unittest
        
        Change-Id: I748c314cac630507f663aff41c876963e0109834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186006
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-06-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [448214abbbf41eea9a116a8059654e1e32e76262]

        tdf#146619 Remove unused headers from vcl/workben
        
        Change-Id: If228ec4d2b14e19958156decfa9c6568fba2e659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186069
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-06-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4511e8b9c9715f7edcb5e101ec09f309378d993e]

        tdf#146619 Remove unused headers from vcl/qa
        
        Change-Id: I029761651a247efdaa9a41fb1ba0f0089846664a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186070
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-06-02  Miklos Vajna  <vmiklos@collabora.com>  [569eb476bbdf83aab0f377da5cb7d2e8c77192b8]

        tdf#166319 sw interdependent redlines: handle reject of del-then-fmt's fmt
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, rejecting the
        BB part is meant to get rid of the delete redline and keep the format
        redline.
        
        The problem is that the old code only considered the primary type
        (format) of the redline, but that's not correct: it's just a small
        detail that there was a format on top of the delete.
        
        Fix the problem by extending
        sw::DocumentRedlineManager::RejectRedlineRange(), so it ignores format
        for both insert as delete.
        
        Also simplify sw::DocumentRedlineManager::AcceptRedlineRange(), we have
        3 non-overlapping cases there, so no need for bHandled there.
        
        Change-Id: I2607740dd0c1ddc447bb3f761f06c07fe80486b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186127
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-06-02  Weblate  <noreply@documentfoundation.org>  [6c4aaabcee292d71e722a53a62c60b9d79bc021f]

        android-viewer translated using Weblate
        
        Esperanto currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ibde349ad7b98164d0b300d56e3b01c140f18ab41
        Co-authored-by: Donald Rogers <donr2648@fastmail.fm>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eo/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186120
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-06-02  Miklos Vajna  <vmiklos@collabora.com>  [f0147cebdefa0cb8bd993c199b0ab290bcec95b7]

        sw: prefix members of ShellMoveCursor
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic307254418b7a12cad2ebfee2e58e2293583d7ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186122
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [cccb93cba84a1a5edce69099ce581ad6dca47258]

        tdf#163485: do not report javaldx failure immediately
        
        Transfer the warning from oosplash to soffice.bin in an environment
        variable, and show it in JavaVMCreationFailureException handler.
        
        Change-Id: Ia3a6a94b2723c74000b7da54d59f4e19576e2692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186115
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [31055d3b22bbdcfa14a38a944c8a02b04197dfc4]

        use shallow copy of default AutoFormatTable
        
        Change-Id: I958f0b6329c4d55af61a94e641bd328abe08dad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186063
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c252310ae33182a77997a4e3b6e600a66eb5422]

        only read-only access to AutoFormatTable needed
        
        for these cases.
        
        Change-Id: Ie2d7423fee72e993b05d855aa4d56c5514ba626a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186062
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [4f400eecc10a04d37652ff1d4dc63aaeee3f0340]

        Move variable declarations to where they are used
        
        Makes it much more clear, which exception is handled there
        
        Change-Id: I0b9fb5d5f356af85e9904f12e038246abea7c8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186112
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ca3e88728f29422ad9e4bd7f9bec08b59cdf4192]

        tdf#166691: don't unhide sections temporarily to create their frames
        
        Commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565 prerequisite:
        make hidden sections have zero-height frames, 2024-02-14) made hidden
        sections have frames. This removes the need to unhide them to get their
        frames, which happened in SwDocUpdateField::MakeFieldList_.
        
        Commit 6db63bb533a5c7436793eab86e83f92322b37044 (tdf#166210: invalidate
        parent's size when hiding section, 2025-04-28) started to invalidate the
        section frame's parent size on section hidden state change. This created
        a loop, where a calculation of the condition, that made a section hidden,
        caused the section to unhide then hide, invalidating parent frame; that
        caused repagination, and then another recalculation (because the number
        of pages may affect the conditions).
        
        This change drops the code in SwDocUpdateField::MakeFieldList_, that did
        the work to unhide then hide sections again, as obsolete.
        
        Change-Id: Ia144835548defaa38d53f03520ac0cc550bdfc23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186108
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [4cc3dc9cb73e9afade3cd91a9bc6ab806cb314af]

        Remove XML_NAMESPACE_NONE noise from editeng
        
        Change-Id: I2bec2d648cca788bac1d2a52118e66a3176cd2aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186097
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [aa5bf844bdb087d55a286e495faf1acde67a2ab5]

        Remove XML_NAMESPACE_NONE noise from xo
        
        Change-Id: I8a4a42848960e24aea2b41cc83cfdee4b5d48e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186099
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [c650a96d0c5ec69e937bf12ad05b032802997c7a]

        Remove XML_NAMESPACE_NONE noise from sw
        
        Change-Id: I7708f23f2e758b2f1ba649652f9ba22c7a64f4f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186098
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [54802cdceb9ff3903b4be1b81638b75fdbfb21f4]

        tdf#166811: let CHILDREN_ON_DEMAND entries draw collapsed in vcl/win
        
        This broke after commit dad7593cf6bb91ecf95153e983723dd2cd03b469
        (GetDontKnowNodeBmp is always empty, 2022-05-11), before which, the
        value of `ButtonValue::DontKnow` was never set to entries. Of course,
        if `GetDontKnowNodeBmp` had been implemented to return a value back
        then, the problem would show there, too.
        
        Change-Id: I13895fb83b8864adabdf4b66c81346c20d15c042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186106
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [b2a15326214684c3569d539af88c2cb70d6a6a38]

        Declare variables where they are used
        
        Change-Id: I930718c1b005c00de4b8fa1da6281c731eb77e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186086
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [9bae9c9ae98fbee769dcb44bcf96dd2d5789c4b7]

        Use C++-style loops on these arrays
        
        Change-Id: Ida7ae15a9d82ed1987b0cb27d6577f026386532c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186091
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a750d23591aaf1bb7883e949769a9b31d6a95983]

        tdf#166773: avoid using HighlightTextColor on treeview standard image
        
        ... when the image is not on a highlight background.
        
        The problem was, that the non-native-drawn symbol of a highlighted
        element was drawn using "highlighted text" color (usually white),
        but that only makes sense when the background of such an element
        (text, symbol) is itself "highlighted" (dark). In tree view, the
        usual rendering only gighlights the text of active element, not
        the area of the "expand" symbol. That resulted in white-on-white
        rendering.
        
        This change tracks, if the background painted for the element's
        items intersects with the area of the symbol, and only uses the
        "highlighted text" color, if it does.
        
        Change-Id: I781b3341466419c1e654d7b46c8cc8db9ead7120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [98e6dae9f7fc9d9bfb646aed278d65be34aad92b]

        store default TableAutoFormatTable in SwModule
        
        throw this away if there is a TableAutoFormatTable save so the
        next use is updated to the current saved table.
        
        Change-Id: I647dc73495f5865f5c1b151f02f9913c23ccefc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186061
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [afe09c75aaf429e5601f1693a72567da94a6562e]

        make SwTableAutoFormatTable::Impl copy on write
        
        Change-Id: I3f2d1aaefeff1592a0e3ac79e3abdefe23ab3288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186060
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b8bdc88bf492d4c444d0a4add9c8e8691c83a03]

        move setup code into Impl ctor
        
        Change-Id: I55d3c47a5f87033975c9a3a55d4fa4aa978be420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186059
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a1cebda1e9d15610718510cc197ca98a27537861]

        move Load/Save bodies to SwTableAutoFormatTable::Impl
        
        Change-Id: I6f9fdfdcacc91a786857d997748069830e92d222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186040
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [375b9d26bbbdfa099004aed37b9333fcdfc54877]

        SwTableAutoFormatTable ctor is always followed by Load
        
        so call that from the ctor
        
        Change-Id: Ic071be84cedb8b131339030d294bbf4690902ac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186036
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [e42a919c04de8c1772b626d38dcb73504cd535cd]

        Remove XML_NAMESPACE_NONE noise from svg
        
        Change-Id: I0612af01d080c009c970672b9d265cdfc47ad10d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186093
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [a4d1a55fa6c84e662d8a64fb16b70abed155fd75]

        Add another test for tdf#166781
        
        Change-Id: I6618f90cd281a982d096060c891234abc1d5623e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186092
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [22ce7a733971fc529eae2d0253abce0924edf3bd]

        Just let the normal "unexpected" error for unmatched loop/wend/until
        
        Otherwise, a code like
        
        sub foo
         wend
        end sub
        
        produces an error "End Sub is missing".
        
        Change-Id: I8e85f7037ab07f1bc1e98037f2a31ef0af45c63f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186090
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [fd8d46654cd309f79c0ae2d284db25d9ac6cc622]

        Document that XDispatchHelper::executeDispatch executes synchronously
        
        This is an important detail. XDispatch::dispatch documentation, which
        is referenced from XDispatchHelper, discusses SynchronMode; but it is
        unclear that executeDispatch doesn't need that, and it always appends
        SynchronMode=true to the passed arguments internally (implementation
        is in framework/source/services/dispatchhelper.cxx).
        
        Change-Id: Ie9634db9458f192966de0094e1596bf3dd967784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186087
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [8574d1af6f705afd108f64d608a5b580d51a88f6]

        Use vector to simplify memory management a bit
        
        Change-Id: I71665feb7da0a94ba35b1d46c5c90b634059ce70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186085
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [b3ed03053d9c304c640fba7442f3278543475852]

        Don't throw on failure copying updater, just return false
        
        This is not a fatal error; other failures are handled in update()
        gracefully. The exception generated here would crash the program,
        because it's not caught.
        
        Change-Id: Id4faa7eed3abacaf075d16f9ec13d61af873121a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186082
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [b80c7b05d0dcb080c7182c9f8610f06e1124d3bb]

        tdf#166751: introduce sfx2::ExecDialogPerRequestAndDispose
        
        It is intended to choose automatically, which mode to use when executing
        dialogs in request handlers. The work on making dialogs async ignored
        the need of synchronous execution when necessary; this helper should
        make it transparent.
        
        Change-Id: If374bbf08159d1591579a278f7319e90f952f4f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186088
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [4630845f221ffea77616ef1103a5111757d0aa55]

        replace a define with std::copy_n
        
        Change-Id: Ifb69965cfb499ed008da413a0804338eb32d6901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186084
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [4187e14558cc5e27dee7aae55b1c14e38f8fcc4e]

        WNT -> _WIN32
        
        Change-Id: Idc6c8f4dbdeb8e13b6b4c5e1f68dec00b83b5fee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186083
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [46425b14c2904e7e1f1b6c1e14a962e8c666d315]

        These `fromUtf8` calls may be avoided
        
        Change-Id: Ifff398ede8d9171d173c3d76107e21f3b0792689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186081
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [6ace08f5117c40d4c0bbec68437af49aa3ec4dd1]

        Simplify a bit
        
        Change-Id: Iecfba0e4280da073dadbe2a34032c18bf624f3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186074
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [b42fad8a35e1f16c5a6691dcbc32abc9830d8efa]

        Use ReadLine taking OStringBuffer to reduce allocations
        
        Change-Id: Ib180a1c67346eb6ce8cfbb6549b6e31e1b7911a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186073
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d81808ec15064e7655503253dddb8ebdc58b1b29]

        Flatten ReadStrFromIni, and reduce string allocations there
        
        Change-Id: I87c1c40d4ad3692ee8da3a4567eda3b6ca3216bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186068
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-31  Stefan Dorneanu  <stefcris2014@yahoo.com>  [27eb6c557e20058f4ca201e94fd9db96b881763e]

        tdf#163738 Use insert() to add multiple values in container instead of for loop
        
        Signed-off-by: Stefan Dorneanu <cdmail2012.cd@gmail.com>
        Change-Id: I6f34abdf199db2cfb14313a600652452ac328079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185432
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-31  Stefan Dorneanu  <stefcris2014@yahoo.com>  [6eaf9092546abe3e225ebf847e7a7fd40aa05cd7]

        tdf#163738 Used insert() to add multiple values in containers instead of a loop
        
        Signed-off-by: Stefan Dorneanu <cdmail2012.cd@gmail.com>
        Change-Id: I8175b11dab5204931aaf53c13d4ac8a2e5a2e911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185431
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-31  Simon Chenery  <simon_chenery@yahoo.com>  [0151a5a2e9114375cd3256e3cca495b2347ebefb]

        Check oox-drawingml-adj-names has delimiter to avoid std::out_of_range exception
        
        Skip line with warning if no tab delimiter found. This avoids a
        std::string_view.substr(-1) call, that throws an std::out_of_range
        exception.
        
        Change-Id: Ie35ea692ce3c2cbc8c21c01b0c488a6bb5eb5e32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183741
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b559e6371c2abf5c75622f602da87f28ff499a91]

        update credits
        
        Change-Id: I223741ecc3312e209bb6f72865ec34cdaa652020

2025-05-30  Miklos Vajna  <vmiklos@collabora.com>  [98f0b23a48246507ced6de5b54d327d95f1725f9]

        tdf#166319 sw interdependent redlines: combine on accept of del-then-fmt's fmt
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, accepting the
        BB part resulted in <del>AA</del><del>CC</del>. The removal of BB is
        good, but there was no combine to also remove AA and CC.
        
        The problem is that the delete-then-format wasn't combined with the
        surrounding delete redlines.
        
        Fix the problem by introducing a new CanReverseCombineTypesForAccept()
        for the case when the redline with 2 types is conditionally combined
        with an other redline and by using that in
        sw::DocumentRedlineManager::AcceptRedlineRange().
        
        Also extract some duplicated code into a new lcl_AcceptInnerDelete().
        
        Change-Id: Ib5881b6c9aa44ae5dcf79342dbd64bbd61f734c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186031
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [cc7cf8e5baab8e8d386e45c60121cb762f7f0575]

        tdf#158803 Remove unused imports from solenv
        
        Change-Id: Ie570247b191ef3689fc8af5ba9aea972086e096f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176794
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-30  Simon Chenery  <simon_chenery@yahoo.com>  [25ece0a2c15f0dc637e0fb607aaa5114b2739998]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in langtab.cxx
        
        Change-Id: I7f27496835e35e049261aadfd65c9c7e7a38202d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183253
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-30  Simon Chenery  <simon_chenery@yahoo.com>  [17418dea6be97bfc5efbe8a47d1a8ee26fbd0a9c]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in qproform.cxx
        
        Change-Id: Ic8f02d859baab75868efde03d891020e8273d83a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184359
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6b73857acb06bd2ad437e8decb82d7c205d306f0]

        Fix typo
        
        Change-Id: I96416b2e71b6e61fa265c83a70594c52633445e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186034
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [111d38aade84be9bd79123f406b630cfd34eab30]

        Fix typo
        
        Change-Id: I3c8aa60f1a0b9509bbac012b3af731a113805b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186035
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-30  Henry Castro  <hcastro@collabora.com>  [1b05e253fc2514154f1a53a4c75deb3154e50c6e]

        cppuhelper: add m_ prefix to OInterfaceIteratorHelper4 for member variable
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I7772c875ea77f942ca55dbe9551df19c2767a5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186044
        Tested-by: Jenkins

2025-05-30  Mike Kaganski  <mike.kaganski@collabora.com>  [a6eb3588d9717eb01c03bdc100565eb692362ded]

        tdf#166789: use text width from DXArray in MetaActionType::TEXTARRAY
        
        DXArray gives much more reliable data compared to font width, which
        is known to require complex corrections (see tdf#127471 and commit
        3d33e4ce3987ea17e73a72e84f7f0df7af8101a6).
        
        This fix uses tspan's `lengthAdjust` and `textLength` attributes for
        automatic justification, which are already documented as early as in
        SVG 1.0 ( https://www.w3.org/TR/SVG10/text.html#TSpanElement ). This
        works in LibreOffice and in Chrome, but is not supported in Firefox
        yet ( see https://bugzilla.mozilla.org/show_bug.cgi?id=890692 ).
        
        I considered using these attributes on `text` element level, which
        is supported in both browsers - but that breaks text elements with
        multiple tspans. The `transform` attribute can't be used with tspan
        both in Chrome and in Firefox, which creates the same problem, and
        has an additional drawback that tspan offsets need tweaks.
        
        Change-Id: I7d4bbb7542a9d60e53bdf6f6cac7fae0729e6e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186033
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c904e02a784d262bdb4c42e8dbf3ac8245d4f3e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 83bd7a5e88a1cb6c828a0c6b06107abb5f304cf9
          - tdf#162607 Disambiguate field cross-ref.
            
            + Hidden contents removed
            
            Change-Id: I81f9ec8bebcf5616250684348bac5e4b3c297a11
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186047
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4d443505ad888495b27516125f7b23019f4ba370]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68b9433aecba3fc363333ff382a01950293e951d
          - tdf#162607 Disambiguate slide show settings.
            
            Change-Id: I79a861eeffec7661b44dbc4bbaac273d0d9fed8e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186046
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [de2cf78b7825935507a30f38ae468bfedb2f36cd]

        reportdesign: Don't pass around empty Sequence
        
        `aProps`, used for the `rMediaDesc` param is an empty Sequence
        in all cases, so drop the param and create the empty Sequence
        where it's needed instead of passing it around.
        
        Change-Id: I3c66a11ae5d1902faed39906f696d8bf5ab06eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186038
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [a76c597187c988f7e3840c808c70d08c2414d269]

        SdUndoAction: pass SdDrawDocument by ref
        
        Change-Id: I0f15f2e93e701f23dd588a891e3d40cc0854ce78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186041
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [14fcd2dc9ac20d87a3c0b4d398d1bce43ec92bce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f789ddb74b0928a3bfa58284b69320518d59007
          - tdf#146113 Precisions on IsNull Basic function.
            
            + refactor
            
            Change-Id: Ic45d26f63d65f13d659a39dca27b5d48dc064b6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186012
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [786e601044c27870f5f6344df33b4d36e687519b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2eef7d7960fbabda12f97e17ec9a707cef3a3542
          - update translations for master/25.8
            
            and force-fix errors using pocheck
            
            Change-Id: I1bef5e627a8a7c55e5b295caf3b0c8d396dc04d3
            
2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [50aaf26eb45e6acee5c2dc3cc19a13299b8945e9]

        svtools: Use RET_CANCEL instead of magic number 0
        
        Change-Id: I4669b19c0bc441e6f7beaa8e4272fd5653e9260e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186030
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [d4b4d5aabe3ba1bf2d97f97351b979c29793d912]

        tdf#164970 add app background bitmap customization ui/api/code
        
        please see: https://gerrit.libreoffice.org/c/core/+/185697
                (Change-Id: I71fee27467be861b610934c213cf80fbae037327)
        
        Change-Id: I46d1a03582c06e948a98b3e554c02b2939be9168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185858
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-30  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [dff301ca58eb0e1300158b4ce161f52b0119f483]

        tdf#164970 organize customizations grid, remove unneccessary rows
        
        Change-Id: Ic09f07269f015dcdb045fe49ececa7c2cd3ab631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185698
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-30  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [d547590c3b10d17525f3581bc0c42922c03dbdc9]

        tdf#164970 [API CHANGE] remove all app background related api/ui/code
        
        previously all this was done in a single [patch] and it made things
        quite complicated for me (to change) and for the reviewers as many
        things were moving in a single patch.
        
        API CHANGE:
        only application background is bitmap customizable and we stored
        the user settings for bitmap file name and draw type as properties
        of AppBackground color entry in a ColorScheme. That unneccessarily
        complicated things as we had to check for the "/BackgroundType" while
        Loading and Committing (saving) the colorschemes.
        
        this patch removes the bitmap properties from AppBackground entry
        of the colorscheme schema along with all the feature implementation
        code. most of the implementation code is added back in a follow up
        patch with a new underlying api and ui to make it independent of color
        customization.
        
        [patch]: https://gerrit.libreoffice.org/c/core/+/184544
        
        Change-Id: I71fee27467be861b610934c213cf80fbae037327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185697
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [97cc7d53f5336d2c4c9b1a98e1bae3eca9432a72]

        vscode: cSpell support
        
        Change-Id: I6760bea7e6106505399477f87d7c17429e74767d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185979
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [08142e65f772d1bf42b4740b0f70ca897bdbaa0e]

        tdf#166764 - Show list of recent documents in Base subdialogs
        
        Change-Id: I6ec809a739e07053872d1a4050bbcfea4b142e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186004
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-05-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f86e3c7f22d53abb9a844f6916246ed96ef99ae6]

        register caches with ImplSVData
        
        and put them under a single trim control
        
        Change-Id: I72b53102e781f6b16968588b9066588d7fdb3055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185753
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [c0b40fed77ee6b792d663bf4e998a5f3957ec4bb]

        cui: Make most ColorPickerDialog methods private
        
        Only the ctor and GetColor need to be public, the
        rest is only used internally.
        
        Also have all field declarations in once place for
        a better overview.
        
        Change-Id: Ibf9087c2415197052bd0f25927910aaa2a7ea5ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186026
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [980c95c59a7a3105710349578af6f27019103b93]

        tdf#130857 qt weld: Use "r" prefix for reference
        
        ... and be more consistent how to camelCase `rId`
        inside QtBuilder.
        
        Change-Id: Id967e7f698708ae07f08da60b259c42aa330ac39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186023
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [3a9dd7f3d5ad0d8220f44536dc18874095a75292]

        tdf#130857 qt weld: Position popup below menu button
        
        When showing the popup for a QtInstanceMenuButton,
        position it below the button, and horizontally centered.
        
        This makes the calendar popup in the dialog newly
        supported since
        
            Change-Id: I57f4a864651e32a1cfc30f2778d86cb1e89f3349
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 29 16:39:43 2025 +0200
        
                tdf#130857 qt weld: Support sc dialog to group by date
        
        show up in a proper position instead of a "random" place
        with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: I6749d8db3c9939063acc0f4c789c9e01ed58aa18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186020
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [9218387aef2a1b9d33cf6b40d774dfb0cb2882ea]

        tdf#130857 qt weld: Support sc dialog to group by date
        
        Declare support for the Calc "Grouping" dialog to group
        by date.
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered as follows:
        
        1) Open attachment 184921 from tdf#153217 in Calc
        2) switch to "Pivot_Table_Sheet1_1" spreadsheet
        3) select cells A1:A13 (i.e. the month names)
        4) "Tools" -> "Group and Outline" -> "Group"
        
        This makes use of QtInstanceCalender introduced
        in previous commit
        
            Change-Id: I8a65701a1aa477a04dcf66f63df7864db0b0cdf4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 29 15:32:54 2025 +0200
        
                tdf#130857 qt weld: Introduce QtInstanceCalendar
        
        and the conditional support for .ui files from
        
            Change-Id: I0174d306187ed65f49f165b9eff7f2f2ea05a3a5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 29 15:43:15 2025 +0200
        
                tdf#130857 qt weld: Prepare for more conditional UI file support
        
        Support for svt/ui/datewindow.ui which contains the
        the popup that contains the "GtkCalendar" is conditional
        on the parent being a native QWidget.
        
        This makes it possible for this to be used for the
        newly supported dialog without breaking dialogs
        that are not native Qt dialogs (yet), e.g. in
        "File" -> "Properties", the "Custom Properties"
        tab still uses the vcl::Window based weld::Calendar.
        Sample use:
        
        * "File" -> "Properties"
        * switch to "Custom Properties" tab
        * press "Add Property"
        * for the newly created entry, select type "Date"
        * click on the menu button in the "Value" column
          to open the calendar popup
        
        (This wouldn't work with the native Qt
        version as of now, because the SalInstanceMenuButton
        expects to also have a vcl popup.)
        
        Change-Id: I57f4a864651e32a1cfc30f2778d86cb1e89f3349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186019
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [c100a4e59350b69db7fe1de20094739e7afdcd6b]

        sc a11y: Resave groupbydate.ui + set a11y relations
        
        Resave the dialog with glade 3.40 and fix
        preexisting a11y issues now triggering gla11y
        build errors:
        
            sc/uiconfig/scalc/ui/groupbydate.ui:148 FATAL WARNING: 'GtkMenuButton' 'start_date' does not have its own label
            sc/uiconfig/scalc/ui/groupbydate.ui:232 FATAL WARNING: 'GtkMenuButton' 'end_date' does not have its own label
        
        Manually restore the
        
            <property name="label" translatable="no"></property>
        
        for the 2 GtkMenuButton objects to avoid following critical
        warnings seen with the gtk3 VCL plugin:
        
            (soffice:340885): GLib-GObject-CRITICAL **: 18:11:59.786: invalid cast from 'GtkImage' to 'GtkLabel'
        
            (soffice:340885): Gtk-CRITICAL **: 18:11:59.786: gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed
        
        Dialog can be triggered as follows:
        
        1) Open attachment 184921 from tdf#153217 in Calc
        2) switch to "Pivot_Table_Sheet1_1" spreadsheet
        3) select cells A1:A13 (i.e. the month names)
        4) "Tools" -> "Group and Outline" -> "Group"
        
        Change-Id: Ia83a764245aa577fbab9e1c1917c25fd1b0c2a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186018
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [2cd7bf146077cd598ad52f8d8cd860535f8a9e5c]

        tdf#130857 qt weld: Prepare for more conditional UI file support
        
        Various .ui files are used for non-toplevel widgets
        that can be used from different dialogs/toplevels.
        
        Using native Qt widgets for these is only supported
        in case the whole dialog is a native Qt dialog,
        because proper functioning depends on a QWidget
        hierarchy.
        A SalInstanceWidget parent doesn't support
        QtInstanceWidget children but relies on them being
        SalInstanceWidgets as well (i.e. vcl::Window based).
        
        Prepare for supporting more .ui files conditionally,
        i.e. only when the parent is a QWidget as well.
        
        This generalizes the solution introduced with
        
            commit 9a03fb9266440013eef5f8cd11cc1e5478706496
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 12 14:05:23 2025 +0200
        
                tdf#130857 qt weld: Support new Welcome dialog
        
        a bit to use a set of .ui files as well, so more
        can easily be added in the future.
        
        Change-Id: I0174d306187ed65f49f165b9eff7f2f2ea05a3a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186017
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [be3e1d32a85eeb2ebb6a83a42d62329b1607e5f2]

        tdf#130857 qt weld: Introduce QtInstanceCalendar
        
        This is the weld::Calendar implementation using
        a native QCalendarWidget.
        
        It's not used in practice yet, as no dialog using
        it has been declared as supported yet, but this
        is one step in preparation of doing so in the future.
        
        Change-Id: I8a65701a1aa477a04dcf66f63df7864db0b0cdf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186010
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [06eeafef14a91b42fd82476fc7b1787a1e362b57]

        sfx2 a11y: Set a11y name for date combobox in linefragment.ui
        
        Resave the file with glade 3.40, but manually restore the
        "label" property for the "date" GtkMenuButton to avoid
        this critical warning seen with gtk3 otherwise:
        
            (soffice:197852): GLib-GObject-CRITICAL **: 13:11:54.151: invalid cast from 'GtkImage' to 'GtkLabel'
        
            (soffice:197852): Gtk-CRITICAL **: 13:11:54.151: gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed
        
        Address this preexisting
        issue now flagged by gla11y and resulting in a build error
        otherwise:
        
            sfx2/uiconfig/ui/linefragment.ui:92 FATAL WARNING: 'GtkMenuButton' 'date' does not have its own label
        
        This makes Orca say "Date" now when that menu buttons get focus.
        
        Sample scenario:
        
        * start Orca
        * start LO Writer with the gtk3 VCL plugin
        * "File" -> "Properties"
        * switch to "Custom Properties" tab
        * press "Add Property"
        * for the newly created entry, select type "Date"
        * tab to move focus to the menu button in the "Value" column
        
        Change-Id: I1c24e4e61cd7550299a00101c29f53c925675add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186005
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [f4b8780fd7a3a5efbfab50f97372e9dc8434141f]

        tdf#130857 qt weld: Support search attributes dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * click on the "Attributes..." button
        
        Change-Id: Ifce43cd3b57a20cca16bd12eecc731639ae2901a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185998
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [b13594de5cbb40d68bb31765ec0c47af284b23b2]

        cui: Resave searchattrdialog.ui with glade 3.40
        
        A dialog using it can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * click on the "Attributes..." button in the dialog
        
        Change-Id: I9bd2a8a5242bfd5b622cecd261663cfac6e5e7be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185997
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [e28f452794366469ebfb3ac947cb520250d243a3]

        cui: Resave optjsearchpage.ui with glade 3.40
        
        A dialog using it can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * check the "Sounds like (Japanese)" checkbox in the dialog
        * click on the "Sounds..." button
        
        Change-Id: Ia99c65e17677e42727a3efa5573c17ce79f1427e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185996
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [8d506ae58d4a83fb673b0360ce79a18500d5d3af]

        tdf#130857 Define widgets in "Similarity Search" dlg in order
        
        Switch the order in which the widgets in the .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        This dialog can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * check the "Similarity search" checkbox in the dialog
        * click on the "Similarities..." button
        
        Change-Id: I552538b9c9b8da9583409e6680cfc98c62236ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185995
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [638c4f8c996bbe38cd8379817c82ae2ba3ef7205]

        tdf#130857 qt weld: Support "Similarity Search" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * check the "Similarity search" checkbox in the dialog
        * click on the "Similarities..." button
        
        Change-Id: I39c1d08e72e506b8a22bdd31d1d2c389b399566c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185994
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [d677acf41dfd219dc796b70e04440c91031eaac6]

        svx: Prefix SvxSearchDialog members with "m_"
        
        Also, use "s" instead of "a" prefix for OUString
        members.
        
        Change-Id: I5daa6ee4ad451ed9ba4bb33605a8683458651b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185993
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [7665fd196926e376f104d285aab5883bc5333a27]

        cui: Resave similaritysearchdialog.ui with glade 3.40
        
        This dialog can be triggered as follows:
        
        * In Writer, select "Tools" -> "Find and Replace"
        * check the "Similarity search" checkbox in the dialog
        * click on the "Similarities..." button
        
        Change-Id: I98c0d04c94ebcc0324c5c829f01d80dff975ba45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185990
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [435e36996197e75f330eea4151935f5d84cd968e]

        svx: Simplify SvxSearchDialog::Remember_Impl use
        
        So far, the method was called with either
        
        * the current text of the search combobox and a value of bSearch=true
        * the current text of the replace combobox and a value of bSearch=false
        
        The method already uses the corresponding combox depending
        on the value of the `bSearch` param.
        
        Therefore move the logic to retrieve the current text also in there
        and drop the first method param.
        
        The checks whether the current text was empty before calling
        the method was also superfluous, because the method returns
        early in that case anyway.
        
        Change-Id: Ieb3f20f36ff0bbc7bc33b4f7676ce8df3d20c83f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185989
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [44d6bdde27ba2bce1c61aa73ec53d34a828bb903]

        svx: Use ref instead of pointer
        
        Change-Id: Iab60327c70b33592c559f625b71924aa85b25a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [2eeb0b2b51066d1cb535d3fadee79dd91b01eeb4]

        tdf#130857 svx: Keep current search term in find dialog
        
        In a WIP branch declaring support for using native Qt
        widgets for the "Tools" -> "Find and Replace" dialog,
        the scenario
        
        1) open the dialog using "Tools" -> "Find and Replace"
        2) enter "foo" in the "Find" combobox
        3) press "Replace All" button
        4) enter "bar" in the "Find combobox"
        5) press "Replace All" button
        6) repeat steps 2-5 a few times
        
        would sometimes result in the current search term
        ("foo" or "bar") getting replaced with the previous
        one after pressing the "Replace All" button.
        
        This is because SvxSearchDialog::Remember_Impl
        was removing the entry for the current search
        term from the combobox and then reinserting it
        at index 0.
        
        That would however not result in the "new" entry
        to automatically get selected for the Qt implementation
        in QtInstanceComboBox, while it seems to be the case
        for the GTK and VCL ones.
        
        Avoid the problem by skipping the removal and
        reinsertion if the current search term is already
        the first one among the combobox entries and in the
        vector of remembered search/replace terms.
        
        Change-Id: Ic1d002d414d5b75beb7a80e9ae7125e116a246f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-30  Michael Weghorn  <m.weghorn@posteo.de>  [349c4c66ec36c53da162bb46438bdb9363f4d4ee]

        tdf#130857 qt weld: Fix qtToVclStringWithAccelerator for empty string
        
        Return an empty string in qtToVclStringWithAccelerator
        when the input string is also an empty string.
        
        The previous logic resulted in "~" being returned because
        the initial index of 0 would never change.
        
        This resulted in the
        
            if(!m_xSearchComponent1PB->get_label().isEmpty() && bSearchComponent1 )
        
        logic in SvxSearchDialog::Construct_Impl to return true
        and Buttons without text showing up in the Search and Replace
        dialog in a WIP branch adding support for that one for
        qt6 and SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: Ie24c091676a36179471b8bd863d60838632de83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185986
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [63597069fbb3209db1b4acd3c3e85b512b5d717c]

        tdf#166767: fix crash quiting LibreOffice with something on the clipboard
        
        No unittest caught this when
        
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        was executed on Jenkins so I don't know how to test it
        
        Change-Id: I4570bb47af06390baabadf84d3513b5d10c7b4d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186025
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1f17dd388d8f66200ca85513e161eb403f6f8667]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f43f8f7b3b3658306291990afad2a675fad4b703
          - tdf#162607 Disambiguate Format menu.
            
            + some refactor
            
            Change-Id: Iae790785e90fb9439a9a6ef9fd650eca59e21985
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186027
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-29  Vlad Ene  <enevlad10@gmail.com>  [cf1c25e542ad58b9e242979cf1e6d9c426321c6f]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Signed-off-by: Vlad Ene <enevlad10@gmail.com>
        Change-Id: I1b7e68e6ff8297cbd5f9cadc301161db629123f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185428
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-05-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [06564d92aa97f1540d6fc336911936952c85feab]

        fix typos
        
        Change-Id: Icd0bdab02beb73d971f9727bbefb571d5c5f1d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185980
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-05-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [30ff5efae638c3206cedf9436433425a0f18f469]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b27a35104859ef38b8ba631f10ec1e0076bdd7fe
          - Update Gluepoints Help page
            
            Change-Id: I4dbe226d9d8f795474da429f271054e05275c64a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186022
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2d6d2f294a8c2574b87a0496f4eb5ff014b905e9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dcdaa73f785b675d8eba20c94b207a19bb66b9f7
          - tdf#162607 Disambiguate Edit menu.
            
            + some refactor
            
            Change-Id: I89b5994381c68327b1b3a63eae7867cdbbc13fe1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/186021
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-29  Skyler Grey  <skyler.grey@collabora.com>  [366c8a03219524a14efd99472749fe574f33c35e]

        fix(mobile): Include DialogFactoryServices
        
        Without these, we cannot open any dialogs in the mobile app.
        
        It looks like they were added in I8c199421c66de2dcf339ccc2d5cb9340d3bea914,
        I90dae749f777446f67342d121e4dc29b974cb9b6 and I389fcafd80f1a450befbffdc252be497ba20f6d5
        to better support mergelibs, and presumably they were unintentionally
        omitted from the mobile app at that time.
        
        Change-Id: Icf0d48ed40e17cfbcd5c2720432bc15bf7b55e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186013
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4a519c00b11f9fda5a50e9e084e9ac7043bc65e3]

        ofz: sanity check NameTableString
        
        Change-Id: Iac194d464e4badb338a1b8ff49105cc87d125125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-29  Jonathan Clark  <jonathan@libreoffice.org>  [86ffb108824d884320bde3320d58c8c497780099]

        tdf#166104 sw: Fix for apostrophes changing to Asian font
        
        Regression from 537645c0834eab2d277113f1e3fcf039c994832d
        "tdf#66791 sw: Treat weak punctuation as Asian in Asian paragraphs"
        
        The fix for tdf#66791 extended the script change scanner to always treat
        weak quotation-like punctuation as Asian script in paragraphs containing
        Asian characters. That new behavior emulates the behavior of other word
        processing programs.
        
        Unfortunately, the change proved too disruptive. This change
        substantially reverts the new behavior added for tdf#66791, but leaves
        the refactoring and testing work intact.
        
        Change-Id: I9eaf91f27a4e8f7440c949a713c6b64fe8dc579b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185812
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-05-29  Guilhem Moulin  <guilhem@libreoffice.org>  [1decbe7399c3abcd5ec36b874a76d33af9880ec3]

        Fix bin/compare-crashreport-stats.py
        
        Change-Id: I13cb6e4558307a4a913d9c0f7f04e2d48466d926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186007
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [44cdfa2eee54f6ead849fd998abe1c3c58b67398]

        tdf#166781: Emit correct expected token on missing End If
        
        Change-Id: I28fc1822d80c45416204f56a5763a804b2b1f5a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185999
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [0229c794a94fc8611049668d25b5033cccacfe9c]

        tdf#97390 - Show recent documents menu item in query result window
        
        Change-Id: Ic648d5c2384275b2219292ae13359ac543fd7d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185973
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2025-05-29  Miklos Vajna  <vmiklos@collabora.com>  [5fedce78c8d79a3e86307523c3d74c7df98668f7]

        tdf#166319 sw interdependent redlines: handle accept of del-then-fmt's fmt
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, accepting the
        BB part resulted in <del>AA</del>BB<del>CC</del>, while the expected
        result would be removal of BB from the document.
        
        The problem is that reject only saw the 'format' in the combined
        delete+format redline, but that's not correct: it's just a small detail
        that there was a format on top of the delete.
        
        Fix the problem by extending
        sw::DocumentRedlineManager::AcceptRedlineRange() to handle the
        delete-then-format case as a delete and only then do the generic redline
        handling.
        
        The surrounding plain delete redlines are not combined yet.
        
        Change-Id: I7ea92a86d8881694ad3da571831100f5996b5d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185985
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [87b3b8e6990b394baa74aec8701cd097f6c0c646]

        tdf#166321 Find bar: blank square with gen environment
        
        Regression from
            commit e0d4d178caff1414a9a21fa57f06bc8d4d2c389a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 13 15:03:05 2025 +0200
            Change alpha behavour of OutputDevice::SetFillColor
        
        Which exposed another place where COL_AUTO is troublesome.
        
        Previouslu, calling set_background(COL_AUTO) used to work
        because COL_AUTO has the same value as COL_TRANSPARENT,
        and calling
            OutputDevice::setBackground(COL_TRANSPARENT)
        would have the same effect as
            OutputDevice::setBackground()
        
        But that is no longer the case, especially when we are drawing to
        an OutputDevice which has no alpha layer.
        In that case, the alpha value is chopped off the Color object, and
        we are left with what is effectively COL_WHITE.
        
        So add some new weld API to make resetting the background to default
        less error-prone.
        
        Change-Id: I29987c4c343af40447ed847a617d6b0e9d673f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [f7079f5d2c58c5d2d9099978c271fdd723f8264a]

        tdf#130857 qt weld: Sort ui file list alphabetically again
        
        ... after
        
            commit 043b186d10fca4a613ce62c1e0d04f86ec63799c
            Date:   Mon May 26 12:33:04 2025 +0200
        
                Related tdf#158880 - [API CHANGE] Rename ToolbarModeDialog to UIPicker
        
        Change-Id: I35992e840812ef789ba354cdaac5e958a9b01484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185981
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [58ba249df589b0c9f91667f2938bfa18d2a1ce61]

        tdf#166779: use model first to obtain selection
        
        The current frame can be Basic, so only use it as a fallback to obtain selection.
        Also, failure to get the selection is not fatal here.
        
        The throwing behavior was since commit aa1927dc257b52edf96de220cc3797e02c83a0ae
        (Make svg export use slidesorter selection in most cases., 2012-10-10).
        
        Change-Id: I06f80151b4184f353d1d5387c11837f1e883a068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185983
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7885ec2c55d06f4ec31864a5cc3e4295b15e81cf]

        Remove duplicated include
        
        Change-Id: I1e0552ce9aea78bbefbef95223ec66faed4397f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185977
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d44ab156f4642f16837e9858c47c80730da15ad9]

        Fix typo
        
        Change-Id: I658c9dc1bea7d8652e0fdfc3756816d536453e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185978
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [29b0be697d568944b47d3f8cbffa72384d50b076]

        gtk3 a11y: Report object's locale
        
        This is basically the gtk3 version of
        
            Change-Id: I33b3bb406da5d84c2353bbeb5bedc7ac0297f31f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 28 22:54:57 2025 +0200
        
                qt a11y: Report locale for Qt >= 6.10
        
        and causes the paragraph locales to be reported for the
        use case described in the above-mentioned commit also
        when using the gtk3 VCL plugin:
        
            In [14]: acc.get_object_locale()
            Out[14]: 'en_GB.UTF-8'
            In [15]: acc.get_object_locale()
            Out[15]: 'zh_CN.UTF-8'
        
        Add the character encoding at the end of the locale string,
        as this is consistent with what is reported by default for
        the object locale (was "en_GB.UTF-8" for any object prior
        to this change) for the gtk3/ATK case.
        
        The atk_object_get_object_locale doc [1] says that the
        returned string is owned by the instance, so make sure to
        free the string again by setting it as data for the
        AtkObjectWrapper object and free it in
        atk_object_wrapper_finalize.
        
        [1] https://docs.gtk.org/atk/method.Object.get_object_locale.html
        
        Change-Id: Icaadc5228f2cc5526b427cc3aef127a8eadd94ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185982
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [1db70ac081d73837f526ff3bfae9eeaa221aa8c6]

        qt a11y: Report locale for Qt >= 6.10
        
        Report the locale for accessible objects using
        the Qt API newly introduced in qtbase commit [1]
        that also describes a scenario using LibreOffice:
        
            commit da3422ca150ab52c1c2184cdd467ff105ba1de3c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 23 10:59:32 2025 +0200
        
                a11y: Introduce QAccessible::Attribute::Locale, bridge to AT-SPI
        
                Introduce a new Locale value for the QAccessible::Attribute
                enum class that can be used to specify the locale
                of an accessible object.
        
                Use this to implement support for the
                "Locale" property of the AT-SPI Accessible interface. [1]
        
                If no locale has explicitly been specified, report
                the default locale in the AT-SPI adaptor, as is
                already the case in the implementation of the
                "GetLocale" method of the AT-SPI Application
                interface.
        
                Being able to explicitly specify a locale is of
                particular interest when an application contains
                objects whose locale differs from the default
                application locale, e.g. documents or paragraphs
                written in a different language.
        
                Demo LibreOffice change making use of this
                new API: [2]
        
                Sample use case with the above-mentioned LibreOffice
                change in place:
        
                1) start LibreOffice Writer, using English UI
                   and document language
                2) type "Hello world" for the first paragraph
                3) press Enter to create a new paragraph
                4) copy-paste "你好世界" ("Hello world" in Chinese)
                   into the new paragraph
                5) start Accerciser
                6) select the first paragraph in Accerciser's treeview
                   of the LibreOffice a11y hierarchy
                7) query locale in Accerciser's IPython console
        
                    In [1]: acc.get_object_locale()
                    Out[1]: 'en_GB'
        
                8) select the second paragraph in Accerciser's treeview
                   of the LibreOffice a11y hierarchy
                9) query locale in Accerciser's IPython console
        
                    In [2]: acc.get_object_locale()
                    Out[2]: 'zh_CN'
        
                For UIA on Windows, UIA_CulturePropertyId [3] seems
                to be the equivalent property that the new attribute
                could be mapped to (to be done separately, not implemented
                in this commit).
        
                [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/2e65b0877d67667b06e0dc6ad918a6fd4943c371/xml/Accessible.xml#L55-67
                [2] https://gerrit.libreoffice.org/c/core/+/185709
                [3] https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids
        
                [ChangeLog][QtGui][QAccessible::Attribute] Added new
                Locale enum value that can be used to specify the
                locale of an accessible object.
        
                Fixes: QTBUG-137144
                Change-Id: Ice11b9e45b512305dbb8195961b8b08e1389c69e
                Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=da3422ca150ab52c1c2184cdd467ff105ba1de3c
        
        Change-Id: I33b3bb406da5d84c2353bbeb5bedc7ac0297f31f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185709
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [aadde5364767445a3ff539d6673a0201912d49db]

        Related tdf#166733 - Show Welcome dialog on the very first start only
        
        Product updates should trigger the WhatsNew flavor of the welcome
        dialog and only new installations the Welcome mode.
        
        Change-Id: I6071ec748d735b92dd0169772dcbddceffad4760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185976
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [17e8dbead42e2d4b55815b1b7b2846b03d62a15d]

        vscode: make the build target prompt for a target
        
        it remembers the previous target, so should be more helpful than having
        to e.g. type "make module" repeatedly
        
        Change-Id: I9b2ed398a6b4efd73007dae2304790fa63760b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185961
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a3b9820e5baeaa32aa06fd55f85f7165061bdd5b]

        add meson to PERMITTED_BUILD_TARGETS
        
        Change-Id: Id51802295d875529176e7006026ef4c1d0a696db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185959
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [058ba67b89174d3c364974b5a519d407c5d108a1]

        FuPoor: pass SdrModel by ref
        
        Change-Id: I7f928dfef0d4136e25fd8933254d759fc6812990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185974
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [ad28d16caa52d2e19b437b469ea67d4d77b1906a]

        Rework SDK installation guide layout
        
        Get rid of table-based layout in favour of CSS grid.
        Don't break paragraphs with line breaks to make it easier to grep stuff.
        
        Change-Id: I86ec8defd5746bfd8de6e08b686e454c8a0fdfa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185975
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-28  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [a07a0f429c3a1a6709ec42907d00b29b84c75447]

        tdf#166525 CEOO: Back to overpaint everything
        
        Change-Id: Ia39331001a6759d27e938602b1fc5d8da2e90ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185971
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [e3ea19d05db432ee41f0bac87197ddefe96265f0]

        comphelper a11y: clang-format accessibleselectionhelper.h,c}xx
        
        ... which in particular gets rid of one extra
        indentation level.
        
        Change-Id: I01e07f8cb7baf1f1f6dc407e6a8eba64cef9fe39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185946
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [e6e6554e5edf6aaf12a589d310ffb68544b8d9df]

        basctl a11y: Drop AccessibleDialogControlShape::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        already implements the same logic.
        
        Change-Id: I42634213177d4c34ca9330db58a01a4f687a66f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185945
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [e00ddac69b81fcb53616c258e6a7cef942dab886]

        odk: Drop a11y UNO API use from InputEvents example
        
        The UNO a11y API is unpublished and has no stability
        guarantuee whatsoever and is not meant to be used by external
        users, so don't use it in the InputEvents example.
        
        Change-Id: Ie98dc344b0459946976d881134f6fac9b7e1452a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [24c86762b1af48c814d47b2a4b6c43e6cd31d373]

        odk examples: Drop unused recursive_acc_ctx
        
        The only uses are commented ever since this
        example was added in
        
            commit 2e52ac48e58efa5f1204ac61eec820eb3fb561ba
            Date:   Thu Jun 27 00:17:31 2024 +0200
        
                Added pyuno demo for key and mouse handlers and listeners.
        
        and the UNO a11y API is unpublished, i.e. not meant
        to be used in external code.
        
        Change-Id: I39f50cdfca938bd260ee6c558c23e13776583565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [71ff088c6b3a22600b3b05c1dc3c4ca42548c5c6]

        gtk3 a11y: Don't rely on win accessible being VCLXWindow
        
        This is similar to winaccessibility commit
        
            commit ed03c63f00dee22112a8632df45e5e044541960d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 09:45:02 2025 +0100
        
                wina11y: Don't rely on win accessible being VCLXWindow
        
        , but in gtk3 a11y code.
        
        This commit e.g. makes sure that the combobox inside of Writer's
        find toolbar will keep showing up in Accerciser's treeview of the LO
        a11y hierarchy after upcoming commit
        
            Change-Id: I25de1ab0f8b47b12346abd01bad05cb54fb75f52
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 26 09:45:11 2025 +0200
        
                vcl a11y: Let vcl::Window create accessible directly, drop a11y factory
        
        , as the previous assumption that the vcl::Window's XAccessible
        is the VCLXWindow/XWindow will no longer be true after
        that commit.
        
        See the winaccessibility commit mentioned above for more
        background.
        
        Change-Id: I7b00f8c00aa11d8426026f8ed427fbb13f4d345a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185842
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [a57c6e99c9aa2f0b2099c0ec2d1d7998da11db75]

        a11y: Drop unused accessiblefactory.hxx includes
        
        Change-Id: I5b605a32a62dfd17318db5232c59282a6ae1cb7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185841
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [cbce194ae57d2c83fa8c191868733cb9f46221fb]

        svx a11y: Drop FmXGridPeer::CreateAccessibleContext
        
        As far as I can understand, this custom override of
        VCLXWindow::CreateAccessibleContext should in the end
        have no effect, because VCLXWindow::CreateAccessibleContext
        only gets called if the window doesn't have an accessible
        yet that's different from the FmXGridPeer, see
        Window::GetAccessible.
        
        Change-Id: I958e3634a074bcf9cd6639bd6942ec0fb8ff920b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185840
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Miklos Vajna  <vmiklos@collabora.com>  [a414d7d884bc49f6d4028ad2fcf4186998a5a67e]

        tdf#166680 DOCX import: handle nested <w:r> runs
        
        Regression from commit 57450afb768c085df0ba2344aa94b5f843060178 (DOCX
        import: declare wps as a supported feature, 2013-12-03), the bugdoc has
        a shape that has invalid (but well-formed) <w:r> elements inside a <w:r>
        element and Word imports this fine.
        
        We used to be compatible, because <mc:AlternateContent> has
        <mc:Choice> and <mc:Fallback> branches and the fallback didn't have
        these nested runs and we used to read the fallback.
        
        Fix the problem by extending the generated tokenizer to also accept
        <w:r> inside <w:r>.
        
        Note that while this is invalid, not only old Writer but also Word
        accepts this.
        
        Change-Id: I52e573f921e95dcc6e2b76b2d46bf2b3a03a88ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185972
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [99032706a8f7b68e2e54d1da5cc58ae3ed67b73e]

        tdf#163805: sd_uiimpress: Add test
        
        Change-Id: If2d9539723ab70be8d2076c292b725da5c7b5313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185967
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b61dffd1da35063006de0e26506fd863cb9782f]

        loplugin:unusedmethods
        
        and trim out some of the noise from the reports
        
        Change-Id: Ib99a044049a7715978ef58718d2518bde23b8fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185958
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a3e4283c1ba72be1304e39a66e50389ad021063]

        loplugin:unusedfields
        
        Change-Id: I52a47047723bcddf8528273a081c78cef9f153c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185957
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [9184814ead16720f8fdc7c58c5390a9b0267e808]

        avoid vcl warning
        
        otherwise I see
          vcl/source/outdev/stack.cxx:101: OutputDevice::Pop() without OutputDevice::Push()
        
        Change-Id: I40ed55ed0cfa2ffea3afae51ef2b3a04f5c35497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185960
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-28  Heiko Tietze  <tietze.heiko@gmail.com>  [043b186d10fca4a613ce62c1e0d04f86ec63799c]

        Related tdf#158880 - [API CHANGE] Rename ToolbarModeDialog to UIPicker
        
        The scope of this dialog has changed with 98d1ac254bd62dff9d0aa9c72ba879d1d52495ef
        and it's not just an UI for the ToolbarMode namespace
        
        * Toolbarmodedlg* renamed to UIPIckerdlg*
        * UNO command ToolbarModeUI renamed to UIPicker
        * SID_TOOLBAR_MODE_UI renamed to SID_UI_PICKER
        
        Change-Id: Id4d617aeee83ae1800d4b9a2d207d28c391dcdb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185789
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-28  Alexandru Babacea  <al.babacea@gmail.com>  [ec7389d5975bb584b1d7a0e13ba412b4d8920f99]

        tdf#156055 Edit Index Entry dialog saving changes
        
        Modified the Close button functionality so that a warning
        message is displayed if there are unsaved changes.
        
        Removed Apply button.
        
        Added a Reset button that restores the current index entry
        if it was modified.
        
        Change-Id: I20d0d07794a27abda7830ba4b34ba412e755369f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185373
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-28  Heiko Tietze  <tietze.heiko@gmail.com>  [3cfa257452dd04da0dcd6e9a8e61dcd98bdcb687]

        Resolves tdf#166733 - Show Welcome dialog only once
        
        WhatsNewDialog made nilable with default=nil; on the very first
        start this variable is set to true (and potentially toggled to
        false by the user later)
        
        Change-Id: I8653c9de2ae58233a614acba5ee3a35fd97c8154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185905
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [37ca6715d0df17054d8d8e627ea88c96db67190b]

        tdf#166445: sc_subsequent_filters_test2: Add test
        
        Change-Id: I6c349ec3324366ef2158cfcaafca04aab04c2fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185955
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b93f495ad5d90b5c3a1f14e3c020892f4b5ffc7]

        curl: upgrade to 8.14.0
        
        * external/curl/undefined.patch.0 has been fixed
        upstream
        
        Downloaded from https://curl.se/download/curl-8.14.0.tar.xz
        
        Change-Id: I3c782cc927798aa6c3e589fbc47bd2f5848f8ca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185947
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [1ef2979ed45c9867e002b9f790aa02c48b86bfa7]

        cui: Resave entrycontextmenu.ui with glade 3.40
        
        This is used e.g. by the context menu that
        can be triggered as follows:
        
        * "Tools" -> "Customize"
        * in the "Menus" tab, right-click on an item in the
          "Assigned Commands" tree view
        
        Change-Id: Ie0698c3700ade5710e562697c929b98a108a8ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185954
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Szymon Kłos  <szymon.klos@collabora.com>  [1fa122efc36ae461228fec6a77b9b9e4820e8313]

        lok: open sidebar when formula is inserted
        
        to insert various math elements we need sidebar,
        in LOK case when it was closed it was hard for an user to
        discover it's features
        
        Change-Id: I1e378d932d42bee637f14842279b44edf33dacb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185248
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185953
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-28  Michael Stahl  <michael.stahl@allotropia.de>  [f80b4a455768131b6054ab5fe80b3c6aac7f0286]

        LOCRDT sw: return EMPTY from EndUndo() if no action inserted
        
        Apparently code in inputwin.cxx already checks for this.
        
        Change-Id: Iaae1b8894b421d8d7bf7b22908abd6cfbf265690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185865
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef23a021ace9135bfdb02c4abfa6f562b9e8ab31]

        convert GapMembership to scoped enum
        
        and drop unused GM_PAGE_BORDER
        
        Change-Id: I8913ceafbcf4803514ffa51ec049496fca04a649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185949
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0465942c3350d0e6a7eae5efbf727d53aa5560d3]

        unused constant
        
        Change-Id: I6bd021857656b912e7c6f5687d331c67b35ace50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [1efbf3bc73f5c0534b316b514ce00cadf5d57135]

        uitest: drop unused import
        
        after
        commit 864904e8d04fadb905dc9e22326a7bf0f69d38c7
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Mon May 26 08:56:43 2025 +0200
        
            sw uitest: Port tdf146145 away from using a11y API
        
        Change-Id: I3ddfa9b80ad02ce4641c13e71673f9510e3dab45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185951
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-28  Miklos Vajna  <vmiklos@collabora.com>  [15bd73a093f1f944d504cf555918ca9e60d75c03]

        tdf#166319 sw interdependent redlines: combine on reject of ins-then-fmt's fmt
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins> in it, rejecting the
        BB part resulted in <ins>AA</ins><ins>CC</ins>, while the expected
        result would be to reject AA and CC together with BB.
        
        The problem is that the insert-then-format wasn't combined with
        surrounding insert redlines.
        
        Fix the problem similar to what commit
        f31293c9fcbc47e43367857085e135f09ed378b8 (tdf#166319 sw interdependent
        redlines: combine on accept of ins-then-fmt's fmt, 2025-05-25) did for
        accept a similar redline: extend
        sw::DocumentRedlineManager::RejectRedlineRange() to also reject the
        surrounding redlines.
        
        With this, clicking reject at the center of this AABBCC redline chain
        makes all of that disappear from the text, as expected.
        
        Change-Id: I330e4a96c6c1464db4844b0e99481aad72e95d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185952
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0152a6245f33b80b85aa0479858dadbaaaa3fcbb]

        Revert "poppler: try to patch out all uses of std::ranges"
        
        This reverts commit 670e3fe7358dc69d80ed25b178cc7a2d3c76f0ee.
        
        Reason for revert: build baseline was bumped so this workaround isn't needed anymore
        
        Change-Id: Ia72943d4980e486b00492e7836690db3bcaeb27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185911
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-28  Justin Luth  <jluth@mail.com>  [10b9d5200e382db5affaefc035ebe4d6b35a92fb]

        tdf#37153 tdf#165478 sw: add mso-compat flag doNotVertAlignCellWithSp
        
        This patch depends on
            NFC tdf#37153 ww8import: replace 'unknown' with compatibility names
        
        The problem was that the cell vertical orientation should not
        ALWAYS be forced to top when the cell contains an floating shape.
        
        This replaces my 6.0 commit 7a9fb40cb07de8c2ea33f92735be5008d30d6704
        which incorrectly applied to all MSO documents. All DOC files - yes,
        but it should only affect DOCX with compat flag doNotVertAlignCellWithSp
        (Don't vertically align table cells with shapes).
        
        It appears that DOC format should ALWAYS be considered
        as having this flag enabled, even if it is set to OFF
        (and it IS set to off somehow in the unit tests).
        At least that is how MS Word 2010 seems to deal with it,
        and MS Word 2003 (which doesn't detail these layout flags)
        also works the same way (even for the DOCX - which reinforces all DOC).
        
        - open the unit test tdf37153_considerWrapOnObjPos.doc
        --   see the image/paragraph marker at the top of the cell.
        - delete the image
        --   see the paragraph marker drop to the bottom of the cell.
        
        make CppunitTest_sw_ww8export2 CPPUNIT_TEST_NAME=testTdf37153
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf165478_bottomAligned
        
        For ooxmlexport24's tdf37153_considerWrapOnObjPos.docx,
        I probably created that unit test after testing in Word 2003.
        There it behaved identically to the DOC version,
        and that becomes no surprise when I now find out that
        doNotVertAlignCellWithSp is a flag introduced for Word 2007.
        Since it was testing for an ancient layout - I changed it.
        
        Change-Id: Id1ef078a19605532bbb694532cbe7f3cf82fb565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185695
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-05-28  Justin Luth  <jluth@mail.com>  [52648dbfa8ea57b164070326d9a3355b45b4e1d0]

        NFC tdf#37153 ww8import: replace 'unknown' with compatibility names
        
        I needed to add fDontVertAlignCellWithSp
        so I figured I might as well take care of all of them in this block.
        
        No Functional Change intended.
        
        (However, I did notice that the range
            // [MS-DOC] 2.7.11 Copts I..P
        only had 7 entries instead of 8,
        but fixing that didn't affect any "named" flag.
        It does mean that there are now 33 entries - which is correct.)
        
        I took advantage of Stephan's todo hint (commit b30b82b723179)
        // in C++20 with P06831R1 "Default member initializers for bit-fields"
        // the above bit-field member initializations can be moved
        // to the class definition.
        
        According to TDF's C++ Code Conventions (May 24, 2024 ~ LO 24.8)
        "LibreOffice uses C++ 20 as the standard for the code base.
        Therefore, you can use the latest features that are available in C++20."
        
        Change-Id: I2c17b7e6b6792dbf59775f4a9c10306c319c88e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185685
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-05-28  Justin Luth  <jluth@mail.com>  [c7f049069c5022ee09d73841d9e32b685a3bd9d8]

        tdf#165478 revert ConsiderWrapOnObjPos: always affect anchoring cell
        
        This reverts my 6.0 commit e56f61c4637c09afbf125fa02f131b0c49e36351
        for tdf#37153
        which was likely fixed properly by some layoutInCell fixes for 25.2.
        
        make CppunitTest_sw_ooxmlexport24 CPPUNIT_TEST_NAME=testTdf37153
        
        make CppunitTest_sw_ooxmlexport25 CPPUNIT_TEST_NAME=testTdf165478_bottomAligned
        
        Change-Id: I0413504228d25aa311318c37478261e17346e3db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185634
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [3cb6bae61d0d7a34570d035b229a38069380abad]

        vcl a11y: Let Edit and subclasses create their accessible directly
        
        This is the equivalent of
        
            commit f82aac71ede9c3f2dc059ca4c8b24f60e0841933
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        for Edit subclasses, see that commit's message for more background.
        
        Since all of DateField, TimeField, MultiLineEdit and VclMultiLineEdit
        are (not necessarily direct) subclasses of Edit and none of their
        subclasses further up the class hierarchy than Edit override
        Edit::CreateAccessible, there is no need for them to do so either,
        but they can use the Edit implementation. Therefore, just drop the
        corresponding methods of their VCLXWindow subclasses that were
        calling `AccessibleFactory::createAccessibleContext(Edit* pEdit)`
        explicitly.
        
        (Before
        
            Change-Id: Ifb7452de3e011a73aa798d1ea0302bbbc74ed7d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 20:13:09 2025 +0200
        
                vcl a11y: Set DateField/TimeField window type in ctor
        
        , two of them had some additional extra logic that might
        have required them to override the base class implementation.)
        
        Since VCLXAccessibleEdit implements the XAccessible interface
        now, its SVTXAccessibleNumericField subclass no longer needs
        to implement that directly.
        
        Change-Id: I5fe96a9061afb9f51e494cdd41a27636d0aa4d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185838
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [344737c3cab905400184d4bda22107c75c7e7d76]

        vcl a11y: Set DateField/TimeField window type in ctor
        
        So far, a DateField (or subclass) would be created
        with WindowType::SPINFIELD due to its SpinField
        base class (and not passing any explicit type to
        the base class ctor).
        
        However, when an accessible context would later be
        retrieved, VCLXDateField::CreateAccessibleContext
        would set WindowType::DATEFIELD on the control
        before creating an XAccessibleContext via the
        AccessibleFactory.
        
        Changing the window type later that way seems odd,
        and implies that the window type would be different
        depending on whether or not accessibility is active.
        
        Change that to set the DATEFIELD window type in the
        ctor already.
        
        The same applies for the TimeField and
        WindowType::TIMEFIELD.
        
        Should that have any unwanted side-effect, then
        it might be that some code path currently only handling
        the WindowType::SPINFIELD type might need to be
        adjusted to handle WindowType::DATEFIELD and/or
        WindowType::TIMEFIELD the same way.
        
        Change-Id: Ifb7452de3e011a73aa798d1ea0302bbbc74ed7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185837
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [d3262b72f69311b282fbdbe3c38de743e76bdda9]

        a11y tests: Don't rely on XWindow being window's XAccessible
        
        See
        
            commit ed03c63f00dee22112a8632df45e5e044541960d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 09:45:02 2025 +0100
        
                wina11y: Don't rely on win accessible being VCLXWindow
        
        for more background.
        
        Change-Id: I19a01f9715536918dd9463f18a72c22878d0cd7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185836
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [64fd4b55a9f1711b766d5e59133dc1222f0793d9]

        vcl a11y: Let FormattedField create its accessible directly
        
        This is the FormattedField equivalent of
        
            commit f82aac71ede9c3f2dc059ca4c8b24f60e0841933
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I81e196680cc976b73ab029e595713e616ea90bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185692
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [2bccfbd9ee56c89764b2e8163cf874cc3650738e]

        toolkit: Drop VCLXHeaderBar
        
        Since
        
            Change-Id: I26249401d9bcde81908553cc01521ac0ead338dd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 19:37:35 2025 +0200
        
                vcl a11y: Let HeaderBar create its accessible directly
        
        , the class doesn't add any functionality to its VCLXWindow
        base class, so drop it altogether and just use plain
        VCLXWindow instead.
        
        Change-Id: I288103d2681a81c3828e311c9b12b7aee1ec1f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185691
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [63feda6b8d614cda08f98bd6e801e081beaffd18]

        vcl a11y: Let HeaderBar create its accessible directly
        
        This is basically the HeaderBar equivalent of
        
            commit f82aac71ede9c3f2dc059ca4c8b24f60e0841933
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        In this case of HeaderBar, there is already an existing
        HeaderBar::CreateAccessible method that was handling
        the case where a custom function to create the XAccessible
        was set and the default vcl::Window logic going via the
        VCLXWindow/AccessibleFactory was only triggered otherwise.
        Handle that case also directly in there instead.
        
        Change-Id: I26249401d9bcde81908553cc01521ac0ead338dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185690
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [942838c81f6a67cd96e8a5f04ff8bdb3d57ef9b7]

        toolkit: Drop VCLXToolBox
        
        Since
        
            Change-Id: Ib6a6746f7fcbcacddc4cc05a00cf63fe04407f80
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 19:21:33 2025 +0200
        
                vcl a11y: Let ToolBox create its accessible directly
        
        , the class doesn't add any functionality to its VCLXWindow
        base class, so drop it altogether and just use plain
        VCLXWindow instead.
        
        Change-Id: I2ef8efa06dc04e5e9b18dc743575666d41ce5648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185689
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [05591f072f752ae24de271ed5a96e0fc91440a6e]

        vcl a11y: Let ToolBox create its accessible directly
        
        This is the ToolBox equivalent of
        
            commit f82aac71ede9c3f2dc059ca4c8b24f60e0841933
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: Ib6a6746f7fcbcacddc4cc05a00cf63fe04407f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185688
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [864904e8d04fadb905dc9e22326a7bf0f69d38c7]

        sw uitest: Port tdf146145 away from using a11y API
        
        Stop using the UNO a11y API in that UI test in
        order to check whether the "Accept" toolbar item
        in the Track Changes toolbar is enabled or not.
        
        The previous logic was depending on the implementation
        detail that ToolBox's XWindow is also its XAccessible,
        which will no longer be the case after upcoming commit
        
            Change-Id: Ib6a6746f7fcbcacddc4cc05a00cf63fe04407f80
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 26 09:08:41 2025 +0200
        
                vcl a11y: Let ToolBox create its accessible directly
        
        Instead, use the API newly introduced in previous commit
        
            Change-Id: I6fcbee3ce894ad82ec42fa034b85544b50408779
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 26 08:26:37 2025 +0200
        
                [API CHANGE] uitest: Add API to get XUIObject for specific XWindow
        
        to get a UI test object for the toolbar.
        For checking the state of the toolbar item, check the
        toolbar child infos, as the toolbar items and their state
        are provided that way since
        
            Change-Id: I6064ad3481e1cef694762c321e244097d8c3029b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 26 08:57:32 2025 +0200
        
                vcl uitest: Add support for toolbar items
        
        This also allows to use the toolbar item's text
        to identify the one of interest, instead of having
        to rely on the toolbar item being at a particular index.
        
        To run the test:
        
            make UITest_sw_table UITEST_TEST_NAME="tdf146145.tdf146145.test_tdf146145"
        
        Change-Id: Ice15d7a9e48c27a257bd6943f473b75c2526e3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185775
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [b95f8892a1b87fe2130397b749a23d48e13a9e62]

        vcl uitest: Add support for toolbar items
        
        Add new class ToolBoxItemUIObject that provides
        access to information about ToolBox (toolbar)
        items in UI tests.
        Initially, report the item's text and enabled
        state. (This can be extended as needed if there
        is a need in the future.)
        
        Extend ToolBoxUIObject to report the ToolBox
        items as children in addition to those children
        retrieved via the WindowUIObject base class logic.
        
        This will be used in an upcoming commit in
        sw/qa/uitest/table/tdf146145.py to port
        that test away from depending on a11y implementation
        details that are about to change.
        
        Change-Id: I6064ad3481e1cef694762c321e244097d8c3029b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185774
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [3cf9ebf5841d363da85e700fe7acc4ebe5be52ca]

        [API CHANGE] uitest: Add API to get XUIObject for specific XWindow
        
        Add a XUITest::getWindow method that allows to get the
        XUIObject for a given XWindow.
        
        The XUITest interface is internal/unpublished API used
        for UI tests.
        
        The newly introduced method will be used in an upcoming
        commit in sw/qa/uitest/table/tdf146145.py to port
        that test away from depending on a11y implementation
        details that are about to change.
        
        Change-Id: I6fcbee3ce894ad82ec42fa034b85544b50408779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185773
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [bc06f26b79e9b3b0d7ed10303dbaa4f4d4d970c5]

        sw uitest: Use 4 spaces for one indentation level
        
        ... instead of 3 in some lines.
        
        Change-Id: Ib2cb0db9b5f00ecfb493f26beaa751ef3554052f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185767
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [fd090409b67bb933c4e110e621150e2eaa4b1b3b]

        vcl uitest: Move ToolBoxUIObject to own .hxx/.cxx
        
        The new header also doesn't have to be a global
        include/vcl/ header, but can be vcl-internal.
        
        Change-Id: Ib625d4b1815f34860f7b7a5d809d8f32b45fd23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185766
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [ed51f56035529e00a1ac985c0ccc3fbc90ee7de5]

        vcl uitest: Use #pragma once
        
        Change-Id: I543f280ca3d5b59427aa2d3ba57ea92b19ff8954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185765
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [796eb580839a39d9ebe9b9808b8a7af32b033fd5]

        libeot: fix win_arm64 build
        
        Most likely after
        commit 80e08f59eaee11a0ff1874416cbcc7e3fb102164
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
        Date:   Fri May 9 00:06:19 2025 +0900
        
            make libeot compile on Windows
        
        Change-Id: I2a1b668c4f6a33b9072cd32c3354e7fe8fb3a7c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185938
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [65c71cf012b0da406ee585d35c0f36b143ae321a]

        sc: fix windows build
        
        C:\cygwin64\home\tdf\jenkins\workspace\lo_daily_src\sc\inc\cellsuno.hxx(404): error C2487: 'ScCellRangesObj::{ctor}': member of dll interface class may not be declared with dll interface
        
        after
        commit 79322a7025bb6fd61928204f90230560b09b4ba9
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed May 21 15:28:41 2025 +0200
        
            tdf#166684 strip out some unnecessary UNO work
        
        Change-Id: I0d90f5ba07d309d3fc1d4a5518596ed1667e547d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185931
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-28  Eike Rathke  <erack@redhat.com>  [b16dd0fb306944a02e5d73d4a2bbc68cf80b0b8f]

        Resolves: tdf#163614 empty compares greater-than for LOOKUP()
        
        Change-Id: I529a83f18a0660c97bd1c9368418f1751b1db2aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185932
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [daa7b2e0673685a2797820733f9d3900c40ba776]

        Remove duplicated include
        
        Change-Id: I0a6b0e58ce86942e2174cda6f7c582b171bd2c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [743dcac17bc885e167da1ef955f123f5862b8f8d]

        Fix typo
        
        Change-Id: Ia1a47c2abd63952033a47c0e522bd5344d3a84ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185913
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f1ad181d73c27a39e10113e1c99bb73fe184135]

        Fix typo
        
        Change-Id: I6077ca4924f16cf8cf379b1bacf321aff7495e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185915
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3afe36ee680dfcf470eca28f089e0ef5e394bd1d]

        Fix typo
        
        Change-Id: Ib75681ba77f8c9854c90f693392eea8c50bc9068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185914
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dff8e9123cac3e6e942e0c081e64fe1a591c37cb]

        move this check to earlier
        
        Change-Id: I3082b828327f0b235ad867001a643ad4766aa35e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [53abdbd6011116ca9e1e03ad2bb5a72eb0bae7f8]

        null deref of SwTextNode
        
         #0  rtl::OUString::getLength (this=<optimized out>) at include/rtl/ustring.hxx:821
         #1  SwTextNode::Len (this=this@entry=0x0) at sw/source/core/txtnode/ndtxt.cxx:300
         #2  0x00007fe9a0a80b0d in SwCursor::LeftRight(bool, unsigned short, SwCursorSkipMode, bool, bool, bool, SwRootFrame const*, bool) ()
             at sw/source/core/crsr/swcrsr.cxx:1789
         #3  0x00007fe9a0a552d4 in SwCursorShell::LeftRight(bool, unsigned short, SwCursorSkipMode, bool) ()
             at sw/inc/crsrsh.hxx:495
         #4  0x00007fe9a0c82eca in SwCursorShell::Right (bAllowVisual=false, nMode=SwCursorSkipMode::Chars, nCnt=1, this=0x361e17e0)
             at sw/inc/crsrsh.hxx:379
         #5  SwEditShell::SetExtTextInputData(CommandExtTextInputData const&) ()
             at sw/source/core/edit/editsh.cxx:1019
         #6  0x00007fe9a13e7dad in SwEditWin::Command(CommandEvent const&) ()
             at sw/source/uibase/docvw/edtwin.cxx:5932
         #7  0x00007fe9b02806fb in ImplCallCommand(VclPtr<vcl::Window> const&, CommandEventId, void const*, bool, Point const*) ()
             at include/rtl/ref.hxx:203
         #8  0x00007fe9b0285bb1 in ImplHandleExtTextInput (nCursorFlags=<optimized out>, nCursorPos=<optimized out>, pTextAttr=<optimized out>, rText=..., pWindow=<optimized out>)
             at include/vcl/vclreferencebase.hxx:37
         #9  ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) () at vcl/source/window/winproc.cxx:2855
         #10 0x00007fe9b0271355 in vcl::Window::PostExtTextInputEvent(VclEventId, rtl::OUString const&) ()
             at vcl/source/window/window.cxx:2098
         #11 0x00007fe9af195bd9 in (anonymous namespace)::LOKPostAsyncEvent(void*, void*) ()
             at sfx2/source/view/lokhelper.cxx:1209
        
        Change-Id: I4f1699b8ed7a7797d6dfabc05c500370c24e0976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185930
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e70cccc17cf1dbe8ff658617ac348bd0a981abc5]

        Hanlder->Handler
        
        Change-Id: I5a2a2158bd4c5bf33441bb083129f9b3f8cc069e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [61eb2261e187989178f660abd42b6d6fa0d34f22]

        add an eot fuzzer
        
        Change-Id: I419c3717f168e3bfbdbee2ac4b6b2f1eb2540bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185887
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [95b9691da797bc5bef17ce67dcfe69766ccf95ba]

        nss: upgrade to 3.112
        
        Downloaded https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_112_RTM/src/nss-3.112-with-nspr-4.36.tar.gz
        
        Change-Id: I755d5e89868870237ba3f7d04a9ec23e11fbba04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185928
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca0b6c3e223273d75dcd90f1c419e37abf6311e6]

        if nTextLen is 0 this loop never ends
        
        seen in crash report as:
        
        [ admin ] ERR  Aborted resource consuming doc | wsd/AdminModel.cpp:802
        
        program/libuno_sal.so.3
        	void rtl::str::stringbuffer_insert<_rtl_uString, char16_t>(_rtl_uString**, int*, int, char16_t const*, int)
        		sal/rtl/strtmpl.hxx:1262
        program/../program/libswlo.so
        	SwEditWin::RequestHelp(HelpEvent const&)
        		sw/source/uibase/docvw/edtwin2.cxx:464
        program/libmergedlo.so
        	(anonymous namespace)::LOKPostAsyncEvent(void*, void*)
        		sfx2/source/view/lokhelper.cxx:1203
        program/../program/libswlo.so
        	SwXTextDocument::postMouseEvent(int, int, int, int, int, int)
        		include/rtl/ref.hxx:125
        program/libmergedlo.so
        	doc_postMouseEvent
        		desktop/source/lib/init.cxx:5595
        
        Change-Id: I43b33ec0ac29ea1a8bb02ec58d3191b0b8d3d7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185916
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b62b122cfed6b864f9dd613bd238474ad99dafe]

        sanity check NameRecords
        
        may also fix cid#1646781 Untrusted loop bound
        
        Change-Id: I3ddb44de3ba45a3654400014bf19a4b202a68325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185909
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5785b8f8363f62adc3c9f144c8309a69f26bb77]

        Revert "poppler: avoid more std::ranges afer update to 25.04.0"
        
        This reverts commit 8cdbe3666440f81aa71539e8d38d5a93eec17b26.
        
        Reason for revert: build baseline was bumped so the workaround is not needed anymore
        
        Change-Id: I551ba5d4fbfb786f748fd603e48d715962ea9847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185910
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cae28bbd3c9504f25a2910c5c75498d17fd618df]

        sanity check NameTable
        
        Change-Id: I8eba80747511ac3114676be486337183315890e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185903
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6f2f0744e1595cbe7bb03933f71e7dbb5e06174]

        sanity check table offsets and claimed lengths
        
        Change-Id: I9c9f3b5f3efcecbe12f6a8ad08455e1f18e6a642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185900
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d573d3c70f356f256d91401f81c7766ff5097b2e]

        FuPoor: pass SdDrawDocument by ref
        
        Change-Id: I75701740a24ad64f7a491937991eacf0c733d37e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185906
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72292a7e87b7970401ffb4762a40177f65d22989]

        ofz#420267110 sanitize anchor for InsertFlyFrame too
        
        Change-Id: If3b5e037428b3e860648b978195b1e6c3b95fcec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185897
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [65fdd33cc49a667d3e212163fde99e3ce7433ab5]

        sanity check and clip number of records possible
        
        Change-Id: I5c6ded1087302aa9fe4bbe1ee252964a266f6957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185896
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ffcdff2ff40124c58249f4a1219430610db7567f]

        tdf#166746: pip: include .exe files
        
        Change-Id: Ia4648ba2f51a1e04b1397bcde5e8321955854ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185907
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f974edd5f7f18152a6c8ba29778a28469289b6df]

        Guard concurrent access of TimerManagerImpl::m_pImpl
        
        ...which was found to be a potential issue while inspecting
        011760896551817d4fe8018214eff6d011bb385a "Timer - shutdown and re-start
        salhelper::Timer thread." and its follow-up
        c6c8e1c325f22039bbd709085eaa4d95ffa22192 "don't return impl by shared_ptr"
        
        Change-Id: I6a515b3b3c84a3010d90d115c801f2e5cbcc245a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185894
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-27  Jonathan Clark  <jonathan@libreoffice.org>  [a7f0e7b40fff2238a5cb2bfac750b22d8d5ee15d]

        tdf#147299 vcl: Set Microsoft ja IME to vertical mode in vertical text
        
        Fixes a Windows IME integration bug causing the Microsoft Japanese IME
        to display inappropriately rotated text or overlap the composition
        string when the text direction is vertical.
        
        Windows IMEs do not expose an explicit option to enable vertical
        writing. Instead, this mode is set by providing a font face with a
        leading '@' sign. This behavior is not documented, but is long-standing
        and is the standard convention on Windows in other contexts.
        
        Change-Id: I9ebe45cf2c48b5f175d369daaa891f86fdc77c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185870
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-05-27  Miklos Vajna  <vmiklos@collabora.com>  [b6cba0119f8028b426f5eee55be9761971dbfdee]

        tdf#166319 sw interdependent redlines: handle reject of ins-then-fmt's fmt
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins> in it, rejecting the
        BB part resulted in <ins>AA</ins>BB<ins>CC</ins>, while the expected
        result would be to reject the underlying insert of BB.
        
        The problem is that the reject code is not aware that the format has an
        underlying insert, so the format gets rejected, and as a side effect the
        insert redline is gone, too.
        
        Fix this by extending sw::DocumentRedlineManager::RejectRedlineRange()
        to recognize this insert-then-format case: act like rejecting the
        insert, not like rejecting the format.
        
        The surrounding plain inserts are not yet rejected, though. Also update
        extend sw doc model xml dump code that was useful to see while working
        on this.
        
        Change-Id: I6718b9c306239837392ae7cd3f0d28aef6b4f71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185891
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-27  Jonathan Clark  <jonathan@libreoffice.org>  [08a3854ba355c511a8098b64a8346dda614ea630]

        tdf#155158 vcl: Fix IME composition not ending on end comp message
        
        This change updates our Windows IME integration to gracefully handle the
        case where the IME sends a WM_IME_ENDCOMPOSITION message to terminate
        composition without sending a final WM_IME_COMPOSITION message.
        
        Change-Id: I97f8cacaec318d613f42cdc668f13841d9ff23eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185901
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-05-27  Laurent Balland  <laurent.balland@mailo.fr>  [edd0991c3cc1c5ae439e33873c2567ee62d0e710]

        Rezing SdrObject: Remove duplicate code
        
        SdrTextObj::ImpDragCalcRect and SdrObject::ImpDragCalcRect are almost duplicate
        This patch creates an inherited function to avoid duplicate code
        
        Change-Id: I9a9abfeb1fa176e59c1d30b4530781268d84fcb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184931
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7729d6339552fd48e75bf92ebee8742ff91e2e82]

        bump minimum Xcode version to 14.3 (and that in turn requries macOS 13)
        
        The old Xcode version just doesn't support newer c++ features like
        std::ranges and similar that some externals and now also some parts in
        core start using.
        We don't have any CI bots building on that old platform anymore, and
        bumping the build-requirement doesn't affect the runtime requirements.
        
        So instead of stacking on workaround after workaround for an OS that
        already reached EOL, just drop support for building on it.
        
        (see also https://developer.apple.com/xcode/cpp/ )
        
        Change-Id: I340180f32c195547a1f93d271e5bbc59252198e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185895
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dee87890e57c5caa076e8fd3ab8567173d28062b]

        sanity check on TableDirectory length
        
        Change-Id: Ibaa2fa09114db3dde97eaa93085718711eb676eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  David Hashe  <me@dhashe.com>  [79e63a2d07758097816ed09c20f21dd2dc450e2d]

        tdf#60700 stop creating empty Configurations2/accelerator in ODFs
        
        This change stops the creation of empty Configurations2/accelerator
        dirs on new documents that do not have anything that needs to be stored
        there. Previously, LibreOffice would always create this directory.
        
        Whenever an XStorage is opened readwrite on a path, it will immediately
        create that path. LibreOffice was opening all of these paths readwrite.
        So, the solution is to always open these paths as readonly, and then
        when we need to write data to them we close them and re-open them as
        readwrite. If we never need to write data to a path, then it won't be
        created.
        
        This patch specifically stops the creation of subdirectories that were
        being created by DocumentAcceleratorConfiguration.
        
        Other patches in the relation chain handle paths created by
        UIConfigurationManager and ImageManager.
        
        Test coverage was added in b9054fed3724a19479e221a8b4818a127a18aabe
        
        $ CPPUNIT_TEST_NAME="Test testTdf60700_accelerators" make CppunitTest_sw_odfexport
        
        As far as I can tell, there is no way to actually attach custom
        accelerators to a document at this time using the UI, so I did not do
        any manual testing for this change.
        
        (The closest thing to storing accelerators in the document is the work
        from 65d2c9ca4d930bd9352e0b51f45e163cf4393241, but the macros don't
        yet continue to work when you save the document in ODF)
        
        With this change, a fresh document looks like this:
        
        $ unzip -l Untitled\ 1.odt
        Archive:  Untitled 1.odt
          Length      Date    Time    Name
        ---------  ---------- -----   ----
               39  2025-05-17 15:57   mimetype
                0  2025-05-17 15:57   Configurations2/
            12645  2025-05-17 15:57   styles.xml
              899  2025-05-17 15:57   manifest.rdf
             3563  2025-05-17 15:57   content.xml
              866  2025-05-17 15:57   meta.xml
            14745  2025-05-17 15:57   settings.xml
              318  2025-05-17 15:57   Thumbnails/thumbnail.png
             1061  2025-05-17 15:57   META-INF/manifest.xml
        ---------                     -------
            34136                     9 files
        
        Change-Id: I5e032d55e94114333ea7778afcc3df0fefe0a30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  David Hashe  <me@dhashe.com>  [0e5981487a480e850b1a3259b5de462d9e17823a]

        tdf#60700 stop creating empty Configurations2/images in ODFs
        
        This change stops the creation of empty Configurations2/images dirs
        on new documents that do not have anything that needs to be stored
        there. Previously, LibreOffice would always create this directory.
        
        Whenever an XStorage is opened readwrite on a path, it will immediately
        create that path. LibreOffice was opening all of these paths readwrite.
        So, the solution is to always open these paths as readonly, and then
        when we need to write data to them we close them and re-open them as
        readwrite. If we never need to write data to a path, then it won't be
        created.
        
        This patch specifically stops the creation of subdirectories that were
        being created by ImageManager.
        
        Other patches in the relation chain handle paths created by
        UIConfigurationManager and DocumentAcceleratorConfiguration.
        
        Test coverage was added in b9054fed3724a19479e221a8b4818a127a18aabe
        
        $ CPPUNIT_TEST_NAME="Test testTdf60700_images" make CppunitTest_sw_odfexport
        
        I also manually tested with the following procedure:
        
        1. Open a new document in writer.
        2. Tools > Customize > Toolbars.
        3. Set scope to "Untitled 1".
        4. Add a new toolbar "New Toolbar 1".
        5. Add any command from Available Commands to the new toolbar.
        6. Add any icon
        7. OK.
        8. Visually verify that the toolbar is present with the custom icon.
        9. Save the document.
        10. Verify that the custom icon is saved correctly inside the file.
        
        $ unzip -l Untitled\ 1.odt
        
        Archive:  Untitled 1.odt
          Length      Date    Time    Name
        ---------  ---------- -----   ----
               39  2025-05-17 16:01   mimetype
              353  2025-05-17 16:01   Configurations2/toolbar/custom_toolbar_cba48a4e.xml
              444  2025-05-17 16:01   Configurations2/images/lc_imagelist.xml
              469  2025-05-17 16:01   Configurations2/images/Bitmaps/lc_userimages.png
                0  2025-05-17 16:01   Configurations2/accelerator/
            13358  2025-05-17 16:01   styles.xml
              899  2025-05-17 16:01   manifest.rdf
             3771  2025-05-17 16:01   content.xml
             1011  2025-05-17 16:01   meta.xml
            14746  2025-05-17 16:01   settings.xml
              318  2025-05-17 16:01   Thumbnails/thumbnail.png
             1406  2025-05-17 16:01   META-INF/manifest.xml
        ---------                     -------
            36814                     12 files
        
        10. Close and reopen the document.
        11. Visually verify that the toolbar with the custom icon is present.
        
        Change-Id: I48b2b8f540f7640ae25da6f27065e7b07f955c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185450
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8cdb6cf9a95f068d465a7fc36316f1c84547dcf8]

        crash seen with dialog open when frame closed
        
        program/libmergedlo.so
        	vcl::Window::SetParent(vcl::Window*)
        		include/rtl/ref.hxx:205
        program/libmergedlo.so
        	weld::MessageDialogController::~MessageDialogController()
        		vcl/source/app/weldutils.cxx:83
        program/libmergedlo.so
        	std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use_cold()
        		/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:175
        program/libmergedlo.so
        	std::default_delete<DialogImpl>::operator()(DialogImpl*) const [clone .part.0]
        		/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/shared_ptr_base.h:354
        program/libmergedlo.so
        	Dialog::dispose()
        		vcl/source/window/dialog.cxx:623
        program/libmergedlo.so
        	UnoWrapper::WindowDestroyed(vcl::Window*)
        		include/rtl/ref.hxx:126
        program/libmergedlo.so
        	vcl::Window::dispose()
        		include/com/sun/star/uno/Reference.h:102
        program/libmergedlo.so
        	VCLXWindow::dispose()
        		include/rtl/ref.hxx:126
        program/libmergedlo.so
        	(anonymous namespace)::XFrameImpl::disposing()
        		include/vcl/svapp.hxx:1351
        program/libuno_cppuhelpergcc3.so.3
        	cppu::WeakComponentImplHelperBase::dispose()
        		cppuhelper/source/implbase.cxx:104
        program/libmergedlo.so
        	(anonymous namespace)::XFrameImpl::close(unsigned char)
        		include/com/sun/star/uno/Reference.hxx:113
        
        Change-Id: I60870d7b47fe91a15c67a0583cb413cfdfff7bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185890
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-27  David Hashe  <me@dhashe.com>  [b77f1d103cd3a800eef0b71456fdc7c28799af65]

        tdf#48140 Fixup variable name for an rtl::Reference
        
        Very minor, non-functional followup change to
        277364ed05e0340ac0affbe7743e209d4d36c0a1
        
        I had named an rtl::Reference<ScCellRangeObj> with
        rCellRangeObj when it is preferred to use xCellRangeObj.
        
        Change-Id: I6950fd3e40774f4c2a58b169116a30cfd3cccc96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185867
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-05-27  Michael Weghorn  <m.weghorn@posteo.de>  [371c20f3dcc6fe9262765cab6b570f1736b3d8e1]

        tdf#130857 qt weld: Notify about tree view toggle change
        
        Call weld::TreeView::signal_toggled when the
        toggle button inside of a QtInstanceTreeView
        column gets toggled.
        
        To do that, connect to the QSortFilterProxyModel::dataChanged
        signal and handle the case where the Qt::CheckStateRole
        has changed.
        
        For now, only signals for a single changed item
        are implemented and others trigger an assert.
        Support for multiple changed items at once should
        however be relatively straightforward to implement
        if the need arises, by iterating over all
        model indices between `rTopLeft` and `rBottomRight`.
        
        The new helper QtInstanceTreeView::externalColumnIndex
        gives the column index as used in the weld::TreeView API,
        i.e. logically does the opposite of
        QtInstanceTreeView::modelIndex to hand the special column
        index of -1 used for the extra toggle button column.
        
        With this commit in place, the toolbars in the
        "View" -> "User Interface" dialog's new "Toolbars" tab page
        introduced in
        
            commit 4ab26f4ea0c627844531144a6a903c357a604a5e
            Date:   Mon May 26 12:03:40 2025 +0200
        
                Resolves tdf#158880 - Let users select multiple toolbars at once
        
        become visible/invisible as expected when toggling
        their status by clicking on the checkbox when using
        the qt6 VCL plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: Iff2fb77bfb226bd2234bb176fd00a8b9b6be7b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185885
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-27  Michael Weghorn  <m.weghorn@posteo.de>  [badce2cebc3c37f51254dc036d7c0a4601187f43]

        tdf#130857 qt weld: Support new toolbar tab page
        
        Declare support for the "View" -> "User Interface"
        dialog's new "Toolbars" tab page introduced in
        
            commit 4ab26f4ea0c627844531144a6a903c357a604a5e
            Date:   Mon May 26 12:03:40 2025 +0200
        
                Resolves tdf#158880 - Let users select multiple toolbars at once
        
        in QtInstanceBuilder. This makes the content of
        that tab page show up when using the qt6 VCL
        plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        The toolbar visibility does not yet get toggled when
        (un)checking the corresponding checkbox, but that
        will be implemented in an upcoming commit.
        
        Change-Id: I3d0f4ec98c551a11c210f02800ef6d940aba96fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185884
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-27  Michael Weghorn  <m.weghorn@posteo.de>  [8190aefd1ff80fb8679febdadca784f551bf6f08]

        tdf#130857 qt weld: Implement QtInstanceTreeView::get_iter_index_in_parent
        
        This is used in the "View" -> "User Interface"
        dialog's new "Toolbars" tab page introduced in
        
            commit 4ab26f4ea0c627844531144a6a903c357a604a5e
            Date:   Mon May 26 12:03:40 2025 +0200
        
                Resolves tdf#158880 - Let users select multiple toolbars at once
        
        , so support it in preparation of declaring support
        for that tab page in an upcoming commit.
        
        Change-Id: If31f1b920d106432760d5b521f2dde02306c79f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185883
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-27  Michael Weghorn  <m.weghorn@posteo.de>  [bd2f38c919b9dbf8f89ab72c226e598741981f6c]

        tdf#130857 cui: Use separate columns in toolbar tab page
        
        Use a separate GtkTreeViewColumn for each of the
        cell renderers in the "View" -> "User Interface"
        dialog's new "Toolbars" tab page introduced in
        
            commit 4ab26f4ea0c627844531144a6a903c357a604a5e
            Date:   Mon May 26 12:03:40 2025 +0200
        
                Resolves tdf#158880 - Let users select multiple toolbars at once
        
        The weld::TreeView API also uses separate columns,
        and the Qt implementation in QtInstanceTreeView relies
        on those also being separate columns in the .ui file.
        
        This prepares for declaring support for that tab
        page in QtInstanceBuilder in an upcoming commit.
        
        Change-Id: I2f73518e17a34f22b79b563af7ec818692f3edb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185882
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [22ab2bec717b44e85e110cd67175c2f3599264c2]

        mac: add parent launch-constraint to packaged framework/helpers
        
        except for unopkg since that is meant to be used to install/manage
        extensions from the commandline
        
        Change-Id: I8bf60777bc0f4f9d814a4f7e1e12eacbc8803e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185792
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed36fc7e3f248a36e2fcce8324e10176a73fdd7f]

        ScFormEditData: pass ScDocShell by ref
        
        Change-Id: I49c116f2aacb34e49b92d53b7e9c43dc3a531581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185886
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-27  Miklos Vajna  <vmiklos@collabora.com>  [63ac5cadc8e594a7c440b410d747dfb37791c34a]

        svx: prefix members of OLEObjCache
        
        See tdf#94879 for motivation.
        
        Change-Id: Ifdf360fed1567065ed5efe819aa2aa890f90f179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185876
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-27  Miklos Vajna  <vmiklos@collabora.com>  [2292bda37378d7f782abbda42c026affd3fa59e5]

        tdf#166319 sw interdependent redlines: combine on accept of ins-then-fmt's fmt
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins> in it, accepting the
        "BB" part resulted in a format-only redline in the middle (good), but
        "AA" and "CC" wasn't accepted, as expected.
        
        The first trouble was that SwRedlineTable::getConnectedArea() calling
        lcl_CanCombineWithRange() considered combining AA with BB when the
        cursor was at AA, but it didn't consider combining BB with AA when the
        curor was at BB. There doesn't seem to be a reason why combining one
        type with the underlying type of a next redline should be only done in
        one direction, so allow both directions. With this, at least
        AcceptRedlineRange() gets the right redline indexes, so it considers the
        two surrounding redlines.
        
        The other trouble was that DocumentRedlineManager::AcceptRedlineRange()
        only tried to combine a redline with 1 type together with an other
        redline with 2 types (assuming that perhaps the 2nd/underlying type is a
        match), and didn't try to combine a redline with 2 types with an other
        redline with 1 type. Allow that case at least for the insert vs
        insert-then-format case when the cursor is at the insert-then-format
        redline.
        
        The reject of insert-then-format's format is still broken, though.
        
        Change-Id: Ic8ab03e9cd2c24506cf98c5e82c09464eab8f6b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185878
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6c8e1c325f22039bbd709085eaa4d95ffa22192]

        don't return impl by shared_ptr
        
        Thread 1 exits, and TimerManagerImpl dtor reduces its m_pImpl shared_ptr of
        TimerManager to use_count 0 triggering dtor of its contents. That dtor
        waits for Thread 2 to join.
        
        Thread 2 calls checkForTimeout which calls TimerManagerImpl::unregisterTimer.
        whose m_pImpl is still set, but with a use_count is 0. Return by value
        results in a temp std::shared_ptr of use_count 0 which on going out of scope
        triggers a second dtor of m_pImpl.
        
        Work around this by not returning a shared_ptr.
        
        Thread 1 (Thread 0x7ffff7ab5100 (LWP 3274153) "cppunittester"):
         #0  0x00007ffff71509a4 in salhelper::TimerManager::~TimerManager (this=0x508000000da0) at salhelper/source/timer.cxx:269
         #1  0x00007ffff71548c0 in std::_Sp_counted_ptr<salhelper::TimerManager*, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:428
         #2  0x00007ffff7153d11 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:346
         #3  0x00007ffff7153b56 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (this=0x7ffff715edd8 <(anonymous namespace)::getTimerManager()::aManager+56>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:1069
         #4  0x00007ffff7154559 in std::__shared_ptr<salhelper::TimerManager, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (this=0x7ffff715edd0 <(anonymous namespace)::getTimerManager()::aManager+48>) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:1525
         #5  0x00007ffff7153ae5 in std::shared_ptr<salhelper::TimerManager>::~shared_ptr (this=0x7ffff715edd0 <(anonymous namespace)::getTimerManager()::aManager+48>) at /usr/bin/../lib/gcc/x--Type <RET> for more, q to quit, c to continue without paging--
         86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr.h:175
         #6  0x00007ffff7152759 in (anonymous namespace)::TimerManagerImpl::~TimerManagerImpl (this=0x7ffff715eda0 <(anonymous namespace)::getTimerManager()::aManager>) at salhelper/source/timer.cxx:62
         #7  0x00007ffff7651641 in __run_exit_handlers () from /lib64/libc.so.6
         #8  0x00007ffff765170e in exit () from /lib64/libc.so.6
         #9  0x00007ffff763808f in __libc_start_call_main () from /lib64/libc.so.6
         #10 0x00007ffff763814b in __libc_start_main_impl () from /lib64/libc.so.6
         #11 0x00000000004314e5 in _start ()
        
        Thread 2 (Thread 0x7fffe6fff6c0 (LWP 3274156) "salhelper::Time"):
         #0  salhelper::TimerManager::~TimerManager (this=0x508000000da0) at salhelper/source/timer.cxx:269
         #1  0x00007ffff71548c0 in std::_Sp_counted_ptr<salhelper::TimerManager*, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:428
         #2  0x00007ffff7154024 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:175
         #3  0x00007ffff7153fb5 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use_cold (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:199
         #4  0x00007ffff7153f6b in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (this=0x503000001060) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:353
         #5  0x00007ffff7153b56 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (this=0x7fffe58ff268) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:1069
         #6  0x00007ffff7154559 in std::__shared_ptr<salhelper::TimerManager, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (this=0x7fffe58ff260) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr_base.h:1525
         #7  0x00007ffff7153ae5 in std::shared_ptr<salhelper::TimerManager>::~shared_ptr (this=0x7fffe58ff260) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/shared_ptr.h:175
         #8  0x00007ffff714fa2c in (anonymous namespace)::TimerManagerImpl::unregisterTimer (this=0x7ffff715eda0 <(anonymous namespace)::getTimerManager()::aManager>, pTimer=0x50d0000001e0) at salhelper/source/timer.cxx:100
         #9  0x00007ffff714f4b5 in salhelper::Timer::stop (this=0x50d0000001e0) at salhelper/source/timer.cxx:159
         #10 0x00007ffff714f465 in salhelper::Timer::~Timer (this=0x50d0000001e0) at salhelper/source/timer.cxx:143
         #11 0x00007ffff7172912 in (anonymous namespace)::TestTimer::~TestTimer() () from workdir/LinkTarget/CppunitTest/libtest_salhelper_testapi.so
         #12 0x00007ffff7172939 in (anonymous namespace)::TestTimer::~TestTimer() () from workdir/LinkTarget/CppunitTest/libtest_salhelper_testapi.so
         #13 0x00007ffff714ea88 in salhelper::SimpleReferenceObject::release() () from instdir/program/libuno_salhelpergcc3.so.3
         #14 0x00007ffff7151be0 in salhelper::TimerManager::checkForTimeout (this=0x508000000da0) at salhelper/source/timer.cxx:410
         #15 0x00007ffff7152189 in salhelper::TimerManager::run (this=0x508000000da0) at salhelper/source/timer.cxx:444
         #16 0x00007ffff714f109 in threadFunc () from instdir/program/libuno_salhelpergcc3.so.3
         #17 0x00007ffff7dbbc31 in osl_thread_start_Impl(void*) () from instdir/program/libuno_sal.so.3
         #18 0x00000000004c84ed in asan_thread_start(void*) ()
         #19 0x00007ffff76a6088 in start_thread () from /lib64/libc.so.6
         #20 0x00007ffff7729f8c in clone3 () from /lib64/libc.so.6
        
        Change-Id: I761ca9db12738415aa0eca386956c762b42b28d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185868
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-27  Szymon Kłos  <szymon.klos@collabora.com>  [e146daf4111a1f68f55b178faf4410c83d8faf7c]

        jsdialog: support disable/enable per container
        
        if we have frame which is dynamically enabled or disabled
        - we update state of all widgets inside.
        
        we need to send update not simple action for jsdialog now
        as client will only update the witget with mentioned id
        not full structure below
        
        this also uses more detailed type for Position and Size tab in Impress
        frames to not use generic Widget wrapper and target with this bigger
        update
        
        Change-Id: I973cb959e8f6add40df53ea6e523424ce8bca1ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185791
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit e7fb2df1f8ff80753c9f336a9cf81ca56695b1a8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185874
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [52e3b2b040ac54c2a5661e3676b135170f028f50]

        ScViewData: simplify constructors
        
        After
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        Change-Id: Ifc661f7e5c841fb017003af53e357218f0aff3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185803
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [335d23999d7210d310287e143a725a805233d1d8]

        ScDrawTransferObj: pass ScDocShell by ref
        
        After
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        Change-Id: I346b5576e31acf8d08de9423558a7ad405a6385e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185869
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [c008f158021ce9cb36f82650103e9249117dd86c]

        Drop WorksheetHelper::getScDocument
        
        WorksheetHelper publicly inherits from WorkbookHelper; and that
        has getScDocument as both const and non-const public member function.
        
        WorkbookHelper::getScDocument variants were introduced in commits
        3043cc87ad5570eaea404f220e42547b5efa7713 (some performance improvements,
        2012-03-28) and 835fee82efb70b40b94f6babc2706ee1eb66dcf7 (Populate raw
        cell values using ScDocumentImport., 2013-11-04).
        
        WorksheetHelper::getScDocument was introduced in commit
        f2f5d74067705b7c64f8fb510952d7cece417627 (tdf#129228 speedup load xls
        file with lots of comments, 2019-12-20).
        
        Change-Id: I755c1d721c2c366c6554b9a96161efc7e2056d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185871
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-27  Szymon Kłos  <szymon.klos@collabora.com>  [de5bd835b81735f5627586bd1efb677d99921eba]

        tdf#161365 xlsx export: checkbox checked property in vmlDrawing.xml
        
        preserve also the checked state while saving
        
        Change-Id: Ibf7e464d952a57c6b52cc74420aa15b24aa0a5d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185872
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-05-27  Szymon Kłos  <szymon.klos@collabora.com>  [2b80f245298fe59e4d467d64e82425583d60549a]

        Apply none fill style for transparent fill color
        
        This is followup for commit df8941ee5bb375de504f106370f28d7f3c12ab70
        tdf#163805: set fill style to solid on fill color selection
        
        When we have shape in Impress/Draw with solid fill color and we
        then use .uno:FillColor with "-1" (transparent) color, we should
        reset Ffill style to NONE. That makes shape transparent.
        
        Previous commit was doing something opposite: add SOLID style
        when color is used.
        
        Change-Id: I72bc8a81bc75941f337ed68125536f771c3e7d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184961
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185808
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d52b5b08952685d31902cc2ec37c50ec04d6f83]

        cui: fix warning C6013: Dereferencing NULL pointer 'Current()'
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/cui/source/dialogs/toolbartabpage.cxx(110): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\cui\source\dialogs\toolbartabpage.cxx(45) : warning C6011: Dereferencing NULL pointer 'Current()'. : Lines: 45, 41, 43, 45
        make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/solenv/gbuild/LinkTarget.mk:338: C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/workdir/CxxObject/cui/source/dialogs/toolbartabpage.o] Error 2
        make[1]: *** Waiting for unfinished jobs....
        
        after
        commit 4ab26f4ea0c627844531144a6a903c357a604a5e
        Author: Heiko Tietze <tietze.heiko@gmail.com>
        Date:   Mon May 26 12:03:40 2025 +0200
        
            Resolves tdf#158880 - Let users select multiple toolbars at once
        
        Change-Id: I54375b705e332d49b7635dc257ff20e9f61d3f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185859
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [994d15796a40e42003facd64714c04f7288681e2]

        Fix reference in comment
        
        Change-Id: I8cd2005c1bb34f90e4739b768c6ea2630c6632d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185814
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [499edcd805b58d5922463b64f345d576c2347558]

        ScPrintFunc, ScPrintFuncCache: pass ScDocShell by ref
        
        Change-Id: If71f61c9b5e75e4035c6066fe07aeb747a3d08bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185811
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1152da8289e5979063d0718bd23c9560197e9c0f]

        ScSizeDeviceProvider: pass ScDocShell by ref
        
        fter
        commit d8ab8992bd35aedfc1d2b0debebab0d623aa8d09
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon May 26 11:06:06 2025 +0200
        
            ScViewData: pass ScDocShell by ref
        
        Change-Id: Iea78d6d1dab657a0b526d58dd8519873c43ae272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185809
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0dd1c4a363b9d4d2a16ff82acc3ada0c075cb65]

        tdf#166445 highlight bug
        
        So we revert two commits here
            commit cadfb0db14c6ff96688259b8a1eeb8615a2f8a49
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 10 13:20:24 2025 +0200
            tdf#165080 Background color cells are reset to white
        
        and
            commit 2d208c4e42595bb85fd0ef726a89e10dd32b48b1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 25 09:03:49 2024 +0200
            tdf#161210 speed xls load
        
        And go with a simpler change in XclImpXFRangeBuffer::SetRowDefXF
        which seems to preserve most of the performance benefits without
        the drawbacks
        
        Change-Id: I2456e122146c4f0bb6763e18fca996bbbab17023
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [28b1b9af5e1388940b4c59503092c0f804e4bac6]

        Emscripten: Move execute_browser to the browser main thread
        
        ...so that it can reference the JS `window` object (e.g., when clicking on "Help
        - About LibreOffice - Credits")
        
        Change-Id: Ia08226af7bbf5a503be9e0b81c27217ad2775269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185801
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-05-26  Heiko Tietze  <tietze.heiko@gmail.com>  [4ab26f4ea0c627844531144a6a903c357a604a5e]

        Resolves tdf#158880 - Let users select multiple toolbars at once
        
        Tab added to the UIPicker aka ToolbarModeDialog showing
        all toolbars likewise in the main menu
        
        Change-Id: I71d52ca88dc14012a70911c20f9252e578798a74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185788
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8ab8992bd35aedfc1d2b0debebab0d623aa8d09]

        ScViewData: pass ScDocShell by ref
        
        After this change, testTdf159174 started to fail.
        Move the fix introduced in
        
        commit 0b93cc83993b3cd78aa05556342839a21c96dc5a
        Author: Mike Kaganski <mike.kaganski@collabora.com>
        Date:   Sun Jan 14 12:16:48 2024 +0600
        
            tdf#159174: there may be no tabs in the clipboard document
        
        to the caller in ScTransferObj::PaintToDev
        
        Change-Id: I770305dd0e1ac31f897ddcf4209f7aba1387f8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185786
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-26  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b4460d983401e0b5962f71159016209e2d74d095]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af2f7973d5fc5bbf5cd99cc02a450783d34096ea
          - tdf#166353 Simplify getting current language, don't use en-US fallback
            
            As en-US might not be installed offline, this was not a working approach.
            
            The XSLT to HTML generator makes sure the html element has a language
            attribute, so just read that.
            
            Change-Id: I2b2857ac7ddd5e056ebb7fbb74f782abf58ed229
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185211
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-26  Henry Castro  <hcastro@collabora.com>  [bb0b7fc3a3fd7be3b9adad6a16d2efc299d0b44c]

        accessibility: remove the colon (:) from the label of the Column.
        
        "Screen readers detect both labels, but the column number is read directly before the
        value (e.g., "2.18"), which can give users with screen readers the
        impression that the value is something like "12.18." This is misleading."
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I7ce2a638065cbec0fe55613a81eb6f1db3dee333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184496
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185606
        Tested-by: Jenkins

2025-05-26  Noel Grandin  <noelgrandin@gmail.com>  [1f61a2ec4e252d2eeccabd65a10650c8ee231a1b]

        tdf#166715 speed up transparent fill operation
        
        Transparent bitmapex drawing works fine these days, so we dont
        need this fallback path anymore.
        
        Dramatically speeds up rendering on most backends (the cairo drawinglayer renderer already has an optimised path here).
        
        Change-Id: Ic66a4f2d76a6815d1cb3a439e416f1235be7a544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-26  Rashesh  <rashesh.padia@collabora.com>  [26b62622ae849781ff6bec47298fba56245989bc]

        tdf#166689: sw: only hide "Add To Dictionary" option when using LOKit
        
        Change-Id: I49be5595dc2fa01ddb10d4a280448a1449eab04d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185743
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        (cherry picked from commit b7b0cbfafeb9d5b7d49a71cbaea7fd8419be68c5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185771
        Tested-by: Jenkins

2025-05-26  Rashesh  <rashesh.padia@collabora.com>  [2167fa8aa5592e04a929cde2cd86a07bad49efde]

        tdf#166674: sc: fix "Name box" remain switched to "Last Used Function List"
        
        Change-Id: I68f46ec54c9a2b6cdaa04b27d02f3c01ebd4f2b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185747
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 86579c2f816e8b77c75c17f25bda47a2312f23da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185776
        Tested-by: Jenkins

2025-05-26  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [0957ec405757ad72d2e1fe4ceed4ac486b27aa21]

        CairoSDPR: Correct BackgroundColorPrimitive2D when Viewport set
        
        If the BackgroundColorPrimitive2D has a Viewport set this means
        we have limitations, so render as needed/defined. This can be
        done additionally by creating geometry for that range, or just
        use the decomposition. To do so, just use recursion/decompose
        in this case.
        
        Change-Id: I85fe6eb78fe8d154ced99d53af40ba0d9f1049d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185718
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [27825fca1dd04b71ade7709fa06eca71a123cc36]

        tdf#161372 Spreadsheets with comments are unreasonably slow
        
        no need to instantiate invisible comments in this case,
        reduces column deelete time down to a couple of seconds
        
        Change-Id: I79cca144918d2ac36d902e2cda3ed8f962c2198a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [af51efd5c26d5d8f6bc02756b25cd525f5b1ff6b]

        don't probe meson with "python meson runpython --version"
        
        runpython is internal flag that's not supported in all versions, and was
        used to prevent testing "python --version" in case MESON was empty, but
        that's now checked for explicitly, so that can be removed.
        
        Also fix logic error when selecting pyuno python version / the one that
        has the final say on what python will be used for the build. Skipping
        the version bump to 3.7 or later when PYTHON_FOR_BUILD was already set
        just nullifies the earlier check wrt harfbuzz/whether meson is needed.
        
        Change-Id: I50bb74a806f8c48d91e12616b69e64c2caa4e7be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185754
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0bf0a1e36d1caca392d8bd2e0e89939162eaa912]

        drop unused vcl::TranslateChar
        
        and its converter cache
        
        Change-Id: Ib8ca08b7b8693cd92a576786e327ff7e63486920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185787
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [c2f3949062eb07e2726b9ae3e05f089cf7b6bbad]

        bCheckPageDescOfNextPage doesn't need pNewPage->GetNext()
        
        Change-Id: I93c177b6ba16a6318a175a45d94cd6df6de8d8fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185782
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [5083bb7c25e52ae5abe3c2766459037d071295d0]

        Drop noise from the comment
        
        Change-Id: I4acfe7453f04ee33fb142aa6dde896d61a583a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185781
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d9f900c9e5466a66b9beeaa0d2b82c22063628a]

        tdf#166684 make ScCondFormatItem hashable
        
        to speed up checking for duplicates. Shaves 3% off load time.
        
        Change-Id: Idea198e69f39eacbb98ab5ef10402e8f376637c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185770
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-26  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [593bf5e35d44ecdac2a046191bb7b36d2ddcf9cd]

        tdf#97228: Remove unused TextAttribProtect
        
        Change-Id: I11d8510ac20967ee1b3d6091d241ce45cc9d9853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183275
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [65ceeb615ccb41d9cc9c41d861ac1ba6777f63e9]

        remove done TODO, lo_trimMemory does this now
        
        Change-Id: I2483705327f4462be920b18fbc2b7effdd4af105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185752
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-26  Mohit Marathe  <mohit.marathe.extern@allotropia.de>  [e887210914951b7b3f72dac5609fb12e4c3319f5]

        tdf#166517 paint borders of frame with zero print area
        
        allow painting borders when text frame in the cell is hidden, but
        the cell is not hidden
        
        (regression from commit 08007b5f0ab0538bb907b99770938bb9f10dba20)
        
        Change-Id: Idc1810d95d6d32a3a9b09486a1581614b5546434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185728
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [8ff115110e62687ee3595b7018587889862739c7]

        vcl a11y: Let ComboBox create its accessible directly
        
        This is the ComboBox equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I8ae7a8a53fa04088ab9130d0905498eb45ad46ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185687
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [01f3de9b220c511155350021819e752285c6290d]

        vcl a11y: Let ScrollBar create its accessible directly
        
        This is the ScrollBar equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I0d8759b699fea20ccf8bea9ec897879f6e3e07b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185686
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [77e753ede1e0227dbe885a0fdf136dd9801d4742]

        vcl a11y: Let FixedText create its accessible directly
        
        This is the FixedText equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: Id3cbc91d6217bbca2d0e770f4fa4813377c10fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185675
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [14eff4a61f39b7145222595668d850883f8665f8]

        vcl a11y: Let FixedHyperlink create its accessible directly
        
        This is the FixedHyperlink equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I2b4f1bd25b4f925bdc7d51948057fbc66c718404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185674
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [528335432757d685a2d69a51488a59eae2198f9b]

        vcl a11y: Let ListBox create its accessible directly
        
        This is the ListBox equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: Ife6382fe72b245b5df2742a17000cf8bb29112b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185673
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [e59f294c0227ee1b67d22cbc34f59f182b8b3a84]

        vcl a11y: Let RadioButton create its accessible directly
        
        This is the RadioButton equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I0bfe50d36250074e21df42ff046a97095b198b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185672
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [2a87fc4d06f8f53112dce3d98d7e166a895104f8]

        vcl a11y: Let CheckBox create its accessible directly
        
        This is the CheckBox equivalent of
        
            Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 22 12:30:12 2025 +0200
        
                vcl a11y: Let PushButton create its accessible directly
        
        , see that commit's message for more background.
        
        Change-Id: I6b6ead743cde3489935a902fed9b63d78fd642f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [f82aac71ede9c3f2dc059ca4c8b24f60e0841933]

        vcl a11y: Let PushButton create its accessible directly
        
        So far, the VCLXButton was the XAccessible implementation
        for PushButton (and subclasses), which got returned in
        Window::CreateAccessible.
        
        VCLXButton's implementation of XAccessible::getAccessibleContext
        was then responsible for creating the XAccessibleContext,
        a VCLXAccessibleButton.
        
        Drop that separation between XAccessible and XAccessibleContext,
        let VCLXAccessibleButton also implement the XAccessible interface
        itself, and override Window::CreateAccessible in
        PushButton to create the VCLXAccessibleButton directly without
        requiring the VCLXButton and AccessibleFactory for this.
        
        This is one step towards unifying the approach for all vcl::Window
        subclasses (some were already creating their accessibles
        directly), makes responsibilities clearer (currently
        shared between vcl::Window and VCLXWindow) and prepares
        for more upcoming a11y changes (towards making
        VCLXAccessibleComponent/OAccessibleComponentHelper implement both,
        XAccessible and XAccessibleContext).
        
        Similar changes for other vcl::Window subclasses will follow.
        
        Internal code previously depending on the fact that a vcl::Window's
        VCLXWindow/XWindow was its XAccessible was adjusted previously in
        commits like
        
            commit b1f3e41f1015f0166dca1382c5fa1d1223f72fb8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 11:03:56 2025 +0200
        
                sw a11y test: Don't rely on XWindow being XAccessible
        
        If this commit causes any issues, there might be
        another place requiring a similar change.
        
        According to the discussion in [1], there might be third-party
        code (unrelated to a11y except for using UNO a11y API) also
        relying on the assumption that the vcl::Window's XAccessible
        is its VCLXWindow, but the UNO a11y API is an internal
        implementation detail explicitly unpublished in
        
            commit 70626249cd247d9acdad417b8eaf252bae22c059
            Date:   Thu Nov 29 00:27:03 2012 +0100
        
                API CHANGE a11y unpublishing and add/removeListener rename.
        
        and has no stability guarantuee whatsoever and is therefore
        not meant to be used by external users. If any third-party
        code was relying on this implementation detail, it should be
        ported away from relying on UNO a11y API.
        
        If there were a desperate need to still be able to
        retrieve the XAccessibleContext via the VCLXWindow/XWindow
        (at least temporarily) somehow, a (temporary) workaround
        once this commit and corresponding upcoming commits are in place
        could be to let VCLXWindow still implement the XAccessible
        interface and return the XAccessibleContext from the window's
        actual XAccessible in VLCXWindow::getAccessibleContext.
        But in my opinion, code relying on that assumption should really
        be adjusted instead, also to avoid breaking again when unpublished
        UNO a11y API changes again in the future.
        
        [1] https://gerrit.libreoffice.org/c/core/+/185597/comments/48aae563_7c620891
        
        Change-Id: If6fa82008f3347c4f95538ab181eaa50c7d9636b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185670
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-26  Szymon Kłos  <szymon.klos@collabora.com>  [02fd0163f55e81f2c0c08c128f055e008ffcfc36]

        tdf#161365 xlsx export: checkbox requires valid anchor to be shown
        
        - checkboxes exported XLSX -> XLSX become invisible in both LO and MSO
        - the file inspection shows we used 0 as a value for all the anchor
          properties (from and to) in both sheet1.xml and drawing1.xml
        - we used maAreaFrom/To which are calculated if XBindableValue
          and SC_SERVICENAME_VALBIND are supported in the control model
          in the XclExpTbxControlObj
        - we can fetch these values directly when saving checkbox form XShape
        - it can be noticed we lack other properties too - for background color,
          to do later as this already makes it usable
        
        Change-Id: Icb833b6943df7d73aad7414f8a115351ea4c7d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185714
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-26  Aron Budea  <aron.budea@collabora.com>  [c55d85888752f128a7d414963c9d7b8787d1fc48]

        tdf#166712 sc: don't export empty dbPr/olapPr elements to connections.xml
        
        Otherwise Excel fails to open the file.
        
        Change-Id: I6eec74c48d20f62a3a75f06a4197ef7ead75b446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185742
        Reviewed-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Tested-by: Jenkins

2025-05-26  Mohit Marathe  <mohit.marathe.extern@allotropia.de>  [3f350a4c0f9a6dd7ee41bbc729d5b3180e21d730]

        tdf#164237 sw: set preferred width of the thread in comments sidebar
        
        Change-Id: I04f879df1b04813b12df1ccaab0e7926a49798f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185749
        Tested-by: Jenkins
        Reviewed-by: Mohit Marathe <mohit.marathe.extern@allotropia.de>

2025-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [67308193f6ee8a21b20043fbd3e831a8c455f40a]

        tdf#165094: do not skip empty page because of wrong page descriptor
        
        The problem was, that the layout process created three pages initially,
        with automatic page break before paragraph 26 (that is controlled by
        SwLayHelper::mnMaxParaPerPage and checked in SwLayHelper::CheckInsert),
        and manual page break before the hidden paragraph; then the paragraphs
        26-45 moved back to page 1; and then the content of page 3 attempted
        to move back. Looking for a page to move to (in SwFlowFrame::MoveBwd),
        it found page 2 as the candidate target; but in SwFrame::WrongPageDesc,
        it concluded that the page 2 can't be used (because of different page
        style, or a difference in even/odd/first format). Thus, that page was
        skipped, the content moved to page 1, effectively ignoring the break.
        
        The check in SwFrame::WrongPageDesc, called from SwFlowFrm::MoveBwd,
        was added in commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 (initial
        import, 2000-09-18). Simultaneously, bCheckPageDescs was set there,
        and the page formats were checked eventually. I think, that skipping
        pages because of wrong page formats is unneeded because of that final
        check; this patch removes the problrmatic conditions.
        
        Change-Id: Ife0b5591c68adb46f7c8fdde0e852e9e326dc38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185751
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3df12b9781daa19eff2b1e30526e65ca2aaa193]

        tdf#166684 avoid O(n^2) loop when importing comments
        
        shaves 5% off load time
        
        Change-Id: I5778b619b859c4090f6d35b1608032148f81795c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-25  Mike Kaganski  <mike.kaganski@collabora.com>  [374dd9fbd660e95a9e6dd09d121c3528c23020a7]

        Unify on VclPtr::reset
        
        We used to have two duplicating sets: smart pointer-like VclPtr::reset,
        and Reference-style VclPtr::set / VclPtr::clear. There is no need in
        this duplication. Further, in ScopedVclPtr, reset is hidden / removed
        to avoid skipping disposeAndClear; but the twin functions are kept
        accessible, possibly as an overlook.
        
        This change drops Reference-style VclPtr::set / VclPtr::clear, and
        unifies on VclPtr::reset, which looks more consistent with the class
        nature (it is closer to shared_ptr, than to uno::Reference). Doing
        that uncovered one place, where a ScopedVclPtr was used incorrectly:
        clear() was used for NotebookbarPopup::m_pParent in NotebookbarPopup
        dtor. I assume then, that the correct class needed here is VclPtr.
        
        Change-Id: I0746075c58d793fabdce1bc357afea8ee455cd8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185553
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-25  Julien Nabet  <serval2412@yahoo.fr>  [00dcdd4716f4695a3c43d49829360d225736e0aa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b9dbcec0f18073dd622b6f759ec154695abc51e
          - Related tdf#166665:  from fi/statistics_data.ods until the end
            
            changes are on ANOVA sheet:
            - remove space in B8
            - remove 26 from B15
            - change B15 format to All
            - put back 26 in B15
            
            Change-Id: Ie0ad42e2c66b569ca516d95358978a9da6882d69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185746
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Jenkins
            
2025-05-25  Julien Nabet  <serval2412@yahoo.fr>  [3c3f948bc27513ccea91f1c9599aaa354e382c9c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6fdaaf839e51d33b781dd31b877b583ebf30d2ea
          - Related tdf#166665: from cs/statistics_data.ods to soffice eu/statistics_data.ods
            
            changes are on ANOVA sheet:
            - remove space in B8
            - remove 26 from B15
            - change B15 format to All
            - put back 26 in B15
            
            Change-Id: I901dcb0e4b546df0e279606e2200248d0b774809
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185745
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Jenkins
            
2025-05-25  Julien Nabet  <serval2412@yahoo.fr>  [6b079338ea2beb244e8ef6123f389920b0b6309d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ed646461fd12fd8770e2812015ce4074e595c37
          - Related tdf#166665: am/statistics_data.ods until ./ca-valencia/statistics_data.ods
            
            changes are on ANOVA sheet:
            - remove space in B8
            - remove 26 from B15
            - change B15 format to All
            - put back 26 in B15
            
            Change-Id: I15e0dbec236e7e5b3d21aaf0c94a74d7d5b0ace3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185744
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2025-05-24  Kohei Yoshida  <kohei@libreoffice.org>  [2ad7444110dad0869dcca711c4db9367fef85061]

        Upgrade liborcus to 0.20.1
        
        Change-Id: I34edb1608eb9ada252646d528d56079f069013fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185726
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Tested-by: Jenkins

2025-05-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d39842d01b63143a4832be0e01a8b3c216afa9e7]

        cleanup msvcdll stuff
        
        was needed for the 64bit shell extensions in a 32bit build of
        LibreOffice, but that was already broken by
        ec0a49ecc7ea8449d90c1e69857d62728af19829 since that not only removed the
        ucrt stuff, but also external/msc-externals/Package_msvc_dlls.mk that
        would have registered the files to be packaged into the installation
        set. So remove that bit for good and do some related cleanup.
        
        Change-Id: I0b963dcf48eb66cb37d3a6bf017c2ee9aa3fbdf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185566
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9e348f9c5b42445e45f9f4303e0c44832a3cfdc9]

        no longer add the 64bit windows explorer extensions to the 32bit build
        
        those were from a time where there was 64bit Windows, but no 64bit
        builds of LibreOffice/OpenOffice.org - now the only usecase for 32bit
        LibreOffice is to use it on 32bit-only machines…
        
        Change-Id: Icf1eacafd9e157788e8ec5a035716327492f5c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185565
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [396c9dd4a40c2e64774c34bb661ef75bfb235af6]

        don't add 64bit activex component to 32bit builds anymore
        
        makefile stuff anymore, there's still code that can be removed from the
        actual code (partly reverting 8f6b5370be6fe558f6658a0b0719ed64eb205212
        that added support for using 64bit Internet Explorer with 32bit Office
        
        Change-Id: Id0c59e2ef2f4c87a04f18ea54ed04f4337ea6c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185564
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [25d62325f320ba75a2b64584fe1d5d98c18275f1]

        janitor: remove some useless redirection from perl code
        
        calling single-use functions that do nothing else but set a single value
        with a single line of code is madness.
        
        only the tip of the iceberg…
        
        Change-Id: Ic222d65d90cb81c6fdef5ac2e538ca8abb441aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185021
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c23c02439f8118c9b7ecb7bd34f8d7ef5a580765]

        add other bugtrackers to autolinking for vscode/gitlens
        
        turns references to issues like tdf#12345 into clickable links
        
        Change-Id: I685d256b2b1b7ef05477d83288dbd011c125fbc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185607
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b91912e8eed26410551ca067addc3489c3f21f15]

        HEAPU16 and HEAPU32 are no longer exported by default by recent Emscripten
        
        ...after
        <https://github.com/emscripten-core/emscripten/commit/96986d06700f1f8da3f77d80ff6a73d8c69e16df>
        "Don't export memory views by default (#24079)", but are used in
        static/source/unoembindhelpers/PrimaryBindings.cxx, so export them explicitly
        
        Change-Id: I0bbcb36443bb92589df9c81630baffba9a8c7223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185717
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8742f36fa2bdc9d23042378f5b587ccda8b54dd]

        tdf#166684 reduce cost of CellAttributeHelper::registerAndCheck
        
        we can avoid checking the style name repeatedly in the loop
        by using the sorted data structure to get an upper as well as a lower bound.
        
        Reduces load time by 80%.
        
        Change-Id: Id08ec2d77a5292bc8ab0eb7cd44672f6b5a69491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185651
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-24  Bayram Çiçek  <bayram.cicek@collabora.com>  [98164d19c21fe753554190172c35523c8c82f375]

        tdf#166205: add unittest for first-page-header&footer
        
        make sure header&footer visible on the screen by checking their height.
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I5c6f32e7ea8f58d195dea9a8423702f502caf44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [04986d105a2b81a2b549d722541f5aa3a04f3937]

        tdf#166684 avoid O(n^2) loop in ScDocument::AddValidationEntry
        
        during XLSX import. Shaves 30% off load time for this document.
        The downside is that we might get a few duplicate entries,
        which (a) is rare, excel seems to mostly deduplicate these
        and (b) is not crucial for correct functioning for us.
        
        Change-Id: I7a95f4c790dd195c04c9de1f2700981d3e318731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-24  Szymon Kłos  <szymon.klos@collabora.com>  [634180af365781e8158e4a438dcdfc48e6af27a8]

        jsdialog: allow stacking freeze on widgets
        
        followup for:
        
        commit a01e6603d5b0356757fd647f90c69a395f376ba5
        clear while frozen if we will need to freeze anyway
        
        commit 61bc7ce2aa02eb621de8e4c879646767af3d28ce
        Navigator: freeze/thaw collapse
        
        Change-Id: I43b7f29e17c8625da2bea09b917061ed6401dcd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185013
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit a865c65727e2a552ba0475656b79fd71773f1142)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185737
        Tested-by: Jenkins

2025-05-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [426b257424e818e3ffdaa663d6151e566d267a96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f946fe66f4a28a46f4530ed45ed719fa8a09ab87
          - tdf#166665 Correct statistics example file
            
            Special thanks to j22Gim@ for the file corrected.
            
            Change-Id: Ia1500d787dbfca15e0ccc6eeac3613c44467c595
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185722
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-24  Julien Nabet  <serval2412@yahoo.fr>  [49fedb7b17d81d14a3e011c681cbc62444e7c6c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d42cdacbd8c27fd4ff5be331031b25724bf418bf
          - Related tdf#166665: change in en-GB, en-US and en-ZA files
            
            Change-Id: I14b1edbab6296b4da5bb43f1f6c9bd2b4d3a68ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185734
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [154fbde27c334968287fa1f64ca79f2a2552ed2f]

        cid#1647992 Uninitialized scalar field
        
        Change-Id: I329a1b4448582b725eb43e7be808049b767a2faf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185705
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b6f5245a130d9fb61f1aaf1a1771a29b58d6f30]

        cid#1647993 Using invalid iterator
        
        Change-Id: I8cac5b219f5a5961e33cbd2fdc066fd7512957c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185706
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [89b0193639f6cc1e62d9f4894ea088f9691f3a79]

        cid#1647994 Resource leak
        
        Change-Id: Id0fbfa4caae3ab2ef0535f1ecf38b33a1b015c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185707
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [de8468e64bfa389b44cae6ff20d4ab9a463f5af1]

        sc: fix warning C6011: Dereferencing NULL pointer 'this->GetDocument()'
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sc/source/filter/xml/xmlfonte.cxx(149): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\filter\xml\xmlfonte.cxx(149) : warning C6011: Dereferencing NULL pointer 'this->GetDocument()'. : Lines: 149
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\filter\xml\xmlfonte.cxx(150) : warning C6011: Dereferencing NULL pointer 'this->GetDocument()'. : Lines: 150
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\filter\xml\xmlfonte.cxx(151) : warning C6011: Dereferencing NULL pointer 'this->GetDocument()'. : Lines: 151
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\filter\xml\xmlfonte.cxx(152) : warning C6011: Dereferencing NULL pointer 'this->GetDocument()'. : Lines: 152
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\filter\xml\xmlfonte.cxx(153) : warning C6011: Dereferencing NULL pointer 'this->GetDocument()'. : Lines: 153
        make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/solenv/gbuild/LinkTarget.mk:338: C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/workdir/CxxObject/sc/source/filter/xml/xmlfonte.o] Error 2
        make[1]: *** Waiting for unfinished jobs....
        
        after
        commit e61a179b4ff8ce2072c3c0780628eb38c7a43529
        Author: Mike Kaganski <mike.kaganski@collabora.com>
        Date:   Fri May 23 12:14:27 2025 +0500
        
            tdf#166627: embed fonts everywhere we emit font data
        
        Change-Id: Ic81b8193dec7fc9f8d2e3468ea09f9d24c4d3be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185721
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [916e00d3a9a91680c6ce757ca2f37b81df732784]

        tdf#166684 suppress scanning of rotation attributes
        
        the same way we do when importing XLSX, shaves 25% off load time
        
        Change-Id: Ib854a449514ef070177324a0031f0bb0976ea4a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185649
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-24  Laurent Balland  <laurent.balland@mailo.fr>  [42eeb10e27dc9838dab7a60278de2edf9ccbded8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c0646cd11e80fda95143a448366ced5f01f79a13
          - tdf#166477 Add help for "Context" option in numerals
            
            - change option "Hindi" to "Eastern Arabic", according to tdf#102235
            - add exemple of numerals for disambiguation
            - add help text for "Context" entry
            
            Change-Id: I50230a5548535a0b11e4e909719d4cf4a71069d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185731
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-24  Mike Kaganski  <mike.kaganski@collabora.com>  [f894f2b8163088f966b3780e0f50aa79b3c80369]

        Deduplicate XLine{Start,End}Item::checkForUniqueItem
        
        Change-Id: I8fd59f4ecef55612ea6a6ff56b07cbbf1923f62e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185733
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-24  Weblate  <noreply@documentfoundation.org>  [b386552bc02e6c9ac629acb1211aa11ba8260501]

        android-viewer translated using Weblate
        
        Romanian currently translated at 8.6% (10 of 116 strings)
        
        Change-Id: I0506e39f2d65124bb38685092d9aedc90fcffeb7
        
        android-viewer translated using Weblate
        
        Romanian currently translated at 8.6% (10 of 116 strings)
        
        Change-Id: I614e68820c9c776596c1af013c11c1368e975551
        
        android-viewer translated using Weblate
        
        Esperanto currently translated at 37.0% (43 of 116 strings)
        
        Change-Id: I8aa3145f6bf67d110e5f29fd4629dbb6ff129484
        
        android-viewer translated using Weblate
        
        Esperanto currently translated at 37.0% (43 of 116 strings)
        
        Change-Id: Ia3d897269e6dc12079fafb94871dc99f9c30cddf
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Co-authored-by: Donald Rogers <donr2648@fastmail.fm>
        Co-authored-by: Mihai Vasiliu <mihai.vasiliu.93@gmail.com>
        Co-authored-by: Miloiu Andrei-Valentin <miloiuandrei@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eo/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185492
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-24  Mike Kaganski  <mike.kaganski@collabora.com>  [451776bc900f032f375adfb0454d088549374f16]

        Make GetItemSurrogatesForItem return a value, instead of using an out argument
        
        Change-Id: I9f54cf6a016d3f01ae37de5c6429cb0c585b9a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185732
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-24  Mike Kaganski  <mike.kaganski@collabora.com>  [8dd04408a999b3066c6c593292d2ea3630021bb5]

        Make GetItemSurrogates return a value, instead of using an out argument
        
        In all cases, it was used with a local variable created for each call.
        
        Change-Id: I436bdd8e611c02425b39d8d44366a4980e19dba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185729
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cb5a4314c3561179e556107b81830a9949b20517]

        tdf#149207 fix image not getting a unique name
        
        Using "background" as the name, CheckNamedItem doesn't correctly
        determine that another XFillBitmapItem exists with an same
        "background" name already, which is then a problem when exporting
        the document and from all "background" images only one will be
        exported.
        
        regression from
          commit ec7ba61a6164c805f5a71b077715b7e1521a2d62
          Author: Noel Grandin <noel.grandin@collabora.co.uk>
          Date:   Wed Apr 17 15:19:25 2019 +0200
          simplify SfxPoolItemArray_Impl (tdf#81765 related)
        
        I am not sure why the above commit caused this problem.
        
        Right now, the reason CheckNamedItem doesn't work is because
        with other subsequent changes to the pool infrastructure, the
        new PoolItem is already in the surrogates/NameOrIndex array
        and so it finds itself when scanning the array.
        
        But back then, the new PoolItem should not have been inserted
        yet.
        
        Any way, fix it by making CheckNamedItem exclude itself when
        scanning the surrogates data.
        
        Added a test for uniqueness of names.
        
        Change-Id: I3c04065a4875a21649ad8141243cc39a8d1a5b3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185719
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-23  Mike Kaganski  <mike.kaganski@collabora.com>  [8ebe1e51ea9be20dd3e2279359ca0bebc9beb05c]

        Related: tdf#166627 Write font-face-src for each mention of embedded font
        
        Before commit e61a179b4ff8ce2072c3c0780628eb38c7a43529 (tdf#166627: embed
        fonts everywhere we emit font data, 2025-05-23),  embedding of fonts only
        happened during export of content.xml, to avoid complexity of shared data
        between different instances of SvXMLExport, created separately per stream.
        
        The said commit introduced a way to pass the data between these instances,
        and embedding now is done by any SvXMLExport instance  that needs to emit
        font-face-decls. Currently, only the first declaration of a used embedded
        font gets its font-face-src.
        
        But this is wrong, when the same embedded font in another stream, where it
        is also used, does not reference its files.  This patch allows all streams
        to emit font-face-src for all fonts used in it. File duplication in ZIP is
        avoided by passing the embedded file information between SvXMLExport, with
        font file hash and its path in ZIP, instead of font names.
        
        Change-Id: I7a62e50c086d8741dbc8aadf61d0f008bad916ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185720
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-23  Mike Kaganski  <mike.kaganski@collabora.com>  [e61a179b4ff8ce2072c3c0780628eb38c7a43529]

        tdf#166627: embed fonts everywhere we emit font data
        
        Commit 69ed893087f89d176a5ec4b263ce8d75774be72b (tdf#160253: fix list
        identifier export decision code) made a large change to the autostyle
        collection procedure, which became more precise. It turns out, that
        before that change, exporting content.xml gathered autostyles from
        page definitions, too, meaning that the fonts used there were marked
        as used in that pass. After the change, that pass doesn't look into
        the page styles and their content, and the fonts that are only used
        in headers/footers aren't seen as used in that pass.
        
        The font embedding procedure was previously implemented to only do
        the embedding during content.xml export, to avoid duplicating font
        files from each pass. Since each stream was exported by a separate
        instance of SvXMLExport, it was considered difficult to maintain the
        already embedded fonts list across all passes. It assumed that the
        export of content.xml sees all used fonts.
        
        But after the described change, this assumption doesn't hold anymore.
        We need to make sure to embed all fonts found in all passes.
        
        This change introduces such state, implemented as set of font names
        maintained in the object that exports all the streams, creating an
        exporter for each. Using a new set of function to set and get the
        "already embedded" font list in SvXMLExport, the outer object passes
        that list to each created SvXMLExport instance, and after the call
        to `filter`, retrieves the updated list, to pass it to the next one.
        
        The change required to move some members from XMLFontAutoStylePool
        to SvXMLExport, to avoid additional complexity of passing the list
        from SvXMLExport to XMLFontAutoStylePool. The implementations of
        the moved methods are kept in XMLFontAutoStylePool.cxx, because the
        internal structs used in the methods are defined there.
        
        After the change, some of the embedded font file references, that
        previously appeared in content.xml, will now be in styles.xml.
        
        Change-Id: Iaa26f1d1d623dee5a5c43600ea5fd2af1d04b46f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185704
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [c642ba4de2a8d3614f0b7c22b9c93a6cf507e78d]

        ScTableLink: drop pImpl and pass ScDocShell by ref
        
        Change-Id: Icdfeb1e10692f6cff7b3d4e4c78b0becfcf3b183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185713
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [987cad5b1c09cc6538b5d5b515b2e0b868bb96bd]

        ScSimpleUndo: pass ScDocShell by ref
        
        Change-Id: If3d1b364836922c210ffbbf8046ea98d912892b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185712
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [0b71553e9a7b51cf84bfa7b1487a768e4ff64920]

        Remove obsolete fw declarations from xmloff/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ic1d7679fc60fb41df351cc849c2e35517b3f0e36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184010
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-23  Jonathan Clark  <jonathan@libreoffice.org>  [21c5006f2e973c1d62085de29c3f4240dce1a4ff]

        tdf#152006 sw: Fix nonresponsive apply button in Text Grid settings
        
        Previously, there was a situational bug causing the Page Style->Text
        Grid settings to fail to update after clicking the Apply button. This
        change fixes that bug.
        
        Change-Id: I260ecc9c72d1e9a575597c57e3145dd1952cba0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185676
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [56da031f73f544d712b369f732f1ded1d3926fc2]

        tdf#166684 strip out some unnecessary UNO work (2)
        
        to make this easier to optimise, strip out some unnecessary UNO stuff between the import filter and the underlying spreadsheet model
        
        Change-Id: I0c1e12c09842390c90a7e804dffa5fdd034f60b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-23  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [f52957d9886f1c5701196331cc396eecd0980712]

        tdf#164970 move customizations frame below the themes frame
        
        Change-Id: I028a1a5f92e25713125980257bde688daf3f8ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185696
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-05-23  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [f7f1538dd8d04a51733af3c5c5457fd65e591f22]

        tdf#164970 add checkbox for toggling document color customization
        
        after themes was released in 25.2, there were quite a few bug reports on
        bugszilla like [broken dark mode], and some on social platforms like one
        [bug reported on X]. this also [broke old presentations], and in that
        case it was more problematic than writer or calc as in case of impress
        it is assumed that "what you see is what you get".
        
        this happened because the documents didn't have the backgroung color
        attribute set and the document canvas color is dark in dark mode. the
        solution for this is to not override the document canvas colors by
        default and provide users with a choice to enable it if they want.
        
        [broken dark mode]: https://bugs.documentfoundation.org/show_bug.cgi?id=164838
        [bug reported on X]: https://x.com/pritamckn25/status/1915068541801210201
        [broke old presenatations]: https://bugs.documentfoundation.org/show_bug.cgi?id=165803
        
        Change-Id: I613b5f0b6e4e1f8f2b8f9fddb50f98286dbdc481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185388
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-05-23  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [22a8a7583c5e906a7a5ecac97b34e2beca506389]

        tdf#164970 add a checkbox for enabling/disabling application theming
        
        the "enable application theming" checkbox allows the users to
        enable/disable ui theming. in the beginning, theming was enabled by
        default but then after [quite some discussion], it was disabled. so if
        the user wanted to enable it again, he had to dig through the expert
        settings to set an integer config value to 1. this checkbox makes it
        convenient.
        
        [quite some discussion]: https://gerrit.libreoffice.org/c/core/+/183490
        
        Change-Id: I5c4228d103d41b8739ff0b72743f962bb20bdb50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185605
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-23  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [6026d13bfda88e0bcf43e7b15c80cfc54e3aa16c]

        tdf#164970 cleanup the ui file for making further work convenient
        
        Change-Id: Ibb2116feb40387c5b13fa2fcab2b137a48be5e72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185604
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-05-23  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [832850eef18270749c70ff72b1d7e13ded7be26c]

        tdf#164970 remove add and remove buttons from appearance tab
        
        the [new] themes panel doesn't have add/remove buttons. also it was
        discussed multiple times in the design meetings that the user sholdn't
        be allowed to create themes and application appearance should only be
        customizable via extensions.
        
        [new]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=200044
        
        Change-Id: I77ca75803a73272a7089a1ac11778445fdb52459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170965
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [baf6a6c02b337b730f218d433f037257234c0c16]

        openldap: upgrade to 2.6.10
        
        Downloaded from https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.6.10.tgz
        
        Change-Id: I1491633eb4b58ec40a1ce228796d3d042ce9ce76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185702
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-23  Pranam Lashkari  <lpranam@collabora.com>  [3b379b6dfd8b9400ae5412b00ae3be1d8851669d]

        sw: avoid front expansion of field with NeverExpand flag
        
        improvment on d6b8e20c9cdca69d684390c264e775a708777846
        
        Change-Id: I572090466f4df7c93099244d7f07e62c1468176e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185316
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185555
        Tested-by: Jenkins

2025-05-23  Pranam Lashkari  <lpranam@collabora.com>  [6c3c9d3d94a4835943a852d9a94a2573acb4258d]

        sw: introduce field parameter to avoid expanding field
        
        problem:
        in online when a reference mark field is inserted and you start
        typing after it, field always expanded.
        
        problem was detected when using zotero citations
        
        patch reverts some part of 58e5e3208a4257a8d9f2e28d8e2d304677aa6980
        
        Change-Id: Ia664b82dae7a2385d9d0a3cf16276bb3ef39e61c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184711
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185554
        Tested-by: Jenkins

2025-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [79322a7025bb6fd61928204f90230560b09b4ba9]

        tdf#166684 strip out some unnecessary UNO work
        
        to make this easier to optimise, strip out some unnecessary UNO stuff between the import filter and the underlying spreadsheet model
        
        Change-Id: I5d0ea6ffc487f089c87f17fd2eb18a30198dbacc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-23  Mike Kaganski  <mike.kaganski@collabora.com>  [3158b14e0b26875300a8098bc117a5e69b76f48f]

        Simplify GraphicProvider::queryGraphic
        
        nExtWidth and nExtHeight are unused since commit
        1c25d22bfa072eb78da8930a3877f37a70ff707b (Simplify an
        "ImportGraphic" method by removing useless pExtHeader
        (WmfExternal), 2022-05-19). Is nExtMapMode (and maybe
        bLazyRead) obsolete, too?
        
        Change-Id: I1de1ea4f08c6e6ef332fbabc228395c7490520cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185669
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bd0d3b460fe9d4aaaf2cefb78ff7dd85423b6066]

        Resolves: tdf#166613 wrong selection returned from forms listbox editor
        
        Change-Id: I14e51eb1945d282691275f394bfbac50f3c4cc48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185666
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6dd8843f7880255a1292e4b3296a1611874e098d]

        Resolves: tdf#166612 MultiSelection inverted for form list properties
        
        Change-Id: I65bac82ceb1f0ddf4a23837e4c29e40e70eead68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185663
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d4fe20029f101538895ba3d6f5abf6a3d014560]

        Resolves: tdf#164226 escape mnemonic's in menu entries
        
        Change-Id: Ia93be72d79a1660b9c9fe17d25763aec3d8a9bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d0d0141b105694bec7d84527f998527f86bb121f]

        Simplify vcl::GetGraphic
        
        Change-Id: I0406d66485ef17fd9b978dff4fe666226c3932a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185665
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [176a52dbce43e84177154ee42061aee1b017852e]

        Simplify vcl::GetBitmap
        
        Change-Id: I75232d76017fa2787c54131c90c6481adefd6d0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185659
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [64f9a698dce9466991981069b70bacaf60f0b955]

        Simplify VCLUnoHelper::CreateBitmap
        
        Change-Id: I94a0427cb24d9e751ba21905e5abb378fba71843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [0d5fed1269e96222774d8092a98a4166f02814fc]

        Related: tdf#163381 Fix and unify on vcl::bitmap::GetMaskDIB
        
        Commit bb6db3aa4c86b92e8321d6734bcb34ba28dfeb27 (tdf#163381
        XBitmap.getMaskDIB() is inverted, 2024-10-16) has fixed the
        implementation of getMaskDIB in unographic::Graphic. There
        is another XBitmap implementation  that needs the same fix:
        VCLXBitmap.  It uses vcl::bitmap::GetMaskDIB  for the task;
        and that may be also reused in unographic::Graphic,  after
        the fix.
        
        Change-Id: Ic0349bcb49e66246765dc7e4deed566b4c4b9094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185657
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [b046d0cfd4ef5c517b9e11c5fa4d659e65cd868e]

        ScRefUndoData: pass ScDocument by ref
        
        Change-Id: If389a4581933daccf6f4f5e9c6cda1a24e179d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185656
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-22  David Hashe  <me@dhashe.com>  [277364ed05e0340ac0affbe7743e209d4d36c0a1]

        tdf#48140 Directly use ScCellRangeObj in finalizeArrayFormula
        
        No need to go through UNO.
        
        Test plan:
        
        $ make CppunitTest_sc_filters_test
        
        Additional manual testing:
        
        1. Create a fresh calc document.
        2. Enter in input line for A1: ={"Foo","Bar","Baz"}
        3. C-S-RET to evaluate and spill the array formula.
        4. Save document in .xlsx format.
        5. Reopen and verify that the array formula is correct.
        
        Change-Id: I07a865eece8f2a14820d82fea1fe4af66d20b231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185073
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [de9093a10c0f805378bc5036c355e671cf1efcde]

        chart color palette: assertion failure in getCID
        
        Change-Id: I5e5628abb4e7e23ccc0f884c8ccb17167a368f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185557
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit f99bc3659663164b0e1d36452f2935ac98324893)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185655
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins

2025-05-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1c1e132593dbd7dc793c953c44bdbafe9271fac1]

        Fix typo
        
        Change-Id: Ie7fb787692b355aa34834b5e9e7d5e86bffd8867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185683
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1e24215cef8a9cbf2a322a0b70d480d43bb0c42e]

        Fix typo
        
        Change-Id: Ife1f48335d7be85cba2a2232a0246254ef22d68b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185684
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [7eb5825e19d0de97c31819e655b2f9636f0e0e04]

        ScDPFieldButton: drop default arguments and pass them by ref
        
        Change-Id: I5de43aca9ce73153bb8448fa4ae90e7ed7261255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-22  Miklos Vajna  <vmiklos@collabora.com>  [8cabdef0b34210d026ea7a8229f321e272a49109]

        tdf#166319 sw interdependent redlines: handle accept of ins-then-fmt's fmt
        
        The bugdoc has <ins>AA<format>BB</format>CC</ins> in it, accepting the
        "BB" part resulted in a fully accepted portion, while the expected
        result is to accept the underlying insert, like in Word.
        
        The problem is that the accept code is not aware that the format has an
        underlying insert, so the format gets accepted and as a side effect the
        insert redline is gone, too.
        
        Fix this by extending DocumentRedlineManager::AcceptRedlineRange() to
        just get rid of the inner redline in the insert-then-format case, which
        results in a plain format redline, as wanted. lcl_DeleteInnerRedline()
        can do exactly this, added already in commit
        f468d61755fad1e38e481f8f439bbce9161a3aa7 (tdf#166319 sw interdependent
        redlines: handle reject of delete under format, 2025-05-16).
        
        Connecting this (effectively) insert redline (insert-then-format, to be
        precise) with the surrounding plain insert redlines is not done yet,
        though.
        
        Change-Id: I64e2ab1f6a6ce7872c3e4ea7b0bfb0c542c611ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185653
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [434e9f28dc3c0560c7234622f0e064c18e25517a]

        wina11y: Use VCLUnoHelper::GetWindow
        
        Change-Id: I6e28b98f4cbd3601a746d53a4962aa7cf3c633e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185646
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [ed03c63f00dee22112a8632df45e5e044541960d]

        wina11y: Don't rely on win accessible being VCLXWindow
        
        While at the moment, the XAccessible for many vcl::Window
        subclasses is a VCLXWindow, this is an implementation
        detail that is subject to change.
        Switch away from relying on that implementation detail,
        and instead rely on the XAccessibleContext being a
        VCLXAccessibleComponent, which will remain true even
        if that one will be created without VCLXWindow being
        involved in the future.
        
        See also
        
        	commit b1f3e41f1015f0166dca1382c5fa1d1223f72fb8
        	Author: Michael Weghorn <m.weghorn@posteo.de>
        	Date:   Wed May 21 11:03:56 2025 +0200
        
        	    sw a11y test: Don't rely on XWindow being XAccessible
        
        for more background (which ports away from an assumption
        "the other way around").
        
        Change-Id: Ia2e2fe9d88c05afcde2c8a6d31c20c60cfbd5c49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185645
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [add53405a0f7b0437223decf7c8aee7382e65048]

        wina11y: Drop extra raw pointer
        
        Change-Id: Ie0b758a426e6b234feaae0b8583584590cfe99a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185644
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [8747e45b5f651d39682299a84af86aa41fef5be7]

        tdf#166233 PDF: Optimize Tagged PDF export to reduce file size in Calc
        
        Let’s avoid exporting empty cells into the tagged PDF, because even if
        a cell doesn’t contain any value, it still gets 3 tags.(<TR>,<TD>,<P>)
        These unnecessary tags significantly increase the size of the tagged PDF
        
        Change-Id: I9302f6daebb03c1502dded5835e07a8953279aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185636
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [645746365891acf277534c62f2a3fc0c8ccd7f89]

        join restartable threads on large trimMemory effort
        
        Change-Id: Ibbb1471fb1436e7894cdc6946410a88e52dd50c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185627
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit b5f44b5f68dcb814771a6eec29ed92fdb56d93d2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-22  Michael Meeks  <michael.meeks@collabora.com>  [011760896551817d4fe8018214eff6d011bb385a]

        Timer - shutdown and re-start salhelper::Timer thread.
        
        Necessary for lok background save.
        
        Change-Id: Ib78f67f124dcd5b2a8b50c65ea58a9e1eb894ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182931
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 79197949d757c40f750406f59e85d6efe02bf584)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185641

2025-05-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [29edbf28fc3135ccc6d84f9484df939c5f891746]

        tdf#166633 - sc fix wrong context menu for text boxes
        
        Handle separately text SdrObjs from not text SdrObjs
        because when we create a new text object we also set
        in edit mode automatically.
        
        regression from commit: 7e15c704cedf1ca77b3ebe8b3b60f6a1ad57deb0
        (tdf#166481 sc shapes edit view: fix wrong draw view shell)
        
        Change-Id: I4887c5f24a277fbbf01b4449148f3934b043220b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185618
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-22  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f7e781292fc97b1d5e845c219c59bd01833da5ee]

        tdf#166349 - Reload recent documents to show pinned items
        
        After clearing the recent document list, reload the start center in order to show pinned items.
        
        Change-Id: I248d28aaf8f4f9a823aab7630e37e8a410848433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185608
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [ec41ec4e96ac03266b6a688e659dcb7b1e65e414]

        a11y: Move OAccessibleWrapper etc. to svx
        
        OAccessibleWrapper and a couple of related classes
        is only used by AccessibleControlShape inside svx,
        so move it there from comphelper.
        
        Use the same "accessibility" namespace as other
        classes there.
        
        Those classes used to be used elsewhere as well before
        
            commit 39e0bdb686baf76a4c54d12cfa66aa9f08db8c3f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:42:03 2025 +0100
        
                tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        Change-Id: Ie56357d943084b34f202510b13e8bb17e07bc125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185639
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [ef500b65297704ddf50e56eee7cf402053dd0e3c]

        comphelper a11y: Use #pragma once
        
        Change-Id: I65beee09218e36657d59ed8483e9b90b21b950c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185638
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Justin Luth  <jluth@mail.com>  [d4dad2e181fd2dc30c3916fd59c05745023a51c8]

        tdf#156707 xmloff import: always provide ControlBorder property #2
        
        In LO 7.5, ORichTextModel changed the app default to use a flat border
        (in order to better match how PDF/print looks)
        while the file-spec's default for undefined borders is 3d,
        so during import time we ALWAYS need to specify 3d as the border.
        
        The patch replaces 25.2 commit 5a617f77ee803eb65051e93f659ef66433879052
            tdf#156707 xmloff import: always provide ControlBorder property
        which wasn't wrong, but just was incomplete.
        It only handled the situation where there was a fo:border element
        which didn't specify 3d/flat/none,
        but didn't handle the situation where there was no fo:border at all
        in style:graphic-properties.
        
        [On export, since the 3d property is the default value,
        fo:border is not even provided as something to be exported,
        and therefore only "solid" and "none"
        are ever exported as fo:border qualifiers.]
        
        I modified the unit test to remove the fo:border
        by clearing the unused-by-3d green border colour
        (although the green was seen if the wrong flat border was assigned).
        
        make CppunitTest_xmloff_style CPPUNIT_TEST_NAME=testTdf156707
        
        Change-Id: I70718fe964a7c3578f8edbf8591fe2e3417ec60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185619
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-22  Oliver Specht  <oliver.specht@cib.de>  [f8eb5d8503adb589239788f649f93d0ef51c2a47]

        tdf#164202 Update gallery data on insert/remove
        
        Fixes crashes introduced with 09c6204b6309321aa25c542f918fde9f5f3f7fe2
        
        Change-Id: Ifca32646c8ba5abce647934e1d2ddac8a8eba2ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185584
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [538765c85f46a1e658b769fc1e04a1e2b3a5838d]

        Simplify vclptr.hxx a bit
        
        Change-Id: I3d92dd98eaaedba377a5877c06aedc2991b79e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185594
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [759c57bca1751546c5e83bdfad03ad255805c7a1]

        No need to use vector here
        
        Change-Id: I1345ed034e92f4576e62ada2e85f1fd78d457fa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185593
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [dd4e3131a72073ceb856258898876170999e13a9]

        comphelper a11y: Use concrete OAccessibleContextWrapper
        
        ... for OAccessibleWrapper::m_aContext instead of
        XAccessibleContext.
        
        This requires adjusting the visibility of
        OComponentProxyAggregationHelper to match that of
        OAccessibleWrapper.
        
        Otherwise loplugin:dyncastvisibility would fail like
        this:
        
            In file included from /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblewrapper.cxx:20:
            In file included from /home/michi/development/git/libreoffice/include/comphelper/accessiblewrapper.hxx:42:
            /home/michi/development/git/libreoffice/include/unotools/weakref.hxx:127:20: error: dynamic_cast from 'com::sun::star::uno::XInterface' with default type visibility to 'comphelper::OAccessibleContextWrapper' with default type visibility [loplugin:dyncastvisibility]
              127 |             return dynamic_cast<interface_type*>(xInterface.get());
                  |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /home/michi/development/git/libreoffice/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:15:40: note: base class 'com::sun::star::uno::XInterface' with default type visibility defined here [loplugin:dyncastvisibility]
            [...]
            /home/michi/development/git/libreoffice/include/comphelper/proxyaggregation.hxx:130:11: note: intermediary class 'OComponentProxyAggregationHelper' with hidden type visibility defined here [loplugin:dyncastvisibility]
              130 |     class OComponentProxyAggregationHelper :public ::cppu::ImplHelper1 <   css::lang::XEventListener
                  |     ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              131 |                                                                         >
        
            [...]
            /home/michi/development/git/libreoffice/include/comphelper/accessiblewrapper.hxx:219:51: note: derived class 'comphelper::OAccessibleContextWrapper' with default type visibility defined here [loplugin:dyncastvisibility]
              219 | class UNLESS_MERGELIBS_MORE(COMPHELPER_DLLPUBLIC) OAccessibleContextWrapper final
            [...]
        
        Change-Id: Ic20872d1b1778dc97dc8d2dfc1833bbe31e3eea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185633
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [d9e74b7ef4486355c7875d353fdc53bbe5ab5e4d]

        a11y: Slightly simplify OWrappedAccessibleChildrenManager::dispose
        
        Change-Id: Id7bb729b5518452294c6daa7428c333f4f2e1e92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185632
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [363ee9fc34c5a6a04671450025fab7940032867d]

        comphelper a11y: Drop unreachable OSL_FAIL
        
        The return value of std::map::emplace is [1]:
        
        > A pair consisting of an iterator to the inserted element
        > (or to the element that prevented the insertion) and a bool
        > value set to true if and only if the insertion took place.
        
        If the element were already present in the map, the
        
            AccessibleMap::const_iterator aPos = m_aChildrenMap.find( _rxKey );
            if ( m_aChildrenMap.end() != aPos )
                return aPos->second;
        
        code path above would have been taken, so there's no way
        that this OSL_FAIL can be reached, which is even more clearly
        visible since
        
            Change-Id: I3df5d430c16d9d5b7c836926928d023e45d85d45
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 20:25:04 2025 +0200
        
                a11y: Flatten OWrappedAccessibleChildrenManager::getAccessibleWrapperFor
        
        [1] https://en.cppreference.com/w/cpp/container/map/emplace
        
        Change-Id: I9dbeb22bac11624533ef7b93da36adcd7038bff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185631
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [57d41c3a9b40163c1c0076da1e896f6f479351bd]

        a11y: Flatten OWrappedAccessibleChildrenManager::getAccessibleWrapperFor
        
        Return early to reduce nesting level.
        
        Change-Id: I3df5d430c16d9d5b7c836926928d023e45d85d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185630
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [be07b0ae141ba9e59a5651ccd381d14d40a9f4d5]

        svx a11y: Drop unnecessary static_cast
        
        Change-Id: Id787572bc2542655733289bd73c55d98dc40ed67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185626
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [c9fb4e4b5b82d6ff39268dd2025ec722b44e3fd5]

        a11y: Merge OAccessibleContextWrapperHelper::baseGet* into callers
        
        Move the logic directly into the only callers in
        the OAccessibleContextWrapper subclass to get rid
        of one level of indirection.
        
        Change-Id: I8d04e5587bbb8464982e7a80469419a74ba44ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185625
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [e32b425520d5634f29df6cc05fb192e5114bae17]

        comphelper a11y: Drop extra indentation level
        
        Change-Id: I0e2cb7eb82947036f36f737d5fb9b29376d12365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185624
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [db9f4b127e895f0d631c0004e867f4d4abedba05]

        comphelper a11y: Drop unnecessary forward-decl
        
        Change-Id: Ieacde9c0ef12bb030653d398c34731e434fcf857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185623
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [9ad80f9dafeec7e4f81fdbc3c657e7682a77a1cf]

        a11y: Turn cppu::ImplHelper1 subclass into alias
        
        Make OAccessibleWrapper_Base a simple alias instead of
        a subclass, as it doesn't add any functionality.
        
        Change-Id: I17ee04b70696a61b234acd4be515e269a869c95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185622
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [ffb112e4795756f2ed2da322de7390b65024bd4f]

        svx a11y: Make static helper a AccessibleControlShape method
        
        ... and stop passing `m_xUnoControl` in every invocation,
        as that can be directly accessed from within the
        method now, renamed to AccessibleControlShape::isControlInAliveMode.
        
        Change-Id: I7d4f8ee0a03511c570f1a10336dc75b817545f6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185621
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [5c4b4c2900838602964e995d4118681fec537e31]

        toolkit a11y: Don't rely on control peer being XAccessible
        
        When getting the accessible context for a
        UnoControl in non-design mode, don't rely/depend
        on the implementation detail that the VCLXWindow
        implements the XAccessible interface for its
        vcl::Window, as this is subject to change.
        
        Instead, retrieve the vcl::Window and then
        get its accessible (context).
        
        See also commit messsage of
        
            Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 11:03:56 2025 +0200
        
                sw a11y test: Don't rely on XWindow being XAccessible
        
        for more background.
        
        Sample scenario to trigger this code path:
        
        * start Orca screen reader on Linux
        * start Writer with gtk3 VCL plugin
        * enable "Form Controls" toolbar in "View" -> "Toolbars"
        * insert a Check Box (or radio button) control
        * disable design mode by clicking the corresponding button
          in the form controls toolbar
        * if not already the case: select the control
        
        At the moment, the accessible context is exactly the
        same with or without this commit in place, but
        the previous approach relying on VCLXWindow being
        the vcl::Window's XAccessible would break if that
        no longer is the case in the future.
        
        Change-Id: I9aa697e1d7a25a10ccb5469f5dd2a84a4f00fbfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185617
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [a804e8efd2ed8edc7a7bbf47121d7da74dc6b994]

        svx a11y: Merge both ShapeTypeHandler::GetTypeId
        
        Change-Id: I31eaad6616a127f056c89c68c0208182d8563b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185614
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [6503bb08224731f3756c59569fd4575ea2b7a4d4]

        svx a11y: Return ShapeTypeId instead of tools::Long
        
        That's what's stored in
        ShapeTypeHandler::maServiceNameToSlotId and what
        the callers wants, so there's no reason to use
        any other integer type.
        
        Change-Id: Ibb5cdf0dc36767771ae02a255e878dcddcb3a45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185613
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [93010de73bd96090389411f4d78361cc94f2d6e3]

        svx a11y: Merge both ShapeTypeHandler::GetSlotId
        
        Change-Id: I140488bcdf9ae4df9e42170ce6d6a5a55f66c29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185612
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [3f6564fc6f0f18104d800c66a3e70f854059f234]

        svx a11y: Flatten AccessibleControlShape::Init
        
        Return early.
        
        Change-Id: Ia1e6f1ce0eb012685b240ba7cd9d2613a0e8ed63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185611
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [5cbd1c00c61cbda91adb836d4cd100be7bdde125]

        gtk3: Don't depend on a11y to detect tooltip win
        
        In RunDialog::windowOpened, don't rely on the
        the VCLXWindow currently usually is also being
        the XAccessible for a vcl::Window, which is an
        implementation detail and subject to change, see
        commit messsage of
        
                Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Wed May 21 11:03:56 2025 +0200
        
                    sw a11y test: Don't rely on XWindow being XAccessible
        
        for further background.
        
        Instead, retrieve the vcl::Window and check the window
        type of that one directly to detect a tooltip.
        (See the mapping from window type to accessible role
        in Window::getDefaultAccessibleRole.)
        
        If continuing to use the a11y layer were necessary for
        any reason, an alternative could be to get the
        vcl::Window's XAccessible without it relying on it
        being the VCLXWindow, see the above-mentioned commit
        for an example.
        
        Sample scenario that triggers this code path and
        still behaves the same as without this commit in
        place:
        
        * start Writer with the gtk3 VCL plugin on Linux, create
          new doc
        * press Ctrl+N to create another new document
        * press Ctrl+S to open the file dialog for the second doc
        * switch back to the first doc
        * press Ctrl+N to open yet another doc
        
        -> The file dialog is popped down after a few moments
        because the logic in RunDialog::windowOpened still
        detects that the new window isn't a tooltip.
        
        Change-Id: I66c9d4c87c7ba96502d08ebc8ec52fdaabe132ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185603
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [e76a027177602e88d902d24017949719fe8aa7c8]

        gtk a11y tests: Don't rely on XWindow being XAccessible
        
        See commit messsage of
        
            Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 11:03:56 2025 +0200
        
                sw a11y test: Don't rely on XWindow being XAccessible
        
        for more background.
        
        Extract a new helper from the existing
        test::AccessibleTestBase::getWindowAccessibleContext
        that returns only the XAccessible and use that one
        to avoid duplication.
        
        Change-Id: I0f3db88a4754f3ce8de5b02e0a0e41ac9cac9ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185602
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [1ebb7ce2e8b0ed518fe6c6adea175a58890c3d7d]

        toolkit a11y test: Don't rely on XWindow being XAccessible
        
        Reuse the existing
        test::AccessibleTestBase::getWindowAccessibleContext
        to get the accessible context.
        
        See commit messsage of
        
            Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 11:03:56 2025 +0200
        
                sw a11y test: Don't rely on XWindow being XAccessible
        
        for more background.
        
        Change-Id: Ic75f0ecb317d174655a0c73c6bed534884c214a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185601
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [81b29ea15476eaeb588a74e930bfd3f44198fe05]

        a11y test: Don't rely on XWindow being XAccessible
        
        See commit messsage of
        
            Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed May 21 11:03:56 2025 +0200
        
                sw a11y test: Don't rely on XWindow being XAccessible
        
        for more background.
        
        Change-Id: Ieda73dc058444ad4b272f1a63a123289ee58bc23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185599
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [3dce350e9059c1badf91972b835d314d77fb2c64]

        a11y tests: Drop unused include
        
        Change-Id: Iaa1baccfb0b95972cd8703da8f80433fdcd62163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185598
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [b1f3e41f1015f0166dca1382c5fa1d1223f72fb8]

        sw a11y test: Don't rely on XWindow being XAccessible
        
        The fact that the VCLXWindow (which implements the
        XWindow interface) is currently also the XAccessible
        for most vcl::Window subclasses (see Window::GetAccessible
        and the default implementation in Window::CreateAccessible,
        but which is overriden in some vcl::Window subclasses) is an
        implementation detail and subject to change, so don't rely on that.
        Instead, call Window::GetAccessible on the underlying
        vcl::Window.
        
        See also
        
            commit b608604d0bbecdc24a17175374581b4e2d720658
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 14:07:52 2024 +0000
        
                tdf#164093 tdf#157001 wina11y: Use vcl::Window's actual XAccessible
        
        Change-Id: Id81ab5f90955ecc600e179164b5f9c7a771182d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185597
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [74153b0a6fc50ea3653f2925ee6695b490b25d8b]

        svx: Drop unnecessary detour to get shape XAccessible
        
        AccessibleControlShape implements both, the XAccessible and the
        XAccessibleContext interfaces itself, and its
        XAccessible::getAccessibleContext implementation
        (in the base class AccessibleContextBase::getAccessibleContext)
        returns `this`, so just use the `pCtlAccShape` directly.
        
        Change-Id: Idd272a76770d8dcf3ed5e7f82bccc180e69fe8c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185596
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-22  Aron Budea  <aron.budea@collabora.com>  [0c477a65b3e49b7fd0eeeb0eaf200d811918032f]

        sw filter: don't write empty OOXML docPr title/description
        
        Change-Id: I4cfeec04dc32ab4aded69f5f99046f8a1cf027a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185337
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-05-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ad96ff22e96618247dfb0ddee74968ce32890963]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ac2783410ff8078ebef80b6ff8aad02c168093f
          - tdf#152122 Business card/Label pages update.
            
            + Added "New Document" to pages
            + Refactor
            + Update entry pages from menu (F1)
            
            Change-Id: Iac462c8f39fd3c86b66eb4c61b5f50f53082cdab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185629
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb08f8463bc00f8a6ef20cf21d29c985f64e8654]

        tdf#164623: handle negative rotations
        
        Change-Id: I35dd1ecda0754639b8e511532af24ef7e0d0935b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185610
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-21  Aleksi Kallio  <aleksi@pullakahvit.fi>  [1794b41c888a3ad42a1d55deb26db2d09953b300]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: Id83d153f0f0239ad0e967a900cf8ec64d8452482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185615
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-05-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c74e95207991cd39561968bdb85be0de03120246]

        fix invalid cast from 'GtkImage' to 'GtkLabel'
        
        Change-Id: I3e608207bdde10b02d4ef3fe7392d63284b06594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185609
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2b4ee64fa60e53ff8996571c88d5de192336111]

        clear while frozen if we will need to freeze anyway
        
        so we have a single thaw event
        
        Change-Id: If82c40480b418e845932854c6b20b09af208967e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184984
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185591
        Tested-by: Jenkins

2025-05-21  Miklos Vajna  <vmiklos@collabora.com>  [08acfb815745e7f43ca43557feefcb68607d26c1]

        tdf#166319 sw interdependent redlines: handle ODF import of delete under format
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, ODT import
        created a model that contains <del>AACC</del> instead, i.e. the
        format-on-delete part was lost.
        
        The first problem was that XMLRedlineImportHelper::ConvertRedline()
        rejected the format-on-delete, fixing the used
        CanCombineTypesForImport() resulted in a format-on-delete redline that
        was in the document, but the order was wrong: BBAACC (matching the order
        in the file, since deletions are listed separately, before the body
        text).
        
        The second problem was that XMLRedlineImportHelper::InsertIntoDocument()
        didn't consider format-on-delete when it looked for deletions: fixing
        that results in the wanted AABBCC string in the document model.
        
        With this, the ODF import/export for ins-then-del, ins-then-fmt &
        del-then-fmt should work.
        
        Change-Id: I7bcdd4d7452d9bca0ff31ce99cbc29795eb63fa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185592
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-21  Szymon Kłos  <szymon.klos@collabora.com>  [b96aedb6f4a830c9b61f103dbbe71f491dca1d70]

        Navigator: freeze/thaw collapse
        
        Do single set of freeze / thaw.
        Previously we did once for cleanup, then
        another one for fill. That is worse for JSDialog
        where thaw emits update of the widget.
        
        expand_row has assertion protecting from doing it in the
        frozen state.
        
        Change-Id: I1b962560b5f864cca42c475789917a2ce5e61bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184835
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185590
        Tested-by: Jenkins

2025-05-21  SilverGreen93  <mihai.vasiliu.93@gmail.com>  [a795a6f8d310a5869943f724e4f2ad04c81f7f8d]

        tdf#165838: Add sc_list_remove icon
        
        sc_list_remove icon is missing from dark themes, so it defaults to light theme which looks bad.
        
        Add png and svg versions to the available dark themes.
        
        Also fix the `sc_add.png` images to not be blurry.
        
        Change-Id: Id4c41fdfed438bc5fc835952f51cfdd0a3e1ef7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185149
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-21  Karthik  <me@karthikreddy.org>  [84c92227f8a47b7a9436806c17b308315de3d38b]

        tdf#139331 Option to redact images in "Auto-Redact"
        
        Add images as target in 'Automatic Redaction' Dialog
        Tools -> Auto-Redact -> Add Target -> Type(All Images)
        
        This redacts the images with black rectangles.
        
        Change-Id: I0b5253df72199a286e268fedfc3db220bee6b5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183248
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-05-21  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [6064d732dc9baf06e2d778b0167f149ed212def9]

        tdf#166520 make OverlayManagerBuffered more aware of MapModes
        
        need to also use MapModeLastCompleteRedraw for the invalidates
        which are at OverlayManagerBuffered::invalidateRange. Calc is
        just completely unstable using MapModes at any Window. The one
        remembered at full repaint has to be the DrawingLayer one, so
        overlay works in DrawingLayer coordinates/MapMode(s)
        
        Change-Id: I6be133078ab27903592cdf75bd3d1d2bb77f189a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185563
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-05-21  Miklos Vajna  <vmiklos@collabora.com>  [117207b42185637f5ac56c61a7ff8eae681049d3]

        pdfium: backport FPDFAttachment_GetSubtype() API
        
        Upstream uses so much C++20 by now that updating pdfium is hard till we
        use clang-cl from VS2019.
        
        This is a fix for <https://issues.chromium.org/issues/408241034>, which
        is something David is waiting for.
        
        Change-Id: I74ec98081adb65a6d534874453f92ca90ac232f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185587
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46f2bd7e96cec80f57b12a60fefb16ecec866117]

        null deref of SfxMedium seen
        
         #1  SfxMedium::GetItemSet (this=this@entry=0x0) at libreoffice/sfx2/source/doc/docfile.cxx:3816
         #2  0x00007fa2526680d8 in SfxMedium::GetBaseURL (this=0x0, bForSaving=bForSaving@entry=false)
             at libreoffice/sfx2/source/doc/docfile.cxx:685
         #3  0x00007fa2526e184a in SfxObjectShell::getDocumentBaseURL (this=<optimized out>) at libreoffice/include/sfx2/objsh.hxx:271
         #4  0x00007fa2453fbb26 in SwOLEObj::GetOleRef (this=0x3370d698) at libreoffice/sw/source/core/ole/ndole.cxx:1027
         #5  0x00007fa2452e3ded in SwFEShell::IsSelObjProtected (this=0x3385dee0, eType=eType@entry=FlyProtectFlags::Content)
             at libreoffice/sw/source/core/frmedt/feshview.cxx:2714
         #6  0x00007fa245b117b1 in SwView::ImpSetVerb (this=this@entry=0x33857340, nSelType=nSelType@entry=SelectionType::Ole)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191
         #7  0x00007fa245b139de in SwView::SelectShell (this=0x33857340) at libreoffice/sw/source/uibase/uiview/view.cxx:312
         #8  0x00007fa245b14237 in SwView::AttrChangedNotify (this=0x33857340) at libreoffice/sw/source/uibase/uiview/view.cxx:580
         #9  SwView::AttrChangedNotify (this=this@entry=0x33857340) at libreoffice/sw/source/uibase/uiview/view.cxx:542
         #10 0x00007fa245b1ec82 in SwView::Activate (this=0x33857340, bMDIActivate=<optimized out>)
             at libreoffice/sw/source/uibase/uiview/view1.cxx:101
        
        Change-Id: I8913088b3dda4d8a85f990ee038bfaa282e61773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185579
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-21  Mike Kaganski  <mike.kaganski@collabora.com>  [bae4c7b360ee38393666f9111b5c823108671490]

        Drop operator!=, it's synthetized now
        
        Change-Id: I53eb5353c939589783dd70df0e1a6d12a4c5df4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185585
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-21  David Hashe  <me@dhashe.com>  [5c74b979eac620dc1a435fcdf9e88488fd4217d9]

        tdf#60700 stop creating empty UIConfiguration subdirs in ODFs
        
        This change stops the creation of various subdirectories of the
        Configurations2/ directory on new documents that do not have anything
        that needs to be stored in those subdirectories. Previously, LibreOffice
        would always create a bunch of empty subdirectories that were not
        necessary.
        
        Whenever an XStorage is opened readwrite on a path, it will immediately
        create that path. LibreOffice was opening all of these paths readwrite.
        So, the solution is to always open these paths as readonly, and then
        when we need to write data to them we close them and re-open them as
        readwrite. If we never need to write data to a path, then it won't be
        created.
        
        This patch specifically stops the creation of subdirectories that were
        being created directly by UIConfigurationManager. There are other paths
        that were being created by ImageManager and
        DocumentAcceleratorConfiguration, and those paths will be handled by
        other patches.
        
        Test coverage was added in aaed16eef8b2d32ac02c8cb3a42ca25246cb0d33
        
        $ CPPUNIT_TEST_NAME="Test testTdf69500" make CppunitTest_sw_odfexport
        
        I also manually tested with the following procedure:
        
        1. Open a new document in writer.
        2. Tools > Customize > Toolbars.
        3. Set scope to "Untitled 1".
        4. Add a new toolbar "New Toolbar 1".
        5. Add any command from Available Commands to the new toolbar.
        6. OK.
        7. Visually verify that the toolbar is present.
        8. Save the document.
        9. Verify that the toolbar is saved correctly inside the file.
        
        $ unzip -l Untitled\ 1.odt
        Archive:  Untitled 1.odt
          Length      Date    Time    Name
        ---------  ---------- -----   ----
               39  2025-04-25 23:35   mimetype
              353  2025-04-25 23:35   Configurations2/toolbar/custom_toolbar_2a773c3.xml
                0  2025-04-25 23:35   Configurations2/accelerator/
                0  2025-04-25 23:35   Configurations2/images/Bitmaps/
            12645  2025-04-25 23:35   styles.xml
              899  2025-04-25 23:35   manifest.rdf
             3563  2025-04-25 23:35   content.xml
             1012  2025-04-25 23:35   meta.xml
            14748  2025-04-25 23:35   settings.xml
              318  2025-04-25 23:35   Thumbnails/thumbnail.png
             1180  2025-04-25 23:35   META-INF/manifest.xml
        ---------                     -------
            34757                     11 files
        
        10. Close and reopen the document.
        11. Visually verify that the toolbar is present.
        
        Change-Id: If0a93675204576b3b6f7fe9113cada398e4da2ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184655
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [536f04b08eb68f0b2715f36e31cddc277ac9bda3]

        reportdesign: Declare var where it's assigned
        
        Change-Id: I3bceb7ba549adf1f49561166dade106b75c5449d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185571
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [38c0897854f1e217f256535cc9acac221752d9a0]

        reportdesign: Switch OSL_ENSURE -> assert
        
        Change-Id: Id9613b3a1b7c3bcea8f4951db6c5057d89829fba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185570
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [f2c843540a7c4b6228bebeedc61fe7c463e7c9f0]

        reportdesign: Flatten OReportEngineJFree::createDocumentAlive
        
        Add early returns to decrease nesting level.
        
        (`git show --ignore-space-change` helps see the
        "actual change" more easily.)
        
        Change-Id: Ib51b2665b8a680e310cc3f9927959838db4ef6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185569
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c47278ba0648f83a828167715cd71d000d20f6a3]

        tdf#164794 - Show complete list of recent documents in the macro window
        
        Change-Id: I7da0d13f4680bee0df50c57264e0263d0ab5c923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185580
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2025-05-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b8f23b6946f819f57c4115d2f6fd75b923b76c6b]

        tdf#166662 Improve bad range name error msg.
        
        Change-Id: I1cab4ba325422a7ebc9fa5a48fc9ac7419599742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185559
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a940660adba4597b29896838097d3480e484c16]

        PPTX: add "glue points" to all remaining shapes
        
        Similar to
        commit e6b974fd699dcef28a7c26a96c74f3b9a8df9cab
        Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        Date:   Mon Apr 22 16:09:04 2024 +0200
        
            tdf#157216 PPTX: add "glue points" to flowchart shapes
        
        Generated running oox/source/drawingml/customshapes/generate.sh
        
        Change-Id: I27d6b5b72590d24e35367c0290a1e79cc4aca5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185574
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [6f88c6e132897e75a7a17b4daaf86e843253bbc0]

        tdf#159774: PPTX: add "glue points" to can shape
        
        Similar to
        commit e6b974fd699dcef28a7c26a96c74f3b9a8df9cab
        Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        Date:   Mon Apr 22 16:09:04 2024 +0200
        
            tdf#157216 PPTX: add "glue points" to flowchart shapes
        
        Generated running oox/source/drawingml/customshapes/generate.sh
        
        Change-Id: I4eac759e970554f14ee4c1b64328de85448b8d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185573
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [6771eb320ca0f550caecdbe6fe6b263e89cf6ac1]

        tdf#166587: PPTX: add "glue points" to upArrow shape
        
        Similar to
        commit e6b974fd699dcef28a7c26a96c74f3b9a8df9cab
        Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        Date:   Mon Apr 22 16:09:04 2024 +0200
        
            tdf#157216 PPTX: add "glue points" to flowchart shapes
        
        Generated running oox/source/drawingml/customshapes/generate.sh
        
        Change-Id: I6a8f3d6ff16120d34219756890fe3b6912f1b11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185572
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-20  Heiko Tietze  <tietze.heiko@gmail.com>  [9e1470c07d7dc4f43c6bf98226583ee14e83c480]

        Resolves tdf#166594 - Reuse the Welcome dialog for WhatsNew
        
        * some nicer strings, depending on whether run as first-start
          dialog or after an update
        * checkbox to not show the dialog again (but the infobar)
        
        Change-Id: I6b1fafbf70e06a80a4e92864acce5cd16b85bc8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185552
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [91f0cb5400d929866062375305c77959bbaeeed0]

        Fix typo
        
        Change-Id: I093a627173fda2b80d6e29a3c0ef3f09613630ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185558
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-20  Jonathan Clark  <jonathan@libreoffice.org>  [e92cb38d63187af20c894c63988ca3a7d35d6f04]

        tdf#162325 vcl: Fix overlapping CJK in vertical justified layouts
        
        This change fixes a logic error causing the rightmost (bottom-most)
        glyph to be shifted incorrectly inside GenericSalLayout::Justify() in
        vertical CJK text.
        
        Change-Id: I525df1496f576ddab26e051adc5e544896fe86e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185567
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-05-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [44fbe5b8d92f48ffdabc0af12f4d653ddaf24c3d]

        tdf#166662 Improve ext tips for named range naming rules.
        
        Change-Id: Ic1269cda02c1c2ced45241730a7ad931de289474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185568
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-05-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [28fb2aa2e3a13aecba50244fbf948623a905952c]

        tdf#166660 - Text Along Path in ToD
        
        Change-Id: I68498559b5e81e100fb6a25fbe14ab917d0ea2c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185556
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-05-20  Szymon Kłos  <szymon.klos@collabora.com>  [0ebfe72f27af2a699520ec63402bc71210def43a]

        lok: setup accessibility sidebar panel root
        
        - we need to point correct node to generate good JSON
          (Deck has dump method)
        - in case of a11y panel entries we are deeper in the structure
        - we need to assign correct LOKWindowId to the sidebar fragments
          to put widgets into correct basket
        
        Change-Id: I72a09acdbfae6c2688ee04b5593a457a7c518911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184716
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185562
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-05-20  Andras Timar  <andras.timar@collabora.com>  [415fdfe1ccd73dcb92571254e35c6526a71bd1cb]

        jsdialog: enable svx/ui/accessibilitychecklevel.ui
        
        Change-Id: I1387bac5412842f24f3c79674fa1a960ae8bb54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183702
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185561
        Tested-by: Jenkins

2025-05-20  Andras Timar  <andras.timar@collabora.com>  [994341e04228decfd35340042bf399b8abea00af]

        LOKit: hide Options button from a11y issues panel
        
        Change-Id: I9aa47cb1fd911a9a05b0bff673511cb66541380a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183705
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185560
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-20  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [519a0d93ac1d4a9b8aa50dc0a30f924bb4a608d4]

        Detach navigator from sidebar for online
        
        When online calls navigator send the json
        for just the navigator not the whole sidebar
        
        Create helper functions for sending full updates
        for navigator and siderbar to encapsulate magic
        strings all into executor.cxx
        
        Handle case for navigator entries on click. User will get specific navigation category entires onDemand when get the click event.Added `Navigator` option init.cxx same as we have for `sidebar` to handle events like `expand`,`select` etc...
        
        Above change credits of the patch goes to Nick Wingate (nick.wingate@collabora.com)
        
        What changes i did (Darshan):
        
         - We did not need ExpandEntireNavigator in content.cxx. As we will expand the navigator entries on demand when user clicks on the heading.
         - And the next thing i have added is we need to detach navigator for other apps as well.( impress, writer, calc & draw)
         - Small fix in SID_NAVIGATOR req handling(sd/source/ui/view/drviews2.cxx). Before we were not handling the incoming request properly after toggle window for SID_NAVIGATOR.
         - Solved conflicts on cherry pick for branch 25.04
        
        Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
        Change-Id: Ibbd2d224bce62e70e100c52085271f154e12c275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183296
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184251
        Tested-by: Jenkins

2025-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4db0dedc52a6b10681be758e9f9bbba2765d6a33]

        loplugin:finalclasses
        
        Change-Id: I56ba3f1d6a3bf90f1b3923ef54745a1582d6c85e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185541
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-20  Miklos Vajna  <vmiklos@collabora.com>  [1a340196237ed075b337e6a0ac9f8a45132053bb]

        tdf#166319 sw interdependent redlines: handle ODF export of delete under format
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, DOCX import
        works, but exporting to ODT turns the format-on-delete redline into a
        plain "format" redline.
        
        What happens is that various code only checks the m_eType of the first
        SwRedlineData of an SwRangeRedline, so format-on-delete is handled as
        format. But this is not correct: if the format-on-delete is to be
        accepted, then it's just a small detail that there was a format on top
        of it: the result should be text deleted from the document on accept,
        not accepting the the format changes and leaving the text in the
        document.
        
        Fix the problem by:
        1) Extending SwRangeRedline::Hide() and SwRangeRedline::Show(), so when
           the ODF export moves delete redlines to their own toplevel SwNode
           section, so it can refer to these ranges using a single SwStartNode
           index, this move happens for format-on-delete as well, not just deletes.
        2) Then can extend SwXRedlinePortion::GetPropertyValue()'s
           lcl_GetSuccessorProperties() to produce an XText for the deleted
           range of a format-on-delete redline.
        3) Finally consume this new XText in
           XMLRedlineExport::ExportChangeInfo().
        
        Note that this way a format redline can now have its own XText (in case
        it's on top of a delete), but we want to export the text only once, so
        restrict the content export for a redline to the 'delete' type.
        
        Change-Id: I91902a2ae4b464ace41717a196d19530be9d84d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185551
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b52384de6f09f124fef9405ccf273c0f5c3339d1]

        Remove obsolete fw declarations from writerperfect/ xml{help,script,security}
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ib5cfbeea3a5811f770dc82d31000e88ec0ea19d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184009
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [abe1c88fae4e396180e3d53c1a4df5a3ae924d14]

        cool#9200 form control: checkbox not shown when exporting to PDF/EPUB or printing
        
        Change-Id: I55f2285130914172a79c8c534f16ae6e2c3fa8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184689
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 4f7e331af8c8109f71cef4e66fa913572e9ab2ed)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184808
        (cherry picked from commit 5cdab87d35c4756814641120ddab7ffe6492208e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185169
        Tested-by: Jenkins
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2025-05-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [90e964d98a57ba12eae6b761008a76eb393116b9]

        chart color palette: ui panel is wrong in the lok case
        
        1) Current color palette is not visible in the sidebar panel.
        2) Setting up a custom color for a data series, the current color
        palette icon is not set to the no color palette image.
        
        Change-Id: I6fdcf84878c9e26a6a4ad3e2ba8628ee0dd28924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184438
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185144
        Tested-by: Jenkins
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2025-05-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [8870c3feb87de2d3d5144e49ddc8a6310a8f8ae5]

        chart color palette for data series: dialog tab pane
        
        Change-Id: I0877212c715d320e954fcd8089d4f984eae16ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184265
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185143
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins

2025-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [800674437dc3b893277794383d8535dd6e4be517]

        update credits
        
        Change-Id: Id5d1475802b700adbf01c99917bfbe28f16352b7

2025-05-20  Michael Stahl  <michael.stahl@allotropia.de>  [d3235480c5d68839f9ab1e6f85bddaafc2f354fb]

        LOCRDT sfx2: only connect with env var YRSCONNECT
        
        Change-Id: Icf5d5d0c647260febd2b3c8cee626ca50833aefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185330
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1c1bd41cf6c65ffb85f8abaaa2b0b0882fb72807]

        fix Gtk-WARNING GtkGrid does not have a child property called expand
        
        just resave with glade to fix this up
        
        Change-Id: I669df71054c451d908f7da73719e69b86edcd7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185472
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-20  Juraj Šarinay  <juraj@sarinay.com>  [9d1064fd5008ec1c3689069dac6e4b18e241cbf7]

        Fix two crashes when verifying (incomplete) signatures using NSS.
        
        Even though SignedData.digestAlgorithms is mandatory in CMS,
        the set can be empty. One ends up with a valid list containing
        a single nullptr. According to RFC 5652, one MAY reject signatures
        without signedData.digestAlgorithms.
        
        SignedData.certificates is OPTIONAL in CMS. If omitted, one gets
        nullptr instead of a list of entries. Rejecting such signatures
        is apparently OK for adbe.pkcs7.detached and required for
        ETSI.CAdES.detached.
        
        Change-Id: If0270bd3f2d4312947562ab68d2206ae47370b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185540
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [8d528d72303141a2a00a94b8755b90cf26d61ccf]

        Avoid some unneeded casting
        
        Change-Id: I6df49f9cf200b659dfe8a86e991d98b8a1ffa012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185547
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-20  Szymon Kłos  <szymon.klos@collabora.com>  [1cc2e48de00baafe4667f1dbfe0d59869c9570c9]

        Navigator: fix change detection
        
        Navigator was marked as changed even if no node was modified.
        After changing eg. bulet list (not header) which is not visible in
        navigator - we got messages. This is caused by wrong condition:
        "invisible" has to match with "sensitive" to be different state
        
        Change-Id: I622d69f9d3cfcec8724d87e18a7897660e8e2670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184834
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185508
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [82b8db03ddbdf6d3ad2a1d7661705ba64021cdc5]

        gpgme: upgrade to 1.24.3
        
        Downloaded from https://gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.3.tar.bz2
        
        Change-Id: I949a71a2bebdc37c592ba0b4364409ddbc0f3cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185544
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5fa790dace0af86d9cb2a05a1e9abf3f1d79f099]

        Remove obsolete fw declarations from vcl/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ie2c6e8c816f30178b6677f05a07bc024dafcb449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184008
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [681b1e5db9ea1c75ec2a16f88ab3ee4c4ae5057b]

        Remove obsolete fw declarations from UnoControls/ unotools/ unoxml/ uui/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I0cd96494bc3e2bdee4d1ed7ee14762d06b702f8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184007
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2d2ba477834895dcacff441df35d5a73974c3b45]

        Remove obsolete fw declarations from ucb/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I186a6e29a4a2a355ae0820c7b211db89c6d81d94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184006
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c537e7171209c16b4c4b33b1e62e9961ebf35be6]

        Remove obsolete fw declarations from toolkit/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I150270ff2fdb6ade19adb6f80af2b7caba650789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184005
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7becd80d9773eb056b85945c5e51277b2481aa0e]

        Remove obsolete fw declarations from sw/ (part2)
        
        found with bin/find-unneeded-includes --fwdecl
        
        checked rest of sw/source
        
        Change-Id: I70cf272ef543e5424ba10ffec761c446d25f29ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183909
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [9ab2578b3a832e75ad3c71477ad1850be236cc3f]

        tdf#166652: do not use FormatEmpty for proportional spacing < 100%
        
        The FormatEmpty optimization can't handle this spacing mode, it uses
        the text height without modification.
        
        The change in testTdf143384_tableInFoot_negativeMargins (fixing the
        test checking incorrect page number) is directly related: there are
        empty paragraphs there, with spacing formatted to 75% - ignoring
        which was the reason of excessive height causing an extra page.
        
        Change-Id: Ibfae8b102f88656a1b703cc73b71ab6ef28a3ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185542
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-20  Oliver Specht  <oliver.specht@cib.de>  [7075178198ddb4c5a1568160fb01cb67ecf16d5e]

        Scroll selection in combination with pictures fixed
        
        Follow-up to 7fc7dc679d61f7d5313733005c244c87d25f32fd
        In documents containing pictures the selection does now grow
        continuously instead of flickering before/after pictures.
        
        Change-Id: I2e2c521cc74a65b98027856f1ac2ebfdf78cba2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185522
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [f93e0514c5c859c9c027787ec757a90602b9cc48]

        connectivity: Drop dbtools::getDataSourceSetting taking const char*
        
        Switch all callers to use the other variant that
        takes const OUString&, which the now dropped variant
        was also calling internally.
        
        Change-Id: If7d2861dc570744444f25b8124cc04781d7772d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185536
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [d0b9e6473d1e0546eee5404806b0eb0d6e7193d1]

        reportdesign: Switch some params to const OUString&
        
        ... instead of passing const char* and converting to
        OUString in the implementations.
        
        Change-Id: Id6acc44eab8ae41add442ed76621cf95b6b901d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185532
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [8157eff1f19b3aa2d84ba2bc89927d18608d2c7b]

        vcl: Move RoadmapWizardImpl back to wizimpldata.hxx
        
        While RoadmapWizardImpl used to have vcl::Window specific
        members before
        
            Change-Id: I8d2becd4c9d84883d00222cccd35a9402df38ca5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 19 12:16:47 2025 +0200
        
                vcl: Have only one pointer to ORoadmap
        
        and
        
            Change-Id: I8d5ecd999dbee4b97ab2bd785aa5053db27f1240
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 19 12:25:22 2025 +0200
        
                vcl: Move RoadmapWizardImpl::maResponses to RoadmapWizard
        
        , it also gets used by the weld::Widget based
        RoadmapWizardMachine (that just didn't make use of the vcl::Window
        specific members).
        
        Therefore, now that the vcl::Window specific bits have
        been removed from the struct, move it back to where
        it used to be before
        
            commit 2d268b2fe518ccb5ba19ed225c033e9148d64f22
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 17 23:32:45 2025 +0200
        
                vcl: More clearly separate vcl::Window specific RoadmapWizard bits
        
        and only include that header for the source file
        containing the RoadmapWizardMachine implementation
        that was moved to a separate source file in
        
            commit c854f5aaae575a0570f79a225b80b53ed420578c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun May 18 01:00:33 2025 +0200
        
                vcl: Move RoadmapWizardMachine to own source file
        
        (which had helped to see the actual dependencies/relationships
        between the different classes/structs more clearly/easily).
        
        This finishes separating the weld::Widget based implementation
        (RoadmapWizardMachine) more clearly from the vcl::Window
        specific one (RoadmapWizard), as no vcl::Window related
        headers are included for the implementation of the former
        any more now.
        
        Change-Id: I9022569cbf7feac62234221937708ca5e1ba876f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185527
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [07ad2798f75a63d5c3ff55ddf3e88cac5fd41813]

        vcl: Don't use RoadmapTypes in RoadmapWizardMachine
        
        RoadmapTypes::ItemIndex is a sal_Int32 typedef used
        primarily for the vcl (i.e. vcl::Window based) ORoadmap.
        
        Don't use that in the weld::Widget based
        RoadmapWizardMachine for no apparent reason, but use
        other integer types appropriate for the context instead,
        which makes clearer this class is not directly related to
        ORoadmap (and doesn't make any direct use of vcl::Window
        anywhere, but makes use of the weld abstraction).
        
        Change-Id: I8a94e9d24abe6c4ec637f459094b9f8dbcd42992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185526
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [9b7604e14566e7f92131e9e06d0d61325d50eeb0]

        vcl: Move RoadmapWizardImpl::maResponses to RoadmapWizard
        
        These vcl::Windows (buttons) are only relevant for
        the vcl::Window based RoadmapWizard, not for the weld::Widget
        based RoadmapWizardMachine that also uses RoadmapWizardImpl,
        so move this to RoadmapWizard to get rid of any use of vcl::Window
        classes in RoadmapWizardImpl and thus RoadmapWizardMachine.
        
        Change-Id: I8d5ecd999dbee4b97ab2bd785aa5053db27f1240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185525
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [e6073530d9058f8bf3176a15f32cb9ea5ec94a3a]

        vcl: Have only one pointer to ORoadmap
        
        So far, RoadmapWizard had two pointers to the ORoadmap
        it uses (both pointing to the same object):
        
        RoadmapWizard::mpViewWindow had a vcl::Window pointer to
        the same object as the RoadmapWizardImpl::pRoadmap
        of its `m_xRoadmapImpl` was pointing to (both set in
        the ctor and disposed/unset in RoadmapWizard::dispose).
        
        Rename RoadmapWizard::mpViewWindow to
        RoadmapWizard::mpRoadmap and let it be the one and
        only pointer to the OWizard.
        
        Change-Id: I8d2becd4c9d84883d00222cccd35a9402df38ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185524
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [9aca8ef0dac45808823a3912131d9ba69f9c3327]

        vcl: Drop always true return values + fallback path
        
        RoadmapWizard::skipUntil always returns true since
        
            Change-Id: Ieea7ca5b6f0ce67ad6f3fac4942a6a62921bfe95
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 19 11:20:55 2025 +0200
        
                vcl: Switch DBG_ASSERT and OSL_FAIL to assert, drop early return
        
        , RoadmapWizard::skipBackwardUntil already did earlier.
        
        Change-Id: Ifde2dbcbfd09b8602d28b131437722baaa86cb6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185515
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [176bfa25ab34e4943880d8cad7a04ca95fd3a98e]

        vcl: Switch DBG_ASSERT and OSL_FAIL to assert, drop early return
        
        Take those serious so if there are any invalid calls,
        they can be detected and fixed.
        
        Change-Id: Ieea7ca5b6f0ce67ad6f3fac4942a6a62921bfe95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185514
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [fff9dcb058ae06bacc87f402a7df181dd032bfc0]

        vcl: Drop RoadmapWizard::GetOrCreatePage
        
        As is obvious since
        
            Change-Id: Ib45aac9d75a8b3d2f71e92b08ec19863cb9acb00
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 19 10:45:20 2025 +0200
        
                vcl: Don't search in always empty map
        
        , RoadmapWizard::createPage always returns nullptr.
        
        This also means that RoadmapWizard::GetOrCreatePage
        doesn't insert any "real" pages (and a `DBG_ASSERT`
        for the null page would already have been triggered),
        but may at most result in dummy pages getting added.
        That doesn't seem useful, so drop it altogether.
        
        If anything was relying on the code path triggering
        a `DBG_ASSERT` inserting dummy pages, that caller
        of RoadmapWizard::ShowPage should most likely be adjusted.
        
        Change-Id: I7a3e711073bd64cc8cbae004ac33c82e268bf280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185513
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [0b3cf125e5ef2295485b9f779a880113e69fc34a]

        vcl: Don't search in always empty map
        
        RoadmapWizardImpl::aStateDescriptors is always empty,
        as entries are never inserted. Therefore, drop it
        altogether instead of trying to find (non-existent)
        entries.
        
        Before
        
            commit 6fb45286490f866013c90a9d5dc4d296e67c7d04
            Date:   Sun Sep 1 13:42:22 2019 +0200
        
                loplugin:unusedmethods
        
        , there was a RoadmapWizard::describeState that
        would have inserted entries into the map, but
        it was already unused back then.
        
        This makes clearer that some methods don't actually
        do anything useful, which might be worth investigating
        further.
        
        Change-Id: Ib45aac9d75a8b3d2f71e92b08ec19863cb9acb00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185512
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [b45aea3beec03ec72a93f5692bcfc32ea093f62d]

        vcl: Drop always true RoadmapWizard::ShowPage ret val
        
        The method was always returning `true`, so drop the
        return value altogether, and the code paths in
        callers that would have handled a `false` return value.
        
        Change-Id: Icf37513da2bceb5df7e062f39498335139179e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185511
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [3d473098d3c8ba3eb4730bbc07a04fa66b4a0fb8]

        vcl: Merge RoadmapWizard::{Activate,Show}Page
        
        Change-Id: I2f3a92ae95abb89dcf31c37b28d73fc9fa87f73e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185510
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [b583b8b413f57250fed6e1d95303b2c46d7d8e28]

        vcl: Merge RoadmapWizard::enterState into caller
        
        The state param was ignored anyway.
        
        Change-Id: I4022c4aebf76bac679192f2e67218b96d662c5fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185509
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-19  Miklos Vajna  <vmiklos@collabora.com>  [96c28cf36c8d221c2d2fa50c320690a48f311ba7]

        sd: fix crash in SdXImpressDocument::GetViewShell()
        
        Crashreport:
        
        > SIG   Fatal signal received: SIGSEGV code: 128 for address: 0x0
        >
        > program/libsdlo.so
        >       SdXImpressDocument::GetViewShell()
        >               sd/source/ui/unoidl/unomodel.cxx:3844 (discriminator 1)
        > program/libsdlo.so
        >       SdXImpressDocument::getViewRenderState(SfxViewShell*)
        >               sd/source/ui/unoidl/unomodel.cxx:3957
        > program/libmergedlo.so
        >       doc_getCommandValues
        >               desktop/source/lib/init.cxx:6760
        
        Change-Id: I92d2f11b98709145f377a8dc0e469d6fe17ec9ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185507
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [f663f56d227b4cd3395710b1fdf99f73c5f6290a]

        ScTabViewTarget: pass ScTabViewShell by ref
        
        Change-Id: I1a0afa75ccccfc72188f839d462f71699ad1995c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185528
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-19  Mike Kaganski  <mike.kaganski@collabora.com>  [9dd884a6df1a00f56b81f7a4f05195a4e2b1ca71]

        Don't call EmptyHeight() twice
        
        Change-Id: Ic10d101387f38a687d8d05e6bb4c92eb24946003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185537
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [6190fe56f72008e0b6d0e502bf94099e72b9d202]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2b9ead8ea0b07c39d223b7e0483fa1aaa78457cb
          - update translations for master/25.8.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: Ie4d5aea7c579a79abf9c6ab5435e78c089a5b7dc
            
2025-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7a302c90274cbbf77713dc1b43ab8bcc8af4f863]

        create these in member init list
        
        Change-Id: Ib5296d10f7efd113950a340d1fb2bd9ecd85d931
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b22592c2fad4677e7bed01b03ab0a6cc02489862]

        OutlinerView always has an Outliner
        
        Change-Id: I73ea7d3224ace7f181aee75ae99d9c2897ac0819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185518
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7d0a028bc266e56d3e1f8ce4a84fc6f930dc0661]

        an EditEngine always exists
        
        Change-Id: I08aea62e3355f202b723cd0a30870334321af3d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185517
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-19  Mike Kaganski  <mike.kaganski@collabora.com>  [9a91a2899947bc906ea5b7b1a740f00cce04a3c0]

        tdf#166637: Do not dereference a result of UNO_QUERY unconditionally
        
        Change-Id: Ifdf3d6fe44ce93e28c679985959db5b56bb5580a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3bd061338efcc492bd039bbae1f922efc5ac9478]

        null deref of SfxMedium
        
         #1  SfxMedium::GetItemSet (this=0x0) at sfx2/source/doc/docfile.cxx:3816
         #2  0x00007d70ffdfc395 in SfxDispatcher::Update_Impl_ (this=0x250de660, bUIActive=true, bIsMDIApp=true, bIsIPOwner=false, pTaskWin=0x24dcbce0)
             at include/sfx2/objsh.hxx:271
         #3  0x00007d70ffdfe275 in SfxDispatcher::Update_Impl (this=this@entry=0x250de660, bForce=bForce@entry=true)
             at sfx2/source/control/dispatch.cxx:1121
         #4  0x00007d70ffe09955 in DispatcherUpdate_Impl (pArg=0x250de660) at sfx2/source/control/shell.cxx:662
         #5  0x00007d7101189d20 in Link<void*, void>::Call (data=<optimized out>, this=0x221a71f8)
             at include/tools/link.hxx:111
         #6  ImplHandleUserEvent (pSVEvent=0x221a71f0) at vcl/source/window/winproc.cxx:2285
         #7  ImplWindowFrameProc (_pWindow=<optimized out>, nEvent=SalEvent::UserEvent, pEvent=0x221a71f0)
             at vcl/source/window/winproc.cxx:2849
         #8  0x00007d710167754c in SalFrame::CallCallback (pEvent=0x221a71f0, nEvent=SalEvent::UserEvent, this=0x160a7d50)
             at vcl/inc/salframe.hxx:311
         #9  SvpSalInstance::ProcessEvent (this=0x136a0ed0, aEvent=...) at vcl/headless/svpinst.cxx:271
        
        Change-Id: I4abdb71e25aed5d4021d0d1684bb5171ad57a705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185503
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [3090535ed32fecfc8e19085537ed164be5283b11]

        ImportPPT: pass SdDrawDocument by ref
        
        Change-Id: Ie8cc94a924758e00f8b6c6103091f8f3636fb81a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185354
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-19  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [256ad05887a23484ef4494cc90ea168696bbba37]

        NDOO: NotesDisplayOnOverlay
        
        For Calc, showing Notes/Postit info on Mouse Hoovering was
        done by painting directly to the SplitWindows and invalidating
        there again. This created unneccessary repaints of the whole
        sheet. It was even painted 'after' the existing Overlay was
        painted to make that work/not collide.
        
        This is a perfect task for the Overlay where this info can
        be shown and hidden again without the need to repaint the
        calc sheet at that places at all.
        
        The new visualization does exactly that. It still is Timer-
        Based to not trigger this all the time (timings unchanged),
        but now creates the needed visualization on the Overlay.
        
        While the visualization data was not changed, the mechanism
        had to be changed to use transformations/overlay/primitives.
        
        This was partially complicated due to the 'combined split
        view' used to show that: The SdrCaptionObj can span over
        multiple windows in split view, separated by the window
        framing lines - it looks like a glass window with segments,
        with the visualisation being shown 'behind' the cross.
        Technically this means that the same visualisation data
        has to be shown - dependent on the view split used - in
        up to four windows. This just uses the same primitives
        for visualisation embedded in the needed transformation
        primitives.
        
        Also the previous version created and destroyed a SdrModel
        and SdrPage (complete with ItemPoos and ItemSets) for
        every visualization, this is no longer needed, too.
        
        Change-Id: I18c6d63d346ea89fca21a4d856ad66c82156a774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185417
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-05-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [83ce76aff65f03c2ba6fb02c5621ce5e1bd3d0d1]

        Fix storing recent directory for Extension->Add dialog
        
        Need to use the filedialoghelper methods, otherwise the
        directory will not be stored properly.
        
        Change-Id: Ib5f380ccd46d8c6c1cfa007cfe745a0aad43963e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185504
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72e93e138abfe68b5591fee9c160bdb2779a523a]

        cid#1647013 Uncaught Exception
        
        Change-Id: I9b88f9a3bbcd2c80ba25d0d86b2adf80b5fd8024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-19  Miklos Vajna  <vmiklos@collabora.com>  [ff110bb17b7e003bd205438af94badabeca007c6]

        tdf#166319 sw interdependent redlines: handle ODF import of insert under format
        
        Open the bugdoc, the ODT file has an insert with a format on top of the
        middle, but the format is lost in Writer.
        
        It seems what happens is that the XML parser correctly populates the
        RedlineInfo structure, but then XMLRedlineImportHelper::ConvertRedline()
        decides to throw away the underlying insert using an explicit condition
        that was added in commit 52d244dee88b111631680d8cd4c8b922f9640c15 (-
        added: redline import, 2001-01-10).
        
        Fix this by extending it similar to the accept redline's
        CanCombineTypesForAcceptReject() by adding a CanCombineTypesForImport()
        that now accepts insert-then-format, too.
        
        This is similar to what was fixed for DOCX in commit
        ed8257a67d26083c2c6cd60ecac331c9e0df15ed (tdf#166319 sw interdependent
        redlines: handle format on top of insert, 2025-04-29). The ODT export
        was working already as-is.
        
        Change-Id: I2163b0350ca56264ebed5abd54735ef4d91ee2ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185500
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-19  Miklos Vajna  <vmiklos@collabora.com>  [085b0ec9cdd8ffbda91e0f3c8c3e7e714024fdd4]

        svx: prefix members of XFillFloatTransparenceItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I811466a635bbeb34639f27f63a11ae791768065c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185496
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [a5239bd4a8ceba49996df84d31400e573dd9cfa1]

        win: Fix --disable-skia Windows build
        
        ... which after
        
            commit 4a4d388e17ae7490ed36f4bb0dd21fbefcdda124
            Date:   Wed May 7 01:58:16 2025 +0200
        
                simplify CompatibleDC
        
                This class is only really used by the skia case. The non-skia
                (i.e. GDI) case completely bypasses it.
                So we can remove the hierarchy and just make it into a skia focused
                class, simplifying the code structure in the process
        
        was seen failing like this:
        
            C:\Users\mwegh\development\git\libreoffice\vcl\inc\skia/utils.hxx(34): fatal error C1083: Cannot open include file: 'SkRegion.h': No such file or directory
            make[1]: *** [C:/Users/mwegh/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:338: C:/Users/mwegh/development/git/libreoffice/workdir/CxxObject/vcl/win/gdi/salnativewidgets-luna.o] Error 2
            make: *** [Makefile:301: build] Error 2
        
        Change-Id: Iaa0f6d3da85467bae07d55b5dba9a4bd68cc784d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185473
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [c854f5aaae575a0570f79a225b80b53ed420578c]

        vcl: Move RoadmapWizardMachine to own source file
        
        Don't intersperse the method implementations of the weld::Widget
        based RoadmapWizardMachine with those for the vcl::Window based
        RoadmapWizard, but move the RoadmapWizardMachine ones to a separate
        source file, to make the distinction clearer.
        
        Also rename the roadmapwizard.hxx header to roadmapwizardmachine.hxx
        accordingly, as it contains the declaration of the RoadmapWizardMachine
        class whose method implementatons are now in the new source file
        called roadmapwizardmachine.cxx.
        
        Change-Id: I4aa2933c496c0a26a70ef3027f45c87d1a0b61bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185466
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [7c6dd50c96a312932b332db95935c5f66d501e0c]

        Clarify comments/debug output mentioning RoadmapWizard
        
        ... when they're not actually meant to refer to the vcl::Window
        based RoadmapWizard class, but either RoadmapWizardMachine
        or WizardMachine.
        
        Change-Id: I8ae2028d82d87433228f541b3e82b5de4e6d1180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185465
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [339f9a79f93f4bb54271c52933b29777f6115f14]

        extensions: Drop OAddressBookSourcePilot_Base typedef
        
        Change-Id: I7a410a9609a63f4857242c05cbed56784963b276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185464
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [4cc7d063392157df280c40f0355ff8bc910ff139]

        vcl: Move defines to only source file using them
        
        These are only used by the vcl::Window based RoadMapWizard
        implementation, so don't need to be in a global vcl header.
        
        Change-Id: I2abc4d8f26716e3e612b02f0e9c889e99e828bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185463
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [2a56b12245e2596dae342fcea8601328663bb3ab]

        vcl: Use more specific include
        
        This doesn't need to include the header for the
        vcl::Window specific implementation any more.
        
        Drop that one and instead add include for
        RoadmapWizardMachine that was previously included
        indirectly.
        
        Change-Id: Ifa0aa042db87adaad96d4ea23fa93dae1b8b1ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185462
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [2d268b2fe518ccb5ba19ed225c033e9148d64f22]

        vcl: More clearly separate vcl::Window specific RoadmapWizard bits
        
        Move code related to the vcl::Window specific implementation
        from vcl/source/control/wizimpldata.hxx that's also included
        by sources for the weld::Widget based abstraction to
        vcl/inc/wizdlg.hxx which is the header for the vcl::Window
        based implementation, to more clearly separate the vcl::Window
        specific bits from those not depending on vcl::Window.
        
        Reorganize includes accordingly.
        vcl/source/control/wizimpldata.hxx now no longer needs
        any `vcl/toolkit/` includes.
        
        Change-Id: Idd8652cada4cfc9a20957a86892544d779cdc692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185461
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [4a160b016cb3fbad3f765115f02e9e53249bbfb9]

        vcl: Move RoadmapWizard method impls to corresponding source file
        
        Move these implementations of the vcl::Window based
        RoadmapWizard to the existing source file where the
        other methods of that class are implemented, instead
        of having some of them in the source file for the weld::Widget
        based WizardMachine, while others are elsewhere.
        
        Move definition of two strings needed by both of them to
        a header that both already include.
        
        Change-Id: I8ece77cbc9d1d8a52b1e3dcedb7b70ac8a310eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185460
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [646734878fecb44f2aeab6fd116edfa0099075cb]

        vcl: Use #pragma once
        
        Change-Id: Id1088364587fc0c47f77cb3657cd3074e806dc52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185459
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [6ca73a2ba232e4ba003fed5d14334f4827a967ad]

        vcl: Move ImplWizButtonData definition to where it's used
        
        As this uses a vcl Button, it's specific to the vcl::Widget
        based implementation, so move it to the header where that
        one is declared.
        
        Change-Id: I9b64517541cb67df66ff8530589b0608076a88e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185458
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [fc42bd1e23fb70f291db74fa5745695befca66f9]

        vcl: Drop unnecessary include
        
        Change-Id: I1fa5b7076c5028a7fed4e816506651558f5eb81c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185457
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-18  Mike Kaganski  <mike.kaganski@collabora.com>  [a12ac9f4da5efd114c84720834ec11fabd01d0fb]

        tdf#166620: don't strip leading tab from footnotes/endnotes anymore
        
        Before the fix for tdf#159382, the layout of footnote/endnote number
        was incompatible between Writer and Word; in Writer, a spacing was
        always created between them, while in Word, there was none. This
        meant, that to create a Word file format with a footnote/endnote
        that looked similar to what Writer showed, we needed to put a tab
        in the beginning of the exported note text; and on import, we needed
        to strip it away.
        
        The fix for tdf#159382 introduced NoGapAfterNoteNumber compatibility
        flag, which avoids the extra space between the note's number and its
        text. This flag it active for all Word file formats; so we need to
        keep the tabs in the beginning of the note text, or else we show it
        wrong.
        
        This change drops the code that stripped the tabs, reverting part of
        commit fcbc2fc4ae4ea9a499616bfeaa6a2cbece93f01a (INTEGRATION: CWS
        tuamfilterteam23 (1.95.10); FILE MERGED, 2004-02-26), and also commits
        b38629ae210b204a6d24d6e9c5c62eaaf563d494 (cp#1000017 DOCX/RTF import:
        avoid fake tab char in footnotes, 2013-12-05),
        946fee3ef1e319ad63a599b72dbd55ef52cbc640 (tdf#106062 ooxmlimport: skip
        fake tab only on hanging indent, 2018-04-24), and
        a3783c0af4bd21eb9c001aadc60c660c06a47779 (tdf#106062 ww8import: skip
        fake tab only on hanging indent, 2018-04-28).
        
        Also, it makes sure to avoid outputting a tab from a document with the
        compatibility flag set, even when the note doesn't start with a tab.
        
        Change-Id: I8fa085d3ba45367476853723c6ccba1b047eb092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185471
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-18  Noel Grandin  <noelgrandin@gmail.com>  [c5fe3bfdee9b910b998e8f2bf31ca9c2c20739d7]

        rename mbGraphics -> mbGraphicsAcquired
        
        to improve its readability, I never know what the flag means
        
        Change-Id: If862ac36f6951b5cedf0299b522bdba72d843a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-18  Noel Grandin  <noelgrandin@gmail.com>  [dedc5ed4f9964cd097cf031aff3d686832d3c462]

        simplify WinSalFrame::AcquireGraphics
        
        inline InitFrameGraphicsDC, simplify the resulting logic,
        and reshuffle a little to avoid a leak in the unlikely possibility
        that GetDC returns nullptr.
        
        Change-Id: I6ebe15ee1d395a3a91db8c1e201b88f89e26806a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185455
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [352a99969281c645b1d0f6bc2688bde30b47cd0d]

        cid#1646936 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iff4b0178bc83f58490296e69381704501c149c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185449
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8686f289dfedb837be5e8c6273944960d1b8b481]

        cid#1646938 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifea2dd63f0e10cf2440fddc1e0d5231f7da617f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185448
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [2b9582f8e1a10e99827e692a9dab50d064ce3472]

        Avoid storing data for delayed deduplication in MarkManager itself
        
        This decreases the size of MarkManager. The two maps (introduced
        in commit 8015a6c9e6b2e67184fdea6c897ff8036a488ca5) take space,
        and are only used when loading.
        
        Change-Id: Ic88438266e383091d0a70658073d7adbee0256ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [866c93e09f24f86ade8d58a6ef4f396376978d2c]

        Fix typo
        
        Change-Id: If83fc16c8e0b5f8ca4495e3dc50d3a82040c5e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185445
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4816397d92e4e4659ac9ef9b8c09cd072f57c2b6]

        Fix typo
        
        Change-Id: I3bef7402132a25aca94866eb69a65e22c12d508d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185447
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [21e1f9ff6e6c13023c461144f4c610d070003e44]

        Drop wrong comment
        
        It was created while working on 8015a6c9e6b2e67184fdea6c897ff8036a488ca5,
        in an intermediate stage. It became incorrect in the final state.
        
        Change-Id: Iaaf9506a9070db2007f9be48852d0f66be50b1f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185443
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-17  Shantanu Oak  <shantanu.oak@gmail.com>  [747b4fb8fa0ab4c52132181c3bc94f674ffc0363]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0852a97a30c0bd66d57bde88a77a84c65a5c9fff
          - add integration files for Marathi
            
            Change-Id: Icb7d2258b17dd7b877fbd43bbd91ca3816c12cf1
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185165
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [9585f2400eb1dee4ee345e7e659203410d1a6909]

        loplugin:unusedmethods
        
        Change-Id: If9b083dd1a4ffcf093ee8af0c654df7fdb38e220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185413
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-17  Andras Timar  <andras.timar@collabora.com>  [e22179f641fa9f844d142f7e233c0aee2b1e9a2e]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to cebbc797e0fc01bd5f8063a8d7222fd60544c718
          - Oriya (or Odia): add missing integration files
            
            Without these files the dictionary would not appear in LibreOffice
            and would not be used.
            Without modifying Module_dictionaries.mk the dictionary would not be
            even built.
            
            Change-Id: I8e88870b3e46ad401fcfe4651a23a1503a75088a
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185130
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Andras Timar  <andras.timar@collabora.com>  [c0d87de4f5311558e6a19731aec02a7d3d1a96fa]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 6649d797520d19bd3d902b86e38ae0dae2978414
          - Assamese: add missing integration files
            
            Without these files the dictionary would not appear in LibreOffice
            and would not be used.
            Without modifying Module_dictionaries.mk the dictionary would not be
            even built.
            
            Change-Id: If9b6e057a6c452feb6c1c002a58e62e02968f251
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185129
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Andras Timar  <andras.timar@collabora.com>  [70fceb348e3635919e5c6847718ec7384fddcb1d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5be65995995e1bc7a0379d13d20404d093d1d24f
          - Kannada: add missing integration files
            
            Without these files the dictionary would not appear in LibreOffice
            and would not be used.
            Without modifying Module_dictionaries.mk the dictionary would not be
            even built.
            
            Change-Id: Ib704f26a8baeba2290f07ef311d6b648a76e99f6
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185128
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Andras Timar  <andras.timar@collabora.com>  [ff1889d60674bcf552ed93f99b9ed404a748bdcb]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 390b7976f0877245c68ba6d85bcec9320c2590e0
          - Tamil: add missing integration files
            
            Without these files the dictionary would not appear in LibreOffice
            and would not be used.
            Without modifying Module_dictionaries.mk the dictionary would not be
            even built.
            
            Change-Id: I1d6a266b1e57895c974b68405b9b39764d5fd7f8
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185127
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Andras Timar  <andras.timar@collabora.com>  [65e7696dd4b34b03341e8c439ee84033c8498e95]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1d83225df00bdae6e6ea49c19cc1fb7e08528fa0
          - Bengali: bn_IN.* files are unused
            
            bn_IN.dic and bn_IN.aff were identical to bn_BD.dic and bn_BD.aff
            In dictionaries.xcu it has been already defined that bn_BD.dic and
            bn_BD.aff should be used for both bn_BD and bn_IN locales.
            
            Change-Id: Ic7134f59df598fd2da250735a56720af9cc42d20
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185126
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [2d33669a535892a9424776e87f928a9321bfbd42]

        tdf#130857 qt weld: Report released mouse button in event
        
        As the QSinglePointEvent::buttons doc [1] says:
        
        > For mouse press, double click, or TabletPress events, this includes the
        > button that caused the event.
        >
        > For mouse release or TabletRelease events, this excludes the button that
        > caused the event.
        
        However, LO expects the released mouse button to be set
        in the MouseEvent passed to weld::Widget::signal_mouse_release
        (in QtInstanceWidget::eventFilter).
        
        Therefore, also include QSinglePointEvent::button (without an "s")
        at the end, which "returns the button that caused the event." [2]
        
        Without this commit in place, clicking into the table of available
        characters in the special characters dialog (in a WIP branch
        experimenting with adding support for that dialog for
        SAL_VCL_QT_USE_WELDED_WIDGETS=1) was resulting in the
        mouse getting grabbed, but the mouse kept being grabbed when the
        left mouse button was released, meaning that e.g. clicking on buttons
        in the dialog had no effect.
        
        This is because the `rMEvt.IsLeft()` check in
        SvxShowCharSet::MouseButtonUp returned false:
        
            bool SvxShowCharSet::MouseButtonUp(const MouseEvent& rMEvt)
            {
                if ( bDrag && rMEvt.IsLeft() )
                {
                    // released mouse over character map
                    if ( tools::Rectangle(Point(), GetOutputSizePixel()).Contains(rMEvt.GetPosPixel()))
                        aSelectHdl.Call( this );
                    ReleaseMouse();
                    bDrag = false;
                }
        
                return true;
            }
        
        [1] https://doc.qt.io/qt-6/qsinglepointevent.html#buttons
        [2] https://doc.qt.io/qt-6/qsinglepointevent.html#button
        
        Change-Id: I88f8314d037a1bcc462a5c4a6cdabd1f70d81bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185440
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [de4293cadce09ac87e8cff8cf016d0a5852aeaaf]

        tdf#130857 sw: Don't use GtkBox inside button box
        
        At least the Qt equivalent of a GtkButtonBox, a
        QDialogButtonBox, doesn't support "random" widgets,
        but only subclasses of QAbstractButtonBox.
        Therefore, place the "previous" and "next" buttons
        directly into the button box without an extra
        GtkBox parent.
        This makes the visual appearance of those buttons
        match the others in the dialog more, and makes them
        show up in a WIP branch where support for that dialog
        is declared when using native Qt widgets with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 in the second
        scenario of that dialog where the buttons are
        displayed as described in previous commit
        
            Change-Id: I47f6bae6978e05787d3de83ccce8660b6a5d8301
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 16 21:27:45 2025 +0200
        
                tdf#130857 qt weld: Fall back to icons from system (theme)
        
        Change-Id: I5f178f100727bb4f3c48127eace7e0b28d71229e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185439
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [332da91c79114dafc51f8014cd7905cb813b3faa]

        tdf#130857 sw: Don't use "pack-type" of "end" in insertfootnote.ui
        
        Avoid using that because it's no longer supported in GTK 4
        and no special handling for it is implemented in the QtBuilder
        either, see also
        
            commit 58544c8fec07b151bb74094e1a0be8b965caf1e9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Jan 18 18:05:39 2025 +0100
        
                tdf#130857 templatedlg.ui: Don't use "pack-type end"
        
        for more background.
        
        Explicitly set positions for elements in the dialog
        to keep the visual order as it was.
        
        No change in behavior intended or observed when testing
        that dialog with the gtk3 or gen VCL plugin on Linux
        for both scenarios mentioned in previous commit
        
            Change-Id: I47f6bae6978e05787d3de83ccce8660b6a5d8301
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 16 21:27:45 2025 +0200
        
                tdf#130857 qt weld: Fall back to icons from system (theme)
        
        Change-Id: Ib57409e4360f6f2d4b0115d7ac8d5785cf010602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [490332c837afc9af854c6d6d48f15c7454b87dcf]

        tdf#130857 qt weld: Implement methods to set font
        
        Add new `toQtFont` helper to create a QFont from
        a vcl::Font which reuses the existing static helper
        methods from the QtFont class and use that to implement
        `set_font` methods that various weld::Widget subclasses
        have via a helper method newly introduced to weld::Widget.
        
        Handling more attributes should be possible in the future
        if necessary.
        
        This gets used e.g. by the "Insert" -> "Footnote and Endnote"
        -> "Insert special Footnote/Endnote" dialog in Writer
        (see SwInsFootNoteDlg::Init).
        
        SwInsFootNoteDlg: :Init
        Change-Id: I14e1099f724866573a04acd4a1aa709c439bcd22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185437
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [acea738b952ac39f6311cd61a025debb4093ecc9]

        tdf#130857 qt: Make some helpers static QtFont methods
        
        Make some local helper functions to apply vcl Font attributes
        to a QFont static methods of the QtFont class and take a
        QFont instead of a QtFont param.
        
        This will allow reusing these methods from elsewhere in an
        upcoming commit.
        
        Change-Id: I35a6ff34dc46fd6f65de2a4f584ed01c83a83b5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185436
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [83763196a3d610d6693de805e0747d8427a011d8]

        tdf#130857 qt weld: Fall back to icons from system (theme)
        
        If no icon for a given icon name can be found in the LibreOffice
        icon themes, fall back to using non-LibreOffice icon themes, e.g.
        the Breeze one used by default on KDE Plasma.
        
        This is e.g. relevant for the "go-previous" icon used in Writer's
        "Insert" -> "Footnote and Endnote" -> "Insert special Footnote/Endnote"
        dialog.
        
        Without this commit in place, this would trigger the
        
            assert(!aPixmap.isNull() && "Failed to create icon pixmap");
        
        in the `QPixmap toQPixmap(const BitmapEx& rBitmapEx)` helper
        in a WIP branch where support for that dialog is declared
        for SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        The button using that icon isn't actually visible when
        triggering the dialog as described above, but is when
        right-clicking on an existing footnote anchor and selecting
        the "Footnote/Endnote" context menu entry to open the dialog
        for editing the existing footnote.
        
        Change-Id: I47f6bae6978e05787d3de83ccce8660b6a5d8301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185435
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [4c46569bcf54ee454147ad0531c6e14ec6c68fe7]

        sw: Resave insertfootnote.ui with glade 3.40
        
        This dialog can be triggered using "Insert" -> "Footnote and Endnote"
        -> "Insert special Footnote/Endnote" in Writer.
        
        Change-Id: I40a9bcb77015581dde6e983bff5668fef84c898b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [94231af057db7871fb993582e2015c0fa21dde46]

        move stray EditView member into its impl
        
        Change-Id: I53732c0d7acb2dc9d0ffb51999d93cc7aa274e46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae5220b761f131126641e11ab691d39d22e1bc74]

        ScEditUtil::GetString: pass ScDocument by ref
        
        allowing to drop ScGlobal::GetStaticFieldEditEngine();
        It was added in
        
        commit 1ecdc7aaf661e97a33cf521f553481d79cd26de2
        Author: Eike Rathke <erack@redhat.com>
        Date:   Thu Jul 25 15:33:49 2013 +0200
        
            resolved fdo#67249 use ScFieldEditEngine to resolve field content
        
        Also adapt the testRichTextContentODS unittest
        
        Change-Id: I06eb1b2b4fcc35867531c645098d854dd9907bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185406
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-16  Justin Luth  <jluth@mail.com>  [5ff1fd13f1879105ecc0541c55f30cea32ae54f4]

        tdf#166510 writerfilter: move empty sectPr bottom margin to prev para
        
        This is follow-up to my 25.2.3 commit for tdf#165047:
            sw mso-compat layout: always consolidate top margin
        
        The problem here was not the consolidation itself,
        but the fact that the paragraph after the section page break
        needs to consolidate based on the below spacing of the sectPr paragraph
        and we simply deleted that info along with the empty sectPr.
        The result was that consolidation was working with the wrong number.
        
        Since the bottom margin of the previous paragraph
        has no impact on the empty sectPr,
        we can simply transfer the sectPr's spacing to the previous paragraph,
        which of course now becomes the last paragraph before the page break.
        
        Slightly unexpected were some examples where no spacing was identified
        for the sectPr context. The unit test includes this complication...
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf166510_sectPr_bottomSpacing
        
        Change-Id: I9bcae239480035b02653ec93a37f6bf05d135d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185424
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [1724c2fe47d36ac8f8049e428ebfa7284b390a14]

        LOCRDT sw: fix undo of deleting comment
        
        CppunitTest_sw_uiwriter4 CPPUNIT_TEST_NAME="testRedlineViewAuthor"
        fails because Undo of deleting a comment doesn't add it back to the yrs
        model
        
        Change-Id: Ib8d559799a350d7d12caadcde1630ab904211b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185425
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [5f0f477f7aecb59d378497094a3535f1b7bd40bf]

        LOCRDT sw: fix crash on deleting comment in hidden text
        
        CppunitTest_sw_mailmerge CPPUNIT_TEST_NAME="testMissingDefaultLineColor"
        calls RemoveInvisibleContent() which deletes a comment and there are 2
        problems:
        
        1) the comment doesn't have an SwAnnotationWin because it's in hidden
           text - so YrsRemoveComment needs to be able to find it with only the
           anchor position, as the comment id is only available from EE
        
        2) the comment wasn't even inserted via YrsAddComment; not sure why,
           presumably because it was inserted via insert file?
           Ignore this for now, just avoid crashing...
        
        Change-Id: Id1e925911ef35d230ad5e35df3ebfdcfbb734558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185421
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [4ec57814fae16d16f9c87178402d52ba3a3c8eb1]

        LOCRDT sw: more test failures
        
        * CppunitTest_sw_a11y CPPUNIT_TEST_NAME="TestMenuInsertPageBreak"
          missing type check in SwFieldMgr::InsertField()
        * CppunitTest_sw_odfexport4 CPPUNIT_TEST_NAME="testTdf160877"
          inserts stuff from SwEditShell ctor so there's a shell calling
          YrsNotifyCursorUpdate() which isn't a SwWrtShell yet...
        * CppunitTest_sw_uiwriter5 CPPUNIT_TEST_NAME="testImageCommentAtChar"
          triggers assert in YrsAddComment() by intentionally adding annotation
          mark with start == end
        
        Change-Id: Ic619b7188c63d30b63916976870c74da10e8c4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185418
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [ff36b49496445b8014b2685d7844152acf86fa9d]

        sd presenter: Reduce code duplication for RTL
        
        Change-Id: Ib2205499556bb8736b065ed4f81d6cad8647b95c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185410
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [55b13d5faf3ad9e716c196a263cb86c5408b9284]

        tdf#160094 sd presenter: Simplify RTL-specific handling
        
        Simplify the RTL-specific handling in PresenterToolBar::LayoutPart.
        
        If RTL is enabled, elements arranged horizontally should be
        in reverse order to non-RTL mode, but elements in a vertical
        container don't change their order within the container.
        
        Implement the logic to be like this.
        
        So far, there was a (non-obvious) implementation
        achieving the same by using implementation details
        of the (default) toolbar configuration in
        officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu:
        
        Processing starts with horizontal orientation. The only
        vertical elements are those 3 elements between the
        two "ChangeOrientation" nodes in the xcu file
        (s. below for reference):
        
        * a "CurrentTimeLAbel"
        * a "HorizontalSeparator"
        * a "PresentationTimeLabel"
        
        The special
        
            // reverse presentation time with current time
        
        handling in the RTL code path in PresenterToolBar::LayoutPart
        was handling those elements special by relying
        on their exact index within the vertical
        container. That does work for the default configuration,
        but is not very straightfoward, and would break if
        the config were ever changed.
        
        Instead, just don't revert the order for vertical
        containers at all.
        
        Relevant part from the .xcu file for the three
        elements:
        
                  <node oor:name="f" oor:op="replace">
                    <prop oor:name="Type">
                      <value>ChangeOrientation</value>
                    </prop>
                  </node>
                  <node oor:name="g" oor:op="replace">
                    <prop oor:name="Type">
                      <value>CurrentTimeLabel</value>
                    </prop>
                    <node oor:name="Normal">
                      <node oor:name="Font">
                        <prop oor:name="Size">
                          <value>18</value>
                        </prop>
                        <prop oor:name="Style">
                          <value>Bold</value>
                        </prop>
                        <prop oor:name="Color">
                          <value>ffffff</value>
                        </prop>
                        <prop oor:name="Anchor">
                          <value>Center</value>
                        </prop>
                      </node>
                    </node>
                  </node>
                  <node oor:name="h" oor:op="replace">
                    <prop oor:name="Type">
                      <value>HorizontalSeparator</value>
                    </prop>
                    <node oor:name="Normal">
                      <node oor:name="Font">
                        <prop oor:name="Color">
                          <value>71767a</value>
                        </prop>
                      </node>
                    </node>
                  </node>
                  <node oor:name="i" oor:op="replace">
                    <prop oor:name="Type">
                      <value>PresentationTimeLabel</value>
                    </prop>
                    <node oor:name="Normal">
                      <node oor:name="Font">
                        <prop oor:name="Size">
                          <value>26</value>
                        </prop>
                        <prop oor:name="Style">
                          <value>Bold</value>
                        </prop>
                        <prop oor:name="Color">
                          <value>ffe969</value>
                        </prop>
                        <prop oor:name="Anchor">
                          <value>Center</value>
                        </prop>
                      </node>
                    </node>
                  </node>
                  <node oor:name="j" oor:op="replace">
                    <prop oor:name="Type">
                      <value>ChangeOrientation</value>
                    </prop>
                  </node>
        
        (`git show --ignore-space-change` helps see the
        "actual change" more clearly.)
        
        Change-Id: I121e5b346f750016cab0769a21aa01f3684a5800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185407
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [265a0ef3c5560476a88818f4f226521a4a8e04a3]

        sd presenter: Make LayoutMode an enum class
        
        Change-Id: Idced9fc9b093aba95e8171b1308f9a39a5213c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185403
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [b246b1c16c10824dd783aca4c7247f390fc24c32]

        sd presenter: Mark PresentationTimeLabel methods final
        
        Mark implementations of the IPresentationTime base class
        methods as final, which silences the following clang-analyzer
        warning shown in Qt Creator:
        
            .../libreoffice/sd/source/console/PresenterToolBar.cxx:1734:5: Call to virtual method 'PresentationTimeLabel::restart' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
        
        Change-Id: If06a0ba8e5f01f27ac1119c71ae596db2e74c8b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185401
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [73794df9ec583df0e656707fbfccec11fd1c3854]

        sd presenter: Indent try block
        
        Change-Id: Id433c9943866480caec21f209ee4570d6f1c696f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185396
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [a8aca56e1390c01e100543ff0895caf216b72501]

        sd presenter: Pass param by ref instead of shared_ptr
        
        This also allows dropping various null checks.
        
        Change-Id: I6fb579ab88f944b7a8ae7dad1e7377ef889a7033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185395
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [4cb65bf14ca75a35dcab1754384ef4d62a1e27dc]

        sd presenter: Make PresenterToolBar::LayoutPart non-static
        
        That gets rid of the need to pass the canvas as a param,
        as the member can be accessed directly now.
        
        Change-Id: I5ab8a551da9a2d4f7bf8565ad695ebe668c3bd43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185394
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [220bd7fcb3c99a2a1bdf65aea48a6998f58485a8]

        sd Presenter: Drop PresenterToolBar::CalculatePartSize canvas param
        
        Use `mxCanvas` directly instead of passing it around.
        
        Change-Id: Ie17fd0c3180334f8b149e6a68086db4c790bb344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185393
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [ee74541f376eee348e8e032158dd8505f4af1f43]

        sd presenter: Drop PresenterToolBar::Layout canvas param
        
        The only callers pass the own `mxCanvas`, so use
        that one directly instead.
        
        Change-Id: I7fdffe60e1fae25cc007a9c06f95e4f06793a634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185392
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [9659eb747c8dd3f9664ec7064e55e75cfb76f2a6]

        sd presenter: Drop PresenterToolBar::ProcessEntry canvas param
        
        The only caller passes the own `mxCanvas`, so use
        that one directly instead.
        
        Change-Id: I90dc11666715170f7b665ae3b73e31e50c21810c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185391
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [d6057f8c1da86a3e43812e77f3975e56afaa2365]

        sd presenter: Drop PresenterToolBar::Context class
        
        It only holds an XCanvas reference and is used to
        pass that one around.
        Instead, just pass the canvas directly.
        
        Change-Id: Ibab2d568c5d6100ff391f9fab2f073d0b94fe2f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185390
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [2239a785440800707f26d054e30ef77b3b9f4ba2]

        sd presenter: Reduce var scope
        
        And rename the variable in the else block to
        `aElementSize` as well.
        
        Change-Id: I0973c21a8fc70aa6d806a163babc2f8311539c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185389
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [6f0805563f850b0756d42fd793a63ba91868a74a]

        tdf#160094 sd presenter: Deduplicate RTL and non-RTL code paths
        
        The loop body is the same, the only difference is the
        direction of the iteration (forward or backward).
        
        Change-Id: Ie05cbfa549948e76d0e08daff58cb8e20d0f955a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185383
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [fc78db91c21468cb5cedb70707e7bfc618edc38f]

        tdf#160094 sd presenter: Use unordered_map for mapping
        
        ... the size explicitly, instead of having a vector and
        the assumption that the elemnt at index i in
        `aPartSizes` provides the size for the element at the
        same index in `maElementContainer`.
        
        This also makes it unnecessary to use the "reversed index"
        for the RTL case and will allow further deduplication
        in an upcoming commit.
        
        Change-Id: I6d00ea116fc7ee144f1ec90ed54da7004800eb4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185382
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [140fb3b98b4f8e1331634213a0825fbe92ccda15]

        tdf#160094 sd presenter: Don't use invalid iterator for RTL
        
        Use reverse iterators instead of manually iterating
        backwards and using an invalid iterator of
        `std::vector::begin() - 1` that triggered
        
            /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/debug/safe_iterator.h:1103:
            In function:
                _Self gnu_debug::operator-(const _Self &, difference_type)
        
            Error: attempt to retreat a dereferenceable (start-of-sequence) iterator 1
            steps, which falls outside its valid range.
        
            Objects involved in the operation:
                iterator @ 0x7ffe4f131df8 {
                  type = gnu_cxx::normal_iterator<std::shared_ptr<std::debug::vector<rtl::Reference<sdext::presenter::PresenterToolBar::Element>, std::allocator<rtl::Reference<sdext::presenter::PresenterToolBar::Element> > > >*, std::vector<std::shared_ptr<std::debug::vector<rtl::Reference<sdext::presenter::PresenterToolBar::Element>, std::allocator<rtl::Reference<sdext::presenter::PresenterToolBar::Element> > > >, std::allocator<std::shared_ptr<std::debug::vector<rtl::Reference<sdext::presenter::PresenterToolBar::Element>, std::allocator<rtl::Reference<sdext::presenter::PresenterToolBar::Element> > > > > > > (mutable iterator);
                  state = dereferenceable (start-of-sequence);
                  references sequence with type 'std::debug::vector<std::shared_ptr<std::debug::vector<rtl::Reference<sdext::presenter::PresenterToolBar::Element>, std::allocator<rtl::Reference<sdext::presenter::PresenterToolBar::Element> > > >, std::allocator<std::shared_ptr<std::debug::vector<rtl::Reference<sdext::presenter::PresenterToolBar::Element>, std::allocator<rtl::Reference<sdext::presenter::PresenterToolBar::Element> > > > > >' @ 0x55ee4e1a92a8
                }
        
        when starting Impress with SAL_RTL_ENABLED=1 and
        then starting a slideshow with Presenter Console
        enabled. for an `--enable-dbgutil` Linux build.
        
        Replace the hard-coded `nIndex=2` with
        `nIndex = aPartSizes.size() - 1` (there are 3
        vector elements) and rename `iBegin` to `iFirst`
        (as it no longer is the begin iterator, but points
        to the first element in the vector, i.e. the element
        at index 0, not the first one when reverse-iterating).
        
        Change-Id: Ibfc3b776391dae8b986964ef8f8d3c256f12d553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185381
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [e646709be8f39f25471d2ebc253006e9958d20f1]

        sd: Don't use unique_ptr for BasicViewFactory::mpViewShellContainer
        
        There's no particular reason for it, so just use a simple
        std::vector.
        
        Change-Id: I5d63860184081065e218c994b311a96deacf1208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185380
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [8dd542fbfa9a21c2b89533a1566cca89a271afe8]

        sd: Turn 2 vector subclasses into aliases
        
        They don't add any extra functionality, so no need
        to subclass std::vector instead of just using it.
        
        Also address
        
            /home/michi/development/git/libreoffice/sd/source/ui/framework/factories/BasicViewFactory.cxx:71:28: error: if zero-initialization of 'ViewShellContainer' (aka 'vector<std::shared_ptr<ViewDescriptor>>') is intentional here, better make that more explicit (e.g., assigning to members, default constructor, default member initializers, std::memset) [loplugin:subtlezeroinit]
               71 |     : mpViewShellContainer(new ViewShellContainer()),
                  |                            ^~~~~~~~~~~~~~~~~~~~~~~~
            1 error generated.
        
        Change-Id: Ia58b669e61d1350b1742dbc8e86339fb64f22c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185379
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [7236de3ca25fb34abda5d15b4243612772e7973c]

        language-subtag-registry: upgrade to 2025-05-15
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-05-15.tar.bz2 data/language-subtag-registry
        
        Change-Id: Ica7e7bfe1a08253e4706fc40840663e74b7e9695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185416
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [6b6776070b12815430b2f849a05349de921ee098]

        LOCRDT sw: deactivate active comment when fly is selected
        
        CppunitTest_sw_uiwriter5 CPPUNIT_TEST_NAME="testImageComment" fails
        because it inserts a comment, putting the cursor into the comment, then
        selecting an image, putting the sw cursor onto the SwGrfNode, but the
        active comment remains active, hence later the selection type is PostIt,
        not anything fly related as it should be.
        
        This appears to be a general problem and the test worked by accident before.
        
        Change-Id: Ic49b46d16cd2412e379015f10fe4fc7224efbd80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185409
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [2bd24c8bc4daa1cb425b3eb38bcffef01c344489]

        no need to subclass std::vector here
        
        Change-Id: Ief5e462f1308601bc951873537aa62a418c61893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185397
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e17a9b4ed2a7c6023adfb059383a32f22a7761c]

        loplugin:unusedfields
        
        Change-Id: I4b02379e872e49dc5a3ecdbb5bc74e237ba61c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b1c01b5084f481c4977c0373e3543916231eb06]

        loplugin:unnecessaryvirtual
        
        Change-Id: I3db8e1d7b2dbd19a812070603d07e678dd90a80e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8e1c8353d61e85e867eabcfa18813abbc7d6352a]

        ScConditionalFormat: pass ScDocument by ref
        
        and in other related places
        
        Change-Id: Ic4fd970c0f91f246893013f0751376043dd809f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185361
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7b57ae6dc98092ad0f584bbf22ef05a5cdbdc3b7]

        ofz#415190397 avoid OOM
        
        with huge amounts of error cells
        
        Change-Id: I7587063de5914030f7231e91643202f0f4782847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185408
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [93fe03c05987434df95d4dea2dcf45fd76020f63]

        LOCRDT sw: fix multiple view shell problems
        
        CppunitTest_desktop_lib testCommentsCallbacksWriter uses 2 view shells
        to insert comments.
        
        The first problem is that SwTextNode::Update() avoids moving the wrong
        (i.e. current shell's) cursor, because it uses SwDocShell::m_pWrtShell
        to check if it's the current shell, but only
        DocumentLayoutManager::mpCurrentView has the correct value.
        
        The other problem is that SwViewShell::GetPostItMgr() also uses
        SwDocShell::m_pWrtShell and so doesn't return its own m_rView's one,
        hence a loop over all shells always uses the same SwPostItMgr.
        
        Change-Id: I043602f88f2f458532224554e5c13de7d37081c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185400
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [0caf06c8fa97bd66c74ea55a551bafff31ce6b77]

        remove some dead stuff in package
        
        ever since
            commit b410749d30ed167f5bf0da6491d72e55f596cd41
            Author: Akshay Kumar Dubey <akshaymani513@gmail.com>
            Date:   Wed Apr 16 02:05:16 2025 +0530
            tdf#137308 - Add zstd build support and decompression classes
        
        Change-Id: Ib67a2ef523ce6596b562633b0da081ba56d3ff6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e1224cfb637b55de1834daf2bee2350099e48af1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2daf496b40b300ac162c7a3ac0f93567a67bd102
          - Revisit Column and Line charts Help pages
            
            + More refactor to spare translations
            
            Change-Id: I980fbc6f6ea9e205937c4ac773147a5682bb13c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185414
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-16  Bayram Çiçek  <bayram.cicek@collabora.com>  [43e49a34a5e581194eff38a5e51fda85cfa5a446]

        tdf#166205: decrease the page height to 5%
        
        to fit header & footer if DocumentSettingId::TAB_OVER_SPACING compatibility flag is set.
        
        - if a doc created in MSO Word and opened in LO Writer, header&footer for the first page were not visible - for some documents.
        - this change make them visible now.
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: If4548949514eb319a6b1e3af5799d266f53ec753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185261
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-16  Miklos Vajna  <vmiklos@collabora.com>  [d659f4b12a24e275e38ec5aa7406c32c9fa08c48]

        tdf#166319 sw interdependent redlines: handle reject of delete under format
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, and once the
        cursor is in the middle of the AA, then pressing Reject should get rid
        of the delete and keep the format, but it resulted in no redlines and a
        "AACC" string.
        
        What happened is that we found the delete under format, but the action
        was still reject, and it's OK to implement reject by deleting the
        content for insert-then-format, but this won't work for
        delete-then-format.
        
        Fix the problem by reusing lcl_AcceptInnerInsertRedline() for this
        purpose: accepting an underlying insert is effectively a NOP (body text
        doesn't change), and rejecting a delete is in the same category.
        
        Rename to lcl_DeleteInnerRedline(), because what this function does is
        to get rid of "underlying" (earlier) redlines of a redline, so this is
        useful for rejecting deletes as well, not just for accepting inserts.
        
        Change-Id: Ie2db419844b77638d12fa6edfcbc0d5c3b59ad20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185404
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [68ba1c02ac9c93db329d92c9dca0c0b8e2ecff07]

        no need to subclass std::unordered_map here
        
        Change-Id: Ib7be7dac8f394a35eed7212c6fbad3cefa39eaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185399
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [fdafe86081022e881061aea81566ae9513620500]

        simplify SvxMSDffBLIPInfos
        
        no need to wrap a sal_uInt32 in a struct
        
        Change-Id: I5db794fced7b8f5de1ad154ceedb8509a627d7a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185398
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [8015a6c9e6b2e67184fdea6c897ff8036a488ca5]

        Related: tdf#165918 Avoid renaming pre-existing bookmarks
        
        Thanks Michael Stahl, for pointing this:
        
        > what happens when you first insert a bookmark, then insert a file that
        > contains a bookmark with the same name at a place in the document before
        > the pre-existing one - the SwHistoryBookmark uses the name of the bookmark
        > to find it, and this loop would rename the pre-exsiting bookmark, so on
        > undo of insert bookmark it can't be found?
        
        ( https://gerrit.libreoffice.org/c/core/+/185340/comment/274a3fba_aa363535/ )
        
        This change avoids this problem by preparing a set of already existing names
        at the start of the performance mode, and only checking the marks that were
        added while in the performance mode.
        
        Change-Id: Id4dc1809871fd4a998396d091f2f920ecd71b7d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185363
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bdc3a61896b95719b4b05453303ae1e7b3d3ac30]

        crash in SwVisibleCursor::SetPosAndShow
        
        /lib64/libpthread.so.0
        	__restore_rt
        		??:?
        program/../program/libswlo.so
        	SwVisibleCursor::SetPosAndShow(SfxViewShell const*)
        		sw/source/core/crsr/viscrs.cxx:224
        program/../program/libswlo.so
        	SwCursorShell::UpdateCursor(unsigned short, bool)
        		sw/source/core/crsr/crsrsh.cxx:2453
        program/../program/libswlo.so
        	SwCursorShell::EndAction(bool)
        		sw/source/core/crsr/crsrsh.cxx:282
        program/../program/libswlo.so
        	SwRootFrame::EndAllAction()
        		sw/source/core/layout/pagechg.cxx:1994
        program/../program/libswlo.so
        	SwXMeta::AttachImpl(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, unsigned short)
        		sw/source/core/unocore/unorefmk.cxx:953
        program/../program/libswlo.so
        	com::sun::star::uno::Reference<com::sun::star::text::XTextRange>::~Reference()
        		include/com/sun/star/uno/Reference.hxx:113
        program/../program/libswlo.so
        	std::vector<svx::ClassificationResult, std::allocator<svx::ClassificationResult> >::~vector()
        		/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:730
        program/../program/libswlo.so
        	SwEditShell::SwEditShell(SwDoc&, vcl::Window*, SwViewOption const*)
        		sw/source/core/edit/edws.cxx:59
        program/../program/libswlo.so
        	SwFEShell::SwFEShell(SwDoc&, vcl::Window*, SwViewOption const*)
        		sw/source/core/frmedt/fews.cxx:692
        program/../program/libswlo.so
        	SwWrtShell::SwWrtShell(SwDoc&, vcl::Window*, SwView&, SwViewOption const*)
        		sw/source/uibase/wrtsh/wrtsh1.cxx:2044
        
        Change-Id: I3664dbaad8102526ec3b91cf11ff364fe4bf2642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cb4a5402dccf239c537af792a228513761e832de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d3f9b5f20d52ccd10b7b845ca9e69b029621b8e
          - Revisit Line, XY, Bubble, Area charts Help pages
            
            + refactor to spare translations
            
            Change-Id: I29baaace14637ea9c4ef7a2603fe8521a5ae241e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185377
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-16  Miklos Vajna  <vmiklos@collabora.com>  [993e2cf8b5cb986f0c5ba8c6f78d314671c76a92]

        svx: lower the priority of StylesListUpdateTask to TaskPriority::DEFAULT_IDLE
        
        The update of styles previews is probably less important thatn the
        update of the document area, so in case this stays in the
        TaskPriority::HIGHEST -> TaskPriority::REPAINT region, that's
        potentially problematic.
        
        In practice for example a LOK client may decide to register its anyInput
        callback to stop idle jobs in case no high priority jobs are scheduled
        on the main loop, and this would delay paintTile() calls due to this
        idle.
        
        Change-Id: I6a3135caccb8abe9a8117e0d8c7bdda0df7e2780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185369
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-16  Jonathan Clark  <jonathan@libreoffice.org>  [1d70690e304cd3321d6c5a14e28df717e3d315d9]

        tdf#151336 editeng: Fix bad cursor pos when moving to RTL paragraph
        
        This change fixes a bug causing incorrect visual cursor positioning when
        advancing the cursor from an LTR paragraph to an RTL paragraph that
        starts with an LTR run.
        
        When advancing the cursor past the end of a paragraph, the cursor should
        be placed at the conceptual start of the following paragraph.
        Previously, Edit Engine did this by placing the cursor immediately
        before the character at index 0. The result looks correct in many
        situations, but it fails in the case of bidi text: the conceptual start
        of an RTL paragraph is the right edge of the text area, but when the
        paragraph begins with LTR characters, the character at position 0 may
        start arbitrarily far to the left of the expected cursor position.
        
        Edit Engine already contains logic to correctly position the cursor for
        the home/end keys. This change extends that logic to include cases where
        the cursor is moved between paragraphs.
        
        Change-Id: I0d23b87beacd53d7508b74445d25f9024dbaf89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185367
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-05-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [195c44b6dcad5cebd4f69c792478df612bbf2105]

        Remove obsolete fw declarations from svx/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Iccc9ef1ae947fefbe95fe51c043725e27916739f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183907
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-16  Gökay Şatır  <gokaysatir@gmail.com>  [106a8448a57d689c26d0c790c529b9ef3b0dc513]

        tdf#142011 - Text disappears if "Adjust to contour" selected.
        
        Steps to reproduce - from the bug report:
        1. Draw a connector between two objects.
        2. Select the connector so that the control points are visible.
        3. Click on Insert Text Box to enter text mode.
        4. Type the connector text.
        5. Right-click on the text and select Text Attributes from the context menu to open the Text dialog.
        6. Select "Adjust to contour" and all other options are disabled.
        7. Click OK and the Text dialog closes. The text disappears.
        
        And the suggested solution is to hide the mentioned option. Because it is not applicable for certain objects.
        
        While i debug, i saw that also "line" objects are problematic with "Adjust to contour" option. So i also hid the option for line objects.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I81974eaae66eccc33da66c623256fbcb977ffb42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185256
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit ad6eaf4559ad4e788dd07ae497a195840ae300ee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185352
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins

2025-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [f4d98621bf0bb93874bb433cb01cbce12de5c439]

        cui SvxNameDialog: Pass string by const ref
        
        Change-Id: I610c4e93f35f6b3456c0b1b6663e002693f5fd11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185374
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-16  Justin Luth  <jluth@mail.com>  [5c7b3f5dc1f14081eed380999dc029a500784d55]

        tdf#166544 writerfilter page break: field-end counts as a character run
        
        For compat14, page breaks that are not the first run
        do not apply the top margin after the page break.
        That makes sense. The top margin has already been applied
        before the break.
        
        The end marker of a field (ToC, legacy text form field, hyperlinks...)
        must be treated as one of these character runs,
        since MS Word doesn't apply the top margn in these instances.
        
        The bug report contains examples for ToC and formfield,
        so I used the hyperlink example as my unit test.
        
        make CppunitTest_sw_ooxmlexport25 \
            CPPUNIT_TEST_NAME=testTdf166544_noTopMargin_fields
        
        Change-Id: Ia3efced0d301c2345667937521beb8e7c895d326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185375
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-05-15  Justin Luth  <jluth@mail.com>  [e43929ce56843ffc91341d5897883e752e5b49ec]

        tdf#166503 sw mso-compat layout: don't consolidate if PAGE_SPACE_MAX
        
        For a few decades, Microsoft has been consolidating the top/bottom
        spacing of adjacent paragraphs. But there does exist a layout flag
        to not do that.
        
        In my recent 25.2.3 changes to attempt to match MS layout,
        that flag (which we already import) wasn't taken into account.
        
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf166503
        
        Change-Id: Ia7842398a4095a8c39753a594214b13ef724969d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185331
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [e349d5a46f858fd742e0db8480c98c1f8c23f38e]

        sd presenter a11y: Merge XAccessible{,Context} implementations
        
        So far, PresenterAccessible was implementing the
        XAccessible interface for the accessible object
        used by PresenterController, and it was creating
        another AccessibleObject (`mpAccessibleConsole`)
        that implemented the XAccessibleContext interface
        and was created in the call to
        PresenterController:getAccessibleContext.
        
        Stop that separation and let PresenterAccessible
        also implement the XAccessibleContext interface,
        and subclass AccessibleObject (which in turn
        subclasses OAccessibleComponentHelper).
        
        This aligns this further with what almost all
        XAccessible/XAccessibleContext implementations
        in the LO codebase do by now.
        
        Apart from that, keep the logic mostly unchanged,
        though the approach taken might be worth reconsidering
        at some point in time in the future.
        Currently, the way that announcement of the current
        slide by screen readers (explicitly analyzed with Orca
        on Linux with the gtk3 VCL plugin) works is by sending
        a dummy focus event for the accessible object for the slide
        preview of the current slide (see
        `PresenterAccessible::NotifyCurrentSlideChangepreview`)
        and then sending a name-changed event which is announced
        by Orca because the "focused object"'s accessible name
        changed. In reality, keyboard focus isn't actually on that preview
        pane, however.
        (A fair part of the UI also isn't accessible/not seen in Accerciser's
        treeview of the LO a11y hierarchy, likely due to the fact that
        custom button etc. implementations are used (see PresenterToolBar and
        PresenterToolBar::Element and subclasses) instead of existing
        vcl/weld widgets and their existing a11y implementations.)
        
        Behavior with both, Orca and Linux with the gtk3 VCL plugin
        and NVDA on Windows when switching slides in Presenter console,
        as well as what was seen in Accerciser on Linux with gtk3 or qt6
        was the same with this commit as prior to it in a quick test.
        
        Change-Id: I0a347aba18d1a4e9c499c3438bcbe2143ca78f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185372
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [d99879e3886785720465d366530c19adae32a1a1]

        [API CHANGE] a11y: Drop unused XPane2::setAccessible
        
        This method is now unused since
        
            Change-Id: I055dd19bbec810126d67e7795ffdfab257beeed3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 15 14:45:24 2025 +0200
        
                sd presenter a11y: Drop indirection to set win accessible
        
        , so drop it the same way that XPane2::getAccessible was
        dropped earlier in
        
            commit 26bf576f85f760c4495f34002d28c9114e1778cc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 13 21:20:11 2025 +0200
        
                [API CHANGE] a11y: Drop unused XPane2::getAccessible
        
        Change-Id: Id0c185562213baa71de3987eb3b5d12fa24798f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185366
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [675be4a949970c779526549ae2283d80d2821d79]

        sd presenter a11y: Drop indirection to set win accessible
        
        So far the logic including indirection via UNO interfaces
        was like this:
        
        * The PresenterAccessible ctor calls XPane2::setAccessible,
          passing itself as the accessible.
        * The XPane2 implementations call vcl::Window::SetAccessible
          with the accessible.
        * The XPane2 implementations (at least the one in
          FullScreenPane::setAccessible) calls XInitialization::initialize
          on the accessible (which is implemented in PresenterAccessible)
          to set the window's a11y parent as the a11y parent of
          the PresenterAccessible.
        * PresenterAccessible::initialize takes that parent and remembers
          it and/or sets it on the underlying console a11y object.
        
        Get rid of that indirection by directly retrieving the
        pane's vcl::Window in the PresenterAccessible ctor and
        moving the logic there.
        
        Linking sdui against the toolkit module is newly needed because
        of the newly introduced use of VCLUnoHelper::GetWindow.
        
        Stop implementing the XInitialization iface in PresenterAccessible.
        
        Replace the XFrame2::setAccessible implementations with dummy
        ones that trigger an assert for now.
        (They will be dropped from the interface altogether in
        a separate commit.)
        
        PresenterAccessible no longer needs an XPane2 any more,
        which allows to drop some UNO querying between XPane and XPane
        interfaces.
        
        Change-Id: I055dd19bbec810126d67e7795ffdfab257beeed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185365
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [7b37a38960afe0d990c508d6a3fa51a0bec04776]

        sd presenter a11y: Set preview's parent
        
        The `mpAccessibleConsole` is the XAccessibleContext
        for the PresenterAccessible, i.e. the PresenterAccessible
        object is the XAccessible object for its `mpAccessibleConsole`.
        
        PresenterAccessible::UpdateAccessibilityHierarchy sets
        the `mpAccessiblePreview` as a child of `mpAccessibleConsole`.
        Therefore, the PresenterAccessible is the parent XAccessible
        for the preview. Set it accordingly.
        
        This fixes an inconsistency in the a11y hierarchy that
        could be seen as follows with the qt6 VCL plugin:
        
        * start an Impress presentation with Presenter Console activated
        * start Accerciser
        * navigate to the "Presenter Console" object in Accerciser's
          tree view of LO a11y.
        * in Accerciser's IPython console:
        
            In [30]: acc.get_child_at_index(0).get_parent() == acc
            Out[30]: False
        
        This means the Presenter Console's a11y child at index 0 (which
        is the current slide preview) doesn't report it's actual
        parent as its parent.
        
        With this commit in place, this behaves as expected now:
        
            In [1]: acc.get_child_at_index(0).get_parent() == acc
            Out[1]: True
        
        Change-Id: Id41da5139214437de44d6b1cf29ad8de1d9d13be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185364
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [03dfd09f7e3d009b6f5a0dc32f403352935ccd48]

        tdf#76029 sd console: Scroll to new slide as needed
        
        When switching to a new slide in Impress, make sure that
        this new slide is fully visible in the Presenter Console
        "Slides" mode automatically, by scrolling to adjust the
        visible area as needed.
        (Make the slide's row the topmost one that's visible.)
        
        This removes the need for the user to manually scroll
        using the scroll bar after switching slides.
        
        Change-Id: I7d2a245e6f4b705a8a2492ccb02bbef490adbe88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185358
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [f63690411df62f373d04d6b78bb93956f5532abf]

        sd console: Don't subclass std::vector
        
        ... without adding any additional functionality.
        Instead, make PresenterToolBar::ElementContainerPart
        an alias for std::vector<rtl::Reference<Element>>.
        
        Forward-declare Element and make it an inner class
        of PresenterToolBar, which also fits with the existing
        
            //===== PresenterToolBar::Element =============================================
        
        comments.
        
        Change-Id: I49c2ef88fb4e4280c4cc21b02ce8a20253947933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185357
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [47b4621b2fef116eed4ef5c9d64d40ecfca2b70c]

        sd console: Drop extra indentation
        
        ... which is only partially used in this source
        file for the anonymous namespace scope.
        
        This will also avoid mixing such indentation changes
        with others in an upcoming commit that will move
        the `Element` class out of the anonymous namespace.
        
        Change-Id: Ia8507558bc82fbb70ff4ad2ee32d0346c218c6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185356
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [eec08c57cd46d63799b28a2393392cb1f552d9bd]

        Revert "sd presenter a11y: Use "x" prefix for Reference"
        
        As Mike Kaganski points out in [1]:
        
        > The semantics of x is "a pointer to an interface" - meaning "we need to
        > do things like querying to get other interfaces implemented by the same
        > object". uno::Reference is that object, which naming should start with
        > "x" (following its template arguments starting with X). But here, with
        > rtl::Reference, we have much more smart-pointer-like object; we know its
        > most-derived type, with all its implemented interfaces being known
        > inherited types. We don't do dance like
        >
        >     Reference<XFoo>(xBar, UNO_QUERY);
        
        Naming conventions also list only
        "(Smart) pointer/reference to a UNO interface", so
        revert the change to use the `x` prefix for an rtl::Reference.
        
        In practice, using the `x` prefix instead of `p` seems to be used much
        more widely for `rtl::Reference` (s. below), but don't actively introduce
        more of that.
        
            $ git grep -P "rtl::Reference<.*> m?_?p" | wc -l
            2111
            $ git grep -P "rtl::Reference<.*> m?_?x" | wc -l
            3814
        
        This reverts commit 3b92011191ca994d47e68ab50d963034586cc8ff.
        
        [1] https://gerrit.libreoffice.org/c/core/+/185327/comment/32f8fe06_1fb00cba/
        [2] https://wiki.documentfoundation.org/Development/Code_Conventions
        
        Change-Id: I12cf88104569c38dd9c095344eece8bce7a2950b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185343
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [2fb0041ca2ea709235c90a503cda5aeafc0a39be]

        sd: Use VCLUnoHelper::GetInterface
        
        And move retrieving the XWindow for the vcl::Window
        to the end, as it isn't needed earlier.
        
        Change-Id: I3cd7653f38562223d43ca96a00660cd35239dd35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185339
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [bbc6480cb3aa139165174f22b410e40aebce9b9c]

        sd presenter a11y: Drop unused local xNotesPane
        
        Change-Id: Ice1ac621330b5de54d28c35bd8474a83e5f6aaff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185338
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [013ea821a5fac77bf0e0361d9d63dbcb54c8a42c]

        qt, configure: Drop QtNetwork
        
        It's unused, so drop it.
        
        Thanks to Andreas Sturmlechner for mentioning it
        on IRC.
        
        Change-Id: I28817fc0bd4bc91d8249c8fea5358bfcb6a61286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185370
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c7d102b4b6fdbf687e907c0266a91a013a78872]

        ofz#417428651 Null-dereference WRITE
        
        Change-Id: I67e12ee72cece647df43cba6cd3074df75351951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185353
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-15  Miklos Vajna  <vmiklos@collabora.com>  [e60a92164ac2cc35f70efcbf20a7272be1e3f99d]

        cool#11942 svx lok: handle Writer idle status when starting the paint view idle
        
        The bugdoc is similar to cool#11785, i.e. a document of 3-400 pages, but
        the content is reasonably simple, mostly plain text and bullet points.
        The document has a shape, though. Loading this document in COOL does a
        full sync layout on load, which is reported to take ~9s on a slower
        machine and it takes >1s for me locally (after doc load, before the
        render of the first page).
        
        It seems what happens is that idle layout is started, but it's not
        interrupted, because moving content between pages in
        SwLayAction::Action(), called from the SwLayIdle ctor calls into
        SdrPaintView::Notify(), which starts a high priority "idle", so the LOK
        client thinks it should not interrupt core jobs, so the idle layout
        first completes, and only then we paint the first tile.
        
        Fix the problem by adjusting the priority of
        SdrPaintView::maComeBackIdle dynamically. Add a flag in the draw model
        to know when we're inside the Writer idle layout and once the svx/ idle
        is started, lower the priority in case that's invoked from inside the
        Writer idle layout. This gives the LOK client a way to interrupt the
        Writer idle layout (via the anyInput callback), now that it seems core
        has no high priority jobs in the scheduler.  Size of the time window
        between the end of doc load and the start of the first tile render,
        before: 1617 ms. After: 182 ms
        
        An alternative approach I considered is to interact with the
        SdrPaintView that belongs to the current Writer view, but that won't
        work. There are typically 2 draw views active right after document
        load, one created in SwViewShellImp::MakeDrawView(), but there is also
        an additional hidden view created in the SvxDrawPage ctor for UNO
        purposes, so if we don't go via SdrModel, we would have to notify both
        views that we're entering / leaving the Writer idle layout, which looks
        more complicated than what this patch does.
        
        Change-Id: I115ba2c152fe7283804cde564afd511f9fbff707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185360
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c3423850610b7fea7331647814e2719796fa088b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e7222bd7d6e60778a30822a3585cf3146516ed10
          - Revisit Net charts Help page
            
            Change-Id: I936a390c933f7882724134233619f0634e533af5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185336
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ccd6d5ffe4d9c6a55c7464c79a6fab17174a4a76]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b39e5d48c762368498107ec564d10651f884b901
          - Revisit Columns charts Help page
            
            Change-Id: I7ab7b12dee0bc7142fbb7da00cf3dcecede79871
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185335
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [618c9ad42fd699c1c0392f38dbe6eaaff39aeb7f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79885174a41744e6580d0064d3ca749f9f0b3e44
          - Revisit Pie charts Help page
            
            + Add page for of-pie charts
            
            Change-Id: Ib7e73f856499b5a0458edb0e0e46aa1a451c159a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185334
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-15  Oliver Specht  <oliver.specht@cib.de>  [f8cbc8eae242ff18a7beff38bac13f4f02bccdc0]

        Improve labels/help text of page range field controls
        
        Follow-up to 4882974799f647fd34c88e86e86fa9fee734af6f
        Changes related labels in field dialog an in header/footer dropdown
        menu.
        
        Change-Id: I663676e6b352377b21bc2fde1d49acb30fe8f26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185292
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-05-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3f48ca0059e80ee71917973b9d71aa8867b6fdf5]

        HtmlExport: pass SdDrawDocument by ref
        
        Change-Id: I9e6579cad6c0b4b72f1f4a20ce11b507299adee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185355
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-15  Sebastian Neagu  <neagu.sebastian05@gmail.com>  [2aedb4ae1fe3efe18920a01940bad1bb014265a5]

        tdf#158280 Replace usage of InputDialog with SvxNameDialog
        
        Similar with commit cda4965ea65ff9fa0e63e53344f46aeac91848a9
        
        Signed-off-by: Sebastian Neagu <neagu.sebastian05@gmail.com>
        Change-Id: Iecd6c04c7944624dfcd5d069f152c7d95ffc9553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185102
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-15  Jonathan Clark  <jonathan@libreoffice.org>  [f08a984a94f5b504c75f4f4ce8a98d0bc074e0ee]

        editeng: Initial ruby character implementation
        
        Implements a minimal functional version of ruby character layout and
        rendering in Edit Engine. Many features are missing from this
        implementation, and will be added in future commits.
        
        Currently, ruby characters cannot be created via the user interface.
        Ruby character styles are also currently hard-coded.
        
        Change-Id: Ia7c18ccae6c37cd320acc214574ba3123c18ddb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185210
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-05-15  Mike Kaganski  <mike.kaganski@collabora.com>  [ec92326744796b364d1300f0867e29826cacf76e]

        Drop unneeded cast
        
        Likely a leftover from time when it was a weak reference.
        
        Change-Id: I73177da5678e9c5dbd236cbb4f7ae3e99e84b89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185349
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-15  Szymon Kłos  <szymon.klos@collabora.com>  [0252af90da1f5816129899b83f137792992ba2f1]

        jsdialog: ignore unused .ui files
        
        Change-Id: I60afbf97673572911be6515e7effc24f5dcbedf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184718
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185346
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-05-15  Szymon Kłos  <szymon.klos@collabora.com>  [1d3595f789101e37ac97e584d94c135ee112a1cc]

        jsdialog: sidebar: use vcl ids for panels
        
        JSDialog API cannot communicate without vcl id of a widget
        
        Change-Id: Ic6bd0d430207f32cf631564102511eae7130b7bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184721
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185348
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-05-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d0f6c4c0dac847112ca83b7b646fc7aa431f480d]

        UBSan vclplug_gtk3 needs ScrollbarValue RTTI now
        
        ...as running soffice started to report
        
        > warn:sal.osl:2389442:2389442:sal/osl/unx/module.cxx:103: dlopen(.../instdir/program/libvclplug_gtk3lo.so, 257): .../instdir/program/libvclplug_gtk3lo.so: undefined symbol: _ZTI14ScrollbarValue
        
        for me after 7bb189c3c2c3fb414484e81b9c6bd2f446784cb3 "tdf#97228 change
        scrollbarvalue code from include/vcl to vcl/" had removed the SAL_DLLPUBLIC_RTTI
        that had been present in the old include/vcl/salnativewidgets.hxx
        
        Change-Id: I4c8b7c1e94f1e3d823a59b8bb4479dc32b005854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185347
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-15  Michael Stahl  <michael.stahl@allotropia.de>  [55793ae8c82691bcad68bc9a46e36f9e659bf784]

        LOCRDT fix conditional compilation
        
        Add a config header for this, and split yrs.hxx in two because the
        actual libyrs.h is only needed in 2 files.
        
        Change-Id: I30453fda3082f977e328ed56a4a101743ecdd586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185329
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-15  Mike Kaganski  <mike.kaganski@collabora.com>  [55f087b48b7b8e6341a0e9abf70695b574689a3e]

        tdf#165918: speed up mark names uniqueness check
        
        MarkManager::makeMark call can be quite expensive, when it needs to
        ensure that the passed name is unique. It needs to iterate over all
        the existing marks in m_vAllMarks, checking their names. At import
        time, this creates quadratic complexity, even when the passed names
        are already all unique.
        
        This change introduces a dedicated performance mode, when names are
        not deduplicated in load time. When the mode is ended, an optimized
        loop is performed, using a set of names for much faster uniqueness
        check. Depending on the number of bookmarks, I saw the improvement
        of the test documents loading times up to 40% (like 190 s -> 115 s;
        of course, realistic documents would have more modest improvements).
        
        Change-Id: I4d624ea6cd7268e7bcfdefecac6d3f1bb58edc28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185340
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [44fc341843d4270e98a44d8e37aaf5b4aa00409d]

        Remove obsolete fw declarations from sw/ (part 1)
        
        found with bin/find-unneeded-includes --fwdecl
        
        checked sw/inc, sw/source/core/ so far
        
        Change-Id: I1fdf17d09e40a76b17e356ac45cebec568c698f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183908
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [c7ff6b049e4e61680c9c767d7404fcf6c0254f63]

        sd presenter a11y: Drop unused local xPreviewPane
        
        Change-Id: Iad9c19d0a633c6735e8f2d9ea3450313dd88316d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185328
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [3b92011191ca994d47e68ab50d963034586cc8ff]

        sd presenter a11y: Use "x" prefix for Reference
        
        Change-Id: I8b687f15f6992ec7ba89d3bde3e3aae1816313a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185327
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [dc44fd91ed42a719a6580d412b09fb77da0ffaf4]

        sd a11y: Drop XConfigurationController check
        
        PresenterAccessible never makes any direct use of
        XConfigurationController, so checking a non-null one
        can be retrieved from the presentation controller seems
        unnecessary. Drop that.
        
        Change-Id: Ic18a6a1ac0b399e9485653b923bc816451be5e73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185326
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [c8fc4db4bffaa0405f47f60a8dca32d3dc91591a]

        sd presenter a11y: Stop tracking a11y state in controller
        
        Stop tracking whether a11y is active in
        PresenterController. So far, this was the case once
        PresenterAccessible::getAccessibleContext was called
        for the first time, at which point that method was calling
        PresenterController::SetAccessibilityActiveState.
        
        Instead, let PresenterController call methods on its
        a11y object unconditionally.
        The object is already created unconditionally in
        PresenterController::InitializeMainPane, and the
        corresponding PresenterAccessible methods still don't
        do much as long as PresenterAccessible::getAccessibleContext
        hasn't been called, because PresenterAccessible::mpAccessibleConsole
        is only created in there.
        
        What's new is that PresenterController::notifyConfigurationChange
        now unconditionally calls
        
            UpdateCurrentSlide(0);
        
        for the ConfigurationUpdateEndEventType case, but making sure the
        slide references are up to date seems reasonable to me.
        
        Change-Id: Ifbc78578caf68323699b54b883e42ffd9295fff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185325
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [bfedefe5161f7755bfff914d418eee18600c28e7]

        sd presenter a11y: Decouple displayed pane title from a11y name
        
        So far, the title displayed for a pane in the Impress Presenter
        Console was always the same as the accessible name.
        
        For the "Current slide" pane in the presenter console, the
        title was different depending on whether or not accessibility
        was enabled, as different templates were used, see the
        "Title" and "AccessibleTitle" entries in
        officecfg/registry/data/org/openoffice/Office/PresenterScreen.xcu:
        
        With a11 disabled,
        "Current Slide (%CURRENT_SLIDE_NUMBER% of %SLIDE_COUNT%)"
        was used, with a11y enabled,
        "Current Slide, %CURRENT_SLIDE_NAME%, %CURRENT_SLIDE_NUMBER% of %SLIDE_COUNT%"
        was used, i.e. if a11y is enabled, the slide title is displayed in
        addition.
        
        No more make what's displayed on screen dependent on that,
        but use the "accessible title" for the accessible name instead,
        so it still e.g. gets announced by the Orca screen reader when
        switching between slides.
        
        Introduce PaneDescriptor::msAccessibleName to hold the
        accessible name.
        
        Adjust PresenterController::UpdatePaneTitles
        to always process both properties.
        
        Rename PaneDescriptor::msAccessibleTitleTemplate to
        PaneDescriptor::msAccessibleNameTemplate for consistency.
        
        Drop call to PresenterController::UpdatePaneTitles from
        PresenterController::SetAccessibilityActiveState as that
        should be unnecessary, now that
        PresenterController::UpdatePaneTitles behavior no longer
        depends on whether or not accessibility is considered
        enabled or not.
        
        Also adjust the template used for the accessible name to
        first announce the text that is displayed on screen
        (e.g. "Current Slide (2 of 4)"), then the slide name, and
        add brackets + remove comma to align it more with the
        displayed title.
        
        Whether it generally makes sense to use string templates
        read from the config for such a purpose may be a valid question,
        but leave that general approach unchanged at least for now.
        
        Change-Id: I52b2d014086e1532b0fb958e15ad915234e4718a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185324
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [fbe9b2b6b080f25e258bf2134322067019cba473]

        sd: Extract helper method to replace placeholders
        
        It will be reused in an upcoming commit.
        
        Change-Id: I894dad466522ec388a7057246af487214ddef7af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185323
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [529785d458488aa6d176a68ce02f227cdaa7c4c5]

        sd a11: Drop PresenterPaneBase::GetTitle
        
        Instead, pass the value of SharedPaneDescriptor::msTitle to
        as the accessible name, which is the same, as
        PresenterPaneBase::msName gets set to the same value.
        
        Change-Id: Ia916ecdfd7a44d81975bcd5ea195a42575a6eb8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185322
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [725a051050bf3158cec8241136363d8ac0afe857]

        sd: Make PresenterConfigurationAccess::GetConfigurationNode const
        
        Change-Id: If4093a967757c93669fce4e97b2939425348e4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185321
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [fec4b0c5d18ef338283ed96da1801ba7e87020bf]

        sd: OSL_ASSERT -> assert
        
        Change-Id: Id5dddac8b07d6982ea1e8e10f985726484c9898c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185320
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [8b2017276d79975412c4739a46580ccd3a67da7e]

        sd: Simplify retrieving slide count for pane title
        
        Use XSlideShowController::getSlideCount instead
        of XIndexAccess::getCount, which also avoids the
        need to query for the XIndexAccess interface.
        
        The implementation in SlideshowImpl::getCount
        even just calls SlideshowImpl::getSlideCount.
        
        Change-Id: Ia1d5d4fb5b246b21fe8583c77e3bcb00b5e894ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185319
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [4a38f462244e8541cc88678d1f3bc37dd40e3b25]

        sd: Don't override XInterface/XTypeProvider methods
        
        I can't think of any reason to override the ones provided
        by ImplInheritanceHelper here, so stop doing so.
        
        Change-Id: I6fcae18ff05ce38f354d4de879ba69cde352e28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185315
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [97981695a9bf3b7922733f5021cd4c8b9578efe2]

        sd a11y: Move AccessibleNotes to own .hxx/.cxx
        
        Change-Id: I47e79a6e568edd8301ebc2e67606b67b31d0a017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185314
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [2995ba081fd969dae0a02177face830b001ff11c]

        sd a11y: Don't set a11y name for notes paragraph
        
        Stop setting an accessible name for paragraphs
        in Impress Presenter Console notes.
        
        This is consistent with no names being used elsewhere
        (like Writer paragraphs) and matches also with the
        W3C ARIA "Providing Accessible Names and Descriptions"
        guideline [1], section "Accessible Name Guidance by Role"
        that says "Necessity of Naming: Prohibited" for the
        paragraph role.
        
        [1] https://www.w3.org/WAI/ARIA/apg/practices/names-and-descriptions/#accessiblenameguidancebyrole
        
        Change-Id: I0d87e3bf38cc1128eea493e76f9efcd7f5df8c0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185313
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [60d673bfbde05ddb0b0aab68906ab5409131f8ad]

        sd: Drop superfluous check
        
        There's already a check for mxSlideShowController being non-null
        further up, and an exception is thrown if it isn't, so
        this code path wouldn't be reached in that case.
        
        Change-Id: Ia34a762d331af45b3d59384490ba7c9fd377f4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185291
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [a6ec84dc8745873b9ea09bce8e77b2b589d125e8]

        sd: Drop unnecessary cast + UNO query
        
        Change-Id: Iece230bf7f3dadba2960429c3cda501ef8345354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185290
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [eb061fccd8132fb2f6aa8d0f3fcb6c035864aca4]

        sd: Try to fix PresenterPane visibility check
        
        See previous commit
        
            Change-Id: I933c63303d1f055b4c0eb826f6726df3fe2a7033
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 13 23:38:34 2025 +0200
        
                sd: Use concrete rtl::Reference<PresenterPaneBorderPainter>
        
        which made clear that PresenterPaneBase::IsVisible
        was effectively always returning false.
        
        Instead, try to query the `mxBorderWindow` for the XWindow2
        interface, and check whether it is visible.
        
        This should presumably be correct, and with a breakpoint set
        there, the checks succeed when starting an Impress presentation
        with the qt6 VCL plugin on Linux, but this is otherwise untested.
        (If this commit results in any issues because of the
        bounding box now actually getting updated and thus
        invalidations taking place, maybe that bounding box/invalidation
        logic should be refined or dropped altogether as it was presumably
        logically dead before this commit.)
        
        Change-Id: I91a45944e65983068463364d08cbc3c68f3a6ad6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185289
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [30e74e8e2b00dae6dd4bfc6f6ca88d1fd12d7d32]

        sd: Use concrete rtl::Reference<PresenterPaneBorderPainter>
        
        After
        
            Change-Id: Iacdd51e0d2d2bde454d66a97d4c468628395a1b5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 13 23:24:27 2025 +0200
        
                sd: Implement PresenterPaneBase::initialize without XInitialization
        
        , it is now clear that this is always a
        PresenterPaneBorderPainter, so use that concrete
        type instead of the abstract XPaneBorderPainter
        interface.
        
        This also makes clear that the attempt to query
        for the XWindow2 interface in
        PresenterPaneBase::IsVisible would never succeed,
        so (temporarily) simply return false there.
        This suggests that PresenterPane::UpdateBoundingBox
        which calls PresenterPaneBase::IsVisible might not
        be as useful as it looked like at first glance as
        it seems to always set `maBoundingBox` to an empty
        rectangle...
        
        This will be adjusted in an upcoming commit, but
        for now, leave the behavior as it used to be.
        
        Change-Id: I933c63303d1f055b4c0eb826f6726df3fe2a7033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185288
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [4e4be4a4ecfb9e73a8e90ac3ba907da840818133]

        sd: OSL_ASSERT -> assert
        
        Change-Id: I931b361dcd560c21020468e6560571006cbee460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185287
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [4f0f8ae6ea2c8ecbb02ad5e2abd7588eb55999b4]

        sd: Drop always empty title param
        
        Apparently, PresenterPaneBase::SetTitle is the way to set the title.
        
        Change-Id: I0e00c25129688e1b793cff77b900aaab117665d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185286
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [c0a31260dff1c100025400bf8ecad4723f526b6a]

        sd: Implement PresenterPaneBase::initialize without XInitialization
        
        No longer let PresenterPaneBase implement the XInitialization
        interface, but instead let PresenterPaneBase::initialize
        take the specific parameters and pass them in the only caller
        instead of wrapping them into a Sequence<Any> and then
        extracting them again in PresenterPaneBase::initialize.
        
        Drop the try/catch, assuming this was primarily there
        for the previous handling of args.
        
        Further simplification can be done in upcoming commits.
        
        Change-Id: Iacdd51e0d2d2bde454d66a97d4c468628395a1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185285
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [fa5e99ccfe964f63ee69b312229f8446e0688cf2]

        XPane doc: "closer button" -> "close button"
        
        Change-Id: Id9072685c4ad12325316dcb968fa93d43b90421d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185284
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [26bf576f85f760c4495f34002d28c9114e1778cc]

        [API CHANGE] a11y: Drop unused XPane2::getAccessible
        
        Drop the unused method from the unpublished
        XPane2 interface that's used inside Draw/Impress.
        
        How accessibility is implemented is an implementation
        detail and likely subject to change in the near future.
        
        XPane2::setAccessible is currently used, so remains
        for now.
        
        Change-Id: I49c475a795f382a8bf62238f2d6bbd7a95bed97a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185279
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [63e50f38693a8901d582cbc3ab893929b5c124f1]

        sd: Drop unnecessary null check
        
        `mpWorkWindow` was just created a few lines above,
        so can't be null here.
        
        Change-Id: Ibab8b77b9b28821588ee03fea0b5e76ff77975de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185278
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [9d4f9cd2c560feb821b368097ec86079b316e7f6]

        sd: Don't use std::unique_ptr for BasicPaneFactory::mpPaneContainer
        
        There's no need for it, so use a simple PaneContainer
        (a.k.a. std::vector<PaneDescriptor>).
        
        Change-Id: I57f67cadb2eeb9f328bdf229827d50810bb54574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185277
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [925b644ee1d3ad74539f91410e6fbdcb0d015c1a]

        sd: Don't subclass std::vector
        
        ... without adding any additional functionality.
        Just use a std::vector.
        
        Change-Id: I159c789cbf88ae7a4c781829a75eb20b5cd39b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185276
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [8eea65864995b01009bec187fa924e90e57b960f]

        sd: Retrieve component context where needed
        
        Call comphelper::getProcessComponentContext in
        BasicPaneFactory::CreateFullScreenPane instead of
        further up and then passing it all the way down there.
        
        Change-Id: I150ec095fe9f590db403adcf07dc0a8e72613c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185275
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [d8a908c28fa2d5e6e9a2437fc039f413d968199a]

        toolkit: Drop unnecessary XWindow2 param specialization
        
        XWindow2 subclasses XWindow, so there's no need for
        a VCLUnoHelper::GetWindow variant taking an XWindow2
        reference that does the same as the variant taking
        an XWindow reference.
        
        Change-Id: I6f931252d2ae2e046dc31c076094e71b8aa71346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185273
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [b4b6193ab8d0bff882b711eb881a7c0341b87419]

        sd a11y: Drop unnecessary call to getAccessibleContext
        
        AccessibleObject::getAccessibleContext returns a
        reference to self, so calling it is unnecessary
        here.
        
        Change-Id: I396a517b5e8bfc14269e9b8e3513477e9a355c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185270
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [e8a8d4a9a83027a3627f856335dcd7ca4c7db3e7]

        sd a11y: Inline helper to PresenterAccessible::getAccessibleContext
        
        Change-Id: I61b49f76ec921ff785aecb2eaa0963210d278494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185269
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [c76e7c317e5a959024829fa3839fc69925d99c4c]

        svtools a11y: Deduplicate XAccessible implementations
        
        Let the base class, AccessibleTabBarBase implement
        the XAccessible interface, instead of having all
        subclasses doing it separately.
        
        Change-Id: I0cd169a0b015514f5ba59e820d72688a041ab27c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185267
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-15  Michael Weghorn  <m.weghorn@posteo.de>  [0cf1574679ec3e36e392284656e731166f6a36d2]

        svtools a11y: Drop extra indentation level
        
        Change-Id: Ic5102cf0ebebe81d179a9907a81f052a2ad16acd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185266
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [901e160d2ea863af71c180980a76a81ec03b6b65]

        vcl: static_cast to Dialog* once
        
        Change-Id: I181823042d4e6a93f3f1e064c11ecb13bd2d6f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185268
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-05-14  Simon Chenery  <simon_chenery@yahoo.com>  [87c603c2346b5835741a41151420f69b9aaeead8]

        Fix OSL_ENSURE "Should be null here!" warning message in OStatement.cxx
        
        Change-Id: I785f1c406ac1799c1b4ca2508d441185ef80f1c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184730
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-05-14  Patrick Luby  <guibmacdev@gmail.com>  [5913201efff027e683b2ff15349943d99b726414]

        tdf#163945 Coalesce mouse dragged events
        
        Previously, the rate of flushes when using Skia/Metal were limited.
        While the various approaches to limiting flushes fixed tdf#166258,
        they caused tdf#163945 to reoccur on some machines.
        
        So instead of trying to reduce the number of Skia/Metal flushes per
        second, coalesce mouse dragged events when macOS floods the native
        event queue with mouse dragged events.
        
        Change-Id: Ie355c9da705d7ff7d045b924ba0b3d10c093e780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185258
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e56c2ea7ff7e9816414fe333c6a733bd7f424ad]

        sd: pass ViewShell by ref
        
        Change-Id: Idbc66dedfb64c28bc699b54f9c433cfa535598ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185309
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-14  Jonathan Clark  <jonathan@libreoffice.org>  [47efe906bece13d2c4f0525c7889f19bbfb236c3]

        tdf#88752 DOCX import: Ignore text grid base height inside tables
        
        When laying out documents containing a CJK grid, Writer fixes line
        heights to a multiple of the grid line pitch. Writer also applies this
        correction to text inside tables.
        
        Unfortunately, this is not the expected behavior for DOC/DOCX files. In
        order to display such files correctly, this change updates Writer to
        skip this line height adjustment when the MS_WORD_COMP_GRID_METRICS
        compatibility flag is set.
        
        Change-Id: I40792191a7690cb53d2ce02725a0a8a68dd8e606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185307
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [2fe8349ebcd033cd9810b4124638eef652e01f63]

        Simplify SkiaHelper code
        
        Reorder functions to avoid some forward declarations; group some env
        variable checks in a single function to make their interaction clear;
        use function-local statics for safe initialization; use std::atomic
        for safety. Also drops a check of SAL_FORCEGL - it's unused now.
        
        Change-Id: I45a3bdc076b881bda2366f9d57e41cb7b5a177b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [56ed516429ec9320b884341fc811b4bf8fbfc322]

        Drop unused static variable
        
        Change-Id: I6885c7e28553132a4e2cb37dfeee20417e6553e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185298
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [06e1529d712dbfeb4a82bf489d535c6c66f8f50e]

        sd: drop duplicated variable
        
        Since
        commit 291919476294f62d7af9b8b7060d138728897ee7
        Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Date:   Thu Apr 4 07:18:38 2024 +0300
        
            tdf#33603: sd: rework notes panel
        
        Change-Id: I9da4848abbaae6f343228d15c1ad13606571fd78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185310
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [61b9ef5510e94f47c1a8c754f032235b67bc3b13]

        sd: don't use the m prefix in parameters
        
        Since
        commit 291919476294f62d7af9b8b7060d138728897ee7
        Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Date:   Thu Apr 4 07:18:38 2024 +0300
        
            tdf#33603: sd: rework notes panel
        
        Change-Id: I4c022b9118b4dad63c9023ce253b36c9c425c9d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185306
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [12c974caf145145521a88622a3ee8a5d24cde9dc]

        sd: simplify code
        
        Since
        commit 291919476294f62d7af9b8b7060d138728897ee7
        Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Date:   Thu Apr 4 07:18:38 2024 +0300
        
            tdf#33603: sd: rework notes panel
        
        Change-Id: I750a5397f98507168ca862a75e36162b4be4e6ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185300
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-14  Aron Budea  <aron.budea@collabora.com>  [37e4623bfaad6bd9e74205f0040b68d92d976f1b]

        tdf#166511 sw: unify export of DrawingML object IDs
        
        Both docPr and cNvPr have IDs referring to DrawingML objects,
        and are supposed to be unique within the document.
        
        These IDs were handled in different parts of the code during export.
        7460e4f4a7b15cc7984adf65bc17e3d580413224 added a workaround,
        likely to keep them unique, but together with
        4b0fa253a4540f5461397815d290586f9ddabe61 this caused a clash
        sometimes, and the result couldn't be opened in Word afterwards.
        
        Use the same counter for both IDs. It needs to start from 1, as 0
        ID makes at least grouped shapes invalid.
        
        Change-Id: I5e7b9855bc88a61841dfcd3d41599a4ce444eb40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185190
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2025-05-14  Patrick Luby  <guibmacdev@gmail.com>  [18f49e8c314c12761fe3d2413c050311b63d7c0b]

        Correct comments about pkgconf and harfbuzz on macOS
        
        Some of the comments copied from Windows to macOS are only applicable
        to Windows so remove those.
        
        Change-Id: I58293db76578f14459d6568639ace04c09dd206c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184508
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-05-14  AlexTMFN  <pospai.alexandru@gmail.com>  [a347c47ee98913a55d36138cd80fa320b8813c9a]

        tdf#158237 chart2: use c++20 contains() instead of find() and end()
        
        Change-Id: Id1a128b0c0f8e1e7ec13545240fe6c07637e9ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185262
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-14  László Németh  <nemeth@numbertext.org>  [41d3574263d90f1872ff0bad74618761e84d0f61]

        tdf#126154 sw word spacing: fix greedy shrinking regression
        
        Fix failing unit test file:///home/sberg/lo/core//sw/qa/extras/layout/data//tdf126154_minimum_shrinking.fodt:
        /home/sberg/lo/core/test/source/xmltesttools.cxx:169:(anonymous namespace)::testTdf126154_minimum_shrinking::TestBody
        equality assertion failed
        - Expected: ,, , , , , , , , Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vesti bulum
        - Actual  : ,, , , , , , , , Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vesti bulum c
        - In <>, attribute 'portion' of '/root/page[1]/body/txt[18]/SwParaPortion/SwLineLayout[1]' incorrect value.
        
        Regression since commit 01d1037262070ae4ab37868bb47f6ac258433618
        "tdf#126154 tdf#149420 tdf#165984 sw: fix hyphenation
        zones with portions".
        
        Notes: Instead of the desired word spacing, an extra shrinking
        was applied, when minimum and maximum word spacing is specified,
        despite that there was no hyphenation with the desired
        word spacing.
        
        The first Guess() call is for the original line breaking
        with 100% word spacing (specified in the font, no shrinking
        or expanding yet), detecting also the possible space count
        in the line. The second Guess() call is for both the custom
        desired and maximum word spacing. The third Guess() call is
        for the minimum word spacing. No need for the third call, if
        
        1) The desired word spacing is 100% (as in the first Guess() call, and
        
        2) There was no hyphenation in the first Guess() call (minimum
        word spacing is used only for avoid hyphenation, yet).
        
        Change-Id: Ia2e689800f4bdf94512e8b47bc42d6e77c3723ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185299
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-05-14  Miklos Vajna  <vmiklos@collabora.com>  [97066d4f5a89ad89d81a45c0b20ce404f9712fc7]

        tdf#166319 sw interdependent redlines: fix DOCX export of delete under format
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, DOCX import
        works fine, but exporting back to DOCX results in a document Word can't
        open.
        
        It seems that the problem is: this is a "format on top of a delete"
        redline, so we kept writing <w:t> for the format redline content, while
        Word considers "format on top of a delete" essentially a type of delete,
        so it requires <w:delText> instead.
        
        Fix the problem by extending DocxAttributeOutput::RunText() to consider
        both "delete" and "delete, then something on top of it" as a delete
        redline, that results in the correct markup.
        
        Keep our own DOCX import unchanged to still accept both <w:t> and
        <w:delText> for text inside a delete redline.
        
        Change-Id: Id64fcad322bc58dc0ef3e453445f83248d6f3cff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185301
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a5aa50a59a3e5e99d8ffd195e1e6e662b78bef57]

        Simplify ZipFile implementation; deduplicate some iteration code
        
        Change-Id: I1cb3336f0242985dc9df5263d46e41e0f47b3dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185296
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-14  Rania Amina  <rania@libreoffice.id>  [99674b604ee6b6316459ec954e496925a7429f8c]

        Resolves tdf#166542 - Welcome dialog: Animated image broken on macOS
        
        Change-Id: Icfc4497c48a98e39235df86c8e078b874fb68d12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185271
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [0f059a2e5f252e6cf1c441b75e54e30fba33dd04]

        sd: drop unused parameter
        
        Change-Id: I6331e5091ead6f81b4e3c90b91294ff02a23987d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185297
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-14  Simon Chenery  <simon_chenery@yahoo.com>  [7cef9ea98537f990aa9d0b8e9a7f3ed5f1d5d228]

        tdf#164954 translate OSL_ENSURE warning message from German to English
        
        Change-Id: I33d12f11310eacecd1f1fdb6e6c2d56c5ae3faf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184916
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-05-14  marus087  <sorin10mil@yahoo.com>  [4e461bb4e33eaabe54dcd6bb3a7f5b2dbce707be]

        tdf#159444 Warn when View -> Field Names is activated
        
        Change-Id: I0a839ab93ac50e701329d3203ae8e2e655ee748c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185213
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae45f22fcffdbfb8983b7f897819da1a9160fc7c]

        sw: drop macro
        
        Change-Id: I21e847ed025ac88c919e9b0eae30ec4ddb09ceda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185265
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-14  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [b145d0925a68863aae03c123d827de19dc784428]

        tdf#164970 Merge appearance options with themes dropdown
        
        TL;DR
        Now there is only one entity "THEME" the user has to care about when
        using the appearance tab page. We ship three default themes which
        just change the document colors. Custom themes can customize the UI
        too.
        
        We used to have two sections in the appearance tab, the themes dropdown
        and the appearance radio buttons group (automatic, light and dark), and
        this was really confusing.
        
        Let's say I am a new user, and I go to the appearance tag page I select
        the dark radio button, why isn't my application changing to dark mode?
        same for light... and then the distinction between application colors
        and document colors, the radio buttons were mainly for the docuemnt
        appearance, and the themes dropdown was for changing the current theme
        which might change the document colors as well.
        
        Now the radio buttons have been merged with the themes dropdown. Now
        there are three default themes there, "Automatic", "Light" and "Dark".
        These three themes don't define any UI colors and just change the
        document colors. If the user installs a new theme, and if that theme
        defines UI colors, the UI will also be customized.
        
        Change-Id: If8da6d2f729f117ada07e13b607ed8525395cb6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184429
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [27e73648aab7cb31d9315f4a1f6a570f6980b940]

        sd: use initializer list
        
        Change-Id: Ic882597bc44b3162b107b1e929c3542056f5a00d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185280
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [145656fdffd701c24b727141ea5d8203f014beb2]

        Initial Markdown export filter stub
        
        Based on the Writer's HTML export code. For now, it doesn't export
        anything yet, just creates an empty file.
        
        Change-Id: I0d484d2b5bc549f34e674c8f858acb352e275c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184201
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 8e83a343a49b2053bc08326a109956f224a47ae1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185283
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [176bc1783f4fd162114a47a692d9eee6c4cf96c5]

        tdf#130857 qt weld: Implement mouse grab API
        
        Change-Id: I224b29b71852064fd40f455cbf52f06e89521cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [61fa9c603b5757f36e471d381195c15d96fc6548]

        tdf#130857 weld: Simplify/Clarify grab API
        
        The weld::Widget API for grabbing is inspired by
        `gtk_grab_add` from GTK 3 [1] which grabs both,
        mouse and keyboard, blocking interaction with
        other widgets in the application.
        
        For LibreOffice, only grabbing the mouse is of
        interest. CustomWidgetController::CaptureMouse
        is the only caller of weld::Widget::add_grab,
        and the VCL implementation in SalInstanceWidget::add_grab
        also only calls `Window::CaptureMouse` on its
        vcl::Window.
        
        In addition, there is a concept of a "grab count",
        i.e. calling `weld::Widget::grab_add` multiple
        times without `weld::Widget::grab_remove` means
        that `weld::Widget::grab_remove` needs to be
        called the same amount of times later on.
        However, the concept of having "multiple grabs" at
        the same time is also not used anywhere in LO
        in practice, and the VCL implementation also
        doesn't implement that concept.
        
        Therefore:
        
        1) Drop the logical concept of multiple grabs from the
        weld::API. Adjust the gtk3 implementation
        to make sure to have at most one grab at a time
        that is owned by LO application code.
        (Internal GTK toolkit code may use additional grabs.)
        
        2) Rename the methods to make clear that only
        the mouse grab is of relevance.
        (The gtk3 implementation still uses
        `gtk_grab_add`, i.e. grabs the keyboard
        as well.)
        
        In GTK 4, there is no more API for grabbing the
        mouse and only a counter was used to keep track
        of how often weld::Widget::add_grab had been called.
        Switch that to a bool instead.
        
        Qt provides separate methods for grabbing the mouse
        (QWidget::grabMouse [2]) and the keyboard
        (QWidget::grabKeyboard [3]).
        This commit is also to clarify that only the former will
        be needed when implementing this weld API for the Qt-based
        VCL plugins in an upcoming commit and grabbing the keyboard
        isn't needed.
        
        [1] https://docs.gtk.org/gtk3/method.Widget.grab_add.html
        [2] https://doc.qt.io/qt-6/qwidget.html#grabMouse
        [3] https://doc.qt.io/qt-6/qwidget.html#grabKeyboard
        
        Change-Id: If6f34a5eed8efe3dfb8d453c1ee97796cd4418c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185254
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7fd5af6b503260f2b66fbba7f1b4e750ce5dbb52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f11f05e501a3b74e1645d251025a539ccd8626f6
          - tdf#166471 Fix Help for DeepL and LanguageTool
            
            Change-Id: I9e2a1e41dbf34e280a01e9ae102dfd5b99805fff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185274
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [59953740b20ceb2bbc682625739f9bb6278ca7cb]

        sw: pass SwView by ref in some places
        
        Change-Id: Idd450d33e74e9b2de05cb4f88483c2ccf32a8cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185260
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [9396237e8e0e2524b852c1abaa25c50e32ce7d44]

        ReqIF: set all necessary borders in merged cells
        
        Commit 63c91b9cb3f73b66a915875721b0efd65b8aebac (sw HTML import: apply
        default table autoformat on cells in reqif mode, 2018-08-08) made ReqIF
        import apply default table autoformat to tables, because ReqIF has no
        cell format info.
        
        Commit 46fcf87725818666fee34226afdac4a64edd94eb (tdf#115576 sw: fix
        borders for single row/col autotable styles, 2019-11-19) introduced
        special handling for inserting tables with single row and/or column,
        because in that case, the applied formatting was for the first (e.g.,
        top-left) cell, which lacked bottom/right borders.
        
        In case of ReqIF tables with merged cells, which span till the right
        table edge, applying autoformat to such a cell has the same problem:
        the cell position is not rightmost, but it needs a right border as in
        the rightmost cell.
        
        This change extends the code from the fix of tdf#115576, to handle not
        only single-row/single-column cases, but also spanned cells, and fixes
        the ReqIF merged cells case.
        
        Change-Id: I50da381d0a74e75e808036bcf335d0857994bf40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185259
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d8ebf963a294f50efc0a36bb45059e82ddd5118]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07bf6a6ac3870c8b7ad9d28d15f0c2fc4d87b44d
          - tdf#164068 Typo
            
            Change-Id: I5cf7ebb351b2f3720f88519f831634211f8e72ea
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185264
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-13  Miklos Vajna  <vmiklos@collabora.com>  [96faaaf83a1c8b897ce675d175b4d8756d0ea0df]

        tdf#166319 sw interdependent redlines: handle accept of delete under format
        
        The bugdoc has <del>AA<format>BB</format>CC</del> in it, clicking accept
        in the middle of AA results in a leftover BB in the document.
        
        This is because the outer redline type of BB is format, so the other
        type is not accepted together with the delete accept. But this is not
        correct: if the delete is to be accepted, then it's just a small detail
        that there was a format on top of it: all this delete is meant to be
        accepted, like Word does.
        
        Fix the problem similar to how commit
        90077e9b4372e1e3445cc6fb2158a0f2bbb8b1b8 (tdf#166319 sw interdependent
        redlines: handle reject of insert under format, 2025-05-09) handled the
        reject of inserts: if there is a format, then see if it has an
        underlying delete, and if so, still combine the to-be-accepted changes.
        
        Note that rejecting the format + deleting the range means we get
        correctly working undo/redo for this use-case.
        
        Change-Id: I8f05d8f94574d5e89432bf9c2df3a737fa8d6d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185251
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-13  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [b0a9be01890578d239bcb958dec33c301986519d]

        tdf#153294 Optimize item index retrieval in Menu::GetCharacterBounds()
        
        using std::find.
        
        Change-Id: Ia72d77025ea0308e336d0b0b5497fedada7e73cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182729
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f8f7f2ca966ec17001216888461a351e9623af56]

        fix local build failure by changing the order of icu
        
        Issue is described in [1] and the problem was reported upstream
        in Fedora (see [2]), but to limit the issues for other people
        and considering that reordering the icu entries is a no-op, it
        makes sense to merge this work-around.
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2025-March/093126.html
        
        [2] https://bugzilla.redhat.com/show_bug.cgi?id=2354168
        
        Change-Id: Ic8bee2b0d85161b232ac21a7b093895d86391199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184886
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-05-13  Marco Cecchetti  <marco.cecchetti@collabora.com>  [e85be683524c59e072912c625be1a4c818d85950]

        chart color palette for data series: sidebar panel
        
        Change-Id: I6f661515e2de11ea1ead0b79435413d6a0e81c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184264
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185142
        Tested-by: Jenkins

2025-05-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [11f6bfe0c9a22838cf7e947bf9e229eef91d6b80]

        ofz#417031550 sanitize anchor for InsertEmbed too
        
        Change-Id: I5a5dd6566149f10f1df6df6a46ca4b3e69cf41af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185247
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b799cb8b609ecb76d4bd89ac1572897765892b03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 713ded95232e2ffd01bced075b48d7705c14e75b
          - Mute l10n for table with numbers on Stock charts
            
            + Refactor
            + visual enhancement for the table
            
            Change-Id: Ic1385eb9baaf996c676cced7639abd245b36103b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185238
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3346825ed3a5f813eb3f50deffced2967ac8dc6f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68f45944fe1f7228736f82e41cddb056e165f7cb
          - tdf#150865 Help page for TEXTAFTER function
            
            Change-Id: I5f24fddb1c515d1dc3a0454a38f553b041eda9aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185230
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [98e3ba25dea98c390a1047632e8d64a665a4bad6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f83b7a9d6db0adb69580d06fd4fd7bb69e69403
          - tdf#150864 Help page for TEXTBEFORE function
            
            + Fix syntax for TEXSPLIT
            
            Change-Id: I0c0ce6e3ccdc23e23c98277dcbf9272af40921e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185229
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-13  Razvan Degeratu  <razvandegeratu007@gmail.com>  [7744d3134b0308ea2f2cb87177022269a55fff00]

        tdf#162986 Restrict ending of Property Let and Set to only End Property
        
        Change-Id: I023dc6399f97dc5ff1ca6503dbbc0cc7a30eea95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185249
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [542dc75792718d57b3ff689b5d6fda2d49c1b641]

        harfbuzz: upgrade to 11.2.1
        
        * 0001-buffer-Allow-unsafe_to_break-whole-buffer-to-succeed.patch.1
        has been fixed upstream
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.2.1/harfbuzz-11.2.1.tar.xz
        
        Change-Id: I8b215831e702529881c8b2529bde1afd2dd95b8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185246
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-13  Miklos Vajna  <vmiklos@collabora.com>  [acc2258eab90ab5a7f062567dfb090fc81f601e7]

        sw doc model xml dump: show bullet types of an SwNumRule
        
        This helped to write the tdf#166229 testcase, because it shows where the
        actual bullet character is.
        
        Also declare the encoding in SwDoc::dumpAsXml() explicitly, since these
        bullet characters are typically not ASCII, so they didn't show up
        correctly in the output.
        
        Change-Id: I5a6f58d0971c2542e4cd79209589259fa5e9e5b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185243
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5b8f9514a3620cfed9c7035652efee9e246e2450]

        Silence new Clang 21 trunk -Werror,-Wunnecessary-virtual-specifier
        
        ...in CompilerTest_compilerplugins_clang,
        
        > [CPT] compilerplugins/clang/test/fragiledestructor.cxx
        > error: 'expected-error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/fragiledestructor.cxx Line 26 (directive at compilerplugins/clang/test/fragiledestructor.cxx:27): calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]
        >   File compilerplugins/clang/test/fragiledestructor.cxx Line 53 (directive at compilerplugins/clang/test/fragiledestructor.cxx:54): calling virtual method from destructor, either make the virtual method final, or make this class final [loplugin:fragiledestructor]
        > error: 'expected-error' diagnostics seen but not expected:
        >   File compilerplugins/clang/test/fragiledestructor.cxx Line 39: virtual method 'f' is inside a 'final' class and can never be overridden
        > error: 'expected-note' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/fragiledestructor.cxx Line 28 (directive at compilerplugins/clang/test/fragiledestructor.cxx:29): callee method here [loplugin:fragiledestructor]
        >   File compilerplugins/clang/test/fragiledestructor.cxx Line 48 (directive at compilerplugins/clang/test/fragiledestructor.cxx:49): callee method here [loplugin:fragiledestructor]
        
        Change-Id: Ie6484149b902e217a54b7b9423627e608d349d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185221
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-05-13  Michael Stahl  <michael.stahl@allotropia.de>  [4727305dd2e6fa1e92408d9fd7fef70b8d1fb913]

        LOCRCT editeng,sfx2,sw: replace temporary SAL_DEBUG
        
        Change-Id: Ib6f3b732a7eb6f2dbf423ffd2206b0474ff6c681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185200
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-13  Michael Stahl  <michael.stahl@allotropia.de>  [ee7ab3d4634ae916f04811d0ce033637ea22578c]

        LOCRDT editeng,sw: yrs weak link peer cursors for editengine
        
        Replace unreliable integer cursors with WeakRef cursors which maintain
        their position automatically.
        
        This requires yrs v0.23.1 with the yweak_read() function.
        
        Unfortunately this crashes currently, so hide it behind #if YRS_WEAK.
        
        https://github.com/y-crdt/y-crdt/issues/536
        
        Change-Id: I74ec1eaa25c7cb554efd38ee632df041ac92d5c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183311
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [28c2be7c1f96219d4454de36cac0a51c1be24fd3]

        Flatten and simplify FileDialogHelper_Impl::execute a bit
        
        Change-Id: I9035704dacbdad543fc38b2fcaff526ceef1a8d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185241
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [4a120aac11602e01164a222907a7b5bcdfd6ea7f]

        Don't convert from Sequence to vector in FileDialogHelper::Execute
        
        The conversion serves no goal, and no place benefits from that.
        
        Change-Id: Id2f1865fb8ef0cdb51f959b35e482f35fad8b75f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185240
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [927093ab9d9a1a964a3b81655555600655daf195]

        Fix SalGtkFilePicker::getFiles
        
        It should only realloc to 1, when the length is greater. The list may also be empty. This aligns the implementation with other pickers.
        
        Change-Id: I8018e71b855ad0c94184eab93d84655c4915f289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185242
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-13  László Németh  <nemeth@numbertext.org>  [7d4ad3fa74674fff06f52eec0abc8dc7691a89b4]

        tdf#155707 sw DOCX: fix Kashida justification import/export/layout
        
        Fix missing import/export of DOCX w:jc=lowKashida/mediumKashida/
        highKashida justification settings. Add visualization support
        using 133%, 200% and 300% word spacing for them.
        
        Kashida justification allows typesetting less compressed Arabic text,
        but this layout lost in Writer, also lost in DOCX/Word completely at
        DOCX export of Writer (the settings weren't grab-bagged).
        
        Note: instead of grab-bagging (which applied only at table properties
        yet in the case of w:jc), these minimum = desired = maximum word spacing
        values carry the Kashida justification setting. (DOCX cannot support
        custom word spacing, so this doesn't interfere with the other settings.)
        
        Follow-up to commit 5a48070f5904c51dc9e7bbad4213d802fd4bc89b
        "tdf#126154 sw offapi xmloff cui: add min/max word spacing",
        and commit 7d6696757dcdfa3cee481ac7795a91b2b47da363
        "tdf#159923 sw cui offapi xmloff: add custom word spacing".
        
        Change-Id: Icc41a69742ae604d091c6429441261742fe6f763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185233
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b31b1a582ce6fd9c46c761d8a539e7d39e5f240]

        sc: Adapt README.md
        
        TEXTAFTER and TEXTBEFORE don't support regex/wildcard
        
        Change-Id: I4a0210021c962bcd9d4f97370647b9c5af892df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185234
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [0dc2e0bc29e3324dd9e9c8a2853c52414d15d50d]

        Don't use XFilePicker::getFiles
        
        The object is XFilePicker3, so a saner getSelectedFiles is available,
        and all existing implementations actually implement getFiles through
        the latter.
        
        Change-Id: I02839ca56a9a36863d1c96c966331e727b79edde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185239
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-13  Juraj Šarinay  <juraj@sarinay.com>  [6d718cabcc849e271a79b62a42053f58818b41fe]

        Refine the handling of adbe.pkcs7.sha1 signatures when using NSS.
        
        Reject signatures with empty encapsulated content.
        Enforce SHA-1 in the first pass.
        
        Change-Id: I42b5f90d02d2abc0c250497d6cc64df4fa798d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185207
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-13  Michael Weghorn  <m.weghorn@posteo.de>  [c80e95cdc8fa9bc40406295b03b239a4ca4df4ff]

        tdf#130857 qt weld: Take content margins into account
        
        In QtInstanceDrawingArea::handleResizeEvent, take
        the QLabel's content margins into account when
        setting the new output size for the VirtualDevice
        when the QLabel was resized:
        The size that the VirtualDevice has available
        is not the full label size, but the content margins
        need to be subtracted.
        
        Not doing so was seen causing a resize loop for the
        ColorPickerDialog (cui/source/dialogs/colorpicker.cxx,
        UI file: cui/uiconfig/ui/colorpickerdialog.ui) in
        a WIP branch declaring support for that dialog using
        native Qt widgets with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        One way to trigger the dialog:
        
        * "Tools" -> "Options"
        * go to "Appearance" tab
        * in the "Customizations" section, click on the
          color picker next to the "Color" label
        * select "Custom Color"
        
        There are more aspects to address before the dialog
        can actually be declared as supported.
        
        Change-Id: Iaf183926abd8269297b8ae2d865568cc57fbf2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185237
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-13  Michael Weghorn  <m.weghorn@posteo.de>  [a629b5db885087d77f9d4dfa243ea3b5ff7ee75f]

        cui: Use existing CustomWidgetController::IsMouseCaptured
        
        ... in ColorFieldControl, instead of manually keeping track
        of whether the mouse was captured/released.
        
        Change-Id: I452762e34ec0be6ec62ffb5926f35962377c38c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185236
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-13  Michael Weghorn  <m.weghorn@posteo.de>  [a32d5ac87ffecf3ee8fbe0e64cffbf39ec8d8cd8]

        sd: Drop redundant static_cast
        
        Change-Id: I0312daf25a76f45545b6ae5c929168b05aad8f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185235
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2129691310f24a333d2a97e79f99a64e1b19a426]

        external/icu: New Clang 21 trunk -Werror,-Wunnecessary-virtual-specifier
        
        > [CXX] svl/source/misc/PasswordHelper.cxx
        > In file included from svl/source/misc/PasswordHelper.cxx:25:
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:148:28: error: virtual method 'clone' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   148 |     virtual RegexPattern  *clone() const;
        >       |                            ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:328:22: error: virtual method 'flags' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   328 |     virtual uint32_t flags() const;
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:347:27: error: virtual method 'matcher' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   347 |     virtual RegexMatcher *matcher(const UnicodeString &input,
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:379:27: error: virtual method 'matcher' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   379 |     virtual RegexMatcher *matcher(UErrorCode  &status) const;
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:428:27: error: virtual method 'pattern' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   428 |     virtual UnicodeString pattern() const;
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:441:20: error: virtual method 'patternText' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   441 |     virtual UText *patternText(UErrorCode      &status) const;
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:457:21: error: virtual method 'groupNumberFromName' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   457 |     virtual int32_t groupNumberFromName(const UnicodeString &groupName, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:476:21: error: virtual method 'groupNumberFromName' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   476 |     virtual int32_t groupNumberFromName(const char *groupName, int32_t nameLength, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:517:22: error: virtual method 'split' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   517 |     virtual int32_t  split(const UnicodeString &input,
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:561:22: error: virtual method 'split' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   561 |     virtual int32_t  split(UText *input,
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:770:19: error: virtual method 'matches' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   770 |     virtual UBool matches(UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:783:19: error: virtual method 'matches' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   783 |     virtual UBool matches(int64_t startIndex, UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:799:19: error: virtual method 'lookingAt' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   799 |     virtual UBool lookingAt(UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:815:19: error: virtual method 'lookingAt' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   815 |     virtual UBool lookingAt(int64_t startIndex, UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:830:19: error: virtual method 'find' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   830 |     virtual UBool find();
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:847:19: error: virtual method 'find' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   847 |     virtual UBool find(UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:858:19: error: virtual method 'find' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   858 |     virtual UBool find(int64_t start, UErrorCode &status);
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:870:27: error: virtual method 'group' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   870 |     virtual UnicodeString group(UErrorCode &status) const;
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:890:27: error: virtual method 'group' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   890 |     virtual UnicodeString group(int32_t groupNum, UErrorCode &status) const;
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:897:21: error: virtual method 'groupCount' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   897 |     virtual int32_t groupCount() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:914:20: error: virtual method 'group' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   914 |     virtual UText *group(UText *dest, int64_t &group_len, UErrorCode &status) const;
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:936:20: error: virtual method 'group' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   936 |     virtual UText *group(int32_t groupNum, UText *dest, int64_t &group_len, UErrorCode &status) const;
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:945:21: error: virtual method 'start' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   945 |     virtual int32_t start(UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:954:21: error: virtual method 'start64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   954 |     virtual int64_t start64(UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:970:21: error: virtual method 'start' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   970 |     virtual int32_t start(int32_t group, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:985:21: error: virtual method 'start64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   985 |     virtual int64_t start64(int32_t group, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1000:21: error: virtual method 'end' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1000 |     virtual int32_t end(UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1015:21: error: virtual method 'end64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1015 |     virtual int64_t end64(UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1035:21: error: virtual method 'end' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1035 |     virtual int32_t end(int32_t group, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1054:21: error: virtual method 'end64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1054 |     virtual int64_t end64(int32_t group, UErrorCode &status) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1064:27: error: virtual method 'reset' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1064 |     virtual RegexMatcher &reset();
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1082:27: error: virtual method 'reset' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1082 |     virtual RegexMatcher &reset(int64_t index, UErrorCode &status);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1102:27: error: virtual method 'reset' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1102 |     virtual RegexMatcher &reset(const UnicodeString &input);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1118:27: error: virtual method 'reset' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1118 |     virtual RegexMatcher &reset(UText *input);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1145:27: error: virtual method 'refreshInputText' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1145 |     virtual RegexMatcher &refreshInputText(UText *input, UErrorCode &status);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1170:34: error: virtual method 'input' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1170 |     virtual const UnicodeString &input() const;
        >       |                                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1180:20: error: virtual method 'inputText' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1180 |     virtual UText *inputText() const;
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1192:20: error: virtual method 'getInput' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1192 |     virtual UText *getInput(UText *dest, UErrorCode &status) const;
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1213:28: error: virtual method 'region' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1213 |      virtual RegexMatcher &region(int64_t start, int64_t limit, UErrorCode &status);
        >       |                            ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1226:28: error: virtual method 'region' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1226 |      virtual RegexMatcher &region(int64_t regionStart, int64_t regionLimit, int64_t startIndex, UErrorCode &status);
        >       |                            ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1236:22: error: virtual method 'regionStart' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1236 |      virtual int32_t regionStart() const;
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1246:22: error: virtual method 'regionStart64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1246 |      virtual int64_t regionStart64() const;
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1257:23: error: virtual method 'regionEnd' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1257 |       virtual int32_t regionEnd() const;
        >       |                       ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1267:23: error: virtual method 'regionEnd64' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1267 |       virtual int64_t regionEnd64() const;
        >       |                       ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1277:21: error: virtual method 'hasTransparentBounds' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1277 |       virtual UBool hasTransparentBounds() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1297:29: error: virtual method 'useTransparentBounds' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1297 |       virtual RegexMatcher &useTransparentBounds(UBool b);
        >       |                             ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1307:21: error: virtual method 'hasAnchoringBounds' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1307 |       virtual UBool hasAnchoringBounds() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1322:29: error: virtual method 'useAnchoringBounds' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1322 |       virtual RegexMatcher &useAnchoringBounds(UBool b);
        >       |                             ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1337:21: error: virtual method 'hitEnd' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1337 |       virtual UBool hitEnd() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1348:21: error: virtual method 'requireEnd' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1348 |       virtual UBool requireEnd() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1356:33: error: virtual method 'pattern' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1356 |     virtual const RegexPattern &pattern() const;
        >       |                                 ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1375:27: error: virtual method 'replaceAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1375 |     virtual UnicodeString replaceAll(const UnicodeString &replacement, UErrorCode &status);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1398:20: error: virtual method 'replaceAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1398 |     virtual UText *replaceAll(UText *replacement, UText *dest, UErrorCode &status);
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1421:27: error: virtual method 'replaceFirst' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1421 |     virtual UnicodeString replaceFirst(const UnicodeString &replacement, UErrorCode &status);
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1448:20: error: virtual method 'replaceFirst' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1448 |     virtual UText *replaceFirst(UText *replacement, UText *dest, UErrorCode &status);
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1478:27: error: virtual method 'appendReplacement' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1478 |     virtual RegexMatcher &appendReplacement(UnicodeString &dest,
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1509:27: error: virtual method 'appendReplacement' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1509 |     virtual RegexMatcher &appendReplacement(UText *dest,
        >       |                           ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1523:28: error: virtual method 'appendTail' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1523 |     virtual UnicodeString &appendTail(UnicodeString &dest);
        >       |                            ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1539:20: error: virtual method 'appendTail' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1539 |     virtual UText *appendTail(UText *dest, UErrorCode &status);
        >       |                    ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1565:22: error: virtual method 'split' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1565 |     virtual int32_t  split(const UnicodeString &input,
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1594:22: error: virtual method 'split' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1594 |     virtual int32_t  split(UText *input,
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1620:18: error: virtual method 'setTimeLimit' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1620 |     virtual void setTimeLimit(int32_t limit, UErrorCode &status);
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1628:21: error: virtual method 'getTimeLimit' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1628 |     virtual int32_t getTimeLimit() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1651:18: error: virtual method 'setStackLimit' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1651 |     virtual void setStackLimit(int32_t  limit, UErrorCode &status);
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1660:22: error: virtual method 'getStackLimit' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1660 |     virtual int32_t  getStackLimit() const;
        >       |                      ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1676:18: error: virtual method 'setMatchCallback' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1676 |     virtual void setMatchCallback(URegexMatchCallback     *callback,
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1691:18: error: virtual method 'getMatchCallback' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1691 |     virtual void getMatchCallback(URegexMatchCallback     *&callback,
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1709:18: error: virtual method 'setFindProgressCallback' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1709 |     virtual void setFindProgressCallback(URegexFindProgressCallback      *callback,
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/regex.h:1724:18: error: virtual method 'getFindProgressCallback' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1724 |     virtual void getFindProgressCallback(URegexFindProgressCallback      *&callback,
        >       |                  ^
        
        and
        
        > [CXX] i18npool/source/collator/collator_unicode.cxx
        > In file included from i18npool/source/collator/collator_unicode.cxx:29:
        > In file included from i18npool/inc/collator_unicode.hxx:26:
        > In file included from workdir/UnpackedTarball/icu/source/i18n/unicode/tblcoll.h:71:
        > In file included from workdir/UnpackedTarball/icu/source/i18n/unicode/coll.h:70:
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:498:18: error: virtual method 'operator==' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   498 |     virtual bool operator==(const UnicodeSet& o) const;
        >       |                  ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:525:21: error: virtual method 'hashCode' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   525 |     virtual int32_t hashCode() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:795:21: error: virtual method 'size' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   795 |     virtual int32_t size() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:803:19: error: virtual method 'isEmpty' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   803 |     virtual UBool isEmpty() const;
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:828:19: error: virtual method 'contains' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   828 |     virtual UBool contains(UChar32 start, UChar32 end) const;
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:846:19: error: virtual method 'containsAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   846 |     virtual UBool containsAll(const UnicodeSet& c) const;
        >       |                   ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1234:25: error: virtual method 'add' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1234 |     virtual UnicodeSet& add(UChar32 start, UChar32 end);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1340:25: error: virtual method 'retain' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1340 |     virtual UnicodeSet& retain(UChar32 start, UChar32 end);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1378:25: error: virtual method 'remove' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1378 |     virtual UnicodeSet& remove(UChar32 start, UChar32 end);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1415:25: error: virtual method 'complement' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1415 |     virtual UnicodeSet& complement();
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1429:25: error: virtual method 'complement' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1429 |     virtual UnicodeSet& complement(UChar32 start, UChar32 end);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1466:25: error: virtual method 'addAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1466 |     virtual UnicodeSet& addAll(const UnicodeSet& c);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1479:25: error: virtual method 'retainAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1479 |     virtual UnicodeSet& retainAll(const UnicodeSet& c);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1492:25: error: virtual method 'removeAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1492 |     virtual UnicodeSet& removeAll(const UnicodeSet& c);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1504:25: error: virtual method 'complementAll' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1504 |     virtual UnicodeSet& complementAll(const UnicodeSet& c);
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1512:25: error: virtual method 'clear' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1512 |     virtual UnicodeSet& clear();
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1549:25: error: virtual method 'removeAllStrings' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1549 |     virtual UnicodeSet &removeAllStrings();
        >       |                         ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1558:21: error: virtual method 'getRangeCount' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1558 |     virtual int32_t getRangeCount() const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1567:21: error: virtual method 'getRangeStart' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1567 |     virtual UChar32 getRangeStart(int32_t index) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1576:21: error: virtual method 'getRangeEnd' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1576 |     virtual UChar32 getRangeEnd(int32_t index) const;
        >       |                     ^
        > workdir/UnpackedTarball/icu/source/common/unicode/uniset.h:1634:25: error: virtual method 'compact' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >  1634 |     virtual UnicodeSet& compact();
        >       |                         ^
        > In file included from i18npool/source/collator/collator_unicode.cxx:29:
        > In file included from i18npool/inc/collator_unicode.hxx:26:
        > workdir/UnpackedTarball/icu/source/i18n/unicode/tblcoll.h:245:39: error: virtual method 'createCollationElementIterator' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   245 |     virtual CollationElementIterator* createCollationElementIterator(
        >       |                                       ^
        > workdir/UnpackedTarball/icu/source/i18n/unicode/tblcoll.h:257:39: error: virtual method 'createCollationElementIterator' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
        >   257 |     virtual CollationElementIterator* createCollationElementIterator(
        >       |                                       ^
        
        etc.
        
        Change-Id: Id2e6c2ac7b10a625b9698644c310a32b0f4b4aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185220
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-13  Heiko Tietze  <tietze.heiko@gmail.com>  [c353ebe6ef9ca9dfc8107fe2e21cc522dbb32f9b]

        Resolves tdf#166543 - Apply UI choice on Welcome dialog to all modules
        
        Change-Id: Ia576d9da46602529550ce75ddfbe3c4557934f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185226
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [2bbd12d870e935ff3c361b21a599ea86aff061d3]

        Don't use XFilePicker::getFiles in FileDialogHelper
        
        Since commit ef8341f05ec79fcdac3b05b45659f5c98ff05edf,
        XFilePicker3 is used there; XFilePicker2::getSelectedFiles
        is guaranteed to be available. Fallback to deprecated API
        is not needed, and this allows to drop some ugly code.
        
        Change-Id: Id11a5238f3db5930c30f80df6ee6a77a377f6475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185232
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [887804deb541a9a4d14cdafd7eff8f2df35a8cdc]

        New Clang 21 trunk -Werror,-Wunnecessary-virtual-specifier
        
        ...warning about non-overriding virtual dtors in final classes.  Every single
        one of these might or might not be suspicious (e.g., in some cases it might be
        better to have a virtual dtor in a derived-from class).  Also, for some of the
        virtual dtors, making them non-virtual then caused
        
        > error: unnecessary user-declared destructor [loplugin:unnecessaryoverride]
        
        so those were removed completely.
        
        Change-Id: If0ee71645a347d6096b65988c56f627c42fe54b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185223
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-12  Michael Weghorn  <m.weghorn@posteo.de>  [91402db28d9d67f64fe9acc1b4fb3df747fd8f67]

        tdf#130857 qt weld: Call correct handler when switching tab
        
        When switching to a new tab, call the
        `m_aEnterPageHdl` for the new tab page, not
        the `m_aLeavePageHdl` that already gets called
        with the ID of the old page.
        
        This fixes a copy-paste error from
        
            commit d4edde13e808aee6ed1a4b8ae049a956733ee4b9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 10 19:35:00 2024 +0100
        
                tdf#130857 qt weld: Call handlers when tab page changes
        
        that resulted in the button labels not getting
        updated as expected when switching tabs in the
        Welcome dialog newly declared as supported in
        previous commit
        
            Change-Id: Ia224b68b36153b1e818d506e0dc9643292a394d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 12 14:05:23 2025 +0200
        
                tdf#130857 qt weld: Support new Welcome dialog
        
        Change-Id: I7c46961500eeeee326e859f7778cd8278186b39a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185216
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-12  Michael Weghorn  <m.weghorn@posteo.de>  [9a03fb9266440013eef5f8cd11cc1e5478706496]

        tdf#130857 qt weld: Support new Welcome dialog
        
            commit 9d90a1733bcf65763268583c97cd5e31a2f90f0c
            Date:   Tue Apr 15 09:22:55 2025 +0200
        
                Resolves tdf#137931 - Show a Welcome dialog on first start-up
        
        introduced a new dialog that gets shown on first start-up.
        (Deleting the user profile before starting can be used
        to simulate that).
        
        Make that one work using native Qt widgets with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 by adding the newly
        added .ui files to the list of supported .ui files.
        
        The existing "Appearance" tab page ("cui/ui/appearance.ui")
        cannot be declared as supported unconditionally, because
        the "Tools" -> "Options" dialog (and therefore it's "Appearance")
        page are not using native widgets yet.
        
        Therefore, only use native widgets if the parent
        itself is also a native Qt one to distinguish the
        two cases.
        
        Without this commit, the dialog looks broken, because
        part of the .ui files used were declared as supported,
        but others weren't.
        
        Change-Id: Ia224b68b36153b1e818d506e0dc9643292a394d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185215
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-12  Michael Weghorn  <m.weghorn@posteo.de>  [ffb7dc831556c2ce898b167248bed731ea6b2024]

        tdf#130857 weld: Reject inconsistent state for radio button
        
        Being a weld::Toggleable subclass, weld::RadioButton
        implementations need to implement
        weldd::Toggleable::{g,s}et_inconsistent.
        
        However, neither the VCL implementation (SalInstanceRadioButton)
        nor the Qt implementation (QtInstanceRadioButton)
        have a concept of an inconsistent state for radio buttons
        (while checkboxes/check buttons do).
        
        The SalInstanceRadioButton implementation was
        already doing nothing when trying to set the
        state, and always returning false when
        querying the state.
        
        Move the logic to the base class, weld::RadioButton
        and add an assert in weld::RadioButton::set_inconsistent
        to prevent any users from trying to set that state (to true).
        (If there any existing ones, they need to be adjusted.)
        
        Setting the state to `false` (as e.g. implicitly
        happens when calling weld::Toggleable::set_state with a value
        of TRISTATE_TRUE or TRISTATE_FALSE) is fine, only trying to
        set to `true` is problematic.
        
        For GtkInstanceRadioButton, explicitly call the new
        weld::RadioButton versions. (Previously, the ones
        derived from its GtkInstanceCheckButton base class
        were used.)
        
        Change-Id: I292ff838b62205d906fb2faf0d391c503a4786e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185214
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a74db26c207c55bc57683fc04748a1aed67d5870]

        Fix typo
        
        Change-Id: I99ffdc71f761f8235faf55f7e5ac5f2c334f6d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185228
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c003f0f2830f57a7ecd780bfb79c41543a98543]

        Fix typo
        
        Change-Id: Id5ad3a19fb07101b63eefce4273883caf626762e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185227
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c46d5d9effa40c8020135f0cc70d0d938fff073e]

        New Clang 21 trunk -Werror,-Wunnecessary-virtual-specifier
        
        ...warning about non-overriding virtual functions in final classes
        
        Change-Id: Id8c6b5c946ee51dc58bc6f3d7aec0f0bf450e6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185222
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [edaa5c608548ec2878abc5a9dc88f7867a1429a9]

        Simplify namespace handling in SwHTMLWriter
        
        Previously, it stored the namespace alone; and added ":" each time
        the value was used, when it was non-empty (either in GetNamespace,
        or when passed to svt's HtmlWriter).
        
        This change only adds the colon once, when maNamespace is set.
        
        Change-Id: Ib16586ebbf99bea7d301d3ac7a870ff4e68ee50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185203
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9cf87b3f3046591ee2234529109d2ac9b67314af]

        Remove obsolete fw declarations from store/ svgio/ svl/ svtools/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I2c2c082d761b87bfe731ab21caa2f04e385c2e3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183906
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4d5203851bd8529353dfee08559eb818e0996d19]

        Flatpak build needs external/libeot now
        
        ...after be12bc02844260d27afb49c39c747b7571dca9f1 "make libeot enabled by
        default on Linux and macOS"
        
        Change-Id: I08f405a47bf452e5e96ac3c60990c5e73a6846b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185212
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-12  Heiko Tietze  <tietze.heiko@gmail.com>  [86e62c4ec7e076244b29ccb329abbaecedf70f37]

        Resolves tdf#166541 - Welcome dialog must not use standard buttons
        
        Replaced hijacked Okay and Reset buttons by special buttons
        
        Change-Id: If8315be3f8f71ca1fc5fae0136eef4a76232b3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185219
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-05-12  Miklos Vajna  <vmiklos@collabora.com>  [d32dd7675b36952dd38e6c9b7d280ff2c4008404]

        tdf#166229 sw: make bullet style change again with list indentation level
        
        Create a new document, turn on bullets, create a next paragraph,
        increase the indent level, the same bullet character is used for the
        inner level, while this used to be different.
        
        This went wrong in commit 626357f53c934e7f57dc80c3c83ad080767961f3 (Use
        configured bullet symbol when clicking bullets button, 2024-07-11),
        which changes Writer to take the bullet characters from the common
        DefaultBullets settings, because it wanted Writer bullets to respect
        that setting. That's OK, but it always took the bullet character
        configured for the first level, also the size of the characters were
        inconsistent (first is significantly smaller than 2nd, 3rd, 4th).
        
        Fix the problem by taking the current level index into account in
        SwWrtShell::NumOrBulletOn(), unless the configured bullet character list
        is shorter than the amount of available Writer indentation levels. Also
        change the DefaultBullets item values to match what was the default in
        Writer.
        
        Likely this is not controversial, since it seems Impress has its
        own defaults: Writer has 3 characters cycled through 10 levels, Impress
        seems to be switching between "•" and "-" for the first 4 levels, then
        just "•" for the remaining levels. And this is just for new bullets,
        existing numberings do what's stored in the document.
        
        Change-Id: I4a2a458d3fafe96f702d8c1b2f1cf6cd78b8014d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185208
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [a023ade307a86c8d96b854ee2b97a7d5f2f2d51e]

        Simplify SvxIconSelectorDialog::ImportGraphics
        
        Change-Id: I49a1c8eea2be157c92ff65c05df66c18e4f25d8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185209
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd0cc5b2d352dc4d2c1fd406ec2998e91adbd3a1]

        tdf#150865: Add support for TEXTAFTER function
        
        Change-Id: Iedd79b069c145de4c3b70d50552df8bf7da66a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185218
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-12  Alexandru Diaconu  <alexandrudiiaconu@gmail.com>  [047c84f431064d6bf5eeff536e6f554d4e63aac3]

        tdf#162983 Restrict closure of Function and Sub to only End Function and Sub.
        
        Change-Id: Ib08b5961e61d7a151fa7c67666b0f5e31a7828b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185185
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [09a285319bc64eac0ef2cec9dc2e270a25635322]

        tdf#150864: Add support for TEXTBEFORE function
        
        Change-Id: I57a19add67b4ffff12fa8af575d997bcda378a4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185206
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [14ece9f5702909525a9b5814d51c789b714c8bfb]

        startsWith has an optional argument to return the rest
        
        Change-Id: I30cc10122b6d64923a8c87a79fa239eebb1c6c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185202
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-12  Aron Budea  <aron.budea@collabora.com>  [40b7e8671779f94894ce2bd4e7eb9b5d41d48c6e]

        sw: reduce nested levels in GetTextFrame
        
        Change-Id: I4bc43382e60daf3d47770c7c24eb2440b1fecaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185205
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5fb0ee63450bef5f1dbfac4760d56d5710e28015]

        null deref seen on ControllerItem::ReceiverNotifyItemUpdate
        
         #0  CntUInt16Item::SetValue (nTheValue=8, this=0x0) at include/svl/cintitem.hxx:91
         #1  sfx2::sidebar::ControllerItem::ReceiverNotifyItemUpdate (this=0x250f5628, nSID=<optimized out>, eState=SfxItemState::UNKNOWN,
             pState=0x792a379165d0 <(anonymous namespace)::aDisabledItem>)
             at sfx2/source/sidebar/ControllerItem.cxx:56
         #2  0x0000792a33a04284 in SfxStateCache::SetState_Impl (this=0x25170250, eState=SfxItemState::UNKNOWN, pState=0x792a379165d0 <(anonymous namespace)::aDisabledItem>,
             bMaybeDirty=<optimized out>) at sfx2/source/control/statcach.cxx:428
         #3  0x0000792a33a042fc in SfxStateCache::SetState (this=<optimized out>, eState=<optimized out>, pState=<optimized out>, bMaybeDirty=<optimized out>)
             at sfx2/source/control/statcach.cxx:335
         #4  0x0000792a339e20e4 in SfxBindings::UpdateControllers_Impl (rFound=..., pItem=<optimized out>, eState=eState@entry=SfxItemState::DEFAULT)
             at sfx2/source/control/bindings.cxx:1218
         #5  0x0000792a339e5437 in SfxBindings::Update_Impl (this=<optimized out>, rCache=...)
             at sfx2/source/control/bindings.cxx:279
         #6  0x0000792a339e5e11 in SfxBindings::NextJob_Impl (this=this@entry=0x262f52c0, pTimer=pTimer@entry=0x26104cc8)
             at sfx2/source/control/bindings.cxx:1281
         #7  0x0000792a339e6020 in SfxBindings::NextJob (this=0x262f52c0, pTimer=0x26104cc8)
             at sfx2/source/control/bindings.cxx:1226
         #8  0x0000792a350adadb in Scheduler::CallbackTaskScheduling ()
             at vcl/source/app/scheduler.cxx:579
         #9  0x0000792a3526d9eb in SalTimer::CallCallback (this=<optimized out>)
        
        (gdb) print *pState
        $5 = {_vptr.SfxPoolItem = 0x792a37591020 <vtable for (anonymous namespace)::DisabledItem+16>, m_nRefCount = 0, m_nWhich = 0, m_bStaticDefault = true,
          m_bDynamicDefault = false, m_bIsSetItem = false, m_bShareable = true, m_bNameOrIndex = false}
        
        DisabledItem isn't cloneable
        
        Change-Id: Ic9a9134f25b4a66485bd43991451b2841cd3a9f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185198
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-12  Noel Grandin  <noelgrandin@gmail.com>  [02abba61eb3adbf1071e84c95bc0f372e9dca7d4]

        optimise CellAttributeHelper::doUnregister a little
        
        no need to call getDefaultCellAttribute() here and instantiate it,
        if it has not already been instantiated, then we cannot be pointing
        to it.
        Shaves 5% off a profile for me.
        
        Change-Id: I2b0a9cfbbf0429bb55e8a0394b9efa92dfa798e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185201
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-12  László Németh  <nemeth@numbertext.org>  [01d1037262070ae4ab37868bb47f6ac258433618]

        tdf#126154 tdf#149420 tdf#165984 sw: fix hyphenation zones with portions
        
        When the text line contains text portions, fix disabled hyphenation at
        minimum word spacing (implemented by hyphenation zones), paragraph end
        zone and hyphenation zone, by calculating with the start of the line
        instead of the start of the text portion.
        
        Hyphenation wasn't disabled at minimum word spacing, paragraph end
        zone and hyphenation zone, despite the available space, if the text line
        contained text portions, e.g. an emphasized word:
        
        tdf#126154: maximum word spacing: if the hyphenated word has
        got own text portion, maximum word spacing was not applied.
        
        tdf#165984 paragraph end zone: hyphenation was not always disabled
        in the last but one paragraph line (i.e. in the last full paragraph
        line), despite the available space in the last paragraph line, if the
        line contains a text portion. (Paragraph end zone is applied only
        if the text content of the planned last paragraph line is shorter,
        than the actual content of the (hyphenated) last full paragraph line.)
        
        tdf#149420: hyphenation zone was not calculated, if the hyphenated word
        has own text portion, similar to the paragraph end zone.
        
        Fix also regression of the preference of maximum and minimum
        word spacing by checking possible space shrinking in the case, when the
        maximum word spacing was also able to disable hyphenation (the unit test
        verifies the fix of this regression, too).
        
        Follow-up to commit 3dd2d7f449f13bec0f0a5c6e0c33a143409c3723
        "tdf#126154 sw word spacing: fix greedy space shrinking",
        commit 5a48070f5904c51dc9e7bbad4213d802fd4bc89b
        "tdf#126154 sw offapi xmloff cui: add min/max word spacing",
        commit 7d6696757dcdfa3cee481ac7795a91b2b47da363
        "tdf#159923 sw cui offapi xmloff: add custom word spacing",
        commit 7a1d4b7d1db93ca1f541856a8d00d621d50e7bd6
        "tdf#149420 sw offapi xmloff: add hyphenation zone",
        and commit 7d384fb1c232f7aa720436bc68dc1de334bf7297
        "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zone"
        
        Change-Id: I8b798889edba449d4fd5506a8d1a6fd970c37c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185116
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-05-12  Jean-Pierre Ledure  <jp@ledure.be>  [a656c736ec13a2223f221c4157b619f3b0601a9a]

        ScriptForge (Document) all document properties
        
        The Document service proposes already
        to access the document properties
        as a dictionary (Basic or Python).
        
        New entries have been added in recent
        releases of LO. They have been added
        in ScriptForge too.
        
        They are:
          Coverage
          EditingCycles
          Identifier
          Publisher
          Relation
          Rights
          Source
          Type
        
        The user documentation does not need any update.
        
        Change-Id: Id5e449e307e7f394f5b5f0375320ab51afd9c250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185188
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-05-12  Michael Weghorn  <m.weghorn@posteo.de>  [54767d6c0e58c8506c899fe290f03b1216846e44]

        tdf#166334 qt: Drop extra QDialog::show for file dialog
        
        Both callers of QtFilePicker::prepareExecute take
        care of calling either QDialog::exec or QDialog::show
        to show the file dialog after calling
        QtFilePicker::prepareExecute.
        
        Therefore, calling QDialog::show in
        QtFilePicker::prepareExecute in addition is unnecessary,
        and also causes issues seen at least sometimes with the kf6 VCL
        plugin on X11/XWayland (QT_QPA_PLATFORM=xcb), but not
        on Wayland or with the qt6 VCL plugin.
        (With kf6, the QFileDialog triggers the native KF6/Plama
        file dialog that's maintained in the plasma-integration
        git repo.)
        
        Remove the call to QDialog::show from
        QtFilePicker::prepareExecute.
        
        Issues that were quite reproducible for me on Debian testing
        without this commit in place (and are fixed now):
        
        1) When clicking the save button in the Writer toolbar in
          a new document, the Writer window was not always greyed
          out when the file dialog opened as a modal dialog.
        2) When clicking the PDF export dialog in the Writer toolbar,
          the dialog appears for a short time, then another one
          (or maybe rather the same one, animated again?) appears
          instead.
        
        Case 1) happens in about 50% of the cases, 2) even more
        frequently.
        
        The problem described in tdf#166334 that the dialog does
        not show up at all is harder to reproduce for me, but hopefully
        has the same root cause and is therefore also fixed by
        this commit.
        
        It's not exactly clear why the call to QDialog::show
        was in QtFilePicker::prepareExecute, but one explanation
        might be that it may have been necessary before
        
            commit d79a41a02cd46c50cab08ba1a5d5b213b6843251
            Date:   Wed Jun 5 14:04:24 2019 +0200
        
                tdf#129071 Qt5 set file picker parent widget
        
        , as the
        
            if (pTransientParent)
            {
                m_pFileDialog->show();
                m_pFileDialog->window()->windowHandle()->setTransientParent(pTransientWindow);
                m_pFileDialog->setFocusProxy(pTransientParent);
            }
        
        that was in place before that commit made use of the window handle,
        which might only have been created when the dialog was actually
        shown.
        That is no more the case since the above commit however.
        
        Change-Id: I3238aff5be60a33b61f65d36aece74db929f98f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185145
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-12  Michael Weghorn  <m.weghorn@posteo.de>  [c0bdc3daf157ce7929facc95aa1d71967909bde4]

        shell: Drop "EnableATToolSupport" backend setting
        
        The "EnableATToolSupport" setting/property that
        can be queried from desktop backend implementations
        doesn't seem to be used anywhere, so drop it.
        
        There is still MiscSettings::GetEnableATToolSupport,
        but that doesn't make use of the above.
        
        Change-Id: I1ce64101d9795356e87e29c598dde25579a73111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185071
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-12  Michael Stahl  <michael.stahl@allotropia.de>  [0ff4c6619031582b6c520db90a17ed285973e1be]

        LOCRDT editeng,sw: yrs peer cursors for editengine
        
        The cursors are represented as integers in yrs as a first step, which
        isn't ideal.
        
        Surprisingly EditView doesn't really have functions to correct the
        cursor, only ImpEditEngine::UpdateSelections() for the case when nodes
        are deleted, apparently there's only one active EditView at a time
        typically so it wasn't needed?  Typically the active EditView's cursor
        is assigned from a return value of ImpEditEngine.
        
        Add some new functions to correct peer cursors and call them all over
        ImpEditEngine; unfortunately UpdateSelectionsDelete() isn't easy to get
        working on EditView's actual EditSelection cursor so leave that for the
        future...
        
        To fix EE paint of non-active comment, add SwAnnotationWin::Paint()
        
        To get things to paint with "gen", it's enough to invalidate the
        SwAnnotationWin, but for gtk3 a queue_draw() must be called, else it's
        only painted when clicking on the window.
        
        Cursors are painted in color in SidebarTextControl::Paint()
        
        Change-Id: Id8696238290405554ece1b9961676972a559b58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181679
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-12  Miklos Vajna  <vmiklos@collabora.com>  [7143fc5d6f746543162d3de8320c10a0f7aeaca5]

        svx: prefix members of SvxIMapInfo
        
        See tdf#94879 for motivation.
        
        Change-Id: I626e35f8dd44ef4fd8311eb2312db92a0ebff41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185192
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-12  Bogdan Visanescu  <visanescu.business@gmail.com>  [19f3b72f34c487dc97d582712d21734a7e055fd5]

        tdf#165744 Added SeparatorType to ClipboardTextImport and TextToColumnsImport
        
        Change-Id: I90b402972f78a2f698fe3cd91e543a1253c95425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185124
        Reviewed-by: Gabriel Masei <gabriel.masei@libreoffice.org>
        Tested-by: Jenkins

2025-05-12  Jaume Pujantell  <jaume.pujantell@collabora.com>  [af762d820294e891869a32b5ff138e0773d30508]

        cool#11885 lok: sc: translate TabPrefix by user
        
        In LOKit different users can have different locales on the same file, so
        when creating a new sheet with the default name, we must ensure that the
        proper localized name is used. Otherwise the language with which the
        module is first loaded is always used.
        
        A test cannot be added since to test this multiple languages have to be
        enabled and in Jenkins right now only English is enabled.
        
        Change-Id: I6aa4caacc7d079fbf9b14ddf9e27428d77411adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185055
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 76a02119f39ffdf9dde8f6122707da95490f2253)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185094
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-05-11  Patrick Luby  <guibmacdev@gmail.com>  [9d973cdf107d1be4db806e6ec8a6ced49275c4e6]

        Related: tdf#163945 include Skia timer in Skia/Metal flushing rate limit
        
        Previously, Skia/Metal flushes were only limited when called from
        AquaSalFrame::doFlush(). While this fixed tdf#166258, this caused
        tdf#163945 to reoccur on some machines. So expand the Skia/Metal
        flushing rate limit to include flushes called from the Skia timer.
        
        Change-Id: I299f17eb406ddf1c635d4f75d51241807f15f58c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185138
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [80d28b6ad2e1295db7f78e6ad0b19045fa6f377e]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I788f0ddd506fe0db39f123c849a79db9b4902ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185148
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ba9ed0c3878e1d55a61c055df2830469c42ae0f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a849732e3fca989e387de7cd2272c53a792d5ba3
          - About optional arguments in TEXTSPLIT function.
            
            Change-Id: Ia3ce48c3fce1c7aeb3e3d72dd3e8ca32dd816c59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185187
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [49769fe145427137b8b2c6e9a47606e8b93a1eb5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 72d4dba2488778d5da417e1b3b7c288c1532585a
          - Try to improve visual for .code class in dark mode
            
            Change-Id: I071b43d1f62cb608703095eac368b0f15fefbe91
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185186
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1eb93ee46cb776061e74140c2c123435ac5534fd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cb48f1e2e8ff179d834a28a6f4eb9b011ce93d0
          - tdf#150866 TEXTSPLIT function Help page
            
            Change-Id: I0dca2ce456c444ed043023e17f30ac12a8d88b87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185184
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2437902c0811b19ffbe55cfad1bbe6ee5419a863]

        Remove obsolete fw declarations from starmath/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I9c5ffdeb592efdb04925ed055626d88c76441d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183905
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e9ba06d94d838b35a1452c07362aebe2e0404009]

        Remove obsolete fw declarations from slideshow/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I864820687f271e032d67d8eccef83166ea4d2b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183904
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3072f7cbadf456814db2b4857e5931ca7a48ab51]

        Optimize SfxItemIter::GetItemState using SfxItemSet::GetItemState_ForIter
        
        Avoids a lookup in the unordered map, where we already have an iterator.
        
        Change-Id: Ie65c588a9ec7b7c3c1ad3ba2181f6c76ec9b7e9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [4dab3d017ff2668ef00417a51908ab7987132b9a]

        Optimize SfxItemSet::Equals
        
        No need to lookup the element in this - we already have the iterator.
        Introduces SfxItemSet::GetItemState_ForIter for the task.
        
        Change-Id: Ib85706201c452b5345df411c317e79bcf6c17238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185167
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-11  Heiko Tietze  <tietze.heiko@gmail.com>  [9d90a1733bcf65763268583c97cd5e31a2f90f0c]

        Resolves tdf#137931 - Show a Welcome dialog on first start-up
        
        With tabs for introduction (and later perhaps also as what's new
        info), appearance, and UI picker.
        
        Run ./soffice --safe-mode to test but make sure to start the app
        next in normal mode
        
        Change-Id: Ia12ba44c8796fb53f2ec1dbaf46dd25a6ec113cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184195
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b05d626a8e2d0a6272a636fa003e5e1ede47c697]

        Fix typo
        
        Change-Id: I5e59ad3d9062ac9879a5168b79c1400604c78052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185164
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [f61f540969ff8c3fb8adf1d3b65671c98705af09]

        license: keep alphabetical order of 3rd party libs
        
        Change-Id: I0151d4d1d633c47929f402417107e6da878cd66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185161
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [6ebeb8aa629b9f0ecab83836ba5055e3277d2442]

        license: Swahili dictionary section was there 2 times
        
        Change-Id: I2f4402be6e98485056ef4e7b012116457d15825e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185160
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [39c52b3c5475fb6472a969814a162835107d2db7]

        license: Graphite2 is MPLv2
        
        Change-Id: Ica2ba6259c07a34fae697b11c3a29548e4aad31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185153
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [4ac55766a2751f8af0912a8835d0edf735ca9949]

        license: NSS is MPLv2
        
        Change-Id: Ibaebc102e7347cefbe982412e27e86e972c9fc6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185152
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [27801d1c0fff77897c2c75b930ba4826f440a2b4]

        license: zxcvbn-c section was there 2 times
        
        Change-Id: I009d2084d7a399d70c7a9592620c373a7be23f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185151
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [46b53a43c046af1c053b9cffbcceb2294afa027f]

        license: rhino is MPLv2
        
        Change-Id: I6f49d35b766f44fb83beedb498979736de0d337b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185150
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [cc0749a21809c932338d4be793bcc965dc8a767f]

        license: dtoa section was there 2 times
        
        Change-Id: I9735f508c053765ef789bae8045d7729e36806a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185146
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Andras Timar  <andras.timar@collabora.com>  [b2cb815a8f9170fa8045a1a522940ca3d3c5ec4d]

        license: remove LIBORCUS section, it might have been added by mistake
        
        BUILD_TYPE LIBORCUS is never defined, we have ORCUS instead. And
        the license does not match either.
        
        Change-Id: Ic35c1cebe502a3a408157e8d2f5bb7f5b279e430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185141
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b1401b2da20f12b2e22341a30bbce7c58164336a]

        Simplify the nullptr checks, as below in ScPatternAttr::areSame
        
        Change-Id: Ie7547a79a1367f849fa5a6769d5ed262dc174926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185166
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84da1f50ca8261129909901c2ff72adb9c67510a]

        ofz: PngImageReader::read null-deref on empty png
        
        since:
        
        commit 70162a33fde729998e4d9c7558f3634352738772
        CommitDate: Tue Apr 22 03:10:03 2025 +0200
        
            vcl: Introduce ImportOutput to return BitmapEx or Animation
        
        Change-Id: Ia4bf6e913fa388725e4d6c246e727aa5d946f46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185147
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b96107a19177e0cf3561b32b2431cfed9615437]

        crash with apparent SwNoTextFrame* cast to SwTextFrame*
        
         #0  __gnu_cxx::__normal_iterator<sw::Extent const*, std::vector<sw::Extent, std::allocator<sw::Extent> > >::__normal_iterator (__i=<error reading variable>,
             this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1072
         #1  std::vector<sw::Extent, std::allocator<sw::Extent> >::begin (this=0x22) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:879
         #2  sw::MapModelToView (rMerged=..., pNode=0x0, nIndex=0)
             at sw/source/core/text/txtfrm.cxx:1315
         #3  0x00007ff57a86ec75 in SwTextFrame::MapModelToView (this=<optimized out>, pNode=<optimized out>, nIndex=<optimized out>)
             at sw/source/core/text/txtfrm.cxx:1384
         #4  0x00007ff57a86ec9f in SwTextFrame::MapModelToViewPos (this=this@entry=0x37d909a0, rPos=...)
             at sw/source/core/text/txtfrm.cxx:1396
         #5  0x00007ff57a426543 in SwCursor::LeftRight(bool, unsigned short, SwCursorSkipMode, bool, bool, bool, SwRootFrame const*, bool) ()
             at sw/source/core/crsr/swcrsr.cxx:1776
         #6  0x00007ff57a3fafe4 in SwCursorShell::LeftRight(bool, unsigned short, SwCursorSkipMode, bool) ()
             at sw/inc/crsrsh.hxx:495
         #7  0x00007ff57a627a7a in SwCursorShell::Right (bAllowVisual=false, nMode=SwCursorSkipMode::Chars, nCnt=1, this=0x37d51780)
             at sw/inc/crsrsh.hxx:379
         #8  SwEditShell::SetExtTextInputData(CommandExtTextInputData const&) ()
             at sw/source/core/edit/editsh.cxx:1019
         #9  0x00007ff57ad8bd9d in SwEditWin::Command(CommandEvent const&) ()
             at sw/source/uibase/docvw/edtwin.c
        
        (gdb) print *this
        $28 = {<SwContentFrame> = {<SwFrame> = {<SwFrameAreaDefinition> = {_vptr.SwFrameAreaDefinition = 0x7ff57b3f0340 <vtable for SwNoTextFrame+16>, maFrameArea = {
                  m_Point = {<PointTemplate<Point, Size>> = {<PointTemplateBase> = {<Pair> = {mnA = 1418, mnB = 1418}, <No data fields>}, <No data fields>}, <No data fields>},
                  m_Size = {<SizeTemplate<Size>> = {<SizeTemplateBase> = {<Pair> = {mnA = 9972, mnB = 5496}, <No data fields>}, <No data fields>}, <No data fields>}},
                maFramePrintArea = {m_Point = {<PointTemplate<Point, Size>> = {<PointTemplateBase> = {<Pair> = {mnA = 0,
                          mnB = 0}, <No data fields>}, <No data fields>}, <No data fields>}, m_Size = {<SizeTemplate<Size>> = {<SizeTemplateBase> = {<Pair> = {mnA = 9972,
                          mnB = 5496}, <No data fields>}, <No data fields>}, <No data fields>}}, mnFrameId = 24, mbFrameAreaPositionValid = true, mbFrameAreaSizeValid = true,
                mbFramePrintAreaValid = true, static snLastFrameId = 31}, <SwClient> = {<sw::WriterListener> = {
                  _vptr.WriterListener = 0x7ff57b3f04a0 <vtable for SwNoTextFrame+368>, m_pLeft = 0x0, m_pRight = 0x37d51910},
                m_pRegisteredIn = 0x37c42a20}, <SfxBroadcaster> = {_vptr.SfxBroadcaster = 0x7ff57b3f04f0 <vtable for SwNoTextFrame+448>,
                m_RemovedPositions = std::vector of length 0, capacity 0, m_Listeners = std::vector of length 0, capacity 0}, static spCache = 0x3780e4d0, mpRoot = 0x37b49ba0,
              mpUpper = 0x37c33460, mpNext = 0x0, mpPrev = 0x0, Python Exception <class 'ValueError'> Unsupported implementation for unique_ptr: std::__uniq_ptr_data<SwSortedObjs, std::default_delete<SwSortedObjs>, true, true>:
        m_pDrawObjs = {_M_t = {<std::__uniq_ptr_impl<SwSortedObjs, std::default_delete<SwSortedObjs> >> = {
                    _M_t = std::tuple containing = {[1] = 0x0, [2] = {<No data fields>}}}, <No data fields>}}, mnFrameType = SwFrameType::NoTxt, mbInDtor = false,
              mbInvalidR2L = false, mbDerivedR2L = true, mbRightToLeft = false, mbInvalidVert = false, mbDerivedVert = true, mbVertical = false, mbVertLR = false,
              mbVertLRBT = false, mbValidLineNum = false, mbFixSize = false, mbCompletePaint = false, mbRetouche = false, mbInfInvalid = false, mbInfBody = false,
              mbInfTab = false, mbInfFly = true, mbInfFootnote = false, mbInfSct = false, mbColLocked = false, m_isInDestroy = false, mnForbidDelete = 0}, <SwFlowFrame> = {
              _vptr.SwFlowFrame = 0x7ff57b3f0518 <vtable for SwNoTextFrame+488>, m_rThis = @0x37d909a0, static s_bMoveBwdJump = false, m_pFollow = 0x0, m_pPrecede = 0x0,
              m_bLockJoin = false, m_bUndersized = false, m_bFlyLock = false}, <No data fields>}, static s_pTextCache = 0x3780fd60, mnAllLines = 0, mnThisLines = 0,
          mnFlyAnchorOfst = 0, mnFlyAnchorOfstNoWrap = 939852432, mnFlyAnchorVertOfstNoWrap = 49, mnFootnoteLine = 940845376, mnHeightOfLastLine = 954225152,
          mnAdditionalFirstLineOffset = 954225136, Python Exception <class 'ValueError'> Unsupported implementation for unique_ptr: std::__uniq_ptr_data<sw::MergedPara, std::default_delete<sw::MergedPara>, true, true>:
        m_pMergedPara = {_M_t = {<std::__uniq_ptr_impl<sw::MergedPara, std::default_delete<sw::MergedPara> >> = {
                _M_t = std::tuple containing = {[1] = 0x2, [2] = {<No data fields>}}}, <No data fields>}}, mnOffset = {m_value = 1750611950}, mnCacheIndex = 32757,
          mbLocked = false, mbWidow = false, mbJustWidow = false, mbEmpty = false, mbInFootnoteConnect = false, mbFootnote = false, mbRepaint = false,
          mbHasRotatedPortions = false, mbFieldFollow = false, mbHasAnimation = false, mbIsSwapped = false, mbFollowFormatAllowed = false}
        
        Change-Id: I936dc000deb297a5d98b088e46399ec3563c57e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185134
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b3337d83f6b77978a7667b373b855711c836df0]

        merge these two hunks to a standalone function
        
        Change-Id: I02273c656c285428a3f3c797f53758d3e6f79819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185131
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b0dd7d128d8ff35ae887afd8345f4fbc56b2f431]

        bump product version to 25.8.0.0.alpha1+
        
        Change-Id: I196ce30822a6de79f02531435cf57354837a7eae

2025-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a2896e060b54ce6ce36e3e29218fac40d2919c74]

        Version 25.8.0.0.alpha1, tag libreoffice-25.8.0.0.alpha1

2025-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [444a1d668b39fd7919e765ac87bbe48dea6b8134]

        bump product version to 25.8.0.0.alpha1
        
        Change-Id: I46f1ea39a5a93b4a05cb7c69f03dfe4286632ece

2025-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9201d00a1a915679c393cb5489cddb5fc6fc3f28]

        ofz: add libeot to fuzzer libs
        
        Change-Id: Ica9fa2a19cef5a06db80c7cbda9b77dd0c29abac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185140
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [29da9e0082e61f0b9cc0c163b1b5ad30066e1fd2]

        shell kf5be: Use existing toOUString helper + drop duplicate
        
        Change-Id: I4071e21d9d9a2e9bf1f465fb4edc049406ce9e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185072
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [7dca86d9efce82973c86068396abd559f6cc8b24]

        Drop DesktopEnvironmentContext, "system.desktop-environment"
        
        The DesktopEnvironmentContext class's only purpose
        seems to have been to provide the name of the current
        desktop environment (by using Application::GetDesktopEnvironment)
        when queried for "system.desktop-environment".
        
        Stop using this and wrapping the original context
        in `InitVCL`, but instead call Application::GetDesktopEnvironment
        directly in those places that were previously using the property.
        
        The
        
            // Desktop Environment context (to be able to get value of "system.desktop-environment" as soon as possible)
        
        comment in InitVCL removed with this commit doesn't explain
        why this "system.desktop-environment" was used in the first place
        instead of calling Application::GetDesktopEnvironment directly.
        (Since the implementation would call the latter, it
        wouldn't be able to provide anything earlier than if calling
        the method directly.)
        
        As expected, the value for the desktop environment is the same in
        both places with this commit in place as it was previously
        ("PLASMA6" in a KDE Plasma 6 session).
        
        Change-Id: I37bef5d1acdf4c532265696a9f2c37f4e507b86c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185070
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [479dd32e10d43c881aad61ffe06e57f3c26c6770]

        tdf#164380 qt: Ensure at least one MIME type for drag'n'drop
        
        Ensure that the QMimeData subclass set for the QDrag used
        for drag and drop reports at least one supported MIME type.
        Report a dummy "application/x.libreoffice-internal-drag-and-drop"
        one if there is no other one.
        (The string used for the MIME type is of no particular meaning,
        any value would do.)
        
        This prevents the issue seen with qt6 on Wayland that a
        drag and drop operation is cancelled when no formats/MIME types
        are reported.
        
        The "wl_data_offer" Wayland protocol [1] is probably relevant
        here:
        
        > A wl_data_offer represents a piece of data offered for transfer by
        > another client (the source client). It is used by the copy-and-paste and
        > drag-and-drop mechanisms. The offer describes the different mime types
        > that the data can be converted to and provides the mechanism for
        > transferring the data directly from the source client.
        >
        > (...)
        >
        > For objects of version 3 or newer, this request determines the final
        > result of the drag-and-drop operation. If the end result is that no mime
        > types were accepted, the drag-and-drop operation will be cancelled and
        > the corresponding drag source will receive wl_data_source.cancelled.
        
        (Further analysis on Qt and Wayland library/protocol level
        might give more insights, but this is sufficient at least for now.)
        
        Example backtrace for how QtWaylandClient::QWaylandDrag::cancel
        (in Qt's qtwayland module) got called previously when releasing
        the mouse after dragging a slide to a different position in
        the Impress slide sorter (on Debian testing in a Plasma Wayland
        session, kwin-wayland 4:6.3.4-3, Qt self-compiled from git dev):
        
            Thread 1 "soffice.bin" hit Breakpoint 1, QtWaylandClient::QWaylandDrag::cancel (this=0x5555555d44d0) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddnd.cpp:49
            49          QBasicDrag::cancel();
            (gdb) bt
            #0  QtWaylandClient::QWaylandDrag::cancel (this=0x5555555d44d0) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddnd.cpp:49
            #1  0x00007fffe479434b in QBasicDrag::eventFilter (this=0x5555555d44d0, o=0x55555e78fb80, e=0x7fffffff3c70) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qsimpledrag.cpp:109
            #2  0x00007fffdf182bb5 in QtWaylandClient::QWaylandDrag::finishDrag (this=0x5555555d44d0) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddnd.cpp:101
            #3  0x00007fffdf17752e in QtWaylandClient::QWaylandDataDevice::dragSourceCancelled (this=0x5555555dfb60) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddatadevice.cpp:316
            #4  0x00007fffdf179ff5 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDataDevice::*)()>::call(void (QtWaylandClient::QWaylandDataDevice::*)(), QtWaylandClient::QWaylandDataDevice*, void**)::{lambda()#1}::operator()() const (this=0x7fffffff3d70) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #5  0x00007fffdf179f1d in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDataDevice::*)()>::call(void (QtWaylandClient::QWaylandDataDevice::*)(), QtWaylandClient::QWaylandDataDevice*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDataDevice::*)()>::call(void (QtWaylandClient::QWaylandDataDevice::*)(), QtWaylandClient::QWaylandDataDevice*, void**)::{lambda()#1}&&) (args=0x7fffffff40a0, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #6  0x00007fffdf179e3f in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDataDevice::*)()>::call(void (QtWaylandClient::QWaylandDataDevice::*)(), QtWaylandClient::QWaylandDataDevice*, void**)
                (f=(void (QtWaylandClient::QWaylandDataDevice::*)(QtWaylandClient::QWaylandDataDevice * const)) 0x7fffdf177500 <QtWaylandClient::QWaylandDataDevice::dragSourceCancelled()>, o=0x5555555dfb60, arg=0x7fffffff40a0)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #7  0x00007fffdf179db1 in QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDataDevice::*)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDataDevice::*)(), QtWaylandClient::QWaylandDataDevice*, void**)
                (f=(void (QtWaylandClient::QWaylandDataDevice::*)(QtWaylandClient::QWaylandDataDevice * const)) 0x7fffdf177500 <QtWaylandClient::QWaylandDataDevice::dragSourceCancelled()>, o=0x5555555dfb60, arg=0x7fffffff40a0)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #8  0x00007fffdf179cdb in QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDataDevice::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x55555e78e0a0, r=0x5555555dfb60, a=0x7fffffff40a0, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #9  0x00007fffe51061d2 in QtPrivate::QSlotObjectBase::call (this=0x55555e78e0a0, r=0x5555555dfb60, a=0x7fffffff40a0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #10 0x00007fffe5329cd4 in doActivate<false> (sender=0x55555782a110, signal_index=3, argv=0x7fffffff40a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #11 0x00007fffe531fec3 in QMetaObject::activate (sender=0x55555782a110, m=0x7fffdf20cb10 <QtWaylandClient::QWaylandDataSource::staticMetaObject>, local_signal_index=0, argv=0x0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #12 0x00007fffdf180206 in QtWaylandClient::QWaylandDataSource::cancelled (this=0x55555782a110) at qtwayland/src/client/WaylandClient_autogen/include/moc_qwaylanddatasource_p.cpp:143
            #13 0x00007fffdf1801d9 in QtWaylandClient::QWaylandDataSource::data_source_cancelled (this=0x55555782a110) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddatasource.cpp:41
            #14 0x00007fffdf14e06e in QtWayland::wl_data_source::handle_cancelled (data=0x55555782a120, object=0x55555e75d680) at /home/michi/development/git/qt5/qtwayland/src/client/qwayland-wayland.cpp:770
            #15 0x00007ffff32986ce in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
            #16 0x00007ffff329797e in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
            #17 0x00007ffff32981ab in ffi_call () at /lib/x86_64-linux-gnu/libffi.so.8
            #18 0x00007fffe6953c91 in ??? () at /lib/x86_64-linux-gnu/libwayland-client.so.0
            #19 0x00007fffe694fc1f in ??? () at /lib/x86_64-linux-gnu/libwayland-client.so.0
            #20 0x00007fffe6950f13 in wl_display_dispatch_queue_pending () at /lib/x86_64-linux-gnu/libwayland-client.so.0
            #21 0x00007fffdf0c2fe2 in QtWaylandClient::EventThread::dispatchQueuePending (this=0x5555555e08c0) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:228
            #22 0x00007fffdf0b9604 in QtWaylandClient::EventThread::readAndDispatchEvents (this=0x5555555e08c0) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:113
            #23 0x00007fffdf0afd62 in QtWaylandClient::QWaylandDisplay::flushRequests (this=0x5555555cd020) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:520
            #24 0x00007fffdf0cb1e5 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}::operator()() const (this=0x7fffffff46b0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #25 0x00007fffdf0cb10d in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}&&) (args=0x7fffd0003c18, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #26 0x00007fffdf0cb02f in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**) (f=(void (QtWaylandClient::QWaylandDisplay::*)(QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf0afd30 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555cd020, arg=0x7fffd0003c18)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #27 0x00007fffdf0cafa1 in QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay::*)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)
                (f=(void (QtWaylandClient::QWaylandDisplay::*)(QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf0afd30 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555cd020, arg=0x7fffd0003c18)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #28 0x00007fffdf0caecb in QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x5555555f34c0, r=0x5555555cd020, a=0x7fffd0003c18, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #29 0x00007fffe51061d2 in QtPrivate::QSlotObjectBase::call (this=0x5555555f34c0, r=0x5555555cd020, a=0x7fffd0003c18) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #30 0x00007fffe53141cc in QMetaCallEvent::placeMetaCall (this=0x7fffd0003bd0, object=0x5555555cd020) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:620
            #31 0x00007fffe5315f21 in QObject::event (this=0x5555555cd020, e=0x7fffd0003bd0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1429
            #32 0x00007fffe31e2f30 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x5555555cd020, e=0x7fffd0003bd0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3311
            #33 0x00007fffe31e6e38 in QApplication::notify (this=0x55555556ea60, receiver=0x5555555cd020, e=0x7fffd0003bd0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3261
            #34 0x00007fffe52504f9 in QCoreApplication::notifyInternal2 (receiver=0x5555555cd020, event=0x7fffd0003bd0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1110
            #35 0x00007fffe5251169 in QCoreApplication::sendEvent (receiver=0x5555555cd020, event=0x7fffd0003bd0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1550
            #36 0x00007fffe52520a8 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x5555555a3f40) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1890
            #37 0x00007fffe5250fac in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1744
            #38 0x00007fffe5859481 in postEventSourceDispatch (s=0x5555555ca610) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #39 0x00007fffe9f04345 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #40 0x00007fffe9f06577 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #41 0x00007fffe9f06ce0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #42 0x00007fffe58586bb in QEventDispatcherGlib::processEvents (this=0x55555556f6e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #43 0x00007fffe4989c18 in QPAEventDispatcherGlib::processEvents (this=0x55555556f6e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #44 0x00007fffe526a690 in QEventLoop::processEvents (this=0x55555ea18e00, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:104
            #45 0x00007fffe526a8e3 in QEventLoop::exec (this=0x55555ea18e00, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:186
            #46 0x00007fffe4794d57 in QBasicDrag::drag (this=0x5555555d44d0, o=0x55555e762960) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qsimpledrag.cpp:176
            #47 0x00007fffe478a2e8 in QDragManager::drag (this=0x55555e78d700, o=0x55555e762960) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qdnd.cpp:81
            #48 0x00007fffe478addb in QDrag::exec (this=0x55555e762960, supportedActions=..., defaultDropAction=Qt::MoveAction) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qdrag.cpp:248
            #49 0x00007fffe6192d42 in QtDragSource::startDrag (this=0x555557046c00, sourceActions=3 '\003', rTrans=uno::Reference to (SdTransferable *) 0x55555a33bda8, rListener=uno::Reference to (SdTransferable *) 0x55555a33bdb8)
                at vcl/qt6/../qt5/QtDragAndDrop.cxx:54
            #50 0x00007fffe6192f10 in non-virtual thunk to QtDragSource::startDrag(com::sun::star::datatransfer::dnd::DragGestureEvent const&, signed char, int, int, com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, com::sun::star::uno::Reference<com::sun::star::datatransfer::dnd::XDragSourceListener> const&) () at vcl/qt6/../qt5/QtDragAndDrop.cxx:76
            #51 0x00007fffee725518 in TransferableHelper::StartDrag (this=0x55555a33bd80, pWindow=0x55555a2528e0, nDnDSourceActions=3 '\003') at /home/michi/development/git/libreoffice/vcl/source/treelist/transfer.cxx:1050
            #52 0x00007fff9dbd7ff0 in sd::slidesorter::controller::Clipboard::CreateSlideTransferable (this=0x55555a22d1d0, pWindow=0x55555a2528e0, bDrag=true, bMergeMasterPagesOnly=false)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsClipboard.cxx:499
            #53 0x00007fff9dbd9489 in sd::slidesorter::controller::Clipboard::StartDrag (this=0x55555a22d1d0, rPosition=Point = {...}, pWindow=0x55555a2528e0)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsClipboard.cxx:596
            #54 0x00007fff9dc1b3ef in sd::slidesorter::SlideSorterViewShell::StartDrag (this=0x55555a21bdc0, rDragPt=Point = {...}, pWindow=0x55555a2528e0)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx:660
            #55 0x00007fff9dbf1366 in sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler::DragAndDropModeHandler
                (this=0x55555e20cd70, rSlideSorter=..., rSelectionFunction=..., rMousePosition=Point = {...}, pWindow=0x55555a2528e0) at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:1396
            #56 0x00007fff9dbf124d in std::_Construct<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&>
                (__p=0x55555e20cd70, __args=..., __args=..., __args=Point = {...}, __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:119
            #57 0x00007fff9dbf0e5a in std::allocator_traits<std::allocator<void> >::construct<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&> (__p=0x55555e20cd70, __args=..., __args=..., __args=Point = {...}, __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/alloc_traits.h:706
            #58 std::_Sp_counted_ptr_inplace<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&> (this=0x55555e20cd60, __a=..., __args=..., __args=..., __args=Point = {...}, __args=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:607
            #59 0x00007fff9dbf0c57 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, std::allocator<void>, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&> (this=0x7fffffff65a0, __p=@0x7fffffff6598: 0x0, __a=..., __args=..., __args=..., __args=Point = {...}, __args=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:970
            #60 0x00007fff9dbf0b7a in std::__shared_ptr<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<void>, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&> (this=0x7fffffff6598, __tag=..., __args=..., __args=..., __args=Point = {...}, __args=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1713
            #61 0x00007fff9dbf0af2 in std::shared_ptr<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler>::shared_ptr<std::allocator<void>, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&> (this=0x7fffffff6598, __tag=..., __args=..., __args=..., __args=Point = {...}, __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:463
            #62 0x00007fff9dbee841 in std::make_shared<sd::slidesorter::controller::(anonymous namespace)::DragAndDropModeHandler, sd::slidesorter::SlideSorter&, sd::slidesorter::controller::SelectionFunction&, Point const&, VclPtr<sd::Window>&>
                (__args=..., __args=..., __args=Point = {...}, __args=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:1007
            #63 0x00007fff9dbee754 in sd::slidesorter::controller::SelectionFunction::SwitchToDragAndDropMode (this=0x55555a323350, rMousePosition=Point = {...})
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:661
            #64 0x00007fff9dbef8da in sd::slidesorter::controller::SelectionFunction::ModeHandler::StartDrag (this=0x55555ea0d510, rMousePosition=Point = {...})
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:947
            #65 0x00007fff9dbf06d4 in sd::slidesorter::controller::(anonymous namespace)::NormalModeHandler::ProcessMotionEvent (this=0x55555ea0d510, rDescriptor=...)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:1102
            #66 0x00007fff9dbef62c in sd::slidesorter::controller::SelectionFunction::ModeHandler::ProcessEvent (this=0x55555ea0d510, rDescriptor=...)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:847
            #67 0x00007fff9dbee47e in sd::slidesorter::controller::SelectionFunction::ProcessEvent (this=0x55555a323350, rDescriptor=...) at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:640
            #68 0x00007fff9dbecea8 in sd::slidesorter::controller::SelectionFunction::ProcessMouseEvent (this=0x55555a323350, nEventType=1024, rEvent=...)
                at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:623
            #69 0x00007fff9dbecf42 in sd::slidesorter::controller::SelectionFunction::MouseMove (this=0x55555a323350, rEvent=...) at /home/michi/development/git/libreoffice/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx:335
            #70 0x00007fff9df19339 in sd::ViewShell::MouseMove (this=0x55555a21bdc0, rMEvt=..., pWin=0x55555a2528e0) at /home/michi/development/git/libreoffice/sd/source/ui/view/viewshel.cxx:700
            #71 0x00007fff9df01faa in sd::Window::MouseMove (this=0x55555a2528e0, rMEvt=...) at /home/michi/development/git/libreoffice/sd/source/ui/view/sdwindow.cxx:248
            #72 0x00007fffee462270 in ImplHandleMouseEvent (xWindow=..., nSVEvent=NotifyEventType::MOUSEMOVE, bMouseLeave=false, nX=117, nY=328, nMsgTime=16292359, nCode=1, nMode=MouseEventModifiers::DRAGMOVE)
                at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:693
            #73 0x00007fffee466675 in ImplHandleSalMouseMove (pWindow=0x555556e035d0, pEvent=0x7fffffff81b8) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2330
            #74 0x00007fffee465304 in ImplWindowFrameProc (_pWindow=0x555556e035d0, nEvent=SalEvent::MouseMove, pEvent=0x7fffffff81b8) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2663
            #75 0x00007fffe61cbdec in SalFrame::CallCallback (this=0x5555560402d0, nEvent=SalEvent::MouseMove, pEvent=0x7fffffff81b8) at vcl/inc/salframe.hxx:310
            #76 0x00007fffe61c8a45 in QtFrame::CallCallback (this=0x5555560402c0, nEvent=SalEvent::MouseMove, pEvent=0x7fffffff81b8) at vcl/inc/qt6/../qt5/QtFrame.hxx:235
            #77 0x00007fffe62fb633 in QtWidget::mouseMoveEvent (this=0x555556dfbdb0, pEvent=0x7fffffff9440) at vcl/qt6/../qt5/QtWidget.cxx:135
            #78 0x00007fffe32a2ae5 in QWidget::event (this=0x555556dfbdb0, event=0x7fffffff9440) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:8969
            #79 0x00007fffe62fd01a in QtWidget::event (this=0x555556dfbdb0, pEvent=0x7fffffff9440) at vcl/qt6/../qt5/QtWidget.cxx:513
            #80 0x00007fffe31e2f30 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x555556dfbdb0, e=0x7fffffff9440) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3311
            #81 0x00007fffe31e4bf2 in QApplication::notify (this=0x55555556ea60, receiver=0x555556dfbdb0, e=0x7fffffff9440) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2788
            #82 0x00007fffe52504f9 in QCoreApplication::notifyInternal2 (receiver=0x555556dfbdb0, event=0x7fffffff9440) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1110
            #83 0x00007fffe52511f9 in QCoreApplication::sendSpontaneousEvent (receiver=0x555556dfbdb0, event=0x7fffffff9440) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1564
            #84 0x00007fffe31e3853 in QApplicationPrivate::sendMouseEvent
                (receiver=0x555556dfbdb0, event=0x7fffffff9440, alienWidget=0x555556dfbdb0, nativeWidget=0x555556df4450, buttonDown=0x7fffe3dd9488 <qt_button_down>, lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false)
                at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2369
            #85 0x00007fffe32e2ad8 in QWidgetWindow::handleMouseEvent (this=0x5555575a7590, event=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:669
            #86 0x00007fffe32e12f3 in QWidgetWindow::event (this=0x5555575a7590, event=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:292
            #87 0x00007fffe31e2f30 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x5555575a7590, e=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3311
            #88 0x00007fffe31e6e38 in QApplication::notify (this=0x55555556ea60, receiver=0x5555575a7590, e=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3261
            #89 0x00007fffe52504f9 in QCoreApplication::notifyInternal2 (receiver=0x5555575a7590, event=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1110
            #90 0x00007fffe52511f9 in QCoreApplication::sendSpontaneousEvent (receiver=0x5555575a7590, event=0x7fffffffa518) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1564
            #91 0x00007fffe408eb27 in QGuiApplicationPrivate::processMouseEvent (e=0x55555da09130) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2480
            #92 0x00007fffe408dc76 in QGuiApplicationPrivate::processWindowSystemEvent (e=0x55555da09130) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2204
            #93 0x00007fffe417628d in QWindowSystemInterface::sendWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1113
            #94 0x00007fffe417613e in QWindowSystemInterface::flushWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1082
            #95 0x00007fffdf0afd75 in QtWaylandClient::QWaylandDisplay::flushRequests (this=0x5555555cd020) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:521
            #96 0x00007fffdf0cb1e5 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}::operator()() const (this=0x7fffffffaa20) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #97 0x00007fffdf0cb10d in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}&&) (args=0x7fffd0002f38, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #98 0x00007fffdf0cb02f in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**) (f=(void (QtWaylandClient::QWaylandDisplay::*)(QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf0afd30 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555cd020, arg=0x7fffd0002f38)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #99 0x00007fffdf0cafa1 in QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay::*)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)
                (f=(void (QtWaylandClient::QWaylandDisplay::*)(QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf0afd30 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555cd020, arg=0x7fffd0002f38)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #100 0x00007fffdf0caecb in QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x5555555f34c0, r=0x5555555cd020, a=0x7fffd0002f38, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #101 0x00007fffe51061d2 in QtPrivate::QSlotObjectBase::call (this=0x5555555f34c0, r=0x5555555cd020, a=0x7fffd0002f38) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #102 0x00007fffe53141cc in QMetaCallEvent::placeMetaCall (this=0x7fffd0002ef0, object=0x5555555cd020) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:620
            #103 0x00007fffe5315f21 in QObject::event (this=0x5555555cd020, e=0x7fffd0002ef0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1429
            #104 0x00007fffe31e2f30 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x5555555cd020, e=0x7fffd0002ef0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3311
            #105 0x00007fffe31e6e38 in QApplication::notify (this=0x55555556ea60, receiver=0x5555555cd020, e=0x7fffd0002ef0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3261
            #106 0x00007fffe52504f9 in QCoreApplication::notifyInternal2 (receiver=0x5555555cd020, event=0x7fffd0002ef0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1110
            #107 0x00007fffe5251169 in QCoreApplication::sendEvent (receiver=0x5555555cd020, event=0x7fffd0002ef0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1550
            #108 0x00007fffe52520a8 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x5555555a3f40) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1890
            #109 0x00007fffe5250fac in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1744
            #110 0x00007fffe5859481 in postEventSourceDispatch (s=0x5555555ca610) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #111 0x00007fffe9f04345 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #112 0x00007fffe9f06577 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #113 0x00007fffe9f06ce0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #114 0x00007fffe58586bb in QEventDispatcherGlib::processEvents (this=0x55555556f6e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #115 0x00007fffe4989c18 in QPAEventDispatcherGlib::processEvents (this=0x55555556f6e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #116 0x00007fffe61ea842 in QtInstance::ImplYield (this=0x5555555f9020, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:501
            #117 0x00007fffe61edb41 in QtInstance::DoYield (this=0x5555555f9020, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:512
            #118 0x00007fffeec40736 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #119 0x00007fffeec4004f in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #120 0x00007fffeec3fe30 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #121 0x00007ffff7b28bb9 in desktop::Desktop::Main (this=0x7fffffffd650) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1680
            #122 0x00007fffeec61f76 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:231
            #123 0x00007fffeec63ba9 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:249
            #124 0x00007ffff7ba306a in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #125 0x00005555555559fd in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #126 0x00005555555559d7 in main (argc=1, argv=0x7fffffffd858) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        [1] https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_data_offer
        
        Change-Id: I41476b2c9330a5a67e7663ac53a5ba57601c4b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185136
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [68be8930c486942fd156c251a45842380c9210ee]

        vcl: Drop no more needed SystemEnvData::aShellWindow
        
        Previous changes up to
        
            Change-Id: I7d44e8a8907fa3946d9b9a249e12c542fa656f1c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 10 00:47:02 2025 +0200
        
                gen: Port SystemEnvData::{aShellWindow -> pSalFrame} for DnD
        
        replaced all uses of SystemEnvData::aShellWindow,
        so drop it (and adjust code that was previously setting it).
        
        Change-Id: I60d69c6e5cb8b7bb9343d419ea6a6ea2a4fc1d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185123
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [2c1be1c3fa520ca3e19845be32f4bfe696c3faa2]

        gen: Port SystemEnvData::{aShellWindow -> pSalFrame} for DnD
        
        Similar to what was done for GTK and Qt based VCL plugins
        in previous commits
        
            Change-Id: I569e147182776c2d78f2269b1dc5eb37d009e3bf
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 10 00:09:51 2025 +0200
        
                gtk: Use dedicated SystemEnvData::pSalFrame for frame
        
        and
        
            Change-Id: I17282ce785ce48ffd2e4346a3108d12ab51c2786
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 10 00:26:54 2025 +0200
        
                qt: Use dedicated SystemEnvData::pSalFrame for frame
        
        , also use SystemEnvData::pSalFrame instead of
        SystemEnvData::aShellWindow for the DnD logic in
        the gen/x11 VCL plugin.
        
        This further unifies the approach, and allows to
        drop SystemEnvData::aShellWindow altogether, which
        will be done in a separate upcoming commit.
        
        Change-Id: I7d44e8a8907fa3946d9b9a249e12c542fa656f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185122
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [bcc7afd7ea8873c44eeab4c18b887ed6bcbe8d9b]

        qt: Use dedicated SystemEnvData::pSalFrame for frame
        
        This is basically the Qt version of previous commit
        
            Change-Id: I569e147182776c2d78f2269b1dc5eb37d009e3bf
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 10 00:09:51 2025 +0200
        
                gtk: Use dedicated SystemEnvData::pSalFrame for frame
        
        for the GTK based VCL plugins.
        
        In addition, this extends QtFrame::FillSystemEnvData
        to actually set SystemEnvData::pSalFrame (as unlike for
        the gtk VCL plugins, that wasn't done earlier yet)
        and pass the frame when calling that method from
        the QtFrame ctor.
        
        Change-Id: I17282ce785ce48ffd2e4346a3108d12ab51c2786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185121
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [97671a572b6d1e6effae8e51bf3d786706d77e1a]

        gtk: Use dedicated SystemEnvData::pSalFrame for frame
        
        SystemEnvData already has a SystemEnvData::pSalFrame
        member for the SalFrame, and GtkSalFrame::InitCommon
        sets both, that one and SystemEnvData::aShellWindow
        to a pointer to self.
        
        Therefore, use the dedicated SystemEnvData::pSalFrame
        in DnD code instead of the less typesafe (and specific)
        sal_IntPtr SystemEnvData::aShellWindow and reinterpret_cast.
        
        Change-Id: I569e147182776c2d78f2269b1dc5eb37d009e3bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185120
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [75be6f36fc84ce5e9869790b0ac26576a6c0573b]

        gen: Get shell window directly from the frame in WMAdaptor
        
        Avoid the detour via the frame's SystemEnvData,
        which also gets rid of the need to static_cast to
        Window, as X11SalFram::GetShellWindow returns that
        type.
        
        Change-Id: Iefdcd6e2a75042a7de5f81b61d13b516c6dde363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185119
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [2e8a055fbd8ca62b73d042b1955917e3969ddf1e]

        gen: Pass X11SalFrame to SalI18N_InputContext ctor
        
        ... instead of a pointer to the subclass, SalFrame.
        
        This allows retrieving the two windows of interest directly
        from the X11SalFrame instead of using the indirection
        via the frame's SystemEnvData.
        
        Change-Id: I7afb6d2067c238b94865836fd528d3824c7054f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185118
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [23a0ff4f42436ef629a089b4e3972b0dd7b4b2fd]

        gen: Use more specific X11SalFrame param
        
        ... in SalI18N_InputContext::SetICFocus and
        related SalI18N_InputContext::Map. This allows
        retrieving the two windows of interest directly
        from the X11SalFrame instead of using the indirection
        via the frame's SystemEnvData.
        
        Change-Id: Ia5af52fc949b77d8cd22fbf83a14e5b4e4cc6c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185117
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [75f2077fd057901142a1e5e333409f2eb1193903]

        vcl: Return XClipboard in SalInstance::CreateClipboard
        
        ... instead of the very generic XInterface, to make
        clearer what this is about from the return type as well.
        
        Adjust related code accordingly. This also allows dropping
        a static_cast and UNO_QUERY in AquaSalInstance::CreateClipboard.
        
        Change-Id: Ibf40f2844a60c4ceb1b5e3e11125b10803d5303e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185115
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [37952deeb68bbd3632bf111611ac139ad1863310]

        qt: Return XClipboard in QtClipboard::create
        
        ... instead of the more generic XInterface.
        
        Change-Id: I249ad00d289daf679522714c48dd41339802b53d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185114
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [828b8f9105808f7d52fa73d6fc9c9f0b2ca20ee8]

        vcl: Return XDropTarget in SalInstance::{Impl}CreateDropTarget
        
        Return reference of the more specific XDropTarget
        interface instead of the more generic XInterface,
        to make clearer what this actually is from the
        signature, instead of only querying for
        the XDropTarget interface later in Window::GetDragSource.
        
        Change-Id: I07d8b9492b8bd07aab4f02a94cffaaf16fbb8a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185113
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [5016881d284d9a7592ebeb7c5ea1ff1219bc1205]

        vcl: Return XDragSource in SalInstance::{Impl}CreateDragSource
        
        Return reference of the more specific XDragSource
        interface instead of the more generic XInterface,
        to make clearer what this actually is from the
        signature, instead of only querying for
        the XDragSource interface later in Window::GetDragSource.
        
        Change-Id: I4d51b73b5b2b4c2b4ae6548c4279ae7d5eaea45c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185112
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [55f6bd0a626a3f02664fad7aed9248c129131cf5]

        win, macOS: Drop return value of OleDnDHelper
        
        This is similar to previous commit
        
            Change-Id: I16f2be9876cbb6cc7d93b40820460dd1684d1e2c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 9 15:59:53 2025 +0200
        
                tdf#164380 vcl: Move X11DnDHelper to gen, drop return value
        
        , also in preparation of returning more specific interfaces
        from SalInstance::ImplCreate{DragSource,DropTarget} in upcoming
        commits.
        
        Change-Id: Iaabd0594d4bb6a985e12daaf7342e54921114d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185111
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [90df46c20f9949edf6de52897b13148e7a299907]

        tdf#164380 vcl: Move X11DnDHelper to gen, drop return value
        
        By now, vcl::X11DnDHelper is only used in the gen VCL
        backend, so move the helper function there and rename
        it to just "InitializeDnD".
        
        Drop the return value, as its the same as an input
        parameter (and thus the callers already have a reference
        to the object of interest).
        
        Resolve disambiguity for SelectionManagerHolder and DropTarget
        (which inherit from XInterface via multiple paths in the class
        hierarchy) in a way that already prepares for returning
        a more specific interface from
        SalInstance::ImplCreate{DragSource,DropTarget}
        in the future.
        
        Change-Id: I16f2be9876cbb6cc7d93b40820460dd1684d1e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185110
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [0e808d1d87d7294b6d6f35e6ec68803c42b5298a]

        tdf#164380 gtk: No longer use vcl::X11DnDHelper, XInitialization
        
        This is the gtk3/gtk4 version of
        
            Change-Id: Ia8a4d305dfcb3916ba44596b31614e2467701514
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 9 14:27:58 2025 +0200
        
                tdf#164380 qt: No longer use vcl::X11DnDHelper, XInitialization
        
        , see that commit's message for more details.
        
        For the GTK based VCL plugins, leave the default
        ctor for both classes in place, because that one is
        also called from elsewhere; but there, XInitialization::initialize
        is not called at all, so leave the logic for the default
        ctor unchanged (and call it from the new ctor taking
        one param).
        
        No change in behavior intended, and drag'n'drop to/from
        Firefox to Writer was still working as expected in a quick test.
        
        Change-Id: Icade8e26f055a7efd75a1aa1a0d3e058ab09daaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185109
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [6f066661936301b4bced4e3ed91c8331804cd0c5]

        tdf#164380 qt: No longer use vcl::X11DnDHelper, XInitialization
        
        Stop using vcl::X11DnDHelper to initialize
        QtDragSource and QtDropTarget.
        vcl::X11DnDHelper uses the XInitialization interface
        to pass the display connection and window via
        XInitialization::initialize.
        
        However, the display connection isn't used, and
        the window handle is already known, so instead
        pass those directly to the QtDragSource and QtDropTarget
        ctors, and stop supporting the XInitialization interface
        altogether.
        
        The parameters passed to XInitialization::initialize
        are documented for the X11DragSource and X11DropTarget
        services in their .idl files, but those are not relevant
        here in the Qt implementation, because this one is only
        supporting the XDragSource and XDropTarget
        interfaces and not reporting the service names including
        the "11" in the name (i.e. specific to the X/X11 window system)
        in the name as supported.
        
        Change-Id: Ia8a4d305dfcb3916ba44596b31614e2467701514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185108
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [3a1aa682e1c2a797a6ba72be1f28a4570a53a80c]

        qt: Drop unused QtDropTarget::deinitialize
        
        Change-Id: Id054fd205f9588257c661dafed99427f3b85f14b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185107
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [c3bb9c5d72ae64a55f06d1ebea3b1b526076ebe0]

        qt: Drop unused QtDragSource::deinitialize
        
        It's non-virtual and not used anywhere.
        
        Change-Id: Ic3f4f098a7895f4b6f2232ea6fe8f384587e7398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185106
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [0a0637b2affa0ae9ee735f9961feef8c706de976]

        gen: Drop always default SelectionManager::get param
        
        Since
        
            Change-Id: Ibc1b6637e3def37f96ab074bde7fe40b60e330c3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 9 13:27:32 2025 +0200
        
                gen: Drop complexity as string is always empty anyway
        
        , there's no more caller explicitly passing a value
        for the `rDisplayName` param, so drop it altogether.
        
        Change-Id: Idbe2376effc5073f6c18962a67cdd695cd796c86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185105
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [877e0198101fcf79e8c74b86ff339e4b6f11c7bb]

        gen: Drop complexity as string is always empty anyway
        
        While this does interesting checks for the first arg,
        `aDisplayName` will always be an empty string as
        an empty/default-constructed Any is used when assigning a
        value using `operator>>=`.
        
        Therefore, drop the extra logic that doesn't
        have any effect, and go with the default param of
        an empty OUString for SelectionManager::get.
        
        Change-Id: Ibc1b6637e3def37f96ab074bde7fe40b60e330c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185104
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [3701ae3d37d46e0988a4fb2e2d45025ff8d355bc]

        gen: Drop unused function declarations
        
        These functions are only declared, but never defined/used.
        
        Change-Id: I7997ef94c30b05a53e8ffabad14c420b8fb6edc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185103
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-10  Jean-Pierre Ledure  <jp@ledure.be>  [92494fbbec5c95130d58cf8ecf76210a1e243c7f]

        ScriptForge (Basic) new Wait() method
        
        Constructions (Python) like
            import time
            while some_event is False:
                time.sleep(1)
        watching for some_event becoming True
        have the drawback to freeze the LibreOffice
        user interface.
        
        While next (Basic) snippet
            Do While Not some_event
                Wait(1000)
        does not.
        
        The Python example prevents for waiting for events
        that require user input,f.i. entering a value
        in a cell.
        
        The here proposed alternative is (Python):
            basic = CreateScriptService('Basic')
            while some_event is False:
                basic.Wait(1000)
        This works smoothly.
        The Wait() method executes in the background
        a Basic Wait statement.
        
        This impacts only Python user scripts.
        The change requires an update of the user
        documentation.
        
        Change-Id: Idb73907a5e27cf288310e306fb41c0aba9c8a388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185137
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [540a68b0d2515c0b6991fb385e8ab6b75812ec6a]

        Fix typo
        
        Change-Id: I68e8e8270f8ff5f10cc6f31dc10ababe68c5e411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185098
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f5b066df04702b00485a3f1a93563a677251bc4e]

        Fix typo
        
        Change-Id: I27d1d5601d0d1495b6ac1c8d9e0513fbab695531
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185097
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-10  Noel Grandin  <noelgrandin@gmail.com>  [0d62ab61e982a0967386e40f21829fc95870b969]

        tdf#163015 FILEOPEN: Opening specific XLSX file takes long time
        
        we spend most of our time inserting into the output sorted_vector,
        which ends up needing a lot of data movement when the output
        vector becomes large.
        Re-arrange the data structures so we can do this in one pass,
        and instead of inserting into the output vector, we can just
        append to it.
        
        Change-Id: If729e8ca1f2e6b5cf546c17331f1f3716674f2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185099
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-10  Noel Grandin  <noelgrandin@gmail.com>  [0a6d9fe495c5ed77fa8a56eb7f070d43ebaa725d]

        reduce some data copying
        
        Change-Id: I9f6bb99df4505dd0c5bbfd8b40d9642864a9fb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [866538a4aeb30a598a6ede3d1763d898eb1920b0]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to ff34fc43e747b73b0068153d799d35d49d8a7c79
          - Revert "Add licenses for Assamese, Kannada, Oriya, Punjabi and Sanskrit"
            
            This reverts commit 0d46e01e7f084e76b67fecd1e175726551b979f6.
            
            Reason for revert: the copying file contradicts the copyright statements of the individual files, easier to revert the whole commit than to retroactively fix stuff.
            
            also since spell check and hyphenation can have different licenses, having corresponding headers in the files would be more suitable.
            The text of a license by itself without a reference what it refers to is not all that helpful.
            
            Change-Id: I84ce0d1fe8a051cbab7136339d7c400cf3f6959d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185056
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2025-05-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4ed74ccee6d8fb9debc263c3b1c8b210e5efdc25]

        Update git submodules
        
        * Update translations from branch 'master'
          to 952baf29a8a0656894fe7bd8f7874f6ee381ee9a
          - update translations for master/25.8.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I54e251ceeb0497c9585777cf545b3d8df9637aab
            
2025-05-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9430b6549a6bf4b6717530c578796e93c5a43f9a]

        use meson as an external when building with fully-internal python
        
        people didn't read configure's warnings and systemwide installed copy of
        meson just causes too many conflicts or even if people read the message
        they'd still break the idea behind fully-internal python.
        
        If the user specifies MESON in autogen.input it will be called as
        specified, if configure autodetects it, it will be prefixed with the
        python command used for building.
        
        meson requires python 3.7, so if harfbuzz is enabled configure now also
        now checks for that (can by bypassed by setting PYTHON in autogen.input
        
        Change-Id: I6535c9f421fe865b389a87252163ab99d617b7b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185032
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [37af47835ef334e91be37929ee3c519933d9c1bc]

        fix fully-internal python on linux when cross-compiling
        
        the build needs to use the python created for the build side, so follow
        the windows example
        
        Change-Id: I167df5d342529a20da0a94651f4c9c7ec864efc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185096
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-09  Skyler Grey  <skyler.grey@collabora.com>  [ba2d75a9932c9a42cc54d52645be88a7cd420466]

        fix(slideshow): Use CoreGraphics to render on iOS
        
        Similarly to `doc_paintTile` in init.cxx, we can't use the regular
        initialization for our graphics backend on iOS. If we do so, we render
        a completely white area. Instead, we need to use CoreGraphics, which is
        the iOS library for rendering graphics
        
        Change-Id: I94cb620d422c02f8343db30eea24cecc53d928c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185095
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e695245b6256161a263722a67c551026a32a62c7]

        tdf#117436 - Set text cell to accommodate potential multiline cells
        
        Set text cell to accommodate potential multline cells during the copy
        and paste process of a table from Base to Calc.
        
        Change-Id: I8032627aee8190b0956be80d64144dc4d7fb07e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185092
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-05-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9bc5b89c149497a83117edfadc3fb0b96d2f9899]

        Remove obsolete fw declarations from sdext/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I63327d7a046d7fc781e6c9c793cb7dc8990754d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183902
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [cbbf3431a0e85392f210f78d79549ee4be69e751]

        Remove obsolete fw declarations from sfx2/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I6cbbf85940a7c961108df6eefbcc9dc5d2b67bf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183903
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-09  knordback  <kurt.nordback@collabora.com>  [95b2c8b82e63ed9f6c0bdeeab2fe9e74ee6283c0]

        tdf#165742 Step 4.3: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML
        and re-export.
        
        Fix various aspects of input and output for chartex (and specifically
        for funnel charts). This now allows for loading and re-exporting a
        very basic funnel chart, with the result that MS Office successfully
        loads the exported chart, and it looks similar (though not quite
        identical) to the original.
        
        Change-Id: I6eeb277e31250031604f7cdd21b80848a9c642ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184758
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-05-09  Rohan Sinha  <rohan05.sinha@gmail.com>  [fda2cfeb8e69ec95bb464301140999486d06b984]

        tdf#163691 replace memcpy with std::copy in xml_byteseq
        
        Change-Id: I6d178bcb6127ba444bf4566906efe46204f5ab6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183511
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-05-09  Miklos Vajna  <vmiklos@collabora.com>  [170a12a2a38f1424d60d0cacfbdf8fae0f441fa2]

        CppunitTest_sw_layoutwriter3: fix en-GB vs en-US mismatch
        
        The test code at testTdf126154_minimum_shrinking and testTdf126154
        checked if en-US hyph data is available, but the documents worked with
        an en-GB locale, so it could happen that you had en-US installed and
        then the test failed if en-GB was not installed.
        
        Adapt the test documents to the test code to fix the inconsistency.
        
        Change-Id: I826db1bdb19bb383ee8e992eac64495670889d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185090
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-05-09  Miklos Vajna  <vmiklos@collabora.com>  [3c039cb31239ba01e3d3b56c526bdb7ba6446032]

        tdf#166319 sw interdependent redlines: handle reject of insert under format
        
        The bugdoc has <insert>AA<format>BB</format>CC</insert> in it, clicking
        reject in the middle of AA results in a leftover BB in the document.
        
        This is because the outer redline type of BB is format, so the other
        type is not rejected together with the insert reject. But this is not
        correct: if the insert is to be rejected, then it's just a small detail
        that there was a format on top of it: all this is meant to be rejected,
        like Word does.
        
        Fix the problem similar to how commit
        d5ca8b09d5ecdc28e28486e5dbd1ecb655d817ab (tdf#166319 sw interdependent
        redlines: handle accept of insert under format, 2025-05-05) handled
        accept: if there is a format, then see if it has an underlying insert,
        and if so, still combine the to-be-rejected changes.
        
        Note that in contrast to insert-then-delete, it's not enough to accept
        the change to delete it (for the higher level reject purpose), so
        explicitly call DeleteRange() on the range of the format after the
        format redline is gone.
        
        Change-Id: Iaf1122d8e37e210790972e0312564245fa6f813f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185089
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7999585bd83783282bd2ab7025f3fd7f676e7c41]

        crash on null pattern de-ref
        
         #5  0x00007fc235921b20 in ScPatternAttr::GetItem (nWhichP=145, this=0x0) at sc/inc/patattr.hxx:164
         #6  ScPatternAttr::GetItem<ScMergeFlagAttr> (nWhich=..., this=0x0) at sc/inc/patattr.hxx:167
         #7  ScGridWindow::UpdateCursorOverlay (this=0x0, this@entry=0x39eb3d30)
             at sc/source/ui/view/gridwin.cxx:6610
         #8  0x00007fc235922c0d in ScGridWindow::CursorChanged (this=0x39eb3d30)
             at sc/source/ui/view/gridwin.cxx:6259
         #9  0x00007fc2359c6860 in ScTabView::ShowAllCursors (this=this@entry=0x356a9c68)
             at include/rtl/ref.hxx:203
         #10 0x00007fc2359c2586 in ScTabView::PaintBlock (this=this@entry=0x356a9c68, bReset=bReset@entry=true)
             at sc/source/ui/view/tabview2.cxx:1286
         #11 0x00007fc2359c271f in ScTabView::DoneBlockMode (this=0x356a9c68, bContinue=bContinue@entry=false)
             at sc/source/ui/view/tabview2.cxx:658
         #12 0x00007fc2359c2779 in ScTabView::DoneBlockMode (this=this@entry=0x356a9c68, bContinue=bContinue@entry=false)
             at sc/source/ui/view/tabview2.cxx:666
         #13 0x00007fc2359ce0ca in ScTabView::SetTabNo (this=0x356a9c68, nTab=3, bNew=<optimized out>, bExtendSelection=false, bSameTabButMoved=<optimized out>)
             at sc/source/ui/view/tabview3.cxx:1965
         #14 0x00007fc2359e851d in ScTabViewShell::Notify (this=0x356a9a60, rBC=..., rHint=...)
             at sc/source/ui/view/tabvwsh5.cxx:202
         #15 0x00007fc245e6f935 in __gnu_cxx::__normal_iterator<SvtListener**, std::vector<SvtListener*, std::allocator<SvtListener*> > >::__normal_iterator (
             __i=<optimized out>, this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1073
         #16 std::vector<SvtListener*, std::allocator<SvtListener*> >::end (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:889
         #17 SvtBroadcaster::SvtBroadcaster (this=0x2b, rBC=...) at svl/source/notify/broadcast.cxx:180
         #18 0x00007ffdb455a730 in ?? ()
         #19 0x0000000000000003 in ?? ()
         #20 0x0000000002476c90 in ?? ()
         #21 0x00007fc244207e01 in avmedia::MediaFloater::setURL (this=0x331fc030, rURL=..., rReferer=..., bPlayImmediately=<optimized out>)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191
         #22 0x00007fc2498f32e0 in com::sun::star::xml::sax::cppu_detail_getUnoType(com::sun::star::xml::sax::XAttributeList const*)::the_type ()
            from /opt/collaboraoffice/program/libmergedlo.so
        
        Change-Id: I7d62f67a840fe6c27b7bcf80fdaf66dff8c270c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [df2423ac932a16021c7bc4e1a2e32b9caa0579b4]

        CppunitTest_sd_font_embedding_tests also needs the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", to avoid
        
        > Test name: testExportEmbeddedFontsPPTX::TestBody
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 32512
        > - failed to execute: sh .../bin/officeotron.sh .../tmp/libtest_sd_font_embedding_tests.so1z20bm.tmp > .../tmp/libtest_sd_font_embedding_tests.so1z20bo.tmp 2>&1
        > java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init
        
        Change-Id: I13732bc79b36621413ca6cea8ae37419795160a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185087
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [17d2a10303272ed90ed0b2fe7ba886a2ab3a65e1]

        external/libeot: Silence invalid-shift-base
        
        ...as seen during CppunitTest_sd_font_embedding_tests,
        
        > src/EOT.c:15:68: runtime error: left shift of 160 by 24 places cannot be represented in type 'int'
        >     #0 0x7f0b39e71791 in EOTreadU32LE (/instdir/program/libvcllo.so+0xbbb0791)
        >     #1 0x7f0b39e73882 in EOTfillMetadataSpecifyingVersion (/instdir/program/libvcllo.so+0xbbb2882)
        >     #2 0x7f0b39e754a6 in EOTfillMetadata (/instdir/program/libvcllo.so+0xbbb44a6)
        >     #3 0x7f0b39e7129e in EOT2ttf_buffer (/instdir/program/libvcllo.so+0xbbb029e)
        >     #4 0x7f0b35eb77d9 in EmbeddedFontsHelper::addEmbeddedFont(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >, std::__debug::vector<unsigned char, std::allocator<unsigned char> > const&, bool, bool) /vcl/source/gdi/embeddedfontshelper.cxx:120:13
        >     #5 0x7f0acf649034 in oox::ppt::EmbeddedFontListContext::onEndElement() /oox/source/ppt/EmbeddedFontListContext.cxx:96:30
        >     #6 0x7f0ace1879d4 in oox::core::ContextHandler2Helper::implEndElement(int) /oox/source/core/contexthandler2.cxx:124:9
        >     #7 0x7f0ace2287c6 in oox::core::FragmentHandler2::endFastElement(int) /oox/source/core/fragmenthandler2.cxx:91:5
        >     #8 0x7f0b07f340ca in (anonymous namespace)::Entity::endElement() /sax/source/fastparser/fastparser.cxx:515:27
        >     #9 0x7f0b07f33a98 in sax_fastparser::FastSaxParserImpl::callbackEndElement() /sax/source/fastparser/fastparser.cxx:1340:17
        >     #10 0x7f0b07f23a24 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) /sax/source/fastparser/fastparser.cxx:339:18
        >     #11 0x7f0b4391eb84 in xmlParseEndTag2 /workdir/UnpackedTarball/libxml2/parser.c:9632:2
        >     #12 0x7f0b438d0124 in xmlParseTryOrFinish /workdir/UnpackedTarball/libxml2/parser.c:11374:14
        >     #13 0x7f0b438c4f6c in xmlParseChunk /workdir/UnpackedTarball/libxml2/parser.c:11640:5
        >     #14 0x7f0b07f1e811 in sax_fastparser::FastSaxParserImpl::parse() /sax/source/fastparser/fastparser.cxx:1091:21
        >     #15 0x7f0b07f18318 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:895:9
        >     #16 0x7f0b07f39a50 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1479:13
        >     #17 0x7f0ace1b2541 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) /oox/source/core/fastparser.cxx:121:15
        >     #18 0x7f0ace1b2cd8 in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
        >     #19 0x7f0ace2871ce in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:421:21
        >     #20 0x7f0ace285a1d in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) /oox/source/core/xmlfilterbase.cxx:351:12
        >     #21 0x7f0acf65bbb2 in oox::ppt::PowerPointImport::importDocument() /oox/source/ppt/pptimport.cxx:109:17
        >     #22 0x7f0ace1c54ab in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/core/filterbase.cxx:486:49
        >     #23 0x7f0acf65f687 in oox::ppt::PowerPointImport::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/ppt/pptimport.cxx:214:24
        >     #24 0x7f0af938ff1a in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2685:34
        >     #25 0x7f0b01e1acd1 in sd::DrawDocShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sd/source/ui/docshell/docshel4.cxx:458:39
        >     #26 0x7f0af9342ab1 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:768:23
        >     #27 0x7f0af95d3e84 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1986:36
        >     #28 0x7f0af9e36f00 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:771:28
        >     #29 0x7f0ac5b19f36 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1180:37
        >     #30 0x7f0ac5b10dd2 in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:415:20
        >     #31 0x7f0ac5b09292 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:311:5
        >     #32 0x7f0ac5b04674 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:167:14
        >     #33 0x7f0ac5bd9348 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:594:16
        >     #34 0x7f0ac5bd96c6 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
        >     #35 0x7f0adc8e6a09 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:72:62
        >     #36 0x7f0af3eb9f62 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /test/source/unoapi_test.cxx:125:19
        >     #37 0x7f0af3eb9098 in UnoApiTest::loadFromURL(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:107:5
        >     #38 0x7f0af3eba994 in UnoApiTest::loadFromFile(std::basic_string_view<char16_t, std::char_traits<char16_t> >, char const*) /test/source/unoapi_test.cxx:132:5
        >     #39 0x7f0b0e518798 in SdModelTestBase::createSdImpressDoc(char const*, char const*) /sd/qa/unit/sdmodeltestbase.hxx:54:13
        >     #40 0x7f0b0e50fa7d in testRoundtripEmbeddedFontsPPTX::TestBody() /sd/qa/unit/FontEmbeddingTest.cxx:49:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3555/>)
        
        Change-Id: I0fed461981c812a10ee88ea44629afe6c76525ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185086
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a3c7481469af82a3df8cb14a07db75ffb2e3ef92]

        external/libeot: Conditionally --enable/disable-debug
        
        But --enable-debug also unconditionally enables -Werror, and which would start
        to cause lots of warning errors, so patch that out.
        
        Change-Id: I9df4b3c924d6490c4f0c01d68808fb875e0517ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185085
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b663c391578727c49844439e9383f123c0f616c6]

        -Werror,-Wunused-private-field
        
        ...after 7bc7ff06d7e6bd34063e22d41b07f81e3b9fd255 "Remove 'StandardDir'"
        
        Change-Id: I5d8ccfad8b1dcf7578687c2651ff4c91bb68937b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185078
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2584109a7929cc44e4dc5a1e57a98a10151973df]

        tdf#117436 - Adjust row height to accommodate potential multiline cells
        
        Using drag and drop to copy a table from Base to Calc adapts the row
        height of the imported content in order to accomodate potential
        multiline cells in the Base table.
        
        Change-Id: Ifadf3f9034a5440385cea7b35ce4e28f206b744d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185066
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f4ed5e6f627c31bfd675a2a8fe642aa1c9251d5f]

        vcl: convert PCX to use ImportOutput
        
        Change-Id: I979091f0d7d6c6c5bf31209d3dc64606e230ba19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185077
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1251d5314a0ab9e511585768132da67edf935a0a]

        vcl: convert MET to use ImportOutput
        
        Change-Id: I90296dd29afb46dd731db96c25928e22fa42712a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185076
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [b247e20e364e861f257c0454bd9a740ca663aefa]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5a5c9c705b258d3452b721d24ab7afbb1278ad19
          - Update Danish dictionaries to v2.9.001
            
            Downloaded from https://www.stavekontrolden.dk/?dictionaries=1
            
            Change-Id: I48572f4c46d5d1ea1cd0e6d5671a33dccf3b9142
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/185081
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c2596a4b59fe4b301bdfd1f0f66bb9e2a1f5b40]

        tdf#150866: Add support for TEXTSPLIT function
        
        Change-Id: I918b46c29791f865e841eb967b2799f7986538bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185027
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [88945b5afdb3106efe3bd2d0463642d42fbd8a59]

        postgresql: upgrade to 15.13
        
        * 0001-Fix-detection-and-handling-of-strchrnul-for-macOS-15.patch.1 has
        been fixed upstream
        Downloaded from https://ftp.postgresql.org/pub/source/v15.13/postgresql-15.13.tar.bz2
        
        Change-Id: I23c9e543ff5bcf649616d3ef0d3253d33e09d3aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185069
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [80e08f59eaee11a0ff1874416cbcc7e3fb102164]

        make libeot compile on Windows
        
        Compile for Windows with LO infrastructure (not the only external lib
        where we do this).
        
        Remove unneeded include of <err.h> in libeot.c that isn't used, but
        Windows doesn't have <err.h> - it's a BSD / Linux thing.
        
        Only compile libeot.la and not the eot2ttf binary (which uses err.h so
        it doesn't compile on Windows).
        
        Change-Id: I26afb2b7bcf0bdf0d2ce0bdbcfceb10599d599e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185057
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5683376d063569368bd7d3036ec6ce725134bb08]

        tdf#165392 Save as should default to current document directory as well
        
        As done in 3fa39a4dadc8e2777185465a6f7c9968c8cf44d1 for Export,
        do the same for "Save as"/"Save a copy" as well.
        
        Change-Id: I5135cff0f74d6673fcfc7fa090ed752bea1d59cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184542
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d57d5826dbcf5769187302718245db8333ce6a27]

        Fix typo
        
        Change-Id: Ic0961f62e5212901104c60fa2119a9fd4cc896ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185029
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [446f9b4fc8e8ebfa5e76ab47f1db4540a7d4343d]

        Fix typo
        
        Change-Id: I3e7d2b34ef2f48c6ba6743e77a8c93d889a467e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185030
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [291bcefebcaf6edf190a038f76baecae1915f8d6]

        Fix typo
        
        Change-Id: I6bdd79f78a09bf71a9e1226f57ea0ce0f6421734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185061
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e814908e7a06c7e0c6a2afa44c29f32838606ab0]

        Fix typo
        
        Change-Id: I511dae887646e37aded7384d7252ca38a7419425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185060
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9fdb80496ab6248e5ff9c35bca6a3c30e836752]

        Fix typo
        
        Change-Id: I511dae887646e37aded7384d7252ca38a74194b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185063
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [94c737a93c3ee75d3d61320d9cd2c7452a87f458]

        Remove duplicated include
        
        Change-Id: If79118e70001aadc0d7a1389c834bc6247affd50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185059
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7452cf296bdc86ca7145c10e4aa701c38766c6e8]

        Fix typo
        
        Change-Id: If693065ce54cbd56f454e69775cb480e214e1a0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185062
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6deb75dfee687ec06fcf3d08a2d67d344507da1c]

        use final upstream harfbuzz fix
        
        Change-Id: Ibc57f684d45ab59332f22546f36f0e5bf79c5d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185067
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-08  László Németh  <nemeth@numbertext.org>  [3dd2d7f449f13bec0f0a5c6e0c33a143409c3723]

        tdf#126154 sw word spacing: fix greedy space shrinking
        
        If there are multiple possible break points allowed by minimum
        word spacing to avoid of hyphenation, choose the nearest to the
        desired word spacing, not the opposite.
        
        Note: fix also potential unit testing problems by using
        metric-equivalent Liberation Sans in the old test document
        tdf126154.fodt instead of Arial.
        
        Follow-up to commit 5a48070f5904c51dc9e7bbad4213d802fd4bc89b
        "tdf#126154 sw offapi xmloff cui: add min/max word spacing"
        and commit 7d6696757dcdfa3cee481ac7795a91b2b47da363
        "tdf#159923 sw cui offapi xmloff: add custom word spacing".
        
        Change-Id: Ib08e1910997d6e0526edcdb9c8fef10d5c8614d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185058
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [15ed00fcef6bbc83b43da2e0c33d0eecba22fd55]

        tdf#166200 The list of open documents/windows is incorrect
        
        Revert "speed up menu construction at app startup"
        
        This reverts commit a18b0b4aa56c47cadd0b6d6d1ad5842cf16e9835.
        
        Change-Id: Ibfa0fe91fcfacf4a357782fedb48468b711044af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185036
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-08  Mike Kaganski  <mike.kaganski@collabora.com>  [33434f16206aaa07f56af8f4c23b05b3c88a2124]

        tdf#166342: refactor SbxValue::Format again, to handle date/time strings
        
        Commit 81e1e0a2a671f19950c1bd3c69f9aa24b0c562e7 changed string-to-number
        procedure from SvNumberFormatter to only use SbxValue::ScanNumIntnl. But
        the latter can only handle strings with simple numbers, not with dates,
        times and the like.
        
        This change restores use of SvNumberFormatter to convert input strings
        to number, when SbxValue::ScanNumIntnl fails. The code is re-structured
        for performance, to avoid creating SvNumberFormatter twice, and repeated
        calls to GetOUString.
        
        Change-Id: I89a4fc041fe24fe00b099ab4fbee371d1f6b5567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185047
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-08  Oliver Specht  <oliver.specht@cib.de>  [4882974799f647fd34c88e86e86fa9fee734af6f]

        Improve labels/help text of page break related controls
        
        Change-Id: I5b40606c1b498d33df1569c7ad63f6b0102f5201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185009
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-05-08  Musuroi David-Gabriel  <titans156@gmail.com>  [4629d59ae52c5d7f0e4d79f412291097c8f7fc40]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: Ic2a72861d7a0c2daaa942d8644b46d1d261a8257
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185049
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-05-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7bc7ff06d7e6bd34063e22d41b07f81e3b9fd255]

        Remove "StandardDir"
        
        This was supposed to set some kind of "default directory" for file pickers.
        It was never implemented for anything except the "gen" vcl plugin - and
        is also not really needed.
        
        Change-Id: I94c6ff04984fc7b1d600530dc26bd8a7672646cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184064
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-05-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [878e48d92dedf8edd8b63a5077c92820623631f6]

        depend on cross-toolset when for foo.allbuild and foo.allcheck targets
        
        Change-Id: I9419c28174b00e207ce1773f695074055cf1905b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185033
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-08  Mike Kaganski  <mike.kaganski@collabora.com>  [5a9c784cba996b599e36965d241509696d19ff3c]

        tdf#136112: return 'Date' type from Time()
        
        Change-Id: Id21a4c378ddf9888740b3201f109e1897b722ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185046
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-05-08  Miklos Vajna  <vmiklos@collabora.com>  [8f7b76c4b2967308f4fd77e1e4620bf30ae7d160]

        sw redline: extract a PreAppendFormatRedline() from AppendRedline()
        
        Similar to commit 7a19e55b09dba8a7c04209f6525418a6af485e7a (sw redline:
        extract a PreAppendInsertRedline() from AppendRedline(), 2025-05-06),
        but this is for format redlines.
        
        Change-Id: I20fd2dccd84646383c39ba13da733dde51aee87c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185048
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-08  Michael Stahl  <michael.stahl@allotropia.de>  [910ccfe6a35c1a039196e29defa7074d35158e3a]

        LOCRDT sw: yrs peer cursors
        
        Factor out a class sw::VisibleCursorState containing all data required
        for a peer cursor.
        
        Let SwCursorShell::UpdateCursor() etc correct also the peer cursors
        locally in the sw shells, else the cursors will be painted in the wrong
        place; every peer updates its own cursor in the yrs model.
        
        Split SwVisibleCursor::SetPosAndShow() into 2 functions, to find the new
        position, and actually paint things.
        
        Peer cursors are not VCL cursors (they don't need to blink) but painted
        in SwSelPaintRects::Show() in color via drawinglayer.
        
        Change-Id: I21ae8cb3fd76759a10b5c226cf3294a5c9fc6451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180900
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-05-08  Michael Stahl  <michael.stahl@allotropia.de>  [af81946e31376938031274086b3ca61b7abe391f]

        LOCRDT sw: fix bug when removing comment before start anchor
        
        Missing remove before insert.
        
        Change-Id: I7072456b96b3137380e27be1e62239b59ac30b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185017
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7e15c704cedf1ca77b3ebe8b3b60f6a1ad57deb0]

        tdf#166481 sc shapes edit view: fix wrong draw view shell
        
        was created when an object was in rotation drag mode and we
        enter into the shape to text edit mode.
        We only need to switch to draw shell if we have not already
        created a text shell for text edit mode.
        
        TODO: unit/UI tests would be useful for the original enhancement.
        (c628a26cd3f763b39a2e2441fc766dabf04ed492)
        
        Follow-up commit of
        c628a26cd3f763b39a2e2441fc766dabf04ed492
        677e40c8b83b06ded8e06b6151f71686baf5f6b5
        
        Regression from commit: c628a26cd3f763b39a2e2441fc766dabf04ed492
        (tdf#90293 switch draw selection to rotate mode)
        
        Change-Id: Ib857673b1f5469d6502736ecad84fe046f8c967e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185031
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-05-08  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [94aa3c3123fe0ff004097c5b05c2fb498d5a45e6]

        tdf#135335 write test for numbering rules font name
        
        Change-Id: I24ac1140ab40c85e7ab2532a8e376563181de450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179960
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-08  Miklos Vajna  <vmiklos@collabora.com>  [77b94fd4906f4a2c0b04e0f89ddbc927ac06b4ec]

        cool#11785 sw lok: take visible area into account when running idle jobs
        
        Load a Writer document that is large enough that loading takes more than
        a second, then spellcheck will be done for the entire document in LOK
        mode, and only then we'll render the first tile.
        
        This was like this since commit 6a490e8834b276359b9ada2ebc95bc86a2dbe759
        (cool#11785 sw lok: only start idling after the idle jobs timer stopped,
        2025-04-29), previously we always did a full spellcheck after load,
        before rendering a first tile.
        
        Fix the problem by reverting the previous fix (that restored a 1 sec
        window in time to rendere first tiles) and instead improve
        SwLayIdle::DoIdleJob(), so in case it wants to only do a job for the
        visible area, then it takes the LOK visible area into account, similar
        to how idle layout does this in SwLayIdle::DoIdleJob().
        
        This probably means m_aFireIdleJobsTimer can be fully removed in the
        future, but that's not yet done here.
        
        Change-Id: I676137daf78cb4fd3be90f474e60213846908fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185044
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [be12bc02844260d27afb49c39c747b7571dca9f1]

        make libeot enabled by default on Linux and macOS
        
        Instead of explicitly enabling the library with --enable-eot,
        there is now --disable-eot to disable using libeot, which is now
        enabled by default, but only on Linux and macOS.
        
        libeot is needed to support reading embedded fonts from PPTX files,
        which use to store the fonts in (compressed or not) EOT format and
        without this library, it is a compatibility problem.
        
        Change-Id: I5ab733fb411cb81137be6834cc970b3034426330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184697
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1c99fa63726caa3e59e76dfb8943f6e81bcdb097]

        Remove obsolete fw declarations from sd/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Icca48a80a17fad6765d0e871ec2a6f12e0317d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183901
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-08  Oliver Specht  <oliver.specht@cib.de>  [90ce84a5dd371c804af19e97896a5e19a3ebf8ca]

        tdf#165564 RTF:Fix export and import of footnotes/endnotes
        
        Removes additional spaces in export and wrong insertions of custom
        footnote/endnote symbols in import.
        
        Change-Id: I2e79e87a5b644b116a87602332e09cde89b64ba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184978
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-05-08  Andras Timar  <andras.timar@collabora.com>  [f9b8a811fe6e57ed69c984788cb90888e00f49a1]

        license: libmspub is MPLv2
        
        https://github.com/LibreOffice/libmspub/commit/f65e2bc75d247044d8def59ced35cf1f63da71f3
        With agreement of all contributors, simplifying licensing to MPL2
        
        Change-Id: I3b6671f82bbef856f40bb8ecfdb34871ef81cd00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185041
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dcd74c1eabfddb4dbc139d853e178c27fe78881f]

        sd: Test OOXML embedded fonts - import, export and round-trip
        
        Import and round-trip tests don't run when libeot is not available.
        Export test doesn't depend on libeot, so it can run.
        
        Change-Id: I71d290b3f93a0ccdb9f8a5bdb9c933464c7059ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184974
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-08  Andras Timar  <andras.timar@collabora.com>  [52974cfa3d2807ad47fba4ec9bce6b3364c820c8]

        license: libcdr is MPLv2
        
        https://github.com/LibreOffice/libcdr/commit/6741805f2e98fab62899ebb6776b93d473a2ec94
        With agreement of all contributors, simplifying licensing to MPL2
        
        Change-Id: Ib575ed536d335ebdba0b5a8331eb9ea36223fdb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185040
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5861fb95950b0ddebc8e59a14fd3997d3bc4a7aa]

        downgrade this SAL_WARN to SAL_INFO
        
        and better describe what's going on
        
        Change-Id: Ic46a004c4459678bab4d27f247066984d67463b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45f2db03385a77f7d3001e65b5d6f0795394b197]

        ofz#416128313 Timeout
        
        Revert "bogus "Endless loop found in a compound glyph" warnings"
        
        its not actually endless, but it is effectively so.
        
        This reverts commit 2cd059c04e15678114ecbbcf1cb50467fa5a3619.
        
        Change-Id: Ifd74e4f9ac53ae3bce4e3dc5228ad9c5ce667dc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-08  Andras Timar  <andras.timar@collabora.com>  [8ff5f175e6f8058057c87d2c25d6d2cc626542bd]

        prefer the last fontFamily name, like fontconfig
        
        There was a report that font names of the "Helvetica Neue LT Pro"
        font family were different, when the fonts were added to the system,
        and when the fonts were added via AddTempDevFont() (remote font config
        in COOL).
        E.g. the font names were expected to be
        - HelveticaNeueLT Pro 45 Lt
        - HelveticaNeueLT Pro 65 Md
        - etc.
        Instead, we always got "Helvetica Neue LT Pro" which did not match, and
        we had a single font name for multiple fonts.
        In these fonts, in the name table there are two platform specific tables,
        macintosh and windows. The fontFamily values are different in these
        tables. In vcl/unx/generic/fontmanager/fontconfig.cxx we reverse the
        order of names. In the case of these fonts the windows table is used.
        With this patch we do the same for the AddTempDevFont() route.
        
        Change-Id: Iaceaabb406dbe63bc76f1066169268de6364b8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184698
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 36de29fe80bfc451d026b986c331afe7ae1129be)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184797
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 379a4ab3a76d0f2080ae69b532004901111391a7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184798
        Tested-by: Jenkins

2025-05-08  Andras Timar  <andras.timar@collabora.com>  [31329d8fa32bab59a46fbf328c112c8f18d4fef0]

        license: zstd
        
        Change-Id: I79f63d667c1de6ea149018ddd99e85af437173b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185024
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-05-08  Attila Szűcs  <attila.szucs@collabora.com>  [1160d5b29a9cdae5ec6126663e888b8e5c76aba4]

        Chart Font sidebar panel
        
        Added font panel for chart text based elements:
        Title, Label , Legends, Axis.
        
        Font sidebar updated based on the selected chart element properties.
        Clicking on the font sidebar will change the properties of the
        selected chart element. (Bold, italic ...)
        
        1 title can have multiple Font settings, the sidebar will display
        a values only if the whole title havbe the same value.
        Setting a value will set it for the whole title at once.
        
        If a Title is edited, then the font panel is disabled now, because
        it need an other implementation, to set textEdit attributes,
        and to update the font panel based on the attributes.
        Added 2 //Todo: where it could (started to) be implemented.
        
        Added 3 new Context to EnumContext:
        - ChartLabel
        - ChartLegend
        - ChartTitle
        This is a bit risky because what was previously only a Chart, now
        may be not a Chart value, but instead 1 of the 3.
        refactored those parts where i seen it could be a problem,
        i hope i not left out something.
        (Axis was already made by someone)
        
        Change-Id: I19eaeb93332a08faae6ed21e7e81a9ea56a4495b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185023
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-08  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [7bb189c3c2c3fb414484e81b9c6bd2f446784cb3]

        tdf#97228 change scrollbarvalue code from include/vcl to vcl/
        
        Change-Id: I76268d39a8792c87a8fcad23dc3f393c4c596486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183192
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f285200efc1318df8d599c8ab3a2534cdaf19ae8]

        apparent use-after-free of ScLOKProxyObjectContact::mpScDrawView
        
         #0  std::vector<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow> >, std::allocator<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow> > > >::size (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:987
         #1  SdrPageView::PageWindowCount (this=<optimized out>) at include/svx/svdpagv.hxx:89
         #2  (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewObjectContact (this=<optimized out>, rTarget=..., rClient=...)
             at sc/source/ui/view/gridwin4.cxx:1467
         #3  0x00007fe8eae62e05 in sdr::contact::ViewObjectContact::getGridOffset (this=this@entry=0x364bdc60)
             at include/svx/sdr/contact/viewobjectcontact.hxx:95
         #4  0x00007fe8eae642fe in sdr::contact::ViewObjectContact::getPrimitive2DSequence (this=this@entry=0x364bdc60, rDisplayInfo=...)
             at svx/source/sdr/contact/viewobjectcontact.cxx:487
         #5  0x00007fe8eae645b1 in sdr::contact::ViewObjectContact::getObjectRange (this=this@entry=0x364bdc60)
             at svx/source/sdr/contact/viewobjectcontact.cxx:209
         #6  0x00007fe8eae64832 in sdr::contact::ViewObjectContact::triggerLazyInvalidate (this=0x364bdc60)
             at svx/source/sdr/contact/viewobjectcontact.cxx:273
         #7  0x00007fe8eae65415 in sdr::contact::ObjectContactOfPageView::Invoke (this=0x7fe8a8103ff0)
             at svx/source/sdr/contact/objectcontactofpageview.cxx:105
         #8  0x00007fe8ebb2b30b in Scheduler::CallbackTaskScheduling () at vcl/source/app/scheduler.cxx:579
         #9  0x00007fe8ebceb21b in SvpSalInstance::StartTimer (nMS=<optimized out>, this=0x2e01000000000000)
        
        Change-Id: Icb71083eb77e528d9025aa7a591892dcdfc2ba89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6f62e2682727a4cf4ed2b3b67a2721e7958a64be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f5426c7fc371d3c2dacef75c96f9e7f94051956
          - tdf#151551 (subsequent) Revisit hyperlink Help pages
            
            + Drop invisible paragraphs
            + refactor XML
            
            Change-Id: Ie5ea2f372a10c6b46a2c7e713bd3955d7f80c5d8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185028
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [380fbf3fd67829282217e917f12899f43dce226f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2545aff7257caee839026723ea517a9e9422e483
          - update templates for master/25.8.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: Ifef141a0180e08e10f4107b5ac8383a0849e4f41
            
2025-05-07  Miklos Vajna  <vmiklos@collabora.com>  [20252bd54ffdcf08a951929bf159437216294330]

        sw redline: extract a PreAppendDeleteRedline() from AppendRedline()
        
        Similar to commit 7a19e55b09dba8a7c04209f6525418a6af485e7a (sw redline:
        extract a PreAppendInsertRedline() from AppendRedline(), 2025-05-06),
        but this is for delete redlines.
        
        Change-Id: I5b4422f15c87300b4831ed33d81d353d0e1227e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185018
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-07  liadam364@gmail.com  <liadam364@gmail.com>  [cc9dd053eefbbd821bbb3da1f8224b481abb1975]

        tdf#164685 Replace SfxItemSetFixed with makeFixedSfxItemSet
        
        Change-Id: Iac40ab819670d238009f9b5801c043d77a921875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184656
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-07  Shantanu Oak  <shantanu.oak@gmail.com>  [bce2373e1d6fd5004e90eb0e6f4835d227880d47]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0d46e01e7f084e76b67fecd1e175726551b979f6
          - Add licenses for Assamese, Kannada, Oriya, Punjabi and Sanskrit
            
            Change-Id: I703418ab8bfeefdfbb75d993652f14215f98abf1
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/184957
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-05-07  Miklos Vajna  <vmiklos@collabora.com>  [2c65437f2dc380783c8d623dca7deebd3a58e0ca]

        cool#11855 sfx2 lok: send command state for ReinstateTrackedChange
        
        The command state was implemented already in commit
        6257cae9e9845ea110b2b7abfad2b2672e966bbb (cool#11357 sw redline
        reinstate: add command state, 2025-03-26), but forgot to expose that on
        the LOK API, which doesn't happen by default.
        
        Change-Id: I11022185498d44df3ee5650ff503687906d61847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185011
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-07  Shantanu Oak  <shantanu.oak@gmail.com>  [1a41ab57295558b93716ed87030d41b5cbda5eff]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 23e01606ab40d8440a97bece8d7d515b302c224a
          - Add license for Tamil
            
            Change-Id: Ic753eafc8e9ec69757a95f2e35f8df81b018f936
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/184956
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-05-07  Julien Nabet  <serval2412@yahoo.fr>  [0804835232b7a678990d2bb15a06aa4767020815]

        sc/source/ui/view/tabview3.cxx: Switch DBG_ASSERT to assert
        
        This fixes Windows/MSVC build errors like the one reported in
        https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_tb_master_win_analyze/1135/console
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sc/source/ui/view/tabview3.cxx(2335):
        error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2313) :
        warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2300, 2302, 2303, 2304, 2309, 2310, 2313
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2359) :
        warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2353, 2354, 2355, 2358, 2359
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sc\source\ui\view\tabview3.cxx(2458) :
        warning C6011: Dereferencing NULL pointer 'pEditView'. : Lines: 2440, 2443, 2444, 2445, 2449, 2452, 2458
        
        Change-Id: I324adb67b207075a420b51726a8211d53257d3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185016
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-07  Jean-Pierre Ledure  <jp@ledure.be>  [0ceb3980c63a74f390fef623887ead7cf24899d3]

        ScriptForge (Calc) ColorizeRange(black)
        
        Typo: the black color was skipped
           >= 0 better than > 0 !!
        Change-Id: I4f52410b60d3f089046084df299ecd8da4cd5e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185014
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-05-07  Karthik Godha  <me@karthikreddy.org>  [63cd2e16e6816ebd8d8aa8588f6a6559e3ff4f7c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 10793e69187eaa6092dad7943dbf78b2e6f556f1
          - tdf#151551 Help Updates for Hyperlink Dialog
            
            Remove 'Frame' references in Help
            
            Change-Id: I96d502f4df9d618791da3b6068b89e9a9e3a3c25
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/185008
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-05-07  Patrick Luby  <guibmacdev@gmail.com>  [3a58d8facfee21616a6a5faa5209be7a56770acf]

        tdf#164337 don't update position data when waiting for a system resize
        
        When entering and exiting LibreOffice's internal full screen mode,
        updating position data causes the "exit full screen" floating
        toolbar to migrate after cycle.
        
        Change-Id: I7b283a4af5460deaa258b9df16bb5577b685a756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185004
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-05-07  Michael Stahl  <michael.stahl@allotropia.de>  [8f8034177b9efcfaa52b3dc0980aec58e75fca5b]

        LOCRDT editeng,sfx2,sw: experimental yrs collab
        
        This can be enabled in configure via --with-yrs=...; see also README.yrs
        
        Currently this is hardcoded to run over a local named pipe.
        
        Everything related to editengine is implemented in EditDoc and made
        accessible via its wrapper classes; everything related to communication
        and accessing sw's comment is implemented in sw::DocumentStateManager.
        
        The acceptor starts in SwView::SwView(), once SwPostItMgr exists.
        
        There is a hack in SfxFrameLoader_Impl::load() to fetch the document
        that the accepting soffice has loaded, and load it in the connecting
        soffice as well.
        
        Change-Id: I89476b5864b70f479bcf15989374c1c65b5da9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175652
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-07  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [0a677d53a6c0eba6f859eaa658d4aecf78bee631]

        LOCRDT sfx2,sw: add special mode EDIT_COMMENT_IN_READONLY_MODE
        
        Create a special mode that allows editing comments and adding new
        comments, while the rest of the document remains in read-only mode.
        
        Since this is a prototype, it is is activated by environment variable.
        
        Change-Id: I6a49000127d2c19804596d84377cc5aeb578cc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173340
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-05-07  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [f678ec9a65c4d7ae2d4dda4599a06fc4b66a27d8]

        CEOO: CellEditOnOverlay
        
        Instead of using EditView's Paint directly to Window I
        changed this now to using the Overlay that is available in
        all applications. This allows to have less repaints of the
        Calc View since the Overlay has a copy of the area it is
        working overlayed.
        It also allows to get away from one of the last areas where
        XOR selection was used since EditView/EditEngine have no
        better way to do this. Selection is now visualized using the
        OS'es choosen SelectionColor, as in all other apps.
        I could also get rid of the flush() of the OverlayManager
        that was needed before and caused some problems (see
        tdf#165621 and associated tasks).
        A failing UnitTest showed that OverlayManagerBuffered needs
        to be aware when no CompleteRedraw was done yet and thus no
        background data exists and refresh makes no sense. This may
        happen when there is no redraw/UI e.g. UnitTests, but still
        an OverlayManager is used and together with a Reschedule
        (many possible reasons) that refresh might be triggered.
        Made access to EditView in OverlayObject no longer dependent
        on ActiveView, that is not always the one with the EditView.
        Now using a combination of ScTabView and ScSplitPos for
        accesses. Asserting now if no EditView -> is mandatory.
        Continuing going through CppunitTest_sc_tiledrendering UTs,
        one more identified.
        Have to re-activate EditViewInvalidate rect forwarding
        since the Invalidate is needed for sc tiled rendering
        tests, but not for sd tiled rendering tests. Added that
        to the impl of EditViewCallbacks using
        LibreOfficeKit::isActive().
        
        Change-Id: I41f5448bfbabfaae4858c7617478771053c2cd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184830
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-05-07  Miklos Vajna  <vmiklos@collabora.com>  [0891df6b21fd95ec7c9614509d92829c0f17c353]

        sw redline: extract a PreAppendInsertRedline() from AppendRedline()
        
        sw::DocumentRedlineManager::AppendRedline() is 1158 lines long, which
        makes it very hard to reason about the body of the function.
        
        3 extractable pieces of it are the blocks which tweak the to-be-inserted
        redline and possibly existing redlines of the redline table based on the
        type of the to-be-inserted redline (insert, delete, format).
        
        Extract the insert redline part into a new function, which alone is 261
        lines long.
        
        To keep this mechanical, pass all variables by non-const ref, then make 2
        selected variables const, since those are only read.
        
        Change-Id: I105524e010bab92afdf54bbba5b33dccdc5900dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184996
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19992b8f238dbfe398b4d7c625905c8ca9ad9845]

        null-deref on doc teardown
        
         #0  std::__uniq_ptr_impl<ScDragData, std::default_delete<ScDragData> >::_M_ptr (this=0xae8)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:191
         #1  std::unique_ptr<ScDragData, std::default_delete<ScDragData> >::get (this=0xae8)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:462
         #2  std::unique_ptr<ScDragData, std::default_delete<ScDragData> >::operator* (this=0xae8)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:445
         #3  ScTabViewShell::GetDragData (this=0x0)
             at sc/source/ui/inc/tabvwsh.hxx:470
         #4  ScModule::GetDragData (this=this@entry=0x4f2dacd0)
             at sc/source/ui/app/scmod.cxx:632
         #5  0x00007e73ef1b3584 in ScDrawTransferObj::~ScDrawTransferObj (this=0x5a10c1c0, __in_chrg=<optimized out>)
             at sc/source/ui/app/drwtrans.cxx:219
         #6  0x00007e73ef1b381d in ScDrawTransferObj::~ScDrawTransferObj (this=0x5a10c1c0, __in_chrg=<optimized out>)
             at sc/source/ui/app/drwtrans.cxx:233
         #7  0x00007e74010d80b9 in com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::~Reference (
             this=0x40a2d160, __in_chrg=<optimized out>)
             at include/com/sun/star/uno/Reference.hxx:114
         #8  vcl::(anonymous namespace)::GenericDragSource::~GenericDragSource (this=0x40a2d110, __in_chrg=<optimized out>,
             __vtt_parm=<optimized out>)
        
        Change-Id: Ibce052c40972576e149d643a4dbbe4f9e89d9a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [de9cf3c3d5ecbc5b4735fb2c6894171d28a6704c]

        Fix typo
        
        Change-Id: Ic5d9899d679295e1af9e034c0b849bf14b9eea21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185001
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-05-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ebbfb7bfd2ce23eceffcd7f41eb8136d38a91dab]

        Fix typo
        
        Change-Id: I301af2c2985a64baa891dedc7d46a6d3c214774e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185000
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Tested-by: Jenkins

2025-05-07  Noel Grandin  <noelgrandin@gmail.com>  [4a4d388e17ae7490ed36f4bb0dd21fbefcdda124]

        simplify CompatibleDC
        
        This class is only really used by the skia case. The non-skia
        (i.e. GDI) case completely bypasses it.
        So we can remove the hierarchy and just make it into a skia focused
        class, simplifying the code structure in the process.
        
        Change-Id: I97f8160126bc5f823c882f3b338c0b2bec2160cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-05-07  Ahmed Khaled  <gostahmedkhaled@gmail.com>  [b710ba48503372ddaf10a17ce7f4f3340bc8adb8]

        tdf#154285 Check upper bound of arguments in SbRtl_FindObject &
        
        SbRtl_FindPropertyObject function
        
        Change-Id: I49b56f0231c5a19871a4a007a0bc21598920b72c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183052
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-05-07  Julien Nabet  <serval2412@yahoo.fr>  [ba521b1d33f629fb448086a3ac052d8a633d6cbf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a05cffc2310a9548fe01682b7efa69ca01d8ea3a
          - Related tdf#166471: replace "Languages" by "General" in Tools > Languages
            
            + indicated DeepL translation as experimental
            
            Change-Id: I0d6d9b14cafaa476d7b283da79e1fe34a1cf3206
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184982
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-07  Simon Chenery  <simon_chenery@yahoo.com>  [8a32f77178e3adc2e661305838064ec9be5f25f6]

        tdf#164954 fix mis-spelled "punktuation" in variable name in TextPortion.hxx
        
        Change-Id: I0d93d4e75652dbe2cca8227f95883e26b25faf76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184968
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-05-06  Justin Luth  <jluth@mail.com>  [b3e1d66d944106bef177a01f7d180ed507c9716c]

        tdf#166474 revert tdf#164907 sw: Calculate row height ... #2
        
        This reverts 25.8 commit e9ed6f1d2cc145e7514bf0a27b8c77f370ceab2d
        (backported to 25.2.2).
        
        It turns out that Oliver's 25.2 commit was correct after all,
        and that "other factors" were coming into play
        that had confused the issue.
        
        I found this by doing an mso-test against my commits
        for tdf#164907 and tdf#165492. I noticed that the improvements
        for DOC files seemed to only be half-improved.
        I hadn't clued in to that while going through DOCX files,
        but afterwards I revisited them and then could see a similar need.
        
        make CppunitTest_sw_layoutwriter4 \
            CPPUNIT_TEST_NAME=TestTdf164907_rowHeightAtLeast
        
        Change-Id: Ib35094583562b8ec36c8583c8fa47c5542b6b1e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184999
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-05-06  Szymon Kłos  <szymon.klos@collabora.com>  [f41d4d008b1c8adc938773e622a9bdd216486de6]

        jsdialog: enable math dialogs
        
        Accessible using sidebar property panel when
        in formula editing. Dialogs are not async yet.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ia2f7792c2f8ec8aeb2d0c5c46acc6af87a6340f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183037
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184995
        Tested-by: Jenkins

2025-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5eec86d6c4ac5efffdf44c546e10726f0e73e509]

        no searchicon (or searchbox) in mobile version of search dialog
        
         #0  0x00007f7a68c0c0e7 in SvxSearchDialog::SetSearchLabel (this=0x377326e0, rStr=...)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:461
         #1  0x00007f7a68c1645c in SvxSearchDialog::SvxSearchDialog(weld::Window*, SfxChildWindow*, SfxBindings&) ()
             at /home/collabora/jenkins/workspace/build_core_co-25.04_for_online_snapshot/include/rtl/ustring.hxx:3957
         #2  0x00007f7a68c16a33 in std::_Construct<SvxSearchDialog, weld::Window*, SvxSearchDialogWrapper*, SfxBindings&> (__p=0x377326e0)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_construct.h:109
        
        I'm not sure whether this dialog even makes sense anymore, but lets not
        crash for now.
        
        Change-Id: I7c8bb0a317a2b058402194234a1daea5bac0b4de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184998
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2025-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fcefdbbd390de622324e2e5e650e1bfb14ec5445]

        apparent null-deref of pPattern seen
        
        Change-Id: Iabab952deb36ab86cce009f4f0b4f82b5d469efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184994
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-06  Miklos Vajna  <vmiklos@collabora.com>  [3948462325e921c5702b2b73b22ff6523b28bc2d]

        cool#11826 desktop lok: inform new view about already painted areas
        
        Open the Calc bugdoc, sheet 1 is visible. Open a 2nd view, still on
        sheet 1. Switch to sheet 2 in view 1, change the call, the sheet 1 in
        view 2 doesn't update.
        
        What happens is that view 1 performs its rendering of sheet 1, then view
        2 is created, so once sheet 2 is changed in view 1, we think that there
        is no need to invalidate view 2, since it was never painted, since
        commit b95a6816555396661d90da02e844d2848b1da3bf (cool#11254 desktop lok:
        avoid invalidations if no tiles are sent, 2025-03-05).
        
        Fix the problem by extending doc_registerCallback() to take the info
        about already painted areas on view creation: now that the view creation
        is handled and the view update is done in
        LibLODocument_Impl::updateViewsForPaintedTile(), the info about already
        painted tiles is again synchronized in all views with the same view
        render state.
        
        Also mention CanonicalViewId in comments, because that's term we use for
        views with the same view render state, so git grep can find both
        locations.
        
        Change-Id: I7698830e1070e0bbe0c186d41ce83c8e22eb7049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184989
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9596472c288d933827cb0724b1d0d8fadaa8e8f2]

        add ZSTD to PERMITTED_BUILD_TARGETS
        
        Change-Id: Ib36ff87be792d1dac763df83b992b734c4e67129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184990
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [404918836d8c2f9fc8459dc37f6c0a757a7dc85f]

        crashtesting: checkGlyphsEqual asserts with harfbuzz-11.2.0
        
        see:
        
        https: //gerrit.libreoffice.org/c/core/+/184761
        https: //github.com/harfbuzz/harfbuzz/pull/5315
        Change-Id: I53442b3b0a917442e6871e60b53273f0bb5b4acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184988
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [659a562512cc48af4a4c1d079cac8e3c45ce6bc2]

        fix extracting zstd under git-bash (dangling symlinks)
        
        git-bash/MSYS doesn't create links by default, so extracting the tarball
        fails with:
        tar: zstd-1.5.7/tests/cli-tests/bin/unzstd: Cannot create symlink to ‘zstd’: No such file or directory
        tar: Exiting with failure status due to previous errors
        
        Unlike in an earlier case with zxing (see
        04585baf973742b0a400b53209391a99ae959d99) those links are only dangling
        temporarily/due to the extraction order, the target it points to is
        created later, but of course same underlying problem/same solution.
        
        Change-Id: I7cca52bb694ceee329cb66407d32c84de8f258a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184987
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [29b930ae634e32f2b922bd11a32add02e6a4d7c4]

        configure.ac: enforce pkgconf-2.4.3.exe on windows/error if not found
        
        protect the users from themselves, too many don't see/respect the
        warning message and picking up pkgconf/pkg-config from cygwin or the
        wsl distro just won't work with the windows-style path needed for
        meson.
        
        Change-Id: Ib3748587c6134f0e90d4772d507d44be5894a69f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184986
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [62e3a541aa5338dfcbcb556e6881056fa5ae38ef]

        configure.ac: fix PathFormat when called with empty value
        
        in wsl-as-helper case this could lead to resulting in an "ECHO is on."
        value. That's completely bogus and also breaks other sanity checks
        that check for an empty variable.
        
        Change-Id: Ifb5c785782a5a7d0f08c8f625725a0d0a4dc241a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184985
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-06  Jean-Pierre Ledure  <jp@ledure.be>  [b7e84bec01e060f805820d812fe16930c52b05f1]

        ScriptForge (Calc) new DefineName() method
        
        Introduction of
        
        1. the DefinedNames property
           Returns the full sorted list of all
           named ranges in the document.
           The names defined in a single sheet
           are qualified with the sheet name.
        
        2. the DefineName() method
             calc.DefineName(definedname, value [,sheetname])
           Define a new name in the worksheet, at global
           or sheet level. If the name existed already,
           it is overwritten without warning.
           The Value of the new name may be a range,
           a scalar value or a formula.
           When a range, the top-left cell is set
           as reference cell.
           After creation, the new name can be used
           in formulaes.
        
        The functions are available both for Basic
        and Python user scripts.
        
        The documentation will need an update.
        
        Change-Id: I184e97b734a57ecba2e8a8eae583050116f40296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184963
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-05-06  Miklos Vajna  <vmiklos@collabora.com>  [8e85d559a68f980d99af4ded6a91b7f0458048b9]

        tdf#166319 sw interdependent redlines: handle accept of insert under format
        
        Open the bugdoc, move the cursor inside "AAA", accept the change, the
        result is that "BBB" still has a change, which is marked as a "format on
        top of insert", while the intent was to accept the insert.
        
        A similar use-case is the same with "delete on top of insert", and that
        one works since commit 52fa7aed48632166e064e6a227e034f0981c4205
        (tdf#157662 SW: redline: accept/reject done for all parts, 2023-10-14).
        
        Fix the problem by extending
        sw::DocumentRedlineManager::AcceptRedlineRange(), so it considers
        format-on-insert the same as delete-on-insert, so all 3 redlines get
        their insert part accepted.
        
        The result is that that the insert-only redlines are deleted and the
        insert-and-format redline is downgraded to be a simple format redline.
        
        Change-Id: I2fdcc906d40c7e94d5446e8912390fe814a5f84c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184983
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-06  Julien Nabet  <serval2412@yahoo.fr>  [23d15485d5aa49cf00fac048b171b3c975b72121]

        tdf#155308: explicitly keep the focus by default for non gtk renderings
        
        Change-Id: I95acbbba1c5322f0b965108d092386ccc6932a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184938
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2cd059c04e15678114ecbbcf1cb50467fa5a3619]

        bogus "Endless loop found in a compound glyph" warnings
        
        probably since:
        
        commit 3a371df3ecce456c9329a493f48600431d2ade69
        CommitDate: Wed Mar 2 12:56:25 2022 +0100
        
            ofz: detect endless loop in font processing
        
        I see this on e.g. export of forum-mso-en4-726282.xlsx to pdf
        and with the original guard disabled there isn't an endless loop
        or recursion. Adjust this to explicitly check what I believe was the
        original issue.
        
        Change-Id: I9d7bd5f7c24e6ae1ae06d61725a5fad45a2326ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184971
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-06  Oliver Specht  <oliver.specht@cib.de>  [7fc7dc679d61f7d5313733005c244c87d25f32fd]

        tdf#50743 improve scrolling with selection
        
        Delay calculation of scrolling timeout for the first 5 calls to
        make it easier to scroll even if you put the mouse cursor too far
        outside of the document window.
        
        Change-Id: If370f87cc439e7e3321078c1334c0a17e6ec6046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184745
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [31108d19e4643cd0fa515a57128fef22d0274ed7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a167a7f257f68ba8fd8617fad4fa003d3c47602
          - tdf#166467 Help for paragraph justification
            
            Change-Id: I1b1f0d3fb2344e655864fb5fcdd00b839c6830b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184970
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b9d61186a5054cfc0b0b1c71683f3ae2d50920cf]

        ofz#415407112 Null-dereference
        
        and
        
        ofz#415525036 Heap-use-after-free
        
        Change-Id: I37349284bb27a8b0a2085e3af99dbdb9ce6983d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184942
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-05  Julien Nabet  <serval2412@yahoo.fr>  [6c271e1bbb6e85ea7fc29cba20e9df193d5b69b5]

        tdf#166407: fix help page for the VALUE function
        
        Change-Id: I44e080cc190f8fa726b9c2f7f35e55c0bcc2b275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184960
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bb04a9783c39ccb10e502dc017035c8b36e85507]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9ab69c9782ee70dc10aa34a3448f274c680f193c
          - Prevent icons to shrink in page.
            
            Change-Id: Ie1b0c6d57f24c01654a51617d44d880a8116ef54
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184947
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [430368f81b0480c01dae419aa89c7e6731b41163]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6e8454443d65a35414b975fa8a3252c19224dafd
          - tdf#137084 Update View menu Help page
            
            Change-Id: Ifb8e3cfa0c467695d136431bdd3f72e0ead61268
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184946
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fb46b475c4374d47dcfc5fa56cb65ca9b3a43eff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b6329f6bcda692c9c0374160e0644fe7fd599c4
          - tdf#137084 Add Page Layout Help page to View menu
            
            Change-Id: I8da50169f80608d478ecbe002e3c5f7bf19241c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184945
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-05-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8ff06494e4edd023b920f8d9f0f679aa5c21f483]

        harfbuzz: use -fvisibility=hidden
        
        Change-Id: I3fa8cd03f91ffdb0463bcb2d67410bac9085a7d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184819
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe2af71719fa335ad232902451ffb8e6e666c7f7]

        nss: upgrade to 3.111
        
        Downloaded https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_111_RTM/src/nss-3.111-with-nspr-4.36.tar.gz
        
        Change-Id: If08f3f13f590a8e17a64f97990a4aced9900dd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184959
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-05  Attila Szűcs  <attila.szucs@collabora.com>  [d5e601edaaccc3e2c15ceff955daf3f0e5e3b0bd]

        LOK: enable DataLabel dialog
        
        It seems to work so it can be enabled
        
        Change-Id: I2c41d911b2fa387160e3888a8b247cb33d1386ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184955
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-05-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [43a97af649fa1214c99f16ce357c94645c9fb085]

        Update git submodules
        
        * Update translations from branch 'master'
          to 953d9f7af3bf3c87cad775f903cd38a4f7cbd63d
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I13e0002a3eb3e131231effea056f05c28e2e5b60
            
2025-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ee2636304ac049f21415c67e92040f7d6c14d35]

        poppler: uggrade to 25.05
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.05.0.tar.xz
        
        Change-Id: Icd2b318cc01bedc5baeb4445a463a136ed6d7c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184953
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-05  Miklos Vajna  <vmiklos@collabora.com>  [c13215d86b5d3a805f5cc0e6721e9babea42ce2c]

        svx: prefix members of SdrMeasureObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie9087a753e871eb684b8dbec2e74a89b7f0f3998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184950
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-05-05  Noel Grandin  <noelgrandin@gmail.com>  [7f33bccce7be3e71dbbad07a7c2c04abd0b1647c]

        improve the bitmap->alpha conversion
        
        we do not need to go via this complex luminance calculation, we
        just want the red channel of the RGB data.
        
        This is also what the skia backends do, ever since
            commit 2fcfbd73768b69ba58607a054e7f851be2942992
            Author: Luboš Luňák <l.lunak@collabora.com>
            Date:   Fri Apr 3 22:50:12 2020 +0200
            no gray conversion needed for VCL alpha hacks
        
        Change-Id: Ie4a7adcc7c488d241ec58e64a130da544c3d39d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184944
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-05-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b87e2d3c25c8e97330f001fc525de90a372492f0]

        sd: rename FontCollector to FontNameCollector, comments, fixes
        
        Rename FotnCollector to FontNameCollector, as it better reflects
        what the class does. Document the class and add some minor
        changes to make the code nicer.
        
        Change-Id: I7e7b08f5e8913bed29b74a240eeaeacbf4984379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184828
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-04  Szymon Kłos  <szymon.klos@collabora.com>  [cb149972d5fc82f3ca8009c3e51931c8d94ee664]

        jsdialogs: use frozen:: set not map
        
        type was redundand
        
        Change-Id: I4bc54407644000f8f605b21f0b5cc6bcdd435747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182824
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184905
        Tested-by: Jenkins

2025-05-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2af77f6288d1a67778d2105662a63babb9901086]

        Fix typo
        
        Change-Id: I26fa17080fb9969eb070a86659585d862ccbe3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184940
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-04  Julien Nabet  <serval2412@yahoo.fr>  [c7ac81a803948c871e33588708e6bee0ead6f7cf]

        Fix logic of fb_shutdown check
        
        From https://www.firebirdsql.org/file/documentation/release_notes/html/en/2_5/rnfb25-apiods-api.html
        "
        Return Values
            A return value of zero means shutdown was successful
            A non-zero value means some errors occurred during the shutdown. Details will be written to firebird.log.
        "
        
        Change-Id: I1139e1abdd1f07f0fad23f24a177aa5439546b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184939
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-04  Laurent Balland  <laurent.balland@mailo.fr>  [2ae6a6b7e4f81254b0b9c94310aa4e0318f3baae]

        tdf#163816 Keep ratio of OLE object (chart...)
        
        When an OLE object (for instance a chart in Calc) is edited,
        resizing should behave like in non-edited mode:
        handles in corner resize proportionaly (Widht/Height ratio is preserved)
        whereas handles on edges modify Width/Height ratio
        Press Shift key to toggle behavior
        When draging object with border,
        press shift key to move object only horizontal/vertical/45°
        
        Change-Id: I66df55d3170a094bbd63eff9f6b93915cc57e060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177588
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2025-05-04  Jean-Pierre Ledure  <jp@ledure.be>  [11d8753e0351ffaddb862c288f4b200e6f8ff925]

        ScriptForge (UI) extend scope of CreateBaseDocument
        
        The
            ui.CreateBaseDocument()
        method accepted so far to create Base documents
        either embedding HSQLDB or FIREBIRD databases
        or linked to a Cals spreadsheet.
        
        It is now extended to make the new Base document
        finding its datasource in an external Firebird
        database file.
        
        The previous signature
            ui.CreateBaseDocument(FileName, EmbeddedDatabase,
                CalcFileName)
        is replaced by
            ui.CreateBaseDocument(FileName, EmbeddedDatabase,
                DataFileName, CalcFileName)
        => The CalcFileName argument is deprecated. When present,
           it is copied to DataFileName.
        The EmbeddedDatabase argument may take next values:
            HSQLDB (default), FIREBIRD, FIREBIRD_EXTERNAL or CALC.
        
        The change is valid for both Basic and Python scripts.
        The documentation should be upgraded.
        
        Change-Id: I5daf418f50739baca6be899eb1444d1b99cf89aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184935
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-05-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bd1ce21e07fb085b7d1545a0c4ce7b606714642f]

        ofz#415088962 Integer-overflow
        
        Change-Id: I6e41db206a9b2eaecb9fb791f05c7d01daa7f594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184936
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-03  Patrick Luby  <guibmacdev@gmail.com>  [7346724e33105a0523cf38ba6287a19939596bc2]

        tdf#163945 Decrease maximum Skia/Metal flushing rate and don't schedule flush
        
        This change reduces the maximum Skia/Metal flushing rate from 50 flushes
        per second to 40 flushes per second.
        
        Also, do not schedule the Skia timer to run as it appears that it might
        be part of the cause for the reappearance of tdf#163945 on some machines.
        
        Change-Id: I85d1e4a4916f2e612e5e5532fc01f05ae00e09b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184919
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-05-03  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f905e15bd5cce3440f9ab8064f1233b1cae4d82f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f5efb304cd9ed27b35dacac846781061edc1b16
          - Take dark mode into account with selection pseudo-element
            
            Change-Id: Id35bb20cfd939de0dc11c3cead4a43ec0ee86888
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184906
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-05-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [25bada14b95c663a289f3f5b6b61c5fc919d468f]

        Fix typo
        
        Change-Id: Ibe901d946c9bf9f2f409c654325e2bfbc954b334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184930
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [86e8abc2b171f56511787eda28f1604a0ee6d000]

        tdf#165858 pdf: use the correct widget to dissble the forms options
        
        "formsframe" widget was a grid that previously contained the forms
        options only, but after restructuring the "forms_frame" is actually
        a frame that contains all the forms option and checkbox to enable
        writing of the forms. A different "forms_options_grid" is used to
        contain only the form options.
        
        This was changed in the .ui file, but it was not changed correctly
        in the code (only "formsframe" was renamed to "forms_frame").
        
        The change fixes the code to use "forms_options_grid" instead of
        "forms_frame" and renames the variables so now the correct widget
        is used.
        
        Change-Id: I15f967575d1a53ab9545e68867c48abefbc6b0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184910
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-03  Michael Weghorn  <m.weghorn@posteo.de>  [30e5e6c7514d814a737aabb63f2a6198be5ec991]

        tdf#130857 qt weld: Support "User Interface" dlg tabpage
        
        Add the .ui file added in
        
            commit ec04856ff1dfe0c5c9462263f2d261c30a336d7c
            Date:   Mon Apr 28 14:15:08 2025 +0200
        
                Turn UI picker dialog into a SfxTabDialog
        
        to the list of supported .ui files, so that the
        "View" -> "User Interface" dialog shows its
        content again with the qt6 VCL plugin when using
        SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: I202e228d2373acb494bf8c28bf2abe16bc2b6062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184911
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [3ab82581e5a5abc03c7ff06eac76a0b2fa0c9c34]

        avmedia: Move context retrieval a level down
        
        Call comphelper::getProcessComponentContext directly
        in MediaWindowImpl::createPlayer instead of passing
        the XComponentContext as a param.
        
        Change-Id: If349dfe1b5a8216ba971233249bb135c1a7d2019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184914
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [821fcbfe97a1b5b1c9fc886c226dfc2bad8d4336]

        avmedia: Use constexpr OUString
        
        Change-Id: Iaed5bd5c6e3ef75d7b1a210a10a9085648d90676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184913
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [08533ca4e2526644b803c40c0c3d3c96f43762af]

        tdf#166055 avmedia qt: Use GStreamer frame grabber by default
        
        As described in tdf#166055, QtFrameGrabber currently
        still causes issues (freezes or crashes).
        
        The QtMultimedia API does not provide a simple
        way to synchronously retrieve a video frame, so
        the current approach is to connect to the
        QVideoSink::videoFrameChanged signal and start
        playing the video until the first frame arrives.
        
        There are various QtMultimedia plugins/backends
        (at least GStreamer and ffmpeg for Linux). Some
        use multiple threads internally. Some logic
        needs to be run in the main thread however, so
        it's not possible to move things to a separate
        thread/event loop to decouple it from the main
        thread.
        As a consequence, there is a need to trigger
        event processing while waiting for the frame,
        as QVideoSink::videoFrameChanged would otherwise
        never be called.
        
        Triggering event processing can have bad side-effects
        however, as seen in tdf#166055, e.g. leading to
        endless recursion or crashes when processing LO events.
        
        See also
        
            commit 697405b533a8ae5b6a8f5bd184b9344a96f71c69
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Apr 9 09:42:45 2025 +0200
        
                tdf#166055 qt avmedia: Provide media/player size right away
        
        for more background and some thoughts.
        
        For now, avoid the problem by using
        the GStreamer based frame grabber even with
        QtPlayer by default.
        
        This means that the QtMultimedia
        framework is still used for video playback with the
        qt6 VCL plugin, where LO's GStreamer implementation
        doesn't work properly, see
        
            commit 441d8ed9be0e7f831b455a69b8688dcb79a8bc00
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 20 16:25:09 2024 +0200
        
                tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback
        
        . However, in order to preview images (that are e.g. shown
        in Impress when not in presentation mode) the LO GStreamer
        backend is used now.
        (That works fine, no UI interaction is needed
        for that.)
        
        Adjust QtPlayer::createFrameGrabber accordingly
        to return the LO default platform player/frame grabber
        implementation (which is the GStreamer one on Linux), see also
        MediaWindowImpl::createPlayer. Use the service to
        avoid having to link GStreamer libraries.
        
        However, allow to force the use of QtFrameGrabber
        by setting environment variable
        SAL_VCL_QT_USE_QT_FRAME_GRABBER.
        
        Change-Id: Ibe5c42adf6e8f699f33e5f089bd2f6076c3de4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184912
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [d72156ff0831c7ce240bb1fe1b542db5c54d1f37]

        tdf#166436: check field stack is not empty
        
        like other places do
        
        Change-Id: I6fcb2bd849b11b0f17f1b19193a24c8e1f4ee660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184909
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [fbca764f46b39a21a3a1d68276fba08d0a0e54a6]

        tdf#130857 qt weld: Make sure .ui file is processed in main thread
        
        QWidgets may only be created in the GUI/main thread, and
        that is what happens when processing the .ui file.
        
        Therefore, ensure this is always run in the main thread.
        
        One case observed where this was not the case was the crash
        recovery dialog getting created after Impress had crashed
        due to an assert being hit somewhere in the QtMultimedia
        library in a non-main thread.
        
        Backtrace:
        
            (gdb) bt
            #0  __GI_abort () at ./stdlib/abort.c:91
            #1  0x00007fe93850641d in qAbort () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:46
            #2  0x00007fe93854dd9a in qt_maybe_message_fatal<QString&> (msgType=QtFatalMsg, context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2140
            #3  0x00007fe938547004 in qt_message (msgType=QtFatalMsg, context=..., msg=0x7fe938ca8ed3 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fe8e27d6f30)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:412
            #4  0x00007fe93854934d in QMessageLogger::fatal (this=0x7fe8e27d70d0, msg=0x7fe938ca8ed3 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:901
            #5  0x00007fe9385064d3 in qt_assert_x
                (where=0x7fe936e5576a "QWidget", what=0x7fe936e5580b "Widgets must be created in the GUI thread.", file=0x7fe936e556b4 "/home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp", line=945)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:115
            #6  0x00007fe93668477d in QWidgetPrivate::init (this=0x7fe88c19c3f0, parentWidget=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:944
            #7  0x00007fe9366845e6 in QWidget::QWidget (this=0x7fe88c003370, dd=..., parent=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:862
            #8  0x00007fe936a92cb5 in QDialog::QDialog (this=0x7fe88c003370, parent=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:375
            #9  0x00007fe93955ed73 in QtBuilder::makeObject (this=0x7fe88c0049f0, pParent=0x0, sName=u"GtkDialog", sType="", sID="DocRecoverySaveDialog", rMap=std::__debug::map with 7 elements = {...}) at vcl/qt6/../qt5/QtBuilder.cxx:213
            #10 0x00007fe93955e1a4 in QtBuilder::insertObject (this=0x7fe88c0049f0, pParent=0x0, rClass="GtkDialog", sType="", rID="DocRecoverySaveDialog", rProps=std::__debug::map with 7 elements = {...}) at vcl/qt6/../qt5/QtBuilder.cxx:109
            #11 0x00007fe9395742e5 in WidgetBuilder<QObject, QObject*, QMenu, QMenu*>::handleObject (this=0x7fe88c0049f0, pParent=0x0, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:234
            #12 0x00007fe939572c16 in WidgetBuilder<QObject, QObject*, QMenu, QMenu*>::handleChild (this=0x7fe88c0049f0, pParent=0x0, pAtkProps=0x0, reader=..., bToolbarItem=false) at include/vcl/widgetbuilder.hxx:131
            #13 0x00007fe939566468 in WidgetBuilder<QObject, QObject*, QMenu, QMenu*>::processUIFile (this=0x7fe88c0049f0, pParent=0x0) at include/vcl/widgetbuilder.hxx:70
            #14 0x00007fe93955da70 in QtBuilder::QtBuilder (this=0x7fe88c0049f0, pParent=0x0, sUIRoot=u"file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", rUIFile="svx/ui/docrecoverysavedialog.ui")
                at vcl/qt6/../qt5/QtBuilder.cxx:66
            #15 0x00007fe9396117a7 in std::make_unique<QtBuilder, QWidget*&, std::basic_string_view<char16_t, std::char_traits<char16_t> >&, rtl::OUString const&>
                (__args=@0x7fe8e27d91a0: 0x0, __args=u"file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", __args="svx/ui/docrecoverysavedialog.ui")
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:1077
            #16 0x00007fe93960ed69 in QtInstanceBuilder::QtInstanceBuilder
                (this=0x7fe88c0db2d0, pParent=0x0, sUIRoot=u"file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", rUIFile="svx/ui/docrecoverysavedialog.ui") at vcl/qt6/../qt5/QtInstanceBuilder.cxx:52
            #17 0x00007fe9395f55a8 in std::make_unique<QtInstanceBuilder, QWidget*&, rtl::OUString const&, rtl::OUString const&>
                (__args=@0x7fe8e27d92a0: 0x0, __args="file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", __args="svx/ui/docrecoverysavedialog.ui")
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:1077
            #18 0x00007fe9395ef490 in QtInstance::CreateBuilder (this=0x56149a5271a0, pParent=0x0, rUIRoot="file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", rUIFile="svx/ui/docrecoverysavedialog.ui")
                at vcl/qt6/../qt5/QtInstance.cxx:916
            #19 0x00007fe9395ef52c in non-virtual thunk to QtInstance::CreateBuilder(weld::Widget*, rtl::OUString const&, rtl::OUString const&) () at /home/michi/development/git/libreoffice/instdir/program/libvclplug_qt6lo.so
            #20 0x00007fe94160079f in Application::CreateBuilder (pParent=0x0, rUIFile="svx/ui/docrecoverysavedialog.ui", bMobile=false, nLOKWindowId=0) at /home/michi/development/git/libreoffice/vcl/source/window/builder.cxx:204
            #21 0x00007fe94208901d in weld::GenericDialogController::GenericDialogController (this=0x7fe88c0095a0, pParent=0x0, rUIFile="svx/ui/docrecoverysavedialog.ui", rDialogId="DocRecoverySaveDialog", bMobile=false)
                at /home/michi/development/git/libreoffice/vcl/source/app/weldutils.cxx:53
            #22 0x00007fe945a1f83d in svx::DocRecovery::SaveDialog::SaveDialog (this=0x7fe88c0095a0, pParent=0x0, pCore=0x7fe88c0dafe0) at /home/michi/development/git/libreoffice/svx/source/dialog/docrecovery.cxx:574
            #23 0x00007fe945a35e25 in (anonymous namespace)::RecoveryUI::impl_doEmergencySave (this=0x7fe88c0d4010) at /home/michi/development/git/libreoffice/svx/source/unodraw/recoveryui.cxx:254
            #24 0x00007fe945a35b03 in (anonymous namespace)::RecoveryUI::dispatchWithReturnValue (this=0x7fe88c0d4010, aURL=...) at /home/michi/development/git/libreoffice/svx/source/unodraw/recoveryui.cxx:148
            #25 0x00007fe945a35ca4 in non-virtual thunk to (anonymous namespace)::RecoveryUI::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libsvxlo.so
            #26 0x00007fe94af24c4f in desktop::(anonymous namespace)::impl_callRecoveryUI (bEmergencySave=true, bExistsRecoveryData=false) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1057
            #27 0x00007fe94af248a1 in desktop::Desktop::Exception (this=0x7ffc5c0f5540, nCategory=ExceptionCategory::System) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1212
            #28 0x00007fe9420667fa in VCLExceptionSignal_impl (pInfo=0x7fe8e27d9d88) at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:178
            #29 0x00007fe94b2484aa in callSignalHandler (pInfo=0x7fe8e27d9d88) at /home/michi/development/git/libreoffice/sal/osl/all/signalshared.cxx:47
            #30 0x00007fe94b2dc3d3 in (anonymous namespace)::signalHandlerFunction (signal=6, info=0x7fe8e27d9fb0, context=0x7fe8e27d9e80) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:423
            #31 0x00007fe94ac49df0 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
            #32 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #33 0x00007fe94ac9e9ff in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:89
            #34 0x00007fe94ac49cc2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #35 0x00007fe94ac324ac in __GI_abort () at ./stdlib/abort.c:73
            #36 0x00007fe93850641d in qAbort () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:46
            #37 0x00007fe93854dd9a in qt_maybe_message_fatal<QString&> (msgType=QtFatalMsg, context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2140
            #38 0x00007fe938547004 in qt_message (msgType=QtFatalMsg, context=..., msg=0x7fe938ca8eb2 "ASSERT: \"%s\" in file %s, line %d", ap=0x7fe8e27dae30) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:412
            #39 0x00007fe93854934d in QMessageLogger::fatal (this=0x7fe8e27dafd8, msg=0x7fe938ca8eb2 "ASSERT: \"%s\" in file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:901
            #40 0x00007fe93850646b in qt_assert (assertion=0x7fe935abd3d7 "subject == PW_ID_CORE", file=0x7fe935abcca8 "/home/michi/development/git/qt5/qtmultimedia/src/multimedia/pipewire/qpipewire_audiocontextmanager.cpp", line=267)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:106
            #41 0x00007fe9359e3b3c in QtPipeWire::QAudioContextManager::startListenDefaultMetadata(QtPipeWire::StrongIdType<unsigned int, QtPipeWire::ObjectIdTag>, unsigned int)::$_0::operator()(void*, unsigned int, char const*, char const*, char const*) const
                (this=0x7fe8e27db0c7, data=0x7fe935c05d10 <QGlobalStatic<QtGlobalStatic::Holder<QtPipeWire::(anonymous namespace)::Q_QGS_s_audioContextInstance> >::instance()::holder>, subject=113, key=0x5614a39ce960 "target.node", type=0x5614a39ce978 "Spa:Id", value=0x5614a39ce988 "-1") at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/pipewire/qpipewire_audiocontextmanager.cpp:267
            #42 0x00007fe9359e2ce8 in QtPipeWire::QAudioContextManager::startListenDefaultMetadata(QtPipeWire::StrongIdType<unsigned int, QtPipeWire::ObjectIdTag>, unsigned int)::$_0::__invoke(void*, unsigned int, char const*, char const*, char const*)
                (data=0x7fe935c05d10 <QGlobalStatic<QtGlobalStatic::Holder<QtPipeWire::(anonymous namespace)::Q_QGS_s_audioContextInstance> >::instance()::holder>, subject=113, key=0x5614a39ce960 "target.node", type=0x5614a39ce978 "Spa:Id", value=0x5614a39ce988 "-1") at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/pipewire/qpipewire_audiocontextmanager.cpp:265
            #43 0x00007fe8f1574054 in ??? () at /usr/lib/x86_64-linux-gnu/pipewire-0.3/libpipewire-module-metadata.so
            #44 0x00007fe8f0d61671 in ??? () at /usr/lib/x86_64-linux-gnu/pipewire-0.3/libpipewire-module-protocol-native.so
            #45 0x00007fe8f0d61e08 in ??? () at /usr/lib/x86_64-linux-gnu/pipewire-0.3/libpipewire-module-protocol-native.so
            #46 0x00007fe8f2dd5c46 in ??? () at /usr/lib/x86_64-linux-gnu/spa-0.2/support/libspa-support.so
            #47 0x00007fe935347b55 in ??? () at /lib/x86_64-linux-gnu/libpipewire-0.3.so.0
            #48 0x00007fe94ac9cb7b in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:448
            #49 0x00007fe94ad1a7b8 in __GI___clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78
        
        Change-Id: I5f9f1f82d8ca76a50872d0b81b67059f78d413fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184896
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [63467889b0ddea39ca305a2ab2396e99359b35d0]

        Revert "tdf#130857 qt weld: Assert widgets exist, drop fallback"
        
        It turns out that there are use cases where IDs are
        used for which no widget exists in the .ui file.
        
        At leasts the SmCategoryDesc ctor doesn't use hard-coded
        widget IDs but generates them dynamically and includes
        `nCategoryIdx`, so the resulting ID may or may not
        have an associated widget, and the null case is handled there.
        
        This reverts commit 960703ce7fe55af062bd33e6bc9f6f33bfd193e8.
        
        Change-Id: I760f1ac82c5e4e22409fe0ab99309e6b23c37aa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184895
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [a90a55180178488876abab89de3c89e87f846109]

        checkExternalLibraries: map zstd and simplify
        
        Change-Id: I899176a4c3813b6c276b4edef22bcaeda35ee681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184904
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a0403b6eb25a99f6225e0f77f4b14d78f4045c9e]

        tdf#47479: Do not modify range of sheet / column / row in notifications
        
        Change-Id: I2c5afa5397e3a98806908a2f73f8d654e83fb890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184889
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-02  Szymon Kłos  <szymon.klos@collabora.com>  [fe7a34d8a6acaeaaf8d5243fd9ddb169a7b69367]

        jsdialogs: check if ignored .ui first
        
        avoid all the checks if we know we want to ignore that .ui file
        
        Change-Id: I5f7603a5f0d7902b4cfe76c9f87ece24e24e497e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182823
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184902
        Tested-by: Jenkins

2025-05-02  Szymon Kłos  <szymon.klos@collabora.com>  [3d888185cf49c13ee7eee62abb56157281965963]

        lok: switch dark mode faster
        
        We don't need to load the color scheme every time
        we switch the dark mode on/off. Let's load it once
        then reuse.
        
        - preloading
        - reuse instance
        
        Change-Id: I72478327124dad7142af826232f483e4033764e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182515
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184901
        Tested-by: Jenkins

2025-05-02  Jean-Pierre Ledure  <jp@ledure.be>  [1456ab8c9cfeb5d35a75d8a9107a35d135bf1305]

        ScriptForge (UnitTest) set return code
        
        Correct the code returned at the end
        of a test suite.
        A test suite is run by
            RunTest()
        and shoule return a positive return code
        when an assertion fails. It did not.
        
        No impact on documentation.
        
        Change-Id: Ib581515f4bd8c57d9373b67e2fffbc8850394b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184900
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-05-02  Justin Luth  <jluth@mail.com>  [f84369daa125717f3c87fe34abb0b91c6f6ba3d5]

        tdf#164033 tdf#161741 tdf#161705 pgnum wizard: avoid undo crash (sledgehammer)
        
        I have zero knowledge of the many intricate pitfalls of undo/redo,
        so there is no way I could create a "proper" fix.
        
        LO 7.6 introduced the page number wizard which has more prominently
        exposed existing ways to make undo/redo of page style changes
        to crash. So treat this as pre-LO 7.2
        and simply erase the undo stack after running the wizard.
        ------------------------------------------------------------------
        The ability to undo/redo the "Header/footer change" started in
        bibisect-linux-64-7.2 commit 910d9a081daf11ea53235d227c3dc9623942a824
        commit 8d8486f43c1a8a51157bfc3e0b87090b05a9229e
        Author: Daniel Arato (NISZ) on Mon Feb 22 16:59:38 2021 +0100
            tdf#46561 sw: fix lost undo stack setting header/footer
        
        -   if( bHeaderFooterChanged )
        -       GetIDocumentUndoRedo().DelAllUndoObj();
        
        Change-Id: I00c529784bfd7b2cd1230474c05eea8516e6c1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170771
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c2193f842a26f576700cd58c076839f112d5355]

        ScInsertCellDlg: pass ScViewData from caller
        
        Change-Id: Ic059f4c964f761f9d1b2c0734f8b6908501fd5d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184898
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a7b6b20bebd0bf122736b94ae32b7981758d4c0b]

        don't use with-system-zstd (yet)
        
        Change-Id: Ib18f121eb69c8c7be0c938a54510a5c6f8a339f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3ff9cf60efa2fc6d29c5581bd895f71daf55611]

        ScConflictsDlg: pass ScViewData by ref
        
        and other related changes
        
        Change-Id: I13f8c81e5715d9adea05e4d89443ec6ef8faf24a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184899
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [56124622936ee42dcd852a9d711af1a1e2e77dfa]

        Resolves: tdf#166417 grow TreeView when dialog grows.
        
        these can get tricky in the gen-case when the TreeView has a header.
        Its easier to deal with when the parent is a GtkBox.
        
        Change-Id: I962437dab114bc18554ad065426f6f1f268137f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-02  Heiko Tietze  <tietze.heiko@gmail.com>  [078337562dc8c6a92def7760c54960a06d6a81cf]

        Resolves tdf#166347 - Start center recent/template button toggle
        
        Change-Id: I897c282a8c4fba2731a625637eb7bbe77473bebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184887
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [96eb56161362603026eb17e5fa8d9d68d5a1a7f8]

        cid#1646782 Negative array index read
        
        Change-Id: I0c8b1ab1fdc01999822042c73f37268a77b1b6b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [ccf40aa486d51623698683086f2130644d7ccee3]

        libpng: upgrade to 1.6.48
        
        Downloaded from
        https://sourceforge.net/projects/libpng/files/libpng16/1.6.48/libpng-1.6.48.tar.xz/download
        
        Change-Id: I37cef8c885807eb26e45f567256faebd05816dc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184891
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [32c7035824e50429c4ffeb43d0bdf306ba8874e9]

        tdf#130857 qt weld a11y: Add custom a11y to registry
        
        Insert the mapping between XAccessible and the associated
        QLabel to QtAccessibleRegistry for the case where a custom
        a11y object is used as implemented in previous commit
        
            Change-Id: I4686f1d6c5862fea38af626facff785ed5e9f9dd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 1 23:21:55 2025 +0200
        
                tdf#130857 qt weld a11y: Support custom DrawingArea a11y
        
        This makes sure that the existing QtAccessibleWidget
        is used for the XAccessible later, instead of creating
        another one/a QtXAccessible later.
        
        See also
        
            commit 61c0c1286dbd9015809ba8ee5ee687b612438bef
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Aug 24 13:47:25 2022 +0200
        
                qt a11y: Remember associated QObject also for non-QtXAcccessible case
        
        for a similar change just a few lines further down, which
        also has more details.
        
        This commit makes the paragraph child in the spelling dialog
        report the edit view/drawing area accessible as its parent on the
        a11y layer as it should, and thus also makes Accerciser
        highlight the correct area on screen when clicking on them,
        while that was not the case previously (at least on Wayland)
        with SAL_VCL_QT_USE_WELDED_WIDGETS=1 in a WIP branch adding
        support for using native Qt widgets for the spelling dialog.
        
        Change-Id: I57a8494152b867a999aecff0e94c2e7b4373881e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184882
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [89be90b92f15e318e1ecb3663cde80e5caa839c1]

        tdf#130857 qt weld a11y: Implement getting location on screen
        
        This makes Accerciser highlight the correct area
        on screen when selecting the
        "Not in dictionary" edit view  in a WIP branch adding support
        for the spelling dialog using native Qt widgets with the
        qt6 VCL plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        (The method gets called from WeldEditView::getLocationOnScreen.)
        
        Change-Id: Ie310435ec87339629470c47c9ef5f310a291d3a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184881
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [7782a0d87bfdfea8af1c24b90939b0e75edce641]

        tdf#130857 qt weld a11y: Drop 2 DrawingArea a11y asserts
        
        No longer assert in QtInstanceDrawingArea::get_accessible_parent
        and QtInstanceDrawingArea::get_accessible_relation_set, but just
        let them return nullptr.
        
        With
        
            Change-Id: I4686f1d6c5862fea38af626facff785ed5e9f9dd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 1 23:21:55 2025 +0200
        
                tdf#130857 qt weld a11y: Support custom DrawingArea a11y
        
        in place, those now get called for the
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 case in
        a WIP branch adding support for the spelling
        dialog when the Orca screen reader is running,
        because QtAccessibleWidget::parent and
        QtAccessibleWidget::relations call them.
        
        However, QtAccessibleWidget::parent already
        falls back to the native QWidget/QObject
        hierarchy to find the accessible parent, which
        works for this case, too. (Adjust the comment
        a bit to mention the new scenario of native weld::Widget
        instances as well.)
        
        Relations should generally also be handled directly
        by QtAccessibleWidget, not the underlying XAccessible,
        as they are set in the .ui file which is evaluated
        by QtBuilder. If something is still missing there,
        then the logic still needs to be refined elsewhere.
        Come back to this later as needed.
        
        gtk3's GtkInstanceDrawingArea implementations also
        don't return anything particular here, but in fact
        simply trigger an assert when called, mentioning
        that this shouldn't be reached for the implementation
        there as everything is handled natively on the ATK
        layer.
        
        Change-Id: I6c9fa487614b5cb984888842e6c137801ab97b8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184880
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [78c628cd2fcfdcf8699167c136551db6183a1f97]

        tdf#130857 qt weld a11y: Support custom DrawingArea a11y
        
        Add support for using a custom accessibility
        interface/implementation for weld::DrawingLayer
        using native Qt widgets with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1:
        
        Handle the a11yref/uno::Reference<XAccessbible> param
        passed to QtInstanceBuilder::weld_drawing_area by
        implementing logic to set a custom QAccessibleInterface
        implementation for the native QLabel that is used
        in the QtInstanceDrawingArea:
        
        Delete the QtAccessibleInterface currently set for
        the label and create a QtAccessibleWidget that basically
        wraps the XAccessible and is already used for non-weld
        objects, too. QtAccessibleWidget::customFactory is already
        registered as an a11y factory for Qt, so extend it to
        evaluate a QObject property to transport the custom
        accessible interface implmentation into that method
        from QtAccessibleWidget::setCustomAccessible.
        
        This, together with some further changes in a WIP
        branch implementing support for the spelling dialog
        result in the "Not in dictionary" edit view becoming
        accessible, i.e. expose its paragraph children on
        the a11y layer, support the AT-SPI Text interface
        and emit caret-changed events when moving the cursor
        within the edit view.
        
        Change-Id: I4686f1d6c5862fea38af626facff785ed5e9f9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184879
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [f0a60807d2cccd3e443635db91140fe326226495]

        qt: Switch QtAccessibleWidget::m_pObject to reference
        
        ... and rename to `m_rObject`. This makes clear it's
        always non-null, and allows to drop a corresponding
        assert.
        
        Change-Id: Iae67e9371a1bce397e52758314d229498449a5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184878
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [610c0285a6fd2c04b72d520eedc4eb2a6872e2f9]

        qt: Move null check to start of QtAccessibleWidget::customFactory
        
        Check once at the beginning and return early in case of a null
        object instead of checking in different code paths.
        
        Also rename the param to `pObject` to match the naming
        convention for pointers.
        
        Change-Id: Ie1cf01e3292c7eb9ae463d956b9380bebc3b0f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184877
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [e5e4873576fa89f11e19ee568e3969fc3a4a03a7]

        tdf#130857 qt: Let QtAccessibleWidget subclass QObject
        
        This will allow to pass it in a QVariant, which will
        be used to support custom accessible implementations
        for QtInstanceDrawingArea in
        QtInstanceBuilder::weld_drawing_area in an upcoming
        commit.
        
        At least the Qt 5 moc does not process Qt version
        checks like
        
            #if QT_VERSION >= QT_VERSION_CHECK(6, 5, 0)
        
        which would result in failures like
        
            In file included from /home/michi/development/git/libreoffice/vcl/qt5/QtAccessibleWidget.cxx:21:
            /home/michi/development/git/libreoffice/workdir/CustomTarget/vcl/qt5/QtAccessibleWidget.moc:91:29: error: unknown type name 'QAccessibleAttributesInterface'; did you mean 'QAccessibleActionInterface'?
               91 |         return static_cast< QAccessibleAttributesInterface*>(this);
                  |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                  |                             QAccessibleActionInterface
            /usr/include/x86_64-linux-gnu/qt5/QtGui/qaccessible.h:627:20: note: 'QAccessibleActionInterface' declared here
              627 | class Q_GUI_EXPORT QAccessibleActionInterface
                  |                    ^
            In file included from /home/michi/development/git/libreoffice/vcl/qt5/QtAccessibleWidget.cxx:21:
            /home/michi/development/git/libreoffice/workdir/CustomTarget/vcl/qt5/QtAccessibleWidget.moc:97:29: error: unknown type name 'QAccessibleSelectionInterface'; did you mean 'QAccessibleActionInterface'?
               97 |         return static_cast< QAccessibleSelectionInterface*>(this);
                  |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                  |                             QAccessibleActionInterface
            /usr/include/x86_64-linux-gnu/qt5/QtGui/qaccessible.h:627:20: note: 'QAccessibleActionInterface' declared here
              627 | class Q_GUI_EXPORT QAccessibleActionInterface
                  |                    ^
            2 errors generated.
        
        Explicitly exclude the Qt >= 6.x specific
        code in the header from the moc run by making it
        conditional on
        
            #ifndef Q_MOC_RUN
        
        to make that work.
        
        Change-Id: I1ea3c37d0041dac89d632970d810ae951ff4afbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184876
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-02  Michael Weghorn  <m.weghorn@posteo.de>  [960703ce7fe55af062bd33e6bc9f6f33bfd193e8]

        tdf#130857 qt weld: Assert widgets exist, drop fallback
        
        In QtInstanceBuilder::weld_*, add asserts that the
        widgets for the passed ID exist and drop the fallback
        of returning an empty std::unique_ptr if they don't.
        
        Dialog implementations generally don't handle null return
        values anyway, and if these methods get called with an
        ID for which there isn't a corresponding widget, this needs
        to be investigated, so rather fail here early than
        due to a null dereference later.
        
        Change-Id: I6d018a4fe8b9ad19a01b7072281d5eb215ab8ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184875
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a15a4f5b77aad416019548e71d7785636d0a7b8a]

        use same type as getNumberOfRecords
        
        Change-Id: I85d8f547cfc687ba343f8e16cb2c7aed731ffce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184874
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-02  Juraj Šarinay  <juraj@sarinay.com>  [4b83cd1e9479fd3292d2630593a2fb051016482a]

        tdf#121133 Emit /DR within AcroForm as a direct object
        
        An indirect /DR within AcroForm causes Acrobat Reader to warn
        of modification of documents signed on export. Emit /DR as a direct
        object referring to the \Font directory.
        
        Change-Id: I82aedf439c8edfceb938c86ba16a7ab4cda90bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181364
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-05-02  Aron Budea  <aron.budea@collabora.com>  [fe5919277e69d38b2d9970fca38e84caddfce5f5]

        cool#11475 lok: sc: correctly export frozen/split pane information
        
        As 7b4802070ac6fb930255536bf3ed2c52428b4181 noted,
        online only supports freeze panes, but preserves splits when saving.
        
        However, files could also end up with mixed frozen/split panes.
        In addition, even a single split was treated like two, with
        the other split being at the first row/column, which was incorrect.
        
        Change-Id: I974690b8877ad6d4eca1e046c3c352359a199706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184421
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184854
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [9f308ba42f44e7d8e2f73a92923b0374e39083aa]

        gtk3 a11y: Drop obsolete handling when notifying child removal
        
        This special handling with the comment saying
        
            /*
             * the atk-bridge GTK+ module gets back to the event source to ref the child just
             * vanishing, so we keep this reference because the semantic on OOo side is different.
             */
        
        was added long ago, in
        
            commit d66cef09e7d7b19d8c85487f3b34e17f44d0ed98
            Author: Oliver Bolte <obo@openoffice.org>
            Date:   Fri Jul 25 08:11:58 2008 +0000
        
                INTEGRATION: CWS aqua11y02 (1.8.34); FILE MERGED
                2008/06/12 13:32:40 obr 1.8.34.3: #i86659# add support for XAccessibleMultiLineText
                2008/06/06 10:19:20 obr 1.8.34.2: #i85292# wrapper now cache the name, suppress unload of gtk plugin when atk-bridge module gets loaded as the shutdown symbol is no longer in global address space
                2008/06/02 04:32:34 obr 1.8.34.1: #i88047# role mapping reworked
        
        and no longer applies. It doesn't for more than a decade, see
        e.g. ATK/at-spi2-core commit [1]
        
            commit 69ac4b1ac14a6da7fd248e97918088eee59e3d6d
            Author: Mark Doffman <mark.doffman@codethink.co.uk>
            Date:   Mon Jan 11 10:24:57 2010 -0800
        
                Ensure the child data is added to children-changed events properly.
        
        where ATK already only calls `atk_object_ref_accessible_child`
        for the "children-changed:add", not the "children-changed:remove"
        event, and that is still true today, see [2].
        
        Therefore, drop the special handling.
        
        [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/69ac4b1ac14a6da7fd248e97918088eee59e3d6d
        [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/a5dcfe006aac552f4e0ca0b8b337febd52426ae4/atk-adaptor/event.c#L1195-1214
        
        Change-Id: I663780826289f7486eb2d73cdfbcc1733e081233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184873
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [63456ae59bead30d4af6e9a9b2e80ab6dd37f58d]

        sw a11y: Drop extra raw pointer local var
        
        Change-Id: Id30fe72601bafd72fd4076dfd0be3add0bbd1419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184871
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [e7aa46efdfb67f448d3687131b375ac27a016ea0]

        sw a11y: Return list instead of using out param
        
        Change-Id: I1fcafa73466fc3da6c0bbfdd605f27c09cf13f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184870
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [9d27287b7c39580729c07aa370ae2ab7eee68a5a]

        sw a11y: Flatten SwAccessibleParagraph::getAccessibleRelationSet
        
        Return early for null `pTextFrame`.
        
        Change-Id: Ieb2ab4d52ff0b7d9686bd3881d44931d3780d401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184865
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [8e43a6c4c1eed2a12c651613c2dbee7d1988c776]

        tdf#130857 qt weld: Evaluate "label" property for tool buttons
        
        Evaluate the GtkToolButton::label property for "GtkToolButton"
        objects in .ui files, and set the text for the QToolButton based
        on it.
        
        This e.g. makes the Orca screen reader announce the "Paste" and
        "Special Characters" tool buttons in the spelling dialog as such
        instead of just saying "button" when they receive focus in a
        WIP branch adding support for that dialog with the qt6 VCL plugin
        and SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: I35a1c6940881d47f6d788144ef221b089cbd67bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12addbb31b57555055d130add599daefa3036c86]

        Fix typo
        
        Change-Id: Idd3b8248db2feff76b4adffacee8dbfea33353b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184861
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b0ef63a163f7801f14b02ac607f2167313ab6b01]

        Fix typo
        
        Change-Id: Iba99aa9b58a1b464cae459108e1fcae9b7cd94b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184864
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2816d1baecef683f9ebe27990362b5221a9c645d]

        Fix typo
        
        Change-Id: Iba99aa9b58a1b464cae459108e1fcae9b7cd9499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184863
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-05-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [404d42e998e5641447ac5dbcb85fb2e33aacd447]

        Fix typo
        
        Change-Id: Id0c5df51e6c8cfb0e2d2895f48393925d7b1fe1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184862
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e5b695eeb2ddc969efae09f0bcf24d5a773c7c1]

        Gtk-WARNING Invalid column number 6 added to iter
        
        Change-Id: Ifa0c340bd621e1490f3404a5cafcab64b2d9112e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184860
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6bd3e5e53e07499e03cebe0c9b0aedcfdbe3c97]

        resave with latest glade
        
        Change-Id: Ia81825851fbd377184cc312348a2e30bd4b80d8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184859
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-05-01  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [ebbb3b979fb4b866947bb90addde59adff5fb267]

        tdf#164970 use proper enums for ApplicationAppearance instead of raw ints
        
        ApplicationAppearance registry entry holds the appearance mode the
        application is in at any point. it is represented by three integers 0
        for "Automatic", 1 for "Light" and 2 for "Dark".
        
        this patch introduces an enum `AppearanceMode` which replaces the
        integer switch cases and comparisons in conditionals with more readible
        enums.
        
        Change-Id: Ibe90875cc8d2370476442f726ebbb4eb02cccc91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184393
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [b410749d30ed167f5bf0da6491d72e55f596cd41]

        tdf#137308 - Add zstd build support and decompression classes
        
        Integrate build system support for the Zstandard (zstd) library and
        implement the corresponding C++ decompression stream classes, enabling
        future use of zstd-compressed streams in ZIP packages.
        
        Build System (Part 2a):
        - Add `--with-system-zstd=[yes|no|auto]` configure option.
        - Implement system library checks (`zstd.h`, `libzstd`) in configure.ac.
        - Define rules (`external/zstd/*`) for downloading and building the
          internal zstd static library (decompression components only).
        - Set up necessary CFLAGS/LIBS via configure.ac and config_host.mk.in.
        - Configure linking via RepositoryExternal.mk (`gb_LinkTarget__use_zstd`).
        - Update auxiliary files (download.lst, distro-configs, etc.).
        
        C++ Implementation (Part 2b):
        - Implement `InflateZstd` (in `include/package`) and `InflaterBytesZstd`
          (in `package/inc`) inheriting from `Inflater`/`InflaterBytes`.
        - Use the zstd streaming API (`ZSTD_decompressStream`) following the
          existing single-call pattern established by the zlib implementation.
        - Manage context (`ZSTD_DCtx`) and input buffer (`ZSTD_inBuffer`) state.
        - Handle errors, stream completion (`ret == 0`), and input truncation.
        - Add new classes to `package/Library_package2.mk` build.
        
        This completes the infrastructure for zstd decompression support.
        The next step (Part 2c) involves adding logic to select the
        appropriate Inflater based on the ZIP entry's compression method ID.
        
        Change-Id: Ia673f3f19b6a751ba5225394fcf8c3f145c4ae63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-05-01  Aron Budea  <aron.budea@collabora.com>  [55169df2f6e4f8deb9c042b81cc3ff4f01cbf522]

        tdf166413 sc: escape quotes in XLSX cond. formatting fixed formula
        
        ...during export, otherwise Excel fails to open file
        
        Change-Id: I50bc16ff4064a84ae3601cfa539d7b90f5441607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184852
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-01  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [52ad257d4434ac6fdd02de7b3c151dfcf84df739]

        tdf#45904 Remove old SwXTableCellText Java test
        
        Change-Id: I32a4c07d733ca5455763eae5c49925a8435ec218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180480
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [92df695bf523a9e34b40811208c30affe4455342]

        basicide a11y: Let Document implement XAccessible, drop TextWindowPeer
        
        No longer have TextWindowPeer as a custom VCLXWindow
        subclass that gets returned in
        EditorWindow::GetComponentInterface (called via
        vcl::Window::CreateAccessible) and is then responsible for
        creating an accessibility::Document object for its XAccessibleContext.
        
        Instead, let the Document class which already implements
        the XAccessibleContext interface also implement the
        XAccessible interface (and return self in its
        XAccessible::getAccessibleContext implementation)
        and create the new class when an XAccessible is
        requested via EditorWindow::CreateAccessible, i.e.
        override vcl::Window::CreateAccessible to avoid
        the VCLXWindow indirection altogether.
        
        No change in end user behavior expected or observed
        in a quick test with Basic IDE ("Tools" -> "Macros"
        -> "Edit Macros") when testing with Orca and Accerciser
        with the gtk3 and qt6 VCL plugins.
        
        Change-Id: Ie6f492b523dfd404c2ac7c3a149979105cc1d43f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184839
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [d997c4fd03d76faf4d72f29a927be43d630f3a64]

        basicide a11y: Move TextWindow a11y classes to basctl, create directly
        
        Move the a11y classes used for implementing Basic IDE a11y
        from vcl to basctl. Move them into a namespace
        "accessibility" to avoid a name clash with the Paragraph
        class declared in include/editeng/outliner.hxx.
        
        In TextWindowPeer::CreateAccessibleContext, call the
        Document ctor directly and drop the now unused
        AccessibleFactory::createAccessibleTextWindowContext.
        
        Change-Id: I396507e5fca17b4e7a1b65b28797569bc31d6a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184838
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [9e96699b4040949699b86e11fd23100f6d59368d]

        basicide a11y: Move basctl::createTextWindowPeer logic to caller
        
        Drop the helper method basctl::createTextWindowPeer
        that calls the TextWindowPeer ctor, and instead
        call the ctor directly from
        EditorWindow::GetComponentInterface.
        
        In order for the class to be known there, move it
        to the anonymous namespace in the same source file.
        
        This is an intermediate step towards
        getting rid of TextWindowPeer altogether.
        
        Change-Id: I58111af8fadb45c6471af942b300665f3df189c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184837
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [3a51a200e552f240d4242ccf32d0421a424306ab]

        svx a11y: Use OAccessibleComponentHelper for WeldEditAccessible
        
        This allows to reuse some of the XAccessibleComponent
        logic already implemented in the new base class.
        WeldEditAccessible::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename it - and drop the SolarMutexGuard at
        the beginning of the method, as the base class takes
        care of that when calling the method.
        
        For now, keep the custom implementations for
        XAccessibleEventBroadcaster methods
        XAccessibleEventBroadcaster::addAccessibleEventListener
        and XAccessibleEventBroadcaster::removeAccessibleEventListener
        which forward the task to the AccessibleTextHelper
        in use.
        (This will be further change in upcoming commits.)
        
        Rename WeldEditAccessible::ClearWin to
        WeldEditAccessible::dispose, let it override the
        base class implementation and call the base class
        implementation at the end.
        
        Add a check and return early if the object has
        already been disposed. Without this,
        CppunitTest_starmath_qa_cppunit was seen triggering
        a segfault, because the object now first got disposed
        in the SalInstanceDrawingArea dtor:
        
            1   WeldEditAccessible::dispose                                                             weldeditview.cxx     549  0x7f2472cb63c3
            2   SalInstanceDrawingArea::~SalInstanceDrawingArea                                         salvtables.cxx       6466 0x7f247d9eb528
            3   SalInstanceDrawingArea::~SalInstanceDrawingArea                                         salvtables.cxx       6442 0x7f247d9eb600
            4   SalInstanceDrawingArea::~SalInstanceDrawingArea                                         salvtables.cxx       6442 0x7f247d9eb689
            5   std::default_delete<weld::DrawingArea>::operator()                                      unique_ptr.h         93   0x7f247765c69b
            6   std::unique_ptr<weld::DrawingArea, std::default_delete<weld::DrawingArea>>::~unique_ptr unique_ptr.h         399  0x7f247765c60f
            7   weld::CustomWeld::~CustomWeld                                                           customweld.hxx       150  0x7f247765c5c9
            8   std::default_delete<weld::CustomWeld>::operator()                                       unique_ptr.h         93   0x7f247765c507
            9   std::__uniq_ptr_impl<weld::CustomWeld, std::default_delete<weld::CustomWeld>>::reset    unique_ptr.h         205  0x7f2477674318
            10  std::unique_ptr<weld::CustomWeld, std::default_delete<weld::CustomWeld>>::reset         unique_ptr.h         504  0x7f2477672f8d
            11  SmEditWindow::DeleteEditView                                                            edit.cxx             857  0x7f247767013a
            12  SmEditWindow::~SmEditWindow                                                             edit.cxx             148  0x7f2477670059
            13  o3tl::default_delete<SmEditWindow>::operator()                                          deleter.hxx          46   0x7f2477728e57
            14  std::__uniq_ptr_impl<SmEditWindow, o3tl::default_delete<SmEditWindow>>::reset           unique_ptr.h         205  0x7f2477729008
            15  std::unique_ptr<SmEditWindow, o3tl::default_delete<SmEditWindow>>::reset                unique_ptr.h         504  0x7f24777224cd
            16  SmCmdBoxWindow::dispose                                                                 view.cxx             1016 0x7f247771d23b
            17  VclReferenceBase::disposeOnce                                                           vclreferencebase.cxx 38   0x7f247d4f3163
            18  VclPtr<SmCmdBoxWindow>::disposeAndClear                                                 vclptr.hxx           207  0x7f24775d6472
            19  (anonymous namespace)::Test::tearDown                                                   test_starmath.cxx    138  0x7f24775cb4c0
            20  CppUnit::TestCaller<(anonymous namespace)::Test>::tearDown                              TestCaller.h         185  0x7f24775d543a
            [...]
        
        And later on, WeldEditAccessible::dispose would be called
        again from the WeldEditView dtor (which was previously
        calling WeldEditAccessible::ClearWin).
        
        No change in behavior intended or observed in a quick
        test with the qt6 VCL plugin and Base's "Tools" -> "SQL" dialog,
        where a WeldEditView is used for the "Command to execute"
        edit view.
        (Accerciser still highlights the correct area when selecting
        the object or its paragraph children.)
        
        Change-Id: I9864a35d53bdbd2332869780c097896102b9523b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184833
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [2c25cabba1d69b0238cf06e03637d23e33dc0c56]

        sfx2 a11y: Drop ThumbnailViewAcc::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        basically implements the same logic already.
        
        Change-Id: Ib2106fd6ace58c016cb0d7c3eb8b98a724af34fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184832
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Michael Weghorn  <m.weghorn@posteo.de>  [f5d607b4ffb031879bd493c59a453fb4740a07e1]

        sc a11y: Make GetBoundingBoxOnScreen::GetBoundingBox{,OnScreen} non-const
        
        These methods are almost exclusively used to implement the non-const
        OAccessibleCompomentHelper::implGetBounds and
        OAccessibleComponentHelper::getLocationOnScreen
        overrides.
        
        Making them non-const allows dropping some
        const_casts in some of the subclass implementations.
        
        Change-Id: Ia26858c1211629c4a336919c8e9d4d0c70e73097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184831
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [b4ad56ecb6ecd6a75667656817136c34f8bea50e]

        Simplify vector initialization using brace initialization
        
        Change-Id: Ied85f4950c0dd01cc58c81fdad1196ee6d51ff4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184850
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [f4b72c08f93f7b4dfb1f40fb9dd4b16e925d64a9]

        Refactor shell thumbnail extension code
        
        1. Drop obsolete #ifndef DONT_HAVE_GDIPLUS, introduced in commit
        06c8108fe5c196aec2888d9b236f595f2bcb1c46 (Attempt to make this
        build with MinGW, 2011-06-24).
        
        2. Improve API methods implementations.
        
        2.1. In IUnknown::Release, make sure to check the value returned
        from decrement, not the member (that could potentially be modified
        in the meantime again).
        
        2.2. In ISequentialStream::Read, don't return S_OK for too large
        read; and make sure to set pcbRead even on zero-byte read.
        
        2.3. In IStream::Seek, check dwOrigin value; handle STREAM_SEEK_END
        correctly, without subtracting an extra 1; don't fail on too large
        positive offset (that is explicitly documented as OK); and don't
        ignore the plibNewPosition argument (callers expect the new offset
        there).
        
        2.4. In IStream::Stat, check grfStatFlag value; handle OOM; don't
        limit the returned offset to 32 bits.
        
        3. Make StreamOnZipBuffer own the buffer. It user a reference to
        temporaries; but the object is refcounted, and when passed to an
        API, it could potentially outlive the temporaries it depended on.
        
        4. Move CThumbviewer definition to CXX, and simplify the HXX.
        
        Change-Id: I5b31a8bf66651862d730cc346948dc04f984fddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184807
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [923da8a3855afae1f3f3a5f50d1fec08bbc02438]

        update credits
        
        Change-Id: I3a4535d6f89e0c2ef9ef78259b271690ce4d2402

2025-04-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [2f2f00c07c104b1fb6a523379a5f8ff639b06de5]

        framework: improve language in comments for better readability
        
        Change-Id: I7a1801f1848869a84ebe3569159175b2ac767567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183249
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [53dd76d891c9d7f3d62ed749f873f95a4915e3e3]

        moNullDate is always created
        
        Change-Id: Id567d4efef40d7510d28d2e02e954d9ab948f121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184841
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ea7ee0bf5ef412b267038583441d308b2cb5943]

        const things up, elide a copy
        
        Change-Id: I8b81c69c4a01ff3a2dd9a58628e203f187ed5e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184843
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-30  Pranam Lashkari  <lpranam@collabora.com>  [e7e48682cca73b3eb4ddba947e10159b6aeb5335]

        sd: use slide(SdPage/Part) selection for current view only
        
        problem:
        in LOK when multipe users select the different slides some operations may fail
        i.e:
        - user A and B opens the document,
        - User B selects slide 4
        - User A selects slide 1
        (without this patch SdPage will only concider slide 1 selected)
        - Then user B tries to drag and drop slide 4 above the slide 1
        - now core will think slide 1 is selected and need to put
        it above slide 1 that means nothing happens
        
        Change-Id: Ia9ebe531ddb1c21ffaa1435d9cc777750b4ca24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184629
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit aee332547295c78b3bcda38b67ba3f1ec2b0fc06)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184842
        Tested-by: Jenkins

2025-04-30  Heiko Tietze  <tietze.heiko@gmail.com>  [ec04856ff1dfe0c5c9462263f2d261c30a336d7c]

        Turn UI picker dialog into a SfxTabDialog
        
        Prerequisite to 6fa44178cad838fe126e64c87c873a1ee181f542
        
        Change-Id: I8612658bddc79682b9b63c60eb8e4bf72021b50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184714
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-04-30  Mateusz Wlazłowski  <mateusz.csi@gmail.com>  [234cb2da3598837a60572dc8475bcb7d9503335f]

        tdf#166268 Initialize the correct null date in ImpSvNumberformatScan
        
        When forcibly recalculating the document from the bug report, multiple threads
        are spawned, each initializing its own SvNFLanguageData object from an already
        existing one.
        
        When initializing an SvNFLanguageData object from another one, the associated
        null date (maNullDate) is not passed to the newly created
        ImpSvNumberformatScan object, resulting in it always initializing with the
        default null date of 30/12/1899 in worker threads.
        However, the document has a base date set to 01/01/1904, causing displayed
        dates to appear from 1904, while functions like =YEAR() calculate dates
        based on 1899. This leads to a 4-year difference between displayed dates and
        the results of date functions.
        
        This commit updates the ImpSvNumberformatScan constructor to pass the original
        object's null date during initialization, while retaining 30/12/1899 as the
        default for cases where no explicit null date is provided.
        
        Regression from: b38974391e8d4bf0d450abfaa86bbccbe1022995
        (Related: tdf#160056 do calc NumberFormatting via ScInterpreterContext)
        
        Change-Id: I7b622717f2c245dccef22897c1a2cc88daf60ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184687
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fd8b5190236281554525eec757d506a14c763efd]

        Avoid misaligned-pointer-use
        
        ...after d0ee08cfbf12145027eee7ad46448a8734693c06 "oox: export embedded font
        used in a presentation document" caused CppunitTest_vcl_font_ttf_structure_test
        to fail with
        
        > vcl/qa/cppunit/font/TTFStructureTest.cxx:47:5: runtime error: member call on misaligned address 0x7de9211e0262 for type 'o3tl::sal_uInt32_BE', which requires 4 byte alignment
        > 0x7de9211e0262: note: pointer points here
        >  00 00  00 00 80 00 00 af 10 00  20 48 00 00 00 00 00 00  00 00 57 33 43 00 00 40  00 20 f0 02 03 20
        >               ^
        >  #0 in (anonymous namespace)::testReadTTFStructure::TestBody() at vcl/qa/cppunit/font/TTFStructureTest.cxx:47:5
        
        Change-Id: I4d46decd497fccf7eecdb38764ac82ed2a68b5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184829
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-30  Michael Stahl  <michael.stahl@allotropia.de>  [2753c21abefa1d08464744ed03467736cc7062ec]

        sfx2: warn user before saving doc with scripting signature encrypted
        
        The pre-ODF 1.5 encryption necessarily destroys macro signatures, but
        the user would learn this only when re-loading the encrypted document.
        
        Change-Id: Ic8a0190205412f484f47a4b8d864b280eea0d23c
        (cherry picked from commit 558c6a83c210a4d9d7a699616c6f254fb23d7cf4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184822
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6fee94e76df21c614ca4504d430394404ace018b]

        preserve symlinks when keeping a copy of unpacked tarball (patches=1)
        
        zxing contains dangling symlinks to an optional submodule
        make with patches=1 (to create copy of the extracted dir in preparation
        for genpatch) fails for zxing because of the missing submodule:
        "cp -r foo foo.org" fails with "cp <danglingsymlinktosubmodule>: No
        such file or directory"
        telling cp to not dereference symlinks/to copy them as-is solves that
        problem.
        
        Change-Id: I0fe7f0bcb21307be99cbeaf9704480df62ff96be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184826
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-30  Juraj Šarinay  <juraj@sarinay.com>  [6783d251608ee09ff7167bb19d81160bd3de1d31]

        tdf#147452 Do not compute the signature twice when adding a timestamp using NSS
        
        For non-deterministic signature schemes (e.g. ECDSA) we produced invalid
        timestamps. The signature timestamped differed from the one actually
        output.
        
        Change-Id: I0e88ed8625330f2a4f45cc2a725cfba28c25870f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180517
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cab41c2b06d27380d53d7f146adc0170c71414c1]

        Remove duplicated include
        
        Change-Id: Iaf6fc930ab49ec4b5c6f3fe71310b1fec1515a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184817
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4b530f4758f08481ef542734c7c9ca62a70bf708]

        Fix typo
        
        Change-Id: If75ded8ca3eecd974e36fc85276388fc2a24a17b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184818
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e275a6e6a08d1e53e5e921a701586c894d07ab2f]

        tdf#166379 - Add export config option to remove "Total editing time"
        
        separately from all private info files during save.
        
        The new expert config option name is: RemoveEditingTimeOnSaving
        (There wasn't any UI element added for this expert config option.)
        
        Change-Id: Iab69d062d161ef6aee1c3eb87ada1c16f8b4fd41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184789
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-04-30  Juraj Šarinay  <juraj@sarinay.com>  [4c140035427f069f35534c51da06b27ce7fdbf31]

        Remove two copies of SEC_StringToOID(), replace strings by OIDs.
        
        The functions were only ever called on string representations
        of id-aa-signingCertificateV2 and id-aa-signatureTimeStampToken.
        Simplify the code by using the corresponding OIDs directly and
        remove the functions.
        
        Change-Id: Ia00159749c27acc3ba0753b24703c3117a25bcc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180516
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e072d02b1ec3f7dc2976042eb7fd46d7b776f95]

        ScAcceptChgDlg: pass ScViewData by ref
        
        to ensure it's not nullptr
        
        Change-Id: I462633d583c7be3f249427f103215bc76d1c0d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184821
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-30  Juraj Šarinay  <juraj@sarinay.com>  [4b71a526ec6e3ceb4aca8694df4cb64f85412c9c]

        Do not add a second copy of signer's certificate to CMS SignedData.
        
        Signer's certificate is included in the chain we add as a result of
        NSS_CMSSignerInfo_IncludeCerts(). There is no need to call
        NSS_CMSSignedData_AddCertificate().
        
        Change-Id: I5cbb4c268a79910ea33b06b58e32f40194ca39c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180515
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-30  Julien Nabet  <serval2412@yahoo.fr>  [13a3a28969d45f12c552e2d2968c03373cb2a063]

        Related tdf#165980: now cxxhelp/provider/inputstream is useless, get rid of it
        
        Change-Id: I3f1c71cc83f6f086c472a94adb8d5b916d1c8526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184827
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [03b0afa5fdf8f4bd0fb23dbfd1c19d50202c07bd]

        vcl: more fine grained handling of error in PNG reader
        
        Handle if the error happens at init, reading and after reading
        differently. At init we don't need to handle the bitmap as nothing
        has yet been writtent to it. Also after reading we can handle it
        like no error happened, because we have read the data completely
        but the error happened after that (like missing IEND chunk for
        example).
        
        Change the error and warning messgaes when reading from the stream.
        
        Change-Id: I927b8679f168da43e8e6e00663ff551064b870c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184811
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [78ee3d4821904449a13de5451e0c1455a432e614]

        ScNavigatorDlg: simplify a bit
        
        not need to have pViewData member
        
        Change-Id: Ia697f80421ffbbec36514c60a04087a55383d349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184801
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-30  Julien Nabet  <serval2412@yahoo.fr>  [871dc7bce19242e467d98a02108a8eb8668f2ea1]

        tdf#165980: fix crash when launching help with "--with-help"
        
        assertion:
        5  0x00007f0f5578cf2a in ByteGrabber::ByteGrabber (this=0x558123967710, xIstream=uno::Reference to (chelp::XInputStream_impl *) 0x558124099a20)
           at /home/julien/lo/libo_perf/package/source/zipapi/ByteGrabber.cxx:44
        6  0x00007f0f557a0793 in ZipFile::ZipFile
           (this=0x558123967640, aMutexHolder=empty rtl::Reference, xInput=uno::Reference to (chelp::XInputStream_impl *) 0x558124099a20, xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x558121aacc48, bInitialise=true, bForceRecovery=false, checks=ZipFile::Checks::Default) at /home/julien/lo/libo_perf/package/source/zipapi/ZipFile.cxx:90
        7  0x00007f0f5580208d in std::_Construct<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&, ZipFile::Checks> (__p=0x558123967640) at /usr/include/c++/14/bits/stl_construct.h:119
        8  0x00007f0f557ffb2d in std::_Optional_payload_base<ZipFile>::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&, ZipFile::Checks> (this=0x558123967640) at /usr/include/c++/14/optional:274
        9  0x00007f0f557fd87d in std::_Optional_base_impl<ZipFile, std::_Optional_base<ZipFile, false, false> >::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&, ZipFile::Checks> (this=0x558123967640) at /usr/include/c++/14/optional:455
        10 0x00007f0f557f9186 in std::optional<ZipFile>::emplace<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&, ZipFile::Checks> (this=0x558123967640) at /usr/include/c++/14/optional:916
        11 0x00007f0f557e63f3 in ZipPackage::initialize (this=0x558123967510, aArguments=uno::Sequence of length 2 = {...}) at /home/julien/lo/libo_perf/package/source/zippackage/ZipPackage.cxx:893
        12 0x00007f0f876d6b87 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments
           (this=0x558121b4fd80, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x558121aacc48, arguments=uno::Sequence of length 2 = {...})
           at /home/julien/lo/libo_perf/cppuhelper/source/servicemanager.cxx:728
        13 0x00007f0f876d6884 in cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments
           (this=0x558121b4fd80, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x558121aacc48, singletonRequest=false, arguments=uno::Sequence of length 2 = {...})
           at /home/julien/lo/libo_perf/cppuhelper/source/servicemanager.cxx:690
        14 0x00007f0f876d9860 in cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext
           (this=0x558121ab2c10, ServiceSpecifier="com.sun.star.packages.comp.ZipPackage", Arguments=uno::Sequence of length 2 = {...}, Context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x558121aacc48) at /home/julien/lo/libo_perf/cppuhelper/source/servicemanager.cxx:1015
        15 0x00007f0f5552856d in chelp::Databases::jarFile (this=0x55812318ee80, rGuard=..., jar=u"shared.jar", Language="fr") at /home/julien/lo/libo_perf/xmlhelp/source/cxxhelp/provider/databases.cxx:842
        16 0x00007f0f5552c519 in chelp::JarFileIterator::nextJarFile (this=0x7ffc4d067e80, rGuard=..., o_xParentPackageBundle=empty uno::Reference, o_pExtensionPath=0x0, o_pExtensionRegistryPath=0x0)
           at /home/julien/lo/libo_perf/xmlhelp/source/cxxhelp/provider/databases.cxx:1593
        
        See almost full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=200590&action=edit
        
        The way to retrieve the zip content (Jar is a zip) since the stream didn't implement comphelper::ByteReader.
        Instead of changing XInputStream_impl to implement it, I thought it could be interesting to copy a bulletproof way
        from by using ZipPackageHelper in unotools/source/misc/ZipPackageHelper.cxx
        
        m_aZipFileTable is now completely useless (BTW compilerplugins/clang/unusedfields.writeonly.results already indicated
        that the member was only written)
        
        If if it works well, we could get rid of xmlhelp/source/cxxhelp/provider/inputstream.hxx and cxx associated.
        
        Change-Id: Ie9c3b5808c835206830e87b129efcdf98ba505af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184732
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0c1b3c1c97bbfdc8d8f84b36fb5879400095c5e0]

        oox: Don't substitute fonts if embedding fonts is enabled
        
        This is needed to prevent that we embed a font but then export
        a different (substituted) font name into the document, which
        would defeat the purpose of embedding in the first place.
        
        This is not ideal either as a we probably need better control of
        what we can just substitue and what we need to embed.
        
        Change-Id: Icd29789ceb739b6950576379358a96cc0449b3b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184696
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [875443e7d93b1d1728be2863d3784e0792a77f41]

        oox: embed used fonts only and font scripts for PPTX export
        
        Support properties "EmbedOnlyUsedFonts", "EmbedLatinScriptFonts",
        "EmbedAsianScriptFonts", "EmbedComplexScriptFonts" when exporting
        embedded fonts. This brings it to the same functionality as other
        embedded font exports.
        
        Change-Id: I9e463c0fbc8a41b165b30fa11222648e930dbca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184348
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2da5506d1c2d9513a96de25f5782f706a108165f]

        vcl: Fix threaded reading of graphics
        
        Make the behavior of handling errors the same as with readPNG
        (ignore the returned bool result, but check if the bitmap is set
        and not empty).
        
        Also make sure we always create the Graphic, even if there was a
        read error, so the check to be loaded and loaded graphics passes:
        
        assert(loadedGraphics.size() == toLoad.size());
        
        Change-Id: I8fe7ee597de9f2385c029d38970bac030a91fc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184810
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-30  Juraj Šarinay  <juraj@sarinay.com>  [637e3c46192dc6fb5ff1a289f626b2fac698aed6]

        tdf#147452 Do not compute the signature twice when adding a timestamp on Windows
        
        For non-deterministic signature schemes (e.g. ECDSA) we produced invalid
        timestamps. The signature timestamped differed from the one actually
        output.
        
        Change-Id: I6717ad4f6ab644244bf97fefdefbd407f207cb05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180519
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [93aa7e615bbc1524c86075b25963d339ec87f464]

        harfbuzz: create symbols with --enable-symbols
        
        --enable-symbols can be used independently (and selectively) from
        --enable-debug or --enable-dbgutil, so if neither of those are
        specified, check whether symbols should be created and pass the flags to
        c_args / cpp_args
        
        Change-Id: I6d5bc9b7857a2538b71efb820534c2a18d1dfd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184753
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0fccc92e326ef663d0e615df50831d32b446233c]

        fix harfbuzz with --enable-debug on win (msvc debug runtime mismatch)
        
        debug type in meson uses flags to use debug versions of the vscrt, this
        causes issues when using --enable-debug since the rest of the build only
        uses the debug runtime if the --enable-dbgutil switch is used. These two
        being misaligned then causes linker failures, harfbuzz using the debug
        runtime and rest of LO using the release version is not compatible:
        
        libharfbuzz.a(hb-blob.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MD_DynamicRelease' in drawmode.o
        
        the debugoptimized build-type doesn't use the debug runtime and also
        uses optimization flags that don't interfere with debugging. The runtime
        could also be forced independently using -Db_vscrt=<mdd,md,mtd,mt>, but
        the automatic selection from the buildtype/the additional optimization
        in the --enable-debug case should be fine.
        
        Change-Id: I9263fa7b6fdb71ab9efb00ae634ddf16453e50cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184751
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-04-30  David Hashe  <me@dhashe.com>  [c712dd24410e49da4039e4e5bec536d673544b90]

        tdf#39749 Add calc unit test covering tdf#147265
        
        Change-Id: I5838f87c7e21a6dc167d49d8680e39dd219d28f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182976
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-30  Miklos Vajna  <vmiklos@collabora.com>  [8278384498d4a02559c81884c0ffe763b9facc1b]

        cool#11785 sw lok: only start idling after the idle jobs timer stopped
        
        Open a 300 pages document with simple content, the load itself only
        takes ~100 ms, but the time between the end of load and start of
        rendering tiles is a lot more than that:
        debug:32053:31994: lo_documentLoadWithOptions: end @ 2092810770
        debug:32053:31994: DocumentTimerManager::DoIdleJobs: finished in 3152 ms
        debug:32053:31994: doc_paintPartTile: start @ 2092814038 -> 3268 ms
        
        Looking at the flamegraph in the issue shows that we start processing
        idle jobs, part of that is sw::DocumentTimerManager::DoIdleJobs(). That
        used to do ~no layout work since layout was fully done as part of
        document load before commit bba965b655a9181c07e5cfb6d3a59363e49e650b
        (cool#11064 sw lok: allow specifying the visible area during doc load,
        2025-02-13). Now some layout can be done on idle, and as part of that we
        call SpellCheckerDispatcher::isValid(), which takes a lot of time, and
        is not interrupted as a tile request comes in.
        
        Fix the problem by extending the delay effort of commit
        349748e63c698076bb44f75da9eaa104489e959c (sw lok: delay processing idle
        jobs to let LOK finish initialization, 2018-12-03), which already had a
        1s delay of idle jobs, but it didn't work, because
        sw::DocumentTimerManager::StartIdling() is also called from e.g.
        SwRootFrame::SetIdleFlags(), so the idle jobs still started. Now we
        explicitly don't start idling till m_aFireIdleJobsTimer is active
        (started, but not yet invoked).
        
        With this, the first tiles are rendered much faster after load:
        debug:14058:13996: lo_documentLoadWithOptions: end @ 2095914924
        debug:14058:13996: doc_paintPartTile: start @ 2095915224 -> 300 ms
        This also means that two tests now don't get idle jobs done after
        Scheduler::ProcessEventsToIdle() (and this is wanted by default), so
        explicitly stop m_aFireIdleJobsTimer in those tests to be able to assert
        what would happen after waiting for long enough.
        
        Change-Id: I8398dc7687d8ac0858f804e687593c5cb7c4e47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184809
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-30  Simon Chenery  <simon_chenery@yahoo.com>  [0661337767b0a07990ea72898b1bd9837306c467]

        tdf#164954 rename German abbreviation "Koeff" to English "Coeff" in vars, funcs
        
        The German word "Koeffizient" translates to "Coefficient" in English.
        
        Change-Id: I38cbb327df085a607cb6922003fa3f07e27eca8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184663
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f6ad4397dc7cee97020d8d2e89345157dbfc7a0f]

        sd: move ModelTraverser to own file so it can be reused
        
        Change-Id: I8d487fd009ca3fa5fb9de8aabe65fd3e5e21b41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184692
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d0ee08cfbf12145027eee7ad46448a8734693c06]

        oox: export embedded font used in a presentation document
        
        This adds support to export the fonts that are used in an
        presentation document. The fonts are converted to EOT fonts.
        
        Adds an EOT converter, which converts a TTF font to EOT font by
        writing a EOT header and adding the TTF font data.
        
        Adds BigEndianTypes so we can read a structure that is defined in
        big endian and the types get converted (if needed) to system
        endian when accessed. + test
        
        Adds TTF reader which reads the true type font structure in an
        easy way that is used by the EOTConverter. + test
        
        Change-Id: I8b0bcb69e47943c2a8679edf881d7c2bab45c450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184288
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [56d64a40c1a257de817406130ca6551d0f3233bf]

        harfbuzz: Honor USE_LD, don't force specific linker if unset
        
        With the harfbuzz build having been switched to meson
        in commit
        
            commit ae24fc8c639b230284f94e837497cd7919f79d21
            Date:   Tue Apr 8 12:19:31 2025 +0200
        
                harfbuzz: migrate to meson
        
        , building harbuzz in my local Android build using
        an autogen.input containing
        
            --with-android-ndk=$HOME/Android/Sdk/ndk/28.0.13004108
            --with-android-sdk=$HOME/Android/Sdk
            --with-distro=LibreOfficeAndroidX86_64
            --enable-sal-log
            --enable-android-editing
            --with-external-tar=/home/michi/development/libreoffice-external
            --disable-ccache
            --with-jdk-home=/usr/lib/jvm/java-21-openjdk-amd64/
        
        started to fail because it couldn't detect the linker to use.
        This is caused by `c_ld` and `cpp_ld` explicitly being set
        to the *compiler* command in `cross-file.txt` that meson evaluates
        which is then used by meson to set the *linker* to use via
        `-fuse-ld=<command>` for gcc or clang (see [1]).
        However, ccache or clang are not suitable to be used as linkers.
        
        Fix that problem by evaluating the USE_LD variable and using the
        linker set this way.
        (It is `USE_LD=-fuse-ld=lld` for above-mentioned Android build.)
        
        If it's not set, then having an empty `c_ld` and `cpp_ld` is fine
        and will result in no particular linker being forced, i.e. let meson
        use its default logic.
        
        Leaving it empty is also fine on Windows. Quoting Christian
        Lohmaier's comment [2]:
        
        > re windows: linker can be empty, it then would try link from the vsenv,
        > but for static libraries it defaults to using LIB / so in the case
        > for harfbuzz c_ld / cpp_ld are in fact ignored/unused. for this case
        > ar setting would be used to override.
        
        Also, replace "X86_64" by "x86_64" for the `cpu_family`
        to address the
        
            WARNING: Unknown CPU family X86_64, please report this at https://github.com/mesonbuild/meson/issues/new
        
        warning seen in the below output.
        
        Thanks to Christian Lohmaier on whose feedback on earlier
        versions of the Gerrit change this is heavily based!
        
        ---------------------------------------------------------
        
        Error seen previously with an `--enable-ccache` build, where
        `-fuse-ld=/usr/bin/ccache` would be used:
        
            $ make harfbuzz
            cd /home/michi/development/git/libreoffice-WORKTREE-android/external/harfbuzz && make -j 32 -rs
            [LOC] top level modules: harfbuzz
            WARNING: Unknown CPU family X86_64, please report this at https://github.com/mesonbuild/meson/issues/new
            The Meson build system
            Version: 1.7.0
            Source dir: /home/michi/development/git/libreoffice-WORKTREE-android/workdir/UnpackedTarball/harfbuzz
            Build dir: /home/michi/development/git/libreoffice-WORKTREE-android/workdir/UnpackedTarball/harfbuzz/builddir
            Build type: cross build
            Project name: harfbuzz
            Project version: 11.0.1
        
            meson.build:1:0: ERROR: Unable to detect linker for compiler `/usr/bin/ccache /home/michi/Android/Sdk/ndk/28.0.13004108/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -target x86_64-linux-android21 -no-canonical-prefixes -ffunction-sections -fdata-sections -Qunused-arguments -Wl,--version -fuse-ld=/usr/bin/ccache`
            stdout:
            stderr: /usr/bin/ccache: unrecognized option '--hash-style=both'
            clang: error: linker command failed with exit code 1 (use -v to see invocation)
            [...]
        
        ---------------------------------------------------------
        
        Error seen previously with a `--disable-ccache build`, where
        `-fuse-ld=/home/michi/Android/Sdk/ndk/28.0.13004108/toolchains/llvm/prebuilt/linux-x86_64/bin/clang`
        would be used:
        
            $ make harfbuzz
            cd /home/michi/development/git/libreoffice-WORKTREE-android/external/harfbuzz && make -j 32 -rs
            [LOC] harfbuzz
            [UPK] harfbuzz-11.0.1.tar.xz
            [LOC] top level modules: harfbuzz
            [PAT] harfbuzz
            WARNING: Unknown CPU family X86_64, please report this at https://github.com/mesonbuild/meson/issues/new
            The Meson build system
            Version: 1.7.0
            Source dir: /home/michi/development/git/libreoffice-WORKTREE-android/workdir/UnpackedTarball/harfbuzz
            Build dir: /home/michi/development/git/libreoffice-WORKTREE-android/workdir/UnpackedTarball/harfbuzz/builddir
            Build type: cross build
            Project name: harfbuzz
            Project version: 11.0.1
        
            meson.build:1:0: ERROR: Unable to detect linker for compiler `/home/michi/Android/Sdk/ndk/28.0.13004108/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -target x86_64-linux-android21 -no-canonical-prefixes -ffunction-sections -fdata-sections -Qunused-arguments -Wl,--version -fuse-ld=/home/michi/Android/Sdk/ndk/28.0.13004108/toolchains/llvm/prebuilt/linux-x86_64/bin/clang`
            stdout: Android (12896553, +pgo, +bolt, +lto, +mlgo, based on r530567c) clang version 19.0.0 (https://android.googlesource.com/toolchain/llvm-project 97a699bf4812a18fb657c2779f5296a4ab2694d2)
            Target: x86_64-unknown-linux-gnu
            Thread model: posix
            InstalledDir: /home/michi/Android/Sdk/ndk/28.0.13004108/toolchains/llvm/prebuilt/linux-x86_64/bin
        
            stderr: clang: error: unknown argument: '--hash-style=both'
            clang: error: unknown argument: '--eh-frame-hdr'
            clang: error: unknown argument: '-m'
            clang: error: linker command failed with exit code 1 (use -v to see invocation)
            [...]
        
        [1] https://mesonbuild.com/Machine-files.html#binaries
        [2] https://gerrit.libreoffice.org/c/core/+/184459/comments/dbb124af_3c49b1e0
        
        Change-Id: I0793d7cc3428a13a050b5989a9e326b1b80595f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184459
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-30  Weblate  <noreply@documentfoundation.org>  [cc5c3b89b8041dd15cb70b1e9be4bbb1cd6d48e1]

        android-viewer translated using Weblate
        
        Romanian currently translated at 6.0% (7 of 116 strings)
        
        Change-Id: I2795e9f406189f2a10666207fb30d8d1e6ee38db
        Co-authored-by: Miloiu Andrei-Valentin <miloiuandrei@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184804
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [e2230f7706cc74ae05a0bc044dee75fa7984b10e]

        svx a11y: Rely on operator!= for awt::Rectangle comparison
        
        Don't reimplement the logic.
        
        Change-Id: Id89245e909cebd79955a5f5b42d4652b9f42a9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184805
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [f98d81f008e11fd2786597d82126a6287353c714]

        ScDrawView: pass ScViewData by ref
        
        Change-Id: I499c44ebc3f3eaf5310788dbf110b8a00d8a8035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184799
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [78fe1ba99e2c9764afefc5b632ddfd037935c0e6]

        vcl a11y: Drop AccessibleBrowseBoxBase::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        already implements the same logic.
        
        Change-Id: I3b9e4b2aa04bb24bb0355897ea18eb41cad9ef61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184794
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [a6d08b80bc014a92cfe3fced0ec09d3a1cc1cffa]

        a11y: Use OAccessibleComponentHelper::isAlive
        
        Use it to implement (inverted) logic in
        AccessibleContextBase::IsDisposed and replace uses
        of the latter in subclasses by using the (protected)
        OAccessibleComponentHelper::isAlive directly.
        
        Change-Id: Ib033097dfac9e7a986cb0334caf7ac568ad4300a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184793
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [aa5064a8973028edf8104c426d06a6f77332f63e]

        sc a11y: Use ref instead of pointer in ScChild{Gone,New}
        
        Change-Id: I28a314c2d07e402decb5a7e9cae1ac59b6e8dc3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184792
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [2cf36848ddfd802287f467aaf85b1c73739634f4]

        sc a11y: Switch ScNotesChildren::mpAccDoc to ref
        
        Use a reference instead of a pointer, to make clearer this is always
        non-null. This also allows to drop a null check in
        ScNotesChildren::DataChanged.
        
        Change-Id: Ief02eaafa7cd67a1ceb9562bf0a62435e4b877a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184791
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [7d5fe5bed3a66fe70908f147a7269e438d03e655]

        svx a11y: Use 0 client ID when disposed
        
        `mnNotifierClientId` is initialized with a non-zero
        value in the ctor, so 0 can be used as a special value
        to indicate that comphelper::AccessibleEventNotifier::revokeClient
        has been called.
        
        This aligns this a bit further with the implementation in
        OAccessibleComponentHelper.
        
        Change-Id: I84044ed76208ff8379e06d45c11591cae06a48d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184790
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [f7811a25c60a6b68fa8b212ee4bbdfab8584f01d]

        svx a11y: Merge both AccessibleTextHelper_Impl::FireEvent
        
        Change-Id: Iad029523c6553a865d0eae469add4dd1e4a8ef5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184788
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [bcbee8ad61937e17d065dfd13f69e459c0c634c1]

        chart a11y: Drop extra assignment to local var
        
        Change-Id: I8a5fccd35a707e84c6638bf1ee3d3a488cd413cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184787
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [83ab114452b78a91fb1eb2440a7db2d27566eb3e]

        chart2 a11y: Switch OSL_ENSURE -> assert
        
        ... and drop the additional check.
        
        The only caller AccessibleChartElement::InitTextEdit
        passes (always non-null) `this`.
        
        Change-Id: I218dc224eb6bad827fce66db02706bb555831a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184786
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [a7f0972c2fc7195f9e1c2f0adaf2a33ff5ae61a8]

        svx a11y: Drop private AccessibleTextHelper_Impl::getNotifierClientId
        
        Use the AccessibleTextHelper_Impl::mnNotifierClientId member directly instead.
        
        (That also aligns this a bit more with OAccessibleComponentHelper,
        which is used as a base class for most XAccessibleEventBroadcaster
        implementations.)
        
        Change-Id: Ib470d14f0c63bd262bb9ebf869c9b120c23236e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184785
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [77ffea4e5cdd3a7f99d4701c0d8fc39e30015b12]

        svx a11y: Drop extra indentation level
        
        Change-Id: I6be9558d858cc5b44a54e3db895bfd8e5c5bf1dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184784
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [f910df50341fbc0620fe2b73a4b3b350861716b0]

        sw a11y: Simplify nested if/else
        
        Change-Id: I77ba2f0e52427982527745e30d786d19e324446e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184775
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [04dd17b2495c5722f478896aa2fa7132cb26edaf]

        sw a11y: Use range-based for
        
        Change-Id: I41d0cdfa50d05a2bc132578b4980a30af218c435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184774
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-29  Patrick Luby  <guibmacdev@gmail.com>  [9947a9b7918c671deecd0265891206f3679dc5aa]

        tdf#163945 Decrease maximum Skia/Metal flushing rate
        
        In commit a24789f747dc998bd4fd1c0110a89e791ee051c2, the maximum
        flushing rate for Skia/Metal was set to 200 flushes per second
        but that caused tdf#163945 to reappear so reduce the limit to
        50 flushes per second.
        
        Change-Id: Iaab6236a6e54484e8a504d812a9bc5d00e1f6caf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184778
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [0096200a4bdffd052aeb43b40e5d538d20e9c044]

        ScQueryItem: no need to store a ScViewData pointer
        
        it can be passed by reference, like the other dialogs do
        
        Change-Id: I79abd717835012af8bcf8d4e135bd7e79f36ac35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184783
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b0a1ff82e4916825a5401ceefeac69ceb657433]

        ofz#396777453 avoid svmfuzzer Timeout
        
        Change-Id: Ia03404a18a12aeae829d9358700dc8c10ed4b0b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184782
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [210876c0f762e21a4004a8593fa0e19547fc56b5]

        Fix typo
        
        Change-Id: I25e04b9e5e5191b75789fb7bb804d73b8d6669d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184735
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36e5e2fa000534517cbe3d7270732db0a8400b0e]

        Fix typo in code
        
        Change-Id: I9a5841f07066504a8b5c585ae270d68b598b8d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184734
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f98d090a11a7f33cc15f4991b7bc1960b1098b98]

        Fix typo
        
        Change-Id: I9a33a4d24d2ed809220a675669c0c378ff3110d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184736
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-29  Patrick Luby  <guibmacdev@gmail.com>  [562a40f453caa003187ff28c7798647d9e0b4ded]

        tdf#144200 Add CFBundleSupportedPlatforms key with MacOSX as its only platform
        
        The necessity of including the CFBundleSupportedPlatforms key in an
        application that does not include the Intel architecture is described
        in the following post:
        
        https://github.com/microsoft/vscode/issues/121169#issuecomment-820653677
        
        The above post is quoted below:
        
        "Its just an issue with which attribute the storage info queries to
        decide the kind, the output of system_profiler SPApplicationsDataType -xml
        shows the arch_kind is arch_ios. I think these look for
        CFBundleSupportedPlatforms attribute and if not present default to the ios
        kind for arm64 executables.
        
        Given the universal and intel labels show up correctly, and considering
        the output of other apple silicon apps in the image posted. I don't think
        this needs a fix, but leaving it open for anyone to address as a good
        first issue."
        
        Change-Id: Ic96ce4407e060fbb0cb8c7b0b72dcf8f61dade19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184738
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [477689c58d842c718940c568616890179f5aac06]

        harfbuzz: upgrade to 11.2.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.2.0/harfbuzz-11.2.0.tar.xz
        
        Change-Id: Ib9910d1a9e1a657b1d26f05354a7213d48b85e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184761
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [b4965d0a7875384d1fedc7d43762c94b30e5e90f]

        Refactor getting thumbnail a bit
        
        Use OOXML package relations (and XRelationshipAccess) to access
        OOXML's thumbnails.
        Unify obtaining the bitmap.
        This change also fixes a possible nullptr dereference when trying
        to read the older Thumbnail/thumbnail.png - access to xDocStorage
        wasn't checked before.
        
        Change-Id: Iff9d85cb461960d2b11acaa008ba9ae69af475a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184750
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [82572ef097e78afd254136f617ae19748b7b409a]

        SwChildWinWrapper: simplify code
        
        Since SwChildWinWrapper::ReInitDlg doesn't have
        any parameter, the condition m_pDocSh != GetOldDocShell()
        is always false.
        
        Since
        commit 9f2a362ed67451cda56f89ad57bcaf2bc809b408
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Thu Sep 27 10:49:33 2007 +0000
        
            INTEGRATION: CWS swwarnings (1.4.222); FILE MERGED
        
        Change-Id: I2c42e813dce3a9cee067d00b81c488cf61569123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184707
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-29  Miklos Vajna  <vmiklos@collabora.com>  [ca7a6a57ad1e8d7aadffbbf3fe28d9aabed31286]

        tdf#166319 sw interdependent redlines: handle format on top of insert
        
        Open the bugdoc, the DOCX file has an insert with a format on top of the
        middle, but the format is lost in Writer.
        
        The first problem is that we tried to create an insert on top of format
        (while in DOCX the format is always inside the insert/delete), fix that
        by changing the order of redline creation in
        DomainMapper_Impl::CheckRedline(). The original motivation is no longer
        relevant after commit b3567d7e1f08df7c050d3cec86cbb200af558172
        (tdf#165322 sw: apply formatting for multiple redlines in SwRedlineItr,
        2025-02-25) Writer core to handle the rendering of format on top of
        insert/delete.
        
        The other problem is that in case we try to append a format redline on
        top of insert ("AB" is an insert and the format would affect "B"), then
        we simply deleted the (candidate) format redline -- change this to
        handle this similar to delete on top of insert.
        
        CppunitTest_sw_ooxmlexport8's testN830205 would now create an unsorted
        redline table on file open, so make sure SwDoc::TextToTable() resorts
        the table after splitting the redlines.
        
        Change-Id: Iada13204892ffccfe09bc2c28bf0c563db6e1ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184752
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-29  Simon Chenery  <simon_chenery@yahoo.com>  [d2d50dba5b41ebd1d4c848c48c9ec457d9efcd93]

        tdf#164954 replace German variable nBreite with English nWidth in op.cxx
        
        Change-Id: I286b15f178a76118189d4a57dfbe61ce641f38c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184667
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-29  Szymon Kłos  <szymon.klos@collabora.com>  [cbf068581024c4211393b37efd25189b809de184]

        lok: use unique ids in sidebar
        
        Panel was shared id in the past (we needed to be able to trigger
        refresh for initial mobile-wizard where no welding was done).
        So we needed the same id to catch any instance and do a full update
        of a sidebar.
        
        Now we have welding so we can use single widget as target
        and avoid sending full JSON on context change. Show/Hide
        panel functionality should be used now and thanks to that
        save some bandwidth.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ib564b608cb4de04185fb89832ad00bea9bcc10bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184717
        (cherry picked from commit 846d0465b4d7171b096bf19436bd53848d9f8bb9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184748
        Tested-by: Jenkins

2025-04-29  Jaume Pujantell  <jaume.pujantell@collabora.com>  [7881f4c18305a3e3b67a5f9f000a7999fe7647df]

        cool#11739 lok: sc: change dialog units per user
        
        On lok different users might have different locales so they need
        different field units in their dialogues. Right now the metric used is
        always the one stored in the ScModule's AppOptions for all users.
        With this change, for lok SfxModule::GetFieldUnit is used because it
        already has the correct metric per lok user.
        
        Change-Id: If2b047874a26deecc7c43936ab267b75eae101e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184567
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit d01737cb12654f488bb88235cdc562d3cf68d7db)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184741
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2025-04-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0229332b67d230cd3269969373fa3e747882f87f]

        Fix typo
        
        Change-Id: I14986be5bacde59207825b1bd239899ec070c6e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184733
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2025-04-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [51e8c19d6d30c659a7f3093736a0e2aa9cb1283f]

        Fix typo
        
        Change-Id: I85a2307ec15f67a6e799085a4f964fc2604469fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184740
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2025-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [d07f4c44cf022dbf9f3450c8adb15cb0c3ae4c34]

        Relationships have "Id" tag, not "ID"
        
        See ISO/IEC 29500-1:2016(E) 9.2 Relationships in Office Open XML:
        
        > ... a resource is referenced from a source part’s XML using the Id attribute
        > of a Relationship tag ...
        
        Change-Id: I3e2e8d3c1c82830c6b6037e9fb114a1a880ad6cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184747
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-29  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [3e1aa5805cb2339a55ffce0448e0b3b5d8efd3a6]

        tdf#137308 - Part 1: Refactor Inflater classes for extensibility
        
        Refactor ZIP decompression classes (Inflater, InflaterBytes) to support multiple decompression algorithms, enabling future Zstandard
        support.
        
        Make Inflater and InflaterBytes abstract base classes defining a common interface. Move the original zlib/Deflate logic into new derived classes InflateZlib and InflaterBytesZlib.
        
        Update usage sites to instantiate the *Zlib variants via unique_ptr to the base class, preserving existing functionality. Move header files to standard locations (include/package, package/inc) and update includes and build files.
        
        This pure refactoring prepares the codebase for adding Zstandard (zstd) decompression. Correct a minor logical bug in the ZipFile::getSizeAndCRC loop condition.
        
        Change-Id: I9be3c02946e29eb2dae09f500eb47d8a4261af22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183504
        Reviewed-by: Devansh Varshney <varshney.devansh614@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac6c7b4f826f053ce0ebe496b906a963c8c52342]

        ofz#409354664 Heap-use-after-free
        
        there is no DeInitVCL in fuzzing, so if the BufferedDecompositionFlusher
        thread is started nothing causes it to exit before _exit.
        
        Change-Id: I62463ce8126a0cf0c67f4218bdf66a140f3a021d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-29  David Hashe  <me@dhashe.com>  [b9054fed3724a19479e221a8b4818a127a18aabe]

        tdf#60700 Unit tests for saving image icons and accelerators
        
        For tdf#60700 we want to reduce the number of empty directories
        under Configurations2/ that are created on every new document,
        and we need tests to verify that the features that rely on those
        directories continue to work.
        
        My previous test at commit aaed16eef8b2d32ac02c8cb3a42ca25246cb0d33
        covers most of the directories, which are directly created by
        UIConfigurationManager. But Configurations2/images/ is created by
        ImageManager and Configurations2/accelerator/ is created by
        DocumentAcceleratorConfiguration, so we need separate tests for those
        in order to exercise the codepaths.
        
        This change adds those two tests.
        
        Change-Id: Ie34b540f0c59de3bbb871b71b956d3387eb852c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184646
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-29  knordback  <kurt.nordback@collabora.com>  [a94f960d8c14e6926d9e4eebf434d5ffc78c3ae5]

        tdf#165742 Step 4.2: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML
        and re-export.
        
        Fix some incorrect URLs and ordering of elements in a <xsd:sequence>.
        
        Change-Id: I4092e91851e80114d3cb8e22f602c33faf146969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183736
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-29  Justin Luth  <jluth@mail.com>  [9ba4c479d8f510cadf1c76bab5ced4b29745bc6b]

        tdf#166035 thumbnailview: recognize some MS-format thumbnails
        
        The sample I was given had thumbnail.emf.
        Using Word 2010, I generated a powerpoint presentation
        that had thumbnail.jpeg, and a spreadsheet that had thumbnail.wmf.
        
        I imagine that other formats could easily exist.
        But I don't know of a generic way to identify them,
        since there doesn't seem to be any special
        "this is where you find the thumbnail" pointer.
        
        Change-Id: Iad5281df3bdb79688eeecfd992da94ef5c3fa4d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184722
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-04-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [557348bda5d9ff68ea33deb8ac1d53d6a893b40c]

        vcl: convert TGA to use ImportOutput
        
        Change-Id: I4e30ac030863e987b9e817d068ed77e142b2fcbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184399
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-28  Ahmed Khaled  <gostahmedkhaled@gmail.com>  [8bbc6fa88a95357898150dbed9ea22a295a255ca]

        tdf#145538 Use range based for loops
        
        Refactor: Changed some loops to range based.
        
        Change-Id: I5d157e62e71f0ae6e13aaa7a8ffcc2ce3a5c527e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182818
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [95fe393ab804a170b71c6cd84ab74dbd5440ae9a]

        svx a11y: Move a11y code into corresponding block
        
        The Any variables here aren't relevant if a11y
        is disabled, so move them into the
        
            #if !ENABLE_WASM_STRIP_ACCESSIBILITY
        
        section, too.
        
        Change-Id: I87a7e171db43bfa7cf0ba9684b700266b4c2fd93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184727
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [8b9b77fde9af5430bdafd6c8abef9ac9123b3954]

        svx a11y: Report checked/checkable state for borders
        
        AccFrameSelectorChild is using an accessible role of
        AccessibleRole::CHECK_BOX and when the status/visibility
        of a border changes in FrameSelectorImpl::SetBorderState,
        an a11y STATE_CHANGED event was already sent for the
        CHECKED state. However, the CHECKABLED and CHECKED states
        themselves were never reported in
        AccFrameSelectorChild::getAccessibleStateSet.
        
        Extend AccFrameSelectorChild::getAccessibleStateSet
        accordingly to match the criterion used in
        FrameSelectorImpl::SetBorderState.
        
        The state now shows up as expected with the qt6 VCL plugin
        in Accerciser for the border's a11y objects in Writer's
        "Format" -> "Paragraph" dialog, tab "Borders" when
        one of the borders in the drawing area under the "User-defined"
        label gets selected in Accerciser's tree view of the
        a11y hierarchy.
        
        In addition, Orca now announces the state as well, e.g.
        "tick box ticked" when such a border receives focus,
        and toggling the state using the space key results in the
        new state getting announced ("not ticked"/"ticked" when
        using Orca with en_GB locale).
        
        Change-Id: Ia6dbe668a32829a94bc31726a434cad4ac1159cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184726
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [551d7191115a6c81cdb0c23e1cd18f35d986a585]

        svx a11y: Flatten AccFrameSelectorChild::getAccessibleStateSet
        
        Return early if `mpFrameSel` is null.
        
        Change-Id: Ica11e586c1e20b8466547a64050a12109d291208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184725
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [cb76ba02148d48a09aa0fd81303dd2fdeba3ed06]

        svx a11y: Don't duplicate frame selector a11y names as descriptions
        
        The strings in RID_SVXSTR_FRMSEL_DESCRIPTIONS used for the
        accessible description are exactly the same as those in
        RID_SVXSTR_FRMSEL_TEXTS which is used for the accessible name.
        
        That duplication doesn't provide any extra value (and might make
        screen readers announce the same thing twice), so just return an
        empty string for the accessible description instead.
        
        Those are used e.g. for the borders in Writer's
        "Format" -> "Paragraph" dialog, tab "Borders" for the
        single borders in the drawing area labeled "User-defined".
        
        Change-Id: I412ed482860fe1aecfc840b9c38491adf4f5b53e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184724
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [4cd6723a49ac3a07b59db97f1fd8e27b226e82f0]

        svx a11y: Drop "bFireFox as API parameter is ugly..." comment
        
        It was added in
        
            commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366
            Author: Steve Yin <steve_y@apache.org>
            Date:   Wed Nov 27 13:03:45 2013 +0000
        
                Integrate branch of IAccessible2
        
        and it's completely unclear what it refers to.
        Drop it.
        
        Change-Id: Iaf4bfddd531000d0abc77708b578a93b1fe79579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184723
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-28  Mike Kaganski  <mike.kaganski@collabora.com>  [6db63bb533a5c7436793eab86e83f92322b37044]

        tdf#166210: invalidate parent's size when hiding section
        
        Regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1
        
        Change-Id: I4469749c9ff3d9fae43f00e01276c241e7c49f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184720
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-28  Jean-Pierre Ledure  <jp@ledure.be>  [9671c73922754a94c1315cfe91d4d693f17b0850]

        ScriptForge (FileSystem) Title arg for PickFolder()
        
        Only Windows implements the Description
        property of the FolderPicker by displaying
        it in the dialog's header. Otherwise it
        is ignored.
        
        This commit harmonizes the behaviour
        among all environments, including Linux.
        
        The previous signature:
           fs.PickFolder(defaultdirectory, freetext)
        is replaced by:
           fs.PickFolder(defaultdirectory, title, freetext)
        
        The 'freetext' parameter is kept for backward
        compatibility. It becomes obsolete. When present,
        and 'title' is absent, its content is pushed
        to the dialog's title.
        
        The change is valid both for Basic and Python scripts.
        The documentation should be updated accordingly.
        
        Change-Id: I888ee4afa5046212081bbdedc849147ebda1a3bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184719
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-04-28  Karthik Godha  <me@karthikreddy.org>  [7ce5b485302802519068d5dd995e37a9f5d2ca47]

        tdf#166153 Fix width of HelpTip on mouseOver
        
        Fix width being too large for mouse over HelpTips
        in the navigator panel.
        
        Change-Id: I84479cd825299e9fbd809ed917b88cb873ebd0ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184347
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-28  Mohamed Ali  <mohmedali1462005@gmail.com>  [0d8f5429a0f4b1e9818c6d04502e08dbfeec3eba]

        tdf#45617 Make master slide copyable
        
        Added a new boolean option `bMergeMasterPagesOnly` to `InsertBookmarkOptions` to allow operations that only merge master pages.
        Updated various functions across the codebase to accommodate this new option, including `ForPaste`, `ForFileInsert`, `ForDragDrop`, and others
        Modified the `DocumentPageCounts` structure to include a count of new master pages
        Adjusted the logic in `insertAllPages`, `PasteBookmarkAsPage`, `ResolvePageLinks`, and `ImportDocumentPages` to utilize the new option for conditional merging behavior
        Updated UI components to pass the new parameter where necessary
        Enhances the naming logic for duplicate master slides, using a numeric prefix pattern (e.g., "1_MasterName") instead of simply appending underscores.
        Add unit tests for copying and pasting master pages
        
        Change-Id: If4167e846e5a747e1e1b194e3ced065a39f34ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182206
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b049163f0d3c418f3007a786d754b81a2973cdf0]

        ofz#406054647 Clear invalid AnchorPos
        
        in the absence of a straight forward idea to avoid it in the first place
        
        Change-Id: I73cf48445de4150282b1b7f9f4c78ad3a8cf9caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184715
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [248b826786e29c32ebdd2553d68adf240903977b]

        oox: read embedTrueTypeFonts and set doc. setting "EmbedFonts"
        
        Embed fonts depending if the attribute "embedTrueTypeFonts "on
        "presentation" element is set to true. If true, set the doc.
        setting "EmbedFonts" and start proceed with font embedding code
        path.
        
        Change-Id: Iba2552ab58c07cfa41afca4e1883ae706eb8c678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184403
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [faf45f80e1963534d72a60636836b816f6d27442]

        oox: import embedded font if it exists in impress
        
        The fonts are usually EOT fonts so this needs libEOT to work. The
        EmbeddedFontHelper takes care the conversion and make the font
        available in LibreOffice (which is then used automatically in the
        document).
        
        Change-Id: I96a9b968aaba4b8ee08fe67fb8551d34d55dd9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184287
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-28  Julien Nabet  <serval2412@yahoo.fr>  [89a4dff62ea9b571bbc37dad8e2e65846118994a]

        Related tdf#166241: add QA test in oox/qa/unit/CryptoTest.cxx for AES_192
        
        Change-Id: I283474a0a1bda243f7077b09376da2c2e6966949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184593
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-28  knordback  <kurt.nordback@collabora.com>  [dd8c544e6128e5d3454c006e00f8f48e5f59a1e0]

        tdf#165742 Step 4.1: Establish a narrow export path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML
        and re-export.
        
        Build out the some of the export structure for chartex charts. This now
        produces an output chartEx*.xml file with no c-namespace content, for
        funnel charts only, and what appears to be fully well-formed OOXML
        per the office/drawing/2014/chartex schema. However, MSO doesn't load
        the result successfully, so I'm calling it step 4.1.
        
        For the bulk of the output code in chartexport.cxx, there was a design
        decision whether to (1) have a single 'if (chartex) ... else ...'
        branch point high up, or to (2) branch much more granularly within the
        code. (1) has the benefit of cleaner reading, without so many ifs, at
        the expense of a lot of duplicated code. (2) allows for much less code
        overall but with lots of ifs. For the time being I've taken approach
        (2), not necessarily because it's the right one, but mostly because it
        is much easier to move from (2) to (1) (largely by just duplicating
        the code and in each large branch deleting the local branches that
        don't apply), than from (1) to (2) (which would require examining the
        differences between the two large branches in detail, in order to re-
        integrate the code).
        
        Change-Id: I78de1484359c358b99320b417ab68cd90dab3e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183561
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2d70d8a31194110380d6f8339480ec68f1197b0]

        cid#1646742 Dereference after null check
        
        Change-Id: Id159ca8de614671db51fafb0e487d4d4f4548fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [358c62e05f902eb601e00465b67154e30a42738a]

        cid#1646741 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5405517c5661bdd4c94b6d09dde9775ba9ac0f2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184702
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36d9217cb4c6288cbd14ce383fb14f3e67711f3f]

        cid#1646746 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6e0ef99fd8bf4240e9b79bc0fca0257d80419509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184701
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b092e7e647616907f3f0122383fd7e5be43c3c2]

        cid#1646747 Useless call
        
        since:
        
        commit e06c771f610c5f5bac983df3ebf5e9700f74bf08
        CommitDate: Fri Apr 25 07:31:34 2025 +0200
        
            sw a11y: Use SwFrame directly in SwAccessibleMap::InvalidateEditableStates
        
        Change-Id: Ibd84c8095b8e30ac77ca1f7d522b41a29e01bb0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184700
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fbbe5df1f7655203fb69f823aa605f3d9d4edd38]

        cid#1646745 Uninitialized scalar field
        
        unused
        
        Change-Id: If680564f64058a6e7ceb9aa08710210a6accb3ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184699
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d114f57ea58ea5133dad91b7671084ea8f77affc]

        Remove obsolete fw declarations from scaddins/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I742740e45a78286aaa30dc16e787e370e4e16cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183899
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [925be2132ef794036936d4ee45e9cc16f37de604]

        Remove obsolete fw declarations from scripting/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ie489c1dd7b682808d38dcb6e92ca49cbf391e08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183900
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [afaa1f0fadb89de8f93d9d3c24a34510f180b2ad]

        Remove obsolete fw declarations from reportdesign/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ib73a4a3f29d7707654ecb3bd84e9904f333c05ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183896
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-28  Miklos Vajna  <vmiklos@collabora.com>  [096a40b27d07603880bbf120440ac169a87fe115]

        tdf#166319 sw interdependent redlines: fix undo of del on top of ins
        
        Load the document, it has an insertion and that has an additional
        deletion inside the deletion. Reject the insert, undo, reject it again:
        only the first half of the insertion gets rejected, instead of the
        entire insert.
        
        Reading the doc model xml dump, the problem is that the deletion is on
        top of the insert (so the large insert gets split to 1) insert 2)
        delete-on-insert and 3) insert), and the SwUndoRejectRedline only tracks
        the delete for 2), there is no SwRedlineData in the action for the
        previous insert part of 2).
        
        Fix the problem by using SwUndoAcceptRedline in
        DocumentRedlineManager::RejectRedlineRange(), which fixes the
        inconsistency of commit 52fa7aed48632166e064e6a227e034f0981c4205
        (tdf#157662 SW: redline: accept/reject done for all parts, 2023-10-14),
        which used SwUndoRejectRedline + lcl_AcceptRedline() for the deletion
        inside the insert.
        
        This also means the custom depth is not needed for the created
        SwUndoAcceptRedline, again making the undo action and the actual action
        more consistent.
        
        Change-Id: I7f38854efa01b08ab4fc705d7bd976eaa585c3b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184695
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-28  Miklos Vajna  <vmiklos@collabora.com>  [be8b65e837af563730064bcf042f3039bd7560b7]

        svx: prefix members of SdrCaptionObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic4cd593ee3605e2c6194ec52e25d27e0e8455b93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184693
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-28  Julien Nabet  <serval2412@yahoo.fr>  [e77624db7f223ca1e487cea462e04a73efbc9f2b]

        tdf#166365: Crash in file picker, directory property (kf5/kf6)
        
        See bt from assertion here: https://bugs.documentfoundation.org/show_bug.cgi?id=166365#c1
        
        Let's do the same as Gtk3KDE5FolderPicker::getDirectory() in
        vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx
        
        Change-Id: Iaea4e4b916c30cc14d3959725922c73e9d161625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184691
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-28  Patrick Luby  <guibmacdev@gmail.com>  [b4eb737f07d85fcc583dffefb0d5489d859690ae]

        Related: tdf#165448 move parent window to front after closing window
        
        When a floating window such as the dropdown list in the
        font combobox is open when selecting any of the menu items
        inserted by macOS in the windows menu, the parent window
        will be hidden. So if there is a key window, force the key
        window back to the front.
        
        Previously, delaying closing of the window was used to avoid
        this bug, but that caused Skia/Metal to crash when the
        window was released before the delayed close occurred. This
        crash was found when rapidly dragging the border between two
        column headings side to side in a Calc document.
        
        Change-Id: I8511fe73e59c49f57d9179f5308e4b7a393809b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184690
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-28  Simon Chenery  <simon_chenery@yahoo.com>  [d9435d2759e78b716b64bfccdecaac3f3f1a0e4d]

        tdf#153294 simplify for loop to std::find call in ImplHelper.cxx
        
        Change-Id: I3bf6b955942c0ef5bf6ab4398b1a2f3103a0a133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183488
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-04-28  Ahmed Khaled  <gostahmedkhaled@gmail.com>  [d87694cf9396ec557031a93cc8b92b01720b69e0]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS()
        
        Change-Id: I327c2724b2212551c8f957b5b4c151e317094fa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183050
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-04-28  Simon Chenery  <simon_chenery@yahoo.com>  [5d5948cf5e8e65caa14e12ad4e7e90212fdc4a61]

        Fix comment "last 3 bites" to "last 3 bits" in op.cxx
        
        Change-Id: I3f99bcb542bf025a009b3299d36c660fb3b431a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184688
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [444f2f7d331464d9628b11f409a513b0458c5bae]

        qt: Make some QtFrame DnD methods non-virtual
        
        Change-Id: Ia38c86a15be846c844688e685329f4a32f4a0dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184679
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-27  Patrick Luby  <guibmacdev@gmail.com>  [a24789f747dc998bd4fd1c0110a89e791ee051c2]

        tdf#166258 Refactor throttling of Skia/Metal flushes
        
        Throttling of Skia/Metal flushes is needed for tdf#163945 but the
        throttling logic was being applied to too frequently. So throttle
        based on the time interval of the last Skia/Metal flush and if the
        flush is too soon after the last flush (i.e. 1/200th of a second),
        schedule the flush in the Skia timer.
        
        Change-Id: Ib4e526ec26ec8b8d36bf3a9776bfe49d153d759f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184681
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0b40671803327b78dbca901fa12214c7607301c1]

        Drop some copypaste errors
        
        Also, aHighlightChangedTimer was already stopped above.
        
        Introduced in commit f89b9d8b8064a2f323f5b3362f88cb873bad8fcc (Resolves:
        tdf#100248 vcl menu scroll timer still active post dispose, 2016-06-09).
        
        Change-Id: I6969163f723b2a381fd5d595264bd6ed4012342b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184680
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-27  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [109e9d6a61a540fde0b0146cb5114ff87594fb21]

        Remove obsolete fw declarations from package/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I00bb2b3216bbd171bed6b71565876e6f60ccc083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183895
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-27  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b94cf8f15aa3c55805f9c0a5d926f11593dd83cd]

        Remove obsolete fw declarations from sc/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I04083a33ce1e7d85980da91f72c2dd85777b594d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183897
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-27  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d29f6a2dd7e695f54cd22edd404372795f21866e]

        Remove obsolete fw declarations from sal/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: If0ab8906d469f70e3805efd98cf1da8589d55012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183898
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [23567fe2db2cefd934f971596c9cdc8835562889]

        tdf#130857 qt weld: Make disabling tree view sorting work
        
        Set the QSortFilterProxyModel's sort column to -1 to
        disable sorting. Quoting from the QSortFilterProxyModel::sortColumn
        doc [1]:
        
        > Returns the column currently used for sorting
        >
        > This returns the most recently used sort column. The default value is -1,
        > which means that this proxy model does not sort.
        >
        > See also sort().
        
        It not working triggered a crash in SwGlossaryDlg::Init
        in a WIP branch for supporting the "Tools" -> "AutoText"
        dialog in Writer, because the QModelIndex set in the QtInstanceTreeIter
        returned as out param when inserting the item did not match
        the one in the sorted model when used later, and the `pData`
        in
        
            GroupUserData* pData = weld::fromId<GroupUserData*>(m_xCategoryBox->get_id(*xSearch));
            if (!pData->bReadonly)
        
        would be null.
        
        (Whether that needs additional work to make sure that a valid
        iterator is still returned for the case where sorting is enabled
        may still be a valid question to be asked separately, in particular
        if any similar issue shows again in the future.)
        
        [1] https://doc.qt.io/qt-6/qsortfilterproxymodel.html#sortColumn
        
        Change-Id: Ibcb8e4318ecc85494141f75644955d26278dec9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184678
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [0361f96e463e3db7d771fd9a30e3ae27b5a94ee8]

        tdf#130857 qt weld: Implement QtInstanceTreeView::iter_*
        
        Implement methods to get previous/next sibling, parent
        or first child.
        
        Change-Id: Icc32b980b595f23d727f0563afdad9e42a05d2b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184677
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [873e22528cf6749520fb7f03f58c4f52fbb9dc03]

        tdf#130857 qt weld: Implement QtInstanceTreeView::get_iter_depth
        
        The implementations in GtkInstanceTreeView::get_iter_depth
        and SalInstanceTreeView::get_iter_depth suggest that
        the iter depth for top-level items is 0 (not 1), so implement
        it likewise.
        
        Change-Id: I61d9700ddd47d2088823c6440d5a8c0d5194a1f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184676
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [8e5b08ad0e7c7c2e470f2dc927427eb620ce6dcf]

        tdf#130857 qt weld: Ensure tree view col count is same on all levels
        
        Other than GtkTreeModel, where the same columns are always
        used on all hierarchy levels, QAbstractItemModel allows
        that to differ on each level/for each parent.
        
        This was seen causing a crash in a WIP branch experimenting
        with adding support for the "Tools" -> "AutoText" dialog
        because
        
                const QModelIndex aIndex = modelIndex(nPos, 0, aParentIndex);
                QStandardItem* pItem = itemFromIndex(aIndex);
                if (pStr)
                    pItem->setText(toQString(*pStr));
        
        inside QtInstanceTreeView::insert would result in
        trying to retrieve the index/item for column 0
        when there were actually no columns in the model
        for the non-top-level item.
        
        Make sure the amount of columns matches by inserting
        them when there are none yet.
        
        Change-Id: I3bca4eb2e036e682298db7a205279bfddf0e8805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184675
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [c059fc8ab8b1641faddd5746efc9c887540c4f2e]

        tdf#130857 qt weld: Keep col index in QtInstanceTreeView::copy_iterator
        
        The model index retrieved via QtInstanceTreeView::modelIndex
        may have an adjusted column number if the toggle button
        feature is enabled.
        
        However, if copying an iterator, the copy should
        be equivalent to the source, so use the unmodified
        QModelIndex from the source instead.
        
        While the weld::TreeIter as used in LO doesn't have
        a concept of columns but references a row
        (and the column index is passed as an extra param
        to methods where needed), not modifying the column
        set in the QModelIndex can still be relevant as
        QtInstanceTreeIter::equal directly compares the
        model indices of the two iters, so the copy
        wouldn't be considered equal if the column index
        is different.
        
        Change-Id: I3050daf17e7453cc62b1071647527ce888fd8a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184674
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [e51e4438b4c7c05de08048f82870ff46f3a54c50]

        tdf#130857 qt weld: Support non-top-level TreeView items
        
        Drop the assert on `pParent` being null in
        QtInstanceTreeView::insert and instead implement
        handling for parent items.
        
        In most of the cases, the corresponding QAbstractItemModel
        methods have an optional (defaulting to `QModelIndex()`)
        param to specify the parent. Pass that param instead
        of using the default.
        
        This builds on top of this previous commit whose
        commit messages has some more details:
        
            Change-Id: Id829ce3a1052f0d8915f0b03a0b0786e2f3586dd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Apr 26 17:00:01 2025 +0200
        
                tdf#130857 qt weld: Move TreeView method logic to overload for iters
        
        Change-Id: Ibb1a119e3fc6f0fa878babbe526990df42d78336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184673
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [ed8a7a64a7f4d86c02dc3d3080179a6c80aa38db]

        tdf#130857 qt weld: Move TreeView method logic to overload for iters
        
        weld::TreeView has a lot of methods that have two overloads
        where one takes a row index and the other takes a weld::TreeIter.
        
        In order to have to implement the logic in only one place,
        QtInstanceTreeView so far implemented the logic in the
        overload taking the row index, and the overload taking the
        weld::TreeIter would forward to the overload taking the row index.
        
        This was fine so far. As long the hierarchical structure of
        "actual" trees wasn't supported and all instances of
        QtInstanceTreeView where therefore just tables where
        all tree view items are top level items (s.a. the assert
        on `pParent` being null in QtInstanceTreeView::insert).
        However, in order to support non-top-level items, i.e.
        items that are children of other items, the approach
        needs to change because the row-index based overload
        only handles top-level items while a weld::TreeIter
        can also represent non-toplevel items.
        
        In order to prepare for that, switch the approach to
        be the other way around: Move the logic from the overload
        taking a row index to the overload taking a weld::TreeIter
        and let the one taking a row index call the one taking
        a weld::TreeIter instead.
        
        Introduce new helper method QtInstanceTreeView::treeIter
        to retrieve a TreeIter for a given (top-level) row index
        and adjust/add other helper methods as needed now.
        
        While at it, already start passing the QModelIndex::parent() [1]
        as an additional param to some of the called methods
        (instead of using the default, which would indicate
        they are top-level items).
        While this doesn't make any difference yet (as long
        as all items are top-level items), it helps prepare
        for supporting non-top-level items in the future.
        
        No change of behavior in any of the already supported
        dialogs is intended by this change.
        
        [1] https://doc.qt.io/qt-6/qmodelindex.html#parent
        
        Change-Id: Id829ce3a1052f0d8915f0b03a0b0786e2f3586dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184672
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [59c49d566c1f491df97422dfb8bfc1102442d576]

        tdf#130857 qt weld: Implement QtInstanceTreeView::{g,s}et_sort_order
        
        As for the sort column, sorting by a certain sort
        order sets that sort order to be used in the future
        as well. Quoting the QSortFilterProxyModel::sortOrder
        doc [1]:
        
        > Returns the order currently used for sorting
        >
        > This returns the most recently used sort order. The default value is Qt::AscendingOrder.
        >
        > See also sort().
        
        This will be used e.g. in  Writer's "Tools" -> "AutoText" dialog
        once support for its .ui file (sw/uiconfig/swriter/ui/autotext.ui)
        will be declared in QtInstanceBuilder::IsUIFileSupported.
        
        [1] https://doc.qt.io/qt-6/qsortfilterproxymodel.html#sortOrder
        
        Change-Id: I4e569fde909188a1712eff45652772c95105d5d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [c063d46fdfdae38344ce3531d7491857c99123e0]

        tdf#130857 qt weld: Add SolarMutexGuard
        
        Change-Id: I190e865e2ea24ccc29bb7cbe1197472c16e4d259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184670
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [7b1f65f3f1b570cc497deec8e5412b90eee6555b]

        tdf#130857 qt weld: Suppport separator menu items
        
        Implement support for "GtkSeparatorMenuItem" objects
        in .ui files.
        
        This is used e.g. in Writer's "Tools" -> "AutoText" dialog
        (.ui file: sw/uiconfig/swriter/ui/autotext.ui) which
        isn't supported by Qt weld yet.
        
        Change-Id: I506ad2627a174b5a48c256c5c9bce11189a95497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184669
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [16745d0b793b61d5719085c04eca8741d815865a]

        crashtesting: .doc output of ooo74516-1.odt cannot be reloaded
        
        allow a larger starmath parse depth to accept this document
        
        Change-Id: I2b912be98958efb351de4cdc9f916831e70cf42d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184668
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-26  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [36aed19e5e96b903f95d2cc782454c9d601f0b94]

        tdf#164970 themes code cleanup, remove unneccessary assignment statements
        
        Change-Id: I1377794519e1b3781b48ed13d2f7f6887e8f9d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184392
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-26  Noel Grandin  <noelgrandin@gmail.com>  [07a3dd72f3eb79c03297aa9af9d77326b07458b6]

        no need to call Width/Height on every iteration of loop
        
        Change-Id: If4615e004ad78936cfbafcad66e78dd66051d32f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-26  Jean-Pierre Ledure  <jp@ledure.be>  [59f8fd6a5cc2534c84c56265821b51a832652cdf]

        ScriptForge (UI) review progress bar termination
        
        Idem https://gerrit.libreoffice.org/c/core/+/184662
        for the progress bar.
        
        Change-Id: Ife48d115d3e8acb81fe167a27542783f4ca25d25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184665
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-04-26  Jean-Pierre Ledure  <jp@ledure.be>  [e803595fc4ab0ad583a056e05e5efae0b24707e8]

        ScriptForge Don't watch close button of stored dialogs
        
        Dialogs can either be stored in a library
        or created from scratch.
        
        When run in non-modal mode, the closing of
        a stored dialog with the Close top-right cross
        is done by LO correctly.
        
        When the dialog is created from scratch,
        a coded XTopWindowListener should do the job.
        
        So far, the listener was activated for all dialogs.
        
        Additionally the Console is a stored dialog.
        When closed and relaunched, the processing
        will now handle the window Close and
        the built-in Close buttons identically, at
        least apparently.
        
        Change-Id: I29e0881989816fbf7e3e8bd12f59517bde4b3047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184662
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-04-26  Simon Chenery  <simon_chenery@yahoo.com>  [44f182a0e03a735fa0406980cd1161f9da9799b4]

        tdf#148251 use std::swap in indexentrysupplier_default.cxx
        
        Change-Id: I49cf4433fd0171d6e95d0c8c8cf5ae2d40b62614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184416
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Devansh Varshney <varshney.devansh614@gmail.com>

2025-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f16e96920463348570ad268150d1fccd75d527b]

        ApplyAutoFilter: pass ScViewData by ref
        
        Change-Id: Ie65b3347fcfad7ba3be2af48dc73e06c027231dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184659
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [08ecccdab71b58cef6aa8b2ee8b0451ad8e562de]

        ScShareDocumentDlg: pass ScViewData by ref
        
        Change-Id: I6308802006c957a693db88746692a8dc63e53026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184658
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [e4fb32ffef1630ceaf5a0a77307e02ae93c9f8f4]

        ScCornerButton: pass ScViewData by ref
        
        Change-Id: Id76186f6eb1d59f101273dc3d97fde1265c3e0ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [d37739f961375a39845fa1449c323d18b788bffe]

        tdf#130857 Define widgets in "Select Paths" dialog in order
        
        Switch the order in which the widgets in the .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Path" button.
        
        Change-Id: I8502b32bba9cf7ea6bb420630ba9c80599decd7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184653
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [89afe6ad2418675f01351d54ef757c83e1611553]

        tdf#130857 qt weld: Support "Select Paths" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Path" button.
        
        Change-Id: I9bcf5253e80e2740151dc801bcd326df09529699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184652
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [eedf1e727cdf7106291b2af852d83540009090ea]

        cui: Resave selectpathdialog.ui with glade 3.40
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Path" button.
        
        Change-Id: Ib86d3d6d827da27f2c0c88b94ea71cdd9f3ed4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184651
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [79bd0519fcfda31c183ddcda9fd01d46107a8afd]

        tdf#130857 qt weld: Don't multi-select tree items in single sel mode
        
        Regardless of what selection mode is set for the tree view
        displaying the model, QItemSelectionModel::select
        adds to the selection and doesn't clear the previous one
        unless the QItemSelectionModel::Clear flag is passed.
        
        As a consequence, multiple tree view entries could be
        selected after QtInstanceTreeView::select was called.
        
        Prevent that by explicitly passing the
        QItemSelectionModel::Clear flag if the tree view
        is in single selection mode.
        
        Prior to this change, multiple entries were e.g. selected
        for the following scenario:
        
        * start Writer
        * "Tools" -> "AutoText", click "Categories" button
        * in the dialog, add various new categories by
          typing text in the "Category" edit and clicking
          the "New" button
        
        Behavior without this change in place for qt6 with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1: All newly
        added categories would be selected at the same time.
        
        Behavior with this change in place: Only the last selected
        category is selected. This matches the behavior of other
        VCL plugins.
        
        Change-Id: I286b1e17b33d686553ae7c1533f07028b73bdfe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184650
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [bad507e7bcb050621acc1b61b0fc8ba1de539f90]

        tdf#130857 Define widgets in sw "Edit Categories" dialog in order
        
        Switch the order in which the widgets in the .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Categories" button.
        
        Change-Id: I2ce55680902895171d5655b9e2c90275a492d3ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184649
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [e61fcdec4d35cce45b32ea8ca1f6b7007721f156]

        tdf#130857 qt weld: Support AutoText "Edit Categories" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Categories" button.
        
        Change-Id: I4936591068ad1cac1a5ca3b1fef1405109258637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184648
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [00bf583504252c48e63206795422cc2d6fc1d95d]

        sw: Resave editcategories.ui with glade 3.40
        
        To trigger the dialog in Writer:
        "Tools" -> "AutoText", click "Categories" button.
        
        Change-Id: Ic718173aa1c8a468af963ac28381d2c0bcecfb9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184647
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [648d97619c921d2f94a91e2932712063ca37646f]

        Fix tar extraction issues when running as root
        
        Following up on 20b48ed9e311c529dcce46b31ed0d986ed7e3ed4 "Fix check-if-root for
        github.com/flathub-infra/vorarbeiter", the next issue those new github actions
        based flathub test builds run into is
        
        > tar: configure: Cannot change ownership to uid 1000, gid 1000: Invalid argument
        
        etc. from the various UnpackedTarball targets.  The reason is that at least GNU
        tar 1.35 defaults to --same-owner when run as root.  I hope the --no-same-owner
        countermeasure is available on all the GNU and BSD tar versions that we care
        about (it is at least supported by /usr/bin/tar bsdtar 3.5.3 on macOS Sequoia
        15.4.1).
        
        Change-Id: Ie9a17856f9bca752817d914e6dd1b9cb2b5ea699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184645
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [0799e55b3d57b8872d363b5ea81e6f89b75d0f4a]

        ScOutlineWindow: pass ScViewData by ref
        
        Change-Id: Iea4da0879bfc281cdb430bec3285a1a5c2da4bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184633
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b09a4bfc1e39a9f9a049c98c3ebc02edb4d4a8e]

        ScQueryItem: always pass ScViewData from caller
        
        Change-Id: I02c061ecf4316907a020e1324c606ea53da7b8a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184630
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [d58487de929fef9ea02c1a835923331161696bad]

        qt/kf/gtk3_kde5: Merge FilePicker_getSupportedServiceNames into callers
        
        Change-Id: Id83690b974c76e3a1feaac345b6145f3ea384f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184637
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [f84c93ca74c515d45aa6627a0e834ab755a64cc3]

        qt: Drop unused includes
        
        Unused since
        
            commit edc9277e0f8de3f32502db41a3167ce03fff2b50
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 25 15:19:57 2025 +0200
        
                tdf#166334 qt: More reliably detect native file dlg parent
        
        Change-Id: Ie61f9883a3e8c47a6ea1bd096b21f9bb218c067b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184636
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [f8a39e7c8bc09627bfe360c8cd1242c0e9666823]

        sc: pass ScViewData by ref here too
        
        Change-Id: Id21b9e901502dc2c589ef6ee22105e883b3c5f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184634
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Noel Grandin  <noelgrandin@gmail.com>  [30563605dd78f23cc832c6cd426c0f76576ab47d]

        tdf#165595 no need to call Width/Height on every iteration of loop
        
        Change-Id: I78a2d1069ccfeafad6be298b9730fa4e72d7df8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [476b851d00b1b5ca380b86cabce842f475b38677]

        ScPrintFunc::DrawToDev: pass ScViewData by ref
        
        Change-Id: Ia7e0b8e4c56ecfc9525ac45bfdb3d4304877e4c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184632
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [79daee261818e6f2919c10ef9c698d66e6fa9c6f]

        ScSortItem: always pass ScViewData from caller
        
        Change-Id: I95b273bebed032a3acb0bdca0e1ae30d0e98600d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184631
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [138f0a92f8c5ed300248b37fbff2a07e31596825]

        ConditionalFormatEasyDialog: pass ScViewData by ref
        
        Change-Id: I38db0341403c0e2fbf147d57dfbe956938e7f8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184628
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dfbdb858e2e584f7a557a45e4ad315dc5a3bef57]

        Instead of warning and failing, just do the right thing
        
        After df83ad933b11e973855d66792c9aff38714f9201 "fix harfbuzz build with
        --enable-python=fully-internal on linux", my --enable-python=fully-internal
        Linux builds that auto-detect MESON=/usr/bin/meson started to emit a configure
        warning
        
        > * WARNING : using internal python with a meson launcher might not work, best to use MESON=/path/to/meson.py in autogen.input
        
        and then fail to build ExternalProject_harfbuzz with
        
        > Traceback (most recent call last):
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 563, in from_name
        >     return next(cls.discover(name=name))
        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        > StopIteration
        >
        > During handling of the above exception, another exception occurred:
        >
        > Traceback (most recent call last):
        >   File "/usr/bin/meson", line 33, in <module>
        >     sys.exit(load_entry_point('meson==1.7.0', 'console_scripts', 'meson')())
        >              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/usr/bin/meson", line 22, in importlib_load_entry_point
        >     for entry_point in distribution(dist_name).entry_points
        >                        ^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 982, in distribution
        >     return Distribution.from_name(distribution_name)
        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 565, in from_name
        >     raise PackageNotFoundError(name)
        > importlib.metadata.PackageNotFoundError: No package metadata was found for meson
        
        So better add back the idea from 736998ccef0bacdd2bbf038c98dacfbe654f1a4d "Only
        run meson from python when it apparently needs to be" (that had been removed
        with df83ad933b11e973855d66792c9aff38714f9201 "fix harfbuzz build with
        --enable-python=fully-internal on linux") to treat a Meson executable that
        doesn't advertise itself as being a Python script as just any plain executable,
        which we don't throw at our --enable-python=fully-internal interpreter.  (Just
        like, say, an Emscripten build of LO uses an emcc compiler executable that
        internally uses Python, and onto which we don't force our
        --enable-python=fully-internal interpreter, either.)
        
        Change-Id: I13965ef08043f350e9614bd61a469708b7faf27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184626
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [edc9277e0f8de3f32502db41a3167ce03fff2b50]

        tdf#166334 qt: More reliably detect native file dlg parent
        
        QtFilePicker's XWindow parent can be either a QtXWindow
        when native Qt widgets are used, see
        
        commit 429b08357e0c904d8096ff5830d844a199cd59b0
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Fri Feb 21 23:48:47 2025 +0100
        
            tdf#130857 qt weld: Introduce QtXWindow
        
        , or a VCLXWindow when vcl::Window is used.
        
        Use a different approach for retrieving the native
        QWidget parent for the file dialog for the VCLXWindow
        case:
        The previous low level handling involving
        resolving the window handle can be problematic
        in particular on Wayland and is therefore refused with
        Qt 6, see
        
            commit 2f4103da5625a9b90eb41d5c767a248a8d0b4255
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 17 17:02:49 2024 +0200
        
                tdf#160565 tdf#145735 qt: Avoid native window handles for Qt 6
        
        . Instead, use UnoWrapper to get the underlying
        vcl::Window and then logic similar to the one in
        QtInstance::GetNativeParentFromWeldParent to
        get the corresponding top level QWidget/QtMainWindow
        from its QtFrame.
        
        On Debian testing with qt6 on Wayland, this commit causes
        the main LibreOffice window to be properly grayed out and
        the file dialog always staying on top when using "File" -> "Save As",
        while that was previously not the case. (With
        QT_QPA_PLATFORM=xcb, the main window was greyed out,
        but the dialog didn't open centered on top of it.)
        
        An alternative solution to make that scenario work
        as expected would be to ensure that a QtXWindow is used
        instead, by implementing a QtFrame::GetFrameWeld
        override that returns a QtXWindow as follows,
        similar to what the gtk3 VCL plugin does:
        
            weld::Window* QtFrame::GetFrameWeld() const
            {
                if (!m_xFrameWeld)
                    m_xFrameWeld.reset(new QtInstanceWindow(asChild()));
                return m_xFrameWeld.get();
            }
        
        While this works just fine for that scenario, the problem
        about this approach is that all dialogs that are not native
        Qt dialogs yet (s. tdf#130857 for Qt welding) cannot handle
        the QtXWindow parent, so they would not have a proper parent
        set and thus dialog modality wouldn't work properly for these
        cases then.
        This would e.g. affect the "Format" -> "Paragraph" dialog
        (and many more) even with SAL_VCL_QT_USE_WELDED_WIDGETS=1
        set.
        
        Therefore, it would be premature to do that - at least unconditionally -
        at this point in time.
        
        Change-Id: If9ee1de461e3a2f0848e349fdddf0c23ee22cbc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184625
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [c03d752c614b3b19ed89a510d7791bc46604a452]

        improve fast_pow in BColorModifier_gamma
        
        And add tests to demonstrate accuracy.
        
        This is taken from
           https://martin.ankerl.com/2007/10/04/optimized-pow-approximation-for-java-and-c-c/
        and results in a maximum error of 3% over our input range.
        
        Change-Id: I1568dabb552d52a3eff085fd327ed3c1c246edcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184623
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [998ab8266aaa57079add1cdd9467cc52655795b0]

        ScPrintAreasDlg: pass ScViewData from the caller
        
        like the other dialogs do
        
        Change-Id: I584a2dc7e347a31c4b627d97277b9ab0207b7ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184627
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [21b025b0cb8614a86a3d3a7fd3ffdfff4e1fa0eb]

        sc: pass ScViewData by ref in some places
        
        it's always non-null.
        
        Change-Id: I0ac888c6d4e40a9de59c8b6136dd3be8c3ec3770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184624
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d80de8925edf6ab38ec48967199b9ea29bb2f6ee]

        harfbuzz with fully-internal python: extend the chmod to all python scripts
        
        depending on the meson version also other scripts like
        src/relative_to.py are run and cause the same problem (namely picking up
        system python instead of the python meson was run with, see description
        of df83ad933b11e973855d66792c9aff38714f9201 / the commend in the
        makefile for more details
        
        Change-Id: I2c75d9a12455495174be7c53a1cca5d5a8f45f8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184622
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [dbab729bca8f5d6e9a14df6c58a1a4593edbcebe]

        sw a11y: Use range-based for
        
        Change-Id: I05314d7852e1d5856ca7b10bffd7254e36b659d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184608
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [d8ec0cba9b064c8f3ca81fe41e30c7107dd175de]

        sw a11y: Drop commented out code
        
        Commented out since it was added in
        
            commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba
            Author: Steve Yin <steve_y@apache.org>
            Date:   Fri Nov 29 13:03:27 2013 +0000
        
                Integrate branch of IAccessible2
        
        At first glance, this also looks like it might
        rather be relevant for the SwAccessibleChildMap
        below, not the SwAccessibleChildMapKey in which
        the comment is located. (?)
        
        Change-Id: I04139845c27118cc564b01e873b6e3d1d6df7751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184607
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [9e7f4c95e4c232c0ea7c7108e996215019431a14]

        sw a11y: Drop SwAccessibleChildMapKey::m_nPosNum
        
        The ctor initializes it to Point(0, 0), and it's never
        changed afterwards. Since it's always the same, it is pointless
        to compare whether it differs for different objects
        of that class.
        
        Change-Id: I9db440faf18a6abbb1ccedbc7d4724a9d0e8684d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184606
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [8d382bc373d38827bbc6af9cb02d51af0bdd8a5e]

        sw a11y: Return vector instead of using out param
        
        Change-Id: I23ef959b5744d1730f3937b876a0ceb187096d2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184605
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [5d44a4d0f7dca219ab9ddafdca7221d3a9914a05]

        sw: Rename IsAttrAtPos::Ftn -> IsAttrAtPos::Footnote
        
        Make name less cryptic. See also
        
            commit 441e51dcfdcf7263cc945928bc4da24211c44bea
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 13:03:23 2025 +0200
        
                sw: Rename SwFrameType::Ftn -> Footnote, FtnCont -> FootnoteContainer
        
        doing the same in another enum class.
        
        Change-Id: Iddc35b2bb14dd177a910187e75e9c0635076aeeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184601
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [2576655cd1abdf33daaa8b739e9bb3da3a061dad]

        sw: Use constexpr instead of #define for SwFrameType combinations
        
        ... and address loplugin:redundantfcast warning
        
            /home/michi/development/git/libreoffice/sw/source/core/layout/wsfrm.cxx:3380:39: error: redundant functional cast from 'const SwFrameType' to 'SwFrameType' [loplugin:redundantfcast]
             3380 |                                    : ~SwFrameType(FRM_NEIGHBOUR);
                  |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
            1 error generated.
        
        Change-Id: Ie497b15a4e94ebd8aa59156446785ee00fba8a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184600
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [599a6d699291142b87b1ada7af70e346a7dd2146]

        sw a11y: Split complex expression in SwAccessibleChild::IsFrameAccessible
        
        As suggested by Noel in [1], split the complex expression
        to make this easier to read.
        
        [1] https://gerrit.libreoffice.org/c/core/+/184579/comment/8f62b3a9_7e13e6cd
        
        Change-Id: Ie52144b695a0294327c0681ad1e5197fa43cc334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184599
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6bef55d650d5221f2b86dcd0116d8db7ebe79a4]

        rename ReferenceMarkerName to SwMarkName
        
        as per vmiklos request at https://gerrit.libreoffice.org/c/core/+/184192/comment/dcdeab88_b56fb1ce?usp=email
        
        Change-Id: I57883da79db3ffb9c2f0e5c1ca3eaa535610eb7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184615
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [20b48ed9e311c529dcce46b31ed0d986ed7e3ed4]

        Fix check-if-root for github.com/flathub-infra/vorarbeiter
        
        Pushing PRs to <https://github.com/flathub/org.libreoffice.LibreOffice> used to
        trigger test builds on <https://buildbot.flathub.org/#/>, but has apparently
        changed recently to triggering test builds on some github actions based
        infrastructure, which then failed our check-if-root (see e.g.,
        <https://github.com/flathub/org.libreoffice.LibreOffice/pull/323#issuecomment-2829465141>),
        because systemd-detect-virt is apparently not available in those containers.
        But those containers apparently do have container=flatpak in their env, so add
        back the check for that from e19b67dcf5e987e58ce4252d8d1c8313d111df85 "allow
        building as root inside a container without complaint" (which had been removed
        by 1eb18361783a25e6c70a94564d55d4e2db7586dd "use systemd-detect-virt to detect
        building as root in container").
        
        Change-Id: Ib3cc5911826644ddfb4a9b6afb0da653c0546a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184614
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-25  Miklos Vajna  <vmiklos@collabora.com>  [53773d52ed1d3ff2ee9dddb0e9c4e8c64d334720]

        sw doc model xml dump: show SwUndoRedline and SwRedlineSaveDatas
        
        I have a redline problem where the undo of reject doesn't restore all
        SwRedlineData of a SwRangeRedline; dumping these help deciding if the
        undo action is already created with the wrong info or just its execution
        is buggy.
        
        Change-Id: I19068e036e3eb421a6b4118d31095138eced5122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184613
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [61760b4c5dbdadf008899f0776962e0f17e48bb7]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 504b17e7d0909231782a9ad7a882a151118f8ab5
          - upgrade Ukrainian dictionaries to 6.6.1
            
            Downloaded from https://github.com/brown-uk/dict_uk/releases/download/v6.6.1/dict-uk_UA-6.6.1.oxt
            
            Change-Id: I81b3ca1efa2ea666257c97af5f1f09a555e7f868
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/184619
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [e32fbddc99cb848fd3609f695ea2296678231d79]

        libgpg-error: upgrade to 1.55
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.55.tar.bz2
        
        Change-Id: Ia7592c071caedcfb4fb75b9516f44932000f2567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184611
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [42568a90c5cee26c2d08cc8513d8379f97e1310a]

        sw: fix warning C6011: Dereferencing NULL pointer 'pUpper->Lower()'
        
        Change-Id: Ibb60f4109f6da3c8feb2d046b7f15c541e5f3b9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184604
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-25  Noel Grandin  <noelgrandin@gmail.com>  [ae8d0bb2d559bdae981ed2bfa0265d9cea11c1e1]

        simplify SalBitmap SystemDependentDataHolder usage
        
        given that we are largely caching SalBitmap here, and none of the subclasses
        want to do anything more sophisticated, we can do the implementation in
        the base class.
        
        Change-Id: I5211933e9a431c8ff46625ef30666c89106ce7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-25  Mike Kaganski  <mike.kaganski@collabora.com>  [07e3981685b0ed0db5ef353ea41b5a17fbcfc9f4]

        Simplify default ctor calls
        
        Change-Id: I7a9df9d0b81840549de945f94efbffe69bd430f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184603
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-25  László Németh  <nemeth@numbertext.org>  [5a48070f5904c51dc9e7bbad4213d802fd4bc89b]

        tdf#126154 sw offapi xmloff cui: add min/max word spacing
        
        To avoid of rivers and too much hyphenation, add minimum
        and maximum word spacing options, similar to XSL-FO/CSS
        and DTP software.
        
        Only limiting hyphenation was implemented: hyphenation
        of the words are disabled, if it's possible to expand
        or shrink the spaces of the line within the values specified
        by the maximum and minimum word spacing. First try to apply
        the minimum word spacing, and if not possible, then the
        maximum word spacing.
        
        Note: maximum allowed shrinking has been applied for the
        hyphenated lines instead of the minimum to remove the
        hyphenation, yet. With the suggested default word spacing
        values, this results no or minimal differences.
        
        New UNO paragraph properties:
        
          com::sun::star::text::ParaWordSpacingMinimum
        
          com::sun::star::text::ParaWordSpacingMaximum
        
        New ODF paragraph attributes:
        
          loext:word-spacing-minimum
        
          loext:word-spacing-maximum
        
        New paragraph settings on Text Align pane:
        
          Minimum word spacing
        
          Maximum word spacing
        
        While the desired word spacing got "Desired" label.
        
        Note: suggested values of minimum, desired and
        maximum word spacing are 80%, 100% and 133% (default
        values e.g. in Adobe InDesign), in narrow columns e.g.
        60%, 100% and 150%.
        
        Follow-up to commit 7d6696757dcdfa3cee481ac7795a91b2b47da363
        "tdf#159923 sw cui offapi xmloff: add custom word spacing".
        
        Change-Id: I7f2a07f7fdb634cb16cdd8c2c937ca911b968405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184595
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-04-25  Noel Grandin  <noelgrandin@gmail.com>  [23e158e4c35a9f548010827adfccccd70d1928f6]

        tdf#165595 speedup BColorModifier_gamma
        
        which shows up heavily on this profile. In this case we don't
        need perfection and we can use a fast approximation for std::pow.
        Thanks to the binary representation of float numbers, this new
        code reduces to some basic bit-twiddling.
        
        Change-Id: I064588f65cf8f5973ba45545fba9c5fe66500e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-25  Mike Kaganski  <mike.kaganski@collabora.com>  [feca6f01456e3a01695ed61a79a791a5b0b6e5ba]

        These methods should not be static
        
        Change-Id: Ie138b0a6248bae23acb40c07abdc3a8cf8eb7100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184598
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [1dad4202994b06b7d133f855e6d8a583f28abfb1]

        sw a11y: no need to have a separate method for this
        
        It's called only from one place
        Also drop the check for GetMap(), pMap comes from
        shared_from_this(), so it won't be nullptr
        
        Change-Id: Ibc6805995b32c9868e1149f2dbb06a5e0718d973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184594
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [9eccccbc71b88665ca2e3012940dedbfa7ab1695]

        sw a11y: Use range-based for
        
        Change-Id: I0780b9747288767c7a1ed9f780191fb362c91373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184589
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [aefb96bb25cd24065898201727b66a34c04acb45]

        sw a11y: Return early for null mpShapeMap
        
        (`git show --ignore-space-change` helps see the
        "actual" change more easily.)
        
        Change-Id: I2560921c7868ce278c69a7be5eb4f2f2305ce9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184588
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [abf75072ab0c1e0cdc9a6aecc31b15c4538a9cdf]

        sw a11y: Drop intermediate local var
        
        Assign directly to `xAcc` instead.
        
        Change-Id: I95b63218ed5b2c72e9cd8ec10399b7ed4cc532cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184587
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [9ed09f66a3cfb24753facb8763ee1677fc764f2c]

        sw a11y: Pass frame by ref to SwAccessibleMap::InvalidateRelationSet_
        
        Change-Id: I6468df09f1e7447e1837aee64701dccbad637f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184586
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [56d1a1eb2b38e5901a6f06a812f7db60424a22eb]

        sw a11y: Pass frames by ref to SwViewShellImp::InvalidateRelationSet
        
        ... and SwAccessibleMap::InvalidateRelationSet.
        
        Change-Id: Ifd2c9a4b2fe48cc641ccf31736e886a807fe19b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184585
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [3e3f759cdd96719f54c36585d55b0ef193d18175]

        sw: Pass frames to SwFlyFrame::UnchainFrames by ref
        
        ... instead of by pointer. They're always non-null.
        
        This will also allow similar changes all the way
        down to SwAccessibleMap::InvalidateRelationSet_ in
        upcoming commits.
        
        Change-Id: Ia109884eedd8b8e1271e5f922470b63a2927da04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184584
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [3089a2c9f688d32c651f9fe211c18f704a1160e2]

        sw a11y: Directly use SwFrame instead of SwAccessibleChild
        
        See
        
            Change-Id: I66cf2433f0d73ffab34e2a8a49f3903be77d6fdc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 14:09:28 2025 +0200
        
                sw a11y: Don't use SwAccessibleChild when it's known to be a frame
        
        for background, which is a similar change elsewhere.
        
        Change-Id: Ibb7c8b508a2cdff8ee83daa8daa1be43c9853c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184583
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [e06c771f610c5f5bac983df3ebf5e9700f74bf08]

        sw a11y: Use SwFrame directly in SwAccessibleMap::InvalidateEditableStates
        
        See
        
            Change-Id: I66cf2433f0d73ffab34e2a8a49f3903be77d6fdc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 14:09:28 2025 +0200
        
                sw a11y: Don't use SwAccessibleChild when it's known to be a frame
        
        for background, which is a similar change elsewhere.
        
        Change-Id: I3c5293189cb82bd285e96b227abc2a1824a250cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184582
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [87eae332940837f21698d61de98776625c6d6016]

        sw a11y: Don't use SwAccessibleChild when it's known to be a frame
        
        SwAccessibleChild provides some abstraction from
        whether the underlying object of interest is an
        SwFrame, an SdrObject or a vcl::Window.
        
        However, here in SwAccessibleMap::InvalidateCursorPosition,
        the `SwAccessibleChild aFrameOrObj` is only ever used to
        "wrap" SwFrame objects, and then SwAccessibleChild::GetSwFrame
        gets called to get the underlying SwFrame from it again.
        
        As far as SwAccessibleMap::InvalidateCursorPosition
        is concerned, the only relevant thing that both,
        the SwAccessibleChild ctor and
        SwAccessibleChild::operator=(const SwFrame* pFrame)
        effectively do is to assign SwAccessibleChild::mpFrame
        that then gets returned in SwAccessibleChild::GetSwFrame.
        
        The only other SwAccessibleChild method that gets called
        is SwAccessibleChild::IsAccessible (for an OSL_ENSURE),
        but that can now be replaced by call to the static
        helper method SwAccessibleChild::IsFrameAccessible
        introduced in previous commit
        
            Change-Id: Ic5c39cd7f7cb27a027adc6eeb7c77b1b6c4b5cba
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 13:58:45 2025 +0200
        
                sw a11y: Extract static helper SwAccessibleChild::IsFrameAccessible
        
        Avoid the extra level of indirection and simply use
        a pointer to SwFrame directly instead of SwAccessibleChild.
        
        This makes much more obvious that only the SwFrame* itself
        is actually of interest.
        
        Change-Id: I66cf2433f0d73ffab34e2a8a49f3903be77d6fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184581
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [33543763b522b8b03114cd8e2877b3c660853f89]

        sw a11y: Simplify SwAccessibleChild::IsAccessible
        
        Change-Id: I34a9190fe38d2b571773b64d1922ba19997aa567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184580
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [2ab3e0053abb8066876001c1b3fa644f5f7839c1]

        sw a11y: Extract static helper SwAccessibleChild::IsFrameAccessible
        
        This will be reused from
        SwAccessibleMap::InvalidateCursorPosition in an
        upcoming commit.
        
        Change-Id: Ic5c39cd7f7cb27a027adc6eeb7c77b1b6c4b5cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184579
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [a6e4b89746fd778aeed3133a772b0487f8a05684]

        sw a11y: Drop commented out code
        
        This is unused for a long time, and
        SwAccessibleMap::mnFootnote and SwAccessibleMap::mnEndnote
        were finally dropped altoegether in
        
            commit 4ae2c3c3dc0be4b511ab07b6f9bd1806f2789725
            Date:   Mon Dec 2 13:08:09 2013 +0200
        
                WaE: unused private fields
        
                Change-Id: I2084fa7cc0af9385b532c6beab0368bc2e45e29e
        
        Change-Id: Ib6b5a9b37e8f70547f8c1fc7098a146f16b65d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184578
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [441e51dcfdcf7263cc945928bc4da24211c44bea]

        sw: Rename SwFrameType::Ftn -> Footnote, FtnCont -> FootnoteContainer
        
        Afford a few more characters to make this less
        cryptic.
        
        "FtnCont" means "FootnoteContainer", not "FootnoteContent",
        see the documentation of class SwFootnoteContFrame:
        
            // There exists a special container frame on a page for footnotes. It's called
            // SwFootnoteContFrame. Each footnote is separated by a SwFootnoteFrame which contains
            // the text frames of a footnote. SwFootnoteFrame can be split and will then
            // continue on another page.
            class SwFootnoteContFrame final : public SwLayoutFrame
        
        Change-Id: Ia8f9bf8cdf121e2172697ac292ac0b2bc43e59ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184577
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [fc4bd80e9d2ab0b6746aee7399b4a00030bcfd2c]

        sw a11y: Reduce var scope + move into only relevant block
        
        See
        
            Change-Id: I29824c442f41310af0aff15ebac0e0de9b9fd4a9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 12:36:08 2025 +0200
        
                sw a11y: Move code into only block where it's relevant
        
        for a similar earlier change.
        
        Change-Id: I9d39681272ce146342d0c1790128d0c3b3de7045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184576
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [75b445fe58889a3af3af5d611e7dbd95f2b1f5f2]

        sw a11y: Return early in SwAccessibleMap::GetContextImpl
        
        With previous commit
        
            Change-Id: I29824c442f41310af0aff15ebac0e0de9b9fd4a9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 24 12:36:08 2025 +0200
        
                sw a11y: Move code into only block where it's relevant
        
        in place, it's now more easily visible that nothing
        else happens here for the case where `xAcc` is non-empty
        or `bCreate` is false. Therefore, return early, which allows
        to drop one level of indentation for the following code.
        
        Change-Id: Ia27352127b0ef804fb103a1e7914d614605ec4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184575
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [cd3207d18b703d4aa9ae0153d882571d298b1eac]

        sw a11y: Move code into only block where it's relevant
        
        `xOldCursorAcc` can only be non-empty and `bOldShapeSelected`
        can only be true if assigned inside of the body of this if
        construct in SwAccessibleMap::GetContextImpl.
        Therefore, move the variables and the code that will
        otherwise have no effect into the body as well.
        
        Change-Id: I29824c442f41310af0aff15ebac0e0de9b9fd4a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184574
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [2f4be841dac6b8bcd771c8f4332aff87a7e5d8db]

        sw a11y: Drop superfluous/misleading comments
        
        The SwAccessibleDocumentBase::getAccessibleChild
        comment saying
        
            // Return the specified child or NULL if index is invalid.
        
        is misleading/incorrect, because passing an invalid
        index results in an IndexOutOfBoundsException being
        thrown instead.
        
        The other 3 dropped ones add no value to the corresponding
        documentation for the base interface, XAccessibleContext.
        
        Change-Id: If724ccafcafdad2b1d35810d46d890cff2000f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184573
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [bdd679d1fa6a3d11bed4f6ed090c8c0a8b3a68be]

        sw a11y: Drop commented out namespace prefix
        
        Change-Id: I786e73fcb7dc8be23348518056374ddc8012ee3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184572
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [a58444db7dcd5a84cda235984b311e9c81ce8a3d]

        sw a11y: Assign final coords to point right away
        
        Change-Id: I3ff988dfe13b095f842d637f3e87ffb742f68ec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184571
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [03239b9002fee213099ef2f567c4c53cef0d6cd0]

        sw a11y: Use vcl::unohelper::ConvertToAWTRect
        
        Change-Id: I9ba2d353479df0e054a5a4f67ea2ba112e2589da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184570
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [139db7a35e0541bcbbdcdfccb816b53fad088f1d]

        sw a11y: Simply use 'this'
        
        Change-Id: I0c08e1a40e63b1f3ece3ca338b97527747837819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184562
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [b268c0e484628c8a97e415bb94f33a4089148278]

        sw a11y: Reuse existing SwAccessibleParagraph::GetTextFrame
        
        Change-Id: I05dcda9e4543b28afe618b5382a4876d4e201a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184561
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [875212df8b1b3d14329ad20475ed632a79ec3ac4]

        sw a11y: Let SwAccessiblePortionData have a ref, not ptr to frame
        
        Switch SwAccessiblePortionData::m_pTextFrame from
        a pointer to a reference (and rename it) to make
        more clear this is always non-null.
        
        This also allows to drop 2 `OSL_ENSURE`s about
        it being non-null.
        
        Change-Id: I7a0563bdc246cead294ce3ba3ec866af9cbdf6d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184560
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [e85e89cb423a2262fd4e54ff71eb50eeba321ff6]

        sw a11y: Move text frame assert to better place
        
        Asserting that the frame in question is actually
        a text frame makes more sense in SwAccessibleParagraph::GetTextFrame
        before doing a static_cast to SwTextFrame.
        
        Change-Id: I7d160b002036f1cd2df2c5d6cd65e48dc1f5b803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184559
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [da311e43e9a49782180c4d22851933c5745c2962]

        sw a11y: Fix typo in comment
        
        Change-Id: I3d31491173d59e3783c15f0ef1b5c2f84ca4f3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184558
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [4af3c5c7374cef5b39e3501e39c090514132b276]

        sw a11y: Switch OSL_ENSURE to assert and drop fallback path
        
        Switch the OSL_ENSURE about `pFrame` being non-null
        to an assert, and drop the fallback path handling
        the null case in SwAccessibleParagraph::UpdatePortionData.
        
        In both callers of the method, `m_pPortionData`
        gets dereferenced afterwards (either directly or
        by calling SwAccessibleParagraph::GetPortionData),
        so the fallback path wasn't a safe one anyway.
        
        Also switch the OSL_ENSURE about the frame being
        a text frame to an assert.
        
        Drop the OSL_ASSERT about `m_pPortionData`
        being non-null at the end of the method, as that
        would only have been relevant for the fallback
        path.
        
        Change-Id: Ib570f609f355d12f9836ad397338225f72484655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184550
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [dc17bf7ef685681af90845f58fe25476a5e25948]

        sw a11y: Only get win if necessary
        
        There's no need to do so if `nOld == nNew`, so move it
        below that check + potential return.
        
        Change-Id: I113971ec2fcf84567621f29aae11c3a51bfabb21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184549
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [3f19e3aacf727d779d508d5f0d65adc6adcf845f]

        sw a11y: Just pass 'this'
        
        No need to use an explicit rtl::Reference to `this`
        here.
        
        Change-Id: I4c1ea4d63bb6fcbfd437607a309f01cde11950a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184548
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [151550bbe7951b7a8ba70aa41106b5d2ad161df2]

        sw a11y: Simplify paragraph parent retrieval in one place
        
        The general way to retrieve the XAccessibleContext
        from an XAccessible is to call XAccessible::getAccessibleContext,
        not to query the XAccessible for the XAccessibleContext
        interface.
        (Doing the latter - as was done here - should still give the correct
        result in practice at least, because SwAccessibleContext::getAccessibleParent
        returns a reference to self.)
        
        For SwAccessibleParagraph as a SwAccessibleContext subclass
        however, there is SwAccessibleContext::getAccessibleParentImpl
        (which also gets called by SwAccessibleContext::getAccessibleParent)
        which returns a SwAccessibleContext right away, so use that
        which is simpler and also removes the need to static_cast the
        accessible to SwAccessibleContext altogether.
        
        As a side not, using `pPara` for the var name of an accessible with
        role TABLE_CELL also seemed a little misleading.
        
        Change-Id: I38991674e806eb8f5ecf75327686651b6779c8ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184547
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [85cbe675d352ab0e9dbf0bf8bad3c8fc3a7e6768]

        sw a11y: Drop class qualifier when calling method
        
        `GetCursorShell` is a non-virtual method of
        the SwAccessibleContext base class, so explicitly
        calling it as SwAccessibleParagraph::GetCursorShell
        from within SwAccessibleParagraph itself
        is unnecessary and rather confusing.
        
        Change-Id: I069d2d2b0d56962b6aac388d0dd0e299e5bc98cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184539
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [d310e84bca42178e01cfbe1fac114b719490a889]

        sw a11y: Return early in SwAccessibleParagraph::GetCaretPos
        
        (`git show --ignore-space-change` helps to see the
        "actual" change more easily.)
        
        Change-Id: I5cb1e84a1db91b19fd6eddd1c72b6184aecead04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184538
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [fcf747cb992cda5ecc2d5bc3cee50ca3da5cb4bb]

        sw a11y: Drop 'using std::{max,min,sort}'
        
        Change-Id: I5e25dce74fba5e9b8d06ecb4c97d5d520c1858fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184537
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [b60c720df85ae6c2b429571bb1e9e926cc1d21ed]

        sw a11y: Return early in SwAccessibleParagraph::GetTextBoundary
        
        Change-Id: I4716598f444f21eb7a040e4fd9cc65fe1551ccf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184536
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a6e59a058306f0523f3686a9b084d010bd80e632]

        update credits
        
        Change-Id: I9cff0d23ae8f3922f14e36a3c0a17cf7d7d3afb1

2025-04-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8cdbe3666440f81aa71539e8d38d5a93eec17b26]

        poppler: avoid more std::ranges afer update to 25.04.0
        
        Not supported by macOS 12.7 / XCode 14.2
        
        Change-Id: I114190ddc9e36c2660c78a4ea2eb1e7797dadf13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184444
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [289327e5abe1b5e94517c7f58ef965079fe37281]

        Simplify concatenation of literals and OUStrings
        
        Change-Id: I34457a119484adeedee84b722215cfe000a220be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184557
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-04-24  Noel Grandin  <noelgrandin@gmail.com>  [4e8d365c62f31d2a5a6d9778a1ace2be902abb2c]

        reduce allocation in SwAccessiblePortionData
        
        no need to allocate sentences separately
        
        Change-Id: I0743bd7206fa4c7bec887841c8e8a9cbcea1060f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184552
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-24  Patrick Luby  <guibmacdev@gmail.com>  [ab54f1da9c04e684c4f1a916d189b6a3e0d60ee0]

        Revert hiding of Start Center when loading modules or documents on macOS
        
        In commit 331ea32ec181aff739eaebee328281b190cad003, the backing
        frame's component was unset if there is no progress bar. This made
        the Start Center's window empty so that loading large documents
        wouldn't have the Start Center content displayed while the document
        loads.
        
        Unfortunately, this change has the side effect of making the Start
        Center undisplayable if the LibreOffice recovery dialog is displayed
        on launch and the "Discard All" button is pressed.
        
        Change-Id: Iff571eb1751256f359cb0ef8a8eec7c094bcec68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184553
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e2035e017e2942fcb46109d02d83cd8990554474]

        tdf#166249 - ooxml export: fix incorrect color exports in chartexport
        
        The colors and alpha values need to be exported individually.
        
        Also simplify leaderlines export by exporting all kind of line properties.
        follow-up of commit: ada05b8874aa2c5161550dbc87d79b47f40f0df8
        
        regression from: 1916957d0750b5471f23f17b2867a907e0e9e0e2
        (tdf#164936 oox: modify getColor method to include alpha)
        
        Change-Id: If0310b78382b384d022559b8411fd315c014612c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184525
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-04-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c8d96de7d4e7e109ac3492c965ed02a996d13d72]

        include vcl/dllapi.h for VCL_DLLPUBLIC
        
        seen in oss-fuzz build failure as:
        
        Step #4 - "compile-honggfuzz-address-x86_64": /src/libreoffice/vcl/inc/../source/filter/ixbm/xbmread.hxx:25:1: error: unknown type name 'VCL_DLLPUBLIC'
        Step #4 - "compile-honggfuzz-address-x86_64":    25 | VCL_DLLPUBLIC bool ImportXBM(SvStream& rStream, ImportOutput& rImportOutput);
        Step #4 - "compile-honggfuzz-address-x86_64":  error generated.
        
        Change-Id: I931502cf8295d4e1e03ffe2d28a6c3dc62d7ab73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184551
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [f7d4cdf6564b8405a69b0a4f1fc2a98d8daee0ac]

        tdf#86630: sw: Add UItest
        
        Change-Id: Ib079bb2eca04a5f9ff86f76e9d47195e369f2008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184546
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-24  Noel Grandin  <noelgrandin@gmail.com>  [48c7b7c06b918702eab88b58f05c09a3a4f19928]

        tdf#165595 speedup drawinglayer processing skia images
        
        Not really sure why this code is needed here, seems like we could
        just put it into the SalBitmap base class,
        there is no actual logic being added.
        
        Change-Id: I2103ab392625c1e13e177ebbb753e111639f06a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184524
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [d9321109253187b7bdc18c887b108e6e2b5fc5ac]

        Useless declaration with initialization before setting the actual value
        
        Change-Id: Ia59445a2434152c40bd128020b17587bc1dd9044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184540
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [d572a56bea0a5ad01f485b365b2135c682c9f65f]

        svx a11y: Don't return just ";" for a11y description
        
        In AccessibleOLEShape::getExtendedAttributes and
        AccessibleShape::getExtendedAttributes,
        simply return an empty string instead of ";"
        for the extended attributes if there is no shape.
        
        Change-Id: I192dff95b433f167a15bb4f0bb8f634c45f2156e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184532
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [e127d6e49a0a1b59e49112d354ddc2ae67e35045]

        wina11y: Use Ref instead of extra raw pointer
        
        In addition, rename `pRXI` according to naming scheme
        (starting with `x` as it is an rtl::Reference).
        
        Change-Id: Ib699957a35b3f49606c8196f5d7350cf27b71da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184531
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [faf94529a0474488f1c80b3126f7d7c3e5cb1a69]

        wina11y: Drop redundant 'this->'
        
        Change-Id: I7c0c09788499d5299820f600e2861bc124c68fed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184530
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [fbc54d6acddb458ade644d42d19197b978cf8554]

        Simplify a bit
        
        Change-Id: I2e1d9910474fd959d9c8c40172033c7041bf0827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184534
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [674ea3f1ee1614b90cdfaaab65226834428a1a07]

        Don't use different ways to refer to the same thing
        
        Change-Id: I78ec70410e1ee11ee98a8f1358c1b623f6ca0b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184533
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-24  Stephan Bergmann  <sbergman@redhat.com>  [8e0ffffe60f1e9c97d7937ffe7d206fb62900357]

        Directly use std::cmp_*, drop o3tl::cmp_*
        
        Change-Id: Ic6e6f1f10cd016550df38118c4e7fdba4d3c4b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158513
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [894ff7b2df09221195399a750afd6ff464637097]

        [API CHANGE] a11y: Return string for XAccessibleExtendedAttributes
        
        All XAccessibleExtendedAttributes::getExtendedAttributes
        implementations return a OUString wrapped in an Any (or
        an empty Any), and all consumers also expect that.
        
        Therefore, change the return type from Any to OUString
        to make that clearer and simpler.
        
        Change-Id: Ic6af692f72fd072c4039996f31208ac2098d2750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184514
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [40c86e05866fcb2f006898d0fc9b7893c151dab8]

        sw a11y: Drop unnecessary cast
        
        SwContentFrame subclasses SwFrame, so there's no
        need to explicitly cast to the latter.
        
        Change-Id: Ib38dfdc8d05d77e2986c658e91ac31ad06f3e82d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184513
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [17c68a6e7405b2d563f7b56503b3596520ce07f1]

        sw a11y: Assign variable value right away
        
        Change-Id: Ia80fceccbe8e1a3a743f1a95de88c5fba8653dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184512
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [9bfcceff0055a2a6e3d1a07cb79a0414e995bd5f]

        sw a11y: Return early in SwAccessibleDocument::getExtendedAttributes
        
        ... if `pFeShell` is null.
        
        (`git show --ignore-space-change shows the "actual" change
        more clearly.)
        
        Change-Id: I6d5f5b5bf26363fdc97e1868e4f1bf6cf1ceb9a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184511
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [78ccf4461adcf063cb5a01fa79238577d9ee5174]

        sw a11y: Drop some unnecessary a11y description handling
        
        Apparently since
        
            commit f70324bf6e546dc722d518bc09c8cfe98ed8cff6
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Tue Nov 9 12:43:28 2004 +0000
        
                INTEGRATION: CWS swqbugfixes08 (1.57.406); FILE MERGED
                2004/09/29 07:56:06 od 1.57.406.2: #117970# <SwAccessibleParagraph::GetDescription()> - provide empty
                         description of paragraphs.
                2004/09/27 15:00:02 od 1.57.406.1: #117970# <SwAccessibleParagraph::SwAccessibleParagraph()>
                         - set an empty accessible name for paragraphs
        
        , the accessible description of Writer paragraphs is always empty.
        
        Therefore, drop some code that would only be relevant if it wasn't.
        
        Change-Id: I8a1820f9a59ce978754e3b14ba907470680b84b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184510
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [4ad7bd90b20d2f689af3543b32dbec76e78550aa]

        sw a11y: Drop SwAccessibleParagraph::supportsService
        
        The base class implementation
        SwAccessibleContext::supportsService already does the same.
        
        Change-Id: I33595e5922d0658663fce89c6ae55d20188c8642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184509
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-24  Simon Chenery  <simon_chenery@yahoo.com>  [50cf101df5d89d7104e185b0adfcff45a2eb76dd]

        tdf#145614 Convert #define JMP_TABLE_SIZE to constexpr
        
        Change-Id: Iedc40d790a4822d0cb65480e1e4b64439de39db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183496
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-04-23  Patrick Luby  <guibmacdev@gmail.com>  [722073473b6d8e8553f501ff1d4a68d4dc21f866]

        tdf#156302 prioritize Silicon architectures before Intel
        
        This solution was copied from the following Apple StackExchange post:
        
        https://apple.stackexchange.com/questions/466284/why-is-a-macos-app-whose-executable-is-a-shell-script-launching-as-x86-64-on-an
        
        Change-Id: I0a3ec9c97efe0284b889ab4d33b694c22c53fc46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184110
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [00e64d04909964e29a0085b6b14fc4e7b2b892b1]

        Latest VS 2022 Preview is 17.14.0 Preview 4.0 now
        
        ..while latest proper VS 2022 is 17.13.6
        
        Change-Id: I1c72cb27b00bee0ce7a382988c34a43e6a0d111a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184518
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-23  Nam Bui  <ndbui03@gmail.com>  [0fbe68c63bc21e392a13e0fa8e60a3dd1e4a5a22]

        tdf#147132 Flatten Basic function implementations
        
        Flattened SbRtl_RmDir() and SbRtl_FuncCaller()
        
        Change-Id: I28168d88209b0d72333849633a64f269735591f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183690
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1a55fe96641a55662be013659ab9ac734614d54c]

        Remove lock file
        
        Accidentally merged in 5268e13d3924a62f164f5c2b018c8289fbcc1ac4
        
        Change-Id: I1579ce72fb873545b5465a61d15966d2e2fc5bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184516
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [17679f5cacefbf55945a04c9b4c3d746a5bffc53]

        Pass NINJA into Meson in ExternalProject_harfbuzz
        
        ...otherwise my macOS build with autogen.input containing (among others)
        
        > NINJA=/Users/stephan/lo/lode/opt/bin/ninja
        
        would have failed building ExternalProject_harfbuzz with
        
        > ERROR: Could not detect Ninja v1.8.2 or newer
        
        Change-Id: I39260ae7fea9808fe26b9e63c3c7aaaa4c27103d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184502
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d0e6d192c25f338803393160bad34533ec7236ca]

        These bogus -Wdangling-reference still hit with current GCC 16 trunk
        
        Change-Id: I228e0b148d77b973afb4e35b8976438ba5a95967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184517
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-04-23  Julien Nabet  <serval2412@yahoo.fr>  [a399c4fae0a3f7dfd00565929e7ad6a41bde0df8]

        tdf#166241: add AES_192_CBC/AES_192_EBC
        
        + improve SALT management by taking the max between encryptedHashInput.size()
        and comphelper::roundUp(mInfo.saltSize, mInfo.blockSize)
        
        + add QA tests
        
        Change-Id: I90dce73928e0b204500ac659eb80cd1499a4f065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184407
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a28af317700b4f0ccbeec8b0fdbc6cb0395c1328]

        Remove obsolete fw declarations from oox/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I5fd8af2e2e14fa6f0a9c94038fa0b3dcc2b08221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183894
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-23  Oliver Specht  <oliver.specht@cib.de>  [5268e13d3924a62f164f5c2b018c8289fbcc1ac4]

        tdf#166191 character style properties only applied if repeated
        
        Reset character properties that are not repated at run level also if
        - the text run is in a table
        - there is no style with the index 0 ('Normal')
        Change-Id: I840178d727a157b628cb359e5c2798c1455cd555
        
        Change-Id: Id04a501e156e33804e6b99b13688eef1cb899e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184277
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f5cca58c2ea765b08cbcc771deb4fa75ead1870e]

        Compare normalized nanosec timestamps in TemplateFolderCacheImpl::equalStates
        
        After 9830fd36dbdb72c79703b0c61efc027fba793c5a "date/time IDL datatypes
        incompatible change", 4fa553e4071a0ba4981a690429903c4e68607864 "fdo#62088: Fix
        regression introduced by the DateTime incompatible change." had fixed
        writing/reading timestamps to/from the .templdir.cache file, by cutting from
        nanosecond precision back to 1/100th-second precision.  But in the call to
        TemplateFolderCacheImpl::equalState, the (cut-down) timestamps read from the
        .templdir.cache file were then compared against (not--cut-down) timestamps
        reported by the filesystem, potentially causing equalState to erroneously return
        false.  (This is only relevant on Windows, as the non-Windows implementation in
        sal/osl/unx/file_stat.cxx always sets Nanonsec = 0 for all the timestamps it
        reports.)
        
        Change-Id: I34b99024531d4d2e49bb53450e8f6fd13397f237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184505
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [01d94f0734466006fe3c4c47bce4edd1a2fc6af7]

        Remove obsolete fw declarations from lotuswordpro/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I76f62dcb953e0f80dcbf289c598c92c9301a495a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183893
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a8278e1c4949eb17ffc32730eea393e908ec7a41]

        Remove obsolete fw declarations from i18npool/ idl/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I6671637445e373310cc982af655bef899b2ec14f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183891
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-23  Oliver Specht  <oliver.specht@cib.de>  [6ea60a38f8bd10c454cda06cee3a777e2ef402cc]

        tdf#166230 Switch off page number of page breaks
        
        Makes is possible to switch off the page number of page breaks
        in paragraph dialog.
        
        Change-Id: Ic185e492080630ffd9906492e0a00e7d8b87d028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184336
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [4dcb25e23da452a345db38a3a04d08b8441dcd42]

        vcl: Replace HELPWINSTYLE_* constants by enum class
        
        Introduce enum class HelpWinStyle
        to replace the HELPWINSTYLE_BALLOON
        and HELPWINSTYLE_QUICK defines.
        
        Change-Id: Ic70b6356af0073eef3e4a0fe588688fa3c81b3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184498
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [0687c3633295ab64f72139a662c3b1f41573493c]

        vcl: Move help win helper declarations to .cxx
        
        Drop declaration from header and make these helper functions
        static, since they are only used inside of vcl/source/app/help.cxx.
        
        Change-Id: Ib7f595212ccaf5f21f0687c6aad6afbad60edaa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184497
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [28e542dc61d408f5807e8c94ed48c273146edbda]

        Avoid loplugin:redundantcast on macOS with recent LLVM 21 trunk
        
        ...including
        <https://github.com/llvm/llvm-project/commit/b6b025797245a5e5416b522df041252e3c4ff868>
        "Fix the signature for __builtin___clear_cache (#134376)", which now caused
        
        > bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:601:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
        >   601 |         reinterpret_cast<char *>(const_cast<unsigned char *>(begin)),
        >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:602:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
        >   602 |         reinterpret_cast<char *>(const_cast<unsigned char *>(end)));
        >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I38e230af517a71016a7afaea4b72ffc91b00ef3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184499
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [d39e1b0463de02f6a78712879d54e69e71b22b3b]

        desktop: Use sal_Int32 instead of tools::Long for progress value
        
        And drop a static_cast to sal_uInt16 in ExtMgrDialog::updateProgress
        for which it's unclear to me why it was there.
        
        Change-Id: Iac204bc1139c4674925d4e42e22614d0cf069ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184480
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [856c58b893224f1aa335e7b5e1f5e42409bb0233]

        harfbuzz: upgrade to 11.1.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.1.0/harfbuzz-11.1.0.tar.xz
        
        Change-Id: Icc126659dd10836a7b2c06d35282a4f1d763b520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184479
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-23  Mike Kaganski  <mike.kaganski@collabora.com>  [437d392c0ef65fefd46d48c89f19550caae919bc]

        Drop needless const_cast and static_cast
        
        And use the pointers to non-const object from start
        
        Change-Id: I1143eb0a52e224f3bcaadd1f6e6bbefd1639c639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-23  Mike Kaganski  <mike.kaganski@collabora.com>  [c4b892a8b8dfb58f26313632388d25a6e71b809f]

        No need in this raw pointer - we have an rtl::Reference here
        
        Change-Id: I214a39ee8ddd0384b8671e0d74efd9c8eb979583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184469
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [99c04ecefc1abae8d13e789460a3a69bd79cb6f8]

        lxml: upgrade to 5.4.0
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-5.4.0/lxml-5.4.0.tar.gz
        
        Change-Id: I2d683ad5173315248dd0348f8b2b268f1fe8f5c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184467
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-23  Mike Kaganski  <mike.kaganski@collabora.com>  [7c9e2e62117efd95e11e8b2dfdbedd88452932b8]

        Drop needless warning
        
        E.g., SwXServiceProvider::MakeInstance explicitly passes nullptr
        to SwXBookmark::CreateXBookmark.
        
        Change-Id: I8163479d399fe2f4243c7b4ecb7e0c04b594b95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184460
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ace0eff7d9b091eeb22258a49c1ddbd77b1e9f62]

        libxml2: upgrade to 2.13.8
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.8.tar.xz
        
        Change-Id: I24dc935a4a878ec3f5de996cecd3615cbed92321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ff7f0f00514e01bd67a8b621d17ffd3f876bee7]

        libgpg-error: upgrade to 1.54
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.54.tar.bz2
        
        Change-Id: Ib7ca69e674917bda54b8743580653600b573a300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184458
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-23  Pierre F  <fpy@bger.ch>  [3a856d6a3cc82d3ebf46ac9d73052ca2de85dd0b]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: I8d7033ff588de7e12300398297ff363f8e65c74d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183930
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-04-23  Oliver Specht  <oliver.specht@cib.de>  [bac7665f78b734a9ba79a4511484c579047ea0df]

        tdf#165083 Remove of wrong page margin export code
        
        With 8ef9573f087b86f93860c8d07d04b60a40512836 import and export
        of page margins has been changed. The export part was wrong so
        it is removed here.
        
        Change-Id: I00ab7854cb7ee0baa81bfffcd7f07dea3b84f2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183146
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [23b9dae8e6fb530b9a966adfd440831510d9854e]

        sw a11y: Drop extra bool var indicating non-empty vectors
        
        `bMarkChanged` is true for any code path that adds
        to either `vecAdd` or `vecRemove`.
        
        Therefore, it doesn't add any extra value:
        
        * If `vecAdd` or `vecRemove` are non-empty, `bMarkChanged` is true,
          so the code path below the check for `bMarkChanged`  which iterates
          over `vecAdd` and `vecRemove` will always be executed.
        * If `bMarkChanged` is false, the early return isn't needed, because
          iterating over 2 empty vectors also doesn't make any difference
          in comparison to not reaching that code path at all.
        
        Therefore, drop `bMarkChanged`.
        
        Change-Id: I9cb62414c8412a5d520eae416258b396db8abd2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184447
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [69565279724b581d780bbc70f9e7b14cafc438e3]

        sw a11y: Don't use unique_ptr for selected shape map
        
        This is similar to
        
            Change-Id: I383b49fb84fc77ace80053355e9e69b144e6c72b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 22 14:57:59 2025 +0200
        
                sw a11y: No longer use unique_ptr for frame map
        
        , but now for SwAccessibleMap::mpSelectedFrameMap.
        
        Change-Id: I590936e5c4460a5066daf36a6dffa8562e70b03d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184446
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [8879903c0ad4eec56dfc3cccd34663492f200d84]

        sw a11y: Use std::unordered_map::contains
        
        Change-Id: I2fe2a810cd310b1aad0d4d013456f7ffb131310c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184442
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [baf2b5b523f721638b01f9842e5c30f36a329d49]

        sw a11y: No longer use unique_ptr for frame map
        
        I can see no particular reason for using a
        std::unique_ptr<SwAccessibleContextMap> for
        SwAccessibleMap::mpFrameMap, instead of just a
        SwAccessibleContextMap.
        
        So far, an empty map was created if `mpFrameMap` was null
        in both, SwAccessibleMap::GetContextImpl and
        SwAccessibleMap::GetDocumentView_, and the member
        was reset in either the dtor or in
        SwAccessibleMap::RemoveContext when the map became empty.
        
        I don't see any particular reason to have an explicit
        null value (and check for it in multiple places) instead
        of simply having an empty map by default.
        Therefore, switch to using the latter, which simplifies
        the code.
        
        For most places, the previous null check can simply
        be dropped as the overall logic remains the same
        with an empty map (e.g. still nothing happens in case
        of an empty map in most methods because no corresponding
        entry is found in the empty map.), but keep an expclicit
        check for these cases:
        
        * At the beginning of SwAccessibleMap::BuildSelectedParas, replace
          the previous null check by checking for an empty map
          instead of just dropping the check, to avoid unnecessarily
          iterating over text frames.
        
        * In the SwAccessibleMap dtor, also replace the
          previous null check by a check whether the
          map is empty.
        
        Change-Id: I383b49fb84fc77ace80053355e9e69b144e6c72b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184441
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8049d3f2345d5e6ead9fcb7b84f376fc84b82706]

        tdf#166194 Chinese characters crowd in cell
        
        regressioon from
            commit 11b15571475414ef853e21a6c96afa2ac81f848f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Oct 30 09:51:26 2024 +0200
            convert KernArray from sal_Int32 to double
        
        Change-Id: I5c9a9d6caa0091f4be1c3307cc842b2ea4662728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184449
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-22  Noel Grandin  <noelgrandin@gmail.com>  [2a008a20344bcc62ca168ce9b22fd3c1cd9d2a05]

        some unit tests not valid when the pdfimport feature is disabled
        
        Change-Id: I2c9aadb292f8c634cff57bf6171be621b6b58064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184448
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-22  Oliver Specht  <oliver.specht@cib.de>  [677e40c8b83b06ded8e06b6151f71686baf5f6b5]

        tdf#166177 Fixes unintended switch to rotate mode
        
        Fixes switch to rotate mode after inserting or
        moving a shape.
        
        Change-Id: I4e8ce8b5891a08c6c3f20a9c29fa4bef4428eb84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184141
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-22  Ming Hua  <plateauwolf@qq.com>  [46d32250f2e32faede9881e2af1a867c58d571de]

        Use American English spelling "favorite" in UI strings
        
        Change-Id: I92cfb9dcd0985e98a9364e0e239584249c166f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184436
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [796f8ff3327c82233e495eb4fcad4314d706a3b0]

        Revert "use more concrete UNO in chart2"
        
        This reverts commit 1886ecf7ee10cc51ca90fe1365e4a8ef2a1b6f27.
        
        because reportdesign will pass in a OReportDefinition* and not a SvNumberFormatsSupplierObj*
        
        Change-Id: Ic0068d18a10ce24ed74bb86cfef4cb9f34e9eeb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [3418a3648fe05169e96532039d01f20e959bacb6]

        tdf#130857 qt weld: Actually implement tree view sorting
        
        Just calling QTreeView::setSortingEnabled
        in QtInstanceTreeView::make_sorted isn't sufficient
        for the tree view entires to be and remain sorted.
        
        It also requires that the tree view uses a model
        that supports sorting. While QStandardItemModel
        has a QStandardItemModel::sort method that can
        be used to sort the model, it doesn't ensure the
        entries remain sorted when adding new ones, i.e.
        it would have to be called every time an entry is
        inserted.
        
        Instead, switch to using QSortFilterProxyModel
        for the QTreeView's model to "wrap" the
        QStandardItemModel, which ensures that items
        remain sorted in the tree view once sorting has
        been enabled.
        
        In addition, QSortFilterProxyModel::sort needs
        to be called once so that the model knows what
        column to sort by. Quoting the
        QSortFilterProxyModel::sortColumn doc [1]
        
        > Returns the column currently used for sorting
        >
        > This returns the most recently used sort column. The default
        > value is -1, which means that this proxy model does not sort.
        >
        > See also sort().
        
        Use the first "normal" column (i.e. not the
        special toggle button column, if that one exists).
        A different sort column could explicitly be set by calling
        weld::TreeView::set_sort_column.
        
        The drawback of switching to QSortFilterProxyModel instead
        of using QStandardItemModel directly is that QSortFilterProxyModel
        only derives from QAbstractItemModel, so some
        QStandardItemModel/QStandardItem convenience methods cannot
        be used directly any more.
        
        Because of that, introduce a QtInstanceTreeView::itemFromIndex
        helper method instead of calling QStandardItemModel::itemFromIndex
        directly.
        In QtInstanceTreeView::swap, convert between the
        proxy and source model row indices and work with the
        underlying QStandardItemModel directly in order to
        be able to continue using QStandardItemModel::takeRow
        and QStandardItemModel::insertRow.
        Similar in QtInstanceTreeView::find_text, where
        QStandardItemModel::findItems is used.
        
        This commit e.g. causes the entries in the "Document" tab in
        Writer's "Insert" -> "Field" -> "More Fields..." dialog to
        be sorted as expected with SAL_VCL_QT_USE_WELDED_WIDGETS=1
        in a WIP branch where support for native Qt widgets for that
        dialog is declared while they were unsorted previously despite
        the SwFieldDokPage ctor calling weld::TreeView::make_sorted.
        
        [1] https://doc.qt.io/qt-6/qsortfilterproxymodel.html#sortColumn
        
        Change-Id: I5849f66caf78bc23059c8b52d45742f444578452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [02b90d55b54743671f3343754ef82f5caa3cf9e1]

        tdf#130857 qt weld: Pass both row indices to std::max
        
        ... instead of passing the same one twice, which
        the initial implementation from
        
            commit fdad3dd5a9c5e524233c497af01ebb16cf32136e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 1 12:41:50 2025 +0200
        
                tdf#130857 qt weld: Implement QtInstanceTreeView::swap
        
        accidently does.
        
        Change-Id: I6f539b4368b6f6626b12ab1cfb4063e9329d6342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184433
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [478d0853c3e8aa8a43da4c7fed8b082f6da387fa]

        sw: Resave flddbpage.ui with glade 3.40
        
        This .ui file is used for the "Database" tab in Writer's
        "Insert" -> "Field" -> "More Fields..." dialog.
        
        Change-Id: I119e433602838f7e76f91ed56eef910399ef0e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184432
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [6999fbebb28adcc03cfd7023f4097523fbbc1ec3]

        sw: Resave flddocumentpage.ui with glade 3.40
        
        This .ui file is used for the "Document" tab in Writer's
        "Insert" -> "Field" -> "More Fields..." dialog.
        
        Change-Id: I7644507c5e31965b12de2793991654a16e3ec5ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184431
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  knordback  <kurt.nordback@collabora.com>  [84d4a5dc218bf2cef908c614efb7f09c821ae00c]

        tdf#165742 Step 3: Establish a narrow input path for chartex
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML
        and re-export.
        
        Build out the narrowest parsing path down to ChartType for funnel charts.
        No other data or parameters are supported at this point other than the
        chart type. This is a step towards more extensive support for I/O of chartex
        charts to/from OOXML.
        
        Change-Id: If33f4320c373262de19a7b0b31d28ce8f1de29e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183463
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Simon Chenery  <simon_chenery@yahoo.com>  [65e295d1f899c4b9f720391441aa5a4d340b0d3d]

        tdf#158068 Use OUString literals in ShapeFactory.cxx
        
        Change-Id: I64f161c44504394e1e92c4abe922950e79607f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbe05bc89a53f4c31e5ccf62edb21e83184c0a34]

        loplugin:bufferadd extend it to find some more places
        
        where we can simplify *StringBuffer usage
        
        Change-Id: Ic2005b886b486a6627a43f8dcfba3258cb168921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184428
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d14905a3dd49e7e32909dfe9e24456c82fdcc38]

        Fix typo in code
        
        Change-Id: I1fb96203fd5d5fa6dfbbcc39dc8e6a6a2291c76f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184427
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [99ab2178c9d8f316811cc3c12d9c6bdc704ba055]

        qt6 avmedia: Adjust code to PngImageReader changes
        
        Adjust the code after
        
            commit 70162a33fde729998e4d9c7558f3634352738772
            Date:   Tue Apr 15 14:17:21 2025 +0900
        
                vcl: Introduce ImportOutput to return BitmapEx or Animation
        
        to address the following build failure for the --enable-qt6 build:
        
            /home/michi/development/git/libreoffice/avmedia/source/qt6/QtFrameGrabber.cxx:36:13: error: no matching member function for call to 'read'
               36 |     aReader.read(aGraphic);
                  |     ~~~~~~~~^~~~
            /home/michi/development/git/libreoffice/include/vcl/filter/PngImageReader.hxx:58:10: note: candidate function not viable: no known conversion from 'Graphic' to 'BitmapEx &' for 1st argument
               58 |     bool read(BitmapEx& rBitmap);
                  |          ^    ~~~~~~~~~~~~~~~~~
            /home/michi/development/git/libreoffice/include/vcl/filter/PngImageReader.hxx:59:10: note: candidate function not viable: no known conversion from 'Graphic' to 'ImportOutput &' for 1st argument
               59 |     bool read(ImportOutput& rImportOutput);
                  |          ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /home/michi/development/git/libreoffice/include/vcl/filter/PngImageReader.hxx:61:14: note: candidate function not viable: requires 0 arguments, but 1 was provided
               61 |     BitmapEx read();
                  |              ^
            1 error generated.
        
        Change-Id: I7d322f66a09f76851e9045e8e90684ac35bb48f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184424
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-22  Noel Grandin  <noelgrandin@gmail.com>  [156d7d72c2c979ab7ef8bc3455c1f3129d057629]

        use tools::DeleteOnDeInit for FilterCache
        
        seems it can otherwise sometimes crash during teardown
        
        Change-Id: If1a06335bdd5feccadaae5a7f8a7828864b556cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [df83ad933b11e973855d66792c9aff38714f9201]

        fix harfbuzz build with --enable-python=fully-internal on linux
        
        if executable python scripts are run as build commands, they can pick up
        system python instead of the LO-internal python and that then can cause
        incompatibilities, ranging from just being too old and failing with
        stuff like
        AttributeError: 'str' object has no attribute 'isascii'
        or attempting to load incompatible modules
        […]
            from . import _compiler, _parser
          File "/home/michi/development/git/libreoffice/instdir/program/python-core-3.11.12/lib/re/_compiler.py", line 18, in <module>
            assert _sre.MAGIC == MAGIC, "SRE module mismatch"
        AssertionError: SRE module mismatch
        
        So remove the executable bit to make sure the scripts are run with the
        python specified for the build, either internal or the system one.
        
        Also undo the workaround added in 736998ccef0bacdd2bbf038c98dacfbe654f1a4d
        (Only run meson from python when it apparently needs to be)
        While this can help running meson itself if the distro has different
        python versions but cannot be run with the default python3 / the python
        version used to run meson is likely newer and then also avoids most of
        the issues above, it still is bad to mix build-tool python and the
        commands executed by the buildtool.
        
        For the cornercase of meson not being able to be executed by the python
        used for the build, the solution is to either specify
        PYTHON=/hatever/python/system/meson/uses (for the non-fully-internal
        case) and/or using a release tarball of meson and pointing
        MESON=/path/to/meson.py in autogen.input (can be used with both system
        and internal python)
        
        Change-Id: Id8e3ea88e0caa4afa872a62207b081c072496903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184271
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5f01c903ef74514610cc8dc8cd38245ae3657953]

        Fix typo
        
        Change-Id: Ia182a613e0252ba5aece75647f3d4c0aac0a18d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184411
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df48b8f02ca6d797c070c2122b254cfbdc4bac62]

        Fix typo
        
        Change-Id: I90e161f632880a41634c4e8225501623899d2648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184410
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [9840136fc91f73b237a81ccbad31721ecba5c689]

        sdext,pdfimport: Add passworded, PDF 2, UA, hybrid test
        
        When LO exports PDF/UA files it doesn't add the old
        AdditionalStreams trailer hack, just using the standard
        EmbeddedFiles mechanism.
        Add a test of a hybrid in that format, with a password
        in PDF2 format (which uses the newer encryption format).
        
        Change-Id: I268784a370ef6223a3b91c38d14b0484fd984b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184082
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [6acfaaca9741e854db161e0afed029ff6c647dd0]

        sdext,pdfimport: Update password helper to use DocumentPasswordRequest2
        
        PDFPasswordRequest currently uses task::DocumentPasswordRequest
        but the test harnesses TestInteractionHandler only
        supports DocumentPasswordRequest2.
        So update to use '2', the only difference seems to be a flag to
        say whether we're opening or modifying a file, in the PDF import
        it's always a case of opening.
        
        Change-Id: I9822179db344fff3743e8c25a0c222338c1ad49e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184081
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [7bf563ff458f4bea85284beae4db071137948360]

        sdext,pdfimport: Fix password encoding on plain PDF import
        
        Use ISO_8859_1 rather than UTF8.
        Found on the 'encrypted_hello_world_r2.pdf' in the PDFium source.
        
        Fixes: 2bbe15a2cea2 ("tdf#55425 sdext,pdfimport: Replace checkEncryption")
        Change-Id: If69c897235352fd0133306004094edf9f9765020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183994
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [d629416be0a3742afda0f5c50c2f80a15553143c]

        tdf#55425, tdf#66580: sdext,pdfimport: embeddedFile password entry
        
        Add password entry for the new embeddedFile based detection.
        
        Note that we need to decrypt to be able to get pdfium to open the
        PDF at all, and fundamentally it's needed to read the filename.
        But that does mean we need the password during the detect phase.
        
        Change-Id: I67473158863ac6eb2ee389659449cf3b5582c579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183860
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [7c46138b61e1dfa9b5d649d6a797737304d225fa]

        tdf#55425, tdf#66580: sdext,pdfimport: Tame password prompts
        
        If one stage in the PDF detect asks for a password and the user
        tries and gives up, don't try asking for it again.
        After the next patch we've got another place that asks, so it can
        get annoying.
        
        Change-Id: I83f670cb452bed17443330b27b10b6a8224427af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183993
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [f3fd83098f3020c9f69032911754a5c1d2fc4fd5]

        tdf#55425,tdf#66580: sdext,pdfimport: Always stash password
        
        Always stash the password in the detect phase, even if it's not
        a hybrid.  This lets the plain PDF import use that password.
        
        Change-Id: Iebcd85428ebf81ea483543892687cf2ed56473ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183992
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [0d4d2563091eccb125a3d0f11b2df858d059d6a7]

        tdf#55425, tdf#66580: sdext,pdfimport: Extract the embedded file
        
        At this point we're pretty sure the embedded file is a hybrid.   Extract
        it.
        
        Change-Id: Id1aa42136692a1500a08455c6e7af5af3576b431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183952
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Dr. David Alan Gilbert  <dave@treblig.org>  [b7a8ce65b47bd85e31ae3ff8e81f23f79380de87]

        tdf#55425, tdf#66580: sdext,pdfimport: Filename/MIME lookup
        
        Look up the filename of the embedded file and find the MIME type we
        associate with it.  If the name doesn't match, then it's not a LO
        hybrid file.
        When PDFium can read the MIME type, we'll be able to check
        this MIME type against what is in the PDF.
        
        Change-Id: Iebccf67c1d86e7c6c16c2c1c9ed8d1c08df758fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183951
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [db34b11d7ccedc5c895fc89e74e8c78551d03ec0]

        vcl: convert PCD to use ImportOutput
        
        Change-Id: I00df142c13bd5c7c191c14c3a951156688b6918b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184398
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [437ae7ea1aeb5e8555460c385d2da57252fe9e31]

        vcl: convert PPM/PBM and DXF to use ImportOutput
        
        Change-Id: Iceca7fe247de8fe20b42303432b37adf8f684829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184397
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [70162a33fde729998e4d9c7558f3634352738772]

        vcl: Introduce ImportOutput to return BitmapEx or Animation
        
        Instead of returning Graphic, which is fully memory managed and
        registers into Memorymanager, instead return ImportOutput which
        returns the bitmap as BitmapEx and animation as Animation objects.
        
        The reason is that we don't want to add into a memory managed
        Graphic after import, as that might not be the intended use and
        can just cause trashing of Graphic. For example this happens when
        we want to import inside (Imp)Graphic itself, where we need to
        create a new (Imp)Graphic temporarily for no reason when swapping
        in, and then assign it to the existing (Imp)Graphic.
        
        This converts PNG, JPG, GIF, XPM, XBM filters to use ImportOutput.
        
        Change-Id: I862ef4125987436798314baaca95b6228f5d1a10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184396
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-22  Michael Meeks  <michael.meeks@collabora.com>  [131985e8d6d54d1c12aea565afb0c570c57ea380]

        Avoid un-necessary busy timer looking to swap out images.
        
        We can start this when we need to in a thread-safe way,
        cf. Timer::Start, Task::Start etc.
        
        Saves CPU, and better - saves debug churn and SocketPoll
        wakeups in quiescent COOL instances.
        
        Change-Id: Ib0e668702bcdfa9ffb34daf8c2a220af55dcc9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184415
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-21  Stanislav Horacek  <stanislav.horacek@gmail.com>  [3a729a2b9716902097cc5ba35615b55882d98e9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 94037b55ded6fd2bbc7ba1c832ddfe55cc6fabaa
          - use consistent markup for On... event properties
            
            Change-Id: I65cb7bbebc9360137169c1b2b8580f9470563a4c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184418
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-04-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a46e5dcf7d8e814d66eeee039f6d06e96b21ac14]

        cid#1646578 Logically dead code
        
        Change-Id: I590d2cf930421de0319dfb705af5b80f793a524a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184408
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-21  Jim Raykowski  <raykowj@gmail.com>  [8316409b68a97f0129b1fd67bcb8c61a7010ceec]

        Resolves tdf#166186 Showing the context menu for in-place editing
        
        ends in-place editing (x11 only)
        
        Fixing this revealed that ESC ends in-place editing when the popup
        menu is active. Esc a second time ends the popup menu. This patch
        fixes this issue as well.
        
        Change-Id: Ia617d27fcdf7221263bc9b2ae96d8a8ebf934fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184400
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-04-21  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f78d03805bc47682c0900e7c0713fb2441cf92f6]

        Remove obsolete fw declarations from l10ntools/ linguistic/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I25d8902ad3fbd1f6768dbb030e96c761aa5b361a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183892
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-21  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fb0000af76c9461761ad278a87c2963026baee29]

        Remove obsolete fw declarations from framework/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ib0094116132b11761c53dfd3e33af53d01e30093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183890
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-21  Dr. David Alan Gilbert  <dave@treblig.org>  [bc680499b5fa782c7396f7ab688c8f5498b58b46]

        tdf#55425, tdf#66580: sdext,pdfimport: embeddedFile detection
        
        Check for exactly one attachment in the PDF and get it's name.
        A PDF with 0 or more than 1 attachment isn't a LO hybrid.
        
        Change-Id: I9d556b1b0435b734c278b58380589c6e3bca9964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183950
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-21  Julien Nabet  <serval2412@yahoo.fr>  [a1807689caca6a924969f8ed7dab5c7b09690325]

        Try to fix TB MSVC Analyzer
        
        Following 53ab599609803e395774b5e0c93192cf4cbe1a35
        "Fix the ESC key behavior in the sidebar sdNavigator"
        
        Change-Id: Ie61e3fb91e4752629617279751a0bc3fbaaaec2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184406
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-21  Mike Kaganski  <mike.kaganski@collabora.com>  [985e26bd407a7ec3f1b9fe002ab035e498b10055]

        Flatten some code
        
        Change-Id: Ib0f82e88392b3da9a03477ee18e70827df7f09bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184404
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1f060b6773912c3b2da7c8af678e20ca786a4d29]

        vcl: move SwapInfo to own header file
        
        Change-Id: Idc936b66158633de13c4d307d2d82bdb092c876a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184395
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-21  Jim Raykowski  <raykowj@gmail.com>  [53ab599609803e395774b5e0c93192cf4cbe1a35]

        Fix the ESC key behavior in the sidebar sdNavigator
        
        This patch allows the sidebar FocusManager to handle the ESC key when
        the keyboard focus is in the Navigator sidebar panel. I could not make
        program execution enter the Navigator window KeyInputHdl when dragging
        an object and pressing escape. The test for in-drag is dropped by this
        patch. Possibly pre-welded it was needed. Also, I am unsure of the use
        of catching ESCAPE in the Navigator to end a slide show. The patch adds
        a test to determine if a slide show is running before ending it and
        consuming the escape key so no furthing key-input processing is done.
        
        Change-Id: Ib8cc465dd11988ac95877782e7a54b1e3fdfb2a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184344
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-04-21  Dr. David Alan Gilbert  <dave@treblig.org>  [9b401a09c5cde0250457f45d9540ee15ab8e43f9]

        tdf#55425, tdf#66580: sdext,pdfimport: Start detecting newer hybrids
        
        There are two mechanisms in Hybrid PDFs to mark the data, one
        uses a non-standardised entry in the PDF trailer, another newer one , uses
        a well-known name for a standard PDF embedded file.
        
        The import filter currently just detects the non-standard trailer
        addition, not the embedded file case, however the export code
        doesn't write the old trailer for some formats, e.g. PDF/UA
        and there's also a desire to get rid of the non-standard stuff
        (see tdf#66580 ).
        
        Add a detection mechanism for the newer embeddedFile form,
        keep the old trailer detect to be able to load ancient files
        that were generated before the embeddedFile format was added.
        
        This is the first step of opening the file and wiring up
        PDFium.
        
        Change-Id: I44c0ffeac5e62dc1345c604bd695a2c2da37260a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183765
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-21  Mike Kaganski  <mike.kaganski@collabora.com>  [f2820a2a8414edefe2f1a0eeb611aa70bc99535a]

        tdf#166260: handle break portion early
        
        Otherwise, it may get handled in the "if ( nWidth )" branch, and
        increment nCurrStart incorrectly.
        
        Change-Id: Ia9fa8a24a9fcc6cfed774a11b0a0b32d6310f47d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184391
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-20  Aron Budea  <aron.budea@collabora.com>  [8397af1bc49897a2d8ebe30c1e960661271503e9]

        tdf#165886 sc: parse various quote characters
        
        Otherwise roundtripped formulas in XLSX containing them
        can end up with extra parenthesis, eg:
         - Expected: OR(D1=0,D1<>““)
         - Actual  : OR(D1=0,D1<>““))
        
        Change-Id: I6d296687cc2467ca0cdee329f9b04f6c956d2de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183987
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f74142e6d02a65e811f9b84bada99b1489c0f9ff]

        cid#1646564 Unchecked dynamic_cast
        
        and
        
        cid#1646560 Unchecked dynamic_cast
        
        Change-Id: I6e66128418fa2c4fdd2f0a1430e8dd17b5e5c684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82e35dbcf9bac39a781081fae3ea434cd7d70894]

        cid#1646566 Dereference null return value
        
        Change-Id: I7464dd0640119c2f3e6317fc0d2672aaf8019718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184383
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [06d4aadb011fe7aa0c3d4e1d779b165b593c9f21]

        cid#1555714 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556132 COPY_INSTEAD_OF_MOVE
        cid#1557140 COPY_INSTEAD_OF_MOVE
        cid#1557729 COPY_INSTEAD_OF_MOVE
        cid#1646558 COPY_INSTEAD_OF_MOVE
        cid#1646562 COPY_INSTEAD_OF_MOVE
        cid#1646563 COPY_INSTEAD_OF_MOVE
        cid#1646565 COPY_INSTEAD_OF_MOVE
        cid#1646567 COPY_INSTEAD_OF_MOVE
        cid#1646570 COPY_INSTEAD_OF_MOVE
        cid#1555021 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibf73c38e83e3958dc4766cf2011298ce4cffe660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184381
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c82191e7b395b79d3370af9edfac99b247791d5]

        cid#1646569 Use of auto that causes a copy
        
        and
        
        cid#1646559 Use of auto that causes a copy
        
        Change-Id: I2c79f76d14cbd03444c2dcba4088f0e73ac0c64c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184382
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-20  Patrick Luby  <guibmacdev@gmail.com>  [0e0f3ed6352cb91ccd2f5d74c97f59fe42838f41]

        Explicitly pass native NSWindow to updateWindowCollectionBehavior()
        
        updateWindowCollectionBehavior() needs to be called during creation
        of a SalFrameWindow. However, the NSWindow has not yet been assigned
        to the AquaSalFrame's mpNSWindow instance variable yet.
        
        Change-Id: I7be538cba11c4eb3e4ae0f47e6842ead1a98cf4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184389
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-20  Julien Nabet  <serval2412@yahoo.fr>  [f28f894267f7f0d8061db3605a04d17b3f743545]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2487e71ba257e1115eda0cab2d86186845b07239
          - Related tdf#166251 Use ";" for separator in SUMIF function
            
            Change-Id: Iccec35b9eb3d0f783d73dc7ea63bb9407deb51dd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184388
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-20  Patrick Luby  <guibmacdev@gmail.com>  [ea0489fe2da17f8d7f31995affa5abe353f6cc6f]

        Fix build breakage in harfbuzz when building with LODE on macOS
        
        By default, configure does not search for the pkgconf command in
        $LODE_HOME/opt/bin and, as a result, PKG_CONFIG is not set in
        config_host.mk.
        
        Change-Id: Ia0512c0506dec268594c3156d6c5133fe3baaeab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184283
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [595fd58cf12e7fddf6cf16bcd7a4eaeaf0f9bbc6]

        Remove duplicated include
        
        Change-Id: I2f43b620c0bac8ddb9c0229281e6d9a74fc60f51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184356
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84ce5c250fe482c221120ecaf851f32393a1eca7]

        Fix typo
        
        Change-Id: Ic980e063e84136552ff88b6bf41c40698426b58a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184378
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ac689643d8d1d81d67b8a5ef051393cde132fe9e]

        Fix command line call for right Help modules (core part)
        
        The new Help could not handle command line with --helpwriter (calc/base/...) because
        the HID was not well set.
        
        Now we pass an unique HID for each module.
        
        This is the core part.
        
        A Help part will follow.
        
        Change-Id: Iee0772785711083af02af8384fdf0868aecacc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184366
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-04-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ecc7af7170eab819a48f9f4e5226fee06fbb4741]

        tdf#166256 Extended tips for options - text boundaries
        
        Change-Id: I5a29838bad6a4156ec13cbe641e1961a30d7642b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184386
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-04-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e6d9d80230bd7de36d2ffcc24078595e1d463eb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 154b5cad52d0ac46e3268a5712d998fcef9f3d2c
          - tdf#166256 Bookmarks for text boundaries page
            
            Change-Id: I75073e8d723642db779d97677a817f9fe99f9176
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184387
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dc105104b98851278141aa36b3c4906d763b0800]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7e19ae098a27a7c6724c6f5e56b77831dc7e5a95
          - tdf#166256 Update Help with object boundaries options + autocomplete.
            
            Change-Id: Id80ad5e0bacb7c8bfb037eceef7b6657139c6ed1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184379
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-20  Jim Raykowski  <raykowj@gmail.com>  [7af4a3191d9172e4af7f6e6b3b99fc530ab2ae29]

        tdf#139633 Draw Navigator rename pages and objects take two
        
        Recent review of the patch done to provide in-place renaming in the
        Writer Navigator (commit 492c94abe05e5ac213475cdd85f158b7a462f824)
        inspired me to review what had been done for this for the Draw
        Navigator. This patch revamps the original work and makes the context
        menu item Rename consistent with the behavior of the Writer Navigator
        context menu item Rename. It starts in-place editing instead of opening
        the Name dialog.
        
        Known issues:
        
        * Gtk3 in-place editing doesn't notify when editing is canceled by
        Escape. This leaves the SdPageObjsTLV editing flag true which causes the
        Enter key to start entry editing instead of going to the object in the
        document.
        
        * For the Navigator in the sidebar, sal in-place editing doesn't revert
        to the original text when Escape is pressed. The sidebar FocusManager
        handling of Escape for focus in a panel content location is the culprit.
        
        Change-Id: If51f962daf8f9f10a738fa8483fc4626a037bc6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184321
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-04-19  Simon Chenery  <simon_chenery@yahoo.com>  [6869da60961a6213fc961c2ece371c0f18038cde]

        tdf#145614 Convert #define FUZZY_EDGE to constexpr
        
        Change-Id: Iea10b1f370b7b6fb77670523c2499c2a7379ccb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183212
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [00ebf365dd33d2272fdbb624976d6a6f94c3820c]

        tdf#130857 qt weld: Don't unconditionally make dialogs modal
        
        Despite QDialog::modal [1] defaulting to false like GtkWindow::modal [2]
        and QtBuilder::setDialogProperties correctly evaluating the "modal"
        property in .ui files, even non-modal dialogs were run as modal
        dialogs when using SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        (Seen with Writer's "Insert" -> "Fields" -> "More Fields..."
        dialog in a WIP branch.)
        
        This is because QDialog::open was used so far to open the dialog,
        for which the doc [3] explains:
        
        > Shows the dialog as a window modal dialog, returning immediately.
        
        Use QDialog::show/QWidget::show instead to show the dialog, which
        does unconditionally run the dialog as modal.
        
        This also makes the "Close" button work for that dialog.
        Previously, it wouldn't close the dialog because
        
            bAllow = !pDialog->get_visible() || !pDialog->get_modal();
        
        in SfxChildWindow::QueryClose would evaluate to false
        because the dialog was both, visible and modal.
        
        [1] https://doc.qt.io/qt-6/qdialog.html#modal-prop
        [2] https://docs.gtk.org/gtk3/property.Window.modal.html
        [3] https://doc.qt.io/qt-6/qdialog.html#open
        
        Change-Id: I099d990c614b592751e01791b48405c674b6ed3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184377
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [5de816bdeb927237262ac6c165b0a5ae0cb8466f]

        sw: Resave fielddialog.ui with glade 3.40
        
        This is Writer's "Insert" -> "Field" -> "More Fields..."
        dialog.
        
        Change-Id: Ic77b96cf659292307a7be14dc1cb3d0c2d01da4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184376
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [62b30a8272d22d8b4b83556afee73824eafc52fb]

        tdf#130857 qt weld: Implement QtInstanceTreeView::get_iter_first
        
        Change-Id: I2874958292ae188d24911f14698f2da44015d65c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184375
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [e5e491c3dbfdc5a51d7df0230191fd8d4aa39177]

        tdf#130857 svx: Use container size for search bar item windows
        
        Set the CheckButtonItemWindow and FindTextFieldControl
        size to the size of the containers they contain
        (see corresponding .ui files svx/uiconfig/ui/checkbuttonbox.ui
        and svx/uiconfig/ui/findbox.ui), not only to the
        size of the checkbox/combobox inside of those containers.
        
        While the size is the same for gen and gtk3 on Linux, it
        isn't in a WIP branch of mine experimenting to support
        using native Qt widgets for those when using the qt6 VCL
        plugin, resulting in the checkbox/combobox not being shown
        completely.
        
        Change-Id: I5ae47adcf21f787d69e130eb2e45737a32676591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184374
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [03774463ff6798309a67eec10f896f1416d986fa]

        svx: Resave checkbuttonbox.ui with glade 3.40
        
        This .ui file is used for the checkboxes in
        the Search/Find toolbar that opens when pressing
        Ctrl+F in Writer.
        
        Change-Id: Ic1c5d0f5245fc29a0473b0a882d985c4fdd44f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184373
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [c64781bde0ccc2a4bb23b57e7b922b47ead92f1d]

        svx: Resave findbox.ui with glade 3.40
        
        This .ui file is used for the combobox in
        the Search/Find toolbar that opens when pressing
        Ctrl+F in Writer.
        
        Change-Id: I6d1f12a8e217a1dbf68e2a13cddbd14cf8b8ac58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184372
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [f2bf5e608c2150a478d8612e4664ba9279a00853]

        tdf#130857 qt weld: Convert accelerator for menu entries
        
        Convert potential "_" GTK accelerator text to "&" Qt one for the
        menu entry text/label.
        
        Otherwise, entries in the menu of the "Modify" menu button
        in Math's "Format" -> "Fonts" dialog show text using
        literal "_" when using the qt6 VCL plugin with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 .
        
        Change-Id: Ifeab698fa458a486d2b223dab588329a2f83ea77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184371
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [3229e8b0a52f22a11c94cdc95cef90fd1aaeb718]

        tdf#130857 qt weld: Support Math's "Format" -> "Fonts" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog can be triggered in Math via the
        "Format" -> "Fonts" menu entry.
        
        Change-Id: I4350a92433444d95a328d2d459156ab639216ed5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184370
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [adc5d928ac419dfcf15135a4a69319b938a0768b]

        tdf#130857 qt weld: Signal on combobox text, not index change
        
        So far QtInstanceComboBox was calling weld::ComboBox::signal_changed
        to notify of a change of the selected entry when the
        QComboBox::currentIndexChanged signal was emitted.
        
        However, that signal is also emitted when the
        same entry remains selected, but its index changes,
        which happens when another entry is inserted before
        the currently selected entry.
        
        This would trigger an infinite recursion with the
        SmFontPickListBox's SelectHdl that gets called by
        weld::ComboBox::signal_changed and then removes and
        reinserts an entry.
        
        See below for a sample backtrace seen with upcoming change
        
            Change-Id: I4350a92433444d95a328d2d459156ab639216ed5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Apr 19 12:48:18 2025 +0200
        
                tdf#130857 qt weld: Support Math's "Format" -> "Fonts" dialog
        
        but without this commit here for the following scenario:
        
        * Start Math
        * "Format" -> "Fonts"
        * click the "Modify" button, select "Math"
        * select any font in the EntryTreeView
        * confirm using the "OK" button
        
        To avoid such problems, don't use a changed index,
        but a text change as the criterion for a change of
        the selected entry, i.e. connect to the
        QComboBox::currentTextChanged signal instead of the
        QComboBox::currentIndexChanged one.
        
        (The assumption is that different entries also use a
        unique text. While that is not technically required,
        it should always be the case, as it's also needed for
        the user to be able to distinguish between them.)
        
        Backtrace:
        
            [...]
            #69195 0x00007f48aaecc45a in SmFontPickListBox::SelectHdl (this=0x55cacbb3fdb0) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:142
            #69196 0x00007f48aaecc37d in SmFontPickListBox::LinkStubSelectHdl (instance=0x55cacbb3fdb0, data=...) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:134
            #69197 0x00007f48cfa3f9e1 in Link<weld::ComboBox&, void>::Call (this=0x55cacc0bc150, data=...) at include/tools/link.hxx:105
            #69198 0x00007f48cfa3f5ec in weld::ComboBox::signal_changed (this=0x55cacc0bc108) at include/vcl/weld.hxx:766
            #69199 0x00007f48cfa3588d in QtInstanceComboBox::signalChanged (this=0x55cacc0bbf90) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:382
            #69200 0x00007f48cfa3fe01 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}::operator()() const (this=0x7ffde4d63c90) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #69201 0x00007f48cfa3fd39 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}&&) (args=0x7ffde4d64050, fn=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #69202 0x00007f48cfa3fc6b in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)
                (f=(void (QtInstanceComboBox::*)(QtInstanceComboBox * const)) 0x7f48cfa35850 <QtInstanceComboBox::signalChanged()>, o=0x55cacc0bbf90, arg=0x7ffde4d64050)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #69203 0x00007f48cfa3fbed in QtPrivate::FunctionPointer<void (QtInstanceComboBox::*)()>::call<QtPrivate::List<>, void>(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)
                (f=(void (QtInstanceComboBox::*)(QtInstanceComboBox * const)) 0x7f48cfa35850 <QtInstanceComboBox::signalChanged()>, o=0x55cacc0bbf90, arg=0x7ffde4d64050)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #69204 0x00007f48cfa3fb16 in QtPrivate::QCallableObject<void (QtInstanceComboBox::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x55cacc0bc300, r=0x55cacc0bbf90, a=0x7ffde4d64050, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #69205 0x00007f48ce9061a2 in QtPrivate::QSlotObjectBase::call (this=0x55cacc0bc300, r=0x55cacc0bbf90, a=0x7ffde4d64050) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #69206 0x00007f48ceb29fb4 in doActivate<false> (sender=0x55cacc0ee6f0, signal_index=12, argv=0x7ffde4d64050) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #69207 0x00007f48ceb201a3 in QMetaObject::activate (sender=0x55cacc0ee6f0, m=0x7f48cd594f88 <QComboBox::staticMetaObject>, local_signal_index=5, argv=0x7ffde4d64050)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #69208 0x00007f48cc9d826b in QMetaObject::activate<void, int> (sender=0x55cacc0ee6f0, mo=0x7f48cd594f88 <QComboBox::staticMetaObject>, local_signal_index=5, ret=0x0, args=@0x7ffde4d64094: 1)
                at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #69209 0x00007f48ccc6941d in QComboBox::currentIndexChanged (this=0x55cacc0ee6f0, _t1=1) at qtbase/src/widgets/Widgets_autogen/include/moc_qcombobox.cpp:367
            #69210 0x00007f48ccc67f2a in QComboBoxPrivate::emitCurrentIndexChanged (this=0x55cac979c770, index=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:1452
            #69211 0x00007f48ccc67e58 in QComboBoxPrivate::rowsInserted (this=0x55cac979c770, parent=..., start=0, end=0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:1163
            #69212 0x00007f48ccc81c62 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}::operator()() const (this=0x7ffde4d642a0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #69213 0x00007f48ccc81bbd in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}&&) (args=0x7ffde4d64680, fn=...)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #69214 0x00007f48ccc81b77 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call
                (f=(void (QComboBoxPrivate::*)(QComboBoxPrivate * const, const QModelIndex &, int, int)) 0x7f48ccc67c80 <QComboBoxPrivate::rowsInserted(QModelIndex const&, int, int)>, o=0x55cac979c770, arg=0x7ffde4d64680)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #69215 0x00007f48ccc81ae1 in QtPrivate::FunctionPointer<void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call<QtPrivate::List<QModelIndex const&, int, int>, void>
                (f=(void (QComboBoxPrivate::*)(QComboBoxPrivate * const, const QModelIndex &, int, int)) 0x7f48ccc67c80 <QComboBoxPrivate::rowsInserted(QModelIndex const&, int, int)>, o=0x55cac979c770, arg=0x7ffde4d64680)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #69216 0x00007f48ccc81a10 in QtPrivate::QPrivateSlotObject<void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QtPrivate::List<QModelIndex const&, int, int>, void>::impl
                (which=1, this_=0x55cacc10a9c0, r=0x55cacc0ee6f0, a=0x7ffde4d64680, ret=0x0) at qtbase/src/corelib/kernel/qobject_p.h:272
            #69217 0x00007f48ce9061a2 in QtPrivate::QSlotObjectBase::call (this=0x55cacc10a9c0, r=0x55cacc0ee6f0, a=0x7ffde4d64680) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #69218 0x00007f48ceb29fb4 in doActivate<false> (sender=0x55cacc0f0a90, signal_index=13, argv=0x7ffde4d64680) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #69219 0x00007f48ceb201a3 in QMetaObject::activate (sender=0x55cacc0f0a90, m=0x7f48cf440ce8 <QAbstractItemModel::staticMetaObject>, local_signal_index=10, argv=0x7ffde4d64680)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #69220 0x00007f48cef6f185 in QMetaObject::activate<void, QModelIndex, int, int, QAbstractItemModel::QPrivateSignal>
                (sender=0x55cacc0f0a90, mo=0x7f48cf440ce8 <QAbstractItemModel::staticMetaObject>, local_signal_index=10, ret=0x0, args=..., args=@0x7ffde4d646f0: 0, args=@0x7ffde4d646ec: 0, args=...) at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #69221 0x00007f48cef6302a in QAbstractItemModel::rowsInserted (this=0x55cacc0f0a90, _t1=..., _t2=0, _t3=0, _t4=...) at qtbase/src/corelib/Core_autogen/include/moc_qabstractitemmodel.cpp:688
            #69222 0x00007f48cef62fa6 in QAbstractItemModel::endInsertRows (this=0x55cacc0f0a90) at /home/michi/development/git/qt5/qtbase/src/corelib/itemmodels/qabstractitemmodel.cpp:2920
            #69223 0x00007f48cde59998 in QStandardItemModelPrivate::rowsInserted (this=0x55cacc0f19f0, parent=0x55cacc0ef360, row=0, count=1) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:629
            #69224 0x00007f48cde59c93 in QStandardItemPrivate::insertRows (this=0x55cacc0f1680, row=0, count=1, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:501
            #69225 0x00007f48cde5badd in QStandardItem::insertRow (this=0x55cacc0ef360, row=0, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:1605
            #69226 0x00007f48cde5d93f in QStandardItemModel::insertRow (this=0x55cacc0f0a90, row=0, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:2684
            #69227 0x00007f48ccc74eca in QStandardItemModel::insertRow (this=0x55cacc0f0a90, arow=0, aitem=0x55cacc104ff0) at qtbase/src/gui/itemmodels/qstandarditemmodel.h:400
            #69228 0x00007f48ccc6b2b7 in QComboBox::insertItem (this=0x55cacc0ee6f0, index=0, icon=..., text=..., userData=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:2353
            #69229 0x00007f48cf972c77 in QComboBox::insertItem (this=0x55cacc0ee6f0, aindex=0, atext=..., auserData=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.h:227
            #69230 0x00007f48cfa39613 in QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0::operator()() const (this=0x55cacc10b630) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:45
            #69231 0x00007f48cfa394e5 in std::__invoke_impl<void, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&>(std::__invoke_other, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&) (__f=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61
            #69232 0x00007f48cfa394a5 in std::__invoke_r<void, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&>(QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&) (__fn=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111
            #69233 0x00007f48cfa3938d in std::_Function_handler<void(), QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0>::_M_invoke (__functor=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290
            #69234 0x00007f48cf9f9f5e in std::function<void()>::operator() (this=0x7ffde4d64ed0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591
            #69235 0x00007f48cf9f172f in QtInstance::RunInMainThread (this=0x55cac963d130, func=...) at vcl/qt6/../qt5/QtInstance.cxx:206
            #69236 0x00007f48cfa3600f in QtInstanceComboBox::insert (this=0x55cacc0bbf90, nPos=0, rStr="OpenSymbol", pId=0x0, pIconName=0x0, pImageSurface=0x0) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:37
            #69237 0x00007f48aaecd82f in weld::ComboBox::insert_text (this=0x55cacc0bc108, pos=0, rStr="OpenSymbol") at include/vcl/weld.hxx:793
            #69238 0x00007f48aaecc45a in SmFontPickListBox::SelectHdl (this=0x55cacbb3fdb0) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:142
            #69239 0x00007f48aaecc37d in SmFontPickListBox::LinkStubSelectHdl (instance=0x55cacbb3fdb0, data=...) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:134
            #69240 0x00007f48cfa3f9e1 in Link<weld::ComboBox&, void>::Call (this=0x55cacc0bc150, data=...) at include/tools/link.hxx:105
            #69241 0x00007f48cfa3f5ec in weld::ComboBox::signal_changed (this=0x55cacc0bc108) at include/vcl/weld.hxx:766
            #69242 0x00007f48cfa3588d in QtInstanceComboBox::signalChanged (this=0x55cacc0bbf90) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:382
            #69243 0x00007f48cfa3fe01 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}::operator()() const (this=0x7ffde4d65110) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #69244 0x00007f48cfa3fd39 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)::{lambda()#1}&&) (args=0x7ffde4d654d0, fn=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #69245 0x00007f48cfa3fc6b in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceComboBox::*)()>::call(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)
                (f=(void (QtInstanceComboBox::*)(QtInstanceComboBox * const)) 0x7f48cfa35850 <QtInstanceComboBox::signalChanged()>, o=0x55cacc0bbf90, arg=0x7ffde4d654d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #69246 0x00007f48cfa3fbed in QtPrivate::FunctionPointer<void (QtInstanceComboBox::*)()>::call<QtPrivate::List<>, void>(void (QtInstanceComboBox::*)(), QtInstanceComboBox*, void**)
                (f=(void (QtInstanceComboBox::*)(QtInstanceComboBox * const)) 0x7f48cfa35850 <QtInstanceComboBox::signalChanged()>, o=0x55cacc0bbf90, arg=0x7ffde4d654d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #69247 0x00007f48cfa3fb16 in QtPrivate::QCallableObject<void (QtInstanceComboBox::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x55cacc0bc300, r=0x55cacc0bbf90, a=0x7ffde4d654d0, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #69248 0x00007f48ce9061a2 in QtPrivate::QSlotObjectBase::call (this=0x55cacc0bc300, r=0x55cacc0bbf90, a=0x7ffde4d654d0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #69249 0x00007f48ceb29fb4 in doActivate<false> (sender=0x55cacc0ee6f0, signal_index=12, argv=0x7ffde4d654d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #69250 0x00007f48ceb201a3 in QMetaObject::activate (sender=0x55cacc0ee6f0, m=0x7f48cd594f88 <QComboBox::staticMetaObject>, local_signal_index=5, argv=0x7ffde4d654d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #69251 0x00007f48cc9d826b in QMetaObject::activate<void, int> (sender=0x55cacc0ee6f0, mo=0x7f48cd594f88 <QComboBox::staticMetaObject>, local_signal_index=5, ret=0x0, args=@0x7ffde4d65514: 1)
                at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #69252 0x00007f48ccc6941d in QComboBox::currentIndexChanged (this=0x55cacc0ee6f0, _t1=1) at qtbase/src/widgets/Widgets_autogen/include/moc_qcombobox.cpp:367
            #69253 0x00007f48ccc67f2a in QComboBoxPrivate::emitCurrentIndexChanged (this=0x55cac979c770, index=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:1452
            #69254 0x00007f48ccc67e58 in QComboBoxPrivate::rowsInserted (this=0x55cac979c770, parent=..., start=0, end=0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:1163
            #69255 0x00007f48ccc81c62 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}::operator()() const (this=0x7ffde4d65720) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #69256 0x00007f48ccc81bbd in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call(void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QComboBoxPrivate*, void**)::{lambda()#1}&&) (args=0x7ffde4d65b00, fn=...)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #69257 0x00007f48ccc81b77 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul, 2ul>, QtPrivate::List<QModelIndex const&, int, int>, void, void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call
                (f=(void (QComboBoxPrivate::*)(QComboBoxPrivate * const, const QModelIndex &, int, int)) 0x7f48ccc67c80 <QComboBoxPrivate::rowsInserted(QModelIndex const&, int, int)>, o=0x55cac979c770, arg=0x7ffde4d65b00)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #69258 0x00007f48ccc81ae1 in QtPrivate::FunctionPointer<void (QComboBoxPrivate::*)(QModelIndex const&, int, int)>::call<QtPrivate::List<QModelIndex const&, int, int>, void>
                (f=(void (QComboBoxPrivate::*)(QComboBoxPrivate * const, const QModelIndex &, int, int)) 0x7f48ccc67c80 <QComboBoxPrivate::rowsInserted(QModelIndex const&, int, int)>, o=0x55cac979c770, arg=0x7ffde4d65b00)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #69259 0x00007f48ccc81a10 in QtPrivate::QPrivateSlotObject<void (QComboBoxPrivate::*)(QModelIndex const&, int, int), QtPrivate::List<QModelIndex const&, int, int>, void>::impl
                (which=1, this_=0x55cacc10a9c0, r=0x55cacc0ee6f0, a=0x7ffde4d65b00, ret=0x0) at qtbase/src/corelib/kernel/qobject_p.h:272
            #69260 0x00007f48ce9061a2 in QtPrivate::QSlotObjectBase::call (this=0x55cacc10a9c0, r=0x55cacc0ee6f0, a=0x7ffde4d65b00) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #69261 0x00007f48ceb29fb4 in doActivate<false> (sender=0x55cacc0f0a90, signal_index=13, argv=0x7ffde4d65b00) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #69262 0x00007f48ceb201a3 in QMetaObject::activate (sender=0x55cacc0f0a90, m=0x7f48cf440ce8 <QAbstractItemModel::staticMetaObject>, local_signal_index=10, argv=0x7ffde4d65b00)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #69263 0x00007f48cef6f185 in QMetaObject::activate<void, QModelIndex, int, int, QAbstractItemModel::QPrivateSignal>
                (sender=0x55cacc0f0a90, mo=0x7f48cf440ce8 <QAbstractItemModel::staticMetaObject>, local_signal_index=10, ret=0x0, args=..., args=@0x7ffde4d65b70: 0, args=@0x7ffde4d65b6c: 0, args=...) at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #69264 0x00007f48cef6302a in QAbstractItemModel::rowsInserted (this=0x55cacc0f0a90, _t1=..., _t2=0, _t3=0, _t4=...) at qtbase/src/corelib/Core_autogen/include/moc_qabstractitemmodel.cpp:688
            #69265 0x00007f48cef62fa6 in QAbstractItemModel::endInsertRows (this=0x55cacc0f0a90) at /home/michi/development/git/qt5/qtbase/src/corelib/itemmodels/qabstractitemmodel.cpp:2920
            #69266 0x00007f48cde59998 in QStandardItemModelPrivate::rowsInserted (this=0x55cacc0f19f0, parent=0x55cacc0ef360, row=0, count=1) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:629
            #69267 0x00007f48cde59c93 in QStandardItemPrivate::insertRows (this=0x55cacc0f1680, row=0, count=1, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:501
            #69268 0x00007f48cde5badd in QStandardItem::insertRow (this=0x55cacc0ef360, row=0, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:1605
            #69269 0x00007f48cde5d93f in QStandardItemModel::insertRow (this=0x55cacc0f0a90, row=0, items=...) at /home/michi/development/git/qt5/qtbase/src/gui/itemmodels/qstandarditemmodel.cpp:2684
            #69270 0x00007f48ccc74eca in QStandardItemModel::insertRow (this=0x55cacc0f0a90, arow=0, aitem=0x55cacbf475e0) at qtbase/src/gui/itemmodels/qstandarditemmodel.h:400
            #69271 0x00007f48ccc6b2b7 in QComboBox::insertItem (this=0x55cacc0ee6f0, index=0, icon=..., text=..., userData=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.cpp:2353
            #69272 0x00007f48cf972c77 in QComboBox::insertItem (this=0x55cacc0ee6f0, aindex=0, atext=..., auserData=...) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qcombobox.h:227
            #69273 0x00007f48cfa39613 in QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0::operator()() const (this=0x55cacbfa0500) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:45
            #69274 0x00007f48cfa394e5 in std::__invoke_impl<void, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&>(std::__invoke_other, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&) (__f=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61
            #69275 0x00007f48cfa394a5 in std::__invoke_r<void, QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&>(QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0&) (__fn=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111
            #69276 0x00007f48cfa3938d in std::_Function_handler<void(), QtInstanceComboBox::insert(int, rtl::OUString const&, rtl::OUString const*, rtl::OUString const*, VirtualDevice*)::$_0>::_M_invoke (__functor=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290
            #69277 0x00007f48cf9f9f5e in std::function<void()>::operator() (this=0x7ffde4d66350) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591
            #69278 0x00007f48cf9f172f in QtInstance::RunInMainThread (this=0x55cac963d130, func=...) at vcl/qt6/../qt5/QtInstance.cxx:206
            #69279 0x00007f48cfa3600f in QtInstanceComboBox::insert (this=0x55cacc0bbf90, nPos=0, rStr="NotoSerifTamilSlanted Thin", pId=0x0, pIconName=0x0, pImageSurface=0x0) at vcl/qt6/../qt5/QtInstanceComboBox.cxx:37
            #69280 0x00007f48aaecd82f in weld::ComboBox::insert_text (this=0x55cacc0bc108, pos=0, rStr="NotoSerifTamilSlanted Thin") at include/vcl/weld.hxx:793
            #69281 0x00007f48aaecc9ce in SmFontPickListBox::Insert (this=0x55cacbb3fdb0, rFont=...) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:169
            #69282 0x00007f48aaecc18e in SmFontPickList::ReadFrom (this=0x55cacbb3fdb0, rDialog=...) at /home/michi/development/git/libreoffice/starmath/source/utility.cxx:116
            #69283 0x00007f48aadfa926 in SmFontTypeDialog::MenuSelectHdl (this=0x7ffde4d6f5d8, rIdent="math") at /home/michi/development/git/libreoffice/starmath/source/dialog.cxx:568
            #69284 0x00007f48aadfa62d in SmFontTypeDialog::LinkStubMenuSelectHdl (instance=0x7ffde4d6f5d8, data="math") at /home/michi/development/git/libreoffice/starmath/source/dialog.cxx:529
            #69285 0x00007f48cfa79361 in Link<rtl::OUString const&, void>::Call (this=0x55cacc103d80, data="math") at include/tools/link.hxx:105
            #69286 0x00007f48cfa78941 in weld::MenuButton::signal_selected (this=0x55cacc103d78, rIdent="math") at include/vcl/weld.hxx:1660
            #69287 0x00007f48cfa73c63 in QtInstanceMenuButton::handleMenuItemTriggered (this=0x55cacc103ba0, pAction=0x55cacc0d5630) at vcl/qt6/../qt5/QtInstanceMenuButton.cxx:189
            [...]
        
        Change-Id: Iea89d6d1c75f38c6e1839da8990c96a88f0e0ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184369
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9176b4c53c516bb642c1a2ccfa75e9a389a3e9fe]

        Remove obsolete fw declarations from forms/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ia59ebd1f5edddb278d77a234b222ae90c5945aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183888
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d5a4086b1f8f38bfa79700df93e525e1bc2be1de]

        Remove obsolete fw declarations from filter/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ia06dc5ab883e515fed05d8a3f05e248b5127eb39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183886
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [aba8ab7cf0e2c49e8a4e4953790e73ade92863ad]

        Remove obsolete fw declarations from fpicker/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ie44abd2cc79fffbde80eb17af866b2ac9e7d5c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183889
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-19  Noel Grandin  <noelgrandin@gmail.com>  [93a779e56cc9cb02c0e053d7a58589ed9fd10636]

        speed up EvalMatrix
        
        by (a) using the iterator instead of doing an index lookup for each iteration and (b) switching the loop so we work with the natural data layout
        
        Change-Id: I35bca868f72657c279c33e221deafd672272c8aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184358
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [673ed9e1b126eafa35a66e23de2d6032cc72ede9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad32d055674e5e934c5d0e0ee94c060293eb6088
          - mute L10n in python code examples
            
            Change-Id: I701d7278ef6e0e1fbb74bf3db401bc0f1f60e1e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184368
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e68691d78a946b7d492e2328fdc3b70db3f5748]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 50b461ba72660a58b0b37ceecc9ed7f0ca9124dc
          - Fix command line call for right module Help (Help part)
            
            Add unique bookmark to help main entry page of each module.
            
            Change-Id: Ia08a7a8c73d8d65239611a00d141898f153b2af4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184365
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [e35a70707094d444ae7146b0e4be397499c4f0d9]

        tdf#130857 Define widgets in Math's font dialog in order
        
        Switch the order in which the widgets in the .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        This dialog can be triggered in Math as follows:
        
        * "Format" -> "Fonts"
        * click the "Modify" menu buttton and select any entry
        
        Change-Id: Ia2339e3d7b0a8fdc31a7b4fb498eddee63772cf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184364
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [2071333e226d0ca3d5cdce36a6afbe3947c71f9b]

        tdf#130857 qt weld: Support Math's font dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog can be triggered in Math as follows:
        
        * "Format" -> "Fonts"
        * click the "Modify" menu buttton and select any entry
        
        This dialog makes use of weld::EntryTreeView for
        which a Qt implementation was added in previous commit
        
            Change-Id: Ide3063e27dd36e87539b9eaf7165dc073669323f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 18 23:00:09 2025 +0200
        
                tdf#130857 qt weld: Introduce QtInstanceEntryTreeView
        
        Change-Id: I88ac6a76b9f70872d965b435c02f35a5bdbbf2d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184363
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Michael Weghorn  <m.weghorn@posteo.de>  [e61a6f9598867db80de1d34837569d48afb7e522]

        tdf#130857 qt weld: Introduce QtInstanceEntryTreeView
        
        This is the weld::EntryTreeView implementation
        using native Qt widgets.
        
        A weld::EntryTreeView is a combobox-like widget,
        but consisting of two widgets: a weld::Entry and
        a weld::TreeView.
        
        In QtInstanceEntryTreeView, implement logic similar
        to the GTK (GtkInstanceEntryTreeView) and VCL
        (SalInstanceEntryTreeView) implementations:
        
        * Auto-completion based on the tree view entries
          when typing in the entry/edit
        * automatically selecting the corresponding tree
          view entry when the entry/edit text matches one
        * forward (page) up/down key events on the entry/edit
          to the tree view, so this can be used to navigate
          through the entries
        
        This worked as expected in a quick test of Math's font
        dialog that can be triggered as follows:
        
        * "Format" -> "Fonts"
        * click the "Modify" menu buttton and select any entry
        
        Support for that dialog will be declared in QtInstanceBuilder
        in a separate commit.
        
        Change-Id: Ide3063e27dd36e87539b9eaf7165dc073669323f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184362
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [115fc4a2d4ce19e3cd85f71fe5a50f9859a944f0]

        ofz#391962477 TextNode added to SwNodes::m_aOutlineNodes during its dtor
        
        Unusually in #5, the dtor of SwTextNode, after it has verified that it
        is not in an OutLine List, then during ResetAttr the node ends up back
        in the Outline List
        
         #0  SwNodes::UpdateOutlineNode (this=0x5d5230, rNd=...) at source/core/docnode/ndnum.cxx:133
         #1  0x00007fffdd45267b in SwTextNode::TriggerNodeUpdate (this=0x771e80, rHint=...) at source/core/txtnode/ndtxt.cxx:5700
         #2  0x00007fffdd452ce4 in SwTextNode::SwClientNotify (this=0x771e80, rModify=..., rHint=...) at source/core/txtnode/ndtxt.cxx:5778
         #3  0x00007fffdc659a79 in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at source/core/attr/calbck.cxx:305
         #4  0x00007fffdccfa5da in SwContentNode::ResetAttr (this=0x771e80, nWhich1=99, nWhich2=99) at source/core/docnode/node.cxx:1706
         #5  0x00007fffdd437583 in SwTextNode::ResetAttr (this=0x771e80, nWhich1=99, nWhich2=0) at source/core/txtnode/ndtxt.cxx:5477
         #6  0x00007fffdd4371e5 in SwTextNode::~SwTextNode (this=0x771e80) at source/core/txtnode/ndtxt.cxx:284
         #7  0x00007fffdd4376b9 in SwTextNode::~SwTextNode (this=0x771e80) at source/core/txtnode/ndtxt.cxx:253
         #8  0x00007fffdcd06b82 in SwNodes::RemoveNode (this=0x5d5230, nDelPos=..., nSz=..., bDel=true) at source/core/docnode/nodes.cxx:2426
         #9  0x00007fffdcd0b785 in SwNodes::DelNodes (this=0x5d5230, rStart=SwNodeIndex (node 85), nCnt=...)
             at source/core/docnode/nodes.cxx:1450
         #10 0x00007fffdca9e5f9 in sw::DocumentContentOperationsManager::DeleteSection (this=0x5eaf20, pNode=0x7518d0)
             at source/core/doc/DocumentContentOperationsManager.cxx:2146
         #11 0x00007fffdcb4bfe4 in sw::DocumentLayoutManager::DelLayoutFormat (this=0x5eb130, pFormat=0x44abe0)
             at source/core/doc/DocumentLayoutManager.cxx:288
         #12 0x00007fffdc8f6afb in DelFlyInRange (rMkNd=..., rPtNd=..., oMkContentIdx=std::optional [no contained value], oPtContentIdx=std::optional [no contained value])
             at source/core/doc/docedt.cxx:257
         #13 0x00007fffdc8f68d5 in DelFlyInRange (rMkNd=..., rPtNd=..., oMkContentIdx=std::optional [no contained value], oPtContentIdx=std::optional [no contained value])
             at source/core/doc/docedt.cxx:247
         #14 0x00007fffdca9e3db in sw::DocumentContentOperationsManager::DeleteSection (this=0x5eaf20, pNode=0x6e1b10)
             at source/core/doc/DocumentContentOperationsManager.cxx:2135
         #15 0x00007fffdda48c38 in SwHTMLParser::DeleteSection (this=0x6b7460, pSttNd=0x6e1b10) at source/filter/html/htmltab.cxx:4902
        
        note: Doesn't really matter if this test case loads or not.
        
        Change-Id: Idaf695698910aba2540594d36541a00a1cf61004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184361
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [d3ef13ac75b05b6dadc32a854696d27b3680259e]

        sw: Make CompareSwSelBoxes::operator() params const
        
        ... and drop some const_casts in Writer accessibility code
        that are no longer needed now.
        
        Change-Id: Ifd462ae4a7501d197b6a3678c75ecb967030454d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184360
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Noel Grandin  <noelgrandin@gmail.com>  [f91611df0c818116cf8d62569dd83ea9c02ea41c]

        tdf#163872 speed up IfJump operation
        
        shaves 10% off the load time here by moving the loop
        of the operation down into the matrix code where we
        can iterate direcltly over the data.
        
        Change-Id: I88f66d0ab3c7fc9e09ccffb96c0fd335daf62169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184343
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4f6ab57c8199142b537796c7c54a626fd7ffe111]

        crashtesting: null deref on layout of ooo46450-1.odt
        
        since:
        
        commit b595dff0bf2fcdb63586e36d007408cf23359a65 (HEAD)
        Date:   Fri Apr 11 16:50:43 2025 +0200
        
            tdf#166125 Revert "tdf#158532 sw: fix toolbar buttons remain disabled ...
        
        Change-Id: I21bf86ffec48e155d1a1f4b9e6ab40555b77a1dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3ac8f26446428308d99f68986b04c282f2aac27a]

        oox: pptx export - replace namespaces defines for functions
        
        Change-Id: I62f4f86643c6471be703dab6877000b9f9799272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184286
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [a54184778d17d93dcbbedc687901e9c2f2a226cd]

        sw a11y: Use range-based for
        
        Change-Id: I5c3e13e671f4f40bc04e3e401311d6c0443ca062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184340
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [7d76bb339905f011bafe99bda958b3e63a9cffc4]

        sw a11y: Drop SwShapeList_Impl typedef
        
        It is only used a single time, so just specify the full
        type there.
        Also move the comment to SwAccessibleMap::mvShapes
        where it belongs, since it describes the semantics
        of that class member, not the type in more general
        terms.
        
        Change-Id: I131acd3d144a81d536aa736d07ceed5c1fcf3cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184339
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [01cdb8a4bf1ae74322baaa94e715e620a8e83a3c]

        sw a11y: Use std::unordered map directly instead of wrapper
        
        No longer use the SwAccessibleContextMap_Impl class
        that is effectively just a wrapper around std::unordered_map,
        but use std::unordered_map directly instead, and use
        SwAccessibleContextMap as an alias/typedef.
        
        Change-Id: I14a873076746c81c4fe628810654995f5d8cb9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184332
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [37e04716bbe68c7d9707dd69dbc90c296cd63978]

        sw a11y: Reduce variable scope + move check into if body
        
        Change-Id: I10f0019eeedb396198078c380153323b54d5ab40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184331
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [43f5bf0439c05cd54925ac8fae683531d929d23d]

        sw a11y: Merge variable decl and assignment
        
        `bOldShapeSelected` can also be const now.
        
        Change-Id: Idd24c9ce22238e74b41b34c781920acafec0083f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184330
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [562b0b063b443bf3f6ae97d0a1fa3d07f1ed7ec8]

        sw a11y: Explicitly clear WeakReference
        
        ... instead of assigning an empty ref, and having
        an explaining comment that this is done to clear it.
        
        Change-Id: Ic4f7c5f64406ed77a66b05c0ec471a23ea3f68bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184329
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [86cef6d3d14098a472c470f901b887f3d361d2b3]

        sw a11y: Drop extra block scopes
        
        Before
        
            commit 59036776b92c0f4ad2edd1bafd332f7a4ee87cdc
            Date:   Wed Apr 26 15:15:01 2023 +0200
        
                tdf#136749 no need to use maMutex in SwAccessibleMap
        
        , these were relevant for the lifetime of an
        
            osl::MutexGuard aGuard( maMutex );
        
        , but that one was dropped in the above commit, so drop
        the extra scopes and indentation level as well.
        
        (`git show --ignore-space change` helps to see the
        "actual" changes more easily.)
        
        Change-Id: I28f9957cea59aeb1836a2a44543d2abc2f114401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184328
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [033a4e93643f83a733f1272d2928e64158388175]

        sw a11y: Use range-based for
        
        Change-Id: I6852239fac6b2f88f6b0dec411a4a7b6c105edee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184327
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [664c2a113db6a9920e08c55e4ea1025e295c4c26]

        sw a11y: Drop SwAccessibleContextMap_Impl::mbLocked
        
        It is only used in debug mode for asserts in
        SwAccessibleMap::GetDocumentView_, but I don't see
        how those should ever be false, as there's no
        indication for this method calling itself recursively
        in odd ways in between those lines where
        SwAccessibleContextMap_Impl::mbLocked is set to
        true and then back to false, so I personally find this
        more confusing than helpful.
        
        Change-Id: I7a16133018e5bc55ec9162a38653aea47c50c319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184326
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [3b6eeb46a59d3c7311ca0f57f3d8c91207bbfcdd]

        sw a11y: Drop unused typedefs
        
        Change-Id: I71fd3c2f48f753c7f1b3afa6c9ee50c7f04ee463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184325
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [0032418589fd04ed61f3c0653a7c563c3a0e0123]

        sw a11y: Drop assignment to intermediate local var
        
        Just assign to `xAcc` right away and drop `pAcc`.
        
        Change-Id: Iabe5169f971e756b573af294100232955ded135e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184324
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [f47e9f1d1692dc63010f454d3e002d20b024eb38]

        sw a11y: Use range-based for in SwAccessibleMap
        
        In SwAccessibleShapeMap_Impl, implement `const_iterator begin() const`
        and `const_iterator end() const` instead of the equivalent
        `const_iterator cbegin() const` and `const_iterator cend() const`,
        as the former are needed for range-based for loops.
        
        Drop the non-const `iterator end()` as it is not needed anymore.
        
        Convert loops to use range-based for, which removes the hassle
        to make sure the iterator is manually incremented in all control
        paths.
        
        Change-Id: Iefbd11a5e0ae94252771c4c0127d11b36abf8c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184310
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [58407933724f0c9da15b567ab3e293204e9d483d]

        sw a11y: Reduce variable scope
        
        Change-Id: I6460ad4619b1185f86f27267f21cc61d1ddddfc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184309
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [31e8f0c7baae4fcab112f0f4266d3ee4d9f27f9e]

        sw a11y: Move std::unique_ptr into block for auto-reset
        
        Instead of declaring the std::unique_ptr before the
        block it is used in and resetting it manually after
        the block, move the declaration inside, so it is
        automatically deleted as it goes out of scope at
        the end of the block, freeing the memory.
        
        Change-Id: I7a2179834aa243621f913e11ea2ec606302db5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184308
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [ccfebdceaba6f6393b9aeaef5e8cad45b83097dd]

        sw a11y: Merge two blocks using same if condition
        
        Change-Id: I2d86635a99f6b6e71cd22ec24e81069de1d18113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184307
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [1c9c895708a58e4d6cce9db8d19b590d1fec61d9]

        sw a11y: Drop commented line of code
        
        Commented out ever since it was added in
        
            commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba
            Author: Steve Yin <steve_y@apache.org>
            Date:   Fri Nov 29 13:03:27 2013 +0000
        
                Integrate branch of IAccessible2
        
        Change-Id: Id6653f045019f8d58574ab46eb2750001c7fa5f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184306
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-18  Michael Weghorn  <m.weghorn@posteo.de>  [5018d3a4c321f411ef27d4797ee6050bf634c9ef]

        sw a11y: Use range-based for in SwAccessibleTableData_Impl
        
        Change-Id: I20ca3ac85ac912a05571ffc5c7468313ae5a25f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184305
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Noel Grandin  <noelgrandin@gmail.com>  [2dca822b02f6ace5dd93ddeb2c5e2831b99ea648]

        flatten ScIfJump method (tdf#163872 related)
        
        Change-Id: I67cfacbc900434173662996da950bd0781ee7343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2752763389775cf826cd308655f3405b4925c81b]

        crashtesting: negative array index on load of tdf100936-4.odt
        
        since:
        
        commit 5a03d511f46ecc05aab35bb29e714b46f5638b1b
        CommitDate: Wed Apr 9 06:47:38 2025 +0200
        
            tdf#130592 i18npool: Fix incorrect line breaking in mixed CJK+Latin
        
        nBreakPos is -1 here, which itself looks dubious, but there is a later
        nBreakPos < nMinBreakPos already.
        
        Change-Id: Ie7f10bee19c359c877e454d20ab1a0efbf5b92c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184338
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fae15203e825647416b0a17dd46a1d5c1e3984fe]

        Emscripten: Provide Module.script
        
        ...which is useful for some downstream scripts
        
        Change-Id: Ibf9d336fb4ad018dcaa5ed460cac1e8e5030ab50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184334
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-04-17  Skyler Grey  <skyler.grey@collabora.com>  [60f966038204773d1242a6bb2e81394fbfa08f3e]

        feat(iOS): enable AVMedia
        
        Previously, AVMedia was disabled entirely for iOS. As we intend to
        support AVMedia in Collabora Office Mobile for iOS, this is rather
        inconvenient. In reality, we can support some of the AVMedia stuff -
        albeit using webkit to play videos rather than gstreamer.
        
        Change-Id: I1c5b791f7f37185c2b92ba5e6d41f934ac215411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184333
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ba393a6d7bd3026e219ce8ded27dfadd8c96317f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a7e577f2c99d8f3f6cf3e85973ff0c69cc10014
          - tdf#165987 fix wording about "Column type" in CSV import.
            
            Change-Id: Ib891322ed767404e14edbe2c3fdbdb1bf4a48a78
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184337
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-17  Miklos Vajna  <vmiklos@collabora.com>  [19b1d810cba575bbcbd61c6c685d03a012d31d95]

        tdf#166218 desktop lok: fix paintTile()
        
        This went wrong in commit bc2d1922e26bcf4e243150c3d439226743c6c2ba
        (cool#11254 desktop lok: avoid invalidations if no tiles are sent,
        2025-03-05), where I changed doc_paintPartTile(), but forgot to adapt
        paintTile() accordingly.
        
        Change-Id: I25fcbbc6681c6b6283ebe051037f3abbfdc34040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184322
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [36a4455b19c55c31d1c309ff951c3f89c198d621]

        Fix the build
        
        ...after abc8ea2da28b17a4a4784830fe74fd2743f8a131 "tdf#165742 Step 2: Create a
        ChartType derived class for chartex funnel chart." got merged after
        1aa34c45b6622942983c872d9d307d5768b68246 "fold DataSeriesHelper functions into
        DataSeries" and thus started to cause
        
        > /Volumes/lode/lode/jenkins/workspace/lo_tb_master_mac_dbg/chart2/source/model/template/FunnelChartTypeTemplate.cxx:151:23: error: no member named 'setPropertyAlsoToAllAttributedDataPoints' in namespace 'chart::DataSeriesHelper'
        >     DataSeriesHelper::setPropertyAlsoToAllAttributedDataPoints(xSeries, "BorderStyle",
        >     ~~~~~~~~~~~~~~~~~~^
        > /Volumes/lode/lode/jenkins/workspace/lo_tb_master_mac_dbg/chart2/source/model/template/FunnelChartTypeTemplate.cxx:161:27: error: no member named 'setPropertyAlsoToAllAttributedDataPoints' in namespace 'chart::DataSeriesHelper'
        >         DataSeriesHelper::setPropertyAlsoToAllAttributedDataPoints(xSeries, "Geometry3D",
        >         ~~~~~~~~~~~~~~~~~~^
        
        (<https://ci.libreoffice.org//job/lo_tb_master_mac_dbg/50335/>) etc.
        
        Change-Id: If9ebdc92b00511144ec9ed556aa80b1f49a0399e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184323
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [59f9bf8e8d50a7bc8b77dff2039708017517e116]

        Initialize the variable upon creation
        
        Change-Id: I75ff53bd2dce22a691b89abe91944041fe2f7a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184319
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [bf248da3aad67abd2ccd154b747314217111719c]

        vcl: use std::accumulate() for Animation::GetSizeBytes()
        
        Change-Id: Iaa27d472cc86dbc22b6fe06da0a1f0af1e8cf324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182048
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [6935f82ebe9e2544f4cb1047718f72bacbafdb42]

        fix BufferedDecompositionFlusher thread naming
        
        otherwise we end up renaming the main thread
        
        Change-Id: I59f8274e13273321d80ab264e1d31e66b70547c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184318
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7dc032dc3deb7c68b68e45dbcf5cb57c66489a58]

        add assert in SvpSalVirtualDevice::ReleaseGraphics
        
        so we don't ignore any mis-use of the API
        
        Change-Id: I8a1edf589d1a2893c4fa0ccb121dd15dd8329f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184316
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [39bd06ad1e404b37eb70b58ee76fc52184dd4b21]

        Hack to keep popup menus alive long enough for Emscripten Qt5
        
        This fixes <https://github.com/allotropia/zetajs/issues/12> "Is it possible to
        make context menu work?"
        
        Change-Id: Ib89b638dd94210bae13017554c30c3172e299102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184315
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-04-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92a8731e0bab5509ff51064e02ac4d5bdb4e9668]

        Ignore pastes that don't originate from a Slide Sorter
        
        so we only do the creation of new pages when pasting entire
        slides, and do the usual paste otherwise.
        
        if this doesn't work out then an alternative idea is to extend
        TransferableObjectDescriptor with some additional information.
        
        Change-Id: I3630ff46c118350e8988e0c8cbd03b83a5a4e1ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184279
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit f57727e8ea65edbc8e6c25730f2b6574d4fa9b6e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184314
        Tested-by: Jenkins

2025-04-17  Miklos Vajna  <vmiklos@collabora.com>  [7a1371b5883fa43a789aa685187c5fffcec64b7e]

        Related: tdf#165322 sw: add tooltip testcase for format+delete redline combo
        
        Fails with commit f439448d21ef2feb03a9920d95d30f23795db6ac (tdf#165322
        sw: prefer insert/delete redline in mouse-over tooltip, 2025-02-25)
        reverted.
        
        Change-Id: I4be681d5920c93d85e4c295133ceaa608bb8bb6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184317
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-17  knordback  <kurt.nordback@collabora.com>  [abc8ea2da28b17a4a4784830fe74fd2743f8a131]

        tdf#165742 Step 2: Create a ChartType derived class for chartex funnel chart.
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML and re-export.
        
        Create ChartType and ChartTypeTemplate derived classes for funnel chart.
        
        Change-Id: I6019412c59e0228bf37a893ced7617a4e3056add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183461
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [77bfb60031e38bd3aa5b7e910e3b625681aea98f]

        vcl: split off IdleFormatter to own source files
        
        Change-Id: I9f463ed77fbabd6158ce3eb2b045e12fdb0705c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179712
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Pranam Lashkari  <lpranam@collabora.com>  [7dddd449068d69ec2f47bfca2487f01fa7067fd0]

        sd: copy slides from instance to another
        
        in core this works between multiple instances (ie: multi users)
        in online now its will be possible to copy slides from one
        presentation to another
        
        in core to test with multiple instance:
        ./instdir/program/soffice -env:UserInstallation=file:///tmp/test1 &
        ./instdir/program/soffice -env:UserInstallation=file:///tmp/test2 &
        
        Co-authored-by: Pranam Lashkari <lpranam@collabora.com>
        Co-authored-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Change-Id: I95b4d332968fd8895b1d950ea620ea37a85524c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184232
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit cdaf9a06f5467f0f0167885a3e44ecc3cdd87b76)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184262
        Tested-by: Jenkins

2025-04-17  Oliver Specht  <oliver.specht@cib.de>  [53d9f2712f6e447240d67538f9890030e2e4e27f]

        Close copy field dialog directly if 'Copy' is pressed
        
        Change-Id: If4482c9c6c931fa6cf205ce999a56d9990930537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184142
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [6c8f4322ac2dad1d8ba4f4a8ad83edfcd00d0d63]

        sw: fix warning C6011: Dereferencing NULL pointer 'rSprm.getValue()'
        
        Change-Id: I4ebd78319b0d47b34ab311a2f57a921bc8369aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184302
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0764e84ca5158d87c3e0fc1301715481f28269ca]

        rearrange SvxCharacterMap class definition
        
        Clean it up a little and make most of it private, doesn't need to be public
        
        Change-Id: Ifc5d14faadcfedb4443a60694296b6b4a63c828d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184289
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [49392773762d0e8caa655a9d4d5a8ae81120c222]

        sw a11y: Use range-based for
        
        Change-Id: Ia8b233d1b7d818365bfc6c2fb9652c2f4b0dc1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184299
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [bba51aab027b097c9cefab523c59ff5c42674f4a]

        sw a11y: Return cell instead of using out param
        
        Instead of having a bool return value and an out
        param for the `const SwFrame*`, simply return the
        `const SwFrame*`.
        
        Change-Id: I6920e23b08b9d6fbe29acf5c71858e6ec0c45512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184298
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [c6be26a067161126d4b2d2ba4982be2518dd8430]

        sw a11y: Drop always false 'bExact' param
        
        ... for SwAccessibleTableData_Impl::FindCell.
        
        Change-Id: I10db77f11e56b03186a99131d09c08856d334403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184297
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [9b90703fa89c8351336e1c97ba6448ca15255bca]

        sw a11y: Drop pThis param to SwAccessibleTableData_Impl::GetCell etc.
        
        Don't pass `this` around as `pThis` param to
        SwAccessibleTableData_Impl::GetCell and
        SwAccessibleTableData_Impl::CheckRowAndCol only
        to be able to pass it in the
        lang::IndexOutOfBoundsException.
        
        Drop the param instead.
        
        (If passing `this` to the exception were very relevant,
        the methods could also be made non-const instead, but
        for now, I see no real reason for that.)
        
        Change-Id: I4057fbdd813af3f0492ff7f3e64cd46b40a03d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184296
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [e08b118858e7822803faa3b4e91df92296b08bcf]

        sw a11y: Deduplicate logic for XAccessibleComponent methods
        
        In SwAccessibleContext, call SwAccessibleContext::getBounds
        instead of directly calling SwAccessibleContext::getBoundsImpl
        for some of the XAccessibleComponent method implementations
        
        This allows to reuse them for the SwAccessibleDocumentBase
        subclass, too, so drop its overrides of those methods.
        
        Change-Id: Ie629fecff4203437c21248e4d09de93c23a96af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184276
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [2f6c7c7ba2031575177ec6ad56bc34dfeaae301d]

        sw a11y: Deduplicate SwAccessibleDocumentBase methods a bit
        
        Reuse SwAccessibleDocumentBase::getBounds logic in
        SwAccessibleDocumentBase::getLocation and
        SwAccessibleDocumentBase::getSize instead of reimplementing
        it. While SwAccessibleDocumentBase::getSize was previously
        using absolute coordinates, using relative ones is fine
        because the size is the same.
        
        Change-Id: Ic4b17b383c995e92cb35e47133b969c05c6d1369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184275
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [3fd9b68d466acf3146202dd8c81d3be53f17c285]

        sw a11y: Simplify SwAccessibleDocumentBase::containsPoint
        
        Reuse existing logic in SwAccessibleDocumentBase::getSize
        to retrieve the bounding rectangle and use its size
        instead of duplicating some code to calculate it.
        
        Change-Id: Ib5524489367fe4aa6da35c4aed09cd34ed3cf55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184274
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [f35d637458c77f6d152986b2f1f47ba24d66aa4b]

        sw: Pass SwViewShell by ref to some helper functions
        
        It's non-null for all callers and unconditionally
        dereferenced in the function implementations.
        
        Change-Id: I6f82edc7ed05f069c0c05486a8175117e8c40794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184273
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea4921a3e31cf87c60e2eceeec46cccdc6a79b23]

        sw: fix warning C6011: Dereferencing NULL pointer 'r_Sprm.getValue()'
        
        Change-Id: Ia6df8bbeb966366f8a1e4465150e684e345ee0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184300
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-17  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ce15f14eb722c5a17fc8fec2a4356c1561f8da7f]

        Remove obsolete fw declarations from editeng/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ic021d9a47f9974d20ef011b34f4897847dd2628a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183884
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-17  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [924ab1962e95cef3c0c36c49606e037c0c1fd110]

        Remove obsolete fw declarations from embeddedobj/ extensions/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I029145e0f04b1ed90bb0d16c871891bca85b39a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183885
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-17  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [227939ee4c16967584ea1162d8115cbb714e3dd5]

        Remove obsolete fw declarations from desktop/ drawinglayer/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I61ee34a26ed75c0bbbf4dae0359bfeeea37b4296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183883
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c317caddbd324ac683873566a7b55405661c39d]

        sw: use SAL_RET_MAYBENULL in getValue()
        
        Change-Id: If2b94443c6efdc277cf22e322171b06e19956110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184294
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2922ba5dfec17cdeebd2ace8948cc88fdc1bcd1a]

        this silent_error_func is unused
        
        Change-Id: Ic6ef091b209fe7cb05a828cf08b67761be2701f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184291
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-04-16  Jonathan Clark  <jonathan@libreoffice.org>  [3c9fdd9aeb74d76ef7f1c0581582439c8a135532]

        tdf#163618 editeng: Fix excessive overlap in justified Arabic script
        
        Fixes a bug causing editeng to insert kashida glyphs in positions where
        there is not enough space for them. The root cause was failing to
        account for the extra space used by blanks while rejecting candidate
        kashida positions.
        
        Change-Id: I1e22f758af0a88c2070f31cca040570f3a730c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184282
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-04-16  Mike Kaganski  <mike.kaganski@collabora.com>  [6ba56baf421156715ac3d305dd2548f28e4b414c]

        Avoid calls to ImplGetDay, ImplGetMonth and ImplGetYear
        
        ... where these calls aren't needed (the return value is not used),
        or where the value is already obtained.
        
        Change-Id: Ibd57f9f113e7fe16214be0cbb4daf0c3ec58663c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184280
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-16  Emmanuel Dreyfus  <manu@netbsd.org>  [9fb26786b75e30df593378954044af4e4753a192]

        tdf#165837 Avoid UNO failure if filesystem does not implement fallocate.
        
        posix_fallocate() may be available but unimplemented for a
        given filesystem. Detect that situation once and use ftruncate()
        instead.
        
        Change-Id: Ic1422bfbcbcda21ef4923a6fc30ceb5ce662db3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183977
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-04-16  Noel Grandin  <noelgrandin@gmail.com>  [ac3b217a43e21b00f434fa796a0c966b9ddfd9df]

        Make UINames and Programmatic Names typesafe
        
        by wrapping up OUStrings inside some type-safe wrappers
        to make it obvious in the code what kind of name we
        are dealing with.
        
        The new classes are in sw/inc/names.hxx
        
        Note that I spun the names for table formats out into
        their own name class TableStyleName, becuase they
        are weird. Most of the time they are UINames, but
        not always.
        
        Change-Id: Iaf320639fd1aae8ba0f99866ff206906544c42be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-16  Justin Luth  <justin.luth@collabora.com>  [a48bc1a44010e12da4ed8c3f66a4e255ef8f2513]

        tdf#166201 docx import: ST_Coordinates as UniversalMeasure
        
        Thankfully the plumbing is already there,
        although it is a bit surprising that I'm the first one
        to need a Universal Measure for EMUs.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf166201_simplePosCM
        
        Change-Id: Ic2198be297e1ba8686b03ecc8b212cb9d887f5eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184248
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-04-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [07250941eae8846f3eda68f897882010cf3cd285]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 850803baad3bd33d82a1fe1db13c09ffbc994f57
          - tdf#162607 disambiguate hid2file.js spotlight
            
            Change-Id: Ic854d6d0d37ef26d625af2714d593bbc1174eaa0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184245
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ce8f746ec524967ada2b39f2e2ac999f069f97bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e20b30849bd3149067a8680cfb80d71008ff892
          - tdf#163745 BASIC help pages must explicitly state types of all arguments
            
            + refactor and tweaks
            
            Change-Id: I39a88a35af32aac68e8ebfe566bce0fc927ceef3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184186
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-16  Weblate  <noreply@documentfoundation.org>  [fe1b1f8fb95c995a78ec68d9b9ddac10921de348]

        android-viewer translated using Weblate
        
        Belarusian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I240e6494c5688cc507cb1d1d3e1fa06390882e7c
        
        Added translation for android-viewer using Weblate (Belarusian)
        
        Change-Id: Ib3482201d32de50e85f2a4c62595ee5e6f86df7b
        Co-authored-by: Valery Levanchuk <levanchuk@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/be/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184130
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [41a9f54e5982f2e8a7ef53ed9be0b79e15ee9ebc]

        try to make the Windows build happy
        
        sw\source\filter\ww8\ww8atr.cxx(350) : warning C4701: potentially uninitialized local variable 'pLRItem' used
        sw\source\filter\ww8\ww8atr.cxx(350) : warning C4703: potentially uninitialized local pointer variable 'pLRItem' used
        
        Change-Id: Iab0c8219ae8bb27706e8a0286716b586fc933330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [eedda19d84dde8f284b4e296bda5208503bf2a7c]

        crashtesting: check getValue()
        
        According to sw/source/writerfilter/inc/dmapper/resourcemodel.hxx:384
        Returns value of the SPRM. Returns nullptr if the internal value is nullptr.
        
        Seen in https://shorturl.at/KVBYr
        
        Change-Id: Icfe015c8f39a3dc26ee1cd38c61c1956d562ee68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184263
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [736998ccef0bacdd2bbf038c98dacfbe654f1a4d]

        Only run meson from python when it apparently needs to be
        
        ...where "apparently needs to be" is approximated by the meson executable being
        named *.py (which, in turn is approximated by some GNU Make $(filter) check).
        This follows up on ae24fc8c639b230284f94e837497cd7919f79d21 "harfbuzz: migrate
        to meson" and should avoid e.g. issues with --enable-python=fully-internal on
        Linux like
        
        > Traceback (most recent call last):
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 563, in from_name
        >     return next(cls.discover(name=name))
        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        > StopIteration
        >
        > During handling of the above exception, another exception occurred:
        >
        > Traceback (most recent call last):
        >   File "/usr/bin/meson", line 33, in <module>
        >     sys.exit(load_entry_point('meson==1.7.0', 'console_scripts', 'meson')())
        >              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/usr/bin/meson", line 22, in importlib_load_entry_point
        >     for entry_point in distribution(dist_name).entry_points
        >                        ^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 982, in distribution
        >     return Distribution.from_name(distribution_name)
        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/home/sberg/lo/core/instdir/program/python-core-3.11.12/lib/importlib/metadata/__init__.py", line 565, in from_name
        >     raise PackageNotFoundError(name)
        > importlib.metadata.PackageNotFoundError: No package metadata was found for meson
        > make[1]: *** [/home/sberg/lo/core/external/harfbuzz/ExternalProject_harfbuzz.mk:47: /home/sberg/lo/core/workdir/ExternalProject/harfbuzz/build] Error 1
        
        (<https://gerrit.libreoffice.org/c/core/+/183345/22#message-66c17b20610944c79d6d7206a62869ad430c3a60>
        "harfbuzz: migrate to meson")
        
        Change-Id: I44da7aebdc35a4be838046f0b065f1b646487156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184254
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-16  Miklos Vajna  <vmiklos@collabora.com>  [59d91a6e65bdff3e606dcb794ed165f95f36f775]

        sw doc model xml dump: show more redline types
        
        RedlineType::ParagraphFormat was the actual type I didn't see, as it was
        reported as "UNKNOWN".
        
        Keep existing values unchanged, although the C++ code was changed in
        commit 28bff4bd3947f442c0aebb92217cd0c7b6a53bda (convert nsRedlineType_t
        to scoped enum, 2019-05-23), and SwRedlineData::dumpAsXml() wasn't
        adapted accordingly.
        
        Change-Id: Iefe4824789cace1bd906f11862e147c53a3aac8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184256
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-16  Karthik  <me@karthikreddy.org>  [492c94abe05e5ac213475cdd85f158b7a462f824]

        tdf#139633 Rename objects from tree view in navigator
        
        Add functionality to enable inline editing of tree node objects
        in the navigator panel to rename objects.
        
        Change-Id: If9933ab03f19d0e5482a46b1a98b31c075602d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183095
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-04-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [27731badb6c91b1767114f7a4f36dd42c1316cd8]

        CppunitTest_sw_ooxmlexport9: split in two
        
        it already has 99 tests
        
        Change-Id: I285ab56f70f3170e9ea547a8cae2d3754a1846ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184242
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e9b9eacad16f893c676f9dc92974bda3a12540d]

        CppunitTest_sw_ooxmlexport14: split in two
        
        It already has 101 tests
        
        Change-Id: Icc874cad81c18b8ced2827a01ded9a5cdf6b29f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184241
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-16  Justin Luth  <justin.luth@collabora.com>  [356f916d0e7dbab7f871c3feb19c6e1292c2a2f5]

        tdf#166201 docx import: simplePos is defined in EMUs, not TWIPs
        
        The normal values of simplePos are usually larger than
        ConversionHelper::convertTwipToMm100_Limited allows,
        so it typically returned 0,
        so usually the anchor was positioned at the top left of the page.
        
        There were no existing unit tests with non-zero simplePos.
        
        Although LN_CT_Point2D_x sounds very generic,
        commit history suggests that it has only been used for simplePos.
           (handle wp:simplePos properly)
        I also checked model.xml, and didn't notice anything else
        actually being imported that could share it.
        Based on the documentation, they all would also be defined
        in EMUs or "Universal Measurement".
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf166201_simplePos
        
        Change-Id: I65f49408262c8f68107fa1614f70ff2f8365e5c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184244
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [984cc982393b0dc198b0aeda84241920623ec0f3]

        vcl: Drop weld::EntryTreeView::EntryModifyHdl decl
        
        It is only declared, but not implemeneted or used
        anywhere.
        
        Change-Id: I107ea83844843c0f7b857a8cffd7fa84c3fd85fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184234
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [f7922602e0a7445ff0f45bcfe2c6454e4074bbe9]

        sw a11y: Return ref in SwAccessibleContext::GetShell
        
        Return a ref instad of a pointer in
        SwAccessibleContext::GetShell and also
        switch the SwViewShell param for LoadURL
        to a reference.
        
        This also allows to drop the
        
            // The shell could be 0 also!!!!!
        
        comment in that method.
        
        Change-Id: I9a817fb33f79a10f1baccb8c6264dafd9677731a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184231
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [3477b770d4add125be81b64c0f7051b655fe6016]

        sw a11y: Use ref for SwAccessibleMap's SwViewShell
        
        After
        
            Change-Id: Iccb2549bfaef37d14f3f7a4b9c691c583b189bb3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 15 15:31:55 2025 +0200
        
                sw: Let SwViewShellImp hold/return ref instead of pointer to its SwViewShell
        
        , it is clear that the SwViewShell passed in the SwAccessibleMap
        ctor is always non-null.
        Switch to a reference for the corresponding class member
        and getter as well.
        
        This makes clear that it's always non-null and allows
        to drop a few null checks/assert/`OSL_ENSURE`s.
        
        Change-Id: Id4219064bdde476a331e343c8d6dea4a5af5b23d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184230
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [3f1f4a0880d367410d6f0508c8737c51a0741263]

        sw: Let SwViewShellImp hold/return ref instead of pointer to its SwViewShell
        
        Switch SwViewShellImp::m_pShell from a pointer to a reference
        (and rename it) and return that reference instead of a pointer
        in SvViewShellImp::GetShell.
        
        This makes more obvious that it's always non-null.
        
        Change-Id: Iccb2549bfaef37d14f3f7a4b9c691c583b189bb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184227
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [185c553ba1ff4fd1a714b2eff2b1cd97954d8d9c]

        sw: Drop detour to get 'this' in SwFEShell::GetAnyCurRect
        
        The SwViewShellImp's shell is the SwFEShell/SwViewShell itself again,
        so just call SwViewShell::GetOut right away.
        
        Change-Id: I894b8d3f4463068a195b64113f84936cc16687db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184226
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [17eea13b2986644a8e59b55aeb2a3c49c4201d4a]

        sw a11y: Use vcl::unohelper::ConvertToAWTRect
        
        Change-Id: I7bbb95c5c24843d92c4750a3a444801cd3f8737e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184225
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  László Németh  <nemeth@numbertext.org>  [7d6696757dcdfa3cee481ac7795a91b2b47da363]

        tdf#159923 sw cui offapi xmloff: add custom word spacing
        
        Add com::sun::star::text::ParaWordSpacing UNO
        and loext:word-spacing ODF extensions to set
        desired word spacing of a justified paragraph
        relative to the width of the space character,
        like DTP software do.
        
        Add Justification section and "Word spacing"
        spin box to the Text Align pane of paragraph settings.
        
        This extends not only the smart justify interoperability
        feature for custom shrinking (until 0%), but for custom
        expansion, too, until 1000%, like Adobe InDesign do.
        
        Note: this value hasn't been applied in the last
        paragraph line, yet.
        
        See also XSL-FO/CSS word-spacing and
        commit 7d08767b890e723cd502b1c61d250924f695eb98
        "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt."
        
        Change-Id: I06f771335135e4682a1d1abfc9a247dbe4bc6b66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184187
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4bfed12f004e8f9b49a7532ed26b1075b4de462]

        replace TabName -> TableName in sw
        
        Change-Id: Ic3e3c8cc8921405cc79abc6e02678426e49e7d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-15  Eike Rathke  <erack@redhat.com>  [8cbe2653fee7322293968a4a2377fab7793bc785]

        Resolves: tdf#166187 {az-AZ} currency symbol is ₼ U+20BC MANAT SIGN
        
        ... and displayed before amount.
        
        Change-Id: Id5cd32f3e054721e44b404406e57aade302b665c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184213
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-04-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d107b16848b8e79b6df74321f22f3fb94ffff3a1]

        autodetect pkgconf-2.4.3.exe on windows/not everyone uses distro-config
        
        without using the distro-config that sets PKG_CONFIG, configure won't
        pick the windows version of pkgconf and the harfbuzz build then fails
        beause the graphite and icu .pc files cannot be found.
        
        Add an autodetection similar to the one for MESON as a convenience for
        building on windows. With that it is enough to have it in PATH or
        installed into $LODE_HOME/opt/bin
        Can always be overridden by explicitly adding PKG_CONFIG=/path/to/file
        into autogen.input
        
        Change-Id: Ia8ea0dffd34e7a97fb28c99ac3f6b561c5dab193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184221
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6fda947ee307d3166bb08da59d794459705a3f11]

        fix macOS tinderbox builds (pkgconf)
        
        macOS has the custom m4 macros bypassing pkgconfig, so it needs to be
        set explicitly.
        
        Change-Id: Id44a8934d2bb000eaa582a9c31fafa49f328cfda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184228
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-15  Miklos Vajna  <vmiklos@collabora.com>  [5dde0947cd1eafde690bd032805be732f5ee6f02]

        tdf#166179 sw: fix inconsistent UI state vs command exec for the para marker
        
        Go to the paragraph marker of the 2nd paragraph in the bugdoc, which is
        red & strike-through. The toolbar suggests that strike-through is on,
        but if you click on it, nothing happens.
        
        The reason for this is that the DOCX bugdoc has these character
        properties on the "paragraph marker", which can have its own formatting
        in Word, but not really in Writer. Writer's native way to do something
        similar is to just host character properties on the paragraph, which is
        not possible in Word. This is not a new problem, commit
        5ba30f588d6e41a13d68b1461345fca7a7ca61ac (tdf#64222 sw: better DOCX
        import/export of paragraph marker formatting, 2019-09-17) added the
        RES_PARATR_LIST_AUTOFMT paragraph property to store the formatting of
        the paragraph marker and commit 6287845eab339a8eb3c660d648d012e9f1dcce30
        (tdf#127606 DOCX lists: fix unchangeable formatting, 2020-04-17) already
        ran into this "can't get rid of formatting" problem, where the fix was
        to clear the RES_PARATR_LIST_AUTOFMT paragraph property.
        
        Improves this a little, so:
        1) If you go to the end of the paragraph and the UI hints that you have
           the relevant formatting enabled, then adjust command dispatch, so
           e.g. the "strike-through is enabled" -> press the toggle button ->
           "strike-through is not disabled" use-case works; and
        2) Given that this paragraph marker formatting is currently duplicated
           in the doc model (stored in both RES_PARATR_LIST_AUTOFMT and also as
           an empty hint at the paragraph end), make sure that applying character
           formatting at paragraph end for these paragraphs doesn't result in an
           inconsistent model (we used to only update the hint, but not
           RES_PARATR_LIST_AUTOFMT).
           Do this a bit similar to how
           SwUnoCursorHelper::SetCursorPropertyValue() handles
           RES_PARATR_LIST_AUTOFMT during the DOCX import.
        
        Note that lcl_InsAttr() is used with an item set, so applying a single
        formatting via a toolbar button or using the char format dialog works.
        Even undo/redo works, because SwRegHistory is still on the stack by the
        time we call SwTextNode::SetAttr(), so the undo action will be an
        SwUndoAttr, which has a SwHistorySetFormat, with both a SwHistoryHint
        and an SwFormatAutoFormat set. This is now easier to see, when the
        SwUndoAttr's SwHistory xml dump is part of the doc model xml dump.
        
        Change-Id: Iaa50d1d2b3c6599c4fd617dfd85c9e93e070e972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184219
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-15  Attila Szűcs  <attila.szucs@collabora.com>  [449d7bad692a6cab1fa925abe2434b72120d1160]

        svx: new dispatch for 2 uno commands
        
        Replaced TextUnderlineControl Underline, and
        TextCharacterSpacingControl CharKerning uno command dispatch.
        If a chart was selected, these commands was not sent to them,
        but now they are sent to the chart, so we can implement a way
        to parse them there.
        
        Change-Id: I5258c952457c7173cda2e893ffab8a0f81d94f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [589109ec567a007883f3ec304ab29c1ab7de4761]

        graphicselection json with mangled ordinal number of literal "-"
        
        these odd things happen when indirectly assigning an O[U]StringBuffer to
        itself. Noticed this when trying to insert a video into a presentation.
        
        Change-Id: I4d7178a9fca56bb53a73b8a0e1657483a34ca120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184218
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-15  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [57f793fd94e9692593b4f8e147c9295751116973]

        tdf#159712 sc: sparklines are not displayed correctly in merged cells
        
        The sparklines are always rendered in the top-left corner and do not
        take the space of the whole merged cell.
        
        Change-Id: I735c180d135de79907dd685045d277cc357815fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184152
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2025-04-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0841f2581c6e9b9301f7e8a4b75f38e19a5fc7f5]

        remove one level of indirection for bison and flex targets
        
        Change-Id: I38c962f86285c04b52d0026274f9739cd144b111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183745
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ada0279f73947984584b77d99ba1e0718d38988]

        fix crash in JunitTest_chart2_unoapi
        
        fix crash seen on jenkins, likely as a result of
        
            commit eeb8ca44ac7994c0552749e190a193a44c956769
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Apr 4 10:02:06 2025 +0200
            tdf#147874 slow sheet switching with large chart2 (2)
        
        Change-Id: Ic3c58080cfd9a8dd36fe980ef36ac38e3890b069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184207
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [a419343d759ff2f3dda850de6f12c251a8d102af]

        Avoid some casting in ScChildrenShapes
        
        Change-Id: Ic57ffd1d932f9613716b63902d5565f1f8f6ef0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-15  Alain Romedenne  <alain.romedenne@libreoffice.org>  [2afeebfff57f89fe90c5f63b1c751c2585a9d8a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d98542a85b40226fd2de5113ace424f8adee7618
          - more omissions in Python help
            
            - incl. code change
            
            Change-Id: Ifef19fdc11352355dead1fab7b4c6f21aaec8608
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184214
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [07de0b7c91b66abc6dc47d71237e355a0bba80fb]

        pyuno: Initialize tp_versions_used for Python >= 3.13
        
        This was added in cpython commit [1]
        
            commit 992446dd5bd3fff92ea0f8064fb19eebfe105cef
            Author: Mark Shannon <mark@hotpy.org>
            Date:   Mon Feb 5 16:20:54 2024 +0000
        
                GH-113462: Limit the number of versions that a single class can use. (GH-114900)
        
        , causing an `--enable-werror` build on Debian testing using
        system python3-dev 3.13.2-2 to fail like this:
        
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno_iterator.cxx:185:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
              185 | };
                  | ^
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno_iterator.cxx:334:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
              334 | };
                  | ^
            2 errors generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:336: /home/michi/development/git/libreoffice/workdir/CxxObject/pyuno/source/module/pyuno_iterator.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno_callable.cxx:252:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
              252 | };
                  | ^
            1 error generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:336: /home/michi/development/git/libreoffice/workdir/CxxObject/pyuno/source/module/pyuno_callable.o] Error 1
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno_struct.cxx:377:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
              377 | };
                  | ^
            1 error generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:336: /home/michi/development/git/libreoffice/workdir/CxxObject/pyuno/source/module/pyuno_struct.o] Error 1
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno.cxx:1693:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
             1693 | };
                  | ^
            1 error generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:336: /home/michi/development/git/libreoffice/workdir/CxxObject/pyuno/source/module/pyuno.o] Error 1
            /home/michi/development/git/libreoffice/pyuno/source/module/pyuno_runtime.cxx:147:1: error: missing field 'tp_versions_used' initializer [-Werror,-Wmissing-field-initializers]
              147 | };
                  | ^
            1 error generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:336: /home/michi/development/git/libreoffice/workdir/CxxObject/pyuno/source/module/pyuno_runtime.o] Error 1
            make: *** [Makefile:128: pyuno] Error 2
        
        Initialize the member to 0, as e.g. commit [2] does for swig.
        
        For cpython versions this is contained in (from within cpython git repo):
        
            $ git tag --contains 992446dd5bd3fff92ea0f8064fb19eebfe105cef
            v3.13.0
            v3.13.0a4
            v3.13.0a5
            v3.13.0a6
            v3.13.0b1
            v3.13.0b2
            v3.13.0b3
            v3.13.0b4
            v3.13.0rc1
            v3.13.0rc2
            v3.13.0rc3
            v3.13.1
            v3.13.2
            v3.13.3
            v3.14.0a1
            v3.14.0a2
            v3.14.0a3
            v3.14.0a4
            v3.14.0a5
            v3.14.0a6
            v3.14.0a7
        
        [1] https://github.com/python/cpython/commit/992446dd5bd3fff92ea0f8064fb19eebfe105cef
        [2] https://github.com/swig/swig/commit/c3e30c5734a8d9a052b233d2d01e58d409b41df0
        
        Change-Id: I1ad4c511880cf00e4c45b9e835edcd245fe2853c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184198
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2b15d4e7c0c1b8b5e16cb97afa244c628277e208]

        fix windows tinderbox builds (not finding pkgconf)
        
        updating those was forgotten in ae24fc8c639b230284f94e837497cd7919f79d21
        (migrate harfbuzz to meson)
        
        Change-Id: Ib6bb3b667b4b33c03774276d05416a9eec7d4077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184200
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [eccf4cd57a1970b296e12296bf0f5a0f52e917a7]

        tdf#166107: remove unnecessary resetPrintArea()
        
        In the mentioned regression, resetPrintArea() was responsible for reverting the print area in Calc, which was set by the Print Dialog,
        back to the one defined by the Page Styles.
        It was implemented in the print-related part that is used by all modules but this is a Calc-specific issue.
        Therefore, in this commit, resetPrintArea() was removed and it made
        more sense to fix the print area issue in the Calc modul.
        
        from
        commit 364f0bb1cac0e12f5f926857f61c2f329a353ec7
        Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        Date:   Wed Feb 28 11:13:10 2024 +0100
        
            tdf#155218 sc: fix regression page orientation in print dialog
        
        Change-Id: I3767c0685addefb9b2fb16bfc7cf967a0f332272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183948
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-15  Noel Grandin  <noelgrandin@gmail.com>  [ac0a285f1fd0c411abffa73458969a4dfe8dbbd8]

        Make reference marker names typesafe
        
        by creating a wrapper class, to make it obvious in the code what kind of
        name we are dealing with.
        
        The new class is in sw/inc/names.hxx
        
        Change-Id: I889c3a56c1cbc451a9a88c4e4340fe4b3183cc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184192
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [789c27c52f90997f38e49cb1377eb2caaad3a95e]

        attempt to fix JunitTest_toolkit_unoapi_4  crash
        
        seen on jenkins, where it looks like things are destructing that need to be destructed while the solar mutex is held.
        
        Thread 1 (Thread 0x7f41c94fc700 (LWP 2563514)):
          ^#0  0x00007f41e7b771cb in SfxItemPool::IsInRange(unsigned short) const (this=0x9999999999999999, nWhich=1077) at include/svl/itempool.hxx:332
          ^#1  0x00007f41e7b6cd84 in SfxItemPool::getTargetPool(unsigned short) const (this=0x9999999999999999, nWhich=1077) at svl/source/items/itempool.cxx:452
          ^#2  0x00007f41e7b6cdd7 in SfxItemPool::getTargetPool(unsigned short) const (this=0x53e0740, nWhich=1077) at svl/source/items/itempool.cxx:455
          ^#3  0x00007f41e7b6ce27 in SfxItemPool::CheckItemInfoFlag(unsigned short, unsigned short) const (this=0x53e0740, nWhich=1077, nMask=1) at svl/source/items/itempool.cxx:461
                pTarget = 0x7f41c94f7eb0
          ^#4  0x00007f41e7bd18a5 in SfxItemPool::NeedsSurrogateSupport(unsigned short) const (this=0x53e0740, nWhich=1077) at include/svl/itempool.hxx:344
          ^#5  0x00007f41e7bc407a in SfxItemSet::checkRemovePoolRegistration(SfxPoolItem const*) (this=0x6253bf0, pItem=0x6253dd0) at svl/source/items/itemset.cxx:382
          ^#6  0x00007f41e7bc3fc7 in SfxItemSet::ClearSingleItem_PrepareRemove(SfxPoolItem const*) (this=0x6253bf0, pItem=0x6253dd0) at svl/source/items/itemset.cxx:362
          ^#7  0x00007f41e7bc3bc0 in SfxItemSet::ClearAllItemsImpl() (this=0x6253bf0) at svl/source/items/itemset.cxx:441
                rCandidate = {first = 1077, second = 0x6253dd0}
                __range1 = std::__debug::unordered_map with 3 elements = {[1077] = 0x6253dd0, [4037] = 0x60b2e30, [1082] = 0x6253d70}
                __begin1 = {<std::__detail::_Node_iterator_base<std::pair<unsigned short const, SfxPoolItem const*>, false>> = {_M_cur = 0x6253e00}, <No data fields>}
                __end1 = {<std::__detail::_Node_iterator_base<std::pair<unsigned short const, SfxPoolItem const*>, false>> = {_M_cur = 0x0}, <No data fields>}
                nRetval = 0
          ^#8  0x00007f41e7bc389b in SfxItemSet::~SfxItemSet() (this=0x6253bf0) at svl/source/items/itemset.cxx:316
          ^#9  0x00007f41e5ff6ccc in std::_Optional_payload_base<SfxItemSet>::_M_destroy() (this=0x6253bf0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/optional:287
          ^#10 0x00007f41e5ff6caa in std::_Optional_payload_base<SfxItemSet>::_M_reset() (this=0x6253bf0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/optional:318
          ^#11 0x00007f41e5ff6db9 in std::_Optional_payload<SfxItemSet, false, false, false>::~_Optional_payload() (this=0x6253bf0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/optional:439
          ^#12 0x00007f41e5ff6d95 in std::_Optional_base<SfxItemSet, false, false>::~_Optional_base() (this=0x6253bf0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/optional:510
          ^#13 0x00007f41e5ff4025 in std::optional<SfxItemSet>::~optional() (this=0x6253bf0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/optional:705
          ^#14 0x00007f41e62467eb in sdr::properties::DefaultProperties::~DefaultProperties() (this=0x6253be0) at svx/source/sdr/properties/defaultproperties.cxx:92
          ^#15 0x00007f41e625061d in sdr::properties::AttributeProperties::~AttributeProperties() (this=0x6253be0) at svx/source/sdr/properties/attributeproperties.cxx:219
          ^#16 0x00007f41e624a225 in sdr::properties::TextProperties::~TextProperties() (this=0x6253be0) at svx/source/sdr/properties/textproperties.cxx:78
          ^#17 0x00007f41e6241525 in sdr::properties::RectangleProperties::~RectangleProperties() (this=0x6253be0) at svx/source/sdr/properties/rectangleproperties.cxx:38
          ^#18 0x00007f41e6241569 in sdr::properties::RectangleProperties::~RectangleProperties() (this=0x6253be0) at svx/source/sdr/properties/rectangleproperties.cxx:37
          ^#19 0x00007f41e6429a1c in std::default_delete<sdr::properties::BaseProperties>::operator()(sdr::properties::BaseProperties*) const (this=0x6217e58, __ptr=0x6253be0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:95
          ^#20 0x00007f41e642995c in std::__uniq_ptr_impl<sdr::properties::BaseProperties, std::default_delete<sdr::properties::BaseProperties> >::reset(sdr::properties::BaseProperties*) (this=0x6217e58, __p=0x0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:203
                __old_p = 0x6253be0
          ^#21 0x00007f41e642612a in std::unique_ptr<sdr::properties::BaseProperties, std::default_delete<sdr::properties::BaseProperties> >::reset(sdr::properties::BaseProperties*) (this=0x6217e58, __p=0x0) at /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:501
          ^#22 0x00007f41e6414094 in SdrObject::~SdrObject() (this=0x6217d00) at svx/source/svdraw/svdobj.cxx:461
                aList = std::__debug::vector of length 0, capacity 1
          ^#23 0x00007f41e64121d5 in SdrAttrObj::~SdrAttrObj() (this=0x6217d00) at svx/source/svdraw/svdoattr.cxx:42
          ^#24 0x00007f41e64bb91b in SdrTextObj::~SdrTextObj() (this=0x6217d00) at svx/source/svdraw/svdotext.cxx:203
          ^#25 0x00007f41e64b6c2f in SdrRectObj::~SdrRectObj() (this=0x6217d00) at svx/source/svdraw/svdorect.cxx:99
          ^#26 0x00007f41e6511024 in SdrUnoObj::~SdrUnoObj() (this=0x6217d00) at svx/source/svdraw/svdouno    m_xShapeAgg.clear();
        .cxx:223
          ^#27 0x00007f41e5f56988 in FmFormObj::~FmFormObj() (this=0x6217d00) at svx/source/form/fmobj.cxx:119
          ^#28 0x00007f41e5f569d9 in FmFormObj::~FmFormObj() (this=0x6217d00) at svx/source/form/fmobj.cxx:112
          ^#29 0x00007f41e64145c6 in SdrObject::release() (this=0x6217d00) at svx/source/svdraw/svdobj.cxx:484
                x = 0
          ^#30 0x00007f41e62baf29 in rtl::Reference<SdrObject>::clear() (this=0x60e3e78) at include/rtl/ref.hxx:193
                pOld = 0x6217d00
          ^#31 0x00007f41e683ba73 in SvxShape::~SvxShape() (this=0x60e3ca8) at svx/source/unodraw/unoshape.cxx:197
                aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x1502140}, <No data fields>}
          ^#32 0x00007f41e685637a in SvxShapeText::~SvxShapeText() (this=0x60e3ca8) at svx/source/unodraw/unoshape.cxx:3852
          ^#33 0x00007f41e681ac5d in SvxShapeControl::~SvxShapeControl() (this=0x60e3ca0) at svx/source/unodraw/unoshap2.cxx:479
          ^#34 0x00007f41e681ace9 in SvxShapeControl::~SvxShapeControl() (this=0x60e3ca0) at svx/source/unodraw/unoshap2.cxx:478
          ^#35 0x00007f41ea9f7110 in cppu::OWeakObject::release() (this=0x60e3ca8) at cppuhelper/source/weak.cxx:230
          ^#36 0x00007f41ea9f7835 in cppu::OWeakAggObject::release() (this=0x60e3ca8) at cppuhelper/source/weak.cxx:292
                x = empty uno::Reference
          ^#37 0x00007f41e6731dd5 in cppu::WeakAggImplHelper12<com::sun::star::drawing::XShape, com::sun::star::lang::XComponent, com::sun::star::beans::XPropertySet, com::sun::star::beans::XMultiPropertySet, com::sun::star::beans::XPropertyState, com::sun::star::lang::XUnoTunnel, com::sun::star::container::XNamed, com::sun::star::drawing::XGluePointsSupplier, com::sun::star::container::XChild, com::sun::star::lang::XServiceInfo, com::sun::star::document::XActionLockable, com::sun::star::beans::XMultiPropertyStates>::release() (this=0x60e3ca8) at include/cppuhelper/implbase12.hxx:166
          ^#38 0x00007f41e6827885 in SvxShapeText::release() (this=0x60e3ca8) at include/svx/unoshape.hxx:358
          ^#39 0x00007f41e68270c9 in SvxShapeControl::release() (this=0x60e3ca0) at include/svx/unoshape.hxx:533
          ^#40 0x00007f41cbdb121e in com::sun::star::uno::Reference<com::sun::star::uno::XAggregation>::~Reference() (this=0x60b39a0) at include/com/sun/star/uno/Reference.hxx:114
          ^#41 0x00007f41cbd9f601 in SwXShape::~SwXShape() (this=0x60b3940) at sw/source/core/unocore/unodraw.cxx:974
                aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x1502140}, <No data fields>}
          ^#42 0x00007f41cbd9f699 in SwXShape::~SwXShape() (this=0x60b3940) at sw/source/core/unocore/unodraw.cxx:963
          ^#43 0x00007f41ea9f7110 in cppu::OWeakObject::release() (this=0x60b3940) at cppuhelper/source/weak.cxx:230
          ^#44 0x00007f41cbdb3485 in cppu::WeakImplHelper<com::sun::star::beans::XPropertySet, com::sun::star::beans::XPropertyState, com::sun::star::text::XTextContent, com::sun::star::lang::XServiceInfo, com::sun::star::lang::XUnoTunnel, com::sun::star::drawing::XShape>::release() (this=0x60b3940) at include/cppuhelper/implbase.hxx:115
          ^#45 0x00007f41d2748b6d in bridges::cpp_uno::shared::freeUnoInterfaceProxy(uno_ExtEnvironment*, void*) (pEnv=0x26d0dc0, pProxy=0x610fed0) at bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:42
        
        Change-Id: Id129278ad720095d2ed77271ac2d47ba82ec32c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184199
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cd85817c7626150fe59cfdd72c09f92cc7d7978]

        loplugin:unusedmethods
        
        Change-Id: I1b2dce9aa52e8af57b15c2bc14c0df67bef185af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-15  Mike Kaganski  <mike.kaganski@collabora.com>  [c608bdee36bd2d914fd8ebfef12b2bebfc204754]

        Use OUStringBuffer instead of C-style array
        
        Change-Id: I1ea51bff7b2eb0f4346a14b558d30efcc7e76a6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184194
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6fa7d991980520238607cb8268052dfdc751b176]

        Make some arrays constexpr
        
        Use Unicode literals, instead of using UTF-8 code units.
        
        And change the key type from LONG to UINT, to match the type
        of the value obtained from MapVirtualKeyW.
        
        Change-Id: I1eff78cf8ad642310e3966596f0f129e9366d8c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184193
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-15  Bayram Çiçek  <bayram.cicek@collabora.com>  [89fdd81f17ac24b007bda26ce5176a5b2f65b1d7]

        tdf#166173: add a unittest for enforcement attribute
        
        of documentProtection element.
        
        - tdf166173_enforcement.docx contains:
        <w:documentProtection w:edit="forms" w:formatting="1" w:enforcement="0"/>
        
        - after export, enforcement attribute should still has '0' value.
        
        Change-Id: I38b48eca054a40586539b1de336ba51f46714a34
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-15  Jonathan Clark  <jonathan@libreoffice.org>  [0f097aee61abc5a8244fb51796f0dd2f9bae22c7]

        tdf#166152 sw: Fix for SwScriptInfo corruption on incremental update
        
        This change fixes a regression in SwScriptInfo::InitScriptInfo, which
        was causing some data structures to be populated with duplicated entries
        following an incremental update.
        
        Regression from 537645c0834eab2d277113f1e3fcf039c994832d
        "tdf#66791 sw: Treat weak punctuation as Asian in Asian paragraphs"
        
        Change-Id: I364effe5579bff35eb7693684e732eafb284d7e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184151
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [8cfc3e8b50e96ecddc25831cf6aa1b7aec5fa548]

        loplugin:unusedfields
        
        Change-Id: I45eedbeeb839279fb469a74a2f8ae1ff3cf32a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fc3b3198c2362f2fc0ae2233d23c163478c1a0d]

        loplugin:unusedfields
        
        Change-Id: I2bbf1c093c5aed75939e9cc51935c8febd9aff04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184160
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a077b777590966ac89b39e0f9159c5df933a6eb]

        use more concrete UNO classes in SwVbaParagraphs
        
        Change-Id: Ib2ddac276e89cc362216bc837e0daefce7b4f135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184159
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f8b700867a2d51e8c6325491828610d0823a86e]

        remove unused field
        
        Change-Id: If81b8c1a21006b49b8025defd2ebd652bdeb8e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184158
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [9851924a4d7648886d7e2d075119a72e77625089]

        tdf#130857 Move weld::EntryTreeView::{g,s}et_entry_font impls to base
        
        The VCL and GTK implementations are equivalent, so move the
        implementation to the base class.
        
        Change-Id: Icbf135411d7d67c68103d8d2caf6edaf3beb8d6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184185
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [21e64a1095fd3f50358e7727e92c1b1187528bad]

        tdf#130857 Move weld::EntryTreeView copy/paste method impls to base
        
        For the SalInstanceEntryTreeView::cut_entry_clipboard and
        SalInstanceEntryTreeview::paste_entry_clipboard implementations,
        this means that Entry::Modify now gets called for the entry/edit
        in addition, as this was added to the corresponding SalInstanceEntry
        methods (but not the SalInstanceEntryTreeView ones) in
        
            commit 097257d5e5ccf5026db42b8bb459dc78390dc9e5
            Date:   Thu Sep 30 16:08:25 2021 +0100
        
                Resolves: tdf#140992 Paste/Cut should mark Edit as modified
        
        However, I see no reason to not have that for SalInstanceEntryTreeView
        as well.
        
        (Should there be any reason, then SalInstanceEntryTreeView could
        still override the base class implementation again, while
        GtkInstanceEntryTreeView - and most likely an upcoming
        QtInstanceEntryTreeView - can continue to use the base
        class implementation.)
        
        Change-Id: Ib2890ad26f717bf81930191251422b86d8bf5e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184184
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [8debe2a6798b45f654bd8046dfcc084a22803100]

        tdf#130857 Move weld::EntryTreeView::set_entry_editable impls to base
        
        The VCL and GTK implementations are equivalent, so move the
        implementation to the base class.
        
        Change-Id: Id0848a92b3bcb0728c9a03d45d3c950d2d656cff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184183
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [09b8cfcdcd0a9c72f2c00654df2c07670c88b05f]

        tdf#130857 Move weld::EntryTreeView::set_entry_placeholder_text impls to base
        
        The VCL and GTK implementations are equivalent, so move the
        implementation to the base class.
        
        Change-Id: I12f768f025e373d6fc442b18335544da0559f825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184182
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [fbf81a6b7959fde6c47da3e818f3e285e1ac80d0]

        tdf#130857 Move weld::EntryTreeView dummy method impls to base class
        
        Instead of having the same dummy implementations for weld::EntryTreeView
        implementations for methods from the weld::ComboBox that only trigger
        asserts in all subclasses, move those to the weld::EntryTreeView base
        class.
        
        As I understand it, these are most likely not actually used, but only
        there because of weld::EntryTreeView being a weld::ComboBox subclass
        (but GtkInstanceEntryTreeView and SalInstanceEntryTreeView not
        subclassing GtkInstanceComboBox and SalInstanceComboBox, so they
        cannot use the existing implementations from those).
        
        Change-Id: Ibf88663fc83142300aa14b39a1e0805bd6f688cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184181
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [77f178ff039aab0ba1fbb3e6732f0c9637bda05c]

        sw a11y: Drop superfluous comment
        
        Explicitly saying that this is always an SwAccessibleContext is
        unnecessary since the type makes that clear since
        
            commit b34c7530a178a61f2f21150f59e7ed01571233c2
            Date:   Mon Sep 16 11:34:40 2024 +0200
        
                use more concrete UNO types in SwAccessibleContext
        
        Change-Id: Ideda7b8cf11855c120afd99f003e94ad34fc4f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184167
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [105b7d4201fc3c6cfac7d2146710c0703aea72f5]

        sw a11y: Get rid of static_cast
        
        Call SwAccessibleMap::GetContextImpl instead
        of SwAccessibleMap::GetContext, which already
        returns a SwAccessibleContext, so there's no
        need to static_cast to that from XAccessible.
        
        Change-Id: Idbc89bfdc454cf3448c891c9e46936e31274f64a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184164
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [793dadb5d75ca34f58b156952bbc997ef83d771a]

        sw a11y: Get rid of need to static_cast
        
        Instead of letting the two SwAccessibleMap::GetContextImpl
        call the corresponding SwAccessibleMap::GetContext
        implementations that return an XAccessible and casting
        that to SwAccessibleContext, rather do it the other way
        around:
        
        Move the existing logic (that already has an
        rtl::Referenc<SwAccessibleContext> to
        SwAccessibleMap::GetContextImpl and let
        SwAccessibleMap::GetContext call the former.
        
        This avoids the need static_cast.
        
        Change-Id: I55cc3502adccb8fd6eece1dab467c8295a8137f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184163
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [fd3fecd59db557e0f3b79163019c2827ea3637a0]

        sw a11y: Drop unused typedef
        
        Change-Id: I33b3ad65b6e0c0ddafa84adba218a46d0f2a6293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184162
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [9498b8d0092e6d903063c279b82101a77decbaf9]

        sw a11y: Deduplicate code for AccessibleEventObject creation
        
        This is basically the Writer equivalent of
        Calc commit
        
            commit b997fd92359c00bb91fd3d25bf992c4b3cd82543
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Apr 9 14:44:35 2025 +0200
        
                sc a11y: Deduplicate code for AccessibleEventObject creation
        
        Behavior should be unchanged except that the
        AccessibleEventId::SELECTION_CHANGED_WITHIN event in
        SwAccessibleTable::FireSelectionEvent previously
        had the AccessibleEventObject::NewValue set to whatever
        would have been set last in the loop above, but that doesn't look
        intended/desirable, so leave it unset now.
        
        Change-Id: Ib108473a02fe109d791e70677714be7e5fab418e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184150
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [9825c183c1a0afdb9800bbde78ee1cd0d3b78f17]

        sw a11y: Fire focus event for scrolled in shape
        
        Setting the AccessibleEventObject::Source to
        a Reference of the AccessibleShape after
        checking it has the focused state, but then
        sending the event using
        SwAccessibleContext::FireAccessibleEvent, i.e.
        to the accessible listeners of the SwAccessibleContext,
        not those of the shape, seems odd.
        
        Instead, notify the listeners of the AccessibleShape
        that has the FOCUSED state set.
        
        Change-Id: Ic9e828c79d0fd99dcf50ba57f9374c427ae2d39a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184149
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [7d4da4426687a63b1b4ab2213a161bb0a47bda20]

        sc a11y: Use concrete rtl::Reference<AccessibleShape>
        
        ... for the return type of some ScAccessibleDocument methods
        and local vars instead of uno::Reference<XAccessible>.
        
        Drop a static_cast in ScAccessibleDocument::Notify
        that is no more necessary now that that type is part
        of the signature.
        
        Change-Id: Ic4e4857b6372581df80442b8669693af06d86a07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184148
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [7806538a33ac8da9c5027193b9a47d8a760f8044]

        sw a11y: Pass concrete type to SwAccessibleMap::InvalidateCursorPosition
        
        ... instead of passing a Reference<XAccessible> and
        unconditionally casting that to SwAccessibleContext.
        
        Change-Id: I0a41ee0296b08870db241e1971919fe166aaaec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184140
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2adacda491cf22f637e6419c4a735c0783e214e6]

        Add a test for three-segment ${file:segment:key} bootstrap references
        
        Change-Id: I6d99cbdc5924b0afefaa1f5f7316824b81ccb474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184179
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [f16f694168b9df555bd93465b0202ed1141fd13d]

        sw a11y: Drop always empty Reference
        
        Ever since the code was added in
        
            commit 5713ed46fa18c274b926dad2a524b66a9538c564
            Author: Michael Brauer <mib@openoffice.org>
            Date:   Mon May 6 11:26:27 2002 +0000
        
                95586#: accessible shapes started
        
        , `xOldCursorAcc` never gets assigned, so drop
        it and the unused code that would only do something
        if it were non-empty.
        
        Change-Id: I5ad3c5f5e6103416fd828324b55783eaf68d61a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184139
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [58e6a9a40e5adb349cdbed41a777e845db62afc9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a029608a20e0acf753b609bc51a89d07823cc8cb
          - tdf#165551 Add case sentitivity entry to validity page
            
            Change-Id: I79013c1b0c8b294112b5688bff07c6ab083e7ae8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184165
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [213acb86d9a2da3972b65b9b0bec7bca27d07fb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 50ac2a4859e37571f39df2a00a250d0d97db121f
          - tdf#163745 BASIC help pages must explicitly state types
            
            Change-Id: Id1c8a68f91b325afd0dd678cfb003d5922100351
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184180
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ce42bf395ca5d98fe710e24280f1008ff195c029]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 665361b6e25061def1bb387eb4c2b3c9fbee5c62
          - tdf#163745 BASIC help pages must explicitly state types
            
            + refactor for simplification
            + changed parameter description section to a table layout
            + tweaks to spare translations
            + changed "Return value" to "Return type" because it refers to
            the type of the returned value.
            
            Change-Id: I4fce2473866c1417bf30c82be11dc79417d1445d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184178
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-14  Khaled Hosny  <khaled@aliftype.com>  [71ed0680be1d1f7af7478a81d0a72027bffe8d61]

        tdf#161981, tdf#157922, tdf#163892 Upgrade HarfBuzz to 11.0.1
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/tag/11.0.1
        
        Change-Id: Id3a6c2c54dde2530ced66a7f971a23aa2fdb815f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184176
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Tested-by: Jenkins

2025-04-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b01838cce57508c216da3b8f728854019160f8db]

        winget configuration: add pkgconf and meson
        
        also securityContext: elevated directives so the the winget configure
        step doesn't need to be done in Admin-shell. If run with regular user
        permissions UAC will prompt.
        
        ninja is part of CMake tools for Windows (that are part of a default
        installation with recommended packages, but not in minimal workload)
        
        Change-Id: I952fc7ac02142d537b2555c1f0e39a53032b96ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183806
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [186e9720b1f97baa6d9817b15a68da64fe33fd9d]

        win: fix dependency issue on libffi for internal python
        
        $(call gb_ExternalExecutable_get_dependencies,python) was incomplete
        since at least "import _ctypes" as done by meson requires libffi to be
        available in instdir. So depend on the package instead of the project.
        
        Change-Id: I8665aeda74cca994e2ba8591278b4b5c8d9ff2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183851
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ae24fc8c639b230284f94e837497cd7919f79d21]

        harfbuzz: migrate to meson
        
        Change-Id: I33aa7ca814409b39b9adb7da1d168c5ebb11b14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183345
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
        Tested-by: Jenkins

2025-04-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [233539764fa1751e9f0495468d410d8574860f13]

        ReemKufi: upgrade to 1.8
        
        Downloaded from https://github.com/aliftype/reem-kufi/releases/download/v1.8/ReemKufi-1.8.zip
        
        Change-Id: I1355d0dd7bb4833a95e1d920f5c13beaf241426e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184016
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>

2025-04-14  Rene Engelhard  <rene@rene-engelhard.de>  [27c0a9d9b6c528f9e010b1ac28cd51a76b31927d]

        bin/lo-xlate-lang: add tl
        
        Change-Id: I716c2ef839b9fc9df0019f5d6f2c506be57f5234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184171
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2025-04-14  Henry Castro  <hcastro@collabora.com>  [4e1b2f117448fb03d7867e297901ad49945cd7f1]

        cppuhelper: prefix 'm_' members of the class OFactoryComponentHelper
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8dbed6d72de45d334e760f3551faa0a3bb7c6fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183274
        Tested-by: Jenkins

2025-04-14  Miklos Vajna  <vmiklos@collabora.com>  [a5f41ea2c026c6e80baabbe7019d517562d195f6]

        sc: move ScTiledRenderingTest to Library_scqahelper
        
        Allows not including .cxx files in Calc tests.
        
        Change-Id: Ib68cd406df1ed1c9d36cbab9701a47bd016eaab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184166
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-14  Gökay Şatır  <gokaysatir@gmail.com>  [e29de7e8d1fe2da1a96e5a190565863951178c9f]

        Calc Test: Ensure text cursor visibility after a paste event.
        
        Change-Id: I1fc688bb683d7bf62ed6330c168227a7761ec2ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184143
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-14  Gökay Şatır  <gokaysatir@gmail.com>  [887ed47fbdb05a2cbbef5722859cdd3e7900b73c]

        Send show cursor command after registering the view.
        
        Issue:
        * Or the "mpViewShell" pointer in "ShowCursor" function is empty and the notification is not sent to Online side.
        
        Change-Id: I42e6d2f914c80fe2bc61483832274357394ef1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184138
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-14  prrvchr  <prrvchr@gmail.com>  [b1528cf4d1662d8aab3cb734feee3886477b12d9]

        tdf#166139 uno-skeletonmaker need to register all service names in passive registration
        
        Change-Id: I5bb176035d09de91459e86e83ec41c772d3ec019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184126
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [925e6269915ee2c62181c93fc6af21572f9863a7]

        show what the name is expected to be in the warning
        
        Change-Id: I856f2e58f283130bf46abda76f95ba2a07a583b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8b28d83532503f09c2553266dd26b6ebe768358c]

        Remove duplicated include
        
        Change-Id: I5bc2f4e1f791c846ec396d59657dc611946aed6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184135
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-04-14  Miklos Vajna  <vmiklos@collabora.com>  [daf8190858d36e0629fe038ea2bbd243b8eef413]

        svx: prefix members of SdrEmbedObjectLink
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib8e7b2bca1347304395149c294634341ba7154f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184128
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-14  Chris Sherlock  <chris.sherlock79@gmail.com>  [921e6117bc0309705a49067287056089fd400a4f]

        vcl: make BitmapDarkenBlendFilter variables constant
        
        Change-Id: Ib147be577caef168f8089883bf64ad7718a801b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173744
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-14  Chris Sherlock  <chris.sherlock79@gmail.com>  [bb75bdc570e6764cd101c47318bc791c9313c0de]

        vcl: remove unnecessary includes in calendar.cxx
        
        Change-Id: Ie8ed143472d79d5fa1b6a415c01efb2f9cc5069b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184125
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-14  Parth Raiyani  <parth.raiyani@collabora.com>  [36aae493d83183d7925c37c1ed42510b96a39905]

        fix: added tooltip property to ToolBox items in DumpAsPropertyTree
        
        Change-Id: Ie58b40df116d90253aca9d51061e5af92a0a61f3
        Signed-off-by: Parth Raiyani <parth.raiyani@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184017
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-04-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f355ddcbf2bf037263e336724829b5467b94ef40]

        chart2: fold isSupported* functions into ChartType
        
        This moves isSupported* function from ChartTypeHelper to ChartType
        where it better belongs to. We can access the concrete classes now
        instead of accessing through UNO si this is possible to do.
        
        Change-Id: Icc52a8ba0d8ab6d5907d7942a1834cc6f7093cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182712
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4575f033e58148ede7283ad2f3c4cd353e57022a]

        vcl: ImpGraphic - rearange code to keep each each type together
        
        Also implement getChecksum at the {Bitmap,Animation}Container and
        use that in ImpGraphic::getChecksum.
        
        Change-Id: I3dd4a0a80bd8f009919956548c049fde6b9df3b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184113
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [90fe4900037d741ef04bdf20fc2416eaaad719a6]

        vcl: make ImpGraphic::getBitmap private
        
        Change-Id: I576ef069e0cbbe9b8f6be004654687765acd3ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184112
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2d586cea07ec5d387976bbff0fac36233b84ea6c]

        vcl: ImpGraphic - use sal_Int64 for byte size
        
        Already used in memory manager anyway.
        
        Change-Id: I9edf79a4c021434f573301a8e47dc76ae542aa4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184111
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-04-14  Regina Henschel  <rb.henschel@t-online.de>  [4f6666529003185fcf40bf23a8f2bcfd8596724c]

        tdf#154858 radial gradient import remove obsolete part
        
        LO has imported radial gradients as rotated linear gradient in case
        of gradient center in shape corner. That was changed in commit
        65439ab2c4fc87e7cc115710a605e9f35dfb39d8 to always using radial gradient.
        So the comment about linear gradient is no longer valid and the gradient
        rotation is useless.
        
        Change-Id: I679f8afc347845eb012e3377e03877c3a7c7d6c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184117
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins

2025-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de18b0a49df79ac0f03abd7a953eae850fa58b3a]

        crashtesting: tdf107209-1.odt exported to rtf cannot be loaded
        
        probably since:
        
        commit 326388da4e40c85f8a1af40264aaf56c7845e224
        CommitDate: Tue Dec 29 13:55:41 2020 +0100
        
            tdf#138779 do not call EndRun() in StartRuby()
        
        There is ruby text in this doc which doesn't span any base text
        so there isn't a run to close it. If there are two of these
        empty rubys in a paragraph the tags get noticibly mangled.
        
        <text:p text:style-name="Text_20_body">
        て栄繁あとうも陸爛誇え大て折ほつころ<text:ruby text:style-name="Ru1">
        <text:ruby-base/>
        <text:ruby-text>
        けんらん</text:ruby-text>
        </text:ruby>
        なも大草みよだ生舗よぬ雑うば物ばほ路っ作あ足通法し相いしこら様がつば有が<text:ruby text:style-name="Ru1">
        <text:ruby-base/>
        <text:ruby-text>
        ふさわ</text:ruby-text>
        </text:ruby>
        </text:p>
        
        Change-Id: I4befe041e778c67f7f9fc7f1510b0a73a8b35d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184122
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [a05f27d0f17729201ba95d934c522d7cb145fda3]

        math: Resave fontdialog.ui with glade 3.40
        
        The dialog can be triggered as follows:
        
        * start Math
        * "Format" -> "Fonts"
        * "Modify" -> "Math"
        
        Change-Id: I9972f85001fc44942c3024302487b746ee7199ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184109
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [0cd985d302978e4119c9435cdd9d51d9d1d31b8f]

        tdf#130857 qt weld: Support BasicIDE "Go to Line" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This GotoLineDialog can be triggered as follows in
        Writer:
        
        1) "Tools" -> "Macros" -> "Edit Macros"
        2) in Basic IDE click on the info about current
           line and column in the centre of the status bar
           (e.g. "Ln 1, Col 1")
        
        Change-Id: I32a88d9f3501a60b0c9402c93aaf7169be993d44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184108
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [d5882d293e97f12b70d6b20dad38aca621d0ddee]

        tdf#130857 basctl: {G,S}et SpinButton value instead of text
        
        Just set/get the value directly and leave it to the
        weld::SpinButton implementation to handle the
        string <-> value conversion.
        
        This GotoLineDialog can be triggered as follows in
        Writer:
        
        1) "Tools" -> "Macros" -> "Edit Macros"
        2) in Basic IDE click on the info about current
           line and column in the centre of the status bar
           (e.g. "Ln 1, Col 1")
        
        Change-Id: I857ec345d37b35733079aee4d1723f838a438a5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184107
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [5c1912f1eed81484befa122681e04e92efa6a1c7]

        tdf#130857 qt weld: Forward key press/release events
        
        Similar to how
        
            commit 099feb494d23bd0addc162a15a5bb90ddc68c111
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 11 15:58:16 2025 +0200
        
                tdf#130857 qt weld: Forward mouse click/release events
        
        implemented it for mouse click/release events, also
        forward Qt key press/release events for the widget
        as vcl KeyPress events.
        
        In a WIP/experimental branch for the spelling dialog
        that contains more changes, this makes typing in
        the edit view in that dialog work.
        
        Change-Id: I334f4fa5811d02260140c2791eee9705d666086c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184106
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [39cc9ad90c6285b522ab909479a7ec1a3541c051]

        qt: Return early in toVclKeyCode
        
        Return value right away instead of first
        assigning to a local variable and returning
        at the end of the function.
        
        Change-Id: I4b00c2fcb29529f04d84ba5b61423a39bb305231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184105
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [a10fe020128bc0573af656cbd1aaee1d3d3355be]

        tdf#130857 qt: Move Qt -> VCL key code helper to QtTools
        
        Move helper function GetKeyCode to QtTools and rename to
        toVclKeyCode.
        
        This will allow reusing it from QtInstanceWidget in
        an upcoming commit.
        
        Change-Id: I7157ee870d16bb77a677c8505e8018b5b871c7f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184104
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [6080e0aaad7e2da1b27791fa604f97eb13c8e98f]

        qt: Drop width param for QtWidget::fillSalAbstractMouseEvent
        
        This is always QtWidget::width(), so just call
        that method in QtWidget::fillSalAbstractMouseEvent
        instead of passing it as a param.
        
        Also drop the FILL_SAME macro.
        
        Change-Id: I2b9cd4df4d321ae4b178088f924d015d193404ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184103
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [79766a63479d9b273d9611cd4616027fff85a836]

        qt: Simply use 'this' in QtWidget methods
        
        ... instead of retrieving a pointer to self
        using `m_rFrame.GetQWidget()`.
        
        Change-Id: Ic61b2e73d6c058979e0b779eee29a32bd52b7d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184102
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [525b3aaa13990185937e773c5afd921476dfeb23]

        qt: Make more QtWidget methods non-static
        
        As done for other methods in previous commits,
        make more methods non-static and use class
        members directly instead of passing them
        as method params.
        
        Change-Id: I9180f7ff94d56b8291878fc5c7ac9e4bcc5d280f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184101
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [f0b83c111c21112637536377d0e759d64f6362e6]

        qt: Make QtWidget::handleMouseEnterLeaveEvents non-static
        
        Make non-static and use `m_rFrame` directly instead of
        passing it as a param.
        Also rename to QtWidget::handleMouseEnterLeaveEvent
        (i.e. drop "s" at the end, as it only processes
        a single event, like the other methods.
        
        Change-Id: If7312982f1fc9ea16b06fe05bfbccaa6737dac30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184100
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [5b1137f08d3cc18ac79afc5e0c73e40343898181]

        qt: Inline QtWidget::handleKeyReleaseEvent to only caller
        
        Change-Id: I4711bfb218f2064f0c56049c0dfec9df43522223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184091
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [a34dac1722555468121acec93616211fa58ddac5]

        qt: Simplify QtWidget::handleEvent
        
        Make non-static and stop passing `m_rFrame` and `this`
        as params in (at least by now) only caller.
        
        Change-Id: Ib001bc2a3da443dc9413a170ea7ac922399be0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184090
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [004f6c08a5f63b0da428bd0fbcbee5330fff53a0]

        qt: Simplify QtWidget::fillSalAbstractMouseEvent
        
        Make the method non-static and use m_rFrame directly instead
        of passing it as a param in all callers.
        
        Change-Id: Id36fb2df3d9118c69ab561d614e2122f727e0c55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184089
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [8e429e752c70dcdc2620f0d844f6fc07a9673a35]

        qt: Simplify QtWidget::handleMouseButtonEvent
        
        Make the method private, non-static and use m_rFrame directly instead
        of passing it as a param in all callers.
        
        Change-Id: I6f7ffcc8c147187cdbbc0588cd3c7b866f40b80f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184088
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [e0e1e6fa7f71c2702a79c7594ebb4dea0441b737]

        attempt to make the impress UITest more reliable
        
        I __think__ the spate of UI test failures on jenkins are
        because multiple concurrent builds are ending up trying
        to use the same temporary file.
        
        Change-Id: I56274cadf40f043c3cf98a82dee3d7cf796e0839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184094
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [8734d375be70a991d3e44b5a26191360d4d32a3c]

        use more concrete UNO in chart2
        
        Change-Id: I3bd1202fc54d474f135d5d541ecca62b06e80d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [50767acffde4b4b144a7ba4eb3d959ae30866333]

        use more concrete UNO in chart2
        
        Change-Id: I6de2e5376cf2a9054d5bb06fc04884e89babd3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [deb736a4f32c0dd5c0ab024e736dd2fb90b10f6e]

        no need to use Sequence here
        
        Change-Id: I88b24d4703d6a1dcbe6a90936a01eb9f893e386a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-13  Aron Budea  <aron.budea@collabora.com>  [82c5d55a9d21b889ecfb71253b4b04084c2e22b9]

        Revert "tdf#165180 convert-to: prefer PowerPoint 2007-365, not Office Open XML"
        
        This reverts commit d4c7b78827c12c4bbc871c3b9eb0ce28271adba4.
        
        The situation is more complicated, let's not change anything
        until reviewing the impact.
        
        Change-Id: Iae8e10bb7eb716c025501f3490909941bf7c4515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184114
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [4e5ea3b1fd3b21ce6108aab58f9e054dc3442722]

        fold DataSeriesHelper functions into DataSeries
        
        Where it better belongs, and where we can do a much better implementation.
        
        Change-Id: I370bd23ee0dfb1570d6376d21b8dac4c83591096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184098
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-13  Noel Grandin  <noelgrandin@gmail.com>  [84f7b8405236dabee247c59858e54a37fa0c67c3]

        fold DataSeriesHelper functions into ChartType
        
        Where it better belongs, and where we can do a much better implementation.
        
        Change-Id: I00d77c28d3dc78c672e8a6756797a768a2eb0d02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184097
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7abefc023c394827563dd6fae82e873d70aeabc7]

        Remove obsolete fw declarations from connectivity/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I0da5d8732b883f862688371bfb175a0aef950691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183880
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [99741c0ece2bf4ed81719083e2906aaf8b34bfff]

        Remove obsolete fw declarations from cppcanvas/ cui/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ie0669b460378c909d5cee2a786763e4d54087ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183881
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8d9cd8c894e18f28859f613eab1c8819d2e58b3e]

        Remove obsolete fw declarations from dbaccess/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: I1a3b1420119b0c79860a1fde69efa4272356af61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183882
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-12  Noel Grandin  <noelgrandin@gmail.com>  [7bb586c436e1b6c12937741a0e170587989ee020]

        fold DataSeriesHelper functions into DataSeries
        
        Where it better belongs, and where we can do a much better implementation.
        
        Change-Id: I81aa687f28816aabed58a3fd26d22a8340c8bfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184070
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-12  Noel Grandin  <noelgrandin@gmail.com>  [1aa34c45b6622942983c872d9d307d5768b68246]

        fold DataSeriesHelper functions into DataSeries
        
        Where it better belongs, and where we can do a much better implementation.
        
        Change-Id: Iec0c932b40512819bd6cc10afa3e2da93fa1e1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184069
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-12  Noel Grandin  <noelgrandin@gmail.com>  [18d5b8c5e5874685abea23e63f2f9eb41dddfc9c]

        fold DataSeriesHelper functions into DataSeries
        
        This moves functions from DataSeriesHelper to DataSeries
        where it better belongs. We can access the concrete classes now
        instead of accessing through UNO.
        
        Change-Id: I15d38c782df3b04aeb2637049ba665b1d0e060ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184068
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-12  Noel Grandin  <noelgrandin@gmail.com>  [11fccfffdcc2269e79d2a41dca26fed05a04a7f2]

        no need to dynamic_cast here
        
        all the call-sites already have the concrete type
        
        Change-Id: Ic15f4ed56cb563b966c05bfb41811c7d79ff185c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184067
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-12  Noel Grandin  <noelgrandin@gmail.com>  [c804e7ffd6ba89426f6d80002aeeab7034c4030b]

        fold DataSeriesHelper functions into DataSeries
        
        This moves functions from ChartModelHelper to ChartModel
        where it better belongs. We can access the concrete classes now
        instead of accessing through UNO.
        
        Change-Id: I35ea769fdbd0af75ae791931505b61c73c4eeac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-12  Mike Kaganski  <mike.kaganski@collabora.com>  [fc227d83a3215a0ab7b010dcc77221ed15eff1f3]

        Simplify SwPosition comparison
        
        Change-Id: I77152569894382a7221b0dcb81a0307ed0217a14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184072
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-12  Mike Kaganski  <mike.kaganski@collabora.com>  [080198e691c944cdf7553cfa86d52e33c2072f51]

        Reorder checks for clarity
        
        Change-Id: I3b18f2dab7b4d7e874548c252730566b2df12798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184077
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [3f69f711a1c3945982c5efcd79a378fb35241629]

        tdf#130857 qt weld: Signal when tool button is clicked
        
            Change-Id: I07c406d6257912a64eeaa781edf245ad16c87862
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Apr 12 00:32:01 2025 +0200
        
                tdf#130857 qt weld: Add initial tool button support
        
        implemented support for "GtkToolButton" objects in .ui files
        and inserts the created QToolButtons in the QToolBar parent
        if there is one.
        
        Build upon this and signal when one of the tool buttons
        inside a toolbar is clicked by calling weld::Toolbar::signal_clicked.
        
        Set the GtkBuilder ID as the QObject::objectName for
        all created objects in QtBuilder::makeObject.
        
        Connect to the QToolButton::clicked signal for all
        tool buttons in the toolbar, and retrieve their ID
        using the QObject::objectName to be able to notify what
        is the ID of the clicked button.
        
        In an experimental/WIP branch to support the spelling dialog
        that contains more changes, this commit results in the
        clipboard content to be pasted when clicking the corresponding
        button in the spelling dialog toolbar, and clicking the special
        characters button now results in the special character dialog
        to open as expected, while nothing would happen previously.
        
        Change-Id: I75b5136c85d4d2c44a312e55624c36a12e87dc7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184085
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [0eb86f18f9d9f3ef1c86b9d1fd7af50ea9c20e6c]

        tdf#130857 qt weld: Add initial tool button support
        
        Handle "GtkToolButton" objects in QtBuilder by creating
        a QToolButton widget for them.
        Evaluate the GtkToolButton::icon-name property [1].
        
        This is used e.g. in the spelling dialog ("Tools" -> "Spelling"),
        .ui file: cui/uiconfig/ui/spellingdialog.ui
        (Dialog not declared as supported yet in QtInstanceBuilder and
        there's much more to do before it can be.)
        
        Support for more properties can be added when needed.
        
        [1] https://docs.gtk.org/gtk3/property.ToolButton.icon-name.html
        
        Change-Id: I07c406d6257912a64eeaa781edf245ad16c87862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184084
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [e3ef8372d330a05fe485792edc99e139c847ae45]

        tdf#130857 qt weld: Pass logic size to OutputDevice::GetBitmapEx
        
        In a local experimental/WIP branch where support for the
        spelling dialog ("Tools" -> "Spelling") and the Base
        "Tools" -> "SQL" dialog are declared in QtInstanceBuilder,
        the text in their edit views wasn't displayed properly, but
        only a very small percentage of the text was displayed
        in the QLabel of the QtInstanceDrawingArea and it looked
        cropped, despite the QLabel widget itself being large enough
        to hold the full content (i.e. much of its area remained unused
        instead of showing the edit view/text).
        
        According to my analysis, this is because
        OutputDevice::GetBitmapEx expects logic coordinates,
        while the toQPixmap helper function was passing
        pixel coordinates so far.
        
        Inside OutputDevice::GetBitmap the width/height would then
        be converted from alleged logic size to device pixels:
        
            Bitmap OutputDevice::GetBitmap( const Point& rSrcPt, const Size& rSize ) const
            {
                if ( !mpGraphics && !AcquireGraphics() )
                    return Bitmap();
        
                assert(mpGraphics);
        
                tools::Long    nX = ImplLogicXToDevicePixel( rSrcPt.X() );
                tools::Long    nY = ImplLogicYToDevicePixel( rSrcPt.Y() );
        ->      tools::Long    nWidth = ImplLogicWidthToDevicePixel( rSize.Width() );
        ->      tools::Long    nHeight = ImplLogicHeightToDevicePixel( rSize.Height() );
        
        , resulting in a way too small width and height being used.
        
        Fix the issue by passing the device's logic instead of
        pixel size.
        
        Other images/drawing areas in already supported dialogs still looked
        fine in a quick test.
        
        Sample backtrace of how the relevant code got called for the Base
        "SQL" dialog:
        
            1  OutputDevice::GetBitmap                                             bitmap.cxx                       198  0x7f68a668cbeb
            2  OutputDevice::GetBitmapEx                                           bitmapex.cxx                     154  0x7f68a6692cbf
            3  toQPixmap                                                           QtUtils.hxx                      65   0x7f689e21752d
            4  QtInstanceDrawingArea::handlePaintEvent                             QtInstanceDrawingArea.cxx        125  0x7f689e22d304
            5  QtInstanceDrawingArea::eventFilter                                  QtInstanceDrawingArea.cxx        104  0x7f689e22d0fe
            6  QCoreApplicationPrivate::sendThroughObjectEventFilters              qcoreapplication.cpp             1248 0x7f689d24f65d
            7  QApplicationPrivate::notify_helper                                  qapplication.cpp                 3303 0x7f689b1e2e7e
            8  QApplication::notify                                                qapplication.cpp                 3255 0x7f689b1e6d84
            9  QCoreApplication::notifyInternal2                                   qcoreapplication.cpp             1111 0x7f689d24f159
            10 QCoreApplication::sendSpontaneousEvent                              qcoreapplication.cpp             1565 0x7f689d24fe59
            11 QWidgetPrivate::sendPaintEvent                                      qwidget.cpp                      5659 0x7f689b297bbf
            12 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5609 0x7f689b28ccb5
            13 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            14 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            15 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            16 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            17 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            18 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            19 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            20 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            21 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            22 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            23 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            24 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            25 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            26 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            27 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            28 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            29 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5788 0x7f689b298140
            30 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            31 QWidgetPrivate::paintSiblingsRecursive                              qwidget.cpp                      5774 0x7f689b297fe0
            32 QWidgetPrivate::drawWidget                                          qwidget.cpp                      5650 0x7f689b28d0b7
            33 QWidgetRepaintManager::paintAndFlush                                qwidgetrepaintmanager.cpp        907  0x7f689b2d41d2
            34 QWidgetRepaintManager::sync                                         qwidgetrepaintmanager.cpp        632  0x7f689b2d21d7
            35 QWidgetPrivate::syncBackingStore                                    qwidget.cpp                      1775 0x7f689b28b9bb
            36 QWidgetWindow::handleExposeEvent                                    qwidgetwindow.cpp                1100 0x7f689b2e3910
            37 QWidgetWindow::event                                                qwidgetwindow.cpp                339  0x7f689b2e0c73
            38 QApplicationPrivate::notify_helper                                  qapplication.cpp                 3309 0x7f689b1e2ea0
            39 QApplication::notify                                                qapplication.cpp                 3259 0x7f689b1e6da8
            40 QCoreApplication::notifyInternal2                                   qcoreapplication.cpp             1111 0x7f689d24f159
            41 QCoreApplication::sendSpontaneousEvent                              qcoreapplication.cpp             1565 0x7f689d24fe59
            42 QGuiApplicationPrivate::processExposeEvent                          qguiapplication.cpp              3482 0x7f689c091814
            43 QGuiApplicationPrivate::processWindowSystemEvent                    qguiapplication.cpp              2276 0x7f689c08cb54
            44 QWindowSystemInterface::sendWindowSystemEvents                      qwindowsysteminterface.cpp       1113 0x7f689c174c6d
            45 QWindowSystemInterface::flushWindowSystemEvents                     qwindowsysteminterface.cpp       1082 0x7f689c174b1e
            46 QtWaylandClient::QWaylandDisplay::flushRequests                     qwaylanddisplay.cpp              521  0x7f68972afd75
            47 QtWaylandClient::QWaylandDisplay::qt_static_metacall                moc_qwaylanddisplay_p.cpp        94   0x7f68972b4cdf
            48 doActivate<false>                                                   qobject.cpp                      4253 0x7f689d328654
            49 QMetaObject::activate                                               qobject.cpp                      4301 0x7f689d31e763
            50 QAbstractEventDispatcher::awake                                     moc_qabstracteventdispatcher.cpp 128  0x7f689d2386b9
            51 QEventDispatcherGlib::processEvents                                 qeventdispatcher_glib.cpp        406  0x7f689d852db8
            52 QPAEventDispatcherGlib::processEvents                               qeventdispatcher_glib.cpp        89   0x7f689c986d88
            53 QEventLoop::processEvents                                           qeventloop.cpp                   104  0x7f689d2692e0
            54 QEventLoop::exec                                                    qeventloop.cpp                   186  0x7f689d269533
            55 QDialog::exec                                                       qdialog.cpp                      575  0x7f689b68e580
            56 QtInstanceDialog::run                                               QtInstanceDialog.cxx             105  0x7f689e227994
            57 weld::DialogController::run                                         weld.hxx                         2814 0x7f683ca5262e
            58 svt::OGenericUnoDialog::execute                                     genericunodialog.cxx             206  0x7f68a8a83d6c
            59 dbaui::OApplicationController::openDialog                           AppControllerGen.cxx             202  0x7f683ca5eb89
            60 dbaui::OApplicationController::Execute                              AppController.cxx                1305 0x7f683ca09f84
            61 dbaui::OGenericUnoController::executeChecked                        genericcontroller.cxx            974  0x7f683cb60803
            62 dbaui::OGenericUnoController::dispatch                              genericcontroller.cxx            586  0x7f683cb5d66a
            63 framework::MenuBarManager::Select                                   menubarmanager.cxx               821  0x7f68acf0f08b
            64 framework::MenuBarManager::LinkStubSelect                           menubarmanager.cxx               776  0x7f68acf0eafd
            65 Link<Menu *, bool>::Call                                            link.hxx                         105  0x7f68a637ced6
            66 Menu::Select                                                        menu.cxx                         352  0x7f68a636ec13
            [...]
        
        Change-Id: Ibb0904be6333f85fc5c809b549d48681e1339e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184083
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3fa39a4dadc8e2777185465a6f7c9968c8cf44d1]

        tdf#165917 Improve Export directory pre-selection
        
        When calling an Export dialog (PDF, epub, ...) the following
        folder will be preselected:
        
        For stored documents:
        * Current document directory
        * If another directory was chosen for the export,
          that directory will be preselected for subsequent exports
          (stored only during runtime - per document)
        
        For unstored documents:
        * The last used export directory is restored (last used in unsaved doc)
        
        Change-Id: I97595d164cf1d3604166c38aa2a5ed31be56f113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184062
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [7fac8458e35620b9855cc6c68a9675159a849b65]

        tdf#130857 qt weld: Support "Address Book Assignment" dlg
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered from Writer using
        "Tools" -> "Address Book Source".
        
        Change-Id: I6d6bbbe12afc8bc31fa8416b5688c010e4a9fd8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184080
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [b03bf3bbb1457671110f1cd9c503eacdb6441da5]

        tdf#130857 address book source dialog: No more do delayed initialization
        
        Posting a user event and initialize things when that
        event gets processed doesn't work with the qt6 VCL
        plugin when using native widgets (for which support
        will be added in an upcoming commit). There, the
        user event only gets processed after the dialog gets
        closed, and then results in a crash when support for
        the dialog is declared in
        QtInstanceBuilder::IsUIFileSupported.
        
        This seems similar to the scenario in
        
            commit 29d6065d9a687f1d86f26f53587e108f8c951a4a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Sep 16 15:21:01 2024 +0200
        
                sfx2: Synchronously set control state in file picker on all platforms
        
        As was done there, do the work right away instead.
        Should that result in any unresponsiveness for certain
        scenarios, those will have to be examined more closely.
        
        (At least with the Bibliography database used for the data
        source, all seems fine.)
        
        Change-Id: Ic2d35df49b683c27c2b505018374f421699f6711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184079
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [bb7cbdb74fa8b27f525a8a8b4ef54aaa0832cc56]

        svtools: Use initializer list to fill vector
        
        The dialog is the "Tools" -> "Address Book Source"
        one in Writer.
        
        Change-Id: I2838377ac98a22307ffa3e25629c481373c4dd0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184078
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [649ea69f09e2c886aa3da99f79122d7d33f0e05d]

        boost: upgrade to 1_88_0
        
        * external/boost/armv7.patch.0 and
        external/boost/0001-Avoid-Wdeprecated-variadic-comma-omission-with-GCC-1.patch.2
        have been fixed upstream
        
        * ignore warning 4996 in vcl/source/window/layout.cxx, otherwise it started to fail with
        [build CXX] vcl/source/window/layout.cxx
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/storage_order.hpp(51): error C2220: the following warning is treated as an error
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/storage_order.hpp(51): warning C4996: 'boost::array<bool,2>::assign': please use `fill` instead
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/storage_order.hpp(47): note: while compiling class template member function 'boost::general_storage_order<2>::general_storage_order(const boost::c_storage_order &)'
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array.hpp(153): note: see reference to function template instantiation 'boost::general_storage_order<2>::general_storage_order(const boost::c_storage_order &)' being compiled
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(350): note: see reference to class template instantiation 'boost::general_storage_order<2>' being compiled
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(414): note: see reference to class template instantiation 'boost::const_multi_array_ref<T,2,T *>' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array.hpp(122): note: see reference to class template instantiation 'boost::multi_array_ref<T,2>' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/window/layout.cxx(905): note: see reference to class template instantiation 'boost::multi_array<`anonymous-namespace'::GridEntry,2,std::allocator<T>>' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(343): warning C4996: 'boost::array<int,2>::assign': please use `fill` instead
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(325): note: while compiling class template member function 'boost::const_multi_array_ref<T,2,T *>::const_multi_array_ref(TPtr,const boost::general_storage_order<2> &,const int *,const unsigned int *)'
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(616): note: see reference to function template instantiation 'boost::const_multi_array_ref<T,2,T *>::const_multi_array_ref(TPtr,const boost::general_storage_order<2> &,const int *,const unsigned int *)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/view.hpp(234): warning C4996: 'boost::array<int,2>::assign': please use `fill` instead
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/view.hpp(434): note: see reference to function template instantiation 'boost::detail::multi_array::const_multi_array_view<T,2,T *>::const_multi_array_view<ExtentList,int>(TPtr,const ExtentList &,const boost::array<int,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    ExtentList=boost::array<int,2>,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/view.hpp(434): note: see reference to function template instantiation 'boost::detail::multi_array::const_multi_array_view<T,2,T *>::const_multi_array_view<ExtentList,int>(TPtr,const ExtentList &,const boost::array<int,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    ExtentList=boost::array<int,2>,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/base.hpp(490): note: see reference to function template instantiation 'boost::detail::multi_array::multi_array_view<T,2>::multi_array_view<boost::array<int,2>,int>(T *,const ExtentList &,const boost::array<int,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    ExtentList=boost::array<int,2>
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/base.hpp(487): note: see reference to function template instantiation 'boost::detail::multi_array::multi_array_view<T,2>::multi_array_view<boost::array<int,2>,int>(T *,const ExtentList &,const boost::array<int,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry,
                    ExtentList=boost::array<int,2>
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(539): note: see reference to function template instantiation 'ArrayRef boost::detail::multi_array::multi_array_impl_base<T,2>::generate_array_view<return_type,2,`anonymous-namespace'::GridEntry*>(boost::type<return_type>,const boost::detail::multi_array::index_gen<2,2> &,const unsigned int *,const int *,const int *,TPtr) const' being compiled
                with
                [
                    ArrayRef=return_type,
                    T=`anonymous-namespace'::GridEntry,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(533): note: see reference to function template instantiation 'ArrayRef boost::detail::multi_array::multi_array_impl_base<T,2>::generate_array_view<return_type,2,`anonymous-namespace'::GridEntry*>(boost::type<return_type>,const boost::detail::multi_array::index_gen<2,2> &,const unsigned int *,const int *,const int *,TPtr) const' being compiled
                with
                [
                    ArrayRef=return_type,
                    T=`anonymous-namespace'::GridEntry,
                    TPtr=`anonymous-namespace'::GridEntry *
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array.hpp(494): note: see reference to function template instantiation 'boost::detail::multi_array::multi_array_view<T,2> boost::multi_array_ref<T,2>::operator []<2>(const boost::detail::multi_array::index_gen<2,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array.hpp(494): note: see reference to function template instantiation 'boost::detail::multi_array::multi_array_view<T,2> boost::multi_array_ref<T,2>::operator []<2>(const boost::detail::multi_array::index_gen<2,2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\boost\boost/multi_array.hpp(454): note: while compiling class template member function 'boost::multi_array<`anonymous-namespace'::GridEntry,2,std::allocator<T>> &boost::multi_array<T,2,std::allocator<T>>::resize(const boost::detail::multi_array::extent_gen<2> &)'
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/window/layout.cxx(928): note: see reference to function template instantiation 'boost::multi_array<`anonymous-namespace'::GridEntry,2,std::allocator<T>> &boost::multi_array<T,2,std::allocator<T>>::resize(const boost::detail::multi_array::extent_gen<2> &)' being compiled
                with
                [
                    T=`anonymous-namespace'::GridEntry
                ]
        make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/vcl/source/window/layout.o] Error 2
        
        <https://dev-www.libreoffice.org/src/boost_1_88_0.tar.xz> has been generated (on
        Debian 12) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.88.0/source/boost_1_88_0.tar.bz2
        > $ printf '46d9d2c06637b219270877c9e16155cbd015b6dc84349af064c088e9b5b12f7b boost_1_88_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_88_0.html>
        > boost_1_88_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_88_0.tar.bz2
        > Unpacking boost_1_88_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_88_0.tar.xz ...
        > Cleaning up ...
        > 5c67a448c562f1606e38203ba7ed7e8d7453581b6b9ca324e96205eae0da5ff8  boost_1_87_0.tar.xz
        > Done.
        
        Change-Id: Ib5f613b34ffb161348b1fd7653cce0d12da98994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184035
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-11  Noel Grandin  <noelgrandin@gmail.com>  [b81f1bce7375cda4f537dac461cf57652cba67c6]

        fold ColorPerPointHelper into DataSeries
        
        Where it better belongs, and where we can do a much better implementation.
        
        Change-Id: I0ea8004778c3697bda97972cb842241459538c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184065
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f8602e4feac16b5d0f6b80b93d5be6378f0aa11]

        tdf#166102: replace < and > with parentheses
        
        =sum<A1:A3> was exported to =sumA1:A3 making the
        expression faulty
        
        I also tried replacing them with spaces but then it causes
        a Syntax error in Word after updating the field
        
        Change-Id: I25b42d0a06335a4e5d8c8df90e8cf30e191fe426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183967
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [8a77f46f0ec8e360bab42dc59a952cebf2cc775b]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_font
        
        Reuse the existing toVclFont helper to get a vcl::Font for
        the QWidget's QFont.
        Fall back to the LO application font if that fails.
        
        Change-Id: I9394fb759c3d20ef35581689362afa713ad4033e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184059
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [0acf18f1c30abe66dfe7480a06e0b3a24fb61baf]

        tdf#130857 qt: Move toVclFont helper to QtTools
        
        ... in order to reuse it when implementing
        QtInstanceWidget::get_font in an upcoming commit.
        
        Change-Id: I5053c24fecd791ef8b5b9b92d9319df9df83f6c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184058
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [d023035acf83ee1b61dfc03333bfc6e612bb58f6]

        qt: Consolidate to one toOUString helper
        
        Instead of having one for vcl in vcl/inc/qt5/QtTools.hxx
        and one in avmedia/source/qt6/QtFrameGrabber.cxx,
        move the existing implementation to
        include/vcl/qt/QtUtils.hxx and use it everywhere.
        
        Change-Id: I8576ab0fe2fd12bb25ae262e59acb8412ef8be0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184057
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [2ceea3e05bdc777d9c1093ef8f838d4a716e0b75]

        tdf#130857 qt weld: Show drawing area tooltips
        
        This is similar to what
        
            commit dd9096736e2e89cc533bc04c77bf539bcc5df6bc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 21:31:04 2025 +0100
        
                tdf#130857 qt weld: Show IconView item tooltips
        
        implemented for weld::IconView, but now for weld::DrawingArea.
        
        Note that `aHelpArea` is an in/out param for
        weld::DrawingArea::signal_query_tooltip, see also
        the gtk3 implementation in
        GtkInstanceDrawingArea::signalQueryTooltip.
        
        In a WIP branch (also containing various other changes)
        for the "File" -> "Templates" -> "Manage Templates" dialog,
        this results in the tooltip for the currently hovered
        template to appear when hovering with the mouse and waiting
        for a few seconds in thumbnail mode.
        
        Change-Id: Ic829d1d1984aedddc0eaccba7538937defea57f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184053
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [2cca27e91e3110457099cea0ec66caf790e6feaf]

        tdf#130857 qt weld: Forward mouse move events
        
        Similar to what
        
            Change-Id: I507deb1ed4aa2ae39c5f2b14f8bcb1fc1069ccf3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 11 15:58:16 2025 +0200
        
                tdf#130857 qt weld: Forward mouse click/release events
        
        implement for mouse click/release events, also forward
        mouse move events.
        
        Quoting from the QWidget::mouseTracking doc [1]:
        
        > If mouse tracking is disabled (the default), the widget only
        > receives mouse move events when at least one mouse button is
        > pressed while the mouse is being moved.
        
        Therefore, override weld::Widget::connect_mouse_move to
        explicitly enable mouse tracking for the widget when
        a handler gets set (and disable otherwise).
        
        In a WIP branch (also containing various other changes)
        for the "File" -> "Templates" -> "Manage Templates" dialog,
        this results in mouse-hover highlighting (light bue with
        the Fusion style) to work in thumbnail mode.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#mouseTracking-prop
        
        Change-Id: I28ac58caafef9721168338ec145bbd41327be9b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184049
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [099feb494d23bd0addc162a15a5bb90ddc68c111]

        tdf#130857 qt weld: Forward mouse click/release events
        
        Set QtInstanceWidget as event filter for its QWidget
        and in QtInstanceWidget::eventFilter, handle
        (single and double) mouse click and mouse release
        events by converting the QMouseEvent to a corresponding
        vcl MouseEvent and calling weld::Widget::signal_mouse_press
        and weld::Widget::signal_mouse_release.
        
        In a WIP branch (also containing various other changes)
        for the "File" -> "Templates" -> "Manage Templates" dialog,
        this results in the correct template getting highlighted when
        clicking on it and opened when double-clicking on it in
        thumbnail mode.
        
        Change-Id: I507deb1ed4aa2ae39c5f2b14f8bcb1fc1069ccf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184048
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [b22229d473e435d33ff6b59ac8c72213d1c53df9]

        tdf#130857 qt weld: Call base class eventFilter()
        
        If the QObject::eventFilter override doesn't handle
        the event itself, call the base class implementation.
        
        This will in particular be relevant once QtInstanceWidget
        will handle events like mouse clicks.
        
        Change-Id: I8055f049cf0244103e55fe4d5c042666d270a3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184047
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [00ce53015d314fbb6bc4a5832b53578cee166918]

        qt: Rename Get{Key,Mouse}ModCode helpers
        
        .. to match the "toVcl..." naming scheme used
        for other helper functions to convert between
        Qt and VCL types.
        
        Change-Id: I33a79b476427dd779ff3e717200c84bd5c358ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184046
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [fc2eee6c3ed912f21850d106fb3094b80774c19e]

        tdf#130857 qt weld: Support "Font Features" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can e.g. be triggered from Writer using
        "Format" -> "Character", then clicking the "Features" button
        in the "Character" dialog.
        
        Change-Id: I8440692adf3956f318cccee68717860ef10a67bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184040
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [70db1c2de93f34eee8a9c411f4f0db21502347db]

        tdf#130857 qt weld: Handle special combobox insert pos -1
        
        weld::ComboBox::append calls weld::ComboBox::insert
        with a special insert position of -1, so handle
        that in QtInstanceComboBox::insert.
        
        Passing -1 as is to QComboBox::insertItem results in
        the new entry to be inserted at position 0 instead,
        i.e. as the first instead of as the last entry.
        
        (Seen in a WIP branch adding support for the
        "Font Features" dialog.)
        
        Change-Id: Ia0c88449ed938d9ccb25bfefabd7f5aa742eed28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184039
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [3555c488c6c893dc0ff184a3753e0a3e7f614ec1]

        tdf#130857 qt weld: Evaluate "inconsistent" prop for checkbuttons
        
        For check boxes/buttons, evaluate the
        GtkToggleButton::inconsistent [1] property when
        processing the .ui file and set corresponding
        QCheckBox properties when true.
        
        This is used e.g. in cui/uiconfig/ui/fontfragment.ui
        which is used in the "Font Features" dialog (which is
        not yet supported by QtInstanceBuilder, but this
        commit prepares for it).
        
        [1] https://docs.gtk.org/gtk3/property.ToggleButton.inconsistent.html
        
        Change-Id: If9a2aaee64998f0fe41c93ca42e4108ff46733d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184038
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [2e79f370ee462e411d3c0d87b058760c5c6fe624]

        cui: Resave fontfragment.ui with glade 3.40
        
        This .ui file is used within the "Font Features" dialog
        that can e.g. be triggered from Writer using
        "Format" -> "Character", then click the "Features" button
        in the "Character" dialog.
        
        Change-Id: I076bdad8c9fff2d597526e0dac57d22c1eb57c8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184037
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [e481fefbf612fc16f6a533d1253243108df78b72]

        tdf#130857 qt weld: Make scroll area child resizable
        
        As the QScrollArea doc [1] says:
        
        > The child widget must be specified with setWidget().
        
        This was implemented in
        
            commit 89b00d3e34c93b4ea0701a321a3cecf57aa0e378
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Dec 14 19:45:51 2024 +0100
        
                tdf#130857 qt weld: Drop scroll area parent if redundant
        
        However, that commit had the side-effect that
        the info text inside the scroll area in the
        "View" -> "User Interface" dialog was no longer
        completely displayed, but looked cropped.
        
        This is because the label still had the size needed
        to display only the initial "Information:" text
        specified in the .ui file
        (cui/uiconfig/ui/toolbarmodedialog.ui), not the
        longer text set later.
        
        Make the widget resizable by calling
        QScrollArea::setWidgetResizable [2]
        after creating the scroll area.
        
        This makes the auto-resize of the label
        work so that the full text is displayed
        again as expected.
        
        [1] https://doc.qt.io/qt-6/qscrollarea.html
        [2] https://doc.qt.io/qt-6/qscrollarea.html#widgetResizable-prop
        
        Change-Id: I2fada7b5e2037d6631006dcabd0ce08dfff27795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184033
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [51d9b37032c1054f873d5378f08ffd09b5c44bcf]

        tdf#130857 Define widgets in Math's "Spacing" dlg in order
        
        Switch the order in which the widgets in the .ui file inside
        the "grid2" are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        The dialog can be triggered in Math via "Format" -> "Spacing".
        
        Change-Id: I00c4e4bc93bc398f2f8752a9ff5d62ebe4caf8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184027
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [6020bbda165b244fac628fa499a8e3bf8f7f0d8b]

        tdf#130857 math: Ensure focus handler in "Spacing" dlg gets called
        
        As mentioned for Math's "Format" -> "Spacing" dialog in
        previous commit
        
            Change-Id: I3018c5a76cd863332ac8560a926105ae76327a38
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 11 10:31:09 2025 +0200
        
                tdf#130857 qt weld: Support Math's "Spacing" dialog
        
        for the case of using native widgets with the qt6 VCL plugin:
        
        > Currently, the image isn't always updated when choosing
        > a different category via "Category" menu button. This
        > will be addressed in a separate commit.
        
        For some reason (not further analyzed so far), no
        QApplication::focusChanged signal gets emitted (that would then
        trigger the slot in QtInstanceWidget::applicationFocusChanged)
        for the following scenario:
        
        * start Math with the qt6 VCL plugin and environment variable
          SAL_VCL_QT_USE_WELDED_WIDGETS=1 set
        * open the "Format" -> "Spacing" dialog
        * while the focus is still on the "Spacing" spinbox, click the
          "Category" menu button and select another category, e.g. "Operators"
        
        The problem cannot be observed when first moving focus away
        from the "Spacing" spinbox.
        
        To make sure the image gets updated, explicitly call
        the SmDistanceDialog::SetCategory
        Call the `GetFocusHdl` handler in SmDistanceDialog::SetCategory
        after setting focus to the spinbutton which makes this work
        for the case of using native widgets with qt6 as well.
        
        Change-Id: Ia4a1389a014f22c9c1665093321b231838ad1215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184026
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [be0d872afc8a1b7dd9d740893f9bc1b5ed94f45f]

        tdf#130857 qt weld: Support Math's "Spacing" dialog
        
        Declare support for Math's "Format" -> "Spacing"
        dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog makes use of the GtkRadioMenuItem support
        added in previous commit
        
            Change-Id: I2c9e8d2ecbef4b09a95bfb2f8057e714b984a329
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 11 10:24:33 2025 +0200
        
                tdf#130857 qt weld: Support "GtkRadioMenuItem"
        
        Currently, the image isn't always updated when choosing
        a different category via "Category" menu button. This
        will be addressed in a separate commit.
        
        Change-Id: I3018c5a76cd863332ac8560a926105ae76327a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184025
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [5492c9bfa51ab45b936c6191066640608384c0e1]

        tdf#130857 qt weld: Support "GtkRadioMenuItem"
        
        Implement support for GtkRadioMenuItem [1] menu items
        in .ui files.
        
        Reuse the logic implemented for "GtkMenuItem". In addition,
        support the "group" property which specifies what radio button
        group the item belongs to.
        For GTK, this is the ID of another GtkRadioMenuItem object.
        For Qt, use a QActionGroup. Let it be owned by the QMenu
        that  the menu items belong to, so it is deleted together with
        the menu.
        
        (The Qt concept of QActionGroup is basically the same as
        QButtonGroup for radio buttons, see also
        QtBuilder::setRadioButtonGroup.)
        
        From a quick test, VclBuilder doesn't seem to evaluate the
        "group" property, but seems to use some logic that simply
        considers adjacent radio menu items as part of the same group.
        
        This will be used by Math's "Format" -> "Spacing" dialog,
        for which support will be declared in an upcoming commit.
        
        [1] https://docs.gtk.org/gtk3/class.RadioMenuItem.html
        [2] https://docs.gtk.org/gtk3/property.RadioMenuItem.group.html
        
        Change-Id: Id0eece0eef65b8c52f77996c67662584f5665726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184024
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [e61975fac8148c667374d815fb376a273f304d24]

        tdf#130857 vcl: Extract BuilderBase::extractGroup helper
        
        This will allow to reuse the existing logic
        to also process the "group" property for
        GtkRadioMenuItem objects [1] in an upcoming commit
        for QtBuilder.
        
        [1] https://docs.gtk.org/gtk3/property.RadioMenuItem.group.html
        
        Change-Id: Ib0b545132dffedc5c33b34ff37d39473c6797343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184023
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f5702d1f27d72e5f70715b04f58b7c76bb1f7915]

        tdf#163821 - sc fix XLOOKUP does not work correctly if the search
        
        array and result array are each entered as an array with curly brackets
        
        In case of the result array is a matrix we need to push them as values
        instead of SingleRef-s, same as what we are doing in case of results with multiple rows or columns.
        
        Also fix tdf#164004 - XLOOKUP across files does not work correctly
        
        Change-Id: Idd1d01a99b33d06ac21bc896279971ac4a805550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183973
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-04-11  Miklos Vajna  <vmiklos@collabora.com>  [b595dff0bf2fcdb63586e36d007408cf23359a65]

        tdf#166125 Revert "tdf#158532 sw: fix toolbar buttons remain disabled ...
        
        ... after pasting an image"
        
        This reverts commit a586ce188086ff27b08b8a4de4672c07ddf8ed7c (tdf#158532
        sw: fix toolbar buttons remain disabled after pasting an image,
        2024-01-03). The original problem is not reproducible anymore and it
        causes tdf#166125, so best to revert it.
        
        Change-Id: I7bee45da2835106915d4f9f7e6410725d6c854d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184054
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-11  Alain Romedenne  <alain.romedenne@libreoffice.org>  [dd8d790df1233fe4d1972bc78d3c5435ddd1e0fd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49f57fc09c3b94850708dcaeb31b81d164e77229
          - multiple omissions/bugs in Python help
            
            Change-Id: I92603f09f832d11720112b129445a74c2f2d63ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/184055
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-04-11  Bayram Çiçek  <bayram.cicek@collabora.com>  [29c7e73d132154ef7e83b15f6ff39938fb927fe5]

        sw: always export enforcement attribute of documentProtection
        
        otherwise: (in word/settings.xml)
        - if a docx document has w:enforcement="0", LO will not
        import it. Hence, LO will not export it, too.
        - this will cause a lack of enforcement attr. - which
        will make the docx "protected" after export from LO - in MSO Word.
        
        Therefore, we have to import enforcement attr. even if it's
        value is "0".
        
        Change-Id: I30cf3cd8725151ea5bd9d4e484757e36602707e5
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184042
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a3415dcf310b9dc7de5b193ff2c020fceb45a0e9]

        Simplify SwReaderWriterEntry::GetReader/GetWriter a bit
        
        Change-Id: Ie356bc3a6ffc94834e27e15935b3a9b53b8be410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184036
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6b10b00d7d4d877d98c92ae81c9482fd76486a85]

        fix msi generation on native windows/aarch64
        
        msidb and other tools from the arm directory are incompatible, so it
        needs the intel ones instead
        
        Change-Id: I9029ab3c78708ec5e2b81085597c67ff10ffc188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184032
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-04-11  Heiko Tietze  <tietze.heiko@gmail.com>  [0110cff15c3befb2021b7e18d21f538254c66103]

        Resolves tdf#101625 & tdf#137298 - Make Edit button functional
        
        Hide the button unless it makes sense to show some dialog. It either
        opens the user or the document properties now.
        
        Change-Id: I3b6fe600e6ddb725cfc638bf69cdddd290c2b810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183919
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-04-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a19a4fb601b82a619f258bb91c5110f39850a221]

        Fix typo
        
        Change-Id: I987de2ab896e334afd7eb73c70a2a0d20e474f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184021
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [abccccafbc54297f9c6d3c744ebdb4ac5c887ad7]

        Fix typo
        
        Change-Id: I52301bc1d82757102cc3c97072e88807d960c3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184022
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f99243d356fb3f472d0f2ed7c08c570036c3b30]

        fontconfig: upgrade to 2.16.2
        
        Downloaded from https://gitlab.freedesktop.org/api/v4/projects/890/packages/generic/fontconfig/2.16.2/fontconfig-2.16.2.tar.xz
        
        Change-Id: I7461d0aa8e4ea25c5b92066cd31bbcc609c390a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184020
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-11  Miklos Vajna  <vmiklos@collabora.com>  [ddc3cf99a47cb76e1386783df782e4852a19307a]

        cool#11592 sw lok: fix sometimes lost comments on load
        
        Load a document with the LOK API, execute
        getCommandValues(".uno:ViewAnnotations"), then listen for comment
        changes. If the document is complex enough, some comments won't be
        included anyhwere: neither in the initial comment list, nor as a
        notification later.
        
        What happens is that SwXTextDocument::getPostIts() iterates over the
        postits of the postit manager, but in case the comment is not yet laid
        out (pWin is nullptr), then we just ignore that comment when creating
        the initial comment list. But then SwPostItMgr::LayoutPostIts() won't
        emit notifications about these comments, either -- assuming these
        comments are not new. So if the LOK client is fast enough to execute
        getCommandValues() and the core is slow enough with the layout of the
        comments, then some initial comments in the documents are lost (they are
        in the document, but they are not visible).
        
        Fix the problem by extending SwPostItMgr::GetOrCreateAnnotationWindow()
        to give info when it created the annotation window, and then in
        SwPostItMgr::LayoutPostIts() notify about both freshly laid out comments
        and about explicitly inserted comments.
        
        Adding a bit of debug output confirms that now comments show up even if
        we hit the unlucky "no annotation window yet" case when testing
        manually:
        	debug:31555:31497: SwXTextDocument::getPostIts: pWin is 0
        	debug:31555:31497: SwPostItMgr::LayoutPostIts: lok notify, type is add
        The first is the state right after load, the second is called by
        SwPostItMgr::CalcHdl() as a user event ("on idle");
        
        Change-Id: I32082d0014454bd492d2ae87fea42e28b639e8e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184014
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [11ff20073b63443fe31d470fc7e6fef0e8019bf7]

        crashtesting: out of bounds in export of forum-mso-en4-596154.xlsx to xlsx
        
        and others, e.g.
        
        forum-mso-en4-596019.xlsx
        forum-mso-en4-596112.xlsx
        
        probably a problem since:
        
        commit 612891865a74777950ab7355a4d794fa5577c5fc
        CommitDate: Thu Mar 20 16:49:11 2025 +0100
        
            tdf#165670 PPTX export: fix glue points export regression
        
        Change-Id: I12af1095115eeca8a8483d5895b716e1a8cc64fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184013
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a48bb5c25bf05b9e26658bd49f43dfa75d4136ba]

        Remove obsolete fw declarations from canvas/ codemaker/ configmgr/
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ife87bf89617d97cee9dd1f25d6e912665e4c33a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183879
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-04-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [530e3ae32001ae980431b774d5747f16a304a914]

        Remove obsolete fw declarations from avmedia, basctl, basic, binaryurp
        
        found with bin/find-unneeded-includes --fwdecl
        
        Change-Id: Ia9eb16d95b02b5e8c13a98b6cc4b06a6315f2311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183878
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [6c152f0934e23410dcd5a61dfff0800baf3eff17]

        comphelper a11y: Drop extra indentation level
        
        Change-Id: I5e53e5d12d6f069d9e53b8247e4d39eeeada0a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184004
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [09f70c8109f8091ca61ab7a0a7283c2a69b1a4d5]

        svx a11y: Drop SvxGraphCtrlAccessibleContext::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        already implements the same logic.
        
        Change-Id: I90abb7a5507644d7ca1f421dbea995050556c1b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184003
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [2594caeda1d63c77ee7e448c0d5c51e9a1ffb3b4]

        svx a11y: Slightly rearrange AccessibleShape::getAccessibleIndexInParent
        
        Return early and drop local var `nIndex`.
        Drop comment about this being "simple but slow",
        as simply returning the index if set is fast,
        and the rest of the comment would thus not refer
        to the implementation here, but in the base class.
        
        Change-Id: Id855a8abd9f6de98d4fda59dc10d65228cb610eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184002
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [1a37558fb2f68f92a464b3c7c0e6fa8e21c6282e]

        svtools a11y: Drop SvtRulerAccessible::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        implements the same logic.
        
        Change-Id: I92958cc3186cabd2e302cf03a297c07bbd65f1b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184001
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [332fb61097f56d797027b9546629c13b8d7214be]

        editeng a11y: Drop AccessibleContextBase::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        already implements the same logic.
        
        Change-Id: I4bd338632c4e440a54470f1294a9e67a0ccb866d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184000
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-11  Weblate  <noreply@documentfoundation.org>  [c38a7db4c8d3848dfc7306f695786a539f974677]

        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I8eb81db4571666e86dfac665fd082baaaa23704b
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I370de79d9016ec8f0be7d292d1e9abc4313fb2f9
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I05b62988c74079f6fbdcd5f9814484b9085ef19a
        
        android-viewer translated using Weblate
        
        Romanian currently translated at 2.5% (3 of 116 strings)
        
        Change-Id: Ie4e439529b016aa3de7e30af632aa51e55231e51
        
        Update translation files for android-viewer
        
        Updated by "Remove blank strings" hook in Weblate.
        
        Change-Id: I768a3ce6dcd914d5dcf9f3e6691badcb05413c53
        
        android-viewer translated using Weblate
        
        Romanian currently translated at 1.7% (2 of 116 strings)
        
        Change-Id: Ic4b65e62594f6228710cf9b483d1feddf13f8bff
        
        android-viewer translated using Weblate
        
        Afrikaans currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ia8ac96ef22f1ba75238734b17833d515ba94132b
        
        android-viewer translated using Weblate
        
        Tagalog currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I3a3b0c3765542509e1a8e4829d42ede0211df01f
        
        android-viewer translated using Weblate
        
        Georgian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ib9d9af42b5d1826255e522125a8f7f2af0d6127b
        
        android-viewer translated using Weblate
        
        Hebrew currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I55fba0974ace39f116824dc599d7805b387d8977
        
        android-viewer translated using Weblate
        
        Esperanto currently translated at 0.0% (0 of 116 strings)
        
        Change-Id: I3d403b1e830248e30573956c0c44e1538f2b5ee1
        
        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: I4fd57416ecf460e45651fc73efef736d1431d318
        
        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: If057d610b14188ae0db7f3d20a5a914c56b81b0f
        
        android-viewer translated using Weblate
        
        Slovak currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ia913e5f4627a89904c77643382bfdf006c8e70b7
        
        android-viewer translated using Weblate
        
        Abkhazian currently translated at 0.0% (0 of 116 strings)
        
        Change-Id: I239da92abf3a1ddbf5f788fd869b6682d20809c7
        
        android-viewer translated using Weblate
        
        Portuguese currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I7d9b6b6a8e83a20571d7b2e35edd0f484065192a
        
        android-viewer translated using Weblate
        
        Hungarian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I216c938054bf5b5a62bc463599402b2e4f7d4508
        
        android-viewer translated using Weblate
        
        Indonesian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I540e30365ad7c6d46560ca75f2124b063b5f506a
        
        android-viewer translated using Weblate
        
        Nepali currently translated at 17.2% (20 of 116 strings)
        
        Change-Id: I7f628a7f40979983d2ad3594fa2166dc8e90f158
        
        android-viewer translated using Weblate
        
        Greek currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ie670518955161245eef8f6f745b78e04e277d23b
        
        android-viewer translated using Weblate
        
        Ukrainian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I7a82e827afbfa19189c7b18c59447bba64e7cc87
        
        android-viewer translated using Weblate
        
        Lower Sorbian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I616b44866cfbe0715face315d2191fb9db38caa1
        
        android-viewer translated using Weblate
        
        Upper Sorbian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I1dc905bb16c4446a1716adfbfca982f4d3276e92
        
        android-viewer translated using Weblate
        
        Dutch currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I2e47958f5cb7e1bc9e66335a0a7b5b877ff06f17
        
        android-viewer translated using Weblate
        
        Dutch currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ib1bb2f5fbe18bc840ea8cb615129d609f81e1bed
        
        android-viewer translated using Weblate
        
        Icelandic currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I49f0c7513a29237aa764a76568104f29fd192f55
        
        android-viewer translated using Weblate
        
        Italian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I115c77a50a911cb7ecb9cba942b14cc7701543b7
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Id6e6b4ab3b318e182b45f996421c954725d6860b
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I994e707dfb5146546332a3b7027aedf07cc186b5
        
        android-viewer translated using Weblate
        
        Czech currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I24f909c87b5c60ce65036064f39119ba8ef16e1a
        
        android-viewer translated using Weblate
        
        Slovenian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I9d5b6dd53f912b498d291e386bb7ea82d3ff8c74
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 83.6% (97 of 116 strings)
        
        Change-Id: Id84aca3465b0cfd47d3b973e57317447be10228d
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 83.6% (97 of 116 strings)
        
        Change-Id: Ied50226ceadc2e5f0ea25d68e902e39715582390
        
        android-viewer translated using Weblate
        
        Chinese (Traditional Han script) currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Iedcab7dd5ec2860d4652e7b8bbea69d7b9e77dc1
        
        android-viewer translated using Weblate
        
        Finnish currently translated at 0.0% (0 of 116 strings)
        
        Change-Id: I7bff03aa120b862a96d30d15e3ca88c5ac6b5508
        
        android-viewer translated using Weblate
        
        Basque currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I2f90a91002ceb47798951f692598912c7b3e2870
        
        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ib6948225c9bd2b49b54780e28b7006b4b7e08cef
        
        android-viewer translated using Weblate
        
        Persian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I4cf681d3fc334245d8eb5831eb55438a40d805d8
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ic7b2cab3e08137e3ed31d214b0dd8cecf8e02af1
        
        android-viewer translated using Weblate
        
        French currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ida71234c709a03e85a7ee06c19d496642194fd3c
        
        android-viewer translated using Weblate
        
        Punjabi currently translated at 95.6% (111 of 116 strings)
        
        Change-Id: I941848df77f885572c8aa03774c4aba655256d2a
        
        android-viewer translated using Weblate
        
        Punjabi currently translated at 95.6% (111 of 116 strings)
        
        Change-Id: I4778b279c99c6958ef94bd6f62f619f2de560945
        
        android-viewer translated using Weblate
        
        Kazakh currently translated at 0.0% (0 of 116 strings)
        
        Change-Id: Icd73da37f57b52b229098a6292479b3c7138e19f
        
        android-viewer translated using Weblate
        
        Welsh currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I5486455397fa466868c03db5c9284ff9e8c2bbd2
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I6e113abdc3eef5137987d15c94f0fd167fb15ec9
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I104c22a23bb49788a1f801aa55d6e592222d57e5
        
        android-viewer translated using Weblate
        
        Spanish currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I4fd24e5f966c747043c3a83e185b2d62f467813b
        
        android-viewer translated using Weblate
        
        Galician currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ie572b7d48cb3221fbbc95bf939a0f013a81f6886
        
        android-viewer translated using Weblate
        
        Armenian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I44e44f2fd60e58af8e1ff7215710c4b4b47e62b2
        
        android-viewer translated using Weblate
        
        Turkish currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ic87d85a9269e8293d92c1c5272910a0536ac978b
        
        android-viewer translated using Weblate
        
        German currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ie7bf6ddd67fc69793cf9ed1ce2b00a84114e6c8b
        
        android-viewer translated using Weblate
        
        German currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I1ea4c5c81e172c42938c51ffb875390052ea210d
        Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
        Co-authored-by: Adam Rak <kitynska@gmail.com>
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Co-authored-by: Aitor Salaberria <amento@ni.eus>
        Co-authored-by: Andika Triwidada <andika@gmail.com>
        Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com>
        Co-authored-by: Anonymous <noreply@weblate.org>
        Co-authored-by: Cheng-Chia Tseng <pswo10680@gmail.com>
        Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com>
        Co-authored-by: Dimitris Spingos <dmtrs32@gmail.com>
        Co-authored-by: Ekaterine Papava <papava.e@gtu.ge>
        Co-authored-by: Elisabetta Manuele <lyzbetta@gmail.com>
        Co-authored-by: Gábor Kelemen <gabor.kelemen.extern@allotropia.de>
        Co-authored-by: Hossein <hossein@libreoffice.org>
        Co-authored-by: Joan Montané <joan@montane.cat>
        Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
        Co-authored-by: Michael Wolf <milupo@sorbzilla.de>
        Co-authored-by: Miloiu Andrei <miloiuandrei@gmail.com>
        Co-authored-by: Miloš Šrámek <msramek22@gmail.com>
        Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Co-authored-by: Paul Roos <iNetRoos@gmail.com>
        Co-authored-by: Rhoslyn Prys <post@meddal.com>
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Co-authored-by: Sveinn í Felli <sv1@fellsnet.is>
        Co-authored-by: Sérgio Marques <smarquespt@gmail.com>
        Co-authored-by: Taichi Haradaguchi <aaaa@users.noreply.translations.documentfoundation.org>
        Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Xandru Martino Ruz <xandrumartino@softastur.org>
        Co-authored-by: Xosé <xosecalvo@gmail.com>
        Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
        Co-authored-by: emism <softinterlingua@gmail.com>
        Co-authored-by: kees538 <kees538@gmail.com>
        Co-authored-by: sophie <gautier.sophie@gmail.com>
        Co-authored-by: vpanter <Leo.Moons@proximus.be>
        Co-authored-by: Євген Кондратюк <lachend@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ab/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/af/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/dsb/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/el/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eo/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/es/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fi/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hsb/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hu/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/id/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/is/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ka/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/kk/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/nl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sk/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/uk/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/zh_Hant/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183799
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-11  Jaume Pujantell  <jaume.pujantell@collabora.com>  [1dacb5512b23bd804bbbfc184755512c80a8c4fa]

        tdf#166126 sw: docx: add annotationRef on comments
        
        Right now we never add <w:annotationRef/> to any comment when saving to
        docx. According to the standard, not having it is the same as having it
        in the beginning. But when round-tripping a document with multiple
        comments without text from MS Word, the comments get mangled if the
        annotationRef tags aren't kept. So it's better to always write the
        implicit annotationRef at the beginning of comments.
        
        Change-Id: I6c395bbc691a29533e2be9a93663993e083db65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183856
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183975
        Tested-by: Jenkins

2025-04-11  Noel Grandin  <noelgrandin@gmail.com>  [76d296f7600bddf0b52fe2bd5522594551f10218]

        fold ChartModelHelper functions into ChartModel
        
        This moves functions from ChartModelHelper to ChartModel
        where it better belongs to. We can access the concrete classes now
        instead of accessing through UNO si this is possible to do.
        
        Change-Id: I21dce8aabe8f8a956863beef7ca5cb4ec6f3b44b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183990
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-11  Noel Grandin  <noelgrandin@gmail.com>  [6a75480ce4a7fe32ebfcf5039de3020d734652c8]

        remove dead code in ChartModelHelper
        
        the new ChartModel class does not implement the older chart::XChartDocument
        interface.
        
        Change-Id: I952a870e6c7b592851d30bb0b55de3c5fb41f428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183989
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fe4142000435f2e4c5b8ae77f44c495cb0ae3e47]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eeb6c27c4dd07cb9ea7c843ec278e3385d64ed97
          - tdf#143183 Update BASIC format codes
            
            + Added hidden formats
            + refactor for easier reading
            
            Change-Id: I25fcebe7530b4c4a78d30371bedecefd0beb7d89
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183974
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [83bbcc139943c32575f18f8d18563502cad31729]

        svx a11y: Drop SvxGraphCtrlAccessibleContext::CommitChange
        
        Use the base class method
        OAccessibleComponentHelper::NotifyAccessibleEvent
        directly instead, for which old and new value need to
        be passed in reverse order.
        
        Also just pass an empty/default-constructed uno::Any
        instead of an empty XAccessible reference in
        SvxGraphCtrlAccessibleContext::getAccessible.
        
        Change-Id: Ida49b0359ab3f3316f710e0c9383f16d5ccafc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183985
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [f4f99ef3de1b78c19a7d1290b9b04fa18a785aef]

        editeng a11y: Drop unused forward-decl
        
        Change-Id: Ic6830053ef281e24e4e358209b87935ad5a3ffbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183984
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [273acb10424e56dd2b0b21f30b28a63fc73953ba]

        sd a11y: Drop unnecessary XAccessibleEventListener inheritance
        
        There's no reason for sd::slidesorter::controller::Listener
        to implement the XAccessibleEventListener interface and
        its XAccessibleEventListener::notifyEvent does nothing.
        
        Therefore, drop the inheritance.
        
        Change-Id: Ibe4379514daa4910c26ea42d607afe1d67f1fa6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183983
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [99ece4e8018dd018aef79046aa465aa79c0a35e2]

        a11y: Drop unused includes
        
        Change-Id: Ib0e4fe99d35c7b5735dc6cbe61705588ee8c84b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183982
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [fcd88d5ceb98b201825b1ec15fe2add1911c8b90]

        editeng a11y: Drop AccessibleContextBase::ThrowIfDisposed
        
        Use the equivalent base class method
        OAccessibleComponentHelper::ensureAlive instead.
        
        Change-Id: I17a87b743d2a7b324cd4ae04cb1b924c676f0195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183979
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [b5d4af2a7281df001fda8f3aed187b1e4fc10b72]

        editeng a11y: Inline AccessibleContextBase::FireEvent to only caller
        
        Change-Id: Ia7ca4b39dc0917b05326e747820688eeb6c45343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183978
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [b37631e6ddd0f92ce07ac2ab4d4ba642f758f180]

        sc a11y: Drop ScAccessibleContextBase::getAccessibleIndexInParent
        
        The base class implementation in
        OAccessibleComponentHelper::getAccessibleIndexInParent
        is using the same approach already - and has the benefit
        of returning early when the child is found instead of
        continuing to iterate over all of the parent's children.
        
        Change-Id: I9ff67770bb4162c2c903a84b0393739a451d3893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183942
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [c3de6327f0552e577aacab34d127ea86fdf0b85d]

        sc a11y: Flatten ScAccessiblePreviewTable::getAccessibleAtPoint
        
        Change-Id: I2bdbad8212fd8fd377f2616a7e322b5696171de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183941
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [b0b37f0d98bf6f4bac90de6b0b588fd732209840]

        sc a11y: Drop ScAccessibleContextBase::IsObjectValid
        
        Use the equivalent base class method
        OAccessibleComponentHelper::ensureAlive instead.
        
        Change-Id: I27fd4ace99ffac9451e4dab76cba19a2a39f37ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183940
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [1b7912eee3e2fbf68ab8d0a4ac5b8b908776bcea]

        sc a11y: Drop obsolete commented code
        
        Commented since
        
            commit 95b1fd019e01babaa6dfc3526a6ed958fe4765f3
            Author: Sascha Ballach <sab@openoffice.org>
            Date:   Thu Jun 13 11:26:31 2002 +0000
        
                #99751#; some little fixes
        
        with the comment that his is not necessary, so just drop it
        altogether.
        
        Change-Id: Id4559db3a9fcae561b86e1b67809cfbfaf9ef6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183939
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [564f62e56e065a36628d9ac3a73c3b4749b034dd]

        sc a11y: Use OAccessibleComponentHelper
        
        Let ScAccessibleContextBase derive from
        OAccessibleComponentHelper to make use of the
        logic already implemented there instead of having to
        implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        The existing ScAccessibleContextBase::GetBoundingBox provides
        necessary logic to implement OAccessibleComponentHelper::implGetBounds,
        so simply call it.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the base class.
        
        No change in behavior intended or observed in a quick
        test with Calc using Orca and Accerciser with the gtk3
        and qt6 VCL plugins on Linux.
        
        Change-Id: I3d6db0e8c3b7c165dbbf9399e9b7c5b789cbfac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183938
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [79a8c883a5791e2b3a99472e0fa1db3a68a1c789]

        sc a11y: Dispose children in ScAccessibleDocumentPagePreview::disposing
        
        ScAccessibleDocumentPagePreview is their parent
        and owns them, so is responsible for disposing
        them again.
        
        See also commit message of
        
            Change-Id: I867ed2203d824bcffe86eb320cc3c009c265f4b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 10 13:12:56 2025 +0200
        
                sc a11y: No longer listen to parent disposal
        
        for some potentially relevant background.
        
        Change-Id: Ida4520a59c472d9f20c0e2df3fd61e37a0df0515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183972
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [d2a4d90c670f4ae453e652429c5502f229bb0edb]

        sc a11y: No longer listen to parent disposal
        
        Commit
        
            commit 8e886993f32b7db11a99bdecf06451e6de6c3842
            Date:   Sat Oct 7 11:42:40 2023 +0200
        
                tdf#157568 After deleting the content of a cell by pressing the delete..
        
                .. key, Orca still speaks the content.
        
                this reverts
                    commit f22cb3dfab413a2917cd810b8e1b8f644a016327
                    Author: Noel Grandin <noelgrandin@gmail.com>
                    Date:   Mon Jun 12 20:02:19 2023 +0200
                    tdf#155376 weakly cache ScAccessibleCell
        
                which was a nice idea, but means that we would need to have
                some way of updating the ScAccessibleCell when the associated
                cell data changes. Which is likely to be complicated.
        
                So return to creating new ScAccessibleCell objects all the time,
                but fix them to not leak.
        
                Change-Id: Ie17ee5c950c9809d4c7281f93761584f75256121
        
        split the XAccessibleEventListener logic from
        ScAccessibleContextBase into an inner helper class
        ScAccessibleContextBase::ScAccessibleContextBaseEventListener whose
        lifecycle is decoupled from its ScAccessibleContextBase
        object.
        As the code comment says:
        
            /**
             The listener is an internal class to prevent reference-counting cycles and therefore memory leaks.
            */
        
        Since that commit, the XAccessibleEventListener::disposing
        implementation however also no longer disposes the
        ScAccessibleContextBase object when being notified about
        the parent disposal, but only disposes the itself,
        which - if I understand correctly - doesn't seem to match the
        original purpose.
        
        This would be needed to dispose the ScAccessibleContextBase
        instead:
        
            diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
            index 99707cdd4517..1918b67b55b3 100644
            --- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
            +++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
            @@ -56,7 +56,7 @@ public:
                 {
                     SolarMutexGuard aGuard;
                     if (rSource.Source == mrBase.mxParent)
            -            dispose();
            +            mrBase.dispose();
                 }
        
                 virtual void SAL_CALL
            stash@{4}: WIP on master: 8ace7409d57f sw a11y: Pass shell by ref
        
        With pending Gerrit change [1] ("sc a11y: Use OAccessibleComponentHelper"),
        that separation of lifecycle also was seen triggering a crash for
        JunitTest_sc_unoapi_1 (s. backtrace below). At the point that
        ScAccessibleContextBase::ScAccessibleContextBaseEventListener::disposing
        gets called (frame #5), the ScAccessibleContextBase object (`mrBase`) has
        apparently already been deleted (when pending change [1] is applied).
        
        Drop the listener altogether.
        Instead, consider it the responsibility of the owner/parent to
        dispose its a11y children as needed, as it is done elsewhere.
        If that disposal is currently missing anywhere, it should be added
        separately. This change shouldn't have any effect in that regard due
        to the listener not disposing the ScAccessibleContextBase object any
        more anyway.
        (There is also existing logic to dispose the object
        in ScAccessibleContextBase::Notify and in the dtor,
        which remains unchanged.)
        
        Backtrace:
        
            Thread 1 (Thread 0x7eff157ff6c0 (LWP 330592)):
            #0  0x00007eff285bcc0c in com::sun::star::uno::BaseReference::iquery (pInterface=0x9999999999999999, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:59
                    aRet = <error reading variable: Cannot access memory at address 0x99999999999999a1>
            #1  0x00007eff286edc79 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::iquery (pInterface=0x9999999999999999) at include/com/sun/star/uno/Reference.hxx:74
            #2  0x00007eff28ae8254 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::Reference (this=0x7eff157fa2f8, pInterface=0x9999999999999999) at include/com/sun/star/uno/Reference.hxx:185
            #3  0x00007eff28ae817a in com::sun::star::uno::BaseReference::operator== (this=0x7eff157fa470, pInterface=0x9999999999999999) at include/com/sun/star/uno/Reference.hxx:426
                    x1 = uno::Reference to (ScAccessibleDocumentPagePreview *) 0x7eff08005ca0
                    x2 = uno::Reference to (com::sun::star::uno::XInterface *) 0x7eff289b62c8 <osl::Guard<comphelper::SolarMutex>::Guard(comphelper::SolarMutex&)+40>
            #4  0x00007eff28ae3ba0 in com::sun::star::uno::BaseReference::operator== (this=0x7eff157fa470, rRef=...) at include/com/sun/star/uno/Reference.hxx:462
            #5  0x00007eff291683b6 in ScAccessibleContextBase::ScAccessibleContextBaseEventListener::disposing (this=0x565180088c00, rSource=...) at /home/michi/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleContextBase.cxx:58
                    aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x56517ce99aa0}, <No data fields>}
            #6  0x00007eff7f4ea1b6 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear (this=0x7eff157fa4c8, rGuard=..., rEvt=...) at include/comphelper/interfacecontainer4.hxx:492
                    aIt = {rCont = @0x7eff157fa4c8, maData = {m_pimpl = 0x7eff08009e50}, nRemain = 0}
            #7  0x00007eff7f4e930e in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=3, _rxEventSource=uno::Reference to (ScAccessibleDocumentPagePreview *) 0x7eff08005ca0) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:204
                    aGuard = {_M_device = 0x7eff7f70e4f8 <(anonymous namespace)::GetLocalMutex()::MUTEX>, _M_owns = false}
                    aClientPos = invalid iterator
                    aListeners = {maData = {m_pimpl = 0x5651800f8950}}
                    aDisposalEvent = {Source = uno::Reference to (ScAccessibleDocumentPagePreview *) 0x7eff08005ca0}
            #8  0x00007eff7f4e5e8d in comphelper::OAccessibleComponentHelper::disposing (this=0x7eff08005ca0) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:61
                    aGuard = {pT = 0x56517ce99aa0}
            #9  0x00007eff29165d79 in ScAccessibleContextBase::disposing (this=0x7eff08005ca0) at /home/michi/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleContextBase.cxx:110
                    aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x56517ce99aa0}, <No data fields>}
                    xKeepAlive = uno::Reference to (ScAccessibleDocumentPagePreview *) 0x7eff08005cf0
            #10 0x00007eff291a2824 in ScAccessibleDocumentPagePreview::disposing (this=0x7eff08005ca0) at /home/michi/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx:1160
                    aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x56517ce99aa0}, <No data fields>}
            #11 0x00007eff7ef3dc40 in cppu::WeakComponentImplHelperBase::dispose (this=0x7eff08005ca0) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase.cxx:104
                    aEvt = {Source = uno::Reference to (ScAccessibleDocumentPagePreview *) 0x7eff08005ca0}
                    aGuard2 = {pT = 0x7eff157fa730}
                    aGuard = {pT = 0x0}
                    exc = <error reading variable: Cannot access memory at address 0x100000004>
            #12 0x00007eff29156eb5 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleExtendedComponent>::dispose (this=0x7eff08005ca0) at include/cppuhelper/compbase.hxx:90
            #13 0x00007eff29165f84 in ScAccessibleContextBase::Notify (this=0x7eff08005ca0, rHint=...) at /home/michi/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleContextBase.cxx:129
            #14 0x00007eff291a2f38 in ScAccessibleDocumentPagePreview::Notify (this=0x7eff08005ca0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx:1232
            #15 0x00007eff7c549b8c in SfxBroadcaster::Broadcast (this=0x7eff3400cf00, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
                    pListener = 0x7eff08005d28
                    i = 0
                    nSize = 5
            #16 0x00007eff29b546f6 in ScPreviewShell::BroadcastAccessibility (this=0x565180199c00, rHint=...) at /home/michi/development/git/libreoffice/sc/source/ui/view/prevwsh.cxx:1159
            #17 0x00007eff29b5451a in ScPreviewShell::~ScPreviewShell (this=0x565180199c00) at /home/michi/development/git/libreoffice/sc/source/ui/view/prevwsh.cxx:185
                    pDrawBC = 0x565180365360
            #18 0x00007eff29b54759 in ScPreviewShell::~ScPreviewShell (this=0x565180199c00) at /home/michi/development/git/libreoffice/sc/source/ui/view/prevwsh.cxx:180
            #19 0x00007eff7d62efff in SfxViewFrame::ReleaseObjectShell_Impl (this=0x7eff1c234340) at /home/michi/development/git/libreoffice/sfx2/source/view/viewfrm.cxx:1142
                    pDyingViewSh = 0x565180199c00
            #20 0x00007eff7d63626c in SfxViewFrame::~SfxViewFrame (this=0x7eff1c234340) at /home/michi/development/git/libreoffice/sfx2/source/view/viewfrm.cxx:2067
                    pSfxApp = 0x7eff1c232340
            #21 0x00007eff7d631832 in SfxViewFrame::Close (this=0x7eff1c234340) at /home/michi/development/git/libreoffice/sfx2/source/view/viewfrm.cxx:1194
            #22 0x00007eff7d5ba93c in SfxFrame::DoClose_Impl (this=0x7eff1c22dac0) at /home/michi/development/git/libreoffice/sfx2/source/view/frame.cxx:138
                    pBindings = 0x7eff1c22e0e0
            #23 0x00007eff7d60358a in SfxBaseController::dispose (this=0x565183247040) at /home/michi/development/git/libreoffice/sfx2/source/view/sfxbasecontroller.cxx:929
                    aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x56517ce99aa0}, <No data fields>}
                    xKeepAlive = uno::Reference to (ScPreviewObj *) 0x565183247068
                    aEventObject = {Source = uno::Reference to (ScPreviewObj *) 0x565183247040}
        
        [1] https://gerrit.libreoffice.org/c/core/+/183938/1
        
        Change-Id: I867ed2203d824bcffe86eb320cc3c009c265f4b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183971
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0459f9502a11e5d54a2a6ae1fb25e3bdd0cdc8e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2159c0c2f6fcef3d74be2fb609818e035b95ecb2
          - tdf#132784 Add reference to Calc Multithreading
            
            + refactor file to keem dialog order
            
            Change-Id: I8fdb955de71863e150173f2df305d0062f9c7593
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183857
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2233d2c20840e80e102ff6c389a8117e11e83f4c]

        Update git submodules
        
        * Update translations from branch 'master'
          to 57a6d3ccdfdd07671f0c05371bcecc7f2896d916
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I391b68e4277acae6afa72d075b0fa890e1cc8059
            
2025-04-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [65439ab2c4fc87e7cc115710a605e9f35dfb39d8]

        tdf#154858 - FILEOPEN PPTX: fix Radial gradient in shape imported as
        
        a Linear gradient
        
        XML_circle gradients should be always imported as GradientStyle_RADIAL.
        
        Regression from: 898e4ae1364e76af8be22183ac64d73b6a6d8d90
        
        Change-Id: I8166a2afd3dadce61c742eeb0a55a0c8a8b9ada6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183836
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-04-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [91fb11d1b2b817ff35faeeca62bd633a05f9d130]

        Atomically write line plus newline into $SAL_LOG_FILE
        
        At least on Windows, I see log files in the wild that have multiple lines from
        different threads combined into one.  This has apparently been broken by
        9f027559557cb132835d8a13cdc0281ad4e757ae "WNT: allow to set log level/path from
        file" switching to a use of std::endl, for unclear reasons.  (But, compared to
        the version preceding that, keep the
        
          s << '\n';
        
        after the ANDROID and sal_use_syslog branches, assuming those don't want a
        newline added anyway.)
        
        Change-Id: Ie68e015e594918d3480d05c741f83948f1c3d69e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183718
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-04-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ffb2a03dd4acd9451d91c9a912960b962bb881a9]

        libffi: upgrade to 3.4.8
        
        Downloaded https://github.com/libffi/libffi/releases/download/v3.4.8/libffi-3.4.8.tar.gz
        
        Change-Id: I465db1e6f8aae186efab48c8449118722a39f30e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183958
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-10  Jonathan Clark  <jonathan@libreoffice.org>  [756bcac94f122b0bed6f2835ec1170406e1b8606]

        tdf#139418 DOCX import: Fix generated genko yoshi grid layout issues
        
        This change includes fixes for three minor grid layout issues affecting
        correct display of generated genko yoshi manuscript documents.
        
        - Due to the way OOXML stores grid parameters, the default Asian font
          height must be known in order to correctly calculate the grid
          character pitch. This change fixes a regression from tdf#107359 which
          caused the OOXML importer to always use the hard-coded default
          character width in certain situations.
        
        - The fix for tdf#149089 caused a regression by also removing the grid
          kerning portions from vertical text, when it correctly should only
          have affected horizontal text.
        
        - For correct interop, the ADD_EXT_LEADING compatibility flag is now
          ignored for vertical text when the MS_WORD_COMP_GRID_METRICS
          compatibility flag is set.
        
        Change-Id: I5aaa245293932d64ff5c4dd4a3f45c4d8bc4a22e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183959
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-04-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1c3af8ed966aa03fd0fe789d87c0172b267489e]

        mariadb-connector-c: upgrade to 3.3.15
        
        Downloaded from https://dlm.mariadb.com/4234370/Connectors/c/connector-c-3.3.15/mariadb-connector-c-3.3.15-src.tar.gz
        
        Change-Id: I16af31402b7edac1842bc69aff88bd741c023f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183956
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [b997fd92359c00bb91fd3d25bf992c4b3cd82543]

        sc a11y: Deduplicate code for AccessibleEventObject creation
        
        Change ScAccessibleContextBase::CommitChange
        from taking a `const AccessibleEventObject&`
        param to taking the parameters needed to
        create an AccessibleEventObject instead and
        create that event in ScAccessibleContextBase::CommitChange
        instead of having all callers do that themselves.
        
        This also aligns this with
        OAccessibleComponentHelper::NotifyAccessibleEvent
        and therefore prepares for turning
        ScAccessibleContextBase into an OAccessibleComponentHelper
        subclass in an upcoming commit, to further deduplicate
        XAccessibleEventBroadcaster and XAccessibleComponent
        implementations.
        
        For most cases, the event being created should be
        unchanged, with few exceptions for cases that looked a
        bit suspicious:
        
        1) In ScAccessibleSpreadsheet::NotifyRefMode, a single
        event object was created and then reused multiple times,
        with just adjusting some of the members. While that
        is fine in general, the AccessibleEventObject::OldValue
        being set to the old/previous formula cell doesn't make
        sense for the AccessibleEventId::SELECTION_CHANGED_WITHIN
        and AccessibleEventId::SELECTION_CHANGED_ADD events, so
        it is no longer set there. (For other events, the
        doc in offapi/com/sun/star/accessibility/AccessibleEventId.idl
        also doesn't always document an `OldValue` to be set
        (or even says it should be empty), but at a quick glance,
        winaccessibility might still process it if set, so leave
        it in place for now.
        (This should potentially be revisited independently, not
        as part of a change like this that intends to not change
        behavior for end users.)
        
        2) In ScAccessibleSpreadsheet::Notify, pass an
        empty/default-constructed uno::Any for the OldValue
        of the AccessibleEventId::ACTIVE_DESCENDANT_CHANGED_NOFOCUS
        event instead of an emtpy reference. The only handler in
        AccDescendantManagerEventListener::HandleChildChangedNoFocusEvent
        handles both the same way.
        Similar for any events further down where the OldValue
        would still be set as it's not explicitly unset.
        
        No change in user-observable behavior was noticed in a quick test
        of Calc with Orca and Accerciser and the gtk3 and qt6 VCL plugins
        on Linux with this commit in place.
        
        Change-Id: Ida3264b0935f544d4ce787b71684af148e47f86b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183931
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-10  Noel Grandin  <noelgrandin@gmail.com>  [371ae67b37c6aebd5a7c2214a6285cd5abe9e6c8]

        tdf#162126 reduce allocation in hot path
        
        Change-Id: Ib4184d496dc07ea2a0790b9c5ecdd269f7c84cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183954
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-10  Michael Weghorn  <m.weghorn@posteo.de>  [8ace7409d57f9ba724ea569524da9899a08b739e]

        sw a11y: Pass shell by ref
        
        Pass the SwViewShell by const ref instead of pointer to
        SwAccessibleFrame::IsEditable and SwAccessibleFrame::IsOpaque.
        
        This makes clear that the param is non-null and allows to
        drop the corresponding `OSL_ENSURE`s inside the implementations.
        
        All callers are already checking for null.
        
        Change-Id: I7129febd9b8c20fef1b0772fe584ae46c9d65b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183946
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [862544b8bdc6b3e6b0b377a7e5271f3ad19ff9af]

        ofz: Use-of-uninitialized-value
        
        ==401==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0x57a9d414370c in ScInterpreter::ScOr() /src/libreoffice/sc/source/core/tool/interpr1.cxx:1461:9
        
        Uninitialized value was created by an allocation of 'fVal' in the stack frame
            #0 0x57a9d4142e74 in ScInterpreter::ScOr() /src/libreoffice/sc/source/core/tool/interpr1.cxx:1414:25
        
        ScValueIterator::GetThis can call ScFormulaCell::GetErrorOrValue
        
        and both follow a pattern of returning true if an error is found,
        leaving the fValue argument uninitialized.
        
        Fix this the same way as the very similar:
        
        commit 7f8b4e14d787ec648a3de69fd51dc90fcfc876d9
        CommitDate: Sun Feb 9 14:16:42 2014 +0100
        
            fix memcheck report about uninitialized fVal
        
        Change-Id: I638791972aa605b4472ec63f7cd89c1f7a8636c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183947
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7143e7acbcc4abf7abd39390601246bc016e2dd]

        no need to Erase() alpha layer twice
        
        Change-Id: If2a05302ffe8489823ca989144a5e6a8be51f6e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183936
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-09  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [47db8dfc39241a7444a7af73372368b9e13f5580]

        tdf#166075: sd: notes pane: enable sidebar list format button
        
        support slots FN_NUM_BULLET_ON & FN_NUM_NUMBERING_ON to properly
        report back whether or not numbering functionality is available in
        notes pane.
        
        Change-Id: I94fd395a328a45db3bc7c394b7473a22edf0c957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183943
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-04-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8815270721053233e32c8f4f6ad50f56b55b1469]

        tdf#165230 chart: fix multiplying row labels in innerdatatable
        
        We only need to handle category labels as multilevel labels.
        
        regression from: fa0a981af41a2606541eec1cb20a379a739691e0
        (DOCX chart import: fix missing complex categories)
        
        Change-Id: I0958d87f315ddbe5cf2721a75a969abb09f4dc34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183858
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7c46846ad1aeeca7e38eb0aada6dc99b5fb701e3]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I6969ecb1fda3ee4ff6861594cf46c8d3d5a0b9a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183887
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-09  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [3edd54cd912c739ecfdf166437db627fa03c1cc7]

        tdf#166068: support paste-special slot for notes pane
        
        start handling the paste special slot: supporting at least RICHTEXT,
        HTML, HTML_SIMPLE, EDITENGINE_ODF_TEXT_FLAT which should be trivial to
        handle for the notes area.
        
        Change-Id: If508e81f81b213d829efef59220196b18252dec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183917
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-04-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [af3f54e7b118149cf1a20403fd0f433e41f5c6b6]

        libgpg-error: upgrade to 1.53
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.53.tar.bz2
        
        Change-Id: I29b4d5a52bd16ebcc1d0d866d1485c5e32264f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183916
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-09  Pranam Lashkari  <lpranam@collabora.com>  [f2ed4a849375a6cd22b0335352cccb3b5f4ba732]

        uno: introduced command to copy slides
        
        problem:
        in online though kit process it was difficult to
        trigger the slidesorter clipboard to copy slides.
        Difficulty was caused by slidesorter using its
        own viewshell to copy and online triggering copy
        command on drawviewshell.
        It's more convenient to use a different command
        rather than jumping between viewshells in this case
        
        Change-Id: I347ad0044efa64a3e5dcd26aeb16fe5b8103bb12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183924
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-09  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [0c80b4440fe3c4a8f14be193136b0903f3b2cd28]

        lok: handle saveas as export
        
        SaveAs saves the document to a new path.
        In the jail, this is unhelpful, since
        we upload the document after saving
        from a specific path.
        
        Instead, we do SaveACopy, or export,
        which saves the given document as a
        copy, retaining the original path
        for subsequent saves.
        
        This fixes a serious issue where
        after hitting Ctrl+Shift+S, the
        document would no longer store any
        further changes (in fact, it was
        saving the changes to a different
        path, which was not used for
        uploading).
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I6ba72df6a0a908d181786c02cb7c060177cd0302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182071
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit fcf4dd4f09018874ad25a035815f46705db0740a)
        (cherry picked from commit 7bf674d926c22aa81a4d4404dd513a6d71c5b2ee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183923
        Tested-by: Jenkins

2025-04-09  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [4241af29fad1aba278286d7cbc0a2942eb189cc4]

        sc: filter: check for null Brush
        
        The likely cause of the this crash:
        /opt/collaboraoffice/program/libmergedlo.so(
        SvxBrushItem::GetGraphicObject(rtl::OUString const&) const+0x25)[0x7faf881f90e5]
        /opt/collaboraoffice/program/libmergedlo.so(
        SvxBrushItem::GetGraphic(rtl::OUString const&) const+0xd)[0x7faf881f964d]
        /opt/collaboraoffice/program/libscfiltlo.so(+0x1b1dbe)[0x7faf7a32fdbe]
        /opt/collaboraoffice/program/libscfiltlo.so(+0x107371)[0x7faf7a285371]
        
        This was fixed by identifying all the GetGraphic() calls
        on a pointer. This turned out to be the only unprotected
        one in sc/source/filter, where the stack shows.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I64175e838423dfeaa4f93762c4894a99236a2ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182073
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3e146b4c8dcc15bb12ef036162090a0301d6aadf)
        (cherry picked from commit 0d6eefe77ed1b1ac9798f3ad9a215892cce33409)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183922
        Tested-by: Jenkins

2025-04-09  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [52e6adcf470b0b186eaa8bb62c23a5d89648a266]

        chart2: protect against null chart objects in ReferenceSizeProvider
        
        The likely cause of this crash:
        
        /opt/collaboraoffice/program/../program/libchartcorelo.so(
        chart::ReferenceSizeProvider::getAutoResizeState(
            rtl::Reference<chart::ChartModel> const&)+0x87)[0x7f98773>
        /opt/collaboraoffice/program/../program/libchartcorelo.so(
        chart::ReferenceSizeProvider::ReferenceSizeProvider(
            com::sun::star::awt::Size, rtl::Reference<chart::ChartModel> const&)+0x2c)[0x7>
        /opt/collaboraoffice/program/../program/libchartcontrollerlo.so(+0x1fc3ae)[0x7f98769e43ae]
        /opt/collaboraoffice/program/../program/libchartcontrollerlo.so(+0x1fd3b8)[0x7f98769e53b8]
        
        Although it's not entirely clear that, if the given chart
        is null, a subsequent access wouldn't seg-fault.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I16a39436c10adfca7f26e9304fd249efb0a53f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182072
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 9aa52c452596db522cd9db616d98b03fe87c74d0)
        (cherry picked from commit ca4e0b62bd814ff1d4f2e707ff658dd4a63cb728)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183921
        Tested-by: Jenkins

2025-04-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6686a02dbf43d1796b82a6f1135df2bbe31ece9c]

        vcl: move {Bitmap,Animation}Container to own files, createSwapInfo
        
        Move BitmapContainer and AnimationContainer into own files.
        
        Implement createSwapInfo for AnimationContiner and add needed
        functions for that.
        
        Change-Id: I723f4606a9a0cfa6627a5244de7f08c4d89387db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183866
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b5ac0a063101a5558d8421e26afd487b072e7a00]

        o3tl: simplify by using concepts in float_int_conversion.hxx
        
        Change-Id: If4373d11c469d476f74087461499b7a425309bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182713
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-09  Miklos Vajna  <vmiklos@collabora.com>  [fc69651f60d2d99df3c9295312a5caf17dbb46df]

        CppunitTest_sc_tiledrendering2, testDecimalSeparatorInfo: fix mismerge
        
        18e206907713768366cff5ee385eafdf26255980 (Add a test for decimal
        separator info., 2025-02-05) was OK, but then the version on master was
        mismerged, restore the lost test.
        
        Change-Id: I289cc228f6a429a0065310389c89a312bf413277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183918
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-09  Eike Rathke  <erack@redhat.com>  [fdb83b72726f2a343e9b8ff2c3131be793156f58]

        Resolves: tdf#166056 Add Gronings {gos-NL} locale data
        
        Co-authored-by: Tom Brand <tom9358@gmail.com>
        Change-Id: I04bdefe7569c7ef38e3cb3daa469e74977002a3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183816
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-04-09  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [543fea4c360b18cea0ccdd13f03f7a3fe05ae4bb]

        related tdf#166068: sd: make paste-special html paste into current textedit
        
        fix HTML paste-special option creating a new text object even if
        paste-special was used in a text-edit context. insert the text into the
        current text edit context instead of creating a seperate object.
        
        this is the current behavior for RTF & Flat XML Format paste options- so
        it is was a bug for html paste option.
        
        Change-Id: Ief9a19997a619b9f0b9c7855561de3f00de2df68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183913
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-04-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [285a94b8de111ac1caef8a8b7cbcd2774d9edfe2]

        fix warning C6011: Dereferencing NULL pointer 'pImpPrMap' (take 2)
        
        after
        commit 8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Sat Apr 5 22:03:18 2025 +0200
        
            tdf#151876 shave some time off chart load (2)
        
        Change-Id: I687d939813e50f78eec92e15ea8aa9606316ea1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183870
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [bd135e5f294ac58bda8007d1553202ae6f9b621f]

        find-unneeded-includes: work around iwyu bug seen in --fwdecl mode
        
        it suggests an empty string to remove, skip that
        so that find-unneeded-includes does not crash
        
        Change-Id: Iaee2d874094451cc0042f6b3f5007462d7f6b5e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183877
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e27a271a292bb620beabf16081cab33e5688cf9b]

        Fix typo
        
        Change-Id: I5ecb4c15b403d42ae61349d68d230c98ee593ef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183910
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [47792c96d1886a7c3a591183923e07fc496084c6]

        Fix typo
        
        Change-Id: I09253d42e291e2ad5d24bca4fa4a431fd0278828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183911
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [33c846e0aafd3cff2c90cebb6a88cbdfb8f1f9f6]

        Fix typo
        
        Change-Id: Ic2071614b1957cfee644c2ff4df71de6b3a41802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183912
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-09  Michael Weghorn  <m.weghorn@posteo.de>  [697405b533a8ae5b6a8f5bd184b9344a96f71c69]

        tdf#166055 qt avmedia: Provide media/player size right away
        
        There are 2 potential approaches for providing the
        preferred player size based on the media (which generally
        matches the the video resolution) in an XPlayer implementation:
        
        1) by implementing the css::media::XPlayerNotifier
           interface in addition and notifying listeners when the
           preferred player size is available, in which case
           XPlayer::getPreferredPlayerWindowSize doesn't need to
           return the proper size before then
        2) by not implementing that interface, but returning the
           correct value in XPlayer::getPreferredPlayerWindowSize
           right from the start.
        
        (See MediaWindow::isMediaURL and MediaWindow::grabFrame for
        how both approaches are supported there.)
        
        So far, QtPlayer was implementing approach 1), i.e. the
        css::media::XPlayerNotifier interface, like GtkPlayer does
        (by which the QtPlayer implementation was inspired, see
        
            commit 441d8ed9be0e7f831b455a69b8688dcb79a8bc00
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 20 16:25:09 2024 +0200
        
                tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback
        
        ), while all other XPlayer implementations don't do
        that.
        
        With the previous implementation, listeners would be
        notified when the QMediaPlayer::mediaStatus [1] transitioned
        to one of the states where the media has been loaded, i.e.
        the information on video resolution can reliably be retrieved.
        
        Given the current implementation of avmedia's PlayerWindow
        and the call to Scheduler::ProcessEventsToIdle (frame #12404 below)
        in avmedia::qt::QtFrameGrabber::grabFrame (frame #12405) in order
        to allow video playback to then be able to retrieve a video frame,
        the current implementation with signals/slots resulted in infinite
        recursion.
        
        Fix/avoid the problem by no longer implementing
        the XPlayerNotifier interface, but ensuring that
        the media is past the QMediaPlayer::LoadingMedia
        status in QtPlayer's XPlayer::getPreferredPlayerWindowSize
        implementation instead (by starting to play the media and then
        processing events until that's the case).
        
        (Running some of the logic in a separate thread came to mind as a
        potential alternative solution, but then some of the QtMultimedia library
        logic seems to expect to be run in the main thread. What would probably
        work as an alternative would be to run the logic to retrieve a video frame
        in a separate process/helper program instead, but that would also imply
        further overhead.)
        
        Sample backtrace of infinite recursion with the default ffmpeg
        QtMultimedia media backend prior to this commit with the qt6 VCL
        plugin on Wayland when inserting a video (not every time, but
        quite often):
        
            [...]
            #12353 0x00007fffeec62967 in Scheduler::ProcessEventsToIdle () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:435
            #12354 0x00007fffdd867acd in avmedia::qt::QtFrameGrabber::grabFrame (this=0x55555e3dd060, fMediaTime=3) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtFrameGrabber.cxx:103
            #12355 0x00007fffdd867bce in non-virtual thunk to avmedia::qt::QtFrameGrabber::grabFrame(double) () at /home/michi/development/git/libreoffice/instdir/program/../program/libavmediaqt6.so
            #12356 0x00007ffff0be5a43 in avmedia::MediaWindow::grabFrame (xPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8, rGraphic=empty uno::Reference)
                at /home/michi/development/git/libreoffice/avmedia/source/viewer/mediawindow.cxx:385
            #12357 0x00007ffff1c3282f in SdrMediaObj::getSnapshot() const::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const
                (this=0x555557523ca0, rPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8) at /home/michi/development/git/libreoffice/svx/source/svdraw/svdomedia.cxx:195
            #12358 0x00007ffff1c327ad in std::__invoke_impl<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(std::__invoke_other, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) (__f=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61
            #12359 0x00007ffff1c3275d in std::__invoke_r<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) (__fn=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111
            #12360 0x00007ffff1c325d5 in std::_Function_handler<void(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&), SdrMediaObj::getSnapshot() const::$_0>::_M_invoke
                (__functor=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290
            #12361 0x00007ffff0bebf96 in std::function<void(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&)>::operator() (this=0x55555e9ea148, __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591
            #12362 0x00007ffff0be8191 in avmedia::PlayerListener::callPlayerWindowSizeAvailable (this=0x55555e9ea100, rPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x7fffd4005ac8) at include/avmedia/mediawindow.hxx:74
            #12363 0x00007ffff0be676f in avmedia::PlayerListener::preferredPlayerWindowSizeAvailable (this=0x55555e9ea100) at /home/michi/development/git/libreoffice/avmedia/source/viewer/mediawindow.cxx:496
            #12364 0x00007fffdd8708f0 in avmedia::qt::QtPlayer::notifyListeners (this=0x7fffd4005a60) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtPlayer.cxx:386
            #12365 0x00007fffdd870718 in avmedia::qt::QtPlayer::notifyIfReady (this=0x7fffd4005a60) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtPlayer.cxx:324
            #12366 0x00007fffdd875636 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}::operator()() const (this=0x7fffffff7560) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #12367 0x00007fffdd8755b9 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}&&) (args=0x7fffffff7930, fn=...)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #12368 0x00007fffdd875583 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call
                (f=(void (avmedia::qt::QtPlayer::*)(class avmedia::qt::QtPlayer * const, enum QMediaPlayer::MediaStatus)) 0x7fffdd8706c0 <avmedia::qt::QtPlayer::notifyIfReady(QMediaPlayer::MediaStatus)>, o=0x7fffd4005a60, arg=0x7fffffff7930)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #12369 0x00007fffdd8754fd in QtPrivate::FunctionPointer<void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call<QtPrivate::List<QMediaPlayer::MediaStatus>, void>
                (f=(void (avmedia::qt::QtPlayer::*)(class avmedia::qt::QtPlayer * const, enum QMediaPlayer::MediaStatus)) 0x7fffdd8706c0 <avmedia::qt::QtPlayer::notifyIfReady(QMediaPlayer::MediaStatus)>, o=0x7fffd4005a60, arg=0x7fffffff7930)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #12370 0x00007fffdd875426 in QtPrivate::QCallableObject<void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), QtPrivate::List<QMediaPlayer::MediaStatus>, void>::impl
                (which=1, this_=0x55555ea5ce20, r=0x7fffd4005a60, a=0x7fffffff7930, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #12371 0x00007fffe51050d2 in QtPrivate::QSlotObjectBase::call (this=0x55555ea5ce20, r=0x7fffd4005a60, a=0x7fffffff7930) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #12372 0x00007fffe5328554 in doActivate<false> (sender=0x555567c57080, signal_index=5, argv=0x7fffffff7930) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #12373 0x00007fffe531e763 in QMetaObject::activate (sender=0x555567c57080, m=0x7fffe29e91f8 <QMediaPlayer::staticMetaObject>, local_signal_index=2, argv=0x7fffffff7930)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #12374 0x00007fffe272fbab in QMetaObject::activate<void, QMediaPlayer::MediaStatus>
                (sender=0x555567c57080, mo=0x7fffe29e91f8 <QMediaPlayer::staticMetaObject>, local_signal_index=2, ret=0x0, args=@0x7fffffff7974: QMediaPlayer::LoadedMedia) at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #12375 0x00007fffe272a7ed in QMediaPlayer::mediaStatusChanged (this=0x555567c57080, _t1=QMediaPlayer::LoadedMedia) at qtmultimedia/src/multimedia/Multimedia_autogen/include/moc_qmediaplayer.cpp:563
            #12376 0x00007fffe272a79c in QMediaPlayerPrivate::setStatus (this=0x55555eaa23c0, s=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/playback/qmediaplayer.cpp:118
            #12377 0x00007fffe271f553 in QPlatformMediaPlayer::mediaStatusChanged (this=0x7fffd4005300, status=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/platform/qplatformmediaplayer.cpp:32
            #12378 0x00007fffa28f0e5c in QFFmpegMediaPlayer::mediaStatusChanged (this=0x7fffd40052f0, status=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:131
            #12379 0x00007fffa28f1c0a in QFFmpegMediaPlayer::setMediaAsync (this=0x7fffd40052f0, mediaDataHolder=..., cancelToken=std::shared_ptr<QFFmpeg::CancelToken> (use count 3, weak count 0) = {...})
                at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:269
            #12380 0x00007fffa28f36de in QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}::operator()() const (this=0x7fff34001870)
                at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:211
            #12381 0x00007fffa28f3688 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}::operator()() const (this=0x7fffffff7d30) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:116
            #12382 0x00007fffa28f3669 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}&&)
                (args=0x7fff340c3048, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #12383 0x00007fffa28f3632 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**) (f=..., arg=0x7fff340c3048) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:115
            #12384 0x00007fffa28f35c1 in QtPrivate::FunctorCallable<QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call<QtPrivate::List<>, void>(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void*, void**) (f=..., arg=0x7fff340c3048) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:337
            #12385 0x00007fffa28f350d in QtPrivate::QCallableObject<QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x7fff34001860, r=0x7fffd40052f0, a=0x7fff340c3048, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:547
            #12386 0x00007fffe51050d2 in QtPrivate::QSlotObjectBase::call (this=0x7fff34001860, r=0x7fffd40052f0, a=0x7fff340c3048) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #12387 0x00007fffe5312adc in QMetaCallEvent::placeMetaCall (this=0x7fff340c3000, object=0x7fffd40052f0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:620
            #12388 0x00007fffe5314831 in QObject::event (this=0x7fffd40052f0, e=0x7fff340c3000) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1429
            #12389 0x00007fffe31e2ea0 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x7fffd40052f0, e=0x7fff340c3000) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3309
            #12390 0x00007fffe31e6da8 in QApplication::notify (this=0x55555556ea60, receiver=0x7fffd40052f0, e=0x7fff340c3000) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3259
            #12391 0x00007fffe524f159 in QCoreApplication::notifyInternal2 (receiver=0x7fffd40052f0, event=0x7fff340c3000) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1111
            #12392 0x00007fffe524fdc9 in QCoreApplication::sendEvent (receiver=0x7fffd40052f0, event=0x7fff340c3000) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1551
            #12393 0x00007fffe5250d08 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x5555555a3f80) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1891
            #12394 0x00007fffe524fc0c in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1745
            #12395 0x00007fffe5853b11 in postEventSourceDispatch (s=0x5555555ca600) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #12396 0x00007fffe9f03f45 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12397 0x00007fffe9f06177 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12398 0x00007fffe9f068e0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12399 0x00007fffe5852d4b in QEventDispatcherGlib::processEvents (this=0x555555558690, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #12400 0x00007fffe4986d88 in QPAEventDispatcherGlib::processEvents (this=0x555555558690, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #12401 0x00007fffe61d5314 in QtInstance::ImplYield (this=0x5555555fa9c0, bWait=false, bHandleAllCurrentEvents=true) at vcl/qt6/../qt5/QtInstance.cxx:503
            #12402 0x00007fffe61d85c1 in QtInstance::DoYield (this=0x5555555fa9c0, bWait=false, bHandleAllCurrentEvents=true) at vcl/qt6/../qt5/QtInstance.cxx:512
            #12403 0x00007fffeec626a6 in ImplYield (i_bWait=false, i_bAllEvents=true) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #12404 0x00007fffeec62967 in Scheduler::ProcessEventsToIdle () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:435
            #12405 0x00007fffdd867acd in avmedia::qt::QtFrameGrabber::grabFrame (this=0x5555696d1210, fMediaTime=3) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtFrameGrabber.cxx:103
            #12406 0x00007fffdd867bce in non-virtual thunk to avmedia::qt::QtFrameGrabber::grabFrame(double) () at /home/michi/development/git/libreoffice/instdir/program/../program/libavmediaqt6.so
            #12407 0x00007ffff0be5a43 in avmedia::MediaWindow::grabFrame (xPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68, rGraphic=empty uno::Reference)
                at /home/michi/development/git/libreoffice/avmedia/source/viewer/mediawindow.cxx:385
            #12408 0x00007ffff1c3282f in SdrMediaObj::getSnapshot() const::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const
                (this=0x5555696652b0, rPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68) at /home/michi/development/git/libreoffice/svx/source/svdraw/svdomedia.cxx:195
            #12409 0x00007ffff1c327ad in std::__invoke_impl<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(std::__invoke_other, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) (__f=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61
            #12410 0x00007ffff1c3275d in std::__invoke_r<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) (__fn=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111
            #12411 0x00007ffff1c325d5 in std::_Function_handler<void(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&), SdrMediaObj::getSnapshot() const::$_0>::_M_invoke
                (__functor=..., __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290
            #12412 0x00007ffff0bebf96 in std::function<void(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&)>::operator() (this=0x7ffeac001728, __args=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591
            #12413 0x00007ffff0be8191 in avmedia::PlayerListener::callPlayerWindowSizeAvailable (this=0x7ffeac0016e0, rPlayer=uno::Reference to (avmedia::qt::QtPlayer *) 0x55556778be68) at include/avmedia/mediawindow.hxx:74
            #12414 0x00007ffff0be676f in avmedia::PlayerListener::preferredPlayerWindowSizeAvailable (this=0x7ffeac0016e0) at /home/michi/development/git/libreoffice/avmedia/source/viewer/mediawindow.cxx:496
            #12415 0x00007fffdd8708f0 in avmedia::qt::QtPlayer::notifyListeners (this=0x55556778be00) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtPlayer.cxx:386
            #12416 0x00007fffdd870718 in avmedia::qt::QtPlayer::notifyIfReady (this=0x55556778be00) at /home/michi/development/git/libreoffice/avmedia/source/qt6/QtPlayer.cxx:324
            #12417 0x00007fffdd875636 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}::operator()() const (this=0x7fffffffa280) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #12418 0x00007fffdd8755b9 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call(void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), avmedia::qt::QtPlayer*, void**)::{lambda()#1}&&) (args=0x7fffffffa650, fn=...)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #12419 0x00007fffdd875583 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call
                (f=(void (avmedia::qt::QtPlayer::*)(class avmedia::qt::QtPlayer * const, enum QMediaPlayer::MediaStatus)) 0x7fffdd8706c0 <avmedia::qt::QtPlayer::notifyIfReady(QMediaPlayer::MediaStatus)>, o=0x55556778be00, arg=0x7fffffffa650)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #12420 0x00007fffdd8754fd in QtPrivate::FunctionPointer<void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus)>::call<QtPrivate::List<QMediaPlayer::MediaStatus>, void>
                (f=(void (avmedia::qt::QtPlayer::*)(class avmedia::qt::QtPlayer * const, enum QMediaPlayer::MediaStatus)) 0x7fffdd8706c0 <avmedia::qt::QtPlayer::notifyIfReady(QMediaPlayer::MediaStatus)>, o=0x55556778be00, arg=0x7fffffffa650)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #12421 0x00007fffdd875426 in QtPrivate::QCallableObject<void (avmedia::qt::QtPlayer::*)(QMediaPlayer::MediaStatus), QtPrivate::List<QMediaPlayer::MediaStatus>, void>::impl
                (which=1, this_=0x55555ebc9d50, r=0x55556778be00, a=0x7fffffffa650, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #12422 0x00007fffe51050d2 in QtPrivate::QSlotObjectBase::call (this=0x55555ebc9d50, r=0x55556778be00, a=0x7fffffffa650) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #12423 0x00007fffe5328554 in doActivate<false> (sender=0x5555696e2b20, signal_index=5, argv=0x7fffffffa650) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4241
            #12424 0x00007fffe531e763 in QMetaObject::activate (sender=0x5555696e2b20, m=0x7fffe29e91f8 <QMediaPlayer::staticMetaObject>, local_signal_index=2, argv=0x7fffffffa650)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4301
            #12425 0x00007fffe272fbab in QMetaObject::activate<void, QMediaPlayer::MediaStatus>
                (sender=0x5555696e2b20, mo=0x7fffe29e91f8 <QMediaPlayer::staticMetaObject>, local_signal_index=2, ret=0x0, args=@0x7fffffffa694: QMediaPlayer::LoadedMedia) at qtbase/src/corelib/kernel/qobjectdefs.h:319
            #12426 0x00007fffe272a7ed in QMediaPlayer::mediaStatusChanged (this=0x5555696e2b20, _t1=QMediaPlayer::LoadedMedia) at qtmultimedia/src/multimedia/Multimedia_autogen/include/moc_qmediaplayer.cpp:563
            #12427 0x00007fffe272a79c in QMediaPlayerPrivate::setStatus (this=0x5555696ece40, s=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/playback/qmediaplayer.cpp:118
            #12428 0x00007fffe271f553 in QPlatformMediaPlayer::mediaStatusChanged (this=0x55556961c710, status=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/multimedia/platform/qplatformmediaplayer.cpp:32
            #12429 0x00007fffa28f0e5c in QFFmpegMediaPlayer::mediaStatusChanged (this=0x55556961c700, status=QMediaPlayer::LoadedMedia) at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:131
            #12430 0x00007fffa28f1c0a in QFFmpegMediaPlayer::setMediaAsync (this=0x55556961c700, mediaDataHolder=..., cancelToken=std::shared_ptr<QFFmpeg::CancelToken> (use count 3, weak count 0) = {...})
                at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:269
            #12431 0x00007fffa28f36de in QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}::operator()() const (this=0x7fff3c354ce0)
                at /home/michi/development/git/qt5/qtmultimedia/src/plugins/multimedia/ffmpeg/qffmpegmediaplayer.cpp:211
            #12432 0x00007fffa28f3688 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}::operator()() const (this=0x7fffffffaa50) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:116
            #12433 0x00007fffa28f3669 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**)::{lambda()#1}&&)
                (args=0x7fff3c0045b8, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #12434 0x00007fffa28f3632 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void**) (f=..., arg=0x7fff3c0045b8) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:115
            #12435 0x00007fffa28f35c1 in QtPrivate::FunctorCallable<QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}>::call<QtPrivate::List<>, void>(QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}&, void*, void**) (f=..., arg=0x7fff3c0045b8) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:337
            #12436 0x00007fffa28f350d in QtPrivate::QCallableObject<QFFmpegMediaPlayer::setMedia(QUrl const&, QIODevice*)::$_0::operator()() const::{lambda()#1}, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x7fff3c354cd0, r=0x55556961c700, a=0x7fff3c0045b8, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:547
            #12437 0x00007fffe51050d2 in QtPrivate::QSlotObjectBase::call (this=0x7fff3c354cd0, r=0x55556961c700, a=0x7fff3c0045b8) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #12438 0x00007fffe5312adc in QMetaCallEvent::placeMetaCall (this=0x7fff3c004570, object=0x55556961c700) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:620
            #12439 0x00007fffe5314831 in QObject::event (this=0x55556961c700, e=0x7fff3c004570) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1429
            #12440 0x00007fffe31e2ea0 in QApplicationPrivate::notify_helper (this=0x55555557cb40, receiver=0x55556961c700, e=0x7fff3c004570) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3309
            #12441 0x00007fffe31e6da8 in QApplication::notify (this=0x55555556ea60, receiver=0x55556961c700, e=0x7fff3c004570) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3259
            #12442 0x00007fffe524f159 in QCoreApplication::notifyInternal2 (receiver=0x55556961c700, event=0x7fff3c004570) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1111
            #12443 0x00007fffe524fdc9 in QCoreApplication::sendEvent (receiver=0x55556961c700, event=0x7fff3c004570) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1551
            #12444 0x00007fffe5250d08 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x5555555a3f80) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1891
            #12445 0x00007fffe524fc0c in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1745
            #12446 0x00007fffe5853b11 in postEventSourceDispatch (s=0x5555555ca600) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #12447 0x00007fffe9f03f45 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12448 0x00007fffe9f06177 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12449 0x00007fffe9f068e0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12450 0x00007fffe5852d4b in QEventDispatcherGlib::processEvents (this=0x555555558690, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #12451 0x00007fffe4986d88 in QPAEventDispatcherGlib::processEvents (this=0x555555558690, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #12452 0x00007fffe61d52c2 in QtInstance::ImplYield (this=0x5555555fa9c0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:501
            #12453 0x00007fffe61d85c1 in QtInstance::DoYield (this=0x5555555fa9c0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:512
            #12454 0x00007fffeec626a6 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #12455 0x00007fffeec61fbf in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #12456 0x00007fffeec61da0 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #12457 0x00007ffff7b28029 in desktop::Desktop::Main (this=0x7fffffffd620) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1680
            #12458 0x00007fffeec83ee6 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:231
            #12459 0x00007fffeec85b19 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:249
            #12460 0x00007ffff7ba238a in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #12461 0x00005555555559fd in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #12462 0x00005555555559d7 in main (argc=2, argv=0x7fffffffd828) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        (Note that different QtPlayer objects are involved, i.e. it's not
        always the same QtPlayer object whose signal triggers another
        recursive call.)
        
        Backtrace when using the gstreamer backend using
        QT_MEDIA_BACKEND=gstreamer was comparable.
        
        [1] https://doc.qt.io/qt-6/qmediaplayer.html#mediaStatus-prop
        
        Change-Id: I8d928d0fd124d9b3f4f1947efe0d4d690e1d8851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183867
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ab40eb75d305e6684d5bea0452cb57ae9e7a5aa]

        fix spelling: "handish" -> "by hand"
        
        Change-Id: I37067a847ab7a4f64488a8a2d80fcf84988f512f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183876
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [6046c64bb67124afa2fe41f67c08101980ce14fc]

        add comment to test
        
        for other people like myself who may get confused
        
        Change-Id: Ibc7234306b214bd74ba35b8b4c46f18016ebf504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c21d9c7636b638855cbcd04f862f7457599e0e31]

        tdf#152299 Drop unused defines
        
        Seem to be unused since 2018 commit 86b9824312d8d
        
        "weld pages of the insert envelope dialog"
        
        Change-Id: I7f62fc544ad20579cde3d2a56bb8db142cd9c3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183859
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-09  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [8346ab98c1f84026bcdfad714e5e690b2f9147c0]

        sd: impress: fix scrollbar not updating on PgUp/PgDown
        
        make scrollbars update when the current slide is switched via
        hotkeys.
        which eliminates now not needed UpdateScrollBars call at
        CurrentSlideManager.
        
        Change-Id: I89db8c45edd14a871e6d9901a156609ad569984c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183854
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-04-09  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [b6a4f372f971a1664bd63158c2b0d41fc9d6c33b]

        tdf#163426 sd: notes pane: use ctrl+pgup/down for slide navigation
        
        notes pane uses pgup & pgdown for scrolling the text inside
        the pane. which blocks regular slide switching hotkeys for
        impress.
        
        add a new impress shortcut ctrl+pgup / ctrl+pgdown for going
        to the next or previous slide. for consistency sake this
        shortcut is not specific to notes pane but works everywhere on
        impress.
        
        make notes pane do not consume these keys so the default keys
        from accelerator config takes effect.
        
        Change-Id: I2221f90556683d1c00747ea855a7fe3a11d1a2a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183849
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2025-04-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [1fa2ae1f6ae5d0bc5cc2190ab921a82c2900c848]

        python3: upgrade to 3.11.12
        
        downloaded from https://www.python.org/ftp/python/3.11.12/Python-3.11.12.tar.xz
        
        Change-Id: I233d304d688466e1192a160599aafa0fc189c51d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183869
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fd417165be155a0c88d04e0179368597a3f05cfe]

        Adapt external/epm to changed default patchlevel
        
        ...from 3709789a58d6c7df5c15565299bb024c52807c31 "gbuild: set default patchlevel
        to 1", which broke --enable-epm
        
        Change-Id: I20566b7b899a226b010f071d4e6a5db6e8a3da63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183864
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [025bc005283f1d96674746e20b52dd339507b3a6]

        Adapt external/xsltml to changed default patchlevel
        
        ...from 3709789a58d6c7df5c15565299bb024c52807c31 "gbuild: set default patchlevel
        to 1", which broke --enable-ext-wiki-publisher builds
        
        Change-Id: Ieb21b5198257a655377652c457242a0e22fc9c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183863
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [538f3a4a82c366b7a28c3f3d58c468be3b4b3f71]

        Remove obsolete comment
        
        ...after 3709789a58d6c7df5c15565299bb024c52807c31 "gbuild: set default
        patchlevel to 1"
        
        Change-Id: I284e23d489a86ad59cf1623d11deebc363941e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183862
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-09  Jonathan Clark  <jonathan@libreoffice.org>  [5a03d511f46ecc05aab35bb29e714b46f5638b1b]

        tdf#130592 i18npool: Fix incorrect line breaking in mixed CJK+Latin
        
        This change updates the CJK BreakIterator to run ICU line breaking rules
        after applying user forbidden rules. This fixes several identified CJK
        GUI text rendering issues, most significantly that embedded English runs
        were previously broken using CJK break rules, rather than using the
        correct English rules.
        
        By implementing this fallback to the ICU rules, the CJK BreakIterator
        now also correctly handles non-breaking characters. This change
        therefore also fixes tdf#117554.
        
        Change-Id: I3bacc7e2b559729df2c37c010974d180c8eef1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183825
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-04-08  Gülşah Köse  <gulsah.kose@collabora.com>  [8933bdc9db8110e980a24b1f7c3627b59a4a1ff1]

        cool#11216 Remove unnecessary control to invalidate cursor
        
        bPostItActive control is introduced by b9cc6653606c829805c6c01b9613a3a25d81c20b
        Then new annotation changes introduced by 69c546e1e7a697217f273baa7c1729ff823efd76
        makes this control unnecessary so removed the test testWriterCommentInsertCursor
        introduced in first commit.
        
        To keep that control makes buggy finding text via "Find and Replace"
        dialog in comments. It never moves the visible cursor if the text
        matches only in comments
        
        Now it fixed.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Ice60b4de2ae65c400b49153c3a0a4f3cccb7ad87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181634
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183844
        Tested-by: Jenkins

2025-04-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [93bf5c795f2a4aa3f7e3e3ff102aa0ce7a44b44e]

        fix warning C6011: Dereferencing NULL pointer 'pImpPrMap'
        
        from the MSVC analyser, after
        
            commit 8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Apr 5 22:03:18 2025 +0200
            tdf#151876 shave some time off chart load (2)
        
        exposed this issue
        
        Change-Id: Ie64f8f4cc8cefa4c47167274c3f54b29e69725a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-08  Noel Grandin  <noelgrandin@gmail.com>  [6e16e1812292236ed61b637371f70459cf993b7f]

        tdf#64991 exit some loops early
        
        Change-Id: Ic3b5a8a2df5a484150edb95fcacf8960b53a6ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183855
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-08  Patrick Luby  <guibmacdev@gmail.com>  [98ca580e910d23bb7933fa39e6907900f9a4b651]

        tdf#165448 Allow macOS to add menu items in LibreOffice windows menu
        
        macOS will automatically insert menu items in NSApp's windows menu
        so set that menu to LibreOffice's windows menu.
        
        Note: while this native feature works with document windows, there
        are two cases where this feature is not available:
        
        - The Start Center has no windows menu so none of the menu items
          that macOS inserts will be inserted.
        
        - For some unkown reason, none of the menu items that macOS inserts
          into the windows menu work if the key window is a native child
          window of another window. Unfortunately, LibreOffice depends on
          a dialog window being a native child window of its parent window
          to mimic native modal dialogs so hide all the those menu items
          when a native child window has focus.
        
        Change-Id: Ie73711be479ef71d6aa62e6e8651c248afb8c252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183762
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-04-08  Pierre F  <fpy@bger.ch>  [ebd4162575187666263239e89e6269069aaf809a]

        tdf#145614 Convert #define to enum class
        
        Change-Id: I0182e3068c25e29f7970416a2a4f4c04afe32bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183635
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-04-08  FerMeza  <fernando.meza.ortega98@gmail.com>  [f3c89726d2234c0803c005dc87392f94147a481f]

        tdf#163691 Replace memcpy with std::copy in basmgr.cxx
        
        Change-Id: I88558282937fe9c4dfb2f102309583f932a4617c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183827
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [889796512ca6369375a90f335ee0d7305af9ca5b]

        sc a11y: Use non-const methods instead of const_casting
        
        Change-Id: I116f0601d916b7cecfab3b17f044a2576e33e584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183832
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [5e702a6c8b0cfdd3da5a06cc61ab3242c4bebd08]

        sd a11y: Drop custom XTypeProvider::getTypes impl
        
        I see no reason to override the base class implementation
        ImplInheritanceHelper::getTypes here.
        
        Change-Id: I2bdd29d49df7b5ab0d95791784e1e4ebe9555c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183831
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [16df8b5bef2c7680956a826f6d0895e9d02768d8]

        sc a11y: Drop ScAccessibleSpreadsheet::addAccessibleEventListener
        
        This override of the base class method
        ScAccessibleContextBase::addAccessibleEventListener
        adds nothing relevant not already done in the
        base class implementation that it calls as the
        end.
        
        Change-Id: I4634e60ed259abb3c7cdb56305cf127dfc5df49e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183830
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [a2baa12f9038be85a2425211fbc960b1c72ff304]

        editeng a11y: Pass bullet's child index in ctor
        
        ... instead of having a separate getter,
        AccessibleImageBullet::SetIndexInParent.
        
        Change-Id: Ie0e59f87e12d04efd72aa5663c4a3eb0df9baf21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183829
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [bafaf554a07766d99bb264f7bcc3198a57c2166e]

        editeng a11y: Drop AccessibleImageBullet::FireEvent
        
        Use base class method OAccessibleComponentHelper::NotifyAccessibleEvent
        directly instead. That one has the reverse order for the old/new value
        params, and no default for the old value, so adjust callers accordingly.
        
        Change-Id: Ib591495c5698832a99cd60854d4ee8aa4a206442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183828
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [7bf384d048ff58bd3e2d6e706176bf3b8e0be7e8]

        editeng a11y: Use OAccessibleComponentHelper for bullet
        
        Let editeng's AccessibleImageBullet derive from
        OAccessibleComponentHelper to make use of the
        logic already implemented there instead of having to
        implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        The existing AccessibleImageBullet::implGetBounds
        implementations provide the necessary logic to implement
        OAccessibleComponentHelper::implGetBounds, so mark it
        as overriding the base class method.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the base class.
        
        No change in behavior intended or observed in a quick
        test with Impress and Accerciser and the gtk3 VCL plugin
        on Linux.
        
        Sample steps to add a bullet item that shows
        up in the a11y tree:
        
        1) start Impress
        2) Create a new slide (Ctrl+M)
        3) type text "Hello world" for the first list item
        4) right-click on paragraph to open context menu, select "Bullets and
           Numbering"
        5) For "Type", select "Graphics"
        6) select "Select image..." -> "Gallery" -> "bluearrow"
        7) close dialog with "OK" button
        
        Then, start Accerciser, and locate the "Image bullet"
        object within LibreOffice's a11y tree.
        
        Change-Id: Iba9d44288be96838e39d7cee2333f7a074deae8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183783
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [785fc3e4975b4174253e2eb8ee03cfafa824a34e]

        editeng a11y: Drop unnecessary exception handling code
        
        Modifying a sal_Int64 value won't throw an exception.
        
        Change-Id: Ia5739ecebb839dfcd51c27f35309ad717b505c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183782
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [50190bec9963d07018c7fd490077dff7a1565143]

        editeng a11y: Simplify AccessibleImageBullet::FireEvent
        
        * Drop const qualifier, which removes the need to const_cast.
        * Don't call AccessibleImageBullet::getAccessibleContext,
          but just use `this` directly.
        
        Change-Id: I4949ec624e44b6330a0ca5f71f898f1d17b4bd8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183781
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [c040f9a3905d6a6abeefc643028a2bbd201a1818]

        editeng a11y: Let paragraph dispose its bullet child
        
        Instead of letting AccessibleImageBullet dispose
        itself in AccessibleImageBullet::SetEditSource when
        called with a null edit source, let the AccessibleEditableTextPara
        that created the bullet and can therefore be considered the
        owner (see AccessibleEditableTextPara::getAccessibleChild) dispose it
        again in AccessibleEditableTextPara::dispose.
        
        Also clear `maImageBullet`.
        
        This is similar to
        
            commit 138bc16c9aac04def13843bb9bf6f18075a88c0f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 3 11:59:51 2025 +0200
        
                editeng a11y: Let para manager dispose its child
        
        Change-Id: I8083b0c9bf304942e9ead446bdeaefeb62ae609f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183780
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [4e892def7bd702c65e9a125b239880b790181a29]

        editeng a11y: Drop empty lines at beginning of methods
        
        Change-Id: Ib25bc28adab2e220c4fe3056413a6fac10fcbdc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183779
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [2efc261bf9cd0320ad8a66c77bfd253078fe67e9]

        editeng a11y: Drop extra indentation level
        
        Change-Id: I1d2f37499b5b1634141f9023815b0cb5ac1f4f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183778
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Gülşah Köse  <gulsah.kose@collabora.com>  [eb0a2864dce8b63d3449d54e29d5eb05abede236]

        ONLINE: Make Area panel visible for OLE objects
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Ic4db91a7a4583c10eb62267f8bb233df661aabd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183194
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183846
        Tested-by: Jenkins

2025-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [667f1012ffd896d0ed04641e359395643486bacb]

        slideshow: simplify a bit more
        
        Change-Id: I0a59e0618f4a7993a7fcbb52c6114c437d48141a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183847
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [132159f779a78ac21c9ed985040e17c612fe66d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d000780aa48792e86edf8d5b74a7c10d7f848cfa
          - Some visual enhancements on icons for New command
            
            Change-Id: I8f9bf4fa70c8b595dae86567be4df208ea2ef3b5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183845
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-04-08  Justin Luth  <justin.luth@collabora.com>  [06114cd852c90468a950271de733f704d02b5f69]

        tdf#165492 sw mso layout: add bottom border padding to 'exact' height
        
        at least for MS Word formats.
        
        This improves 25.2 commit 4f5b896d004af023f210f235aeafa9abc50068d2
            tdf#155229 Calculate row height incl. border if 'atLeast' is set
        by applying an anomaly shared with the atLeast calculation.
        
        Interestingly, the top padding has no effect at all
        on the 'exact' cell height.
        Yet, the bottom padding is added on top of the provided height,
        and therefore 'exact' doesn't mean exact at all.
        Rather bizarre actually.
        
        make CppunitTest_sw_ooxmlexport22 \
           CPPUNIT_TEST_NAME=testTdf165492_exactWithBottomSpacing
        
        make CppunitTest_sw_ooxmlexport21 \
           CPPUNIT_TEST_NAME=testTdf160077_layoutInCellB
        
        ooxmlexport14's tdf87569_vml.docx is another decent example
        where the mailing labels now fill the entire page better.
        
        Change-Id: Iec1a935950ecafc0d8d84d23bca4b85b79b700e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183739
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6a1ff865e69ff4bd7f6b41dc3328a6593ce40ff]

        slideshow: refactor code a bit
        
        * return from initiateWorld is unused
        * drop step. it's called only from one place
        * makeShapeStatic is unused
        * Drop default parameters
        * Drop duplicated asserts already checked in the caller
        
        Change-Id: I8d77cf1b4e71d5f0f9a7f6da61672d24bd83725b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183840
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-08  Miklos Vajna  <vmiklos@collabora.com>  [7b31fb0c5035f9af3e36862ac26b86fce3844e79]

        Related: cool#11226 fix 'record track changes' export to FODT
        
        Create a Writer document, enable tracked changes, save to FODT, reopen,
        changes are no longer tracked.
        
        This seems to be an export problem, <text:tracked-changes
        text:track-changes="true"> is simply not in the export result.
        
        What happens is that the export wants to show insertions and hide
        deletions during the export, and this happens in
        SwXMLExport::exportDoc() for FODT while it happens in
        SwXMLWriter::Write_() for ODT. This went wrong in commit
        6af264883910fe31433b4164b1956f4f9ed75ecb (#94187# switch redline mode
        outside of XML export components (or inside for each of them),
        2001-11-08), where the mask to clear out the "show" bits was wrong for
        the flat case and good for the package case.
        
        Now that we actually set redline flags to hide deletions during FODT
        export (or anything based on that, like the XHTML export), an additional
        problem is that SetRedlineFlags() asserts in UnHide() for
        CppunitTest_sw_xhtmlexport's testTdf66305, because there is no
        StartAllAction() / EndAllAction() around it, while that is happening in
        SwWriter::Write() for the ODT case. Fix this, too.
        
        Change-Id: I227a883ecc5d68611d8aee5c80d65485b5f3c4c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183837
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-08  Justin Luth  <justin.luth@collabora.com>  [ae4c4d5db85e2a61cbef1dc045c6c2614ad36dfc]

        LOK fix nullptr dereference in DrawViewShell::SelectPage
        
        Introduced with commit ebdb73c17d884c463c3c1279678a36c2668fd8c2
        Date:   Tue May 26 10:17:40 2020 +0530
            LOK: slide sorter: update the model on selecting multiple slides
        around the time of LO 7.0
        
        There were no steps to reproduce given.
        This is a blind fix based on a code read and a stack trace.
        
        sd::slidesorter::SlideSorterViewShell::GetSlideSorter (this=0x0)
        at sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx:291
        
        [I also took the opportunity to flatten the simply code
        (otherwise it would have ended up awkward
        with clang-format compliant formatting).]
        
        Change-Id: I78a703f51287d52cbcbae7d87ae4b455379becbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183717
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-04-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7607560a7b0840ba883b00807d1bc86e594a0f13]

        lok: slideshow: effect for paragraph with auto font color can be wrong
        
        Color animations applied to a paragraph with font color set to auto didn't work.
        Here we implement a new way for retrieving the real paragraph font color.
        
        Change-Id: I72540964a6eddb75188c21f22b110a7e5007bcac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183838
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b773eb296ee526185ca29b7a2f526e2ed10340aa]

        restore CharacterProperties::createFontDescriptorFromPropertySet
        
        because we will use this again
        
        Change-Id: Idb7dccf9ee2f41ed99929f4ee9588b5e1b30dc8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183839
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-08  Szymon Kłos  <szymon.klos@collabora.com>  [d33dab92286f139178488c3091e0c4b8dcf38277]

        Impress: implement DontTerminateEdit support
        
        Name FN_PARAM1 in calc so it is clear what it does.
        It is used as DontTerminateEdit indicator used eg. in
        LOK case when we do saving in the background. In Impress
        when we edit textbox and close presentation - sometimes it
        is not saved because we didn't press Enter to commit the change
        inside. In LOK case we want to save the content to not allow
        data loss in unexpected connection close.
        
        Change-Id: Ibcdcd4a0d52eb36e0b1004971dcb73f58c35459e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183652
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ff47a1657d3fb9ac89824566f5b7b8899a72587b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183826
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-04-08  Noel Grandin  <noelgrandin@gmail.com>  [ca8f94720e4d1e08c5136b2cbc7f93717e2566b1]

        some unit tests not valid when the pdfimport feature is disabled
        
        Change-Id: I1d4b7e449192a689fc107ef0ce500501f6722185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [fddde0716a4f08eba97e511f13e1908155611ea2]

        postgresql: fix build with macOS 15.4
        
        From https://github.com/postgres/postgres/commit/0de9560ba9b8fc4f0de8c5784303db82156279a6
        
        Change-Id: If2d40ef5d4cced2cd72c401a2c103f55511dace5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183776
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [f6a96d91e3bf28ace032c38f889f58271c5e4dc9]

        tdf#130857 uui: Move showing warning dialog out of PasswordDialog ctor
        
        Move logic to show a warning dialog that the (previously entered)
        password was incorrect from the PasswordDialog ctor to the
        executePasswordDialog function which calls the ctor.
        
        As the dialog is meant to be shown before the PasswordDialog,
        there is no reason to have the logic in the ctor, and (while
        the underlying issue is potentially a Qt bug) this
        helps avoid the problem described in previous commit
        
        Change-Id: I9d1ffeaf48380aa4849e3cb771f6ff517d588790
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Mon Apr 7 15:23:02 2025 +0200
        
            tdf#130857 qt weld: Support PasswordDialog
        
        > When typing an incorrect password and confirming using
        > the OK button, the dialog is oddly shown as "Set Password"
        > dialog on top of the warning dialog ("The password is incorrect.
        > The file cannot be opened.") when using qt6, which is not the
        > case for qt5.
        > This will be addressed in a separate commit.
        
        which is somehow caused by both dialogs using the same
        parent.
        (It wouldn't occur e.g. when not setting a parent for
        one of them.)
        
        Change-Id: Iba10d44294c5c94f3fb7f8ce7aaf9135d1113736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183796
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [dac3395f3826ef7e4d752a69e313a3c8af9a0864]

        tdf#130857 qt weld: Support PasswordDialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog gets shown when opening a password-protected
        file, allowing to type the password in order to open the
        file.
        
        When typing an incorrect password and confirming using
        the OK button, the dialog is oddly shown as "Set Password"
        dialog on top of the warning dialog ("The password is incorrect.
        The file cannot be opened.") when using qt6, which is not the
        case for qt5.
        This will be addressed in a separate commit.
        
        Change-Id: I9d1ffeaf48380aa4849e3cb771f6ff517d588790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183795
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [c78d9f48a6b6e59ad2321b35e51e5cb1e4dec6d3]

        libnumbertext: remove obsolete comment
        
        Since
        commit 6064b3382102bcbc153156f5874fbc8dfde97b98
        Author: László Németh <nemeth@numbertext.org>
        Date:   Sun Nov 13 13:00:42 2022 +0100
        
            tdf#115007 tdf#148672 bump libnumbertext 1.0.11
        
        Change-Id: Ic87d04946490eb8fefbb9783c54102e38ad7f29f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183819
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [3709789a58d6c7df5c15565299bb024c52807c31]

        gbuild: set default patchlevel to 1
        
        Change-Id: I195dbafff63e21a22edf438f5b9ed5beee4dac03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183784
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [c451dfe04d4ccf46bae328ea2529a8b944936279]

        slideshow: fix for animated paragraph with bg color partly transparent
        
        Given a text shape with a background color with alpha component != 0, 1 a layer
        related to an animated paragraph includes also the background which is clearly
        wrong.
        
        Change-Id: Ib3a2ffb5bc01506400897f946ca4d6c23f8eb388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183793
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-08  Michael Weghorn  <m.weghorn@posteo.de>  [e7a34dbaec716fb441f09007b150c7be54e3b013]

        wina11y: Simplify SELECTION_CHANGED_* handlers a bit
        
        Drop the unused `oldValue` param from the methods
        handling the SELECTION_CHANGED_* events, and make
        them non-virtual, as they don't need to be overriden
        in any subclass.
        
        Change-Id: Ic4a248a6dedaa0a6b25b22dd5673be2bb27a4fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183791
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-08  Andras Timar  <andras.timar@collabora.com>  [3ebf51d380e13cb0258ceea504d55a675a4d506b]

        fix internal Python build for ppc64le platform
        
        Change-Id: I1229e93ea7bf5dd24580fbf3114a4201270c0120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183810
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-08  Justin Luth  <justin.luth@collabora.com>  [879c30d6f3a4027b486f15ad0f554e5d0df87a84]

        tdf#165424 writerfilter: handle row's tblPrEx tblCellMar
        
        Up till now, we have handled table margins
        specified at the table level
        and overridden at the cell level.
        But we have ignored any definition of the cell margins
        at the row level.
        
        This patch adds support for tblCellMar under w:tr's tblPrEx,
        
        make CppunitTest_sw_layoutwriter4 \
               CPPUNIT_TEST_NAME=TestTdf164907_rowHeightAtLeast
        
        This also can be seen (slightly) in ooxmlexport14's tdf92472.docx
        and in rows 4+ of ooxmlexport20's tdf138612.docx.
        
        The patch ended up being simple, thanks to Laszlo's earlier work.
        (I fixed a tiny bug for him - otherwise it was missing
        the first cell/column - which I have captured in this unit test):
        
        make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf138612
        
        Change-Id: Ic98d6cb1b41096c6fd137948babc74dba7e79ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183753
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-04-08  Justin Luth  <justin.luth@collabora.com>  [057a9b7ac67ca178bbc5186ba73f3e45aa7ad04c]

        tdf#165492 sw mso layout: add bottom border padding to cell minHeight
        
        at least for MS Word formats.
        
        This improves 25.2 commit 4f5b896d004af023f210f235aeafa9abc50068d2
            tdf#155229 Calculate row height incl. border if 'atLeast' is set
        where it seemed to work if (as is typical)
        the top and bottom padding were identical.
        
        However, the top padding actually has no effect
        on the minimal cell size - only on the actual fitted size.
        Yet, the bottom padding DOES affect the minimal cell size.
        
        [Bottom padding should also be added on top of the "exact" cell height,
        but I didn't see a place where both of these could be handled
        with a single chunk of code.]
        
        make CppunitTest_sw_ooxmlexport22 \
           CPPUNIT_TEST_NAME=testTdf165492_atLeastWithBottomSpacing
        
        A follow-up commit (for tdf#165424) is needed to fix this unit test,
        where we don't import the overriding row definitions
        that would remove the bottom border padding for all-but-the-first row.
            TestTdf164907_rowHeightAtLeast
        
        Change-Id: Ib987defc6187171de05884cb0ced3273cdc57b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183737
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-04-08  Justin Luth  <justin.luth@collabora.com>  [3b92b1b0bcbd3f490bbd1d94bf4a9e6593540cdc]

        related tdf#165492 sw table layout: calc entire space before compare
        
        This is just based on a code read.
        It doesn't make sense to check if the row will fit on the page
        before fully determining the actual minimum size.
        
        [The "if (bMinRowHeightInclBorder)" code block
        was the most recent addition.]
        
        Change-Id: Iab256e4098650c838dc5ef7ca3fb06aa0fd9acd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183738
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-04-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0e808a107c77cc0d669105624060a6e6baac433c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e34d749b46d0d79db4b048e6a04cb2154ac0acf
          - Fix typo
            
            Change-Id: Ia291efd6eda5c5ae2ac724b07a80ee1d04ae76ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183813
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-04-08  Eike Rathke  <erack@redhat.com>  [bac279b83d498ed54bb64a6faeafc6ef96bbfb95]

        Related: tdf#166056 Add Gronings {gos-NL} to language list
        
        Change-Id: I10c29d8644621e4834c95cab2be0b7825680ec9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183817
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-04-07  Manish  <mailmessgcnect@proton.me>  [4eacc9dc0f5c643b02fdc7364666536fc040f54b]

        tdf#162563 Remove remaining Java applet code and references
        
        Change-Id: Icecb06ee056c3089e931f6fca8f0791ec67ccf8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183740
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-04-07  Eike Rathke  <erack@redhat.com>  [28ababa6cc49d9cbc2e483faf74818610863b1d0]

        Related: tdf#166056 Add Gronings {gos-NL} [0x06B5] mapping
        
        Change-Id: I4db299a198f8352720071eb1269e3294a4f88270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183815
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-04-07  Noel Grandin  <noelgrandin@gmail.com>  [a950caa029b6afcf385fbbdfbf8d2d6367b7e0a0]

        tdf#64991 inline some calls inside a hot loop
        
        Change-Id: I04cfb8edd761e26f5093668e4acd31204e7906b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-07  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f336fc1835e89175257058ac7397a02b805e8170]

        Revert "tdf#163691 Replace memcpy with std::copy in basmgr.cxx and image.cxx"
        
        This reverts commit fa357e4a0a44471637373302c4391e6b0c2f1a20.
        
        Reason for revert: no license statement submitted
        
        Change-Id: I45f473c3185df5593a55017fcbaefd03dc5f43e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183790
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-04-07  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [7d7ee87f18f50a0a07ddfe383e3497041183f828]

        tdf#163444 sd: add mnemonic for Notes Pane menu item
        
        Set p as the mnemonic for Notes Pane menu item. AFAICS no
        clash-free mnemonic was possible. As a result the mnemonics
        for Slide Pane and Notes Pane clash now.
        
        I think it is logical to make these two items clash, since
        they are both for toggling panes.
        
        Change-Id: I00ac6f815e0109a3e276eeee7e03beffba7b0946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183777
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-04-07  Miklos Vajna  <vmiklos@collabora.com>  [94e683b5e18cfa40a65d970b50f03a88ec352b60]

        cool#11226 sw per-view redline on: fix bad record mode change on undo
        
        Have 2 Writer views, enable recording for "this view", type a few
        characters, undo. The recording is now enabled for all views, not just
        this view.
        
        The problem is that sw::DocumentRedlineManager::SetRedlineFlags_intern()
        only gets flags, so in case UndoRedoRedlineGuard sets new temporary
        flags & then restores those flags later, then that guard assumes that we
        return to the old state, but it implicitly calls
        SetRedlineFlags_intern() with 'bRecordAllViews = true', so the record
        mode changes from "this view" to "all views" at the end.
        
        Fix the problem by changing the RecordAllViews boolean to an enum and
        introducing a "view agnostic" mode: here we don't care too much about
        views, since these calls are typically just temporary, but what we care
        is that 1) if they enable recording, then IsRedlineOn() reports true and
        2) if they set new flags & later restore the old flags, the state is
        unchanged.
        
        Alternatives considered:
        - It would be possible to just touch the model in the "view agnostic"
          case, but then IsRedlineOn() would still get the recording bool from
          the view, leading to a stack overflow: lcl_DoWithBreaks() ->
          sw::DocumentContentOperationsManager::DeleteAndJoinWithRedlineImpl() ->
          sw::DocumentRedlineManager::AppendRedline() ->
          sw::DocumentContentOperationsManager::DeleteAndJoin() ->
          lcl_DoWithBreaks() again.
        - It would be possible to fix this on the undo side (to query the record
          mode and restore that mode explicitly when restoring flags), but we
          have many other use-cases for setting & restoring flags: e.g.
          autocorrect or autoformat.
        
        Change-Id: I75697c6b5b3767ad8db899cda080be312eb6c821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183792
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [eee10ae0c83a62b39ae466e4cca433c95f9a9433]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 850c928eb0745dbe8c8886ab96cb99b80e760ce2
          - Upgrade Mongolian dictionary to 2025.04.04
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2025.04.04.zip
            
            Change-Id: I9e34c8f42ab12bb80aea26c1a0731228294a8d4b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/183807
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-04-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6fc773a5e4ef41f7f944c6a0fdcb598aad2a7d8]

        update to skia m136
        
        drop a patch that is now upstream
        
        Change-Id: I2dc624ad2f2705c116a4dfe2e6e1ceac811f97d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [476881dc6cc53ddb1912da5a35f57f24c2db0ed6]

        lxml: upgrade to 5.3.2
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-5.3.2/lxml-5.3.2.tar.gz
        
        Change-Id: Iec99130a6bcb5581044a49b9cfc7e951c08a865c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183773
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-07  Celia Palacios Gómez Tagle  <celia.palacios@libreoffice.org>  [edb51323566d616ef7dfafd7b573c5042d246a6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3bc8ac32da08aa1da0e8e6df0cca3491dc1a82dd
          - Edit source/text/sbasic/shared/03/sf_filesystem.xhp
            
            Change-Id: I0e0faded698ed2da706e7cb5fd83df3cf16c894a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183764
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-07  Christopher Sherlock  <chris.sherlock79@gmail.com>  [a9caf1506b5e4b78cf98ab23fc495fb324282e49]

        vcl: flatten StartExtHelp() and EndExtHelp() in Help
        
        Change-Id: If061ec9e47f89b473ee582ff1f6b6a8d97cbafa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182062
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-07  Miklos Vajna  <vmiklos@collabora.com>  [cd4e4bf9f958c833387694cff7408efdfb53ff84]

        svx: prefix members of SdrCircObj
        
        See tdf#94879 for motivation.
        
        Change-Id: I56630c82d7adccdb89f7ca86077c9eadb799383a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183766
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-07  Noel Grandin  <noelgrandin@gmail.com>  [cd22ac3f63084a4290fa5cdad8300f7a69b2030e]

        tdf#151876 flatten data-structure a little
        
        so we need to do less pointer chasing to perform the work
        
        Change-Id: I16f160a009ca157b1712eab98dd7ad7b1414b5d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-07  Noel Grandin  <noelgrandin@gmail.com>  [f2924ccd27919f850e94e5ab68dc8f908058a066]

        tdf#151876 no need to insert zero here
        
        when we use operator[], it will create an entry if necessary,
        and if it needs to do so, that entry will default to zero.
        
        Change-Id: I5b2646cd4a7bbe49e3e3dd281062a7f23aa6a399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183758
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-07  Manish  <mailmessgcnect@proton.me>  [b7e6e0f150a669aa191b16655e6e03d60946c416]

        tdf#146150 Use dispatch command instead of numerical ID for the UNO commands
        
        Change-Id: Ia50b51bbb12faabf9c7418530209e48c96425fb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183563
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [eb4977cb6d81b1c15d025435adf25b19e88d3132]

        assigning m_pPosHelper here does nothing useful
        
        Change-Id: I46750c9782610b47e5bb64808f12b5691643cba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [7881f210b439fcee025daaac56115cb0f868a402]

        tdf#151876 shave some time off chart load (3)
        
        reduce the number of times we acquire/release the solarmutex in
        the hottest part of the load.
        
        Change-Id: I840e4b1bdb489319c6b03d9bfa69e761eb448831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183756
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dc9bcbd50f79811787202429b49fe855c2d643be]

        crashtesting: unable to reimport odp export of fdo72444-1.pptx
        
        There is a smil:values / smil:keyTimes count mismatch where the original
        pppx has: <p:tavLst><p:tav tm="0"><p:val></p:val></p:tav> so p:val is
        present but empty which results in an empty Any so the matching
        smil:values at export of the odp is empty while a smil:keyValues is
        exported, resulting in AnimationNodeContext::init_node throwing
        css::io::WrongFormatException from the mismatch of
        xAnimate->getValues().getLength() != xAnimate->getKeyTimes().getLength()
        
        exporting to pptx and then converting that to odp just drops the
        smil:values + smil:keyTimes, so solve this by only exporting
        smil:keyTimes if there was a successful export of smil:values.
        
        Change-Id: I5577a6671bfcebecf995afeea90e2d701f33eab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183761
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-06  Michael Weghorn  <m.weghorn@posteo.de>  [263536de849a9f5d5dcf5b7abe45bf0e1f2ca53e]

        tdf#130857 qt weld: Clarify comment
        
        See also commit message in
        
            commit e32d069ba74229916c459842d0c27c5a89b82168
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 13 22:55:50 2024 +0100
        
        that added the comment.
        
        Change-Id: Ibcd82e9392a2fb20311bf7dc7653faf32fd8c626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183729
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-06  Michael Weghorn  <m.weghorn@posteo.de>  [3c492ebe592ff83f13b4a6db6ff6f4eb5336c277]

        tdf#130857 qt weld: Support more button types in button boxes
        
        So far, QtBuilder only added button to the parent button box
        when those buttons were created for "GtkButton" objects in
        a .ui file, but not for other button types like "GtkMenuButton".
        
        Move the logic from the "GtkButton" specific handling to
        QtBuilder::setButtonProperties so it is also used for
        other button types.
        
        This will e.g. be used e.g. by the Math "Format" -> "Spacing"
        dialog (starmath/uiconfig/smath/ui/spacingdialog.ui, not supported
        by QtInstanceBuilder yet) which has a "GtkMenuButton" (with ID "category")
        in its button box.
        
        Change-Id: I1748fa85ca3e85dff09a93c4d1c453a151956c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183728
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-06  Michael Weghorn  <m.weghorn@posteo.de>  [f0fe0f843923e9da5e9401ba41651842a8e502c0]

        tdf#130857 qt weld: Support doc recovery dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the dialog showing the list of files
        that will be restored when LO crashes.
        
        Change-Id: I4bcf439309d7db433e0bb1e404c75e971460c2ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183727
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-06  Michael Weghorn  <m.weghorn@posteo.de>  [14088f6d2db96b83782c8e52126fc4a5584ffd69]

        svx: Resave docrecoverysavedialog.ui with glade 3.40
        
        This is the dialog showing the list of files
        that will be restored when LO crashes.
        
        Change-Id: I291e94a6ce35569b51856278057a963c092ed430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183726
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [61e1e38595e95e228168e8385662fe3bcd4c80e1]

        crashtesting: out of bounds in export of tdf128404-1.ppt to pptx
        
        and others, e.g.
        
        bugtrackers/pptx/ooo119584-1.pptx
        bugtrackers/pptx/novell499654-1.pptx
        bugtrackers/pptx/tdf112868-1.pptx
        bugtrackers/pptx/tdf104787-1.pptx
        bugtrackers/pptx/ooo96911-2.pptx
        bugtrackers/pptx/rhbz615970-1.pptx
        bugtrackers/pptx/tdf136754-2.pptx
        bugtrackers/pptx/tdf65724-6.pptx
        bugtrackers/pptx/tdf128404-1.pptx
        bugtrackers/docx/fdo51321-2.docx
        bugtrackers/docx/tdf103964-2.docx
        bugtrackers/ppt/tdf128404-1.pptx
        
        Change-Id: I73d75d714f2cecca9e728b3ba99e8c152e0f7685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183760
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [ed1f295018c14cd83fbd17568a6083942ba74ed4]

        reduce time in strlen when parsing xml prefix
        
        Change-Id: Ieac59782b502cf90cbc4c939b14317ac7c637c99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183754
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2]

        tdf#151876 shave some time off chart load (2)
        
        manage SvXMLImportPropertyMapper with unique_ptr instead
        of rtl::Reference, which avoids a bunch of ref-counting
        traffic
        
        Change-Id: I1e0e95408cdd5dc4271fa72178e57087737eb062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [b00bb0e9dcde085c103d42a7e22149bd914a91a9]

        tdf#151876 shave some time off chart load
        
        reduce the number of temporary UNO objects we create
        
        Change-Id: Ia429282e516610fd9ee2677bb930da9e02f6e43a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [2824c9ca4ba53f015f9b8f279b347585ee847818]

        use more concrete UNO in sc
        
        as a prelude to doing some optimisation
        
        Change-Id: Ia92f4c2f7a440c39c3180b262cde4ef83db7622a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183749
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [6ed923f647aaae79f36039b735c53592a4864ecb]

        tdf#151876 speedup editing large chart (2)
        
        reduce hang time when switching chart to edit mode by 50%.
        
        We were already calculating min/max in one pass, but we were
        calling it twice, once for min and then again for max.
        
        Change-Id: I80275cc32cf1514862b65bb1236057d2c872bdb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [51ea035a6f1f05260381bf98373774cde7ce5dfa]

        tdf#151876 speedup editing large chart
        
        reduces hang time when switching chart to edit mode by 50%.
        
        PerXMinMaxCalculator does not need to build a summary data structure,
        since we already walking over the data in X order.
        Also switch some the intermediate data structures to more cache
        friendly ones. In this case, std::map is better because we walk
        the data in X order.
        
        Change-Id: I3d291fd56becc1dfdd7d2df87d04b11f363bfd52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183747
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-06  Noel Grandin  <noelgrandin@gmail.com>  [a35e809943ec9a06a94cff3b11019fb766e8c3a4]

        hoist calls outside loop in chart2
        
        no need to call these inside the loop
        
        Change-Id: Ica84ca353e3c7b14542c405d8866386210babc3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183746
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-05  Jim Raykowski  <raykowj@gmail.com>  [b5e366c97d813c65d477941d45ae55f7dff954ad]

        tdf#165998 Spotlight switches the view to the Stylist
        
        * Makes turning on spotlight not switch to the Styles deck unless the
        sidebar is not currently open.
        
        * Makes turning off spotlight not switch to the Styles deck.
        
        * Fixes incorrect spotlight checkbutton state in the Styles deck when
        the state is changed in the Styles Inspector deck.
        
        * Fixes spotlight not turning on using the Styles Inspector deck
        spotlight buttons before visiting the Styles deck once.
        
        Change-Id: I6d2dea05c0ba47fbe3bf63d3caed8d87960df7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183694
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2025-04-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e559c3b2b4ca1fd2ba8c8ee5a7a5ac8a88893cf]

        tdf#147874 slow sheet switching with large chart2 (3)
        
        in
            commit 8611749d0acbf910a7003131e4419022eb4fe4bc
            tdf#147874 slow sheet switching with large chart2
        
        I didn't get the init order quite right to get the speedup I wanted.
        
        Change-Id: I5c1ce80e5770578079985c02208fb253818c9c86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-05  Noel Grandin  <noelgrandin@gmail.com>  [03cecc410ed2f271f0e90eaafcff3380080aec0e]

        use more concrete class in chart2
        
        Change-Id: Ie949b25310ad9292165405c254a24e374095cb82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-05  Julien Nabet  <serval2412@yahoo.fr>  [67f6e7299cd5cc6d4fd6dad4e64480c315a64c79]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 80829a174e316e34be479840640208f6f22c4b38
          - Fix path of logo for Spanish dictionary
            
            Regression from 762abe74008b94b2ff06db6f4024b59a8254c467
            "Updating RLA-ES Spanish spellcheker to v2.9."
                
            There's no "images" subdir in "dictionaries/es"
            
            Change-Id: I0aef269375f01fc0d869474059693ebf7ffc9a5a
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/183711
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2025-04-04  Jim Raykowski  <raykowj@gmail.com>  [22ef238e820955f6f8ac84781289b8a1d8e477b9]

        Replace 'highlight' with 'spotlight' in variable names used in the
        
        styles spotlight feature
        
        The feature was initially referred to as styles highlighter. Shortly
        before merging it was relabeled styles spotlight.
        
        Change-Id: Ie65c6dd9c759c6ff1ea0ca23642a4041a932881c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183693
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f405c6a670a4272581095b4aa75bb0ca8c6daf63]

        Revert "reduce object creation in SvNumberFormatsSupplierObj (tdf#147874 related)"
        
        This reverts commit 083556bd17713bbbb1e7569b738c87dc3e93edf9.
        
        Reason for revert: This created a reference cycle, leading to a memory leak
        
        Change-Id: I786ff3674d88bf41d451f656914729ae4d53bf9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183725
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-04  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c947c4625b225b0dabce3e9514d52188c89d69b9]

        tdf#164318 (related) Fix translation context in Copy field content dialog
        
        Copy button was not picked up by make translations
        because of the "stock" context
        
        Change-Id: Icb941944568da5d9a05cf3568ef1eebed4c48491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183708
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [91b297730b1497850ca81d55288b65ab1712e468]

        tdf#166040 package: ZipFile::recover() find DD without PK78 signature
        
        The PK78 signature is optional, and if the sizes in the local file
        header are 0 then without the DD the recovery won't do anything useful.
        
        If the latest local file header has the DD bit set in flags, then try to
        find the DD before the next thing that has a PK?? signature.
        
        Change-Id: I149a87805f7bcb6216fc909c20ece600ce77956d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183722
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [4995811d0d9cf74fecf9b733b0a0f04fb15e372e]

        tdf#166040 unordf: fix assert when importing empty stream
        
        rdf_parser.c:592: (librdf_parser_parse_counted_string_as_stream) assertion failed: string length is not greater than zero
        
        Check for this in librdf_Repository::importGraph()
        
        Change-Id: I27e180fd2fc09c5f43b7fdfcc7faa184bdc0808a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183721
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-04-04  ArsalanKhan04  <arsal4an@gmail.com>  [c55ae722661d499cb27bc1f2727bc9873248adc5]

        tdf#163164 support altChunk referencing HTML in DOCX
        
        Change-Id: Ib6ff389f66dcc27dd2b2b07d66a1666ecb2c0518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183560
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [f57b11457c7dc7c9be44d4406b39b49a829cdabe]

        tdf#130857 Define widgets in math "Font Sizes" dlg in order
        
        Switch the order in which the widgets in the .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        The dialog can be triggered in Math via
        "Format" -> "Font Size".
        
        Change-Id: I9b0286d3329671632269649a461df52b855128b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183715
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [c82b58e9ca2ceaf90561f3f1e3d6b46c89a84442]

        math: Resave fontsizedialog.ui with glade 3.40
        
        This is the "Format" -> "Font Size" dialog in Math.
        
        Change-Id: I152f6f7ad4ebd2d4433485ebd266255f97e1da43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183714
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [5f89458043a828998e9ca13382a98f8f9aba0939]

        tdf#130857 qt weld: Use QDoubleSpinBox logic when no parser set
        
            commit 210c69cf7aaa314f932a9debe0e64ba2789f2365
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 20 19:22:52 2025 +0100
        
                tdf#130857 qt weld: Implement spin button input validation
        
        implemented input validation for QtInstanceSpinButton
        and QtInstanceFormattedSpinButton.
        
        If a function to parse the text is set,
        QtDoubleSpinBox::validate uses that to validate
        the input, as the commit message mentions:
        
        > If a handler for parsing the text is set and
        > it can successfully parse the text, return
        > QValidator::Acceptable, otherwise
        > QValidator::Intermediate (allowing to continue
        > editing/typing).
        
        This implementation however assumes that the parser
        function will return a std::optional containing
        a value when the input is valid.
        
        That assumption is correct for QtInstanceFormattedSpinButton.
        For QtInstanceSpinButton however, there's also the
        case where no formatter has been set, in which case
        weld::SpinButton::parse_text returns TRISTATE_INDET
        (s. its documentation).
        
        So far, this resulted in QtInstanceSpinButton::convertTextToDouble
        - which was set for QtDoubleSpinBox::m_aParseTextFunction, i.e. as
        the function to parse the text - to always return an empty std::optional.
        
        As a consequence, the value wouldn't be accepted
        by QtDoubleSpinBox, e.g. for the following scenario
        since the above-mentioned commit when using the qt5 or qt6 VCL
        plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1:
        
        1) "Tools" -> "Options" -> "Advanced" -> "Open Expert Configuration"
        2) search for "LibreOfficeTheme"
        3) double-click on the config entry (of type short)
        4) in the spinbox, manually type a value of 2
        5) press Tab to move focus out of the spinbox
        
        Result: The manually typed value of 2 gets reset to
        the previous value (currently 0 by default) instead of
        taking over the new value.
        
        Fix this by extending QtDoubleSpinBox::m_aParseTextFunction
        to use the same semantics as weld::SpinButton::parse_text,
        i.e. return a Tristate value which allows to distinguish
        between the 3 different outcomes (parser set and value
        could be parsed, parser set and value could not be parsed,
        no parser set) and in case it returns TRISTATE_INDET
        (indicating that no parser is set), fall back to
        the logic in the QDoubleSpinBox base class to try to
        parse/validate the current text.
        
        Change-Id: Ic811dae10ecfd624e8f2e26022a61a95365152c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183713
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-04  Noel Grandin  <noelgrandin@gmail.com>  [083556bd17713bbbb1e7569b738c87dc3e93edf9]

        reduce object creation in SvNumberFormatsSupplierObj (tdf#147874 related)
        
        otherwise we create and destroy a ton of these in tight loops when
        processing large charts.
        
        Change-Id: Id9f5ef2bd5ea3b7d068dfd62a703b3bf11a5c100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183716
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [eeb8ca44ac7994c0552749e190a193a44c956769]

        tdf#147874 slow sheet switching with large chart2 (2)
        
        ExplicitCategoriesProvider is rather expensive to create, and we do it
        twice.
        
        So store it on the BaseCoordinateSystem object and share it, which means
        we only need to construct it once.
        
        This reduces switching time from 2s to 1s.
        
        Note that I am not sure that this is the best location to store this,
        the entire architecture of chart2 is a little opaque.
        
        Change-Id: Ic9dc9573f7495bcb76de14caa7cc7d5ad61d9ed1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183700
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [8611749d0acbf910a7003131e4419022eb4fe4bc]

        tdf#147874 slow sheet switching with large chart2
        
        split out the initialisation and exit early if possible. Takes the
        switching time from 11sec to 2sec for me.
        
        Change-Id: If31962e9603a14271a638da19a26ea1b050967d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183699
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [34cf82953ccd260a05a1c3838178ba50314e2eef]

        editeng: extract ImpEditView::ImplGetCursorRectAndMaybeScroll()
        
        ... to separate it from the VCL-Cursor/LOK logic.
        
        Change-Id: I60f533630e6c55e832d1471c1512d6651107d5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183310
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [8b4a7ea0ac0f26aeaa896cad39235bf2f8195841]

        svx: flatten WeldEditView::DoPaint()
        
        Change-Id: I411bcc24400a18fc64c901dba3a0cde0187786e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181678
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [a28db0efd2941f53d4aefaedbcbba9d5dd2f2df6]

        editeng a11y: Use usual 4 spaces to indent one level
        
        ... instead of 6
        
        Change-Id: I27585734069f76d7d535c01760d0bd2085f51051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183707
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-04  Miklos Vajna  <vmiklos@collabora.com>  [e435dc6ca1a898f4e806127257c9acc627c080cc]

        tdf#165941 DOCX import: fix unhandled exc while removing dummy para in table
        
        The bugdoc can't be opened in Writer but Word considers it valid.
        
        This went wrong in commit 97f9af714ea1c46e498fa99f7ca34fc1708d38a6
        (Related: tdf#125038 DOCX import: fix unexpected linebreak inside IF
        condition, 2019-10-30), because now we may have a range that is crossing
        a table of section boundary: this is a valid range for a field start/end
        in Word, but not in Writer.
        
        Fix the problem by handling exceptions from createTextCursorByRange() in
        DomainMapper_Impl::RemoveDummyParaForTableInSection(): we already
        assumed previously that the created cursor may be an empty reference,
        just the exception case was unexpected.
        
        The bigger problem is that Writer fields can't expand to multi-paragraph
        content while Word can do that, but that was a problem before the above
        commit, so is not addressed here.
        
        Change-Id: I718b702e68da5bf90eb4af95bb179d2e33abadc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183710
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [1886ecf7ee10cc51ca90fe1365e4a8ef2a1b6f27]

        use more concrete UNO in chart2
        
        Change-Id: Id71c919abb85039d7fdfdb334e505f293e530255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [75649dbc8de311c675ed4050affce3de556e623b]

        scripting: remove obsolete commented out code
        
        Since
        commit 6af846d0a13a8fb6e5153a0759e4952907bb86e5
        Author: Michael Stahl <mstahl@redhat.com>
        Date:   Sun Nov 25 16:03:47 2012 +0100
        
            scripting: pythonscript.py: adapt to Python 3
        
        Change-Id: I7b39f3b3c098ec3a07ee95bd3ca706d0fd0c9671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183704
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [99078d06e984f7596e57cb342671ccdd291ae176]

        tdf#85976, tdf#165678: sc: Add UItest
        
        Change-Id: I137d45babe4fc1b54ecda9ab32977035e38c998c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183701
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [79ed1d0ddab3813cfb92f5d0f486046fb880d07d]

        svx: factor out WeldEditView::PaintSelection()
        
        Change-Id: I51b71b20f6bb2b0e86611a052221f1e3785c84d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181677
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [a3a59876a48688d39e9057bad4d6c7ebb440ecea]

        editeng: factor out ImpEditEngine::UpdateSelection()
        
        Change-Id: Ia6f694a813ad30aadf159db0f75fb1a86e9663dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181676
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [46000e9db470c6d7735aac050dd5e944c79d9b38]

        svx,sw: when replying to comment, set parent ids immediately
        
        ... and not after insertion is already finished.
        
        This requires 3 new slots because SwWrtShell::InsertPostIt() takes a
        SfxRequest...
        
        Then SwInsertField_Data needs another different temporary representation.
        
        Open question is why does a comment need to have 3 different ids.
        
        Change-Id: Ie655c4f089240b8407c52288b2f96653299665c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183686
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bfa56c3cabcc4bf037606b4acae325a8a5fd966b]

        tdf#136540 - Prevent scrolling to cursor during deletion of annotations
        
        Change-Id: Id71030736233c39100b61dd95581dbd079c07c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183698
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-04-04  Marco Cecchetti  <marco.cecchetti@collabora.com>  [c43020cbab42df44fe375fecb52f3a70ab3efc34]

        slideshow: map motion animation to the correct animation node on export
        
        Change-Id: I292a37d0c0a08c601b844704ef514877f58cfcf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183696
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-04-04  Noel Grandin  <noelgrandin@gmail.com>  [c9bb5c1396671a146da218f288cfd77913f7ae8a]

        drop python2 compat code in generate-tokens.py
        
        which should speed it up a little too
        
        Change-Id: I7d78108392f6dd7e319289c97957979fadaae796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-04  Jim Raykowski  <raykowj@gmail.com>  [662e62e2ef71fdea754859246a81481f604f9ae4]

        tdf#162840 Hypenation Sidebar deck only looks good in gtk3 UI
        
        Makes other VCL plugins look better.
        
        Change-Id: Ic8fecadfc8612cec102e60bc9b6ae5923c169d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183451
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [024236a108c1a1abf3e815218f4777c05ab3a79f]

        gtk4: Include new header for Cairo format defines
        
        ... to adjust for
        
            commit 1aac139d504c9f7b60edeadba3c52a14524e5694
            Date:   Thu Apr 3 16:00:18 2025 +1030
        
                vcl: cairo: split cairo format defines into new header
        
        to fix build failures for the --enable-gtk4 build:
        
            /home/michi/development/git/libreoffice/vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:2201:24: error: use of undeclared identifier 'SVP_CAIRO_ALPHA'
             2201 |     sal_uInt8 a = data[SVP_CAIRO_ALPHA];
                  |                        ^
            /home/michi/development/git/libreoffice/vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:2202:47: error: use of undeclared identifier 'SVP_CAIRO_BLUE'
             2202 |     sal_uInt8 b = unpremultiply_table[a][data[SVP_CAIRO_BLUE]];
                  |                                               ^
            /home/michi/development/git/libreoffice/vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:2203:47: error: use of undeclared identifier 'SVP_CAIRO_GREEN'
             2203 |     sal_uInt8 g = unpremultiply_table[a][data[SVP_CAIRO_GREEN]];
                  |                                               ^
            /home/michi/development/git/libreoffice/vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:2204:47: error: use of undeclared identifier 'SVP_CAIRO_RED'
             2204 |     sal_uInt8 r = unpremultiply_table[a][data[SVP_CAIRO_RED]];
                  |                                               ^
            4 errors generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:339: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/unx/gtk4/salnativewidgets-gtk.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            make: *** [Makefile:301: build] Error 2
        
        Change-Id: I54c329fe9caa59ca223c16c2c7737201e4427ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183691
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [85bfc66f54934510b5c2f07ed0a1b8fe0db31823]

        tdf#74580 Simplify passing "Edit Filter Settings" to Filter Dialog
        
        Simplify passing the checkbox state of "Edit Filter Settings" to
        the Filter Dialog via ContextLayer.
        
        Change-Id: I6dd581a530de9e8634d515295d2dab978b1c8f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183646
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [72f62009c95bd9a70fc4be05999852d12e2402af]

        editeng a11y: Use OAccessibleComponentHelper for paragraph
        
        Let editeng's AccessibleEditableTextPara derive from
        OAccessibleComponentHelper to make use of the
        logic already implemented there instead of having to
        implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        The existing AccessibleEditableTextPara::getBounds
        implementations provide the necessary logic to implement
        OAccessibleComponentHelper::implGetBounds,
        so rename those accordingly (and drop the extra mutex
        guard, as the base class takes care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the base class.
        
        No change in behavior intended or observed in a quick
        test with text in Impress slides and Accerciser and Orca
        when using the gtk3 and qt6 VCL plugins on Linux.
        
        Change-Id: I5cb47eb9c6738f4bd7807cbeef260151437c0862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183681
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [5348c79e012ed68810fe3ed229c2bc12e7c7ed53]

        editeng a11y: Simplify AccessibleEditableTextPara::FireEvent
        
        * Make method non-const, which avoid the need to const_cast.
        * Just use `this` directly instead of calling
          `getAccessibleContext`, which returns a reference to `this`
          again.
        
        This also prepeare for turning AccessibleEditableTextPara
        into an OAccessibleComponentHelper subclass in an
        upcoming commit.
        
        Change-Id: I74526e47070979ce34e89c165843ca3a5a9b1f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183680
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [138bc16c9aac04def13843bb9bf6f18075a88c0f]

        editeng a11y: Let para manager dispose its child
        
        Instead of letting AccessibleParaManager dispose
        itself in AccessibleEditableTextPara::SetEditSource when
        called with a null edit source, let the AccessibleParaManager
        that created the paragraph and can therefore be considered the
        owner (see AccessibleParaManager::CreateChild) dispose it
        again in AccessibleParaManager::Release.
        This is consistent with how it also explicitly disposes
        all children in AccessibleParaManager::Dispose.
        
        This is the only place that calls AccessibleEditableTextPara::SetEditSource
        with a null param, so this change shouldn't change behavior
        in any way.
        
        Change-Id: I9d6ec8db69a789c18fd424e680624744b4913798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183679
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [2f2f3ab30cd7251fe0dbd31afc3e7117106f4452]

        editeng a11y: Deduplicate bullet text length calculation
        
        Add a helper method AccessibleEditableTextPara::GetBulletTextLength
        instead of duplicating the same logic 6 times in different places.
        
        Change-Id: I8f9fa307fe52c84ca0200126061c5a957c7e02ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183677
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [eeb20233980c1b5262ce21f99549f0b0645ae9d0]

        editeng a11y: Simplify AccessibleStaticTextBase::GetParagraphBoundingBox
        
        Change-Id: I0bcc4d5ee3c6d9f976688cb25e7b6a3234d78da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183676
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [fbdd3714acb4c6f1253da14662016131e2fd0006]

        svx a11y: Don't fall back to space character for shape a11y description
        
        Don't use " " (i.e. a string containing a single
        space character) as the fallback for the accessible
        description of a shape, but use an empty string instead.
        
        Adjust the existing Impress a11y test accordingly, which
        included the description reported so far in the
        expected output, but that's not the purpose of the
        test.
        
        The text was previously extended in
        
            Change-Id: I92a781aaf9c05df6264e64a59db775495fa5671c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Apr 2 16:53:58 2025 +0200
        
                sd a11y test: Add a shape to layout test
        
        to ensure the logic for testing a11y descriptions
        keeps being used even with this new commit in place.
        
        Also adjust a CppunitTest_sw_a11y dialog test accordingly.
        
        Change-Id: If4bd88cf5e2dd48c68fa93a69871d0bcfbee9424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183675
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [db40165c039d8bb9df912d9fdf605403f9115569]

        sd a11y test: Add a shape to layout test
        
        Extend the existing layout test by adding a shape object
        into the document.
        
        The shape has a name of "MyRectangle" and a description/Alt text
        of "Some Rectangle" set and contains the text "Text inside Shape".
        
        Relevant diff in the fodp file for the new shape:
        
            +    <draw:custom-shape draw:name="MyRectangle" draw:style-name="gr4" draw:text-style-name="P11" draw:layer="layout" svg:width="6cm" svg:height="4cm" svg:x="6cm" svg:y="10.5cm">
            +     <svg:desc>Some Rectangle</svg:desc>
            +     <text:p text:style-name="P10">Text inside Shape</text:p>
            +     <draw:enhanced-geometry svg:viewBox="0 0 21600 21600" draw:type="rectangle" draw:enhanced-path="M 0 0 L 21600 0 21600 21600 0 21600 0 0 Z N"/>
            +    </draw:custom-shape>
        
        (The rest is mostly noise from opening + resaving the existing
        document.)
        
        The main reason to add this is to have something to
        test the accessible description.
        Currently, the expected test output includes a test
        for the a11y description of various shapes being
        " " (i.e. a single space character, see the implementation
        in AccessibleShape::getAccessibleDescription that falls
        back to this), but that will be changed to an empty string in
        an upcoming commit.
        
        The newly added shape will keep having a non-empty
        description, so that logic can still be tested.
        
        Change-Id: I92a781aaf9c05df6264e64a59db775495fa5671c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183674
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [e8d45fe35e6abb01d235aba263f6ff41a3efd5ed]

        editeng a11y: Drop custom WeakCppRef, use unotools::WeakReference
        
        Use the existing unotools::WeakReference instead of the
        custom WeakCppRef template class to hold weak references
        to the AccessibleEditableTextPara objects in
        AccessibleParaManager.
        
        An AccessibleEditableTextPara forward-declaration is not
        sufficient to use
        unotools::WeakReference<AccessibleEditableTextPara>, so
        re-arrange includes/forward-declarations a bit.
        
        Drop the now unused WeakCppRef.
        
        Change-Id: I54553059a7cb36515109573c5b22d73738b1c46f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183672
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [d6a34a8c5b20ebe31ff693465b1343c2210c52c5]

        editeng a11y: Use unotools::WeakReference for bullet
        
        Replace use of the custom WeakCppRef template class
        for AccessibleEditableTextPara::maImageBullet by
        unotools::WeakReference which provides the
        same functionality (a weak reference and access
        to the the concrete implementation class).
        
        Change-Id: I333f467caeb4925d718313e679507f45c9c96e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [6934cf941800ee9fa222a128f8730692ea1c4ad8]

        editeng a11y: Simplify AccessibleParaManager::CreateChild
        
        Both callers are only interested in the XAccessible
        in the returned std::pair, so let the method only
        return that instead of the pair.
        
        Drop the now unused AccessibleParaManager::Child typedef.
        
        Change-Id: I2b271de7b3e668be982b01bd183e0c39d47f444d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183670
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [4397edc75dab602f0963731d9a9fa6b902c8622b]

        editeng a11y: Replace auto and adhere to naming scheme
        
        This makes more obvious that the child is a
        rtl::Reference<AccessibleEditableTextPara> here, which
        is otherwise a bit harder to see with all the typedefs etc.
        involved.
        
        Change-Id: Id9d0c2457813b7e0fed34b0ce8fe52553ef6a39d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183669
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [1f91b8e0cbdc6befce53465e59393bb8259fd56b]

        editeng a11y: Inline AccessibleParaManager::ShutdownPara in only caller
        
        Change-Id: I27f86a476b6c4c7c90f4c26baff30cc1a525d9b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183663
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [037896a309b7c386be0427ba2f05bb0d3da874dd]

        editeng a11y: Replace ReleaseChild class with lambda
        
        Change-Id: I0b036aebb481e3fe45fcad890a7f2227bc734142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183662
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [a39bc80a3a7a3634fdccefaeda8792f7a7689368]

        editeng a11y: Drop AccessibleStaticTextBase::mpThis etc.
        
        AccessibleStaticTextBase::mpThis is only used to
        pass it to Exception ctors, so it seems a bit
        overkill to have to manage it for that purpose.
        
        Drop it and the corresponding setter
        AccessibleStaticTextBase::SetEventSource.
        Its doc says that the interface is also used
        as the event source for a11y events, but that's
        not actually the case.
        
        Also drop ScAccessibleCell::Init which now no
        longer needs to override the base class implementation,
        ScAccessibleCellBase::Init.
        
        Change-Id: Ide64cf2e59bfb9ae7df41171cc36e1df0c86eb9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183628
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [385b1fa3d3e18e1be5650cb7047a3eaad1e0426d]

        editeng a11y: Merge AccessibleStaticTextBase{,_Impl}
        
        Merge AccessibleStaticTextBase_Impl into
        AccessibleStaticTextBase.
        
        Further simplification will be possible in
        upcoming commits.
        
        Change-Id: I4f0067c2cf1cb5b2f464b8075bc4a64f44d7babc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183627
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [9b892757d2ccae1fe74e616158f378c31a67ae6d]

        editeng a11y: Drop extra indentation level
        
        Change-Id: I5f2d99730cfda9490c3fa9fa43242e0d5219ca82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183626
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [053365d29e28af88b173ed8594649ca70c17ce6b]

        editeng a11y: Drop paragraph's a11y description
        
        So far, "paragraph <number>" and the (start of) the
        paragraph text were reported as the accessible description
        of the paragraph.
        
        This resulted e.g. in Orca saying something like
        "Paragraph 0: Hello world Hello world" when moving cursor
        to a paragraph containing the text "Hello world" in Impress,
        because both, a11y description and the text reported via the
        AtspiText interface were reported.
        
        Drop the a11y description, which is also consistent with Writer
        where no description is reported. The
        
            // (writer takes first sentence here, but that's not supported
            // from EditEngine)
        
        comment dropped along with this commit looks outdated.
        
        The fact that this is a paragraph is already reported via the
        a11y role and the text is reported via the XAccessibleText
        interface. (The information which paragraph this is could
        be retrieved by checking the children of the paragraph's
        parent, so if an AT wanted to report that, it could
        implement corresponding logic on the client side.)
        
        Adjust the Impress a11y test originally added in
        
            commit 6185a27db46bf5cba404e669eaf3a1c78f4a8607
            Author: Colomban Wendling <cwendling@hypra.fr>
            Date:   Sun Jul 31 17:20:03 2022 +0200
        
                tdf#150064 Add tests for a11y tree order
        
                Check the tree order is stable across loads and page switches.
        
        accordingly, which included the description in
        the expected output, but that's not the purpose
        of the test.
        
        Also adjust the sw a11y test
        (test::AccessibleTestBase::BasicTestFontworkDialog) accordingly.
        
        Change-Id: Ifbc1a15a976d7488396630c6bc3c9e42ba26ccc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183625
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [64ab00120778f2d6d41998fe8485cd127fe7fe80]

        editeng a11y: Rely on XAccessibleContext implementing XAccessiblecomponent
        
        Only query the XAccessibleContext of the parent
        accessible for the XAccessibleComponent interface,
        not the XAccessible first and the XAccessibleContext
        only as fallback.
        
        As far as I understand it, the XAccessible is only there
        to allow retrieving the XAccessibleContext using
        XAccessible::getAccessibleContext and all other logic
        should be implemented in the class implementing
        the XAccessibleContext interface.
        That's also what the platform bridges rely on, see
        e.g. `getComponent` in vcl/unx/gtk3/a11y/atkcomponent.cxx.
        
        If there's any case where this is handled differently,
        that one should likely be adjusted to match the pattern
        used everywhere else, too, instead of having special
        handling here in AccessibleEditableTextPara.
        
        (In most cases, it's the same class that implements both,
        the XAccessible and the XAccessibleContext interface
        anyway.)
        
        Change-Id: Ic03c11f8406213f5f44074e39fe867b4e8b93dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183624
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3c67c1e3439fc46883b8cc32f9c541cfd9998a0]

        use more concrete UNO in reportdesign
        
        Change-Id: I4ad63bbc248c6561b6166131e1ed87baf625af3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183678
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [403b1dd4808f72a2cd5cd6397f1610d41882eb01]

        wina11y: Drop unused includes
        
        Change-Id: I95f73355321b5bf9e9cb14d2bd350a49c1a13a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183683
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [5b9f867b91fdb7b9c1fa2c0d01ad6fe68180f867]

        wina11y: Clean up listener creation a bit
        
        * AccObjectWinManager::CreateAccEventListener always returns
          non-empty reference, so replace if check by assert.
        * Use "x" prefix for rtl::Reference.
        * No need to explicitly have a uno::Reference<XAccessibleEventListener>,
          just pass the rtl::Reference.
        
        Change-Id: I0c45f70670a21dbd879c3e4c8c093f155722155a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183682
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  László Németh  <nemeth@numbertext.org>  [5a905c47ec4b9afeec97eb91f6d899bb05da8483]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fcff6cf389b6bf14fae3c796578634b00fb22a0c
          - tdf#165984 sw: document Text Flow -> Paragraph/Column/Page/Spread end zones
            
            Follow-up to commit 7d384fb1c232f7aa720436bc68dc1de334bf7297
            "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zone".
            
            Change-Id: Ib045b4a22bffdfa445a01ecac46bc2dca63acc02
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183648
            Reviewed-by: László Németh <nemeth@numbertext.org>
            Tested-by: Jenkins
            
2025-04-03  László Németh  <nemeth@numbertext.org>  [5daab76058e38ae16180b1bea239161b7c8be274]

        tdf#165984 sw: don't apply hyphenation zone at disabled hyphenation
        
        Fix unit tests testTdf132599_column and
        testTdf132599_page_in_last_column.
        
        In widorp.cxx, end zone is calculated by the inheritance of
        the hyphenation zone, and as a regression, it was applied in
        the last line enabling hyphenation disabled by hyphenation-keep
        and hyphenation-keep-type.
        
        As an optimization, skip also frame update of the last line, when
        end zone is not different from the hyphenation zone, i.e. when
        the last line has already had correct line break.
        
        Regression from commit 7d384fb1c232f7aa720436bc68dc1de334bf7297
        "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zone".
        
        Change-Id: Ia54c9164d5297b5a73649259b4a25a808ece68e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183673
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [27ef70b06503d763e3a7de064fac96fa0771ec71]

        Fix typo
        
        Change-Id: I13c73a649a01bf18a94898366e18abc805c108fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183661
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [c9057566e3e5691011156f6332c228060c36ac89]

        libjpeg-turbo: upgrade to 3.1.0
        
        Downloaded from https://github.com/libjpeg-turbo/libjpeg-turbo/releases/download/3.1.0/libjpeg-turbo-3.1.0.tar.gz
        
        Change-Id: Ic9e8c7e4520073da09abf27866aa3cff0b6a0c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183617
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [295fee0f78c002ca20708fdfd57d52b0e4ce0d87]

        tdf#164969 tdf#165297 Disable theming by default
        
            commit 924c7de80afa47a93705e5d073c35f2d81f4ed5a
            Date:   Wed Dec 25 23:13:47 2024 +0530
        
                tdf#164393 [API CHANGE] Make the "Automatic" theme Customizable
        
        had - among others - enabled theming by default, which
        results in incorrect colors being used with at least
        GTK and Qt based VCL plugins on Linux in the default
        configuration, i.e. without any custom color having
        been set anywhere.
        
        As discussed in [1], disable theming again by default, by
        setting the default for
        `officecfg::Office::Common::Appearance::LibreOfficeTheme`
        to 0 again.
        
        This implies that custom colors for widgets cannot be
        set in "Tools" -> "Options" -> "Appearance" by default
        anymore.
        In order to set custom colors for those, the above-mentioned
        setting can still be set to 1 in the expert settings
        (in which case colors can be set for the "Automatic"
        theme also, which was implemented in the above-mentioned
        commit).
        
        A larger rework of the theming code is in progress,
        see Sahil's WIP Gerrit change at [2].
        
        [1] https://gerrit.libreoffice.org/c/core/+/183490/comments/efc32644_52e556d5
        [2] https://gerrit.libreoffice.org/c/core/+/183574
        
        Change-Id: I896b7b02a26038f094e044b56f32dbc01cf99ab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183490
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-03  Miklos Vajna  <vmiklos@collabora.com>  [dcd3427149c33852428b4198c22f6f858125c294]

        cool#11357 sw redline reinstate: add to the context menu for text
        
        Right click on a tracked insert, you can accept and reject the change,
        but not reinstate it.
        
        The two extremes would be to not allow reinstate there at all and to add
        all of reinstate, reinstate-and-next and reinstate-all to the context
        menu.
        
        Be consistent with accept/reject and only add
        .uno:ReinstateTrackedChange to avoid cluttering the context menu too
        much.
        
        Change-Id: I8f05eedc066a67327e0c7ad25a0e6480867d872b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183664
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [677568200f81a2c9921e08d18169d6103e01fe61]

        ofz#408042967 reduce allowed font height when fuzzing
        
        Change-Id: I2bd0cae38c588539db206c64f8907b0b944903fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6fa4e0559358e82222df5bb0f130f90f3799169]

        make unit tests compile with --enable-cairo-rgba
        
        they don't pass yet
        
        Change-Id: Id66d9a257bc8a3d519f2b8377fd13873ad8337f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8b263f3a0bdc87790267ee6f8a59c3fe90f08e29]

        SAL_INFO when vnd.sun.star.expand is considered exotic
        
        As discussed in the appertaining comments at
        <https://gerrit.libreoffice.org/c/core/+/176645/3#message-1209b271ac4a330311eb90b2d6c16bbff57842ef>,
        836d73a65180d89a077e36457f1f3aa1698c2058 "consider VndSunStarExpand an exotic
        protocol" may have been a bit brittle:  "[vnd.sun.star.expand] originated from
        the UNO configuration infrastructure, but indeed hard to tell if it then found
        reasonable uses outside that area.  I guess the best we can do is get it in,
        maybe mention it in the release notes, and see."  Turns out it is used at least
        to handle %origin% in extensions, where that change caused
        <https://bugs.documentfoundation.org/show_bug.cgi?id=165851> "Installing custom
        default template via extension stopped working".
        
        So to be better prepared to track down potential further breakage caused by that
        change, note cases where it (legitimately or problematically) hits with a
        SAL_INFO.
        
        Change-Id: If742f4f0b0f223e5acf346d294567ccc09eaf49b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183659
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-03  Aron Budea  <aron.budea@collabora.com>  [1aac139d504c9f7b60edeadba3c52a14524e5694]

        vcl: cairo: split cairo format defines into new header
        
        Change-Id: I1d9b05c600cea860df0596d63e817b30347f563c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183651
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-04-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c79209694d58abdbaf8c28b5e8cc690a937c1cc]

        curl: upgrade to 8.13.0
        
        * Add external/curl/undefined.patch.0 to handle
        https://github.com/curl/curl/issues/16925
        
        Downloaded from https://curl.se/download/curl-8.13.0.tar.xz
        
        Change-Id: I5555cdee13f7660b52ac4a513969dfde1563bf56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183614
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [274f1fb5f43ff416d3262382cf4edfd6d2e72ee0]

        Fix some --without-system-jpeg builds
        
        ...like <https://ci.libreoffice.org/job/lo_daily_tb_linux_wasm/1026/>,
        
        > wasm-ld: error: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/workdir/LinkTarget/StaticLibrary/liblibjpeg-turbo.a(jchuff.o): undefined symbol: jpeg_nbits_table
        
        apparently broken with 451a7e9c435f2c76a718995faf52a59fd3a89127 "libjpeg-turbo:
        upgrade to 3.0.4".  But just enabling the missing
        workdir/UnpackedTarball/libjpeg-turbo/jpeg_nbits.cxx then caused
        
        > workdir/UnpackedTarball/libjpeg-turbo/jpeg_nbits.c:29:27: error: expected ';' after top level declarator
        >    29 | const unsigned char HIDDEN jpeg_nbits_table[65536] = {
        >       |                           ^
        >       |                           ;
        
        so tweak external/libjpeg-turbo/jconfigint.h a bit more (cf.
        workdir/UnpackedTarball/libjpeg-turbo/CMakeLists.txt and
        workdir/UnpackedTarball/libjpeg-turbo/jconfigint.h.in).
        
        Change-Id: I3ca1c78b467fb9f1d7584799591dbb8a797320ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3f42583a772667f88715ed408be89b927cefb53b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96afb0d08461aca9cfa4470f2cff634c88d915f1
          - Add info on saving only active sheet.
            
            Change-Id: I9880cdc48472e801792da45fdd1bfd5adaa007d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183598
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da851ac38150612a1048cc1a5075d58319bc1b7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8e9369e739ce9119af7a662e46b662804f7c1d9
          - tdf#165758 Escape CGI comma for xapian template
            
            Change-Id: I3ebd50f3a12c9eebab5df2359b9a2bdb85c239ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183647
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-04-03  Justin Luth  <justin.luth@collabora.com>  [74f67cd1c3ef1bb38bf3de6b3a888d9c94227957]

        tdf#165047 sw mso-compat layout: always honour contextualSpacing
        
        This improves 25.8 commit ae7900dd42a65aaf60df6b21b9ad511496b209d9
        tdf#164095 sw: fix missing top margin on paragraph
                       after changing page style
        which was backported to 24.8.5.
        
        The problem is that you can't just simply apply the top margin.
        Even though it may be across a page break,
        or even in a different section,
        the fact that the previous paragraph is the same style
        means that we simply don't add any upper spacing to this paragraph.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf165047_contextualSpacingTopMargin
        
        Change-Id: I12712e5421e20ea0757c59029c6890bff9d81b94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183643
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-04-03  Justin Luth  <justin.luth@collabora.com>  [9a8eb2dc17435d290f482070dd5f20f538b5b68b]

        tdf#165047 sw mso-compat layout: always consolidate top margin
        
        This improves 25.8 commit ae7900dd42a65aaf60df6b21b9ad511496b209d9
            tdf#164095 sw: fix missing top margin on paragraph
                           after changing page style
        which was backported to 24.8.5.
        
        The problem is that you can't just simply apply the top margin.
        Even though it may be across a page break,
        or even in a different section,
        the already-applied, previous paragraph's bottom margin
        needs to be "removed" from this paragraph's top margin.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf165047_consolidatedTopMargin
        
        Change-Id: I1ca5a6173cc5ae5a06adaf38a3292f556a81a48d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183619
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-04-02  Aron Budea  <aron.budea@collabora.com>  [69162f01d3449e92e9a8b76c8a09378e1aef8a56]

        tdf#166005 vcl: cairo: use correct order in RGBA case
        
        When built with --enable-cairo-rgba parameter, green
        and blue colors were swapped.
        
        Likely since ff46c8bf598481ae37022414f3495c1e9385eb7c,
        but these macros are already defined in
        cff87aac4ec77957569377d690bc4aa8f7146e0d.
        
        Change-Id: Ia1a382c66e8e5ceb9d3d7eaa0f0d6287a6870cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183642
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-02  Mike Kaganski  <mike.kaganski@collabora.com>  [6401be9549d70b50ef43002b4c62f2527a0be1a8]

        Drop duplicating line
        
        Was this way since commit a91ae4acbf2f37a638cb63ede6896184b99c6b5f
        (INTEGRATION: CWS os109 (1.27.110); FILE MERGED, 2008-01-29).
        
        Change-Id: I35e30591bfc8736191e929d83f132b9872e28661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183640
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-04-02  Jaume Pujantell  <jaume.pujantell@collabora.com>  [c77b88e150642c7e715882ef2f7c036f35a349cc]

        cool#11497 lok: calc: update separators per locale
        
        On LOK, multiple locales might be in use at the same time, so skipping
        the update of native symbols and separators on load is not viable.
        
        I've also tested the original bug for which this code is skipped and it
        seem to not affect online in the same way.
        
        Change-Id: Ic2e6e329c9bdfb55f6a5fdd540d102c05ac168cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183594
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit d6135b62ee9716f120e6ba347503cc222e364829)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183630
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-04-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f13305178c1bf88dffceb42ec15d0944b808a5c]

        poppler: upgrade to 25.04.0
        
        After 032d035220702523cf10d924fd436c9e6c83d24c
        "Enforce error checking on stream::reset" the return from reset
        has to be checked, otherwise it fails with
        error: ignoring return value of ‘bool ImageStream::reset()’, declared with attribute ‘nodiscard’ [-Werror=unused-result]
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.04.0.tar.xz
        
        Change-Id: I5c6022b11c307f4293e4b2ea566e811053e3ab6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183632
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc6442d4459074ce95559d48a28010def5234e1c]

        fix gdb-core-bt
        
        I messed up in
            commit 5440262dd2fc58025702b7172cebe6b9f1c466ec
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 26 16:04:32 2024 +0200
            Get at least some information out of coredumpctl
        
        Change-Id: I9e5c035c371114077f02f8adef432f742d98b255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183638
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ff3c48c213332e2bb617de4cda6ebc4994906f92]

        Fill in the flatpak appdata screenshot captions
        
        ...that had been left empty when they had been introduced in
        <https://git.libreoffice.org/dev-tools/+/f96d7afbf282e5621697aca84177e42fe2cc2255%5E!>
        "Adapt org.libreoffice.LibreOffice.appdata.xml".  (This should avoid the warning
        "appstream-screenshot-missing-caption: One or more screenshots are missing
        captions in the Metainfo file" from `flatpak run --command=flatpak-builder-lint
        org.flatpak.Builder repo repo`, see
        <https://docs.flathub.org/docs/for-app-authors/submission#run-the-linter>.)
        
        Change-Id: Ib1f3a629cbb19229408f8d476a37385678a607d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183634
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c36f2356511d36c3d5c8cf6ffbdad308c9c4120b]

        Drop .desktop suffix from flatpak appdata id
        
        ...that had been like that (for reasons that escape me now) ever since
        <https://git.libreoffice.org/dev-tools/+/cb6ca493be62b59aa16c7ec6a051e594a1d92f18%5E!>
        "Create a single-app LibreOffice.flatpak", but which causes an error
        "appstream-id-mismatch-flatpak-id: The ID tag:
        org.libreoffice.LibreOffice.desktop in Metainfo does not match the FLATPAK_ID:
        org.libreoffice.LibreOffice" from `flatpak run --command=flatpak-builder-lint
        org.flatpak.Builder repo repo` (see
        <https://docs.flathub.org/docs/for-app-authors/submission#run-the-linter>)
        
        Change-Id: I0823020e6de20930b1ef8d5205fcf49ac2319a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183633
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-04-02  Miklos Vajna  <vmiklos@collabora.com>  [7d702ebbfcda41ce2972e30b2a1e493c320df67c]

        cool#11357 sw redline reinstate: fix undo count & string for multiple redlines
        
        Open a document with insert redlines, reinstate, check the undo stack,
        it says it has multiple undo actions.
        
        This is technically true, but the user did a reinstate, which happens to
        be implemented as deletions.
        
        Fix the problem by using SwUndoId::REINSTATE_REDLINE in
        SwEditShell::ReinstateRedlinesInSelection(), too.
        
        This fixes both the undo count (now one reinstate results in one
        user-visible action) & the string to say reinstate.
        
        Change-Id: I8f59fa6334876ef1bd860b7aa41c0ed7d35cbf31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183623
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-02  Michael Stahl  <michael.stahl@allotropia.de>  [e8cbd4f14a3086e0f148f0b39f32f7101c25b012]

        sw: use same line height as Word for paragraphs empty due to hidden text
        
        If paragraphs are merged by hidden paragraph end markers, and all of the
        text in the paragraphs is hidden by character formatting, then Word will
        use the formatting of the end marker of the last paragraph to calculate
        the line height; Writer would use the formatting at the position where
        the last portion of hidden text ends, which may be in an earlier
        paragraph.
        
        Change-Id: I1e8c5676d7330c383521755c736828fdc42e4217
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183622
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-04-02  Michael Stahl  <michael.stahl@allotropia.de>  [40f093ae2c4a6b6a3178db7a0b8be384dc75ef04]

        solenv: gdb: add Region prettyprinter
        
        Works for RegionBand, which is the common case apparently.
        
        Change-Id: I1b26f6ff8486094003685522ed23e44c2040db6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183621
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [12df2ac0b0a4cba7ed8977f837e9bb8840ba0aa0]

        dont draw to alpha layer if draw to bitmap layer fails
        
        Change-Id: I9ae4e552bf16dfb53b7d0626d66252e4e8929698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183616
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [e7b162d9576ad34f9150177d4922dcb6b7f84b76]

        postgresql: fix arm64 build
        
        Change-Id: I6ca6606c53f1e3f9c6f73292f40dcae0ee1c5a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183615
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-04-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [726099e511da95761500f8a70714c84b585d4faf]

        slideshow: reset visibility of primitives after rendering
        
        If the visible flag is not reset to true, it may be used outside
        of slideshow rendering.
        
        Change-Id: I42589b75c85d6e24af65a4d910bec4ac0c1a45e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183611
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [412da215c1cb7283b121fa6e9332c3fb2b76a1f4]

        cid#1645566 Dereference null return value
        
        Change-Id: I27846372fd28aaba66b726e9838d1e674c2f05be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183612
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-02  Michael Weghorn  <m.weghorn@posteo.de>  [899064be931ec4bb0cd5f32f60773980470e18a2]

        sw: Resave notebookbar.ui with glade 3.40
        
        ... to minimize the unrelated diff whenever the file gets
        edited in glade next time.
        
        However, for now manually undo misc changes like automatically added
        
            <property name="can-focus">False</property>
        
        for GtkToolButton objects as I'm not sure whether those might
        have any side-effect (so might be best to handle separately
        instead of having it in a change mostly changing underscore
        to hyphen).
        
        Suppress critical gla11y warnings like
        
            sw/uiconfig/swriter/ui/notebookbar.ui: FATAL WARNING: 'GtkMenuItem' 'Menu-Extension-PackageManagerDialog' does not have its own label
        
        as false positives, because labels for Notebookbar items are
        set in C++ code, not the .ui file.
        
        This .ui file is used for the Notebookbar in Writer
        when "View" -> "User Interface" is set to "Tabbed".
        
        Change-Id: I543b692f1d26404b0def59dfb8b203c7cbb1dbe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183609
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bf25073c50a8f1efe9fb52630084274300212d1]

        cid#1645567 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I933b54db23a084a8a3d9883b5ec0aa602dad8ef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183610
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-04-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [451a7e9c435f2c76a718995faf52a59fd3a89127]

        libjpeg-turbo: upgrade to 3.0.4
        
        * Add external/libjpeg-turbo/UnpackedTarball_libjpeg-turbo.mk
        to handle different undefined references errors
        
        Downloaded from https://github.com/libjpeg-turbo/libjpeg-turbo/releases/download/3.0.4/libjpeg-turbo-3.0.4.tar.gz
        
        Change-Id: Ib915b3e58d16b049cf6403a011da061fbf12a7d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180502
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-04-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e37b3c6c2e794222517f85007289ed52c605b2e5]

        Fix typo
        
        Change-Id: I4a60ab368d1decfa0c2b5075bb3aa76400a56936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183608
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-04-02  László Németh  <nemeth@numbertext.org>  [d0eaf32858f92761e23acb0155d56514af246a51]

        tdf#165984 offapi: document inheritance of end zones
        
        Document inheritance of the previously added paragraph
        properties:
        
        com::sun::star::text::ParaHyphenationZoneAlways
        com::sun::star::text::ParaHyphenationZoneColumn
        com::sun::star::text::ParaHyphenationZonePage
        com::sun::star::text::ParaHyphenationZoneSpread
        
        Follow-up to commit 7d384fb1c232f7aa720436bc68dc1de334bf7297
        "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end
        zone" (where the new paragraph properties were introduced).
        
        Change-Id: I90e275472e487a566b8e9cbb3fe511ec1e1e7874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183603
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-02  László Németh  <nemeth@numbertext.org>  [4e509260aa892ae14b447d0f915f4875e9a1fc26]

        tdf#165984 xmloff: don't export default end zone value "no-limit"
        
        They inherit the value of the hyphenation-zone or their
        ancestor (paragraph -> column -> page -> spread), so no need
        to export the default value "no-limit".
        
        Follow-up to commit 7d384fb1c232f7aa720436bc68dc1de334bf7297
        "tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end
        zone".
        
        Change-Id: I50a3bb9801402b000fe9861e592958a946953056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183602
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-02  László Németh  <nemeth@numbertext.org>  [7afd5aa47cda6200d259d025163a207b80068622]

        tdf#165354 cui: gray out Move Line at disabling hyphenation
        
        Follow-up to commit 698b38a18f5f70fd8d50968bc50951aba7085175
        "tdf#165354 sw cui: implement HyphenationKeepLine – part 3".
        
        Change-Id: I5cff4f280a1166ddd42df25fc53ab1f2ee0dc588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183601
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [503d988fc6cfe3315a60d640acf315fca05d206d]

        Fix typo
        
        Change-Id: If77ca9754acd0010edb2810dfaecd511d51add29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183559
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-04-02  knordback  <kurt.nordback@collabora.com>  [a0dd9ce966ca0b027262bdd077198973314efcf0]

        tdf#165742 Step 1: Introduce chartex namespace in parser and export
        
        This is a subtask of tdf#165742: Chartex charts are lost on input from OOXML and re-export.
        
        Add the chartex namespace to the list of supported schemas
        
        Change-Id: Ie98d316c6c8b15053ae58c474d7552352af1b0d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183457
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-04-02  Andras Timar  <andras.timar@collabora.com>  [967ff0c7b9d2943ca8cd4045d7037543feeeb67c]

        typo: Onine -> Online
        
        Change-Id: I6fd8350e74a63d8b8919c781b98698b4cbac92ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183600
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-04-01  Noel Grandin  <noelgrandin@gmail.com>  [4cf48d3c9f1c44a9fc9cdedefd638a54c92030e5]

        macos and pch still not happy with clang-17
        
        Change-Id: I0f2d8028916d360bcf1dfdf6327a4de6ad053ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-01  Noel Grandin  <noelgrandin@gmail.com>  [30dda57ffcddf8ec1981c589ce3c5df63e9e1054]

        remove SAL_WARN from BufferedDecompositionFlusher
        
        now that this has stabilised, I don't need it anymore
        
        Change-Id: Ibadd043bb11f6070ee66637e3eb0174c9bbe7a63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183596
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [911609a595728f304dfe592bd290c79d2d1ef436]

        cid#1645558 silence Overflowed constant
        
        Change-Id: I311ede3b822c2e1ec20bba3d1b3bba83381db70d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183579
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-01  László Németh  <nemeth@numbertext.org>  [7d384fb1c232f7aa720436bc68dc1de334bf7297]

        tdf#165984 sw cui xmloff: add Paragraph/Column/Page/Spread end zone
        
        Add new hyphenation options to adjust hyphenation, like DTP software do
        in accordance with typographic requirements:
        
        – Paragraph/Column/Page/Spread end zone spin boxes to Hyphenate Across
          section of Text Flow pane of paragraph settings;
        
        – loext:hyphenation-zone-always, loext:hyphenation-zone-column,
          loext:hyphenation-zone-page and loext:hyphenation-zone-spread
          ODF extensions;
        
        – widorp.cxx, guess.cxx: handle Column/Page/Spread end zones;
        
        – guess.cxx: handle Paragraph end zone (without portions, yet).
        
        According to their typography, languages with long words need better
        adjustment of line break of the last full paragraph/column/page/spread
        lines, than simply disabling hyphenation by the recent ODF hyphenation-
        keep or its equivalent MS Word OOXML extension. DTP software use
        paragraph and column/page/spread end zones to adjust the hyphenation
        zones in the last lines, for example, setting Column end zone to the
        150% percent of the Hyphenation zone, resulting less hyphenation, also
        less short words parts at the end of the columns, pages and spreads,
        increasing readability.
        
        Note: the default OOXML hyphenation zone 18 pt (or its MS Word variants,
        for example 21.25 pt) disables single letter or narrow 2-letter (li-,
        ﬁ-, i.e. fi ligature) hyphenations at 12 pt font height. Setting 27 pt
        for Column end zone, all 2-letter hyphenation is disabled in last lines
        of columns and pages.
        
        Note: textflow.ui needs multiple adjustment definitions for correct work
        of the multiple spin boxes.
        
        Change-Id: I37bbb4da30de0ec75eb8636f70d8e16588c56ed1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183565
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [890d7b1b7f32c4e7e1ea0f4ae5ced14e336ad1f2]

        Resave taborder.ui with glade 3.40
        
        Sample steps to trigger the dialog:
        
        * start Writer
        * ensure "Form" -> "Design Mode" is enabled
        * select "Form" -> "Check Box"
        * insert multiple check boxes into the document
        * "Form" -> "Activation Order"
        
        Change-Id: I1ffda2a385f66024922e343bb131ec65fe37690c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183588
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [35babbeeaeb1f7cda73f19f0c1e6e3549f59a19c]

        tdf#130857 qt weld: Support "Tab Order" dialog for form controls
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can e.g. be triggered like this:
        
        * start Writer
        * ensure "Form" -> "Design Mode" is enabled
        * select "Form" -> "Check Box"
        * insert multiple check boxes into the document
        * "Form" -> "Activation Order"
        
        Change-Id: I2f9593b92ca13c097435785cd13245795ec07cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183587
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [fdad3dd5a9c5e524233c497af01ebb16cf32136e]

        tdf#130857 qt weld: Implement QtInstanceTreeView::swap
        
        Check whether any of the rows to be swapped
        are selected before removing/reinserting them,
        and restore that selection again in that case.
        
        This method is used by the "Form" -> "Activation Order"
        dialog in Writer, for which support will be declared
        in an upcoming commit.
        
        Change-Id: If94a6bb2758d4a0f08574db76b963047cfe7c128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183586
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [b08ff27d8a5f5801cf7531b0f0630cfb2f84d028]

        tdf#130857 qt weld: Select whole tree view row
        
        weld::TreeView::select only takes a row number.
        Select the whole row, not just the first cell
        in that row.
        
        This e.g. makes a difference when using the
        "Move Up" button in the "Form" -> "Activation Order"
        dialog once support for that dialog is declared
        (which will happen in an upcoming commit).
        
        Change-Id: Ib5d2ce5de02f2d4e552e28163ed978176be466ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183585
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8d9a82899e9d29510c46a298e3a5da6ac23f6407]

        slideshow: need to set the page background color to the outliner
        
        This is needed or else we don't correctly determine and set what
        the auto color is for a particular page, which has the result that
        sometimes we set the text color to white where it should be black
        and probably also vice-versa.
        
        Change-Id: If17a008a49fbdd87e6bbb5299fe8efe506165a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183590
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-01  Miklos Vajna  <vmiklos@collabora.com>  [fbf9465e2bc9f878723674d1eff13e0c69656057]

        cool#11357 sw redline reinstate: fix undo string for a single redline
        
        Open a document with an insert redline, reinstate, check the undo stack,
        it says we have a "delete" on it.
        
        This is technically true, but the user did a reinstate, which happens to
        be implemented as a delete for inserts.
        
        Fix the problem by adding a dedicated SwUndoId::REINSTATE_REDLINE and
        use that when reinstating a single redline.
        
        The "reinstate multiple redlines at once" case still needs fixing.
        
        Change-Id: Ib2c58ac41fcb86b2f947b041ada318ea2a361e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183589
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-04-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cc7c5010f9ed93a7b112ce2f6fc72690c46ce2d]

        add some more SvxFieldData to the model.xml dump
        
        which I found useful in debugging
        
        Change-Id: I28045cbedbba14633a85fa6b4ebc0b8c02f36cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eaa3f84301affbb29378982ec7c263483e7b8571]

        cid#1645529 silence Use after free
        
        Change-Id: Ie8ac6573b7b4d72e0c91d019190ed89546c9605e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7d54aeb2eeade99e9bde5766a7e930ac3bca1bcf]

        cid#1645557 Dereference null return value
        
        Change-Id: I546558560a0044419abe86406d1d466729e809c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183576
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-04-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e07a0568b0b06c089ef4d346af8a7ece880890bc]

        move loplugin:constparams out of store again
        
        since I have improved and updated it a little. But leave it off by
        default, since it is pretty expensive
        
        Change-Id: I60226bc37eb38ddb5c648e5205aba311a75e7f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183570
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [719f17554e2e73563cd90593c3f7f6b0eea84f17]

        tdf#165473 PPTX hyperlinks to other slides do not work
        
        regression from
            commit c638ae429e500cee147b621ed30d9fed392edd0a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Oct 18 16:21:10 2024 +0200
            don't use iterateItemSurrogates for EE_FEATURE_FIELD
        
        Change-Id: Ibf7a89cb30dd11591152a7e052e4d11ea4bf9407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183578
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-04-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [31d5cbdf486d14a396153bcefdcb3881d2ad5040]

        loplugin:unusedmethods
        
        Change-Id: I07b1acf3d01bc0ceb6e5b2a6db260e6e7874379e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-01  Karthik  <me@karthikreddy.org>  [0d0e5c72e6344de48227b74846a6ff638b803c64]

        tdf#160194 Add 3 checkboxes in Style InspectorPanel
        
        Add functionality to enable/disable below SportLight features
        in Style InspectorPanel
        
        - Paragraph Styles
        - Character Styles
        - Direct Formatting
        
        Change-Id: I22bc988514ed28dbf309ddb148b1d029bb507b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182716
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [2384755ca8688a99ab9c0b0907123632aca6471b]

        a11y: Drop unnecessary XAccessibleExtendedComponent overrides
        
        Drop overrides of the XAccessibleExtendedComponent
        which just return an empty string.
        
        That is now already implemented in the base class
        implementations in OAccessibleComponentHelper, see
        
            Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 31 13:49:20 2025 +0200
        
                a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl
        
        Change-Id: Ibc3fe295eaa2dc5443ba4f8fa25a81451b7b3765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183553
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [0cb6632eceef31846a5c4af2d599e97da523bdd6]

        a11y: Merge OAccessibleComponentHelper and OCommonAccessibleComponent
        
        Merge the two classes, now that OAccessibleComponentHelper
        is the only OCommonAccessibleComponent subclass after
        
            Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 31 13:49:20 2025 +0200
        
                a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl
        
        Change-Id: Ic7a36c40066f307f8df29dc4dd45ed3ee966bcb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183552
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [e856e8e71ffe0215911ad1aaabc64f5bef7fc696]

        a11y: Merge OAccessible{,Extended}ComponentHelper, add default impl
        
        Merge OAccessibleExtendedComponentHelper and
        OAccessibleComponentHelper by letting
        OAccessibleComponentHelper already implement the
        XAccessibleExtendedComponent interface.
        
        Add default implementations for the two
        XAccessibleExtendedComponent methods
        (XAccessibleExtendedComponent::getToolTipText
        and XAccessibleExtendedComponent::getTitledBorderText)
        that simply return an empty string.
        
        Replace all uses of XAccessibleExtendedComponent
        by OAccessibleComponentHelper.
        
        This simplifies the class hierarchy and prepares
        for further simplification in upcoming commits.
        
        Change-Id: I05547b12806a6a90b166edbe196b4bc5a27344be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183551
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [42e1ea290a01e6b1b8b2ba3f578d496a7913b388]

        dbaccess a11y: Implement OConnectionLineAccess::implGetBounds
        
        Don't manually override OAccessibleExtendedComponentHelper
        methods related to bounds/position, but implement
        OConnectionLineAccess::implGetBounds (i.e. override
        the base class implementation) instead so that the
        logic in OAccessibleExtendedComponentHelper "just works".
        
        Mark the OAccessibleExtendedComponentHelper methods that
        shouldn't be manually overriden as final, just as is already
        the case in OAccessibleComponentHelper.
        
        Change-Id: Ia24d254384757796a8357928af05dca48e16ada9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183550
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [46f7fad86df883677e368f79bac4abada7281f9a]

        editeng a11y: Use OAccessibleExtendedComponentHelper
        
        Let editeng's AccessibleContextBase derive from
        OAccessibleExtendedComponentHelper to make use of the
        logic already implemented there instead of having to
        implement all the XAccessible(Extended)Component
        and XAccessibleEventBroadcaster methods manually.
        
        Adjust the various subclasses accordingly as well.
        
        Make OCommonAccessibleComponent::addAccessibleEventListener
        and OCommonAccessibleComponent::removeAccessibleEventListener
        no longer final so that AccessibleShape can override them
        (to add/remove the listener for the AccessibleTextHelper
         object in addition to calling the base class implementation).
        
        The existing XAccessibleComponent::getBounds implementations
        provide the necessary logic to implement
        OAccessibleExtendedComponentHelper::implGetBounds,
        so rename those accordingly (and drop the extra guards,
        as the base class takes care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the base class.
        
        No change in behavior intended or observed in a quick
        test with Impress and Accerciser and Orca when using
        the gtk3 and qt6 VCL plugins on Linux.
        
        Change-Id: I7c42a9cac1099991bc5763b87c55ace2b0fed8a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183549
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [42ef76a37dc67007e0271db7501f35236e3c8d29]

        a11y: Return early for empty listener
        
        Check once early whether `_rxListener` is an empty reference
        and return in that case, instead of checking in different
        code paths.
        
        No change in behavior intended.
        
        Change-Id: Ib3548a7c9a71f8d24df4f91089dd46d376c031c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183545
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [369ddbbafcd3777b62f01757b5f080a429480836]

        editeng a11y: Drop dummy XAccessibleComponent implementations
        
        Leave these 2 methods purely virtual in AccessibleContextBase,
        as this depends on subclasses overriding them to function properly.
        
        Change-Id: I52121e18f8bb0c76d8b588a7e09b3cca9f09232d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183544
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [18b7dc796fa2a72a6b56263a5dff35a80536b0af]

        editeng a11y: Merge Accessible{Context,Component}Base
        
        AccessibleContextBase and AccessibleComponentBase
        are both subclassed by the exact same classes.
        
        Merge AccessibleComponentBase into AccessibleContextBase
        to simplify the class hierarchy.
        
        Drop now unnecessary overrides.
        
        This also aligns AccessibleContext further
        with the comphelper::OAccessibleExtendedComponentHelper
        class that also implements both, XAccessibleContext
        and XAccessibleExtendedComponent, and thus also prepares
        for potential refactoring to deduplicate code in those
        two classes in the future.
        
        Change-Id: Ia3331f2bd4563bf9cdfee35c9ea6cca91bd093cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183543
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [a5eb44c1e6db95ef6e3c478c7feb3b3849c1164a]

        editeng a11y: Use #pragma once
        
        Change-Id: Ia4a06488a0d908bcef711707262ba3fbf21dba1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183542
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [45d5a34ba4d9f44811aa42274de3904f915196da]

        editeng a11y: Fix interface names in doc
        
        Change-Id: I02f000b574165d9a8e068dd29e3dbd7e902f0b65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183539
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [a3af74ab9f2ff5cba9a35c20eff96a037072f966]

        basctl a11y: Use OCommonAccessibleComponent::isAlive helper
        
        Change-Id: I2cc920d7fcb772000f6c31367602cbdecd56f324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183538
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [24f207d4fe604e0b95590da5b2dff85739599cfa]

        chart a11y: Reuse base class logic to check disposed state
        
        Change-Id: I79c95519ee5ba76f68bff6984e3659abdea9ce60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183537
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [9a71ceb7946e3ae4d67bfeef4ca8325c550f400a]

        chart a11y: Drop AccessibleBase::BroadcastAccEvent
        
        Use the base class's OCommonAccessibleComponent::NotifyAccessibleEvent
        directly instead.
        
        The old/new params are in reverse order
        for that one, so adjust callers accordingly.
        
        Change-Id: I8d4ef730a139366c5762836819e20d35cb2ff5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183536
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [0191439627ee5ec4f692e60b25501fa40f9ea91e]

        chart a11y: Use OAccessibleExtendedComponentHelper
        
        Let chart's AccessibleBase derive from
        OAccessibleExtendedComponentHelper to make use of the
        logic already implemented there instead of having to
        implement all the XAccessible(Extended)Component
        and XAccessibleEventBroadcaster methods manually.
        
        AccessibleBase::getBounds implements what is needed
        to implement OAccessibleExtendedComponentHelper::implGetBounds,
        so rename the method.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the base class.
        
        Adjust subclasses as well to deduplicate logic there, too.
        
        No change in behavior intended or observed initially
        when testing this with Accerciser and Orca and the gtk3 and qt6
        VCL plugins for a chart inserted in Writer ("Insert" -> "Chart").
        
        Change-Id: I5d29c099dc31d70711f4017e52a0859f22c5aa23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183524
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [fcc01f789aabf734307e609fee62ef5037c1903a]

        chart a11y: Simplify XAccessible{,Extended}Component implementations
        
        Let the base class AccessibleBase implement
        XAccessibleExtendedComponent with default implementations
        for the methods that simply return empty strings.
        
        This simplifies the implementation in subclasses, that
        now only need to override XAccessibleComponent
        and XAccessibleExtendedComponent methods when they
        actually want to have a different behavior, not
        to avoid ambiguity due to XAccessibleComponent
        being a base class of both of their base classes
        (XAccessibleExtendedComponent, AccessibleBase).
        
        Change-Id: I2a6a39a721de19178954db898d52a2d7bc01fcb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183523
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [a97b5966d3b2e6ff40d945ec94eafa4176d53753]

        chart a11y: use vcl::Window instead of XWindow
        
        Switch AccessibleChartView::m_xWindow,
        AccessibleElementInfo::m_xWindow and related code
        from using the UNO interface
        css::uno::WeakReference<css::awt::XWindow> to using
        the concrete implementation class vcl::Window/ChartWindow
        directly instead of assuming it's a vcl::Window and then
        using VCLUnoHelper::GetWindow to get the vcl::Window
        from the XWindow in multiple places.
        Rename the members accordingly.
        
        Use a VclPtr and clear it in
        AccessibleBase::disposing and AccessibleChartView::disposing.
        
        No change in behavior intended or seen in a quick test using
        Accerciser with the qt6 VCL plugin with a chart inserted in Writer
        using "Insert" -> "Chart".
        
        Change-Id: If98ef041fdd1a8bf68620e0c8b1e81973e7b01f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183522
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [55010423927385f7b2ff97e95799a9e03036575f]

        chart a11y: Use nullptr directly
        
        This makes more obvious that this is null. In particular
        calling VCLUnoHelper::GetWindow with a Reference that is
        known to be empty/null doesn't make much sense.
        
        This has become more obvious with previous commit
        
            Change-Id: I91d4e9cc40473aa204ec7bcada954cf0f765e6ea
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 31 06:14:27 2025 +0200
        
                chart a11y: Make clearing weak refs more obvious
        
        Change-Id: Ia544001d609ede8f44003ffd4befc3cddccf045f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183519
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [a179c0a6c1c9eec319062c21a53f976282083235]

        chart a11y: Make clearing weak refs more obvious
        
        Drop the local vars that are first assigned
        the current value of the members, but then
        cleared, and then assigned to the members.
        
        Instead, clear the members directly to make more obvious
        what's happening.
        
        Change-Id: I91d4e9cc40473aa204ec7bcada954cf0f765e6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183518
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [1721a3042ec65f2b4c8ad2cdc036caf160321227]

        chart a11y: Use Reference to XAccessible
        
        Before
        
            commit bdf2d664784b3ebe3e7078b9ec82a02d09d9ded8
            Date:   Sat Sep 2 10:44:51 2023 +0200
        
                use more concrete type in AccessibleChartView
        
        , that was a `Reference<lang::XInitialization>`,
        but now, there's no more reason to use something else
        than an XAccessible.
        
        Change-Id: I054fad40e1b62f3b4ec688ab09673d4c86f7f1ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183517
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [ce050797b5b3a9f9912c2bed88febd6b6ca7307f]

        chart: Use ChartController::m_xViewWindow directly
        
        ... instead of assigning it to an additional local
        variable and using that one.
        
        Also drop the (maybe related?)
        
            //@todo
        
        comments that unfortunately don't say what should
        be done...
        
        Change-Id: I08ba33facba385b4f1b43f176125710dd8f031d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183516
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Michael Weghorn  <m.weghorn@posteo.de>  [679e9b4ca1a9a7842cae5d8a9aad5188d4bb5f0d]

        chart a11y: Drop XEventListener inheritance
        
        Don't let AccessibleBase subclass XEventListener as
        there's no need to, and AccessibleBase::disposing
        wasn't doing anything anyways.
        
        Change-Id: I6fa5e7cb65853e775792c35ce6571104c8c7edcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183515
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-04-01  Noel Grandin  <noelgrandin@gmail.com>  [f8f5c1837c0382de40bdcbc5017e62ab13dbcb04]

        take solarmutex in BufferedDecompositionFlusher
        
        when clearing objects, I have seen a crash on macos which happens inside
        skia
        
        Change-Id: I8328439917339242d56d813f518e05bbd92adc60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-04-01  Justin Luth  <justin.luth@collabora.com>  [a2c58edd20f243697a0790d323816094e319b2a7]

        tdf#165995 pptx export: table cell margins weren't exported
        
        Although some left/right margins have been exported since
        5.0 commit 636c5a63d67b52b0d2f9f21a863c45eca6ac9ff7
        Author: yogesh.bharate001 on Thu Mar 26 10:48:15 2015 +0530
            tdf#90223:PPTX table cell left  and right margin is not exported.
        
        zero left/right margins weren't exported,
        and nothing was done for top/bottom border padding from table cells.
        (That's a bit weird, because I am using Yogesh's unit test to
         test for a round-tripped zero bottom border.
         It was the only existing unit test with non-default border spacing.)
        
        [The default (if not specified during import) L/R margins are 0.25cm
         (so definitely a zero margin needs to be exported and not ignored),
         and the import default for T/B margins is 0.127cm.
         However, none of that is documented of course.]
        
        make CppunitTest_sd_export_tests-ooxml1 \
            CPPUNIT_TEST_NAME=testCellLeftAndRightMargin
        
        Change-Id: I12a8a785ddb784cacd4abf10e8e19df7cd50ec64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183564
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-03-31  Aron Budea  <aron.budea@collabora.com>  [ab45b8d9959f8f392a10d0874c50f26b816a4da8]

        tdf#165655 oox: don't export incomplete shape data coming from VML
        
        Some export was added in fd238380ae7820f12ac1f7c52d0f7180a93f3ba3.
        This can result in only anchor pointers and no other data
        saved for certain shapes having no export code, making it an
        invalid file.
        
        Change-Id: I81bf513b6ebaa9f6456a26ccbc3276e019551eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182699
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-31  Noel Grandin  <noelgrandin@gmail.com>  [215500ea4d1f6f2d7630ab161d59c9a265425c56]

        merge ExplicitValueProvider interface into ChartView
        
        Change-Id: I4e5ef8c00b8e1b001d0f711c0c15814d316e2905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183479
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [42190cd153d4061a8401acdb2c2f8edf9154a978]

        Revert "Move SingleSelectQueryComposer.java tests to C++"
        
        This reverts commit d1ec7e90772421331bef31eb934180c7f992e42f.
        
        To avoid deadlocks on jenkins.
        
        Change-Id: Icbe299ed29dfd02f61b14953344a902e2184c606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-31  Miklos Vajna  <vmiklos@collabora.com>  [01311bb1e4c2404354cce8934d36991d91d527b2]

        cool#11357 sw redline reinstate: avoid unwanted multi- or table selection
        
        See
        <https://gerrit.libreoffice.org/c/core/+/183270/2#message-788fb983dba403b07915e3046ab00e799b42a723>,
        if we have a table selection by the time we reinstate, this would lead
        to a use-after-free.
        
        Fix the problem by always killing table selections and multi-selections,
        we just want reinstate to work on simple selections.
        
        Change-Id: I0cef8d63125a4f5dee78b6feca24ed47ad7b0220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183548
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2bcf9bbfe150c25636743ae6a833f01830d1828]

        sd: silence warning C6011: Dereferencing NULL pointer 'pPaintWindow'
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sd/source/ui/tools/SlideshowLayerRenderer.cxx(770): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sd\source\ui\tools\SlideshowLayerRenderer.cxx(768) : warning C6011: Dereferencing NULL pointer 'pPaintWindow'. : Lines: 741, 742, 743, 744, 745, 746, 747, 748, 749, 750, 752, 753, 755, 762, 766, 767, 768
        make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/solenv/gbuild/LinkTarget.mk:339: C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/workdir/CxxObject/sd/source/ui/tools/SlideshowLayerRenderer.o] Error 2
        
        After
        commit 7c76dfc35350d6a8fef0379129b17ab97a775a4a
        Author: Marco Cecchetti <marco.cecchetti@collabora.com>
        Date:   Tue Dec 3 18:59:50 2024 +0100
        
            lok: slideshow: handle text object in edit mode
        
        Change-Id: I561ee1aa9f20c1c5de8f44efa547b1ad8069e370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183547
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-31  Alain Romedenne  <alain.romedenne@libreoffice.org>  [1c7ac9b6d1cfbea54d9a514b9c95765cb2de9829]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49f82528aecdece559fb6a859a98e86fd31c7e6a
          - Precisions about OS recognition in scripts
            
            plus a few invitations to go Python 
            Change-Id: I0c58b9f35638c0d609727e6ef4affffac8fce971
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183441
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-31  Heiko Tietze  <tietze.heiko@gmail.com>  [f597c3a6eaa6b45f43b127b9b042442516ddc202]

        Resolves tdf#101142 - Always use a white background for print preview
        
        Change-Id: Ib60ca1c5de5eb17008cc5ddc04ae4fccfe373b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183541
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-31  Justin Luth  <justin.luth@collabora.com>  [a47776a938c4666d4618b5cbf20d4319f64a6ff4]

        tdf#165521 pptx layout: don't use font's leading for cells too
        
        This patch also fixes tdf#119951 and perhaps tdf#148039.
        
        WARNING: This patch will likely resize the text line height
        in every table imported from PPTX.
        
        Someone must have figured out that Microsoft just ignores
        the font metrics, and simply adds 20% to the font height
        to achieve a "single spacing" line height.
        
        In LO, that is either termed FontIndependentLineSpacing
        (a misnomer because it DOES depend on the font ascent/descent)
        or FixedCellHeight
        (also a misnomer because it so far hasn't applied to cells/tables
         and certainly is not restricted to cells/tables
         since it was implemented for customShapes).
        
        With this patch, my particular document
        now has the right "text/table height" according to a PDF overlay.
        The theory is that this change is needed for every document.
        
        The reason this patch is needed is because
        svx/source/table/viewcontactoftableobj.cxx's
        createPrimitive2DSequenceImpl
        passes rCellItemSet as the ItemSet
        that will eventually be checked for
        rSet.Get(SDRATTR_TEXT_USEFIXEDCELLHEIGHT),
        which creates attribute::SdrTextAttribute(bFixedCellHeight)
        which is used by SdrTextObj::impDecomposeBlockTextPrimitive
        to set SdrOutliner (and thus EditDoc) with
        SetFixedCellHeight(rSdrBlockTextPrimitive.isFixedCellHeight());
        
        With FixedCellHeight, impedit3.cxx calculates text/line height
        using ImplCalculateFontIndependentLineSpacing.
        
        make CppunitTest_svx_unit \
            CPPUNIT_TEST_NAME=testTdf165521_fixedCellHeight
        
        I modified testTdf144092TableHeight,
        and attached PDF overlay images to tdf#144092 as proof
        the the table should be taller than originally stated.
        
        Change-Id: Ibb4af395b77a3f4d30b5c2e8a08429b701f1ae95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183130
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-03-31  Justin Luth  <justin.luth@collabora.com>  [0bd1df2d72bd62327dbbc8b39cc23e06c444f73a]

        tdf#165521 svx layout: clear Outliner FixedCellHeight after use
        
        This specifically avoids a PPTX custom shape's editEngine flag
        from bleeding into the remainder of the document
        and affecting another shape's sizing calculations.
        
        This bleeding was noticably affecting PPTX table sizes,
        triggering the investigation that lead to this patch.
        
        FALSE REGRESSION NOTE:
        It appears that perhaps PPT/X tables SHOULD ALWAYS
        be sized according to SDRATTR_TEXT_USEFIXEDCELLHEIGHT = TRUE.
        In other words, tables currently match MS Powerpoint's table size
        only when they accidentally have this setting bleed through.
        With this patch, we are effectively always setting it to FALSE,
        and thus tables will never be accidentally correct anymore.
        ... and the same possibly is true for all kinds of other shapes.
        
        The problem with having a correct table size
        is that the text inside the table needs to also
        be in sync with this sizing calculation.
        Otherwise it will either be too small (commonly),
        or it could spill out of the table
        (in cases where the font is designed with a large leading).
        
        This patch's effect on tables is to allow
        the table to only be defined by its own content.
        Now when other actions cause a table recalculation
        (like selecting text, drag and drop, editing)
        the table size won't fluctuate (since in this re-draw context
        there wasn't any FixedCellHeight bleeding into the calculation).
        
        make CppunitTest_svx_unit \
                CPPUNIT_TEST_NAME=testTdf165521_fixedCellHeight
        
        Change-Id: I5239c78cf8f1e8fffd65b6aa285a840428e92e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183172
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-03-31  Heiko Tietze  <tietze.heiko@gmail.com>  [01b1e0f172c1912dac24337692d85a9caf637d9a]

        Resolves tdf#84375 - Commands to protect image size and position
        
        Change-Id: Id693e4198d5feb1bb4d71a59785d0ab651b3cc68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183330
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [6845b8a9262089f673ee7cc147db5e0192b4b4bd]

        loplugin:constparam in various
        
        Change-Id: I874a95777aed3471675bf03acfcf05ecfcb4f830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-31  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7c76dfc35350d6a8fef0379129b17ab97a775a4a]

        lok: slideshow: handle text object in edit mode
        
        This patch allows to render a text object in edit mode by decomposing a
        TextHierarchyEditPrimitive2D instance in place of using TextEditDrawing.
        That avoids to have artifacts displayed while playing the slideshow such as a
        tiny rectangle around the edited text shape.
        Moreover it allows to animate a single paragraph even when the related text
        object is in edit mode.
        
        Change-Id: I0c27dc0953dd1b0fb7ae70f41e569587f3a623ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183532
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-31  Miklos Vajna  <vmiklos@collabora.com>  [4535698e0b16bf003e8a3705e28f7347f509eb12]

        cool#11357 sw redline reinstate: add a reinstate-all command
        
        Accept and reject can be invoked for all redlines in a document, the
        same doesn't work with reinstate.
        
        Additional problem is that
        sw::DocumentRedlineManager::AcceptAllRedline() iterates over redlines by
        consuming them, but reinstate creates new redlines, so just naively
        doing the same would create an infinite loop.
        
        Fix the problem by reusing SwEditShell::ReinstateRedlinesInSelection()
        for reinstating all redlines: we can easily select the entire document
        and reinstate the selection's redlines.
        
        Change-Id: I24c84c1e5add59d94958bccff65261b5940d3104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183530
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [c1e935c00903fd1b8e7e0674020778bbd0348835]

        postgresql: upgrade to 15.12
        
        According to https://www.postgresql.org/support/versioning/
        the last release of branch 14 is on November 12, 2026
        Upgrade master branch to branch 15 to avoid reaching the EOL
        
        Downloaded from https://ftp.postgresql.org/pub/source/v15.12/postgresql-15.12.tar.bz2
        
        Change-Id: I86eefbc5f2341aef81ce026a93f5c8cc65f95f50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183528
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-31  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [5528fb79ec1e143b0aea7bbb0685ad7a6cff2696]

        Need to take over BColorModifierStack for *all* content renderings
        
        Change-Id: Iac558c8b653349a86966869bd96dca265a8fb223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183419
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [969d6815b802893b5dd765afc17ad230af0fe456]

        nss: upgrade to 3.110
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_110_RTM/src/nss-3.110-with-nspr-4.36.tar.gz
        
        Change-Id: I4301e093661bbac3aae9f59d7ae366a0b2e2ef9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183526
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-31  Simon Chenery  <simon_chenery@yahoo.com>  [03dced9d7ddb084649e72b88ed8f41d13b8e4469]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: I7823970bb3b222fcc2dbac9f4cbee4e3fc3f3813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183416
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-31  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [1ab04b964122897ea4d3d0470dde1379955d7bbb]

        tdf#145614 - Convert #define to constexpr
        
        Change-Id: Ia213981f353b16f2c3d5097eed1c08c55533902e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183354
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-31  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [2563ac9aa6ad35f79aa51a1ca639a3a397cb8dd6]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e7f163feb2beaf526135132d8716e68e19d2716e
          - Updated the English dictionaries: GB+ZA + Extension icon
            
            Change-Id: I5a0d1adee2996ca0c9444469cfb9450f0c7bd71b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/183513
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2025-03-31  Miklos Vajna  <vmiklos@collabora.com>  [ce613d65dd3cbf3a6c153201ac81730813691821]

        svx: prefix members of XLineDashItem
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib28086416950e6f5ad5d62640ce9cfe4bd1e1872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183520
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-31  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [dc468362e4c1f8ec518b79dfbd0d927fb5182b65]

        tdf#94699: freehand drawing tool, ignore extremely offsetted control points
        
        Now with the /org.openoffice.Office.Common/Misc/FreehandThresholdPixels config
        option, when using low threshold pixels like 1px it is more apparent that
        XPolygon::PointsToBezier will sometimes make the curve shoot off.
        
        Try to counteract by ignoring control points offsetted more then the segment
        length.
        
        Better fix would be changing the PointsToBezier algorithm, but this seems to
        hold OK for now.
        
        Change-Id: I7ab0a67a33e25874ff55af932b3e087bbaad98fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181841
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-03-31  Noel Grandin  <noelgrandin@gmail.com>  [c976458eb2ef4309bb6b9eff6f00740d2dd6e558]

        simplify the DLL annotations in chart2
        
        now that the libraries are merged, nothing needs to be visible
        
        Change-Id: I009f062301ccec9cf9c57b3280a3cd7452adcf38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-31  Simon Chenery  <simon_chenery@yahoo.com>  [45ff93aea24222a02c292c0ac443993f030dbb4d]

        tdf#154285 Check too many arguments to BASIC WEEKDAY function
        
        Change-Id: I8f3044f1c8ebf12d4654b5ad173563e09897ccc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183494
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-30  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [3a5c9f31b662519293120f3e10d1b555e1f14849]

        tdf#94699: make hardcoded freehandmindist an expert option
        
        Make Freehand Tool minimum pixels between points, a configurable option.
        /org.openoffice.Office.Common/Misc/FreehandThresholdPixels
        
        Change-Id: I4f1f56bc16bbf86820418c286a8f9e1a632645ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181840
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [9147a19d2469b9a641d51c37d33bf874311f8e94]

        Use osl_getEnvironment instead of getenv
        
        Avoids conversion to OUString; and is Unicode-safe on Windows.
        
        Change-Id: Idd82f589ae9bf692ce2e73f84cb664a68156915a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183507
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [c16c8b78fadbafcc2e75c581510d17692c718993]

        Use osl_getEnvironment instead of getenv
        
        Avoids conversion to OUString; and is Unicode-safe on Windows.
        
        Change-Id: I39fc7af8822850a187efb108e5f862a9863152fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-30  Patrick Luby  <guibmacdev@gmail.com>  [159be5c95178088c02ad863a3ad6f0a01b3ecc7f]

        Related: tdf#161623 don't set the menubar to null on macOS
        
        When a window enters LibreOffice's internal full screen mode,
        the vcl code will hide the macOS menubar. However, if the
        window is also in native full screen mode, macOS will force
        the menubar to be visible.
        
        While the vcl code already partially handles this case by
        disabling all menu items when in LibreOffice's internal full
        screen mode, the problem is that any submenus that were not
        displayed before setting the menubar to null will show all
        menu items with no title.
        
        A simple way to reproduce this bug is to open a new Writer
        or Calc document and do the following:
        - Switch the window to LibreOffice's internal full screen
          mode by manually selecting the View > Full Screen menu
          item (the bug does not occur if its key shortcut is
          pressed)
        - Switch the window to native full screen mode
        - Click on the menubar and note that many of the submenus
          are displayed with menu items, but none of the menu items
          have a title
        
        So, we need to keep the menubar visible and rely on the vcl
        code to disable all menu items.
        
        Change-Id: I97fc63a8cd028c029a71899090185bc09d4aa492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183508
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [269b588647bb8435a0f3cb8b6c01cdd1c006e8ed]

        Use osl_getEnvironment instead of getenv
        
        Fix a TODO
        
        Change-Id: I8647b6b90f3fb50180363f8241f27329be426a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183505
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [7e5a704e7c57f499e6f232b1a346d207f271430b]

        Use _wputenv_s instead of _wputenv
        
        Avoids unneeded concatenations; also it's documented as "more secure".
        
        Change-Id: Idbe0bd330992833bc70231a069ddbd808ea94b62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183502
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0166610b95112b8a6245b2f9ad87001163deeefe]

        Use osl_getEnvironment instead of getenv
        
        Avoids conversion to OUString; and is Unicode-safe on Windows.
        
        Change-Id: If4f76f867f988d43ec4dae0a8e09f1390fee42e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183503
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-30  Jean-Pierre Ledure  <jp@ledure.be>  [c8d2751a90cbf1eceaf34257876d09b4eb1efd9d]

        ScriptForge (SF_Exception) Return codes
        
        So far, an exception raised in a user script
        and detected by ScriptForge gave next behaviour:
        - an error message was displayed to the user (1)
        - the same error message was recorded in the
          console (2)
        - the execution of the script was stopped (3)
        
        The actual commit introduces 4 new properties
        in the SF_Exception service.
        Next two boolean properties may optionally
        change above behaviour:
          exception.ReportScriptErrors (default = True)
          exception.StopWhenError (default = True)
        They may change resp. behaviours (1) and (3).
        Note that behaviour (2) is preserved anyway.
        Their values are set until they are set
        again or until the LO session expires.
        
        When StopWhenError is set to False, next two
        properties allow to test the success of the
        last call to the ScriptForge API and to
        define an appropriate action, including the
        continuation of the process:
          exception.ReturnCode
          exception.ReturnCodeDescription
        
        Example:
            exc = CreateScriptService("Exception")
            fs = CreateScriptService("FileSystem")
            exc.ReportScriptErrors = False
            exc.StopWhenError = False
            fs.OpenTextFile("/aaa/bbb")
            if exc.ReturnCode = "UNKNOWNFILEERROR":
                ...
        
        The test on the return code must precede any
        next call to any ScriptForge API entry.
        
        The list of the available return codes is
        listed in the SF_Exception.xba source code.
        
        These changes are applicable both for Basic
        and Python user scripts.
        The user documentation should be reviewed.
        
        Change-Id: I6d274e54ee37702f244e729ea5c9d1751b69abec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183486
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [11f10c48688436129337ffc7a082a56023c58071]

        Use GetEnvironmentVariableW a bit more correctly
        
        1. Make the buffer size equal to the documented max environment
           variable length plus one.
        2. Check that the function result is not larger than the bufer size,
           which would indicate "buffer too small"
        3. Use the returned length to avoid finding the length again.
        
        While at this: drop the obsolete comment about large buffer again.
        Before commit f78a2bcce88dd5c12052ae3e55c561cdd48b05fe, the comment
        told about a problem in unicows library (the Win9x implementation
        of W-functions). The restored comment only told about unspecified
        problem in GetEnvironmentVariableW. Since we don't support Win9x
        (and unicows), the comment can be removed. The size of the buffer
        is not a problem here, so just let it be.
        
        Change-Id: If57a37a9c35aca2c08543619aa4aba6faac79045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183495
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-30  Patrick Luby  <guibmacdev@gmail.com>  [f20681176eb6abab6438f6722439a139fe07a963]

        Related: tdf#161623 disable menubar visibility if no key window
        
        If a window is in LibreOffice's internal full screen mode
        and not in native full screen mode and then the user switches
        to a different application and back using the Command-Tab keys.
        the menubar and Dock would unexpectedly appear.
        
        It appears that the key window will still be nil in this
        case, so only enable menubar visibility if the key window
        is not nil.
        
        Change-Id: I1ad9aefe8183908044042efc2ec67df3bae252dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183498
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6aa6fd0f14770d2b2d5071109bd19349e83b6667]

        Fix typo
        
        Change-Id: Ia755b84247f8bd9bc294ea9007daedc5dcef28cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183399
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [720d58ad7f86bd0262a83eeebac6b61e19b55e69]

        Fix typo
        
        Change-Id: Ief3e82b05c547e1ce30fcdaaba9ed9e765999eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183492
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [50421d9de2a03d190244058496c6bc8654d96a4d]

        Fix typo
        
        Change-Id: I6ae8b72de6e7f606f8b1e854b60b9a637593e0ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183493
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ec5bbc9a98e5648d88524b4e5d6a2a40ba65e5cd]

        Simplify Val function implementation
        
        Use o3tl::toInt64 instead of strtol, which required string conversion.
        
        Change-Id: Ie7571834e8a126963899f340230baa14e3353b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183489
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-29  Noel Grandin  <noelgrandin@gmail.com>  [e09f212f91033471f1527337fa183e4cb19a8d0b]

        merge chartcore and chartcontroller libraries
        
        there is no good reason to keep these separate
        
        Change-Id: Ib484dbd5d331b0d1a117f5fc2e331123c4e70d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [4409dbbdbcf5446d2085ac424048d188cd7b9062]

        Use osl_getEnvironment instead of getenv
        
        Avoids the need to convert between OUString and OString;
        and resolves a pressing Win16 compatibility issue.
        
        Change-Id: I4cf5b6962050181a66a33c1261c9440ac7a39b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183487
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [bb57fa601a30151f897399725bd3b36a1a5fbd0f]

        Avoid useless OUString -> OString -> OUString conversion
        
        Change-Id: I938d13d91bc83b9fd0c018e676923c27a7cad637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183484
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [940f189cdfa6022d92204978e14739b86a636c5c]

        Simplify SetFlagContextHelper.hxx
        
        Limit the implementation class visibility.
        Allow to define the value of the flag.
        
        Change-Id: I9ce42569895c6df044074bcc2ab77e2cd5b901ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183481
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-29  Patrick Luby  <guibmacdev@gmail.com>  [0fabcd369fc2c9a79b86b634b2e048223f9d8697]

        Related: tdf#128186 stop Skia/Metal flicker in full screen mode transitions
        
        Let vcl use the CAMetalLayer's hidden property to skip the fix for
        tdf#152703 in external/skia/macosmetal.patch.1 and create a new
        CAMetalLayer when the window's frame changes.
        
        When using Skia/Metal, flushing to an NSWindow during transitions
        into or out of native full screen mode causes the Skia/Metal surface
        to be drawn at the wrong window position which results in a noticeable
        flicker.
        
        Also, enable the standard macOS animation by only suppressing
        animation when in internal full screen mode. LibreOffice's internal
        full screen mode fills the screen with a regular window so skipping
        the macOS animation makes sense for that case, but it appears very
        abrupt when transitioning to a window that is smaller than the screen.
        
        Lastly, fix several incorrect conversions between window content and
        frame rectangles during full screen mode transitions.
        
        Change-Id: I0e620ea2f727977921c0fdb63b9995b4e77eb161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183307
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-03-29  Justin Luth  <jluth@mail.com>  [210c89a34bda429fe7e0b8f0e63ce5bb5add9d8b]

        related tdf#165521 oox: ShapeExport::GetNewShapeID of at least 2
        
        This patch fixes an existing bug that was exposed in 7.6.5
        by commit bff76421e234df7246a7f49c71a11432f86e09d1.
        
        Microsoft Powerpoint was complaining that my unit test
        tdf165521_fixedCellHeight.pptx
        needed to be repaired after round-tripping it in LO.
        
        While notesMaster1.xml didn't mind two shapes having the same id=2,
        it complained if the first one was set to id=0 or id=1.
        
        However, we can see the same situation in other files
        (like slidesMaster1.xml) where there is no complaint,
        like in tdf106867.pptx.
        
        So I don't know what really is going on,
        but it makes sense to not have overlapping unique IDs,
        and thus this patch "just works",
        which is enough to make me happy.
        
        Change-Id: I6e7303997bd404e269e71fe156b1390c57ddb349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183464
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-03-29  Oliver Specht  <oliver.specht@cib.de>  [862483386614347e45ffdde69e109d4d2dd25fd2]

        tdf#50743 improve scrolling with selection
        
        Second attempt to improve scrolling whith selection after
        47bf215cc7693bde89143f63b88556c61a68a132
        
        Change-Id: I46b321b7e0706ef0975e7078018d75ef64d65897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183361
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-29  Noel Grandin  <noelgrandin@gmail.com>  [d1fecfda9b3d6b15a996b60aec19cb4ae9f747b9]

        simplify Chart2ModelContact a little
        
        Change-Id: I26ac8717e70a737c0c15441603cbf48db4913233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183465
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-29  Nam Bui  <ndbui03@gmail.com>  [6522da9cde7e21a7d6f3d2c03b12062d80d83e1b]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Changed find() == end() to !contains() in
        sw/source/uibase/sidebar/CommentsPanel.cxx
        
        Change-Id: I02d31c148d1b2feace0e97ae6318d523793b07a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183422
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-03-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed7d087120fa08de37f80230421173422f2dcf87]

        related tdf#85976: unify ok/cancel/help buttons in the dialog
        
        Same as the rest of dialogs
        
        Change-Id: I0213581d5f69ecee829af622af95773defd6811e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183460
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [57e38f9aaef1a5a83baed1166830a70917c53327]

        cid#1645527 Copy-paste error
        
        since:
        
        commit 4db90da301cff5b4bcedbe492d12bfa10e7577b7
            tdf#45617 Refactor the member function SdDrawDocument::InsertBookmarkAsPage
        
        Change-Id: I87e00ee6289143388203e4366b1d3a58dd3a34c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183467
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [315febd7ead36519b627bb3d8980b32f393c6062]

        related tdf#162786, tdf#159988: fix arm64 for linux
        
        Change-Id: Ia2670b3827880f4aba642390e68ffcc77dc63740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183371
        Reviewed-by: Guillaume Paquereau <guillaume@carbone.io>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [c42357adc04648d2607346e78514ea1b8503b077]

        Amiri: upgrade to 1.001
        
        Downloaded from https://github.com/aliftype/amiri/archive/refs/tags/1.001.zip
        
        Change-Id: Ib6bd5ed05cbb282fde0bcab44b715350fdf252ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183455
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny <khaled@libreoffice.org>

2025-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2ebc6595ba5ca9b0be4554b5b4f2601b771dd3bb]

        Resolves: tdf#165881 use position of mouse release for ValueSet select
        
        somewhat dubious to my mind, but that's what's wanted and it used to do
        this, whether by design or chance is unclear.
        
        Change-Id: I6f2aa7076e4819b7f310fdabff4f678b331b6c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183462
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-28  Jaume Pujantell  <jaume.pujantell@collabora.com>  [80d036c0ddfce7025e0d069f54c65b28031a9f7c]

        tdf#165933 avoid w:delText inside w:moveFrom
        
        w:delText should only be used inside a w:del, we differentiate if we use
        w:del or w:moveFrom by looking if the current redline is move and if it
        is inside a move bookmark. But sometimes the run contents are writen
        before the surrounding bookmarks, in that case we wrongly used delText.
        To avoid this we need to check not only the existing bookmarks but also
        the ones that will be opened in this run.
        
        Change-Id: I6653d18545cc5eb5f302c5753cdd7dfb24bee6fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183458
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2025-03-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8044f9a2b5a99c865f1ead89c60986a66151c488]

        tdf#163638 - CSV Import Dialog: show visual indicator for from rows
        
        Reflect remembered from rows control in the visual indicator after
        opening a new CSV file in the current session.
        
        Change-Id: If51a10cbe1282ef45786f672d2a237b37dced89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183440
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2025-03-28  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [fec431aeef76e2f4e21dca8ef55f6807b5ad228d]

        tdf#65872 Remove import dialog for normal paste in Calc
        
        Remove the import dialog when performing a normal paste.
        Show the dialog only for Paste Special to avoid unnecessary interruptions.
        For normal paste, use the last selected preferences from Paste Special.
        
        Change-Id: Idfc985b9c13cb3b995c91e947e815d1789e6f041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181225
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa1ce426bd578d0f20468cf4e864f69e2de4bcf1]

        loplugin:constparam in vcl
        
        Change-Id: Iec5eb0c8179a8f84c24c9987fe7054bc7cb3a85d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-28  Balazs Varga  <balazs.varga.extern@allotropia.de>  [557941fda42d80865c6d5983fddca3a1458f1980]

        Add unique accelerators config file for wasm builds
        
        Remove/disable hotkeys which brings up certain dialogs - and sometimes these dialogs loses the focus and they disappear but still keep the document waiting for them to close - for wasm app with wasm-accelerators.xcu
        
        TODO for later: better solution would be to have the props that are removed here rather be install:module="..."-conditional in officecfg/registry/data/org/openoffice/Office/Accelerators.xcu
        See details: https://gerrit.libreoffice.org/c/core/+/183389/comment/064afee4_47e66b62/
        
        Change-Id: Ia44390fd7682327feb56e944d30a9fd7ff4cbd82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183389
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-28  Adam Seskunas  <adamseskunas@gmail.com>  [ef2fc674d29d1bf922c15427ef9484386869bed8]

        tdf#157482 Add UI test for Warning InforBar
        
        Change-Id: Ie6a8c4283e6f0ce89f98b0f40ee4d2d2351a1408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170535
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [3874e6ef7d4e5fdb76e446ba1ba524a51572791f]

        checkExternalLibraries: check current libxml2 branch
        
        There is a new 2.14 branch of libxml2 but LibreOffice uses 2.13
        at the moment so only notify when there is a new version of
        the current branch
        
        Change-Id: I827f02a390fbb2623297cc5991ff0c1bea5bfb81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183449
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0afe740800a5a2a4bc2041fa602b11dc31a4a4e1]

        tdf#165811 calc mouse select sometimes off by one char
        
        regression from
            commit 11b15571475414ef853e21a6c96afa2ac81f848f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Oct 30 09:51:26 2024 +0200
            convert KernArray from sal_Int32 to double
        
        Change-Id: I9266693fa8d449c3369b65c31fbb4a3d3182777f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183452
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-28  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [19ebfeb83d39d7ff246a89cfedcc4691c966dff1]

        tdf#147021 Use std::ssize() instead of SAL_N_ELEMENTS macro
        
        Change-Id: I602fa86255fafbc30ed63178eeab569db8c8d6dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183379
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-28  Hossein  <hossein@libreoffice.org>  [6274a47543542a5d163907b3104b15de40831282]

        tdf#143305 Remove SID collision in .hrc file
        
        There was some SID collisions in the below file which should have been
        avoided:
        
        * include/svx/svxids.hrc
        
        The collision occured over the offset of 450:
        
         $ git grep -n "SID_SVX_START + 450"
         svxids.hrc:385:#define SID_EDIT_DIAGRAM        ( SID_SVX_START + 450 )
         svxids.hrc:542:#define SID_SB_STARBASEOPTIONS  ( SID_SVX_START + 450 )
        
         $ git blame -L 542,542 include/svx/svxids.hrc
         cb05db521ee51 (Vladimir Glazounov 2007-04-11 15:30:44 +0000 542)
        
         $ git blame -L 385,385 include/svx/svxids.hrc
         cfb68712a4916 (Armin Le Grand (Allotropia) 2022-03-02 11:52:14 +0100 385)
        
        As described in 1b4997d7a84d1, it is possible to use grep to make sure
        no collision is remaining:
        
         $ git grep -h "SID_SVX_START[ ]*+" *.hrc | grep -Ev '^\s*\/\/' \
             |awk -F\( {'print $2'} | awk -F\) {'print $1'}             \
             |awk '{gsub(/^ +| +$/,"")}1'|sort|uniq -c|grep -v "      1"
        
        If there are any results, it means occurrence of some collision.
        
        Change-Id: I252c582bac7d92e98e56c2834715e1766244aa52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183446
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-28  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [bd1c60bcf290d50a8d496246a785f346a20af04d]

        [API CHANGE] tdf#74580 Add option to skip filter settings dialog
        
        Introduce a new set of setting under org.openoffice.Office.UI/FilePicker
        to control whether the settings dialogs of filters always appears. Add an
        "Edit Filter Settings" checkbox to the File Open dialog, using the new API
        constant FILEOPEN_READONLY_VERSION_FILTEROPTIONS (TemplateDescription.idl)
        to show additional controls: "Read Only", "Filter Options", and "Version"
        listbox.
        
        Modify the Calc's Text Import filter settings dialog to include an "Always
        Show on Import" checkbox.
        
        Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com>
        
        Change-Id: Ic7bea0036ae2db8f8ab223f48499fb0cc8b18425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183055
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-28  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [1d04721870ab60cb6d66d99dc62ee21eee02232f]

        tdf#163691 Replace memcpy / memmove with std::copy / std::copy_backward
        
        Change-Id: Icaead7aadedd8734a2f862c7c684f2846c1e2fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183418
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-28  Marco Cecchetti  <marco.cecchetti@collabora.com>  [264ec12d917fe7cda4ad52d38c50d31e8f0d3cff]

        lok: slideshow: support effects applied to a group of shapes
        
        What has been achieved:
        - when a group is animated a layer with all shapes belonging to the group is
        created and marked as an animated layer
        - any effect applied to a shape belonging to a group (animated or not) is
        discarded
        - any effect based on color animations applied to a group of shapes is discarded
        
        For the last 2 points, we mimic the same behavior that occurs on LibreOffice.
        
        Unit tests for several scenarios as been provided.
        
        Change-Id: Ie094ac2a6a85f08e0e873062b0a780fe322c83bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183448
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [d9df9ebe8562536df29fa1b4c6aeafdd7adf6542]

        expat: upgrade to 2.7.1
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_1/expat-2.7.1.tar.xz
        
        Change-Id: I10c3e609f1711afeceb5dad2ee871e305cccdf8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183444
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-28  Miklos Vajna  <vmiklos@collabora.com>  [1c5f8e7cafbdfe726e0e62e7691de5dd98430155]

        cool#11320 xmloff: warn, but not fail when can't export a numbering style
        
        It's not clear how to reproduce this problem, but when it happens, an
        ODT file can't be saved because of an unhandled exception while
        producing styles.xml.
        
        Digging deeper, a container::NoSuchElementException is thrown in
        XStyleFamily::getByName(), and when that happens the backtrace is:
        	#0  (anonymous namespace)::XStyleFamily::getByName (this=0x28fb8740, rName=...)
        	    at sw/source/core/unocore/unostyle.cxx:1031
        	#1  0x000075ae461d5d8c in (anonymous namespace)::XStyleFamily::getByIndex (this=0x28fb8740, nIndex=0)
        	    at sw/source/core/unocore/unostyle.cxx:1027
        	#2  0x000075ae541c4d77 in XMLTextListAutoStylePool::XMLTextListAutoStylePool (this=0x75ae243c1318, rExp=...)
        	    at include/com/sun/star/uno/Reference.h:384
        I.e. the XMLTextListAutoStylePool gets the NumberingStyles style family,
        nStyles is 15, we try to get each numbering style by index, but already
        the first fails, because 0 gets turned into a 'Keine Liste' (no list)
        name, but getting that internally by name then fails.
        
        Fix the direct problem by catching container::NoSuchElementException in
        the XMLTextListAutoStylePool_Impl ctor, not expoting a list style is
        better than not being able to save the document at all.
        
        Almost certainly this is an effect of a problem earlier, but this should
        improve things till reproducer steps are found for that problem.
        
        Change-Id: Ia9fbe8db9dfe5f90f2583111c3d59b98a914798d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183445
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-28  Jesus Solis  <solisj@alum.mit.edu>  [95c42616b7d4b6ff7f6088d29399fb9e9be6c833]

        tdf#132293 remove unused imports
        
        Change-Id: I4feced18070ff9e4a0f631a56b4b0c8b0b6a1948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183358
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-28  Manish  <mailmessgcnect@proton.me>  [e23e0132d5c304e88c5571e32c84f6c4717ba5e9]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: I1a7a8b924fcd3f5e909ab42f560efb6f8d87654e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183415
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-28  Jim Chen  <jim.chen.1827@gmail.com>  [c448bb47544968f9557f4b319c5158cd95521266]

        tdf#143148 Replace #include guards with #pragma once in vcl
        
        Replaces include guards in headers with #pragma once directive
        
        Change-Id: I7e4f6a84ddb9895b294016e74f55522c78c071c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183255
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-28  Heiko Tietze  <tietze.heiko@gmail.com>  [85b07269cd25a6dfb796558fd1e970c72ded577d]

        Resolves tdf#124673 - Insert > Horizontal Line must not toggle
        
        The command does not insert some element but applies a built-in style.
        And since styles are mutually exclusive it correctly toggles on/off.
        The patch moves the style to the correct place in order to keep
        it searchable. In the long run we probably better remove it.
        
        Change-Id: I03b42c4c97e350141110ee0851575528eb9f5dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183289
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-28  Mohamed Ali  <mohmedali1462005@gmail.com>  [e71eab276666729d421cb5c6601ac9a6636dd4be]

        Add validation to pStandardPage pointer to avoid accessing a null pointer
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sd/source/core/drawdoc3.cxx(780): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sd\source\core\drawdoc3.cxx(766) : warning C6011: Dereferencing NULL pointer 'pStandardPage'. : Lines: 640, 647, 650, 651, 664, 666, 667, 669, 672, 676, 677, 678, 680, 686, 687, 688, 690, 699, 708, 719, 726, 729, 730, 732, 737, 752, 753, 755, 758, 760, 763, 765, 766
        
        Change-Id: Ic3c6253be150c2689499d4118d5b2b8c88c4da68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183426
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-28  Marco Cecchetti  <marco.cecchetti@collabora.com>  [35b4c3596dc57502e9d6fe5e37fc6bbba079d4c0]

        lok: slideshow: support for skipping bg and mp rendering - followup
        
        Unit test helper function needs to provide info about the layer group
        and index
        or in case of test failure we don't know on which layer occurred.
        
        Change-Id: Ie667e3efd781fb75b66de74accd032fc2539be82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183409
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e9e0f720f1b6fd5692fb4556e5932877195ce43]

        loplugin:constparam in sw
        
        Change-Id: Ic169c3c090d5617fb22d9dbb6c09dc3ec69e57fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7d0b0d6b929b93a4972af43a979a53a90c5ae1d]

        fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlock (2)
        
        similar to
            commit c02c75ba1e748ee72f299464fc6cf34f9ddc9298
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Mar 27 14:28:02 2025 +0200
            fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlock
        
        deadlocking threads are
        
         in privateSnippetExecutor
         in connectivity::hsqldb::ODriverDelegator::shutdownConnection
         in connectivity::hsqldb::ODriverDelegator::disposing
         in privateSnippetExecutor
         in dbaccess::OConnection::disposing
         in dbaccess::OSharedConnection::close
         in SingleSelectQueryComposerTest::tearDown
        
        and
        
        Thread 42 (Thread 0x7f7d6e672700 (LWP 3544697) "DocumentEventNo"):
         in comphelper::SolarMutex::acquire
         in dbaccess::ModelMethodGuard::ModelMethodGuard
         in dbaccess::DocumentGuard::DocumentGuard
         in dbaccess::ODatabaseDocument::getCurrentController
        in non-virtual thunk to
        dbaccess::ODatabaseDocument::getCurrentController
         in tdoc_ucp::OfficeDocumentsManager::isWithoutOrInTopLevelFrame
         in tdoc_ucp::OfficeDocumentsManager::isOfficeDocument
         in tdoc_ucp::OfficeDocumentsManager::documentEventOccured
         in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow
         in dbaccess::DocumentEventNotifier_Impl::processEvent
         in comphelper::AsyncEventNotifierBase::execute()
         in comphelper::AsyncEventNotifierAutoJoin::run()
         in threadFunc(void*) (param=0x36a7450)
        
        Change-Id: Ifb8e37a05ce62ca37132e8391980de821bb97ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183428
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [eadd7bfecd0a3570a353a142250136636222775b]

        remove volatile from m_bStateSetInitialized
        
        because volatile does not mean thread-safe in C++
        
        And update comment, because there is no double-checked locking going on
        here.
        
        Change-Id: I7fe8622d4e193387664edf659a408575f2f8d0f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183397
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-28  Julien Nabet  <serval2412@yahoo.fr>  [4b7ddc149990f21a98deb8ba0cc6a97e62b201d7]

        tdf#165928: MySQL/MariaDB direct connection: VARCHAR can be > 255 characters
        
        Change-Id: If3d5163416508d0f9e26978e2d853542f7a01961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183400
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-28  Miklos Vajna  <vmiklos@collabora.com>  [1926105b47df7b15dd34a8c1135f83b936bf9926]

        cool#11357 sw redline reinstate: add a reinstate-and-next command
        
        Accept and reject has a way to do their action & move to the next
        redline, reinstate is missing this combo.
        
        This is because these versions are separate UNO commands and reinstate
        just has the direct .uno:ReinstateTrackedChange.
        
        Fix the problem by adding a new .uno:ReinstateTrackedChangeToNext that
        does this, together with the command state.
        
        Also add it to the menubar.
        
        Change-Id: Ica2358b3fc38cc66e801292ab13f8ba3ec4e9ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183410
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [6b5d160e836772e2ebb536da10329c1d29eb4a0b]

        tdf#165658 Data Provider: Catch exception when importing CSV
        
        Currently, the DataProvider parses the CSV in a separate thread. If an exception happens, LO crashes or freezes.
        
        With this patch, whenever a CSV parsing error happens, it gets caught and an error message is shown.
        
        Change-Id: Ia7e8facfe37f22d03647d94fcdf94ae0ecae10c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182791
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-28  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [fbd888bfc8e916361afbc55dbfa329ebaab6d2d3]

        tdf#158068: Replace OUString literal with u'...'_ustr in getOSVersion
        
        Change-Id: Id8a706cd3f906d37f865080f154aabcfac2647cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183387
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-28  خالد حسني  <khaled@libreoffice.org>  [742dbb088b44783c3a4f0fd120b11be3a74fd483]

        Revert^2 "tdf#163213: do not show OpenType features if the font has "morx" table"
        
        This reverts commit 378dd9025e39f7a4e575ba09b7bde8e038fc0b26.
        
        Reason for revert: The user report that resulted in the first revert was bogus and based on user misunderstanding
        
        Change-Id: I511386fb66bb1026da46cef9939c7108f9516318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183423
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2025-03-28  Oliver Specht  <oliver.specht@cib.de>  [a22f83249699b41317f2d6923878c369e0344598]

        tdf#133352 Undo HasDirectFormatting flag of table box
        
        With 09fc6fef2d03ca8558dd6f0eec45d61ceb282cb5 a mbDirectFormatting flag
        has been added to table boxes. This is now also restored in undo.
        
        Change-Id: I3b8c22c0c452be3dd4b2f203a0ac5b9fdc7488d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183347
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-03-27  Oliver Specht  <oliver.specht@cib.de>  [80e7e76b25881ca500c51ee91cfba3687a49b1f6]

        tdf#165329 Improve fix of tdf#163634
        
        Broken loading of text boxes with relatives sizes is fixed here.
        
        Change-Id: I180850d746aa9e92d0de13b3eb594f3bb754899e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183341
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-27  Oliver Specht  <oliver.specht@cib.de>  [1a081416db0b89a392bcb187a9792b9b6fc75dbb]

        tdf#165923 top margin import fixed
        
        Top paragraph margin needs to be reset to default if not repeated
        at the paragraph itself.
        
        Change-Id: I02b92a6893122add3a7aa59d58e0c4fe52aba98a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183390
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [14f8c60896f3a56e7ff8941311148f18659b53af]

        static/README.wasm.md: tweak code blocks for consistency
        
        Change-Id: I1f98d8477f9e19fddaca13953a674bfd470c2256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183413
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [7502c56675dd99f0e168707c75caa08713238835]

        convert volatile bool to std::atomic<bool>
        
        volatile does not mean thread-safe in C++
        
        Change-Id: Iea5f38f4cb0db56634c904d66da275bd2d5e90b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183393
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5ee8258ff3ea660504467397313ae0ff54175b27]

        tdf#165836 - Page style header/footer HelpID
        
        + Page style' header and footer dialog share the same .ui file
        
        + Under SAL_USE_VCLPLUGIN gen and kf5, the controller send HelpID for
          "frame1" widget, thus it was impossible to separate help for header and
          footer.
           + added variable m_xFrame to catch frame1 widget and assign HelpId
             according to logic in the contructor.
        
        + Under gnome, use the existing m_xContainer, that is, the issue does
          not show.
        
        Note: this is a hack. For gen and kf5/6 it should be like gnome.
        
        Change-Id: Ief6d17689361b1446e7e76bf59dbe962397614cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183353
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [811935d900e4e5e3eebb9e7566e2507de4f4e880]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7227c7e904fceaecacb16c74b057c869686f012d
          - tdf#165836 - Page style header/footer HelpID
            
            Help part
            
            Added Help page for Header and Footer page floating menu.
            
            Change-Id: Ie3672d59861d1f6731177f8906899a0aa44f1c38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183355
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-27  Jonathan Clark  <jonathan@libreoffice.org>  [6818bc55ff248c59f12b2e090139eff30fe949dd]

        tdf#88908 sw: Add BalanceSpacesAndIdeographicSpaces compat option
        
        Added a new Writer compatibility option, as noted. When enabled, Writer
        adjusts the width of certain normal space characters to one half the
        width of a CJK ideographic space. This adjustment is only applied to
        leading and trailing spaces, multiple sequential spaces, and spaces
        between CJK characters.
        
        This flag is enabled automatically when importing DOCX files with the
        w:balanceSingleByteDoubleByteWidth option enabled.
        
        This flag is also enabled automatically when importing DOC files with
        the fDntBlnSbDbWid compatibility flag unset.
        
        Change-Id: I1c666a9894f2e0f302df57203b1cf488cc13000b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183412
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2d9574daf0b15c676deeda189231eee36f2f003]

        libxml2: upgrade to 2.13.7
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.7.tar.xz
        
        Change-Id: Ic65581fd80ebc73d052f934afcf61954fc6e6527
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183407
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-27  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [3da11981797a45f83195d63c20818f315406e3dd]

        Make conversion to Primitives more accessible for EditEngine/Outliner
        
        When checking how TextEdit on the Overlay may be doable in Calc
        I stumbled about that I initially did that based on Outliner
        (svx) for all DrawObjects/Draw/Impress, but it is not accessible
        from EditEngine.
        Calc again just uses an EditEngine for TextEdit in Cell, so I
        checked doability. Quite some stuff has to be changed, basically
        instead of unsing IMPL/DECL_LINK I use lambda functions now. The
        former callbacks were anyways exclusively used for this and had
        no general used case.
        Also simplified and cleaned up quite some other stuff, some
        member functions could be removed, some helper classes deleted
        or simplified/streamlined.
        This should do no change to existing decomposes or edit views,
        but will make it possible to move in the direction of CellEdit
        on the Overlay and also prepares decompositions there to allow
        going in the direction of primitive based paints in Calc.
        
        Change-Id: Ia9c4c1129c9579ba4870b091977082e5f0d319f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183388
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [66b698e64e0c06b6a51ace7eac8a77de67ec3df8]

        convert volatile bool to std::atomic<bool> in DeleteOnDeinitBase
        
        volatile does not mean thread-safe in C++
        
        Change-Id: I80886c24af0f29d644368bb8b922d75a874d4009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b50c234d64e60778aea93afc16413583e813a95]

        remove volatile modifiers in CloseableLifeTimeManager
        
        (a) these fields are only accessed when the mutex is held
        (b) volatile does not mean thread-safe in C++
        
        Change-Id: I0cc1abb2fba5596d73e3a688e4df228d853bf1d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183396
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [8381240aaf9062e70669cd4060fef4cec4454626]

        simplify CloseableLifeTimeManager a little
        
        Change-Id: Iad50da94acc1ad476b98762ff3ab3f0f677d5f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183395
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-27  Nam Bui  <ndbui03@gmail.com>  [ffbc2198363c346c4bf14bb63c3dc99a54dd1f8e]

        tdf#158237 C++20 contains() instead of find(), end()
        
        Use C++20 contains() and std::binary_search() instead of find() and end()
        in sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx
        
        4083: find() != ends() to contains()
        Change-Id: Ia6db458aaca3922278e7e49dee57d83c83b339a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Mike Kaganski  <mike.kaganski@collabora.com>  [3e88456b7135ef2cd0f0121d46cc56436ce56ee5]

        Simplify lcl_FindMarkByName
        
        Change-Id: Ia8c53bc4c31c03870b3f5d1314fe14fa6291d372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183373
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-27  Manish  <mailmessgcnect@proton.me>  [b5ccb7acf05dd04078089ff7a6e2f0f7f32d1cf2]

        tdf#87605 Add NoSQL to the technical dictionary
        
        Change-Id: I0eaa71fff27e7270b4bec72f80be1cee7b05a676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183349
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7b352e023110876f2e47c2b12319c3683f12b1d]

        remove volatile from variable in rtl_math_acosh
        
        which does nothing useful here.
        
        was introduced in
            commit f70de5267d7d9b7b6946cd72fe26e91bb6ac8431
            Author: Kurt Zenker <kz@openoffice.org>
            Date:   Fri Sep 11 18:55:06 2009 +0000
            CWS-TOOLING: integrate CWS odff06
        
        Change-Id: I7a626296db7ac7588cc114db6578e05408d59de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [c02c75ba1e748ee72f299464fc6cf34f9ddc9298]

        fix CppunitTest_dbaccess_SingleSelectQueryComposer_test deadlock
        
        I have seen several deadlocks on jenkins in this unit test, normally
        with stacks like
        
         privateSnippetExecutor ()
         connectivity::hsqldb::OHsqlConnection::flush()
         connectivity::hsqldb::ODriverDelegator::flushConnections()
         connectivity::hsqldb::OConnectionController::queryTermination
         framework::Desktop::impl_sendQueryTerminationEvent
         framework::Desktop::terminate()
        (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*,
        LinkParamNone*)
         (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*)
         Link<LinkParamNone*, void>::Call(LinkParamNone*) const
         in DeInitVCL()
        
        Implement a proper teardown in the unit test so this does not happen.
        
        Change-Id: I3242752dc38d74128fcd134fe7391f04bd64ebc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183391
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Jaume Pujantell  <jaume.pujantell@collabora.com>  [b9b0716438ab3764ea2cc3f9af23cb3437edbafb]

        sc: avoid cursor jump on failed search
        
        When using the command .uno:ExecuteSearch with the SearchStartPointX/Y
        options, the cursor would change position even if no matching string is
        found in the sheet.
        
        Change-Id: I94471b79b00a882489e0c92295c8359d68ee3372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183292
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3f510862bfbcfa4b2b7d94ce7ad917016e5662fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183364
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5440262dd2fc58025702b7172cebe6b9f1c466ec]

        Get at least some information out of coredumpctl
        
        This is not great, but it is a dramatic improvement over the current
        situation (getting nothing).
        
        Change-Id: Id8f9b7f0e87229e4d5aefba448c4f062aac3c204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Mohamed Ali  <mohmedali1462005@gmail.com>  [4db90da301cff5b4bcedbe492d12bfa10e7577b7]

        tdf#45617 Refactor the member function SdDrawDocument::InsertBookmarkAsPage
        
        Break down the monolithic InsertBookmarkAsPage function into smaller, more
        specialized methods with clearer responsibilities:
        - Extract separate methods for inserting all/selected pages
        - Create specialized variants for different insertion scenarios
          (paste, file insert, drag-drop, page links, internal document operations, document import)
        - Introduce parameter structures to better organize function arguments
        - Add dedicated methods for style transfer and master page management
        - Improve code organization with clearer function boundaries
        - Enhance maintainability through smaller, focused functions
        
        Change-Id: If2b8bda0c2e88f25478d534af3f8fa0394017dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179832
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-03-27  Mohamed Zaghloul  <zaghloulmohamed9@gmail.com>  [1d57a6f7fa3b3ea97ce481dc056a1261d269a502]

        tdf#145538 Replace loop with std::find_if
        
        Refactor 'removeControl' method for improved readability and performance
        while avoiding use of index-based-for-loop
        
        Change-Id: Ib89e34dc69ff9f6cdfc94e500463163cd2466245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183190
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [8bbba41d8730212931208434ee63efe913868a12]

        loplugin:constparam in sc
        
        Change-Id: I2aa9b016130918f15a33fadee7fb147aeba18559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183370
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a8ace353634afa9be103b1dc74613c9dac45b8d4]

        tdf#130326 speedup load of complex XLSX
        
        Shaves 10% off load time by avoiding some unnecessary stylesheet work.
        
        Change-Id: Ide5545c4bea16904c62d76e3cf0676bdfddcf267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183374
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Mohamed Zaghloul  <zaghloulmohamed9@gmail.com>  [a790b8f4d554f2e249cd63f524f88940b0166325]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS()
        
        Change-Id: I77f84819915497966aa725e35a416c0e7f5c72c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183185
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-03-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [944420a3e681ff0620a1f69184c4fbe6e41d097a]

        Fix typo
        
        Change-Id: Ib78693f8e042050a972ea1016bbd60e4c75487e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183336
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b0668b6c57ee8a5fce0266df4fce0b73a78873b]

        python3: simplify code in makefile
        
        Mac never executes this code. See
        
        $(if $(filter MACOSX,$(OS)),GeneratedPackage_python3,ExternalPackage_python3)
        
        in external/python3/Module_python3.mk
        
        Change-Id: I928f480945279f13f8ff3c398ddbbed133b9d9ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183369
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [177189b17dd2ba1e6ecdb0736a744cb6c31a40d6]

        windows arm64 requires SDK 10.0.22000 or newer for clang (skia,pdfium)
        
        since the windows headers themselves use intrinsics that are not
        available when using clang. Newer SDK solves that problem.
        
        Change-Id: I0fa8cb05650b7cf87c38f8859bd1d0fc4f10c7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182933
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4a314fcc66fade6c761cc7c7106336c1fd0e672]

        tdf#150623 reduce cost of ColorCfg
        
        when switching tabs on this document, we end up in the ScChildrenShapes
        performance sinkhole, which constructs and destructs ColorCfg a ton of
        times.
        Which should normally be free, but a bunch of logic has crept into the
        outer class, and now we spend a lot of time unnecessarily adding and
        removing an application event listener.
        
        So push that logic down into ColorCfg_Impl, where it belongs, and now
        tab switching goes from 2 seconds to under 1 second.
        
        Change-Id: I4c7a508da0064a11bd4fa0b9251a91a6cda50c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183301
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-27  David Hashe  <me@dhashe.com>  [aaed16eef8b2d32ac02c8cb3a42ca25246cb0d33]

        tdf#69500 Regression test for saving toolbar to document
        
        The regression was introduced in commit da06166015689eca260c702602bef4cea58afbd3
        for tdf#60700 and fixed in commit 42f4261f835ad4ff7d98126cc7fb3be84dc76126
        
        This change adds a regression test to verify that saving a custom toolbar
        to a fresh document works. It passes for master and fails with
        cherry-pick da06166015689eca260c702602bef4cea58afbd3
        
        Change-Id: I569c1172d3e2360a0364768d0b4fa799da9194d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-27  Mike Kaganski  <mike.kaganski@collabora.com>  [f9b487f44fc8a65febafc5ea713e493369be9445]

        tdf#165918: Avoid bookmarks correction when removing temporary nodes
        
        When loading a table, each cell contains an extra node, which is dropped
        when finalizing the cell. The removal of the node calls SwDoc::CorrAbs,
        which it turn calls MarkManager::correctMarksAbsolute. The latter looks
        through all existing bookmarks, checking if they need to be corrected.
        In documents with lots of tables and lots of bookmarks, the time taken
        by eack following call to SwDoc::CorrAbs grows quadratically.
        
        We know, that these extra nodes in cells do not affect bookmarks, and
        it is safe to just skip these specific nodes from bookmark correction.
        
        This speeds up loading bugdoc by 40% in my testing.
        
        Change-Id: I61b587d04c9ae2301d9fef497885fb76c2d3ae74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-27  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [797292f65b214353e407e3d61ded45fb90ac3191]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: Icba16d0ec6782c1d135c693cb840c6a2116c0fa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183163
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-27  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [a07a6d9705c105956a5320d85fed77e03b89257c]

        windows signing: fail build on signtool failure
        
        Previous code relied on brittle stderr parsing to detect signtool
        failures. Let's keep that heuristic, but additionally evaluate exit
        code, too.
        
        Change-Id: I367b5b4dc67569398e1e26891302274f3fb0b30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183304
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-03-27  Oliver Specht  <oliver.specht@cib.de>  [eaac1bfe008e70fd9be59bbcd4b5cfa9c0f8f115]

        tdf#164318 Call copy field dialog on double click
        
        In read only documents a double click on a field executes the
        copy field dialog if the field contains text to be copied.
        
        Change-Id: I83042a95c4320f7fa94b04e53f880d0bc5af92a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183323
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-03-27  Haokun Wu  <hw3068@columbia.edu>  [fa357e4a0a44471637373302c4391e6b0c2f1a20]

        tdf#163691 Replace memcpy with std::copy in basmgr.cxx and image.cxx
        
        Change-Id: I19714fd28f0a859586a4699d0ff01673b5e7e42f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183284
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-03-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c5a0c43f4b3a8626897a6f8d78e602ebc7f35e8c]

        Update git submodules
        
        * Update translations from branch 'master'
          to 10956694ebcfcb29d091ac1b583fcdf56d225540
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I0053225bdf201b5db26226394184d8e24bbbc768
            
2025-03-26  Oliver Specht  <oliver.specht@cib.de>  [ff81c8285103f588bf94ddac533362c8b34e7bd8]

        tdf#158709 Update cell formula if cells change from value to text
        
        Modification of cells that are part of formulas notify
        also if numeric content is changed to text - even if they have
         multiple paragraphs.
        
        Change-Id: Ifb6a35f4c162388d4fadd73e5207a6d3719a9a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180013
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-26  Noel Grandin  <noelgrandin@gmail.com>  [530c42d42984e29fe7356ad446437dd9e0084b00]

        delay calls to SetUpdateLayout(true) some more
        
        until just before we actually need layout info, which removes some unnecessary layout computation
        
        Change-Id: Ia97a50ea0e611cf2238223b17e3a9576d893c57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183312
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-26  varshneydevansh  <varshney.devansh614@gmail.com>  [2a20616d09709427e8cf2474d4721836bce66b8e]

        Move Windows error helpers to comphelper namespace
        
        Previously, WindowsErrorString and WindowsErrorStringFromHRESULT were
        defined in an anonymous namespace in windowserrorstring.hxx, which:
        1. Made them unavailable to other translation units
        2. Violate ODR by creating separate copies in each TU
        3. Require workarounds to access them
        
        Changes:
        - Move functions to proper comphelper namespace
        - Keep implementations inline as they're simple utilities
        - Preserve all existing functionality
        - Update all call sites to use comphelper:: prefix
        
        This change enables proper use of these utilities across LibreOffice
        while maintaining current behavior and performance characteristics.
        
        Introduced in this commit:
        
            commit 94cdcaa4d8db8f03ac9a84dac54357efff3eb123
            Author: Tor Lillqvist <tml@collabora.com>
            Date:   Thu Aug 13 13:22:28 2015 +0300
        
                Add a globally usable WindowsErrorString function
        
        Change-Id: I34df1c2b1f30c6204f107ca4792131d692203880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183332
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-26  Noel Grandin  <noelgrandin@gmail.com>  [437303ab97187116fcbed8a92f4a3fc38065e43c]

        add translate functions for B2D*Polygon
        
        Change-Id: I1f9091c47f0145d6fa0a8bc2deb4864244aad896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183309
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-26  Noel Grandin  <noelgrandin@gmail.com>  [fecf7a6424c39e3f047639797200b61db50d3f2d]

        DeleteOnDeinitBase::gShutdown should be volatile
        
        because we are touching it from multiple threads
        
        Change-Id: I48f5f9c0dc5bb5365e8821259839eb88f8ba0887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183319
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-26  Jonathan Clark  <jonathan@libreoffice.org>  [98057a0e54f39160121f7c88b19250e6085d5343]

        tdf#165510 vcl: Fix incorrect adjustment of bidi MultiSalLayouts
        
        The final step in laying out text with font substitutions is to drop
        invalid glyphs from the base layout and position glyphs from
        substitution layouts in their place. This change fixes a logic error in
        this algorithm which was causing tofu and overlapping characters in the
        frequent case of an all-LTR base layout and an all-RTL substitution
        layout containing multiple fallback runs.
        
        Change-Id: I0d8b03671a77c7d4c41c9ea0f32b526ed44477fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183340
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-26  Miklos Vajna  <vmiklos@collabora.com>  [9c2c98ac7668e4a3a2e3a70cc54b632de5f79621]

        cool#11357 sw redline reinstate: add command state
        
        Go outside a redline with your cursor, the accept and reject UNO
        commands report disabled state, but reinstate is enabled all the time.
        
        This happens because SwView::GetState() handles FN_REDLINE_ACCEPT_DIRECT
        / FN_REDLINE_REJECT_DIRECT explicitly.
        
        Fix the problem by handling FN_REDLINE_REINSTATE_DIRECT the same way: if
        reject is disabled, then reinstate ("reject with history") is also OK to
        be disabled.
        
        With this, reinstate is mostly usable, so add it to the Edit -> Track
        changes menu.
        
        Change-Id: Ic534bc314f0910b1a8376cabe944bfb6f0bc6953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183338
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [e39a1baeb4441e1736022a7fd07668bd5db2cb6e]

        nss: upgrade to 3.109
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_109_RTM/src/nss-3.109-with-nspr-4.36.tar.gz
        
        Change-Id: I2210c384f629ccc9a671c2bb3260b822a302dd1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181773
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-26  Miklos Vajna  <vmiklos@collabora.com>  [44b4ff646ea21df75f9e35b885d76d1aa0d61682]

        tdf#165020 sw DoNotCaptureDrawObjsOnPage: fix left padding for wrap through
        
        Open the bugdoc, the left shapre is partially outside the page frame,
        but is not captured. This is fine, but the text should be clipped in a
        way that only the right half is visible, and instead the left half is
        visible.
        
        This went wrong in commit 61692b82ae4ff62662509b5979a7aabc7d380678
        (tdf#161635 sw DoNotCaptureDrawObjsOnPage: fix handling of left padding,
        2024-06-19), where I assumed that in case the left paddig is increased
        in Word for these partially off-page shapes, then that happens
        unconditionally.
        
        Fix the new use-case by only doing this for non-wrap-through shapes:
        this restores the lack of increased left padding for the new use-case
        and keeps the old one fixed.
        
        Special-casing the 'wrap mode == through' case for off-page positioning
        is not new, SwAnchoredObject::IsDraggingOffPageAllowed() and
        SwAnchoredObjectPosition::GetInfoAboutObj() also takes it into account.
        
        Change-Id: I07dec72e860c810a753c2c356f8f32cc2178b012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183339
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-26  Noel Grandin  <noelgrandin@gmail.com>  [6fd5570cc9ecfd44c104f734e348b42bcea88f8e]

        fix BufferedDecompositionFlusher some more
        
        if the onShot() method is processing a lot of work, and at the same
        time teardown happens, it might managed to restart itself after teardown.
        
        What ended up being easiest is making this its own thread, and calling
        shutdown() on that thread from DeInitVCL.
        
        See notes in BufferedDecompositionFlusher.cxx.
        
        Change-Id: I70fecb259c6e74d2c102065696f7ae2bed15cab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183320
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-26  Kukee Thoo  <kukeethoo@proton.me>  [d40097edc58d93d823d2892e0b12a8ce43669b83]

        tdf#163691 Use std::copy() instead of memcpy() in docpasswordhelper.cxx
        
        Change-Id: Iff549b340de1e385915bc4a985aa6237855cc615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183305
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [ca0bd3a66d468910ea1e70719b7f836b89ab4276]

        nss: upgrade to 3.104
        
        Add uncompr to the static zlib library, otherwise windows build
        will fail with
        
        tstclnt.obj : error LNK2019: unresolved external symbol _uncompress referenced in function _zlibCertificateDecode
        
        because it uses USE_SYSTEM_ZLIB=1
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_104_RTM/src/nss-3.104-with-nspr-4.35.tar.gz
        
        Change-Id: Ide3c6c641a0433f11c5b7ac1897e1bd46d85e51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183092
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-26  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [8994f2a43c2c5930c5fb0bfb7270d28fec9ef140]

        tdf#48140: Replace PropertySet with ScDPSaveData in finalizeImport
        
        Change-Id: If8286bba7170d00dccec23e38fd3a80d348e2c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183277
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-26  Marco Cecchetti  <marco.cecchetti@collabora.com>  [e2cab7cacbe47684725a58f922c7721c4e6a4410]

        lok: slideshow: support for skipping background and masterpage rendering
        
        Change-Id: Id72a0a6aac819dad2d6e3cef2f1434c84693e560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183331
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [535c1f2561570b85c64eab846d6f95da6cf1ff64]

        tdf#150623 reduce load time of complex calc document
        
        this is a bit of a hack
        
        Change-Id: Id14cae908c9139f571ec212089efa5e44d4d5ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a62d9e9bb6b565e83c422066cf1f428173cdc0e0]

        tdf#165910: use sal_Int32 for match count
        
        This is what all the functions called from SwView::FUNC_Search return:
        SwWrtShell::SearchAttr, SwWrtShell::SearchTempl, SwWrtShell::SearchPattern;
        and all of them use SAL_MAX_INT32 to denote 'cancel' state.
        
        Change-Id: Icec9c6b33ebfc856e4a67320f3442324db7459d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183324
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b153b4cd9dc661f1681e9a069c9dcbbd7f2e4e52]

        Fix typo
        
        Change-Id: I0993eb9df114bdfdc76cb920c9675f067160641e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183315
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-26  Justin Luth  <justin.luth@collabora.com>  [c7c543e5f5a361d52dd0cc57379da4304bc3eb7f]

        related tdf#165521 svx: don't start layout until text is set
        
        It has been this way since it svdoashp.cxx
        was introduced in 2004.
        
        Calculating the layout is expensive.
        So why turn on the layout updates early,
        when both SetFixedCellHeight (which can cause a FormatFullDoc)
        as well as SetText (which always triggers a full layout)
        could still obsolete any previous layout results.
        
        Change-Id: I258ae8ffc33cf6221f56a4eb52f151e10d08bb82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183314
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-03-25  Justin Luth  <justin.luth@collabora.com>  [feb3c03b70ac1534a187e390c3bc1604a919ce12]

        related tdf#165521 svx: avoid FormatFullDoc, SetFixedCellHeight first
        
        This ought to be an optimization.
        Typically the outliner is empty before SetText.
        In that case there is nothing to reformat,
        and since a change in FixedCellHeight
        triggers an expensive FormatFullDoc (if IsFormatted)
        do it before SetText to avoid formatting the text twice.
        
        Change-Id: Ib7a72f863a16ecc4c491df1659d743697cdaaabd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183272
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [0b18ae391fd87307cdbde21fa10f009cf4230585]

        tdf#150623 speed up switching tabs in complex calc doc
        
        In some cases, we can use the faster ScTable functions which iterate
        directly over our compressed height data structure.
        Takes the tab switching time from 7 seconds to 2 seconds for me.
        
        Not sure why I had to exclude tiledrendering to make it happy.
        
        Change-Id: Ie438a2d3af5a347face76227e1cba4aaaed3f0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183300
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [6997e953593cfd055485af37bf34f0e7861261e9]

        related: tdf#165821: update test range
        
        based on https://gerrit.libreoffice.org/c/core/+/183154/comment/ffc2be1d_ee0cd770/
        
        Change-Id: Icee71c61cb3f22eabb1e209c2e3cce58f1238ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183306
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-25  Miklos Vajna  <vmiklos@collabora.com>  [447935fba57f1b0f88c0b56cccf5bf971fb1e819]

        cool#11357 sw redline reinstate: simplify ReinstateRedlinesInSelection()
        
        See
        <https://gerrit.libreoffice.org/c/core/+/183291/2#message-27513c9877bf7779293a0ebd556e8da2115a4209>.
        
        Change-Id: Ifb11893d31ca300984234b7ece8610326962e55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183308
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-25  Jean-Pierre Ledure  <jp@ledure.be>  [300ed95296f4c800e2dd23e53bf7313e87f62e1c]

        ScriptForge prettyprint in APSO 1.4.4
        
        The latest version of APSO (1.4.4) introduces
        a new positional argument in the
          def console():
        in apso_utile.py, named 'prettyprint'.
        
        The def is used in
          SF_Exception.PythonShell()
        
        The absence of the argument caused
        an exception/regression.
        The actual patch makes above method compatible
        with latest and previous versions of APSO.
        
        No impact on user scripts.
        No impact on user documentation.
        
        Change-Id: I0a90112d441bba550b330925742e5021665ecee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183265
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [d57c777801c25ea55150329c59910d92a39148c5]

        tdf#165815: sw: Add UItest
        
        Change-Id: I6c3f2ac7b7ca6c96e2ecf83ff90a4461ea7f20e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183303
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-25  Miklos Vajna  <vmiklos@collabora.com>  [157c00922959adc8fd2e0203ed94dfd847479c54]

        cool#11357 sw redline reinstate: handle deletes in selection
        
        In case the cursor is inside a delete redline, then
        .uno:ReinstateTrackedChange works for that change, but if the cursor is
        a selection that covers one or more deletes, then this simply kills the
        selection.
        
        This happens because reinstating creates new redlines, but
        SwEditShell::ReinstateRedlinesInSelection() iterates the redline table
        while reinstating.
        
        Fix the problem by creating a copy of the redline pointers and work on
        that copy, this way all deletes are reinstated correctly.
        
        The command has no explicit state yet, though.
        
        Change-Id: Ia0e7b8365cb423ebf10d8f75aaff30d6495e1f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183302
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a555d35d92f72c8f3247abb1d3212bc06547c71]

        tdf#150623 speed up tab switch in calc
        
        no need to calculate row heights twice on tab switch
        
        Change-Id: I0ac93640d41344a711197bcfd67874b700be23b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183297
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-25  prrvchr  <prrvchr@gmail.com>  [fabdac1af8d30f849a94defd516d6699945f908d]

        tdf#165774 Support for Java instrumentation
        
        Change-Id: I5323eaba60a1dbc6b872550dbbfed0fe989bcd11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183280
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [73d87a030cf9c4245cd86fd7d95f57639f6c87df]

        loplugin:constparam in sd
        
        Change-Id: Ia0e35f9f89773846781f3ba336428dba71b0a05a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183295
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b21dd5ce3a716e6711c805961a5765925fb2be9]

        loplugin:constparam in drawinglayer
        
        Change-Id: I7921dc085e348945f8f14c12a15ed6c5414f298e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183294
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [70638097bec75daeb33454c7c8789c49ab3a8d7e]

        loplugin:constparam in cui
        
        Change-Id: I11d27385b0f666ad17ffb05d645455fb6ddd8ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a94c1371cfa2051b9bbb30166217ccedfa274f58]

        loplugin:constparam in xmloff
        
        Change-Id: I24c536279c5b02b32d564893793fa15672c6f73c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183288
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [8944b5872403d58f0780059b35f16aa5cc4951de]

        loplugin:constparam in svl
        
        Change-Id: Ib975b84d73d6a7012a3d20c69872a0b0039f7929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183287
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [c23d7d4dda56bc35a7ddf2fb0219d4c026187d18]

        loplugin:constparam in chart2
        
        Change-Id: I3d538fe3e97569e9c67c7924ffa585c93d131dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183286
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [81b820a7ea7fded7c30a71a799b9fe1fac1915f9]

        nss: change target from WIN95 to WINNT
        
        In preparation for the upgrade to nss 3.104
        
        In nss 3.103 or older, when OS_TARGET is not specified, it defaults to
        WIN95, See comment
        
        -  When building on Windows, OS_TARGET now defaults to WIN95. To use the WINNT build
              configuration, specify OS_TARGET=WINNT.
        
        in doc/rst/legacy/nss_releases/nss_3.15.4_release_notes/index.rst
        However, in nss 3.104 or newer, WIN95 support has been dropped and
        the WINNT has become the default. It needs some tweaks though:
        
        * Add external/nss/nspr-win95-target.patch to keep building
        nspr with WIN95 target, which is still available in nspr.
        Explicitly pass --enable-win32-target=WIN95 to NSPR_CONFIGURE_OPTS,
        otherwise, it would use WINNT, as nss, and it will fail with
        
        make[7]: *** No rule to make target 'libnspr4.lib', needed by 'build'.  Stop.
        make[7]: *** Waiting for unfinished jobs....
        
        * Add external/nss/winnt.patch.0 to remove the 'lib' prefix as WIN95 does,
        otherwise it fails with
        
        LINK : fatal error LNK1181: cannot open input file '..\..\..\..\dist\out\lib\libplc4.lib'
        
        
        Change-Id: Ifaf19eeb1398389256a5c441a056f542b409622a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183262
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-25  jucasaca  <jucasaca@gmail.com>  [ca109bc22f07774c776b4305d137c55f90ae0b98]

        tdf#165839 Changes the transaction isolation level
        
        Changes the transaction isolation level to allow modification of the
        same table by multiple simultaneous connections
        
        Change-Id: I5db7e55ffbe75e21c5eba56e168deb8e478eb282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183180
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [31eaf2686a1017729d7f7075ce3330b8ea719b56]

        nss: remove unneded patch
        
        This is a follow-up to
        
        commit acf84f9e21999327b831580691430db8c8fe8a71
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Fri Mar 14 12:28:51 2025 +0100
        
            nss: remove obsolete target
        
        In nss 3.103 or older, when OS_TARGET is not specified, it defaults to WIN95
        anyway. See comment
        
        -  When building on Windows, OS_TARGET now defaults to WIN95. To use the WINNT build
              configuration, specify OS_TARGET=WINNT.
        
        in doc/rst/legacy/nss_releases/nss_3.15.4_release_notes/index.rst
        thus, nspr is built with --enable-win32-target=WIN95 as the Makefile
        does
        
        ifeq ($(OS_TARGET),WIN95)
        NSPR_CONFIGURE_OPTS += --enable-win32-target=WIN95
        endif
        
        consequently, the patch added in
        commit 486c91147c587febdacf3fa95d56633dbd703d5f
        Author: David Ostrovsky <david@ostrovsky.org>
        Date:   Tue Feb 23 22:25:06 2016 +0100
        
            Bump nss to 3.22.1 and nspr to 4.12
        
        can be removed. The reason why it was added initially
        is unclear to me though
        
        Change-Id: I9a2acc2b2cdd560fce9166c2e6e11c71ee21b5e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183282
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-24  Patrick Luby  <guibmacdev@gmail.com>  [eba768cb5588c8b3b30a530028b8ee0a67177b18]

        Related: tdf128186 update native collection behavior when window becomes key
        
        The user can enable or disable native full screen mode at any time
        by changing the EnableNativeFullScreenWindows export preference.
        So when an NSWindow becomes the key window, update its native collection
        behavior to match that preference's current value.
        
        Also, AquaSalFrame stores both the maNativeFullScreenRestoreRect and
        maInternalFullScreenRestoreRect in VCL coordinates so convert to
        Cocoa coordinates when setting an NSWindow's frame to one of those
        member variables.
        
        Change-Id: Id0f6559b8272120f745f83129c16d160adadb378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183278
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-03-24  Oliver Specht  <oliver.specht@cib.de>  [fadcf3d1a48ed04308518772a1e7840ff18089f9]

        tdf#165829 Shortcut Shift+Ctrl+F2 assigned to ConvertFieldToText
        
        Change-Id: I42af5bc081e6618789988446d9011f78541b599d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183263
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-24  Oliver Specht  <oliver.specht@cib.de>  [bf52841f339ed13221cac8f7cd9e4e93faccde17]

        tdf#165748 re-save state of portrait/landscape buttons on apply
        
        Change-Id: I7e525d41ce7b46c5086e3ef2112a74485cd46793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183273
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>
        Tested-by: Jenkins

2025-03-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [28f81e8b0e13ef725d2c0993d9bb1c0a5ee3757b]

        tdf#159979 - UI: do not allow Online Update page if the original
        
        Online update is not available (not installed)
        
        This is only a workaround solution for tdf#159979, with removing
        MAR update specific files during msi installation if the original
        Online Update feature is skipped to install, therefor later we can
        check if the Automatic update UI page should be visible or not.
        
        Better/final solution would be if we just skip and not create any MAR
        update files with /core/external/onlineupdate/Module_onlineupdate.mk
        if we are not installing the Online Update feature.
        
        Change-Id: I7e16c694308f7bb196f9f1121bd7a85e368d35b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183119
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [08ef54500089f949e67f184bf61ebfa54d5b3dae]

        configmgr: Let XRegistryKey::getLongValue return boolean values, too
        
        Ever since 21d42ab495d7b7aea103e7e32bd7a436c914f6b5 "#75148# check security and
        netaccess are set now", getJavaPropsFromSafetySettings in
        stoc/source/javavm/javavm.cxx tries to read a Security property (of type
        xs:boolean in officecfg/registry/schema/org/openoffice/Office/Java.xcs) via
        XRegistryKey::getLongValue.  While this may have worked with the previous
        configmgr implementation, it now just always caused an exception (that would
        have been swalled in initVMConfiguration in stoc/source/javavm/javavm.cxx).
        
        Not sure if there are any other places where code expects to read a boolean
        property value from the configuration via XRegistryKey::getLongValue, but lets
        better add that (back) as a (hopefully) harmless extension.
        
        Change-Id: I33ca60595da8fd79fb9250d74f36be0b328d610f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183269
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [941213ec206b6ad1374cdbe70cf8ae9891a651ca]

        Avoid exception when reading nil NetAccess value
        
        The NetAccess property in
        officecfg/registry/schema/org/openoffice/Office/Java.xcs is nillable and has no
        default value, so reading it here via XRegistryKey::getLongValue would typically
        have caused an exception (that would have been swallowed in initVMConfiguration,
        but would have caused the remainder of getJavaPropsFromSafetySettings to be
        skipped).
        
        Change-Id: If53986900917de20366f9517b9eae16227d69cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183268
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-24  Miklos Vajna  <vmiklos@collabora.com>  [db541619cb1ca83598ec479eb9f52e559a8fe72d]

        cool#11357 sw redline reinstate: handle a single rich delete
        
        In case the cursor is inside a delete redline (single-paragraph, plain
        text), then .uno:ReinstateTrackedChange works for that change. If the
        change contains formatting, then that formatting is not copied to the
        insertion.
        
        This is simply because SwEditShell::ReinstatePaM() gets the content of
        the delete redline as an OUString. Doing a rich copy would preserve
        formatting, but then
        sw::DocumentContentOperationsManager::CopyImplImpl() would use
        lcl_DeleteRedlines() to strip away content which is inside a delete
        redline, so that won't work out of the box, either.
        
        Fix the problem by copying the content of the delete redline to a
        clipboard doc and inserting from there, and by introducing a new
        bDeleteRedlines flag (defaults to true). When that flag is off, the copy
        does what we need here: it preserves formatting, but doesn't strip away
        content which was originally inside a delete redline.
        
        Go via SwTransferable instead of invoking
        sw::DocumentContentOperationsManager::CopyRange() directly, because this
        way the inserted content will be inside an insert redline & we get
        working undo/redo out of the box.
        
        Change-Id: Id853844b7282c6b1c36cb0f4f8cc75d968e53dcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183270
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-24  Marco Cecchetti  <marco.cecchetti@collabora.com>  [4da4617266bc816256b6c1d898046ab51080af35]

        lok: slideshow: send fill, line, font colors for an animated layer
        
        We improved the information collected when a layer to be animated is renderered.
        When the fill style is solid we send the fill color for the animated shape, so
        that on the client we can check per each texel if it is part of the shape fill
        and in case substitute the original fill color with the color computed by the
        animation. The same is done for the line color.
        Moreover, in case the animated object is a paragraph, we send the font color.
        
        Change-Id: Iffca357879ef13489c5d943fb5c6faeeaca0d1b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183254
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a2741c9e6083016bba82fa9be06e157a18aaaf07]

        cid#1645088 Data race condition
        
        and
        
        cid#1645104 Data race condition
        
        Change-Id: I91674b3646789cb70ddcea034f34b386c23ea95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183257
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-24  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [7a1de78ec2e58d2cceded3bf03c0c3c3cccc675a]

        tdf#165706 additional taking care in CairoSDPR
        
        The task is fixed with the previous commit for this tdf
        number, but convinced me to do also some more safe stuff
        in the CairoSDPR implementation.
        
        The associated OutputDevice *is* now handed over to
        CairoSDPR and some stuff being done in the helper to
        create the SDPR is now done directly in the CairoSDPR
        constructors.
        
        Also the FormControl rendering is now closer to what the
        VCLPrimitiveRenderer does, to be on the safe side. It
        is still just the FormControl rendering that indirectly
        uses the associated OutputDevice, but more convenient.
        
        The CairoSDPR now also (as VCLRenderer) resets the
        MapMode in the associated OutputDevice for the time
        using it - just in case there might be other *indirect*
        usages like the FormControl one.
        
        Change-Id: I5029788655ff81bf360d98312d417b7886208e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183204
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-03-24  Miklos Vajna  <vmiklos@collabora.com>  [f16c450acea1256b6f65a66c01cfc768bb91e777]

        svx: prefix members of SvxBitmapListItem
        
        And the same in a couple of more related classes, so we can still have a
        single version of the QUERY_PUT_IMPL() macro.
        
        See tdf#94879 for motivation.
        
        Change-Id: I48e9132cef4983b25bafb8c03f595f7855d60e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183252
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b936f80d96b9a1f4646e0ba5371b67eccf302527]

        Adapt to LLVM 21 trunk MemberPointerType change
        
        <github.com/llvm/llvm-project/commit/14f7bd63b95d0f61a6f47119ac66398ca230559a>
        "Reland: [clang] preserve class type sugar when taking pointer to member
        (#132401)"
        
        Change-Id: Ie409324fcf3b98cd733cc46e06ee9e99dc140968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-23  Noel Grandin  <noelgrandin@gmail.com>  [ea1404e42063be2c9737755ffb7528329515f429]

        use more B2DRange::translate
        
        which is much more efficient that using a matrix operation
        
        Change-Id: I8d5f3dae7ac5be0181d84081d94803ced9b86758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183245
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-23  Patrick Luby  <guibmacdev@gmail.com>  [e8f8af2b9872ff8ce646a0278f142cdb5c4005f7]

        Related: tdf#128186 force key window to a native full screen window
        
        AquaSalMenu::setDefaultMenu() is generally called when the key
        window has been closed. When not in native full screen mode,
        macOS appears to automatically set the key window.
        
        However, closing a native full screen window sometimes causes
        the application to drop out of full screen mode even if there
        are still native full screen windows open. So, if the application
        is active, activate all windows to force macOS to set the key
        to a window rather than leaving the application in a state where
        the key window is nil.
        
        Also, add a EnableNativeFullScreenWindows expert preference so that
        users can disable native full screen mode and make the green button
        in the titlebar zoom instead of switching to a full screen window.
        
        Change-Id: I3d9c538d784d7abcd5e75975ea00582768851ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183229
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc2372a7e7418cc0bef78c8753e7ed577304472a]

        cid#1645104 Data race condition
        
        and
        
        cid#1645088 Data race condition
        cid#1645086 Data race condition
        
        presumably the mutex is just for maBuffered2DDecomposition, otherwise
        setting maLastAccess with the mutex held implies all the other maLastAccess
        uses should be protected with that mutex
        
        Change-Id: I918b8854a2abbb8436200c98cf545e217b19bba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-23  Arnaud VERSINI  <arnaud.versini@pm.me>  [94c051433a1c02aa450606038e7930b1b586a006]

        bridges : use frozen unordered map
        
        Change-Id: I8ba732ef5b0e7600c70a2ce880db343945b594bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183246
        Tested-by: Arnaud Versini <arnaud.versini@pm.me>
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2025-03-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cbaabd5f51ae0a5deaaa4edf78ddd4e1ac8faf48]

        cid#1645100 Big parameter passed by value
        
        and
        
        cid#1645099 Big parameter passed by value
        cid#1645097 Big parameter passed by value
        cid#1645096 Big parameter passed by value
        cid#1645095 Big parameter passed by value
        cid#1645094 Big parameter passed by value
        cid#1645093 Big parameter passed by value
        cid#1645090 Big parameter passed by value
        cid#1645087 Big parameter passed by value
        cid#1645084 Big parameter passed by value
        
        Change-Id: Ib81c9d99bdba61bb7354fa9babd710073ead9d90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4fefd0c9ae772f3fc5c09bbb4e8cc489506f13da]

        cid#1645085 Dereference null return value
        
        Change-Id: I5bb9691679a80c53a8285415dfa8ac159d0e69db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183242
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-23  Andras Timar  <andras.timar@collabora.com>  [084c99e0a4073f539bbd6a21a42016e1c256eaed]

        Update license text of Python (see https://docs.python.org/3/license.html)
        
        Change-Id: I8963b4d88ae6bbdf0e31aca12a0803f249778b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183233
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-03-23  Michael Weghorn  <m.weghorn@posteo.de>  [b1576ba17a4111f02fc6f8e27c09c78dbd7fd963]

        tdf#165870 qt avmedia: Handle null media player
        
        QtPlayer::m_xMediaPlayer can be null, e.g. in a PPTX file
        created in PowerPoint that contains an external video link to
        Youtube, so handle that case gracefully instead of asserting/crashing.
        
        Backtrace of assert getting triggered without this change in place:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7ffff789e95c
            2 __pthread_kill_internal pthread_kill.c 89 0x7ffff789e9ff
            3 __GI_raise raise.c 26 0x7ffff7849cc2
            4 __GI_abort abort.c 73 0x7ffff78324ac
            5 __assert_fail_base assert.c 118 0x7ffff7832420
            6 avmedia::qt::QtPlayer::stop QtPlayer.cxx 75 0x7fff980b1675
            7 avmedia::qt::QtPlayer::disposing QtPlayer.cxx 281 0x7fff980b34f7
            8 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7ffff5b3de60
            9 cppu::PartialWeakComponentImplHelper<com::sun::star::media::XPlayer, com::sun::star::media::XPlayerNotifier, com::sun::star::lang::XServiceInfo>::dispose compbase.hxx 90 0x7fff980b0455
            10 avmedia::qt::QtManager::createPlayer QtManager.cxx 32 0x7fff980afc7e
            11 non-virtual thunk to avmedia::qt::QtManager::createPlayer(rtl::OUString const&) 0x7fff980afdbc
            12 avmedia::priv::MediaWindowImpl::createPlayer mediawindow_impl.cxx 212 0x7ffff0bf0d40
            13 avmedia::priv::MediaWindowImpl::createPlayer mediawindow_impl.cxx 193 0x7ffff0bf0a7e
            14 avmedia::MediaWindow::createPlayer mediawindow.cxx 364 0x7ffff0be5860
            15 slideshow::internal::ViewMediaShape::implInitializeMediaPlayer viewmediashape.cxx 391 0x7fff65284f52
            16 slideshow::internal::ViewMediaShape::implInitialize viewmediashape.cxx 309 0x7fff652839ab
            17 slideshow::internal::ViewMediaShape::startMedia viewmediashape.cxx 107 0x7fff652832b1
            18 slideshow::internal::(anonymous namespace)::MediaShape::implStartIntrinsicAnimation mediashape.cxx 212 0x7fff6526578e
            19 slideshow::internal::ExternalShapeBase::ExternalShapeBaseListener::enableAnimations externalshapebase.cxx 68 0x7fff65259ccd
            [...]
        
        Change-Id: I6978f27d9b756a0fa8492d06bed57e805ca23a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183228
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-22  Jan Rheinländer  <jrheinlaender@users.sourceforge.net>  [d9eac4f95649f04e1ddbe5026d8bb323c1fc58d8]

        tdf#164850 Avoid resetting edit flags when resetting column widths
        
        Change-Id: Id679068be1ff175676b9a79c1c847ba86d43a050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180450
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-22  Alain Romedenne  <alain.romedenne@libreoffice.org>  [c0a8ba8066c95b2bf80fe4b74288dfd3f6931808]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c3aecb2749de2eea7c4eb0ad6481fc5eb97d3d7c
          - Explicit FilePicker wildcards in filters
            
            Change-Id: Iba727b603318a9a0786e076966ea40b01383e16c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183209
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-03-22  Noel Grandin  <noelgrandin@gmail.com>  [8c0d8f50717503d8fe45aed95055b2c9e2227c0d]

        tdf#141415 reduce time spent loading language data
        
        cache LocaleDataWrapper because otherwise we spend quite a bit of
        time doing function-pointer-symbol lookups.
        
        Change-Id: Ic1bd07dabac95a2e1bdad70cffbc2b4cabdc62ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183221
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [b417954503efe6f61c42f9d5991148b80ffa3e44]

        gtk3: Fix memleak in get_{primary,secondary}_text
        
        Quoting from the g_object_get doc [1]:
        
        > In general, a copy is made of the property contents and the caller is
        > responsible for freeing the memory in the appropriate manner for the
        > type, for instance by calling g_free() or g_object_unref().
        
        This fixes these 2 memory leaks reported by valgrind when triggering
        the "Save Document?" dialog in Writer:
        
            ==502039== 52 bytes in 1 blocks are definitely lost in loss record 10,157 of 19,684
            ==502039==    at 0x4844818: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
            ==502039==    by 0x1306B2C1: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x13087E72: g_strdup (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x12FE6D7A: ??? (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC58BB: g_object_get_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC5DB4: g_object_get (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x186EBFD6: (anonymous namespace)::get_secondary_text(_GtkMessageDialog*) (gtkinst.cxx:4788)
            ==502039==    by 0x186F3B45: (anonymous namespace)::GtkInstanceBuilder::postprocess_widget(_GtkWidget*) (gtkinst.cxx:24309)
            ==502039==    by 0x186ECCC0: (anonymous namespace)::GtkInstanceBuilder::postprocess(void*, void*) (gtkinst.cxx:24343)
            ==502039==    by 0x1308714F: g_slist_foreach (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x186EC43D: (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(_GtkWidget*, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SystemChildWindow*, bool) (gtkinst.cxx:24426)
            ==502039==    by 0x186D3089: std::__detail::_MakeUniq<(anonymous namespace)::GtkInstanceBuilder>::__single_object std::make_unique<(anonymous namespace)::GtkInstanceBuilder, _GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr), bool>(_GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr)&&, bool&&) (unique_ptr.h:1077)
            ==502039==
            ==502039== 54 bytes in 1 blocks are definitely lost in loss record 10,163 of 19,684
            ==502039==    at 0x4844818: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
            ==502039==    by 0x1306B2C1: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x13087E72: g_strdup (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x12FE6D7A: ??? (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC58BB: g_object_get_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC5DB4: g_object_get (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x186EBE36: (anonymous namespace)::get_primary_text(_GtkMessageDialog*) (gtkinst.cxx:4767)
            ==502039==    by 0x186F3A92: (anonymous namespace)::GtkInstanceBuilder::postprocess_widget(_GtkWidget*) (gtkinst.cxx:24308)
            ==502039==    by 0x186ECCC0: (anonymous namespace)::GtkInstanceBuilder::postprocess(void*, void*) (gtkinst.cxx:24343)
            ==502039==    by 0x1308714F: g_slist_foreach (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x186EC43D: (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(_GtkWidget*, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SystemChildWindow*, bool) (gtkinst.cxx:24426)
            ==502039==    by 0x186D3089: std::__detail::_MakeUniq<(anonymous namespace)::GtkInstanceBuilder>::__single_object std::make_unique<(anonymous namespace)::GtkInstanceBuilder, _GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr), bool>(_GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr)&&, bool&&) (unique_ptr.h:1077)
        
        [1] https://docs.gtk.org/gobject/method.Object.get.html
        
        Change-Id: I0d41a400440b9a1208e9f63d5529a14bc5cf0b1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183218
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [4b06f0e7e280eafbb2d2cfc1d9f2d26823dfe0b6]

        gtk3: Fix another memleak in GtkInstanceBuilder::postprocess_widget
        
        Fixes this memory leak reported by valgrind:
        
            ==502039== 48 bytes in 2 blocks are definitely lost in loss record 10,090 of 19,684
            ==502039==    at 0x4844818: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
            ==502039==    by 0x1306B2C1: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x13087E72: g_strdup (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x12FE6D7A: ??? (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC58BB: g_object_get_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x12FC5DB4: g_object_get (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==502039==    by 0x18C7A79D: gtk_widget_get_tooltip_text (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2417.32)
            ==502039==    by 0x186F2A7E: (anonymous namespace)::GtkInstanceBuilder::postprocess_widget(_GtkWidget*) (gtkinst.cxx:24148)
            ==502039==    by 0x186ECCC0: (anonymous namespace)::GtkInstanceBuilder::postprocess(void*, void*) (gtkinst.cxx:24343)
            ==502039==    by 0x1308714F: g_slist_foreach (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==502039==    by 0x186EC43D: (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(_GtkWidget*, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SystemChildWindow*, bool)
        
        Change-Id: I0cecc055c1b3ae5e7429b60f4a68618f644ed29a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183217
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [9490f58df1c298de18bfea5e7baf425fafe66594]

        gtk3: Fix memory leak in GtkInstanceBuilder::postprocess_widget
        
        While `gtk_widget_get_tooltip_text` returns a `const char*` owned
        by the instance for GTK 4 [1], it returns a `gchar*` for which the
        caller takes ownership for GTK 3 [2].
        
        Use `g_autofree` so it automatically gets freed.
        
        This fixes this memory leak reported by valgrind:
        
            ==499478== 780 bytes in 34 blocks are definitely lost in loss record 18,648 of 19,759
            ==499478==    at 0x4844818: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
            ==499478==    by 0x1306B2C1: g_malloc (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==499478==    by 0x13087E72: g_strdup (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==499478==    by 0x12FE6D7A: ??? (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==499478==    by 0x12FC58BB: g_object_get_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==499478==    by 0x12FC5DB4: g_object_get (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.8400.0)
            ==499478==    by 0x18C7A79D: gtk_widget_get_tooltip_text (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2417.32)
            ==499478==    by 0x186F2E37: (anonymous namespace)::GtkInstanceBuilder::postprocess_widget(_GtkWidget*) (gtkinst.cxx:24221)
            ==499478==    by 0x186ECC70: (anonymous namespace)::GtkInstanceBuilder::postprocess(void*, void*) (gtkinst.cxx:24339)
            ==499478==    by 0x1308714F: g_slist_foreach (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.8400.0)
            ==499478==    by 0x186EC3ED: (anonymous namespace)::GtkInstanceBuilder::GtkInstanceBuilder(_GtkWidget*, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SystemChildWindow*, bool) (gtkinst.cxx:24422)
            ==499478==    by 0x186D3039: std::__detail::_MakeUniq<(anonymous namespace)::GtkInstanceBuilder>::__single_object std::make_unique<(anonymous namespace)::GtkInstanceBuilder, _GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr), bool>(_GtkWidget*&, rtl::OUString const&, rtl::OUString const&, decltype(nullptr)&&, bool&&) (unique_ptr.h:1077)
        
        [1] https://docs.gtk.org/gtk4/method.Widget.get_tooltip_text.html
        [2] https://docs.gtk.org/gtk3/method.Widget.get_tooltip_text.html
        
        Change-Id: I36ce82565f07227683477b682b34dbd77e806478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183216
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-22  Noel Grandin  <noelgrandin@gmail.com>  [4503abd1a6788a5c3cb2168f23b63559a6cabebf]

        tdf#141415 speed up a perf hotspot in SalLayout
        
        a translation is just 2 additions, no need to do expensive matrix math
        
        Change-Id: I76949e6168acc8c50ade358fdccb61575b59a5e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183220
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-22  Jim Raykowski  <raykowj@gmail.com>  [186a2738396e938cc898166b95a02c70a5e22a30]

        Resolves: tdf#165756 - The spotlight view does not display colored and
        
        numbered boxes beside the names of the styles (GTK3)
        
        This first went missing when the surface attributes were dropped in
        commit e3d7473a5611f414bfcf1a3e812248c82f9e9b83 and then again in commit
        7f42f031ed1b9f374f3fcba9c814dc5862492026 when set_image replaced setting
        the image in insert.
        
        Change-Id: Ib5dd05e11fbc3db8f02a777cf7147bfd2b01ae97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183213
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-21  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [81dfc7afcdc473bd655ff64038e8a449a9999c0c]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: Ieb5d3ee0ade0f9657722e05132d260c304de5410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-21  Marco Cecchetti  <marco.cecchetti@collabora.com>  [1efddf160508c2fdd860ad3815c553aaaa6aa460]

        slideshow: create a placeholder even if text field content is hidden
        
        A placeholder always needs to be exported even if the content is hidden
        since it
        could be visible on another slide and master page layers should be
        cached on the
        client.
        In order to support text fields different from the default ones a hash
        is used
        for linking text field placeholder and text field content in place of
        the text
        field type.
        Any text field content should be sent first, so that when the client try
        to draw
        a master page layer corresponding to a text field placeholder the
        content is
        already available.
        Slideshow unit tests have been updated to match the new implementation.
        
        Includes:
        
        	Author:     Marco Cecchetti <marco.cecchetti@collabora.com>
        	AuthorDate: Tue Mar 11 18:46:13 2025 +0100
        
        	    AnnotationTest: UniqueID regression
        
        	    By when incrementing the static counter used by UniqueID has been moved
        	    from getID() method to ctor, it's wrong to expect that created
        	    annotations have consecutive ids.
        
        Change-Id: I845888d141e0f02c2066a9cb17d89ab152bf28b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183201
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-21  Miklos Vajna  <vmiklos@collabora.com>  [e312cf46fe840f04b729600db9efe89d5f58d6fe]

        cool#11357 sw redline reinstate: handle a single delete
        
        In case the cursor is inside an insert redline, then
        .uno:ReinstateTrackedChange works for that change, but if it's inside a
        delete redline, then nothing happens.
        
        This is because SwEditShell::ReinstatePaM() only handles insertions,
        where reinstate/reject means a deletion.
        
        Extend this to have basic support for reinstating a deletion: insert the
        same string after the redline.
        
        This is just initial support, multi-paragraph and multi-portion redlines
        are not yet handled.
        
        Change-Id: I2ca40f572d021be610146d2d25983264d8592ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183203
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-21  Michael Stahl  <michael.stahl@allotropia.de>  [8c548d46f4eacd615527412a0019d7a46150bee6]

        tdf#165851 sfx2: fix loading template with expand URL from configuration
        
        Expand trusted URLs from configuration or extension.
        
        (regression from commit 836d73a65180d89a077e36457f1f3aa1698c2058)
        
        Change-Id: I7c2f8a59b44ae62e25ac26eb568f3f80c77a01ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183206
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b92a45435677f74703a08054f2d5f22f6bc5fb0]

        GetView() seen as null in crash report
        
        Change-Id: I3597bc22a3e36f11b74f3d0925d765625811fa2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183198
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d9ca20a7dce6c6cf0e187ddd866f9f4e581d894]

        Update git submodules
        
        * Update translations from branch 'master'
          to a25cbcee8841b30d23d53ba55da7b51fe72e3b43
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Icecf3a5bef494326b0165fa43da642529a78e04e
            
2025-03-21  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [530fdcafd1283a84f47d891d52211f48da8ff996]

        icon-themes/README.md: How to minify SVG files
        
        Change-Id: I731d7eb9c559d3a4ba30189e5ae8e10e8a3cc3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183199
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [d57d001e277108bdde0bed5740813bde9f2088ac]

        Simplify ToStringHelper a bit
        
        This helped me to workaround a very mysterious problem, that appeared
        in non-debug build (using VS2022 17.14.0 preview 2.0), where a concat
        in cppuhelper::ServiceManager::addSingletonContextEntries looking like
        "/singletons/" + u"com.sun.star.configuration.theDefaultProvider"_ustr
        gave "/single/sincom.sun.star.configuration.theDefaultProvider". The
        problem has survived three 'make clean' and rebuild. No idea what was
        the reason: maybe a specific VS (preview) version's optimization bug?
        Or do we do some spooky memory rewrite somewhere, which happened to
        surface in this case? The workaround helping me is obviously because
        of some code reorganization in the compiler, not caused by functional
        change. (Just for completeness: another workaround was to replace the
        literal "/singletons/" with u"/singletons/", which also helped.)
        
        Change-Id: If01823ccafb6b4c44f99f9a39d849d7c425cc069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183195
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-21  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [6a7e2f4ba5581946adf26195f0782f938c56919f]

        tdf#165706: Fix visualization of MultiFirmControls in EditMode
        
        'Simple' FormControls were rendered correctly with SDPR
        active, but 'Multi' FormControls did not. Found an error
        regarding use of MapModes in that drawing code below in
        vcl that did not handle an evtl. set MapMode, corrected
        that.
        
        Change-Id: I51d7318c2950b7d70e3064ba628909cb17416bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183196
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08cce3e6429e6b5c78c36bf30c4c14e37b25aba7]

        ofz#405177551 Clear invalid AnchorPos
        
        in the absence of a straight forward idea to avoid it in the first place
        
        Change-Id: Ia4f1ee901f2443a1b5414e30752283c6e7da0414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183193
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-21  Zainab Abbasi  <101zabbasi@gmail.com>  [dcbf347c6d8c57361dbecdd5891630e5afd42860]

        tdf#165233 Use lambdas instead of std::bind
        
        Change-Id: I28b611edf9868a4820ea520dc186d912ed065103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182849
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-21  Karthik  <me@karthikreddy.org>  [5a3dd3f0b1e83eca0984b2458fc0f6ee2eb49e4e]

        tdf#165233 Use lambdas instead of std::bind
        
        Change-Id: I1aad4c456ee171b569b49de326c53380d73da071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182448
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [49b71f818d84eb40719e9f18b886f7dd27bb9d56]

        jsdialogs: shortcut legacy mobile-sidebar update
        
        In the past we used UI testing not welding for user interaction
        and updates so it was needed to send full update after every change.
        Use shortcut to avoid unnecessary operations.
        
        Change-Id: Ib3715e2287d6cc8b70db495b93cf09dd9aa20b14
        (cherry picked from commit 6fd6fc9d351527059d7a7ded3155f772c5e0982a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183188
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-03-21  Irgaliev Amin  <irgaliev01@mail.ru>  [13575ca0fb914dbdc075ca6c3a8d7fce370b4807]

        tdf#165371 Reverse page switching direction using mouse in print dialog preview
        
        If there are multiple pages when previewing in the print dialog,
        standard scrolling down (to the next page) will not work.
        
        When a user sees the print preview, they expect to navigate through
        pages using standard scrolling: upwards for the previous page and
        downwards for the next page. However, at this point, the direction
        of page switching is reversed: scrolling upwards takes you to the next
        page, while scrolling down takes you to the previous page.
        
        Change-Id: I534e6f26699d74466a69d9f4f4e8646fb1c9074f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183174
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-21  Oliver Specht  <oliver.specht@cib.de>  [ec8ea016002e2521649e435fc28850ef3f8e5348]

        tdf#165827 Assign id to ConvertFieldToText undo action
        
        Fixes "Replace $1 $2 $3" entry in undo dropdown.
        
        Change-Id: I108cf408ac4f703677d1b013864e6295f7b52e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183173
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-21  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [057c74f7963c78d6038d280facf3133339a766b1]

        Revert "tdf#165803 use COL_WHITE for DOCCOLOR for both light and dark modes"
        
        This reverts commit ddfce993c3d833171b92980476b11c985fb7693d.
        
        Reason for revert: revert in favour of 'per module customization', a better solution for the problem
        
        Change-Id: I746e001bda8ae73f9219fa281a057ed42784bfbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183187
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-03-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [11f7f34b90151b6cb01754a35bad66061322a119]

        tdf#118171 - Snap rectangles of objects without line width
        
        Change-Id: I10d984438826362035add494e0a2431824e36519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183142
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2025-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [d2c08aa8f469c172fe5c9f79713eab5d05aa3f86]

        jsdialog: use const for command data
        
        All used fields are mandatory so fetching them using ::at
        
        Change-Id: I15c9b96c2aae42d49c726ea4e0448befab852a09
        (cherry picked from commit 658bea27f47e66aba625f1e3c2613781daaec14d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183124
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-03-21  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [52225dfaeb78d2c99dfa7b2ef140183accf668a2]

        tdf#165233 Use lambdas instead of std::bind
        
        Change-Id: Ie6a8c76bae10f52d8e97645d71e2825dd59c52c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183184
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-21  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [ef9586eb7de51bd683563bd4caa5c376f687ab47]

        Revert "tdf#164490 Use stronger typed SwClient"
        
        This reverts commit 13c5a3b07e4dd66a80bd20556dffbd96a910bb74.
        
        No improvement.
        
        Change-Id: Ib2c315b0b464068998b299e4f73fffda2a1a4688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183153
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-20  Devashish Gupta  <ashishkrgupta.hajipur@gmail.com>  [d986127690cf6b61e8973ee37e009a1f0dbbc9ca]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Ibfc42cd388f08e5e4c84c2761f6b5ec3f37f7a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183139
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-20  Oliver Specht  <oliver.specht@cib.de>  [00fd41ace152425b886a55fd4868faa976afd6b6]

        tdf#165805 RTF import of \page at table end fixed
        
        With 7d3778e0ef9f54f3c8988f1b84d58e7002d6c625 page breaks
        in tables were ignored in docx import. That is not done in
        RTF import anymore.
        
        Change-Id: I7a0fa859360323376f84570a289ba91079f171cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183096
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-20  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [ddfce993c3d833171b92980476b11c985fb7693d]

        tdf#165803 use COL_WHITE for DOCCOLOR for both light and dark modes
        
        LibreOffice since 1995 has used light as the default background color
        for slides and documents. 'LibreOffice Themes' broke this behaviour as
        it depends on the hardcoded color values for the document colors.
        
        if the desktop environment is in dark mode, a dark document color is
        used. this causes issues for the slides created pre themes as they
        were created with white slide background. issues like black text on
        black background.
        
        this is also concerning because DOCCOLOR is not saved with the document,
        so if someone creates slides/documents with DOCCOLOR in mind, they would
        be disappointed to see the difference.
        
        so the simplest solution to this problem would be to use white color for
        both light and dark modes.
        
        since we would be using COL_WHITE for DOCCOLOR after this patch, it would
        be best change CALCGRID as well, to use a lighter shade of grey in dark
        mode (which would match the document color changes)
        
        changing DOCCOLOR value to COL_WHITE for dark mode broke a sd_tiledrendering
        test it was using the DOCCOLOR to check if dark or light theme is being
        used. commented that test out for now (just for this patch).
        
        reworking themes ui and implementation details to simplify the feature.
        
        Change-Id: Ib1ff7f2ca14110270baa8d6790d76696fd268183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183071
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-03-20  Ujjawal Kumar  <randomforest33@gmail.com>  [6b67355f1275ea296a6a74c8f4d6a9060ff2f8a1]

        tdf#164322 Add "Clear AutoFilter" option in context menu of cells
        
        Change-Id: Id0555f0e89e3e21010b36559bec0caefe63fe8d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182755
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cbe801780abec2894673b2eb0abdfbcff4884ff4]

        Emscripten Qt5: Reliably send cut/copy data to browser Clipboard API
        
        Change-Id: I11204b77649e0543f5350546505dbe965a2a471c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183160
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-20  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [612891865a74777950ab7355a4d794fa5577c5fc]

        tdf#165670 PPTX export: fix glue points export regression
        
        In some cases, we exported non-integer values for the glue points,
        and their positions were also incorrect.
        
        this regression is
        caused by commit Id4a127e7ef462611bf63da791717f8260ec51be0
        (tdf165262 PPTX export: fix shape export regression).
        
        Change-Id: I978fa180ef181391651abad5c2b748e0b606b320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183165
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5e42599f91fc98d7f31c03e45378b95c756964d4]

        loplugin:constparam in sfx2
        
        Change-Id: I3980c28f0b3c024d7c7648db51a69fdf804f54b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [dfe21d378722e90218f2b97cea5c7a449d00b48c]

        loplugin:constparam in oox
        
        Change-Id: Iadec18cc82fd3fa8fb129698be92fed4ec2fbb1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183144
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [76c2a523c6ab19bdaed2b4ad068348b9376d9c59]

        slideshow: set isBitmapLayer correctly
        
        For a layer placeholder the flag should be set to false.
        
        Change-Id: I54c426bf491e681e411e70edba745d74f447a04a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183169
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-20  Miklos Vajna  <vmiklos@collabora.com>  [1df71464588d4cfcba708cf00ef7b6ac94574c8f]

        cool#11357 sw redline reinstate: handle inserts in selection
        
        In case the cursor is inside an insert redline, then
        .uno:ReinstateTrackedChange works for that change, but if multiple
        inserts are selected, then this simply results in a reject with no
        history.
        
        This happens because SwView::Execute() has a bool for the accept, so if
        we have accept/reject/reinstate slots, then by default reinstate is
        handled as a reject (this is not terrible, reinstate is meant to be
        "reject with history").
        
        Fix the problem by adding a new
        SwEditShell::ReinstateRedlinesInSelection() which can decide what
        redlines are in the selection and then by invoking reinstate on these
        redlines.
        
        Similar to accept/reject, it works to only partially select a redline,
        which results in a split: the non-selected part is left unchanged and we
        invoke the action on the selected part.
        
        Change-Id: I21a5896f9bd983d8ca8e2480826421c6bffbe556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183170
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d9bbf0809b3b4722cae9c934ce55cd6189fb67bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d80c8eab1992dd82a197755e9c8e5c35eaff1be5
          - Code sample fix
            
            Change-Id: I3150817f6ba40184f84f9fdaa743dc2c8435789c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183149
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-03-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [2184959586543905d5ccf2a9269fe66ea25cb670]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e187e1497fe9c9dc8f8a5d6380e63604e228bbb1
          - SF_Platform new property
            
            Change-Id: Ibf565f9ffd2acd6fdb9fae91a0e54b57ec4ee562
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183158
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-20  ArsalanKhan04  <arsal4an@gmail.com>  [5db7fb3c7560f883bc0e2882e34904d9b8d7bd0f]

        tdf#165233 Use lambdas instead of std::bind
        
        Change-Id: Iae08fdeed33601d40a4ce6124342ce7765f02653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182880
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b816410089ea57494bf74581dc06cc0bfcd2350c]

        fix BufferedDecompositionFlusher shutdown crash (2)
        
        stopping the timer doesn't seem to be sufficient, try deleting all of
        the contained data at that point in time too.
        
        regression from
            commit 8a17b7f0a679ebf21bcfb425186b205d996d129b
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Mar 13 18:37:54 2025 +0200
            tdf#131595 Improve drawinglayer flushing mechanism.
        
        Change-Id: Ic11f287e83c482bfa81b5efb6b378113d15ecd0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183164
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-20  Szymon Kłos  <szymon.klos@collabora.com>  [24ac93785abdbb7938027e0ab6f5caf2a23f816f]

        jsdialogs: check for empty id
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ie8d51bec10cb1a18704af8bc5d265db999558dd1
        (cherry picked from commit 68fd6a383777027d18f701fa9666ad706a100f26)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183152
        Tested-by: Jenkins

2025-03-20  Vojtěch Doležal  <dolezvo1@cvut.cz>  [8adf0851ee87475d9abe133de8076b39876292e5]

        tdf#165577 Fix bibliography regressions
        
        Fix regressions introduced in b0299c4141f80dfd9989f1f376a960a9590f7a07, i.e.:
        
        1) Do not clear bibliography type options to allow new bibliography entry creations
        
        2) Set the short name so that it is not deleted when clicking Edit after creation
        
        Change-Id: Id3d500872cbbb578fc45cdf75f0b7f7f89144aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182586
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [d3c38d590bec7a2ea3b4415ba21cbd5137121370]

        tdf#165821: sc_uicalc: Add unittest
        
        Change-Id: I06b8b4803a5df590c859b820eeed90811e847ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183154
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-20  Jean-Pierre Ledure  <jp@ledure.be>  [2cb150fd2de0fcbc1c136e11b90e455b40518387]

        ScriptForge (Platform) new UntitledPrefix property
        
        Returns the prefix used to name new documents
        (in English = "Untitled ").
        
        Improves the portability of scripts by making
        them more language-agnostic.
        
        Available for Basic and Python scripts.
        The user documentation should be updated.
        
        Change-Id: Ie3c06e25fdc30fc1c3c775ef6ebbcee1d9cd77cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183134
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6c5f0a41331abb2041394ac19c6653aec4ad0899]

        require Xcode version >= 14.2 (and in turn macOS 12) to build
        
        that was already our documented baseline, but configure still accepted
        older versions of the macOS SDK/older versions of Xcode.
        Xcode 14.2 is the last version available for macOS 12 and it comes with
        macOS SDK 13.1, so we can also require/check for that in configure.
        
        After f4bd60261e6b8c1f7aa273bf985fa597c4e6e6dd
        "Refactor comparison operators for DateTime and Time classes"
        building with SDK 12.1 fails with
        In file included from /Users/libreoffice/lode/bibisect/core258/tools/source/datetime/datetime.cxx:19:
        /Users/libreoffice/lode/bibisect/core258/include/tools/datetime.hxx:74:69: error: invalid operands to binary expression ('pair<typename __unwrap_ref_decay<int>::type, typename __unwrap_ref_decay<long>::type>' (aka 'pair<int, long>') and 'pair<typename __unwrap_ref_decay<int>::type, typename __unwrap_ref_decay<long>::type>')
                                return std::make_pair(GetDate(), GetTime()) <=>
                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
        
        Change-Id: I340180f32c195547a1f93d271e5bbc59252198e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179972
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8f9ede9ecd14ed2679d51fe4c1cc3ed1496c75e]

        tdf#165815 Base crashes on saving edited table
        
        thanks to adamseskunas for finding the source file that contained the
        bug
        
        regression from
            commit 09e2627a83d4769983c39fb2cb260e11fce354f3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 17 11:06:55 2025 +0200
            use more concrete UNO types in some local vars
        
        Change-Id: I6884e5b7b20e45e3e7cfd11d5aa20d6e03ae34d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183151
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3aac8a24148eda2c0f9dc52dd8701f037fb6ccf]

        loplugin:constparam in svx
        
        Change-Id: Ibdac11b615ce28cf0cfbd3ad51ecbc56f5a73154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-20  Rashesh  <rashesh.padia@collabora.com>  [60cfd11276d6cef6f796f7b45ae1da8a29bbe430]

        tdf#165606 fix: master slide panel doesn't resized correctly in gtk
        
        - follow up to 98b86bff2c73
        - the problem was get_rect give 0 height when preview are loading.
        - this patch fixes the problem by taking image size from
        MasterPageContainer
        
        Change-Id: Ie4a3e25826e871ae5cbda58edba092e9a3eae193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182806
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-03-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [2eb772b833842868ba4b0253c42e23c344f05ad9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8742dc36df0890274c66880aaed9d6a92b5c67c6
          - TabPageContainer new facility in ScriptForge Dialogs - part 1 & 2
            
            ref patch# https://gerrit.libreoffice.org/c/core/+/182697
            https://gerrit.libreoffice.org/c/core/+/182865?usp=email
            
            - removed xml-lang tags
            - added missing UNO API properties
            
            Change-Id: I049588de8959be37578c521b4c2f81d2fff591eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182745
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-03-20  Szymon Kłos  <szymon.klos@collabora.com>  [026c26ff143628ab61ebb84abd87069f500f8fca]

        lok: sidebar: do not remember last active
        
        It is done in lok client, do not introduce
        additional state in core part.
        
        Also config modification is costly so good to avoid.
        
        There was rule to always open ElementsDeck in Formula context.
        Move it to a dedicated map with overrides.
        
        We need to not skip context updates when enters OLE second time.
        Introduced in commit 81055959e06848c917c4df1e4f19e1e5c6e70684
        lok: Avoid redundant call to UpdateConfigurations
        But it has negative performance impact - causing to switch decks
        on every key press when 2 users are typing.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ie20181db013a2b7ea1cbb8245b301e55260b8c0d
        (cherry picked from commit f0e226a0057cbbb8904bd8046febf31f7c65d936)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183123
        Tested-by: Jenkins

2025-03-20  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [13c5a3b07e4dd66a80bd20556dffbd96a910bb74]

        tdf#164490 Use stronger typed SwClient
        
        Change-Id: I2afe819dee8fbc9b2a5cfeb6de80f7fc72d33ae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182208
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2dd493c86e532eea636b1ca8aed35fb1214eb750]

        loplugin:constparams
        
        Change-Id: I90c5d427914931d8efa93d3a4efbea55a9475e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [427c83177e2b9c6913c417990f0f9a5df5d32c3e]

        loplugin:constparams
        
        Change-Id: Icf4efa7757d6b3f6ed6066cd07b8fdf4101aae5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183138
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [78a66f99958ed258686cb2fac90f361954b5afe4]

        tdf#165821: don't change range of ScCellIterator outside of wanted bounds
        
        Commit 8e3a29110c8ad739bedeea90932663608d8d3935 (ofz#20904 check bounds,
        2020-02-29) workarounded an out-of-bounds access, by changing maStartPos
        to be in the allocated range. But that meant that functions that wanted
        the data from some specific range, got the data from another.
        
        Fix this by looking for table in the wanted range that has the allocated
        columns in the wanted range (cf. to ScCellIterator::getCurrent(), which
        skips the unallocated area altogether). If no tables have such columns,
        just initialize maCurPos with an unvalid table, which causes first() to
        return false (the same as with invalid tables).
        
        No idea how to make a unit test for this. Adding a formula like
        
        =COUNTA(ABC:ABC)
        
        to the end of sc/qa/unit/data/functions/statistical/fods/counta.fods,
        with expected value of 0, doesn't fail without the fix.
        
        Change-Id: I570cf4a11a410b4e79eb4df785d6c52897973b6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183141
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1d8ff7bd62249ad0f825eaca18ea524d9d7c6c2e]

        XClipboardOwner::lostOwnership is documented to take the old content
        
        ...so passing in the clear()'ed m_aContents is apparently a bug introduced in
        4df7758dbd43c722bab9e3b0f0b21c16a4311937 "INTEGRATION: CWS vcl17 (1.9.52); FILE
        MERGED".  (But convert back to the name xTrans introduced there; it looks more
        meaningful than the xKeepAlive to which it had been renamed in
        b9fe4f26eaf1099b8d0907b8d9cbf52c86914466 "rename some local variables".)
        
        Change-Id: I05254d7f06a956655fdc215c8956aa5f207de42f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183137
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bc77818fc726b1a475f9d06ae5d1374aa2ea4f99]

        Remove some redundant uses of o3tl::narrowing
        
        ...that narrowed to exactly the parameter type taken by InsUInt16 and InsInt16,
        respectively
        
        Change-Id: I59ffd4543d7c40867714dd90786a4366711fa234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183136
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce0d72fbe222d8c839d33f9e3ad56bc195e84ce0]

        fix BufferedDecompositionFlusher shutdown crash
        
        releasing the reference is not enough, we have to call stop() on it.
        
        regression from
            commit 8a17b7f0a679ebf21bcfb425186b205d996d129b
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Mar 13 18:37:54 2025 +0200
            tdf#131595 Improve drawinglayer flushing mechanism.
        
        Change-Id: I6686e1fb1d2509413597ce4fa88b23d99a7e047a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-19  Mike Kaganski  <mike.kaganski@collabora.com>  [599ab8dc3ae9d8b8749b6400e87d98a6dad2a03c]

        Rename con-const vcl::Font property getters for clarity
        
        There are two sets of getters there; and the non-const ones may copy
        the COW mpImplFont, and may call its AskConfig.
        
        The name overload is unfortunate. It is not obvious at the call site,
        which of the two will be called; and what is different. IMO, the way
        to fix it would be to keep only one set of getters (the const one),
        and make the call to AskConfig explicit (in the places that set font
        name, and know that resolution of other properties will be needed).
        
        But in this change, I only rename the non-const getters, making sure
        to keep the behavior unchanged (at least the intention is to have a
        non-functional change, meaning that the places that called non-const
        overload, now use the renamed functions), to make it clear where we
        actually may copy and initialize it.
        
        Change-Id: I9a5cd91d5c1c0de7ff8577b9b982d165e4cdd2c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183116
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-19  Miklos Vajna  <vmiklos@collabora.com>  [7af8b3d3305fe8344cb9339269c5dc3f1cd44650]

        cool#11357 sw redline reinstate: implement this for a single insert
        
        When reviewing a document with tracked changes, sometimes we want to
        reject a change with history, which is currently hard to do on the UI.
        
        For a single insert, a workaround is to select the insert redline and
        then press delete, that'll create a delete redline on top of the insert
        one.
        
        Fix the problem by adding a new .uno:ReinstateTrackedChange UNO command
        that does this for the insert redline under cursor.
        
        More cases (e.g. handle all selected insert redlines) are still to be
        handled.
        
        Change-Id: I61dbe38bcfffc9a0a9cf009531d8bf28cfd1e13b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183115
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-19  Jonathan Clark  <jonathan@libreoffice.org>  [15aa055adfb8e52d593a3302e283ec15b03900ff]

        Fix ubsan out-of-range int in DOC export with CJK hanging indentation
        
        As seen in:
        
        > /include/o3tl/safeint.hxx:227:78: runtime error: -200 is outside the range of representable values of type 'unsigned short'
        >    #0 0x7f8cd335b5ec in unsigned short o3tl::narrowing<unsigned short, double>(double) /include/o3tl/safeint.hxx:227:78
        >    #1 0x7f8cd341698c in WW8AttributeOutput::FormatFirstLineIndent(SvxFirstLineIndentItem const&) /sw/source/filter/ww8/ww8atr.cxx:4358:32
        
        during CppunitTest_sw_ww8export4::testTdf80596Hanging
        (<https://ci.libreoffice.org/job/lo_ubsan/3500/>)
        
        sprmPDxc* attributes contain signed 16-bit integers, as they may
        correctly be negative in the case of hanging indentation. However, they
        were previously serialized as if unsigned.
        
        Change-Id: Id7f6ed465876d5c471ad3ed5c37134db98b0f8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183122
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-19  Marco Cecchetti  <marco.cecchetti@collabora.com>  [13df4f19a8bb849417fefeb883c90be32613e5b9]

        slideshow: render text shape with all paragraphs animated properly
        
        When all paragraphs of a text shape are animated, the render pass related to the
        non animated part of the text shape was rendering all the paragraphs instead of
        the text shape background only.
        
        Change-Id: I1b4d9e301efe569b2b26bec19f569ff54ef61182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183114
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-19  Ujjawal Kumar  <randomforest33@gmail.com>  [1b03f6ea0362a38c6c4e5e767fcb5cf87ddd28dd]

        tdf#149825 Add command to insert a paragraph break before table
        
        Change-Id: I7af1a4bba7222f7989aa99bc158f6e4081aad226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182873
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-19  Taichi Haradaguchi  <20001722@protonmail.com>  [1fa0e101740d2805cebc3b815aaa78927ee9b9fb]

        Fix alignment of the RID_SUBSETSTR_EGYPTIAN_HIEROGLYPHS_EXTENDED_A definition.
        
        Align the NC_ macro parameter in the RID_SUBSETSTR_EGYPTIAN_HIEROGLYPHS_EXTENDED_A definition with the rest of the definitions for consistency.
        
        Change-Id: Iebafe88a5665d93fe2d180bf0cf2bffc7e70b8b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183099
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a59819d0765024b6d2be09eec87f4701d7afbcbe]

        Fix typo
        
        Change-Id: I42884b818969891a993e451d4c23b0925130baf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183061
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3bf06ce8df1fa0e121d284914ec0ad65be3473ca]

        Fix typos
        
        Change-Id: Ia38dd2e506e2fbbaa778c717de92ef7c1e3d108f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183060
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d446029007914e23a9b93df1a0164d95e6b8c79b]

        Fix typo
        
        Change-Id: I9510e40f5a83ef53cf369f80aa2b6db777e33064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183106
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [474b1a67c5f9b6d54a45f7ac6ed1fe3f510b1f58]

        Fix typo
        
        Change-Id: I200ade1a34cd3b567258daaba546f9e572390d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183105
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aecaa87a126a6d84a1a8975ef4c150b0be5ae24b]

        Fix typo
        
        Change-Id: I2f7dd73ab410c4006a29e31e0cf36565608a4aeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183104
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [98c8077893044453ca76ad2a34c6d86d9be0c2c7]

        tdf#165808 fix always visible Quickstarter UI frame
        
        Better to check SID_ATTR_QUICKLAUNCHER is set at all with
        GetItemIfSet, then with GetItemState, because if
        ShutdownIcon::IsQuickstarterInstalled is false we simple disable
        the item with rSet.DisableItem( SID_ATTR_QUICKLAUNCHER ); and later
        the disabled item is removed from the itemset therefore the original
        SfxItemState will be SfxItemState::DEFAULT.
        
        regression from commit: b8e393686c4ab6a69b091240065f440eadfff230
        
        Change-Id: I6ce85798100d93dd3f712abc8ede2087b912b867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183041
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-03-19  Miklos Vajna  <vmiklos@collabora.com>  [c4c399219932318e04ee98fa89b0a59b56b855e9]

        officecfg: fix indent
        
        After commit e846c8e5ed07e6b67a4375dd8ab4d4ca30fd9066 (tdf#45946 Add
        function to convert field to text, 2025-03-17).
        
        Change-Id: I58f1ade9f208475378404feb5d94ea4a00d023bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183117
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-19  Szymon Kłos  <szymon.klos@collabora.com>  [b29f2a8b00f82a16bee5aaea579ccaab691202ce]

        lok: don't invalidate on theme switch
        
        In LOK invalidation means: content was changed.
        Apart of tiles we send the background color so
        client already knows - has to redraw and new
        rendering state options also trigger notifications.
        
        LOK with this knowledge will request tiles in new
        theme variant if not having them already in the cache.
        
        Invalidation was causing the cache in WSD beeing cleared.
        What caused expensive redrawing of all tiles needed later.
        
        Especially visible when joining with new view or dark mode
        switching.
        
        Old logs:
        
        [ kitbroker_001 ] TRC  KitQueue(2) - pop child-04c uno .uno:ChangeTheme {"NewTheme":{"type":"string","value":"Dark"}}| kit/KitQueue.cpp:410
        ...
        [ kitbroker_001 ] TRC  Should we trim our caches ?| kit/Kit.cpp:1057
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_VIEW_RENDER_STATE] [SD;Dark].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  postMessage called with: client-04c canonicalidchange: viewid=5 canonicalid=1001 viewrenderedstate=SD;Dark| kit/Kit.cpp:832
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR] [1c1c1c].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_INVALIDATE_TILES] [EMPTY, 1, 0].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_CALC_FUNCTION_LIST] [hidetip].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_VIEW_RENDER_STATE] [SD;Dark].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR] [1c1c1c].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_VIEW_RENDER_STATE] [SD;Dark].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback [5] [LOK_CALLBACK_APPLICATION_BACKGROUND_COLOR] [1c1c1c].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        [ kitbroker_001 ] TRC  Document::ViewCallback [4] [LOK_CALLBACK_INVALIDATE_TILES] [EMPTY, 1, 0].| kit/Kit.cpp:1158
        [ kitbroker_001 ] TRC  Removing smaller invalidation: EMPTY, 1, 0 ->  0 0 2147483647 2147483647 1 0| kit/KitQueue.cpp:231
        [ kitbroker_001 ] TRC  Document::ViewCallback end.| kit/Kit.cpp:1214
        ...
        [ docbroker_001 ] TRC  Removing invalidated tiles: part: 1, mode: 0, x: 0, y: 0, width: 2147483647, height: 2147483647, viewid: 1000| wsd/TileCache.cpp:282
        ...
        [ docbroker_001 ] TRC  TileCombined request for  nviewid=1000 part=1 width=256 height=256 tileposx=0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200,0,3840,7680,11520,15360,19200 tileposy=314880,314880,314880,314880,314880,314880,318720,318720,318720,318720,318720,318720,322560,322560,322560,322560,322560,322560,326400,326400,326400,326400,326400,326400 tilewidth=3840 tileheight=3840 ver=-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1,-1 oldwid=1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1 from wsd| wsd/DocumentBroker.cpp:4371
        
        It makes big performance impact.
        Recently this code was reworked in 77ae7611fb2a670bb567718ce2cd3c4cc2fd9660
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I4d295c526638ab199d50f284d962da411f18b7b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181860
        (cherry picked from commit 6a7591039e0de8490fc5934ef1ed7238c3166646)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183056
        Tested-by: Jenkins

2025-03-19  AhmedHamed3699  <ahmed.hamed03@eng-st.cu.edu.eg>  [08c170b2fa0ceaae388da4ddbed0330bd57a663a]

        tdf#61313: Allow customization of conditional formatting operators in icon sets
        
         - Replaced the fixed >= operator with a dropdown to select different operators.
         - Applied the last valid condition for each cell.
         - Fixed an issue where importing an Excel spreadsheet with conditional formatting did not preserve conditions correctly.
        
        Change-Id: Id31522e825e51916db4870fbfb19519745e54660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182760
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-03-19  jlorber  <jlorber@linagora.com>  [4957d832c76598e78a57324dad5b4de7345a33e2]

        tdf#163616 add Match Diacritics to the find bar
        
        Trying to replicate the behaviour implemented
        in the search dialog, while trying to respect
        the previous logic for search bar which
        ignores diacritics and kashida if CTL font
        is enabled.
        In my opinion, the new checkbox should be the
        only parameter ruling whether the search
        should match diacritics or not, but we
        can still ignore kashida if CTL font is
        enabled.
        
        Change-Id: I1b88be26dd80a1ebbcf78c32ade7d5a289e0766c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182212
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-03-18  Patrick Luby  <guibmacdev@gmail.com>  [1c4c24042cbe0ede59513d30a676442f7f238b62]

        tdf#151423 allow trackpad or Magic Mouse to behave like a regular mouse
        
        Give both trackpad and Magic Mouse users the option to restore
        the legacy zoom via Command+swipe gesture.
        
        The IgnoreKeysWhenScrollingWithTrackpadOrMagicMouse preference is
        set to true by default and that disables zooming via swiping.
        The problem is that while trackpad users are able to zoom via a
        magnify gesture, the Magic Mouse doesn't have a magnify gesture.
        
        Since I have not found a reliable way to distinguish a Magic Mouse
        from a trackpad, Magic Mouse users have no obvious replacement
        for the zoom via Command+swipe gesture.
        
        Change-Id: Ic2fa5ba153ecb3d7a7cd4711549288b28e6591d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182740
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b1f913c8ea90c60fed50596e27e2328b1a7d788]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e143bbe99dd72ec8111c6224e6525d5fc87c5092
          - Add precision on Duplicates command fo Calc
            
            + Update How to get
            + Inform on effects of removing cells.
            
            Change-Id: I69e0bfdec4139bdb6c1f151a263295e814c1432d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183086
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-18  Noel Grandin  <noelgrandin@gmail.com>  [e3bf8e0f58355d1460d190bd0b7751f133934573]

        tdf#162343 speedup redline document
        
        we spend a lot of time searching for changes by calling GetTextOfArea.
        
        Speed that up by avoiding intermediate OUString and OUStringBuffer
        creation.
        
        Takes load time from 19 sec to 4 sec for me.
        
        Change-Id: Iae124d3668ddb874ddf12e209348c1f696e5549b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183101
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-18  Mike Kaganski  <mike.kaganski@collabora.com>  [808c56f1ea159209ee35d73c7995806df834f46e]

        Remove redundant check
        
        Change-Id: I0e8a6905851fd74b7eab52e95158c34d66f819b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183088
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e9615765771453230e63409062bf96e45aabe339]

        update credits
        
        Change-Id: I3e823dda94867d45ad34e7c254e0990592856ed2

2025-03-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [c8bfafbbf802a690d94807b6292852bb754818e0]

        nss: upgrade to 3.103
        
        Add initialize() method to hash class: in PDFWriterImpl::emitTrailer
        we need to re-initialize the hash after calling finalize(),
        otherwise update() inside writeBuffer will fail with
        Assertion failure: rv == SECSuccess, at sechash.c:140
        See https://lists.freedesktop.org/archives/libreoffice/2025-March/093075.html
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_103_RTM/src/nss-3.103-with-nspr-4.35.tar.gz
        
        Change-Id: Iebf144be7bce9f45900b427adedc7465e4b2e4e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183075
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a8ce824a210f6300be4275283518a442737b2e77]

        tdf#165800 - fix locking down proxy server settings
        
        We used wrong config key for lock/unlock Proxy
        Server settings.
        
        Change-Id: I2e49b5d3494e04197ea90a6d066c9690b12cc0ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183068
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-18  Simon Chenery  <simon_chenery@yahoo.com>  [067f16627844588b18aba29c2577cd7007134aff]

        tdf#145538: Use range based for loop in docstyle.cxx
        
        Change-Id: I3dc9a319f525e2a22edb125065e9c5dd4e1e0bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182398
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-18  Miklos Vajna  <vmiklos@collabora.com>  [f60266597212b12039b9055de7db1724fd06cd3e]

        tdf#164902 sw DoNotCaptureDrawObjsOnPage: enable non-textbox wrap=no draw objs
        
        Open the bugdoc, the poor layout expects Writer to not capture the shape
        at the top of the page, but we captured it.
        
        This went wrong with commit a0b6587c4acb1d74e1b00904147821640c98b323
        (tdf#161199 sw DoNotCaptureDrawObjsOnPage: capture wrap=none draw
        objects, 2024-06-13), which had a draw obj (part of a draw-fly format
        pair, forming a textbox), that was captured in Word, but not in Writer.
        Notice how the old bugdoc was a textbox draw obj, but the new draw obj
        is not a textbox one.
        
        Fix the problem by once again refining the condition when to capture
        objects inside the page frame. When it comes to draw objects, continue
        to capture wrap=none ones, but only in case they are part of a textbox.
        This keeps the wanted capturing for the old case and restores the lack
        of capturing for the new case.
        
        Note that the in-header shape is actually wrap-through in Word, and at
        the moment not in Writer, which would be also nice to fix, but that's
        not done here.
        
        Change-Id: I163ea9366bb34b09b2319c91c4cd53b82c19964a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183085
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bac07e37a03b82c5033365f8c4f487445b57caec]

        If combobox is UserDraw, then don't bother measuring text
        
        the UserItemSize is all that matters in this case. Which then
        side steps the issue of a sizeable glyph cache in the long
        lived font and styles comboboxes as it no longer gets filled.
        
        cat /proc/<kitbrokerpid>/smaps_rollup |grep Private|awk '{s+=$2} END {print s}'
        
        before: 102684 kB
        after:  100552 kB
        
        Change-Id: Ib8a0a149ca49c17c7b1ff47b6b56c52ae28e6eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183072
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d18e41ca7466ac1488da4e39388a15935991500]

        ImplFontListFontMetric is an o3tl::cow_wrapper so these created copies
        
        const them up to avoid that
        
        Change-Id: I36b0b33d9868feb70824df67d1eefbda9564e153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183076
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [036235278ce569ea657fa7f07ac6b2de40301da2]

        slideshow: render fields slide number, footer, date/time
        
        Add support for rendering of slide number, footer and date/time
        fields to slide layer renderer, with the compatible JSON output.
        But still keep the more generic field rendering in.
        
        Change-Id: Ieaa31c15dc86c3e0dab6d13d914756abace667d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183065
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-18  Michael Stahl  <michael.stahl@allotropia.de>  [59a18d3c3ca4f4543e0de616eaf7e5bdc4488383]

        tdf#165694 package: log specific message for missing data descriptor bit
        
        Guess based on size of holes.
        
        Change-Id: I6209844dd74164fa56329df8f31eb40664b2b7e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183062
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-03-18  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [90490e7436ab8d823994b50472622d1c83fa118e]

        tdf#163691 Use std::copy() instead of memcpy().
        
        Change-Id: I4fbbb4f53542c2b5b86722f7721c51fb8dacd83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183038
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-18  Juraj Šarinay  <juraj@sarinay.com>  [9f687b06fc25156a2a3f4d688b56542612995aa9]

        Improve adbe.pkcs7.sha1 signature verification
        
        For PDF signatures with SubFilter == adbe.pkcs7.sha1, we only
        compared hash values and never actually checked SignatureValue
        within SignerInfo.
        
        Fix bugs introduced by 055fd58711d57af4d96214aebd71b713303d5527 and
        e58ed17e35989350afe3e9fd77b24515df782eac by verifying the actual
        (public-key) signature after the hash values compare equal.
        
        Change-Id: I5fa3d60df214cc5efedd1c0eba6cf1b9faf05360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183059
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [65e6adeff4ebe9c25b409bf9f5ac0b7e03403908]

        load sidebar etc images during preload
        
        Change-Id: Ia2ab12955932913ad0106c699118148750e2b49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-18  Jonathan Clark  <jonathan@libreoffice.org>  [fbb46a2fd940d1b5f4b2782708756f67659c0f38]

        tdf#83844 DOCX import: implement Ch-based LR indentation
        
        Adds support for the leftChars, rightChars, hangingChars, and
        firstLineChars attributes, which are used for character-based
        indentation in CJK documents.
        
        This change also updates import/export of DOC Ch-based hanging
        indentation to correctly match the new behavior implemented for DOCX.
        
        Change-Id: Ib9168d4b5fa14f37ae81ba6ebb5402211ff10fd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183066
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-18  Oliver Specht  <oliver.specht@cib.de>  [a2a88f0073bdd5119745679daa61469e87002579]

        tdf#165717, tdf#165718 additional hack to apply continuous section breaks
        
        Keeps reference to range in front of the current range to
        apply page style to an already available page break in cases
        where the section starts with a table.
        Page number restart is also applied in the old and the new code.
        Remove of dummy section paragraphs introduced with
        b696600821d8aafb63b6a88016d299ef89478f56 is now only performed
        if it is no RTF import.
        
        This causes:
        
          Test name: testHiddenParaBreaks::TestBody
          equality assertion failed
          - Expected: 3
          - Actual  : 4
          - In <>, XPath '/root/page[2]/body/txt' number of nodes is incorrect
        
        But the file is not imported correctly anyway and this is actually
        fixing a bug, so adapt the test file.
        
          rtfimport.cxx:910:Assertion
          Test name: (anonymous namespace)::testContSectionPageBreak::TestBody
          equality assertion failed
          - Expected: THIRD
          - Actual  :
        
        The problem here is that the extra paragraph that is inserted for \sect
        if m_bIgnoreNextContSectBreak is now wrong as it was previously removed
        but no longer is, so don't insert the extra paragraph any more.
        
        But leave the extra paragraph in case it's a frame, otherwise we get:
        
          rtfexport8.cxx:91:(anonymous namespace)::testTdf158586_0::TestBody
          equality assertion failed
          - Expected: 1
          - Actual  : 2
        
        testTd112202 fails, but Oliver says that extra page 6 is an improvement.
        
        Change-Id: Ie9a22f00e75c797762f52e6b865e32002051988c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182830
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-18  Miklos Vajna  <vmiklos@collabora.com>  [0c5953f1adb36ba3c5658050e6fb4b086839f210]

        sw doc model xml dump: show SwRangeRedline IDs
        
        The inner SwRedlineData has an ID, and that was shown, but that may not
        be unique and also e.g. SwView::Execute() works with the SwRangeRedline
        ID, not with the SwRedlineData ID.
        
        Change-Id: Ic855434beaa9ce2ebe6eb02c5dd13721970f8805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183058
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [e1c7923596f39bac8ce926b56a2450911ffde4d8]

        tdf#165678 Handle Duplicates dialog: make "All" checkbox work as in AutoFilter
        
        Change-Id: I5ed547d89ede1fe1ec413b1746b3cb2cd2c551d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182779
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [950cbe4ccf2a95981e40f2a9589b22a403784557]

        tdf#144151: do not adjust row height for font / style preview
        
        In commit bcc51fb2ebdf77a1cc089857775fd742085b45b6 (add support for
        in-place style preview, 2013-08-29), a feature of live preview was
        introduced, to see the effect of not-yet-applied font currently
        hovered in the font list. While doing this, it could recalculate
        row heights (e.g., for auto-wrapped cells).
        
        For large selection, this recalculation may take several seconds.
        Also, this may mark document modified, and also result in following
        UI operations slowdown.
        
        This change prevents this recalculation for the preview. The cost
        is that now the preview could be not 100% correct, but hopefully
        this is much less problematic, than the problems it resolves.
        SID_ATTR_CHAR_FONTHEIGHT (.uno:CharFontName) does the height adjust
        anyway.
        
        Change-Id: If347aa7222cb700d8969dd546727ae437f787d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183034
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-17  Andras Timar  <andras.timar@collabora.com>  [b8167a76f4795a685f5e4d49eccabdcb5d8fddef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 408530b25e361410a1a39d07733baa2ee3c0b937
          - make the word 'and' localizable in Xapian search result template
            
            Change-Id: I57f29701c9080f59ee676c422efbcf180f417757
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182964
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-17  Ahmed Khaled  <gostahmedkhaled@gmail.com>  [7f3b61e5f1c95a9745a9406c213e6616055065e1]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I03d2f624fedb22a00c3360ac6c46a810100ec6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182969
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-17  Simon Chenery  <simon_chenery@yahoo.com>  [39c6e59938f634c2fe40d81620c43a00a1f0e380]

        tdf#165233 replace std::bind and helper function with lambda
        
        Change-Id: I2fb3ff1ef5d9de581a45cd3d0aafbf830b349d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181853
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-17  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [5ea1f5d8e05e24c704a987fd86a1f63fea9c9641]

        Add vcl/README.themes.md for themes implementation details
        
        Change-Id: Ia1df363bc0a8d8d23ce3182504c4d0fb9164245c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182447
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-17  Heiko Tietze  <tietze.heiko@gmail.com>  [95a21d1cd35ca436c5b4a6d0cd923bfc77a2aa22]

        Resolves tdf#45864 - Access to glue point deletion from context menu
        
        Function must not be on the toolbar since .uno:Delete removes the whole
        object eventually; and adding a state methode to disable it sounds like
        over-engineering
        
        Change-Id: If22f38cc0ab44c82ea6155647449f6763d39f64f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183033
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-17  László Németh  <nemeth@numbertext.org>  [e499c8d2fba41c5958e8611f6cb007cca3e62ed9]

        tdf#165354 sw HyphenationKeepLine: apply it on the sidebar
        
        Use the default HyphenationKeepLine=true, when hyphenation
        is enabled by using the sidebar (i.e. Move Line = false).
        Otherwise use the actual HyphenationKeepLine setting,
        when KeepLineType is modified by the sidebar buttons (instead
        of using always the (mostly bad) Move Line = true).
        
        Follow-up to commit f8b9cd8fd13897094a014ad06df406f0c78adc62
        "tdf#165354 sw xmloff: implement HyphenationKeepLine – part 2"
        and commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320
        "tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1".
        
        Change-Id: I25bb8b7a1be518f152b056870a313008aa180edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183031
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-03-17  Simon Chenery  <simon_chenery@yahoo.com>  [478920da0895d8c55827cda8f1d20e1b7fa511ea]

        Add isEmpty() to avoid possible OUString underflow in HelpSearch.cxx
        
        Avoid accessing invalid index -1 if OUString queryStr is empty.
        
        It cannot be guaranteed that callers will always pass a non-empty
        value for queryStr.
        
        Change-Id: I759a4caea5d52371467f58bb5b95edbd3ff7d4d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181850
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-03-17  Simon Chenery  <simon_chenery@yahoo.com>  [d022499adacdc753065d79af56608c034de07b5d]

        tdf#143148: Use pragma once instead of include guards in ucbhelper
        
        Change-Id: Ic6e59aa0d46f6acf47b4c327fafc6de9ceecd01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183007
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-17  Karthik  <me@karthikreddy.org>  [74147823a7c933c796239b00cd9bf89edb899eb3]

        tdf#151551 Remove frame target option from Hyperlink dialog
        
        Remove frame targe option from:
        - Hyperlink Internet page
        - Hyperlink Document page
        - Hyperlink Mail page
        - Hyperlink New Document page
        
        Change-Id: Ifef2bb9e6c15e7c3dfdb327808fac19462e6791c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182803
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [52d3da6b71d12b630d32761fcb0673d2c535b3dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 892fadda32887ed6c1a9995cec548e228d6f1f55
          - Fix a "D'oh! you found a bug!"
            
            + change toolbar images to svg
            
            Change-Id: I0c5817045c1d24039e691d7d9fdaecd121621764
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182932
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-03-17  Oliver Specht  <oliver.specht@cib.de>  [e846c8e5ed07e6b67a4375dd8ab4d4ca30fd9066]

        tdf#45946 Add function to convert field to text
        
        The current field can be converted to it's representing text.
        Exceptions are fields in header or footer that have multiple representations
        like page number or chapter fields.
        
        Change-Id: I62b92b2d0b2ed766a2722ffd804496008b72e792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167900
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-03-17  Simon Chenery  <simon_chenery@yahoo.com>  [288ad65ee8ef93dbcac3334249a39a09ebe4b660]

        tdf#145614 Convert #define CELL_X to constexpr
        
        Change-Id: I46e09f1833bb55634e09d7cc110684cc837ac619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183000
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-03-17  Simon Chenery  <simon_chenery@yahoo.com>  [50fcf2f5f2465bb2873d04b1270bc42aec76290b]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in Condition.cxx
        
        Change-Id: I84925b1734f520fffb9f94255130f7156c6ff8a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182944
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-03-17  Banobe Pascal  <banobe.pascal@collabora.com>  [a6917e60975868d7926faa695336d437b7148660]

        tdf#165736 jsdialog: reorganize style list sidebar panel information hierarchy
        
        The style list sidebar panel components were poorly organized,
        leading to confusion about the relationship between controls and
        their effects. This commit implements a standardized visual hierarchy:
        
         New hierarchy:
          - Toolbar (top-level actions)
          - Settings (show previews and spotlight)
          - Filter controls (filter list)
          - TreeView/FlatView (filtered content)
        
         Previous hierarchy:
          - Toolbar
          - TreeView/FlatView
          - Filter controls
          - Settings
        
        This is a manual port of commit 1804adba875a from co-24.04, recreated for
        co-25.04 because the original patch does not apply cleanly to the target branch
        due to code divergence between the versions.
        
        Signed-off-by: Banobe Pascal <banobe.pascal@collabora.com>
        Change-Id: I2b5661624dcc2fdd24a48a0652d030977bf703b7
        (cherry picked from commit 0bb99a8a5279bf12b650a44504b94cbfca3d8adc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182900
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-03-17  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [144af82ac9a0e2061a8fbb7f14608093ff0ee895]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1b8d1d5d48dbccbdccbf2f57d68f1dce51e645c2
          - tdf#164715 Improve spelling suggestion for Thai
            
            * th_TH/typos-common.txt, th_TH/typos-translit.txt,
              th_TH/test-spelldict.sh:
              - Add test cases and test script.
            * th_TH/th_TH.aff:
              - Add REP entries to cover more common mistakes in typos.
            * th_TH/th_TH.dic:
              - Try to make hunspell suggest proper spellings for typos
                listed in typos-common.txt and typos-translit.txt:
                + Add ph: fields to existing entries
                + Remove/fix more typos found
                + Add entries as necessary
            
            Change-Id: Ia263e392de1e9a8a01a30587f7436c748291e0a4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180311
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-03-17  Shantanu Oak  <shantanu.oak@gmail.com>  [eb443f279243ea22530554ec7c37cf991b7ff48b]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c79a8bfddc5af52101dbc3dcfc4f146efe13cb3b
          - rename hypn to hyph
            
            Change-Id: I41794edb61b430d99293338a9a3befd0aecf9724
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180679
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-03-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [1ae9af0e07ebbc5f15505eeabe05aca25320f541]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5cc566302a96a97ccd3c96ceec141d8b6d5c2104
          - Upgrade Mongolian dictionary to 2025.03.15
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2025.03.15.zip
            
            Change-Id: I6ae0d727c229e06f6ffed65295cc64c61a95c1ee
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/183028
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-03-17  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [6e8a094a1a1d63ed2684900c5e0c4292f8d833a8]

        dereference the pointer iff it's not null
        
        Change-Id: I1dc1a1ef7e03a86292478a39cfd6e145f3eb5630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182973
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-17  Alain Romedenne  <alain.romedenne@libreoffice.org>  [11fccb169bc524d16a1476bec29e990bd0db9f7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 87e6a620e1695371a7fa1b39f60517a4db7d528c
          - VBA Excel method - poorly supported
            
            cf. https://opengrok.libreoffice.org/xref/core/oovbaapi/ooo/vba/excel/XApplication.idl
            
            Change-Id: I6db02e6051c25237b13c4be11169911bde03d419
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183021
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-03-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c5e050943c53f01c6458107bcd3bf381d3c71062]

        slideshow: check JSON content for slideshow rendering test
        
        JSON checks were missing for most tests, while the other tests
        did check the JSON string directly instead of parsing it first.
        
        Change-Id: Ie0733acb24cd982e7e6be3ef719f8ef2e1345ffa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183022
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-17  Miklos Vajna  <vmiklos@collabora.com>  [a0914d9c21efee21496ac432d2720ebb7b87f0d4]

        svx: prefix members of SvxDoubleItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I9164d15ee91c5f49d39b97f9bb1ab07b8750e199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183019
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2cc3a9f4c8c2359b525261ec917bb68fc5e8b6c4]

        tdf#164797 - sw a11y: add new check of links and references in Header/Footer
        
        to warn users about PAC "Link annotation is not nested inside a Link
        structure element." errors, so they can avoid them.
        
        Change-Id: I8d1fc7042e2ee34a5777c3a448d2379038ea24e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182868
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [08d2454dd9ce1c201f04a884e322c9e3e08803e5]

        loplugin:nullptr
        
        Change-Id: I088338591dbacc41a0465d2e5e42f74f0c4dc258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183012
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [493e37d16ce673560ab4309f91308cd5a99944d1]

        Avoid -Werror,-Wnull-dereference
        
        Change-Id: Ibfc0111a61817b7cf8c5b60d3f9563fd3cf05c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183011
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8192e71eca228bb181ced36074f8144f604f969a]

        Simplify OUString -> std::u16string_view
        
        ...following up on 26d0af9ddc98355865c62ce0ffc04c3919ebce87 "Revert 'tdf#158068:
        Replace with static constexpr O(U)String'"
        
        Change-Id: I75464cc7ad310f48d0a79662a5e952d0debeda91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183010
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-17  Noel Grandin  <noelgrandin@gmail.com>  [8a17b7f0a679ebf21bcfb425186b205d996d129b]

        tdf#131595 Improve drawinglayer flushing mechanism.
        
        Which dramatically speeds up switching between sheets in
        the referenced document.
        
        The problem here is that we have a timer for each buffered primitive.
        And we have a lot of primitives here.
        And the TimerManager does not scale well to lots and lots of timer,
        because it uses a linked list.
        
        So this change modifies the flushing mechanism, trading off some
        precision for some speed.
        
        Change-Id: I66a744f06af9b08d4e9b797d11db8d22f4060789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182876
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [f382c1a267a93539f3c169530780889336d20b25]

        svtools a11y: Simplify AccessibleTabBarPageList::getAccessibleAtPoint
        
        * Only convert the vcl Point to awt::Point once, not
          in every loop iteration.
        * Return early.
        
        Change-Id: I267d9b1a188a9f9323dede0f30e46d4c990b188f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183017
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [4465cd882891caae22cf059e5b44f9642dc6d76f]

        tdf#163989 gtk3 a11y: Set a11y parent for native GTK vcl::Window child
        
        When mixing vcl::Window and native GtkWidget, the native
        GtkWidget's AtkObject is correctly reported as the
        InterimWindow child e.g. for the text edit of the combobox
        in the Find toolbar since
        
            commit 39e0bdb686baf76a4c54d12cfa66aa9f08db8c3f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:42:03 2025 +0100
        
                tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        . However, the GtkWidget's AtkObject was not reporting the accessible
        object of the parent vcl::Window as its parent (but presumably the
        next GtkWidget in the hierarchy), which resulted in an inconsistent
        a11y hierarchy: The "a11y object path" top-down is different from the
        bottom-up one.
        This inconsistency e.g. caused Accerciser's "Jump to object" feature
        to not select the correct object in its treeview of the LO a11y hierarchy
        when clicking on the event source of the "object:text-caret-moved"
        AT-SPI2 event triggered by typing in the search bar.
        
        Event displayed in Accerciser's Event Monitor:
        
            65.7 object:text-caret-moved(2, 0, 0)
                source: [text | ]
                application: [application | soffice]
        
        When clicking on the event source, the correct area on screen
        was highlighted and details about the object were displayed in
        Accerciser's Interface Viewer, but the object wasn't selected
        in the treeview.
        
        Bottom-up a11y object path printed via Accerciser's IPython console:
        
            In [2]: obj = acc
            In [3]: while obj:
            In [3]:     print(f'object: {obj}, index in parent: {obj.get_index_in_parent()}')
            In [3]:     obj = obj.parent
            In [3]:
            object: [text | ], index in parent: 0
            object: [combo box | ], index in parent: 0
            object: [filler | ], index in parent: 0
            object: [panel | ], index in parent: 0
            object: [viewport | ], index in parent: 0
            object: [scroll pane | ], index in parent: 3
            object: [root pane | Untitled 1 — LibreOfficeDev Writer 25.8 [f3288f031a2667a8acc7b3c79744fed1db590845]], index in parent: 0
            object: [panel | ], index in parent: 1
            object: [panel | ], index in parent: 0
            object: [frame | Untitled 1 — LibreOfficeDev Writer 25.8 [f3288f031a2667a8acc7b3c79744fed1db590845]], index in parent: 0
            object: [application | soffice], index in parent: -1
            object: [desktop frame | main], index in parent: -1
        
        This is missing various objects as compared to the top-down path
        seen when navigating from the top-level application object down
        to the combobox's text edit in Accerciser's treeview.
        
        Fix this by explicitly setting the parent of the GtkWidget's
        AtkObject to the AtkObject that wraps the XAccessible of the
        vcl::Window. This makes sure the parent <-> child relationship
        is now consistent both ways.
        
        Bottom-up a11y object path with this commit in place:
        
            In [1]: obj = acc
            In [2]: while obj:
            In [2]:     print(f'object: {obj}, index in parent: {obj.get_index_in_parent()}')
            In [2]:     obj = obj.parent
            In [2]:
            object: [text | ], index in parent: 0
            object: [combo box | ], index in parent: 0
            object: [filler | ], index in parent: 0
            object: [panel | ], index in parent: 0
            object: [panel | ], index in parent: 0
            object: [filler | ], index in parent: 0
            object: [panel | ], index in parent: 0
            object: [panel | Find Values], index in parent: 1
            object: [tool bar | Find], index in parent: 0
            object: [panel | ], index in parent: 5
            object: [root pane | Untitled 1 — LibreOfficeDev Writer 25.8 [1d0572a62fcbba1a96438f49b737e2b177e6cb8e]], index in parent: 0
            object: [panel | ], index in parent: 1
            object: [panel | ], index in parent: 0
            object: [frame | Untitled 1 — LibreOfficeDev Writer 25.8 [1d0572a62fcbba1a96438f49b737e2b177e6cb8e]], index in parent: 0
            object: [application | soffice], index in parent: -1
            object: [desktop frame | main], index in parent: -1
        
        This matches the (reversed) top-down object path, and makes Accerciser's
        "Jump to object" feature work for the scenario described above
        when using the gtk3 VCL plugin.
        
        Change-Id: Ibd18aef3c784d63c75ab29287910c31273939538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182992
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-17  Jan Rheinländer  <jrheinlaender@users.sourceforge.net>  [2828191c2370895a074741f946f6132fa05c2be8]

        Revert extra changes merged with gerrit 181017
        
        Merge 181017 included changes that were not required for the patch, only for reproducing the bug
        
        Change-Id: If7284ed822b39d47a64eac751a31699f48ea504e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182999
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [e75bc84d254f022a01bd7bc5444bdfa6cf7deda5]

        vcl a11y: Call AccessibleIconView ctor directly
        
        No longer use AccessibleFactory for this, which was
        needed in the past to break a dependency cycle, which
        is no longer the case since
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        The
        
            // need to be done here to get the vclxwindow later on in the accessible
            css::uno::Reference<css::awt::XVclWindowPeer> xHoldAlive(GetComponentInterface());
        
        part is also obsolete, since the VCLXWindow is no longer
        used by the a11y implementation class.
        
        Change-Id: I36831850da4934c78a8f7a754bca82a02a50f6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [62e9923b78d6b53757b15d815229ebc201ab5470]

        vcl a11y: Call AccessibleListBox ctor directly
        
        No longer use AccessibleFactory for this, which was
        needed in the past to break a dependency cycle, which
        is no longer the case since
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        The
        
            // need to be done here to get the vclxwindow later on in the accessible
            css::uno::Reference< css::awt::XVclWindowPeer > xHoldAlive(GetComponentInterface());
        
        part is also obsolete, since the VCLXWindow is no longer
        used by the a11y implementation class.
        
        Change-Id: I9b6a1a3f000434c2b0d3d856f2ac2ff34ab5ebe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [620e2e1c95acc4d7d6173a9146dbec4c4d6844d4]

        This GetBoxFormat can use the const version
        
        Change-Id: Iabcb2010b79d2e7e34d4f3f5a4d090efc3267408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183006
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [35fd858c76ee1315bcbcb9ab0f23fd19619692b9]

        related tdf#157233: accessibility check is not online
        
        Change-Id: Ica677c9b4d6297c8023f7ba1689b96e45d76b7c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183008
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-03-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [aa8a3dd4e738a88775e1580e6d63657eaee914d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96dc368916f442128a151f09fef1cdf1ed089d06
          - fix name of icon for standard filter
            
            Change-Id: Iefe65552def50afa03cc26b3d39ba5391f08811b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/183009
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d3629748560325e7a0fcd439c69990be1d3853ff]

        cid#1644499 Uninitialized scalar field
        
        Change-Id: I7a1eb07d56bb89baf7f274595ed097598ea4d540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183003
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [09cc1e0b670835905a44840810a4925b075e52fd]

        cid#1644497 Uninitialized scalar field
        
        Change-Id: Ia401830433cdaf13fc5ca8af31b3de8ab9b95c10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183002
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f09e0f49b5b1629f394e1d0f871d8faba24e15e2]

        cid#1644498 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia1d9555a98244e7a0aeecf3a1f084f9c222c8cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [cef2ea134acf20ce3a1bcf681424b1ed2864f7db]

        tdf#135891 - Adjust the x position to ensure the correct starting point
        
        Change-Id: I739f27796ed2bf995a8c11e8e6fe958776a05bfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182965
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fadd1c9791a8dca3b7c03bbeae02cd3053056373]

        make all on-demand s_pDefaultBoxAutoFormat use existing GetDefaultBoxFormat
        
        Change-Id: I75c0d73b48484540be0a728599eaf1e177dcefbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182971
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f8a08b2515342e6ef9d91865bb5262640f81703f]

        -Werror,-Wunused-private-field
        
        ...since 98b86bff2c7350ad9a22eb0db7f7696672c6db51 "tdf#165606 sd: fix master
        slide panel doesn't resized correctly"
        
        Change-Id: Ie67b2cdbb9b870aa299b33ad0b8428ce7eb88618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182996
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [21aad3fb1260988f5c4068c945a34b5233420bfd]

        UBSan apparently needs ScDatabaseRangeObj RTTI now
        
        ...as CppunitTest_sc_dataprovider started to fail with
        
        > [_RUN_____] ScDataProvidersTest::testCSVImport
        > warn:sal.osl:2875534:2875534:sal/osl/unx/module.cxx:103: dlopen(/home/sberg/lo/core/instdir/program/libscfiltlo.so, 1): /home/sberg/lo/core/instdir/program/libscfiltlo.so: undefined symbol: _ZTI18ScDatabaseRangeObj
        
        Change-Id: I4c75c770951dd7ed6506ecd35fd574c28c41381d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182995
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [26d0af9ddc98355865c62ce0ffc04c3919ebce87]

        Revert "tdf#158068: Replace with static constexpr O(U)String"
        
        This reverts commit 817cb41005db87c9bdd63663e5d1d1357d6e5cbc, as it causes
        
        > desktop/source/app/crashreport.cxx:197:26: error: view pointing into temporary i.e. dangling [loplugin:stringviewdangle]
        >   197 |         aCommandSeperator=u","_ustr;
        >       |         ~~~~~~~~~~~~~~~~~^~~~~~~~~~
        
        Change-Id: I787e4997c536f8bb37973da33c9ca1d660f2698c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182993
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b0337333b1314a710e251fa88bf012e0cd682bc7]

        Fix typo
        
        Change-Id: I9b4fd5e80451519db5cb51d254534621dcb7d434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182938
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c22d5ae851269bc405c9825e9897e2add65f4dc7]

        Fix typo
        
        Change-Id: I65ddc856933b40bf4cbe809fafca3e7ad2617843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182935
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e2d1898efb07de1d9251f8c3fd5f774cf02a28aa]

        Fix typo
        
        Change-Id: I7ed74b0a0cd803a81085c6a56431014ae8a71e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182937
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5a2667759b1fddf063d95230ad0c96ed4221578a]

        Fix typo
        
        Change-Id: Idecfe89e597405e228986ce97cd3957b5f2fc8da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182936
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [27ea25bc44af09a791154b36efb5b9e06ea04866]

        Fix typo
        
        Change-Id: Ibcb46c3857eff5da343fad88e0a1d53c317d5634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182991
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c50a42c322a26edfd19c282bd4a17234a635ab59]

        Fix typo
        
        Change-Id: I186c815d9fa3b8539f587cf0208c8ab08330bdb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182990
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [b3a88cd27c326315865cf24f47ee18215496aaa5]

        a11y: Drop unused includes
        
        Change-Id: Icbeb1bb55991d27a57640d7314fb090c6a669742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182989
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [132f22d9f6d58b4e3541ef3e8efe8ef7e3136a23]

        tdf#157003 a11y: Replace AccessibleDropDownListBox Java with C++ test
        
        Remove the existing Java AccessibleDropDownListBox
        tests and introduce a new C++/cppunit test that
        takes a bit of a different approach:
        
        Other than
        
            commit d2a5b4bc0b8c8d1dd82133719a3ef5cc01b0cbbe
            Date:   Tue Apr 26 16:56:56 2022 +0200
        
                toolkit: convert AccessibleStatusBar test to C++
        
                Just translate the test and add required or handy CppUnit helpers.
        
        which basically translated the existing AccessibleStatusBar
        test as is to C++/cppunit, don't do the same here,
        but:
        
        1) Move the test from toolkit to vcl, where the a11y
        implementations for vcl widgets are located since
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        2) Instead of starting Writer and then searching for
        the accessible object of the dropdown listbox in the
        a11y tree, only create a simple dialog that contains
        a dropdown listbox (VCL ListBox with WB_DROPDOWN set).
        This minimizes the complexity/a11y tree to the object
        of interest.
        
        Apart from that, the general logic of what aspects are
        tested is mostly unchanged, now using the C++ helpers
        introduced in the above-mentioned d2a5b4bc0b8c8d1dd82133719a3ef5cc01b0cbbe
        (and later commits) to test the various XAccessible* interfaces.
        
        The XAccessibleEventBroadcaster interface is no more
        explicitly tested, since the XAccessibleEventBroadcasterTester
        would require an XWindow again.
        However, the logic is implemented in the VCLXAccessibleComponent
        subclass used by almost all widgets (vcl::Window subclasses), so
        not explicitly testing it here shouldn't be a problem.
        
        Change-Id: I61bfff515c5e9f7e2d18b9279861c09ceede403e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182986
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [2041fbab92f8d4e789bda625d7f98f486bb791a6]

        vcl a11y: Use sal_Int32 in IComboListBoxHelper::GetBoundingRectangle
        
        Align the param type with what both, ComboBox::GetBoundingRectangle
        and ListBox::GetBoundingRectangle have, which get called by the
        implementation in the only subclass implementation in
        VCLListBoxHelper::GetBoundingRectangle.
        
        Drop unnecessary casting in VCLXAccessibleListItem.
        
        Change-Id: I8f8b7c9f355768a05174b753ac28d0dd60374673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182985
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [ecb19ca12010bc78e9cce3fffdb0c730b64fbec4]

        vcl a11y: Use more specific ListBox subclass in VCLXAccessibleTextField ctor
        
        Use a ListBox* param instead of having a vcl::Window*
        param and documentation stating that this is expected
        to be a ListBox.
        
        VCLXAccessibleTextField::implGetText does a cast to
        ListBox.
        
        Change-Id: I9ef6c4cb8fc7c7fa38af79a8aac7b95d984075b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182984
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [cadee0d0d9906b3f648172e354ad71982e9761bc]

        a11y tests: Introduce XAccessibleActionTester
        
        Similar to how e.g. XAccessibleContextTester tests
        the methods of the XAccessibleContext interface, this
        one tests the methods of the XAccessibleAction interface.
        
        This C++ version is similar to what the Java implementation in
        qadevOOo/tests/java/ifc/accessibility/_XAccessibleAction.java
        does.
        
        XAccessibleActionTester::testGetAccessibleActionDescription is
        more strict in that it also requires that the action description
        is non-empty.
        
        This will be used to replace the existing AccessibleDropDownListBox
        Java test with a C++ one in an upcoming commit.
        
        Change-Id: I41e9fe2fb5011cd8f33dbfc2494b04f4833c43cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182983
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [1b704035f5b5f41e12b2cb9b30bc3e34fd20937f]

        a11y tests: Move more helpers from toolkit to test
        
        Move the XAccessibleEventBroadcasterTester and
        XAccessibleExtendedComponentTester classes from toolkit to test,
        so they can be reused for a11y tests in other modules.
        
        Change-Id: I33e9ee43b9652e6cefcea2ee3264114109f8d9f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182982
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [f3288f031a2667a8acc7b3c79744fed1db590845]

        a11y: Merge OAccessibleWrapper::createAccessibleContext into only caller
        
        Change-Id: I648aa804409fb81152c9136743465cff565eefdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182397
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [11b0139c39123b6cd272f5c3d3eb253b434793d2]

        a11y: Drop now unused OAccessibleWrapper::getParent
        
        Drop the protected OAccessibleWrapper::getParent which
        is unused now after
        
            Change-Id: I3b2182ca953056a939670e73687f4568620a4087
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:42:03 2025 +0100
        
                tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        Change-Id: I45697411ed202015199d10be58b90e26b86e5d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182396
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [92999e090c12751a7928d4952b35ea716e1c8da9]

        a11y: Make OAccessibleWrapper::createAccessibleContext non-virtual
        
        ... and private.
        
        The only override in a subclass was dropped in
        
            Change-Id: I3b2182ca953056a939670e73687f4568620a4087
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:42:03 2025 +0100
        
                tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        Change-Id: I3074ed748e460e0608d28b5312e1fec702a2b8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182395
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [39e0bdb686baf76a4c54d12cfa66aa9f08db8c3f]

        tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        If a toolbar item has a window
        (as returned by ToolBox::GetItemWindow), then the
        toolbar item's accessible (a VCLXAccessibleToolBoxItem)
        should be reported as the parent of the accessible
        object for that item window.
        
        Reporting the item window's accessible as a child is
        pretty straightforward and already implemented in
        The VCLXAccessibleToolBoxItem::getAccessibleChild.
        
        Ensuring that the item window's accessible reports
        the VCLXAccessibleToolBoxItem as its parent and
        the proper index is more challenging, because it
        does not match the vcl::Window hierarchy. (There
        is no vcl::Window for toolbar items, but only for
        the toolbar itself.)
        
        So far, in order to make that work, OToolBoxWindowItem
        was the XAccessible implementation for toolbar item windows
        and OToolBoxWindowItemContext was the XAccessibleContext
        implementation that got returned by OToolBoxWindowItem::getAccessibleContext
        (via the base class implementation OAccessibleWrapper::getAccessibleContext).
        
        Those were subclassing OAccessibleWrapper and
        OAccessibleContextWrapper in order to report
        the parent (and index in parent) as needed.
        
        One effect of this however is that the gtk3 logic
        to include native GtkWidgets that are contained in a
        vcl::Window in the a11y hierarchy, as implemented in
        
            commit 305c6fee0be4db38023d9ca5f7915e443e0bc1fc
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Wed Mar 24 11:33:42 2021 +0000
        
                tdf#141197 if we have a sysobj child then include that in the atk hierarchy
        
        does not work for that case, because it relies on
        the accessible to be an XWindow in order to extract
        the underlying vcl::Window. With OAccessibleWrapper
        being used, that is not the case.
        As a consequence, native GTK widgets inside the vcl ToolBox
        (i.e. non-native toolbar) like the Paragraph Styles or Font Style
        comboboxes or the combobox in Writer's search toolbar
        cannot be found in Accerciser's treeview of the LO a11y hierarchy.
        (There are panels, but the comboboxes inside the panels are missing.)
        
        While the logic inside the gtk3 a11y bridge could be
        extended to cover that case also (by making use of
        implementation details in OAccessibleWrapper, e.g.
        getting its OAccessibleWrapper::m_xInnerAccessible),
        choose another solution that doesn't depend on making
        use of more implementation details and ports away
        from OAccessible(Context)Wrapper for the
        toolbar item windows completely:
        
        Introduce Window::SetAccessibleParent that allows
        to explicitly set an accessible parent for a vcl::Window.
        If this is done, Window::GetAccessibleParent, used by
        VCLXAccessibleComponent::getAccessibleParent returns
        this accessible instead of using the accessible for
        the vcl::Window returned by vcl::Window::GetAccessibleParentWindow.
        
        This ensures that the item window returns the
        toolbar item as its parent in
        VCLXAccessibleComponent::getAccessibleParent
        and the base class implementation in
        OCommonAccessibleComponent::getAccessibleIndexInParent
        ensures that the correct child index is also returned.
        
        Drop the now unused classes OToolBoxWindowItem and
        OToolBoxWindowItemContext.
        
        With this commit in place, the native GTK widgets
        inside VCL toolbars now show up in Accerciser's
        treeview of the LO a11y tree when using the gtk3
        VCL plugin as expected.
        
        Change-Id: I3b2182ca953056a939670e73687f4568620a4087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182426
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [827da8833cccda2b51f99eb0257be8ee68232899]

        tdf#163989 vcl a11y: Don't rely on Window a11y parent being Window
        
        In VCLXAccessibleComponent::implGetBounds, use
        Window::GetAccessibleParent introduced in
        
            commit 5ef30632ede4258f0c45194259567849cc172dab
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:05:16 2025 +0100
        
                tdf#163989 a11y: Introduce Window::GetAccessibleParent
        
        to get the accessible parent of the vcl::Window instead of
        using vcl::Window::GetAccessibleParentWindow directly.
        The latter would give an incorrect result if the
        accessible parent is not a vcl::Window itself.
        
        This prepares for upcoming commit
        
            Change-Id: I3b2182ca953056a939670e73687f4568620a4087
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 3 17:42:03 2025 +0100
        
                tdf#163989 vcl a11y: Rework toolbar item window a11y
        
        Change-Id: Iffa85bd9b6733eeed5357dd4937aac00966724c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182978
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [02a4655d8a8f846eaae1527c9c350f40db8570f8]

        vcl a11y: Flatten VCLXAccessibleComponent::implGetBounds
        
        Change-Id: I17936af21d34d56fe02d20a4ebe065a79786f92d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182977
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [b7c3beb429dfca11786655bbba58c0faab3b6e87]

        sc a11y: Leave some methods purely virtual in base class
        
        Instead of having dummy implementations that `OSL_FAIL`
        in the ScAccessibleContextBase base class, leave them
        purely virtual there; they're overriden in subclasses.
        
        Change-Id: I038c4ffd09f1fcc5e31b2e01eec01fd3e4bf09dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182981
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [714927c249e69b35a38ae1e563e441a62ae539a7]

        svtools a11y: Use existing Window::GetAccessibleParent
        
        Change-Id: I5eb010b76f5756b3c7164e4cc25f505dea14c510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182980
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [cee4f55e66efcf54179457316b244229961a067b]

        toolkit a11y: Use existing Window::GetAccessibleParent
        
        Change-Id: I8a4ef1676707c519f6b90707e3d36b2f69121ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182979
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [6901639601f0ae1b0d48afa083ee3503ef5c9398]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dd533c4b5f93f89018aa234fded8e69f722f0089
          - related tdf#152122 there is no Medium tab for business cards anymore
            
            Change-Id: If07348c2e889fc564b3a4119622ce4550007f85c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182970
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [8e5f5938ed7316d1dbc6a1ad365ffd8e938c6e06]

        a11y tests: Don't assume that child on top has higher child index
        
        An accessible can have multiple children at the same point. As the
        XAccessibleComponent::getAccessibleAtPoint doc says:
        
                @return
                    If there is one child which is rendered so that its bounding box
                    contains the test point then a reference to that object is
                    returned.  If there is more than one child which satisfies that
                    condition then a reference to that one is returned that is
                    painted on top of the others.  If there is no child which is
                    rendered at the test point an empty reference is returned.
        
        So far, XAccessibleComponentTester::testAccessibleAtPoint was making
        the assumption that if multiple children are at the same point, the
        one on top has the higher child index. Otherwise, the test would fail.
        
        The reason for that assumption is unclear. Replace that by checking
        whether the accessible returned by XAccessibleComponent::getAccessibleAtPoint
        is a direct child (by checking its parent) and actually contains the
        point instead.
        
        Without this, the test was seen failing in a WIP branch that converts
        the AccessibleDropDownListBox JUnit test to a cppunit test.
        Related failure output:
        
            Found 2 children
            * Found child: (0x562c20b3b7b8) role=TEXT name="" description=""
              states: ENABLED | SENSITIVE
              component: 0x562c20b3b770
              bounds: X: 0, Y: 0, Width: 100, Height: 21
              bounds: 100x21+0+0
            finding the point which lies on the component
            Child found at point +0+0
            * Found child: (0x562c20b30028) role=LIST name="" description=""
              states: ENABLED | FOCUSABLE | MANAGES_DESCENDANTS | SENSITIVE
              component: 0x562c20b30010
              bounds: X: 0, Y: 20, Width: 100, Height: 88
              bounds: 100x88+0+20
            finding the point which lies on the component
            Child found at point +0+20
            The child found ((0x562c20b3b7b8) role=TEXT name="" description="") is not the expected one ((0x562c20b30028) role=LIST name="" description="")
            /home/michi/development/git/libreoffice/test/source/a11y/XAccessibleComponentTester.cxx:204:AccessibleDropDownListBox::TestBody
            equality assertion failed
            - Expected: (0x562c20b30028) role=LIST name="" description=""
            - Actual  : (0x562c20b3b7b8) role=TEXT name="" description=""
            - The child found is NOT the expected one
        
        Change-Id: I8bc01c333ff0b3b9e90948bfd21b5abb86989687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182968
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [f69fa9e37232d0d41e5f224872d0e86391f19f2f]

        a11y tests: Move helpers from toolkit to test
        
        Move the XAccessibleComponentTester and XAccessibleContextTester
        classes from toolkit to test, so they can be reused for a11y tests
        in other modules.
        
        Change-Id: I9a4bb3f96d92b05d58a5e8afe7f86b5eb2fd0c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182967
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-15  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d1e90f2e26fb56c0fc1b290c8910aad9d9d8bcdb]

        related tdf#155050: list of sources is still called "bibliography"
        
        Change-Id: I7a800043d240685b4a249f8c78ceb9e1affef420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182841
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2eb8abda788e4f8c1b83281463673848c08ed6e0]

        tdf#135891 - Adjust the x position to ensure the correct starting point
        
        Adjust the x position to correctly align the cell background color to
        the drawn grid.
        
        Change-Id: Ic881a20d970befacfdd8a5076d0547256093a04e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182934
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2025-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [b5da114b67b29c91d16f2cb618cf30e7aa1b068d]

        Move code applying functor to selection from ScColumnData to ScTable
        
        Helps in a following optimization work.
        
        Change-Id: I303432fe783ec2c7eb29196a5f6704cde24c8c1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182930
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8c2605aea05c6c5b9883400e1c1b7944f4edbc47]

        use clang with --target switch on windows (pdfium/skia)
        
        fixes the native compilation of arm64 of pdfium after
        6007fbef5c2e4a0b80a4c0031ff36117aa41e63f (update to pdfium 7012
        that switched to using clang) and allows to enable skia
        
        Change-Id: I1cee8c7b84c1988f7a5800da913c299d14444e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182889
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [922e13cd65a5c2c88d822884483f3be57a517cba]

        lokit: don't double-buffer combo/list box dropdowns
        
        we don't need them and they take up a noticeable amount
        of dead memory
        
        .e.g. before: 57140k, after 56732k for a blank writer
        document.
        
        Change-Id: I50b378989c01e5e2a94e06c8e78a08dfb3829ef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182928
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-14  Simon Chenery  <simon_chenery@yahoo.com>  [12bf8a356f6663d98071da40a034693dc80ab898]

        Simplify lookup maps in PPPOptimizerTokenEnum
        
        Used a range-based for loop which does not need the number of array
        elements in pppoptimizertoken.cxx. Also Used OUString type in all
        functions and data structures to avoid unnecessary string conversions.
        
        Change-Id: I571135ce28e70b3ac745728f2454ba9babe43ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182066
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c7156da00e05a6ba2c589ca3d34d99c944c53ad]

        cool#1125 Reduce cost of spell checking in writer
        
        Loading a new CharClass for each NextWord() call can add up.
        
        Change-Id: Ie15f2adcd4c603074320b49d5c0276f558aab3e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182919
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7aff1587cde760f911f88cd1b82808700ea9b473]

        slideshow: simplify rendering, render text fields each in own layer
        
        This change significantly simplifies the rendering of layers by
        introducing an analysis pass (when we render the background) that
        creates rendering pass objects, which contain which objects and
        paragraphs need to be rendered in each pass. Previously we tried
        to figure this out durign the rendering, which meant we had to
        track a lot of various states. This all is not longer needed. This
        chaneg also means that the new RenderPassObjectRedirector is fairly
        simple.
        
        In addition this changes the test and implementation to render
        each text field in its own layer as it is expected by the online
        implementation (to enable master pages caching), but it still
        doesn't first render the placeholders for text fields as MasterPage
        layer and the TextField layer as a separate bitmap layer. This
        will be done next.
        
        Change-Id: I5377f4c5e5ebff67da70b248c831837cb9f2e559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182923
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-14  Jaume Pujantell  <jaume.pujantell@collabora.com>  [05f2cb64f690093172b5d0465936a78b46b3380e]

        tdf#165059 sw use delText inside all del tags
        
        Continuation of commit 624de66a2aeee92c0d2cadc8de3740167ec09062 "sw fix
        not valid moveFrom/moveTo tag". Make sure to us w:delText instead of w:t
        inside the w:del tags now used because of that change.
        
        Change-Id: Ic5bac1865e5c12a71bd15306249c2624eb1149f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182922
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [294bbbea5d0d51861aff8c319d4b3932428fc0ff]

        flatten some code in svx
        
        Change-Id: I63a15c6274accf75e66a8981ad4c011a505e1532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182917
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8597681fe6ebf65cb1555e56f14ff748b864be4a]

        avoid cost of throwing and ignoring exceptions..
        
        .. in AccessibleTextHelper_Impl::UpdateSelection
        
        Which gets expensive when we do it for a whole spreadsheet
        
        Change-Id: Iaea424903f4abc65d8b7b2342a50feae1aa38db1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182916
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1a922958d7707521414ab6ddfa6a0ffeb69622d1]

        Fix typo
        
        Change-Id: I87849a595bfaef20cbb06e683b012f35fe628119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182912
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-14  Miklos Vajna  <vmiklos@collabora.com>  [f0d38305d7eec27a5fa6846a5e02529b982a2f49]

        cool#11347 sw lok: avoid view jump on showing formatting marks
        
        Open a document with a few pages, set zoom level to 50%, press page down
        a number of times, scrool to the top, show formatting marks: view jumps
        back from the top to the page where the cursor is, which used to not
        happen in the past.
        
        This went wrong in commit 9400c0cf10bc14963a994ec0c0caeeb22a7c2513
        (tdf#132274 follow-up fix to Writer zoom options, 2024-10-09), because
        of the unconditional call to SwView::SetZoom() in lcl_SetUIPrefs():
        	#0  desktop::CallbackFlushHandler::queue (this=0x417f3f80, type=5, aCallbackData=...) at desktop/source/lib/init.cxx:1795
        	#1  0x00007ff83caebe78 in desktop::CallbackFlushHandler::libreOfficeKitViewCallback (this=0x417f3f80, nType=5, pPayload="true")
        	    at desktop/source/lib/init.cxx:1704
        	#2  0x00007ff838d1cf7a in SfxViewShell::libreOfficeKitViewCallback (this=0x41fb88a0, nType=5, pPayload="true") at sfx2/source/view/viewsh.cxx:3352
        	#3  0x00007ff82125482b in SwCursorShell::ShowCursor (this=0x41fbfd60) at sw/source/core/crsr/crsrsh.cxx:2819
        	#4  0x00007ff8227fb198 in SwView::SetZoom (this=0x41fb88a0, eZoomType=SvxZoomType::PERCENT, nFactor=100, bViewOnly=true)
        	    at sw/source/uibase/uiview/viewmdi.cxx:77
        	#5  0x00007ff822431a46 in lcl_SetUIPrefs (rPref=..., pView=0x41fb88a0, pSh=0x41fbfd60) at sw/source/uibase/app/swmodul1.cxx:103
        	#6  0x00007ff822431fd7 in SwModule::ApplyUsrPref (this=0x4194ff40, rUsrPref=..., pActView=0x41fb88a0, nDest=SvViewOpt::DestText)
        	    at sw/source/uibase/app/swmodul1.cxx:197
        	#7  0x00007ff8227d37a1 in SwView::ExecViewOptions (this=0x41fb88a0, rReq=...) at sw/source/uibase/uiview/view0.cxx:766
        Investigating how "set zoom" works, notice that SwView::SetZoom_()
        stores both the zoom type and the zoom factor in SwMasterUsrPref. (User
        profile settings.)
        
        Fix the problem by checking what's the current zoom type/factor in
        lcl_SetUIPrefs(), and only call SetZoom() if needed, to avoid
        invalidating the (unchanged) cursor, which would lead to a view jump.
        
        online.git's
        cypress_test/integration_tests/desktop/writer/scrolling_spec.js 'Check
        if we jump the view on change of formatting mark' can be re-enabled
        after this.
        
        Change-Id: Id3777db91cbfa5b32f7e4488bb27b1fb8a081599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182913
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8e1c9cbd58c123cf37681ccff1c417e537a9272]

        fix deadlock in SystemDependentDataBuffer::flushAll (tdf#131595 related)
        
        seen while testing my other patches for this bug
        
        Change-Id: I1c14bdfe5ec60915885dd062a7bb81a284459da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182911
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [acf84f9e21999327b831580691430db8c8fe8a71]

        nss: remove obsolete target
        
        it has been removed in recent versions of nss.
        Do it in preparation for the upgrade.
        
        Change-Id: I2dbcdb065c59e3d79235fb8a17dc072f4826319b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182914
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [69bf9f849234f3adb678c254b8ec7dbb5824ed8b]

        tdf#135891 - Don't adjust x and y coordinates when working logic units
        
        Don't adjust x and y coordinates when working with logic units since the
        repaint process will redraw the background and grid again using pixels.
        Otherwise, this would lead to an offset between the grid (pixels) and
        the background of the cells (logic units).
        
        Change-Id: I224bb9e50b80f3a54ed1403e465eecd4cb317581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182890
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [303e5631f8119ef69c8ff515e7e47d4cf6ab74c6]

        use mutex before touching maBuffered2DDecomposition (tdf#131595 related)
        
        Otherwise we could be reading stale data.
        
        And change it to return a bool, the call-sites only care if we
        have/dont-have the data, and returning a value of a field that should only
        be accessed under a lock is dodgy.
        
        And move the the setRemainingTime call to get2DDecomposition(), because
        that where we really "use" the data ie. paint with it.
        
        Change-Id: I44b5d41fee68985213ecc7d11b4ce1bdcfd119b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182909
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab4cf371eda16668b875dbd99950034b09d0dc4c]

        use mutex before touching maBuffered2DDecomposition (tdf#131595 related)
        
        Otherwise we could be reading stale data.
        
        And change it to return a bool, the call-sites only care if we
        have/dont-have the data, and returning a value of a field that should only
        be accessed under a lock is dodgy.
        
        And move the the setRemainingTime call to get2DDecomposition(), because
        that where we really "use" the data ie. paint with it.
        
        Change-Id: Ie795465a1177a47f846cf9310d419079e52b8770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-14  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [08a83c88b2838e0aa4ed0c3b5e3ef2e21efe4b2e]

        tdf#71583 (related) Add ext. tooltip to floating menu
        
        and improve tooltip in the Page number wizard
        to make it easier to understand this feature
        
        Change-Id: Ic1de136deac74541f611fedc84765b7bb2597bf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182846
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [82c0b78f16dc4a5969b130c0d2519cf9d05e4794]

        expat: upgrade to 2.7.0
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_0/expat-2.7.0.tar.xz
        
        Change-Id: I714d00fe5e1b3073ec3034065057ae9795060eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182894
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-14  Taichi Haradaguchi  <20001722@protonmail.com>  [5d09908418767a541977acae348654af8239e9db]

        Update ICU to 77.1
        
        Downloaded from https://github.com/unicode-org/icu/releases/tag/release-77-1
        
        Change-Id: I05060c281b70ad7e9733268796b695d1cf4ea30a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175841
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [16f76c36a64b93961af2d11e20b2f509759ea06c]

        fontconfig: upgrade to 2.16.1
        
        Downloaded from https://gitlab.freedesktop.org/api/v4/projects/890/packages/generic/fontconfig/2.16.1/fontconfig-2.16.1.tar.xz
        
        Change-Id: I72d7cf3c664693076e2b980a28aded752842df45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182884
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-14  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [c3e1743287c5c8b968eb9f45975b44f6adb65ea4]

        tdf#48140 Replace XDatabaseRange with ScDatabaseRangeObj
        
        Co-authored-by: Oromidayo Owolabi <owolabioromidayo16@gmail.com>
        
        Change-Id: Idcea0e26edad071cb7af05c89022f477564136ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cb4750f651ef7cd03f0dfeb54103870c3ab7dc71]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a006edb8f7907be14cedaba4da9b14902c86a47
          - tdf#137419 More content in Data Provider Help page
            
            + Add details on formatting data
            
            Change-Id: I6b231857847e7e53bd212d481005dc90a6a94ede
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182888
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-03-13  Adam Seskunas  <adamseskunas@gmail.com>  [d1ec7e90772421331bef31eb934180c7f992e42f]

        Move SingleSelectQueryComposer.java tests to C++
        
        Move the tests to SingleSelectQueryComposer_test.cxx
        Remove the old SingleSelectQueryComposer JUnit tests/file
        Add makefile for SingleSelectQueryComposer_test
        Remove the java test from JunitTest_dbaccess_complex.mk
        Add the CppUnit test to the Module_dbaccess.mk file to be
          run only when Java is enabled on the test machine
        
        Change-Id: I832c80e294be6cd4dced4d358bcee383ea04b0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182759
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b2b4934ce87096322e65b83770b165804cd883b4]

        Fix typo
        
        Change-Id: I538d1e0fffebb2aac7489d1529287d0bfbe76e7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182874
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-13  Oliver Specht  <oliver.specht@cib.de>  [816a4ede2cfefbe58e39fcc683cfb328ce8ecd08]

        tdf#165315 Store field:fieldmark in a text::span
        
        Store automatic style around fieldmark to keep character attributes
        
        Change-Id: I902c90d9bfbbc964c3f0567042ea7f7bc993471f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182582
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-13  Karthik  <me@karthikreddy.org>  [bbd3f8063f496cfaf7a97cd8e1e2c6e118e611d9]

        tdf#146947 Add show/reveal toggle to "Enter Password" dialog
        
        Implemented password visibility toggle button in "Enter Password" dialog. When you open an encrypted file you will see this dialog.
        
        Change-Id: Id736a1224b5254d5f3c1ae3a96353ed65023d2c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182694
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-13  Miklos Vajna  <vmiklos@collabora.com>  [2d73d378751ea4ee8abe5504c8a371d071803d65]

        tdf#165701 sw: fix unexpected list level change on inserting new bullet
        
        Go to the end of the 3rd paragraph of the bugdoc, press Enter, list
        level of both the old and new paragraphs change from 5 to 4,
        unexpectedly.
        
        It seems what happens is that the paragraph in question has a style
        which has its outline level set to 4. So once the node is split, the
        newly inserted node will host the old text (so need to set the style on
        it to the old style, which sets list level to the outline level from the
        style as a side effect) and the old node will host what looks like a new
        bullet point on the UI, so there we need to set the paragraph style to
        the follow style. This second set-style also drops the list level direct
        formatting and takes the outline level from the style.
        
        Fix the problem by keeping the old scenario (paragraph style with a
        different follow style) unchanged, since a different list level on an
        actual paragraph style change can be expected -- but avoid setting a
        list level when this is a simple node split with just the same style on
        both nodes. That's not seen as an explicit "set style" by the user, so
        changing the list level there is confusing.
        
        In fact the list level is fine after copying the text node's item set
        from the old node to the new node, just make sure that
        SwTextNode::ChgTextCollUpdateNum() doesn't set a new list level in the
        "effectively no style change" case. Make sure to not set a new list
        level at both places (SwTextNode::MakeNewTextNode() does this for the
        previous node, SwTextNode::ChgFormatColl() does this for the next node).
        
        Change-Id: Ifdf9048f01fef7bb8e99098ebeb5d1ec339fdaa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182869
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-13  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [f007d20a0a4224cab3e6ebb4a3083c0a579efa65]

        tdf#165621 fix Calc repaint on TextEdit activation
        
        Found a simple way to do that (after some experimenting),
        needed to trigger the Overlay update, and that can just be
        done with a Reschedule. Other places that used
        flushOverlayManager() checked, but work on their own, so
        we do not need to bring that OverlayManager flush back.
        
        Unfortunately this triggers CppunitTest_desktop_lib
        "DesktopLOKTest::testRedlineCalc", probably due to not
        only the timer triggering but 'other' stuff that better
        runs later (...?). Not doing it - as long as we need
        to do it - is safer, but forces to keep that flush just
        for this single usage.
        
        Change-Id: Iacf18d688597129baba6e893252487d73a1fdfff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182834
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-03-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [0dafd80f219d4e701a8759beb96d175c17e2c5c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ca3dcbc01b5b6b72cc3d9869a76b2c7170cf2aa5
          - tdf#71583 Describe the new checkbox in Page Number Wizard dialog
            
            plus some bookmarks to related boxes so that F1 works better
            
            Change-Id: Ifdd8332bff754078a40b2d04b06e3e3a92cf0850
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182845
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-03-13  Jean-Pierre Ledure  <jp@ledure.be>  [0658c51d633be105aa7e36d4bb2a7faec4a1584c]

        ScriptForge (Dialog) new ImportControl() method
        
        The
          ImportControl()
        method copies a control stored in a dialog
        to the actual dialog.
        Like in:
          dlg1 = CreateScriptService("Dialog", ...)
          dlg2 = CreateScriptService("NewDialog", ...)
          dlg2.ImportControl(dlg1, "thiscontrol", ...)
        
        The additional arguments contribute to optionally:
        - renaming the new control
        - storing the new control in a specific page
        - repositioning the control (offsetx and offsety args)
        - including the OnEventxxx properties
        
        One goal is to help defining individual smaller
        dialogs in the IDE and inserting them in a larger
        one, keeping them in separate pages.
        
        The function works for Basic and Python user scripts.
        The user documentation will have to be updated.
        
        Change-Id: I6155f58d2e8706b73fc5f72c070bb8230cdd17ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182865
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-13  Simon Chenery  <simon_chenery@yahoo.com>  [1d78c4993c33bb505939243e3d5873f94e12219c]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro
        
        Replaced loops with std::find_if calls to avoid use of the
        SAL_N_ELEMENTS macro in smmod.cxx.
        
        Change-Id: I561d8a4ae66dc5ad342009ee8af3c9db87688d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182194
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-13  Karthik  <me@karthikreddy.org>  [1791a290a82591d5b0609502e86f07ed69acee5c]

        tdf#146947 Add show/reveal toggle to "Set Password" dialog
        
        Implement password visibility toggle button in "Set Password" Dialog when saving files with password.
        File -> Save-As -> Select "Save with password"
        
        Change-Id: I33de726b8f34c18443cf66b82e725c799d673017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182693
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [48dde8fc151e8e582fab01cfadc8b20cf063c6c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9218bcbfa5f67ffe3243a1e5f942eb290d213610
          - tdf#71583 Add a tip to Insert Manual Break page
            
            about the new page count in range field, related to the
            customized page numbering feature
            
            Change-Id: Ie49561075a872d86c4ceea063f7eaee0d7f34b1f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182844
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-03-13  Oliver Specht  <oliver.specht@cib.de>  [d4bde4c979df6589fca2b405111e1b17fcff9ca7]

        tdf#90293 switch on rotation of shapes
        
        Adds Writer images not handled by c628a26cd3f763b39a2e2441fc766dabf04ed492
        
        Change-Id: Icaf046df0eef9cf3722a00bb1d7761c849f03734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182592
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-13  Bayram Çiçek  <bayram.cicek@collabora.com>  [765bf4bff2b8d4ed9569e735dc663ac55ae7a424]

        tdf#123225 - calculate count attribute correctly
        
        in xl/pivotTables/pivotTable*.xml we have e.g. <location ref="A3:B6" firstHeaderRow="1" firstDataRow="1" firstDataCol="1" rowPageCount="1" colPageCount="1"/>
        
        - the 'ref' attribute indicates the cell range of a pivot table.
        - 'firstDataRow' specifies the first row of the PivotTable data,
        relative to the top left cell in the ref value.
        - 'firstDataCol' specifies the first column of the PivotTable data,
        relative to the top left cell in the ref value.
        
        if we get the number of rows and cols in the pivot table (using
        <location ref="..."), and substract 'firstDataRow' & 'firstDataCol'
        from it, we get the correct count attr. value of <row/colItems> during
        export from ODS -> XLSX.
        
        - added testTdf123225PivotTableEmptyRowColItems Cppunit test to make
        sure that export works with empty row/col items.
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Ia85a89e429d95492f0f753af3fbf46771d1a2a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182529
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [c36483e738da19986f091c59be757e55558c7127]

        libxslt: upgrade to 1.1.43
        
        Downloaded from https://download.gnome.org/sources/libxslt/1.1/libxslt-1.1.43.tar.xz
        
        Change-Id: Iadab2934e3b1e8178a4912ef9a56c4a3c158c7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182855
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [04ef40cb60fd96960004b15b38a56e1141a8de7e]

        (related: tdf#164945) writerfilter: RTF import: try to fix more cases
        
        Presumably bufferProperties() calls for stuff that is inside paragraphs
        (fields, bookmarks, annotations, tracked changes) should use
        LN_Value_ST_StyleType_character to avoid overriding paragraph properties.
        
        Change-Id: Ida4a6e930af7515161289de505f546e496e39799
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182836
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [1a7346e7f14b54cf5d9b74798d41cff2a3a05872]

        tdf#164945 writerfilter: RTF import: fix erroneous default paragraph...
        
        ... properties in empty table cell.
        
        The problem is that for an empty table cell, there is a sequence of
        buffer entries SETSTYLE, PROPS, SETSTYLE, PROPS, and the 2nd PROPS
        sets a default value of the LN_CT_PrBase_pBdr SPRM, and that overwrites
        the \brdrs value that was contained in the 1st PROPS.
        
        All these buffer entries originate in \cell handler, which must use
        ST_StyleType_character when buffering the character properties, then no
        paragraph properties will be generated in getProperties() for the 2nd
        PROPS.
        
        (regression from commit 6f42a2c8631bace1caa4fac0b3ea554942f1fca3)
        
        Change-Id: Iefb939d8d8dace6dc58cb665b4bd1575f09701c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182835
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-03-13  Marco Cecchetti  <marco.cecchetti@collabora.com>  [62f541674c209c34b59529c1520456857ae62f9a]

        lok: slideshow: provide support for interactive animations sequence
        
        Change-Id: Ic6ff5f3fe5f7a330e511a33db70f75b77e9b58fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182853
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-13  Miklos Vajna  <vmiklos@collabora.com>  [8edf379304b1a36c7f29dc2108ace489cb7ee151]

        sd: move ViewCallback to Library_sdqahelper
        
        Allows not including .cxx files in Impress tests.
        
        Change-Id: I86cbe9d68800b28ceb4e98bccaccfba5ea164f78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182851
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cdb6fea315760415dd88238f0224c7fa1915129]

        update to skia m135
        
        Change-Id: I61bb92770b1204c0f6abaae355c5905028c5cc46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182842
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-13  Kohei Yoshida  <kohei@libreoffice.org>  [04a25a4759d452381b4542072b80abac25394bbf]

        Add a test case for importing autofilter from Excel 2003 XML
        
        Change-Id: If5479128219ebc846ab2255dbaaff51a2edf5ac9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182848
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2025-03-13  Jonathan Clark  <jonathan@libreoffice.org>  [2a7660251c9b584e9b58340d08ade3da96cb2f2c]

        tdf#80596 DOC import: implement Ch-based LR indentation
        
        Adds support for the sprmPDxcLeft, sprmPDxcLeft1, and sprmPDxcRight
        attributes, which are used for character-based indentation in CJK
        documents.
        
        Change-Id: I374f3a85b7163799ca78a4c5bb856da3adb0a945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182850
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [477138a0570589e8dcecdbfe104a055f432638ce]

        use more concrete UNO class in sw
        
        Change-Id: If5839135eba9e82516c29441d28938e73570d7f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182837
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fef5a0d2bcc1bea859de7cc62a42cf99b7f98c8]

        update to skia m134
        
        Change-Id: I12012d287f12ba3b4457bc3d1d57ec81cf75df88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-12  Moritz Duge  <moritz.duge@allotropia.de>  [3918e3e22ebf76a9f9ee2ddce41083c3db2aa6de]

        WASM clarified --with-wasm-module
        
        Option is for WASM only, so shouldn't be named --with-main-module.
        
        Also the option's default value changed since it was introduced, so the
        documentation became outdated. See commits:
        
        fe678ffc6f6f0e851c3b7b7b0c8a1b8219b819a2 Emscripten: No need to pass --with-main-module into build configure
        437b4d802ccec2eb1395a4e4137a4a0af039de5a Fix default value of Emscripten --with-main-module
        8aef8c3a1451b2fce37a21870a004855822ee335 Make it possible to run either Writer or Calc in the same Emscripten thing
        97ee126d69859d01abfbdb55450d27afb71bf9b1 WASM add Calc as optional build result, make it build & run
        
        Change-Id: I29aeeb9a840ec07e46cbf153c535b3fca9d88cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182798
        Tested-by: Jenkins
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>

2025-03-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cde8bf6bcf3b361bd107276efe14b2a221826399]

        slideshow: fix para. rendering when using SdrBlockTextPrimitive2D
        
        If using an empty ViewInformation, it is possible that the prim.
        decomposition is redone, when a different ViewInformation is used.
        This removes all visibility flags for the paragraphs, so the whole
        text is rendered. This fixes the issue by using the same instance
        of the ViewInformation that is also used later for rendering the
        primitives to the VirtualDevice, so the buffered decomposition is
        used.
        
        Also a test is added - it checks the hash of the buffer, which
        should be different for all 3 layers. For this the tostring has
        to be moved to the common hash.hxx, so we can reuse it in out
        tests.
        
        Includes:
        
        	Author:     Marco Cecchetti <marco.cecchetti@collabora.com>
        	AuthorDate: Wed Mar 5 23:15:33 2025 +0100
        
        	    slideshow: regression: layer with paragraph has not the expected content
        
        	    Change-Id: I850c6922cdd358eee35074fbff04f238994b2c76
        
        Otherwise 'make -C sd -sr CppunitTest_sd_tiledrendering
        CPPUNIT_TEST_NAME=testSlideshowLayeredRendering_Animation_DifferentKindOfTextBox'
        would fail.
        
        Change-Id: I4c951215a52e302d3b7b60a30c1b995002e53a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182833
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-12  Moritz Duge  <moritz.duge@allotropia.de>  [3cf71eec36518a5cc85073e46a420067b855c20e]

        WASM enable Impress for WASM builds
        
        Change-Id: Ib0e8f073f9fb74bd0fd3b00e8f31f620f8aa9f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182750
        Tested-by: Jenkins
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>

2025-03-12  Moritz Duge  <moritz.duge@allotropia.de>  [0cd1969beeda22287730b109a1e6359334cfaa1d]

        WASM clean up AC_DEFINE section
        
        Removed variables from config_wasm_strip.h.in which weren't used in C++
        code or headers. And also removed the respective AC_DEFINE lines.
        Always disabling Writer or Calc for LOWA wouldn't have made sense anyway.
        
        Change-Id: I48767b8c7cd7737b851b349e184d17f8b2acafba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182749
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
        Tested-by: Jenkins

2025-03-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4f03d1c23840b49d9af5080eaf9f59688685664f]

        css.lang.XSingleServiceFactory must not be @deprecated
        
        ...which caused cppumaker to emit the corresponding C++ class as
        SAL_DEPRECATED_INTERNAL (since 44ea5d14140cccdc77a5fd8e2473804e879880df "Adding
        SAL_DEPRECATED_INTERNAL to an implementation function is pointless"), which
        caused compilers to emit warnings upon its legitimate uses in external
        !LIBO_INTERNAL_ONLY code
        
        Change-Id: I8043506cd11658164e68f8743702acbc1a8213f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-12  Miklos Vajna  <vmiklos@collabora.com>  [ccd010346cb2afc6f8c9d9880c03e82ba5fceb9a]

        cool#11320 xmloff lok: improve error reporting
        
        When processing a report on failed ODF save, it can be tricky to find
        reproduction steps. A typical source of errors is some uncaught
        exception. Currently we just report which stream failed to save:
        
        0x70c23(Error Area:Sw Class:Write Code:35) arg1=SfxBaseModel::storeSelf: 0x70c23(Error Area:Sw Class:Write Code:35) arg1=styles.xml at sfx2/source/doc/sfxbasemodel.cxx:1735
        
        Improve this to also report what would appear on stderr in a dbgutil
        build:
        
        com.sun.star.lang.IllegalArgumentException: "SwXMLExport::exportTheme() failed at sw/source/filter/xml/xmlfmte.cxx:189"
        
        In case e.g. the theme export throws an exception for testing purposes.
        
        Change-Id: I85ec1ac4f932851401aa3b25a753219eb20638a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182831
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-12  Miklos Vajna  <vmiklos@collabora.com>  [b320ade8f9d5205d552fb6fa7de9072eccb867d8]

        sd: move SdTiledRenderingTest to a new Library_sdqahelper
        
        Towards not including .cxx files in Impress tests.
        
        Change-Id: I8b50bd79ff36856f878529205d98d4b3299855de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182805
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-12  Hossein  <hossein@libreoffice.org>  [9299d425f3ed941d983f68d6dc1e979b4d4d1060]

        Simplify string definition
        
        With Unicode literals, the code is now much simpler. This patch also
        corrects the text, which means 1 2 3 in Arabic.
        
        Change-Id: I59a6a3afcddde416f73e74287319750cf4111048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182826
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-12  Muhammad Danish  <mdanishkhdev@gmail.com>  [b4fd0468f62cfe7c4a2b2ed1208e6e3b1e16c06b]

        Make WinGet config files consistent with new recommendations
        
        The new file naming conventions for WinGet configurations files are:
        
        - Use the `.winget` extension instead of `.dsc.yaml`. This allows user to run the configuration directly
          from the file explorer.
        - The configurations should be placed in a `.config` directory in the root of the repository.
        
        Reference: https://learn.microsoft.com/en-us/windows/package-manager/configuration/create#file-naming-convention
        
        This commit also removes `allowPrerelease: true` directive from the `Microsoft.WinGet.DSC` resource.
        The Microsoft.WinGet.DSC module is GA (stable) so the directive is no longer needed.
        See https://www.powershellgallery.com/packages/Microsoft.WinGet.DSC/
        
        For reference, maintainers may see these recommendations enacted in the following Microsoft repositories:
        
        - WinGet CLI: https://github.com/microsoft/winget-cli/tree/master/.config
        - WinGet Packages: https://github.com/microsoft/winget-pkgs/tree/master/.config
        - WinGet Create: https://github.com/microsoft/winget-create/tree/main/.config
        - PowerToys: https://github.com/microsoft/PowerToys/tree/main/.config
        
        Change-Id: Ib88598f5fb93b1bb0ed1b608e0d690c196cf9b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182675
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-03-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3d3d093e99943de1f3383d6eed16e51600becd9c]

        drop warning re Apple patch - used by CI for quite a while now
        
        so if there inconsistencies found between GNU patch and Apple's patch,
        those are detected early and won't make it to master in the first
        place.
        macOS switched the system patch in macOS ventura (macOS 13), so older
        systems have gnu patch, and ce31e09a6d40295cec4be9da8f4cec886d6c92c1
        enabled to use the "new and unknown" apple patch that was pickier re
        the context lines, but no other compatibility issues were observed.
        So fine to say that it works fine/is no longer "experimental" but
        rather the default on macOS
        
        Change-Id: I993d4474beeb3840039363dc8fc2a401b188ca98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182820
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [29f38173e824ab0434d0a6b2bfb7d6a0d03cc4a0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 8563502e6692ea225c95f9bced619da091b13dcf
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ia8fd7a24f5bbc1db48141553e1c8fb79af128ecb
            
2025-03-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d532407e12c41c508329b7926164926e2c59fde1]

        tdf#165636 - FILESAVE PPTX: fix extra table border lines shown
        
        Export correctly the transparency value of table borders.
        
        Change-Id: I22ee5e29d1846295645ce5934149cf864a178bb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182741
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fb0b4878d312d150759ea517d279041b40cf7888]

        Fix typo
        
        Change-Id: I91b3b33e93b742284a77f80acad251d977ae42e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182730
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [407f6fc7c060c1cd3a754405f71d2fba314803da]

        Fix typo
        
        Change-Id: I8ae3107c5ab0da12dd5182a5c87db6831f685b7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182783
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b455a7894c9a6d298c9f736455c45f9c198b267]

        Fix typo
        
        Change-Id: I8ea21b5f00d9ae21e4c8f89472c04bb2e3b0d640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182804
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-12  Szymon Kłos  <szymon.klos@collabora.com>  [29e66e84270285886d8ec3062e2d35e810f24704]

        lok: style panel shortcut icon command fix
        
        This reverts commit 90a63a2325e45b435762570ac9aecd50fcb5b676.
        lok: use .uno:SidebarDeck.StyleListDeck as shortcut
        
        it caused regresison in Writer where we should still open the
        Style Edit dialog. Only Calc should open style list.
        
        Change-Id: Ia8844330e8f91ef56864ae78b18d5ce57a146c58
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 0f57885a3cf63af68bf07b14c5296e14ef0ad4c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182807
        Tested-by: Jenkins

2025-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [41f0f6b483b8c22b6f380f89c21373ea25bdd262]

        language-subtag-registry: upgrade to 2025-03-10
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-03-10.tar.bz2 data/language-subtag-registry
        
        Change-Id: Ic83bb4f02c43f657a6fcf7e74913c9c8e1d5af1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182809
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [817cb41005db87c9bdd63663e5d1d1357d6e5cbc]

        tdf#158068: Replace with static constexpr O(U)String
        
        Change-Id: Ie2f1e821451a692a79c40dd4d40dc89a9fa550c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176803
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [02a5df653f12696b9738f6cd5f267d3592f85209]

        use more concrete UNO in connectivity
        
        Change-Id: I3842706a0b28c3bf78c8f359ca2d2226ed5f1b07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ce35e70da08cccb20302f1acc36521dc1b1bec2]

        update to skia m133
        
        Change-Id: Id12146bfd28003acc146fc45fdea4d9e4323539e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-12  Jonathan Clark  <jonathan@libreoffice.org>  [720983ad53b46f88988b91e8e3ac08a8110bc7c3]

        tdf#70102 API cleanup for RTL icon variant code support
        
        Removed an unnecessary DIR_LR_TB enum value.
        Added a missing @since annotation.
        
        Change-Id: If27357cb05498abca5a69adcd6e63c25b412f6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182802
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-03-12  Simon Chenery  <simon_chenery@yahoo.com>  [7b9e27da2033192c628b23e4e1686209e951dadb]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro
        
        Refactor getMathMLEntity() to use std::string_view
        and OUString for string handling, so that there is less
        string conversion when calling this function.
        
        Use std::find_if to find formula in array instead of a loop.
        
        Change-Id: I0ed98d33e62f6bc730ac750f4fd545d2f07145fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182065
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-12  Nam Bui  <ndbui03@gmail.com>  [0176752f6d9431d3b0b1e3c3d81acb2a8dca8fe0]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS()
        
        Use std::size() in vcl/workben/vcldemo.cxx
        
        Change-Id: I7a320b79ee218a32af3a1a5a52bda08fd972ad46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182756
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-12  Simon Chenery  <simon_chenery@yahoo.com>  [c0e17ec1ae05e52b6881ce3e05a875b5b8c28fe0]

        tdf#145614 Convert #define WIDTH_CHARS to constexpr
        
        Change-Id: I17f3c039c78953dfc842e97351e8af3537539835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182663
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-11  Kukee Thoo  <kukeethoo@proton.me>  [bff3d755c8c11721054f4ff40a3d5f723b0c6b96]

        tdf#163691 Use std::copy() instead of memcpy()
        
        Change-Id: I55df00e2625cf42a7e2662850e8cc272ceb70152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182787
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [1152ed5c9731b71c24b0d045b925ec99f90f4402]

        CppunitTest_sw_odfexport2: split in two
        
        At least on my computer it takes
        real	7m16,468s
        user	9m17,205s
        sys	0m11,565s
        
        Change-Id: Ia199aa53e7b3e9fe52c6d255002c8c8d36b125ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182784
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-11  Patrick Luby  <guibmacdev@gmail.com>  [93574e7a581bc9d0a06e83f2bf1e1caab093ae69]

        Partial: tdf#156855 update native and LibreOffice dark mode states
        
        Updating the dark mode state of everything all at once does not
        solve all failures to update colors when the light/dark mode
        changes, but it eliminates enough failures that the UI is now
        generally readble without restarting LibreOffice.
        
        Also, update the application's color mode when the macOS light/dark
        mode changes while LibreOffice is running.
        
        Change-Id: Iffe3ca3789373135f06f7fbe22429cc59438d4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182484
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Sahil <sahil.gautam.extern@allotropia.de>

2025-03-11  Rashesh  <rashesh.padia@collabora.com>  [12969dd7922d167ef821c7aad611c2030fc70532]

        svdraw: append SdrCropViewHdl instead of prepending in crop mode
        
        Previously, enabling crop mode caused the crop handle (SdrCropViewHdl) to be added
        at the start of the handlers list. This change in order led to a shift in handler IDs,
        which Collabora Online relies on for identifying and managing handlers.
        
        This patch fixes the bug by appending the SdrCropViewHdl to the end of the list,
        ensuring that the IDs for the main crop handles remain consistent.
        
        Change-Id: If082d292e32e242648cf5d04e278880bd457efb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181705
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 4daf1b96c52e8b399908bfeb6871482a6699422c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181775
        Tested-by: Jenkins

2025-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [ddaea18557b1ec60d9e360f9eab539c8f551061f]

        CppunitTest_sw_odfexport: split in two
        
        at least in my computer it takes
        real	6m36,775s
        user	8m36,325s
        sys	0m11,136s
        
        Change-Id: I2c2167949f1cf1e9d46645cf26428677ab079133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182781
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-11  Miklos Vajna  <vmiklos@collabora.com>  [ce5527f0fefc74fe1c807fb2330098b6fe79a497]

        CppunitTest_sw_uiwriter5: extract CppunitTest_sw_uiwriter10 from this
        
        uiwriter5 is so large that trying to build it by now fails with:
        
        {standard input}: Assembler messages:
        {standard input}:327871: Warning: end of file not at end of a line; newline inserted
        {standard input}:328313: Error: no such instruction: `_zn11__gnu_debug16_error_formatter10_parameterc2in9__gnu_cxx17__normal_iteratoripkpn2sw4mark8markbaseenst9__cxx19986vectoris8_sais8_eeeeenst7__debug6'
        g++-12: fatal error: Killed signal terminated program cc1plus
        compilation terminated.
        make[1]: *** [/home/vmiklos/git/libreoffice/core/solenv/gbuild/LinkTarget.mk:339: /home/vmiklos/git/libreoffice/core/workdir/CxxObject/sw/qa/extras/uiwriter/uiwriter5.o] Error 1
        
        Change-Id: Iede9ef1e4302af7b1d84c35c88b371a57f28b2d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182777
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [44a17ea1ce5e2ad4fe6ea92dc394a47b8941c48b]

        CppunitTest_sw_rtfimport: split in two
        
        it already has 109 tests
        
        Change-Id: I0fe53be21ac15f49157087991f56a4ba40975c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182772
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-11  Juan C. Sanz  <jcsanz@libreoffice.org>  [b586705fff4e24c14a76789c3f7fadb1f55d3a53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77055d951cf90c65598a2f0db2c43a82e08fa4d4
          - Edit source/text/sdatabase/dabawiz02access.xhp
            
            Change-Id: I96194de7ec6efb2a3aafa1267f3267aaa54d54eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182757
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5284fbe7b4358426f4236157009dfb9e6c69a2f7]

        update to skia m132
        
        dropping patch that is already upstream
        
        Change-Id: I7f0dc4b964499eb1ea6db0b32846ed9328f22ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182768
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [17a6b3a8f8afdf213f04f30f7ba50865ef645fc4]

        sw: fix warning C6011: Dereferencing NULL pointer 'pDocSh'
        
        after
        commit ab91358566ccf31f7a9ac57f1c32a9c62840f5d5
        Author: Miklos Vajna <vmiklos@collabora.com>
        Date:   Mon Mar 10 10:18:10 2025 +0100
        
            cool#11226 sw per-view redline on: support this-view <-> all-views transition
        
        Catch by https://ci.libreoffice.org/job/lo_tb_master_win_analyze/
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/edit/edredln.cxx(44): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sw\source\core\edit\edredln.cxx(36) : warning C6011: Dereferencing NULL pointer 'pDocSh'. : Lines: 35, 36
        make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/solenv/gbuild/LinkTarget.mk:339: C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/workdir/CxxObject/sw/source/core/edit/edredln.o] Error 2
        
        Change-Id: I0f191ee2bf583ba0fda5c9868679996baf480ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182767
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-11  László Németh  <nemeth@numbertext.org>  [8c7c4ada3db07264a7849d36de6179205219350f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9453c4646b34c22dcf59bc3c9ac8614029dbcad0
          - tdf#165354 sw: document Text Flow->Move Line (HyphenationKeepLine)
            
            Document new Text Flow setting of version 25.8: Hyphenate Across
            by moving only the hyphenated word (disabled Move Line).
            
            Also modify help of Hyphenation Across options to the new
            default "move word" from "move line".
            
            Follow-up to commit 698b38a18f5f70fd8d50968bc50951aba7085175
            "tdf#165354 sw cui: implement HyphenationKeepLine – part 3".
            
            Change-Id: I484a16dfcfbfd03c8c04da2d3d25a6ffa377ba1e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182747
            Reviewed-by: László Németh <nemeth@numbertext.org>
            Tested-by: László Németh <nemeth@numbertext.org>
            Tested-by: Jenkins
            
2025-03-11  Rashesh  <rashesh.padia@collabora.com>  [98b86bff2c7350ad9a22eb0db7f7696672c6db51]

        tdf#165606 sd: fix master slide panel doesn't resized correctly
        
        Change-Id: Ifb26d80f431f0fe6c4e58e58621e170e5a33a718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182671
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit a5a15bf521510530d33aa4f21a37f168ddc1bb68)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182727
        Tested-by: Jenkins

2025-03-11  Rashesh  <rashesh.padia@collabora.com>  [9f2fc6fbf74cbc0643f380aa4b799e36997734aa]

        tdf#165610 sd: master slide panel is broken with "show large preview"
        
        Change-Id: If7d6350ca289ab165f11af71bd1f22dee7be86d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182668
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 756a4a85d0362264e82389d5924c2ded30f25885)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182765
        Tested-by: Jenkins

2025-03-11  Michael Stahl  <michael.stahl@allotropia.de>  [7a9a1e8ef5ad9dd3e9b7d286a8f85d2f18088d29]

        sw: layout: hide text frame before table like Word
        
        There are several empty paragraphs before a table, all have the
        paragraph end marker hidden, and the first one is preceded by a section
        break, which is represented as a break item on the first text node in
        Writer.
        
        Word hides the paragraphs, so that the following table starts at the top
        of the page.
        
        Writer merges the paragraphs into one text frame, but it is not
        considered hidden because it doesn't contain any hidden characters; if
        you insert a character into a paragraph, the merged text frame will
        disappear!
        
        The first idea was to adapt SwTextFrame::IsHiddenNowImpl() to check if
        there isn't any text in the text frame and the paragraph end marker is
        hidden.
        
        But it turns out that the problem is more general: it's a problem of the
        sw_redlinehide merging, because an un-merged paragraph is hidden via a
        check of RES_CHRATR_HIDDEN in SwScriptInfo::selectHiddenTextProperty().
        
        It's a bit nonobvious why this didn't work, and how it would interact
        with delete redlines, but 2 problems are that the case of the empty text
        frame needs a special case handling to get to this check in
        selectHiddenTextProperty(), and then GetBoundsOfHiddenRange() doesn't
        assign its outparameters in the special case of the empty paragraph; it
        looks like the values in m_HiddenChg should be 0, 0 then.
        
        Change-Id: I2ba85e98c02fb69159ee7ba77a7e4694fdf6fd52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182642
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-11  Miklos Vajna  <vmiklos@collabora.com>  [ab91358566ccf31f7a9ac57f1c32a9c62840f5d5]

        cool#11226 sw per-view redline on: support this-view <-> all-views transition
        
        Have 2 views, enable "this view" recording in view 1, then try to
        transition to "all views" still in view 1, nothing happens.
        
        This is because SwEditShell::SetRedlineFlags() checks if the redline
        flags would change (for this view) and since they don't change, we
        return early.
        
        Fix the problem by passing a "record mode change" bool around, which is
        set when when we keep recording on, but would switch between this-view
        vs all-views to still update the various views accordingly.
        
        Note that we have 3 states here, with the following intention:
        - off: if we transition to this, all views go to off
        - this view: transitioning to this from "off" just enables the current
          view, but transitioning to this from "all-views" turns off all views
        - all-views: if we transition to this, all views go to on
        Now all the 6 transitions between the 3 states is meant to work without
        surprises.
        
        Change-Id: I6e4d9e40f7008f680c476825a4d15dab12c6dadc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182764
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-11  Michael Weghorn  <m.weghorn@posteo.de>  [2da018de56e99e0843b9141d326a57aa1f264dab]

        tdf#130857 qt weld: Implement QtInstanceWidget::{g,s}et_margin_*
        
        Change-Id: I8b909a133ed87823ba4e362dbb8a25943baa2686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182762
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-11  Noel Grandin  <noelgrandin@gmail.com>  [b7b9cfce63879ae9408ef43a34af25617c97904d]

        no need to heap allocate here
        
        Change-Id: Ib22b861a55c082ec5dcde915e4c6f87135c799cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-11  Noel Grandin  <noelgrandin@gmail.com>  [a368b4321a8f1584939cbc1f2bc2c4ac83ddb97d]

        tdf#136238 Speedup deleting a very very large cross page table
        
        We have a very large nested/list action here, which means
        that RemoveOldestUndoAction() cannot do anything, and we spin
        in the loop in sw::UndoManager::AddUndoAction
        
        So we need to break out of that loop in this situation, which
        makes the delete almost instantaneous.
        
        Change-Id: Ia2bd9c0fd00c6551e99ae09154ecf0f680b9fcea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182748
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-11  Jonathan Clark  <jonathan@libreoffice.org>  [dcfc32914fe1d5239f9cbcb46a286f1a2e2d437e]

        tdf#70102 Code support for RTL variants in icon themes
        
        UNO commands may optionally rotate or mirror their icons depending on
        context (usually based on writing direction). This approach is an easy
        way to provide large numbers of such context-sensitive icons, but
        suffers from serious drawbacks in certain cases. For example, icons
        which contain asymmetrical symbols or text will be obviously mirrored,
        and icon themes which use shading will appear inconsistent next to
        non-transformed icons from the same theme.
        
        This code change lets icon themes provide specialized graphics for the
        left-right-top-bottom text direction. Such specializations are available
        for any command which specifies COMMAND_PROPERTY_MIRROR.
        
        Direction-specialized versions should be placed in the `cmd/rltb`
        directory within the icon theme.
        
        Localized specializations may also be nested inside that directory. For
        example, icons in `cmd/rltb/en` will be used for English in RTL context.
        
        Change-Id: Ic7a8cf3a6657a171e92123413d1c47e621f1bddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182761
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-03-11  Michael Weghorn  <m.weghorn@posteo.de>  [46159476c32c64e2f63d0e1a7ae77deca48b5920]

        tdf#130857 qt weld: Assert type before static_cast
        
        As Noel Grandin points out in [1], this can help
        "so we catch issues early and obviously (instead of getting
        some weird crash later on)".
        
        [1] https://gerrit.libreoffice.org/c/core/+/182711
        
        Change-Id: I5e8c9f9bc441f2c60d7a6b78ba52c7027d3fab7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-11  Michael Weghorn  <m.weghorn@posteo.de>  [5d5b1c0c1bcdd313ed0ea0227b7449d65651b3b9]

        tdf#130857 qt weld: Add Q_OBJECT macro to QtHyperlinkLabel
        
        This is needed to `qobject_cast` to that class.
        
        This prepares for upcoming commit
        
            Change-Id: I5e8c9f9bc441f2c60d7a6b78ba52c7027d3fab7d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Mar 10 13:00:11 2025 -0700
        
                tdf#130857 qt weld: Assert type before static_cast
        
        Change-Id: I89b930d4cacbf11ab5e85f627c0caf7aebaf61d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182751
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-11  langty  <zllangty@qq.com>  [19ac1ce1531e4ff6977cca1321c73494c0ffaef1]

        tdf#165553 Fix Draw import of nonzero paths from pdf
        
        Convert to nonzero path when importing FILLPATH from xpdfimport. This change
        should fix the handling of these kinds of pdf files generated from svg.
        
        Change-Id: Ic8d553d11c584462a4432f0971da9456a23d9347
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182667
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [501e5a7db75e265ace4b1efbe9b604d97b8e7b1e]

        tdf#130857 qt weld: Use more specific QWidget*
        
        ... instead of a pointer to the more generic
        QObject base class.
        
        Change-Id: I09629b746dbd3b04d5b78d5a46695795364e6e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182711
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [2b04f943428c1c29c3a6a596c129f75ae9753f70]

        tdf#130857 qt weld: Use map instead of vector for ID -> widget mapping
        
        Instead of using a std::vector of a custom WinAndId struct
        and iterating over all entries in QtBuilder::get_by_name,
        use a std::unordered_map instead to map between the OUString ID
        and the QWidget.
        
        This requires switching a few method params from std::u16string_view
        to const OUString&, which is consistent with other WidgetBuilder
        methods.
        
        Change-Id: I597315811f5842238f355f369c694ce0bb59de9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182710
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [5c660dee650edd029db296ea21e3bc4ad88d63a5]

        tdf#130857 qt weld: Look up menu in vector that has it
        
        Other than the widgets created directly in QtBuilder::makeObject,
        menus (QMenu) are created via WidgetBuilder::handleMenu and
        inserted into WidgetBuilder::m_aMenus.
        
        Therefore, use WidgetBuilder::get_menu in order to retrieve
        the QMenu from there.
        
        This also matches what the VCL implementation does, see
        SalInstanceBuilder::weld_menu.
        
        (QtBuilder::get<QMenu> was seen to return nullptr here in
        a branch experimenting with adding support for
        "sfx/ui/tabbarcontents.ui".)
        
        Change-Id: I3106882c0135d3358c160fa0e19e7c13d1e81b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182709
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c74df27aad015eec75c24306904c8c73f3ab4f5]

        update to skia m131
        
        Change-Id: If300d83a61389d19371d153a399eea10c2d87dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e384f2e8de9603c0e10bed9e35f26be08c0ca86c]

        crashtesting: crash on reimport of xlsx output of forum-pl-2758.ods
        
        also seen as a leak as nothing is erased by:
        
        maRegisteredCellAttributes.erase(&rCandidate);
        
        once the style names are changed and the std::set isn't ordered
        according to its predicate anymore.
        
        Easiest thing to do here seems to run the rename of a cell style through
        CellAttributeHelper so it can reinsert the affected ScPatternAttrs
        
        Change-Id: I13486701f378228792baa2b378709b7d530c3770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182743
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-10  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [ec65a00298ffbb30869dec222887f42f3ca4533e]

        tdf#165491 ITEM regression: Chart needs order of events
        
        The Item with WhichID SCHATTR_STAT_KIND_ERROR *has* to be
        handled 1st since it sets additional information about the
        ErrorBarStyle at beans::XPropertySet xErrorBarProp that the
        processing of the *other* Items already need access to, see
        'case SCHATTR_STAT_KIND_ERROR' in
        StatisticsItemConverter::ApplySpecialItem. This worked before
        the change of SfxItemSet to use a std::unordered_set since
        the order of Items was fix and - since SCHATTR_STAT_KIND_ERROR
        had the lowest WhichID - was handled 1st. Not sure if that was
        by purpose and it was known that this was necessary - there
        are no comments hinting to that, so it might have worked by
        coincidence before. In general it is bad style to rely on the
        'order' of Items in an ItemSet - there is no order defined in
        general.
        
        Change-Id: I93e2c8e30f762e1bb83adb2b43459bbfb263a151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182742
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-03-10  Gökay Şatır  <gokaysatir@collabora.com>  [3a593bf6bb5e6a2696205e4ef6c712fe828b47cf]

        cool#10967: Add a test for the fix.
        
        Before the fix, there are 4 calls to invalidateTiles while switching to notes view.
        After the fix, the call count is 8.
        
        Change-Id: Idd737a8ceb954073d2962b8cc7a9bbfa5830d285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182737
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8edd6684de55b9de1dc4b6b69aaf91f634e4b57]

        this should hold, otherwise the erase isn't doing anything
        
        Change-Id: I2982a48a05da2918a4c73628340e9e7c5f2663de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182732
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-10  Patrick Luby  <guibmacdev@gmail.com>  [6dd8de16f20be7d7e4e4581ef303a44b480dd5cb]

        tdf#128186 use non-full screen values for native full screen windows
        
        Also, ensure that restore rectangles are in VCL coordinates.
        
        Change-Id: I9c5d15b2217ec3804d1a6c365b3e0c71b054c143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182704
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [22f46bd89f6afc95438acf09fb5ff948f4ca8e02]

        use more concrete UNO classes
        
        Change-Id: Id10786bbf7985adbb251224b45f9dabcc84d0a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [376466a7451843be90d1ee12a3a7a2b65113e575]

        Emscripten: Pre-cancel synchronous execution of modal dialogs
        
        ...which would run into Application::Yield -> std::abort, so better live with
        this hack for now.  (The way forward would be to either asyncify relevant
        dialogs, or move to Qt6 and --enable-emscripten-jspi.)
        
        Change-Id: I143747cc32fb163e4908fa42b031e4eaea697d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182731
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8888e6f42df067304743fd2e82b8341e6bd42998]

        Emscripten: Hack to not call Application::Yield when loading xslt
        
        ...fixing one part of <https://github.com/allotropia/zetajs/issues/11> "The
        conversion of PPTX and XLSX files failed."
        
        Change-Id: I9f4dc63f424eeafd36c139c64260b179cb9ff24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182718
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [50ac0aa72f8af34ab180c8ea2060b0221afe0731]

        tdf#165502 Clear table preview when refreshing the data source
        
        Previously, when the Apply button was pressed for a second time in the "Data Provider" dialog, and the new dataset was smaller than the existing data, the content outside the new data range would still be visible in the preview.
        
        This patch ensures that the preview is cleared before updating it.
        
        Change-Id: I33861bba65d9059df2cf44fd76b74b0b981b9564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182701
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [daba307859942e17ec6686988d5d7ac34b06d438]

        tdf#154311: sc_subsequent_filters: Add unittest
        
        Change-Id: Id59ad205a969abc0ae9d2f9cc34a24b25323f682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182728
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [49323ab5e73a3c92a28d4c9fe386dcf5e78d2968]

        use more concrete UNO classes in toolkit
        
        Change-Id: Ief7941e0abbc111c6e0932b8bed84a626b9a744d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-10  Jean-Pierre Ledure  <jp@ledure.be>  [05d2701e3bba4c36752d5dbc144e103667ce1681]

        ScriptForge (Dialogs) add the TabPageContainer control
        
        TabPageContainer-type controls are not supported
        by the Basic IDE, while they are visually
        attractive.
        
        The current commit proposes the insertion
        of such a control by code
          dialog.CreateTabPageContainer(..., tabheaders, ...)
        where tabheaders is simply an array of strings.
        
        The originality of the approach is here to make
        the link with dialog pages very easy:
          OnTabSelected: define the script to trigger
                         when a tab is selected
          Value: get or set the actual tab
        
        Additionally, the TabPageContainer control is
        associated with the SetPageManager() method.
        
        Example on
        https://gitlab.com/LibreOfficiant/scriptforge/-/snippets/4823173
        
        The function is available for Basic and Python user scripts.
        
        The documentation will need to be updated accordingly.
        
        Change-Id: I7a1644344cad5f3739055f7e1eec69310ffa019c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182697
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb42d9e8a5246973921cfbd43d2e76afde85798a]

        Resolves: tdf#143909 some gtk im need to see key release
        
        e.g. GTK_IM_MODULE="gtk-im-context-simple" GDK_BACKEND=x11 and
        ctrl+shift+u followed by hex digits in writer comments
        
        Change-Id: I0da17b8e18b088789cb6359610473da22c9c70af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-10  Miklos Vajna  <vmiklos@collabora.com>  [18d6c749361887f481c9bac9df92deb14047f171]

        svx: prefix members of SgaIMapInfo
        
        See tdf#94879 for motivation.
        
        Change-Id: Iaad47716ce87141a854ce33711fd73d78b1ae26b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182715
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c94fa3d5b2225e46eb5d90a090e0586cbc7464ba]

        tdf#150317 - Sync visible tab during save process
        
        Change-Id: I188d59e2b5ca7d7d6f92d405b886d3c12420b690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182698
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-03-10  Heiko Tietze  <tietze.heiko@gmail.com>  [684658df943b9cb8e25e9727af1147d22e396078]

        Resolves tdf#165085 - Automatic font color on PDF document
        
        Patch 2ca381b31e40d516c5d79ce4e59cecbf9683b616 applies here too
        
        Change-Id: I82948ef4f8d8bc9312cc24692ff3471710543ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181327
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-10  Karthik  <me@karthikreddy.org>  [d5f5f0e06d15dfa43da90d86e9a99ed60f7fb690]

        tdf#156915 Tabbed UI: add Theme below Watermark in layout context menu
        
        Change-Id: I6ac60d396daea7b8814f4b21e9251ca580b3359e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182516
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-10  Karthik  <me@karthikreddy.org>  [d501fe41ddcb2d338baee301cbd534944cd116ff]

        tdf#164012 Add Change Master... below Move in Slide Pane context menu
        
        Change-Id: I408efd7369336965af8b572493043556af9fcc1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182526
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-10  Aron Budea  <aron.budea@collabora.com>  [a3d767248392dd1acffd7b16b45b2841e410d528]

        tdf#165503: sc_subsequent_export_test4: Use precise XPath
        
        The previous one was working fine, too, but it was missing the
        last, single element in the path.
        
        Change-Id: I8d8d359436f52fd8d5397b29905747e40d5f8793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182550
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2025-03-10  Patrick Luby  <guibmacdev@gmail.com>  [331ea32ec181aff739eaebee328281b190cad003]

        Related: tdf#41775 show Start Center when loading a document at launch
        
        This is the second attempt to implement a fix for tdf#41775
        after reverting commit 9e3d8d0176bb1e95414e4a578065c2e1035a8dd6.
        On macOS, the Start Center's menubar is the "no windows open"
        menubar. This is done by making a native copy of the Start
        Center's menubar each time it is opened (note: on macOS the
        Start Center window can be closed and reopened repeatedly)
        so pre-populate the "no windows open" menubar by opening the
        Start Center even if a document is going to be loaded.
        
        But if LibreOffice is launched by opening a document from the
        Finder, dragging it onto the application's Dock icon, or from
        the command line with a module or document path parameter, the
        the Start Center doesn't get created when all of the document
        windows are closed. This causes the old "File only" menubar to
        be displayed instead of the "no windows open" menubar.
        
        Change-Id: Ide079014b4a7db390ae4d084b45af922f0422525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182702
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d6ab5c01b2fe486c0e4f8090d7c1eacbe7a12f6c]

        Fix typo
        
        Change-Id: I5f87f4c5ef8e20c9b6629b9f3e1b7e51396fda25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182688
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [529f831e7380aeadc00d8ae4b51bca4c53cb25aa]

        Removed executable permission on rtf file
        
        Change-Id: If3157a1e669c28eabf9c214a80e15356280b9614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182689
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2beea94d05198628d06c88e41351d94389abc784]

        Fix typo
        
        Change-Id: Ifa3c2c456665769ae59f7b99cf1f12c6fc70fa1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182687
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df4b633fa46bce5db6a09b0513feced2a68b7e68]

        Fix typo
        
        Change-Id: I43ba3b1b227503f85e006d7ed3c238924527951d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182686
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b918d301a815ba251e74cbf6ac64ed65d28a0106]

        Removed executable permission on idl file
        
        Change-Id: I093389379b73695ed2b86e4f6b39c909b4ce5e2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182690
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d42994e8fed5836489b1e1f425c120809de7826]

        Fix typo
        
        Change-Id: I0a3e5331c41f67529ea97aa5bf8fb02fa9ec4978
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182691
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3335e1b12c34d56a7693678c88ae541177a335a4]

        Fix typo
        
        Change-Id: I54017fe34bd4f71006ca83dca33c23473f852dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182692
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-09  Patrick Luby  <guibomacdev@gmail.com>  [5696cee879e6c6794c213cb3db294bb78e8680f6]

        Revert "Related: tdf#41775 show Start Center even if loading a document"
        
        This reverts commit 9e3d8d0176bb1e95414e4a578065c2e1035a8dd6.
        
        Reason for revert: after testing, I found that only command line arguments go through this patch's path. It is extremely difficult trying to find where opening from the Finder or Dock is occurring since I cannot launch LibreOffice from the command line to test in my local build.
        
        Change-Id: Ica339cb4b76c1943ad04c8f3dd7f987c97dfe164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182695
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-09  Patrick Luby  <guibmacdev@gmail.com>  [9e3d8d0176bb1e95414e4a578065c2e1035a8dd6]

        Related: tdf#41775 show Start Center even if loading a document
        
        If LibreOffice is launched by opening a document from the
        Finder, dragging it to the Dock, or including it in the
        command line arguments, the Start Center doesn't get created
        when all of the document windows are closed. So, the old
        "File only" menubar is displayed.
        
        On macOS, the Start Center's menubar is the "no windows open"
        menubar. This is done by making a native copy of the Start
        Center's menubar each time it is opened (note: on macOS the
        Start Center window can be closed and reopened repeatedly)
        so pre-populate the "no windows open" menubar by opening the
        Start Center even if a document is going to be loaded.
        
        Change-Id: Ia3353748ca0517bb5f090f0b09641c93cf22c260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182682
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-09  Justin Luth  <justin.luth@collabora.com>  [60788682d3d62264e8a5ac42f3469f2d2f55815c]

        tdf#165642 docx export glossary: RT endnotes.xml/footnotes.xml too
        
        settings.xml might refer to endnotePr
        (in which case there must be an endnotes.xml file)
        and / or footnotePr
        (in which case there must be a footnotes.xml file)
        so round-trip these 2 files also if they exist in the glossary folder.
        
        Otherwise MS Word complains about invalid content.
        
        For this particular unit test it went bad in LO 7.4.4,
        but in other circumstances, it already goes bad in LO 4.3.
        
        make CppunitTest_sw_ooxmlexport22 \
            CPPUNIT_TEST_NAME=testTdf165642_glossaryFootnote
        
        Change-Id: Ib4c2513fa915fc4de4aee056b67a5936be5c52a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182674
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-03-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f668fab0441500da85b76ee042309dcfb67d2253]

        Resolves: tdf#160391 test if dark/light mode changed at WM_THEMECHANGED
        
        what docs there are generally mentions WM_SETTINGCHANGE with lParam of
        ImmersiveColorSet but this seems to be too early for UseDarkMode() that
        uses ShouldAppsUseDarkMode to always return the right thing. While
        at WM_THEMECHANGED UseDarkMode() ShouldAppsUseDarkMode seems to be
        more robust.
        
        Change-Id: I0d582b441d0beeadc61d41e6518012fccdcce6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182673
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-08  Noel Grandin  <noelgrandin@gmail.com>  [44ed2efc53cb36bd5837e9d51f0922798e8ae515]

        flatten t_OUString2PrefixMap
        
        no need to use unique_ptr indirection here
        
        Change-Id: I557e5ada59b9ff054eb2fced321bcf341e04232b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182664
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-08  Noel Grandin  <noelgrandin@gmail.com>  [1d0da28c7e8bb962c33f2390f42e0e84e47ada9d]

        no need to allocate these ScTokenArray on the heap
        
        Change-Id: I605e9d3fc19e118b4992cf0799a91de189ed0dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182665
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [309ac64cf45e0d165a84e8526bf388697dba9ec5]

        use more concrete UNO in chart2
        
        Change-Id: I0f91e4ed7a2ddc656d0edb3c8a54960a3b1b70b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182666
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [25ac3297b02c2c32e6d6ee661b89ce7361c2f7d2]

        use more concrete UNO in svx
        
        Change-Id: Ie947ba0209f9166ee1cd065f91341292f2b02668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-08  Patrick Luby  <guibmacdev@gmail.com>  [3b96af6479ddbbf27834ed93ed9543b91451befb]

        tdf#151423 revert commit b197379e867087413be86bd1a32030b912ecaa8a
        
        User testing found that scrolling with a Magic Mouse while pressing
        the Command key only reenables zoooming sporadically so revert
        commit b197379e867087413be86bd1a32030b912ecaa8a.
        
        This revert will disable zooming on a Magic Mouse just like on a
        trackpad until another heurisic is found to reliably identify a
        Mouse Magic.
        
        Change-Id: I6b4b92bcdea44702385b7db2fe24fb05bfe99df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182670
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-08  Oliver Specht  <oliver.specht@cib.de>  [bf557f6c181578e1e89f63e502aae3eed1880af1]

        tdf#165064 fix regression from tdf#161233
        
        Change-Id: I07953d4569542774c8012b879f3894e7da61e0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182487
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-03-08  Oliver Specht  <oliver.specht@cib.de>  [554d2769d1c8c5b2fa03d2c72e91c92a94fb3cd8]

        tdf#71583 Add page count of ranges with consecutive page numbering
        
        Adds a field that counts the pages in ranges defined by page number restarts
        
        Change-Id: Ie0727ab20c81464918ad5fb9aa42046bf00aa63c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178141
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-08  Jan Rheinländer  <jrheinlaender@users.sourceforge.net>  [d6114ed001160f7e5d5607d96f572a484473c571]

        Fix bug in SalInstanceTreeView::columns_autosize()
        
        SvTreeListBox::getPreferredDimensions() returns widths, not positions
        Bug can be reproduced by adding a line to BookmarkTable::InsertBookmark()
        Unit test fails unless patch 180450 is applied as well
        
        Change-Id: Iafa9ca02968d4ec3dce95ef5242396c3ce5d4c7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-08  Michael Weghorn  <m.weghorn@posteo.de>  [2432b0ae28af0191348d2fe04a29c097c38ee6fa]

        solenv: Fix indentation in Python GDB pretty printer
        
        Fix incorrect indentation causing
        
            Traceback (most recent call last):
              File "/home/michi/development/git/libreoffice/instdir/program/libbasegfxlo.so-gdb.py", line 23, in <module>
                module = importlib.import_module('libreoffice.' + mod)
              File "/usr/lib/python3.13/importlib/__init__.py", line 88, in import_module
                return _bootstrap._gcd_import(name[level:], package, level)
                       ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
              File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
              File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
              File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
              File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
              File "<frozen importlib._bootstrap_external>", line 1022, in exec_module
              File "<frozen importlib._bootstrap_external>", line 1160, in get_code
              File "<frozen importlib._bootstrap_external>", line 1090, in source_to_code
              File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
              File "/home/michi/development/git/libreoffice/solenv/gdb/libreoffice/basegfx.py", line 121
                if self.index >= self.count:
                                            ^
            IndentationError: unindent does not match any outer indentation level
        
        since
        
            commit 221f9aa5828aad420d0599f5a24f71b7f83c9244
            Date:   Wed Mar 5 21:46:04 2025 +0100
        
                another try for Armin's problem with debuggers and pretty printers
        
        Change-Id: I53330858c433ff4dd2b0dadce89ea955b3a014c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182662
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-08  Kohei Yoshida  <kohei@libreoffice.org>  [bcd544aafc6ae3c3472f056cdb99a4cab6b74d82]

        Apply clang-format to other orcus-related files
        
        Change-Id: If8bc8c79a797027f5e44e36590c36aa30f79c342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182661
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Tested-by: Jenkins

2025-03-08  Kohei Yoshida  <kohei@libreoffice.org>  [cd1998864f49819871c6ef7b0f6ea958be15ac40]

        Move ScOrcusGlobalSettings into its own header and source
        
        This is to avoid autofilter.cxx from including the entire
        orcusinterface.hxx header.
        
        Change-Id: I3c265682f793873018fcec5a31583c4ca6332641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182660
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Tested-by: Jenkins

2025-03-08  Kohei Yoshida  <kohei@libreoffice.org>  [08c9e64c0bedc05767dbcdfb879d389e0c413d85]

        Import autofilter via orcus interface
        
        This should address tdf#154311.
        
        Change-Id: I84401ad7a9982eaa868e68d7ae612debf09ecf9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182606
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2025-03-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e2effa8955db4dc4b31145fbb14b53636b32186]

        Resolves: tdf#165455 fix hover in RTL custom widgets under GTK
        
        Change-Id: If8f4e219766a7a17a85fea60e4d7855684e57d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-08  Patrick Luby  <guibmacdev@gmail.com>  [1553e8c2b245b2226454e5fdacdf77da58fe0a18]

        tdf#165266 fix conditionals that limit -[NSApp setAppearance:] calls
        
        Calling -[NSApp setAppearance:] fires an NSNotification even if it is
        called with the curent appearance as parameter. To reduce the number
        of NSNotifications, commit 48125efbd7bf370981d48e4a8d0ce7fbaf1857e1
        attempted to limit the number of -[NSApp setAppearance:] calls but
        the conditionals were flipped and that commit ended up blocking
        -[NSApp setAppearance:] calls once it has already been set to a
        non-nil value.
        
        Also, sync NSView's appearance to NSApp's appearance. Invoking
        -[NSApp setAppearance:] does immediately update the appearance of
        each NSWindow's titlebar, but it does not appear to update any
        NSView's appearance so explicitly sync appearances.
        
        Change-Id: I996daa868807cd5e4c8194f80d1f783b9e6e4e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182654
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-03-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [37a99eb4d3489206d9385b9c065c5bb541c17b32]

        tdf#165341 - FILEOPEN PPTX: fix paragraph alignment for text wrapped shapes
        
        In case of word wrapped text objects no need to set TextHorizontalAdjust based on text alignment.
        
        regression from: 1d9ce0a67a71e51569cd33c26270eeece587a354
        (tdf#162571 - sd: Text box expands or shrinks on left or right or)
        
        Change-Id: I9455e30a58cc3853bc2a1c2030ab7cc62314106c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182616
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4ba511f17e7ccbb52e3b83dea77ab4b27025d1e7]

        Related: tdf#165455 get tooltips working for RTL custom widgets under GTK
        
        Change-Id: I0e011b4d8d72c5133297127381ffe5c86e81ec51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182643
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-07  Michael Weghorn  <m.weghorn@posteo.de>  [76bd6bf83309c50177fc230231755b8aaffb1e77]

        tdf#162995 gtk4: Add combobox in file dialog after its label
        
        First add the label, then the combobox that labels it.
        This ensures that the label comes first visually, then the
        combobox for the gtk4 VCL plugin, as is already the case for gen,
        gtk3 or qt6.
        
        This can be seen e.g. in the "File" -> "Open" dialog
        where using an LTR locale now results in
        "Version: [Current version]" instead of "[Current version] Version:".
        ("[Current version]" here refers to the combobox with the
        "Current version" entry selected.)
        
        Change-Id: Ib814bba460ca84a694029107d4a66a274860b716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182641
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-07  Michael Weghorn  <m.weghorn@posteo.de>  [122de03c9693089b2b7b9f26a6faf33d9ecce417]

        tdf#162995 gtk4: Handle file dialog selection changes
        
        The GtkFileChooser::selection-changed signal used
        by the gtk3 VCL plugin no longer exists in GTK 4
        and there doesn't seem to be any equivalent new API.
        
        In order to still be notified about selection changes
        in the file dialog, make use of GTK implementation
        details of the GtkFileChooserDialog to retrieve the
        GtkColumnView used in the dialog and connect to
        the GtkSelectionModel::selection-changed signal of its
        model.
        
        With this in place, the "Version" combobox in the file picker
        triggered via "File" -> "Open" from Writer now has a
        "Current Version" entry as expected (and seen with
        gtk3, gen, or qt6) when an ODT file is selected, while
        the combobox had no entry at all previously when using
        the gtk4 VCL plugin.
        (Tested with gtk git main as of commit
        739467d16fc465089dcfc4defd5a80dbf1b9d044)
        
        Regarding the non-existance of an official
        GtkFileChooser::selection-changed replacement,
        see also GNOME forum discussion at [1], which also mentions
        another workaround:
        
        > I ended up implementing the preview by adding atick_callback to the
        > widget and just checking every frame if the selection changed and then
        > emitting my own signal. Obviously this is terrible style and goes
        > against the signal architecture but it will have to do for now, as I
        > needed the custom preview to display information about a custom
        > file-type that’s specific to my application.
        
        [1] https://discourse.gnome.org/t/gtk4-filechooser-selection-changed-signal-alternative/12180
        
        Change-Id: Ieafea7bead5ed4f419ee21e83679c4834d50fff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182640
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8ce0b9964fc198eff0b8b4441d34b54063a2fd83]

        Resolves: tdf#165603 zoom settings reset to default in ctor
        
        after they were loaded from the config
        
        Change-Id: Id58d997d620b00f7e7ae9a7b9d71fd628d44db8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182635
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ded5a925e3aec66a890787bd96e9cc5477541a39]

        tdf#165229 Extended tips for Data Provider Transformations
        
        Change-Id: I20152909f691fc0cb483f4ceaa0887dcd893c86f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182603
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-03-07  Justin Luth  <justin.luth@collabora.com>  [81cbe4a2cb19dd2b552d83772075267cc64c3f01]

        typo: off -> of
        
        Change-Id: I9edfe99f2a96e1d92c663cc894800e649f224284
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182628
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-03-07  Michael Weghorn  <m.weghorn@posteo.de>  [678a00dc1eb3ae12ef2d83f6ae12fd6cdf000626]

        tdf#162995 gtk: Initially hide custom file dialog controls
        
        Explicitly set custom file dialog controls to invisible
        initially, as they are explicitly shown when needed.
        
        While this isn't needed for gtk3, where GtkWidget:visible [1]
        is FALSE by default [1], it is for gtk4, where the property
        is TRUE by default [2]
        
        This addresses the
        
        > Currently, too many controls are visible there for gtk4, but that
        > will be addressed in a separate commit.
        
        aspect mentioned in previous commit
        
            Change-Id: If351c24010702e374adb816366892d9ed5280d17
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Mar 7 06:10:49 2025 +0100
        
                tdf#162995 gtk4: Show extra controls in file dialog
        
        [1] https://docs.gtk.org/gtk3/property.Widget.visible.html
        [2] https://docs.gtk.org/gtk4/property.Widget.visible.html
        
        Change-Id: Ife8bcc97073807b605bee69434a3db60e1967f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182610
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-07  Michael Weghorn  <m.weghorn@posteo.de>  [521bcdc4535555a45934a6e224a96aa87bbef659]

        tdf#162995 gtk4: Show extra controls in file dialog
        
        While the custom widgets for the file chooser were
        created for the gtk4 case as well, they were never
        added to the dialog because the call to
        `gtk_file_chooser_set_extra_widget` only happens for the
        gtk3 VCL plugin.
        That GTK function is no longer available in GTK 4.
        
        For gtk4, use gtk_dialog_get_content_area to get
        the GtkBox holding the dialog content, and add the
        GtkBox holding our custom controls to it manually.
        
        With this in place, it's now e.g. possible to save a
        file with password protection by checking the "Save with password"
        checkbox in the "File" -> "Save As" dialog.
        
        Currently, too many controls are visible there for gtk4, but that
        will be addressed in a separate commit.
        
        Change-Id: If351c24010702e374adb816366892d9ed5280d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182609
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [620b89adea77519fd5d057cac7e1acf8a6fb2544]

        tdf#165321 - sd ooxml import fix missing shapes or shapes with near
        
        zero height
        
        Use the calculated shapes size (before we calculate the shape size with
        NbcAdjustTextFrameWidthAndHeight if the autoTextGrowHeight is true) instead of the shape size directly from the xml, which need to be transformed in some cases.
        
        Regression from commit: ebf13e890766f4cadbba81444784cfe3c8e1bbc3
        (tdf#156857: sd ooxml import: fix shape size if spAutofit is set)
        
        Change-Id: Icddaf22d10a89b172a3f1ca3e55150162e51a877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182581
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-07  Jaume Pujantell  <jaume.pujantell@collabora.com>  [7b57004cf20ae1715eabd6623ad9007a68a0a32e]

        tdf#165059 sw fix not valid moveFrom/moveTo tag
        
        According to the ISO standard, w:moveFrom/To elements are only permitted
        within a move*RangeStart/End section. If not inside such delimited range
        only w:ins and w:del are valid.
        
        We still write w:move* in paragraph properties outside of move*Range.
        This is technically also not valid, but lots of tests seem to have
        documents with this, and it is outside the scope of the bug.
        
        Change-Id: Iaf097b8b017aac1f6182a91abe464433e7664620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182503
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182633
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2025-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0f4f4b5e476fa5c3c64fcdc2e3cb473969703f7]

        use more concrete UNO in sc
        
        Change-Id: Id339156cd7f9b74985575a200ed3946c6d3e5d8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182622
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0ac8d313c9e8469b4545f5d4fc30894a3719004]

        use more concrete UNO in sw
        
        Change-Id: Ibea3bdca049dac353c7a1d3ab1311db38f7da132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a1f131a124cc6620c2423da5867985300962a42]

        cool#11258 move Language into the cache key
        
        setMisspellRanges complicates things somewhat, so return the
        cell language from getMisspellRanges and propogate that along
        with the misspelled range so SetAutoSpellData can transport
        the Language back to setMisspellRanges
        
        Presumably we can assume that the cell language in
        ScInputHandler::EnterHandler2 is that of the EditEngine for
        the case of freshly created MisspellRanges.
        
        https://github.com/CollaboraOnline/online/issues/11258
        
        Change-Id: I93bb869eacbab8ebec875e891d1ed42512cdf9a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182627
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4ba2e1c5a1ee9243a9d5df80d1a7f216653c960]

        trim excessive leading whitespace in connectivity
        
        Change-Id: I5629ca3ac7503c1cab848f65fcd25d15a1e3dcaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182580
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>

2025-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1b6f4f706492c0889025786f6b3736782dd9194]

        use more concrete UNO in dbaccess
        
        Change-Id: I46188654135721d21dd05ac2778224a078e96293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182623
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-07  Oliver Specht  <oliver.specht@cib.de>  [38464825c8c80eed0d9b328a89cd96eb27175a0e]

        tdf#165483 style inherits only repated properties
        
        Each attribute a style inherits from a parent style needs to be
        repeated at that style. Otherwise it is overwritten by a default
        attribute.
        
        Change-Id: I9cef60b0d1eaa16d212f091434e9896bfd4a44c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182284
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-07  Mike Kaganski  <mike.kaganski@collabora.com>  [75135c6c7d43b9d4f979a026cdd2529209cb9dea]

        ReqIF export: avoid writing border properties
        
        Change-Id: I05e7ba3fda54300f99fd2121aaa5d167dd27851c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182617
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [55b13db9f18a945bb5e61e14a462f5770ce99d66]

        create-mar: flush stdout to see the message when using  2>&1 | tee log
        
        in case the script is aborted/fails otherwise and doesn't remove the
        lockfile, another attempt to obtain the lock ends up in an endless loop
        
        No problem if the user sees the corresponing messages, but when using
        shell redirection of stdout and stderr and trying to tee that to a
        logfile, the message is never seen/the buffers are not flushed
        
        So force flushing stdout to have the message show up in the terminal
        
        Change-Id: Ib133b9bc523d9ba2210564f75762258f41415f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182595
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-03-07  Miklos Vajna  <vmiklos@collabora.com>  [33b411c51578d47c84b4fd1d0f9176bd01744d5d]

        cool#11289 desktop lok: don't assume all views invalidate the same area
        
        Have 2 Calc views, go to e.g. F30 in the first view and F31 in the
        second view. Type enough in the 2nd view that the text goes outside the
        cell, to a next tile, e.g. till the column I area is reached; text
        doesn't show up in the new tile area on typing.
        
        This went wrong in commit 43965ae570ded21653dabb5ec0570f8aaa7c497e
        (cool#11254 desktop lok: avoid invalidations if no tiles are sent,
        2025-03-05), because it assumed that all views get the same
        invalidations, but they do not in this case:
        debug:12008:11949: ScGridWindow::LogicInvalidate: view #5, rect is 6670x345@(20452,14102)
        debug:12008:11949: ScGridWindow::LogicInvalidate: view #4, rect is 2144x372@(20452,14102)
        debug:12008:11949: ScGridWindow::LogicInvalidate: view #5, rect is 6670x345@(20452,14102)
        debug:12008:11949: ScGridWindow::LogicInvalidate: view #4, rect is 2144x372@(20452,14102)
        debug:12008:11949: ScGridWindow::PaintTile: view #4, x is 11520, y is 7680, w is 3840, h is 3840
        
        Fix the problem by tracking paints in all views of a view group sharing
        the same render state ("have the same canonicalviewid").
        
        Getting the view render state on tile paint for each view would be
        expensive, so get that once and then subscribe to the update callback.
        The view render state is then still compared as string -- if that shows
        up in a profile, we could switch to integer-based tracking instead with
        some added complexity ("canonical view id").
        
        Change-Id: I151b1ff9713ea13f2ee218b4cb44e4b0a227abcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182615
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-07  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [221f9aa5828aad420d0599f5a24f71b7f83c9244]

        another try for Armin's problem with debuggers and pretty printers
        
        had to refine a typo, also all places with '\{\}\)->' that
        call functions at an incarnation have to be made safe, so
        added this also to getPrevControlPoint/getNextControlPoint
        calls.
        
        see commit 3c82f49fcee3f1e4ddae8919993dde57e8bbab2d for more details
        
        Change-Id: Id8c1abfeb41961a9cca85ef28b2ea70beb07f37c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182548
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [894563ee0e4032019623a97c313af3d833863b1f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ae751565346311b204f62a1e82e22d2e9969d44
          - tdf#137419 More content in Data Provider Help page
            
            + Add details on transformations
            
            Change-Id: I8be7e6143da4727c8083651c0e36812411a2237a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182604
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-03-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a915fe8299fd27aeaef5e5f3be4f9e1e5f6e5014]

        Fix typo
        
        Change-Id: I3704da2755323eda86835ee55a91062e334dc36f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182579
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [efaceac76b91cb114c9f87d56872f085143cabab]

        Revert "tdf#165504 restore SdrPage::GetLayoutName virtual"
        
        This reverts commit 5137fcc47f8e40dcba991db1f57dc1b395bbf970.
        
        The commit I bisected in
        https://bugs.documentfoundation.org/show_bug.cgi?id=165504#c3
        was actually the same as tdf#164463 which got fixed in
        960db01dbfe2f916b91782da03532fae1f836445 "Resolves: tdf#164463 we need
        to pass a copy of the LayoutName"
        So this revert is not necessary.
        I'm really sorry for all the inconveniences caused.
        
        Change-Id: Ice96b06220decf8078658b61ca721638cc8d2254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182578
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-03-06  László Németh  <nemeth@numbertext.org>  [6e31affdbab46d548d7b680a0128cf9fbd3e3f6c]

        tdf#165354 sw HyphenationKeepLine: fix 3-page or longer paragraphs
        
        Fix layout of 3 or more page long paragraphs (when the third or
        more pages start with a hyphenated line) by removing an obsolete/broken
        limitation (detection of shifting the entire hyphenated line, when
        HyphenationKeepLine is false).
        
        Add more unit tests for long paragraph.
        
        Follow-up to commit e79e12484f5a7ec20e48233a2b5b60d7bd8b54ab
        "tdf#165354 sw: fix frame update (HyphenationKeepLine – part 4)".
        
        Change-Id: I8a06ccf3eb7d5f5e5e31478f3765b543bd374da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182590
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [9cef7e5ba50b483cd84682528c7ef503965b6104]

        tdf#161583 vcl,sc,sw: PDF/UA export: fix Contents of Link annotations
        
        In ISO 14289-2:2024 the requirement was changed from "shall" to "should":
        
          Link annotations should include a Contents entry to enrich information
          available to assistive technology.
        
        There is also now a Well-Tagged PDF (WTPDF) Version 1.0.0, which says:
        
          8.9.2.4.2 Link
        
          Link annotations should include a Contents entry to enrich information
          available to assistive technology.
        
          NOTE 1 Link annotations are often accessed out of context; the Contents
          entry provides optional additional information. The Contents entry is also
          particularly valuable in the context of link targets that are not intended
          to be human-readable.
        
          EXAMPLE — A link over the text “click here” is improved by a Contents entry
          to advise the user regarding the link’s target.
        
        So adapt PDFWriterImpl::emitLinkAnnotations() to produce "Contents" only
        if there is some alt text.
        
        The sw a11y check will already warn if the alt text/"name" is missing on
        a hyperlink in a SwTextNode, and a previous commit added a warning if it
        is missing on a hyperlink in a SwFlyFrameFormat.
        
        Contents should in any case not contain the textual representation of
        the hyperlinks, that was a misunderstanding, but describe the target of
        the link.
        
        This requires adapting numerous unit tests.
        
        (regression from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9)
        
        Change-Id: I88a7ae83d17d781115c93152d267ddb57208c200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182600
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [7ada3b1012f84a192b339dd9e3a015fa8979051f]

        sw: fix testTdf165354_column
        
        XPath '/root/page[1]/body/txt/section/column[2]/body/txt/SwParaPortion/SwLineLayout[1]' not found
        
        (regression from commit e79e12484f5a7ec20e48233a2b5b60d7bd8b54ab)
        
        Change-Id: I52a520dfef2a06efacd65556bb1780f05871c7a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182599
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-06  prrvchr  <prrvchr@gmail.com>  [ed90785aad27068bb3f02fbc1cf584070418a89c]

        tdf#165617 remove unused import from uno-skeletonmaker
        
        Change-Id: Ica9a8078cd85b224ea50fab878cbe339668e0604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182596
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [8bf8873f3091f131f6b4067d5a5f868882949114]

        tdf#161583 drawinglayer,editeng,svx,sd: add "Name" to SvxURLField ...
        
        ... and use for PDF export, instead of the representation, which appears
        to be wrong.
        
        Strangely the Hyperlink dialog already allowed to insert a Name, but it
        was not actually set in the document.
        
        (regression from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9)
        
        Change-Id: Ic21bbe8ead9f85dfbe0827b0051ecb68aeff0beb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182597
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [934c0769ed78ae6f503d869c9cdcaf3e744f3316]

        use more concrete UNO classes in sd
        
        Change-Id: I8727b67fbafa2a7baf89589ee2c85ce4637659ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182584
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-06  shrey_223  <shreykhakharia223+1@gmail.com>  [59d89cd23c5ad5c2241eca39ea057d715d925aea]

        tdf141137 AutoCorrect submenu are missing from the Groupedbar Compact
        
        Change-Id: Ia2f67b2a921afdb2da8617b99209485940a21e78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181451
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [5445e9de41b1330fa27e07d46eaa4babe956645f]

        tdf#161583 sw: a11y check: warn about flys with RES_URL with no "name"
        
        Fly frames can have hyperlinks too.
        
        Change-Id: I80da4b53e44e6f82a4f37f4b2aa859b8475b452a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182577
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-06  prrvchr  <prrvchr@gmail.com>  [f78397068fa7fd403046605fb37620fba7a76e63]

        tdf#165580 uno-skeletonmaker provide passive registration
        
        Change-Id: Ic347a68eb1a13923493d6efe6d911e7e705145a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182436
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-06  Andras Timar  <andras.timar@collabora.com>  [f78a20ea166123c6891c06b50b6a2394e4fcae06]

        LOK: add OpenGL transitions to impress package
        
        This is a follow-up to b83387a55410a0f7701b3cb7898ef15a36668e4c
        that added the necessary files to instdir, when
        ENABLE_OPENGL_TRANSITIONS was not TRUE. That variable is unset
        for LOKit/COOL for various reasons:
        1) disabled for MPL-only build
        2) disabled without X11
        So I add the files from instdir to impress deb/rpm package based on the
        conditions:
        1) the target operating system is LINUX, and
        2) USING_X11 is not defined.
        That is the LOKit/COOL case, and I hope it will not interfere with
        anything else.
        
        Change-Id: Ia04249c5ed609b2d8e7695ae6e8dd648cdf9b825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182438
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit af65c54f9c2ca7750a9466e21745efb9b449ec78)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182452
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-03-06  Jim Raykowski  <raykowj@gmail.com>  [6c7593e0366cb7705234960d555a451e27753725]

        tdf#163347 Restore options chart colors page color column for gtk3
        
        The surface attribute for the cell renderer pixbuf in column 1 of the
        chart colors tree view needs to be set to 0 for gtk3 to show the color
        column. It got bonked when resaving with a newer version of glade in
        commit
        7eb0e13c6547f00bc139d817ef53350c99e3eb2e
        
        Change-Id: I1ab322b9f54bd6dd07de5a484ca77917e5be2d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182551
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2025-03-06  Jim Raykowski  <raykowj@gmail.com>  [90fdf50aa5dac4520893a98e52feb8d1ae8d9d7a]

        tdf#163646 Writer Navigator enhancement to show in the tooltip for
        
        Headings entries the outline word and character count that includes
        all sub outline words and characters.
        
        Examples:
        
        FIRST_LEVEL_HEADING --> tooltip shows 30 words
        two three four five six seven eight nine ten
          SECOND_LEVEL_HEADING --> tooltip shows 20 words
          two three four five six seven eight nine ten
            THIRD_LEVEL_HEADING --> tooltip shows 10 words
            two three four five six seven eight nine ten
        
        FIRST_LEVEL_HEADING --> tooltip shows 17 words
        two three four five
          SECOND_LEVEL_HEADING --> tooltip shows 4 words
          two three four
          SECOND_LEVEL_HEADING --> tooltip shows 8 words
          two three
            THIRD_LEVEL_HEADING --> tooltip shows 5 words
            two three four five
        
        Change-Id: If2a40c14633889d6a38df77f017b73a0f038584d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175895
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-03-06  László Németh  <nemeth@numbertext.org>  [e79e12484f5a7ec20e48233a2b5b60d7bd8b54ab]

        tdf#165354 sw: fix frame update (HyphenationKeepLine – part 4)
        
        Fix missing layout frame update, when the last hyphenated
        word is moved to the next column (i.e. also text frame or
        table cell), page or spread:
        
        – at modifying hyphenation settings: 1) enabling hyphenation
          in the last line again or 2) enabling Move Line;
        
        – at loading columns/frames with hyphenation-keep-line="true"
          setting: hyphenation wasn't disabled in the frames, despite
          the document model (but it was possible to update them by
          using Toggle Formatting Mark);
        
        – at text editing: deleting lines before the line with disabled
          hyphenation didn't enable its hyphenation, despite that the
          line was not the last line on the page any more.
        
        Add various unit tests for columns, frames and tables, when
        the last hyphenated word moved or not moved to the next column,
        text frame or page:
        
        – hyphenation-keep-type="column":
        
            – tdf165354_column.fodt: disable hyphenation at the end
              of all columns;
        
            – tdf165354_frames_on_same_page_no_hyphenation.fodt:
              disable hyphenation at the end of all linked text frames,
              including when they are on the same page.
        
        – hyphenation-keep-type="page":
        
            – tdf165354_page_in_last_column.fodt: disable hyphenation
              at the end of pages, in columns, too;
        
            – tdf165354_page_in_not_last_column.fodt: otherwise don't
              disable hyphenation at the end of the non-page-terminating
              columns;
        
            – tdf165354_frames_on_same_page_hyphenation.fodt:
              don't disable hyphenation at the end a linked text frame,
              if the next frame with the continuation of its text is there
              on the same page.
        
            – sw/qa/extras/layout/data/tdf165354_page_in_table.fodt:
              disable hyphenation at the end a table cell, if the text
              continues on the next page;
        
        – hyphenation-keep-type="spread":
        
            – tdf165354_frames_on_spread_hyphenation.fodt:
              don't disable hyphenation at the end a linked text frame,
              if the next frame with the continuation of its text is there
              on the same spread, see at the end of text frame 2 on page 2
              (left page) and its continuation, text frame 3 on page 3 (right
              page of the same spread);
        
            – tdf165354_frames_on_right_pages_no_hyphenation.fodt:
              disable hyphenation, if the next text frame is there
              in a different spread (i.e. a different right page here);
        
        Follow-up to commit 698b38a18f5f70fd8d50968bc50951aba7085175
        "tdf#165354 sw cui: implement HyphenationKeepLine – part 3",
        commit f8b9cd8fd13897094a014ad06df406f0c78adc62
        "tdf#165354 sw xmloff: implement HyphenationKeepLine – part 2"
        and commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320
        "tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1".
        
        Change-Id: I8f0b879cbac30b7972ee27e473d492d8964b1090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182549
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-03-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5137fcc47f8e40dcba991db1f57dc1b395bbf970]

        tdf#165504 restore SdrPage::GetLayoutName virtual
        
        revert
        
        commit 235c230cd348600ce7385cc580c45a7be3572704
        CommitDate: Tue Oct 22 09:17:02 2024 +0200
        
            We don't need a virtual here
        
        and
        
        commit 960db01dbfe2f916b91782da03532fae1f836445
        CommitDate: Sat Dec 28 22:13:40 2024 +0100
        
            Resolves: tdf#164463 we need to pass a copy of the LayoutName
        
        Change-Id: Iecc486eca72e4d752527e77a9817dc4bed663cc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182445
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-05  Karthik  <me@karthikreddy.org>  [9a1be61b2f4e07d18da603bbfc9cd8cd31a147ed]

        tdf#158798 Nomenclature: "Arrange" commands not homogeneous in UI
        
        Change-Id: I1546ab1adf92ac42c68820bc614b5c3eae9c0858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182506
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-03-05  Oliver Specht  <oliver.specht@cib.de>  [0a31206b38f4a116ee1642ca9d29e6bd33391785]

        tdf#165596 Fix format paintbrush in Impress with lists
        
        Follow-up to dbb05dc818afb08b3e05ac62bd92389a5cf90fa7 to copy
        paragraph attributes from the source also if no selection is
        set.
        
        Change-Id: I05bea3fcaf8cf7a9c7ed341d2a7171d3f8a28131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180277
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3bef4ab04fed9842bd978a3b26cf7e7986a6e56f]

        Fix typos
        
        Change-Id: If791f4f1729c272ae9925561c68d11c08d72a362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182489
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-05  Michael Stahl  <michael.stahl@allotropia.de>  [e5dbde2aaba22f906fbf6a3d74a2dd4b16fc49df]

        tdf#165586 sw: fix accessibility sidebar with gtk3
        
        No issues are shown.
        
        (regression from commit fe8ef5ec0777e2edcddbaf1ed03280fbac05f67d)
        
        Change-Id: Ic9d6a9f64613f2f5d50a8acdb4b460f3567380b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182542
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [62f605e2a7508dcea2cc85cd47a05861cec6e800]

        jsdialogs: use frozen:: map for ui file lookup
        
        - less string comparison
        - more compact code
        - less duplication
        
        Change-Id: I6325cf59b1c8ecf04f3dd89bf454ab15542311c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182538
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [e979ec28042466f5bf071d7717a68165064f84fc]

        jsdialog: make executor more readable
        
        - no functional change
        - move executor to separate functions
        - make factory just for decision making which function to use
        - we need to use some functions for many types
        
        Change-Id: I5b54e90a6feb86bcda97d37c4cfff36a371efb5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180540
        (cherry picked from commit 7d23b904222ebe82b72dc919bf1aada2d55b35cc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182514
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-03-05  Miklos Vajna  <vmiklos@collabora.com>  [bc2d1922e26bcf4e243150c3d439226743c6c2ba]

        cool#11254 desktop lok: avoid invalidations if no tiles are sent
        
        If we have not rendered any tiles, then we should not need to emit
        invalidations. To generalize that, for each view:
        - when there is a clean-start or an EMPTY invalidation: reset a bbox of
          all tiles rendered
        - whenever we render a new tile we should grow the bbox
        - whenever we get an invalidate we should crop it against the bbox
        
        This has to be per-view: view1 may have a different view render state
        (e.g. spellcheck on) vs view2, so render in view1 should not influance
        invalidations in view2. COOL has a concept of "canonical view ids" (a
        group of views with the same render state), but that's not a problem for
        us, as long as we always render on the same single view for the group,
        the consistency is maintained.
        
        For Calc we also have multiple parts, and Impress additionally have part
        modes; the bbox should not be shared for these inside a single view.
        Solve this by using a "part -> mode -> bbox" map of maps.
        
        This then requires updating DesktopLOKTest::testBinaryCallback() in
        CppunitTest_desktop_lib, because now some invalidates will be only
        emitted if there was a paint before.
        
        Change-Id: I5b18330ce56a0200a493d30ad51524bb46e1de02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182543
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [591d57a21e0f1b4641095d4fcd66c44320d272ed]

        fix dodgy lifecycle in OOoMountOperation
        
        We fix/improve 3 things here
        (1) Holding a pointer to something that might be on the stack seems dodgy.
        I traced the calls back a few levels and ended up with lots of lots of
        call sites, with no guarantee this pointer is safe to hold for any
        length of time.
        
        (2) we already have a unique_ptr in this structure, but we are not
        properly constructing it.
        
        (3) once we fix (1) and (2) by calling the constructor/destructor
        explicitly, we can simply the password/username field handling.
        
        This code has been here since:
        
            commit 065b374d695f5208c6dcdad8ead3f1ff6223036f
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Wed May 14 13:49:20 2008 +0000
            INTEGRATION: CWS ucpgio1 (1.1.2); FILE ADDED
            2008/04/30 16:35:19 cmc 1.1.2.1: #i88090# add gio content provider
        
        Change-Id: I3ffcf30fbf66c855cedc4a3a99985bc6ee42faa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182483
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b3da13029312f9e921f213bef9ef5aa51eb7946]

        improve type-safety in FirebirdDriver
        
        Change-Id: I110d7d2c10d5855b6486d84763b7e963de1617f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e031fc7d6f039d03b537c2e4f90b6de1fde13f5]

        improve type-safety in dbaccess::OConnection
        
        Change-Id: I39ebd277431407b65c5c4a80698714399d39330f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182531
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [f6f1c7eb64a5b4ee44278e77e59305878979cfaa]

        tdf#165582: nMaxWidth may be negative
        
        Change-Id: Ibe4a57e8a098b219e2662d3ce8645d5caef98123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182536
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [50fe13355e3c7f0bdbba7e2deb9cb15d9c7eb925]

        jsdialogs: fix nested containters lookup
        
        Do not break the loop early if not found a widget.
        We need to go up sometimes. Fixes regression from
        commit	13af671fda1317175a93fd747e5455ce897ed167
        jsdialog: share code for widget registry
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I5516c0708452e95b2b6067e3a1fb99582b47dcf7
        (cherry picked from commit 90f836f5ef250c586fe9d58637ae15dee305edb7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182537
        Tested-by: Jenkins

2025-03-05  Noel Grandin  <noelgrandin@gmail.com>  [67df353008c0f240fa14d1e941cc7a1062335ec2]

        improve type-safety in ado::ODriver
        
        Change-Id: Ic93722a2e4b8348011316c2ee1ecd3addf6fdd2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182534
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [df7b3a53bd266d1c47da8490299f57a403b83860]

        remove unused typedef
        
        Change-Id: I6954a70e9ca3498ef38164a7415e19ac3ade524a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [8056d28ee363918fe9a256635fc898df331c575e]

        improve type-safety in dbaccess::ORowSet
        
        Change-Id: I08ae1369a7b1e388bc6eeaed86587261ffb83943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  Miklos Vajna  <vmiklos@collabora.com>  [85fc28a4e55bb8dafd69a19dc5d21a76501446cb]

        cool#11226 sw per-view redline on: state for the per-view and per-doc commands
        
        The UI for recording is one toolbar button (toggle) with a dropdown that
        has 2 radio buttons. The expectation is that once the toggle is on, one
        of the radio buttons report enabled state. So this is a tri-state: the
        record status is off, per-view or per-doc on the UI. At a code level, we
        have a per-doc flag and we have a boolean in each view.
        
        The requirements:
        1) Compatibility: if the dropdown menu is not used, then clicking on the
           old toggle should enable recording for all views & once it's enabled
           (either per-view or per-doc), clicking on it should disable the
           recording.
        2) If recording is on, the exactly one of per-view or per-doc radio
           button in the submenu should report enabled status.
        This leads to a not entirely symmetric behavior if you compare the
        enable, status and disable parts of this commands, and this is wanted to
        result in the least amount of surprise.
        
        Fix the problem by:
        1) Enable: the toolbar button enables recording for all views (to stay
           compatible), the dropdown menu allows choosing between this view vs
           all views.
        2) Status: the toolbar button reports enabled status if recording is on
           for this view for any reason; the "this view" command reports enabled
           status if recording is on in this view but not in all views; the "all
           views" command reports enabled status if recording is on in this view
           and no other view has it disabled.
        3) Disable is almost the opposite of enabled, but the toolbar toggle can
           always disable recording, so a per-view -> off -> all-views
           transition is possible by clicking on the toggle twice.
        
        This required a single change to testTrackChangesPerViewEnableOne,
        because now going back to the no-record state is doable by clicking on
        the enabled toolbar button, i.e. by dispatching the .uno:TrackChanges
        command; dispatching .uno:TrackChangesInThisView always changes to the
        per-view recording.
        
        Change-Id: Iacc984f832b4c08e0e100a67774e1e559729d82a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182539
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3786da6ebe9da3d2b37ba2425bbfed57cfb7913f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 151e1105f7bd22de0681204f763a2a850df93589
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I821455583da340f88eabe725a40f509459b9ff4c
            
2025-03-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6686aa128eb22fefee660ca6913dec01a94741ca]

        Revert "Resolves tdf#165517 - Rename Preferences to Settings on macOS"
        
        This reverts commit 11ecd11abab2a5f9e4779b36ca14420c644f923b.
        
        Reason for revert: requires coordingation to also rename in help
        and I also personally would like to have a clear statement that shows that impact on guides, wikipages, forum-posts, etc has also been addressed.
        
        Change-Id: I26b77e54923e9f33867148b37b80cfae64cc7ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182528
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-03-05  Miklos Vajna  <vmiklos@collabora.com>  [368e2e445c1941d37697cee05a50a34150d18015]

        cool#11226 sw per-view redline on: allow both per-view and per-doc
        
        Have two windows for a document, record changes in one view, and be
        surprised that now this is not turned on in the other view since commit
        ae6d396552cd3cebd7fba4942e6ca2fd5de579af (cool#11226 sw per-view redline
        on: add view-aware getter, 2025-03-03).
        
        Adding the ability to record changes per-view is intentional, but it was
        not a deliberate choice to also remove the old per-document recording.
        
        Fix this by turning the "is recording on" UI into a tristate, so the
        user can enable recording for all document windows or just the current
        document window -- similar to how showing changes can be off, inline and
        there are also 2 more on-margin options.
        
        The state of the new UNO commands still has to be implemented.
        
        Change-Id: I1e5271d4cc8900a28c7a8da8d34e00fec9e2e1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182527
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [0ab812e3ea9c7a3d2fadc294a47ad06873abbdeb]

        lok: use .uno:SidebarDeck.StyleListDeck as shortcut
        
        EditStyle command was causing the sidebar to close in lok
        case and it was not possible to open it again.
        Let's use dedicated command for opening the sidebar deck
        with styles navigator.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Idf6bbfa8676127ef72699c68ed6a778881c07030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182442
        (cherry picked from commit 90a63a2325e45b435762570ac9aecd50fcb5b676)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182509
        Tested-by: Jenkins

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [3b8b8d6a6c0ea871b6beb4d056949bbd4503a33c]

        jsdialogs: warn if not used in lok
        
        - it will be easier to spot missing ui file
        - add ignore list to not spam
        
        Change-Id: I2aabadfd0fa04732e7a7346dbb082d4ca5f01a98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182453
        (cherry picked from commit 126fb266713cf6cdf4a5bfa49f927516ce8d5d15)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182508
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-03-05  Szymon Kłos  <szymon.klos@collabora.com>  [f3ef8a54ace48d15ea24b3b5df3f655cb57679f5]

        Improve UX of currency dropdown
        
        - single click activation
        - no additional ok button in the dropdown
        - no label
        
        It's not common that dropdown has to be confirmed using button
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ib5ad5509f99466710cd898bf0baedeac8fdb49ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182512
        Tested-by: Jenkins

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [3cb0678a9cac9a681903b5a082d1c5dd5f25f665]

        fix dodgy DrawController::fireChangeLayer code
        
        wow. just wow.
        
        So this "worked" previously by virture of the fact that we were storing
        a pointer to something on the stack, and it would have fired almost all
        of the time, so mostly the symptom would be unnecessary screen updates.
        
        Of course, sometimes, by accident, two things on the stack would end up
        in the same location and the firing would not happen, leading to a
        temporary screen glitch.
        
        Change-Id: Iea85520ce1a2f522a0d63a57fbd14017d1bb349c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d793d6453d61d81d35d37f359915b351e26d4d6]

        improve type safety in OEvoabDriver
        
        Change-Id: I9b65bdf5ffb4ffd52f2ec8f87eb999c767569948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [0405a139e3cffe8f60f1d6760baeff257a09512c]

        improve type safety in file::OFileDriver
        
        Change-Id: I2150fbd2c23b6bde08443f2eb6eabdcb269376fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-05  László Németh  <nemeth@numbertext.org>  [38a4d3f0b095f70deaf1c25617b5f8b378f31626]

        tdf#164823 sfx: fix order of sidebar hyphenation options
        
        Position of hyphenation toolbar and its label was the
        same, resulting platform-specific layout problem, e.g. on Windows.
        
        Follow-up to commit 98f7f540463c533da17d4e8595c091d9e98a6c83
        "tdf#162491 tdf#125032 add hyphenation settings to sidebar".
        
        Change-Id: I97a873fb6c19f283526ee67b89fe310ab9c62acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182486
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-03-05  László Németh  <nemeth@numbertext.org>  [fe502cd93b70c598fcf9196f7ec1d9169bfe522f]

        tdf#162840 sfx: fix layout of sidebar hyphenation options
        
        Row-spacing was too small on Windows user interface,
        resulting overlapping widget elements.
        
        Follow-up to commit 98f7f540463c533da17d4e8595c091d9e98a6c83
        "tdf#162491 tdf#125032 add hyphenation settings to sidebar".
        
        Change-Id: I055500cdcef39eef1ecc2fab35eb4cc8ef231992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182485
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-03-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ead9ac54676ed62530d1f9181a1a9227d18e6dd]

        Resolves: tdf#163570 escape dictionary name for ui
        
        so _ doesn't get seen as a ui code, keep the original and map it with
        the itemid and avoid pitfalls of what happens to end up in the label
        itself.
        
        Change-Id: I25376adb797c1719ac52a59a4596f1c16cc665dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182497
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-05  Heiko Tietze  <tietze.heiko@gmail.com>  [ffd552926b381591972d2db55c16e57569cde98a]

        Resolves tdf#151040 - Brand image misplaced in Start Center
        
        Change-Id: If2c4e0e5fa2e5be11bc82d41734c09bcdd3fe804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182463
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-05  Andras Timar  <andras.timar@collabora.com>  [88d509fa07def3980f473de21189d751707c3867]

        Remove obsolete Patch Creation Properties files
        
        Obsolete since:
        fcfb30e81af windows packaging: remove unused msp creation
        
        Change-Id: I4792775ae21068e616f3cae68a74204d52c9fcdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182501
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-03-05  Jonathan Clark  <jonathan@libreoffice.org>  [ef31a26abc5ff4851be5360fd8ecd325132c5592]

        tdf#165540 sw: Fix kashida insertion position data corruption
        
        This change greatly simplifies the Writer kashida justification
        implementation. As part of this change, a number of string index
        invalidation bugs have been fixed by virtue of the implementation no
        longer needing to store or reference those indices.
        
        Change-Id: Ibd96963c98cc74462ae55501c0a0a1b944d8bcc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182507
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-03-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [36a6bf8bd65e2ece92a4354e9f6d8e47e0f03d84]

        make consistent parameter names and descriptions of Calc functions
        
        that have been added recently
        
        Change-Id: I29e2878ef268126dd97ed31381ecaa328a9001c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182499
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-03-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [eb3ec34e5f4f0f3a9ba14f8fd88ebe0be41368f1]

        fix help tooltip for margin in footer
        
        Change-Id: Ifa4dacb702e403eced86c07d701f261bac0e57c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182500
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-03-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [6d024852a57ab795ef776f769280b8396402893f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e60ca6e6dac497137d8176607151bbff55760f61
          - adjust labels used in Appearance options page
            
            Change-Id: I3f4584fdc6333d59c4928efaa9d759c492a71f09
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/182498
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2025-03-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7cd18962d32d7536b2947483f541971a3475ffd5]

        update credits
        
        Change-Id: I5b99f9280aecd423968cab731892e8f1eea3e9f7

2025-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [057df5db591f963bc593f4d7dbddf7cc84e1ae99]

        iconchoicectrl a11y: Reuse parent handling + disposing from base class
        
        Drop the custom handling for the accessible parent
        from AccessibleIconChoiceCtrl, as the base class
        VCLXAccessibleComponent already has an implementation
        for vcl::Window subclasses that effectively does the same.
        
        Drop AccessibleIconChoiceCtrl::disposing, which also
        means that the base class one is used now, which
        so far wasn't called from the override for no apparent
        reason.
        
        Change-Id: Iec4b297462fb8265e75fd9f298ba0838c23053db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182491
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [817e0a27a734c98ea3082b1e7051cf7a02105a89]

        vcl a11y: Call AccessibleIconChoiceCtrl ctor directly
        
        ... and no longer use AccessibleFactory::createAccessibleIconChoiceCtrl, which
        was used in the past to break a dependency cycle between vcl and the
        (no longer existing) accessibility module.
        
        Change-Id: I0c7a7bb621b391ec0840abad0ee86b07696ee763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182490
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-04  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [dedaef9565dba5856ef68a49c634b614cb3ef24d]

        tdf#165437: regression: CairoSDPR: Exclude SDPR when mirrored
        
        This one is similar to tdf#165061 due to not using CairoSDPR when
        RTL is used, but it seems that not all cases of 'mirroring' are
        covered with using IsRTLEnabled. It also needs to check
        HasMirroredGraphics, so I added that.
        
        Change-Id: Ia86add7841e69657d8f64f7001eea4a57e927043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182481
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-03-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ae6f696b0e71d0ad453dc3c4dea48d7c60c4e0b6]

        tdf#93357 - Display first page as thumbnail in the recent documents view
        
        Display first page as thumbnail in the recent documents view for draw
        and impress documents.
        
        Change-Id: Ia69b338b68d5b2a47349b113d4f4f47ee1f1b08f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182479
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-03-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [68722fce71ac5bee808bebb76caf32128d6e9ca0]

        tdf#158794: sw: Add UItest
        
        Change-Id: I6b7fd51861bd03af993a68d04886bb0c10705e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182471
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ac5c93bfbefb18130eb0f1371fdacca0909cc16a]

        Add extra font config options for emscripten wasm build
        
        In case of wasm build we can have missing default font config
        options compared to Linux or other builds. These options are
        necessary for the FontConfig lib.
        
        Change-Id: I3e04847f28bdbd28c767793bf5cb4061b7b3a251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182462
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4a878c726b2e4a92cc6946e9b9d474505e2f9f2]

        improve type safety in mysqlc::MysqlCDriver
        
        Change-Id: I3050e0e3b649a0e093750d9e51019d5e0b2cc730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182476
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab9ba059a6a990dc581520387f0cde6e406a8783]

        improve type safety in mysqlc::OConnection
        
        Change-Id: Id41f78a67c9634ddfcfd0435357bb9a754a150f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [773fa222432cd8191d3155cfa7608f7ba516f947]

        improve type safety in mysqlc::OPreparedResultSet
        
        Change-Id: If0a427ff5c02ed15f62608603e641a8f6dbe5755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182474
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [99f20f69dd9a5cdcee460135a3c8a2e0b5ba0d14]

        improve type safety in mysqlc::OResultSet
        
        Change-Id: I44e7aafd7b9e7d426d511aab72ccd5f818305133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [90351ca6b1d6483590878bdc55be2b446019ee7c]

        ODatabaseMetaDataResultSet::m_aStatement is unused
        
        Change-Id: If8ce23440a5046c8d6b16558ac7ecd885afc0305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182465
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [52249ad398d64fb982281655edb3b83d1aa4eaed]

        improve type safety in hsqldb::ODriverDelegator
        
        we can use type-safe WeakReference wrappers classes. Also use
        a custom struct instead of std::pair<std::pair<
        
        Change-Id: Idc984e316dd063a3656688872bf7b40ca8733b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Noel Grandin  <noelgrandin@gmail.com>  [ee66e1112de4dc058ebdbb920beea7f8b85f5900]

        more type-safety in odbc::ODBCDriver
        
        Change-Id: I5db758cd282299ccd15872195a292224827d0c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182468
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-04  Noel Grandin  <noelgrandin@gmail.com>  [8489375bdc42b9090fb7991ac5a2f1c7b6e2ff76]

        ado::ODatabaseMetaDataResultSet::m_aStatement is unused
        
        Change-Id: I5185f4ddeaa041013af43006c927aa2709fb2ac4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182467
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e10493a24835afecbc3aa58e4c327c064abd3d02]

        improve type safety in mysql::ODriverDelegator
        
        we can use type-safe WeakReference wrappers classes. Also use
        a custom struct instead of std::pair<std::pair<
        
        Change-Id: I0debaf3b0a77e92545c39aa755ca2477cc1e8c26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Christopher Sherlock  <chris.sherlock79@gmail.com>  [e262ddf89c21966c56fe41483045b40ee461c80a]

        vcl: flatten ImplFindPartRect()
        
        Change-Id: I6d6c08355c675f29471e2fcd835ccee3d7cffc48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179368
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d77471b670e050f99e7f8fd442d7d4ee6b84a6e3]

        cool#10967: LOK Impress: Invalidate tiles on switching the CenterPane
        
        and not at DrawDocShell::Connect which happens on switching view which
        happens frequently with multiple users which creates a storm of
        invalidations.
        
         #0  SfxViewShell::libreOfficeKitViewInvalidateTilesCallback (this=0x3301ce40, pRect=0x0, nPart=0, nMode=0) at sfx2/source/view/viewsh.cxx:3331
         #1  0x00007fd0f1bae136 in sd::DrawDocShell::Connect (this=0x352e3e50, pViewSh=0x3700bed0) at sd/source/ui/docshell/docshel2.cxx:159
         #2  0x00007fd0f2168cae in sd::ViewShell::Activate (this=0x3700bed0, bIsMDIActivate=true) at sd/source/ui/view/viewshel.cxx:350
         #3  0x00007fd0f202c41b in sd::DrawViewShell::Activate (this=0x3700bed0, bIsMDIActivate=true) at sd/source/ui/view/drviews1.cxx:84
         #4  0x00007fd115efb7d6 in SfxShell::DoActivate_Impl (this=0x3700bed0, pFrame=0x37066300, bMDI=true) at sfx2/source/control/shell.cxx:326
         #5  0x00007fd115ebed5e in SfxDispatcher::DoActivate_Impl (this=0x370481c0, bMDI=true) at sfx2/source/control/dispatch.cxx:600
         #6  0x00007fd1163b9f00 in SfxViewFrame::DoActivate (this=0x37066300, bUI=true) at sfx2/source/view/viewfrm.cxx:1196
         #7  0x00007fd115da26b6 in SfxApplication::SetViewFrame_Impl (this=0x318c3ba0, pFrame=0x37066300) at sfx2/source/appl/app.cxx:260
         #8  0x00007fd1163c8126 in SfxViewFrame::SetViewFrame (pFrame=0x37066300) at sfx2/source/view/viewfrm.cxx:3652
         #9  0x00007fd1163c02ba in SfxViewFrame::MakeActive_Impl (this=0x37066300, bGrabFocus=false) at sfx2/source/view/viewfrm.cxx:2252
         #10 0x00007fd116374bba in SfxLokHelper::setView (nId=5) at sfx2/source/view/lokhelper.cxx:221
         #11 0x00007fd1164a59ce in doc_setView (nId=5) at desktop/source/lib/init.cxx:6918
        
        Change-Id: Id4883d99009544cee8a239471f3ae65eb3646306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182443
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 22307f05056aefebc4ba5d0ab60445b30adfc00c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182464
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-04  Noel Grandin  <noelgrandin@gmail.com>  [5f064fe5e8f7ab45965dc282cbb0267c07f78769]

        m_aStatement in ODatabaseMetaDataResultSet is unused
        
        Change-Id: If7cc484a3160dbb1422547d0c88cbf81f4b5aeb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7c17d4a993b746ae92ac1307790f645835e84aa]

        improve type-safety in dbaccess OStatementBase
        
        we can use unotools::WeakReference instead of untyped
        WeakReferenceHelper.
        
        Also rename the field to something more obvious
        
        Change-Id: Iff674893ec0c3144830c46d1745c920f910d6067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [541eacf801b111594b380afd27aa33ee7648e708]

        Reinstate the JDK_SECURITYMANAGER_DISALLOWED_FOR_BUILD workaround
        
        ...for Java versions < 24.  As discussed in the comments starting at
        <https://gerrit.libreoffice.org/c/core/+/132558/4#message-4fd391160f395455362289909dadb7d2663f4ff2>
        "Allow building against JDK 18", the previous
        35d9ec3e596bce2ea35ed3b6418e0ba672a61443 "Remove the
        JDK_SECURITYMANAGER_DISALLOWED_FOR_BUILD workaround" had started to resurface
        the old "exception and build failure with JDK 21/22/23 on macOS Sequoia."
        
        So keep the workaround for Java versions < 24, and hope that we won't run into
        scenarios where we combine a Java version >= 24 (for which the workaround would
        cause the new build failure) with an Ant version that requires the workaround.
        
        Change-Id: Ib886f68d5c17ace2384f22672dcc2d0478830228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182454
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-04  Taichi Haradaguchi  <20001722@protonmail.com>  [bb11c36d81b7c5a1440129f988bd6ed0dd3d2856]

        cui: include Version.h instead of ZXVersion.h
        
        ZXVersion.h has been deprecated since 2.3.0,[1]
        so include Version.h instead if possible.
        
        [1] "cmake: replace -DZXING_BUILD_READER with #define in Version.h"
        https://github.com/zxing-cpp/zxing-cpp/commit/a054439f12457f800961f80495a041fe2ee753bd
        
        Change-Id: I61749b16f52443eb705937e676d6ccc529cfd322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179812
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@protonmail.com>

2025-03-04  Heiko Tietze  <tietze.heiko@gmail.com>  [11ecd11abab2a5f9e4779b36ca14420c644f923b]

        Resolves tdf#165517 - Rename Preferences to Settings on macOS
        
        Change-Id: I89926ce1021876038315b27f3b1d4e3c2db1b4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182450
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c806a668530f25730717a12e6f97972f69d9c09]

        Fix typo
        
        Change-Id: I9edf7cb827c2c62a94fc4e8e396a0885d2c955d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182403
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d11b4552f56477fb93033580b9489ba753cea504]

        Fix typo
        
        Change-Id: Ida61cba76576166be486c7f0fcc11f37b144b789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182390
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [002c9884ddb9053b51c09f9882cbe1a1cec96630]

        Fix typo
        
        Change-Id: I5102c2d0ab5c223895b45c68c77d7024b5a51ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182405
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [90741a80c04cddf5c06d97c47c796c2f28d124f8]

        Fix typo
        
        Change-Id: I784fae4569d504893277d7985f09248764ce75b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182404
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-03-04  László Németh  <nemeth@numbertext.org>  [698b38a18f5f70fd8d50968bc50951aba7085175]

        tdf#165354 sw cui: implement HyphenationKeepLine – part 3
        
        Add check box "Move Line" to the Hyphenate Across section
        of the Text Flow paragraph settings.
        
        Note: this is the MSO interoperability option of MS Word
        Layout Option "Use Word 2013 rules for hyphenation between
        pages and columns".
        
        "Move Line" is sensitive only if Hyphenate Across Column,
        Page or Spread are disabled (MS Word Layout Option "Allow
        hyphenation between pages or columns").
        
        Default value of HyphenationKeepLine is true, i.e. if "Move
        Line" is disabled. Enabling Hyphenation Across Spread not only
        grays out "Move Line", but disables it, too, to force the default
        value, which may be better for interoperability and typography,
        too (see description of commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320).
        
        Follow-up to commit f8b9cd8fd13897094a014ad06df406f0c78adc62
        "tdf#165354 sw xmloff: implement HyphenationKeepLine – part 2"
        and commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320
        "tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1".
        
        Change-Id: Ibc4f3b904bfe1a676195d166a334910c12760ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182446
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [5ef30632ede4258f0c45194259567849cc172dab]

        tdf#163989 a11y: Introduce Window::GetAccessibleParent
        
        Add new method Window::GetAccessibleParent that for now
        uses the existing logic duplicated in multiple places
        to get the accessible for the window returned by
        `Window::GetAccessibleParentWindow()`.
        Deduplicate code by using the newly introduced method
        instead.
        
        No change in behavior intended by this change, but this
        also prepares for an upcoming commit that will allow
        explicitly setting a parent.
        
        Change-Id: I0ac5e370d34994c1ede864204d4d41019f7b9336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182441
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [1622d672b8cc721d5f9917931f6d8d999f218f7a]

        tdf#55425:sdext,pdfimport: Document the new protocol
        
        Document the new protocol between the two processes.
        
        Change-Id: I3873e78a1832d9125d80c5a3238efc20d45918f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181751
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [4aba4d73969dccc983dee52581faecef78ddea2b]

        tdf#55425:sdext,pdfimport: Add a test
        
        Add a test for opening a PDF2.0 encrypted file.
        It was generated by exporting it from LO with the type set as PDF2.0
        and specifying a password.
        
        Change-Id: I0c23768de6c8a931acfe8b89ca550b406ec8aeb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181750
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [2bbe15a2cea20d2dfb9346992a9bf8ff39b4d42c]

        tdf#55425 sdext,pdfimport: Replace checkEncryption
        
        Replace the old checkEncryption by just passing it to the poppler
        wrapper and seeing if it likes it.
        
        Change-Id: I702495f4fc4a7f296bd90357d2bd9dc930705f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181742
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [779a77d1a9a467230dd1ae98b89ea76b02b22c42]

        tdf#55425 sdext,pdfimport: Add a command loop to the poppler wrapper
        
        At the moment the poppler wrapper just takes in a password and
        gives a status followed by the actual data.
        
        Make this a more controlled process where the LO side can
        send commands.
        
        The commands we have are:
        
         Pmypassword
             Set the password to be used for future opening of the PDF
         O
             Open the PDF document using the password; this returns
             the #OPEN or #ERROR response.
         G
             Render the previously opened PDF to commands/data
         E
             Quit without rendering.
        
        Change-Id: Id81a0ceb024d75abfda8d908e3228b7d0d903b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181741
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [a77caf540cf4a0b97974da02362153021996d9e4]

        tdf#55425 sdext,pdfimport: Add a status string for opening the PDF
        
        Make the poppler process start with an explicit status line saying
        if it managed to open the PDF or if it hit an encryption problem.
        
        The current lines are:
          #OPEN
             It opened OK
          #ERROR:1:
             Or other number, meaning an error (see poppler for error codes)
          #ERROR:2:ENCRYTPTED
             We failed to open the document because it was encrypted.
             Don't rely on the number, look for the 'ENCRYPTED' string.
        
        Change-Id: I57ca014233ad0ca4b478108033055bc991465011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181740
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-03-04  Dr. David Alan Gilbert  <dave@treblig.org>  [99d7822b3932a9c74b8fc33bbbce504c33f3ee7e]

        tdf#55425 sdext,pdfimport: wrapper: Split out line read
        
        Split out the line read into a seperate method since we'll
        need it in a later patch,
        Note, it's reading on a pipe.
        
        Change-Id: Ie65246b01b4a898f8b9fe3ee6077e5ac05b52742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181739
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-03-03  Simon Chenery  <simon_chenery@yahoo.com>  [7e4acdc2f70d46b73424e38e876d559fd6ab7a6d]

        tdf#145614 Convert #define MAX_HEADER_LENGTH to constexpr
        
        Change-Id: Ie61197b62e8cc7d329da04fdf9ed8d2f1c190854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181920
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb8d18eb6f97832fb69a37135e32f78112cd8e7e]

        use more concrete UNO classes in framework
        
        Change-Id: I7653de4d2c0a4d2960715c6cbab69c70eb892336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182435
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9865922ff1cee541cc7037c55bcffaf3010f9ecc]

        use more concrete UNO classes in linguistic
        
        Change-Id: Iae9dc3c7dadc21e3d92192a197f42c55e590fab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182434
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [835fcbca7ac1d17ac586ce9f1519e1da67edaef8]

        tdf#165115: odf_export2: Add unittest
        
        Change-Id: I0cf346e1551d13595ee0c9c77710661bd893a937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182432
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-03-03  László Németh  <nemeth@numbertext.org>  [434af9dea64f95e1d5f93a5563106b9124bb17af]

        tdf#164905 tdf#164499 sw smart justify: fix overlapping text in ToC
        
        Unnecessary calculation with the width of the glue portions resulted
        bad ToC, i.e. text lines with tabulators got overlapping text.
        
        Regression from commit 857dd6000c877f2c6d8bb73806a8557fa0baea73
        "tdf#161810 sw smart justify: fix overhanging lines containing tabs".
        
        Revert only the calculation, but not the unit test, which is still
        correct, according to commit ed7fbfce0b434f7d2a5542483d2838af51958e34
        "tdf#164499 sw smart justify: disable in tabulated lines to fix ToC".
        
        Change-Id: I3fe6d0d56ea8593ddee23d3c4063024762b65bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182433
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-03-03  Miklos Vajna  <vmiklos@collabora.com>  [745256f37973d89ea068acd831eba8054a81b93b]

        Related: cool#11226 sw per-view redline on: fix ratio buttons of is-show
        
        Redline recording is now per-view, but it would be even better to have
        UI where the user can decide how to record (don't record, record
        per-view, record in all views).
        
        While looking for an example to follow, I noticed that the redline show
        UI is similar, but the radio buttons always have a false state. Turns
        out simily the command state wasn't implemented in commit
        6aeeef8807fef36295b65d0a300a21466bfbeda0 (tdf#116757 sw ChangesInMargin:
        add "Show Insertions in Margin", 2021-01-20), add this.
        
        Change-Id: Ie50c13c45c4e53fbfbb6befa36b6a29be084f2d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182427
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-03-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c60ca3582598c7b9b9b33c288edbd76207f5b14d]

        tdf#134791 Clamp options dialog height to 80% of screen size
        
        to make buttons accessible on smaller screens.
        
        Change-Id: If43edfeb97ad710c69c0ea8780a9af6ee336a5c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182341
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [2df7a51f6e7724a749823435dcd00cc0c07e1a96]

        expand the ObjectType typedef
        
        in preparation for making some of the code more typesafe
        
        Change-Id: I7c8a4b30cd1144feaaa2e31fce67cd6545065a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182425
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-03  László Németh  <nemeth@numbertext.org>  [f8b9cd8fd13897094a014ad06df406f0c78adc62]

        tdf#165354 sw xmloff: implement HyphenationKeepLine – part 2
        
        Add loext:hyphenation-keep-line to the ODF export/import
        to support HyphenationKeepLine, i.e. MS DOCX compatibility
        option useWord2013TrackBottomHyphenation=false, where not
        the full hyphenated line, but only the hyphenated word
        is shifted to the next text block.
        
        Add unit tests for hyphenation-keep-type="page" and "spread"
        with hyphenation-keep-line="true" support.
        
        Follow-up to commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320
        "tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1".
        
        Fix unit test testTdf132599_spread, which loaded tdf132599_page.fodt
        instead of tdf132599_spread.fodt (duplicating testTdf132599_page).
        
        Restore unit test testTdf160518_auto_in_text_body_style, which was
        removed by accident in commit 3e02ffb76c484a05cdc140d8a10bc3d993fe8320.
        
        Silence the linguistic warning of HyphKeepLine, according to the
        commit d25de4a04671c2f380fc86a58259b073c49dfe19
        "silence unknown property 'HyphNoLastWord'... etc warnings".
        
        Change-Id: Ibb9643f8e20ee2a1456c4d62b901e4c66b57c341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182424
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-03-03  bruh  <randomforest33@gmail.com>  [7668d76e7a7d10a94c6122d7ff7932ab4cb1710a]

        tdf#155050 Replaces the Bibliography entries with Citation
        
        The patch replaces Bibliography entries in Tables Of Contents and Index and bibliography dialog box with Citation.
        
        Left some of the entries in sw/uiconfig/swriter/ui/bibliographyentry.ui and sw/uiconfig/swriter/ui/createauthorentry.ui unchanged as per the discussion on the bug page, where it was mentioned not to modify them.
        
        Change-Id: I34c0051806a799b50d546841960c5d5a04b60196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181224
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-03-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8f8e84eddb3b1a24d3fc670155832618dfcbcd09]

        Missing test dependency
        
        > [_RUN_____] CRMDBTest::testCRMDatabase
        [...]
        > java.lang.ClassNotFoundException: org.hsqldb.jdbcDriver
        > 	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:349)
        > 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:557)
        > 	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:490)
        > unknown:0:CRMDBTest::testCRMDatabase
        > An uncaught UNO exception
        > - com.sun.star.sdbc.SQLException: {Message: "The driver class “org.hsqldb.jdbcDriver” could not be loaded.The additional driver class path is “vnd.sun.star.expand:$LO_JAVA_DIR/hsqldb.jar vnd.sun.star.expand:$LO_JAVA_DIR/sdbc_hsqldb.jar”. at /home/sberg/lo/core/connectivity/source/drivers/jdbc/JConnection.cxx:674", Context: @0x7b373fdfdb70, SQLState: "", ErrorCode: 1000, NextException: com.sun.star.sdbc.SQLException: {Message: "org.hsqldb.jdbcDriver at /home/sberg/lo/core/connectivity/source/drivers/jdbc/Object.cxx:185", Context: @0x7b373fd19b70, SQLState: "", ErrorCode: -1, NextException: void: void}}
        
        Change-Id: I4aeadfcf2a5c82eea4bf1fd646bceba4e8da5f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182422
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-03-03  Michael Stahl  <michael.stahl@allotropia.de>  [641cb041a55aae30c629a80e134efc493027f0c4]

        tdf#165351 sw: fix crash after Undo of inserting table row...
        
        ... if an existing row of the table has a drawing object anchored to it
        as character, and the table is in a fly frame.
        
        The problem is that the SwTextFrame inside the table cell doesn't have
        the mbInfFly flag set, because SetInfFlags() was called too early, when
        the frame was attached to its SwCellFrame but the SwCellFrame didn't
        have an upper yet:
        
         0  SwFrame::SetInfFlags () at sw/source/core/layout/findfrm.cxx:1600
         1  SwFrame::IsInSct () at sw/source/core/inc/frame.hxx:1009
         2  SwFrame::FindSctFrame () at sw/source/core/inc/frame.hxx:1178
         3  SwFrame::IsHiddenNow () at sw/source/core/layout/trvlfrm.cxx:1734
         4  SwTextFrame::IsHiddenNowImpl () at sw/source/core/text/txtfrm.cxx:1514
         5  SwTextFrame::Prepare (ePrep=PrepareHint::FlyFrameAttributesChanged) at sw/source/core/text/txtfrm.cxx:3031
         6  SwAnchoredDrawObject::InvalidateObjPos () at sw/source/core/layout/anchoreddrawobject.cxx:595
         7  SwFrame::AppendDrawObj () at sw/source/core/layout/fly.cxx:2803
         8  AppendObj () at sw/source/core/layout/frmtool.cxx:1079
         9  AppendObjsOfNode () at sw/source/core/layout/frmtool.cxx:1277
         10 AppendObjs () at sw/source/core/layout/frmtool.cxx:1330
         11 InsertCnt_() at sw/source/core/layout/frmtool.cxx:1666
         12 SwCellFrame::SwCellFrame () at sw/source/core/layout/tabfrm.cxx:5729
         13 SwRowFrame::SwRowFrame () at sw/source/core/layout/tabfrm.cxx:4627
         14 lcl_InsertRow () at sw/source/core/frmedt/tblsel.cxx:2053
         15 FndBox_::MakeFrames () at sw/source/core/frmedt/tblsel.cxx:2402
         16 SaveTable::CreateNew () at sw/source/core/undo/untbl.cxx:1100
         17 SwUndoTableNdsChg::UndoImpl () at sw/source/core/undo/untbl.cxx:1783
        
        Reset flags in InsertCnt_().
        
        (regression from commit 0a3f5169acc6708c352cad0fa07fdb4af8c8b2dd)
        
        Change-Id: I048196278b314ea516bd5a4877b3e86f696dfce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182367
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-03-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5c838df65338dbb38fea1e3b68e55c92200c7468]

        tdf#165339 - Data Provider - tweak wording and more
        
        + Moved data format org.libreoffice.calc.* to dataproviderdlg.ui
           as ID of provider_lst widget
        + Add strings CSV,HTML,XML,SQL to list and set non translatable
        + Adjust dialog labels according to UX advise
        + Adjust transformation names in list
        + Adjust individual transformation dialogs to same names (visible in
          tranformation set box).
        + Deleted methods related to org.libreoffice.calc.* in cxx controller
        + and in header hxx file.
        
        Change-Id: I960dd267d40f81f203bb6cc2a3979a69edd72108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182338
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-03-03  Michael Stahl  <michael.stahl@allotropia.de>  [0be897258beadc77ad2fa129f12ccbdb5c956e93]

        tdf#165115 sfx2: fix storing wholesome encrypted ODF templates
        
        Oops, hard-coded SetupStorage(bTemplate=false) which caused wrong
        MediaType on the root folder and:
        
          ManifestExport.cxx:131: ManifestExport::ManifestExport(): Assertion `aDocMediaType.isEmpty() || aDocMediaType == aMediaType' failed.
        
        (regression from commit 3b347664b26d58d44f685a607a5e6d10dff89cd4)
        
        Change-Id: Ia65ba39e8a853f47d0d58acdca90fd6e12b7cd7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182372
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e8ddfc3d4af0a73e819adb90b57746e3a015f17]

        use more conrete UNO classes in vcl
        
        Change-Id: I1caceef305fb88a25a505633c7fa31fd70b7e960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182417
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-03  Miklos Vajna  <vmiklos@collabora.com>  [ae6d396552cd3cebd7fba4942e6ca2fd5de579af]

        cool#11226 sw per-view redline on: add view-aware getter
        
        Have 2 views, view 1 enables tracked changes recording by dispatching
        .uno:TrackChanges, view 2 does not. The result is that this gets enabled
        in both views, including the toolbar button state, insertion recording,
        deletion recording.
        
        The toolbar button state behavior was introduced in commit
        d890ec2f130188af9d998abf5968f06e7218b7a4 (tdf#101592 sw: track changes
        state is doc-specific, not view-specific, 2016-08-19), but there the
        motivation was that *if* the setting is per-doc, then all views should
        show the same toolbar button state.
        
        Fix the problem by:
        - improving SwDocShell::IsChangeRecording(), so it takes a hitn on what
          is the relevant view; the relevant view is the view where the state is
          updated, it may not be the current view
        - using sw::DocumentRedlineManager::GetRedlineFlags() everywhere, so
          we'll have a central points for reading these flags
        - extending sw::DocumentRedlineManager::GetRedlineFlags() to try to take
          the "is recording" setting from the current view (if there is such a
          view)
        - improving SwEditShell::GetRedlineFlags() to pass itself to
          sw::DocumentRedlineManager::GetRedlineFlags(), so the entire chain of
          calls for the toolbar button work with the correct view
        
        Also add tests to make sure all of uno command state, insert & delete
        works. Drop the desktop/ test that is now redundant -- and testing
        per-view callbacks there is harder than in sw/.
        
        Change-Id: I6dbd826ea27facb9f8d06029efe805c637b7e080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182423
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-03  Miklos Vajna  <vmiklos@collabora.com>  [509b6d19d4b4310bad80d2a91ddd1429ccabc51f]

        svx: prefix members of GalleryThemeEntry
        
         See tdf#94879 for motivation.
        
        Change-Id: I6a551ab7cb6d6a0595d93703d6a99e5d9e6b2abc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182416
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-03-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [35d9ec3e596bce2ea35ed3b6418e0ba672a61443]

        Remove the JDK_SECURITYMANAGER_DISALLOWED_FOR_BUILD workaround
        
        ...that had been introduced with 19de5d97efbb80e9767bc6b873bcc2c263a721de "Allow
        building against JDK 18" to work around odd failures of ExternalProject_hsqldb
        with whatever versions of JDK 18 and Ant I had been using at that time.
        
        However, with java-latest-openjdk-24.0.0.0.36-1.rolling.fc41.x86_64 that
        workaround now started to make ExternalProject_hsqldb fail for me with
        
        > ERROR: JVMTI: 112(JVMTI_ERROR_WRONG_PHASE): Cannot get thread info
        > ERROR: JVMTI: 112(JVMTI_ERROR_WRONG_PHASE): jvmtiEnv::GetLoadedClasses()
        > Error occurred during initialization of VM
        > java.lang.Error: A command line option has attempted to allow or enable the Security Manager. Enabling a Security Manager is not supported.
        > 	at java.lang.System.initPhase3(java.base@24/System.java:1947)
        
        apparently because of <https://openjdk.org/projects/jdk/24/>'s
        <https://openjdk.org/jeps/486> "JEP 486: Permanently Disable the Security
        Manager".
        
        But with the ant-1.10.14-13.fc41.noarch I'm using now, neither
        java-21-openjdk-21.0.6.0.7-6.fc41 (I no longer have the problematic-back-then
        JDK 18) nor java-latest-openjdk-24.0.0.0.36-1.rolling.fc41.x86_64 appear to need
        that workaround anymore anyway (presumably because "an updated version of Apache
        Ant [has] become available", as discussed in the commit message of that
        19de5d97efbb80e9767bc6b873bcc2c263a721de).
        
        Change-Id: Id13b57559df486012c888247c96323716168c97d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182419
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-03-03  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [62a1377e8d15fcacb2e123ba88c0a86b2e20e050]

        tdf#86628 Fix image squishing on Reset Crop
        
        Call ZoomHdl in UncropHdl to recompute width and height, ensuring the
        correct scale.
        
        Change-Id: I35af48f5729d0a17a3c06f47efc133c9bab830cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181434
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-03-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [794e86b99dae26358b9837645a5db95073dfccd4]

        o3tl: Add concepts for 32/64 bit types, use in hash_combine
        
        This simplifies determining what the byte size of the template type
        is, so we can write a specific implementation for 32 and 64 bit
        seeds for hash_combine.
        
        Change-Id: Icd68e4618151957ecc00585dd521adf11fe3931a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182266
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-03-03  Aron Budea  <aron.budea@collabora.com>  [9d3fba976012b65e740c024e753f034600ce2852]

        tdf#165503 oox: save numerical date categories into numerical cache
        
        f547cf17a179ebd7de5c2b4dd2d00d0027a25429 switched
        saving date categories from text to numeric, but
        the values were still formatted text.
        Excel considered these files corrupted.
        
        Switch to saving actual numeric values.
        
        Change-Id: I1f77a87fd66d6f8fde4987f110e37ed55711bdf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182364
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2025-03-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [9b4dac8bf180f3fd5441b447a60439fb258854d4]

        Avoid short blinking of text when activating TextEdit
        
        In Presentation with title/Body with text directly activating
        one by clicking makes the other 'blink' briefly when it gets
        deactivated. All that has to do with OverlayManager, repaints
        and the text being 'hidden' (to not be shown twice during
        edit). That needs to be synchronized since OM refreshes using
        a timer and direct paint to the target, while repaint uses
        system's invalidate-and-paint-callback functionality. It
        has shown that the immediate flush of the OM that was used
        before is not needed anymore, so I removed that.
        Note that there is task tdf#102293 mentioned as reason for
        the flush, so I checked that the there mentioned triple/
        double-click on text does the right thing.
        
        Change-Id: Id9539129c5d6989959974befd15300abdfef3186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181904
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-03-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [897d70c1f710c88f9c321cf72af739b21de427ca]

        Remove OverlayManager::flush() mechanism
        
        This is a follow-up to 'Avoid short blinking of text
        when activating TextEdit' commit. The update using the
        timer works nowadays flawless, so no longer needed.
        I separated the two places in two commits because this
        one handles some places I do not know good enough to
        be completely sure, so it would be simpler to turn
        back in case of (unexpected) problems.
        
        Change-Id: I336515838949585b98101ff566e9137b898da82f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181906
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-03-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7c483a0d5287de5eb0face12d02673a50f656633]

        Avoid slight jumping of TextEdit on activation
        
        A PixelSnap was used before using GetOutputDevice() and
        LogicToPixel/PixelToLogic (what was incorrect, would need
        to take care of 1/2 pixel in logic for rounding). We do not
        need that anymore, in fact it leads to the text slightly
        'jumping' around by up to 1 pixel (of course).
        
        We paint text nowadays using decomposed TextPrimitives
        with sub-pixel precision and similar (using a shortcut)
        for text in TextEdit on the Overlay, also using sub-pixel
        precision. Just remove this to avoid Text being displayed
        different in TextEdit and EditView paint visualizations
        and assign given value to OutputArea unchanged.
        
        If this should cause problems somewhere (I do not think so,
        we try to paint text with Sub-Pixel quality now anyways)
        this can also be done in alternative ways and only for
        TextEdit on Overlay.
        
        Change-Id: If177ceec880a29a6d102ad4f0dddf891d95b69c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182094
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-03-02  Arnaud VERSINI  <arnaud.versini@pm.me>  [83579ee9f1312d71fb223fff2dee19c616fd87f2]

        package : reduce OUString allocation by using u16string_view
        
        Change-Id: I6c52fe7dbf3072132853ad820b5eba58beb6d76c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174149
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-03-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [a43320a3ad867d65a9d9c8b332abc4dad10b430e]

        vcl: make BitmapDarkenBlendFilter use BitmapFilter
        
        Change-Id: I2ec47793fa094e452f30f9628c121772db578656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173743
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-03-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [717a898b05dd1226254ee47b61ab354b348df198]

        Use officecfg instead of custom accessor methods
        
        Change-Id: I986981b835dd1ec14c7e345c9636bc05b05664bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182393
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-03-02  Michael Weghorn  <m.weghorn@posteo.de>  [7d467fab95e5814fb0cdc9a2d71af2c55fdd8d9b]

        tdf#130857 qt weld: Introduce QtInstanceScrollbar
        
        Add new class QtInstanceScrollbar as the weld::Scrollbar
        implementation using a native QScrollBar.
        
        QtInstanceScrolledWindow already contains similar logic
        to what is needed for some of the methods.
        
        Extend QtBuilder to create a QScrollBar for "GtkScrollbar"
        objects.
        
        Change-Id: Iccb08659852f216df143e2d4293eead2bc9215f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182401
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-02  Michael Weghorn  <m.weghorn@posteo.de>  [c4dbac16a1a241c60f8f72be57191efe65ebebef]

        weld::Scrollbar: Make clear that signal is about value change
        
        A GtkAdjustment [1] doesn't only have a current value, but
        also lower + upper bounds,...
        
        Rename weld::Scrollbar::signal_adjustment_changed
        to weld::Scrollbar::signal_adjustment_value_changed
        etc. to make clearer that this signal is only emitted
        when the current value changes, not any of the other
        things an adjustment manages (and that can be set
        via the weld::Scrollbar API, for example).
        
        See how the GtkInstanceScrollbar ctor connects
        the `signalAdjustValueChanged` callback to the
        GtkAdjustment:value-changed signal [2], not the
        GtkAdjustment:changed signal [3], which means that
        only changes to the current value trigger the callback
        (which in turn calls `signal_adjustment_value_changed()`),
        but changes to other GtkAdjustment properties don't.
        
        [1] https://docs.gtk.org/gtk3/class.Adjustment.html
        [2] https://docs.gtk.org/gtk3/signal.Adjustment.value-changed.html
        [3] https://docs.gtk.org/gtk3/signal.Adjustment.changed.html
        
        Change-Id: Icbeb92f3e53e0747154038aeca2f11626623fbae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182400
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-03-02  Michael Weghorn  <m.weghorn@posteo.de>  [8c86f055e3e9a1500858e95a1a5b3dd9cfaad3f3]

        weld: Don't use "upper" as param name for lower
        
        The GtkInstanceScrollbar and SalInstanceScrollbar
        overrides already use "lower" for the param name
        as well.
        
        Change-Id: If92382e4b67bf919f85e4804012563c5d87cc887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182399
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-01  Christopher Sherlock  <chris.sherlock79@gmail.com>  [27d027e5704d15639b4b06653a1ee68e8d1c5b0b]

        tdf#97228 move include file BitmapDuoToneFilter to vcl/inc/bitmap
        
        Followup to commit 47272b465 - file was moved to vcl/inc but should have
        been moved to vcl/inc/bitmap
        
        Change-Id: Iaff0a5095f6826b52fc51a5f62d98276e37cc348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182392
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-03-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d587f3dbb497a9f2846086c431ea53d72ec34a22]

        cid#1643903 Dereference before null check
        
        its null checked a mere two lines down from this deref
        
        Change-Id: I315be90633ac6d855fb3dbdd2e7a6332ee95183a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-03-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [381c2ddf463cf126fd7693173542be43d2de923d]

        cid#1643905 Uninitialized pointer field
        
        Change-Id: I8ec78ac3c713dd206846214c7a7309dfd5923b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182386
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [180458bcc4b78bf964d11e8c7be1e6e175cc9262]

        cid#1643904 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5f59d7f3f147aa80d164fd8d20e1adad317910d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182385
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-03-01  Patrick Luby  <guibmacdev@gmail.com>  [0ed6480f563c0f7f5601fb2045c5be2bafd226db]

        tdf#165277 On macOS, only delay priorities lower than POST_PAINT
        
        macOS bugs tdf#157312 and tdf#163945 were fixed by firing the
        Skia flush task with TaskPriority::POST_PAINT.
        
        The problem is that this method often executes within an
        NSTimer and NSTimers are always fired while LibreOffice is in
        -[NSApp nextEventMatchingMask:untilDate:inMode:dequeue:].
        
        Since fetching the next native event doesn't handle pending
        events until *after* all of the pending NSTimers have fired,
        calling SalInstance::AnyInput() will almost always return true
        due to the pending events that will be handled immediately
        after all of the the pending NSTimers have fired.
        
        The result is that the Skia flush task is frequently delayed
        and, in cases like tdf#165277, a user's attempts to get
        LibreOffice to paint the window through key and mouse events
        leads to an endless delaying of the Skia flush task.
        
        After experimenting with both Skia/Metal and Skia/Raster,
        tdf#165277 requires the Skia flush task to run immediately
        before the TaskPriority::POST_PAINT tasks. After that, all
        TaskPriority::POST_PAINT tasks must run so the Skia flush
        task now uses the TaskPriority::SKIA_FLUSH priority on macOS.
        
        One positive side effect of this change is that live resizing
        on macOS is now much smoother. Even with Skia disabled (which
        does not paint using a task but does use tasks to handle live
        resizing), the content resizes much more quickly when a user
        repidly changes window's size.
        
        Change-Id: I727b2d215382dbd2ebc2608d401f8b5c0dd49773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182380
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-03-01  Jean-Pierre Ledure  <jp@ledure.be>  [dec9f7d5b2d72e83f4feb81bc8845bca506bbe20]

        ScriptForge (dialogs, documents, widgets) Secure listeners
        
        Listeners programmed in Basic are created with
          CreateUnoListener(prefix, listener)
        
        The prefix argument determines the series of
        routines run when an event is triggered.
        
        So far, for SF internal listeners, the prefix
        was chosen to minimize the risk of naming
        collisions with routines present in user scripts.
        
        In fact the prefix argument may be provided as
          Library.Module.Prefix
        which eliminates the risk of ambiguity or
        homonymy.
        
        With the actual change forcing the full
        qualification of prefixes, the risk is reduced
        from epsilon to zero.
        
        No impact on the user documentation.
        
        Change-Id: I95ef4beec80c89a074c8bec809f416479e64d8cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182384
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [05ed03e70f852b0dda6073005bce71e0ac811d5c]

        toolbar a11y: Don't pass component context
        
        ... to the OToolBoxWindowItem ctor, but call
        comphelper::getProcessComponentContext directly there instead
        to get a component context to pass to the base class ctor.
        
        Change-Id: I2ea2bbf7a48096c50e0f703e6589b0346a0665ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182373
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-03-01  Bingwu Zhang  <xtex@aosc.io>  [be1b310125098ebd015c4838f1fdc8ccd50817c9]

        skia: enable LASX explicitly to LASX binary compatible objects
        
        Fix skia build on LA64 for the second time (:
        
        Enable LASX intrinsics explicitly when building with LASX binary
        compatibility.
        
        In function ‘__lasx_xvsub_h’,
        inlined from ‘S32_alpha_D32_filter_DX’ at .../workdir/UnpackedTarball/skia/src/opts/SkBitmapProcState_opts.h:323:43:
        /usr/lib/gcc/loongarch64-aosc-linux-gnu/14.2.0/include/lasxintrin.h:539:42: error: built-in function ‘__builtin_lasx_xvsub_h’ is not enabled
        539 | return (__m256i)__builtin_lasx_xvsub_h ((v16i16)_1, (v16i16)_2);
        
        cf. https://buildit.aosc.io/logs/62784-libreoffice-25.2.0.3-loongarch64-loong13-2025-02-07-22:04:10.txt
        
        Link: https://skia-review.googlesource.com/c/skia/+/873776
        Fixes: I232b4656a87a4c3d87d669769c6483e01425c0e6
        Tested-by: Bingwu Zhang <xtex@aosc.io>
        Change-Id: I9fbf0f24f28f71a76c10ee31e9a9da00ff350481
        Signed-off-by: Bingwu Zhang <xtex@aosc.io>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181256
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-03-01  Bingwu Zhang  <xtex@aosc.io>  [ec5cd2a82dfb39fcb76eb42ef2ebb5be71e70007]

        skia: backport & cherry-pick fixes for LoongArch64 LSX vectorization
        
        This changeset backports/cherry-picks the following changes from Skia:
        - I5751928376acbe298d923b465cc9303bd5bac2bb
        - I1e6183b987002ed09621b111a6012a0f186233f1
        - I45e43a7a7e6d50b4c32c5e69a6d1d7de341eccf1
        - I3b4e9479cb6f9628b4cf796a0ac25098bc1836a2
        
        This should address compiler errors when building LibreOffice for
        LoongArch64 targets with LSX enabled and LASX disabled.
        
        Tested-by: Bingwu Zhang <xtex@aosc.io>
        Link: https://skia-review.googlesource.com/c/skia/+/908136
        Link: https://skia-review.googlesource.com/c/skia/+/908137
        Link: https://skia-review.googlesource.com/c/skia/+/909436
        Link: https://skia-review.googlesource.com/c/skia/+/948976
        Change-Id: I87fa242c44296b222a8c70b19169b06d62f566b3
        Signed-off-by: Bingwu Zhang <xtex@aosc.io>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181251
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-03-01  Justin Luth  <justin.luth@collabora.com>  [e9ed6f1d2cc145e7514bf0a27b8c77f370ceab2d]

        tdf#164907 sw: Calculate row height adds border if 'atLeast' set #2
        
        The idea in 25.2 commit 4f5b896d004af023f210f235aeafa9abc50068d2
        was to add the border line's width to the atLeast row height.
        However, the function used also included the border spacing,
        which is not (really) correct.
        
        [It appears that the BOTTOM border padding should be added,
         but that is true for both the atLeast and the 'exact' cases,
         so that change should be handled separately.]
        
        In MS Word, the bottom border of one row
        is also the top border of the next row (IsCollapsedBorders()).
        The bottom border line width seems to be irrelvant
        in regards to the height of the row,
        so the fact that the code only adds the top border seems correct.
        The last row puts the bottom border _below_ the row.
        
        make CppunitTest_sw_layoutwriter4 \
            CPPUNIT_TEST_NAME=TestTdf164907_rowHeightAtLeast
        
        Change-Id: I756d38109a724d06e6230f5607b80a0bdc059bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182139
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-02-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a91494780bb59afe8c971003e6b809f1e66df050]

        tdf#165487 Always select a tab page by default
        
        Change-Id: Iba56e9a519d45e1e1962bfdaaccc8f062d001286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182340
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-28  Pranam Lashkari  <lpranam@collabora.com>  [e8c44d23c792fd710738cdd97cd03ba5b3e2176a]

        jsdialog: enabled writer setboarder style popup
        
        Change-Id: I6ac3f81de49d91ef46ada4b5f881404155cab3c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182366
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 032659457188fe5a96fea3945754ad944ffade38)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182368
        Tested-by: Jenkins

2025-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [57cb96439adc022768fb279f2d2ab33a392a9f80]

        tdf#163989 toolbar item window a11y: Leave wrapped accessible in place
        
        OToolBoxWindowItem wraps the accessible for toolbar item
        windows using OAccessibleWrapper as its base class.
        
        In addition to setting that wrapper,
        VCLXAccessibleToolBox::getAccessibleChild was so far
        also setting the wrapper as the new accesible for
        the item window, i.e. the wrapper was now somewhat
        replacing the accessible it was meant to wrap.
        
        This e.g. broke the logic to get the proper accessible
        child index for a panel in the Find toolbar in Writer
        when using the qt6 VCL plugin.
        
        This could e.g. be seen using in a similar way to the
        approach/observations described for gtk3 in tdf#163989
        comment 1:
        
        1) start LO Writer using the qt6 VCL plugin
        2) in Accerciser, enable event monitoring for LO
           object:text-caret-moved events
        3) start Orca (to trigger creation of accessible objects
           in LO)
        4) Press Ctrl+F to enable the search toolbar
        5) type, move cursor
        6) In Accerciser's Event Monitor, identify a corresponding
           "object:text-caret-moved" event
        7) click on the event source
        
        -> First issue: The object is not highlighted in Accerciser's
        treeview of the LO a11y.
        
        8) print the a11y hierarchy of the object bottom-up (i.e.
           from the object to the desktop) using Accerciser's IPython
           console:
        
            In [2]: obj = acc
            In [3]: while obj:
            In [3]:     print(f'object: {obj}, index in parent: {obj.get_index_in_parent()}')
            In [3]:     obj = obj.parent
            In [3]:
            object: [text | eeee], index in parent: 0
            object: [combo box | eeee], index in parent: 0
            object: [filler | ], index in parent: 0
        ->  object: [filler | ], index in parent: -1
            object: [panel | ], index in parent: 0
            object: [panel | Find Values], index in parent: 1
            object: [tool bar | Find], index in parent: 0
            object: [panel | ], index in parent: 5
            object: [panel | Untitled 1 — LibreOfficeDev Writer 25.8 [fbdfde26391730216bae230cd6f228a6ae6ee89c]], index in parent: 0
            object: [panel | Untitled 1 — LibreOfficeDev Writer 25.8 [fbdfde26391730216bae230cd6f228a6ae6ee89c]], index in parent: 0
            object: [frame | Untitled 1 — LibreOfficeDev Writer 25.8 [fbdfde26391730216bae230cd6f228a6ae6ee89c]], index in parent: 0
            object: [application | soffice.bin], index in parent: -1
            object: [desktop frame | main], index in parent: -1
        
        Second issue (which is cause for the first one):
        There is a filler with invalid child index -1 in
        the path (highlighted by an arrow above).
        
        With this fix in place, both issues no longer appear, but
        the combobox's text entry is correctly selected in Accerciser's
        treeview and the child index is correct:
        
            In [6]: obj = acc
            In [7]: while obj:
            In [7]:     print(f'object: {obj}, index in parent: {obj.get_index_in_parent()}')
            In [7]:     obj = obj.parent
            In [7]:
            object: [text | eee], index in parent: 0
            object: [combo box | eee], index in parent: 0
            object: [filler | ], index in parent: 0
        ->  object: [filler | ], index in parent: 0
            object: [panel | ], index in parent: 0
            object: [panel | Find Values], index in parent: 1
            object: [tool bar | Find], index in parent: 0
            object: [panel | ], index in parent: 5
            object: [panel | Untitled 1 — LibreOfficeDev Writer 25.8 [89cb9707f45fdf2e00c1670701a5abc393f0c13d]], index in parent: 0
            object: [panel | Untitled 1 — LibreOfficeDev Writer 25.8 [89cb9707f45fdf2e00c1670701a5abc393f0c13d]], index in parent: 0
            object: [frame | Untitled 1 — LibreOfficeDev Writer 25.8 [89cb9707f45fdf2e00c1670701a5abc393f0c13d]], index in parent: 0
            object: [application | soffice.bin], index in parent: -1
            object: [desktop frame | main], index in parent: -1
        
        For gtk3, the issue described in tdf#163989 18 comment 1
        remains however and will have to be addressed separately.
        
        Change-Id: Ie16b34caf1df70c25a4b2a52eaeb22ff0ab3d9e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182371
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [98df0c4bd3c440299bb21650f0e6e53bb169f8ae]

        svx: Switch FindTextFieldControl parent param to ToolBox
        
        ... instead of the more generic vcl::Window.
        This makes it clearer that the parent always has to
        be a ToolBox.
        
        This is already assumed elsehwere, e.g. in
        FindTextFieldControl::ActivateFind, where a
        a static_cast<ToolBox*> is done.
        
        Change-Id: Id0c54b466ea7fc59c566e6eef6d8601281578d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182370
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [eea1f0374267c4cb3fd1ecfb04528bd0f7b905b5]

        use more concrete UNO classes in OFormattedFieldWrapper
        
        Change-Id: Ibb5d170e293a7ed5b90301e226fae8c666ea9138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182363
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-28  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [61290d41e575f5f5a328966d87516ec8c3e15a74]

        remove unused include from vcl
        
        Change-Id: Ibb8b7492764e5f1146521f6bf964c7bab19e1895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182002
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [820cd47b34a8138a2c17094ee4ae2ebbd9d507ab]

        tdf#164895: sc_subsequent_filters_test3: Add unittest
        
        Change-Id: I4b1949ac6daede017bef6ff02ecca27407238489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182333
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-28  Jaume Pujantell  <jaume.pujantell@collabora.com>  [dd5f718c4b621313c406ea6ed4d7141b8db78e61]

        tdf#163890 sw: fix anchor inserted shape to paragraph
        
        Since the commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 "sw: fix
        double-click opening frame dialog, not graphic dialog on images", when
        GetModelPositionForViewPoint is called on an "as-char" graphic it
        returns the graphic node. This makes inserted shapes anchor to page as a
        fallback since they don't find a text node to anchor to.
        
        With this change, the function returns the anchor text node as before if
        the caller explicitly asks for only text frames.
        
        This change breaks testTdf157129 in sw_uiwriter8. After pasting content
        ending with a hidden paragraph, SwCursorShell::UpdateCursorPos() should
        only move the cursor outside the hidden content. Before this change, the
        call to GetLayout()->GetModelPositionForViewPoint didn't change the
        cursor position because SwTextCursor::GetModelPositionForViewPoint
        called pFlyPor->GetFlyCursorOfst and returned success even when it
        failed to get a text node and therefore the cursor didn't change. Now it
        finds a valid text node and changes the cursor to that. But this is the
        wrong behavior, GetModelPositionForViewPoint should not be called if a
        non-hidden paragraph can trivially be found.
        
        Change-Id: I8cf9f0c7dcfe6f4be46435c8506e67606ce8fe9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176775
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 7ee34038b12c18b34261beb303f1f945d690761c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176863
        Tested-by: Jenkins

2025-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [b5a614a412b59d686ee3e8a3531dc28c0fccb8e9]

        dbaccess: fix typo
        
        Change-Id: Ibdac76ba3346fc623a04345550d6ffd83a3ff77d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b39c4dd8bf1a54bd96cf4119342c581b52509c9]

        lok: encourage even more sharing of config Node pages.
        
        some properties, e.g. the localized user strings for "uno commands"
        as used by vcl::CommandInfoProvider::GetCommandProperties are
        cloned, so the inserted clones are not staticized.
        
        Profiles persisted in show many probe:do_wp_page events from
        salhelper::SimpleReferenceObject::acquire in
        configmgr::Access::getUnmodifiedChild
        
        https: //raw.githubusercontent.com/caolanm/profiles/585ce8645ff6ea1e3de1b3cc6f11a16f325fb0d9/do_wp_page/Demo.eu-2025-02-12T04%3A36%3A21.759836.svg
        Change-Id: I3eaccbbd7e9af0c312ed1d7da68e64ffb96d3292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181513
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 9be96cfcaec84b730ad2dae923a91aa39efe2993)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182350
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-28  Michael Meeks  <michael.meeks@collabora.com>  [f05302c3dffe79dc4a799ed341e0096f34b66808]

        lok: encourage more sharing of config Node pages.
        
        Profiles show lots of probe:do_wp_page events from things like
        configmgr::Access::getUnmodifiedChild - as when we read we touch
        lots of Node reference counts - un-necessarily.
        
        So - reduce un-necessary reference counting thrash here in the
        lok case through the environment variable. Quite possibly this
        would also be safe and beneficial for the desktop app - needs
        measurement.
        
        measuring with coolmap and an empty hello-world.odt before & after:
        before:
        	unshared  3634 (14536kB)
        	unshared  3631 (14524kB)
        	unshared  3605 (14420kB)
        
        after:
        	unshared  3578 (14312kB)
        	unshared  3613 (14452kB)
        	unshared  3599 (14396kB)
        
        Not hugely encouraging, perhaps there is another page touch
        underneath we'll find when this is addressed.
        
        Change-Id: I8ac74c5fcd17f8699139e914a7076a7848456e2a
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175197
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182349
        Tested-by: Jenkins

2025-02-28  Michael Meeks  <michael.meeks@collabora.com>  [b30c061989ede0c19b62a10f6206cecc77e2bf69]

        SimpleReferenceObject: add ability to staticize the ref-count.
        
        Useful for when we allocate data at startup and want to share it
        across multiple threads. Also potentiall useful for turning
        extreme cases of ref-count wrap-around into a more benign leak.
        
        Change-Id: I04e6a62dbd366d294d86ab72036c3498402357f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175196
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182348
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [c46213606d64bbaca9b1d284063c248932c725de]

        convert oox::drawingml::Color::ColorMode to scoped enum
        
        Change-Id: Ieb9a3cd02ca135e451f38cfca2c625923f9edeb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [fbdfde26391730216bae230cd6f228a6ae6ee89c]

        CppunitTest_dbaccess_migration: Unify into 1 place
        
        and use setUp and tearDown to enable/disable
        the experimental mode
        
        Change-Id: I922bc289179528d1fc1df1a3545315ec92489afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182355
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [c406e0005f952420667ad0394bc7f4c34d50abd3]

        thumbnailview a11y: Drop ThumbnailViewItemAcc::m_aMutex
        
        Use SolarMutexGuard in ThumbnailViewItemAcc::ThumbnailViewItemDestroyed
        instead, like in other methods.
        
        This also fixes this build failure I see on Win 11
        (due to missing `#include <mutex>`):
        
            C:\Users\mwegh\development\git\libreoffice\sfx2\source\control\thumbnailviewitemacc.hxx(33): error C2039: 'mutex': is not a member of 'std'
            C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\14.42.34433\Include\sstream(19): note: see declaration of 'std'
            C:\Users\mwegh\development\git\libreoffice\sfx2\source\control\thumbnailviewitemacc.hxx(33): error C3646: 'maMutex': unknown override specifier
            C:\Users\mwegh\development\git\libreoffice\sfx2\source\control\thumbnailviewitemacc.hxx(33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
        
        Change-Id: I783c42759df6305038d0901d35d81146084bb3ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182346
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-28  Rene Engelhard  <rene@rene-engelhard.de>  [344b71a1d1598465d7ebf6768aa68ad1db38d506]

        fix poppler < 25.02 builds again
        
        after 406afe11711df9fcabbc829fcff00aef2f44c1d9
        should be #if POPPLER_CHECK_VERSION(25, 2, 0), cf. e.g.
        https://cgit.freedesktop.org/libreoffice/core/tree/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx?id=406afe11711df9fcabbc829fcff00aef2f44c1d9#n1325
        
        Change-Id: I2b891eaab55a303d74e92335bb15b520af4805bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182344
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Robin Candau <antiz@archlinux.org>
        Tested-by: Jenkins

2025-02-28  Eike Rathke  <erack@redhat.com>  [23a9d6f069039fb8032362e00fbe42dea4ffb125]

        Resolves: tdf#164895 Fix OOXML global names import without sheet reference
        
        ... like it's often the case in named expressions.
        
        Wonder why that didn't pop up earlier..
        
        Change-Id: Ie9d2b8642848981f420e45c6ede995f86e062903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182318
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2cc1f8a6bd27907800416a5396942a0c7ca56ce]

        tdf#134864 speedup load of pathological conditional formats in XLS
        
        This associated file had 300k conditional formatting entries, which
        reduced to about 10 when de-duplicated.
        
        Rework the logic so instead of deduplicating rule model entries, we dedplicate at a slightly higher level, and make the comparison check more thoroughly, which greatly increases the number of duplicates we find.
        
        Takes the load time from 38sec to 6sec on my machine.
        
        Tweak one of the unit tests, because we now consolidate some
        of the conditional formatting entries in that test file.
        
        Change-Id: Iff2c6afb1c9959576aa00a38d0a8e5d4a48b0fd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182356
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-28  Michael Stahl  <michael.stahl@allotropia.de>  [154b58cfd76a8ad670d4aa25874eed66e3398a3e]

        sw: layout: fix truncation of table in section
        
        There is a table in a section, split across 2 pages; now insert a page
        break that moves the section to page 2.
        
        In SwTabFrame::MakeAll(), on page 2, first the follow is joined, which
        grows the table frame but shrinks the section frame (removing the
        follow's height), then the table's upper is grown to LONG_MAX but with
        bTst=true so it doesn't actually change or invalidate the section frame,
        then in lcl_RecalcRow() almost no growth happens because the table
        frame already has accounted for the height of most of the table content.
        
        The section frame remains too small for the table, and the content is
        truncated... this problem can already be reproduced in OOo 3.3.
        
        When GetUpper()->Grow() returns some space, invalidate the upper if it's
        a section frame, then the next round will format the section.
        
        (Simply calling Grow() with bTst=false results in an opposite problem,
        where the section is too large.)
        
        Change-Id: I3cb3a5a38fbd7996fa9fcea9a6036f4260451a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182331
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-28  Christopher Sherlock  <chris.sherlock79@gmail.com>  [9d35ad8ee8aefedb5978f0c22aa08e1d9971c9b7]

        vcl: extract ScrollBar hit test functions
        
        ImplHitTestBtn1(), ImplHitTestBtn2(), ImplHitTestPageUp(),
        ImplHitTestPageDown() and ImplHitTestThumb() extracted and used.
        
        Extracted IsHorizontal() and GetScrollbarRegion() to reduce code
        duplication (also makes things arguably more clear - thanks to Michael
        Weghorn for pointing this out in review).
        
        Change-Id: Ibc9e584ab046046f2e6f1cd3056b8213973e3254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179242
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-28  Christopher Sherlock  <chris.sherlock79@gmail.com>  [91ce2860cc21d4a20888310b8b8835391f20fca6]

        vcl: fix modelines in vcl/source/control/fmtfield.cxx
        
        Change-Id: I547d4c993f1c1ab6d71dde68d82fc159d1254e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181688
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5315f2438987d9df821a732515a076ed2ba23f23]

        Fix typo
        
        Change-Id: Ib8a84524b31c3a50e51f55ec493d3baf12dc4035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182343
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [78a4e18b594b7c5be371284dcb24ac1d9b556a2d]

        Fix typo
        
        Change-Id: I706c13611ffc7ef8d8cad48366afe4665514e9c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182342
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [31d4a7bd3760ecb087c61cd6ae5095493820d230]

        loplugin:constantparam
        
        Change-Id: I8184c75ea6f35538eb68faa9eaf18b6d053f843c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [97e2f31089c6676545a4a80369d575c79fb7817b]

        Fix typo
        
        Change-Id: I8683242309b3756335ff64c9bfca3cbcf1de4c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182250
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Tested-by: Jenkins

2025-02-28  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [8a1b353e7f0ccaeb7fe179863f27b473f83ca2cb]

        tdf#165438 for user created (raw) themes, use default document colors
        
        Change-Id: I7d35617ac4a22e6d41cdad2fb6991ae9901284e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182263
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit e4045146603e3bb64373b60c2675276502cb4f2e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182303
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [f0868e555a3054487c49690c9e2398bedf9067b7]

        vcl a11y: Drop comments mentioning non-existent OAccessibleListBoxEntry
        
        It's unclear what they're referring to, e.g. when
        the one in vcl/inc/accessibility/vclxaccessiblelistitem.hxx
        was added in
        
            commit d1a197df359aa2d7f8010f1103fe5080060cbc90
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Wed Jun 27 14:26:30 2007 +0000
        
                INTEGRATION: CWS a11ysep (1.1.2); FILE ADDED
                2006/10/05 08:20:12 fs 1.1.2.3: MANUAL RESYNC m130->m185:
                file had been modified in MWS, but moved herein in CWS
                2005/09/28 11:40:36 fs 1.1.2.2: manual resync (files have been moved herein from another location): licence change
                2005/03/07 08:27:39 fs 1.1.2.1: #i44293# moved implementations herein from toolkit module
        
        , it was already just above the VCLXAccessibleListItem
        class declaration.
        
        Change-Id: I97b89e4c8869e715c1e4332fca04f66ee020fdd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182273
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [0424b3c6475f988d67a5896f83e115958fae4fe7]

        vcl a11y: Drop unused forward declaration
        
        Change-Id: I780c37e573707279fc83f7c552aafa514d2f79ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182272
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [ca0067886006b995dca57648996e0a36cb8e00ab]

        sd presenter a11y: Drop AccessibleObject::ThrowIfDisposed
        
        Use the base class method
        OCommonAccessibleComponent::ensureAlive instead.
        
        Change-Id: If6d9393c8fe3f3996fa42174ae5831201d7122d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182330
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [565be680deffa09a9536717d216c00f4e59d2f20]

        sd presenter a11y: Dispose objects
        
        So far, the a11y objects used for the Impress Presenter
        console were not disposed by their owners, leading to
        the crash on exit with qt6 described in previous commit
        
            Change-Id: I1481cbb03e99b6f89c5222ed260477004a9db62c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 17:40:37 2025 +0100
        
                sd presenter a11y: Use OAccessibleComponentHelper
        
        Let the owners take care of disposing the objects, which
        fixes this issue.
        
        Change-Id: I86d740ecfdbec2cb00c25726376e6c88aa51f1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182329
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [d4807c79aaad4d8a13fcf3247ca0c029b27dd3ef]

        sd presenter a11y: Use OAccessibleComponentHelper
        
        Similar to how
        
            commit 1c3d0bc25f1a8bc506fecca7bf39d78f7f817ad3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 11:14:04 2025 +0100
        
                thumbnailview a11y: Use OAccessibleComponentHelper for ThumbnailViewItemAcc
        
        did for ThumbnailViewItemAcc, also derive
        from OAccessibleComponentHelper for AccessibleObject
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        AccessibleObject::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed initially
        when testing this with the qt6 VCL plugin and the scenario
        otherwise described in
        
            Change-Id: I74660a07e5660a0f1ac0cd17eff793e4e4a8979b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 17:00:44 2025 +0100
        
                sd presenter a11y: Avoid invalid string index
        
        However, when closing LO, this now triggers an assertion:
        
            soffice.bin: /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed.
        
        This is the same preexisting issue as already described
        in more detail for ValueItemAcc in
        
                commit e7dc7ebc9e14447a4ab75502a378f632a910c394
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Tue Feb 25 12:14:24 2025 +0100
        
                    valueset a11y: Use OAccessibleComponentHelper for ValueItemAcc
        
        (items don't get disposed) and will be addressed
        in an upcoming commit.
        
        Change-Id: I72ac37ad368b7d4abf14f625004dad60b20ffe81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182328
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [440b37e3bdb59c173ca753bc9bd18a86797939b1]

        sd presenter a11y: Fix parent-relative paragraph position
        
        AccessibleParagraph used to override both,
        AccessibleObject::GetRelativeLocation
        and AccessibleObject::GetAbsoluteParentLocation.
        
        What was odd is that AccessibleParagraph::GetAbsoluteParentLocation
        was not returning the absolute location of the actual parent,
        but of the grandparent (parent's parent), because
        AccessibleObject::GetRelativeLocation didn't actually
        return the position relative to the direct parent, but to the
        grandparent as well.
        
        While this evens out in AccessibleObject::getLocationOnScreen
        where both of these are called, it doesn't in
        AccessibleObject::getLocation where only
        AccessibleObject::GetRelativeLocation gets called.
        
        Adjust the logic to let AccessibleObject::GetRelativeLocation
        return the paragraph's relative location without adding to
        that.
        
        This allows to drop AccessibleParagraph::GetAbsoluteParentLocation
        altogether because the base class implementation can be used as
        is now.
        
        Without this commit, the incorrect area would be highlighted
        by Accerciser when using the gtk3 VCL plugin and the scenario
        decribed in previous commit
        
            Change-Id: I74660a07e5660a0f1ac0cd17eff793e4e4a8979b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 17:00:44 2025 +0100
        
                sd presenter a11y: Avoid invalid string index
        
        . With this commit in place, the correct area is highlighted
        on screen now.
        
        Change-Id: I1481cbb03e99b6f89c5222ed260477004a9db62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182327
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [477cf1ebcac5ed97c5118350a15ae6d624af6a7a]

        sd presenter a11y: Avoid invalid string index
        
        In PresenterTextParagraph::GetTextSegment, only
        use start index + 1 for the end index if the text
        has at least that many characters.
        
        This fixes an assert with the below backtrace for the following
        case:
        
        1) start Impress with the gtk3 VCL plugin, in a dual screen setup
        2) add notes for the first slide via "View" -> "Notes"
        3) make sure Presenter Console is enabled in "Slide Show" -> "Slide Show
           Settings"
        4) Start slide show (F5)
        5) start Accerciser
        6) in Accerciser's treeview of the LO a11y hierarchy, navigate to
           the first paragraph object in the slide notes object
        
        Backtrace of the assert:
        
            1  __pthread_kill_implementation                                        pthread_kill.c          44   0x7ffff789ddcc
            2  __pthread_kill_internal                                              pthread_kill.c          78   0x7ffff789de2f
            3  __GI_raise                                                           raise.c                 26   0x7ffff7849d02
            4  __GI_abort                                                           abort.c                 79   0x7ffff78324f0
            5  __assert_fail_base                                                   assert.c                96   0x7ffff7832418
            6  __assert_fail                                                        assert.c                105  0x7ffff7842612
            7  rtl::str::newFromSubString<_rtl_uString>                             strtmpl.hxx             890  0x7ffff7f4ca59
            8  rtl_uString_newFromSubString                                         ustring.cxx             1152 0x7ffff7f471c9
            9  rtl::OUString::copy                                                  ustring.hxx             2578 0x7fff9cbec4fc
            10 sdext::presenter::PresenterTextParagraph::CreateTextSegment          PresenterTextView.cxx   868  0x7fff9cd037ad
            11 sdext::presenter::PresenterTextParagraph::GetTextSegment             PresenterTextView.cxx   806  0x7fff9cd030d3
            12 AccessibleParagraph::getTextAtIndex                                  AccessibleParagraph.cxx 322  0x7fff9cc43c88
            13 non-virtual thunk to AccessibleParagraph::getTextAtIndex(int, short)                              0x7fff9cc43d4b
            14 text_wrapper_get_run_attributes                                      atktext.cxx             538  0x7fffe4450b7f
            15 atk_text_get_run_attributes                                                                       0x7fffe7045b5e
            16 ??                                                                                                0x7fffe3700805
            17 ??                                                                                                0x7fffe37034ed
            18 ??                                                                                                0x7ffff77dc024
            19 dbus_connection_dispatch                                                                          0x7ffff77cb8fb
            20 ??                                                                                                0x7fffe359eb79
            21 ??                                                                                                0x7fffea103d5f
            22 ??                                                                                                0x7fffea105fd7
            23 g_main_context_iteration                                                                          0x7fffea106740
            24 GtkSalData::Yield                                                    gtkdata.cxx             405  0x7fffe4483dac
            25 GtkInstance::DoYield                                                 gtkinst.cxx             439  0x7fffe4488cb3
            26 ImplYield                                                            svapp.cxx               385  0x7fffeec7fae6
            27 Application::Yield                                                   svapp.cxx               488  0x7fffeec7f3ff
            28 Application::Execute                                                 svapp.cxx               360  0x7fffeec7f1e0
            29 desktop::Desktop::Main                                               app.cxx                 1680 0x7ffff7b25bd9
            30 ImplSVMain                                                           svmain.cxx              230  0x7fffeeca0fb6
            31 SVMain                                                               svmain.cxx              248  0x7fffeeca2ba9
            32 soffice_main                                                         sofficemain.cxx         122  0x7ffff7b9f4ba
            33 sal_main                                                             main.c                  51   0x555555555a6d
            34 main                                                                 main.c                  49   0x555555555a47
        
        Change-Id: I74660a07e5660a0f1ac0cd17eff793e4e4a8979b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182326
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [e896bbbd55af7eac5d4f60af56b134f85afcbd78]

        sd presenter a11y: No longer read a11y names from config
        
        Instead of reading strings for the a11y names to use
        for the Impress Presenter Console objects, use the
        usual approach for translatable strings.
        
        This is simpler and I see no reason to have those
        accessible names configurable.
        
        Maybe the previous approach was somehow related
        to the fact that Presenter Console used to be
        an extension before
        
            commit ea91c7d90d74e1ca039ba669b5d3e14fa359c0fa
            Author: Stephan Bergmann <sbergman@redhat.com>
            Date:   Wed Nov 21 17:19:28 2012 +0100
        
                Turn presenter screen from bundled extension to plain code
        
        Change-Id: I55b5e525913f429ec60a1c21b7bf162870d79af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182325
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [6e433b1aa65a661fbea8a64ed5eff8e336e452c1]

        sd presenter a11y: Don't report a11y name also as description
        
        AccessibleObject::msName already gets returned
        in AccessiblePresenterObject::getAccessibleName, so don't
        use it for the accessible description in addition, but
        return an empty string instead.
        
        Change-Id: I7a9fe978fff4704927a7456830235268b2c8f67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182324
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [27bff3be074e9a31b199cfbac52c3a992ea736a3]

        sd presenter a11y: Move AccessibleParagraph to own header/source
        
        Move the AccessibleParagraph class outside of the
        PresenterAccessible class and to its own header and
        source file.
        
        Move the AccessibleRelationSet helper class only used
        by AccessibleParagraph to its source file, too.
        
        Change-Id: Ie412d29cd17d192d3ca71a8a178c9b7607a8bec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182323
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [bc35ec327f1ade9075232ebc77a466130aa3aa95]

        sd presenter a11y: Move 2 classes to own .hxx/.cxx
        
        Move the AccessibleFocusManager and
        AccessibleObject classes to their own
        header and source files, which makes it a little
        easier to keep the overview.
        
        AccessibleObject is now also no longer an inner
        class of the PresenterAccessible class.
        
        Change-Id: Ifdd2101fff7bee32567d737227dff514678d8f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182322
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [da3c954c95b2cc8e9316a36f76ec5f7bfadce868]

        sd presenter a11y: Construct default Locale on demand
        
        The PresenterAccessible::AccessibleObject was always
        called with a default-constructed css::lang::Locale.
        
        Avoid the impression that the Locale that gets passed
        could be something meaningful and simply call the
        default ctor on demand in
        PresenterAccessible::AccessibleObject::getLocale instead.
        
        Change-Id: I362ffbb755ac1a3bcffc1edc2e572a7046f96bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182301
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [a155c12fca28bbd9a790b5a9c438717c3a138c7d]

        sd presenter: Drop always false params
        
        All callers of PresenterHelper::createWindow
        pass false for both, the `bEnableChildTransparentMode`
        and the `bEnableParentClip` params.
        
        Drop them altogether, which allows to
        simplify PresenterHelper::createWindow a bit.
        
        Change-Id: Id4dc1ddb81833cdd303ec8314a80eeeee1cd89ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182300
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [7fd252bd27147d0bf76e01f7a19c97a96044b3de]

        sd presenter: Drop always false bCreateSystemChildWindow param
        
        PresenterHelper::createWindow always gets called with
        a `bCreateSystemChildWindow` param of false. Drop
        the param altogether.
        
        Change-Id: Ia82dfa6d4826bf2cbe85a164c7645d3e9a7d1fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182299
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [5d6574613a11dff1c3060d9b7879b4c2cef7904d]

        sd presenter: Don't allow creating PresenterHelper objs
        
        By now, the class is only useful for the static
        helper methods it provides.
        
        The last use of an actual PresenterHelper object was
        dropped in
        
            Change-Id: I7b85ae4f720474faf72d2721545158726b1d745d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 11:04:45 2025 +0100
        
                sd presenter: Drop PresenterPaneBorderPainter::Renderer::mxPresenterHelper
        
        Make that clear by marking the default ctor as deleted and
        dropping what has become irrelevant.
        
        Change-Id: I411b02b94c8f81bc8cfb19e248e861adfe1a670e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182298
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [75696de0e7575afbbfd2113ebeb388f6be78daa1]

        sd presenter: Drop PresenterPaneBorderPainter::Renderer::mxPresenterHelper
        
        It's only set in the ctor, but never used afterwards.
        
        Change-Id: I7b85ae4f720474faf72d2721545158726b1d745d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182297
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [84961ec877a13c528112f8aeb045dcc6c286bdb6]

        sd presenter: Drop commented out code
        
        It's commented ever since it was added in
        
            commit 4d91841e0bc18d5b01fe85eb03eb0be589cf0c74
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Tue May 13 13:34:16 2008 +0000
        
                INTEGRATION: CWS presenterscreen (1.2.4); FILE MERGED
                2008/04/22 08:24:33 af 1.2.4.3: RESYNC: (1.2-1.3); FILE MERGED
                2008/04/16 16:59:13 af 1.2.4.2: #i18486# Fixed some Linux build problems.
                2008/04/16 15:46:44 af 1.2.4.1: #i18486# Added support for callout.
        
        Change-Id: I27c8bfa4fef204d19aab46371efa4efe2427dfad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182296
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [97fc0f691d7beb97d3481cf9ec60b2b0a63f8795]

        sd presenter: Drop ReadContext::mxPresenterHelper
        
        It's only written to, but never read.
        
        Change-Id: I75d087f61f5005af5e17f9efc05c07c948b50c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182295
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [fc44d28260ea4ef74c3ed125d57af3e7e588f42c]

        sd presenter: Drop PresenterController::mxPresenterHelper
        
        It's no more needed after
        
            Change-Id: I3668849e06aadc2ad9cfd4be80ee0749d59c8440
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 10:45:18 2025 +0100
        
                sd presenter: Drop PresenterToolBar::Context::mxPresenterHelper
        
        Also drop the use of XMultiComponentFactory in the
        PresenterController ctor which seems unnecessary
        and seems only to be there because it was used
        in the past to create a PresenterHelperobject/XPresenterHelper
        instance when this was still done using a UNO service.
        
        Change-Id: I87e323cf6c5d8f3b67deb5ab5bd203af4c0b2063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182294
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [fce24e47de104afebbe02ed23141b99ff7af605c]

        sd presenter: Drop PresenterToolBar::Context::mxPresenterHelper
        
        It's no more needed after
        
            Change-Id: I0afcf0e429fbc1b3c503f79373d3150fdd59a4bc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 10:10:15 2025 +0100
        
                sd presenter: Drop PresenterHelper param
        
        Change-Id: I3668849e06aadc2ad9cfd4be80ee0749d59c8440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182293
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [c9be05938a2e2258642c300de31ae396137bc5bd]

        sd presenter: Drop PresenterBitmapContainer::mxPresenterHelper
        
        It is only written to, but never read, since
        
            Change-Id: I7055e5652f59f251b58bc4d79f7dae0e9c99f667
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 10:10:15 2025 +0100
        
                sd presenter: Drop PresenterHelper param
        
        Drop the class member and ctor params only needed to
        initialize it.
        
        Change-Id: Id935301e6188ee7b5d0fbe9bf065a5b185b1a137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182292
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [bb609ee548ceb017825076e3bee12dfa52bd5da8]

        sd presenter: Drop PresenterHelper param
        
        The `rxPresenterHelper` param in PresenterBitmapContainer::LoadBitmap
        is effectively unused by now:
        
        Only an `OSL_ASSERT` remained after
        
            Change-Id: I7741b966e09850412f60d2a3f44d36b401553729
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 27 09:43:46 2025 +0100
        
                sd presenter: Make PresenterHelper::loadBitmap static
        
        Therefore, drop the param altogether.
        
        Change-Id: I0afcf0e429fbc1b3c503f79373d3150fdd59a4bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182291
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [67b4f79188f6a95c245d31625c31fe989ecac041]

        sd presenter: Drop unused PresenterHelper::createCanvas
        
        Change-Id: Ia3231f30ff7ee0223d596d1b15936b5ddd792a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182290
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [6530a474b4dd56a6f597cbcee87f72c3d9d8b03f]

        sd presenter: Make PresenterHelper::getWindowExtentsRelative static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make sd::presenter::PresenterHelper::getWindowExtentsRelative
        static.
        
        Drop rtl::Reference<PresenterHelper> class members in other classes
        that are now no more needed as they were only used to call the
        now static method.
        
        Change-Id: Ic095cfa900db7211bc3b7e286702807afeba1c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182289
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [1ab613dcca54f6710c335f5e3251de3afd8d2817]

        sd presenter: Make PresenterHelper::toTop static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make sd::presenter::PresenterHelper::captureMouse
        and sd::presenter::PresenterHelper::releaseMouse
        static.
        
        This also makes PresenterScrollBar::mxPresenterHelper
        unnecessary, so drop it.
        
        Change-Id: Id45500f07fd5388abdcc0fc51623287cfc247f51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182288
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [576a3a82c52c9b36daab36ca679d3a8f6ecabaf7]

        sd presenter: Make PresenterHelper::loadBitmap static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make PresenterHelper::loadBitmap static.
        
        Change-Id: I7741b966e09850412f60d2a3f44d36b401553729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182287
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [a88f2a8f69e5ba9fa803ad1dd047949b09976e3d]

        sd presenter: Align param names in doc with actual ones
        
        This was forgotten when the doc was taken over from
        the XPresenterHelper IDL file in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        Change-Id: I79d9ff754f175d768b53bfc3a64d77d2cae88faf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182280
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [6da9abaa34f080403d38fd995a78be5368c75342]

        sd presenter: Use u16_string_view, OUString instead of char const*
        
        This also prepares for an upcoming commit to
        make PresenterHelper::loadBitmap static, at which
        point switching the method param to std::u16string_view
        would be mandated by a clang-plugin.
        
        Change-Id: I6def3aceb1966c5d0d24db5112d64f6e662d55bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182279
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [ae46e4f31817a65869ffb8b6a6703a8bef91bf15]

        sd presenter: Make PresenterHelper::createSharedCanvas static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make PresenterHelper::createSharedCanvas static.
        This also makes PresenterButton::mxPresenterHelper
        unnecessary, so drop it and the ctor param only needed
        create it.
        
        Change-Id: I4af6e537d140a330fc6ffca518ed2809b935dafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182278
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [cf2dd3be95586ec4b1db83c38b615b89058eb801]

        sd presenter: Use bool instead of sal_Bool
        
        sd presenter: Make PresenterHelper::createWindow static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , there's no more reason to use sal_Bool.
        
        Change-Id: I0333f7c1a05fe0bca4ce3920d8142bb89c03418d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182277
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [513e3084b43e8364db1b9529f1a3d3fc11b4e77a]

        sd presenter: Make PresenterHelper::createWindow static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make PresenterHelper::createWindow static.
        
        Change-Id: I8d43904294e130b8f50bc4986c740b92a1a3cf4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182276
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [13ffb1d41f24f142074ebef5e6f0c5c45d4e6a0f]

        sd presenter: Make PresenterHelper::toTop static
        
        Now that PresenterHelper no longer needs to implement
        the XPresenterHelper interface dropped in
        
            commit a80dec4e7bfb64d5331fe59d0feaeede636376f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 17:17:42 2025 +0100
        
                [API CHANGE] Drop css::drawing::XPresenterHelper
        
        , make PresenterHelper::toTop static and adjust callers.
        This also makes PresenterParseContainer::mxPresenterHelper
        unnecessary, so drop it and the PresenterParseContainer ctor
        param only needed to initialize it.
        
        Change-Id: Ifc4e1447e11f4a3b73277f8610875ba8294e0975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182275
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d03fd2119edf3e8b7f1cbb33b2c9951e8f0acc8b]

        tdf#165383: sc_subsequent_export_test4: Add unittest
        
        Change-Id: I3c0592d59243d2bfb45fdd2900b1d45c7582c06f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182332
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-27  Pranam Lashkari  <lpranam@collabora.com>  [dc8017563934dee2aef7597f1c2f3719cb1d90e8]

        sc comment kit: use iso format dates
        
        problem:
        Online expects iso format dates, different date type confuses online as there is no way to identify in online which format date is sent
        
        Change-Id: I84d83005287869cea44f27c1d5a337bd67975bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182243
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 432e75c8997dafca72ab816ac5decee7bfed21c7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182312
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-02-27  Eike Rathke  <erack@redhat.com>  [fbf053ac8f6983116014d8f24e153304794d1021]

        Resolves: tdf#165383 Write range reference also if absolute/relative differ
        
        ... and top left / bottom right point to a single cell, so $K$9:K9
        remains expandable to $K$9:K10
        
        Change-Id: Ibafd1f715ae72de21d268e934ffd82df9a48f625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182313
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-02-27  Julien Nabet  <serval2412@yahoo.fr>  [1137a2f025152576790933763daddef7d0c6197f]

        Revert "tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if ...
        
        This causes regression, see tdf#165458
        
        This reverts commit 9530664d07f400f4d8dcbe54d0e82d69168844de.
        
        Change-Id: Ic2be6ea3a41e1a22c9443a2fe8a0cae188bc6eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182314
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5f46f5b7301789000c5c71acec1747f192cee01a]

        Work around epm failure with readme file gone from SDK
        
        ...with 01ae181574d06d5ea60f9454684cb09621724f17 "Remove readme file from SDK",
        after which Linux --with-package-format=deb or --with-package-format=rpm builds
        had started to fail with errors like
        
        > : *****************************************************************
        > : ERROR: ERROR: Could not find readme file README_en-US (C) at /home/sberg/lo2/source/solenv/bin/modules/installer/epmfile.pm line 488.
        > : *****************************************************************
        >
        > make[1]: *** [/home/sberg/lo2/source/instsetoo_native/CustomTarget_install.mk:123: sdkoo‧en-US‧_SDK‧‧deb‧nostrip] Error 1
        
        epm demands a %readme line in its input (cf.
        
        >   if (!dist->product[0] ||
        >       !dist->copyright[0] ||
        >       !dist->vendor[0] ||
        >       !dist->license[0] ||
        >       !dist->readme[0] ||
        >       !dist->version[0])
        >   {
        >     fputs("epm: Error - missing %product, %copyright, %vendor, %license,\n", stderr);
        >     fputs("     %readme, or %version attributes in list file!\n", stderr);
        
        in workdir/UnpackedTarball/epm/epm.c), but doesn't seem to actually need it, at
        least in this scenario.  So use NO_README_IN_ROOTDIR, which happens to be set
        exactly for LibreOffice_SDK and LibreOfficeDev_SDK in
        instsetoo_native/util/openoffice.lst.in, as a flag to provide a dummy %readme
        line for epm, which appears to work well.
        
        Change-Id: I350c5914cd7b6d2f61cdd3d1ed4db7f7cc50c627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182285
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bafe4102742d2a3e2f5d81ba498035d2eefce371]

        tdf#163592 - sc fix Sort/SortBy function shows err504 instead of results
        
        with a single row as sort array.
        
        No Need to sort anything if we are sorting one row by rows or we are
        sorting one column by columns, in that case we can just return the original
        rows/columns to be sorted.
        
        Change-Id: I59528854c7f203957dbc479b23473ce0f3c44d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182085
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-02-27  Miklos Vajna  <vmiklos@collabora.com>  [e36643877e5ddf57a34481f1c46f87cf250caf19]

        cool#11226 sw per-view redline on: move the setter to the model
        
        Open e.g. an RTF file with \revisions in it (enable track changes
        recording), notice that track changes is not enabled, when the UI would
        take the "redline on" setting from the view.
        
        Commit 025a1e4612fecf59f38910fbf52fc63db054ae5f (cool#11226 sw per-view
        redline on: add new flag in SwViewOption, 2025-02-26) added the per-view
        "is record" setter to SwEditShell, but I missed that this setting can be
        also set by an import filter, which works on an SwDoc with no view.
        
        Fix this problem by:
        
        - remove the setter from SwEditShell::SetRedlineFlags(), we'll do this
          in the model instead
        - use sw::DocumentRedlineManager::SetRedlineFlags_intern() everywhere,
          so we have a central point where the current view (if there is any)
          can be updated together with the model
        - implement the model -> current view synchronization in
          sw::DocumentRedlineManager::SetRedlineFlags_intern()
        - extend the the SwView ctor, so the setting of the view is not the
          default, but it's based on the model
        
        Also make it explicit that RedlineFlags::Ignore is not something a user
        may set. With this rearrangement, implementing a getter (that takes the
        view into account) looks possible, but is not yet done in this commit.
        
        Change-Id: Ifc0c3bbb95539cc1a26582ee7d27653899fbc236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182304
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-27  Jonathan Clark  <jonathan@libreoffice.org>  [fac5695974d8a2197edba1e9f69f86621196cae1]

        tdf#164140 sw: Fix invalid string indices in kashida justification
        
        During layout, Writer has to mark certain lines and positions as
        ineligible for kashida. These lines and positions are stored using
        string indices on a per-paragraph basis.
        
        This change fixes a bug causing corruption of these kashida
        ineligibility indices during editing. Writer tries to reuse the existing
        layouts of lines whenever possible. Since these kashida indices are
        computed at the same time as layout, and the paragraph-relative subrange
        of a line may be different after inserting or deleting text in previous
        lines, the stored indices would point to different parts of the
        paragraph string than intended.
        
        Change-Id: Idb67d0a217841dc0743ed716ef8214d10e7b560b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182286
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-02-27  Robin Candau  <robincandau@protonmail.com>  [406afe11711df9fcabbc829fcff00aef2f44c1d9]

        tdf#165433 Fix PDF imports with (system) poppler >= 25.02.0
        
        Since poppler 25.02.0, GlobalParams doesn't have a constructor
        that accepts a nullptr anymore,
        see upstream poppler b50390f748b59cb0a64b912636ecf6527bd0d12a commit.
        
        As such, the data directory location defined for SYSTEM_POPPLER
        needs to be updated accordingly (when SYSTEM_POPPLER >= 25.02.0),
        otherwise PDF imports fail with
        "General Error / General input/output error".
        
        Change-Id: I2a60b03a9ae20aab8d36db2a6827f1f3b9618115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182282
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-27  Andras Timar  <andras.timar@collabora.com>  [660d2140c344bfafd2776e633e9b29e5fb2d5295]

        Remove notice/license info about Apache Jakarta HttpClient
        
        It was removed from the project in 2015.
        cf. f7d149a731a0 swext: remove commons-httpclient dependency from Wiki Publisher
        
        Change-Id: Id6f6bcc5aa6f78fd0ed4c06dab4c4587616f6d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182222
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-02-27  Andras Timar  <andras.timar@collabora.com>  [1afd59ece7844ccd105ac13ca29dedcccfc6eddf]

        Remove notice/license info about Apache Tomcat
        
        Apache Tomcat was removed from the project in 2013.
        cf. 2c92030ff07a Kill servlet-api and tomcat
        
        Change-Id: Iaaeeda26fe983721cec74da3761fe55740f1e957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182221
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2025-02-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e1e6f5c7d029af3e2942a6cc5a5aff26d1971904]

        Remove workaround for old Android NDK
        
        ...which had been added with 41ab6a5dfa0bbc67c726ba872e9ef85fde67a394 "struct SN
        needs a strict weak ordering operator <" and should no longer be necessary
        since2b68bf57789714bf79b5bd1fc3e4e9ad586b7c31 "android: Update minimum NDK
        version to 27"
        
        Change-Id: I8a2fb01804ed6220bb927175992b4d5015b0d7e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [f6a2c26be19631b2f39b39ae0a56ba396c386d65]

        Simplify SwTextGuess ctor
        
        Change-Id: I112e66387d0d147b68119cceb9ba00af904c5c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182141
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-27  Oliver Specht  <oliver.specht@cib.de>  [c628a26cd3f763b39a2e2441fc766dabf04ed492]

        tdf#90293 switch draw selection to rotate mode
        
        Clicking a draw object(selection) switches to rotate mode and
        back in Calc/Writer like it is done in Draw/Impress already.
        By default this function is off an can be activated in
        via toolbar Drawing
        
        Change-Id: I4a11d008e7df97c5278cae987d5c47fa50cddf14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181169
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-27  Pranam Lashkari  <lpranam@collabora.com>  [19df53668c2078015e7135aaca261093f5c4dc0a]

        tdf#162070: enclose delimiters in in formula inside quotes
        
        problem:
        1. some characters were not correctly interpreted inside formulas
        casuing them to appear as inverted question mark.
        2. when some special symbols like 'abs' were inserted as normal string
        were replaced with symbols and sometimes also causing to invalidate formula
        and add inverted question mark
        
        Note:
        So in MSO if you use operator with spaces on either size it will be treated as
        literal and when you use them without space in either side it will be operator.
        This same thing goes for all operators.
        
        In libre office you will be able to see visual difference
        in operator and literal one is slightly bold than other.
        
        Change-Id: Id1b0cda36727c1749619adc858b27212057b37e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176421
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-27  Miklos Vajna  <vmiklos@collabora.com>  [b8400fe4d3b8aa2b2efd57479cd8c445674e391e]

        oox: fix outdated comment
        
        After commit 1bec1608a55c1b5096e7a9d06564c658bd5be1d5 (tdf#165132 DOCX
        import: fix unexpected rotation on entirely vertical line, 2025-02-26).
        
        Change-Id: Ia23d0f03edffa1fdfe25521e3b19e4e7be654f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182274
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-27  Bayram Çiçek  <bayram.cicek@collabora.com>  [3b3ba9c329b691ef600ad9ecc419e818b385ce0e]

        tdf#123225 - export <i t="grand"> of row/colItems
        
        in xl/pivotTables/pivotTable*.xml.
        
        - we should always export (.ods to .xlsx) <rowItems> and <colItems>, even if
        the pivot table does not contain col/row items. Otherwise:
          1) Excel will fail to open the xlsx document, you will get an error message.
          2) Excel will open the file without any errors but:
            2.1) context menu -by right clicking on the pivot table- will have less
                 or more items than it should have after "refresh".
            2.2) if e.g. trying to sort the items you will get "Cannot determine
                 which PivotTable field to sort by" warning.
        
        - we should add t="grand" to the last <i> element. Otherwise, Excel will not
        have all functions in the context menu of the pivot table. Especially for the
        "Grand Total" column/row cells. we shouldn't need "refresh" to use all
        functions/items in the context menu.
        
        - note: it is not completely clear that the last <i> element always gets
        t="grand". however, testing on the some docs indicate that t="grand"
        should be in the last <i> element.
        
        - added testTdf123225PivotTableNoColItems unit test to check if
        <i t="grand"> exported. also, added some useful information in the
        comment section for future tests/issues.
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I22b42ddb4a27c4b7b88ad8a71376c2c82d5a735a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182242
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-27  Mohamed Ali  <mohmedali1462005@gmail.com>  [47372b4650cb3a214ccf8f0947e1e652a5516793]

        tdf#97228 Move include file BitmapDuoToneFilter.hxx to vcl/inc/
        
        Change-Id: I0cbe932889c56b63fa463e50d92605fafaf0907b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181837
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5440abe0520404709b62679041fb2f3681e6ae6f]

        tdf#165190 Karasa Jaga: simplify 128x128_writer_doc-p.svg
        
        Change-Id: Idee9c9893b29bc4a9d441e5a4567ff30f9108ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182247
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2025-02-27  Jim Raykowski  <raykowj@gmail.com>  [5830f1f2941652895187b252b202b6042bb72c76]

        tdf#157249 Show deleted headings tracked changes in the Navigator
        
        only when show tracked changes is on
        
        Change-Id: I941d0af303f962dfca28ba11f449bda812c99aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170810
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [a80dec4e7bfb64d5331fe59d0feaeede636376f4]

        [API CHANGE] Drop css::drawing::XPresenterHelper
        
        As the interface's documentation says:
        
            /** This interface is a collection of functions that were necessary to
                implement larger parts of the presenter screen as extension.  The
                methods of this interface give access to services that could only be
                implemented in the Office core, not in an extension.
        
                <p>As the presenter screen is no extension any more, this hack can go again;
                it just needs clean-up.</p>
            */
            interface XPresenterHelper
        
        Now that all uses of the interface have been replaced
        by using the concrete sd::presenter::PresenterHelper
        class directly in previous commits (see the
        `git log --grep="sd presenter"` output), drop the interface.
        
        Take over method documentation to PresenterHelper.
        
        Now that PresenterHelper no subclasses XPresenterHelper,
        further cleanup/simplification is possible in upcoming commits.
        
        Change-Id: Ie7bdad151d28762af1710db896bfaa1026dae65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [907b39ef3e8efb4bffa2ecd5e83cd098ca8ba997]

        sd presenter: Drop unused includes
        
        Change-Id: I84413fce55937b5189e93d36336067e913287d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182258
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [11310df933bb9ae33ef0f998911405bf22b6b854]

        sd presenter: Use concrete PresenterHelper in PresenterPaneBorderPainter
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: I66e49f35a5297142b14c20014df83ed5dc0543ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182257
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [d762415f1ae2756f17f1d5935ca9bd9287dea18f]

        sd presenter: Use concrete PresenterHelper in PresenterBitmapContainer
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: I69ff78bcb1988b218fbdd5f57f7110df6bd72664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182256
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [3b3a00372b7aacf4e24e1b380024bc361f8bdc07]

        sd presenter: Use concrete PresenterHelper in PresenterPaintManager
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: Iaf7c1561c87150655de4a8d60b746360454230f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [8e0c9e4139fc808ce10afa9f5721e24ac91f5b7a]

        sd presenter: Use more rtl::Ref instead of uno::Reference<XPresenterHelper>
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: I3f8895ecf0de161a696aca0dc915b4f33c336440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182254
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [320b12921a1171ae3b81fe1fb153f34e9895fe2e]

        sd presenter: Use rtl::Ref for PresenterPaneBase::mxPresenterHelper
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: Iac824d48d682fd68b21cdaa79ffe8d1e103a20e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182253
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [56bb84fe410ee3f52bbd869cbadd36aa0d5fe40d]

        sd presenter: Use rtl::Reference
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: Ieb424ede4db71a4bb488654b935d6e130ed14b31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182252
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [87d89848ea275249a5a22b9655bf3cee51d1485e]

        sd presenter: Use rtl::Ref for PresenterButton::mxPresenterHelper
        
        See
        
            Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 16:01:59 2025 +0100
        
                sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        for more background.
        
        Change-Id: I4799e1233c4478807d5975a97a4242cf9b98cb37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182251
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [9bb7e3bdb4facb5d04550fbdd187d2df34fa0892]

        sd presenter: Use rtl::Ref for PresenterController::mxPresenterHelper
        
        ... now that it's known to be an sd::presenter::PresenterHelper
        after
        
            Change-Id: I9e65b907eca64c0abcafee3423fb21d2a657d850
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 15:18:51 2025 +0100
        
                sd presenter: Call PresenterHelper ctor directly, drop service
        
        Similar simplification is possible elsewhere to continue the
        cleanup mentioned in offapi/com/sun/star/drawing/XPresenterHelper.idl:
        
            /** This interface is a collection of functions that were necessary to
                implement larger parts of the presenter screen as extension.  The
                methods of this interface give access to services that could only be
                implemented in the Office core, not in an extension.
        
                <p>As the presenter screen is no extension any more, this hack can go again;
                it just needs clean-up.</p>
            */
        
        Change-Id: I807bc1ba0d4253329813190ca89cde93bb8f64b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182240
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [6817c8de91905ebb0647b8a9b556827a44d60198]

        sd presenter: Call PresenterHelper ctor directly, drop service
        
        Instead of creating instances of sd::presenter::PresenterHelper
        by using a "com.sun.star.drawing.PresenterHelper" service
        and a factory to create them, call the ctor directly.
        
        Drop the now unused service/component.
        
        The use of UNO abstraction seems to be historical only, see the
        
            /** This interface is a collection of functions that were necessary to
                implement larger parts of the presenter screen as extension.  The
                methods of this interface give access to services that could only be
                implemented in the Office core, not in an extension.
        
                <p>As the presenter screen is no extension any more, this hack can go again;
                it just needs clean-up.</p>
            */
        
        comment in offapi/com/sun/star/drawing/XPresenterHelper.idl,
        introduced with
        
            commit ea91c7d90d74e1ca039ba669b5d3e14fa359c0fa
            Author: Stephan Bergmann <sbergman@redhat.com>
            Date:   Wed Nov 21 17:19:28 2012 +0100
        
                Turn presenter screen from bundled extension to plain code
        
        Change-Id: I9e65b907eca64c0abcafee3423fb21d2a657d850
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182239
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [d38795dfc3f749272e8d4b161c5ffbd5e17571ee]

        sd presenter: Move PresenterHelper.hxx to sd/inc
        
        This is in preparation of using the PresenterHelper
        class directly PresenterController instead of the
        XPresenterHelper UNO interface.
        
        Change-Id: If1896a4514b1f5a39091c4a154d8bc53dc752ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182238
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [e34fbd4c70f00409b9566ee28d924123e31311e5]

        sd presenter: Get rid of sdext::presenter::PresenterHelper
        
        Turn sdext::presenter::PresenterHelper::GetSlideShowController
        into a local helper function in the only source file using
        it and drop the sdext::presenter::PresenterHelper namespace
        altogether.
        
        This also helps avoid confusion because there's also
        a sd::presenter::PresenterHelper class that's something
        completely different (s. sd/source/ui/presenter/PresenterHelper.hxx).
        
        Change-Id: I91478fe14190acc9cafe4d91962b5f068f3d0223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182237
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [17f86b2241c853ece57f72a593daf2b6ea678abe]

        sd presenter: Define full screen URL where it's needed
        
        The
        
            Provide access to frequently used strings of the drawing framework.
        
        comment looks outdated, because
        sdext::presenter::PresenterHelper::msFullScreenPaneURL
        is only used in a single place.
        
        Turn it into a constexpr variable in that source file
        instead.
        
        Change-Id: I70738df9ab127c9332f0ee40db24eb6b291d9f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182236
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-27  Christopher Sherlock  <chris.sherlock79@gmail.com>  [e4f7dd75937e9f7eaf92c7e9e244a03a3f17f48d]

        vcl: simplify Animation::Invert()
        
        Regardless of whether all the frames are inverted, the animation bitmap
        will always be inverted. Thus, we can invert the bitmap first, and then
        start inverting all the frames. This simplifies matters because we can
        just exit the function with a false return if the invert fails on any
        animation frame.
        
        Secondly, this allows us to convert to a for range loop.
        
        Change-Id: Ifa8152e9903bfc53634b67c8933b50915e7a194f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182050
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-02-27  Christopher Sherlock  <chris.sherlock79@gmail.com>  [08d940d3b7b194808385bd25bac6aa3160013e17]

        tdf#74702 vcl: make OutputDevice classes aware of animation capability
        
        Not all OutputDevice classes can animate. In fact, the only class that
        can do this currently is WindowOutputDevice, everything else is a static
        image.
        
        Rather than check what type of class is being used, I'm introducing
        CanAnimate().
        
        Change-Id: I56339214e388aee2e7a564cf10a3f92629f0a6ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182049
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-02-27  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [74ea65cfb29098171cbef1b003da1424f57fece1]

        Add firebird intl DLLs for code signing
        
        Change-Id: Ic67f51ddc2e8957c4cc228a98a888a4129aac36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182198
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-02-27  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [31653943cddff60a31fe0c31c09c555b6f4a77d7]

        tdf#160568 start signing cli DLLs as well
        
        There does not seem to be any downside not signing those anymore (the
        2007er commit excluding them mentions rebasing, which is no longer
        used), and according to tdf#160568 a number of upsides. So lets start
        doing it now.
        
        Change-Id: If56a8c94dcbf431b55929142ddcb24a671e93a6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182213
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [55290b09d139fb73ea8a29adb03f96ca26fb792e]

        vcl a11y: Drop XTypeProvider::getImplementationId overrides
        
        They all do the same as their base class implementations.
        
        Change-Id: Ib6055b51f0417a7d76973989420b4ba910bc6d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182261
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [9d136ee0df1f0a5d40078823828b543f944fa4e7]

        sd slidesorter a11y: Drop AccessibleSlideSorterObject::ThrowIfDisposed
        
        Use the base class OCommonAccessibleComponent::ensureAlive
        directly instead.
        
        Change-Id: Idcba10f4c8d9fef18ffc7d4c71d8a129f464c3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182249
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [deb08fdad2f95fc288b15fca5c6fab8b3804a74e]

        sd slidesorter a11y: Use OAccessibleComponentHelper for items
        
        Similar to how
        
            commit b5d197cf4b4fc5f4e6aca5e01e2cc9757293c63e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 11:51:40 2025 +0100
        
                valueset a11y: Use OAccessibleComponentHelper for ValueSetAcc
        
        did for ValueSetAcc, also derive
        from OAccessibleComponentHelper for AccessibleSlideSorterObject
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        AccessibleSlideSorterObject::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed when testing
        this with Accerciser and Orca and the qt6 VCL plugin
        with the "Slides" pane in Impress.
        
        Change-Id: I7a7fe4c3e82632e46ac5406e366ee4763f239ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182248
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [4a5c1d4e7394d099fb61853ca634e93200a53ee2]

        sd slidesorter a11y: Use rtl::Reference to concrete class
        
        Use rtl::Reference<AccessibleSlideSorterView> for
        AccessibleSlideSorterObject::mxParent. This simplifies
        the code using it.
        
        Change-Id: I5e41738521c0a849ff864c9a57e539566a8dbeb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182229
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [c242747b61988ed5d6dcabbfee29f6d176a9e29d]

        sd slidesorter a11y: Use OAccessibleComponentHelper
        
        Similar to how
        
            commit b5d197cf4b4fc5f4e6aca5e01e2cc9757293c63e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 11:51:40 2025 +0100
        
                valueset a11y: Use OAccessibleComponentHelper for ValueSetAcc
        
        did for ValueSetAcc, also derive
        from OAccessibleComponentHelper for AccessibleSlideSorterView
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        AccessibleSlideSorterView::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        Calling AccessibleSlideSorterView::Destroyed
        from the dtor (which would notify listeners
        that the object is disposed is no more needed
        as the base class OCommonAccessibleComponent::disposing
        does that, and the OCommonAccessibleComponent dtor
        calls OCommonAccessibleComponent::ensureDisposed.
        
        No change in behavior intended or observed when testing
        this with Accerciser and Orca and the qt6 VCL plugin
        with the "Slides" pane in Impress.
        
        Change-Id: Ic7e6ff1450ced8fb88eca57d607dc27d6c0b9e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182228
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [52cd46ca7f5d3b256fc1aec733d58a00c33ef6d1]

        sd slidesorter a11y: Drop redundant and misleading comments
        
        Some of the comments simply repeat what the documentation
        for the corresponding XAccessible* interface already states.
        
        Others seem incorrect or at least misleading/confusing, for
        example:
        
            /** The default implementation returns an empty rectangle.
            */
             virtual css::awt::Rectangle SAL_CALL getBounds() override;
        
        It's unclear what "the default implementation" refers to here:
        The base class XAccessibleComponent::getBounds is purely virtual.
        The actual implementation in this class,
        AccessibleSlideSorterView::getBounds, does not return an empty
        rectangle, but actually calculates the bounds of the slide sorter
        view.
        
        The same repeats similarly for other comments.
        
        Drop that kind of AccessibleSlideSorterView comments to reduce
        confusion. Leave others that look more useful at first sight.
        
        Change-Id: I30e9c3c59cec932e8ade7ecd9afb707eb654c7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182227
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [299f205898f102034a3d3800b5ad726f4e6bb354]

        thumbnailview a11y: Dispose ThumbnailViewItemAcc objects
        
        This is the ThumbnailViewItemAcc variant of
        
            commit b3c460980c34d2d9f91120823bb525ece7bc2fac
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 12:33:21 2025 +0100
        
                valueset a11y: Dispose ValueItemAcc objects
        
        and fixes the problem/assert described in
        
            Change-Id: Ie4e5c300ff6bdb160e756e7173c45c0f143fac69
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 26 11:14:04 2025 +0100
        
                thumbnailview a11y: Use OAccessibleComponentHelper for ThumbnailViewItemAcc
        
        in the same way as the above-mentioned commit
        b3c460980c34d2d9f91120823bb525ece7bc2fac fixed it
        for the corresponding ValueItemAcc issue mentioned in
        its commit message.
        
        Change-Id: Id2ec7a3bd6311ea63f718f5136f68f2ea94be5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182226
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [1c3d0bc25f1a8bc506fecca7bf39d78f7f817ad3]

        thumbnailview a11y: Use OAccessibleComponentHelper for ThumbnailViewItemAcc
        
        Similar to how
        
            commit e7dc7ebc9e14447a4ab75502a378f632a910c394
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 12:14:24 2025 +0100
        
                valueset a11y: Use OAccessibleComponentHelper for ValueItemAcc
        
        did for ValueItemAcc, also derive
        from OAccessibleComponentHelper for ThumbnailViewItemAcc
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        ThumbnailViewItemAcc::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed initially
        when testing this with the ThumbnailView for "Recent Documents"
        in the LO Start Center with Accerciser and Orca and the qt6
        VCL plugin.
        
        However, when closing LO, this now triggers an assertion:
        
            soffice.bin: /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed.
        
        This is the same preexisting issue as already described
        in more detail for ValueItemAcc in the above-mentioned
        commit (items don't get disposed) and will be addressed
        in an upcoming commit.
        
        Change-Id: Ie4e5c300ff6bdb160e756e7173c45c0f143fac69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182225
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [9b70943c2837bbdd68b6120df1a26ed15e92670c]

        thumbnailview a11y: Use OAccessibleComponentHelper for ThumbnailViewAcc
        
        Similar to how
        
            commit b5d197cf4b4fc5f4e6aca5e01e2cc9757293c63e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 11:51:40 2025 +0100
        
                valueset a11y: Use OAccessibleComponentHelper for ValueSetAcc
        
        did for ValueSetAcc, also derive
        from OAccessibleComponentHelper for ThumbnailViewAcc
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        ThumbnailViewAcc::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed when testing
        this with Accerciser and Orca and the qt6 VCL plugin
        with the ThumbnailView for "Recent Documents" in the
        LO Start Center.
        
        Change-Id: Ia875bb290acb12137f74defa5c5ab855c352a0ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182217
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [1c269af407824997139e73e79fb262725b51d83b]

        thumbnailview a11y: Use #pragma once
        
        Change-Id: Icbb74ea2279c0c31d827a20e61847e77af0bcbe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182216
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [4cc1949e366902aea2de6c0118dd1432d914baca]

        thumbnailview a11y: Don't confuse x/y pos for item location
        
        Fix ThumbnailViewItemAcc::getLocationOnScreen by using
        the y coordinate of the parent's screen position instead
        of the x one when calculating the item's y position.
        
        This makes Accerciser highlight the correct area
        on screen when selecting the a11y object of one of the
        recent documents in the "Recent Documents" tab in the
        LO Start Center.
        
        Change-Id: I34ad1797e042d93bebf8dca1025c914db6dda254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182211
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [6b94da5baa8d75c709877807d6057309d9a3678f]

        thumbnailview acc: Move ThumbnailViewItemAcc to own .hxx/.cxx
        
        Change-Id: If9a7f674488f16480bcf09e3dcfa084b42b350e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182210
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [52ae7fed568bef2b7de50130de02908016ab30dc]

        convert IgnoreValues to scoped enum
        
        Change-Id: I418251421e6d0c648ac2d1579d4fa8420dc4c96b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-26  Oliver Specht  <oliver.specht@cib.de>  [7957b996cf53cdd4952817b15b41a4581316e3b3]

        tdf#165077 Align applied options to dialog
        
        Options in tools/.../draw|impress/general do not overwrite
        flags not supported in the dialog any longer.
        
        Change-Id: Ia1e8e678dd47e58d6201a36e4c57501d27429759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181440
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-26  Christopher Sherlock  <chris.sherlock79@gmail.com>  [1d98bf6caaf4582f53e3a3eb57306a95633bbb6d]

        vcl: remove commented out code
        
        The original code was from 2001, in commit aed8f7e44502be1:
        
            // in der Detailsview muss das Invalidieren intelligenter erfolgen
            //if( !(nWinBits & WB_DETAILS ))
                pView->Invalidate( INVALIDATE_NOCHILDREN );
        
        This was later translated in commit 25d571fff37ee35.
        
        The reason for the comment is now lost in the mists of time...
        
        Change-Id: I91ea3d2e918ee73ed8d017ca15c6cbbeb00e791f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179208
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d3806f5aede07d03b11c14db069f81c9b9f668c]

        tdf#160252: sc: Add UItest
        
        Change-Id: I1180a3ee8fccfa91452da006f968be16a402994e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181873
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [09e2627a83d4769983c39fb2cb260e11fce354f3]

        use more concrete UNO types in some local vars
        
        found by a little plugin I created.
        
        Plugin parked into store/ folder because it needs hand-holding
        when run.
        
        Change-Id: I2b4da7378f0becbc5f020ac9e78cd765aa0119b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181768
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4ab140ec079b86857145f5370d083b5e2c38440]

        loplugin:unusedenumconstants
        
        Change-Id: Ic5dee6225be56385a1ed4a8674dadba9a453dcb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182204
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Jean-Pierre Ledure  <jp@ledure.be>  [2953ff4682333cd81f4d53a56dd67175a5fedb18]

        ScriptForge (SF_Calc) formatting, case-sensitive arguments
        
        Next methods:
           AlignRange() =>        TMBLCR
           BorderRange() =>       LTRBUDHV
           DecorateFont() =>      BUSI
        receive a string argument describing
        what they have to do.
        
        Those arguments become case-sensitive: only
        upper-case characters are considered.
        
        Now:
           calc.DecorateFont(range, decoration := "BI")
        may be written as:
           calc.DecorateFont(range, _
                decoration := "Bold+Italic")
        which improves the readability of user's scripts.
        
        The functionality is available both in
        Basic and Python scripts.
        
        To be considered in the 25.8 documentation.
        
        Change-Id: If241f7aef2e8cbfa5b7dd240e26489790a8cca13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182232
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [26773186b57e5b8a4338294f0d3f858144d5a8dc]

        tdf#164299: sd: Add UItest
        
        Change-Id: I40689d1f59fa8ef9959cf18f78bf38739d820ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182231
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-26  Miklos Vajna  <vmiklos@collabora.com>  [1bec1608a55c1b5096e7a9d06564c658bd5be1d5]

        tdf#165132 DOCX import: fix unexpected rotation on entirely vertical line
        
        Open the bugdoc, it should have a fake left paragraph border (a vertical
        line), it shows up as horizontal.
        
        This went wrong in commit 6c09c85ec384e88c89bff0817e7fe9889d7ed68e
        (tdf#161779 DOCX import, drawingML: fix handling of translation for
        lines, 2024-06-26) where it tried to model the ODF import, but there the
        PolyPolygon and Transformation properties are set separately (in this
        order) on the line shape, while oox/ code sets it via
        SvxShape::setPropertyValues() and that leads to a wrong result.
        
        Fix the problem by switching to set the two properties one by one (and
        not in one go) at least for vertical line shapes, which leads to the
        correct result.
        
        Note that this is a minimal regression fix, a better (but more risky)
        fix would be to improve SvxShape so setting all properties in one go
        would lead to the same result. Tests which were failing while working on
        this change:
        - CppunitTest_oox_drawingml's testToplevelLineHorOffsetDOCX: manual
          testing shows this is still OK.
        - CppunitTest_sw_ooxmlexport3's testArrowPosition and
          CppunitTest_svx_unit's testPageViewDrawLayerClip: restrict this to
          entirely vertical lines for now.
        
        Change-Id: Ia0e113d476d785d9320a142bdb449843f61d5dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182207
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-26  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [35c2320dcc2e0a492d5d85133081ed040578483d]

        tdf#160252 ITEM fix ScCondFormatDlgItem usage (againII)
        
        Change-Id: Iac66fed14c6084d80c0b49badbaa1f8c6109f248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182218
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [7dddb827c921fc2b5cdca899c66417cda1822db6]

        tdf#164949: sw_uiwriter9: Add unittest
        
        Change-Id: Ic3132d100307a8aec5789d18b3e3403faf666898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182219
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d8f6291a6360e2a7694240fb27503fac734a31b]

        tdf#122756: sw_uiwriter9: Add unittest
        
        Change-Id: I763f9efc0497431cbc1150b8dbf1c8ba6bed5012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182220
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9d7ab8dde9fef6eba30d8c75f3949acec4d42ff]

        IdenticalNameAction is unused
        
        insert() is always called with the same value
        
        Change-Id: I319864f112097ce7ba3c01687cf0598789005bdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182205
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [547c67de9ffedbc893ea6132b22a1d771b6165b0]

        tdf#133146 - Enable delete shortcut to remove items
        
        Change-Id: I8d0f223f27a3de299f917467064629c205e79c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181779
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-02-26  Miklos Vajna  <vmiklos@collabora.com>  [025a1e4612fecf59f38910fbf52fc63db054ae5f]

        cool#11226 sw per-view redline on: add new flag in SwViewOption
        
        And set it in SwEditShell::SetRedlineFlags(). Existing usage of
        RedlineFlags::On is not yet changed to work with
        SwViewOption::IsRedlineRecordingOn() instead.
        
        Change-Id: Ic7c549ef765ebb3667e3ca969fe0e02eb9f5d2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182209
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [24eb7e8e01b9b2e9354c3d8fde66ee528b3e1ed3]

        tdf#164487: "Show underline" compatibility option OOXML import/export
        
        Change-Id: I8db0b3da1cdadbf4a5c279231abc96699a8761f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182189
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a877c6ce97f73906c39cf800bc61d7d99847361c]

        tdf#164487: Introduce "Show underline" MS Word compatibility option
        
        It corresponds to ulTrailSpace element in OOXML. This commit creates
        the option in officecfg, UI, ODF, and implements its initial support
        in layout.
        
        Unresolved problems (pre-existing, not created here):
        
        1. Short lines show underline unconditionally.  In the unit test doc,
        line 2 is such.  In SwTextGuess::Guess, there is the "first check if
        everything fits to line" shortcut, that skips SwHolePortion creation,
        that causes the problem.
        
        2. The first character of the trailing whitespace is underlined.  It
        is caused by AdjustCutPos only stepping back until there is a single
        character left. But to fix that,  we need to handle the "zero-length
        portion plus some extra" case.
        
        Change-Id: Icc84fcff3ae62ced198522a80b8ce6b0e12e3a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182188
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [95b497ae82c5291961f66f3bca52ab09d1dfa897]

        simplify the SearchMode enums
        
        there only needs to be one enum, not two
        
        Change-Id: Idb8c0c37737505cf6c28f26c0024c3c21a19fbb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182202
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [185df5e6b3c81eec52f54f643697e8cfee9c1454]

        speed up display of XLSX with lots of conditional formatting
        
        The biggest win here is the call to ShrinkToUsedDataArea, because
        otherwise, we end up iterating over 16384 columns, most of which are
        empty
        
        Change-Id: I92f90b82b66b3a3997890cb22432482e10f7f960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182178
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7b70df642ab07e9aabf03d40eb0e02864a30583]

        simplify VirtualDevice::InnerImplSetOutputSizePixel
        
        the pBuffer param is unused
        
        Change-Id: I4185d7b573734afc1a3e3903f8f30811b2d00750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [84cd2e5a712f68062429d369cc5a196f7070fd41]

        loplugin:simplifyconstruct improve warning message
        
        which was needlessly cryptic
        
        Change-Id: Ifb91631705accff3f49ec3f55b67e83532d70a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182199
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [e20cc47c0e03f3412517a3ff4ac856f6d250205b]

        thumbnailview a11y: Drop ThumbnailViewItemAcc::mbIsTransientChildrenDisabled
        
        See also
        
            commit 91ee00bcc13408eed23335770eabaf363970c526
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 18:44:24 2025 +0100
        
                valueset a11y: Drop ValueItemAcc::mbIsTransientChildrenDisabled
        
        which did the same for ValueItemAcc.
        
        Change-Id: Iac03d27aa67bc3379c51827131e92570fa1a11a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182197
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [5003e1d57dfd39d35859bc17482b5f83bf4136eb]

        thumbnailview a11y: Drop always false param
        
        See also
        
            commit d144891269f8b2431d0c954c71894ef525a89335
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 18:33:56 2025 +0100
        
                valueset a11y: Drop always false ValueSetItem::GetAccessible param
        
        which basically did the same for ValueSetItem.
        
        Change-Id: Ibb2b2d23926e618c3380a4b7aff0115fdea41a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182196
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [bb5f3c008bfad784ac390206ba73ce167dfb774d]

        thumbnailview a11y: Simplify ThumbnailViewItemAcc::getAccessibleIndexInParent
        
        This is basically the same as
        
            commit 921609b4b01d65f840233cf332b76b26fcb10b15
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 18:07:43 2025 +0100
        
                valueset a11y: Simplify ValueItemAcc::getAccessibleIndexInParent
        
        , but now for ThumbnailViewItemAcc. See the above commit for more
        details.
        
        Change-Id: I73cc73e195187fe74dac89e33cf8f23aa1ea8b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182185
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [cb1615948b6a9f23fc6b47d76c64078921717af6]

        thumbnailview a11y: Rename ThumbnailViewItemAcc::mpParent
        
        Same motivation as in
        
            commit 8f0b672a1ac712c75227e9497aa812e17724638b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 15:04:32 2025 +0100
        
                valueset a11y: Rename ValueSetAcc::mpParent to mpValueSet
        
        The object referred to by ThumbnailViewItemAcc::mpParent
        is the ThumbnailViewItem for which this is the accessible
        object, not any parent widget/accessible, so rename
        to avoid confusion.
        
        Also rename ThumbnailViewItemAcc::ParentDestroyed
        accordingly.
        
        Change-Id: I186b59a23ab6b9b18a713bdd6929594edda3a404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182184
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [a67a353b0387858627e1e33d41e3604f89ec4514]

        thumbnailview a11y: Rename ThumbnailViewAcc::mpParent
        
        Same motivation as in
        
            commit 8f0b672a1ac712c75227e9497aa812e17724638b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 15:04:32 2025 +0100
        
                valueset a11y: Rename ValueSetAcc::mpParent to mpValueSet
        
        The object referred to by ThumbnailViewAcc::mpParent
        is the ThumbnailView for which this is the accessible
        object, not any parent widget/accessible, so rename
        to avoid confusion.
        
        Change-Id: If188f8bce7e47223ac89c03e5300b89fd38e302c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182183
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [0b92534cd705862f8610ef68464c8934bb18a419]

        thumbnailview a11y: Drop misleading comment
        
        ThumbnailViewItemAcc::getLocationOnScreen is supposed
        to return the position of the object itself (not its parent)
        in screen/global coordinates, so the
        
            // get position of the accessible parent in screen coordinates
        
        comment is rather misleading.
        
        Change-Id: Iaf371b7b7644b2f08831588baa7f306b285fb46e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182182
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [b3c460980c34d2d9f91120823bb525ece7bc2fac]

        valueset a11y: Dispose ValueItemAcc objects
        
        So far, the ValueItemAcc objects created by
        ValueSet were never disposed.
        
        While this is a preexisting issue, this started triggering
        crashes with the qt6 VCL plugin after
        
            Change-Id: If448008b3a6dc7b22a06b6ed551b08a40b2d5de3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 12:14:24 2025 +0100
        
                valueset a11y: Use OAccessibleComponentHelper for ValueItemAcc
        
        as described in its commit message.
        
        Fix this by disposing the objects in ValueSet::ImplDeleteItems,
        and not just sending an AccessibleEventId::CHILD event.
        
        Adjust the logic to be independent of whether the item is visible,
        but instead do this for all items that have an associated ValueItemAcc.
        Add a new `bCreate` param to ValueSetItem::GetAccessible and pass
        false here to avoid creating new ones.
        
        In the ValueSet dtor, call `ImplDeleteItems` before invalidating
        the accessible object, as it may still be needed in `ImplDeleteItems`
        to send the events.
        
        This fixes the crash on exit for the scenario described in the
        above-mentioned commit.
        
        Backtrace of such a crash/assert:
        
            soffice.bin: /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed.
            [New Thread 9546.9547]
            [New Thread 9546.9548]
            [New Thread 9546.9549]
            [New Thread 9546.9557]
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (rr) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ff8c289de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007ff8c2849d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ff8c28324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007ff8c2832418 in __assert_fail_base
                (fmt=0x7ff8c29b6ca0 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7ff8c0f27cc6 "rClients.end() != rPos && \"AccessibleEventNotifier::implLookupClient: invalid client id \" \"(did you register your client?)!\"", file=file@entry=0x7ff8c0f360b9 "/home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx", line=line@entry=142, function=function@entry=0x7ff8c0efd262 "bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &)") at ./assert/assert.c:96
            #5  0x00007ff8c2842612 in __assert_fail
                (assertion=0x7ff8c0f27cc6 "rClients.end() != rPos && \"AccessibleEventNotifier::implLookupClient: invalid client id \" \"(did you register your client?)!\"", file=0x7ff8c0f360b9 "/home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx", line=142, function=0x7ff8c0efd262 "bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &)") at ./assert/assert.c:105
            #6  0x00007ff8c10eb4c8 in (anonymous namespace)::implLookupClient (nClient=24, rPos=...) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:140
            #7  0x00007ff8c10eb938 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing (_nClient=24, _rxEventSource=uno::Reference to (ValueItemAcc *) 0x558da6f7a220)
                at /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:185
            #8  0x00007ff8c10e751d in comphelper::OCommonAccessibleComponent::disposing (this=0x558da6f7a220) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:61
            #9  0x00007ff8c0b3cee0 in cppu::WeakComponentImplHelperBase::dispose (this=0x558da6f7a220) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase.cxx:104
            #10 0x00007ff8bb84a0c5 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose (this=0x558da6f7a220)
                at include/cppuhelper/compbase.hxx:90
            #11 0x00007ff8c0b3cc07 in cppu::WeakComponentImplHelperBase::release (this=0x558da6f7a220) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase.cxx:79
            #12 0x00007ff8bb84d6c5 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::release (this=0x558da6f7a220)
                at include/cppuhelper/compbase.hxx:86
            #13 0x00007ff8bb8e0b95 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>::release (this=0x558da6f7a220) at include/cppuhelper/implbase.hxx:171
            #14 0x00007ff8bb97d595 in cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper, com::sun::star::accessibility::XAccessible>::release (this=0x558da6f7a220) at include/cppuhelper/implbase.hxx:171
            #15 0x00007ff8af309baa in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference (this=0x558da6f7a428) at include/com/sun/star/uno/Reference.hxx:114
            #16 0x00007ff8af321bad in QtAccessibleWidget::~QtAccessibleWidget (this=0x558da6f7a3e0) at vcl/inc/qt6/../qt5/QtAccessibleWidget.hxx:39
            #17 0x00007ff8af321c49 in QtAccessibleWidget::~QtAccessibleWidget (this=0x558da6f7a3e0) at vcl/inc/qt6/../qt5/QtAccessibleWidget.hxx:39
            #18 0x00007ff8ad8faf48 in QAccessibleCache::deleteInterface (this=0x558d9fbd0ac0, id=2147483692, obj=0x558da6eecdb0) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:173
            #19 0x00007ff8ad8fad78 in QAccessibleCache::~QAccessibleCache (this=0x558d9fbd0ac0) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:31
            #20 0x00007ff8ad8faf8d in QAccessibleCache::~QAccessibleCache (this=0x558d9fbd0ac0) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:29
            #21 0x00007ff8ad8fb027 in cleanupAccessibleCache () at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:24
            #22 0x00007ff8ae44a792 in qt_call_post_routines () at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:343
            #23 0x00007ff8ac3ddee4 in QApplication::~QApplication (this=0x558d9e8c76c0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:667
            #24 0x00007ff8ac3de29d in QApplication::~QApplication (this=0x558d9e8c76c0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:663
            #25 0x00007ff8af3d63b8 in std::default_delete<QApplication>::operator() (this=0x558d9e955870, __ptr=0x558d9e8c76c0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #26 0x00007ff8af3d7da8 in std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication> >::reset (this=0x558d9e955870, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:205
            #27 0x00007ff8af3cfcbd in std::unique_ptr<QApplication, std::default_delete<QApplication> >::reset (this=0x558d9e955870, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:504
            #28 0x00007ff8af3c7b34 in QtInstance::~QtInstance (this=0x558d9e9556e0) at vcl/qt6/../qt5/QtInstance.cxx:323
            #29 0x00007ff8af3c7c29 in QtInstance::~QtInstance (this=0x558d9e9556e0) at vcl/qt6/../qt5/QtInstance.cxx:320
            #30 0x00007ff8b9bb1c54 in DestroySalInstance (pInst=0x558d9e9556f0) at /home/michi/development/git/libreoffice/vcl/source/app/salplug.cxx:361
            #31 0x00007ff8b9ca1509 in DeInitVCL () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:629
            #32 0x00007ff8b9c9fa4f in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:241
            #33 0x00007ff8b9ca15e9 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #34 0x00007ff8c2b9f4ba in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #35 0x0000558d9330ba6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #36 0x0000558d9330ba47 in main (argc=2, argv=0x7ffd2669fb48) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Ifa7e18393edcc1889bcb390fa453c611d9345bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182174
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [e7dc7ebc9e14447a4ab75502a378f632a910c394]

        valueset a11y: Use OAccessibleComponentHelper for ValueItemAcc
        
        Similar to how
        
        Change-Id: I59643f970a54a585c9ec1f8a5ca915014f1e2991
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Tue Feb 25 11:51:40 2025 +0100
        
            valueset a11y: Use OAccessibleComponentHelper for ValueSetAcc
        
        did for ValueSetAcc, also derive
        from OAccessibleComponentHelper for ValueItemAcc
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        ValueItemAcc::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed initially
        when testing this with Accerciser and Orca and the qt6
        VCL plugin for the scenario described in
        
            commit cfe63bf67f4a2c9943f5089781d5f26f78266913
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 17:17:34 2025 +0100
        
                valueset a11y: Fix reported position
        
        However, when closing LO, this now triggers an assertion:
        
            soffice.bin: /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed.
        
        This is due to a preexisting issue that ValuItemAcc
        objects are not disposed that will be fixed separately
        in upcoming commit
        
            Change-Id: Ifa7e18393edcc1889bcb390fa453c611d9345bdc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 25 12:33:21 2025 +0100
        
                valueset a11y: Dispose ValueItemAcc objects
        
        The issue didn't trigger a crash on exit before
        this commit because AccessibleEventNotifier and
        the static `ClientMap gaClients` it uses weren't
        used before with ValueSetAcc's custom a11y event
        handling.
        (Considering to get rid of the static client map
        might be something to further consider in the future,
        but I think that makes most sense once more classes
        currently using AccessibleEventNotifier directly
        have been refactored to use OAccessibleComponentHelper).
        
        The fact that Orca currently doesn't announce the
        valueset items when moving focus between them is independent
        of this commit. Suggested upstream fix to make it work:
        https://gitlab.gnome.org/GNOME/orca/-/merge_requests/236
        
        Change-Id: If448008b3a6dc7b22a06b6ed551b08a40b2d5de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182173
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [b5d197cf4b4fc5f4e6aca5e01e2cc9757293c63e]

        valueset a11y: Use OAccessibleComponentHelper for ValueSetAcc
        
        Similar to how
        
            commit 7107db3fe773629cc511eb5922bc9c28c9c5c60a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 24 18:57:58 2025 +0100
        
                toolkit a11y: Use OAccessibleComponentHelper for grid control
        
        did for AccessibleGridControlBase, also derive
        from OAccessibleComponentHelper for ValueSetAcc
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        ValueSetAcc::getBounds implements what is needed
        to implement OAccessibleComponentHelper::implGetBounds,
        so rename the method (and drop the mutex guard from that
        method, as callers of that method in the base class take
        care of that).
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed when
        testing this with Accerciser and Orca and the qt6
        VCL plugin for the scenario described in
        
            commit cfe63bf67f4a2c9943f5089781d5f26f78266913
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 17:17:34 2025 +0100
        
                valueset a11y: Fix reported position
        
        Change-Id: I59643f970a54a585c9ec1f8a5ca915014f1e2991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182158
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [2f534f9dc9e0e7bdcf2407193e77f790d95d1e3f]

        a11y: Introduce OCommonAccessibleComponent::hasAccessibleListeners
        
        The method returns whether any accessible listeners are registered.
        
        The main motivation is to to have an equivalent for the current
        ValueSetAcc::HasAccessibleListeners implementation, in preparation
        of making ValueSetAcc an OAccessibleComponentHelper subclass (to
        reuse existing OAccessibleComponentHelper logic instead of having
        yet another custom implementation in ValueSetAcc).
        
        Change-Id: Id3ad3ba06a9d4daaa259e18641d8ad4492edfb63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182157
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-26  Arnaud VERSINI  <arnaud.versini@pm.me>  [9fddd34834e8a08c60c291b367074f40ac787b12]

        basic : use more OUString literals in basic comp
        
        Change-Id: Ib67bee7e4ba85602be266bb7acc23c52251548b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177611
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2025-02-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d9c964d809431acb978976c498d566cf26ce18bd]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I4836c66372b3d7151fed943086cb2df505d7b314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177179
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-02-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1681c11cc186b1e1a281a12f20761840e1aee57b]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I1d608d8a0a02e460ce7cd9f3fb42d464e63bfb3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177136
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-02-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7950d2900f1a959643512e7bec3a807b4916b326]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I3ef9e2f547ddbc39ccad230e4e6fb3b95dd49c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177155
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-02-26  Simon Chenery  <simon_chenery@yahoo.com>  [321881ca09ccb84a8d8c12f2aa0df9f54b2521ae]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: Id295063a5f0460ab0b66ced5be29aaaeceaa8382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182195
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [12c1596b0fd152399bed90f3d26014a32efc24e3]

        related tdf#165433: poppler: upgrade to 25.02.0
        
        Downloaded from https://poppler.freedesktop.org/poppler-25.02.0.tar.xz
        
        Change-Id: I22cf1bd4dc3d27cabd8ce291d3bafd962d3f45f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182169
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [3f3ec465e14bf55a53bf795f07c1da7527d092aa]

        tdf#164640: improve unittest
        
        * Test more levels
        * Can be reproduced with a blank document
        
        After
        
        commit 3aa4d993063a3f871f8f509ba81274a356d0dda0
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Feb 25 13:49:12 2025 +0100
        
            tdf#164640: sd_import_tests2: Add unittest
        
        
        Change-Id: I4135a757bc85fb8a3233f613263ea6b71f41efa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182187
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [db59ba7360507db722bcec5f0a4fb93017d379b0]

        tdf#165443 fix Locked config of ForceSafeServiceImpl ignored for SKIA
        
        "Use hardware acceleration" should always be insensitive in case
        of readonly config key.
        
        Change-Id: I42476c167bed11ae5f2c98a68334daf8083402e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182177
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d883aab37dc9b04ed1dccf139fca9d709d29317b]

        loplugin:constantparam
        
        Change-Id: Iba5ce1d44e52610e985e97d299571cf3387d938a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0a10d0a26343bc5c4dca188ffae6c1b5801116a]

        pPrintData param of PaintLayer method is unused
        
        ever since
            commit 3bffef8f40a0259df390575929261248f36b695f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Sep 30 14:02:59 2024 +0200
            PaintSwFrame is always called with a nullptr for pPrintData
        
        Change-Id: I66296cf73aed6f4d078d2a894f8683a802bb0118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-25  Michael Stahl  <michael.stahl@allotropia.de>  [d09f3f24c38eda633825f4ac214731db06bc9a9a]

        tdf#165330 writerfilter: fix import of redline in paragraph after frame
        
        The flag m_bIsActualParagraphFramed is reset only in
        ExecuteFrameConversion() which is called at the end of the paragraph
        that follows the one that is in the frame, so all redlines in that
        paragraph were erroneously moved to the frame; reset it when a paragraph
        ends, if the next paragraph is also in the frame it can set the flag
        again.
        
        (regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba)
        
        Change-Id: I75a18d2e7b600737958e984c135ebf6201e6f979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182181
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [3aa4d993063a3f871f8f509ba81274a356d0dda0]

        tdf#164640: sd_import_tests2: Add unittest
        
        Change-Id: Ibbfbd91ccf9eb9d27fcf80bf90cc9127a4db9813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182166
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1c1b9cfe6dcb257d7fbb091fabffcef15cadf39]

        use more concrete UNO types in some local vars
        
        found by a little plugin I created.
        
        Change-Id: If89a8fa349bb823c4e8dfa5cd9732950149d06cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b07819fbaaefacf7668560ce8872e6e34d024b3]

        use more concrete UNO types in some local vars
        
        found by a little plugin I created.
        
        Change-Id: I5ff1f279c3510dbec2d6b208b09f3cd7f55e75b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182161
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [30306fd300c876e46cf41509656187624c50222e]

        use more concrete UNO types in some local vars
        
        found by a little plugin I created.
        
        Change-Id: Ib048d80abed89da2ff3876c526c1fb48aded1546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-25  افشین ‌  <afshin@libreoffice.org>  [4332e34565823cb6fa53e33e1c6d6bdfd372ec87]

        tdf#164996 Optimize Persian (Farsi) AutoCorrect list
        
        In this patch, I have added ~100 new incorrect Persian (Farsi) words
        and removed ~1000 words that were not incorrect.
        
        The removed words were spelling variants and can not be considered
        incorrect.
        
        Change-Id: I0d9ee8e34d70e144e8ab9d920c3d9dbc4242841d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181982
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-25  László Németh  <nemeth@numbertext.org>  [33e54802ee31d4c76e7e41b714f5bfeed484bbd2]

        tdf#164903 sw inline heading: fix DOCX layout by zeroing top margin
        
        Skip top margin of the paragraph of the inline heading by
        direct paragraph formatting to fix DOCX layout interoperability.
        
        Regression from commit 56588663a0fddc005c12afaa7d3f8874d036875f
        "tdf#131728 sw inline heading: fix DOCX paragraph layout
        interoperability".
        
        Change-Id: I9fb485b08b4f3fd7506562e636151ccb6ee7b0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182138
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-02-25  László Németh  <nemeth@numbertext.org>  [e5e7e5c6d06b7af19f4ff7c2d76ff87b1e8a288e]

        tdf#164878 sw inline heading: skip non-text content, i.e. formula
        
        Formulae with style separator lost their centered position because
        of the newly introduced Inline Heading frame around the object.
        Limit Inline Heading frames only for paragraphs with text content.
        
        Regression from commit 49765a9e7be41d4908729ff7d838755276b244cb
        "tdf#48459 tdf#131728 sw inline heading: new frame style: fix DOCX export".
        
        Change-Id: Ibabc0e045045f96dbbe8cfb31f9ce319189ee72a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182127
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-02-25  Miklos Vajna  <vmiklos@collabora.com>  [88e12a83aec0ffda82195c8a1e34a255d3cfdfd5]

        cool#11226 sw layout xml dump: show some more view options
        
        Not just the view of meta chars, but all the rest.
        
        Change-Id: I6bc4d436517e56f8918a5fb8890c90df1c64a950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182149
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [263829229351b5ff509ca2cad4252971c98d2f86]

        GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel'
        
        Change-Id: Ic5cc0db44cd00dab828ed17d7e4d41d59d89cf26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182147
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-25  Michael Stahl  <michael.stahl@allotropia.de>  [b3567d7e1f08df7c050d3cec86cbb200af558172]

        tdf#165322 sw: apply formatting for multiple redlines in SwRedlineItr
        
        SwRedlineItr::Seek() assumes that redlines don't overlap, but sometimes
        they do, at least a ParagraphFormat and a Delete redline can overlap
        (unsure if that is a good idea) when imported from DOCX.
        
        Change-Id: Ic13080bfe8c9910ffef44f3e48d11c7f852427ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181961
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [8351c54ee1c0f915f6378d58216432cec4a610d0]

        SwPosSize -> SwPositiveSize
        
        Maybe it was obvious, but I confused it for "position + size".
        
        Change-Id: Id6b550cb4fac34d39647cc61cde0c1ffa06c03e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182146
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-25  Michael Meeks  <michael.meeks@collabora.com>  [5554fff70e5b79c4eef1a419bda1b3b831d54bdd]

        vcl: better variable naming for annotating low priority idles.
        
        Change-Id: I80dd443a864bc63b4e0214a13efdd76474daa57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182140
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2025-02-25  Gökay Şatır  <gokaysatir@collabora.com>  [5a3d715524c7b3794a24613ca55062bc2f808fec]

        Add a test for decimal separator info.
        
        Ensure that decimal separator of the number inside the cell is also sent to the server.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I5864b86ae2d1c4a582a86a0f2488f7229be7bdaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181094
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181776
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182143
        Tested-by: Jenkins

2025-02-25  Michael Stahl  <michael.stahl@allotropia.de>  [f439448d21ef2feb03a9920d95d30f23795db6ac]

        tdf#165322 sw: prefer insert/delete redline in mouse-over tooltip
        
        Unfortunately SwCursorShell::GetContentAtPos() can only report 1 redline
        for a given position; in case there is a format and a insert/delete
        redline at the same position, the latter is more important.
        
        This is then used in SwEditWin::RequestHelp() to display a tooltip if
        the user moves the mouse cursor over a redline.
        
        Change-Id: I32af7a154873e3fa5775a711980bb3dab3e307ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181960
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-25  Michael Stahl  <michael.stahl@allotropia.de>  [c5f7619d6eebe478332ae4dcb27fde85df6278a9]

        tdf#165322 sw: GetRedline() binary search doesn't work with overlaps
        
        Change-Id: I6d7a271eb96f55abdd6d53a153b277083868109b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182117
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-02-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0ab638e42184284f296fbbb9aa9465a70ae6e3bd]

        Related: tdf#164997 - sc refactor and optimize LET function calculation
        
        Fix crash because of missing new svStringName from ConvertMatrixParameters
        
        Change-Id: Ifd3b67c5709476058412cddeae53b695a83cb5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182095
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4de4466d380caff2e5765d91942c98fac7ea0eac]

        use std::string_view for TokenValue
        
        we will need the length anyway, and in the case that its constructed
        from OString then that strlen can be elided. (For the const char* case
        then std::string_view[4] will compute the len)
        
        Change-Id: Ifc06595573625cf93f07dd72ceec8a20745e12f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182123
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-25  Christopher Sherlock  <chris.sherlock79@gmail.com>  [8b998ed161f0c7e72530e5f02aa9be13edb4f703]

        vcl: move FormattedField to own file
        
        Change-Id: I00e0734ff06c307377e04e2b4d61c637616068b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179184
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [e014935a645c56182d15463c2692616c29308313]

        vcl: make control/calendar.cxx variables const
        
        Change-Id: Icb517aaf92cc6563d01827e7bc608e8b6b7930da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174729
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-25  Andras Timar  <andras.timar@collabora.com>  [6008e771f0c098e07d8efcfa7932fed58432a1b9]

        license: zxcvbn-c
        
        Change-Id: Ied2d6ac56aa3d0841f2a8241a9bb44dc44a860c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182105
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-02-25  Andras Timar  <andras.timar@collabora.com>  [0a835a608c80745315909ff5f4e72435d5a8f1c6]

        fetch frozen and zxcvbn_c optionally, system option exists
        
        Change-Id: I8d6ac530a127a724adeca38826b1f0efe3953958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182104
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2025-02-25  Andras Timar  <andras.timar@collabora.com>  [c4a9bcdab36633bd0317ecd320dada832246c9ff]

        license: dtoa.c
        
        Change-Id: I37da8258516b434d3ce6ffdf656998cbf1a9074c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182103
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2025-02-25  Michael Weghorn  <m.weghorn@posteo.de>  [819ff5b50958fc1ac630d4774ea51d644f6c8478]

        vcl: Drop RoadmapWizard::implConstruct param
        
        The only caller (the ctor) passes all of the WizardButtonFlags,
        so drop the param and simplify the code a little.
        
        The actual logic which buttons to show/hide is implemented in
        class WizardMachine.
        
        Change-Id: Ief89a116a26682e6e7210184ebe4a3dd7a54b966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182126
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-25  Michael Weghorn  <m.weghorn@posteo.de>  [bdc21628d211f1ae1c6d97aed3b830f032ae64be]

        chart a11y: Avoid const_cast
        
        AccessibleBase::BroadcastAccEvent is only called from non-const
        methods, so there is no need for it to be const itself.
        
        Drop the const qualifier and the now no longer needed const_cast
        of `this` inside the method.
        
        Change-Id: I9e8bb74d761135b1f22525fa79912f4694ca7654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182121
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-25  Michael Weghorn  <m.weghorn@posteo.de>  [cceed7e86ad2fe07d7fa4162f473fc46222910e8]

        chart a11y: Use rtl::Reference<AccessibleBase>
        
        Use an rtl::Reference of the specific AccessibleBase
        instead of a generic uno::Reference<XAccessible> and
        then still making assumptions that it's actually an
        Accessible object in various places.
        
        Change-Id: Iaccccc3e928d4f47b16b4681404b6c6169ac67c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182120
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [37216049f1a699a3269f0e19ee514e814b965266]

        tdf#165420: handle empty arguments correctly
        
        Change-Id: Ib30cce816b2af8a780e09fa04a2129afd91fafe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182118
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-25  Pranam Lashkari  <lpranam@collabora.com>  [f6944d251f6eb4ad2bcf6cee6027a83e44d72364]

        sc comment: use standerd ISO date format for comment
        
        problem:
        in online when comments are stored in one language (i.e: en-us)
        and opened in another language(i.e: de) it caused months and
        day to be swapped which caused incorrect date stamp for comment
        
        Change-Id: Ibaf3a5cc30389f261c14381356dbc8bdcf794639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182093
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182119
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [91ee00bcc13408eed23335770eabaf363970c526]

        valueset a11y: Drop ValueItemAcc::mbIsTransientChildrenDisabled
        
        As is obvious since
        
            Change-Id: Iff97c47023e1a5d1f0758d0a898312f234479ff5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 18:33:56 2025 +0100
        
                value set a11y: Drop always false ValueSetItem::GetAccessible param
        
        , this member is always set to `false`, so drop it altogether.
        
        Change-Id: I13062998ddb42edc91d752fd2c103f83973619e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182115
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [d144891269f8b2431d0c954c71894ef525a89335]

        valueset a11y: Drop always false ValueSetItem::GetAccessible param
        
        Since
        
            Change-Id: I502c4e2271c65dc4d4c35d1f22e247b0b6ea98b9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 18:07:43 2025 +0100
        
                value set a11y: Simplify ValueItemAcc::getAccessibleIndexInParent
        
        , all callers explicitly pass `false` for the param, so simply
        drop it.
        
        I also don't see how `true` could ever have been passed before the
        above commit, because all callers explicitly passing either true or
        false were already passing false, and the 2 callers dropped
        in the above commit were passing the value of
        ValueItemAcc::mbIsTransientChildrenDisabled, which must be from
        a  ValueItemAcc created earlier (with the `false` parameter
        passed to ValueSetItem::GetAccessible).
        
        Now that false is already passed, ValueItemAcc::mbIsTransientChildrenDisabled
        can be dropped altogether in an upcoming commit.
        
        Change-Id: Iff97c47023e1a5d1f0758d0a898312f234479ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182114
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [921609b4b01d65f840233cf332b76b26fcb10b15]

        valueset a11y: Simplify ValueItemAcc::getAccessibleIndexInParent
        
        Instead of calling ValueSetItem::GetAccessible
        on various ValueSetItems (first in a loop, and the first item later)
        in order to compare whether their returned accessible is self (`this`),
        instead check whether the ValueSetItem is
        `ValueItemAcc::mpValueSetItem`, i.e. the ValueSetItem for which
        `this` is the accessible object.
        
        Before and after this change, the reported child index is as expected
        in both, Writer's "Format" -> "Paragraph" dialog's "Borders" tab (see
        
            Change-Id: Id31a321c6bec2a3ef9a1cbb2e5264eb6deabc57f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 17:17:34 2025 +0100
        
                value set a11y: Fix reported position
        
        for more details on how to get to the object of interest
        in Accerciser.) and in Calc's "Format" -> "Cells" dialog, "Background" tab
        when enabling the "Color" option when testing with the qt6 VCL plugin.
        (The single color rectangles in the palette are ValueSetItems,
        and when querying their index in the parent in Accerciser's IPython console,
        it matches, i.e. is n for the n-th child of the ValueSet.)
        
        Change-Id: I502c4e2271c65dc4d4c35d1f22e247b0b6ea98b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182113
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [cfe63bf67f4a2c9943f5089781d5f26f78266913]

        valueset a11y: Fix reported position
        
        ValueSetAcc::getBounds needs to report its bounding
        box within its parent.
        
        However, so far the returnded rectangle would always
        have a position of (0,0), which is wrong if the ValueSet
        isn't positioned at the top left of its parent.
        
        The ValueSetAcc::getLocationOnScreen logic to get
        the position relative to the parent and add the parent's
        absolute position is correct in theory, but was wrong
        because the position relative to the parent was incorrect.
        
        Instead, use weld::DrawingArea::get_accessible_location_on_screen
        for the ValueSet's DrawingArea to get the location on screen.
        
        In ValueSetAcc::getBounds, subtract the screen location of
        the parent to convert the absolute position to one relative
        in the parent (the opposite of what ValueSetAcc::getLocationOnScreen
        was doing before this commit).
        
        Without this, an incorrect position was e.g. seen
        for the following use case when using the qt6 VCL plugin:
        
        1) in Writer, open the "Format" -> "Paragraph" dialog
        2) go to the "Borders" tab
        3) start Accerciser
        4) in Accerciser's treeview of the LO a11y, navigate to the
           "Shadow Style" panel
        
        -> The correct area is highlighted on screen
        
        5) click on its "Position" label child
        
        -> The correct area is highlighted on screen.
        
        6) click on its list child
        
        -> The wrong area is highlighted on screen: The highlight
        rectangle's left edge is at the "Position" label again and
        it doesn't reach the end of the different shadow style (ValueSet)
        items.
        
        With this commit in place, the correct area is highlighted.
        
        Change-Id: Id31a321c6bec2a3ef9a1cbb2e5264eb6deabc57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182112
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [7cfdf821078a1cfe8d77ebf39feebf3e7183abb8]

        valueset a11y: Rename ValueItemAcc::mpParent to mpValueSetItem
        
        ... for the same reasons as
        
            Change-Id: I30b516c7654022d6e9a486361b30cc5e538951ce
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 24 15:04:32 2025 +0100
        
                value set a11y: Rename ValueSetAcc::mpParent to mpValueSet
        
        did for ValueSetAcc.
        
        Also rename ValueItemAcc::ParentDestroyed to
        ValueItemAcc::ValueSetItemDestroyed accordingly.
        
        Change-Id: Ic682e27c35a78f9ff523074ff4edfd0b330783d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182099
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [8f0b672a1ac712c75227e9497aa812e17724638b]

        valueset a11y: Rename ValueSetAcc::mpParent to mpValueSet
        
        It is simply the ValueSet for which this ValueSetAcc is
        the accessible context.
        
        Having "parent" in the name seems to suggest that this is the
        (accessible) parent, which it is not, see
        ValueSetAcc::getAccessibleParent which gets the accessible
        parent of ValueSetAcc::mpParent for the actual parent.
        
        Also rename the ValueSetAcc::ThrowIfDisposed param
        accordingly.
        
        Change-Id: I30b516c7654022d6e9a486361b30cc5e538951ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182098
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [51249c967055f22c6e3509afdac2246c39e86495]

        svx a11y: Drop unused include
        
        Change-Id: I92bc817d14630fe50e0fa6edf3aef7899f4f1cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182097
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [45ca7c822ed2c45ff83af1713095cacb3273813c]

        icon choice ctrl a11y: Drop obsolete comment
        
        AccessibleIconChoiceCtrlEntry no longer
        directly implements XAccessibleEventBroadcaster
        methods since
        
            commit 1c892a7729234202e6ce14e116e91786b248835a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jul 11 16:54:09 2024 +0200
        
                icon choice ctrl entry a11y: Use OAccessibleComponentHelper as base
        
        Change-Id: Idb575ebe1a1abbc6a12570a76fe4b412f9404945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182096
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-24  Oliver Specht  <oliver.specht@cib.de>  [9ceac9e0c4297b62fc8570bb915e35972a136e71]

        tdf#164949 regression fixed
        
        Fixes regression introduced with 3e4aa127416a5947882e6644409468aa1ca039ae
        
        Change-Id: I065c626358b19f74d1838ae79717b0b630532dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181624
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-24  Andras Timar  <andras.timar@collabora.com>  [301c178a937803170a60c12be4e537ffa88e4208]

        license: add Box2D
        
        Change-Id: I1192d0b0c08ec8a5efffad1b33e6c50a4e357314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182089
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-02-24  Patrick Luby  <guibmacdev@gmail.com>  [48125efbd7bf370981d48e4a8d0ce7fbaf1857e1]

        tdf#165266 Force NSColor and native controls to use effective appearance
        
        +[NSAppearance setCurrentAppearance:] is deprecated and calling that
        appears to do less and less with each new version of macos and/or Xcode
        so run all system +[NSColor ...] calls and drawing of native controls
        in a block passed to -[NSAppearance performAsCurrentDrawingAppearance:].
        
        Change-Id: I857bfb2504ad2896579c7b2da4fdd2d591fab3b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182074
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-02-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [004c882b698489f05b21513d2e54bc58f5ad49a4]

        optimize unoxml for the common case of no listeners
        
        Change-Id: I64dcf61813c9a5dfa8a82fd0b39bad2bf916b9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182080
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-24  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [86d36ee56521438069504fbacff8dc2aff3a1afc]

        tdf165262 PPTX export: fix shape export regression
        
        When exporting a shape from PPT to PPTX, the preset shape export is
        sometimes incorrect. In such cases, we export the shapes as custom
        shapes. The export of glue points is also important, so it has been
        added to the fix.
        
        this regression is
        caused by commit I378ffffc2ba09fcffcaa4e5dcf74bfd19e9f704d
        (tdf#149126 fix export of PPTX preset shapes).
        
        Change-Id: Id4a127e7ef462611bf63da791717f8260ec51be0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182068
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2025-02-24  Simon Chenery  <simon_chenery@yahoo.com>  [eb955488499bcb92721ac6ec72b6fc95014915a0]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I97c620ddea1fb536caedddd1f3afa7f3b0f510a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182070
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2d7af5bf61d8582feb57102a492e024c2218f411]

        vcl: AnimationContainer to handle Animation with memory managing
        
        This adds the continer for Animation objects (AnimationContainer)
        which will handle memory management and swapping for Animations.
        
        Change-Id: I9f48169f3d513913d1922fe0d365a0c586931284
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180621
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-02-24  Simon Chenery  <simon_chenery@yahoo.com>  [4d6cf9434009fcbdd2445d7bcae5081595edae28]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in appuno.cxx
        
        Change-Id: I6d72f0dd0d2747b2e0041f1be1284e3f570b0363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182067
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-24  Miklos Vajna  <vmiklos@collabora.com>  [b4880f7f39a4acde5b78af8fd152d8d6bc149b93]

        sw doc model xml dump: show the redline manager's flags
        
        I'm looking at moving that RedlineFlags::On to the view.
        
        Change-Id: I9cd4d41108a19097d2bed0e1660c084ac7fe8c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182081
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-24  Christopher Sherlock  <chris.sherlock79@gmail.com>  [2068c08a9d831248863ae1e94a618dc307ba5b6c]

        vcl: remove i_ prefix and use recommend variable prefixes
        
        Change-Id: I14d4880784873efbff6746e0bc3737f19e9b9bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182028
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bf4fe0c2ba1d0a44cc07c6afba6d56b8adf8af50]

        tdf#164249 adjust XML_localSheetId to take into account not exported sheets
        
        this is to avoid failure on re-import of:
        
        XmlFilterBase::importFragment - XML parser failed in fragment 'xl/workbook.xml'
        	com.sun.star.uno.RuntimeException message: "invalid sheet index used at sc/source/filter/oox/workbookhelper.cxx:438"
        Error: source file could not be loaded
        
        Change-Id: I235edd018c4ebcd4bafa9c549bdec9f23f0bd6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182069
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-24  Miklos Vajna  <vmiklos@collabora.com>  [6daa6b730b479121c8e2d8a70d3622c464d2701c]

        svx: prefix members of GalleryTheme
        
        See tdf#94879 for motivation.
        
        Change-Id: I671da8408c1935a99a71e669c13abc3dfc687d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182075
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [135963ad72b70b391dbeaa05c1a7991b633e5d03]

        Simplify a bit
        
        No need to calculate these square roots at runtime
        
        Change-Id: I29689f4bd9bf3f5e00eccadae067973343b237b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175990
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [01ae181574d06d5ea60f9454684cb09621724f17]

        Remove readme file from SDK
        
        This file is included in the main installer.
        Doesn't make much sense to include it in the SDK, since there is
        nothing SDK specific in it.
        
        Change-Id: I44f87ff304be4a9064000e54a5246c4a4b55c68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181790
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-02-23  Simon Chenery  <simon_chenery@yahoo.com>  [1fc03eaed2899ac041f660f54cb1facb71390ccf]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I0efe76b814035aad9faa86c9dfed447759a4448b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182015
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c957fc0d669884f3d1e27fa5296e045198a6013a]

        cid#1643142 avoid Missing move assignment operator
        
        Change-Id: Ic9b3ea98f0dbdf059e22d845e7189a26586e46eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182038
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0ed956bf2a6779ae8cf9d1dc9bd17c66bd15ffb1]

        update credits
        
        Change-Id: Ib9d63c49a3105152882980d3367ecab8fb34850f

2025-02-23  Mohit Marathe  <mohit.marathe.extern@allotropia.de>  [1916957d0750b5471f23f17b2867a907e0e9e0e2]

        tdf#164936 oox: modify getColor method to include alpha
        
        Change-Id: I141be9568b54334a17f5f781f1612423bec19999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181861
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2025-02-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [28d90810aea48a1cc6c58947ecc239d935f23634]

        Fix typo
        
        Change-Id: I67217842e91b790dad832fee4cd2906cbf57c63b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182064
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-23  Julien Nabet  <serval2412@yahoo.fr>  [a123c8c86fa4668ff1f7650bc087964441672ee9]

        Try fix local variable is initialized but not referenced for ARM TB
        
        Change-Id: Ib74892d60fd2d9b9a34ef4cca4f9c7872364e0f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182063
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [7bec65cca52f297b39b909182cff544285e0969d]

        tdf#130857 qt weld: Implement QtInstanceAssistant::set_page_index
        
        As already mentioned in
        
            Change-Id: I91b44da40736f6e61c64167d00305a1d7ba06b45
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 22 18:30:30 2025 +0100
        
                tdf#130857 qt weld: Introduce QtInstanceAssistant
        
        , the page id that QWizard uses does not conceptually match
        the page index that weld::Assistant uses:
        
        weld::Assistant uses two ways to refer to specific pages:
        1) an int page index
        2) an OUString identifier
        
        QWizard uses an int id to refer to pages. This concept of an id does
        not match the index concept that weld::Assistang uses. (The id generally
        does not match an index in the range between 0 and the number of pages - 1.)
        
        Introduce a new property PROPERTY_PAGE_INDEX that
        gets set on the QWizardPage objects and contains
        the page index as used in the weld::Assistant API
        and 2 helper methods QtInstanceAssistant::pageIndex
        and QtInstanceAssistant::setPageIndex to get/set
        the page index property for a page as well as a helper
        method QtInstanceAssistant::page that returns the
        page for a given page index.
        
        Update existing code to no longer assume that
        the QWizard page ID and the weld::Assistant page index
        are the same.
        
        Implement QtInstanceAssistant::set_page_index that
        moves an existing page to a new position/index.
        Given that the IDs used in QWizard don't match the
        page indices, use a vector to sort by page index
        instead and reassign the new index property to
        all pages at the end.
        
        In a previous attempt trying to keep the QWizard page ID
        and the weld::Assistant page index in sync, I ran
        into the problem that the ID for a page cannot simply
        be changed, and removing and reinserting a page with
        a new ID had the side-effect that it triggered events.
        (And the current page can change when pages are removed
        from QWizard.)
        
        While the default QWizard logic that decides what
        page to switch to when pressing e.g. the "Next"
        button would switch to the page with the lowest
        ID greater than the current page (see [1], [2])
        in which case the page IDs would be relevant.
        However, the approach taken in LO is that the
        logic of switching pages is handled "manually"
        inside LO instead, using callbacks that get triggered
        on button click, etc.
        
        [1] https://doc.qt.io/qt-6/qwizard.html#nextId
        [2] https://doc.qt.io/qt-6/qwizardpage.html#nextId
        
        Change-Id: Idd94676e850cabca75763645cb1e102999b80b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182047
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [5c94c294299a1c21462b55c5983f22f94f33e029]

        tdf#130857 qt weld: Implement QtInstanceAssistant::append_page
        
        Do like SalInstanceAssistant and GtkInstanceAssistant
        and have a std::vector of std::unique_ptr of the already
        created pages as a class member, so they will be deleted
        with the QtInstanceAssistant object.
        
        Change-Id: I8ad2b07ee64edd3f6018b5623be20e13b1700059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182046
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [ec21ae547d2128a8c76fcc8cd05e0f6260da007c]

        vcl: Switch BuilderBase::set_response param from short to int
        
        An int is used in the end anyway for all cases
        (Dialog::add_button for the VCL implementations,
        QtBuilder::set_response for the Qt implementation).
        
        Change-Id: I3011f25d465edaed23ab1a312c6a424ee2d51198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182045
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [d05936403f84bcab08a9811d0624877e7e4bdd8c]

        tdf#130857 qt weld: Implement QtInstanceDialog::weld_button_for_response
        
        Change-Id: I16838459d981093a989eb500d8876c0b3d19d8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182044
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [94e5e5ef062b05845f341f04dfe3508c76d6a206]

        tdf#130857 qt weld: Split QtInstanceMessageDialog::buttonForResponseCode
        
        Split the existing logic from
        QtInstanceMessageDialog::buttonForResponseCode into 2 methods:
        Extract a static helper method that takes a list of buttons as
        an additional parameter and move that one to the QtInstanceDialog
        base class, so it can be reused there in an upcoming commit.
        
        No longer explicitly make sure to run the
        QtInstanceMessageDialog::buttonForResponseCode logic
        in the main thread in that class, as that already happens
        in both callers.
        
        Change-Id: I0cbc73798caf4925496b2b26be73913dae4a89b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182043
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [1c3234ace9473aa7fe596e892177bde47362d101]

        tdf#130857 qt weld: Move findButtonBox helper to QtInstanceDialog
        
        It will be reused there in an upcoming commit.
        
        Change-Id: I419d2a4d82fb179501bafe04f00bde64d256a750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182042
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [ffd236bdf85682329ed18360007c7454eb2693aa]

        tdf#130857 qt weld: Introduce QtInstanceAssistant
        
        Add new class QtInstanceAssistant as the weld::Assistant
        implementation using native Qt widgets.
        
        A QWizard is used for the widget.
        
        This commit introduces QtInstanceAssistant and adds an
        initial implementation for most of its methods.
        (Others still need to be added in the future and
        calling them currently triggers an assert.)
        
        While GtkAssistant [2] and weld::Assistant use
        indices to identify pages, QWizard uses IDs. For now,
        assume that those are equivalent. Some extra logic may
        be needed to ensure this in the future (or an implementation
        that is not built on this assumption).
        The OUString identifier used in the weld::Assistant
        API is something different and set as the QObject::objectName
        property of the pages.
        
        In QtBuilder, create a QWizard widget when encountering
        a "GtkAssistant" object in a .ui file.
        
        [1] https://doc.qt.io/qt-6/qwizard.html
        [2] https://docs.gtk.org/gtk3/class.Assistant.html
        
        Change-Id: I91b44da40736f6e61c64167d00305a1d7ba06b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182036
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [485a87fd4836593be4ec5b2ab0c8e7bf27f1c10f]

        Make "XML Filter Settings" dialog modal and set parent
        
        So far, the "Tools" -> "XML Filter Settings" dialog
        did not have a parent and was not modal.
        
        As a consequence (tested on Plasma Wayland):
        
        * With qt6 or gen, the dialog would just "disappear" behind
          the main Writer window when clicking on the main Writer window
          or moving focus there using Alt+Tab.
        * With gtk3, the dialog would always stay on top of the Writer
          window, but would still allow to interact with the Writer window,
          so when typing text, the cursor could easily move to be behind
          the dialog.
        
        Make the dialog modal and set a parent (using
        XMLFilterDialogComponent::initialize) , which makes the dialog
        consistently appear on top of the Writer main window and the
        Writer window insensitive/disabled until the dialog gets closed again.
        
        Change-Id: I79ebc20cc3c059f217de9a1a909a7c7a424ab5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182034
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [0d291789e10ea070b30c3a2fa603d890961f686e]

        tdf#130857 qt weld: Support "XML Filter Settings" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered in Writer via
        "Tools" -> "XML Filter Settings".
        
        Change-Id: Ibfb299cb746a35630bb4930789f93c73bcda1eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182033
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [9d617f6fab45fd1330edb6baf751b10960d86554]

        tdf#130857 qt weld: Support "Test XML Filter" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered in Writer via
        "Tools" -> "XML Filter Settings" -> "Test XSLTs".
        
        Change-Id: I88853d2299cda220027033c2b7e75b7ae8bae4e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182032
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [f358878e943631a236806b083287f7f33254dc56]

        tdf#130857 Define widgets in XML Filter dlg .ui files in order
        
        Switch the order in which the widgets in the .ui files
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure
        that tab focus order with the Qt-based VCL plugins is correct as well
        when using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        The dialog can be triggered in Writer via
        "Tools" -> "XML Filter Settings" -> "New".
        
        Change-Id: Icf1043da9d97efed6f1a5e1d3cb722d66f86921c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182031
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [05ce94ba091130b67e1da98e1289412440008151]

        a11y: Leave comment field in XML Filter dialog on simple Tab
        
        See similar commit for another dialog
        
            commit faa6749592b7777773a51cb6f350a39aeb67b052
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Oct 7 08:10:56 2024 +0200
        
                a11y: Leave accessible description text view on simple tab key
        
        for reasoning.
        
        The dialog can be triggered in Writer via
        "Tools" -> "XML Filter Settings" -> "New".
        
        Change-Id: I384c9bcaac9b681f7facd209e1eb39ef98ab569c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182030
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [8ab2d4f6dc8acd566644063a6ca85438fdb7791e]

        tdf#130857 qt weld: Support XSLT filter dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered in Writer via
        "Tools" -> "XML Filter Settings" -> "New".
        
        Change-Id: I75a544b0e503779a2e2224da21d91dd93e1809bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182029
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-23  Mohamed Ali  <mohmedali1462005@gmail.com>  [f4bd60261e6b8c1f7aa273bf985fa597c4e6e6dd]

        Refactor comparison operators for DateTime and Time classes
        
        Change-Id: Ia59373da6717c8705c96eecb0f1dc0016cd2dcd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181068
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ddc09464d302a6ae580d16bcd44b4e7213124fe3]

        kit: enable metadata filter
        
        Change-Id: I6814a9aa4fff5903258e92e4d1b56db1c452c49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182041
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [99a3bdc03a5f345a05596aedfe0753eea5e4e2fe]

        add Writer/Content/NonprintingCharacter to allowed list
        
        Change-Id: I18f44e52d2cd576cd5f94e77305c364f9379e45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181234
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 8ec4ffcc19124f3451118225b95f9543912bce2c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182040
        Tested-by: Jenkins

2025-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c1716f183431b700ea325f3259c18273c4c9cda5]

        preload typedetection to share it with children.
        
        Change-Id: Ia212dbf44899932880180185977e74cfbfac34c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182010
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [efc5ee18b3bcc5d45ad282662365bbb35c1fda1f]

        filter out instance metadata connections
        
        Change-Id: Iad8b06515700f88c07bd22fa31fb2deb85dde805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181144
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-22  Johnny_M  <klasse@partyheld.de>  [bd25b8521d542fcd91fce06b016fa5d040caa6f4]

        tdf#39468 Translate German comments
        
        And a spelling correction of an earlier translation.
        
        Change-Id: Ib2df159f28313a3e62b9ef08dc807d7751698c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181921
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2025-02-22  Justin Luth  <justin.luth@collabora.com>  [e4b629c1eecf8cd46007fb064179d765d55fd26b]

        tdf#165207 tdf#164201 docx: always use errata uri in docProps/core.xml
        
        This patch effectively replaces (and thus contains a revert of)
        25.8 commit d97085cc6cd2bdc3b6723d1960d0ec5fa0a48165.
        
        This fixes a longstanding bug that became more prominent in 7.6
        when mstahl renamed docx filters to promote Word 2010,
        and then again in 25.2 when my bug 164201 patches
        told command-line convert-to to export using Word 2010 filter,
        and finally in 25.8 for interactive round-tripping of existing files.
        
        So what does this patch fix?
        Basically, all of the meta-data was not being read by MS Word,
        which primarily means no create/modify dates, subject, title etc.
        Every time we saved to DOCX format (except DOCX 2007), we caused Word
        to be incapable of understanding anything in docProps/core.xml.
        Telltale sign: when MS Word round-trips with added docProps/core0.xml.
        
        The spec says that DOCX 2010 should be using
            officedocuments/2006/relationships/metadata/core-properties
        and thus our untouched 2010-era coding
        specified all of that for import and export.
        
        But reality seems to be much different than the spec,
        (and some errata-sounding documentation agrees),
        so throw the spec out the window and always write
            package/2006/relationships/metadata/core-properties
        (but only for DOCX - Excel and Powerpoint follow the spec...)
        
        That meant that I also had to rewrite our import logic,
        but that was already suggested by mstahl in
        https://gerrit.libreoffice.org/c/core/+/178048
        
        Bug 165207 doesn't affect LO in any way.
        If there was already a unit test writing out to _rels/.rels
        I would have added a test for this, but since there isn't
        I won't bother since I don't see any value in doing so.
        Plus, we already have validity checks to cover this kind of stuff.
        
        The retained the unit test ensures import logic is still correct:
        make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf158855
        
        A uiwriter4 test depends on the previous patch in this bug report.
        (See earlier versions of my patchset for details)
        
        officeotron sounds like they WANT to report invalidation errors
        based only on spec, so no point in trying to "submit a patch".
        
        Change-Id: Ib76803bf0c9f3791f9078846f00c118099ef67cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181463
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [342613810cf22fe3855b5cee12a0c6933fb18ce9]

        tdf#130857 qt weld: Support macro security dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This makes use of QtInstanceWindow::GetXWindow supported
        since
        
            Change-Id: I55637876c9b93bbbfb63459caba6c89dfd4188a9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 21 23:48:47 2025 +0100
        
                tdf#130857 qt weld: Introduce QtXWindow
        
        To trigger the dialog + file dialog:
        
        * start Writer
        * "Tools" -> "Options" -> "Security" -> "Macro Security"
        * in the "Macro Security" dialog, switch to the "Trusted Sources"
          tab
        * Click on the "Add" button in the "Trusted File Locations" section
          to open a folder picker.
        
        Change-Id: I117fcc966b1189d2d04f59a37df2f0b505c7970e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182026
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [9f3680935c15c780a3ab93fce3595a877a6b0f39]

        tdf#130857 qt weld: Demote assert about radio button word wrap
        
        Replace the assert by a warning that QRadioButton doesn't support
        word wrap, so there's little that can be done on LibreOffice side at
        the moment (other than implementing a custom widget), see QTBUG-5370 [1].
        
        [1] https://bugreports.qt.io/browse/QTBUG-5370
        
        Change-Id: I272f1916080e1ecdb04c7fdb0118b3c100c90fcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182025
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [429b08357e0c904d8096ff5830d844a199cd59b0]

        tdf#130857 qt weld: Introduce QtXWindow
        
        Similar to how gtk3's SalGtkXWindow, introduce
        QtXWindow as a class implementing XWindow via
        the TransportAsXWindow subclass.
        
        Implement QtInstanceWindow::GetXWindow
        to return an instance of this new class.
        
        In QtFilePicker::initialize, extract the
        QWidget parent from the QtXWindow if the
        parent is one.
        
        This is used e.g. in a WIP branch adding
        support for the "Macro Security" dialog
        using native Qt widgets
        (SAL_VCL_QT_USE_WELDED_WIDGETS=1) in the
        following scenario to set the proper
        parent for the file dialog.
        
        * start Writer
        * "Tools" -> "Options" -> "Security" -> "Macro Security"
        * in the "Macro Security" dialog, switch to the "Trusted Sources"
          tab
        * Click on the "Add" button in the "Trusted File Locations" section
          to open a folder picker.
        
        Change-Id: I55637876c9b93bbbfb63459caba6c89dfd4188a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182024
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [6b389c157370e3482a9093f05c292fb9934b1b60]

        tdf#130857 qt: Don't expect XFilePicker3 template in XFolderPicker2 init
        
        QtFilePicker implements both, the XFilePicker3 and the XFolderPicker2
        interfaces.
        
        While a sal_Int16 specifying the TemplateDescription to use
        is passed to the initialize method in case of XFilePicker3
        (s. FileDialogHelper_Impl::FileDialogHelper_Impl), that is
        not the case for XFolderPicker2 (s. sfx2::createFolderPicker,
        frame 2 in the below sample backtrace; a sal_Int32 with value 0
        is passed there instead).
        
        However, QtFilePicker was always expecting it and throwing an
        IllegalArgumentException and thus not executing the rest of the
        initialize method (but the folder picker would still show up and
        work otherwise).
        
        This can for example be seen for the following scenario:
        
        * start Writer
        * "Tools" -> "Options" -> "Security" -> "Macro Security"
        * in the "Macro Security" dialog, switch to the "Trusted Sources"
          tab
        * Click on the "Add" button in the "Trusted File Locations" section
          to open a folder picker.
        
        This is a preexisting issue. But in an upcoming commit that
        implements QtInstanceWindow::GetXWindow and the use of native
        Qt widgets for that macro security dialog, the fact that the parent
        widget isn't set (which would only happen further down in
        QtFilePicker::initialize) would now have the practical implication
        that the file dialog isn't properly shown as modal and blocking
        the macro security dialog that is its parent.
        
        Fix this by no longer throwing an exception when the
        first arg is not a template ID, but simply make the
        code using it conditional on that and skip it otherwise.
        
        Also extract it to a new helper method
        QtFilePicker::applyTemplate for readability.
        
        (For comparison, note how for gtk3 the XFilePicker3 implementation
        in SalGtkFilePicker is separate from the XFolderPicker2 implementation
        in SalGtkFolderPicker and only the former tries to extract a
        template ID.)
        
        Sample backtrace:
        
            1 QtFilePicker::initialize QtFilePicker.cxx 730 0x7fc196b45652
            2 sfx2::createFolderPicker filedlghelper.cxx 1217 0x7fc1a6544781
            3 MacroSecurityTrustedSourcesTP::AddLocPBHdl macrosecurity.cxx 303 0x7fc158926afc
            4 MacroSecurityTrustedSourcesTP::LinkStubAddLocPBHdl macrosecurity.cxx 298 0x7fc158926a2d
            5 Link<weld::Button&, void>::Call link.hxx 105 0x7fc1a1426331
            6 weld::Button::signal_clicked weld.hxx 1558 0x7fc1a1401fdc
            7 SalInstanceButton::ClickHdl salvtables.cxx 2955 0x7fc1a13d32b8
            8 SalInstanceButton::LinkStubClickHdl salvtables.cxx 2943 0x7fc1a13d280d
            9 Link<Button *, void>::Call link.hxx 105 0x7fc1a0cd5881
            10 Button::Click()::$_0::operator()() const button.cxx 130 0x7fc1a0ccd082
            11 std::__invoke_impl<void, Button::Click()::$_0&>(std::__invoke_other, Button::Click()::$_0&) invoke.h 61 0x7fc1a0ccd055
            12 std::__invoke_r<void, Button::Click()::$_0&>(Button::Click()::$_0&) invoke.h 111 0x7fc1a0ccd005
            13 std::_Function_handler<void(), Button::Click()::$_0>::_M_invoke std_function.h 290 0x7fc1a0cccf2d
            14 std::function<void()>::operator() std_function.h 591 0x7fc1a0cf700e
            15 Control::ImplCallEventListenersAndHandler ctrl.cxx 307 0x7fc1a0cf51cb
            16 Button::Click button.cxx 130 0x7fc1a0cb98d8
            17 PushButton::Tracking button.cxx 1321 0x7fc1a0cbf71b
            18 vcl::Window::EndTracking window2.cxx 341 0x7fc1a0c6a763
            19 ImplHandleMouseEvent winproc.cxx 713 0x7fc1a0ca4aae
            20 ImplHandleSalMouseButtonUp winproc.cxx 2351 0x7fc1a0ca9041
            21 ImplWindowFrameProc winproc.cxx 2700 0x7fc1a0ca7d55
            22 SalFrame::CallCallback salframe.hxx 311 0x7fc196b6ebac
            23 QtFrame::CallCallback QtFrame.hxx 235 0x7fc196b6bc05
            24 QtWidget::handleMouseButtonEvent QtWidget.cxx 117 0x7fc196c7c5ca
            [...]
        
        Change-Id: I008cb851d1ec1f9383e0f1e4342a2bb2a05e5c41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182023
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [d91da3c1bc953afa9acf383b6710fbcb3e2ea465]

        tdf#130857 qt weld: Convert Qt to VCL accelerator in get_label()
        
        In QtInstanceLabel::get_label and QtInstanceButton::get_label,
        convert the text potentially containing a Qt accelerator "&"
        and escaped "&" ("&&") to the VCL variant using "~" as accelerator.
        (The same is already done the other way around in `set_label()`).
        
        Without this, the "New" button in the dialog triggered as follows
        in a WIP branch where support for that dialog is declared for
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 was displayed with a literal "&New"
        as its text, because SvxEditDictionaryDialog::SvxEditDictionaryDialog
        does this:
        
            sNew = m_xNewReplacePB->get_label();
            // ...
            m_xNewReplacePB->set_label(sNew);
        
        To trigger the dialog:
        
        * "Tools" -> "Spelling" -> "Options"
        * select the Hungarian dictionary
        * click the "Edit" button
        
        Change-Id: Ia457f0d8c3dc03b33fa3cb026814830b18c5ca8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182021
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [ad04dd44b013e7cbb20be5902392b12a7ce1a142]

        tdf#130857 qt weld: Support BreakNumberOption dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Dialog can be triggered e.g. like this in Writer:
        
        * "Tools" -> "Spelling" -> "Options"
        * select the Hungarian dictionary
        * in the "Options" treeview, select "Minimal number of characters for
          hyphenation"
        * click the "Edit" button
        
        Change-Id: Ib039debda6e7fcaab1f20ba6cda9364e38b380f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182020
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [37382153c480393569a0d2e29d115b80efda2f41]

        cui: Resave breaknumberoption.ui with glade 3.40
        
        Dialog can be triggered e.g. like this in Writer:
        
        * "Tools" -> "Spelling" -> "Options"
        * select the Hungarian dictionary
        * in the "Options" treeview, select "Minimal number of characters for
          hyphenation"
        * click the "Edit" button
        
        Change-Id: I47685d691ceedfe93147c21b0ac38f23354c768c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182019
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [cd1d93a5fe73338f7c7130544585ff22355b975c]

        tdf#130857 qt weld: Support QueryDeleteDictionaryDialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Dialog can be triggered like this in Writer:
        
        * "Tools" -> "Spelling" -> "Options"
        * select a dictionary and click "Delete" button
        
        Change-Id: Ied3566fffdcf515a9d6f2778c28ea88038cf9c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182018
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [08c8f9483312b531d7184785633f8121821d9725]

        tdf#130857 qt weld: Also select item in QtInstanceTreeView::set_cursor
        
        Align the Qt implementation with `gtk_tree_view_set_cursor`
        (used in GtkInstanceTreeView::set_cursor), which [1]
        
        > Sets the current keyboard focus to be at path, and selects it.
        
        So far, QtInstanceTreeView::set_cursor was only setting the
        cursor (i.e. the item that has keyboard focus once focus moves
        to the tree view), but not updating the selection.
        
        The different behavior was seen in a WIP branch declaring support
        for the "Tools" -> "Spelling" -> "Options" -> "Edit" dialog in Writer
        where typing a word already in the list would not result in
        that word to become selected with qt6 and SAL_VCL_QT_USE_WELDED_WIDGETS=1
        while it would with gen or gtk3.
        
        [1] https://docs.gtk.org/gtk3/method.TreeView.set_cursor.html
        
        Change-Id: I1b916f7f176e0a4862f8e6bee720a694e50b2972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182017
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [f2e75bcf775c178a3ea5ece0d281c4b0f23ab8f1]

        tdf#130857 qt weld: Forward more QtInstanceTreeView methods taking iter
        
        ... to their counterparts taking a row index param.
        
        (Some of those still trigger an assert as well, but once they're
        implemented, the variant taking an iter param should work just
        the same.)
        
        Change-Id: Ide9f03ce81dbad1cb36e67e9e30c1da76918218e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182016
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [83e63f8e052f7d567e097a5a30d616e6ee61b815]

        tdf#130857 weld: Make {Icon,Tree}View::{,un}select_all purely virtual
        
        No longer let the base class implementation
        `weld::TreeView::select_all()` call `weld::Treeview::unselect(-1)`
        and similar, but make them purely virtual and implement in
        the subclasses instead.
        
        This introduces a working implementation for QtInstanceTreeView,
        where the special value of -1 wasn't handled in the `select()` and
        `unselect()` implementations.
        (It also doesn't feel very "natural"/obvious to me and wasn't explicitly
        documented for `select` and `unselect`.)
        
        For the GTK and VCL implementation, leave the logic as it was
        for maximum backward compatibility for now.
        
        I noticed this in a WIP branch declaring support for
        the "Tools" -> "Spelling" -> "Options" -> "Edit" dialog in Writer
        where typing a new word not yet in the list would not result in
        the previously selected word in the treeview to become unselected
        despite SvxEditDictionaryDialog::ModifyHdl calling
        
            m_pWordsLB->unselect_all();
        
        Change-Id: I2f681e2297a553beedd10fd7054adc539ac13ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182013
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [d08b41c6708e0b469af10a0d61617213b2cd8900]

        tdf#130857 qt weld: Don't assert text has been set when getting it
        
        If QStandardItemModel::data returns a QVariant that cannot
        be converted to QString (most likely an invalid QVariant
        because no data has explicitly been set), simply return an empty
        string QtInstanceTreeView::get_text and don't assert.
        
        This assert was e.g. triggered for the "Tools" -> "Spelling"
        -> "Options" -> "Edit" dialog in Writer in a WIP branch
        where support for that dialog is declared.
        
        Change-Id: Ic5782c418758becdc636356c13ab878f5fd2f007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182012
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [a5a3769ebd6eae7154b2e47107df322e122b59a2]

        tdf#130857 cui: Hide whole frame instead of individual widgets
        
        In the spelling options dialog that can be triggered
        in Writer via "Tools" -> "Spelling" -> "Options" dialog,
        don't call weld::Widget::hide separately for the single
        items in the "Available Language Modules" frame, but
        hide the whole frame instead.
        
        Besides being simpler, this also fixes the issue that
        the frame was still visible when opening the dialog
        when using the qt6 VCL plugin and SAL_VCL_QT_USE_WELDED_WIDGETS=1
        (i.e. enabling use of native Qt widgets).
        
        Change-Id: I331ce368b94a9636aa2f4a54c01a3a650f84ef03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182009
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [7cc0abf8c4517ee6cf7beb0da0c6e27c56f314c4]

        cui: Simplify and rename SvxLinguTabPage::HideGroups
        
        It only ever gets called with param GROUP_MODULES,
        so rename to SvxLinguTabPage::HideModulesGroup,
        drop the param and the corresponding
        GROUP_MODULES define altogether.
        
        Change-Id: I9324e85d2c13dac6a58ae0b0440eacb2b661e0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182008
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [66a674f915badf9e586b8e3854954d71dc908a4d]

        tdf#130857 qt weld: Support spelling options dialog
        
        Declare support for the .ui files used for Writer's
        "Tools" -> "Spelling" -> "Options" dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog makes use of the weld::TreeView feature
        of having a special checkbutton column for which support
        was added in the QtInstanceTreeView implementation
        in previous commit
        
            Change-Id: I5889429bf77e69cec4004fd54b2f93454d911c36
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 21 15:20:49 2025 +0100
        
                tdf#130857 qt weld: Add support for special toggle button column
        
        Change-Id: Ic0b81e9e9d429ad558783121f6981719ee8fe920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182007
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [24cbe829cfe1e341a67d5aeb4197384259d980ec]

        tdf#130857 qt weld: Add support for special toggle button column
        
        As the comment for weld::TreeView in weld.hxx says:
        
            /* Model column indexes are considered to begin at 0, but with special columns
               before index 0. A expander image column (and an additional optional toggle
               button column when enable_toggle_buttons is used). Column index -1 is
               reserved to access those columns.
            */
            class VCL_DLLPUBLIC TreeView : virtual public Widget
        
        Add initial support for the special toggle button
        column (only for checkbuttons/checkboxes initially,
        not radiobuttons).
        
        That special column gets enabled when
        weld::TreeView::enable_toggle_buttons gets called.
        For those methods that provide access, a column
        index of -1 is used to access that special column,
        and the first "normal" column uses an (external)
        column index of 0.
        
        In the QtInstanceTreeView's QStandardItemModel however,
        the special column has an index of 0 (because it
        is the first one) and the next column has a column
        index of 1.
        
        Adjust QtInstanceTreeView::modelIndex to calculate
        the model index accordingly when the special
        column has been enabled.
        
        This is similar to what the GTK and VCL implementations
        do, see GtkInstanceTreeView::to_internal_model
        or SalInstanceTreeView::to_internal_model.
        
        Introduce QtInstanceTreeView::m_bExtraToggleButtonColumnEnabled
        to keep track of whether this column has been enabled.
        
        Add QtInstanceTreeView::toggleButtonModelIndex
        for a helper to get the QModelIndex for the cell
        containing the checkbox for a given row.
        (For now, this assumes that the column index is 0,
        which may or may not change when adding support for
        the other "special column" for the expander image
        also mentioned in the weld::TreeView doc quoted above.
        
        In QtInstanceTreeView::enable_toggle_buttons, resize
        the column according to the contents, as otherwise
        it was taking way too much space when tested with
        an upcoming commit adding support for Writer's
        "Tools" -> "Spelling" -> "Options" dialog.
        
        Change-Id: I5889429bf77e69cec4004fd54b2f93454d911c36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182006
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [ef4314436d24d2733d268d714ad4bcc2e9fed626]

        tdf#130857 qt weld: Let QStandardItemModel::itemFromIndex create item
        
        QStandardItemModel::itemFromIndex "will lazily create an item for
        the index (using itemPrototype()), and set it in the parent item's
        child table, if no item already exists at that index." [1].
        
        Make use of that instead of manually calling the QStandardItem
        ctor.
        
        The main motivation is that this simplifies an upcoming change.
        
        [1] https://doc.qt.io/qt-6/qstandarditemmodel.html#itemFromIndex
        
        Change-Id: I371cdf8bd46b5f640c57760e4b52dda6489876c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182005
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [bb6a98f5dad7bf99eaa690d52b21c1f51e42fca3]

        tdf#130857 qt weld: Implement QtInstanceTreeView::{g,s}et_toggle
        
        Use QStandardItem::checkState [1] and
        QStandardItem::setCheckState [2] to retrieve/set the state.
        
        Add 2 static helper methods to map between vcl Tristate
        and Qt::CheckState.
        
        [1] https://doc.qt.io/qt-6/qstandarditem.html#checkState
        [2] https://doc.qt.io/qt-6/qstandarditem.html#setCheckState
        
        Change-Id: I4a77f3cd0ed69c879beca81821c8c2546923006d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182004
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-22  Mike Kaganski  <mike.kaganski@collabora.com>  [c2ffb93c7258aae9039148b8f8765cdbb73d8901]

        Deduplicate getTypeEntries in cppuhelper
        
        Also makes sure that the code initializing the struct uses the same
        mutex.
        
        There is also a duplicating code in comphelper/source/misc/compbase.cxx;
        however, to deduplicate also that, we would need to export the function.
        
        Change-Id: I145ea21d5c20536bab887ad55c69b74e7aeeb239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181865
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f9d61250208d4aff335c3cc4d6a12563db425efb]

        pdf: enable PDF/UA only when writing PDF version 1.7 or 2.0
        
        PDF/UA-1 should be used only with PDF 1.7 and PDF/UA-2 with PDF
        2.0. PDF/A-1 can't be used with PDF/UA as it's base on PDF 1.4,
        but PDF/A-2, PDF/A-3 (1.7) and PDF/A-4 (2.0) can be used with
        PDF/UA.
        
        Change-Id: I724cde804494b13dca573253e53786b54ff60998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181947
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-02-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [50f1900733e21e234620d852300378e301dc9f28]

        vcl: introduce BitmapContainer and use it in ImpGraphic for bitmap
        
        So we can move bitmap specific methods in this BitmapContainer
        including the memory managment and swapping.
        
        Change-Id: I9cec104d70da426084337ccdf2efbcdef2d8ad3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180620
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-02-21  Jim Raykowski  <raykowj@gmail.com>  [3c8bf431e33ed367d83370eb5a44b6adca284ed4]

        tdf#150524 Cannot traverse entire font lists in combo box with
        
        Windows scaling, the widget extends off display
        
        Applies to gen(x11)/win/qt5 VCL plugins.
        
        Change-Id: Ic5df291ba68ab8a19dd950dacd8a7dd61224c913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171966
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-02-21  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [652259c47d2be3f1b122ae4aee9e0b09f3f6cc5c]

        tdf#146553 sw: allow the AutoText dropdown button in the toolbar in RO
        
        Change-Id: Icddb74ff6256e3cce635fad14210beda8a1f4f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182011
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2025-02-21  Oliver Specht  <oliver.specht@cib.de>  [330efa9db365fbc28d825de2fe14162a692ffb2f]

        tdf#165333 RTF: import SYMBOL fields correctly
        
        Úsing XTextAppend to insert SYMBOL fields fixes wrongly extended
        character properties.
        
        Change-Id: I14f187e63e2c72d3c2cf27ab99cdced108797057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181892
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-21  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [f70f5fad59e55abd15209128d7f14b3015e2958b]

        remove unused LoadColorsFromTheme() from gtk theming code
        
        the usual theming approach is to set the colors at the source i.e.
        using the widget toolkit's mechanism and then the UpdateSettings
        function should be able to extract that color and set it in the
        StyleSettings.
        
        LoadColorsFromTheme like functions are used where the widget toolkit
        doesn't provide a nice way of setting the colors at source.
        
        Change-Id: I235f4dc06d9f8607cad6bfcdafae66f597f10547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182003
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [8d816d7a8f2ff35414b82dcc400626bc3a82a75b]

        vcl: Merge SvTreeListBox::{SetCheckButtonData,EnableCheckButton}
        
        Change-Id: I9b3be5d3c9b21e7178baa95fc71eb2e9904bb391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182000
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [a19f35090f571fdafe8147b2584bba8c666daafa]

        vcl treeview: Pass SvLBoxButtonData by ref instead of pointer
        
        This allows dropping the (unused) special handling for nullptr.
        
        Change-Id: I547b0804f11106afaf4d053e4a20ce3e5e7d9119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181999
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [3d0547f3002eca287c17b8bea2c46c454d487a06]

        vcl: Drop SvLBoxButtonData::SetImage
        
        This is never called from outside, so
        move the logic to the only caller instead of
        having a public method.
        
        Change-Id: I24de9da32c9e65d328174b251dbf3f80f3e9e0a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181998
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [030446104b44f674b3dc84f9eaaa3aa33b7e572a]

        vcl: Use Size instead of width/height in SvLBoxButtonData
        
        Use Size directly instead of retrieving width and height from a Size
        to store them, call the getters for each of them to
        then create a Size object from them again.
        
        Change-Id: I161629b9fb731768010110715b4a78d0288c73e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181997
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [f04a5c65db2e9997c2a42a191cab09de9b1b6bba]

        vcl: Drop pointless SvLBoxButtonData::m_bDefaultImages and getter
        
        The member already gets set to `true` in the
        ctor and that value is never changed again after that.
        
        Change-Id: I5e26bf937d6bac757a7f0c1b8a3249e3c2500bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181996
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [5b470b2ec4bcef2b295a9a16c8193a02da00f96d]

        vcl: Use a std::map for SvLBoxButtonData::aBmps
        
        ... instead of using a std::vector and casting
        the SvBmp enum class values to/from int.
        
        Drop the specific int values for the enum values
        as they are no longer relevant.
        
        Change-Id: I521970cd6f5c31934dc7376910124284f020974e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181995
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [a697539819386b56df0ea89b8202ffc2910b470b]

        vcl: Merge SvLBoxButtonData_Impl into SvLBoxButtonData
        
        Change-Id: Icde3ef5effd893ade779002514f7a4132c9b2390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181990
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [ffe3ac6192f952a0604aafdd1a0f93004026b948]

        vcl: Pass control by ref to SvLBoxButtonData::SetDefaultImages
        
        and in the SvLBoxButtonData ctor. Drop the (unused)
        fallback to application settings.
        
        Change-Id: I3275551ef20c1d982b99c19573f8da09d0f46acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181989
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [8b794cfbe3d4b3429f5a5e5128947f95444f82be]

        vcl: Merge SvLBoxButtonData::InitData into ctor
        
        Change-Id: Ia6634d886943264fd197e5234278463b9cacbdc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Gökay Şatır  <gokaysatir@collabora.com>  [d0f1f8b6c42f2f3ba83578a31853d38b7a64bcaf]

        cool#11072: Send current cell's decimal separator.
        
        Calc: In a file with a language that uses "," as the decimal separator,
        using a keyboard with a layout that uses "." as decimal separator is difficult.
        Numbers are considered as string when it happens.
        Users should be able to use NumPad decimal separator regardless of the cell's current decimal separator.
        
        Change-Id: I35623661acb0f505597458b7ce55cfc2c3a4dace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181993
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins

2025-02-21  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [accbfbc4a298cb811072ff78bda9425dd1af4e81]

        tdf#160705 PDF export: Set the table caption element inside the table
        
        According to the PDF standard, if a table has a caption, it must be
        either the first or the last child within the table tag.
        Therefore, if both above and below captions are set for the table, they will be exported as the table's first child.
        
        Change-Id: Id4ee732d469d606b6ad49f68b34500bc1174c51e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181981
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2025-02-21  Justin Luth  <justin.luth@collabora.com>  [018daed42eb3b69b7566348849aa2a13fd288f4a]

        tdf#164845 doc import: read_tabs for sprmPChgTabs
        
        I'm not sure how we possibly got away with not reading
        so many tabstops in styles.
        
        Change-Id: I66f66c94f70423db866de10945429444a4906027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181979
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-02-21  Justin Luth  <justin.luth@collabora.com>  [e05000900bf24611031438270b4f0ad72275d2c2]

        related tdf#164201 Word 2010 dotx should be flagged as FILTER_DOCX
        
        Change-Id: I34de21cc2d5aa6be6a3cb0e71b7479211f7f9cd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181980
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-02-21  Noel Grandin  <noelgrandin@gmail.com>  [5357da349b4b266b4003d25b61ecb12a515893c4]

        Revert "remove canvas/cairo and canvas/gdi and canvas/directx backends"
        
        So the vclcanvas backend is in worse shape than I thought. It will
        take too long to get it into shape to be sure of making the next
        release, so revert this for now, and I will have to find another
        approach.
        
        This reverts the following commits
        
        commit fbefe07e4c4a8959278ea08a247d75612994727c
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Thu Feb 20 09:42:14 2025 +0100
        
            qt: Remove now unused vcl/inc/qt6/QtSvpSurface.hxx
        
        commit 595354ab7e01546765d84103aaf2bc38e5d3c9b3
        Author: Julien Nabet <serval2412@yahoo.fr>
        Date:   Wed Feb 19 21:13:49 2025 +0100
        
            Remove also canvas/cairo in gtk4, qt6 and gtk3_kde5
        
        commit d539f6e99e1be89e6133b2ef623c67bf4f0cff4f
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Wed Feb 19 18:15:30 2025 +0200
        
            fix "local variable is unused" warning
        
        commit 704f61b1bd2c54831c383e34e74315bd6da356e2
        Author: Noel Grandin <noelgrandin@collabora.co.uk>
        Date:   Wed Jan 29 15:35:21 2025 +0200
        
            remove canvas/cairo and canvas/gdi and canvas/directx backends
        
        Change-Id: I0492dabf7da8c42a15720c868f161919e8dc7ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181984
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-21  Michael Stahl  <michael.stahl@allotropia.de>  [bbef5782b66f8bd716445b828edc101bb2ac6815]

        sw: fix some comments
        
        Change-Id: If941bcab2fd9c9cfd1822842171e1361b857688e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181959
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-02-21  László Németh  <nemeth@numbertext.org>  [3e02ffb76c484a05cdc140d8a10bc3d993fe8320]

        tdf#i165354 sw offapi DOCX: implement HyphenationKeepLine – part 1
        
        ODF 1.0 feature hyphenation-keep, i.e. disabling hyphenation across
        page etc. was implemented by shifting the full hyphenated line
        (fixing also the DOCX layout interoperability, when value of the
        useWord2013TrackBottomHyphenation MSO DOCX compatibility option is
        true). To shift only the last word, add UNO paragraph property
        
        com::sun::star::text::ParagraphHyphenationKeepLine
        
        and the associated layout in Writer core, i.e. disabling
        the hyphenation in the last line, instead of line shifting,
        if the value of ParagraphHyphenationKeepLine is true.
        
        Fix missing DOCX layout interoperability by mapping the unhandled
        useWord2013TrackBottomHyphenation = false case to the new layout.
        
        Note: shifting lines may be better for languages with long
        words, but only with 1) typesetting with line-level (greedy)
        line breaking instead of the desirable paragraph-level, 2) and
        with missing optimized hyphenation at boundaries of compound word
        constituents, and 3) forgotting the following: Shifting only words
        or word constituents are better for 1) equal line count on pages
        and spreads (very basic typographical requirement), 2) disabling
        hyphenation really (shifting doesn't guarantee this, because
        shifting is limited in a single line, but the previous line can be
        hyphenated, too) and 3) more compact typesetting.
        Both hyphenation-keep algorithms are important for interoperability,
        but the new HyphenationKeepLine can create state-of-the-art automatic
        typesetting with the planned improvements.
        
        Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21
        "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep".
        and commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463
        "tdf160518 DOCX: import hyphenation-keep to fix layout".
        
        Change-Id: Iafa352ec91bbd5d1d227b8480337fa2b9acb5993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181954
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-02-21  Simon Chenery  <simon_chenery@yahoo.com>  [2aaa35d2a2281b87b8803bab990592099100350f]

        tdf#158068 Use OUString literals in dbmgr.cxx
        
        Change-Id: Ia664b6963c48c2832e01a5de845166a3dbd16dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [8710a20fabcb8892d8f1f2ae917101028db61e39]

        tdf#130857 qt weld: Handle image/icon in QtInstanceTreeView::insert
        
        Change-Id: I681da4205302d86d3022e1b1099729fa6ed71d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181978
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [9cf930e673178bfee0508ff0f3f374b7b210ef80]

        tdf#130857 qt weld: Implement QtInstanceTreeView::{g,s}et_sensitive
        
        Use QStandardItem::setFlags [1] whose doc already mentions:
        
        > The item flags determine how the user can interact with the item.
        > This is often used to disable an item.
        
        [1] https://doc.qt.io/qt-6/qstandarditem.html#setFlags
        
        Change-Id: Ieb1fde2e9df124a42fce1e6c18a9998dd82ab94f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181977
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [e22f00d890c3160059e9e38220177d4ff0658336]

        tdf#130857 qt weld: Implement TreeView methods to expand/collapse
        
        ... and get the current status.
        
        Change-Id: I175ffa67e49529dc62d58e9f8502b747691d84de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181976
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [24eded86bc205fbf9d785400a1c4cef64ff6ebf4]

        tdf#130857 qt weld: Implement QtInstanceTreeView::count_selected_rows
        
        Change-Id: I57b2b8230119c823ca475d7306c370f8ea57d8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181975
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [6b77cbba6b577477c75712608381dec596dcd8fb]

        tdf#130857 qt weld: Forward more TreeView methods taking iter
        
        ... to their equivalents taking a row index.
        
        Change-Id: I1e61f2931a6c10e1d220f0377ffa937a3f69abfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181974
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [01c88fcab34df9b796bfa1105c333ab21dc1df72]

        tdf#130857 qt weld: Implement QtInstanceTreeView::is_selected
        
        Change-Id: Id86fac8f3f6c2ff06f3b480ccc4fa7ef4a25cbf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181973
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [0202d8a9d58d49c6b75d01cd72146c8c84ce7cdf]

        tdf#130857 qt weld: Use QtInstanceTreeView::modelIndex helper
        
        Change-Id: I51ef89d08a5a56141355121dcd6b83bff4f5d99a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181972
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [ce0217d6a812974c04be21315541bb48fe3fce16]

        tdf#130857 qt weld: Implement more treeview methods using first text col
        
        Following
        
            Change-Id: Ibba0f99d6be006d7b8d896b0bfc396cfabbec084
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 20 22:24:37 2025 +0100
        
                tdf#130857 qt weld: Add logic to find first treeview text column
        
        , implement the remaining weld::TreeView methods whose
        doc says that a column index of -1 refers to the first text
        column. Also implement handling of other col indices where
        that wasn't done yet.
        
        Whether the logic introduced commit will turn out to be sufficient
        in the end remains to be seen. (E.g. whether other text data are
        always already set at the point in time that
        QtInstanceTreeView::set_text gets called with a col index of -1,
        which is a prerequisite for the logic to find the correct column.)
        
        Change-Id: I49298245f2773309ceb33fe05971dbc1907c5675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181971
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [4decd1b668899f54bd55990a9e72c2d4ec0c045e]

        tdf#130857 qt weld: Add logic to find first treeview text column
        
        The weld::TreeView::get_text doc says:
        
            // col index -1 gets the first text column
        
        So far, the QtInstanceTreeView implementation was simply
        assuming that  the first text column is the first column, i.e.
        the column at index 0.
        
        Add new method QtInstanceTreeView::firstTextColumnModelIndex
        that tries to find the first text column in a given row
        by finding the first column where data of type
        Qt::DisplayRole ("The key data to be rendered in the form of text.
        (QString)" [1]) is set.
        
        Assert if no such column was found.
        
        This at least works as expected for Calc's
        "Sheet" -> "Show Sheet" dialog for which initial
        support was added in
        
            commit 5d94ffde5125960fff0c177635292b2de5e20d38
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Nov 29 15:44:55 2024 +0100
        
                tdf#130857 qt weld: Support Calc's "Show Sheet" dialog
        
        [1] https://doc.qt.io/qt-6/qt.html#ItemDataRole-enum
        
        Change-Id: Ibba0f99d6be006d7b8d896b0bfc396cfabbec084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181970
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [33c9641db65d16f4ecf86709de008f0afa42a7d4]

        tdf#130857: sd presentationsdialog.ui: Define widgets in order
        
        Switch the order in which the widgets in the dialog's .ui file
        are defined so that the order matches the visual appearance
        (and "left-attach"/"top-attach" properties order), which makes sure that tab focus
        order with the Qt-based VCL plugins is correct as well in that dialog when
        using native Qt widgets (SAL_VCL_QT_USE_WELDED_WIDGETS=1), where focus order
        is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        This is the Impress "Slide Show" -> "Slide Show Settings"
        dialog.
        
        Change-Id: I1324e5e5a410c49859eec14d6d4681a5a3339a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181969
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [c516f6da693d9d5d5ea1d1bb2af2cf964694e86c]

        sd: Resave presentationdialog.ui with glade 3.40
        
        This is the Impress "Slide Show" -> "Slide Show Settings"
        dialog.
        
        Change-Id: Iad8aa7892c1cd41121df2fe0a489aed85bd0021b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181968
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [6ca50428779b24e39e172efc5acaac7213f510be]

        tdf#130857 qt weld: Use QSpinBox in SpinButton's weld::Widget methods
        
        In the implementation of the QtInstanceWidget methods,
        don't use the `m_pWidget` member directly, but instead
        call the virtual `getQWidget()` method to get the
        widget to work with.
        
        This ensures that the QSpinBox is used for QtInstanceSpinButton
        and QtInstanceFormattedSpinButton, which pass the QSpinBox's
        QLineEdit into the QtInstanceEntry base class ctor in
        order to be able to implement the weld::Entry interface, see
        
            commit 12fb40fd7bc771813b825806cb4151833d7cd789
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 27 23:40:16 2024 +0100
        
                tdf#130857 qt weld: Let SpinButton derive from Entry
        
        Using the actual QSpinBox (i.e. the "main widget") e.g. makes
        disabling the spinbox in the Impress "Slide Show" -> "Slide Show Settings"
        dialog work as expected.
        
        (Without this commit in place, it wasn't possible to type into
        the "Loop and repeat after" SpinButton, but it was still possible
        to change the value using the "up/down" buttons of the SpinButton
        even if the checkbox was not checked.
        
        Change-Id: I561a662830203b20db4d247fcc90416c13950e7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181967
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [d1f97a537b576454b2d93406d372cc4ed36d0b32]

        tdf#130857 qt weld: Support Impress slide show settings dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog uses a weld::FormattedSpinButton with a TimeFormatter
        for which support has been implemented in previous commits
        up to
        
            Change-Id: Idde78409b6e4564521e96c8ef9947492b6a33e63
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 20 20:02:50 2025 +0100
        
                tdf#130857 qt weld: Allow typing spinbox value when TimeFormatter is used
        
        Sample steps to trigger the dialog and interact with the spinbox:
        
        * start Impress
        * "Slide Show" -> "Slide Show Settings"
        * check the "Loop and repeat after" checkbox in the "Presentation Mode"
          frame
        * select all text in the spinbutton
        * type "1:2:3" for a time of "01:02:03" to be set
        
        Change-Id: I2d1552d4bc5a97da38ddb3678f20aa2a1faeb014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181966
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [3e3fae39dc7f9f88b88dce8fc3fe06652be51228]

        tdf#130857 qt weld: Consistently use QString in QtDoubleSpinBox
        
        Switch uses of OUString in QtDoubleSpinBox to QString and
        drop includes for LO-specific types.
        
        Instead, let QtInstance{Formatted}SpinButton take care of the
        QString <-> OUString conversion.
        
        Change-Id: I2b3cc2e2fd855c890b7a808f955bff33c855a4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181965
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [e1a864dafa0753c6ccab2559f1ae7d0742f3ee7f]

        tdf#130857 qt weld: Allow typing spinbox value when TimeFormatter is used
        
        So far, when trying to manually insert/edit text in a
        QtInstanceFormattedSpinButton (its QtDoubleSpinBox widget),
        that didn't work as expected when TimeFormatter is used for
        it formatter, e.g. for the following scenario
        with upcoming
        
            Change-Id: I2d1552d4bc5a97da38ddb3678f20aa2a1faeb014
            Author: Michael Weghorn <m.weghorn@posteo.de>
        
                tdf#130857 qt weld: Support Impress slide show settings dialog
        
        in place:
        
        * start Impress
        * "Slide Show" -> "Slide Show Settings"
        * check the "Loop and repeat after" checkbox in the "Presentation Mode"
          frame
        * select all text in the spinbutton
        * type "1:2:3"
        
        The text typed didn't appear as expected because it was already
        replaced by other text before finishing typing. This is because
        weld::TimeFormatter reacts to cursor position changes in the
        spinbutton edit/entry (s. weld::TimeFormatter::CursorChangedHdl
        in frame 18 in the below backtrace) and calls
        QtInstanceFormattedSpinButton::sync_increments_from_formatter (frame 16)
        which calls QDoubleSpinBox::setSingleStep (frame 9) which is Qt-internal
        and calls QAbstractSpinBoxPrivate::updateEdit (8) which updates
        the text in the spinbox with the one returned by
        QtDoubleSpinBox::textFromValue (s. frame 6).
        
        Changing the text just because the cursor moves while typing is not desirable.
        Prevent that by introducing a QtInstanceFormattedSpinButton::m_bInSetSingleStep
        member to detect that case and simply returning the current spinbox text
        (instead of formatting the passed value) in the function that is
        responsible for converting a value into display text.
        
        With this commit (and the upcoming change to support the
        dialog), the scenario above now results in a time value of
        "01:02:03" being set in the spinbox, as is the case with
        the GTK or VCL implementations as well.
        
            1 QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0::operator()(double) const QtInstanceFormattedSpinButton.cxx 38 0x7fffe43ddbc7
            2 std::__invoke_impl<rtl::OUString, QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0&, double>(std::__invoke_other, QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0&, double&&) invoke.h 61 0x7fffe43ddb8c
            3 std::__invoke_r<std::optional<rtl::OUString>, QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0&, double>(QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0&, double&&) invoke.h 114 0x7fffe43ddaf1
            4 std::_Function_handler<std::optional<rtl::OUString>(double), QtInstanceFormattedSpinButton::QtInstanceFormattedSpinButton(QtDoubleSpinBox *)::$_0>::_M_invoke std_function.h 290 0x7fffe43dd9e8
            5 std::function<std::optional<rtl::OUString>(double)>::operator() std_function.h 591 0x7fffe432f159
            6 QtDoubleSpinBox::textFromValue QtDoubleSpinBox.cxx 31 0x7fffe432eddd
            7 QDoubleSpinBoxPrivate::textFromValue qspinbox.cpp 1400 0x7fffe17d2616
            8 QAbstractSpinBoxPrivate::updateEdit qabstractspinbox.cpp 1784 0x7fffe17c95ba
            9 QDoubleSpinBox::setSingleStep qspinbox.cpp 780 0x7fffe17d0635
            10 QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0::operator()() const QtInstanceFormattedSpinButton.cxx 120 0x7fffe43df11c
            11 std::__invoke_impl<void, QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0&>(std::__invoke_other, QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0&) invoke.h 61 0x7fffe43df0d5
            12 std::__invoke_r<void, QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0&>(QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0&) invoke.h 111 0x7fffe43df085
            13 std::_Function_handler<void(), QtInstanceFormattedSpinButton::sync_increments_from_formatter()::$_0>::_M_invoke std_function.h 290 0x7fffe43defad
            14 std::function<void()>::operator() std_function.h 591 0x7fffe439195e
            15 QtInstance::RunInMainThread QtInstance.cxx 206 0x7fffe438946f
            16 QtInstanceFormattedSpinButton::sync_increments_from_formatter QtInstanceFormattedSpinButton.cxx 118 0x7fffe43dd78b
            17 weld::EntryFormatter::SetSpinSize weldutils.cxx 230 0x7fffeecbcba2
            18 weld::TimeFormatter::CursorChangedHdl field2.cxx 3183 0x7fffee51ef57
            19 weld::TimeFormatter::LinkStubCursorChangedHdl field2.cxx 3166 0x7fffee51ee2d
            20 Link<weld::Entry&, void>::Call link.hxx 105 0x7fffe43d8e61
            21 weld::Entry::signal_cursor_position weld.hxx 1795 0x7fffe43d8ecc
            22 QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0::operator()() const QtInstanceEntry.cxx 24 0x7fffe43d566f
            23 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0>::call(QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0&, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 116 0x7fffe43d5648
            24 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0>::call(QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0&, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0>::call(QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0&, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7fffe43d5629
            25 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0>::call(QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0&, void * *) qobjectdefs_impl.h 115 0x7fffe43d55f2
            26 QtPrivate::FunctorCallable<QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0>::call<QtPrivate::List<>, void>(QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0&, void *, void * *) qobjectdefs_impl.h 337 0x7fffe43d55a1
            27 QtPrivate::QCallableObject<QtInstanceEntry::QtInstanceEntry(QLineEdit *)::$_0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 547 0x7fffe43d5548
            28 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7fffe3303c22
            29 doActivate<false> qobject.cpp 4223 0x7fffe3521c84
            30 QMetaObject::activate qobject.cpp 4283 0x7fffe3517e93
            31 QMetaObject::activate<void, int, int> qobjectdefs.h 319 0x7fffe163a675
            32 QLineEdit::cursorPositionChanged moc_qlineedit.cpp 345 0x7fffe16fbbe4
            33 QLineEditPrivate::cursorPositionChanged qlineedit_p.cpp 139 0x7fffe1702cdb
            34 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul>, QtPrivate::List<int, int>, void, void (QLineEditPrivate:: *)(int, int)>::call(void (QLineEditPrivate:: *)(int, int), QLineEditPrivate *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7fffe170aac7
            35 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul>, QtPrivate::List<int, int>, void, void (QLineEditPrivate:: *)(int, int)>::call(void (QLineEditPrivate:: *)(int, int), QLineEditPrivate *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul>, QtPrivate::List<int, int>, void, void (QLineEditPrivate:: *)(int, int)>::call(void (QLineEditPrivate:: *)(int, int), QLineEditPrivate *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7fffe170aa2d
            36 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul, 1ul>, QtPrivate::List<int, int>, void, void (QLineEditPrivate:: *)(int, int)>::call qobjectdefs_impl.h 126 0x7fffe170a9e7
            37 QtPrivate::FunctionPointer<void (QLineEditPrivate:: *)(int, int)>::call<QtPrivate::List<int, int>, void> qobjectdefs_impl.h 174 0x7fffe170a951
            38 QtPrivate::QPrivateSlotObject<void (QLineEditPrivate:: *)(int, int), QtPrivate::List<int, int>, void>::impl qobject_p.h 272 0x7fffe170a880
            39 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7fffe3303c22
            40 doActivate<false> qobject.cpp 4223 0x7fffe3521c84
            41 QMetaObject::activate qobject.cpp 4283 0x7fffe3517e93
            42 QMetaObject::activate<void, int, int> qobjectdefs.h 319 0x7fffe163a675
            43 QWidgetLineControl::cursorPositionChanged moc_qwidgetlinecontrol_p.cpp 192 0x7fffe171494f
            44 QWidgetLineControl::emitCursorPositionChanged qwidgetlinecontrol.cpp 1400 0x7fffe1710bdc
            45 QWidgetLineControl::moveCursor qwidgetlinecontrol.cpp 471 0x7fffe17118b1
            46 QLineEdit::mousePressEvent qlineedit.cpp 1536 0x7fffe16f685d
            47 QWidget::event qwidget.cpp 8960 0x7fffe14a09d1
            48 QLineEdit::event qlineedit.cpp 1493 0x7fffe16f64c8
            49 QApplicationPrivate::notify_helper qapplication.cpp 3309 0x7fffe13e2e80
            50 QApplication::notify qapplication.cpp 2786 0x7fffe13e4b52
            51 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1100 0x7fffe344c429
            52 QCoreApplication::sendSpontaneousEvent qcoreapplication.cpp 1554 0x7fffe344d129
            53 QApplicationPrivate::sendMouseEvent qapplication.cpp 2367 0x7fffe13e37a7
            54 QWidgetWindow::handleMouseEvent qwidgetwindow.cpp 669 0x7fffe14dffc8
            [...]
        
        Change-Id: Idde78409b6e4564521e96c8ef9947492b6a33e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181964
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [da5b0c93b24e6b9c73e035237ce472a519176126]

        tdf#130857 qt weld: Don't signal spinbox value/text changes while typing
        
        Disable keyboard tracking in QtDoubleSpinBox, the custom QDoubleSpinBox
        subclass used by both, QtInstanceSpinButton and
        QtInstanceFormattedSpinButton.
        
        Quoting the QAbstractSpinBox::keyboardTracking doc [1]:
        
        > This property holds whether keyboard tracking is enabled for the
        > spinbox.
        >
        > If keyboard tracking is enabled (the default), the spinbox emits the
        > valueChanged() and textChanged() signals while the new value is being
        > entered from the keyboard.
        >
        > E.g. when the user enters the value 600 by typing 6, 0, and 0, the
        > spinbox emits 3 signals with the values 6, 60, and 600 respectively.
        >
        > If keyboard tracking is disabled, the spinbox doesn't emit the
        > valueChanged() and textChanged() signals while typing. It emits the
        > signals later, when the return key is pressed, when keyboard focus is
        > lost, or when other spinbox functionality is used, e.g. pressing an
        > arrow key.
        
        Seeing where SalInstanceSpinButton calls `signal_value_changed`
        (in its `ActivateHdl`, `UpDownHdl` and `LoseFocusHdl` handlers)
        suggests that that class also doesn't emit these events while
        typing.
        And debug output in GtkInstanceSpinButton::signalValueChanged
        also suggests that that signal gets triggered when the GtkSpinButton
        loses focus for example, but not while typing.
        
        [1] https://doc.qt.io/qt-6/qabstractspinbox.html#keyboardTracking-prop
        
        Change-Id: I793b245a3848fa37880cb7d857cef160537c153e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181963
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [210c69cf7aaa314f932a9debe0e64ba2789f2365]

        tdf#130857 qt weld: Implement spin button input validation
        
        Override QDoubleSpinBox::validate [1] to validate
        whether a given input text is valid.
        
        If a handler for parsing the text is set and
        it can successfully parse the text, return
        QValidator::Acceptable, otherwise
        QValidator::Intermediate (allowing to continue
        editing/typing).
        
        Without this, in the Impress "Slideshow" -> "Slideshow Settings"
        dialog, modifying the value for the "Loop and repeat after"
        spinbox wasn't possible by typing (as opposed to using the
        up/down arrow keys or buttons) at all in a WIP branch declaring
        support for that dialog, see upcoming
        
            Change-Id: I2d1552d4bc5a97da38ddb3678f20aa2a1faeb014
            Author: Michael Weghorn <m.weghorn@posteo.de>
        
                tdf#130857 qt weld: Support Impress slide show settings dialog
        
        With this change in place, at least selecting a number
        and typing another one to replace the existing one to
        change the time works.
        (Further improvements to come in another commit before
        the dialog will actually be declared supported.)
        
        [1] https://doc.qt.io/qt-6/qdoublespinbox.html#validate
        
        Change-Id: If214119799fdf32f7295cacfab51d2c8ce5ba505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181962
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Stanislav Horacek  <stanislav.horacek@gmail.com>  [2f5925d97faa8b0d1877fdf18e5e83cb9c50c4dd]

        simplify extended tip for position of subtotals
        
        Change-Id: Ia6f444bd92d85562513062eb1796534502a41831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179412
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2025-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [4a22790873b93b154d6f7fbc5aef6174b984d8a3]

        Make the char tables referenced from ScCompiler::Convention constexpr
        
        Change-Id: Ifd569145acbde2925c71b9969fee1ebd6eb1bde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181702
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-20  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [4b09854515dd2a8de2de3700c5295ac8a188dd35]

        SwCollCondition: SwClient no more
        
        Change-Id: I5cf43f4aec61d8e7b2adf84becfda9d61629ea60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181924
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [0fd4cfdc0826a4dfde62e0adf1a43dd64969af6a]

        tdf#130857 qt weld: Avoid losing decimals in SvxDecimalNumberDialog
        
        For QDoubleSpinBox (and thus the custom QtDoubleSpinBox subclass
        used in QtFormattedSpinBox), the number of decimals set via
        QDoubleSpinBox::setDecimals [1] does not only affect how
        many decimals are displayed, but also applies to the
        actual value used (which makes sure they are consistent).
        
        As a consequence, setting the amount of decimals to 0
        results in rounding to an integer when setting the value.
        
        So far, this happened for SvxDecimalNumberDialog because
        the "digits" property for the "GtkSpinButton" in the .ui
        file uses the default value of 0.
        
        Change this to 2 instead (which matches the amount of decimals
        shown with both, the GTK and the VCL variants) when opening the
        dialog.
        
        For SvxNumberDialog that uses the same .ui file, explicitly
        set the number of decimals to 0, to keep the behavior unchanged
        for that one.
        
        This addresses those issues mentioned in previous commit
        
            Change-Id: I25707ab6c5877eea2270bc21a27d08483d0f52e6
        
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 20 11:12:51 2025 +0100
        
                tdf#130857 qt weld: Support Svx(Decimal)NumberDialog
        
        > Handling for decimal numbers using QtInstanceFormattedSpinButton
        > still needs some tweaks that will be done in upcoming commits.
        > (For example, it currently rounds the value when double-clicking
        > on a proparty that has a floating point value set, and only allows
        > typing integer values, not actual floating point values.)
        
        [1] https://doc.qt.io/qt-6/qdoublespinbox.html#decimals-prop
        
        Change-Id: I9a242c704a1199cbbf7b16e96151d950223905b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181948
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [ca05be9dde72a72d8b76136887381d8e25f2a215]

        tdf#130857 qt weld: Implement FormattedSpinButton text -> value conversion
        
        Use the method introduced in previous commit
        
            Change-Id: I475fc97c78feb05703a9a134b004d1c12ccd855a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 19 22:45:53 2025 +0100
        
                tdf#130857 Formatter: Extract helper method to convert text to value
        
        to set the function used by QtDoubleSpinBox::valueFromText
        to convert text to a value for the
        QtFormattedSpinButton use case.
        
        See also similar commit
        
            commit 6871b55b6915396caa3e5aca7e233f6a5efc7864
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 17:47:01 2025 +0100
        
                tdf#130857 qt weld: Implement SpinButton text <-> value conversion
        
        for the QtInstanceSpinButton case.
        
        Change-Id: Ic6e31163ab47e716f8d305f45168c0af25266534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181944
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [572207aa731ab95feef562601d4e08e915e4718e]

        tdf#130857 Formatter: Extract helper method to convert text to value
        
        Move the existing logic from Formatter::ImplGetValue
        that converts the text to a double value into a new
        method Formatter::ParseText and call it from
        Formatter::ImplGetValue.
        
        It returns a std::optional, which correspond to
        the `true`/`false` return values of Formatter::ImplGetValue
        (empty std::optional means `false`, i.e. no value could be
        retrieved from the text).
        
        The newly introduced method will be reused to
        implement text -> value conversion for
        QtInstanceFormattedSpinButton.
        
        Change-Id: I475fc97c78feb05703a9a134b004d1c12ccd855a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181943
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [eee97f8c66a60e2faf7485d6d59a6dc425a2eca5]

        tdf#130857 Formatter: Pass string to convert to double
        
        Instead of letting the implementations set for
        Formatter::m_aInputHdl via Formatter::SetInputHdl
        always retrieve the current text and parse
        that one, pass the text to convert as a parameter
        instead.
        
        Introduce a new struct Formatter::ParseResult
        so that both, the state (which describes whether
        parsing was successful and/or a handler was set)
        and the value can still be returned at the same time.
        (Link/The handlers only supports a single param. So far,
        the state was returned by the function result and
        the value was returned via an out param, but the
        single param is now used for an input param to pass the
        text.)
        
        Make it the responsibility of Formatter::ImplGetValue
        to pass the current text instead of having the handlers
        read it themselves.
        
        Rename the members accordingly:
        
        * Formatter::m_aInputHdl -> Formatter:m_aParseTextHdl
        * Formatter::SetInputHdl -> Formatter::SetParseTextHdl
        
        This is similar to
        
            Change-Id: I6b3fbccc89b89446a1ea367a80aeed3a7b583298
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 18 20:29:20 2025 +0100
        
                tdf#130857 Let Formatter:m_aOutputHdl convert double to text
        
        (but for the conversion the other way around) and
        
            commit 15ad64a412d80fdf05ee1783bcc277753eaa34bc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 11:22:54 2025 +0100
        
                tdf#130857 weld: Let SpinButton input hdl only parse value from string
        
        (which is a similar change, but in weld::SpinButton).
        
        No change in behavior is intended by this change
        by itself.
        
        The primary motivation is to allow reusing the
        logic to convert a string to a value in order
        to implement QtDoubleSpinBox::valueFromText
        for QtInstanceFormattedSpinButton.
        
        Change-Id: If6837409aadbe9cc37fdbb4c0650f5e1305229f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181942
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [21bc6e075d8b004bce7bf7d9305f5fdcff2df24d]

        sw: fix bug with redline following fieldmark or hidden break
        
        It is now possible for HideIterator to move to another node without a
        redline being involved, but if this happens and there was no redline on
        the previous node, GetRedlinePos() had already returned
        SwRedlineTable::npos and now no redlines can be found in the new node.
        
        (regression from commit 657de5fba12b0e9afcdee361654d2a2d0dbd7311)
        
        Change-Id: I536b2660c97501be896203403cdd5e2f2015e816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181946
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [8ff1892730113db075bd0b591c03e083720458ba]

        tdf#130857 qt weld: Support Svx(Decimal)NumberDialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The .ui file is used for 2 dialogs:
        
        * SvxNumberDialog which handles integer values
          and uses "just" weld::SpinButton
        * SvxDecimalNumberDialog which handles decimal numbers
          and uses weld::FormattedSpinButton
        
        Sample steps to trigger the SvxDecimalNumberDialog:
        
        * start Writer
        * "Tools" -> "Options"
        * "LibreOfficeDev" -> "Advanced" -> "Open Expert Configuration"
        * Search for "ColScale" and double-click on the only search result
          (config entry "org.openoffice.Office.Calc" > "Filter" > "Import" >
           "MS_Excel", property "ColScale") to modify it
        
        Handling for decimal numbers using QtInstanceFormattedSpinButton
        still needs some tweaks that will be done in upcoming commits.
        (For example, it currently rounds the value when double-clicking
        on a proparty that has a floating point value set, and only allows
        typing integer values, not actual floating point values.)
        
        Change-Id: I25707ab6c5877eea2270bc21a27d08483d0f52e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181941
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [75016899f518109d888c91232c03228ea877c338]

        tdf#130857 qt weld: Explicitly reset formatter in spinbutton dtor
        
        This fixes a crash otherwise seen with the upcoming
        
            Change-Id: I25707ab6c5877eea2270bc21a27d08483d0f52e6
            Author: Michael Weghorn <m.weghorn@posteo.de>
        
                tdf#130857 qt weld: Support Svx(Decimal)NumberDialog
        
        which is caused by the weld::EntryFormatter dtor calling
        weld::FormattedSpinButton::SetFormatter (s. frames 8 and 7 below).
        This causes QtInstanceFormattedSpinButton::m_xOwnFormatter
        to be reset while it's already in its own dtor (see dtor in
        both, frames 8/9 and 2/3), triggering a double-free of
        members when returning to the dtor that was called first.
        
        Prevent this the same way as GtkInstanceFormattedSpinButton
        does it by explicitly resetting the `m_xOwnFormatter`
        and `m_xOwnFormatter` members in the QtInstanceFormattedSpinButton
        dtor.
        
        As [1] documents, std::unique_ptr::reset (other than the dtor)
        first assign the new value (here: nullptr) before deleting the
        previously managed object:
        
        > Replaces the managed object.
        > 1,2) Equivalent to
        >
        >       auto old_ptr = get();
        >       /* assigns “ptr” to the stored pointer */
        >       if (old_ptr)
        >           get_deleter()(old_ptr);
        
            1 Formatter::~Formatter fmtfield.cxx 273 0x7f6f181356c4
            2 weld::EntryFormatter::~EntryFormatter weldutils.cxx 159 0x7f6f188b9392
            3 weld::EntryFormatter::~EntryFormatter weldutils.cxx 154 0x7f6f188b93d9
            4 std::default_delete<weld::EntryFormatter>::operator() unique_ptr.h 93 0x7f6f0dfdecb8
            5 std::__uniq_ptr_impl<weld::EntryFormatter, std::default_delete<weld::EntryFormatter>>::reset unique_ptr.h 205 0x7f6f0dfdf5e8
            6 std::unique_ptr<weld::EntryFormatter, std::default_delete<weld::EntryFormatter>>::reset unique_ptr.h 504 0x7f6f0dfde5bd
            7 QtInstanceFormattedSpinButton::SetFormatter QtInstanceFormattedSpinButton.cxx 73 0x7f6f0dfdc7a5
            8 weld::EntryFormatter::~EntryFormatter weldutils.cxx 158 0x7f6f188b9385
            9 weld::EntryFormatter::~EntryFormatter weldutils.cxx 154 0x7f6f188b93d9
            10 std::default_delete<weld::EntryFormatter>::operator() unique_ptr.h 93 0x7f6f0dfdecb8
            11 std::unique_ptr<weld::EntryFormatter, std::default_delete<weld::EntryFormatter>>::~unique_ptr unique_ptr.h 399 0x7f6f0dfde51f
            12 QtInstanceFormattedSpinButton::~QtInstanceFormattedSpinButton QtInstanceFormattedSpinButton.hxx 17 0x7f6f0dfdec2c
            13 QtInstanceFormattedSpinButton::~QtInstanceFormattedSpinButton QtInstanceFormattedSpinButton.hxx 17 0x7f6f0dfde6c0
            14 QtInstanceFormattedSpinButton::~QtInstanceFormattedSpinButton QtInstanceFormattedSpinButton.hxx 17 0x7f6f0dfde729
            15 std::default_delete<weld::FormattedSpinButton>::operator() unique_ptr.h 93 0x7f6edf54bc98
            16 std::unique_ptr<weld::FormattedSpinButton, std::default_delete<weld::FormattedSpinButton>>::~unique_ptr unique_ptr.h 399 0x7f6edf54b16f
            17 SvxDecimalNumberDialog::~SvxDecimalNumberDialog dlgname.hxx 89 0x7f6edf54b84a
            18 CuiAboutConfigTabPage::StandardHdl_Impl optaboutconfig.cxx 866 0x7f6edf6ddbd7
            19 CuiAboutConfigTabPage::DoubleClickHdl_Impl optaboutconfig.cxx 773 0x7f6edf6dd24d
            20 CuiAboutConfigTabPage::LinkStubDoubleClickHdl_Impl optaboutconfig.cxx 771 0x7f6edf6d733d
            21 Link<weld::TreeView&, bool>::Call link.hxx 105 0x7f6f18820296
            22 weld::TreeView::signal_row_activated weld.hxx 993 0x7f6f187fce1c
            23 SalInstanceTreeView::DoubleClickHdl salvtables.cxx 5332 0x7f6f187dc339
            24 SalInstanceTreeView::LinkStubDoubleClickHdl salvtables.cxx 5328 0x7f6f187d2a6d
            25 Link<SvTreeListBox *, bool>::Call link.hxx 105 0x7f6f17eb0d96
            26 SvTreeListBox::DoubleClickHdl treelistbox.cxx 463 0x7f6f183a1541
        
        [1] https://en.cppreference.com/w/cpp/memory/unique_ptr/reset
        
        Change-Id: Iabdfc6dede2d08406a9605825d41c2acb79f6303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181940
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [f1daf188934d079cc2a72266c51085c92438afaa]

        tdf#130857 qt weld: Initialize QtInstanceFormattedSpinButton::m_pFormatter
        
        This amends
        
            commit 2bd9ff78c7be6a66a3f4b381bf6726dcce9e2814
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 18 19:07:07 2025 +0100
        
                tdf#130857 qt weld: Introduce QtInstanceFormattedSpinField
        
        Change-Id: Ib4be192d96acefc2603ae3052a3631c46667a55b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181931
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [2b68bf57789714bf79b5bd1fc3e4e9ad586b7c31]

        android: Update minimum NDK version to 27
        
        As discussed in today's ESC meeting [1], bump the
        minimum NDK version for Android builds from 23 to 27,
        which is used in CI since
        
            commit b8e51e8a26b8b8faf63e457ba0c03651dd864d95
            Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Date:   Tue Feb 18 16:57:39 2025 +0100
        
                bump android ndk to 27.2.12479018 on CI
        
        and has better support for C++20 features.
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2025-February/093032.html
        
        Change-Id: Ib7d7d355868ef38e7b92a5067ac0045a3b3f494c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181956
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Justin Luth  <justin.luth@collabora.com>  [bbb2ec8b3728a013794065a2e0651f52589b37a5]

        related tdf#164201 Word 2010 filter should be flagged as FILTER_DOCX
        
        And I have no idea what all the implications of this will be,
        but a hint is to look for FILTER_DOCX
        (even though the value OXML existed before FILTER_DOCX was defined)
        or git grep -25 SfxFilter | grep -25 GetUserData
        
        "OXML" was always in MS_WORD_2007-XML.xcu since it was created.
        3.x commit 47c4912441c25438b4433069940a0dd4de385cca
        Author: Oliver Bolte on Thu Jan 10 11:56:37 2008 +0000
            2007/02/26 11:10:48 os 1.1.8.1: file MS_Word_2007_XML.xcu
        
        The one "GetUserData" implication I know
        is that "Insert - Text from file"
        uses a different code path and inserts the text with an additional CR.
        
        For FILTER_DOCX,
        likely extremely important is that it was not considered
        IsInWriterfilterImport() before... which looks important for undo.
        commit c4dab726caaa73be9f9c731312080143b0a0b89d
        Author: Caolán McNamara on Thu Mar 12 12:43:10 2020 +0000
            ofz#21168 sw,writerfilter: limit writerfilter hack to writerfilter
        
        FILTER_DOCX was introduced with this commit.
        It seems to be irrelevant and harmless for "import function" of autotext
        since DOCX files are already listed in the file picker...
        5.4 commit 0b31912b1df719c5507b22a2f63086cb8921f597
        Author: Szymon Kłos on Fri Apr 14 10:22:37 2017 +0200
            AutoText: .dotx files visible when import
        [ACTUALLY AutoText: .docx/.docm/.dotx files visible when import]
        
        Change-Id: I7c0b82bc2fb1730c8fff595b7171765339de0330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181645
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [8712673a445edeb28a5f3029bbcaa096f38d72e6]

        sw: use same paragraph properties as Word for hidden text
        
        This is a follow-up to commit 2bcfb7231b5ca74f02274cfb74ca8463f78905d6
        "tdf#152872 sw: conditionally hide paragraph breaks".
        
        Word determines the paragraph properties differently depending on
        whether paragraphs are merged by hidden text (where the first paragraph
        containing non-hidden text wins) or delete redlines (where the last
        paragraph wins).
        
        This fixes the hidden text situation while leaving the delete redline
        situation as it is.
        
        The problem is that CheckParaRedlineMerge() only considers hidden text
        on the paragraph end marker (RES_PARATR_LIST_AUTOFMT) but not elsewhere
        in the paragraph, so there are extents for the hidden text.
        
        The actual hiding of that is done via ScriptInfo::m_HiddenChg, which
        cannot be removed and replaced by merging because it is required for
        Writer's notion of hidden paragraphs in SwTextFrame::IsHiddenNowImpl().
        
        * FindParaPropsNodeIgnoreHidden() skips over nodes that contain only
          hidden text in case hidden text isn't shown
        
        * factor out ScriptInfo::InitScriptInfoHidden() because it is now needed
          to find the pParaPropsNode, but the rest of InitScriptInfo() requires
          the pParaPropsNode...
        
        * testTdf152872 requires changes as it was relying on ControlCharacters
          alone toggling the merging
        
        list of commits that tweaked setting pParaPropsNode:
        58353884dc86bdb3c1464f8bbf8c3e131584b78a (related: tdf#130685) sw: adapt definition of sw_redlinehide index 0
        b86ff2c6a88aa41379e74f11e8ec8497ff85ffd0 tdf#118699 sw_redlinehide: need some more changes to use the last node
        fa5eb82b398e29ae033f7b7c8c8195dfc10cf5b0 tdf#118699 change tracking: don't number empty lines
        beec1594587d0bf1ea2268f9a435c948b5580278 tdf#125319 sw_redlinehide: handle empty paragraphs more like Word
        c20308f1b919ca5ce61233068946e5fddb7eadb3 sw_redlinehide_4b: surprising discoveries
        
        Change-Id: If0e49a4d105dbf7d71e753967f36f2ec56f21f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181918
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-02-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [c42af7177292011d313188be547f65058a9949c6]

        postgresql: upgrade to 14.17
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.17/postgresql-14.17.tar.bz2
        
        Change-Id: I94beaecaa7ada4423d74b080770b4d1fcb28210e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181950
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1cd643693f04a8f1e9d58eab2e0d80f5e203bb05]

        drop obsolete android-gcc-toolchain switch
        
        it had been deprecated since ndk 13 where it defaulted to clang already
        and had been completely removed in ndk 18
        
        nss still checks for it in the nss/coreconf/Linux.mk makefile, but the
        paths it tries to set up there are unused/don't exist for a long while.
        
        Change-Id: Ie37104ae59b2143ec4645af3ff437ad06792ee65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181852
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b8e51e8a26b8b8faf63e457ba0c03651dd864d95]

        bump android ndk to 27.2.12479018 on CI
        
        Change-Id: I087e3e1aa8f7136bc020769a4d30c5e5ce9dbe3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181851
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [886798ee04f39c124f541549db18ec74ad886643]

        tdf#162769 android: Declare support for NDK versions up to 28
        
        With previous commits
        
            Change-Id: Icd45abee58e13a2fc77d78d12e823a8045272b4f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 19 13:44:55 2025 +0100
        
                android: Drop linker flag for libandroid_support
        
        and
        
            Change-Id: I759c5213b5f5873fc097a6ca0e0f0f85962e421b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 19 14:00:33 2025 +0100
        
                tdf#162769 android nss/nspr: Drop '-D_PR_NO_LARGE_FILES=1'
        
        , Android Viewer builds with NDK versions up to the latest
        version 28.0.13004108 now work fine, so add them to the list
        of supported versions so autogen no longer warns when
        they are used.
        
        Change-Id: I210a2783e88898e58031826c21f09349f5217a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181900
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [83450c00200d56079b8fe87d3eb6fd1b4c598dcc]

        tdf#162769 android nss/nspr: Drop '-D_PR_NO_LARGE_FILES=1'
        
        The `-D_PR_NO_LARGE_FILES=1` configure option causes a
        
            --with-android-ndk=$HOME/Android/Sdk/ndk/26.1.10909125/
            --with-android-sdk=$HOME/Android/Sdk
            --with-distro=LibreOfficeAndroidX86_64
        
        Android build (with NDK 26) to fail like this:
        
            [...]
            checking whether /usr/bin/ccache /home/michi/Android/Sdk/ndk/26.1.10909125//toolchains/llvm/prebuilt/linux-x86_64/bin/clang -target x86_64-linux-android21 -no-canonical-prefixes -ffunction-sections -fdata-sections -Qunused-arguments -glldb -Xclang -debug-info-kind=constructor -D_PR_NO_LARGE_FILES=1 -DSQLITE_DISABLE_LFS=1 accepts -pthread... yes
            configure: creating ./config.status
            config.status: creating Makefile
            config.status: creating config/Makefile
            config.status: creating config/autoconf.mk
            config.status: creating config/nsprincl.mk
            config.status: creating config/nsprincl.sh
            config.status: creating config/nspr-config
            config.status: creating config/nspr.pc
            config.status: creating lib/Makefile
            config.status: creating lib/ds/Makefile
            config.status: creating lib/libc/Makefile
            config.status: creating lib/libc/include/Makefile
            config.status: creating lib/libc/src/Makefile
            config.status: creating lib/tests/Makefile
            config.status: creating pkg/Makefile
            config.status: creating pr/Makefile
            config.status: creating pr/include/Makefile
            config.status: creating pr/include/md/Makefile
            config.status: creating pr/include/obsolete/Makefile
            config.status: creating pr/include/private/Makefile
            config.status: creating pr/src/Makefile
            config.status: creating pr/src/io/Makefile
            config.status: creating pr/src/linking/Makefile
            config.status: creating pr/src/malloc/Makefile
            config.status: creating pr/src/md/Makefile
            config.status: creating pr/src/md/unix/Makefile
            config.status: creating pr/src/memory/Makefile
            config.status: creating pr/src/misc/Makefile
            config.status: creating pr/src/threads/Makefile
            config.status: creating pr/tests/Makefile
            config.status: creating pr/tests/dll/Makefile
            config.status: creating pr/src/pthreads/Makefile
            config.status: executing default commands
            ../../../../../pr/src/md/unix/unix.c:2742:27: error: incompatible function pointer types assigning to '_MD_Fstat64' (aka 'int (*)(int, struct stat64 *)') from 'int (int, struct stat * _Nonnull)' [-Wincompatible-function-pointer-types]
                _md_iovector._fstat64 = fstat;
                                      ^ ~~~~~
            ../../../../../pr/src/md/unix/unix.c:2743:26: error: incompatible function pointer types assigning to '_MD_Stat64' (aka 'int (*)(const char *, struct stat64 *)') from 'int (const char * _Nonnull, struct stat * _Nonnull)' [-Wincompatible-function-pointer-types]
                _md_iovector._stat64 = stat;
                                     ^ ~~~~
            ../../../../../pr/src/md/unix/unix.c:3288:61: warning: passing 'int *' to parameter of type 'socklen_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Wpointer-sign]
                if (getsockopt(osfd, SOL_SOCKET, SO_ERROR, (char*)&err, &optlen) == -1) {
                                                                        ^~~~~~~
            /home/michi/Android/Sdk/ndk/26.1.10909125//toolchains/llvm/prebuilt/linux-x86_64/bin/../sysroot/usr/include/sys/socket.h:304:92: note: passing argument to parameter '__value_length' here
            __socketcall int getsockopt(int __fd, int __level, int __option, void* __value, socklen_t* __value_length);
                                                                                                       ^
            1 warning and 2 errors generated.
        
        A similar build issue for Android API levels < 21
        was fixed in NSPR commit [1] ("Bug 1784193 - Cast values when
        setting _md_iovector._{f,}stat64 on Android API < 21.")
        
        Patching nss/nspr to apply a similar change for the
        
            #elif defined(_PR_NO_LARGE_FILES)
        
        code there would fix this issue, too (see initial description
        in tdf#162769).
        
        However, it seems that the `-D_PR_NO_LARGE_FILES=1` configure
        flag for NSS/NSPR, originally added in
        
            commit 4082a18406c18af7b4fcef7bd501c3679c3be56b
            Date:   Wed Nov 22 23:08:06 2017 +0100
        
                android: use unified headers and llvm-c++ STL (x86) with NDK 16
        
        is no longer necessary these days, so drop it.
        
        (Potentially, more of the disabling of large file support
        introduced in the above-mentioned commit is no longer
        needed now or at least when bumping the minSdkVersion further.
        Section [2] on the "32-bit ABI bugs" page has some more details
        on large file support in different Android/NDK
        versions and mentions "by API 24 you have everything including
        <stdio.h>" - while our current `minSdkVersion` is 21.)
        
        Building and running Android Viewer and opening files (including a
        password-protected one, which is where NSS might be involved) worked
        fine in a quick test with these build/device configurations:
        
        * Android x86_64 AVD with API 35 (Android 15.0),
          NDK 26.1.10909125,
         `--with-distro=LibreOfficeAndroidX86_64`
        
        * Samsung Galaxy S4 GT-I9505 (32 bit ARM) LineageOS 17.1
          (based on Android 10), NDK 25.2.9519653,
          `--with-distro=LibreOfficeAndroid`
        
        Tests with a build with this change in place using the latest NDK 28.0.13004108
        also worked fine on the above 2 devices (x86_64, 32-bit ARM)
        and a Fairphone 3+ (aarch64, LineageOS 21, based on Android 14)
        and an x86 AVD (API 24, i.e. Android 7.0).
        
        [1] https://phabricator.services.mozilla.com/D154336
        [2] https://android.googlesource.com/platform/bionic/+/refs/heads/main/docs/32-bit-abi.md#32_bit-and
        
        Change-Id: I759c5213b5f5873fc097a6ca0e0f0f85962e421b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181899
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [38d3c9abe6c3e32b25fa15258d9c121225f37ad7]

        android: Drop linker flag for libandroid_support
        
        According to [1], libandroid_support is no longer needed
        for API level >= 21. Quoting from the issue:
        
        > Dropping KitKat will have greater benefits than the other API levels
        > we've dropped support for over the years (and while not the only reason,
        > one motivation for the prior support removals was getting us
        > closer to being able to drop 19/20):
        >
        > 1. libandroid_support will no longer be needed.
        >   i. libandroid_support
        >      adds to the APK size for all apps. Even if your minSdkVersion is
        >      21+, libc++ is built for the lowest API level supported by the NDK,
        >      so it includes some pieces of libandroid_support.
        > [...]
        
        The LO Android build no longer supports API versions < 21
        since:
        
            commit c2fc2c8c7c63ca4e43bca6e8c9b82c50418422d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 5 09:57:22 2023 +0100
        
                android: Bump minSdkVersion to 21 (Android 5.0)
        
        The linker flag was otherwise now causing linker errors in an NDK 28
        build in a WIP branch including a fix for tdf#162769, using
        
            --with-distro=LibreOfficeAndroidX86`
            --with-android-sdk=/home/michi/Android/Sdk
            --with-android-ndk=/home/michi/Android/Sdk/ndk/28.0.13004108/
        
        Error:
        
            Linking /home/michi/development/git/libreoffice-WORKTREE-android/android/obj/local/x86/liblo-native-code.so
            ld.lld: error: unable to find library -landroid_support
            clang++: error: linker command failed with exit code 1 (use -v to see invocation)
        
        The linker flag had already been dropped earlier in
        
            commit a7f6338875931d8afff55cb39ead8f6600af04cb
            Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Date:   Wed Aug 7 12:06:25 2019 +0200
        
                android: support NDK 19 and above (20 as of this commit)
        
        but was restored in
        
            commit f68a36b62ed327eb67efdfea0ac46645b4d90877
            Date:   Fri Oct 25 07:42:30 2019 +0200
        
                android: Fix problems with unwinding in the Online-based Android app.
        
                This partially reverts a7f6338875931d8afff55cb39ead8f6600af04cb.  The
                problem is that with that approach, the problems with unwinding as
                described in 312eeeee42cb4a1e356943e17305555e41afc4ef were plaguing the
                Online-based Android app, leading to mysterious crashes with stack
                traces like:
        
                 #00 pc 0005f2b6  /apex/com.android.runtime/lib/bionic/libc.so (abort+166) (BuildId: 68c87e04526a60689ecb5deb329804a0)
                 #01 pc 05caaae7  /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b)
                 ...
                 #06 pc 07452e43  /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b)
                 #07 pc 0005a37c  /apex/com.android.runtime/lib/bionic/libc.so (__restore_rt) (BuildId: 68c87e04526a60689ecb5deb329804a0)
                 #08 pc 0005f2b2  /apex/com.android.runtime/lib/bionic/libc.so (abort+162) (BuildId: 68c87e04526a60689ecb5deb329804a0)
                 #09 pc 07565d3b  /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b)
                 ...
                 #11 pc 07565641  /data/app/libreoffice.debug-fBEOIUwPHY3_k3eQid159Q==/lib/arm/liblo-native-code.so (BuildId: 1c3d0e6336ddfc3578e1c186944160252a750b8b)
                 #12 pc 0001e394  /apex/com.android.runtime/lib/bionic/libm.so (__gnu_Unwind_RaiseException+108) (BuildId: 0ee3a75927e0da4fa0fe29469ccf8b39)
                 #13 pc 0001eee8  /apex/com.android.runtime/lib/bionic/libm.so (_Unwind_RaiseException+20) (BuildId: 0ee3a75927e0da4fa0fe29469ccf8b39)
        
        Hopefully whatever was the problem back then is not
        retriggered by dropping `-landroid_support` again
        these days.
        
        [1] https://github.com/android/ndk/issues/1751
        
        Change-Id: Icd45abee58e13a2fc77d78d12e823a8045272b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181898
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [347a437dc6d854d9ab92503cc18b1e8bf803d358]

        use more concrete UNO types in some local vars
        
        found by a clang plugin I created.
        
        Change-Id: I109cf2ebd48e39a626c975da2199bf25edc3bb27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181933
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e420583fee9f753e7de5a207637fda25e495ac7d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 61e86f1a3118747875f4ea5838ccdebe0ddbcc54
          - Fix syntax parameter description for consistency
            
            + After remarks from L10n list
            
            Change-Id: I71b25f20c0cb52ce4533ebd70d4d10f6617a75a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181945
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63f3573dd7a68ddd44fe9bd723d3597b8772c7e9]

        cid#1643103 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I729b1e59b3320e698de503eb248efed555e605b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181938
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0fe2b9cf985bd77483a716c825734956f3dc828]

        use more concrete UNO types in some local vars
        
        found by a clang plugin I created.
        
        Change-Id: I72ebc2b6fadb854a12d69a543facf2fd7e4f1e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181932
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-20  Attila Szűcs  <attila.szucs@collabora.com>  [240a3a5303082e461d190bdff7d92d4cc9b330c7]

        FillApi: fixed JSON validity issues
        
        Changed extract to always extract a valid JSON file.
        
        Extract changed in 2 place:
        At charts:
        old format:
        "DataValues": [
            "Row.0": [ "22", "24"],
            "Row.1": [ "18", "16"],
            "Row.2": [ "32", "32"],
            "Row.3": [ "25", "23"]
        ]
        
        New:
        "DataValues": [
            [ "22", "24"],
            [ "18", "16"],
            [ "32", "32"],
            [ "25", "23"]
        ]
        
        At Slides the following arrays changed to objects:
        "MasterSlides" [ -> "MasterSlides" {
        "Slides" [ -> "Slides" {
        "Objects" [ -> "Texts" {
        "Texts" [ -> "Texts" {
        
        Change-Id: I18180db714c0d0701380376a72e608cb080b67cd
        
        ---
        
        Transform will still accept the old not valid JSON files also,
        But for now, they will also accept a bit different JSON format file
        that is valid JSON.
        
        "Transforms" now can be an array and all of its element an object
        old:
            "Transforms": {
                "Charts.ByEmbedIndex.0": {
        new:
            "Transforms": [
                { "Charts.ByEmbedIndex.0": {
        
        The same chanes was at :
        "Charts.????"
        "UserDefinedProperties"  //at Document Properties
        
        ---
        
        These changes was needed only becsuse of 2 JSON rule:
        1: Arrays can not conatin propertyes.
        (only values, and objects are allower)
        2: Objects cannot have 2 property with the same name.
        
        Also updated unit tests.
        
        Change-Id: I70311b1c6da57305dc1d9e8ec1f29ab5aa93ee56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181934
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2578da962608a2123d637b80499123c258829582]

        return concrete UNO class in oox::AttributeList::getFastAttributeList
        
        Change-Id: I9d149b15f495080f25c1ace7fa29c4c9bb20ce10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-20  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [481b0844d82a92faaecc9db73f6973093dd21c04]

        tdf#145538 Use range based for loops
        
        refactor: Simplify loops in MergeNotebookBarAddons and MergeNotebookBarMenuAddons functions
        
        Change-Id: Ie7c8daebca810d05a652dd995827248a1dee89de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181926
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [fbefe07e4c4a8959278ea08a247d75612994727c]

        qt: Remove now unused vcl/inc/qt6/QtSvpSurface.hxx
        
        , following
        
            commit 704f61b1bd2c54831c383e34e74315bd6da356e2
            Date:   Wed Jan 29 15:35:21 2025 +0200
        
                remove canvas/cairo and canvas/gdi and canvas/directx backends
        
        and
        
            commit 595354ab7e01546765d84103aaf2bc38e5d3c9b3 (HEAD -> master, origin/master, origin/HEAD)
            Date:   Wed Feb 19 21:13:49 2025 +0100
        
                Remove also canvas/cairo in gtk4, qt6 and gtk3_kde5
        
        Change-Id: If8366bdb6eb3e10de7917cc5c80848eb62c0cbd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181930
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [897a924d9badc0df17835131d9a4a3efb15c3586]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d586cc95d7eeebecddaaea6ba106df6596d2367a
          - tdf#165271 Improve Option dialog for Pivot Table
            
            Change-Id: I1e94afdc330e6530042311fea554661562cce6ae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181798
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            Tested-by: Jenkins
            
2025-02-20  Simon Chenery  <simon_chenery@yahoo.com>  [748fef9fbd9a2818c58bcb149092b3960448ea14]

        tdf#145614 Convert #define MAX_ENTRIES to constexpr
        
        Change-Id: Ibe561bcd4376e98528d1ef9f3e8ed708c21816cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181925
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-20  Miklos Vajna  <vmiklos@collabora.com>  [36c5ef2d8b50aa7a5cbe55d68c37ed26a73e8498]

        vcl: remove unused include
        
        Mostly just to test CI with a change.
        
        Change-Id: Ia9a6d81bf94c36105936b612d7438ab2373ea715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181928
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-20  Bayram Çiçek  <bayram.cicek@collabora.com>  [02398c20b206c016f210705f6de312c1eecf0d19]

        tdf#123225 - export <rowItems> and <colItems>
        
        of xl/pivotTables/pivotTable*.xml.
        
        - additionally, export <i> and <x> with their default attribute values.
        
        - <x/> single element has only "v" attribute and its value is
        increased by 1 up to the count attribute value of rowItems/colItems.
        
        - it is expected that this will fix function loss in XLSX pivot table's
        context menu and there will be no need to refresh the pivot table.
        (ODS -> XLSX)
        
        - this is also fix "Cannot determine which PivotTable field to sort by"
        warning on Excel if you try to e.g. sort the items - alongside the loss
        of functions.
        
        - add testTdf123225PivotTableRowColItems Cpp unit test
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Id44806e666a55500ba3faeb0571e50e407c15791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181795
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-20  Julien Nabet  <serval2412@yahoo.fr>  [595354ab7e01546765d84103aaf2bc38e5d3c9b3]

        Remove also canvas/cairo in gtk4, qt6 and gtk3_kde5
        
        Change-Id: Ic70ee92011ee04a4d4246c8c9ba81ce7832596f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2933da20065af063bb06ef3d022dfe4a56f6d93a]

        Emscripten: Let runUnoScriptUrls handle all scripts in one go
        
        ...so that the !HAVE_EMSCRIPTEN_PROXY_TO_PTHREAD case (introduced in
        bc60c54878185bcd7d95cc87e9b94a785a086915 "If necessary, fall back to an
        approximation of WorkerGlobalScope.importScripts") can make sure that one script
        is fully evaluated before the next is loaded, to avoid a race when some script
        depends on an earlier script
        
        Change-Id: I5fca4d7aa5d7e9b8d86b59667c599f62f1f3064c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181905
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7a84593ec130b41da35d98fe7d45a71706935909]

        Create Data on demand in comphelper::emscriptenthreading::getData
        
        ...and get rid of comphelper::emscriptenthreading::setUp.  This will help with a
        potentially forthcoming change to move initUno in desktop/source/app/appinit.cxx
        to the eventHandlerThread (so code in both desktop and in vcl/qt5 would need the
        comphelper::emscriptenthreading::Data and it would be unclear which should call
        setUp).
        
        Change-Id: I157f80a450d8eeabd6d0317c881c6a9ea67fc59a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181908
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5e1973754a9b924b2d9362c6083866d2cf93b790]

        Redesign comphelper::emscriptenthreading::Data::eventHandlerThread
        
        Instead of being a thread that keeps blocking in C++
        emscripten::ProxyingQueue::execute(), make it a thread that immediately goes
        back to the browser event loop via emscripten_exit_with_live_runtime().  (Which
        will eventually allow setupMainChannel from desktop/source/app/appinit.cxx to
        run on that thread and receive the "LOWA-channel" JS message event.)
        
        The thread is detached now and no longer joined in
        comphelper::emscriptenthreading::tearDown, but that was mostly academic anyway
        (as LOWA doesn't terminate in the traditional sense, and just stops when you
        close its browser tab).
        
        Change-Id: I32270cfc602549cf26b99c6f66811b3aca5ea5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181907
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-19  Michael Weghorn  <m.weghorn@posteo.de>  [4d580ab25c24fc2293f41a3b580c874f817ee7aa]

        tdf#130857 qt weld: Format QtInstanceFormattedSpinButton value
        
        Set a function used to convert the value to text to show in
        the QtDoubleSpinBox used in QtInstanceFormattedSpinButton.
        
        For further background, see also
        
            commit 6871b55b6915396caa3e5aca7e233f6a5efc7864
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 17:47:01 2025 +0100
        
                tdf#130857 qt weld: Implement SpinButton text <-> value conversion
        
        and related commits doing similar for QtInstanceSpinButton.
        
        This e.g. makes the time value shown in the Impress
        "Slide Show" -> "Slide Show Settings" dialog be formatted
        as expected in a WIP branch that declares support
        for that dialog.
        
        Conversion the other way around (i.e. text to value)
        is still missing.
        
        Change-Id: I229553c15ca318643472b9ca797f0a81060a3f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181914
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-19  Michael Weghorn  <m.weghorn@posteo.de>  [15adb8396cc8f2a1c693f3d11bcd7d42a1aad41a]

        tdf#130857 vcl: Extract Formatter method to convert value to string
        
        Extract logic to convert a value to a string from
        Formatter::ImplSetValue to a new method Formatter::FormatValue.
        
        The new method will also be used by QtInstanceFormattedSpinButton in
        an upcoming commit.
        
        Change-Id: I8735cf49c9c72f2fba3782256a7f54507bcf76e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181913
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-19  Michael Weghorn  <m.weghorn@posteo.de>  [f6f79531d84f59188bbff3d97cef79140b2eb3ad]

        vcl: Return ref in Formatter::GetOrCreateFormatter
        
        This makes it more obvious that it's non-null.
        Drop 2 corresponding `DBG_ASSERT`s that were
        checking exactly this.
        
        Change-Id: I5b2de299664d93b3ba71582a2c7907b17bbbc9b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181912
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-19  Michael Weghorn  <m.weghorn@posteo.de>  [20e1c3d2f35afba1adf0e5852a83a753efaf500d]

        tdf#130857 Let Formatter:m_aOutputHdl convert double to text
        
        So far, the Formatter:m_aOutputHdl output handler set via
        Formatter::SetOutputHdl did not receive any parameter
        and had the responsibility to set the text based on
        the current value, i.e. first retrieve the current
        value, then convert it to a text representation, and
        then set that text in the formatter.
        
        Change semantics so that the method instead receives
        the (double) value to format as a parameter and
        returns the formatted string.
        
        Passing the current value as a double and using the
        returned string to update the text is now the responsibility
        of the only caller, Formatter::ImplSetValue.
        
        Adjust the naming accordingly:
        
        * Formatter:m_aOutputHdl -> Formatter::m_aFormatValueHdl
        * Formatter::SetOutputHdl -> Formatter::SetFormatValueHdl
        
        This is similar to the change done elsewhere in
        
            commit 76396a371eb7dfef79963d00fea54a989f54fbbc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 13:44:50 2025 +0100
        
                tdf#130857 weld: Abstract from "input"/"output" SpinButton signals
        
        (and changes referenced from its commit message)
        and is one step towards supporting value <-> text
        conversion in QtInstanceFormattedSpinButton as well.
        
        No change in behavior is intended by this commit.
        
        Change-Id: I6b3fbccc89b89446a1ea367a80aeed3a7b583298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181911
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [f310b47ead5bf4a85a1c93d15b3c5f78f6675f7a]

        sc: Add basic UItest for ColorScaleFormatDialog with 2 entries
        
        Change-Id: I1ecbe1bfde1bf42de24832286eca795f74e135de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181916
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [849461b17ca124c111aff27ed7e6bf4d47b012fd]

        sc: Add basic UItest for ColorScaleFormatDialog with 3 entries
        
        Change-Id: If38de58b22c94748c8e5db7423c57b24ad934f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181910
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [29751c4eb4004d1c4c8205f0f4c6bef8f88f3512]

        tdf#163316: sc: Add basic UItest for IconSetFormatDialog
        
        Change-Id: I0c6ad7983addd8d24a0b79874aa8f095a58d93e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181909
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [ef3a2624657645d61fa66e0188f40f14f506770a]

        SwFormatCharFormat: SwClient no more
        
        Change-Id: Ic41688ed012373738b00ad24755ca47ad52b956b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181849
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2025-02-19  Noel Grandin  <noelgrandin@gmail.com>  [d539f6e99e1be89e6133b2ef623c67bf4f0cff4f]

        fix "local variable is unused" warning
        
        on Windows release build
        
        Change-Id: Ia9e95f967b728efdcc2bbb8b73ddffedfa042c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181915
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b96c634d3190dc5441548be1752da13c47d293fd]

        Fix typo
        
        Change-Id: I4a956e71e54051da58ef75e936106ba21bf501d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181894
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [595165ea76afc5bd552e5bc7e0185cd0ceca966e]

        Fix typo
        
        Change-Id: Ia88014fd1eb18d3fb828a748aa890479a7a3272a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181893
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [b6953ce38b0117efc5e2023fb7641b764c357fad]

        tdf#163897: sc: Add UItest
        
        Change-Id: I14e96cd9d3c937e4387188b445b1fd2b91a01b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181885
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-19  Noel Grandin  <noelgrandin@collabora.co.uk>  [704f61b1bd2c54831c383e34e74315bd6da356e2]

        remove canvas/cairo and canvas/gdi and canvas/directx backends
        
        These were originally created to better support alpha/transparency
        in slideshows, but vcl can do that these days.
        
        Mostly, removing these makes the path to better backends (e.g. GDI+)
        in vcl considerably easier.
        
        If regressions are detected, it would be better to improve vcl
        to perform better, or render better, since that will both fix
        the regression and improve other output from LibreOffice.
        
        Also remove various bits of vcl backend that were only being
        used by the canvas stuff.
        
        Change-Id: Ic5276d57e696f3dcbeaed2cc149b8fc09c5816f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e37feb060c2a5c823d1e762a87bdca09995f480]

        tdf#164722: sc: Add UItest
        
        Change-Id: If7d778596d56750344cca56a6666aa02fe40adc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181891
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [f838f886aab79ef5c09c3f9b4c701cefec9c8576]

        tdf#165160 active and non-active parts of ruler should be distinctable
        
        Change-Id: I52d280b5253fec3c090a4e1d0c49b028142ae1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181879
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2025-02-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b37d52696c393d8f4a908b67932a1ecf4aa7b917]

        changes to distro-config files also should trigger re-running autogen.sh
        
        As otherwise if autogen.input contains a --with-distro-config=foo line
        and if that distro-configs/foo.conf get changed, the build won't pick
        up the changes unless autogen.sh is triggered manually, and that's not
        what is intended/expected.
        
        Change-Id: I81523572cedb953fff7cb69b8739fb1c76c9718a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181886
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [8303c3f6496663fa8564e2e07255f2f28e0ed925]

        tdf#162692: sc: Add UItest
        
        Change-Id: Idff9b6de54a57aded82b12b2841ea5e2301f1032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181887
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Miklos Vajna  <vmiklos@collabora.com>  [f12991396dbb9c00e75978569e1bf110f7dcb50f]

        cool#11064 vcl lok: fold the scheduler info into the anyinput callback
        
        This changes the LOK API added in commit
        e9e39e45f0daed52276377321088aa4d49b112b6 (cool#11064 vcl lok: expose
        info about the scheduler, 2025-02-14) so that a LOK client doesn't have
        to query the priority of the most urgent task: instead the anyInput
        callback gets it as a parameter.
        
        The scheduler is a hot path and it's not expected this priority
        information would be needed in other places, so folding the new LOK API
        into the anyInput callback simplifies things.
        
        Change-Id: I1385055bfa27f47a243d40683b54cb2ddc9d33bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181878
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ccefc5e5244d06871f6452ef00b33dd8cc73d562]

        [API CHANGE] remove XTiledRenderable
        
        which is an abandoned experiment, the tiled rendering for LOK moved in a
        different direction
        
        Change-Id: Idccd22d5124cc7c7add55b76edc75ef27df59a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181862
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-19  Patrick Luby  <guibmacdev@gmail.com>  [d59011736e78f87c5f21ec01a9cf5e83d7996070]

        Fix iOS build breakage
        
        Although I think this is a safe commit, I cannot test it since
        the Collabora Online master branch is currently paired with the
        LibreOffice distro/collabora/co-24.04 branch and so the Collabora
        Online code fails to build against the LibreOffice master branch.
        
        Change-Id: Ie7497974dfa53b27ced616fc8f958bb31d915d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [934f40d2b55bf40756cd596a149dfb7c766efc2f]

        libpng: upgrade to 1.6.47
        
        Downloaded from
        https://sourceforge.net/projects/libpng/files/libpng16/1.6.47/libpng-1.6.47.tar.xz/download
        
        Change-Id: I8fc0469fa034b7da7850e42d8ed635b0959952f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181864
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [71e781cbe597a6173e9956e14f82bfa661df9dde]

        Introduce DBG_TESTNOTSOLARMUTEX, to complement DBG_TESTSOLARMUTEX
        
        ...and use it in one place for the experimental Emscripten Qt6
        JSPI/non-PROXY_TO_PTHREAD mode (where I have a hunch that some of the deadlocks
        I experience in that experimental mode are due to a mis-locked SolarMutex)
        
        Change-Id: Ifb335202569b7d2beecd7a502064ebcfdaaddbab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181872
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3fe202579fa8afdf2369cb6eba3c00cd7db5b2b3]

        cid#1643100 DLS: Dead local store
        
        since:
        
        commit a2888a8f5a2fd5a01a709ce445fe479059c16d59
        CommitDate: Tue Feb 18 16:06:22 2025 +0100
        
            tdf#161144 Fix ambiguous sorting in Query Wizard
        
        Change-Id: I965675a0b8c36dd65c6a637471a61eb32dd1a908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [dbff1a3506ef405829afc91cba92c1bc82d010c1]

        libassuan: upgrade to 3.0.2
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libassuan/libassuan-3.0.2.tar.bz2
        
        Change-Id: I007756045035517ef17eaa45086b3858eaf49f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181870
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Jean-Pierre Ledure  <jp@ledure.be>  [ec71ff69fed9a2ed247760abcf653dbc07b47002]

        ScriptForge (SF_Calc) formatting methods
        
        So far only the SetCellStyle() method
        provided means to modify cell formats.
        
        The actual patch introduces next methods
        to apply simple and common formats. For
        other options use the XCellRange
        UNO interface.
        
        - calc.AlignRange(targetrange,alignment,...)
        - calc.BorderRange(targetrange,borders,...)
        - calc.ColorizeRange(targetrange,foreground,background,...)
        - calc.DecorateFont(targetrange,fontname,fontsize,
                 decoration,...)
        - calc.FormatRange(targetrange,numberformat,locale,...)
        
        Extra arguments ("...") are:
          FilterFormula: a Calc formula to select cells
          FilterScope; CELL, ROW or COLUMN
        to allow a kind of static conditional formats.
        
        All methods are applicable to Basic and Python
        user scripts.
        
        This change will require an update of the
        user documentation.
        
        Change-Id: Ic824aebd763f2b55364c2c0bea17430f32512742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181854
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [09721edb1c48c996b965b2e533f271d9df401414]

        libxml2: upgrade to 2.13.6
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.6.tar.xz
        
        Change-Id: Ia52a7fd49d9db7a339e5defacce866e4aad34efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181867
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ce4e8a5686933511070722db2215784aceef98ce]

        Emscripten: Make --with-main-module easier to extend in the future
        
        ...beyond calc and writer
        
        Change-Id: I68a1e65cc45c4188c50b27172d644818ac874def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181856
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fe678ffc6f6f0e851c3b7b7b0c8a1b8219b819a2]

        Emscripten: No need to pass --with-main-module into build configure
        
        No idea why 97ee126d69859d01abfbdb55450d27afb71bf9b1 "WASM add Calc as optional
        build result, make it build & run" had added that.  ENABLE_WASM_STRIP_CALC and
        ENABLE_WASM_STRIP_WRITER will always be set to empty values in config_build.mk
        anyway.
        
        Change-Id: I07a3863f8396149481507f5ed558d130e34a44dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181855
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-02-19  Rahul Anand  <rahul.anand1222004@gmail.com>  [f92a82639abbe61d191cffbeed780a7bb91c3cf0]

        tdf#145759 Use symbolic constants instead of magic numerical constants
        
        Change-Id: I97d63d576527bed7f07ade501a10027129dbf18d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181311
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-19  Michael Weghorn  <m.weghorn@posteo.de>  [2bd9ff78c7be6a66a3f4b381bf6726dcce9e2814]

        tdf#130857 qt weld: Introduce QtInstanceFormattedSpinField
        
        This is the weld::FormattedSpinField implementation
        using a native Qt widget.
        
        Implementation mostly inspired by the GTK implementation
        in GtkInstanceFormattedSpinButton as well as
        QtInstanceSpinButton.
        
        What's still missing is to implement the conversion
        between value and text (both ways) similar to what
        
            commit 6871b55b6915396caa3e5aca7e233f6a5efc7864
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 17:47:01 2025 +0100
        
                tdf#130857 qt weld: Implement SpinButton text <-> value conversion
        
        implemented for QtInstanceSpinButton.
        
        However, this needs more refactoring elsewhere first.
        
        Change-Id: I06647dc1b43a05dd86d4488f213d0f0c72566cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-19  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [12d487285b4e25415d6807f1856536418640c453]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: I35b815e45debc479d20c956fd07a188d0251853d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181293
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [fdd666e566a9fe37200c5cd67a8cbc622da7b4ec]

        tdf#165271 Improve Option dialog for Pivot Table
        
        Change-Id: I2317ab71c11da62abb400a67cbe5a93c11f39005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181797
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-02-19  Noel Grandin  <noelgrandin@gmail.com>  [1849e2d46c42412e2d98c80aef1c9f8f2f524b5a]

        partially implement EMR_CREATECOLORSPACE
        
        just enough to make it stop spitting out hundreds of warnings
        when I am debugging
        
        Change-Id: Icbfcd334ee568c2154f665fc31646982cceb52aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181846
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f9b9bf030618f66eccf9168413f1935ac521f161]

        tdf#165261 - PPTX import: fix text in shape is left-aligned
        
        instead of being centered
        
        regression from: 1d9ce0a67a71e51569cd33c26270eeece587a354
        (tdf#162571 - sd: Text box expands or shrinks on left or right or...)
        
        Change-Id: Ieed39426dc5aec7a34d15bbb0a4faaeba04ba50f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181822
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-02-18  Jim Raykowski  <raykowj@gmail.com>  [6d978385b1d34fe0703ca9cc841c7ea67abd47cc]

        Resolves tdf#165223 SB Navigator 'Reminder' objects set in a block of
        
        text are copied and pasted with that text, corrupts the movement
        stack
        
        Change-Id: Icce2a96184099f62ccac1475cb57fdb9e6975847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181759
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2025-02-18  Simon Chenery  <simon_chenery@yahoo.com>  [63d7583c0ab864787f0ad9c45f27c206e2904b98]

        tdf#39468 Translate German word "gerade" in comment to English
        
        Change-Id: I247547e9e23f81bd01a90507b0863e7cd2cb01c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181505
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-02-18  Alexandre Sena Coelho  <alexandre_ti@yahoo.com>  [a2888a8f5a2fd5a01a709ce445fe479059c16d59]

        tdf#161144 Fix ambiguous sorting in Query Wizard
        
        Fix ambiguous sorting in Query Wizard by including table names in
        ORDER BY clause
        
        Change-Id: Ie178c366f501156f72ff0bd441a75be98dc15220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179564
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [46cadd6b03294202ac27f1c3587d66e08e0b797e]

        Some more need for EmscriptenLightweightRunInMainThread
        
        This code can be reached e.g. when
        <https://github.com/allotropia/zetajs/blob/main/examples/simple-examples/rainbow_writer.js>
        is executed not on the main browser thread,
        
        > Aborted(Assertion failed: invalid handle: 14)
        > threadPrintErr	@	soffice.js:900
        > abort	@	soffice.js:1202
        > assert	@	soffice.js:658
        > toValue	@	soffice.js:7308
        > __emval_call_method	@	soffice.js:9856
        > $QWasmWindow::frameMargins() const	@	soffice.wasm:0x83de160
        > $QWasmWindow::setGeometry(QRect const&)	@	soffice.wasm:0x83dd1a6
        > $QWindow::setGeometry(QRect const&)	@	soffice.wasm:0x7cfd8a1
        > $QWindow::setPosition(int, int)	@	soffice.wasm:0x7cff114
        > $QWidgetPrivate::setGeometry_sys(int, int, int, int, bool)	@	soffice.wasm:0x8041fd9
        > $QWidget::move(QPoint const&)	@	soffice.wasm:0x80419ab
        > $QtFrame::SetScreenNumber(unsigned int)	@	soffice.wasm:0x65b5c61
        > $QtFrame::ShowFullScreen(bool, long)	@	soffice.wasm:0x65b418f
        > $non-virtual thunk to QtFrame::ShowFullScreen(bool, long)	@	soffice.wasm:0x65b4231
        > $WorkWindow::ShowFullScreenMode(bool)	@	soffice.wasm:0x1553b3f
        > $VCLXTopWindow::setFullScreen(unsigned char)	@	soffice.wasm:0x123f6b4
        > $non-virtual thunk to VCLXTopWindow::setFullScreen(unsigned char)	@	soffice.wasm:0x123f727
        > $callVirtualFunction_vii	@	soffice.wasm:0x659ab75
        > $callVirtualFunction(std::__2::basic_string_view<char, std::__2::char_traits<char>>, unsigned long, unsigned long long const*, void*)	@	soffice.wasm:0x6526a40
        > $(anonymous namespace)::call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, long, _typelib_MethodParameter*, void*, void**, _uno_Any**)	@	soffice.wasm:0x651f2ea
        > $unoInterfaceProxyDispatch	@	soffice.wasm:0x651e742
        > $stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::set(com::sun::star::uno::Any&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64ec9ec
        > $non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::set(com::sun::star::uno::Any&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64ecb76
        > $(anonymous namespace)::ImplIntrospectionAccess::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64a4ec4
        > $non-virtual thunk to (anonymous namespace)::ImplIntrospectionAccess::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64a8b18
        > $stoc_inv::(anonymous namespace)::Invocation_Impl::setValue(rtl::OUString const&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64b3e81
        > $non-virtual thunk to stoc_inv::(anonymous namespace)::Invocation_Impl::setValue(rtl::OUString const&, com::sun::star::uno::Any const&)	@	soffice.wasm:0x64b66bc
        > $emscripten::internal::MethodInvoker<emscripten::internal::rvp::default_tag, void (com::sun::star::script::XInvocation::*)(rtl::OUString const&, com::sun::star::uno::Any const&), void, com::sun::star::script::XInvocation*, rtl::OUString const&, com::sun::star::uno::Any const&>::invoke(void (com::sun::star::script::XInvocation::* const&)(rtl::OUString const&, com::sun::star::uno::Any const&), com::sun::star::script::XInvocation*, rtl::OUString*, com::sun::star::uno::Any*)	@	soffice.wasm:0x48dbe6
        > uno_Type_com$sun$star$script$XInvocation.setValue	@	VM1145:10
        > invokeSetter	@	zeta.js:444
        > Object.defineProperty.set	@	zeta.js:485
        > (anonymous)	@	rainbow_writer.js:36
        > setInterval
        > demo	@	rainbow_writer.js:36
        
        Change-Id: I9380e2aba1d87cef6ce858b7755bdd3f01484021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [0b7e2e77b745a5f510b5192f487aab4bf8a8ab20]

        gtk: Port from deprecated gtk_widget_hide
        
        This is basically the same as
        
            Change-Id: Ib99a8c2420c50d918392070b10adb1aa5544492d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 18 13:50:46 2025 +0100
        
                gtk: Port from deprecated gtk_widget_show
        
        , but now for `gtk_widget_hide` [1], which was also deprecated
        in GTK 4.10.
        
        [1] https://docs.gtk.org/gtk4/method.Widget.hide.html
        
        Change-Id: I5029a9553feeebfaaaa2499cbc7544c324a12fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181834
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [ac0e7ccc03ff4c21cc2311246aa248a3ad3bcea2]

        gtk: Port from deprecated gtk_widget_show
        
        `gtk_widget_show` was deprecated in GTK 4.10 [1].
        Replace with calls to `gtk_widget_set_visible` instead
        (which itself just calls the deprecacted `gtk_widget_show`
        internally for now in GTK 4 [2]) as recommended.
        
        While it's not deprecated for GTK 3, also replace it in gtk3-only
        code where the semantics are the same. Quoting from the
        GTK 3 `gtk_widget_set_visible` doc [3]:
        
        > This function simply calls gtk_widget_show() or gtk_widget_hide() but is
        > nicer to use when the visibility of the widget depends on some
        > condition.
        
        A similar change will be done for `gtk_widget_hide`
        in an upcoming commit.
        
        [1] https://docs.gtk.org/gtk4/method.Widget.show.html
        [2] https://gitlab.gnome.org/GNOME/gtk/-/blob/849b5e55d531a8a5645487853cb3876681674c31/gtk/gtkwidget.c#L5837-5859
        [3] https://docs.gtk.org/gtk3/method.Widget.set_visible.html
        
        Change-Id: Ib99a8c2420c50d918392070b10adb1aa5544492d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181833
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1f24fd93763f0ef7f24a761ebee535dd5df33e24]

        Emscripten: Add ClassHandle to EXPORTED_RUNTIME_METHODS
        
        ...as it is used since the initial commit of
        <https://github.com/allotropia/zetajs/blob/7122b81eface9d435fe4e4dd7b65582e30e1368b/source/jsuno.js#L65>
        (and where it should arguably be used as Module.ClassHandle rather than just as
        plain ClassHandle, but which requires it to be listed in
        EXPORTED_RUNTIME_METHODS)
        
        Change-Id: Ic2f32eab8e61d06a0c68241a46cda3d81a121dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181831
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [048cc17da1102b001d756dbe49f7c4f3005ab31e]

        tdf#126824 Make l10n for Data Provider transforms
        
        + Moved data provider transformation names to ui file
        + Adjust controller
        
        PS2: transform into static array.
        PS3: handle thru indexes to prevent issues with reordering
        
        Change-Id: I3be6fe4c466c4b041884f3808faea44c26efe021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181657
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [45cfeed90899ff43015d9ee9e3bbf42ea07d8992]

        tdf#165211 android: Include tabbuttonsmirrored.ui
        
        This fixes a crash seen when trying to open the
        sample file from tdf#165211. From ADB log:
        
            02-18 12:10:07.538  7343  7378 E libo:sal/osl/unx/file: failed to open /assets/share/config/soffice.cfg/svt/ui/tabbuttonsmirrored.ui
            02-18 12:10:07.538  7343  7378 W vcl.builder: 1:include/vcl/widgetbuilder.hxx:74: Unable to read .ui file file:///assets/share/config/soffice.cfg/svt/ui/tabbuttonsmirrored.ui
            02-18 12:10:07.538  7343  7378 F libc    : /home/michi/development/git/libreoffice-WORKTREE-android/include/vcl/widgetbuilder.hxx:76: void WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu>>::processUIFile(Widget *) [Widget = vcl::Window, WidgetPtr = VclPtr<vcl::Window>, MenuClass = PopupMenu, MenuPtr = VclPtr<PopupMenu>]: assertion "false && "missing ui file or missing gb_CppunitTest_use_uiconfigs dependency"" failed
            02-18 12:10:07.538  7343  7381 I stderr  : /home/michi/development/git/libreoffice-WORKTREE-android/include/vcl/widgetbuilder.hxx:76: void WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu>>::processUIFile(Widget *) [Widget = vcl::Window, WidgetPtr = VclPtr<vcl::Window>, MenuClass = PopupMenu, MenuPtr = VclPtr<PopupMenu>]: assertion "false && "missing ui file or missing gb_CppunitTest_use_uiconfigs dependency"" failed
            02-18 12:10:07.538  7343  7378 E LibreOffice/androidinst: SalAbort: 'Unspecified application error'
            02-18 12:10:07.538  7343  7378 F libc    : Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 7378 (Thread-2), pid 7343 (org.libreoffice)
        
        Change-Id: Ie3917043671f43af5e8251d4d9a05723c0c51690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181828
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [aaceec6a64f4762eee3c8e711137efbb603bbfd5]

        android: Update Android Gradle Plugin to 8.8.1
        
        ... and gradle to 8.10.2, as suggested by Android Studio.
        
        Change-Id: Id3e90285ec1a40fdefbc0a4bcc9bc49e7a02f9c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181825
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [96a4272a84a33b939411bb99d1024cbb2bdaf046]

        cid#1642989 Double lock
        
        since:
        
        commit 867d380b0b8e2c59689eb42665c75aad34733bbc
        Commit:     Michael Stahl <michael.stahl@allotropia.de>
        
            tdf#161168 Improve constant repetitive loop thread
        
        Change-Id: If8e70322db88f2356aebd6799449a542c0d8bdfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181818
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-18  Jonathan Clark  <jonathan@libreoffice.org>  [fd7717f81b18faab0e400c9fa3e87c4579f254d1]

        tdf#165089 sw: disable grid centering for DOC/DOCX compatibility
        
        This change disables Writer CJK text grid centering when the
        MS_WORD_COMP_GRID_METRICS compatibility flag is set.
        
        Grid centering is useful for the Writer-native grid implementation,
        which defines both line pitch and a line count, but does not make sense
        for the Word grid algorithm which always fills a page at a specified
        pitch.
        
        Change-Id: Iaf63b2545636a678d5ba7264e0fb27e042e215c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181829
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-02-18  Oliver Specht  <oliver.specht@cib.de>  [44d1dd3a252cb79629037110c75058925efdeb80]

        tdf#118465 RTF: import repeated headers of tables
        
        Change-Id: Idc0cd36e1ca55a0c0cc60faf455919af645bb747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181792
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6bb0c4ee5883912ecde026b009f5742d06713aef]

        Missing delete of emscriptenthreading::Data
        
        ...lacking from 364508802571c25ac993e9327c67e2d5c575f668 "Experimental
        Emscripten Qt6 --enable-emscripten-proxy-to-pthread ersatz", but rather academic
        anyway, as LOWA doesn't terminate in the traditional sense (and just stops when
        you close its browser tab)
        
        Change-Id: I04d5ccbd5b9fa8350a9e3d949bf3903bc4692c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181823
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-18  Miklos Vajna  <vmiklos@collabora.com>  [231e027663077c565c1fc48c4c608235160fad14]

        cool#11064 Set priority of some idles to TaskPriority::DEFAULT_IDLE
        
        LOK clients can set their "any input" callback to interrupt idle jobs
        when they have something to execute which is less important that core
        "high priority" jobs but is more important than "low priority" jobs.
        
        For example calculating the layout for the visible area of a just
        changed Writer document is high priority, while calculating the
        non-visible area is low priority.
        
        Experimenting with an upcoming change to only interrupt the scheduler
        tasks when there are no high priority tasks scheduled, I noticed a
        number of idles which have a default priority, which is rather high:
        TaskPriority::DEFAULT is higher than a repaint priority.
        
        Fix the problem by checking what idles prevent the early paint of the
        visible area in Writer in LOK client code and by downgrading the
        priority of these idles to TaskPriority::DEFAULT_IDLE. With this, the
        "early paint of the visible Writer area" feature in LOK client code
        continues to work, even if the any input callback starts to not
        interrupt for the case when there are
        TaskPriority::HIGHEST..TaskPriority::REPAINT tasks in the scheduler,
        ready to be invoked.
        
        Change-Id: I42b3e0adbad98ef992ee3a454aba431a662a8126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181824
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-18  Noel Grandin  <noelgrandin@gmail.com>  [b5510122fd68e3d16117684f51062dfb03961b85]

        remove mpThreadGraphics from GDI backend
        
        we have required for a long time now that all vcl/UI updates
        run with the SolarMutex locked, so they are all effectively
        single-threaded.
        
        Change-Id: I4a0ce64a5fa9cb563d04f581cf3aa6e6e51ba1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181811
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-18  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [0434700e36440082c9f23bb591924d9f57f449aa]

        tdf#164886 register gallery/backgrounds with scp2
        
        app background bitmap customization wasn't working on any release of
        25.2. The issue was that the gallery/backgrounds folder wasn't
        registered under the package-file mechanism in the build system.
        
        so the backgrounds weren't included in the installation, hence this
        issue.
        
        Change-Id: I32c70ee80e074e927a59b51d1c5146230f72442f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181520
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8ae2584165fbb3cfc6874d9c1dabe01fbee71470]

        cid#1642990 Useless call
        
        noticeable since since:
        
        commit 70ffc422e515ca2ccea68de2c5bc4bf09cebf500
        Commit:     Michael Weghorn <m.weghorn@posteo.de>
        
            sc: Don't modify string passed to NumToAlpha/AlphaToNum
        
        Change-Id: Ie4c84430b7b4a9c77367af4e2f1ce4efcc6b4f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [53635086f19cf3060de2efdbdabdf9505743f36c]

        cid#1642991 Overflowed constant
        
        Change-Id: Ife6797f7850d84cdb30a0b0074a15dbf25d5c7e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181816
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [659554516df9b24600fe8f5c39e9659bba408396]

        cid#1642988 Uninitialized scalar field
        
        Change-Id: Ifa99aace590839db618696ce7d068cdd515701ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181815
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-18  Attila Szűcs  <attila.szucs@collabora.com>  [b306a12710ce9f38a37bcaef86cf74e74beab706]

        SD: fillapi-slide: format text parts
        
        Implemented way to select partial text in a text object, and use
        uno commands to format them.
        
        Tested several uno commands.
        
        to avoid some JSON validity issue:
        "Transforms"
        "SlideCommands"
        "EditTextObject."
        can have array value also, not just object values (as previously)
        
        New useable commands:
        { "EditTextObject.1": [   // start to edit the object-1 on the actual slide
        // multiple commands can be inside of it
        
        New useable commands inside of "EditTextObject.1"
        {"SelectParagraph": 1},   //select the paragraph-1 text in the edited textobject
        {"SelectText": [0,1,0,3] },  //select text
        // 0.paragraph,1.character - 0.paragraph 3.character
        // can be used with less parameter
        // [] = select all text (=[0,0,*,*])
        // [1] = select the full paragraph 1 text (=[1,0,1,*])
        // [1,2] = position cursor to paragraph 1, char 2.. no selection (=[1,2,1,2])
        // [1,2,3] = select the text between 1. para 2. char - 3.para last char (=[1,2,3,*])
        {"InsertText": "-Inserted-"},  //insert text "-Inserted-" into the actual textobject
        // to the selected place. It can insert multiple paragraps. "--\n++" = 2 paragraph
        // if a text is selected, it will replace that,
        // if cursor was set without selection, then it will extend the text there.
        // It will select the newly inserted tex, so it can be formatted right away
        {"UnoCommand": ".uno:Bold"},   //run the uno command ".uno:Bold" that change the
        // selected text format to bold.
        
        several basic formatting unoCommands that worked:
        
        ".uno:Bold", ".uno:Italic", ".uno:Strikeout", ".uno:Shadowed", .uno:Underline
        ".uno:DefaultBullet", .uno:DefaultNumbering
        ".uno:SuperScript", ".uno:SubScript"
        // all previous commands are toggle command
        // useing them on a bold text will make it not-bold
        
        ".uno:CenterPara", ".uno:RightPara", ".uno:LeftPara", ".uno:JustifyPara"
        // these commands set the horizontal alignment of whole paragraphs.
        
        ".uno:Color {\"Color.Color\":{\"type\":\"long\",\"value\":2777241}}"
        // set the selected text color to: 2777241 it is a blue like color
        ".uno:CharBackColor {\"CharBackColor.Color\":{\"type\":\"long\",\"value\":6710886}}"
        // set the background color of the selected text to: 6710886 it is a gray color
        
        a sample transform:
        {
            "Transforms": [
                { "SlideCommands": [
                    {"JumpToSlide": 0},
                    {"EditTextObject.1": [
                        {"SelectParagraph": 1},
                        {"InsertText": "----\n++++"},
                        {"UnoCommand": ".uno:DefaultNumbering"},
                        {"SelectText": [0,1,0,3] },
                        {"InsertText": "-Inserted-"},
                        {"UnoCommand": ".uno:Underline"},
                        {"UnoCommand": ".uno:Bold"},
                        {"UnoCommand": ".uno:Italic"},
                        {"UnoCommand": ".uno:Strikeout"},
                        {"UnoCommand": ".uno:Shadowed"},
                        {"UnoCommand": ".uno:JustifyPara"},
                        {"UnoCommand": ".uno:DefaultBullet"},
                        {"UnoCommand": ".uno:SuperScript"},
                        {"SelectText": [0,14,0,17] },
                        {"UnoCommand": ".uno:SubScript"},
                        {"UnoCommand": ".uno:Color {\"Color.Color\":{\"type\":\"long\",\"value\":2777241}}"},
                        {"UnoCommand": ".uno:CharBackColor {\"CharBackColor.Color\":{\"type\":\"long\",\"value\":6710886}}"},
                        {"SelectParagraph": 1},
                        {"UnoCommand": ".uno:CenterPara"},
                        {"SelectParagraph": 2},
                        {"UnoCommand": ".uno:RightPara"},
                        {"SelectParagraph": 3},
                        {"UnoCommand": ".uno:LeftPara"}
                    ]  }
                ] }
            ]
        }
        
        Change-Id: I90eba60f8b31e48c681283fa27a6c7daa1886141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181778
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [906598cac70f471954ef1bdb6905bcfa303c522a]

        cid#1642994 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9fceedc0868adb0d33befa78beafc570c92978a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181814
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [1218e023fd67b32dc6c6110c1bd2fe6d44ed1e0b]

        vcl: menubtn.[hc]xx -> MenuButton.[hc]xx
        
        Change-Id: I0b037261c753df6cd7efc2ee605abc02304c226c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179238
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [be37c3e65407fdf08781a7c49f21d7e7e80a46ae]

        crashtesting: getSdrObjectFromSdrObjList() might return nullptr
        
        Seen in https://crashreport.libreoffice.org/stats/signature/E3dScene::NbcInsertObject(SdrObject%20*,unsigned%20__int64)
        
        Change-Id: I1136a977314ac47d1a3772c21d6970c20fe760cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181801
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [56390eefb11558d2c24f0e820fedc808361c6f7f]

        vcl: flatten Slider:ImplInitSettings()
        
        Change-Id: I8ca52cc3efc80084c0a30e554437dac5ddee925e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179327
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [b666efedd669d652c05deac4a6f9734b461e5074]

        vcl: nType -> eType
        
        Change-Id: I3e55e6173494f660febc296ec342ab223e5cdec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178227
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [de018733fc1fa793848d319d1a962536c5a5d762]

        vcl: remove unnecessary includes from combobox.cxx
        
        Change-Id: I2c76c67dd6660dc8e9979755eade14d06ad6b000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178214
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Simon Chenery  <simon_chenery@yahoo.com>  [2aba56b511894e7b8be4e6b10413b1b64f86bc3a]

        tdf#158068 Use OUString literals in targetlistener.cxx
        
        Also remove unnecessary nested OUString object.
        
        Change-Id: I970dbb239eee0f7169d1d5b569053489678858f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181756
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [e4a2fa75e3d361ecb60942747a3c9f72aea27029]

        vcl: rename DDInfo to DragDropInfo
        
        Change-Id: I190a3ccea226c7a23eb553a1698d5959b8353b84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178506
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Rashesh  <rashesh.padia@collabora.com>  [1ba9ebc9ec63563e1a51b99dd0376e80a7003c57]

        fix(sw-lokit): correctly load shared wordbooks
        
        - Fixes a regression introduced in commit 89d86b64c93f2f47d7cfdefb928812e4de64fe3b.
        - Ensures dictionaries are reinitialized even when only shared wordbooks are uploaded.
        - Previously, reinitialization occurred only when user wordbooks were uploaded.
        
        Change-Id: I0f54b6b01fe1aefadc2c1fec2d9ae57db1c5d02a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181787
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 190593257ad7636a9f88ff765ab66ff7307b9dca)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181813
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [12b74fa3682479532bfca5abbe16d24cb7b1f8da]

        vcl: declare variable in for loop
        
        Change-Id: Ifc2fac7afe552c3dfa0007d4999a5b981c9417fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178944
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Simon Chenery  <simon_chenery@yahoo.com>  [685899f24e58653ad274c518d84610a41880f6da]

        tdf#158068 Use OUString literals in convert3to4.cxx
        
        Change-Id: I9c6e978a914a575cf90c7e444c57afdbfff800b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181743
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [ac07c380ac24557a0c383e68728bded571df1281]

        vcl: rename local functions in spinfld.cxx
        
        Change-Id: Ifa4a8d7c0e660c125733fa28912eef147fa4aa81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179378
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [67a25eb13f5a2b6a9efeb4af80c7288b07cd33e0]

        vcl: flatten TabControl::ImplInitSettings()
        
        Change-Id: I3ca648e45e6d0c22cc195abc3a6a2a858dbae38e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179449
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Christopher Sherlock  <chris.sherlock79@gmail.com>  [0f53e4237dd7e16783f039b8ffee184513f4c86b]

        vcl: add comments for Window::GetBorder()
        
        Change-Id: I8113aa5c047bd96c6400044a9dfa34e5381fb001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181788
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [8b8ed9056511a5259da3097dfbb12f4d86741bba]

        tdf#130857 qt weld: Support Writer "Column Width" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        To trigger the dialog:
        
        * start Writer
        * insert table via "Table" -> "Insert
        * move cursor into a table cell
        * "Table" -> "Size" -> "Column Width"
        
        Change-Id: Ia9719668fbd332f5fd61b440008ec6d30afbb332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181810
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [b2c5d3720e37c6b9a2b9402424ad64bf1c344f99]

        sw: Resave columnwidth.ui with glade 3.40
        
        To trigger the dialog:
        
        * start Writer
        * insert table via "Table" -> "Insert
        * move cursor into a table cell
        * "Table" -> "Size" -> "Column Width"
        
        Change-Id: Idfda6b2878806cbde9fb0d700942aaef4d7e0fe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181809
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [774f9d735b9cce2ab984b1fe53243468d8a7d369]

        tdf#130857 qt weld: Support Writer "Insert Table" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The dialog can be triggered in Writer using "Table" -> "Insert Table".
        
        Change-Id: Idcc4d94b3fa39ceef2278bcb4d8ab6ab79d31892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181808
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [663077c0c3c6621a9ed61e880228c15541893ced]

        sw: Resave inserttable.ui with glade 3.40
        
        This is Writer's "Table" -> "Insert Table" dialog.
        
        Change-Id: I232feaa5fd18d313b05588c4c5634d038811845e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181807
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [4a1a26e2a29f1c501cc61c23cb7ac556c1034b96]

        tdf#130857 qt weld: Implement QtInstanceLabel::set_label_type
        
        This is e.g. used by Writer's "Table" -> "Insert Table"
        dialog (for which support will be declared in an upcoming
        commit) to show a warning when a large number is set for
        rows or columns.
        
        Implement similar to GtkInstanceLabel::set_label_type by
        setting specific font and background colors.
        
        Change-Id: I1e4c1863261cfd7f37f0bf80803fd97062c5604c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181806
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [ef38373275008740d1090fa1a1a59e1832ea40a9]

        weld: Switch SpinButton::{format_text,parse_value} to double
        
        In line with the earlier commit
        
            Change-Id: I31bc2b95b46bae8174388cddc9a383ed61e6763e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 17 13:10:16 2025 +0100
        
                tdf#130857 Pass double values to/from weld::SpinButton subclasses
        
        , switch also the params/return values for
        weld::SpinButton::format_value and
        weld::SpinButton::parse_text from sal_Int64
        to double, because those methods are called
        from the subclasses that otherwise use floating
        point values (double) and don't need to deal
        with conversion between sal_Int64 and floating
        point values, depending on the number of decimals
        that are set for the SpinButton.
        Instead do the conversion in those methods now.
        
        Rename weld::SpinButton::format_value to
        weld::SpinButton::format_floating_point_value
        for clarity.
        
        Make weld::SpinButton::convert_double_to_value
        and weld::SpinButton::convert_value_to_double
        private, as the subclasses no longer need them
        any more, the weld::SpinButton base class takes
        care of all conversion between sal_Int64 and
        double now.
        
        Change-Id: I3ff01295799e3ead8b1fbec8c3b9ad3afdea993a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181805
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [b8249ed9265d34ad0bddc9b3d199fe1553a4a5ec]

        weld: Let Formatter:m_aInputHdl use double instead of sal_Int64
        
        Switch the param for the out param in Formatter:m_aInputHdl
        from sal_Int64* to double* and adjust the methods/Links
        that get set via Formatter::SetInputHdl.
        
        Formatter itself otherwise already uses double for its
        value (and min/max, etc.), so using double here as well
        is consistent with that.
        
        It also matches what SalInstanceSpinButton, one of the
        classes that uses Formatter internally does since
        
            Change-Id: I31bc2b95b46bae8174388cddc9a383ed61e6763e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 17 13:10:16 2025 +0100
        
                tdf#130857 Pass double values to/from weld::SpinButton subclasses
        
        Formatter:m_aInputHdl gets used in Formatter::ImplGetValue
        to convert text into a number. While Formatter:m_aInputHdl
        was returning sal_Int64 so far, that was already converted
        to a double value there anyways, depending on the number
        of digits (s. call to `GetDecimalDigits()`), with basically
        the same logic that the weld::SpinButton base class
        does it by now since the above commit (while SalInstanceSpinButton
        was implementing the logic previously.)
        
        Notes on the methods/Links that are being passed via
        Formatter::SetInputHdl:
        
        * SpinfieldControl::ParseInputHdl already had a double value
          that it was multiplying by the same factor that
          Formatter::ImplGetValue was earlier then dividing by,
          so the multiplication there can simply be dropped.
        
        * SalInstanceSpinButton now uses weld::convert_value_to_double
          to get a double value as needed.
          In an upcoming step, weld::SpinButton::parse_text will
          be adjusted to also use double right away, as another
          step to let its subclasses use double directly.
          (Preparing for this was the main motivation for this commit.)
        
        * LongCurrencyFormatter can have decimals and now does the
          division previously done in Formatter::ImplGetValue
          to achieve the same result as previously.
        
        * DateFormatter and TimeFormatter both use values that don't have
          any decimals, so the conversion should already
          have been a no-op (dividing by 1) and therefore doesn't
          need to be added elswhere.
        
        In case anything was missed in a handler here, adding a
        division by
        
            weld::SpinButton::Power10(m_xWidget->GetFormatter().GetDecimalDigits())
        
        as was previously done in Formatter::ImplGetValue
        should likely fix the issue.
        
        Change-Id: Ibc297928f76ac1dab0080c36cef44ddddefab7b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181804
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [20970269b70c9a7c0b94dc705ec73c2c326624b9]

        vcl: Drop ImplLongCurrencyGetValue
        
        It was just calling ImplCurrencyGetValue with the
        same params. Adjust callers do do that right away instead.
        
        Change-Id: If13a28fc99734d605d93974e109aa36ff33cb18c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181803
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [f7fb355759b2295bba5d6225cabbebae06d4bd7c]

        vcl: Drop LongCurrencyFormatter::SetDecimalDigits
        
        It's only ever called with a value of 0 from the ctor.
        Drop the method and LongCurrencyFormatter::mnDecimalDigits
        and call ReformatAll() in the ctor directly (which was
        previously called from LongCurrencyFormatter::SetDecimalDigits.
        
        Let LongCurrencyFormatter::GetDecimalDigits simply return 0
        for now. This could be simplified further to adjust all
        callers.
        
        Note that this class is a different class from
        weld::LongCurrencyFormatter (defined in
        include/vcl/weldutils.hxx).
        
        Change-Id: I571f2edf79d1e203d5c05acf684a3e50e593f477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181802
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [7b0bcaf5a1fc48335056c5f62af67bda434e9bc2]

        sw: Resave rowheight.ui with glade 3.40
        
        To trigger the dialog:
        
        * start Writer
        * insert table via "Table" -> "Insert
        * move cursor into a table cell
        * "Table" -> "Size" -> "Row Height"
        
        Change-Id: I1bda3b0647b082c048b491978f79da9cf44af4f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181786
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [8895c5c7447bb1b0eb53846c2f1dbfa69323338c]

        tdf#130857 qt weld: Support sw "Row Height" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        To trigger the dialog:
        
        * start Writer
        * insert table via "Table" -> "Insert
        * move cursor into a table cell
        * "Table" -> "Size" -> "Row Height"
        
        Change-Id: Ifd69687611919d476ae99f3dc4f6f1c087ca07cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181784
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [773c7a4946bd18c1e83c710ee50775065b1fbb4f]

        tdf#130857 qt weld: Adjust value <-> text conversion to use double
        
        Until recently, the QtInstanceSpinButton implementation didn't
        take into account that the sal_Int64 values used in the weld::SpinButton
        API cannot simply be used as floating point values as they are, but need
        to be converted first, based on the result of
        `weld::SpinButton::get_digits()`.
        
        With
        
            Change-Id: I31bc2b95b46bae8174388cddc9a383ed61e6763e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 17 13:10:16 2025 +0100
        
                tdf#130857 Pass double values to/from weld::SpinButton subclasses
        
        in place, the base class now already takes care of that conversion in most
        places.
        
        However, QtDoubleSpinBox::textFromValue and
        QtDoubleSpinBox::valueFromText were still passing/using
        values as they were.
        
        Adjust these to do conversion as well, by implementing
        the required logic in QtInstanceSpinButton (convert
        using weld::SpinButton::convert_value_to_double and
        weld::SpinButton::convert_double_to_value) and passing
        corresponding functions to
        QtDoubleSpinBox::set{FormatValue,ParseText}Function.
        
        Change-Id: Ib498c63f6164054909a260ecb12283182ac8ba98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181783
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [20a4fba188cc70ff837dd0d6e0d7063ad66a4386]

        tdf#130857 Pass double values to/from weld::SpinButton subclasses
        
        As described in previous commit
        
            Change-Id: I2ecf0b8713a99e15887ab4ee6d4cda27f1afdfc4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 17 10:54:18 2025 +0100
        
                tdf#130857 vcl: Move sal_Int64 <-> double helpers to weld::SpinButton
        
        , the weld::SpinButton API uses integers (sal_Int64) to represent
        all values, including floating point values, while GtkInstanceSpinButton
        and SalInstanceSpinButton internally use double to represent values.
        
        So far, the conversion between them was done in
        GtkInstanceSpinButton and SalInstanceSpinButton methods.
        
        Move the logic to the weld::SpinButton subclass instead:
        
        Let the existing public methods (used by dialog implementations)
        no longer be (purely) virtual, but let them do the conversion
        and then call newly introduced (purely) virtual methods that
        take/return the double equivalent (which depends on the return
        value of `weld::SpinButton::get_digits()`).
        
        Override those methods in the weld::SpinButton subclasses instead,
        so no conversion needs to be done there any more.
        
        For GtkInstanceSpinButton and SalInstanceSpinButton,
        this commit should not result in any change of behavior
        
        QtInstanceSpinButton so far didn't do the conversion
        by itself, but should now get it "for free" from
        the base class implementation without having to
        implement the same logic that the GTK and VCL
        implementations previously had once again.
        Drop any explicit rounding that some QtInstanceSpinButton
        methods did so far to convert the double value to an
        integer.
        
        Change-Id: I31bc2b95b46bae8174388cddc9a383ed61e6763e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181782
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [7528dac1b2cd4ac13a0cf988a68fdc701c0b240f]

        tdf#130857 vcl: Move sal_Int64 <-> double helpers to weld::SpinButton
        
        The weld::SpinButton API uses integers (sal_Int64) to represent
        all values, including floating point values (by taking into account
        the number of digits, see also weld::SpinButton::normalize and
        weld::SpinButton::denormalize and how they're used in dialog
        implementations).
        
        However, both GtkInstanceSpinButton and SalInstanceSpinButton
        internally use double to represent values
        (GtkInstanceSpinButton via its GtkSpinButton, SalInstanceSpinButton
        via Formatter) and each had their own implementation to convert
        between the two.
        
        Move the GTK implementations to the weld::SpinButton base class and
        reuse them in SalInstanceSpinButton. This also avoids
        the need to reimplement the same logic yet another
        time for more weld::SpinButton subclasses, like
        QtInstanceSpinButton.
        
        Change-Id: I2ecf0b8713a99e15887ab4ee6d4cda27f1afdfc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181781
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e1282affdb4e132a6329f378d6379155968b689]

        Fix typo
        
        Change-Id: Ieed2b8565dbde5c977950ca9bab37911b2fa1b0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181710
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4f3ab90e047823e17e09e8f3892891d977221e15]

        Fix typo
        
        Change-Id: Id3d0aac6f2e66c183c2af306557280cfee9caa71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181708
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f31bc15dade964b8acda62c7448363082630dd1b]

        Fix typo
        
        Change-Id: I46a602ac256a2351b0eafea550709a8557a209eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181707
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [398c11abf08eb8ec01746cd059443f224d78b99f]

        Fix typo
        
        Change-Id: I851399ffe075c4fb54bcef495feb8097e1d4b803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181709
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7a283ee5540e42662b723ac08d3ea1a0e454045e]

        Resolves: tdf#165295 partial cid#1555986 lock acquisition evasion revert
        
        seeing as getTypeEntries can be reentrant
        
        Change-Id: Ice119e2a48d4912722a35843bd1c5078805249bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181799
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-17  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7ff861a1ead95d12ed6ab301093c4ee488f7155f]

        SwTextRuby: SwClient no more
        
        Change-Id: I2ff5a5af710302dff5de5bc42e514f3838a13655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181757
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [d80dd99db9d8c78fa4b9b4a2be4bc13721df7469]

        Use LO_DEBUG_MAILMERGE environment variable to debug mailmerge.py
        
        This is often useful in release builds, too.
        
        Change-Id: Icb01353541836a18834897f3da501f1b0e466f3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181771
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3ee34dffdbd7061e776b0cce34069153198694e5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 179d8999b71b3aec777a556a627f7cc24b2d73cc
          - Update teasing vide in online help
            
            Change-Id: I30db73a88b859a3bf79ed0d6322fc2bfcf7c0321
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181791
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-17  Michael Weghorn  <m.weghorn@posteo.de>  [ecac024b906f90b4402be22fc0e9e994ece954dc]

        vcl: Call MetricSpinButton::format_number directly
        
        Change-Id: I12d0b9b040a74365c061e8361d2812ac46802024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181762
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [4f591786ccbb4274aa575c20d3d31a9ca8d3da8d]

        Simplify some uses of basegfx::utils::create*B2DHomMatrix
        
        The additional zero checks are unneeded (the creation functions do
        that internally). And in one case, a simpler function exists.
        
        Change-Id: I481b3d22b8081cbfad545c343b04f7f3330b0eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181769
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-17  Simon Chenery  <simon_chenery@yahoo.com>  [d58a0238561584cb5440e8df79fbf06737ae42af]

        tdf#158068 Use OUString literals in printerinfomanager.cxx
        
        Change-Id: Ibd2e77246fddbe782f14252fee708035e9466b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181754
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7dfdc18d6834432099bb2885037c1a9e84a71b4d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3580e1e8fc464bf3058ceda08a2a72b1876633fc
          - tdf#162607 disambiguate hid2file.js, Insert/Edit Section
            
            Change-Id: I8a5b52bc48d4ac17d936f84b61f5a134b14f399a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181755
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [696c241c03d3773fd82cedc390192dfa784c2493]

        Some more need for EmscriptenLightweightRunInMainThread
        
        Calls to qApp->devicePixelRatio() can internally call out to
        main-browser-thread-only JS objects when the data keeps getting invalidated by
        e.g.
        
        >       setInterval(function() { window.dispatchEvent(new Event('resize')); }, 1000);
        
        at
        <https://github.com/allotropia/zetajs/commit/c7d80ed5c2d7336d0daedf8c34ac4055fb7f9626#diff-9fc68f096a70ca06e4a5b52d47a44abebeec78c757dab340b9b177cac35a65a8R42>.
        
        Change-Id: Ic1387f2a49c9a231842d88b6220f8efc8bc32479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181682
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1c928cb4f34c3925a585e07fe3bddedf3f49809f]

        Support non-void QtInstance::EmscriptenLightweightRunInMainThread return types
        
        Change-Id: Ic0e02dd21c6dd59dc89088c3e797788bcea91273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-17  Rashesh  <rashesh.padia@collabora.com>  [4ea5f5beb0089fb76e9ef1469e5e8eedeb54554f]

        sw: lokit: add new `isCropMode` property to LOK_CALLBACK_TEXT_VIEW_SELECTION
        
        Change-Id: I788d0b56bfba2c150401a906c7442652e50da58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181160
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 63c7d4b73faf346f84d664f4ecd1dcd1e430750d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181661
        Tested-by: Jenkins

2025-02-17  Mohamed Ali  <mohmedali1462005@gmail.com>  [72d766134e374816e88451fa90c70656dde89581]

        tdf#161195 Allow right-to-left brochure printing in Draw / Impress
        
        introduces support for Right-to-Left (RTL) brochure printing in LibreOffice Draw and Impress. The changes include modifications to the print layout logic to handle RTL text and ensure proper alignment and formatting.
        
        - Adjusted the brochure printing logic to correctly handle RTL page order. This ensures that pages are printed in the correct sequence for RTL languages, which is essential for creating readable brochures.
        
        - Modified the user interface to allow users to select RTL brochure printing. This includes adding new options in the print dialog.
        
        Change-Id: Ie0c5e6abebfdf4805c1b9d9d43bdf91f5d710aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177432
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-17  Miklos Vajna  <vmiklos@collabora.com>  [9e82453c2d5e075ee2eed8330f5b710e4a7a6df7]

        cool#11064 vcl lok: expose info about the scheduler
        
        A LOK client can interrupt the vcl main loop in its 'any input'
        callback. When making that decision, it's useful in case it can know
        what's the priority of the most urgent job, for example it may want core
        to still finish high priority tasks, but not idle ones.
        
        Add a LOK API to expose this info. Keep it minimal, so it's realistic to
        call this frequently from a LOK client.
        
        Change-Id: Id51668eb8156067e60d6fd0f33606c65858008a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181761
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-17  Szymon Kłos  <szymon.klos@collabora.com>  [aec5e1c566a935fd4f650243e298cd79b10a0bd6]

        jsdialog: be sure we found entry for context menu in treeview
        
        Fix regression from commit 0d18454f08476475255469d23107d8a9ee6549c4
        jsdialog: reduce unwanted containers
        
        after that patch we didn't get the entry because coordinates
        of the entry based on abs pos in the tree were negative
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I6a9e2c7acb7f02231caaeac1a861321a3a235fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178962
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181526
        Tested-by: Jenkins

2025-02-17  Szymon Kłos  <szymon.klos@collabora.com>  [044c9a457867b2f376c6596ec4cfc25083c5be2d]

        jsdialog: reduce unwanted containers
        
        we don't need additional container on top level
        which makes it harder to layout widgets
        
        Change-Id: I49532c4cd0ab8790c27e84098faa86a338da3c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181525
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-02-17  Miklos Vajna  <vmiklos@collabora.com>  [be145cb8b6f60805ddc8674aa6557be7e79c227f]

        svx: prefix members of GalleryPreview
        
        See tdf#94879 for motivation.
        
        Change-Id: I5b2f371541851adb3a423573567b33f207c4ab3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181760
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-17  Julien Nabet  <serval2412@yahoo.fr>  [51e8bb0db422c485d586a36b59201e0019801a76]

        Fix license + footer + rename RowId into XRowId
        
        + use PseudoColumnUsage and XRowId in UnoApi_offapi.mk
        +fix errors in XRowId.idl
        
        Change-Id: Id4e6c23872618752b6e24c91e7efecefcfac7177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181674
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-02-17  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [6a2393e4e7e0347ad47ca8f7cf2bc35b11c3dbeb]

        getting rid of FieldTypeGuard/SwClient
        
        Change-Id: Icd10490f2d0acda8f05fdf037683957f20afa750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2025-02-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [8d01f7a927970bc205b816be6be4f79570192808]

        vcl: move TextLine to own header file
        
        Change-Id: I0e7097cc4a020d945a90e732539a0b5773bccf11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179711
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [157a3629b30ec66b4998f63ea21d3ae1881c582d]

        tdf#164997 - sc refactor and optimize LET function calculation
        
        With the original solution the embeded LET function into another
        functions caused unexpected error values.
        
        Such as: IFERROR(LET(...)...) gave error for non-error LET result
        
        Change-Id: I5f09a8771ce38492269cfeb567b9c3357cfd510c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181662
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [b01c3dc872b370a7314c7f65b63f32b5a1e315a8]

        vcl: initialize DDInfo members in definition
        
        Change-Id: I2af2264bca5217b3d96d1abfd3278fec4a1bbf3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178505
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [67d0f364bb729025822f21e8e24a31cd5e8ffb38]

        vcl: _rStyle -> rStyle
        
        Change-Id: Icefcd78be0f9a30a3a714e9bc04b8e7a1b6f425e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179145
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-17  Rashesh  <rashesh.padia@collabora.com>  [f9a56d3c52e43dce5a4a56a79d16401e209c7dfd]

        sw: lokit: don't activate standard.dic
        
        - in online, standard.dic is not required and causes confusion to the
          user
        
        Change-Id: I79a66e3479a35a0ace90dc4c30f3c479526f0fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180979
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 769de908b837d8fca0109cd833f7b4f64a5e8ff4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181168
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [90b2fd021247cfb1e737f4a189dfbda2729ff76f]

        vcl: fix modelines in vcl/source/control/hyperlabel.cxx
        
        Change-Id: Idf755506ce2dbe19427dcc042d502e09f8f6357a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181689
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [db83a93b7349e94b9658558e0a8ca4e9f7700a99]

        vcl: remove unnecessary parentheses
        
        Change-Id: I76612bb87e4fc95219e95da72357ee123fb273ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179194
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [50b211d6ba6cdec01f7eb304d406fec615e6917f]

        Correct bug number
        
        Change-Id: Ifad0623a6eb5d497c81abf9eeb0df1bb4be77834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181628
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f4cf9971ceaf72a630fe1d1dd8154326daca9832]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 348fc0b886f0f917f18f151e85542f34d35ed37a
          - Fix Help pages for labels and business cards
            
            + Fix bookmarks
            + Fix calls in menus and tabbed UI
            
            Change-Id: I935b21d8c2056ffcddbda3f4971764893a594cab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181758
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2265a8a3a3056c10c75c06b771ce7fcc553b4187]

        Simplify oslTranslateFileError
        
        Drop a duplicating entry in errtable (which was there from start);
        sort it; and use range-based for loop. A follow-up could use e.g.
        sorted lookup, or frozen::unordered_map.
        
        Change-Id: I025f7ec30a6e1f27b769f5d643d7e8f2bf39f2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181747
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [92c86c7c414dfe621f1f9778c8a85db58ce73358]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5cae320fad8746d99075e59a16cdc6f4ecb7f1e
          - Untangle help page for Paste Special.
            
            Change-Id: Iec95eda30c0dddc1534f8303ba5eda7e643ee62c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181749
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [cd969d0c4197736fee76196701282964ad64055b]

        tdf#130857 qt weld: Ignore "GtkCellRendererToggle"
        
        Ignore it like the other GtkCellRenderer* ones.
        
        Seen e.g. in cui/uiconfig/ui/searchattrdialog.ui
        (for which support hasn't been declared yet).
        
        Change-Id: I2dfd36c89edf5fce859f06724f672d3896fdfdd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181738
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [11df94e8c882dd6656e73a548011e3c131bcf464]

        tdf#130857 qt weld: Support "Delete {Header,Footer}?" dialogs
        
        To trigger the "Delete Footer?" dialog
        
        * start Writer
        * "Insert" -> "Header and Footer" -> "Footer" -> "Default Page Style"
        * type something in the footer
        * "Insert" -> "Header and Footer" -> "Footer" -> "Default Page Style"
          to disable again
        
        For "Delete Header?" one, choose "Header" instead of "Footer"
        in the steps mentioned above.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I38157fed85a05af74383d1d8f2b7548b323da876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181737
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [ea3b83e228d56e33d8bcffeeb88b7fbcdaf08e87]

        svx: Resave delete{footer,header}dialog.ui with glade 3.40
        
        To trigger the "Delete Footer?" dialog
        
        * start Writer
        * "Insert" -> "Header and Footer" -> "Footer" -> "Default Page Style"
        * type something in the footer
        * "Insert" -> "Header and Footer" -> "Footer" -> "Default Page Style"
          to disable again
        
        For "Delete Header?" one, choose "Header" instead of "Footer"
        in the steps mentioned above.
        
        Change-Id: I9f7add612401df223d2102c4bebf705a96c0dd52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181736
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [b4716d8a58bd6c4e36cdc0009874fef78c21c3fa]

        tdf#130857 qt weld: Support zoom dialog
        
        Declare support for this dialog that can be triggered in
        Writer using "View" -> "Zoom" -> "Zoom".
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I420b96dd1c585b2628e9f429621b99be77af1c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181734
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [09233f452236f99e0999d939d616f0c5f53fc7b5]

        cui: Resave zoomdialog.ui with glade 3.40
        
        Dialog can be triggered in Writer using
        "View" -> "Zoom" -> "Zoom".
        
        Change-Id: I8df1d7c6b04eac7d776ea6b16871fb70f1226903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181733
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [645a8296712f88d768c4243e9013191d281e5c53]

        tdf#130857 qt weld: Support "Printer Options" dialog
        
        Declare support for the "Printer Options" dialog that
        can be triggered as follows:
        
        * "File" -> "Printer Settings"
        * in the "Printer Setup" dialog that shows up, click the "Options"
          button
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        For some modules, there are extra controls whose .ui files
        are added in this commit as well.
        
        Change-Id: I5f8fcb5207b5db8cd4c71a6698c215ae09d97dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181732
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [d455d8118f2f08083fd237273ddb2087d7d98ad8]

        tdf#130857 qt weld: Support Math "Save defaults?" dialog
        
        Declare support for the dialog that can be triggered as follows:
        
        * start Math
        * "Format" -> "Font Size"
        * click the "Default" button in the dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog makes use of the GtkMessageDialog:buttons property
        for which support was added in
        
            Change-Id: I69c9e736b5080a4a824ffeb5f364492402e406c8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 20:56:58 2025 +0100
        
                tdf#130857 qt weld: Add standard message dialog buttons defined in .ui
        
        Change-Id: I8078bb88f45e9d7820a546c1866b79cb316ccaca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181727
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [91bdb8e30e855b916c1b7ef9e299e63b43d7b793]

        tdf#130857 qt weld: Add standard message dialog buttons defined in .ui
        
        When processing a .ui file in QtBuilder, also evaluate the
        GtkMessageDialog:buttons property [1] and add the corresponding
        buttons to the QMessageBox.
        
        This is needed e.g. for the dialog that can be triggered
        as follows, for which support will be declared in an upcoming commit:
        
        * start Math
        * "Format" -> "Font Size"
        * click the "Default" button in the dialog
        
        (Without this commit, the dialog would only have a
        single "OK" instead of a "Yes" and a "No" button.)
        
        [1] https://docs.gtk.org/gtk3/property.MessageDialog.buttons.html
        
        Change-Id: I69c9e736b5080a4a824ffeb5f364492402e406c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181726
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [d0ccde777ce83a27ac46290254c3d1102f962f7c]

        vcl: Switch SAL_WARN about button types to assert
        
        The
        
            git grep '"buttons"'
        
        output suggests that there's no case of any unknown value being
        used. Switch the existing SAL_WARN to an assert to notice more
        easily if that ever changes.
        
        Change-Id: I015de3da46056bdb5cbbe6dd8d88c39c128fad72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181725
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [07fe29fb7a601e899ff92298af799c216588736a]

        tdf#130857 vcl: Extract helper to map GTK to VCL buttons type
        
        Extract the existing logic to map the various possible values
        for the GtkMessageDialog:buttons property [1] to the VCL
        equivalent from MessageDialog::set_property to a new static helper
        method BuilderBase::mapGtkToVclButtonsType, for reuse in QtBuilder
        in an upcoming commit.
        
        [1] https://docs.gtk.org/gtk3/property.MessageDialog.buttons.html
        
        Change-Id: I7eee72cde7e162733d551dc4c19936c7b837baa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181724
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [1f036a5cc7be95cd6e318e947193d426499de37e]

        tdf#130857 qt weld: Split QtBuilder::setProperties
        
        Split QtBuilder::setProperties into 4 more specific
        methods that handle particular widgets and call the
        methods right after the widgets have been created
        and no longer from QtBuilder::insertObject.
        
        This aligns this with how its already done for
        other widget types and removes the need to
        use qobject_cast, as the class is known at the
        point in time when the specific widgets are created.
        
        Change-Id: I230c07b97ea15cdc83ba0965f36496b930323860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181723
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [580000aaade53c650e6da5a328f1bbc757d1ef78]

        tdf#130857 qt weld: Assign variable right away
        
        Change-Id: I1c98aef30bd263579e8c6e4bcfbaa5618bc00b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181722
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [2ced62c97738b2a26e57285e3b1bf09d7fc0cf1d]

        tdf#130857 qt weld: Extract logic to add buttons to static helper methods
        
        This is one step in preparation of reusing the logic in an upcoming
        commit to add support for the GtkMessageDialog:buttons property [1].
        
        [1] https://docs.gtk.org/gtk3/property.MessageDialog.buttons.html
        
        Change-Id: I19c59db5e403f07e5e50615c7cb705193dd0e72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181721
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [0515c27ef685babf1907d38106410bf6d7597040]

        tdf#130857 qt weld: Move helper function to QtInstanceMessageDialog
        
        This is one step in preparation of reusing the logic in an upcoming
        commit to add support for the GtkMessageDialog:buttons property [1].
        
        [1] https://docs.gtk.org/gtk3/property.MessageDialog.buttons.html
        
        Change-Id: I432587529ec8b0bbb7b0a5c13a6e77b7ef178a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181720
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [da406dbd9eb7fc9ba8452688fa049cf43045959c]

        tdf#130857 qt weld: Move include to .cxx
        
        Change-Id: I147a286126a8ee8820aa2740339570f4d1d1ea25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181719
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [f2ea471a37474a6f7cf53468ef39023fd0ddbed4]

        math: Resave savedefaultsdialog.ui with glade 3.40
        
        The dialog can be triggered like this:
        
        * start Math
        * "Format" -> "Font Size"
        * click the "Default" button in the dialog
        
        Change-Id: I50b2595f8edc0558200918d3a75ba1355d2f2c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181718
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [1d5af8d4cd693a0ee37a592843aa971620d36358]

        tdf#130857 qt weld: Support Math "Font Size" dialog
        
        Declare support for the "Format" -> "Font Size" dialog in
        Math.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog uses weld::MetricSpinButton, and is therefore
        the first supported dialog making use of the logic implemented in
        
            Change-Id: Ifb24da2bcf37c2a769d22d5aa33b69929ca8cb11
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 17:47:01 2025 +0100
        
                tdf#130857 qt weld: Implement SpinButton text <-> value conversion
        
        Change-Id: Idaaa07ae3da884436af4b97fc06886098db45936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181717
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [14d01d78ca82a57080fd9582e362b45780961540]

        tdf#130857 qt weld: Demote assert in QtInstanceEntry::set_width_chars
        
        Switch the assert that the method isn't implemented to a SAL_WARN
        for now, to not block other Qt welding work at the moment
        (like adding support for the Math "Format" -> "Font Size" dialog).
        
        This method is for adjusting the size of the widget, so not having
        it implemented should have "only" a visual effect, while at this
        stage, my primary focus is on implementing missing logic and
        dialogs are added one at a time, so any major issues will be
        noted while working on adding support for them.
        
        Come back to this later.
        
        Change-Id: I65bed22716db92a04da2a41dc1966ab5635b0482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181716
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [6871b55b6915396caa3e5aca7e233f6a5efc7864]

        tdf#130857 qt weld: Implement SpinButton text <-> value conversion
        
        In order to implement custom conversion between the current
        value of a spin box and the text to display as well as from
        the user-entered text to the value to use, methods
        QDoubleSpinBox::textFromValue [1] and
        QDoubleSpinBox::valueFromText [2] can be overriden.
        
        Implement these methods and use the existing methods
        in QtInstanceSpinButton's weld::SpinButton base class
        to implement the logic.
        
        In order to be able to use those in QtDoubleSpinBox,
        add two new members and setters for those functions,
        and call them in the QtInstanceSpinButton ctor.
        
        See also previous commit
        
            Change-Id: If4cd12ef947233331a5deccba5c14a15e30a30c8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 13:44:50 2025 +0100
        
                tdf#130857 weld: Abstract from "input"/"output" SpinButton signals
        
        and the commits mentioned therein for more background,
        as those commits were in preparation for this one.
        
        In a WIP branch adding support for the "Format" -> "Font Size"
        dialog in Math, this commit makes the text in the
        spin boxes show the units as expected, e.g. "12 pt", "100 %"
        when using SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        (Support for that dialog will be declared in an upcoming
        commit.)
        
        [1] https://doc.qt.io/qt-6/qdoublespinbox.html#textFromValue
        [2] https://doc.qt.io/qt-6/qdoublespinbox.html#valueFromText
        
        Change-Id: Ifb24da2bcf37c2a769d22d5aa33b69929ca8cb11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181715
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [76396a371eb7dfef79963d00fea54a989f54fbbc]

        tdf#130857 weld: Abstract from "input"/"output" SpinButton signals
        
        So far, the weld::SpinButton logic to retrieve a value
        from text in its entry and (the other way around) to format a value into
        text to show in the entry was based on the concept of
        GtkSpinButton and its "input" [1] and "output" [2] signals
        for which handlers can be set that directly retrieve/set
        the text and value in the SpinButton.
        
        Continue and finish the work from previous commits
        
            Change-Id: I53df480e5b3b2e4eeb9f9fb0c24e8e735fae063b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 14 20:38:28 2025 +0100
        
                tdf#130857 weld: Let SpinButton output hdl only format the string
        
        and
        
            Change-Id: I4962497122b79c320f3c60e5565cd64973af6df3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 01:19:56 2025 +0100
        
                tdf#130857 weld: Let SpinButton::signal_output return text
        
        and
        
            Change-Id: Icb55f49cddeb1d039f4b4c8359058769cea77f14
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Feb 15 11:22:54 2025 +0100
        
                tdf#130857 weld: Let SpinButton input hdl only parse value from string
        
        to abstract away from those signals.
        
        Consider this as an implementation detail that dialog
        implementations don't have to deal with.
        It also doesn't match the approach that Qt's QSpinBox/QDoubleSpinBox
        uses for the value <-> text conversion.
        
        Instead, use the approach of having methods that
        simply convert a given value to a formatted string
        and vice versa, and call those from the "output" callback/handler
        in the GTK implementation of weld::SpinButton, GtkInstanceSpinButton,
        and call the method to set text/value with the returned value there.
        
        Dialogs (users of weld::SpinButton) can set a "value formatter"
        (a method that returns a formatted string for a given value) and a
        "text parser" (that returns an integer value for a given
        text).
        
        Part of the logic was already introduced in the above-mentioned
        commits. This commit adjusts the former weld::SpinButton::signal_output
        to take the value to format as an input parameter instead
        of calling weld::SpinButton::get_value itself to get the
        current value.
        Similarly, the former weld::SpinButton::signal_input
        now gets the text to parse as an input paramter instead
        of calling weld::SpinButton::get_text itself.
        
        Rename the methods to reflect the new semantics:
        
        * weld::SpinButton::signal_output -> weld::SpinButton::format_value
        * weld::SpinButton::signal_input -> weld::SpinButton::parse_text
        * weld::SpinButton::connect_output -> weld::SpinButton::set_value_formatter
        * weld::SpinButton::connect_input -> weld::SpinButton::set_text_parser
        
        GtkInstanceSpinButton and SalInstanceSpinButton are adjusted
        to pass the values accordingly, so no change in behavior
        is to be expected.
        
        [1] https://docs.gtk.org/gtk3/signal.SpinButton.input.html
        [2] https://docs.gtk.org/gtk3/signal.SpinButton.output.html
        
        Change-Id: If4cd12ef947233331a5deccba5c14a15e30a30c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181714
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [15ad64a412d80fdf05ee1783bcc277753eaa34bc]

        tdf#130857 weld: Let SpinButton input hdl only parse value from string
        
        Similar to how
        
            commit bbc51c66a3b499c3f4ac71e4e6f7a0f2d9984dfc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 14 20:38:28 2025 +0100
        
                tdf#130857 weld: Let SpinButton output hdl only format the string
        
        adjusted the logic to let weld::SpinButton::m_aOutputHdl only
        format a value into a string, also adjust the logic for
        weld::SpinButton::m_aInputHdl:
        
        Let it take a string and convert that into a value/integer,
        without having to retrieve the text from the SpinButton
        itself.
        
        As the text may not be parseable into an integer, use
        std::optional<int> as a return value. (An empty std::optial means
        that parsing failed, which was previously indicated by a return value
        of `false`).
        
        Besides simplifying the implementations (set via
        SpinButton::connect_input), this also aligns the logic
        more with what Qt's QDoubleSpinBox::valueFromText [1]
        does and thus prepares for implementing the required
        logic for QtInstanceSpinButton.
        
        [1] https://doc.qt.io/qt-6/qdoublespinbox.html#valueFromText
        
        Change-Id: Icb55f49cddeb1d039f4b4c8359058769cea77f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181713
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [70ffc422e515ca2ccea68de2c5bc4bf09cebf500]

        sc: Don't modify string passed to NumToAlpha/AlphaToNum
        
        The NumToAlpha and AlphaToNum helper functions
        are only used by ScNavigatorDlg::ParseRowInputHdl
        (and AlphaToNum also calls NumToAlpha in turn).
        
        So far, both methods were taking an `OUString&`
        param and modifying that string.
        
        However, ScNavigatorDlg::ParseRowInputHdl doesn't
        actually make use of the out param any more after
        calling those methods, so switch the param to
        `const OUString&` instead and stop modifying
        the value in the helper functions.
        
        In AlphaToNum, introduce a new local variable
        `aUpperCaseStr` so that the modified string
        can be used within that function without
        modifying the string passed as a param.
        
        In NumToAlpha, drop the call to ::ScColToAlpha,
        whose only effect was to modify the out param,
        and drop the now unused out param altogether.
        
        Change-Id: Idcfd743603e12a06633b615aa8c912c244f0bd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181712
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [d97caf36686ff31df96edbf40ef1aa3aecc5af4f]

        sc: Merge NumStrToAlpha into only caller
        
        ScNavigatorDlg::ParseRowInputHdl is the only
        caller of NumStrToAlpha, so merge the two.
        
        ScNavigatorDlg::ParseRowInputHdl already calls
        CharClass::isAsciiNumeric, so the repeated check in
        NumStrToAlpha was redundant.
        
        Change-Id: I0065aacb1350e01bdda73468c2f607d0a29967fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181711
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [62cb9a6f1f5c5cd5c8427978e2f9cdef550c1bd6]

        tdf#130857 qt weld: Implement QtInstanceBuilder::weld_metric_spin_button
        
        Do the same as the GTK implementation does.
        
        Change-Id: I1c15af157213f33120cf93ea8edcd9dfc08c5eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181686
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [bd06ce16f41331acca71c5132c7847fb856e2307]

        tdf#130857 weld: Let SpinButton::signal_output return text
        
        If a custom output handler was set via
        weld::SpinButton::connect_output, return the formatted string
        it generates for the current value in SpinButton::signal_output
        instead of directly setting it as the SpinButton's text using
        SpinButton::set_text.
        
        Let the subclasses which call the method take care of setting
        the text instead.
        
        If no handler is set, return an empty std::optional.
        
        This approach is similar to how SpinButton::signal_input
        returns the new value (via an out param).
        
        But the main reason is that simply calling
        weld::SpinButton::set_text to set the new text isn't sufficient
        for the Qt implementation in QtInstanceSpinButton, but
        QDoubleSpinBox::textFromValue  can be overriden for that
        purpose - and this commit prepares for an implementation
        that will do that in an upcoming commit.
        
        Change-Id: I4962497122b79c320f3c60e5565cd64973af6df3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181685
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [9298d909e6ed081516bda9513ba1f52e44e39be9]

        tdf#130857 weld: Let SpinButton output hdl only format the string
        
        Adjust the logic so that the weld::SpinButton::m_aOutputHdl
        set via weld::SpinButton::connect_output is now only
        responsible for returning a string format for a given spinbox
        value, i.e. it now has a sal_Int64 input parameter and
        a OUString return value.
        
        This means that the implementations for those handlers
        generally no longer need interact with the underlying
        weld::SpinButton directly, i.e. no longer need to call
        SpinButton::get_value and SpinButton::set_text to get the
        value and manually set the formatted string as the new
        text.
        
        That logic is for now moved to
        weld::SpinButton::signal_output which gets called by the
        weld::SpinButton implementations and calls the handlers
        (i.e. one level further up in the call stack) and other
        places directly calling the handlers.
        
        The main motivation is that in order to implement
        setting the formatted text based on a value for QSpinBox/QDoubleSpinBox
        can be done by overriding QDoubleSpinBox::textFromValue
        that takes a value and returns a string. Changing
        weld::SpinButton::m_aOutputHdl to a similar logic
        is one step in preparation of implementing the logic
        for QtInstanceSpinButton.
        
        No change in behavior intended.
        
        MetricSpinButton::spin_button_output was previously
        explicitly checking whether the new and old text
        were the same, and only calling weld::SpinButton::set_text
        if they were not. If not doing that any more there should
        result in any change in behavior, it might make sense
        to reimplement that logic in the weld::SpinButton::set_value
        implementations of the concrete weld::SpinButton subclasses
        instead.
        
        Change-Id: I53df480e5b3b2e4eeb9f9fb0c24e8e735fae063b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181684
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [80b2b9b6e1324ab109742a9d45631fbe5ee64489]

        sc: Simplify ScNavigatorDlg::FormatRowOutputHdl
        
        Call the ScColToAlpha version that returns a OUString
        instead of using an out param.
        
        Change-Id: Iac25682b7b2bd731c9b04ca1c7ba7d0efbdd1605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181683
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [41df8ca6cb7ec210cf391ff27fce1a6eb36de33b]

        QuickLook Preview/Thumbnail version should match the app's version
        
        appstore verification complains about CFBundleVersion Mismatch /
        CFBundleShortVersionString Mismatch and while submissions aren't
        rejected yet "you may want to correct the following issues in your
        next delivery"…
        
        Change-Id: I19f7db194c1f027f91eb84100955f85cd0bfd545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181681
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-02-15  Rahul Anand  <rahul.anand1222004@gmail.com>  [b5e1580544194c77ac0214c90c23fa47447ef1d9]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I6803a035266203bec99a910ac65757267892967b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181670
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-15  Rahul Anand  <rahul.anand1222004@gmail.com>  [43f5ad59d64ef48669d99bbae349cc556a674bad]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: Id0e2d001a660a2e1a52a11febe1d0ead42f8761e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180639
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [7593261bc98c3915d874fca59440d1d5a7f96a2c]

        Optimize SwDocInfoField::ExpandImpl a bit
        
        Avoids some needless calculations, and reorders checks to skip some
        calls for fixed fields
        
        Change-Id: Ia079904dbfc2818e5c53ce7d3748fd10831359b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181701
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [828221842b77e15e2115aff106906b95051919c3]

        Make Date::GetAsNormalizedDays public, and use it for optimization
        
        The function was introduced specifically to speed up the common case
        of null date value, and we can make use of that.
        
        Change-Id: I26ccd2a4abce7a9d9dcd828a62c700c7319b30ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181700
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [0ab6cb2583b5c835036b366333961a6d386b64ce]

        Simplify special debug function handling
        
        Having some arrays of C strings far away from the use point; using
        some unobvious arithmetics (with unrelated enum values) to get the
        array elements; using loops just for two elements - all that makes
        simple repeated comparison a better choice.
        
        Change-Id: Icaaa771a2cf529fa2cc2b946d5128ee1deba31e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181703
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [1acf329e7f0501549e8882952ecffc43abc41521]

        Introduce GetInt16WithDefault, and use in ScGetWeekOfYear to simplify
        
        Change-Id: I29b91222d653d28e1d6cb853d815d7bea2c8bedd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181699
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [804d54e5a1a72a95d978cb76e7a53c08c97ffc8c]

        ScDde doesn't need GetUInt32
        
        Use GetInt32 instead.
        
        Change-Id: I2e0868dfc548c6378e0dd0c5bb5e3921b0091334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181698
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [572fee6ca74f86f094418ec747803ef045901eea]

        Getting workdays doesn't need GetUInt32
        
        All other placed in Calc, that take dates, use GetFloor32; switch
        to that for consistency.
        
        Change-Id: If198ab3f6ef3a6a1866bfeed6bca14edcd815bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181697
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [3c53ab89693bd0e930c0a9b8a222199c5b714171]

        ScIndex doesn't need GetUInt32
        
        The minimal allowed value for the fourth argument is 1. Using GetInt32
        allows to easily switch to GetInt32WithDefault, if needed.
        
        Change-Id: I5b7585b939ae71b417597c5f389197b3df6c0d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181696
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [168c17d4864922fac26cd8bfc7da4a119efb9fab]

        Implement GetUInt32 using double_to<sal_uInt32>
        
        This unifies the implementation with other conversions to integers.
        It is theoretically a behavior change, since it now treats numbers
        in the range of (-0.5;0) as 0, and succeeds, where it previously
        failed. But:
        
        (1) this shouldn't be a problem in practice;
        (2) this is consistent with the general spreadsheet convention of
            rounding when converting to integers.
        
        Change-Id: Ib2455d9b9a253dcf6e00cc7fafe61964aeb7ab33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181695
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [58a3233f5873fb40996682c35ef9c1e19e03ef4d]

        Deduplicate conversion to integers
        
        Change-Id: I225b304651048c6cc97397d8780e0463e3b5f984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181694
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [c38f9a4cd8537377337bd8558b197d937e30dcd1]

        Simplify Get*WithDefault to delegate to GetDoubleWithDefault
        
        Change-Id: I8be117954f58775e7b7ebbd441d252030f175f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [196806fe04963bc83dbae9134e0158361322247f]

        Deduplicate ScInterpreter::GetStackType
        
        Avoid code duplication.
        
        Change-Id: I48bb3b00568e80f2de5b9fe632ed9c2db341c9cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181692
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-15  Rahul Anand  <rahul.anand1222004@gmail.com>  [b3ae7a16b5e5f1b1d3498a6ae599c579c7241991]

        tdf#147132: Flatten Basic function implementations
        
        Change-Id: Iac462f843bb1437027d2e7a5b6b856d2f00deb8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181317
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-15  Rahul Anand  <rahul.anand1222004@gmail.com>  [6d0bcc1a14ade7d37f75599246fc4523255722b6]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Idb6d6c2aa9fa81cbae35b35b4aa2d0908efa1796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181309
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-02-15  Daniel Frantes  <danfrantes@seznam.cz>  [b78e3343b5e8e39b178b85c1e1713921678094e9]

        tdf#132293: Fix issues found by pyflakes
        
        Change-Id: I971ca13741c07dfe3a34857272bad5b1754d9968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177822
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-02-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [f67bf3783d947f1784a2cf9343315112f690c581]

        weak pointer for BroadcasterMixins
        
        - replace remaining use of SwDeleteListener with sw::WeakBroadcastingPtr
        - fold SvtDeleteListener into sw::WeakBroadcastingPtr<>
        
        Change-Id: I97e7f4e4074f3a13af1e0bca80043e08803e2d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-14  Michael Weghorn  <m.weghorn@posteo.de>  [b4059c4b9ae2230d9c6d722d457dca2216ddd581]

        gtk4 a11y: Report update to focused state
        
        Recent GTK 4 upstream commits [1] [2]
        
            commit 224e587cd30b9452eb19d3ec06f9f49ccd3c7cd0
            Author: Emmanuele Bassi <ebassi@gnome.org>
            Date:   Thu Feb 13 12:15:50 2025 +0000
        
                a11y: Emit platform state changes on non widgets
        
                GtkAccessible implementations are not necessarily widgets, so handle
                platform states just like we do for any other state attribute.
        
                Fixes: #6272
        
            commit e7dfe11e6aa3513a661bfbe5028ad0d792a3fc9e
            Author: Emmanuele Bassi <ebassi@gnome.org>
            Date:   Thu Feb 13 12:09:18 2025 +0000
        
                a11y: Add platform change notification method
        
                Some GtkAccessible implementations have a concept of "platform state": a
                state inherent to the toolkit, and not under user control. We already
                allow accessible objects to provide that state when implementing the
                GtkAccessible interface, but we have no way of communicating changes in
                the platform state to assistive technologies.
        
                See: #6272
        
        introduced API that allows notifying of changes to
        "platform states" for non-GtkWidget GtkAccessible implementations
        This includes changes to the focused state.
        
        Use that API to notify about changes to the FOCUSED
        state.
        
        This is essential for assistive technology like the
        Orca screen reader, which announces the newly focused
        object based on the corresponding object:state-changed:focused
        AT-SPI event that gets emitted.
        
        With this in place, Orca now e.g. announces the currently
        focused toolbar button in Writer's toolbars when moving
        focus between the items using the Tab key.
        
        Focus changes between paragraphs in Writer are currently
        still not announced reliably with the gtk4 VCL plugin,
        which is probably due to another issue.
        
        Orca now querying information for newly focused objects
        was seen to (sometimes) trigger crashes when a Writer
        paragraph gets focus. This turned out to be related to
        the logic for text attribute runs.
        GTK MR with a suggested fix: [3]
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/224e587cd30b9452eb19d3ec06f9f49ccd3c7cd0
        [2] https://gitlab.gnome.org/GNOME/gtk/-/commit/e7dfe11e6aa3513a661bfbe5028ad0d792a3fc9e
        [3] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/8208
        
        Change-Id: Icab099eee6d895fe4373ef6356793ca0789e8b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161062
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-14  Noel Grandin  <noelgrandin@gmail.com>  [b478b176a2a1fe10102ea084423123f984c805cc]

        fix regression in GDI rendering
        
        after
            commit 42cc3b58451dec8a99af9c26e8bc947cce0ae058
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 24 11:52:18 2025 +0200
            N32BitTcMask is unnecessary
        
        which went unnoticed because our unit tests currently run the skia
        backend, but if we had run
         SAL_DISABLESKIA=1 make CppunitTest_vcl_backend_test
        on Windows, we would see a failure.
        
        Change-Id: I6e291db3b1c33d9378e1db9780f9c9429ee5fa2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181675
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-14  Justin Luth  <justin.luth@collabora.com>  [793853fbd1665e90ab91e9b45826174707617275]

        tdf#164703 tdf#111969 sw Get*Correction: only mouse passes PixelPos
        
        This fixes my 24.8 commit 5bc7d0186d1a70990377a2f4c630fe11e2dfd166.
        
        All my focus was on mouse clicks, so I didn't realize that
        keyboard shortcuts were badly affected.
        
        Avoid all of that cursor -> pixel -> cursor madness
        and just don't provide a pixel position at all
        when it is a keyboard request for a context menu.
        
        I don't see how to create a unit test for this. (See earlier patchsets)
        
        Change-Id: Id1fe7d1c15ce590ea4f882be49cfe539971c8c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181522
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-02-14  Patrick Luby  <guibmacdev@gmail.com>  [a53f44ce842b30da14463f282eddec21c32b016f]

        Set bundle identifier to match Mac App Store requirements
        
        The Mac App Store expects the bundle identifier to be the application's
        bundle identifier + "." + the extension name and the extension name
        cannot have any period characters.
        
        Change-Id: I8c2ee048dc52bec961e6d740edfd05cf3e11d631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180257
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-02-14  Attila Szűcs  <attila.szucs@collabora.com>  [f3162dd1e3afbed73ed094d5745ba747fcf089cd]

        SD: fillapi: slide, text, uno commands
        
        Implemented extract and transform for slides.
        It can manipulate slides and some of its text content.
        
        usable commands for transform:
        
        {"JumpToSlide": 4},   //jump to slide 4 (counted from 0) "last" can be used
        {"JumpToSlideByName": "Slide 4"},jump to slide named "Slide 4"
        {"InsertMasterSlide": 10}, //insert the 10. masterSlide after the
        actual slide, and jump to this new Slide
        {"InsertMasterSlideByName": "name"}, //same as InsertMasterSlide,
        but with parameter of masterSlide name.
        {"DeleteSlide": 2},   // delete the 2. slide. It may or may not
        change the actual slide
        can be used without parameter:
        {"DeleteSlide": ""}, // it delete the actual slide.
        {"MoveSlide.2": 5}, // move the 2. slide to the 5. position, if it is
        the actual slide, then jump to the new position of this slide.
        If it is not the actual slide then it may jump, so the actual Slide
        eill remain the same.
        {"MoveSlide": 5}, // move the actual slide to the 5. position
        {"DuplicateSlide": 5}, //duplicate the 5. slide , it jumps to the
        duplicated slide
        {"DuplicateSlide": ""}, // duplicate the actual slide
        {"ChangeLayout": 18},  // change the actual page layout
        to the 18. layout. (would be good to have a better ID)
        {"ChangeLayoutByName": "AUTOLAYOUT_TITLE_2CONTENT"}, //same as
        ChangeLayout, nbut indxed by the layout name.
        {"RenameSlide": "NewNameForSlide"}, //rename the actual slide
        {"SetText.0": "first"},  //set the text of 0. sdrobject on the
        actual page to "first"
        {"MarkObject": "1"},    //mark the 1. sdrobject on the actual slide
        {"UnMarkObject": "1"},  //Unmark the 1. sdrobject on the act slide
        {"UnoCommand": ".uno:DefaultBullet"}, //run an uno command.
        This uno command toggle the default bullet type on thext marked.
        
        There are many more uno commands.
        Limited uno commands allowed to be used here, because some would
        be dangerous.
        For allowed uno commands, check lokunocmdlist.hxx.
        
        Note: Uno commands not worked on a windows system
        
        For layout names these can be used:
        "AUTOLAYOUT_TITLE_CONTENT"
        "AUTOLAYOUT_TITLE_CONTENT_OVER_CONTENT"
        "AUTOLAYOUT_TITLE_CONTENT_2CONTENT"
        "AUTOLAYOUT_TITLE_4CONTENT"
        "AUTOLAYOUT_ONLY_TEXT"
        "AUTOLAYOUT_TITLE_ONLY"
        "AUTOLAYOUT_TITLE_6CONTENT"
        "AUTOLAYOUT_TITLE"
        "AUTOLAYOUT_TITLE_2CONTENT_CONTENT"
        "AUTOLAYOUT_TITLE_2CONTENT_OVER_CONTENT"
        "AUTOLAYOUT_TITLE_2CONTENT"
        "AUTOLAYOUT_VTITLE_VCONTENT"
        "AUTOLAYOUT_VTITLE_VCONTENT_OVER_VCONTENT"
        "AUTOLAYOUT_TITLE_VCONTENT"
        "AUTOLAYOUT_TITLE_2VTEXT"
        
        Extract will:
        Extract all masterSlides name
        Extract the following for all Slides:
        Name, MatsreSlideName, LayoutId, LayoutName, ObjectCount, Objects.
        
        For all objects it will extract:
        TextCount, Texts
        
        For all texts it will extract:
        ParaCount, Paragraphs
        
        where Paragraphs is an array of strings.
        
        Change-Id: Icab5afe44acc30f8b75974240d8b39fd040ede2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181671
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-14  Simon Chenery  <simon_chenery@yahoo.com>  [391e1d1a39ff9d3fd407253ef79354261fd6e7c3]

        tdf#158068 Use OUString literals in DataInterpreter.cxx
        
        Change-Id: I53c620921a93265513dcb4460d73902eff97ed5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181647
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-14  Michael Weghorn  <m.weghorn@posteo.de>  [38024bc9559d75696eb8c91ac5b0b41be0baa55f]

        gtk4: Own the string when freeing it
        
        As the GVariant format string doc says [1] about
        pointers:
        
        > The `&` character is used to indicate that serialised data should be
        > directly exchanged via a pointer.
        >
        > Currently, the only use for this character is when it is applied to a
        > string (ie: `&s`, `&o` or `&g`). For `g_variant_new()` this has absolutely no
        > effect. The string is collected and duplicated normally. For
        > `g_variant_get()` it means that instead of creating a newly allocated copy
        > of the string, a pointer to the serialised data is returned. This
        > pointer should not be freed. Validity checks are performed to ensure
        > that the string data will always be properly nul-terminated.
        
        Therefore, freeing the string with
        
            g_free(pLabel);
        
        is incorrect and resulted in a crash when starting Writer with
        the gtk4 VCL plugin, s. backtrace below.
        
        Use just "s" instead of "&s" for the format string to get a
        string copy that is owned and can be freed.
        
        (Dropping the `g_free` might be an alternative and avoid
        a string copy, but it's not instantly clear to me whether
        using "a pointer to the serialised data" is safe without
        digging any deeper what exactly that means.)
        
        Backtrace:
        
            free(): invalid pointer
            [New Thread 125500.125502]
            [New Thread 125500.125503]
            [New Thread 125500.125504]
            [New Thread 125500.125505]
            [New Thread 125500.125506]
            [New Thread 125500.125507]
            [New Thread 125500.125508]
            [New Thread 125500.125510]
            [New Thread 125500.125511]
            [New Thread 125500.125525]
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (rr) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007f0bb969de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007f0bb9649d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007f0bb96324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007f0bb963332d in __libc_message_impl (fmt=fmt@entry=0x7f0bb97b5303 "%s\n") at ../sysdeps/posix/libc_fatal.c:134
            #5  0x00007f0bb96a7965 in malloc_printerr (str=str@entry=0x7f0bb97b3082 "free(): invalid pointer") at ./malloc/malloc.c:5772
            #6  0x00007f0bb96a9bf4 in _int_free (av=0x7f0bb97f1ac0 <main_arena>, p=<optimized out>, have_lock=have_lock@entry=0) at ./malloc/malloc.c:4507
            #7  0x00007f0bb96ac43f in __GI___libc_free (mem=<optimized out>) at ./malloc/malloc.c:3398
            #8  0x00007f0ba62b908a in (anonymous namespace)::MenuHelper::get_item_label (this=0x55b0c8dcd360, rIdent="standard") at vcl/unx/gtk4/../gtk3/gtkinst.cxx:5684
            #9  0x00007f0ba63013d8 in (anonymous namespace)::GtkInstanceMenu::get_label (this=0x55b0c8dcd360, rIdent="standard") at vcl/unx/gtk4/../gtk3/gtkinst.cxx:11694
            #10 0x00007f0ba6301b2f in virtual thunk to (anonymous namespace)::GtkInstanceMenu::get_label(rtl::OUString const&) const () at vcl/unx/gtk4/../gtk3/gtkinst.cxx:11823
            #11 0x00007f0bb482d026 in (anonymous namespace)::SelectionTypePopup::GetItemTextForState (this=0x7ffed304ad80, nState=0) at /home/michi/development/git/libreoffice/svx/source/stbctrls/selctrl.cxx:56
            #12 0x00007f0bb482cc59 in SvxSelectionModeControl::StateChangedAtStatusBarControl (this=0x55b0c8d2d6e0, eState=SfxItemState::DEFAULT, pState=0x55b0c8f331c0) at /home/michi/development/git/libreoffice/svx/source/stbctrls/selctrl.cxx:128
            #13 0x00007f0bb5f9af1e in SfxStatusBarControl::statusChanged (this=0x55b0c8d2d6e0, rEvent=...) at /home/michi/development/git/libreoffice/sfx2/source/statbar/stbitem.cxx:263
            #14 0x00007f0bb5a9d4c8 in SfxDispatchController_Impl::addStatusListener (this=0x55b0c8ed6380, aListener=uno::Reference to (SvxSelectionModeControl *) 0x55b0c8d2d6f0, aURL=...)
                at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:841
            #15 0x00007f0bb5a9d174 in SfxOfficeDispatch::addStatusListener (this=0x55b0c8f280e0, aListener=uno::Reference to (SvxSelectionModeControl *) 0x55b0c8d2d6f0, aURL=...)
                at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:283
            #16 0x00007f0bb28a8577 in svt::StatusbarController::bindListener (this=0x55b0c8d2d6e0) at /home/michi/development/git/libreoffice/svtools/source/uno/statusbarcontroller.cxx:462
            #17 0x00007f0bb28a7f09 in svt::StatusbarController::update (this=0x55b0c8d2d6e0) at /home/michi/development/git/libreoffice/svtools/source/uno/statusbarcontroller.cxx:169
            #18 0x00007f0bb6d41a6b in framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > >::operator() (this=0x7ffed304b547, rElement={...})
                at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:69
            #19 0x00007f0bb6d3e5ef in std::for_each<__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > >, std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > >, std::bidirectional_iterator_tag>, framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > > > (__first={...}, __last={...}, __f=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_algo.h:3786
            #20 0x00007f0bb6d3d9a5 in framework::StatusBarManager::UpdateControllers (this=0x55b0c8cefc90) at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:269
            #21 0x00007f0bb6d4028b in framework::StatusBarManager::FillStatusBar (this=0x55b0c8cefc90, rItemContainer=uno::Reference to (framework::ConstItemContainer *) 0x55b0c8e017e8)
                at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:479
            #22 0x00007f0bb6d4ae38 in framework::StatusBarWrapper::initialize (this=0x55b0c8d0f060, aArguments=uno::Sequence of length 4 = {...}) at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarwrapper.cxx:117
            #23 0x00007f0bb6df9104 in framework::MenuBarFactory::CreateUIElement
                (ResourceURL="private:resource/statusbar/statusbar", Args=uno::Sequence of length 2 = {...}, ResourceType=u"private:resource/statusbar/", _xMenuBar=uno::Reference to (framework::StatusBarWrapper *) 0x55b0c8d0f0f8, _rxContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x55b0ba8b8308) at /home/michi/development/git/libreoffice/framework/source/uifactory/menubarfactory.cxx:158
            #24 0x00007f0bb6df9c0a in (anonymous namespace)::StatusBarFactory::createUIElement (this=0x55b0c8e03800, ResourceURL="private:resource/statusbar/statusbar", Args=uno::Sequence of length 2 = {...})
                at /home/michi/development/git/libreoffice/framework/source/uifactory/statusbarfactory.cxx:68
            #25 0x00007f0bb6df9d74 in non-virtual thunk to (anonymous namespace)::StatusBarFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #26 0x00007f0bb6e01290 in (anonymous namespace)::UIElementFactoryManager::createUIElement (this=0x55b0bf803260, ResourceURL="private:resource/statusbar/statusbar", Args=uno::Sequence of length 2 = {...})
                at /home/michi/development/git/libreoffice/framework/source/uifactory/uielementfactorymanager.cxx:440
            #27 0x00007f0bb6e024f4 in non-virtual thunk to (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #28 0x00007f0bb6b6d427 in framework::LayoutManager::implts_createElement (this=0x55b0c1e3a170, aName="private:resource/statusbar/statusbar")
                at /home/michi/development/git/libreoffice/framework/source/layoutmanager/layoutmanager.cxx:730
            #29 0x00007f0bb6b71852 in framework::LayoutManager::implts_createStatusBar (this=0x55b0c1e3a170, aStatusBarName="private:resource/statusbar/statusbar")
                at /home/michi/development/git/libreoffice/framework/source/layoutmanager/layoutmanager.cxx:849
            #30 0x00007f0bb6b75bcc in framework::LayoutManager::createElement (this=0x55b0c1e3a170, aName="private:resource/statusbar/statusbar") at /home/michi/development/git/libreoffice/framework/source/layoutmanager/layoutmanager.cxx:1443
            #31 0x00007f0bb6b76b57 in framework::LayoutManager::requestElement (this=0x55b0c1e3a170, rResourceURL="private:resource/statusbar/statusbar")
                at /home/michi/development/git/libreoffice/framework/source/layoutmanager/layoutmanager.cxx:1570
            #32 0x00007f0bb595f0b5 in SfxWorkWindow::UpdateStatusBar_Impl (this=0x55b0bf82f570) at /home/michi/development/git/libreoffice/sfx2/source/appl/workwin.cxx:1471
            #33 0x00007f0bb595e9a0 in SfxWorkWindow::UpdateObjectBars_Impl2 (this=0x55b0bf82f570) at /home/michi/development/git/libreoffice/sfx2/source/appl/workwin.cxx:1242
            #34 0x00007f0bb595e001 in SfxWorkWindow::UpdateObjectBars_Impl (this=0x55b0bf82f570) at /home/michi/development/git/libreoffice/sfx2/source/appl/workwin.cxx:1095
            #35 0x00007f0bb59ca573 in SfxDispatcher::Update_Impl (this=0x55b0c742b5b0, bForce=false) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:1123
            #36 0x00007f0bb6003921 in SfxBaseController::ConnectSfxFrame_Impl (this=0x55b0c7469930, i_eConnect=SfxBaseController::E_CONNECT) at /home/michi/development/git/libreoffice/sfx2/source/view/sfxbasecontroller.cxx:1207
            #37 0x00007f0bb6002ade in SfxBaseController::attachFrame (this=0x55b0c7469930, xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55b0bfb36e40)
                at /home/michi/development/git/libreoffice/sfx2/source/view/sfxbasecontroller.cxx:531
            #38 0x00007f0bb5fd38b9 in utl::ConnectFrameControllerModel
                (xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55b0bfb36e40, xController=uno::Reference to (SwXTextView *) 0x55b0c7469958, xModel=uno::Reference to (SwXTextDocument *) 0x55b0c71c0670)
                at include/unotools/fcm.hxx:57
            #39 0x00007f0bb5fcfec1 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView
                (i_rModel=uno::Reference to (SwXTextDocument *) 0x55b0c71c0670, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55b0bfb36e40, i_rViewFactoryArgs=..., i_rViewName="Default")
                at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:585
            #40 0x00007f0bb5fcd45c in (anonymous namespace)::SfxFrameLoader_Impl::load (this=0x55b0c22dc9f0, rArgs=uno::Sequence of length 9 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55b0bfb36e40)
                at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:764
            #41 0x00007f0bb6bc2644 in framework::LoadEnv::impl_loadContent (this=0x55b0c1271ec8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:1180
            #42 0x00007f0bb6bbf7a5 in framework::LoadEnv::start (this=0x55b0c1271ec8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:415
            #43 0x00007f0bb6bbd452 in framework::LoadEnv::startLoading
                (this=0x55b0c1271ec8, sURL="private:factory/swriter", lMediaDescriptor=uno::Sequence of length 4 = {...}, xBaseFrame=uno::Reference to (framework::Desktop *) 0x55b0bbbee8c8, sTarget="_default", nSearchFlags=0, eFeature=(LoadEnvFeatu--Type <RET> for more, q to quit, c to continue without paging--
            res::WorkWithUI | LoadEnvFeatures::AllowContentHandler)) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:311
            #44 0x00007f0bb6a56311 in framework::LoadDispatcher::impl_dispatch (this=0x55b0c1271e70, rURL=..., lArguments=uno::Sequence of length 4 = {...}, xListener=empty uno::Reference)
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:107
            #45 0x00007f0bb6a57071 in framework::LoadDispatcher::dispatchWithReturnValue (this=0x55b0c1271e70, rURL=..., lArguments=uno::Sequence of length 4 = {...})
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:60
            #46 0x00007f0bb6a57114 in non-virtual thunk to framework::LoadDispatcher::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:60
            #47 0x00007f0bb80110b0 in comphelper::SynchronousDispatch::dispatch (xStartPoint=uno::Reference to (framework::Desktop *) 0x55b0bbbee8b8, sURL="private:factory/swriter", sTarget="_default", lArguments=uno::Sequence of length 4 = {...})
                at /home/michi/development/git/libreoffice/comphelper/source/misc/synchronousdispatch.cxx:62
            #48 0x00007f0bb99757fd in desktop::DispatchWatcher::executeDispatchRequests (this=0x55b0c16043b0, aDispatchRequestsList=std::__debug::vector of length 1, capacity 1 = {...}, bNoTerminate=false)
                at /home/michi/development/git/libreoffice/desktop/source/app/dispatchwatcher.cxx:529
            #49 0x00007f0bb9993b5a in desktop::RequestHandler::ExecuteCmdLineRequests (aRequest=..., noTerminate=false) at /home/michi/development/git/libreoffice/desktop/source/app/officeipcthread.cxx:1347
            #50 0x00007f0bb992f196 in desktop::Desktop::OpenDefault () at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:2276
            #51 0x00007f0bb992e5cd in desktop::Desktop::OpenClients () at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:2220
            #52 0x00007f0bb992c3a3 in desktop::Desktop::OpenClients_Impl (this=0x7ffed3055280) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1979
            #53 0x00007f0bb992aa3d in desktop::Desktop::LinkStubOpenClients_Impl (instance=0x7ffed3055280, data=0x0) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1963
            #54 0x00007f0bb02ac091 in Link<void*, void>::Call (this=0x55b0bffb6ba8, data=0x0) at include/tools/link.hxx:105
            #55 0x00007f0bb02a8291 in ImplHandleUserEvent (pSVEvent=0x55b0bffb6ba0) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2285
            #56 0x00007f0bb02a51ba in ImplWindowFrameProc (_pWindow=0x55b0bfc9e9b0, nEvent=SalEvent::UserEvent, pEvent=0x55b0bffb6ba0) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2849
            #57 0x00007f0bb0e665bc in SalFrame::CallCallback (this=0x55b0bf7eaa50, nEvent=SalEvent::UserEvent, pEvent=0x55b0bffb6ba0) at vcl/inc/salframe.hxx:311
            #58 0x00007f0bb0e8ef5f in SalGenericDisplay::ProcessEvent (this=0x55b0baa61510, aEvent=...) at /home/michi/development/git/libreoffice/vcl/unx/generic/app/gendisp.cxx:66
            #59 0x00007f0bb09aaddd in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7ffed3053530) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:119
            #60 0x00007f0bb09aacb6 in SalUserEventList::DispatchUserEvents (this=0x55b0baa61510, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:120
            #61 0x00007f0bb0e8eeb5 in SalGenericDisplay::DispatchInternalEvent (this=0x55b0baa61510, bHandleAllCurrentEvent=false) at /home/michi/development/git/libreoffice/vcl/unx/generic/app/gendisp.cxx:51
            #62 0x00007f0ba628536f in call_userEventFn (data=0x55b0ba8d13e0) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:827
            #63 0x00007f0babd03d5f in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #64 0x00007f0babd05fd7 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #65 0x00007f0babd06740 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #66 0x00007f0ba62840ac in GtkSalData::Yield (this=0x55b0ba8d13e0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
            #67 0x00007f0ba6289863 in GtkInstance::DoYield (this=0x55b0ba8d1290, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:439
            #68 0x00007f0bb0a75c06 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #69 0x00007f0bb0a7551f in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #70 0x00007f0bb0a75300 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #71 0x00007f0bb9928a19 in desktop::Desktop::Main (this=0x7ffed3055280) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1679
            #72 0x00007f0bb0a970d6 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #73 0x00007f0bb0a98cc9 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #74 0x00007f0bb99a22fa in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #75 0x000055b09e4b3a6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #76 0x000055b09e4b3a47 in main (argc=2, argv=0x7ffed3055488) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        [1] https://docs.gtk.org/glib/gvariant-format-strings.html#pointers
        
        Change-Id: I87bd2840ac573426264d1dff2fd40ab292f09fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181666
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-14  Michael Weghorn  <m.weghorn@posteo.de>  [ec95d529b51e95b074adaafb9f113904fed636c7]

        tdf#165238 qt: Rely on Qt for "text/plain" and UTF-8 clipboard text
        
        QMimeData::text implements handling for the
        "text/plain;charset=utf-8" and "text/plain" MIME types
        (see [1]).
        
        Rely on that instead of implementing our own handling for
        these MIME types.
        
        This fixes copying Greek characters from Firefox as plain
        text into Writer with qt6 on Wayland (tdf#165238).
        
        This approach was already mentioned as an idea in
        
            commit 5b3227fac58dcbd588e2389e205679cd77842bac
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Apr 6 13:51:59 2022 +0200
        
                tdf#147285 qt: Prefer "text/plain;charset=utf-8" over "text/plain"
        
        > (An alternative solution to adding our own handling for
        > "text/plain;charset=utf-8" and making assumptions for the
        > encoding of "text/plain" data would be to let Qt handle
        > this and just call `QMimeData::text()` for the
        > `m_bProvideUTF16FromOtherEncoding=true` case
        > in `QtTransferable::getTransferData`.
        > Since qtbase commit 589a01ff6b1eacf81e74a5fc4801572135214f43
        > ("QMimeData: Prefer UTF-8 when multiple charsets are available",
        > contained in Qt >= 5.13), that one handles MIME type
        > "text/plain;charset=utf-8" in addition to "text/plain".)
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qmimedata.cpp?id=6c61d7b0f804ae5c048af95abef4d41ecc8862df#n383
        
        Change-Id: Iee695f62e836f3a8776b719ca95afb8fbddea82f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181660
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [38bad260039a6d3ec6a4ce39859ab13dfe8d9c4c]

        use more concrete UNO in writer
        
        Change-Id: I5a177f6bf1a0dc134ed1b0cf80f0e99cc1fcb937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181667
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-14  Noel Grandin  <noelgrandin@gmail.com>  [01c6aa4bfa4d3a54f2126b4752a817e69f40685a]

        simplify WinSalVirtualDevice construction
        
        Change-Id: I6eafe9ea2fe4d4f2faca9cfe9427009926833fd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-14  Julien Nabet  <serval2412@yahoo.fr>  [4e1bf615897c234dff5817e709bb8f1bcc146fe3]

        Refine sync of SDBC with JDBC 4.3
        
        1) Implement more missing parts of the API and correct doxygen commands to properly refer to them:
           - Constant group com.sun.star.sdbc.PseudoColumnUsage (see https://devdocs.io/openjdk~21/java.sql/java/sql/pseudocolumnusage)
           - Interface com.sun.star.sdbc.RowId (see https://devdocs.io/openjdk~21/java.sql/java/sql/rowid)
        
        2) Document return type of getRowIdLifetime(); in Java it is a proper enum, but in IDL it is a generic long,
           but is supposed to come from constant group com.sun.star.sdbc.RowIdLifetime
        
        Change-Id: Idef8eacb6692cb0b9cacc2b21d1eda807b5ad802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181467
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-02-14  Miklos Vajna  <vmiklos@collabora.com>  [1f725b2c2afae70d7886b89a2936ab9ced53b599]

        configure: fix --disable-skia build of pdfium
        
        A problem since commit 6007fbef5c2e4a0b80a4c0031ff36117aa41e63f (Update
        pdfium to 7012, 2025-02-13), it's one thing that pdfium needs to be
        built with clang-cl on Windows (similar to Skia), but our configure
        didn't configure clang-cl when skia was off. So do it when either skia
        or pdfium is enabled.
        
        Reported at
        <https://lists.freedesktop.org/archives/libreoffice/2025-February/093003.html>.
        
        Change-Id: I261b98511b664182d46a4a11ecbb40ad91663c41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181665
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [177cd3b79ee72dfc83eeb7a4871ec72f45c34668]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2138236ec937d2c25cac2742f0cb7f01b2ef9ee5
          - Fix bad link in Save Remote menu page.
            
            Change-Id: I184db06440d664165d0653ce4c6efbeb26f09096
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181669
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bc60c54878185bcd7d95cc87e9b94a785a086915]

        If necessary, fall back to an approximation of WorkerGlobalScope.importScripts
        
        ...for --disable-emscripten-proxy-to-pthread, where runUnoScriptUrl is run on
        the browser main thread
        
        Change-Id: I49c44219b7f77bbc8552994fe3e8483ae0e138fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-14  Christopher Sherlock  <chris.sherlock79@gmail.com>  [3b4793b366982d84b07fefe26470d0d12bf49733]

        vcl: document BitmapFilter
        
        Change-Id: I68cbb0a6b9050c89050afd1906d6fd948f9bff45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180822
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [41ab24cecd6ad74312843f113d2faa13259cdb7d]

        tdf#130857 qt weld: Set model index in tree iter again
        
        This went wrong in
        
            commit ee1868536701873dd3a8946c33dce51941b4f6f0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 10:44:24 2025 +0100
        
                tdf#130857 qt weld: Make QtInstanceTreeIter::m_aModelIndex private
        
        Change-Id: I2c140c2775d185c5b79ec9cacad45d12114ddcf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181652
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [dd9096736e2e89cc533bc04c77bf539bcc5df6bc]

        tdf#130857 qt weld: Show IconView item tooltips
        
        Register the QtInstanceIconView as an event filter
        for the QListView that holds the items and show
        the tooltip text for the currently hovered item,
        if there is one.
        
        This works fine for the "Insert" -> "Fontwork"
        dialog in Writer with the qt6 VCL plugin and
        SAL_VCL_QT_USE_WELDED_WIDGETS=1.
        
        Change-Id: I9c6d0e3309d4303558d64e1ca83b636ac3de712e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181651
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f0a9a00f75527166f0fb077614d2538764c2f7b]

        postgresql: upgrade to 14.16
        
        * external/postgresql/0001-Assume-that-stdbool.h-conforms-to-the-C-standard.patch.1
        has been fixed upstream
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.16/postgresql-14.16.tar.bz2
        
        Change-Id: I48eb460ea141385b3335b11e21e818ffd02a15e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181644
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d64d8bd8bcb23af9e246a59ec33d6bbb3994f1be]

        Instances of salhelper::Thread must not be allocated on the stack
        
        ...as salhelper::Thread::onTerminated() calls
        salhelper::SimpleReferenceObject::release() calls delete this
        
        Change-Id: I3d64882dab014e270806fcc12461f816bc9d101d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181631
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-13  Christopher Sherlock  <chris.sherlock79@gmail.com>  [4159d6238e7c7b9549de51a71ca78c37a6826ba2]

        vcl: remove using namespace from edit.cxx
        
        Change-Id: Iaf57c25c658686e980171ffd3314f69096421ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178504
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff8400cdecfa152ca1a58412f4a52f0467f874d3]

        curl: upgrade to 8.12.1
        
        Downloaded from https://curl.se/download/curl-8.12.1.tar.xz
        
        Change-Id: I038e6bb402a5c6f19ac30efd9e8aa1aaf020b63b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181630
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [be7ee86fff11807035d54b5515a91abfc418e748]

        gtk3 a11y: No longer report IconView item tooltip as a11y desc
        
        This is the gtk3 (GtkInstanceIconView) version of
        
            Change-Id: I153e91292ec70bb3a6dc4e1d473dc0362af55c79
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 16:43:03 2025 +0100
        
                vcl a11y: No longer report IconView item tooltip as a11y desc
        
        that effectively did the same for the VCL version
        (SalInstanceIconView).
        
        See commit message of the above-mentioned commit and those
        commits referenced from it for more details.
        
        Change-Id: I98eba69cf0061d15d0bfc4da9e4b7a1e1e8428b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181639
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [b446ea138b4ce0ac674008edf3e181c4f8476b87]

        vcl a11y: Don't use same text for list item a11y name and description
        
        Unless an accessible name has explicitly been set,
        AccessibleListBoxEntry::getAccessibleName calls
        AccessibleListBoxEntry::implGetText which calls
        SvTreeListBox::SearchEntryTextWithHeadTitle to
        get an accessible name.
        
        AccessibleListBoxEntry::getAccessibleDescription
        either returns an empty string or also calls
        SvTreeListBox::SearchEntryTextWithHeadTitle, in
        which case the accessible description would be the
        same as the accessible name (unless an a11y name
        was explicitly set).
        
        Reporting the same string for both, a11y name and
        a11y description doesn't make much sense. Let
        AccessibleListBoxEntry::getAccessibleDescription
        always return an empty string instead.
        
        In case there is a need to set/report an accessible
        description, introducing a new method in the weld API
        to set the a11y description explicitly would likely be the
        better approach, see
        
            Change-Id: I8fcbdddd74d75283469f046ff5b60f111051b021
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:42:05 2025 +0100
        
                a11y: Introduce weld::IconView::set_item_accessible_name
        
        which did the same for the accessible name for icon views.
        (That would also ensure that it works for other implementations,
        not just the VCL one.)
        
        Change-Id: I1026d6a2c3d5a79359fd4b65352491ebe98db092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181638
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [a4422ce3049da23439fb18daebba90da9d8614d8]

        vcl a11y: Move listbox entry a11y desc logic to only caller
        
        Since
        
            Change-Id: I153e91292ec70bb3a6dc4e1d473dc0362af55c79
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 16:43:03 2025 +0100
        
                vcl a11y: No longer report IconView item tooltip as a11y desc
        
        , SvTreeListBox::GetEntryAccessibleDescription is a static
        method used only in AccessibleListBoxEntry::getAccessibleDescription.
        Move the existing logic right into that method instead.
        (Let AccessibleListBoxEntry, the a11y class, be responsible.)
        
        Change-Id: I3faf5fc8643ca4f39b7926b43b251ab9c7f92c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181637
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [8c9a2bc6074e0fdc33895a6085b491beb32a1833]

        vcl a11y: No longer report IconView item tooltip as a11y desc
        
        Now after
        
            Change-Id: I8fcbdddd74d75283469f046ff5b60f111051b021
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:42:05 2025 +0100
        
                a11y: Introduce weld::IconView::set_item_accessible_name
        
        introduced API to explicitly set the a11y name for IconView
        items and commits
        
            Change-Id: I59275d8020d0ebd46256bdc1531849cf5be5a353
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:48:35 2025 +0100
        
                svx a11y: Set accessible name for Fontwork Gallery items
        
            Change-Id: Ie54f41014822ec92576f30c72f569a8d186151c6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 15:00:43 2025 +0100
        
                sd a11y: Set a11y names for items in master page selector
        
            Change-Id: I74d1aa41896b70f6025fdc7e4784a2b6539ec6f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 15:18:10 2025 +0100
        
                math a11y: Set a11y names for items in Elements sidebar deck
        
        implemented setting a11y names for those items which previously
        had no accessible name, but only an accessible description
        based on the tooltip, drop the fallback of using the tooltip
        for the accessible description of tooltip items that was originally
        introduced in
        
                commit 2a28ebeef5ea3e2b01d836a7233d2316b765bf38
                Date:   Wed Jun 1 11:18:26 2022 +0300
        
                    Accessibility for IconView
        
        and which would now result in the same text being used for
        the accessible name and accessible description for the
        above cases when the VCL implementation (SalInstanceIconView) is used.
        (Screenreaders usually still announce only one of them
        if they are the same, but the accessible description is
        no longer needed now.)
        
        See commit message of the above-mentioned
        
            Change-Id: I8fcbdddd74d75283469f046ff5b60f111051b021
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:42:05 2025 +0100
        
                a11y: Introduce weld::IconView::set_item_accessible_name
        
        for more details.
        
        As far as I can see, the UI elements addressed by the
        above commits are the only ones that relied on the
        tooltip getting used, as other dialogs etc. using
        IconView pass a string/text when calling
        weld::IconView::insert etc., and the three ones above
        are the only ones calling weld::IconView::connect_query_tooltip
        to be able to provide a tooltip text this way.
        
        In case I missed anything and this commit results in
        IconView items no longer getting announced somewhere, an
        accessible name should presumably be set for those as well,
        using  weld::IconView::set_item_accessible_name (s. above
        commits for examples).
        
        Change-Id: I153e91292ec70bb3a6dc4e1d473dc0362af55c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181636
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [db146f9856f41dba94477888853918a764a02e7a]

        math a11y: Set a11y names for items in Elements sidebar deck
        
        Similar to how
        
            Change-Id: I59275d8020d0ebd46256bdc1531849cf5be5a353
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:48:35 2025 +0100
        
                svx a11y: Set accessible name for Fontwork Gallery items
        
        did for the Fontwork Gallery, set a11y names for the items
        in Maths "Elements" sidebar deck (e.g. the mathematical operators,...).
        
        Use the text also used for the help text/tooltip (e.g. "+ Sign"),
        s. `QueryTooltipHandler`.
        
        Change-Id: I74d1aa41896b70f6025fdc7e4784a2b6539ec6f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181635
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [6c22b1abff20ff4b07e51119cf158a71ca75c371]

        sd a11y: Set a11y names for items in master page selector
        
        Similar to how
        
            Change-Id: I59275d8020d0ebd46256bdc1531849cf5be5a353
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:48:35 2025 +0100
        
                svx a11y: Set accessible name for Fontwork Gallery items
        
        did for the Fontwork Gallery, set a11y names for the items
        in the IconView in the Impress master page selector
        ("Master Slides" deck in the Impress sidebar).
        
        Use the page name as the a11y name, which also gets used
        for the tooltip, s. `QueryTooltipHdl`.
        
        Change-Id: Ie54f41014822ec92576f30c72f569a8d186151c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181623
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [3c063aecde00fa9746a2822b44f0d9d962bbeefe]

        gtk3 a11y: Don't pass null ref to atk_object_wrapper_ref
        
        XAccessibleComponent::getAccessibleAtPoint can return
        an empty ref if there is no child at the given position
        (e.g. also for any a11y object that doesn't have any children.)
        
        Fixes the following critical warning seen with the gtk3
        VCL plugin when using Accerciser's "Inspect object under mouse"
        feature when the mouse pointer is over one of the items
        in the "Insert" -> "Fontwork" dialog.
        
        Backtrace received with G_DEBUG=fatal-criticals:
        
            ** (soffice:2129541): CRITICAL **: 14:07:18.230: AtkObject *atk_object_wrapper_ref(const uno::Reference<accessibility::XAccessible> &, bool): assertion 'bool(rxAccessible)' failed
        
            Fatal exception: Signal 5
            Stack:
            #0 sal::backtrace_get(unsigned int) at /home/michi/development/git/libreoffice/sal/osl/unx/backtraceapi.cxx:42
            #1 (anonymous namespace)::printStack(int) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:289
            #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:330
            #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:427
            #4 /lib/x86_64-linux-gnu/libc.so.6(+0x3fda0) [0x7f57da649da0]
            #5 g_logv in /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #6 g_log in /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #7 atk_object_wrapper_ref at /home/michi/development/git/libreoffice/vcl/unx/gtk3/a11y/atkwrapper.cxx:936
            #8 component_wrapper_ref_accessible_at_point(_AtkComponent*, int, int, AtkCoordType) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/a11y/atkcomponent.cxx:174
            #9 /lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0(+0x1b57d) [0x7f57c736c57d]
            #10 /lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0(+0x2348d) [0x7f57c737448d]
            #11 /lib/x86_64-linux-gnu/libdbus-1.so.3(+0x29024) [0x7f57da4f6024]
            #12 dbus_connection_dispatch in /lib/x86_64-linux-gnu/libdbus-1.so.3
            #13 /lib/x86_64-linux-gnu/libatspi.so.0(+0x1bb79) [0x7f57c62adb79]
            #14 /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x5ad5f) [0x7f57ccf03d5f]
            #15 /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x5cfd7) [0x7f57ccf05fd7]
            #16 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #17 GtkSalData::Yield(bool, bool) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:405
            #18 GtkInstance::DoYield(bool, bool) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:439
            #19 ImplYield(bool, bool) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #20 Application::Yield() at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:489
            #21 Application::Execute() at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #22 desktop::Desktop::Main() at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1679
            #23 ImplSVMain() at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #24 SVMain() at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #25 soffice_main at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #26 sal_main at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #27 main at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
            #28 __libc_start_call_main at ./csu/../sysdeps/nptl/libc_start_call_main.h:74
            #29 call_init at ./csu/../csu/libc-start.c:128
            #30 _start in ./instdir/program/soffice.bin
        
        Change-Id: I07b3f8a8a1b817fcc666c8477f90b54b5f97fe5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181622
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [73941c857946b4831968886a3e1b048968d78832]

        svx a11y: Set accessible name for Fontwork Gallery items
        
        Use weld API newly introduced in
        
            Change-Id: I8fcbdddd74d75283469f046ff5b60f111051b021
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 13 13:42:05 2025 +0100
        
                a11y: Introduce weld::IconView::set_item_accessible_name
        
        to set the accessible name for items in the "Fontwork Gallery"
        dialog ("Insert" -> "Fontwork" in Writer).
        
        With this in place, Accerciser now shows accessible
        names for them for all 3 weld::IconView variants:
        
        * GtkInstanceIconView (SAL_USE_VCLPLUGIN=gtk3)
        * SalInstanceIconView (SAL_USE_VCLPLUGIN=qt6,
          SAL_VCL_QT_USE_WELDED_WIDGETS *not* set)
        * QtInstanceIconView (SAL_USE_VCLPLUGIN=qt6
          and SAL_VCL_QT_USE_WELDED_WIDGETS=1 set)
        
        Change-Id: I59275d8020d0ebd46256bdc1531849cf5be5a353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181621
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [01241a6b3a5b9fed3d9b28d0b8fb8a9a5c0b5f1e]

        a11y: Introduce weld::IconView::set_item_accessible_name
        
        Introduce a new weld::IconView::set_item_accessible_name
        method that allows to set the accessible name for
        an item in the IconView.
        
        So far, IconView icons don't have any accessible
        name if no text is set in addition to the icon.
        
        There is some logic to use (or fall back to) the tooltip
        text for the accessible *description* in both,
        SalInstanceIconView (introduced in
        
            commit 2a28ebeef5ea3e2b01d836a7233d2316b765bf38
            Author: Mike Kaganski <mike.kaganski@collabora.com>
            Date:   Wed Jun 1 11:18:26 2022 +0300
        
                Accessibility for IconView
        
        ) and GtkInstanceIconView (introduced in
        
            commit ba0e36e607d1c380fd09b6725a4ebcb69ff399de
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Mar 9 11:38:36 2023 +0100
        
                tdf#153657 tdf#140659 gtk3 a11y: Use IconView item tooltip as a11y desc
        
        ), but having a way to directly set the a11y name
        has the following advantages:
        
        * Focusable objects should have an accessible name,
          not just an accessible description (that is meant
          to provide additional information only, and whether
          or not accessible descriptions are announced
          is usually configurable in screen readers).
        
        * The tooltip text may or may not be appropriate as
          the accessible name.
        
        * a11y name/description and tooltip are generally
          conceptually different things in UI toolkits, so
          reflect that in the weld API as well and set
          them explicitly rather than making assumptions
          in the implementations that need to implement the
          weld API using specific toolkits (VCL or third-party).
        
        Therefore, introduce this method to allow explicitly
        setting the accessible name and implement it for all
        3 implementations (SalInstanceIconView, GtkInstanceIconView,
        QtInstanceIconView).
        
        It will be used to set a11y names in upcoming commits.
        (The fallback to use the tooltip for the a11y description
        can be dropped once an accessible name is set everywhere.)
        
        For the VCL implementation (SalInstanceIconView), introduce
        a new SvTreeListEntry::m_sAccesibleName member and prefer
        that in AccessibleListBoxEntry::getAccessibleName if set.
        
        For GtkInstanceIconView, the logic is similar to the one
        in the existing
        GtkInstanceIconView::set_item_accessible_description_from_tooltip
        (which is gtk3-only, i.e. doesn't work for gtk4).
        
        For QtInstanceIconView, set the Qt::AccessibleTextRole [1]
        for the item.
        
        [1] https://doc.qt.io/qt-6/qt.html#ItemDataRole-enum
        
        Change-Id: I8fcbdddd74d75283469f046ff5b60f111051b021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181616
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [b3925c4d1b25cf76836022114a36ade63746f209]

        tdf#130857 qt weld: Implement misc IconView methods
        
        These weld::IconView methods are similar to
        the corresponding weld::TreeView methods
        (except that the weld::IconView only has one dimension),
        so use the same approach as used in QtInstanceTreeView.
        
        Change-Id: I26a5a3190a1d95d61ae01512f13a200e48da068b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181615
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [5ebe96edb9ff876cea64f4974678d685468a350e]

        weld icon view: Pass VirtualDevice by ref instead of pointer
        
        Switch the weld::IconView::set_image param from VirtualDevice*
        to VirtualDevice&. This makes it consistent with the
        corresponding weld::TreeView::set_image variant and avoids
        the need to check for nullptr in the implementations
        (where nullptr was not used as an indicator that any
        previously set image should be cleared).
        
        Change-Id: I61b61acaef871a961465ba15e697267902f42596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181610
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [ee1868536701873dd3a8946c33dce51941b4f6f0]

        tdf#130857 qt weld: Make QtInstanceTreeIter::m_aModelIndex private
        
        Add a getter instead of accessing the member directly
        from outside.
        
        Change-Id: Ia11451b8d838b221ebe5ef9451256de64f3fb803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181609
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [4a25132b4a3199a294302405f2e568c27b699a6c]

        tdf#130857 qt weld: Move QtInstanceTreeIter to own header/source
        
        Move QtInstanceTreeIter from vcl/qt5/QtInstanceTreeView.cxx
        to its own header and source files, so it can be reused
        in QtInstanceIconView in upcoming commits.
        
        Change-Id: If5bc4de8e2f02f859d3f8954e3503a670d5bd060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181608
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [c8f1f72cf5e60540526fa3f8352ff4f3f04611ae]

        tdf#130857 qt weld: Implement QtInstanceTreeView::set_id(int,...)
        
        Change-Id: I6747877b475eedb9ee380edc26a72fb63bfb3eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181546
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff7bd4d2ac03f39f1da8ead9a6474e84d0f7b277]

        tdf#164620: sw_uiwriter3: Add unittest
        
        and fix another edge case it found.
        
        Change-Id: Ia57ae1c9a13279f240b78f90fd05faa2f0da7ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-13  Miklos Vajna  <vmiklos@collabora.com>  [449aca5c02c9a927f44b3c6cae99248903fb492c]

        cool#11064 sw lok: expose if layout pages have invalid content
        
        This is meant to help test writing on the LOK client side, for example
        this allows dispatching a command and once the poll callback of the LOK
        client is invoked, we can now check if the layout is fully done (slower)
        or the poll callback is invoked earlier (faster).
        
        Change-Id: I56ab4e6fe46f07a205a197c5b7aa5bb15b3ef676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181619
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-13  Jonathan Clark  <jonathan@libreoffice.org>  [48ac7439438e2d12e78eea08e7a17e6dd1877c80]

        tdf#149089 sw: DOC/DOCX portions should not be snapped to char grid
        
        The Writer and Word text grid implementations differ significantly.
        Writer tries to align characters to grid cells for attractive
        typesetting. Word, on the other hand, adds extra space to each character
        based solely on the grid metrics, with no effort to align characters to
        the grid. The result looks odd, but emulating it is necessary in order
        to display most CJK Word documents (or non-CJK documents translated
        from CJK languages).
        
        Part of this mismatch was already addressed by tdf#161145.
        
        This change builds upon the previous work by updating Writer to no
        longer insert extra kerning portions when the MS_WORD_COMP_GRID_METRICS
        compatibility flag is set. Writer normally needs these portions in order
        to align the starts of successive portions to the grid. However, Word
        doesn't do this. This mismatch was causing layout issues manifesting as
        excessive indentation or whitespace inserted into text where none is
        expected.
        
        Change-Id: I3adf9001bdb49a69bdf760919d6f8810eac565d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181617
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-02-13  Miklos Vajna  <vmiklos@collabora.com>  [6007fbef5c2e4a0b80a4c0031ff36117aa41e63f]

        Update pdfium to 7012
        
        Windows has to switch to clang-cl, see
        <https://groups.google.com/g/pdfium/c/d7KZi_wePHs/m/7eZyhYhVDAAJ> "Does
        anyone still use MSVC?", similar to what skia does already.
        
        This also allows reverting the CppunitTest_vcl_pdfexport and
        CppunitTest_vcl_pdfexport2 test tweaks from commit
        59c5a7d5c7502770896491a59c73de3c627afcc5 (Update pdfium to 6764,
        2024-10-14).
        
        Change-Id: I14052c74c551c4412a13a77eac6284455365d888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181544
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-13  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [8acd6b515e087ce60d3ddefec162a208951fe082]

        tdf#165061 CairoSDPR: regression: Fix RTL usage
        
        See comments in task, for now disable using SDPR when RTL is
        enabled.
        
        Change-Id: I9dabe2324fb9e6b190ebb3851dc73b2c7dacf84d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181604
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-02-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fd9c6cb835f6ee9bf22acf7da6ab13e4837b6264]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c038335c3030c14e0170c088578d156d1a7246c9
          - Fix links in text.
            
            Change-Id: I91f2ebc10d51a4142864610086d85c7f715b21fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181614
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4dd0f15fa0a45c3f4cbb7caeb882d0e93338cdbb]

        Fix typo
        
        Change-Id: I469c85a564707cf50e5730bcac345d1879694919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181612
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a383d7afa4e82bea728ecddf1bc44bbd9fd0eddb]

        Setting zoom must also reset offsets in LOK cached view
        
        The problem was, that having a spreadsheet with objects,
        e.g. rectangles, drawn e.g. over M15:O31, and zooming
        the spreadsheet in Online, the object was painted with
        substantial offset from the actual placement (it could
        be three rows below, and some millimeters to the right).
        
        The problem was, that respective ViewObjectContact did
        not reset its maGridOffset upon changing zoom, because
        it belonged to a view cached in ScGridWindow.
        
        It is different from what GetSdrPageView will return in
        ScDrawView::resetGridOffsetsForAllSdrPageViews; we need
        to handle that in ScModelObj::setClientZoom, or zooming
        in Calc would paint drawing objects in wrong positions.
        
        The sizes of the objects are still painted incorrectly.
        
        Change-Id: Ie2f90568f0570bc0492b614a5fa9128c3e5e9a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181611
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [22c07826d77adf93ada6e17ed6ac531163dd5059]

        tdf#165228 Don't reuse previous path in save dialog
        
        Change-Id: I8abd005eac663a2d7be1952e0e91acd3cc3ae2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181547
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-13  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [49407a8723574f93cf07b807fa536b254da5db61]

        Add missing a11y information for toolitem
        
        - Pass `aria` label and description for `ToolItem` in Sidebar cell appearance.
        - Enhance accessibility with `aria` attributes for better screen reader support.
        
        Change-Id: Iec434aee339db3a73b70a0baec33aad5599412e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179324
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 9d98c8133e008ea0b960a0eb51e0503b1fba02de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179601
        Tested-by: Jenkins

2025-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15c9610d682b295516989f728b142de240a606d1]

        Fix typo
        
        Change-Id: I315c6b4b596b7f6ba3d93cd780d9f371d46be6f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181523
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [682c500074385abc12128ee55677eee83c830d27]

        Revert "the data provider feature is not ready for production"
        
        This reverts commit 24939a5b43b9fe889c3aace027c668666ff61987.
        
        Reason for revert: Data Provider has been availble since 2021
        
        Change-Id: I17de68711ec741349ffe64e9295a3bf4a641d9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181452
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-02-13  Adam Seskunas  <adamseskunas@gmail.com>  [c48ebfd863f53fd58eb83b086d32d8db3fffabe4]

        Change the unparseable query to parse ODBC escape query
        
        dbaccess/qa/connectivity/tools/CRMDatabase.java - remove unparseable query
        dbaccess/qa/unit/dbtest_base.cxx - Add the ODBC escape query
        dbacces/qa/unit/CRMDatabase_test.cxx - Add test
        
        The unparseable query has been commented out for a number of
        years in the CRMDatabase.java. At some point, this query has become
        parseable so this commit removes the old commented out Java query,
        moves the it to C++ and adds a CPPUNIT test for the queries parseability.
        
        Change-Id: Ie4d700458bc6dfd52cd87aec75ec202dd12248ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181142
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [39fcf245d65103caf0844bc7ebee688ec6c7dc75]

        tdf#130857 qt weld: Implement QtInstanceTreeView::scroll_to_row
        
        Change-Id: I0d140aff5c203d90718c3c890e4424b217469e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181518
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [37180baf408aa527e481b7f1a3e37142ed2074f8]

        tdf#130857 qt weld: Implement remaining QtInstanceTreeView::set_image
        
        ... variants.
        
        Change-Id: I8e01ea5ac78d66732c7b437d8632c76c99b67777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181517
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [78953a77d532bb0e197334fe94b6e7622b05d814]

        tdf#130857 qt weld: Implement QtInstanceTreeView::set_image(int,...)
        
        Reuse the implementation for the variant taking a
        `const weld::TreeIter&` and forward the latter.
        
        Change-Id: I96e4e1c293daa2fc1a6030b0dd31830777a349c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181516
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [f25a1d52e0086bf5019c0cd24df49753d7297ba4]

        tdf#130857 qt weld: Simplify QtInstanceTreeView::get_id
        
        Drop the extra helper method that takes a QModelIndex
        and let the variant that takes a weld::TreeIter& param
        forward to the one that takes an int for the row index
        instead.
        
        This aligns it with the approach described in previous
        commit
        
            Change-Id: I9cb958bedce1b8926a10bc42dad032cc5f689989
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 12 22:11:40 2025 +0100
        
                tdf#130857 qt weld: Unify/deduplicate the 2 QtInstanceTreeview::set_text
        
        Change-Id: I23c41c56bbc175d86ad483402fb904ac744bba0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181515
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [17967a3124524aebff28e60027214def5fcada88]

        tdf#130857 qt weld: Unify/deduplicate the 2 QtInstanceTreeview::set_text
        
        Instead of duplicating the logic twice (once for the variant
        that takes an `int nRow` param, and once for the variant
        that takes a `const weld::TreeIter& rIter` param):
        
        * Add helper method QtInstanceTreeView::rowIndex
          that returns the row index for a weld::TreeIter
        * Use that in the QtInstanceTreeview::set_text
          variant that takes the weld::TreeIter& param
          to convert that to the row index and forward
          the call to the variant that takes the row index
        * Align the variant that takes the row index param
          with the previous implementation in the variant
          taking a weld::TreeIter&, as that one looks a
          little nicer.
        
        The idea is to use the same approach for other methods
        as well where such 2 variants exist.
        
        Change-Id: I9cb958bedce1b8926a10bc42dad032cc5f689989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181514
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [8f071b7b20697ff0167de7706e45f0b57a6b67ae]

        tdf#130857 qt weld: Implement some treeview methods to set data
        
        Extend the QtInstanceTreeView::modelIndex helper methods
        to also take a column index (default: 0).
        
        Implement the QtInstanceTreeView::set_text,
        QtInstanceTreeView::set_id and QtInstanceTreeView::set_image
        variants that were seen used in a WIP branch to support
        the "File" -> "Templates" -> "Manage Templates" dialog
        in Writer.
        (More is needed to actually support that dialog.)
        
        ListView::AppendItem/ListView::AppendRow (in
        sfx2/source/control/listview.cxx) calls
        weld::TreeView::set_image with an empty image/icon
        name, so return early if that happens.
        
        Change-Id: I53c2b096220b53e23e81f8979638696ed592addd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181512
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [b3ba248a58edef45412a6369b68c64582cf01316]

        tdf#130857 qt weld: Set icon view icon size to max icon used
        
        When adding an item with an icon, adjust both icon size
        dimensions to be at least as large as the icon is, as otherwise
        the icon is downscaled.
        
        This addresses the
        
        > Currently, the icons in the dialog are very small.
        
        aspect mentioned for the "Insert" -> "Fontwork" dialog
        in previous commit
        
            Change-Id: Idbc6ba8c67becafa294e49b638e541add1b5bc21
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 12 20:15:49 2025 +0100
        
                tdf#130857 qt weld: Support "Fontwork Gallery" dialog
        
        Change-Id: I94daac01b50846ea2743905c795c9266b9706d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181510
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [59b624b75d44e6db5194be7f79ff539796a5d5f4]

        tdf#130857 qt weld: Support "Fontwork Gallery" dialog
        
        Declare support for the "Fontwork Gallery" dialog  that can be
        triggered like this:
        
        1) start Writer
        2) "Insert" -> "Fontwork"
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Currently, the icons in the dialog are very small.
        
        Change-Id: Idbc6ba8c67becafa294e49b638e541add1b5bc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181509
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-13  Patrick Luby  <guibmacdev@gmail.com>  [0ede438ded0baedffe92f9efaf02b0826b3b2a25]

        Fix iOS build failure when building with Xcode 16.1 on macOS Sequoia
        
        Change-Id: I21c0ff32298bdc1309b2d0dd6152e1f5f43746e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176485
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        (cherry picked from commit c6a45e78fbbab54a05a0cc89e907d5a3cba87e5d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181500
        Tested-by: Jenkins

2025-02-13  Gökay Şatır  <gokaysatir@collabora.com>  [1cbed7b598c39bd715ad98b12f78f67312841909]

        Online Calc: Update view pos after setting the client zoom.
        
        Issue: If user zooms in/out while editing is active, the edited area is misplaced and tiles are rendering wrong.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ib9ec8237da52363bffcf586b85a1bd041785c693
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179857
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181481
        Tested-by: Jenkins

2025-02-13  Gökay Şatır  <gokaysatir@collabora.com>  [d7d05bb3136ac60fc1cb1410f15fdbc856c14d90]

        cool#10967: LOK Impress: Invalidate tiles on switching the view mode.
        
        Issue:
        * Select second slide (some slide other than the first one).
        * Switch to notes view.
        * Switch back to normal view.
        * Edit textbox content.
        * Switch to notes view again.
        * Notice that the preview in notes view is not updated.
        
        Reason:
        * Invalidate tiles callback is called before the view is connected.
        
        Solution:
        * Call invalidation on connection.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I997c603e11024743420ced659c7d0b0f1c5bc937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180022
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181480
        Tested-by: Jenkins

2025-02-13  Ismael Olea  <ismael@olea.org>  [4fc77c8b6d129d4096aca10234d724fc89b5b8ee]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 762abe74008b94b2ff06db6f4024b59a8254c467
          - Updating RLA-ES Spanish spellcheker to v2.9.
            
            Change-Id: I68e6c54a9dab27ade9015fe5084d8b2b1b1e1191
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/181076
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-02-13  Skyler Grey  <skyler.grey@collabora.com>  [6f8516d055a2c9d995b24729d64ea8f2adfdacb2]

        fix(wordcount): Add docComments on mobile
        
        In I29ca811065cce83f9c8630f79a2b78c2c3fe0da1, we added a widget for
        docComments to the word counter UI. Unfortunately, we didn't properly
        handle the mobile case, leading to mobile crashing over it missing the
        label to display the result whenever the word count dialog was opened.
        
        Change-Id: Ib94c8db5beb88d0b71035081680ce25a74774d08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176945
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit a9f87065f2725a467d60b49fff6a1b21a14aa0f7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181502
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-02-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1be7c7a3f200cab41cb718399e39e7e13e45aa2e]

        tdf#165119 Also fix # of param for VSTACK, HSTACK
        
        + based on https://gerrit.libreoffice.org/c/core/+/181439
        
        Change-Id: I86c7e534bda881d84b47e81c9f36fd1cafbf59d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181506
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0ab7917fb7f6cd1c24e198d0a7ed68685c833c29]

        update credits
        
        Change-Id: I7f35e212bb8aaf33ddb25fd76aa9c0f2ec375177

2025-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7fa9691dc204cef02b14141697f1a68330dcdf30]

        tdf#165149 fix installing Visual Studio C++ runtime dlls/merge modules
        
        regression from 1cabb20fad8303d16e25957ee245970f37ad2f82
        previously the code had the foreach loop only for the cygwin case, but
        it was added in a way that looked more like a leftover/temporary
        addition to add more fine-grained logging that was left in the code on
        accident rather than intentionally (indents weren't adjusted for
        example) in a commit that talked about adding support for filesystems
        without short names (fac37861914f255c55a196a154575a0d7e143ac8) and the
        code before that one also passed all the tables at once – but it
        turns out that there actually is a functional difference.
        
        Description for msidb's -i option reads:
        "Import text archive files from folder into database. Table names for
        import are file names 8 characters long with an ".idt" extension. Longer
        names are truncated to 8 characters if supplied by command for import.
        Standard wild card specifications may be used."
        
        Maybe that truncation mechansism doesn't work as expected when
        specifying more than one table… Instead of messing around with that
        however: Play it safe and use the method that was used for the last
        14 years
        
        Change-Id: If1bdc1f01f4ccdee13277267f5407046cba4ca03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181511
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-02-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bd136f5d3bb916be912d5dcee1be6c9fe669e348]

        Update git submodules
        
        * Update translations from branch 'master'
          to 98dc659a27b2348cfcf54ba2b91365b92f700525
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I9ff34aacd293205785f776e3a898d2cfa5b5c0f6
            
2025-02-12  Jonathan Clark  <jonathan@libreoffice.org>  [d48e3e1df55120fc0102ff07f1b637933fc91c87]

        tdf#164871 sw: Implemented exact and at-least line spacing for grid
        
        Previously, paragraphs snapped to CJK grid allowed proportional line
        spacing, but did not allow either exact or at-least line spacing. These
        other line spacing types had not been implemented.
        
        Change-Id: I4c07876ab4f9881899bcc2ebb8b64019141bf988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181508
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [25798f072420fd0a3e3111a8f47614edf6d5f5f3]

        math a11y: Drop SmGraphicAccessible::getAccessibleIndexInParent
        
        The base class implementation in
        OCommonAccessibleComponent::getAccessibleIndexInParent
        already implements the same logic.
        
        Change-Id: I47ca934da330c90a68dc0060a68121fe34a5ce01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181504
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [f9cdea4bb53c3c954b9656a94e711276d553bf40]

        math a11y: Use comphelper::OAccessibleComponentHelper
        
        Turn SmGraphicAccessible into a comphelper::OAccessibleComponentHelper
        subclass.
        
        comphelper::OAccessibleComponentHelper already implements
        the logic for event handling and most of the location/bounds handling,
        so avoid reimplementing it.
        
        Move the SmGraphicAccessible::ClearWin logic into
        SmGraphicAccessible::disposing and call
        SmGraphicAccessible::dispose from the SmGraphicWidget
        dtor instead.
        
        Change-Id: I0fa3e6e5a73a8318be730e8165a0e0f149b771ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181503
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [6afcb3da1f7831ef53af014ebf510cc830f03452]

        math a11y: Don't return self in SmGraphicAccessible::getAccessibleAtPoint
        
        As the XAccessibleComponent::getAccessibleAtPoint doc says,
        the purpose of this method is:
        
        > Returns the Accessible child that is rendered under the given point.
        
        Returning a reference to self is incorrect and bad.
        It e.g. triggers an infinite loop when using Accerciser's
        "Inspect object under mouse" feature when the mouse is
        over the formula in Math, because it recursively queries
        for the child at the position until null is returned.
        
        Change-Id: I1aefd6fe69df32bb766351fe068d1c8b151156ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181496
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [8c098f1ba9b070c388affb44a6d37d07e894f39f]

        math a11y: Simplify SmGraphicAccessible::getBounds
        
        `aOutPos` is a default-constructed Point.
        Simply use 0 for x and y coordinate directly instead.
        
        Change-Id: I52d0d3648558c6f0fc0b43b4ab5710952dfe7cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181495
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [d20636b53db08f07af224dc54c61ed93b242000a]

        math a11y: OSL_ENSURE -> assert
        
        Change-Id: If4eaf8f7805289eea8b67df435014bd25db7fb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181494
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [2cc01e22610df1ebee2c1dad8c4339621c83b171]

        sw a11y: Avoid unnecessary casting
        
        Change-Id: Iebfef08d6de9c2e9b0f7bab56e84e6397cfe33db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181493
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [62b8ebe343ec49756fdbfddd0f22cb0b15296747]

        GraphCtrl a11y: Use comphelper::OAccessibleComponentHelper
        
        Turn SvxGraphCtrlAccessibleContext into a comphelper::OAccessibleComponentHelper
        subclass.
        
        comphelper::OAccessibleComponentHelper already implements
        the logic for event handling and most of the location/bounds handling,
        so avoid reimplementing it in SvxGraphCtrlAccessibleContext.
        
        No longer manually call `dispose()` from the SvxGraphCtrlAccessibleContext
        dtor, as the OCommonAccessibleComponent base class dtor already calls
        `ensureDisposed()`. Drop SvxGraphCtrlAccessibleContext::mbDisposed
        and use methods from the base class instead to check whether
        the object has been disposed already.
        
        No change in behavior seen when testing with Accerciser with
        the steps described in previous commit
        
            Change-Id: I876af36f3a583f054da2804151bbe3208e1bbdbf
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 12 12:58:01 2025 +0100
        
                GraphCtrl a11y: Create the accessible object again
        
        Change-Id: Idfa69c97e57598fc8fcc1bf390cf607510d6f53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181487
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [2b773f238be02f1c4f92977349928908454ecd7e]

        GraphCtrl a11y: Create the accessible object again
        
        Since
        
            commit 8a35ae3e6c5c45aa1426cfd81472b309d02a1b48
            Date:   Thu May 16 15:17:38 2019 +0100
        
                weld SvxIMapDlg
        
        , the null check in GraphCtrl::CreateAccessible
        prevented the accessible from getting created at all
        because the method now gets called from the
        SvxIMapDlg::SvxIMapDlg ctor, before the model
        and view are set. Backtrace:
        
            1   GraphCtrl::CreateAccessible                                                                                                                                                  graphctl.cxx          844  0x7ffff27e88bd
            2   weld::CustomWeld::CustomWeld                                                                                                                                                 customweld.cxx        24   0x7fffeeba2276
            3   SvxIMapDlg::SvxIMapDlg                                                                                                                                                       imapdlg.cxx           118  0x7ffff27fd237
            4   std::_Construct<SvxIMapDlg, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                                                                                         stl_construct.h       119  0x7ffff28078c6
            5   std::allocator_traits<std::allocator<void>>::construct<SvxIMapDlg, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                                                  alloc_traits.h        706  0x7ffff28074f5
            6   std::_Sp_counted_ptr_inplace<SvxIMapDlg, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *> shared_ptr_base.h     607  0x7ffff28074f5
            7   std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<SvxIMapDlg, std::allocator<void>, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                   shared_ptr_base.h     970  0x7ffff280727f
            8   std::__shared_ptr<SvxIMapDlg, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<void>, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                       shared_ptr_base.h     1713 0x7ffff28071ac
            9   std::shared_ptr<SvxIMapDlg>::shared_ptr<std::allocator<void>, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                                                       shared_ptr.h          463  0x7ffff280712a
            10  std::make_shared<SvxIMapDlg, SfxBindings *&, SvxIMapDlgChildWindow *, weld::Window *>                                                                                        shared_ptr.h          1007 0x7ffff28037c9
            11  SvxIMapDlgChildWindow::SvxIMapDlgChildWindow                                                                                                                                 imapdlg.cxx           89   0x7ffff27fc8fc
            12  std::make_unique<SvxIMapDlgChildWindow, vcl::Window *&, unsigned short&, SfxBindings *&, SfxChildWinInfo *&>                                                                 unique_ptr.h          1077 0x7ffff280368c
            13  SvxIMapDlgChildWindow::CreateImpl                                                                                                                                            imapdlg.cxx           59   0x7ffff27fc484
            14  SfxChildWindow::CreateChildWindow                                                                                                                                            childwin.cxx          242  0x7ffff3ac434f
            15  SfxWorkWindow::CreateChildWin_Impl                                                                                                                                           workwin.cxx           1350 0x7ffff3b5fdcd
            16  SfxWorkWindow::UpdateChildWindows_Impl                                                                                                                                       workwin.cxx           1299 0x7ffff3b5fb36
            17  SfxWorkWindow::UpdateObjectBars_Impl2                                                                                                                                        workwin.cxx           1247 0x7ffff3b5f175
            18  SfxWorkWindow::UpdateObjectBars_Impl                                                                                                                                         workwin.cxx           1095 0x7ffff3b5e7a1
            19  SfxDispatcher::Update_Impl                                                                                                                                                   dispatch.cxx          1123 0x7ffff3bcad13
            20  SfxBaseController::ConnectSfxFrame_Impl                                                                                                                                      sfxbasecontroller.cxx 1207 0x7ffff42048a1
            ... <More>
        
        Drop the null check (model and view can later be set
        via SvxGraphCtrlAccessibleContext::setModelAndView
        which gets called from GraphCtrl::InitSdrModel).
        
        No longer try to initialize SvxGraphCtrlAccessibleContext::maTreeInfo
        in the ctor, but use a local variable in
        SvxGraphCtrlAccessibleContext::getAccessible (the only place
        where it gets read) instead, because the relevant
        SvxIMapDlg methods cannot be called before its ctor
        (see frame 3 in above backtrace) is done (resulting in a crash).
        
        With this in place, SvxGraphCtrlAccessibleContext now
        gets used again, which can be seen as follows when using
        the qt6 VCL plugin:
        
        1) start Writer
        2) insert an image
        3) select the image
        4) "Tools" -> "ImageMap"
        5) select the accessible object for the pane that shows the
           image in Accerciser's treeview
        
        It now has an accessible name of "Contour control"
        (RID_SVXSTR_GRAPHCTRL_ACC_NAME) again.
        
        Change-Id: I876af36f3a583f054da2804151bbe3208e1bbdbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181486
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [94d95182336b97c36c481f43bb4b780bcee0da89]

        GraphCtrl a11y: Drop SvxGraphCtrlAccessibleContext::mpModel
        
        No need to have a class member, as it is always first assigned
        before being read. Use local variables instead.
        
        Change-Id: I4c3262083f61c5484831ff20860dbf567624b94f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181485
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [bd4be5f4238d756a8ec6c3097d7a0fdf5ce87c8f]

        svx a11y: Drop unused VectorOfStates typedefs
        
        Change-Id: I3d450b894f047766380b85ddb0f6364193b6117a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181484
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [1fa13c73216e52e55684e907f9cb2ec4042c1bd8]

        ruler a11y: Use comphelper::OAccessibleComponentHelper
        
        Turn SvtRulerAccessible into a comphelper::OAccessibleComponentHelper
        subclass.
        
        comphelper::OAccessibleComponentHelper already implements
        the logic for event handling and most of the location/bounds handling,
        so avoid reimplmenting it in SvtRulerAccessible.
        
        Turn SvtRulerAccessible::GetBoundingBox into the
        `implGetBounds` override of the base class and let it return
        an awt::Rectangle.
        
        No change in behavior seen when testing with Accerciser.
        (The class implements a11y e.g. for the ruler above the document
        in Writer.)
        
        Change-Id: I3e1f1dcd7533fb14317428e74b3be1a1e2e57277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181477
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [83bfb947e7640e7ee1fa2998197aaa71d15378db]

        ruler a11y: Guard XAccessible* methods by SolarMutex
        
        Guard implementations of the public XAccessible* methods
        by SolarMutex. No longer use a mutex in the helper methods.
        
        Mostly restrict use of UnoImplBase::m_aMutex to passing it
        to WeakComponentImplHelperBase::throwIfDisposed.
        
        This prepares for an upcoming commit to turn SvtRulerAccessible
        into a comphelper::OAccessibleComponentHelper subclass.
        
        Change-Id: I4ccf7b2cbe3b7be859dc34dac9f2f9b2db705c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181476
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6328993552631970b45b5b2eefce50ced55df22f]

        Filter kit xcu to an allowed subset of options
        
        Change-Id: I577de4f4c9ec2207be466fd2c2b1fa2548fe0197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181115
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5c357a4c66990e2ffd4d46d627ee836e7c30fa25]

        Fix plain LOWA build
        
        ...after 364508802571c25ac993e9327c67e2d5c575f668 "Experimental Emscripten Qt6
        --enable-emscripten-proxy-to-pthread ersatz" made it fail with
        
        > em++: error: undefined exported symbol: "__ZN10emscripten8internal13MethodInvokerINS0_3rvp11default_tagEMN7qstdweb13EventListenerEFvNS_3valEEvPS5_JS6_EE6invokeERKS8_S9_PNS_7_EM_VALE" [-Wundefined] [-Werror]
        
        when linking Executable_soffice_bin
        
        Change-Id: Ia8089e0b7f6330b42ffcdeba80cc8636bf1ea314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181492
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [d10117c9feb6b5c31370b9b474fea7569b98e9cb]

        IASS: Use correct OutlinerParaObject in text decompositions
        
        In SdrTextObj the methods impDecomposeAutoFitTextPrimitive and
        impDecomposeChainedTextPrimitive used the wrong
        OutlinerParaObject. Unfortunately there are two OPOs available
        in the SdrTextPrimitive2D, one by using
            (A) getOutlinerParaObject()
        and one using
            (B) getSdrText()->GetOutlinerParaObject()
        whereby (A) is the one which contains possible changes from
        an active text edit while (B) contains the original text at
        the start of the possible text edit.
        By using (B) those two decomposes were not able to show
        the already changed text, thus the update in the SlideShow
        seemed not to work.
        
        Change-Id: Id2dcc3924fe8029688d0e76ca0f3f7300f461bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181490
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-02-12  Simon Chenery  <simon_chenery@yahoo.com>  [37481972038dddffcfda9cb5b86d75cac85a3b27]

        tdf#145614 Convert #define ZOOM_PARAMS to constexpr
        
        Change-Id: I17bf502166cc8de3372676711119b360326cc40d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181319
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-12  asif196  <asifmohaideen123.dev@gmail.com>  [314021ed594a67a08b410632fc775c4e8dd91f70]

        tdf#145538 used range loop in textbreakuphelper.cxx
        
        Change-Id: I529dfdee60055cb27af2ef6ba3ae50694ac191e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180554
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-12  Gülşah Köse  <gulsah.kose@collabora.com>  [218948f488f75a92199244a740ccb5af3f8f33a7]

        ONLINE: Check cursor position changes more safely
        
        Prevent cursor invalidation if the cursor position doesn't change.
        It prevents to flickering hyperlink popup while other users are typing.
        
        Fixes the regression caused by a260cc52b2fae1382805b4389c95f29ed8671f42
        
        With that patch we can use next and previous page buttons in the status
        bar safely.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I82bfe2355f91d18057d2254a8969fd4994dab4df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180784
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ccaeb27fafbd7ab40a6b811202edd6a65da639fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181471
        Tested-by: Jenkins

2025-02-12  Gülşah Köse  <gulsah.kose@collabora.com>  [e7f05ee2e3c03350e13da607a3e48a822f8baf7e]

        tdf#164141 Fix command button xls to xlsx convert problem.
        
        MSO has two type controls. ActiveX and normal. ControlTypeinMSO
        specifies the form control object is ActiveX or not.
        
        2: ActiveX form control
        1: Normal form control
        
        Current case is simple ActiveX button created by MSO can not be exported by
        LibreOffice properly. It was triggering the repair dialog on MSO. And we
        even lost the button in LibreOffice.
        
        If the pCurrXclObj is failed, we need to give a chance to export button
        by using XclExpTbxControlObj instead of directly XclObjAny
        
        This patch just fixes the Command button xls to xlsx convertion problem.
        Not all the form controls.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Ifabf4d0e16bd620f8201a2143d8af7c64d8859a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180414
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181345
        (cherry picked from commit 7f06e1e26cd3e76c65fcb271563d5741b3a45333)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181472
        Tested-by: Jenkins

2025-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [364508802571c25ac993e9327c67e2d5c575f668]

        Experimental Emscripten Qt6 --enable-emscripten-proxy-to-pthread ersatz
        
        With Qt5, the (enabled by default) --enable-emscripten-proxy-to-pthread (i.e.,
        leveraging Emscripten's -sPROXY_TO_PTHREAD) works reasonably well with the
        handful of hacks we added to our Qt5 5.15.2+wasm branch.  However, for Qt6 any
        necessary hacking there would need to be excessive and looks unrealistic (see
        the mailing list thread starting at
        <https://lists.qt-project.org/pipermail/development/2024-December/045960.html>
        "[Development] Wasm: Support for Emscripten PROXY_TO_PTHREAD?" and the
        presentation at
        <https://fosdem.org/2025/schedule/event/fosdem-2025-5169-lowa-in-need-of-a-vcl-plug/>).
        
        But when leveraging the upcoming browser support for JSPI (through Emscripten's
        -sJSPI, Qt6's -feature-wasm-jspi, and our --enable-emscripten-jspi), it looks
        feasible to leave the Qt6 code alone and instead of proxying the complete
        application main thread (including the Qt6 event handling) off the browser main
        thread to an additional thread (automatically set up through Emscripten
        -sPROXY_TO_PTHREAD), to just proxy some of the LO event handling off the browser
        main thread to an additional thread (set up through a new
        comphelper::emscriptenthreading::setUp).  That way, problematic LO code that is
        triggered from event handling (like "Tools - Extensions..." wanting to spawn
        additional threads, which requires the browser main thread to be unblocked) can
        be offloaded to the additional thread and get the browser main thread unblocked.
        
        Thus there is a new "Emscripten Qt6 JSPI/non-PROXY_TO_PTHREAD" mode now (via
        --enable-qt6 --enable-emscripten-jspi --disable-emscripten-proxy-to-pthread).
        It is still experimental and known to occasionally hang and crash, but has been
        seen to generally work at least with recent emsdk 4.0.3 and a recent Qt dev
        branch (towards Qt 6.10, built with -feature-wasm-jspi) and running on recent
        Chrome 132 with "Experimental WebAssembly JavaScript Promise Integration (JSPI)"
        enabled under <chrome://flags>.
        
        There are two places where code is proxied off the browser main thread to the
        additional thread:  One is QtInstance::ProcessEvent, the other is invoking
        certain kinds of tasks (just "vcl::Dialog maLayoutIdle", for now) in
        Scheduler::CallbackTaskScheduling (unconditionally proxying off all kinds of
        tasks there appeared to cause more issues than it would solve).  For the latter,
        the concept of "transferability" has been added to class Task; the new
        Emscripten mode is the only case making use of that concept.
        
        Also for the latter, it is important that the browser main thread does not get
        blocked at the
        
        >     SolarMutexGuard aGuard;
        
        in QtTimer::timeoutActivated when such a timer event happens while the
        additional thread has the SolarMutex locked and tries to do something that
        requires the browser main thread to not be blocked (like spawning additional
        threads upon "Tools - Extensions...").  Therefore, as a bad hack, and only for
        the new Emscripen mode, that SolarMutexGuard has been moved from
        QtTimer::timeoutActivated down to the call of pTask->Invoke() in
        Scheduler::CallbackTaskScheduling (see the two TODO comments added to the code).
        This appears to work relatively well, but is still a bad hack that should rather
        be done properly.
        
        And then there's some code across vcl/qt5 that may now end up running proxied
        off the browser main thread, but which actually requires to be run on the
        browser main thread (because, e.g., it calls into Qt6 code that accesses JS
        entities that are only available there).  Those places use a newly introduced
        QtInstance::EmscriptenLightweightRunInMainThread that takes some code via a
        lambda:  For the new Emscripten mode, the code is explicitly proxied back to the
        browser main thread, while in all other cases it is run directly in place.
        
        Some further notes:
        
        * -sPTHREAD_POOL_SIZE needed to be bumped by one, to accommodate for the
          additional new thread.
        
        * The code requires two additional JSPI "entry points",
          _emscripten_check_mailbox (to complement the suspension in
          QtInstance::ProcessEvent) and the invocation of the Qt6-internal
          qstdweb::EventListener::handleEvent (to complement a Qt6-internal suspension
          point hit when e.g. doing "Tools - Extension Manager..." and clicking "Add").
        
        * The new Emscripten mode requires -fexperimental-library (for std::jthread and
          std::stop_token) when building at least with emsdk 4.0.3, but it shouldn't
          hurt to have that switch enabled unconditionally for Emscripten builds (which
          are self-contained, so can't be hit by any compatibility issues that switch
          might cause).
        
        Change-Id: Id3b13e2cc3c304b072f388c6d736e7e663b36c58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181424
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [af7e4a555f3e755a08a2e73fae1217886d982f71]

        loplugin:unusedmethods
        
        Change-Id: If02eaf59ebc74001e82b70430bc32ef2edcb6d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181470
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-12  Jean-Pierre Ledure  <jp@ledure.be>  [ff298dfebcd5a6772de53d075e960bddcd4aff46]

        ScriptForge (SF_Services) fix tdf#165147 do not require JRE
        
        When a user script invokes CreateScriptService()
        for a not yet used library, ScriptForge loads
        the library and searches for the list of
        services provided by that library.
        
        The list can be found in a specific method
        that the library must contain,
          RegisterScriptServices()
        in whatever module.
        
        The exploration was done so far through a
        ScriptProvider UNO service. This service includes
        all programming languages, including Java,
        even without Java being used. This caused
        an inconvenient error message when Java
        is disabled in the advanced options.
        
        This service is now replaced by a
          com.sun.star.comp.scripting.ScriptProviderForBasic
        service. This gives a direct access to a lower
        branch of the scripts tree and skips the Java issue.
        
        All the changes are done in the
          ScriptForge.SF_Services._FindModuleFrom Method()
        function.
        
        No change required in the user documentation.
        
        Change-Id: I4a6820e5d1a379bf5b61c6077db8a9a382c1757d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181445
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8976d09cdf0411472765f5faecc6335d9ea8fd9a]

        update mergeclasses
        
        Change-Id: I1cf3a1487ffdf9e344248854109eec70dda6336b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181468
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [02971a09db764b255f89d1f632b576d7ca052fad]

        unused "lock_" field in Components::WriteThread
        
        ever since
        
            commit a0ffaeeff972710a4172e7b4ee72610ad858c4df
            Author: Stephan Bergmann <stephan.bergmann@allotropia.de>
            Date:   Mon Feb 10 14:38:33 2025 +0100
            Shrink critical section into writeModFile
        
        Change-Id: Iaa7e34182dffe485addc5b221953c938675375d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181469
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-12  Aron Budea  <aron.budea@collabora.com>  [cde91f936d8b569278f63205e942ea3ded5907b3]

        tdf#165181 Don't overwrite guessed media MIME type with default on load
        
        MIME types for media can be the default one,
        'application/vnd.sun.star.media'.
        In ODFs coming from old versions, for media unsupported
        at the time, this default MIME type was used, and is read
        when opening them in new versions.
        
        MIME type is also guessed more accurately from the URI
        (file name and extension), but was overwritten by the saved
        MIME type. When using the UI, it is again overwritten by
        the guessed MIME type, but not when using '--convert-to'.
        
        This can cause a problem when saving ODPs to PPTX, PP will
        consider these files corrupted.
        
        Started happening after bc72514f90d90e1ab3fed8167663e835edf03508.
        
        Change-Id: Icd95b06d54154f3b533840f8a5f381400f2e6108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181399
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9bfee82eb1c6e9e2effefda5013e256c4c30e658]

        simplify WinSalGraphics::setPalette
        
        only called from one place, so inline it and remove dead code
        
        Change-Id: Iffc0f7eb2464f78a109355d94031e82da00a4afd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181466
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [f0e8ca29657b8254266a6c90e31f317395110909]

        a11y: Update param name in XAccessibleRelationSet doc
        
        The param was renamed from `aRelationType` to `eRelationType` in
        
            commit 92a36bbd4f3e9ad5d2741f55fe4ac7f03f7e2531
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 6 18:54:12 2024 +0100
        
                [API CHANGE] a11y: Switch AccessibleRelationType to enum
        
        Update in the doc as well.
        
        Thanks to Mike Kaganski for noting it in [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/176153/comment/04f93ca5_6498e8e0/
        
        Change-Id: I8dd6e2b9e9105d7d876a722c2610fac998a6923d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181464
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [95aaa121a5705a029f147a92d5818469c161ce92]

        list item a11y: Use comphelper::OAccessibleComponentHelper
        
        Let VCLXAccessibleListItem subclass
        comphelper::OAccessibleComponentHelper which already
        implements the logic for event handling and most of the
        location/bounds handling, instead of duplicating the
        logic here.
        
        The existing VCLXAccessibleListItem::implGetBounds
        basically already implements the logic needed to override
        the purely virtual
        comphelper::OAccessibleComponentHelper::implGetBounds,
        only the required conversion from tools::Rectangle to awt::Rectangle
        is still added in this commit.
        
        Tested as described in more detail in previous commit
        
            Change-Id: I53c686276537713fec604eb22d19be2331ce1f56
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 11 15:13:41 2025 +0100
        
                list item a11y: Fix parent-relative position
        
        with no change in behavior noticed (now that the issues
        detected previously have been addressed in previous
        commits already in preparation for this commit).
        
        Change-Id: I74e53e3297948977bed1b8608468dc8378859426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181433
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [f315c44bbf1cf8002302f1f760befbb0aa031b22]

        list item a11y: Fix parent-relative position
        
        XAccessibleComponent::getLocation etc. are supposed
        to return the objects position relative to its direct
        accessible parent.
        
        However, IComboListBoxHelper::GetBoundingRectangle used by the
        VCLXAccessibleListItem::implGetBounds helper method returns
        the position relative to the ComboBox or ListBox for which the
        a11y implementation is , which is a VCLXAccessibleBox subclass,
        and that is actually the VCLXAccessibleListItem's accessible
        "grandparent" (parent's parent), as the direct parent is a
        VCLXAccessibleList.
        Therefore, the parent-relative position was incorrect.
        
        Fix that by subtracting the parent's relative position
        within the ListBox/ComboBox.
        
        VCLXAccessibleListItem::getLocationOnScreen, which returns
        the absolute screen position, was correct, because it
        added the combobox/listbox position to the "parent-relative"
        position (which was actually the position relative to the
        combobox/listbox).
        Now that VCLXAccessibleListItem::implGetBounds returns the
        position relative to the actual parent, also adjust
        VCLXAccessibleListItem::getLocationOnScreen to add the
        actual parent's location on screen.
        
        The issue about incorrect parent-relative positions
        was noticed with an (upcoming) change that refactors
        VCLXAccessibleListItem to subclass comphelper::OAccessibleComponentHelper
        where the parent-relative position gets used.
        
        Issue could also be reproduced like this:
        
        1) apply only the VCLXAccessibleListItem::getLocationOnScreen
           part of this change
        
        2) run Python script attachment 199141 from tdf#161087 on X11/XWayland
           which highlights the area of the currently focused object:
        
            GDK_BACKEND=x11 python3 ./highlight-focused-object.py
        
        3) start LO with the qt6 VCL plugin on X11/XWayland:
        
            QT_QPA_PLATFORM=xcb SAL_USE_VCLPLUGIN=qt6 ./instdir/program/soffice.bin --writer
        
        4) Navigate to the "Styles" combobox in the formatting toolbar
        
        5) Press Alt+Down to expand, then arrow keys to navigate through
           the combobox entries
        
        (Note: Running Orca in addition can help to trigger creation of the
        the required a11y objects and events.)
        
        Without this change in place, the wrong area was highlighted
        when moving between entries. Now, the correct area of the currently
        focused combobox entry is highlighted.
        
        Change-Id: I53c686276537713fec604eb22d19be2331ce1f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181432
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [59640987b0e45b6b58ca48dda0ac036ba47e42ca]

        list a11y: Fix parent-relative position
        
        So far, VCLXAccessibleList::implGetBounds
        (which is supposed to report the bounds relative
        to the direct parent) and VCLXAccessibleList::getLocationOnScreen
        (which is supposed to report the absolte screen position)
        were mostly duplicating the logic.
        
        VCLXAccessibleList::getLocationOnScreen seems correct,
        but VCLXAccessibleList::implGetBounds reported an
        incorrect position for an expanded combobox list.
        
        This is because VCLListBoxHelper::GetDropDownPosSizePixel
        was returning a screen position, not a position relative
        to the parent.
        
        Fix this by:
        
        * Making VCLListBoxHelper::GetDropDownPosSizePixel return
          a parent-relative position instead.
        * Adjusting VCLXAccessibleList::getLocationOnScreen to
          not duplicate most of the logic, but calling
          VCLXAccessibleList::implGetBounds to get the
          parent-relative position and then adding the
          parent's screen position to get the own screen
          position.
        
        The fact that the parent-relative position is incorrect
        was noticed while working on fixing the parent-relative
        position reported by VCLXAccessibleListItem and even
        with an issue in the implementation there, the incorrect
        position was still reported.
        (The VCLXAccessibleListItem will be done in a separate
        upcoming commit.)
        
        Change-Id: I322327753ceec7bc7912ec13c45e208a79dd6976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181431
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [7bcd976db8b29b86b49bdb4c33d07ef156f1fa8f]

        list a11y: Use ref to concrete VCLXAccessibleBox
        
        This will come in handy when simplifying and fixing
        VCLXAccessibleList::implGetBounds and
        VCLXAccessibleList::getLocationOnScreen in
        upcoming commits.
        
        Change-Id: I8b969243d9731ab997cc1a02c187491dbf171952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181430
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [5be1a099570d26df816327ce7a2f91d05118aba4]

        list item a11y: Deduplicate bounds calculation
        
        Introduce and use new helper method
        VCLXAccessibleListItem::implGetBounds
        instead of duplicating the code to calculate
        the parent-relative bounds in multiple places.
        
        This is also in preparation of fixing parent-relative
        coordinates (in a single rather than multiple places).
        
        Change-Id: Ie2791a73a392ed1c0d6872d2131cc59785c214b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181429
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [f1fdedb2f5d1ab108678c07cdce2a5d692ff1760]

        listbox a11y: Consistently lock (only) SolarMutex
        
        So far, some of the public XAccessible* method implementations
        were locking only the SolarMutex, some were locking only
        `m_aMutex` and some were locking both.
        
        Unify that to always lock only the SolarMutex in
        all of those methods.
        
        Change-Id: Ia6e7655d47a372d4b70d3c7de8715881b9aaddc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181428
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [6af514e29dc14916e8ab63655b0c175928bdfc8c]

        browsebox a11y: Let base class implement XAccessible
        
        By now, all non-abstract subclasses of AccessibleBrowseBoxBase
        implement the XAccessible interface (Either directly or by subclassing
        BrowseBoxAccessibleElement) and their XAccessible::getAccessibleContext
        implementation returns a reference to self.
        
        Deduplicate code by letting AccessibleBrowseBoxBase
        implement the XAccessible interface and dropping the
        implementations from subclasses. Also drop the now unused
        BrowseBoxAccessibleElement class.
        
        Change-Id: I0cef92acc67f176b55c97bc7ab5ae28b69433b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181407
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [b3cd6017f370e5cc2ab4ce4f0537127b2951702b]

        browsebox a11y: Use cppu:ImplInheritanceHelper
        
        Change-Id: Iae300fb7b6472397706f64526c36ce228c1b33ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181406
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-12  Simon Chenery  <simon_chenery@yahoo.com>  [6586dbe9569be562c5be1982d488417fb08b082e]

        tdf#154285 Check too many arguments to SbRtl_Abs() for BASIC ABS function
        
        Change-Id: I82f1df998afca37f5e14baacc9c36339596724ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181447
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-12  sid-sg  <sengupta.sid03@gmail.com>  [b3503b8b33093e4143d0507dc565eb9546d4c14f]

        tdf#143148: Replace include guards with #pragma once in slideshow module
        
        Change-Id: Id48764be9df30bee8d5a803ea78097db9c5c41e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180129
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-02-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5a77b665a40b606ba914f361d4d4271be0a064c6]

        tdf#165196 Help button to Data Provider dialog
        
        + Rename dialog button container (was blank)
        
        Change-Id: I2da0a2896635565fc534bfc9513620e40f72069c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181425
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2025-02-11  Oliver Specht  <oliver.specht@cib.de>  [fe1a74c68b892d01bf5d8be9aed90c12c5bf6abd]

        tdf#164921 Renaming list styles fixed
        
        User defined list styles are now correctly updated in paragraph
        styles that are using them and only directly applied to paragraphs
        that had a direct formating before.
        
        Change-Id: I9b671655ffa430d643c48fc35f15f38b41de4b9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180892
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5204069793c77c2179c059679cae8b69a5b5edaa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35b759e6da136e3d46e3e1d08ef2245c50b1d76d
          - tdf#137419 (part 2) Data Provider Help page
            
            + Refactor, add some bookmark entries, how-to-get ...
            + Page need further work once the feature is properly documented.
            
            Change-Id: I6bfb9fc2c1bef43ee49caef7e5b9d6d5adbd153d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181462
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-11  Simon Chenery  <simon_chenery@yahoo.com>  [b064297cfc660a01a4e788bac331e5765649c121]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0b34aab50fc803bfe100a2b4dbe62a52ae3dccb3
          - tdf#154285 Error code 5 Invalid procedure call possible for NOW()
            
            Change-Id: Ia2b249988f7df784801dc74992127c26f967749d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181376
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-11  Oliver Specht  <oliver.specht@cib.de>  [0e0ae62ded3f72768bc06e38253dacbf5af0ed5a]

        tdf#164266 RTF: border distance in style is not applied to table
        
        Attributes from styles are only valid if they are repeated at the
        location where the style is applied.
        
        Change-Id: I0083b833266346084d51aaf78a162b96012a0dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180835
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe39e60102f34f6dba59828579ee75e4c05486e0]

        openssl: upgrade to 3.0.16
        
        Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.16/openssl-3.0.16.tar.gz
        
        Change-Id: I9eeb10132455be1240cbe7312275d5211dee3600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181442
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [0b0e651f2ffc6ce86fbf6db3f79225403dfbf2cd]

        xmlsec: upgrade to 1.3.7
        
        Downloaded from https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.7.tar.gz
        
        Change-Id: I0f49daab676969ef2bd9452825cd02e2c7aa7037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181444
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [7a2fec66b5f2c527b79db312135e3691bb8b56ac]

        tdf#165119: fix number of parameters in CHOOSECOLS/CHOOSEROWS
        
        Change-Id: I39fee81e0fc8aaa33265a3539bd4e6dff5d9d2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181439
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-11  László Németh  <nemeth@numbertext.org>  [ed7fbfce0b434f7d2a5542483d2838af51958e34]

        tdf#164499 sw smart justify: disable in tabulated lines to fix ToC
        
        Calculated extra text content without shrinking resulted overhanging
        text lines, e.g page numbers over the margin in ToC. Fix it
        by skipping space shrinking completely in tabulated lines,
        restoring also interoperability.
        
        Regression since commit 53de98b29548ded88e0a44c80256fc5e340d551e
        "tdf#158333 sw smart justify: fix multiple text portions".
        
        Change-Id: I390a254b8a47c6563d2c01a2f818f5ac6122e2ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181397
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-02-11  Aron Budea  <aron.budea@collabora.com>  [d4c7b78827c12c4bbc871c3b9eb0ce28271adba4]

        tdf#165180 convert-to: prefer PowerPoint 2007-365, not Office Open XML
        
        I haven't seen it causing an actual issue so far,
        but let's use the correct filter.
        
        Similar rationale as c90c1d4435a64531e1d9b41d0a8dc0b91ba236cd.
        
        Change-Id: I2afd686db6f41b385214c274e47d293ef546b901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181398
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2025-02-11  Miklos Vajna  <vmiklos@collabora.com>  [5300efbbb13c73d7d5d17cd9834f9cb118657915]

        cool#11064 sw lok: allow specifying the visible area during doc load
        
        Large enough documents significantly faster on the desktop than in LOK
        mode for some reason.
        
        Investigating the reason, it turns out that the layout mechanism to
        layout the visible area (first page, typically) of the document as part
        of doc load goes wrong in the LOK case, where nominally the entire
        document is visible.
        
        Fix the problem by adding new "ClientVisibleArea" option to
        lo_documentLoadWithOptions(), so the LOK client can inform us about what
        is the visible area before SwXTextDocument::setClientVisibleArea() can
        be called.
        
        lok::Office::documentLoad() cost for the bugdoc:
        - before: 540 ms
        - after: 112 ms
        
        Change-Id: Ib1df71e768fc42cf92b858a717d7a0e5d51678b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181426
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-11  Oliver Specht  <oliver.specht@cib.de>  [9647aded124c17e97db1bf7bb071136c7f91cb90]

        tdf#164176 Import multiline document variable with break
        
        Converts the '_x000d_' or '_x000d__x000a_' to a paragraph break in docx import.
        
        Change-Id: Ib8b5203338e987028279711928d3aecb9cedd836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177838
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c0685d82238fd3813ffe7d67be3778280f2d47e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07e8db4df115a5662b5e28831cbc7049cd50c217
          - tdf#165141 - Fix Draw - Scale Help page
            
            + Refactor
            + Improve how to get
            + Remove switches.
            
            Change-Id: I3649c9a87170b4d665c1766d211074fa519a8405
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181373
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f647131cb34fabbc206b4b72705d95a5d59884e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 84435ba08d96a46d9ced24ccd37599d2932e8932
          - tdf#137419 (part) Restore Data Provider Help page
            
            + Restore deleted help page
            + Refactor, add some bookmark entries, how-to-get ...
            + Page need further work once the feature is properly documented.
            
            Change-Id: I7984ac16dd355f4df1e63bbbcd928109660b0cd5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181419
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [449b905f78737337eef8daff03a6342f96df845e]

        tdf#165080: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I2352f6c40cf18344a5ac97467ddfe074e9bb4016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181421
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a4dac9f93347aa3321e8efe7c575e87ab418f5e6]

        Fix typo
        
        Change-Id: I34fef02e800fd1ca8d2e00e30c66e9dbea02621c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181410
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2639e2a98f114f053a13da669440587d56a0dd8]

        tdf#165003 Row height wrong at writing direction 90°
        
        regression from
            commit f91a411340ae204ce1e6997f22e0352a4c6a8355
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu May 23 15:09:52 2024 +0200
            reduce cost of calc column height calculation
        
        This also fixes another bug in the above commit where the code did not
        update nValue for the "else if (bBreak && !bWidth)" case
        
        Change-Id: I367a56c2cb555336e1d510efb0c7acac1447525f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [01a214d9596a595570b08d5e9d0c5776f892aa09]

        allow zero or more xcu files to be installed
        
        Change-Id: Ibcca052697c391794b636606cf590549568821be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180782
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit e3b6888f9071011fd69e1d15aa8adb0eae5e658c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181411
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-11  Mike Kaganski  <mike.kaganski@collabora.com>  [ebea5ef578bd919ab10d769d2eb27521d2c15012]

        tdf#165185: consider LOK read-only view in SID_SEARCH_OPTIONS
        
        This reverts commit cae3ed92df74672a886ee706ebb970a763be3712 "disable
        invoking Search and Replace dialog (by Ctrl+H) in read-only documents",
        2025-02-11. Instead, the dialog will disable replacement controls.
        
        Change-Id: Iefef1f636492f60b2bcff07379c2c2dc7bcead79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181408
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [e52899ed08405f67ea755271a2592ed0df516c77]

        lcms2: upgrade to 2.17
        
        * external/lcms2/0001-Added-missing-export.patch.1 has been
        fixed uptream
        * external/lcms2/lcms2-windows_aarch64_outdir.patch.1 has been
        fixed upstream
        
        Downloaded from
        https://sourceforge.net/projects/lcms/files/lcms/2.17/lcms2-2.17.tar.gz/download
        
        Change-Id: Iae97a557f153279582878c8eb94dc2fab75b658d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181340
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-11  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [2ebefc61f48b13456de7b45597e64ca5f4d9f729]

        tdf#164969 fix widget theming/styling in gtk
        
        - when using automatic theme, and when theming is enabled,
          if everything is set to automatic, then the application
          shouldn't have any visual changes.
        
        - use close button color from libadwaita specification, that's
          the closest we can get to the defaults without defining a
          "close button color" variable under theme colors.
        
        - remove  border  from  the notebook  headers,  change  the
          color/style to match the default look without any theming.
        
        Change-Id: Ib0143ccc681b4f0f5863be028a32af32d9631917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181381
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-11  Miklos Vajna  <vmiklos@collabora.com>  [fb8bf5f209e1bd7fd7d8ad555ec66dbf31649ee8]

        svx: prefix members of DialogGalleryPreview
        
        See tdf#94879 for motivation.
        
        Change-Id: I2ddf9dfcd65ae44852fc17d97d634c5382d296b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181400
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-11  Gülşah Köse  <gulsah.kose@collabora.com>  [641fd154649edfb3fe1dad89f833f2e48caf41d7]

        Fix wrong detection of sortCondition reference
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I877ede71f9487ba35efd7da6aeeee954560272cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181344
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-02-11  rafaelhlima  <rafael.palma.lima@gmail.com>  [e2c08c31cf29e53ffc22f18424f108302728cd21]

        tdf#164685 Cleanup SfxItemSetFixed - Part 3
        
        This is the continuation of the cleanup of class SfxItemSetFixed, as described in the bug ticket.
        
        Change-Id: I567f985af181d326a6adb6c3d3af2a9e2fa8df34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180975
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2025-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [089e8d0ae15da9632456bdf0c59a3531a6853dee]

        tdf#164712: sw_odfexport: Add unittest
        
        Change-Id: If81490314f47c88d54140712bee05b609990aa2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181395
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-11  Justin Luth  <justin.luth@collabora.com>  [95b173d41fa7a450821d0e69225df3faa899d290]

        tdf#165040 tdf#143899 compat15 layout: restrict body fly #2
        
        What was happening was that layout was considering
        whether to put the fly on a different page than the anchor,
        and my 25.2 commit 1de6bea27ed36167ec138818607da7b49e92ec4a
        apparently caused layout to accept that location in some cases,
        in which case it wasn't visible at all...
        
        Now, I'm not going to pretend that I actually understand LAYOUT at all,
        but my patch was only intending to affect the image
        in relation to the same page as the anchor is.
        So forcing that as a criteria seems to get me out of hot water.
        
        Since this is just bits-on-a-screen in some random kind of
        I'd-like-to-stick-myself-on-a-different-page layout anomaly
        and I don't have any nice changes-page-count examples,
        I'm not going to try to add a unit test.
        
        Change-Id: I84b980f109016ae6d904fb3720f77e131197b6a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181391
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-02-10  Andras Timar  <andras.timar@collabora.com>  [62551cd0a0b19e1baf19c5a5c81019efb35f0e35]

        disable resetting cell attributes (by Ctrl+M) in read-only spreadsheets
        
        Change-Id: I31dd5db509d06951df6df68ae47b746b5807e15e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181388
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-10  Andras Timar  <andras.timar@collabora.com>  [cae3ed92df74672a886ee706ebb970a763be3712]

        disable invoking Search and Replace dialog (by Ctrl+H) in read-only documents
        
        Change-Id: Ib49d6260ec465070caa6dae6620ea01b5814648e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181387
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2025-02-10  Andras Timar  <andras.timar@collabora.com>  [6b0a4d5c00f22fdb5e75abac1d1b20c8e781b9a3]

        cool#11123 disable .uno:FillDown (invoked by Ctrl+D) in read-only spreadsheets
        
        Change-Id: I252f7ff8ba79795355f8f70f6fea321e7f1bc41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181372
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit f69b62382d112b028ad7d3f12a577dd32fa6e018)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181374
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-10  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7825e7775113864093260175387ccece1e0e25d0]

        Logo on api.libreoffice.org should link to itself
        
        not to libreoffice.org
        
        Change-Id: Ic6c66312720dc1921693015b6d904f5b12d19f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181355
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-10  Noel Grandin  <noelgrandin@gmail.com>  [df2b2526826e44cb215752e4daab1c6cbdfb480b]

        optimise CairoCommon::drawMask
        
        Change-Id: I955718b491f72e4f92170d5894db8688949e06ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [249440f5b7a84f5855301ce71f365679e7ce45a6]

        gpgme: upgrade to 1.24.2
        
        Downloaded from https://gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.2.tar.bz2
        
        Change-Id: I3b75db7258a99cbab1f68151e678d118376b949c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8572635aa5f30d9f24bc55f69db85960e0c578b]

        cut down the amount of GetBaseModel querying
        
        Change-Id: Ib7007a223373232006b8c4261778748b6fe3bf97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181321
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [9ee01d58771b8ea585698094019b1a4dd38e54eb]

        tdf#153131 wina11y: Return error code when child count exceeds max long
        
        When the accessible child count exceeds max long,
        no longer return max long in the IAccessible::get_accChildCount [1]
        implementation in the Windows a11y bridge, but instead return error
        code `S_FALSE` [2]:
        
        > The method succeeded in part. This happens when the method succeeds, but
        > the requested information is not available. For example, Microsoft
        > Active Accessibility returns S_FALSE if you call IAccessible::accHitTest
        > to retrieve a child object at a given point, and the specified point is
        > not within the object or the object's child.
        
        This prevents the problem that Windows Speech Recognition on Windows 10
        (see tdf#153131) and apparently some tools on Windows 11 that query
        information from LO via the accessibility API (see tdf#165131 and
        tickets referenced from there) apparently try to iterate over all
        children from child index 0 to (excluding) the returned index
        unconditionally, which causes a freeze if the returned number is too large.
        
        In practice, this is known to be a problem with Calc sheets, for which
        all cells are currently considered direct children.
        
        A quick test with NVDA and this change in place didn't reveal any
        issues.
        (Independent of this change, using JAWS 2025.2412.50 instantly
        results in a crash somewhere in the AT code that gets run
        in-process, preventing to test what implications this change
        would have there otherwise.)
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-get_accchildcount
        [2] https://learn.microsoft.com/en-us/windows/win32/winauto/return-values
        
        Change-Id: If12dbcbb387a765bec4194d2bfe61bd29aa0f8a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181370
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [c5f3e78f34a31077df6f9f8e3e9093454cdca25f]

        tdf#165080 Background color cells are reset to white
        
        regression from
            commit 2d208c4e42595bb85fd0ef726a89e10dd32b48b1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 25 09:03:49 2024 +0200
            tdf#161210 speed xls load
        
        Change-Id: Ided4df0ce448cf811e7f43bcf601641e2b7c29c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181350
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a0ffaeeff972710a4172e7b4ee72610ad858c4df]

        Shrink critical section into writeModFile
        
        ...from the calling configmgr::Components::WriteThread::execute.  This is
        relevant at least for an upcoming Emscripten Qt6 JSPI/non-PROXY_TO_PTHREAD mode,
        where part of the LO event handling (which would normally take place on the main
        thread) will be offloaded to an additional thread.  There, opening e.g. a fresh
        Writer document shortly after starting LO could have lead to a deadlock:
        
        The configmgrWriter thread had the configmgr::Components mutex locked and tried
        to do a mkdir, which it needs to proxy to the main thread on Emscripten,
        
        > $emscripten_futex_wait (soffice.wasm:0x83dbf64)
        > $__timedwait_cp (soffice.wasm:0x83e7f34)
        > $__pthread_cond_timedwait (soffice.wasm:0x83e8168)
        > $pthread_cond_wait (soffice.wasm:0x83e85a2)
        > $emscripten_proxy_sync_with_ctx (soffice.wasm:0x83e6709)
        > $emscripten_proxy_sync (soffice.wasm:0x83e6a08)
        > $_emscripten_run_on_main_thread_js (soffice.wasm:0x83e6d77)
        > ret.<computed> (soffice.js:8709)
        > (anonymous) (soffice.js:1285)
        > proxyToMainThread (soffice.js:1617)
        > ___syscall_mkdirat (soffice.js:6613)
        > $mkdir (soffice.wasm:0x83e3e0a)
        > $osl::mkdir(rtl::OString const&, unsigned int) (soffice.wasm:0xbce7b3)
        > $create_dir_with_callback(char*, void (*)(void*, _rtl_uString*), void*) (soffice.wasm:0xbdc4d6)
        > $create_dir_recursively_(char*, void (*)(void*, _rtl_uString*), void*) (soffice.wasm:0xbdc422)
        > $osl_createDirectoryPath (soffice.wasm:0xbdc35f)
        > $configmgr::writeModFile(configmgr::Components&, rtl::OUString const&, configmgr::Data const&) (soffice.wasm:0x4218d80)
        > $configmgr::Components::WriteThread::execute() (soffice.wasm:0x41f561d)
        > $non-virtual thunk to salhelper::Thread::run() (soffice.wasm:0xd369fd)
        > $threadFunc (soffice.wasm:0xd36890)
        > $osl_thread_start_Impl(void*) (soffice.wasm:0xbca617)
        
        ...while the main thread was serving a proxied call from the additional "event
        handling offload" thread, during which it accesses configmgr code and tried to
        lock the configmgr::Components mutex,
        
        > $a_cas_p (soffice.wasm:0x83dc0d9)
        > $futex_wait_main_browser_thread (soffice.wasm:0x83dbfed)
        > $emscripten_futex_wait (soffice.wasm:0x83dbf23)
        > $__timedwait_cp (soffice.wasm:0x83e7f34)
        > $__timedwait (soffice.wasm:0x83e7fd2)
        > $__pthread_mutex_timedlock (soffice.wasm:0x83e9323)
        > $__pthread_mutex_lock (soffice.wasm:0x83e9208)
        > $osl_acquireMutex (soffice.wasm:0xbbc750)
        > $configmgr::Access::thisIs(int) (soffice.wasm:0x41dc351)
        > $configmgr::Access::getByName(rtl::OUString const&) (soffice.wasm:0x41e13b3)
        > $non-virtual thunk to configmgr::Access::getByName(rtl::OUString const&) (soffice.wasm:0x41e159a)
        > $comphelper::detail::ConfigurationWrapper::getPropertyValue(std::__2::basic_string_view<char16_t, std::__2::char_traits<char16_t>>) const (soffice.wasm:0xc2f8fe)
        > $comphelper::ConfigurationProperty<officecfg::Office::Common::Misc::ViewerAppMode, bool>::get(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (soffice.wasm:0xdfbc05)
        > $SfxDispatcher::FindServer_(unsigned short, SfxSlotServer&) (soffice.wasm:0xdfb6d4)
        > $SfxDispatcher::GetShellAndSlot_Impl(unsigned short, SfxShell**, SfxSlot const**, bool, bool) (soffice.wasm:0xdfb398)
        > $SfxDispatcher::QueryState(unsigned short, com::sun::star::uno::Any&) (soffice.wasm:0xe01fe3)
        > $SfxDispatchController_Impl::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) (soffice.wasm:0xe1d5bd)
        > $SfxOfficeDispatch::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) (soffice.wasm:0xe1d4ce)
        > $non-virtual thunk to SfxOfficeDispatch::addStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&, com::sun::star::util::URL const&) (soffice.wasm:0xe1daa6)
        > $svt::PopupMenuControllerBase::updateCommand(rtl::OUString const&) (soffice.wasm:0x20cd630)
        > $svt::PopupMenuControllerBase::updatePopupMenu() (soffice.wasm:0x20cd460)
        > $framework::HeaderMenuController::updatePopupMenu() (soffice.wasm:0x29a0323)
        > $svt::PopupMenuControllerBase::setPopupMenu(com::sun::star::uno::Reference<com::sun::star::awt::XPopupMenu> const&) (soffice.wasm:0x20cf1bb)
        > $non-virtual thunk to svt::PopupMenuControllerBase::setPopupMenu(com::sun::star::uno::Reference<com::sun::star::awt::XPopupMenu> const&) (soffice.wasm:0x20cf1e0)
        > $framework::MenuBarManager::CreatePopupMenuController(framework::MenuBarManager::MenuItemHandler*, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&) (soffice.wasm:0x217c209)
        > $framework::MenuBarManager::Activate(Menu*) (soffice.wasm:0x218130b)
        > $framework::MenuBarManager::Activate(Menu*) (soffice.wasm:0x2180b17)
        > $framework::MenuBarManager::LinkStubActivate(void*, Menu*) (soffice.wasm:0x2180126)
        > $Menu::Activate() (soffice.wasm:0x14d68e0)
        > $Menu::HandleMenuActivateEvent(Menu*) const (soffice.wasm:0x14df42c)
        > $QtMenu::DoFullMenuUpdate(Menu*) (soffice.wasm:0x6617932)
        > $QtMenu::SetFrame(SalFrame const*) (soffice.wasm:0x661738a)
        > $std::__2::__function::__func<QtMenu::SetFrame(SalFrame const*)::$_0, std::__2::allocator<QtMenu::SetFrame(SalFrame const*)::$_0>, void ()>::operator()() (soffice.wasm:0x661c275)
        > $QtInstance::EmscriptenProxyToMainThread(std::__2::function<void ()>)::$_0::__invoke(void*) (soffice.wasm:0x65b24e4)
        
        Change-Id: Iee58b86a96147273b7ae288524513e0d174287a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181353
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-10  Patrick Luby  <guibmacdev@gmail.com>  [39f5af68e9cc7691f8f085af08ef6bf9f9172c6b]

        tdf#128186 Enable native full screen mode on macOS
        
        Commit c1452e73091412ba0bb72306329e1912df2ba513 disabled native full
        screen mode on macOS so revert the minimal amount of pieces of that
        commit. In theory, this should reintroduce one or more of the various
        bugs identified in the above commit as well as in tdf#117872.
        
        This approach purposely excludes all of the code that kept the native
        and internal full screen modes in sync. This is because the fix for
        tdf#161623 made native and internal full screen modes exist
        independently of each other. Essentially, native full screen mode is
        sort of treated like a window decoration and the internal full
        screen mode is treated the same as it would if the native window was
        not in full screen mode.
        
        Change-Id: I45110d12648092cfb4d6a26d19dfcf956777f8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170452
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [f26e7468cb3467f969a96bf5cebb8d300dc88973]

        libffi: upgrade to 3.4.7
        
        Downloaded from
        https://github.com/libffi/libffi/releases/download/v3.4.7/libffi-3.4.7.tar.gz
        
        Change-Id: I02f4137ed0cdaab74dc3630928e2567d0e9b3360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181334
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-10  Justin Luth  <justin.luth@collabora.com>  [44eda1f72b4d67b9627155741067d3e57a1f9747]

        tdf#164876 tdf#165117 writerfilter: no dummy paragraphs in header
        
        The problem was that an extra CR was being added
        (often every round-trip) to headers that started with a table.
        
        This is a long-standing bug (see moz1211781-1.docx)
        that got more exposure recently from changes to
        7.6.6 (via 86ad08f9d25110e91e92a0badf6de75e785b3644)
        and 24.8.0 (via ef77086255821d61838a7e26fee9baadaca0b9e0)
        
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf161631
        
        Change-Id: Idb6a0efda246fa064822f01a9ce097f686810b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181307
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-02-10  افشین  <afshin@libreoffice.org>  [e142387ffd70d357c0830a9f07d59e4a5b5135f5]

        tdf#164996 Optimize Persian (Farsi) AutoCorrect list
        
        This patch provides an optimized version of the AutoCorrect list for
        Persian (Farsi) language. The old version was created to resolve
        i#95322, eleven years ago.
        
        In the old file, there were over 6,000 words in the list, nearly 2/3
        of which were unnecessary and essentially did not belong to the
        database. It would be better to move them to spell-checking.
        
        Change-Id: Ibe3a2e07ebecdf4a541a5cfacf6fefa8ade4e300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181004
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [bc518885c17ee392a1d9af5c2c9542e819fe2451]

        vcl: Replace use of MYTABMASK in SvTabListBox::SetTabAlignCenter
        
        Seeing
        
            constexpr SvLBoxTabFlags MYTABMASK =
                SvLBoxTabFlags::ADJUST_RIGHT | SvLBoxTabFlags::ADJUST_LEFT | SvLBoxTabFlags::ADJUST_CENTER | SvLBoxTabFlags::FORCE;
        
        , it is not particularly obvious what the idea behind that
        set of flags is.
        
        Introduce SvLBoxTabFlags::ADJUST_FLAGS for the adjustment
        flags and use that one in SvTabListBox::SetTabAlignCenter instead,
        where the purpose is to clear existing alignment flags before setting
        SvLBoxTabFlags::ADJUST_CENTER.
        
        Explicitly clearing SvLBoxTabFlags::FORCE (as happened
        before) isn't necessary because that flag is explicitly
        set afterwards (so it doesn't make any difference whether
        or not it is cleared first).
        
        Change-Id: Ib26e103185c4a79cae97c8ef38b99a02c66c6368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181339
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [e441a7e9908ff4538dacc4580fd44c771d954acd]

        vcl: Drop commented code in SvTabListBox::SetTabs
        
        This has been commented ever since
        
            commit 8ab086b6cc054501bfbf7ef6fa509c393691e860
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon Sep 18 16:07:07 2000 +0000
        
                initial import
        
        It's also unclear what `ButtonsOnRoot` in the comment refers
        to, as `git grep ButtonsOnRoot` doesn't give any results,
        nor did the above commit include it anywhere except for this comment.
        
        Change-Id: I86e3421d05ffe87ce86bd11fae2383b74de696e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181338
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [b0b97184aa56fd507785045afb51d2b53419d023]

        vcl: Simplify and rename SvTabListBox::SetTabJustify
        
        SvTabListBox::SetTabJustify only ever gets called
        with SvTabJustify::AdjustCenter for param `eJustify`.
        
        Drop the param and rename the method to
        SvTabListBox::SetTabAlignCenter to simplify the code.
        
        Drop now unused enum class SvTabJustify.
        
        Change-Id: Ibaaafcbdc16551f7562987212b25a68552290c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181337
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [59d34ccdbd27ddba09179c235ba89e542d818a41]

        vcl: Use enum class instead of int defines for treeview button types
        
        Change-Id: I2d19d71cb3ac5a2b7d8319635610369036d4ac0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181336
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [38bab24446ca7967f604735a04452b4969758c8c]

        check once if there are any urn:bails metadata in the document
        
        for the common case that there are none at all, in which case we
        don't have to check every paragraph for its metadata.
        
        Change-Id: I65a59041d1eeb56db6e312c8b130fbd7d519306a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee29fb4b41b143eaa6cae5d962c55339e7cf1906]

        language-subtag-registry: upgrade to 2025-02-06
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-02-06.tar.bz2 data/language-subtag-registry
        
        Change-Id: I3b61e752e14384ff45b692f63b2f741d6a09dc77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181331
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ca40e9ebcf01b9403a1c1ebecb74755fa0e54fe2]

        lxml: upgrade to 5.3.1
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-5.3.1/lxml-5.3.1.tar.gz
        
        Change-Id: I5a8a91867163c3df7a57e39032530068a6f085ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181329
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-10  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [95d640e4c228181485af50248d90ad94228de9a4]

        tdf#164712: ITEM regression: Fix SfxItemSet::Differentiate
        
        For SfxItemSet::Differentiate and ::Intersect we had the strange
        case that dependent of the former possible same WhichRanges two
        different things were done, see the comments I had added to those
        methods when adapting to ITEM changes.
        This error now has given a hint that one of those was the intended
        one, the one that ALSO does that for item in state
        SfxItemState::DISABLED or SfxItemState::INVALID.
        Thus I now adapted these methods to (hopefully now) do the right
        thing in all cases.
        
        Change-Id: I276da418d663d37942530563c4bfaf0a46a93e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181258
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-02-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7da1497aa462e2b719aa9b308a749caf7b9a19b1]

        Improve description of new Calc array function arguments
        
        Change-Id: Idc93a820563601e763595cd5d3f34fd6889669e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181276
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-10  Christopher Sherlock  <chris.sherlock79@gmail.com>  [95609ed61346d4ad3f38f354963f7d809e8effa6]

        vcl: make variables const in combobox.cxx
        
        Change-Id: Icb94a3341c1eb02f74d18dda7b3af1d83ef30f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178212
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Christopher Sherlock  <chris.sherlock79@gmail.com>  [e554da3b298a45abe0532a67b478a90a3bf34fb1]

        vcl: OV_DRAWGRID is not ever set anywhere
        
        Change-Id: I239cf124ebdccc0b9e811e403f763d0c45b640a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179207
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Christopher Sherlock  <chris.sherlock79@gmail.com>  [8a3a2ab67d8db2a99936671a24ed300fd965c303]

        vcl: move ImplInit into Slider constructor
        
        Change-Id: I70a990079443aa0bc3480c8f98235f67ce043611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179326
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-10  Christopher Sherlock  <chris.sherlock79@gmail.com>  [58cc936ec70ae352f9574167ffe32144e7b7933f]

        vcl: remove SpinButton::ImplInit()
        
        Change-Id: I865d1c46e210c92fa9e4e5cdb4d5272640ce41c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179363
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-10  Noel Grandin  <noelgrandin@gmail.com>  [b11957681f7dfbc5268e2f08528e3cf6f5c1b180]

        hopefully fix the PDF export of alpha once and for all
        
        The root of the problem, is that at the bottom of the call-chain,
        we want to export transparency. We were trying to patch this in the
        middle of call-chain, by inverting. But that is unreliable because
        sometimes we don't always traverse the middle of the call-chain
        once.
        
        So remove all of the various inverting, and just invert at the
        bottom, when we want to output transparency data.
        
        Tested this with the various bugs linked in the comments I removed.
        
        Change-Id: I880ab3a3e6c44f8531893f7405a33a331e4b4295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181316
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-09  Chris Sherlock  <chris.sherlock79@gmail.com>  [988d09d170b94f4ed5aa9b0fa6aa199e3fb521a9]

        vcl: flatten control/calendar.cxx functions
        
        Change-Id: I9ed6ca251e40f050ec872c70d3310d330c705e22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174728
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4e6053bededfdec658a9081142f348a784bdce9e]

        vcl: remove VectorGraphicData string path constructor
        
        Not needing that convenience that is used only once - better to be
        sure we always take the BinaryDataContainer as a input. This also
        means every VectorGraphicData still has access to the source
        format (SVG, PDF, EMF,...).
        
        Change-Id: I179f6eafd2fbb18497e433a1c5d3f4dcc551c508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180787
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-02-09  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [589e523dd967e39f4715cfe120e12fba11cf9c90]

        tdf#164775 PPTX export: fix connector shape regression
        
        A connector shape can be connected to a shape, if the end of connector shape is released inside the target shape, it will automatically attach to the best possible connection point.
        It takes into account the shape type, geometric properties, and
        user-defined glue points.
        In this case, if we export the ODP file to PPTX, we need to use the GetConnectorRule() method to get the correct connection index(idx).
        
        this regression is
        caused by commit 4d153517183193f468dee9148c94fe9d874bacb3
        (tdf#149697 PPTX export: fix changing place of connection points).
        
        Change-Id: I8eda059e72f595edc62fd5bc7f3e6466988af5bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181226
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2025-02-09  Noel Grandin  <noelgrandin@gmail.com>  [2d813610d2de85455588a65ca1bc81391a3cdc7d]

        simplify writeBitmapMaskObject
        
        we are only actually fill in two elements of the struct we pass
        here.
        
        Change-Id: Ic07b8395c56876d5a0e1193ebedebf49d65375ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181315
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-09  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7cdd095af4605c6a2569b99618c19727b6c1cbfc]

        tdf#163486: PVS: Constant expression in switch statement
        
        V785 Constant expression in switch statement
        
        Added a default value for the case of uninitialized nStyle.
        
        Change-Id: I3c73a9b293958d72a7897b5923afdd9291030db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175901
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [28a2ee25d9d776f1f13a9f1fa67e19cef3dc6a76]

        tdf#164995: only match keywords for requested locale and opcode
        
        The fuzzy search, where a matching keyword for a different language
        and/or function could be returned, resulted in the French "version"
        standing for standard "release", changing semantics.
        
        Change-Id: Icf96f0e0c0c032ce7779bf53fe73af060a59a484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181313
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [78d5ca5e451a52ccc72051dcf05ce3a72bbcb94b]

        Simplify implementation of ScCellKeywordTranslator::transKeyword
        
        Move everything except the function declaration into CXX.
        
        Change-Id: Ib804431d27ded92e0fe7981beb4dbefc6c99ea76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181312
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5920c329cfe86af8b70dc9bd4594ce4d5ec27811]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 59b3b34772dc046c393d4b31570a4262cfd523ef
          - Fix some new functions Help pages
            
            + Refactor for less translation
            + cross links between help pages
            + fix syntax definitions
            + other changes for readability
            
            Change-Id: I1c93ad3ef7b65f88b02afecff2d1ac706f1c75ea
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181314
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [15900343d7dceec7e2a7017a309f9ec184c3da14]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ffb89373324e64c4753ffd41d98bbd7f70b336ea
          - tdf#150867, tdf#150868 VSTACK, HSTACK Help pages
            
            Change-Id: I99393f75184cabb9f8fd636c1e42efcf2e71ee38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181305
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [558cba561b2c390107000580b16852de626b45c0]

        Make some typed_flags operations constexpr
        
        Change-Id: I226673acb0d98b00387bdb5582ff41469ffbd130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181308
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-09  Simon Chenery  <simon_chenery@yahoo.com>  [b22f9843e6801621538e132ad332f1870e2bef16]

        tdf#154285 Check correct number of arguments to SbRtl_Now function
        
        If BASIC function NOW is called with the wrong number of arguments,
        then return error code 5 (Invalid procedure call).
        
        Change-Id: I123f316e36e6726a2cfc9d1e53664ce632af1289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181303
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-09  Jim Raykowski  <raykowj@gmail.com>  [cdcaa50e60c8abbbb84b460b8ac6671fc42b9d50]

        resolves tdf#164985 Incorrect bookmarks list in bookmark dialog after
        
        column sort followed by delete
        
        Change-Id: Id0ff9213b7a09faf4ed490a216e85ac7ec277af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181006
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2025-02-08  Kohei Yoshida  <kohei@libreoffice.org>  [89285dd322e9975f874514e03a299e616a953efb]

        Upgrade mdds to 3.0.0 and liborcus to 0.20.0
        
        The portion of this change related to the mdds upgrade has been done by Xisco
        Fauli via https://gerrit.libreoffice.org/c/core/+/180862
        
        mdds 3.0.0
        
        * external/mdds/0001-cid-1546160-COPY_INSTEAD_OF_MOVE.patch.1 is fixed upstream
        * external/mdds/use-after-free.patch is fixed upstream
        
        Downloaded from https://gitlab.com/api/v4/projects/mdds%2Fmdds/packages/generic/source/3.0.0/mdds-3.0.0.tar.xz
        
        liborcus 0.20.0
        
        * Pick up superscript and subscript text attributes.
        * Update the import of the font underline attributes as well as the
          strikethrough attributes applied to the cells.
        * Pick up the underline and strikethrough attributes in rich text
          strings.
        * Implementation for the previous auto filter interface has been
          removed for now.
        
        Downloaded from https://gitlab.com/api/v4/projects/orcus%2Forcus/packages/generic/source/0.20.0/liborcus-0.20.0.tar.xz
        
        Change-Id: I93f6e5ab961d707a2bae03a4eca1466c541f086e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181282
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2025-02-08  David Hashe  <me@dhashe.com>  [9da2ba0f82c8b1e2ecaa4cdbad69f452808fb601]

        tdf#42982 Make exception messages more consistent
        
        Follow-on patch to commit b23c2ba4c4ecf447de7e0db62a395856e70de1dd
        (tdf#42982 Improve UNO API error reporting, 2025-01-15).
        
        Change-Id: I80e05c1f7790f63f1372d719b512c4800e05bf05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181297
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-08  Justin Luth  <justin.luth@collabora.com>  [5ef44a0b2ad238fbd13196e2f602de71f42a34d1]

        tdf#165130 sc: prevent pane's topLeftCell from being in frozen zone
        
        While Excel 2010 opens this unit test just fine
        (and looks like a split window)
        Excel 2019 complains it is corrupt.
        
        So, this patch just prevents writing an invalid topLeftCell
        which will avoid us from causing such a problem
        as well as fixing documents that already exhibit the problem.
        
        make CppunitTest_sc_subsequent_export_test2 \
            CPPUNIT_TEST_NAME=testFreezePaneStartCellXLSX
        
        Change-Id: I32888d7d020ec16dca436686cd76008ed417d699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181275
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-02-08  Patrick Luby  <guibomacdev@gmail.com>  [36b4609461d9daa7cfd9b00689f64d31717e5044]

        Revert "tdf#164223 invert alpha mask for JPEG images"
        
        This reverts commit 5e03f4d40c14cc79b1f3f790955196a31eec5d3c.
        
        Reason for revert: the commit causes tdf#165125. Interestingly, tdf#165125 no longer occurs on this branch after reverting the
        above commit so it appears that after my commit, some other
        commit may have fixed the underlying bug.
        
        Change-Id: Ief33e857b389882f4961a2b1bb8b1945f950e9cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181291
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [b20d0f9b3797f6e1e33076d386608fa5eecd1106]

        tdf#165062 qt: Make only floating window/popup widget bg translucent
        
        For QtWidget, only set the window attributes needed for
        translucent background for floating windows and popups,
        not all QtWidgets.
        
        This fixes rendering issues when resizing a Window
        with Notebookbar (Groupedbar Compact) active (tdf#165062).
        
        Setting those flags was introduced in
        
            commit 9ea767cb568cef1b142190d2adb0e301baa382e2
            Date:   Thu May 26 13:48:38 2022 +0200
        
                tdf#132350 Qt implement SalMenu button interface
        
        whose commit message explains:
        
        >  This also includes the transparency flags for our QtWidget, so the
        >  updater "bubble window" is properly alpha-masked / shaped.
        
        Indeed, the BubbleWindow doesn't properly use alpha
        on X11 if those flags are not set  in a quick test with demo change [1] applied
        locally to trigger the update notification.
        
        (Even without those flags set, the window still uses
        a translucent background on Wayland in my tests. It has
        a different problem of being misplaced there, but that's
        a completely independent issue, see tdf#158994.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/106922/4
        
        Change-Id: Ibda381985c0dc562d7548656146f99f01fca1964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181292
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-08  Mike Kaganski  <mike.kaganski@collabora.com>  [9735a9377b3013943e6a245b5afef57de738a0f6]

        Related: tdf#164788 Force Skia software rendering after crash in test
        
        The minidumps in the bug give this call stack:
        
          KERNELBASE.dll!RaiseException()
          [Inline Frame] mergedlo.dll!SalAbort(const rtl::OUString &) Line 377
          mergedlo.dll!Application::Abort(const rtl::OUString & rErrorText) Line 300
          mergedlo.dll!desktop::Desktop::Exception(ExceptionCategory nCategory) Line 1237
          mergedlo.dll!VCLExceptionSignal_impl(void * __formal, oslSignalInfo * pInfo) Line 176
          [Inline Frame] sal3.dll!callSignalHandler(oslSignalInfo *) Line 47
          sal3.dll!`anonymous namespace'::signalHandlerFunction(_EXCEPTION_POINTERS * lpEP) Line 141
          KERNELBASE.dll!UnhandledExceptionFilter()
          ntdll.dll!RtlUserThreadStart$filt$0()
          ntdll.dll!__C_specific_handler()
          ntdll.dll!RtlpExecuteHandlerForException()
          ntdll.dll!RtlDispatchException()
          ntdll.dll!KiUserExceptionDispatch()
          skialo.dll!sk_gpu_test::FreeVulkanFeaturesStructs(const VkPhysicalDeviceFeatures2 * features) Line 885
          skialo.dll!skwindow::internal::VulkanWindowContext::initializeContext() Line 83
          skialo.dll!skwindow::internal::VulkanWindowContext::VulkanWindowContext(const skwindow::DisplayParams & params, std::function<VkSurfaceKHR_T *(VkInstance_T *)> createVkSurface, std::function<bool (VkInstance_T *, VkPhysicalDevice_T *, unsigned int)> canPresent, void(*)()(*)(VkInstance_T *, const char *) instProc) Line 59
          skialo.dll!skwindow::MakeVulkanForWin(HWND__ * hwnd, const skwindow::DisplayParams & params) Line 72
          vclplug_winlo.dll!`anonymous namespace'::createVulkanWindowContext(bool __formal) Line 571
          [Inline Frame] mergedlo.dll!SkiaHelper::getTemporaryWindowContext() Line 546
          mergedlo.dll!SkiaHelper::checkDeviceDenylisted(bool blockDisable) Line 253
          mergedlo.dll!SkiaHelper::isVCLSkiaEnabled() Line 408
          vclplug_winlo.dll!WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType, bool bScreen, HWND__ * hWnd, SalGeometryProvider * pProvider) Line 636
          vclplug_winlo.dll!WinSalFrame::AcquireGraphics() Line 1063
          mergedlo.dll!vcl::WindowOutputDevice::AcquireGraphics() Line 838
          mergedlo.dll!vcl::Window::ImplInit(vcl::Window * pParent, __int64 nStyle, SystemParentData * pSystemParentData) Line 1100
          mergedlo.dll!ImplBorderWindow::ImplInit(vcl::Window * pParent, __int64 nStyle, BorderWindowStyle nTypeStyle, SystemParentData * pSystemParentData) Line 1566
          [Inline Frame] mergedlo.dll!ImplBorderWindow::{ctor}(vcl::Window *) Line 1594
          [Inline Frame] mergedlo.dll!VclPtrInstance<ImplBorderWindow>::{ctor}(vcl::Window * &) Line 280
          mergedlo.dll!WorkWindow::ImplInit(vcl::Window * pParent, __int64 nStyle, SystemParentData * pSystemParentData) Line 51
          [Inline Frame] mergedlo.dll!IntroWindow::{ctor}() Line 35
          mergedlo.dll!`anonymous namespace'::SplashScreenWindow::SplashScreenWindow(`anonymous-namespace'::SplashScreen * pSplash) Line 125
          [Inline Frame] mergedlo.dll!VclPtr<`anonymous namespace'::SplashScreenWindow>::Create(`anonymous-namespace'::SplashScreen * &&) Line 129
          [Inline Frame] mergedlo.dll!`anonymous-namespace'::SplashScreen::{ctor}() Line 145
          mergedlo.dll!desktop_SplashScreen_get_implementation(com::sun::star::uno::XComponentContext * __formal, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & __formal) Line 616
          [Inline Frame] cppuhelper3MSC.dll!std::_Func_class<com::sun::star::uno::XInterface *,com::sun::star::uno::XComponentContext *,com::sun::star::uno::Sequence<com::sun::star::uno::Any> const &>::operator()(com::sun::star::uno::XComponentContext * <_Args_0>, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> &) Line 869
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & arguments) Line 717
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, bool singletonRequest, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & arguments) Line 689
          cppuhelper3MSC.dll!cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(const rtl::OUString & ServiceSpecifier, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & Arguments, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & Context) Line 1013
          mergedlo.dll!desktop::Desktop::OpenSplashScreen() Line 2516
          mergedlo.dll!desktop::Desktop::Main() Line 1356
          mergedlo.dll!ImplSVMain() Line 228
          [Inline Frame] mergedlo.dll!SVMain() Line 246
          mergedlo.dll!soffice_main() Line 121
          [Inline Frame] soffice.bin!sal_main() Line 51
          soffice.bin!main(int argc, char * * argv) Line 49
          [Inline Frame] soffice.bin!invoke_main() Line 78
          soffice.bin!__scrt_common_main_seh() Line 288
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        The crash happened inside checkDeviceDenylisted. Let's try to wrap
        the dangerous code into a pair of configuration changes: first to
        force software rendering in Skia - this change will stay in case
        the HW check crashes for some reason; and after the check, second
        to restore the original value.
        
        If similar problems can happen also in case of Metal, then it can
        be also done inside the '#ifdef SK_METAL'.
        
        Change-Id: I163a0a16e0edc6b542dfc3e25ee862f38cffa863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181290
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c10dbe07b7def2eebd8eed3874c3df9b9d37fa41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69e7134a2cbf10aa1acda3515fa78f7d48d35fe9
          - tdf#150999, tdf#151000 CHOOSECOLS, CHOOSEROWS Help page
            
            Change-Id: Ib520e10b17f34eff8fcdc71c008c22ca150341f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181283
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-08  Mike Kaganski  <mike.kaganski@collabora.com>  [ca31eac04b10fec6bf27a801b9164ec419062763]

        tdf#165099: do not notify change listeners about temporary changes
        
        Commit bc09a4f1ce1f6a714f7827a404aa6317b503d307 (Disable subpixel AA
        in GraphicExporter::filter unconditionally, 2024-12-04)  had changed
        GraphicExporter::filter  to set application settings unconditionally,
        instead of only when AA was explicitly set. That uncovered a problem
        that the change may trigger a rebuild of sidebars;  and in slideshow
        case, it may make the rebuilt sidebars to capture the temporary view
        created for the slideshow.
        
        1. Slideshow is built; in SlideShow::StartFullscreenPresentation, it
           creates a new component with a frame,  which eventually creates a
           new sd::DrawController;
        2. Slideshow draws its slide(s); in slideshow::internal::getMetaFile,
           GraphicExporter::filter is called, which would change application
           settings;
        3. Application::SetSettings eventually trigger WindowEventHandler in
           sfx2::sidebar::SidebarController, with WindowDataChanged;
        4. SidebarController::maContextChangeUpdate is called asynchronously,
           i.e.,  after all the draw is finished;  eventually this will call
           SidebarController::UpdateConfigurations for SdSlideTransitionDeck,
           which forces rebuild of the deck;
        5. sd::SlideTransitionPane::Initialize  resets its mxView to current
           controller, which is the sd::DrawController created on step 1 for
           the slideshow;
        6. sd::SlideShow::end closes its frame, eventually disposing frame's
           controller (calling sd::DrawController::dispose);  note that this
           controller is still referenced from sidebar.
        
        After that, the sidebar interactions will crash because of unhandled
        exception thrown from DrawController::ThrowIfDisposed.
        
        Note that the change in the abovementioned commit only uncovered the
        problem; before that change it could still crash, when AA was set in
        the GraphicExporter::filter call.
        
        This change makes sure to not notify listeners in the #3 above, when
        the change of the settings is only temporary  (for the duration of a
        export). This is similar to the existing bTemporary argument that is
        already passed to SetAntiAliasing from GraphicExporter::filter. This
        allows to avoid the unwanted sidebar rebuild;  and also, this should
        improve the filter call performance. The hope is, that this wouldn't
        modify the result; but if some components, that listen to the change
        notifications, happen to affect the export,  we likely would need to
        change their behavior to always use Application::GetSettings.
        
        It seems to me, that after this change, clicking the first time on a
        transition after a slideshow will not select it.  Seems like another
        pre-existing problem;  it flickered before selection even before the
        change; likely needs a separate fix.
        
        Change-Id: Ia0ba19401ca805c2190926623c1c708cf26a313b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181288
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [74a1f82aebdd9cc05244f7313ff4d06261f3087a]

        qt: Run QtMenu::RemoveMenuBarButton in main thread
        
        ... and merge it with QtMenu::ImplRemoveMenuBarButton
        that it was previously calling.
        
        This fixes the below assert that gets triggered when
        extension updates are available.
        (In my case, a fake update notification was triggered
        by forcing it with the changes from demo Gerrit change [1].)
        
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007fb5a6e9de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007fb5a6e49d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007fb5a6e324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fb592902f8d in qAbort () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:46
            #5  0x00007fb592949948 in qt_message_fatal<QString&> (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2062
            #6  0x00007fb592942b4d in qt_message (msgType=QtFatalMsg, context=..., msg=0x7fb593090df3 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fb55fffb4b0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:342
            #7  0x00007fb592944e9d in QMessageLogger::fatal (this=0x7fb55fffb650, msg=0x7fb593090df3 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:831
            #8  0x00007fb592903043 in qt_assert_x
                (where=0x7fb59309a8b9 "QCoreApplication::sendEvent", what=0x5628d475e9f0 "Cannot send events to objects owned by a different thread. Current thread QThread(0x5628d4691800). Receiver 'QWidget(0x5628d4472f70)' was created in thread QThread(0x5628cb7b0e20, name = \"Qt mainThrea"..., file=0x7fb59309a695 "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=530)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:115
            #9  0x00007fb592a490b6 in QCoreApplicationPrivate::checkReceiverThread (receiver=0x5628d4472f70) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:526
            #10 0x00007fb5909e4011 in QApplication::notify (this=0x5628cb7b0d60, receiver=0x5628d4472f70, e=0x7fb55fffc2d8) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2590
            #11 0x00007fb592a4a8d9 in QCoreApplication::notifyInternal2 (receiver=0x5628d4472f70, event=0x7fb55fffc2d8) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1098
            #12 0x00007fb592a4b549 in QCoreApplication::sendEvent (receiver=0x5628d4472f70, event=0x7fb55fffc2d8) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1538
            #13 0x00007fb590a8816a in QWidget::~QWidget (this=0x5628d4472f70) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1569
            #14 0x00007fb590c285db in QAbstractButton::~QAbstractButton (this=0x5628d4472f70) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qabstractbutton.cpp:453
            #15 0x00007fb590da0b89 in QPushButton::~QPushButton (this=0x5628d4472f70) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qpushbutton.cpp:250
            #16 0x00007fb590da0bcd in QPushButton::~QPushButton (this=0x5628d4472f70) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qpushbutton.cpp:249
            #17 0x00007fb593a30f8a in QtMenu::ImplRemoveMenuBarButton (this=0x5628d06d8840, nId=2) at vcl/qt6/../qt5/QtMenu.cxx:872
            #18 0x00007fb593a315a0 in QtMenu::RemoveMenuBarButton (this=0x5628d06d8840, nId=2) at vcl/qt6/../qt5/QtMenu.cxx:900
            #19 0x00007fb59d9af55e in MenuBarWindow::RemoveMenuBarButton (this=0x5628d08cd990, nId=2) at /home/michi/development/git/libreoffice/vcl/source/window/menubarwindow.cxx:1191
            #20 0x00007fb59d99b766 in MenuBar::RemoveMenuBarButton (this=0x5628d06e8140, nId=2) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:2720
            #21 0x00007fb59d7e6ad0 in MenuBarUpdateIconManager::RemoveMenuBarIcon (this=0x5628d48922e8, pMenuBar=0x5628d06e8140) at /home/michi/development/git/libreoffice/vcl/source/window/bubblewindow.cxx:574
            #22 0x00007fb59d7e71d2 in MenuBarUpdateIconManager::RemoveMenuBarIcons (this=0x5628d48922e8) at /home/michi/development/git/libreoffice/vcl/source/window/bubblewindow.cxx:422
            #23 0x00007fb59d7e7284 in MenuBarUpdateIconManager::SetShowMenuIcon (this=0x5628d48922e8, bShowMenuIcon=false) at /home/michi/development/git/libreoffice/vcl/source/window/bubblewindow.cxx:435
            #24 0x00007fb58e5effc7 in (anonymous namespace)::UpdateCheckUI::setPropertyValue (this=0x5628d4892290, rPropertyName="MenuIconVisible", rValue=uno::Any("boolean": 0 '\000'))
                at /home/michi/development/git/libreoffice/extensions/source/update/ui/updatecheckui.cxx:215
            #25 0x00007fb57cafd80e in UpdateCheck::handleMenuBarUI (this=0x7fb560025d40, rUpdateHandler=rtl::Reference to 0x7fb5600279f0, eState=@0x7fb55fffcc44: UPDATESTATE_NO_UPDATE_AVAIL, suppressBubble=true)
                at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:1287
            #26 0x00007fb57cafa135 in UpdateCheck::setUIState (this=0x7fb560025d40, eState=UPDATESTATE_NO_UPDATE_AVAIL, suppressBubble=true) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:1332
            #27 0x00007fb57cafd368 in UpdateCheck::setUpdateInfo (this=0x7fb560025d40, aInfo=...) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:1253
            #28 0x00007fb57caff7c3 in (anonymous namespace)::UpdateCheckThread::runCheck (this=0x7fb5600269e0, rbExtensionsChecked=@0x7fb55fffd1a7: false)
                at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:389
            #29 0x00007fb57cafefd3 in (anonymous namespace)::UpdateCheckThread::run (this=0x7fb5600269e0) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:508
            #30 0x00007fb57cb08a4e in threadFunc (param=0x7fb5600269e0) at include/osl/thread.hxx:189
            #31 0x00007fb5a7502ccb in osl_thread_start_Impl (pData=0x7fb5600271b0) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:237
            #32 0x00007fb5a6e9c083 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:447
            #33 0x00007fb5a6f1a5f0 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100
        
        [1] https://gerrit.libreoffice.org/c/core/+/106922
        
        Change-Id: I571ec792bf4f83d61f0bc327199559fc47159dca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181281
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [35d1c4267dae6452a12be85f680020b69939762d]

        qt: Let Qt take care of showing menu item tooltips
        
        While Qt doesn't show tooltips for QActions set in QMenu
        by default, this can explicitly be enabled using
        QtMenu::setToolTipsVisible.
        
        Use this to simplify the solution initially implemented
        in
        
            commit a108fce773d46441e30dcc14abe29751410ae4ed
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 17 14:18:30 2025 +0100
        
                tdf#163186 qt: Show menu item tooltips
        
        that was using a custom event filter to show tooltips.
        
        Change-Id: I1e9719e59111d0e43059ba632e88f8ddf77be642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181289
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [9d8444e16535d6cdd460d8263d92961110b70145]

        vcl: remove unnecessary headers from tabctrl.cxx
        
        Change-Id: I92214814a486209eb07f7398e4ceece890ec1845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179448
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [f07092c3ea33c326d351d38d11e9cb56004b920c]

        vcl: remove unnecessary headers in throbber.cxx
        
        Change-Id: Ie9fc341bdcc71b57d8bfae12d84a5100f1f029c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179665
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-08  Andras Timar  <andras.timar@collabora.com>  [1cd13c33d030ba750440eacdffea86b9e8b94254]

        cool#11103 sc: respect document specific settings
        
        The purpose of this CheckConfigOptions function is to reset
        formula separators, when there is a clash with decimal separator.
        However, ignoring other settings that are coming from the document
        can cause issues, like that we saw with LOKit, where
        StringRefAddressSyntax of a German XLSX document was reset to default
        CONV_UNSPECIFIED, and function =INDIREKT("Sheet1!A1") which was
        according to CONV_XL_A1 stopped working, and gave error #BEZUG (#REF).
        
        Change-Id: I7693deed436ad4e54569a21cc3faeaafceeb459c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181250
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181287
        Tested-by: Jenkins

2025-02-08  David Hashe  <me@dhashe.com>  [b23c2ba4c4ecf447de7e0db62a395856e70de1dd]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: I0c587834ea5ed6e3527471e58fd9a94ee2aac55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180993
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [1ac1da97a190382eae6a276944f176fbc8c84117]

        vcl: remove unnecessary incldues in hyperlabel.cxx
        
        Change-Id: I214a9368523a521f2115b9e22b547325fbbae57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179192
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-08  Noel Grandin  <noelgrandin@gmail.com>  [5fa7281135b2d0ede1eeb801a032eed67f27eac6]

        move some fields from OutlinerEditEng to Outliner
        
        as the comment indicates, that is where they belong
        
        Change-Id: I0078a359253d86d0197a87fade5a2de7579be042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181273
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3aa64249508c36e8f798f870d9bc2539f26e4dde]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 34ab1eecfb16f544cd52cad5fd00cc7489811d02
          - CSS: add missing semicolon and tweak whitespace
            
            Change-Id: I9f16d3bf00e049f671c1d4077d04777f8e3609aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181286
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [3d26b7363aaf105209194a5a64f99fde79d2492f]

        vcl: nStyle -> eStyle
        
        Change-Id: Iae6c45830ccbfdf1841099270572ecb9fd7c8109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178226
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [3d85419747a857522e8e0997724bb3f117eedc88]

        vcl: ImplCalcPos() -> lcl_CalcPos()
        
        Change-Id: Idbfd93d8d8faf12c516fd34642ef8ca33c14d189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179144
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [332af14e82f114202fd5b12cda0e33b9a6c446d3]

        vcl: remove using namespace from fmtfield.cxx
        
        Change-Id: I43e4c6c34d76d97e5073167fee8af25fd887bde3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-08  Christopher Sherlock  <chris.sherlock79@gmail.com>  [9d76dc9bfe4e4acb7ce7fcf976461e1d3ff9f685]

        vcl: remove using namespaces from field.cxx
        
        Change-Id: Ie5e8463184171e4660aecc3395d6e85cb30dcc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178942
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-08  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [731a4876b72d9794d2a76f170d0338f799369d3f]

        tdf#164972 Fix white-on-white themed scrollbars on windows
        
        - in case of light mode, decrease the base color luminance.
        
        - this is just a temporary fix similar to how other controls
          like disabled buttons are themed and would be replaced with
          themed native controls.
        
        Change-Id: If574e96499f48a5139775a2efcd6aa1f20e26c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181271
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-02-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [4328d1cca66ed9d1e34a8d788d16a2205fe77c1c]

        tdf#120397 - odf export fix missing texts in text box control
        
        (Ab)use a call to XTextRange::getText to flush edits and restore
        the selection of the textcontent in the textfields.
        
        TODO: unit/UItest
        
        Change-Id: If8e1c85f3565ae1b80fd0645c0905aae16404379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181245
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [0ccd8cd083a820e8c7ee983d88c9ca3c55221506]

        browsebox a11y: Merge EditBrowseBoxImpl into EditBrowseBox
        
        EditBrowseBoxImpl just holds a reference to the
        accesssible object and a helper method to clear the
        reference. Move these directly into EditBrowseBox instead.
        
        Change-Id: I2ab6eae401e4924da4cade6583ca008c755cd6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181221
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [4774bb6a64ef7f694c46657734e8ec1b6eb69a45]

        browsebox a11y: clang-format EditBrowseBoxTableCell
        
        Not much left to do after
        
            Change-Id: I5dfd2554d919babb3400967f8ffc0df5df3af53a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 7 17:09:22 2025 +0100
        
                browsebox a11y: Completely rework EditBrowseBoxTableCell
        
        any more, so clang-format 2 more lines and drop from the exclude list.
        
        Change-Id: I6e8283ffaff8dcd2a9a682bd8d74320164c18987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181269
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [8a919d023c1cb1397228a185ff3a6216448b5f90]

        browsebox a11y: Completely rework EditBrowseBoxTableCell
        
        So far the logic to implement accessibility for the
        currently active control to edit a cell in a BrowseBox
        (an EditBrowseBox) was as follows:
        There were two classes: EditBrowseBoxTableCellAccess
        implemented the XAccessible interface and created
        an EditBrowseBoxTableCell object in its
        XAccessible::getAccessibleContext implementation.
        EditBrowseBoxTableCell was the XAccessibleContext
        implementation that derived from
        AccessibleBrowseBoxCell and wrapped the accessible
        of the control window (svt::ControlBase) using
        comphelper::OAccessibleContextWrapperHelper
        (that it also subclassed).
        
        Change that as follows:
        
        1) Let EditBrowseBoxTableCell implement both, the
        XAccessible and the XAccessibleContext interfaces
        at the same time.
        
        2) No longer derive from AccessibleBrowseBoxCell
        as almost none of the the base class logic from
        that subclass was used (mostly storing and
        retrieving the current row + column index to generate
        an accessible name based on that), but was instead
        using comphelper::OAccessibleContextWrapperHelper
        functionality to use the logic of the wrapped
        accessible instead.
        
        3) No longer use comphelper::OAccessibleContextWrapperHelper
        to wrap the accessible object of the svt::ControlBase,
        but let EditBrowseBoxTableCell be the
        svt::ControlBase's accessible itself
        (created in ControlBase::CreateAccessible).
        
        4) Derive from VCLXAccessibleComponent, which is
        the default implementation for vcl::Window's XAccessible
        and is what was used for the svt::ControlBase
        before. The base class already does most of the things
        as needed. Only override what needs to be adjusted.
        
        5) Move existing logic to generate an accessible
        name based on the cell's address from
        EditBrowseBoxTableCell::getAccessibleName to
        EditBrowseBox::implCreateActiveAccessible and set
        it via vcl::Window::SetAccessibleName. This also
        takes care of sending the necessary events about
        name changes if the accessible name of the existing
        accessible is changed. (Since the ControlBase's
        accessible is used now, the lifetime of the
        accessible is tied to the lifetime of the
        ControlBase/vcl::Window, too, and apparently
        that control gets reused e.g. for comboboxes
        in multiple rows, but this way, the name gets
        updated as needed on the a11y layer.)
        
        6) No longer let EditBrowseBox dispose the accessible
        object. As described in 5), it is no longer the owner,
        but the ControlBase is (so the "normal" vcl::Window
        logic applies regarding lifecycle of the accessible
        and the vcl::Window disposes the accessible).
        
        7) Implement EditBrowseBoxTableCell::getAccessibleParent
        to override the default VCLXAccessibleComponent
        implementation and return the BrowseBox's accessible
        as the a11y parent. In the vcl::Window hierarchy, there is
        a BrowserDataWin in between, but as the
        BrowseBox's accessible implementation, AccessibleBrowseBox,
        reports the EditBrowseBoxTableCell as a direct child, also
        report the parent accordingly the other way around.
        (This was previously handled by OAccessibleContextWrapperHelper.)
        
        To test:
        
        1) Start Base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."
        3) In the window that opens, edit cells ("Field Name", "Field Type",
           "Description") in multiple rows.
        4) Inspect a11y tree using Accerciser.
        5) Use a screen reader while doing the previous steps
           and observe what gets announced.
        
        Besides simplifying code, this commit also improves/fixes the
        following aspects seen during testing:
        
        1) With the qt6 VCL plugin, hen clicking on the accessible object implemented by
        EditBrowseBoxTableCell in Accerciser's treeview of the a11y
        hierarchy (shown e.g. with an accessible name of "Column 2, Row 2"
        as a child of the "BrowseBox" object), the correct area is highlighted
        on screen now, while it was slightly off before.
        
        2) The object now reports the correct child index (index in parent)
        which matches the position in the parent as shown in Accerciser
        (index 3, after the "ColumnHeaderBar", "RowHeaderBar", "Table").
        
        Before:
        
            In [3]: acc.get_index_in_parent()
            Out[3]: -1
        
        Now:
        
            In [2]: acc.get_index_in_parent()
            Out[2]: 3
        
        (This is now handled correctly by OCommonAccessibleComponent::getAccessibleIndexInParent
        via the new VCLXAccessibleComponent base class hierarchy.)
        
        3) When testing with the NVDA screen reader running on Windows,
        this works OK now when testing for a while, while LibreOffice would
        previously freeze/deadlock quite quickly (somehow related to the
        comphelper::OAccessibleContextWrapperHelper base class hierarchy).
        Sample backtrace:
        
            1 NtWaitForAlertByThreadId ntdll 0x7ffb0c5b0f24
            2 RtlWaitOnAddress ntdll 0x7ffb0c574d6d
            3 RtlWaitOnAddress ntdll 0x7ffb0c574c22
            4 RtlWaitOnAddress ntdll 0x7ffb0c574a3d
            5 RtlEnterCriticalSection ntdll 0x7ffb0c53fcb4
            6 RtlEnterCriticalSection ntdll 0x7ffb0c53fae2
            7 osl_acquireMutex mutex.cxx 65 0x7ffaf6aa7328
            8 osl::Mutex::acquire mutex.hxx 63 0x7ffaf8814620
            9 osl::Guard<osl::Mutex>::Guard<osl::Mutex> mutex.hxx 144 0x7ffaf88122a1
            10 `anonymous namespace'::AffineBridge::v_callOut_v AffineBridge.cxx 272 0x7ffaf88163fd
            11 Enterable_call_callOut_v Enterable.hxx 75 0x7ffaf8816890
            12 cppu::Enterable::callOut_v Enterable.hxx 58 0x7ffaf4993ebd
            13 `anonymous namespace'::Base::v_callOut_v helper_purpenv_Environment.cxx 505 0x7ffaf49955e6
            14 Enterable_call_callOut_v Enterable.hxx 75 0x7ffaf49957b0
            15 cppu::Enterable::callOut_v Enterable.hxx 58 0x7ffaf3e6fa9d
            16 s_callOut_v EnvStack.cxx 251 0x7ffaf3e70385
            17 s_callOut EnvStack.cxx 263 0x7ffaf3e7032f
            18 s_environment_invoke_v EnvStack.cxx 286 0x7ffaf3e7044f
            19 uno_Environment_invoke_v EnvStack.cxx 310 0x7ffaf3e710c8
            20 uno_Environment_invoke EnvStack.cxx 319 0x7ffaf3e7107f
            21 computeObjectIdentifier component.cxx 112 0x7ffaf63db115
            22 defenv_getObjectIdentifier lbenv.cxx 446 0x7ffaf3e82535
            23 `anonymous namespace'::ProxyRoot::queryAggregation proxyfac.cxx 298 0x7ffaf9336b13
            24 comphelper::OProxyAggregation::queryAggregation proxyaggregation.cxx 70 0x7ffae10a99a7
            25 comphelper::OComponentProxyAggregationHelper::queryInterface proxyaggregation.cxx 129 0x7ffae10a9c11
            26 comphelper::OAccessibleContextWrapperHelper::queryInterface accessiblewrapper.cxx 381 0x7ffae100dd4b
            27 comphelper::OAccessibleContextWrapper::queryInterface accessiblewrapper.cxx 475 0x7ffae100dc81
            28 com::sun::star::uno::BaseReference::iquery Reference.hxx 59 0x7ffadedf85f2
            29 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleHypertext>::iquery Reference.hxx 75 0x7ffadee02596
            30 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleHypertext>::Reference<com::sun::star::accessibility::XAccessibleHypertext> Reference.hxx 179 0x7ffadee010fe
            31 CMAccessible::get_accState MAccessible.cxx 568 0x7ffadee24a88
            32 DllGetClassObject OLEACC 0x7ffaee454bd2
            33 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46c3abd
            34 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46c2cb1
            35 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46c4d5e
            36 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46d68d5
            37 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46d63fc
            38 DllCanUnloadNow uiautomationcore 0x7ffaf46a55de
            39 UiaClientsAreListening uiautomationcore 0x7ffaf46ed629
            40 UiaRaiseAutomationEvent uiautomationcore 0x7ffaf46e7ca8
            41 uiautomationcore 0x7ffaf4693abb
            42 uiautomationcore 0x7ffaf4697300
            43 uiautomationcore 0x7ffaf4693c9c
            44 DllCanUnloadNow uiautomationcore 0x7ffaf46a55de
            45 DllCanUnloadNow uiautomationcore 0x7ffaf46abe77
            46 DllCanUnloadNow uiautomationcore 0x7ffaf46ab5c9
            47 uiautomationcore 0x7ffaf469acf7
            48 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46ccfe5
            49 UiaReturnRawElementProvider uiautomationcore 0x7ffaf46ccca7
            50 Ordinal2712 USER32 0x7ffb0c21e442
            51 SendMessageTimeoutW USER32 0x7ffb0c2210c3
            52 KiUserCallbackDispatcher ntdll 0x7ffb0c5b1374
            53 NtUserPeekMessage win32u 0x7ffb09bb1064
            54 PeekMessageW USER32 0x7ffb0c20a333
            55 PeekMessageW USER32 0x7ffb0c20a293
            56 Ordinal87 combase 0x7ffb0b3f9403
            57 Ordinal87 combase 0x7ffb0b3f936d
            58 Ordinal88 combase 0x7ffb0b3f9c3e
            59 Ordinal88 combase 0x7ffb0b3f969b
            60 Ordinal87 combase 0x7ffb0b3f7d8a
            61 CoWaitForMultipleObjects combase 0x7ffb0b3f4aa5
            62 CoWaitForMultipleHandles combase 0x7ffb0b3f1736
            63 sal::systools::WaitForMultipleObjects_COMDispatch wait_for_multiple_objects.hxx 26 0x7ffaf6a91a1e
            64 osl_waitCondition conditn.cxx 79 0x7ffaf6a91d1a
            65 osl::Condition::wait conditn.hxx 124 0x7ffaf88167aa
            66 `anonymous namespace'::AffineBridge::outerDispatch AffineBridge.cxx 183 0x7ffaf8815167
            67 `anonymous namespace'::AffineBridge::v_callInto_v AffineBridge.cxx 262 0x7ffaf8816353
            68 Enterable_call_callInto_v Enterable.hxx 73 0x7ffaf8816840
            69 cppu::Enterable::callInto_v Enterable.hxx 57 0x7ffaf4993e6d
            70 `anonymous namespace'::Base::v_callInto_v helper_purpenv_Environment.cxx 500 0x7ffaf4995596
            71 Enterable_call_callInto_v Enterable.hxx 73 0x7ffaf4995760
            72 cppu::Enterable::callInto_v Enterable.hxx 57 0x7ffaf3e6fa4d
            73 cppu::Enterable::callInto Enterable.hxx 95 0x7ffaf3e6f9ff
            74 s_callInto_v EnvStack.cxx 232 0x7ffaf3e702cc
            75 s_callInto EnvStack.cxx 244 0x7ffaf3e7026f
            76 s_environment_invoke_v EnvStack.cxx 300 0x7ffaf3e704d8
            77 uno_Environment_invoke_v EnvStack.cxx 310 0x7ffaf3e710c8
            78 uno_Environment_invoke EnvStack.cxx 319 0x7ffaf3e7107f
            79 Proxy::dispatch helper_purpenv_Proxy.cxx 432 0x7ffaf49992b5
            80 s_Proxy_dispatch helper_purpenv_Proxy.cxx 151 0x7ffaf4999efd
            81 cpp2uno_call cpp2uno.cxx 149 0x7ffaf63e52ef
            82 cpp_mediate cpp2uno.cxx 336 0x7ffaf63e6c88
            83 cpp_vtable_call cpp2uno.cxx 52 0x7ffaf63d2506
            84 privateSnippetExecutor mscx_uno 0x7ffaf63ecdee
            85 dbaui::OFieldDescControl::ActivateAggregate FieldDescControl.cxx 419 0x7ffac81839ee
            86 dbaui::OTableFieldControl::ActivateAggregate TableFieldControl.cxx 90 0x7ffac839ba3e
            87 dbaui::OFieldDescControl::DisplayData FieldDescControl.cxx 892 0x7ffac81889b4
            88 dbaui::OTableFieldDescWin::DisplayData TableFieldDescWin.cxx 67 0x7ffac839cc4c
            89 dbaui::OTableEditorCtrl::SwitchType TEditControl.cxx 1654 0x7ffac83ad160
            90 dbaui::OTableEditorCtrl::resetType TEditControl.cxx 693 0x7ffac83ae1aa
            91 dbaui::OTableEditorCtrl::CellModified TEditControl.cxx 676 0x7ffac83a4a92
            92 dbaui::OTableEditorCtrl::CellModified TEditControl.cxx 700 0x7ffac83a4205
            93 svt::EditBrowseBox::CellModifiedHdl editbrowsebox.cxx 1074 0x7ffadd8dc04a
            94 svt::EditBrowseBox::LinkStubCellModifiedHdl editbrowsebox.cxx 1071 0x7ffadd8de116
            95 Link<void *,void>::Call link.hxx 105 0x7ffacc1dfd43
            96 ImplHandleUserEvent winproc.cxx 2285 0x7ffacc1e8ec7
            97 ImplWindowFrameProc winproc.cxx 2849 0x7ffacc1ea6a4
            98 SalFrame::CallCallback salframe.hxx 311 0x7ffacbfc8036
            99 ImplHandleUserEvent salframe.cxx 4539 0x7ffac9a58f8b
            100 SalFrameWndProc salframe.cxx 6123 0x7ffac9a5e5ed
            101 SalFrameWndProcW salframe.cxx 6229 0x7ffac9a5ebf0
            102 CallWindowProcW USER32 0x7ffb0c20ef5c
            103 DispatchMessageW USER32 0x7ffb0c20e684
            104 ImplSalDispatchMessage salinst.cxx 443 0x7ffac99bc4f8
            105 ImplSalYield salinst.cxx 474 0x7ffac99bc5fb
            106 WinSalInstance::DoYield salinst.cxx 549 0x7ffac99bc1c1
            107 ImplYield svapp.cxx 385 0x7ffacc7eb309
            108 Application::Yield svapp.cxx 488 0x7ffacc7ef0a9
            109 Application::Execute svapp.cxx 361 0x7ffacc7e89ec
            110 desktop::Desktop::Main app.cxx 1679 0x7ffaf31d8d4d
            111 ImplSVMain svmain.cxx 230 0x7ffacc800245
            112 SVMain svmain.cxx 249 0x7ffacc800a42
            113 soffice_main sofficemain.cxx 122 0x7ffaf32291da
            114 sal_main main.c 51 0x7ff702321013
            115 main main.c 49 0x7ff70232105a
            116 __scrt_common_main_seh exe_common.inl 288 0x7ff702321344
            117 BaseThreadInitThunk KERNEL32 0x7ffb0b9c7374
            118 RtlUserThreadStart ntdll 0x7ffb0c55cc91
        
        Change-Id: I5dfd2554d919babb3400967f8ffc0df5df3af53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181268
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [1df8f5979a818f10c3654a2a9bcb5c1184c53278]

        a11y: Move EditBrowseBoxTableCell to svtools
        
        While the AccessibleBrowseBoxCell base class
        and other AccessibleBrowseBox* classes are
        used for both, SvHeaderTabListBox (in vcl)
        and BrowseBox (in svtools), EditBrowseBoxTableCell
        is only used for the latter, in order to make
        the currently active edit control accessible.
        
        Therefore, move the class to the svtools library,
        where BrowseBox is located as well.
        
        This is also in preparation of reworking
        how accessibility for BrowseBox's currently active
        control is implemented.
        
        Change-Id: Ia290df4b497baa66f98c1065c2425a0e2e079d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181267
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [6decfbd3fb03158ddcdb3aad268f2f451f6b921d]

        browsebox a11y: Drop duplicate check
        
        If `nChildIndex` is negative, an exception is already
        thrown above, so don't check again.
        
        Change-Id: Ia73fe554529ba3ad4b6adc3dff6aee28713b0132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181238
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [3ef0790a55878285d747fa657f1d73c5bf22793a]

        browsebox a11y: Report correct child index for cells
        
        No longer add any offset when a cell's child index
        is calculated in
        AccessibleBrowseBoxTableCell::getAccessibleIndexInParent.
        
        For SvHeaderTabListBox, that offset was already 0 anyway.
        
        For BrowseBox, that offset was 3 (BBINDEX_FIRSTCONTROL),
        presumably so that the first cell comes after
        * the column header (BBINDEX_COLUMNHEADERBAR, 0)
        * the row header (BBINDEX_ROWHEADERBAR, 1)
        * the table (BBINDEX_TABLE, 2)
        
        However, that doesn't make sense, because the row and
        column headers and the table are children of the
        AccessibleBrowseBox, not the AccessibleBrowseBoxTable,
        and the AccessibleBrowseBoxTableCells are children
        of the AccessibleBrowseBoxTable, not the AccessibleBrowseBox,
        so whatever children the AccessibleBrowseBox has is irrelevant
        for the cell's child index.
        
        The incorrect index could be seen like this:
        
        1) Start Base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."
        3) Start Accerciser
        4) In Accerciser's treeview of the LO a11y, navigate
           to the accessible object for the table (which has
           an accessible name of "Table").
        5) Request the child index from the child at index 0
        
        Without this change in place, this is incorrect (0 != 3):
        
            In [2]: acc.get_child_at_index(0).get_index_in_parent()
            Out[2]: 3
        
        With this change in place, this is now 0 as expected:
        
            In [3]: acc.get_child_at_index(0).get_index_in_parent()
            Out[3]: 0
        
        This also makes Accerciser's bookmark feature work for
        these table cells, i.e. creating a bookmark for a cell
        and then jumping to that bookmark later will now select
        the correct cell in the treeview again instead of a
        different one.
        
        Change-Id: Ic1a074cf604a0d0342dd9e2d4b62b58866b78351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181237
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [d4029719366042b1a5d38e4f5e73c66c2eb08f69]

        browsebox a11y: Drop unused iface method impls in BrowseBox
        
        Those 2 implementations of IAccessibleTableProvider
        methods are both overriden in the only direct
        subclass EditBrowseBox, so there's no need for
        those dummy implementations in the base class.
        
        Change-Id: I59fd87c4981aee91d328d4ff591e155b7356799a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181236
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [66e74dc7668979bc177f1ae73c102220b5905f50]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b63b651f7d1854b17074be0754416a29be00b70a
          - Add semicolon in rule.
            
            Change-Id: I887a1603a58e4e2ed0c3cbb4dbffba956ef5a7c6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181272
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [437b4d802ccec2eb1395a4e4137a4a0af039de5a]

        Fix default value of Emscripten --with-main-module
        
        ...broken by 12ed25fb94fbbee15389467dc6ae02eddf811c34 "Support Emscripten
        --with-main-module="
        
        Change-Id: I0dc3e32e4fbc0f4c90fd11b6ac56ec3ac6d67ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181259
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-07  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [44575876825f1af7c5d0cf9c5f0c2450d61f4634]

        IASS: Update mouse-as-pen status into live slideshow
        
        If live mode is enabled, reflect new settings of slideshow pen
        directly into the running slideshow.
        
        Change-Id: Ic44dc3b28c682366aba72383d24c552b7dd826da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181227
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [52e85a7cbfa5722462d43d65f6415b03b69a2260]

        mariadb-connector-c: upgrade to 3.3.14
        
        Downloaded from https://mirror.raiolanetworks.com/mariadb///connector-c-3.3.14/mariadb-connector-c-3.3.14-src.tar.gz
        
        Change-Id: I4efa0c4bfff6587758c85f69442b2c78b81fd384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181244
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-07  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [e80317dfc5fb918eb90ae188e03038f5c8c23c0a]

        tdf#65911 Fix Alt+C behavior by adjusting install:module for
        
        en-US locale
        
        Ensure Alt+C works consistently for the en-US locale by adding
        install:module="unxwnt" to its <value>. Also, add a separate <value> with
        install:module="macosx" to ensure functionality on macOS.
        
        Previously, <value> entries with install:module (e.g., for de, eu, etc.)
        overrode en-US behavior on Unix/Windows platforms due to strict interpretation
        of the install:module attribute. Even if en-US had a defined <value> without
        install:module, it would be ignored when conflicting locale-specific values
        with install:module were present.
        
        This fix prevents unwanted overrides by making en-US explicitly platform-aware
        while retaining expected behavior for other locales. Alt+C now works correctly
        for en-US on all platforms and ensures localized behavior for other languages.
        
        Change-Id: I630440e5c2d9a07a7a93955224b0901fc6e8036c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180528
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9b81a98953536b3a958038770e3df3e4bf66a128]

        Introduce loplugin:mustoverride
        
        ...to find derived classes that do not directly override SfxPoolItem::ItemType.
        Most of the cases that the plugin flagged were classes that are apparently not
        meant to be instantiated themselves (so I added pure virtual overrides there),
        but SdrMeasureFormatStringItem appears to genuinely have missed it
        DECLARE_ITEM_TYPE_FUNCTION stanza.
        
        Change-Id: Iec40080377f26cc4fa2c8cff735d5f0d3bd60509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181211
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-07  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4fd0d6a2e4891bd22fb991a4342faf875780962b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7ae8ea26752683c5940ffdc28647c87216406e5
          - code comment english precision
            
            Change-Id: Ic0a5f84fa328c7cc5e07d0088eeed1b533c28dc3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/181230
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2025-02-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c750e4fbff376152e793ff3ca43e808cd573b0bf]

        use the pam as seen in MSWordExportBase::ExportDocument
        
        paranoia wrt:
        
        commit 97939394589d6cc75bfbb0a0a8bd3988406b623f
            defer creating SwMSConvertControls until its needed
        
        so guaranteed to be no change in practice
        
        Change-Id: I0d35b735826dcd6f6bbf2a24af6b7baa78781831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181233
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6e1026cacada6056f2be6b74baf426c984305867]

        external/firebird: Avoid ODR violation issues from sanitizer builds
        
        My local ASan/UBSan builds of d37c60c5e2b793c0934d431e59c8cb3ff1a170b6
        "external/firebird: Drop -fno-rtti from sanitizer builds" against LLVM 21 trunk
        had been fine, but <https://ci.libreoffice.org/job/lo_ubsan/3459/> against
        lode's LLVM 12.0.1 started to fail with
        
        > ==3374322==ERROR: AddressSanitizer: odr-violation (0x0000007af7a0):
        >   [1] size=16 'typeinfo for Firebird::Exception' /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/firebird/src/common/fb_exception.cpp
        >   [2] size=16 'typeinfo for Firebird::Exception' /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/firebird/src/common/fb_exception.cpp
        > These globals were registered at these points:
        >   [1]:
        >     #0 0x440738 in __asan_register_globals.part.0 /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360:3
        >     #1 0x68237b in asan.module_ctor (/workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql+0x68237b)
        >
        >   [2]:
        >     #0 0x440738 in __asan_register_globals.part.0 /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360:3
        >     #1 0x7f5ccdec01ab in asan.module_ctor (/workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2+0x9b41ab)
        
        What appears to make a difference there is
        <https://github.com/llvm/llvm-project/commit/1ada819c237bf724e6eaa1c82b2742e3eb57a5d5>
        "[asan] Default to -fsanitize-address-use-odr-indicator for non-Windows", first
        appearing in LLVM 16:  My local ASan/UBSan LLVM 21 trunk build, which builds
        external/firebird fine, has
        
        > 0000000000ee5166 B __odr_asan_gen__ZTIN8Firebird9ExceptionE
        > 000000000045b960 D _ZTIN8Firebird9ExceptionE
        
        in workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql and
        
        > 0000000000e49920 b __odr_asan_gen__ZTIN8Firebird9ExceptionE
        > 0000000000b9d100 D _ZTIN8Firebird9ExceptionE
        
        in workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2, but
        when I rebuild it with -fno-sanitize-address-use-odr-indicator, it has only
        
        > 000000000045bbc0 D _ZTIN8Firebird9ExceptionE
        
        in workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql and only
        
        > 0000000000b9d1c0 D _ZTIN8Firebird9ExceptionE
        
        in workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2, and
        fails the same way as <https://ci.libreoffice.org/job/lo_ubsan/3459/>.
        
        So make the "Drop -fno-rtti" patch depend on Clang >= 16 (recorded, for
        simplicity, with a bespoke new CLANG_16 config_host.mk variable).
        
        Change-Id: I70a8ce8eb535265d592d470718d6b3a6765d5bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181235
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [a4cde4fa1a18a99e6eb808ed9c00cad8a56081fe]

        editbrowsebox.cxx: Drop extra indentation level
        
        Drop the extra level of indentation due to the namespace
        in that file.
        
        It isn't used in the other source file
        (svtools/source/brwbox/editbrowsebox.cxx)
        of the same EditBrowseBox class either.
        
        Change-Id: I6d21e3fe63e37c277c83168fe8a1b24f2ab5f33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181220
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [e109310429411a4d7621c1418ea9823563b9b9a2]

        browsebox a11y: Use reference to concrete EditBrowseBoxTableCellAccess
        
        Change-Id: Ie564f4e26caa76dd8c400219ea5d509a6abe8106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181218
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [cc8d3dac879ce8be66b785efdfe62be4ca6676bd]

        browsebox a11y: Drop AccessibleBrowseBoxAccess
        
        So far, AccessibleBrowseBoxAccess was the XAccessible
        implementation for the BrowseBox (in svtools) while
        AccessibleBrowseBox is the XAccessibleContext implementation
        that AccessibleBrowseBoxAccess::getAccessibleContext() returns.
        
        AccessibleBrowseBoxAccess has some additional methods that
        call the corresponding AccessibleBrowseBox methods.
        
        Drop AccessibleBrowseBoxAccess and instead let
        AccessibleBrowseBox be the XAccessible and XAccessibleContext
        implementation for BrowseBox at the same time.
        
        AccessibleBrowseBox already implements the XAccessible interface
        (and AccessibleBrowseBox::getAccessibleContext() returns a reference
        to self) since
        
            Change-Id: I5cc292e86e2549fa15e00edcc417308d18335b9e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 5 16:45:43 2025 +0100
        
                browsebox a11y: Let AccessibleBrowseBox implement XAccessible
        
                Let AccessibleBrowseBox implement the XAccessible
                interface and return a reference to self in
                its XAccessible::getAccessibleContext implementation.
        
                The AccessibleTabListBox subclass was already doing
                this. Drop the override (that didn't hold the mutex
                or check whether the accessible is still alive).
        
                This also prepares for merging AccessibleBrowseBoxAccess
                into AccessibleBrowseBox into an upcoming commit.
        
        Now that AccessibleBrowseBox is always its own "creator"
        (i.e. the XAccessible whose associated XAccessibleContext it
        is), there's no more need to keep track of who created it, so
        drop AccessibleBrowseBox::m_aCreator and simply use `this`
        instead.
        
        Change-Id: I51099442d600dce0db78a78d37b1f4709c6f95b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181217
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [9562c1a3560f8522181bbb3f25ec0b8bda035be1]

        browsebox a11y: Use "x" prefix for rtl::Reference
        
        Change-Id: I6f187d97989a4989ac7a32ce994b16fac2d2974c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181208
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [783e6b70b4fd5a78dabf6677301a116c50a18e0d]

        browsebox a11y: Drop IAccessibleBrowseBox iface
        
        Switch BrowseBox::m_pAccessible from a Reference
        to the IAccessibleBrowseBox iface to a Reference
        to the specific AccessibleBrowseBoxAccess subclass
        and drop the IAccessibleBrowseBox interface.
        
        Change-Id: Iecc518232eceecc922b69b8c3a4c89f27e6e4c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181207
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [eca4b449dc9b5fe689e429ec449fefe8198fc2b3]

        browsebox: Drop unnecessary const_cast
        
        Change-Id: Iad7851be5b3f077128a8197626070a09b43c057c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181222
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Miklos Vajna  <vmiklos@collabora.com>  [7192e3e5d6f875e4e9d2eda6de9e1f31c4917f62]

        writerfilter: fix crash in DomainMapperTableHandler::endTable()
        
        Crashreport signature:
        
        /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_stack.h:234: std::stack<_Tp, _Sequence>::reference std::stack<_Tp, _Sequence>::top() [with _Tp = writerfilter::dmapper::TextAppendContext; _Sequence = std::deque<writerfilter::dmapper::TextAppendContext, std::allocator<writerfilter::dmapper::TextAppendContext> >; reference = writerfilter::dmapper::TextAppendContext&]: Assertion '!this->empty()' failed.
        
        SIG   Fatal signal received: SIGABRT code: 18446744073709551610 for address: 0x7300004d65
        
        program/libwriterfilterlo.so
              writerfilter::dmapper::DomainMapper_Impl::GetTopTextAppend()
                      /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_stack.h:234
        program/libwriterfilterlo.so
              writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int)
                      workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/text/XTextAppendAndConvert.hpp:23
        program/libwriterfilterlo.so
              writerfilter::dmapper::TableManager::resolveCurrentTable()
                      include/tools/ref.hxx:56
        program/libwriterfilterlo.so
              writerfilter::dmapper::TableManager::endLevel()
                      writerfilter/source/dmapper/TableManager.cxx:461
        
        It seems the trouble is that DomainMapperTableHandler::endTable() calls
        GetTopTextAppend() unconditionally, which asserts that the text append
        stack is non-empty. GetCurrentXText() already check if this stack is
        empty, so use that to check for emptyness and only then get the top of
        the stack. Later DomainMapperTableHandler::endTable() already checks if
        xTextAppendAndConvert is an empty reference or not.
        
        Change-Id: Ibb377cb03f8beaed9b3c9d45e322c8ad1f9d26c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181231
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [fb591ac1b7debcd90cfa9d35fb5392599de9bb2e]

        tdf#130857 qt weld: Convert accelerator when setting label text
        
        Without this, the label in the second dialog mentioned
        in the commit message of
        
            Change-Id: Icab9171faa2a011e65796f468f29ee1517ae4f01
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 5 13:06:01 2025 +0100
        
                tdf#130857 qt weld: Support Base dialogs asking to save changes
        
        would have a label containing the literal text "~Table Name"
        instead of "Table Name" with the "T" used as accelerator.
        
        Change-Id: Iae3cc053216c6cb565cc5137fbfd7e58c19f2089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181163
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [d423dcf8ea0009214eda772e333960084887ef52]

        tdf#130857 qt weld: Support Base dialogs asking to save changes
        
        Declare support for the 2 dialogs that can be triggered like this:
        
        1) Start Base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."
        3) In the table that shows up, do any changes.
        4) close window
        -> A dialog asking whether changes should be saved shows up.
          (This is "dbaccess/ui/tabledesignsavemodifieddialog.ui".)
        5) Select "Yes"
        -> A dialog allowing to enter a name for the table
          shows up.
          (This is "dbaccess/ui/savedialog.ui".)
        
        This means that native Qt widgets are used for these dialogs
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: Icab9171faa2a011e65796f468f29ee1517ae4f01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181162
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [14f86f5458edd0969a649e637aff818da9e189e1]

        Fix typo
        
        Change-Id: I6db42f1dfc93f46d0fbc4ac82125be2c80cb8d93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181018
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c08d8ef27a72c30bf2a70d90b200df53ca287b6]

        Fix typo
        
        Change-Id: Ic689d0302d4fef4cd6454ccbac36e8895f9075af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181125
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-02-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [18e708c65a6b18ac99a17a8e31732ad3ed5d1ac7]

        Fix typo
        
        Change-Id: I6661da0bba0d34e2922a3e89875708888978143d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181067
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [775331abeeb478bec4943f0ec3a233f76dd83aaa]

        Fix typo
        
        Change-Id: I18b25eb81f557e92d3a19dec6a917a14649b8b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181223
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [51dc6397e740b49038d15f7e0f1e9d3970e9d5a3]

        browsebox a11y: Call AccessibleBrowseBox* ctors directly
        
        No longer use the AccessibleFactory for creating the
        accessible objects.
        
        In the past, this was necessary to break a dependency
        cycle, but that's no longer the case, see
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        Mark copy ctors and operator= as deleted.
        Otherwise, the Windows build fails like this [1]:
        
            [build CXX] vcl/source/accessibility/AccessibleBrowseBoxTableCell.cxx
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\cppuhelper/implbase.hxx(152): error C2280: 'AccessibleBrowseBoxCell::AccessibleBrowseBoxCell(const AccessibleBrowseBoxCell &)': attempting to reference a deleted function
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxCell.hxx(61): note: see declaration of 'AccessibleBrowseBoxCell::AccessibleBrowseBoxCell'
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxCell.hxx(61): note: 'AccessibleBrowseBoxCell::AccessibleBrowseBoxCell(const AccessibleBrowseBoxCell &)': function was explicitly deleted
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxTableCell.hxx(100): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible>>(cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible> &&)' being compiled
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxTableCell.hxx(100): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible>>(cppu::ImplInheritanceHelper<AccessibleBrowseBoxCell,com::sun::star::accessibility::XAccessibleText,com::sun::star::accessibility::XAccessible> &&)' being compiled
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\cppuhelper/implbase.hxx(151): error C2248: 'AccessibleBrowseBoxCell::AccessibleBrowseBoxCell': cannot access private member declared in class 'AccessibleBrowseBoxCell'
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxCell.hxx(61): note: see declaration of 'AccessibleBrowseBoxCell::AccessibleBrowseBoxCell'
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/AccessibleBrowseBoxCell.hxx(30): note: see declaration of 'AccessibleBrowseBoxCell'
            make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/vcl/source/accessibility/AccessibleBrowseBoxTableCell.o] Error 2
            make[1]: *** Waiting for unfinished jobs....
        
        [1] https://ci.libreoffice.org/job/gerrit_windows/193155/console
        
        Change-Id: Ib24fc6b7f85e4ca575cb2505c172243da2cfb8b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181206
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [561876dc1b48be5e077d87b27892ab0b0f0df946]

        a11y: Move AccessibleBrowseBox* headers to global vcl include dir
        
        AccessibleBrowseBox and related classes are the a11y
        implementations for both, SvHeaderTabListBox
        (see SvHeaderTabListBox::CreateAccessible) and
        BrowseBox (see BrowseBox::CreateAccessible).
        
        The former is in the vcl module, but the latter
        is in svtools. Move the headers to include/vcl/accessibility
        to be able to use the classes directly from both modules
        in upcoming commits instead of having to use the AccessibleFactory
        to create the accessible objects.
        
        Change-Id: Idfd5cf2d605f8413f4fa4091ae7c5e4df8cc0cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181202
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [eb0f454482d7c67b32f1ac0e99d73ced1927fd32]

        browsebox a11y: Let AccessibleBrowseBox implement XAccessible
        
        Let AccessibleBrowseBox implement the XAccessible
        interface and return a reference to self in
        its XAccessible::getAccessibleContext implementation.
        
        The AccessibleTabListBox subclass was already doing
        this. Drop the override (that didn't hold the mutex
        or check whether the accessible is still alive).
        
        This also prepares for merging AccessibleBrowseBoxAccess
        into AccessibleBrowseBox into an upcoming commit.
        
        Change-Id: I5cc292e86e2549fa15e00edcc417308d18335b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181201
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [1c024bfa9d54eace41ae196334bbabb4fa34ee0b]

        browsebox a11y: Use ImplInheritanceHelper for cell
        
        Change-Id: I523f98b1e374e8eb56a52171eccf707c64550364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181200
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [1ce6fe0b50b1f1bbb2112d95fa2a9a733c6e5d25]

        sw: Drop SwEntryBrowseBox_Base typedef
        
        Change-Id: Ib7dee3649271ac84df62c12a0b0fb218944f8a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181199
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [2d84a5f411e684a1c1955cf02781dd0336f5b85c]

        browsebox a11y: Convert local helper to class method
        
        This removes the need to pass `this` and aligns it more
        with how it's handled for header bars and the table
        (BrowseBox::getAccessibleHeaderBar, BrowseBox::getAccessibleTable).
        
        Change-Id: I2b4665eb6b4405be3b06a524002e0d24010b2f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181198
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [1fc76c3ef0e9ed16dbfe4b25c6f40fb2799ae334]

        a11y: Drop now unused IAccessibleTableProvider::GetWindowExtentsAbsolute
        
        Change-Id: I39b3c5ec28e025cfdb3b3da733b6e377752eb06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181197
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [5737b61ec6ff9ec1091192cf33d985759b0f0475]

        browsebox: Convert dispatch ID defines to enum class
        
        Convert the `BROWSER_*` defines in include/svtools/brwbox.hxx
        to a new enum class BrowserDispatchId.
        
        The specific integer values that were used
        don't seem to have any particular meaning, so
        just drop them.
        
        Add default case that does nothing in BrowseBox::Dispatch
        to address
        
            /home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox2.cxx:1779:13: error: 5 enumeration values not handled in switch: 'NONE', 'CURSORENDOFSCREEN', 'CURSORTOPOFSCREEN'... [-Werror,-Wswitch]
             1779 |     switch (eId)
                  |             ^~~
            1 error generated.
        
        Change-Id: Ibb023ec13ee2c10a0fc0ef7abe1371dbd856e735
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181167
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [6d87fa009153ee32bc2b5a8e97fa0072d13f64ef]

        browsebox a11y: Drop '_bOnScreen' param
        
        It's always `false` since
        
            commit 261dd0fd48b2e2c284485c25feade854154595aa
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 31 11:40:09 2025 +0100
        
                browsebox a11y: Use comphelper::OAccessibleComponentHelper
        
        , so dro the param altogether to simplify code.
        
        Change-Id: If184b3103f87a7d5391ed97b673ed10ed9953f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181166
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [ef5e4af1ce07dcbbb2c58864b0a5c6eb674cc28d]

        a11y: Rename IAccessibleTableProvider::GetFieldRectPixel
        
        to IAccessibleTableProvider::calcFieldRectPixel.
        
        This aligns the naming with the
        IAccessibleTableProvider::calcHeaderRect
        and IAccessibleTableProvider::calcHeaderRect
        methods and prevents a name clash with the
        other BrowseBox::GetFieldRectPixel variant
        only taking 3 params in an upcoming commit that
        will drop the `_bOnScreen` param from the now
        renamed method.
        
        Change-Id: I156412f825a187d86390325050147cd84e934251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181165
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [ad226c0fdf76a22f992f960e249b37ccf24feb34]

        browsebox a11y: Merge helper function into only caller
        
        Merge `getRectangle` into AccessibleBrowseBoxHeaderCell::implGetBoundingBox
        and simplify a bit.
        
        Change-Id: If432ec8fcb64645d293cead1d9a97b98d31c19a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181164
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [71d1432714b7aba0a10ca5d072c87e46ec325271]

        browsebox a11y: Use recursive mutex
        
        Fixes a deadlock seen for this scenario
        with the qt6 VCL plugin on Linux:
        
        1) start Orca
        2) Start Base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."
        3) click around in the table, use Tab key to move focus
        
        AccessibleBrowseBoxAccess::commitEvent (frame 20 in the below
        backtrace) locks the mutex, and then
        AccessibleBrowseBoxAccess::getAccessibleContext (frame 8) tries to
        acquire the mutex again and deadlocks.
        
        Locking in AccessibleBrowseBoxAccess::commitEvent was added in
        
            commit 67158da00e965c90495bb4f339ea25bbec898c60
            Date:   Fri Oct 4 14:22:22 2024 +0100
        
                cid#1608061 Data race condition
        
                and
        
                cid#1607995 Data race condition
        
        Backtrace:
        
            Thread 1 "soffice.bin" received signal SIGINT, Interrupt.
            futex_wait (futex_word=0x7fffd804ba30, expected=2, private=0) at ../sysdeps/nptl/futex-internal.h:146
            warning: 146    ../sysdeps/nptl/futex-internal.h: No such file or directory
            (gdb) bt
            #0  futex_wait (futex_word=0x7fffd804ba30, expected=2, private=0) at ../sysdeps/nptl/futex-internal.h:146
            #1  __GI___lll_lock_wait (futex=futex@entry=0x7fffd804ba30, private=0) at ./nptl/lowlevellock.c:49
            #2  0x00007ffff789f3a2 in lll_mutex_lock_optimized (mutex=0x7fffd804ba30) at ./nptl/pthread_mutex_lock.c:48
            #3  ___pthread_mutex_lock (mutex=0x7fffd804ba30) at ./nptl/pthread_mutex_lock.c:93
            #4  0x00007fffee0d742f in __gthread_mutex_lock (__mutex=0x7fffd804ba30) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/x86_64-linux-gnu/c++/14/bits/gthr-default.h:762
            #5  0x00007fffee0d9915 in std::mutex::lock (this=0x7fffd804ba30) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_mutex.h:113
            #6  0x00007fffee0d98e4 in std::unique_lock<std::mutex>::lock (this=0x7fffffff3b48) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_lock.h:147
            #7  0x00007fffee0d8108 in std::unique_lock<std::mutex>::unique_lock (this=0x7fffffff3b48, __m=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_lock.h:73
            #8  0x00007fffee0d729d in AccessibleBrowseBoxAccess::getAccessibleContext (this=0x7fffd804ba00) at /home/michi/development/git/libreoffice/vcl/source/accessibility/AccessibleBrowseBox.cxx:281
            #9  0x00007fffee0d7404 in non-virtual thunk to AccessibleBrowseBoxAccess::getAccessibleContext() () at /home/michi/development/git/libreoffice/instdir/program/libvcllo.so
            #10 0x00007fffe42c3b8c in QtAccessibleWidget::getAccessibleContextImpl (this=0x7fffd804b9a0) at vcl/qt6/../qt5/QtAccessibleWidget.cxx:93
            #11 0x00007fffe42c451d in QtAccessibleWidget::childCount (this=0x7fffd804b9a0) at vcl/qt6/../qt5/QtAccessibleWidget.cxx:149
            #12 0x00007fffe290e9d5 in AtSpiAdaptor::notifyAboutCreation (this=0x555556916e10, interface=0x7fffd8051df0) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1403
            #13 0x00007fffe290ad18 in AtSpiAdaptor::notify (this=0x555556916e10, event=0x7fffffff5e40) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:971
            #14 0x00007fffe2966779 in QSpiAccessibleBridge::notifyAccessibilityUpdate (this=0x5555568aab30, event=0x7fffffff5e40) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/linux/qspiaccessiblebridge.cpp:85
            #15 0x00007fffe28e5c89 in QAccessible::updateAccessibility (event=0x7fffffff5e40) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessible.cpp:943
            #16 0x00007fffe42bb466 in QtAccessibleEventListener::notifyEvent (this=0x555557d6de30, rEvent=...) at vcl/qt6/../qt5/QtAccessibleEventListener.cxx:231
            #17 0x00007ffff60ec617 in comphelper::AccessibleEventNotifier::addEvent (_nClient=288, _rEvent=...) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:256
            #18 0x00007ffff60e8107 in comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent (this=0x55555be2f520, _nEventId=7, _rOldValue=uno::Any(void), _rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": ...), nIndexHint=-1)
                at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:127
            #19 0x00007fffee0dd7c9 in AccessibleBrowseBoxBase::commitEvent (this=0x55555be2f520, _nEventId=7, _rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": ...), _rOldValue=uno::Any(void))
                at /home/michi/development/git/libreoffice/vcl/source/accessibility/AccessibleBrowseBoxBase.cxx:310
            #20 0x00007fffee0d8fb0 in AccessibleBrowseBoxAccess::commitEvent (this=0x7fffd804ba00, nEventId=7, rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": ...), rOldValue=uno::Any(void))
                at vcl/inc/accessibility/AccessibleBrowseBox.hxx:250
            #21 0x00007ffff08806b6 in BrowseBox::commitBrowseBoxEvent (this=0x55555bdc8bf0, _nEventId=7, _rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": ...), _rOldValue=uno::Any(void))
                at /home/michi/development/git/libreoffice/svtools/source/brwbox/brwbox3.cxx:406
            #22 0x00007ffff08a090b in svt::EditBrowseBox::implCreateActiveAccessible (this=0x55555bdc8bf0) at /home/michi/development/git/libreoffice/svtools/source/brwbox/editbrowsebox2.cxx:87
            #23 0x00007ffff089c7af in svt::EditBrowseBox::ActivateCell (this=0x55555bdc8bf0, nRow=0, nCol=1, bCellFocus=true) at /home/michi/development/git/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:945
            #24 0x00007ffff089e6c0 in svt::EditBrowseBox::ActivateCell (this=0x55555bdc8bf0) at include/svtools/editbrowsebox.hxx:1029
            #25 0x00007ffff089b291 in svt::EditBrowseBox::implActivateCellOnMouseEvent (this=0x55555bdc8bf0, _rEvt=..., _bUp=true) at /home/michi/development/git/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:482
            #26 0x00007ffff089b43c in svt::EditBrowseBox::MouseButtonUp (this=0x55555bdc8bf0, rEvt=...) at /home/michi/development/git/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:468
            #27 0x00007ffff08876ad in BrowserDataWin::MouseButtonUp (this=0x555556fed350, rEvt=...) at /home/michi/development/git/libreoffice/svtools/source/brwbox/datwin.cxx:490
            #28 0x00007fffee4b1055 in ImplHandleMouseEvent (xWindow=..., nSVEvent=NotifyEventType::MOUSEBUTTONUP, bMouseLeave=false, nX=73, nY=89, nMsgTime=10536810, nCode=1, nMode=(MouseEventModifiers::SIMPLECLICK | MouseEventModifiers::SELECT))
                at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:719
            #29 0x00007fffee4b5571 in ImplHandleSalMouseButtonUp (pWindow=0x7fffd80482c0, pEvent=0x7fffffff8118) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2351
            #30 0x00007fffee4b4280 in ImplWindowFrameProc (_pWindow=0x7fffd80482c0, nEvent=SalEvent::MouseButtonUp, pEvent=0x7fffffff8118) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2700
            #31 0x00007fffe435910c in SalFrame::CallCallback (this=0x555556abc050, nEvent=SalEvent::MouseButtonUp, pEvent=0x7fffffff8118) at vcl/inc/salframe.hxx:311
            #32 0x00007fffe43563b5 in QtFrame::CallCallback (this=0x555556abc040, nEvent=SalEvent::MouseButtonUp, pEvent=0x7fffffff8118) at vcl/inc/qt6/../qt5/QtFrame.hxx:235
            #33 0x00007fffe445475a in QtWidget::handleMouseButtonEvent (rFrame=..., pEvent=0x7fffffff93c0) at vcl/qt6/../qt5/QtWidget.cxx:117
            #34 0x00007fffe4454a11 in QtWidget::mouseReleaseEvent (this=0x7fffd8048d90, pEvent=0x7fffffff93c0) at vcl/qt6/../qt5/QtWidget.cxx:128
            #35 0x00007fffe149f8ad in QWidget::event (this=0x7fffd8048d90, event=0x7fffffff93c0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:8964
            #36 0x00007fffe44569ae in QtWidget::event (this=0x7fffd8048d90, pEvent=0x7fffffff93c0) at vcl/qt6/../qt5/QtWidget.cxx:678
            #37 0x00007fffe13e2e20 in QApplicationPrivate::notify_helper (this=0x555555577ae0, receiver=0x7fffd8048d90, e=0x7fffffff93c0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3305
            #38 0x00007fffe13e4af2 in QApplication::notify (this=0x555555564d60, receiver=0x7fffd8048d90, e=0x7fffffff93c0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2782
            #39 0x00007fffe344b419 in QCoreApplication::notifyInternal2 (receiver=0x7fffd8048d90, event=0x7fffffff93c0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #40 0x00007fffe344c119 in QCoreApplication::sendSpontaneousEvent (receiver=0x7fffd8048d90, event=0x7fffffff93c0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1566
            #41 0x00007fffe13e3747 in QApplicationPrivate::sendMouseEvent
                (receiver=0x7fffd8048d90, event=0x7fffffff93c0, alienWidget=0x7fffd8048d90, nativeWidget=0x555556f2f660, buttonDown=0x7fffe1fca488 <qt_button_down>, lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false)
                at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2363
            #42 0x00007fffe14ded48 in QWidgetWindow::handleMouseEvent (this=0x5555577f5b40, event=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:669
            #43 0x00007fffe14dd555 in QWidgetWindow::event (this=0x5555577f5b40, event=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:292
            #44 0x00007fffe13e2e20 in QApplicationPrivate::notify_helper (this=0x555555577ae0, receiver=0x5555577f5b40, e=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3305
            #45 0x00007fffe13e6d3d in QApplication::notify (this=0x555555564d60, receiver=0x5555577f5b40, e=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3255
            #46 0x00007fffe344b419 in QCoreApplication::notifyInternal2 (receiver=0x5555577f5b40, event=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #47 0x00007fffe344c119 in QCoreApplication::sendSpontaneousEvent (receiver=0x5555577f5b40, event=0x7fffffffa498) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1566
            #48 0x00007fffe2285ca2 in QGuiApplicationPrivate::processMouseEvent (e=0x7fffd0001560) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2485
            #49 0x00007fffe2284e66 in QGuiApplicationPrivate::processWindowSystemEvent (e=0x7fffd0001560) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2212
            #50 0x00007fffe236d57d in QWindowSystemInterface::sendWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1113
            #51 0x00007fffe236d42e in QWindowSystemInterface::flushWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1082
            #52 0x00007fffdf8b2685 in QtWaylandClient::QWaylandDisplay::flushRequests (this=0x5555555c8390) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:526
            #53 0x00007fffdf8ce4e5 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}::operator()() const (this=0x7fffffffa9a0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #54 0x00007fffdf8ce40d in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)::{lambda()#1}&&) (args=0x7fffd0002f98, fn=...) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #55 0x00007fffdf8ce32f in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay::*)()>::call(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**) (f=(void (QtWaylandClient::QWaylandDisplay::*)(class QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf8b2640 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555c8390, arg=0x7fffd0002f98)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #56 0x00007fffdf8ce2a1 in QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay::*)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay::*)(), QtWaylandClient::QWaylandDisplay*, void**)
                (f=(void (QtWaylandClient::QWaylandDisplay::*)(class QtWaylandClient::QWaylandDisplay * const)) 0x7fffdf8b2640 <QtWaylandClient::QWaylandDisplay::flushRequests()>, o=0x5555555c8390, arg=0x7fffd0002f98)
                at qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #57 0x00007fffdf8ce1cb in QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x5555555e1390, r=0x5555555c8390, a=0x7fffd0002f98, ret=0x0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #58 0x00007fffe3461362 in QtPrivate::QSlotObjectBase::call (this=0x5555555e1390, r=0x5555555c8390, a=0x7fffd0002f98) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #59 0x00007fffe350ad5c in QMetaCallEvent::placeMetaCall (this=0x7fffd0002f50, object=0x5555555c8390) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:620
            #60 0x00007fffe350cab1 in QObject::event (this=0x5555555c8390, e=0x7fffd0002f50) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1429
            #61 0x00007fffe13e2e20 in QApplicationPrivate::notify_helper (this=0x555555577ae0, receiver=0x5555555c8390, e=0x7fffd0002f50) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3305
            #62 0x00007fffe13e6d3d in QApplication::notify (this=0x555555564d60, receiver=0x5555555c8390, e=0x7fffd0002f50) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3255
            #63 0x00007fffe344b419 in QCoreApplication::notifyInternal2 (receiver=0x5555555c8390, event=0x7fffd0002f50) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #64 0x00007fffe344c089 in QCoreApplication::sendEvent (receiver=0x5555555c8390, event=0x7fffd0002f50) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1552
            #65 0x00007fffe344cfc8 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x55555559f110) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1892
            #66 0x00007fffe344becc in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1746
            #67 0x00007fffe3a3d4a1 in postEventSourceDispatch (s=0x5555555f0f80) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #68 0x00007fffea10b81f in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #69 0x00007fffea10da57 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #70 0x00007fffea10e1c0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #71 0x00007fffe3a3c6db in QEventDispatcherGlib::processEvents (this=0x555555568dc0, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #72 0x00007fffe2b7a148 in QPAEventDispatcherGlib::processEvents (this=0x555555568dc0, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #73 0x00007fffe4376a82 in QtInstance::ImplYield (this=0x5555555f5a00, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:485
            #74 0x00007fffe4379d51 in QtInstance::DoYield (this=0x5555555f5a00, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:496
            #75 0x00007fffeec869b6 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #76 0x00007fffeec862cf in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #77 0x00007fffeec860b0 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #78 0x00007ffff7b287f9 in desktop::Desktop::Main (this=0x7fffffffd5d0) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1679
            #79 0x00007fffeeca7e36 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #80 0x00007fffeeca9a29 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #81 0x00007ffff7ba20da in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #82 0x0000555555555a6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #83 0x0000555555555a47 in main (argc=2, argv=0x7fffffffd7d8) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Id3832663f5c5c66a4d624054fee4d48219732b95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181155
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [ced891245d29e83905ab2849e63ff52eb588f139]

        browsebox a11y: Don't report EditBrowseBoxTableCell as its own parent
        
        The EditBrowseBoxTableCell ctor's first param is the
        parent, the second one is the owner.
        
        The EditBrowseBoxTableCellAccess is the owner, but not the
        parent, which means that the params were passed in the
        wrong order.
        
        Since EditBrowseBoxTableCellAccess::getAccessibleContext
        returns the EditBrowseBoxTableCell, this would result
        in the EditBrowseBoxTableCell reporting itself as
        its own parent.
        
        This results in infinite recursion when trying to walk
        up the a11y hierarchy starting at the EditBrowseBoxTableCell.
        
        Switch the order of the first 2 params to fix that.
        
        This addresses a preexisting issue that was now
        triggering a crash as described in
        
            commit 261dd0fd48b2e2c284485c25feade854154595aa
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 31 11:40:09 2025 +0100
        
                browsebox a11y: Use comphelper::OAccessibleComponentHelper
        
                [...]
        
                Sample scenario for BrowseBox:
        
                1) Start Base, create a new database
                2) With the "Tables" section enabled, click on
                   "Create Table in Design View..."
                3) in Accerciser's treeview of the LO a11y, navigate
                   through the a11y objects of the table and its children
        
                A quick test with Orca [...] triggered
                a crash for the BrowseBox case.
        
                The underlying problem is a preexisting issue however, and
                will be addressed in an upcoming commit.
        
        Sample backtrace:
        
            Thread 1 received signal SIGSEGV, Segmentation fault.
            0x00007fd5a4700cde in std::scoped_lock<std::mutex>::scoped_lock (this=0x7ffe58c71100, __m=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:787
            787           { _M_device.lock(); }
            (rr) bt
            #0  0x00007fd5a4700cde in std::scoped_lock<std::mutex>::scoped_lock (this=0x7ffe58c71100, __m=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:787
            #1  0x00007fd5a47402e4 in cppu::getTypeEntries
                (cd=0x7fd59e2da610 <cppu::detail::ImplClassData<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>, com::sun::star::accessibility::XAccessibleComponent>::operator()()::s_cd>) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase_ex.cxx:69
            #2  0x00007fd5a473f399 in cppu::queryDeepNoXInterface
                (pDemandedTDR=0x55ca49389ab0, cd=0x7fd59e2da610 <cppu::detail::ImplClassData<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>, com::sun::star::accessibility::XAccessibleComponent>::operator()()::s_cd>, that=0x55ca4a156260) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase_ex.cxx:148
            #3  0x00007fd5a473f917 in cppu::ImplHelper_queryNoXInterface
                (rType=invalid uno::Type, cd=0x7fd59e2da610 <cppu::detail::ImplClassData<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>, com::sun::star::accessibility::XAccessibleComponent>::operator()()::s_cd>, that=0x55ca4a156260) at /home/michi/development/git/libreoffice/cppuhelper/source/implbase_ex.cxx:225
            #4  0x00007fd59ccdac55 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>::queryInterface (this=0x55ca4a156260, aType=invalid uno::Type)
                at include/cppuhelper/implbase.hxx:165
            #5  0x00007fd59ccd8375 in cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper, com::sun::star::awt::XFocusListener, com::sun::star::lang::XServiceInfo>::queryInterface (this=0x55ca4a156260, aType=invalid uno::Type)
                at include/cppuhelper/implbase.hxx:166
            #6  0x00007fd59ccfab51 in EditBrowseBoxTableCell::queryInterface (this=0x55ca4a156260, _rType=invalid uno::Type) at /home/michi/development/git/libreoffice/vcl/source/accessibility/accessibleeditbrowseboxcell.cxx:62
            #7  0x00007fd59ccd9ac5 in com::sun::star::uno::BaseReference::iquery (pInterface=0x55ca4a156260, rType=invalid uno::Type) at include/com/sun/star/uno/Reference.hxx:59
            #8  0x00007fd59cce8739 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::iquery (pInterface=0x55ca4a156260) at include/com/sun/star/uno/Reference.hxx:74
            #9  0x00007fd59ccfe39c in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::query (rRef=...) at include/com/sun/star/uno/Reference.hxx:380
            #10 0x00007fd59ccfd0b6 in com::sun::star::uno::WeakReference<com::sun::star::accessibility::XAccessibleContext>::operator com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> (this=0x55ca4a14a1e0)
                at include/cppuhelper/weakref.hxx:218
            #11 0x00007fd59ccfc4d1 in EditBrowseBoxTableCellAccess::getAccessibleContext (this=0x55ca4a14a1a0) at /home/michi/development/git/libreoffice/vcl/source/accessibility/accessibleeditbrowseboxcell.cxx:202
            #12 0x00007fd59ccfc6a4 in non-virtual thunk to EditBrowseBoxTableCellAccess::getAccessibleContext() () at /home/michi/development/git/libreoffice/instdir/program/libvcllo.so
            #13 0x00007fd5a4ce8642 in comphelper::OCommonAccessibleComponent::implGetParentContext (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:208
            #14 0x00007fd5a4ce8bdb in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:238
            #15 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #16 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #17 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #18 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #19 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #20 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #21 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #22 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #23 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #24 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #25 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #26 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #27 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #28 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #29 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #30 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #31 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #32 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #33 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #34 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #35 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #36 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #37 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #38 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #39 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #40 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #41 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #42 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #43 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #44 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #45 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #46 0x00007fd5a4ce90a9 in non-virtual thunk to comphelper::OAccessibleComponentHelper::getLocationOnScreen() () at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            #47 0x00007fd5a4ce8cb6 in comphelper::OCommonAccessibleComponent::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:242
            #48 0x00007fd5a4ce9075 in comphelper::OAccessibleComponentHelper::getLocationOnScreen (this=0x55ca4a156260) at /home/michi/development/git/libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:285
            [...]
        
        Change-Id: If8b0edba80c804ba621c808495358d6358be96ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181154
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [738450ff592d069f20092c1c31071fe4ee9414a4]

        browsebox a11y: Use comphelper::OAccessibleComponentHelper
        
        Let AccessibleBrowseBoxBase derive from
        comphelper::OAccessibleComponentHelper instead
        of duplicating much of the logic for notifying of
        a11y events and location/bounds handling.
        
        The involved classes are the a11y classes for both,
        BrowseBox (see BrowseBox::CreateAccessible)
        and SvHeaderTabListBox (see SvHeaderTabListBox::CreateAccessible).
        
        With the fixes to the involved classes from previous
        commits in place, a quick test for both of these with
        Accerciser and the qt6 VCL plugin didn't show any change in
        behavior with this commit in place.
        
        Sample scenario for SvHeaderTabListBox:
        "Tools" -> "Options" -> "Advanced" -> "Open Expert Configuration"
        
        Sample scenario for BrowseBox:
        
        1) Start Base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."
        3) in Accerciser's treeview of the LO a11y, navigate
           through the a11y objects of the table and its children
        
        A quick test with Orca also didn't reveal any changes
        in behavior for the expert configuration case, but triggered
        a crash for the BrowseBox case.
        
        The underlying problem is a preexisting issue however, and
        will be addressed in an upcoming commit.
        
        Change-Id: I2a540ade0c5f6a5a82c764de4cef37be556453fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181153
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Michael Weghorn  <m.weghorn@posteo.de>  [855fe539121d5ede59d12dbd3d2537afe67d2b3a]

        browsebox a11y: Fix parent-relative cell coords
        
        Parent-relative coordinates are meant to be
        relative to the immediate parent. The immediate
        parent of the cells is the table, and the immediate
        parent of the AccessibleBrowseBoxTable
        is the AccessibleBrowseBox (which is the a11y
        class for BrowseBox).
        Therefore:
        
        * Don't add the position of the BrowseBox inside
          of its parent widget when relative coords are
          requested.
        
        * In AccessibleBrowseBoxCell::implGetBoundingBox,
          subtract the relative position of the table
          from the result of BrowseBox::GetFieldRectPixel,
          because BrowseBox::GetFieldRectPixel returns the
          relative position within the BrowseBox (i.e.
          the parent's parent), not within the accessible
          parent.
        
        Without this commit, the wrong area would be highlighted
        e.g. for the following scenario when using the gtk3 VCL
        plugin:
        
        1) Start base, create a new database
        2) With the "Tables" section enabled, click on
           "Create Table in Design View..."#
        3) Start Accerciser
        4) in Accerciser's treeview of the LO a11y, navigate
           to the a11y object of the (non-header) table cells
        
        Result: Incorrect area is highlighted on screen, not the
        one actually covered by the cell.
        
        See also
        
            commit 589ead3a6ae776fdbcb426f2817fbb94933a8bf7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 4 17:16:27 2025 +0100
        
                treeview a11y: Fix parent-relative coordinates
        
        for a similar case.
        
        Change-Id: I45154fcb8365d40984b34ea750cff621ddd0331f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181152
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-07  Stephan Bergmann  <sbergman@redhat.com>  [afe00aba4ed19c237fda222dc4afbc13d4615af8]

        Disambiguate pattern rules in extras/CustomTarget_autotext{share,user}.mk
        
        One of my builds using make-4.4-3.fc38.x86_64 started to consistently fail now
        with
        
        > [ZIP] autotext/user/mytexts.bau
        > S=... && I=$S/instdir && W=$S/workdir &&  cd $W/CustomTarget/extras/source/autotext/user/mytexts/ && zip -q0X --filesync --must-match $W/CustomTarget/extras/source/autotext/user/mytexts.bau mimetype && zip -qrX --must-match $W/CustomTarget/extras/source/autotext/user/mytexts.bau
        >
        > zip error: Nothing to do! (.../workdir/CustomTarget/extras/source/autotext/user/mytexts.bau)
        > make: *** [.../extras/CustomTarget_autotextshare.mk:3668: .../workdir/CustomTarget/extras/source/autotext/user/mytexts.bau] Error 12
        > make: *** Deleting file '.../workdir/CustomTarget/extras/source/autotext/user/mytexts.bau'
        
        It turned out that this didn't use the expected
        
        > $(call gb_CustomTarget_get_workdir,extras/source/autotext/user)/%.bau
        
        rule in extras/CustomTarget_autotextuser.mk (with a stem of "mytexts"), but
        rather the
        
        > $(call gb_CustomTarget_get_workdir,extras/source/autotext)/%.bau
        
        rule in extras/CustomTarget_autotextshare.mk (with a stem of "user/mytexts").
        But in that mismatched rule the part
        
        > $(call extras_AUTOTEXTSHARE_XMLFILES_RELATIVE,$*)
        
        then expanded to nothing, calling zip with an empty list of files, which makes
        zip fail.
        
        No idea why this apparently worked reliably in the past, and why it started to
        fail for just this one build scenario of mine (it still worked for other builds
        also using make-4.4-3.fc38.x86_64 now).
        
        Change-Id: I643fb0835313cacca5b64416006a3573e559ae78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148946
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-07  Szymon Kłos  <szymon.klos@collabora.com>  [926e16ed65b45615dde46698ebb53d9b93ef5b23]

        jsdialog: toolbar set_item_active method
        
        it was not updating state when toolbar in style sidebar
        was used
        
        Change-Id: Ie1a6f9fe8cc867d30abe2a7359bda42163a0d92e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181170
        (cherry picked from commit 7e5075fea733d68c8167ac33e5ce34d89b50a6a9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181216
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-02-06  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [6042e60d69c40d1f307710e60a278cb286d68603]

        tdf#164745 fix SfxStateCache
        
        Seems I did too much with tdf#162666 by also trying to
        remember invalid and disabled states in pLastItem, so
        went over it again. Also corrected SetVisibleState to
        also take action when disabled item.
        
        Not urgently necessary, but stumbled over it: The items
        used for INVALID_POOL_ITEM and DISABLED_POOL_ITEM were
        based on the same class. Not a problem technically,
        these are 'special' static items that represent a state,
        but comparing them would have claimed these to be equal
        what should not be the case. Thus I based each of these
        on an own derivation of SfxPoolItem.
        
        Change-Id: Ic9dd1a21772bb20b25ed8f7fa929da74edb79e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181194
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-02-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a03edb923d88789c86b68f62e7cc58f89d94a863]

        external/firebird: Drop -fno-rtti from sanitizer builds
        
        Until now, at least Clang silently drops -fsanitize=vptr (which needs RTTI, and
        which is by default included in -fsanitize=undefined) from -fsanitize=undefined,
        that's how external/firebird (which uses -fno-rtti) worked for now with
        -fsanitize=undefined.  However, Clang is planing to break -fsanitize=vptr out of
        -fsanitize=undefined (see
        <https://discourse.llvm.org/t/rfc-remove-vptr-from-undefined/83830> "[RFC]
        Remove `vptr` from `undefined`"), so to be prepared for that I started to do my
        local ASan/UBSan build with an explicit -fsanitize=vptr already.  Which thus
        started to cause
        
        > clang++: error: invalid argument '-fsanitize=vptr' not allowed with '-fno-rtti'
        
        But there appears to be no good reason to do such instrumented builds with
        -fno-rtti anyway.
        
        Change-Id: I9f579846a6c0f666d071d3432d17b266d8ef339e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181213
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [aabf7c44ecdf7162eaa8ceead5fb7147218e6ffc]

        Update the reference rdbs to libreoffice-25.2.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-25.2.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-25.2.0.3/instdir/program/types.rdb \
         .../libreoffice-25.2.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I427bd420baab08fd25fc85f03cf2861372b8a8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181212
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [451f832c8ead47ec6d85093e61f5de984b8cc687]

        sw: test paragraph style clone formatting
        
        Change-Id: Ibdda2ddd1a3ea8c5c7850925582d9efe9353c20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181209
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-06  Gökay Şatır  <gokaysatir@collabora.com>  [3b654bd876070313d6b7e9775fde235fa4eda240]

        Make sure that certain accelerator files are included for LOK case.
        
        Issue:
        Accelerators-unxwnt file is omitted when window system is different than X11.
        This causes LOK to miss the shortcuts which has "install:module="unxwnt"" signature.
        
        This commit adds the required file in linux case.
        
        Change-Id: I4a8425d17a5d95b03a176153506f29a3f393c173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181204
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-06  Manish Bera  <mbera.dev05@gmail.com>  [867d380b0b8e2c59689eb42665c75aad34733bbc]

        tdf#161168 Improve constant repetitive loop thread
        
        Change-Id: I01cebb1bb085c3b390c3ced48c431e8f5dc6bcbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181005
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a3f58f83558d76ae5b32b17d31e2ba0ee39fd2dd]

        defer creating SwMSConvertControls until its needed
        
        which might be never
        
        Change-Id: I9b1baf2098e092020aa8d10b55622c645e15e745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181196
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [311ec7341945365970a4ab35ad8da01ea4d845d0]

        sc: Add test for the fill handle drag and drop
        
        Change-Id: I4625b989800b07bf94db07af0e3feb568e9f015a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181190
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [12ed25fb94fbbee15389467dc6ae02eddf811c34]

        Support Emscripten --with-main-module=
        
        ...i.e., stripping both Calc and Writer, which comes in handy when trying e.g.
        -fsanitize=address and the resulting binary would otherwise become too large.
        
        (Which also unearthed that the StartModule/menubar/menubar.xml had erroneously
        been added to the Writer section of static/CustomTarget_emscripten_fs_image.mk
        ever since 88b94aafc23348238b2d112682bc55719d1978a3 "WASM create and link the
        Emscripten FS image".)
        
        Change-Id: Ia880040f51f15d33ed447a1c69838fa807f48ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181188
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c13e5bf98cb0373d4cf9ac346fb3beb003441673]

        defer getting SvtFilterOptions until its needed
        
        which might be never
        
        Change-Id: I72c71efd754f40371ce77dd507bdd530ec376855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181189
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cd88c0534e11b8357f15428deb0ee52689cb7d5]

        loplugin:unusedmethods
        
        Change-Id: I76e97a932fb6c6d26dc6ad1b9a45dde2dfd7b0a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181182
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [14303b9c1fb1e8618a169779cc03e025dfb40db8]

        SystemDependentData_CairoPath needs to check stroke values
        
        so we don't accidentally re-use invalid data
        
        Change-Id: Ia971dde953044c68f17caab2000ae8089a267096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181181
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2373a13d4ce8f4308ee5de4d06140fc3b716ea29]

        realloc-ing to 0 is common
        
        which frees, we can use a std::vector for this temp storage and
        avoid the reallocation churn.
        
        Change-Id: If7ea4ecb1e6c6a13934b5b9cc59fbb6c80180a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181186
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [796097c546c921b627f5e25f2a4f3d8bc0a6b37c]

        use more ByteSequence in sax
        
        Change-Id: I514b022256acc60c20e430ef6e68815a47859ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181185
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [0843e1df9be6451d3462d0c907de945df30bbf68]

        curl: upgrade to 8.12.0
        
        Downloaded from https://curl.se/download/curl-8.12.0.tar.xz
        
        Windows build fails now with
        WARNING:
        
        The winbuild build system is deprecated and will be removed in
        September 2025 in favor of the CMake build system.
        
        Please see docs/INSTALL-CMAKE.md : "Migrating from winbuild builds"
        
        To use the winbuild build system you must acknowledge this warning by
        setting command line option WINBUILD_ACKNOWLEDGE_DEPRECATED=yes
        
        Makefile.vc(37) : fatal error U1050: The user must acknowledge the deprecation warning to continue.
        Stop.
        
        so building with WINBUILD_ACKNOWLEDGE_DEPRECATED=yes for now until
        the migration from winbuild is done
        
        Change-Id: I5d357b20a93863c81f7637f43abbf7d3167f6dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181173
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe8ef5ec0777e2edcddbaf1ed03280fbac05f67d]

        loplugin:unusedfields
        
        Change-Id: I7c23234f25872fccc0cecc3bdcbae7d47d15951a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181180
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ff1b4491a79644b6efdd6ddac86d5c41196f9f8]

        loplugin:unnecessaryvirtual
        
        Change-Id: I9fc9554f659beea6041b8c64f915c853478aebd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181179
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1b17b71ae30b085e511ab1d262c4f568808b574]

        loplugin:mergeclasses update
        
        Change-Id: Ifb7918120ce827c438784faa5fa7b15dcc126e93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181178
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f1ab3ac05511f64696deb236c071a599f7452899]

        For Emscripten, always assume we run inside soffice
        
        ...and not in some unopkg process.  The checks done here would not work for
        Emscripten, where osl_getExecutableFile returns some generic "./this.program",
        and where we don't set up the office pipe.
        
        Change-Id: Iac3fead3eaa0ac9cfc9dbcf3c01cd9f12df5548b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181161
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-05  Rashesh  <rashesh.padia@collabora.com>  [80c61e88e507a9b4bb93d563f87cf8acd0f656c3]

        lokit: move re-initialization of wordbook to addconfig option
        
        - previously we used to re-initialize it in lo_init because we wanted
        regonize newly added dictionaries but then we again had to re-initailize
        the XDictionary if new dicionary are added after ForKit is created and
        when new LoKit is initialized
        - this patch now does it on "addconfig" setOption which after kit is
        initialized
        
        Change-Id: I115e8ef23e0b3184f35169f6421fe461239c856a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178665
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7daf54c93dbcdfb74a84e2e8e0b7725c67bf0941]

        avoid uno casting cost, and simplify
        
        these are always XStorageBasedLibraryContainers, so transport
        around as that and can avoid casting and some expensive throw/catches
        
        Change-Id: I772efceea3bb4f38d70be0497345f5f81173494c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181156
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [09a351281ad82a6b4fc0a5def77ad3df4a0f031a]

        tdf#156348: sw_uiwriter3: Add unittest
        
        Change-Id: Icaf8ad315035018f6b9e009e486b00c1fc9deceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181157
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [6a680ef017e5a842113f4eb4b555acb51e921f20]

        tdf#158198: sw_uiwriter6: Add unittest
        
        Change-Id: Ie155880ec549ef66d36116db587eef98c06423e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181149
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-05  Oliver Specht  <oliver.specht@cib.de>  [d723103ff8404ddadb3314dd3b67439602799d6c]

        tdf#153192 support read protection in RTF documents
        
        The keyword \readprot sets the document to read-only mode.
        
        Change-Id: Idef47e9f93d3891d491cada18a9646b9f1b56cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179826
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-05  Szymon Kłos  <szymon.klos@collabora.com>  [2cd3c9fdd05336b17bda301eb37c1ca86b062052]

        jsdialog: export sortable property for treeview columns
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I2e2e6ce0a50239e29ac51b3e6974ed2d3bd2e421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179949
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180933
        Tested-by: Jenkins

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [4906f11d8f0c85248464b10c0b6c9c02e1657bad]

        browsebox a11y: Drop unnecessary friend class
        
        Change-Id: Icd89f9eb0dcb1c5adf12c44971215b17cbb53a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181147
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [9675a28dacb50a24b6960e155454b526dfe4585d]

        starmath: Drop unused SvTreeListBox forward decl
        
        Change-Id: Ifbd7a704b4ffd271246dbc15bb45e4f6bdb19a3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181146
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [69c0b537bfa05a6193e212105d166c26492124f6]

        browsebox a11y: Drop incorrect parent-relative pos conversion
        
        The only thing that changes when parent-relative coordinates
        (and not screen coordinates) are used is that the origin
        of the rectangle is different, which is already handled below.
        
        Passing bRelToBrowser=false to BrowseBox::GetFieldRectPixel
        is incorrect and resulted in the position for BrowseBox
        headers cells being incorrectly reported on the a11y layer
        when parent-relative coordinates are used.
        
        This was observed with an upcoming commit to let
        AccessibleBrowseBoxBase derive from OAccessibleComponentHelper
        and could be seen e.g. with the table seen in the
        Base window that shows up when selecting
        "Create Table in Design View..." in the "Tables" tab after
        creating a new database. (Highlighted position for
        those was wrong in Accerciser when selected in the
        a11y tree view there when using the qt6 VCL plugin.)
        
        Change-Id: I4c68748db0f09787037ac1ef023febaf01d1156e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181145
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [9b9d6a99e1509a03648fd6af0310e44c3fba5b14]

        Drop EOF comments
        
        No need to add a comment that the end of the (source)
        file is near, it's sufficiently obvious...
        
        Change-Id: Iac8885cf67fce45a81de387a31f8b726d615dff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181140
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [098a706920d11cfe7a70d367e9e3e9eedc032773]

        browsebox a11y: Deduplicate 2 cases effectively doing the same
        
        There's no need to distinguish between the case where
        `pParent` is set (i.e. parent-relative coords were requested)
        and where it is not, as only the height, and not the position
        are used, and the size is the same for the two rectangles retrieved
        via Window::GetWindowExtentsRelative and
        Window::GetWindowExtentsAbsolute, so simply always use the latter.
        
        (The distinction further down is relevant, however,
        because it uses the top-left point of the rectangle,
        not its size.)
        
        Change-Id: I3362e1493112236e08600f66f7c772d339919e7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181139
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [589ead3a6ae776fdbcb426f2817fbb94933a8bf7]

        treeview a11y: Fix parent-relative coordinates
        
        SvHeaderTabListBox::calcTableRect and
        SvHeaderTabListBox::GetFieldRectPixel get used when
        parent-relative coordinates are needed in
        AccessibleBrowseBoxTable.
        
        Parent-relative coordinates are meant to be
        relative to the immediate parent. The immediate
        parent of the AccessibleBrowseBoxTable is the
        AccessibleTabListBox, so there's no need to
        take the relative position of the
        AccessibleTabListBox parent within its parent
        (i.e. the AccessibleBrowseBoxTable's grand-parent)
        into account.
        
        Therefore, drop that extra offset.
        
        Without this commit, the highlighted area was too
        far down when clicking through the cells in the
        a11y tree of the treeview in the "Tools" -> "Options"
        -> "Advanced" -> "Open Expert Configuration" dialog
        in Accerciser when using the qt6 VCL plugin on Linux
        with an upcoming change to let
        AccessibleBrowseBoxBase derive from
        OAccessibleComponentHelper which makes use of the
        parent-relative coordinates instead of the
        screen coordinates currently reported by
        AccessibleBrowseBoxBase::getLocationOnScreen.
        
        Change-Id: Ie904701a0a715b22f210361eea3ced969b13c69f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181138
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [1a40b93d11b940bfff020e330ee23801b10826a2]

        treeview a11y: Don't report header twice
        
        AccessibleTabListBox is the a11y class for
        SvHeaderTabListBox. That widget only contains
        the table without the header, while the (column)
        header is implemented by HeaderBar which is a
        sibling of the SvHeaderTabListBox, see the
        "GtkTreeView" case in VclBuilder::makeObject.
        
        The header bar is already part of the a11y
        tree as a11y class for the HeaderBar.
        
        The fact that AccessibleTabListBox::getAccessibleChild
        was reporting that as a child as well resulted in the
        header bar (an a11y object with Table role) to appear
        in the a11y hierarchy seen in Accerciser twice when
        using the qt6 VCL plugin. (And clicking on it would
        result in an area to be highlighted that is not part
        of the area that the parent a11y object occupies.
        
        No longer report it as a child of the AccessibleTabListBox.
        
        The above can be observed with the "Tools" -> "Options"
        -> "Advanced" -> "Open Expert Configuration" dialog
        and the qt6 VCL plugin on Linux.
        
        Change-Id: If3099e12dd84cd4f3c420e94c377182c87c65106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181137
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [8b9a7146bc6d8ccd19968b89ed97ce59cd466573]

        vcl: Merge SvHeaderTabListBoxImpl into SvHeaderTabListBox
        
        SvHeaderTabListBoxImpl only has a single VclPtr<HeaderBar>
        member. Move that one directly to SvHeaderTabListBox and drop
        SvHeaderTabListBoxImpl.
        
        Change-Id: Ia79229a1c901f4e7a9f90496caacfb434b582fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181136
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-05  Michael Weghorn  <m.weghorn@posteo.de>  [8fbae3f72ef305feef3981ce6feb4e9fe92c7abd]

        a11y: Use ImplInheritanceHelper
        
        Change-Id: I040c0c0e0caac924d97d015adf248aba7dce8dc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181135
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-05  Noel Grandin  <noelgrandin@collabora.co.uk>  [c4edd3e223eb49b914a99b6345df41565a082808]

        remove dithering from Windows GDI backend
        
        This has not been necessary for some years now. In the unlikely
        event that we run on a 256-color display, the OS and the graphics
        driver will do the dithering for us.
        
        Change-Id: I23c7a3ded6ea63fcd0a5239bbf2a2cc91bba306f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [8dc9d06735684dd217c6258fe02ef373426456dd]

        tdf#149907: sc: Add UItest
        
        Change-Id: If21693a5e3cb92e0c465417f8989ad2fa9670432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181128
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b37942159448fa902ed0b1c635e9c556872492bd]

        ofz#394329881 Integer-overflow
        
        Change-Id: Ie1cd71c72a7a2159c9c4592f3e39e3efb8ac5b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [8fa6af450bf148f0033331e5b46154abd5ab72e5]

        tdf#127873, tdf#158867: starmath_export: Add unittest
        
        Change-Id: I996f86cbf1bf64f08ec5e9f1b74805a74865880f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181126
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1e7c73f612d99f320390cbca4d83b32cec1075dc]

        make calc Display config listen for changes
        
        Change-Id: I36a9118f8a29ccd543da9510e9ecf11ebf02b2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181131
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [0467f88e2892b36d6f89b626f0d273fa8c403a87]

        tdf#164072 sw annotation: Use menu parent that outlives menu
        
        When opening the popup menu by right-clicking on a Writer
        comment and selecting "Delete All Comments", the SwAnnotationWin
        (`mrSidebarWin`) gets disposed while the popup menu and its associated
        MenuFloatingWindow are still alive. With the menu floating window
        being a child of the SwAnnotationWin, that would trigger the
        below assert since
        
            commit 6708246e20ce522e673f539369cd38687d2dd16d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 11:06:48 2024 +0000
        
                tdf#164093 tdf#157001 a11y: Improve menu window disposal
        
        Avoid disposing parent window before its child by not using
        the SwAnnotationWin, but its parent as the popup menu
        parent.
        
            warn:legacy.osl:64828:64828:vcl/source/window/window.cxx:307: Window ( N2sw10annotation15SwAnnotationWinE()) with live SystemWindows destroyed:  18MenuFloatingWindow()
            Window ( N2sw10annotation15SwAnnotationWinE()) with live SystemWindows destroyed:  18MenuFloatingWindow()
            [New Thread 64828.64829]
            [New Thread 64828.64830]
            [New Thread 64828.64831]
            [New Thread 64828.64832]
            [New Thread 64828.64833]
            [New Thread 64828.64835]
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (rr) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007f580ac9de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007f580ac49d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007f580ac324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007f5801fbc2cb in SalAbort (rErrorText="Window ( N2sw10annotation15SwAnnotationWinE()) with live SystemWindows destroyed:  18MenuFloatingWindow()", bDumpCore=true)
                at /home/michi/development/git/libreoffice/vcl/source/app/salplug.cxx:403
            #5  0x00007f5802087961 in Application::Abort (rErrorText="Window ( N2sw10annotation15SwAnnotationWinE()) with live SystemWindows destroyed:  18MenuFloatingWindow()")
                at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:300
            #6  0x00007f580188bba8 in vcl::Window::dispose (this=0x55711f066550) at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:308
            #7  0x00007f5801902216 in Control::dispose (this=0x55711f066550) at /home/michi/development/git/libreoffice/vcl/source/control/ctrl.cxx:61
            #8  0x00007f58019552cc in InterimItemWindow::dispose (this=0x55711f066550) at /home/michi/development/git/libreoffice/vcl/source/control/InterimItemWindow.cxx:54
            #9  0x00007f57ca8fb980 in sw::annotation::SwAnnotationWin::dispose (this=0x55711f066550) at /home/michi/development/git/libreoffice/sw/source/uibase/docvw/AnnotationWin.cxx:189
            #10 0x00007f5801b06ee3 in VclReferenceBase::disposeOnce (this=0x55711f0667e8) at /home/michi/development/git/libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #11 0x00007f57ca939d52 in VclPtr<sw::annotation::SwAnnotationWin>::disposeAndClear (this=0x5571205dc3e0) at include/vcl/vclptr.hxx:207
            #12 0x00007f57ca9260b5 in SwPostItMgr::RemoveItem (this=0x55711a340eb0, pBroadcast=0x55711fe07bb0) at /home/michi/development/git/libreoffice/sw/source/uibase/docvw/PostItMgr.cxx:529
            #13 0x00007f57ca926662 in SwPostItMgr::Notify (this=0x55711a340eb0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/sw/source/uibase/docvw/PostItMgr.cxx:595
            #14 0x00007f5806551a4c in SfxBroadcaster::Broadcast (this=0x55711fe07bb0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #15 0x00007f57ca0e62c9 in SwpHints::DeleteAtPos (this=0x5571215061d0, nPos=0) at /home/michi/development/git/libreoffice/sw/source/core/txtnode/thints.cxx:3440
            #16 0x00007f57ca0b31d1 in SwTextNode::EraseText (this=0x55711a2d3070, rIdx=SwContentIndex (node 9 offset 4), nCount=1, nMode=SwInsertFlags::DEFAULT) at /home/michi/development/git/libreoffice/sw/source/core/txtnode/ndtxt.cxx:2877
            #17 0x00007f57ca0b501d in SwTextNode::EraseText (this=0x55711a2d3070, rIdx=SwPosition (node 9, offset 4), nCount=1, nMode=SwInsertFlags::DEFAULT) at /home/michi/development/git/libreoffice/sw/source/core/txtnode/ndtxt.cxx:2837
            #18 0x00007f57ca1494c2 in SwUndoDelete::SaveContent (this=0x557121daf110, pStart=0x7ffcf6391340, pEnd=0x7ffcf6391388, pSttTextNd=0x55711a2d3070, pEndTextNd=0x55711a2d3070)
                at /home/michi/development/git/libreoffice/sw/source/core/undo/undel.cxx:476
            #19 0x00007f57ca147457 in SwUndoDelete::SwUndoDelete (this=0x557121daf110, rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection, bFullPara=false, bCalledByTableCpy=false)
                at /home/michi/development/git/libreoffice/sw/source/core/undo/undel.cxx:264
            #20 0x00007f57c97e72e8 in std::make_unique<SwUndoDelete, SwPaM&, SwDeleteFlags const&> (__args=SwPaM = {...}, __args=@0x7ffcf6391214: SwDeleteFlags::ArtificialSelection)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:1077
            #21 0x00007f57c97d79a1 in sw::DocumentContentOperationsManager::DeleteRangeImplImpl (this=0x55711dbb22d0, rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection)
                at /home/michi/development/git/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4574
            #22 0x00007f57c97bf899 in sw::DocumentContentOperationsManager::DeleteRangeImpl (this=0x55711dbb22d0, rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection)
                at /home/michi/development/git/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4500
            #23 0x00007f57c97c2cf9 in sw::DocumentContentOperationsManager::DeleteAndJoinImpl (this=0x55711dbb22d0, rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection)
                at /home/michi/development/git/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4471
            #24 0x00007f57c97bfc2d in (anonymous namespace)::lcl_DoWithBreaks
                (rDocumentContentOperations=..., rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection, pFunc=(bool (sw::DocumentContentOperationsManager::*)(class sw::DocumentContentOperationsManager * const, class SwPaM &, enum SwDeleteFlags)) 0x7f57c97c2cb0 <sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, SwDeleteFlags)>) at /home/michi/development/git/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:686
            #25 0x00007f57c97c1773 in sw::DocumentContentOperationsManager::DeleteAndJoin (this=0x55711dbb22d0, rPam=SwPaM = {...}, flags=SwDeleteFlags::ArtificialSelection)
                at /home/michi/development/git/libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:2377
            #26 0x00007f57c9a7ef97 in SwEditShell::DeleteSel (this=0x55711b0054e0, rPam=SwPaM = {...}, isArtificialSelection=true, goLeft=false, pUndo=0x7ffcf6391d9f) at /home/michi/development/git/libreoffice/sw/source/core/edit/eddel.cxx:122
            #27 0x00007f57c9a7f538 in SwEditShell::Delete (this=0x55711b0054e0, isArtificialSelection=true, goLeft=false) at /home/michi/development/git/libreoffice/sw/source/core/edit/eddel.cxx:164
            #28 0x00007f57cae1c83b in SwWrtShell::DelRight (this=0x55711b0054e0, isReplaceHeuristic=false) at /home/michi/development/git/libreoffice/sw/source/uibase/wrtsh/delete.cxx:419
            #29 0x00007f57ca930aaa in SwPostItMgr::Delete (this=0x55711a340eb0) at /home/michi/development/git/libreoffice/sw/source/uibase/docvw/PostItMgr.cxx:1770
            #30 0x00007f57caa8d050 in SwAnnotationShell::NoteExec (this=0x55711eef12c0, rReq=...) at /home/michi/development/git/libreoffice/sw/source/uibase/shells/annotsh.cxx:1170
            #31 0x00007f57caa8cf15 in SfxStubSwAnnotationShellNoteExec (pShell=0x55711eef12c0, rReq=...) at workdir/SdiTarget/sw/sdi/swslots.hxx:19464
            #32 0x00007f5806fc9fbe in SfxDispatcher::Call_Impl (this=0x55711ae7d3b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:255
            #33 0x00007f5806fce446 in SfxDispatcher::Execute_ (this=0x55711ae7d3b0, rShell=..., rSlot=..., rReq=..., eCallMode=SfxCallMode::RECORD) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:754
            #34 0x00007f5806fb6c8e in SfxBindings::Execute_Impl (this=0x55711de05e80, aReq=..., pSlot=0x7f57caf33a18 <aSwAnnotationShellSlots_Impl+8712>, pShell=0x55711eef12c0)
                at /home/michi/development/git/libreoffice/sfx2/source/control/bindings.cxx:1045
            #35 0x00007f580709d8bd in SfxDispatchController_Impl::dispatch (this=0x55711e141080, aURL=..., aArgs=empty uno::Sequence, rListener=empty uno::Reference) at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:735
            #36 0x00007f580709c374 in SfxOfficeDispatch::dispatch (this=0x55711e140fe0, aURL=..., aArgs=empty uno::Sequence) at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:254
            #37 0x00007f5808307ddb in framework::MenuBarManager::Select (this=0x55711fe3b8c0, pMenu=0x5571215e12b0) at /home/michi/development/git/libreoffice/framework/source/uielement/menubarmanager.cxx:821
            #38 0x00007f580830784d in framework::MenuBarManager::LinkStubSelect (instance=0x55711fe3b8c0, data=0x5571215e12b0) at /home/michi/development/git/libreoffice/framework/source/uielement/menubarmanager.cxx:776
            #39 0x00007f58017a64f6 in Link<Menu*, bool>::Call (this=0x5571215e1320, data=0x5571215e12b0) at include/tools/link.hxx:105
            #40 0x00007f5801798233 in Menu::Select (this=0x5571215e12b0) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:352
            #41 0x00007f58017a56a8 in PopupMenu::ImplFlushPendingSelect (this=0x5571215e12b0) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:2872
            #42 0x00007f58017a5ced in PopupMenu::FinishRun (this=0x5571215e12b0, pWin=..., pParentWin=..., bRealExecute=true, bIsNativeMenu=true) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:3108
            #43 0x00007f58017a5487 in PopupMenu::ImplExecute
                (this=0x5571215e12b0, pParentWin=..., rRect=..., nPopupModeFlags=(FloatWinPopupFlags::Down | FloatWinPopupFlags::NoKeyClose | FloatWinPopupFlags::AllMouseButtonClose | FloatWinPopupFlags::NewLevel | FloatWinPopupFlags::NoMouseUpClose | FloatWinPopupFlags::GrabFocus), pSFrom=0x0, bPreSelectFirst=false) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:3033
            #44 0x00007f58017a3eca in PopupMenu::Execute (this=0x5571215e12b0, pExecWindow=0x55711f066550, rRect=..., nFlags=(PopupMenuFlags::ExecuteDown | PopupMenuFlags::NoMouseUpClose))
                at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:2860
            #45 0x00007f58034b67d3 in VCLXMenu::execute (this=0x5571215df5a0, rxWindowPeer=uno::Reference to (VCLXWindow *) 0x55711ef4bbe8, rPos=..., nFlags=1) at /home/michi/development/git/libreoffice/toolkit/source/awt/vclxmenu.cxx:509
            #46 0x00007f5806fd2d91 in SfxDispatcher::ExecutePopup (this=0x55711ae7d3b0, rResName="annotation", pWin=0x55711f066550, pPos=0x7ffcf6394968) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:1937
            #47 0x00007f5806fd2186 in SfxDispatcher::ExecutePopup (pWin=0x55711f066550, pPos=0x7ffcf6394968) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:1785
            #48 0x00007f57ca95d2c3 in sw::sidebarwindows::SidebarTextControl::Command (this=0x5571215354d0, rCEvt=...) at /home/michi/development/git/libreoffice/sw/source/uibase/docvw/SidebarTxtControl.cxx:443
            #49 0x00007f5801fb39e1 in weld::CustomWeld::DoCommand (this=0x557121536330, rPos=...) at /home/michi/development/git/libreoffice/vcl/source/app/customweld.cxx:93
            #50 0x00007f5801fb371d in weld::CustomWeld::LinkStubDoCommand (instance=0x557121536330, data=...) at /home/michi/development/git/libreoffice/vcl/source/app/customweld.cxx:91
            #51 0x00007f57f7799bb6 in Link<CommandEvent const&, bool>::Call (this=0x55711a2c0bd0, data=...) at include/tools/link.hxx:105
            #52 0x00007f57f7703ba8 in (anonymous namespace)::GtkInstanceDrawingArea::signal_command (this=0x55711a2c0900, rCEvt=...) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:19099
            #53 0x00007f57f7701f3d in (anonymous namespace)::GtkInstanceDrawingArea::signal_popup_menu (this=0x55711a2c0900, rCEvt=...) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:18731
            #54 0x00007f57f76e3cc7 in (anonymous namespace)::GtkInstanceWidget::signalPopupMenu (pWidget=0x55712152de30, widget=0x55711a2c0900) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:2701
            #55 0x00007f57f6c9adb5 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #56 0x00007f580552c9c0 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #57 0x00007f5805540d83 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #58 0x00007f5805548440 in g_signal_emitv () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #59 0x00007f57f6cce9f5 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #60 0x00007f57f6cceff0 in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #61 0x00007f57f6cd04bb in gtk_bindings_activate_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #62 0x00007f57f6c97caa in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #63 0x00007f580552c9c0 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #64 0x00007f5805541360 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #65 0x00007f5805542072 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #66 0x00007f5805548666 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #67 0x00007f5805548723 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #68 0x00007f57f6f551cc in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #69 0x00007f57f6f78143 in gtk_window_propagate_key_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #70 0x00007f57f6f7c9fb in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #71 0x00007f57f77fc4ac in key_forward (pEvent=0x55711a45b0c0, pDest=0x55711ae7bae0) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkframe.cxx:4239
            #72 0x00007f57f77f2f8d in GtkSalFrame::signalKey (pWidget=0x55711ae7bae0, pEvent=0x55711a45b0c0, frame=0x55711af84100) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkframe.cxx:4300
            #73 0x00007f57f6c97caa in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #74 0x00007f580552c9c0 in g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #75 0x00007f5805540d83 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #76 0x00007f5805542072 in ??? () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #77 0x00007f5805548666 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #78 0x00007f5805548723 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #79 0x00007f57f6f551cc in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #80 0x00007f57f6e05e6f in ??? () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #81 0x00007f57f6e07b76 in gtk_main_do_event () at /lib/x86_64-linux-gnu/libgtk-3.so.0
            #82 0x00007f57f7da7ce9 in ??? () at /lib/x86_64-linux-gnu/libgdk-3.so.0
            #83 0x00007f57f7ddc096 in ??? () at /lib/x86_64-linux-gnu/libgdk-3.so.0
            #84 0x00007f57fd10b81f in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #85 0x00007f57fd10da57 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #86 0x00007f57fd10e1c0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #87 0x00007f57f768350c in GtkSalData::Yield (this=0x55711906f850, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:405
            #88 0x00007f57f7688413 in GtkInstance::DoYield (this=0x55711906f700, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:439
            #89 0x00007f5802088706 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #90 0x00007f580208801f in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #91 0x00007f5802087e00 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #92 0x00007f580af287f9 in desktop::Desktop::Main (this=0x7ffcf6397a70) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1679
            #93 0x00007f58020a9b86 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #94 0x00007f58020ab779 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #95 0x00007f580afa20da in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #96 0x00005570fb1c4a6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #97 0x00005570fb1c4a47 in main (argc=2, argv=0x7ffcf6397c78) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: I20d037038c0d4a84d104bf9987bae28835dac609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181110
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c35a5990c0bb9d74fcf492cf21c186d12e30328]

        tdf#150867: Add support for VSTACK function
        
        Change-Id: I76e3267f45a0d035f6a79af934b9ce2c606b4b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181120
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [094e26cd989b1b51a3b3b612b9a9e3857f8d228c]

        tdf#150868: Add support for HSTACK function
        
        Change-Id: I105ffabc8dd1fa58bf3acec4a81c3217061d3a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181100
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-04  Noel Grandin  <noelgrandin@collabora.co.uk>  [eba3c7d18ba0bf75aab4234c91239155f4fa7c59]

        sort members of WinSalGraphics
        
        Change-Id: Ie9593c47141772395cf4c35bd3a3a20170787155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181099
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d2dd5bf00a45f53fbd6d703f84878dfa9c0e3cf0]

        Actually make wrapped_iterator a bidirectional_iterator
        
        ...which it claims to be.  Also, builds against recent LLVM 20 trunk libc++ (on
        macOS) had started to fail with
        
        > In file included from sc/source/core/tool/scmatrix.cxx:20:
        > In file included from sc/inc/scmatrix.hxx:22:
        > In file included from sc/inc/address.hxx:30:
        > In file included from sc/inc/types.hxx:14:
        > In file included from external/boost/include/boost/intrusive_ptr.hpp:30:
        > In file included from workdir/UnpackedTarball/boost/boost/intrusive_ptr.hpp:16:
        > In file included from workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:20:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/functional:557:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__functional/boyer_moore_searcher.h:25:
        > ~/llvm/inst/bin/../include/c++/v1/__vector/vector.h:1043:20: error: no matching function for call to object of type 'const __copy_n'
        >  1043 |       auto __mid = ranges::copy_n(std::move(__first), size(), this->__begin_).in;
        >       |                    ^~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__vector/vector.h:317:5: note: in instantiation of function template specialization 'std::vector<double>::__assign_with_size<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>, (anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>>' requested here
        >   317 |     __assign_with_size(__first, __last, std::distance(__first, __last));
        >       |     ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/../types.hpp:335:15: note: in instantiation of function template specialization 'std::vector<double>::assign<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>, 0>' requested here
        >   335 |         m_vec.assign(first, last);
        >       |               ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/../types.hpp:718:11: note: in instantiation of function template specialization 'mdds::mtv::delayed_delete_vector<double>::assign<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>>' requested here
        >   718 |         d.assign(it_begin, it_end);
        >       |           ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/../standard_element_blocks.hpp:73:1: note: in instantiation of function template specialization 'mdds::mtv::element_block<mdds::mtv::default_element_block<10, double>, 10, double, mdds::mtv::delayed_delete_vector>::assign_values<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>>' requested here
        >    73 | MDDS_MTV_DEFINE_ELEMENT_CALLBACKS(double, element_type_double, 0.0, double_element_block)
        >       | ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/macro.hpp:101:21: note: expanded from macro 'MDDS_MTV_DEFINE_ELEMENT_CALLBACKS'
        >   101 |         block_type::assign_values(dest, it_begin, it_end); \
        >       |                     ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:2545:13: note: in instantiation of function template specialization 'mdds::mtv::mdds_mtv_assign_values<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>>' requested here
        >  2545 |             mdds_mtv_assign_values(*blk_data, *it_begin, it_begin, it_end);
        >       |             ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:2519:16: note: (skipping 3 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
        >  2519 |         return set_cells_to_single_block(row, end_row, block_index1, it_begin, it_end);
        >       |                ^
        > sc/source/core/tool/scmatrix.cxx:2419:29: note: in instantiation of function template specialization 'mdds::multi_type_matrix<(anonymous namespace)::matrix_traits>::set<(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>>' requested here
        >  2419 |                 pos = mrMat.set(pos,aFunc.begin(), aFunc.end());
        >       |                             ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_matrix.hpp:191:13: note: in instantiation of member function '(anonymous namespace)::MatrixOpWrapper<matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>>::operator()' requested here
        >   191 |             m_func(mtm_node);
        >       |             ^
        > ~/llvm/inst/bin/../include/c++/v1/__algorithm/for_each.h:33:5: note: in instantiation of member function 'mdds::multi_type_matrix<(anonymous namespace)::matrix_traits>::walk_func<(anonymous namespace)::MatrixOpWrapper<matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>>>::operator()' requested here
        >    33 |     __f(*__first);
        >       |     ^
        > sc/source/core/tool/scmatrix.cxx:2468:11: note: in instantiation of function template specialization 'mdds::multi_type_matrix<(anonymous namespace)::matrix_traits>::walk<(anonymous namespace)::MatrixOpWrapper<matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>>>' requested here
        >  2468 |     maMat.walk(aFunc);
        >       |           ^
        > sc/source/core/tool/scmatrix.cxx:3598:12: note: in instantiation of function template specialization 'ScMatrixImpl::ApplyOperation<matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>>' requested here
        >  3598 |     pImpl->ApplyOperation(aOp, *rMat.pImpl);
        >       |            ^
        > ~/llvm/inst/bin/../include/c++/v1/__algorithm/ranges_copy_n.h:64:3: note: candidate template ignored: constraints not satisfied [with _Ip = __libcpp_remove_reference_t<wrapped_iterator<default_element_block<10, double, mdds::mtv::delayed_delete_vector>, MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double> &>, _Op = pointer]
        >    64 |   operator()(_Ip __first, iter_difference_t<_Ip> __n, _Op __result) const {
        >       |   ^
        > ~/llvm/inst/bin/../include/c++/v1/__algorithm/ranges_copy_n.h:61:13: note: because '(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>' does not satisfy 'input_iterator'
        >    61 |   template <input_iterator _Ip, weakly_incrementable _Op>
        >       |             ^
        > ~/llvm/inst/bin/../include/c++/v1/__iterator/concepts.h:154:26: note: because '(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>' does not satisfy 'input_or_output_iterator'
        >   154 | concept input_iterator = input_or_output_iterator<_Ip> && indirectly_readable<_Ip> && requires {
        >       |                          ^
        > ~/llvm/inst/bin/../include/c++/v1/__iterator/concepts.h:135:6: note: because '(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>' does not satisfy 'weakly_incrementable'
        >   135 | } && weakly_incrementable<_Ip>;
        >       |      ^
        > ~/llvm/inst/bin/../include/c++/v1/__iterator/concepts.h:122:10: note: because '__i++' would be invalid: cannot increment value of type '(anonymous namespace)::wrapped_iterator<mdds::mtv::default_element_block<10, double>, matop::(anonymous namespace)::MatOp<(lambda at sc/source/core/tool/scmatrix.cxx:3596:17)>, double>'
        >   122 |       __i++;                      // not required to be equality-preserving
        >       |          ^
        
        etc.
        
        Change-Id: I1c49823d462c67bb73b16453ea44e5f2fe19d2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181111
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-04  Michael Stahl  <michael.stahl@allotropia.de>  [ee482e856143ee62b37869411a64c36a1d78c7cc]

        tdf#159029 sw: layout: fix cell vertical orientation after split
        
        The vertical alignment of cells is implemented in SwCellFrame::Format(),
        but it is disabled if IsRebuildLastLine() is true (apparently since the
        time when splitting table rows was first implemented in commit
        90b73c7b667b06d42f5e37196d25a85b6c787f33 "INTEGRATION: CWS cellbreak")
        which is in 2 different cases:
        
        1. when another line fits on the page, around a call to
           lcl_RecalcRow(pLastLine) after RemoveFollowFlowLine() - this is the
           relevant case when the paragraph is deleted
        
        This case used to work by accident before commit
        068c133ac41c97652909b88c432e3b73010efc3e, when after
        RemoveFollowFlowLine() of row 406 the text frame moved to the top, then
        a Split of the row after the one containing the last part of the merged
        cell with the problem was attempted and failed, and in lcl_RecalcRow()
        after the Split the alignment was fixed; this commit changed it so that
        the first row frame 6 had an invalid position, which caused an earlier
        correction of the position of all the cells and text frames during the
        lcl_RecalcRow() after joining the follow, where m_bIsRebuildLastLine was
        set.
        
        2. after a successful Split() with bTryToSplit=true, i.e., a row was
           split - this is the relevant case on Undo of the paragraph delete
        
        This actually was a problem already before the above mentioned commit,
        but then it could be "fixed" by clicking on the cell, which stopped to
        work.
        
        Here there is no RemoveFollowFlowLine() at the start, but then again a
        failed attempt to Split a row followed by a successful Split between
        rows; before the 2nd Split the text frame is correctly positioned and
        valid, but then lcl_RecalcSplitLine() calling
        lcl_ShrinkCellsAndAllContent() moves the text frame up.
        
        In both cases, explicitly invalidate the PrtArea of cells in the last
        row where a vertical orientation is set.
        
        (regression from commit 068c133ac41c97652909b88c432e3b73010efc3e)
        
        Change-Id: I7d2e85bb76a4b77c7871d759abbebd6abeb31282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181113
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-02-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [222ff8ce8e20f3afcef3acb21d5eb7ebfa388138]

        Avoid -Werror,-Wunused-parameter
        
        > /Volumes/lode/lode/jenkins/workspace/lo_tb_master_mac/vcl/quartz/salvd.cxx:120:22: error: unused parameter 'pGraphic' [-Werror,-Wunused-parameter]
        >     AquaSalGraphics* pGraphic, tools::Long &nDX, tools::Long &nDY,
        >                      ^
        
        (<https://ci.libreoffice.org/job/lo_tb_master_mac/52565/>) since
        a46c265051af9b383c928914087d1e91025c2d2f "split CreateVirtualDevice into two
        methods".  (The argument to
        
        >     mpGraphics = new AquaSalGraphics( /*pGraphic*/ );
        
        had been commented out ever since the code got introduced in
        f0faedb959edd27d6b5b96ec77fd54f7172d52dd "INTEGRATION: CWS aquabmpfix01
        (1.22.12); FILE MERGED".)
        
        Change-Id: I476bba0fe65005bbd8f95e7185639e0a6629affd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181101
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [febf27dd63604e67a169639b6c1b4f424022d95b]

        simplify ImplPreparePolyDraw
        
        first parameter is always true
        
        Change-Id: I3e85d5ddfc1e706414be595316e5780fb4d1cc8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181102
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [d746a39ea9dc2c39cc2a7aa5d78e6c9d7563d9ca]

        tdf#165035 gtk3 a11y: Set relations for combobox's edit
        
        As described in
        
            commit 94c97ecdbfa606401fb53685048731128186672b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 18 18:59:46 2024 +0200
        
                gtk3 a11y: Set a11y relations for custom combobox impl
        
        , the gtk3 VCL plugin currently uses a custom combobox
        implementation.
        
        The above commit implemented that accessible relations set
        for the original GtkComboBox in the .ui file
        are taken over to the custom combobox implementation's
        toggle button.
        
        In case of an editable combobox, also set those relations
        for the box containing the combobox's GtkEntry.
        (Move the existing logic to set the role up to have everything
        in once place.)
        
        This makes the Orca screen reader announce the associated
        label's text also when the entry receives focus, not
        only when the toggle button does, e.g. in the
        "Format" -> "Character" dialog, "Font" tab, for the
        "Style" combobox.
        
        Change-Id: I2ece9177355aa18e43e0826bb07b6291944e8912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181093
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Gökay Şatır  <gokaysatir@collabora.com>  [6d8d9100b043db4f7e4d828261142c3271b81fd5]

        cool#10533
        
        LOK: Do not set the pasteMode when the view is read only.
        
        There is a chance to paste the copied content in read only view if user acts too fast.
        We need to set the pasteMode selectively to ensure that the action is not performed.
        
        Change-Id: I446469a2f1fa25c5cdf6c5958f664a46d6d1a741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181085
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-04  Jaume Pujantell  <jaume.pujantell@collabora.com>  [87f132a5e81557e423456c12c1bdcde13d1e4c66]

        [API CHANGE] sd pdfium: add page number when saving/loading pdf pages as images
        
        When a pdf file is opened with pdfium and then saved as odg, each page
        is saved as a draw:image of the pdf. But since no page number info was
        given, when opening the odg file, all the pages are shown as the first
        one.
        
        This adds a loext:page-number to the saved odg and the logic to load a
        specific page from an embedded pdf.
        
        Added loadGraphicAtPage to XGraphicStorageHandler.
        
        Change-Id: I398b7ad7f03cc7fb930a4e7b7620c6f238b41c0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181066
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-04  Noel Grandin  <noelgrandin@collabora.co.uk>  [3214c8de3d22c0c4a931facbe836aae719576701]

        document raster operation code
        
        Change-Id: I093ae6abcc2256bc422640887a572dcdda5541dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181087
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c0c19d00953a787e1832213f96d514c2b3c7853]

        cid#1642560 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If2abd138060ce97d2505c0a60f3cc3c6477dcbf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5d15a29f271c09f27a87bce2be2185fd62c635fe]

        wsl-as-helper: also support winget's version of Git on aarch64
        
        the current version of Git.Git apparently is now available in a version
        compiled for arm64 specifically, so also look for clangarm64 is PATH to
        properly detect git-bash / wsl-as-helper method in that case
        
        Change-Id: I3668220b7231cfa8e998b742f4357f7a1e9b4823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181075
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fc4445dc365bf121715d189b0f769d39660c1411]

        wsl-as-helper: make liblangtag more resilient (MSYS path mangling)
        
        different versions of git-bash come with different msys library that behave
        slightly differently when it comes to the path mangling that occurs. When msys
        encounters something that looks like a path, but the path doesn't exist, then
        it prefixes that path using the home of the git-bash installation. That path is
        using the long form and since git-bash usually is installed to Program Files
        the build then breaks because the path arguments aren't quoted.
        
        The path-mangling can be prevented by starting the path with a double-slash, so
        --prefix=//usr/local will take care of those instances where git-bash from
        Visual Studio works, but git-bash installed via winget fails.
        Luckily that seems to be the only case where the differences actually show
        themselves.
        
        Change-Id: I702da05b34dc153267f7251810a1c93babf66022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181061
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-02-04  Noel Grandin  <noelgrandin@collabora.co.uk>  [7dd7ac0311cfc74137b569c5473e14e73738762d]

        flatten some windows GDI code
        
        Change-Id: I9dd2d795803c588da235d9ae9baf213abd208ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181086
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cb750372980ba3a572dfb980c59878d3b341d0e]

        remove some windows95 code
        
        which we have not supported for a very long time
        
        Change-Id: I09bcd3a567c6b4d6c93666f4a4bcb3f632ef43a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c14614439bb006701dedda13505c2669c9cc1998]

        disable SbRtl_Shell by default in kit-mode
        
        Change-Id: I645c776bf59a718f4946c2c70edd9194f039e471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181071
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5f565b51a9f03df1ec5968f8b1a7787f00c82c3]

        no need to mess with x87
        
        this is tryly ancient cruft
        
        Change-Id: I285d81375644bba061586a9f601fe7db54f08af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6059ba88075d68075ce4dcb4bcef17a61b1f9b9]

        improve variable naming
        
        these are alpha, not transparency
        
        Change-Id: I0c2a28793a5ef5a759f20318971360cc25db6ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181082
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-04  Jean-Pierre Ledure  <jp@ledure.be>  [970ad633e4fc374798d4f2591b73098d44c0986b]

        ScriptForge (SFDocuments) new MenuHeaders property
        
        The %enuHeaders property returns,
        as an array/tuple of strings the list
        of the menus present in the menubar.
        
        This is a helper for the CreateMenu()
        method:
        - check if the menu exists already to
          avoid duplicates
        - ease the choice of the Before argument
        
        The property is applicable to next classes:
        - Document, and its subclasses
          Base, Calc, Writer, FormDocument
        - Datasheet
        
        The property is made available to Basic
        and Python user scripts.
        
        This new property will require an update
        of the user documentation/help
        
        Change-Id: Ia14daf6c58973e06d576b350e416eb178f70feb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181065
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-02-04  Jaume Pujantell  <jaume.pujantell@collabora.com>  [76c6d180f398a7d482665c24c07ec75f8a1dc7cd]

        sd: pptx export every layout used
        
        Regression from commit 9205b4eb09dcb4c91539e092db521154fc4e9523. On
        conversion from odp or ppt to pptx, some slide layouts were not saved if
        their masters were seen as equivalent.
        
        When reducing duplicated masters, only the layouts used in the Impress
        masters were saved for each duplicated masters. But when converting from
        other formats that handle masters/layouts differently it's necessary to
        search for all used layouts in each Impress slide that uses each
        duplicated master.
        
        Change-Id: Ie27852e7c0ff0b160a4e2415669f5e615c46e2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181070
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cdb0c1e5c99cdb9b31e24f50e96a9b254dd9fb33]

        crashtesting: SvBaseLink::Update can invalidate later entries
        
        e.g. load forum-mso-en4-62141.xls and update links
        
         #0  sfx2::LinkManager::Remove (this=0x270d720, pLink=0x27b5780) at core/sfx2/source/appl/linkmgr2.cxx:118
         #1  0x00007fffa9813eef in ScDocument::UpdateRefAreaLinks (this=0x1f5d740, eUpdateRefMode=URM_INSDEL, rRange=..., nDx=0, nDy=-6, nDz=0)
             at core/sc/source/core/data/documen8.cxx:1141
         #2  0x00007fffa97a8639 in ScDocument::UpdateReference (this=0x1f5d740, rCxt=..., pUndoDoc=0x0, bIncludeDraw=true, bUpdateNoteCaptionPos=false)
             at core/sc/source/core/data/documen3.cxx:1053
         #3  0x00007fffa9829c9e in ScDocument::DeleteRow (this=0x1f5d740, nStartCol=1, nStartTab=0, nEndCol=7, nEndTab=0, nStartRow=3, nSize=6, pRefUndoDoc=0x0, pUndoOutline=0x0, pTabMark=0x0)
             at core/sc/source/core/data/document.cxx:1431
         #4  0x00007fffa982a324 in ScDocument::DeleteRow (this=0x1f5d740, rRange=...) at core/sc/source/core/data/document.cxx:1484
         #5  0x00007fffa982d1a4 in ScDocument::FitBlock (this=0x1f5d740, rOld=..., rNew=..., bClear=true) at core/sc/source/core/data/document.cxx:1883
         #6  0x00007fffaa6c385d in ScAreaLink::Refresh
             (this=0x27b5780, rNewFile="http://stocks.tradingcharts.com/stocks/symbols/s/NYSE/Boeing", rNewFilter="calc_HTML_WebQuery", rNewArea="HTML_2", nNewRefreshDelaySeconds=0)
             at core/sc/source/ui/docshell/arealink.cxx:365
         #7  0x00007fffaa6c5069 in ScAreaLink::DataChanged (this=0x27b5780) at core/sc/source/ui/docshell/arealink.cxx:128
         #8  0x00007ffff3ac81e1 in sfx2::SvBaseLink::Update (this=0x27b5780) at core/sfx2/source/appl/lnkbase2.cxx:324
         #9  0x00007fffa98137b6 in ScDocument::UpdateAreaLinks (this=0x1f5d740) at core/sc/source/core/data/documen8.cxx:1058
        
        Change-Id: Ie6c59b240d9a24cbf427be9c5bfda1660fe888c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181078
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-02-04  Andras Timar  <andras.timar@collabora.com>  [bfb8dbc4a6a462bc9a836d125faaeafd81daadd9]

        tdf#165011 accept empty second parameter of WEEKNUM spreadsheet function
        
        and treat it like if it was the the default "1".
        
        Change-Id: I618575a7441a2a6650228fc1a29177e294933ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181048
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [11e62f3a0566464186cef88f6133dbf88fe60a08]

        related: tdf#162601 UNIQUE function is case-insensitive also for non ASCII
        
        Kudos to M. Kaganski for flagging it
        
        Change-Id: I061a66f2e58bc48025575f20f97479059d0f4453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181077
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-04  László Németh  <nemeth@numbertext.org>  [d60ea6596f7a394290f9a82ac5324e2e8307f5f9]

        tdf#164932 sw inline heading: unit test for fixed text frame AutoSize
        
        Follow-up to commit b4d41f6b0deb0299cd01173c150c5b94568c9a21
        "tdf#164932 sw inline heading: fix frame AutoSize at list offset".
        
        Change-Id: I62521d3672695b35d592b9671c052d091d403b04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181062
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [fb0bd0e39bd8ccc618ef34bc6f830067723c1b4d]

        fpicker: Drop unused SvTabListBox forward decl
        
        Change-Id: I4e6a7cae9d7f932fcd7c0449ce490920227ea57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181023
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [a3befdae52513f04ce57b1f9ecab61ea439ebed9]

        vcl: Merge LclHeaderTabListBox into SvHeaderTabListBox
        
        By now LclHeaderTabListBox is the only SvHeaderTabListBox
        subclass and SvHeaderTabListBox is not used by itself.
        Merge the former into the latter to make the class hierarchy
        a little less complex.
        
        The "plain" SvHeaderTabListBox or other subclasses used
        to be used in the past, but that is no longer the case,
        see e.g.
        
            commit 4e07b178f58b1dabbb48bc9f26155b8270a4a72d
            Date:   Tue Feb 18 10:16:40 2020 +0000
        
                weld WatchWindow panel
        
        which eliminated one use.
        
        Copy the comment about the default NotifyStartDrag
        implementation in the base class being weird from
        vcl/inc/treeglue.hxx but also leave it there, as
        it applies for the LclTabListBox class that is
        still there just the same.
        
        Change-Id: I658332a9675a9c67c7250f2577a6eb1a0cc491f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181022
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [aa3416b59abfde102e8589f53f75089cadffc242]

        cui: Drop unnecessary forward declarations
        
        The SvTabListBox one is unused.
        SvxMacroTabPage_ is declared just below.
        
        Change-Id: I0fd8e3be7967b533aa0268833d98833d15b3903b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181021
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [6b67cef4fa7aaebaacfdc8715594d22a186555ce]

        vcl: SvHeaderTabListBox: Pass HeaderBar in ctor
        
        ... instead of having a separate method
        SvHeaderTabListBox::InitHeaderBar that gets called
        right after the ctor.
        
        Change-Id: Ie4c523448dd11e58718c94d0b74888faa8984fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181020
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [b671f7f47036fe08bf4edd1a21ed014026f604ca]

        a11y: Drop obsolete comment mentioning IAccessibleTabListBox
        
        Obsolete since:
        
            commit eaaa5d04a27270ad13d5e470ed5f50d418e6fa4d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 28 13:54:14 2025 +0100
        
                a11y: Drop IAccessibleTabListBox iface
        
        Change-Id: I4b6e88be79872d6bacd0852d61d04d4ded350265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181019
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [d5617cd2a26c023eaf9e6b4df379a07aab63d0be]

        sidebar: Have sidebar deck tooltip only set on its button
        
        Drop the tooltip from the toolbar that contains the
        button.
        This is already set for the button as well since
        
            commit 9fdc7384eff0e9627de2d9c2b59a7716f9e8af25
            Date:   Tue Dec 15 14:33:32 2020 +0000
        
                tdf#138938 put the tooltip on the toolbar item instead of the toolbar
        
        , so setting it on the toolbar in addition seems unnecessary.
        (The tooltip showed fine in a quick test with both, gtk3
        and gen as expected.)
        
            commit bb1d48498c9fdedf8e78344765f6c6eda6f4707c
            Date:   Wed May 18 22:22:06 2022 -0800
        
                tdf#84502 related: Show keyboard shortcut in sidebar tab bar tab button
        
        had added the shortcut in the tooltip text set for the button,
        but not the toolbar, but having these two different variants
        doesn't look intentional to me.
        
        Change-Id: I6bdc72d00b33c8a970777ed94a6911042db309ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181074
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [bd9666444d0b914d4102a4ce9446148d7e258a0c]

        tdf#165002 sidebar a11y: Set a11y name on sidebar deck buttons
        
        For sidebar deck tool buttons, set  the accessible name
        for the actual button, not the toolbar that contains it.
        
        That makes the Orca screen reader announce the name
        when the button receives focus instead of just announcing
        that a button received focus, leaving it unclear for the
        user what this button is about.
        
        Change-Id: I80b3ed45b57ba7cf10b7a46bb0506fdccde55f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181073
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [a90d3a8f09f8bea3630020eda42dad6fccac18e3]

        gtk4 a11y: Terminate gtk_accessible_update_property params
        
        As the documentation [1] describes:
        
        > A list of property and value pairs, terminated by -1.
        
        Without explicitly terminating the list by -1, gtk4 was
        seen crashing with a segfault when started after
        
            Change-Id: I8c30b6b67366d1839acb725bc4af012c276a5ee2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 3 08:41:49 2025 +0100
        
                tdf#165002 sidebar a11y: Set a11y names for styles tool buttons
        
        that triggered this preexisting issue.
        
        [1] https://docs.gtk.org/gtk4/method.Accessible.update_property.html
        
        Change-Id: If167b0723df29d4eabf813c670e4cfa842f259d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [8b221ecd50d2bd7ce84874333c06068e45c774cd]

        tdf#165002 sidebar a11y: Set a11y names for "Styles" toolbar items in .ui
        
        Similar to how
        
            Change-Id: I8c30b6b67366d1839acb725bc4af012c276a5ee2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 3 08:41:49 2025 +0100
        
                tdf#165002 sidebar a11y: Set a11y names for styles tool buttons
        
                For the toolbar buttons to switch between the different
                styles categories ("Paragraph Styles", "Character Styles",...)
                in the "Styles" sidebar deck, set the tooltip text also as
                the accessible name.
        
                This makes the Orca screen reader with announce them
                (e.g. "Paragraph styles, toggle button, pressed") when using
                the gtk3 VCL plugin instead of just saying "toggle button", which
                doesn't give the screen reader any clue what those buttons are for.
        
        did for those toolbar buttons whose tooltips etc. are set in
        C++ code, also set a11y names for those that are handled in
        the .ui file and set the text used for the tooltip also
        as the accessible name, so Orca can announce those as well.
        This makes Orca also announce the items in the right-hand
        side toolbar of the "Styles" sidebar deck when using the
        gtk3 VCL plugin.
        
        Change-Id: Iaf68ec56049feceaf27be5f62cf631a81bf0f50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181039
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [6f441eba260db39df386c46c5ee7492e79e25c8c]

        tdf#165002 sidebar a11y: Set a11y names for styles tool buttons
        
        For the toolbar buttons to switch between the different
        styles categories ("Paragraph Styles", "Character Styles",...)
        in the "Styles" sidebar deck, set the tooltip text also as
        the accessible name.
        
        This makes the Orca screen reader with announce them
        (e.g. "Paragraph styles, toggle button, pressed") when using
        the gtk3 VCL plugin instead of just saying "toggle button", which
        doesn't give the screen reader any clue what those buttons are for.
        
        Change-Id: I8c30b6b67366d1839acb725bc4af012c276a5ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181037
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [700194c65544f130c92819425933d43528ba1598]

        No longer use std::optional for SfxModule::CreateStyleFamilies
        
        Just return an empty std::vector instead of a std::optional that
        contains no value in the default implementation, and adjust the
        type of the local variables and class members that contain
        the result and their use accordingly.
        
        Change-Id: I4e25b3cbd96c6eb9f06b0ae44b36675bb11ab38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181024
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-03  Oliver Specht  <oliver.specht@cib.de>  [527f81f2717812a10f88fb69edeaf062fd8589a1]

        fix regression from 075560420a7aa238182e2d80dfe1c5fbaad3edbd
        
        Applying a paragraph style with an attached list style does now
        overwrites a list style at a paragraph that had a list(style) applied
        
        Change-Id: I0dc124dc2db167370dab8416a6cc97d563bcc03c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177842
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2025-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a46c265051af9b383c928914087d1e91025c2d2f]

        split CreateVirtualDevice into two methods
        
        because I need to make it more complicated in an upcoming patch, and
        this is already complicated.
        
        Change-Id: I920adc8729e53672a370c9778aa2b8a6b907ad50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9179d008ab6b0f7996225b16723e5e7cf96bd5be]

        Fix code typo: multiple ; in opencl/
        
        Change-Id: I03a1bfd03de7c3ff9b28456c2a6c8074a5ebd20c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179592
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2025-02-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [85f3a41d6909b4d8adb10012289e64dea88d12d1]

        tdf#145056 Delete autofilter settings when turning off autofilter
        
        Otherwise when turning autofilter back on, colors will still be selected
        in the dropdown (while the filter is not active)
        
        Change-Id: I2bfeed08b187b3923e001d3b71658d5dc47556f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181053
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-02-03  Andras Timar  <andras.timar@collabora.com>  [a6c1ed0e9c3bbd87d483ecb7c5d667418ffb650e]

        Fixed WEEKNUMBER test sheet, ISERROR(a13ú) did not seem right
        
        Change-Id: I01ccd512d38c887bfcf834ef2fbfcf46a2e98246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181047
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [afc90ce5850249bfb043ab274e6838c0c0010e06]

        sc: a13ú -> A13
        
        Change-Id: I7200ac41f6d2b66a5320dc7fcd0f845e2b315ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181055
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [aa1e2fc959633a589f6bf961d39991dbd1261947]

        vcl: rename enum variable prefixes
        
        Change-Id: I1177e876d3959da2e9349c1cd4441a612951199e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178211
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ef05087b54621caec96e72fc8aaf13f86a90bf9]

        tdf#162601: UNIQUE function is case-insensitive
        
        Change-Id: I12d67cb926c1e6dc8b7863529639dc252385b8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181035
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [689a004df332888d5eca0b3386b84c82744e2b74]

        sw: fix wrong condition
        
        Changed by mistake in
        commit 6b09bec95747d3bd9871bab3f49142a2fca2d368
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Fri Nov 29 18:36:52 2024 +0100
        
            sw: use SAL_RET_MAYBENULL in Lower()
        
        Kudos to Michael S. for finding it
        
        Change-Id: Iaebcfee19da5b56a012f437cd5189e95cb56ace5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181045
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-02-03  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [86429ad22f715d2e715d0bb4cb052e5194a23d01]

        tdf#165005 Fix URL to community forum in readme
        
        Change-Id: I11a2d9bd4ffcface3f3b0841aaf921dc5b0bca69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181034
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-02-03  Gökay Şatır  <gokaysatir@collabora.com>  [8b9bfe98259c54ba6e9407d3c486436965cdf7db]

        cool#10610: Test for ensuring the parent-child relations of comments.
        
        Change-Id: Idacdc1df20049f4d5a0214570a3451cc4382d71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181031
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-02-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b89047a0f0100fb30121084cf42815aa792c1f88]

        tdf#164843 - sc optimize "SubTotal" function's reference ranges
        
        Double references from relative named ranges can point to large
        ranges (MAXCOL/MAXROW) and because of that some function evaluation
        like SubTotal can be extreamly slow when we call ScTable::CompileHybridFormula
        with these large ranges. Since all the SubTotal functions ignore empty cells
        its worth to optimize and trim the double references in SubTotal functions.
        
        Change-Id: I9340b520cd3ac333b63b4aec35a3c647f5d9a119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180773
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-02-03  Manish Bera  <mbera.dev05@gmail.com>  [d8f405ccf6aa5c44a2fca659e62d7a8c09d9db7d]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: I3a9fe3c74b869195ffa9b34f180e8e58c841d9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180312
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-03  Simon Chenery  <simon_chenery@yahoo.com>  [4cc35cf5d52b2e6f9458b27ea6b26a9ebd066af0]

        tdf#163738 use insert function instead of for loop in migration.cxx
        
        Change-Id: Icf49d59fa56b6c7074abd476deeca040ea4c178f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180801
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-02-03  Simon Chenery  <simon_chenery@yahoo.com>  [9df6108dd7bd301a1b8d60c08b2f2d508c8bd125]

        tdf#153109 simplify any_of to find without lambda
        
        Simplify a std::any_of call to std::find, which avoids
        the need for a lambda function.
        
        Change-Id: Ibc4799b77e4997440d58995d37e39c6eae411764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180851
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-02-03  Simon Chenery  <simon_chenery@yahoo.com>  [05c92d3bdc633186975d3191d9ae5629c57a9a60]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in keynames.cxx
        
        Change-Id: Id413378f638807355fa7ce4b37d8aee62fedefb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180769
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-02-03  László Németh  <nemeth@numbertext.org>  [b4d41f6b0deb0299cd01173c150c5b94568c9a21]

        tdf#164932 sw inline heading: fix frame AutoSize at list offset
        
        Calculation of AutoSize of text frames was incomplete,
        resulting narrower frame width and e.g. two-line numbered inline
        heading instead of a single one, if the left offset of the
        numbering level in the attached list style was not zero.
        
        This is a general fix for all text frames, not only for
        text frames with Inline Heading frame style.
        
        Regression from commit 56588663a0fddc005c12afaa7d3f8874d036875f
        "tdf#131728 sw inline heading: fix DOCX paragraph layout
        interoperability".
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export",
        commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf48459 sw inline heading: add Inline Heading frame style"
        
        Change-Id: I4aea651d6982db61af0e423f25152b1401dc16c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181025
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-02-03  Simon Chenery  <simon_chenery@yahoo.com>  [ad471148ec8763e17f55059aaf85e320175220f2]

        Add isEmpty() check to avoid possible OUStringBuffer underflow
        
        Avoid accessing invalid index -1 if OUStringBuffer aBuffer is empty.
        
        It cannot be guaranteed that callers will always pass strings that
        result in aBuffer being non-empty.
        
        Change-Id: Ied9abf753bcaf2bd1ee618b2431fa35b0bdb5573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180856
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2025-02-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5be5e9da58c7dcee418264b2da29ddcc07e4709d]

        tdf#149907 Update results when changing condition
        
        Regression from d9dd003f63a781e63bfbe380ea737e080c21881f
        
        Change-Id: I9373be1f77ba13049a91816f57c5ae6b8913f071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181028
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-03  Miklos Vajna  <vmiklos@collabora.com>  [1752e15c52deff5a0f73f68b7e957e9b0c36df5f]

        svx: prefix members of Gallery
        
        See tdf#94879 for motivation.
        
        Change-Id: I58c8c02342085eca1d08c80fb9fae58c84a47e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181027
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-02-03  Jaume Pujantell  <jaume.pujantell@collabora.com>  [e748726e3cb7bd311d4c0808963d6847295385ea]

        lok: allow save on comment only mode
        
        Allow execution of .uno:Save command on comment only mode for all types
        of files, not only pdf.
        
        Change-Id: I35387d93d00d709d209d3ed1ba2d315bd20b67d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180940
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit adcfa0902b8641a50b11c9fb528bb971993d5f12)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181026
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2025-02-03  Arnaud VERSINI  <arnaud.versini@pm.me>  [c38e3562e3d644011a09a2d71af5ce70c75f8830]

        vcl : use frozen unordered_map to avoid allocations
        
        Change-Id: I6b0ecd18fe3aa79211c5f1f28a2b87eece98d0e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179581
        Tested-by: Arnaud Versini <arnaud.versini@pm.me>
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
        Tested-by: Jenkins

2025-02-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [a838bac7b7eb36890aaa441a76ae40b5be5e391a]

        vcl: aType -> eType
        
        Change-Id: Iceca9108d9cba3c3f5680ebb78926f430b29f73a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [6ec3ff63dfae1e6af2e776f48068eadb9a46011f]

        vcl: remove unnecessary includes in ctrl.cxx
        
        Change-Id: I62f7ab6b3e3bcc1fcf1994a142e0d444344d76c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178225
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [1dd3ab8842be49afe9357402d0cd5506ff72bb2b]

        vcl: remove unnecessary includes in fmtfield.cxxx
        
        Change-Id: I8b08a8ca072040c5ebf9c667d618ffb0d0b21c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179182
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [01f48ef20173a305752ce2605d1d581a663357da]

        vcl: remove implInit() from HyperLabel
        
        Change-Id: I45d1f519f812529f0913d4a4453201a59d984163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179191
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-03  bruh  <randomforest33@gmail.com>  [cda4965ea65ff9fa0e63e53344f46aeac91848a9]

        tdf#158280 Replace usage of InputDialog with SvxNameDialog
        
        Change-Id: I02309ea7c01369429de08be0b2bd78725602a837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181002
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [ad5cb7e99f574c17811ef7d5419b35a95ed82696]

        Drop some needless mappings to identical strings
        
        Change-Id: Ia9aac22c8bf6872636bd225f693950f9924071c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181013
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [eca5475de85bed4dc0b4026a9d6558547721287e]

        Use OUString instead of run-time conversion from char arrays
        
        Change-Id: I94bd75121796b84b8ea44f5e3bed1893d0b02edf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181012
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [47690d9fbeb1e1650145c272972fc92a6e7d01ef]

        The first entry must not be the default best match
        
        This is based on code reading; I see no reason to assume that the
        front has the best match, that should be used when the following
        iterations didn't choose it explicitly.
        
        Change-Id: I2f90e56d00c25737c58e1e90642618a88f1fa2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181011
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f329c6da61d8b48b6b3e37557df0e7aebcfa7282]

        Inline cellkeywords.inl, and drop its generating machinery
        
        Now that we have UTF-8-encoded CXX, we can simplify the initialization
        of ScCellKeywordTranslator, by inlining all the translation pairs.
        
        Change-Id: I5dedf71d5694c919f09c8c538bd4dba6cce391ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181010
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [c87b9950f01b29a9720f7acaba2d654b03f12ecc]

        Simplify cellkeywords.inl
        
        It was autogenerated once; likely, it was needed when the encoding
        of all CXX files was undefined. These days, the encoding is fixed
        to UTF-8, so no meed to encode the literals like this.
        
        Change-Id: I0a181075360a28e79c1a2e67548eebc970832a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181009
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-02  Manish Bera  <mbera.dev05@gmail.com>  [663f46379e06df0ee30d2648739ada2926cc2fef]

        tdf#130924 use SAL_INFO/WARN instead of f/printf
        
        Change-Id: I43ce33f470153e9f8c69851d44d3ba05faaad8ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179487
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-02-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [efda1fa20d2309fae15354dada32867cf5ccfd7b]

        Filter out more unwanted command URIs
        
        Change-Id: I24c95d73b4fee89bdf044d5dd6efc9cd89627c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180970
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [e33613b16223b22640304c2ca63b49ce2957fb49]

        Add a comment to clarify what kind of inputs the class handles
        
        Change-Id: Ic9d343a590a8c94a2545bca2c5442c484dd60190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181008
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [6d78861299331fdfa51a070ced1ce498ceff342f]

        tdf#164989: Disallow combining characters when a hex already appeared
        
        We either expect a single (maybe combined) character to convert into "U+"
        notation, or a sequence of hexadecimal numbers (possibly with U+) for
        conversion to characters. If we already saw a hexadecimal ASCII character,
        it can't be preceded by a character combining with it, so stop as soon as
        such an unexpected character appears.
        
        Change-Id: Ic480fe8f173240eb263d5a77286b149c933049a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181007
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-02-02  Christopher Sherlock  <chris.sherlock79@gmail.com>  [ea047987b57bcd683f397220d705503bc2bd0642]

        vcl: ignore readability commit
        
        Change-Id: I4ba970c5b3f35ccd7863bd751ef76d90d2e36947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178347
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-02  Christopher Sherlock  <chris.sherlock79@gmail.com>  [1a60a7e9536193a5e8649c296d68be3718d7eff4]

        vcl: remove unnecessary headers in edit.cxx
        
        Change-Id: I7da22e688d579e050918f7749707c1cb6bba47e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-02  Christopher Sherlock  <chris.sherlock79@gmail.com>  [166447334270584cda49f069e13430d320eb4907]

        vcl: remove unnecessary comments
        
        Change-Id: I38f26fea85b3af7e52db81863c967bd689ee059a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-02-02  Christopher Sherlock  <chris.sherlock79@gmail.com>  [5823e25c929eafee043a734486f7b1ad8a269be1]

        vcl: simplify ImplCalcPos()
        
        Change-Id: Ie7ea3b4f88c6740cb00b01c739f943d2e8011204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179143
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [1b6fbba88bd342fe3179e58e5ee0172041beb100]

        vcl: make calendar.cxx more readable
        
        Change-Id: I9fe1549417ffcb0f788ca941216dfd4a103544e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174726
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-02  Christopher Sherlock  <chris.sherlock79@gmail.com>  [03974760595039eab07a08cefaca6bd7f31b7e77]

        vcl: remove unnecessary includes from field.hxx
        
        Change-Id: I33ef533895f089bb5dfb78424fc407e568f9165f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178941
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-02-01  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [08e40accb3fabe676746c40797efc20eaa218801]

        tdf#163962 Enable spell checking in editable sections in read-only mode
        
        Change-Id: I1464cb229cc77748a07003e76d0d009c7a95ca66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181000
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-01  Mohamed Ali  <mohmedali1462005@gmail.com>  [6802590b3a850c4c91f4bf16bae770fee6cda577]

        tdf#157665 Use <=> operator for date
        
        Change-Id: I3527b7fde74f09f6ce4a887ca353ba05a8e14742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177211
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2025-02-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df6fe961632e0dfdac3b1b2550ec7fb81fb3f0a2]

        Fix typo
        
        Change-Id: I2750b0f6445165abfa67cdbc362715e19e869358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180944
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-01  Andras Timar  <andras.timar@collabora.com>  [948d9c6480698772dce95e0a23d26594436f8551]

        misc_extensions is now empty and can be removed
        
        Change-Id: Ibffac03be5f22852e647340ddc4f5211d0159c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180997
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-01  Andras Timar  <andras.timar@collabora.com>  [a76a0ca930b8329f588c7da90c15674751db7b7b]

        Remove obsolete Numbertext 0.9.5 extension
        
        There is no point to bundle it, because
        1) it is an old version
        2) since LibreOffice 7.5 there are built-in number formats in
           Calc with the same functionality (using libnumbertext FWIW)
        
        Change-Id: I8cfb24f7e6f045bd51fea620aca6a61269dba77a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180996
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-02-01  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [88741ef8c7aaa6d75ff99e44648087ff743937f1]

        tdf#146553 sw: Enable the AutoText dialog's Insert button in editable
        
        sections in read-only mode.
        
        Change-Id: I0fdf3a11f96ded8fe84cf9c81da2d6a020af3197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180995
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2025-02-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7aa00ac2de10ffc553e8809045e954cff9f81aa0]

        Fix typo
        
        Change-Id: I63ecf57578e8c7d8688fbebcbc1f22fd9e70c194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180986
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [d595e1aa4111054ca9abe722f23fa7bb54d3fb65]

        tdf#151000: Add support for CHOOSECOLS function
        
        Change-Id: Id183f79a148080adebe652f63e29716910c638b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180992
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-31  Gökay Şatır  <gokaysatir@collabora.com>  [b0a4afc58e1c9434e56ddb96c41f4ebe5985ed0a]

        cool#10610 Ensure the parent-child relations of comments.
        
        Previously, parent-child (comment-reply) relations were established using the position of comments.
        For some time now, users can add comments to the same position and they still won't be replies to first comment.
        This is provided with parent-name, parentPostItId etc variables.
        When copying a portion of text, comments are also copied.
        While copying the comments, we need to re-establish their parent-child relations.
        This code uses a temp map for the purpose and re-connects replies to their new parent comments.
        
        Change-Id: Id0fe7f419228b115a6e3d1e10ccb2fc70db57cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180991
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [b0d4b4664a295631ce4d8dee2ceb5cd94ae12edb]

        tdf#158198 sw: prevent xBookmark.getAnchor().setString("") from deleting
        
        ... the bookmark.
        
        Add a RANGE_IS_BOOKMARK to SwXTextRange and special case setString() so
        that it will do a replace, not a delete, to prevent the bookmark from
        being deleted.
        
        SwXBookmark::getAnchor() will create such a SwXTextRange.
        
        Bookmarks may be in table cells of course so we need RANGE_IN_CELL to be
        a flag now so it can be used with 2 different enum values.
        
        (regression from commit baf8d2c1c16cb3bdc4edad2560f95fea807a034f)
        
        Change-Id: I69169b9a5f6f7525715122b16de009c894246bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180985
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-01-31  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [5f81c84e9b5d4bc9eb5ba05aa1aad5eeaa4eb89a]

        tdf#146549 sw: Make the formatting toolbar visible
        
        when moving the cursor to an editable section in read-only mode.
        
        Change-Id: I7ed5837eb627a3db00b1b64516b790cc7a3aea01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180890
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2280c07bfc0887d8784aff04ac5ea20981b17b8]

        make Dialog destruction a little safer
        
        rather keep the Impl object around for the lifetime of the Dialog
        object.
        
        where I saw a backtrace that looked like
        
        vcl/source/window/dialog.cxx:1098: short Dialog::Execute(): Assertion
        `mpDialogImpl' failed.
         Dialog::Execute()
         SalInstanceDialog::run()
         ScSpellingEngine::ShowFinishDialog()
         ScConversionEngineBase::FindNextConversionCell()
         ScSpellingEngine::SpellNextDocument()
         ScSpellDialogChildWindow::GetNextWrongSentence(bool)
        
        Change-Id: I5858f3cd126185bc4f59932dfa53f6a6a3a66aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180980
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [c9c2d46acf651bfc4327f8a08caa467b3140e4f7]

        Simplify SfxBindings::ExecuteSynchron
        
        ... by making SfxBindings::Execute return SfxPoolItemHolder.
        
        Change-Id: Idd62a5eae791a6a4fec283c0c80fdac19c3526d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180982
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [e6d50480a15f7b673a17eafa3db542f8ace7e731]

        Drop unused arguments from Execute_Impl
        
        Unused since commit db93b92d78714ed193b3cbe52b18e3cfd9da99b8
        (loplugin:constantparam in sfx2, 2016-03-17)
        
        and commit 20c14c812ccc00692d42d294d3b8dea1774e3511
        (loplugin:constantparam in sfx2, 2016-09-09).
        
        Change-Id: Iebe4bdda87bb6f8472389a676cd394039588249a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180981
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-31  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [7c0d5fab2b62a9cb79e228e372bb85d38fe73bcc]

        tdf#164476 CiaroSDPR: improve ControlPrimitive2D rendering
        
        The task shows that for some situations the Controls do not
        get vbisualized. These *should* be child windows of the
        panel containing them, but fir some reason these seem to
        get incarnated by being 'painted'.
        Problem is that for SDPRs an OutputDevice to do so is not
        available - by purpose. Luckily it is possible to use a
        awt::XGraphics and 'paint' from there.
        It would also be possible to find out why the child windows
        do not get constructed and where this may need to be done,
        but for now just add 'painting' the Controls by using the
        path utilizing the awt::XGraphics mechanism. For that
        purpose, do set an awt::XGraphics at the CairoSDPR if it
        gets constructed using an OutputDevice.
        It may be that we need to think about how to solve this
        for SDPRs that get constructed from scratch, e.g.
        when using createPixelProcessor2DFromScratch. This would
        mean to somehow construct a awt::XGraphics from a cairo
        surface, probably using an OutputDevice as in-betwen
        step, but for now this change solves the problem.
        
        Change-Id: I3bc653deab7f0b2902081b0fdbd501dfcc78383b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180967
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [163ddd7a841fc4ee2b4a79a5ec5e5635bcc0cbc2]

        tdf#158221 sw: fix performance disaster in SwInsertBookmarkDlg
        
        Moving the shell cursor without Start/EndAction results in formatting
        and repainting for every bookmark :(
        
        (regression from commit aa6ec3f79607478213272283b7eb17ec2116173c)
        
        Change-Id: I2eb77a7a6aa48a1f218957245d75399bddb594ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180965
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cd00ca413da8d29f54749c04493e85937a2fa38]

        use more OutputDevice::Push/Pop (tdf#164799 related)
        
        So we save/restore the fill colors properly
        
        Change-Id: I9613587d76785905346b341e24b5491188d095d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-31  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [94eb08183ac2be67f11d45e6ad8e703d39115246]

        tdf#164950 Set GtkCssProvider at APPLICATION level, not USER
        
        - when set at the user level, the set_background() calls
          cannot override the theme settings as USER level has
          higher priority than APPLICATION level.
        
        Change-Id: If8819b5838f6f9ff1cf5ec83e380b7546aafce93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180977
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-31  rafaelhlima  <rafael.palma.lima@gmail.com>  [80c90897657896b94689513119bf05eafc21519b]

        tdf#164685 Cleanup SfxItemSetFixed - Part 2
        
        This is the continuation of the cleanup of class SfxItemSetFixed.
        
        This patch contains a few edge cases, more specifically when SfxItemSetFixed is used in header files.
        
        Change-Id: I2ed48177ca53311b20b9e2a8aed95d3b1c87f250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180309
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2025-01-30  Michael Weghorn  <m.weghorn@posteo.de>  [5797e5448ed990047771ff65e033ac521b3b2a7d]

        tdf#164899 Don't call SystemWindow::SetNotebookBar recursively
        
        Fix crash with the backtrace below when opening sample doc
        attachment 198795 from tdf#164885 with macros enabled
        when using the qt6 VCL plugin.
        
        sfx2::SfxNotebookBar::StateMethod (frame 80) calls
        SystemWindow::SetNotebookBar (frame 79) which calls
        ImplBorderWindow::SetNotebookBar (frame 78) which
        first disposes and clears the existing
        ImplBorderWindow::mpNotebookBar and then creates
        a new one.
        
        However, calling the NotebookBar ctor triggers
        a recursive call to sfx2::SfxNotebookBar::StateMethod
        and SystemWindow::SetNotebookBar again (see frame 4).
        
        When that one calls SystemWindow::SetNotebookBar,
        it skips the logic to set a new NoteBookbar, but
        the following call to the getter
        SystemWindow::GetNotebookBar returns null, because
        the previous ImplBorderWindow::SetNotebookBar (in frame 78, s. above)
        hasn't finished yet.
        
        For now, prevent such recursion from happening by
        returning early in sfx2::SfxNotebookBar::StateMethod
        if the NoteBookBar is already in the process of
        getting set up.
        
            Thread 1 received signal SIGSEGV, Segmentation fault.
            0x00007f3030de3eb5 in std::__uniq_ptr_impl<WindowImpl, std::default_delete<WindowImpl> >::_M_ptr (this=0x8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:193
            193           pointer    _M_ptr() const noexcept { return std::get<0>(_M_t); }
            (rr) bt
            #0  0x00007f3030de3eb5 in std::__uniq_ptr_impl<WindowImpl, std::default_delete<WindowImpl> >::_M_ptr (this=0x8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:193
            #1  0x00007f3030de3e95 in std::unique_ptr<WindowImpl, std::default_delete<WindowImpl> >::get (this=0x8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:465
            #2  0x00007f3030e1c6e5 in std::unique_ptr<WindowImpl, std::default_delete<WindowImpl> >::operator bool (this=0x8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:482
            #3  0x00007f30310a1c67 in vcl::Window::Show (this=0x0, bVisible=true, nFlags=ShowFlags::NONE) at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:2193
            #4  0x00007f3036cabbf2 in sfx2::SfxNotebookBar::StateMethod (pSysWindow=0x561c07f14910, xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, rUIFile=u"modules/swriter/ui/", bReloadNotebookbar=false)
                at /home/michi/development/git/libreoffice/sfx2/source/notebookbar/SfxNotebookBar.cxx:524
            #5  0x00007f3036cab110 in sfx2::SfxNotebookBar::StateMethod (rBindings=..., rUIFile=u"modules/swriter/ui/", bReloadNotebookbar=false) at /home/michi/development/git/libreoffice/sfx2/source/notebookbar/SfxNotebookBar.cxx:422
            #6  0x00007f300b7bc406 in SwDocShell::GetState (this=0x561c07140db0, rSet=SfxItemSet of pool 0x561c07b742c0 with parent 0x0 and Which ranges: [(10338, 10338)])
                at /home/michi/development/git/libreoffice/sw/source/uibase/app/docsh.cxx:1117
            #7  0x00007f300b7bb7cd in SfxStubSwDocShellGetState (pShell=0x561c07140db0, rSet=SfxItemSet of pool 0x561c07b742c0 with parent 0x0 and Which ranges: [(10338, 10338)]) at workdir/SdiTarget/sw/sdi/swslots.hxx:1427
            #8  0x00007f3036822a3a in SfxShell::GetSlotState (this=0x561c07140db0, nSlotId=10338, pIF=0x561c0add4a90, pStateSet=0x0) at /home/michi/development/git/libreoffice/sfx2/source/control/shell.cxx:492
            #9  0x00007f30367d1278 in SfxDispatcher::QueryState (this=0x561c0b151ec0, nSlot=10338, rState=...) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:2030
            #10 0x00007f30367cc4e0 in SfxDispatcher::Update_Impl (this=0x561c0b151ec0, bForce=true) at /home/michi/development/git/libreoffice/sfx2/source/control/dispatch.cxx:1135
            #11 0x00007f303682374e in DispatcherUpdate_Impl (pArg=0x561c0b151ec0) at /home/michi/development/git/libreoffice/sfx2/source/control/shell.cxx:662
            #12 0x00007f303349e861 in Link<void*, void>::Call (this=0x561c0b87eae0, data=0x561c0b151ec0) at include/tools/link.hxx:105
            #13 0x00007f30334fb3c8 in svtools::AsynchronLink::HandleCall_PostUserEvent (this=0x561c0b87eae0) at /home/michi/development/git/libreoffice/svtools/source/control/asynclink.cxx:66
            #14 0x00007f30334fb31d in svtools::AsynchronLink::LinkStubHandleCall_PostUserEvent (instance=0x561c0b87eae0, data=0x0) at /home/michi/development/git/libreoffice/svtools/source/control/asynclink.cxx:58
            #15 0x00007f30310c86c1 in Link<void*, void>::Call (this=0x561c0b8811c8, data=0x0) at include/tools/link.hxx:105
            #16 0x00007f30310c48c1 in ImplHandleUserEvent (pSVEvent=0x561c0b8811c0) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2285
            #17 0x00007f30310c17ea in ImplWindowFrameProc (_pWindow=0x561c07e19360, nEvent=SalEvent::UserEvent, pEvent=0x561c0b8811c0) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2849
            #18 0x00007f3026f5523c in SalFrame::CallCallback (this=0x561c07b6bb80, nEvent=SalEvent::UserEvent, pEvent=0x561c0b8811c0) at vcl/inc/salframe.hxx:311
            #19 0x00007f3026f75d7f in QtInstance::ProcessEvent (this=0x561c066f4840, aEvent=...) at vcl/qt6/../qt5/QtInstance.cxx:527
            #20 0x00007f30317c879d in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7ffd6c8cf850) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:119
            #21 0x00007f30317c8676 in SalUserEventList::DispatchUserEvents (this=0x561c066f4878, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:120
            #22 0x00007f3026f727c1 in QtInstance::ImplYield (this=0x561c066f4840, bWait=false, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:453
            #23 0x00007f3026f758e1 in QtInstance::DoYield (this=0x561c066f4840, bWait=false, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:475
            #24 0x00007f3031893896 in ImplYield (i_bWait=false, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #25 0x00007f30318934ab in Application::Reschedule (i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:409
            #26 0x00007f303736f734 in SbiRuntime::Step (this=0x561c0b2b4e50) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:778
            #27 0x00007f30372638c9 in (anonymous namespace)::RunInitGuard::run (this=0x7ffd6c8d0810) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1017
            #28 0x00007f303726262d in SbModule::Run (this=0x561c0e7f98c0, pMeth=0x561c0d8d6080) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1177
            #29 0x00007f3037261b41 in SbModule::Notify (this=0x561c0e7f98c0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:775
            #30 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c0e851df0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #31 0x00007f303726879b in SbMethod::Broadcast (this=0x561c0e851d20, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2115
            #32 0x00007f30373b2a65 in SbxObject::Call (this=0x561c0e53fa50, rName="interceptor_queryDispatch", pParam=0x561c0cea64d0) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxobj.cxx:273
            #33 0x00007f30371fa7a6 in StarBASIC::Call (this=0x561c0e53fa50, rName="interceptor_queryDispatch", pParam=0x561c0cea64d0) at /home/michi/development/git/libreoffice/basic/source/classes/sb.cxx:1318
            #34 0x00007f303722eeb5 in (anonymous namespace)::BasicAllListener_Impl::firing_impl (this=0x561c0e891750, Event=..., pRet=0x7ffd6c8d1218) at /home/michi/development/git/libreoffice/basic/source/classes/sbunoobj.cxx:3852
            #35 0x00007f303722e9c1 in (anonymous namespace)::BasicAllListener_Impl::approveFiring (this=0x561c0e891750, Event=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbunoobj.cxx:3882
            #36 0x00007f303722eb1c in non-virtual thunk to (anonymous namespace)::BasicAllListener_Impl::approveFiring(com::sun::star::script::AllEventObject const&) () at /home/michi/development/git/libreoffice/instdir/program/libsblo.so
            #37 0x00007f303722f5b8 in (anonymous namespace)::InvocationToAllListenerMapper::invoke (this=0x561c0e891280, FunctionName="queryDispatch", Params=uno::Sequence of length 3 = {...})
                at /home/michi/development/git/libreoffice/basic/source/classes/sbunoobj.cxx:4002
            #38 0x00007f303722f8e4 in non-virtual thunk to (anonymous namespace)::InvocationToAllListenerMapper::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) () at /home/michi/development/git/libreoffice/instdir/program/libsblo.so
            #39 0x00007f30237370ed in gcc3::callVirtualMethod
                (pThis=0x561c0e8912a8, nVtableIndex=4, pRegisterReturn=0x7ffd6c8d1480, pReturnTypeRef=0x561c0670f930, bSimpleReturn=false, pStack=0x7ffd6c8d14a0, nStack=0, pGPR=0x7ffd6c8d1790, pFPR=0x7ffd6c8d1750)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:87
            #40 0x00007f3023735e5b in cpp_call (pThis=0x561c0e8915b0, aVtableSlot=..., pReturnTypeRef=0x561c0670f930, nParams=4, pParams=0x561c0e891c80, pUnoReturn=0x7ffd6c8d19f0, pUnoArgs=0x7ffd6c8d1a20, ppUnoExc=0x7ffd6c8d19d0)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:229
            #41 0x00007f3023735626 in unoInterfaceProxyDispatch (pUnoI=0x561c0e8915b0, pMemberDescr=0x561c0e893b50, pReturn=0x7ffd6c8d19f0, pArgs=0x7ffd6c8d1a20, ppException=0x7ffd6c8d19d0)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:409
            #42 0x00007f30112ef6f2 in stoc_invadp::(anonymous namespace)::AdapterImpl::invoke (this=0x561c0e893aa0, pMemberType=0x561c0e8964c0, pReturn=0x7ffd6c8d1b40, pArgs=0x7ffd6c8d1ae0, ppException=0x7ffd6c8d1c70)
                at /home/michi/development/git/libreoffice/stoc/source/invocation_adapterfactory/iafactory.cxx:456
            #43 0x00007f30112eea48 in stoc_invadp::adapter_dispatch (pUnoI=0x561c0e8923f0, pMemberType=0x561c0e8964c0, pReturn=0x7ffd6c8d1b40, pArgs=0x7ffd6c8d1ae0, ppException=0x7ffd6c8d1c70)
                at /home/michi/development/git/libreoffice/stoc/source/invocation_adapterfactory/iafactory.cxx:604
            #44 0x00007f3023723fdb in cpp2uno_call
                (pThis=0x561c0e895580, pMemberTypeDescr=0x561c0e8964c0, pReturnTypeRef=0x561c082efdb0, nParams=3, pParams=0x561c0e8951c0, gpreg=0x7ffd6c8d2398, fpreg=0x7ffd6c8d23a0, ovrflw=0x7ffd6c8d23f0, pRegisterReturn=0x7ffd6c8d2350)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:190
            #45 0x00007f30237237f5 in cpp_vtable_call (nFunctionIndex=3, nVtableOffset=0, gpreg=0x7ffd6c8d2370, fpreg=0x7ffd6c8d23a0, ovrflw=0x7ffd6c8d23f0, pRegisterReturn=0x7ffd6c8d2350)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:388
            #46 0x00007f30237457a6 in privateSnippetExecutor () at /home/michi/development/git/libreoffice/instdir/program/libgcc3_uno.so
            #47 0x00007f303784bf19 in framework::InterceptionHelper::queryDispatch (this=0x561c07eea430, aURL=..., sTargetFrameName="", nSearchFlags=0) at /home/michi/development/git/libreoffice/framework/source/dispatch/interceptionhelper.cxx:87
            #48 0x00007f303784c03c in non-virtual thunk to framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) () at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #49 0x00007f3037a04d31 in (anonymous namespace)::XFrameImpl::queryDispatch (this=0x561c07ef7d40, aURL=..., sTargetFrameName="", nSearchFlags=0) at /home/michi/development/git/libreoffice/framework/source/services/frame.cxx:2332
            #50 0x00007f3037a08b3c in non-virtual thunk to (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) () at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #51 0x00007f30336b4d74 in svt::ToolboxController::bindListener (this=0x561c0e74d190) at /home/michi/development/git/libreoffice/svtools/source/uno/toolboxcontroller.cxx:513
            #52 0x00007f30336b4987 in svt::ToolboxController::update (this=0x561c0e74d190) at /home/michi/development/git/libreoffice/svtools/source/uno/toolboxcontroller.cxx:235
            #53 0x00007f3036cfff76 in sfx2::sidebar::ControllerFactory::CreateImageController (rxFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, rxParentWindow=uno::Reference to (VCLXToolBox *) 0x561c0cea66b0)
                at /home/michi/development/git/libreoffice/sfx2/source/sidebar/ControllerFactory.cxx:49
            #54 0x00007f3036cf3f71 in sfx2::sidebar::SidebarToolBox::SidebarToolBox (this=0x561c0e74bba0, vtt=0x7f3036ed3bd0 <VTT for sfx2::sidebar::(anonymous namespace)::NotebookbarToolBox+8>, pParentWindow=0x561c0e790ca0)
                at /home/michi/development/git/libreoffice/sfx2/source/sidebar/SidebarToolBox.cxx:75
            #55 0x00007f3036cf6688 in sfx2::sidebar::(anonymous namespace)::NotebookbarToolBox::NotebookbarToolBox (this=0x561c0e74bba0, pParentWindow=0x561c0e790ca0)
                at /home/michi/development/git/libreoffice/sfx2/source/sidebar/SidebarToolBox.cxx:318
            #56 0x00007f3036cf6312 in VclPtrInstance<sfx2::sidebar::(anonymous namespace)::NotebookbarToolBox>::VclPtrInstance<VclPtr<vcl::Window> const&> (this=0x7ffd6c8d2e80, arg=...) at include/vcl/vclptr.hxx:280
            #57 0x00007f3036cf6242 in makeNotebookbarToolBox (rRet=..., pParent=..., rMap=std::__debug::map with 7 elements = {...}) at /home/michi/development/git/libreoffice/sfx2/source/sidebar/SidebarToolBox.cxx:336
            #58 0x00007f3030e685dc in VclBuilder::makeObject (this=0x561c0e6fad80, pParent=0x561c0e790ca0, name="sfxlo-NotebookbarToolBox", id="SectionBottom", rMap=std::__debug::map with 7 elements = {...})
                at /home/michi/development/git/libreoffice/vcl/source/window/builder.cxx:1991
            #59 0x00007f3030e6dd6e in VclBuilder::insertObject
                (this=0x561c0e6fad80, pParent=0x561c0e790ca0, rClass="sfxlo-NotebookbarToolBox", rID="SectionBottom", rProps=std::__debug::map with 7 elements = {...}, rPango=std::__debug::map with 0 elements, rAtk=std::__debug::map with 0 elements) at /home/michi/development/git/libreoffice/vcl/source/window/builder.cxx:2309
            #60 0x00007f3030ebcaba in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0e790ca0, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:234
            #61 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0e790ca0, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #62 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0e0b7e00, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #63 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0e0b7e00, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #64 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0e0b7d10, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #65 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0e0b7d10, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #66 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0e75b7b0, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #67 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0e75b7b0, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #68 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0d9b1f20, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #69 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0d9b1f20, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #70 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0c2d0930, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #71 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0c2d0930, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #72 0x00007f3030ebcb92 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleObject
                (this=0x561c0e6fad80, pParent=0x561c0c2d0930, pAtkProps=0x0, reader=..., sType="", sInternalChild="", bToolbarItem=false) at include/vcl/widgetbuilder.hxx:237
            #73 0x00007f3030ebb52d in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::handleChild (this=0x561c0e6fad80, pParent=0x561c0c2d0930, pAtkProps=0x0, reader=..., bToolbarItem=false)
                at include/vcl/widgetbuilder.hxx:131
            #74 0x00007f3030e7dd88 in WidgetBuilder<vcl::Window, VclPtr<vcl::Window>, PopupMenu, VclPtr<PopupMenu> >::processUIFile (this=0x561c0e6fad80, pParent=0x561c0c2d0930) at include/vcl/widgetbuilder.hxx:70
            #75 0x00007f3030e598af in VclBuilder::VclBuilder
                (this=0x561c0e6fad80, pParent=0x561c0c2d0930, sUIDir=u"file:///home/michi/development/git/libreoffice/instdir/program/../share/config/soffice.cfg/", sUIFile="modules/swriter/ui/notebookbar.ui", sID="", xFrame=empty uno::Reference, bLegacy=true, pNotebookBarAddonsItem=0x7ffd6c8da430) at /home/michi/development/git/libreoffice/vcl/source/window/builder.cxx:531
            #76 0x00007f30311c39d2 in NotebookBar::NotebookBar
                (this=0x561c0c2d0930, pParent=0x561c07ed3110, rID="NotebookBar", rUIXMLDescription="modules/swriter/ui/notebookbar.ui", rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, aNotebookBarAddonsItem=...)
                at /home/michi/development/git/libreoffice/vcl/source/control/notebookbar.cxx:100
            #77 0x00007f3030e3eae4 in VclPtr<NotebookBar>::Create<ImplBorderWindow*, char const (&) [12], rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, NotebookBarAddonsItem const&>
                (arg=@0x7ffd6c8da0b8: 0x561c07ed3110, arg=..., arg="modules/swriter/ui/notebookbar.ui", arg=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, arg=...) at include/vcl/vclptr.hxx:129
            #78 0x00007f3030e3ca45 in ImplBorderWindow::SetNotebookBar
                (this=0x561c07ed3110, rUIXMLDescription="modules/swriter/ui/notebookbar.ui", rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, aNotebookBarAddonsItem=...)
                at /home/michi/development/git/libreoffice/vcl/source/window/brdwin.cxx:1945
            #79 0x00007f30310372ac in SystemWindow::SetNotebookBar
                (this=0x561c07f14910, rUIXMLDescription="modules/swriter/ui/notebookbar.ui", rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, aNotebookBarAddonsItem=..., bReloadNotebookbar=true)
                at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:916
            #80 0x00007f3036cabba1 in sfx2::SfxNotebookBar::StateMethod (pSysWindow=0x561c07f14910, xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, rUIFile=u"modules/swriter/ui/", bReloadNotebookbar=true)
                at /home/michi/development/git/libreoffice/sfx2/source/notebookbar/SfxNotebookBar.cxx:522
            #81 0x00007f3036cab110 in sfx2::SfxNotebookBar::StateMethod (rBindings=..., rUIFile=u"modules/swriter/ui/", bReloadNotebookbar=true) at /home/michi/development/git/libreoffice/sfx2/source/notebookbar/SfxNotebookBar.cxx:422
            #82 0x00007f3036cad6a2 in sfx2::SfxNotebookBar::ReloadNotebookBar (sUIPath=u"modules/swriter/ui/") at /home/michi/development/git/libreoffice/sfx2/source/notebookbar/SfxNotebookBar.cxx:683
            #83 0x00007f3036e36b9b in SfxViewFrame::Notify (this=0x561c0b023e80, rHint=...) at /home/michi/development/git/libreoffice/sfx2/source/view/viewfrm.cxx:1574
            #84 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c07140db0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #85 0x00007f303665e339 in (anonymous namespace)::SfxEventAsyncer_Impl::IdleHdl (this=0x561c0c330660, pAsyncIdle=0x561c0c3318b0) at /home/michi/development/git/libreoffice/sfx2/source/appl/appcfg.cxx:109
            #86 0x00007f303665dead in (anonymous namespace)::SfxEventAsyncer_Impl::LinkStubIdleHdl (instance=0x561c0c330660, data=0x561c0c3318b0) at /home/michi/development/git/libreoffice/sfx2/source/appl/appcfg.cxx:102
            #87 0x00007f30318b9641 in Link<Timer*, void>::Call (this=0x561c0c3318d0, data=0x561c0c3318b0) at include/tools/link.hxx:105
            #88 0x00007f30318b94ac in Timer::Invoke (this=0x561c0c3318b0) at /home/michi/development/git/libreoffice/vcl/source/app/timer.cxx:75
            #89 0x00007f30318680b8 in Scheduler::CallbackTaskScheduling () at /home/michi/development/git/libreoffice/vcl/source/app/scheduler.cxx:509
            #90 0x00007f302703fad2 in SalTimer::CallCallback (this=0x561c07960ba0) at vcl/inc/saltimer.hxx:53
            #91 0x00007f302703ef6a in QtTimer::timeoutActivated (this=0x561c07960b90) at vcl/qt6/../qt5/QtTimer.cxx:51
            #92 0x00007f30270400a1 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtTimer::*)()>::call(void (QtTimer::*)(), QtTimer*, void**)::{lambda()#1}::operator()() const (this=0x7ffd6c8dd310)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtTimer::*)()>::call(void (QtTimer::*)(), QtTimer*, void**)::{lambda()#1}&&) (args=0x7ffd6c8dd6d0, fn=...)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #94 0x00007f302703ff0b in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtTimer::*)()>::call(void (QtTimer::*)(), QtTimer*, void**)
                (f=(void (QtTimer::*)(QtTimer * const)) 0x7f302703ee70 <QtTimer::timeoutActivated()>, o=0x561c07960b90, arg=0x7ffd6c8dd6d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #95 0x00007f302703fe8d in QtPrivate::FunctionPointer<void (QtTimer::*)()>::call<QtPrivate::List<>, void>(void (QtTimer::*)(), QtTimer*, void**)
                (f=(void (QtTimer::*)(QtTimer * const)) 0x7f302703ee70 <QtTimer::timeoutActivated()>, o=0x561c07960b90, arg=0x7ffd6c8dd6d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #96 0x00007f302703fdb6 in QtPrivate::QCallableObject<void (QtTimer::*)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*)
                (which=1, this_=0x561c07961090, r=0x561c07960b90, a=0x7ffd6c8dd6d0, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #97 0x00007f302605fc52 in QtPrivate::QSlotObjectBase::call (this=0x561c07961090, r=0x561c07960b90, a=0x7ffd6c8dd6d0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #98 0x00007f302611e6e4 in doActivate<false> (sender=0x561c07960bb0, signal_index=3, argv=0x7ffd6c8dd6d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4128
            #99 0x00007f30261141b3 in QMetaObject::activate (sender=0x561c07960bb0, m=0x7f3026a10b18 <QTimer::staticMetaObject>, local_signal_index=0, argv=0x7ffd6c8dd6d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4188
            #100 0x00007f302614bb9b in QMetaObject::activate<void, QTimer::QPrivateSignal> (sender=0x561c07960bb0, mo=0x7f3026a10b18 <QTimer::staticMetaObject>, local_signal_index=0, ret=0x0, args=...)
                at qtbase/src/corelib/kernel/qobjectdefs.h:306
            #101 0x00007f302614a3d5 in QTimer::timeout (this=0x561c07960bb0, _t1=...) at qtbase/src/corelib/Core_autogen/include/moc_qtimer.cpp:182
            #102 0x00007f302614a38f in QTimer::timerEvent (this=0x561c07960bb0, e=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtimer.cpp:285
            #103 0x00007f302610aef6 in QObject::event (this=0x561c07960bb0, e=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1404
            #104 0x00007f3023fe2dc0 in QApplicationPrivate::notify_helper (this=0x561c06676ae0, receiver=0x561c07960bb0, e=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3305
            #105 0x00007f3023fe6cdd in QApplication::notify (this=0x561c06663e20, receiver=0x561c07960bb0, e=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3255
            #106 0x00007f3026049dc9 in QCoreApplication::notifyInternal2 (receiver=0x561c07960bb0, event=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #107 0x00007f302604aa39 in QCoreApplication::sendEvent (receiver=0x561c07960bb0, event=0x7ffd6c8de470) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1552
            #108 0x00007f30263dd90f in QTimerInfoList::activateTimers (this=0x561c066eff30) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtimerinfo_unix.cpp:426
            #109 0x00007f302663b565 in timerSourceDispatch (source=0x561c066efed0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:152
            #110 0x00007f302663b844 in idleTimerSourceDispatch (source=0x561c066eff70) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:199
            #111 0x00007f302cd0b81f in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #112 0x00007f302cd0da57 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #113 0x00007f302cd0e1c0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #114 0x00007f302663a30b in QEventDispatcherGlib::processEvents (this=0x561c06667e80, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #115 0x00007f3025776a98 in QPAEventDispatcherGlib::processEvents (this=0x561c06667e80, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #116 0x00007f3026063980 in QEventLoop::processEvents (this=0x7ffd6c8de888, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:104
            #117 0x00007f3026063bd3 in QEventLoop::exec (this=0x7ffd6c8de888, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventloop.cpp:186
            #118 0x00007f3024483eb7 in QDialog::exec (this=0x561c0e897c80) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:575
            #119 0x00007f3026fe0cfb in QtInstanceMessageDialog::run (this=0x561c0e7811b0) at vcl/qt6/../qt5/QtInstanceMessageDialog.cxx:159
            #120 0x00007f30373468c0 in SbRtl_MsgBox (rPar=...) at /home/michi/development/git/libreoffice/basic/source/runtime/methods.cxx:4242
            #121 0x00007f3037327ca2 in SbiStdObject::Notify (this=0x561c0e785e70, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/runtime/stdobj.cxx:1103
            #122 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c0e7b5620, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #123 0x00007f30373c7ad4 in SbxVariable::Broadcast (this=0x561c0e856200, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:154
            #124 0x00007f30373c04fd in SbxValue::SbxValue (this=0x561c0c2d1e10, vtt=0x7f30373eb6d0 <VTT for SbxMethod+16>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:68
            #125 0x00007f30373c6674 in SbxVariable::SbxVariable (this=0x561c0c2d1e10, vtt=0x7f30373eb6c8 <VTT for SbxMethod+8>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:48
            #126 0x00007f30373b6f4a in SbxMethod::SbxMethod (this=0x561c0c2d1e10, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxobj.cxx:842
            #127 0x00007f303737782a in SbiRuntime::FindElement (this=0x561c0e890580, pObj=0x561c0e785e70, nOp1=32786, nOp2=2, nNotFound=..., bLocal=false, bStatic=false)
                at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:3701
            #128 0x00007f303736ab71 in SbiRuntime::StepRTL (this=0x561c0e890580, nOp1=32786, nOp2=2) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4124
            #129 0x00007f303736fa77 in SbiRuntime::Step (this=0x561c0e890580) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:808
            #130 0x00007f30372638c9 in (anonymous namespace)::RunInitGuard::run (this=0x7ffd6c8df5d0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1017
            #131 0x00007f303726262d in SbModule::Run (this=0x561c0e7f98c0, pMeth=0x561c0e886740) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1177
            #132 0x00007f3037261b41 in SbModule::Notify (this=0x561c0e7f98c0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:775
            #133 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c0e850ce0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #134 0x00007f303726879b in SbMethod::Broadcast (this=0x561c0e850d60, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2115
            #135 0x00007f30373c04fd in SbxValue::SbxValue (this=0x561c0e87af00, vtt=0x7f30373eb6d0 <VTT for SbxMethod+16>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:68
            #136 0x00007f30373c6674 in SbxVariable::SbxVariable (this=0x561c0e87af00, vtt=0x7f30373eb6c8 <VTT for SbxMethod+8>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:48
            #137 0x00007f30373b6f4a in SbxMethod::SbxMethod (this=0x561c0e87af00, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxobj.cxx:842
            #138 0x00007f303737782a in SbiRuntime::FindElement (this=0x561c0e854db0, pObj=0x561c0e7f98c0, nOp1=32775, nOp2=0, nNotFound=..., bLocal=true, bStatic=false)
                at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:3701
            #139 0x00007f3037378e95 in SbiRuntime::StepFIND_Impl (this=0x561c0e854db0, pObj=0x561c0e7f98c0, nOp1=32775, nOp2=0, nNotFound=..., bStatic=false) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4134
            #140 0x00007f303736ac0d in SbiRuntime::StepFIND (this=0x561c0e854db0, nOp1=32775, nOp2=0) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4140
            #141 0x00007f303736fa77 in SbiRuntime::Step (this=0x561c0e854db0) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:808
            #142 0x00007f30372638c9 in (anonymous namespace)::RunInitGuard::run (this=0x7ffd6c8e04d0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1017
            #143 0x00007f303726262d in SbModule::Run (this=0x561c0e7f98c0, pMeth=0x561c0e8544a0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1177
            #144 0x00007f3037261b41 in SbModule::Notify (this=0x561c0e7f98c0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:775
            #145 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c0e850490, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #146 0x00007f303726879b in SbMethod::Broadcast (this=0x561c0e84e6b0, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2115
            #147 0x00007f30373c0ef3 in SbxValue::Get (this=0x561c0e84e6b0, rRes=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:290
            #148 0x00007f303726848b in SbMethod::Call (this=0x561c0e84e6b0, pRet=0x561c0e854c20, pCaller=0x0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2071
            #149 0x00007f301134bcfe in basprov::BasicScriptImpl::invoke (this=0x561c0e807880, aParams=uno::Sequence of length 1 = {...}, aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence)
                at /home/michi/development/git/libreoffice/scripting/source/basprov/basscript.cxx:262
            #150 0x00007f301134c4ac in non-virtual thunk to basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) () at /home/michi/development/git/libreoffice/instdir/program/../program/libbasprovlo.so
            #151 0x00007f3011258dc7 in scripting_protocolhandler::ScriptProtocolHandler::dispatchWithNotification (this=0x561c0b213f70, aURL=..., lArgs=uno::Sequence of length 1 = {...}, xListener=empty uno::Reference)
                at /home/michi/development/git/libreoffice/scripting/source/protocolhandler/scripthandler.cxx:213
            #152 0x00007f301125a2ef in scripting_protocolhandler::ScriptProtocolHandler::dispatch (this=0x561c0b213f70, aURL=..., lArgs=uno::Sequence of length 1 = {...})
                at /home/michi/development/git/libreoffice/scripting/source/protocolhandler/scripthandler.cxx:286
            #153 0x00007f3036cbe0ff in SfxEvents_Impl::Execute (aProperties=uno::Sequence of length 2 = {...}, aTrigger=..., pDoc=0x561c07140db0) at /home/michi/development/git/libreoffice/sfx2/source/notify/eventsupplier.cxx:268
            #154 0x00007f3036cbe474 in SfxEvents_Impl::documentEventOccured (this=0x561c0b104010, aEvent=...) at /home/michi/development/git/libreoffice/sfx2/source/notify/eventsupplier.cxx:293
            #155 0x00007f3036c40e77 in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator()
                (this=0x7ffd6c8e27c0, listener=uno::Reference to (SfxEvents_Impl *) 0x561c0b104040) at /home/michi/development/git/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3335
            #156 0x00007f3036c31e05 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<(anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> > (this=0x561c0a9accf8, func=...) at include/comphelper/interfacecontainer3.hxx:275
            #157 0x00007f3036c31553 in SfxBaseModel::postEvent_Impl (this=0x561c0adc4440, aName="OnViewCreated", xController=uno::Reference to (SwXTextView *) 0x561c0b116e18, supplement=uno::Any(void))
                at /home/michi/development/git/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3369
            #158 0x00007f3036c30a7d in SfxBaseModel::Notify (this=0x561c0adc4440, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3002
            #159 0x00007f3035d51a4c in SfxBroadcaster::Broadcast (this=0x561c07140db0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #160 0x00007f303665db14 in SfxApplication::NotifyEvent (this=0x561c07e29130, rEventHint=..., bSynchron=true) at /home/michi/development/git/libreoffice/sfx2/source/appl/appcfg.cxx:343
            #161 0x00007f3036e057ee in SfxBaseController::attachFrame (this=0x561c0b116df0, xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0)
                at /home/michi/development/git/libreoffice/sfx2/source/view/sfxbasecontroller.cxx:536
            #162 0x00007f3036dd6519 in utl::ConnectFrameControllerModel
                (xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, xController=uno::Reference to (SwXTextView *) 0x561c0b116e18, xModel=uno::Reference to (SwXTextDocument *) 0x561c0adc44d0)
                at include/unotools/fcm.hxx:57
            #163 0x00007f3036dd2b21 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView
                (i_rModel=uno::Reference to (SwXTextDocument *) 0x561c0adc44d0, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0, i_rViewFactoryArgs=..., i_rViewName="Default")
                at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:585
            #164 0x00007f3036dd00bc in (anonymous namespace)::SfxFrameLoader_Impl::load (this=0x561c07efffa0, rArgs=uno::Sequence of length 12 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x561c07ef7db0)
                at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:764
            #165 0x00007f30379c3004 in framework::LoadEnv::impl_loadContent (this=0x561c078f1e18) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:1180
            #166 0x00007f30379c0165 in framework::LoadEnv::start (this=0x561c078f1e18) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:415
            #167 0x00007f30379bde12 in framework::LoadEnv::startLoading
                (this=0x561c078f1e18, sURL="file:///tmp/hyperlink.fodt", lMediaDescriptor=uno::Sequence of length 4 = {...}, xBaseFrame=uno::Reference to (framework::Desktop *) 0x561c079aab88, sTarget="_default", nSearchFlags=0, eFeature=(LoadEnvFeatures::WorkWithUI | LoadEnvFeatures::AllowContentHandler)) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:311
            #168 0x00007f3037856cd1 in framework::LoadDispatcher::impl_dispatch (this=0x561c078f1dc0, rURL=..., lArguments=uno::Sequence of length 4 = {...}, xListener=empty uno::Reference)
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:107
            #169 0x00007f3037857a31 in framework::LoadDispatcher::dispatchWithReturnValue (this=0x561c078f1dc0, rURL=..., lArguments=uno::Sequence of length 4 = {...})
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:60
            #170 0x00007f3037857ad4 in non-virtual thunk to framework::LoadDispatcher::dispatchWithReturnValue(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/framework/source/dispatch/loaddispatcher.cxx:60
            #171 0x00007f3038e10e00 in comphelper::SynchronousDispatch::dispatch
                (xStartPoint=uno::Reference to (framework::Desktop *) 0x561c079aab78, sURL="file:///tmp/hyperlink.fodt", sTarget="_default", lArguments=uno::Sequence of length 4 = {...})
                at /home/michi/development/git/libreoffice/comphelper/source/misc/synchronousdispatch.cxx:62
            #172 0x00007f303a774d3d in desktop::DispatchWatcher::executeDispatchRequests (this=0x561c082f00b0, aDispatchRequestsList=std::__debug::vector of length 1, capacity 1 = {...}, bNoTerminate=false)
                at /home/michi/development/git/libreoffice/desktop/source/app/dispatchwatcher.cxx:529
            #173 0x00007f303a79307a in desktop::RequestHandler::ExecuteCmdLineRequests (aRequest=..., noTerminate=false) at /home/michi/development/git/libreoffice/desktop/source/app/officeipcthread.cxx:1347
            #174 0x00007f303a72d937 in desktop::Desktop::OpenClients () at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:2203
            #175 0x00007f303a72b8c3 in desktop::Desktop::OpenClients_Impl (this=0x7ffd6c8eaae0) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1979
            #176 0x00007f303a729f5d in desktop::Desktop::LinkStubOpenClients_Impl (instance=0x7ffd6c8eaae0, data=0x0) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1963
            #177 0x00007f30310c86c1 in Link<void*, void>::Call (this=0x561c07f3e718, data=0x0) at include/tools/link.hxx:105
            #178 0x00007f30310c48c1 in ImplHandleUserEvent (pSVEvent=0x561c07f3e710) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2285
            #179 0x00007f30310c17ea in ImplWindowFrameProc (_pWindow=0x561c07e19360, nEvent=SalEvent::UserEvent, pEvent=0x561c07f3e710) at /home/michi/development/git/libreoffice/vcl/source/window/winproc.cxx:2849
            #180 0x00007f3026f5523c in SalFrame::CallCallback (this=0x561c07b6bb80, nEvent=SalEvent::UserEvent, pEvent=0x561c07f3e710) at vcl/inc/salframe.hxx:311
            #181 0x00007f3026f75d7f in QtInstance::ProcessEvent (this=0x561c066f4840, aEvent=...) at vcl/qt6/../qt5/QtInstance.cxx:527
            #182 0x00007f30317c879d in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7ffd6c8e8f20) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:119
            #183 0x00007f30317c8676 in SalUserEventList::DispatchUserEvents (this=0x561c066f4878, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/salusereventlist.cxx:120
            #184 0x00007f3026f727c1 in QtInstance::ImplYield (this=0x561c066f4840, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:453
            #185 0x00007f3026f758e1 in QtInstance::DoYield (this=0x561c066f4840, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:475
            #186 0x00007f3031893896 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:385
            #187 0x00007f30318931af in Application::Yield () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:488
            #188 0x00007f3031892f90 in Application::Execute () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:360
            #189 0x00007f303a727f39 in desktop::Desktop::Main (this=0x7ffd6c8eaae0) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1679
            #190 0x00007f30318b4d16 in ImplSVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:230
            #191 0x00007f30318b6909 in SVMain () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:248
            #192 0x00007f303a7a181a in soffice_main () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:122
            #193 0x0000561bdaf4ba6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #194 0x0000561bdaf4ba47 in main (argc=2, argv=0x7ffd6c8eace8) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Ie10498c60554783b33aaa03070eebd8252ed9561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180951
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1d250ff2e146281a2cc3d2c72d3fd373b139627]

        tdf#150999: Add support for CHOOSEROWS function
        
        Change-Id: If7de1b243a6040424a5712ba28017176b7e36101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180955
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8dccf51cabbc8e9e269ed97cece2d4808d28cd34]

        ucbhelper::Content can do nothing with a "private:stream"
        
        so don't bother, and skip throwing exceptions in this case
        
        Change-Id: Ie5f4dc5fb24f117be7e671dc83766c7804a98005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180962
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-30  Jean-Pierre Ledure  <jp@ledure.be>  [74f93a222bca93010a19b3ba7c5d5e9d4042dfbe]

        ScriptForge (SFWidgets) fix popup menu bugs
        
        1) when in Python the event argument of
            CreateScriptService('popupmenu', event)
           is set to None, an error was raised
           although not justified.
        
        2) when
            popupmenu.Execute(False)
           is run and the user clicks outside the popup
           menu, the doc says a zero-length string
           should be returned. It retuned 0.
        
        No impact on user documentation.
        
        Change-Id: I4e1a1372800a728b994813b021f928fcf2b2603c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180960
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-30  Michael Stahl  <michael.stahl@allotropia.de>  [3227660e55416254463234f35a43268b9b4c2c9e]

        (tdf#159377 related) sw: fix undo of table pasted in middle of paragraph
        
        The problem is that the !bCanMoveBack path doesn't work if the insert
        position's content index isn't 0.
        
        (regression from commit fcd4222d36e1864452163e5c94976eea353bbaf0)
        
        Change-Id: I746db2187ab8f2e24eb694dc94d7eea9f50e2d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180948
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-30  Michael Stahl  <michael.stahl@allotropia.de>  [3bbbe366e455f1b165f2f913fffd27f3a0e03a2d]

        tdf#159377 sw: fix undo of paste table into footnote
        
        Tables aren't allowed in footnotes, hence pasting a table into a
        footnote will paste only the text nodes in the cells but not the table
        nodes.
        
        This code isn't prepared for this situation, so the adjustment of the
        position doesn't happen.
        
                if (pCopyPam->GetPoint()->GetNode().IsStartNode())
                    pCopyPam->GetPoint()->Adjust(SwNodeOffset(-1));
        
        But then the corresponding adjustment in SwUndoInserts::SetInsertRange()
        does happen and the stored start node index is wrong.
        
        It looks like both of these adjustments can simply be removed.
        
        (regression from commit fcd4222d36e1864452163e5c94976eea353bbaf0)
        
        Change-Id: Ib419b29da552cf1df7150178924c45e3743cd7d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180947
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-01-30  Michael Stahl  <michael.stahl@allotropia.de>  [ff16c4e3f27efc0fc9ed734b19ae778482566cdb]

        tdf#158867 offapi,i18npool,starmath: fix "," in Math again
        
        This is essentially the same bug that was fixed in commit
        2caa9d7ddcff3f6e380c306b737e9b5e9cdaf4c2 "Resolves: tdf#127873 accept
        ',' comma group separator in number entities again".
        
        The problem is that sw wants to recognize group separators only if there
        are 3 digits following so it really looks like a number (see bug
        tdf#42518), but starmath really wants to recognize either comma or dot
        as a decimal separator and uses the GROUP_SEPARATOR_IN_NUMBER as a hack
        to get this behaviour, so the same parser can work in any locale.
        
        Introduce new constant GROUP_SEPARATOR_IN_NUMBER_3 so that sw and
        starmath can request different parsing.
        
        sc/source/core/tool/compiler.cxx also uses GROUP_SEPARATOR_IN_NUMBER and
        it's unclear to me what is desired there, but there are no known
        regression reports so leave the behaviour there unchanged.
        
        (regression from commit 1bd9a51b826015746069fcc0d02a30a2ddc7e7f5)
        
        Change-Id: Icb7662f26d89677cf84ccad07a2ea4c380587ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180920
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-30  Skyler Grey  <skyler.grey@collabora.com>  [523662727ccdd5c03842dd2c6607dace6b86cb41]

        feat(iOS): Allow use of desktop clipboard code
        
        Historically, iOS has used pasteboard code instead of the normal
        clipboard code, forming a different clipboard flow for the Collabora
        Online app for iOS. This is "not ideal" for consistency in clipboard
        behavior between iOS and other platforms, so we're switching iOS to use
        the same clipboard APIs as everywhere else. This means that we need this
        desktop clipboard code to be compiled into iOS.
        
        Change-Id: I42567ad64641913817a26d1494858393501b6503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180946
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-30  Michael Weghorn  <m.weghorn@posteo.de>  [5d2b2b9f381bbfb19ffd393f361c1fdd4a898550]

        qt: Return from QtFrame::SetPosSize after running it in main thread
        
        If QtFrame::SetPosSize is called from a thread other
        than the main thread, it gets executed in the main
        thread via QtInstance::RunInMainThread.
        Once that's done, return, and don't try to run
        the rest of the method once again in the original thread.
        
        This was missed in
        
            commit 5ef991ffc226424a673662b6e478db124825022a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 30 17:20:41 2024 +0200
        
                tdf#162696 qt: Always run QtFrame::SetPosSize in main thread
        
        and resulted in a deadlock when opening the sample doc
        attachment 198264 from tdf#164460 with the qt6 VCL plugin
        and running the macro, using a current qtbase git dev build.
        
        With this and the 2 previous commits
        
            Change-Id: I0ee7aa62893da92b886acfd3d47be0bdb10d6007
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 30 11:38:52 2025 +0100
        
                qt: Ensure more methods are run in main thread
        
        and
        
            Change-Id: I787bb74644dcf29ccbd6c7a59fe5ca9fc7a50061
            commit 9cfc139a5a9ec499741cfc95669f6469a17e5329
            Date:   Thu Jan 30 11:47:53 2025 +0100
        
                qt: Ensure QMenu gets destroyed in main thread
        
        in place, the macro now gets executed and the
        form shows as expected without triggering asserts
        or deadlocks.
        
        Change-Id: I503e03133eb09e1bbea5e7549fbbcdd3c3379d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180939
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-30  Michael Weghorn  <m.weghorn@posteo.de>  [d44bab9b49b29f84b90eece51a1aba22102f30ef]

        qt: Ensure QMenu gets destroyed in main thread
        
        This fixes this assert triggered when opening the sample doc
        attachment 198264 from tdf#164460 with the qt6 VCL plugin
        and running the macro, using a current qtbase git dev build:
        
            ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread QThread(0x7fffbc000f50). Receiver 'QWidget(0x555558de1c00)' was created in thread QThread(0x555555564ee0, name = "Qt mainThread")", file /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 530
        
            Thread 24 "DocumentEventNo" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fffc4f4f6c0 (LWP 626865)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff789de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff7849d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe3302efd in qAbort () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:46
            #5  0x00007fffe3349788 in qt_message_fatal<QString&> (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2062
            #6  0x00007fffe334298d in qt_message (msgType=QtFatalMsg, context=..., msg=0x7fffe3a8edf3 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fffc4f41650)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:342
            #7  0x00007fffe3344cdd in QMessageLogger::fatal (this=0x7fffc4f417f0, msg=0x7fffe3a8edf3 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:831
            #8  0x00007fffe3302fb3 in qt_assert_x
                (where=0x7fffe3a98873 "QCoreApplication::sendEvent", what=0x7fff60309060 "Cannot send events to objects owned by a different thread. Current thread QThread(0x7fffbc000f50). Receiver 'QWidget(0x555558de1c00)' was created in thread QThread(0x555555564ee0, name = \"Qt mainThrea"..., file=0x7fffe3a9864f "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=530)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:115
            #9  0x00007fffe3447d56 in QCoreApplicationPrivate::checkReceiverThread (receiver=0x555558de1c00) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:526
            #10 0x00007fffe13e3f91 in QApplication::notify (this=0x555555564e20, receiver=0x555558de1c00, e=0x7fffc4f42478) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2590
            #11 0x00007fffe3449dc9 in QCoreApplication::notifyInternal2 (receiver=0x555558de1c00, event=0x7fffc4f42478) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #12 0x00007fffe344aa39 in QCoreApplication::sendEvent (receiver=0x555558de1c00, event=0x7fffc4f42478) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1552
            #13 0x00007fffe148741a in QWidget::~QWidget (this=0x555558de1c00) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1569
            #14 0x00007fffe1780ab3 in QMenu::~QMenu (this=0x555558de1c00) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qmenu.cpp:1798
            #15 0x00007fffe1780b7d in QMenu::~QMenu (this=0x555558de1c00) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qmenu.cpp:1782
            #16 0x00007fffe443bf08 in std::default_delete<QMenu>::operator() (this=0x555558de18d8, __ptr=0x555558de1c00) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #17 0x00007fffe443bd5f in std::unique_ptr<QMenu, std::default_delete<QMenu> >::~unique_ptr (this=0x555558de18d8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:399
            #18 0x00007fffe44379fc in QtMenu::~QtMenu (this=0x555558de1860) at vcl/inc/qt6/../qt5/QtMenu.hxx:40
            #19 0x00007fffe4437a59 in QtMenu::~QtMenu (this=0x555558de1860) at vcl/inc/qt6/../qt5/QtMenu.hxx:40
            #20 0x00007fffee3b8ce8 in std::default_delete<SalMenu>::operator() (this=0x7fff6030d320, __ptr=0x555558de1870) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #21 0x00007fffee3b8c28 in std::__uniq_ptr_impl<SalMenu, std::default_delete<SalMenu> >::reset (this=0x7fff6030d320, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:205
            #22 0x00007fffee3b1a2d in std::unique_ptr<SalMenu, std::default_delete<SalMenu> >::reset (this=0x7fff6030d320, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:504
            #23 0x00007fffee3a27b8 in Menu::dispose (this=0x7fff6030d210) at /home/michi/development/git/libreoffice/vcl/source/window/menu.cxx:225
            #24 0x00007fffee7122a3 in VclReferenceBase::disposeOnce (this=0x7fff6030d210) at /home/michi/development/git/libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #25 0x00007fffee283ddb in VclPtr<PopupMenu>::disposeAndClear (this=0x7fff60310ba8) at include/vcl/vclptr.hxx:207
            #26 0x00007fffeebdba5c in SalInstanceMenu::~SalInstanceMenu (this=0x7fff60310b80) at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:974
            #27 0x00007fffeebdbab9 in SalInstanceMenu::~SalInstanceMenu (this=0x7fff60310b80) at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:971
            #28 0x00007ffff275023b in std::default_delete<weld::Menu>::operator() (this=0x7fffc4f42960, __ptr=0x7fff60310b80) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #29 0x00007ffff273552f in std::unique_ptr<weld::Menu, std::default_delete<weld::Menu> >::~unique_ptr (this=0x7fffc4f42960) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:399
            #30 0x00007ffff2a300fd in (anonymous namespace)::SelectionTypePopup::~SelectionTypePopup (this=0x7fffc4f42950) at /home/michi/development/git/libreoffice/svx/source/stbctrls/selctrl.cxx:48
            #31 0x00007ffff2a2fd68 in SvxSelectionModeControl::StateChangedAtStatusBarControl (this=0x7fff602fa6b0, eState=SfxItemState::DEFAULT, pState=0x7fff6025c330) at /home/michi/development/git/libreoffice/svx/source/stbctrls/selctrl.cxx:130
            #32 0x00007ffff419db7e in SfxStatusBarControl::statusChanged (this=0x7fff602fa6b0, rEvent=...) at /home/michi/development/git/libreoffice/sfx2/source/statbar/stbitem.cxx:263
            #33 0x00007ffff3c9f158 in SfxDispatchController_Impl::addStatusListener (this=0x7fff601c92c0, aListener=uno::Reference to (SvxSelectionModeControl *) 0x7fff602fa6c0, aURL=...)
                at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:841
            #34 0x00007ffff3c9ee04 in SfxOfficeDispatch::addStatusListener (this=0x7fff6030bd90, aListener=uno::Reference to (SvxSelectionModeControl *) 0x7fff602fa6c0, aURL=...)
                at /home/michi/development/git/libreoffice/sfx2/source/control/unoctitm.cxx:283
            #35 0x00007ffff0aa6737 in svt::StatusbarController::bindListener (this=0x7fff602fa6b0) at /home/michi/development/git/libreoffice/svtools/source/uno/statusbarcontroller.cxx:462
            #36 0x00007ffff0aa60c9 in svt::StatusbarController::update (this=0x7fff602fa6b0) at /home/michi/development/git/libreoffice/svtools/source/uno/statusbarcontroller.cxx:169
            #37 0x00007ffff4f4242b in framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > >::operator() (this=0x7fffc4f43117, rElement={...})
                at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:69
            #38 0x00007ffff4f3efaf in std::for_each<__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > >, std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > >, std::bidirectional_iterator_tag>, framework::(anonymous namespace)::lcl_UpdateController<std::__debug::map<unsigned short, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, com::sun::star::uno::Reference<com::sun::star::frame::XStatusbarController> > > > > > (__first={...}, __last={...}, __f=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_algo.h:3786
            #39 0x00007ffff4f3e365 in framework::StatusBarManager::UpdateControllers (this=0x7fff602ccc10) at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:269
            #40 0x00007ffff4f40c4b in framework::StatusBarManager::FillStatusBar (this=0x7fff602ccc10, rItemContainer=uno::Reference to (framework::ConstItemContainer *) 0x7fff6029b8c8)
                at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarmanager.cxx:479
            #41 0x00007ffff4f4b7f8 in framework::StatusBarWrapper::initialize (this=0x7fff602d1320, aArguments=uno::Sequence of length 4 = {...}) at /home/michi/development/git/libreoffice/framework/source/uielement/statusbarwrapper.cxx:117
            #42 0x00007ffff4ff9ac4 in framework::MenuBarFactory::CreateUIElement
            [...]
        
        Change-Id: I787bb74644dcf29ccbd6c7a59fe5ca9fc7a50061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180938
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-30  Michael Weghorn  <m.weghorn@posteo.de>  [6afa3931f0aa8141ff1c5ba4bbbe6e30bef58069]

        qt: Ensure more methods are run in main thread
        
        This fixes various asserts triggered when opening the sample doc
        attachment 198264 from tdf#164460 with the qt6 VCL plugin
        and using a current qtbase git dev build, for example:
        
            ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread QThread(0x7fffbc000f50). Receiver 'QWidgetWindow(0x555556dd9f10, name = "QtMainWindowClassWindow")' was created in thread QThread(0x555555564ee0, name = "Qt mainThread")", file /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 530
        
            Thread 24 "DocumentEventNo" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fffc4f4f6c0 (LWP 625101)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff789de2f in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff7849d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe3302efd in qAbort () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:46
            #5  0x00007fffe3349788 in qt_message_fatal<QString&> (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2062
            #6  0x00007fffe334298d in qt_message (msgType=QtFatalMsg, context=..., msg=0x7fffe3a8edf3 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fffc4f478f0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:342
            #7  0x00007fffe3344cdd in QMessageLogger::fatal (this=0x7fffc4f47a90, msg=0x7fffe3a8edf3 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:831
            #8  0x00007fffe3302fb3 in qt_assert_x
                (where=0x7fffe3a98873 "QCoreApplication::sendEvent", what=0x7fffbc000c00 "Cannot send events to objects owned by a different thread. Current thread QThread(0x7fffbc000f50). Receiver 'QWidgetWindow(0x555556dd9f10, name = \"QtMainWindowClassWindow\")' was created in thread QThr"..., file=0x7fffe3a9864f "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=530)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:115
            #9  0x00007fffe3447d56 in QCoreApplicationPrivate::checkReceiverThread (receiver=0x555556dd9f10) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:526
            #10 0x00007fffe13e3f91 in QApplication::notify (this=0x555555564e20, receiver=0x555556dd9f10, e=0x7fffc4f486a0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2590
            #11 0x00007fffe3449dc9 in QCoreApplication::notifyInternal2 (receiver=0x555556dd9f10, event=0x7fffc4f486a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1112
            #12 0x00007fffe344aa39 in QCoreApplication::sendEvent (receiver=0x555556dd9f10, event=0x7fffc4f486a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1552
            #13 0x00007fffe235f1ff in QWindowPrivate::setCursor (this=0x5555571f48a0, newCursor=0x7fffc4f48770) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:3269
            #14 0x00007fffe235f0ce in QWindow::setCursor (this=0x555556dd9f10, cursor=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:3227
            #15 0x00007fffe1492921 in applyCursor (w=0x555556e5d360, c=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:5020
            #16 0x00007fffe148e6e4 in qt_qpa_set_cursor (w=0x55555707ea30, force=false) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:5058
            #17 0x00007fffe14927cc in QWidgetPrivate::setCursor_sys (this=0x555556e37f10, cursor=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:4995
            #18 0x00007fffe149274e in QWidget::setCursor (this=0x55555707ea30, cursor=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:4985
            #19 0x00007fffe43493b8 in QtFrame::SetPointer (this=0x555556dc14c0, ePointerStyle=PointerStyle::Wait) at vcl/qt6/../qt5/QtFrame.cxx:794
            #20 0x00007fffee3db06e in vcl::Window::EnterWait (this=0x555556df3620) at /home/michi/development/git/libreoffice/vcl/source/window/mouse.cxx:614
            #21 0x00007fffeebd9b16 in SalInstanceWidget::set_busy_cursor (this=0x5555575c9520, bBusy=true) at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:625
            #22 0x00007fffa505266a in weld::WaitObject::WaitObject (this=0x7fffc4f48a48, pWindow=0x5555575c9560) at include/vcl/weld.hxx:611
            #23 0x00007fffa504c0b1 in dbaui::OApplicationController::ensureConnection (this=0x555556e115f0, _pErrorInfo=0x7fffc4f48b48) at /home/michi/development/git/libreoffice/dbaccess/source/ui/app/AppControllerDnD.cxx:310
            #24 0x00007fffa505f75a in dbaui::OApplicationController::connect (this=0x555556e115f0) at /home/michi/development/git/libreoffice/dbaccess/source/ui/app/AppControllerGen.cxx:316
            #25 0x00007fffe0b370ed in gcc3::callVirtualMethod (pThis=0x555556e11968, nVtableIndex=8, pRegisterReturn=0x0, pReturnTypeRef=0x555555604370, bSimpleReturn=true, pStack=0x7fffc4f48c70, nStack=0, pGPR=0x7fffc4f48f40, pFPR=0x7fffc4f48f00)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:87
            #26 0x00007fffe0b35e5b in cpp_call (pThis=0x7fffbc2af2e0, aVtableSlot=..., pReturnTypeRef=0x555555604370, nParams=0, pParams=0x0, pUnoReturn=0x0, pUnoArgs=0x7fffc4f490c0, ppUnoExc=0x7fffc4f49370)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:229
            #27 0x00007fffe0b35626 in unoInterfaceProxyDispatch (pUnoI=0x7fffbc2af2e0, pMemberDescr=0x7fffbc2b0bd0, pReturn=0x0, pArgs=0x7fffc4f490c0, ppException=0x7fffc4f49370)
                at /home/michi/development/git/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:409
            #28 0x00007fffb6fe565a in stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke (this=0x7fffbc2b33d0, rObj=uno::Any("com.sun.star.frame.XController": ...), rArgs=empty uno::Sequence)
                at /home/michi/development/git/libreoffice/stoc/source/corereflection/criface.cxx:591
            #29 0x00007fffb6fe5e74 in non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libreflectionlo.so
            #30 0x00007ffff4618bde in SbUnoObject::Notify (this=0x7fffbc29fea0, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbunoobj.cxx:2249
            #31 0x00007ffff3151a4c in SfxBroadcaster::Broadcast (this=0x7fffbc2b5480, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #32 0x00007ffff47c7ad4 in SbxVariable::Broadcast (this=0x7fffbc2b5990, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:154
            #33 0x00007ffff47c04fd in SbxValue::SbxValue (this=0x7fffbc2808c0, vtt=0x7ffff47eb6d0 <VTT for SbxMethod+16>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:68
            #34 0x00007ffff47c6674 in SbxVariable::SbxVariable (this=0x7fffbc2808c0, vtt=0x7ffff47eb6c8 <VTT for SbxMethod+8>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:48
            #35 0x00007ffff47b6f4a in SbxMethod::SbxMethod (this=0x7fffbc2808c0, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxobj.cxx:842
            #36 0x00007ffff477782a in SbiRuntime::FindElement (this=0x7fffbc1bfb00, pObj=0x7fffbc29fea0, nOp1=75, nOp2=12, nNotFound=..., bLocal=false, bStatic=false) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:3701
            #37 0x00007ffff476adc2 in SbiRuntime::StepELEM (this=0x7fffbc1bfb00, nOp1=75, nOp2=12) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4187
            #38 0x00007ffff476fa77 in SbiRuntime::Step (this=0x7fffbc1bfb00) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:808
            #39 0x00007ffff46638c9 in (anonymous namespace)::RunInitGuard::run (this=0x7fffc4f4a4c0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1017
            #40 0x00007ffff466262d in SbModule::Run (this=0x7fffbc093b00, pMeth=0x7fffbc16d040) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1177
            #41 0x00007ffff4661b41 in SbModule::Notify (this=0x7fffbc093b00, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:775
            #42 0x00007ffff3151a4c in SfxBroadcaster::Broadcast (this=0x7fffbc094fb0, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #43 0x00007ffff466879b in SbMethod::Broadcast (this=0x7fffbc095060, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2115
            #44 0x00007ffff47c04fd in SbxValue::SbxValue (this=0x7fffbc1b9590, vtt=0x7ffff47eb6d0 <VTT for SbxMethod+16>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:68
            #45 0x00007ffff47c6674 in SbxVariable::SbxVariable (this=0x7fffbc1b9590, vtt=0x7ffff47eb6c8 <VTT for SbxMethod+8>, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvar.cxx:48
            #46 0x00007ffff47b6f4a in SbxMethod::SbxMethod (this=0x7fffbc1b9590, r=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxobj.cxx:842
            #47 0x00007ffff477782a in SbiRuntime::FindElement (this=0x7fffbc16d360, pObj=0x7fffbc093b00, nOp1=10, nOp2=0, nNotFound=..., bLocal=true, bStatic=false) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:3701
            #48 0x00007ffff4778e95 in SbiRuntime::StepFIND_Impl (this=0x7fffbc16d360, pObj=0x7fffbc093b00, nOp1=10, nOp2=0, nNotFound=..., bStatic=false) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4134
            #49 0x00007ffff476ac0d in SbiRuntime::StepFIND (this=0x7fffbc16d360, nOp1=10, nOp2=0) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:4140
            #50 0x00007ffff476fa77 in SbiRuntime::Step (this=0x7fffbc16d360) at /home/michi/development/git/libreoffice/basic/source/runtime/runtime.cxx:808
            #51 0x00007ffff46638c9 in (anonymous namespace)::RunInitGuard::run (this=0x7fffc4f4b3c0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1017
            #52 0x00007ffff466262d in SbModule::Run (this=0x7fffbc093b00, pMeth=0x7fffbc162760) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:1177
            #53 0x00007ffff4661b41 in SbModule::Notify (this=0x7fffbc093b00, rBC=..., rHint=...) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:775
            #54 0x00007ffff3151a4c in SfxBroadcaster::Broadcast (this=0x7fffbc093f10, rHint=...) at /home/michi/development/git/libreoffice/svl/source/notify/SfxBroadcaster.cxx:43
            #55 0x00007ffff466879b in SbMethod::Broadcast (this=0x7fffbc0938c0, nHintId=SfxHintId::BasicDataWanted) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2115
            #56 0x00007ffff47c0ef3 in SbxValue::Get (this=0x7fffbc0938c0, rRes=...) at /home/michi/development/git/libreoffice/basic/source/sbx/sbxvalue.cxx:290
            #57 0x00007ffff466848b in SbMethod::Call (this=0x7fffbc0938c0, pRet=0x7fffbc156ef0, pCaller=0x0) at /home/michi/development/git/libreoffice/basic/source/classes/sbxmod.cxx:2071
            #58 0x00007fffdc9f4cfe in basprov::BasicScriptImpl::invoke (this=0x7fffbc012bd0, aParams=uno::Sequence of length 1 = {...}, aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence)
                at /home/michi/development/git/libreoffice/scripting/source/basprov/basscript.cxx:262
            #59 0x00007fffdc9f54ac in non-virtual thunk to basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) () at /home/michi/development/git/libreoffice/instdir/program/../program/libbasprovlo.so
            #60 0x00007fffdffeedc7 in scripting_protocolhandler::ScriptProtocolHandler::dispatchWithNotification (this=0x7fffbc002330, aURL=..., lArgs=uno::Sequence of length 1 = {...}, xListener=empty uno::Reference)
                at /home/michi/development/git/libreoffice/scripting/source/protocolhandler/scripthandler.cxx:213
            #61 0x00007fffdfff02ef in scripting_protocolhandler::ScriptProtocolHandler::dispatch (this=0x7fffbc002330, aURL=..., lArgs=uno::Sequence of length 1 = {...})
                at /home/michi/development/git/libreoffice/scripting/source/protocolhandler/scripthandler.cxx:286
            #62 0x00007fffc6f7d166 in dbaccess::(anonymous namespace)::lcl_dispatchScriptURL_throw
                (xWeakDocument=..., xURLTransformer=uno::Reference to ((anonymous namespace)::URLTransformer *) 0x555557223d28, _rScriptURL="vnd.sun.star.script:Standard.Backup.DatabaseStart?language=Basic&location=document", _rTrigger=...)
                at /home/michi/development/git/libreoffice/dbaccess/source/core/dataaccess/documenteventexecutor.cxx:100
            #63 0x00007fffc6f7cbe6 in dbaccess::DocumentEventExecutor::documentEventOccured (this=0x55555721f030, Event=...) at /home/michi/development/git/libreoffice/dbaccess/source/core/dataaccess/documenteventexecutor.cxx:169
            #64 0x00007fffc6f8dfb7 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent>::operator()
                (this=0x7fffc4f4d220, listener=uno::Reference to (dbaccess::DocumentEventExecutor *) 0x55555721f058) at include/comphelper/interfacecontainer3.hxx:249
            #65 0x00007fffc6f8dd45 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> > (this=0x55555721f368, func=...) at include/comphelper/interfacecontainer3.hxx:275
            #66 0x00007fffc6f7fd33 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::notifyEach<com::sun::star::document::DocumentEvent>
                (this=0x55555721f368, NotificationMethod=&virtual table offset 32, Event=...) at include/comphelper/interfacecontainer3.hxx:290
            #67 0x00007fffc6f7f007 in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow (this=0x55555721f320, _rEvent=...) at /home/michi/development/git/libreoffice/dbaccess/source/core/dataaccess/documenteventnotifier.cxx:197
            #68 0x00007fffc6f7f3b9 in dbaccess::DocumentEventNotifier_Impl::processEvent (this=0x55555721f320, _rEvent=...) at /home/michi/development/git/libreoffice/dbaccess/source/core/dataaccess/documenteventnotifier.cxx:230
            #69 0x00007ffff6119f47 in comphelper::AsyncEventNotifierBase::execute (this=0x5555575b4de0) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:139
            #70 0x00007ffff611b074 in comphelper::AsyncEventNotifierAutoJoin::run (this=0x5555575b4de0) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:246
            #71 0x00007ffff612743e in threadFunc (param=0x5555575b4df0) at include/osl/thread.hxx:189
            #72 0x00007ffff7fa2ccb in osl_thread_start_Impl (pData=0x5555575a22b0) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:237
            #73 0x00007ffff789c083 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:447
            #74 0x00007ffff791a7b8 in __GI___clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78
        
        Change-Id: I0ee7aa62893da92b886acfd3d47be0bdb10d6007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180937
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-30  Oliver Specht  <oliver.specht@cib.de>  [e72919a30132cabeb3e3fda2f9ce16688e9f40eb]

        tdf#151278 tdf#164724 tdf#164728 tdf#164729 switch off charts number format from source
        
        Labels get their number format usually from source. When copy/pasted
        the chart has no connection to a source format anymore.
        The related LinkNumberFormatToSource flag is therefore reset.
        The label (data series) number format used is now also saved.
        
        Change-Id: I640083ec0036f116dec94cc982317e1e7992328b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180600
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [39c50d9aedc1721ec5ffaa4568b668171e0342bf]

        tdf#164185 Activate View - Boundaries in Writer by default
        
        Verifying this requires deleting user/registrymodifications.xcu
        
        Change-Id: Ie034833e116697bd66bf7c924c17e05457ee5d49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180943
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6f6ed57f052159e25f0987869a21bf60222087b]

        cid#1641647 silence Unchecked return value
        
        and
        
        cid#1641646 Unchecked return value
        cid#1641648 Unchecked return value
        cid#1641645 Unchecked return value
        
        Change-Id: Ief552a1de6a6120599d7019ad5696b4970969337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e575acbb93c325648d3ad16ec97661dfa1f3178a]

        tdf#143157 - Include first and secondary keys in index fields
        
        Include first and secondary keys in the tooltip of index fields.
        
        Change-Id: Ic35257d04c89c5aec979909e0aca9725f21e8702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180908
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [295665abd80a5e83beb17c5d55d5817668804008]

        cid#1641649 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I247fffbf6058e395ab5c1d5968d3f0ae63be9e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-30  László Németh  <nemeth@numbertext.org>  [f1bbce4068828f3d1240afd50b228d820c17e848]

        tdf#164901 sw inline heading: fix lost floating tables
        
        Style separators inside floating tables resulted losing of
        the floating tables. In this case, don't handle style separators,
        as before commit 56588663a0fddc005c12afaa7d3f8874d036875f.
        
        Regression since commit 56588663a0fddc005c12afaa7d3f8874d036875f
        "tdf#131728 sw inline heading: fix DOCX paragraph layout interoperability".
        
        Change-Id: I30b6683b2312636405960efc65b5af2b6b4dbfa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180925
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-01-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [778feb1f6706aae990146aa0ff7bc557b28835a2]

        Update git submodules
        
        * Update translations from branch 'master'
          to 51596110f62555f9c56794c25c140bde7a66ea59
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I6bd8294d9e1ff583b3af4c43834d22833d8c7de2
            
2025-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [157d82354876493542b7ac1066b847fee59ebc61]

        Revert "Adapting basegfx.py due to blocking in some situations"
        
        This reverts commit 3c82f49fcee3f1e4ddae8919993dde57e8bbab2d.
        
        This fixes the use of these pretty-printers in gdb.
        Otherwise the call to 'if self.exists()' throws an error
        because the exists() method does not exist.
        
        Change-Id: Ie3cd2f50a08508ed44f4a062777f3fb455b34d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180935
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-30  Noel Grandin  <noelgrandin@collabora.co.uk>  [ff3c9428e7936ed409fb012ffb66d0321f169e94]

        tdf#164799 Tooltips appear empty
        
        regression from
            commit e0d4d178caff1414a9a21fa57f06bc8d4d2c389a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 13 15:03:05 2025 +0200
            Change alpha behavour of OutputDevice::SetFillColor
        
        where DrawColorWallpaper is not correctly saving/restoring the
        fill color.
        Previously this worked because GetFillColor would return a
        transparent color if no fill color was set, and a transparent
        fill color would be interpreted as "no color" when drawing.
        
        Change-Id: I63e1ba2df0a5e2088d018068fe0a0e45453b7c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-30  Miklos Vajna  <vmiklos@collabora.com>  [7af540ddeb42a3a733f258a77e17c7ebb16d4571]

        tdf#164904 RTF import: fix unexpected CharFontFamily
        
        Open the RTF in Word, the font fallback is serif, open in Writer, our
        fallback is sans.
        
        \froman is not parsed by the RTF import, but the default font family was
        ROMAN and that worked in the past.
        
        Fix the problem by only setting the property in case the tokenizer has a
        value for it, there is a difference between not setting it vs setting it
        to "don't know".
        
        Regression from commit d06de2e049761b7b9e8a95f17557d309812f7acc
        (Related: tdf#162072 DOCX import: handle font family for characters,
        2024-07-19).
        
        Change-Id: I4253ac7e27fab7d3e8e61c43659589b4fc177d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180934
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-30  Mike Kaganski  <mike.kaganski@collabora.com>  [c45b278542f41a61c223c13f74e910badb3a8851]

        Avoid some dynamic_casts
        
        ... where we already know that the object we are passing is SwWrtShell
        
        Change-Id: Idfcbc05fa013860df8bb711fa4e565f929c978f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180926
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-30  Michael Weghorn  <m.weghorn@posteo.de>  [daaaed50c10eb790b9035d4ca7181a19e1c246a9]

        vcl: Drop SvListView::Impl::ActionClear detour
        
        Change-Id: Id113b64bce226790b9329ba2848a759a8c50c9f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180924
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b73e1530906696bf6eac0857d20b43be5d47f1bd]

        avoid uno_type_sequence_construct cost
        
        Change-Id: I5ef2d5d0b88fdffa1e425ffb182586a897858fde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180915
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-30  Heiko Tietze  <tietze.heiko@gmail.com>  [7f4901ded76fa3f3dffaef2d8f68d5c4803d98a2]

        More appealing design for alientformat warn dialog
        
        Change-Id: I575f24e6b8f9dd08bd8797343a86ac25b49f19b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180713
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [7a9e303d0ffad7b83beccfe1918f962d2de04a37]

        icon choice ctrl a11y: Don't announce selection change on focus (II)
        
            Change-Id: I013da234b78f872b1b286769acdf38a66d58801b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 29 16:45:23 2025 +0100
        
                icon choice ctrl a11y: Don't announce selection change on focus
        
        had implemented not "inventing" a selection change event
        in the a11y implementation, AccessibleIconChoiceCtrl,
        when the icon choice control receives focus.
        
        However, the SvtIconChoiceCtrl itself was also sending
        a VclEventId::ListboxSelect event that gets processed
        by the AccessibleIconChoiceCtrl, which again resulted
        in an a11y selection changed event getting emitted
        (`object:selection-changed` for AT-SPI2).
        
        No longer send that event to not notify of a fake
        selection change. (From all I can see,
        AccessibleIconChoiceCtrl is the only consumer
        of that event.)
        
        Actual changes in the selected entry are still
        announced fine (see SvxIconChoiceCtrl_Impl::EntrySelected).
        
        With the qt6 VCL plugin on Linux and the Orca screen
        reader, this makes Orca now announce "List with 4 items"
        before it announces the currently selected item
        when focus moves to the icon choice control
        ("vertical tabbar") in the "Insert" -> "Hyperlink"
        dialog in Writer. (Previously, only the accessible
        name of the selected item was announced, but not
        the list it is contained in.)
        
        Change-Id: I0a49a034f37fb4fb3a7ea6953c2e545fec184f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180913
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [88522bbe48cc1173cac32a40de1524b8492da15b]

        icon choice ctrl a11y: Separate selection from active descendant change
        
        When receiving a VclEventId::ListboxSelect event,
        always send an a11y event to notify about the changed
        selection if an entry is selected, regardless of whether
        or not the icon choice control has focus.
        
        Make only the ACTIVE_DESCENDANT_CHANGED event
        conditional on focus, as that is the event that
        notifies about the child that newly receives focus.
        
        Change-Id: Ibea29092ff33be69fde098777b13a9fa96b19c8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180912
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [155e1013734aee83124aee16f745784a55f17f93]

        icon choice ctrl a11y: Don't announce selection change on focus
        
        When processing a VclEventId::WindowGetFocus event,
        only send and event to notify that the active
        descendant (= child that has focus) of the icon choice control
        has changed, but don't announce a selection change event.
        The latter is handled in VclEventId::ListboxSelect instead.
        (And when receiving focus, the selected entry generally remains
        the same, i.e. the selection does not change.)
        
        Also, don't try to extract the selected entry
        from the data sent in the focus event.
        
        This code gets triggered for the "Insert" -> "Hyperlink"
        dialog in Writer.
        
        Change-Id: I013da234b78f872b1b286769acdf38a66d58801b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180911
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [c53f88f1d247e9538a8ab63e8bda539945332bcb]

        icon choice ctrl a11y: Drop commented code + outdated comment
        
        The `NotifyAccessibleEvent` call that the comment refers to
        was commented and replaced by different handling in
        
            commit efb23f29983f87104a684e7fab00b84fc59d131d
            Author: Steve Yin <steve_y@apache.org>
            Date:   Mon Nov 25 15:24:55 2013 +0000
        
                Integrate branch of IAccessible2
        
        Therefore, drop them.
        
        Change-Id: I18f6d80958e369b8a9ef3bce76a03531c3e79057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180910
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Mike Kaganski  <mike.kaganski@collabora.com>  [94636bc76489f27087eb4a5433693082631f3334]

        tdf#130672: handle Rule::factor explicitly
        
        When representing a signed number, the rule may consist of two subnodes:
        a punctuation bearing "+" or "-", and then the following digits (see
        'factor:' in connectivity/source/parse/sqlbison.y). After punctuation
        was added to the string buffer, the following number is passed to
        parseLeaf, where it checks if the buffer is not empty, and then adds
        a space between the preceding sign and the digits.
        
        This change handles the 'factor' rule explicitly.
        
        Change-Id: I0c929418ad88c5bf653a4e820f45b7d627b07da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180917
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-29  Michael Stahl  <michael.stahl@allotropia.de>  [b5967157b37904219865fd847b20938b3ccfbd72]

        tdf#156348 sw: fix crash on converting text to table with SwSetExpField
        
        The problem is that the table node only gets a SwFrameFormat assigned at
        the end of the operation after all the nodes have been split etc., and
        moving a field into a newly split node calls
        sw::FindNeighbourFrameForNode() which needs to handle table node without
        SwFrameFormat now when going backwards (not when going forwards because
        the table node is always before the nodes in the table).
        
        (regression from commit 9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749)
        
        Change-Id: Ia0c1f7d7b14f525aa8de4a2b6492c39b59f31052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180914
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-01-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0e9785ef0a3f0c350f8e719d2062f1c7beb801ad]

        tdf#164885: use SfxBindings::Execute instead of SfxDispatcher::ExecuteList
        
        Commit 502f7958d99e3aa27f4c1c1f33f4827055459da8 (pass a frame to use as
        parent for any dialog that may need to appear, 2023-11-16) switched to
        SfxDispatcher::ExecuteList, in order to pass there frame to be used as
        parent for dialogs.
        
        Later, in commit d7b33b1be8fee684e906f170f4001735c095056e (use SID_DOCFRAME
        for dialog parents if there is no SID_FILLFRAME, 2023-11-23), the fix
        was changed, and passing the frame got not needed.
        
        Since the change to SfxDispatcher::ExecuteList caused the regression
        (likely because SfxDispatcher unexpectedly uses a bit different method
        to find the slot server), and the original reason for the change is no
        more actual, let's revert to the older method.
        
        Change-Id: I6b126bf336dcf8cd3f49a3ce9682f3adc3bc208f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180909
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a8aa8d76dba4a32b1d082a87a188c3f0b1f666b4]

        tdf#164900 table text in different columns no longer lined up
        
        Revert "tdf#161846 use unordered_map in SfxItemPropertyMap"
        
        This reverts commit c39978f41dccbeb2e973c919a67d9b1d974f8f3c.
        
        Change-Id: I26cadb32b426fd3b48179b67c677213a78b4999c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180903
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-29  Michael Stahl  <michael.stahl@allotropia.de>  [f747378c4d5c3b2af0dc6ed2dc8cdbd2c4bf09c9]

        sw: layout: fix loop with table at the end of a section
        
        There is a table alone in a section, and there are 2 rows in the table,
        with the 2nd row split across page 1 and page 2.
        
        Due to space for another line of text being available, the table frame
        first does RemoveFollowFlowLine() etc and grows much higher than the
        section frame upper.
        
        Then in SwTabFrame::Join(), the section frame on page 2 is destroyed via
        SwSectionFrame::DelEmpty() so the section frame on page 1 doesn't have a
        follow.
        
        Then a SwTabFrame::Split() happens, and lcl_ShrinkCellsAndAllContent()
        ends up shrinking the section frame to 0 height (because there is no
        follow currently seen by SwSectionFrame::ToMaximize()), which is wrong
        as there is a 1st row in the table, so the table is still height 3712.
        
        If the table is directly in the body, then this works because the body
        frame doesn't shrink or grow.
        
        Then when the text frame in the 2nd row is formatted, it can't grow
        because SetRestrictTableGrowth(true) was called as a follow flow line
        exists, and in SwTabFrame::GrowFrame() nReal is -2777 due to the
        SwTabFrame being higher than the upper; the result is that the text
        frame is the same height/split at the same line as before
        SwTabFrame::MakeAll().
        
        Then the whole thing happens again until eventually
        warn:sw.layout:875613:875613:sw/source/core/layout/layouter.cxx:194: Looping Louie: Stage 1!
        
        Try to detect situation of too high table in section and propagate
        Shrink only until the section is the same height as the table.
        
        Change-Id: If4b6db8b03d93a3227ad223203f2b0c3f73d3cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180857
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [c8658bb7dc44b244031b6d73870547ce1aff20da]

        a11y: Replace Paragraph::checkDisposed uses with base class equivalent
        
        Use the existing OCommonAccessibleComponent::ensureAlive
        instead of reimplementing the logic here.
        
        Change-Id: I24d66e4c577a58619d968a4efcb1bad7a19aed7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180897
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [9ed4a07ceeafe09447431a8e2b8ce93a65cd2145]

        a11y: Use OAccessibleComponentHelper for text window Paragraph
        
        Similar to how
        
            commit 7107db3fe773629cc511eb5922bc9c28c9c5c60a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 24 18:57:58 2025 +0100
        
                toolkit a11y: Use OAccessibleComponentHelper for grid control
        
        did for AccessibleGridControlBase, also derive
        from OAccessibleComponentHelper for Paragraph
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods manually.
        
        Paragraph::getBounds already
        provides what is needed to implement
        Paragraph::implGetBounds, so just rename it.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed when
        testing this with Accerciser and Orca and the qt6
        VCL plugin with the IDE editor ("Tools" -> "Macros"
        -> "Edit Macros").
        
        Change-Id: I88ac869d115ceb13ccf48932f6d66d95bbd2fc9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180896
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [6e7fbfc362f397bbbe3f66b0ac8b15c62691db16]

        browsebox a11y: Use cppu::ImplInheritanceHelper
        
        Change-Id: Ia1bd0ee2cae89eeb6aeb6791183dda008f0631bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180895
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [0ebff46bb227d9c4ef86e68ae014d2d86b21da49]

        browsebox a11y: Drop AccessibleTabListBox::getTable
        
        There's already AccessibleBrowseBox::getTable in the
        base class that does the same.
        
        Change-Id: I045cace63fa1603a1ec0866c814b32a08ed27dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180894
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [daaf29a942b5be479d4600b61dfee22abd8ed502]

        browsebox a11y: Drop check for a11y context disposed from outside
        
        Since AccessibleBrowseBoxAccess is the owner, the context
        should never be disposed elsewhere/"from outside", so drop
        the corresponding check.
        
        See
        
            Change-Id: Ibe89b39be7540d68144400927bc96c318b2873c1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 28 09:23:53 2025 +0100
        
                uno grid a11y: Drop check for a11y context disposed from outside
        
        for another case elsewhere.
        
        Change-Id: I651530b34e3647942c6a9ee0edc10139a299339f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180893
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [eaaa5d04a27270ad13d5e470ed5f50d418e6fa4d]

        a11y: Drop IAccessibleTabListBox iface
        
        It was needed in the past to avoid a dependency
        cycle when the a11y classes were still in a separate
        accessibility module, but that's no more the case
        now that a11y clases are in vcl, too.
        
        Change-Id: I9f45e1f0d50126338ae93d7e859124dafeb28574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180850
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [1ebb0d64f2b5d40986a37a7c4561ef0af4973acf]

        a11y: Simplify SvHeaderTabListBox::CreateAccessible
        
        Now after
        
            Change-Id: I65489bd682b0d56ef0c1202319c7885c6dd4b6e8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 28 13:41:37 2025 +0100
        
                a11y: Use Reference to concrete AccessibleTabListBox
        
        , AccessibleTabListBox::getMyself is no more needed and
        SvHeaderTabListBox::CreateAccessible can be simplified
        a bit.
        
        Change-Id: I31c49ad0202a21d2894e90155e06dd515a490663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180849
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [a14b66f6b64d233579a9b721149a106777381968]

        a11y: Use Reference to concrete AccessibleTabListBox
        
        Instead of using the abstract IAccessibleTabListBox
        interface for SvHeaderTabListBox::m_pAccessible,
        use a Reference to the concrete implementation,
        AccessibleTabListBox.
        
        (Use rtl::Reference instead of a raw pointer as requested
        by clang plugin, and clear it in SvHeaderTabListBox::dispose.)
        
        This also prepares for further simplification in upcoming commits.
        
        Change-Id: I65489bd682b0d56ef0c1202319c7885c6dd4b6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180848
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [0ebf8c832ff4fe3b44801067a5994a4b122215a0]

        vcl a11y: Drop namespace "accessibility"
        
        Drop the "accessibility" namespace in which the classes
        moved to vcl from the earlier separate accessibility
        module were, see
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        In an upcoming Gerrit change [1] that namespace was
        now causing ambiguity in source files using
        
            using namespace css::uno;
        
        because a simple `accessibility` namespace specifier
        could now be for either the `accessibility` namespace
        removed with this commit or `css::uno::accessibility`.
        
        Sample from Windows CI failure [2]:
        
            C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/accessibility/vclxaccessiblecomponent.cxx(112): error C2872: 'accessibility': ambiguous symbol
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\vcl\inc\accessibility/accessibletablistbox.hxx(29): note: could be 'accessibility'
            C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\vcl/accessibility/vclxaccessiblecomponent.hxx(31): note: or       'com::sun::star::accessibility'
            C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/source/accessibility/vclxaccessiblecomponent.cxx(112): error C2039: 'XAccessibleContext': is not a member of 'accessibility'
        
        Drop the namespace to avoid having to always specify
        the whole namespace (`css::uno::accessibility` vs `::accessibility`).
        
        (`git show --ignore-space-change` shows the "actual
        changes" more clearly as some code was using an
        extra indentation level due to the namespace
        that has been removed along with the namespace.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/180848
        [2] https://ci.libreoffice.org/job/gerrit_windows/192770/consoleFull#1759204403cbd6b0d4-2729-45f4-a019-828721d0af3e
        
        Change-Id: I6ca85c2660c001f9bc45700f2f13bd0b6707f8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180870
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [375c3952c09feb328b08a874e7658b4c7ca90d57]

        Revert "remove unnecessary cairo soname patch"
        
        This reverts commit 3500c44bccafd442e50da604287342708506bb5c.
        
        Reason for revert: At least for Linux --without-system-cairo builds, this causes
        workdir/UnpackedTarball/cairo/src/.libs/libcairo.so (which is the lib that other
        libs like Library_drawinglayer and Library_vcl will link against) to have an
        SONAME of libcairo.so.2 (instead of libcairo-lo.so.2), so at runtime libs like
        instdir/program/libdrawinglayerlo.so and instdir/program/libvcllo.so will have a
        NEEDED of libcairo.so.2 (instead of libcairo-lo.so.2), so will pick up whatever
        system libcairo.so.2 (/usr/lib64/libcairo.so.2 from cairo-1.18.2-2.fc41.x86_64,
        in my case) instead of instdir/program/libcairo-lo.so.2, which caused e.g.
        CppunitTest_vcl_bitmap_render_test
        CPPUNIT_TEST_NAME=BitmapRenderTest::testTdf113918 to happen to fail for me with
        
        > [_RUN_____] BitmapRenderTest::testTdf113918
        > warn:vcl.gdi:2234659:2234659:vcl/headless/CairoCommon.cxx:1619: unsupported SvpSalGraphics::drawAlphaBitmap case
        > vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx:100:BitmapRenderTest::testTdf113918
        > equality assertion failed
        > - Expected: rgba[ffffffff]
        > - Actual  : rgba[008000ff]
        
        Change-Id: I9a2a64197185b7c057352c3fb7f3e3f6dbcf70db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180884
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2a1c9972dafc961267c436a95f8a1fd4898dacfd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2d8698dd194a028b45ba2fcef92b71ac1f1af5aa
          - tdf#150998 DROP() Help page
            
            Change-Id: I51f591a2885d46035f10d96442e399fb23663b4c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180899
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c639284b2219333fd017d81406ac8e4e4d38d958]

        Fix typo
        
        Change-Id: If596f94b80ee9a7d203ccf04f74d94ff8636e069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180891
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b18a03d80eac0b16f8a04ca0e9d3851676d7dd1c]

        SAL_INFO the result of checkCoordinateLimitWorkaroundNeededForUsedCairo
        
        Change-Id: I88a021042ccf4e69d550a15eb9555c8f36437c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180887
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f8ee2ccc0a1059759706ecbb1a7d592084dedc9]

        tdf#164855: sd_uiimpress: Add unittest
        
        Change-Id: If912bd0a1c33f7eaefc5872643a7073dbc836c31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180888
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf6ba4620bc5e7c8c18745f72c9018a6abe62256]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b945af55d7c5375316753052c1a5d1e668b301b
          - tdf#150997 TAKE() Help page
            
            Change-Id: Ib0e5084a1c6f3d48054c00767662e9f72a3473a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180871
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-29  Skyler Grey  <skyler.grey@collabora.com>  [4260ae054188a6b14ec424922e681da4b2fc5867]

        fix(iOS): Remove missed clipboard method
        
        In I49671a0bdbd1e1699253c9e710366c1a860ca38d, we cleaned up the old
        obsolete iOS clipboard code. Unfortunately, we missed removing a method
        in our header files elsewhere. Worse, while we can build with a missing
        method we aren't able to package testflight builds for iOS with it,
        leading to everything working until the packaging step which fails.
        
        Change-Id: I47f8fbb6762d82da449886798f0fb7eacf76047a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180883
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-29  Mike Kaganski  <mike.kaganski@collabora.com>  [6ab7c31a7ef9249be2e7eede31c83d9f2aa71b5b]

        Speed up the iteration further
        
        ... after commit 1a938482fbe10065d670e05257a62d8fcfff3793 (use
        getFastAttributeTokens and getValueByIndex, 2025-01-29), which
        has avoided Sequence construction overhead.
        
        This avoids conversion of value strings from UTF-8 to UTF-16
        and back.
        
        Change-Id: Ie832002c5ef4fb6e5390e4b17b752714c09cf471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180882
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-29  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [eec87ad741c361315433f548faf3e676d1b52a8d]

        tdf#164403 CairoSDPR: adapt hairline width
        
        If Cairo Coordinate Limit Workaround is Active do
        also adapt hairline width to 1.0 since we (have to)
        fallback to render in view coordinates.
        
        Change-Id: I2216c1728355b5e76ee04f699193a896f9c4fd4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180860
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-01-29  Miklos Vajna  <vmiklos@collabora.com>  [ec9dbbe288ccb759ed95533fb849dac8a65c4a6b]

        tdf#161872 xmlsecurity mscrypt: don't require trusted signing certs
        
        See commit 1817760f56b74e47120c1b4d7641fbaebcf378ad (tdf#161872
        xmlsecurity nss: don't require trusted signing certs, 2025-01-28), this
        is the same situation, but this time on Windows.
        
        Change-Id: I945899da47ab5dcc421f35db31ec7af240c59b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180881
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-29  Chika Starks  <CHIKA.SUE1@gmail.com>  [a1acff0b36eff5befcbeeee21c3d10fa27f4fd3b]

        tdf#143148 Use pragma once instead of include guards in
        
        WidgetDrawInterface
        
        Change-Id: I961aa6717a05473d0bc6e900eed0275f54be25b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180563
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-29  Pranam Lashkari  <lpranam@collabora.com>  [63b26e8e20f6a4eeb3117925b7a727f565e3a2dc]

        sc: convert data validity dialog async
        
        Change-Id: Ifef985c15a58c1c081f9a011e174e3b2547f3ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179402
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180704
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [3b5aca2b0a21c65dc892d5c691b5b24102a87d48]

        a11y: Drop VCLXAccessibleComponent::getAccessibleIndexInParent override
        
        The base class implementation
        OCommonAccessibleComponent::getAccessibleIndexInParent
        does the same, so there's no need to override it here.
        
        Change-Id: I157e0229f28044233a4e6258bb4cce8e158f0904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180869
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [1158b69ed4c7f5b53a6fe769fb1e5d997cc6202c]

        a11y: Use existing method to get VCLXAccessibleComponent parent
        
        Call `getAccessibleParent()` to
        get the parent instead of reimplementing the logic
        from VCLXAccessibleComponent::getAccessibleParent
        in VCLXAccessibleComponent::getAccessibleIndexInParent.
        
        Calling `getAccessibleParent()` could give a different
        result when any subclass overrides
        VCLXAccessibleComponent::getAccessibleParent. But the
        logic implemented here should use the actual accessible
        parent, so if it didn't use the actual parent for any
        subclass before this commit, that was probably a bug that
        this commit should fix as well.
        
        (`git show --ignore-space-change` makes the "actual
        change" clearer.)
        
        Change-Id: I1d7c43d5ffa7abb8546ad50b7c6a4f9773d5c583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180868
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [28db7f64e553a7061c48db9e4f6f3da2bc516a4a]

        Fix typo
        
        Change-Id: I7c89c636ec6e12f4caf83df4a065f8b63a6e7506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180843
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [76117eddf79c9776bcd328449d7ab7b49d6669d0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 12039db8f078823fd754faf87e7c126e953e3689
          - Fix typos
            
            Change-Id: I9703f7c65c06f8d207921d5563702ef13e37d2fd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180872
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2025-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1a938482fbe10065d670e05257a62d8fcfff3793]

        use getFastAttributeTokens and getValueByIndex
        
        instead of getFastAttributes
        
        Change-Id: I011f0fd8bfd615ff9ee89dd7755c536740463f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b9dd9caa566b12ddc41ee1c4a6f58425a634584c]

        xml::sax::XWriter is a xml::sax::XDocumentHandler
        
        Change-Id: I492bff5580b61c222a7e9b84d49ba70a5dc318b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180863
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [a92113830e8980aa2f4973b25d42712aad6fb049]

        a11y: Drop unnecessary null check
        
        Change-Id: I94d5651a6bcb3cb478e1d1f4020a60b70c093a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [f94c211a2185dc3b949bce34e3cb5e0b61a22044]

        a11y: Drop AccessibleBrowseBoxBase::{g,s}etCliendId
        
        Use the m_aClientId member directly.
        
        Change-Id: I3ca53f664341f5481352ee502d475e91b4876e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [a3cbbe9a885a72ae7addb8e06f62a5365a6de415]

        a11y: Drop AccessibleListBoxEntry::getImplementationId override
        
        The base class implementation
        ImplInheritanceHelper::getImplementationId does the same.
        
        Change-Id: I81c550366c50e20157f034a1cb58709ea7891ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180845
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [a93fc90a149ff6678486a50e7fa7558f9e3e6290]

        a11y: No longer use AccessibleListBoxEntry::GetBoundingBox
        
        Instead use AccessibleListBoxEntry::GetBoundingBox_Impl directly
        in both callers, which already themselves do the same check + mutex
        locking that AccessibleListBoxEntry::GetBoundingBox does.
        
        Change-Id: I9b82cfc1d9000fcfbfa95e53739cc665005577aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180841
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [735b2109f0cfb7f8f5fe2188a8e3ed6a71aa123d]

        a11y: Use OAccessibleComponentHelper for AccessibleListBoxEntry
        
        Similar to how
        
            commit 7107db3fe773629cc511eb5922bc9c28c9c5c60a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 24 18:57:58 2025 +0100
        
                toolkit a11y: Use OAccessibleComponentHelper for grid control
        
        did for AccessibleGridControlBase, also derive
        from OAccessibleComponentHelper for AccessibleListBoxEntry,
        to make use of the logic already implemented there
        instead of having to implement all the XAccessibleComponent
        and XAccessibleEventBroadcaster methods  manually
        
        AccessibleListBoxEntry::GetBoundingBox_Impl already
        provides what is needed to implement
        AccessibleListBoxEntry::implGetBounds, just needs
        to convert to awt::Rectangle.
        
        Drop all of the other overrides that are no longer
        needed as the implementation is now provided by
        the OAccessibleComponentHelper base class.
        
        No change in behavior intended or observed when
        testing this with Accerciser and Orca and the qt6
        VCL plugin with the "Tools" -> "AutoText" dialog
        in Writer, where this code path is used for
        items in the treeview.
        
        Change-Id: I5c95bc6135db92a6e9d736a134af2cbcc35a5e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180840
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [cc8d33cb4da053e4f7738ddf42660e60c0965e79]

        uno grid a11y: Deduplicate 2 cases doing the same
        
        Change-Id: I293213079fede1444f3d5e9f0bce5d03d30a9253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180839
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [87ee0883b67b09ed857096d9d6dc069834efc2da]

        uno grid a11y: Unify XAccessible implementation in base class
        
        By now, all AccessibleGridControlBase subclasses implement
        both, the XAccessible and XAccessibleContext interfaces,
        and their XAccessible::getAccessibleContext implementations
        return a reference to self.
        
        This is implemented in different ways: Either implementing
        it directly or using the GridControlAccessibleElement
        class that does it as base class.
        
        Unify and simplify this by letting AccessibleGridControlBase
        implement the XAccessible interface, and dropping the extra
        handling in all subclasses.
        
        (Other than the other implementations,
        AccessibleGridControlHeaderCell::getAccessibleContext
        was previously not using SolarMutexGuard, but I can't
        see a particular reason, so don't see a reason to
        override the new base class implementation.)
        
        Change-Id: Ibdb674c5d5556fcf1c5644a2f6d961985b0e3362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180838
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [cf8a59f258d10d1bc9b2eb27dbea91d26e2a1b84]

        uno grid a11y: Use cppu::ImplInheritanceHelper
        
        Change-Id: I363a3836ee46f1243c6d61c323910bcac70c0da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180834
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [7ebcd51ea2959c6c01ba2529a83509d3dcd04745]

        uno grid a11y: Drop method only declared, but not implemented
        
        Implementation was dropped in
        
            commit ce52b490ddb7924c6b5b14fee4077182a3c7dd02
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jan 27 15:13:10 2025 +0100
        
                toolkit a11y: Simplify AccessibleGridControl::getAccessibleAtPoint
        
        Change-Id: Id6038b57648be5549645c5f77ebbfc4d387a5dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180833
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [393222247a85c2621ce71986a3e8ce558da7b711]

        uno grid a11y: Merge AccessibleGridControl{,Access}
        
        So far, AccessibleGridControlAccess was implementing
        the XAccessible interface, and its
        XAccessible::getAccessibleContext implementation
        was returning a AccessibleGridControl instance
        that implements XAccessibleContext.
        
        Drop that separation and let AccessibleGridControl
        also implement the XAccessible interface directly
        and return itself in
        AccessibleGridControl::getAccessibleContext.
        
        TableControl_Impl::getAccessible now creates
        an AccessibleGridControl accordingly.
        
        No change in behavior intended or seen when
        testing with the grid in the sample doc attachment 198647
        from tdf#164783 when testing with Orca and Accerciser
        with the gtk3 and qt6 VCL plugins.
        Change-Id: Iabc4cd11e7b6b6e121c65a6813a28e218c34b4e1
        
        Change-Id: I8bfdf64f436a831251f155d0e1238e4d82d1fa58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180832
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [33a7e6910f7075c3b24b56feba4e6318caeb4952]

        uno grid a11y: Drop check for a11y context disposed from outside
        
        AccessibleGridControlAccess owns its
        AccessibleGridControl (`m_xContext` member)
        and is responsible for disposing it.
        
        It does that in AccessibleGridControlAccess::DisposeAccessImpl
        where it also clears `m_xContext` to nullptr.
        
        Therefore, this
        
            // if the context died meanwhile (we're no listener, so it won't tell us explicitly when this happens),
            // then reset and re-create.
        
        check looks very suspicious and should never be reached,
        as anything "from outside", i.e. something not
        owning the AccessibleGridControl should never
        dispose it.
        
        Drop that check.
        
        (In case there actually *is* something disposing the
        accessible context from elsewhere, that should most likely
        be changed in the first place.)
        
        See also
        
            Change-Id: Id16dd7dbf8264d887f52e2fe304b0568079cb924
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 28 09:17:10 2025 +0100
        
                uno grid a11y: Replace alive check by simple null check
        
                TableControl_Impl owns its accessible (`m_pAccessibleTable`)
                and disposes it in TableControl_Impl::disposeAccessible
                which gets called from TableControl::dispose.
        
                TableControl_Impl::disposeAccessible also sets
                `m_pAccessibleTable` to nullptr.
        
                As `m_pAccessibleTable` should only ever be disposed by
                its owner, I can't think of any (valid) scenario where
                `m_pAccessibleTable` could be non-null but disposed,
                so simply use a null check instead of
                TableControl_Impl::isAccessibleAlive that was checking
                for it being non-null and not diposed.
        
        for a similar commit elsewhere.
        
        Change-Id: Ibe89b39be7540d68144400927bc96c318b2873c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180831
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [6b94a653b763655b09032e8b2964bf3eb03a8f7a]

        uno grid a11y: Replace alive check by simple null check
        
        TableControl_Impl owns its accessible (`m_pAccessibleTable`)
        and disposes it in TableControl_Impl::disposeAccessible
        which gets called from TableControl::dispose.
        
        TableControl_Impl::disposeAccessible also sets
        `m_pAccessibleTable` to nullptr.
        
        As `m_pAccessibleTable` should only ever be disposed by
        its owner, I can't think of any (valid) scenario where
        `m_pAccessibleTable` could be non-null but disposed,
        so simply use a null check instead of
        TableControl_Impl::isAccessibleAlive that was checking
        for it being non-null and not diposed.
        
        Change-Id: Id16dd7dbf8264d887f52e2fe304b0568079cb924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180830
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [abd9bb06912daac0568fd47c87886c519a37bad8]

        uno grid a11y: Let impl handle alive check
        
        Make TableControl_Impl::isAccessibleAlive private
        and drop all uses in TableControl. They are unnecessary
        there, because the TableControl_Impl methods that
        get called already call TableControl_Impl::isAccessibleAlive
        themselves to check whether the accessible is still alive,
        and that is in my opinion actually an implementation detail
        only the impl should have to care about.
        
        Drop "IfAccessibleAlive" from the method names for
        TableControl::commitCellEventIfAccessibleAlive
        and TableControl::commitTableEventIfAccessibleAlive.
        
        Change-Id: I5589289de0ca96ce5fc5993df5cef3877dce881a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180819
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [2f574de08b5c4c009c1e3880f548e79d380bcc4f]

        uno grid a11y: Merge TableControl_Impl::{impl_,isAccessibleAlive}
        
        Move logic from TableControl_Impl::isAccessibleAlive
        to TableControl_Impl::isAccessibleAlive, which was
        previously just calling the latter.
        
        Change-Id: I6161e8745568954fdaa53dbfa573d29daa547275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180818
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [b3a60c9d07a80f7e70fafaca7561b7fa5df36ecb]

        uno grid a11y: Drop duplicate check whether alive
        
        TableControl_Impl::commitTableEvent and
        TableControl_Impl::impl_commitAccessibleEvent
        check whether the accessible is alive before
        doing anything, so there's no need to do that
        manually before calling those methods in addition.
        
        Change-Id: Ie940653a994fe92eefd367d0816ba03c95d409a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180817
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-29  Michael Weghorn  <m.weghorn@posteo.de>  [0267279ae8c2145cfedc1497634a869fb79e300e]

        uno grid a11y: Drop superfluous check
        
        The non-null case already has an early return
        above, so there's no need to check again whether
        `m_pAccessibleTable` is actually nullptr.
        
        Change-Id: Id094c80787f425fe18e48cf0a6460c50d33056ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180816
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3271cf5adfbe2e00d02417d85ff320763d7e9a5]

        SwXTextDocument::getBodyText can be used instead of getText here
        
        and that's already a rtl::Reference to SwXBodyText which is
        derived from SwXText
        
        Change-Id: I071c0711fef911deec4258ef9e6719b721a39de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180859
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [86cc183b5d8080b7ea1b1c96e827875b2a322034]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d84a00730dc742b4a3aad3da9e5fc4ef0ec82fd
          - tdf#151001 EXPAND() Help page
            
            Change-Id: I345b2866343ba3f56795af3428c2fc749e487844
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180858
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e54b5b0dfff81d21fa79ca629f66a5bc3cc3745c]

        We already have a SwXTextDocument, don't need to cast
        
        to XDocumentMetadataAccess, it's already available
        
        Change-Id: I35965afafb4080a2315862739d602677b966245a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180853
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c66e2cdbb4358c90807f00ba989b5c1905bebd40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b1c6f6063d9174be03a4ed9485b802dab26c4ffc
          - Fix some tables layout for statistics examples
            
            Change-Id: Ib4b8dd3e489199928a151e7348b129b7690515f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180812
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-28  Oliver Specht  <oliver.specht@cib.de>  [875bb514b9d50bae02c2999f3be071e654c0d10d]

        tdf#163340 fixes regression
        
        Pasting a single paragraph with a list into an empty paragraph
        with a different list should keep that target list and not apply
        the source list.
        
        Change-Id: Ife81aa9553bb2396082d23cc86336ad773b83a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180536
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-28  Miklos Vajna  <vmiklos@collabora.com>  [1817760f56b74e47120c1b4d7641fbaebcf378ad]

        tdf#161872 xmlsecurity nss: don't require trusted signing certs
        
        Configure your signing cert in Firefox, (unusually) don't trust the CA
        that you would use to issue your signing cert, try to sign a document,
        error.
        
        This is reportedly wrong since commit
        bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b (Update libxmlsec to 1.3.1,
        2023-06-09), for some reason our usage of libxmlsec-1.2 didn't trigger
        this problem.
        
        Given that we already disable libxmlsec-side cert verify while
        verifying a signature (and have our own logic there), it's consistent to
        do the same while creating the signature, and that fixes the bug, too.
        
        The Windows / MSCNG backend is not yet changed here.
        
        Change-Id: I8a7adf06b9a26731f1a180a4f6257317084e414a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180844
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6ca82a321f31a537eef8a334ada4cd751a2a00cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9400a3e9696e67e24560695969877e2e30199918
          - tdf#150880, tdf#150881 WRAPROWS() + WRAPCOLS() Help pages
            
            + refactor to reuse sample data
            + Adjust data for TOCOL and TOROW
            
            Change-Id: I6d4661a9c044d414d4142aa159900b699ccb2192
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180811
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [815c59104ff2f0a3603471b84132f4786a102fbd]

        Don't broadcast SfxHintId::TitleChanged if title doesn't change
        
        Change-Id: Id3a0adb8903f269a94fdfb63220305780b96db4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [76324a5c75b04c0288d8636b3e270f0273ce4e65]

        Set an empty ComplexColor, or the previous one could be used
        
        In some OOXML documents it can happen the ComplexColor is set to
        elements that shouldn't be set, so set one in all cases so we can
        be sure it is set to the ComplexColor we want.
        
        Change-Id: I480c788267c6497f8d6588790150aaa9f2a07c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180786
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-28  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [924c7de80afa47a93705e5d073c35f2d81f4ed5a]

        tdf#164393 [API CHANGE] Make the "Automatic" theme Customizable
        
        + enable the "Customizations" section for the "Default" theme.
          by default the system colors will be used. If the system theme
          changes then only those colors will persist which were set explicitly
          by the user. (well explained in the comments near colorcfg.cxx changes)
        
        + add a "Reset all" button to reset all the theme colors to
          system colors. Pressing this button sets all the values to Automatic
          (system colors) irrespective of which theme is being used.
        
          We have plans for integrating the ExtensionManger with Themes so that
          we can reload the extension when the colors are reset.
        
        Change-Id: Ic811415b24a353b9cfcf7c633a5621b595ec27d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179406
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [795e6f6f3e5ab8201dabde65e9b3b939293d34a4]

        Introduce EMSCRIPTEN_EXTRA_QTLOADER_CONFIG
        
        for use in Emscripten --enable-qt6 builds, to e.g. add command line arguments
        (like --writer) into qt_soffice.html.
        
        For standard --enable-qt5 Emscripten builds, it works to specify an
        
        > EMSCRIPTEN_EXTRA_SOFFICE_PRE_JS=/path/to/include.js
        
        containing
        
        > Module.arguments = ['--writer'];
        
        to make qt_soffice.html open a Writer document.  Due to how the Qt loading has
        changed in Qt6, that no longer works for --enable-qt6 Emscripten builds.  But
        what works there now is to instead specify an
        
        > EMSCRIPTEN_EXTRA_QTLOADER_CONFIG=arguments:['--writer']
        
        (The sed -z option that is necessary to replace text spanning a newline is a
        non-standard GNU extension, but lets assume that this is only executed for
        cross-builds from Linux that use GNU sed.)
        
        Change-Id: I31372a7a1f8fccbe0fe2594614bf5846e5e5c95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-28  László Németh  <nemeth@numbertext.org>  [a4af3948e9212ef46149f906e5880f77693cca4b]

        tdf#163309 sw: clean-up bookmark boundary mark labels
        
        Add white background to the labels for better visibility on
        colored page/background.
        
        Maximize the size of the label in 3 pt to support very
        narrow fixed line spacing of headings.
        
        Follow-up to commit 3393e52be0900ad63ceee0a43cd44d473ec8248a
        "tdf#163309 sw: show rdf:type as labels on bookmark boundary marks".
        
        Change-Id: I986b73892f2caca9ea0c97918db4c45577ada0eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180810
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-01-28  Balazs Varga  <balazs.varga.extern@allotropia.de>  [4354919a9e5bea6182b23c7fbc93ce082111a44c]

        tdf#164855 sd - fix crash while centering table contents
        
        regression from: 1d9ce0a67a71e51569cd33c26270eeece587a354
        (tdf#162571 - sd: Text box expands or shrinks on left or right...)
        
        Change-Id: I75425dc15f40a32c353284f0a1338e117b8db018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180809
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [eabe32cb1822f1150abdb4c44a9ca19d551c2ecf]

        Fix "Remove a hack at least for Emscripten --enable-qt6"
        
        ...following up on 862e86d187c53ab077b672997ca8d9623396b962, where I had screwed
        up (and thanks to Michael Weghorn for spotting)
        
        Change-Id: I0e5c6b4c12b6609021fe8ff7e0ad092d736728db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180813
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-28  Michael Weghorn  <m.weghorn@posteo.de>  [5e3805934e882afe3b8a46902551b770616301a4]

        tdf#130857 qt weld: Address clazy warning (clazy-range-loop-detach)
        
        Address this clazy warning:
        
            .../libreoffice/vcl/qt5/QtInstanceMenuButton.cxx:154:5: c++11 range-loop might detach Qt container (QList) [clazy-range-loop-detach]
        
        Change-Id: I4348b2c66b54716a2442f5c3ccafafd66cf92333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180808
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-28  Michael Weghorn  <m.weghorn@posteo.de>  [12c6bf058cf88b6d4cfe6e0aff09cf183ea9e033]

        tdf#130857 qt weld: Support MenuButton separators + respect pos
        
        Implement QtInstanceMenuButton::insert_separator.
        Add a helper method QtInstanceMenuButton::insertAction
        that inserts the given action at the given position
        and use it from QtInstanceMenuButton::insert_item
        as well, which was so far only assigning the `nPos`
        local var, but not actually taking it into account
        to specify where to insert the new action.
        
        Use QWidget::insertAction [1] that allows to specify before
        which existing action the action should be inserted
        instead of always appending to the end.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#insertAction
        
        Change-Id: I0acefb29f01b680b4efdf0ad6cea3bbf7f84c4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180807
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3500c44bccafd442e50da604287342708506bb5c]

        remove unnecessary cairo soname patch
        
        This was introduced by
            commit 2def5485aa57d7c407a84ecc73b22083579e9a98
            Author: Tor Lillqvist <tml@collabora.com>
            Date:   Tue Sep 20 16:07:14 2022 +0300
            Enable opening of downloaded fonts only in ForKit in Online
        
        but we don't need to this, since we rename the .so file when we copy it
        in external/cairo/ExternalPackage_cairo.mk
        
        This change makes a later patch less noisy/
        
        Change-Id: I06f78d7ff068df14e95542391e20b669487ebb5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180794
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-28  Simon Chenery  <simon_chenery@yahoo.com>  [67444270826e17b8ae7b38b7519365b34dde5601]

        tdf#153109 Use any_of to check for match in spelldsp.cxx
        
        Change-Id: If9bf5d96dea0dc5939c951a29f893d5fb02003d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180751
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [a8ec21adf255b70bb6eeb0a1717190df303d8b26]

        uno grid a11y: Use ImplInheritanceHelper
        
        Change-Id: Ie60417bd84f1ed1378da987f012cacad796ea0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180805
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [1ddf5902591e8468401cba9d0b4a46c87603cca6]

        uno grid grid a11y: Return existing cell accessible
        
        ... instead of creating a new one every time
        AccessibleGridControlTable::getAccessibleAtPoint
        gets called.
        
        Change-Id: Icc6e2963bcbe56136717cc2499e10d8d45a2e15a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180804
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [062681cecfbfd20990d53bc43ea3c601c8b3a1d8]

        uno grid a11y: Pass pos relative to TableControl as expected
        
        TableControl::ConvertPointToCellAddress expects a position
        relative to the TableControl.
        However, AccessibleGridControlTable::getAccessibleAtPoint
        gets a position relative to itself, which is different
        at least when the table also has row/col headers.
        
        Add the own position relative to the parent (which is the
        TableControl) to convert the position as needed.
        
        With this in place, using Accerciser's "Select object under mouse"
        feature with the grid control from attachment 198647 from tdf#164783
        with the qt6 VCL plugin now results in the correct cell being
        highlighted when the mouse pointer is over a regular cell, while
        the cell one row above was highlighted previously.
        
        The cell is still not selected in Accerciser's treeview
        of LO a11y tree, but that's still another issue.
        
        Change-Id: If9456b6399ad7a871cb52d9ff4f38168e5907579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180803
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [ee9143100e4523c47702f54151b55c95e272389c]

        uno grid a11y: Don't confuse row/col
        
        TableControl::calcHeaderRect's `_bIsColumnBar` param is
        passed as the `bColHeader` to TableControl_Impl::calcHeaderRect,
        both of which have the same meaning ("whether this is a column
        header (cell)"), so inverting it (for no apparent reason) is
        incorrect.
        
        As a consquence, selecting the grid control's column header bar
        in Accerciser's treeview of the LO a11y hierarchy with sample doc
        attachment 198647 from tdf#164783 with the qt6 VCL plugin
        would result in not only the header area getting highlighted, but
        the area of the rest of the table as well (as rectangle returned by
        AccessibleGridControlHeaderCell::implGetBoundingBoxOnScreen
        result was incorrect).
        
        With this commit in place, the header area is now highlighted
        as expected.
        
        Change-Id: I2c99c940faf469678ecee33dd029580e57170f2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180802
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [eab7fb83f1521f9ce4c2ee586604c87ff0fc49ce]

        toolkit a11y: Convert condition to assert
        
        AccessibleGridControl::implGetAccessibleChildCount calls
        TableControl::GetAccessibleControlCount which always returns
        a positive integer, so assert on that and drop the fallback
        path.
        
        Change-Id: I06c9b31d0d79535fe6fa9d7ada371717e42badfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180800
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [ce52b490ddb7924c6b5b14fee4077182a3c7dd02]

        toolkit a11y: Simplify AccessibleGridControl::getAccessibleAtPoint
        
        In order to check whether any of the children contains
        the given point, use the existing
        AccessibleGridControl::getAccessibleChild method  to iterate
        over the actually existing children instead of having
        an additional AccessibleGridControl::implGetFixedChild
        that uses static/fixed indices for the different kinds
        of potential children that may or may not be there.
        
        Drop now unused helper methods that mostly duplicated
        logic already found in AccessibleGridControl::getAccessibleChild.
        
        Change-Id: I57b814aa497097d1f18506303a76d53ec9f6e0b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180799
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [cc33576917951b5f2c5de0b925058f56159d7182]

        a11y: Move AccessibleTableControlObjType to toolkit-only header
        
        It's only used in the toolkit module by now, so there's no
        more need to have it in a global header.
        
        Change-Id: Iba820035752e5f4ed5a0e6f99f6c792447d4209b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180798
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [ae8ff1c875b4cacabc64d5183f25baed8c6890c5]

        a11y: Drop IAccessibleTable
        
        Now that all related code is in the toolkit module
        and the interface (abstract base class) is no more
        needed to break a dependency cycle, drop the interface altogether.
        
        (An earlier version of this change resulted in LO clang plugins
        pointing out some oddities. These have in the meantime been addressed
        separately in previous commits to prepare for this change.)
        
        Change-Id: I6295695d9f0bf02be26175c45142965351ec5eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180797
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [24a2dd9cbe6c2079d379921e35c45331c19e723e]

        toolkit: Drop now unused TableControl::ConvertPointToControlIndex
        
        Change-Id: I15fa134992de8ada04346c8bfd881ed76f9e4b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180793
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [76677a804f23ebd1fac0a098883c861816103b91]

        a11y: Drop non-functional bits from AccessibleGridControl::getAccessibleAtPoint
        
        XAccessibleComponent::getAccessibleAtPoint should return
        the direct child at the given point.
        
        AccessibleGridControl can have up to 3 children,
        see AccessibleGridControl::getAccessibleChild:
        
        * a row header (AccessibleGridControlHeader)
        * a column header (AccessibleGridControlHeader)
        * the table (AccessibleGridControlTable)
        
        TableControl::ConvertPointToControlIndex on the other
        hand returns the child index of a cell within
        the table, so could only be relevant when
        calling AccessibleGridControlTable::getAccessibleAtPoint on the
        AccessibleGridControlTable child
        (and AccessibleGridControlTable::getAccessibleAtPoint does similar,
        but uses a method called TableControl::ConvertPointToCellAddress
        instead).
        
        In addition, TableControl::CreateAccessibleControl that
        was called with the index retrieved that way was
        warning it should be overriden (Where?) and unconditionally
        returning nullptr.
        
        Drop that broken code path. The remaining logic
        to iterate over the children looks reasonable in principle.
        
        Without this commit in place, using the "Inspect object under mouse"
        feature in Accerciser when the mouse is over a cell of the grid control
        of the sample doc attachment 198647 from tdf#164783 with the qt6 VCL plugin
        would result in the top-level's TableControl's a11y object getting selected
        in Accerciser's treeview of the LO a11y and its full area getting
        highlighted.
        Now, it selects/highlights the column header cell - even if the mouse cursor
        is over one of the regular cells - which is still not fully correct,
        but that is a different issue.
        
        Change-Id: Ib4a0d05145c66a96dcb72a6a50805182c17fb2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180792
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [2443e39e7b9623d3b69a38af5419a54ae0601e40]

        toolkit a11y: Simplify AccessibleGridControlHeader::getAccessibleChild
        
        Reuse existing AccessibleGridControlHeader::implGetChild
        instead of duplicating the logic.
        
        Change-Id: Id5a89a24d511ff5667d8a512fb7c89394ce9c636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180791
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [f3cb49e5986e9b02cbecfc989888ddf4f09047c2]

        toolkit a11y: Ensure non-negative child index
        
        Extend AccessibleGridControlTableBase::ensureIsValid{Row,Column,Index}
        to also check that the index is non-negative and use
        the existing AccessibleGridControlTableBase::ensureIsValidIndex in
        AccessibleGridControlHeader::getAccessibleChild.
        
        Change-Id: If67fe2e23ee2d22683be072a8ed9ccfb1d9efd57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180790
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [495089ccfc71a5fdba1a6d5d97300571f9c38439]

        vcl a11y: No longer use factory to create AccessibleTabListBox
        
        Just call the ctor directly, now that the class is
        inside vcl, too, since
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        so there's no more need to use the factory to break
        a dependency cycle.
        
        Change-Id: Ieeae16ba91533820b707e6bf0fd964ba7b8a7cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180789
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3b18d95ba3f3137528a208d68d40d12407b36372]

        related tdf#162786: Add cacert.pem
        
        In order to fix
        ERROR: Could not install packages due to an OSError: Could not find a suitable TLS CA certificate bundle, invalid path:
        /home/xisco/libreoffice/instdir/program/python-core-3.11.11/lib/pip/_vendor/certifi/cacert.pem
        when using pip install
        
        Change-Id: I84d6c23021523c11803bc2b0858d69a706da0dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180788
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-27  Jonathan Clark  <jonathan@libreoffice.org>  [e5a7140c32a243782e21172a1ff9998720a063c3]

        tdf#164803 sw: Revert use ext leading for grid spacing on DOC import
        
        Removes an incorrect fix for tdf#129808, which was introducing
        unintended document layout issues.
        
        This reverts commit 43fc662520e5488cbeadd6eb60a24374a837dca4
        Author: Jonathan Clark <jonathan@libreoffice.org>
        Date:   Thu Jan 23 09:04:10 2025 -0700
        
            tdf#164803 sw: Fix SwTextSizeInfo applying grid metrics without grid
        
        and commit 2155684c819dcdc52968c59276046fb0cad83561
        Author: Jonathan Clark <jonathan@libreoffice.org>
        Date:   Thu Sep 19 22:05:08 2024 -0600
        
            tdf#129808 sw: Use ext leading for text grid spacing on DOC import
        
        Change-Id: I356dc045aaf0b60a3b7fcd6e43fd98ccccc25ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180796
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-01-27  Skyler Grey  <skyler.grey@collabora.com>  [1bd9ac53f0d042c82de77abccde292a2bd179bbd]

        chore(iOS): Cleanup old iOS pasteboard code
        
        Since as we're switching to handling the clipboard the same in iOS as
        everywhere else, this old pasteboard code is no longer needed
        
        Change-Id: I49671a0bdbd1e1699253c9e710366c1a860ca38d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180785
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3575986e30705d588d4eea94eb669474a3adbf77]

        tdf#162786, tdf#159988: python3: do not strip soabi on linux/macOS
        
        Otherwise libraries installed through pip do not work
        
        Change-Id: Ib916964ce7d309faffaad1763884b1600b139c18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180781
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [862e86d187c53ab077b672997ca8d9623396b962]

        Remove a hack at least for Emscripten --enable-qt6
        
        That "no idea, why Qt::WA_NativeWindow breaks the menubar for EMSCRIPTEN" had
        been added in c3d25b55990e2205af56747aa2935f4ff11ad0aa "WASM Qt: various
        EMSCRIPTEN adaptions", but with no explanation beyond "Don't create a native
        window handle".  At least for recent Qt6 dev (towards Qt 6.10), that doesn't
        appear to cause any (obvious) issues, however, but would cause some
        "qt.core.qobject.connect: QObject::connect(QWindow, QtFrame): invalid nullptr
        parameter" console log from
        
        > $QObjectPrivate::connectImpl(QObject const*, int, QObject const*, void**, QtPrivate::QSlotObjectBase*, int, int const*, QMetaObject const*) @ soffice.wasm:0x7a88b4c
        > $QObject::connectImpl(QObject const*, void**, QObject const*, void**, QtPrivate::QSlotObjectBase*, Qt::ConnectionType, int const*, QMetaObject const*) @ soffice.wasm:0x7a8892c
        > $QtFrame::Show(bool, bool) @ soffice.wasm:0x659b18f
        > $non-virtual thunk to QtFrame::Show(bool, bool) @ soffice.wasm:0x659b695
        > $vcl::Window::Show(bool, ShowFlags) @ soffice.wasm:0x1557411
        > $vcl::Window::Show(bool, ShowFlags) @ soffice.wasm:0x155733d
        > $VCLXWindow::setVisible(unsigned char) @ soffice.wasm:0x129b055
        > $non-virtual thunk to VCLXWindow::setVisible(unsigned char) @ soffice.wasm:0x129b0f6
        > $desktop::Desktop::ShowBackingComponent(desktop::Desktop*) @ soffice.wasm:0xc15712
        > $desktop::Desktop::Main() @ soffice.wasm:0xc13b1a
        > $ImplSVMain() @ soffice.wasm:0x18b2cde
        > $SVMain() @ soffice.wasm:0x18b4eef
        > $soffice_main @ soffice.wasm:0xc1c35d
        > $main @ soffice.wasm:0xb95548
        
        Change-Id: I8f12ac8c3d196ed69bea43589a34b79912c1ef36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180783
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [907da00ef44b7b0dd4a4eb892679f560ca0a5483]

        Update git submodules
        
        * Update translations from branch 'master'
          to 8125bff43289e85b09abcc18dea4a61ed9565796
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ib44db990763474fea9a548400b77322caef33327
            
2025-01-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eb568de67b0671ac93d84ee8fbb659408b7e6d4a]

        We don't need to broadcast these GrabBag changes
        
        no need to redo any layout, etc due to these
        
        Change-Id: Id0d849221527db26b196f07865722d450093f13c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180778
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [657efd649ffb183336250799a6fa4bab950d03f3]

        macOS: simplify mac exclusion recipes
        
        on branches 25-2 and 24-8 the python tkinter dylib is back.
        The corresponding python module is ignored already, and the tkinter
        cpython dylib already was removed in the past, but apparently at some
        point that file wasn't generated anymore and the corresponding line to
        delete it was removed in 6e62c9df969fdf3a599e4f7b0e46a70e8f0780e5
        That same commit also changed the filenames to use a * wildcard after
        the python version, apparently to account for a "d" suffix in the
        --enable-dbgutil case. In the spirit of the old commit to avoid rm -f
        and to be explicit and catch potential other issues in future remove
        that wildcard again/replace the suffix with a macro that contains the
        appropriate suffix already as used in ExternalPackage_python3.mk.
        
        Change-Id: I22b49af7dbf9a0bed5c124d9f137b8a38fee7471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180705
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-01-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b09f64173fa8c9fe1f4bbed6ab018141407321b]

        Resolves: cool#10952 use existing ComponentContext
        
        instead of unnecessarily bootstrapping an entirely new one
        
        See: https://github.com/CollaboraOnline/online/issues/10952
        Change-Id: I625c539eb7272e152ee84a568f235751128bd96a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180776
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6a1da9db8f717294b407c94b3572e4d7e72929f]

        We can use the PoolItem SetAttr rather than create an entire SfxItemSet
        
        presumably at least
        
        Change-Id: Ib8238322d64f91c0f64606c51806ace96696aa71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180716
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [68969293c1a15e8d27091e159aeb813c1f94c9a3]

        enable spotlight subset in kit mode
        
        Use the index of the style within the list of writer's instantiated
        styles as the indicator number to use, so this is stable regardless of
        what particular mode the style dialog/panel is using.
        
        Unused styles don't get a number indicator, but do have a (stable) color
        until they are used in the document.
        
        For kit, Para/Char style mode renders all styles, not just the subset
        selected in the style dialog/panel, when Para/Char spotlight is enabled.
        
        Change-Id: I513e4a676a7c4f7f542c016afa5a79d158778210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178481
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit e5eec842b0c61c9c91a8f836661d6885c9c236a8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180768
        Tested-by: Jenkins

2025-01-27  Miklos Vajna  <vmiklos@collabora.com>  [7d3729961c1a8c4d0d2c843d55789000982635d7]

        svx: prefix members of SvxClipboardFormatItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I2b968e01db03871dbe0748a5bbbde4f7dcf566cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180772
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7f8a5594694c5f2861648c36ff7c87a21422f283]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c0ab5d8cbdbf455565c655539e50dd7669a02b59
          - tdf#150879, tdf#150878 TOROW() + TOCOL() Help pages
            
            Change-Id: Ib23a32caf6c652fd8d8f3e490465062a8c3c9d12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180733
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-26  Noel Grandin  <noelgrandin@gmail.com>  [6fed871be7c444d35fcedcc037fa89e71a4b284c]

        simplify writeBitmapObject
        
        by splitting into two methods. The previous recursive nature
        and plethora of conditionals made following the logic impossible.
        
        Change-Id: I1a9a5fa592c00b65bd8308ec33ba7df5cb7fb26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180752
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85c8901dc2710e91bccb64cd7d8068441f42f65b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8477edf27300030dbdb6393c58430c2e290a2127
          - Work on tables for dark mode
            
            + Center tables in main displays area
            + introduce stripes in table
            
            Change-Id: Ia27c944fe9a51089385b5c099eed853d467004bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180745
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a7406b7236703dcd95fbc3a1cd1d4b5efd374aa0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ef0e0459c7a86b8faf74470956a885feec43a35
          - Remove unused transformation on no-script
            
            Change-Id: I8e1e5a236fe80993ea8f4a06404d0c3601411a56
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180744
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d81fc1367653bba68ea08906364d3792dffc4596]

        Resolves: tdf#164853 find_if causing copy
        
        the pred param of:
          const std::pair<QueryKey, QueryCriteriaAndResult>&
        doesn't exactly match what the arg should be, which is
          const std::pair<const QueryKey, QueryCriteriaAndResult>&
        so an unecessary copy is silently created, add and use some typedefs
        to make this more straightforward.
        
        seen with:
        
        perf record -e mem_load_l3_hit_retired.xsnp_fwd -e mem_load_l3_hit_retired.xsnp_miss
        
        on profiling specifically for contested accesses, see tma_contested_accesses in perf -v
        
        Change-Id: I1d1a57e49a0f2af8bc57ca22ac4572c0246c719b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180753
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-25  Patrick Luby  <guibmacdev@gmail.com>  [5e03f4d40c14cc79b1f3f790955196a31eec5d3c]

        tdf#164223 invert alpha mask for JPEG images
        
        Change-Id: I6f1070b8cc38a56168ea5248fa4b011f04d83c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180746
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [1c763a6b88c2efd425e764778fc8c709387cf2ff]

        tdf#160770: use OUString ctor that takes length, which allows nullptr
        
        bstrDescription can obviously be nullptr.
        
        Change-Id: I09f368a632143479c165cb0653a33aef26fe0e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180743
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [62a4a9659c914a71c89e90c3a71538d45930597b]

        sc: factor out some more code
        
        Change-Id: I604bf182e9ac6f34298f7193cfffd1cc818132b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180738
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [94f72a396b1e15e710163c37e175552c59048447]

        tdf#164793: fix misplaced rounding
        
        Regression after commit bc0ab08634f59e1a1814e575fe6ad5e50bf1aee1,
        where I confused what neede to be rounded.
        
        Change-Id: Ib150ea1989ed7241747fe4a89bce051478a54bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2d1acf7dd0558f5c2575cef58df7db4e59181a68]

        tdf#164844: handle colorscale and friends specially when deduplicating CF
        
        The conditional formats like colorscale, databar and iconset may take
        their whole range to calculate their maximum / minimum, and each cell
        format would depend on the CF range. Thus, automatic merge of ranges
        of similar CFs when copying/pasting could create unexpected results.
        E.g., merging CFs of two distinct color scales - one for a range from
        1 to 10, and another from 100 to 500 - would change colors on both of
        them, which is usually not what user wants, even when these ranges
        are side by side in adjacent columns.
        
        On the other hand, users still may want to have a way to expand the
        range automatically. E.g., when there is a column from A1 to A10 with
        a colorscale, and the user copies a cell from that range to A11, it
        is very likely that the intention is to expand the existing CF, not
        to create a separate colorscale individually for the cell A11.
        
        This makes it necessary to create some complexity in deciding when to
        deduplicate, and when not. This change introduces a function for that,
        called isRangeDependentFormatNeedDeduplication; and implements some
        simple algorithm that currently only depends on analysis of the two
        CFs' ranges. If both ranges are one-dimensional vectors, and the new
        CF range "continues" the existing range (the edges of the two vectors
        are adjacent), then it decides to combine them into one expanded CF.
        Also, if the new range is completely inside the old one (which may
        easily happen, when a user copies a cell from one place to another
        inside the same range), it also allows deduplication. In other cases,
        it rejects deduplication, requiring creation of a new CF.
        
        It may be extended as needed. One possible improvement could be e.g.
        when a user has a two-dimensional colorscale block, and copies some
        of its rows below, then it would be likely that the intention is to
        expand the range of existing CF, rather than creating a new one for
        the expanded range. This would need some specification how to tell
        this case from others that must not deduplicate.
        
        I must note that this problem is indeed difficult: e.g., in Excel,
        there is also no simple logic around copying such CF. I saw very odd
        cases, where the copy resulted in merging ranges of existing CF, or
        in creation of new CF; also, it could even magically add cells to
        existing CFs without copy - just by entering data below existing CF
        (and even when there was some gap between the existing CF range and
        the newly entered data - but not when there was two gaps). So there
        likely will always be some corner cases where users expect something
        else.
        
        This changes the behavior established in commits
        3f614f431475e1bf3bb3bbeac59b0681309628b7 (tdf#95295: don't add
        duplicate conditional formats, 2017-12-11),
        3fa15dd614bd72ddb36dbe033abeef5609d31f38 (tdf#154906 tdf#129813
        tdf#129814 sc: fix conditional format color scale, 2023-04-26)
        and 8af6c46a9c0e86bbbd908e96ff236ad1d6c4ddab (tdf#155319 sc: fix
        conditional format data bar after copying, 2023-05-22) regarding the
        mentioned types of CF.
        
        Change-Id: Ie94167bbf66e448a6b56ad0962cb38221aa7d4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180735
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-25  Noel Grandin  <noelgrandin@gmail.com>  [5247f456e536b7c7687f6c5b97b12c5d45b2f962]

        convert SwTextGrid to scoped enum
        
        Change-Id: I0c317a0bd1e91ed9399e5436bd2b0d7d26173ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [287941a6cdff79bfacf508e29977efdf00e479c6]

        tdf#164847 - Update menu items based on concordance file selection
        
        Disable/enable the 'Edit' menu option based on the presence of a
        concordance file during the creation of an alphabetical index.
        
        Change-Id: I0a12ee21d32975b7f7962d6205986724e15145bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180734
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-01-25  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [0fe8cf893217bb7c443a6e650fa004edbe6fff62]

        Mark some visible strings in ui files as translatable
        
        found with bin/ui-translatable.sh
        
        Change-Id: Ibe74635abc54a898c6040d4e62427f749f842474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180722
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9fd8cc18a9cd5cd4ae86b4256cf8786ea34ea89]

        Revert "tdf#158280 Replace usage of InputDialog with SvxNameDialog"
        
        This reverts commit a88b3da5b01403ba593423821843a0dacda158ec.
        
        Reason for revert: it breaks the build because there was a mid-air
        collision with
        commit b811b283c254fb48d8991576dfee0bae3dc322dd
        Author: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Date:   Wed Jan 22 12:54:21 2025 +0100
        
            Extend the Link DBG_UTIL support to non-member function Links
        
        Change-Id: I674b91fbfecae16204bb9d7560ec7ad56f348a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180728
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [8fad479890379e2f010fbf0be29f8f97e6e85904]

        libpng: upgrade to 1.6.46
        
        Downloaded from https://netix.dl.sourceforge.net/project/libpng/libpng16/1.6.46/libpng-1.6.46.tar.xz
        
        Change-Id: I532674663e66e294f92269d2ac0b748b8afb8543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180730
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [b92e6bf5c5d1aa3fd6ea8c31afb286803e26ad83]

        toolkit a11y: Use cppu::ImplInheritanceHelper
        
        Change-Id: I69a1eeb53b1f3f2f4ba2b9050c70efb3d91e2150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180725
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [23d2869e9b74673a11a9f8c3d45a2f5e6990dc5c]

        toolkit a11y: Drop AccessibleGridControlBase::getAccessibleIndexInParent
        
        It effectively does the same as the base class implementation,
        OCommonAccessibleComponent::getAccessibleIndexInParent.
        
        Change-Id: I649841c4676009797612cbe0e6422dd088218a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180724
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [7107db3fe773629cc511eb5922bc9c28c9c5c60a]

        toolkit a11y: Use OAccessibleComponentHelper for grid control
        
        Simplify AccessibleGridControlBase by subclassing the
        comphelper::OAccessibleComponentHelper helper class
        that already provides much of the logic.
        
        Unless I'm missing anything, the corresponding custom
        implementations in AccessibleGridControlBase were
        equivalent (and partly looked copy-pasted).
        
        Notes:
        
        * XAccessibleEventBroadcaster logic is fully implemented
          in OAccessibleComponentHelper, so drop the custom logic.
        
        * In order to implement XAccessibleComponent methods,
          only OAccessibleComponentHelper::getBounds needs
          to be overriden. The logic is already implemented
          in AccessibleGridControlBase::implGetBoundingBox,
          just need to convert from tools::Rectangle to
          css::awt::Rectangle in addition.
          Drop all of the other methods related to location/bounds
          handling. The AccessibleGridControlBase logic takes
          care of that now.
        
        * Drop AccessibleGridControlBase::ensureIsAlive and
          use OAccessibleComponentHelper::ensureAlive instead,
          which has the same logic.
        
        In a quick test using sample document attachment 198647
        from tdf#164783 with the qt6 VCL plugin and Accerciser
        and the Orca screen reader, no differences in behavior
        were observed with this change in place.
        
        Change-Id: I90099dd5426db093260175b2c3d09db548e05c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180723
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [d1d2afa7dd9591664c72fffd6cd941220bb05999]

        toolkit a11y: Return parent-relative coords if requested
        
        As its documentation described, the (so far) purely virtual
        AccessibleGridControlBase::implGetBoundingBox was implemented
        by all subclasses to return the bounding box relative to the
        TableControl's vcl::Window parent.
        
        However, this method is used to implement methods like
        XAccessibleComponent::containsPoint,
        XAccessibleComponent::getBounds and
        XAccessibleComponent::getLocation, all of which are supposed
        to be using the position relative to the *immediate* accessible
        parent.
        
        This mismatch could e.g. be seen with the grid control
        in attachment 198647 of tdf#164783 and the gtk3 VCL plugin
        as follows:
        
        1) allow macros
        2) open sample file
        3) click "Grid in dialog" to start the dialog containing a grid
        4) start Accerciser
        5) In Accerciser's treeview of the LO a11y hierarchy, select the
           "Grid control" object with a11y table role.
        6) Select its first child, which is a table cell.
        
        What could be seen is that the top-left corner of the highlighted
        area for the first cell (step 6) is shifted to the right and down
        as compareed to the highlighted area for the table (step 5), even
        though the first cell in reality has the exact same origin, (because
        the table area is defined by the cells it contains).
        
        The AccessibleGridControlBase::implGetBoundingBoxOnScreen overrides
        correctly return the bounding box on screen and duplicated much
        of the logic.
        
        Fix the problem and deduplicate code by implementing
        AccessibleGridControlBase::implGetBoundingBox directly in
        AccessibleGridControlBase: Let it calculate the position
        relative to the parent from the absolute position of the parent
        and of the object itself.
        
        With this in place, the scenario described above now results in
        the area highlighted in steps 5) and 6) to have the same top-left
        corner.
        
        Change-Id: If28de14d440706bd6493626586f82859e5570e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180720
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [16684da3f18b8747714a7ddd44810cb429eab5ae]

        toolkit: Merge TableControl_Impl::{calc,impl_get}CellRect
        
        Move logic from TableControl_Impl::impl_getCellRect
        to TableControl_Impl::calcCellRect and drop the
        former.
        
        Change-Id: I2c44e72a4e781130661deebd0882939ad34c050a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180718
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [ea0faaf9bb1fab2044e6cef9bc8e3d03f63896ec]

        toolkit: Use method with return value instead of out param
        
        Return direct uses of TableControl_Impl::impl_getCellRect
        with uses of TableControl_Impl::calcCellRect
        that returns the Rectangle instead of taking an
        out Rectangle& param.
        
        (Note that the order of the row/col index params is
        reversed in both methods.)
        
        Change-Id: I32af4c14d6193c12bd0bbc91dde14bb526abc48e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180717
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [af3c7a31ea2cb979fa5819d103438ace17864472]

        toolkit a11y: Deobfuscate TableControl::calcCellRect
        
        In the only 2 callers of this method, the logic
        so far was this:
        
        1) Retrieve the child index, which is calculated
           from the row index + column index.
        
        2) Revert the calculation from step 1 by calculating
           the row and column index from the child index.
        
        3) Pass the column index calculated this way as the
           `_nRowPos` param and the row index as the
           `_nColPos` param to TableControl::calcCellRect.
           (Note that the param order is reversed from what
           at least I would naively have expected from looking
           at the param names.)
        
        4) In TableControl::calcCellRect, call
           TableControl_Impl::calcCellRect, passing the `_nRowPos`
           param as the `nRow` param and the `_nColPos` as the
           `nCol` param.
           (That looks reasonable.)
        
        5) In TableControl_Impl::calcCellRect,
           call TableControl_Impl::impl_getCellRect, which
           takes row index and column index in the reverse
           order. Pass the TableControl::calcCellRect's
           `nRow` param as TableControl_Impl::impl_getCellRect's
           `_nColumn` param and vice versa.
           (Note that using `_nRowPos`/`nRow` for the row index in
           one method and for the column pos in the other
           method is not what I would naively have expected,
           but together with 3), the order is correct again.)
        
        Make this a bit less confusing by skipping steps 1) and 2)
        and consistently using `_nRowPos`/`nRow` as param name for
        the row index, `_nColumn`/`nCol` for the column index.
        
        Change-Id: Iffb920c45e08c00087e590debebaa286368aee3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180712
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [3e447bcca78dec8c2b8f3499969641e008ad7e7f]

        toolkit a11y: Drop AccessibleGridControlBase::{g,s}etClientId
        
        The AccessibleGridControlBase::m_aClientId is
        (and should only be) used by the class itself, not by subclasses,
        so access the member directly and drop the protected getter
        and setter.
        
        Change-Id: I987cad89c7aec48fb0286d7b24e9b282db3b536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180711
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [d38bb9e0a9a192ccc6f5c71c9e173cc95e709119]

        toolkit a11y: Port away from TableControl::GetFieldIndexAtPoint
        
        Same as
        
            Change-Id: Ib2c799cdb5f8f8515ee771b241e1fd8567dc967d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jan 24 10:40:53 2025 +0100
        
                toolkit a11y: Port away from TableControl::GetFieldCharacterBounds
        
        , but for TableControl::GetFieldIndexAtPoint.
        
        Change-Id: I359376532e8e80e001e6c286ee4fdd3d7a3ea2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180710
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [1ed642a19958e65bccd21bbb7de8f03812c23ac5]

        toolkit a11y: Port away from TableControl::GetFieldCharacterBounds
        
        TableControl::GetFieldCharacterBounds ignores the first
        2 params and just calls TableControl::GetCharacterBounds,
        so use the latter directly instead and drop the former.
        
        Change-Id: Ib2c799cdb5f8f8515ee771b241e1fd8567dc967d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180697
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [7bdaccecdfd82fd2c6853be8d740a3a9dc466954]

        toolkit: Drop IAccessibleTable::GetWindowInstance
        
        This method to get a vcl::Window pointer to self is
        no more needed since
        
            commit c6c471546ee82d939092da3ac25a6548145c56c9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 23 17:29:32 2025 +0100
        
                toolkit a11y: Use pointers/refs to concrete TableControl class
        
        Use the TableControl right away instead.
        
        Change-Id: I692b0397e6d6b74d8dd5d194d1708a796e1c4e8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180696
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [dd3fae8818d0685fb67a2fad8e0b42f3de7c2fea]

        toolkit a11y: Drop methods just calling their base class implementations
        
        These were only needed before
        
            commit c6c471546ee82d939092da3ac25a6548145c56c9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 23 17:29:32 2025 +0100
        
                toolkit a11y: Use pointers/refs to concrete TableControl class
        
        to be able to call them with only a pointer/ref to the
        abstract IAccessibleTable base class.
        
        Change-Id: I9d148babaa4ac7210d9b1d3a81d7361ff8eab438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180695
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [b7a662e81432bc50ec485f6062cab4b0dc71870c]

        Drop unused RowPos typedef
        
        The `RowPos` typedef used e.g. in
        toolkit/source/controls/table/tablecontrol_impl.cxx
        is defined the same way in toolkit/inc/controls/table/tabletypes.hxx .
        
        Change-Id: Ia9997150f1b9395bf4b7a73b079e0a79639b209e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180694
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9701fa96d9a64a9d6374447a0cdb62b5746d3b9a]

        More readable grep output from bin/ui-translatable.sh
        
        Change-Id: I3faea6bf893c6c70d4fcf71146796530be062b6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180721
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-24  Michael Stahl  <michael.stahl@allotropia.de>  [225ce4b678f5f0241bf3757d9ab7e5223866c431]

        sw: layout: fix bad split table resulting in empty cell
        
        The problem is that the table goes into an infinite loop of splitting
        and joining, because there is a temporarily negative PrtArea height in
        the top row's cells (-170), because of setting all heights to 0.
        
        This causes an inconsistency where it is first joined because in
        ShouldBwdMoved() another line of text in the right column cell can move
        backward, but then there isn't enough space for another row as the
        negative cell PrtArea height is added to the available space and so the
        line won't fit in SwTextFrameBreak::IsInside(); the same situation
        occurs until a "Looping Louie" aborts the iteration with a bad result.
        
        This is somehow caused by the hidden section following the table, but
        not sure how exactly (the "if (pNxt->IsHiddenNow()) bCalcNxt = false"
        suspect code was actually added in a later commit).
        
        Prevent it by preventing negative PrtArea heights.
        
        (regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1)
        
        Change-Id: I36ce8a8bf750cf407cece5ad3cc23374182179de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180719
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-24  bruh  <randomforest33@gmail.com>  [a88b3da5b01403ba593423821843a0dacda158ec]

        tdf#158280 Replace usage of InputDialog with SvxNameDialog
        
        Change-Id: Ic70a88f391f1aca9dd7d8429cb1af9678654820e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180514
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [577c47a279b4307a563f8387a16b354a470e6830]

        sc: factor out common code
        
        Change-Id: Ie76ee43b4fd00d5a1e152532017b3a30581252cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180715
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [5506dd8bcf587ac4472ce28d26c174bfdfd08f91]

        tdf#151001: Add support for EXPAND function
        
        Change-Id: I4eabd526d656c13da7792d3c195f036ce78bd0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180706
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-24  Miklos Vajna  <vmiklos@collabora.com>  [32f0b68a9cb4f2762f9b5d31713972e6a430a2f2]

        cool#11002 sfx2: fix uncaught exception in SfxObjectShell::isExportLocked()
        
        Similar to commit 71aa5352f6f57283d1db51c980f6f0b802381871 (sfx2: fix
        uncaught exception in SfxObjectShell::isEditDocLocked(), 2025-01-23).
        
        This seems to be the last problem with this pattern.
        
        Change-Id: Ibaceb23beaff808d9f192fd55505361bf74016b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180709
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1c3ffcb60d55c2c2ac92bf998c98732f5d982fc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3d44a635cf6f1dde13883262a259c0d73e020a0
          - tdf#164318 Add help page for the new Copy Field Content dialog
            
            Change-Id: I3ea5b64ce58bcf934c3f80b2b45904bfb624f2b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180419
            Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
            Tested-by: Jenkins
            
2025-01-24  Oliver Specht  <oliver.specht@cib.de>  [a45428d4bdf733718bad2d87412eb0932c90d27e]

        tdf#164318 Add dialog to show content of fields in readonly documents
        
        Change-Id: I0036e8c02b57dab91361213489c5a6189149b553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179953
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc5e9c0d0afe0e7ffeb3d2c4475852620b3fc2e2]

        remove some unnececessary ColorMask includes and forwards
        
        Change-Id: I33c43e14e962991f89b960cd10519cf1a37cb84e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b6d1050ffe1c538426e8365802439e0c1b9f313]

        no need to use ColorMask in BitmapBuffer
        
        ever since
            commit 291c6d7626278e0d0db1b0bcd9e7c911eb8eeb83
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 24 11:55:11 2025 +0200
            no need to use color mask in QuartzSalBitmap::AcquireBuffer
        
        Change-Id: I3bdd5ec96d69a8ee75d92c46040ec0b352de1f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [973771c8cd1e9888f34511919070a0161e079229]

        no need to store ColorMask in BitmapInfoAccess
        
        when we already have it in the BitmapBuffer we point to
        
        Change-Id: I64158251c113f9dd11f21f4f3f112248b82db5f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e77eefb0ef2d6a23a2d9833ad9783a194c37d1b]

        no need to use color mask in QuartzSalBitmap::AcquireBuffer
        
        ever since
            commit b29e161488f0291f381f04e2533106321f357c1e
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Jan 10 21:19:54 2025 +0200
            make the ScanlineFormat values more explicit
        
        Change-Id: I5a348659e1d341e3f33e0a2636697e37aaabfe47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [42cc3b58451dec8a99af9c26e8bc947cce0ae058]

        N32BitTcMask is unnecessary
        
        The remaining usage site can use N32BitTcXrgb
        
        Change-Id: I97c0a7e97d45dfcb4726b197159ca2f197b43713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Miklos Vajna  <vmiklos@collabora.com>  [99f4c0fc0a0e12ff7e72a4b047a6d8cfdfee5012]

        cool#11002 sfx2: fix uncaught exception in SfxObjectShell::isContentExtractionLocked()
        
        Similar to commit 71aa5352f6f57283d1db51c980f6f0b802381871 (sfx2: fix
        uncaught exception in SfxObjectShell::isEditDocLocked(), 2025-01-23).
        
        Change-Id: I9f6c35c8b2934fee193a4c4211f4d3fbcad12aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180691
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c55d9be304f0f6eb88488c46031a17e1ccac1eb]

        expose Add to Dictionary menu entries to kit
        
        Change-Id: If9a072afef339110a4d44366b1f2e515e6feb55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178917
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2ce644117859138121869ff6146822c153ea60f0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180692
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-24  bruh  <randomforest33@gmail.com>  [cc42d34ce938352135fb405a47d5bc7e5d929e1b]

        tdf#158624 -  Improve warning dialogue for non-recommended formats during save
        
        Implemented changes to display the recommended file extension in the
        warning dialogue when a non-recommended extension is selected during
        document save. This improves user guidance and ensures better file
        format compatibility.
        
        Change-Id: I08208a8968f37a4dfeb34623402004b41a0a2c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180605
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7befa23eacd46607afdf1363d9aaa93a589f547]

        remove remnants of 1-bit bitmap support
        
        dead since
            commit 21734247d58a6e915b058d8fa55ece949d049613
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jan 10 12:56:58 2023 +0200
            drop internal support for 1-bit images
        
        Change-Id: I755423e339dac797abc726012cfb96d27b8f15fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [fee5ffe67ca3100a9fc2e4830aff2bea0d22591b]

        remove remnants of 16-bit bitmap support from windows backend
        
        dead since
            commit 78b9dac2ee77bf6efc1298962cbeca284db5b00a
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Sep 24 21:38:51 2019 +0200
            remove internal use of 16-bit packed formats
        
        Change-Id: Iab6e4fc4b6bc4c83deac07d587bc8c996359e3d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180689
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1bda2919756c8a5ef5e7505614938033950f87c]

        BI_BITFIELDS in windows vcl backend is unused
        
        all the way back to initial import
        
        Change-Id: I2bfc75b2461496a1b7d127d211a7c358092ab2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-24  Miklos Vajna  <vmiklos@collabora.com>  [7ce3ff3edefe7f4540f37754d789035286634b9b]

        cool#11002 sfx2: fix crash in SfxViewFrame::StateReload_Impl()
        
        Now that the scheduler no longer calls std::abort(), we crashed with:
        
        	#5  <signal handler called>
        	(gdb)
        	#6  std::__uniq_ptr_impl<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::_M_ptr (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:191
        	191           pointer    _M_ptr() const noexcept { return std::get<0>(_M_t); }
        	(gdb)
        	#7  0x00007ff37cdaf9da in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::get (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:462
        	462           { return _M_t._M_ptr(); }
        	(gdb)
        	#8  0x00007ff37cdab888 in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::operator-> (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:455
        	455             return get();
        	(gdb)
        	#9  0x00007ff37cd989e3 in SfxMedium::GetItemSet (this=0x0) at sfx2/source/doc/docfile.cxx:3810
        	3810        if (!pImpl->m_pSet)
        	(gdb) up
        	#10 0x00007ff37d082c50 in SfxViewFrame::StateReload_Impl (this=0x1ba830c0, rSet=SfxItemSet of pool 0x18ba4d60 with parent 0x0 and Which ranges: [(6312, 6312)] = {...})
        	    at sfx2/source/view/viewfrm.cxx:944
        	944                         const SfxBoolItem* pItem = pSh->GetMedium()->GetItemSet().GetItem(SID_EDITDOC, false);
        	(gdb) print pSh->GetMedium()
        	$1 = (SfxMedium *) 0x0
        
        So just check for that case when the shell doesn't have a medium.
        
        Change-Id: I0198121853d283253b782c7e526ef8ef9436eed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180685
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-24  Heiko Tietze  <tietze.heiko@gmail.com>  [70e9083c0e511ae845a43b6ceaf9e79ee47ab880]

        Resolves tdf#164586 - Confirm 'Delete all comments'
        
        Option Common::Misc::QueryDeleteAllComments added but
        with default false to keep the familiar workflow and
        to prevent macros to fails
        
        Change-Id: I9424d900d226b7b757701f5f16209a0241adf7cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180596
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [9bf96332b57efdff2755ec498cda17408ff5deca]

        tdf#150998: Add support for DROP function
        
        Change-Id: Id84cbf25e655410c3fac655cd88f1d74dc98defd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180673
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [81f7503d2d205f4f6df0bfd1a66ed10cccb556c2]

        tdf#132853 - UI: fix different sizes in Image tabs Type & Crop
        
        Sincornize Graphic frame size and frame size values in Writer
        "Position and Size" tab and "Crop" tab.
        
        Change-Id: Ifc325bb510ac4d2376ec5be791aadb7df81e8ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180510
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2025-01-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [38a25d0e18430d1936a554fbd363dde21aa547ad]

        Fix typo in code
        
        "paintPolyPoylgonRGBA"->"paintPolyPolygonRGBA"
        
        Change-Id: I9969634d9bd286c25b8c1953b1b7ddf1a4bf4629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180654
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-24  László Németh  <nemeth@numbertext.org>  [c377f4f038293fa57b6abed46e6576c29813888a]

        tdf#121119 master docs at-page anchor: clean-up renaming
        
        Add file name only to the objects anchored at page, not
        to all of them.
        
        Follow-up to commit 2f135fa82c5d78ddafc14f38c0ee33358075b266
        "tdf#121119 master docs at-page anchor: fix missing images",
        commit fb4197ed81765e122b862471e184fcade4a2b524
        "tdf#121119 master docs at-page anchor: fix duplicated images"
        and commit 47d596688f2dcdf67fab24e58d92f823e69c0c35
        "tdf#121119 master docs at-page anchor: fix runtime duplicated images".
        
        Change-Id: If851818731e87225d53370978a92c02cfb5d7189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180678
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [d7412fdc0d422df7d3240307449ad602a6180508]

        toolkit a11y: Drop AccessibleGridControlAccess::getContext
        
        No need for a public getter, as this is only used
        by the class itself, and that one can use the
        `m_xContext` member directly.
        
        Change-Id: Ice625a63e84512ac5d77fd26e8d67b4977eb48e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [c6c471546ee82d939092da3ac25a6548145c56c9]

        toolkit a11y: Use pointers/refs to concrete TableControl class
        
        Use pointers/references to the concrete TableControl class
        instead of the interface (abstract base class) IAccessibleTable,
        now that all relevant code is located inside toolkit since
        
            Change-Id: Ic93796bce96916192da7cfffcf1faf00905373c7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 23 16:26:57 2025 +0100
        
                a11y: Move AccessibleGridControl* classes to toolkit
        
        and there's no more need to use an abstract interface to avoid
        dependencies between multiple modules anymore.
        
        As requested by loplugin:vclwidgets, use a VclPtr now
        for AccessibleGridControlAccess::m_pTable (now renamed
        to `m_xTable`).
        
        Getting rid of the IAccessibleTable base class altogether
        can be considered for a separate commit.
        
        Change-Id: I5c8c8ae22db3a7b3e1ba8cb751482a647bb9663a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180670
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [80409cacf1ea34f395848875d304326d2755e5c5]

        a11y: Drop IAccessibleTableControl
        
        Now after
        
            Change-Id: Ic93796bce96916192da7cfffcf1faf00905373c7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 23 16:26:57 2025 +0100
        
                a11y: Move AccessibleGridControl* classes to toolkit
        
        , AccessibleGridControlAccess is in the toolkit library
        and can be used directly, which removes the need to
        abstract from the actual implementation by using
        an interface (abstract base class) IAccessibleTableControl.
        
        Therefore, drop that one and use references to
        AccessibleGridControlAccess instead.
        
        Change-Id: I81a0de53d0190477e238fe4c5010379bd8fd46d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180669
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [d040635b8e0b74a1d6cfee175cdc64bd29c60a84]

        a11y: Move AccessibleGridControl* classes to toolkit
        
        Move AccessibleGridControlAccess and all related
        classes from vcl to toolkit, as that is where the
        grid control that makes use of them is located.
        
        Stop using the AccessibleFactory to create the
        AccessibleGridControlAccess, but call the ctor
        directly in TableControl_Impl::getAccessible,
        now that the class is also in the toolkit module.
        
        Further simplificiation can happen in upcoming
        commits.
        
        Change-Id: Ic93796bce96916192da7cfffcf1faf00905373c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180668
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [6fc13fb03bc96eda65b91fd65ada26a162437404]

        toolkit: Move TableControl key input logic into that class
        
        Move logic from DefaultInputHandler::KeyInput
        into the only caller, TableControl::KeyInput.
        
        Drop ITableControl::dispatchAction from that interface
        as TableControl is now the only caller and that one
        knows that it's TableControl::m_pImpl is a
        TableControl_Impl.
        
        Change-Id: I0445ce10f8abee17ab6e4895aba5adf42974721b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180662
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [57906dde339a71eee87437ae2d11c7474c03befd]

        tdf#164783 toolkit a11y: Only send event for current cell if there's one
        
        TableControl::commitCellEventIfAccessibleAlive sends an event
        on the currently selected/active cell. So only call it in
        SVTXGridControl::ProcessWindowEvent when there is one.
        
        Use TableControl::GetCurrentRow and TableControl::GetCurrentColumn
        to check that, which return a special value (of -2) for the case there
        is no active cell.
        
        For TableControl::GetCurrentRow:
        
                /** retrieves the current row
        
                    The current row is the one which contains the active cell.
        
                    @return
                        the row index of the active cell, or ->ROW_INVALID
                        if there is no active cell, e.g. because the table does
                        not contain any rows or columns.
                */
                sal_Int32 GetCurrentRow() const override;
        
        The previous check whether the table has any rows was insufficient
        and resulted in an invalid attempt to access vector elements at
        negative indices.
        
        For the tdf#164783 scenario:
        
            /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/debug/vector:508:
            In function:
                reference
                std::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>>::operator[](size_type)
                [_Tp = rtl::Reference<accessibility::AccessibleGridControlTableCell>,
                _Allocator =
                std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell>>]
        
            Error: attempt to subscript container with out-of-bounds index -6, but
            container only holds 60 elements.
        
            Objects involved in the operation:
                sequence "this" @ 0x5638c74e2350 {
                  type = std::debug::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>, std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell> > >;
                }
            /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/debug/vector:508:
            In function:
                reference
                std::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>>::operator[](size_type)
                [_Tp = rtl::Reference<accessibility::AccessibleGridControlTableCell>,
                _Allocator =
                std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell>>]
        
            Error: attempt to subscript container with out-of-bounds index -6, but
            container only holds 60 elements.
        
            Objects involved in the operation:
                sequence "this" @ 0x5638c74e2350 {
                  type = std::debug::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>, std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell> > >;
                }
                sequence "this" @ 0x5638c74e2350 {
                  type = std::debug::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>, std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell> > >;
                }
        
            Fatal exception: Signal 6
            Stack:
            #0 sal::backtrace_get(unsigned int) at .../libreoffice/sal/osl/unx/backtraceapi.cxx:42
            #1 (anonymous namespace)::printStack(int) at .../libreoffice/sal/osl/unx/signal.cxx:289
            #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at .../libreoffice/sal/osl/unx/signal.cxx:330
            #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at .../libreoffice/sal/osl/unx/signal.cxx:427
            #4 /lib/x86_64-linux-gnu/libc.so.6(+0x3fda0) [0x7f7544649da0]
            #5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 (discriminator 1)
            #6 raise at ./signal/../sysdeps/posix/raise.c:27
            #7 abort at ./stdlib/abort.c:81
            #8 std::__throw_bad_exception() in /lib/x86_64-linux-gnu/libstdc++.so.6
            #9 std::__debug::vector<rtl::Reference<accessibility::AccessibleGridControlTableCell>, std::allocator<rtl::Reference<accessibility::AccessibleGridControlTableCell>>>::operator[](unsigned long) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/debug/vector:508
            #10 accessibility::AccessibleGridControlTable::getAccessibleChild(long) at .../libreoffice/vcl/source/accessibility/AccessibleGridControlTable.cxx:66
            #11 accessibility::AccessibleGridControlTable::getAccessibleCellAt(int, int) at .../libreoffice/vcl/source/accessibility/AccessibleGridControlTable.cxx:191
            #12 accessibility::AccessibleGridControl::commitCellEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) at .../libreoffice/vcl/source/accessibility/AccessibleGridControl.cxx:272
            #13 accessibility::AccessibleGridControlAccess::commitCellEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) at .../libreoffice/vcl/inc/accessibility/AccessibleGridControl.hxx:197
            #14 svt::table::TableControl_Impl::commitCellEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) at .../libreoffice/toolkit/source/controls/table/tablecontrol_impl.cxx:2304
            #15 svt::table::TableControl::commitCellEventIfAccessibleAlive(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) at .../libreoffice/toolkit/source/controls/table/tablecontrol.cxx:470
            #16 SVTXGridControl::ProcessWindowEvent(VclWindowEvent const&) at .../libreoffice/toolkit/source/controls/svtxgridcontrol.cxx:823
            #17 VCLXWindow::WindowEventListener(VclWindowEvent&) at .../libreoffice/toolkit/source/awt/vclxwindow.cxx:390
            #18 VCLXWindow::LinkStubWindowEventListener(void*, VclWindowEvent&) at .../libreoffice/toolkit/source/awt/vclxwindow.cxx:383
            #19 Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const at .../libreoffice/include/tools/link.hxx:101
            #20 vcl::Window::CallEventListeners(VclEventId, void*) at .../libreoffice/vcl/source/window/event.cxx:262
            #21 Control::CallEventListeners(VclEventId, void*) at .../libreoffice/vcl/source/control/ctrl.cxx:298
            #22 Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&) at .../libreoffice/vcl/source/control/ctrl.cxx:305
            #23 Control::EventNotify(NotifyEvent&) at .../libreoffice/vcl/source/control/ctrl.cxx:247
            #24 vcl::Window::CompatNotify(NotifyEvent&) at .../libreoffice/vcl/source/window/window.cxx:3943
            #25 vcl::Window::LoseFocus() at .../libreoffice/vcl/source/window/window.cxx:1861
            #26 svt::table::TableControl::LoseFocus() at .../libreoffice/toolkit/source/controls/table/tablecontrol.cxx:94
            #27 vcl::Window::CompatLoseFocus() at .../libreoffice/vcl/source/window/window.cxx:3912
            #28 vcl::Window::ImplAsyncFocusHdl(void*) at .../libreoffice/vcl/source/window/winproc.cxx:2127
            #29 vcl::Window::LinkStubImplAsyncFocusHdl(void*, void*) at .../libreoffice/vcl/source/window/winproc.cxx:2033
            #30 Link<void*, void>::Call(void*) const at .../libreoffice/include/tools/link.hxx:101
            #31 ImplHandleUserEvent(ImplSVEvent*) at .../libreoffice/vcl/source/window/winproc.cxx:2288
            #32 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at .../libreoffice/vcl/source/window/winproc.cxx:2849
            #33 SalFrame::CallCallback(SalEvent, void const*) const at .../libreoffice/vcl/inc/salframe.hxx:311
            #34 SalGenericDisplay::ProcessEvent(SalUserEventList::SalUserEvent) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:67
            #35 SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const at .../libreoffice/vcl/source/app/salusereventlist.cxx:119
            #36 SalUserEventList::DispatchUserEvents(bool) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120
            #37 SalGenericDisplay::DispatchInternalEvent(bool) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:51
            #38 call_userEventFn(void*) at .../libreoffice/vcl/unx/gtk3/gtkdata.cxx:827
            #39 /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x5a81f) [0x7f7536f0b81f]
            #40 /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x5ca57) [0x7f7536f0da57]
            #41 g_main_loop_run in /lib/x86_64-linux-gnu/libglib-2.0.so.0
            ...
        
        Change-Id: Iafed90e6985cf2c05d65be5f74334f58b369d945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180661
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [dc6d5c1fc6bd8700281f478f7df8f5bb594a85ca]

        toolkit: Drop TableDataWindow's unnecessary friend class
        
        TableFunctionSet doesn't need access to any non-public
        members.
        
        Change-Id: I73acd3b1efd8ff326a08b3a2a404c047729f8ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180660
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [c2753661d74bb099560d23da189337827414f930]

        toolkit: Make TableControlAction an enum class
        
        Change-Id: I70197d55a95c3d87a2d0921aca4d05068d88d5b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180659
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [8f22441d5eb06d134bc12a51da632880a998634e]

        toolkit: Drop obsolete SVTXGridControl TODO
        
            commit e8f649b5ad64a2a3f07dfab1a52033d126da211b
            Author: Frank Schoenheit [fs] <frank.schoenheit@oracle.com>
            Date:   Wed Jan 19 11:11:29 2011 +0100
        
                gridsort: render indicator for current column sort
        
        replaced the previous `pTable->Invalidate();` with
        
            pTable->getTableControlInterface().invalidate( TableAreaRowHeaders );
        
        , which should have implemented what the TODO was
        suggesting (invalidate the header area only).
        
        Change-Id: Iae9f8cee75d25ce982597e0da654357ec8c03692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180658
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [ba0d9c0f3f6ddcd4a783f886702c825c3728be59]

        toolkit: No longer provide getter for TableControl::m_pImpl
        
        Drop TableControl::getTableControlInterface that was
        providing direct access to TableControl::m_pImpl
        via the ITableControl interface.
        
        This was only used in SVTXGridControl to call
        ITableControl::hitTest and ITableControl::invalidate.
        
        Add new methods TableControl::hitTest and
        TableControl::invalidate which allow doing exactly
        that via the TableControl without requiring direct
        access to the `m_pImpl` from outside.
        
        Change-Id: I098739e0bb64efcbaafdb8762e082d6f7b7325bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180633
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [0f82767a7d2d396687d2be7f9374e64e6071bc00]

        toolkit: Drop DBG_CHECK_ME macro
        
        Use DBG_TESTSOLARMUTEX directly.
        
        Change-Id: If3dd942d1e3d32615a82419071f1a4b8a7e5eceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180632
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [9391dd417ec20e033c6d61cf41c9945aa039ce0a]

        toolkit: Move DefaultInputHandler::{Get,Lose}Focus logic to only callers
        
        Both always return false, so Control::{Get,Lose}Focus
        always gets called.
        
        Change-Id: If26132d68cebfb7930f12418480480ddd3cb9333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180631
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [17bd739038c18b99f61e341fbb6b93495efb4eb3]

        toolkit: Drop ITableInputHandler
        
        Drop the ITableInputHandler interface (abstract class)
        that is only implemented by a single subclass,
        DefaultInputHandler, and use that one directly.
        
        Adjust the PTableInputHandler to
        
            typedef std::shared_ptr<DefaultInputHandler> PTableInputHandler
        
        and take over method comments to DefaultInputHandler.
        
        Make methods non-virtual and follow the
        loplugin:staticaccess suggestion to make 3 of
        the methods static.
        
        This also prepares for further code simplification in
        upcoming commits.
        
        Change-Id: Ib4f3c2eb9f132da0484ef86a404251e3cdd84890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180630
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-23  Jonathan Clark  <jonathan@libreoffice.org>  [43fc662520e5488cbeadd6eb60a24374a837dca4]

        tdf#164803 sw: Fix SwTextSizeInfo applying grid metrics without grid
        
        Writer has two grid attributes: the document-level grid item, which
        controls whether the grid is enabled; and a paragraph-level grid item,
        which controls whether the document grid applies to the paragraph.
        
        Previously, SwTextSizeInfo populated its snap-to-grid flag based only on
        the paragraph-level attribute. Downstream code was expected to
        double-check that the grid is actually enabled using the document-level
        item. As shown by tdf#164803, this is error-prone.
        
        Now, SwTextSizeInfo only sets the snap-to-grid flag when the grid is
        enabled by both attributes.
        
        Change-Id: I6528f653748de942f42da11e34ff340cb3db37e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180676
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-01-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [15e917c9f7f95e48c2a6316b458822212b032e54]

        update credits
        
        Change-Id: Id31f9191d74ee1f784a57b301fc3beaded326571

2025-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f071292a5af10f4718302a1bf9cc9cdc37528225]

        tdf#160578: do not modify procedure argument type based on its use
        
        Since the initial import, there is a code in SbiExpression::Term, that
        checks if the defined symbol is used as object (e.g., dot notation to
        access its members), and then, if its defined type is Variant, then it
        is corrected to Object. There is no rationale for this in comments; so
        I have no way to know what could break if that core is dropped.
        
        It's obvious that at least for procedure arguments, such correction is
        wrong: the argument definition is the procedure's API; and the actual
        use of the symbol should not unexpectedly change what is advertised.
        
        This change limits the application of the correction to non-arguments.
        If it should be dropped completely is a separate question.
        
        Change-Id: Ia902afa3f744d0d51510ba6903be45f78e2f6429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180665
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [63e7a70ad1a6a8ec4190ab510f683d2fc9dea417]

        tdf#164811: swap the "if IsCompatibility()" branches to match other places
        
        Commit 9cdb73ff28c4cd6380412468f34ff10e46292a07 (INTEGRATION: CWS jl5vba
        (1.25.94); FILE MERGED, 2004-03-17) has introduced handling of decimal,
        currency, and date for VBASupport mode in sbunoobj.cxx. However, in
        getUnoTypeForSbxBaseType, it changed the behavior for date type in the
        non-VBASupport mode, obviously by mistake. This change swaps the code
        in the 'if' branches, to what appears to be the original intention.
        
        Change-Id: I88cddf7cec1a980f56de96ae1c5e64d8e7630b77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180637
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [073022ec122e75931395d6f25de2d19ffbac058e]

        Avoid matching the 'if' with an empty reference
        
        Commit d833992e7e06f7d385fca6ffe35ce66b79360a63  (Avoid checking
        exact interface type of Any value,  2024-11-08)  had modified an
        'if' condition in ScFunctionAccess::callFunction, so an Any with
        a reference  to an object  implementing  the requested interface
        could be matched, even if the Any points to another interface of
        the object. However, it made an empty XInterface reference match,
        too, which is unexpected.
        
        It is not a real problem now:  both no match,  and a match of an
        empty reference  set the error;  but in the future,  a new "else"
        branch could be added  after this one,  and then it could behave
        unexpectedly, so fix it here.
        
        Change-Id: I43375fc34fe01665e7984ea6ad7052f7969c13c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180636
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [d165b70f986558f30440228c47223c40f5b129e5]

        sc: these new functions are from 2024
        
        While at it, fix FunctionData of WRAPCOLS and WRAPROWS
        caused by a copy&paste mistake
        
        Change-Id: I2061ae89e42665b606aacb5dd40fdfb0f99ddee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180624
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [e820e7a33bd84773498ec91dc8f21b5a5c1c40fd]

        tdf#150997: Add support for TAKE function
        
        Change-Id: I2e7d223707941d31db0330282f783e845497130b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180622
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-23  Miklos Vajna  <vmiklos@collabora.com>  [71aa5352f6f57283d1db51c980f6f0b802381871]

        sfx2: fix uncaught exception in SfxObjectShell::isEditDocLocked()
        
        Crashreport signature:
        
        SIG   Fatal signal received: SIGABRT code: 18446744073709551610 for address: 0x1da00001e2c
        program/libmergedlo.so
        	Scheduler::CallbackTaskScheduling()
        		vcl/source/app/scheduler.cxx:486 (discriminator 7)
        program/libmergedlo.so
        	comphelper::SolarMutex::release(bool)
        		include/comphelper/solarmutex.hxx:91
        program/libmergedlo.so
        	SvpSalInstance::ImplYield(bool, bool)
        		vcl/headless/svpinst.cxx:401
        program/libmergedlo.so
        	SvpSalInstance::DoYield(bool, bool)
        		vcl/headless/svpinst.cxx:475
        
        I.e. we do an abort when a task throws when the scheduler processes
        events on the main loop. This happens *sometimes* locally, but it's
        unclear to me how to reliably trigger it. When it happens, we warn like
        this:
        
        warn:vcl.schedule:27650:27441:vcl/source/app/scheduler.cxx:485: Uncaught com.sun.star.lang.NotInitializedException message: "at sfx2/source/doc/sfxbasemodel.cxx:3034" context: SdXImpressDocument
        
        Checking the SAL_DEBUG_BACKTRACE() output for the case when
        SfxBaseModel::MethodEntryCheck() throws:
        
        	#3 instdir/program/libsfxlo.so(SfxBaseModel::MethodEntryCheck(bool) const+0x154) [0x7fec1e8ad9b4]
        	#4 instdir/program/libsfxlo.so(+0x6bdd1e) [0x7fec1e8bdd1e]
        	#5 instdir/program/libsfxlo.so(SfxBaseModel::getArgs2(com::sun::star::uno::Sequence<rtl::OUString> const&)+0x56) [0x7fec1e8a0dd2]
        	#6 instdir/program/libsfxlo.so(SfxObjectShell::isEditDocLocked() const+0x11c) [0x7fec1e8239da]
        	#7 instdir/program/libsfxlo.so(+0x882851) [0x7fec1ea82851]
        	#8 instdir/program/libsfxlo.so(+0x87cefc) [0x7fec1ea7cefc]
        	#9 instdir/program/libsfxlo.so(SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*)+0x1cc) [0x7fec1e4d57f4]
        	#10 instdir/program/libsfxlo.so(+0x2b900a) [0x7fec1e4b900a]
        	#11 instdir/program/libsfxlo.so(+0x2bd954) [0x7fec1e4bd954]
        	#12 instdir/program/libsfxlo.so(+0x2bd631) [0x7fec1e4bd631]
        	#13 instdir/program/libsfxlo.so(+0x2bd5a1) [0x7fec1e4bd5a1]
        	#14 instdir/program/libvcllo.so(+0xf4fb91) [0x7fec1894fb91]
        	#15 instdir/program/libvcllo.so(Timer::Invoke()+0x23) [0x7fec1894fa19]
        	#16 instdir/program/libvcllo.so(Scheduler::CallbackTaskScheduling()+0x123d) [0x7fec188fe277]
        
        Fix this in SfxObjectShell::isEditDocLocked(), where we already return
        false to avoid a nullptr dereference, and do it the way
        SfxObjectShell::isScriptAccessAllowed() does the same for consistency.
        
        Change-Id: I435b2877b1b600e01bf32b44bfa664be1672c231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180663
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d3ae791b2fed42d87208c3a44a9d70bec544d238]

        ofz#391709141 Abrt __cxxabiv1::failed_throw
        
        Change-Id: I2c1f59707e24d0de9ab65704ee659355090a32f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180651
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-23  László Németh  <nemeth@numbertext.org>  [47d596688f2dcdf67fab24e58d92f823e69c0c35]

        tdf#121119 master docs at-page anchor: fix runtime duplicated images
        
        Asking for "All" update of the master document resulted
        duplicated objects anchored at page, loading the subdocuments
        again, which contained the images originally.
        
        Follow-up to commit 2f135fa82c5d78ddafc14f38c0ee33358075b266
        "tdf#121119 master docs at-page anchor: fix missing images"
        and commit fb4197ed81765e122b862471e184fcade4a2b524
        "tdf#121119 master docs at-page anchor: fix duplicated images".
        
        Change-Id: I4c76c325963cd740906045653fc90055ce1840c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180628
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2025-01-23  László Németh  <nemeth@numbertext.org>  [fb4197ed81765e122b862471e184fcade4a2b524]

        tdf#121119 master docs at-page anchor: fix duplicated images
        
        Skip saving images anchored at page in the master document,
        if they are imported from subdocuments to avoid their duplication
        during the round-trip/update of the linked subdocuments.
        
        Follow-up to commit 2f135fa82c5d78ddafc14f38c0ee33358075b266
        "tdf#121119 master docs at-page anchor: fix missing images".
        
        Change-Id: I731026bee01576fe66c9d677b53c7f85a53230fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180627
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-01-23  László Németh  <nemeth@numbertext.org>  [2f135fa82c5d78ddafc14f38c0ee33358075b266]

        tdf#121119 master docs at-page anchor: fix missing images
        
        Images and other objects anchored at pages weren't imported
        from the subdocuments, resulting broken master document.
        
        Subdocuments are imported as sections of the master document,
        but their objects anchored at page need a document-level copy,
        not a section one. To calculate the new document-level page
        number of the copied object, store and sum the page count
        meta data of the previous subdocuments, added to the subdocument-
        level page number of the object.
        
        Note: the recent solution doesn't calculate with the own text
        content of the master document yet. As a workaround, to get
        the original page number exactly, store everything in subdocuments
        before the objects anchored at page.
        
        The problem is inherited from OpenOffice.org, see ooo#19131.
        
        Change-Id: I0be80bb27442565764142d2b23b0f56a3421c035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180626
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2025-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [333484e34418a3e33633d231d3e3386d79911486]

        Fix typo
        
        Change-Id: Id343170838639e1b3f6e762f7769a9f0b066f9be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180653
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5c4cbad694239ad387c70ddf28d00eebd32c3c6f]

        Fix typos
        
        Change-Id: I6cee3b0b283feff5b153301bed5a0cae2ef88eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180652
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2afd2aa8c205840e98dc59e067b8fe07c29fea29]

        Fix typo
        
        Change-Id: I487635a431735308f8244eed7d66e3b0b014e205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180655
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6ef212e670bafdfe6f52c57e5141506aef09b4ce]

        Fix typo
        
        Change-Id: Ia7bf5acfdc6b30f31d29d7938c419f9e26b43ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180657
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cf308761a5bb1d925a2378d4476a52c4141bc020]

        Fix typo
        
        Change-Id: Iaae13f81959f54eb0d216a4bd15f8527eec8595b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180656
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-23  Skyler Grey  <skyler.grey@collabora.com>  [dd7d9a61c95bf9c13ded2044193d6b7a2e27b87b]

        fix(ooxmlexport): Prevent unknown media type crash
        
        To determine the extension of a media file, we just take whatever parts
        of the URL were left after the final dot.
        
        Normally this is something normal such as `mp4`, `mp3` or suchlike
        
        Unfortunately, sometimes (such as when in Collabora Online) this URL
        would is actually be something Uno-y, leaving an extension like
        
           Package:Media
        
        That's no good, because in Zip files we can't have colons in our names,
        at least according to our Zip file name checker, which looks through and
        denies access to any file names that have colons in
        
            bool OStorageHelper::IsValidZipEntryFileName( std::u16string_view aName, bool bSlashAllowed )
            {
                long nDots{0};
                for ( size_t i = 0; i < aName.size(); i++ )
                {
                    switch ( aName[i] )
                    {
                        // ------------------ 8< cut ------------------
                        case ':':
                            return false;
        
        Promptly causing us not to open a file output stream...
        
            if ( aElementName.isEmpty() || !::comphelper::OStorageHelper::IsValidZipEntryFileName( aElementName, false ) )
                throw lang::IllegalArgumentException( THROW_WHERE "Unexpected entry name syntax.", uno::Reference< uno::XInterface >(), 1 );
        
            -> leading to implOpenSubStorage failing to set xSubXStorage...
        
            if( mxStorage.is() ) try
            {
                // XStorage::isStorageElement may throw various exceptions...
                if( mxStorage->isStorageElement( rElementName ) )
                    xSubXStorage = mxStorage->openStorageElement(
                        rElementName, css::embed::ElementModes::READ );
            } catch ... { ... }
        
        ...and eventually to us never having an output stream in the first place...
        
            Reference<XOutputStream> xOutStream = mpFB->openFragmentStream(sFileName, aMimeType);
        
            gdb$ print xOutStream
            $1 = empty uno::Reference
        
        ...and crashing the code that tries to copy to that stream.
        
        The upshot of this bug is that any videos inserted with Collabora Online
        (or presumably similar .uno command use) crash LO when you later try to
        save your .pptx
        
        The quick fix here is to replace colons with another character, which is
        what I've done here. Future followup patches could do other sensible
        things like stopping crashes if we can't open an output stream for
        whatever reason or figuring out what to do with names that aren't
        permitted for reasons other than colon use.
        
        Change-Id: I9113b272d29f74882dc25bf6e74306bd9ecd58a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180635
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [1caad5a5f7251423ca3ba8c0bbe9d2bceaf16603]

        pyuno: call target only with internal python
        
        Change ifeq ($(SYSTEM_PYTHON),) to ifneq ($(SYSTEM_PYTHON),TRUE)
        to make it more obvious
        
        Change-Id: Ie104a31ee4ac5858686af3836f3a04f2d7ea0336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180625
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [804da806ed9fc6436ee81b2fbd7988611d2523f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5eeb4854797b00302a1f78e439ec63c78e3f559c
          - The "point" mentioned in the help is not a "printer point"
            
            ... but a PostScript point (1/72 in).
            
            Change-Id: Ibc43cb702e5ea891d571f7d28f806fa28d957f15
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180640
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Tested-by: Jenkins
            
2025-01-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b811b283c254fb48d8991576dfee0bae3dc322dd]

        Extend the Link DBG_UTIL support to non-member function Links
        
        ...so that they don't report "unknown" (and make empty links report "empty"
        instead, for clarification).  This introduces a new LINK_NONMEMBER macro; the
        non-default Link ctor should no longer be used directly, so make it private.
        
        Change-Id: I4ae99758de57adb8569ce98cb3824e875b26c959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180593
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-23  Chris Sherlock  <chris.sherlock79@gmail.com>  [10d8402957fe7b8a148a2abd719b7f2cb15f05a7]

        vcl: move variables closer to first use in BitmapColorQuantizationFilter
        
        Change-Id: I8a539718ef0eedfea9fadb2bd5ec321bcb8f108e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173703
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b7aadb5298d8a42525da3b206952e61d59c5c202]

        defer finding dialog parent until we need it
        
        which might be never for the typical save
        
        Change-Id: I2989f2e9629ce13c8b301a6b85707443ddc4954a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180606
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [c9d250ef724a358b9c7ab56d2188cd7e23cd121d]

        tdf#130857 qt weld: Support "Java Start Parameters" dialog
        
        Declare support for the InputDialog that can be triggered like
        this:
        
        1) "Tools" -> "Options" -> "Advanced"
        2) "Parameters"
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I8dd405bd2957bed8d0c58247285f8df848a89a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180614
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [89904461809e41262233ef9be73aa3c45d14c394]

        tdf#130857 qt weld: Support InputDialog
        
        Declare support for the InputDialog that can be triggered e.g. like
        this:
        
        1) "Tools" -> "Options" -> "Advanced"
        2) "Parameters"
        3) type anything in the "Java start parameter" edit
        4) confirm using "OK" button
        5) select the param in the list
        6) press the "Edit" button
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I74299b2a920a91508add971e09cc95d4c3c3b3b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180613
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [a4ef8bb7cab6e4845b0ded20097e004530595275]

        tdf#130857 qt weld: Implement setting font color
        
        Similar to the existing QtInstanceWidget::set_background,
        add a helper method QtInstanceWidget::setFontColor
        to set the font/foreground color, and call it from the
        subclasses that have a set_font_color method.
        
        With this in place, the "warningmsg" label in
        the "Security Level" tab
        (xmlsecurity/uiconfig/ui/securitylevelpage.ui)
        of the macro security dialog now shows with
        the font color that gets set in
        MacroSecurityLevelTP::SetWarningLabel in a WIP
        branch where support for that dialog is declared
        in QtInstanceBuilder.
        
        Change-Id: I100d4c708bd6d19e99870cd0c2158ce542326480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180612
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [cfee53a71ecf0f4cf5788a7748352fe981d4cf3c]

        tdf#130857 qt weld: Actually paint custom bg color
        
        Call QWidget::setAutoFillBackground(true) [1] so
        that the color set for the widget background is
        actually automatically filled with the color that was set.
        
        Stop setting a custom role for the background role.
        Instead, set the custom color for the role that
        is already set as the background role.
        
        Make sure to run in the main thread.
        
        With this in place, the "warningmsg" label in
        the "Security Level" tab
        (xmlsecurity/uiconfig/ui/securitylevelpage.ui)
        of the macro security dialog now actually shows with
        the background color that gets set in
        MacroSecurityLevelTP::SetWarningLabel in a WIP
        branch where support for that dialog is declared
        in QtInstanceBuilder.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#autoFillBackground-prop
        
        Change-Id: Ib09ef25ee8d7b84fb8287f9b7abb25459a708be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180611
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [f3ac98295b859e2664279bfb6966ce5caabf2cc4]

        tdf#130857 qt weld: Implement QtInstanceLinkButton::set_label_wrap
        
        Change-Id: I399ccf7f7949d51c3561e088afc4081823df4067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180610
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [d7fd4f2f84aba449dcd03b20ae4f295172164131]

        tdf#130857 qt weld: Introduce QtInstanceBox
        
        Introduce QtInstanceBox as the weld::Box implementation
        using native Qt widgets.
        
        weld::Box is used e.g. in the (not yet supported by
        QtInstanceBuilder) macro security dialog, which however
        doesn't make use of any weld::Box-specific API
        (only uses the weld::Container API), so leave
        implementing the logic for those for later.
        
        Change-Id: I6d3948e1282dd6178a3762c235bd8fc97c6e9e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180609
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-23  Noel Grandin  <noelgrandin@gmail.com>  [18df81e1568f4944a8fd79fd81e85d263dc0325b]

        Revert "ScanlineDirection is unnecessary"
        
        This reverts
          commit a525438eb62f59801899c5ea45e451963b2ec248
          Author: Noel Grandin <noelgrandin@collabora.co.uk>
          Date:   Wed Jan 22 09:50:43 2025 +0200
          fix GDI and Quartz backends
        and
          commit 828a0dcdf6fd1600baaf3103583633006a90d9f9
          Author: Noel Grandin <noel.grandin@collabora.co.uk>
          Date:   Thu Jan 16 08:23:19 2025 +0200
          ScanlineDirection is unnecessary
        
        because macOS uses bottom-up coordinate system, and I could not
        find a way to make the bitmaps stored top-down.
        
        Change-Id: Idc05b7473eca5fae0e33d634117de810146da3b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-23  Simon Chenery  <simon_chenery@yahoo.com>  [e4271c596d33b2e864e86517a15694967f05fa33]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro in fmtcol.cxx
        
        Change-Id: I78d040fcf26766d33b86ae454b31c2278b3f7584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180207
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [89c27a63a70f46ad290fc8cd34a08fae8fe94c8a]

        docthemes: Save themes def. to a file when added to ColorSets
        
        Color themes will be written to the user folder.
        
        Change-Id: I58e650550044bd35a5054a303ce41789d3d51d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180542
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-22  Jonathan Clark  <jonathan@libreoffice.org>  [1412f0235405e71aaa327596e3db71ffa999e122]

        tdf#163228 Enable vertical text options for Mongolian script
        
        Previously, vertical text direction options were enabled if and only if
        CJK language support is enabled. This change extends the logic to also
        enable vertical text direction options if the CTL language is set to
        Mongolian Mongolian.
        
        Change-Id: I4e3738b4dea755c26c786cc233aff8786146e90b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180604
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-01-22  Simon Chenery  <simon_chenery@yahoo.com>  [4bad8cb5fd321b10ad648ea1674a9f790c5aef1a]

        tdf#153109 Use any_of to check for match in gciterator.cxx
        
        Change-Id: Ieadc725272dbab7a4e5e04abb4682879051e6d16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180247
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f8a15382610e5d537d2e0fb338fffe33f8f4c09]

        tdf#150880: Add support for WRAPROWS function
        
        Change-Id: I44341835403c068a61cfb79185aeabe6daf32f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180598
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-22  Christopher Sherlock  <chris.sherlock79@gmail.com>  [f8bf05b294102bbc5dc4b4763cd2288de781288a]

        vcl: don't initialize variable and then immediately clobber it in for loop
        
        As pointed out by Mike Kaganski in
        https://gerrit.libreoffice.org/c/core/+/177805 we are setting the loop
        counter to 0 and then immediately reinitializing it to 1 in the for
        loop.
        
        As this is not necessary, just declaring the variable initially without
        initializing it.
        
        Change-Id: Ia91cd6c46a62786dc14c459f1b44daecd758ec90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180567
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b4a929615d7cb414cb0db58ed8bded9a071b349b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 52a90697abc6127f1c9210002cd42280025fa9f4
          - Update and fix xapian search in online help pages
            
            + Adjust div's in grid after changes in default.css
            + Removed language dropdown
            + Add link to bookshelf on bottom
            + Removed index based on bookmarks-value
            + Removed scripts and css not used (prism, index-related)
            
            Change-Id: Ic1ebcfb35650ecb8a5beec81eec7ce31fa5a9d1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180599
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [045b26df5790fc759b4fa6aa77cb6b10032d6383]

        Drop unused 'using namespace'
        
        Change-Id: Ieae92ec95fee8d506fde9b21ac6551e83bd2750c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180594
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f877f7e88663657587561e65f7f46a9f5f4421fb]

        docthemes: Load document themes def. files into ColorSets
        
        This is then used in Theme dialog to show which themes are
        available. Also add the existing hardcoded themes as theme def.
        files.
        
        Change-Id: I230bc84ae70f22b558aa31053339d602d04885bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180541
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [31b601d8fc2afa73fb0afd9c1d58ad488aa038cf]

        tdf#160196 add /AF entry to catalog, enable assoc. files in PDF/A-3
        
        PDF 2.0 introduced "associated files" entry. Add the association
        for the attached files to the /Catalog (/AF entry) and make sure
        the /AFRelationship is set to /Source.
        
        Also enable this for PDF/A-3 (where this was apparently added),
        as this is required.
        
        Change-Id: I5d0048daeb6e78534cef8ceb467f6dd2627a53ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180566
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [001397c7463f7591811beeb9d03f637f2447ed3f]

        QuickLook Preview/Thumbnail need to have the hardened runtime enabled
        
        otherwise the packages fail Apple's notarization
        
        Change-Id: I39877bb2b79d3e53103c44980730aaeaef8b9647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180589
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-01-22  Miklos Vajna  <vmiklos@collabora.com>  [819941bf1422f40e9346eba61d75e0fda3d24275]

        cool#10630 lok doc sign: reduce the default size of the signature line
        
        This is obviously somewhat subjective, but the default shape size in
        officecfg/registry/schema/org/openoffice/Office/Impress.xcs,
        DefaultObjectSize is 8x5cm, and I find myself always reduring the
        inserted signature line when I test it on a few sample PDF files where
        others left some space for a signature.
        
        Improve this by going with the half of the default in case of signature
        lines, so people typically need to only move the inserted shape, not
        resize it.
        
        The need to only move it is especially helpful as our resize would not
        keep aspect ratio by default and only few users will know they need to
        hold ctrl-shift while resizing to do proportional resize.
        
        Change-Id: Ieaad56601be8277b39a5403e3c3f2e6ed1fd1c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180587
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb6653ced44bd6cc96b10242e24bae3d8fd7e83a]

        language-subtag-registry: upgrade to 2025-01-21
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2025-01-21.tar.bz2 data/language-subtag-registry
        
        Change-Id: Ia1da48d2e0705413c47368263d57b4df04992991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180578
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [b78733ce071576ab115a6520f0b5fa59decf6a50]

        Drop unneeded additional check
        
        The two inner blocks inside the outer 'bWidth || bHeight' condition
        check the same bWidth and bHeight, so will execute exactly the same
        way without that outer check.
        
        Change-Id: If6b4c94ab47f2495c0a69473907c541ac9ffe524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [cd3332dd1dd8e951bdd8be22d78a4681e1d4b6c7]

        Introduce ScConditionalFormatList::Clone and use it to simplify
        
        Potentialy could also return a unique_ptr, would need to change the
        methods where the result is passed.
        
        Change-Id: I9cbd876e446094b93e2d6f72b16aefe58327e7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180572
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [7a51400b327b94929ff51035196253341ccf9036]

        tdf#164785: make sure to not modify CF list in undo/redo
        
        Commit 21830c58f27977ca4a1dbacd2f41583c9f3ae775 added a call to
        CopyToDocument to CF undo/redo. But that could modify the CF list
        (calling its DeleteArea method, and tab's CopyConditionalFormat).
        This change prevents that by using document's AddCondFormatData
        instead of CopyToDocument.
        
        Change-Id: Ic59a6724b5cc70ef16ec1ef3b3e2674cb3cc83f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180570
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [99e09f215d694b455c7b911cc2b2dc38ee0a7a2e]

        tdf#150881: Add support for WRAPCOLS function
        
        Change-Id: Ie152a83dcb7bf16f7a92ab55fd801270658a2e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-22  Michael Weghorn  <m.weghorn@posteo.de>  [942718b8f69b4dc248508954159cc9af005ead8a]

        a11y: Update links to IA2 text/obj attr spec
        
        These are maintained in the IAccessible2 git repo
        instead of the LinuxFoundation wiki now, see
        https://github.com/LinuxA11y/IAccessible2/issues/24 .
        
        Change-Id: I39213a61ed3d0c4f24ffda98ebbd004c0479bffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180575
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-22  Michael Weghorn  <m.weghorn@posteo.de>  [a2d3c9341f177b720d7a52e70759721d3221037f]

        tdf#164795 a11y: Report first line indent via IAccessible2
        
        Translate the UNO "ParaFirstLineIndent" attribute
        to the corresponding IAccessible "text-indent" object
        attribute that is mentioned in the IAccessible2 object
        attributes spec [1] which references the CSS spec [2]
        that says:
        
        > This property specifies the indentation of the first line
        > of text in a block container.
        
        Use a value in millimetres as the IAccessible2 object attr
        spec [1] says:
        
        > This value should be specified in mm, e.g. 4mm.
        
        With this in place, querying object attributes of
        the Writer paragraph that has a first line indent of 1 cm
        in attachment 198672 from tdf#164795 now gives this
        in NVDA's Python console:
        
            >>> focus.IAccessibleObject.attributes
            'text-align:left;text-indent:10mm;'
        
        (Reporting of "text-align:left;" was already implemented
        before, "text-indent:10mm;" is newly implemented by
        this commit.)
        
        In order for NVDA to actually speak the first line indent
        when requesting announcement for text attributes (via NVDA+F),
        handling of the "text-indent" attribute will have to be
        implemented in NVDA as well.
        
        [1] https://github.com/LinuxA11y/IAccessible2/blob/master/spec/objectattributes.md
        [2] https://www.w3.org/TR/CSS2/text.html#propdef-text-indent
        
        Change-Id: Id6db1ec832a21f63b6e2d7e99386ddc2453ed24f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-22  Heiko Tietze  <tietze.heiko@gmail.com>  [35487636dad444773f543db52db32abd4e490aa7]

        More flexible query dialog
        
        Modifies and reverts a52bc9b5d6f86b6919931db21d83834d6c14e955
        and 8b84691d5e2c02429c53fe9a8dc2f20e39a9d35c
        
        Prerequiste for tdf#164586
        
        Change-Id: If35a94ce25c634a6d583aeb8188d2f9ed75bc0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180547
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1103b0bd28bb244386106c1561a8bc6022b4096c]

        Also use Any <<= Color
        
        ...following up on b3d5a3d7a79715464cc221f5b0e5489b3c2b250e "tdf#75280: Convert
        sal_uIntPtr use to operator >>= Color."
        
        Change-Id: Ib1a4c311e083ce900ce527477fec355f62503571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180573
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-22  Noel Grandin  <noelgrandin@collabora.co.uk>  [a525438eb62f59801899c5ea45e451963b2ec248]

        fix GDI and Quartz backends
        
        regression from
            commit 828a0dcdf6fd1600baaf3103583633006a90d9f9
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jan 16 08:23:19 2025 +0200
            ScanlineDirection is unnecessary
        
        Change-Id: I5bc9dc8fc1ad74fb75a2656a97f5c994e9be5bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-22  Attila Szűcs  <attila.szucs@collabora.com>  [a02cbda34e8ea3d0e3d29e6e5dcafe0ec0c982d9]

        LOK: added .uno:UndoCount and .uno:RedoCount
        
        Added new commands for doc_getCommandValues
        to get actual undo and redo count.
        
        They get undo/redo count directly from SfxUndoManager.
        
        Change-Id: I2f7b7fc487eada7c5b1b161dfd4086c54094d747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180553
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d23c5560c13fc10ef367ae1d3bbf6c790dde2a61]

        tdf#160196 add support for PDF/UA-2 and NS for struct. elem.
        
        This adds support for PDF/UA-2 which is used when using PDF 2.0
        (and PDF/UA-1 when using PDF 1.x).
        
        PDF/UA-2 requires that the PDF 2.0 introduced namespaces are set
        for the structure elements, so this also adds support for the
        namespaces with always setting the PDF 2.0 namespace for all the
        structured elements (we don't use others anyway).
        
        Change-Id: Ifbd8f8126d9bcc0d4dcd06a5f56bacdb0804adbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180565
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88906ae23dbe3d8649e459089e9e28b80b758e01]

        add loading libmswordlo.so to lok_preload_hook
        
        similar to libscfiltlo.so in calc's lok_preload_hook so the module is
        loaded before any chroot might leave the original libs unavailable to
        find.
        
        Change-Id: I94e88dcd488ba15dc7781078796930e10f32b45c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180560
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-22  Marc Mondesir  <timepilot3000@gmail.com>  [b3d5a3d7a79715464cc221f5b0e5489b3c2b250e]

        tdf#75280: Convert sal_uIntPtr use to operator >>= Color.
        
        Replace casts to sal_uIntPtr, then to other types with operator >>= Color.
        
        Change-Id: Ib30370da83f3f653f8c5816e4d88cc5381ae648b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [35a61e79b2515f4a4b41215b643f0b3d2a873d50]

        extend XmlWalker test
        
        Change-Id: Id46605dac8e9033a776e84e6533768ebcf339bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180551
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-22  Michael Weghorn  <m.weghorn@posteo.de>  [b3076a0016b4fd33be35b61381800ce5591682b4]

        tdf#130857 qt weld: Support ScrolledWindow page size
        
        IIUC, the "page size" (other than the "page increment")
        refers to the size of the widget shown in the scroll area.
        
        Therefore, get/set the width/height of the QScrollArea's widget
        when getting/setting the page size.
        
        As the QScrollArea::widgetResizable doc [1] says:
        
        > Regardless of this property, you can programmatically resize the
        > widget using widget()->resize(), and the scroll area will automatically
        > adjust itself to the new size.
        
        [1] https://doc.qt.io/qt-6/qscrollarea.html#widgetResizable-prop
        
        Change-Id: Ibe90c0228bdc3a2c1ba311a9c9c88fa83d1389b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180564
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-22  Michael Weghorn  <m.weghorn@posteo.de>  [4108d5ff7b1e1ce00a96ced566f9afb5c4fa27eb]

        tdf#130857 qt weld: Support custom MenuButton popover
        
        Like GtkMenuButton [1], weld::MenuButton doesn't
        only support showing a menu, but also a custom
        popover/widget.
        
        This widget can be set via weld::MenuButton::set_popover.
        Implement that for QtInstanceMenuButton and adjust the
        logic to use either that popover (if set) or a menu
        set for the underlying QToolButton.
        
        Manually trigger either showing the popover or the menu
        in a slot connected to the QToolButton::clicked signal.
        
        One dialog using menu buttons with custom popovers
        is the one that can be triggered in Writer via "Format" -> "Theme",
        then clicking the "Add" button in that dialog.
        (That dialog isn't supported by QtInstanceBuilder yet,
        however, just seen that while experimenting.)
        
        Change-Id: I9a5924a5ed8c5b8b39050849fe609188559c479c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180561
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [21830c58f27977ca4a1dbacd2f41583c9f3ae775]

        tdf#164785: restore saving/reapplying of CF keys in cells
        
        Commit c492de66a077f3a2a960209b0b8b278b3901f361 (tdf#160149: save and
        restore the whole set of tab's conditional formats, 2024-03-17) had
        replaced copying of the affected cell ranges (including respective CF)
        with copying of the whole CF list. That allowed to replace the list as
        a whole, and be sure that it is in the same state as before the undone
        operation (not merged in any way because of re-application of CF).
        
        But the previous code made sure to set the CF keys in affected cells.
        New code didn't do that, and so, the changes to the cell attributes with
        CF keys were not cleared on undo. Applying new CF to another cell range
        created the same key that was already referenced in those old cells, so
        they behaved as if they belong to the new CF range.
        
        This change keeps the "save/restore whole CF list" idea, so tdf#160149
        is kept fixed. But additionally, it restores saving/reapplying of cell
        attributes (but not other data) in the areas affected by CF.
        
        Change-Id: I4ff844ca1345322e231df605fb019b9613a6b123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180555
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [47e110fc66292e76152252a90a0e20580c33c13d]

        tdf#162786, tdf#161947: Add support for setuptools and pip
        
        For that, just unzip the wheel files to the Lib directory
        
        Change-Id: I3998e427aeadb840b626ebbb6ce91938de47d2b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180271
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-21  Jonathan Clark  <jonathan@libreoffice.org>  [698698633806a95490c0ce4d46f763bbdd4ee358]

        tdf#163227 Add Mongolian {mn-Mong-MN} locale data
        
        Adds provisional locale for Mongolian script, derived from mn-Cyrl-MN.
        
        This locale data will likely need refinement. In particular, traditional
        Mongolian date formats are not implemented due to insufficient data.
        
        Change-Id: I56a9e4cac1b26b4588c5a7327c56991ec91f033d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180552
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-01-21  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [e0a6771a1c7e7ae662982c705ef28b59f815fe60]

        tdf#164403 CairoSDPR: Solve Cairo's 24.8 coordinate problem
        
        Thus Cairo is offering a full-fledged double precision API but
        internally uses a 24.8 fixed-float format (see https://gitlab.
        freedesktop.org/cairo/cairo/-/issues/252, thanks Caolan for
        finding that). This seems to be the case for linux and windows
        implementations. Due to the API being on double precision this
        is an implementation detail, but it has to be taken into
        account when using cairo. It is not officially documented what
        is a shame - it should be somewhere in the readmes/
        documentation at a prominent place.
        
        24.8 means coordinates are limited to +/- 2^23 (usually minus
        one) and [0/256 .. 255/256] places after comma. This is
        unfortunately not limited to the view coordinates - that
        would be acceptable, discrete/pixel areas of that size should
        be fine, BUT used with transformations. Thus when having any
        coordinates beyond that limit - and with double precision and
        transformations we have that here - cairo just 'cuts' the
        coordinates to it's min/max 24.8 format. This is not acceptable
        for e.g. a cad system, and even leads to problems in something
        like an office suite as we see. It implies that using cairo in
        a safe way means to basically use linear algebra yourself in
        your app and use cairo only without transformations and with
        discrete view coordinates (pixels). AND to know about that
        limitation in the 1st place ...
        
        Well, cairo works well and that problem happens until now
        in one place in writer below page 490. Let's be pragmatic.
        Key is to *detect* the situation. Always doing own
        transformations is possible, but not nice: I *could* always
        transform the polygon to screen coordinates, but that will
        kill the PolyPolygon buffering mechanism (in chart we have
        PolyPolygons with 80.000 entries :-); These are held in
        cairo_path_t form at the original PolyPolygon to not need
        to transform them every time, but let Cairo do that. The
        idea is that when Cairo impl may use HW on the system to
        do that (HW can do that nowadays) while rendering the
        PolyPolygon from the object model would have to be
        converted just once to Cairo form and used multiple times...
        
        Cairo *should* be fair, document this and allow you to test/
        ask if this limit exists in the version you are using, but
        it does not. Thus I suppose to detect that situation as
        'cheap' as possible and react to it - e.g. in writer when
        below page 490. But not only - it might be possibe to
        construct draw/impress pages (free definable) that also reach
        that limit.
        
        With detecting as cheap as possible I mean: Naturally you
        would start to test your geometry to be painted if it is
        overlapping or outside that range defined by 24.8, but
        that would already involve transforming all geometry by
        world and view transformations. I think it should be okay
        to just take the target area (starting at 0,0 and having a
        size in pixels) and transforming that back to logical world
        coordinates. Then this needs to be checked only if view
        transformation changes, not object transformation. Usually
        view transformation is setup and all/many objects are
        painted to it using object transformations. Detection
        should then only be needed when view transform changes.
        
        Thus I added a test (see
        checkCoordinateLimitWorkaroundNeededForUsedCairo()). This
        is esecuted once per office runtime. If it detects that
        the problem is there it sets a flag. Depending on this
        the view coordinates are then transformed to logic
        coordinates and checked if these are completely inside
        the coordinate area that ciaro *can* correctly handle.
        This has to be done once per CariroSDPR since (currently)
        ViewTransformation is not changed (has to be adapted if
        this should happen one day). Based on that the single
        helpers on the renderer have to be adapted: Simplest
        is just to render using ViewCoordinates - and do
        transform object geometry using basegfx/our own stuff
        that does that correctly (with ease :-).
        
        Done that, checked, works AFAICT. What a bad surprise,
        but I can work around it...
        
        Change-Id: Ic33d6ccfe9854af396d0ac9f14c76eb25bb9e4e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180529
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-01-21  Michael Weghorn  <m.weghorn@posteo.de>  [7c04ae197204f99a5756a8572253e7c8a9936e0a]

        Drop unnecessary DBG_ASSERT
        
        With the
        
            if( mvTabList.empty() )
                return;
        
        above, this is unnecessary, while there was probably
        more potential do have inconsistencies before
        
            commit 39c7e09ca5cb9b6dab143483bd6cb72fcad8307e
            Date:   Wed Apr 25 12:37:18 2018 +0200
        
                loplugin:useuniqueptr in SvTabListBox
        
        Change-Id: I775fef9b9c04c32eaa7dbdb4ff68e5e8d0e5dd90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180538
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-21  Michael Weghorn  <m.weghorn@posteo.de>  [238cc5d5a52ec9640da21e0c2f04ea660ff23495]

        vcl: Pass vector to SvTabListBox::SetTabs
        
        ... instead of passing an array and the number of
        elements as two separate params.
        
        Change-Id: If4d4e6db0f2db62ff155a29867baab495e326274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180537
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-21  Jaume Pujantell  <jaume.pujantell@collabora.com>  [bd5d39b307dbd31a77e4ea5e267275af8184aa35]

        sd: de-duplicate masters on save to pptx follow-up
        
        After commit 2d9c808d1952c18daa007b41e70fc7e63f6c5712 "sd: de-duplicate
        slide masters on save to pptx", there was some loss of data on save
        since when saving only the layouts for de-duplicated masters, not enough
        of the shape tree was being saved.
        
        Ideally we may want a clever algorithm that best separates the shape
        tree between master and layout, but just saving all the shape tree on
        the layout files when de-duplicating masters also works.
        
        Change-Id: I8b932708ef9212a4d5034713066299065083da8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179861
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3c8c537b3cfc4cf812e8728f6e6e46c0596ba7f6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180546
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-01-21  Oliver Specht  <oliver.specht@cib.de>  [5337205fdc3917760008dac77f1d0f5c4d55fef7]

        tdf#105083 Support status of numbering and bullet list
        
        Shows the status of bullet/numbering in the current text selection
        in the toolbar buttons ToggleUnorder/OrderedList.
        
        Change-Id: I458896293c502da8142ad9cb43b5ea62a9f3b558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180238
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-21  Oliver Specht  <oliver.specht@cib.de>  [530f51fd27127c614320bda06d25bcd70f29de99]

        tdf#160621 Variable field dialog size of value field
        
        The size of the value field is now set to 6 rows.
        
        Change-Id: I298a0dfc5c61c18a170b2e8f7a700dab17b5ee66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180173
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-21  Jaume Pujantell  <jaume.pujantell@collabora.com>  [9205b4eb09dcb4c91539e092db521154fc4e9523]

        sd: de-duplicate slide masters on save to pptx
        
        pptx files have layouts separated from masters, so multiple layouts can
        reference the same master. On import that master is duplicated for each
        layout. So we want that if it is saved without modification, the created
        file contains the same number of masters and layouts as the original
        pptx file.
        
        The commit d590f094ccd28ca449eff91692c2178058d5c621 "tdf#155512: sd:
        filter: eppt: add "SlideLayout" property to Slide Master" tried to do
        this but saved too many layouts, which appeared as extra masters on
        reload. The commit bff76421e234df7246a7f49c71a11432f86e09d1 "tdf#157740
        FILESAVE PPTX: fix explosion of the number of master slides" fixed the
        issue of extra layouts but removed the de-duplication of masters.
        
        This commit avoids saving duplicated masters while keeping the correct
        saving of layouts.
        
        testTdf157740_slideMasters now checks for the correct number of masters
        and layouts.
        
        Change-Id: I199c55abe59d39c64e1e3e1fbd620e88f4f7290d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178669
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 2d9c808d1952c18daa007b41e70fc7e63f6c5712)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180539
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-01-21  Oliver Specht  <oliver.specht@cib.de>  [60b64338c2a1236cdc98f3834cc77fc3006fc241]

        tdf#117946 Mouse zoom support added to slide sorter
        
        Change-Id: I3d532f14f25d31a90971ace262ddf88df3c33eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180020
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-21  Oliver Specht  <oliver.specht@cib.de>  [47bf215cc7693bde89143f63b88556c61a68a132]

        tdf#50743 tdf#37507 Improve scrolling while selecting
        
        If the mouse leaves the document window scrolling of selections
        happens now in smaller steps so the user is able to stop at the
        intended position easier.
        
        Change-Id: Ifd21c92936021f8e2213d34446672e2a8eab568f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178724
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [72beaf19974e71abb5f3e9ef99dc7455b6323899]

        vscode-ide: use windows-style paths and Git Bash in wsl-as-helper case
        
        This way automatic creation of a terminal for the build-tasks uses
        git-bash and also the paths to the executable can be found.
        
        Change-Id: I4871dc13e467927be3d82f1129fb39aa8d6925d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180512
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-01-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [206ac992eb4eefc19313c1775e3e76975c7abc5e]

        wsl-as-helper: avoid misdetecting builddir!=srcdir with long paths
        
        when the user runs wsl.exe ./autogen.sh in a long path, the build
        initially works OK, it will realize that the build is performed in the
        source directory.
        However if another run of wsl.exe ./autogen.sh is triggered by running
        make (i.e. when configure.ac or some of the other files gets changed),
        it was run with the shortened version of the path as the value for
        SRCDIR, and comparing that with the pathname of the current directory
        (which most likely was browsed to by using the long form) resulted in a
        misdetection of the builddir != srcdir case, and autogen.sh did try to
        create the necessary symlinks and <module>/Makefile and
        external/*/Makefile files as if building in a separate build directory.
        Especially the self-referencing symlink in the include dir then caused
        some parts of the build (skia) to fail.
        
        To avoid this problem, explicitly convert the path to its long-form.
        This alone is not enough however to prevent the same issue occuring when
        the user changed to the srcdir using the shortened form, then the
        conversion would fail the same way (and while it is unlikely that the
        user uses that path manually, launching a terminal via the
        vscode-integration for example would also use the shortened form). So
        also cd to the long form of BUILDDIR when running the automatically
        triggered autogen.sh
        
        Change-Id: I02c1ee7d302daa6062b6a049d924f40a49217e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180511
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-01-21  Miklos Vajna  <vmiklos@collabora.com>  [524c266f0f0a3cdccfa9feecfba2a19c9a29b701]

        tdf#161001 sw floattable: require in-header/footer for non-follow-text-flow
        
        Open the bugdoc, the in-body floating table has an inner floating table
        which is rendered above the outer table, not inside it.
        
        This went wrong in commit f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce
        (tdf#159453 sw floattable: fix unexpected overlap of in-header fly and
        body text, 2024-02-13), where the use-case was an in-header floating
        table interacting with body text.
        
        The more general case is in-body floating tables interacting with
        in-body text, so fix the problem by restricting the custom
        IsFollowingTextFlow=false property for in-header floating tables.
        
        Change-Id: I902f232e3c840ff0279d8ed6c2329ba48a03b4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180534
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f31f6fcad2bdc38170a4c4b921d918dc10f7d0f]

        fix ubsan in UITest_manual_tests
        
        after
            commit 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
            Author: Pranam Lashkari <lpranam@collabora.com>
            Date:   Mon Dec 30 02:20:22 2024 +0530
            sc: make data validy error dialog async (invalid value error)
        
        Change-Id: I885e470c6585df038f12bf5834fba005f5a072da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-21  Noel Grandin  <noelgrandin@collabora.co.uk>  [13183013f155a2a0eef8bf2f0c1ca3f27d268ceb]

        tighten up WinSalBitmap::Create* methods
        
        One of the paths cannot be hit, so remove it.
        Add asserts in other places to catch conditions that
        should not happen.
        
        Change-Id: I401a0ffea2587d8bbcb313edef06e766d65c3eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180533
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9e4419dcb9f30f46ba9cc2db62e8a2859c075c29]

        cid#1465236 Uncaught exception
        
        and drop coverity workarounds
        
        Change-Id: If9ffc607999285b2f5b63e85c51b0289fb05750f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180531
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9723eab349aae681e2680b0bf1854bf5a55e2589]

        cid#1641353 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9037272d4f6ff2e2008d6e13e8021551e5cab1af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180530
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-21  Jean-Pierre Ledure  <jp@ledure.be>  [ca1dca4f1df7ba4b0b74e4a378169c8f8cf690d0]

        ScriptForge (ContextMenu) new RemoveAllItems() method
        
        The contextmenu service handles the context
        menus stored in a document. So far, it
        provided only the AddItem() method to add
        new items at the bottom of the menu.
        
        The new method allows to forget the preconfigured
        menu and to replace it completely.
        
        Example: associate next Sub with the
                 on-right-click event of sheet 'Sheet1'
                 => The custom menu appears when
                    right-clicking in column C, otherwise
                    normal behaviour
          Sub OnRightClick1(Optional XRange)
               ' Xrange is a com.sun.star.table.XCellRange
          Dim calc, menu, bColumn
          Set calc = CreateScriptService("Calc", ThisComponent)
          Set menu = calc.ContextMenus("cell")
          menu.RemoveAllItems()
          bColumn =  ( Len(calc.Intersect("Sheet1.$C:$C", _
                     XRange.AbsoluteName)) > 0 )
          If bColumn Then
              menu.AddItem("A", Script := "vnd.sun.star.script:...&location=document")
              ...
          End If
          menu.Activate(bColumn)
          End Sub
        
        The function is available both for Basic and Python user scripts.
        The user documentation will have to be reviewed.
        
        Change-Id: I84ee8724bf99c37397a19d729133cc4686a63980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180520
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-21  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [3e706aa31d7d1a521710dfa544316e5d35bdf5f0]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: I0bdbb662b807c6ffc9030c4c695e5022949e172f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180254
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-21  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [9dc1faa1428cdf3e74be002bff51a1ce4823ff66]

        tdf#87605 Add new words to technical dictionary
        
        Change-Id: I88e178a31a1539ef5632c2425b0f7fdd73d344fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180478
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-21  Noel Grandin  <noelgrandin@collabora.co.uk>  [2da756e0a8877a1cfce5d7c0841ea609eae4e35e]

        avoid some casting in WinSalBitmap
        
        Change-Id: I0f18baf52131f229edb5be4bab723e954ba36cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180532
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-21  bruh  <randomforest33@gmail.com>  [744e7419e0c85a926fc4576c0def94f0248326cb]

        tdf#160084 Simplify comparison with zero when using basegfx::fTools::less
        
        Change-Id: Ide5fff5ad3ad7322fc5955eb06ad14da83451abf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180482
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-21  Noel Grandin  <noelgrandin@gmail.com>  [bb9180f0a6a7082de202eb7d4697242e7f24ec54]

        pass by reference to GoEndOfSection/GoStartOfSection
        
        instead of pointer, since we always de-ref the pointer
        
        Change-Id: I0193f77f9019fe5e57a6d56765917bb6c1f3f560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-21  Noel Grandin  <noelgrandin@gmail.com>  [5b4b4c0e691ede48f50725f4f174a0e1ac7b3668]

        dont store wrong bitcount in WinSalBitmap
        
        There is no point in lying to ourselves and saving a different bitcount
        from the one that is actually reported.
        This code dates back to "initial import" so no idea why it tries
        to do this.
        
        Change-Id: Ia5a88d28c85436b67b0225dbc81d83e74a1d3218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180524
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-21  Justin Luth  <jluth@mail.com>  [f1bdc5b77406fadb97c9a54f0a06d5cafbdf0371]

        remove assert looking for new compatibilityMode DOCX
        
        Sadly, there is a document in our crash-testing corpus
        that says version 16 (last edited by LO 6.3.5 in 2020...)
        which is certainly a bogus value in this case.
        
        Change-Id: I55c6c7085151fb1acaab036f01ed44cf317c42f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180527
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-01-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f1f715fa01157696287ef81191b8f1354a7324ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5bac4054249848f5d28b225507149f8107ebeaca
          - tdf#164180 Print option for "custom pages per sheet"
            
            Change-Id: I237f66609549214568c2c79330351ce64c254ec3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180522
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-20  Mike Kaganski  <mike.kaganski@collabora.com>  [26246b2fb202e1fe8045dd69ff771588a845764a]

        Simplify a bit
        
        No need to skip the loop explicitly when there's no element in the container.
        No need to take integers (the elements in the container) by reference.
        
        Change-Id: I15f7ccdeaafaa5a766ae36b31e49f41daebf86b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180518
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-20  Miklos Vajna  <vmiklos@collabora.com>  [76e0a520d6beb118dd6437889fbe16d2a94c941c]

        cool#10630 doc electronic sign: unselect & reject reselect
        
        Insert a signature line, move/resize the selected shape, finish signing,
        the signature line is still selected and you can still move/resize it.
        
        This was working for the desktop visual signing which
        SfxViewShell::GetSignPDFCertificate() returned an XCertificate, but not
        for electronic signing, which is a separate branch in
        SfxObjectShell::ExecFile_Impl().
        
        Fix the problem by deselecting the shape even in the desktop case and
        the moving this cleanup code to a new ResetSignatureSelection() and
        calling that in the electronic sign case, too.
        
        SdrMarkView::UnmarkAllObj() is private to sfx2/, so go via UNO to do the
        same.
        
        Change-Id: I52c89c4aea0203f8624bd801a900186211541dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180508
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-20  Noel Grandin  <noelgrandin@gmail.com>  [4c6316ef441a2013cf92ed81436ad569d6ebe44a]

        fnNds is dead
        
        ever since
          commit f761e0aee58fe152b69daaa0e4b9697ad4f0e038
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Tue Oct 11 10:45:31 2022 +0200
          use more SwPosition::Assign
        
        Change-Id: I4eadbf3cc7dfb8cba6fb778e551cf016355ac337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180481
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-20  Noel Grandin  <noelgrandin@gmail.com>  [f60995e97f50152aca57305a0f13e708265186a6]

        pass param by reference in GoNext/GoPrevious
        
        to enforce that they are never nullptr
        
        Change-Id: I973dcc143b5334c3060a0f815474e569deae4c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180459
        Tested-by: Jenkins
        Reviewed-by: Ashod Nakashian <ash@collabora.com>

2025-01-20  Szymon Kłos  <szymon.klos@collabora.com>  [d09ca3730a20341a0abf2c07b7a3d1cbac1bf90c]

        jsdialog: scroll to row before use
        
        If we first select lat row, then try to select some top row
        in LOK -> we will not get correct result for popup menu
        as the coordinates will be negative and we will also fail
        on assertion. We need to scroll row to be visible first
        
        Change-Id: Ib8a76eff093817fe7e3a777aa8cecf1246fae25f
        (cherry picked from commit 62b81789a7c16925c4b15692e40b1da6badb73d1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180509
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2025-01-20  Mike Kaganski  <mike.kaganski@collabora.com>  [9916469fa9ff48340cfe317269f259b50e4ecd21]

        tdf#164722: fix the "contains conditional format" condition
        
        In commit a06a44c3b342648139e7fa0ff850a4176df60538 (one more fix for
        fdo#58686, 2012-12-25), the code was adjusted for possible nullptrs
        in the conditional format list. The new bContainsExistingCondFormat
        variable meant "there is at least one non-nullptr element in list",
        and was used as a condition for deciding which dialog to show (and
        the pre-existing bContainsCondFormat variable was used to decide if
        iterating the list is necessary).
        
        But the two similar variables resulted in confusion; eventually, in
        commit 2b5915da481990fd6ea272104215d82b6fbf5dbb (tdf#60573 Conditional
        formatting does not allow scrolling, 2015-05-12), bContainsCondFormat
        was misused in a condition to show the dialog.
        
        Commit c492de66a077f3a2a960209b0b8b278b3901f361 (tdf#160149: save
        and restore the whole set of tab's conditional formats, 2024-03-17),
        nullptrs became possible in one more scenario (which is OK), but
        that uncovered the wrong variable use here.
        
        To avoid further confusion, merge the two variables into one, i.e.
        update bContainsCondFormat in the loop over the list - so that we
        only have one "contains conditional format" variable with up-to-date
        information.
        
        Change-Id: I567dc97551fba748bf6f2242d4650442f4753cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180507
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-20  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0e01a536d8173270d6a4545a861c2b0b1ba4db17]

        tdf#164622 - SVG: fix broken cropped svg files at metafile export
        
        For creating metafile, there mask polygon from MaskPrimitive2D needs to be closed.
        Otherwise later during the metafile export the we will skipp the rendering of the
        last points of the polylines.
        
        SVG clipping paths: "A clipping path is a set of closed vector path that may consist
        of an arbitrary number of straight and curved segments."
        
        Change-Id: I21487a81b904ec7ec5c6bd2a89b7539aeb86d606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180278
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-01-20  Aron Budea  <aron.budea@collabora.com>  [1552102dd32cfa76a8b5b5c083be8921871941af]

        LOK: Use OOXML 2010+ format
        
        Change-Id: Ic2deac5602293cfcd1a1a73774dab94b2c4c970a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180458
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 6f7e5f6c26a212c3fdbff3b97522d05a5ab896cb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180500
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Tested-by: Jenkins

2025-01-20  Gökay Şatır  <gokaysatir@collabora.com>  [afb09d65d223aeecba9a9f343e71f6ce1f1535f0]

        Make checking alternative views more strict.
        
        Remove unnecessary -1 checks.
        Remove nLastNonEditorView, we don't use a view if it is in edit mode. We are more picky now.
        Don't check for alternative views when the render state is empty. It shouldn't be empty but when switching to/from other modes, it is empty.
        
        Change-Id: I2df4442d77bdddc4ce219a423f70527716245720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180498
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-20  rafaelhlima  <rafael.palma.lima@gmail.com>  [7afd95daf2224e80fe57c62f819dfb9ec4c630c9]

        tdf#164685 Cleanup SfxItemSetFixed
        
        Cleanup of class SfxItemSetFixed as described in the bug ticket.
        
        Change-Id: I0704ab45624217a8d00a942e0e8d6d6276934306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180255
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2025-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef5a350b75b8ff31dce6fa016d6ca8b920164a9f]

        tdf#164640 List bullets formatting changed
        
        revert part of
            commit 76319347a83aecee7a423a614d67287182b31b00
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Oct 21 09:26:31 2024 +0200
            set stylesheet parent at creation time
        
        Change-Id: Iabbfabc1412af54b76c0ac04d2e887a15a4cbbad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [79d6de8f878fd4fce27557739cbc37431c465e2a]

        Make Programmatic Names typesafe
        
        by creating a wrapper class, to make it obvious in the code what kind of
        name we are dealing with.
        
        The new class is in sw/inc/names.hxx
        
        Change-Id: Ifb3e598d497f098cf1fce71b87c5e0da9f8a7151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180406
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [763f500906f839f9086971eff3433e5911ea8d0d]

        Add wrongly formatted files to excludelist
        
        Change-Id: I2c7e7a6ed5ec89b9de875a4fac8cb82849acc2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180497
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-20  Michael Stahl  <michael.stahl@allotropia.de>  [f8126c5d93f2807030da20e2de39f3c72c92e7d3]

        sw: HTML import: apply hard formatting at insert position ...
        
        ... even if the paragraph style contains the same item, but with a
        different value.
        
        Surprisingly, SfxItemSet::Differentiate() doesn't actually compare if
        the items in the 2 sets have the same value, just that 2 items with the
        same WhichId exist.
        
        Also, apply paragraph attributes, except list and breaks and other ones.
        
        (follow-up to commit f45d2fa85ba89eb7d71b51c3324f5938509b3201)
        
        Change-Id: I1e11705f63c1f059e2f5baa658238f2d62f6c66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180422
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-20  Miklos Vajna  <vmiklos@collabora.com>  [6e781525c4781e1b62dfd03f0352a82386c94019]

        svx: prefix members of SdrVirtObj
        
        See tdf#94879 for motivation.
        
        Change-Id: I58815855425a02c18fbc59b4c002b9bc128955e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180495
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [340f0965e6ffef318304ba8a7a1a7f10bb2548fe]

        vcl: move variables closer to first use in BitmapColorizeFilter
        
        Change-Id: I3f08511689a2118713f2b75436459501e51ed893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173702
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [277cd55361980b68597ad7eb7ffd1afce9e1c382]

        __coverity_tainted_data_sanitize__ is deprecated
        
        Change-Id: I333fa67d7f9a8369405c39873760bba1ae2a2c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180491
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fcd60a02137f7669fabb8841503e6ad5cdbd00a8]

        drop coverity std::optional workaround
        
        Change-Id: Ie1b61fc4a8a8219e9ba3d4c8f77c27b8c725407e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e62220a58461499b1e22530fa8a7e931425958c]

        drop coverity workaround
        
        Change-Id: I6085b9af2cc16114f61ba06fdeece601add50885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5db33f380b1f163ee39f345ac0c289b766a431fd]

        tidy lambda captures
        
        Change-Id: Ifb0a815cdf93e18a5ad10ef4cfb2b772f5032df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180488
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f107b0fac3f4b4ba5c573aac68cb459c347af3f9]

        cid#1399255 Uncaught exception
        
        and
        
        cid#1399255 Uncaught exception
        
        Change-Id: I4a8d416ad5acd8bac747cc764ebd3d4cc749ce0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-20  Michael Weghorn  <m.weghorn@posteo.de>  [9b08d9c366a4e7cfcf0e2f4b566f9f92e5c0eb73]

        cpdb: Don't use possibly deleted PPDKey
        
        The PPDParser ctor taking a const `std::vector<PPDKey*>&`
        param calls PPDParser::insertKey for each of the inserted
        keys, which does
        
            m_aKeys[ pKey->getKey() ] = std::move(pKey);
        
        for the std::unique_ptr `pKey` that owns the
        PPDKey. If multiple keys use the same OUString PPDKey::m_aKey,
        that means that reassigning `m_aKeys[pKey->getKey()]` will
        result in the std::unique_ptr that was previously assigned to
        be deleted, i.e. the pointer in the vector that was passed
        to the ctor also becomes invalid.
        
        Therefore, don't use the `keys` variable any more
        after passing it to the ctor in CPDManager::createCPDParser.
        
        Instead, use an explicit std::map to maintain a mapping
        of the OUString key that identifies the PPDKey and the
        OUString that can be used to retrieve its PPDValue and
        iterate over that map instead of the (potentially invalid)
        vector after creating the PPDParser.
        
        This should fix the crash seen with the WIP CPDB change
        as mentioned in [1], once that change has been rebased
        onto this commit.
        
        Without this, a PPDKey* element in `keys` was seen to
        point to invalid data when debugging, after the PPDParser
        ctor was called.
        
        This was with a dummy printer for which a
        "Brother DCP-9020CDW for CUPS" PPD was assigned
        and cpdb-text-frontend would print these translations
        (relevant 2 that are mapped to the same translation
        and would therefore be mapped to a PPDValue using
        the same `m_aKey` with [1] are marked with an arrow):
        
            > get-all-translations dummy-brother-dcp9020cdw CUPS
            'OPT#print-scaling#auto' : 'Automatic'
            'OPT#print-quality' : 'Print Quality'
            'GRP#Color' : 'Color'
            'OPT#multiple-document-handling' : 'Multiple Document Handling'
            'OPT#job-sheets#standard' : 'Standard'
        ->  'OPT#finishings-col' : 'Finishings'
            'OPT#output-bin#face-down' : 'Face Down'
            'OPT#job-hold-until#indefinite' : 'Released'
            'OPT#page-ranges' : 'Page Ranges'
            'OPT#sides#one-sided' : 'Off'
            'OPT#job-hold-until#day-time' : 'Daytime'
            'OPT#job-hold-until#night' : 'Night'
            'OPT#print-color-mode' : 'Print Color Mode'
            'OPT#job-hold-until#no-hold' : 'No Hold'
            'OPT#job-hold-until#weekend' : 'Weekend'
            'OPT#printer-resolution' : 'Print Resolution'
            'OPT#print-color-mode#color' : 'Color'
            'OPT#job-sheets#none' : 'None'
            'GRP#Scaling' : 'Scaling'
            'OPT#multiple-document-handling#separate-documents-uncollated-copies' : 'Separate Documents Uncollated Copies'
            'GRP#Ouput Quality' : 'Ouput Quality'
            'OPT#print-scaling' : 'Print Scaling'
            'OPT#job-name' : 'Title'
            'OPT#orientation-requested#5' : 'Reverse Landscape'
            'GRP#Page Management' : 'Page Management'
            'OPT#print-quality#4' : 'Normal'
            'OPT#job-hold-until#evening' : 'Evening'
            'OPT#copies' : 'Copies'
            'OPT#number-up' : 'Number-Up'
            'OPT#orientation-requested#6' : 'Reverse Portrait'
            'OPT#media-source' : 'Media Source'
            'OPT#media-type' : 'Media Type'
            'OPT#print-scaling#fit' : 'Fit'
            'OPT#print-scaling#fill' : 'Fill'
            'OPT#job-priority' : 'Job Priority'
            'OPT#print-scaling#auto-fit' : 'Auto-fit'
            'GRP#Copies' : 'Copies'
            'OPT#print-scaling#none' : 'None'
            'OPT#page-delivery' : 'Page Delivery'
            'OPT#orientation-requested' : 'Orientation'
            'OPT#job-hold-until' : 'Hold Until'
            'OPT#sides' : '2-Sided Printing'
            'OPT#print-color-mode#monochrome' : 'Monochrome'
            'OPT#job-hold-until#second-shift' : 'Second Shift'
            'OPT#job-hold-until#third-shift' : 'Third Shift'
            'OPT#job-sheets' : 'Banner Page'
            'GRP#Job Management' : 'Job Management'
            'OPT#sides#two-sided-long-edge' : 'On (Portrait)'
        ->  'OPT#finishings' : 'Finishings'
            'GRP#Finishings' : 'Finishings'
            'OPT#output-bin' : 'Output Tray'
            'OPT#sides#two-sided-short-edge' : 'On (Landscape)'
            'OPT#multiple-document-handling#separate-documents-collated-copies' : 'Separate Documents Collated Copies'
            'GRP#Media' : 'Media'
            'OPT#orientation-requested#4' : 'Landscape'
            'OPT#orientation-requested#3' : 'Portrait'
        
        The fact that 2 different CUPS/IPP options are currently
        not mapped to `PPDKey`s with different string keys
        in the current version of the Gerrit change [1]
        when the (CUPS-provided) translation is the same for
        both options might still be problematic when it comes to supporting
        all PPD/IPP options, but that's a different story.
        
        [1] https://gerrit.libreoffice.org/c/core/+/169617/comments/a7d83fb1_ea8dd50e
        
        Change-Id: I7c48f03c752f458c55f516340f2c0a48d7305ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180083
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a8e0de1b5d6dfc03a9fc4ed13cb7ec8a691a6772]

        doctheme: add LibreOffice theme file to LO share folder
        
        Change-Id: Ifa38b69739d82d1f2efdfca58a2e0d6f9ff69008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180416
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [24754a9270dcb8b26b9e772b849eed6e3ecb42dc]

        doctheme: Add document themes folder as a config. path
        
        Currently the document themes are hardcoded and the new ones will
        be only used in the current document. This is the first of the
        series to make document theme user defined and stored in the user
        and shared folders (just like other resources). This change adds
        the configuration of the folder which will be used to search for
        the document themes. By default the folders are located in the user
        and shared profile folders.
        
        Change-Id: I1388983804d012cd7f8575dfc96830451821f56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180379
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b9477183bb383c7a00d5ad2c27985fbd9d22173b]

        tools: moved function to create the color from string to tools
        
        Will be needed again in a follow up commit.
        
        Change-Id: Idbe2f540f9c3fb974f7dadf62dc099a0791bb0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180378
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2990620e202eb59edce160264e25ca63ba4a93ba]

        remove code duplication - conversion hex char to value
        
        We use the same funciton all over the place, so create a common
        function in o3tl and use that in all instances where we duplicated
        the code.
        
        Change-Id: I74091fbbde8c2ba8c7e4ab30194ab53e2a338e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180372
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [b3601746facd15e6c54cb5061c77d6fbad6591cc]

        tdf#130857 qt weld: Delete unused image label object
        
        QLabel objects created for "GtkImage" objects in .ui file
        that are used to set button images are not displayed by themselves,
        so unconditionally mark them for deletion once the image data has
        been taken over to the button.
        (See also use of `aImagesToBeRemoved` in the VclBuilder
        ctor for how images used for button images are deleted there.)
        
        This is also no problem if the image is used for multiple
        buttons inside of the dialog because QtBuilder::deleteObject
        calls QObject::deleteLater, i.e. doesn't delete the object
        immediately, but schedules it for deletion once control
        returns to the event loop, so reusing it is still safe
        until then.
        
        Deleting the QLabel object only if it has no parent isn't
        sufficient, because even labels created for "GtkImage"
        objects that are top-levels within the corresponding
        dialog (or other .ui file)  still have the dialog's parent
        widget set as the parent.
        
        Without this commit, a copy paste icon would be shown
        on the left hand side of the Writer window after opening and
        closing the "Help" -> "About LibreOffice" dialog (which has a
        button that has such an icon set.
        
        Change-Id: I40aaaa1af700b4ab0adfdc7a1c04103dfcab7c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180469
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [1052f5cd508a33c4cea3a89d16f03b53ebe18b40]

        tdf#130857 qt weld: Signal when toggle button gets toggled
        
        Change-Id: Ia44a203a56a2b560a995446da2dd1c48a736bf60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180467
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [532618ae4e0f7bf8537c566421f59df473135d7d]

        tdf#130857 qt weld: Support QtInstanceToggleButton::set_inconsistent(false)
        
        While QCheckBox supports an "inconsistent" state
        (see QCheckBox::tristate), I don't see that for
        QToolButton/QAbstractButton.
        
        Therefore, keep triggering an assert when trying to
        enable the indeterminate state (and reconsider what to
        do whenever encountering that example while working
        on support for more dialogs in the future).
        
        However, explicitly *disabling* the inconsistent
        state is fine: Don't do anything in that case.
        
        This gets called by the subclass, weld::Toggleable::set_state
        when setting the toggle button to checked or unchecked.
        
        [1] https://doc.qt.io/qt-6/qcheckbox.html#tristate-prop
        
        Change-Id: I4cb1475a4b5e3295ada7ed18dcbfcbf24baa53e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180466
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [a2f7ee2f7cdf39d48879843967983c4ba9debd5c]

        tdf#130857 qt weld: Set GtkButton props for ToggleButton
        
        The GTK 3 GtkToggleButton [1] subclasses GtkButton [2].
        Therefore, let QtBuilder apply the GtkButton properties for the
        QToolButton created for a "GtkToggleButton" object in a .ui file
        as well.
        
        This e.g. ensures that the icons for the toggle buttons in the
        "File" -> "Templates" -> "Manage Templates" dialog are set
        in a WIP branch where support for that dialog using native Qt
        widgets is declared.
        
        [1] https://docs.gtk.org/gtk3/class.ToggleButton.html
        [2] https://docs.gtk.org/gtk3/class.Button.html
        
        Change-Id: I1efedea116a799b8bc41fa81a27585af65893220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180465
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [58544c8fec07b151bb74094e1a0be8b965caf1e9]

        tdf#130857 templatedlg.ui: Don't use "pack-type end"
        
        Don't use the "pack-type" property with a value of "end"
        to reverse the order of GtkBox children, but use the
        default (of "start") and set the indices for the "packing"
        properties of the children in the usual order, which is more
        straighforward.
        
        The "pack-type" GtkBox property no longer exists in GTK 4 (see [1];
        `Convert3To4` in vcl/unx/gtk4/convert3to4.cxx currently
        has special handling for it for the "GtkBox" case to revert
        the order) and I also think it makes more sense to "normalize"
        the .ui files than implementing such a special handling in
        QtBuilder.
        
        Adjusting this in glade and resaving the .ui file also results
        in the GtkBox children to be defined in visual order, which ensures
        that the (focus) order is correct in Qt as it (by default) is based
        on the order in which widgets are created.
        
        (The "File" -> "Templates" -> "Manage Templates" dialog is not
        yet supported by QtInstanceBuilder, just noticed this while
        experimenting in a WIP branch.)
        
        [1] https://discourse.gnome.org/t/gtk4-replacement-for-pack-type/5574
        
        Change-Id: I1633fc05da68a7ccce36e17d13d0d654f4e6145b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180463
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [c6c756864dd4b052b63079fb6931ad5af0b3158f]

        tdf#130857 qt weld: Evaluate entry's placeholder text
        
        Evaluate the GtkEntry "placeholder-text" property [1]
        when processing "GtkEntry" objects in .ui files.
        
        This gets used e.g. in the (not yet supported)
        "File" -> "Templates" -> "Manage Templates" dialog
        for the "Search..." entry.
        
        [1] https://docs.gtk.org/gtk3/property.Entry.placeholder-text.html
        
        Change-Id: Ic5d85199da4511bfc6758a77079f3b4c6c2aa7bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180462
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [2172bb226ab29ff0e9ea8ebe1a498f83afb5c891]

        tdf#130857 qt weld: Set GtkButton props for MenuButton
        
        The GTK 3 GtkMenuButton [1] subclasses GtkButton [2].
        Therefore, let QtBuilder apply the GtkButton properties for the
        QToolButton created for a "GtkMenuButton" object in a .ui file as well.
        
        This e.g. ensures that the menu button in the
        "File" -> "Templates" -> "Manage Templates" dialog
        gets the "Manage" label in a WIP branch where support
        for that dialog using native Qt widgets is declared.
        
        [1] https://docs.gtk.org/gtk3/class.MenuButton.html
        [2] https://docs.gtk.org/gtk3/class.Button.html
        
        Change-Id: I3f2e7b701776476a6677d2bb324ffbdd4956f471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180461
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-19  Michael Weghorn  <m.weghorn@posteo.de>  [a6cd97bd9c513a6131be1e7f46c44e2d135f8dc7]

        tdf#130857 qt weld: Extract helper method to set menu button props
        
        Change-Id: I5f23f3e5734cee99ed54c9082fe9cbb3d9b54f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180460
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-19  bruh  <randomforest33@gmail.com>  [2b13469b6da26f6b7494c506685a8fcbc29220ce]

        tdf#145759 Use symbolic constants instead of magic numerical constants
        
        Change-Id: Ie8c1c37d4d5385b4f85714116e5e94709419ee66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180477
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-19  Noel Grandin  <noelgrandin@gmail.com>  [de41a28e9aab0c1b05f32e60c1c74b47c6857300]

        document RasterOp a little
        
        Change-Id: If0a13b7e76684b12cd68566429ca0c6a285fc989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180468
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-19  Jean-Pierre Ledure  <jp@ledure.be>  [1032ba121411b2c75f7a4be130cd1409e829bf88]

        ScriptForge (SF_Calc new Intersect() method
        
        The
            calc.Intersect(range1, range2) method
        computes the common area as a string
        which is a sub-range of both input ranges.
        It returns an empty string when the
        sub-range is empty.
        
        Potential use case: customizing a popup
        or context menu depending on the presence
        of the selected cell in a given area.
        
        In addition, the A1Style() method returns
        the sheetname in the output string only
        when it is an explicit argument.
        
        Changes are applicable both for Basic and
        Python scripts.
        
        They require an update of the user documentation.
        
        Change-Id: I920fc8bee6dace9ceed263a0570b4c0197bc8cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180479
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-19  bruh  <randomforest33@gmail.com>  [623521289e7673c795d848c241637bcbb3ce5c0d]

        tdf#145614 Convert #define to enum
        
        Change-Id: I146b65cc931dfc3ce2785ccb5c921e6385fbb4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180015
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [2e31b49edea62b82163cb48444a20339f15f6aa8]

        Use CComPtr and its method to create instance by prog id
        
        Also CComVariant can be created directly from CComPtr, acquiring its
        reference as needed.
        
        Change-Id: I0dda0687eca5eefd8d3b7266f895d485f145eea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180447
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [afb8bce96f8283ece298d422422415b9599eef2f]

        Use EXTENDED_MAX_PATH for consistency
        
        ... instead of literal 32767 or duplicating constants.
        
        Change-Id: I43d7bba2fa2dc74ae65b23f54fb7765f95084895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180464
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [b6223845f6dc50f1343a9302b5826a6e801dea57]

        Use IID_PPV_ARGS in COM calls to avoid C-style cast
        
        Change-Id: I071ed5e3ae95877f2f0954f6fca63d011871d49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180449
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [c31c20a06540b4066e34de6cb320c0317840a952]

        Use IID_PPV_ARGS and CComPtr to simplify
        
        IID_PPV_ARGS allows to avoid reinterpret_casts (and also explicit
        auto-deducible IIDs). Also, there always was a mismatch between the
        type of mWebBrowser2 (which is IWebBrowser2) and the queried IID in
        CSOActiveX::SetClientSite (which was IID_IWebBrowser, instead of
        the correct IID_IWebBrowser2). Looks like in practice it wasn't a
        problem, but now it's consistent.
        
        Use of CComPtr in CSOActiveX::Load allows to release the pointer
        correctly (previously, the call to Release was missing).
        
        Change-Id: I29d672052780a36465f6143106c22fa2c90dab5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180448
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Patrick Luby  <guibmacdev@gmail.com>  [b197379e867087413be86bd1a32030b912ecaa8a]

        tdf#151423 use the same modifier keys during a scrolling session
        
        Revert commit f5ef5eafdf70a36edd5129147502a9c74df89456 as it
        completely disabled the ability to zoom on mice with limited
        support for gestures such as the Apple Magic Mouse by pressing
        pressing the Command key while scrolling. So try a different
        approach and use the modifier keys that were pressed when the
        current scrolling session was started for the entire scrolling
        session.
        
        Unfortunately, session state changes such as a scrolling session
        began or ended are not fired when scrolling with a regular mouse
        scrollwheel so use a significant pause between scrolling events
        as a rough indicator that a new scrolling session has begun.
        
        Change-Id: I898d7f0d3e28ad0436fcb75504f9efb6bf9cdb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180451
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-01-19  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [e46f1c492a3ef9727f2d671ae68a646f9b04a639]

        tdf#164749 make "Compare by: " label in Duplicates dialog translatable
        
        Change-Id: I09a46ecaba91a5d3e9ffca1ae1d7796e6ee21ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180470
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-19  bruh  <randomforest33@gmail.com>  [f9dc1f61b6ccf1281b14a55d13cd4430316c255f]

        tdf#158337 Use C++20 std::erase instead of std::remove followed by erase
        
        Change-Id: Ic6781ae74c2945608c35b92ad8ba92e789582973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180421
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a207e40dbf72c9209e444f17dc51e6167d840d9c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb5ddc28e542ab1963a7e3fc5c3352a72cc86b22
          - Remove module colors from Index, plus...
            
            + Set Index module font color to heading-color
            + Darken headings color for A11Y
            + Set Contents font to bold.
            
            Change-Id: If4708e1ac8e50f125787a0cded63588be895b4b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180475
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [4213b4cb860900f7a6247f582aeb6e84c5772e2d]

        Use COMReference to handle COM pointers in CreateShortcut
        
        Simplifies the code.
        
        Change-Id: I25ab66380e982aaa111242507997f3bc0fda4bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180446
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [582517d60032acfbed2622a2ee905d2c9d3860ce]

        Use std::u16string_view to avoid needless allocation
        
        Change-Id: I0b7c64ea29f65a381a5d02e8818a848e8cc46258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180445
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [75840df232ec960afa20d40e85eb1f0ebd2d5312]

        cid#1640468 Dereference after null check
        
        Change-Id: I5ade1b36b43aca5a33703333dc5d4ff30c383af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180437
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ddb4047a19a4bda4385cb23046eb094beea88079]

        Fix typo
        
        Change-Id: Idccd17065affa1d5ed0821f71faac7d71e9a8928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180443
        Reviewed-by: Taichi Haradaguchi <20001722@protonmail.com>
        Tested-by: Jenkins

2025-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2b15ec7525953ea61f35153ab7be2da61c257c1c]

        Fix typo
        
        Change-Id: Ie50100eb2ab2b099aa4cc6962efc7923669dbf29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180442
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@protonmail.com>

2025-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9cba5a740eb07d4a9dacfc7d8eee9f6e2a006ca7]

        cid#1640473 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id8e440ea08e2d6a853e870dc0161d30e63b75cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180436
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f74160c617667a25dba7fdbfb18583d12c16e991]

        cid#1640469 Dereference null return value
        
        Change-Id: Ib115c3ee73a0124d9d6a3c895722c89158da2d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [848d3ec126be8d8b05b3a07d2eacb98524085dbe]

        cid#1640471 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5b9e8ab80e884609bc18060674f3a974684a0303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180434
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [055a1520e765bbff17dee77f6e045adc4829f3b4]

        cid#1640467 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id029fdf37d8b7b1e8d0bae672d37f6dfcbef8ce8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c70c58c28fbaf004ef8fb3f157be0e719951669]

        QtVirtualDevice::SetSizeUsingBuffer is unnecessary
        
        this method is only used by LOK and LOK only renders to the SVP backend
        
        Change-Id: I33b47e549e4762c61cb921ebbe4e60f97b0c28cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180439
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [99e88bb7497c7d31e660fa5e693b488bafdbf703]

        Use EXTENDED_MAX_PATH in ShutdownIcon
        
        Allows to use long paths in quickstarter, could be useful when the
        program is in a deeply nested directory.
        
        Change-Id: Iba6f8e2f7c54bfd442d19da63c94da9a50a867e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-18  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [437cbf2293dc5a605fe77d97b7c08e3690461835]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fae33ebe38ef8314058d90831f2b6c933feb4e8e
          - Clean up and optimise CSS
            
            Prefer readability over compactness. Repetition is fine, if it
            helps with readability.
            
            Took some tips from this validator: https://stylelint.io/demo/
            
            Change-Id: I36108e2f063c848182503ea469d146bb00099a75
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180438
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [dda2475304e316e9c4c98450d95b0744d95de8a7]

        fontconfig: upgrade to 2.16.0
        
        * external/fontconfig/ubsan.patch is fixed upstream
        
        Downloaded from https://www.freedesktop.org/software/fontconfig/release/fontconfig-2.16.0.tar.xz
        
        Change-Id: Id1acbc473cc03e35c8a7a6bd2b2c080cbf653d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180441
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa3e0b27385258c2fbd24e02b9319e86db00e7e2]

        sw: Dereferencing NULL pointer 'pChangeHint'
        
        After
        commit c239b6cad271d20f443482bc8b6039b1734d18f2
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Sat Jan 4 16:20:57 2025 +0200
        
            convert RES_ATTRSET_CHG to SfxHint
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/draw/dcontact.cxx(1670): error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sw\source\core\draw\dcontact.cxx(1529) : warning C6011: Dereferencing NULL pointer 'pChangeHint->m_pNew'. : Lines: 1415, 1416, 1417, 1424, 1431, 1433, 1435, 1436, 1437, 1445, 1447, 1448, 1450, 1454, 1496, 1499, 1500, 1525, 1528, 1529
        
        C: /cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/sw/source/core/fields/docufld.cxx(2318): error C2220: the following warning is treated as an error
        C: \cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\sw\source\core\fields\docufld.cxx(2294) : warning C6011: Dereferencing NULL pointer 'pChangeHint'. : Lines: 2265, 2271, 2273, 2274, 2275, 2276, 2290, 2279, 2294
        Change-Id: I919d59d108a39dd77adb18967392a8ae8920275a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180431
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b7dfd32f417652087e3d880bcbf88bc2b4d2676]

        vcl: Dereferencing NULL pointer 'pData'
        
        After
        commit a108fce773d46441e30dcc14abe29751410ae4ed
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Fri Jan 17 14:18:30 2025 +0100
        
            tdf#163186 qt: Show menu item tooltips
        
        C: /cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_analyze/vcl/source/window/menu.cxx(1144): error C2220: the following warning is treated as an error
        C: \cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win_analyze\vcl\source\window\menu.cxx(1142) : warning C6011: Dereferencing NULL pointer 'pData'. : Lines: 1137, 1139, 1142
        Change-Id: I62e8462fcff83817f876489a10bd010e246a1d01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180430
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-18  Weblate  <noreply@documentfoundation.org>  [b5419f147deffb40410ae50ef3f474dfe8c7d525]

        android-viewer translated using Weblate
        
        Nepali currently translated at 17.2% (20 of 116 strings)
        
        Change-Id: Ic4035d126f219a07a06e5fca1cbbcda44da450cd
        
        android-viewer translated using Weblate
        
        Romanian currently translated at 1.7% (2 of 116 strings)
        
        Change-Id: I5546924ae3c8a06ef146ad9edace2d35b5808b77
        
        Added translation for android-viewer using Weblate (Romanian)
        
        Change-Id: Ia8a83b4214d1e2534effba69ec1b3616a94eee1a
        
        android-viewer translated using Weblate
        
        German currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I4e8df9f44be8070659ef951e0a79ae1d358d9155
        
        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I1963efa6ecef6c3259d31ef99fa087266c1e9156
        Co-authored-by: Adam Rak <kitynska@gmail.com>
        Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com>
        Co-authored-by: Miloiu Andrei <miloiuandrei@gmail.com>
        Co-authored-by: Nabin  Khanal <boiinventer@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ro/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178880
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [76b55ced15a85f2cd5da8e14a1543cd98c921357]

        basegfx: simplify template code by using concepts
        
        Change-Id: Ie5bff37dbc20253ec869b2e0e0379eb22e78f6d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180415
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0b3c285cedfa63285519354708e28c113851b98b]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I469e956f24a33b803243ffe20ebac252766821cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177154
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-01-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [345738b9e6094d2d8f55c040c0d134d53adf3cf1]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I3749b9d198eb0f237de31ae479394f4e3800c973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177137
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-01-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d39b3dabbfdc61bb886e6dae36fb9740bf78db3b]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I395cabac91b986e94869578921a1de491219dfc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177157
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2025-01-18  Dr. David Alan Gilbert  <dave@treblig.org>  [9f147a024c2efd88a3fadbf2f89800a1659f544e]

        sdext: Document the pdf import code
        
        Change-Id: I572d9a73a652df1f26cf4c6434be4ebe8c5bff00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180132
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2025-01-18  Justin Luth  <justin.luth@collabora.com>  [23a73756211eb198c2e6e46975d564c6274165a2]

        tdf#164748 writerfilter: fix missing even/odd header properties
        
        Lots of header/footer page style properties are ignored
        if the header/footer is not first enabled.
        So copying propertyList MUST follow completeCopyHeaderFooter()
        [which is where all those settings are turned on].
        
        However, copying properties AFTER turning on the header/footer
        was Exception'ing when trying to copy
        BottomMarginComplexColor as void().
        
        So ignore any property-copy errors,
        and then everything should work in theory...
        ...and it seems to.
        
        make CppunitTest_sw_core_header_footer \
            CPPUNIT_TEST_NAME=testBnc519228OddBreaks
        
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf160976_headerFooter
        
        Change-Id: Iecf0a070e77525c04b44c4fc38efa0f9d558eca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180417
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-01-17  Chris Sherlock  <chris.sherlock79@gmail.com>  [a3ee63e617d166e5950e3d1355fe75e8fedcc48b]

        vcl: prefix member variables with 'm' in BitmapBasicMorphologyFilter
        
        Change-Id: I7258502c509584301392c45a21cf0de2ccf5bca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173700
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-17  Christopher Sherlock  <chris.sherlock79@gmail.com>  [f7af54d39a402b24f55bcfd9c1d906b9c8b3dac8]

        vcl: followup to remove unnecessary resets
        
        Followup for 44dfcebde64b9edfa9f50eace34e5e1497ab9314
        
        Just enclose it in the correct scope.
        
        Change-Id: I3bb3bfa0fa8bc5996d728f175aad16b64da52166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180260
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [94d851b27f26ad9a97c5a8a559592d6d9ea0f37b]

        Revert "tdf#163335 qt a11y: Work around broken sw selection handling"
        
        The underlying issue in Writer was fixed in
        
            commit 65a5a4772af919e71a1fe7a752e622ec4cdba7ad
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 14 12:11:46 2025 +0100
        
                tdf#163335 sw a11y: Handle cursor selection consistently
        
        , so revert the temporary workaround in the qt a11y bridge again
        (on master only, workaround remains in place for release branches).
        
        This reverts commit 3eaa35e8bacc19a85f5c9d907450846bfa8bffae.
        
        Change-Id: Ib53aa2d16e0302c4ccd7ba8ac38e9ebb7cf186e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180410
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [a108fce773d46441e30dcc14abe29751410ae4ed]

        tdf#163186 qt: Show menu item tooltips
        
        So far, the qt VCL plugins were not handling/showing
        menu item tooltips, like showing the full path for
        entries in the "File" -> "Recent Documents" submenu.
        
        Implement handling so they are shown:
        
        * Set the tooltip for the menu entry's QAction in
          QtMenu::InsertMenuItem.
        
        * Introduce SalMenu::SetItemTooltip, override it
          in the QtMenu subclass and call it in Menu::SetTipHelpText so
          newly set tooltips are propagated to the native
          Qt menu, to keep them up to date (similar to what already
          happens e.g. for the menu entry's displayed text in
          Menu::SetItemText).
        
        * Since Qt doesn't by default show tooltips for
          QActions used in menus, install an event filter
          on the QMenu/QMenuBar objects that handles the QEvent::ToolTip
          event to manually show a tooltip. See [1] for
          more background and a similar example using custom
          QMenu/QMenuBar subclasses instead of the
          QObject::installEventFilter/QObject::eventFilter approach
          taken in this commit.
        
        Only show the tooltip if one was explicitly set.
        QToolTip::tooltip() [2] by default returns a text
        based on the action's text (with accelerator's etc.
        stripped), so only show the tooltip if QToolTip::tooltip()
        returns something that differs from what would be used
        based simply on the text.
        
        [1] https://forum.qt.io/topic/6821/solved-settooltip-in-qaction-menu/2
        [2] https://doc.qt.io/qt-6/qaction.html#toolTip-prop
        
        Change-Id: I1e2568d9d6e9e2baf7dcd7dffbaaabae7862b489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180408
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [526ea4cc178f8f923c7fcc3fc6b4eea0d8538a07]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e17de2924949bccdbe3aedb527fac6acc210e6e3
          - Fix typo
            
            Change-Id: Id592377c9916d5c18470b996e574710db0ef0c59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180367
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-17  Jonathan Clark  <jonathan@libreoffice.org>  [145d82b5f0cab44a8c34071ddc4458dd3756f6e5]

        tdf#164394 Fix Vulkan vkCreateXcbSurfaceKHR validation error
        
        Updates the Skia shared context patch to avoid surface/swapchain
        construction on invalid X11 windows.
        
        Change-Id: Ia591fb3755ed5adeec2b6246cf9a4a2fb9dcc74d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180420
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-01-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aa94e5cdd98fd395ec7dd9c951aefa298f730b5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 186169d9bd0f713a780e5aae2d8ac71916fb3a60
          - Fix "Contents" heading color
            
            Change-Id: Ic6c42902bd554d365626793dd571607acb2c6433
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180418
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-17  Gökay Şatır  <gokaysatir@collabora.com>  [7495a506642787e220917ce594346d3f6109791d]

        Refactor doc_paintPartTile a bit.
        
        Move repeated lines into inline functions.
        Move large code blocks into inline functions.
        Separate the data validation and process parts.
        
        Change-Id: Icaf4a6fa0bdc15907b4bee7e148edc878555ea45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180412
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-17  Jean-Pierre Ledure  <jp@ledure.be>  [a5ab9e78329cd8174274193c42039b49a049de8b]

        ScriptForge es.po Typos and enhancements
        
        In addition the VALIDATEREGEX message
        is obsolete and removed from next
        language files
        
        	modified:   wizards/source/scriptforge/po/es.po
        	modified:   wizards/source/scriptforge/po/fr.po
        	modified:   wizards/source/scriptforge/po/pt.po
        
        Change-Id: I67c2e5604e548870bf1bdceb9641d4802530e437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180413
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [be1d81eeeaef67ce01ea2e307207a5657b1ceecd]

        prevent assignment if ENABLE_MSVC_ANALYZE exists
        
        so export ENABLE_MSVC_ANALYZE=1 can be used
        in https://ci.libreoffice.org/job/lo_tb_master_win_analyze/
        
        if a macro/variable is only used by make, then there's no need to use export in config_host.mk
        
        Change-Id: I31ebef21c92dfaa279bd3bf7e5e5ecef1e960ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180384
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c212fd9254ed53e478b815c7fc4606d5e6d9850b]

        vcl: extract scanning for resources to UserResourceScanner class
        
        So the scanning for resources can be reused for other things.
        
        Change-Id: Ia1589eb6c2ce4f254be0a62e296b1e186d0ba323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180371
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-17  Pranam Lashkari  <lpranam@collabora.com>  [1ee33246ae88f484e074a6ac15060cc41374ab5a]

        lok: send username of the person who removed comments
        
        This can be userful to know when a user is editing comment
        and another user deletes it.
        It will help to identify and inform about
        the conflict to relevent users only
        
        Change-Id: I81f5edc8f6cbb85ad00e03b5bf668b68eeae1ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179298
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 0b3e73526496875735eeb657929d94897a840b02)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180289
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-01-17  Pranam Lashkari  <lpranam@collabora.com>  [72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0]

        sc: make data validy error dialog async (invalid value error)
        
        Change-Id: Icd077776b26e21b226b4dee5beb1a5ff6dcf301a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179509
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 495be2dcb34d22af59a2028d3a686a0d48774166)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180286
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-01-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [37f1999e15f2b5339e628a2f161672443af561f6]

        tdf#157519 Make solver's Sensitivity Report prettier
        
        Currently the sensitivity report has no formatting whatsoever. This patch formats the report using table headers and adds a line delimiter at the table's end.
        
        The new formatting capabilities were added into AddressWalkerWriter so that it can also be used to improve other statistics reports (such as the features in Data - Statistics).
        
        Change-Id: I80da3c673fec457e3d5de07c5f7a09904412d01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180305
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [656a123c745a55582dc13a589c83c6fad07e1dd4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c0b77292ca59b964feb3d039e9cb9e3adb927c96
          - tdf#131927 Clarify criterion as string expression in SUMIF
            
            Change-Id: I6f59f9042e444011d044eeefb2aeda29b00425c4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180364
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-17  Andras Timar  <andras.timar@collabora.com>  [0e512e7aeeda61e95d2eafc2a566a3cef24fadf6]

        LOK: preload hyphenators
        
        Without this fix the hyphenation feature did not work when
        bind mounting was not available, e.g. in docker containers.
        
        Change-Id: I800012b5229ce5a56a5698db7057e3a27e760be3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180337
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 7b43ce868f980dc47c37f482900210eae2d0187e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180382
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6c9519b5f92eab604a8884aa6db4e8f1ac616b3]

        tdf#137848 Speed up inserting rotated image
        
        Since writer supports displaying rotation now, we don't need to convert
        and rotate the image data itself
        
        Change-Id: I547d8da98125f8956badeb0c113f2d6ab332ee86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180380
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e488385c994993c22d21ac8f1d967770b3145153]

        ofz#390253942 Integer-overflow
        
        Change-Id: Id53f4812622d87a6f775a495d82d9bd7ea1e2869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180381
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [ff41053e7700e5489630869afb4e063f5c8a2ede]

        LOK: Do not try to show an "update links" dialog
        
        In commit f8528cdda9292c7ae6c9d49b80c1a3a3b4a67094 (LOK: don't crash
        when trying to show a dialog during file load, 2024-12-26), all not
        yet async / not properly set up dialogs made to fail gracefully. In
        the follow-up https://gerrit.libreoffice.org/c/core/+/180334, an
        assert is added to still fail in debug builds.
        
        The specific "update links" dialog case, that triggered the original
        change in the first place, does not need to appear at all in the LOK
        case, because there is no external documents available for updating.
        This change avoids the dialog in that case.
        
        Change-Id: I7c6bc755d87656f002829460f4768fed34dc2f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180335
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [f7499659050ace3d4a6aa133853125138f969ac4]

        Add an assert to allow debugging not yet async dialogs
        
        Commit f8528cdda9292c7ae6c9d49b80c1a3a3b4a67094 (LOK: don't crash when
        trying to show a dialog during file load, 2024-12-26) fixed a crash
        when a not async / not properly set up dialog was attempted in Online.
        This is reasonable in release builds, but the added assert helps to
        find the problem in development (debug) builds.
        
        Change-Id: Ie75574cc7a69de06f6b63925249a5da2e50abb6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180334
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c73958bf812d4c1f0b08354bcd86cec5802c6d4e]

        undo/redo of comment insertion assumes Par2 content matches TextObject
        
        contents (as much as conversion to plain text makes possible)
        
        To make things easier, add an EditTextObject::GetText() like
        EditEngine::GetText() that serializes multiple paragraphs in an
        equivalent way so there isn't a need to create an editengine just
        to do this conversion.
        
        Modify and extend DesktopLOKTest::testCommentsCallbacksWriter to
        use a html payload and add a undo/redo to it.
        
        Change-Id: I4d895138e919bab54ebbbcb966f9b9faef574086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179594
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180377
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [2761a14646da14cde30988c19cc22ee02a0281fd]

        configure.ac: fix typo
        
        I hope it fixes https://ci.libreoffice.org/job/lo_tb_master_win_analyze/
        where ENABLE_MSVC_ANALYZE=1 is not doing anything
        
        Change-Id: Ibc2ca6151720d152400f80da611093ec4679e21e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180376
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a1a3fd98dcb3c9336eeaffe1d9def7c3ca8c699b]

        cid#1555986 Check of thread-shared field evades lock acquisition
        
        and
        
        cid#1556190 Check of thread-shared field evades lock acquisition
        cid#1555295 Check of thread-shared field evades lock acquisition
        cid#1608596 Check of thread-shared field evades lock acquisition
        cid#1555236 Check of thread-shared field evades lock acquisition
        
        Double-checked locking pattern
        
        Change-Id: Id5cba26750bbd9c7e0248181f636ff653ada5654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-17  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [b9464eadfc39c93f7c8beb04dc0d2b94b3a2e841]

        Set StyleSettings::DisableColor value in Win
        
        WinSalFrame::UpdateSettings function loads colors from the widget
        toolkit into the StyleSettings objects. Themes uses these colors as
        default values.
        
        I tried using `OpenThemeData(mhWnd, L"Button")` to get the fill color
        value for background color, but didn't get the appropriate color.
        For the time being, modifying the ButtonRect luminance for the disabled
        state. Would replace it with something more appropriate as the Win32
        welding work progresses.
        
        Change-Id: Ied04a8c6c6cb01b1388ef1d744077ae6dfd27b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179439
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-17  bruh  <randomforest33@gmail.com>  [589cd1b840ccdfb00c74d8ae776d853832bcdf4e]

        tdf#153251 remove s_nPixelTwips
        
        Change-Id: I43d39925931071b78e08adf47bf3c6c590b1a2ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180360
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2025-01-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1f7a4ef133542b19d5093fe8e02eb366a7888fd7]

        tdf#148812 write #NAME? for an empty definedName value
        
        This keeps MSOffice silent when opening the documents that don't
        have the any range/formula expression set for the define name.
        
        Change-Id: Ib4cc01a5c51b3875c0d8e0870e2bdf9c15794df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180258
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-16  Miklos Vajna  <vmiklos@collabora.com>  [62dd6274c71bc840f5c5abcd4b1fa536238aa25d]

        cool#10630 doc electronic sign: move signature line tracking to the view
        
        No functional changes intended:
        
        - Replace SfxObjectShell::GetSignPDFCertificate() and
          SfxObjectShell::ResetSignPDFCertificate() with
          SfxViewShell::SetSignPDFCertificate() and
          SfxViewShell::GetSignPDFCertificate(), because information about shape
          selection belongs to the view.
        
        - Change svx::SignatureLineHelper::setShapeCertificate() to use
          SfxViewShell::SetSignPDFCertificate() to avoid duplication.
        
        - Change GetSignatureLineShape() in xmlsecurity/ to use
          SfxViewShell::GetSignPDFCertificate(), again to avoid duplication.
        
        With this, all setters/getters of the inserted signature line go via
        SfxViewShell and the amount of getCurrentSelection() calls on the model
        is reduced.
        
        Change-Id: I021bc41262b2a16d1014fbf1431a0eb6e1e86c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180355
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [29c73c128443bf2d63327346821be570b3fea5e0]

        defer creating std::locale until it is needed
        
        (if ever, seeing as it's only required if there is an error)
        
        Change-Id: Id8ba5ff495dfd2048401231023a09abba9bbf785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180347
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-16  Noel Grandin  <noelgrandin@gmail.com>  [384c21f8937b5b38c52178e051d929408eea6606]

        convert RES_UPDATE_ATTR to SfxHint
        
        Change-Id: I4d5da5ba4e65ddbce2cb05bdfda34eb582c52d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [4d9820addc8116e3383b03143ed3b1191967c1b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d9104f52a1f7e3b2eee958544659cabb6808cd3c
          - Center everything with 1440px width
            
            Change-Id: I4a97df011b58c70f5ff8ef73433d8f6bd325d371
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180297
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e89ade57e15dfcb8997f1b22671892d19c720837]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f4c572d64b2fbe1ce66dc917c2709d96a4158fd
          - tdf#164068 Add Table style in style category page.
            
            + refactor
            
            Change-Id: I0f85fd41b62f980c118e2c00d9f7eacf691a723c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180361
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [51e4b6b126dc90e0725b9a94dfca8ee87f3e2d3b]

        crashtesting: Find might return nullptr
        
        Since
        commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        Author: László Németh <nemeth@numbertext.org>
        Date:   Fri Oct 25 00:38:35 2024 +0200
        
            tdf#48459 sw inline heading: apply it on the selected words
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/5629bae3-8c43-4864-8758-4887b00a892d
        
        Change-Id: I125304700b4e2fcc4ecc52eb7eaecea049cbb5ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [087604aa3c31e9e1586fa448edfc554b0131575d]

        Simplify SwFormatLineBreak/SwXLineBreak interaction
        
        No need to use BroadcastingModify here, both sides hold a pointer
        to a concrete class.
        And we only need to deal with destruction in one direction,
        because the other direction uses a weak reference.
        
        Change-Id: If15d515d83e695c92614c8335356ce2f32db8dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180353
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [737dd3d412b57660c683972183a75e2c9cc666f2]

        sc: improve failure message in FunctionsTest
        
        The comment
        "Column A has the result value, column B has the expected
        value, Column C has the check result (1 or 0), column D has
        the formula text."
        is no longer true in some documents
        Instead, use the headers in first row to find the correct columns
        
        Change-Id: I6a08f788b34120fb68db0dfc0443b35361954687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180338
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c8c2ce7c3d6ecb57fa0736447c8aeff287c92f4]

        loplugin:unusedmethods
        
        Change-Id: I8041b975ee8e1cb0a75c43c6332f315627847033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180343
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [2507d08388dd03547d2c5fc5aeedc5aa0f166bd1]

        split the SetSizeUsingBuffer code paths
        
        into one that uses pBuffer and one that does not, to make it easier to
        understand, and easier to validate.
        Consequently, add some asserts to the parts of the resulting code paths
        that look like bogus.
        
        Change-Id: I9060f780df678e03688e34f49ef5fa2d437a082c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180350
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  Patrick Luby  <guibmacdev@gmail.com>  [18e5d1ce26ab7a0fb41b8b64a0a732b5f81f3ed8]

        Related: tdf#145127 force error when compiling for unsupported Apple OSs
        
        While LibreOfficeKit can be built on macOS, the built library won't work
        as intended since a headless vcl implementation is needed. Currently,
        iOS is the only Apple OS that has a headless vcl implementation so
        force a compiler error.
        
        Change-Id: Ib9318851ff7e6c98531672ba7241c22a91f3ef7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180093
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-01-16  Pranam Lashkari  <lpranam@collabora.com>  [1de4b9ae2b43c5f3818cc146ab1f46d3da2edf03]

        math: store main viewshell id in math view shell
        
        problem:
        when we enter to edit a formula a new view shell is created.
        In LOK all the JSwidgets would be mapped to this window id.
        But when LOK requests widgets we get the requests from the main viewshell
        and we can't find any widgets mapped to the main viewshell
        which means LOK can't load any widgets.
        
        Currently there's no mechanism to find the sub viewshell
        
        Change-Id: I4f9ce161101ef6815f4d9e712d9bd42f0dc83ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180038
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180287
        Tested-by: Jenkins

2025-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d4e8447a1d2c37a31e809e7ce47999328a2841d]

        sc: keep conditional format in test file
        
        it was removed when running flat-odf-cleanup.py
        
        File added in
        commit ee05b94e713adbc7af3e29ac6018c5e825511c96
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Jan 14 16:19:06 2025 +0100
        
            tdf#150879: Add support for TOCOL function
        
        Change-Id: I2e59b2605dd74472810f55894ecdfa94df70997d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180307
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-16  Julien Nabet  <serval2412@yahoo.fr>  [888c2a40f356b563d149bbd3e06ed6438bc5f676]

        More improvements in fr.po (wizards/scriptforge)
        
        Replace:
        -"supporté" with "pris en charge"
        -"tableau" with "matrice" when it's about an array
        
        Change-Id: I7c91bece58da90beb8c9787c1310fcd235698402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180306
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [28c01fa9093667114448238cb09ae8c57661fbae]

        sc: fix some checks
        
        See https://gerrit.libreoffice.org/c/core/+/180245/comment/59cd8c41_737390e6/
        After
        commit ee05b94e713adbc7af3e29ac6018c5e825511c96
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Jan 14 16:19:06 2025 +0100
        
            tdf#150879: Add support for TOCOL function
        
        and
        
        commit c1565b8b94548ef85508b0302ef9299f18ff09be
        Author: Balazs Varga <balazs.varga.extern@allotropia.de>
        Date:   Fri May 10 17:06:39 2024 +0200
        
            tdf#126573 Add Excel2021 array function UNIQUE to Calc
        
        Change-Id: I277cb1e998d1ef33f319beec42c990bc8effefe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180346
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-01-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e4bc6564e8269ab4c86ebc350518a51d1579c8ad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to de99260dbb43ec2b4676b2daa31cc8499be4e11b
          - Center <body> in screen for Help pages
            
            Change-Id: I60f45842ba7c8a86afd0714b72292a9bbf5bcaf2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180352
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [ea79049eeda1328fdc881033e729c573078b5d3e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fc3b49ad5d6547412773419ce91fe2b1f0509c25
          - Wrap book icons for mobile-friendliness
            
            Change-Id: I2475c2c65883f6c1c12c3d762d472fc5f83764a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180344
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-16  Eike Rathke  <erack@redhat.com>  [8d8f84de676ef30e11e26d9449e25cf9ce714c52]

        Related: tdf#164276 It's Guyana ...
        
        Change-Id: I7d7b4fd4894fc800c6cee7a18f016e6397fd61ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180304
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1da8b21e37dce9019a696ec4174283721b92648]

        SimpleCertificateValidationRequest is unused
        
        since
            commit 9413f2b39cb48417d75dfd3b5a28dac18541839e
            Author: Michael Stahl <michael.stahl@allotropia.de>
            Date:   Fri Jun 21 16:23:24 2024 +0200
            ucb: cmis: remove CertValidationHandler
        
        Change-Id: Iee66db682081ddcb7da9a6276acf3261a637f315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b620171f6b3fb15f48890d46fb6e8fb51bfd383]

        tdf#150878: Add support for TOROW function
        
        Change-Id: Ic1acb5c2fd08ecab7c3ee059888cf44aa45ee287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180308
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [41de340e048c3545480c0cd209f4d1a3bb9b83ff]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ided094e1c45f7beba9a12bc44b1bc68ea5d3319c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180342
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  bruh  <randomforest33@gmail.com>  [c67bd0a332a41f62fefd0957b58809b554d0cacb]

        tdf#147132 Flatten Basic function implementations.
        
        Change-Id: I5e5d01c43b39f68f38290ce04b26730af362b43e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180282
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [28e449d31f3aa3f759a495e9d0e932bc1dcb3280]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd6c0ba10789ecf74cb220cf4e31cd3d6a66a954
          - tdf#148016 Add dark mode to Help pages
            
            + First trial to implement a dark mode
            + Mode follows browser settings
            + removed modules color foo in help2.js
            
            Change-Id: I0dfc62f832c3f5d406ac8d92d530eac382c4dc62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180294
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-16  Gökay Şatır  <gokaysatir@collabora.com>  [2952c8f7804966b7091d940e785597466d2b0e86]

        Remove unused callback.
        
        Change-Id: I1ef8646aec506aa687202ad4130e52da3c3dd503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180336
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [828a0dcdf6fd1600baaf3103583633006a90d9f9]

        ScanlineDirection is unnecessary
        
        we always use top-down data now.
        
        (which indicates that the Windows OpenGL code has bitrotted a little
         and has probably been broken for some time).
        
        Change-Id: Ic16893d5cf7d2a3f9045b5aa77d4ad2ebc4fe432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180331
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  Pranam Lashkari  <lpranam@collabora.com>  [1dd45462fd55ba2069b1303f8713a591ef57feab]

        svx: avoid emptying sidebar properties
        
        these properties are either updated or reformatted based on *Blanked variables so no need to do an extra update
        
        problem:
        emptying these properties causes to lose measurement units in LOK. It happens due to second time this sidebar is not completly initialised but just updated the value of the fields so units are lost for LOK.
        
        Change-Id: Id32638686578652ab4ffa25a638b5308c46eea2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179583
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180288
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2025-01-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3568870bfd768877733679ba00636722d63c14c5]

        Fix comment
        
        Change-Id: I3486a471583d63500978383bcd6deb772a094883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180339
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5a23e690d32141544035c0124c22b48bd1e401d]

        missing return statement in SwSectionFormat::SwClientNotify
        
        regression from
            commit da758c4d15569667cc3d444ba53826b0ee5d2a90
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Jan 5 13:23:59 2025 +0200
            convert RES_OBJECTDYING to SfxHint
        
        Change-Id: I4fdfd2ffe1d395d28b0eadd61613dbee2dc3de51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180333
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-16  Heiko Tietze  <tietze.heiko@gmail.com>  [8b5d4c360c359adf787d466164377c05ac8f7d14]

        Resolves tdf#164185 & tdf#89420 - Show text boundaries in Draw
        
        Show margins by default and hide per expert setting
        Draw::Misc::TextObject::ShowBoundary
        
        This patch reverts/improves I3e31bec65ab34772bd2f8137be7e5e5258758184
        
        Change-Id: I177ab0491e85aea327a512ab9d336949ddfa6e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179995
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-16  Justin Luth  <justin.luth@collabora.com>  [575094675e7f6fb643e8cac61f06c14d2f79bcd5]

        tdf#164500 docx import framePr: add blank para as anchor before table
        
        In my unit test there is a "problem"
        because the added paragraph wraps below the frame
        and thus pushes the content down an extra line (compared to MS Word).
        But if the frame was not autosized (full width),
        then the added paragraph would wrap around behind it perfectly.
        This is emulation (since we can't anchor to a table start node),
        so it will have to be good enough.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf164500_framePrBeforeTable
        
        Change-Id: I1318dbacf853fb7d08c988e48dda7ac20c9498ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179492
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-01-15  Eike Rathke  <erack@redhat.com>  [35b9371acf5a1295ef7c12bbfa285efb7ea4b485]

        Related: tdf#164276 Add English (Guyana) to language list
        
        Change-Id: Ie80891543737dded886daa91894d5f2aa513b645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180276
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2025-01-15  Eike Rathke  <erack@redhat.com>  [ff7ea6b660b4e6bcd6575106c160882076c066a2]

        Resolves: tdf#164276 Add English (Guyana) {en-GY} locale data
        
        Change-Id: I6571e4c58efed00a9c7120d6cab9139223283741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180275
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-01-15  Eike Rathke  <erack@redhat.com>  [795ac9ab988b1408029c333eec14857e08ead400]

        Related: tdf#164276 Add English (Guyana) [0xBC09] {en-GY} mapping
        
        Change-Id: I87a3d6f7bb8ea70578312ac2894c6badac48652b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180274
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2025-01-15  Miklos Vajna  <vmiklos@collabora.com>  [9dd225ee8c45d6c944b9ce5578780d89612e9ffb]

        cool#10630 doc electronic sign: fix no graphic selection for the signature line
        
        Insert a signature line in "extern" mode, the shape gets selected but
        there is no graphic selection at a LOK API level.
        
        This is because GetSignPDFCertificate() returned an XCertificate, which
        is empty in the external signing case, so we can't differentiate between
        no signing and external signing.
        
        Fix this by changing the return type to svl::crypto::CertificateOrName,
        this way SdrMarkView::SetMarkHandlesForLOKit() can annotate the
        signature line correctly even in the external signing case.
        
        The tracking of the signature line selection is still in the model (not
        in the view), that's not yet fixed here.
        
        Change-Id: I4ef9c1fa0a88af0c0fcd55156b973a3705f985c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180296
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-15  Christopher Sherlock  <chris.sherlock79@gmail.com>  [11bc8cc7d89f69a0fdcf97db92fd86299acc0734]

        vcl: move variables closers to first use
        
        Change-Id: Ie1d5ee1270c565a73cee54726c147300f27593e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177805
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [611d4819bf190765ea0b8d79b4795ac0f11aa409]

        Simplify a bit
        
        Change-Id: I808db67b749a5e36da63cf791d43cb31d7408876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180263
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [2ba64848bb375b6825fc59e1300c1c228a432a39]

        Simplify a bit
        
        Change-Id: Idbc96dc2db8202326dd7a40033e0b94df6de9ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180270
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-15  Jean-Pierre Ledure  <jp@ledure.be>  [80623714e63e1aa18bc02a51ba87ea7805b81ec1]

        ScriptForge add spanish translation
        
        	modified:   wizards/Package_scriptforge.mk
        	new file:   wizards/source/scriptforge/po/es.po
        
        Change-Id: Ia4d51b9dfaa75bf2f50bb5a11f7f8d465b106489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180285
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-01-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7c4844ab3f7f08468c53b922a320045e410fbc4e]

        We don't need that hack with --enable-emscripten-jspi
        
        With recent Qt6 dev branch (which is the only Qt that supports
        -feature-wasm-jspi, and which is still experimental there), plain
        --disable-emscripten-jspi would call emscripten_set_main_loop via LO's
        soffice_main -> SVMain -> ImplSVMain -> desktop::Desktop::Main ->
        Application::Execute -> QtInstance::DoExecute calling Qt's QApplication::exec ->
        QGuiApplication::exec -> QCoreApplication::exec -> QEventLoop::exec ->
        QEventDispatcherWasm::processEvents ->
        QEventDispatcherWasm::handleApplicationExec.
        
        But --enable-emscripten-jspi, where Application::IsUseSystemEventLoop returns
        false, doesn't call into QApplication::exec from QtInstance::DoExecute
        (vcl/qt5/QtInstance.cxx), so never calls emscripten_set_main_loop, so doesn't
        need the hack here.
        
        Change-Id: I0d0baed40d638bbad4359306aff8f2a3e7e76a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180269
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d21e33f0f7c8e610e2f19b632fe5885c573c1691]

        Fix Windows `make CppunitTest_... CPPUNITTRACE=TRUE`
        
        ...after b20d18054ca5c13376bfd723b7e442c2e011c6de "Move setting of
        LD_LIBRARY_PATH closer to invocation of cppunittester" had caused that to just
        start VS without a program to debug
        
        Change-Id: I0e9039acf3b63f2cf43f64aeecd05d51aff58979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180284
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-15  Andras Timar  <andras.timar@collabora.com>  [593df89a655d19e009dd067e1b6e5508251f695d]

        The ':' separator without spaces was difficult to read on UI
        
        Change-Id: I0886518f254659b6e9c1c242a9331b85e471dd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180233
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-01-15  Andras Timar  <andras.timar@collabora.com>  [eb0cb45bdc6d3683d1dc6052205070b73e4032c5]

        Localize "My AutoText" one more place
        
        Change-Id: Ia743818dc5aacbc11f41154692bbf79f32eeb50d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180232
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2025-01-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee05b94e713adbc7af3e29ac6018c5e825511c96]

        tdf#150879: Add support for TOCOL function
        
        Change-Id: I0c8bfdd8f9b806a1260cceace1ced4be2b046abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180245
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-15  Jonathan Clark  <jonathan@libreoffice.org>  [bf54efbe21d6c6fcb910f7fa3d9f43978dc555c9]

        tdf#34837 sc: Use border from correct cell for merged cells in RTL
        
        This change fixes a bug causing borders to fail to render for merged
        cells in RTL spreadsheets.
        
        The root cause for this bug was framelinkarray utility code using the
        top-left cell as the source for border styles of merged cells. This use
        was correct for LTR spreadsheets. However, this framelinkarray data is
        mirrored for RTL documents. After mirroring, the correct cell containing
        border styles is the top-right one.
        
        This change also reverts and reimplements a prior fix for tdf#135843
        (commit 586a0f149f332c0b0e53c0bb30568d4bd411b0e3), which violated the
        framelinkarray contract that edge styles for merged cells must be added
        to the top-left underlying cell of a merged cell.
        
        Change-Id: I27eec416d54f9f99cd5df1151a12c758f350c789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180256
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [4d5b3e99911acb3085dba5d66627b5737c885d85]

        tdf#164717: count all found cells in the dialog
        
        The number of list entries is already limited in ListWrapper::Insert;
        but it needs to count all the items to give a sensible output.
        
        Change-Id: I04bd4437977c88144c929af4b45fef119e8b2a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180268
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [cbec608e996c86c3242fe06ca3a42e9117072495]

        remove dead code in SwRegHistory
        
        This was introduced in
        
            commit 7d9bb549d498d6beed2c4050c402d09643febdfa
            Author: Armin Le Grand <alg@apache.org>
            Date:   Mon Jun 2 15:00:50 2014 +0000
            Related: #i124638# Second step of DrawingLayer FillAttributes...
        
        But makes no sense because this pool item is really a hint, and it will
        be ignored in all the code paths that flow from here.
        
        Change-Id: I5e3aca9fa438c99f1883c8c56634264cd61e3eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180273
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [6dc8bc3a7bbcd0327c6aabf5cc5afdb0d9efb9a3]

        tdf#130857 qt weld: Convert accelerator in button label
        
        Otherwise e.g. the "~Open" label (STR_OPEN, which
        gets set in SfxTemplateManagerDlg::SfxTemplateManagerDlg)
        gets shown as a literal "~Open", rather than "Open" with
        the "O" being the accelerator key in a WIP branch experimenting
        with Qt welding of the "File" -> "Templates" -> "Manage Templates"
        dialog.
        
        While at it, simplify the method a bit to just
        run the single method in the main thread
        unconditionally.
        
        Change-Id: Iea25948f77edb6e884bad96cb36ab7eec67a141e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180253
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [2ef30328ab45e9d64a7bbce87b04865c85c44b62]

        tdf#130857 qt weld: Signal MenuButton menu item selection
        
        Change-Id: I389993794db520778093845458daf0c89dec21b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180252
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [1506b6a3136269d54aa9eb8c99c4335170632f3b]

        tdf#130857 qt weld: Open menu button's menu instantly
        
        Set the QToolButton's popup mode to QToolButton::InstantPopup [1]
        
        > The menu is displayed, without delay, when the tool button
        > is pressed. In this mode, the button's own action is not triggered.
        
        Otherwise, the default of QToolButton::DelayedPopup is used
        and the menu only opens when clicking the button for a longer
        time, which is unintuitive for menu buttons:
        
        > After pressing and holding the tool button down for a certain amount of
        > time (the timeout is style dependent, see QStyle::SH_ToolButton_PopupDelay),
        > the menu is displayed. A typical application example is the "back" button in
        > some web browsers's tool bars. If the user clicks it, the browser simply browses
        > back to the previous page. If the user presses and holds the button down for a
        > while, the tool button shows a menu containing the current history list
        
        [1] https://doc.qt.io/qt-6/qtoolbutton.html#ToolButtonPopupMode-enum
        
        Change-Id: Ie4be457ec801cddd3eee02a7b8800b1400564216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180251
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Stahl  <michael.stahl@allotropia.de>  [2b50dc0e4482ac0ad27d69147b4175e05af4fba4]

        redland: disable all raptor parsers except for "rdfxml"
        
        It's the only one the unordf component invokes.
        
        CVE-2024-57823 CVE-2024-57822 affect the "ntriples" and "turtle"
        parsers.
        
        However it appears that the function raptor_uri_normalize_path() could
        also be called from raptor_libxml_* functions?  Somewhat unclear, let's
        add the patch just in case.
        
        Change-Id: Idd7ebbc29c63e84ca2434b06c26f7aca34bdcaa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180272
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [7fe443e1f3f235cd6f0f04e4956616464ca5f80f]

        SfxListener::RemoveBroadcaster_Impl must handle duplicates
        
        SfxListener::StartListening explicitly allows duplicates.
        RemoveBroadcaster_Impl should be safe in that regard; use
        std::erase to remove all occurrences of the broadcaster.
        
        Change-Id: Icc4d1d12c450a0893e9e4da429120f32388b35fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180262
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1dab72d780e718cccfcc4fe6e722ac0c0822174b]

        Let a test use a copy of a SRCDIR test doc
        
        Whatever the reason, but running the test against a read-only SRCDIR caused
        CppunitTest_sd_tiledrendering2
        CPPUNIT_TEST_NAME=testInsertSignatureLineExternal::TestBody to fail with
        
        > sd/qa/unit/tiledrendering/tiledrendering2.cxx:64:testInsertSignatureLineExternal::TestBody
        > equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        
        Change-Id: I6fedd20bec3c36cd2f803a8cb0b4222863a6126f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180266
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [1b14aced2b382eb876f27f17c251060361905a4a]

        tdf#130857 qt weld: Implement QtInstanceMenuButton::insert_item
        
        Add initial implementation for QtInstanceMenuButton::insert_item.
        See also QtBuilder::insertMenuObject which partially has the
        same logic.
        
        Handling for radio or check items is not implemented yet,
        so assert that `eCheckRadioFalse` is `TRISTATE_INDET` for now.
        
        This will e.g. be used by the "File" -> "Templates"
        -> "Manage Templates" dialog once that one is supported.
        
        Change-Id: Ib34d6b61b26ae900eac3b34b68224e6ac2e11711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180250
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Gökay Şatır  <gokaysatir@collabora.com>  [b954798dc2a249c8cd12e9b384e0c157ac07f1ea]

        cool#7406 Revert "cool#9019: draw/impress: disable the Grid for now"
        
        This reverts commit 41130a39ad68310a0136605cbced1f191396c456.
        
        Now we are preparing to show & snap grid functionality.
        
        Snap grid feature is ready:
        https://github.com/CollaboraOnline/online/pull/10147
        
        Change-Id: I0ecc395616cc985aadc76f44b1dfe011b624ecc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180265
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-15  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [633213093e22c813f3c9df6d2d174ec07eedebff]

        Use comphelper::containerToSequence() instead of loop
        
        Change-Id: I768bf65bd3f5d2fff601a0d50fcec8e832162b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180108
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [14a221bf5687d368f5918295682de2ccf8a5e814]

        qt: No longer manually destroy QWindow
        
        With current qtbase git dev, expanding the Font Name
        combobox in Writer's Formatting toolbar and clicking on a
        combobox entry to select it triggers a crash in
        `QWidgetWindow::handleMouseEvent`, similar to
        the one described in more detail and fixed in
        
            commit 4b547f11ae3e943e67c195a67a033307ce7f1d6d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 24 13:12:18 2024 +0100
        
                tdf#130857 qt weld: Defer QDialog deletion
        
        . For the scenario here, the QWidgetWindow whose
        virtual method gets called (causing the crash) was
        destroyed with this backtrace earlier:
        
            1 QWidgetWindow::~QWidgetWindow qwidgetwindow.cpp 162 0x7f856b6dc6c7
            2 QWidgetWindow::~QWidgetWindow qwidgetwindow.cpp 160 0x7f856b6dc80d
            3 QWidgetPrivate::deleteTLSysExtra qwidget.cpp 1711 0x7f856b687fa1
            4 QWidget::destroy qwidget.cpp 12612 0x7f856b687bd6
            5 QtWidget::hideEvent QtWidget.cxx 261 0x7f856e63decc
            6 QWidget::event qwidget.cpp 9199 0x7f856b69fd67
            7 QtWidget::event QtWidget.cxx 689 0x7f856e63f6ce
            8 QApplicationPrivate::notify_helper qapplication.cpp 3305 0x7f856b5e2dd0
            9 QApplication::notify qapplication.cpp 3251 0x7f856b5e6cc9
            10 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1118 0x7f856d6481b9
            11 QCoreApplication::sendEvent qcoreapplication.cpp 1558 0x7f856d648e29
            12 QWidgetPrivate::hide_helper qwidget.cpp 8205 0x7f856b69d95f
            13 QWidgetPrivate::setVisible qwidget.cpp 8402 0x7f856b69e9d5
            14 QWidget::setVisible qwidget.cpp 8310 0x7f856b69e1dc
            15 QtFrame::Show QtFrame.cxx 398 0x7f856e53ec37
            16 vcl::Window::Show window.cxx 2218 0x7f85786ccd7f
            17 vcl::Window::Show window.cxx 2212 0x7f85786cccaa
            18 FloatingWindow::ImplEndPopupMode floatwin.cxx 896 0x7f857858caf1
            19 FloatingWindow::EndPopupMode floatwin.cxx 948 0x7f8578589485
            20 ComboBox::ImplSelectHdl combobox.cxx 410 0x7f857872ee66
            21 ComboBox::LinkStubImplSelectHdl combobox.cxx 316 0x7f857872d2bd
            22 Link<LinkParamNone *, void>::Call link.hxx 101 0x7f85784223a1
            23 ImplListBoxWindow::ImplCallSelect imp_listbox.cxx 722 0x7f85787c0bc0
            24 ImplListBoxWindow::Tracking imp_listbox.cxx 1133 0x7f85787c221f
            25 vcl::Window::EndTracking window2.cxx 341 0x7f85786ae763
            26 ImplHandleMouseEvent winproc.cxx 713 0x7f85786e8aae
            27 ImplHandleSalMouseButtonUp winproc.cxx 2351 0x7f85786ed041
            28 ImplWindowFrameProc winproc.cxx 2700 0x7f85786ebd50
            29 SalFrame::CallCallback salframe.hxx 311 0x7f856e54cecc
            30 QtFrame::CallCallback QtFrame.hxx 235 0x7f856e549e95
            31 QtWidget::handleMouseButtonEvent QtWidget.cxx 117 0x7f856e63d45a
            32 QtWidget::mouseReleaseEvent QtWidget.cxx 128 0x7f856e63d711
            33 QWidget::event qwidget.cpp 8971 0x7f856b69f34d
            34 QtWidget::event QtWidget.cxx 689 0x7f856e63f6ce
            35 QApplicationPrivate::notify_helper qapplication.cpp 3305 0x7f856b5e2dd0
            36 QApplication::notify qapplication.cpp 2782 0x7f856b5e4aa2
            37 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1118 0x7f856d6481b9
            38 QCoreApplication::sendSpontaneousEvent qcoreapplication.cpp 1572 0x7f856d648eb9
            39 QApplicationPrivate::sendMouseEvent qapplication.cpp 2363 0x7f856b5e36f7
            40 QWidgetWindow::handleMouseEvent qwidgetwindow.cpp 664 0x7f856b6de49b
            41 QWidgetWindow::event qwidgetwindow.cpp 292 0x7f856b6dcd25
            42 QApplicationPrivate::notify_helper qapplication.cpp 3305 0x7f856b5e2dd0
            43 QApplication::notify qapplication.cpp 3255 0x7f856b5e6ced
            44 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1118 0x7f856d6481b9
            45 QCoreApplication::sendSpontaneousEvent qcoreapplication.cpp 1572 0x7f856d648eb9
            46 QGuiApplicationPrivate::processMouseEvent qguiapplication.cpp 2485 0x7f856c484282
            47 QGuiApplicationPrivate::processWindowSystemEvent qguiapplication.cpp 2212 0x7f856c483446
            48 QWindowSystemInterface::sendWindowSystemEvents qwindowsysteminterface.cpp 1113 0x7f856c56a27d
            49 QWindowSystemInterface::flushWindowSystemEvents qwindowsysteminterface.cpp 1082 0x7f856c56a12e
            50 QtWaylandClient::QWaylandDisplay::flushRequests qwaylanddisplay.cpp 524 0x7f8569ca7635
            51 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7f8569cc32d5
            52 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7f8569cc31fd
            53 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 126 0x7f8569cc311f
            54 QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay:: *)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 174 0x7f8569cc3091
            55 QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 545 0x7f8569cc2fbb
            56 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7f856d65e772
            57 QMetaCallEvent::placeMetaCall qobject.cpp 622 0x7f856d707e5c
            58 QObject::event qobject.cpp 1431 0x7f856d709bb1
            59 QApplicationPrivate::notify_helper qapplication.cpp 3305 0x7f856b5e2dd0
            60 QApplication::notify qapplication.cpp 3255 0x7f856b5e6ced
            61 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1118 0x7f856d6481b9
            62 QCoreApplication::sendEvent qcoreapplication.cpp 1558 0x7f856d648e29
            63 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1898 0x7f856d649d68
            64 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1752 0x7f856d648c6c
            65 postEventSourceDispatch qeventdispatcher_glib.cpp 246 0x7f856dc377b1
            66 ?? 0x7f857430b81f
            67 ?? 0x7f857430da57
            68 g_main_context_iteration 0x7f857430e1c0
            69 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 399 0x7f856dc369eb
            70 QPAEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 89 0x7f856cd64858
            71 QtInstance::ImplYield QtInstance.cxx 464 0x7f856e56a532
            72 QtInstance::DoYield QtInstance.cxx 475 0x7f856e56d5b1
            73 ImplYield svapp.cxx 385 0x7f8578ebd8d6
            74 Application::Yield svapp.cxx 488 0x7f8578ebd1ef
            75 Application::Execute svapp.cxx 360 0x7f8578ebcfd0
            76 desktop::Desktop::Main app.cxx 1679 0x7f8581d27b89
            77 ImplSVMain svmain.cxx 230 0x7f8578eded56
            78 SVMain svmain.cxx 248 0x7f8578ee0949
            79 soffice_main sofficemain.cxx 121 0x7f8581da146a
            80 sal_main main.c 51 0x55d374ac7a6d
            81 main main.c 49 0x55d374ac7a47
        
        To fix that, no longer manually destroy the QWindow (s. frame 5).
        
        This reverts commit
        
            commit 2284e26a0731a606568eda706e8e4451aaf880d8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 19 09:49:57 2024 +0200
        
                qt a11y: Destroy QWindow when popup gets hidden
        
        (which wasn't causing any such issues before qtbase commit [1])
        and results in the top-level frame of the combobox popup not
        getting removed from the a11y layer any more when the combobox gets closed
        (s. commit message of the above commit for more details),
        so this will need another solution instead.
        (Using native QComboBoxes might solve this issue as well,
        once the Qt welding process - see tdf#130857 - has reached the
        point where these comboboxes can be native Qt ones.)
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=84a5f50c7766c99f62b22bb4388137e0aa8dd13d
        
        Change-Id: I3dfd7bd7883498a68b3106bf42541c2948344040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180243
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [a3fb32f077f36ac0647f3ca8aba51304ad045939]

        qt: Set fullscreen directly via QWidget
        
        There's no need to go via the widget's
        QWindow by calling QtFrame::windowHandle
        which would force setting the
        Qt::WA_NativeWindow attribute as well.
        
        Change-Id: Ibd3941c47361007f34a1f6aaf995adb866aac59b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180242
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [65a5a4772af919e71a1fe7a752e622ec4cdba7ad]

        tdf#163335 sw a11y: Handle cursor selection consistently
        
        Fix the issue described in more detail in
        
            Change-Id: I874ad4a7a9faf79492967c943517d83df5f47e75
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 14 11:32:25 2025 +0100
        
                tdf#163335 qt a11y: Work around broken sw selection handling
        
        :
        
        > SwAccessibleSelectionHelper::getSelectedAccessibleChildCount
        > returns the count of paragraphs that are (partially) selected
        > by the text cursor if no other objects are selected.
        > However, SwAccessibleSelectionHelper::getSelectedAccessibleChild
        > doesn't take these into account and therefore throws the
        > IndexOutOfBoundsException when called with any index.
        
        Sample steps to reproduce with the gtk3 VCL plugin:
        
        1) have a Writer doc with 3 paragraphs
        2) in Accerciser, select the document in the a11y tree
        3) interactively query information in Accerciser's IPython
           console:
        
            In [5]: sel = acc.get_selection_iface()
            In [6]: sel.get_n_selected_children()
            Out[6]: 2
            In [7]: sel.get_selected_child(0)
            In [8]: sel.get_selected_child(1)
        
        The last 2 lines trigger
        
            ** (soffice:238967): WARNING **: 12:00:10.723: Exception in getSelectedAccessibleChild()
        
        in `selection_ref_selection`.
        
        Fix this by aligning the logic in
        SwAccessibleSelectionHelper::getSelectedAccessibleChild
        with the one in
        SwAccessibleSelectionHelper::getSelectedAccessibleChildCount
        and take the paragraphs that have cursor selection into account there
        as well.
        (This is also consistent with the fact that they have the SELECTED
        a11y state set.)
        
        With that in place, the selected paragraphs can now be queried
        in Accerciser:
        
            In [10]: sel = acc.get_selection_iface()
            In [11]: sel.get_n_selected_children()
            Out[11]: 2
            In [12]: sel.get_selected_child(0)
            Out[12]: <Atspi.Accessible object at 0x7f0405596a40 (AtspiAccessible at 0x402b7380)>
            In [13]: sel.get_selected_child(1)
            Out[13]: <Atspi.Accessible object at 0x7f040557a100 (AtspiAccessible at 0x402b86d0)>
            In [14]: sel.get_selected_child(1).role
            Out[14]: <enum ATSPI_ROLE_PARAGRAPH of type Atspi.Role>
        
        But querying an invalid index still gives a `None` result
        as expected:
        
            In [16]: sel.get_selected_child(2)
            In [17]: sel.get_selected_child(2) == None
            Out[17]: True
        
        (Behavior with qt6 VCL plugin is basically the same.)
        
        Change-Id: Ic8cf462ae19e494b899643db1709f5075460d287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180231
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [3aa8b6f809113e398122bdfc0d5756f1cd6e2af9]

        sw a11y: Reuse existing list of a11y children
        
        Deduplicate (and reuse in case both code paths
        are taken).
        
        Change-Id: I1a5a22ed99d136a43342e6e5ab4a9e283a36eab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180230
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [104c099a77cb8b0cf2629204c7fcfc3e9ec9bb3b]

        sw a11y: Flatten SwAccessibleSelectionHelper::getSelectedAccessibleChildCount
        
        Change-Id: Idb66fa1728fd9bea6cd9cff639ea7f1056ae6118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180229
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [1367092fa695456c430b5d1a63dd890382b58ccf]

        sw: Rename SwFEShell::{IsObjSelected -> GetSelectedObjCount}
        
        The method returns the number of selected objects,
        not just a bool indicating whether any (or a particular)
        object is selected, other than the
        SwFEShell::IsObjSelected variant that takes a
        `const SdrObject&` param.
        
        Rename the method to make that clearer.
        
        Change-Id: I30afec5322d2e6f1d31e5bc0ca6c252faa1fb4d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180223
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [4e35cf055d3074beaef7bf573fafefe4adb2a37e]

        sw a11y: Use reference instead of pointer
        
        Change-Id: I79b7fa475642b93f15c000d6f989cf30864ce212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180222
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [8f8518cdacb8ef7aee872b2380ae3424dcb3d633]

        sw a11y: Drop VEC_PARA typedef
        
        Change-Id: I8de415d96f95f6d65c8e9fa0f03658818489821d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180221
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [b0a4f7c24a4371761d00b91e526eb4eccec3bf47]

        sw a11y: Drop local var bIsSelAll
        
        Just call IsDocumentSelAll() at the one
        place where the local var was used so far.
        
        Change-Id: Ia7b50bbb678f0186a6cb10cd9c156ac4c2b026b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180220
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-15  Noel Grandin  <noelgrandin@gmail.com>  [da758c4d15569667cc3d444ba53826b0ee5d2a90]

        convert RES_OBJECTDYING to SfxHint
        
        and remove SwPtrMsgPoolItem, which is now unused
        
        Change-Id: Ie5bedcd9855256d3ad90189db3df1ae978977e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180180
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-14  Dione Maddern  <dionemaddern@libreoffice.org>  [6ddca6f506a56ffd0d29b026de48a02cde04df60]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bdd4044b77f13aad47d233aebdd529530271b119
          - tdf#162504 Add help page for Cell Appearance sidebar panel
            
            Create new help page source/text/scalc/01/sidebar_cell_appearance.xhp
            - Add a new help page to document the features of the Cell Appearance
            sidebar panel in Calc
            - The head section from this page will be added to the Properties
            Sidebar page when help pages for all properties panels are complete.
            
            In /home/twistappel/libreoffice/helpcontent2/AllLangHelp_scalc.mk
            - Add the new help page source/text/scalc/01/sidebar_cell_appearance.xhp
            to the repository
            
            In source/text/scalc/01/05020000.xhp
            - Add variable tags to the main heading easier to make it easier embed
            in other pages.
            
            In
            /home/twistappel/libreoffice/helpcontent2/source/text/shared/01/05030500.xhp
            - Add variable and section tags to make content easier to embed in other
            pages.
            
            Change-Id: I7e61a7daea7a1759f88d6ff6cbfde4aec57da680
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180244
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a01151b4cf282fae0e775611e0a8de0d2ef6bc43]

        sc: fix copy&paste error
        
        Since
        commit 521a56d8d1e12b7471fda6b62b21d51776c9fbaf
        Author: Balazs Varga <balazs.varga.extern@allotropia.de>
        Date:   Thu May 30 18:43:09 2024 +0200
        
            tdf#137543 - Add new LET function to Calc
        
        Change-Id: I7e059457a3b31246bd5c3b903371d5f158975653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180246
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-14  Julien Nabet  <serval2412@yahoo.fr>  [88e49b25ac0269f3c50b053b881d123351e71e67]

        Typos and improvements in fr.po (wizards/scriptforge)
        
        Change-Id: Ibc073d4167e9aa755a52ddcea412039925f4c0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180187
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-14  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [c612aa8fcb7c64884b369a4c72cd56ac10c40dc6]

        Revert "remove unused #include from svtools"
        
        This reverts commit 8fb8e2fb5fc6f8059b56ef98450dff01940023c7.
        
        Reason for revert: <string_view> is used quite often in colorcfg, removing it just because it's indirectly used might cause some issues down the road like what if the file which indirectly included it removes it?
        
        Change-Id: Ibb01144a3473fa422745bf61591a9ce51268a6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180064
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0d4d178caff1414a9a21fa57f06bc8d4d2c389a]

        Change alpha behavour of OutputDevice::SetFillColor
        
        It is pretty ugly bad on several levels.
        
        Essentially what the currrent behaviour does is, if the fill color has an
        transparency value, and draw some pixels, we just don't bother to write
        anything to the color surface at all, we only write to the alpha surface.
        
        (*) It is impossible to emulate efficiently when we switch to combined
            color+alpha surfaces
        (*) It works completely differently to how every other graphics API in the
            world operates
        (*) It makes no sense - it doesn't allow you to fill a shape with partially
            transparent color pixels (because it just doesn't bother writing to the
            color surface).
        
        This behaviour dates back to "initial import", so sadly no reason why.
        
        Noting that we are changing 3 things here:
        (1) Setting a fill color with transparency will actually write to the color
            surface.
        (2) Previously, SetFillColor(COL_TRANSPARENCY) was the same as
            SetFillColor(), now they mean different things
        (3) SetFillColor(x) where x has tranparency will now actually affect the fill
            color of the alpha layer.
        (4) VirtualDevice::SetOutputSizePixel will now erase/fill the device with
            data in cases where it previously would not (because previously the
            fill was ignored when background == COL_TRANSPARENT)
        
        Change-Id: I4c8b371a436a4d1ffc4344c7d6b21932d861397d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-14  Michael Weghorn  <m.weghorn@posteo.de>  [3eaa35e8bacc19a85f5c9d907450846bfa8bffae]

        tdf#163335 qt a11y: Work around broken sw selection handling
        
        When using the qt6 vcl plugin with the Orca screen reader
        running, selecting text in Writer resulted in a crash
        due to an IndexOutOfBoundsException being thrown.
        
        Backtrace:
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            warning: 44     ./nptl/pthread_kill.c: No such file or directory
            (rr) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007f889b09ddef in __pthread_kill_internal (threadid=<optimized out>, signo=6) at ./nptl/pthread_kill.c:78
            #2  0x00007f889b049d02 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007f889b0324f0 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007f889aca1a3d in ??? () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #5  0x00007f889acb300a in ??? () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #6  0x00007f889aca15e9 in std::terminate() () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #7  0x00007f889acb3288 in __cxa_throw () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #8  0x00007f8862346900 in SwAccessibleSelectionHelper::throwIndexOutOfBoundsException (this=0x561f2f8d1910) at .../libreoffice/sw/source/core/access/accselectionhelper.cxx:72
            #9  0x00007f8862347df8 in SwAccessibleSelectionHelper::getSelectedAccessibleChild (this=0x561f2f8d1910, nSelectedChildIndex=0) at .../libreoffice/sw/source/core/access/accselectionhelper.cxx:283
            #10 0x00007f8862298e6f in SwAccessibleDocument::getSelectedAccessibleChild (this=0x561f2f8d1800, nSelectedChildIndex=0) at .../libreoffice/sw/source/core/access/accdoc.cxx:467
            #11 0x00007f8862298eaf in non-virtual thunk to SwAccessibleDocument::getSelectedAccessibleChild(long) () at .../libreoffice/sw/source/core/access/accdoc.cxx:467
            #12 0x00007f88878c6200 in QtAccessibleWidget::selectedItem (this=0x7f887c014ac0, nSelectionIndex=0) at vcl/qt6/../qt5/QtAccessibleWidget.cxx:1861
            #13 0x00007f8885f08ba0 in AtSpiAdaptor::selectionInterface (this=0x561f2b8a7070, interface=0x7f887c014ac0, function=..., message=..., connection=...)
                at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:2596
            #14 0x00007f8885f03ce1 in AtSpiAdaptor::handleMessage (this=0x561f2b8a7070, message=..., connection=...) at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1479
            #15 0x00007f888366d217 in QDBusConnectionPrivate::activateObject (this=0x7f887c00a390, node=..., msg=..., pathStartPos=27) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1448
            #16 0x00007f888366e1d0 in QDBusActivateObjectEvent::placeMetaCall (this=0x7f887c03aca0) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1604
            #17 0x00007f8886b09bb1 in QObject::event (this=0x561f2b8a7070, e=0x7f887c03aca0) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:1431
            #18 0x00007f88849e2dd0 in QApplicationPrivate::notify_helper (this=0x561f2a554ae0, receiver=0x561f2b8a7070, e=0x7f887c03aca0) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3305
            #19 0x00007f88849e6ced in QApplication::notify (this=0x561f2a541420, receiver=0x561f2b8a7070, e=0x7f887c03aca0) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3255
            #20 0x00007f8886a481b9 in QCoreApplication::notifyInternal2 (receiver=0x561f2b8a7070, event=0x7f887c03aca0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1118
            #21 0x00007f8886a48e29 in QCoreApplication::sendEvent (receiver=0x561f2b8a7070, event=0x7f887c03aca0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1558
            #22 0x00007f8886a49d68 in QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=0, data=0x561f2a56fee0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1898
            #23 0x00007f8886a48c6c in QCoreApplication::sendPostedEvents (receiver=0x0, event_type=0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1752
            #24 0x00007f88870377b1 in postEventSourceDispatch (s=0x561f2a5cce80) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246
            #25 0x00007f888d50b81f in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #26 0x00007f888d50da57 in ??? () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #27 0x00007f888d50e1c0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #28 0x00007f88870369eb in QEventDispatcherGlib::processEvents (this=0x561f2a545d00, flags=...) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399
            #29 0x00007f8886164858 in QPAEventDispatcherGlib::processEvents (this=0x561f2a545d00, flags=...) at .../qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #30 0x00007f888796a492 in QtInstance::ImplYield (this=0x561f2a5d16c0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:464
            #31 0x00007f888796d511 in QtInstance::DoYield (this=0x561f2a5d16c0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:475
            #32 0x00007f88924bd626 in ImplYield (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:385
            #33 0x00007f88924bcf3f in Application::Yield () at .../libreoffice/vcl/source/app/svapp.cxx:488
            #34 0x00007f88924bcd20 in Application::Execute () at .../libreoffice/vcl/source/app/svapp.cxx:360
            #35 0x00007f889b327b89 in desktop::Desktop::Main (this=0x7ffcd9ea1c00) at .../libreoffice/desktop/source/app/app.cxx:1679
            #36 0x00007f88924deaa6 in ImplSVMain () at .../libreoffice/vcl/source/app/svmain.cxx:230
            #37 0x00007f88924e0699 in SVMain () at .../libreoffice/vcl/source/app/svmain.cxx:248
            #38 0x00007f889b3a146a in soffice_main () at .../libreoffice/desktop/source/app/sofficemain.cxx:121
            #39 0x0000561ef2802a6d in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #40 0x0000561ef2802a47 in main (argc=2, argv=0x7ffcd9ea1e08) at .../libreoffice/desktop/source/app/main.c:49
        
        While QtAccessibleWidget::selectedItem already returns early
        if the passed selection index is too large according to what
        XAccessibleSelection::getSelectedAccessibleChildCount()
        returns, this is not enough because Writer's SwAccessibleSelectionHelper
        has an inconsistent/broken implementation:
        
        SwAccessibleSelectionHelper::getSelectedAccessibleChildCount
        returns the count of paragraphs that are (partially) selected
        by the text cursor if no other objects are selected.
        However, SwAccessibleSelectionHelper::getSelectedAccessibleChild
        doesn't take these into account and therefore throws the
        IndexOutOfBoundsException when called with any index.
        
        Temporarily (in particular for backporting to release branches),
        handle the exception in QtAccessibleWidget::selectedItem like
        other a11y bridges do (see e.g. `selection_ref_selection`
        for the gtk3 VCL plugin) to avoid the crash.
        
        The underlying Writer issue described above will be fixed in a
        separate commit (and for master only).
        
        Change-Id: I874ad4a7a9faf79492967c943517d83df5f47e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180228
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-14  codewithvk  <vivek.javiya@collabora.com>  [91a97c7d11d77935ff459679ddcacd59014771d2]

        Add unit tests for .uno:DeleteContentControl command
        
        - Added tests for deleting Rich Text, Checkbox, Dropdown, and Date content controls.
        - TODO: Add test for Picture content control.
        
        Change-Id: Icf423ab85d6a28c6c33412677fd1eb44d0ae94f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176068
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [2e498d7dba898d19ef32aac7b0cc53e074fcca3d]

        Use ErrorHandler::HandleError, instead of creating own message box
        
        Change-Id: Ib4aeb52db1d81d9e3dcc4e0c6c880be8982b8120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180219
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [94e9c45d9a82d917738f46243173b4521e1ccd09]

        we never actually erase device in SetOutputSizePixelScaleOffsetAndLOKBuffer
        
        So simplify the code.
        
        The reason this currently "works" is that we always set the
        background to COL_TRANSPARENT, and when we do that,
        the DrawRect() logic will short-circuit and do nothing.
        
        Which also means we can inline ImplSetOutputSizePixel
        into SetOutputSizePixel, since it has only one call site.
        
        Change-Id: I0ae000e187fb7d18801ccfb61d1066f71f0c6cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f1ac2464e7b7002b285bcd254b8cb21b90eb495]

        Fix typo
        
        Change-Id: Id8c9642b2b94416c271f7bd10829080ace0e9a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180205
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a41cddf0f1693eeb05032d6428f77c92cbd5a82f]

        Fix typo
        
        Change-Id: I1e9187cc2fb024bd72a1de41cffb4b01910f83b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180171
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2025-01-14  Adam Seskunas  <adamseskunas@gmail.com>  [dd386eddfdfe77c0b14cf2ed84243f066aadefb0]

        Port Query.java test to CppUnit
        
        dbaccess/qa/unit/CRMDatabase_test.cxx add test
        dbaccess/qa/complex/dbaccess remove Query.java
        dbaccess/JunitTest_dbaccess_complex.mk remove test call
        
        Change-Id: If21863de1fa4db738e3d51f93a3c7ca19130bb1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177278
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [32fd04f13ae563262fb0fcb03906ebc891151f1b]

        Use o3tl/source_location.hxx in errcode
        
        Change-Id: Ibb4ee84e74ebd501fefa12070c999e5e9da199fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180212
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-14  Michael Weghorn  <m.weghorn@posteo.de>  [44dfcebde64b9edfa9f50eace34e5e1497ab9314]

        Revert "vcl: remove unnecessary resets"
        
        This reverts commit 210f30410803113cbbd3d32062c2769b95aa8a81.
        
        Reason for revert:
        As Mike Kaganski explains in [1]:
        
        > This is technically wrong. The bitmaps must not be used when they
        > have active write access. Creation of the BitmapEx in theory may 
        > scale the bitmaps (indeed, here they are created with the same size), > which would assert on active write access.
        >
        > Se tdf#156856
        
        
        [1] https://gerrit.libreoffice.org/c/core/+/180142/comments/d55835ab_a4f52e04
        
        Change-Id: I731b7ff2b17f33f886e7113ad48e30f87e9b80d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180211
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [590157ac1584fb829b0c61905298114e7c4adfde]

        external/python: Don't package an _lzma library
        
        ...to avoid
        
        > [build CHK] CustomTarget/postprocess/check_dynamic_objects/check.done
        > instdir/program/python-core-3.11.11/lib/lib-dynload/_lzma.cpython-3.11d.so has suspicious NEEDED: liblzma.so.5
        
        as seen at least when building on a Fedora 41 machine that happens to have
        xz-devel-5.6.2-2.fc41.x86_64 installed (so that Python's configure detects
        have_liblzma=yes).
        
        The _lzma library had been added to external/python3/ExternalPackage_python3.mk
        in 892c0d2ef0ee43e079aff51dcc09572d76689ec1 "python3: update
        python3_EXTENSION_MODULES", but without giving any rationale.  (It had
        previously been removed there with c2e4e74138c0a816f6aace4d336c7d8cb611d4fa
        "Python3.5: Remove external dependencies: readline and lzma".)
        
        Change-Id: I4afe9fb08891dda116f115dac7b2f948aac84e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180194
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-13  Michael Stahl  <michael.stahl@allotropia.de>  [670e3fe7358dc69d80ed25b178cc7a2d3c76f0ee]

        poppler: try to patch out all uses of std::ranges
        
        Cloph reports it is not supported by macOS baseline XCode 14.2
        
        Change-Id: I70a2e4c3ffd91c1a41123d1fa4d371406b300cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180026
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2025-01-13  Martin Srebotnjak  <miles@filmsi.net>  [1863a27931cb20f0289e6d0b5ef546b10b42da72]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to a245529de520531329531184d0513cc5a73c8c70
          - Updated Slovenian thesaurus
            
            Change-Id: Idd56555762bd591ff719cbdf52d3212cea80ff85
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180208
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [be5e2a99039002fabe6bf8032b45350fa388b6fb]

        The protocol was already checked above
        
        Change-Id: If2ca73f043308736a4bfc3325d51aa271b07abe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [12664b7ceaf1c96943fda3f7e604465b8d34a84c]

        tdf#164686: handle exceptions from UCBContentHelper::Exists
        
        When a filename can be treated as a non-file URL, checking its existence
        may throw. This needs to be handled here.
        
        Handles '?' in the filename.
        
        Change-Id: If065c483d1a44cbbfcea21f91d72adf1fdfde579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180199
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a9bf19d0d399c2aa5356927930335d7ceddf1aea]

        tdf#164686: drop the erroneous exclusion of pdf export
        
        This partially reverts commit 25a997c15d39fb30676a375df8ea4ce1ed2e1acd
        (tdf#53530 Only show 1 error dialog instead of 3 on export to PDF,
        2022-08-29).
        
        Handles ':' in the filename.
        
        Change-Id: Ieccbbd55f5978e7dbd7b154a3e3a2df5d1cc07ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180198
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [134a7533d51b134b28afbcd4b93a24552951903b]

        tdf#164686: Check filename validity in SvtFileDialog
        
        Handles '|', '<', '>', '"' in the filename.
        
        Change-Id: Ic43bb3b08b1ccd48c691b7ca90f1fc65fed6f320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180197
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80108b903d30c7ea61d25d890f80be1a9a6f7cbd]

        loplugin:redundantcast
        
        Change-Id: I8c26a439679359553d387686d9a11718a106ef5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180181
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-13  Laurent Balland  <laurent.balland@mailo.fr>  [57d453d0f1855c42b24b78c804cdfbc92be02d7a]

        tdf#164617 Fix Vivid Impress template
        
        Change styles of objects of first slide to automatic styles.
        It preserves styles when affecting Master Page.
        
        Change-Id: I4612efed987e2a976ba493555845fb82c18c3228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180145
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2025-01-13  Michael Weghorn  <m.weghorn@posteo.de>  [9778cd8b09b03757b0462bd6780cf7500000072f]

        tdf#164127 vcl: Skip further focus processing for disposed Edit
        
        For the UNO control property browser, switching focus away
        from the property browser to the document while an Edit in the property
        browser has focus and then back to the property browser results in the
        controls of the property browsers getting disposed and new ones created
        when processing the focus event. Backtrace of how the Edit gets
        disposed (for the "Name" edit):
        
            1 VclReferenceBase::disposeOnce vclreferencebase.cxx 37 0x7f62fdb3d82a
            2 VclPtr<vcl::Window>::disposeAndClear vclptr.hxx 207 0x7f62fd6aebc5
            3 VclBuilder::disposeBuilder builder.cxx 831 0x7f62fd68ca34
            4 VclBuilder::~VclBuilder builder.cxx 823 0x7f62fd68c8c7
            5 VclBuilder::~VclBuilder builder.cxx 822 0x7f62fd68cba9
            6 std::default_delete<VclBuilder>::operator() unique_ptr.h 93 0x7f62fd748b78
            7 std::__uniq_ptr_impl<VclBuilder, std::default_delete<VclBuilder>>::reset unique_ptr.h 205 0x7f62fd77c9f8
            8 std::unique_ptr<VclBuilder, std::default_delete<VclBuilder>>::reset unique_ptr.h 504 0x7f62fd77bf4d
            9 SalInstanceBuilder::~SalInstanceBuilder salvtables.cxx 7578 0x7f62fe038f8a
            10 SalInstanceBuilder::~SalInstanceBuilder salvtables.cxx 7573 0x7f62fe038fe9
            11 std::default_delete<weld::Builder>::operator() unique_ptr.h 93 0x7f62dcf9a3ab
            12 std::__uniq_ptr_impl<weld::Builder, std::default_delete<weld::Builder>>::reset unique_ptr.h 205 0x7f62dd101868
            13 std::unique_ptr<weld::Builder, std::default_delete<weld::Builder>>::reset unique_ptr.h 504 0x7f62dd0f7a5d
            14 pcr::CommonBehaviourControl<com::sun::star::inspection::XPropertyControl, weld::Entry>::clear_widgetry commoncontrol.hxx 150 0x7f62dd15ad8d
            15 pcr::CommonBehaviourControl<com::sun::star::inspection::XPropertyControl, weld::Entry>::disposing commoncontrol.hxx 156 0x7f62dd1552d5
            16 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7f6304f3db00
            17 cppu::PartialWeakComponentImplHelper<com::sun::star::inspection::XPropertyControl>::dispose compbase.hxx 90 0x7f62dd1545b5
            18 pcr::(anonymous namespace)::lcl_implDisposeControl_nothrow browserlistbox.cxx 678 0x7f62dcf9f864
            19 pcr::OBrowserListBox::Clear browserlistbox.cxx 694 0x7f62dcf9c8d1
            20 pcr::OBrowserListBox::~OBrowserListBox browserlistbox.cxx 324 0x7f62dcf9c717
            21 o3tl::default_delete<pcr::OBrowserListBox>::operator() deleter.hxx 46 0x7f62dcfae757
            22 std::unique_ptr<pcr::OBrowserListBox, o3tl::default_delete<pcr::OBrowserListBox>>::~unique_ptr unique_ptr.h 399 0x7f62dcfae54f
            23 pcr::OBrowserPage::~OBrowserPage browserpage.cxx 38 0x7f62dcfae348
            24 std::default_delete<pcr::OBrowserPage>::operator() unique_ptr.h 93 0x7f62dd136577
            25 std::unique_ptr<pcr::OBrowserPage, std::default_delete<pcr::OBrowserPage>>::~unique_ptr unique_ptr.h 399 0x7f62dd13373f
            26 pcr::OPropertyEditor::PropertyPage::~PropertyPage propertyeditor.hxx 43 0x7f62dd1336ed
            27 std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>::~pair stl_pair.h 284 0x7f62dd1341a9
            28 std::destroy_at<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>> stl_construct.h 88 0x7f62dd134185
            29 std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>>>::destroy<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>> alloc_traits.h 593 0x7f62dd1340b5
            30 std::_Rb_tree<unsigned short, std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>, std::_Select1st<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>>::_M_destroy_node stl_tree.h 621 0x7f62dd1340b5
            31 std::_Rb_tree<unsigned short, std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>, std::_Select1st<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>>::_M_drop_node stl_tree.h 629 0x7f62dd134051
            32 std::_Rb_tree<unsigned short, std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>, std::_Select1st<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>>::_M_erase stl_tree.h 1934 0x7f62dd133f9e
            33 std::_Rb_tree<unsigned short, std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>, std::_Select1st<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>, std::less<unsigned short>, std::allocator<std::pair<unsigned short const, pcr::OPropertyEditor::PropertyPage>>>::clear stl_tree.h 1251 0x7f62dd1371e5
            34 std::__cxx1998::map<unsigned short, pcr::OPropertyEditor::PropertyPage>::clear stl_map.h 1183 0x7f62dd136e25
            35 std::map<unsigned short, pcr::OPropertyEditor::PropertyPage>::clear map.h 573 0x7f62dd132b68
            36 pcr::OPropertyEditor::ClearAll propertyeditor.cxx 62 0x7f62dd130570
            37 pcr::OPropertyBrowserController::stopInspection propcontroller.cxx 839 0x7f62dd0e7e58
            38 pcr::OPropertyBrowserController::impl_rebindToInspectee_nothrow propcontroller.cxx 916 0x7f62dd0e94be
            39 pcr::OPropertyBrowserController::inspect propcontroller.cxx 246 0x7f62dd0e9c1a
            40 pcr::FormController::setFastPropertyValue_NoBroadcast formcontroller.cxx 190 0x7f62dd06dcca
            41 cppu::OPropertySetHelper::setFastPropertyValue propshlp.cxx 524 0x7f6304f873a8
            42 cppu::OPropertySetHelper::setPropertyValue propshlp.cxx 264 0x7f6304f859bb
            43 basctl::PropBrw::implSetNewObject propbrw.cxx 303 0x7f62e8b185db
            44 basctl::PropBrw::ImplUpdate propbrw.cxx 501 0x7f62e8b16549
            45 basctl::PropBrw::Update propbrw.cxx 64 0x7f62e8b15f4a
            46 basctl::DialogWindowLayout::UpdatePropertyBrowser baside3.cxx 1256 0x7f62e89e805b
            47 basctl::DialogWindow::UpdateBrowser baside3.cxx 599 0x7f62e89e8009
            48 basctl::Shell::Activate basides1.cxx 1602 0x7f62e8a0669a
            49 SfxShell::DoActivate_Impl shell.cxx 326 0x7f630301e7a3
            50 SfxDispatcher::DoActivate_Impl dispatch.cxx 600 0x7f6302fc9bc8
            51 SfxViewFrame::DoActivate viewfrm.cxx 1197 0x7f63036313f4
            52 SfxApplication::SetViewFrame_Impl app.cxx 261 0x7f6302e4e59e
            53 SfxViewFrame::SetViewFrame viewfrm.cxx 3731 0x7f63036313ad
            54 SfxViewFrame::MakeActive_Impl viewfrm.cxx 2332 0x7f63036365e4
            55 SfxFrameWindow_Impl::EventNotify frame2.cxx 108 0x7f63035c383c
            56 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            57 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            58 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            59 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            60 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            61 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            62 DockingWindow::EventNotify dockwin.cxx 581 0x7f62fd778931
            63 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            64 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            65 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            66 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            67 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            68 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            69 Control::EventNotify ctrl.cxx 253 0x7f62fd939845
            70 TabControl::EventNotify tabctrl.cxx 1618 0x7f62fda32eac
            71 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            72 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            73 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            74 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            75 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            76 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            77 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            78 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            79 VclScrolledWindow::EventNotify layout.cxx 2181 0x7f62fd79e326
            80 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            81 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            82 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            83 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            84 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            85 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            86 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            87 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            88 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            89 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            90 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            91 vcl::Window::EventNotify event.cxx 213 0x7f62fd77eec7
            92 Control::EventNotify ctrl.cxx 253 0x7f62fd939845
            93 vcl::Window::CompatNotify window.cxx 3943 0x7f62fd8cae40
            94 vcl::Window::GetFocus window.cxx 1855 0x7f62fd8cb109
            95 Edit::GetFocus edit.cxx 1838 0x7f62fd94ab69
            96 vcl::Window::CompatGetFocus window.cxx 3903 0x7f62fd8d602f
            97 vcl::Window::ImplGrabFocus mouse.cxx 384 0x7f62fd8052c7
            98 vcl::Window::GrabFocus window.cxx 2990 0x7f62fd8c4a67
            99 vcl::Window::ImplAsyncFocusHdl winproc.cxx 2059 0x7f62fd8eb787
            100 vcl::Window::LinkStubImplAsyncFocusHdl winproc.cxx 2033 0x7f62fd8eb5ad
            101 Link<void *, void>::Call link.hxx 101 0x7f62fd8f39e1
            102 ImplHandleUserEvent winproc.cxx 2285 0x7f62fd8efbe1
            103 ImplWindowFrameProc winproc.cxx 2849 0x7f62fd8ecb1a
            104 SalFrame::CallCallback salframe.hxx 311 0x7f62fe4ad65c
            105 SalGenericDisplay::ProcessEvent gendisp.cxx 66 0x7f62fe4d596f
            106 SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const salusereventlist.cxx 119 0x7f62fdff0d7d
            107 SalUserEventList::DispatchUserEvents salusereventlist.cxx 120 0x7f62fdff0c56
            108 SalGenericDisplay::DispatchInternalEvent gendisp.cxx 51 0x7f62fe4d58c5
            109 SalX11Display::Yield saldisp.cxx 1860 0x7f62f3910ad4
            110 DisplayYield saldisp.cxx 321 0x7f62f3905b2f
            111 (anonymous namespace)::YieldEntry::HandleNextEvent saldata.cxx 559 0x7f62f390169c
            112 SalXLib::Yield saldata.cxx 655 0x7f62f3900f09
            113 X11SalInstance::DoYield salinst.cxx 193 0x7f62f391df3d
            114 ImplYield svapp.cxx 385 0x7f62fe0bdd46
            115 Application::Yield svapp.cxx 488 0x7f62fe0bd65f
            116 Application::Execute svapp.cxx 360 0x7f62fe0bd440
            117 desktop::Desktop::Main app.cxx 1679 0x7f6306f27f39
            118 ImplSVMain svmain.cxx 230 0x7f62fe0df1c6
            119 SVMain svmain.cxx 248 0x7f62fe0e0db9
            120 soffice_main sofficemain.cxx 121 0x7f6306fa181a
            121 sal_main main.c 51 0x55f5d611da6d
            122 main main.c 49 0x55f5d611da47
        
        As a consequence, the subsequent call to
        
            GetSettings().GetStyleSettings().GetSelectionOptions();
        
        in Edit::GetFocus (s. frame 95 above) triggers a crash
        because the `mpWindowImpl` of the disposed Edit is null.
        
        To prevent this, check whether the Edit is disposed
        after the call to vcl::Window::GetFocus and return
        early if that is the case.
        
        For the property browser, that restores the behavior from
        before
        
            commit b2b43e83ccc41c37bad32a4dcf07ca86bf2f8a15
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 7 15:42:57 2023 +0200
        
                a11y: Call base class impl at beginning of Edit::GetFocus
        
        , where the app doesn't crash, but the previously focused
        "Name" edit no longer has focus after switching back and forth
        (as it has actually been replaced by a new edit).
        (The cursor blinks once in the edit, then disappears.)
        
        Without being familiar with the underlying property browser
        logic, it's unclear to me whether the underlying problem there
        could be solved in a better way, e.g. whether skipping the
        logic for the `OwnPropertyId::INTROSPECTEDOBJECT` case in
        FormController::setFastPropertyValue_NoBroadcast (s. frame 40 above)
        could be skipped if the previously inspected object (`m_xCurrentInspectee`)
        is already the same as the "new" object to inspect (`_rValue`)
        or whether that logic is required to ensure displayed values get
        updated in specific scenarios where they might have changed
        in the meantime.
        
        Change-Id: I0e441fe9f5dfb487bf832206bcdec08d87e7ae2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180168
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-13  Miklos Vajna  <vmiklos@collabora.com>  [7d4222d0088f22a68941d2e910fe50bd10e8bdfe]

        cool#10630 doc electronic sign: fix insertion of the signature line
        
        Have electronic signing configured in the LOK client, try to insert a
        signature line, you'll get a certificate picker, while we don't have a
        cert during esign.
        
        What's in fact needed for creating the signature line is just a name
        (previously extracted from the certificate), we can survive the lack of
        actual certificate.
        
        Fix the problem by adding a new External parameter to
        .uno:InsertSignatureLine to hint that the certificate chooser should not
        be opened, instead the editor name (used for comments already) should be
        used. Add a new CertificateOrName in svl/ and use that in all places
        where previously we wanted a certificate but in fact it's enough to have
        a certificate or a name to create the signature line.
        
        The name on the signature line is just visual feedback, the actual name
        on the crypto signature is still not based on untrusted used input.
        
        Change-Id: Ib7008112a8e28a9e7d9649745e6021dd6b6b9c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180193
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fe1a096573c6757dc7962658a23939a3cf77c251]

        loplugin:external
        
        Change-Id: I2ffa24ce53cec9e395023e78bfea6786235e48dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180182
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-13  Michael Stahl  <michael.stahl@allotropia.de>  [8ec4fd8fe58c1c10100be43c0a94c0b2e06aa626]

        sw: tweak assert in SwFlowFrame::IsKeep()
        
        There is a slight inconsistency that causes this to trigger in kde84547-1.doc
        
        For text frames, IsHiddenNowImpl() needs to be called because that is
        what SwContentFrame::MakeAll() is calling.
        
        (regression from commit cd8468bcba952ab9b0d6ca97152a63d7469a9209)
        
        Change-Id: Icb8cb238b8460c07b99a6479cb78c523494f7248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180172
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-01-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5cbbebc85320a9c1b1810c2b27f0b8ed58cd65a3]

        Remove RecentFilesStringLength
        
        ...unused since 6efdd1444810e132ba37379dd39afa6a3220f541 "tdf#41775 copy the
        Start Center menubar to the default menubar on macOS"
        
        Change-Id: Ibfc1d822c6e114bba42fdf8b235a1de49af78141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180183
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [d4f932ba98bee4cd88dee14769334df5939ac71b]

        boost: upgrade to 1_87_0
        
        * external/boost/0001-Add-a-comma-before-ellipsis-in-constexpr_swap.patch.2
        has been fixed upstream
        
        * Add external/boost/armv7.patch.0 based on following patches:
        - https://github.com/boostorg/interprocess/commit/f58e968f13e693ffaa78fb283972e8598dc48c9f
        - https://github.com/boostorg/unordered/commit/07f6463c1c302c5b1d28aa253e0b768e71c90235
        - https://github.com/boostorg/json/commit/57d42f07158b8ea4a713378c90d22b28ca4787f8
        - https://github.com/boostorg/outcome/commit/83e5127dd20b15e3f59059e5862e9926283fee80
        to fix the problem described in 4f60246a1de68f7b47713ff926902791abe7a9ca
        "Revert "boost: upgrade to 1_87_0" for now to unbreak android arm32
        build"
        
        <https://dev-www.libreoffice.org/src/boost_1_87_0.tar.xz> has been generated (on
        Debian 12) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.87.0/source/boost_1_87_0.tar.bz2
        > $ printf 'af57be25cb4c4f4b413ed692fe378affb4352ea50fbe294a11ef548f4d527d89 boost_1_87_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_87_0.html>
        > boost_1_87_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_87_0.tar.bz2
        > Unpacking boost_1_87_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_87_0.tar.xz ...
        > Cleaning up ...
        > efd6d4ce7e8571ba87f77a30bee2d3dd8dccd306721351464fc6998dd00b0c8c  boost_1_87_0.tar.xz
        > Done.
        
        Change-Id: I4bb14ba60f0b19c4908a0ffbdc66cc23c1b2581e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180169
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [6bfe8335c83fd9e5fd1b8c02a7d31650caa56279]

        Simplify and improve getMSPaperSizeIndex
        
        Previously, it required for some reason, that in order to be found,
        the new paper size must be better than the previous-best, in *both*
        dimensions. Thus, if the previous-best e.g. matched one dimention
        perfectly, but not the other, no better match could be found.
        
        Change-Id: Ia8cd4fd98f324c8450577859dbdd21831b66e2e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180164
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-13  Laurent Balland  <laurent.balland@mailo.fr>  [cdca03a54d0a1619e24b70822d05b2e82cc2cd25]

        tdf#164617 Fix Yellow Idea Impress
        
        Change styles of objects of first slide to automatic styles.
        It preserves styles when affecting Master Page.
        
        Change-Id: Ifa60225aff25ebdae9ed65b5f65a2d7f906cd442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180146
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2025-01-13  Aron Budea  <aron.budea@collabora.com>  [202332062d245fe394f01236cb56e04083e01141]

        tdf#164123 Changing language on a selection of cells resets formatting
        
        Change-Id: I580ef23d19a62e2074e098e84e5b50831a6705cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180016
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins

2025-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [1ad1b3e833742f4e2018586a6e00d274e87b7a73]

        tdf#164434: svgio: Add unittest
        
        Change-Id: Id66f344c785f1771debcc8bd2e09c8a04da4c989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180165
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [bf7b45c2dea9fda943b3878e25d051ec1c5b19fa]

        Use o3tl::convert
        
        Change-Id: Ie877cbee77752aaa30346c78b4f5b836f0ec44d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180161
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-13  Miklos Vajna  <vmiklos@collabora.com>  [444179c7e14d1d0d1ffadd905a6c7c5961ce6e6d]

        svx: prefix members of SvxOle2Shape
        
        See tdf#94879 for motivation.
        
        No problem with _ suffixes, but parent SvxShape uses m_ prefixes, so
        switch to that here as well for consistency.
        
        Change-Id: I7a1f8630c5281c629a5b02ffe51fd9df208602dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180153
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-13  Noel Grandin  <noelgrandin@gmail.com>  [c239b6cad271d20f443482bc8b6039b1734d18f2]

        convert RES_ATTRSET_CHG to SfxHint
        
        Change-Id: I45e30282fed0dbd5423c777d3dfa0aa3315619fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180029
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [42025cc3072fd4288ccefdf264dec843e23448a3]

        Fix dxcanvas::DeviceHelper::getPhysicalResolution
        
        XGraphicDevice::getPhysicalResolution returns pixel per millimeter
        (offapi/com/sun/star/rendering/XGraphicDevice.idl). The claculation
        was wrong (multiplying by 25.4 instead of dividing) since commit
        3161cf3741e045092d342f9752b61b9b36eee056 (INTEGRATION: CWS
        dxliberate01 (1.1.2); FILE ADDED, 2027-11-01).
        
        Change-Id: I92f33347d48c48c37d02c767fcadcf35d1271e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180152
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-13  Jean-Pierre Ledure  <jp@ledure.be>  [db6a6efdc49df054826e9019ebe955282de929a7]

        ScriptForge add french translation of system messages
        
        	modified:   wizards/Package_scriptforge.mk
        	new file:   wizards/source/scriptforge/po/fr.po
        
        Change-Id: I4cb0c93c2c8b335d8319835a383255e02b9b04ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180143
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-13  Noel Grandin  <noelgrandin@gmail.com>  [91abc3df612f287c13dc4ae827be3325014e8dcb]

        prevent stale SwNode objects from reporting wrong value in GetIndex
        
        Sometimes we end up in situations where a SwNode(BigPtrEntry) is still alive,
        but has been removed from the SwNodes(BigPtrArray) data structure.
        And then we call SwNode::GetIndex and it reports a bogus value.
        
        So clear those back-pointers to avoid reading incorrect data.
        
        Change-Id: I95d4f99bf169eeb1c3290432ff8b64ca0aa69275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180126
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d59aa7ddfdcb9a37655ce60cffd4187ce509102c]

        Adapt compilerplugins to recent LLVM 20 trunk change
        
        <github.com/llvm/llvm-project/commit/cfe26358e3051755961fb1f3b46328dc2c326895>
        "Reapply '[clang] Avoid re-evaluating field bitwidth'"
        
        Change-Id: Ic31d5cd8251d0f83e7589e2f00e3c34789c75bad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180150
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-13  Christopher Sherlock  <chris.sherlock79@gmail.com>  [210f30410803113cbbd3d32062c2769b95aa8a81]

        vcl: remove unnecessary resets
        
        Change-Id: I68c0e7693ee6f2df64189957807a8a367bb1d122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180142
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c22cb6f2a566232c57194eadb02f46aebda4c3ca]

        pdfium: add support for reading the structure tree
        
        + add test for reading the tree
        
        Change-Id: I2f0e9d1852d20b3aa20ec0bcdd3ebc65370d15dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180124
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-13  Aron Budea  <aron.budea@collabora.com>  [899d87a844c2aa2990df4a9268008960d8489379]

        Slightly more informative logging
        
        Change-Id: Ia474a208d5a562e424df76ff389cfcc4e3f2b1fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179817
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2025-01-13  Patrick Luby  <guibmacdev@gmail.com>  [6efdd1444810e132ba37379dd39afa6a3220f541]

        tdf#41775 copy the Start Center menubar to the default menubar on macOS
        
        The ShutdownIcon class on macOS handles the menubar for when there are
        no windows displayed. So copy the entire menubar's tree to a native
        menu and use that native menu as the default menubar.
        
        Note: not all menu items may crash without a C++ window so currently
        the Tools > Configure menu must force the Start Center window to
        reappear before displaying its dialog.
        
        Change-Id: I3190da0dffdd6c7181939aec71954e067689d081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179980
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-01-12  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [e146f49704ef535c9ddd74338783e7c38390bf59]

        stronger typing for SwClient::GetRegisteredIn" and fix SwIterator cast
        
        * and fixes UBSAN by iterating over WriterListeners in GetInfo/SwClientNotify for safe casting
        
        Change-Id: If564111ac9529dc18daf1b5a30ac355023331b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179663
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [823e1c1c367ef159f56ae9c36c3bd0ac1aa21b82]

        cid#1638656 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1638657 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I866cb3f7550260c0dd14e14beb94144348665226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180134
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [74358a0f500a5f102791a55ac9e090df0c236488]

        tdf#164284 - Prevent page name change during page move
        
        Change-Id: I341c5b9baf7cc39b8d543df89b4c46a59bf2a9e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180138
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-01-12  Jean-Pierre Ledure  <jp@ledure.be>  [b86e078d791e337fed2e42fb79fa3c58ff413d83]

        ScriptForge (SF_Calc new XRectangle property
        
        The
           XReetangle(rangename)
        property returns a com.sun.star.awt.Rectangle
        structure describing the coordinates (in pixels)
        on the screen where the given range is
        located.
        
        This opens the door to effective interactivity
        in calc sheets with the use of popup menus.
        
        Example:
           r = calc.XRectangle("B2")
           menu = CreateScriptService("PopupMenu", , _
                   X := r.X + r.Width/2, Y := r.Y + r.Height/2)
        initializes a popup menu centered on the given
        cell.
        
        The property exists in Basic and Python.
        The SF_Calc help page should be updated
        according to the actual patch.
        
        Change-Id: I2a97c5c7b5bf84d36a2aab5e4b822e30c9d53d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180140
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [52a0fe737166a0abef534b377d4108d2b4167c1d]

        Use %PRODUCTNAME in UI and add a11y to dialog
        
        + LibreOffice name was hard-coded in dialog, change to %PRODUCTNAME
        + Add a11y in extnded tips.
        
        Change-Id: Ie32c9913124f7d230c3e72a7acef3f76c314f462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180094
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2025-01-12  Laurent Balland  <laurent.balland@mailo.fr>  [c22fb96ce78f0f527134a0a73ded636746bea5a6]

        tdf#164617 Fix Forestbird Impress template
        
        Change styles of objects of first slide to automatic styles.
        It preserves styles when affecting Master Page.
        
        Change-Id: I664679a2772a45bee9afa46ad027553cdf060704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179975
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2025-01-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2d9287144195ca68976caf3891e218d5330f49b6]

        add Abkhaz (ab) langaugepack
        
        Change-Id: I100b6c5b34d9c377ab2458dda1cf9af14767c6f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179892
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-01-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [02a20c026349d8ec245c1e095b2f8d079ecb261a]

        pdf: add PDF 2.0 support for /Em and /Strongstructure element
        
        Add support to PDF export to handle /Em (Emphasis) and /Strong
        structure element and fallback to /Span if the PDF version is not
        PDF 2.0.
        
        Use /Em if "Emphasis" char style is used and /Strong if "Strong
        Emphasis" char style is used.
        
        Change-Id: I33d572748592bb20c7daf55716d1f2cc3e6bd989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180123
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3f254da09abe02478bf4de7a27d5def67470a6f5]

        pdf: add PDF 2.0 support for /Title structure element
        
        Add support to PDF export to handle /Title structure element and
        fallback to /P (paragraph) if the PDF version is not PDF 2.0.
        Then add /Title structure element in writer if the style name of
        the paragraph is "Title".
        
        Change-Id: Ia8faab09bf3c97423d154deb7f1eb69860ce857a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180122
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [635f9d8542a3104420e6051be95957db83ef37c1]

        cid#1638655 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7d6ab24fb8d295a9e21a475e850374ba7d2becf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180133
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c1373091fbe7611fc2efc213a39fc20134b8d50]

        Remove duplicated entry
        
        Change-Id: If327c8df23c40a25d8a4fe99dc5e97aca2a2b31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180119
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-01-12  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [169aea06cc84bcfb012a9a50e935479b889ad976]

        tdf#164374 - Fix Edit comments in navigator creates new comment
        
            - Create new comment on same position for online
            - This will fix the edit comment problem described in Bug 164374
        
        Change-Id: If0aae9ad1e59eae8c7c09c72e8d7b0df5dbb38bf
        (cherry picked from commit 0cce452b93ce657e4baedb5b1574184b32e950e3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179884
        Tested-by: Jenkins
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>

2025-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [c61ffc7089d74c0cb59a7b393d5a6b295fe5a54b]

        Simplify a bit
        
        Change-Id: I7a20b8e9ffa99c2010ff656dda2758abdb17e1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180135
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-12  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [05a075d23eb6003849e75582e12ef788e615a56d]

        tdf#160051 PDF export: Artifact present inside tagged content
        
        If a PDF file containing artifacts is added to a document as an image,
        and the document is then exported as a tagged PDF, these artifacts are
        placed into a structure element (e.g., figure), which is not allowed.
        This fix removes unnecessary artifact tags from the content stream.
        
        Change-Id: I590ebec9a7aecdaa42520008824469bc8a9ff65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180041
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [029540bf5f31397cf5467c822869e22c0d90b2c0]

        crashtesting: assert on reloading .docx output of fdo60683-2.odt
        
        maybe since:
        
        commit 8cb4db941f91cc234dd18c61f8b1e51f65360d1f
        CommitDate: Wed Aug 31 08:29:49 2022 +0200
        
            tdf#30731: Improve caret travelling in Writer
        
         #3  0x00007ffff74dabf0 in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) () at /lib64/libstdc++.so.6
         #4  0x00007fffce3e97b3 in std::clamp<int> (__val=@0x7ffffffe52b4: 1897, __lo=@0x7ffffffe51f0: 1900, __hi=@0x7ffffffe51e8: 1897)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/stl_algo.h:3625
         #5  0x00007fffce3e41ff in GetTextArray
             (rDevice=..., rStr='x' <repeats 200 times>..., rDXAry=std::__debug::vector of length 0, capacity 0, nIndex=1875, nLen=25, nLayoutContext=std::optional = {...}, nMaxAscent=0x7ffffffe5680, nMaxDescent=0x7ffffffe5678, bCaret=true, layoutCache=0x0) at core/sw/source/core/txtnode/fntcache.cxx:763
         #6  0x00007fffce3e2a47 in SwFntObj::GetTextSize (this=0x6134340, rInf=...) at core/sw/source/core/txtnode/fntcache.cxx:1734
         #7  0x00007fffce461147 in SwSubFont::GetTextSize_ (this=0x6281450, rInf=...) at core/sw/source/core/txtnode/swfont.cxx:1039
         #8  0x00007fffce1f953c in SwFont::GetTextSize_ (this=0x6281450, rInf=...) at sw/source/core/inc/swfont.hxx:321
         #9  0x00007fffce2234e2 in SwTextSizeInfo::GetTextSize (this=0x7ffffffe6b80, nLayoutContext=std::optional = {...}) at core/sw/source/core/text/inftxt.cxx:439
         #10 0x00007fffce2f2217 in SwTextPortion::GetTextSize (this=0x62a3d40, rInf=...) at core/sw/source/core/text/portxt.cxx:586
         #11 0x00007fffce250b8c in SwTextCursor::GetCharRect_ (this=0x7ffffffe6fc8, pOrig=0x7ffffffe81c8, nOfst=..., pCMS=0x7ffffffe6e20) at core/sw/source/core/text/itrcrsr.cxx:956
         #12 0x00007fffce24d978 in SwTextCursor::GetCharRect (this=0x7ffffffe6fc8, pOrig=0x7ffffffe81c8, nOfst=..., pCMS=0x7ffffffe6e20, nMax=20604)
             at core/sw/source/core/text/itrcrsr.cxx:1281
         #13 0x00007fffce1f08c1 in SwTextFrame::GetAutoPos (this=0x6259250, rOrig=SwRect = {...}, rPos=SwPosition (node 28, offset 1897)) at core/sw/source/core/text/frmcrsr.cxx:430
        
        Change-Id: I8230c9cbb99126b513bea38517b1dbfac5a50f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180131
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-11  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [30ea093fd65f5fb4807a6aa88b88c82130dfd719]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ia1d2686020bdf8aae38f487e2468953cd0a389c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180109
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-11  Jean-Pierre Ledure  <jp@ledure.be>  [7fdaeef4c5dcee68dd104851662eea9cf9aea59e]

        ScriptForge (SF_Array) fix the list of methods
        
        The Methods() method returns the list of methods
        present in each class.
        
        It is unused so far (vs. Properties() is used
        in the code) => a wrong list has no
        consequences. It is however reserved for
        future use.
        
        The list was incomplete in Array class.
        
        Change-Id: I3e0522d6669d2732c68e52e4021ffb5c8a3fb108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180127
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2025-01-11  Noel Grandin  <noelgrandin@gmail.com>  [b29e161488f0291f381f04e2533106321f357c1e]

        make the ScanlineFormat values more explicit
        
        instead of cleverly deciding that one format is actually another
        format, depending on the current state of the supportsBitmap32()
        call, just have explicit values that say what the actual format is.
        
        This patch should have no functional affect, but will make
        upcoming patches simpler.
        
        Change-Id: I07f127a3e36800aa4cee034261c2e1216d8e8da1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180089
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-11  Jean-Pierre Ledure  <jp@ledure.be>  [e0935e73bb906fa143db349706466173ca11a626]

        ScriptForge - Upgrade to version 25.8
        
        Hard-coded version numbers are modified
        from 25.2 to 25.8.
        
        Many changes in po files due to the alphabetical
        sequence of keys after the introduction of the
        new "case-sensitive" keys feature.
        Before this the dict.Keys() method delivered
        the keys as an array in the order of creation.
        
        No effect on actual user scripts.
        
        Change-Id: Iee0c48eca22d17ad892278398c9125912b8b2b3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180120
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b6d9da0e53bad06562536248280384f17671c1d4]

        Fix typos
        
        Change-Id: I6a4bd79a974a4408db19874625422731739fba70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180113
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [758ea7adf410af8a95976b5bb01c7b909a0b5590]

        Fix typo
        
        Change-Id: Icfa717f28ea589161632d3cad978da4f4b105fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180117
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0a8118009ae0b4d5f1a9dbecee9dcb921db9a0a6]

        Fix typo
        
        Change-Id: I295787301985e9209e4b9397e638869bee1d4ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180115
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [98c08942863198d9f9b6f38b38e39c7d012df6b7]

        Fix typo
        
        Change-Id: Iaf3fa835b43e8272b4bceaf4cfe6104fd1cd7e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180114
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [46332200961363706f5b1f280e813510d7e1c265]

        Fix typo
        
        Change-Id: I60c92b959f114b2cb6131fc7f271f002fd793709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180116
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2025-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [808c09b917e2e508c95a28668eb8c3c0bfa74763]

        Fix typo
        
        Change-Id: I36544984d78ac8e5c4ebe33c5702f39709bc5d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180118
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-11  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [92d3bd58a12c01316ef5704ecaa8e4294e5d68c6]

        Improvement to conditional formatting naming
        
        Previously, the menu and submenu of conditional formatting options were technically correct but not very readable. We replaced 'Condition...' with 'Highlight cells with...'.
        
        Change-Id: I9f4c30506fee9b698f95608ace72f37dfd80f2b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168238
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 18d295cb585c8dbed1860d10c1c22c10a15bee14)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168445
        Tested-by: Jenkins
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>

2025-01-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f3fc477dab60f4f1c741b4453b4d0d34d00a46ba]

        pdf: change StructElement to enum class, move out of PDFWriter
        
        Moves the StructElement out of PDFWriter and changes it to enum
        class. This makes it mroe type safe, easier to search and more
        clear what type we are using.
        
        Change-Id: Icf469319a01f58397b131c3517bc75fba4072500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179977
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [de0023b819e56d696e2e20bcb766d536ecf41427]

        pdf: add /AFRelationship entry for attached files
        
        Setting the value as /Source for attached files as they are the
        files added are the original source ODF file. This is optional for
        PDF 2.0 but needed for PDF/A-4f.
        
        Change-Id: Ib8ef8844d8ab93411149438902bb3ad8961be9af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179976
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-11  Noel Grandin  <noelgrandin@gmail.com>  [d334e7da3013392549694cd7dd3dd326a0387f19]

        fix import BGRx image from PDF
        
        bug introduced in
            commit 45c753aff6468b9761e68bc0bf48ab161cd0cba6
            Author: Miklos Vajna <vmiklos@collabora.co.uk>
            Date:   Fri Sep 28 12:30:01 2018 +0200
            svx: pdfium's FPDFImageObj_GetBitmapBgra() is not needed after all
        
        Although the confusion was understandable, since the previous commit
        which had introduced FPDFImageObj_GetBitmapBgra, which, despite
        its name, actually returned RGB* data
        
        Change-Id: I762f1e963d64b4243e21e26cab31c05f4903af49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [96ed0ae5e35fbcf0f97a5dc8b6dff211579be893]

        tdf#164620 CRASH: selecting all and deleting
        
        regression from
            commit 73a46895c5927d68a222b13dc811ea1cceb811a1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Dec 5 07:58:44 2024 +0200
            tdf#119840 speed up SearchForStyleAnchor
        
        We are dealing with a dangling pointer here, so I'm not sure if this
        change will be sufficient.
        We are very deep inside a series of listener callbacks and events here,
        so no idea how to fix the actual problem i.e. not having a dangling
        pointer at all.
        
        Change-Id: I8314cd0f906e3b2652e10e55dfe8396abdf02856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-11  Michael Weghorn  <m.weghorn@posteo.de>  [bd7029c28db18592041eaebf36542586f4d73434]

        tdf#130857 qt weld: Support Calc "Move/Copy Sheet" dialog
        
        Declare support for Calc's "Move/Copy Sheet" dialog that shows
        up when right-clicking on a sheet in the bottom tabbar showing
        sheets and selecting the "Move or Copy Sheet" context menu entry.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: Ibabfd1188a21c2d6b50595b8133ef297e995642d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180088
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-11  Michael Weghorn  <m.weghorn@posteo.de>  [ceeb93657bdc1a232d99c8e0a061590408722ac1]

        tdf#130857 qt weld: Traverse widget hierarchy to detect child focus
        
        Actually traverse the hierarchy instead of
        looping infinitely in
        QtInstanceWidget::has_child_focus when the
        initial `pParent` doesn't have focus.
        
        Change-Id: I91daad8c39b21f7874fc6bc77c5ae868f44a301c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180086
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c154b79b580c7c9a7802b4a95ccfdc83d498eb3b]

        tdf#94193: add missing SecureCustomProperties
        
        Change-Id: I777f5094058135bf438545a558074e9ebacdb743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180110
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-11  Shantanu Oak  <shantanu.oak@gmail.com>  [1624ac0d58c2d8208a2c67e9f192661e21291393]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d12cf2e15fafeaaaa56330ca8812f15b1c060b08
          - Add Punjabi & Oriya
            
            Change-Id: I2d25d1bd617e4628a1b376c837b8cd40efa1cb00
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180106
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-11  Noel Grandin  <noelgrandin@gmail.com>  [9e8e01c54826995c92667b52faffe1d8113c7c80]

        fix debugging unit tests under macOS 15.2
        
        as of macOS 15.2, trying to debug a unit test will fail because
        "env" is hardened and we were calling that around our actual
        executable. But we don't need that, since we already pass in the
        required stuff via a command that is inserted before the call to
        lldb.
        
        Change-Id: I4caa91d8ef45326375aa86944b0cee9799acaa59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [c9ae567c791bcffdc3fff9e3fb11b46275a13d2b]

        python3: get python.exe from extern
        
        Instead of downloading nuget.exe and then python.exe
        as explained in https://lists.freedesktop.org/archives/libreoffice/2025-January/092881.html,
        Add python.3.12.8.nupkg to extern and download it as a tarball
        to unzip it in external/pythonx86.
        find_python.bat will look for python.exe in external/pythonx86/tools
        
        Downloaded from
        https://globalcdn.nuget.org/packages/python.3.12.8.nupkg?packageVersion=3.12.8
        
        Change-Id: Ib1638fa66b3983048c2f9a472d00ce365602fcbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180078
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Patrick Luby  <guibmacdev@gmail.com>  [3eb7cdd6eca9ee557282e9f11f27958fed395617]

        tdf#35361 Add a Quick Look plugins for .od* files on macOS
        
        Implement simple Quick Look plugins that generate a preview and/or
        thumbnail image using Apple's latest Quick Look APIs. The approach
        is to load and render any thumbnail images that may have been
        embedded in .od* files when they were last saved.
        
        Fortunately, LibreOffice, OpenOffice, and NeoOffice have been
        saving thumbnail images by default in .od* files since at least
        the mid-2000s so this approach should work with most unencrypted
        .od* files.
        
        Note: the plugins appear to work in unsigned builds using the
        following steps to enable them:
        
        1. Install LibreOfficeDev.app from an unsigned .dmg (e.g. nightly
           master builds) but the plugins in instdir/LibreOfficeDev.app
           in a local build are not usable.
        
        2. Launch LibreOfficeDev.app to register the plugins.
        
        3. Launch the System Preferences application, navigate to the
           Login Items & Extensions panel, and in the Extensions section,
           click on the icon next to the Quick Look entry to see a list of
           installed extensions.
        
        4. If macOS has successfully found and loaded the plugins, there
           should be two extensions listed under LibreOfficeDev. If they
           are disabled, enable both.
        
        5. Press Command-Option-Escape, select the Finder in the dialog
           that appears, and press the Relaunch button.
        
        The Finder should now display the thumbnail images in .od* files.
        
        Change-Id: I094afbc56b684cc85b12ed996e060818bfe8ad46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178393
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-01-10  Michael Weghorn  <m.weghorn@posteo.de>  [a47ee4efce589f2b6d8178d2a70d2440ef10e0f7]

        cpdb: Print name of the key that was actually set
        
        Print key of the `key` local variable, which is
        the one used in the iteration and which gets passed
        in the PPDContext::setValue call above, instead of
        using `pKey` that was assigned further above but
        is generally unrelated here.
        
        Change-Id: Ifdb86b5848dc2d7f0027a3960f43914ea143c018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180082
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-10  Michael Weghorn  <m.weghorn@posteo.de>  [e148db3deebeaccae5c2b255fde2645d764a42d8]

        vcl: Drop unused PPDParser forward declaration
        
        Unused since
        
            commit 003a3d7a55d9f83d5b68800d54fdac633b4c281a
            Date:   Tue Nov 26 17:08:25 2013 +0200
        
                No more uses of printer built in fonts
        
        Change-Id: Idd3e2b0e8a8a2d3e70d194d5ceecbf46924e9638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180081
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-10  Michael Weghorn  <m.weghorn@posteo.de>  [8166df9e833d410537cdd48e49ff3a182cf2eae9]

        vcl: Make PPDValueType an enum class
        
        Change-Id: I94e52914acb29374f4dd1b6ea9c725a12b521416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180080
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-10  Michael Weghorn  <m.weghorn@posteo.de>  [b6b3f7c0b09f11c7d9b4f4040ea23ed7e0e2559f]

        vcl: Drop PPDParser friend class PPDContext
        
        It doesn't make use of any non-public members, so doesn't
        need to be a friend.
        
        Change-Id: Ie1cb98f32cf87a9e1f3328ac0b0f5f9bf1130f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180079
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-10  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [9304f13db61dc101ff1c121277c344a472c2951a]

        ITEM: Refactor ItemType
        
        ItemType is useful and faster than RTTI. Until now it was
        implemented by a 16-bit member in the base class, plus
        (potentially) all constructors having to hand a value
        in at item construction type (of type SfxItemType) to
        get that member set correctly.
        
        This works, but there is no reliable way to guarantee
        coverage, and there have already been cases with missing
        SfxItemType - these fallback to '0' and thus all Items
        with ItemType() == 0 are assumed equal and might be
        static_cast'ed to the wrong classes. Note that I
        identified *35* Items that had no correct ItemType
        set/implemented actually. It also uses 16-bit per
        incarnated Item at runtime.
        
        I thought and realized now a more systematic approach
        to do that with a pure virtual function at the Item
        itself. That can also be secured by a clang compiler
        plugin in the future to keep it working. It uses one
        virtual function per derived class, no longer space
        in incarnated Items. Also the constructors will get
        more simple again.
        
        But the main aspect is security - we cannot afford
        Items potentially being held as equal if they are not.
        
        Unfortunately C++ does not offer something like a
        'strict pure virtual function' that would force to
        be overloaded in every derivation, but the used
        methotology and adding a clang test is reasonably
        safe.
        
        Have now done the cleanup of previous method.
        
        Change-Id: I04768285f1e9b73d64b0bb87df401944b5d35678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180017
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-01-10  Michael Stahl  <michael.stahl@allotropia.de>  [77e536c61a20cbf77207dbf599a88bd21e8ecc27]

        sw: clean up Start/EndAction in SwViewShell hierarchy
        
        SwViewShell and SwCursorShell both have non-virtual
        StartAction()/EndAction()?
        
        Also, StartAllAction()/EndAllAction() can just be on the base class.
        
        Change-Id: Ieaf88bb746b2479f44a635e4fd917fc91efb51a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180072
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-10  Miklos Vajna  <vmiklos@collabora.com>  [d925b64ac552348e3862a6b8b61ecd751a8f3a9e]

        cool#10630 lok doc sign: allow setting the size of the Impress sign line
        
        Insert a signature line in LOK mode when PEM certs are configured,
        moving the just inserted shape works (even in the read-only PDF view),
        but you can't resize the shape.
        
        This is because moving goes via .uno:TransformDialog, while resizing
        uses .uno:MoveShapeHandle.
        
        Fix this similar to moving, by allowing the operation when the shape is
        a just inserted signature line. Allowing the command in read-only mode
        is meant to be safe, since the command implementation again checks if
        the resize is allowed, and there we allow this only for signature lines.
        
        Also expose the "is signature line" info on the LOK API, so it can show
        the graphic selection handles conditionally (only when resize will be
        allowed).
        
        Change-Id: Ie85aa1211564758dc24ff83b4241de78a8e69ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180065
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-10  Michael Weghorn  <m.weghorn@posteo.de>  [9dd21ea57a8e098f994a4c65d299480f5211a18e]

        tdf#164037 Check property exists before accessing it
        
        Only call XPropertySet::getPropertyValue with
        PROPERTY_STANDARD_THEME if the property set actually
        has such a property.
        
        This amends
        
            commit 2bf3cada925ca49e3ac6a249ec6c342954739986
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 2 15:09:54 2024 +0200
        
                tdf#153343 Show settings for the actual default font in control properties
        
        Otherwise, calling XPropertySet::getPropertyValue triggers
        an UnknownPropertyException in OPropertySetHelper::getPropertyValue
        for the tdf#164037 sample macro dialog and the actual font
        properties are not shown in the dialog.
        
        Backtrace of how UnknownPropertyException gets thrown:
        
            1   cppu::OPropertySetHelper::getPropertyValue                                                  propshlp.cxx             276  0x7fc251385a68
            2   non-virtual thunk to cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&)                                     0x7fc251385bac
            3   pcr::ControlCharacterDialog::translatePropertiesToItems                                     fontdialog.cxx           232  0x7fc210c32b15
            4   pcr::FormComponentPropertyHandler::impl_executeFontDialog_nothrow                           formcomponenthandler.cxx 2839 0x7fc210c4ccde
            5   pcr::FormComponentPropertyHandler::onInteractivePropertySelection                           formcomponenthandler.cxx 1435 0x7fc210c49abd
            6   pcr::OPropertyBrowserController::Clicked                                                    propcontroller.cxx       1259 0x7fc210cf3352
            7   pcr::OBrowserListBox::buttonClicked                                                         browserlistbox.cxx       540  0x7fc210b9f19c
            8   pcr::OBrowserLine::OnButtonClicked                                                          browserline.cxx          383  0x7fc210b969e0
            9   pcr::OBrowserLine::LinkStubOnButtonClicked                                                  browserline.cxx          380  0x7fc210b9631d
            10  Link<weld::Button&, void>::Call                                                             link.hxx                 101  0x7fc24a462971
            11  weld::Button::signal_clicked                                                                weld.hxx                 1557 0x7fc24a43e78c
            12  SalInstanceButton::ClickHdl                                                                 salvtables.cxx           2955 0x7fc24a40f9b8
            13  SalInstanceButton::LinkStubClickHdl                                                         salvtables.cxx           2943 0x7fc24a40ef0d
            14  Link<Button *, void>::Call                                                                  link.hxx                 101  0x7fc249d154b1
            15  Button::Click()::$_0::operator()() const                                                    button.cxx               130  0x7fc249d0cd02
            16  std::__invoke_impl<void, Button::Click()::$_0&>(std::__invoke_other, Button::Click()::$_0&) invoke.h                 61   0x7fc249d0ccd5
            17  std::__invoke_r<void, Button::Click()::$_0&>(Button::Click()::$_0&)                         invoke.h                 111  0x7fc249d0cc85
            18  std::_Function_handler<void(), Button::Click()::$_0>::_M_invoke                             std_function.h           290  0x7fc249d0cbad
            19  std::function<void()>::operator()                                                           std_function.h           591  0x7fc249d36f1e
            20  Control::ImplCallEventListenersAndHandler                                                   ctrl.cxx                 311  0x7fc249d350db
            ... <More>
        
        Change-Id: I2d34c2152238e2439e24e561435d6d6b5a1a985a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180073
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-10  Gabor Kelemen  <kelemeng@gnome.hu>  [facb2bb11ff0644cbe33d1b29a33730973335725]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 542ec4ede3c0d1ce2ffc99e41762d85b5a5d14a2
          - tdf#161411 Add detailed list of allowed PDF password characters
            
            Change-Id: Ib41cb8b6e3795858dc1daecc974cf9b2170517e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180005
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [04585baf973742b0a400b53209391a99ae959d99]

        wsl-as-helper: fix extracting zxing tarball (dangling symlinks)
        
        git-bash/msys tar fails when trying to extract the zxing tarball because
        it contains dangling symlinks and MSYS doesn't create symlinks by
        default.
        
        Change-Id: I51f3bb9e2a8cf5395b3fa314f3ac1d10b8873da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179948
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2025-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [6b6f8ca3dd4aa145519f5961f822435607d0e1d1]

        Factor out and simplify COM-safe wait
        
        Before commit 1e2e51607a163021ef1fb1fb0d217266bd448173 (Try to use
        CoWaitForMultipleHandles magic to handle COM message loop, 2025-01-10)
        osl_waitCondition didn't adjust the timeout value in the COM message
        processing loop. The abovementioned commit started to use a function
        that pumps the message loop itself, but the code for manual pumping
        wasn't removed (it has (likely) became dead).
        
        This drops the dead code, and deduplicates the rest.
        
        Change-Id: I0f7bbf8220792fbe42178c2689a065b5f38645d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180069
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-10  Patrick Luby  <guibmacdev@gmail.com>  [0dfecee85589abfb94d9fa0cc8129c4fdbaf696c]

        Related: tdf#163126 fix failure to restart print job
        
        Commit 09484a1befd41681276cc9909b3228e5bf28a76e caused restarting
        a print job to fail when either the "Print selection only" or
        the "Brochure" checkboxes were changed.
        
        Also, that same commit added logic to handle empty paper names
        but setting the paper size would sometimes fail for standard
        paper names so always set the paper size if the width and
        height parameters are valid no matter what the paper name is.
        
        Change-Id: Ia6bcbffca1152ba0c47309d0c208686d2d1b30e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180036
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2025-01-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6eb1a3c4b08f004c074dac41dee31bacb38216a5]

        tdf#146947 - UI: Ability to show/reveal characters being typed into
        
        password prompt to decrypt a document.
        
        Add toggle buttons for showing and hiding password characters in
        password textbox entries.
        
        Change-Id: Iba69d303431c2f9f2c987c67fcbd3f36b42dc057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179889
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-10  Akshay Kumar Dubey  <akshaymani513@gmail.com>  [c56556448a47a41b2a1dfbb070dadc051b34d351]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I2dc10e68da2bd573615f7c36e6261d8db209bfc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180050
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c10a2c4cbab82001e1a3f17afc2fcaaad045f63]

        tdf#164621: sw_uiwriter3: Add unittest
        
        Change-Id: Id1c03461676f1a68e2917c0a5f4c22073a0b7fc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180067
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c382de68c8bfd24af62c9979d6fceb4094d2405d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e9d43a7d1d12b7e9dcfbf8b54b8d50b0cba7b78
          - Simpler solution for no javascript browsers.
            
            Avoid previous flashing warning
            
            Special thanks to Christian Lohmaier for the tip.
            
            Change-Id: Iead34d14f12c5f670645adbcf28f4ab96d625477
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/180024
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-10  Ashwani kumar  <ashwani1235kumar@gmail.com>  [fb5af8b6b8bf02de61e858bc661c08c6d94d32a8]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: I3085a272cda147f64df750e5d9b29368b72b4ec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180025
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [61cb7921a09cffb4f95b36985ecd8acc083b8138]

        sw: silence C6011 warning
        
        C: /cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sw/source/core/layout/fly.cxx(1337): error C2220: the following warning is treated as an error
        C: \cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sw\source\core\layout\fly.cxx(1322) : warning C6011: Dereferencing NULL pointer 'this->Lower()'. : Lines: 1232, 1234, 1235, 1237, 1243, 1244, 1245, 1246, 1247, 1248, 1249, 1250, 1251, 1252, 1258, 1259, 1269, 1258, 1270, 1272, 1274, 1290, 1291, 1292, 1294, 1296, 1297, 1298, 1299, 1301, 1305, 1306, 1307, 1310, 1312, 1315, 1322
        Change-Id: If50b0dfb63fe241c46577fa0f7afce1597ec73cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180063
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Shantanu Oak  <shantanu.oak@gmail.com>  [73579fd69e25fed764337f3aa1c5e3ca15b20137]

        Add Marathi autocorrect
        
        Change-Id: If26014164a3fad771006245e7c52c33394133067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180047
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Marco Pinto <marcoagpinto@sapo.pt>

2025-01-10  Miklos Vajna  <vmiklos@collabora.com>  [a10d5191b62822b96b247e0c95d8be735cc4feed]

        cool#10630 lok doc sign: allow setting the pos of the Impress sign line
        
        Open a PDF in LOK mode, insert a signature line, try to drag the
        selected signature widget/shape, nothing happens.
        
        Given that the inserted shape has a default position at page center, you
        typically want to adjust that default position, but that requires adding
        a few exceptions, since PDFs are normally read-only. Desktop Impress
        gets around this since commit 5d296183072dc7cfe7a9985c38388b56f37d873c
        (sd signature line: allow move / resize of shape before signing,
        2020-06-26), but LOK clients want to rather dispatch an UNO command
        (instead of handling this in the mouse event handler), so this requires
        additional work.
        
        A first problem is in isCommandAllowed() in desktop/ that explicitly
        rejects the UNO command for read-only documents: allow this when a
        signature widget is selected.  A second problem is in
        SdrEditView::SetGeoAttrToMarked(), check for the signature widget there
        as well.
        
        Given that the implementation of .uno:TransformDialog already has a set
        of flags to prevent doing anything for read-only documents, it looks
        safe to allow the execution of the command itself.  The size of the
        widget should be also possible to modify, that's not yet done here.
        
        Change-Id: I92a60717e98ac33f7a1eb9770cd0c7903f60759c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180049
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [1e2e51607a163021ef1fb1fb0d217266bd448173]

        Try to use CoWaitForMultipleHandles magic to handle COM message loop
        
        A customer reports a freeze problem, with the call stacks seemengly indicating
        a shuck COM re-entry, even though osl_waitCondition should be prepared for COM
        re-entry. The two relevant threads are:
        
        1. VCL Main
        
          win32u.dll!NtUserMsgWaitForMultipleObjectsEx()
          user32.dll!RealMsgWaitForMultipleObjectsEx()
          combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2156
          [Inlineframe] combase.dll!ModalLoop(CSyncClientCall *) Line 164
          combase.dll!ClassicSTAThreadWaitForCall(CSyncClientCall * pClientCall, WaitForCallReason reason, unsigned long dwRetryTimeout) Line 172
          [Inlineframe] combase.dll!ThreadSendReceive(tagRPCOLEMESSAGE *) Line 7355
          [Inlineframe] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5900
          combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5459
          [Inlineframe] combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE *) Line 1542
          [Inlineframe] combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext *) Line 565
          combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 547
          combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 783
          combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 655
          combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 2002
          rpcrt4.dll!NdrpClientCall3()
          rpcrt4.dll!NdrClientCall3()
          [Inlineframe] combase.dll!IDataObject_RemoteGetData_Proxy(IDataObject *) Line 2082
          combase.dll!IDataObject_GetData_Proxy(IDataObject * This, tagFORMATETC * pformatetcIn, tagSTGMEDIUM * pMedium) Line 1267
          ole32.dll!CDefObject::GetData(tagFORMATETC * pformatetcIn, tagSTGMEDIUM * pmedium) Line 1316
          [Inlineframe] emboleobj.dll!rtl::OUString::indexOf(const char[13] &) Line 2030
          [Inlineframe] emboleobj.dll!GetAspectFromFlavor(const com::sun::star::datatransfer::DataFlavor &) Line 215
          emboleobj.dll!OleComponent::getTransferData(const com::sun::star::datatransfer::DataFlavor & aFlavor) Line 1556
          [Inlineframe] emboleobj.dll!com::sun::star::uno::Type::{ctor}() Line 46
          [Inlineframe] emboleobj.dll!com::sun::star::datatransfer::DataFlavor::{ctor}() Line 20
          [Inlineframe] emboleobj.dll!com::sun::star::embed::VisualRepresentation::{ctor}() Line 19
          emboleobj.dll!OleEmbeddedObject::getPreferredVisualRepresentation(__int64 nAspect) Line 372
          comphelper.dll!comphelper::EmbeddedObjectContainer::GetGraphicReplacementStream(__int64 nViewAspect, const com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> & xObj, rtl::OUString * pMediaType) Line 1430
          [Inlineframe] svtlo.dll!svt::EmbeddedObjectRef::GetGraphicReplacementStream(__int64) Line 916
          svtlo.dll!svt::EmbeddedObjectRef::GetGraphicStream(bool bUpdate) Line 690
          svtlo.dll!svt::EmbeddedObjectRef::GetReplacement(bool bUpdate) Line 486
          svtlo.dll!svt::EmbeddedObjectRef::GetGraphic() Line 524
          swlo.dll!OutHTML_FrameFormatOLENodeGrf(SwHTMLWriter & rWrt, const SwFrameFormat & rFrameFormat, bool bInCntnr, bool bWriteReplacementGraphic) Line 1652
          swlo.dll!SwHTMLWriter::OutFrameFormat(AllHtmlFlags nMode, const SwFrameFormat & rFrameFormat, const SdrObject * pSdrObject) Line 464
          swlo.dll!OutHTML_SwFlyCnt(SwHTMLWriter & rWrt, const SfxPoolItem & rHt) Line 2974
          swlo.dll!Out(SwHTMLWriter &(*)(SwHTMLWriter &, const SfxPoolItem &) * pTab, const SfxPoolItem & rHt, SwHTMLWriter & rWrt) Line 40
          swlo.dll!OutHTML_SwTextNode(SwHTMLWriter & rWrt, const SwContentNode & rNode) Line 2477
          swlo.dll!SwHTMLWriter::Out_SwDoc(SwPaM * pPam) Line 960
          swlo.dll!SwHTMLWriter::WriteStream() Line 612
          swlo.dll!Writer::Write(SwPaM & rPaM, SvStream & rStrm, const rtl::OUString * pFName) Line 236
          swlo.dll!Writer::Write(SwPaM & rPam, SfxMedium & rMedium, const rtl::OUString * pFileName) Line 250
          swlo.dll!SwWriter::Write(const tools::SvRef<Writer> & rxWriter, const rtl::OUString * pRealFileName) Line 872
          swlo.dll!SwDocShell::ConvertTo(SfxMedium & rMedium) Line 778
          sfxlo.dll!SfxObjectShell::SaveTo_Impl(SfxMedium & rMedium, const SfxItemSet * pSet) Line 1633
          sfxlo.dll!SfxObjectShell::PreDoSaveAs_Impl(const rtl::OUString & rFileName, const rtl::OUString & aFilterName, const SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 3120
          sfxlo.dll!SfxObjectShell::CommonSaveAs_Impl(const INetURLObject & aURL, const rtl::OUString & aFilterName, SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 2910
          sfxlo.dll!SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t,std::char_traits<char16_t>> aFileName, SfxItemSet & rItemSet, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 320
          sfxlo.dll!SfxBaseModel::impl_store(const rtl::OUString & sURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & seqArguments, bool bSaveTo) Line 3203
          [Inlineframe] sfxlo.dll!SfxBaseModel::storeToURL::__l7::<lambda_1>::operator()() Line 1813
          sfxlo.dll!vcl::solarthread::detail::GenericSolarThreadExecutor<`SfxBaseModel::storeToURL'::`7'::<lambda_1>,void>::doIt() Line 114
          [Inlineframe] vcllo.dll!vcl::SolarThreadExecutor::worker(void *) Line 37
          vcllo.dll!vcl::SolarThreadExecutor::LinkStubworker(void * instance, void * data) Line 32
          [Inlineframe] vcllo.dll!Link<void *,void>::Call(void *) Line 111
          [Inlineframe] vcllo.dll!ImplHandleUserEvent(ImplSVEvent *) Line 2287
          vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2851
          vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 310
          [Inlineframe] vclplug_winlo.dll!ImplHandleAppCommand(HWND__ *) Line 5496
          vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 6159
          vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 6190
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 476
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 544
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 393
          vcllo.dll!Application::Execute() Line 369
          sofficeapp.dll!desktop::Desktop::Main() Line 1605
          vcllo.dll!ImplSVMain() Line 229
          sofficeapp.dll!soffice_main() Line 94
          vText.dll!00007ff7f1bb105b()
          vText.dll!00007ff7f1bb1304()
          kernel32.dll!00007fff114b7374()
          ntdll.dll!00007fff128fcc91()
        
        2. cppu_threadpool::ORequestThread
        
          win32u.dll!NtUserMsgWaitForMultipleObjectsEx()
          user32.dll!RealMsgWaitForMultipleObjectsEx()
          sal3.dll!osl_waitCondition(void * Condition, const TimeValue * pTimeout) Line 82
          [Inlineframe] vcllo.dll!osl::Condition::wait(const TimeValue *) Line 123
          vcllo.dll!vcl::SolarThreadExecutor::execute() Line 63
          sfxlo.dll!vcl::solarthread::detail::GenericSolarThreadExecutor<`SfxBaseModel::storeToURL'::`7'::<lambda_1>,void>::exec(const SfxBaseModel::storeToURL::__l7::<lambda_1> & func) Line 103
          [Inlineframe] sfxlo.dll!vcl::solarthread::syncExecute(const SfxBaseModel::storeToURL::__l7::<lambda_1> &) Line 167
          sfxlo.dll!SfxBaseModel::storeToURL(const rtl::OUString & rURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs) Line 1813
          mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
          mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
          binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
          binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
          binaryurplo.dll!request(void * pThreadSpecificData) Line 84
          cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
          cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169
          cppu3.dll!threadFunc(void * param) Line 190
          sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67
          ucrtbase.dll!00007fff106f1bb2()
          kernel32.dll!00007fff114b7374()
          ntdll.dll!00007fff128fcc91()
        
        In fact, this is not even obvious that the problem is really re-entry; it could
        also turn out to be a call to an external COM server. I can't debug the problem
        myself, so this is just a guess.
        
        A nice summary of the problem is in https://stackoverflow.com/questions/34420920;
        my suspicion is that our MsgWaitForMultipleObjects call doesn't include some
        message types needed for proper COM message pumping, sufficiently defined as
        "a small set of special-cased messages" in COWAIT_FLAGS enumeration docs [1].
        
        Let me try if CoWaitForMultipleHandles in place of MsgWaitForMultipleObjects
        maybe resolves the issue.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/combaseapi/ne-combaseapi-cowait_flags
        
        Change-Id: I4eaac32cf08c7379a3f8b88bcdd851e70e97d757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180048
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [ab26bd699ad49c57ae90b44a0fe8c586845da2f4]

        tdf#164420 Fix unselected Check/Radio buttons not following themes in GTK
        
        The button part of the check and radio buttons wasn't using theme
        colors, because till now I couldn't figure out what css nodes/properties
        it was using. Turns out the background for the buttons uses the
        background-image property. Set that to none with separator color as the
        border color, as that seemed to be the most sensible option.
        
        We might want to theme these too some day.
        
        Change-Id: I90a7fe5965d97e1437e13fe8e2f2a277a5b82485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179486
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [8fb8e2fb5fc6f8059b56ef98450dff01940023c7]

        remove unused #include from svtools
        
        Change-Id: I34e24992fd634ff171c045f100ec328da64662b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179985
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [9051ec05066c113bde29d5c7b0a393ad923c1d99]

        Use disable color for disabled controls in GTK
        
        Change-Id: I65bb0e6353cfc8a2240c7219a66fa4a82f4707a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179410
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [d2bf91d9594e38552e030b66dfb71084d0fb2664]

        Set StyleSettings::DisableColor value in GTK
        
        Themes uses StyleSettings::DisableColor value as the default color value
        for disabled UI elements. Set it in the UpdateSettings function for GTK.
        
        Change-Id: Ida71a0aaff2e05309d9b8c03d15b3db8ed5a7aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179409
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [88975a654ca8c69d5ee1fd5146435ec08ea1a30e]

        Use different color for the window and the field in GTK
        
        Usually fields use different colors compared to the window, usually a
        lighter shade when using dark mode, and a darker shade otherwise.
        However StyleSettings::GetWindowColor and StyleSettings::GetFieldColor
        were reporting the same colors. Fixed it.
        
        Change-Id: Iadb4f66b339e82498a5b073cc55d3dfdbb88e619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179408
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-10  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [b820a2a5db707daeb7518a96bb7d3854ab71ca39]

        Fix menubar back and menu highlight reading black color from the system in GTK
        
        Themeing code gets menubar background color from StyleSettings, which
        was reported as rgba[000000ff] by the gtk code. fixed that by adding
        a background class to the menubar's GtkStyleContext.
        
        The Highlight color for menubar items and menu items was also reported
        rgba[000000ff]. Using Accent color for that for the time being.
        
        Change-Id: I605a75775f2786fe5ee7645ca707f5dd2037040d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179407
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [209bb3388a57045d575fa05eb33b98992f287fbf]

        python3: fix win arm build
        
        removed by mistake in
        commit 50524481b30d904ee4a12ef478eeae05647a465d
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Dec 17 17:25:59 2024 +0100
        
            Python: upgrade to 3.11.11 (master only)
        
        Change-Id: Ib1f79713e81238fd5c26cbbaf87e260a0a7e4f41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180032
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-10  Mohamed_Ali  <mohmedali1462005@gmail.com>  [74dacdca49304b3acef686de9c6e4bdda3643902]

        tdf#42982 Improve Error Messages with RuntimeException in UNO API
        
        Change-Id: Ib1b84374ae87d2565bf4557cc4bc6153c12978cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177150
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e87fdbb86d504d44c2417702d2edd77319a1b42c]

        external/python3: Avoid misaligned-pointer-use
        
        ...when generating Python/deepfreeze/deepfreeze.c during the build of
        ExternalProject_python3 after 50524481b30d904ee4a12ef478eeae05647a465d "Python:
        upgrade to 3.11.11 (master only)",
        
        > Objects/dictobject.c:1500:40: runtime error: load of misaligned address 0x555853494d81 for type 'PyDictUnicodeEntry *', which requires 8 byte alignment
        > 0x555853494d81: note: pointer points here
        >  00 00 00  ff ff ff ff ff ff ff ff  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00
        >               ^
        >  #0 in dictresize at workdir/UnpackedTarball/python3/Objects/dictobject.c:1500:21
        >  #1 in dict_merge at workdir/UnpackedTarball/python3/Objects/dictobject.c:2880:17
        >  #2 in _PyDict_MergeEx at workdir/UnpackedTarball/python3/Objects/dictobject.c:3003:12
        >  #3 in _PyEval_EvalFrameDefault at workdir/UnpackedTarball/python3/Python/ceval.c:3432:17
        >  #4 in _PyEval_EvalFrame at workdir/UnpackedTarball/python3/./Include/internal/pycore_ceval.h:73:16
        >  #5 in _PyEval_Vector at workdir/UnpackedTarball/python3/Python/ceval.c:6434:24
        >  #6 in _PyFunction_Vectorcall at workdir/UnpackedTarball/python3/Objects/call.c:393:16
        >  #7 in _PyObject_FastCallDictTstate at workdir/UnpackedTarball/python3/Objects/call.c:141:15
        >  #8 in _PyObject_Call_Prepend at workdir/UnpackedTarball/python3/Objects/call.c:482:24
        >  #9 in slot_tp_init at workdir/UnpackedTarball/python3/Objects/typeobject.c:7855:15
        >  #10 in type_call at workdir/UnpackedTarball/python3/Objects/typeobject.c:1103:19
        >  #11 in _PyObject_MakeTpCall at workdir/UnpackedTarball/python3/Objects/call.c:214:18
        >  #12 in _PyObject_VectorcallTstate at workdir/UnpackedTarball/python3/./Include/internal/pycore_call.h:90:16
        >  #13 in PyObject_Vectorcall at workdir/UnpackedTarball/python3/Objects/call.c:299:12
        >  #14 in _PyEval_EvalFrameDefault at workdir/UnpackedTarball/python3/Python/ceval.c:4769:23
        >  #15 in _PyEval_EvalFrame at workdir/UnpackedTarball/python3/./Include/internal/pycore_ceval.h:73:16
        >  #16 in _PyEval_Vector at workdir/UnpackedTarball/python3/Python/ceval.c:6434:24
        >  #17 in PyEval_EvalCode at workdir/UnpackedTarball/python3/Python/ceval.c:1148:21
        >  #18 in run_eval_code_obj at workdir/UnpackedTarball/python3/Python/pythonrun.c:1741:9
        >  #19 in run_mod at workdir/UnpackedTarball/python3/Python/pythonrun.c:1762:19
        >  #20 in pyrun_file at workdir/UnpackedTarball/python3/Python/pythonrun.c:1657:15
        >  #21 in _PyRun_SimpleFileObject at workdir/UnpackedTarball/python3/Python/pythonrun.c:440:13
        >  #22 in _PyRun_AnyFileObject at workdir/UnpackedTarball/python3/Python/pythonrun.c:79:15
        >  #23 in pymain_run_file_obj at workdir/UnpackedTarball/python3/Modules/main.c:360:15
        >  #24 in pymain_run_file at workdir/UnpackedTarball/python3/Modules/main.c:379:15
        >  #25 in pymain_run_python at workdir/UnpackedTarball/python3/Modules/main.c:605:21
        >  #26 in Py_RunMain at workdir/UnpackedTarball/python3/Modules/main.c:684:5
        >  #27 in main at workdir/UnpackedTarball/python3/Programs/_bootstrap_python.c:109:12
        
        Change-Id: I0bacef11b5874bca6104516a206076a0505528ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180037
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [440ef8f32f3f7deae2c9f9910bd2750a504afd54]

        Fix SwHTMLTextCollOutputInfo::HasParaToken, check for 'p', not 'P'
        
        This had apparently been broken by 73e3aafa990168aa532fa7b81fc4de8f455b10e1
        "convert HTML tags/attributes to lowercase for html export" turning the various
        OOO_STRING_SVTOOLS_HTML_... defines from upper- to lowercase, but leaving that
        single 'P' alone.  (Though it's unclear whether this makes much of a difference
        in practice.  At least none of the `make check` tests apparently change their
        behavior due to this.)
        
        Change-Id: I1411b0dd7d82237fccffdff27e4982089a1d64b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180035
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-10  Shantanu Oak  <shantanu.oak@gmail.com>  [189feae5b9974dc35f88d408402e6164ade945f4]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5b8116e5e8a1ce761f929f8dad1a91ff6ceb5ccc
          - Add Sanskrit
            
            Change-Id: Iffca4fe252cc06c79e75189ef267f6307dc63867
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180046
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-10  Shantanu Oak  <shantanu.oak@gmail.com>  [55bf40f69b8cc8dd421acf2a1426a1e4e0d041bf]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5e4bb811f8d7cbea58a3085291b43edf2f76d8be
          - Add Kannada
            
            Change-Id: I3eac267803aef6fc21722ca8226f844fb7016260
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180045
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-10  Justin Luth  <justin.luth@collabora.com>  [b3f3d1ffeca42cbe6028f81b5a07c342f84e8c88]

        tdf#164627 docx export: consolidate getWordCompatibilityMode()
        
        Solves TODO: this is duplicated, better store it as DocxExport member?
        
        It is generally useful to be able to query what compatibility mode
        the DOCX will be exported as, so calculate the value once
        and cache it.
        
        I re-arranged things a bit, and I think it is clearer now
        what is happening here.
        
        Change-Id: I5cd619e1696ecef956a54957fb57f49803e7bc67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179981
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2025-01-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [89c00618b9cee6e786fd11a7fdbf7aaf24e4fbb7]

        tdf#161411 - UI: Add Better wording for ASCII-only characters
        
        Based on the suggestions at:
        https://bugs.documentfoundation.org/show_bug.cgi?id=161411#c8
        
        Change-Id: I5d2d17e36551687d929f9529dd8e6a7d2f78ff6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180006
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2025-01-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [77fc0018f5a5e6dccdc7125c223f1f6891812b82]

        tdf#161412 - UI: fix warning in PDF password dialog didn't disappear
        
        Warning about "Only Basic Latin characters can be entered" should
        only be highlighted until we are entering non-ASCII characters into
        the password textbox.
        
        Change-Id: I87c26a3b0b1777e0e76fe12422027aa2f377ad35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179891
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-09  Shantanu Oak  <shantanu.oak@gmail.com>  [2b902859ae2d63578a5af6813708d25c66b6b353]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 7951da9434fc16d2d69e2cc0653236619eb03bd8
          - Add Assamese
            
            Change-Id: I6f222c3b90acd1aba1e3c7669e00d879dd875981
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179983
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-09  Shantanu Oak  <shantanu.oak@gmail.com>  [24ef243cd0cb21aef866c84528d0111f99f17675]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 73267e0018dceb7d4001dd35f0ed46c9f9ea245e
          - Add Tamil
            
            Change-Id: I409eb7a7af6e9440bf3412702931c9cf7d188b5d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179982
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-09  Christopher Sherlock  <chris.sherlock79@gmail.com>  [84db299b24992d1dfc2e6c99bad3a67e425c1cb5]

        vcl: flatten BlendFrameCache.cxx
        
        Change-Id: Iff5dc958c90afc82cd719176c1566413faea677e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179173
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-09  Christopher Sherlock  <chris.sherlock79@gmail.com>  [6e29421b78105e4833f9a315f24fabc62e11408d]

        vcl: flatten BlendFrameCache.cxx
        
        Change-Id: Ibf0ddd053c2e787c113a468ee75b03bb77610626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179171
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2029893863ed06b8977088b57d59a6fce3b92a1e]

        loplugin:stringconstant (in -DDEBUGPASTE-only code)
        
        Change-Id: I01f417f589393062afba2ffe0bbd07e7cf2e5344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180018
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [87c7e32ad758e7a5a2f0e364a92aacef5b410ef4]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 7eec558f0737384d5aa357ee32e9a8a6a74ac4de
          - Upgrade Mongolian dictionary to 2025.01.05
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2025.01.05.zip
            
            Change-Id: Ica44af35f96c8adf1d17987c7a3ad1d3b16e1e28
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/180021
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-01-09  AhmedHamed  <ahmedhamed3699@gmail.com>  [dc77629b31423b4df553b7e63579f15445ddeab1]

        tdf#162286 Add a category to store favorite functions in FW
        
        Change-Id: Iec0d169570ba3d29501a4917d8858a9e9438f608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171828
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2025-01-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [50524481b30d904ee4a12ef478eeae05647a465d]

        Python: upgrade to 3.11.11 (master only)
        
        Downloaded from https://www.python.org/ftp/python/3.11.11/Python-3.11.11.tar.xz
        
        * Add external/python3/replace-powershell-with-wget.patch.1
        to avoid
        
        FindPythonForBuild:
         Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure
         channel.
         At line:1 char:1
         + Invoke-WebRequest https://aka.ms/nugetclidl -OutFile
         'C:\cygwin64\home\tdf\jenki ...
         + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         ~~~
             + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt
            pWebRequest) [Invoke-WebRequest], WebException
             + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe
            ll.Commands.InvokeWebRequestCommand
        
         'py' is not recognized as an internal or external command,
         operable program or batch file.
        
        when downloading nuget.exe from https://aka.ms/nugetclidl
        using powershell. By default powershell uses TLS 1.0 and the site security requires TLS 1.2,
        so it fails with 'The request was aborted: Could not create SSL/TLS
        secure channel.'
        
        Kudos to Caolán for helping with a compiling issue.
        See https://lists.freedesktop.org/archives/libreoffice/2024-December/092830.html
        
        Change-Id: If66a88dd8f8c7774c49f8c33e9e40d2d5418e7c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178681
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-09  Jonathan Clark  <jonathan@libreoffice.org>  [b06e7814d2edbc369b7c441941c3392df1266423]

        tdf#152515 vcl: Implement Win32 vert CJK printing for all fonts
        
        Previously, vertical CJK printing was implemented on Windows by
        substituting the font with an @-prefixed alternate. This was a naming
        convention once used by Microsoft to indicate that a font is a
        specially-prepared vertical variant containing pre-rotated CJK glyphs.
        However, modern fonts don't ship these variants and cannot be printed
        correctly if this approach is used.
        
        This change deletes the @-prefix substitution. Instead, a secondary
        HFONT is used for printing upright characters, as determined by the
        shaper. This implementation should work with all fonts, and the printed
        output should now match the screen better.
        
        Change-Id: I3c474980f90ade8475073926364ab59dd9310ca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180014
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2025-01-09  Oliver Specht  <oliver.specht@cib.de>  [853ddebc0b14fedf4ae7ed9a5017dc425bd99479]

        tdf#164183 Add hyperlink entries to context menu of tables
        
        Table objects in Draw/Impress now have Open/Edit/Copy/Remove hyperlink
        entries in context menu of text in table objects.
        
        Change-Id: Id3a5346eb3227871a06d2ea7fdb3ed38c07654c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177849
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2025-01-09  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [8e48c41a218b33eafa383429995a840d08523fa1]

        tdf#154285 Check upper bound of arguments in SbRtl_Second function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Ib3a97f9acb7778c90aa1c172ca82cf450a1e792f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179249
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-09  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [7419fc569f07fbd5685a6e58439b681a52fdd045]

        tdf#154285 Check upper bound of arguments in SbRtl_Hour function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Ib372b4dfde77961e7982bd0d8f1f8598be7da726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179252
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-09  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [73dc528db8418720cdab81cfaf5a1589693a3e90]

        tdf#154285 Check upper bound of arguments in SbRtl_Month function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Ifc27af0f091c75c02d3816b83b3717fc435ad31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179250
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-09  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [633a787707786de7a535070efbd81781430395e7]

        tdf#154285 Check upper bound of arguments in SbRtl_Day function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Ic22d420f0f5596ea3a4ff9cd7e540e6c51a559ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179254
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-09  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [e08ed1d92f083cc604cb25eb284deb21016268fd]

        tdf#154285 Check upper bound of arguments in SbRtl_Year function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Iffffe3988afdc91068e85beaafc5ff1580210ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179253
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-09  Miklos Vajna  <vmiklos@collabora.com>  [1e06592574472cea476cf2d505d53c7838004fc0]

        cool#10782 vcl lok: avoid changing the current view during Yield
        
        Commit 520cc546e2940bdfbc45eab1e569bb06bab17a9c (cool#10782 sfx2 lok:
        fix bad view id on PDF export, 2024-12-20) provided a specific fix for
        one case where spinning the main loop can result in callbacks being
        emitted on the wrong view.
        
        Hunting down all the SfxViewShell::Current() calls and auditing them if
        they are problematic in practice is a large task, so it's desirable to
        handle this problem in a more generic way.
        
        Fix the problem by pushing/popping the current LOK view in
        Application::Reschedule(), which is what e.g. the framework/ status bar
        code uses during PDF export. This keeps the original problem fixed but
        is more generic.
        
        This requires storing function pointers in comphelper/, since normally
        vcl/ code can't call SfxLokHelper, since sfx2/ already depends on vcl/.
        The fix can be tested by reverting the original fix:
        git show 520cc546e2940bdfbc45eab1e569bb06bab17a9c -- sfx2|git apply -R
        and then running the testcase:
        make -C sw -sr CppunitTest_sw_tiledrendering CPPUNIT_TEST_NAME=testPDFExportViewSwitch
        which now passes even if the sfx2-level fix is not there. Keep that
        specific fix, though: the less time we assume SfxViewShell::Current()
        returns the correct view, the better.
        
        Change-Id: Ic1811ff1e67f73fa5066af775d31589136b8502a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179993
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a7dd6c1503425e1e36993a53a9a2641733412340]

        Fix typo
        
        Change-Id: I8c3c0b8f1bf41e64b89d6e2819f81dc861766c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179969
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f4abbfc92517b1566c6df1db64ba41b367c2e51e]

        Fix typo
        
        Change-Id: I0acd3e6df2654682f3dcf8554bfcd7ec0f717b33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179968
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-09  Michael Weghorn  <m.weghorn@posteo.de>  [26ebdd88a66d8b8e983572822ee8694f1fadd4d5]

        tdf#130857 qt weld: Move button prop logic to helper method
        
        Move existing logic to set push button properties
        from QtBuilder::setProperties to a separate helper
        method QtBuilder::setButtonProperties and call it right
        after creating the QPushButton.
        
        This simplifies QtBuilder::setProperties and gets rid
        of one qobject_cast there.
        
        Change-Id: If7c8ae2cc6e53923f0efd196916f847535596e93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179966
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2025-01-09  Michael Weghorn  <m.weghorn@posteo.de>  [6231f5dfdd2dc446b925b2b780052fe10461f74a]

        tdf#130857 qt weld: Set combobox entry icons
        
        Handle the `pImageSurface` and `pIconName` params
        that can be used to set icons for combobox entries.
        
        This gets used e.g. in the spell check dialog (that's
        not supported by QtInstanceBuilder yet).
        
        Change-Id: I88a39826280aedbd7a8054366c30d263090cdd96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179965
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-09  Michael Weghorn  <m.weghorn@posteo.de>  [ad29aebd689c158ab59f2c2d4f8253b0e5146a32]

        tdf#130857 qt weld: Handle "GtkComboBox" objects
        
        Handle it the same as "GtkComboBoxText" and create
        a QComboBox widget for it.
        
        This gets used e.g. in the spellcheck dialog that's
        not supported by QtInstanceBuilder yet.
        
        Change-Id: I959ecd2736a171eb44849df4405f1b4a42b5c69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179964
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-09  Michael Weghorn  <m.weghorn@posteo.de>  [41498a8ae8075b17e4df4c580c7d1ed9ff071fdc]

        tdf#130857 qt weld: Implement QtInstanceDrawingArea::set_cursor
        
        See also QtFrame::SetPointer.
        
        Change-Id: I446abcd28e0066b936724228472d466a405ce1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179963
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [400970acf4241632d084f66275161fc4b4ac1b21]

        check if non-file uris could be interpreted as a file system pathname
        
        Change-Id: If283bec44ad1d648c68a5d0f028855e09c09017e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-09  Mike Kaganski  <mike.kaganski@collabora.com>  [171acae53f7b5f4f78dd395a10c89f779cb57494]

        tdf#163083: try to release lock to avoid deadlock
        
        The minidump in the bug (https://bugs.documentfoundation.org/attachment.cgi?id=198431)
        shows these three stacks:
        
        1. VCL main thread:
        
          ntdll.dll!NtWaitForAlertByThreadId()
          ntdll.dll!RtlpAcquireSRWLockExclusiveContended()
          ntdll.dll!RtlAcquireSRWLockExclusive()
          msvcp140.dll!mtx_do_lock(_Mtx_internal_imp_t * mtx, const xtime * target) Line 103
          [Inline Frame] vclplug_winlo.dll!std::_Mutex_base::lock() Line 50
          [Inline Frame] vclplug_winlo.dll!std::unique_lock<std::mutex>::{ctor}(std::mutex &) Line 133
          vclplug_winlo.dll!CWinClipboard::getContents() Line 125
          sclo.dll!ScTabViewShell::GetClipData(vcl::Window * pWin) Line 542
          [Inline Frame] vbaobjlo.dll!ooo::vba::excel::implnPasteSpecial(const com::sun::star::uno::Reference<com::sun::star::frame::XModel> &) Line 235
          vbaobjlo.dll!ScVbaRange::PasteSpecial(const com::sun::star::uno::Any & Paste, const com::sun::star::uno::Any & Operation, const com::sun::star::uno::Any & SkipBlanks, const com::sun::star::uno::Any & Transpose) Line 2942
          mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
          mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
          reflectionlo.dll!stoc_corefl::`anonymous namespace'::IdlInterfaceMethodImpl::invoke(const com::sun::star::uno::Any & rObj, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & rArgs) Line 593
          mergedlo.dll!SbUnoObject::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 2246
          mergedlo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 36
          mergedlo.dll!SbxVariable::Broadcast(SfxHintId nHintId) Line 155
          mergedlo.dll!SbxValue::SbxValue(const SbxValue & r) Line 68
          mergedlo.dll!SbxVariable::SbxVariable(const SbxVariable & r) Line 49
          mergedlo.dll!SbxMethod::SbxMethod(const SbxMethod & r) Line 847
          mergedlo.dll!SbiRuntime::FindElement(SbxObject * pObj, unsigned long nOp1, unsigned long nOp2, ErrCode nNotFound, bool bLocal, bool bStatic) Line 3703
          mergedlo.dll!SbiRuntime::StepELEM(unsigned long nOp1, unsigned long nOp2) Line 4189
          mergedlo.dll!SbiRuntime::Step() Line 811
          [Inline Frame] mergedlo.dll!`anonymous-namespace'::RunInitGuard::run() Line 1017
          mergedlo.dll!SbModule::Run(SbMethod * pMeth) Line 1177
          mergedlo.dll!SbModule::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 776
          mergedlo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 36
          mergedlo.dll!SbMethod::Broadcast(SfxHintId nHintId) Line 2121
          mergedlo.dll!SbxValue::Get(SbxValues & rRes) Line 290
          mergedlo.dll!SbMethod::Call(SbxValue * pRet, SbxVariable * pCaller) Line 2078
          mergedlo.dll!basprov::BasicScriptImpl::invoke(const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam) Line 264
          mergedlo.dll!SfxObjectShell::CallXScript(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & _rxScriptContext, const rtl::OUString & _rScriptURL, const com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aParams, com::sun::star::uno::Any & aRet, com::sun::star::uno::Sequence<short> & aOutParamIndex, com::sun::star::uno::Sequence<com::sun::star::uno::Any> & aOutParam, bool bRaiseError, const com::sun::star::uno::Any * pCaller) Line 1545
          mergedlo.dll!SfxApplication::OfaExec_Impl::__l120::<lambda_2>::operator()(long nDialogResult) Line 1768
          [Inline Frame] mergedlo.dll!std::_Func_class<void,long>::operator()(long <_Args_0>) Line 869
          mergedlo.dll!Dialog::EndDialog(__int64 nResult) Line 1212
          [Inline Frame] mergedlo.dll!Link<weld::Button &,void>::Call(weld::Button &) Line 111
          [Inline Frame] mergedlo.dll!weld::Button::signal_clicked() Line 1508
          [Inline Frame] mergedlo.dll!SalInstanceButton::ClickHdl(Button *) Line 2941
          mergedlo.dll!SalInstanceButton::LinkStubClickHdl(void * instance, Button * data) Line 2929
          [Inline Frame] mergedlo.dll!std::_Func_class<void>::operator()() Line 869
          [Inline Frame] mergedlo.dll!Control::ImplCallEventListenersAndHandler(VclEventId) Line 311
          mergedlo.dll!Button::Click() Line 130
          mergedlo.dll!PushButton::Tracking(const TrackingEvent & rTEvt) Line 1324
          mergedlo.dll!vcl::Window::EndTracking(TrackingEventFlags nFlags) Line 341
          mergedlo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, NotifyEventType nSVEvent, bool bMouseLeave, __int64 nX, __int64 nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 715
          mergedlo.dll!ImplHandleSalMouseButtonUp(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 2353
          mergedlo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2702
          mergedlo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 312
          vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3318
          vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5876
          vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 6231
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 476
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 552
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
          mergedlo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 387
          mergedlo.dll!Application::Execute() Line 360
          mergedlo.dll!desktop::Desktop::Main() Line 1652
          mergedlo.dll!ImplSVMain() Line 229
          [Inline Frame] mergedlo.dll!SVMain() Line 247
          mergedlo.dll!soffice_main() Line 99
          [Inline Frame] soffice.bin!sal_main() Line 51
          soffice.bin!main(int argc, char * * argv) Line 49
          [Inline Frame] soffice.bin!invoke_main() Line 78
          soffice.bin!__scrt_common_main_seh() Line 288
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        2. Clipboard thread:
        
          ntdll.dll!NtWaitForAlertByThreadId()
          ntdll.dll!RtlpWaitOnCriticalSection()
          ntdll.dll!RtlpEnterCriticalSectionContended()
          ntdll.dll!RtlEnterCriticalSection()
          sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 65
          [Inline Frame] vclplug_winlo.dll!osl::Mutex::acquire() Line 63
          vclplug_winlo.dll!SalYieldMutex::doAcquire(unsigned long nLockCount) Line 148
          [Inline Frame] mergedlo.dll!comphelper::SolarMutex::acquire(unsigned long) Line 86
          [Inline Frame] mergedlo.dll!osl::Guard<comphelper::SolarMutex>::{ctor}(comphelper::SolarMutex & t) Line 144
          [Inline Frame] mergedlo.dll!SolarMutexGuard::{ctor}() Line 1340
          mergedlo.dll!TransferableHelper::getTransferDataFlavors() Line 477
          vclplug_winlo.dll!CFormatRegistrar::RegisterFormats(const com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> & aXTransferable, CFormatEtcContainer & aFormatEtcContainer) Line 145
          [Inline Frame] vclplug_winlo.dll!CXTDataObject::InitializeFormatEtcContainer() Line 648
          vclplug_winlo.dll!CXTDataObject::EnumFormatEtc(unsigned long dwDirection, IEnumFORMATETC * * ppenumFormatetc) Line 549
          ole32.dll!SetClipboardFormats(HWND__ * hClipWnd, IDataObject * pDataObj) Line 4482
          ole32.dll!OleSetClipboardInternal(IDataObject * pDataObject, IDataObject * pSourceDataObject, void * * ppDataObjectMTAAddress, const wchar_t * pszCallerPackageFullName, unsigned long pid) Line 3750
          ole32.dll!OleSetClipboard(IDataObject * pDataObject) Line 3602
          [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::onSetClipboard::__l2::<lambda_1>::operator()() Line 464
          [Inline Frame] vclplug_winlo.dll!sal::systools::RetryIfFailed(unsigned int) Line 31
          [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::onSetClipboard(IDataObject *) Line 463
          vclplug_winlo.dll!CMtaOleClipboard::mtaOleReqWndProc(HWND__ * hWnd, unsigned int uMsg, unsigned __int64 wParam, __int64 lParam) Line 541
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!DispatchMessageWorker()
          [Inline Frame] vclplug_winlo.dll!CMtaOleClipboard::run() Line 668
          vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 685
          ucrtbase.dll!thread_start<unsigned int (__cdecl*)(void *),1>()
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        3. Clipboard content changed notification thread:
        
          win32u.dll!NtUserMsgWaitForMultipleObjectsEx()
          combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2105
          combase.dll!ModalLoop(CSyncClientCall * pClientCall) Line 171
          combase.dll!ClassicSTAThreadDispatchCrossApartmentCall(tagRPCOLEMESSAGE * pMessage, OXIDEntry * pOXIDEntry, CSyncClientCall * pClientCall) Line 324
          [Inline Frame] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5704
          combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5310
          [Inline Frame] combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE *) Line 1493
          [Inline Frame] combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext *) Line 581
          combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 563
          combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 797
          [Inline Frame] combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE *) Line 674
          combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 1899
          rpcrt4.dll!NdrpClientCall3()
          combase.dll!ObjectStublessClient(void * ParamAddress, __int64 * FloatRegisters, long Method) Line 366
          combase.dll!ObjectStubless() Line 176
          [Inline Frame] combase.dll!RemoteReleaseRifRefHelper(IRemUnknown *) Line 8720
          combase.dll!RemoteReleaseRifRef(CStdMarshal * pMarshal, OXIDEntry * pOXIDEntry, unsigned short cRifRef, tagREMINTERFACEREF * pRifRef) Line 8627
          combase.dll!CStdMarshal::DisconnectCliIPIDs(unsigned long) Line 5357
          combase.dll!CStdMarshal::DisconnectWorker_ReleasesLock(unsigned long dwType, bool logEventIsActive, CObjectContext * explicitServerContext, bool performCallback, CIDObject * pIDDelayRelease, const void *) Line 4676
          combase.dll!CStdMarshal::Disconnect(unsigned long dwType, const void * callerAddressForDiagnostics) Line 4441
          combase.dll!CStdIdentity::~CStdIdentity() Line 388
          combase.dll!CStdIdentity::`scalar deleting destructor'(unsigned int)
          [Inline Frame] combase.dll!CStdIdentity::CInternalUnk::ReleaseWithCallerAddress(const void *) Line 945
          combase.dll!CStdIdentity::CInternalUnk::Release() Line 851
          [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 229
          [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::{dtor}() Line 158
          [Inline Frame] vclplug_winlo.dll!CAPNDataObject::{dtor}() Line 97
          vclplug_winlo.dll!CAPNDataObject::`scalar deleting destructor'(unsigned int)
          vclplug_winlo.dll!CAPNDataObject::Release() Line 140
          [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 229
          [Inline Frame] vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::{dtor}() Line 158
          vclplug_winlo.dll!CDOTransferable::`scalar deleting destructor'(unsigned int)
          [Inline Frame] vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::{dtor}() Line 114
          vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 330
          vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 412
          vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 699
          ucrtbase.dll!thread_start<unsigned int (__cdecl*)(void *),1>()
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        Thread #3 has locked m_aMutex in CWinClipboard::handleClipboardContentChanged, and
        tries to destroy CDOTransferable in the reference dtor. That delegates to another
        thread (not entirely clear which, but could be either thread #1 or #2); at this
        point, thread #1 is in CWinClipboard::getContents waiting for the same m_aMutex,
        and thread #2 is in TransferableHelper::getTransferDataFlavors, waiting for the
        solar mutex (locked by VCL main thread in basprov::BasicScriptImpl::invoke).
        
        This change releases m_aMutex in CWinClipboard::handleClipboardContentChanged as
        soon as it in not needed anymore. This aligns with comment several lines above,
        telling that transferables must be destroyed only outside of the mutex lock.
        
        Change-Id: I9faf254930a8913d1621f5ed504aeb369b37adfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-09  Laurent Balland  <laurent.balland@mailo.fr>  [4e8775bfa4dbdf392b0e6f89331c2ae33bd68d97]

        tdf#164617 Fix Focus Impress template
        
        Change styles of objects of first slide to automatic styles.
        It preserves styles when affecting Master Page.
        
        Change-Id: I3c54284477d6a4cd84369204a556f123b36b0ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179970
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2025-01-09  Laurent Balland  <laurent.balland@mailo.fr>  [d2c3b27a05bdb4adb8c058b1092f9d88f5e0369b]

        tdf#164617 Fix Ligths Impress template
        
        Change styles of objects of first slide to automatic styles.
        It preserves styles when affecting Master Page.
        
        Change-Id: I43b8d8354c7c7c63f1b6f460e20c6376a76dcc02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179971
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2025-01-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [325945a544f0b18fb763bfd955e196258cc70eb1]

        Fix rudimentary Emscripten Qt6 copy -> paste support
        
        ...following up on 5a4ca3ce934ca3f34669bc66b8941544aef1bc89 "Rudimentary
        Emscripten copy -> paste support" (which had addressed both Qt5 and Qt6, in
        general)
        
        Change-Id: I45dbea5cf852c126cdf0509f9cdef7218d2a8eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179962
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-08  Michael Stahl  <michael.stahl@allotropia.de>  [b57f1f7be140c5c69136e2b5c8b8826b1b27141a]

        xmlsecurity: fix --without-system-nss build
        
        signing2.cxx:71: error: undefined reference to 'NSS_OptionSet'
        
        (regression from commit f0efcb917049547ad0496c004830ff0153602071)
        
        Change-Id: Idad3f7d5d1a2cb642ac3485a750cdc7631fbf4df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179954
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [9e4114e2cc9473cc3d4cf055a3f50e6d0115a1d0]

        Simplify a bit
        
        WinLaunchChild takes the same kind of argv as execv, terminated by
        a null pointer; so no need to pass argc.
        
        Change-Id: I280c8da0c613a7d0d1a208831a87f0e4648719f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179952
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [3b89850b808803271201df9a5be8d04543b76515]

        Use o3tl::toW instead of c-style cast
        
        Change-Id: Id027978cbe6188fecafe71f6566dd8501ffdabe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179950
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-08  Michael Stahl  <michael.stahl@allotropia.de>  [e28c5a2c93477d167eb449f08eca220cb3b26b31]

        poppler: upgrade to release 25.01
        
        Fixes CVE-2024-56378
        
        - remove disable-nss-and-gpgmepp.patch.1 and instead build
          CryptoSignBackend.cc which appears to have working ifdefs now
        - run the update_pch script
        - add clang-std-rotate.patch.1 because jenkins failed
        
        Change-Id: I7fcdd10766287e83dc666041644f129378584d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179903
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [aa95ece9d8eb0c3c255a7c565e12e377660a176c]

        Revert "Revert "Revert "stronger typing for SwClient::GetRegisteredIn"" and fix SwIterator cast"
        
        This reverts commit d8e29e2697e90da6acf5858fd74d6054ed9e5aa3.
        
        Reason for revert: It causes CppunitTest_sw_rtfexport2 to fail with
        
        > /sw/inc/calbck.hxx:428:18: runtime error: downcast of address 0x6060004d0fd8 which does not point to an object of type 'sw::ClientBase<SwModify>'
        > 0x6060004d0fc0: note: object is base class subobject at offset 24 within object of type 'SwFormatHeader'
        >  00 00 00 00  90 c6 d3 ea 6e 7f 00 00  01 00 00 00 66 00 48 01  a0 11 00 00 88 be be be  10 c7 d3 ea
        >               ^                                                                          ~~~~~~~~~~~
        >                                                                                          vptr for 'sw::ClientBase<SwFrameFormat>' base class of 'SwFormatHeader'
        >     #0 0x7f6edd5beb5e in SwIterator<sw::ClientBase<SwModify>, SwModify, (sw::IteratorMode)0>::First() /sw/inc/calbck.hxx:428:18
        >     #1 0x7f6edd5b6d69 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:237:35
        >     #2 0x7f6edd5b7c45 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:259:15
        >     #3 0x7f6edd5b49c6 in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:229:5
        >     #4 0x7f6edd605e7b in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:309:19
        >     #5 0x7f6ee039738b in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2849:15
        >     #6 0x7f6edd5b8189 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:268:13
        >     #7 0x7f6edd610879 in SwFormat::SetFormatAttr(SfxItemSet const&) /sw/source/core/attr/format.cxx:604:13
        >     #8 0x7f6ee6495964 in FillHdFt(SwFrameFormat*, SfxItemSet const&) /sw/source/uibase/utlui/uitool.cxx:239:14
        >     #9 0x7f6ee64914e7 in ItemSetToPageDesc(SfxItemSet const&, SwPageDesc&) /sw/source/uibase/utlui/uitool.cxx:340:13
        >     #10 0x7f6ee43fe5b4 in SwDocStyleSheet::SetItemSet(SfxItemSet const&, bool, bool) /sw/source/uibase/app/docstyle.cxx:1894:13
        >     #11 0x7f6ee304306c in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) /sw/source/core/unocore/unostyle.cxx:3157:33
        >     #12 0x7f6ee304d9b9 in SwXPageStyle::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) /sw/source/core/unocore/unostyle.cxx:3453:5
        >     #13 0x7f6e9b369897 in writerfilter::dmapper::DomainMapper_Impl::PushPageHeaderFooter(writerfilter::dmapper::PagePartType, writerfilter::dmapper::PageType) /sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:3910:25
        >     #14 0x7f6e9b445050 in writerfilter::dmapper::DomainMapper_Impl::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:10046:13
        >     #15 0x7f6e9b101b9d in writerfilter::dmapper::DomainMapper::lcl_substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/DomainMapper.cxx:4746:14
        >     #16 0x7f6e9b877f73 in writerfilter::LoggedStream::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream> > const&) /sw/source/writerfilter/dmapper/LoggedResources.cxx:272:5
        >     #17 0x7f6e9ad35daf in writerfilter::rtftok::RTFDocumentImpl::resolveSubstream(unsigned long, unsigned int, rtl::OUString const&) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:381:14
        >     #18 0x7f6e9ad33bc1 in writerfilter::rtftok::RTFDocumentImpl::resolveSubstream(unsigned long, unsigned int) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:356:5
        >     #19 0x7f6e9ad48f49 in writerfilter::rtftok::RTFDocumentImpl::sectBreak(bool) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:705:9
        >     #20 0x7f6e9adcd3b7 in writerfilter::rtftok::RTFDocumentImpl::popState() /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:3695:13
        >     #21 0x7f6e9afd2595 in writerfilter::rtftok::RTFTokenizer::resolveParse() /sw/source/writerfilter/rtftok/rtftokenizer.cxx:2011:37
        >     #22 0x7f6e9ad4ef4f in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) /sw/source/writerfilter/rtftok/rtfdocumentimpl.cxx:844:27
        >     #23 0x7f6e9bd39f91 in (anonymous namespace)::RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/writerfilter/filter/RtfFilter.cxx:164:20
        >     #24 0x7f6ef659a6a4 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2719:34
        >     #25 0x7f6ef654cf40 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:767:23
        >     #26 0x7f6ef67df024 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1991:36
        >     #27 0x7f6ef703d0f0 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:725:28
        >     #28 0x7f6ec073ee16 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1180:37
        >     #29 0x7f6ec0735cb2 in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:415:20
        >     #30 0x7f6ec072e172 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:311:5
        >     #31 0x7f6ec0729554 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:167:14
        >     #32 0x7f6ec07fe176 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:592:16
        >     #33 0x7f6ec07fe396 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
        >     #34 0x7f6ed3d9c8c9 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:72:62
        >     #35 0x7f6ef13e8d62 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /test/source/unoapi_test.cxx:126:19
        >     #36 0x7f6ef13e7e98 in UnoApiTest::loadFromURL(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:108:5
        >     #37 0x7f6efe61e0c7 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) /sw/qa/unit/swmodeltestbase.cxx:384:5
        >     #38 0x7f6efe632c07 in SwModelTestBase::createSwDoc(char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:433:9
        >     #39 0x7f6efe0c635f in (anonymous namespace)::testAllGapsWord::TestBody() /sw/qa/extras/rtfexport/rtfexport2.cxx:771:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3418/>)
        
        Change-Id: I70bd88050887c8b6c747707f2ea3b89802c7b468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179946
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bea1ab84b2492e72579aeaf82c91ba40c2556479]

        Revert "convert RES_ATTRSET_CHG to SfxHint"
        
        This reverts commit 404fbec25740406e3b926844f3bd0f324dc38b8c.
        
        Reason for revert: It's follow-up fix bbb53997c3a6890567ee991aed8502b397dcb7a6
        "fix ubsan failure" had to be reverted (because it conflicted with a revert of
        cc56bf56e170492e414a975ad8c07c41ed72e1a4 "convert RES_OBJECTDYING to SfxHint",
        which in turn is known broken and thus needed to be reverted for now), so revert
        this known-broken commit for now as well.
        
        Change-Id: I4e65c7113e1e5bfdb9841c98bee3712a1beb12ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179941
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0d71b29e3427d2d43b45ae4cfb91bb19ec1e3158]

        Revert "convert RES_OBJECTDYING to SfxHint"
        
        This reverts commit cc56bf56e170492e414a975ad8c07c41ed72e1a4.
        
        Reason for revert: It causes CppunitTest_sw_uwriter
        CPPUNIT_TEST_NAME=SwDocTest::test64kPageDescs to fail with
        
        > /sw/source/core/attr/format.cxx:273:29: runtime error: downcast of address 0x6140000e1840 which does not point to an object of type 'SwFormat'
        > 0x6140000e1840: note: object is of type 'SwModify'
        >  00 00 00 00  b0 e1 74 97 df 7f 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwModify'
        >     #0 0x7fdf8a31ca65 in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:273:29
        >     #1 0x7fdf8d066efe in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2766:19
        >     #2 0x7fdf8a2d51f2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:231:18
        >     #3 0x7fdf8a2d2c5a in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:222:5
        >     #4 0x7fdf8a2d07bd in SwModify::~SwModify() /sw/source/core/attr/calbck.cxx:145:15
        >     #5 0x7fdf89b267c5 in sw::BroadcastingModify::~BroadcastingModify() /sw/inc/calbck.hxx:242:59
        >     #6 0x7fdf8a319f52 in SwFormat::~SwFormat() /sw/source/core/attr/format.cxx:208:1
        >     #7 0x7fdf8d064426 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2705:1
        >     #8 0x7fdf8d0644d8 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2677:1
        >     #9 0x7fdf8b42be68 in std::default_delete<SwFrameFormat>::operator()(SwFrameFormat*) const /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:95:2
        >     #10 0x7fdf8b454cc4 in std::__uniq_ptr_impl<SwFrameFormat, std::default_delete<SwFrameFormat> >::reset(SwFrameFormat*) /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:203:4
        >     #11 0x7fdf8b38aa7e in std::unique_ptr<SwFrameFormat, std::default_delete<SwFrameFormat> >::reset(SwFrameFormat*) /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unique_ptr.h:501:7
        >     #12 0x7fdf8b3434a6 in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:625:23
        >     #13 0x7fdf8abc1dd5 in SwDoc::release() /sw/source/core/doc/doc.cxx:136:9
        >     #14 0x7fdf8c2cbc16 in rtl::Reference<SwDoc>::clear() /include/rtl/ref.hxx:193:19
        >     #15 0x7fdf9102a534 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:445:16
        >     #16 0x7fdf910295bd in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:373:5
        >     #17 0x7fdf9102a728 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:363:1
        >     #18 0x7fdfda648fca in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:230:9
        >     #19 0x7fdf89b2801f in rtl::Reference<SwDocShell>::clear() /include/rtl/ref.hxx:193:19
        >     #20 0x7fdf89ac3f0c in SwDocTest::tearDown() /sw/qa/core/uwriter.cxx:1977:17
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3425/>)
        
        Change-Id: Ib4866bcfc71e2e3358a8f860cc19efa3f6349885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179925
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0c966d6f6d455d8a05de541b0ac258ecc5bef3d8]

        Revert "fix ubsan failure"
        
        This reverts commit bbb53997c3a6890567ee991aed8502b397dcb7a6.
        
        Reason for revert: It conflicts with a revert of
        cc56bf56e170492e414a975ad8c07c41ed72e1a4 "convert RES_OBJECTDYING to SfxHint",
        which in turn is known broken and thus needs to be reverted for now (see comment
        at
        <https://gerrit.libreoffice.org/c/core/+/179781/6#message-65721cd380de7681cd9ade644da755e6549e23f7>
        "convert RES_OBJECTDYING to SfxHint")
        
        Change-Id: I8212d8ca609b45a4d9399e492727b364fa0a7b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179940
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a8234e081c97fafcda009746828f3d01195fe3b]

        libpng: upgrade to 1.6.45
        
        All three patches are upstreamed.
        
        Downloaded from https://kumisystems.dl.sourceforge.net/project/libpng/libpng16/1.6.45/libpng-1.6.45.tar.xz?viasf=1
        
        Change-Id: I61d336704b96e2a25d92b4512507cc168648ddec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179930
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [e143c83b1c5a6479562adaed0086923c568d90cf]

        Simplify using designated initializers
        
        Change-Id: I73d666a0aa4a41e8e73cb701161be1da6fd59d0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179942
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f468593d901b9f4ad8e90b6e101d17e6d490b5ef]

        Close handles properly
        
        Change-Id: If8620229d41ae9b6c0a1714967a8bb6d51d3ba0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179939
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Gökay Şatır  <gokaysatir@collabora.com>  [9884f7aa793b4bacfd6780db498a2c40e7a134c1]

        In dark mode, configuration of master page is checked for auto color.
        
        This works for standart pages. But notes pages don't have a style property in their master pages.
        This commit, when libreofficeKit is active, uses corresponding standart page's master page properties for notes pages.
        
        Used only for background colors.
        
        Change-Id: Ib1115a4fbc87ecd94f9bb44b43268b9578734950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179929
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [892c0d2ef0ee43e079aff51dcc09572d76689ec1]

        python3: update python3_EXTENSION_MODULES
        
        Change-Id: Ia636690f0dd9497e62ac9fd7a1ed4d00e71cc299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179896
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0819a1e6b3518cfbca372806b706e5fb08d2dfda]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 703c344328b4751e2c6a6477323798848c5594d7
          - tdf#164549 PDF/UA requires tagged PDF
            
            + Improve "How to get"
            
            Change-Id: Iaa8591f5ff65ddb687436c1e3b18191620c36bff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179915
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-08  Michael Stahl  <michael.stahl@allotropia.de>  [aa94faf493945e854a888e809a9c5cc8d6d0b978]

        sdext: adapt xpdfwrapper to poppler 24.12
        
        Change-Id: Ia47edf2ac821e3ef5c40f7582253f894eac74060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179902
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-08  Miklos Vajna  <vmiklos@collabora.com>  [8f16b069d08bb5b17eb2220c380f7f45fa522358]

        sw: stop including .cxx files in Writer tests
        
        The remaining 2 classes are not used in multiple .cxx files, so just
        move them closer to their only user.
        
        Change-Id: I7c7b295e21ea97acf33d7f4a60a61b25788ab5c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179926
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-08  Michael Weghorn  <m.weghorn@posteo.de>  [bcc518102ac9db436b1f41be835c055aaffb74a9]

        tdf#130857 qt weld: Introduce QtInstanceToolbar
        
        Introduce QtInstanceToolbar as the native Qt implementation
        for weld::Toolbar that uses a QToolBar widget.
        
        This mostly adds the basic structure and lets Qt{,Instance}Builder
        create an instance of the class when encountering a
        "GtkToolbar" object in a .ui file.
        
        The actual logic for the QtInstanceToolbar methods
        still needs to be implemented. Calling them currently
        triggers an assert.
        
        Change-Id: I2734e5b931d5cb9608ec4d01222634a8ffada299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179883
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2025-01-08  Shantanu Oak  <shantanu.oak@gmail.com>  [11c4fb22b4dbaa2ab4f63dc3d9b44d51a4b64ecc]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 259e906688a224e25ce12c48efb5ca7037a84760
          - added Marathi hyphenation and thesaurus
            
            Change-Id: Ic6e08de69edf376612d5d4fd275baa04e68a0a5d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179872
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Marco Pinto <marcoagpinto@sapo.pt>
            
2025-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2f6f23097121a56da9bbd50f96ab5878ced0fec]

        Resolves: tdf#158669 round long currency to decimal digits in use
        
        as its predecessor did before:
        
        commit 0c85d1ee0688435ffefd8eff797e57eac9bace27
        CommitDate: Wed Jul 15 10:26:16 2020 +0200
        
            weld LongCurrencyControl
        
        Change-Id: I251c976b9b3025a0faddd0f75cd303c29b1a33c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179917
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [158e43c438049fa5d3c28dbcc3edfbfe11021aac]

        Fix naming of the argument
        
        Change-Id: Ice5ab90ddfee0e1273e0607cb1c3251b1435b6dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179924
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Oliver Specht  <oliver.specht@cib.de>  [fa9d3f5706606379f66622d51e74699b94df45d6]

        tdf#164621 Fix regression from 3e9658a201f60dee95bd1bd8421b18bf8905c308
        
        Change-Id: I1026ae18bf9bb86b506e4ef1782b9f3aa5ae7125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179874
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [b76d70338258811bb0ca516d01c6cfe7a222ca76]

        tdf#164600: Return true from IsNumeric for booleans in VBASupport mode
        
        Change-Id: Ib68f237001389c8f7b9d2771d5162a583b544b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179866
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f8ac9d3311a623fdca64583b08780ea8ebed157c]

        tdf#164599: Allow space between sign and number in VBASupport mode
        
        Change-Id: Ib9e8c8770f8c2d1b348ff032502467915829c4f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179865
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [20db60030eaa9a2bc099894d89a63808e12c7635]

        Use sal_Int32 for string length
        
        Change-Id: Ie069c20b7d91631cb3b5d39e1a52f09cc13e8a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179864
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [bb86627216f5532b6d776fafafd9e796060b57b8]

        tdf#154284: check if ImpScan found a number at all
        
        Change-Id: Iddc87bd0d04f9b0212b03d63f3177b17bb07d278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179863
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-07  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [6700b311310a94e0de8123b307275cd553bb0d9b]

        tdf#164434 Correct SvgSymbolNode SVG import
        
        The embedding cannot rely on SVG providing all
        values of x/y/w/h, so added fallbacks to real
        geometric size. Also removed double-adding
        geometry.
        
        Change-Id: I1914ed0c3e1e42ba899db4f3eb9193fd29e9c4be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179831
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2025-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [14693204260bb6e19b28ea9994d81f99166ac1cd]

        cid#1557414 Unguarded read
        
        Change-Id: I4b0bd74d0841989905dd8034a9352b6d59b40dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177189
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8b2f6b4fba6c466ed399f4f4b80e9631f13a6232]

        Fix UBSan build of ExternalProject_raptor
        
        Using an autogen.input somewhat different from what I usually use for ASan/UBSan
        builds, that caused
        
        > libtool: link: /home/sberg/llvm/inst/bin/clang -fdiagnostics-color=always -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-return=always -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize=nullability -fno-sanitize=function -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -ggnu-pubnames -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/sberg/lo-asanubsan/core/instdir/program -o .libs/rapper rapper.o  ../src/.libs/libraptor2.so -Wl,-rpath -Wl,/usr/local/lib
        > /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_vptr_type_cache'
        > /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
        > clang: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[3]: *** [Makefile:540: rapper] Error 1
        > make[3]: *** Waiting for unfinished jobs....
        > libtool: link: /home/sberg/llvm/inst/bin/clang -fdiagnostics-color=always -fsanitize=address -fsanitize-address-globals-dead-stripping -fsanitize-address-use-after-return=always -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize=nullability -fno-sanitize=function -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -ggnu-pubnames -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/sberg/lo-asanubsan/core/instdir/program -o .libs/rdfdiff rdfdiff.o  ../src/.libs/libraptor2.so -Wl,-rpath -Wl,/usr/local/lib
        > /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_vptr_type_cache'
        > /usr/bin/ld: /home/sberg/lo-asanubsan/core/instdir/program/libicuuc.so.75: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
        > clang: error: linker command failed with exit code 1 (use -v to see invocation)
        
        It appears that different configurations cause different libraries to be created
        in ExternalProject_raptor, so that's why I never ran into this before, but the
        solution is the same as in b3300387f2e14ea59c70db513a8f6eda6fe17afa "Fix UBSan
        build of ExternalProject_redland".
        
        Change-Id: I8bf955632af8c6490d9bd66a1d7dcd19b623c305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179898
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [bbb53997c3a6890567ee991aed8502b397dcb7a6]

        fix ubsan failure
        
        since
            commit 404fbec25740406e3b926844f3bd0f324dc38b8c
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Jan 4 16:20:57 2025 +0200
            convert RES_ATTRSET_CHG to SfxHint
        
        where the code is incorrectly continuing, and thus doing
        an invalid downcast
        
        Change-Id: I04f69e73fc14c7ba04ef619ef7647320931d9a51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2025-01-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5a4ca3ce934ca3f34669bc66b8941544aef1bc89]

        Rudimentary Emscripten copy -> paste support
        
        ...with two hacks, so that at least copying text from LO and pasting it back
        into LO works (instead of the copying step either hitting the
        
        >         assert(pTrans);
        
        in QtClipboard::getContents in --enable-assert-always-abort builds or doing
        nothing in --disable-assert-always-abort builds)
        
        Change-Id: I246986fa1beaf17a8390eccb404408605e121630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179894
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-07  Miklos Vajna  <vmiklos@collabora.com>  [2af0a128b509f8c372f442636a079967ff85aec0]

        sw: move ViewCallback to Library_swqahelper
        
        Towards not including .cxx files in Writer tests.
        
        Change-Id: I42c6dba93599819ff93c92444a91a7ddc29ece38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179885
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-07  Henry Castro  <hcastro@collabora.com>  [c0392315ba3691f55ddbcf205544c21f019a9b6a]

        tdf#164130: ensure valid column and row values
        
        Sometimes the range mark has not valid col/row values.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I29cf70c8c2a4e832f1ee65abac0ff55e49295fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179563
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-07  Jonathan Clark  <jonathan@libreoffice.org>  [1afdda6bca508abe56edf7968677e689b5ee07d4]

        tdf#164493 Update script change algorithm to always make progress
        
        Fixes ofz#385256118 Timeout on ImpEditEngine::InitScriptTypes.
        
        Previously, the script assignment algorithm could backtrack in certain
        cases where a script run ends with weak characters that should be
        included in the following run. Fuzz testing unearthed a case involving
        right-to-left override and a CJK combining mark, which caused the
        algorithm to make no progress and hang.
        
        The algorithm now always makes progress on each iteration.
        
        Change-Id: I4da138c51d391c152afcee2428c21dc762a2dafc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179888
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-01-07  Michael Stahl  <michael.stahl@allotropia.de>  [f0efcb917049547ad0496c004830ff0153602071]

        xmlsecurity: fix CppunitTest_xmlsecurity_xmlsec with F41 system NSS
        
            xmlsecurity/qa/xmlsec/xmlsec.cxx:102:(anonymous namespace)::testInsertPrivateKey::TestBody
            equality assertion failed
            - Expected: 1
            - Actual  : 0
        
        Just copying the NSS setup code from the other tests lets the test pass.
        
        Also sync all the copies of the setup code while at it.
        
        Change-Id: Idcaebec4dff29f37e0ed0f05d6d7d62782947325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179893
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2025-01-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [98d5b8783246aaf9b2bdf92cf69667685c21aa79]

        Update git submodules
        
        * Update translations from branch 'master'
          to c0a323a8e6bf862e47a6f93909ddef6aaaef35dc
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I5f9bfb155d155c02685c11c39083e5d13d57c9f2
            
2025-01-07  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [c007449ec38f49e18ed7d6b8f9ef74c5bd5c015a]

        tdf#164393 Change themes UI as per UX feedback
        
        - inlined the controls for color/image with the labels. also inlined
          the image stretched/tiled radio buttons.
        
        - There were plans to change the default theme's name from
          "Automatic" to "Default", but due to string freeze for 25-2,
          moved that to a separate patch which won't be backported to 25-2.
        
        Change-Id: I8470dbf1c42d1b402d17f0feeec12d190e879ca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179405
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-07  Patrick Luby  <guibmacdev@gmail.com>  [7ef881c76e656ece71cf6d1d472757edf5c1ff44]

        tdf#161480 use BmpScaleFlag::NearestNeighbor when upscaling on macOS
        
        On macOS, due to Retina window scaling, it is very common to
        have Skia surfaces that are 2 times the size of their respective
        output device sizes so upscaling is often the default state.
        
        But when upscaling bitmaps on macOS with either Skia/Metal or
        Skia/Raster, some distortion to color and/or alpha values is
        introduced and only BmpScaleFlag::NearestNeighbor will upscale
        the bitmap correctly.
        
        Change-Id: I9cf02d3acace82751fa6e114aaecf23cbbb85c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179848
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2f870ac44b28963b5f116c3f70fb697fab0317cc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00bbe2a984f64dd23c44ccc63d74021b99d4e0d4
          - Fix XML tag position
            
            Change-Id: Iab81f4d3cd86848412c53639cce5c84fc73a646d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179880
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [61c12dd1c80e4b7227a614227bb690b00feb78ad]

        tdf#164619: bite the bullet, and write the correct ODF version
        
        The problem was the inconsistency between ODF versions for the forms
        in the package and the form's content.xml. The check
        for consistency was introduced in version 5.4 in commit
        0a0f205775807d63e7f6dd910de368bb12b11a49 (tdf#105686 - fixed wrongly
        imported named expressions:, 2017-03-21). In version 7.0, commit
        9fdf8c0a5cc036ea9bd1e11dd8f2c1a6e601fae2 (Also consider saved
        exceptions when terminating parse, 2019-11-16) made the exception
        from that check fatal.
        
        Commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 (tdf#134582 sfx2:
        when storing, set Version on embedded object storage, 2020-07-10)
        started to write the embedded object versions to package manifest,
        and commit 16de54a5c47fbc4691ee099c1f7bb559a8fe11ac (tdf#138209 ODF
        export: work around forms problem in LO < 7.0, 2021-05-10) created
        an exception for forms, to workaround the problem in older versions.
        But the latter commit created the reverse inconsistency, where the
        newer versions started to write older ODF version in manifest.xml,
        but newer ODF version in content.xml.
        
        This change restores the correct version written to the manifest.
        It is already messy in the already-released versions; it doesn't
        look possible to restore sanity retroactively, so just make it
        correct from now on, and accept the problem in older versions.
        
        Change-Id: If5d07b6000b9f08b33844db48b815881bed2915b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179867
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2025-01-07  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [242b8a9540f8e019dbe82c11d989d20d3a0f0ea7]

        tdf#164393 [API CHANGE] ThemeColors refactor part 3
        
        - add functions like IsThemeEnabled(), IsThemeDisabled(), GetThemeState(),
          SetThemeState() to check/change registry (theme state) values so that
          code outside ThemeColors class remains unaffected from any API changes,
          and use enums like ENABLED and DISABLED to represent int values from
          registry.
        
        Change-Id: I6067cb5b0fa40d6c038e398229ef8ba93d26ca92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179404
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-07  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [6929168584be46583ae033c3b82574f743490c4c]

        tdf#164393 ThemeColors refactor part 2
        
        - rename IsThemeLoaded() to IsThemeCached() (similar for setter) because
          it's not loading but caching colors in ThemeColors::m_aThemeColors.
          ColorConfig_Impl::Load() loads themes.
        
        Change-Id: If65302bc77d50f637176beaac47b43dff949368b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179854
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b20d18054ca5c13376bfd723b7e442c2e011c6de]

        Move setting of LD_LIBRARY_PATH closer to invocation of cppunittester
        
        At least for a Linux build of mine, `make CppunitTest_vcl_gtk3_a11y` would fail
        with something like
        
        > workdir/LinkTarget/Executable/cppunittester X11 error: Can't open display:
        >    Set DISPLAY environment variable, use -display option
        >    or check permissions of your X-Server
        >    (See "man X" resp. "man xhost" for details)
        
        apparently because that test adds an invocation of xvfb-run to ICECREAM_RUN,
        which appeared on the command line after gb_CppunitTest_CPPTESTPRECOMMAND
        (which, on Linux, sets up LD_LIBRARY_PATH to include instdir/program), so that
        the execution of xvfb-run picked up libraries from instdir/program instead of
        from the system (at least libpixman-1.so.0, it appears), which then apparently
        caused things to not work well.
        
        So move the contents of gb_CppunitTest_CPPTESTPRECOMMAND further down on the
        command line (which then requires an invocation of `env`).  (This still leaves
        me with a `make CppunitTest_vcl_gtk3_a11y` that fails in a different way now,
        but that's something for another day...)
        
        Change-Id: Ic53dd8f87e3fa548a998363f5489819a02b2bf8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179862
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-07  Miklos Vajna  <vmiklos@collabora.com>  [fa5be641bc0ad23ed51fb1702a157878cc3ecb04]

        cool#10630 doc sign: fix Impress sign line, to be able to finish signing again
        
        Open a PDF for signing on the desktop, insert a signature line, click
        the "finish signing" button on the infobar, Draw first asks if you want
        to save your modified document as ODG, then crashes.
        
        The first problem is that opening a PDF for signing and adding a
        signature line / visual signature didn't result in a modified doc model,
        but that now happens since commit
        aca32a55456aa4e907b216fb490b3c15d26c3d55 (tdf#146547 sfx2: allow
        read-only documents to be modified, 2023-06-16). Probably we want to
        keep this feaature that read-only documents can be modified in some
        cases, so explicitly mark the PDF document as not-modified before
        signing in SfxObjectShell::SignDocumentContentUsingCertificate().
        
        The other problem is that visual signing tried to reload the document:
        this is handy, as it shows if our PDF export worked correctly, but
        reloading is problematic since the signing code moved to async and it
        assumes that the underlying object shell is never deleted, so callbacks
        can have a pointer to it without worrying about the lifecycle. Fix this
        problem by not reloading, but clearing the marker on the signature shape
        and invalidating the signature status, instead of reloading, in
        SfxObjectShell::ExecFile_Impl().
        
        With this, visual signing of an existing PDF file works again in desktop
        Draw.
        
        Change-Id: I743983947d4607aa06674a1329bc8efb5af8a6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179856
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [410653b9f654a0a265fffbb79c0bac0205b52278]

        crashtesting: raw & exported unescaped to xl/externalLinks/externalLink1.xml
        
        seen on reimport of xlsx export of forum-mso-en4-136321.xlsx as:
        
        XmlFilterBase::importFragment - XML parser failed in fragment 'xl/externalLinks/externalLink1.xml'
        com.sun.star.xml.sax.SAXParseException message: "[xl/externalLinks/externalLink1.xml line 2]: xmlParseEntityRef: no name
        
        Change-Id: I71f2d5b01905349bedff7c66fc4b087358569bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179845
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-07  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [c398498fe155790a8e6510353427ffa5224343ac]

        tdf#164393 ThemeColors refactor part 1
        
        - Use a single `ThemeColors::VclPluginCanUseThemeColors()` check instead of
          `ThemeColors::IsThemeLoaded()` and then checking if the current scheme
          is Automatic or not
        
        Change-Id: I96294c3b4b75b5f2cee02c72a8b0dd1a85bedec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179853
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-07  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [7970a121a83653474e696550f91c5e7b963674e8]

        tdf#164393 Format the code to make clang-format happy
        
        Change-Id: I1a07935757752c64e86e779a6f3b3c925774c6d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179852
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-07  Shantanu Oak  <shantanu.oak@gmail.com>  [c8aca254f9dc01d7523cc08b41f8d1b4b5b9cb36]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e7b61087d7d42eba51425eae74643ea5623c574a
          - Add Marathi & Bengali
            
            Change-Id: I18bfa668abba41b9ac494584dbca7a40920e2e6b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179851
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [758dbc24ddc84b44147e3473144d74567c3ec64a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 072df4685038ef66c35df633e7966529e63032d1
          - Fix typo
            
            Change-Id: Ie9d34a859f5eba2d2fdb993c3fc1c0328a99a1ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179847
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-01-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [481e230e834c903e7ec0f045c20039910ad894ed]

        tdf#162246 use main ViewShell when synching the annotations
        
        Current ViewShell is not always available, but we use the main
        ViewShell most of the time anyway in AnnotationManager, so use
        that when annotation synching. Use only the current ViewShell
        when opening the annotation pop-up window.
        
        Change-Id: Ibbc8e0859d0b91617577148e76e8293cb8015941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179849
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d3afb7acebc023340aef5d70d4f35cecb359cd54]

        tdf#164529 support annotation selection with edit (trigger pop-up)
        
        In some instances we want to select the annotation and edit them
        at the same time - trigger pop-up. This change adds back support
        for that.
        
        Also properly close the pop-ups when the view shell and window
        are destroyed.
        
        Change-Id: I17abeb39a7500001b148b8923eb9028d297a40a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179664
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c034a21f359db6bd8ba7b4938d4501bbcc87e21d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fcd5b8983cf33e93df135530776ce3a3bb3f0ae
          - tdf#160178 Add bookmarks to Pivot Table Gouping
            
            Also fix the "How to get" section.
            
            Change-Id: I22d5d707397d37ceb7ad45a8c42b128146eb742e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179846
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c59dfb2f7c5c61068704183602cfb66a42ab0c1a]

        split out a separate 'checkFile'
        
        no change in logic intended
        
        Change-Id: I56b8dabaaecd403704d2317cfe90ee5f04875dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179844
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-06  Noel Grandin  <noelgrandin@gmail.com>  [cc56bf56e170492e414a975ad8c07c41ed72e1a4]

        convert RES_OBJECTDYING to SfxHint
        
        and remove SwPtrMsgPoolItem, which is now unused
        
        Change-Id: I4f5246aa03e300d78b81801c54255b3ab68ce312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179781
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f5cb16b62332c09b3afd589cc009507f72c113f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b4b8a46283741f14935a5bf69a224ac04f1a1f0
          - Fix typo
            
            Change-Id: I4db29c5cc9fba1902f9cd1316096f9a8ea59d42d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179842
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [540d6349ac675e98c73166392cabbfcca8a6fc5b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bb22cfc2c8ed1e515d47dc98cc34a2b38923faaa
          - tdf#121452 Add Paste Special entry in index.
            
            + Ad also Calc .uno:Paste* bookmarks.
            
            Change-Id: I991152633a95c88c97995f534597f567a2d98a4e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179809
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2025-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [202de88b10cf0b7ba16a3c767865a386f04c355f]

        crashtesting: assert on reimport of forum-mso-en4-29087.ods
        
        conversion of xlsx to ods and reload
        
        Change-Id: I8f1f10520e3601326405acd90a310ebd6163ffbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179834
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-06  Henry Castro  <hcastro@collabora.com>  [7174a1a7b4cd52ad9e9f4fff887821e60e63693f]

        lokit: add scale parameter to "renderNextSlideLayer"
        
        When client side change the device pixel ratio.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I6356ff2a2e6513ac835b5f02a755173aafe01dc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178580
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179825
        Tested-by: Jenkins

2025-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08111edaeb425f1b66d0c69c415dbd7d2f44ac8c]

        crashtesting: assert on reimport of forum-mso-en-2419.docx
        
        after export to docx. Use similar duplicate preventation mechanism as
        normal bookmarks and annotations use.
        
        Change-Id: I31a70f1ee437a5d8cce790c7ec2c7a8d5894d3f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179828
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca7ee477978c6b818a28fcd601a7033066e23a9f]

        merge duplicate part of branches
        
        Change-Id: I58d4748819c5eb950f26f09684eb93d55bf025ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179827
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-06  Jonathan Clark  <jonathan@libreoffice.org>  [9b505f583954c88ce7b72a07c9bfd65d78d863ef]

        tdf#66791 sw: Apply first-seen script type to leading weak characters
        
        Previously, leading weak characters were always assigned a script type
        derived from the application language. This change updates the algorithm
        to instead use the logical-order first-seen non-weak script type.
        
        Change-Id: I5f6732c6faa1eb35aff51e98e82a87c8008f70ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179824
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2025-01-06  Miklos Vajna  <vmiklos@collabora.com>  [0cc0896b212b0d1fded8d999b980f18f0379e6e0]

        cool#10630 lok doc sign: fix Impress sign line when picking a certificate
        
        Once .uno:InsertSignatureLine gets dispatched, a visual signature
        placeholder gets inserted, then a certificate picker shows up, but no
        certificates are visible in the list.
        
        The first problem is that .uno:InsertSignatureLine needs to take sign
        key/cert parameters in DrawViewShell::FuPermanent() (similar to
        .uno:Signature), so it can learn what certificate to use for signing.
        
        The second problem is that once that sign cert is attached to the view,
        the cert chooser for signature lines were not taking the sign cert from
        the view in DocumentDigitalSignatures::chooseCertificatesImpl() -- this
        needs routing the info about the current view from sd/ (where we still
        have that info) to xmlsecurity/.
        
        With this, a LOK client dispatching .uno:InsertSignatureLine with the 2
        new parameters set can insert a signature line, it'll show up, but the
        subsequent .uno:Signature dispatch still needs fixing up. (Currently it
        wants to "save" the modified PDF, while it should just sign.)
        
        Change-Id: Ie536842152ef097aa6959c67916f2beb6d356e4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179819
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7112bc2a98b06217302fb18e52fcbd03f8744f79]

        tdf#132770 - FORMATTING: Import inserted text tag <ins> (underlined)
        
        Change-Id: I5819ce4d4551bbd781921d847131f15cf2b94a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179771
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2025-01-06  Johann  <jlorber@linagora.com>  [a48561a28741436b03006f100b947403e4cddfc9]

        tdf#145614: Convert #define to enum
        
        Change-Id: I5ae1b39c8824f228d148d3df00ba954694a1dee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178640
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [63753117640dde3e8e0b0e677afe26b7f57c626b]

        tdf#163852 ooxml: fix import of cropped vector graphic objects
        
        We need to store the vector graphic objects size, so later
        we can calculate with that for the cropping.
        
        follow-up commit of: 1db193c6c744289139b1df2af0b8defcf974b238
        (tdf#126084 import svg image from ooxml document that use svgBlip elem)
        
        Change-Id: Iffa98cc6a03063544bdf2b8ec3012415868e7c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179626
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2025-01-06  Mohamed_Ali  <mohmedali1462005@gmail.com>  [4df99b813f1f0f643ab5f1b7a4f60cef938da13c]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: I2d2bf71e90f803773b46a0a7f9fd72184f2d3d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177208
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [de8b935e16d463c632f3311294869479c56f1201]

        Drop unneeded forward declarations from include/ even harder
        
        test drive the new bin/find-unneeded-includes --fwdecl mode
        with iwyu 0.23 instead of 0.21, this seems to find more unneeded
        fw declarations
        
        Change-Id: I451e571c70eb74f46c799753e3c5a53c0110da36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179707
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-06  Miklos Vajna  <vmiklos@collabora.com>  [145e62541762b2fb16d41e07aacc52081f782754]

        svx: prefix members of SvxMediaShape
        
        See tdf#94879 for motivation.
        
        No problem with _ suffixes, but parent SvxShape uses m_ prefixes, so
        switch to that here as well for consistency.
        
        Change-Id: I938598829924ba5bb7ee22e16a1337e354c3411e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179816
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4288deb11c1def3657bb06549d5adfbfabe60bcb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c5a09f2ad9c2396860dc89553e4a6b31f2e0896
          - tdf#137419 Remove Data Provider help page
            
            Change-Id: I898f9165a27b009a379a1c3d59886981b6f9f2d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179810
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2025-01-05  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [022e95d39d9ae29496be0f81740eefaf515f578a]

        tdf#154285 Check upper bound of arguments in SbRtl_Minute function
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Ic861d453395a10d484614e29b5a491800ddb7a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179251
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2025-01-05  Shantanu Oak  <shantanu.oak@gmail.com>  [c1eb6334d267954e97c1627026bf0570ccc5fb85]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 2bb5f4cd04b2a0a3cba85ce9879c99ace1b10221
          - update hindi
            
            Change-Id: I8abbeeca2e3dab5b4f75e5c0ec0c44b87e2fd678
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179779
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2025-01-05  Noel Grandin  <noelgrandin@gmail.com>  [404fbec25740406e3b926844f3bd0f324dc38b8c]

        convert RES_ATTRSET_CHG to SfxHint
        
        Change-Id: I22c4bd909010e2c5d48fcfa040e9efe2a4c7950a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179772
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2025-01-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [3569baecf8f18d00fc804ce75a06a3946996fdb4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccdc6623be9a0cd3cbae36d2f7fa6f9ec0c1ecfe
          - sections of privacy policy are labeled by roman numerals
            
            Change-Id: I6c7cd7d49b54329ac48d2d8f9ee72c95d0b0222d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179776
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f23af7a56dda5aabe8ba3616566fbfe75805759f]

        Gtk-WARNING: GtkBox does not have a child property called homogeneous
        
        since:
        
        commit b4d1dff8835a2c52f2adf767596a367695a9e1a5
        CommitDate: Fri Jan 3 10:03:06 2025 +0100
        
            jsdialog: enable style sidebar
        
        Change-Id: I8518570e2ead2dbeff1ad09960a067bbb0c79505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179777
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-04  Patrick Luby  <guibmacdev@gmail.com>  [55f7845b9922e1dec3818579a4445e25a27c7e17]

        tdf#164564 don't stop the timer while waiting for a native event
        
        Partially revert commit 62baf23796132d6c0e17ae1ff37c3b9ee0556cf0.
        If only ImplGetSVData()->mpWinData->mbIsWaitingForNativeEvent is
        true, stopping the timer will also stop animation when using
        Skia/Raster or Skia is disabled.
        
        Change-Id: I1d267625c4213687a5b98d0b073e8c9c345c2978
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179773
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2025-01-04  Julien Nabet  <serval2412@yahoo.fr>  [068fef40d39b24a7f7ef1142e45cb3e7dcc9fb08]

        Related tdf#162279: rather use OSL_DEBUG_LEVEL instead of NDEBUG
        
        Following Stephan's suggestion.
        
        Change-Id: Iaeb7192129d83471aa0a32e7adb272a14e80ff71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179703
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f4a3ffe1110aa38a3836533e6c51b910c68c2336]

        cid#1637440 silence Using invalid iterator
        
        Change-Id: Ief211a353d57fbacc9bc8e4003c0e7c68dbba626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [1b93ed7991479a977ea5f91b49f90303a0d4e220]

        jsdialog: setup parent for menu
        
        similar to popup we point what is the parent so we
        can show menu just below that element / entry
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I09a524d3da7c5fe1c36de6a2a2033058e5554a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178670
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179710
        Tested-by: Jenkins

2025-01-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e5551984da6be558e0a53117d787a9915060dab]

        cid#1637439 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0c0454093358d2f089a9d796aabbca8d0f0fc2a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179705
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2025-01-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [04d39f6220113700adbfcb49928c482d0e14da42]

        Actually honor a non-default --with-keep-awake=...
        
        Looks like this was inadvertently missing from
        f5c3ec505b83a20d272a66305bca565e9ff38b04 "add --with-keep-awake switch to
        prevent going into sleep/suspend".
        
        Change-Id: I162eac442b89671aa4d2e0039ca810ff71cd08aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179709
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-03  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [75d47b87abde45591128ae7a12fb0b0fad6768c2]

        sw: protect against null annotation window
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I3d2b820d492757c60e396b5eda484bb3c049928c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179375
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2025-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e70afe758eae3acdc5ac6ee2b3d173985899db1a]

        tdf#162695 decrease the text margins to smaller
        
        This decreases the text margins so the comment is overall smaller,
        which should make the situation better, but the main issue might
        be that the comments previously did not change size with zoom, but
        now do. This is probably nto so simple to change.
        
        Change-Id: I5c83b787f58324431e110ee095f61135b67588e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179662
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2025-01-03  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [5ada7884f6a0facf8253b713cc86a6cbf286505d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 359f22f92b756a9aca921ac4d0a36ace1d9ae872
          - tdf#164395 Help page for Appl'tion Appearance (II)
            
            + Reuse old Aplication Colors help page
            + Place in the folder /shared/optionen/
            + Update "how to get"
            + Update Contents tree
            
            Change-Id: I86ca7fdd5e457c178ee39b7959f4976e44118060
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179629
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e13c4edfd94b2ee1b3d3992993763670bfcab244]

        slideshow: Fix "calculating" the hash for the object's paragraphs
        
        Using the createEnumeration on the UNO object and finding the
        UNO object that representing the paragraph, and using that pointer
        as a unique identifier has doesn't work reliably. The reason for
        this is probably that the createEnumeration call creates new UNO
        objects that represent the paragraph, so the pointers change all
        the time.
        
        This changes the "calculation" of the paragraphs so that the hash
        is actually combined using the hash of the object (which is always
        of the XShape type and the hash is consistent with those) and the
        paragraph index. This works well for the slideshow where we don't
        edit the objects, but it can be a problem in the future if we will
        allow editing.
        
        Change-Id: I6dc9486a1e5d7c4ceb3d609613b60603886063c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179698
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9c855f5e596bf97cb1db6de3cc3d8f3785ec096b]

        Filter out text/uri-list with empty list
        
        ...as seen at least with the Qt6 Wasm implementation (see the code comment for
        details), and where, at least when trying to paste some plain text into Writer,
        the LO code would then favor that faux text/uri-list over text/plain, and would
        get into the
        
        >     else if( bMsg )
        
        branch in SwTransferable::PasteFileList (sw/source/uibase/dochdl/swdtflvr.cxx)
        and try to synchronously show a message box, which for now causes an abort in
        the Emscripten build
        
        Change-Id: I64e7cf66717f29b3609c04aea3c6124279ab55de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179699
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2025-01-03  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [fd32e497bb97e2fb8f77f48ffaf3bf230c65b7a6]

        Broadcast the transition change
        
        - Now multiple user can see the simultaneous changes on transition sidebar
        
        Change-Id: Iae598d2cf106f3fdfb96ce409c31c69d196e8912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178298
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ba0ec3b5f6f2154205ad72ce444a48b4dfb9af88)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179602
        Tested-by: Jenkins

2025-01-03  Gökay Şatır  <gokaysatir@collabora.com>  [a54a0e1906e35cbd0c812381704942ace24597dc]

        cool#10794 Test for: Don't open validity dropdown in readOnly mode.
        
        Issue: In readonly mode, validity dropdown is still usable.
        
        There are 2 tests here. 1 is to ensure that dropdown opens and it also exists as an example on dropdown events.
        The other is to ensure that dropdown is not opened in readonly mode.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Id73c4421454af2af4f306925d6c628f776ecd2d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179303
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179697
        Tested-by: Jenkins

2025-01-03  Gökay Şatır  <gokaysatir@collabora.com>  [223a8291a649ab462fad23b682ec9a014cf8d6ed]

        cool#10794 Don't open validity dropdown in readOnly mode.
        
        Issue: In readonly mode, validity dropdown is still usable.
        
        Since the action is not performed via an uno command but event handling (function name is also: HandleMouseButtonDown), we need to add a guard to event handler.
        
        This issue is online only. Desktop view doesn't have the issue.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ic0883d610f484cbc2b777200333e6ae5d14f52d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178378
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179696
        Tested-by: Jenkins

2025-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [b4d1dff8835a2c52f2adf767596a367695a9e1a5]

        jsdialog: enable style sidebar
        
        - disable not supported previews field, action menu for now
        
        Change-Id: Ife94ee96dd15bd92752ff6e9cc5e68243aac0851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175646
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179625
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-01-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [72df5a6fdf3e14d9994ebd1de269ab712136a27a]

        Drop unneeded forward declarations from include/
        
        test drive the new bin/find-unneeded-includes --fwdecl mode
        
        Change-Id: I507fa2b172ec9e348d1d91066ea241f02187b5ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179321
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9e1e48d73014471ebc2ea4f3589276cace096613]

        tdf#162920 make show/hide comments working again
        
        use SdrObject::SetVisible to change the annotation's visibility
        status.
        
        Change-Id: I8002294351c64830ad294c43f6ee92425456ac0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179661
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2025-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [38ee2883fbebb59b6775e7027b4b7ec799c0fc6f]

        loplugin:indentation
        
        > vcl/quartz/salgdi.cxx:151:5: error: else body should be indented [loplugin:indentation]
        >   151 |     mpBackend.reset(new AquaGraphicsBackend(maShared));
        >       |     ^
        
        Change-Id: I6b6ee344e05080219efa8ab2e4ae21923e833c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179617
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-02  Szymon Kłos  <szymon.klos@collabora.com>  [15d33f1b6468b05f9cea08e266c408238248cc23]

        lok: jsdialog: enable font size box after save
        
        This is followup for commit cbe229ec219e56ce1bb5dd9598f9052a98504249
        lok: jsdialog: enable font name box after save
        
        We need to use weld:: api to inform JSDialogs about
        sensitivity change. Happens in lok after shape
        resize - we cannot open font size dropdown.
        
        Change-Id: I1897502948c90e3bd1e5e3e347429fa9729d87a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177512
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179612
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-01-02  Szymon Kłos  <szymon.klos@collabora.com>  [389e7d4bc5525b0fbb595ceb89c19dc78c0b00f2]

        jsdialog: use single static register
        
        followup for commit 13af671fda1317175a93fd747e5455ce897ed167
        jsdialog: share code for widget registry
        
        this way we avoid modyfying compilerplugins every time we add new
        thing we need to remember
        
        Change-Id: I6b750175e7dcb31d62666f53c9275a2c5d879150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178344
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179622
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0a78f5de99ae80e84d3ab33ddef6cf7642743425]

        slideshow: Render each animated paragraph in its own layer
        
        We need to render each animated paragraph of a SdrTextObj in its
        own layer. This is not easy to do, so modify the PrimitiveContainer
        after rendering and turn off all the paragraphs that shouldn't be
        rendered. In addition also turn off rendering of the object itself
        (the fill and stroke). This can be done by setting the newly added
        setVisible method on the desired TextHierarchyParagraphPrimitive2D
        to false (and others to true), and turning the primitives to render
        the object to setVisible = false. If the primitive is not "visible"
        it will be skipped in the when rendering with VclPixelProcessor2D.
        
        Also changes the SlideshowLayerRenderer to take into account the
        rendering of paragraphs. We remember all the paragraphs for an text
        object that are animated, then we take this into account when we
        do render passes.
        
        We also need to take care of the paragraph hash, which needs to be
        set consistently for all animated paragraphs (so the layers can be
        identified correctly for animated paragraphs).
        
        Change-Id: Ice3b9e1f586c3fca81cf5da809fa88c4b9c87c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179599
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [32ed2a4bbca0de1e5aa67e38e520e37e33a0df40]

        loplugin:reftotemp
        
        Change-Id: Ic2282e19fcb33cf08380a08098b375c0ca03b724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179616
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2025-01-02  Szymon Kłos  <szymon.klos@collabora.com>  [53017b90e6a61e2ae0873833ab5b647eec83f212]

        jsdialog: remember message dialog
        
        regression from commit 13af671fda1317175a93fd747e5455ce897ed167
        jsdialog: share code for widget registry
        
        we want to remember message dialog when NOT present
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ia072800d62745b47668ee81f4bee17b9fe24b5af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177957
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179618
        Tested-by: Jenkins

2025-01-02  Szymon Kłos  <szymon.klos@collabora.com>  [d8a7b0e9708603aca3f18107e47cb6872598c725]

        Revert "lok: sw: fix PageDown position when cursor is not visible"
        
        This reverts commit ddb454bb80622a2fd625bc09af8a66b025b0739f.
        lok: sw: fix PageDown position when cursor is not visible
        
        It caused sending of incorrect cursor position during tile rendering
        in LOK case - LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR while
        `SwCursorShell::VisPortChgd` <- which is used eg. in the PaintTile to
        make interesting part visible:
        ```
        libswlo.so!SwCursorShell::VisPortChgd(SwCursorShell * this, const SwRect & rRect) (sw/source/core/crsr/crsrsh.cxx:1800)
        libswlo.so!SwViewShell::PaintTile(SwViewShell * this, VirtualDevice & rDevice, int contextWidth, int contextHeight, int tilePosX, int tilePosY, tools::Long tileWidth, tools::Long tileHeight) (sw/source/core/view/viewsh.cxx:2034)
        ```
        
        There are 2 problems:
        1. It generates and sends it just-now, not using the optimized delayed version `SfxLokHelper::notifyUpdatePerViewId`
        2. Even more important: rendering tiles shouldn't cause cursor movement/invalidation
        
        Change-Id: I2315cf7dd5575586276b86ca5285d6c5b15ff73a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177520
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179613
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2025-01-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc5e50519ef76ad74408410b45c312997faa1dab]

        zxing-cpp: Upgrade to 2.3.0
        
        Downloaded from https://github.com/zxing-cpp/zxing-cpp/archive/refs/tags/v2.3.0.tar.gz
        
        Change-Id: I79a9d63cfafb44d733231b78bc19a45b43baa6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179604
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1a9572e5057dfce1dfd65ac3478255df6eb19e62]

        Sort bin/find-unneeded-includes results
        
        not naturally, but numerically
        so a hit in line 101 will be listed after the hit in line 99
        not after the one in line 10
        
        Change-Id: Ic5b3da80df20a3aeda7b1a71c8d6380371ed3ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179320
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2025-01-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [892bd92c8924bfceaa230acd5d127d4cda851233]

        zxing: sort objects alphabetically
        
        Change-Id: Ica4cacc702f338e9e0ebcf6e4b6a48d1d4f3bef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179605
        Reviewed-by: Taichi Haradaguchi <vdnznnwii@mozmail.com>
        Tested-by: Jenkins

2025-01-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ef9f44cf36c930492e67b2e4115b80617a643a7]

        update LIBO_THIS_YEAR
        
        Change-Id: I6574dfb4eca425f5f83b978f814deec69478d98c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179611
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [48527403950033b7002807bd248a5e887af5159d]

        bump copyright year to 2025
        
        Change-Id: Id2d0597ed86a5f798eec22dde5b954c06442a2a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179610
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2025-01-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [458353be11417448a5318cd69a9e3677cf9a34fc]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I5db5200f59f32e428963a2c5bd6f70da42ec078f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176780
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2025-01-02  Manish Bera  <mbera.dev05@gmail.com>  [10b0ab7ba8f792198b2f84f845a388fb86440c2c]

        tdf#146619 Remove unused #includes from C/C++ files
        
        Change-Id: Ic6a6f9a8462a128ab8f61dfa6dbbecb8c707e57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179595
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7336fcd93c566a5fed470e79a16d66cf5c08ac8d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 85cefda4f49164a075a4b03568a281caaa6f9710
          - Drop spurious </ahelp>
            
            ...introduced in 7bb37bc63384aa1654041c19cceac7463266f9fc "update translations for master" and causing
            
            > [build HPX] pt-BR/helpcontent2/source/text/swriter/01
            > Entity: line 1: parser error : Opening and ending tag mismatch: root line 1 and ahelp
            >  tempo). A linha hifenizada é movida para as próxima páginas abertas.</ahelp>
                                                                                           ^
            
            Change-Id: Ibc7e2431b0cf64a3b1612f86bb795277126c11f2
            Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/179606
            Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
            Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
            
2025-01-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [99ec4b258685672c7bfad847c0abbb8b10474fc8]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to f9cf1b6cda2e125715d435f52bb1d7f076280db6
          - upgrade Ukrainian dictionaries to 6.5.4
            
            Downloaded from https://github.com/brown-uk/dict_uk/releases/download/v6.5.4/hunspell-uk_UA_6.5.4.zip
            
            Change-Id: I3d73f79750e7ab194f5811f194cd9f523098d931
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179607
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2025-01-02  Miklos Vajna  <vmiklos@collabora.com>  [335d041133fc86ab475ed9f85dd4123ffc925dba]

        sw: move SwTiledRenderingTest to Library_swqahelper
        
        Towards not including .cxx files in Writer tests.
        
        Change-Id: I92b3eb6d2208ba10797d0363fca53df5acc98324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179598
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2025-01-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [0489e8e21a072f05b6b4373e92c3f36e9c3e2594]

        Drop unneeded forward declarations from chart2 module
        
        test drive the new bin/find-unneeded-includes --fwdecl mode
        
        Change-Id: I9fd1148e8cff3ebda4595820af5fc824f530245c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178967
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2025-01-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [cff2f182e4b30055661ef202e08f30a0c0af29ec]

        Revert "find-unneded-includes: don't suggest removal of fwd decls"
        
        This reverts commit cee2e455605bbb921e1e32201cc27af973cb775c.
        
        Improve the forward declaration removal algorithm:
        run IWYU without --no_fwd_decls but ignore the header removal suggestions
        
        This way only the obsolete forward declarations are listed
        
        Previously we did not have a way for telling apart needed and
        unneeded forward declarations, now these can be cleaned out too
        
        Put this mode behind a new command line switch: --fwdecl
        
        Change-Id: I1b5659fd44253627adbaa7866178ddc000b1b5eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178966
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2025-01-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [a1c835797d16383db1e67035c79b237c7706df0c]

        crashreporting: unify GetViewData and check it
        
        There are asserts all over the place but the crash is still
        reproducible, see https://crashreport.libreoffice.org/stats/signature/SvListView::SelectListEntry(SvTreeListEntry%20*,bool)
        So at least do not crash in a release build
        
        Change-Id: I1cde218cea449235f063198fdb03c5601dae3d0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2025-01-01  kkasliwal  <kkasliwal@hawk.iit.edu>  [1671636d97902c7275a5f7646d92061b6bb4b827]

        tdf#114441 Convert use to sal_uLong to sal_uInt32
        
        Change-Id: I26669ed7a15b27314e97ec29076d07f798a54ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179572
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-01  kkasliwal  <kkasliwal@hawk.iit.edu>  [7994ecabf6841512fd2449d161686ace9221c60d]

        tdf#158237  Use C++20 contains() instead of find() and end()
        
        Change-Id: I59aee557e3a508a067cecad569ae4882c83c809b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179484
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2025-01-01  Justin Luth  <justin.luth@collabora.com>  [c90c1d4435a64531e1d9b41d0a8dc0b91ba236cd]

        tdf#164201 docx convert-to: prefer Word 2010–365 Document, not 2007
        
        This was made more prominent by mstahl's 7.6
        commit e66ddcd4b66923bc835bd7c5f5c784a809a420a2,
        which rightly forced the compatibilityMode to 12 for Word 2007 exports.
        
        The context here is running a command-line
            soffice --convert-to docx myfile.odt
        which was creating a compat12 Word 2007 DOCX
        instead of a compat15 Word 2013+ DOCX.
        
        Filtercache registers valid conversion types in a seemingly random order
        "but if it's a 'Preferred' one - set it to the front of the list.
         Of course, multiple 'Preferred' registrations can occur
         (they shouldn't, but they can!) ..."
        
        For DOCX, both writer_MS_Word_2007_XML and writer_OOXML
        say that they are the preferred one,
        and since Word 2007 was processed last, it won.
        
        However, since 2020 we have preferred exporting as compat15 (2013+)
        so make the modern format the preferred filter.
        
        [I looked for more "multiples", but more often than not,
         NOTHING is set as the preferred entry, so first come first served.]
        
        Change-Id: I2e4c95520619e0aa2e1f0d8ae5e8928d0033902e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179588
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2025-01-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a000943c849d6016e69e44ac68aa66ea354fcc94]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a63d9b986914704c1ad027660f7733e722980560
          - Mute L10n in BASIC examples
            
            Change-Id: I9feccab8811cfa728310e96eb1e7a78de452a1eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179591
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2025-01-01  Stanislav Horacek  <stanislav.horacek@gmail.com>  [0719c8e66bcf1cfed120d6327cd4f1d0a997b54a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e93bec996c1b4a34190e648eaaae670478fd169f
          - fix missing space in page title
            
            Change-Id: I2042ce811a2d75ef268b2b7dfc225100fff959de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179493
            Tested-by: Jenkins
            Reviewed-by: Taichi Haradaguchi <vdnznnwii@mozmail.com>
            
2025-01-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8a207b6e5fa6438ccc687010f219a4326396e4c]

        Fix typo
        
        Change-Id: If532e379e947020988e2c7741cae4e9c3e594991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179585
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6588f09e8cd003651cd10e68116dcf2044ac6e58]

        Fix typo
        
        Change-Id: I6e0d9f24aa95c8962d7db903c486fc9011459b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179584
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2025-01-01  Manish Bera  <mbera.dev05@gmail.com>  [7d1d111c36c9e81d41442f3eb29f7fc52b598c90]

        tdf#140226: use StaticWhichCast
        
        Change-Id: I461471e5b2e9cd3d94896d9ba6ac315f7237bec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179510
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2025-01-01  Stanislav Horacek  <stanislav.horacek@gmail.com>  [acdbf9a4c24e290e1164b40cbea88d05b465332b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e8030324b49d927c3a5de133478f08f5ef74ba60
          - fix not localized items of displayed information table
            
            Change-Id: Icb972fea4019a98ffba4202a881e4b4c13c6257f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179577
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-12-31  Patrick Luby  <guibmacdev@gmail.com>  [61f8fb648ecf9a20ee8abec0e8d3fad3e666db5e]

        Related: tdf#159995 allow setting the page size when printing to file
        
        On macOS, printing to file just saves to PDF using a native print
        job just like the native print dialog's PDF > Save as PDF... option.
        Also, as noted in tdf#163558, the native print dialog could support
        changing the page size eventually (and already does in Apple's
        Safari and TextEdit applications) so allow changing of the page
        size in the non-native print dialog on macOS as well.
        
        Also, changing a listbox's active item does not trigger an update
        to the preview so force an update to the preview by calling each
        active listbox's select handler after changing the active printer.
        
        Lastly, when printing to file with the non-native print dialog, try
        to mimic the save dialog behavior when using the native print dialog
        to save to PDF.
        
        Change-Id: I5f42d818701cf64fdf3ecb616d1eef7b835eb2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179573
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a9966e81381059a3a9d8fc4d391ba17d99385fee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2cc2c9d5a7a9739d47b3162e0e10102b42e9cc70
          - Warn when javascript is not enabled in browser
            
            + A big red warning displays on top of pages when JS is disabled in browser.
            + otherwise JS switch warning to display = none.
            + Fast/instantaneous in Firefox
            + Some delay (flash) experienced with Brave and Edge in Linux (Chrome engines).
            
            Change-Id: I2b1792e87520b3f4e0bf93a6e0430376587b4afb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179578
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-12-31  Taichi Haradaguchi  <vdnznnwii@mozmail.com>  [c1e4a484bce2fe8044232bf1c0b47205f01f9ad4]

        Fix build --with-system-bzip2
        
        Fix the following errors:
        
        > configure: error: Package requirements (bzip2) were not met:
        > 
        > Package 'bzip2', required by 'virtual:world', not found
        > 
        > Consider adjusting the PKG_CONFIG_PATH environment variable if you
        > installed software in a non-standard prefix.
        > 
        > Alternatively, you may set the environment variables BZIP2_CFLAGS
        > and BZIP2_LIBS to avoid the need to call pkg-config.
        > See the pkg-config man page for more details.
        > Error running configure at ./autogen.sh line 333.
        
        Change-Id: Iaa06f7c527330395fecca649ea1b77d277c26ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179576
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <vdnznnwii@mozmail.com>

2024-12-31  kkasliwal  <kkasliwal@hawk.iit.edu>  [f41009f923ec8a77f66a1212a42d03604fb5e643]

        tdf#145614 convert #define to constexpr
        
        Change-Id: Iffa0af4cdc8eea6aaba5bca7c4c13103fe938644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179180
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-31  kkasliwal  <kkasliwal@hawk.iit.edu>  [a759dcce07889e5381d31dea05c2dffd2ac6f506]

        tdf#145614 convert #define to constexpr for scripts
        
        Change-Id: If549a027389746408e378f81d7334924a3d471b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179083
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca8c079aa1b42c9a7d582dc04be0437aca1084a5]

        crashtesting: assert on loading ooo56980-8.odt
        
        in lcl_MoveRowContent since:
        
        commit 6b09bec95747d3bd9871bab3f49142a2fca2d368
        CommitDate: Thu Dec 26 18:26:32 2024 +0100
        
            sw: use SAL_RET_MAYBENULL in Lower()
        
        RemoveFromLayout invalidates the Lower() so it must be refetched
        
        Change-Id: Ie8722fba8b1765b13969c03f10711ade26b04080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-30  Patrick Luby  <guibmacdev@gmail.com>  [09484a1befd41681276cc9909b3228e5bf28a76e]

        Related: tdf#159995 fix pages per sheet in the non-native print dialog
        
        Use filtered page sizes so that printing multiple pages per sheet
        in LibreOffice's non-native print dialog uses the correct paper
        size.
        
        On macOS, the native pages per sheet setting in the native print
        dialog adds margins and scales down the pages to fit. So the only
        alternative is to have LibreOffice handle pages per sheet but
        that is only available in LibreOffice's non-native print dialog.
        
        Note: to enable LibreOffice's non-native print dialog, set
        "UseSystemPrintDialog" to "false" in LibreOffice's Expert
        Conguration dialog and restart.
        
        Also, fix the following bugs when printing a Writer document with
        different paper sizes on each page:
        
        - Print jobs with different paper sizes are broken up into a
          separate NSPrintOperation for each set of continguous pages
          with the same size so the page number needs to be offset by the
          current page start range.
        
        - If the LibreOffice paper name is empty, fallback to setting the
          paper size by width and height.
        
        - When the last page has a page size change, one more loop still
          needs to run so set the current page range count to zero.
        
        - When using the native print dialog and one of the print dialogs
          is cancelled, abort the entire print job.
        
        Change-Id: I3450a11acefba5db6cb39a0111ce83da7546f6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179508
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [2bce53f785909173210af45df1eba7c702c98a61]

        Revert "simplify RES_UPDATE_ATTR handling"
        
        This reverts commit c854c09ed109b650b5b5faaafcc8c202860ff39e.
        
        Reason for revert: The call sites that pass pOld == nullptr and pNew == something, are effectively passing a flag to SwRegHistory::SwClientNotify
        
        Change-Id: I58e71e7439893061d598aecef3a91f5f2d0897f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179566
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-30  Shardul Vikram Singh  <shardulvikrm@gmail.com>  [e0c2d334f195ba4d727c94f0ba9795b88bc47fe4]

        tdf#146150 Replace SID with dispatch cmd in ContextMenuInterceptor.java
        
        - Replace `slot:5410` with `.uno:HelpMenu`
        - Replace `slot:5400` with `.uno:HelpOnHelp`
        
        Change-Id: Ifcb67906882d4cb416c65bd65c41956e5dda7f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179501
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-30  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d890ef557325241f36cf83a4622d96b98785f07d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f775af098de5db73b11b39c7a5722a1ca4ce4dcd
          - SF_exception help corrections
            
            Change-Id: Ie2c36471a7c3f1901454fae2e7cb55e3db5b5770
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179565
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-12-30  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [d8e29e2697e90da6acf5858fd74d6054ed9e5aa3]

        Revert "Revert "stronger typing for SwClient::GetRegisteredIn"" and fix SwIterator cast
        
        - This reverts commit 9d69c20f8bcd9df4051e4f287c467efbdeae7eed.
        - adapt SwIterator specialization too
        
        Change-Id: Ieeb6f45019489494d2c778c52e0b88ea9e412b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179480
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-12-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3f2f85f69d8e555daa66ce860c43ac92d18c7c32]

        Improve loop a little bit
        
        Change-Id: I6a88935103f1de210f1286c9f7863ebf96aa4b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179562
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-30  Noel Grandin  <noelgrandin@gmail.com>  [c854c09ed109b650b5b5faaafcc8c202860ff39e]

        simplify RES_UPDATE_ATTR handling
        
        make all call-sites pass the same pointer for pOld and pNew
        
        Change-Id: I81319fe91e56668d708b96c70ef9573531f35c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179512
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-30  Noel Grandin  <noelgrandin@gmail.com>  [a3b378c3942aac2fab2ef506c80ee2c4fc741ae2]

        clean up event handling in SwCursorShell::SwClientNotify
        
        Not a bug, just reads better this way.
        
        Change-Id: I089e60878b7748a5a91fd16cf15147c4c09e870b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179511
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-30  kkasliwal  <kkasliwal@hawk.iit.edu>  [833b5c334a0946ae05089101e57341fc2d02c570]

        tdf#145538 use ranged based for loops in
        
        xsdvalidationpropertyhandler.cxx
        
        Change-Id: I443c381a53ca50c27b69726a900c197f44ea9403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179482
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7408508758d3e88fde78f205a28d67ebff3f47d4]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I4176bf09032e5d6024432726927affc2514b61e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177141
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-29  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [91f807f8be8fc37766d003057e3b7e7119bfb369]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b4c400322e93e0ae4fd165ec0d81b2163bbfa6f
          - tdf#164395 Help page for "Appearance" tab page
            
            Change-Id: I7132611a53a20dfbfd762b2bedc90e1aeb2d64f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/179496
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e6b06b8b163e4fb41daa0615b68ca287d54b2162]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I13b880dbe693cadb122088a96312cfd931c70d11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177151
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59aa16560e544ae89c15a85d99bfa22f0b857964]

        cid#1637332 'Constant' variable guards dead code
        
        and
        
        cid#1637333 'Constant' variable guards dead code
        
        since:
        
        commit 2006145e9c8df557f3c1f1834bd4579c03a18f42
        CommitDate: Sat Dec 28 15:04:03 2024 +0100
        
            move RES_FMT_CHG to SfxHint
        
        Change-Id: If3212d76d3fc32b042f19a51535e77680688e1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179503
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c844ecb4d5f87d741b8d96776a6a4781760a5303]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I84a160ebc0744fa68d9ad5415ddb6224bb094522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177174
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [bed685c09f9bb1ceac1c227cfd5abbb4f4484579]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ie4df418e9145f049e0b109fae4cf466037947f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177161
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [84b3791da6be9cf48375cf1d5e06688fb5060315]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Iaefbba294bd236dc5a18f0aa1bb0a89f85124bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177159
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0f9da67c3f165a193568ef8c36f3425e6de853e5]

        UBSan apparently needs SwAnnotationItem RTTI now
        
        ...as CppunitTest_sw_uiwriter5 started to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so: undefined symbol: _ZTI16SwAnnotationItem"
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3414/>)
        
        Change-Id: Ibd7a7010beb1c7a25e9477f18998694dc9528d6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179505
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-12-29  Chenxiong Qi  <qcxhome@gmail.com>  [b0ed190986fab0c57d5933b4d4a41a9be72e3f1b]

        Format pythonloader.py and pythonscript.py
        
        The goal is to make the script more readable. The format is done with
        command:
        
            black --line-length 120 <filename>
        
        No manual modification to these files.
        
        Change-Id: I8ebbac936924277308fc011b20cba60849fa9c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179438
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9d69c20f8bcd9df4051e4f287c467efbdeae7eed]

        Revert "stronger typing for SwClient::GetRegisteredIn"
        
        This reverts commit 687080c2d284f111fdd1fde1ab768ef924c04aa9, as it caused e.g.
        CppunitTest_sw_docbookexport to fail with
        
        > sw/inc/calbck.hxx:428:18: runtime error: downcast of address 0x7ba8053a9db8 which does not point to an object of type 'SwClient' (aka 'ClientBase<SwModify>')
        > 0x7ba8053a9da0: note: object is base class subobject at offset 24 within object of type 'SwFormatHeader'
        >  00 00 00 00  d0 8b c9 ae 47 7b 00 00  01 00 00 00 66 00 48 01  40 6c 00 00 88 be be be  50 8c c9 ae
        >               ^                                                                          ~~~~~~~~~~~
        >                                                                                          vptr for 'sw::ClientBase<SwFrameFormat>' base class of 'SwFormatHeader'
        >  #0 in SwIterator<sw::ClientBase<SwModify>, SwModify, (sw::IteratorMode)0>::First() at sw/inc/calbck.hxx:428:18
        >  #1 in SwModify::CallSwClientNotify(SfxHint const&) const at sw/source/core/attr/calbck.cxx:237:35
        >  #2 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const at sw/source/core/attr/calbck.cxx:259:15
        >  #3 in SwModify::SwClientNotify(SwModify const&, SfxHint const&) at sw/source/core/attr/calbck.cxx:229:5
        >  #4 in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) at sw/source/core/attr/format.cxx:309:19
        >  #5 in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) at sw/source/core/layout/atrfrm.cxx:2849:15
        >  #6 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) at sw/source/core/attr/calbck.cxx:268:13
        >  #7 in SwFormat::SetFormatAttr(SfxItemSet const&) at sw/source/core/attr/format.cxx:604:13
        >  #8 in FillHdFt(SwFrameFormat*, SfxItemSet const&) at sw/source/uibase/utlui/uitool.cxx:239:14
        >  #9 in ItemSetToPageDesc(SfxItemSet const&, SwPageDesc&) at sw/source/uibase/utlui/uitool.cxx:340:13
        >  #10 in SwDocStyleSheet::SetItemSet(SfxItemSet const&, bool, bool) at sw/source/uibase/app/docstyle.cxx:1894:13
        >  #11 in SwXPageStyle::SetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) at sw/source/core/unocore/unostyle.cxx:3157:33
        >  #12 in SwXPageStyle::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) at sw/source/core/unocore/unostyle.cxx:3453:5
        >  #13 in writerfilter::dmapper::DomainMapper_Impl::PushPageHeaderFooter(writerfilter::dmapper::PagePartType, writerfilter::dmapper::PageType) at sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:3910:25
        >  #14 in writerfilter::dmapper::DomainMapper_Impl::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&) at sw/source/writerfilter/dmapper/DomainMapper_Impl.cxx:10049:13
        >  #15 in writerfilter::dmapper::DomainMapper::lcl_substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&) at sw/source/writerfilter/dmapper/DomainMapper.cxx:4746:14
        >  #16 in writerfilter::LoggedStream::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&) at sw/source/writerfilter/dmapper/LoggedResources.cxx:272:5
        >  #17 in writerfilter::ooxml::OOXMLDocumentImpl::resolveFastSubStreamWithId(writerfilter::Stream&, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&, unsigned int) at sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx:127:13
        >  #18 in writerfilter::ooxml::OOXMLDocumentImpl::resolveHeader(writerfilter::Stream&, int, rtl::OUString const&) at sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx:384:10
        >  #19 in writerfilter::ooxml::OOXMLFastContextHandler::resolveHeader(int, rtl::OUString const&) at sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:895:35
        >  #20 in writerfilter::ooxml::OOXMLHeaderHandler::finalize() at sw/source/writerfilter/ooxml/Handler.cxx:214:20
        >  #21 in writerfilter::ooxml::OOXMLFastContextHandlerProperties::handleHdrFtr() at sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:1117:28
        >  #22 in writerfilter::ooxml::OOXMLFactory_wml::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) at workdir/CustomTarget/sw/source/writerfilter/ooxml/OOXMLFactory_wml.cxx:7530:26
        >  #23 in writerfilter::ooxml::OOXMLFactory::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) at sw/source/writerfilter/ooxml/OOXMLFactory.cxx:157:19
        >  #24 in writerfilter::ooxml::OOXMLFastContextHandler::endAction() at sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:320:5
        >  #25 in writerfilter::ooxml::OOXMLFastContextHandlerProperties::lcl_endFastElement(int) at sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:1038:9
        >  #26 in writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) at sw/source/writerfilter/ooxml/OOXMLFastContextHandler.cxx:227:9
        >  #27 in (anonymous namespace)::Entity::endElement() at sax/source/fastparser/fastparser.cxx:515:27
        >  #28 in sax_fastparser::FastSaxParserImpl::callbackEndElement() at sax/source/fastparser/fastparser.cxx:1338:17
        >  #29 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) at sax/source/fastparser/fastparser.cxx:339:18
        >  #30 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11254:8
        >  #31 in xmlParseChunk at workdir/UnpackedTarball/libxml2/parser.c:11636:5
        >  #32 in sax_fastparser::FastSaxParserImpl::parse() at sax/source/fastparser/fastparser.cxx:1117:25
        >  #33 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:896:9
        >  #34 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1477:13
        >  #35 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) at sw/source/writerfilter/ooxml/OOXMLDocumentImpl.cxx:514:18
        >  #36 in (anonymous namespace)::WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sw/source/writerfilter/filter/WriterFilter.cxx:210:24
        >  #37 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2719:34
        >  #38 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:767:23
        >  #39 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1991:36
        >  #40 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:725:28
        >  #41 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1180:37
        >  #42 in framework::LoadEnv::start() at framework/source/loadenv/loadenv.cxx:415:20
        >  #43 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) at framework/source/loadenv/loadenv.cxx:311:5
        >  #44 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:167:14
        >  #45 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:592:16
        >  #46 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx
        >  #47 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:72:62
        >  #48 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:126:19
        >  #49 in UnoApiTest::loadFromURL(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:108:5
        >  #50 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) at sw/qa/unit/swmodeltestbase.cxx:384:5
        >  #51 in SwModelTestBase::createSwDoc(char const*, char const*) at sw/qa/unit/swmodeltestbase.cxx:433:9
        >  #52 in (anonymous namespace)::testtdf91095::TestBody() at sw/qa/extras/docbookexport/docbookexport.cxx:35:5
        
        Change-Id: I1e6d6888c8b311988e627845107148c7970fbaab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179502
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1389f4666bf4a4e05bdb1582f827887332d92167]

        Resolves: tdf#154683 select the saved page after loading the Model
        
        The default Instance page needs to be selected at LoadModel time in
        order to get its tab text updated automatically. Easiest thing to do
        here is to load with the default page selected and restore the user's
        saved page afterwards.
        
        Change-Id: I4ac5231894834f258d33108e4ebcb2f0af062922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [960db01dbfe2f916b91782da03532fae1f836445]

        Resolves: tdf#164463 we need to pass a copy of the LayoutName
        
        a reference means it can get updated to rName during the function and
        the comparisons fail.
        
        a problem since:
        
        commit 235c230cd348600ce7385cc580c45a7be3572704
        CommitDate: Tue Oct 22 09:17:02 2024 +0200
        
            We don't need a virtual here
        
        Change-Id: I2f4e19ffb21b56f3554837d700977bde45140e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179494
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d6f741ccb093eb7cce673d7789fedd4642772311]

        Fix typo
        
        Change-Id: Ieecbb4c473d335858b3b613ccad187e37949f1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179490
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-28  Simon Chenery  <simon_chenery@yahoo.com>  [ba26de65b4f131ca3c76941dbb73dd9d3afde0d1]

        tdf#153109 Use any_of instead of loop to check for match
        
        Change-Id: I1ff9ff36520391bced7229eede86335d0a2b411f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178073
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [df9f56259c52b21340a1429fa796e0aff1917a6d]

        cid#1637330 silence Dereference after null check
        
        Change-Id: I0c6585d8ff29689d79b0614c26c7b15502d947fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179489
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [85be6c20ee99382a2d59d08688cb11aed016f043]

        cid#1637331 silence Using invalid iterator
        
        Change-Id: Ia706dbbb397f80069bace68e831b082de11d8557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-28  Noel Grandin  <noelgrandin@gmail.com>  [2006145e9c8df557f3c1f1834bd4579c03a18f42]

        move RES_FMT_CHG to SfxHint
        
        SwUpdateAttr is re-using this constant for a similar purpose,
        so rather give that its own constant to play with
        RES_UPDATEATTR_FMT_CHG.
        
        Change-Id: I5ffe2a861c44948d8c7dbdd6cf1435c913985c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179305
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-28  Noel Grandin  <noelgrandin@gmail.com>  [5622a7c601a34c2176d39887ca898fbfd279513a]

        Simplify SwFormatFootnote/SwXFootnote interaction
        
        No need to use listeners here, both sides hold a pointer
        to a concrete class.
        And we only need to deal with destruction in one direction,
        because the other direction uses a weak reference.
        
        Change-Id: I2b1e05bcebbb7ff8b62ac1874edc91557dd6951f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179476
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-28  kkasliwal  <kkasliwal@hawk.iit.edu>  [25716e4b7e4d56530cbd6180d807c369fe0725ad]

        tdf#147021 use std::size() instead of SAL_N_ELEMENTS() in ww8par.cxx
        
        Change-Id: I5880840971a01ca5bcb8a3074da1e8c4cbcca562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179181
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-28  Noel Grandin  <noelgrandin@gmail.com>  [466211a423d34b1383de5d7b942a0d5362c88fc2]

        Simplify SwFormatRefMark/SwXReferenceMark interaction
        
        No need to use listeners here, both sides hold a pointer
        to a concrete class.
        And we only need to deal with destruction in one direction,
        because the other direction uses a weak reference.
        
        Change-Id: Ie3a062d21f7215867ada5a9bacf1b00f0ce119f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179474
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a9c19ca567017c7b21be336e82a2ea41d993769]

        cid#1607623 Data race condition
        
        Change-Id: Id0c2ec62a246a301d41732d71c99dfa3d02631b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-27  Patrick Luby  <guibmacdev@gmail.com>  [5bd6ef607d68d371b93ad438fb24e2d8fc352b10]

        tdf#163126 Fix incorrect paper size and rotation when printing a brochure
        
        Printing a brochure in Writer that has A5 pages would set the page size
        to 10 times the size of an A4 page instead of the expected A4 page size
        and would sometimes print the content at 90 degrees relative to the
        paper.
        
        This bug ended up being caused by several paper matching bugs:
        
        - The page size and rotation would fail to be set if the printer was
          nil. A printer is not needed to use the native macOS print dialog so
          if the printer is nil, use the native default printer instead.
        
        - Expand page size match range to 1/10th of an inch. The A4 page size in
          Apple's "no printer installed" printer can differ from LibreOffice's
          A4 page size by more than a millimeter so increase the match range to
          1/10th of an inch since an A4 match would fail when using the previous
          0.5 millimeter match range.
        
        - When brochure printing in Writer, set the printer's page size to match
          the preferred page size. Unlike most other platforms, the native print
          dialog is always displayed on macOS and it displays a preview of the
          print output which the user can make layout changes to. The user can
          also change the printer or even send the print output to PDF instead
          of a printer from within the native print dialog so set the printer's
          paper to the preferred size so that the initial preview more closely
          matches the page size and rotation that LibreOffice expects.
        
        Lastly, the fix for this bug includes fixes for the following bugs in
        the "print selection only" checkbox:
        
        - The "print selection only" checkbox would remain unchecked after
          checking it had restarted the print job so load the checkbox state
          from where it was updated in
          ControllerProperties::changePropertyWithBoolValue(). This fix was
          copied from the following NeoOffice source code file which is licensed
          under the Mozilla Public License, v. 2.0:
        
          https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/osx/printaccessoryview.mm
        
        - If the "print selection only" checkbox is changed when the content is
          only a single page, calling
          -[AquaPrintPanelAccessoryController updatePrintOperation:] won't
          restart the print job so force the print job to restart.
        
        - If the the "print selection only" checkbox is changed and then the
          restarted print dialog is cancelled, idling will have already been
          unblocked so check if it is blocked before unblocking it.
        
        Change-Id: I99e9b3f73e3d3d860762c168573d2bb520934df3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179096
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-27  Noel Grandin  <noelgrandin@gmail.com>  [5e9ab8a8ee883975c1217d855c1c4f9fe9968b05]

        Simplify SwFormatField/SwXTextField interaction
        
        No need to use listeners here, both sides hold a pointer
        to a concrete class.
        And we only need to deal with destruction in one direction,
        because the other direction uses a weak reference.
        
        Change-Id: Ia7825f16d0754cbc74c59baa6ef9996311869a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-27  Noel Grandin  <noelgrandin@gmail.com>  [3642472bea67c6e0c35bee1e6567e1fe9d560e1a]

        merge SwSidebarItem and SwAnnotationItem classes
        
        Because the separation is not doing useful.
        
        Which reveals that SwAnnotationWin::ChangeSidebarItem was
        doing some very dodgy object slicing when assigning
        to mrSidebarItem.
        Fix that by using a pointer in SwAnnotationWin instead.
        
        Change-Id: I516dfaac7066d8f1effe351ef388c03dd1127fd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179445
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8b492a1f3057d2b6c3daed7405000d0270ea3dd9]

        tdf#164417 ooxml export: fix autofilter wrong attribute order
        
        According to ooxml standard, x:filter attributes are always before
        x:dateGroupItem.
        
        Regression from: eea523b686b27b4807ab21b62805ce9fbddf74ef
        
        Change-Id: Ibfcbba8ba88162203ab662312347fb49cc836083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179440
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-27  Arnaud VERSINI  <arnaud.versini@pm.me>  [e47aebcec5a0103f8ed836f1bcba50c5f198f47c]

        tools : use constexpr array instead of std::vector
        
        Change-Id: Ifade95457b4b7c614a4ec83857c822d349a9f88d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179444
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-12-27  Johann  <jlorber@linagora.com>  [bf7ac07c04cb06316b745eb9716787b16c1314dd]

        tdf#158237: Use C++20 contains() instead of find() and end()
        
        Change-Id: I0528229042aa62d3d99e8dbaad68a86d41cf369a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178659
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2d9af865880d5da94e86f40d18686433ff821df]

        sw: fix UBSAN build
        
        /sw/source/core/text/txtfly.cxx:181:29: runtime error: downcast of address 0x6130003eea10 which does not point to an object of type 'const SwFlyFrame'
        0x6130003eea10: note: object has invalid vptr
         be be be be  be be be be be be be be  be be be be be be be be  be be be be be be be be  be be be be
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      invalid vptr
        
        Change-Id: I43e25626af82bb9fc3bef4bb9f60dd8aabc10596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179442
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-27  Noel Grandin  <noelgrandin@gmail.com>  [c028e57f9622028d31a8eb07bcbbb56d98c9765e]

        Simplify SwTOXMark/SwXDocumentIndexMark interaction
        
        No need to use listeners here, both sides hold a pointer
        to a concrete class.
        And we only need to deal with destruction in one direction,
        because the other direction uses a weak reference.
        
        Change-Id: I64058c1dee78056441847d85f33f57fc37a8c05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179441
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [647aa0f596e899176a088e47c16124cccdff4fc8]

        tdf#164474: do not delete anchor node, when the anchor didn't move
        
        Regression since commit f09420fa189be5165b0311083ba127073500a121
        (tdf#158855: Make sure to not add extra paragraph after a table in
        a section, 2023-12-25).
        The code in SwXText::convertToTextFrame still relied on existing
        extra paragraph after the table, which now gets removed.
        
        Change-Id: I562058c15e323a23e3278fd7743f877eeec25999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179443
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8787408cd8b54d389718172495e68fde4214e2a9]

        tdf#147132 Flatten Basic function
        
        Change-Id: I7dfec2da7ee3982255cd5be11d350c343331ed0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177459
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-27  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [687080c2d284f111fdd1fde1ab768ef924c04aa9]

        stronger typing for SwClient::GetRegisteredIn
        
        - introduce sw::ClientBase<> which knows what kind of SwModify it is a
          client of
          * unfortunately, while this is implemented as a statically typed
            template class, it is only ensured at runtime by an assertion
            in SwModify::Add()
          * still I think it is better than not trying to have any typing at all
            between SwClient and SwModify
        - thus make SwClient a typedef of sw::ClientBase<SwModify>: a generic
          client of any kind of SwModify
        - introducing sw::FrameFormatClient as an SwClient only listing to
          SwFrameFormats as a first example use in headers and footers.
        
        Change-Id: Id2dc6d6acb34854be779c8bc4252c836db91bb6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179307
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-12-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4911fc79ec16f9945d726cf9c57ad991a7d1a89a]

        Fix typo
        
        Change-Id: I950e9d7be41f74c638d870eff18dcf6599142929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179269
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [485b8d1b8d49932009ece4508a3a2572b907d4b4]

        Fix typo
        
        Change-Id: I1733e10abbe7ead32076a1d885c32dc173cfd3e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179413
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-12-27  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [51ea740d68990dd23f8450f74fb249ba61619dda]

        SwTOXMark a SwModify no more
        
        ... thus separating the 'listening' and the 'broadcasting' parts, and especially getting rid of the 'if I die, my listeners will be forwarded to what I listened to'.
        
        Change-Id: Ia652c026616ca113d5eeb1a97a20a06223371dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-12-27  Rene Engelhard  <rene@rene-engelhard.de>  [a0d5bc55d5c0cd47d8357ddbba952a179fae9207]

        fix skia build on loongarch64
        
        Add missing _lasx files, because otherwise we get
        
        /usr/bin/ld: /<<PKGBUILDDIR>>/workdir/GenCxxObject/UnpackedTarball/skia/src/core/SkBitmapProcState_opts.o: in function `SkOpts::Init_BitmapProcState()':
        ./././workdir/UnpackedTarball/skia/src/core/SkBitmapProcState_opts.cpp:36:(.text+0x58): undefined reference to `SkOpts::Init_BitmapProcState_lasx()'
        /usr/bin/ld: /<<PKGBUILDDIR>>/workdir/GenCxxObject/UnpackedTarball/skia/src/core/SkBlitRow_opts.o: in function `SkOpts::Init_BlitRow()':
        ./././workdir/UnpackedTarball/skia/src/core/SkBlitRow_opts.cpp:36:(.text+0x58): undefined reference to `SkOpts::Init_BlitRow_lasx()'
        /usr/bin/ld: /<<PKGBUILDDIR>>/workdir/GenCxxObject/UnpackedTarball/skia/src/core/SkOpts.o: in function `SkOpts::Init()':
        ./././workdir/UnpackedTarball/skia/src/core/SkOpts.cpp:65:(.text+0x237d8): undefined reference to `SkOpts::Init_lasx()'
        /usr/bin/ld: /<<PKGBUILDDIR>>/workdir/GenCxxObject/UnpackedTarball/skia/src/core/SkSwizzler_opts.o: in function `SkOpts::Init_Swizzler()':
        ./././workdir/UnpackedTarball/skia/src/core/SkSwizzler_opts.cpp:51:(.text+0x58): undefined reference to `SkOpts::Init_Swizzler_lasx()'
        
        cf. https://buildd.debian.org/status/fetch.php?pkg=libreoffice&arch=loong64&ver=4%3A25.2.0~beta1-1&stamp=1733592509&raw=1
        
        Change-Id: I232b4656a87a4c3d87d669769c6483e01425c0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178051
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: wu jiahuan <wujiahuan@loongson.cn>
        Tested-by: René Engelhard <rene@debian.org>

2024-12-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2b68e8bc0303432625a87d6dd60d5e6c3de9be72]

        pdf: write correct conformance XPM metadata for PDF/A-4
        
        Also write pdfaid:rev when we write metadata for PDF/A-4 (revision
        2020).
        
        Change-Id: Idb1864ca2b66aa43e8c2f118e945d5fb37932935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178676
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178780
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d93dde7f12493a4c4b9426943f2c54608725f0b7]

        pdf: /Info shouldn't be written in PDF 2.0 unless really needed
        
        We shouldn't write the /Info unless we really need to for /ModDate
        or /CreationDate, which are needed if /PieceInfo is present, which
        we don't support.
        
        Change-Id: I14770a20e4efcd5f77bb7b31af3e87682ce040b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178675
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178779
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6bf6c4e062bdb4df103a489406e6bca6c26704ef]

        pdf: test hybrid mode (PDF attachment) with encryption
        
        This adds a test that checks the attached file is correctly added
        to the PDF stream when encryption is enabled.
        
        Also add support for reading of attachments to PDFium wrapper.
        
        The test saves a document as encrypted PDF with hybrid mode enabled,
        then opens the document in PDFium and saves the attachment content
        to a temporary file, which is opened again and the content checked.
        
        Change-Id: I918f67d269c31fe7826a49473e939d52bac7fe98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178629
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178778
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5d0629877b9f3e818fabed30d4add2dd948f3911]

        cid#1637055 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1637056 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia6a3d359b847d738461bb6908da9bc6168352201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [480478ef31e2ac587223848c7fa59efd8d476445]

        cid#1607956 Data race condition
        
        Change-Id: I4d7ea07d7e513a396c32af2428d26e84bc72595d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179235
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-26  kkasliwal  <kkasliwal@hawk.iit.edu>  [1bdc754f066f3a5bef4206afb079020b191c1d3b]

        tdf#145538 use range based for loop in svx
        
        Change-Id: Ie9d9db48aff66b7f425b9a42708682f850e490bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179266
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-26  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [ad56e437b0534a69f4f687919eeb56690177bb2d]

        tdf#140226 use StaticWhichCast
        
        Change-Id: Ie419cb01b62800c088151aa9aa35f7c07ada27bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176839
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-26  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [dfdbc253ff6a3e7fc1bc516279a5a5d4b33baa85]

        tdf#140226 use StaticWhichCast
        
        Change-Id: I54bc2c64cbd4db1c8242057c93de456a7aebe152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176781
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b09bec95747d3bd9871bab3f49142a2fca2d368]

        sw: use SAL_RET_MAYBENULL in Lower()
        
        to catch issues like tdf#163325
        
        Change-Id: I2d2e3e66bd376884d029aaf227b93aabe4ca5794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177555
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-26  Noel Grandin  <noelgrandin@gmail.com>  [1c2df42580f381ccfdd1863bc1da4c81314533aa]

        no need to allocate AnnotationData for every SdrObject
        
        SdrObject is performance sensitive, because we allocate a boatload
        of them when drawing charts. Avoiding an extra allocation that
        only a tiny handful of SdrObjects need is worthwhile.
        
        Change-Id: I4974bc1eacfe8abcce45ea659d9edaa8694135d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-26  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [aa93f7366236c5c291a8984900eb863b98d4da07]

        tdf#164393 nicely format gtk-css-declarations for custom themeing
        
        these are css definitions as strings. previously clang-format messed
        up the structure and it became quite hard to read the code. now it's
        excluded from clang-format's range thanks to the // clang-format off/on
        comments
        
        Change-Id: I3ba54a5ac5ef036f08558c607df911a1eb0db1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179403
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-26  Mike Kaganski  <mike.kaganski@collabora.com>  [f8528cdda9292c7ae6c9d49b80c1a3a3b4a67094]

        LOK: don't crash when trying to show a dialog during file load
        
        Opening an ODP with a linked object, which wants to show a "update
        links?" dialog during the load, would assert in Online debug build
        with this stack:
        
          libvcllo.so!vcl::Window::SetLOKNotifier(vcl::Window * const this, const vcl::ILibreOfficeKitNotifier * pNotifier, bool bParent) Line 3188
          libvcllo.so!Dialog::ImplStartExecute(Dialog * const this) Line 940
          libvcllo.so!Dialog::Execute(Dialog * const this) Line 1072
          libvcllo.so!SalInstanceDialog::run(SalInstanceDialog * const this) Line 1881
          libvcllo.so!JSMessageDialog::run(JSMessageDialog * const this) Line 1483
          libsfxlo.so!sfx2::LinkManager::UpdateAllLinks(sfx2::LinkManager * const this, bool bAskUpdate, bool bUpdateGrfLinks, weld::Window * pParentWin) Line 333
          libsdlo.so!SdDrawDocument::UpdateAllLinks(SdDrawDocument * const this) Line 827
          libsdlo.so!SdXMLFilter::Import(SdXMLFilter * const this, ErrCode & nError) Line 647
          libsdlo.so!sd::DrawDocShell::Load(sd::DrawDocShell * const this, SfxMedium & rMedium) Line 299
          libsfxlo.so!SfxObjectShell::LoadOwnFormat(SfxObjectShell * const this, SfxMedium & rMedium) Line 3320
          libsfxlo.so!SfxObjectShell::DoLoad(SfxObjectShell * const this, SfxMedium * pMed) Line 705
          libsfxlo.so!SfxBaseModel::load(SfxBaseModel * const this, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & seqArguments) Line 1983
          libsfxlo.so!(anonymous namespace)::SfxFrameLoader_Impl::load((anonymous namespace)::SfxFrameLoader_Impl * const this, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & rArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & _rTargetFrame) Line 725
          libfwklo.so!framework::LoadEnv::impl_loadContent(framework::LoadEnv * const this) Line 1176
          libfwklo.so!framework::LoadEnv::start(framework::LoadEnv * const this) Line 412
          libfwklo.so!framework::LoadEnv::startLoading(framework::LoadEnv * const this, const rtl::OUString & sURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lMediaDescriptor, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame> & xBaseFrame, const rtl::OUString & sTarget, sal_Int32 nSearchFlags, LoadEnvFeatures eFeature) Line 308
          libfwklo.so!framework::LoadEnv::loadComponentFromURL(const com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> & xLoader, const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & xContext, const rtl::OUString & sURL, const rtl::OUString & sTarget, sal_Int32 nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArgs) Line 168
          libfwklo.so!framework::Desktop::loadComponentFromURL(framework::Desktop * const this, const rtl::OUString & sURL, const rtl::OUString & sTargetFrameName, sal_Int32 nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 592
          libsofficeapp.so!lo_documentLoadWithOptions(LibreOfficeKit * pThis, const char * pURL, const char * pOptions) Line 2927
          lok::Office::documentLoad(lok::Office * const this, const char * pFilterOptions, const char * pUrl) Line 981
          Document::load(Document * const this, const std::shared_ptr<ChildSession> & session, const std::string & renderOpts) Line 1927
          Document::onLoad(Document * const this, const std::string & sessionId, const std::string & uriAnonym, const std::string & renderOpts) Line 1224
          ChildSession::loadDocument(ChildSession * const this,  tokens) Line 932
          ChildSession::_handleInput(ChildSession * const this, const char * buffer, int length) Line 310
          Session::handleMessage(Session * const this, const std::vector<char, std::allocator<char> > & data) Line 311
          Document::forwardToChild(Document * const this,  prefix,  payload) Line 2139
          Document::drainQueue(Document * const this) Line 238
          KitSocketPoll::drainQueue(KitSocketPoll * const this) Line 2794
          KitSocketPoll::kitPoll(KitSocketPoll * const this, int timeoutMicroS) Line 2873
          libvcllo.so!SvpSalInstance::ImplYield(SvpSalInstance * const this, bool bWait, bool bHandleAllCurrentEvents) Line 434
          libvcllo.so!SvpSalInstance::DoYield(SvpSalInstance * const this, bool bWait, bool bHandleAllCurrentEvents) Line 475
          libvcllo.so!ImplYield(bool i_bWait, bool i_bAllEvents) Line 396
          libvcllo.so!Application::Yield() Line 480
          libvcllo.so!Application::Execute() Line 374
          libsofficeapp.so!desktop::Desktop::Main(desktop::Desktop * const this) Line 1605
          libvcllo.so!ImplSVMain() Line 229
          libvcllo.so!SVMain() Line 261
          libsofficeapp.so!soffice_main() Line 94
          libsofficeapp.so!lo_runLoop(LibreOfficeKitPollCallback pPollCallback, LibreOfficeKitWakeCallback pWakeCallback, void * pData) Line 7846
          lok::Office::runLoop(void * pData, LibreOfficeKitWakeCallback pWakeCallback, LibreOfficeKitPollCallback pPollCallback) Line 1135
          lokit_main(const std::string & childRoot, const std::string & jailId, const std::string & sysTemplate, const std::string & loTemplate, bool noCapabilities, bool noSeccomp, bool useMountNamespaces, bool queryVersion, bool displayVersion, bool sysTemplateIncomplete, std::size_t numericIdentifier) Line 3691
          createLibreOfficeKit(const std::string & childRoot, const std::string & sysTemplate,  loTemplate, bool useMountNamespaces, bool queryVersion) Line 490
          forkit_main(int argc, char ** argv) Line 872
        
        Change-Id: I45c20ed8c46e927301aa1de43179638a17608a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179430
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-26  Mike Kaganski  <mike.kaganski@collabora.com>  [faf5725d7cf2025aadad08e10f3d0ac9271cf9e2]

        Simplify a bit
        
        Change-Id: Ibbd269624bbd043aef7039585edf05d4c63bef38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179429
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [93fe2327a156eafc14ea1faf01028fd20f5ed5a0]

        pdf: don't write ProcSet array to resource dictionary for PDF 2.0
        
        /ProcSet is deprecated in PDF 2.0 so don't write it to the PDF
        stream if the output is PDF 2.0.
        
        Change-Id: Id65e60bd68e42c26f4ba5a590fbc383aa2eb23bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178673
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178777
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-26  Andras Timar  <andras.timar@collabora.com>  [b3f2491d7cb14ca9a87e8610dfdcf8e8a86d7a9f]

        Fixed two message context strings and a typo
        
        Change-Id: Ic8926a03990bd1643734608a0bd711caee145f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179421
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-12-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [dcccb6d26ad07609b67470ad7f9a5c0b856700cc]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 9e21ef7309e336a0f8f623c54a4dda49f9d043b6
          - Upgrade Mongolian dictionary to 2024.12.26
            
            Downloaded from https://codeload.github.com/bataak/dict-mn/zip/refs/tags/2024.12.26
            
            Change-Id: I336665091832e67a7c27fe602f8cc9fd98e87e7c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179426
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-12-26  Manish Bera  <mbera.dev05@gmail.com>  [117d31400c946538d075e85cbb4251dc9487a0a2]

        tdf#162563 Remove Java applet code and references from embeddedobj
        
        Change-Id: If3e7ab1cb45c988f3f39fc2f73377c77dc9972f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178873
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6a9cc00c4b8814a279cdea4f0a5e70ace7e65e1]

        cid#1636890 presumably Division by zero shouldn't arise here
        
        Change-Id: Id9a5267ce250143c8c7d87ad477d8fe538bb1b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179314
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-26  Szymon Kłos  <szymon.klos@collabora.com>  [9a6411546aca8f4e9af095dacf73f446fd514326]

        jsdialog: send cell address on startup with jsdialog too
        
        When loaded, LOK_CALLBACK_CELL_ADDRESS is called in:
        
        libsclo.so!ScInputHandler::NotifyChange(ScInputHandler * this, const ScInputHdlState * pState, bool bForce, ScTabViewShell * pSourceSh, bool bStopEditing)
        libsclo.so!ScTabViewShell::UpdateInputHandler(ScTabViewShell * this, bool bForce, bool bStopEditing)
        libsclo.so!ScInputWindow::ScInputWindow(ScInputWindow * this, vcl::Window * pParent, const SfxBindings * pBind)
        libsclo.so!VclPtr<ScInputWindow>::Create<vcl::Window*&, SfxBindings*&>(SfxBindings *& arg, SfxBindings *& arg)
        
        but we didn't allow the same for SetPosString which was called in the
        neighbouring place
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I9cec1b05d5d9b31c352d99bcb92045ead618a3d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175192
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175301
        Tested-by: Jenkins

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fe40cf26a3b416e4d3a71d4164f94ea10b68631e]

        pdf: /Win entry is deprecated in PDF 2.0 for launch actions
        
        /Win is deprecated, as well as /Mac and /Unix (which we don't
        write), so instead write /F directly, not under /Win entry.
        
        Change-Id: Ic6b71f6e7aba8d5e4a22e678f82fa5a70d9b7c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178674
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178776
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cb906a62d1df4be5988a85eed9b63505c78a72ff]

        pdf: remove functions that have been replaced by COSWriter
        
        The functions like appendUnicodeTextStringEncrypt, appendHexArray,
        appendLiteralStringEncrypt, appendLiteralString, appendHex have
        been copied into COSWriter and changed there to integrate with
        it, then the existing code was refactored piece by piece to use
        COSWriter instead. Now the final refactoring was done and the
        code isn't using those functions anymore, so the functions can
        be removed.
        
        Change-Id: Ibf33d730a7fe50fad5e0175db14d90912e8636a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178594
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178775
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a1bc9e9d6663b4d0828dd0057968738268bd4181]

        pdfium: remove duplication of converting a unicode string
        
        This adds a universal getUnicodeString function that takes a
        function call as a parameter, which is only a wrapped PDFium
        function call that returns a unicode string. The rest of conversion
        magic to OUString is then done by the function in one place.
        
        This reduces a lot of duplication as we had to copy the way how
        to convert the unicode string to OUString to every method.
        
        Change-Id: Id951e2dd0c8b98837ca096cd5f800b8df0449fa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178628
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178774
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5364b7b663b2be30d802474618dea3db14a2182a]

        tdf#160196 Embedded files are not allowed in PDF/A-1 and PDF/A-2
        
        This disables embedded/attached files in the UI as well as in the
        export filter for PDF/A-1 and 2. PDF/A-3 is almost identical to
        PDF/A-2 with the difference that it allows embedded/attached files.
        
        Change-Id: If8c3af6ab08ad320cf15618ead9c69fbd490d4f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178413
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178769
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [94378114b58a89812ce9d98887b0fd193c06b15d]

        pdf: Rearrange general tab of PDF dialog, add PDF vers. selection
        
        Repurpuses PDF/A combobox to also add PDF 1.7 and PDF 2.0 as
        options, as those are exclusive (either you have classic PDF, or
        you select PDF/A which is a special version of some PDF version.
        No need to have a check box for PDF/A anymore, so this was removed.
        
        - Moved the version selection to top
        - Added "Forms" frame, which for all the form options.
        - Moved Tagged PDF into "Structure" frame.
        - Reworded some text (extended tips, tooltips) for PDF versions
        
        Change-Id: I731222ee02afea6a49e4213d18f27d1beae9da10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178270
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178768
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [81b5ae3a5464189771b6953ae162847caa5a18dc]

        pdf: move appendName implementations into COSWriter
        
        Change-Id: I5c6b5bf685479643b32363159e047621473ad65a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178592
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178773
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5719a09bcbffa7ad0e1bedb19f4046aadfc38ce4]

        pdf: use "Default" enum value for PDF version when 0 is passed
        
        0 means to not use any specific version so always use the version
        that is set as default here.
        
        Change-Id: I1aa9aac9c67fdd8c8334f581f1b8b93a43e5c3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178591
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178772
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a30330702d4dcafab3f8b0deae2485997e28a01d]

        pdf: Fix embedded files when the PDF is encrypted
        
        When we encrypt the PDF and want to attach the ODF document to the
        PDF, the PDF file would not have any attachments when opened. This
        is because the encryption for the attachments and embedded files
        was not done correctly. This patch fixes this issue.
        
        Change-Id: I5bd8175f6067b8b684defa3b60746176f4314c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178447
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178771
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f45401ce130f1377163e977f52b037b7b46b4910]

        pdf: Don't write non-standard LO keys when using PDF/A or PDF/UA
        
        We write /DocChecksum and /AdditionalStreams entries into the
        trailer dictionary, which is not allowed by the standard in any
        case. To avoid a potential compliance checker to report errors
        because of this, the writing is shorted out if PDF/A or PDF/UA
        are enabled.
        
        Change-Id: I98247e89f1984f158ffbcb78b9e3713fcab053fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178414
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178770
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-25  Patrick Luby  <guibmacdev@gmail.com>  [1846448d81aab9812410a30303c0c36a41a825b6]

        tdf#164428 Skia/Metal needs flush after drawing progress bar
        
        Also, move much of the duplicate code in the two AquaSalFrame::Flush()
        methods into a new AquaSalFrame::doFlush() method.
        
        Change-Id: I59f597692b7d5bc3035181681b2af8349c9812b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179374
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-25  Hossein  <hossein@libreoffice.org>  [04b54d560dd9029e10b026210ecd9105e0368420]

        Prevent vcl app crash without translations
        
        Previously, vcl app with gen UI backend was always crashing when no
        translation files where available. This patch fixes that for gen UI
        backend.
        
        This crash happens in minvcl example, when changing one of the LibreOffice
        ui files to a minimal Glade .ui file that contains the used UI elements.
        
        One can run the minweld example with gen ui backend with:
        
        $ export SAL_USE_VCLPLUGIN=gen
        $ ./bin/run minweld
        
        Change-Id: Ia3bf7671577b6b8013cae9b54a5469213bf65601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178750
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-25  Sebastian Andrzej Siewior  <sebastian@breakpoint.cc>  [dad9b00e8258da13e42211f7509cfb182f18d7fc]

        vcl/qa/cppunit/GraphicTest: Don't test for the exact size of the png file.
        
        Building with zlib-ng instead of zlib leads to the following error in the
        testsuite:
        
        | [_RUN_____] testSwappingGraphic_PNG_WithGfxLink::TestBody
        | ./vcl/qa/cppunit/GraphicTest.cxx:528:testSwappingGraphic_PNG_WithGfxLink::TestBody
        | equality assertion failed
        | - Expected: 319
        | - Actual  : 318
        
        The different implementation of deflate() leads to a different result.
        
        Use an approximation of the expected size instead of the exact value.
        
        Change-Id: I173164bc3b1e6dd37eb48fe42093527069a54075
        Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177440
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-25  Mike Kaganski  <mike.kaganski@collabora.com>  [91b1153bb75d7527e7de3aacc476259563292ab4]

        Move LIBO_USE_SOURCE_LOCATION to o3tl for possible reuse
        
        Change-Id: I045fc1d86576f6017def01a14dd9a091ee35a544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-25  Simon Chenery  <simon_chenery@yahoo.com>  [f90d00a43f9fd1e14ac42f43c11e5f7eb966a355]

        tdf#147021 avoid use of SAL_N_ELEMENTS macro
        
        Change-Id: I320f09b918c75fe83ea7edea2d500a6b2b86b519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178081
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-25  Michael Weghorn  <m.weghorn@posteo.de>  [4b547f11ae3e943e67c195a67a033307ce7f1d6d]

        tdf#130857 qt weld: Defer QDialog deletion
        
        Instead of deleting the QDialog owned by the
        QtInstanceDialog in the QtInstanceDialog dtor
        right away by calling std::unique_ptr<QDialog>::reset,
        instead mark the object for deletion by calling
        QObject::deleteLater [1] on the dialog object, which schedules
        the object for deletion when control returns to the event
        loop.
        
        Also switch QtInstanceDialog::m_pDialog from a unique_ptr
        to a plain QDialog*.
        
        This fixes crashes seen with the current qtbase git dev branch
        after qtbase commit
        
            commit 84a5f50c7766c99f62b22bb4388137e0aa8dd13d
            Author: Shawn Rutledge <shawn.rutledge@qt.io>
            Date:   Tue Nov 12 10:04:31 2024 +0100
        
                Move QContextMenuEvent synthesis from QWidgetWindow to QWindow
        
        The crash was quite reproducible for me by running LO with the qt6 VCL
        plugin and SAL_VCL_QT_USE_WELDED_WIDGETS=1 (to enable use of
        native Qt widgets), opening the "Help" -> "About LibreOfficeDev"
        dialog and closing it by clicking the "Close" button with the
        left mouse button.
        
        Backtrace of the crash:
        
            (rr) bt
            #0  0x0000000000000000 in ??? ()
            #1  0x000019667a96b92f in QWidgetWindow::handleMouseEvent (this=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:675
            #2  0x000019667a96a145 in QWidgetWindow::event (this=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:292
            #3  0x000019667a86fe10 in QApplicationPrivate::notify_helper (this=0x56488e07aae0, receiver=0x5648961bd080, e=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3304
            #4  0x000019667a873d2d in QApplication::notify (this=0x56488e067420, receiver=0x5648961bd080, e=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3254
            #5  0x00006f736e25acc9 in QCoreApplication::notifyInternal2 (receiver=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1122
            #6  0x00006f736e25bb39 in QCoreApplication::sendSpontaneousEvent (receiver=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1578
            #7  0x0000555757871f72 in QGuiApplicationPrivate::processMouseEvent (e=0x5f6d64003360) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2485
            #8  0x0000555757871136 in QGuiApplicationPrivate::processWindowSystemEvent (e=0x5f6d64003360) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2212
            #9  0x0000555757958a4d in QWindowSystemInterface::sendWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1113
            #10 0x00005557579588fe in QWindowSystemInterface::flushWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1082
            #11 0x0000393946e55875 in QtWaylandClient::QWaylandDisplay::flushRequests (this=0x56488e0ca590) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:524
            #12 0x0000393946e5a946 in QtWaylandClient::QWaylandDisplay::qt_static_metacall (_o=0x56488e0ca590, _c=QMetaObject::InvokeMetaMethod, _id=4, _a=0x7ffe9cb172a0)
                at qtwayland/src/client/WaylandClient_autogen/include/moc_qwaylanddisplay_p.cpp:95
            #13 0x00006f736e331954 in doActivate<false> (sender=0x56488e06c0e0, signal_index=4, argv=0x7ffe9cb172a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4151
            #14 0x00006f736e3273e3 in QMetaObject::activate (sender=0x56488e06c0e0, m=0x6f736ec1ec68 <QAbstractEventDispatcher::staticMetaObject>, local_signal_index=1, argv=0x0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4199
            #15 0x00006f736e243c79 in QAbstractEventDispatcher::awake (this=0x56488e06c0e0) at qtbase/src/corelib/Core_autogen/include/moc_qabstracteventdispatcher.cpp:129
            #16 0x00006f736e84d1e8 in QEventDispatcherGlib::processEvents (this=0x56488e06c0e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:406
            #17 0x0000555758154088 in QPAEventDispatcherGlib::processEvents (this=0x56488e06c0e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #18 0x00006a0d3b6d9b82 in QtInstance::ImplYield (this=0x56488e111bf0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:464
            #19 0x00006a0d3b6dcc01 in QtInstance::DoYield (this=0x56488e111bf0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:475
            #20 0x00005abe4e4b26e6 in ImplYield (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:385
            #21 0x00005abe4e4b207f in Application::Yield () at vcl/source/app/svapp.cxx:473
            #22 0x00005abe4e4b1e60 in Application::Execute () at vcl/source/app/svapp.cxx:360
            #23 0x00004759668eccab in desktop::Desktop::Main (this=0x7ffe9cb18ec8) at desktop/source/app/app.cxx:1679
            #24 0x00005abe4e4d3bc6 in ImplSVMain () at vcl/source/app/svmain.cxx:230
            #25 0x00005abe4e4d57b9 in SVMain () at vcl/source/app/svmain.cxx:248
            #26 0x00004759669665da in soffice_main () at desktop/source/app/sofficemain.cxx:121
            #27 0x000056486abf0a6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #28 0x000056486abf0a47 in main (argc=1, argv=0x7ffe9cb190d8) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        The segfault happens when calling
        
            d->maybeSynthesizeContextMenuEvent(event);
        
        , i.e the virtual QWindowPrivate::maybeSynthesizeContextMenuEvent.
        This is because the QWidgetWindow object and its QWidgetPrivate
        have already been deleted when processing an earlier event
        triggered by the mouse click, see backtrace below.
        
        Not deleting the object right away but marking it for deletion later
        makes sure the object is still valid when the event gets processed,
        and then deleted afterwards.
        
        Backtrace of how the QWindowPrivate object got deleted earlier
        (reverse-debugged with rr) - see frame 17 for the dtor (i.e. the
        code that was adjusted in this commit now to fix the problem):
        
            Thread 1 hit Breakpoint 1.1, QWindowPrivate::~QWindowPrivate (this=0x564896397450) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:211
            211     QWindowPrivate::~QWindowPrivate()
            (rr) p this
            $6 = (QWindowPrivate *) 0x564896397450
            (rr) bt
            #0  QWindowPrivate::~QWindowPrivate (this=0x564896397450) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:211
            #1  0x000019667a96f039 in QWidgetWindowPrivate::~QWidgetWindowPrivate (this=0x564896397450) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:34
            #2  0x000019667a96f05d in QWidgetWindowPrivate::~QWidgetWindowPrivate (this=0x564896397450) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:34
            #3  0x00006f736e33a7e8 in QScopedPointerDeleter<QObjectData>::cleanup (pointer=0x564896397450) at qtbase/src/corelib/tools/qscopedpointer.h:24
            #4  0x00006f736e32e134 in QScopedPointer<QObjectData, QScopedPointerDeleter<QObjectData> >::~QScopedPointer (this=0x5648961bd088) at qtbase/src/corelib/tools/qscopedpointer.h:81
            #5  0x00006f736e31cdb2 in QObject::~QObject (this=0x5648961bd080) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:1149
            #6  0x00005557579435ec in QWindow::~QWindow (this=0x5648961bd080) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:206
            #7  0x000019667a969be6 in QWidgetWindow::~QWidgetWindow (this=0x5648961bd080) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:179
            #8  0x000019667a969c2d in QWidgetWindow::~QWidgetWindow (this=0x5648961bd080) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:160
            #9  0x000019667a915351 in QWidgetPrivate::deleteTLSysExtra (this=0x564894d40bf0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1711
            #10 0x000019667a914f86 in QWidget::destroy (this=0x56488f3e8100, destroyWindow=true, destroySubWindows=true) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:12612
            #11 0x000019667a914504 in QWidget::~QWidget (this=0x56488f3e8100) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1565
            #12 0x000019667ad11705 in QDialog::~QDialog (this=0x56488f3e8100) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:394
            #13 0x000019667ad1174d in QDialog::~QDialog (this=0x56488f3e8100) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:386
            #14 0x00006a0d3b71e358 in std::default_delete<QDialog>::operator() (this=0x5648963f9fb0, __ptr=0x56488f3e8100) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #15 0x00006a0d3b71e478 in std::__uniq_ptr_impl<QDialog, std::default_delete<QDialog> >::reset (this=0x5648963f9fb0, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:205
            #16 0x00006a0d3b71e40d in std::unique_ptr<QDialog, std::default_delete<QDialog> >::reset (this=0x5648963f9fb0, __p=0x0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:504
            #17 0x00006a0d3b71b550 in QtInstanceDialog::~QtInstanceDialog()::$_0::operator()() const (this=0x7ffe9cb13630) at vcl/qt6/../qt5/QtInstanceDialog.cxx:30
            #18 0x00006a0d3b71b525 in std::__invoke_impl<void, QtInstanceDialog::~QtInstanceDialog()::$_0&>(std::__invoke_other, QtInstanceDialog::~QtInstanceDialog()::$_0&) (__f=...)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61
            #19 0x00006a0d3b71b4d5 in std::__invoke_r<void, QtInstanceDialog::~QtInstanceDialog()::$_0&>(QtInstanceDialog::~QtInstanceDialog()::$_0&) (__fn=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:111
            #20 0x00006a0d3b71b3fd in std::_Function_handler<void(), QtInstanceDialog::~QtInstanceDialog()::$_0>::_M_invoke (__functor=...) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290
            #21 0x00006a0d3b6e278e in std::function<void()>::operator() (this=0x7ffe9cb13630) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591
            #22 0x00006a0d3b6da31a in QtInstance::RunInMainThread (this=0x56488e111bf0, func=...) at vcl/qt6/../qt5/QtInstance.cxx:226
            #23 0x00006a0d3b71947b in QtInstanceDialog::~QtInstanceDialog (this=0x5648963f9f90, vtt=0x6a0d3b98fec8 <VTT for QtInstanceDialog>) at vcl/qt6/../qt5/QtInstanceDialog.cxx:30
            #24 0x00006a0d3b7195a0 in QtInstanceDialog::~QtInstanceDialog (this=0x5648963f9f90) at vcl/qt6/../qt5/QtInstanceDialog.cxx:28
            #25 0x00006a0d3b7196a9 in QtInstanceDialog::~QtInstanceDialog (this=0x5648963f9f90) at vcl/qt6/../qt5/QtInstanceDialog.cxx:28
            #26 0x00005abe4e4746f8 in std::default_delete<weld::Dialog>::operator() (this=0x564896171890, __ptr=0x5648963fa1f8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:93
            #27 0x00005abe4e4faefd in std::_Sp_counted_deleter<weld::Dialog*, std::default_delete<weld::Dialog>, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x564896171880)
                at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:527
            #28 0x00005abe4da1978a in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (this=0x564896171880) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:346
            #29 0x00005abe4da19706 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (this=0x5648961a7cb8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1069
            #30 0x00005abe4db3d6e9 in std::__shared_ptr<weld::Dialog, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (this=0x5648961a7cb0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1525
            #31 0x00005abe4db2e905 in std::shared_ptr<weld::Dialog>::~shared_ptr (this=0x5648961a7cb0) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:175
            #32 0x00005abe4e4f6a7b in weld::GenericDialogController::~GenericDialogController (this=0x5648961a7c90) at vcl/source/app/weldutils.cxx:58
            #33 0x000000444e3b8ce9 in AboutDialog::~AboutDialog (this=0x5648961a7c90) at cui/source/dialogs/about.cxx:142
            #34 0x000000444e5787b6 in std::destroy_at<AboutDialog> (__location=0x5648961a7c90) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:88
            #35 0x000000444e578795 in std::_Destroy<AboutDialog> (__pointer=0x5648961a7c90) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:149
            #36 0x000000444e57862f in std::allocator_traits<std::allocator<void> >::destroy<AboutDialog> (__p=0x5648961a7c90) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/alloc_traits.h:708
            #37 std::_Sp_counted_ptr_inplace<AboutDialog, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x5648961a7c80) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:616
            #38 0x00006a0d3b661e5a in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use (this=0x5648961a7c80) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:175
            #39 0x00006a0d3b661e35 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use_cold (this=0x5648961a7c80) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:199
            #40 0x00006a0d3b661e11 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (this=0x5648961a7c80) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:353
            #41 0x00006a0d3b661cf6 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (this=0x7ffe9cb13a30) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1069
            #42 0x00006a0d3b71ea39 in std::__shared_ptr<weld::DialogController, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr (this=0x7ffe9cb13a28) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1525
            #43 0x00006a0d3b71da14 in std::__shared_ptr<weld::DialogController, (__gnu_cxx::_Lock_policy)2>::reset (this=0x7ffe9cb13ae8) at /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1643
            #44 0x00006a0d3b71ae1c in QtInstanceDialog::dialogFinished (this=0x5648963f9f90, nResult=7) at vcl/qt6/../qt5/QtInstanceDialog.cxx:198
            #45 0x00006a0d3b71e9a6 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<int>, void, void (QtInstanceDialog::*)(int)>::call(void (QtInstanceDialog::*)(int), QtInstanceDialog*, void**)::{lambda()#1}::operator()() const (this=0x7ffe9cb13bd0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:127
            #46 0x00006a0d3b71e8c9 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<int>, void, void (QtInstanceDialog::*)(int)>::call(void (QtInstanceDialog::*)(int), QtInstanceDialog*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<int>, void, void (QtInstanceDialog::*)(int)>::call(void (QtInstanceDialog::*)(int), QtInstanceDialog*, void**)::{lambda()#1}&&) (args=0x7ffe9cb13fa0, fn=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #47 0x00006a0d3b71e803 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<int>, void, void (QtInstanceDialog::*)(int)>::call
                (f=&virtual QtInstanceDialog::dialogFinished(int), o=0x5648963f9f90, arg=0x7ffe9cb13fa0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:126
            #48 0x00006a0d3b71e77d in QtPrivate::FunctionPointer<void (QtInstanceDialog::*)(int)>::call<QtPrivate::List<int>, void> (f=&virtual QtInstanceDialog::dialogFinished(int), o=0x5648963f9f90, arg=0x7ffe9cb13fa0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:174
            #49 0x00006a0d3b71e6a6 in QtPrivate::QCallableObject<void (QtInstanceDialog::*)(int), QtPrivate::List<int>, void>::impl (which=1, this_=0x5648961544d0, r=0x5648963f9f90, a=0x7ffe9cb13fa0, ret=0x0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:545
            #50 0x00006f736e271f82 in QtPrivate::QSlotObjectBase::call (this=0x5648961544d0, r=0x5648963f9f90, a=0x7ffe9cb13fa0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #51 0x00006f736e331854 in doActivate<false> (sender=0x56488f3e8100, signal_index=7, argv=0x7ffe9cb13fa0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4139
            #52 0x00006f736e3273e3 in QMetaObject::activate (sender=0x56488f3e8100, m=0x19667b4289a8 <QDialog::staticMetaObject>, local_signal_index=0, argv=0x7ffe9cb13fa0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4199
            #53 0x000019667a86520b in QMetaObject::activate<void, int> (sender=0x56488f3e8100, mo=0x19667b4289a8 <QDialog::staticMetaObject>, local_signal_index=0, ret=0x0, args=@0x7ffe9cb13fe4: 7) at qtbase/src/corelib/kernel/qobjectdefs.h:306
            #54 0x000019667ad11f28 in QDialog::finished (this=0x56488f3e8100, _t1=7) at qtbase/src/widgets/Widgets_autogen/include/moc_qdialog.cpp:191
            #55 0x000019667ad11e55 in QDialog::done (this=0x56488f3e8100, r=7) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:617
            #56 0x00006a0d3b71b173 in QtInstanceDialog::handleButtonClick (rDialog=..., rButton=...) at vcl/qt6/../qt5/QtInstanceDialog.cxx:226
            #57 0x00006a0d3b658b0c in QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0::operator()() const (this=0x5648961351a0)
                at vcl/qt6/../qt5/QtBuilder.cxx:528
            #58 0x00006a0d3b658ae8 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_v--Type <RET> for more, q to quit, c to continue without paging--
            iew<char, std::char_traits<char> >)::$_0>::call(QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0&, void**)::{lambda()#1}::operator()() const (this=0x7ffe9cb14370) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:116
            #59 0x00006a0d3b658ac9 in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0>::call(QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0&, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0>::call(QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0&, void**)::{lambda()#1}&&) (args=0x7ffe9cb146d0, fn=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:65
            #60 0x00006a0d3b658a92 in QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0>::call(QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0&, void**)
                (f=..., arg=0x7ffe9cb146d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:115
            #61 0x00006a0d3b658a41 in QtPrivate::FunctorCallable<QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0>::call<QtPrivate::List<>, void>(QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0&, void*, void**) (f=..., arg=0x7ffe9cb146d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:337
            #62 0x00006a0d3b6589e8 in QtPrivate::QCallableObject<QtBuilder::tweakInsertedChild(QObject*, QObject*, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)::$_0, QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x564896135190, r=0x56488f3e8100, a=0x7ffe9cb146d0, ret=0x0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:547
            #63 0x00006f736e271f82 in QtPrivate::QSlotObjectBase::call (this=0x564896135190, r=0x56488f3e8100, a=0x7ffe9cb146d0) at qtbase/src/corelib/kernel/qobjectdefs_impl.h:461
            #64 0x00006f736e331854 in doActivate<false> (sender=0x56489581c360, signal_index=9, argv=0x7ffe9cb146d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4139
            #65 0x00006f736e3273e3 in QMetaObject::activate (sender=0x56489581c360, m=0x19667b414930 <QAbstractButton::staticMetaObject>, local_signal_index=2, argv=0x7ffe9cb146d0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4199
            #66 0x000019667a86538b in QMetaObject::activate<void, bool> (sender=0x56489581c360, mo=0x19667b414930 <QAbstractButton::staticMetaObject>, local_signal_index=2, ret=0x0, args=@0x7ffe9cb14717: false)
                at qtbase/src/corelib/kernel/qobjectdefs.h:306
            #67 0x000019667aab4f52 in QAbstractButton::clicked (this=0x56489581c360, _t1=false) at qtbase/src/widgets/Widgets_autogen/include/moc_qabstractbutton.cpp:253
            #68 0x000019667aab4e67 in QAbstractButtonPrivate::emitClicked (this=0x564893f024d0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qabstractbutton.cpp:381
            #69 0x000019667aab4cc1 in QAbstractButtonPrivate::click (this=0x564893f024d0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qabstractbutton.cpp:374
            #70 0x000019667aab616f in QAbstractButton::mouseReleaseEvent (this=0x56489581c360, e=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qabstractbutton.cpp:976
            #71 0x000019667a92c6fd in QWidget::event (this=0x56489581c360, event=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:8971
            #72 0x000019667aab5f8c in QAbstractButton::event (this=0x56489581c360, e=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qabstractbutton.cpp:933
            #73 0x000019667ac2dfb1 in QPushButton::event (this=0x56489581c360, e=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qpushbutton.cpp:684
            #74 0x000019667a86fe10 in QApplicationPrivate::notify_helper (this=0x56488e07aae0, receiver=0x56489581c360, e=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3304
            #75 0x000019667a871ae2 in QApplication::notify (this=0x56488e067420, receiver=0x56489581c360, e=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2781
            #76 0x00006f736e25acc9 in QCoreApplication::notifyInternal2 (receiver=0x56489581c360, event=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1122
            #77 0x00006f736e25bb39 in QCoreApplication::sendSpontaneousEvent (receiver=0x56489581c360, event=0x7ffe9cb15ad0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1578
            #78 0x000019667a870737 in QApplicationPrivate::sendMouseEvent
                (receiver=0x56489581c360, event=0x7ffe9cb15ad0, alienWidget=0x56489581c360, nativeWidget=0x56488f3e8100, buttonDown=0x19667b45b488 <qt_button_down>, lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false)
                at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2362
            #79 0x000019667a96b8bb in QWidgetWindow::handleMouseEvent (this=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:664
            #80 0x000019667a96a145 in QWidgetWindow::event (this=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidgetwindow.cpp:292
            #81 0x000019667a86fe10 in QApplicationPrivate::notify_helper (this=0x56488e07aae0, receiver=0x5648961bd080, e=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3304
            #82 0x000019667a873d2d in QApplication::notify (this=0x56488e067420, receiver=0x5648961bd080, e=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:3254
            #83 0x00006f736e25acc9 in QCoreApplication::notifyInternal2 (receiver=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1122
            #84 0x00006f736e25bb39 in QCoreApplication::sendSpontaneousEvent (receiver=0x5648961bd080, event=0x7ffe9cb16b98) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1578
            #85 0x0000555757871f72 in QGuiApplicationPrivate::processMouseEvent (e=0x5f6d64003360) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2485
            #86 0x0000555757871136 in QGuiApplicationPrivate::processWindowSystemEvent (e=0x5f6d64003360) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qguiapplication.cpp:2212
            #87 0x0000555757958a4d in QWindowSystemInterface::sendWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1113
            #88 0x00005557579588fe in QWindowSystemInterface::flushWindowSystemEvents (flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindowsysteminterface.cpp:1082
            #89 0x0000393946e55875 in QtWaylandClient::QWaylandDisplay::flushRequests (this=0x56488e0ca590) at /home/michi/development/git/qt5/qtwayland/src/client/qwaylanddisplay.cpp:524
            #90 0x0000393946e5a946 in QtWaylandClient::QWaylandDisplay::qt_static_metacall (_o=0x56488e0ca590, _c=QMetaObject::InvokeMetaMethod, _id=4, _a=0x7ffe9cb172a0)
                at qtwayland/src/client/WaylandClient_autogen/include/moc_qwaylanddisplay_p.cpp:95
            #91 0x00006f736e331954 in doActivate<false> (sender=0x56488e06c0e0, signal_index=4, argv=0x7ffe9cb172a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4151
            #92 0x00006f736e3273e3 in QMetaObject::activate (sender=0x56488e06c0e0, m=0x6f736ec1ec68 <QAbstractEventDispatcher::staticMetaObject>, local_signal_index=1, argv=0x0)
                at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qobject.cpp:4199
            #93 0x00006f736e243c79 in QAbstractEventDispatcher::awake (this=0x56488e06c0e0) at qtbase/src/corelib/Core_autogen/include/moc_qabstracteventdispatcher.cpp:129
            #94 0x00006f736e84d1e8 in QEventDispatcherGlib::processEvents (this=0x56488e06c0e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:406
            #95 0x0000555758154088 in QPAEventDispatcherGlib::processEvents (this=0x56488e06c0e0, flags=...) at /home/michi/development/git/qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:89
            #96 0x00006a0d3b6d9b82 in QtInstance::ImplYield (this=0x56488e111bf0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:464
            #97 0x00006a0d3b6dcc01 in QtInstance::DoYield (this=0x56488e111bf0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:475
            #98 0x00005abe4e4b26e6 in ImplYield (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:385
            #99 0x00005abe4e4b207f in Application::Yield () at vcl/source/app/svapp.cxx:473
            #100 0x00005abe4e4b1e60 in Application::Execute () at vcl/source/app/svapp.cxx:360
            #101 0x00004759668eccab in desktop::Desktop::Main (this=0x7ffe9cb18ec8) at desktop/source/app/app.cxx:1679
            #102 0x00005abe4e4d3bc6 in ImplSVMain () at vcl/source/app/svmain.cxx:230
            #103 0x00005abe4e4d57b9 in SVMain () at vcl/source/app/svmain.cxx:248
            #104 0x00004759669665da in soffice_main () at desktop/source/app/sofficemain.cxx:121
            #105 0x000056486abf0a6d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #106 0x000056486abf0a47 in main (argc=1, argv=0x7ffe9cb190d8) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=84a5f50c7766c99f62b22bb4388137e0aa8dd13d
        
        Change-Id: I3f547c1b1c1581d2f3ae092f2034d930640b0f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179312
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-25  Noel Grandin  <noelgrandin@gmail.com>  [193a8f64b4019391f7ad1c0418ddc52a094f2b6a]

        avoid some OUString <-> string_view conversion
        
        Change-Id: Iae4466aafb71cfe9b35dcd5b00c0aae9ccab7e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179261
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f24bb80e45c1693db33b47ee695436b2c8d5fbcd]

        tdf#163144 Undo crash when duplicationg a page with a new annotation
        
        Check if the annotation pop-up is set and only if it is, try to
        close it. Also added a test for this.
        
        Change-Id: Id2db041f2c0e917304377a747b1bb31bda0c6f5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174287
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Mike Kaganski  <mike.kaganski@collabora.com>  [30ca798d8136bfd48dcd11438d69396848024313]

        Mark some Calc slots as inactive in readonly mode
        
        They all modify the document model.
        
        Change-Id: I0ce145ec6dd741557da36598b77063be256f47f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179316
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-24  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [05dbc72aac392389d7f47fd4bf6c8986fb701833]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 614d35e5e05a8ac908446111d1cc71620248c288
          - tdf#163657 Remove/fix typos in Thai spelling dict
            
            Yet another set of removals/fixings of misspellings, non-standard
            variations, and irrelevant phrases randomly found in Thai spelling
            dictionary.
            
            With this, ph: fields are also selectively added for some entries
            based on the removed misspellings.
            
            Change-Id: I40cf85552693a0454c5769300d0ea874f9633240
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/179109
            Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-12-24  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7b5fc53e1378ab26c3d8cf6402351737ffd7b144]

        move HiddenParaPrint to SfxHint
        
        Change-Id: I94ab48328de791bb9e879b489cc9cb4e140b97de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179170
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-12-24  Mike Kaganski  <mike.kaganski@collabora.com>  [bb04dcc6050069bd22c2276fec860672bb5aff5e]

        tdf#128957: fix UpdateHdlMtfSize* handlers in ExportDialog
        
        Since the introduction of resolution support in the dialog in commit
        333d1e3dcc2e819f8c62c9713cca96fbedaba3de (impress186: #i4499# graphic
        dialog reorganisation - added support of bitmap resolution, 2010-06-16),
        the code handling points was wrong, multiplying by 72, where it needed
        to divide. This created an error times 72 * 72 = 5184.
        
        This change uses o3tl::convert for the task.
        
        Change-Id: I096c72422e477d28f08632f8902e31fcbb548c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179308
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [20dadf1713424f157232b9aa4988ef05df751aaa]

        pdf: fix PDF encryption and re-enable the test
        
        Slightly wrong loop exit condition when calculating the R6 hash,
        which caused that every now and then the document could not be
        decrypted correctly. This happened at least 1 time in 100 tries
        (usually it did not even take that much to encountered a test
        failure), but with the fix it worked correctly for 500 tries, so
        it seems this issue is now fixed.
        
        Change-Id: I5fa046892f36dabc367aabed1295802e805ee6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179299
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Noel Grandin  <noelgrandin@gmail.com>  [81f724c6fc87ff78270bceb7476e22c344e1993c]

        convert some warnings in SwTextCharFormat to assert
        
        Change-Id: I665db920f11108c29ac0cbbf44090f6ff4847e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179178
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d979137209a9579385bc26781007180608d903f9]

        cid#1401342 Uncaught exception
        
        Change-Id: I58c442ee3f85b0378c5eb772bcccbab0d0d7f38d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179264
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-24  Mike Kaganski  <mike.kaganski@collabora.com>  [b01e697b53607fef0ac3ab222b5b25a6eb0257a5]

        tdf#164446: fix internationalized FP input in Basic IDE Watch
        
        Now that tdf#97983 fix made the default conversion internationalized,
        the special handling of the Watch window input needs to do it in the
        other direction. Additionally, move ImpConvStringExt to the single
        place that uses it.
        
        Change-Id: I18a4043511f4a1b32f79410447e96c7679329886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179302
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-24  Noel Grandin  <noelgrandin@gmail.com>  [218023f3eacc1ca898cf07c5fc47aa5ebab10aaf]

        move RES_REMOVE_UNO_OBJECT to SfxHint
        
        Change-Id: I82936e0ddb685746a714e1929fc7682a68ef4d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179240
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eb135eb831eeb61cf873dcda94c00a2c13ecf3b4]

        pdf: add Default entry to PDFVersion enum , use it in constructor
        
        This is added so we can change the default more easily.
        Also documented some entries on what PDF version those are based
        on.
        
        Change-Id: Ic11150017b3f3471125cea854a58d0762bc976c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178269
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178767
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2f37637ad905cd84420da02dae1fefed548caa27]

        pdf: move COSWriter complex methods into the cxx source file
        
        So those are not inlined needlesly all over the PDF writer code.
        
        Change-Id: Ic3e3b442a3dc95d3bd944e7d7add285fe1beb772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178412
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178766
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2043785084e13ec5244f43dc08e6a581ba69f1db]

        pdf: use COSWriter to write literal and unicode strings
        
        Change-Id: I72f86ea48fd2d0cdaaca843e90b97e7286c34cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177453
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178765
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6912dd8dda491740d35e1aabe8518330b412684e]

        pdf: properly encrypt metadata (for Revision 6+)
        
        Metadata should also be encrypted, and it is the default, so also
        encrypt the metadata and properly set the flags in encrypt dict.
        
        Change-Id: I083faa8174a1ed4b43ecaceaa11e27e87562e1b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177038
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178764
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7257cd8b5420e398f14456e6713de61850223dba]

        pdf: get rid of PDFWriter::AppendUnicodeTextString
        
        It's not needed when we have COSWriter instead that could be used.
        Needed to change IPDFEncryptor from unique_ptr to shared_ptr so we
        can share it with COSWriter, but without the need to be set.
        
        Also rename the string literal and unicode methods that take a key
        to writeKeyAnd... methods to be mroe explicit. We will need methods
        that don't write a key sooner or later.
        
        Change-Id: I15c5d347c6658f7ded2de940acc968dee053d460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177037
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178763
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ad714ad52c49d8fdf6da4a227307130b14841f79]

        pdf: comment out test, which causes random failures
        
        Need to find where is the bug in the implementation first.
        
        Change-Id: Ib9df001480acf7e24f3834314e6fa672b794ef29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179272
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2305fe302e12c4256e452589e2533772d4213e59]

        pdf: create a new document for PDF version test, fix spelling
        
        Change-Id: I5c898b3dd58610243be6b0273aaaa889704f5eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179255
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-24  Eike Rathke  <erack@redhat.com>  [f91f3484bbac46ed762bf9ff356b690224e20096]

        Excel im-/export function name mapping for EASTERSUNDAY, tdf#162177 follow-up
        
        Which isn't exactly needed because compiler uses
        RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML but the mapping is used
        for css::sheet::XFormulaOpCodeMapper even if that is almost (?)
        dead in Excel context. Gave warnings like
        
        warn: sc:566679:566679:sc/source/filter/oox/formulabase.cxx:1381:
        OpCodeProviderImpl: :initFuncOpCode - no opcode mapping for function ODF 'ORG.OPENOFFICE.EASTERSUNDAY' <-> OOXML '_xlfn.ORG.OPENOFFICE.EASTERSUNDAY'
        Change-Id: I0e7a74ef24fd03bd533b486bd11dab1f6287e2c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179262
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Eike Rathke <erack@redhat.com>

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce67fc823880ac81dbf66f66c97fde21e9e5a733]

        crashreporting: more checks of pActiveViewSh
        
        See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::SetMode(ScInputMode,rtl::OUString%20const%20*,ScEditEngineDefaulter%20*)
        
        Change-Id: Ib0a07f4ee8d7da05960eaac14af561a6b624b0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179263
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1d4da92f7ce8026a5433822d9b8f5728a308bb75]

        cid#1607743 Data race condition
        
        Change-Id: Ic7f4744fdb1cf43f6bcf6c66752f37be25c06cb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178494
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [42e7722ddf80937fc969a70c0e6f55f55085876a]

        crashreporting: check pActiveViewSh
        
        See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::UpdateFormulaMode()
        
        Change-Id: I87ccb3c07b08ebe0a77b1ebb6a5f4e8c2ea89894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179259
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [a3b43e95baefd03f257765d9153b9827c337b90f]

        Simplify ImpScan
        
        Change-Id: I8928d3c7f0fc6884a75c05e77908df7f482c9e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179246
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad15ee137123a9657886f3a25692e8b8b707b080]

        crashreportScraper: open links in new tab
        
        Change-Id: I577b8d9ceff6c1aa74128a14a1e0f8ef57c3fd89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179258
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [634062aef12161bbec164e3aaed7fbe37618cd68]

        sw: FindSttNodeByType -> FindStartNodeByType
        
        Change-Id: I37dbe6583ef121fbb2439d413eaa6bcad9d07f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179257
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a42e3db9c644906df801cbc65b71c234fec4f8d]

        optimise ScBoundsProvider::GetIndexTowards
        
        Especially when laying out rows in sheets with thousands of rows.
        By pushing the work down to a new GetRowForHeightPixels method,
        we can do the work in only a couple of iterations of the loop, because row heights are normally represented by only a few spans.
        
        Change-Id: If3f62a131a3e7a0794d7352d7c6c1a5de0ef2df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179086
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [31427786778946b9d6f0f23731fdaae40e967e21]

        pdf: move PDFStructureWriter into own file, rename to COSWriter
        
        This needs to duplicate some functions from pdfwriter_impl to make
        this possible.
        
        Change-Id: Ie738c9690306d6498c883f034a3fcd6483f24eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176985
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178762
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b8ea5a835ec07d0f84cd8ec2d0dab976edcfcebe]

        pdf: change encryption to use new random IV on each encrypt call
        
        This is how it's supposed to work - not to have same IV all the
        time we are encoding (that's why the IV is written to the stream).
        
        Change-Id: I17a1d98bd5cf6f06b830eaea04822b8793d4e0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176984
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178761
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [807f977b389f196d17701f01ddbb40b297face95]

        pdfium: Log error when opening fails (useful for tests)
        
        Change-Id: I597d82bb40c73b900c08c8b37fd303e8f5e98eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179179
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [e080eebd4ebb20ddb0aff1f168096ec22b326546]

        crashreporting: check Lower()
        
        See https://crashreport.libreoffice.org/stats/signature/SwLayoutFrame::AdjustColumns(SwFormatCol%20const%20*,bool)
        
        Change-Id: I690a6358c8964f5511aedf3246384649cf004d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179234
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce913724f648061b534098f2deda362791e15386]

        crashreporting: check Lower()
        
        See https://crashreport.libreoffice.org/stats/signature/SwRowFrame::ShouldRowKeepWithNext(bool)
        
        Change-Id: I49ac8312e0288471780c405bb2cd7eb66163ab43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179233
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [cac9c7db6257b27724d90d4a355e52e456ef7e08]

        i18npool: drop macro
        
        Change-Id: I517ab7ba57c5f91282b6271e64113d868191dd5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179225
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [a3a7927408a26a70e5789df5246bff165b5b43c3]

        Simplify a bit
        
        The previous code made sure that cNonIntntlDecSep is always equal to
        IntntlDecSep (in the code handling bOnlyIntntl). Frop the redundancy,
        and make the variable names simpler.
        
        Change-Id: I31c994cd49bdbf007e110f593297acf112cc420b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179198
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [e40b541d7ae6acdcfda19e54a12a4dbc59bfbd09]

        Fix a copypasta
        
        From commit 9e9f39d171cafa035d7b8e74187e25c3581cb89d (resolved
        rhbz#919020 Basic CDbl() and CSng() scan localized number, 2013-03-19)
        
        Change-Id: I871d7fb06ccb5d15723f7acfb57701890607055f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179197
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-23  Balazs Varga  <balazs.varga.extern@allotropia.de>  [78dbd341bb5023448af2c3eefceb5a840fd6d8d9]

        tdf#164383 - sw a11y fix unnecessary "Avoid simulated captions" warning
        
        for caption frame.
        
        We should not have "Avoid simulated captions" warning about correct captions.
        
        Change-Id: I57fe53c5f9e1aa2affe0aec6520d1d6eed5d6990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178927
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [e6d71b9381aba8531c0ebf635c11508e5389fdc6]

        tdf#42989: don't set fake ATTR_VALUE_FORMAT for multi-format selection
        
        Change-Id: Iaed133b19c4d870ff85fd9d2dd69db36318bb28e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179190
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [750e4d32aa468a91169764144bdf9b59b3a70a31]

        Simplify a bit
        
        Change-Id: Ic02ee03a800e3e92fafd73efed5aa0fd803f454b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179195
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [2559f6329dd285b3e0e27f6a26091a47326b328d]

        sc: move these to slowcheck
        
        so Jenkins will tests them on all platforms
        
        Change-Id: Idb17dc34b4b1f26067ed160037c7d81b800ed8f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178801
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [70978cecc68328498530488d3674e5b7bf439b9d]

        Fix typo
        
        Change-Id: I0d22de1cc8e5a9817770c9cee9abbc3833b3b973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178938
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8853bc68e0df00b961aae5eece9d1996d7119c6]

        Fix typo
        
        Change-Id: I80788a1abf4c8c63821dd3ad3cc5b213500a9ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178982
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f72255d3473bb9141e119698fc14eca2207967c4]

        Fix typo
        
        Change-Id: I3ded88c7080b8c009937223bc9845367872dd25f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178939
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d74738ef156b6c468fd8aa0fb9e0528f04cf5c07]

        tdf#132111: don't claim a number format for multiselection / no set format
        
        The "not set" state for RES_BOXATR_FORMAT is handled explicitly in many
        places, e.g., in SwTableBox::HasNumContent. This allows to detect number
        entered into cells without explicit format. Thus, this state is not the
        same as "text" number format, and it must not be selected in the Number
        Format dialog. The same is for multiselection with different formats.
        
        Change-Id: I4f4aa66a2cbfd1bf2efa8b99a6e7a2cf9c119712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179177
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d2b593d95da7416562eaade7e2b2cf59b3cd7fbe]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: If3ea044a9f63e8fdbf920a40e8309f247a23c491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177153
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ed3fe52aba6b51284d3dfa6666cf40ac97ddc72e]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ib84ec9730aca0b528a61f06c1ac5a4ace7ae77fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177134
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d44a06a611f54fbf8bd2b613fd7fb278889b1011]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Iae87151a8d16052864f587edfd97fe3eb2d8ba24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177087
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [76b8571e2c1baeccb14fdfd46812c0d398c8f8fb]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ie7e8a0e2f489126974b75c61e3b53d0014d01dcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177133
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [178715ac8c3923ab3a1589a3ece364f8db0642c6]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ia0f52455804aadb8b8dff68a2665a409c9173b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177182
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [09f820eff0620bd685d1b4f859787cbab70774fe]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I34fcfda19bc9ff35b49faf8892ab14c0f9808943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177184
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ce763f282db7b6814bef84e4461794dd2c4bed59]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I32c8a4c8dd56ef781f40db1d3ca66823dd9b995f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177185
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c1bfe401061d7d23353fe5b96299d98b86f5ff9a]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I051f33ac28bdc1e3922d2d390ff3234204b80688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177186
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4eb05e0c0656516fce68475dc9be415874530094]

        pdf: fix saving external PDF with form fields (CONTINUED)
        
        This updates the test with comments and adds options at test start
        to make the test more robust (without those it can fail depending on
        the execution order of other tests)
        
        Change-Id: Ia7ea7e8810cc63b754d2d7f1ff1757839026ed3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178760
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e019575b64c4e33d4133ff10d45bedb9daa59cd2]

        cid#1636855 Out-of-bounds read
        
        Change-Id: Id2573d678b0059c1929d1a896cbfdf863676f945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179142
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [119aa2a770e54fa28f41dae3ca55f883393266ce]

        reduce the amount of casting
        
        Change-Id: I70f5607d8d5ccdadf1f5c69c846c93821f7681df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179141
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3efd05df94e417d4534ef5446c947f83b2c71072]

        cid#1636857 Dereference before null check
        
        Change-Id: Ib4411323cb5b1e1a44c56e890b6c0c1266d93eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179140
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0f76224163cc9abed30d4964f58a35e6d33bf95d]

        cid#1636856 silence Explicit null dereferenced
        
        and
        
        cid#1636859 Explicit null dereferenced
        
        Change-Id: I6e618bebd0f61a1e796b367343bb98e7a01d29b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7aa24c8064c7f6562a1a98f087b468bdc379133a]

        cid#1529286 silence Explicit null dereferenced
        
        Change-Id: I03909c8ed7e9f2bf410412b02790aee0fbca6d58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179138
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [40516b3ef9f430204d25e8a7d91ab5ca63475181]

        cid#1636858 Dereference before null check
        
        Change-Id: I03aa87d1a265761ac2f781e33b6136a4c38cbb31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179137
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0920e5dd036f956ab3956a22e47edbd5f2d57071]

        Resolves: tdf#161832 select row before update that depends on selection
        
        Change-Id: Ic1d291a68009749ce1464de60a78baf3047ddcc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179092
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dfab7782e1577ce40bab68330347edc48ff05389]

        crashreporting: disable load from template during print preview
        
        Change-Id: Ifc60a01f0e5e1f6cdab3680e69202f98471c2a7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [bb9b4aaf3dabe582a18e544d25b15aa2f8f3d78e]

        cui: Resave namedialog.ui with glade 3.40
        
        This dialog can e.g. be triggered via "Tools"
        -> "Options" -> "Appearance", then clicking the
        "New" button.
        
        Change-Id: I59b2195274ef1ff7f56057dc439b03bb0610d106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179111
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [0646d79de9ca728eb03b2de62c47de4194ec9fa1]

        tdf#130857 qt weld: Support "Name Dialog"
        
        Declare support for the name dialog that e.g. gets used
        in "Tools" -> "Options" -> "Appearance" when clicking the
        "New" button.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: Idaa3190d45efba87a74ef80a2999f3c6be7fa90d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179110
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [0664f11de7e654e4279559858c5f14206a85f22e]

        tdf#130857 qt weld: Implement QtInstanceWidget::queue_resize
        
        Call QWidget::adjustSize [1].
        
        [1] https://doc.qt.io/qt-6/qwidget.html#adjustSize
        
        Change-Id: Ic191d65b9c7a3aee5e0e9c945773d7732719d4e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179099
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [a7428730f7088e3eb22e22a094754d2c9cae2276]

        tdf#130857 qt weld: Introduce QtInstancePopover
        
        When encountering a "GtkPopover" object in a .ui
        file, create a QWidget with window flags Qt::Popup
        and set a layout, as weld::Popover is a weld::Container
        subclass.
        
        Add new QtInstancePopover that QtInstanceBuilder::weld_popover
        creates.
        For now, methods in that class simply trigger an assert;
        actual logic still needs to be implemented.
        
        Change-Id: I9a0dfefd9fb79d24fe40dd5efe13ef0c3ab9b7fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179098
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [bb111c22a6093ec1f5edc5890d7ec6d238362c02]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_pixel_size
        
        Change-Id: I082430e653f5634ecdcc101b370f531b2c0e25cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179097
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de>

2024-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [342470f03960274da41c608fc87688f3954d08fb]

        tdf#130857 qt weld: Implement {s,g}etters for scroll area min/max/val/step
        
        Change-Id: I698e98ac16d8e1f2cd1e01a50570bd9012c94952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179095
        Reviewed-by: Michael Weghorn (away) <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [141f3fd15633803afa720837405a0bacbc2726cb]

        Simplify abstract dialog impls using vcl::AbstractDialogImpl* in sc
        
        Change-Id: Iff9ac377a5cfa259c5911632ad16d2b1e3269868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178986
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [729dfe5baa7dc3cfa1365cbed0ac09ff28332bed]

        Simplify abstract dialog impls using vcl::AbstractDialogImpl* in sd
        
        Change-Id: I93f40aef003aa52b4eef173f8f481c99fe4c0489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178985
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [e04d5aef350a2cee7bdc7d661be1d10a90d75086]

        Simplify abstract dialog impls using vcl::AbstractDialogImpl* in sw
        
        Change-Id: Ie2816ab4f4ad5f4d703d4f6669ae16a9fa60933e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [99df3eb3702b00268774287c242ccd16a272c899]

        Factor out AbstractDialogImpl template for reuse
        
        Add a ctor to /opt/lo/bin/clang-format -i include/vcl/abstdlgimpl.hxx
        to construct the dialog in-place, to simplify factory methods.
        And move two abstract dialog impls where all others are in cui
        
        Change-Id: Ia3f3a5d6c1aaa5a9aca9c11990f833842e4536e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178983
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4072e87b4e1b3a5e6c84be5f008a72dea04fb48c]

        crash reporting: use SfxRequest to get parent for dialogs
        
        0: return pWindow ? pWindow->GetFrameWeld() : nullptr;
        2: SfxNewFileDialog aNewFileDlg(GetView()->GetFrameWeld(), SfxNewFileDialogMode::LoadTemplate);
        
        Reproducible by adding "LoadStyles" to the menu in writer, then print
        preview and then use that "LoadStyles" entry.
        
        Also dispatch "SID_TEMPLATE_LOAD", as used by "Load Styles from Template"
        entry in the dropdown from the "Styles Action" toolbar of the style
        panel, with an explicit frame it is associated with.
        
        Change-Id: I3d536b897fbf6be9e20e4238e6a761df56ac9701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179084
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [6eb53d3ecc839d5988a581132c81bfdf9ee2fa69]

        tdf#164233 vcl: Fix and simplify spin field mouse over check
        
        Instead of checking individually whether the mouse pos is
        over the SpinField's up or down button or the `mpEdit`,
        just check the SpinField's whole rectangle.
        
        The mouse event pos is relative to the SpinField, so
        use (0, 0) for the top left position of the SpinField's
        rect used in the check.
        
        This is not only simpler, but also fixes the case
        of the UNO control when the "Spin Button" options is disabled
        in which case there are no buttons and `mpEdit` is null, so
        `bMouseHovered` would always be false and adjusting the spin field
        value for that control using the mouse wheel wouldn't even work when
        mouse-hovered after the initial check was introduced in
        
            commit 869b88488ac443cc64943254064da20b0f361c56
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 13 16:37:45 2024 +0200
        
                tdf#160824 vcl: Require mouse over spinfield to mouse-wheel through values
        
        Change-Id: I3a2ee3af8af872e4a330a4d5e9f5cd6a2de89754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179085
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [938a5ce4c5ddc149362f800e33cb8913913a2616]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7bb37bc63384aa1654041c19cceac7463266f9fc
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I17e0a401077dd9cfc491eba7be3fb76032ebf87c
            
2024-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [31647b5449df6b64a0dc12c4ce22aceb0ceff039]

        Re-write ScTable::GetRowForHeight
        
        Cleanup up this method, making it more organised in how it iterates over
        spans,
        and adding asserts to verify assumptions.
        The asserts uncovered that we are sometimes fed bad data, so now we deal
        with
        that (and not sanitising the input is possibly why the original code was
        a little weird).
        
        Also, now that we are returning correct data, our caller does not need
        to correct the return value
        
        Change-Id: I094931bb2e93a3273b7a928fc7e83eed75e3db51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [8dc14858924afe317235dd870e1e367dcfcd754d]

        weld: Don't use "upper" as param name for lower
        
        Change-Id: I31e7c5f48680d5196db6f44e8e3cfd31d5a5fda9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2b7b8106ecdab2f62f5239462b65ed6a2a12395e]

        pdf: implement PDFEncryptor for PDF (2.0) encryption V5R6
        
        PDFEncryptorR6 implements PDF 2.0 encryption (ver. 5 rev. 6) using
        AESv3 (256 bit key length). The PDFEncryptorR6 is enabled when the
        PDF output is PDF 2.0 (other versions have been deprecated, so it
        is the only one available in PDF 2.0).
        
        Change-Id: I27f270197910405b5c2378a3873d2495f52f3206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176885
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178759
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7ea66a327fd8d66350dbb931325104ad19097ec1]

        pdf: move creating access permissions to common place
        
        The access permission are needed independent to the kind of PDF
        encryption so they should be in a common place so they can be
        reused. PDFEncryptionProperties is the best place to create the
        value anyway.
        
        Change-Id: Ic6e6c3d9a8cb314523c0305eba9e64f3734d52b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176884
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178758
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [186e997c559c7e5d4b9462f9b4be6a935cdd04cd]

        tdf#164171 Improve tooltip for Open Documents
        
        Change-Id: Icee61b29fa1f233c6c28e47c57343820a1f723c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178953
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [3f776f44d704e1c2786d461fe06aa9335192c1df]

        tdf#130857 qt weld: Implement {g,s}etting scroll bar thickness
        
        Do it in a similar way as the GtkInstanceScrolledWindow
        implementation.
        
        Change-Id: I92d5b1d55ed390e012e59525dd9fc9e9ffc72cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178977
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [71d90c236d57580e3e81adcd09ea5abe5be8a8d2]

        tdf#130857 qt weld: Implement scroll bar policy {g,s}etters
        
        Change-Id: I0ee4cececc40f21a6ef4eeb034c44727578d309c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178976
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [d4317567357228f75eb10f22decc55ac2be26dd2]

        tdf#130857 qt weld: Handle more QtInstanceTreeView::insert params
        
        * Don't always append, but evaluate the insert position
          (with special value -1 to append).
        * If an iterator is passed for `pRet`, set its model
          index to the new item's model index.
        
        Change-Id: I2db8718f4b572d4ae3dcfa7183033f04174b72a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178975
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [8c98986b5bd5e2e841a2e1a2f78621f3d4d7b8da]

        tdf#130857 qt weld: Implement QtInstanceWidget::set_busy_cursor
        
        This is basically the the Qt port of the existing
        GtkInstanceWidget::set_busy_cursor.
        
        Gets called e.g. from RemoteFilesDialog::OpenURL
        (via the weld::WaitObject ctor/dtor).
        
        Change-Id: I0b61ae33ad47190c8f2258745ab483152dde1331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178974
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [78872b270dfca6cfa25e3e08a5539362f60f1174]

        tdf#130857 qt weld: Implement most QtInstanceMenuButton methods
        
        The QToolButton::menu methods to retrieve the menu doesn't
        exist in the QAbstractButton base class, so let
        QtInstanceMenuButton take a QToolButton pointer.
        
        Implement the menu item related methods in line
        with the corresponding QtInstanceMenu methods.
        
        Change-Id: I4d97f528fe112ba3b94069ce0173a5b63a415ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178973
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [0f3cf3091666ef393e189b539aa9a808e168df81]

        tdf#130857 qt weld: Set menu button's menu defined in .ui file
        
        Make the existing local helper function `extractPopupMenu`
        used by VclBuilder a static method in the BuilderBase base
        class for reuse by QtBuilder.
        
        Use it in QtBuilder::makeObject to evaluate
        the "popup" property for a "GtkMenuButton"
        object, get the corresponding QMenu and set
        it for the button.
        
        The code currently assumes that the corresponding
        menu is aleady known, i.e. was defined earlier in
        the .ui file than the menu button it belongs to.
        VclBuilder doesn't rely on that, so a handling
        similar to there could be implemented as and when
        needed.
        
        Change-Id: I95446fb7a369f2cfee0d8d51432933582bbfd570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178972
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [9c11d1f4350a1a49eb955d9d280dff0adcabf33b]

        tdf#130857 BuilderBase: Drop explicit call to VclPtr::get
        
        There's no need to explicitly call VclPtr::get
        to get the Menu* from the VclPtr<Menu>, so drop it,
        also to make the code reusable for QtBuilder, where
        the template type `MenuPtr` is just `QMenu*`, so there's
        no `get` method to call.
        
        Change-Id: I45eb23791a8b6cd099b79e276bdb18c3b8199923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178971
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [33d8c0637e0096ed93e45f9a99b0ff2f7eaaca8b]

        Resave remotefilesdialog.ui with glade 3.40, but restore 2 properties
        
        For some reason unclear to me, glade 3.40 would automatically
        remove the "pixbuf-column" and "text-column" properties for the
        "iconview" GtkIconView.
        Looking at the doc [1], this seems suspicious.
        (Actually removing the properties would event result in
        a crash when opening the dialog via "File" -> "Open Remote"
        in Writer.)
        
        Therefore, restore those 2 properties manually again after resaving
        with the newer glade version.
        
        [1] https://docs.gtk.org/gtk3/property.IconView.pixbuf-column.html
        
        Change-Id: Ifd8251384be93fb2ca372351ccb6b40bff682953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178970
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [429a6f64506b7256c3939bc2464d6d0edc393f47]

        tdf#130857 qt weld: Ignore "GtkCellRendererPixbuf" objects
        
        VclBuilder also doesn't seem to have any particular handling
        for that, just like for "GtkCellRendererText", so return
        early instead of asserting further down that this case isn't handled
        yet.
        
        Change-Id: Idf2a490fb944ac2596f64b96c6e3693fad894935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178969
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [3d96c29132f06ddcd6292654be233b8d17895e3e]

        tdf#130857 qt weld: Implement basic menu logic
        
        Implement basic logic related to menus:
        
        * Creating menus and simple menu items in QtBuilder.
        * Setting and retrieving misc properties for menu items
          in QtInstanceMenu.
        
        Use the QObject::objectName property [1] to hold
        the ID for menus and menu items.
        
        Introduce a PROPERTY_ACTION_NAME to hold the
        action name/command name for menu items. This property
        gets set for the corresponding QAction objects.
        
        [1] https://doc.qt.io/qt-6/qobject.html#objectName-prop
        
        Change-Id: Ic866377e42202bde6d1f8bd215829ff99a4b682a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178968
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [b8ca64234f2b35b0d984999f36414bb20cf192b7]

        tdf#130857 qt weld: Introduce QtInstanceMenu
        
        Introduce QtInstanceMenu as the native Qt implementation
        for weld::Menu.
        
        This mostly adds the basic structure.
        For all methods except QtInstanceMenu::clear,
        the actual logic still needs to be implemented.
        
        Change-Id: I983f2cd3976eee50f55b2ac702578833dbad3d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178964
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Michael Weghorn  <m.weghorn@posteo.de>  [a6f206c92dc91003c5cbefd03e41cace25c85dc9]

        tdf#130857 qt weld: Introduce QtInstanceMenuButton
        
        Add new QtInstanceMenuButton class as the native Qt
        weld::MenuButton implementation.
        
        The actual logic of the class methods still needs to
        be implemented, they all just trigger an assert when
        called right now.
        
        Create a QToolButton for "GtkMenuButton" objects in .ui files.
        
        Let QtInstanceBuilder::weld_menu_button create an instance
        of that new class and pass the button in the ctor.
        
        Change-Id: Ie5ba0bad8e351554323e8f4ec1281b2c5ae8fbc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178963
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0df75a03e2b67e65b42a582018c1ebe2e6e8491c]

        add more coverage to testRowForHeight
        
        and more comments.
        
        Because I want better coverage before I go changing
        ScTable::GetRowForHeight
        
        And because it makes obvious the flaws in this method.
        
        Change-Id: Ic7ec7bdcbab2547387efaaf2c1ad8b7cd05d1b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f44becfdb8bc0dad2d3ec7abd3aaa889d9e0bfea]

        pdf: add function to pad the vector as required by PDF specs
        
        Change-Id: I7196ad523b3084124a3b03fb2e4998d42fd91779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176883
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178757
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0c09e5fb6eca9d3128e69779a654c4c6f01d9c02]

        pdf: add /Perm encrypted access permission algorithm
        
        + add test
        
        Change-Id: Iba54dab6738c9707b37e434bab23ae286675436d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176882
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178756
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [41cd0fc6d9cbbf49acf4b13dcdcb0dd3332f9c52]

        pdf: generate U, UE and O, OE keys for R6 encryption
        
        Also test the algorithm against the known values from an example,
        to be sure we are calculating the values correctly. For this we
        need a couple of decryption algorithms, but those do mostly just
        the reverse of the encryption.
        
        Change-Id: I5499ed0b57671f44e48fe68961e07cde22be6b39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176881
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178755
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7e04eb9555fb069569eee6060cbfd68e0de7ca7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4f4fd964633268c3e52cb2b4cc32a11000ad148
          - Fix bad characters
            
            Change-Id: I3b8a1f8188d2b88fb8409df4a1e602102c4a3381
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178960
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1840947f172c63e1bd53781be50e6a260ee3a8fa]

        make modcfg ConfigItems listen to the config changes.
        
        Change-Id: I9ba49ff8df463519631e698ce5916f0126c5d7b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0242f8b8ff2d6b9886b410f1f45033a4d6d9ab2f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ecda866708ab53144cffd8ab3be134b949f3394
          - Fix grammar
            
            Change-Id: I0843f2bf289d7950feaf6fdccf3e0f5e62a368f0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178965
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [45add04444908dee3c9a9a2e512d7c2710e16c2f]

        crashreportScraper: output to html
        
        it's clearer and faster and easier to add links
        
        Change-Id: Id3f41daae257cf002c63b9203ec9f24857b8fcb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178959
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-20  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [8391bd0ea4fb3a7f4cad4149ec63c980eab5808d]

        tdf#163691 Use std::copy() instead of memmove()
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: I429aa29f97d3f7cc904cac5664b988548fe7f46c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178954
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-20  Rashesh  <rashesh.padia@collabora.com>  [0c900b165d4d24c33942e8b59f85243706b93890]

        sc: fix: can't switch focus from font menu back to edit window
        
        - Steps to reproduce:
        1. Open Calc
        2. Put the cursor in the font selection field, and type
        3. Try to move the cursor back to the sheet and to type
        
        Change-Id: I596e5380d38f761a310c2a363389b0b03a0e94ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178787
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2c95e7186e053ed5f2e7d8388fbe087fa60636c2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178796
        Tested-by: Jenkins

2024-12-20  Rashesh  <rashesh.padia@collabora.com>  [a8bffc1c6a9296294625e75e3ddfb42931d91586]

        sc: fix: unnecessary updates to ScPosWnd when named range are empty
        
        - follow up 115776004c875b3a8a861d070129187c893b136a
        
        Change-Id: I57072d1999e703975a43dc50077698d4b28df461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175869
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177646
        Tested-by: Jenkins

2024-12-20  Rashesh  <rashesh.padia@collabora.com>  [767fc7cfe567c33e80f12cf19140dba8c586b377]

        sc: fix: unnecessary updates to ScPosWnd even if NamedRanges are same
        
        Change-Id: Idd32343f38d6294f5140835d99137dae9f1237ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175061
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 115776004c875b3a8a861d070129187c893b136a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177647
        Tested-by: Jenkins

2024-12-20  Rashesh  <rashesh.padia@collabora.com>  [5e2bd2bb4c1a2f8a5467009b4ab7007401a14446]

        cool#10115 sc: enable ScPosWnd for lokit with jsdialog
        
        Change-Id: I18829c48a2495e3aa31af83970c8c1c4791a170a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173987
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 9ffc274bbc414d1e98313af804386861beeff9bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177645
        Tested-by: Jenkins

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4a584493db8b920637b664459e7519b6eef458a4]

        let insertModificationXcuFile accept "/" to indicate all nodes
        
        insertModificationXcuFile takes a set of paths to include and a set of
        paths to ignore from a given .xcu files
        
        adapt this to allow an include path of "/" to match all contents of the
        xcu.
        
        insertModificationXcuFile is more useful than insertExtensionXcuFile for
        the intended use case, because the latter inserts as an extension level
        layer, and cannot override higher layers.
        
        Change-Id: I8eabd9fb91184146a75b087cc31cee44f378d96d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178603
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d355682ba1799eb42069f4095e321db95fc2f540]

        make SwFmtAidsAutoComplConfig ConfigItem listen to the config changes.
        
        Change-Id: I92f57f9ea8a0ea109fbec9e18665adeb3c6d2837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b228790dfb771bbc24bd4c21bf26d217651bb8f]

        make SwWebColorConfig ConfigItem listen to the config changes.
        
        Change-Id: I5190155eb0edb4639b09983cc58101a5a8c82f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178929
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e9ed7bdd6c60ee5d3ee506a0b954d3ed6652625d]

        make SwLayoutViewConfig ConfigItem listen to the config changes.
        
        Change-Id: Id86edc48c304d2ab35a5cb01a20d9dac20e04280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178926
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f376ad74457fed10f0655f1028ad3bb6897dff4d]

        make SwCursorConfig ConfigItem listen to the config changes.
        
        Change-Id: Ia653759378913758f0b2750c9d072b76523fa034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178924
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46d0e19de898cb8712b5e8582966e58ba6e13ff1]

        use member init list and initialize before member Loads
        
        Change-Id: Iaca646e1a36b20adb29b5ff25649d08fc7055e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178951
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [5de080cae9bf09a2e360974e7b31567272c89798]

        tdf#164285 secure access to SID_ATTR_TRANSFORM_SIZE_POINT
        
        Change-Id: Ice52f9be8ecc1887de48f3538b5627514518aef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178936
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7db48ca86b9ab88d07430bccfdb50a22597ab5ce]

        fix --disable-poppler build with clang plugins enabled
        
        Change-Id: Ibc133de32a8c4343c5d941f78933cb8bae24f434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Vojtěch Doležal  <dolezvo1@cvut.cz>  [b0299c4141f80dfd9989f1f376a960a9590f7a07]

        tdf#164179 - Fix crash on BibEntry ComboBox select
        
        One change in 7b99871635cd48c2a8a1d0afbd7afc60a45cc2ff (to
        ToxAuthorityField) caused crashing bug in IdentifierHdl due to it
        trying to call unsupported method on an input field to set its
        value. This patch not only fixes the crash, but also moves the
        volatile code into the SetFields method, which is also called in
        the constructor of the Dialog, meaning if similar change were made
        in the future, the crash would manifest immediately and hopefully
        not pass to production.
        
        Change-Id: I93abef0cdaa5c533523fbefd9514d1a287fd368b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178448
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b82824edee44ddaacba91b5c230fc08a43e6080]

        stray semicolon
        
        Change-Id: Ibe57036e31c704b8866de49934a58b0fa6c47496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c0149f76729ba0f13997134b3663f44c532fe828]

        tdf#164396: Fix the minimum size for menu
        
        It is not the full size of our minimal system requirements - it's
        half of that: when the menu appears from the middle of the screen,
        it only has half of the height.
        
        Since the original commit 643a1492bd648fbd803ca86aca600cc2bdaf5819
        (Add some fallback minimum size when screen size detection goes wrong,
        2020-03-11) only mentioned misdetection of 0, this change should
        be safe.
        
        Change-Id: If62f4ee90dc062c37547fea4e72df2569d78f956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178940
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0600d72f81a1f28652905ca818c2ffaf22f7421f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 053504317ac7f4c205f540d6871c9389dd6b9240
          - tdf#163132 Adjust Impress Remote guide.
            
            as follow up of https://gerrit.libreoffice.org/c/help/+/171958
            
            Change-Id: I2f6cb97fab60d463f127663ab3f9a6ce36a8a12c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178919
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [2a15ce89ce132d198ab6895e64af2ed7179621ed]

        crashreportScraper: fix ids
        
        Change-Id: I55b3529cdda0219fabb4ea14c8fa2a90e88b5a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178914
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a47c0e3b74d7f4c60bba509644bd5b401ff1adb]

        add uno:AddToWordbook for adding word to user dictionary
        
        Change-Id: I1c679f62f554bfa112c505a545ceb8b5e31ef453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178921
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d52481325bc0dcc50af37d14cce68abfe9659564]

        The initialization of pResId is not used
        
        Change-Id: Ic8409352e347d01fe5cc15458d18f612084cccab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178913
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [33f0f08f675e3e933c919fc327e61687ce952490]

        sw: Remove executable bit from test .odt file
        
        Local fdroid build was warning about it:
        
            2024-12-20 14:07:59,973 WARNING: Found executable binary, possibly code at sw/qa/extras/uiwriter/data/tdf146356.odt
        
        Change-Id: Ib574580872d12cd737c3a1fcb221fd1ddc991b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178920
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Attila Szűcs  <attila.szucs@collabora.com>  [a2ed0b9bfae98c1ee06a325f52e93eda77fb37ce]

        SW: extract transform DocProperties
        
        Implemented Document Properties extraction, and transformation.
        
        For UserDefinedProperties Properties you can use add, and delete commands.
        If the property already exist, "add" will delete that,
        before adding the new UserDefinedProperty
        
        see the unittest for an example.
        
        Change-Id: I036b73bf1539bc25f454aea64c319241177e167a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178918
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [46533f9c308bb57545fd25527f3141daec0080d7]

        correct caching in osl_getLocalHostname*
        
        the change
        
            commit eac00017e34e77343b9ac3638bed9c75115a23fe
            Author: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
            Date:   Thu Dec 10 14:24:05 2020 +0100
            [API CHANGE] Do not call getaddrinfo if we just want the hostname
        
        means that the result returned from osl_getLocalHostname and
        osl_getLocalHostnameFQDN is always the same, but depends on which one is
        called first.
        
        Rather cache them independently, so they always return the right thing
        
        Change-Id: Ifa2f731a6002550cf08f57b53fd6e25e8b79295f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-20  Miklos Vajna  <vmiklos@collabora.com>  [496c409841d9ee71964af8a8afdc121282e69a63]

        cool#10782 sfx2 lok: fix bad view id on PDF export
        
        Have 2 views, view 2 dispatches .uno:ExportDirectToPDF, and sometimes
        view 1 gets the LOK_CALLBACK_EXPORT_FILE callback, which is incorrect.
        
        What happens is that the command gets dispatched correctly, but during
        save the progressbar gets updated in
        framework::StatusIndicatorFactory::end(), which calls
        Application::Reschedule(), which processes LOK jobs on the main loop,
        which may switch back to view 1, so the callback is emitted on that
        view.
        
        Fix the problem by reducing the duration where we work with the "current
        view". We know that initially the command dispatch has the correct
        current view since commit ee7ca8e4ea8ed93655f99e77a9e77032ac830c46
        (cool#7865 sfx2 lok: fix bad view id on async command dispatch,
        2023-12-20), so fetch the current view before the actual filter call and
        work with that view explicitly later.
        
        This is also similar to what SfxObjectShell::ExecFile_Impl() does for
        the bMailPrepareExport case, which also had trouble with GUIStoreModel()
        spinning the main loop.
        
        Change-Id: Id642056aa55831c54e88c61931753c03fa23b6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178915
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e574e99e889ea6697099028190e1aa4a08f01e95]

        Fix typo
        
        Change-Id: I1d2bf150ffc29c65b0ac35a8e261b65f56514b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178882
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [0480e84e4c0b43d3829d83746636ad7a7037e76e]

        sw: pass by reference
        
        Change-Id: I974472bc55104f0487a3406d4885ed0b52441896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178878
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [3160e03a4d1b2f5f3fe470a25a079c2c373bdae6]

        android: Update androidx.constraintlayout:constraintlayout to 2.2.0
        
        Change-Id: If589496270104a7e5cd103833573672a4f7eb326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178877
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [a6846dd5572c9e9e2476837d06e7df9b45acab0e]

        tdf#130857 qt weld: Support "Compress Image" dialog
        
        Declare support for the "Compress Image" dialog that
        can be triggered by selecting an image in Writer, right-clicking
        and selecting the "Compress" context menu entry.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the first supported dialog that has a slider ("GtkScale")
        in it, for which support was added in previous commit
        
            Change-Id: I0d04b4db0b4531daba1e1110879acf85aff53aa3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 19 21:19:31 2024 +0100
        
                tdf#130857 qt weld: Add QtInstanceScale
        
                QSlider [1] is the Qt equivalent for GtkScale [2],
                so use it.
        
                [1] https://doc.qt.io/qt-6/qslider.html
                [2] https://docs.gtk.org/gtk4/class.Scale.html
        
        Change-Id: I0cd7768f74d36272a9144efabb69864f167d3c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178875
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [255cbbed8bbac810889329676dc14e7a7b04f765]

        tdf#130857 qt weld: Apply GtkScale/slider properties from .ui file
        
        Change-Id: I6f7de7e27ee87a5b50e38f5c763288b0e010d8f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178874
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [9bce3ab468b7840a0aef682ff7c2ecfff6749822]

        tdf#130857 qt weld: Add QtInstanceScale
        
        QSlider [1] is the Qt equivalent for GtkScale [2],
        so use it.
        
        [1] https://doc.qt.io/qt-6/qslider.html
        [2] https://docs.gtk.org/gtk4/class.Scale.html
        
        Change-Id: I0d04b4db0b4531daba1e1110879acf85aff53aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178867
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [f4523f671038d8dd7bce30ae90f8ab2f0337de92]

        svx: Resave compressgraphicdialog.ui with glade 3.40
        
        To trigger the dialog, right-click on an image in Writer
        and select the "Compress" context menu entry.
        
        Change-Id: Ib0c11475c1cf50762f02f4f6cd0b1e14588a66c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178866
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [37c922d633a594b787b5f0ad6e33293bc5062b1c]

        Revert "coverity#1430065 silence Uncaught exception"
        
        This reverts commit 16d5cbfd38e57a6fccfda018ede2de7e4c448221.
        
        Reason for revert:
        The reverted commit was likely wrong, and was immediately obsoleted by
        commit 7df7545fc9ac4aa55403998b2d65e1b147a9f037 (coverity#1430074
        Uncaught exception, 2018-03-19), where the dtor of SwAutoFormatDlg got
        a try...catch block.
        
        The actual lines changed in the original commit were later modified in
        commit c91faacfb7dd26fe7b7c93c7af5d4c330779a59f (make auto-format
        dialog async, 2024-01-31), and this commit removes the use of
        o3tl::default_delete, appeared in those subsequent changes.
        
        Change-Id: Ibd634187d2930f3cc158aa0c36981ca8b327db91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178876
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-20  Balazs Varga  <balazs.varga.extern@allotropia.de>  [519282418137861144341da8b7a5759068104405]

        tdf#164091 - sw fix Accessibility sidebar gives warning about decorative
        
        marked shapes
        
        We should not have warning about missing alternative text in case of
        decorative marked shapes.
        
        Change-Id: Ibac7f152886d7db004039eede9b657fa5e84ae87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178795
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a4d40da62542a521b93af87a42dc4cc04aaf658]

        libwebp: upgrade to 1.5.0
        
        Downloaded from https://storage.googleapis.com/downloads.webmproject.org/releases/webp/libwebp-1.5.0.tar.gz
        
        Change-Id: I7e29a8bd81526e488417baddb093447d7582b542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178871
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-20  Miklos Vajna  <vmiklos@collabora.com>  [891d93dd4def0bde06aa90e348920d78f20869be]

        UITest_calc_tests3: fix indent in insertQrCodeGen
        
        Similar to commit 36047855334fb7bf988386eb7cdc140a31617c0c
        (UITest_writer_tests3: fix indent in insertQrCode, 2024-12-19).
        
        Change-Id: Ic20f60ee7adae45ddfaea301d0029cc2af34a3a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178869
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-20  Christopher Sherlock  <chris.sherlock79@gmail.com>  [67dbd34422941048bb726188857801579f64ea99]

        vcl: remove using namespace from components/fontindent.cxx
        
        Change-Id: I9c4340701a22405b7892cd64227f672495e19c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178161
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Christopher Sherlock  <chris.sherlock79@gmail.com>  [4b426f9fe58cb57d6c08e072d7406e6d6f5715ba]

        vcl: remove using namespace from components/factory.cxx
        
        Change-Id: I778a9b676cfba626b05ba5bf008d333ce5a4543f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178160
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Miklos Vajna  <vmiklos@collabora.com>  [70111311f39b52858f7de8b5adb764db9d28a46e]

        cool#10630 lok doc sign: fix Impress sign line when creating directly
        
        Once .uno:InsertSignatureLine gets dispatched, FuConstructRectangle gets
        activated, the signature line (a graphic shape) gets inserted, but then
        FuConstructRectangle is not deactivated in the "create directly" case,
        so next clicks keep inserting new signature lines, while the expectation
        is that "create directly" inserts one shape and selects it.
        
        The "create directly" mode is the default for LOK, but you can trigger
        it on the desktop with the KeyModifier=8192 (KEY_MOD1, i.e. Ctrl) UNO
        command parameter, too. The normal mode would send the mouse button
        down/up events to FuConstructRectangle and
        sd::FuConstructRectangle::MouseButtonUp() would select the shape after a
        drag to determine the position/size.
        
        The "create directly" mode will insert instantly, so
        sd::FuConstructRectangle::MouseButtonUp() is not called, so the shape is
        not selected, so the shape insert mode is not deactivated. Fix this by
        selecting the object for the create direct mode the same say as
        FuConstructRectangle would do, at the place where e.g. text editing is
        started for Impress textboxes.
        
        Do this for rectangle shapes for now, but later other shapes might want
        to do the same: e.g. curve insert doesn't have this problem, but it
        seems line insert has the same problem -- that's not changed here.
        
        Change-Id: I3ae85a07010f95b80a862e0cc631994113613eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178865
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [216d8a0a44c5053b4ea3799773fbc9db2dca16d6]

        android: Update Android Gradle Plugin to 8.7.3
        
        ... and gradle to 8.9, as suggested by Android Studio.
        
        Change-Id: Ic7c36e5d3f7117f877985cd4af82c79bcca9fb87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178838
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-20  Christopher Sherlock  <chris.sherlock79@gmail.com>  [9efbc448876d92d24697fa0eddd4580dcdbb9672]

        vcl: BlendFrameCache refactor
        
        - split off BlendFrameCache.hxx to own header
        - move functionality into constructor
        
        Much of the functionality in createAlphaBlendFrame() just updates the
        BlendFrameCache's bitmap frame. Really, this should be done when a
        BlendFrameCache is instantiated, so functionality has been moved out of
        createAlphaBlendFrame() and into the BlendFrameCache constructor.
        
        Change-Id: Ia53a6f1c058ccb5f0ee4314b7a6e0b02ad7db376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177802
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [bb7baf41229f2ef6bc7e43a5355a7a32e3ff9276]

        tdf#130857 vcl: Move extract* helpers to BuilderBase
        
        This will allow reusing them in QtBuilder in upcoming
        commits.
        
        Change-Id: I74d1cbf936d832443efccaaba4eb6625d32d1437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178851
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [78a27033548ad931932dbc91f2be5637337135d8]

        tdf#130857 qt weld: Create QSplitter for "GtkPaned"
        
        GtkPaned [1] allows having two panes, allowing the
        user to adjust the size using a handle.
        
        In Qt, there's QSplitter [2] which would even support
        having more than just two children and also handle it
        in QtBuilder::replaceWidget.
        This is e.g. used in the (not yet supported, but
        seen in an experimental WIP branch) "File" -> "Open Remote"
        dialog in Writer, where the GtkPaned has a GtkScrolledWindow
        child that has a GtkTreeView child, and QTreeView
        (created for the GtkTreeView) is a subclass of
        QAbstractScrollArea, i.e. doesn't need a QScrollArea
        parent in order to be scrollable.
        
        Create a QSplitter for "GtkPaned" objects in .ui
        files.
        
        [1] https://docs.gtk.org/gtk3/class.Paned.html
        [2] https://doc.qt.io/qt-6/qsplitter.html#replaceWidget
        
        Change-Id: I7abaa1a0ca8e00046d5c3b1f2d4e00077b0aa360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178850
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [67ee5fc2fdf2c1f7c16a45dfbc6e6e6618fb55ed]

        tdf#130857 qt weld: Implement {g,s}etting column width(s)
        
        Change-Id: I954259f1120cf3ea45eb92e5fd9e130c18ce1770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178849
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [feaf080065bb904473cebfe31c0caf5539172ad0]

        tdf#130857 qt weld: Add a QtInstanceToggleButton
        
        QAbstractButton, which is a base class for both,
        QPushButton and QToggleButton already provides the
        API needed for toggling.
        
        Use a QToggleButton, as the QPushButton doc [1] says:
        
        > As a general rule, use a push button when the application or dialog
        > window performs an action when the user clicks on it (such as Apply,
        > Cancel, Close and Help) and when the widget is supposed to have
        > a wide, rectangular shape with a text label. Small, typically square
        > buttons that change the state of the window rather than performing an
        > action (such as the buttons in the top-right corner of the QFileDialog)
        > are not command buttons, but tool buttons. Qt provides a special
        > class (QToolButton) for these buttons.
        >
        > If you need toggle behavior (see setCheckable()) or a button that
        > auto-repeats the activation signal when being pushed down like the
        > arrows in a scroll bar (see setAutoRepeat()), a command button is
        > probably not what you want. When in doubt, use a tool button.
        
        For the weld::Toggleable::{g,s}et_inconsistent overrides, it's a bit unclear
        to me what these should reasonably do for a button. Just let
        them trigger an assert for now.
        
        [1] https://doc.qt.io/qt-6/qpushbutton.html
        
        Change-Id: I51605ee02709bd78f77aeddf9c1993f930fcddd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178848
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [a441ba3f8eaff31c9d4ffdfbd0a251cdd838659c]

        tdf#130857 qt weld: Use pointer to QAbstractButton base
        
        QtInstanceButton doesn't make use of any
        QPushButton methods beyond what the QAbstractButton
        base class already provides.
        
        Switch QtInstanceButton::m_pButton from QPushButton
        to QAbstractButton, which will also allow subclassing
        QtInstanceButton (for a weld::ToggleButton or
        weld::MenuButton implementation) and reusing the
        existing logic with other QAbstractButton subclasses
        if that turns out to be useful.
        
        Change-Id: Ice45b0390f2f37dfb9a96f4e943ab036a294c376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [4a7247ac6c89f6e163c0086c46706f5226dc3d78]

        tdf#130857 qt weld: Implement QtInstanceButton::set_image
        
        Change-Id: I326ae219732a5cb389368dbc0566e9f27ce9a66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2f5e75ed134cfd0224e03411ca9d7d81f319c91b]

        Slightly improve diagnostic output
        
        Change-Id: Ice1debce98c77a0fa4400843abe62631dfd90a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178826
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [399f3414a902646e6563cc1679be2bf9f3ccaa51]

        sd: Dereference after null check
        
        Since
        commit 37edf62981acf8b73a70d645755e8cdbc9bbcd3f
        Author: Gökay Şatır <gokaysatir@collabora.com>
        Date:   Thu Oct 3 17:31:09 2024 +0300
        
            cool#7406: Refactor Impress->getPartInfo & use JsonWriter.
        
        Change-Id: Ie84b0a5a04c298348368a4781c0afbd97f748f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178845
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [98afe0ad746bef755f4af8d782e8a6c501ad9366]

        pdf: move common things to interface, prepare methods
        
        Move common flag, if the stream is encrypted from PDFEncryptor
        impl. to the IPDFEncryptor "interface".
        
        Change setupEncryption and encrypt methods to be closer to what
        will be needed in R6 implementation.
        
        Change-Id: I4dbd787c29e2a13ac900c6df360538b7e06af4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176880
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178754
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-19  Patrick Luby  <guibmacdev@gmail.com>  [fa3dd1c3a190fcbead9d39038a30f0fd306a1baa]

        tdf#164354 skip unnecessary transparency removal when printing
        
        On macOS, there are no known problems drawing semi-transparent
        shapes, fill, text, and bitmaps so only remove transparency when
        reduce transparency and no transparency print settings are both
        true.
        
        The fix not only eliminates the sometimes lengthy wait for the
        native print dialog to appear, but in cases like tdf#164354 the
        fix reduces the size of the PDF file generated by the macOS
        print subsystem by more than 90%.
        
        The fix was copied from the following NeoOffice source code files
        which are licensed under the Mozilla Public License, v. 2.0:
        
        - https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/source/gdi/print.cxx
        - https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/source/gdi/print2.cxx
        
        Change-Id: I54263a24201a0195fc86df6dc50580e2d6a61c70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178818
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [36276f606cd99561dd8449f41ba846866e75affa]

        vcl a11y: Drop idea about more roles for msg/alert/... dialogs
        
        I'm not aware of any platform a11y API that has different
        roles for alert dialogs vs. message dialogs, etc., so even
        if LO had different roles, they would be mapped to the same
        one in the a11y bridges again. Drop the idea.
        
        Change-Id: Ic0ccd3ffda806dff008442cc1107a7f64cdd1c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178832
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [ee3a207a033c42cb328b49845011bafb55ee37ee]

        vcl a11y: Drop custom special value for a11y role
        
        Use accessibility::AccessibleRole::UNKNOWN instead
        of a custom integer value of 0xFFFF to indicate
        that no role has explicitly been assigned.
        
        Change-Id: Ia9525a3235c32757eeb748127e75b684139b993f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178831
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [1b0915bb001c38a0e77f3dbaaf8405e54f6680d1]

        vcl a11y: Use AccessibleRole constant
        
        ... instead of hard-coded 0.
        
        Change-Id: Iea69998b8dd7df7d26758f38f3295557adbf9422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178830
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [d5df7f87b4b422502606ce8420097622ddbb7aa4]

        wina11y: Deduplicate 2 cases doing the same
        
        Change-Id: I1135434fa99d3accb230e379850bcb6651663260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178829
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [3077098976996fdd9573eed2ebffdd4356423567]

        tdf#157001 wina11y: Remove popup menu with its children
        
        In AccTopWindowListener::windowClosed, drop the special
        handling that was causing a popup menu (floating window)'s
        accessible to not be removed from the objects that
        the AccObjectWinManager manages.
        
        It's unclear to me why that special handling was there
        for accessibles with role
        css::accessibility::AccessibleRole::POPUP_MENU, but might
        have been some workaround for another issue fixed in the
        meanwhile.
        
        Removing the menu's children, but not the menu itself would
        result in the menu's children not to be reinserted (and thus
        no a11y listeners be registered) when the menu is shown again
        after being closed, so that no focus events for the children
        would be sent by the Windows a11y bridge.
        
        Remove the menu's accessible as well and rely on the default
        logic. This makes NVDA announce menu entries in Calc's
        Organize Template menu also once the menu has been closed
        and is then opened again.
        
        Change-Id: Ie9cf96cad95215b9aeb0ebd7e4970da3c35b92c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178825
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-19  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [e87b50fb4936c221bdfb0fe6e8efd15251f6f38f]

        tdf#163620 Allow users to modify "Appearance" for Automatic scheme
        
        Disabling "Appearance" options for Automatic scheme is pointless
        and it's bad UX as the users don't have any clue about what's
        going on.
        
        "Normal  user should  have our  old feature  - to  select
        dark/light/system theme in only one action. Customizing theme is
        absolutely another thing" -- Kompilainenn (LO Design Team)
        
        Change-Id: I181420daefd29e0f7a7d638d9c7a26034c40c566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178828
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d524283769179842e3869e1650facd99a17b0c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bbf0db1682b2cd6b749e0fbd9a72606277cafe5
          - Mute L10N when <embedvar> is a singleton in text
            
            + some refactor
            
            Change-Id: I071758f139a7f6e9ab91ca277a420c8283b1eae0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178833
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-19  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [f3f70ef02f04d876abb768bb3ec65645ddb8d89d]

        tdf#164270 CairoSDPR: Correct Control rendering
        
        Controls need not to be rendered when they are
        visible as Windows (they then render themselves).
        Also added some needed cleanups for better display
        of control primitive decomposition as Bitmap.
        
        Change-Id: I976cd791f9f080a7ab567232303d5d4f0b6dff05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178725
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-12-19  Jonathan Clark  <jonathan@libreoffice.org>  [de29bec27e90a7d24a90c6f071e7899abefe683e]

        tdf#163660 sw: Treat strong CJK inside RTL runs as Asian script
        
        Previously, Asian-script characters following an explicit direction mark
        or inside an RTL embedding would be rendered using the Complex font,
        rather than the Asian font. This change updates script detection to
        treat these characters as Asian regardless of text direction.
        
        This change also consolidates more duplicated script detection code from
        Writer and Edit Engine.
        
        Change-Id: I3931c3ec0cb447f3c504fdbfb3ee62185fd14422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178817
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-19  Miklos Vajna  <vmiklos@collabora.com>  [36047855334fb7bf988386eb7cdc140a31617c0c]

        UITest_writer_tests3: fix indent in insertQrCode
        
        The indent is 4 spaces, and it hurts readability to violate that, given
        that this is Python, so no curly braces.
        
        Change-Id: I45aa85c23ab3468acbc6a6d7a37f7db19cc94836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178814
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1338df7dcfaec258e5a015abb5d1e7ed561a2792]

        Avoid global variables with non-constexpr ctors
        
        ...that had been introduced in ddeeca35d9630f2d3d3afb83a2ec8f21458f6e19
        "tdf#163620 [API CHANGE] Add UI for libreoffice themes", but caused builds that
        statically link in Library_cui (like LOWA) to fail on start up with an uncaught
        css::uno::DeploymentException from
        
        > soffice.wasm.comphelper::getProcessServiceFactory()
        > soffice.wasm.comphelper::getProcessComponentContext()
        > soffice.wasm.utl::ConfigManager::acquireTree(utl::ConfigItem const&)
        > soffice.wasm.utl::ConfigManager::addConfigItem(utl::ConfigItem&)
        > soffice.wasm.utl::ConfigItem::ConfigItem(rtl::OUString, ConfigItemMode)
        > soffice.wasm.SvtSysLocaleOptions_Impl::SvtSysLocaleOptions_Impl()
        > soffice.wasm.SvtSysLocaleOptions::SvtSysLocaleOptions())
        > soffice.wasm.SvtSysLocale_Impl::SvtSysLocale_Impl()
        > soffice.wasm.SvtSysLocale::SvtSysLocale()
        > soffice.wasm.CuiResId(TranslateId)
        > soffice.wasm._GLOBAL__sub_I_appearance.cxx
        > soffice.wasm.__wasm_call_ctors
        
        (because comphelper::getProcessServiceFactory was now called before
        comphelper::setProcessServiceFactory)
        
        Change-Id: I4e2d8aa048c5c0b8c5c15edf6ae358bafceb08a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178815
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0953be74953cdee281e6ad77909fa063ba7cd532]

        crash see on SdXImpressDocument::getPartInfo for missing page
        
        possibly after uno.HideSlide
        
         #0  0x00007e697b8c0b97 in SdPage::GetPageInfo (this=this@entry=0x0, jsonWriter=...)
             at sd/source/core/sdpage.cxx:1751
         #1  0x00007e697bbda0ab in SdXImpressDocument::getPartInfo (this=<optimized out>, nPart=<optimized out>)
             at sd/source/ui/unoidl/unomodel.cxx:3692
         #2  0x00007e698ae7e078 in doc_getPartInfo (pThis=0x121017c0, nPart=9)
             at desktop/source/lib/init.cxx:4176
         #3  0x000000000059bcf4 in LOKitHelper::getPartData (part=9, loKitDocument=0x121017c0) at kit/KitHelper.hpp:47
         #4  LOKitHelper::fetchPartsData (loKitDocument=0x121017c0, resultInfo=std::unordered_map with 6 elements = {...}, partsCount=84, mode=@0x7ffec727bd58: 1)
             at kit/KitHelper.hpp:91
         #5  0x000000000059c6a3 in LOKitHelper::documentStatus (loKitDocument=0x121017c0) at kit/KitHelper.hpp:164
         #6  0x000000000057fb7a in ChildSession::selectClientPart (this=0x556fe60, tokens=...) at kit/ChildSession.cpp:2964
         #7  0x000000000058a88f in ChildSession::_handleInput (this=<optimized out>, buffer=<optimized out>, length=<optimized out>) at kit/ChildSession.cpp:495
         #8  0x000000000061c63f in Session::handleMessage (this=0x556fe60, data=std::vector of length 29, capacity 29 = {...})
        
        Change-Id: Ib4e532b31cdc6a69f9e54317699f426c12de35d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177781
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 03156b7ccb5129202978c2e636c641a2208a61aa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178788
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-19  Justin Luth  <justin.luth@collabora.com>  [662b5eaf86b5fc15d67ef4f0cf43fd31630ac77e]

        tdf#164263: avoid exception when SAL_DISABLE_PRINTERLIST #2
        
        This fixes a backported to 24.2.1 regression
        from commit e6f75eb50bc5d1ebccda0c0f80a7b353d991106e
        
        Although an empty OUString is returned when IsDisplayPrinter(),
        using that to setPropertyValue causes an exception.
        Since IsDisplayPrinter always returns static values for all queries,
        there is no need to actually attempt to make any changes
        when IsDisplayPrinter().
        
        This replaces my earlier, very focused patch for writerfilter.
        I'm afraid that this Exception could evidence itself
        in many different areas, so this more generic fix
        ought to resolve any problems triggered by SAL_DISABLE_PRINTERLIST.
        
        I don't see any unit test examples from the offending regression,
        or anything else in SW relating to Printer or environment variables,
        nor is there any explict call available to set mpDisplayDev,
        so I don't know how I can create a unit test for this.
        
        Change-Id: I3d4054df57ab460833d9994d71133aef64cbb714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178753
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-19  Miklos Vajna  <vmiklos@collabora.com>  [65043a50adf8d56e1f965ec48b9609ca836ccced]

        Related: tdf#164359 editeng RTF export: track unused follow styles recursively
        
        Similar to commit a7a81b6fbe37af938ce461e790fac517be032317 (tdf#164359
        editeng RTF export: track unused parent styles recursively, 2024-12-18),
        the follows of a style has to be tracked recursively as well, to avoid a
        crash.
        
        The Impress UI doesn't seem to have a way to specify the parent/next
        name of a style, but you can definitely create such a follow chain from
        test code and probably this is also possible via macros.
        
        Fix this similar to the parent case, except here handle when a style
        sets itself as a follow: that's what the default Outline N styles do in
        Impress.
        
        Change-Id: If3847add02061fdb9ba1e3fbf7c1fc42e3866209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178786
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f41776730a8a5c92c7b350451a594597368015b3]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9887b0a0a5ebc6f79d5035c7c0808086f039096a
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ief574fb9affafb5ac48b6e9b4db64122b7386d7a
            
2024-12-19  Bayram Çiçek  <bayram.cicek@collabora.com>  [fd9cfe9ebe89dd64d6893e517375a56be50056e4]

        sc: autofill: no need to send deleted cell addresses
        
        - with LOK_CALLBACK_TOOLTIP. we already send them with
          SendReferenceMarks (https://gerrit.libreoffice.org/c/core/+/176557)
        - also avoid warning "unknown tooltip type - CanvasTileLayer.js" on the
          console
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Id6e6d2c20c7b874d8d57324ed4dd3984a56ac398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176565
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 02046576573e1547c7cd00cd17faffc87d1ede72)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178790
        Tested-by: Jenkins

2024-12-19  Bayram Çiçek  <bayram.cicek@collabora.com>  [bf22a14283e3f9eda5e7062983f4e6055c404d59]

        sc: send cell addresses of delete-by-autofill
        
        with LOK_CALLBACK_REFERENCE_MARKS
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Ic991f1dd41b99cf6caca7dc408caaf6d4dfeac3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176557
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit c82ceac1cc544fe77f1ce8aaccc8baa0de938821)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178789
        Tested-by: Jenkins

2024-12-19  Noel Grandin  <noelgrandin@gmail.com>  [69c03b1fd4a5b6d782109f8fcaf66ba5939f2f2b]

        Index Link is a programmatic name
        
        Change-Id: Id909800fdd5db5dd2eadec92774c1dda4a435c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178735
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8546b081d668a90799a4c7357e7534adaa7730ce]

        tdf#155211 - Change line style from solid to dashed
        
        Change line style from solid to dashed during GDI meta file import,
        if there exist dashed line properties.
        
        Change-Id: Ia5b88bd8513929969aed67b17494541da83b29d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178708
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12af04516999c2e13156b25e7fe2a1d22f347575]

        Fix typo
        
        Change-Id: I93758f1bb09b9a7ce65e3692d968149fc58ae6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178746
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [83b8206c69d9b89c269b90eb7c0dcd95e75daa6d]

        Fix typo
        
        Change-Id: I97349f5ede05de8b2dd605e1bf88c6429d1ae999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178743
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3f857ad375811c0714d43500d98d5c34e913bbd5]

        Remove the remains of the set_office_start_language mechanism
        
        ...whose uses have been dropped in 38fb0462578bde685e3862187a2dc842968d8f72
        "fdo#54278 Only en-US help pack should contain en-US help"
        
        Change-Id: Ia2bee3fae2bf7fe5c0563fe075819b82162cc07a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178782
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [12b64d959573186ef2169e92702602a952a2c772]

        fix comment in assert
        
        Change-Id: I7a9909bf1e6721726befb3756d4c897d9dcec2c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178783
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [29f0304fc77206ac03132d2c6a8015b83de11f6a]

        Fix typos
        
        Change-Id: I6b0c8e56632b56c570cac660b878687bb02d25e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178742
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [538cb629d0fc01ca9efb82d9ae86af4f32dc5081]

        Fix typos
        
        Change-Id: Ifd7be9bdd784f042b27dbdd28d3e4229a41344d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178747
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [111edc82743369fd1557784566a46c8e03dc4bbd]

        tdf#130857 qt weld: Map ID to to parent QWidget for layouts
        
        QBoxLayout (created for "GtkBox" in .ui files) and QGridLayout
        (created for "GtkGrid" in .ui files) are QLayout subclasses,
        not QWidgets.
        
        So far, QtBuilder::m_aChildren was containing QObjects
        that could be either QWidgets or QLayouts.
        
        QtInstanceBuilder::weld_container and QtInstanceBuilder::weld_grid
        were retrieving the corresponding QLayout using QtBuilder::get,
        all other QtInstanceBuilder::weld_* methods the corresponding
        QWidget.
        
        However, for a "GtkBox" or "GtkGrid", it's not only possible
        to call QtInstanceBuilder::weld_container or
        QtInstanceBuilder::weld_grid, but it's also possible
        to just get a pointer to the weld::Widget subclass by calling
        QtInstanceBuilder::weld_widget with the ID of the grid/box.
        
        So far, this would have resulted in QtInstanceBuilder::weld_widget
        calling QtBuilder::get<QWidget>, in which case the latter
        would incorrectly `static_cast` the QLayout to a QWidget.
        
        Since
        
            commit bf42162fc50d0c6f8e567d8765f8b14b96d7cc50
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Nov 4 19:06:15 2024 +0100
        
                tdf#130857 qt weld: Add extra QWidget parents for layouts
        
        , extra parent widgets for the layouts (except for the top-level
        ones in dialogs) are created. Insert these into QtBuilder::m_aChildren
        instead and retrieve them by the ID, which allows to uniformly use
        QWidget. Adjust QtInstanceBuilder::weld_{container,grid} accordingly.
        (Special handling for top-level layouts in containers can
        still be added as needed later.)
        
        This fixes an assert seen in a WIP branch where suport
        for the FontFeaturesDialog (open context menu for paragraph in Writer,
        select "Character" -> "Character" to open the "Character" dialog,
        in the "Font" tab, click on the "Features" button) is declared.
        
        Backtrace, where FontFeaturesDialog::m_xContainer is a weld::Widget
        referring to the "fontentry" GtkGrid in
        cui/uiconfig/ui/fontfragment.ui:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7ffff789dc8c
            2 __pthread_kill_internal pthread_kill.c 78 0x7ffff789dcef
            3 __GI_raise raise.c 26 0x7ffff7849c42
            4 __GI_abort abort.c 79 0x7ffff78324f0
            5 __assert_fail_base assert.c 94 0x7ffff7832418
            6 __assert_fail assert.c 103 0x7ffff7842552
            7 QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0::operator()() const QtInstanceGrid.cxx 25 0x7fffe438b5e1
            8 std::__invoke_impl<void, QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0&>(std::__invoke_other, QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0&) invoke.h 61 0x7fffe438b4f5
            9 std::__invoke_r<void, QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0&>(QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0&) invoke.h 111 0x7fffe438b4b5
            10 std::_Function_handler<void(), QtInstanceGrid::set_child_left_attach(weld::Widget&, int)::$_0>::_M_invoke std_function.h 290 0x7fffe438b39d
            11 std::function<void()>::operator() std_function.h 591 0x7fffe4345aee
            12 QtInstance::RunInMainThread QtInstance.cxx 226 0x7fffe433d67a
            13 QtInstanceGrid::set_child_left_attach QtInstanceGrid.cxx 23 0x7fffe438aa63
            14 cui::FontFeaturesDialog::fillGrid FontFeaturesDialog.cxx 142 0x7fff6db25fb1
            15 cui::FontFeaturesDialog::initialize FontFeaturesDialog.cxx 73 0x7fff6db2541d
            16 cui::FontFeaturesDialog::FontFeaturesDialog FontFeaturesDialog.cxx 35 0x7fff6db24f61
            17 SvxCharNamePage::FontFeatureButtonClicked chardlg.cxx 1154 0x7fff6de651d1
            18 SvxCharNamePage::LinkStubFontFeatureButtonClicked chardlg.cxx 1131 0x7fff6de5fa7d
            19 Link<weld::Button&, void>::Call link.hxx 111 0x7fffeec54551
            20 weld::Button::signal_clicked weld.hxx 1558 0x7fffeec3078c
            21 SalInstanceButton::ClickHdl salvtables.cxx 2955 0x7fffeec018ee
            22 SalInstanceButton::LinkStubClickHdl salvtables.cxx 2943 0x7fffeec00e2d
            23 Link<Button *, void>::Call link.hxx 111 0x7fffee508da1
            24 Button::Click()::$_0::operator()() const button.cxx 130 0x7fffee5005f2
            ...
        
        Change-Id: I7901b9085f887acef7b5505eef0baa792816cd0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178752
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [fb3f9d72d102dcfde93d32660ebb59a4bb75a5b3]

        tdf#130857 qt weld: Introduce QtInstanceGrid
        
        ... as the weld::Grid implementation using
        native Qt widgets.
        
        This adds an implementation of the API
        newly added in
        
            commit 7056ea9c29c7e454c21b525e61cdc1e0c03f7301
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        Change-Id: I3db89aa9fe2986dfa7fc617440f530334d029bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178733
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-19  Jonathan Clark  <jonathan@libreoffice.org>  [0e553976c29a84bdb5d2d8ee720e1901d9da77ac]

        Added build option for Skia/Vulkan validation layers
        
        This change adds the --enable-skia-vulkan-validation build option. When
        this option is set, Skia will be built with Vulkan validation layers
        enabled. Vulkan validation layers must also be installed on the
        development machine (e.g. via the Windows Vulkan SDK, or the Ubuntu
        vulkan-validationlayers package).
        
        Vulkan validation layers are an important debugging tool for Vulkan
        application development. Validation layers externally verify that Vulkan
        API calls are correct and comply with the standard. This is particularly
        important as Vulkan does not require drivers to reject invalid uses;
        some hardware or drivers may tolerate certain developer mistakes, while
        other drivers reject them. Without using validation layers to confirm,
        this may create a false impression that certain hardware/drivers are
        faulty, when it is our own code at fault.
        
        Change-Id: If39a09e3d1043d37b465dd3cc5fcd8e5c364a1a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [99363538616d41de1c5647adddc49d603c4dec61]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ia2d43ef6d04cf16941c46b329917b3be96bae4b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177138
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8ce5c7623d0d20e812824194a108ab259ee8f530]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Icbb9de0bc296e914782f73bc109c2c3430952277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177135
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [da95528f8c76e13fc6994d70fc8c331f1e84d121]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I9834c891e4b15c650c5a2600435283516ca7b2c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177148
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3502fdf8e678ed20a996f05f9a175ef5856b84f4]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: If16e686ce726f6f05d84224ef30fc95813600791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177146
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d51e1ac5c1045347f6265fdd34e9e553d9ac057b]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ibdda74f8a779097ab189f77a62adff7a12330bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177145
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [65b055a5e86d5c01334389f62b1f80260fb4d425]

        Fix typo
        
        Change-Id: I5b27cfe2589b47446a385736245dfbfa62c77ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178744
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3641b18f4b95d4c79ae4fb6c1c37dc0e50e9e7fd]

        Fix typo
        
        Change-Id: I61350f8132e300c015a88d58b14fe78c7999b0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178745
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-12-19  Patrick Luby  <guibmacdev@gmail.com>  [2120acaa261aaa1adaafc051582ac7f7dd4de372]

        tdf#161623 Fine tune menubar visibility when in LibreOffice full screen mode
        
        Every once in a while, toggling LibreOffice full screen mode in a
        native full screen window causes the menubar to be set to "hide"
        instead of "autohide". So, expand the conditions for enabling
        instead of disabling the menubar's visibility to include from
        when a window is about to enter native full screen mode.
        
        Also, just to be safe, always disable the menu items in the menubar
        for LibreOffice full screen mode windows in case the menubar can't
        be hidden while not in native full screen mode.
        
        Change-Id: I4f1e8fc4a644cc13451690156b56662035321459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178751
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [85212289dc3bcee17d2fac1d205b33f61bcdae74]

        tdf#113015 Improve update description
        
        Change-Id: If5ba0ee65483ebe27e71522b25c34daf04751991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178534
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-12-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [02363a5cf5ef95b9958a05c4b3af2fba18549226]

        related tdf#143980: python3: add ensurepip
        
        Change-Id: Ia38a81cbcd14776b7fa1398856bd3f8997a869ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178741
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [860e4b044a40d69bddd39efc97d281a43f1f6e48]

        related tdf#162798: add script to create the list of external packages
        
        Change-Id: Ifc24cb42df76c50f0ca40e3c793f36c355e483d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178730
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [755d09864b2c7ca157017ffdfe0f9ec60bed41a4]

        More --disable-zxing fixing
        
        ...in the same vein as ff20399edf0e8ab4c15e802e5b1aa400db42d33c "Some
        --disable-zxing fixes", this time for UITest_calc_tests3
        
        Change-Id: I836f366ebe0f60a8b2c316ebfcc6782e28046ba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178732
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88f0e9a245f4a52ea45a25274a075b48fae7ef9c]

        crashtesting: unknown 'IsContentEmpty' property reloading rtf export
        
        of forum-mso-en4-218597.doc
        
        where the XText is a TextFrame, presumably a problem since:
        
        commit cfd3b14fd4e1ee889dd356523e5cdaa639786d37
        CommitDate: Fri Aug 2 10:37:31 2024 +0200
        
            tdf#162295 DOCX import: optimize the check if the header/footer is empty
        
        Change-Id: I14e851aea66ad66024e9a8e38b1d1cdef0bf570c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178717
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-18  Michael Weghorn  <m.weghorn@posteo.de>  [ffbe93aa93c0300dd4ff5f4d55dfb33e4c7a394d]

        tdf#164353 tdf#130857 qt weld: Keep extra msg dialog widget in place
        
        Both, QMessageBox::setText, and
        QMessageBox::setInformativeText call
        QMessageBoxPrivate::setupLayout [1], and that one
        deletes the QMessageBox's previous layout, creates
        a new QGridLayout and sets that as the dialog's new
        layout.
        
        As a consequence, adding the widget that can hold
        extra controls to the dialog's layout only once
        by calling QtInstanceMessageDialog::addWidgetForExtraItems
        from the QtInstanceMessageDialog ctor isn't sufficient,
        but needs to be repeated each time the dialog layout
        may have changed.
        (Otherwise the widget is not contained in the layout,
        and "randomly" placed in the dialog, so it can e.g.
        overlap other UI elements in the dialog, see tdf#164353).
        
        Therefore, rework QtInstanceMessageDialog::addWidgetForExtraItems
        a bit,  rename it to QtInstanceMessageDialog::positionExtraControlsContainer
        and call it also after updating texts.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/dialogs/qmessagebox.cpp#n290
        
        Change-Id: Ib17b5867393a0694701c56b0ab74165021a8bc51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178726
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [c6f3ffe93afc0591e4121be9edc6655ef0bc2653]

        Simplify VCL dialog implementations, and drop some macros
        
        Change-Id: I6eec9c4ebfc795ca82ea014ab317b6c10bf931d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178722
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [aee655940b5a19d5f54750a8c40eded10672622f]

        tdf#163395 tdf#153057 - sc fix standard filter problem with formatted
        
        values
        
        ScQueryEntry::ByValue was removed unnecessarily in the original
        patch, but it is necessary for filtering number values correctly.
        
        Regression from commit: 1f755525189884e4b2824889a6b9dea8933402db
        
        Change-Id: Ib013d971ad0b0809fc55949a6a2d9bf02418b516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178690
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9ebcb0271b4f1a4a1381e32c3c133e099a451806]

        tdf#157476 tdf#150861 - sc fix autoFilter is filtering incorrectly
        
        caused by rounding problem with duplicated values.
        
        We need to store the rounded values, based on the numberformat
        precision, otherwise later can cause problems at removing the duplicated
        values.
        
        Regression from: f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
        
        Change-Id: I19f5248122ffca1e52adb96714df79dd9c64b23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178683
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8b7900dc3dfc6e3284442dc106799c44dc8961de]

        tdf#135320 sd fix soft edges are not shown on text frames
        
        Allow soft edge and glow effect on text frames objects.
        
        Change-Id: If08da1cfeae515aa50ded5689b7fe3a963a98cd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178656
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-18  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [ddeeca35d9630f2d3d3afb83a2ec8f21458f6e19]

        tdf#163620 [API CHANGE] Add UI for libreoffice themes
        
        Instead of Color, we have Light and  Dark in the registry. So each theme extension
        will specify  dark and  light color  values for  each "customizable  element" like
        DocColor etc. Under appearance we have three radio buttons - light/dark/system. If
        system  is selected  then light/dark  colors are  switched based  on the  system's
        theme.  if  explicitly light/dark  is  selected  - that  color  is  used from  the
        registry.
        
        ColorConfigValue now has three entries  nColor, nLightColor, nDarkColor. nColor is
        used as a cache for the color being used at the moment. This is to avoid otherwise
        expensive  function calls  + hundreds  of modifications  in the  codebase just  to
        change nColor. nColor  is cached either when  the theme is loaded  or when changes
        are committed in `ColorConfig_Impl::ImplCommit()`.
        
        Now, if  Automatic theme is selected  then themes is disabled  and the application
        uses the system  colors. If some other scheme is  selected like "CustomTheme" etc,
        then LibreOffice themes/UI color customization is enabled and the theme colors are
        used.
        
        Instead of a scroll window, now we have  a combobox for the registry entries and a
        single  color dropdown  to select  the  color value.  This color  dropdown is  for
        convinience in case the user wants  to change some specific color that's bothering
        him. For themeing, theme extensions should be used.
        
        API CHANGE
        + remove Color in favour of Light and Dark
        + AppBackground has additional two - BackgroundType and Bitmap
        + remove officecfg::Office::Common::Misc::Appearnce in favor of
          officecfg::Office::Common::Appearance::ApplicationAppearance
        + move LibreofficeTheme under officecfg::Office::Common::Appearance
        
        UI
        + it looks like https://i.imgur.com/UMxjfuC.png which is a little
          different from how the [mockup] on the ticket describes it, and that's
          because of lack of time due to upcomming feature freeze.
        
        + system/light/dark allow the user to switch between light/dark modes
          based on either the system theme (system) or by manually specifying
          light/dark.
        
        + ui themeing and color customization is disabled when automatic theme
          is selected, and enabled otherwise.
        
        [mockup]: https://bug-attachments.documentfoundation.org/attachment.cgi?id=197469
        
        Change-Id: I1a7f70dfe44b81f863814f87e8d46e146c0e3d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174835
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-12-18  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [c4962247e40b5e6750c522d43359d9436dcfec68]

        tdf#163620 [API CHANGE] remove persona/appearance-toggle related code
        
        - remove ui and source files related to app colors and personalization tabs
        - remove persona entries from registry
        - remove functions related to persona settings from StyleSettings, vcl..
        - remove ui and code related to tools - options - view - appearance combo box
        
        Change-Id: I98f0c38dc1facddd0e8dd03197c61a92287fdbc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176836
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e4b7be35cf38acdd67ecaeb63c1c5f152afd4f5]

        use more concrete UNO in sw
        
        Change-Id: Ie83d957349f123bca0fd46ce3144ce778c3ec101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178704
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-18  Michael Weghorn  <m.weghorn@posteo.de>  [6b63318f73de07b9a9697284d018e1271cb3307c]

        scp: Drop reference to no longer existing acc files
        
        These are no more since
        
            commit 9283da858506fe3b4383e4cfe0506e470a4356f6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        , so drop the reference.
        
        Fixes the build failure seen in the macOS daily build [1].
        
        Thanks to Christian Lohmaier for pointing it out.
        
        [1] https://ci.libreoffice.org/job/lo_daily_tb_mac/1946/console
        
        Change-Id: Ib4a5c4cb2774f596332715fe6dd2faea678e9ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178721
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-18  Arnaud VERSINI  <arnaud.versini@pm.me>  [5d8336d70e5f2bfcaa37b0b176397aa72f3af393]

        vcl mtfxmldump : allocates less OUString
        
        Change-Id: Ibd78e40817f6a0ec071c9f45bb41c38e476dd02d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176408
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [d38e0d615c73b55d3cf2a299cfb9290f0005000b]

        Send attachments to xdg-email also as --attach arguments
        
        Intended to handle the potential end of support of "attach" in mailto URLs,
        as discussed in https://gitlab.freedesktop.org/xdg/xdg-utils/-/issues/177.
        
        Change-Id: If1e9a7161e9805f634fcab5fb83e6f172af54d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178701
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-18  Weblate  <noreply@documentfoundation.org>  [280edea49643e20a0e16e24b1cb602b82e252600]

        android-viewer translated using Weblate
        
        Afrikaans currently translated at 70.6% (82 of 116 strings)
        
        Change-Id: I71381e8730922f481c5d7cf1d0b5aa879e8dd8f3
        
        android-viewer translated using Weblate
        
        Afrikaans currently translated at 56.8% (66 of 116 strings)
        
        Change-Id: Id75cae5888d66e89e6fb673deda1d4160892b8bb
        
        Added translation for android-viewer using Weblate (Afrikaans)
        
        Change-Id: Ia75e38962a94682d1b9e927da51ec018d54d7158
        
        android-viewer translated using Weblate
        
        Tagalog currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I9d1b4fced291230fb73082bb8a00ed911e918ca6
        Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com>
        Co-authored-by: Paul Roos <iNetRoos@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/af/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tl/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178391
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-18  Heiko Tietze  <tietze.heiko@gmail.com>  [872945ecec6cabac691b036676d3dfe81f240948]

        Resolves tdf#140298 - SQL dialog must not become oversized
        
        SQL history becomes quickly too large for the dropdown control
        The patch sets a fixed width so this control wont take over the
        dialog size.
        
        Change-Id: I106ae19dfd505388e5b528becbc06e9d6110d45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178702
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-12-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ea604324bb2a26ac96b5c190121579b602ebffd2]

        add a way to update config from kit
        
        arg is a path to a "presets" dir similar to instdir/presets/
        
        where autotext/wordbook/xcu may exist
        
        initially just update xcu if that is present, autotext itself
        typically is updated dynamically if a new file is found, while
        wordbooks are not and the diclist can be explicitly reinitialized
        here if there are wordbooks.
        
        Change-Id: Ibeb9d23d143c710f12e6c9d75b2861e0e6d44a01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177372
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 30f83f2dff9f80db0b4a467fb30f9a9b2531fa3c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178664
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-18  Miklos Vajna  <vmiklos@collabora.com>  [02ab907ef7f8ad8d4b0d31baead9d1749669e812]

        CppunitTest_sw_tiledrendering2: make this more stable, try 3
        
        I got the workaround condition wrong in commit
        d248d8f5271c380e51af9482b6724d471e2cb929
        (CppunitTest_sw_tiledrendering2: try to make this more stable,
        2024-11-20), the intent was to return early when we get no state
        changes, but we did the early return when there *were* state changes,
        fix this.
        
        Change-Id: I90abcec062c59360642da87069911f937cc2110a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178706
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23cf7f503e2730e56565476cef1f36ed2080c660]

        cid#1606564 silence Overflowed constant
        
        Change-Id: I6a4e36e9905278673577b543b27c50bc7988cc18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178707
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [981669cbc4ffa1dc6aa216ba99ace1b67c3e1dfb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c4a6bbc4f688feeabeb307c0dea1ef0c8f2baab
          - tdf#124954 Improve Help about cache spreedsheet formula
            
            Change-Id: If9fdd7fa699afd9735b98fb42def1c1700556591
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178535
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [05b508f9f1397249079842dca86c36cbca01b43d]

        Fix typo
        
        Change-Id: I75ce750a6073d4baed29c8cb737e1ad406bba6a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178713
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-18  Miklos Vajna  <vmiklos@collabora.com>  [a7a81b6fbe37af938ce461e790fac517be032317]

        tdf#164359 editeng RTF export: track unused parent styles recursively
        
        Start edit mode for the shape in the document, double-click on a word
        which has a "level 2" bullet associated with it -> crash.
        
        This is a regression from c8b607b7c0096c58dc5187262bf0133dee728d50
        (tdf#163883 editeng RTF export: fix broken offsets into the para style
        table, 2024-11-19), the direct cause is that ImpEditEngine::WriteRTF()
        maps all style pointers to a style ID and once we write the parent
        property in the style table, we unconditionally dereference our search
        result, because we know all styles should be in that map.
        
        The root of the problem seems to be that once parent styles are marked
        as used for the "only write used styles for the clipboard" case, those
        parents themselves can have parents, and we didn't mark those as used.
        Combined with the unconditional dereference, this leads to a crash. Fix
        this by walking up the parent chain till we get no parent.
        
        This assumes that importers create a valid document model, so there
        can't be loops while walking the parent chain. If that would be a
        problem in practice, we could check for that in the future.
        
        Change-Id: I4b416e78f26bf455040d95ee8ed220cfe870e33a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178703
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-18  Manish  <mbera.dev05@gmail.com>  [e016a9d8ac99209fe17034a3231e24dfb238b699]

        tdf#114441 change the sal_uLong to sal_uInt8 in msdffimp
        
        Change-Id: I22dacda7966d0f680006f0e589bd6d95b5a6f4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178436
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5b2674b278fd48700409079803fbaf7ea177be61]

        tdf#164225: Only install MAR update_service when it will be needed
        
        ...where "will be needed" is approximated by "install location is under
        C:\Program Files" (i.e., where admin privileges will be necessary to do an
        update)
        
        Change-Id: I00c93df8c0c2c5132fffa4056b88af098cb4a644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178679
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-12-18  Robert Muir  <rmuir@apache.org>  [85b33eaab7462e72dfb426d8f268e061dcaf89ba]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c3ff53711dcac4bdec24f23a2c1f9712a0833b67
          - tdf#164366: fix wrong REP count in mongolian .aff file
            
            Commit d169602 broke parsing of this file by the lucene hunspell
            support, because now a `REP 3619` is followed by 3621 REP rules.
            
            Fix the count to be correct.
            
            Change-Id: I2c971dec7c44793e3d5b7a4030940014ddbebbb4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178710
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-12-18  Michael Weghorn  <m.weghorn@posteo.de>  [4f60246a1de68f7b47713ff926902791abe7a9ca]

        Revert "boost: upgrade to 1_87_0" for now to unbreak android arm32 build
        
        For some (still unknown) reason the upgrade from boost 1.86 to 1.87
        caused the 32-bit ARM Android builds to fail
        with errors like
        
            <inline asm>:1:41: error: expected '%<type>' or "<type>"
            .pushsection ".debug_gdb_scripts", "MS",@progbits,1
                                                    ^
            <inline asm>:318:12: error: .popsection without corresponding .pushsection
            .popsection
                       ^
            2 errors generated.
            make[1]: *** [/home/tdf/lode/jenkins/workspace/android_arm/solenv/gbuild/LinkTarget.mk:339: /home/tdf/lode/jenkins/workspace/android_arm/workdir/CxxObject/configmgr/source/groupnode.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            [build CXX] configmgr/source/node.cxx
            <inline asm>:1:41: error: expected '%<type>' or "<type>"
            .pushsection ".debug_gdb_scripts", "MS",@progbits,1
                                                    ^
        , see e.g. [1] and the list of all Android ARM 32 bit builds [2].
        
        A local bisect points to this commit, and reverting it
        fixes the build.
        Do this for now to work around the build failure and give
        time for finding a better solution.
        
        This reverts commit 25e7e1677b13db818b5458cd0c3fd3d9dfc88557.
        
        [1] https://ci.libreoffice.org/job/gerrit_android_arm/43354/console
        [2] https://ci.libreoffice.org/job/gerrit_android_arm/
        
        Change-Id: Ifad1412b691adce74bb16805975e3439898e3b74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178697
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3359b944fe3feab3fdc30aad3552c8ebb5ae886a]

        Resolves: tdf#156398 use same color combination as used in tdf#51300
        
        so we don't get white text on yellow background
        
        Change-Id: I346decaab293e2bb15c1110dfa61df5838607d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178694
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ff20399edf0e8ab4c15e802e5b1aa400db42d33c]

        Some --disable-zxing fixes
        
        For one, UITest_writer_tests3 would crash soffie.bin in an --enable-dbgutil
        build with
        
        > include/vcl/vclptr.hxx:109: VclPtr<reference_type>::~VclPtr() [with reference_type = AbstractQrCodeGenDialog]: Assertion `(!m_rInnerRef.get() || m_rInnerRef->isDisposed() || m_rInnerRef->getRefCount() > 1) && "someone forgot to call dispose()"' failed.
        
        from within that test_insert_qr_code.  But even with that out of the way, the
        test would still hang (in any kind of --disable-zxing build, not just
        --enable-dbgutil), with the Python process at
        
        >   File "uitest/uitest/test.py", line 129, in wait_and_yield_dialog
        >     time.sleep(DEFAULT_SLEEP)
        >   File "uitest/uitest/test.py", line 151, in execute_dialog_through_command
        >     yield from self.wait_and_yield_dialog(event, xDialogParent, close_button)
        >   <built-in method next of module object at remote 0x7fb6fc6a0230>
        >   File "instdir/program/python-core-3.10.16/lib/contextlib.py", line 135, in __enter__
        >     return next(self.gen)
        >   File "sw/qa/uitest/writer_tests3/insertQrCodeGen.py", line 18, in test_insert_qr_code
        >     with self.ui_test.execute_dialog_through_command(".uno:InsertQrCode") as xDialog:
        
        and the soffice.bin process idly yielding at
        
        > #14 0x00007fa582369b78 in Application::Yield () at vcl/source/app/svapp.cxx:473
        > #15 0x00007fa582368a40 in Application::Execute () at vcl/source/app/svapp.cxx:360
        > #16 0x00007fa58ca42fba in desktop::Desktop::Main (this=0x7fffe69ca960) at desktop/source/app/app.cxx:1679
        
        Change-Id: I007d1497e6f0c968039af3649f6252794e222226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-18  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [e6d4af2a03f22de1493e00e497e081240bf8a5c4]

        tdf#163319 Do not decrement destination position when moving a tab
        
        to the right
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: Id8da1a1b199927bb2f1b71b814737b8287ea2a34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178362
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [943c079def4f55463581e1639b08c11f04863a04]

        Update git submodules
        
        * Update translations from branch 'master'
          to 86672eb8932b6779dd5b6d036c083662d4bcd15f
          - update translations for master/25-2
            
            and force-fix errors using pocheck
            
            Change-Id: Ie775663b93d82f8392fa6317099ad158661dbdc7
            
2024-12-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4b182f88e2d798634b9065362e650c51011e1629]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7001361d995b74c7ea2bb334e442797e57feaea7
          - Typo
            
            Change-Id: I9ffdecb64a9a6adec25e6516615b65ea79e1e788
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178684
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0e5f569e030dbed6efd2527f9d0bc4a3b7ab7588]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 46b1c476e1b92773ea63f3e74460acb1cf5792a5
          - Typos
            
            Change-Id: I19aac6bc535a8ca337fe11247cb2823db64eb7a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178692
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [7503bb286ff6bc15c1682d47b188fc37f3beff31]

        [API CHANGE] a11y: Drop UNO service to create a11y contexts
        
        Drop the com.sun.star.accessibility.GetStandardAccessibleFactoryService
        UNO service that was used to create instances of
        the a11y classes for (mainly vcl) widgets.
        
        The service was needed to break a dependency cycle.
        However, with
        
            Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 17 12:04:04 2024 +0100
        
                a11y: Merge accessibility module into vcl
        
        and all the preparatory commits in place, there
        is no more dependency cycle, as the a11y classes
        for vcl widgets no longer depend on any modules
        "above" vcl.
        
        Therefore, drop the UNO service and the abstract
        vcl::IAccessibleFactory class and other related
        classes.
        
        Make all methods in the AccessibleFactory class
        (that was previously subclassing the abstract
        IAccessibleFactory) static helper methods,
        and call them directly.
        
        The UNO service dropped in this commit was
        introduced in
        
            commit 1af510e95147374e5289ae1c12f1f280931919f4
            Date:   Wed Feb 21 11:30:47 2024 +0200
        
                Create an UNO service to do the symbol lookup in toolkit::AccessibilityClient
        
        and its documentation was already clearly stating
        that it's only meant for LibreOffice internal use:
        
        > /**
        >   The toolkit module uses this to get a pointer to the AccessibleFactory from the acc module.
        >   Because we have a dependency in our modules that goes the "wrong" way.
        >
        >   @since LibreOffice 24.8
        >
        >   @internal
        >
        >   ATTENTION: This is marked <em>internal</em> and does not
        >   have the <em>published</em> flag, which means it is subject to
        >   change without notice and should not be used outside the LibreOffice core.
        > */
        
        Change-Id: Ib97396a4bad486d9530361dd851ad3ee0f9681b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178689
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [4c35e9beedc9ba89b20e7ce48cc04c800ee2fa6a]

        a11y: Drop unused UnoWrapper::maAccessibleFactoryAccess
        
        Unused since
        
            commit 739b0716504d2526fb7283100420e4bd5eacb7c2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Dec 4 15:48:51 2024 +0100
        
                a11y: Move menu a11y classes to vcl, no more use factory
        
        Change-Id: I492bc5dee8ccadba3d608ffb1cef011cc6f1e250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178688
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [486728e582d1932cb0b97a51b8edfacf462ec7f9]

        a11y: Use #pragma once
        
        Change-Id: I99b22c542c673c5633ebd9fe270e32759eb54457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178687
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [78c27e32df7298c13c27bd66221d5f8aff4da824]

        vcl a11y: Move AccessibleFactory declaration to header
        
        ... in preparation of using it directly elsewhere.
        
        Change-Id: I50e773fb359418838d7fd42846772ff4f1546ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178686
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [9283da858506fe3b4383e4cfe0506e470a4356f6]

        a11y: Merge accessibility module into vcl
        
        Now that the accessibility module no longer
        depends on toolkit and svtools and there's
        therefore no more cyclic dependency, merge it
        into the vcl library, where the vcl widgets are located,
        for which the classes in the accessibility
        module (primarily) provide the a11y classes.
        
        Initially, take over the existing UNO service
        "com.sun.star.accessibility.comp.GetStandardAccessibleFactoryService"
        to vcl as is. It used to be necessary to break the cyclic
        dependency between the vcl, svtools, toolkit and
        accessibility module. (vcl is the lowest and
        accessibility used to be furthest up in the dependency
        chain; yet vcl needed it to create the objects
        providing the XAccessible/XAccessibleContext
        for its widgets.)
        
        Further simplification can happen in upcoming commits.
        
        Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178647
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [90c3d4b17f053de94f098ce807836b974ab97877]

        a11y: Merge toolkit::IAccessibleFactory into vcl one
        
        toolkit::IAccessibleFactory and
        vcl::IAccessibleFactory are abstract classes
        providing methods to retrieve the XAccessible or
        XAccessibleContext for different vcl widgets.
        
        Both are implemented by the same class in the
        accessibility module: AccessibleFactory
        
        Merge toolkit::IAccessibleFactory into
        vcl::IAccessibleFactory to have things in
        one place, and have everything in vcl, i.e.
        no longer part of it in toolkit that itself
        depends on vcl.
        
        Change-Id: I5da571899c9987267cbec2950630d0c44ff4d2f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178643
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [3b6bea954e9cdc297c70e5d11cfe62600d9b3d86]

        weld: Drop now unused weld::Widget::{g,s}et_grid_*
        
        These methods were superseded by corresponding methods
        in the weld::Grid class in
        
                Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Mon Dec 16 11:02:00 2024 +0100
        
                    weld: Add weld::Grid to handle grid child positions
        
        Now that all existing code has been ported to the new
        API, drop the unused old methods.
        
        Change-Id: I94ffa6a9de5e052e8248276b60f6fe4f10dff697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178638
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [a62bc3edcf9b023268a59830e2e88e449fc8f1fa]

        Port SwTableColumnPage to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I75184bd5522c9ae53981a7260ee5de110b7565f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178637
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [1a66faa674e4ef953cfdb17f9be610e6f567adcc]

        sw: Resave tablecolumnpage.ui with glade 3.40
        
        Change-Id: I671a272f60dfd12325f760681cb3c6f988467c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178635
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [3625655191374af9dfdc34caae36f85596b4f785]

        Port SwCreateAuthEntryDlg_Impl to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Deduplicate the code a bit by introducing a
        `pTargetGrid` local var that points either to
        `m_xLeft` or `m_xRight`.
        
        This dialog can be triggered in Writer via "Insert" ->
        "Table of Contents and Index" -> "Bibliography Entry",
        then clicking the "Edit" button.
        
        Change-Id: Ib75c5f1225d9590849f1eaed083857dbe30ce551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178634
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [d640f8e81b146d7012ec4b18dc908ad63e078f2b]

        Port SwTOXWidget subclasses to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I7d6d23f0d1fec640c1de38c896f3e9b7e06ed70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178633
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [c0a3f50bd97c1d3b7c908777e8082efdf1447021]

        Port SwAssignFragment to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I6ba9008c4ab9b049d9703c13c15d3df262436e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178632
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [c29f7a7ab36b762c60199e1e9fa55c80f88b3f7a]

        Port SwAddressFragment to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I1ee227fbf9eaa4048e1a9c86ae0280ef473d6af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178631
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [e23046a56df98b384eb400b631a9d45c2fc996f2]

        Port ScDataFormFragment to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I1e0202182dc1f4f3136cfcabdb451ab52ee17294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178625
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [219084b9f3668d5b1012f6a737dde975bc8bf739]

        Port ScIconSetFrmtDataEntry to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I310bade49f4732e1da34486dcfb2dc23a3c3ae0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178624
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [3ff0a96bfa734c841572c756b47bc5730f8b646a]

        Port ScCondFrmtEntry to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I0d808c4738e14321c9d0a9b022abd4d215030910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178623
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [92d257cf7d67a6fa4b7ec23016b56bf226ba608b]

        weld: Drop unused CustomWeld::{g,s}et_grid_left_attach
        
        It's currently unused, so drop it.
        If there's ever a need to adjust grid positions in the future,
        this should instead be done by calling the corresponding methods
        on the weld::Grid, see previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: Ia573a850d62233a0500b8d3b38f2ddd47c2ce680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178622
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [0ec855823a9449c9196ab0508470de3b043fea2f]

        Fix and port ScHFEditPage grid handling to new API
        
        The code was calling weld::Widget::get_grid_left_attach
        and weld::Widget_set_grid_left_attach on the wrong widgets
        that are not direct children of the grid, but children
        of the grid children, triggering these warnings with
        gtk3:
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.461: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1206: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach'
        
            (soffice:1996241): Gtk-WARNING **: 21:10:33.472: ../../../gtk/gtkcontainer.c:1348: container class 'GtkViewport' has no child property named 'left-attach'
        
        To trigger:
        
        * start Calc with the gtk3 VCL plugin and SAL_RTL_ENABLED=1
        * "Format" -> "Page Style"
        * select the "Header" tab page
        * click on the "Edit" button
        
        Fix this by assigning IDs for the GtkScrolledWindows that
        are actually the direct children of the grid and using these
        instead.
        
        Port to the new weld::Grid API instead of calling the
        methods directly on the weld::Widget children,
        see previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I22c31a2f6b5eade56f6061023f5b914b615f4ba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178615
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [33d56b1cd6ee033fbb63501c799715ac0eebdfc4]

        Port SvxSplitTableDlg to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: I82b5d9c6ac3577cf247c64b88466fb0b0ba3f877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178614
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [19d9a4d0d6fcfc2b5b5c6d8b983817f94c0c1e1a]

        Port FontFeaturesDialog to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        To trigger dialog:
        
        * open context menu for paragraph in Writer
        * select "Character" -> "Character" to open the "Character" dialog
        * in the "Font" tab, click on the "Features" button
        
        Change-Id: I9b87a82c65c59b5d02ddf44df96ca85113f7ffc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178613
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [f956d81ac75450710629ee883bc2193f13dd6091]

        Port OBrowserLine to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        Change-Id: If0e0ea858a64411a137f07f33b1963185025e4d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178572
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [b7faeb1a70ee57c19531bc0f23538dd0ce6f07d1]

        weld: Port AdditionsDialog to new weld::Grid API
        
        See previous commit
        
            Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 16 11:02:00 2024 +0100
        
                weld: Add weld::Grid to handle grid child positions
        
        for more background.
        
        The changed code path can e.g. be triggered in Writer as follows:
        
        * "File" -> "Templates" -> "Manage Templates",
        * click the "Manage" combobox
        * select the "Extensions" entry
        
        Change-Id: I28f258fde8700ade4d5c6ded39d6063f31bc2e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178571
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Michael Weghorn  <m.weghorn@posteo.de>  [7056ea9c29c7e454c21b525e61cdc1e0c03f7301]

        weld: Add weld::Grid to handle grid child positions
        
        Currently, weld::Widget provides methods that can
        be used to retrieve and change the position (and column
        span) of widgets that are located inside of a grid
        (parent), e.g. weld::Widget::set_grid_left_attach
        to set the column.
        
        These methods however only make sense for widgets
        that are actually direct children of a grid, not
        for any "random" weld::Widget.
        Generally, it's the grid's responsibility to manage
        child positions, and the gtk3/gtk4 implementations
        actually assume that the parent is a GtkGrid, retrieve
        that parent and then call the corresponding GTK API
        functions for that grid.
        
        Align the weld API more with the concept of the
        grid being responsible for positioning its children
        by introducing a new weld::Grid class with methods
        equivalent to the current weld::Widget ones, but that
        take the child widget as an additional parameter.
        Take over the existing logic from the corresponding
        weld::Widget methods for both, the gtk and vcl implementations
        (e.g. GtkInstanceWidget::set_grid_left_attach
         -> GtkInstanceGrid::set_child_left_attach).
        Add an assert that the passed widget is actually
        a grid child.
        
        Deprecate the existing weld::Widget methods for grid
        position handling. They will be removed once existing code has
        been ported to the new weld::Grid API.
        
        The fact that the vcl implementation, VclGrid
        (used by vcl's new SalInstanceGrid implementation
        of weld::Grid), still relies on its vcl::Window children
        having the corresponding members set correctly remains
        unaffected.
        
        Change-Id: I67f5ea16b5108e8359820850f0815e34db439ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178570
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-17  Patrick Luby  <guibmacdev@gmail.com>  [13bdc2ba0cec0cb1c9e8077eb2217f69822a805f]

        tdf#161623 Handle windows that macOS forces to native full screen mode
        
        Starting with commit c1452e73091412ba0bb72306329e1912df2ba513, native
        full screen was disabled. However, in certain cases, macOS will force
        a window into native full screen mode and this caused numerous bugs.
        
        So add the following fixes to support native full screen windows. Note:
        the green titlebar button will still zoom the window. That button will
        only escape native full screen mode only when macOS has already forced
        a window into native full screen mode:
        
        - When in native full screen mode, -[NSWindow styleMask] will include
          NSWindowStyleMaskFullScreen which can affect the frame and content
          rectangle calculations so always use -[NSWindow styleMask] instead
          of the mask that was used to create the window when doing such
          calculations.
        
        - A comment in commit c1452e73091412ba0bb72306329e1912df2ba513 mentions
          crashing after ordering out a native full screen window. I have not
          experienced any crashing, but I did find that ordering out would
          leave the application in a state where there is no Desktop and both
          the menubar and the Dock are hidden. The fix, which is to close
          windows instead of ordering them out, was copied from the following
          NeoOffice source code file which is licensed under the Mozilla Public
          License, v. 2.0:
        
          https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/java/source/window/salframe.mm
        
        - In AquaSalFrame::GetWindowState(), add both the original and the
          curent frame when the window is in LibreOffice and/or native full
          screen mode.
        
        - Track LibreOffice and native full screen state in separate instance
          variables so that both modes can be activated independently and the
          window is not set back to its original size unitl a window has exited
          both full screen modes.
        
        LibreOffice also has its own full screen mode which hides the menubar
        and Dock, resizes to fill the screen, and hides all of its toolbars.
        As much as possible, both full screen modes should coexist and the
        user can enter or exit LibreOffice full screen mode while in native
        full screen mode. So add the following fixes for LibreOffice full
        screen mode:
        
        - Do not add the window's titlebar height to the window's frame as
          that will cause the titlebar to be pushed offscreen.
        
        - The menubar and Dock are both hidden when a window enters LibreOffice
          full screen mode. However, -[NSWindow setFrame:display:] shrinks the
          window frame to allow room for the menubar if the window is on the
          main screen. So, force the return value to match the frame that
          LibreOffice expects.
        
        - Multiple windows can be in LibreOffice full screen mode at the
          same time so hide or show the menubar and Dock when a LibreOffice
          full screen window gains or loses focus.
        
        - When a window is in LibreOffice full screen mode, LibreOffice hides
          the menubar. However, when in native full screen mode, hiding the
          menubar causes the window's titlebar to either fail to display or
          fail to hide when expected. So allow the menubar to remain visible
          when a window is in both LibreOffice and native full screen mode
          and disable all LibreOffice menus (like is done when a modal windowj
          is displayed) to mimic the effect of hiding the menubar.
        
        Change-Id: I94ae24a03d192a681d5500930f7fec70e595ffaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178497
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b70c6d5e79dde0ef50f83a18afc69703d0dfc712]

        sw: silence warning C6011
        
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sw/source/core/fields/reffld.cxx(1419): error C2220: the following warning is treated as an error
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sw\source\core\fields\reffld.cxx(1313) : warning C6011: Dereferencing NULL pointer 'pStart'. : Lines: 1299, 1301, 1302, 1303, 1305, 1307, 1308, 1309, 1312, 1313
        make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sw/source/core/fields/reffld.o] Error 2
        
        Change-Id: I7ab3a8906738ed0cd64c890cabdf04234c80afd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178666
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-17  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [896e87937fe6985d2f8f47b6c28a78703eeb85c5]

        tdf#132274 Clarify wording of default Writer zoom behaviour
        
        There was apparently some confusion what 'latest setting' was
        referring to (in fact, it's the latest setting that was stored in the
        document, for most cases).
        
        Change-Id: I30d36567cde602ba18b0b721dec0c9e76b560edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178660
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b5ff805386556a01fc7aa39696bfc987739f22b2]

        tdf#164124: sc_ucalc: Add unittest
        
        Change-Id: I002369729f8ced8023412d1a57d91816d44dbb3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178661
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7c2d94c6b41a71e0440953d753f6a7092626bc9c]

        crashtesting: unable to import rtf export of forum-mso-en-14843.doc
        
        user field names have control chars in them and import from rtf hits
        the code added by:
        
        commit a6516c76c01b92f7d35bfb352b63af7de42b5707
        CommitDate: Wed Oct 30 14:44:09 2019 +0100
        
            writerfilter: rtftok: filter control characters
        
        so control chars are stripped out, which results in a duplicate
        user field name which throws. Filtering out at doc import time
        seems to work better, so lets do that as well.
        
        Change-Id: I463e30b223bfb5639de23c696d112eda2c27b428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178657
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-17  Michael Stahl  <michael.stahl@allotropia.de>  [fae1eb775d44438a2193ba1ec07261ea0a94fef4]

        xmlsecurity: fix tests to run with system NSS on Fedora 40
        
        testDropMacroTemplateSignature fails printing this:
        
          warn:xmlsecurity.xmlsec:3511616:3511616:xmlsecurity/source/xmlsec/errorcallback.cxx:53: signatures.c:599: xmlSecNssSignatureSetKey() 'rsa-sha1' 'VFY_CreateContext' 4 'NSS error: -8011'
        
        because policy sets NSS_RSA_MIN_KEY_SIZE to 2048.
        
        testPDFGood fails printing this:
        
          warn:svl.crypto:3587940:3587940:svl/source/crypto/cryptosign.cxx:1941: ValidateSignature: message is not signed
          warn:xmlsecurity.helper:3587940:3587940:xmlsecurity/source/helper/pdfsignaturehelper.cxx:482: failed to determine digest match
        
        because enabling SEC_OID_SHA1 for NSS_USE_ALG_IN_ANY_SIGNATURE doesn't
        enable it for SMIME signatures, so smime_allowed_by_policy() fails -
        obviously one has to use NSS_USE_ALG_IN_SIGNATURE to enable it in any
        signature.
        
        Change-Id: I59ffaf0994eee6b51362fd3296f61465d0fc7903
        (cherry picked from commit a7b7b00b78426bff8607c77106ea62dd213f0821)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178663
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-17  Mike Kaganski  <mike.kaganski@collabora.com>  [b88a3f1f16f1eba6f5aabeedc8b4d5df8d54958a]

        Simplify and deduplicate a bit
        
        Change-Id: I3f7fac31e7f15562c39b453c67735d7386c86f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178658
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [3504cb5364c77849b63c1228a164e537380ea62b]

        sd: Dereference after null check
        
        C: /cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sd/source/ui/view/drviewsg.cxx(247): error C2220: the following warning is treated as an error
        C: \cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sd\source\ui\view\drviewsg.cxx(130) : warning C6011: Dereferencing NULL pointer 'Current()'. : Lines: 106, 109, 110, 112, c:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\include\comphelper\configuration.hxx:51, c:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sd\source\ui\view\drviewsg.cxx:113, 116, 123, 125, 127, 129, 130
        
        Since
        commit 9d9c24328cef503f999bf3a5475743e87a3aff5a
        Author: Gökay Şatır <gokaysatir@collabora.com>
        Date:   Tue Sep 24 13:30:22 2024 +0300
        
            cool#7406 Inform lokit side about the grid state.
        
        Change-Id: Ic06e765386330cf344380ddf61757298210f921e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178655
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d1b00c9924765624e0e3e5bdf947f3e30317ff8]

        use more concrete UNO in sw
        
        Change-Id: I664c7eff512625f988a2a278062719d3084845dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-17  Gökay Şatır  <gokaysatir@collabora.com>  [37edf62981acf8b73a70d645755e8cdbc9bbcd3f]

        cool#7406: Refactor Impress->getPartInfo & use JsonWriter.
        
        We need to add more information to getPartInfo function for getting grid properties.
        While doing this, i refactored current function to use JsonWriter.
        We also need to inform client side when a page border, size or margin change happens.
        This commit also adds a shared function for these events.
        
        Change-Id: I9dad094545c7cf0e072a7831f300dd0401ebf4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178639
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [844ef4fc67e37bd1db9e9895cf9805eaab57074f]

        sw: pStt -> pStart
        
        Change-Id: If2d8574e732581b5726734e2ac24196242a52d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178642
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [d43e4cf2fdcc01e626174c3fe8aa11d538351e52]

        sw: fix log messages
        
        After
        commit 285b66443303b8e240a6af48adb1f58bf4f8644e
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Dec 4 15:57:14 2024 +0200
        
            split up SwGetRefFieldType::FindAnchor method
        
        and
        commit 75d734698347565253571978fd585f1681229a97
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Dec 4 16:14:35 2024 +0200
        
            split up SwGetRefFieldType::FindAnchor method some more
        
        Change-Id: I77fb86a384f53c74586bc05e4cb3bcbebf225acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178641
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [85b7a25135eb96919d62a108fea18eab5531a4da]

        sc: Dereference after null check
        
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sc/source/core/data/column3.cxx(2821): error C2220: the following warning is treated as an error
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\sc\source\core\data\column3.cxx(2752) : warning C6011: Dereferencing NULL pointer 'pPattern'. : Lines: 2723, 2726, 2727, 2728, 2730, 2731, 2732, 2733, 2734, 2735, 2736, 2737, 2738, 2739, 2740, 2742, 2744, 2745, 2747, 2751, 2752, 2753, 2754, 2756, 2762, 2763, 2766, 2791, 2809, 2811, 2814, 2819, 2740, 2742, 2744, 2745, 2747, 2751, 2752
        make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/sc/source/core/data/column3.o] Error 2
        
        After
        commit 2c613da01d02d45a140b94b391a142aede46e8b8
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Dec 4 11:20:01 2024 +0200
        
            tdf#163010 inline and cache rDoc.GetCondFormat call
        
        Change-Id: If9093d5b43ae63e059b3f0597c85b326599e9ed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178621
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc8a86743d122a7df8fcabf59959705895e631f9]

        vcl: silence warning C6011
        
        Compiling with ENABLE_MSVC_ANALYZE fails with
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/jsdialog/jsdialogbuilder.cxx(1034): error C2220: the following warning is treated as an error
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\vcl\jsdialog\jsdialogbuilder.cxx(1029) : warning C6011: Dereferencing NULL pointer 'pButton'. : Lines: 1020, 1022, 1025, 1027, 1028, 1029
        C:\cygwin64\home\tdf\jenkins\workspace\gerrit_windows\vcl\jsdialog\jsdialogbuilder.cxx(1057) : warning C6011: Dereferencing NULL pointer 'pButton'. : Lines: 1038, 1039, 1040, 1042, 1044, 1046, 1048, 1050, 1053, 1055, 1056, 1057
        make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:339: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/vcl/jsdialog/jsdialogbuilder.o] Error 2
        make[1]: *** Waiting for unfinished jobs....
        
        Change-Id: I97bbd1a68800b2b9e2c2f1cefbf8a74d3416b811
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178612
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-17  Rashesh  <rashesh.padia@collabora.com>  [09b8baaaedd788d424d4d14690ae2aff9d60138f]

        kit: re-initialize user-defined dictionaries on lo_init
        
        Change-Id: I017767089efe54bf8d32d905e995f1a99c23984f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178398
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit f4df86eda7ef82a3ffaf7fdd76a4775d0f66e438)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178609
        Tested-by: Jenkins

2024-12-17  Mike Kaganski  <mike.kaganski@collabora.com>  [38d8aa28d5f1a82a064b3babc71fcb964e72eccc]

        Simplify variable expansion
        
        Change-Id: I2447d040a371da9c76fe167da3ac802cd7d7416a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178610
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1d9a3789c97c4bbcd3f71a7e3f6f81034570b55b]

        Fix typo in earlier commit
        
        ...6d1cddea8e4e19287891ab8fb7e3774ae9976ea1 "tdf#135628 Let uri-encode encode
        newlines"
        
        Change-Id: I11e6f08947e85964f02fe1379217a2004492d0b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178602
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-17  Sakura286  <sakura286@outlook.com>  [254546523f2b77e1f79a60b73712e04f233136a3]

        tdf#148631: fix shading in some ribbon shapes
        
        This fixes the shading of some custom shapes:
          - mso_sptRibbon
          - mso_sptEllipseRibbon
          - mso_sptEllipseRibbon2
        
        Content in this patch:
          - Remove nofill command for shading sub-shape
          - Beautify the comment by the way. No vertex is changed.
        
        Change-Id: Ia26fcf6d3aad8b2286e9499a35efed72eb8cc795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-17  Justin Luth  <justin.luth@collabora.com>  [61fd72bff241cf3cb0556cee7e414a698c46cd1d]

        tdf#164263 writerfilter: avoid exception when SAL_DISABLE_PRINTERLIST
        
        This fixes a backported to 24.2.1 regression
        from commit e6f75eb50bc5d1ebccda0c0f80a7b353d991106e
        
        Apparently a blank value is allowed to be in RES_PAPER_BIN,
        but it is not allowed to try to setPropertyValue as a blank string.
        
        Lots of ways I could try to solve it.
        -could just lump it in with staticDenylist,
         but that is comment-labeled as "read only values".
        -could just wrap setPropertyValue in a try/catch,
         which is tempting because it is a generic fix
         for these otherwise silent failures,
         but that would hide potentially useful info
         behind a generic exception message.
        -just do the one-off check like I first decided to do.
        
        I don't see any unit test examples from the offending regression,
        or anything else in SW. So I don't know how I can create
        a unit test for this.
        
        Change-Id: Ic2506dd4adb71f0e64d719363f6d261ffccf0151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178620
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-12-17  Justin Luth  <justin.luth@collabora.com>  [668bd34288952019d6013758b435294f4fd83a87]

        tdf#164075 rtfimport: ignore assert developed for DOCX fixing
        
        I don't exactly remember why I put the assert there,
        but it sounds reasonable to expect that if
        the paragraph defined the numbering
        that it should also have numbering rule content,
        and if it doesn't, then it is worth investigating why.
        
        Investing anything related to RTF is never worthwhile.
        
        Change-Id: I6525d0a40d9535f1888056a610576085941605a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178607
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-12-16  Jonathan Clark  <jonathan@libreoffice.org>  [537645c0834eab2d277113f1e3fcf039c994832d]

        tdf#66791 sw: Treat weak punctuation as Asian in Asian paragraphs
        
        This change modifies script detection to treat certain weak punctuation
        marks, particularly left- and right- quotation marks, as Asian script in
        paragraphs containing Chinese and Japanese characters, but no Complex
        characters. This change improves our script detection compatibility with
        other programs.
        
        As part of this change, duplicated script detection code has been
        extracted from Writer and Edit Engine, and consolidated.
        
        Change-Id: Ib2880f2e832aaac4c0093971daa88223c7232d63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178608
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-16  Andras Timar  <andras.timar@collabora.com>  [8e9e47bd73982d868b9db394bfbc1b718b5a85b5]

        Add Nextloud to technical.dic
        
        Change-Id: I68fec7cbaf167c2702ea38b93d74052d373fdf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178599
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 91119801859ed20900ff30751ef00c9cb0dcd62d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178604
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [a7cc36dad9f37dcd74fe03ea08887a7732f08ff0]

        a11y: Move TabBar a11y classses to svtools, no longer use factory
        
        Move AccessibleTabBar and related classes to
        implement accessibility for the TabBar control
        to svtools, where the TabBar code is also located.
        (This matches how it's organized for the Ruler control
        whose a11y class AccessibleRuler is also in svtools.)
        
        This removes the last dependency of the accessibility
        module on svtools, so drop that from accessibility/Library_acc.mk.
        
        Instead of using the AccessibleFactory to
        create an instance in TabBar::CreateAccessible,
        just call the AccessibleTabBar ctor directly.
        
        Change-Id: Id6a8852de930ffe7fe7509f84f33861d274120dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178588
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [12ce6bbd537b6b6cb00f674dd5035d4389135c75]

        a11y: Drop unnecessary #ifndef check
        
        `ACCESSIBILITY_EXT_ACCESSIBLETABBARPAGELIST` isn't defined
        anywhere, so this check doesn't make any difference.
        
        Change-Id: I4f9c2ec1f7893158c4a9780acfa8d442924db6d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178587
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [0143fd51480169696efb565f5c1da12364b185ff]

        svtools a11y: Switch OSL_ENSURE to assert
        
        Change-Id: I5391cd0a23c28d1df30f2f4f87701156e25f34b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178586
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [4b55d5ab1566ac64fc432d8c9e62c346441730cb]

        svtools a11y: Simplify Ruler::CreateAccessible
        
        Ruler::mxAccContext is only used in this method
        and nowhere else, so there's no need to have
        this as a class member. (The vcl::Window
        base class already holds a Reference to the
        XAccessible, s. below.)
        
        There's no need to explicitly call
        vcl::Window::SetAccessible, because
        Ruler::CreateAccessible gets called
        by Window::GetAccessible, and that already
        sets `mpWindowImpl->mxAccessible`, which
        is what vcl::Window::SetAccessible also does.
        
        Drop the
        
            // MT: Fixed compiler issue because the address from a temporary object was used.
            // BUT: Should it really be a Pointer, instead of const&???
        
        comment for which it's unclear what it refers to now,
        neither is it clear to me when looking at the
        commit that originally introduced it,
        
            commit b755fb8c0f6b1282f62c12f378c0a5ecac64d490
            Author: Steve Yin <steve_y@apache.org>
            Date:   Mon Nov 25 16:15:58 2013 +0000
        
                Integrate branch of IAccessible2
        
        Change-Id: Ic423d0fcc97894303c29097023742f2dabf00b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178585
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [8af53caecef4d7b0add1823a4a1f8be5907679b2]

        a11y: Drop special menu/toolbar handling in AccessibleFactory
        
        IIUC, this code path should never be reached:
        
        The accessible for menu and menu floating windows
        gets created in Menu::CreateAccessible. The
        menu floating window reuses the Menu's accessible
        and if the code path dropped in this commit was ever
        reached for menu floating windows, it would be problematic,
        see the commit messsage of
        
            commit b608604d0bbecdc24a17175374581b4e2d720658
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 14:07:52 2024 +0000
        
                tdf#164093 tdf#157001 wina11y: Use vcl::Window's actual XAccessible
        
        for more details.
        
        Implementation for floating toolbar windows to have a null
        XAccessible is implemented in ImplPopupFloatWin::CreateAccessible,
        so that case also shouldn't get here (where a null XAccessibleContext
        would have been returned).
        
        Change-Id: Ie9a55b4120a6857e9cac534fa2bdfd3a0cf7d9c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178584
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-16  Gökay Şatır  <gokaysatir@collabora.com>  [9d9c24328cef503f999bf3a5475743e87a3aff5a]

        cool#7406 Inform lokit side about the grid state.
        
        When grid in impress or draw is turned on, we need to inform libreofficekit.
        So it can show relevant UI and act accordingly. Same goes for griduse command.
        
        Also add a test for the new state callbacks.
        
        Change-Id: Ia5737ca0088e434f826eb7c40b0bec59049432af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178578
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6d1cddea8e4e19287891ab8fb7e3774ae9976ea1]

        tdf#135628 Let uri-encode encode newlines
        
        ...and invoke it via `printf ... | uri-encode` rather than `echo ... |
        uri-encode`, to avoid passing spurious newlines to it (which appears to have
        been the reason for it not to encode newlines in the first place)
        
        Change-Id: I26131a19f69c04b0beca8e8bab72c1dbb65300c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178596
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0ecc9bbffb15bd9b312e706238a131f9a19fa0f]

        crashtesting: unable to import doc export of forum-de2-10510.ott
        
        "No namespace defined for pic at sax/source/fastparser/fastparser.cxx:718"
        
        Change-Id: I417ee6608b63f27b92236ab96cc705d4261b8350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178581
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2388501ed81c4873d63f2f26505603ade06642d3]

        Reapply "add an autotext 'common' directory like templates/common"
        
        This reverts commit 331bcad4dbe923f4ce47cfe1de64ea0ffbe5a6ce now
        there is a fix for the problem that triggered the revert.
        
        Change-Id: I4acacd51d5799e80dfa42a0433278e684d82a860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178577
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-16  Miklos Vajna  <vmiklos@collabora.com>  [703cbc0bb75b0943cf5b95ff62c6fe4b4a028788]

        CppunitTest_sw_apitests: remove leftover myNewGroup2.bau before the test
        
        This fails for me in a tree that runs 'make check' and there was a
        previous 'make check' previously.
        
        Seems the trouble is that we have this C++ test creating an autotext
        .bau file, but there is also a Java one, so if we're not lucky with the
        order of these, the C++ one will fail with its hardcoded "must be 3 .bau
        files in instdir" assertion.
        
        Fix the immediate problem by removing the test .bau file before running
        the C++ test.
        
        A better, but more complex fix would be to create the test .bau file in
        the user profile (and not in instdir) for both the Java and C++ cases,
        and then none of these tests would influece other tests during 'make
        check'.
        
        Change-Id: I536d769db733515ec6a7d41fd7dbf601c4b582d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178548
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178576

2024-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [25e7e1677b13db818b5458cd0c3fd3d9dfc88557]

        boost: upgrade to 1_87_0
        
        * external/boost/0001-Add-a-comma-before-ellipsis-in-constexpr_swap.patch.2
        has been fixed upstream
        
        <https://dev-www.libreoffice.org/src/boost_1_87_0.tar.xz> has been generated (on
        Debian 12) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.87.0/source/boost_1_87_0.tar.bz2
        > $ printf 'af57be25cb4c4f4b413ed692fe378affb4352ea50fbe294a11ef548f4d527d89 boost_1_87_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_87_0.html>
        > boost_1_87_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_87_0.tar.bz2
        > Unpacking boost_1_87_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_87_0.tar.xz ...
        > Cleaning up ...
        > efd6d4ce7e8571ba87f77a30bee2d3dd8dccd306721351464fc6998dd00b0c8c  boost_1_87_0.tar.xz
        > Done.
        
        Change-Id: I9aaa9fc435b5b1890f9038ccfbfa26707a57a8da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178574
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f7aceea7a54c9c17dce2583659a19d11efd6159]

        Java-WebSocket: upgrade to 1.6.0
        
        Downloaded from https://codeload.github.com/TooTallNate/Java-WebSocket/tar.gz/refs/tags/v1.6.0
        
        Change-Id: Ibcf78603e1826721fc5620eef20d633addbf357f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178538
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-16  Oliver Specht  <oliver.specht@cib.de>  [728f5eb01de33bd1f16f25d9bd7cdef6fa0909de]

        tdf#164299 fix crash in pasting HTML table
        
        Supports <colgroup> element now.
        
        Change-Id: I4fe49f3c79c567e9364a1642e716846256c6070b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178536
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [401dedc11e8921505fbd3eac8c26bb065e0197b0]

        Set that a non-modal Popover don't auto-grab focus on popup
        
        currently sc/uiconfig/scalc/ui/filtersubdropdown.ui is the only one of
        these, and this doesn't change its behaviour
        
        Change-Id: Ia975f40fd75c88ddbb28490e60c4274b9e6e056b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-16  Miklos Vajna  <vmiklos@collabora.com>  [80cdbde2883ca2b8fe56051948672f07715ed910]

        svx: prefix members of SdrUnoObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Idb56275705f63ffda376d0ca1aa85af0f72dc172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178533
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [dc7e8be039d6c581686fd94c641e3a7e47d18d4e]

        tdf#130857 qt weld: Introduce QtInstanceScrolledWindow
        
        QtBuilder::makeObject already creates a QScrollbar
        for "GtkScrolledWindow" objects.
        
        Implement QtInstanceBuilder::weld_scrolled_window
        to return an instance of the newly added
        QtInstanceScrolledWindow class.
        
        While weld::ScrolledWindow subclasses weld::Container,
        don't let QtInstanceScrolledWindow subclass
        QtInstanceContainer, because the latter requires
        a QWidget that has a layout set, while QScrollArea
        directly manages its child widget without using
        a layout.
        
        Implement QtInstanceScrolledWindow::vadjustment_set_step_increment,
        which is the only weld::ScrolledWindow method used by
        FontFeaturesDialog and trigger an assert in all others.
        (Leave implementing them for later, e.g. when adding support for
        dialogs that actually make use of them.)
        
        Change-Id: Ie122225f70f90b9421f902fce320d414f03291f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178496
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-16  Michael Weghorn  <m.weghorn@posteo.de>  [f161a066133e7cadcf109adba578460f9628dfae]

        tdf#130857 qt weld: Implement QtInstanceWidget::{g,s}et_direction
        
        Change-Id: If9e8ce40bd162e6ef79c20c6f13032d6fed8ea5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178495
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7b9077669541b5685f3758b7a640b7e0d10dbe1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f25a5c106d4188ff4629e00b832f2cdfe891544b
          - Mute L10N in Navigator context help page (IV)
            
            + Sort panel <-> deck terminology error, according to (1)
            + Changes in experimental mode warning, replacing explicit text by embeded one.
            
            (1) https://wiki.documentfoundation.org/File:LO-HIG_SideeBar-Terminology.png
            
            Change-Id: I8d7d4e899dadda56c2ef1b6290e74b09f7411f0b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178527
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-16  B. Antonio Fernández  <bantoniof@libreoffice.org>  [086fb66b36a905e824b0fd8c32eacfe693fcbcef]

        Add TSCP example file for Spanish (es-ES)
        
        Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Change-Id: I26030116201f37195cdf052f7f5e18786d1d61a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178493
        Tested-by: Jenkins

2024-12-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8ea0108e6bf06cae0caba48ed92c96f31aa4e7e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09cb07cdb52fd8ea1f73685476580cf001a8b927
          - Mute L10N in Navigator context help page (III)
            
            Change-Id: Ic4c791f5f7f59376b548caa476cbc7b635e5e1ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178523
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-12-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [74d0fe2b2186d9802798f07cbf4ad71865f4e081]

        cid#1607171 Data race condition
        
        and
        
        cid#1606809 Data race condition
        
        Change-Id: I27919537a022f8375b0be2df0549ae9878ef0a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23710388dab26b5716da5c99537e37e36128de79]

        Gtk-CRITICAL gtk_tree_model_iter_nth_child: assertion 'n >= 0' failed
        
        Change-Id: I9a3f66263200071f6a63d3a6ae4ea882a56d4c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178490
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [d65d8a3adc9691451bfa21ca8c574b77e54a3290]

        tdf#130857 qt weld: Implement QtInstanceWidget::strip_mnemonic
        
        Change-Id: If106bf66d58921eedd8968c5321c0d9555e03aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178492
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [113ce1e5029d07224a2bbe7a5b253799fb420228]

        a11y: Leave URL/text field in QR dialog on simple tab
        
        See similar commit for another dialog
        
            commit faa6749592b7777773a51cb6f350a39aeb67b052
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Oct 7 08:10:56 2024 +0200
        
                a11y: Leave accessible description text view on simple tab key
        
        for reasoning.
        
        Change-Id: Iac05e219f852918c4f0861541fd15cbffb6c9eaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178487
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [21d137ba6905872e5c8d46081756c3fef15b937f]

        tdf#130857 qrcodegen.ui: Define grid children in order
        
        Switch the order in which the children of the grid in the
        .ui file are defined so that the order matches the visual appearance,
        which makes sure that tab focus order with the Qt-based VCL plugins is
        correct as well in that dialog when using native Qt widgets, where
        focus order is (by default) based on widget creation order.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        Change-Id: I3995a50a34b2fc1515c5d64f5f1b6ff0dd83dbeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178486
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [09e76631dd60f1e6ffab3faa17889fe7327b8a3c]

        tdf#130857 tdf#162704 qt weld: Support QR/bar code dialog
        
        Declare support for the "QR and Barcode" dialog
        that can be triggered in Writer using "Insert" -> "OLE Object"
        -> "QR/Barcode".
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        The native QPlainTextEdit also doesn't have the
        problem of rendering artifacts as described in tdf#162704
        for the vcl widget when used with qt6/kf6 and the Breeze
        style.
        
        Change-Id: I6263b8961d97141719e2b23dcc4467cda960d3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178485
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [89b00d3e34c93b4ea0701a321a3cecf57aa0e378]

        tdf#130857 qt weld: Drop scroll area parent if redundant
        
        For Qt widgets that already provide scrolling capabilities
        by themselves because they implement QAbstractScrollArea,
        as QPlainTextEdit does, there is no need to have a separate
        QScrollArea parent, and having one can even result in
        unexpected behavior as described in previous commit
        
            Change-Id: Ia94fdc8075a76af6a18b656a4c6b9168a408aee0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 18:16:18 2024 +0200
        
                tdf#130857 qt weld: Support "Alt Text" dialog
        
                Declare support for the "Alt Text" dialog that
                can e.g. be triggered as follows in Writer:
        
                * "Insert" -> "OLE Object" -> "QR and Barcode"
                * type anything, confirm
                * select the QR code
                * right click, select "Alt Text" in the context
                  menu
        
                This means that native Qt widgets are used for that dialog
                now when using the qt5 or qt6 VCL plugin and starting LO with
                environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
                Currently, tab/focus behavior is a little odd,
                as focus first moves to the scroll area that
                the QScrollArea (created for the "GtkScrolledWindow"
                object in the .ui file) before it moves inside the
                QPlainTextEdit (created for the "GtkTextView" object
                in the .ui file) contained therein.
                That will be improved in an upcoming commit.
        
        Therefore, add special handling for the QScrollArea child:
        
        * If it subclasses QAbstractScrollArea, then remove
          the QScrollArea parent from the widget hierarchy,
          and put the child widget in its place. Don't do it
          directly in QtBuilder::tweakInsertedChild, but only
          after WidgetBuilder::processUIFile has finished
          processing the .ui file. This is necessary for
          the packing properties for the scroll area to be
          applied properly: WidgetBuilder::handleChild calls
          `tweakInsertedChild` before `applyPackingProperties`,
          so the child wouldn't yet "inherit" the correct
          packing properties (like grid position) otherwise.
          (Seen in a WIP branch with Writer's "Insert" ->
          "OLE Object" -> "QR and Barcode" dialog with an
          earlier attempt to replace directly, where the
          text field would move to the wrong position.)
        * If it doesn't subclass QAbstractScrollArea, set the
          widget as the scroll area's widget using
          QScrollArea::setWidget.
        
        The first scenario is the one in the "Alt Text"
        dialog described in the commit message quoted above
        and makes that dialog work as expected.
        The second scenario might be relevant in other
        dialogs, because just setting the widget as a
        child might not be sufficient for it to be
        placed and handled properly for scrolling.
        
        Change-Id: If475f8a8108eae958d49e0624e870936456206c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178484
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [d798242b8a1761e1bbd9f9e8aff205dabd95017e]

        tdf#130857 qt weld: Support "Alt Text" dialog
        
        Declare support for the "Alt Text" dialog that
        can e.g. be triggered as follows in Writer:
        
        * "Insert" -> "OLE Object" -> "QR and Barcode"
        * type anything, confirm
        * select the QR code
        * right click, select "Alt Text" in the context
          menu
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Currently, tab/focus behavior is a little odd,
        as focus first moves to the scroll area that
        the QScrollArea (created for the "GtkScrolledWindow"
        object in the .ui file) before it moves inside the
        QPlainTextEdit (created for the "GtkTextView" object
        in the .ui file) contained therein.
        That will be improved in an upcoming commit.
        
        Change-Id: Ia94fdc8075a76af6a18b656a4c6b9168a408aee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178483
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [da56d1bd13e0396ca04b58d9e09bc9ad6315a869]

        unnecessary qualifications on get_cursor_nId
        
        Change-Id: Iae38bac81b14197784e92c610c3c208ec9ba791e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a2a228d3bfe68acdefe3c2591e6451c99da9a03]

        Gtk-WARNING gtktreestore.c:1047: Invalid column number 1 added to iter
        
        Change-Id: I228cd7ae5d4b8686dbbebc6c50ea7048f3ff54e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [01f0676b9517af903abd7da041d8219e5df25eeb]

        cid#1608560 Data race condition
        
        Change-Id: I3b579434727e8b51d0de136c83d891c2f409d77a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178482
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aed39170cea65926bb4e497dfde08e4e16f9ee8f]

        cid#1606940 Check of thread-shared field evades lock acquisition
        
        and
        
        cid#1608607 Check of thread-shared field evades lock acquisition
        
        futile to lock m_nState
        
         #1  0x00007f3bdc4a9cc1 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6
         #2  0x00007f3bc48b0683 in __gthread_mutex_lock (__mutex=0x29ae4698) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/x86_64-redhat-linux/bits/gthr-default.h:762
         #3  0x00007f3bc48b9505 in std::mutex::lock (this=0x29ae4698) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/std_mutex.h:113
         #4  0x00007f3bc48b8bec in std::unique_lock<std::mutex>::lock (this=0x7fffa21aa7e8) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/unique_lock.h:147
         #5  0x00007f3bc48b0b58 in std::unique_lock<std::mutex>::unique_lock (this=0x7fffa21aa7e8, __m=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/14/../../../../include/c++/14/bits/unique_lock.h:73
         #6  0x00007f3bc48af7cc in fileaccess::BaseContent::cDEL (this=0x29ae4600) at core/ucb/source/ucp/file/bc.cxx:1126
         #7  0x00007f3bc48af9d4 in non-virtual thunk to fileaccess::BaseContent::cDEL() () at core/instdir/program/../program/libucpfile1.so
         #8  0x00007f3bc492d43f in fileaccess::TaskManager::getContentDeletedEventListeners (this=0x29ab47e0, aName="file://core/instdir/program/../share/config/cdefghij.klm")
             at core/ucb/source/ucp/file/filtask.cxx:2581
         #9  0x00007f3bc492caaa in fileaccess::TaskManager::remove
             (this=0x29ab47e0, CommandId=5, aUnqPath="file://core/instdir/program/../share/config/cdefghij.klm", IsWhat=fileaccess::TaskManager::FileUrlType::File, MustExist=true)
             at core/ucb/source/ucp/file/filtask.cxx:1572
         #10 0x00007f3bc48ab8c2 in fileaccess::BaseContent::deleteContent (this=0x29ae4600, nMyCommandIdentifier=5) at core/ucb/source/ucp/file/bc.cxx:934
         #11 0x00007f3bc48a9891 in fileaccess::BaseContent::execute (this=0x29ae4600, aCommand=..., CommandId=5, Environment=empty uno::Reference) at core/ucb/source/ucp/file/bc.cxx:300
         #12 0x00007f3bc48ad00a in non-virtual thunk to fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) ()
             at core/instdir/program/../program/libucpfile1.so
         #13 0x00007f3bdc8f5537 in ucbhelper::Content_Impl::executeCommand (this=0x29adfb80, rCommand=...) at core/ucbhelper/source/client/content.cxx:1260
         #14 0x00007f3bdc8f673c in ucbhelper::Content::executeCommand (this=0x7fffa21ab0a0, rCommandName="delete", rCommandArgument=uno::Any("boolean": 1 '\001'))
             at core/ucbhelper/source/client/content.cxx:562
         #15 0x00007f3bdf7fd2c1 in KillFile (rURL=...) at core/svx/source/gallery2/galmisc.cxx:291
        
        Change-Id: Iff9114adb4d5fe2ccf0d5a10fdd91295393a7820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177519
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [877205ccb1a66bec26817e9c51c53acca715c64b]

        Simplify OOo2OasisTransformer
        
        Change-Id: I212c3196060e4038cb265d10c841ebbbeb736ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178478
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad65448f3a3c1186c2c86970cbb7df1c48f81ba7]

        Get the style color and number just once
        
        Change-Id: I4dfa6feb1f41f9c62bd025ff521adc011c655926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178453
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4544d10c3833b05a5cdb653e8ba59749f09430f1]

        cid#1556282 silence Unguarded read
        
        Change-Id: If95e72b324378b334e106c9cb78e8e198f819573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-14  Manish  <mbera.dev05@gmail.com>  [5347fc187487f78d94f55654f4ac2e8ffdda54b2]

        use insert function instead of for loop
        
        Change-Id: Iee9dd7faee476642a19349f68191904207be3c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178395
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa91f149b1a0fe6851d3a934e8351eccb8f3a56e]

        cid#1636693 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0122df11e30fb4f083d4183a450b00a0b2adca72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178450
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [16ad7dd90bca781a608499c6450bb1bc11ec096f]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_text_height
        
        Change-Id: Ibff403210b430264b2e0b0ce35b6bee11e4c2669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178446
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [f27d2d76c4e577c7231ae755548a8fc20711ca48]

        tdf#130857 qt weld: Support mail merge "Server Auth" dialog
        
        Declare support for Writer's "Tools" -> "Options"
        -> "LibreOfficeDev Writer" -> "Mail Merge Email"
        -> "Server Authentication" dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the first dialog requiring support for
        radio button groups added in previous commit
        
            Change-Id: I60e8b5b525411c299ac50a8712361cc8572cc403
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 13 22:55:50 2024 +0100
        
                tdf#130857 qt weld: Evaluate radio button groups
        
        Change-Id: I6dcc386b47256dbd573bc4678807d414aa5189df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178445
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [e32d069ba74229916c459842d0c27c5a89b82168]

        tdf#130857 qt weld: Evaluate radio button groups
        
        Add support for radio button groups by implementing
        QtBuilder::setRadioButtonGroup.
        
        Qt provides QButtonGroup [1] to explicitly group
        buttons. Quoting from the QRadioButton doc [2]:
        
        > Radio buttons are autoExclusive by default. If auto-exclusive is
        > enabled, radio buttons that belong to the same parent widget behave as
        > if they were part of the same exclusive button group. If you need
        > multiple exclusive button groups for radio buttons that belong to the
        > same parent widget, put them into a QButtonGroup.
        
        To make sure exactly one button group exists and it gets
        freed automatically, make the radio button whose ID is set for
        the GtkRadioButton::group property [3] the parent (and thus the
        owner) of the group.
        Set a pointer of the group as a property for that button,
        so it can be retrieved directly from the button without requiring
        another map/... to keep track.
        
        With this in place, the radio buttons in Writer's
        "Tools" -> "Options" -> "LibreOfficeDev Writer"
        -> "Mail Merge Email" -> "Server Authentication"
        dialog are now grouped into 2 groups as expected in
        a WIP branch, rather than all of them being in one group (because
        they all have the same grid as a parent).
        Support for that dialog will be declared in an
        upcoming commit.
        
        [1] https://doc.qt.io/qt-6/qbuttongroup.html
        [2] https://doc.qt.io/qt-6/qradiobutton.html
        [3] https://docs.gtk.org/gtk3/property.RadioButton.group.html
        
        Change-Id: I60e8b5b525411c299ac50a8712361cc8572cc403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178444
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [7f64114f90c58599c459b9b5ce622e4d97bf9388]

        tdf#130857 VclBuilder: Move more radio group logic to base class
        
        Add a purely virtual WidgetBuilder::setRadioButtonGroup method
        and call it for each of the entries in the map from
        WidgetBuilder::processUIFile, in line with what is already done
        for mnemonic widgets.
        Move the existing logic for handling such a pair to the new
        VclBuilder override, VclBuilder::setRadioButtonGroup.
        
        An "actual" implementation for QtBuilder will be added in a
        separate commit, just emit a warning there for now when the method
        gets called.
        
        Change-Id: I027278014bb18d9d5f3de8189cd2f515959bf3e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178443
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [ce67331daa101ce1d8fc81fe1c843d8810f7a33c]

        tdf#130857 VclBuilder: Store radio button groups in BuilderBase
        
        Move the std::vector<RadioButtonGroupMap> and the method
        to extract and add to that map from VclBuilder to its base
        class, BuilderBase.
        
        Add a getter, BuilderBase::getRadioButtonGroupMaps instead
        of accessing the base class member directly in the VclBuilder subclass.
        
        Change-Id: Ic0d2abbd9faa41760d542ab22a80f2ba23136ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178442
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [ae078891116a097d06133f4176421cde4cc333f6]

        Fix GNU C++ version check
        
        It must match the existing GNU C version check (starting at line 4812).
        An omission from commit 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 (Adapt
        Clang and GCC minimum version checks, 2023-09-23).
        
        Change-Id: Iaaf7d8ba5ab7d731db9f4e84311a37600444cedc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178439
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [49250f85f5c375ea04e302eb95871bf339fb18e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7407423c52548eeed98be9ebf00f20a823b1ac29
          - Mute L10N in Navigator context help page (II)
            
            Change-Id: I90c53621efef6bdfd47c68a57d285daf3ecb7ba7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178440
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [9a493013f2f3b116a21266c14952e507c475f419]

        a11y: Port from svtools to vcl clipboard helper
        
        Switch from using svt::OStringTransfer::CopyString
        to vcl::unohelper::TextDataObject::CopyStringTo
        to copy a string to the clipboard, to avoid
        a dependency on the svtools library for this task.
        
        Change-Id: I5226c28b5519d4fc020f45d7967b9ad15aab0dae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [42b788d090f21c05eb3a207630c4760dbc00bb16]

        a11y: Make TabBar a11y independent of HAVE_FEATURE_SCRIPTING
        
        Build the code for the TabBar a11y classes independent of
        whether or not the scripting feature is enabled.
        
        Otherwise, e.g. the tab bar showing sheets in Calc is inaccessible
        in a `--disable-scripting` build, i.e. it e.g. doesn't show up
        in Accerciser.
        
        It was made conditional on HAVE_FEATURE_SCRIPTING in
        
            commit fb308c193bc9f0d07ad2cccd5a0b239f86cbe442
            Date:   Wed May 19 12:16:42 2021 +0200
        
                Fix --disable-scripting for DESKTOP build
        
        , which doesn't give any explicit reason, so my
        assumption is that it had some dependency relying
        on that feature being enabled back then.
        
        At least a local `--disable-scripting` build of mine
        works fine with this enabled again now, so let's assume
        whatever was the problem back then is solved by now.
        
        Change-Id: I6ee2ea6823aaa30bf597678c2b3ee86b42111920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178437
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [e9fd0df2369a96e80f0cc178104b356e27dc506c]

        a11y: No longer let accessibility module depend on toolkit
        
        In the AccessibleBrowseBox ctor, no longer use the
        VCLUnoHelper::GetInterface helper from the toolkit module,
        but do the same inline.
        
        (Assigning to AccessibleBrowseBoxBase::m_xFocusWindow
        after the AccessibleBrowseBoxBase base class ctor has
        been called looks a little odd to me as that one
        would add a focus listener for that window if
        already set/passed when called - but leave the
        logic unchanged for now.)
        
        With this, Library_acc no longer depends on the
        toolkit module, so drop the dependency from the
        make file.
        
        Change-Id: I8e7759c2d92a344bef51d154df0045c78f0471fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178435
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [26c2b0af00e9aa14f5973d5fae96e5fb38151705]

        a11y: Move VCLXAccessibleComponent from toolkit to vcl
        
        After
        
            commit 168512dce7f1f1453c045584d47bd78a0a6c73f7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 12 18:06:13 2024 +0100
        
                a11y: Stop using VCLXWindow in vcl a11y classes
        
        and further related commits, VCLXAccessibleComponent
        no longer depends on anything in the toolkit module,
        so move it from there to vcl.
        
        This way, subclassing VCLXAccessibleComponent (as the
        a11y classes for vcl widgets do, currently located in
        accessibility/ ) no longer introduces a toolkit
        dependency.
        
        Change-Id: I4fd33fb1dc2265d75e8ca9ad87bcc70db61639d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [007d1815a2fca1ddc5eabc29d08642049ab8966d]

        a11y: Drop unused toolkit includes
        
        Change-Id: Idc51576e05306cd45aec291e05b8b19a2cd2b2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178433
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [a3e4ee0aa6cc55ed50f792fcfecaedf8ae623b09]

        a11y: Drop always null BrowseBoxAccessibleElement focus win param
        
        Drop the `_xFocusWindow` param from the BrowseBoxAccessibleElement
        ctor. Both subclasses are unconditionally passing nullptr.
        Just unconditionally pass nullptr in the base class ctor instead
        of forwarding the (always nullptr) param.
        
        Change-Id: I9296ae8dae8ac53c52cec99e143288e70a586ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178432
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [7eefb8056311fe31be6b2a8af4f234e90b90e556]

        a11y: Drop always null AccessibleBrowseBoxHeaderCell focus win param
        
        Both callers of AccessibleFactory::createAccessibleCheckBoxCell
        (in SvHeaderTabListBox::CreateAccessibleColumnHeader)
        unconditionally pass nullptr for the `_xFocusWindow` param.
        Therefore, drop the parameter from that method and the
        AccessibleBrowseBoxHeaderCell ctor, and unconditionally
        pass nullptr to the base class ctor.
        
        This is basically the same as for AccessibleBrowseBoxTableCell in previous commit
        
            Change-Id: I22d5cb98332aa5d89fc4c479d0ec29588fe83e4d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 13 12:37:03 2024 +0100
        
                a11y: Drop always null AccessibleBrowseBoxTableCell focus win param
        
        Change-Id: Ife57d0163f1c99407e08875ba98725ea114597cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178418
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [fd50ed4aac52d5a83a417949e358edf6eb34b785]

        a11y: Drop always null AccessibleCheckBoxCell focus win param
        
        Both callers of AccessibleFactory::createAccessibleCheckBoxCell
        unconditionally pass nullptr for the `_xFocusWindow` param.
        Therefore, drop the parameter from that method and the
        AccessibleCheckBoxCell ctor, and unconditionally
        pass nullptr to the base class ctor.
        
        This is the same as for AccessibleBrowseBoxTableCell in previous commit
        
            Change-Id: I22d5cb98332aa5d89fc4c479d0ec29588fe83e4d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 13 12:37:03 2024 +0100
        
                a11y: Drop always null AccessibleBrowseBoxTableCell focus win param
        
        Change-Id: I76660aed909fc73ab19bc99a3e3bfb54176e7e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178417
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [aa2cad6d86d13fe4981e67095cdeabb9bae3a3d3]

        a11y: Drop always null AccessibleBrowseBoxTableCell focus win param
        
        Both callers of AccessibleFactory::createAccessibleBrowseBoxTableCell
        unconditionally pass nullptr for the `_xFocusWindow` param.
        Therefore, drop the parameter from that method and the
        AccessibleBrowseBoxTableCell ctor, and unconditionally
        pass nullptr to the base class ctor.
        
        Change-Id: I22d5cb98332aa5d89fc4c479d0ec29588fe83e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178416
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [6bc07b0717e8f610bf8b6f876546c2eac480de38]

        a11y: Use delegating ctor in AccessibleBrowseBoxBase
        
        ... and pass the Reference params by const ref, as
        suggested by loplugin:passparamsbyref.
        
        Change-Id: I7f0e153d901f451d47d6a9b94255dd41f89c7d0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178408
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [c126c209acd892188054d4a7cb5f21a7ecf7f88b]

        a11y: Drop unused includes
        
        Change-Id: I99d087f820cc8195de525889b8d766304ef18396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178407
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [3794ab35403073077990d076f32252303652d7f8]

        a11y: Report font slant (italic) in IDE editor with correct type
        
        Use the existing vcl::unohelper::ConvertFontSlant
        helper to convert the FontItalic enum value to the
        corresponding FontSlant instead of casting to an integer.
        
        The latter would trigger an assertion when trying to
        extract a FontSlant from the Any later, seen e.g.
        with the qt6 VCL plugin when navigating to the paragraphs
        in the "Tools" > "Macros" > "Edit Macros" dialog in Accerciser,
        or when moving navigating through the text while Orca is active.
        
        Backtrace:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7ffff789dc8c
            2 __pthread_kill_internal pthread_kill.c 78 0x7ffff789dcef
            3 __GI_raise raise.c 26 0x7ffff7849c42
            4 __GI_abort abort.c 79 0x7ffff78324f0
            5 ?? 0x7ffff74a1a3d
            6 ?? 0x7ffff74b300a
            7 std::terminate() 0x7ffff74a15e9
            8 __cxa_throw 0x7ffff74b3288
            9 o3tl::doAccess<com::sun::star::awt::FontSlant> any.hxx 284 0x7fffee23ea99
            10 ConvertUnoToIAccessible2TextAttributes AccessibleTextAttributeHelper.cxx 288 0x7fffee23bd8e
            11 AccessibleTextAttributeHelper::GetIAccessible2TextAttributes AccessibleTextAttributeHelper.cxx 347 0x7fffee23b45e
            12 QtAccessibleWidget::attributes QtAccessibleWidget.cxx 1001 0x7fffe4685866
            13 non-virtual thunk to QtAccessibleWidget::attributes(int, int *, int *) const 0x7fffe4685bca
            14 AtSpiAdaptor::getAttributes atspiadaptor.cpp 2329 0x7fffe2d15b79
            15 AtSpiAdaptor::textInterface atspiadaptor.cpp 1990 0x7fffe2d0c3ed
            16 AtSpiAdaptor::handleMessage atspiadaptor.cpp 1481 0x7fffe2d067f8
            17 QDBusConnectionPrivate::activateObject qdbusintegrator.cpp 1448 0x7fffe046d567
            18 QDBusActivateObjectEvent::placeMetaCall qdbusintegrator.cpp 1604 0x7fffe046e520
            19 QObject::event qobject.cpp 1432 0x7fffe3908d70
            20 QApplicationPrivate::notify_helper qapplication.cpp 3297 0x7fffe17e2d90
            21 QApplication::notify qapplication.cpp 3247 0x7fffe17e6cad
            22 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1122 0x7fffe3845c99
            23 QCoreApplication::sendEvent qcoreapplication.cpp 1564 0x7fffe3846a79
            24 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1920 0x7fffe38483b8
            25 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1751 0x7fffe38468bc
            26 postEventSourceDispatch qeventdispatcher_glib.cpp 246 0x7fffe3e39281
            27 ?? 0x7fffea10b81f
            28 ?? 0x7fffea10da57
            29 g_main_context_iteration 0x7fffea10e1c0
            30 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 399 0x7fffe3e3847b
            31 QPAEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 89 0x7fffe2f67218
            32 QtInstance::ImplYield QtInstance.cxx 464 0x7fffe472d3c2
            33 QtInstance::DoYield QtInstance.cxx 475 0x7fffe4730441
            34 ImplYield svapp.cxx 385 0x7fffeed3c9d6
            35 Application::Yield svapp.cxx 473 0x7fffeed3c36f
            36 Application::Execute svapp.cxx 360 0x7fffeed3c150
            37 desktop::Desktop::Main app.cxx 1679 0x7ffff7b2788b
            38 ImplSVMain svmain.cxx 228 0x7fffeed5e2a6
            39 SVMain svmain.cxx 246 0x7fffeed5fe99
            40 soffice_main sofficemain.cxx 121 0x7ffff7ba11ba
            41 sal_main main.c 51 0x555555555a6d
            42 main main.c 49 0x555555555a47
        
        Change-Id: Id30fc0acf20af5213c025a337765bb638ab6b02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178404
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [cd76d6caafa0fe20bed9df42f84d82cd857b20a8]

        a11y: Pass vcl::Window instead of VCLXWindow for TextWindow a11y
        
        As was done for the other a11y classes subclassing
        VCLXAccessibleComponent in
        
            commit 168512dce7f1f1453c045584d47bd78a0a6c73f7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 12 18:06:13 2024 +0100
        
                a11y: Stop using VCLXWindow in vcl a11y classes
        
        , also pass the vcl::Window when creating an
        XAccessibleContext for a TextView, to get rid of
        the UNO/toolkit dependency.
        
        Change-Id: I3c5febd27a53fe17f83cc4e95dd7466f11a7a225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178403
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [667823e412ac2b08d1a2f929e0347fc9ef54256c]

        a11y: Get text window doc accessible from Window on demand
        
        Instead of storing a reference to the VCLXWindow (which is
        a TextWindowPeer), which is the EditorWindow's accessible
        as Document::m_xAccessible member, adjust Document::getAccessible
        to get the accessible on demand via vcl::Window::GetAccessible
        instead.
        
        This also prepares for no more passing the VCLXWindow
        to the ctor in an upcoming commit.
        
        Change-Id: I498f90a456eda453508a4f1ed84983006594ea86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178402
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [71a9de600abb46e9f8bf61fd3c139dd895c60c28]

        crashtesting: assert on reimport of docx export of ooo102874-2.doc
        
         #0  SdrObjList::RemoveObjectFromContainer (this=0x1d12e30, nObjectPosition=3) at core/svx/source/svdraw/svdpage.cxx:1093
         #1  0x00007ffff15da0bd in SdrObjList::SetObjectOrdNum (this=0x1d12e30, nOldObjNum=3, nNewObjNum=2) at core/svx/source/svdraw/svdpage.cxx:536
         #2  0x00007ffff14c954c in SdrObject::ensureSortedImmediatelyAfter (this=0x4f56d30, rFirst=...) at core/svx/source/svdraw/svdobj.cxx:897
         #3  0x00007fffcdc4978c in SwTextBoxHelper::DoTextBoxZOrderCorrection (pShape=0x4c3a660, pObj=0x4c3d730) at core/sw/source/core/doc/textboxhelper.cxx:1638
         #4  0x00007fffcdc4bcbc in SwTextBoxHelper::changeAnchor (pShape=0x4c3a660, pObj=0x4c3d730) at core/sw/source/core/doc/textboxhelper.cxx:1247
         #5  0x00007fffcdc4e613 in SwTextBoxHelper::synchronizeGroupTextBoxProperty
             (pFunc=0x7fffcdc4bc10 <SwTextBoxHelper::changeAnchor(SwFrameFormat*, SdrObject*)>, pFormat=0x4c3a660, pObj=0x4c3d730)
             at core/sw/source/core/doc/textboxhelper.cxx:1652
         #6  0x00007fffcdd41a89 in SwDrawContact::Changed_ (this=0x4c55400, rObj=..., eType=SdrUserCallType::ChildMoveOnly, pOldBoundRect=0x7fffffff09d8)
             at core/sw/source/core/draw/dcontact.cxx:1250
         #7  0x00007fffcdd410a7 in SwDrawContact::Changed (this=0x4c55400, rObj=..., eType=SdrUserCallType::ChildMoveOnly, rOldBoundRect=...)
             at core/sw/source/core/draw/dcontact.cxx:1005
         #8  0x00007ffff14c7356 in SdrObject::SendUserCall (this=0x4c3d730, eUserCall=SdrUserCallType::MoveOnly, rBoundRect=...) at core/svx/source/svdraw/svdobj.cxx:2827
         #9  0x00007ffff14b11d8 in SdrObjCustomShape::Move (this=0x4c3d730, rSiz=Size = {...}) at core/svx/source/svdraw/svdoashp.cxx:1499
         #10 0x00007ffff152753b in SdrObjGroup::Move (this=0x1be18e0, rSiz=Size = {...}) at core/svx/source/svdraw/svdogrp.cxx:561
         #11 0x00007fffce8c80b8 in SwViewShellImp::NotifySizeChg
             (unique_ptrI7SdrMarkSt14default_deleteIS2_EESaIS5_EE11_M_allocateEm=<error reading variable: Unhandled DWARF expression opcode 0x0>, hrowE=<error reading variable: Unhandled DWARF expression opcode 0x0>) at core/sw/source/core/view/vdraw.cxx:274
         #12 0x00007fffce032bc1 in AdjustSizeChgNotify (pRoot=0x5e1c7f0) at core/sw/source/core/layout/pagechg.cxx:851
         #13 0x00007fffce03243f in SwRootFrame::CheckViewLayout (this=0x5e1c7f0, pViewOpt=0x0, pVisArea=0x0) at core/sw/source/core/layout/pagechg.cxx:2445
         #14 0x00007fffce032eec in SwPageFrame::Cut (this=0x5f19910) at core/sw/source/core/layout/pagechg.cxx:921
         #15 0x00007fffce037d40 in SwRootFrame::RemovePage (this=0x5e1c7f0, pDelRef=0x7fffffff13c0, eResult=SwRemoveResult::Prev)
             at core/sw/source/core/layout/pagechg.cxx:1518
         #16 0x00007fffce03808e in SwRootFrame::RemoveSuperfluous (this=0x5e1c7f0) at core/sw/source/core/layout/pagechg.cxx:1557
         #17 0x00007fffcdfe8d04 in SwLayAction::InternalAction (this=0x7fffffff1a30, pRenderContext=0x5211510) at core/sw/source/core/layout/layact.cxx:694
         #18 0x00007fffcdfe7cc6 in SwLayAction::Action (this=0x7fffffff1a30, pRenderContext=0x5211510) at core/sw/source/core/layout/layact.cxx:396
         #19 0x00007fffce8d5995 in SwViewShell::CalcLayout (this=0x521c540) at core/sw/source/core/view/viewsh.cxx:1197
         #20 0x00007fffcde1233f in SwEditShell::CalcLayout (this=0x521c540) at core/sw/source/core/edit/edws.cxx:111
        
        Change-Id: I66ffbbfc74e52eea2e24e486d52607e84ffb8fcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178415
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [7de706483eedb15188f8683194c4042034a12bad]

        Avoid a warning shown since bumping Windows baseline
        
        This is shown now, since commit b664c08a6d1096d279437c883e55735a0c431ac8
        (Drop support for Windows versions prior to Windows 10, 2024-12-07):
        
          Change your target platform to Windows 7 or below if your application
          requires backward compatibility for the ADO interface.
        
        Change-Id: Ic95a0819440b958cc3e01bbc2ffe91d7495bb8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178406
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-13  Justin Luth  <justin.luth@collabora.com>  [6edc10c6b0b8322db63230b3a71e393437cbb7ac]

        tdf#163033 sc: fix crash when copying comment to another ScDocument
        
        Fixes a crash that started with
        7.6.0.2 commit eec038b982b4672ac8feb030cb6bae546fa8c901
        
        The crash occurred when comments were copied (without cloning)
        to another document and then the source document was closed,
        removing access to the (uncloned) comment.
        
        Also took the opportunity to put the (minutely) most expensive
        comparison at the end of the if clause.
        
        Change-Id: Ia5c1313aa17550f760d5f870c566f06b7abd598b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178394
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-12-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9948c2ed03d227e178b9002dabc6edf34c32a5af]

        tdf#150789 - FILEOPEN PPTX: fix text in SmartArt vertically off
        
        Calculate correctly the textbox area of upArrowCallout and
        downArrowCallout shapes in group shapes. In grouped list
        text area does not cover the whole shape but just a part of it at the top.
        
        In case of upArrowCallout and downArrowCallout the arrow size of the shape
        is not included in the textbox area of the full shape.
        
        Change-Id: If732305747c20da55bbd2896522c0b9c05cc4b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178343
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-13  Noel Grandin  <noelgrandin@gmail.com>  [e7763739ae04193190a29e5127f047de2f5f35af]

        GetCountOrName returns a UI name
        
        But the caller in SwXStyleFamily::getByIndex was treating the
        return value like a programmatic name.
        
        Change-Id: I6b3779be834f713e09a026fdcbf965753a77cc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178381
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [dc79662a04780590f8ed3e2a6a111ce98dab8728]

        tdf#144694 In direct SQL dialog, activate options 'Run SQL command
        
        directly' and 'Show output of "select" statements' by default.
        
        Change-Id: I7708259ccbe8b81b6c0ef9d6bc10c5c2c9933194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178405
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-13  Ariel Darshan  <abdaandroid@gmail.com>  [d2080376b32c2523c877dd6ed7d18e9be0260551]

        tdf#163858 sd: Support autorepeating slides in windowed mode
        
        Change-Id: I6b1d78f234699062d6b846989e4d92bfa4b3d85d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176342
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [982342138ed01589e568ee7af3a2e61831d02d13]

        Inline 'submit', and allow separate 'wip'/'private'
        
        Now it's possible to run something like
        
          ./logerrit submit "" wip
        
        to auto-guess the branch, and make it WIP.
        
        Change-Id: I099a840ad39a1674c7dc5851c0a0c1d3976ee728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178401
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [236244b81ad58988341d66aea0018c2fa9c82a50]

        cid#1636690 Dereference after null check
        
        Change-Id: Ie32ffbe6148c2e12aa99068790fa7a1a1c0f27e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178399
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [3abe4b62e5937f7135384df7d93afe4ebab20342]

        Deduplicate a bit
        
        Change-Id: I5e0ec4adc79f81ff81d7cfe54e2f1a637b5d7f43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178397
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6002f2777ab9294c1d41ef64863480976f254e43]

        Replace workaround of resize to invalidate with an explicit SfxHint
        
        Change-Id: Ic0c8ba5e5f65f7b1e472a667b69e737f4f1d9fbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178389
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1ec7d9d904c1a0bb376278d6e1fce84d275d8af]

        Defer broadcast of postit field update from layout
        
        until oTextPara has been applied to the field's associated postit
        window.
        
        This became a noticeable problem since:
        
        commit 2fba6df7242586870988b62909156538b42c2bc0
        CommitDate: Thu Dec 5 15:31:06 2024 +0100
        
            LOK: don't recreate the dialogs of an old view when loading new views
        
        In the broken situation the contents of the postit are sent back to kit
        as apparently empty, so newly inserted comments appear to be empty.
        
        The broadcast bt of this scenario is:
        
         #0  sw::annotation::SwAnnotationWin::GetSimpleHtml (this=0x19f38790) at sw/source/uibase/docvw/AnnotationWin.cxx:516
         #1  0x00007f37d246283e in (anonymous namespace)::lcl_CommentNotification (pView=0x267cac40, nType=(anonymous namespace)::CommentNotificationType::Add,
             pItem=0x26baf4e0, nPostItId=0) at sw/source/uibase/docvw/PostItMgr.cxx:176
         #2  0x00007f37d2467fef in SwPostItMgr::LayoutPostIts (this=0x266d7160) at sw/source/uibase/docvw/PostItMgr.cxx:1084
         #3  0x00007f37d209dd1b in SwViewShell::VisPortChgd (this=0x267cce90, rRect=...) at sw/source/core/view/viewsh.cxx:1326
         #4  0x00007f37d119030d in SwCursorShell::VisPortChgd (this=0x267cce90, rRect=...) at sw/source/core/crsr/crsrsh.cxx:1788
         #5  0x00007f37d276478b in SwView::SetVisArea (this=0x267cac40, rRect=..., bUpdateScrollbar=true)
             at sw/source/uibase/uiview/viewport.cxx:249
         #6  0x00007f37d2764cc3 in SwView::SetVisArea (this=0x267cac40, rPt=..., bUpdateScrollbar=true)
             at sw/source/uibase/uiview/viewport.cxx:311
         #7  0x00007f37d2765e2e in SwView::Scroll (this=0x267cac40, rRect=..., nRangeX=65535, nRangeY=65535)
             at sw/source/uibase/uiview/viewport.cxx:495
         #8  0x00007f37d24d7708 in ScrollMDI (pVwSh=0x267cce90, rRect=..., nRangeX=65535, nRangeY=65535)
             at sw/source/uibase/docvw/edtwin3.cxx:41
         #9  0x00007f37d209a896 in SwViewShell::MakeVisible (this=0x267cce90, rRect=...) at sw/source/core/view/viewsh.cxx:665
         #10 0x00007f37d119a238 in SwCursorShell::MakeSelVisible (this=0x267cce90) at sw/source/core/crsr/crsrsh.cxx:3490
         #11 0x00007f37d1837671 in SwFEShell::MakeSelVisible (this=0x267cce90) at sw/source/core/frmedt/feshview.cxx:2677
         #12 0x00007f37d1192fcc in SwCursorShell::UpdateCursor (this=0x267cce90, eFlags=6, bIdleEnd=false)
             at sw/source/core/crsr/crsrsh.cxx:2345
         #13 0x00007f37d11886f9 in SwCursorShell::EndAction (this=0x267cce90, bIdleEnd=false) at sw/source/core/crsr/crsrsh.cxx:280
         #14 0x00007f37d178ed62 in SwEditShell::EndAllAction (this=0x267cce90) at sw/source/core/edit/edws.cxx:102
         #15 0x00007f37d2503daf in SwFieldMgr::InsertField (this=0x7fff88937c00, rData=...) at sw/source/uibase/fldui/fldmgr.cxx:1561
         #16 0x00007f37d292df75 in SwWrtShell::InsertPostIt (this=0x267cce90, rFieldMgr=..., rReq=...)
        
        while in the "working" case IsScrollMDI is false and MakeVisible returns early.
        
        2fba6df7 causes the profile's desire to restore core's SID_SIDEBAR to be
        ignored and so the results of IsScrollMDI differ between the two
        scenarios.
        
        Which makes it more likely that IsScrollMDI is true when queried by
        SwViewShell::MakeVisible, and so LayoutPostIts triggers before
        pPostIt->SetTextObject, so the contents of that TextObject, while
        applied to the postit, are not broadcast back via the kit.
        
        put a StartAction/EndAction pairing when oTextPara is present to
        suppress the update until oTextPara is applied.
        
        Change-Id: Id42ff1be85fec4b1053e5a7726cf6d2ba8d7de84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178326
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit c29a10b51db8027f90397d1bd9e31bd8a3571bc6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b9573b77f785d857be2b5d20fb8e5d20beeca3d]

        Hold vcl::Window by VclPtr
        
        suspicious that there is "delete pOLV" after retrieving a bare pointer,
        holdinf this by VclPtr looks sensible in any case.
        
        program/libmergedlo.so
        	OutputDevice::LogicToPixel(tools::Rectangle const&) const
        		/home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/outdev/map.cxx:906
        program/libmergedlo.so
        	vcl::Window::LogicToPixel(tools::Rectangle const&, MapMode const&) const
        		/home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/window/window3.cxx:158
        program/libmergedlo.so
        	SdrObjEditView::SdrEndTextEdit(bool)
        		/home/collabora/online-buildscripts/staging/builddir/libreoffice/svx/source/svdraw/svdedxv.cxx:1796
        program/../program/libsdlo.so
        	sd::View::SdrEndTextEdit(bool)
        		/home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/view/sdview.cxx:780
        program/../program/libsdlo.so
        	sd::FuText::MouseButtonDown(MouseEvent const&)
        		/home/collabora/online-buildscripts/staging/builddir/libreoffice/sd/source/ui/func/futext.cxx:290
        
        Change-Id: Ic9e8c8cf4256acfcb45daa4b9d72b0cb1cea635a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178359
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [33b2abf2cd31ef75b9d8a17e021489159b4cfa3c]

        sw a11y: clang-format SidebarWinAccessible code
        
        Change-Id: I623d7ce9520236dcca7322c808e89328c26cb70c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178387
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [12dd2f6b3c1b42e099f9ea599887346cd3516c99]

        sw a11y: Merge SidebarWinAccessible and SidebarWinAccessibleContext
        
        Instead of having two separate classes to implement
        the XAccessible and the XAccessibleContext interfaces,
        let SidebarWinAccessible implement both and
        merge the corresponding logic from SidebarWinAccessibleContext
        into SidebarWinAccessible.
        
        This also reduces duplication.
        
        In SidebarWinAccessible::getAccessibleContext,
        simply return a reference to the object itself
        (after checking that the object is still alive).
        
        After
        
            Change-Id: If0894e733273eecad268c6a932ecee7c2e34b4c2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 12 18:06:13 2024 +0100
        
                a11y: Stop using VCLXWindow in vcl a11y classes
        
        , there's also no more need for SidebarWinAccessible to
        subclass VCLXWindow, so drop that inheritance.
        
        Change-Id: I5688ced4f83a0291de49741dc1b9df8c8f256099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178386
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [168512dce7f1f1453c045584d47bd78a0a6c73f7]

        a11y: Stop using VCLXWindow in vcl a11y classes
        
        Adjust VCLXAccessibleComponent and subclasses to take
        a vcl::Window arg instead of a VCLXWindow in the ctor
        and drop the VCLXAccessibleComponent::m_xVCLXWindow member
        that used to hold a reference to the VCLXWindow.
        (VCLXAccessibleComponent still holds a VclPtr
        to the corresponding vcl::Window.)
        
        Instead of passing the UNO/toolkit peer (VCLXWindow
        and subclasses) to the AccessibleFactory to create
        an XAccessibleContext context for the underlying VCL
        widget, pass the underlying vcl widget, which can
        now be passed as is to the corresponding ctors
        of VCLXAccessibleComponent and specialized subclasses.
        
        This follows earlier commits replacing the use of the
        VCLXWindow classes by direct uses of the vcl::Window
        subclasses inside VCLXAccessibleComponent and subclasses
        and is the next step in reducing the UNO/toolkit
        dependency in the accessibility implementation for
        vcl widgets.
        
        For now, the logic where those accessible objects
        are created remains in VCLXWindow::CreateAccessibleContext
        and overrides, but that can change in the future.
        
        `IAccessibleFactory::createAccessibleContext(VCLXMultiLineEdit*)`
        is just dropped and doesn't need its own replacement:
        The previous VCLXMultiLineEdit variant was
        creating a VCLXAccessibleEdit like the variant
        taking a VCLXEdit, but VCLXMultiLineEdit doesn't
        subclass VCLXEdit.
        The vcl MultiLineEdit however subclasses Edit,
        so VCLXMultiLineEdit::CreateAccessibleContext can make
        use of `IAccessibleFactory::createAccessibleContext(Edit*)`
        as well now.
        
        This also implements what was mentioned in earlier
        commit
        
            Change-Id: I67bb7a6a237e57d0c522790c09a595c02ac06325
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 12 17:16:29 2024 +0100
        
                sw annotation win a11y: Skip VCLXWindow logic
        
        :
        
        > Drop the comment about the code being dodgy from
        > SwAnnotationWin::CreateAccessible. This commit partially
        > addresses it and switching VCLXAccessibleComponent
        > to using the vcl::Window will take care of the rest,
        > see upcoming commit
        > Change-Id If0894e733273eecad268c6a932ecee7c2e34b4c2
        > ("a11y: Stop using VCLXWindow in vcl a11y classes").
        
        Now that the VCLXAccessibleComponent ctor takes a
        vcl::Window, the sw::annotation::SwAnnotationWin
        can be passed directly.
        
        From a user perspective, no change in behavior is
        intended by this commit.
        
        Change-Id: If0894e733273eecad268c6a932ecee7c2e34b4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178385
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [5699b04a0cb64394c7951ec480b663402187fd85]

        sw annotation win a11y: Skip VCLXWindow logic
        
        Instead of overriding the base class VCLXWindow::CreateAccessibleContext
        which gets called by VCLXWindow::getAccessibleContext and
        results in the VCLXWindow base class also keeping a
        pointer to the XAccessible, override
        VCLXWindow::getAccessibleContext right away, and keep
        a reference to the SidebarWinAccessibleContext
        in SidebarWinAccessible itself.
        
        This simplifies the code, removes the need to cast
        the XAccessibleContext retrieved via the base class
        methods, and also prepares for making VCLXAccessibleComponent
        no more rely on the VCLXWindow, but using a vcl::Window
        directly in an upcoming commit.
        
        Drop the comment about the code being dodgy from
        SwAnnotationWin::CreateAccessible. This commit partially
        addresses it and switching VCLXAccessibleComponent
        to using the vcl::Window will take care of the rest,
        see upcoming commit
        Change-Id If0894e733273eecad268c6a932ecee7c2e34b4c2
        ("a11y: Stop using VCLXWindow in vcl a11y classes").
        
        Change-Id: I67bb7a6a237e57d0c522790c09a595c02ac06325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178384
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [e2cd6cd7cb4457b07471c52533b73b155aa98198]

        sw a11y: Pass the VCLXWindow to SidebarWinAccessibleContext ctor
        
        SwAnnotationWin::CreateAccessible returns the very
        object that is calling the SidebarWinAccessibleContext
        ctor.
        
        Make that more obvious by passing it as a param instead
        of calling SwAnnotationWin::CreateAccessible and then
        dynamic_casting that to a VCLXWindow.
        
        Change-Id: Id2ef80c7e5540276548c635cf550a552302b2fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178383
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [e9a6ed092df2a0bd761b2f459fc2179682666c90]

        sw a11y: Move SidebarWinAccessibleContext declaration to header
        
        This is in preparation of reworking the
        SidebarWinAccessible logic in upcoming commits.
        
        Change-Id: Ia1c9bf6a62d1cefb6147f82891361b0ced251263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178367
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [9486e163b6b563f5ddec6a56826e03ac16374d7b]

        a11y: Pass non-const ref to AccessibleListBox ctor
        
        ... and to the AccessibleIconView subclass one, too.
        
        This is in preparation of switching the base class VCLXAccessibleComponent
        ctor to taking a vcl::Window* instead of a VCLXWindow* in an
        upcoming commit.
        
        Change-Id: I10074f4c6716c2c7cb3b800c75bec8200ee6208c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178366
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [843a772dbbe6864045be421f8e45276645f1f16a]

        a11y: Pass non-const ref in AccessibleIconChoiceCtrl ctor
        
        Pass a non-const SvtIconChoiceCtrl& instead of a const one,
        in preparation of switching the base class VCLXAccessibleComponent
        ctor to taking a vcl::Window* instead of a VCLXWindow* in an
        upcoming commit.
        
        Change-Id: Ib2fd0efeb897c8f375309b00946a89dd2f8fd097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178365
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [dd8c7d034271b15a6bfa8f48338dbee268757e66]

        a11y: Rename VCLXAccessibleComponent::m_x{EventSource -> Window}
        
        Change-Id: I3724481e81a5f2987567b51424da479879ca78ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178364
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [add40b532e004048f17d3f3e3b9f63dcc039e938]

        toolkit a11y: Pass the XControl ref right away
        
        Instead of passing/using a Reference<XAccessible>
        and querying that one for the XControl interface
        in the OAccessibleControlContext ctor and in
        OAccessibleControlContext::implGetWindow, pass
        (and remember) the control via a Reference<XControl>
        right away.
        
        Change-Id: I0a9e15cda37bf42ff06f00ef3f49efacf2992043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178356
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [bbc2823f58aa2deab47be4951a43379d1228d251]

        a11y: Move OCommonAccessibleComponent::m_aCreator to subclass
        
        Move this member holding a weak reference to the XAccessible
        that created the context to the OAccessibleControlContext
        subclass, which is the only one making use of it now after
        previous commit
        
            Change-Id: I29fb7cd42512a02fc1cc56835bb83f847e9ec0fd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 12 11:08:54 2024 +0100
        
                tdf#164294 a11y: Don't rely on "creator" to determine child index
        
        This also removes the need to call OCommonAccessibleComponent::lateInit
        in those subclasses that did so previously.
        
        Change-Id: I3edd14810feb6c884b4e67db1f76b40ae003dffa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178355
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [6a68b96c6a449f3861cda5af8e77dbe15dcce5d6]

        tdf#164294 a11y: Don't rely on "creator" to determine child index
        
        In OCommonAccessibleComponent::getAccessibleIndexInParent,
        no longer rely on OCommonAccessibleComponent::m_aCreator
        to have been set to the "creator" (i.e. the XAccessible whose
        XAccessible::getAccessibleContext() created this object)
        in order to determine the index of the object in its parent.
        
        Instead, call XAccessible::getAccessibleContext on
        the parent's child XAccessible objects and compare
        that to `this`.
        
        At least for SvxPixelCtlAccessible (and most likely other
        child classes), OCommonAccessibleComponent::m_aCreator
        isn't set (by a call to OCommonAccessibleComponent::lateInit),
        so the logic would fail, and an incorrect index of -1
        was returned.
        
        Simplify the logic and no longer depend on
        OCommonAccessibleComponent::m_aCreator in that
        method. This also prepares for further decoupling
        VCLXAccessibleComponent from the VCLXWindow toolkit/UNO class.
        (The VCLXAccessibleComponent ctor currently calls
        OCommonAccessibleComponent::lateInit with its VCLXWindow,
        but overrides VCLXAccessibleComponent::getAccessibleIndexInParent
        without making use of the "creator" there.)
        
        Comments suggest that the previous logic was there to
        avoid calling XAccessible::getAccessibleContext for
        performance reasons.
        If that's a concern for a particular subclass, overriding
        OCommonAccessibleComponent::getAccessibleIndexInParent
        in that subclass (and making use of whatever internal
        details help to efficiently implement the method) seems
        like a better and more reliable solution to me.
        
        Change-Id: I29fb7cd42512a02fc1cc56835bb83f847e9ec0fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178354
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [7abcb501e14a4cd4159b17f8365bb86c9c8eb302]

        a11y: Merge OAccessibleControlContext::Init into ctor
        
        Instead of calling a default ctor without arguments
        and then calling OAccessibleControlContext::Init
        with the arguments directly afterwards, move
        the OAccessibleControlContext::Init logic into
        the ctor right away.
        
        There's no need for using such a "late ctor" as the
        comment calls it. (No virtual methods involved.)
        
        Change-Id: I815decd44ce94f242ea8c4814b33e2f73b39241f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178353
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2976e22f7a6740bb17933f67895ecbdbbe48cbd6]

        update credits
        
        Change-Id: Ic661fad279ad26f8aebc9ca1a2c8b271090e7d62

2024-12-12  Patrick Luby  <guibmacdev@gmail.com>  [94508506e7f6b9e53c77b631c5d7de1e06ff78d9]

        tdf#147067 Jump to clicked spot if left mouse click with Option key
        
        Most macOS applications such as TextEdit and Safari jump to the
        clicked spot if the Option key is pressed during a left mouse click.
        
        Change-Id: I56149e42daf1825cfebde8be8cfbb53645b31928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178369
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c243654727b26e3a29dfbc6daca477e04c48b71]

        cid#1636677 Uninitialized scalar field
        
        and
        
        cid#1636678 Uninitialized scalar field
        cid#1636679 Uninitialized scalar variable
        cid#1636680 Uninitialized scalar variable
        cid#1636681 Uninitialized scalar variable
        cid#1636682 Uninitialized scalar variable
        cid#1636683 Uninitialized scalar field
        
        Change-Id: I5f9c2cb0fae83b674d1f9f140ce4e8c91ef589f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178360
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [10a5c3162a7b0a6b5c6c5d1bb62808dfe870b49a]

        Include the org.libreoffice.embindtest infrastructure in all Emscripten builds
        
        ...not just --enable-dbgutil ones, which gives more flexibility in using that
        infrastructure downstream.  (The unotest/source/embindtest/embindtest.js code is
        still only included in desktop/Executable_soffice_bin.mk for --enable-dbgutil
        builds, though.)
        
        Building unotest/source/embindtest/embindtest.cxx also outside of
        --enable-dbgutil, and thus implicitly --enable-assert-always-abort, builds
        required moving from assert() to some hand-crafted verify().
        
        Change-Id: I3f0fa00feee25b4ea6e7866c22a5b4a4d40cb3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178361
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-12  Hubert Figuière  <hub@collabora.com>  [6fb8d0b7d696e0bc8e53ad5bcd8aee429e1294af]

        lok: getSlideShowInfo: return the slide names
        
        This allow finding slides by bookmark
        
        Change-Id: Ia951aebdd04b67f4138138f7c0e1404078cc23ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178345
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1cabb20fad8303d16e25957ee245970f37ad2f82]

        replace a couple manual calls to cygpath with PathFormat
        
        this fixes using the MSM merge modules in the wsl-as-helper case and
        avoids "cygpath not found" error lines when doing the compiler tests
        when running configure.
        
        Also capture and report the output of failed msidb calls in the
        isntaller code and simplify the path-mangling to windows-style
        
        Change-Id: I6877edda72959ab592e686d662b1344487e6313e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177966
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-12-12  Mike Kaganski  <mike.kaganski@collabora.com>  [02c7a9bec769aaa0256bfe4ed8f9a323732e83b6]

        Use correct object
        
        Fix an error in commit a1b18eba354dc773c214fc3b7ee92c3473ec4a5e
        (Implement Custom Font Collections on pre-Windows 10 systems, 2024-01-11),
        where the wrong object used in the call to CreateFontSetBuilder resulted
        in the empty return from the initializer, overwriting the just-created
        reference. Before commit 93350f4694ef8606150a95786c760bb2efd43979 (Drop
        pre-Win10 code from WinSkiaSalGraphicsImpl, 2024-12-07), it was checked,
        and the pre-Win10 path was used. After the said commit, it results in a
        nullptr dereference.
        
        Change-Id: Ia59f6ae6d236d1eb2c474f4330dcee6f38276c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178357
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-12  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [c1473de894b17f113fcb6c81f82592434e272a8c]

        sd: keep a non-owning pointer to the OverridingShell
        
        ... instead of keeping an owning shared_ptr
        
        To fix the ubsan build error
        <https://ci.libreoffice.org/job/lo_ubsan/3385/>
        
        Which appears to be caused from EventMultiplexer::CallListeners
        triggering a NotesPanelView to be deleted, and then notifying
        that just-deleted NotesPanelView, see
        <https://gerrit.libreoffice.org/c/core/+/177686/2#message-857c0180ae3e6572534d3bcd40f32000d434cc3d>
        
        Change-Id: I05e67dfeab093e7549e9b2ec4caf4a95dc743627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178348
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [ba767f634384c7dca5cb42364e51bc1a8dbd1835]

        a11y: Simplify OCommonAccessibleComponent::getAccessibleIndexInParent
        
        Just return the child index right away instead of assigning to a local
        variable first if the currently inspected child is the one.
        
        Change-Id: Ie5620498c34644fcf5523ce3eec6c71cb7486d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178325
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [e5065e23d9ecc27fa12207cc9e0fd00eea91188b]

        a11y: Flatten OCommonAccessibleComponent::getAccessibleIndexInParent
        
        Return early if `xParentContext` or `xCreator` are empty.
        
        Change-Id: I4b0aa1679658cf6dfb47c1c0bc21ca7a0d2e9c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178324
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [9d9a83acf2238aec2f33a51db2b4bf6086ec4d17]

        a11y: Drop OAccessibleControlContext_Base typedef
        
        Change-Id: I999bdea008b5aa5c98e099232bdf18b9e156c851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178323
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [c8a370c81f6dd0417b2bf5dbba574901571bcd3f]

        a11y: Return early in AccessibleFactory::createAccessibleContext
        
        ... if `pWindow` is null.
        
        (`git show --ignore-space-change` shows the
        "actual change" more clearly.)
        
        Change-Id: I39685d0a51ee9a5a280d302c940b2cdbc21c2b6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178322
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [51e416dbe4cc41c38573235d1a9598d2a34f44ad]

        a11y: Use vcl::Window in VCLXAccessibleComponent::grabFocus
        
        Directly call vcl::Window::GrabFocus instead of
        going via VCLXWindow::setFocus, which does the same.
        
        Change-Id: I2104c09e6b777c6c0deb2e04093cd48ce2aacc55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178306
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [eecf7db06b659c4d4d5ffb8240a7760bd89ae5c8]

        a11y: Simplify VCLXAccessibleComponent::GetWindow
        
        The ctor assigns
        
            m_xEventSource = pVCLXWindow->GetWindow();
        
        , so return that directly instead of querying it
        from the VCLXWindow again.
        
        Change-Id: Ifacdfb82e95b97c23c57d0cf9da46b77289ad227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178305
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [2e2fec9b0d8f39af8dbc8ba7d637629ba77ebfed]

        a11y: Use vcl::Window for VCLXAccessibleComponent validity check
        
        Instead of checking for VCLXWindow reference being non-empty,
        check whether the VclPtr<vcl::Window> ptr is non-empty.
        
        The latter should never be true unless the former is
        because VCLXAccessibleComponent::DisconnectEvents
        gets called before both possible calls to
        
            m_xVCLXWindow.clear();
        
        , and VCLXAccessibleComponent::DisconnectEvents
        clears VCLXAccessibleComponent::m_xEventSource.
        
        No change in behavior intended, but this further
        reduces the use of the toolkit/UNO VCLXWindow
        in favor of using the vcl::Window directly.
        
        While at it, also drop the references to
        tickets that don't provide any additional helpful
        information:
        
        "#122218#" is a reference to the StarDivision internal
        StarOffice bugtracker, which is unavailable
        
        "#i68079#" refers to [1], but also doesn't really
        explain whether/why that check is needed:
        
        From the initial description in that ticket:
        
        > This is a follow-up of the issue 43665...  We still have the patch in
        > ooo-build; it applies in IMPL_LINK( VCLXAccessibleComponent,
        > WindowChildEventListener, VclSimpleEvent*, pEvent ) (few lines below the
        > original problem).  Is it necessary (could it avoid a possible problem), or is
        > it just bogus, and not needed?
        
        Reply in comment 1:
        
        > I'm not aware of any known issue, but I think this patch makes sense in
        > order to avoid any potential problems. I will integrate this patch in
        > one of the next childworkspaces.
        
        [1] https://bz.apache.org/ooo/show_bug.cgi?id=68079
        
        Change-Id: I14118cb95db4859ddac57d9646531cdbe0f967f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178304
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-12  Szymon Kłos  <szymon.klos@collabora.com>  [e6f54da28699fcf4fbbe3a042c0906cb5623b9f4]

        jsdialog: add const
        
        Change-Id: If689daf52ca01904bc22c8f2e72f65247be2a3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178334
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [3bc1608758e37cba4eac8ca201e4464cd081fd07]

        curl: upgrade to 8.11.1
        
        Downloaded from https://curl.se/download/curl-8.11.1.tar.xz
        
        Change-Id: Id6ac29867e0f09daf239f8585c870181e606cd02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178337
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-11  Szymon Kłos  <szymon.klos@collabora.com>  [a5149eadb23825a9fb5beeda81836ad7940c3083]

        jsdialog: send message for weld::Menu
        
        - we need to setup correct notifier
        - enable context menu in the style sidebar in Writer
        - handle menu actions
        - base of vcl::Window and PopupMenu is VclReferenceBase
        - prepare template function sendMessage to handle both
        
        Change-Id: I54c8dc468856c0f98495bdaf4ddd504c2f56562f
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178319
        Tested-by: Jenkins

2024-12-11  Noel Grandin  <noelgrandin@gmail.com>  [f15c86221b41739a578c8a9b15046b20b43cb8c1]

        fix ruby style name handling in SwXStyle::SetPropertyValue
        
        code dates back to
          commit 023a58b5fbbf3b30692f4b66d5f5b07c28270934
          Author: Oliver Specht <os@openoffice.org>
          Date:   Mon Feb 19 07:04:57 2001 +0000
          ruby properties added
        Both the other places in sw/ that CharFormatName from
        SwFormatRuby expect it to be a UIName not a programmatic name.
        
        Change-Id: Ic02670f6c7ca7bacc6cd30cd48642f32eb9beb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178331
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-11  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [18632b1abe087ae95c3ce9d3392c265bb9ddeaab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 267fb2534f2d50eeb63cc98fdb6c4d3d1490cfb2
          - tdf#161917 Update option label to Highlight cell in edit mode
            
            Change-Id: Ic1e602a254e4d9e51183d9d68274059a1374d09c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178332
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-12-11  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f49441a66a862025dd3f3b22586f03d784e2a61e]

        tdf#161917 Rename Edit cell highlighting
        
        Change-Id: Id36fb6a0677392e2db76a8a3dd295b0acad12cdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178267
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-12-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [13516716fa294eda2d50d2267823500feac4420a]

        g: macOS' ln doesn't know --symbolic, only -s
        
        Change-Id: Idf0b276563a2552db7c6a9f2cca14b55acabb753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178316
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-12-11  Weblate  <noreply@documentfoundation.org>  [7565ca8f5c5e81200cee253ec48557fdd7c568ba]

        android-viewer translated using Weblate
        
        Tagalog currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I9aa790d8d71820122306ce10a013a1b445ea238b
        Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tl/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178320
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-12-11  Jonathan Clark  <jonathan@libreoffice.org>  [c697c36d4ef330b4cbf8c6bbeb4f893a3ea4c666]

        crashtesting: fix assert while parsing tdf94588-1.odt
        
        Some ODF parsing code uses relative indices into XMLPropertyMapEntry
        arrays to enumerate related attributes. This change moves some
        recently-added paragraph property entries to the end of the respective
        array, fixing an assertion caused by accessing unexpected attributes via
        these hard-coded relative indices.
        
        Problem since:
        
        commit 7e4f4a0ccd3c56093dec44c7dcdd14c8b34623c3
            tdf#163913 Implement font-relative margins
        
        Change-Id: Ia2671372f0152e4efb98bd25b390638e4458a1b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178318
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-11  Oliver Specht  <oliver.specht@cib.de>  [fdb13df0cb759e65e48bb65b1513e8add429d4d6]

        tdf#163634 Format empty paragraph if they have a bullet/numbering
        
        Some optimization in commit 52abeff6d5836b29dbefe69f284bbd89f6672ae2
        ignores paragph attributes if the paragraph is empty.
        But it is not empty if it has an active list.
        
        Change-Id: I8885d0f201fc48279263a3d41ec6d660b534ded2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178311
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-12-11  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [cc65bec38ca26265ce8ecfd02110c26bcc62b79b]

        tdf#161541 sd: fix the orientation of handouts on the printed page
        
        Change-Id: I1896674ab317fcbcfe2ebbe9ea21dcc36c203328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178274
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-11  Rashesh  <rashesh.padia@collabora.com>  [d0bd11f45b75065185a6730b8f101aa5c5e441ea]

        sw: lokit: make sure to read annotation html with utf-8
        
        - its online specific patch where the we pass html for annotation
        - to test:
          1. Open document in online
          2. Use "pt" keyboard to type comment "légend" and save
          3. Before: lÃ©gend; After: légend
        
        Change-Id: Ibd32fbd70c780938e8036362313067e8c1bc8f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178300
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-11  Miklos Vajna  <vmiklos@collabora.com>  [39f35f2ed2277931da36b6e3d2516c2355296fc9]

        Update pdfium to 6887
        
        CPWL_Dash-switch-to-universal-init.patch.1 is upstreamed, remove it.
        
        Change-Id: I4ff68f15d58b853896626b0458d3817f64fbc32f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178297
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-11  Hubert Figuière  <hub@collabora.com>  [e2a3e63bc42df4fbe346070a4b5621908170fc30]

        lok: impress: Fix variable name
        
        Was missed in https://gerrit.libreoffice.org/c/core/+/172847
        
        Change-Id: I8e5ece6be2253106df6b6e535afa5efaa86850a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178291
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-11  Michael Stahl  <michael.stahl@allotropia.de>  [bb7d9c47982aa83e8462fa82f470a3bb55eb2874]

        tdf#159549 sw: lcl_getUsedPageStyles() needs to use FillProgName()
        
        ... not FillUIName().
        
        Thanks to Noel Grandin for pointing out this mistake in commit
        0bc6fe5c1b889496fb83730545f9c8593ca65863
        
        Change-Id: I4b86ec7363b2a09d3e328b6d77772db63873795f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178301
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-11  Szymon Kłos  <szymon.klos@collabora.com>  [aa93771b041f96f11e1cf8a6948a6a458fee946c]

        jsdialog: move sender to separate file
        
        builder file is already very long, let's split that
        no functional change, just moved code to new file
        
        Change-Id: I12dcb8cbc8a17091282b557f459f07510a016af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178302
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-12-11  Szymon Kłos  <szymon.klos@collabora.com>  [a46586fc4dfd1dedab2a196e44a77a234bab40f2]

        jsdialog: use single constructor for builder
        
        - we mostly do the same thing for initial values
        - enum already have "subtypes"
        - let's do it in one switch
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I0f9280168569067fde1758e3577d564f5e63172c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178290
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a049c6ef426affe9ab347b4cec589919d687673e]

        Use SvtSecurityOptions::IsMacroDisabled() instead of officecfg check
        
        The change is most important for Viewer app mode, which also disables
        macros
        
        Change-Id: Ie305649dafbb3717e7986a4b437c38b09ffc1802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178275
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1c32970c0d9bbe6ba5778416b6d08c57bcffd3ea]

        Disable macros in Viewer Mode
        
        Prevents "This document contains macros" dialog on file open.
        
        Change-Id: I92cbd6b5f919ccfa5812b4a90ec72ad4378d009a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178273
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c876e6c4a5dd5fac61dd34f2605116377ab31c0d]

        These slots don't make sense even in read-only mode
        
        Thanks Miklos for spotting this!
        
        Change-Id: Ic4e85b2357f5cd98ce2932e50e8e84e8bcb25f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178261
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [bf77951004d49a0fc9b7d2bd36ce67b8f1902e47]

        Simplify the slot status check, and add some comments
        
        Change-Id: Ie2a77f0c5157a03a3461ae54d372382b1e57fe2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178238
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 4172ffad04f4a72d9865612530ae4d9117f1eb59)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178245
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [d799a66e07ac8d9a4f8162734d66930858b9411b]

        Check if the correct slot is active in SaveToolbarController::statusChanged
        
        Otherwise, the button may still be active, even with the slot disabled.
        
        Change-Id: Id292b69513a7de8248d33fa813a8b09964f30434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178124
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [5d25fc928846a0914954b71f52636f0232ac2618]

        Check if the slot is active in NewMenuController::fillPopupMenu
        
        Otherwise, the popup menu gets filled, even when the respective slot
        is disabled.
        
        Change-Id: I74ff3692500ca76e6e15bf3725dd295f0213403c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178002
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f3e81c95b148dbab5ce56764f5534b5e6de53204]

        tdf#62845: Introduce ViewerApp flag for slots, to hide in Viewer app mode
        
        Some slots make sense in read-only files, when the application runs in
        normal mode; but they make no sense in Viewer app mode. So this new flag
        is orthogonal to the existing ReadOnlyDoc flag.
        
        When it is FALSE, the respective command should not be active in the
        viewer mode. The default is TRUE.
        
        Change-Id: I5b5c75487fdf5a647aeab80129b6e84b42c00745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177965
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c49b966d54d004d1fcb9b94e8ca34a86759a85c7]

        Mark an svx slot as inactive in readonly mode
        
        Change-Id: I4e508c2492025bd7e39a1c67cc68016977843de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177964
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [62f5310fd1aa2cd6c2c2a63d69fb4a39ff7dfb93]

        Mark some Calc slots as inactive in readonly mode
        
        Change-Id: If1874a3d85b90e5671abdb026549ac913f990a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177963
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [531656832265eaad9ba7bf4a2bc9103bd9544be8]

        Mark some Writer slots as inactive in readonly mode
        
        Change-Id: Ic27b5558a835d1adaca5af52ae7ec5c81643a9e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177962
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [08f1b209c4843ff3c7f4281641ec644569f63d17]

        tdf#62845: Hide some sidebar panels in Viewer app mode
        
        These are confusing and cluttering the UI in this mode.
        
        Change-Id: I909f17f71846f5a7e82e43f078f32ed7b5daf159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177961
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [05b2a255a0726b79c34785b5a8b85437bbfe8394]

        Let StyleDispatcher take the state of StyleApply slot into account
        
        Before, it only listened to ParaStyle, or CharStyle, etc. obtained
        in MapFamilyToCommand; and that meant, that its actual command was
        ".uno:StyleApply?...", but StyleApply state was ignored. This meant
        that all respective items under "Style" menu were enabled in read-
        only mode, where StyleApply itself was inactive.
        
        Listen to both. When StyleApply is disabled, that takes priority.
        
        Change-Id: Ic087ba6fc6fe6d45b8c8ecc35494734cd8765bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177971
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [21bba18b26cb13c98c2c16a83c974170e4bd2873]

        tdf#62845: Introduce an application-wide viewer mode
        
        Using the new 'ViewerAppMode' expert setting, the UI should disable
        all the edit controls; all options to create new content (including
        new documents); i.e., work as a view-only application.
        
        This change:
        
        1. Introduces the setting.
        2. Checks it in SfxMedium::IsReadOnly, making sure that all documents
           always have read-only medium.
        3. Checks it in SfxFrameLoader_Impl::load, to prevent creation of new
           documents.
        4. Checks it in SfxObjectShell::isEditDocLocked, to prevent entering
           edit mode.
        5. Checks it in BackingWindow::checkInstalledModules, to hide buttons
           that create new documents.
        6. Checks it in SfxViewFrame methods, to avoid showing "readonly" and
           "macros" infobars.
        
        Change-Id: Iaeeb8aab16db83ebdf500fd2bca8b8a9ac2180ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-11  Michael Stahl  <michael.stahl@allotropia.de>  [d821cc66d98b60e5408cbab77ebdbc33cc63b6f5]

        tdf#159549 sw: try to fix style mapping for Table Styles
        
        Fix the SwStyleNameMapper mapping for all families except TabStyle
        because testTdf129568ui fails; commit
        7d08664be4d9a949718ce66e3bc974105a10284c "tdf#129568 Rename the default
        table style" indicates that earlier LO versions wrote UIName into
        table:template-name attributes which is quite tragic and prevents fixing
        this case.
        
        Rename SwXTextCellStyle::m_sParentStyle to m_sTableStyleUIName
        
        Actual changes to name conversion in SwXStyleFamily::insertByName(),
        SwXStyleFamily::replaceByName(), SwXStyleFamily::removeByName(),
        SwXTextTableStyle::setName(), SwXTextCellStyle::isInUse()
        
        Change-Id: I886d1196f0a4e93b0770d2859beddd9424a79430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177860
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [059e695005b7eb500058f8c1c6cf83eb92dad20b]

        cid#1606642 Data race condition
        
        Change-Id: I7b36a4632981a548c04b2bc31decc9be98200c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178284
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ab314514f9cc422c6018ec3b387c730afa1de817]

        cid#1636673 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifd97a8f5578552266354861eb4a59f3e09fc57da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178285
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f19b16d5d1ee9d7ce8797fed3ad7d0904d31a91c]

        cid#1607842 Overflowed constant
        
        Change-Id: I4768cf58a14c0664257b74160d0c09497efec574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178075
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ce688c1a24cd3755bbddfaf6b610a86cb3516d79]

        cid#1636674 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557211 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idf6e060a75abd2d7cb231318ea924e2c02ddfc04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178283
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5e52e182f697534473231426a731966ca2571650]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e01a338bc36c94309a4bfb4e609651f3546d1c9f
          - Fix typo
            
            Change-Id: I06f47ab3e8d6d9a1e4755964f6e577de08b4ce86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178263
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c1cdfd90a0e5df66896810d114a8ef19af3d8c5]

        Fix typo
        
        Change-Id: Ie54afd58ea1921f3c5ed6d4175efef06b701b93d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178264
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3fcbf5947a456d80993c554089368ecdcbe18be5]

        Fix typo
        
        Change-Id: I59ca8b57bd8e1fd11a719a63a9fd5cf095d772a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178265
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7ace7f13987a17980af7bd0d04f230123c7da2c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0bd879bf7c5df309d24c96789e1f73add311b0ff
          - Fix typo
            
            Change-Id: I66c69b40313d0ee2a1cce2a02eab69a533794183
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178262
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [40b6e282aacf5a641c0b0cbd6183aee43e28a463]

        Fix build
        
         C:\lo\core\vcl\inc\jsdialog/jsdialogmessages.hxx(85): error C2039: 'mutex':
         is not a member of 'std'
        
        Change-Id: I5d43e415cef5b16a4b71d3772e3f40e8135cdfab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178272
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [b211e848e21b1bf6df23d8f877a3d09e09535e41]

        tdf#130857 qt weld: Support dialog to choose UI variant
        
        Declare support for the "View" -> "User Interface"
        dialog that allows to choose a UI variant.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Currently, there's some black background behind
        the images displaying the different UI variants,
        which is presumably due to alpha not being handled
        the way it should somewhere, This should be further
        investigated at some point, but I don't consider
        it blocking at the moment since the native Qt
        dialogs are not used by default.
        (Letting QtInstanceWidget::create_virtual_device
        create a virtual device with a separate alpha
        channel as SalInstanceWidget::create_virtual_device
        does would result in the background being white
        instead of black, as it is for the non-welded
        dialog with qt6.)
        
        Change-Id: I198750a27e13476b59569bda60949e286b567c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178254
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [56fb85cf0a5b01aa03c3f60e288e3e8d2971308a]

        tdf#130857 qt weld: Implement QtInstanceImage::set_image(VirtualDevice*)
        
        In addition, make sure that all of the QtInstanceImage::set_image
        variants are run in the main thread.
        
        Change-Id: I6808239480a02306de46a9dd4734477c905f666b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178253
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [70503aed6a786aa3958c6f6b33ea92bd32e50bb8]

        tdf#130857 qt weld: Implement QtInstanceWidget::create_virtual_device
        
        Do the same as GtkInstanceWidget::create_virtual_device
        and don't use a separate alpha channel.
        
        Change-Id: Ie69024ee317f68dd927752b57b8a0b8d2840aede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178252
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [6ae8fd04fd9b849b509ced8ff5aa8af8b8260af2]

        tdf#130857 qt weld: Handle GtkViewPort child
        
        The GtkViewPort doc [1] says:
        
        > The GtkViewport widget acts as an adaptor class, implementing
        > scrollability for child widgets that lack their own scrolling
        > capabilities. Use GtkViewport to scroll child widgets such as GtkGrid,
        > GtkBox, and so on.
        
        For QScrollArea (which is created for "GtkScrolledWindow"
        objects in .ui files), no special adaptor class is needed.
        
        Therefore, just create a simple QWidget for "GtkViewport".
        
        In theory, that widget could even be removed from the
        hierarchy again later (e.g. in QtBuilder::tweakInsertedChild)
        if there's a reason to.
        
        [1] https://docs.gtk.org/gtk3/class.Viewport.html
        
        Change-Id: I4d4f5164e73c8077aa4c5c65c080ee9d0e4676d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178251
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Michael Stahl  <michael.stahl@allotropia.de>  [7aae0e71a408b2c9aae4fb1135ec71a4f10ed2df]

        tdf#159549 sw: fix FN_UNO_PARA_STYLE in unotbl.cxx
        
        SwXTextTableCursor::getPropertyValue() and
        SwXCellRange::getPropertyValue() were erroneously returning UINames.
        
        Thanks to Noel Grandin for pointing these out.
        
        Change-Id: I232b86512cac1adf9c00ac00bf8afaf3ccfeb3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178258
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [cd80b3cebca54f166c56501cd563397aee219ad1]

        tdf#164102 - Start Center: adjust first item only if there are pinned items
        
        Change-Id: I7c80efde04f037234a54ba0d063acd6bf48a903c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178206
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [85e17c7ff9c8af34847a1d26f234a06f1aff2af2]

        a11y: Directly use vcl ScrollBar in VCLXAccessibleScrollBar
        
        ... instead of using the toolkit/UNO wrapper class
        VCLXScrollBar.
        
        WIP: simplify
        
        Change-Id: I9df8efb514d2bcf555bd163a7fe418c5c8d9e903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178241
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [6f6e920a294a20c48c5ff59ba13433b91fa84ae1]

        a11y: Extract a VCLXAccessibleScrollBar::GetOrientationState helper
        
        See also VCLXScrollBar::getOrientation which uses the
        same logic and was called earlier. This is in preparation
        of using the vcl ScrollBar directly instead of depending
        on its VCLXScrollbar toolkit/UNO peer.
        
        Change-Id: Ie2a1a104c69d56036890e995fc97849d5acc137a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178240
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [26cdc1f5a964417089c966f521b123c3f2cb3286]

        a11y: Directly use vcl RadioButton in VCLXAccessibleRadioButton
        
        ... instead of using the toolkit/UNO wrapper class
        VCLXRadioButton.
        
        While at it, also switch the single use of
        VCLXAccessibleComponent::GetAsDynamic to
        VCLXAccessibleComponent::GetAs, too, as
        the control is known to be a RadioButton.
        
        Change-Id: I9d26e0ca165c8df16095a3bc460907567c04ccd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178239
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8a1da033c7e1f6c23b502b8f86de1e6e101a57eb]

        tdf#164039: Improve tip of the day (II)
        
        Change-Id: I200173f7a7572ac170a2c0fc390d552a28ca016d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178249
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9573460c98ba3f10de7b5b42202056ce3962031c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5629180ff0a8e16137e308b00f9674858473b744
          - Fix localization in bookmark
            
            Change-Id: I17fb59061e3b4b0ee6e9ac14f6ddce3539ff0010
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178256
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-10  Oliver Specht  <oliver.specht@cib.de>  [5fb8e29926a5c0dd1ae027f05d48826399cc31a1]

        tdf#164065 load vml textbox in a group shape
        
        Store (vml) textbox elements to determine whether to load shape text or
        Writer frame. Replay elements in second step and process depending
        on the outcome.
        - result flag not yet available while processing
        - The text shape in docx bugdoc of tdf#152878 can now be loaded as Writer frame
        but with wrong size/position.
        - should also be applied to drawing ml shapes currently always loaded as Writer
        frame
        
        Change-Id: I0778057f9985f5523d91a9d757e00f2968aba350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174902
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-12-10  Szymon Kłos  <szymon.klos@collabora.com>  [9877694e27f7e52ab8ac69c3729677cd8090e41f]

        jsdialog: move message related classes to separate header
        
        no functional change - just make files shorter
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ice8ccedc235c81f26cbe6e753785bb3e0d960324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178208
        Tested-by: Jenkins

2024-12-10  Michael Stahl  <michael.stahl@allotropia.de>  [f32ee6801ad7e268224a1da918517a3577e8a582]

        tdf#159549 sw: rename SwXStyle variables to make it more obvious
        
        There are only 2 actual changes in behaviour, in SwXStyle::getName() and
        SwXStyle::setName(): these now convert the name, but in practice it
        should not make any difference, because it looks like any attempt to set
        the name of a built-in style, or set a style's name to the name of a
        built-in style, will eventually throw an exception without changing the
        document model.
        
        Change-Id: If11fba2797e28b10c98c383c5d130f19ce0c77b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178209
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-10  Michael Stahl  <michael.stahl@allotropia.de>  [44878a26e0d934a80ab39d5bf597ca49e46db86e]

        tdf#159549 sw: fix style mapping for Character Styles
        
        Change-Id: If6a130f21bfb29fe834c7004788183849f39f51e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178172
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-10  Michael Stahl  <michael.stahl@allotropia.de>  [0bc6fe5c1b889496fb83730545f9c8593ca65863]

        tdf#159549 sw: fix style mapping for Page Styles
        
        lcl_getUsedPageStyles() needs to convert the style names.
        
        Lots of tests request the UIName, testTdf87533_bidi even checks the same
        style twice with different names.
        
        Change-Id: Id173493daffadd0d0a74e089ecba8f19d2b267c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177859
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [a7a12bdb5d98244929ceb2cbb626027494975510]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to faec730e559a925e7b48132a91f3b0faa1775953
          - Precision in ScriptForge.Session.RunApplication() method
            
            Change-Id: Iade10670dedb638dd36e1b32529b856b44676afe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178144
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Tested-by: Jenkins
            
2024-12-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [993a6f5ee74c64d3f727ddd10339aa9278f5093b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 811ee5d92e702abd73cb555f979f1d54a19a2389
          - Python typing hints are available for Scriptforge services
            
            Change-Id: I0e5bcd7f39d4de7913080648cb6770e83253207c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178131
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-12-10  Miklos Vajna  <vmiklos@collabora.com>  [904b956622b1581517c938ed8dacac70f7c6242c]

        pdfium: mark part of build.patch.1 as upstreamed
        
        So it'll be easier to drop it the next time pdfium is updated.
        
        Change-Id: Iebeb892f62ee8002460142adf28f75666c92c2e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178237
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [859eb9522c85ced69e2aea01e30eb3d39664fbcd]

        Update git submodules
        
        * Update translations from branch 'master'
          to aea4df31b2132b52671a6de84abd7b41e612db17
          - update translations for master/25-2
            
            and force-fix errors using pocheck
            
            Change-Id: Ic9518a3b67ec6de430ab12459a584c55c9f896b3
            
2024-12-10  Adesola Samuel  <adesolasamuel2022@outlook.com>  [62fbc583a7a04c69631d84177f26f51a5aad16d9]

        tdf#150839 a11y added page layout view under View Option
        
        An option "Layout of pages" is added to the view option
        which allows user to select any of the three page layout:
        1) Single Page per Row 2) Multiple Pages per Row 3) Book View
        view for ease of accessibility.
        
        Change-Id: I8dcab9b78deee15fb68cf313dab6eff40025f5a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176367
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [46ce77dfffaa6445ed05e1400284f4f9491b9faf]

        ReqIF: avoid 'target' attribute in 'a' elements
        
        Change-Id: Iab34a18e2da766d30a2d6b5f5d8ed3855f3c8b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178207
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-10  Szymon Kłos  <szymon.klos@collabora.com>  [21b1e5b6bcc9bc7e549db4555fdb6e21a73f5a32]

        lok: calc: fix assertion on toggle autofilter
        
        Steps to reproduce:
            Open attached spreadsheet
            type "date" in D1
            type any date eg. 2020-02-02 in D2
            Select all data visible ~ A1:D7
            Insert -> Autofilter
        
        result: crash
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I53e794d644120c6a2a67453727f1206aa47aa9b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175837
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178204
        Tested-by: Jenkins

2024-12-10  Szymon Kłos  <szymon.klos@collabora.com>  [969f242f2e63deef3609809dbc2d70eeb40d81f4]

        jsdialog: share code for widget registry
        
        - move all helpers for widgets registration into
          separate file
        - share code for Widgets, Menu and Popup register
        
        Change-Id: I3449721d7e436ff4459edb7990c1af860b78054f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178205
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-12-10  Christopher Sherlock  <chris.sherlock79@gmail.com>  [3faa61452a67bca97d223ee59748ac7b469cdd48]

        vcl: flatten vcl_component_getFactory()
        
        Change-Id: I411c75ad491e5d755710bc6a4d38446e170abc47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178159
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Manish  <mbera.dev05@gmail.com>  [28c526bc88dad00c74fba969fd76032ac94801fe]

        tdf#163738 use insert function instead of for loop
        
        Change-Id: I8e2d361459ed0db3bea28a0df9550d298145110b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178158
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-10  Pranam Lashkari  <lpranam@collabora.com>  [161cd3c3a2bc1d9d1b3d65de45aad1200bb4fd8e]

        lok: use locale units in dialogs and sidebar
        
        this patch updates fix for the dialog which were not fixed by e2708fecb34fb4084f8db5f2c5ffb4d8923002ca
        
        Change-Id: I7a9531d5af5b388cd6d763ea8c8d62ff4e7f12ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177896
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178203
        Tested-by: Jenkins

2024-12-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6ea738e7f4ffa7d9452c65df48550842f711c6c4]

        [API CHANGE] remove LOKSlideRenderer implementation
        
        SlideshowLayerRenderer has replaced it so it's not used anymore
        and we don't need it anymore to compare the output too.
        
        Change-Id: Ic1277d650324937722ec69a91218f23f147d0bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178199
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6eaf4d7451e37e985b9d50701e6cdbfc97308a0c]

        Silence -Werror,-Wunused-private-field
        
        ...in DBG_UTIL-only code introduced in 2e1f9da8a6359c8909e087a92239aefd4851b116
        "Decouple ScPatternAttr from SfxItemPool", which only started to generate a
        warning now with Clang 20 trunk, presumably since
        <https://github.com/llvm/llvm-project/commit/d457100a8152cc2ebf8cd219caae92cc0f591156>
        "[Clang] Fix -Wunused-private-field false negative with defaulted comparison
        operators (#116871)" (and only warns about m_nSerialNumber, which is only
        written to in the ctor, but not about m_bDeleted, which is also written to in
        the dtor, even though neither of them appears to ever be read)
        
        Change-Id: Id7fb1cc1e082464d4c5b935bdd194edf92704505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178202
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-12-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [330eefb2b9aa29f2fcf5c7bb8005d2889c8190de]

        -Werror,-Wunused-private-field
        
        Seemingly unused ever since the code was introduced in
        1dd7cc9446233f047ace02f4275ef6405587b9c9 "tdf#116091: Replaced 'AutoFormat'
        Button in Convert Text to Table dialog", but only reported by Clang 20 trunk
        now, presumably since
        <https://github.com/llvm/llvm-project/commit/d457100a8152cc2ebf8cd219caae92cc0f591156>
        "[Clang] Fix -Wunused-private-field false negative with defaulted comparison
        operators (#116871)".
        
        Change-Id: I90fbd5be737b625f83283e8fbbb4d64d490d8fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178201
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e03a50fb6443fa7da4209ebb981f1c1329aba966]

        tdf#164039: Improve tip of the day
        
        Change-Id: I4b40e012c557a08c61b7b383c4c57fc615d71c04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177298
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-12-10  Noel Grandin  <noelgrandin@gmail.com>  [a33b6d57d04bc011cd0a8d44023efe1639915b09]

        fix bug in use of SwStyleNameMapper::GetUIName
        
        introduced in
        ca435be45f316120b9df6c9d547b781ed975817d
        "writer: handle styles in multiple languages for online"
        
        and sprinkle some [[nodiscard]] around to prevent future such
        issues
        
        Change-Id: Ie12a7966a4de93c9ad05fef01fd2ff606f9dde6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178087
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [90d9b6e12f0aa9a569958586832bd4abe9561197]

        tdf#164072 vcl: Let MenuButton dispose its PopupMenu
        
        The MenuButton usually owns the PopupMenu that
        gets set via MenuButton::SetPopupMenu, but so far
        didn't dispose it, i.e. the PopupMenu was never
        disposed.
        
        As far as I understand, that is a preexisting issue,
        but since
        
            commit 6708246e20ce522e673f539369cd38687d2dd16d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 11:06:48 2024 +0000
        
                tdf#164093 tdf#157001 a11y: Improve menu window disposal
        
        , not disposing the menu also means not disposing the
        menu's MenuFloatingWindow (which gets created when the
        popup menu shows), resulting in
        
            warn:legacy.osl:563630:563630:vcl/source/window/window.cxx:307: Window ( 10MenuButton()) with live SystemWindows destroyed:  18MenuFloatingWindow()
            Window ( 10MenuButton()) with live SystemWindows destroyed:  18MenuFloatingWindow()
        
        and an assert getting triggered as mentioned in
        tdf#164072 comment 16.
        
        Fix this by letting the MenuButton take care of
        disposing the menu if it is the owner.
        
        The only case where the MenuButton is assigned a menu
        without taking ownership is in
        SalInstanceComboBox::set_item_menu (which currently only
        gets called from SvxStyleBox_Base::SetupEntry).
        In that case, the weld::Menu passed to
        SalInstanceComboBox::set_item_menu has the ownership:
        SalInstanceBuilder::weld_menu calls the
        SalInstanceMenu ctor with a bTakeOwnership=true,
        and the SalInstanceMenu dtor disposes the menu.
        
        Add a `bTakeOwnership` bool param to MenuButton::SetPopupMenu
        to distinguish between the cases where the PopupMenu
        is responsible for disposing the menu and where it's not.
        
        Change-Id: I32766d5084e4826056ef394a587b8c2e3124c4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178197
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [06bc2dfc23da1b8ae6fe690b6d8e3557b7419f1e]

        tdf#130857 qt weld: Implement some QtInstanceIconView methods
        
        Just enough to make Writer's "Insert" -> "Fontwork"
        dialog generally work in a WIP branch where support for
        that dialog is declared.
        
        Change-Id: I4610db085b1e1ca57f63e86012373b2890454447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178180
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [995866ebfce1e219fe78805eea88bd4ea94cb835]

        tdf#130857 qt weld: Add QtInstanceIconView skeleton
        
        Most of the logic still needs to be implemented.
        
        Change-Id: I2b6a684f36a6aadcba527c0aaf8a9a29702e37c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178178
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [8a6f6fef87336a2777c0c21053e10b30783bd686]

        tdf#130857 qt weld: Implement QtInstanceTreeView::make{un,}sorted
        
        Change-Id: Iffdf85e19eacbba2ee5bec22e7c0de6d0c90303b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178177
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-10  Justin Luth  <justin.luth@collabora.com>  [a366cd34a85a21210939482d229d6d2dd9c1087c]

        tdf#125969 cui: add in-use area image to bitmap list
        
        This fixes a five year old (non-)easyhack with 3 duplicates.
        Note the nice-to-have dependencies in the bug report(s).
        
        When the document has a unique background (area) image,
        it is now added to the list of available images
        IF/WHEN the user looks in the area tab.
        This allows the user to switch back after changing,
        or re-use it in other places in the document.
        
        Most of this patch ended up being plumbing to ensure that
        this added image is ONLY available to the current document,
        because it MUST NOT be saved to the user profile.
        
        This change affects all apps and all types of areas: NICE
          -tested Writer pages, paragraphs, headers, textbox, sidebar(page)
          -tested Calc page style
          -tested Draw page, sidebar(page), textbox
        
        Caveats:
        -the bitmap list is NOT updated at the time of document import,
         only when area property inspected.
         (The bug requesting inclusion at the time of import is tdf#100832).
        
        make -srj1 UITest_writer_tests8 \
            UITEST_TEST_NAME=tdf125969.tdf125969.test_tdf125969 \
            SAL_USE_VCLPLUGIN=gen
        
        Change-Id: Ic9fea9b199602c4df1376e781d5df019526473d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176253
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-12-10  Justin Luth  <justin.luth@collabora.com>  [d97085cc6cd2bdc3b6723d1960d0ec5fa0a48165]

        tdf#164201 docx import: compat14+ cannot be ECMA_376_1ST_EDITION
        
        This fixes a 7.6 regression
        from commit e66ddcd4b66923bc835bd7c5f5c784a809a420a2.
        
        At import, the base filter was treating too many documents
        as if they were limited to Word 2007 format,
        and thus reducing their compatibilityMode to 12 on export.
        
        This import case is matched in a LOT of unit tests.
        However, it doesn't manifest itself in
            saveAndReload(mpFilter) (or DECLARE_OOXMLEXPORT_TEST)
        because the mpFilter string set in the Test class with
            SwModelTestBase(..."ooxmlexport/data/", "Office Open XML Text"),
        forces saving in ISOIEC_29500_2008 mode
        and thus unit tests basically NEVER round-trip as "MS Word 2007 XML".
        
        However, the general user was almost always round-tripping
        these as MS Word 2007 XML / compat12 since LO 7.6.
        
        make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf158855
        
        Change-Id: If635866cc816e7b4734443f87b30410ac3bba951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178048
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-09  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [50a8b8e6e47d804358ba6cbf497a0d34ce4782b0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 22c587639a5c06e9a61a390b4ea18da0cb0c0b68
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: Idf08d44bb5287da44b281820e73e08c58e154f99
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178163
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-09  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a80b04058084826f28cfe58a66a96116383b1146]

        tdf#161915 Wrong extended tip
        
        Change-Id: I3c7be8f877f6ae0a505d6ec9a8bd786a0bd76745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177902
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-12-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3dd137c50f94f2b0ae602eb7ed66827cf0d9af9d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 635f1dc3de1c1af8b6a99205d2237c0650084bea
          - tdf#155193 No indexing when indexer="excluded" in <topic>
            
            Use omindex property of HTML indexing. See
            
            https://xapian.org/docs/omega/overview.html
            
            Change-Id: I9737d0111860da875e09f27814adf7b14104919b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178156
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-09  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [45aca23c11bb37b7e7c9fe33019c2fa5f4e64f81]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1e72401e01866e317fa763f914d15ea9a277372
          - tdf#156317 Explain: Use superordinate object settings
            
            Change-Id: I24f55c9a28acb53d1f9af431e0d215a4a18d8637
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178059
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-09  Dione Maddern  <dionemaddern@gmail.com>  [adf11923692b5baf3750a6c5c5d3043772a68338]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f723cce6039b88b82380fbc8ebe9a2e18eaf3fd4
          - tdf#162504 Create help page for Alignment Sidebar panel
            
            Create new file source/text/scalc/01/sidebar_alignment.xhp to explain
            the features of the Alignment panel of the Properties sidebar.
            
            In AllLangHelp_scalc.mk
            - Add new file source/text/scalc/01/sidebar_alignment.xhp to the make
            file
            - Change the file path for
            source/text/scalc/01/sidebar_number_format.xhp to show amended file
            location.
            
            In source/text/shared/01/05020700.xhp
            - Add variable tag so that the file can easily be linked from other help
            pages.
            
            In source/text/shared/01/05100100.xhp
            - Add section tags so that content can be easily embedded in other
            pages.
            
            In source/text/shared/01/05340300.xhp
            - Add section and variable tags so that content can be easily embedded
            in other pages.
            - Reformat the "reference_edge" section so that each option has its own
            heading. This improves readability and consistency and allows the same
            content to be re-used in the help page for the Alignment Sidebar panel.
            
            In source/text/shared/01/LeftToRight.xhp
            - Add section tags so that content can be easily embedded in other
            pages.
            
            In source/text/shared/01/RightToLeft.xhp
            - Add section tags so that content can be easily embedded in other
            pages.
            
            In source/text/scalc/sidebar_number_format.xhp
            - Moved file to source/text/scalc/01/sidebar_number_format.xhp
            
            In source/text/shared/01/sidebar_properties.xhp
            - Embed description of Alignment sidebar panel
            - Update file path for source/text/scalc/01/sidebar_number_format.xhp
            - Add loc_false tags for embedded variables
            
            Change-Id: Id9c232c18bab1cfab99eec83e796f8db25681898
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177707
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b012d206350f57bf4268d8cd8528c32647c6b933]

        cid#1636669 Dereference after null check
        
        Change-Id: I56e9669058a79750f83bb99e682e25c3fea2a0bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178170
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-09  Eike Rathke  <erack@redhat.com>  [47b4b1633a08dd4c97d66feabe8cd3290074dc0f]

        Resolves: tdf#164239 Can force Y-M-D to ISO 8601 if no date acceptance pattern
        
        ... was matched at all, even for a-b-c with MDY a<=12 or DMY a<=31.
        
        Change-Id: Ie2d62c73c91794a96114b787d6ad2357c7affb2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178171
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-12-09  Manish  <mbera.dev05@gmail.com>  [8f7294223a654e0ca13f94cbc906e5c333e28308]

        tdf#145538: Use range based for loops
        
        Change-Id: I8b41b96775fdd26464122e47ec853b48bdd921d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178150
        Reviewed-by: Skyler Grey <skyler.grey@collabora.com>
        Tested-by: Jenkins

2024-12-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9f5040abbfdb6057fc2455cd6726398dc8ba7b9b]

        tdf#61358 - Remember the last "insert as link" state
        
        Change-Id: I3fe88411092df159fa6dc39a8fb9eb3ab36eeb70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158254
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-12-09  Michael Weghorn  <m.weghorn@posteo.de>  [a4b03fce93fce7672be40b57d30797ac36ca67c9]

        tdf#164247 sw a11y check: Adhere to WCAG contrast threshold for large text
        
        Quoting WCAG 2.2 "Success Criterion 1.4.3 Contrast (Minimum)" [1]:
        
        > The visual presentation of text and images of text has a contrast
        > ratio of at least 4.5:1, except for the following:
        >
        > Large Text
        >
        >     Large-scale text and images of large-scale text have a contrast
        >     ratio of at least 3:1;
        
        Regarding large text, the corresponding "Understanding SC 1.4.3" [2]
        clarifies:
        
        > Text that is larger and has wider character strokes is easier to read at
        > lower contrast. The contrast requirement for larger text is therefore
        > lower. This allows authors to use a wider range of color choices for
        > large text, which is helpful for design of pages, particularly titles.
        > 18 point text or 14 point bold text is judged to be large enough to
        > require a lower contrast ratio.
        
        Therefore, lower the text contrast requirement in
        Writer's accessibility check from 4.5 to 3.0 for
        text that is considered large according to that
        specification.
        
        Add a unit test with 2 test documents:
        
        * one that adheres to the requirements and would have triggered false
          positives without this change in place
          (sw/qa/core/accessibilitycheck/data/ContrastTestOK.odt)
        * one that doesn't adhere to the requirements and still fails the
          check, as it should
          (sw/qa/core/accessibilitycheck/data/ContrastTestFail.odt)
        
        [1] https://www.w3.org/TR/WCAG22/#contrast-minimum
        [2] https://www.w3.org/WAI/WCAG22/Understanding/contrast-minimum.html
        
        Change-Id: I398f72aa5bdcd77c42834632575d6465a5ecd586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178127
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5ba8f4f453f79b7beae750b42a3459d19b34cb44]

        f'up to "Windows 7-8.1 support was removed, prevent install on these old systems"
        
        ucrts are no longer added to the installation sets and the corresponding
        configure switch has been removed as well.
        
        Change-Id: I484c65c6109572ddd31738e91fcc798575508a7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178076
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-12-09  Michael Weghorn  <m.weghorn@posteo.de>  [0bf5756b6aad1e15b00f0cdeea8546363b2c1cff]

        win: Reuse existing WinSalInstance::getWindowsBuildNumber
        
        Change-Id: I59b4da71a25a3532e044451b7e89637a53d53a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178136
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-09  Michael Weghorn  <m.weghorn@posteo.de>  [5f00b748cbcb2c37f3c3a11a86b4df85b8b9a213]

        vcl win: Use only Windows build number to identify version
        
        Now that support for Windows versions earlier than Windows 10
        was dropped in
        
            commit b664c08a6d1096d279437c883e55735a0c431ac8
            Date:   Sat Dec 7 14:46:24 2024 +0500
        
                Drop support for Windows versions prior to Windows 10
        
        , also drop handling for earlier versions from
        `getOSVersionString`.
        
        All still supported Windows versions (10, 11,
        corresponding server versions) report a major/minor
        version of 10.0 (see [1]), so rely on the build
        version only and drop previous logic to retrieve
        the major and minor version.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/sysinfo/operating-system-version
        
        Change-Id: I91e0e8238350f680594a516b5e0c042244a49683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178135
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-09  Michael Stahl  <michael.stahl@allotropia.de>  [bfdba3c86301e9680204de0a66bfbfc6383494b9]

        tdf#159549 sw: add unit test
        
        Change-Id: I8b964d4436835b66f25acece9562516ed70473eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178148
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-09  Adesola Samuel  <adesolasamuel2022@outlook.com>  [928081ac7288eecf7cafe0f1ac6e803dc611b39a]

        tdf#157747 Add tooltip to Calc select all rows
        
        Added a tooltip that says "Click here to select all cells" to calc
        select all rows corner. The report shows a tooltip
        will suffice instead of an added icon
        
        Change-Id: I33f9bcb48f9185267be760219f58b196e4d5874d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178092
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-12-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e8b7fe1809d07576276ebec9f321216bd0b7d184]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 31bc2a1104a1cd175f900902f994c76dea35c763
          - Add new word "Ratenvereinbarung"
            
            And put "Rattenvereinbarung" on the blacklist
            
            Change-Id: Ie4d7b8fd93c5758316b5a60539c2a42152725537
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/178143
            Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            
2024-12-09  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [f958aea556e6ea067eb8696a1dff99f3458e8c19]

        tdf#164129 sd: fix resizing of the notes text content
        
        The notes text content was not resized when we changed the paper size
        in the print dialog.
        
        Change-Id: I2f610579e2ac84c298c4105a5c1235fbe62ad627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178146
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-12-09  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [6fd252d499ef8b2f88ca8fdab8b989e8d80bae28]

        Related: tdf#88226 if the paragraphs of notes contain upper and lower
        
        paragraph spacing, add this values to the notes text size.
        
        Change-Id: I277ecad30244a418d5038e2a8668cf28302f10ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177856
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-12-09  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [6c9055aaac77323b9446050dafb8dc8d492a6bd6]

        tdf#158512: PPTX import: reset useBgFill flag when it is unused
        
        Even if current fill is not "use background" we should reset useBgFill
        explicitly, since this value could be set from master slide and was
        nested in current shape.
        
        It is somewhat confusing to have fillStyle as none and using slide
        background at the same time. So better to clean it explicitly.
        
        Change-Id: I0d817dc295785be7a6cb8f884d5023d316cd2ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165994
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-12-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [41ab6a5dfa0bbc67c726ba872e9ef85fde67a394]

        struct SN needs a strict weak ordering operator <
        
        ...so it can be used with std::sort in impSolve() (further down in
        basegfx/source/polygon/b2dpolypolygoncutter.cxx).  At least on macOS with a
        LLVM 20 trunk libc++ in hardened mode, JunitTest_sfx2_complex failed with
        
        > ~/llvm/inst/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:59: assertion __comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering
        
        To simplify the new implementation of struct SN operator <, add a B2DPoint
        operator <=> (but whose implementation would cause
        
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/basegfx/source/curve/b2dbeziertools.cxx:21:
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/include/basegfx/curve/b2dcubicbezier.hxx:22:
        > /home/tdf/lode/jenkins/workspace/android_arm/include/basegfx/point/b2dpoint.hxx:129:41: error: invalid operands to binary expression ('tuple<const double &, const double &>' and 'tuple<const double &, const double &>')
        >         { return std::tie(a.mnX, a.mnY) <=> std::tie(b.mnX, b.mnY); }
        >                  ~~~~~~~~~~~~~~~~~~~~~~ ^   ~~~~~~~~~~~~~~~~~~~~~~
        
        etc. on Android with NDK 23.2, see
        <https://ci.libreoffice.org/job/gerrit_android_arm/43174/>, so work around that
        in the implementation for now).
        
        Change-Id: I9f46d39dc9e9024fe9ac59413c44e49642282c8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175622
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-09  Michael Stahl  <michael.stahl@allotropia.de>  [2b8d794e448a7d3c573ff79cffe9decc8d960262]

        tdf#159549 sw: fix style name in SwXStyle::getParentStyle()
        
        For a style that isn't inserted yet, the m_sParentStyleName is converted
        to UIName by setParentStyle() but isn't converted back to ProgName in
        getParentStyle().
        
        This caused all of the writerfilter test failures in commit
        c166d112381f195a171425d1f9c1d38ce579319a.
        
        Change-Id: Ib5495785996807a8f3d9339ed2740f286b04d716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177998
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-09  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7364b3a2d820e028d30237cf13f562674759dc4f]

        lok: slideshow rework: check that requested slide is the expected one
        
        Change-Id: I225dfea9981d43fb90888f5025792e9d24d9a789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173061
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178129
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [810b895ec76d374e173a254c98552c3366183af2]

        crashtesting: reimport of fdo61125-1.docx has negative image width
        
        we probably shouldn't do that anyway, but the assumption at this
        import check appears to be for >= 0
        
        Change-Id: Ibf98b1b0802a15bc283b3d1e3db7e4e8163837dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178132
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [91c636c7f9484f650b6c494bf90212c57118f438]

        Silence -Werror,-Wunused-private-field
        
        ...with !USE_CRYPTO_ANY (e.g., Android)
        
        Change-Id: I139aceeea085420dd3ec31ced25b66a1671dc7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178130
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f9f04421b45d07b600078d968afa45384ee7060]

        rename IsOnSystemEventLoop -> IsUseSystemEventLoop
        
        to match the underlying field and avoid confusion.
        
        The "IsOn" prefix normally means "is the current thread running on",
        which is not what this method means
        
        Change-Id: I3399a707582c9b0c681cd4aa03bc9f94860fc7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177960
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [10c2eee93be76d8bdad980bd86d02c84896758c1]

        remove some range checks
        
        which are more likely to hide an underlying bug than they are to help
        
        Change-Id: I118b592677df05246912d7fa3d7ab8ca2fe99377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [b0d6329c055d66a7a07fbbee89015e3843945682]

        remove some range checks
        
        which are more likely to hide an underlying bug than they are to help
        
        Change-Id: I5087827665bd6213142ee90450bf58d8d819c93f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [3339fd9a3fbbeca3af1239487146b61486c8145f]

        remove some range checks
        
        which are more likely to hide an underlying bug than they are to help
        
        Change-Id: Ifba3c38e9dc6c3d47c9c62bebf5b5e68f11d9ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [d18ab050c4ce0536abd4bc9339a6dd1436172d7e]

        remove some range checks
        
        which are more likely to hide an underlying bug than they are to help
        
        Change-Id: I3bcac401d62f9baf27e72bacb6bb0a2315d1c081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [0aa4bfe37a80f3b17430cb91b4fd5e9e528efcbd]

        improve SalInstanceNotebook m_aPages handling
        
        I added some asserts here, and discovered that sometimes
        m_aPages and the pages in the underlying TabControl get out
        of sync. So rather than relying on indexing into a vector,
        just store a map indexed on the page identifier, which
        means everything uses the same scheme now.
        
        Change-Id: I1b8228e9b124521bda0e79c98e4961bedc71d641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178003
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [ba16fd8e741e85e3472b7425e25986ebfe4901a8]

        no need to do repeated lookups here
        
        Change-Id: Iec30aa6bbd1bcb8bb22cfb002f81ea04458755b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178116
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-09  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [0892ff2de0093fcc53f23e7d0787fbda34b6c371]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f45820f45e2cf351d3f08238952d25de0f68337d
          - tdf#161502 Update label Structure to Content in Function Wizard help
            
            Change-Id: I62322b720b0ec54c54268d9cb6a0f2d36b7c8d94
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178125
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2024-12-09  Miklos Vajna  <vmiklos@collabora.com>  [8c7ad3231435e3b11467cfc9f28d88157caf3f4b]

        svx: prefix members of SdrDragResize
        
        See tdf#94879 for motivation.
        
        Change-Id: I90f3a09e5dee630ead50954b1d8c5848b9319949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178123
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [917b039c99236e0c9de9b6ecb941fd11d8c17fd8]

        pdf: forward declare IPDFEncryptor
        
        To compile less when changing PDFEncryptor.
        
        Change-Id: I56e19e12494488fedb929998f8e6d0ff3bf8008c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176456
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177875
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9b6be690a22ebfbacd05a6567e9904f4db3449a1]

        pdf: cleanup and improve PDFEncryptionProperties
        
        Add clear method to clear the variables that we usually want to
        be cleared. Also rename Encrypt to canEncrypt - which is more
        clear what it means. Cleanup initializers.
        
        Change-Id: I96735eb6f73a699fb0759496fc8781bcff3854de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176455
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177874
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6e049433e409a7cd0e5213f367947fedf752bd5c]

        pdf: refactor and move encryption init. to a common function
        
        This is needed because we have to separate the init. for both
        encryption methods and we have to init both when the password is
        entered. Currently we only prepared this, to make this possible
        when we introduce the other encryption method.
        
        Change-Id: Id6556ddc6a6218164a93bb689f03d6ec6dbad8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176454
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177873
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-09  Noel Grandin  <noelgrandin@gmail.com>  [29c32bf317d57e6b9d7895e2cbdfcc0c9d8bbb56]

        make conversion operator explicit
        
        so less invisible behaviour
        
        Change-Id: I497763cb4be554ddbd00831458f162d9d975742e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178115
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [16a534c61752aadbcb83bf876f752f444f471d2a]

        Simplify OInputSeekStream
        
        Change-Id: Ie8da09ad8f3e4425aaeb87f907e47a4e2148f164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178118
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [e512091e89f2489e8b4a5dd5a19880b508c6867b]

        Simplify InteractionContinuation and derivatives
        
        Change-Id: Ib7294cc09255f7563ae14488ab7fb56d02092dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178117
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-09  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a1b8b44bf99b331f6cd4b4583d08b6a01d5c4f03]

        tdf#131332: Replace custom date formats with ISO 8601
        
        Change-Id: Ia9307e299f5cbf131b62e8936bc65aa8d7af8739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177496
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-12-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e67465f817e71df099bf9be6e7db8072ebcec747]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fd0b5ff3a8599ee49a04b36c9203a03e6295f54
          - Add Tagalog to online help dropdown list
            
            Change-Id: Ie22b89529b3937a36806f87b3e9a049a14bc85b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178120
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e693261fbb96acb52567bd1e36228e93c4622630]

        tdf#144407 save the current window state on new document
        
        so a new window of the same type will open with the same settings
        
        Change-Id: I7ee4b476d207d1dbd538ce6c054d83f7281f0309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [045a98c9ee0a0b9f1366064f3e57bdce977cb056]

        Simplify SwAccessible*
        
        Change-Id: I2994161bfa8fa3a88b3e66a9f4f12e4de6d5b025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178096
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [76cf7c6fc071c76675fef80bf55be473efef6296]

        Simplify UcbContentProviderProxy
        
        Change-Id: I7366e31dc167707adf2c614049cee852e44d7ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178097
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [2ef6b7f9dbbf826817a14640cb3118c495db5bc4]

        Drop some OTypeCollection uses
        
        Change-Id: Ia1467c44998961f5e0820fb4d0621a4189d49d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178095
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f8aa78379cfbff830b0e8dc6f2b6961dd09fa74b]

        Simplify ProgressMonitor, StatusIndicator
        
        Change-Id: I1c17fa54e865c2750407783adbb2f73c095dbbfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178094
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [98352eda9b032666b98f108b69fc38427380ab15]

        Simplify ScCellRangesBase and descendants
        
        Change-Id: I2416ab8a9263bd7858e0d62055067b3c6132e0b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178093
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [06e81f5783c96ea3d07ecbc11e2085ff41adcff0]

        Update readme files after Windows runtime baseline bump to 10
        
        Change-Id: I9b26bed6eb02f4df59c1ffaa5d28aa50aa1cb6c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178091
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f74aa7c2012e1cb127292a44951647f85f5c4752]

        cid#1635773 Dereference after null check
        
        and
        
        cid#1635777 Dereference after null check
        
        pass ScDocument& around when we know it can't be null,
        drop mpDoc and redundant null checks
        
        Change-Id: Ia7efe71c561ff084fbb2dc3cbabd02852a656099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178046
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [b083e27de5e3cd7d46df089915572340325b2bd1]

        GetCurrentPackageFullName is available in the baseline Windows 10
        
        Change-Id: Ie5d46f6a53af9a9a68ae98d4de28021fa1ee7eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178088
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46cfd8d2a7a06fb5c04c027ce641a766af8a337a]

        cid#1636664 Dereference after null check
        
        Change-Id: I916212471a80417a582192920427999ee6a425d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178078
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [4a09777d8f043f79e4fdcb8d42ec60ea88ad14c0]

        Windows 10 is the baseline, drop checks for older versions
        
        Change-Id: I78c3b1e6efc73095cd11cecc4ffc30acba02f943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178089
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [fdd07300524b278a9f674e5b13a8dabebed5e82f]

        tdf#138615: canonicalize the paths with wildcards, to process long paths
        
        Now that we discontinued support of Windows 7, PathCchCanonicalizeEx is
        definitely available.
        
        Change-Id: I38b0ff5b6810dfbd6ee6fe84693f71b8392a1808
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178086
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [04957a8d32d21685d5e72ae1ae3e9f97df6ae47f]

        Drop BCryptKeyDerivation.patch.1 from xmlsec
        
        Change-Id: I161f3cfc334d6be0263536800cb028b8e7310823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178080
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [de3baea91f37273f6af5079a6e37040d42255b1d]

        Drop vcl/win/gdi/dw-extra.h after baseline bump
        
        Change-Id: Ib303b35837fd73cc3dea77e5095f6d00c9dfa1bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178082
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [599dc2a504fde53a39599a39b1cc895edf06b300]

        Remove Windows 7, 8 and 8.1 from driver blocklist code
        
        Change-Id: If3138b9b603c21a9cc6fedc08a7db144fb9f00ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178077
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7dd9d6525aa45ebd22d58cb3980c63d8c7341d2c]

        Drop windows7.patch.1 from pdfium
        
        Change-Id: Idb458e3e65bc22d148cc68e496aa0dda32fec2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178079
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Marc Mondesir  <timepilot3000@gmail.com>  [143e89dbf85b13e1acccb76877d774a7fca1b016]

        tdf#119745: Fix touchpad scrolling for Slides and Pages panes.
        
        Use fractional lines scrolled to calculate distance to scroll view,
        instead of jumping forward or backward a full page every call based on
        sign. Also fixes existing bugs: horizontal pane can scroll too far to
        right; and snapping pane from vertical to horizontal can break scrolling
        if view partially scrolled.
        
        Change-Id: I0ead4710a296aac26f1cf1a0fc48e6ea403271a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177836
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [18399240f2aa976041db1928b1ae9db1a0ad706d]

        cid#1607671 Data race condition
        
        Change-Id: Id2e87001b77087a072705ba7ffa1a2190220a082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32767d081e10bac317b21cd53b48755837b5b533]

        cid#1607247 Overflowed constant
        
        Change-Id: I9648bc8a41a44a98fd8d0d78e889228948e38a34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178045
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [813f34d6726584368641f2e93fdaf79ff387d6b8]

        tdf#79298 - FORMATTING: Copy/paste: import strikethrough attribute
        
        Change-Id: I0539e87f2a87f869e234ed7c944b9da6bd0e82bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177847
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c4dee829f397a7ad1fe195e8f3a6f849dac459d7]

        Simplify SvtFilePicker
        
        Change-Id: I2b6d1589c25cb1fa4711f088641afe1bfe1d7411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178072
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [495e38c85396f9116d8f2831fc925404bf933905]

        tdf#130857 qt weld: Implement QtInstanceTreeView::selected_foreach
        
        This gets used in the "Tools" -> "XML Filter Settings" dialog
        in Writer when selecting multiple rows in the tree view,
        then clicking the "Save as Package" button.
        
        The result with SAL_VCL_QT_USE_WELDED_WIDGETS=1 and the
        qt6 VCL plugin in XMLFilterSettingsDialog::onSave looks
        as expected with this change in place (variables `aFilters`
        and `nFilters` contain the selected filters and total
        count of these when observed with a breakpoint after the call to
        `m_xFilterListBox->selected_foreach`).
        
        The method still triggers an assert later in a WIP
        branch where support for that dialog is declared,
        because `QtInstanceWindow::GetXWindow` is called,
        but not implemented yet.
        
        Change-Id: Iab47f391106132b5a6ee03fd2ad1902d493c0999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178070
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [aad48b06e7262cfa3979ade40b85819b506cb78e]

        tdf#130857 qt weld: Add tree view iter and implement some methods
        
        Add a new QtInstanceTreeIter struct as the weld::TreeIter
        implementaton for QtInstanceTreeView.
        It uses the QModelIndex of the item it points to.
        
        Add QtInstanceTreeView::modelIndex helper methods
        to convert both, an int row index and a QtInstanceTreeIter
        to a QModelIndex.
        This can be used to deduplicate code when (re)implementing
        the methods that have two variants that either take an
        int row index or a TreeIter input param.
        
        For QtInstanceTreeView::get_id, add a new variant that
        takes a QModelIndex and move the existing logic from
        the implementation for the int param there and reuse
        it to implemetnat the variant taking a TreeIter param
        as well.
        
        Implement a few more methods taking or returning
        a weld::TreeIter.
        
        Change-Id: I0508ad14a43214faccc6a3cba208400031bb231c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [254743e93f67fb6d623b659b33a8c78387f23a1a]

        tdf#130857 qt weld: Implement QtInstanceTreeView::remove
        
        Side note: In Writer's "Tool" > "XML Filter Settings" dialog,
        trying to always delete the first entry works 3 times
        (when using a fresh profile), but doing it again after then
        doesn't remove the entry from the treeview, but the entry is
        still gone when closing and reopening the dialog.
        
        That's the same with gtk3 however, weld::TreeView::remove
        doesn't get called. So it's not a problem in the weld::TreeView
        implementations, but probably in XMLFilterSettingsDialog
        or some other underlying logic.
        
        Change-Id: Ic91b3d1d62b66574b9e0710b17b2d9606d27a0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178068
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [044f2113dc3f5e76fa3b56e57823c9c9b7f390b6]

        tdf#130857 qt weld: Report selected tree view row only once
        
        Now that support for multiple columns has been implemented
        in QtInstanceTreeView, iterating over all selected model
        indices and appending their row index to the vector
        results in the row being appended once fore each column
        of the selected row. (Index seen twice in `aRows` in
        XMLFilterSettingsDialog::updateStates while debugging
        another issue in the "Tools" > "XML Filter Settings" dialog
        with the qt6 VCL plugin and SAL_VCL_QT_USE_WELDED_WIDGETS=1).
        
        Use QItemSelectionModel::selectedRows (with the default column
        index of 0) instead of QItemSelectionModel::selectedIndexes
        to prevent that.
        
        Change-Id: Ic8caa299549d954ed844c39c4b2ba957edf2b404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178067
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [9c334767305ec0b24bdf05f3eb3df1fa41aa330c]

        tdf#130857 qt weld: Fix incorrect param order for row/col
        
        In QtInstanceTreeView::get_id, the nPos param is the
        row number, but was incorrectly passed as the
        second parameter to QStandardItemModel::index [1]
        which is for the column. Swap the params to fix that.
        
        Passing incorrectly would trigger a crash in a WIP branch
        for Writer's "Tools" -> "XML Filter Settings" dialog when
        clicking on the second row, as the ID data is only set
        for the item in the first, not the second column,
        so `pInfo` in XMLFilterSettingsDialog::updateStates
        would be null.
        
        Backtrace:
        
            1 XMLFilterSettingsDialog::updateStates xmlfiltersettingsdialog.cxx 183 0x7f3eb862194e
            2 XMLFilterSettingsDialog::SelectionChangedHdl_Impl xmlfiltersettingsdialog.cxx 153 0x7f3eb8621859
            3 XMLFilterSettingsDialog::LinkStubSelectionChangedHdl_Impl xmlfiltersettingsdialog.cxx 151 0x7f3eb861e8cd
            4 Link<weld::TreeView&, void>::Call link.hxx 111 0x7f3eeb997aa1
            5 weld::TreeView::signal_selection_changed weld.hxx 989 0x7f3eeb99733c
            6 QtInstanceTreeView::handleSelectionChanged QtInstanceTreeView.cxx 781 0x7f3eeb98cb2d
            7 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7f3eeb998141
            8 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7f3eeb998079
            9 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *) qobjectdefs_impl.h 126 0x7f3eeb997fab
            10 QtPrivate::FunctionPointer<void (QtInstanceTreeView:: *)()>::call<QtPrivate::List<>, void>(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *) qobjectdefs_impl.h 174 0x7f3eeb997f2d
            11 QtPrivate::QCallableObject<void (QtInstanceTreeView:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 545 0x7f3eeb997e56
            12 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7f3eeaa5ce22
            13 doActivate<false> qobject.cpp 4139 0x7f3eeab1c644
            14 QMetaObject::activate qobject.cpp 4199 0x7f3eeab121b3
            15 QMetaObject::activate<void, QItemSelection, QItemSelection> qobjectdefs.h 306 0x7f3eeaf93da5
            16 QItemSelectionModel::selectionChanged moc_qitemselectionmodel.cpp 390 0x7f3eeaf85b76
            17 QItemSelectionModel::emitSelectionChanged qitemselectionmodel.cpp 2029 0x7f3eeaf87a2f
            18 QItemSelectionModel::select qitemselectionmodel.cpp 1372 0x7f3eeaf872f9
            19 QTreeViewPrivate::select qtreeview.cpp 4016 0x7f3ee906f2ec
            20 QTreeView::setSelection qtreeview.cpp 2393 0x7f3ee906eaae
            ... <More>
        
        Change-Id: Icf6b3004ab95991da69c0ff86201421d620aaa43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178066
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c91edf5e57a7441fbac399c7a44f26a57878e5be]

        SvtRemoteFilePicker doesn't extend SvtFilePicker's interface list
        
        Change-Id: Iad25fa30a550494ba5a27d30f703ee6748fd338c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178071
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [4d91b67e1f0dbd73ee594c6539d08a6ebc935b7e]

        tdf#130857 qt weld: Evaluate button box orientation
        
        Set orientation to vertical if that's specified
        in the .ui file instead of using the default of
        horizontal.
        
        This is used by the button box on the right hand side
        of the "Tools" -> "XML Filter Settings" dialog.
        
        Change-Id: I64460037649dcd24897c7a5d7148430836702edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178064
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [77f4c8c78aa1b79f1e81d7dac477ed1676e1d5df]

        tdf#130857 qt weld: Set tree view column header title
        
        Make the `extractTitle` helper function used by
        VclBuilder a static method in the BuilderBase
        base class for reuse by QtBuilder.
        
        In QtBuilder::makeObject, when encountering a "GtkTreeViewColumn"
        object, add a new column to the QTreeView and set the
        column title in the underlying model using
        QStandardItemModel::setHeaderData.
        Return the parent (tree view).
        (Returning no object would cause WidgetBuilder::handleObject
        to call WidgetBuilder::insertObject again, and thus result
        in every column being processed twice, i.e. the double
        amount of columns would be inserted).
        
        Adjust QtInstanceTreeView::clear to no longer
        call QStandardItemModel::clear [1], as that would
        not only remove the "actual" items, but also the
        header items, i.e. the column titles would get lost
        as well. Remove all rows instead.
        
        With this in place, the tree view in Writer's
        "Tool" -> "XML Filter Settings" dialog has the
        correct data + title set on open in a WIP branch
        where support for that dialog is declared in
        QtInstanceBuilder. (Other aspects in the dialog
        still need to be addressed however.)
        
        [1] https://doc.qt.io/qt-6/qstandarditemmodel.html#clear
        
        Change-Id: I59956c007ed73cddb299ad2374afd88199ddc94d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178063
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [36ab4833c96bf9568e7fb06880c01729f2c75ece]

        tdf#130857 qt weld: Implement QtInstanceTreeView::columns_autosize
        
        QTreeView::resizeColumnToContents [1] looks like the Qt
        equivalent for GTK's gtk_tree_view_columns_autosize [2].
        
        [1] https://doc.qt.io/qt-6/qtreeview.html#resizeColumnToContents
        [2] https://docs.gtk.org/gtk3/method.TreeView.columns_autosize.html
        
        Change-Id: I4771896fb932834f51fa48ceaa3557181f474fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178062
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [23ea73587adead7b41e39a9c2cf55d5bb5f8b926]

        tdf#130857 qt weld: Implement QtInstanceTreeView::set_text
        
        For now, require that the actual column index is passed.
        
        The weld::TreeView::set_text doc mentions
        
            // col index -1 sets the first text column
        
        , but that is not supported yet, so assert a different
        index is passed for now.
        Revisit when implementing support for a dialog that actually
        makes use of this.
        
        Change-Id: I8ba6e965ba22542bf3151548200b92c8c6b085d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178061
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [a26173266db38a2e9f91c37005097e33bb0e628d]

        Simplify a bit
        
        Change-Id: I7ecbf2c1e4b08175dabd29782a40dd2f25fe040c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178058
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8075798b22f2188530f57b8747589923bfd419ef]

        Fix check for further exotic protocols
        
        ...that were added in 59891cd3985469bc44dbd05c9fc704eeb07f0c78 "look at
        'embedded' protocols for protocols that support them"
        
        Change-Id: I42836d6fd27cd99e39ab07e626053f002a2651f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178047
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [05eb50c396c3ff2adcc824cba20f8af1ed0d27c8]

        Simplify unocontrols::BaseControl hierarchy
        
        Change-Id: I7c690cd429b2ac52f8aac602b4c9129bdd774b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178052
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [cd9976d2b1019a01f7de0b1850acf1957cbb8946]

        Avoid needless temporary Sequence creation
        
        Change-Id: Ia0b6df8b329136292917c94ee5d5e69a0931a200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178056
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [8fdef548702ef240980b52e4076af36122534fed]

        Simplify OPropertyContainer::getBaseTypes
        
        Change-Id: I438d510e05329163dabdc8ed42d3a97d49e19ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178055
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [831700824d6c6c86ee798fec4617307aedded7df]

        Simplify getTypes implementations
        
        Change-Id: Ia0f7e8497f628b17a108a4dd8ffebc60745b7d6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178054
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [75f5c610de6161284dc7db0550d7875c18fbf27f]

        Simplify OPreparedStatement
        
        Change-Id: I1c36ec85d1acafc5c6ef33ea250ac6027d604da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178053
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ec0a49ecc7ea8449d90c1e69857d62728af19829]

        Windows 7-8.1 support was removed, prevent install on these old systems
        
        There is no simple "Windows is 10 or newer" check in MSI, with the
        Microsoft policy of "you don't need to know real Windows version".
        See also https://developercommunity.visualstudio.com/t/detect-a-windows-version-from-msi/412198
        
        The values that MSI sees (e.g. on my Win11) are:
        
        Property(C): VersionNT = 603
        Property(C): VersionNT64 = 603
        Property(C): WindowsBuild = 9600
        
        So those can't be used for the check. I use the WINMAJORVER that is
        read from registry (Software\Microsoft\Windows NT\CurrentVersion).
        
        There is no more need to check and install UCRT; it was dropped.
        
        Change-Id: Ic02d6aeb965e9684bafd4357f969980f77000e73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178049
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [762d76d9a44704af45b4989f900a906f8f7aa3a3]

        Simplify avmedia::SoundHandler
        
        Change-Id: I253d6eda265e3e93d4b85ac35376a96676a68553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178050
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [04c62acc63a88e668edea67ea6dd2127858e25be]

        Use std::initializer_list, C-style array instead of more expensive Sequence
        
        Change-Id: Ibb268268926cc91f595f19026f6cee4b5a74a8bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178038
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a35f0aee6270da1c99e9104a372634d7e8913bd6]

        Simplify a bit
        
        Change-Id: Ie2b96e099a0507e14ad8e79276abdbe0f21d35f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178040
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Jim Raykowski  <raykowj@gmail.com>  [b96894426f187a323688953f625e21d4fdbc63f4]

        check passed functions before use
        
        This is a follow up to commit
        55e86edcb37a37123a69ce3e1eb9e20758415fb6 to fix a crash that occurs
        when importing a Basic library.
        
        The change made to functions arguments passed to ImportLib in PS28
        requires they be checked for nullptr before use. For further
        understanding please see change to moduldl2.cxx at https://
        gerrit.libreoffice.org/c/core/+/176254/27..28
        
        Change-Id: I3f7ccc46134ddd2429c499d6e728e30331b51d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177924
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-12-07  Jim Raykowski  <raykowj@gmail.com>  [ab5b5ad75d7816d449255b8e0663032749bfc041]

        Resolves tdf#164143 Tooltip with path to macro in new Macro Organizer
        
        dialog contains percent symbols instead Cyrillic
        
        Additionally use the same approach to make the expected symbols
        appear in the description text view.
        
        Change-Id: I89adafde4305dbe9a6e56481ed246376bc1d94a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177925
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a9734683dfa8a36eafd6f32414408c9b8f4a221c]

        Simplify OTextInputStream a bit
        
        Change-Id: I94c4432228c470ad31d15a765de87565b4ada9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178039
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5528f9c8b8ea08ad0a347e9564e7ce98564bed30]

        cid#1635776 Overflowed constant
        
        there is intended to be no logic change here, just rearrangement
        and acknowledgement that SwOutlineNodesInline::Seek_Entry always
        sets nEndPosInline to some value.
        
        Change-Id: I10d694e20c8619ae297a61f612590556c9a9effa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178037
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e92db94e19c869050140fc1df64c09b59e97cd67]

        cid#1636579 Dereference after null check
        
        and
        
        cid#1636580 Dereference after null check
        cid#1636581 Dereference after null check
        
        Change-Id: I856876a99a0bbccf27055d2db0dd24f7f040d3af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178036
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c97decfe2e4544f76a2b6f5704928cad0e30b56e]

        cid#1636576 Dereference null return value
        
        since:
        
        commit 43e511e642a2ce7026b30ea5c212940ff3eb522e
        CommitDate: Wed Dec 4 10:17:24 2024 +0100
        
            tdf#88226 sd: fix cutting off the overflow text on the notes print page
        
        Change-Id: I0a982a0a4213e220ec1bbd166e08bf14191eed0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178032
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88986086f9d785491f7430a66bbc255dd737738b]

        cid#1636582 Negative loop bound
        
        Change-Id: Ib91ee62814837765f89f65a1204021e9d9610e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c812bb3fe730a68f7fd9e5a32a5e1be7a59f60a7]

        cid#1636575 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1636577 COPY_INSTEAD_OF_MOVE
        cid#1636583 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic56139c5a17d8cc83d90afc78072ae073e99308c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178034
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [93350f4694ef8606150a95786c760bb2efd43979]

        Drop pre-Win10 code from WinSkiaSalGraphicsImpl
        
        Introduced in commit a1b18eba354dc773c214fc3b7ee92c3473ec4a5e (Implement
        Custom Font Collections on pre-Windows 10 systems, 2024-08-20).
        
        Change-Id: I2aa16ae560d4dad8489e13289ad79d8be349b6b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178031
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [d751cbefb4e1380cde2ac3d9d372cda8e88e33c9]

        Simplify AccessibleGridControlTableBase
        
        Change-Id: If4b8379f676a1a412eed6d79bf6b5382d3c726b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178030
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [bbf4c5ca179697f302893d3c193b28cbc241e1c4]

        Simplify GridControlAccessibleElement
        
        Change-Id: I1509ca337b5864805132a87dab2627df721091db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178029
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ac6b34ed9d21c33bfc9ac89ff74c408f2b008403]

        Simplify AccessibleBrowseBoxTableBase
        
        Change-Id: I8af6ac72923aa823db356769153790ae9d7752a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178028
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ffa47ff780ed737aef3ab988db4f42aee92653a3]

        Simplify BrowseBoxAccessibleElement
        
        Change-Id: Ic8322090d38d58475c4c946e1f850950bce7421a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178027
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [259480c5e1a387e01618dcd772e0ecdeead9b88b]

        Simplify OABSPilotUno
        
        Change-Id: Id722754aadecbb0cdb0a35fd8b3a7ac24e21b546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178026
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Alin Andrei Abahnencei  <alinandrei2004@gmail.com>  [734f80b66947210861ab2beb216e0dc327959e18]

        tdf#162716 Always strip line-ending characters
        
        Signed-off-by: Alin Andrei Abahnencei <alinandrei2004@gmail.com>
        Change-Id: I3dfc6908e18f7bad54468620cf657a0a4afb8046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177393
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b664c08a6d1096d279437c883e55735a0c431ac8]

        Drop support for Windows versions prior to Windows 10
        
        Now when version 25.8 is in development, and the drop of legacy Windows
        versions was announced in release notes.
        
        Change-Id: Iefda63a29cafe40aec78d149067bdd7a3f20cffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178025
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Michael Weghorn  <m.weghorn@posteo.de>  [634e226c6b0b0fea7c620395a4e84c4701179a86]

        tdf#130857 qt weld: Implement getting/setting cursor
        
        This is independent of the selection.
        (For selection, there is weld::TreeView::select
        and weld::TreeView::get_selected_index instead.)
        
        Change-Id: I3698a080cebaf4411740b0e7a95c54743e84d881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178024
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-07  Michael Weghorn  <m.weghorn@posteo.de>  [57d532057b4dcc248b9332835df2d6b7f61dfd92]

        weld: Rename weld::Treeview selection signal/connect
        
        Rename weld::TreeView member + methods to clarify
        that these are about selection changes:
        
        * m_aChangeHdl to m_aSelectionChangedHdl,
        * signal_changed to signal_selection_changed
        * connect_changed to connect_selection_changed
        
        In GtkInstanceTreeview, also rename the
        related methods calling signal_selection_changed
        accordingly for consistency.
        
        Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [4b9bf0a2b9c0f2bcba1f4f8a7ba45f1e7672d77a]

        SfxLibraryContainer: use std::mutex, and pass it to NameContainer
        
        ... to avoid own mutexes in own name container implementation.
        
        Change-Id: I29ff6ef987154359c35d0628d529b0606ef08c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177637
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-07  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [18b55add5e1b2da0905043d8043dd824e4bf7ca3]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I54460a95759ab8e2073c8ecab4e37ff15193a4e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177176
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-12-07  Simon Chenery  <simon_chenery@yahoo.com>  [1eb5e365212c078025b9f315f9377b8d2bef8a25]

        tdf#163738 use insert function instead of for loop
        
        Change-Id: I57c1ec3e580f4df22852dfaf7c75019e12fe352c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177898
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7292bc192ce511655fbfe361bc228bef6e9196a2]

        increase rtf2pdffuzzer max_len
        
        Change-Id: I99b48a7b38c8a53f6908137bfa3e4cee0231c4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178015
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8727bba7d1220cfdc0e1d325ee4551d4c46e17a]

        GetRootURL is always used to ctor a INetURLObject
        
        Change-Id: Ic532e92e20bfff75b6d68c670ce21b0157034bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5a251b6f55a950bcd71fd8ab9a9f3e1c78a73292]

        crashtesting: failure to reimport forum-it-2308.odt rtf export
        
        Change-Id: I9908dea4aa822b7793ece91874de0282239bd17b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177988
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-06  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [f77bff02edc05a31164983d73408edf78b9989ac]

        remove unused header in vcl/settings.hxx
        
        Change-Id: I93ab70526cbbbcc690d45fd9dacf7e6e110e7e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177958
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-12-06  Noel Grandin  <noelgrandin@gmail.com>  [a60617b1f2f1eca31177867e575bed57b1b448a3]

        tdf#163221 crash in dialog editor
        
        regression from
        commit 65d52af42f329bbe7c5e7d6ac617320f7faa4760
        clang-tidy: performance-unnecessary-copy-initialization in svx
        
        Change-Id: I48428fe08acdf9590a533c7ea91abe905713b292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177979
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-06  Michael Stahl  <michael.stahl@allotropia.de>  [afab0fa906a1bb9281378774586fe07193cba41d]

        sw: layout: ignore Keep-With-Next on hidden frames, part3
        
        SwTabFrame: :MakeAll(), SwRowFrame::ShouldRowKeepWithNext()
        Change-Id: I7cb6e558dc05736658a9bc75d6c735e6a47062b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177977
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-06  Michael Stahl  <michael.stahl@allotropia.de>  [a08b8fa2d01e630ef876b7944c37f0b6de09d407]

        sw: layout: ignore Keep-With-Next on hidden frames, part2
        
        SwFrame::PrepareMake(), SwContentFrame::MakeAll(),
        SwContentFrame::WouldFit_()
        
        Change-Id: I2a909ac6d147668dddece97bd99e31fdddcf20eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177976
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-06  Michael Stahl  <michael.stahl@allotropia.de>  [cd8468bcba952ab9b0d6ca97152a63d7469a9209]

        sw: layout: ignore Keep-With-Next on hidden frames, part1
        
        When a frame is hidden, don't consider it when evaluating keep-with-next
        attributes - this was the case for content in hidden sections before
        commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1
        
        ~SwFrameNotify() invalidating position of hidden frame with keep
        attribute causes layout loops.
        
        Also skip hidden frames in SwFlowFrame::IsKeepFwdMoveAllowed(),
        SwFlowFrame::CheckKeep(), SwFlowFrame::IsPrevObjMove(),
        SwFlowFrame::MoveBwd(), CalcContent().
        
        Change-Id: I68556ba0a8e016d962399f3ce199e5eda0378867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177975
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59891cd3985469bc44dbd05c9fc704eeb07f0c78]

        look at 'embedded' protocols for protocols that support them
        
        Change-Id: Ie99f5f5a390639bdc69397c831e0a32594a5030c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177981
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-06  Miklos Vajna  <vmiklos@collabora.com>  [ae7900dd42a65aaf60df6b21b9ad511496b209d9]

        tdf#164095 sw: fix missing top margin on paragraph after changing page style
        
        Open the bugdoc, go to the page after the section break, there is a top
        margin for the first paragraph there in Word, but not in Writer.
        
        This went wrong in commit abd90828cf101581a07b9d1c371a8c3156521e9f
        (tdf#160952 sw: ignore top margin of para on non-first pages with newer
        DOCX, 2024-05-14), where it seemed that all implicit and explicit page
        breaks want to ignore that top margin for the first paragraph.
        
        Turns out this is more complex: implicit breaks and page breaks should
        be followed by an ignore, but not paragraphs after "section break (next
        page)". So restore the margins for the RES_PAGEDESC, but continue to
        have them for RES_BREAK & implicit breaks.
        
        Change-Id: If1fcf3077b81a705d3587bdae422dcfa16f1c17c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177973
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-06  Simon Chenery  <simon_chenery@yahoo.com>  [7bd7adc3387714a2c9e6e663271c7b20708168c4]

        tdf#145538: Use range based for loops
        
        Change-Id: I6f8539869b991c2c71044e1a18dba69641ffabe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177505
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-12-06  Mohamed Ali  <mohmedali1462005@gmail.com>  [6fa141074beea30b68615764221a668f58bdf222]

        tdf#145538 Use range based for loops
        
        Change-Id: Iee3052f2fcc693b78c32fbae581f22527d64ffbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177082
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-12-06  Szymon Kłos  <szymon.klos@collabora.com>  [8203f31040e8f99196872e97456674d2f4a2bf83]

        slideshow: use unified hash for animations and layers
        
        Change-Id: I98d048f933469a63295776f689e96ce84d0c4f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177969
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-06  Patrick Luby  <guibmacdev@gmail.com>  [cd983f0af4d0d2a187e30f070bc96241d362302f]

        Related: tdf#152703 Reuse existing CAMetalLayer to stop flicker
        
        When live resizing a window, replacing the CAMetalLayer with each
        resize event repaints the window's background which causes a
        noticeable flicker. So reuse any existing CAMetalLayer already
        assigned to the native view.
        
        Change-Id: I03bda5f0d40b84606b6602961e5f0d3b0dfcc6ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177921
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-06  Oliver Specht  <oliver.specht@cib.de>  [add6efb409fdc6d0c3f649a58f2607947669e18f]

        tdf#160621 Variable field dialog size of value field
        
        The size of the value field is now set to 5 rows.
        
        Change-Id: I808ffbb64d71a0707857cf80d1c0b73419ac7b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177893
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-12-06  Michael Stahl  <michael.stahl@allotropia.de>  [bd727654ec8cc339292072b42073e57d566cc220]

        tdf#159549 sw: fix ODF import of newly colliding Body Text styles
        
        Commit c83d241effbd09491e9f96d3e435ab91700f58b0 "tdf#154933 Rename "Text
        Body" para style to "Body Text"" introduced a regression when importing
        certain ODF documents, but the problem is actually pre-existing.
        
        What happens is that first the built-in "Text body" style is created,
        and then a non-built-in style with the same translated name as "Text
        body" is imported, and instead of creating a new style, the built-in one
        is found and used, and so its properties are overwritten.
        
        The root cause is that SwStyleNameMapper::FillProgName() and in
        particular SwStyleNameMapper::FillUIName() are defined poorly, ever
        since they were introduced in 2001 in commit
        4fbc9dd48b7cebb304010e7337b1bbc3936c7923
        
        It becomes obvious relatively quickly that the way style names work is
        that at the UNO API level, the "ProgName" (internal, non-localised)
        names are used, and at the core document level, the "UIName" (localised)
        names are used.
        
        This is in itself questionable - why is the translation from ProgName to
        UIName not done in the UI? - but also very expensive to change now.
        
        So then the UNO services are responsible for translating between
        ProgName and UIName.
        
        But the 2 functions don't do that properly; both need to check if the
        given name is a known ProgName *or* a known UIName, and rename it in
        case it collides with a known target name; also the 2 functions need to
        cancel each other out, not add " (user)" at the end in both directions.
        
        Fixing this causes numerous tests to fail, due to:
        
        1. the UNO services calling themselves with already converted style
           names, which are then translated a second time, which fails now.
           (or calling the wrong function like SwXStyleFamily::getByIndex())
        
        2. many tests call the UNO API with UINames instead of ProgNames
        
        3. somehow the writerfilter import is also changed, causing failures in
           e.g. testTdf113182 and testTdf104492
        
        4. buggy code elsewhere (lcl_getUsedPageStyles()), problem similar to
           1., for PageDescs
        
        5. potentially more buggy code yet to be discovered (definitely table
           styles, forgot which test that was)
        
        So limit this fix for now to only paragraph styles, and don't do it in
        writerfilter import, now at least sw.check passes.
        
        Change-Id: I5cbdf3e174622e83f9af8787c3671b88c0e37bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177858
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-12-06  dtm  <daniel@fearnley.net>  [418a55e0dcb5e99e5972cebd63ffe4f961f9f0ac]

        tdf#157794 refactor Complex to use std::complex where possible
        
        Change-Id: Ie583399977caf266e3cc0a3cb78462be4cd63151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160394
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-12-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0a7b9ba8a49fe9f7ec9964864298f1994e81ff79]

        tdf#163486: PVS: The 'eAggFunc' variable was assigned the same value
        
        V1048 The 'eAggFunc' variable was assigned the same value. Will be assigned after the switch.
        
        Change-Id: I21d4cb4b0e7427bea56598476ca176cc0a4f7124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175902
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-12-06  Michael Weghorn  <m.weghorn@posteo.de>  [26b24e181c7e924a4f0521a875cf38bbc7b70871]

        tdf#130857 qt weld: Support printer properties dialog
        
        Declare support for the "Insert Breaks"
        "File" -> Printer Settings" -> "Properties" dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Since this dialog contains tab pages, their .ui files
        need to be declared as supported as well.
        
        Change-Id: Ia4360eebf3fed6ab5f78510c866a1703b0db8998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177923
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-06  Michael Weghorn  <m.weghorn@posteo.de>  [42f8227fdd3a0bb92a5eb50fd580e76d7d35fcb0]

        tdf#130857 qt weld: Return selected item when requested in callback
        
        The current item and the selected item(s) are
        not necessarily the same.
        
        Looking into the gtk and VCL implementations,
        weld::TreeView::signal_changed is called
        when the selection (not the current item) changes, so
        connect to the QItemSelectionModel::selectionChanged signal
        instead of the  QItemSelectionModel::currentChanged one
        in the Qt implementation.
        
        At the point in time that the QItemSelectionModel::selectionChanged
        signal gets emitted, QItemSelectionModel::selectedIndexes
        returns the newly selected indices while that was not
        yet the case with QItemSelectionModel::currentChanged.
        
        For the "Device" tab in the "File" -> "Printer Settings" -> "Properties"
        dialog (for which support will be added in an upcoming commit),
        this resulted in the PPD values (in the tree view
        on the right) not being shown for the actually selected PPD
        option/key (in the left tree view), but for the
        one selected previously.
        (See RTSDevicePage::SelectHdl for the logic filling
        the tree view with items, which gets triggered when
        weld::TreeView::signal_changed gets called.)
        
        Change-Id: I31ec5aaaa47cd3d4704f25086b24645fb708be0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177922
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [31d0c99c31be9a83cb8dae9c7555f27083b3320c]

        add assert in SwNodes::ForEach
        
        to catch any dodgy code
        
        Change-Id: Iffd0612b28871c864f103634a40d13b82160d1ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177955
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7268b7d9e4ee79785116d1d80942cec8f035aae]

        tdf#119840 small tweaks
        
        Change-Id: Ie2c7a9633ee62bc1c4c0ad821d5ff1ace71fc15d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177928
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-06  Mike Kaganski  <mike.kaganski@collabora.com>  [5950fe86b84bb062e88034e382fc5df90bb1e98c]

        tdf#164213: don't activate OLE objects in read-only mode
        
        Similar to the check done in SwEditWin::MouseButtonDown.
        
        Change-Id: I1a1b8966502a6b1557d424f28cfc1c1ecdf4b65e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177930
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-06  Christopher Sherlock  <chris.sherlock79@gmail.com>  [aefc769e62e5a5cba4ba62f9a8c10e8317d2868c]

        vcl: make Color parameters const in BitmapEx::createAlphaBlendFrame()
        
        Change-Id: I6d71552f4d5004477b5980fe6c8de710dd4aea9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177565
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [50bf9a5e979c3b16c67828de43a3b62790251762]

        Fix typo
        
        Change-Id: I93f5238a1e18f9a9335e6cdafc48711eb049e8dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177786
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-06  Jonathan Clark  <jonathan@libreoffice.org>  [9b2eaa37ba08b4d2c2f1c54a5fbbdaae19fbeedd]

        tdf#164106 Fix reordered glyph positioning with split grapheme clusters
        
        Due to formatting, grapheme clusters can possibly be split across
        multiple layouts. Layouts containing split grapheme clusters are created
        by laying out the complete string, and extracting only the necessary
        glyphs based on source codepoint index.
        
        This approach is good enough for most diacritic cases, but it cannot
        handle certain substitution cases where glyphs with advances would be
        interleaved with other layouts. Sub-layouts must be contiguous.
        
        This change introduces code to disable grapheme cluster splitting in
        these cases that cannot be handled correctly.
        
        Change-Id: I122abbf9c3f8a5efa4c72ad47991d0ad9ff8a8c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177927
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-06  Michael Weghorn  <m.weghorn@posteo.de>  [00df9cec579057853b781b43c336f2ec0c2a91ed]

        tdf#130857 qt weld: Implement QtInstanceTreeView::clear
        
        Used e.g. in RTSDevicePage::FillValueBox
        (i.e. in the "File" -> "Printer Settings" -> "Properties"
        dialog).
        
        Change-Id: Ice39b266b366a6fd6b37b6ece28cee529990dc80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177909
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-06  Eike Rathke  <erack@redhat.com>  [6926c820ceea1a1337a97b0afda95b072027a6ff]

        Resolves: tdf#164124 Do not trap incomplete date 2021-6/1 as fraction
        
        In fact do not accept anything else than blanks after integer
        portion for a fraction.
        
        Change-Id: I29746bb7cd78ecc6a7810e8841bee748589a36e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177899
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f232952e727c50cc3a5927ff3b082f88e36c9bed]

        crashtesting: HLINK_MARK embedded null import from forum-mso-en4-7137.doc
        
        which causes problems on export to docx. Sanitize at the original
        import.
        
        Change-Id: I8b9fa86465c455fe872c41386889dc54e38eb9ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177904
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-05  Szymon Kłos  <szymon.klos@collabora.com>  [2d7ab2b66bf1266246fcbab6e428faf0af94d913]

        jsdialog: weld::Menu
        
        - weld::Menu doesn't have base with weld::Widget
        - use separate container, only one menu per WindowId
        - first only send menu and cancel, when user activates
          option we will send another request and execute entry
          as menu can be blocking
        - there is connect_activated way of async setup too
        
        Change-Id: Iea03f82a91ecc19af67b91f85364675c119056ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177722
        (cherry picked from commit efeb511607dacce991866bcf328c96a01ab594f9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177852
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [f975b8418573b887cdc3269bcefa54bde6d60fa1]

        a11y: Drop SAL_LOPLUGIN_ANNOTATE("crosscast")
        
        Added in:
        
            commit d66a97d5622bfc7c8d68452eb5a3c2378b0b1820
            Date:   Thu Jan 12 08:29:24 2023 +0100
        
                loplugin:crosscast (clang-cl)
        
                > winaccessibility/source/service/AccTopWindowListener.cxx(47,36): error: suspicious dynamic cross cast from 'css::accessibility::XAccessible *' to 'VCLXAccessibleComponent *' [loplugin:crosscast]
                >     else if (auto pvclxcomponent = dynamic_cast<VCLXAccessibleComponent*>(pAccessible))
                >                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
                Change-Id: Iee7585dd2fa0d92af3be6b89d7d08326de3d1e7b
                Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145380
                Tested-by: Jenkins
                Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        
        AccTopWindowListener::HandleWindowOpened no longer does
        that crosscast now, see
        
            Change-Id: Ic96d2c95128af144c7769aac40707299b1c80f8c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 14:07:52 2024 +0000
        
                tdf#164093 tdf#157001 wina11y: Use vcl::Window's actual XAccessible
        
        Change-Id: Ifca76a5d519099f9cbe06f8bde606e01871363fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177891
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [b608604d0bbecdc24a17175374581b4e2d720658]

        tdf#164093 tdf#157001 wina11y: Use vcl::Window's actual XAccessible
        
        By default, a vcl::Window's XAccessible is its
        VCLXWindow (toolkit peer):
        
            css::uno::Reference< css::accessibility::XAccessible > Window::CreateAccessible()
            {
                css::uno::Reference< css::accessibility::XAccessible > xAcc( GetComponentInterface(), css::uno::UNO_QUERY );
                return xAcc;
            }
        
        However, that's a virtual method and subclasses can
        return a different XAccessible.
        MenuFloatingWindow::CreateAccessible returns the
        accessible of its menu.
        
        However, winaccessibility's AccTopWindowListener
        code was relying on the Window's XAccessible always
        being its VCLXWindow.
        
        The VLCXWindow is passed as a param in the
        XTopWindowListener methods, and AccTopWindowListener
        was querying it for the XAccessible interface, and
        then calling XAccessible::getAccessibleContext in
        order to retrieve the XAccessibleContext for the
        window.
        
        This is incorrect if the Window actually has another
        XAccessible.
        
        For the df#164093 scenario with NVDA running, opening and
        closing the sidebar popup menu would result in the
        VCLXWindow's VCLXWindow::getAccessibleContext menu
        getting called, which calls VCLXWindow::CreateAccessibleContext
        and the VCLXWindow would keep a reference to the
        returned XAccessibleContext and dispose it when
        the VLCXWindow itself gets disposed.
        However, AccessibleFactory::createAccessibleContext
        (called by VCLXWindow::CreateAccessibleContext)
        doesn't actually create a new object for the
        MenuFloatingWindow's accessible, but returns the
        existing accessible object of the PopupMenu, which is
        owned by the PopupMenu, not the MenuFloatingWindow,
        s.a. previous commit
        
            Change-Id: Ia2931bee23204395e8b3396927acf4fa1d0f077c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Dec 5 11:06:48 2024 +0000
        
                tdf#164093 tdf#157001 a11y: Improve menu window disposal
        
        for more details.
        
        Backtrace of how that accessible context was returned:
        
            1 `anonymous namespace'::AccessibleFactory::createAccessibleContext acc_factory.cxx 305 0x7fffbc160767
            2 VCLXWindow::CreateAccessibleContext vclxwindow.cxx 879 0x7fffc0b1bc67
            3 VCLXWindow::getAccessibleContext vclxwindow.cxx 2418 0x7fffc0b2670b
            4 AccTopWindowListener::HandleWindowOpened AccTopWindowListener.cxx 60 0x7fffe5c32ab6
            5 AccTopWindowListener::windowOpened AccTopWindowListener.cxx 119 0x7fffe5c3375e
            6 ``anonymous namespace'::VCLXToolkit::callTopWindowListeners'::`2'::<lambda_1>::operator() vclxtoolkit.cxx 2364 0x7fffc0af27ef
            7 comphelper::OInterfaceContainerHelper4<com::sun::star::awt::XTopWindowListener>::forEach<``anonymous namespace'::VCLXToolkit::callTopWindowListeners'::`2'::<lambda_1>> interfacecontainer4.hxx 349 0x7fffc0ae7f9e
            8 `anonymous namespace'::VCLXToolkit::callTopWindowListeners vclxtoolkit.cxx 2359 0x7fffc0afeaed
            9 `anonymous namespace'::VCLXToolkit::eventListenerHandler vclxtoolkit.cxx 2295 0x7fffc0b02492
            10 `anonymous namespace'::VCLXToolkit::LinkStubeventListenerHandler vclxtoolkit.cxx 2288 0x7fffc0afbdf6
            11 Link<VclSimpleEvent &,void>::Call link.hxx 111 0x7fffbfba33d3
            12 VclEventListeners::Call vclevent.cxx 47 0x7fffbfba35f1
            13 Application::ImplCallEventListeners svapp.cxx 733 0x7fffbfb76dbb
            14 vcl::Window::CallEventListeners event.cxx 229 0x7fffbf45f841
            15 vcl::Window::ImplSetReallyVisible window.cxx 1331 0x7fffbf566bad
            16 vcl::Window::ImplSetReallyVisible window.cxx 1344 0x7fffbf566c7d
            17 vcl::Window::Show window.cxx 2336 0x7fffbf56a8d1
            18 vcl::Window::Show window.cxx 2349 0x7fffbf56a9ce
            19 FloatingWindow::StartPopupMode floatwin.cxx 825 0x7fffbf46a702
            20 PopupMenu::Run menu.cxx 3018 0x7fffbf4a6f02
            ... <More>
        
        When the MenuFloatingWindow gets disposed, its
        VCLXWindow is also disposed. Since it incorrectly
        assumes it (or its Window) owns the XAccessibleContext,
        it disposes that as well:
        
            1 OAccessibleMenuBaseComponent::disposing accessiblemenubasecomponent.cxx 608 0x7fffbf300c82
            2 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7fffe199964a
            3 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2,com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose compbase.hxx 90 0x7fffdb8d1820
            4 VCLXWindow::dispose vclxwindow.cxx 938 0x7fffc0b24012
            5 UnoWrapper::WindowDestroyed unowrapper.cxx 302 0x7fffc0cfddc6
            6 vcl::Window::dispose window.cxx 220 0x7fffbf56e68f
            7 SystemWindow::dispose syswin.cxx 107 0x7fffbf515606
            8 FloatingWindow::dispose floatwin.cxx 225 0x7fffbf46b751
            9 MenuFloatingWindow::dispose menufloatingwindow.cxx 134 0x7fffbf4bd766
            10 VclReferenceBase::disposeOnce vclreferencebase.cxx 39 0x7fffbf7520d9
            11 VclPtr<vcl::Window>::disposeAndClear vclptr.hxx 207 0x7fffbf3f98d2
            12 PopupMenu::ImplExecute menu.cxx 2947 0x7fffbf4a0ee7
            13 PopupMenu::Execute menu.cxx 2834 0x7fffbf49c392
            14 MenuButton::ExecuteMenu menubtn.cxx 77 0x7fffbf639f1d
            15 MenuButton::MouseButtonDown menubtn.cxx 214 0x7fffbf63a847
            16 ImplHandleMouseEvent winproc.cxx 708 0x7fffbf57ca27
            17 ImplHandleSalMouseButtonDown winproc.cxx 2338 0x7fffbf57e1af
            18 ImplWindowFrameProc winproc.cxx 2683 0x7fffbf57fc07
            19 SalFrame::CallCallback salframe.hxx 312 0x7fffbf3443c6
            20 ImplHandleMouseMsg salframe.cxx 3415 0x7fffbc818e8f
            ... <More>
        
        However, the Menu that actually owns the accessible may
        still be alive, and then opening the menu again results
        in an attempt to make use of the already disposed object,
        triggering a crash due to a DisposedException being thrown:
        
            1   RaiseException                                            KERNELBASE                           0x7ff808e8b699
            2   CxxThrowException                                         VCRUNTIME140                         0x7fffef535267
            3   comphelper::OCommonAccessibleComponent::ensureAlive       accessiblecomponenthelper.cxx   141  0x7fffdb8d1937
            4   comphelper::OContextEntryGuard::OContextEntryGuard        accessiblecontexthelper.hxx     64   0x7fffbf2fb8eb
            5   comphelper::OExternalLockGuard::OExternalLockGuard        accessiblecontexthelper.hxx     81   0x7fffbf2fb948
            6   OAccessibleMenuBaseComponent::getAccessibleContext        accessiblemenubasecomponent.cxx 641  0x7fffbf301337
            7   VCLXAccessibleComponent::ProcessWindowChildEvent          vclxaccessiblecomponent.cxx     165  0x7fffc0a9596d
            8   VCLXAccessibleComponent::WindowChildEventListener         vclxaccessiblecomponent.cxx     124  0x7fffc0a96669
            9   VCLXAccessibleComponent::LinkStubWindowChildEventListener vclxaccessiblecomponent.cxx     114  0x7fffc0a957f6
            10  Link<VclWindowEvent &,void>::Call                         link.hxx                        111  0x7fffbf45f7d3
            11  vcl::Window::CallEventListeners                           event.cxx                       300  0x7fffbf45fe0c
            12  vcl::Window::ImplSetReallyVisible                         window.cxx                      1331 0x7fffbf566bad
            13  vcl::Window::ImplSetReallyVisible                         window.cxx                      1344 0x7fffbf566c7d
            14  vcl::Window::Show                                         window.cxx                      2336 0x7fffbf56a8d1
            15  vcl::Window::Show                                         window.cxx                      2349 0x7fffbf56a9ce
            16  FloatingWindow::StartPopupMode                            floatwin.cxx                    825  0x7fffbf46a702
            17  PopupMenu::Run                                            menu.cxx                        3018 0x7fffbf4a6f02
            18  PopupMenu::ImplExecute                                    menu.cxx                        3005 0x7fffbf4a1707
            19  PopupMenu::Execute                                        menu.cxx                        2834 0x7fffbf49c392
            20  MenuButton::ExecuteMenu                                   menubtn.cxx                     77   0x7fffbf639f1d
            ... <More>
        
        To fix that, adjust winaccessibility's
        AccTopWindowListener to no longer just use
        the VCLXWindow for the accessible, but
        get the vcl::Window for the VCLXWindow and
        query it's actual XAccessible using
        vcl::Window::GetAccessible().
        
        This fixes the tdf#164093 crash. The problem of
        tdf#157001 where items in the popup menu of Calc's organize
        template dialog are only announced the first time the menu
        is opened still remains for now, but is also somehow
        related to the MenuFloatingWindow being disposed.
        (No longer reproducible when no longer calling
        the base class FloatingWindow::dispose from
        MenuFloatingWindow::dispose in a local test,
        still needs further analysis.)
        
        Change-Id: Ic96d2c95128af144c7769aac40707299b1c80f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177889
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [eed855d70317ce25d267c28b28c0f40f8e7b69cb]

        wina11y: Use existing references + drop duplicate checks
        
        There's no need to have local raw pointer variables
        in addition to the existing References.
        Replace all uses of the former by using the latter
        and drop duplicate checks.
        
        Change-Id: I1339dabecbe8e1652e49df8ecd5ce2749b897f47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177888
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [f40a68f58dd1fc8b4cbd89434559c3400e7bd39b]

        wina11y: Drop unnecessary exception handling
        
        Window::GetSystemData should never throw an
        exception, so there's no need for exception
        handling here. Also, return early if the
        system data is null.
        
        Change-Id: I65794f10019d0c2fb5cc7150500b551c31cc2a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177887
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [c82a5669bc996bc23baebb3838fbabc629ef5d75]

        vcl: Return reference in SalFrame::GetSystemData
        
        ... instead of a pointer, to make clear
        that this is always non-null.
        
        Change-Id: I4c8676913b2507f077d8a66973ab5f95e73cb497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177886
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [4453b2f65b13d6b7c11344f89695a2a01aaf955d]

        vcl: Return reference in SalObject::GetSystemData
        
        ... instead of a pointer, to make clear
        that this is always non-null.
        
        Change-Id: Ic0f92e672b08494cf3bfaa9a956cb78170bc1ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177885
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [070b198961977ec0a3197d1ac85aa065b62c432c]

        wina11y: Drop duplicate variable + check
        
        No need to have `pAccessibleContext` as a raw
        pointer, just use the `xContext`. And that one
        has already been checked for being a non-empty
        Reference above.
        
        Change-Id: I15d7e70ddbc8b260e5e1bc0eb4e190c54d6a2ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177884
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [6708246e20ce522e673f539369cd38687d2dd16d]

        tdf#164093 tdf#157001 a11y: Improve menu window disposal
        
        In MenuFloatingWindow::dispose, unset the accessible
        before calling the base class implementation, to prevent
        the accessible from getting disposed there as well.
        This is necessary because the MenuFloatingWindow
        doesn't create (and therefore own) its accessible
        object, but returns that from its menu in
        MenuFloatingWindow::CreateAccessible. Therefore,
        the PopupMenu as the owner is responsible for disposing the
        accessible as well, not the MenuFloatingWindow.
        
        This logic was already implemented in Menu::dispose,
        but that doesn't help in cases where the MenuFloatingWindow
        gets disposed independently.
        
        In Menu::dispose, drop the extra logic
        and just call `m_pWindow.disposeAndClear`
        so that MenuFloatingWindow::dispose can
        take care of everything that's needed.
        (For the MenuBar case, MenuBar::dispose
        calls MenuBar::ImplDestroy, which unsets
        Menu::m_pWindow, so other than for PopupMenu,
        this change to MenuBar::ImplDestroy method doesn't
        make a difference for that class.)
        
        Don't dispose the current Menu::m_pWindow in
        PopupMenu::FinishRun, but instead in
        PopupMenu::ImplExecute (if set) before assigning
        a new one, to ensure that the old one gets disposed.
        Drop the
        
            SAL_WARN_IF(GetWindow(), "vcl", "Win?!");
        
        because that case is handled fine now. Without this
        change in place, I saw that warning getting triggered
        while debugging (potentially because PopupMenu::FinishRun
        never got reached as the menu didn't show,  maybe due to
        switching focus to the IDE when reaching a breakpoint
        or different timing,...).
        
        This commit by itself doesn't yet fix the crash
        from tdf#164093 seen on Windows with NVDA running
        because the menu's accessible still incorrectly gets
        disposed by the MenuFloatingWindow's VCLXWindow
        (toolkit window peer). That will be addressed
        in a separate commit.
        
        Change-Id: Ia2931bee23204395e8b3396927acf4fa1d0f077c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177883
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [13a9a236adae972f360753a399bc47fda34a51d4]

        wina11y: Drop special combobox handling in AccessBridgeHandleExistingWindow
        
        It's unclear to me why the list child's accessible should
        be passed instead of the window's here.
        
        In addition, AccessBridgeHandleExistingWindow is only relevant
        when the AT brigde is started, i.e. for example when starting
        a screen reader while LO has been running already. This makes
        this look even less relevant and unclear to me why special handling
        would be applied for that case, but not when a combobox popup
        is shown when a11y has been active before already.
        
        Change-Id: Ie7b16de36889e2432f6ac9455ab297ca16d3b26e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177882
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [9084c484c0596dc1dc17eef0247bd2475e060d4a]

        wina11y: Drop always true bShow param
        
        Change-Id: I794e486b3e5e7d341a05cec20cc218dd2cd7e242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177881
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [db366ebcde00ead8d2a37589c147bd867ed6e455]

        wina11y: Replace condition by by assert in AccessBridgeHandleExistingWindow
        
        The method only gets called from AccessBridgeUpdateOldTopWindows
        which always passes a non-null window.
        
        Change-Id: I7d6d4effb75c722af6176257b8f296b5a77734cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177880
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [5ce6b81d4dc599ed4470f164b221eeefd07f7fba]

        wina11y: Drop unnecessary cast to sal_uInt16
        
        Application::GetTopWindow also takes a tools::Long param,
        so there's no reason to cast to sal_uInt16.
        
        Change-Id: Ic592262bee8173329986ccb83298a26deb3586b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177879
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [d1c40cfda530cc249ba1daa0bbb8dc71ffbc2d46]

        wina11y: Make these 2 methods non-virtual
        
        Change-Id: I791ec6d822573e18c981343d3ce8371acf0b3b38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177878
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [8a762c35ea517c1ac24d7ca20e190144d5413e71]

        a11y: Update comment wrt reference being (not) weak
        
        This was using a weak reference when the comment
        was added in
        
            commit 9b34eb7c8512ebc2a7788692a0c826d4e384d460
            Author: Frank Schönheit <fs@openoffice.org>
            Date:   Thu Apr 25 10:24:33 2002 +0000
        
                #98750# be an XEventListener at the AccessibleContext
        
        , but later changed to be a hard reference in
        
            commit 23d689d4e43986c10372da0dd756dbcecd82beb8
            Author: Thomas Benisch <tbe@openoffice.org>
            Date:   Thu Nov 7 16:19:24 2002 +0000
        
                #103674# change the reference to the accessible context from weak to hard
        
        . Unfortunately that commit only references a StarDivision
        internal ticket, so the exact reason remains unclear,
        but at least update the comment.
        
        Change-Id: Icdc9aec97647ae05ae7fb3f2bdc1be43c3a62619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177848
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [ab38826d9005d206600bfc94d6b7b4986480ecce]

        vcl a11y: Use comphelper::disposeComponent
        
        Change-Id: Ifc63db272484e9a7986e6113989f2f6274f40349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Mike Saunders  <mike.saunders@documentfoundation.org>  [0e88a69ff0e23b85b19e9566a7daba120796ad4f]

        Change infobar donate message after discussions in Marketing
        
        Telegram group.
        
        Change-Id: Ib0ab77fafde0a7a5abc719a7eec9ef32615f15c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177853
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-05  Pranam Lashkari  <lpranam@collabora.com>  [c9763a9f160bd0e91a19cfb681556f49a28cbac5]

        LOK: don't recreate the dialogs of an old view when loading new views
        
        follow up for f5ebf512ccd3d5ae3af5fe706b411a85fa19182d
        
        now same actions are performed on all the dialogs
        
        Change-Id: I6531a766327dda106770a2c513ebd492dea7c655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176933
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2fba6df7242586870988b62909156538b42c2bc0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177892
        Tested-by: Jenkins

2024-12-05  Avramoniu Calin  <clavramoniu@gmail.com>  [eea90af52e744d64c3d6ffd49c8859572450aed4]

        tdf#163419 Save import dialog window size and skip resizing separator options
        
        Signed-off-by: Avramoniu Calin <clavramoniu@gmail.com>
        Change-Id: Ib894b61edc15d4a89e7a83bb990a2819084879f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177397
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-12-05  Heiko Tietze  <tietze.heiko@gmail.com>  [ad5e52d266b95753b3b836c701a079ecc7ba33b4]

        Related tdf#164034 - Enable ProtectedSpace by default
        
        Make non-breaking space and hypen visible
        
        Change-Id: Ibe088c752b9d8378bb167133df3c8fdeacf1f1eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177850
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-05  Miklos Vajna  <vmiklos@collabora.com>  [0a535147f9bed7856e7ab3513fe3f6c38549a099]

        cool#9992 doc electronic sign: make return type for .uno:Signature consistent
        
        It turns out the majority of getCommandValues() return values specify a
        commandName and a commandValues key, which is helpful when we don't
        track the request for this reply.
        
        Fix .uno:Signature to do the same for consistency.
        
        Change-Id: I46ffe5c36047ef2b59113d0221a1874ba28d335b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177857
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [acd9e2165c42f0d6977e1ffd883983fe33c5d073]

        crashtesting: HLINK embedded null import from ooo98294-1.doc
        
        which causes problems on export to docx. Sanitize at the original
        import.
        
        Change-Id: I3b5521dac6a2b6926db6362d33500b11f0a69098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bce744550d80b66a6889ebb9dc2814f9644f978e]

        Fix typo
        
        Change-Id: I0b9be4ea10c3837007158771fde46ad70e5c52a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177785
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-12-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [04de71cb67d913866a6377a35fb02ac6debc1e86]

        Fix typo
        
        Change-Id: Ia445fefad176685a8e4d3f78372b33e219c7832d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177704
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-12-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c68d4501b9607536352e84d36066ec27e9471e7f]

        Fix typo
        
        Change-Id: I8d9daaf14829e20dfd16817dcb7b90c18fb78939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177703
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [55e77a48fbafd47036d7bd3ba11579c5f15f2359]

        gtk4: GtkIconView doesn't have convert_widget_to_bin_window_coords
        
        but still has the same problem as the gtk3 iconview with reporting
        positions when scrolled
        
        a problem since:
        
        commit a36a58933a1e07d3f54bacd5c2fe8ca53063a63a
        CommitDate: Wed Dec 4 07:40:30 2024 +0100
        
            sd: convert sidebar masterpage panels from drawingview to iconview
        
        Change-Id: Ice549b40d88c5d2063e37ccb63490e3537736d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-05  Mike Kaganski  <mike.kaganski@collabora.com>  [a81c1e16516dccd0e4a37c4ea5d37e9c85b5a3d7]

        Get SwFieldType after broadcast
        
        A crash was reported in HasOnlyOneListener, with the following call stack:
        
         ntdll.dll!KiUserExceptionDispatch()
         swlo.dll!SwModify::HasOnlyOneListener() Line 204
         swlo.dll!SwFormatField::~SwFormatField() Line 142
         swlo.dll!SwHistorySetTextField::`scalar deleting destructor'(unsigned int)
         swlo.dll!std::default_delete<SwHistoryHint>::operator()(SwHistoryHint *) Line 3090
         swlo.dll!std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>::{dtor}() Line 3198
         swlo.dll!std::destroy_at(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * const) Line 311
         swlo.dll!std::_Default_allocator_traits<std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::destroy(std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>> &) Line 688
         swlo.dll!std::_Destroy_range(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * _First, std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * const) Line 905
         swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::_Destroy(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * _Last, std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> *) Line 1667
         swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::_Tidy() Line 1751
         swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::~vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>() Line 699
         swlo.dll!SwUndoSaveContent::~SwUndoSaveContent() Line 740
         swlo.dll!SwUndoDelete::~SwUndoDelete() Line 633
         swlo.dll!SwUndoDelete::`scalar deleting destructor'(unsigned int)
         svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090
         svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198
         svllo.dll!std::destroy_at(MarkedUndoAction * const) Line 311
         svllo.dll!std::_Default_allocator_traits<std::allocator<MarkedUndoAction>>::destroy(std::allocator<MarkedUndoAction> &) Line 688
         svllo.dll!std::_Destroy_range(MarkedUndoAction * _First, MarkedUndoAction * const) Line 905
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Destroy(MarkedUndoAction * _Last, MarkedUndoAction *) Line 1667
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Tidy() Line 1751
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::~vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>() Line 699
         svllo.dll!SfxUndoArray::{dtor}() Line 1389
         svllo.dll!SfxListUndoAction::~SfxListUndoAction() Line 1318
         svllo.dll!SfxListUndoAction::`vector deleting destructor'(unsigned int)
         svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090
         svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198
         svllo.dll!std::destroy_at(MarkedUndoAction * const) Line 311
         svllo.dll!std::_Default_allocator_traits<std::allocator<MarkedUndoAction>>::destroy(std::allocator<MarkedUndoAction> &) Line 688
         svllo.dll!std::_Destroy_range(MarkedUndoAction * _First, MarkedUndoAction * const) Line 905
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Destroy(MarkedUndoAction * _Last, MarkedUndoAction *) Line 1667
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Tidy() Line 1751
         svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::~vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>() Line 699
         svllo.dll!SfxUndoArray::{dtor}() Line 1389
         svllo.dll!SfxListUndoAction::~SfxListUndoAction() Line 1318
         svllo.dll!SfxListUndoAction::`vector deleting destructor'(unsigned int)
         svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090
         svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198
         svllo.dll!std::destroy_at(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * const) Line 311
         svllo.dll!std::_Default_allocator_traits<std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::destroy(std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>> &) Line 688
         svllo.dll!std::_Destroy_range(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * _First, std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * const) Line 905
         svllo.dll!std::vector<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>,std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::_Destroy(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * _Last, std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> *) Line 1667
         svllo.dll!std::vector<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>,std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::clear() Line 1442
         svllo.dll!svl::undo::impl::UndoManagerGuard::~UndoManagerGuard() Line 325
         svllo.dll!SfxUndoManager::ImplClearRedo_NoLock(const bool i_currentLevel) Line 468
         swlo.dll!sw::DocumentContentOperationsManager::InsertPoolItem(const SwPaM & rRg, const SfxPoolItem & rHt, const SetAttrMode nFlags, const SwRootFrame * pLayout, SwTextAttr * * ppNewTextAttr) Line 3694
         swlo.dll!SwXTextField::attach(const com::sun::star::uno::Reference<com::sun::star::text::XTextRange> & xTextRange) Line 1972
         swlo.dll!SwXText::insertTextContent(const com::sun::star::uno::Reference<com::sun::star::text::XTextRange> & xRange, const com::sun::star::uno::Reference<com::sun::star::text::XTextContent> & xContent, unsigned char bAbsorb) Line 606
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
         binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
         binaryurplo.dll!request(void * pThreadSpecificData) Line 84
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
         cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169
         cppu3.dll!threadFunc(void * param) Line 190
         sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67
        
        I don't know why pType->Which() succeeded before the broadcast and reset,
        and pType->HasOnlyOneListener() crashed; field destructors themselves do
        not seem to destroy their types (except SwDBField, which is handled here
        explicitly). My blind guess is, that a change could happen in broadcast.
        
        Change-Id: I5c7f07da2e1283510bce3a3e3e80b6f8d849f38b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177854
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [73a46895c5927d68a222b13dc811ea1cceb811a1]

        tdf#119840 speed up SearchForStyleAnchor
        
        no need to copy things to a std::deque, it is quite straightforward to
        just iterate over the SwNodes structure.
        
        Shaves off about 30% of the time spent processing post-load.
        
        Change-Id: I852079c18738299be04cec52b82e0f6949f2d81c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177837
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-05  Heiko Tietze  <tietze.heiko@gmail.com>  [139bb786bb4fe5cf2554f6016095ff1588f3994f]

        Resolves tdf#164034 - Rename Non-breaking Spaces
        
        The option also affects hyphen and the label should reflect this
        
        Change-Id: I5e092f8c5d67c1c039de709d024c89481b40a82d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177841
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-05  Jonathan Clark  <jonathan@libreoffice.org>  [dfa81bdb3a7956d631c8ccb1e00166289d37993e]

        tdf#162750 sw: Fix layout with small caps inside ligatures
        
        Previously, Writer was not correctly terminating layout contexts at the
        starts of small caps spans. This could cause incorrect character
        placement in certain cases.
        
        Regression since:
        
        Commit 30d376fb7ded4c96c85ad1112a0e44b5929657c9
            "tdf#61444 Correct Writer text layout across formatting changes"
        
        and
        
        Commit ab0a4543cab77ae0c7c0a79feb8aebab71163dd7
            "tdf#124116 Correct Writer text shaping across formatting changes"
        
        Change-Id: I863b9b66356eb0a9efb5bbdc75e80b43d56aaaf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177839
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [5776d98616a93b5e77326ddf205a239b2f8ca016]

        tdf#130857 qt weld: Notify when receiving/losing focus
        
        In QtInstanceWidget, connect to the QApplication::focusChanged
        signal [1] and when either the old or the new focus widget
        is the one belonging to this QtInstanceWidget, notify
        about the lost/gained focus.
        
        With this in place, SvxSearchDialog::FocusHdl_Impl
        now gets called in a WIP branch where support for the
        "Find and Replace" dialog is declared when moving
        focus into one of the comboboxes in that dialog.
        
        [1] https://doc.qt.io/qt-6/qapplication.html#focusChanged
        
        Change-Id: I15190cf9b0d2e72d78a57f58da7ff2ebd1e7a6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177835
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [4a309551927898f97d1a9b2dce8050e021bbfd34]

        weld: Add weld::Widget::signal_* methods to call handlers
        
        Similar to what already exists in most subclasses,
        add signal_<event_name> methods to call the handlers
        and use these in the subclasses instead of calling
        the handlers directly.
        
        Change-Id: I6b79ddd859b360e947d97ada57f1573a276d6177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177834
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [2d0d3500c29a5e31a6e6ecf86aa7bc604a537a1c]

        tdf#130857 qt weld: Let QtInstanceWidget derive from QObject
        
        Also add Q_OBJECT macros for all subclasses
        that didn't have them and run moc for them, too.
        
        Change-Id: Ia42ee7d02b68d54df308d33c88bf286468bfa68f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177833
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [44b2a3d53646bd3c55993af29121d007fb177c55]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_extents_relative_to
        
        This e.g. gets called when pressing the "Find Next" button
        in the "Find and Replace" dialog.
        
        Change-Id: I30e33d52d19b0afe44564486bfa79e3b500ae856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177832
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [5614c39745e43ed105b2308dc4f4107fbf5f0fe3]

        tdf#130857 qt weld: Signal combobox text change
        
        As the comment for weld::ComboBox::connect_changed
        (in vcl/include/weld.hxx) says:
        
            /* m_aChangeHdl is called when the active item is changed. The can be due
               to the user selecting a different item from the list or while typing
               into the entry of a combo box with an entry.
        
               Use changed_by_direct_pick() to discover whether an item was actually explicitly
               selected, e.g. from the menu.
             */
            void connect_changed(const Link<ComboBox&, void>& rLink) { m_aChangeHdl = rLink; }
        
        QComboBox::currentIndexChanged is not emitted while
        typing in an editable combobox, so connect to the
        QComboBox::editTextChanged signal in addition.
        
        Also, hold the SolarMutex when calling the signal handler.
        
        QtInstanceComboBox::changed_by_direct_pick isn't implemented
        yet, but would trigger an assert when called, so this doesn't
        go unnoticed at least.
        
        Witht this commit in change, typing in the "Find"
        combobox in the "Find and Replace" dialog in a WIP
        branch declaring support for that dialog now results
        in the buttons getting enabled or disabled as expected
        (disabled when text is empty, enabled when non-empty).
        
        Change-Id: I9b89b3a3c8b5ed7ebdeda7b486bdbf2f7e54fd86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177831
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [abfb229bbe90367f218c0a03d8ecb11b5c14488c]

        tdf#130857 qt weld: Hold SolarMutex when signalling checkbox toggle
        
        Not doing so would e.g. trigger an assert when
        toggling the "Match case" checkbox in the "Find and Replace"
        dialog in a WIP branch where support for that dialog with
        native widgets is declared.
        
        Change-Id: I5dc95e81e81bceaf258ecba6e55dfa280dfdd572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177830
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [e6bf5124be8b898649b6221d23960aacb7602d0e]

        tdf#130857 qt weld: Implement QtInstanceComboBox::set_entry_message_type
        
        Reuse the logic previously implemented in
        QtInstanceEntry::set_message_type by moving it to a
        static helper method that takes a QLineEdit* param,
        and for QtInstanceComboBox::set_entry_message_type,
        pass the combo box's line edit.
        
        Change-Id: I8e81c9473da294d2a8c863ed143d735c30ade2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177829
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [4aa9b7a0bbcca4352a838962838c3311c44d7442]

        tdf#130857 qt weld: Implement QtInstanceWindow::{g,s}et_window_state
        
        Map to/from what looks like the corresponding QWidget
        equivalents.
        No explicit testing done.
        
        Change-Id: I47152c8789223372c49ea60f774d0a04a64db2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177828
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [d1243097a39375e98ef2fbc8a87be549e16275ff]

        tdf#130857 qt weld: Implement QtInstanceWindow::get_{size,position}
        
        These are needed e.g. for the "Find and Replace" dialog.
        Use the QWidget::geometry property [1] for now.
        An alternative to consider might be QWidget::frameGeometry [2].
        
        At least on Wayland, screen positions are not available
        anyway, however.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#geometry-prop
        [2] https://doc.qt.io/qt-6/qwidget.html#frameGeometry-prop
        
        Change-Id: I2449d8be688c17a4abb58ba424c966dde0e30e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177827
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Michael Weghorn  <m.weghorn@posteo.de>  [33c7d3a3e16c2c8db31e30d9daf302263449ed0d]

        tdf#130857 qt weld: Implement QtInstanceWidget::set_background
        
        Used e.g. by the "Find and Replace" dialog (Ctrl+H).
        
        Change-Id: Ie181eea1600616ddb6a8044864df221ac4bb108d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177826
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [293d03e6803be57af7a3948e358e7ed9f8545c13]

        tdf#160487 - PPTX export: fix "Fit height to text"
        
        attribute of drawing objects (placeholders)
        
        Export spAutoFit attribute correctly to ooxml.
        
        Change-Id: I57e5b21bd6c407bdb5d1b36b3c3674249fbd2f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177798
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-05  Christopher Sherlock  <chris.sherlock79@gmail.com>  [9b4cbd876b5eba07bfb00bc4eeef1b179b37fbb6]

        vcl: move variables closer to first usage
        
        Change-Id: Ib09f054eca56d55ba6b91c8e2377f373fc615430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177808
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-05  Rosh  <roshsiddiq@gmail.com>  [f5976b8d0b826c0273b616699d1af639beb9f2f1]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I54fbdebbd5287f1e832ed662986b8b3fa45fbe45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177583
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-05  Andre Herbst  <moormaster@gmx.net>  [112736d1ea5234a66c669e2b2999229f33f05c71]

        tdf#163752 fix: hide drag target border on cancellation of d&d operation
        
        Not relying on rData.pCellTransfer anymore since it is always null
        when rEvt.mbLeaving is true.
        
        Change-Id: I4755e8f9b62efacd2eb4d515e1993578beadef09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175970
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-05  Dr. David Alan Gilbert  <dave@treblig.org>  [abfbca2719767516d5a35ee641ddd0d96d93e4ea]

        tdf#85428: Clip strokes
        
        Clip stroke paths coming from the PDF import.
        Similar to my previous patches for fills.
        
        (It's possible we might have to do something clever with cropping
        of arrows/etc but not sure yet)
        
        Change-Id: I9e46deac4a722e3ac510f0cc4bdb6b38b67c579e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176952
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ffd1e31b17965646fe4893e9a393fab3294b383]

        gpgme: upgrade to 1.24.1
        
        * external/gpgmepp/gettid.patch issue fixed upstream
        
        Downloaded from https://gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.1.tar.bz2
        
        Change-Id: Id2d984f5e68b8681bf5e635a1afe5d90605711ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177821
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [393565203e9027fe3ed0ff64cd46fdc1332ec480]

        sw: static_cast after dynamic_cast
        
        Change-Id: Ie50fd8bb2bbb26962ead459fe8014828c99fd755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177789
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [e3c9a06b7056e2b99628aef8005329c328bcab91]

        a11y: Use vcl CheckBox directly in VCLXAccessibleCheckBox
        
        ... instead of using the toolkit/UNO wrapper class
        VCLXCheckBox.
        
        Change-Id: I271535f3e2e46202e2ca3d2e3f9a1d05ac380c41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177815
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [1d2f37a93cb6746dfb08731579d269478943d2a0]

        a11y: Use FormattedField directly in SVTXAccessibleNumericField
        
        ... instead of using the toolkit/UNO wrapper
        SVTXNumericField.
        
        Change-Id: I86e274a06f210e2076e287087a1d4b979abe7c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177814
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [def785ee31bc71fc8edb4f717280265fa9f80b0a]

        a11y: Use vcl::Window instead of VCLXWindow right away
        
        Use the vcl::Window for the null check instead of the
        corresponding VCLXWindow. There's no need to
        use a toolkit class here, in particular since the
        vcl::Window is used later anyway.
        
        Change-Id: Ia2c80f9634eadf33601af8c9ea1f628e7ea3e96b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177813
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [739b0716504d2526fb7283100420e4bd5eacb7c2]

        a11y: Move menu a11y classes to vcl, no more use factory
        
        Other than most of the a11y implementations for vcl
        classes, VCLXAccessiblePopupMenu etc. do not
        make use of any VCLXWindow (i.e. UNO/toolkit wrapper of a
        vcl::Window) and thus do not depend on the toolkit
        module, which the accessibility module depends on.
        
        Therefore, there's also no need to use the accessible
        factory to create them (which is needed when toolkit
        classes are involved to avoid a dependency cycle).
        
        Move those classes from the accessibility module to
        vcl and add a new method Menu::CreateAccessible and
        move the logic from AccessibleFactory::createAccessible
        there. Drop the now unnecessary factory methods
        previously used for those classes.
        
        No change in behavior intended (yet), but this
        also simplifies the code involved for the
        tdf#164093 scenario.
        
        Change-Id: Ie3f6f1a02bf6662206d31383473cdc868e1f9164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177812
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [3d780e72b93773a25f796feb488b0fd878c490b5]

        Move helpers for css::awt/VCL point/rect/size to vcl::unohelper
        
        Move helpers to convert between the Rectangle, Point and Size
        classes in vcl and in css::awt from VCLUnoHelper (in the toolkit module)
        to vcl::unohelper (in the vcl module), for reuse in vcl in upcoming
        commits.
        
        Change-Id: I7b11c8a6b8c843a01ce25b1e4c0fb1869ad1e6ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177816
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [2449571a3ed5f0f5daeb60db6e740a5d830afa4a]

        a11y: Move action string header to vcl
        
        ... so these constants can be reused in vcl.
        
        See commit message of
        
            Change-Id: I6aeee104f271c804c85727002822b89a9263628f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Dec 4 11:45:44 2024 +0100
        
                a11y: Move CharacterAttributeshelper from accessibility to vcl
        
        for motivation.
        
        Change-Id: I1552c0a0111c81643ab9bb6f202c8a31662251d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177811
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [b28f16520bff4a8bd8b09661f7393a4d91a853f5]

        a11y: Move CharacterAttributeshelper from accessibility to vcl
        
        This is in preparation of moving more from
        the accessibility module to vcl.
        
        Currently, the a11y implementations for vcl widgets
        are implemented in the accessibility module (in
        directory of the same name), which in turn depends
        on the toolkit module.
        To break the dependency cycle (vcl needs accessibility
        to create a11y objects for its widgets), there's a UNO
        service.
        
        At least some a11y classes don't really need toolkit,
        however, so the plan is to decouple this and move those
        from the accessibility module into vcl in upcoming
        commits.
        
        Change-Id: I6aeee104f271c804c85727002822b89a9263628f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177810
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [a2c1a337f0bd02353433c2f944049e9f3ee72bcb]

        [API CHANGE] a11y: Drop XAccessibleExtendedComponent::getFont
        
        This method from the unpublished XAccessibleExtendedComponent
        interface is not used by any of the a11y platform bridges, and
        I don't know of any platform a11y API that would need it.
        
        In order to report character/font attributes, there is the
        XAccessibleText interface and its
        XAccessiText::getCharacterAttributes method instead, which
        actually gets used by the platform a11y bridges.
        
        Therefore, drop this method to simplify code, and also decouple
        the accessibility module a bit further from the toolkit
        module without having to reorganize code further.
        (VCLXFont from the toolkit module currently gets used in
        various implementations.)
        
        Change-Id: I06ea3cc5998a13927b3f869877b28f03ac07c89b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177809
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [7431507d247b6a5e867ae85647550f55d3641e31]

        toolkit: Pass VCLXFont init args in ctor
        
        Pass arguments right away in ctor rather than
        having a ctor that takes no arguments and then
        having to call VCLXFont::Init with the arguments
        right after calling the ctor.
        
        Change-Id: I651e27154499f61638409377438f9589bc7412a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177795
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [78ef285661c9f936c2bf2fa832c3aec7bbb1760a]

        Use '#pragma once' in vclxfont.hxx
        
        Change-Id: I445ec8a08c6622c681e459efc2dd2afbf74dd78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177794
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [75d734698347565253571978fd585f1681229a97]

        split up SwGetRefFieldType::FindAnchor method some more
        
        To make it easier to see the modifications I want to do to improve
        performance here.
        
        Change-Id: Icbb663b39905ce0fe82544bac7afd21314d4c7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-04  Christopher Sherlock  <chris.sherlock79@gmail.com>  [48d0d525d0cc579be2b1ba195ee797fd6f670276]

        vcl: fix call sites for createBlendFrame(), rename to createAlphaBlendFrame()
        
        The call sites are actually passing in transparency, in fact to be
        consistent with current conventions we are actually dealing with alpha
        values. So we need to take the transparent values at the call sites and
        convert to alpha values by just subtracting 255. Hence fixing the FIXME
        comment.
        
        Change-Id: Ibc55ea77f469ec8afcab0cc26d2b8cdf25ea8a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173858
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [285b66443303b8e240a6af48adb1f58bf4f8644e]

        split up SwGetRefFieldType::FindAnchor method
        
        to make it easier to read
        
        Change-Id: Ifaece90d4fb18be3caae9fd4afbbbdf64ff9d18a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177800
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d775d637b9ff7619aba195559deed6e9a341e372]

        crashtesting: failure to reimport forum-es-2526.odt after export to odt
        
        2nd arg to copy is len, not index. Probably a problem since:
        
        commit 12a7a3d57d3dcf222b13fa9143c37736f8ea3d0b
        CommitDate: Thu Sep 3 15:33:36 2020 +0200
        
            Fix crashtest fdo77855.odt
        
        in forum-es-2526.odt the input has:
        
        fo:border-=".009cm solid #595959"
        
        where 'fo:border-' is an unknown attr and "fo" ends up truncated to "f".
        On export and reimport the 'f' is further truncated to '' and we assert
        on this oddness.
        
        Change-Id: Ie85d81947504bf15b9caefb92477c7f977eb5cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177788
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-04  Johann Lorber  <jlorber@linagora.com>  [1ad425812aaa29d0f449a27350a86b90c18c626c]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Iac334c822ab0699b5cc5122e5f2b1a2b9662f58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177784
        Reviewed-by: Skyler Grey <skyler.grey@collabora.com>
        Tested-by: Jenkins

2024-12-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8fb31e76975124a12a070ec681bd410f05a18eed]

        bump product version to 25.8.0.0.alpha0+
        
        Change-Id: I8b5394fb5119e124240a567e99497337ff897686

2024-12-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d28ca0db5edd43b9e2bb82d78021b4c4eb276d4e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 6eca395810730a005bd24fcafa92eba4860350b9
          - update translations for master/25.2.0 Beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I291ff1a663a6689b727528a376ac200d4041281d
            
2024-12-04  Szymon Kłos  <szymon.klos@collabora.com>  [76be2970722faceda1552681d6d2ab942d350595]

        slideshow: lok: export hiden slide
        
        we need to be aware of hidden slides to make correct
        decision when doing "start from current slide" based
        on the slide number
        
        Change-Id: Ib4944c699fa2589026e4d8ae57766c83e0439d49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177775
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e90ebdde4110ea7e250f66327af1e3f4eeb8718f]

        cid#1636561 Dereference after null check
        
        Change-Id: I7a4c19d9344dba9c09861fe78b864a8651c3286f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177771
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [bc09a4f1ce1f6a714f7827a404aa6317b503d307]

        Disable subpixel AA in GraphicExporter::filter unconditionally
        
        ... in D2DWriteTextOutRenderer.
        
        Commit 785a56b6be7f3128c2e7a131381e02525a50eb6b (D2DWriteTextOutRenderer:
        use grayscale AA for file output, 2024-11-27) has disabled it only when
        the export settings explicitly specified a concrete AA setting. In case
        when the settings didn't specify explicitly, if AA should be used or not,
        then system settings were used, which in case of D2DWriteTextOutRenderer
        would still enable ClearType (subpixel AA).
        
        This stores additional flag in StyleSettings, similar to what was done
        in commit e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966 vcl: add
        a flag to determine if AA of fonts is used from the system, 2018-07-28),
        that tells the renderer to prevent subpixel AA, even if use of AA itself
        is defined by system settings. This flag is currently only considered by
        D2DWriteTextOutRenderer.
        
        Change-Id: Ibd1879d3c222276eee00c37a442881d6d47c831f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177780
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c613da01d02d45a140b94b391a142aede46e8b8]

        tdf#163010 inline and cache rDoc.GetCondFormat call
        
        which reduces save time to around 30s for me
        
        Change-Id: I6889312d25bd8f297f1c54f683496ef00e114d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fa6edf0b8625185fc19a76fc1e6268d99275cb0]

        tdf#163010 walk pattern by range
        
        which avoids a lot of lookup cost
        
        Change-Id: I9b030f3f8402f05a5c7b03c0147ff3ffc91d1cdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f70663c322209626bec08e3b63be6f0de663911]

        tdf#163010 include GetPattern here
        
        we are already at the column data level, no need to call via ScDocument
        
        Change-Id: Ib8b0bc0f1fd9782229dc6c5240f87c086bdc970c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177777
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e4dbbcd7a56f6b6b4827c0df3d2588d4a5ca3cfa]

        cid#1636563 Unchecked return value
        
        Change-Id: I8d9cf983ca8c96d1619aceff9113732814d09f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177773
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a1d7dd96ea89427f8b8e8553b5bf46302432c645]

        cid#1607257 Overflowed constant
        
        this shouldn't happen unless the rdb is broken
        
        Change-Id: I3e861d25a8c10243f03446ec8a7b44457186585a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177774
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [75235a0759160fea2a15c2eaf9f7155f218b898a]

        cid#1636560 silence Unchecked return value
        
        Change-Id: Iffb4b464ff124ffce19548a756d878130c10921a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177772
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [10d32939b1742f0eb935dc970d298c5f4b8b127c]

        gtk4: Unbreak --enable-gtk4 build
        
        gtk_icon_view_convert_widget_to_bin_window_coords was
        dropped in gtk commit [1]
        
            commit 8dc5e13e8c66cd260edff17dbaa10eedcc95ae1b
            Author: Timm Bäder <mail@baedert.org>
            Date:   Tue Jun 27 11:11:57 2017 +0200
        
                iconview: Remove bin_window
        
        , so make the code using it conditional for gtk3.
        
        This at least unbreaks the build for now after
        
            commit a36a58933a1e07d3f54bacd5c2fe8ca53063a63a
            Date:   Mon Nov 25 17:07:59 2024 +0530
        
                sd: convert sidebar masterpage panels from drawingview to iconview
        
        It's possible gtk4 needs to do something else instead,
        but that can still be added later.
        See discussion newly started at [2] which might
        give some insights.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/8dc5e13e8c66cd260edff17dbaa10eedcc95ae1b
        [2] https://gerrit.libreoffice.org/c/core/+/177642/comment/4edf0ddd_f71cb30b/
        
        Change-Id: I3bd42614addd03d483c7b41daa2b3a4677b9318e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177769
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  anonymotter  <kstefun@csumb.edu>  [913854864096605bcea23a6174834fb5750ddad0]

        tdf#158979 Add static variable for last used merge option
        
        A static variable has been added so that, when merging cells in Calc
        where multiple cells have content in them, it will remember which of the three
        merge options was last used in a given session and automatically select that
        option the next time the merge cells dialog pops up. The default for the first
        merge in a session remains the option to keep the content of hidden cells.
        
        Change-Id: I35f6c01ffe9dff2756e3b9f5d530725e5d939db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177455
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [16030c0700a3a68b5d6bbb8567bcc8bd690ba966]

        cid#1636562 Uninitialized scalar field
        
        Change-Id: I4d9f76cc5cb767054e138819d2b8dd9032188c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5155e21bf1c511fa844010b9d07e2bfcb9ce8570]

        loplugin:unusedfields
        
        Change-Id: Iac4a64af74c92cbd76335faa62e51fa80ef21789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-04  Jean-Pierre Ledure  <jp@ledure.be>  [d28fcb3e26497ab1982ffcaee613e33821773c2a]

        ScriptForge (SF_Session) enhance ExecuteCalcFunction
        
        The ExecuteCalcFunction() method is a wrapper
        of the
           com.sun.star.sheet.FunctionAccess::callFunction()
        method.
        
        This method accepts a broad variety of arguments
        - scalars: numeric and strings only
        - data arrays (= arrays os arrays)
        - 2D arrays (1D arrays give errors)
        - com.sun.star.table.XCellRange objects
        depending on the called function and its
        execution or not as an "array function".
        
        The actual commit makes that the arguments passed to
           session.ExecuteCalcFunction()
        are checked as formally correct: scalars are filtered
        as numeric or strings, dates and booleans are converted,
        arrays are reshaped to 2D where necessary.
        
        The actual change facilitates, as an example,
        the use of complex array functions like XLOOKUP,
        a powerful search engine on large data sets.
        
        The implemented functionalities are valid in Basic
        and Python.
        
        The help documentation might be completed with
        additional examples.
        
        Change-Id: I6bba1e21828ef09c5c6f0463cbcfa1f5df695073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177744
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-12-04  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [43e511e642a2ce7026b30ea5c212940ff3eb522e]

        tdf#88226 sd: fix cutting off the overflow text on the notes print page
        
        This fix offers two options to preserve the overflowed text:
        1: if the "Original size" option is selected for printing,
           the overflowed text will be displayed on a new page.
        2: if the "Fit to Printable Area" option is selected for printing,
           notes will be scaled to fit within the available printable space.
        
        The "Multiple sheets of paper" and "Tile sheet of paper" options are disabled for notes because these options are intended for slide printing and do not make much sense for printing notes.
        
        The orientation for the notes print page has also been fixed.
        
        Change-Id: I99e56cf9aed5c32764797469a8ea7f3b25053882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177511
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [eae43ee9112e59b8aabc2abad04d5413230e17a4]

        Use o3tl::cow_wrapper instead of std::shared_ptr
        
        Change-Id: I05ff47fe51cccce6a78745027ae8c2679783bd8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177766
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [230a9da04f81c5ae54b6d7dc7972ac05a20a52c8]

        vcl: Drop MenuFloatingWindow::KillActivePopup param
        
        Move logic to the only caller that passed something else than
        the default nullptr.
        
        Change-Id: I293f2ca7ccd22f8f0f57a7fd91a6b4dfaa6a8846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177747
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [3e144ccb3cd9a1a093357b55140cc0be61beb3f7]

        vcl: Slightly simplify check in MenuBarWindow::KillActivePopup
        
        Use existing PopupMenu::ImplGetFloatingWindow
        instead of casting manually.
        
        Change-Id: I9449130e077fc997d724d5fadc854a278ba16cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177746
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Michael Weghorn  <m.weghorn@posteo.de>  [02bc6cd589ae4bf8469afea297b970d579a12229]

        vcl: Change Menu::ClosePopup param to PopupMenu*
        
        Change Menu::ClosePopup param from Menu* to
        the child class PopupMenu*, as this is always
        a PopupMenu. This also removes the need to
        cast to PopupMenu in the PopupMenu::ClosePopup
        override.
        
        Change-Id: I129e6ebc7c801c1ca93514f26f79b76f970957a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177745
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-04  Rashesh  <rashesh.padia@collabora.com>  [a36a58933a1e07d3f54bacd5c2fe8ca53063a63a]

        sd: convert sidebar masterpage panels from drawingview to iconview
        
        - also removes unused PreviewValueSet
        
        Change-Id: I5e7dacb4f472de526a61366295bc91edca12e9ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177642
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [171aa32c38569803f7470cf30180b66707e2db41]

        pdf: fix saving external PDF with form fields
        
        Change-Id: I3d7fdcfe2c4ec0f716425c349b0bf621809fd249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177741
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-12-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [345d1138c86ea2889a2d137949ecad28b2f2d9e7]

        pdf: simplify EncryptionHashTransporter
        
        No need for a map to remember the implementation - we can just
        dynamic_cast to the actual implementation.
        
        Change-Id: If590316023be7f749d270c04b7ad3dc5fa1993b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177644
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [780b41adb47c883f74fe0d2d28ca573377c4be99]

        pdf: introduce IPDFEncryptor interface
        
        Change-Id: I9cc0413f6c0af3be6ef83f4dbcf8dcf73b992f92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177643
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [53110dd25ea16c34c1ead6ef3d58288003a865d2]

        Revert "PVS: V614 Potentially null smart pointer 'pFillData' used"
        
        This reverts commit 60df7e1052e4ec0a33978df8af8afd65196dbd8c.
        
        Reason for revert:
        Michael Stahl: "the PVS warning is wrong, checking bChgFillData is already enough"
        
        Change-Id: I7d963e2b2ebbb30195af05b70ad36ab8d78e7c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177760
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [c196546d2454f0994e248d2f6925b70ad6307206]

        python: upgrade to 3.10.16
        
        Downloaded from https://www.python.org/ftp/python/3.10.16/Python-3.10.16.tar.xz
        
        Change-Id: I677c1dec6ac1d06596d7ff88269b6cac70d848c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177757
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [92099b161fd1904948441aaed90fa21472647e85]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0321da3f2b7fca3f7bda1655d64206f28231818e
          - Reapply "enable help for Tagalog (tl)"
            
            This reverts commit dc50ebde81a0e9266806878b69de81da422ec39c.
            
            Change-Id: I0795bff471896fba0972f6e8e44cc81b97e66ccd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177749
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Tested-by: Jenkins
            
2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f84a4390d945f985c8e0d80c958ee7bd9433aed2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac15fc2c15fa9e188f0acf1749ca63c2ac228530
          - add missing screenshots & files for Tagalog help
            
            Change-Id: I078f85931d21441929737105e694e0936fd1531f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177748
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-12-03  László Németh  <nemeth@numbertext.org>  [bfb8f9cae715efb5fe2b0120924aa333ce2bd4d2]

        tdf#48459 sw inline heading: don't apply inside frames or over 120 chars
        
        Don't apply inline heading 1) in a text frame
        2) or if the selected text is over 120 characters.
        
        1) It would be enough to limit this for inline heading
        frames, but the recent FN_INSERT_FRAME – which is used
        for creating the Inline Heading frame, cannot handle the
        insertion inside a frame: the new frame is anchored outside
        of the frame, not inside the actual paragraph, resulting
        bad layout.
        
        2) Increase also the limit of applying the inline heading
        to 120 characters (very upper limit for a long line) from 75.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        
        Change-Id: I05de4be3a08926fdabad2e601d4bbe57ae25f7c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177739
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-12-03  anonymotter  <kstefun@csumb.edu>  [7a12424df2b46385897b48c304bca867415b3f88]

        tdf#158068 Replace string literals with OUString literals in canvas
        
        Change-Id: I7bbcc08786843d6d289b3170248ce2696e57f3b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177602
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-03  Michael Stahl  <michael.stahl@allotropia.de>  [1b4bf7effc4784cf9f0c135e70434993103e1475]

        sw: HTML import: apply hard formatting at insert position ...
        
        ... even if there is a character format hint there - in this case, a
        RES_TXTATR_AUTOFMT attribute will not be converted to the SwTextNode's
        item set.
        
        Also add a test that uses the XDocumentInsertable interface to insert
        the HTML, which is closer to the real use case.
        
        (follow-up to commit f45d2fa85ba89eb7d71b51c3324f5938509b3201)
        
        Change-Id: Idbf7efceabca8d43d3e32d0b29fb37a9322c184c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177740
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6420c3df6c08afa2bad4add1dc4826feef851279]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9a24d35bd2100d7686503528bfce2cb2d6d18ca4
          - update translations for master/25.2
            
            and force-fix errors using pocheck
            
            Change-Id: I8cd66ba0ada8029d2c300d43b6c37ff7da3c3584
            
2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c3ed6e5a2cb7823f131d733c2014c9ea41126559]

        windows: use jom instead of nmake to build openssl if available
        
        jom (https://wiki.qt.io/Jom) is a parallel version of nmake that
        especially helps with building openssl since everything is compiled
        individually/the compiler cannot use parallelism either.
        Also in a LibreOffice build there's not much else that can be done in
        parallel/other stuff requires openssl to be built to continue.
        
        Change-Id: Ib16b0f947991a1d3255aeae7dc5d9bdee0b157a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177743
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-12-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [16b2cae80e3c112b44143cf0dabcd9d59322630c]

        tdf#164090: a11y sw: add new warning for non numbered empty paragraph
        
        Add new warning for empty paragraph between numbering paragraphs.
        
        Change-Id: Ib85b376da77a72a87ab05a3e8271be43e223f129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177493
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [863f5d26f96609b408794e02d3ef7e238a8c5e4d]

        Fix typo
        
        Change-Id: I7066a328fa54c062d1a12582d4f270e70f466c32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177702
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-12-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7f927322d9b030ceb3b04ae09ea5641e98916f62]

        configmgr: Better handling of finalized vs. non-finalized in the same layer
        
        When there are multiple competing configuration settings for the same
        configuration layer (e.g., in xcu files of two different extensions from the
        same extension layer), then the setting that is read last always won, even if
        any of the settings read earlier is marked as finalized.  (The reason for
        originally doing it that way was that it kept the code logic somewhat simple.)
        
        However, esp. for a scenario of multiple extensions in one extension layer
        (bundled, shared, or user), it can be unexpected by a user that a non-finalized
        setting (that comes from the extension that happens to be read last) can win
        over a finalized one.
        
        Therefore, change the logic accordingly.  Now, if any of the competing settings
        are finalized, the first finalized one that is read wins.
        
        Change-Id: I22aeade543a5b26d95d49cfcb561f974cd7a5081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177737
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [f643a98b2b60ccad63f7b4647ff6bc0141df0718]

        Revert "sc: manage conditional format with simpler dialog"
        
        This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37.
        
        Change-Id: I500a96508684547c158cdd1814540a4b24f667d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341
        Tested-by: Jenkins

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [acc8b8c49da3a0f2a1cc25e4425a56ed87edff4b]

        Revert "sc: added date condition option in conditional format manage dialog"
        
        This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef.
        
        Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340
        Tested-by: Pranam Lashkari <lpranam@collabora.com>

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [ec1b094127765333d7720aa7bc97832ab84babc6]

        Revert "sc: now formula conditions can be managed
        
        ...from condition format manager"
        
        This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8.
        
        Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339
        Tested-by: Pranam Lashkari <lpranam@collabora.com>

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [eb933099a537da8d667c5921d73196401ac23b89]

        Revert "sc: preview style in easy format dialog"
        
        This reverts commit 2661be5f8fb28ada80b4f5336d59f54b520bf614.
        
        Change-Id: Ie3482641cbbb34baa866a679c782221d2d513df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177287
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177338
        Tested-by: Jenkins

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [904b5157824f3d3920c8422dba277824e0d2bd88]

        Revert "sc: give warning about condition input in easy condition dialog"
        
        This reverts commit 2a6dc9dfd84b278352608f475a600e866846af2e.
        
        Change-Id: I061f8ebfbf0115dd55d357c325a3905c5a774a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177286
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177337
        Tested-by: Jenkins

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [70b9e65eae31abcc5d88773565059ba8dae44468]

        Revert "sc: display all the conditions of same ranges
        
        ...in conditional format manager"
        
        This reverts commit 399253ca8ca391504ff1f6a3709fb41d438ce2d6.
        
        Change-Id: I3c0a79ee0a34364d0a51ab4736810f35efe4bfdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177285
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177336
        Tested-by: Jenkins

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [36108acc124efd73a5e69f5780e8e8220cf0875c]

        Revert "sc: now conditions can be edited from easy conditional format dialog"
        
        This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a.
        
        Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335
        Tested-by: Pranam Lashkari <lpranam@collabora.com>

2024-12-03  Pranam Lashkari  <lpranam@collabora.com>  [dcf48b9d2dab74412b024ec1a3c12a6348f0c5f1]

        Revert "sc: prefill easy condition dialog with editing condition data"
        
        This reverts commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23.
        
        Change-Id: Ifdbc8920f232d388eac2a07cd6e2e2dece204a7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177283
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177334
        Tested-by: Jenkins

2024-12-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0b42fcdb3733f6919e9d221380c0fe27554a0d57]

        external/boost: Avoid some -Wdeprecated-variadic-comma-omission
        
        ...new with GCC 15 trunk -std=c++26 since
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cc67d95dc100706ea665e8cce581d59466aba62e>
        "c++: Implement C++26 P3176R1 - The Oxford variadic comma",
        
        > In file included from workdir/UnpackedTarball/boost/boost/rational.hpp:82,
        >                  from source/external/boost/include/boost/rational.hpp:30,
        >                  from source/tools/source/generic/fract.cxx:32:
        > workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:66:56: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
        >    66 |          inline constexpr void constexpr_swap(T&a, U& b...) BOOST_GCD_NOEXCEPT(T)
        >       |                                                        ^~~
        >       |                                                        ,
        
        and
        
        > In file included from workdir/UnpackedTarball/boost/boost/move/unique_ptr.hpp:24,
        >                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/impl/grammar.ipp:18,
        >                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/grammar.hpp:21,
        >                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core.hpp:42,
        >                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic.hpp:24,
        >                  from workdir/UnpackedTarball/boost/boost/spirit/include/classic.hpp:11,
        >                  from source/external/boost/include/boost/spirit/include/classic.hpp:30,
        >                  from sdext/source/pdfimport/pdfparse/pdfparse.cxx:23:
        > workdir/UnpackedTarball/boost/boost/move/detail/unique_ptr_meta_utils.hpp:500:39: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
        >   500 | struct is_unary_function_impl<R (*)(T0...)>
        >       |                                       ^~~
        >       |                                       ,
        
        Change-Id: I56856e274a7c577c53d96343992bb79d4c3d602e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177730
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-12-03  Martin Srebotnjak  <miles@filmsi.net>  [6d96021511629812fe1d0af67b09c330c749ff3c]

        Update git submodules
        
        * Update translations from branch 'master'
          to 93f61b8759efdb510d3e24eac33e10c8231aedf8
          - Updated Slovenian translation
            
            Change-Id: I0f24e5a42d5d8650fec3dc21d199882691bbdbba
            
2024-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7736eb6aebbbd27d6aa5ec7b7631826e3c22f07]

        fix --disable-scripting build
        
        Change-Id: I0b0113d5e3a1652280e0d84c1beba7c572ded191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3e6ad944ac6a7ccd465ed7a862157c467730f86b]

        don't bother passing const std::[u16]string_view by reference
        
        Change-Id: I49477c20849dd99118d5935c0f1576429648bfca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63594c62024b894251e1c88d5f65980c553dec4e]

        crashtesting: fix failure of forum-en-13617.odt to reload from .doc
        
        Change-Id: I907e282c9e7b75abca9a4c91ba12a2c57fc45f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177733
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db40f96f617f579486328ce4ed11f4c0a9540789]

        Resolves: tdf#139700 use WB_FLATVALUESET to get tracking highlights
        
        a problem since:
        
        commit 53d2a0390473319555f244f0ac3cf9a44b5ac7a0
        CommitDate: Tue Jan 14 13:45:44 2020 +0100
        
            weld PageSizePopup
        
        Change-Id: I5e55d1972a205b7bf1ec6f6bdfd2d8cd22e13eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b83387a55410a0f7701b3cb7898ef15a36668e4c]

        add OpenGL transitions even when OpenGL is not available
        
        This is needed for online, so the sidebar fills all the available
        transitions.
        
        Change-Id: Id3af1ed0272305fe7f1ab2d5dddd967276bbbb3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177727
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-03  Mohit Marathe  <mohitmarathe@proton.me>  [e3dd37ce0ce4251dd0f166659c5bd94a9e3008b9]

        tdf#163403 fix comments not showing in generic backend
        
        Change-Id: I21345049d8137e43cc3e50b0b1bcc8d41a123458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177582
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-12-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1699d29fca758944a5e477b05e61b5f42cc8907c]

        tdf#164137 - Fix Accessibility sidebar gives no warnings
        
        We need to check rather the update button is visible instead of the
        expanders.
        
        Regression from commit: 13ac356a32f279a3fd542d62c12e58abe3d3ad30
        (tdf#164048 sw a11y: improve error/warning levels with...)
        
        Change-Id: I63fb5906ad2f7bb13bc5822c284861a419897c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177723
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [02b2dce99c50d2f48de454a5aba1defc7f67ac78]

        cid#1636522 Missing move assignment operator
        
        Change-Id: I2d5f4e69b5cb9205743484c23443df2084da4fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-03  Heiko Tietze  <tietze.heiko@gmail.com>  [a0db0bd2e8558bfd1b2f7491a90221280f4a38d0]

        Resolves tdf#127937 - Feedback for AutoCalculate
        
        Shows an icon in the statusbar if autocalc is off;
        clicking the icon toggles autocalc on
        
        Change-Id: I7fb3296281647583f6f761427d35dcd79282f06c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177418
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e99ef8f347870b42eeef5ff94672d1f32e8c0af9]

        Related: tdf#163902 fix version number typo in the ui file
        
        Version number was accidentally downgrade after re-saving with glade.
        
        Change-Id: I266280884739dba65e97804d542f358a20e575f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177717
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-12-03  Patrick Luby  <guibmacdev@gmail.com>  [24032fea95e84111ad60da7a8401eb1672c5f10d]

        tdf#164047 Don't include libicuuc in libraptor2-lo link list on macOS
        
        For some unkown reason (maybe due to the macOS two-level namespace?)
        including the $(ICU_LIBS) link flags causes a crash on startup in
        the macOS dynamic library loader on some versions of macOS running
        on Intel machines. LibreOffice 24.8.3 and earlier did not have this
        bug since libraptor2-lo was not linked against libicuuc. So, revert
        back to the LibreOffice 24.8.3 macOS build behavior.
        
        On macOS, libraptor2-lo still links successfully even without
        libicuuc and the bundled JavaScript HelloWorld macro still runs. So
        it appears that libraptor2-lo does not need any symbols in libicuuc
        or, if it does, libicuuc has already been loaded by the time
        libraptor2-lo is loaded.
        
        Change-Id: I2e09ce57b5f7aea631a522f5d33f3a4b1ebfd419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177594
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2d5f8af346dfbd6b534a6dade13a92512014db00]

        don't require pkg-config in wsl-as-helper build
        
        windows build doesn't make use of system libraries, so we only need to
        make autoconf/configure happy (allow it to use PKG_CHECK_MODULES macro)
        but for that adding the m4/mac path is enough (there's nothing mac
        specific, just the pkg-config macros have been added for mac initially)
        
        Change-Id: Ia5db12833c26d89b7e0dbd7009562836885d8055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177562
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-12-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6e93419f46924876da1f0c52d27c03968becf046]

        wsl-as-helper: look for perl modules in the perl that's actually used
        
        i.e. strawberry-perl-portable for the installsets and openssl
        
        The only module that needs to be installed (and only when building
        installation sets) is Font::TTF::Font - but only on the windows side,
        not in the wsl-container.
        
        in the wsl-as-helper case there are three different versions of perl
        involved:
        
          * one inside wsl, since autogen.sh is a perl script
          * one provided by git-bash - used for the majority of the build
            whenever a recipe uses perl
          * and strawberry-perl-portable for building openssl (since that is
            picky and needs one that handles the windows-paths a certain way)
            and for building the installation sets (because of similar
            assumptions in path mangling)
        
        Change-Id: I8374749f21c7862f2e9e77d760077e836a6e9166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177560
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-03  Mike Kaganski  <mike.kaganski@collabora.com>  [15f4b64379e53170f20c146a30ac99228c560f48]

        Simplify ImplStyleData
        
        Change-Id: I4b6bb9e3250a0f88f4fb99f3c9c8195c3c7a8f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177714
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-12-03  Christopher Sherlock  <chris.sherlock79@gmail.com>  [890c03d39059685735f5ada62e706204eab81f0d]

        vcl: flatten functions in bitmapex.cxx
        
        Change-Id: I82c470705add539fa425b084805a5da12eefa0ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176535
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a6690210229572ff1f0be611997cd44f7ff35992]

        tdf#163902 sc: fix the size of available fields box of pivot dialog
        
        Similarly to Filters, Column Fields, Row Fields, Data Fields boxes
        the Available Fields box should be enabled to expand horizontally.
        
        Change-Id: I36a6322ef528a18e2c37eb8f3397cf1aeeedc759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177680
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-12-03  Mohamed Ali  <mohmedali1462005@gmail.com>  [c480e9ffb7092dd006e7ac61a46a11765251338a]

        tdf#130924 use SAL_WARN instead of fprintf
        
        Change-Id: Iefac2a4e58248c9fcead2bcf97817488097fb20d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177711
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-03  Jonathan Clark  <jonathan@libreoffice.org>  [9a14a0fd8b4227b5d08b3154cddca46f82ec2a03]

        tdf#162912 i18npool: Updated CJK BreakIterator to use custom rules
        
        Regression from commit 14c6cde779d64596eab0f4d3f32f181ce2243929:
          "tdf#49885 Updated CJK BreakIterator to use ICU"
        
        Previously, languages requiring dictionary-based break iterators were
        handled by instantiating a stock ICU break iterator as a special case.
        tdf#49885 upgraded our custom rules to support passthrough for
        dictionary-based breaking, so this special case is no longer necessary.
        
        Change-Id: Iebb06de82eb511946e5b220e5dc414440838b03c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177713
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-02  Jonathan Clark  <jonathan@libreoffice.org>  [94afced0195ef824e575176e33c79ca57484cd5c]

        tdf#164098 sw: Fix word overflow kashida justification crash
        
        This change fixes an infinite recursion crash while updating kashida
        insertion positions. This crash could occur if a word is too long to fit
        on a page and is broken onto another line, with the best-fit valid
        kashida insertion position on the previous line, and the following line
        also containing valid kashida insertion positions.
        
        Change-Id: Ifc3320765f35ccdc49bbf179446bc03654e2596d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177709
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [6c48547069afa15b0f0dfedb5ac6b87fe54d160f]

        vcl: Simplify MenuBar::ImplDestroy a bit
        
        MenuBar::GetWindow() and MenuBar::getMenuBarWindow
        return a pointer to the same object, so there's no
        need to use + check both for null.
        
        Change-Id: I1b7065e4cd04a24e6215118a8dc71f147ed75132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177699
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [228f40c5f6c9f5c707f92bbfddb128eacdaf2a8b]

        vcl: Drop unnecessary null check
        
        pMenuBarWindow is non-null and was already dereferenced earlier
        anyway.
        
        Change-Id: Ieaeda4129d5c819fefa37dd3a186f76e035961b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177698
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [185f7fa290d2d7e6f79b543acdc239323f727a5e]

        vcl: Switch MenuBar::ImplCreate param to MenuBarWindow*
        
        This avoids the need to do a dynamic_cast and makes
        clear that this method always gets called with either
        a window of a proper type or nullptr.
        
        Change-Id: I8ca4020476c806ad423379c7c7ee6fdc6ceccd3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177697
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [88a6a8eb9a0b30a25a6996cd8677b47a42f4822a]

        vcl: Consistently use pMenuBarWindow in MenuBar::ImplCreate
        
        Use `pWindow` only to assign initial value to
        `pMenuBarWindow`, then consistently use only the latter
        instead of keeping both in sync and using interchangeably.
        
        This also prepares for changing the `pWindow` param
        from `vcl::Window*` to `MenuBarWindow*` in an upcoming
        commit without upsetting clang plugins.
        
        Change-Id: I07482e23c365ce39c4aa581fb42bf97ad03f6e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177696
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [99379a3260f790d3a19662b08fd892da4f7323a3]

        vcl: Drop commented code in menu.cxx
        
        Commented out ever since
        
            commit 8ab086b6cc054501bfbf7ef6fa509c393691e860
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon Sep 18 16:07:07 2000 +0000
        
                initial import
        
        Change-Id: I147a6f6376e624bce2164d156e9360f99ac3b1d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177695
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [d4903bb537f8645e756f8621c26685f2fddb6217]

        vcl: Merge PopupMenu::PrepareRun into PopupMenu::ImplExecute
        
        Merge PopupMenu::PrepareRun into its only caller
        which makes it a little easier to follow the logic
        and track what's assigned to what local variable than
        when using many out params.
        
        Change-Id: Id967040a579e3f6532afa523215049bdb68f1cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177694
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [ed6d0b6a2037fddcc5869c9cebf999cf4060e973]

        vcl MenuBar: Drop friend class Application
        
        Application doesn't need access to any private members.
        
        Change-Id: Ia69b64ecf8e380b0b8da7477e3a3c7d312629965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177693
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [09187a0208b9d531be75b780055002db620c4d96]

        vcl: No longer let MenuFloatingWindow be a friend of MenuBar
        
        MenuFloatingWindow is the window used of PopupMenu,
        while the window for MenuBar is MenuBarWindow.
        
        MenuFloatingWindow only needs access to the menu
        bar's MenuBarWindow, so make MenuBar::getMenuBarWindow
        public and no longer let MenuFloatingWindow be a
        friend of MenuBar, to make a little clearer who
        is able to access whose private members,...
        
        Change-Id: I7ee492e36d6e94884d1dba652d11f26cb8543a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177692
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Stahl  <michael.stahl@allotropia.de>  [654e3134adbf48c61aaa29dcd9f52ce236694535]

        unotest,sw: introduce queryDispatchStatus()
        
        ... and reset the view options that are toggled in
        testHiddenParagraphFollowFrame and testHiddenParagraphFlys.
        
        Backporting these tests to the libreoffice-24-8 branch broke 2 unrelated
        tests because of the changed view settings:
        
        Test name: (anonymous namespace)::testHiddenSectionPageDescs::TestBody
        equality assertion failed
        - Expected: 532
        - Actual  : 798
        - In <>, attribute 'height' of '/root/page[2]/body/section[1]/infos/bounds' incorrect value.
        
        xmltesttools.cxx:203:Assertion
        Test name: (anonymous namespace)::testTable0HeightRows::TestBody
        equality assertion failed
        - Expected: 28
        - Actual  : 22
        - In <>, XPath '/root/page[1]/body/tab/row' number of nodes is incorrect
        
        Change-Id: Ie58242348fecabe163e54048f3896c6d427d2608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177691
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6091e6b0ed363b7e65569830ac76cdcb7ba99b24]

        crashtesting: further failure to reload forum-de3-6592.docx
        
        git show -w
        
        Change-Id: I2963833726779d784bcdfa772e152e65dfde3af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [adfbf35c0c102c7cead29845bde807947df4e30d]

        cid#1606759 Data race condition
        
        Change-Id: I1357972c5ca8c6441533f15423134707efd36e33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177684
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [f75b9f7e1eda6e9ab6e45df774134dcd3665f60e]

        loplugin:unusedmethods
        
        Change-Id: I85ef1d4e9391e211c9e5e7ac6e9de875e9f5f5af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177679
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-02  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [ae281b51456196246a5b21929f6624bf6c030294]

        tdf#163948: fix crash when NotesPane is enabled on Tabbed UI
        
        Pane shells (BottomImpressPane, LeftImpressPane etc.) do not implement any slot
        handling, so make sure they are not activated on the top of the shellstack.
        
        Another solution for this could have been getting ChildWindowPanes properly
        dispose instead of Hide() at BasicPaneFactory::releaseResource, and adapting the
        rest of the code which assumes these Panes are recycled.
        
        This is since ConfigurationUpdater::UpdateCore attempts at releasing via
        ConfigurationUpdater::CheckPureAnchors and
        ConfigurationControllerResourceManager::DeactivateResources calls.
        
        But in the end the ChildWindowPane is hidden on the DeactivateResource call
        instead of being diposed, so the "PureAnchor"'s Shell stays at the shellstack.
        
        Change-Id: I52788d350b66ae22875683f57d87326f4a9a77de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177686
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [264c333b055bcebf0ba85f5d7ebf66fe6b245bbc]

        crashtesting: failure to reload conversion of forum-de3-6592.odt to docx
        
        Change-Id: Ic2781bbd25e794992a181b2f4807fc0ca08ef33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177673
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4d74fc3b44b8e9b00330d2fd9c4f8809f01f063]

        mnOriginalTextPos is only written to, never read
        
        Change-Id: Iaca97dc3a0534847cbe96816a0827549a8f8d371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177685
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a730cd0793919e3b60fe5b32aaba0fe5eb2a115]

        crashtesting: failure to import rtf output of forum-en-44797.odt
        
        field text ended in \ so next } was escaped
        
        Change-Id: I2129f410a1d1c3d507a223c3576f02b78f7aac63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [44f6a3e9583357ac882f1660285214231961204a]

        vcl: Use existing PopupMenu::ImplGetFloatingWindow
        
        ... instead of manually casting the `m_pWindow`
        member in another place.
        
        While at it, also just call GetWindow()
        in PopupMenu::ImplGetFloatingWindow, not explicitly
        the base class Menu::ImplGetFloatingWindow. Both
        are the same, as this is a non-virtual method
        only implemented in the base class.
        
        Change-Id: I12debc7c5bad8b21722fabb093cbc4a7a669dff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177672
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [1336fc1713f50d743cc151c78ead4621d48ecfb9]

        vcl: Use VclPtr<PopupMenu> and reduce casting
        
        MenuFloatingWindow::pMenu is always a PopupMenu,
        so use a VclPtr<PopupMenu> for it, instead of
        a VclPtr<Menu> and casting in multiple places.
        
        Change-Id: I004fc57063fc1cd50e5f14463367af3063a247b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [5b47e57f177df6ae0f5f3afd7f0bee47a208fd6d]

        vcl: Pass GetSystemMenuData param by ref
        
        Change-Id: I04cae4a880dcf5c34e35ade9983b56d8ff8ed496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177661
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [e45cf9aab3de52ebcbefb70bec81f407d037b166]

        vcl: Add a default SalMenu::GetSystemMenuData implementation
        
        Have a default SalMenu::GetSystemMenuData implementation
        that does nothing instead of being purely virtual
        and all subclasses except WinSalMenu::GetSystemMenuData
        having to override it to do nothing.
        
        Change-Id: Ia47af286f0fd3c1e3c6a00fff4512c9334fd6e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177660
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [d49091617b8fa6fc8bce611323758fcf60e49b8b]

        vcl: Make Menu::ImplGetSalMenu const
        
        And drop the then no longer needed const_cast in
        Menu::GetSystemMenuData.
        
        Change-Id: Iac438850c5258e5fc23a4b3901f4601edf82e57c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177659
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [66dcd9ea8af085f222d59aea25da1fae500a5e6a]

        vcl: Prefix Menu::pWindow member with "m_"
        
        This makes a bit more obvious that this is a class
        member while reading code where it's involved, in
        particular since local `pWindow` variables are
        used in addition.
        
        Change-Id: Ic68e856a0c3ddedbf510124937cf4bc21febf916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177658
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [7ea2e48c431dad2fd704a0f75c0059904e37c715]

        vcl: Consolidate to one Menu::pWindow getter
        
        There are two getters for that member:
        Menu::ImplGetWindow and Menu::GetWindow.
        
        Replace uses of the former with the latter
        and drop Menu::ImplGetWindow.
        
        Change-Id: Ieaefe43258172f6000c326503eeeefe1a05faabb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177657
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [18c2199537b405dfb549d44ee1d29a58105ec86c]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ie010deb5cdf9da20f2ca60d79feabf1c0de93c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-02  Andras Timar  <andras.timar@collabora.com>  [aa443205e634880c8e3e35776f2b07675a798f85]

        Remove unused empty string
        
        Change-Id: If29babb15d0e594e2746d6124218704e3f49728b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177670
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-12-02  Szymon Kłos  <szymon.klos@collabora.com>  [73aed15d73f63ec509b2f6d7a8a4947453313523]

        slideshow: export isField property for layers
        
        this is temporary fix for caching the old values in
        the text fields like page number. to be removed, we
        need separate layers with awareness of fields
        
        Change-Id: I74d8186441912ad110bff4bc6f46faff79a20cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177664
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-12-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [02a5a4c4341df534ff1c42465e87ca25e63eec4e]

        tdf#163325: uitest: load the saved document
        
        After
        commit 2145204724049cad1585743c0b980ed2c6561212
        Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Date:   Mon Nov 25 09:17:45 2024 +0100
        
            tdf#163325 - Check Lower() frame during ToC preview
        
        Change-Id: Ie34e4d433e747ad68264f618047b49b4a826eaa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177667
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-02  Miklos Vajna  <vmiklos@collabora.com>  [48e9066621dffc5889cf158f09d5c81347a1f86b]

        svx: prefix members of E3dSphereObj
        
        See tdf#94879 for motivation.
        
        Change-Id: If10c0d7a40536f27fb18f7624c91092471d45996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177651
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-02  Jean-Pierre Ledure  <jp@ledure.be>  [ec4415d2a78b1c0fb5eab5baea88508d6b9db43b]

        ScriptForge - Methods about data arrays
        
        A data array is a 1D array of 1D subarrays.
        All arrays are presumed zero-based.
        Usages:
        - the content of a range of Calc cells returned
          by the UNO XCellRange.getDataArray() or
          XCellRange.getFormulaArray() methods
        - the output of SF_Session.ExecuteCalcFunction()
        - a tuple of (sub)tuples returned by a Python script
        
        3 methods are added to the Array service:
        
        1) ConvertFromDataArray(DataArray, [IsRange], [FillValue])
          Convert a data array to a scalar, a vector or a 2D array.
          On request, the individual items are reduced
          to strings or doubles only.
        
        2) ConvertToDataArray(Data, [IsRange], [Rows], [Columns)
          Create a data array from a scalar, a 1D array or a 2D array.
          The returned data array is zero-based and compatible
          with the XCellRange.DataArray property when IsRange = True.
        
        3) ConvertToRange(Data, [Direction])
          Create a valid cells range content from a scalar,
          a 1D array, a 2D array or a data array.
          The individual items are always reduced to strings
          or doubles. Including booleans or dates.
          The returned scalar or array is a valid argument
          of the SF_Session.ExecuteCalcFunction() method.
        
        They replace the internal _ConvertFromDataArray()
        and _ConvertToDataArray() that were present in
        the Calc service, called by SetValue(),
        SetFormula() etc. methods.
        
        This change is Basic only and has no effect in Python.
        
        The documentation about the Array service
        should be completed with these new 3 methods.
        
        Change-Id: Idc5b6417648e4574b0f9c7c6e2438ff7dfce1829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177620
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-12-02  Miklos Vajna  <vmiklos@collabora.com>  [56664a5b6fffa8b4bd993663374acc94fe1b7fba]

        CppunitTest_sw_tiledrendering2: make this more stable, try 2
        
        Similar to commit d248d8f5271c380e51af9482b6724d471e2cb929
        (CppunitTest_sw_tiledrendering2: try to make this more stable,
        2024-11-20), but note that the problematic assert at e.g.
        <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/178813/console>
        is before the early return, so move the early assert below the early
        return.
        
        Change-Id: I0ed9168840defcc567e2e2fa8262bdf32489b54a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177652
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a81a5272196d6ba00551dd7ee0e4dab807e4052]

        crashtesting: crash on load of forum-en-40508.odt + F9 to update fields
        
        seems to already exist in oldest version I have
        
        Change-Id: I3f3652952476678c121cbe3f800b7adf7f7aa1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177626
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4161486f9ae29452375aa57fd080cc6af7d6fd3b]

        crashtesting: crash on load of .doc output of forum-de3-398.odt
        
        Change-Id: Ibcd898e25c8807dba36226d0ec7126588ba38837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-02  LeSci-0x1  <sscire@csumb.edu>  [c3f04640979d4f9d9abe8dc3e645d058e1cfb182]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: If8222286f36cda3071d63a14896d8d89c5802437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177650
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-02  LeSci-0x1  <sscire@csumb.edu>  [388b8fa5b28df532cd87689a35a38905b0cd038a]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I3d8b65f0ef386eed2ada12664aa33d2efd53fb65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177641
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-02  Rosh  <roshsiddiq@gmail.com>  [e1775391a59927219dfb4e1308f9291a5a0cc4c0]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Idd8907bd5e10d374f32f7ec9ba7ecf39c9031b0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177454
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-12-02  Rosh  <roshsiddiq@gmail.com>  [ece03018cb6e0bcc6bf56b1a703c29f04df88eed]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I08c84cd3fdc1a1606bbfedbbf5a4987f923cefa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177467
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-12-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f52aafac08731e3f60b49c912f4169394d787d66]

        tdf#157869 Improve description for columns in textbox (Impress)
        
        Change-Id: I5ddda383f41095a96597d57ab635dbab500aabc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177220
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-12-02  Gökay Şatır  <gokaysatir@gmail.com>  [90ab893c55b50cef2e7b936fec20864168845eb3]

        Add a test for setAllowChangeComments function.
        
        This is a follow up for:
        * https://gerrit.libreoffice.org/c/core/+/164570/2
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: If748aac779767174d14dde33efab62d980b115ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172114
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176287
        Tested-by: Jenkins

2024-12-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d8e7a3b2457cde49deb2f88ff1070ce54000f659]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I8ef1df248d3ed9fbc804e53897ca934cce9683e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176779
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [b537e5b6d50988458aca8893393451d2c3d255e9]

        Drop Window::IsAccessibilityEventsSuppressed param
        
        All callers use the default of `true` for the
        `bTraverseParentPath` param since
        
            Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 2 03:28:50 2024 +0100
        
                sc a11y: Don't suppress a11y events when setting new pos
        
        , so simplify this by dropping the param altogether.
        
        Change-Id: If47333f096d31afc3fb2c57dcc03d8e342ae4aa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177640
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [a80d7dcb848438092895b6ad80cf6072478a1677]

        vcl a11y: Drop newly unused vcl::Window::SetAccessibilityEventsSuppressed
        
        Unused now after
        
            Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 2 03:28:50 2024 +0100
        
                sc a11y: Don't suppress a11y events when setting new pos
        
        Change-Id: I4359c903d1d1902671de87121161e0ca74b88251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177639
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-12-02  Michael Weghorn  <m.weghorn@posteo.de>  [a0a22acced55c53a79aca74dceff7d3219f66769]

        sc a11y: Don't suppress a11y events when setting new pos
        
        Don't suppress a11y events when setting the new
        position string in the combobox in Calc's formula
        toolbar.
        
        Suppressing events was added in
        
            commit 38fe580341a3f1e379edada08db7e1aebab258f5
            Author: Malte Timmermann [mt] <malte.timmermann@oracle.com>
            Date:   Thu Jan 20 16:34:26 2011 +0100
        
                accfixes: added more accessibility information and fixed tab orders in multiple dialogs (sc module)
        
        for unclear reasons.
        
        The only potential reason I can come up with could be
        to avoid announcement by screen readers, but they
        usually don't announce text/value changes to non-focused
        controls anyway, and neither Orca on Linux nor NVDA
        on Windows announcement changed with this change in place
        when moving focus between cells in Calc.
        
        Without this change in place, having the combobox's
        "text" child selected in Accerciser's treeview
        of LO's a11y hierarchy, the text shown in the "Text"
        interface section would not automatically update to display
        the newly selected location due to the missing
        event when using the qt6 VCL plugin. With this change in
        place, it is updated as expected.
        
        Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177638
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-02  Oliver Specht  <oliver.specht@cib.de>  [ef4452663d13d0d559356440e71e97a6c282b1ff]

        tdf#161341 show/hide controls/shapes/pictures in view/print
        
        Controls/shapes and images/objects have a display option in tools/options/
        Writer/View and in print dialog there is "Form controls" and
        "Images and other graphic objects". With this change the options
        will actually be applied again.
        
        Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-12-02  Jim Raykowski  <raykowj@gmail.com>  [55e86edcb37a37123a69ce3e1eb9e20758415fb6]

        tdf#120658 - Reworking of dialogues Organize macros
        
        (make from 5 existing only one)
        
        Much of what makes up this patch is adapted from existing code that is
        used to organize and select macros and to assign macros to shortcut
        keys. Comments in the patch say where code is borrowed from.
        
        Known issues:
        
        + Scripting framework library rename for BeanShell, Java, and JavaScript
        always returns fail when there are no macro entries in the library even
        though it actually succeeds. The same thing happens using
        SvxScriptOrgDialog::renameEntry.
        
        + Deleting Basic macros from the Macro Manager dialog is not implemented
        yet.
        
        Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0f3f3710280d2476425bb86bc2e065e3e7a82952]

        NameContainer need not be an UNO object itself
        
        Change-Id: I56f07a62ed3d2388eede16a85e673027cfed8158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177616
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [827fa4cb7bba8dc5f101c6325075d5b54210cd01]

        mac-sandboxing: also exclude AppleRemote when using --enable-mergelibs
        
        mergelibs have been added to the LibreOfficeMacOSX distro config in
        e6e22bee153e36989069124e8d1a55d6d6ba433a, but AppleRemote has been
        disabled in the sandboxing case since 2013
        4fe9ef81aa83403bd3b7df555ccbd96cbdfd7c2d "The AppleRemote code is
        blocked by sandboxing so bypass it in that case"
        (unclear to me whether fundamentally not working or whether it was
        disabled to get sandboxing as a whole in a working state quickly, since
        there was an earlier entitlement for mac.remotecontrols)
        
        Change-Id: I8514319b1d9ffa3a993267eaebac0c2ff058740f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177621
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-12-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [16652e55f916025d42ca18b95934e67edd878de0]

        mac: don't try to strip Contents/Frameworks/intl directory
        
        the intl data for firebird has been added with
        07cc2fdc3d447479ca3afd2f91c9bc80be745dff (and the associated config file
        later moved to Resources with dfa78d2eac7632c93d1e76e52c9d46050dd932a2)
        
        Change-Id: I4fe666076c42bae21b371fe0ea9495ebc915bd21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177617
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [90248dca6bbe4a33f3d91a3cd5d7bd7d904ef8ce]

        cid#1608083 Overflowed constant
        
        Change-Id: I1aaa2ca5711b932676621ee37b00fd0683593214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1c8d7d826fcbf234e9a327188dd0962339270e41]

        rearrange to compare against unoperated-on nCharCount
        
        Change-Id: I5bd1e8c4974616289b563bfd4893bf9616c04a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177618
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [87aa067bae975363c373d94462554f5fece5bb77]

        This TODO got fixed in 2016
        
        with:
        
        commit 8a2149c1059c70d67b4897e8a7751cf028a5136b
        CommitDate: Fri May 20 07:55:30 2016 +0000
        
            clang-tidy misc-assign-operator-signature
        
        Change-Id: I9ffbfd4cfa5742b4fa62b616591c19ebe3fc1f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177615
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2ca770830cd2129470de486b41a0d68727aeb00b]

        nothing consumes the ReadParaProps nCharCount arg, so drop it from params
        
        Change-Id: Iea1bd3bb7df6466aeee480d8e44659b71bef580e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b4908d77dbe29c8d3ba81523fce7ee2ed5102ec]

        disentangle nCharCount variable used for two different things
        
        Change-Id: Ia8a5eef35c7a4ccdc9d7747fbb408f670777a49b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177613
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [caeed200754eda7787cae256136dee25f347a69c]

        ReadCharProps always overwrites nCharCount
        
        its an out only param, not in-out
        
        Change-Id: I4e969bf06bed41a7e04497880f8ea51a3f784feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177612
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f82818ad04717ed28338d0eb2bdc55c1942b1bf7]

        cid#1557419 Data race condition
        
        and
        
        cid#1557189 Data race condition
        
        Change-Id: I6ee6dd60d7b0eccca3042ad5ff7846f77f16feec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177610
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad338cae4efa3f05907ccec0fbf54c9c35e2f3ce]

        cid#1606986 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556101 COPY_INSTEAD_OF_MOVE
        cid#1555475 COPY_INSTEAD_OF_MOVE
        cid#1555310 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibabd8fd59a5435b8ab6c33d78c1303e5e1bdfd9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177609
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [658b492c1a798a6135fce6eb18808eaeb6425db0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 685db476dad288f6635917ae0ca05d5369c64c15
          - update translations for master / 25.2
            
            and force-fix errors using pocheck
            
            Change-Id: Iad27f4c2f514466569dcb982849dee099b6c77d7
            
2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [297b7a7676524ce6d5b3b79764697c5f78970871]

        Optimize SfxLibrary / SfxLibraryContainer memory layout a bit
        
        Change-Id: I63ba583ef990dd2bbfb7f44af613fce1d8d1b411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177608
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d91eca950ef024de7734af9a8de3a208e19b638c]

        Simplify SfxLibrary hierarchy
        
        For some reason, SfxLibrary's own interfaces were used outside of
        WeakComponentImplHelper; and derived classes didn't use inheritance
        helper.
        
        Change-Id: Ib0b6cf5cfa559fe5eedc4d05247655aca1bfc4b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177607
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ac334d5c76fad666a465508a3704815fa5aaec7c]

        Simplify a bit
        
        Change-Id: Ia48a24d1696aaf2ee7e49f5e8c9f9dcc0ae9e8e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177606
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ece47db81680e8e99bbaa62605f9a7e3e4b38bef]

        make this a little more readable
        
        Change-Id: I922b150f2c1682ec48331319bbf6222482c6cd3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177595
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32ac606ec319b4b66192fe9a43fecce446cbca27]

        new doesn't return null on failure since C++98
        
        Change-Id: Ib9260ec6ba148f0de248753148309a6c578e796d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177600
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e3b9a442e0993952e401d2eec517e3a4dd02a4aa]

        drop 'store' from libs we pagein on startup
        
        it's there to speed up later read of it, but in normal situations we
        shouldn't use it anymore IIUC
        
        Change-Id: Ia075e32cd4820729b341d4d47dbfb9126a363559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-12-01  Laurent Balland  <laurent.balland@mailo.fr>  [3ee73a4d1ee2b11564df2c001514bcfd8b5c632c]

        tdf#163102 Replace DocBookTemplate.stw by build-in...
        
        DocBookTemplate.ott
        Simply copy makefile of extra/templates
        fix bug tdf#161930: mimetype is zipped only once
        
        Modifications to DocBookTemplate.stw:
        - change fonts to bundled fonts: Liberation Serif, Noto Sans CJK, Noto Sans Devanagari
        (not so useful as used fonts are defined in
        docbooktosoffheadings.xsl and sofftodocbookheadings.xsl)
        - remove language and country tags
        - remove page size
        - remove writing mode tags
        - remove content.xml
        - remove meta.xml
        - simplify settings.xml
        - remove unused namespaces
        
        Change-Id: Ic2a2284c3d890b8a6b7b4e29bdab18c33d40dcee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174847
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ea2a97438643a440e192dbe30d03988da65c6b18]

        Simplify NameContainer
        
        Having a map, two vectors, and a counter for what is a job for a single
        map is a bit too much.
        
        Change-Id: I50d29f03a2463e6f63ed8e645c36b4c77aa1413a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177604
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [e413d962ac6f4cc6c32bd153a030a57a57d66676]

        Drop unneeded indirection and unused argument
        
        The extra complexity was introduced for #i94994# in commit
        326696598621c5883d7c28f491ca8192e8cfb21c (CWS-TOOLING: integrate CWS
        ab61, 2009-02-11).
        
        Change-Id: If5a69984e3c2c963d4eea2824373fbf1e8a47fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177603
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-12-01  Michael Weghorn  <m.weghorn@posteo.de>  [afc441e65107ed808c399b65f4737d25541cdf77]

        tdf#130857 qt weld: Support "Insert Breaks" dialog
        
        Declare support for the "Insert Breaks" dialog that
        can be triggered using the "Insert" -> "More Breaks" ->
        "Manual Break" menu entry in Writer.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I338b017d082532a831168f1c6d0e3e5147e04a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177599
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-01  Michael Weghorn  <m.weghorn@posteo.de>  [7498b77bf677d5199be0133b18720b4446c0a80a]

        tdf#130857 qt weld: Support "Split Table" dialog
        
        Declare support for the "Split Table" dialog that
        can be triggered using the "Table" -> "Split Table"
        menu entry in Writer while the cursor is inside of a
        table cell.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: Iae4855027de533ff7f9a4148f8101a56c281abcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177598
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-12-01  Michael Weghorn  <m.weghorn@posteo.de>  [6eb823fa40c0a9ce09a0503df601910b09077d60]

        tdf#130857 qt weld: Support "Split Cells" dialog
        
        Declare support for the "Split Cells" dialog that
        can e.g. be triggered using the "Table" -> "Split Cells"
        menu entry in Writer while the cursor is inside of a
        table cell.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I5b994698ea46e9ede763169d21fe53527b3b369b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177597
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c1dbd3188a3baeaab849d4a72e9de8ea85e00fd]

        cid#1607542 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1606986 COPY_INSTEAD_OF_MOVE
        cid#1557969 COPY_INSTEAD_OF_MOVE
        cid#1557837 COPY_INSTEAD_OF_MOVE
        cid#1557772 COPY_INSTEAD_OF_MOVE
        cid#1557735 COPY_INSTEAD_OF_MOVE
        cid#1557672 COPY_INSTEAD_OF_MOVE
        cid#1557664 COPY_INSTEAD_OF_MOVE
        cid#1557650 COPY_INSTEAD_OF_MOVE
        cid#1557642 COPY_INSTEAD_OF_MOVE
        cid#1557639 COPY_INSTEAD_OF_MOVE
        cid#1557628 COPY_INSTEAD_OF_MOVE
        cid#1557623 COPY_INSTEAD_OF_MOVE
        cid#1557581 COPY_INSTEAD_OF_MOVE
        cid#1557489 COPY_INSTEAD_OF_MOVE
        cid#1557473 COPY_INSTEAD_OF_MOVE
        cid#1557317 COPY_INSTEAD_OF_MOVE
        cid#1557261 COPY_INSTEAD_OF_MOVE
        cid#1557146 COPY_INSTEAD_OF_MOVE
        cid#1557135 COPY_INSTEAD_OF_MOVE
        cid#1557134 COPY_INSTEAD_OF_MOVE
        cid#1557079 COPY_INSTEAD_OF_MOVE
        cid#1557063 COPY_INSTEAD_OF_MOVE
        cid#1557052 COPY_INSTEAD_OF_MOVE
        cid#1556982 COPY_INSTEAD_OF_MOVE
        cid#1556977 COPY_INSTEAD_OF_MOVE
        cid#1556950 COPY_INSTEAD_OF_MOVE
        cid#1556943 COPY_INSTEAD_OF_MOVE
        cid#1556804 COPY_INSTEAD_OF_MOVE
        cid#1556736 COPY_INSTEAD_OF_MOVE
        cid#1556658 COPY_INSTEAD_OF_MOVE
        cid#1556621 COPY_INSTEAD_OF_MOVE
        cid#1556590 COPY_INSTEAD_OF_MOVE
        cid#1556579 COPY_INSTEAD_OF_MOVE
        cid#1556534 COPY_INSTEAD_OF_MOVE
        cid#1556524 COPY_INSTEAD_OF_MOVE
        cid#1556478 COPY_INSTEAD_OF_MOVE
        cid#1556467 COPY_INSTEAD_OF_MOVE
        cid#1556422 COPY_INSTEAD_OF_MOVE
        cid#1556314 COPY_INSTEAD_OF_MOVE
        cid#1556309 COPY_INSTEAD_OF_MOVE
        cid#1556258 COPY_INSTEAD_OF_MOVE
        cid#1556143 COPY_INSTEAD_OF_MOVE
        cid#1556119 COPY_INSTEAD_OF_MOVE
        cid#1556101 COPY_INSTEAD_OF_MOVE
        cid#1556097 COPY_INSTEAD_OF_MOVE
        cid#1556039 COPY_INSTEAD_OF_MOVE
        cid#1555966 COPY_INSTEAD_OF_MOVE
        cid#1555948 COPY_INSTEAD_OF_MOVE
        cid#1555915 COPY_INSTEAD_OF_MOVE
        cid#1555836 COPY_INSTEAD_OF_MOVE
        cid#1555748 COPY_INSTEAD_OF_MOVE
        cid#1555644 COPY_INSTEAD_OF_MOVE
        cid#1555582 COPY_INSTEAD_OF_MOVE
        cid#1555478 COPY_INSTEAD_OF_MOVE
        cid#1555475 COPY_INSTEAD_OF_MOVE
        cid#1555409 COPY_INSTEAD_OF_MOVE
        cid#1555372 COPY_INSTEAD_OF_MOVE
        cid#1555334 COPY_INSTEAD_OF_MOVE
        cid#1555330 COPY_INSTEAD_OF_MOVE
        cid#1555310 COPY_INSTEAD_OF_MOVE
        cid#1555257 COPY_INSTEAD_OF_MOVE
        cid#1555247 COPY_INSTEAD_OF_MOVE
        cid#1555147 COPY_INSTEAD_OF_MOVE
        cid#1555120 COPY_INSTEAD_OF_MOVE
        cid#1555059 COPY_INSTEAD_OF_MOVE
        cid#1555016 COPY_INSTEAD_OF_MOVE
        cid#1554880 COPY_INSTEAD_OF_MOVE
        cid#1554824 COPY_INSTEAD_OF_MOVE
        cid#1554808 COPY_INSTEAD_OF_MOVE
        cid#1546189 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I2d2f33c603f1596228c9ecb169472ba6751e7826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177593
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [096a1f0a6f2d8fdbd632bd4263e2f022b07f9b69]

        cid#1608320 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1607135 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If8f36744c53bb0515516a23589ffdb389aaec02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10ea4f0b932d16ff0a7b2d25d15d0c4b57456243]

        cid#1635783 silence Using invalid iterator
        
        and
        
        cid#1635784 Using invalid iterator
        cid#1635785 Using invalid iterator
        
        Change-Id: I88ca7325b45a556638dc7b7ee01e78cf0238a0de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177591
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9fa670467033bc0ef99539295f8f2425e05a51e9]

        cid#1607234 Overflowed return value
        
        Change-Id: Ic4b47f0dd0f5d24026a4ce001d52d1fd29a0c656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177590
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6fd05636e2b14806355c2a612de5755f1f6b801d]

        cid#1557258 Data race condition
        
        Change-Id: Iaf4fdba3696669763511aa476e53a0fea36a05c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177589
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-30  Arnaud VERSINI  <arnaud.versini@pm.me>  [fb30ee5a6390160cc482572adcab14cc242528da]

        tdf#147021 : use std::size in scaddins
        
        Change-Id: I8a17b5a782aedd8784595c7febbacc24921bce1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169357
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-11-30  László Németh  <nemeth@numbertext.org>  [20ee4ecfeb1c504f0bc8a3057ff30e2e61f4b300]

        tdf#164074 sw inline heading: clean-up outline moving
        
        Fix bad condition with ++std::npos in the following !WithChildren
        inline heading branch:
        
        else if( pOutlNdsInline && ++nEndPosInline < pOutlNdsInline->size() )
        
        The problem was reported by Caolán McNamara.
        
        Remove also an unused variable in docnum.cxx.
        
        Follow-up to commit 32398232e925d18d2ac5a6d467b61e1a84a0df7c
        "tdf#164074 sw inline heading: add up/down outline moving".
        
        Change-Id: I61d75451adeb13fe8e74ce586c4668a8caf0105b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177580
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [34a63a22df48ee5aef35fde502aa59d5207fbdd9]

        sd: simplify UpdateShellStack
        
        Change-Id: I10a21d1d62afa6118b665c031cb6d70b1bc006ba
        Co-authored-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177497
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [7d89a348fbd4a7705fe03688041fff0a27398afe]

        tdf#164101: avoid incorrect OLE object scaling during loading
        
        Use an internal property for that, alowing to pass the option from the
        import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more
        proper way to do this, but I couldn't find it.
        
        Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [f36de41877dc5afdfca59308331202ac1ec18959]

        tdf#130857 vcl: Deduplicate extract* methods returning OUString
        
        This is similar to
        
            Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Nov 30 10:24:30 2024 +0100
        
                tdf#130857 VclBuilder: Deduplicate extract* methods returning bool
        
        , but for methods extracting an OUString value instead
        of a bool one.
        
        Change-Id: Ic90ac0c630ee7454b8a7fa4f34383f8635d21ff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177585
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [1e54fbfa6b01cbeea1a497f116baa8b956bd6ace]

        tdf#130857 vcl: Deduplicate extract* methods returning bool
        
        Add new `extractBoolEntry` helper that takes the
        map, key and a default value to return if the
        map doesn't contain the key.
        
        Use that new helper to deduplicate the various
        methods implementing the same logic over and over
        again.
        
        Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177584
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [2fe4500628ec7d98719b58ee98f0e227d536799c]

        vcl: Drop local var pointing to self in WindowData ctor
        
        Before
        
            commit 2e509b886f1d77ef158579385b55f1f94cfbc710
            Date:   Sun Jun 12 17:42:05 2022 +0200
        
                Convert ImplWindowStateFromStr to WindowData(str)
        
        , `rData` was a method param for ImplWindowStateFromStr.
        
        Now, using it instead of just using `this` is
        unnecessary.
        
        Change-Id: I7974161990375e44d4d78097e49a9f42e118bcce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177579
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [de7cfac4df2d32da2eb75affffe3c36e0b89adbf]

        tdf#130857 qt weld: Assign QtInstanceFrame::m_pGroupBox
        
        That was apparently forgotten in
        
            commit 0a4ec73c23678cc1008f191a08963c331255db61
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 25 10:04:10 2024 +0200
        
                tdf#130857 qt weld: Add a QtInstanceFrame
        
        and none of the dialogs declared as supported this
        far was actually calling any method making use
        of it, as that would have triggered nullptr
        dereference.
        (Seen now while experimenting with adding support for
        the "Search and Replace" dialog.)
        
        Change-Id: I84ec83f4d4af8b2828e5033f366037b3114629d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177578
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [9ccfc8a719bfcb34baff8559dc33a9cd5b638646]

        tdf#130857 Search dialog: Use weld::Container ptr instead of Box
        
        None of the weld::Box methods are used, so having a pointer
        to the weld::Container subclass is sufficient in the
        "Find and Replace" dialog implementation.
        
        Change-Id: I1219dd657ab8fb6067c90aabdc27b2b84c0a1443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177577
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [05c8f91d5abf79f3591b5979ae01a17f2b153880]

        tdf#130857 qt weld: Implement more TreeView methods wrt selection
        
        Change-Id: I3479b138a0986f1fbac7745e575e318bf63c1911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177576
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [ec395cfd2062f98af77029dee845c12bb2f9153a]

        tdf#130857 qt weld: Add member for tree view selection model
        
        ... and use it in misc places instead of calling
        QTreeView::selectionModel repeatedly.
        
        Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [7003cb1d74aafd40fc4d3ac5ec81063b6926199a]

        tdf#130857 qt weld: Notify about current tree view item change
        
        When the current (focus) item in the tree view changes,
        call weld::TreeView::signal_changed to notify about this.
        
        While QTreeView doesn't have a signal for that itself,
        its QItemSelectionModel does, so connect to that one.
        
        With this in place, SvPasteObjectDialog::SelectHdl
        now gets called when switching between items in the
        "Past Special" dialog when using the qt6 VCL plugin
        with native Qt widgets, as is the case with the gtk3
        VCL plugin.
        
        Change-Id: I5aab68055f711480d56b043252d15621f18c4919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177573
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [0513dbac40d276526ce7a2a183d72cc02ce78eed]

        tdf#130857 qt weld: Call tree view row activation handler
        
        Change-Id: Ib95cc7d4c2b60d3b426b76573ff06917637d838e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177572
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [f96959a3779cc589381662604c3b927a24f6e205]

        tdf#130857 qt weld: Support "Paste Special" dialog
        
        Declare support for the "Paste Special" dialog
        that appears when copying something using Ctrl+Shift+V.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        At least copying text from a browser gives the expected
        result when copying as either HTML or plain text in a quick
        test.
        
        Change-Id: I967f5edd00b19e7ee70f1f7ef4d55240ae700e2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177570
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [210088db7c9d07c7600550bd6525d2f3299b9a39]

        tdf#130857 qt weld: Implement QtInstanceTreeView::get_selected_{id,text}
        
        Change-Id: I6a732606c6bf762033744824e857f861077b0237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [17b49c778dbbb99407891ebbcc17775e89df5bf5]

        tdf#130857 qt weld: Implement QtInstanceTreeView::find_{id,text}
        
        Still untested.
        
        Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [f956faffdeab44fa59765c5c933198799164ef2b]

        tdf#130857 qt weld: Implement setting tree view entry ID
        
        Use QStandardItem::setData with a custom role
        (ROLE_ID, with a value sufficiently larger than
        Qt::UserRole to avoid any accidental overlap, as
        e.g. QStandardItem::setData would use a default
        role of Qt::UserRole + 1) to set the ID.
        
        Implement QtInstanceTreeView::get_id
        to get the ID for the entry with a given index.
        
        Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [25c0fe3f495e7169cd1e74b35b6d5a4d8afdffd6]

        cui: Resave pastespecial.ui with glade 3.40
        
        This is the "Paste Special" dialog that shows
        when pasting using Ctrl+Shift+V.
        
        Change-Id: I7a3166251111a4fd568ad8c395e4d4053ae1f868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177566
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [5073fc170e3b45a6b80a4dbf85aa5e24338177b4]

        tdf#130857 qt weld: Evaluate GtkTreeView:show-expanders property
        
        Evaluate the GtkTreeView:show-expanders property [1]
        and set the QTreeView::rootIsDecorated propert accordingly [2]:
        
        > This property holds whether to show controls for expanding and
        > collapsing top-level items
        >
        > Items with children are typically shown with controls to expand and
        > collapse them, allowing their children to be shown or hidden. If this
        > property is false, these controls are not shown for top-level items.
        > This can be used to make a single level tree structure appear like a
        > simple list of items.
        
        With this in place, there are no more expanders shown for
        Calc's "Sheets" -> "Show Sheet" dialog for the native Qt
        version, just like with the gtk3 or gen versions.
        
        [1] https://docs.gtk.org/gtk3/property.TreeView.show-expanders.html
        [2] https://doc.qt.io/qt-6/qtreeview.html#rootIsDecorated-prop
        
        Change-Id: I11bcdd39695d230866abddf6d4b305dd6af52f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177548
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [cb17f33b673e7786a57028fddc85485c33e1576b]

        tdf#130857 qt weld: Evaluate tree view header visibility
        
        Take into account the "headers-visible" property
        for "GtkTreeView" in .ui files.
        
        With this in place, Calc's "Sheets" -> "Show Sheet"
        dialog no longer shows an unexpected "1" title
        above the list of hidden sheets.
        
        Change-Id: I054cca7e2b379782cf3548cb822ecdba0f5553d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177547
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [480d38b18ccdc422c92f7dde11058f16c4ac57fa]

        tdf#130857 VclBuilder: Move extractHeadersVisible to base class
        
        Move this helper function to the base class, for reuse
        in QtBuilder in an upcoming commit.
        
        Change-Id: Ide125c87bd4ebf63f70f94239a9bc42c3eab3c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177546
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [4d1f6c439be24a0701a923081b249d6801902bc1]

        showsheetdialog.ui: Resave with glade 3.40
        
        To trigger the dialog:
        
        * start Calc
        * add more sheets
        * hide some of the sheets (e.g. by right-clicking them
          in the bar at the bottom, "Hide Sheet")
        * select "Sheet" -> "Show Sheet" in the menubar
        
        Change-Id: Ie2f92c0b86ec47cf5bab85c9ea3c8096023a11de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177545
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [5d94ffde5125960fff0c177635292b2de5e20d38]

        tdf#130857 qt weld: Support Calc's "Show Sheet" dialog
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the first supported dialog making use of
        weld::TreeView.
        
        To trigger the dialog:
        
        * start Calc
        * add more sheets
        * hide some of the sheets (e.g. by right-clicking them
          in the bar at the bottom, "Hide Sheet")
        * select "Sheet" -> "Show Sheet" in the menubar
        
        Change-Id: I4c4c0dca67dd6325f7145254f40452cc7000a783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177542
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [5d8fb68823c3f6fdc0ab3d1abfac8c7283f22eb9]

        tdf#130857 qt weld: Implement basic tree view logic
        
        Implement a small subset of the QtInstanceTreeView
        methods - basically what is used by Calc's
        "Sheets" -> "Show Sheets" dialog for which
        support will be declared in an upcoming commit.
        
        In QtBuilder, ignore "GtkCellRendererText" and
        "GtkTreeSelection" objects, just as VclBuilder
        does.
        For now, also don't implement logic for handling
        "GtkTreeViewColumn" objects yet, but add a warning
        that this is still missing.
        
        Use QStandardItemModel for the tree view's
        model.
        
        For those methods where not all possible
        parameters are handled yet, add asserts
        that will trigger when called with currently
        still unsupported ones, so this can easily
        be identified when working on support for
        dialogs using more complex tree views in the
        future.
        
        QtInstanceTreeView::get_height_rows logic
        to return the required height to show n
        entries also still needs some thought, so the
        method simply warns and returns 0 for now, which
        means that the tree view might not be shown with
        the ideal initial height, but resizing the dialog
        is sufficient to work around that for now if needed.
        
        Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-30  Rosh  <roshsiddiq@gmail.com>  [71ec40df421dea0540b4245c5d590f87c57e33e7]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I2495fa1ad081ad75bd8e79a22bdeaa97217aa398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177581
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [5a42e163cd5c6427fe46d19b43a57cb09b57cc14]

        tdf#163483: implement export of Math formula's fallback image to PPTX
        
        This was left as a TODO in commit cb890ae43bacd2be24bc74fad2e2e5cce8910995
        (oox: export Math objects to PPTX files, 2016-01-15). Now after commit
        7cfff4751befd678b3db4b6f16b020d38f4e9c32 (Related: tdf#129061 Avoid formula
        import and use fallback for now, 2024-09-11), that relied on the fallback
        being present, our exported documents lost the formulas completely on load.
        So the fallback export became a necessity.
        
        Change-Id: I52d4ef0400ce72ee10fda10a1131b4ba29ea56be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177564
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-29  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [44ccd392be12dad23e216fb3eb2c2e5b275eee75]

        LibreOffice Theme Part 2: GTK Color Customization
        
        Most of the UI is covered by themes. The icon theme changes
        automatically to light or dark based on the window color. Further
        improvements will be based on the feedback from the users.
        
        Change-Id: Ia63ee608fe7870bc7cc86abb892f5fd5d6f1d8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168829
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [590e7a3db2a3889ddea1a99b4460a737f19b823d]

        make screenshot: add missing dependency to AllLangMoTarget
        
        without the translations, the screenshots for all languages will only
        have the English strings
        
        Change-Id: I9a82da905c74457c0813ca3efb2d6d0ba31a0f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177563
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-11-29  Jonathan Clark  <jonathan@libreoffice.org>  [f23c1baa4646957ad8a7060376638935a5e87889]

        tdf#164062 i18npool: Added da_DK as a prepostdash language
        
        Previously, Danish words ending with hyphens were not handled correctly
        during spell checking. This change fixes the issue by modifying the
        da_DK locale to reference the existing breakiterator rules for languages
        with word-final hyphens.
        
        Change-Id: I9b08fb5246b5b846814dc3b4b9ba249b29fc7a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177504
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-29  Justin Luth  <justin.luth@collabora.com>  [eaef1432bd0799bbed8dcbd6286942ed1d54ad90]

        tdf#163872 ScTable::SetOptimalHeight: use better way to iterate rows
        
        I stumbled across GetNextValue while looking how I could optimize
        GetValue's use of Search. Since this function needs to iterate
        through every single entry, it was relatively expensive to
        "Search" for the beginning row each time, when we know it will be index++.
        
        Change-Id: I1bc7b6b041b7836aebc4cd2bfd9214851804bf31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177561
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-29  Manish  <mbera.dev05@gmail.com>  [6c0b18e06a83648478a55db45783868f583936b0]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I8b71f1af2841846bfbdc7a1f63e7014f338bf41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177543
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9c0443de3981256ffdb438a4b5ac4f7dd68c574d]

        tdf#158237 connectivity: use c++20 contains() instead of find() and end()
        
        Change-Id: I2e047407e771b75323898ecf096721b8f3600ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176799
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [eb8e6ddd6a4c2336c882644462aecc4359766695]

        tdf#158237 dbaccess: use c++20 contains() instead of find() and end()
        
        Change-Id: I03e682093bff3b743b074d0d1dc68994f31ae707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176800
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [905fa8f49d98d7ce986333b781f0462be6dfa49e]

        tdf#158237 chart2: use c++20 contains() instead of find() and end()
        
        Change-Id: I4b02c5b4dca22bce5653dad1d179ea2a1b249a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176798
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>

2024-11-29  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [991a7b44da24cce0a828ec8f2d7472ce76cbab79]

        tdf#158237 sw: use c++20 contains() instead of find() and end()
        
        Change-Id: Ic8622a035fcd3c8a4a9883db9df8275cf6b10a30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176801
        Tested-by: Jenkins
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [383e3aef8438141bfc953f0cca094f6d3d7ed007]

        PVS: V773 The return value of function 'lcl_CopyStyle'...
        
        ... is required to be utilized. A memory leak is possible.
        
        Change-Id: Iae82c6a9dd124ac073c0eb99141d4104b1e05101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177551
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [050e827b5ce09b0fc528667710d604c2242701f4]

        add some comments to weld::ComboBox
        
        because it took me a while to figure out the magic value here
        
        Change-Id: I9a188d23a1f5aaac1bff10f795a916bc30cfb7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177534
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [b938c891e1b74c887ff1a849576965e5462c6287]

        fix various getSelectedItemPos implementations
        
        clearly we do not often have combobox's that have nothing selected,
        otherwise these issues would have arisen sooner.
        
        The immediate cause of fixing this was the assert
        VCLXListBox::getSelectedItemPos which was triggered when using X-ray to
        examine a writer document
        
        Change-Id: Ia5ec713ef54a841010a9b680d4520f7160d48167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-29  Michael Stahl  <michael.stahl@allotropia.de>  [0795698c1c82b4026a0f6acdfba5c6b93c8e1412]

        sw: layout: fix toggling Hidden Paragraphs not shrinking flys
        
        There are 2 as-char flys with 2 hidden paragraphs each, and when turning
        off show hidden paragraphs, the paragraphs shrink to height 0 but the
        flys don't - this is because due to other hidden paragraphs earlier, the
        position of the flys change and Shrink() is called before MakePos() and
        then it uses the old position to check and that results in a negative
        nRstHeight, so the upper doesn't actually shrink.
        
        Fix this by always calling MakePos() before MakeValidZeroHeight().
        
        (presumably regression from commit
         0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups)
        
        Change-Id: I9a4ffadff02b6a2bc59c6a37aa15abec429e1068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177524
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-29  Michael Stahl  <michael.stahl@allotropia.de>  [a60f016a89787a818e868fbfa5b714853ff44a78]

        sw: layout: fix toggling Hidden Paragraphs that have follows
        
        When a hidden paragraph is split across pages, there is nothing that
        joins its follow (SwContentFrame::MakePrtArea() has code to do it but it
        wasn't called even before the previous commit?) and when the follow is
        formatted is doesn't move back.
        
        So just join all follows asap in SwContentFrame::MakeAll().
        
        (presumably regression from commit
         0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups)
        
        Change-Id: Icecdf17c1c1e11a3b62c7e5bf2c6624f234c94f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177500
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [27509505be691b2f37d50d5c60ef1cea87357671]

        loplugin:unusedmethods tweak for less noise
        
        Change-Id: Idedd1680b03f6b62ff80ad7d0fd74c11d1675053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-29  Jonathan Clark  <jonathan@libreoffice.org>  [f4fe6df6aa92573368c3fa0edb9fd03e64d9d059]

        tdf#162514 i18npool: Handle abbreviations in dictionary breakiterator
        
        Restores abbreviation handling to spell checking.
        
        Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700
         "tdf#49885 BreakIterator rule upgrades".
        
        Change-Id: I2883f984952aa3e54cfe800590a16c0de74ae0e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177506
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [60df7e1052e4ec0a33978df8af8afd65196dbd8c]

        PVS: V614 Potentially null smart pointer 'pFillData' used
        
        Change-Id: I3026788bc8a239dc467b0a43c865c9659f392108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177540
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-29  Michael Stahl  <michael.stahl@allotropia.de>  [0a3f5169acc6708c352cad0fa07fdb4af8c8b2dd]

        sw: layout: fix toggling Hidden Paragraphs resulting in bad layout
        
        1. SwContentFrame::MakeAll() needs some more checks to ensure that it
           never Formats a hidden text frame. This fixes the reported problem
           that turning off "Hidden Paragraphs" in Tools->Options->Writer->View
           results in bad layout (extra completely empty page at the end).
        
        3. This means HideAndShowObjects() must be called manually in that case
           as it was previously called inside Format(), see
           testHiddenSectionFlys.
        
        2. SwTextFrame::Prepare() as called from calcing some upper (table cell)
           in the bugdoc needs to avoid invalidating a hidden frame so it isn't
           formatted (triggered new assert).
        
        4. SwLayAction::IsShortCut() had what looks like an obvious and ancient
           mistake that was causing a crash in testTdf155011.
        
        5. SwTabFrame::MakeAll() should not calc the next if it's hidden, that
           was causing a problem in testThemeCrash where a hidden frame moved
           back into an overfull body and immediately forward again, triggering
           the new asserts.
        
        6. SwTextFrame::IsHiddenNow() caused interesting problem where some
           ancient (CVS import) check for a 0 width would skip the invalidating
           due to the 2. change when called from SwViewShell::Reformat() ...
           lcl_InvalidateContent() in testParagraphMarkInCell; unclear why this
           check exists, let's avoid it for the cases where we definitely know
           that only doc model should determine visibility.
        
        7. JunitTest_sw_unoapi_1 triggers new asserts because MakePos() in a
           cell ends up invalidating the text frame; fix it up again.
        
        (presumably regression from commit
         0c96119895b347f8eb5bb89f393351bd3c02b9f1 or one of its follow-ups)
        
        Change-Id: I619f4be852eca5124f49d9a91e1de658b7070074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177486
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [93eb912f109bc25ba84861f39d1d6d8fe4c58f47]

        cid#1606728 Overflowed integer argument
        
        Change-Id: I6fef2b6818018b8a0f82125ef2d8220688d642a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177536
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8aea35ec4f19419b714879eb09fc6658fd3eeb1f]

        crashtesting: failure to export forum-mso-en4-491312.xlsx to ods
        
        probably since:
        
        commit 65129e0bc5abfe7afc612eb46f1434e627265a7d
        CommitDate: Tue Feb 2 22:06:18 2021 +0100
        
            tdf#137081, tdf137082 fixes shape handling in RTL sheets
        
        Change-Id: Ife720a0ccbff0029ace822d246dc227e01846734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177537
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-29  Patrick Luby  <guibmacdev@gmail.com>  [c585b697b583fa0f8cdadeab594c31d270367ba7]

        Related: tdf#163945 don't directly flush graphics with Skia/Metal
        
        When dragging a selection box on an empty background in
        Impress and only with Skia/Metal, the selection box
        would not keep up with the pointer. The selection box
        would repaint sporadically or not at all if the pointer
        was dragged rapidly and the status bar was visible.
        
        Apparently, flushing a graphics doesn't actually do much
        of anything with Skia/Raster and Skia disabled so the
        selection box repaints without any noticeable delay.
        However, with Skia/Metal every flush of a graphics
        creates and queues a new CAMetalLayer drawable. During
        rapid dragging, this can lead to creating and queueing
        up to 200 drawables per second leaving no spare time for
        the Impress selection box painting timer to fire.
        
        So with Skia/Metal, throttle the rate of flushing by
        calling display on the view.
        
        Also, with the reduced Skia/Metal flushing load from this
        fix, the color conversion when drawing to an NSBox appears
        to be no longer needed. The converted color appeared less
        saturated, at least to me, so accept the (hopefully now
        imperceptible) performance hit of drawing an NSBox with
        native colors.
        
        Change-Id: I55b4ab763bf20c6c2acad65587b703fc6f645264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177530
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-11-29  Michael Weghorn  <m.weghorn@posteo.de>  [9f5dfd3986e9c51b5e33b58d6acb0629e19e5d00]

        tdf#163989 a11y: Avoid "showing" event on empty notification label
        
        The label in the search bar has a notification a11y role
        in order for the text (like "Search key not found") to
        be announced when screen readers receive an event indicating that the
        notification became visible (an object:state-changed:showing
        event for AT-SPI on Linux).
        
        However,
        
            commit 48ba98a51f029cd14b5d982dab36eb581d40fef3
            Date:   Wed Nov 29 14:29:57 2023 +0100
        
                Resolves tdf#158412 - Don't show chevron in quick find bar
        
        caused this event to be triggered also when the label has no
        text, which resulted in Orca just saying "Notification", without
        any indication what that notification might be.
        
        Avoid that by not setting the label to hidden at the beginning
        of LabelItemWindow::set_label if the label text is empty, so setting
        it to visible again doesn't have any effect if it's already visible
        when the method gets called.
        
        An alternative might be to switch to using dedicated
        notification events instead of using a label with
        a notification a11y role, now that that kind of event
        is available in AT-SPI2 since at-spi2-core-commit [1]
        
            commit 26835da29918be2c0da6c08fb70d893de22891d2
            Author: Mike Gorse <mgorse@suse.com>
            Date:   Thu Aug 4 12:38:27 2022 -0500
        
                    Add an "announcement" event/signal to allow objects to send notifications
        
                    Fixes #63
        
        [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/26835da29918be2c0da6c08fb70d893de22891d2
        
        Change-Id: Ia4fbf9544f72e10c74e92487619222d59f55cfa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177523
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-29  Miklos Vajna  <vmiklos@collabora.com>  [9f25e61d0e9bbd762ef6da063c16c65e53c9c980]

        sfx2 lok: fix crash in SfxLokHelper::notifyOtherViewsUpdatePerViewId()
        
        Crashreport signature:
        
        > SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
        > program/libmergedlo.so
        >       SfxLokHelper::notifyOtherViewsUpdatePerViewId(SfxViewShell const*, int)
        >               sfx2/source/view/lokhelper.cxx:1098
        > program/libswlo.so
        >       SwSelPaintRects::Show(std::vector<rtl::OString, std::allocator<rtl::OString> >*)
        >               sw/source/core/crsr/viscrs.cxx:514
        ...
        > program/libswlo.so
        >       SwWrtShell::SwWrtShell(SwDoc&, vcl::Window*, SwView&, SwViewOption const*)
        >               sw/source/uibase/wrtsh/wrtsh1.cxx:2032
        ...
        > program/libmergedlo.so
        >       framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        >               framework/source/services/desktop.cxx:592
        
        I.e. it can happen that during load we don't yet have a view, similar to
        commit a2b22f5b551cb2030cd29d3dd3510fca42a0bfc1 (sfx2 lok: fix crash in
        SfxLokHelper::notifyUpdate(), 2024-11-26).
        
        Change-Id: Id17a61296a181a2ba4909b633d46a3c9d7aacb02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177525
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [caf0071d604eca7fc7b89e9ecfa7a686157ca797]

        fix refreshing git-hooks when using git-bash
        
        real symlinks require admin-rights or developer mode, and the other
        fallback mechanisms won't work for the version of git that comes with
        git-bash. Either spawning the process failes or worse it silently fails
        and basically ignores the hook.
        MSYS uses regular file copy when using "ln -s" which means to make sure
        the current version of a hook is used the hooks need to replaced
        everytime or the file contents need to be compared. When using hardlinks
        instead it is enough to check whether the source and target share the
        same inode.
        
        Change-Id: Ib2e325048779828313afc7fc9d120661d55fc3a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177498
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-11-29  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [216a3b2f22304665cbd7a6f16176cb29560b95de]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0fdcd7916f2e59da20419d408cad8bcb909c5ae5
          - Updated the English dictionaries: GB+ZA
            
            Change-Id: Ifea0bef5714162def9b5adc7dd20c1d6d69d05e0
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/175966
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            Tested-by: Aron Budea <aron.budea@collabora.com>
            
2024-11-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2145204724049cad1585743c0b980ed2c6561212]

        tdf#163325 - Check Lower() frame during ToC preview
        
        Change-Id: Ife0e974d66d5ddbe3c831c64e4da28442e476da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177234
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-11-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1070fa0e5ddce15f92e873ae96d45104ba71b6cc]

        pdf: R6 hash algorithm and test, introduce PDFEncryptorR6
        
        This adds PDFEncryptorR6 and adds R6 hash implementation and makes
        sure it is correct with a test.
        
        Change-Id: I11ca746a6b676bb294723b4ef76069f1d4f3a182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177384
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [a2dbdee29e0a02401647d2303abc867c55dd12c7]

        PVS: the 'bDummy' variable was not initialized.
        
        This variable is passed by a reference to the 'readArguments' function in which its value will be utilized. Inspect the fifth argument.
        
        Change-Id: I39d71ac5e76d3d9a808fa08a430af9aa0686684d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177494
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [13ac356a32f279a3fd542d62c12e58abe3d3ad30]

        tdf#164048 sw a11y: improve error/warning levels with
        
        adding two A11y issue level: Error and warning level, and
        categorizing our accesibility issues based on how the
        PAC 2024 tools and WCAG behave with the different warnings/errors.
        
        Change-Id: If4e4800497340318bb990326c64de655f24a47e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177389
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-11-29  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7dc626a6cd3895d206320e0ddc1412749d1663a7]

        lok: slideshow: animated shape bounding box in twips
        
        Since we have slide size in twips we need shape bounding box in twips
        too.
        
        Change-Id: I41e4658278e7b36b87a6bccc72b429944ef27e4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177522
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-29  Michael Weghorn  <m.weghorn@posteo.de>  [32642136ad7ba0426f71d335730a3afe02524215]

        tdf#130857 qt weld: Implement QtInstanceTreeView::set_selection_mode
        
        Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f41481fe987b3c183ac3edbd946ecff38721a79]

        cid#1607551 silence Overflowed constant
        
        Change-Id: I128a60a312fe15a3333bd7dad37257c80fb20d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b425ad0247d09466f26398c717d9b3c8beee69e]

        cid#1634810 Overflowed constant
        
        Change-Id: I634a88af23116fd823b9b595cdb801a032593688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e854f1d7a0a3a8bac6429a1dbe80ab2a6973c00a]

        m_pDocShell seen as null in SwXTextDocument::getPostIts
        
         #2  SwView::GetPostItMgr (this=<error reading variable: Cannot access memory at address 0xc8>) at sw/inc/view.hxx:659
         #3  SwXTextDocument::getPostIts(tools::JsonWriter&) () at sw/source/uibase/uno/unotxdoc.cxx:3351
         #4  0x00007f6238ac7cc8 in getPostIts (pThis=0x36aa6cb0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/ext/atomicity.h:111
         #5  doc_getCommandValues () at desktop/source/lib/init.cxx:6739
         #6  0x00000000005863e0 in lok::Document::getCommandValues (pCommand=<optimized out>, this=<optimized out>)
            at /home/collabora/jenkins/workspace/package_cool_24.04_rpm/rpmbuild/BUILD/coolwsd-24.04.9.2snapshot/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:492
         #7  ChildSession::getCommandValues(StringVector const&) () at kit/ChildSession.cpp:1180
        
        Change-Id: Ib2a3c2e7eb1a108ad969588f6c313cade145e8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176600
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit c0542a438d91051bcdab1f5bc19ee46c90bd91a7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0090640f882309f1ad07466054fb29b0ed10cb6f]

        cid#1635775 Use of auto that causes a copy
        
        looks like a stray line I think
        
        Change-Id: I065a35d6e161c37d832e308f7ed1ce239e4e2bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177516
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7c6bc0bda7ed0c3dfa46b60face255160df2c19]

        tdf#164046 style searching improvement breaks Impress layout
        
        regression from
            commit 6c2f827697b898c9d351b79c2dbb5aefc8b70dcc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sun Oct 20 15:07:41 2024 +0200
            improve style searching in SvXMLStylesContext
        
        Two problems - the original code was searching by DisplayName,
        not Name, so add another index for DisplayName,
        and the prefix matching was not properly matching.
        
        Change-Id: Ifd43bdb89d33067954298115c8700b87c7f93050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177488
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e627686deb33a7eef013da7bbdbe18871b87b172]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc50ebde81a0e9266806878b69de81da422ec39c
          - Revert "enable help for Tagalog (tl)"
            
            This reverts commit 3d37519d37c1ac9e5d30b45f1cd922c73107d4d1.
            
            Reason for revert: apparently not all files have been added for master
            
            Change-Id: Ia0979a8abca4aa598563598276c9a9c0e0518a33
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177515
            Tested-by: Jenkins
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-11-29  Weblate  <noreply@documentfoundation.org>  [80d4ce197f2b9b38ce6af6ed18eb159edd24be5f]

        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: I6f6529872aa3c3cf3553eacebe280195fa5f0699
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: eduver <hmcb2080@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177478
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-29  Szymon Kłos  <szymon.klos@collabora.com>  [70d054a3da47362adf81442c399bc5bd3cfe43c3]

        lok: jsdialog: enable font name box after save
        
        When we save - we block UI. In the lok we disable that for
        some cases like in commit e005690e9c648ce516c1ed60da6341c7215bf2c9
        lok: avoid sending jsdialog messages during background save.
        
        But we also use save file to generate previews of shapes what happens
        on eg. resize in Online. Then we trigger disable and enable cycle
        for frames - and we end with FontNameBox enabled!
        
        That was causing the JSDialog combobox still being locked - because
        frame unlock was using direct VCL API, not weld:: one in the
        InterimItemWindow. Let's fix that with proper StateChanged handling.
        
        So now it is functional. But still I think there is some error in the
        logic - as after save we should beg the "before save" state of control
        not "always enabled". But it's different problem.
        
        Change-Id: Ia8e5c8c864156271b5f68d482234e83eb57b0deb
        (cherry picked from commit cbe229ec219e56ce1bb5dd9598f9052a98504249)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177489
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-11-29  Simon Chenery  <simon_chenery@yahoo.com>  [678f732d9cc5b9a73e633d77bd2d1ae34700ed3d]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I596245603c0945438a940465122cb4c3e6954e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177140
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-29  Oliver Specht  <oliver.specht@cib.de>  [40436e1dfdad42690cc0cfc4781c38e5419e0dc5]

        tdf#146553 Enable additonal functions in editable section while in r/o mode
        
        Insert/Edit table, insert lists, insert AutoText
        automatic spell checking
        
        Change-Id: Iccef3965316dc6079ea56a0283023c5a658512cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165031
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-11-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b440a03b30bfa5637b60dfe112d663375449d136]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aa5fa6c008064ee28c01354b1f40920b2de83b2c
          - Mute L10N in Navigator context help page
            
            Change-Id: I5211d028909ca140fbe2d9eed6fa57cbf57b84c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177510
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [d81894231794c7a570bef1a5991056a325a7d61e]

        sc a11y: Make 2 members non-mutable
        
        ... and use a non-const pointer when iterating instead.
        
        Change-Id: I165b0ce907cadacc76562bff974ff913a3a711da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177480
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-28  Jonathan Clark  <jonathan@libreoffice.org>  [7e4f4a0ccd3c56093dec44c7dcdd14c8b34623c3]

        tdf#163913 Implement font-relative margins
        
        This change adds loext:margin-left and loext:margin-right, which
        implement margins that support font-relative units.
        
        See tdf#36709 for additional details.
        
        Change-Id: I31b0dd2b6f98cb5b02fd4dca3608db6fdee4054c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177473
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-28  Manish  <mbera.dev05@gmail.com>  [c73e52d295c97e1ce35ad7066d0e92982e897e29]

        tdf#143148: Replace include guards with #pragma once in XpmReader.hxx
        
        Change-Id: I2708f103cb9e63294cd2ee056dc490c734285a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177487
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b944488aad7c2460824d9f344704004ed6c4fe49]

        crash seen in export of forum-mso-en-2962.doc to rtf and reimport
        
        Change-Id: I3813d8ebcb1e678ece2e3c3554bb0ddb7b546b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4c9b1291e9db623614ecdbaf875ec29826fa3d4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3d37519d37c1ac9e5d30b45f1cd922c73107d4d1
          - enable help for Tagalog (tl)
            
            Change-Id: I0e35015d4d2526ea0d09404140a1ee73ce658350
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175653
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Tested-by: Jenkins
            
2024-11-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2fd5fc442bee1e73561bb7d2dd7922627b76e50d]

        Fix typo
        
        Change-Id: I8ac3024a3865a5e2e45d9eca70f1ca5e067971c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177495
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7489c032a33b6a14b20d389b6a10f5daeb853e95]

        cid#1607902 Overflowed constant
        
        Change-Id: Id43616644bc8495a6a5944de099ddfc29016bbe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177484
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb5c088c008fe1c83d9dbfa1537f91f0678d3c80]

        clarify that nNum is reused for two different things
        
        so the first use of nNum is dead after scope
        
        no logic change intended
        
        Change-Id: I81a51531418b32a09f5b9dba1131bc65ac71df3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b85f012ff816533299fb35707825c9f9eb652bb]

        we can deindent this and make it conditional
        
        given that we return early on the opposite condition
        
        no logic change intended, git diff -w is your friend
        
        Change-Id: I37b7db3a1d092ffbe0ef41561982555f6b6d3bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177482
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ea24f2356211530e5ee3517d7e5c764e06d751f2]

        return early if bUseChkStr is true
        
        no logic change intended
        
        Change-Id: Ie1b4d15af35b01c9f490db7eb33c9493775ab9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177481
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-28  Michael Meeks  <michael.meeks@collabora.com>  [58249677c3330b5238a7f6ee665c923d93464bc9]

        cool#4250 - add API to set per view options.
        
        Change-Id: I5e3b3b3548ba93b96b33fe682405a2b0b53bbdee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176715
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 8dcb86a4a724f143f7d5cfcc3d1231a7f924cbd9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177445
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-11-28  Marco Cecchetti  <marco.cecchetti@collabora.com>  [75a241e7c70df69525a777e0ecdef17b38aec974]

        lok: getSlideShowInfo: interactions: check that properties are available
        
        Not all properties are available for all kind of shapes.
        In this case Visible is not available for a SvxFrameShape.
        
        Change-Id: I7811ab6cd04d782f8758fbee449bbc5bc421fd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177470
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-28  László Németh  <nemeth@numbertext.org>  [32398232e925d18d2ac5a6d467b61e1a84a0df7c]

        tdf#164074 sw inline heading: add up/down outline moving
        
        Move inline headings with their outline tree in
        Navigator, clicking on the Move Heading Up/Down icons.
        
        Instead of changing CompareSwOutlineNodes, which breaks
        the code at other places, add a new SwOutlineNodesInline
        and CompareSwOutlineNodesInline to sort inline headings
        (put in Inline Heading frames) with normal headings only
        for MoveOutlinePara and other part of Navigator's
        outline moving.
        
        Reordering chapters and sections using the Navigator was
        limited for normal (root) headings, but not for headings
        in text frames and tables.
        
        Recent implementation of inline headings use text frames
        with Inline Heading frame style, anchored as characters
        to their paragraphs. Now these inline headings are movable
        with the Navigator, with their outline tree, i.e. the paragraph
        where the inline heading anchored as character, the following
        paragraphs without inline heading, or the following subsections.
        
        Note: selecting the inline headings is possible by the Navigator
        content tree or or by clicking inside the text of the inline
        heading in the document.
        
        Note: according to the fix for tdf#143569, multiple headings
        in the same text frame or table are ordered alphabetically in
        the Navigator. This doesn't effect the inline headings, where
        there is only a single heading in an Inline Heading text frame.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export"
        and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf48459 sw inline heading: add Inline Heading frame style".
        
        Change-Id: I7618aa1d4e1ddc20512d81c9a2babfa660053cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177438
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60047110c19a403e51c767cb003b0cf989f6b2bc]

        Fix typos
        
        Change-Id: I60eaa9de20577ef7c7930c3ade23851c91ea3260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177475
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3c9a4e222ab3a0d4cb1014deaa5138e8f5a35b73]

        loplugin:fakebool
        
        Change-Id: I41d767833eb3dbc4264c1d6b63b7ddb71e422472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177469
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [83a06bf09e18bcc0028739d3dbe67617f007fbe9]

        loplugin:reftotemp
        
        Change-Id: I6ec03b1c3238a9c222444078b3d9b5ccb40d81d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177468
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [7ccde3fecfc496f8a57d699880e51432f7660d88]

        Simplify a bit
        
        The creation of own TransferableDataHelper was needed when the code
        was introduced initially, taking a reference to XTransferable; now,
        when it already takes a helper, it's no more needed.
        
        Change-Id: I4c42327ab9b964c61572be13a4a89b44efc8d343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177466
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c8fb04402878fcf1c62f68b8d4838e98553f72b5]

        This is likely the correct object to use here
        
        In commit 5e6def1bd4e36379e8dce78402820540bd6f02e2 (Redesign for XTransferable,
        2001-01-19), a code was introduced, that used two different pPickObj variables.
        Later, in commit 507aced21a19deba279029bbabeca24562381824 (INTEGRATION: CWS
        sdwarningsbegone (1.68.10); FILE MERGED, 2006-12-12), the name conflict was
        fixed; but that fix changed the object used here, from the nearest, that was
        just initialized in the current scope, to the one that was optionally assigned
        early in the function, depending on a variable not used in current scope. I
        assume that that was an overlook; so fix it now.
        
        I don't have a failure case, just found it by code reading, so this could be
        wrong, and need be reverted, hopefully with an explanation.
        
        Change-Id: Ib95bc450b78f64e1ac468e9676f32395ddaf0870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177464
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [cb53c054dd92777bffbe2d33c14f992596b93d64]

        Use correct object
        
        A potential dereference of nullptr was introduced as renaming overlook
        in commit 507aced21a19deba279029bbabeca24562381824 (INTEGRATION: CWS
        sdwarningsbegone (1.68.10); FILE MERGED, 2006-12-12).
        
        Change-Id: I4cf787e3ec3e1819040368d17279cae4db391bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177461
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c70fa22d147db736f06a7513b5e2fa82d66b60bf]

        Return from functions, instead of using out arguments
        
        Change-Id: Ie57bf41790800cc3bc83e0785a9063643d700c1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177458
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [27c95bb44572fe3d9253c0ee2660e17590d0e705]

        svx: Simplify "Go to Page" dialog, let SpinButton do its job
        
        Set the allowed range using weld::SpinButton::set_range
        so that weld::SpinButton makes sure that a value within
        the correct range is set, instead of having a custom
        handler called when the text of the spinbutton changes
        that effectively does the same thing (+ manually setting
        cursor to the end of the edit, but sticking to the toolkit
        default there instead makes sense to me for consistency).
        
        Adjust the test case to no longer type invalid input
        for the page number ("3a"), as SalInstanceSpinButton
        doesn't parse the number then, but would set the value to
        the minimum (here: 1) instead.
        (If a different behavior were intended here, that
        should be implemented in SalInstanceSpinButton or
        the underlying VCL widgets to be consistent
        across dialogs.)
        
        In GotoPageDlg::GetPageSelection, use weld::SpinButton::get_value
        to get the integer value right away, instead of
        getting the text and converting that into an
        integer manually.
        
        All that custom handling provided an interesting test case
        while implementing support for that dialog using native
        Qt widgets, see commits up to
        
            commit 70825e677f808437bd47651ebecc8a0c53955676
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Nov 28 00:30:10 2024 +0100
        
                tdf#130857 qt weld: Notify about spinbox combined value+text change
        
        , but apart from that (which is done now), I think
        that a more standard approach makes more sense.
        
        Change-Id: I06492b6629a4210c6325d50467da8e195daa4c94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177463
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [94081225aa7925cbeea359446d50c2daccc3a7b4]

        PVS: V612 An unconditional 'break' within a loop.
        
        Change-Id: I512969e1583f780b54c035f6a3c3c3e14e783016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177472
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e805281f6ffe1e2c0d8a36edea93122b43c94bb7]

        don't need to check for null twice
        
        since:
        
        commit 1ae71d8f09771ba7180be6ebdf89d36a31eb8625
        CommitDate: Fri Dec 16 20:18:04 2022 +0000
        
            Revert "fix math export/import in docx/rtf"
        
        tidy up here, and possibly
        
        commit ef533553559fe09b4afab651fc692885d1acf4ed
        CommitDate: Wed Jan 4 13:49:58 2023 +0000
        
            Rudimentary support for dynamic_cast on UNO proxy objects
        
        is also relevant
        
        Change-Id: I27548c5071df4f3231a49a1ee47fa72d0a93148c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177471
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [ff3d9ab6ecda2a1b8a3e7d39865cf0dbde916df6]

        tdf#130857 qt weld: Drop unused header
        
        Change-Id: I93571abf7f056f51039672d03a7bcfc1d6bb6dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177465
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50fec9db063edd2fdf63ca22277ef16b3727ca4c]

        crashtesting: unbalanced rtf {} on inability to export a math object
        
        Seen in export of forum-mso-en-11772.docx to rtf and reimport
        
        so rtf cannot be imported, a problem probably since:
        
        commit c14355592ccc249500ca58b3607888db195b06c0
        CommitDate: Tue Dec 31 18:02:07 2013 +0100
        
            Related: fdo#66440 RTF export: handle NULL component in FlyFrameOLEMath()
        
        A problem with casting the uno proxy obj probably got fixed with:
        
        commit ef533553559fe09b4afab651fc692885d1acf4ed
        CommitDate: Wed Jan 4 13:49:58 2023 +0000
        
            Rudimentary support for dynamic_cast on UNO proxy objects
        
        At least now converting the original test case to rtf doesn't crash for
        me on export, and now uses "if (pBase)" to keep balanced and at least
        output a preview image if not the math text content.
        
        Change-Id: Ib428ab89fac6f36f1fa8e3bd7b3b01cd0a889d7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177442
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dee760e92c9aa18f5335e3e43dabb504f012dfaf]

        comphelper: put each Crypto impl. in own file - minimize ifdefs
        
        This puts NSS and OpenSSL implementations into own classes and
        adds an interface to make this possible. The implementation is
        now determined in Library_comphelper.
        
        Change-Id: I4918f19bca0adfd2f9180fb418d1bd57bb83982d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177383
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [4908455dc5b44d801eca1db22d902355c83ee64f]

        PVS: V612 An unconditional 'return' within a loop
        
        Change-Id: Id7f54dd27a33cb4979e4d2594002ace25e65b34f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177441
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [211389c2d35188adc6f4e110378dd526746b6e8a]

        Flatten
        
        Change-Id: I68a38cd7b2bf2dd966b357d81b6831790a229392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177457
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [8bb3778952ca5adf641f0382e4279ad55594b424]

        Only sort if had a chance to add something
        
        Change-Id: I54ec1368ab64d422de13217e877076a3ee41de94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177456
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [70825e677f808437bd47651ebecc8a0c53955676]

        tdf#130857 qt weld: Notify about spinbox combined value+text change
        
        While QtInstanceEntry generally takes care of handling signals
        for the spinbox's QLineEdit, this doesn't work when the value
        is changed as a result of setting a new spinbox value (e.g.
        by using the spinbox buttons), as the QLineEdit signals are blocked
        then, see QAbstractSpinBoxPrivate::updateEdit in qtbase [1].
        Therefore, connect the QDoubleSpinBox::textChanged signal
        to the slot that calls signal_changed() instead to ensure
        it gets called nonetheless, and disconnect from the other signal.
        
        While at it, also add a SolarMutexGuard when calling the
        signal.
        
        This fixes the issue noticed with the "Go to Page"
        dialog mentioned in previous commit
        
            Change-Id: I1f24cf3925e945ae78a9f1646535e08736cd8786
        
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 27 23:53:58 2024 +0100
        
                tdf#130857 qt weld: Support "Go to Page" dialog
        
        as:
        
        > One issue seen with the dialog is that by using the
        > up arrow of the spinbox to increase the value, it
        > is currently possible to increase the value
        > beyond the maximum value (last page number),
        > while this is not the case when typing a number
        > into the box manually.
        >
        > This is because the GotoPageDlg::PageModifiedHdl
        > handler currently only gets called for the
        > latter case, not the former one, despite
        >
        >     Change-Id: Ie19bc852f4ceed0fa79565302975376db7126ea4
        >     Author: Michael Weghorn <m.weghorn@posteo.de>
        >     Date:   Wed Nov 27 22:53:55 2024 +0100
        >
        >         tdf#130857 qt weld: Also notify about programmatic text changes
        >
        > and will be addressed in a separate commit.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/widgets/qabstractspinbox.cpp?id=ced47a590aeb85953a16eaf362887f14c2815c45#n1790
        
        Change-Id: Ifba9a0877442f9e84f0103d8aab202ae3583c5cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177451
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [d765cdc515d3808898bf8bb5d78335fdee2d698b]

        tdf#130857 qt weld: Support "Go to Page" dialog
        
        Declare support for the "Edit" -> "Go to Page" dialog
        available in e.g. Writer.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        One issue seen with the dialog is that by using the
        up arrow of the spinbox to increase the value, it
        is currently possible to increase the value
        beyond the maximum value (last page number),
        while this is not the case when typing a number
        into the box manually.
        
        This is because the GotoPageDlg::PageModifiedHdl
        handler currently only gets called for the
        latter case, not the former one, despite
        
            Change-Id: Ie19bc852f4ceed0fa79565302975376db7126ea4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 27 22:53:55 2024 +0100
        
                tdf#130857 qt weld: Also notify about programmatic text changes
        
        and will be addressed in a separate commit.
        
        Change-Id: I1f24cf3925e945ae78a9f1646535e08736cd8786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177450
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [12fb40fd7bc771813b825806cb4151833d7cd789]

        tdf#130857 qt weld: Let SpinButton derive from Entry
        
        As weld::SpinButton derives from weld::Entry,
        also let QtInstanceSpinButton derive from
        QtInstanceEntry, instead of duplicating code
        by reimplementing all of the weld::Entry methods
        anew.
        
        As the QtDoubleSpinBox derived from QDoubleSpinBox
        itself is not a subclass of QLineEdit, it cannot
        itself be passed down as the widget to the
        QtInstanceEntry ctor.
        Pass the spin box's QLineEdit instead. Make it
        available by adding a new QtDoubleSpinBox::lineEdit
        method which overrides the base class method of the same
        name that is protected.
        
        With this in place, QtInstanceSpinButton is now
        the only QtInstanceWidget subclass where the
        widget passed down to QtInstanceWidget is not
        the same as passed by QtInstanceBuilder in
        the QtInstanceSpinButton ctor, i.e.
        QtInstanceWidget::getQWidget does not return
        the QtDoubleSpinBox, but it's line edit.
        Therefore, make QtInstanceWidget::getQWidget
        virtual and override it in QtInstanceSpinButton
        to return the spin box.
        
        Drop the QtInstanceSpinButton methods of all
        methods already implemented in QtInstanceEntry.
        
        Change-Id: Ide2e1fe91216a5ec7f90a4f72ae34e3f63f624d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177449
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [68203597e1e2fe2525dc2a8dbced468070ee7074]

        tdf#130857 qt weld: Handle special value -1 for cursor pos
        
        Implement special handling for cursor position value
        of -1 according to the comment above weld::Entry::set_position
        in include/vcl/weld.hxx:
        
            // nCursorPos can be -1 to set to the end
        
        Change-Id: I078d2123f391cf1fcab6f40d26309e2a2eb2315f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177448
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [83ec1e723061dcbb8a35c9fb28d698c3fcb3cce6]

        tdf#130857 qt weld: Also notify about programmatic text changes
        
        Connect to the QLineEdit::textChanged [1] signal instead
        of QLineEdit::textEdited [2].
        
        As the doc of the latter says:
        
        > Unlike textChanged(), this signal is not emitted when the text is
        > changed programmatically, for example, by calling setText().
        
        Programmatic changes are of interest, however, e.g.
        GotoPageDlg::GotoPageDlg connects to the changed signal
        of the weld::SpinButton and expects to be notified
        when the text is changed by using the spin button
        buttons to change the value (and thus the text).
        
        [1] https://doc.qt.io/qt-6/qlineedit.html#textChanged
        [2] https://doc.qt.io/qt-6/qlineedit.html#textEdited
        
        Change-Id: Ie19bc852f4ceed0fa79565302975376db7126ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177447
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [df32eb6023d874574accde09adb9b92c15023fca]

        tdf#130857 qt weld: Call spinbutton value changed handler
        
        Change-Id: I435ed112469b58cec191badaf98e7f019381707b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177446
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [669c839a61e2742a9128aabba30e2b55be517d21]

        Simplify ScSubTotalParam
        
        Change-Id: I4c1840e377711ad065c3042bddacb2028481b88d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177433
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-28  Justin Luth  <justin.luth@collabora.com>  [2310b7c8541a66fc4cbd243ca550cdc42e271cb3]

        tdf#126533 vml gradient export: fix radial color swapping
        
        This fixes my 24.8 regression 6dd6891a3deed8718bf2b0fcf564f229f676f8ba
        related tdf#126533 tdf#159824 VML: don't export: negative angles
        
        So far I really haven't touched radial gradient code,
        but the above patch swapped the colors around for linear/axials,
        and (while the import for radials is probably wrong)
        that also changed round-tripped radials - swapping colors each time.
        
        Note that on the unit test, the initial focus is 100,
        so on the first import the colors are NOT swapped.
        But since we don't write a focus, re-imports will start swapping.
        
        See FillModel::pushToPropMap in oox/source/vml/vmlformatting.cxx
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_pageGradient
        
        Change-Id: I469fe7fba520e338df90e2eb0d8bdf96709d2ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177452
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [ec958b578bd01071b4a6061f57007df6fec93aee]

        tdf#164069 Make line in Find sidebar respect dark mode
        
        Change-Id: Ie75cb0a581447e7f247be6b6d2bf1860ec74c8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177415
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [fe7fe79feef8561d1cbd731d1bd53357eef902be]

        tdf#130857 qt weld: Implement spinbutton cursor/sel methods
        
        Implement QtInstanceSpinButton methods related to
        the text cursor and selection.
        
        The QDoubleSpinBox base class QAbstractSpinBox
        has a method QAbstractSpinBox::lineEdit [1]
        that provides access to the spin box's QLineEdit.
        However, that method is protected, and can therefore
        not be accessed from QtInstanceBuilder.
        Therefore, add corresponding methods to
        QtDoubleSpinBox and forward calls to the line edit
        from there.
        
        The methods implemented in this commit are
        very similar to the corresponding ones in
        QtInstanceEntry (which however has has direct access to
        the QLineEdit).
        
        [1] https://doc.qt.io/qt-6/qabstractspinbox.html#lineEdit
        
        Change-Id: Ib5d2b55478f88618ed58adc2353824c59015a039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177436
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [6ab6dcf92000bb3a942b0c8658239877e46093b4]

        tdf#130857 qt weld: Introduce custom QDoubleSpinBox subclass
        
        Introduce a new QtDoubleSpinBox subclass for the
        stock QDoubleSpinBox and use it for the native Qt
        weld::SpinButton implementation.
        
        Initially, the new subclass doesn't add any
        additional functionality, but that will be
        added in future commits to provide functionality
        needed to implement more of the QtInstanceSpinButton
        methods.
        
        Change-Id: Icebbf6485172b065d6a6d2c1c8ef87be9d3d244e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177435
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [24b5ec318403479d3ee3a2553a489fffa2cb14e8]

        tdf#130857 gotopagedialog.ui: Resave with glade 3.40
        
        This is the .ui file for the "Edit" -> "Go to page"
        dialog in Writer.
        
        This luckily also moves the "page_value" GtkAdjustment
        to the top of the file, which (at least for now, in
        order to support that dialog) avoids the need to
        extend QtBuilder to implement handling of GtkAdjustments
        that are referenced in the .ui file before they are
        defined.
        
        (If it's still needed in the future, extracting
        some of the current logic from VclBuilder into
        the BuilderBase or WidgetBuilder base classes for
        reuse also by QtBuilder might be an idea.)
        
        Change-Id: Ic03acc1d514d412cd609543754829a370a5678e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88431fff42d168099962206e52475050d4f0e3c1]

        cid#1607688 Check of thread-shared field evades lock acquisition
        
        Change-Id: I89042693b8844b4769be79fa854722fe3d7babf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177426
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [c251a8cfe6b72c910d79d48e644046de4e7a2536]

        PVS: V547 Expression '!bNeedAction' is always false.
        
        Since
        commit 9859528a0e0ab33b22d4969e1856ec1dc98de6b6
        Author: Ingrid Halama <iha@openoffice.org>
        Date:   Thu Mar 22 15:48:03 2001 +0000
        
            #84921# smart propagation of fetchsize and direction from stub to possibly underlyingCachedContentResultSet
        
        Change-Id: I6d1c2ef916d3e5b43f4cc896ef202acd69e2a2fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177431
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3b39c887e95998e7384b310d259f3d1dbe4fef1e]

        PVS: V547 Expression '!bNoPrtLine' is always false
        
        Since at least
        commit a2a922c273e90af27810cee4ec8cb724125b6aa5
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Dec 5 10:59:41 2018 +0200
        
            loplugin:singlevalfields in sw
        
        Change-Id: I54ce5a9ca4571de26c4c25448e58abc361a6a121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177430
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Sakura286  <sakura286@outlook.com>  [d17a495c5c7d596b7b7642906b1aac15fcca654c]

        tdf#152943: Add configure option to disable NaN payload related tests
        
          Because some architecture(such as riscv64) does not support NaN
          payload (NaN propagation), skipping the related tests might be a
          good choice for builders who has already known the risk of lacking
          NaN payload support.
        
          Currently the tests that could be skipped via --disable-nan-tests are:
        
          - rtl_math: test_payloadNaN
          - sc_ucalc_formula2: testExternalRefFunctions
          - sc_ucalc_formula2: testFuncGCD
          - sc_ucalc_formula2: testFuncLCM
          - sc_ucalc_nanpayload: testNanPayload
        
        Change-Id: Ia8834595a8b469d8c542809b3e580a3f6316ef20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174801
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: René Engelhard <rene@debian.org>

2024-11-27  Miklos Vajna  <vmiklos@collabora.com>  [8d7272141f56935a7fbd629706bb4fefb7d3ba84]

        sw: add stub Title impl for SwPostItField
        
        It is advertised as a property, but it's not implemented: just avoid the
        assert fail on inspecting the UNO wrapper.
        
        Similar to commit eb3fccbd86ca343f21aa42505fa3400bfec838c8 (sw: add stub
        Title impl for SwAuthorField, 2022-05-25).
        
        Change-Id: Idd49f8c23e2d66616346b30e1f0e04eda9da7725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177429
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [71be29d7f54d228502eafd4ab9d4ac00917e9e9d]

        PVS: V560 A part of conditional expression is always false:
        
        !bDoDirectCairoStroke.
        
        Since
        commit 9c9f76dd5b6fb115e521ac6568673c7a10879192
        Author: Armin Le Grand <Armin.Le.Grand@me.com>
        Date:   Sat Feb 8 12:14:09 2020 +0100
        
            tdf#130478 add direct dash paint in cairo
        
        Change-Id: I31cc48d7757048a4ea985a2de2c7c8380114acb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177423
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d29348f2da2e405ac651d009354e8f967a216170]

        PVS: V547 Expression '!bFoundCert' is always true
        
        Since
        commit 4b399dbfc4c3081174be1703a0c98fec1afd761f
        Author: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Date:   Tue Sep 10 11:19:08 2024 +0200
        
            tdf#162405: check if there's a matching singing cert only when saving
        
        Change-Id: I4f70843660f4feca12135ddeaa0452d5c57b20c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177427
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [aea7c6a01301a368e47a54cc85408bd9f34ace5a]

        sd: Drop unnecessary non-zero check
        
        The second part of the condition already
        makes sure that the mark count is non-zero.
        
        Change-Id: I174bfc2ff3112616a63dda64f4435cd3d235343c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177424
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4f7cdf40ded90d392331d45bab5adfc0986fe8e8]

        drop a TODO
        
        I don't think anyone is getting around to changing this after 13
        years, and an int worth of config layers looks safe enough to me.
        
        Change-Id: Iecf00a4d342e60d8f56a27978c40fa8d861ecd7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177428
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e08e1c77c685c30d67cae0fd294eec96a253272]

        cid#1635586 Explicit null dereferenced
        
        presumably since:
        
        commit c969795babd116635f87184facdc37f4f952d838
        CommitDate: Mon Nov 25 08:25:53 2024 +0100
        
            pdf: Introduce a IPDFEncryptor and use it in PDFWriterImpl
        
        Change-Id: I07958613a546443f10883f36daf6f306f19358ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-27  Regina Henschel  <rb.henschel@t-online.de>  [7cec59402d09077749cc6bbe96cbf19652d2d3d9]

        tdf#131862 No table:cell-range-address in ODF 1.4
        
        ODF 1.4 has removed the attribute table:cell-range-address from the
        chart:plot-area element. So we may write it only in versions < 1.4.
        The attribute was used to distinguish whether a chart has internal data.
        The same information is given by the href attribute of the chart:chart
        element.
        The actual used cell-range-address values are already given in the
        chart:axis and chart:series child elements and evaluated from there.
        A global setting is not needed.
        
        The attributes chart:data-source-has-labels, chart:column-mapping and
        chart:row-mapping are related to the table:cell-range-address attribute.
        These three attributes are deprecated already in ODF 1.2. Thus we will
        not write them in ODF 1.4. Their information is given in the chart:axis
        and chart:series child elements. The order of series is given by the
        order of the chart:series child elements.
        
        Change-Id: I08886723b1c8eb27489a7f44b5f8321572defdff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177323
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [36b69c4525070f1258eac5c566c6dc4940deee24]

        tdf#94147 svx a11y: Honor animation setting in OverlayRectangle
        
        Base the decision to disable animation of the
        overlay rectangle on whether animations are disabled
        (either explicitly in LibreOffice itself or when
        LibreOffice uses the default value of "System" for
        animations and animations are disabled in the OS/desktop
        environment) instead of on the fact whether
        or not high contrast mode is enabled.
        
        This is the same criterion as used for Calc's
        "marching ants" animation, see
        
            commit ef7429f86788f0616db5b274ec77eb67cd41cb3d
            Date:   Mon Jul 29 11:36:29 2024 +0200
        
                tdf#161765, tdf#115688 Let user choose which animation settings to use
        
        Change-Id: If14b05006b1b04be9c2da9089dfbfbca70e88f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177417
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [03b1e988b15866af9d43ac2f1249e5c73d1d22bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b423c924ba73aab8b885304822fd92b00ee562d
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: I79b7a4953c49590afd96cc13efad8598285b03a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177296
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec68e9884a362693d5f5b1bbbe167bc72b585999]

        PVS: V560 A part of conditional expression is always true: bEqual
        
        Since
        commit d0484bcdcbffd42d242647a2fdc1a203d176b775
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Mon Sep 18 23:16:46 2000 +0000
        
            initial import
        
        Change-Id: Ib1cf69ecf70bf9d866308892562a2d9080e1350f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177413
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [b54e905ce6d295104af9a6d2a01b38c02abee6e3]

        PVS: V560 A part of conditional expression is always true
        
        Since
        commit 9b538afc2995f7d703a77bb4e6d0e1bc97e3ca20
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Tue May 22 17:46:33 2007 +0000
        
            INTEGRATION: CWS chart2mst3 (1.10.4); FILE MERGED
        
        Change-Id: I1ed040165018d38770f7438a7f64436c7aa4873f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177412
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9da32329f05a862635861adb19f9b0f331912c5b]

        PVS: V560 A part of conditional expression is always true: bRotate90
        
        Since
        commit fd069bee7e57ad529c3c0974559fd2d84ec3151a
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Mon Sep 18 16:07:07 2000 +0000
        
            initial import
        
        Change-Id: Ie2aeabafb1ff2a73b1c8cb90ee1a4d03a7482ab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177410
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d9920fe89aad76898d8a9c6a70c77a052861a328]

        PVS: V560 A part of conditional expression is always true: bOk
        
        Since
        commit 4e2453022f82074542811faf0cd051cf33151cf8
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Mon Jan 31 07:53:46 2005 +0000
        
            INTEGRATION: CWS fwkbugfix05 (1.145.34); FILE MERGED
        
        Change-Id: I707fd1b1f7d315542b6afecbe19739a34033d9a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177409
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [45a7c21ed8d7588a676878b52d12113a3fe2e077]

        PVS: V560 A part of conditional expression is always true: bSuccess
        
        Since
        commit 217ef2ed9b8a757b7b02feac799621d20d0f312e
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
        Date:   Mon Jan 23 12:32:25 2023 +0900
        
            pdfimport: refactor pdf and hybrid format detection code
        
        Change-Id: Ib8bd09417eb07bd395b38a04245de30e8abda5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [785a56b6be7f3128c2e7a131381e02525a50eb6b]

        D2DWriteTextOutRenderer: use grayscale AA for file output
        
        It makes no sense to use ClearType for file output - because it, by
        definition, depends on the device and scale; and the file output is
        for display on unknown device and scale.
        
        Change-Id: Icf032b1fecc1a4a7f0a4be53797728c9f9505fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177402
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b08b34d3dbf3af4a2dd36919c96201523f17990]

        PVS: V560 A part of conditional expression is always true: !bReturn.
        
        Since
        commit eff3f82033b5862af6300876aa69d9de0486d61b
        Author: Miklos Vajna <vmiklos@collabora.co.uk>
        Date:   Thu Mar 10 17:41:04 2016 +0100
        
            sd: handle classification during copy&paste
        
        Change-Id: Ia65e34cbd9e7dc688eeae09a77105bf22fc17857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177406
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [75c9b78b07d9b2e887f9ff7c57461ecfd873b3d1]

        PVS: V560 A part of conditional expression is always true: !bSelection.
        
        Since
        commit c6fc14a42e068877af844b2695dea8939517c1ac
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Tue Jun 30 12:21:20 2020 +0200
        
            loplugin:singlevalfields
        
        Change-Id: If5242fd47d550c905b480d848d926da37c57766e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177407
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [85951fbfc630993aad391ce1fbb33dfecd618ae5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c73747f8fb95caee2f4bd5095b886e305bd7d684
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: I46c451df1f3b957a3129f167e0a8d45726ef78c4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177295
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [102ff62a40eb8ae89fede7c41b50562dd1c51c52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ecc00617e7b93d3869ea7d77c777ebe47db9896
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: I350334e689e6116465bbca4821e21a3046c0ce9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177293
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3be6d3182d023723f4c382c5c30d53797a9036a6]

        PVS: V560 A part of conditional expression is always true: !bReadOnly
        
        Since
        commit a39a3f1ad1e5e39b09ce474c0f4c0f9f4e174bbe
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue Feb 9 12:07:27 2021 +0000
        
            weld impress annotation window
        
        Change-Id: I63855a609d5de49a0c810994fccf240695605456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177405
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1967187957e1e4b56962564a81917d0ba92cac0]

        PVS: V560 A part of conditional expression is always true: !bSingle
        
        Since
        commit 5a725d1fde7381ef9c02afcb639235a11e52182c
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Tue Mar 28 15:27:36 2017 +0200
        
            loplugin:singlevalfields
        
        Change-Id: I5fabc0537f385531fedb34a0becf69e480d39394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177404
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [69a020c19a5f1a8abe8a024abb73c862be2a762d]

        PVS: V547 Expression 'bDouble' is always true
        
        Added in
        commit 96928bb74a993f3020ed71776d11b9849501f90c
        Author: Marco Cecchetti <marco.cecchetti@collabora.com>
        Date:   Thu May 10 23:13:12 2018 +0200
        
            lok: sc: ctrl-clicking links doesn't work
        
        and became always true after
        commit 142d3e15916afd1c38bcccf0d23cac292ea357fc
        Author: Jan Holesovsky <kendy@collabora.com>
        Date:   Mon Oct 24 16:27:17 2022 +0200
        
            sc lok: Double-click should behave more like on desktop
        
        Change-Id: I5e36fe835088865a9caede88b8a690f070a3da9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177403
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Hubert Figuière  <hub@collabora.com>  [d24439927081692ab8fe355a04264e8501c37a90]

        LOKit/impress: Send click actions for slideshow
        
        This will allow to implement the Interaction between slides
        in the slideshow.
        
        Change-Id: I0c4ca1858ab9935fd4926b776e96ba5b7a386e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177398
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [95563e734722449c150c8e9ba88f12f100d50294]

        PVS: V595 The 'mpDoc' pointer was utilized before it was...
        
        ... verified against nullptr
        And some other related cases
        
        Change-Id: If07cad3286afbc6e3058ed951128f501b11d79b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177395
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [127659cda6f4f84e20dabce8a23546c61b448990]

        make calc Grid config listen for changes
        
        Change-Id: I1015adf6f8a270569e48b8e66b141ef37f217a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177400
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [86341e2ae913052f318f87c2c27912342249c280]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce42a420ae28518aae72e72e06a8d3d8a3f33cc8
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: I2f17cb9ffc9704c229f4c2f6dd9c6fb8e0531f42
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177297
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [e73b5b0afad2daaafe76b9a201ddcad74560c4d2]

        openldap: upgrade to 2.6.9
        
        Downloaded from https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.6.9.tgz
        
        Change-Id: Ie26290f4443d92cb9f0801548782c0f10a518984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177401
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [55baaa526c301d86d09400a9a50d482fb14dd2c2]

        for --without-templates still generate the template/common/presnt dir
        
        but leave it empty
        
        Change-Id: Ie7f95f6d01c669598305e24472c357c1b92ad1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177353
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e393a739fa890aeb77f189b62de4356043211490)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177392
        Tested-by: Jenkins

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7dfa6d794d52e275b43da82cce2ed86a5621a4c5]

        disable autotext atevent.xml in kit mode
        
        Change-Id: Ie6e3e38768124e256a31c343a10cbc30262708e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176492
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit afc7f61f6a87f2daf3b9e3cba2ecd4a70578793d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177394
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [91abc314b7de5d8abe2292cd732646c03ac22915]

        sc: use SAL_RET_MAYBENULL in GetDocument()
        
        mpDoc can be nullptr
        while at it, prefix it as a member
        
        Change-Id: I48233bc4bfcd87a382e29ba9b9ee053612ba6bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177258
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Laurent Balland  <laurent.balland@mailo.fr>  [e1b8bf208afe3c41ac768f3205b3c94017b2bd98]

        tdf#39468 translate German comments in ipwin.cxx
        
        Change-Id: I6b3617f8b31c77b8538e468d80a8ef54702945f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177216
        Reviewed-by: Simon Chenery <simon_chenery@yahoo.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-27  Weblate  <noreply@documentfoundation.org>  [b7e71559ceeb5fd2feae394cab8330d067706850]

        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: I75ff1908970b8d28c3380e5791aea0146354868c
        Co-authored-by: eduver <hmcb2080@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177272
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [fc95e370fdaf15232548409132c806379376714b]

        Drop separate instantiation of objects included in AllSettings
        
        Change-Id: If56c0cbf5679bee57f6fe1b364c402d949089b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177386
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa50b71fb8ac99b0d9afbcd29a509d0b1b063953]

        tsan: use of freed mutex
        
        Because the mutex has already been freed because raptor calls
        xmlCleanupParser
        
        I have logged a feature request against raptor for a flag to turn off
        this behaviour, but until that lands, this will have to do.
        
        -----
        
        make CppunitTest_filter_pdf results in
        
        WARNING: ThreadSanitizer: use of an invalid mutex (e.g. uninitialized or
        destroyed) (pid=330602)
        0 pthread_mutex_lock
        /home/noel/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1371
        (discriminator 8) (cppunittester+0x7e1be)
        1 xmlDictFree ??:? (libxml2.so.2+0x3404b) (BuildId:
        14c9410dbe8278dfa121dabc48c9ae25eac169d1)
        2 lt_xml_unref
        /home/noel/libo-tsan/workdir/UnpackedTarball/liblangtag/liblangtag/lt-xml.c:351
        (liblangtag-lo.so.1+0x1fc6a)
        3 lt_db_finalize
        /home/noel/libo-tsan/workdir/UnpackedTarball/liblangtag/liblangtag/lt-database.c:144
        (liblangtag-lo.so.1+0xac22)
        4 (anonymous namespace)::LiblangtagDataRef::teardown()
        /home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:219
        (libi18nlangtag.so+0x20951)
        5 (anonymous namespace)::LiblangtagDataRef::~LiblangtagDataRef()
        /home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:204
        (libi18nlangtag.so+0x20951)
        6 cxa_at_exit_callback_installed_at(void*)
        /home/noel/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:445
        (cppunittester+0x6e3af)
        7 LanguageTagImpl::canonicalize()
        /home/noel/libo-tsan/i18nlangtag/source/languagetag/languagetag.cxx:190
        (libi18nlangtag.so+0xe370)
        8 main /home/noel/libo-tsan/sal/cppunittester/cppunittester.cxx:482
        (cppunittester+0x10cf6c)
        
        Change-Id: I5d9ff1c5667f8e19e5858cd5a408e8f95d2a98e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177320
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c41d2eb41dc9412ca15875c6f36410cfdd06941a]

        Allow toggling grid options on/off via config to update writer
        
        SwGridConfig ConfigItem didn't listen to the config changes.
        
        Note that after this, while toggling e.g. VisibleGrid on/off in expert
        settings doesn't initially appear to do a whole pile, it does affect
        newly created documents, while before this change it does not.
        
        Existing documents don't update to use that config. Toggling this
        on/off via the explicit Show Grid ends up in
        
        SwModule::ApplyUsrPref(const SwViewOption &rUsrPref, SwView* pActView)
        
        with something of a bodge to determine the current SwView in order
        to affect the document the setting dialog is launched from, which
        is why it changes the current document, and new documents, but not
        any other open documents.
        
        Change-Id: Ic57e89e3aa9765ad3c4374ddf02ed718382cf518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0b3f75e73c1f2f0c8877e57d47f2de499839ee6]

        SwContentViewConfig already ctor calls Load
        
        so this one doesn't need another explicit Load called
        
        Change-Id: If1ff686655a90ed81be97bf0821518b2e82bdd57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177369
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [3244668b05ecb5eeda8e4758359eae597dbd0821]

        Reuse SAL_ACCESSIBILITY_ENABLED to allow disabling a11y on Windows
        
        After commit c5b6e3ac564c35aa10744d498b372fa5d4f68bf3 (win a11y: Stop
        using setting to indicate AT support, 2024-10-30), the a11y status
        doesn't depend on a setting, and will be enabled whenever anything on
        Windows sends a WM_GETOBJECT messaage to a window. To allow debugging
        without a11y interference, use the existing SAL_ACCESSIBILITY_ENABLED
        environment variable, and extend it to use its "0" value to disable.
        
        Change-Id: I43bdec59a195ace3f704206d9ebe07352dd3e819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177385
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [246baac818f682b7021e13017f943ae476ac74d4]

        starmath: fix deref nullptr
        
        Change-Id: I84ad6d24d850857949bbae403cb6f640cd31b16e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177374
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [5259a08e951858cc32bb529e63e3a2fe5837540a]

        vcl: Drop unnecessary casts in VclMultiLineEdit
        
        Neither the const_cast, nor the explicit cast to vcl::Window
        is needed here in order to call vcl::Window::GetBorder.
        
        Change-Id: Id234d21e6d9792e83487fc5503cd737fe3832b91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177377
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [3b6688fe11c162e3e14371e6f7bfa4b66afec8a5]

        weld: Rename weld::Dialog::{widget -> button}_for_response
        
        Rename weld::Dialog::widget_for_response to
        weld::Dialog_button_for_response as it specifically
        returns a weld::Button, not a generic weld::Widget (other than GTK's
        `gtk_dialog_get_widget_for_response` [1] which
        returns a GtkWidget).
        
        [1] https://docs.gtk.org/gtk3/method.Dialog.get_widget_for_response.html
        
        Change-Id: I3b1dc34c0af752853551d2ebb706109f2214720d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177376
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [cf108a359b77ce58c2f8bb7f4116f87a8c536ca5]

        weld: Return unique_ptr in weld::Dialog::widget_for_response
        
        ... to make more obvious from the API that the
        caller owns the returned weld::Button* (but not
        the underlying toolkit widget).
        
        Change-Id: I64f57f80e4eea4c2c984fa7b615b5a2350ed892a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177375
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [68699d3699fed08956e37e53664fa92e70487b8d]

        Release CXNotifyingDataObject in separate thread
        
        The reported deadlocking situation at paste was:
        
        1. Thread CMtaOleClipboard::run() is handling CXNotifyingDataObject::Release,
        which calls CWinClipboard::onReleaseDataObject before deleting self, and that
        eventually tries to lock solar mutex:
        
          sal3!osl_acquireMutex+0x49 [sal\osl\w32\mutex.cxx @ 65]
          vclplug_winlo!osl::Mutex::acquire+0xa [include\osl\mutex.hxx @ 63]
          vclplug_winlo!SalYieldMutex::doAcquire+0x91 [vcl\win\app\salinst.cxx @ 148]
          vcllo!osl::Guard<comphelper::SolarMutex>::{ctor}+0xe [include\osl\mutex.hxx @ 144]
          vcllo!SolarMutexGuard::{ctor}+0x1b [include\vcl\svapp.hxx @ 1340]
          vcllo!TransferableHelper::lostOwnership+0x36 [vcl\source\treelist\transfer.cxx @ 487]
          vclplug_winlo!CXNotifyingDataObject::lostOwnership+0x61 [vcl\win\dtrans\XNotifyingDataObject.cxx @ 140]
          vclplug_winlo!CWinClipboard::onReleaseDataObject+0x57 [vcl\win\dtrans\WinClipboard.cxx @ 364]
          vclplug_winlo!CXNotifyingDataObject::Release+0x36 [vcl\win\dtrans\XNotifyingDataObject.cxx @ 77]
          combase!Ordinal230+0x1c9b
          ...
          combase!Ordinal87+0x3d19
          USER32!DispatchMessageW+0x741
          USER32!DispatchMessageW+0x201
          vclplug_winlo!CMtaOleClipboard::run+0x18f [vcl\win\dtrans\MtaOleClipb.cxx @ 657]
        
        2. Thread CMtaOleClipboard::clipboardChangedNotifierThreadProc() is handling
        the respective event, calling CWinClipboard::handleClipboardContentChanged,
        which notifies listeners, including SwClipboardChangeListener, which, in its
        changedContents, has locked solar mutex, and requests the clipboard content,
        which eventually calls CMtaOleClipboard::getClipboard posting a message to
        the CMtaOleClipboard::run() thread, and waiting the result:
        
          vclplug_winlo!`anonymous-namespace'::Win32Condition::wait+0x3b [vcl\win\dtrans\MtaOleClipb.cxx @ 92]
          vclplug_winlo!CMtaOleClipboard::getClipboard+0x220 [vcl\win\dtrans\MtaOleClipb.cxx @ 355]
          vclplug_winlo!CWinClipboard::getIDataObject+0x84 [vcl\win\dtrans\WinClipboard.cxx @ 161]
          vclplug_winlo!CDOTransferable::tryToGetIDataObjectIfAbsent+0x56 [vcl\win\dtrans\DOTransferable.cxx @ 413]
          vclplug_winlo!CDOTransferable::getClipboardData+0x79 [vcl\win\dtrans\DOTransferable.cxx @ 425]
          vclplug_winlo!CDOTransferable::getTransferData+0x163 [vcl\win\dtrans\DOTransferable.cxx @ 252]
          sotlo!GetTransferableAction_Impl+0x13d [sot\source\base\formats.cxx @ 1352]
          sotlo!SotExchange::GetExchangeAction+0xde [sot\source\base\formats.cxx @ 1429]
          swlo!SwTransferable::IsPaste+0xba [sw\source\uibase\dochdl\swdtflvr.cxx @ 1402]
          swlo!SwClipboardChangeListener::changedContents+0xac [sw\source\uibase\uiview\uivwimp.cxx @ 315]
          vclplug_winlo!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent>::operator()+0xc [include\comphelper\interfacecontainer4.hxx @ 274]
          vclplug_winlo!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::forEach<comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent> >+0xb6 [include\comphelper\interfacecontainer4.hxx @ 304]
          vclplug_winlo!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::notifyEach+0x28 [include\comphelper\interfacecontainer4.hxx @ 325]
          vclplug_winlo!CWinClipboard::handleClipboardContentChanged+0x156 [vcl\win\dtrans\WinClipboard.cxx @ 303]
          vclplug_winlo!CWinClipboard::onClipboardContentChanged+0x5c [vcl\win\dtrans\WinClipboard.cxx @ 387]
          vclplug_winlo!CMtaOleClipboard::clipboardChangedNotifierThreadProc+0x172 [vcl\win\dtrans\MtaOleClipb.cxx @ 699]
        
        This change tries to untie this, by creating a dedicated thread to call
        CWinClipboard::onReleaseDataObject and delete CXNotifyingDataObject outside
        of its Release (and of the CMtaOleClipboard::run() thread), so that locking
        happening in that process doesn't deadlock functional threads.
        
        Change-Id: I93da6fe79225319a84b332c81716793f4d9fb05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177363
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [03a701516ea94b786ba6e1b35bf6dad22cceced5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ade9473eb6bb45b83d49c2e77f9448ac638e4425
          - Untranslatable string made translatable
            
            Change-Id: I5cd51e885dce97d43559ddc95754f750ef842e9d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177368
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d7bbc50f3144a7d08c8f37a93745ff9a9e7c7ff9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6977846f119905354c5b449612e1e0b64fdf0722
          - tdf#131332: Replace custom date formats with ISO 8601
            
            Change-Id: I258013e509a72caf640032fe6dc258a734127fd1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177292
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa6b56cdda0883ff86151f84c0aafe1e2bec7b53]

        NotoSans: upgrade to v2.015
        
        Downloaded from https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSans-v2.015/NotoSans-v2.015.zip
        
        Change-Id: I924800998d31235eb7d2fcea83adfc64ff748ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177361
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-26  Justin Luth  <justin.luth@collabora.com>  [1f60ba36f4e2fa2785d31200b2a95226920ec298]

        tdf#147819 doc export: only ShapeFlag::Background if XATTR_FILL
        
        The mere presence of an object somewhere in the document
        was causing the document background to force a white color.
        
        This code was developed in the heady days
        of figuring out what bits meant what,
        so the documentation and code-reading is NOT clear.
        
        make CppunitTest_sw_ww8export \
            CPPUNIT_TEST_NAME=testTdf41542_imagePadding
        (My ODT file had obviously spent some of its lifetime as a DOC
        because it had a white page background.
        I unzipped the file, and hand-adjusted styles.xml to set
        fo:background-color="transparent" and draw:fill="none")
        
        Change-Id: I41484ab7f71f4a3156e3193e49127b14e58949cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177347
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-26  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [fafc2b9cd55c78d82cc0df9223f8563fb78d65b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 815ce1be85e4bd8e77ccbed66ec5d482863f4caa
          - tdf#85976 update help page for 'Handle Duplicate Records' dialog
            
            + use row/column instead of record to make it easier to understand
            
            + use field instead of record to describe the treeview entries in the
              'Compare by' section as that's a more technically correct term.
              https://bugs.documentfoundation.org/show_bug.cgi?id=85976#c84
            
            Change-Id: I05f2280a94507528a595436d2a8a52c6ed574d9e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177261
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [77bcd4dbbb0e18bc15ebb42afd45bc382aa4e925]

        NotoSerif: upgrade to v2.015
        
        Downloaded from https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSerif-v2.015/NotoSerif-v2.015.zip
        
        Change-Id: I2cf07988ddb411db69457998e8171b19c46ea356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [082ba4a420ff30e8d9c40b2d2be6621fc0051936]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7c79a8fc5bd529a081c2bc0360183d6cd819356
          - Typo in Help page
            
            Change-Id: I5c149638fb6501e64f8255c843872e3570169036
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177281
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ab60c81f77f45315ba3cfc7cae6c1d9144588663]

        Fix typo
        
        Change-Id: Ifdd5f7cce7006b824397525f3a698df3f30ee17e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177327
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [500e79807d724efe8c68db0ee23b71415e219ed8]

        Fix typo
        
        Change-Id: Ia1395f64bdc649f8e0f450b9173d302efa058c9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177326
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3c94289c22a64907150ca0d01451cf6227344656]

        Remove exec bits on odt file
        
        Change-Id: Ic528aa0d92d3d5e9ac971be8b5343a0b2b4da5c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177328
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8068f5a5d0a9b09606165eec17e8ef5d26482fcf]

        Fix typo
        
        Change-Id: I2a3df5cad1bd4daa18292cc106d5e8fedefca364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177325
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [82417b47bdeffd8f1051819bda94cd33a9fa48fa]

        tdf#163992 Improve tooltip for opened documents
        
        Change-Id: I9d3cd55b05a684a8b21d5ee5a478202a3d0788c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177321
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-26  Heiko Tietze  <tietze.heiko@gmail.com>  [b32d040d647812fed03f96be2f07a96ffddad4e9]

        Resolves tdf#126857 - Center object on page/slide
        
        * uno:AlignMiddle labeled "Middle"
        * uno:AlignOnPage added
        
        Change-Id: Iafc162bdd80d7c20fabd55234e93212c1fa3435a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177348
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fd2c9abe5229f98e062b7b32994e9e015975ca90]

        show extension link on startcenter for macosxsandbox case
        
        the ShowDonation has already a default value of true via the schema,
        so it is enough to override it to false for the macosxsandbox case
        similar to how it is done with the Infobar / using the install:module
        method
        
        Change-Id: I8f1ea6d3530e66806f66f9f2d2fb16ef0276e460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177333
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [c630dbc1ab0756ce25a65a6326b908313a35d17f]

        svtools a11y: Merge BrowseBoxImpl into BrowseBox
        
        Change-Id: I3667e47867eb85f18cf8ad620cff903cc13f38c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177352
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [649d2de3dc195c457875ff2b031920e876cd0575]

        svtools: Move THeaderCellMapFunctorDispose struct out of impl class
        
        Move to anonymous namespace in the only .cxx where it's used.
        
        Change-Id: Ifa1219c49e5673d3440a889b2fd814059a29b5bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177351
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [b5ac3d2092fce7d78f39ee501b509a353b8cd173]

        svtools: Merge BrowseBox::ConstructImpl into ctor
        
        Change-Id: I9bd8a018dbe2c3416af9b50a6ca782ac5fb3a4ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177350
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-26  Noel Grandin  <noelgrandin@collabora.co.uk>  [668dbfd99ada1888d5919cffedcfd7486c101717]

        tdf#162815 Greyscale images not corrrectly exported to PDF
        
        regression from commit 21734247d58a6e915b058d8fa55ece949d049613
        "drop internal support for 1-bit images"
        
        This only works on Linux because the HasGreyPaletteAny() check
        is returning false on Linux, because on linux the swap in/out is more aggressive, and after it is has gone through the swap in/out process,
        the image palette is no longer one that matches anything that HasGreyPaletteAny() checks for (it contains 256 entries, but only 2 of them are used)
        
        I'm not exactly sure why the greyscale bitmap generation code
        is generating bad PDF data, but the RGB code works great, so
        lets just use that rather.
        
        Change-Id: Ibb9e837540d5ed567c706e21e7ff93fe92118580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-26  Aron Budea  <aron.budea@collabora.com>  [2af9fcddba57632e4a13797dcd5894f4cfeb51a7]

        Operator should be logical AND instead of OR
        
        Change-Id: Ife1870da9979e974fa9dc11ca7dff87c8cfe66bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177310
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-11-26  Miklos Vajna  <vmiklos@collabora.com>  [7cfcfa30aa606536d7693ea09f39e57c60af00d6]

        sfx2 lok: fix crash in SfxLokHelper::notifyUpdate()
        
        Crashreport signature:
        
        > kit-09946-09946 2024-11-25 16:46:13.180120 +0000 [ kitbroker_498 ] SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
        > program/libmergedlo.so
        >       SfxLokHelper::notifyUpdate(SfxViewShell const*, int)
        >               sfx2/source/view/lokhelper.cxx:1072
        > program/libswlo.so
        >       SwViewShell::GetSfxViewShell() const
        >               sw/inc/viewsh.hxx:472
        > program/libswlo.so
        >       SwCursorShell::UpdateCursor(unsigned short, bool)
        >               sw/source/core/crsr/crsrsh.cxx:2382
        ...
        > program/libmergedlo.so
        >       framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        >               framework/source/services/desktop.cxx:592
        
        I.e. it can happen that during load we don't yet have a view, handle
        this in SfxLokHelper::notifyUpdate() till it takes a pointer and not a
        reference.
        
        Change-Id: Ifa5d9300029076e91ba8722152a7d91a1f2ecbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177343
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e334b25b91b4585a8660e49355c3442ebfd334e]

        libcdr: upgrade to 0.1.8
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: I46b921f3c2ef41ab52e272df5afd82a1d9331f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177332
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [174d1d3f3b57547c86ff858d1c2ed931eca3bb37]

        libqxp: fix copy&paste path
        
        Since
        commit 05aedcba6672979d317b540bbfa74f5c9b409402
        Author: Stephan Bergmann <sbergman@redhat.com>
        Date:   Thu Jan 21 23:19:20 2021 +0100
        
            Fix use of -fvisibility=hidden with Clang in external/libcdr, external/libqxp
        
        Change-Id: Idb97eaea30f5a2b15379b18981455532de0308b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177330
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a1025adeb3608b06df751225a97d84e5be87d48]

        libetonyek: upgrade to 0.1.12
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: I74ac661c5f8db9abf7644212d98b29c3ec5b422f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176036
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-26  Heiko Tietze  <tietze.heiko@gmail.com>  [f395e6599facba41392eac3d646a0d505868e6fa]

        Resolves tdf#163685 - Save user-defined formula
        
        Change-Id: I88a1c40d3e97d77c289c8b670b52dca50dea126f
        Co-authored-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176788
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [f81af8f7a5e8f86d4214bc328c44632841fbec2b]

        a11y: Handle combobox subedit a11y name in VCLXAccessibleEdit
        
        Let VCLXAccessibleEdit::getAccessibleName take care
        of returning the same accessible name as the combobox
        parent for the combobox subedit instead of trying
        to set the same name when that combobox child is
        requested the first time.
        
        This makes sure the name remains in sync, and prevents
        trying to get the combobox a11y name while a dialog
        containing it might still be in the process of getting
        constructed by VclBuilder, in which case e.g. the
        AccessibleRelation::LABELLED_BY relation that
        gets used in Window::getDefaultAccessibleName
        may not have been set. That relation e.g. gets
        set if a label has the combobox set as its
        "mnemonic-widget" in a .ui file.
        
        The previous logic was triggering an assert
        when opening the "Fonts" page in the "Tools" -> "Options"
        dialog or using the search feature in that dialog on Windows
        with an AT (like NVDA) active when trying to set the a11y
        name of the "font2" combobox's entry
        (UI file: cui/uiconfig/ui/optfontspage.ui):
        
            Assertion failed: GetChildCount() == 4 || pWindowImpl->mbInDispose, file .../vcl/source/window/layout.cxx, line 1945
        
        Backtrace:
        
            1   abort                                                                                                     ucrtbase                           0x7ffad46e286e
            2   get_wpgmptr                                                                                               ucrtbase                           0x7ffad46e426e
            3   get_wpgmptr                                                                                               ucrtbase                           0x7ffad46e4165
            4   wassert                                                                                                   ucrtbase                           0x7ffad46e44f1
            5   VclScrolledWindow::get_child                                                                              layout.cxx                    1945 0x7ffa88f67e35
            6   nextLogicalChildOfParent                                                                                  dialog.cxx                    139  0x7ffa88f147cf
            7   nextLogicalChildOfParent                                                                                  dialog.cxx                    157  0x7ffa88f14884
            8   nextLogicalChildOfParent                                                                                  dialog.cxx                    157  0x7ffa88f14884
            9   ImplGetSubChildWindow                                                                                     dlgctrl.cxx                   137  0x7ffa88f197e1
            10  ImplGetChildWindow                                                                                        dlgctrl.cxx                   151  0x7ffa88f18dae
            11  ImplGetNextWindow                                                                                         dlgctrl.cxx                   180  0x7ffa88f19600
            12  ImplFindDlgCtrlWindow                                                                                     dlgctrl.cxx                   362  0x7ffa88f18a2b
            13  vcl::ImplGetLabeledBy                                                                                     legacyaccessibility.cxx       122  0x7ffa88e65437
            14  vcl::Window::getLegacyNonLayoutAccessibleRelationLabeledBy                                                legacyaccessibility.cxx       178  0x7ffa88e657ac
            15  vcl::Window::GetAccessibleRelationLabeledBy                                                               accessibility.cxx             604  0x7ffa88e6193a
            16  vcl::Window::getDefaultAccessibleName                                                                     accessibility.cxx             470  0x7ffa88e63c73
            17  vcl::Window::GetAccessibleName                                                                            accessibility.cxx             441  0x7ffa88e614ba
            18  vcl::Window::SetAccessibleName                                                                            accessibility.cxx             427  0x7ffa88e623bc
            19  VCLXAccessibleBox::getAccessibleChild                                                                     vclxaccessiblebox.cxx         319  0x7ffa853e3e02
            20  AccObjectWinManager::InsertChildrenAccObj                                                                 AccObjectWinManager.cxx       536  0x7ffa855b2ed1
            21  AccEventListener::HandleChildChangedEvent                                                                 AccEventListener.cxx          109  0x7ffa855b9593
            22  AccEventListener::notifyEvent                                                                             AccEventListener.cxx          64   0x7ffa855ba6ef
            23  AccContainerEventListener::notifyEvent                                                                    AccContainerEventListener.cxx 95   0x7ffa855bdfbc
            24  comphelper::AccessibleEventNotifier::addEvent                                                             accessibleeventnotifier.cxx   256  0x7ffa916598c0
            25  comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent                                             accessiblecomponenthelper.cxx 127  0x7ffa9165071e
            26  VCLXAccessibleComponent::ProcessWindowChildEvent                                                          vclxaccessiblecomponent.cxx   165  0x7ffa8b7e6029
            27  VCLXAccessibleComponent::WindowChildEventListener                                                         vclxaccessiblecomponent.cxx   124  0x7ffa8b7e6d62
            28  VCLXAccessibleComponent::LinkStubWindowChildEventListener                                                 vclxaccessiblecomponent.cxx   114  0x7ffa8b7e5ee6
            29  Link<VclWindowEvent &,void>::Call                                                                         link.hxx                      111  0x7ffa88f3bf43
            30  vcl::Window::CallEventListeners                                                                           event.cxx                     300  0x7ffa88f3c57c
            31  vcl::Window::ImplSetReallyVisible                                                                         window.cxx                    1331 0x7ffa8904394d
            32  vcl::Window::ImplSetReallyVisible                                                                         window.cxx                    1344 0x7ffa89043a1d
            33  vcl::Window::Show                                                                                         window.cxx                    2336 0x7ffa89047671
            34  vcl::Window::Show                                                                                         window.cxx                    2349 0x7ffa8904776e
            35  vcl::Window::set_property                                                                                 window2.cxx                   1537 0x7ffa8902d4b3
            36  ComboBox::set_property                                                                                    combobox.cxx                  1553 0x7ffa89097521
            37  BuilderUtils::set_properties                                                                              builder.cxx                   2192 0x7ffa88ef13c5
            38  VclBuilder::insertObject                                                                                  builder.cxx                   2469 0x7ffa88ee18df
            39  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleObject                  widgetbuilder.hxx             230  0x7ffa88e23d54
            40  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleChild                   widgetbuilder.hxx             127  0x7ffa88e22c30
            41  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleObject                  widgetbuilder.hxx             234  0x7ffa88e23dff
            42  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleChild                   widgetbuilder.hxx             127  0x7ffa88e22c30
            43  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleObject                  widgetbuilder.hxx             234  0x7ffa88e23dff
            44  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleChild                   widgetbuilder.hxx             127  0x7ffa88e22c30
            45  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleObject                  widgetbuilder.hxx             234  0x7ffa88e23dff
            46  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleChild                   widgetbuilder.hxx             127  0x7ffa88e22c30
            47  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleObject                  widgetbuilder.hxx             234  0x7ffa88e23dff
            48  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::handleChild                   widgetbuilder.hxx             127  0x7ffa88e22c30
            49  WidgetBuilder<vcl::Window,VclPtr<vcl::Window>,PopupMenu,VclPtr<PopupMenu>>::processUIFile                 widgetbuilder.hxx             70   0x7ffa88e24b4a
            50  VclBuilder::VclBuilder                                                                                    builder.cxx                   523  0x7ffa88ea53be
            51  SalInstanceBuilder::SalInstanceBuilder                                                                    salvtables.cxx                7088 0x7ffa895da3ff
            52  std::make_unique<SalInstanceBuilder,vcl::Window * &,rtl::OUString const &,rtl::OUString const &,0>        memory                        3434 0x7ffa895d44c8
            53  SalInstance::CreateBuilder                                                                                salvtables.cxx                7470 0x7ffa895ef18e
            54  Application::CreateBuilder                                                                                builder.cxx                   198  0x7ffa88ebed2a
            55  BuilderPage::BuilderPage                                                                                  weldutils.cxx                 28   0x7ffa89684128
            56  SfxTabPage::SfxTabPage                                                                                    tabdlg.cxx                    137  0x7ffa8cd5f0e5
            57  SvxFontSubstTabPage::SvxFontSubstTabPage                                                                  fontsubs.cxx                  36   0x7ffa8372d1cd
            58  std::make_unique<SvxFontSubstTabPage,weld::Container * &,weld::DialogController * &,SfxItemSet const &,0> memory                        3434 0x7ffa8372cdbf
            59  SvxFontSubstTabPage::Create                                                                               fontsubs.cxx                  146  0x7ffa8372f692
            60  CreateGeneralTabPage                                                                                      treeopt.cxx                   289  0x7ffa8383199a
            61  OfaTreeOptionsDialog::SelectHdl_Impl                                                                      treeopt.cxx                   1317 0x7ffa838372e7
            62  OfaTreeOptionsDialog::ShowPageHdl_Impl                                                                    treeopt.cxx                   623  0x7ffa83837f11
            63  OfaTreeOptionsDialog::LinkStubShowPageHdl_Impl                                                            treeopt.cxx                   620  0x7ffa83834366
            64  Link<weld::TreeView &,void>::Call                                                                         link.hxx                      111  0x7ffa88ebdf13
            65  weld::TreeView::signal_changed                                                                            weld.hxx                      969  0x7ffa88ef210f
            66  SalInstanceTreeView::SelectHdl                                                                            salvtables.cxx                5304 0x7ffa895f4b39
            67  SalInstanceTreeView::LinkStubSelectHdl                                                                    salvtables.cxx                5299 0x7ffa895f38c6
            68  Link<SvTreeListBox *,void>::Call                                                                          link.hxx                      111  0x7ffa88ebe413
            69  SvTreeListBox::SelectHdl                                                                                  treelistbox.cxx               454  0x7ffa892ba7a1
            70  SvTreeListBox::Select                                                                                     treelistbox.cxx               2128 0x7ffa892ba514
            71  SvImpLBox::SetCursor                                                                                      svimpbox.cxx                  617  0x7ffa892d05e8
            72  ImpLBSelEng::SetCursorAtPoint                                                                             svimpbox.cxx                  2596 0x7ffa892d08a9
            73  SelectionEngine::SelMouseButtonDown                                                                       seleng.cxx                    174  0x7ffa88fd0071
            74  SvImpLBox::MouseButtonDown                                                                                svimpbox.cxx                  2016 0x7ffa892cc580
            75  SvTreeListBox::MouseButtonDown                                                                            treelistbox.cxx               2277 0x7ffa892b71e2
            76  ImplHandleMouseEvent                                                                                      winproc.cxx                   708  0x7ffa89059867
            77  ImplHandleSalMouseButtonDown                                                                              winproc.cxx                   2338 0x7ffa8905afef
            78  ImplWindowFrameProc                                                                                       winproc.cxx                   2683 0x7ffa8905ca47
            79  SalFrame::CallCallback                                                                                    salframe.hxx                  312  0x7ffa88e1ee56
            80  ImplHandleMouseMsg                                                                                        salframe.cxx                  3335 0x7ffa85c270bf
            81  SalFrameWndProc                                                                                           salframe.cxx                  5987 0x7ffa85c2de7d
            82  SalFrameWndProcW                                                                                          salframe.cxx                  6342 0x7ffa85c2ec60
            83  CallWindowProcW                                                                                           USER32                             0x7ffad61cef5c
            84  DispatchMessageW                                                                                          USER32                             0x7ffad61ce684
            85  ImplSalDispatchMessage                                                                                    salinst.cxx                   475  0x7ffa85b8cf98
            86  ImplSalYield                                                                                              salinst.cxx                   552  0x7ffa85b8d6bd
            87  WinSalInstance::DoYield                                                                                   salinst.cxx                   581  0x7ffa85b8cc61
            88  ImplYield                                                                                                 svapp.cxx                     385  0x7ffa89656364
            89  Application::Yield                                                                                        svapp.cxx                     474  0x7ffa89659fe2
            90  Dialog::Execute                                                                                           dialog.cxx                    1077 0x7ffa88f0c017
            91  SalInstanceDialog::run                                                                                    salvtables.cxx                1882 0x7ffa896149af
            92  weld::DialogController::run                                                                               weld.hxx                      2691 0x7ffa88eef436
            93  OfaTreeOptionsDialog::run                                                                                 treeopt.cxx                   2514 0x7ffa83841dd2
            94  CuiAbstractController_Impl::Execute                                                                       dlgfact.cxx                   144  0x7ffa837085c8
            95  SfxApplication::OfaExec_Impl                                                                              appserv.cxx                   1641 0x7ffa8cb36506
            96  SfxStubSfxApplicationOfaExec_Impl                                                                         sfxslots.hxx                  1307 0x7ffa8cb10165
            97  SfxDispatcher::Call_Impl                                                                                  dispatch.cxx                  257  0x7ffa8cc1f4ae
            98  SfxDispatcher::Execute_                                                                                   dispatch.cxx                  754  0x7ffa8cc2260f
            99  SfxBindings::Execute_Impl                                                                                 bindings.cxx                  1062 0x7ffa8cc0086d
            100 SfxDispatchController_Impl::dispatch                                                                      unoctitm.cxx                  736  0x7ffa8cc93caa
            101 SfxOfficeDispatch::dispatch                                                                               unoctitm.cxx                  254  0x7ffa8cc945b0
            102 framework::MenuBarManager::Select                                                                         menubarmanager.cxx            821  0x7ffa8d8574d4
            103 framework::MenuBarManager::LinkStubSelect                                                                 menubarmanager.cxx            776  0x7ffa8d855796
            104 Link<Menu *,bool>::Call                                                                                   link.hxx                      111  0x7ffa88f77d88
            105 Menu::Select                                                                                              menu.cxx                      360  0x7ffa88f83e19
            106 Menu::ImplCallSelect                                                                                      menu.cxx                      2152 0x7ffa88f7c761
            107 Menu::LinkStubImplCallSelect                                                                              menu.cxx                      2148 0x7ffa88f82366
            108 Link<void *,void>::Call                                                                                   link.hxx                      111  0x7ffa890529b3
            109 ImplHandleUserEvent                                                                                       winproc.cxx                   2288 0x7ffa8905ba97
            110 ImplWindowFrameProc                                                                                       winproc.cxx                   2850 0x7ffa8905d256
            111 SalFrame::CallCallback                                                                                    salframe.hxx                  312  0x7ffa88e1ee56
            112 ImplHandleUserEvent                                                                                       salframe.cxx                  4471 0x7ffa85c28fab
            113 SalFrameWndProc                                                                                           salframe.cxx                  6236 0x7ffa85c2e654
            114 SalFrameWndProcW                                                                                          salframe.cxx                  6342 0x7ffa85c2ec60
            115 CallWindowProcW                                                                                           USER32                             0x7ffad61cef5c
            116 DispatchMessageW                                                                                          USER32                             0x7ffad61ce684
            117 ImplSalDispatchMessage                                                                                    salinst.cxx                   475  0x7ffa85b8cf98
            118 ImplSalYield                                                                                              salinst.cxx                   506  0x7ffa85b8d09b
            119 WinSalInstance::DoYield                                                                                   salinst.cxx                   581  0x7ffa85b8cc61
            120 ImplYield                                                                                                 svapp.cxx                     385  0x7ffa89656364
            121 Application::Yield                                                                                        svapp.cxx                     474  0x7ffa89659fe2
            122 Application::Execute                                                                                      svapp.cxx                     361  0x7ffa89653aa6
            123 desktop::Desktop::Main                                                                                    app.cxx                       1679 0x7ffa9336887f
            124 ImplSVMain                                                                                                svmain.cxx                    228  0x7ffa8966b310
            125 SVMain                                                                                                    svmain.cxx                    247  0x7ffa8966baf2
            126 soffice_main                                                                                              sofficemain.cxx               121  0x7ffa933b86f4
            127 sal_main                                                                                                  main.c                        51   0x7ff64a491013
            128 main                                                                                                      main.c                        49   0x7ff64a49105a
            129 __scrt_common_main_seh                                                                                    exe_common.inl                288  0x7ff64a491344
            130 BaseThreadInitThunk                                                                                       KERNEL32                           0x7ffad5c07374
            131 RtlUserThreadStart                                                                                        ntdll                              0x7ffad679cc91
        
        Change-Id: I3be8a8e4acd1c87fdfa495c755fd947e9a11b9aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177314
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [4622e28f8308e5bd3b4d29f91da7b25760362373]

        a11y: Drop misleading comment
        
        The "The role is always AccessibleRole::COMBO_BOX." comment
        for VCLXAccessibleBox::getAccessibleRole is misleading,
        as the actual implementation can also return AccessibleRole::PANEL.
        
        Change-Id: I15b089e168aa7ec0701eacc8630023123f3a10dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177313
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [c7e210919ac940ca7734ec6dd9b2ecb76ab3d4d4]

        a11y: Create VCLXAccessibleEdit::isComboBoxChild helper
        
        It will be reused in another method in an upcoming commit.
        
        Change-Id: Ie6b4559e268d9340b5b13844c906232c6ff38a6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177312
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [c9cae91d0a37051e1009730ceadf3a1ca3f239ee]

        a11y: Drop VCLXAccessibleComponent::supportsService overrides
        
        Like the base class implementation, they call
        cppu::supportsService, so there's no need to override
        the former.
        
        Change-Id: I6550edce0567502a411cac402923c2c02e02f58d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177311
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ea0b06415b35ff68959c8fb24355f2c15ad63e64]

        external/postgresql: Include configure fix for C23 stdbool.h
        
        ...by backporting upstream
        <https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=bc5a4dfcf7390145dc3ba3c1c18c5ce561b778cd>
        "Assume that <stdbool.h> conforms to the C standard." to our REL_14_15 version.
        GCC 15 trunk defaults to C23 now, so started to fail with
        
        > In file included from fls.c:49:
        > ../../src/include/c.h:419:23: error: two or more data types in declaration specifiers
        >   419 | typedef unsigned char bool;
        >       |                       ^~~~
        > ../../src/include/c.h:419:1: warning: useless type name in empty declaration
        >   419 | typedef unsigned char bool;
        >       | ^~~~~~~
        > make: *** [<builtin>: fls.o] Error 1
        > make: Leaving directory 'workdir/UnpackedTarball/postgresql/src/port'
        
        (Removing HAVE__BOOL and HAVE_STDBOOL_H also from src/tools/msvc/Solution.pm is
        necessary to avoid failures like
        
        > "C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/openssl\apps\openssl.exe" version 2>&1unused defines: HAVE_STDBOOL_H HAVE__BOOL at /home/tdf/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/postgresql/src/tools/msvc/Mkvcbuild.pm line 870.
        > make[1]: *** [C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/external/postgresql/ExternalProject_postgresql.mk:27: C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/workdir/ExternalProject/postgresql/build] Error 1
        
        in MSVC builds.)
        
        Change-Id: I1f6bd0d613ae4d6ce70feaaf67aaf95496eeff87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177280
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ed282bedf626ac93ce005906aed7fc2bb835a55]

        sc: prefix members of ScConditionalFormat
        
        Change-Id: Ib8d6b19f4ff1a5a641039f7e06083430b53a6edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177301
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-26  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [2baa317ae365003b75537bbdc4d7b57bfa20e0b3]

        Libreoffice Theme Part 5: OSX Color Customization
        
        We don't draw popup menus and menubar rather use the native ones. I don't know any Objective-C which made it really difficult for me to parse the widget toolkit code.
        
        I can learn it if required, but it would be better if some macos developer takes this patch further; Themeing related objects like colors, persona settings (TODO) will be available via the ThemeColors class.
        
        Change-Id: Idd89328ca82fbfa58b1e686b5b105469bea4b4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171239
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-26  Sahil Gautam  <sahil@libreoffice.org>  [608deaf49c585e8b34e9d53e4e3f175fbfdf3201]

        Libreoffice Theme Part 4: Windows Color Customization
        
        I couldn't find any way of putting the colors from the theme back
        into the system using the win32 api. Taking inspiration from Caolan's
        dark mode patch (commit: a3f400886768bf95fbd8e6b236e11d7aac393b96,
        related: tdf#118320 enable some windows dark theme support, 2022-03-17),
        I was able to make it work.
        
        I am working on vcl welding for windows, for which I am learning win32.
        In the coming weeks/months the themeing approach for windows
        is expected evolve because of that. There are some "rough edges" still...
        something to be addressed later in different tickets.
        
        Change-Id: I4b4cb3804b9b7a9d15e75a1b2511cdedda2b5b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170840
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-11-26  Szymon Kłos  <szymon.klos@collabora.com>  [16bce5bb1cb4e446f45633b128f6ab02a48b6840]

        tdf#86731 bNoDictionaryAvailable should trigger meesagebox
        
        Reverts "PVS: V547 Expression 'bNoDictionaryAvailable' is always false"
        This reverts commit 816b51c7a9cdd72eaa01f3c074ba5a8446917d19.
        
        It removed the message completely from the code while, we should
        fix it rather by using correct condition.
        
        It was somehow too aggresively limited in commit f200dd5cb84681558700c49de0969907f78f8db1
        tdf#86731 Don't show 'start from beginning' when dictionary is missing
        
        Change-Id: I5f4b859047216399a09c7aefb8a47244c4833df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177271
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-11-26  Gülşah Köse  <gulsah.kose@collabora.com>  [d902401452d85db0c320401335b5170dfa5f6c51]

        tdf#163842 Fix autofilter ascending sort condition reference import
        
        if (rSorConditionLoaded.mbDescending) condition ignores the ascending sort.
        So when we import a document that uses ascending sort then export it, we
        don't know which column is sorted.
        
        With the following patch we fix this case.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I561146517959a87eb0fb6cec419d68299bcb7eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177016
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177222
        Tested-by: Jenkins

2024-11-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4049405dcde61fa66852dae72d811562c69b3920]

        Let a test use a copy of a SRCDIR test doc
        
        Whatever the reason, but running the test against a read-only SRCDIR caused
        CppunitTest_sfx2_view
        CPPUNIT_TEST_NAME=testLokHelperCommandValuesSignature::TestBody to fail with
        
        > sfx2/qa/cppunit/view.cxx:138:testLokHelperCommandValuesSignature::TestBody
        > assertion failed
        > - Expression: nSignatureTime != 0
        
        Change-Id: I35d7df0de1b63937920687444ea0698fc0856446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177302
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [1e54b2037a4d58dacc821bd8833e924f6691a7fd]

        tdf#146269: don't set modified when connecting frame, model and controller
        
        Change-Id: I487a989a97389af11c98e10ac001c860d7855aec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177300
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d88683e4675f836c26c8fb10cda7a7d71026bcb7]

        Some simplification
        
        Change-Id: I8dc994421ef036f609e270c4891ac4494276ba23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177299
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8f2bf78a55624da22d18a844dc3f05fd61c4f62b]

        comphelper: fix test - key should be 32 bytes, not 16 bytes
        
        Issue spotted when trying encryption and decryption with OpenSSL,
        which doesn't handle the shorter keys correctly.
        
        Also can't use the same instance of Encrypt after an attempt that
        failed  (0 bytes written) as the blocks are inter-dependent and
        it looks like OpenSSL already changes the state.
        
        Change-Id: I061764e6727c7fbe600e11c5a5a6b8889d15c4e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177305
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5e0c670e6534fee529ea46d520c6b442bea93aac]

        comphelper: add support for AES256_ECB encryption
        
        Change-Id: I5e8ab2a2be6ea9cd5d1ed93b70780f1f6153f3fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176892
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a0ff88da40c2fdc20a069e686230506e41b2ebc5]

        pdf: write encrption O and U values as hex string
        
        This is easier to evaluate when opening the file in text editor
        than binary. It is also more common in other PDF writers to use it
        as hex string. There is no problem with viewers.
        
        Change-Id: Ie453556d22695017916c7953f91c499e3d990b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176891
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-26  Kurt Nordback  <kurt.nordback@protonmail.com>  [b10d331c1c9801adbf6d014d9348bb0a4dad3d2c]

        tdf#161800 -  I/O of '# of values in second plot' parameter not supported
        
        Add support for input and output of 'split position' parameter (number of entries
        in second plot) for of-pie charts. In OOXML this uses the supported split-pos
        tag. For ODF I added an extension in loext namespace for this parameter.
        This commit also includes simple tests for the I/O functionality in OOXML and
        ODF.
        
        Change-Id: I00ff59db721867fa836eb99b6677350040d005dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170666
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-25  Oliver Specht  <oliver.specht@cib.de>  [7c7e7da1538c1ed0c65821e18233ec9dcdc6cd2b]

        tdf#152839 remove paragraph spacing attributes in fill cells
        
        Invisible cells in Word are added to Writer tables to get regular
        tables. Borders of such cells are allready switched off. Now also
        paragraph spacing is removed to not determine the row height.
        
        Change-Id: I27d3d033de54f051527cf29e2655e7a564d1a5ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176219
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-11-25  Oliver Specht  <oliver.specht@cib.de>  [29a95e4b9051ee35b063b88ac4d80d81f78eca85]

        tdf#163870 remove list attribute on style apply
        
        Follow-up to 075560420a7aa238182e2d80dfe1c5fbaad3edbd
        Removes hard list attribute also if the applied paragraph
        style is applied again.
        
        Change-Id: Ic08241b5e244690825dfe79c419298c5d5f7c17e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177270
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [dc0307fd4092383a8740225307001894cdc81519]

        ScCondFormatList: pDoc is never nullptr
        
        Change-Id: I764cd7eed4fe91bac7ad83dbbc48b2a2c4509c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177273
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-25  Justin Luth  <justin.luth@collabora.com>  [507c6fc66cda7c1022008b3d1d4c087540cb2d18]

        tdf#124741 export xlsx: no defaultRowHeight without customHeight
        
        Apparently, the value of defaultRowHeight is just some nice
        kind of suggestion to Excel, since optimalRowHeight rows
        can be less than what is specified in defaultRowHeight.
        
        Since Calc always treats defaultRowHeight as authoritative,
        on export it needs to always export it that way.
        
        Apparently there are some TWIPS calculations
        going on because while Calc defaults
        to exporting a defaultRowHeight of 12.80,
        Excel is still round-tripping it as 12.75.
        
        make CppunitTest_sc_subsequent_export_test2 \
            CPPUNIT_TEST_NAME=testTdf120168
        (In this unit test, it originates as customHeight=1,
        but Calc was round-tripping it without that.
        Although the round-trip looked identical in Calc,
        in Excel the empty rows were now much shorter,
        being height-formatted according to the default font size.)
        
        Change-Id: I7ed6b612de0fa508a89dc4cf357b873de230962c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177276
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f0a2c52f60f2d11bf4a1f8df246f651ce01360e]

        Resolves: tdf#163777 Ignore pageup and down when modifier held...
        
        in a SalInstanceEntryTreeView, otherwise the ctrl+pageup/down gets
        processed twice by the toplevel notebook due to the forwarding used
        here.
        
        Change-Id: Ic5003064ddba44f940fb4c4a727d8081c3644361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177277
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-25  prrvchr  <prrvchr@gmail.com>  [4178b34521227e726bd1f393d384c17c63909c3d]

        tdf#164040 Expose XGridDataListener type in SortableGridDataModel
        
        It had been introduced in commit de9dba9275aff2863978f7f665685d54ef82b0ad
        (gridsort: introduce XSortableGridDataModel::removeColumnSort, 2011-01-18),
        but in getTypes, an explicit exclusion for it had been made.
        
        Change-Id: I4915949b26ef15905ec810aa54e69d0e62100b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177256
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-25  Patrick Luby  <guibmacdev@gmail.com>  [0807fe362819629259a9a80a48d2826e588d909c]

        Improve rendering speed for native controls when using Skia/Metal
        
        While debugging tdf#163945, Xcode's Instruments application uncovered
        the following performance bottlenecks when using Skia/Metal:
        
        1. Very slow rendering an NSBox:
           Many system colors have the NSColorTypeCatalog color type. For
           some unkown reason, setting the NSBox's fill color to a color set
           to NSColorTypeCatalog causes drawing to take at least twice as
           long as when the fill color is set to NSColorTypeComponentBased.
           So, only draw with a fill color set to NSColorTypeComponentBased.
        
        2. Excessively large offscreen buffers when drawing native controls:
           The temporary bitmap was set to the control region expanded by
           50 * mScaling (e.g. both width and height were increased by 200
           pixels when running on a Retina display). This caused temporary
           bitmaps to be up to several times larger than needed. Also,
           drawing NSBox objects to a CGBitmapContext is noticeably slow
           so filling all that unneeded temporary bitmap area can slow down
           performance when a large number of NSBox objects like the status
           bar are redrawn in quick succession.
           Using getNativeControlRegion() isn't perfect, but it does try to
           account for the focus ring as well as the minimum width and/or
           height of the native control so union the two regions set by
           getNativeControlRegion() and add double the focus ring width on
           each side just to be safe. In most cases, this should ensure
           that the temporary bitmap is large enough to draw the entire
           native control and a focus ring.
        
        3. Unncessary copying of bitmap buffer when drawing native controls:
           Let Skia own the CGBitmapContext's buffer so that an SkImage
           can be created without Skia making a copy of the buffer.
        
        Change-Id: Ibd3abb4b9d7045c47268319772fe97a5c4dba3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177225
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fc1e12bb2dbe74793adc8e66d0d1eaa0ab701efb]

        distro-configs/LibreOfficeFlatpak.conf lacks --without-system-java-websocket
        
        ...after 3de3f660af5afad6f4a78cc021ed20dada936bbd "add a
        --with-system-java-websocket"
        
        Change-Id: If96dafacbc33746934a2d388b11436c797290559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177275
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-25  Justin Luth  <justin.luth@collabora.com>  [8431865e6b4d006f9df34663c4d81e76cccbda44]

        tdf#108820 tdf#158713 sw layout: no footnote in repeated table rows
        
        This fixes my LO 7.1 regression from bug 108820.
        
        The problem was that footnotes-placed-in-table-headline
        were being visually removed if a split-table was ever joined
        during editing, etc. (i.e. one less page needed).
        
        Avoid the join() cleanup code being triggered on GetFollow frames
        because those were wrongly being informed that there was a footnote,
        despite being deliberately disallowed in IsFootnoteAllowed,
        so it really must not HasFootnote()!
        
        make CppunitTest_sw_core_layout \
            CPPUNIT_TEST_NAME=testTdf158713_footnoteInHeadline
        
        Change-Id: I8f395217ba66a258738fc3f32846b952c69d367b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177059
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-11-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ac2b3c339ee47497365066754e9937aba2cca700]

        GCC 15 trunk now defaults to C23, where bool is a keyword
        
        ...so the existing C code started to fail with
        
        > In file included from workdir/UnpackedTarball/mariadb-connector-c/libmariadb/ma_alloc.c:20:
        > workdir/UnpackedTarball/mariadb-connector-c/include/ma_global.h:687:25: error: two or more data types in declaration specifiers
        >   687 | typedef char            bool;   /* Ordinary boolean values 0 1 */
        >       |                         ^~~~
        
        (And the !defined(HAVE_BOOL) there, always being true, apparently started to get
        in the way now and thus needed to be removed, whatever its original purpose.)
        
        Change-Id: I781458d643e01a7199e19a178da3a32520d16b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177260
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-25  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [e2378e0074c35fa5b7980f8202ca137c518e399b]

        tdf#85976 consider 'contains column labels' property for database range
        
        A database range  is an <table:database-range> element in file  format. It has the
        attribute 'table:contains-header'  with values  'true' (default) and  'false', and
        the attribute  'table:orientation' with values  'row' (default) and  'column'. The
        attributes are only written to file, if the value is not default.
        
        If the  selected range has a  database range element then  use its contains-header
        property rather than what was last selected.
        
        Change-Id: I120daa2756c50b6c51fab4f6a0549a0b874abaee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177231
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [4fef75d4c8798dd5ebff1c6bd66993665602507d]

        sw: fix property set implementation of SwXTextRange RANGE_IS_SECTION
        
        Use cursor that includes section nodes, the core implementation should
        not need start/end to be a text node.
        
        Fix one case in SwDoc::ResetAttrs() where a text node is expected.
        
        (regression from commit 7ab349296dac79dad3fec09f60348efcbb9ea17e)
        
        Change-Id: I56960b5d233ced02703a7c522ebe6afa3347cd25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177259
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [ba3ac4735deeda1332f9c716a6f1b5f6cd4c9c4a]

        a11y: Avoid const_cast in Window::getLegacyNonLayoutAccessibleRelationLabelFor
        
        Make the ImplGetLabelFor param const, so the const
        `this` can just be passed to it as is.
        
        Change-Id: Ie6f0c5100cc67050012d9165b436cbd76550d8d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177248
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [4401a0ee3efcf3a13d4ae83291f186aaf4c994e5]

        vcl: Use non-const local var instead of const_casting later
        
        Change-Id: I34ddf601a4f48aa894e32ae0842fd30f4cfe823b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177247
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [a3152312aca05b4ac0afd9f1640ba04c8ddbafce]

        a11y: Make ImplGetLabeledBy param const and drop const_cast
        
        Change-Id: I7b9d61a5a6752985d17633f2a1aff80d86a7011a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177246
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [afa42fcd26d9d8677b246fcc4485a11c50d5d67d]

        PVS: V547 Expression 'pOldSelFly' is always true.
        
        Since
        commit 142dc93d9ad793e036baa5573aea31cb6f416f57
        Author: Michael Stahl <Michael.Stahl@cib.de>
        Date:   Mon Oct 26 16:41:29 2020 +0100
        
            (related: tdf#131679) sw: only unmark if this SwFlyFrame is marked
        
        Change-Id: Ia916161d336dad3d06e9df0c5747fda78dbd404c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177254
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [93362fec3e5cb3a8e009d518bd1325fb750b3c0d]

        fix: Gtk-CRITICAL gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed
        
        Change-Id: I45cbfbef038653e1e99e9b2f8907a1739d6c2214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177257
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [32d81ed85c581134dbbfe04707863a59f0101a1a]

        PVS: V560 A part of conditional expression is always true
        
        Change-Id: I1c84f84f5d656e2a11f5b3a594f7f19641ff51ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177255
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [579d0a72a3df1e292d1d1a049247500d003ff4e3]

        a11y: Move identical implementations to base class
        
        Instead of having a purely virtual
        VCLXAccessibleBox::IsValid that all subclasses
        implement the same way, deduplicate this by
        moving the implementation to the VCLXAccessibleBox
        base class.
        
        Change-Id: I354bf3d0be6751a165b373c06b951c6f0b63480b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177252
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [d2587b5646833b49c9cfc12ea7eaa013a1fcf7f1]

        gtk3: Drop gtk+-unix-print-3.0 from configure.ac
        
        Unused since
        
            commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6
            Date:   Sun Dec 20 16:49:12 2020 +0000
        
                drop never completed GtkSalPrinter
        
        Change-Id: Iacbf84449175863e5a6ad09f6946b3bd3b503a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177237
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-25  Michael Weghorn  <m.weghorn@posteo.de>  [ae55831f16584aa2a727aa684df57f590bdab0e9]

        a11y: Make param const to avoid const_cast in caller
        
        Make the `pWindow` param for `ImplFindDlgCtrlWindow`
        a const pointer, which removes the need to
        `const_cast` when calling the function in
        Window::getLegacyNonLayoutAccessibleRelationMemberOf.
        
        Change-Id: I2225f5c4be33060c1e3fddd5e83760e68856585d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177245
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9f35c2b6cdc50de017aae3585fd9e55b0796d4e4]

        move SdViewOptions options down to ViewShellBase
        
        ViewShellBase is the SfxViewShell and is the analogue of the equivalent
        writer/calc SfxViewShell's, while a DrawViewShell is one of multiple
        sd::ViewShells that can exist inside that SfxViewShell
        
        Issue:
        * When creating new shell instances, background color is fetched from application configuration.
        * When multiple users are active on an Impress document, if one switches to notes view, a new shell is created.
        * Background color for the new shell is fetched from app colors.
        * If another user has switched to dark mode, the user which just switched to notes view, will see dark mode for their background.
        
        Moving the SdViewOptions options down the ViewShellBase means that
        multiple sd::ViewShells hosted within that ViewShellBase share the same
        view settings.
        
        Change-Id: Id875260dda89311ab8029ead08b47f80fd14604f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [3a00e589cec3d760efa677edfe11c81841d986ad]

        slideshow: lok: export bounds for animated layers
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Iccc0993fd9736842fc3e9783306d21aabc813e5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173121
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177249
        Tested-by: Jenkins

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c20db9a219699f689d0096fb11fe72d10034c6f0]

        cid#1607047 Overflowed integer argument
        
        Change-Id: I60c991ba32c85ed872c6086104774259d1ac3b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-25  Sahil Gautam  <sahil.gautam.extern@allotropia.de>  [81a6c8704f19a08acb6c56cc39d5f117ee38df75]

        tdf#85976 Use correct labels in 'Handle Duplicate Records' dialog
        
        + 'Records:' to 'Compare by:'
        + if row is selected in 'Compare:', 'Header:' checkbox should be labeled as
          'Data contains column headers' and vice versa for column
        
        Change-Id: Ic9dfbab9a5636312c40b6945af3abdcd9b190310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177230
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil.gautam.extern@allotropia.de>

2024-11-25  Miklos Vajna  <vmiklos@collabora.com>  [95efd80fcae322a14c5051e8a4455b571db926c5]

        cool#10582 sd lok: insert curve shapes directly
        
        Dispatching .uno:Line in LOK mode inserts a line shape with defaults at
        the center of the current slide, but dispatching .uno:Bezier_Unfilled
        starts an interactive mode where the preview is not exposed in LOK, so
        looks weird.
        
        .uno:Line works because DrawViewShell::FuPermanent() actives the "create
        directly" flag for SID_DRAW_LINE.
        
        Fix the problem by doing the same for SID_DRAW_BEZIER_NOFILL in the next
        block: we get a curve shape with reasonable defaults with this.
        
        If an interactive curve drawing mode is wanted for LOK in the future,
        then that would be handled outside LOK anyway, with taking the already
        drawn curve's properties at UNO command dispatch time.
        
        Change-Id: I03feded76578575ecfbd4a0d79c7ca1a31e37093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177250
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1c49a6d5aab168ca02fdda6d2c27d4ca1fa152f6]

        cid#1607224 Overflowed return value
        
        Change-Id: I297159aec76a497c5082c70adc0c2e45878322a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177240
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e1ecd89fb3e389bb3d5f331ed178cb76d8d5cfa]

        Labels can just use mnemonic-widget to indicate what they label
        
        the more complex label-for/labelled-by only need to get used
        when when using something non-standard as a "label"
        
        Change-Id: Ibbe13b868622646e20357703e31cfc26e31fac7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177238
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [51b2f0a1c787b77df843f37fa641f28e5d2ddc66]

        slideshow: lok: correct z-order
        
        we need to keep the order correct, especially
        when we have stacked shapes which are animated
        and some are non-animated.
        
        in case:
        
        non-anim
        anim
        non-anim
        anim
        
        don't allow to join non-animated layers into one
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ic5d94478b691a80fd62853946ebedec075963f44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173116
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177236
        Tested-by: Jenkins

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [4ffd7c145626563ef36f81a256b5b2cddc72fc8e]

        slideshow: fix initVisible value
        
        be sure we don't overwrite the real "visibility"
        value when other property is read
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ied2285e8183665b5b48d10d74e1cc052cf8edcbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173110
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177235

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [dfb779ff7689fc31b7e6bd27ea87a2074c2bdfd3]

        lok: slideshow: render animated objects as separate layers
        
        don't merge animated and non-animated objects on single
        layer
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I259507e08c95c3662e60f7691646395d1a840465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173084
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177228
        Tested-by: Jenkins

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [505775873fb715ef4e60a88927fd73b5e96b0b6d]

        lok: slideshow: render background as separate layer
        
        we still take color from the JSON
        
        Change-Id: I6b83cc8aaaa3e9127d85ec06589bac7ed4472f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173083
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177227
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-11-25  Miklos Vajna  <vmiklos@collabora.com>  [ff68535068169d86cf95907c5e6a3a0aee94cb49]

        svx: prefix members of SdrDragMove
        
        See tdf#94879 for motivation.
        
        Change-Id: I4945cec5ee88700360c5a8ff706105dbc7f95f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177229
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [58e255c8e29e5287d9c9fea2a698045138a354ca]

        Related: tdf#157233 - A11y: fix wrong Issue ID in options_list
        
        DocumentStyleLanguage used the wrong AccessibilityIssueID.
        
        Change-Id: I7bbb9737abc9b36972376e86996e65443014b178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177040
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-11-25  Aron Budea  <aron.budea@collabora.com>  [69e881925f8fb876f334541abe0c17fbaf3f8f1f]

        tdf#163486 PVS V581 The conditional expressions of the 'if' statements situated
        
        ...alongside each other are identical.
        
        Started when a call inbetween was removed in
        e50f6c023926269f76cd73e085b7a246cd0f88fa.
        
        and
        V1053 Calling the 'EnableRTL' virtual function in the constructor
        ...may lead to unexpected result at runtime.
        
        and
        V1051 Consider checking for misprints. It's possible that the
        ...'nTopPos' should be checked here.
        
        V1028 Possible overflow. Consider casting operands of the...
        'nStartCol + 1' operator to the 'sal_Int64' type, not the result.
        
        Change-Id: Ided25ab6dc9e9d4a1c72a1b809de586c7b890ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177218
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c969795babd116635f87184facdc37f4f952d838]

        pdf: Introduce a IPDFEncryptor and use it in PDFWriterImpl
        
        The idea of IPDFEncryptor is to be the interface to encrypt the
        stream/string in the same way, irregardless which PDF encryption
        version/revision we are using.
        
        Change-Id: Ie7835384f1be5a44c53985b01c8187323400aa0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176890
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a7041bb3099dcd40ec67d598dc0fa3eecf2e63d3]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Id7b5e1675963fd4b65974f4da39dbdccd45af549
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [c913af24825baa8c95c91c3706d140a0b45e3341]

        slideshow: extract initial visibility of the animation target
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I35ea503d254f36c8ab7307b157c87d5c2e0a8e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173050
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177224
        Tested-by: Jenkins

2024-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [8bbc65fa69b2c414370bfc3035368ac0437dae03]

        Identify layers so can be recognized as animation target
        
        it has to match convertTarget result from unomodel.cxx
        which is used on export of animations
        
        Change-Id: I61df0b82681628722516c17c110acd90ce25b881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172875
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177223
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-11-25  Aron Budea  <aron.budea@collabora.com>  [9646eddfa09c0048b2ca0371b9d540076025b0ca]

        tdf#163486 PVS V1023 A pointer without owner is added to the container
        
        ...by the 'emplace_back' method.
        
        Change-Id: I76a0a655d5fc5b123cd1018cb010ff9c9625c1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177226
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-11-25  Aron Budea  <aron.budea@collabora.com>  [fbfa2769f261cba11a5ea7f3be648fa67c3816ca]

        tdf#163486 PVS V1037 Two or more case-branches perform the same actions
        
        second identical branch was added in
        d519cbe89268ff24e2b8b05ba5124dca98f22b79
        
        and
        V530 The return value of function 'GetTitle' is required...
        to be utilized
        
        the unnecessary GetTitle() call that was duplicated in
        d519cbe89268ff24e2b8b05ba5124dca98f22b79 was there since
        9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 (initial import)
        
        Change-Id: Ied25faf177184cc1b1ca4a512285232bf966c1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177209
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [f4253af367e95a59c5f68140c7b1ec0a45aa22e5]

        Avoid assigning unused value
        
        Change-Id: Ic6c59500805a8710150f083ff089b2e1c4c36530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177217
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [737c4e624f660970eb66dd9a80de3e0306647937]

        Resolves: tdf#164026 explicitly make these insensitive
        
        Change-Id: Ifa399d9bb42bad8e5209f5937052fa9b616f8914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d3c2fcc3f33f09d655904abdfbad62c1db005288]

        Resolves: tdf#163772 move margin into ValueSet itself
        
        instead of using margin property in .ui where size_request
        doesn't take such margins into account, while pref_size does.
        
        Change-Id: I7c557fd63c438515814ad32b9627895c27c13b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177213
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [c568149596fe58adcba00641368f5da7c64b3590]

        No need to create PossibleHyphens for no-hyphenation case
        
        Change-Id: Idd509e40f96373fc29d0f313bcb5c14ee8490f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177212
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [2f5acb35458d360c7db6b0f072204baf021ea84b]

        tdf#130857 qt weld: Notify about Expander state change
        
        Call weld::Expander::signal_expanded when the
        QtExpander expanded state changes, e.g. when
        its button gets clicked.
        
        In order to do that, introduce a signal in
        QtExpander and connect to that in
        QtInstanceExpander.
        
        With this in place, a breakpoint in
        weld::Expander::signal_expanded now gets
        hit as expected when (un)expanding the
        expander in the "Set Password" dialog triggered in Writer
        using "File" -> "Save As", check "Save with password"
        checkbox and press "Save" when using the qt6 VCL
        plugin with SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This implements what was mentioned as still
        missing in earlier commit
        
            Change-Id: I7e3a332c0417b1897ae57d7d4c29609245fb5e19
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 24 01:20:31 2024 +0100
        
                tdf#130857 qt weld: Add QtInstanceExpander
        
        as
        
        > Signal handling still needs to be implemented
        > (calling `weld::Expander::signal_expanded` when
        > the expanded state is toggled).
        
        Change-Id: I9cd1b2cc99018f84ba930d55399953266119bed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177199
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [5e4aa646356e1d59976e0f1adcfeb9353c65eda0]

        tdf#130857 qt weld: Support "Save with password" dialog
        
        Declare support for the "Set Password" dialog that can
        be triggered in Writer using "File" -> "Save As", check
        "Save with password" checkbox and press "Save" to trigger
        the dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This makes use of QtInstanceExpander added in
        
            Change-Id: I7e3a332c0417b1897ae57d7d4c29609245fb5e19
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 24 01:20:31 2024 +0100
        
                tdf#130857 qt weld: Add QtInstanceExpander
        
        Currently, I see a small rendering issue when
        opening that dialog and expanding the expander:
        The "Enter password to allow editing" and
        "Confirm password" label text is a bit cropped.
        It's shown fine when manually enlarging the dialog a bit,
        however.
        
        Change-Id: I37775fa3a39d621696d2a6aaa49bd11d6cfb9350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177198
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [ec760b211087b90f9cddec96d1e097bf68ad3e1f]

        tdf#130857 qt weld: Add QtInstanceExpander
        
        Add a new QtInstanceExpander class that is the
        weld::Expander implementation using a native
        Qt widget. It uses the custom QtExpander widget
        added in
        
            Change-Id: Id2366834cb542eba613ea087e70f3a812d20fa89
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 24 00:07:44 2024 +0100
        
                tdf#130857 qt weld: Implement "GtkExpander" equivalent
        
        Extend QtExpander to provide what's needed
        to implement the QtInstanceExpander methods.
        
        Let QtInstanceBuilder::weld_expander return an
        instance of the new class.
        
        Signal handling still needs to be implemented
        (calling `weld::Expander::signal_expanded` when
        the expanded state is toggled).
        
        QtInstanceExpander is e.g. needed by the "Set Password"
        dialog. ("File" -> "Save As", check "Save with password"
        checkbox and press "Save" to trigger the dialog.)
        
        Change-Id: I7e3a332c0417b1897ae57d7d4c29609245fb5e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177197
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [a60ccb091ed26e5287d29ea1df885bf144c74b3f]

        tdf#130857 qt weld: Support "Safe Mode" dialog
        
        Now that "GtkExpander" support has been implemented,
        declare support for the "Safe Mode" dialog that can
        be triggered via "Help" -> "Restart in Safe Mode"
        and confirming with "Restart".
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I67ef04356a5147c24442cd3ec84e4bbc644b3a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177196
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [62595170ec26af556cd5d2ab3501d9e12ff28d49]

        tdf#130857 openlockedquerybox.ui: Define grid children in order
        
        Switch the order in which the children of the grid in the
        .ui file are defined so that the order matches the visual appearance,
        which makes sure that tab focus order with the Qt-based VCL plugins is
        correct as well in that dialog when using native Qt widgets after
        support for that dialog was added in
        
            Change-Id: If30736e70172c6b25feee0072c952274754aa81e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 24 00:22:26 2024 +0100
        
                tdf#130857 qt weld: Support "Document in Use" dialog
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        Change-Id: Ie18c7b91911fea612167510e9bb098d63e1e9227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177195
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [a0ca2e68177322539f554cd18eea5b7ca36ae155]

        tdf#130857 qt weld: Support "Document in Use" dialog
        
        Declare support for the dialog shown when trying to
        open a file that's already opened by another user
        (or more exactly, for which a lock file suggesting
        that it's opened by another user or LO instance
        exists).
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the first supported dialog making use of "GtkNotebook"/
        QtInstanceNotebook, i.e. of what was implemented in previous commit
        
        Sample steps to see that dialog:
        
        * start Writer, save document as /tmp/test.odt
        * kill LibreOffice
        * open the lock file ( /tmp/.~lock.test.odt# ) in a text
          editor and change the user name to a dummy one, save.
        * start LO with qt6 VCL plugin and try to open the document
        
        Change-Id: If30736e70172c6b25feee0072c952274754aa81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177194
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [9ca43e71e294f778db1cd4febcfc232f2935a0b4]

        tdf#130857 qt weld: Implement "GtkExpander" equivalent
        
        Implement support for "GtkExpander" objects in .ui
        files. As Qt doesn't seem to have any equivalent, add
        a new QtExpander class that subclasses QWidget and
        has a button that can be used to toggle visibility
        of the widget that is the GtkExpander's [1] content child.
        
        For a visual appearance similar to GtkExpander,
        set an icon for the button ("go-down" and "go-next"
        from the icon theme, which are arrows like the ones
        shown on a GtkExpander, at least with the Breeze
        icon theme).
        
        In QtBuilder, implement handling for "GtkExpander"
        objects:
        
        * Create an instance of the new QtExpander
          class.
        
        * Identify the content child, which can be distinguished
          from the label child by the fact that the latter
          has a "label" child type set, see also previous
          commit
        
            Change-Id: I3e308a6642d72b55d0ccc597dac716b236c22d61
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Nov 23 20:54:47 2024 +0100
        
                tdf#130857 Pass child type to WidgetBuilder::insertObject
        
        * Erase the "visible" property for the content child,
          as otherwise the content widget would be initially
          visible even if the expander is set to not be
          expanded. (QtExpander takes care of this, so
          ignore the property set in the .ui file.)
        
        * For the label child in GtkExpander, simply take
          over its text to QtExpander's button, then mark
          the label for deletion, as it's not needed
          otherwise.
        
        Support for the "Document in Use" dialog that
        has a GtkExpander and thuse makes use of this
        will be declared in a separate commit.
        
        [1] https://docs.gtk.org/gtk3/class.Expander.html
        
        Change-Id: Id2366834cb542eba613ea087e70f3a812d20fa89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177193
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [7738a109699044ab4c370e4794234402b27b7677]

        tdf#130857 weld: Move Window::set_centered_on_parent to Dialog
        
        weld::Window::set_centered_on_parent only ever gets
        called for weld::Dialog instances, so move it to the
        weld::Dialog subclass.
        
        For the Qt implementation, no longer trigger an assert because
        of the method being unimplemented (doing nothing), as QDialog
        opens centered on its parent toplevel by default.
        Quoting from the QDialog doc [1]:
        
        > Note that QDialog (and any other widget that has type Qt::Dialog) uses
        > the parent widget slightly differently from other classes in Qt. A
        > dialog is always a top-level widget, but if it has a parent, its default
        > location is centered on top of the parent's top-level widget (if it is
        > not top-level itself).
        
        (API for moving a QWidget to a different position like
        QWidget::move [2] exists, but would only work on X11/XWayland,
        not Wayland.)
        
        [1] https://doc.qt.io/qt-6/qdialog.html#details
        [2] https://doc.qt.io/qt-6/qwidget.html#pos-prop
        
        Change-Id: I14d41f91e5297c6e58cb4edb2ee98f19814d45cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177192
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-24  Michael Weghorn  <m.weghorn@posteo.de>  [a18672dd3ef382436b0aa2449bded50c18e35705]

        tdf#130857 Pass child type to WidgetBuilder::insertObject
        
        In WidgetBuilder::handleChild, pass the child type
        not only to WidgetBuilder::tweakInsertedChild, but
        also to WidgetBuilder::handleObject (add a new param
        for that) and from there down into the virtual
        WidgetBuilder::insertObject, so it can be evaluated
        by subclasses when creating new widgets.
        
        While it is not used yet, an upcoming commit will
        make use of it in QtBuilder, in order to distinguish
        between the two "GtkExpander" children: the label and
        the actual content child.
        
        As described in the "GtkExpander as GtkBuildable" doc [1]:
        
        > The GtkExpander implementation of the GtkBuildable interface supports
        > placing a child in the label position by specifying “label” as the
        > “type” attribute of a <child> element. A normal content child can be
        > specified without specifying a <child> type attribute.
        
        [1] https://docs.gtk.org/gtk3/class.Expander.html
        
        Change-Id: I3e308a6642d72b55d0ccc597dac716b236c22d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177191
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6272747e0668e98c818c1830ae6d25186e6e649d]

        cid#1607832 Overflowed constant
        
        Change-Id: Ie0d14ef985bebf4acdb08c460675ebba75f88a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177166
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-24  Laurent Balland  <laurent.balland@mailo.fr>  [190ccb653955fa1d23e7c0d3bf5e47769a73ba30]

        tdf#161930 Copy only once mimetype
        
        mimetype must not be zipped, just stored.
        mimetype was correctly stored with the first zip command,
        but mimetype was also present in the files list on the second zip command.
        This patch remove mimetype from the files list of the second zip command.
        
        Change-Id: Ie66f06103bbad2700eee4986df878b9ebd4c0a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175930
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [b44339c2156dbef8a9adb4be88981631d0181c29]

        Deduplicate calls to hnj_hyphen_hyphenate3
        
        Change-Id: Iecd3cf707fd692a10382f3a6be02c2dd94f02111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177201
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12cad7e619913323eb748464ffe1a3bae2a9dd4e]

        cid#1607163 silence Overflowed return value
        
        and
        
        cid#1608078 Overflowed return value
        cid#1608461 Overflowed return value
        
        Change-Id: Ic5fa20994c5be5d6c09a21c0bd1e3530ae9a6941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aed4e00c4f5788253d68502f7d957dbb08f4555b]

        UserInstallation may change in kit-mode
        
        So the setting fetched at ctor time for UserInstallation (and
        BRAND_BASE_DIR) may no longer be true, so expanding variables based
        on those earlier seen values results in unwanted paths.
        
        add XInitialization to SubstitutePathVariables (like done for
        PathSettings) to allow reiniting these explicitly once.
        
        Change-Id: Ia930ea71cb09adc91d6d47ee047c44b24222e8a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175961
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 410f6b50eb44276b1d2095c844244ef4d0ddefaa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177109
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [53d54929b518e48b307611bb0e2209629a17395f]

        cid#1606852 silence Overflowed constant
        
        Change-Id: I94d75d6c2b69937e5d0f29b498518999b1f49120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177167
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-24  Patrick Luby  <guibmacdev@gmail.com>  [16b629cf08f93e27e52816c761eeb3b5c128647b]

        tdf#157312 and tdf#163945 Lower Skia flush timer priority on macOS
        
        On macOS, flushing with Skia/Metal is noticeably slower than
        with Skia/Raster. So lower the flush timer priority to
        TaskPriority::POST_PAINT so that the flush timer runs less
        frequently but each pass copies a more up-to-date offscreen
        surface.
        
        Unfortunately, lowering the priority causes tdf#163734 to reoccur.
        When a dockable window is dragged by its titlebar, a rectangle
        may be drawn in its parent window. However, the Skia flush
        timer doesn't run until after the mouse button has been
        released (probably due to lowering of the Skia flush timer's
        priority to fix tdf#163734). So run the parent frame's Skia
        flush timer immediately to display the rectangle.
        
        Change-Id: I289eab85a087cb76a751dc6b777342b8dee49e1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177190
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [ec775c8ada237b7a861074e51caf36a79d0e5fcc]

        Deduplicate a bit
        
        Change-Id: I9a19dcc2fbf5297fe391fcd3644843eb51afdb9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4cb8dd96f7031fcfaff22f8728121cab37e68f7]

        cid#1606622 silence Overflowed integer argument
        
        Change-Id: I8a25e19d3de1515a03fe478fa28c1f5eec0963c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [948e99fb30a98120e9c8281d5158faf9370e0a6f]

        cid#1555216 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555525 COPY_INSTEAD_OF_MOVE
        cid#1555562 COPY_INSTEAD_OF_MOVE
        cid#1555676 COPY_INSTEAD_OF_MOVE
        cid#1556099 COPY_INSTEAD_OF_MOVE
        cid#1556527 COPY_INSTEAD_OF_MOVE
        cid#1556607 COPY_INSTEAD_OF_MOVE
        cid#1557084 COPY_INSTEAD_OF_MOVE
        cid#1557141 COPY_INSTEAD_OF_MOVE
        cid#1557937 COPY_INSTEAD_OF_MOVE
        cid#1556099 COPY_INSTEAD_OF_MOVE
        cid#1557774 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifd716627d985dd43f4d1a9ce3df151e519fab03a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177163
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [7eaf28b0a210a9ad7b22372a2a850a8c514d7593]

        tdf#164005: also initialize locales in hyphenate()
        
        ... which is also used in queryAlternativeSpelling
        
        Change-Id: I7f0bbbc6e598d56156efe1446f422f9674ed6f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177187
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Julien Nabet  <serval2412@yahoo.fr>  [b3dd1e92af805bd549bcf9d5ce0553831d2afc73]

        Revert "tdf#152299 - Remove unused define(s) from C/C++ files"
        
        This reverts commit 16a5ae7c90a3349854fb3975b435c24f08c0a51c.
        
        It seems to break public API.
        
        Change-Id: I0ef2c6e975b4cf20b9894ddf33f36444e2230ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177168
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-24  Julien Nabet  <serval2412@yahoo.fr>  [3f0da431b3b826cd7e653dba5e77af8ec8e177f5]

        Revert "tdf#152299 - Remove unused define(s) from C/C++ files"
        
        This reverts commit aee4e184119512dc407d8a3696653b57d3d9a54f.
        
        It seems to break stable API.
        
        Change-Id: I64b7b1b5a5f5d53649a6117de34790238313ed23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177170
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [d3d176cc657d5dcb5e0bc6d8912358a9b4435a93]

        Simplify a bit
        
        Change-Id: I0b3e02669b326533f4579f57a41a16da53cf8ff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177188
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-24  Mohamed Ali  <mohmedali1462005@gmail.com>  [c069f50a9e05c796935a55e6b2db5f714cf9cff7]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I958365b3db058ec809702a5ddde1d153467f21ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177158
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [f9cac88fc24539eb5f7fa501b2499ddf5a46d7f2]

        Let ESelection use EPaM for simplification
        
        And drop EPosition, which duplicates EPaM, except for its default
        ctor (used in a single place).
        
        Change-Id: I48bb6dafcba84465d61579df0ec71b815945532a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177075
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [7fce875718687e12df4d7a8b997ca7baea548b91]

        Turn SD_MOD macro to a function
        
        Change-Id: I1303e9d48e92ac00eee12af9ed299cdaad2ce009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177072
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [2ca32d2905aaf42ca3feaae04a55500c708fe8ad]

        Turn SW_MOD macro to a function
        
        Change-Id: Ide1f6fd2fc8a80b31353a14e416505a2349cea2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177071
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [5166efaa646fdb53345009529ba2005abf9fb6c2]

        Turn SC_MOD macro to a function
        
        Change-Id: I5fc11037902bc6200fdaf4749260efe8e658bdce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [a1e7302a65554efdc339f0e0808965a7ab11fe0d]

        GetAttrOutlineContentVisible may be const
        
        Change-Id: If94b948ddcc2fac9bce254947b78afc1c6f0383e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177078
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-23  Jim Raykowski  <raykowj@gmail.com>  [662c6a6d70bab6b1a6ae8048457907be97f447ca]

        related tdf#157255: add DisableLayerHighlighting expert setting
        
        This allows the layer objects overlay to not be done when the value set
        for DisableLayerHighlighting is less than the number of objects in the
        layer of the tab which the mouse is hovered over in the layer bar.
        
        Change-Id: Ie49ecb11bfb029ada57824c0acbbd133e1fe83b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176809
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [fa706421c9a981df11814cd845fe901181c49974]

        Avoid new string allocations, when only checking if empty
        
        Change-Id: I35a44dedd27b5c3470ed035e64ec0461d8d0cbdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177074
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [ee331d51c84b0d6fcbd65810843ab6c836d9dea9]

        Reduce copying of ScEditEngineDefaulter's SfxItemSet
        
        Change-Id: Ifea96f2cf586b4e5b63761e2f03944dade764430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177073
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d33b24d62f8b84b4da2c53b9f5e42fe147645425]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I9b27cfb715f6cd0a9b6ea21da9cb24fc8d8ec739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177050
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c1a9fa9b2c783057c70045ef926fd7481e60e9ae]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I377154880c52685e5b1588221d631c51967c490a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177047
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d2adf4b1d32069bdec0655e86269034670eb1fea]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I93494b4dec546d48b7dced2f1a6c774177c99c86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176782
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [23392c3c12e5558358188a94d7bb3d53730ed92d]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I0a6d9a12f3e6d84ad4ba665ba16dd05fb6f9786f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177048
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [56b32b808b8c6f231b1a594d2e5316f33ab171b6]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I95b7b249082f5c2755ca54a0656912011d2cb116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176983
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9d862186c0e0ecb7f5948f0fd84160ce26aecdcc]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I161af7b70421a819f5ecb6b95867e6fa142fe3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177046
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f66d3e550246eca42012392e270c4660957597d6]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I183330f8c2e947d6c8dffbcabc7da6c115e08a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176963
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d4bc4d9e9f6af7d13c54be38f59f1f330b7adfdc]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I3207e070fba8407fd8475c8d774b3a500cae8e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176965
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2a3e7a751cb910bac0d8b7392658c77dfb8655c9]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: If150b8fec5350cb513550711a61923cc1a273a80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177052
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [bdb5f278a7418cc428f64563585f95e2a305e761]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Id74c10f5965d97bf24b49fc9ee777bf7b0ad251d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177051
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [291420684981050e0daff00456def227ae9c0515]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ided473c985f8bdca007d3da34f92e42fb5080f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177099
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f57f05e574ff628a8aa8c341c8a16d759b4b3640]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I01cc9d30499783e531777eb17e332490afab4d6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177098
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Simon Chenery  <simon_chenery@yahoo.com>  [c6fd44d819f77d499aa939e29c5206f04ac731f3]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: Ib0ed8868b94c1470768a95fb26767cf25fe4bf8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177028
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3f2d10e2a526602aa82e74fdcde305f448a272c7]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Id5d1b36ba734c3cf10b83f472ab5afe3a142a464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177060
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c4338ba8560331b7a8f8a147b6447f7067793022]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I38b932ab81842b5f209d89ef5229d61e10f3ffd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177097
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [89c431aa997293023e09919c8f7bb5b54a544029]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I1e460b817dd876977e520251b6a79d9fb9c283d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177100
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9579907205ee0f060fe5f9fa1ded3504c474860c]

        Spelling mistake in code
        
        Change-Id: I9db111c16865a2b7514e62a21a66d5497cda91fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176966
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [df39550839451ab6ad9b1fd722beb56c43bd5aa3]

        tdf#130857 qt weld: Hide widget marked for deletion
        
        Add a helper method QtBuilder::deleteObject
        that takes care of marking no longer needed
        objects for deletion and use it in the 3 places
        so far calling QObject::deleteLater themselves.
        
        If the object marked for deletion is a widget,
        hide it as well, as it could otherwise still
        be "in the way".
        This was seen wit the edit (QLineEdit) of the editable
        combobox in the "File" -> "Properties" dialog,
        "General" tab (in a WIP branch for adding support
        for that dialog), where the unnecessary edit was
        shown on top of the combobox, hiding the combobox
        content + dropdown button.
        
        Change-Id: Ie299b80824c94d40cfac9f7962c9bd4ba95b446d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177057
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [3e65d085efa2f2d2a8a51e57b752a8ffb2e7624d]

        tdf#130857 qt weld: Call checkbox toggled handler
        
        Change-Id: I0943a2d8e35acea8e1af97bdd151bba65b0af24a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177056
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [f928b97cfa9ab335a6be75bd993f335cfd666673]

        tdf#130857 qt weld: Handle invalid ID in QtInstanceNotebook::get_page
        
        If QtInstanceNotebook::get_page gets called with
        and ID that none of the existing pages actually have,
        return nullptr early and don't try to QtInstanceContainer
        instance for the null widget, which would trigger an
        assert when nullptr is passed to the QtInstanceWidget
        base class ctor.
        
        Calling QtInstanceNotebook::get_page with an ID for
        which no page exists yet is what
        SfxTabDialogController::AddTabPage does explicitly
        before asserting a page to assert that there isn't
        such a page yet.
        
        SalInstanceNotebook::get_page and GtkInstanceNotebook
        also have specific handling for that case.
        
        Change-Id: Ib2044fd4c9f986f2252afed5754a6383f940e5e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177055
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [f3bacd7b2ae909d39916eb9a31dd1b4994118d8f]

        tdf#130857 qt weld: Implement QtInstanceDialog::weld_content_area
        
        When this method gets called the first time, insert
        a widget with a QVBoxLayout at the beginning
        of the dialog's layout, remember and return that.
        On subsequent call, return the same one.
        
        Initially, handle the case where the dialog's
        layout is a QBoxLayout (subclass), which is
        the case for the "File" -> "Printer Settings"
        -> "Options" dialog in Writer.
        
        This should be easy to extend for other layouts
        as well when needed. For now, assert when another
        layout is used, so it will become clear when
        working on adding support for another dialog
        that needs this.
        
        Change-Id: Ia41a87f8cf62666efc91c05f25dae5fccb3da41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177054
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [9c14ec81b6c25c7932964382f306dadfefeda518]

        tdf#164006: Only use original word's positions, ignore extra encoded length
        
        The encoding of the string passed to Hunspell/hyphen service depends on the
        encoding of the dictionary itself. When the usual UTF-8 encoding is used,
        the resulting octet string may be longer than the original UTF-16 code unit
        count. In that case, the length of the buffer receiving the positions will
        be longer, respectively. But on return, the buffer will only contain data
        in positions corresponding to the characters, not code units (it is unclear
        if we even need to pass buffer that large). So just as the following loop
        only iterates up to nWord length, the calculation of hyphen count must use
        its length, too, not the length of encWord.
        
        I suspect that the use of UTF-16 code units as hyphen positions is wrong;
        it will break in SMP surrogate pairs. The proper would be to iterate code
        points. However, I don't have data to test, so let it be TODO/LATER.
        
        Change-Id: Ieed5e696e03cb22e3b48fabc14537372bbe74363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177077
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [29091962399dfae3707b1bbd981ce037c97684ec]

        tdf#164005: make sure to initialize locales before use of Hyphenator
        
        Change-Id: I23ab742801ab00b68e4f8c5e7bc415c401e28c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177076
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [061b9dc1f5f6d31abcce192663bf6a101237fdcf]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Iae168766fdfcbf4c68aa0770b0c42e96a61001c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176964
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4ece715160515af7b10980f8f94acddc2e92ed06]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ic07d9b5e5ed5c486f2fefbd535b4209a1a62eae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177066
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d784c1a5ec9f80e94895ef1726450d06364f195c]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Ifbdf8e07aa8085e465df45b48fe54345f0ad56e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176961
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [929875a43179c0ef136bab7bf86024f9348f8488]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I23379077766af9c04357bd098b132a03a9b35877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177061
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [6e828489da09ce4bf96e255e496510d37833f33e]

        tdf#162195: use SwFrame::IsHiddenNow when building index
        
        Before commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 (tdf#159565
        prerequisite: make hidden sections have zero-height frames, 2024-02-15),
        the hidden sections were absent from layout, so didn't appear in the
        SwTOXBaseSection::Update* functions. Now they are zero-height, but
        present, so their visibility must be taken into account explicitly.
        
        Change-Id: I95cc72b383a99e1f65152579c5458e253a3f60ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177079
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a3ad37edf25efa8d9039abdcc08401ca08882b4d]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I171b90858f58c4afa8984f55864712e8b7a93b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177088
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [aee4e184119512dc407d8a3696653b57d3d9a54f]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I7206e5ac7f525d810505230ef4dcdaa5fff3fbf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177065
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [16a5ae7c90a3349854fb3975b435c24f08c0a51c]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Iac23bad883f54bd980d051fe74474efdcd2572a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177063
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [fec1501374860983d837d482cd175d80f4635b6f]

        Use specific SvtModuleOptions::Is*Installed for clarity
        
        Change-Id: Ibe64b9fcccf33471d96bb0fb1aa896cb456657f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177069
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [e777bda2398e2507bca7e13582f23cad0d2d8689]

        Simplify a bit
        
        Change-Id: I6cb0d64119b859446e015eccb6438396960f351e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177068
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-23  Aron Budea  <aron.budea@collabora.com>  [10f3e7f602e68f83f851f4c5179cfd4c40d1c09e]

        tdf#163486: PVS V1028 Possible overflow. Consider casting operands,
        
        ...not the result.
        
        Change-Id: I4ba8afa5989aea906000bb9c4059855015055002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177042
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-11-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [869fff459cbee6a2edadd5c24f2b65c199712de6]

        Related: tdf#160517 - chart odf: import/export formatted chart titles
        
        No need to check chart title paragraph style name and ID, since its
        never exists.
        
        follow-up of:
        d7214aba95bbdcbd40e87ef50fc66f2e2ec4f5ff
        6fdad723729a458eaff7ca509cb202ad355832be
        
        Change-Id: Ieffe3026adc848cfbf3a847b4f876b5aa2e2a026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177011
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bbad3358168d81df38d7afa1ba61f6569c4bfc19]

        bump product version to 25.2.0.0.alpha1+
        
        Change-Id: If5be3912a516f279ada6f6b5d82b927701a0ac16

2024-11-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7cfb08c1ff7bfe0da477783fc2c0fbb661b8b29]

        cid#1634864 avoid Missing move assignment operator
        
        and
        
        cid#1634866 Missing move assignment operator
        
        Change-Id: Iaf588bdd9185da6afeee26eea0607e72a9792bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177045
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36c2ce13445d4326d97237a23ad3e517320360e8]

        cid#1608081 silence Overflowed array index write
        
        Change-Id: I40d4207eafe46736a122e07c56f6db94cb517697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177044
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [437aaf54c6076c19aad80fdede7202b8083c07f0]

        loplugin:unusedmethods
        
        Change-Id: I24666a7746f8920ddf84731f204f3e1a5b9b0c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177024
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1e8e430db41e1b3e90332e6826ba71ccb8c6971]

        loplugin:unusedfields
        
        Change-Id: I9ee946ceabf59e4126db938d6abda446fcf9ce36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176994
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c7c2716db83a0afeb1859b5fde3e44cf61b5fc5]

        loplugin:methodcycles
        
        found cycle
            FmEntryData::FmEntryData(const FmEntryData &)
            svx/source/inc/fmexpl.hxx:148
        
            FmFormData::FmFormData(const FmFormData &)
            svx/source/inc/fmexpl.hxx:230
        
            FmControlData::FmControlData(const FmControlData &)
            svx/source/inc/fmexpl.hxx:252
        
            std::unique_ptr<FmEntryData> FmEntryData::Clone()
            svx/source/inc/fmexpl.hxx:161
        
        Change-Id: I2bef463f62b4513c473bb99eb999a97e99f5e602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176993
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2fe487b20e373e09498ece248ed9e30b1cd3bf8a]

        add Santali (Ol-Chiki) languagepack (sat-Olck)
        
        Change-Id: I6cdc09f1c44acf3c7e2d8b24ccb5a73f175acbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177043
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-11-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [351e6e17e08ee2fe03143be825318687cb904342]

        Update git submodules
        
        * Update translations from branch 'master'
          to 096ea211364abd9f3a59671796e3aabb093faf54
          - add translation files for Santali (Ol-Chiki) (sat-Olck)
            
            Change-Id: Ic6efa6bfeee7fbd70c8fd629e3e7f87c8e840f8d
            
2024-11-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e49e878d824b5f3c2c1b919fa2e95a037273a327]

        Update git submodules
        
        * Update translations from branch 'master'
          to 318e92fb60edf7a9889cac87bd0489123553ce1d
          - update translations for master/25.2.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: Ie52bd18e7f82e90d5095b195ffbf6bbc4f84e254
            
2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [90c25e59124deb8fc2d282f828dd95bfd899024c]

        PVS: V547 Expression 'bComplete' is always true.
        
        Since
        commit 47527821f32f9b5890b39b4031f5962f5cb46646
        Author: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
        Date:   Mon Nov 16 22:17:07 2020 +0100
        
            SwGrfNode: Remove graphic arrived hack
        
        Change-Id: I7c0a3b0208d2da06781be6b69e04e9958b762870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177036
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [ea1d0a62d9b9790c235044a754604166ec5df6d4]

        sw: do not paint hidden frames' borders
        
        SwFrame::PaintSwFrameShadowAndBorder() is called by upper's
        SwFrame::PaintSwFrameBackground() so it needs another check.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: Ic7ac28e4af8e0abf4970d87edb40a79ad4d25156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177032
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [c80cbceeed44132320811d9e5f265417447bab5c]

        PVS: V547 Expression '!aPropertyStates.empty()' is always true.
        
        Identified by M. Kaganski
        
        Change-Id: I02c3ab0ec29367ebc2e73586044d729eab24231d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177029
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3a302043b2392cf7dcdd5dfe6e418c8e12a6eda]

        PVS: V1048 The 'bRet' variable was assigned the same value
        
        Change-Id: Idbd94e0eb49819f737a90bcb161cd3dd88f24221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177014
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [180a99d9ffe156a79a0d49bd0d5bd9c5d5f05ca9]

        Render objects that are in an animation as a separate layer
        
        Change-Id: I4220b8398e75589bd54b67942cf987244b1d0b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177035
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-22  Julien Nabet  <serval2412@yahoo.fr>  [a680e71b50e8957674f432a6b8c7adb1ee0cd70d]

        tdf#163486: PVS V1043 global object variable is declared in header (starmath)
        
        Change-Id: Ieb038d21f27c7d31362be44b71fd13e2932fcf69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176995
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-22  Patrick Luby  <guibomacdev@gmail.com>  [97c0797cf379cca6056b8ab34499b56c7f01fd9b]

        Revert "tdf#163945 present drawable immediately"
        
        This reverts commit 32eb29377c5bbf6a965357756d2813add2789053.
        
        Reason for revert: Original commit did not fix tdf#163945
        
        Change-Id: Ie66edde40ed44f89bb28043db074fab7e6e06a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177025
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [026e52441be266a3cbe9e2e19d9ff0c4c568542b]

        sw: no need to pass a bool as a reference
        
        Change-Id: I62aabd66d368856959be032d866888b82b018dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177018
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a57d16d5243cc8b89f0ba9f345bda15685d9f6b5]

        PVS: V1048 The 'bTestAllowed' variable was assigned the same value.
        
        Change-Id: I8322b68ce93adedbcb5ae2462b5ed1868d3552db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177013
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e85d48c90ec647665be7eb8e76a98ec3feadd5ce]

        Fix typos
        
        Change-Id: I49cf90c401243c9606372735ad160f5f2b63b603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177026
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-22  Julien Nabet  <serval2412@yahoo.fr>  [b86368d712a67df4adb35011bf52286d9bd03724]

        tdf#163486: PVS V1043 global object variable is declared in header (sw)
        
        Change-Id: I7d8375e822dabcceeaf25eaf4ba1f29ce7494337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176996
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-22  Julien Nabet  <serval2412@yahoo.fr>  [de7e10f9dd823d3be8cb5a9f960c6b5a43e671f2]

        tdf#163486: PVS V1043 global object variable is declared in header (sc)
        
        Change-Id: Ie328b5120bc879702db351555c9db5d6b661be41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176990
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-22  Julien Nabet  <serval2412@yahoo.fr>  [2fa20173229c35de5432a7ad60a9c7e942aac37e]

        tdf#163486: PVS V1043 global object variable is declared in header (include/)
        
        Change-Id: If6a656f47cb88dd218af660def31ece572a3b8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176989
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [816b51c7a9cdd72eaa01f3c074ba5a8446917d19]

        PVS: V547 Expression 'bNoDictionaryAvailable' is always false
        
        Since
        commit a50a2bf8e8c6084aeacb8d2db42e21f528410742
        Author: Szymon Kłos <szymon.klos@collabora.com>
        Date:   Thu Jan 24 11:22:22 2019 +0100
        
            tdf#86731 Don't show 'start from beginning' when dictionary is missing
        
        Change-Id: Ib71051ddbb3318c74fb5020ec27560f1c6f73893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177017
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [2bcaafd4a25e4875ab08114f5a8d198ad3a35212]

        PVS: V1048 The 'nConcurrency' variable was assigned the same value.
        
        Change-Id: I5819652b2f5ab491b7412e6cb4d0159f640297bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177012
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [53872d4eee780dce8072800eb333c618ece37c32]

        PVS: V547 Expression '!aHandlePropVec.empty()' is always true.
        
        Change-Id: I1eaf7fbb481f061948d65e9b7e855d9a9261e3ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177001
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [bf2c6653164073c542fd04e19a5f3dd7f934078a]

        CppunitTest_sd_tiledrendering: factor out common code
        
        Change-Id: I8ba7871cd3ca7580230c31dedf468aaa8219241a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176915
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [568fcd66c53ec9fc5fa2ef8060a10085d48c36c8]

        PVS: V560 A part of conditional expression is always true:
        
        !rPolyPolygon.empty().
        
        Change-Id: I61b79d0995cc08b70c2a39bdeb043a22722313e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177000
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ab81e7c44001ad86461673719cf1ac22f8932c5]

        PVS: V547 Expression '!aPropertyStates.empty()' is always true.
        
        Change-Id: Id71d10060c79d36095bbd952b89aa6af68a29a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176999
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f2cf4d91687fcebcad90a839dd5232a28b47e6e1]

        crashtesting: invalid iterator on load of forum-de-1233.odt docx export
        
        although the actual order doesn't change there is a Delete/Insert of
        the object in case the order should change.
        
        ::Insert will check if sorted and resort if not anyway, so presumably
        if we just skip the middle-men and resort here if we need to then that
        is equivalent, but without the invalidation for the already sorted case.
        
         #0  SwSortedObjs::Remove (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:243
         #1  0x00007fffce0af130 in SwSortedObjs::Update (this=0x510ed40, _rAnchoredObj=...) at core/sw/source/core/layout/sortedobjs.cxx:282
         #2  0x00007fffcdf32c40 in SwAnchoredObject::UpdateObjInSortedList (this=0x51123c0) at core/sw/source/core/layout/anchoredobject.cxx:661
         #3  0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859
         #4  0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x5112260, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112
         #5  0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311
         #6  0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316
         #7  0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302
         #8  0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e68da0, rHint=...) at core/sw/source/core/attr/format.cxx:300
         #9  0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e68da0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843
         #10 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325
         #11 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e68da0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e68e68 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...})
             at core/sw/source/core/attr/format.cxx:597
         #12 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x5e47b90, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...))
             at core/sw/source/core/unocore/unoframe.cxx:1867
         #13 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dce770, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0)
             at core/sw/source/core/doc/textboxhelper.cxx:995
         #14 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e69dd0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757
         #15 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:575
         #16 0x00007fffcdf31eaa in SwAnchoredObject::InvalidateObjPosForConsiderWrapInfluence (this=0x4e69dd0) at core/sw/source/core/layout/anchoredobject.cxx:400
         #17 0x00007fffcdf32be5 in SwAnchoredObject::UpdateObjInSortedList (this=0x510e530) at core/sw/source/core/layout/anchoredobject.cxx:654
         #18 0x00007fffcdf8fc38 in SwFlyFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/fly.cxx:859
         #19 0x00007fffcdf9d1bf in SwFlyAtContentFrame::SwClientNotify (this=0x510e3d0, rMod=..., rHint=...) at core/sw/source/core/layout/flycnt.cxx:112
         #20 0x00007fffcd65bca8 in SwModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:311
         #21 0x00007fffcd65bd71 in sw::BroadcastingModify::CallSwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:316
         #22 0x00007fffcd65b42f in SwModify::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/calbck.cxx:302
         #23 0x00007fffcd66771b in SwFormat::SwClientNotify (this=0x4e364a0, rHint=...) at core/sw/source/core/attr/format.cxx:300
         #24 0x00007fffcdf4448a in SwFrameFormat::SwClientNotify (this=0x4e364a0, rMod=..., rHint=...) at core/sw/source/core/layout/atrfrm.cxx:2843
         #25 0x00007fffcd65be1e in sw::ClientNotifyAttrChg (rModify=..., aSet=..., aOld=..., aNew=...) at core/sw/source/core/attr/calbck.cxx:325
         #26 0x00007fffcd66948e in SwFormat::SetFormatAttr (this=0x4e364a0, rSet=SfxItemSet of pool 0x1bcebe0 with parent 0x4e36568 and Which ranges: [(88, 141), (159, 159), (1014, 1034)] = {...})
             at core/sw/source/core/attr/format.cxx:597
         #27 0x00007fffce649a2c in SwXFrame::setPropertyValue (this=0x4a86e10, rPropertyName="Size", _rValue=uno::Any("com.sun.star.awt.Size": ...))
             at core/sw/source/core/unocore/unoframe.cxx:1867
         #28 0x00007fffcdc4d7ea in SwTextBoxHelper::syncProperty (pShape=0x4dc65f0, nWID=89, nMemberID=0 '\000', rValue=uno::Any("com.sun.star.awt.Size": ...), pObj=0x0)
             at core/sw/source/core/doc/textboxhelper.cxx:995
         #29 0x00007fffcdf2e2d7 in SwAnchoredDrawObject::GetObjBoundRect (this=0x4e3a0d0) at core/sw/source/core/layout/anchoreddrawobject.cxx:757
         #30 0x00007fffcdf320ca in SwAnchoredObject::GetObjRectWithSpaces (this=0x4e3a0d0) at core/sw/source/core/layout/anchoredobject.cxx:575
         #31 0x00007fffcdf815b3 in (anonymous namespace)::IsNextContentFullPage (rThis=...) at core/sw/source/core/layout/flowfrm.cxx:217
         #32 0x00007fffcdf81002 in SwFlowFrame::IsKeep (this=0x4e5a630, rKeep=..., rBreak=..., bCheckIfLastRowShouldKeep=false) at core/sw/source/core/layout/flowfrm.cxx:259
        
        Change-Id: If2191e8b99d1b0347bab54a704013ce0a9a19410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1329b4fa5428c00ccbb201dc3a08880b0ed09573]

        PVS: V560 A part of conditional expression is always true
        
        !aTempContentText.empty().
        
        Change-Id: If61fc09e7e19786ee055b78442b69f0147c8da75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176998
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [51ca3c42adfa565b7658cf543ec9c27c5c349242]

        PVS: V547 Expression 'aUnoArgs.empty()' is always false
        
        Change-Id: I9283b59499fe7739f06d926357218ef7eb916a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176997
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [17e7743d5fa5de8ddecad5bb35bf2ad644ded2b3]

        sd: add CppunitTest_sd_lokit_search
        
        Change-Id: If4844f3f9a40495f3ceaf2603de5211b9f1555cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176972
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [e0a5ad2f8d45a1a7b552414bf0e16d3f5cb9ef02]

        LOKitSearchTest.cxx: use CPPUNIT_TEST_FIXTURE()
        
        Change-Id: I11af98e069be3a8b5ec88a55024bb767e6b2c543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176991
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2088e585b6f7da1092fdede73d263854a01929d8]

        pdf: move stream/string encryption into PDFEncryptor
        
        Change-Id: Ie710e51faa7d65686d72a03d1ef4ca40dff8c27e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176889
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b1ce30df8b15de984209154df7f2710930fa8a9e]

        pdf: add initial test for PDF 2.0 (check using PDFium)
        
        Change-Id: I43e6048d34ee9c51e0602cd671a73b19145a9c17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176888
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a3aa8acfede5adaaf5f8b783e826bac961a0f8e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 143fba581c7499e9e36971e52e18bada4a262be1
          - Revisit Writer Navigator Help page.
            
            Change-Id: I1bdc2fe094bcc3d75d5e1442af458f018ee60f81
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176973
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [05565fc05798535e1771e97105e5fde660f2d1dd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6f1acf9c43c6d2de0de9d8d3e3fad2c849f1278
          - Mute L10n on <embedvar>
            
            Change-Id: I268936d73e67b2108f92f1fa2bb2dbcb28955277
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176975
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [eecd78825061fb1ad51528b44cae96e559e88da8]

        ReqIF: avoid 'type' attribute in 'ul' elements
        
        Change-Id: I028737cac0b89344be5df55f9b60046230603979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176987
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-22  Julien Nabet  <serval2412@yahoo.fr>  [cbc5fd0df45c88aaca32a283c67d38cbdf286da6]

        tdf#163486: PVS V1043 global object variable is declared in header (svddef.hxx)
        
        Change-Id: If11d609ccf6bdaadfec6b3844e08589cb289aec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176971
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c06de26c4b83edad29a70a454dea20dcd0261a33]

        tsan: make oslPipe thread-safe
        
        add a mutex around accesses of the internal data structures of
        oslPipeImpl, to prevent data-races
        
        Change-Id: Ia39961c0a3df0a5a5db31cc515d248d013998255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176931
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [35f07a51850aeede7ef92dc2a2eae2326cff06a1]

        tdf#148161 - Remove redundant attributes from configuration schema XML files
        
        Change-Id: I25b6dd6868ac8f24155d4c2d45333ef47557c9c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176950
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [626c184f77e77227217a23694176f950b80b7c44]

        crypto: add AES256 test, document Encrypt, Hash conv. function
        
        This adds AES256 test of encryption and decryption - an example
        on how the Encrypt and Decrypt classes are used.
        
        Also add a convenience function for Hash, accepting vector of
        bytes as this is used in a lot of places.
        
        Change-Id: I9b395c7afb8fac45cae8d7d8bd983f5daaafd64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176887
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [68de311b3bafca98e6def64cf3dccf45acd2ba6a]

        pdf: wrap more encryption specific code into PDFEncryptor
        
        To make the code contained, so it is easier to add the new
        encryption method later.
        
        Change-Id: Ie3e3194c2148f6c3cb8ac58709fcd5f74e84a93a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176886
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-22  zdavis  <zdavis@csumb.edu>  [b61ae38fe4794e0e0ae8fd067b19d1f33dc75fda]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ic6796c91318bc838804ec30790f52480734e9b7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176615
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-22  Justin Luth  <justin.luth@collabora.com>  [0d3748e5fbfb2ac8dd60d491d566075938927237]

        tdf#163598 editeng: avoid using fake outline depth
        
        Most implementations do not actually
        do anything meaningful with Get/SetDepth,
        so don't exception or accept their values.
        
        To fix the bug, I could have just checked for
        dynamic_cast<SvxEditEngineForwarder*>
        (since it supports EE_PARA_OUTLLEVEL directly)
        but this way seemed more encompassing.
        
        The potential downside is that EE_PARA_OUTLLEVEL
        will be requested as a real property
        after GetPropertyValueHelper
        with some of these dummy providers,
        and who knows what UNO might do about that...
        
        IF this patch causes problems,
        then I need to implement Get/SetDepth
        in SvxEditEngineForwarder
        (or consider the dummy providers as SupportsOutlineDepth).
        
        Change-Id: I74bf5e39a13bb1d588c39634347eb0982bda66b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176981
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [d3613d15e518c0c8cc4930c4bdf37219813fd665]

        notebookbar: Simplify logic to detect whether hidden children
        
        The actual number of hidden children is not of interest here,
        only whether there is at least one, so stop iterating once
        the first hidden child is encountered.
        
        Change-Id: Ice1a7461d2bfd9d576109771cf93deb6a17ef975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176930
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [de426177dcf08925b0a12b437ceb4d0a1eae006e]

        notebookbar: Drop PriorityHBox::GetHiddenCount
        
        The method is only used in the PriorityMergedHBox
        subclass, which overrides the method anyway,
        so drop the base class implementation.
        
        Change-Id: If2c11377b1ca0ac0f3c6cd4fec9890cdcbbce0ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176929
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [d723ef639216c0e8e2b82f99bcf2eaf3d6a19c90]

        notebookbar: Drop unnecessary static_cast
        
        Change-Id: If7aa91609409d3ad499a55348545d49d136d6606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176928
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [59cba4298dae0caf0f1ba72a830d8f4edf48756d]

        notebookbar: Pass menu button as parent for its menu
        
        Use the Notebookbar menu button as parent for its
        menu. This also makes the button position be used
        as the reference.
        
        This allows to drop the now unused
        NotebookbarTabControlBase::GetHeaderHeight.
        
        Also, set the reference point to be at the bottom
        of the button, so the menu opens below it instead
        of approximately in the middle, which matches
        how other menu buttons behave.
        
        To test: Set "Tabbed" for the UI variant in
        "View" -> "User Interface", then click the
        "Hamburger menu" button in the notebookbar.
        
        Change-Id: I0717fad73ff7a42d2bdaaa53a73d055234003d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176927
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [11e857374fb44a1a24fb07948e3ee300f09b6a11]

        vcl: Simplify NotebookbarTabControlBase::ImplActivateTabPage a bit
        
        Only set new value for nCurPos if there's a valid
        new page instead of always doing it and then
        reverting back to the old value.
        
        Change-Id: I25f56e34da6260ee7c586fa25a88ff813f7c26f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176926
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [08c315e7b7a2198b36f956245453fad13f1ac6cc]

        vcl: Don't use out param in addition to return value
        
        Let lcl_isValidPage simply return whether the
        tab item is "valid" and don't set the out
        param in addition, but let the callers do
        that, which is more straightforward.
        
        Change-Id: I35000d46899f457087c417e91ee1968aab7bd239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176925
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6ca76f3e6fbb19ef4982b0c178879645e7f72c00]

        Related: tdf#160536 - ooxml import export correctly cell protection
        
        property for Pivot tables cells.
        
        Change-Id: I1bff7a27cf169fd0876e361b22b4d7017f190b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176897
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b2e60fb56e8f8f0b99fdaf3162034db19a80fd7b]

        ofz#380107559 fods2xlsfuzzer Null-dereference READ
        
        in SvXMLStylesContext::FindStyleChildContext
        
        Change-Id: I384e8e36bc23b7d84b7ccda34e1ee29109e5f708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1fbc7faa91181ae8ac240dfe8db704673c44a14d]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: Iced153f4258e2f27007cfbb7a63b78db7f6985dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176962
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c5bf76720fc4f0962b47b702970d6d31c2905407]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I5c109872713b51cde54ad4617627e72070163601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176783
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d4425ae2f4cf8a18a43bb54ed4228d75665516de]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I94ef2c1465698dca75925845be0a4b4cdd9f40d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176959
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-21  Julien Nabet  <serval2412@yahoo.fr>  [a88a4f49dd2ff21e477530fce93ef89c69b01278]

        tdf#163486: PVS V1043 global object variable is declared in header (eeitem.hxx)
        
        Change-Id: I6d3445671f0a086a800c1239e105e7732c652eb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176953
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [37a92f526ab48bc85171a17f303c642753f2f5c1]

        postgresql: upgrade to 14.15
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.15/postgresql-14.15.tar.bz2
        
        Change-Id: I1dc53ff2cf487f36d0611913f59917c5c0097690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176940
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Julien Nabet  <serval2412@yahoo.fr>  [89884a63e1f45f83fe2b95c4b56345cc0906f996]

        tdf#163486: PVS V1043 global object variable is declared in header (chart2)
        
        Change-Id: I553e7ed4782341fa0a2e8e7d444f158bc18d770e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176943
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6e8ca63a61e3314e91a9b20cf371dd76969bc669]

        tdf#153600 Extended tips for Style General page
        
        Change-Id: I05ab2620aac82c07613ac01ec7cb57031e5a9eab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176805
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-11-21  Jim Raykowski  <raykowj@gmail.com>  [19c61f4dc34c751235fadcba0d79c2c4da129c5c]

        Resolves tdf#163971 - Unexpected sidebar opening in Math
        
        with Alt+2/3/4 shortcuts
        
        Change-Id: I0acb8fd2fc1b570a4cab3b3a6950a8e6294be316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176895
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-11-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [166dd64751616ee148c6a45796da9869525c59d4]

        Fix typos
        
        Change-Id: I98f88e799a9a5128677f26e0c740c0764ffc8d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176934
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-21  Julien Nabet  <serval2412@yahoo.fr>  [3d7991d3f1c7c43bea404a7027e1dee92c1b1cf4]

        tdf#163486: PVS V1043 global object variable is declared in header (xdef.hxx)
        
        ...Multiple copies of it will be created in all translation units that include this header file.
        
        Change-Id: Ie63ed8b12c5579e0ff5cb77e4709eb4526c1e7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176924
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [510467f5b2b9b9dc5ba0cd24b446dcd2c2e32acf]

        tdf#163486: PVS: variable was assigned the same value
        
        Since
        commit 1a1e953ee33c213dc8b88dd96a69ca9fc5e42d50
        Author: Gökçen Eraslan <gokcen.eraslan@gmail.com>
        Date:   Mon Jul 9 13:53:38 2012 +0300
        
            We use hidden signatures for now.
        
        V1048 	The 'sigHidden' variable was assigned the same value.
        
        Change-Id: If394032db0cc848864a640e45a0492eee28b5205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176917
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Patrick Luby  <guibmacdev@gmail.com>  [32eb29377c5bbf6a965357756d2813add2789053]

        tdf#163945 present drawable immediately
        
        It seems that -[MTLCommandBuffer presentDrawable:] doesn't
        immediately replace the previous drawable on screen so I
        assume that there is some default minimum display time for
        drawables.
        
        LibreOffice only invokes this method in a timer so let
        LibreOffice control the rate of window updates by presenting
        the drawable right now.
        
        Change-Id: Ibd8d72bd6ea0303f9582264791cc4356bda62c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176879
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-11-21  Michael Stahl  <michael.stahl@allotropia.de>  [fbfbd2f51ebc5ab239d06ded7931214b1c84a5fd]

        sw: fix hiding/unhiding section via condition
        
        The problem was that when un-hiding a section, table rows that contained
        only empty paragraphs were not reformatted and remained at height 0.
        
        It turns out that the table row that became visible did so because the
        cells had a VertOrientation different from NONE and so
        SwContentNotify::ImplDestroy() invalidated the cells' printarea.
        
        However, the real problem isn't in the layout code at all, as it then
        turns out that the reason why anything is reformatted at all is that
        there are docinfo fields on the same page as the section and also in the
        paragraphs at the start of the section, and these get invalidated
        somehow after unhiding the section.
        
        Unhiding the section didn't actually invalidate anything in the layout
        because in ImplSetHiddenFlag() no change is detected, and that is
        because the section was first hidden by removing its (false) condition,
        which calls SwSection::SetSectionData() and that didn't call
        ImplSetHiddenFlag(), again relying on docinfo field update to trigger
        the relayouting.
        
        Change-Id: Ie5d9e4d5a0467c17c662f20f8d54aa6b22b382da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176914
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-21  Michael Stahl  <michael.stahl@allotropia.de>  [483a3db5204f36798811da8c36641be03104be63]

        sw: layout: fix unhiding section containing multiple page breaks
        
        With multiple page breaks in a hidden section, the following frames were
        only moved on the first break, and with the second break the frames go
        out of order in SwSectionFrame::SwClientNotify().
        
        Also handle multiple columns there.
        
        (regression from commit a97e245ba11598050e1800fde9ace796d20e9df2)
        
        Change-Id: I4120e72bf083f3bed75f9305fbd757efd55f0b3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176773
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [08143bf192a885e1adbde061bb7d68bc5c559e03]

        no longer need this svtools/drawinglayer hack
        
        after
            commit 664ecbd8916478cdc28a9c793fbdb9359b3cac64
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Wed Nov 20 16:08:14 2024 +0200
            remove OutDevSupportType::TransparentRect
        
        Change-Id: I57804ec9e9967c7082a1f657165d967d75b1dedf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176910
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [d22d862ce6abd28a5859571b465459489da430d8]

        tdf#163486: PVS: Expression is always true
        
        Since
        commit 47a173edb603538521a035157efb6ef684238087
        Author: Noel Grandin <noelgrandin@gmail.com>
        Date:   Sat Sep 15 18:36:08 2018 +0200
        
            use std::vector in PDFWriterImpl for encryption buffer
        
        V547 	Expression 'buffOK' is always true.
        
        Change-Id: I66b0f4de18cfca398da0b4091d980b259f5e9dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176916
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ebcea990c725752d40ff9e0de5f5eaa321f25d1]

        call PathSettings::initialize after utl::Bootstrap::reloadData
        
        and add setting 'BRAND_BASE_DIR' alongside existing 'UserInstallation'
        which necessitates moving this block after aAppPath is determined
        
        Done so that PathSettings will use the new locations set in bootstrap
        for UserInstallation directory and not the locations detected during
        preinit.
        
        So autotext can be found relative to the final UserInstallation dir.
        
        Change-Id: Ib6dadbec85a380475537027a8ce3972e31089711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175960
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176905
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Noel Grandin  <noelgrandin@gmail.com>  [75799dae6e85c1af047ae7051702b7913e2c0f28]

        use default implementation for drawEPS
        
        so only the one that implements it needs to override it
        
        Change-Id: I19e79c5746dbbebbf5914922587016fd03a902d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176848
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a44a406de423b3d69183cc2e23f1e5f121518fab]

        Make rendering more flexible, render fields in separate layer
        
        If the amster page has a field (like slide number) then render the
        objects containing fields into a separate master slide layer.
        
        Also change the rendering in such a way to be more flexible and
        has less conditions. So in the renderer it doesn't really matter
        if we are rendering a master slide or slide, what matters only is
        if the object is already rendered and if we need to stop rendering
        for some specified reason (like we encountered a field and need to
        stop rendering and need to switch to a new layer).
        
        Change-Id: I37ea2528427bbc1b3de938f960fb344866ee9399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176911
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-21  Mike Kaganski  <mike.kaganski@collabora.com>  [512ef23224987e3107e66241db3b42934e15a561]

        tdf#163974: ignore nested footnotes on ODF import
        
        That is a valid, but unsupported, markup, that is explicitly mentioned
        in ODF 1.4 part 3 "Schema" sect. 6.3.4 "<text:note-body>":
        
          Note: The schema allows for the inclusion of <text:note> elements as
          a descendant of a child of the <text:note-body> element. While this
          may be reasonable for note types, it is not reasonable for footnotes
          and endnotes. Conforming consumers need not support notes inside notes.
        
        (The "reasonable for note types" is obviously an editorial error from the time when ODF 1.1 text "reasonable for some future note types"
        was reviewed for ODF 1.2.)
        
        As the ODF also specifies, that a conforming consumer "need not
        interpret the semantics of all elements, attributes and attribute values"
        (ibid., sect. 2.4 "Consumer"), it is OK to silently drop this data, just
        as done for other similar cases.
        
        Change-Id: I0a417981087ebf225565628f14409661058d100d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176906
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-21  Andras Timar  <andras.timar@collabora.com>  [a1a21ca3d4a8c36620fcb2e2af0b6ddd300f6739]

        docx: export empty GrabBag elements as self-closing xml tags - 2
        
        In 6cb711645b8d8f3cee0d3454e193cc7bf1cad305 the condition was not
        good, because there is a special element called "attributes" which
        is not a child element but contains attributes of the current element.
        In the condition we should check for 0 elements that are not
        "attributes".
        
        Change-Id: I1d6995e13f288902c1cce85ac3b7d4e0da213df8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176900
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb362d3b4a09f612e27036d5f994479c4fa808c3]

        add XInitialization to PathSettings
        
        so PathSettings could be reinitialized if the underlying assumptions it
        made on initialization have changed, like the location where the
        application is installed, which affects the "Internal" paths for e.g.
        AutoText which are RO paths that aren't normall allowed to change.
        
        Change-Id: I3e056ddfbfdc3257561bd67c39163b48d3dde9a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175951
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176904
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e8fca750c4a8b2ac99c4f47b65d31a4f58ad43f9]

        Related: cid#1634864 can use member list initialization here
        
        Change-Id: I39c56e381fda147b5dac885f95e93648c366225d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176901
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Michael Stahl  <michael.stahl@allotropia.de>  [e8c59414016a2f28ab9e15002e2c36b5a714924e]

        sw: layout: fix crash in SwSectionFrame::MakeAll()
        
        sectfrm.cxx:854: Assertion `moveBackPos == &GetPrecede()->GetFrame()' failed.
        
        Because the section has columns, and GetPrevSctLeaf() apparently returns
        the body frame in a column.
        
        (regression from commit c60ad7e0fbf3cc86af167f5e98b38c25620ada7e)
        
        Change-Id: I16fcd7a42b24e54873cde0aa0087c7aa56b0a8e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176738
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73cb99d5ea12b76c6cfbc498c58c4ed133b94c5e]

        Related: cid#1364016 Missing move assignment operator
        
        Change-Id: I186718f4e74ca3a77d92a62358d6007a1f6fd7fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176903
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b16fd7e9be7a61a0acb1c134cc55fa3f66655c8]

        cid#1634867 Using a moved object
        
        since:
        
        commit 193207c5abf339253e15b59f398da0c1f6f43bee
        CommitDate: Tue Nov 19 07:46:25 2024 +0100
        
            improve loplugin passparamsbyref
        
        Change-Id: Ib2dfa03dfe66630ddb902ea4e75338ca70857e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176899
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [60ca9c8fd48225069ed6c9c0cbcada4717999724]

        CppunitTest_sd_tiledrendering2: move to tiledrendering folder
        
        In preparation for a follow-up commit
        
        Change-Id: Ifb3ee72cef3493cb1774c0a0c5ac6b5850309396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176878
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5cd7e18483b6d56ae836b02107063a657745134a]

        cid#1634865 Uninitialized scalar field
        
        since:
        
        commit 43b9ab55a3b6ac1497bcadd6a71a5a133ece4d3d
        CommitDate: Tue Nov 19 01:15:00 2024 +0100
        
            tdf#163956 calculate line height differently in FORMTEXT
        
        Change-Id: Ic0e6e78f77b1adf6f5ca9fe7a48e113bd8592552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0b7faed2818971d46122da16322691e3c836c0e6]

        Latest VS 2022 Preview is 17.13.0 Preview 1.0 now
        
        ...while latest proper VS 2022 is 17.12.1
        
        Change-Id: I93ebd2756e665f5f33ba71934ab625709c3758db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176893
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c585cd975e8566a952651670a1e6b1865c22114]

        CppunitTest_sc_tiledrendering: factor out common code
        
        Change-Id: If9f3ff5d9699876290fb643ed14ba64108cd191c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176877
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [4d41da669d443ecaffb344964a272630ccdca634]

        CppunitTest_sc_tiledrendering2: move to tiledrendering folder
        
        In preparation for a follow-up commit
        
        Change-Id: I8e7852b1861d6879e0dcda8c6fddd947bec3c959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176876
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae2009b9cc4a1097b1583b70a965d8f3ede5e713]

        tdf#163486: PVS: variable is assigned values twice successively
        
        Since
        commit d0cacf09a1105d89bf3df84b18623d790e3aeb82
        Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Date:   Wed Apr 27 11:45:04 2022 +0200
        
            tdf#99708 Save formula bar height to document
        
        V519 	The 'pSettings[14].Name' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 3806, 3816.
        
        Change-Id: I7afcee42d10d692c2c9a84b6a6f0a97ceb913081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176761
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-11-21  Noel Grandin  <noelgrandin@gmail.com>  [664ecbd8916478cdc28a9c793fbdb9359b3cac64]

        remove OutDevSupportType::TransparentRect
        
        all our backends support transparency, and have some time, XRender
        support became mandatory a couple of years ago.
        
        Change-Id: Ie2db7e4665068fe88a926e9791d74a82c2e75834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176852
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7606a6039aa4aebbb7b8be7abc8495d9c1db2065]

        Missing test dependencies
        
        Change-Id: I554ca1edd014f91433a948302762bcd7a3ed64bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176870
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-21  Martin Srebotnjak  <miles@filmsi.net>  [8eebf99ec64761fb0461dced4aeef23c9e1824d0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 8f5f1e8348d605be128fcfa742e6fb92d52e758f
          - Updated Slovenian translation
            
            Change-Id: I5502cef3a456758e12170ad6d95a39b152cf63f1
            
2024-11-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [e2f81814dd51bcbb49395f682a7e9677056fb4bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4eb5edf36d5bfa7f1dc90c09623086ade07b97b5
          - ghost ref to OO.o
            
            Change-Id: I92d95d09dea69f9482a9a49ed6a380da017ce749
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176820
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-11-21  Justin Luth  <justin.luth@collabora.com>  [1bc4835bd00d12bee93671a01423f4646f4622f0]

        tdf#163872 ScTable::SetOptimalHeight: optimize if all rows ManualSize
        
        SetOptimalHeightsToRows does nothing
        if all the rows are manualsize.
        GetOptimalHeightsInColumn can be extremely expensive to run,
        so exit early if all the processing will have been for nothing.
        
        This doesn't solve bug 163872,
        but it does help with some of the sheets.
        
        Change-Id: I425bbd4f181058aa637c92f2abccf7c27dcf607d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3959d5bddafb61bcd50613d6c6453a2d6fe370b7]

        Fix typo
        
        Change-Id: I8c8e5c3e6c4e0a8a7f41943ac8c014e1175e093a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176871
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ebce1088ce97587fe358eb76e21979b62881a4ee]

        Fix typo
        
        Change-Id: I4520061338adfcb13d2eece2f59fb8331c7dbf8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176874
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b3c93feae131dd7fe812e5d754fbcd96b85d262d]

        Fix typo
        
        Change-Id: If765fa2c6e7df36dd5d62b351898b61ac263a6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176872
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-20  Oliver Specht  <oliver.specht@cib.de>  [1ed564ecb73f2cab3a921a5bde67b9db48ea04a3]

        tdf#163967 RTF: Pasting/loading hyperlink imports font color and underline
        
        Hyperlinks are typically colored and underlined. The RTF import
        - also used when pasting from clipbard - now evaluates font color
        and underline in the field result.
        
        Change-Id: I725fc3e94746c96d68379c021fb0c12cd3750096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176714
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-20  Michael Weghorn  <m.weghorn@posteo.de>  [2bb92e0a9da148df662bc697eeb835cc1161544a]

        gtk3 a11y: Use OString literals
        
        Change-Id: I23365943e79847e3c7162808de3dc176f7db2b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176804
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [a7ec9431083cf5dde8a86e59b9af203f3d35073d]

        CppunitTest_sw_tiledrendering: factor out common code
        
        Change-Id: Icc8958f9f86844149bc66d12d60111bdcac0f8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176867
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [e3de36ececcc032a264c3249988a8f7b2916039f]

        CppunitTest_sw_tiledrendering2: move to tiledrendering folder
        
        In preparation for a follow-up commit
        
        Change-Id: Id790d14ccbbb17f4ca086c67a702e199397d272b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176864
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-20  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [4b0b65f7605f1291fedc77ac850afed8e39dfcd8]

        starmath: Use field color for SmEditTextWindow background
        
        With same reasoning as
        
        commit 8bb38e1b3f1ba1d9c563598d161230fdf27e4685
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Mon Oct 14 12:22:32 2024 +0200
        
            tdf#163397 svx: Use field color for WeldEditView bg
        
        Change-Id: Iac0c6b934946b6755ce53ac312c1e637678f966d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176856
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-20  Jonathan Clark  <jonathan@libreoffice.org>  [235aebe31e6ba32a7ffc6a960396f651bdaa6ae3]

        tdf#91315 Implemented RTL support for SVG export
        
        Previously, the direction attribute was not set on text tags when
        exporting RTL text to SVG. This change adds the missing attribute.
        
        Change-Id: I57770c1cc44f10c3c43ccac2f5a17c1422c34d35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176869
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [755b28d019db62d29ef36535a501809912182960]

        Catch exceptions thrown when notifying individual listeners
        
        Any such exceptions were already caught further up the stack (by
        SfxBaseModel::postEvent_Impl), but prevented later listeners from being notified
        as soon as one listener threw an exception (which I saw happen with some
        3rd-party extension).
        
        Change-Id: Ia6bd1c73d29ab6d6e131652df51939ba0c0e988e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176854
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [e8a7423baabd53c8e9f9dcdac687cdbd2aa44ec0]

        CppunitTest_sw_htmlexport: split in two
        
        It already had 114 tests
        
        Change-Id: I16bddb42364c542fb2b5e115672096984b29e975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176847
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-20  Heiko Tietze  <tietze.heiko@gmail.com>  [f40dc496a511ae06a308dd0859bc3aad28a8ec7e]

        Resolves tdf#163856 - Disentangle boundaries options
        
        * Boundary toggles removed from app colors
        * Object boundaries completely removed (color replaced with
          DOCBOUNDARIES; Impress placeholder on/off now an expert option)
        * Toggle options added under formatting aids
        * Individual UNO commands marked deprecated
        * New command added to show all boundaries
        * Frames follow sections now in state and color
        * Kind of wrapping doesn't matter anmymore
        
        Change-Id: I7bbec20831dcb95abef6523884d84b05a1a7df0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176242
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-11-20  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [c635271eb17e3b9d50223356dbc09b771fcd643f]

        tdf#163428 CairoSDPR: Fix regression in freeing unified buffers
        
        I had added BufferedData_ModifiedBitmapEx for CairoSDPR (but
        not only) to allow Bitmaps modualted by BColorModifierStack
        to be buffered in the standard way and at the original
        Bitmap. This nicely can still hold the system-dependent form
        of the Bitmap to be used at the Bitmap of that buffered
        modified Bitmap.
        This uses something I was not aware of: One Buffer implementation
        may - as in this case - use another buffer. That may lead to the
        second buffer being deleted/freed when the first one gets freed
        - by timer or directly - what is wanted. This *needs* the methods
        inside SystemDependentDataBuffer to do the actual potential
        destruction of the Object outside the Mutex-Locked parts of
        the code, else this might lead to a deadlock.
        It is good to have found this, there may be other such
        combinations in the future: That the implementation of a buffer
        using that standard mechanism uses another class that may also be
        buffered.
        I have now made sure that buffered objects get deleted *outside*
        the Mutex-Locked areas. This is better anyways, the destruction
        does not need that lock - it is just needed so secure the
        manipulation of the local unordered_map that organizes the
        buffered elements globally.
        
        Change-Id: Ie2f346a3f1a24105b89310ace3ff7a41472143c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176795
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>

2024-11-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [278a05e0b627cc7d8abb47facb9d1289b006bdf4]

        WARN about swallowed exceptions
        
        Change-Id: I2d6aef0dfa8bd8c002fd172b13363e629bc9cc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ff4baa0770832cb7ffaac121dccd796669f7776c]

        Use notifyEach
        
        ...as had already been done prior to 8122c82d90117fc0c4c8ea87aa7f771d5e92bf36
        "osl::Mutex->std::mutex in SfxGlobalEvents_Impl"
        
        Change-Id: Ia74c07a3458d7a5af428b68d1728cc9e51aa42a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176853
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1a949fceae16913b29efae713b5890398c69ffac]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1209, 1218
        
        Change-Id: I9f2fe51a0b7d4514ff6a82d24be940ed50d39e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175221
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [db7152d2cabcfb0279cf3bd6947c321a6cb9448d]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Ibd3f95a7af4df51aee5fd1974914aa808dded229
        V1037: Two or more case-branches perform the same actions. Check lines: 666, 688. Similar cases are grouped closer.
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175051
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-20  Michael Weghorn  <m.weghorn@posteo.de>  [bf0c4166478c6e124bb4969e16444c8f478b8989]

        gtk: Switch param from const char* to const OString&
        
        Change-Id: Ie92591770a2828a5f828d76d8c1bf7e5a253c3de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176814
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-20  Michael Weghorn  <m.weghorn@posteo.de>  [a560f22c79c18df57b2e905fb7ff01e6ee2b5593]

        gtk: Let GetCommandForItem return OString instead of char*
        
        This simplifies memory management, as it removes the
        need to manually free the memory using `g_free` again.
        
        Change-Id: I71f8e6a8df46c0090f2f003d3f443500028b1f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176813
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [343232190f1bafd608c574ac85ec27b4f404b79a]

        use bNewFontLists of true to refetch new font lists
        
        which becomes more obviously required since:
        
        commit d85cb3832286ae1fdcf4a8494abb8212f21e4e9a
        CommitDate: Fri Feb 2 22:47:28 2024 +0100
        
            preload: open and close empty documents of main types in preinit.
        
        because since then SdModule has called GetVirtualRefDevice to create the
        long-life virtual device that is used to set the lists of available
        fonts before "addfonts" has been called to add extra fonts to the kit
        so impress/draw remains unaware of any changes there.
        
        It was actually "true" here before:
        
        commit ab612633003c75dfb30664db8cc8924c086a91ee
        CommitDate: Wed Apr 13 20:09:54 2022 +0200
        
            Follow-up fix to Collabora Online "addfont" handling: avoid assertion failure
        
        but its uncertain what assertion is referred to here, perhaps the same
        assertion as later fixed by:
        
        commit d1ed24ba34d422128fd48184dbc3b344b5922d3a
        CommitDate: Wed Oct 2 16:19:47 2024 +0200
        
            Get SolarMutex before calling ImplClearAllFontData
        
        Change-Id: Ibc81191ba3b88d9b4def90b6d9662a83295ec9cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176032
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-20  Bayram Çiçek  <bayram.cicek@collabora.com>  [57d123745a6e07da2a9893540e42b72e55641a59]

        sc: autofill: send to-be-deleted cell addresses
        
        with LOK_CALLBACK_TOOLTIP
        
        also avoid nullptr ViewShells:
        
        -        if (comphelper::LibreOfficeKit::isActive())
        +        if (ScTabViewShell* pLOKViewShell
        +            = comphelper::LibreOfficeKit::isActive() ? aViewData.GetViewShell() : nullptr)
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I38578297cc1aadefe8c43033cdb14b9460e22c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175827
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 459a9401f342210d7f6ab8fe6fa780ae28413ef6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176825
        Tested-by: Jenkins

2024-11-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e3a88a283bbbe772703e099adcd70baf7ad3e2f]

        switching PageKind without switching EditMode retains current page
        
        i.e. ChangeEditMode doesn't do anything if the EditMode is unchanged
        but the PageKind was switched from Notes to Standard. So the same
        page of the other mode is still selected. An explicit SwitchPage
        is required to change the page from the other mode.
        
        This results in the reported mode of "2", but rendering actually still
        rendering as if in "mode 0", so a request to render a 'standard' page
        returns an image of the currently still-selected 'notes' page, which
        confusingly can be cached and not shown until served as a reply to a
        later request of the 'standard' page.
        
        See DrawViewShell::ReadFrameViewData and other places for more
        of this pattern.
        
        Change-Id: Ie8aa8f93f45189fd6f9c37c4077fa2b547ca4815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176084
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 95e9c210ef8380b0909c6ba596e3023bafef4083)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176824
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-20  Gökay Şatır  <gokaysatir@collabora.com>  [cb610c0200152ea2d62152a3e6f5e003e246bd21]

        cool#7406: Refactor Calc->getPartInfo & use JsonWriter.
        
        Indeed this seems unrelated to the task. But grid in Impress requires to add new properties to "getPartInfo (impress)".
        When i checked the code, i saw that we use getPartInfo's result (on server side) like it's a text instead of JSON. So we'll refactor that part.
        Touching that part requires also touching some other shared functions on COOL side. And those changes also required adding new props here.
        
        We have been fetching this data (without adding new properties) one by one. We now will be able to fetch the whole part's data at once.
        
        This commit also uses JsonWriter class.
        
        Change-Id: Icc26ae71c668c391218e2d517259e1ef32a0832f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176815
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b4bd177f841db980754e233f7996c1a855647ed4]

        update language-subtag-registry to 2024-11-19
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2024-11-19.tar.bz2 data/language-subtag-registry
        
        Change-Id: I1ae31648771642592f8ce5c201ded8fd84eef8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176821
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [fd4498d62c9c317ea9d3a53e335033cf85ab2d02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aa2f1c2c7172ad20c607734c8c11057ee717599a
          - New arguments in ScriptForge.Exception.PythonShell() method
            
            Change-Id: Iceb8b2480055e912eb712ff1eb7d842be440f6ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176712
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-11-20  Miklos Vajna  <vmiklos@collabora.com>  [d248d8f5271c380e51af9482b6724d471e2cb929]

        CppunitTest_sw_tiledrendering2: try to make this more stable
        
        This fails from time to time, see
        <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/177770/console>
        for a case.
        
        When it fails, we get no status callback at all, while the interesting
        failure is when we get a status callback, but it's wrong.
        
        Just give up in the rare case when we get no status callback to avoid
        false alarms for now.
        
        Change-Id: I8f971b64db878d207f9fd2e4fffc4d4b9a4a14e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176818
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-20  Miklos Vajna  <vmiklos@collabora.com>  [6c6e4358ae14328e1dd4bab7cdd8e9019187429c]

        desktop: fix crash in forceSetClipboardForCurrentView()
        
        Crashreport signature:
        
        > Fatal signal received: SIGSEGV code: 1 for address: 0x0
        > program/libmergedlo.so
        >       (anonymous namespace)::forceSetClipboardForCurrentView(_LibreOfficeKitDocument*)
        >               desktop/source/lib/init.cxx:1376 (discriminator 6)
        > program/libmergedlo.so
        >       rtl::Reference<LOKClipboard>::~Reference()
        >               include/rtl/ref.hxx:128
        > program/libmergedlo.so
        >       com::sun::star::uno::Reference<com::sun::star::lang::XComponent>::~Reference()
        >               include/com/sun/star/uno/Reference.hxx:113
        
        Sounds like an attempted document load that failed, but we still try to
        set the clipboard for the first view during shutdown.
        
        Change-Id: I21e5742ae4fcd4b24daf2888f3d64aae437d4fda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176812
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5c5b51e7561624f46c34ec1c1b024269b92739b]

        use TOOLS_WARN_EXCEPTION to get exception details
        
        Change-Id: I68f45585878b323e44ce9ca2d660c72ebb7be174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-20  Michael Weghorn  <m.weghorn@posteo.de>  [357f040d36c4bdebb59c9ada1a2ee20423ca2155]

        tdf#155449 gtk3 a11y: Hold reference to the original AtkObject
        
        Let the AtkObjectWrapper hold a reference to the original AtkObject,
        and release it in `atk_object_wrapper_finalize`.
        
        Without this, the original AtkObject might get destroyed
        too early. Then trying to access it would result in a crash.
        
        While occasionally also seen elsewhere, this was somewhat
        more reliably reproducible when starting the Orca screen
        reader or a pyatspi event listener script while the spell
        check dialog in Writer was shown.
        
        Backtrace of how the AtkObject got destroyed (reverse-debugged
        with rr with a data breakpoint on the AtkObject's accessible description):
        
            1  _int_free_create_chunk   malloc.c             4738 0x7fe5766a858e
            2  _int_free_merge_chunk    malloc.c             4700 0x7fe5766a99b8
            3  _int_free                malloc.c             4646 0x7fe5766a9d31
            4  __GI___libc_free         malloc.c             3398 0x7fe5766ac4ff
            5  atk_object_finalize      atkobject.c          1399 0x7fe5626a7785
            6  g_object_unref                                     0x7fe56e9b94ee
            7  expiry_func              accessible-leasing.c 122  0x7fe5624f32b1
            8  ??                                                 0x7fe568f0f88e
            9  ??                                                 0x7fe568f0c7df
            10 ??                                                 0x7fe568f0ea17
            11 g_main_context_iteration                           0x7fe568f0f180
            12 GtkSalData::Yield        gtkdata.cxx          405  0x7fe5634766ec
            13 GtkInstance::DoYield     gtkinst.cxx          425  0x7fe56347b493
            14 ImplYield                svapp.cxx            385  0x7fe56db0e106
            15 Application::Yield       svapp.cxx            473  0x7fe56db0da9f
            16 Application::Execute     svapp.cxx            360  0x7fe56db0d880
            17 desktop::Desktop::Main   app.cxx              1679 0x7fe576926d8b
            18 ImplSVMain               svmain.cxx           228  0x7fe56db2e996
            19 SVMain                   svmain.cxx           246  0x7fe56db30589
            20 soffice_main             sofficemain.cxx      121  0x7fe5769a08da
            21 sal_main                 main.c               51   0x5644db935a6d
            22 main                     main.c               49   0x5644db935a47
        
        Backtrace of the crash when using the already deleted
        object later:
        
            1  g_type_check_instance_cast                             0x7fe56e9d9337
            2  atk_object_get_index_in_parent atkobject.c        1007 0x7fe5626a5ae5
            3  wrapper_get_index_in_parent    atkwrapper.cxx     545  0x7fe56344a244
            4  atk_object_get_index_in_parent atkobject.c        1011 0x7fe5626a5b3c
            5  append_cache_item              cache-adaptor.c    183  0x7fe562500591
            6  append_accessible_hf           cache-adaptor.c    246  0x7fe56250029b
            7  g_hash_table_foreach                                   0x7fe568efacd3
            8  spi_cache_foreach              accessible-cache.c 423  0x7fe5624f33f9
            9  impl_GetItems                  cache-adaptor.c    328  0x7fe562500174
            10 handle_other                   droute.c           558  0x7fe56250f8a4
            11 handle_message                 droute.c           605  0x7fe56250e7d6
            12 ??                                                     0x7fe5764f5e64
            13 dbus_connection_dispatch                               0x7fe5764e58ab
            14 message_queue_dispatch         atspi-gmain.c      89   0x7fe5623abc52
            15 ??                                                     0x7fe568f0c7df
            16 ??                                                     0x7fe568f0ea17
            17 g_main_context_iteration                               0x7fe568f0f180
            18 GtkSalData::Yield              gtkdata.cxx        405  0x7fe5634766ec
            19 GtkInstance::DoYield           gtkinst.cxx        425  0x7fe56347b493
            20 ImplYield                      svapp.cxx          385  0x7fe56db0e106
            21 Application::Yield             svapp.cxx          473  0x7fe56db0da9f
            22 Application::Execute           svapp.cxx          360  0x7fe56db0d880
            23 desktop::Desktop::Main         app.cxx            1679 0x7fe576926d8b
            24 ImplSVMain                     svmain.cxx         228  0x7fe56db2e996
            25 SVMain                         svmain.cxx         246  0x7fe56db30589
            26 soffice_main                   sofficemain.cxx    121  0x7fe5769a08da
            27 sal_main                       main.c             51   0x5644db935a6d
            28 main                           main.c             49   0x5644db935a47
        
        The deleted object is the `AtkObject *accessible` param
        passed to `atk_object_get_index_in_parent`.
        
        This is with at-spi2-core git main as of commit
        422cac4bd657ce783164324e6ae4b3d54a8aa761.
        
        Change-Id: I23d8a3d55bd587aa99316d71524a18afcd6c0479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176787
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-20  Michael Weghorn  <m.weghorn@posteo.de>  [657873772c2ab37eca2558950c3515458c21f2c5]

        gtk3 a11y: Simplify gtk3/gtk4 version check
        
        One gtk3-specific section is sufficient.
        
        Change-Id: I42a5cd1b94df7874665743a386af8e2e19590b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176786
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-20  Noel Grandin  <noelgrandin@gmail.com>  [c5834bcfacba768fb361ae273534f1eac63f546f]

        use default implementation for hasFastDrawTransformedBitmap
        
        so only the one that implements it needs to override it
        
        Change-Id: I1acffb4796d95d75edc4507f533d9b1f8987972b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176790
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3746195ff989a4596afc456d53010d8860bd7b64]

        catch invalid ranges at export
        
        log failure and continue to export the remainder of the document
        
         #0  0x0000733dda8ae4a1 in __cxa_throw () from target:/lib/x86_64-linux-gnu/libstdc++.so.6
         #1  0x0000733dc5d0bd43 in ScCellRangeObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7)
             at sc/source/ui/unoobj/cellsuno.cxx:4638
         #2  0x0000733dc66150d5 in ScTableSheetObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7)
             at sc/source/ui/unoobj/cellsuno.cxx:6711
         #3  0x0000733dc62d3e38 in ScXMLExport::GetMerged (this=0x1fc74160, pCellAddress=<optimized out>, xTable=...)
             at sc/source/filter/xml/xmlexprt.cxx:2750
         #4  0x0000733dc62d7104 in ScXMLExport::AddStyleFromCells (this=0x1fc74160, xProperties=..., xTable=..., nTable=0, pOldName=0x0)
             at sc/source/filter/xml/xmlexprt.cxx:2156
         #5  0x0000733dc62dfebb in ScXMLExport::collectAutoStyles (this=<optimized out>)
             at sc/source/filter/xml/xmlexprt.cxx:2559
         #6  0x0000733dc62d0fff in ScXMLExport::ExportAutoStyles_ (this=0x1fc74160)
             at sc/source/filter/xml/xmlexprt.cxx:2657
         #7  0x0000733dd833a7a4 in SvXMLExport::ImplExportAutoStyles (this=0x1fc74160)
             at xmloff/source/core/xmlexp.cxx:1123
         #8  0x0000733dd833d098 in SvXMLExport::exportDoc (this=0x1fc74160, eClass=<optimized out>)
             at xmloff/source/core/xmlexp.cxx:1389
         #9  0x0000733dd83386f6 in SvXMLExport::filter (this=this@entry=0x1fc74160, aDescriptor=...)
             at xmloff/source/core/xmlexp.cxx:815
         #10 0x0000733dc62e6452 in ScXMLExport::filter (this=0x1fc74160, aDescriptor=...)
             at sc/source/filter/xml/xmlexprt.cxx:5472
         #11 0x0000733dc63204a0 in ScXMLImportWrapper::ExportToComponent (this=0x7ffc11959890, xContext=..., xModel=..., xWriter=..., aDescriptor=..., sName=...,
             sMediaType=..., sComponentName=..., aArgs=..., pSharedData=...)
             at sc/source/filter/xml/xmlwrap.cxx:707
         #12 0x0000733dc632679a in ScXMLImportWrapper::Export (this=this@entry=0x7ffc11959890, bStylesOnly=bStylesOnly@entry=false)
             at sc/source/filter/xml/xmlwrap.cxx:943
         #13 0x0000733dc6465d5e in ScDocShell::SaveXML (this=0x11d1c440, pSaveMedium=0x138252f0, xStor=...)
             at sc/source/ui/docshell/docsh.cxx:653
         #14 0x0000733dc646a519 in ScDocShell::SaveAs (this=0x11d1c440, rMedium=...)
             at sc/source/ui/docshell/docsh.cxx:1913
         #15 0x0000733dd6ae7432 in SfxObjectShell::SaveAsOwnFormat (this=0x11d1c440, rMedium=...)
             at sfx2/source/doc/objstor.cxx:3378
         #16 0x0000733dd6af0ae6 in SfxObjectShell::SaveTo_Impl (this=0x11d1c440, rMedium=..., pSet=0x7ffc11959fe0)
             at sfx2/source/doc/objstor.cxx:1520
         #17 0x0000733dd6af2f08 in SfxObjectShell::DoSave_Impl (this=0x11d1c440, pArgs=0x7ffc11959fe0)
             at sfx2/source/doc/objstor.cxx:2760
         #18 0x0000733dd6b2b3aa in SfxBaseModel::storeSelf (this=0x5348c30, aSeqArgs=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/optional:306
         #19 0x0000733dd6ab2671 in SfxStoringHelper::GUIStoreModel (this=this@entry=0x2ba275b0, xModel=..., aSlotName=..., aArgsSequence=...,
             bPreselectPassword=bPreselectPassword@entry=false, nDocumentSignatureState=SignatureState::NOSIGNATURES, bIsAsync=false)
        
        perhaps some relation to https://gerrit.libreoffice.org/c/core/+/160363
        which is a somewhat similar situation
        
        Change-Id: I6b28ef0e9df0f44641fa5c582b5827dbcfb4af8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176765
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176792
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [08c04a589ad87274647e7bdb76957d5285eca116]

        tdf#163486: PVS: variable is used after it was moved
        
        Since
        commit 9fe2ead3d5355224dd94d6462b0ddc6100f6d4e3
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri Oct 8 06:43:18 2021 +0200
        
            loplugin:moveparam in svx
        
        V1030 	The 'aSdrObjects' variable is used after it was moved.
        
        Change-Id: I9b426204ff2e2e2d0f6b375e201259765aa12736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176785
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6a539cb5fdd487aa90a1ba551e034b4fdecbf2f]

        sfx2: unused returns
        
        Change-Id: I0ab14e51d10cf67c956624710d1f82c69662e586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176784
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [836d73a65180d89a077e36457f1f3aa1698c2058]

        consider VndSunStarExpand an exotic protocol
        
        and generally don't bother with it when fetching data
        from urls
        
        Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-19  Dione Maddern  <dionemaddern@libreoffice.org>  [40a1affe63dd1321a423308cce8a407b4972949a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9c7414e4fd17c6f2ffbe6208db2c741fe33e803
          - tdf#162504 Create help page for Number Format pane
            
            Create new page source/text/scalc/sidebar_number_format.xhp to describe
            the features of the Number Format pane in the Properties sidebar deck.
            
            In AllLangHelp_scalc.mk
            - Add new file source/text/scalc/sidebar_number_format.xhp to
            repository.
            
            In source/text/scalc/01/default_number_formats.xhp
            - Add variable and section tags so that content can be easily linked and
            embedded in other pages.
            - Remove old comments
            
            In source/text/shared/01/05020300.xhp
            - Add variable and section tags so that content can be easily linked and
            embedded in other pages.
            - Remove old comments
            
            In
            /home/dione/libreoffice/helpcontent2/source/text/shared/01/sidebar_properties.xhp
            THIS PAGE IS A WIP AND WILL NOT BE LINKED IN HELP UNTIL IT IS FINISHED
            - Embed description of the help page for Number Formats
            - Added index bookmarks (Currently commented out)
            - Updated application switches to hide the desription of the Paragraph
            pane for CALC and BASE.
            
            Change-Id: I7e1849ddc41cad7fd5d4b6c57e8a03186eb6575f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176720
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [74d46954cd4a1e2377573683c3a2f7f7033ffb5b]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I6ae56ad61ceec5bc34898befd636a0ceae8266e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176700
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [d02286e7724304a5931181f3c61aed411cbfeae5]

        sw: unused return
        
        Change-Id: I18a5665609b3e15a98bb88e6d307e9f18be967e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176778
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [980164fe222460799f733a6f1a3acc53d5cb002c]

        svx: unused return
        
        Change-Id: If747870121e3fc8c2d97b5fc769b2d928a4c3f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176777
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-19  Noel Grandin  <noelgrandin@gmail.com>  [f1ab6d3e046c261ac0cc0de35bed3e61ba052dca]

        Simplify SalGraphicsImpl::Init
        
        it is only used for one thing, so rename it, and
        use a default implementation to avoid having empty
        implementations everywhere
        
        Change-Id: Ib650bb520ccbfcc27537b754db4d3de4ad10e638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [256463f132597b257cde0b2e3506757b785e4b08]

        loplugin:passparamsbyref
        
        Change-Id: I9ad592670399f25eeaea375bf71e6d30ee20118f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [d991795635784675f6659dc47265088b1803cd52]

        canvas: simplify calcTransformedRectBounds
        
        Change-Id: Ia0314a985ae2183727587ad254faec12ee49b66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176769
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [b20156432fcb2dadabff2decaa04537a7eebc042]

        canvas: simplify calcRectToOriginTransform
        
        Change-Id: I851d9d11c9d3f3c34353913a146ad168a98dc3d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176771
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [e289fdedeb326a37253be509962c6c8ba0ccee80]

        canvas: simplify getViewStateTransform/getRenderStateTransform
        
        Change-Id: If9487aff0d80f7ee9d368cd97bc2828a856cc392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176766
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-19  Miklos Vajna  <vmiklos@collabora.com>  [b0eceb839a8ddb70412d8cc5737eb3bd2b90b2c8]

        svx: prefix members of SvxB3DVectorItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I74c53028d9966ca4059c7a145b3fb0d914d8ae77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176770
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-19  Hossein  <hossein@libreoffice.org>  [1163713bca932e96c1634a54310f9f2b45b038f2]

        Improve LOK tilebench README.md for joining test
        
        The previous command was not working, because of the lack of absolute
        path and also the wrong path to the test document. This should be fixed
        now.
        
        Change-Id: I2230041e17e4b6b33cfd44e5f15a5fce086a5f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176764
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-11-19  Pranam Lashkari  <lpranam@collabora.com>  [85ced7dad83c9d804ded113e6baf37a2814cfd34]

        LOK: use boolean or disabled payload for EditDoc
        
        it is more appropriate state variable for this particular command,
        as in many cases its disabled and that can not be treated as false
        as document still maybe editable
        
        Change-Id: Ib19a0cc087518a18bf295abd08b93815606af1fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176736
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 04375f2a31cc6c233a015215f06682462b30425f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176748
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-11-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [540ac6933be3ffc7585631aea12c86cfe326f462]

        intruduce RenderContext, RenderOptions to remove code duplication
        
        To remove code duplication when rendering main and master slide,
        it is needed to put them into common code, so add RenderContext
        and RenderOptions classes to put the common code into those.
        
        Change-Id: Icf4039f85e0aa5bf4d43e6fe5efb725c90504173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176762
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [10d6a5d62ea8fbeb390714bb8e765664f8613556]

        Update git submodules
        
        * Update translations from branch 'master'
          to fdabff5f73e16046cb570561051304029eef48f9
          - update translations for master / 25.2 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I667061bab346925defe899a544153314133b6bc5
            
2024-11-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d44621c7a7eb8fd0bd571d19ab6540f6022502b2]

        Adapt to LLVM 20 trunk QualType::isAtLeastAsQualifiedAs change
        
        ...in
        <https://github.com/llvm/llvm-project/commit/b9d678d22f74ebd6e34f0a3501fb01d3d80984e7>
        "[Clang] Use TargetInfo when deciding if an address space is compatible
        (#115777)"
        
        Change-Id: Ibe9e4882057edbdcdbd286416c3d317c292b2298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-19  Pranam Lashkari  <lpranam@collabora.com>  [69817b8a8c088e840c958ad1c0b6fdde6e155698]

        LOK: send state of EditDoc for write protection status
        
        Change-Id: I58eb4ab04b4063e382bc6550b5cf08d7806a6c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173470
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 3fa8df9e7f46fd7bf988ca96b0454e5c1ee0a153)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176749
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-11-19  Miklos Vajna  <vmiklos@collabora.com>  [c8b607b7c0096c58dc5187262bf0133dee728d50]

        tdf#163883 editeng RTF export: fix broken offsets into the para style table
        
        Regression from commit 70d1bd6ee0eba9d6661cd6280566f77a87f2d068
        (tdf#161652 editeng, RTF copy: only write used paragraph styles,
        2024-06-20), type a few characters into the title placeholder shape in
        Impress, switch to the Outline view, select all, copy, paste into
        Writer: the resulting text nodes won't have paragraph styles, just
        direct formatting.
        
        Inspecting the produced RTF, the problem is that the styles table
        started to omit unused styles, but the style -> offset mapping table
        still included them, so the offset didn't match, which results in losing
        the style on RTF import.
        
        Fix the problem by building the mapping table later also also ignoring
        unused paragraph styles there, to restore consistency between declaring
        style entries and referring to them.
        
        Change-Id: I9156a881543cc710eb12990f110ceefc77a1858b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176747
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [04afe8b86ccb7975c77971ab339b6eaef92c7b9c]

        cid#1608576 silence Overflowed return value
        
        Change-Id: I131a201cbcbda3415864e357a45f0ac0cd296d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [f5cb83c03339af0efbbf7f2a2fec0f93a7aeb16e]

        tdf#160621 tdf#162702 Variable field dialog page resize
        
        Reduce the size of the upper boxes to get more space for the
        field value input.
        Fixes also tdf#162702 by setting the size also to the number
        format list box.
        
        Change-Id: I96cc38b30fa7afccf6ca009aad3b15f1f051d381
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176106
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-11-19  Andras Timar  <andras.timar@collabora.com>  [6cb711645b8d8f3cee0d3454e193cc7bf1cad305]

        docx: export empty GrabBag elements as self-closing xml tags
        
        Although <tag></tag> and <tag/> are syntactically equivalent, we
        got a report that some 3rd party tool could not process a docx file
        produced by LibreOffice. In styles.xml there was
            <w14:ligatures w14:val="standardContextual"></w14:ligatures>
        instead of
            <w14:ligatures w14:val="standardContextual"/>
        This patch is meant to fix this, to mimic what Word does anyway.
        
        Change-Id: Iea409981d2a2eac40c460bdae4d3dc7e8b0c33ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176680
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2024-11-19  Michael Weghorn  <m.weghorn@posteo.de>  [c5f360a8f667a35282f80682e71f8ad7acebee8b]

        tdf#130857 uui: Drop empty GtkSizeGroup from password.ui
        
        As the GtkSizeGroup [1] says:
        
        > GtkSizeGroup provides a mechanism for grouping a number of widgets
        > together so they all request the same amount of space. This is typically
        > useful when you want a column of widgets to have the same size, but you
        > can’t use a GtkGrid widget.
        
        However, "sizegroup1" in this .ui file is empty, i.e.
        doesn't group any widgets that should be the same size,
        so drop it altogether.
        
        [1] https://docs.gtk.org/gtk3/class.SizeGroup.html
        
        Change-Id: I9ffa6d0d302c08c6668b40847dde04de11fb24cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176737
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [193207c5abf339253e15b59f398da0c1f6f43bee]

        improve loplugin passparamsbyref
        
        I think I managed to disable this when I converted it to
        use the shared plugin infrastructure.
        
        So fix that, and then make it much smarter to avoid various
        false positives.
        
        Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-19  Gülşah Köse  <gulsah.kose@collabora.com>  [b4b3949da1aad091b9f8d0f301f9f7031d6ce295]

        Fix the wrong detection of hidden autofilter button
        
        Regression caused by 2942fdc8dbda375622d0add8c36df2d6679e321a
        
        OOXML <filterColumn colId="0">
        
        Autofilter range colID is not absolute id. It starts always with 0 even
        if the autofiltered range doesn't start with col 0 in the document.
        
        So we are checking the flag from document (rDoc), not from the autofiltered range. So
        we should use absolute column id  to get right flag.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I1f94058caa23686596d57dd6983ddf02cd8f5e71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176564
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176717
        Tested-by: Jenkins

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [3e9658a201f60dee95bd1bd8421b18bf8905c308]

        tdf#163340 pasting paragraphs with lists changed again
        
        Pasting paragraph with a list into an empty or completely selected
        paragraph with lists has been changed:
        If the pasted paragraph(s) are all formatted with a list from the
        paragraph style then this list will be preferred.
        If some the pasted paragraphs including the first one are formatted
        with a hard list then these attributes will be preferred.
        If all paragraphs have a hard list or no list at all the list at
        the target position will be preferred.
        
        Change-Id: I5aa6834d32f7c69b2eb9f8330b282c0ae6fca559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176478
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [43b9ab55a3b6ac1497bcadd6a71a5a133ece4d3d]

        tdf#163956 calculate line height differently in FORMTEXT
        
        Lines containing EN_SPACES only ignore character height
        while calculating line height. In FORMTEXT fieldmarks the character
        height of the default EN_SPACES is not ignored.
        
        Change-Id: I8a89f13875f61ed287ce1697a91b42f20bd17192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176147
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [c4aa95310d98a7f92ae799ead76c8b25ffca53b3]

        tdf#160267 Fix SVG and add PNG format from the clipboard
        
        Since 6c04b8356c0764ba8ac51448eee5ff577b08d9e2 SVG was added
        to the supported clipboard formats but it did not work.
        SVG support is now fixed and PNG format is added in the gallery.
        
        Change-Id: Ic9cb2eebfc37bd38605dfaa3a1c353a7532af357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165908
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [0313b56b931d78453ac5711d5f5f16eed38d02ca]

        tdf#162198 Reset default cell padding in RTF
        
        66b4bfe302e248fc1503c5c74b83f4fb5fee4026 introduced a default left/right
        cell margin of 0.19 cm in DOCX import but is was also applied in RTF.
        This is no longer applied in RTF import.
        
        Change-Id: I192b2d17018c234837b926be64fdf27554b024e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173981
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-11-19  Oliver Specht  <oliver.specht@cib.de>  [075560420a7aa238182e2d80dfe1c5fbaad3edbd]

        tdf# 162326 reset paragraph list attributes on style apply
        
        Follow-up to a593c27e8897280871dc310184ff568bf34a6ebe.
        If Ctrl key is presseed then remove list attributes of the paragraph, too.
        
        Change-Id: I29ea97ff08f45061d532b11cb981c534cc786f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174977
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-11-18  Eike Rathke  <erack@redhat.com>  [03b2f4afc57973fa61284782f7e3d45be99f5eec]

        Resolves: tdf#163903 Add French (Republic of Guinea) {fr-GN} locale data
        
        Change-Id: I46eb65f05a2015f7bd884585a544e030e143f5b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176735
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-11-18  Eike Rathke  <erack@redhat.com>  [6acaa433762624b29eaeca39c5a60eb7824788d6]

        Related: tdf#163903 Add French (Republic of Guinea) {fr-GN} [0x940C]
        
        Change-Id: I2ebea83a757533088fc49a3c849e6b7890277d1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176734
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7a1ab3f0a3c4545b35cf4cc4e3d71b791053350d]

        tdf#163486: PVS: reference may become invalid
        
        V758 	The 'aModel' reference becomes invalid when smart pointer returned by a function is destroyed.
        
        Change-Id: If06b81fda6fdaf4debf5061dd0e3c6c7caccad5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176742
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd63354d2d8c4906cc5ef7b3a1ce42b069e9aa9e]

        tdf#163486: PVS: dereferencing of a potential null pointer
        
        V522 	There might be dereferencing of a potential null pointer.
        
        Change-Id: I23e4eba0399243ca67ecaa3101a327eece825687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176722
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a025eef0034e76e91b9fa4a2e33b133ce6dd07eb]

        cid#1606638 silence Overflowed integer argument
        
        and
        
        cid#1608572 Overflowed integer argument
        cid#1607772 Overflowed integer argument
        cid#1607196 Overflowed integer argument
        cid#1606568 Overflowed return value
        cid#1607573 Overflowed return value
        
        Change-Id: I9a701b19026572127399712c3b660094f2a0bd40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [331bcad4dbe923f4ce47cfe1de64ea0ffbe5a6ce]

        Revert "add an autotext 'common' directory like templates/common"
        
        This reverts commit 3b267b65d24616fe49ca1410b123d186a59541d0.
        
        reports of test failures at:
        https://gerrit.libreoffice.org/c/core/+/176508
        
        Nothing depends on this right now, so I'll have second go at this later.
        
        Change-Id: I95999f05c69fa9b2459128116927616b1f6a9ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176743
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [09de897e579a4c21de6bac37077cad7d8a19a9c2]

        simplify X11SalGraphics::DeInit
        
        it is always called in the destructor, so lets just centralise the logic
        here
        
        Change-Id: I8c9b204d147315b6693fa7a08f759b53b9a6a17c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-18  Noel Grandin  <noelgrandin@gmail.com>  [e4a6ca79beba1f3d3e7106e7080fa04cbc12c421]

        SalGraphics does not need virtual freeResources()
        
        it is only called to do one thing, in X11SalGraphics, so make
        it private to that class, and rename it to better fit its
        purpose.
        
        Change-Id: I16ea2f86f8b596351354faa80bb2bab4d2ac6e7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2261734d88fa3bcfbaa037b0a2bc18cf582c3cf5]

        Resolves: tdf#163831 Invalidate cache if the style is modified
        
        Change-Id: I4a43936a6a7130734f5ae459a9406da99bf0f5f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176727
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-18  Michael Weghorn  <m.weghorn@posteo.de>  [7a551570fe8baf1ca68c6c723c3709a56b69730b]

        qt: Update vim headers/trailers
        
        Following
        
            commit 4f08a15f3be9b39d0f1e83e6cffa47b62c183b69
            Author: lovatico21 <lorenzo04lovato@gmail.com>
            Date:   Wed Nov 13 18:12:58 2024 +0100
        
                updated vim footers in vcl/qt6/*.cxx
        
        , update vim header/trailers to those in current
        `TEMPLATE.SOURCECODE.HEADER` for other qt5/qt6
        headers and sources as well (i.e. for directories
        `vcl/inc/qt5`, `vcl/inc/qt6` and `vcl/qt5/`).
        
        Change-Id: If9fea8f4ce955396f064dbd9fd706e76d947bce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176705
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-18  Michael Weghorn  <m.weghorn@posteo.de>  [4e770803c63417791cf2e38e27ec85127056b7a5]

        tdf#163792 gtk3: Don't always focus combobox when its popup closes
        
        Since
        
            commit 405cf00e4818886b0d3053d03cfb2e3f3a5e8eb8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 28 11:50:12 2024 +0200
        
                related tdf#160971 gtk3 a11y: Keep new combobox value
        
        , closing an (editable) combobox like the font size one
        in the Writer formatting toolbar resulted in the combobox's entry
        having focus, while the focus was set to the document before that
        commit.
        
        Make this work as expected (again), by making grabbing the
        focus conditional in 2 places:
        
        1) In GtkInstanceComboBox::signal_popup_toggled,
        only set the focus to the GtkEntry of the custom
        combobox implementation if the child focus is already
        inside of the combobox. As I understand it, the intended
        logic is "move focus from the combo box's button to its entry",
        not "unconditionally grab the focus".
        This also matches what the gtk4 implementation does. Sync the
        comment from the gtk4 implementation, which explicitly
        mentions the case of the font combobox in the toolbar (which
        behaves the same as the font size one in that regard) where
        focus should not be grabbed.
        
        2) In GtkComboBox::menu_toggled, only explicitly set focus to
        the toggle button if the combo box is located inside of a popup.
        This is the same condition used to grab all keyboard events.
        
        The code to do both was introduced in
        
            commit 131c1c7da8c567636ca55751e49d24cb6d6c9b9e
            Date:   Sun Nov 21 19:53:47 2021 +0000
        
                Related: tdf#145786 cooperate between our own grabs
        
        whose commit message only explicitly mentions grabs
        for popups. The scenarios described in the commit message
        still work as expected with GDK_BACKEND=x11.
        
        With this in place, focus now moves to the document
        as expected when clicking on a combobox entry in the popup
        for the font size combobox in Writer's formatting toolbar,
        while clicking an entry in any of the comboboxes in e.g.
        Writer's "Format" -> "Character" dialog's "Font" tab still
        results in the entry of the combobox getting focus.
        
        Change-Id: Ib07b034f8327dab19a2264ae3ed8e20ea918dd89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176713
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [b223a06401c0b82a37bf5bb288397b6c5314eab9]

        tdf#163486: PVS: reference may become invalid
        
        V758 	The 'rModel' reference becomes invalid when smart pointer returned by a function is destroyed.
        
        Change-Id: I34cbf998da49a576b43b946187de94495f5e5529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176716
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [14f5d64771d5f1db73f8e992e8fbaf414d4c11aa]

        Limit to len the number of UTF-16 code units being read
        
        Change-Id: I62bcf2919cb97d16811e9a59a63f1155437b6740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176718
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [f41701a71b261fd7d3d935f600e61c17fd8ec7e0]

        CppunitTest_sw_layoutwriter2: split in two
        
        It already had 109 tests
        
        Change-Id: I52e7416091bb3ffa80c39a1409dc283771f7d9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176710
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-18  Patrick Luby  <guibmacdev@gmail.com>  [dbe8a75f7933d3f63a6fdd54f0c562a944b53975]

        tdf#163945 Lower priority of Skia flush timer
        
        Commit f4c2c7c79cfe4464ac596afda37b8904d06969db fixed tdf#157312
        by lowering the timer priority to TaskPriority::POST_PAINT. But
        it caused tdf#163734 so it was reverted to TaskPriority::HIGHEST
        in commit 5a38e4f9798c5ff247aa57581adf2671485627fd.
        
        While reverting to TaskPriority::HIGHEST did not cause tdf#157312
        to reoccur, it did cause tdf#163945 so set the timer priority to
        TaskPriority::HIGH_IDLE. This priority appears to be low enough to
        fix tdf#16394 without causing tdf#163734 to reoccur.
        
        Change-Id: Ifc2833a886d52117d46c02a80c88c674ad080824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176698
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-11-18  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [3c371b7bde13c02ad644db7702fb5770d0d25e47]

        Windows Taskbar: use progress bar feature (ITaskbarList3)
        
        Any status progress in LO status bar is also represented
        as progress in Windows taskbar.
        
        Change-Id: Ibd7131ff6246cf5ea37ab8730d0eddfa084265c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171886
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-11-18  Johnny_M  <klasse@partyheld.de>  [e3d16cb1ccf0cdbe9ffac972d9c1fff9f6de3dc2]

        tdf#39468 Translate German comment
        
        Change-Id: If0b996ff97b29860367e6ef939682b3753d47f35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176663
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7afb836b23c286eac4605ef4d98cf517f825b8d8]

        crashtesting: crash on import of rtf exported from forum-en-32886.odt
        
        see: git diff -w
        Change-Id: Id50e45e53b7b433d6c468038a7de14441f4ee560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176707
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-18  MelvinYG  <melvingeorge204@gmail.com>  [828ea8d37d98cedca389e082388a19f4ce7200dd]

        tdf#142741: Add unit test to set valid pages for footnote links PDF export.
        
        Change-Id: I90abb354fb9c4c6319034d994165f2e5cd667d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175945
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-18  AshSinc  <ashleighsinclair86@gmail.com>  [76fa6776c66ece5de9e871905054ea6a1a832c50]

        tdf#163251 Fix for missing flags in single click obj creation
        
        Change-Id: I0f6e65c4cf3ad9cac3096144d8a0efec29030739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174420
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-11-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [15475ac404913a9f5d309ab9789c0bb3c902b62a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3bc6425768d93d6b9bb7304ed3a0ead4b03e2a7
          - Mute L10n of <embedvar> + typos
            
            Change-Id: I06d3cf6d3d56dc030d422228f1e37cd68a7bddb5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176697
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-18  Michael Weghorn  <m.weghorn@posteo.de>  [62c7d89c6a968f162f0ae53288574d0f3a685369]

        loplugin:dllprivate: Extend for new qtbase macro
        
        Qt's qtbase commit [1]
        
            commit cecca90ff23ff27b9396defc21abd472b3fe0003
            Author:     Thiago Macieira <thiago.macieira@intel.com>
            AuthorDate: Tue Oct 1 11:26:30 2024 -0700
            Commit:     Thiago Macieira <thiago.macieira@intel.com>
            CommitDate: Tue Nov 12 17:14:46 2024 -0800
        
                moc: fix support for generating meta objects for nested private classes
        
        introduced a new QT_OBJECT_GADGET_COMMON macro, causing my
        `--enable-qt6` clang plugin build with current qtbase git dev
        (as of commit 957e2be00a5c45223a5ef842a5f9f2f7b7be882b)
        to fail as follows for classes using the Q_OBJECT macro:
        
            In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtAccessibleRegistry.cxx:10:
            In file included from /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtAccessibleRegistry.cxx:11:
            In file included from /home/michi/development/git/libreoffice/vcl/inc/qt6/QtXAccessible.hxx:10:
            /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:27:5: error: declaration nested in DLLPRIVATE declaration redundantly marked as DLLPRIVATE [loplugin:dllprivate]
               27 |     Q_OBJECT
                  |     ^~~~~~~~
            /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:145:5: note: expanded from macro 'Q_OBJECT'
              145 |     QT_OBJECT_GADGET_COMMON \
                  |     ^~~~~~~~~~~~~~~~~~~~~~~
            /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:132:5: note: expanded from macro 'QT_OBJECT_GADGET_COMMON'
              132 |     Q_DECL_HIDDEN_STATIC_METACALL static void qt_static_metacall(QObject *, QMetaObject::Call, int, void **);
                  |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:98:39: note: expanded from macro 'Q_DECL_HIDDEN_STATIC_METACALL'
               98 | #define Q_DECL_HIDDEN_STATIC_METACALL Q_DECL_HIDDEN
                  |                                       ^
            /home/michi/development/git/qt5/qtbase/src/corelib/global/qcompilerdetection.h:190:46: note: expanded from macro 'Q_DECL_HIDDEN'
              190 | #    define Q_DECL_HIDDEN     __attribute__((visibility("hidden")))
                  |                                              ^
            /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:25:7: note: parent declaration is here [loplugin:dllprivate]
               25 | class QtXAccessible : public QObject
                  | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               26 | {
                  | ~
               27 |     Q_OBJECT
                  |     ~~~~~~~~
               28 |
               29 | public:
                  | ~~~~~~~
               30 |     QtXAccessible(css::uno::Reference<css::accessibility::XAccessible> xAccessible);
                  |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               31 |
               32 |     /** Reference to the XAccessible.
                  |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               33 |       * This is cleared once it has been passed to the QtAccessibleWidget,
                  |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               34 |       * which then keeps an own reference and takes care of all required
                  |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               35 |       * access to the XAccessible for the Qt a11y bridge. */
                  |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               36 |     css::uno::Reference<css::accessibility::XAccessible> m_xAccessible;
                  |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               37 | };
                  | ~
            1 error generated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:339: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtAccessibleRegistry.o] Error 1
        
        Extend the plugin to also take the new macro into account in
        addition to Q_OBJECT.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=cecca90ff23ff27b9396defc21abd472b3fe0003
        
        Change-Id: I990f0b25010b3a0f0cc3902f732b93d13bb85d78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176702
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-18  Adam Seskunas  <adamseskunas@gmail.com>  [37e082bd2b968fcabd46b047643288f1d272e95c]

        dbaccess/qa - Seperate database connection so it can be reused
        
        Change-Id: I982cf589aff159149190c7f0f78dc8085a700240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174981
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-18  lovatico21  <lorenzo04lovato@gmail.com>  [4f08a15f3be9b39d0f1e83e6cffa47b62c183b69]

        updated vim footers in vcl/qt6/*.cxx
        
        Change-Id: I98f15800abf65bf3c69b473e8eb68b01838b2ed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176556
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [671886c569a35e691ff3a1b2e60816f75ec223ce]

        tdf#81913 - Keep cell highlighting active during arrow key navigation
        
        Don't delete range finder during arrow key navigation since cursor keys
        don't count as modifications.
        
        Change-Id: I53566a4a84ff4dc81fdf0d8b8f6468f956958925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176689
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9595fc05608a1e7989c85d6eeb5127828f93c9df]

        crashtesting: use after free
        
        commit 8393267c651d0a3071472a8d6ad9861ed75af38b
        CommitDate: Tue Nov 12 09:03:21 2024 +0100
        
            clang-tidy: performance-unnecessary-copy-initialization in various
        
            Change-Id: I1033c33a6b4bf06e365ce183b1a73c98bea777ab
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176442
        
        Change-Id: Id9e253b849c74a2828ef889f9a13854de0fe2f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176693
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-17  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3d871e230fe730d93556a22d853ba4b48ea368e4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4bd6c98f97baeebb9ab087939cf6675ac27a2ce
          - Basic MiD() method has 2 different signatures
            
            - arguments syntax precisions
            - keyword names correction, the 4th argument keyword name is unknown
            
            Change-Id: I6d38dcf61286f88d28090d9e18fafde25bd89376
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172821
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e1ecdda0c13fbf4ae145eebd7a366ea109a56a66]

        cid#1607974 silence Overflowed return value
        
        Change-Id: I9663f3e0cb641bd4530e1aca06d4216de74e38cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176691
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dc4a43373317efed85144b49cf08ff0a30531991]

        cid#1607833 Overflowed constant
        
        Change-Id: Ie90b759b76fa587cddd3c160fe7845dec01652c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176690
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ed8514af4930fdf67f0f213f62551dbbec45af83]

        cid#1607905 Data race condition
        
        Change-Id: Idb525a4e19cfbe0c4a493f511be7dadafac0cff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176465
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c3c337c9506ab9b908f2f91983bb3ee4caa26b3f]

        create BaseContent with the state required and drop mutex
        
        and ContentEventNotifier can be de-friended
        
        Holding this mutex to write to a just created local doesn't make sense
        to me. I can't see any where that there might be another thread that
        matters here.
        
        Change-Id: I803a45a0cf02ebc306767595555018ee97d96caf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [033043c404c841860f241151d69c7b46640801b4]

        cid#1607919 Overflowed constant
        
        Change-Id: I842357000f3282521aa927921a5598fddaef5dee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176686
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5d2de069349528a137c8136233635dc3b9cc5f83]

        pNew is only possible if there is a pRedLine
        
        so we can move this inside the other conditional
        
        Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-17  Sloane Vaznova  <sloane.vaznova@gmail.com>  [78f2f1502bb09e76615d5aee9335f7f6f6f64eda]

        tdf#143148 Use pragma once instead of include guards
        
        Refactored include guards into pragma once for some files
        alphabetically c-d in sw/inc.
        
        Change-Id: I8cf8059851169472d7953f4e6f5408666d27c2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176688
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-17  Jim Raykowski  <raykowj@gmail.com>  [503d7594e3ac32e26752ea294dacf255f66c061c]

        Drop DECL_LINK missed in commit
        
        60a77c7ef46f6fa82b016c7605ec3451de291344
        
        Change-Id: I9141380327aa111bee02257ea2dda53a19bcb0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176687
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-11-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [39f701d540d9bc7e90fa99393c2eac165e71faae]

        Avoid UBSan when negating the most negative sal_Int64 value
        
        ...as exhibited by recently added 08e566f0c97fb6cc2ee17813e81c221a8d7154c0 "add
        a couple of tests for tools::BigInt"
        
        Change-Id: Icd1080f86ccd985868fce34d6f86e2706acd58df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176677
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b8394b36bf1602ca3f33a00dacd18329cc91d2d]

        cid#1606752 silence Overflowed return value
        
        and
        
        cid#1607158 Overflowed return value
        cid#1607271 Overflowed return value
        cid#1608107 Overflowed return value
        cid#1606975 Overflowed return value
        cid#1608009 Overflowed return value
        cid#1608353 Overflowed return value
        cid#1608486 Overflowed return value
        cid#1607009 Overflowed return value
        cid#1606780 Overflowed return value
        
        its totally unclear what the source of these warnings is
        
        Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0847c140a16ddc2d39ebfbacd432efb50f25d64c]

        cid#1371295 avoid Missing move assignment operator
        
        Change-Id: I27cca1b737c441a9f31ed6aa0fc462190ca818da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176682
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0019607e2e39843d7bde7fae31728fd70922254]

        cid#1557644 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I63510464b74e72f8fc73899e963e20891cdf0f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176644
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-16  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [adcc06a4564164b8b0a73ce4254d54f144675bc9]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar.
        
        Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [03e4b7c48d6294520fbe914fe3675108a9935769]

        Fix typo
        
        Change-Id: Iffd36495c9a1424ad02756dbc9bde6ae55df86c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176662
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-11-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [518d875a517ec3af0b0d75fd5d92a12011cdb43b]

        Fix typo
        
        Change-Id: I05757dccf4abc66f11454d2587902d25fca4312a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176660
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-11-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7cb6712b6947f127e6f589972072d12151a9ae3c]

        Fix typos
        
        Change-Id: Ibeadfb72c54887ac8a74dbb11958266fbbda46e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176659
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-11-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0cf68a958b53e6d9a41ae202f9bc69312405b264]

        Fix typo
        
        Change-Id: I4ffd3af20662e92512119ddfa27ea255a114f910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176661
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-11-16  Julien Nabet  <serval2412@yahoo.fr>  [f59ca5c9f9dfe30d755567a74806c42b1f795892]

        Related tdf#105112: FB fix request for getFunctions
        
        add missing spaces + quote before and after function name searched
        
        Change-Id: I3b0bd3ca780c4de9d04fda7d2c80c29e60ddd1ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176669
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-15  Patrick Luby  <guibmacdev@gmail.com>  [f5ef5eafdf70a36edd5129147502a9c74df89456]

        tdf#151423 Only allow modifiers for mouse scrollwheel events
        
        The Command modifier converts scrollwheel events into
        magnification events and the Shift modifier converts vertical
        scrollwheel events into horizontal scrollwheel events. This
        behavior is reasonable for mouse scrollwheel events since many
        mice only have a single, vertical scrollwheel but trackpads
        already have specific gestures for magnification and horizontal
        scrolling. So, behave like most macOS applications and ignore
        all modifiers if this a trackpad scrollwheel event.
        
        Also, ignore all modifiers for swipe events since it appears
        that devices that generate swipe events can generate both
        vertical and horizontal swipe events.
        
        Change-Id: I3c0c726759ef010d528f221c63d1e7e401726db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176410
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-15  Patrick Luby  <guibmacdev@gmail.com>  [0c065c5e233044361713c0003dac6294a82a6e6e]

        tdf#163876 ignore marked text generated from Command-` events
        
        For some unknown reason, when using the standard macOS French
        layout, pressing Command-` causes -[NSView interpretKeyEvents:]
        to temporarily set and unset the marked text.
        
        Command-` should only cycle through the application's windows
        so ignore marked text changes from such key down events.
        
        Change-Id: Ifeb4ad637d572b339d7b389466815bb60a4b3120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176652
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-11-15  Julien Nabet  <serval2412@yahoo.fr>  [afcfb89e3901c303f0fb104a9f91193052f5595b]

        Related tdf#105112: use XDatabaseMetadata3 in Firebird + implement getFunctions
        
        Firebird query for getFunctions comes from Jaybird (Firebird JDBC client).
        
        Change-Id: I427cc1a103ed6fe2b1ad3554bb7c3e2f7a903d87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176273
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-15  Julien Nabet  <serval2412@yahoo.fr>  [bf0374b64edac86402e295a38f0faa655d91abc6]

        tdf#130564: getTableTypes retrieves only table types of the current database
        
        So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views
        
        Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-15  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [bd8a1d1c4547656f5ae30a507cb7453500cff252]

        tdf#163383 Skip adding a tooltip to internal links in all cases
        
        Change-Id: I1d4e46b6e886d45982f3e8145e0bc12ec12d9884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176626
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-15  Miklos Vajna  <vmiklos@collabora.com>  [981ce9b3a95d68bc88cf8c9b6fe5c9e6f17a75ef]

        render master and slide content separately (drawinglayer render)
        
        This renders master and the main slide as 2 separate layers, which
        is useful because in a huge slideshow we can reuse the master slide
        and only render the rest of the slide, which should be more compact
        in size as the master slide is the one that usually contains the
        (complex) background.
        
        Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-15  Hossein  <hossein@libreoffice.org>  [2fbb7e047245922a6e159ee88b6207ec3fbf67ec]

        Cleanup notebookbar.ui for draw
        
        Fix duplicate IDs found by glade-previewer
        
        Change-Id: I5331d5ebdc226bb370d2fd6d6f00c2315952f5ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176625
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-11-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e36a3972c8fd677814b616ecec138287082998fc]

        tdf#163486: PVS:  V614 Uninitialized variable used
        
        V614 Uninitialized variable 'aLStyle' used.
        V614 Uninitialized variable 'aFStyle' used.
        
        Change-Id: I2e545d7909818d8850728bea7cbb533d5ddd87e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175860
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Kurt Nordback  <kurt.nordback@protonmail.com>  [12b9c12eac34e4bd383c27c52355910cdd813424]

        tdf#79450 - Other: Bubbles too near disappear in a Calc chart
        
        An existing optimization avoids rendering a bubble chart bubble if
        it is nearly the same size and position as the preceding bubble. This
        results in incorrect rendering in the case of transparent fill. Skip
        the optimization in this case.
        
        Change-Id: Ie21235a66c4d22ac2ce793264ef5bb7b6434117e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c55f8607fa44475ed574ac9e941fc2c0c111a2e]

        tdf#163486: PVS: fix assert
        
        V547 	Expression '!"unknown reference mark type"' is always false.
        
        Change-Id: I7f984c0e008924b23e3a2384c2e36390bf76cfec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9af69930f06ac8b5ff56ad04c42b90a3ef97c0b9]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 830, 840, 850
        V1037 Two or more case-branches perform the same actions. Check lines: 960, 1148
        
        Change-Id: Ifff7612b44d2a3bc0ea573077104b460fed8cf76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175222
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [61717e306b1c63dc4944efe21bc2ba863b8990aa]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I71c6cd9b5dbcb3126da1919108be009f6512b0d0
        V1037: Two or more case-branches perform the same actions. Check lines: 100, 122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175054
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [6a3618e9d9d364b82713067f6b11821576aedf06]

        vcl: make Calendar constructor initializer functions more clear
        
        Change-Id: I670f219e98bb83f0e8efd0054a06aa869f8fc098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [60889b7326d06c1fbfe146756d664b8f9ee7cc21]

        tdf#39468 vcl: translate German comments in control/calendar.cxx
        
        Change-Id: I6d741a7b1da28f0111df1b1947e510d595d282dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Sahil Gautam  <sahil@libreoffice.org>  [df175a50b687df3abea37515f1154f40a7920319]

        tdf#136003 Change labels in the protect sheet dialog
        
        previously a comment `(for unprotected cells)` was added to the `Delete Rows` and `Delete Columns` menu entries as a solution of tdf#136003. The change has been reverted https://gerrit.libreoffice.org/c/core/+/176614
        
        As tdf#136003 says "Can't delete rows, despite of allow to deletes", the source of confusion is these labels `[ ] Delete Rows` and `[ ] Delete Columns` in the protect sheet dialog. Changed these to `Delete rows with unprotected cells` to make it more clear what they are about.
        
        Change-Id: I1009fca2a3cf56ffdc513fdb9b6192b3b965d050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176616
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil@libreoffice.org>

2024-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1cfbdf60e242930b0f2396dd9a8b29eb24aa36e]

        simplify GDIMetaFile::ReplaceAction
        
        now that we are using proper reference-counting template classes to
        control lifetime here, the code can be simplified and obsolete comments
        removed.
        
        Change-Id: I7693c684d4bed0e26016b5d6bbbf1c38fec62519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176624
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-15  Mohamed Ali  <mohmedali1462005@gmail.com>  [bb7cd2946668e3bc7e98411d7e9bfe956cf5eb2e]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: If278386d2f6da2b841f57be0b57c189dcade3c3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176608
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-15  Miklos Vajna  <vmiklos@collabora.com>  [60261557e5311a7b445fb2455aa534697697a9ec]

        cool#9992 lok doc sign: add initial serialization of external signatures
        
        Now that the hash extract part works, the other end of this external
        signature support is to be able to integrate an externally generated
        (e.g. qualified) signature into our PDF file.
        
        The problem is that we have SignDocumentContentUsingCertificate() for
        non-interactive signing and we have the interactive sign dialog, but we
        have no way to integrate an existing PKCS#7 blob.
        
        Fix the problem by extending vcl::filter::PDFDocument::Sign(): if a
        signature value is provided, then integrate that, instead of calling
        svl::crypto::Signing::Sign() to generate a new signature.
        
        Also extend the SigningContext documentation, since now it has 3 modes
        (normal sign, hash extract, sign serialize).
        
        Change-Id: I113fb536b1a83b8a4869a7064bb415bca6a91ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176623
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6fa60bdffe46ae869ae77c2cee14146a72808f6]

        consistently return -1 in SvFileStream::PutData
        
        for the error case
        
        Just for consistency with the other error cases in PutData/GetData
        
        Change-Id: Ib7fd27f9347021b3063e6eac88fd8038d5f218e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [08e566f0c97fb6cc2ee17813e81c221a8d7154c0]

        add a couple of tests for tools::BigInt
        
        because I might touch this area and I want to be sure I don't mess it up
        
        Change-Id: I62c177031f690f4455a58f3280ed26186df94158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-15  Hossein  <hossein@libreoffice.org>  [dbce105be93b7721817d45c3ab6d774c9c23943c]

        Cleanup notebookbar.ui for sc
        
        While trying to load notebookbar.ui for sc I found that there are issues
        with the .ui file itself:
        
        * Duplicate IDs, created in 608e1452c51efa4f9bbcea8ed9a538ff974eed28
        * Typo in the attribute names, created with the manual edits in
            04ed7cbe53243a042ceeecc62212e73a910d7aef
        
        This patch fixes above problems.
        
        Now, one can preview the notebookbar.ui for sc with:
        
        $ export GLADE_CATALOG_SEARCH_PATH=$PWD/instdir/share/glade
        $ glade-previewer -f sc/uiconfig/scalc/ui/notebookbar.ui
        
        Change-Id: I83be23f4a2a24a04f4fa8b627c138bc42bdf6916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176619
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-11-15  Hossein  <hossein@libreoffice.org>  [f1c1a1b809c03140da7f4a2c2e7f27e484363342]

        Add minimal vcl weld example application
        
        The "minweld" is a minimal standalone vcl application that uses the
        LibreOffice vcl weld framework to display the "tip of the day" dialog on
        the screen. Upon clicking on the "Next Tip", a counter is incremented
        and the text label containing its value is displayed/updated in the
        center of the dialog box.
        
        One can run the application by invoking:
        
            ./bin/run minweld
        
        This example uses cui/ui/tipofthedaydialog.ui for the UI, but only uses
        a few elements of it.
        
        Change-Id: If304c60ddb262182cf23438ed1f83dba85e66391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176610
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-11-15  Sahil Gautam  <sahil@libreoffice.org>  [d18fbc0c20180f6856e9e47eaa97e3763dd4d8e9]

        Revert "tdf#136003 Make Delete Rows/Columns labels more descriptive"
        
        This reverts commit 68d074fb910de7298cbefb6a3c3e192dae201837.
        
        Reason for revert: Changing labels in the menu doesn't help much, rather makes it confusing for new users; decided in the design meeting on 2024-Nov-14
        
        Change-Id: Id8560cd32b233f6908e79beb3af3d774ccc06adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176614
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <sahil@libreoffice.org>

2024-11-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4805277b8d3e93ac652a5ed66d0ed101d64a78c3]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 931, 941
        
        Change-Id: Id5be5973b9b3141576d82f64e5fc46acd926b81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175228
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [83910246044c1e05a3b50e25d21ac6a31566cc38]

        tdf#160404 tdf#160535 tdf#160536 - sc improve sheet protection
        
        tdf#160404: Fix FILEOPEN XLSX Pivot table is not imported if sheet
        protection has Pivot table editing enabled
        - Import correctly the pivot tables, even if the tab protection is not
        allowing to use them.
        
        tdf#160535: Support sheet protection option: Use AutoFilter
        - Add new option for tab protection to enable/disable to use autofilter
        on the sheet. Import/export correctly to odf/ooxml.
        Add new ext-odf attribute: XML_USE_AUTOFILTER
        
        tdf#160536: Support sheet protection option: Use PivotTable&PivotChart
        - Add new option for tab protection to enable/disable to use Pivot table
        on the sheet. Import/export correctly to odf/ooxml.
        Add new ext-odf attribute: XML_USE_PIVOT
        
        Change-Id: I5d34e3608aed1a3d004ec553f6125b6428e9c05e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176274
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-11-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ec13618a1836a46ada1fee72ce4de5c82c0051f6]

        Fix typo
        
        Change-Id: I68102ce865c4f1a132b0e61cb8863bc52adcc695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176609
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [7631b0821f1409f8f7ef669da205084b5a467cc6]

        postgresql: upgrade to 14.14
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.14/postgresql-14.14.tar.bz2
        
        Change-Id: I43f68c1e60e9e9075c983836bdb015b7d3cb8a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176603
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eab66e602fcecf307e2f83ec3e70d8634dbbd66d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f957ab38158f000cba832c0c9183b0a8544e16c
          - tdf#163886 Fix "Edit > External links" for DRAW and IMPRESS
            
            + some refactor
            
            Change-Id: Ice03942da611a57472bf12322e65f4ba3486e0e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176604
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-14  Pierre F  <fpy@bger.ch>  [2a8a840064bf02c300aa5d9045e3882bb97363e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8667cb70fe8fe718b7cf2717bd765e944c2e6f1e
          - misc. href typo (lines 65, 71)
            
            Change-Id: I324a475efd194feb4a80d846aa3b206144335ece
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173181
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [78693c376ed1bdf6d859a44c2651030dc9c970f8]

        tdf#108189 inspection of object hangs LO
        
        There is no general solution to this that I am aware of, so just
        implement a rather specific solution that will need periodic extending
        to check for other dangerous properties
        
        Change-Id: Ie09d89416fea5b7cdf782319ed9921657faa5a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176593
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-14  Jonathan Clark  <jonathan@libreoffice.org>  [78a18a5dc6986c9f5612f26d164c62202a1b94f8]

        tdf#36709 GUI changes for font-relative first-line indent
        
        This change includes GUI element changes to support viewing and editing
        first-line indent values with font-relative units in the paragraph style
        dialog.
        
        Change-Id: I72ada2565f51d70475eb17096a1317be9316b770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176595
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-11-14  Miklos Vajna  <vmiklos@collabora.com>  [39bf87f943cce9a0b5a784bc7426b5b98bbc6992]

        cool#9992 lok doc sign, hash extract: add signatureTime parameter
        
        Execute getCommandValues('Signature') on the same document twice, you
        get different hashes, because the content includes a timestamp, which
        changes, so it's not possible to know if the hash is stable or not.
        
        Also, working with a provided timestamp will needed for
        <https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html#_4-add-the-signature-to-the-pdf-file>
        anyway.
        
        Fix the problem by adding a signatureTime parameter and this way we can
        have a test that makes sure we get the same hash if the time is
        provided.
        
        With this, the hash extraction part is meant to be ~complete.
        
        Change-Id: If5e1e5bcf84c3b777f26b2ded24dcca48ea9ad94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176601
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [89714f9e3ea07381f315686a16cc3ee4a7ccabeb]

        Fix indentation
        
        ...accidentally broken by 16e3b84d2e04cc3e976b59ca4cecd59ca1577cbc "Improve
        loplugin:dyncastvisibility to check for non-inline key functions"
        
        Change-Id: Ie840803b4223fae76bcd72973b6a072eaa5e1d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176598
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b267b65d24616fe49ca1410b123d186a59541d0]

        add an autotext 'common' directory like templates/common
        
        for language neutral autotexts
        
        Change-Id: Id3202981c28071a8100a6ce730274788c80a2867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176508
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [45bb8d9ddcec53aea0f1e831f77cc8290c6018e6]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'm_pRelStorElement->m_xStorage' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: Ie195de78b48c3766ef08a2d3666f778f75d2ca6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176596
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [19e1cf2d1c83586c0444d7eb0a23128706262f28]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'pUndo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: I3eeff673f5c0862e0b3c7f0a5338ddb0882ab31d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176594
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c8afec430a8156e524043e10e8bc81dd5e69bc5d]

        cid#1634638 Use of auto that causes a copy
        
        and
        
        cid#1634639 Missing move assignment operator
        
        Change-Id: Icfc8f958dccae87fd646404c3a5a3772362bcc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176573
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bffbd8f554b0c7b835f02eb5f03845e7e02c870]

        cid#1634806 Logically dead code
        
        Change-Id: If8de961277c3f1a29d2f2ab58261abd8145d4316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9edf69bc03b484afc9933047c92580c9aed71c78]

        cid#1634808 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7209b869abb1133d27271979b1e6c06fa50f7ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6c5355d45d27064ff4fed566d07041e0c6c372e9]

        Fix Linux cppuhelper_detail_findSofficePath
        
        ...so that it looks for the /usr/bin/ symlink with the name with which it is
        created by sysui/CustomTarget_share.mk via sysui/desktop/share/create_tree.sh
        
        Change-Id: I46c2bb9d8df936fd5c7bd52bbee86da959d5c6cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176597
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [80cea922912ba83baf2e2415a0328abb9edc6a00]

        tdf#163486: PVS: Expression is always false
        
        V560 	A part of conditional expression is always false: pTable == nullptr.
        
        Change-Id: Id6f9a8ff3943fecbe77a4d339b3ca76e27a86605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176585
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [4cde4b4b980de4102745516c48dd64e6b388e893]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: mpPage.
        
        Change-Id: If132fa2d5116ec3517846e026bfd3f76ef2cd9a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176591
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [766b63f2d90e011ff5c5b45a2f2ee051a9fde939]

        svx: fix typo
        
        Change-Id: If344ad16098d8bb1549108700d40a7dff65debb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176590
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [11e5ef0698d28fb7ba23f12a1d1b248ce9d6e9b8]

        tdf#163486: PVS: container is empty
        
        Since
        commit ecd615ab32fcacf8f8116672ebe631d1db72cb4e
        Author: Armin Le Grand (Allotropia) <Armin.Le.Grand@me.com>
        Date:   Thu Nov 18 18:06:39 2021 +0100
        
            VCL implement GetGlyphOutline fallback
        
        V557 	The 'aDXArry' container is empty, the access to its elements is impossible.
        
        Change-Id: Ib67bbbf21f215bc27aa03b1a61dd7195c93e5311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176589
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d03f1ed446731f343dc594fc29366ed120b1d5ff]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pFlyFormat.
        
        Change-Id: I9cc68a314dcdf98857eaf39aacf613d6fa67b720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176584
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c8c4d78f6daae5c5add593c16fd6f92836af869]

        tdf#163486: PVS: Expression is always false
        
        V560 	A part of conditional expression is always false: pPap.
        V560 	A part of conditional expression is always false: pSty.
        
        Change-Id: I37a2cce02f303b9a3944c232d57f89b9087375ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176586
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [6454428f1d6c3d759ea2aa61406a24f04faebbff]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pView.
        
        Change-Id: I6c01996c66a0c1488080da532734c3c05820337d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [95bc3adf3a725688369215468284b15c84322dff]

        tdf#163486: PVS: Expression is always true
        
        Since
        commit 9cddf9da7fb256418e1bc3b4719abb55e3b0604c
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Tue May 22 15:33:44 2007 +0000
        
            INTEGRATION: CWS chart2mst3 (1.1.2); FILE ADDED
        
        V560 	A part of conditional expression is always false: (!(pTableFormat && pUnoCursor)).
        V560 	A part of conditional expression is always true: pTableFormat.
        V560 	A part of conditional expression is always true: pUnoCursor.
        
        Change-Id: Id690161e2a64a82f94530142879bf291bd8df743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [0f08d5cac57276d426b21a4be32648ab51bad723]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pFormatItem.
        
        Change-Id: I82009191496573e7f9dd1a6ab7f19df2243a30b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176582
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [333b215427868f7f4cf232cf169c42a5163412b9]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pV != nullptr.
        
        Change-Id: I4af6361993f3b172c54479e1011358c37fcde64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176580
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b3159b984f703345306fbf9dadb433f806505e5]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pItem->mbVisible.
        
        Change-Id: Id9c55e610fa81003a5ad7661d98962aa6d48c062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176579
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b7d9354782420dcaa02969885eb2fb832fb12d9]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pArguments == nullptr.
        
        Change-Id: I1fd44091173ed81cdb0c4a4e27e9408cb6a25e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176578
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [16e3b84d2e04cc3e976b59ca4cecd59ca1577cbc]

        Improve loplugin:dyncastvisibility to check for non-inline key functions
        
        This would have caught the issue discussed in
        709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique
        RTTI".  (The commit message talks about RTTI there, while what Clang actually
        compared for an optimized implementation of a dynamic_cast to a final class is
        vtable pointers, but the overall picture remains the same.  Both RTTI and
        vtables are emitted along the key function, and if that is missing or inline,
        they are emitted for each dynamic library individually, and as internal symbols
        on macOS.)
        
        This commit also addresses all the issues found by the improved
        loplugin:dyncastvisibility on Linux.  See the newly added TODO in
        compilerplugins/clang/dyncastvisibility.cxx and
        86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka
        EventHolder<DocumentEvent>) a key function" for an issue with key functions for
        class template instantiations.
        
        Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac2983bbfbc389b3c3a60b6dc31b96f6686f5233]

        Fix typos
        
        Change-Id: I67b770e3973b78cd59bc1e7c23d780187814c07a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176587
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6e81eaf73bf8fe52a1d1d5b0f9009d4b8af482c]

        tdf#163486: PVS: simplify expression
        
        V728 	An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression.
        
        Change-Id: I31edbbc7ce3b10085c5f1404e74485ea180ddec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176577
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a37890e704528a02d8fd378814ad305818305d86]

        render slide layers with VCL / drawinglayer primitives
        
        Instead of using slideshow module to render the slide layers, use
        the VCL / drawinglayer instead, which makes it possible to render
        transparency correctly and fast.
        
        Change-Id: Idfc9fcc8bc0e2bc139df93d1805f7a19fb1bce1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176575
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [86b86ac87ea0cc90249f156494c98c3c93e4f3fc]

        Give DocumentEventHolder (aka EventHolder<DocumentEvent>) a key function
        
        ...that is not inline, so that RTTI and vtable are not emitted for each dynamic
        library individually.  (Where they would be internal on macOS, which could break
        optimized uses of dynamic_cast for that final class just checking vtable pointer
        identity, as could happen for the dynamic_cast at
        dbaccess/source/core/dataaccess/documenteventnotifier.cxx:232:51,
        
        >   232 |         const DocumentEventHolder& rEventHolder = dynamic_cast< const DocumentEventHolder& >( _rEvent );
        >       |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        And with the extern explicit template instantiation, EventHolder needs to be
        SAL_DLLPUBLIC_TEMPLATE instead of just SAL_DLLPUBLIC_RTTI now, so that
        Library_comphelper will export the DocumentEventHolder ctors and
        DocumentEventHolder::getEventObject.)
        
        (This would ideally have been caught by an upcoming improvement of
        loplugin:dyncastvisibility, but might be complicated to check there for template
        instantiations.)
        
        Change-Id: I1e6280b185535968a870fbfadaff6238d38858e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176547
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-14  Jonathan Clark  <jonathan@libreoffice.org>  [cf42d70e8c50cecd865fdb16d4d8e9e86fc3db25]

        cid#1634809 Null pointer dereferences
        
        and
        
        cid#1634807 Null pointer dereferences
        
        Change-Id: I9a100651a744cb77ff89769e8c98afcfb771f593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176563
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [08aa3c4fa7090b782301ea95891266fd6029cfd9]

        loplugin:reftotemp
        
        (plus ensuing -Werror,-Wpessimizing-move)
        
        Change-Id: Ie2bc5310f0c4a50ba6cdc351cc99f09e7534de29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176562
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-14  Mike Kaganski  <mike.kaganski@collabora.com>  [eecdaa02b64f10302f2742b27a7bd89a13fc30f5]

        Turn a macro to a function
        
        Change-Id: I39cfbe43e7f27ada9999daf93aa6ccfd38fb0c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176561
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-14  Pranam Lashkari  <lpranam@collabora.com>  [df8941ee5bb375de504f106370f28d7f3c12ab70]

        tdf#163805: set fill style to solid on fill color selection
        
        problem:
        The issue here is that the table does not have a fill style set,
        but using the fill tool from the menubar does not give any error
        or warning, either, which confuses the user.
        
        Change-Id: Ib7d6ecdbb315b6eb2eca21423fba28d3cb086450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176245
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit c0623158f010e08e0bfadaffb988eac14e1ff34e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176238
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-11-14  Chris Sherlock  <chris.sherlock79@gmail.com>  [221194dda8a6543f835c057bf609b0e3b3820432]

        vcl: make BitmapArithmeticBlendFilter variables constant
        
        Change-Id: I8e1219ef5ecdbb507b41756304d30eb49ae9a227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173699
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-14  Jim Raykowski  <raykowj@gmail.com>  [2b1b78e11b2b9b3512fe710c5a9679842cd04bc0]

        SwNavigator: Improve the page change control
        
        The intent of this patch is to address an issue with the Writer
        Navigator page change control reported at https://
        ask.libreoffice.org/t/writer-display-single-page/111050
        
        "I have selected View > Normal and View > Whitespace and View> Zoom>
        Entire Page. On the bottom right, I’ve chosen the single page icon."
        ... "It is odd that the page number displayed as you click the
        [Navigator Page control spin button] up and down arrows does not
        change.."
        
        The patch changes the function used by the page control to determine
        the page number of the page in the view to that used by the status
        bar page control. It also disables page tracking by the control when
        the view is set to Multiple-page view or Book view.
        
        Change-Id: I439bb4493061528f87eaeca3c08a33095adb8192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173888
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-11-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [deaa5dc2a4d5446cdd120236615608702598e365]

        Parameterize lower case PRODUCTNAME in odk/config/setsdkenv_windows.bat
        
        Change-Id: I50ebfabdc63729b0ea3152fa919758b028a9c5d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176558
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc383577b8f9c4a67cfe6a52afb425df7af085d2]

        svx: use a reference here
        
        Change-Id: Ic92f640f79c8d1185be422eefaa61601eae9ae8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176555
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa60d9a5af195438afe4aaad5838e78df307cf05]

        tdf#163486: PVS: variable is used after being declared
        
        V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
        V614 	The 'pReturn' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
        
        Change-Id: Ic84af8c395c4b3f86017eb83be17a6fbd628e5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176553
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [6570d5600918c07a4f54b86b1f52e6c4d1964f0c]

        tdf#163486: PVS: variable is used after being declared
        
        Since
        commit 400d5d8a90f1f2737f87b7011294cddb8071768f
        Author: Miklos Vajna <vmiklos@collabora.co.uk>
        Date:   Wed Nov 13 10:35:36 2013 +0100
        
            oox: initial import of wps:wsp
        
        V614 	The 'pMasterShape' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Consider checking the third actual argument of the 'WpsContext' function.
        
        Change-Id: I1e14be0a528e01acbfa2d3e79d5a4d03e4b3e268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176552
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [c382c5202cdfd88302caa11c871bcb6a6c53e5bc]

        tdf#163486: PVS: variable was assigned the same value
        
        Since
        commit 2387c2a46e15995686d28dccdfd455012072b4cf
        Author: Matthew J. Francis <mjay.francis@gmail.com>
        Date:   Wed Jul 29 15:22:54 2015 +0800
        
            Give PyUNO structs/exceptions their own separate type
        
        V1048 	The 'me' variable was assigned the same value.
        
        Change-Id: Ia75c524c9cf459ff2961206c9a17dac1de0125a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176530
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [97cb43c001ffa7811d05150b86902bff8323c2d7]

        tdf#163486: PVS: variable is used after being declared
        
        Since
        commit d4087b13fa278bd63f229a290dd12bda6392e77c
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Fri Apr 18 13:32:32 2008 +0000
        
            INTEGRATION: CWS xmlfilter04 (1.2.12); FILE MERGED
        
        V614 	The 'pMasterShape' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it. Consider checking the second actual argument of the 'GraphicalObjectFrameContext' function.
        
        Change-Id: I3d4241e8c88ee80c95a93d0e08d5498d87e7853b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176551
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [6923fa7a92bd8f33b46be5e5ef6ff44362de435a]

        tdf#163486: PVS: identical conditional expressions
        
        Since
        commit 63cd67e5e18f01aca303131e148c80398a181a41
        Author: Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>
        Date:   Fri May 14 13:53:32 2021 +0200
        
            tdf#92525 tdf#142398: fix export of simple custom shapes
        
        V649 	There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 733, 738.
        
        Change-Id: I92bff7ef8472c1774e6def78c5f1a165ea6a0153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176550
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [83763a3ae15ac8bd2faaf9b194d95ff077f6da4b]

        tdf#163486: PVS: variable is used after being declared
        
        V614 	The 'pEffect' smart pointer is utilized immediately after being declared or reset. It is suspicious that no value was assigned to it.
        
        Change-Id: Ic93aa42fa34af873f8dced5da0c1f55a8dcbd58d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d366b2b6d94be876ea1a9900ec8ba44bd241e4df]

        Update modeline in license header and vim footer
        
        per the current template in TEMPLATE.SOURCECODE.HEADER
        
        Change-Id: I06b36a22d0a62c46e0e0c99f27e1035e9f24e1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176549
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [98e2abcfb8c75172cd719e171dcc1be8474ee630]

        tdf#163486: PVS: variable was assigned the same value
        
        Since
        commit 1847211c00612b4d0c0cb0700aeecd4881a0e01b
        Author: Sander Vesik <svesik@openoffice.org>
        Date:   Wed Apr 21 11:25:53 2004 +0000
        
            INTEGRATION: CWS loadenv01 (1.27.22); FILE MERGED
        
        V1048 	The 'm_bViewCreated' variable was assigned the same value.
        
        Change-Id: I2c5fe19dcbc0524f6a4bf9baf774cc5ef0c2e793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176545
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [81bce5cdfc7908464ac1f55193fbbdf9998f7689]

        tdf#163486: PVS: variable was assigned the same value
        
        V1048 	The 'm_bDelete' variable was assigned the same value.
        
        Change-Id: Ib324ee9473de6b8ce8d4e6e073265580c8a3ba68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176546
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [603e92c7d9d4110bed1161009dbad71f38db572a]

        Some PRODUCTNAME parametrization in SDK .html files
        
        (and some places need a lower case LCPRODUCTNAME; plus some more clean up)
        
        Change-Id: I7e97fcbe2e59ef22dffa7c0b47f076446873d09e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176539
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f251d6ff76f5bf1abb10bb718e6cdbd1678f7d5]

        tdf#163486: PVS: variable was assigned the same value
        
        Since
        commit 49ab7533eb32de671088e2ff5294c2365fb8a756
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Thu Sep 27 07:43:57 2007 +0000
        
            INTEGRATION: CWS swwarnings (1.15.222); FILE MERGED
        
        V1048 	The 'm_bUndoIdInitialized' variable was assigned the same value.
        
        Change-Id: Iccc66213efa98c8fc9108294515ec174b45cc08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176537
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-11-13  NickWingate  <nick.wingate@collabora.com>  [fa3e9a2f31bac6bf17415373656de854f8825b6b]

        Enable context menu key in online
        
        Catch and execute context menu command when
        called from online.
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: I5cca5c7855f5b87f7850c9248e27aa20382dde04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171914
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 5e969a45d36b7e76b4e1e168263bcf2fefddfcef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176529
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c5476ada992ed6dc4759c18af9de0042a6b66eb]

        tdf#163486 PVS: identical sub-expressions
        
        Since
        commit 85a47bbb8340e65a19dc1ceaac768902a771ee77
        Author: László Németh <nemeth@numbertext.org>
        Date:   Fri May 12 17:03:57 2023 +0200
        
            tdf#155328 sw tracked table column: add DOCX export/import
        
        V501 There are identical sub-expressions 'pRedline->GetRedlineData().GetType()' to the left and to the right of the '==' operator.
        
        Change-Id: Ib53d20f102e64cd716245d558d6fd7754f62d9a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175403
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Jonathan Clark  <jonathan@libreoffice.org>  [2cb039f570379213ffc9469a132f5b24f425b7be]

        tdf#36709 editeng: Layout for font-relative first-line indent
        
        This change extends layout for font-relative paragraph first-line
        indentation into Edit Engine.
        
        Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a095909899622ce16bac020fa7034ff162fe0df5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 74e6e0d730bc95780fdb6627dad502abff1dbe57
          - Update simpress screenshots
            
            Change-Id: I5d280d7d2b2f85c4c9f57226fda2bd1a06e4845f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176540
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a4861057447227dda29fad918eee3e04a5238a52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7250806b1224b5e01016dad05430cde02674151
          - Update sdraw screenshots
            
            Change-Id: I543c390401cbbd9faf34e88e4bdcaa30bc1eeabb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176541
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [921bc202246843d444d6e72a28457fd952e5333e]

        tdf#163486: PVS: variable was assigned the same value
        
        Since
        commit ca644612762921e772ca95d5e8737325d9f343d2
        Author: Radek Doulik <rodo@novell.com>
        Date:   Tue Jun 26 12:25:03 2012 +0200
        
            remember spell check/find&replace start position only 1st time
        
        The 'mnStartPageIndex' variable was assigned the same value.
        
        Change-Id: I567f15e88d853804516010b10d9bd571d95f10aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176527
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [004f785a7d1ed168cc5589922101ad98c3251607]

        tdf#163486: PVS: variable was assigned the same value
        
        V1048 	The 'm_eType' variable was assigned the same value.
        
        Change-Id: I03caa56da47c80774008e12120661722522300b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176528
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a5233afeaefb995dfe6c2e4055cff4912585c49e]

        Fix typo
        
        Change-Id: I467a2734fa34c4b8daaefc38754c697c2c2803cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176531
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [fb745b54d223acc480a1f024c42806eadd0c5708]

        new loplugin:reftotemp
        
        look for places where we are taking a reference (i.e. "&") to a
        temporary object, which is misleading.
        
        Change-Id: Id0eb4dce3f1ca559f86e02edcbea3ca17bea8e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175978
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-13  László Németh  <nemeth@numbertext.org>  [bcee366d82392b02745b0070a312624e7baa29d3]

        tdf#163873 sw inline heading: use HTML text, not lo-res bitmap export
        
        Text frames formatted with Inline Heading style and anchored as
        characters were converted to unacceptably low resolution images in
        the HTML export. Now the HTML export contains normal h1–h6 elements
        with display:inline; CSS setting to get text-based/searchable inline
        headings, fixing also the rendering quality.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export",
        commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf48459 sw inline heading: add Inline Heading frame style"
        and commit 984f0e49d35ba87c105310f27d945147a23d1198
        "tdf#163874 sw inline heading: fix XHTML export".
        
        Change-Id: I02f7af8a39314e78d670b4db9a76897e931b3a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176512
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [b51386b77c03068520a0460fed6f2e8fe9459f34]

        tdf#163486: PVS: variable was assigned the same value
        
        V1048 	The 'y' variable was assigned the same value.
        V1048 	The 'x' variable was assigned the same value.
        
        Change-Id: I691b6f2c108dae48cf28d328f502847b8f6726f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176526
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5621b4b488abb4283c09f6f08b4c0e62dc6cd6a4]

        tdf#163486: PVS: Expression can be simplified
        
        Since
        commit 8ab086b6cc054501bfbf7ef6fa509c393691e860
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Mon Sep 18 16:07:07 2000 +0000
        
            initial import
        
        V1065 	Expression can be simplified, check 'nRowCount' and similar operands.
        
        Change-Id: Icd9cdd82cb083e2b40498a21de44a814169977ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176524
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4444d134150209f8c49e8b2d3f5347a51f7b9b04]

        tdf#163486: PVS: variable is assigned but not used
        
        Since
        commit c617be8307033394bde4255c05b72dbd01ae0056
        Author: Norbert Thiebaud <nthiebaud@gmail.com>
        Date:   Tue Nov 27 22:58:50 2012 -0600
        
            remove legacy String svl's Put*Entry family of function and convert users
        
        V1001 	The 'sParams' variable is assigned but is not used by the end of the function.
        
        Change-Id: I90e32de620be23b22c4ab4ee4973433455d844b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176522
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Marco Cecchetti  <marco.cecchetti@collabora.com>  [9d1bedcd6791463c6c8ae737d912cee505dd5699]

        lok: slideshow: export slide duration also when there is no transitions
        
        Change-Id: I234cb814a2096a0071de9cea3f7f8289c107b2b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176520
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [b7d472b0cc581d82c11802a32f2eeafa913ce9b1]

        tdf#163486: PVS: variable is assigned but not used
        
        Since
        commit 659db7d705835b8676065fb4fe3babe39d938977
        Author: Chris Sherlock <chris.sherlock79@gmail.com>
        Date:   Fri Jan 15 03:06:18 2016 +1100
        
            vcl: change ImplFontMetricData to be reference counted via intrusive_ptr
        
        V1001 	The 'xFontMetric' variable is assigned but is not used by the end of the function.
        
        Change-Id: Ib3364c036a2a8e69917d6e02cd8cdbbeee9b65c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176521
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [d7c396771303c772bb8ed8c01b3b76d74946f179]

        libxml2: upgrade to 2.13.5
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.5.tar.xz
        
        Change-Id: I8b88b49fdda737c74bc0c2b3b18b14ada3389f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176519
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-13  László Németh  <nemeth@numbertext.org>  [984f0e49d35ba87c105310f27d945147a23d1198]

        tdf#163874 sw inline heading: fix XHTML export
        
        Text frames anchored as characters, containing inline
        headings were exported without display:inline using
        the XSLT XHTML filter (see File->Export As), resulting
        separated paragraphs for inline headings.
        
        Note: both div and heading elements need display:inline.
        
        This reverts commit d2e8705c9cc503afdaed366b1f71ed012b0c568f
        "tdf#153839: add newline after certain tags" partially
        (and conditionally), because fancy printing is bad here:
        the new line between the div element was converted to a space
        at display:inline, resulting double space with the original
        space between the inline heading and the other text content
        of the following part of the paragraph line.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export"
        and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf48459 sw inline heading: add Inline Heading frame style".
        
        Change-Id: I6623066354a70a69faf14cd30fc2b917c9ec9c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176511
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-11-13  László Németh  <nemeth@numbertext.org>  [4f871a5a9aa1a81831bd525f31023b3915432dd7]

        tdf#48459 sw inline heading: fix bad NC of the new frame style
        
        Which affected translation etc.
        
        Introduced by commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf#48459 sw inline heading: add Inline Heading frame style".
        
        Reported by Olivier Hallot with code pointer.
        
        Change-Id: I7fc4cfa685be4374993754a303b4d54df7d1ee37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176210
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-13  Jonathan Clark  <jonathan@libreoffice.org>  [d3a59f7a915f9cc0864f2c76ccf90b6cd6fea339]

        tdf#36709 sw: Writer layout for font-relative first-line indent
        
        This change implements layout for font-relative paragraph first-line
        indentation in Writer.
        
        Change-Id: Ie8f386bcc13a43ab92d5c15654c24bfdfc62bd69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176216
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [510f0837882284d20b49da8ee1f4f909ed54f0b7]

        bin: Add script to check the latest version of external libraries
        
        it uses https://release-monitoring.org for that
        
        Change-Id: I8ec79f3b1b5e9ae57cc35e19156cba5022870911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173618
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [07ba469a350052eee905e908080f98f11517af66]

        tdf#163486: PVS: pointer not released in destructor
        
        V773 	The 'pDefaults' pointer was not released in destructor. A memory leak is possible.
        
        Change-Id: I7df195d1f515b86e85993d6c0a6cf60bcaff3109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-13  Justin Luth  <justin.luth@collabora.com>  [6595fcacfa9afb5f09465785aa0c4af46e972ef0]

        tdf#103916 tdf#163824 cui tparea: always save changed Fill Lists
        
        This was only working for some EditEng components.
        This change makes it work for all uses of Area Fill.
        
        I put this in the destructor because the current implementation
        (for SvxAreaTabDialog) SavePalettes() on both OK and CANCEL.
        
        I first tried putting it in DeactivatePage,
        but that is not called on a CANCEL,
        or on a switch to another AREA type.
        
        [ColorListState doesn't need this treatment
        since we don't save to disk here,
        plus it needs to be shared between SvxAreaTabDialog pages.]
        
        NOTE: the rename/delete fix for bug 157467 is probably a dependency
        because this patch will significantly increase the likelihood
        that people will try to manage these lists.
        
        Change-Id: I65a84eb6befe91620fd43f3cec2d3ce4dd7ae92d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176325
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-13  Marco Cecchetti  <marco.cecchetti@collabora.com>  [6a7ba6684766b8a506d8038f75e16684cb9c0ef1]

        lok: slideshow: not export endless and repeat property per each slide
        
        Endless and loopAndRepeatDuration properties has to be exported as
        presentation property
        
        Change-Id: I223ab488c8be0726f84a229a63595be6f9455c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176468
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [55d2fdf4ba40af1369406b7775df643f846836a4]

        ignore OUStringChar in loplugin:rangedforcopy
        
        where using a "&" in a for loop is overkill, and may even not be
        the type of range elements
        
        Change-Id: Idba3d84fc52d50a15d917576e07bbac754127126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176480
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a123bed09507ca231e74bbf17b74b1358c6b4a3c]

        Some missing readme PRODUCTNAME parametrization
        
        (and where two places need a lower case LCPRODUCTNAME)
        
        Change-Id: I3879d3eef08d20f65b081a6dfd73658b0b76a33d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176513
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [83b62f2f6675c68d6b22f3f23f20243c1fd906a3]

        loplugin:reftotemp in vcl
        
        Change-Id: Ia5b0fd303f5a3b2c4c119f431517cc063070f4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [a34d9e36193821fdbc8fb7d6b3527daf076b2069]

        loplugin:reftotemp in scripting..uui
        
        Change-Id: I6953958b4429dd0fa1a44d02b0b49618f97baf90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec3850e661e40c146edd55c6ad1fce3996e421c4]

        loplugin:reftotemp in writerperfect
        
        Change-Id: I7a185e98047965a1f6cedd0b31dead5ba6d89192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176502
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [910d3a4f04946207ee88f5a1433946069fb882ed]

        loplugin:reftotemp in xmloff
        
        Change-Id: I121307865a576b8d0bced6098fae37051bd531b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-13  lovatico21  <lorenzo04lovato@gmail.com>  [c189bb19ea118a77d77c9cd335a4de8c7c7780c0]

        added license header and vim footer
        
        Change-Id: Ic4fb58b4285fc657808bc947c79921dad7f4c666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176506
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-12  Michael Stahl  <michael.stahl@allotropia.de>  [58948dd22464c38b2a042022f4d549ca926f0476]

        tdf#161775 sfx2: SfxRedactionHelper: actually use font for layout
        
        Don't just use the font's height, but set the font at the OutputDevice,
        to get the correct Y position of the redaction rectangle.
        
        Still need to increase the top/bottom of the rectangle a little; also add
        a little on the right edge, at least the "t" in Arial sticks out.
        
        Change-Id: Ic6505fc7fa8697d72a6b11259005bb308e74a50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176498
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-12  Michael Stahl  <michael.stahl@allotropia.de>  [f7368c95b6fe90aeb4f06c1eee15be770beda382]

        tdf#161775 vcl: WMF export: remove special case of Dx in EXTTEXTOUT
        
        EMFWriter::ImplWriteTextRecord() has a special case for the last
        position of the DX array to write an average width of all the characters
        excluding the last one.
        
        This has been the case since CVS initial import, and i was unable to
        find any reason for it.
        
        When redacting "Schritte" (large text in bugdoc), it causes the right
        edge of the rectangle to be at 2964 instead of 3103, exposing the last
        character.
        
        Change-Id: I86391e97c4d06093adf3045b04f69153e8e3b0ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176497
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce3f9fd64cc9577af90b899c5cf1fc582dc77fae]

        mariadb-connector-c: upgrade to 3.3.13
        
        Downloaded from https://mirror.raiolanetworks.com/mariadb///connector-c-3.3.13/mariadb-connector-c-3.3.13-src.tar.gz
        
        Change-Id: I54668847708fa6031ec841e886136e4a85f1ff12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176489
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [027544cd4126547f0bf4599d204509a81cf7f992]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8b9ac2e6884fe6d6420443adfc1d4ce862232d6
          - Remove Calc screenshots.
            
            + used only once in a help page
            + Calc localized screenshots are missing.
            + Re-visit "make screenshots" for Calc sometime in the future.
            
            Change-Id: I7a8df7b48eec280d63396c457e3115236bb57ae6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176505
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [92e93e56c9586831e00c9c15dda3f212ea1a5b7c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d1f4acbed85b4a1a59d955c712def6b03689c0a
          - tdf#162627 Update help for Status Bar's Combined Display
            
            The functionality that used to require a double-click now works with
            a single click.
            
            The functionality to insert a field by double-clicking was removed in
            
            commit ebabf6d1fa648d62dd63529e9fe64dcb631caee8
            Author: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
            Date:   Sat Nov 8 23:02:11 2014 +0100
            
                fdo#86018 Don't do anything when clicked on placeholder in statusbar
            
                No idea why this code got executed in sw, it has no action in sd and sc.
            
            Change-Id: If83eeed71de812b1c64f7111e8311c9cc02248c3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176494
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [385a9946074c5098ab027ff0dd7e2dc6b7dc5d25]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 990edcd0aee12e91f6de6e82f6aa093a39d47b3e
          - Update smath screnshots, add new languages
            
            Change-Id: I4af7d78278763b21f82f7278678ec89491de25ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176499
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [879610c41cfad7bff1350d9f6720b53bb478b6a3]

        It's not really an error to not have atevent.xml in an autotext
        
        so downgrade to SAL_INFO
        
        Change-Id: I143eea443e7b41307d80d17b44ac980c73854388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-12  Jim Raykowski  <raykowj@gmail.com>  [1b49aa0bad6d1fce29f27112991ddd839600cd0d]

        tdf#89352 Allow user to change all Footnotes to Endnotes and vice versa
        
        through use of context menu entries in the Writer Navigator Footnotes
        and Endnotes content types
        
        Change-Id: I2c7b6d01013023702f9272e222b76a83710ca6f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176495
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [56e0bd7f4280c52111ba211fee618a412b2b7e9c]

        loplugin:reftotemp in sw
        
        Change-Id: I370d18643b0c83c60846a0b6f051440a043c647a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176486
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Dione Maddern  <dionemaddern@gmail.com>  [285cd7e48ec3f3be2e50b2f3f658ef9aa2092d40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9d4aba7ef8015a50cfe78c611632b445573a874
          - tdf#162504 Add help page for Design sidebar deck
            
            Add new file source/text/swriter/01/sidebar_design.xhp to describe the
            features of the Display sidebar deck.
            
            In AllLangHelp_swriter.mk
            - Add new file source/text/swriter/01/sidebar_design.xhp to repository
            
            In source/text/shared/01/05210200.xhp
            Add section tags to allow content to easily be linked and embedded in
            other pages.
            
            In source/text/shared/01/themesdialog.xhp
            Add section tags to allow content to easily be linked and embedded in
            other pages.
            
            Change-Id: Ic6566b6b1c2a3a6a92d22b2f49b9220cef4bd03c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176493
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [908b85de630fd0d474491c4f2f7402cb39553150]

        libgpg-error: upgrade to 1.51
        
        * external/libgpg-error/w32-build-fixes-6.patch fixes
        libgpg-error.lib(libgpg_error_la-spawn-w32.obj) : error LNK2019: unresolved external symbol __imp__AllowSetForegroundWindow@4 referenced in function __gpgrt_process_spawn
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.51.tar.bz2
        
        Change-Id: I6001d1932d1226c0daa037408523f98a9e719f2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176446
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3aecdee689cdf49815d55c9c7935805d51ea7c53]

        tdf#163486: Improve comments
        
        Change-Id: I2a892e1b3dd8cfbc1501b1e4c40977ee6b7239bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176078
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [96ccb9f0689ce9740cf3c0a76a3a1e2c07f53b77]

        loplugin:reftotemp in slideshow
        
        Change-Id: If01cb31a8dd9a81d62bb7100731d28d33591f76a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176475
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8dd533aa2c71e80f50a292b07660fb5021716f38]

        loplugin:reftotemp in svx
        
        Change-Id: Ie5f9a7f0e6903476bd02391a71c1f3d75afaf09f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [65caa58206bb64c6fa6e482dbd847af1b3c2c1b0]

        loplugin:reftotemp in sot..svl
        
        Change-Id: I4c15b3443f411e81eaf7ea0e8c98e8728ab4ca02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [7a7ba9cbee91485a9254949d1594352b3629c070]

        tdf#145614 Convert #define to enum class
        
        Converted #define to enum class
        
        Change-Id: I16195a439643bcf0111c591a829272b5bf70179d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175027
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-11-12  Justin Luth  <justin.luth@collabora.com>  [006541afcf9cf68425ad3eea466c5d9e129f3b63]

        tdf#157467 SvxPresetListBox: contextmenu must affect item under mouse
        
        Yikes - especially when delete is involved.
        Previously it was deleting the in-use background,
        regardless of where the mouse right-click happened.
        
        You might wonder why not just query GetHighlightedItemId?
        That is because (at least for GTK)
        the highlightedItem is zero'd out as soon as the pop-up starts,
        i.e. when the mouse is moved over top of the context menu.
        
        Change-Id: Ib88cb0edb8c2c8f854c35821d8125a1991d12a55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176447
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [112e07f37f87d6e5ae22bf91f9cccc896698ff87]

        sw: use SAL_RET_MAYBENULL in GetDocShell()
        
        similar to
        commit c796878e6af0fc7c886e813a0010d9402312eb5c
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon Oct 21 15:56:25 2024 +0200
        
            tdf#163543: check GetDocShell()
        
        Change-Id: I4b489c59b7596466aea6b5c7b78248d82f193a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175628
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [3dcd0f4a4cd62f56e75c5f62df9284dc24882f72]

        tdf#162691: ODF 1.4 Add support for xy and polar handle new attributes
        
        Co-author: Regina Henschel
        This implements the new draw:handle attributes of ODF 1.4. For reasons
        for new attributes see https://issues.oasis-open.org/browse/OFFICE-4110
        The old attributes are deprecated but may still be written. So we keep
        them to be backward compatible.
        
        Change-Id: I0b3443d000b2b163363f9070e5e276af2b018cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174966
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ccb96251ea15c3252010416377dd185205206cbd]

        loplugin:reftotemp in sfx2
        
        Change-Id: I0ec28fe2c0737b71ff18c4efbc99c896339f5062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [021b7b6684f13853d8bd1a7bcd7273967a2034d9]

        loplugin:reftotemp in sd
        
        Change-Id: Ib38fdc34dc2112f1aac3914baa074c7574f34f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2d333e5f2f99e594bfdafd6ffb6bdcc1c9451d5]

        sc: prefix members of ScEnginePoolHelper
        
        Change-Id: I7c161ea0f30f6dce8cc64a841245f98f4ca8c507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176472
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6e85bf47b2e62d3af61374eb771a102eb7282fc]

        cid#1606989 Overflowed constant
        
        Change-Id: I1165d1c9b145b25e3160b749df9544d653c4920c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176464
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [15d66da417068051229e8888e9d776a7514b2a46]

        cid#1607638 silence Overflowed return value
        
        Change-Id: Ie6f9db4949924a53edd3b0738bee5c21ca6051a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [007987ffb7d4de050c3b4fa84b5fae33658a8699]

        cid#1607965 Overflowed constant
        
        Change-Id: Ia35a09b2c5e230136a3d3a238c9753cdb268a6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176462
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-12  Miklos Vajna  <vmiklos@collabora.com>  [eabda77c9735040dd5bdb1d2ebe0b96ce316561a]

        cool#9992 lok doc sign, hash extract: digest for getCommandValues('Signature')
        
        To be able to sign externally, we need a way to know what is the
        document hash that would be passed to
        NSS_CMSSignedData_SetDigestValue(), without actually performing the
        signing.
        
        Note that svl::crypto::SigningContext already gives us a way to expose
        the time that would be used for signing.
        
        Expose the hash in a similar way: the format is a SHA-256 hash in base64
        form.
        
        This adapts both places dealing with time: vcl::PDFWriter::GetDateTime()
        and svl::crypto::Signing::Sign, to make sure they use the same time,
        otherwise the hash would potentially depend on two times, which would be
        hard to reproduce later when we serialize the signature we get.
        
        Change-Id: Ib039db4cdd043c8117215c31cb5bc83397693820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176470
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [859f66b6dc37e3192161e1c5cff6afbd83f3b616]

        Simplify a bit
        
        Change-Id: I970ae0afd01ceb4651c0e7bc722ac43b4e9aa0b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176469
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [cb112c1730dc5adb472c48bc2b619a1713397dbe]

        Fix no-pch build
        
        After commit df3483fa74baa0ee73b981df0c106d03dc964a68 "tdf#130857
        VclBuilder: Make MenuAndId a template", 2024-11-10
        
          [CXX] vcl/jsdialog/executor.cxx
          C:\lo\core\include\rtl/ref.hxx(126): error C2027: use of undefined type 'PopupMenu'
          C:\lo\core\include\vcl/builder.hxx(41): note: see declaration of 'PopupMenu'
          C:\lo\core\include\rtl/ref.hxx(126): note: the template instantiation context (the oldest one first) is
          C:\lo\core\include\vcl/toolkit/menubtn.hxx(40): note: see reference to class template instantiation 'VclPtr<PopupMenu>' being compiled
          C:\lo\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled
          with
          [
          reference_type=PopupMenu
          ]
          C:\lo\core\include\rtl/ref.hxx(123): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)'
          with
          [
          reference_type=PopupMenu
          ]
          C:\lo\core\include\vcl/vclptr.hxx(217): note: see the first reference to 'rtl::Reference<reference_type>::~Reference' in 'VclPtr<PopupMenu>::~VclPtr'
          with
          [
          reference_type=PopupMenu
          ]
        
        Change-Id: Ifa2f8e55135faf8864a157aeddcf2764f4b2db4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176471
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [55bb4ac2b8203ba4069ff8c86c4c2f9791d1b65a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8273b9ce92cde88181f89b10a4afba0abfb01f39
          - Revert "Remove modules/smath screenshots (not used)"
            
            This reverts commit 11a434839b830d6527edbfae192f9ad044ec3572.
            
            Reason for revert: Break Help build.
            
            Change-Id: I4b8d109bc24caa79062ee9b32cfd6f74871de140
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176476
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [134afb333ace20672531e464f4e21f1d00cf7bee]

        clang-tidy: performance-unnecessary-copy-initialization in sc
        
        Change-Id: I5d4b2190af6373772fcea7c8427454170fde2e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [33c2a79f141cd20078f82dba5a9292dd6046df6e]

        clang-tidy: performance-unnecessary-copy-initialization in vcl
        
        Change-Id: Idb09d0d256601fb3b9e822404b2f57f41d04d713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176443
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e23be78a6a98c3eb4bef0d598369238ee1ec0cf5]

        clang-tidy: performance-unnecessary-copy-initialization in xmloff
        
        Change-Id: I086167b3d24c125efac99180012e32d9851d49ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176444
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [20d971a58727715475b3dcdd22ad568190c2fac4]

        clang-tidy: performance-unnecessary-copy-initialization in sd
        
        Change-Id: I2521bc29afb9ae98d7db2fab81f93264c91c4065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176438
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [de44eadeb7032c6938e0e30de4b0c906207c92a2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f83321e274052b64e16dba7b50ddee41db53ab3
          - Removed exec bits on PNG files
            
            Change-Id: Ib7c4c917bb7a9c661ee1f28b7c4359acdbac767b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176425
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [58f9555cd52ff3a652f76ece4133141265095878]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1684acfaca19b37db9387f09618dd05cb90048f2
          - Removed exec bits on PNG files
            
            Change-Id: Iff6b93bc6d36414509c659a220eda6529f0a3f61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176460
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Jenkins
            
2024-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6116e6bdb305e4b345bf35bbd80da9a171dc847]

        tdf#163486: PVS: simplify while loop
        
        V654 	The condition of loop is always true.
        
        Change-Id: I9c7cc133cf197e899ac7e13ee3cedc97b7c4d0be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176406
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8393267c651d0a3071472a8d6ad9861ed75af38b]

        clang-tidy: performance-unnecessary-copy-initialization in various
        
        Change-Id: I1033c33a6b4bf06e365ce183b1a73c98bea777ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ba5a6ccf44d02c1711b059bcf6667a18ee3b574]

        clang-tidy: performance-unnecessary-copy-initialization in sw
        
        Change-Id: I64342ae8c10738e276702e8ab2c0c0954be25752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [41ab82d5dbfd04eca6437dc072e0cef15b5d1ae9]

        clang-tidy: performance-unnecessary-copy-initialization in sfx2
        
        Change-Id: If818f7b10eb81f8921b5d90fe0c2db4d4ad97ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176439
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [65d52af42f329bbe7c5e7d6ac617320f7faa4760]

        clang-tidy: performance-unnecessary-copy-initialization in svx
        
        Change-Id: I80bdcae1db64f7693600178d86c122c5875369b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2c3fc08d119989f731a46a4af357e2366d3c508c]

        tdf#162753 - Hyperlink dialog: trim leading/trailing whitespaces of URLs
        
        Change-Id: Ic18d30239e8741f8a28e81e423d3dc223d709a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176409
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e27fd62bd83e5d78f544f661e8aa7e86d3a53c4d]

        clang-tidy: performance-unnecessary-copy-initialization in oox
        
        Change-Id: I9964087880efcf24b5748130cffa2bd85adf1965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [22a9cfbc9cc9577b08493828f3192262f76e7ac9]

        loplugin:reftotemp in sc
        
        Change-Id: Ibd0efec208447d0ad3f5d85354cbfc7d276064af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [554861a3e25c047f3b44e8154f80456985c83402]

        clang-tidy: performance-unnecessary-copy-initialization in reportdesgn
        
        Change-Id: I00a0db4a3cd23ae757aa894f886f5b5a1a0359f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176435
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [16f6149a09945465c97525f521f11922b6a95138]

        clang-tidy: performance-unnecessary-copy-initialization in sal
        
        Change-Id: I99d7b71b2e06c5fc016411c369b6e887a274ec4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176436
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [753be8826eb21d105821b30f2b55a993a2df14f4]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 981, 1008
        V1037 Two or more case-branches perform the same actions. Check lines: 1018, 1025
        
        Change-Id: Iea6f6edc65490587cb974f6d3baa17d3a337a0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175217
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [bb70ecfdfd2117985627cc1b5e0de4b787969e7f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 921, 924
        V1037 Two or more case-branches perform the same actions. Check lines: 1003, 1160
        
        Change-Id: I42e78f2960b97a67625bfdb524b7f615833332ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175230
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [645b37039fff84b1ce4c9d603bd44559c5e57ea5]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 697, 700
        V1037 Two or more case-branches perform the same actions. Check lines: 714, 717
        
        Change-Id: Icb62ded0f40561215abb2bbe571f94c72409916b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175341
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f640c0ab087cc358f957aefa72e438c3c915fe4c]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 36, 186
        V1037 Two or more case-branches perform the same actions. Check lines: 51, 266
        V1037 Two or more case-branches perform the same actions. Check lines: 86, 281
        V1037 Two or more case-branches perform the same actions. Check lines: 96, 116
        V1037 Two or more case-branches perform the same actions. Check lines: 101, 121
        V1037 Two or more case-branches perform the same actions. Check lines: 136, 211
        V1037 Two or more case-branches perform the same actions. Check lines: 141, 171
        V1037 Two or more case-branches perform the same actions. Check lines: 146, 176
        V1037 Two or more case-branches perform the same actions. Check lines: 151, 161
        V1037 Two or more case-branches perform the same actions. Check lines: 156, 166
        V1037 Two or more case-branches perform the same actions. Check lines: 236, 251
        
        Change-Id: I34e62bf931da669e35a0b8e0e25b50402a334c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175224
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [354dc28282ec72326b6decf0b34df57ed43858fb]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Ic54a8e009f68ab992831ba849ae1349a6235bedd
        V1037: Two or more case-branches perform the same actions. Check lines: 1276 and 1408, 1434 and 1510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175149
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [aa416c7d880f2b69a824037d44cd0da2bd675c1b]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Icb29cacf3888421843c958a4f157d1079343cc9e
        V1037: Two or more case-branches perform the same actions. Check lines: 1173, 1176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175053
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [27805424cc880433595a749a36c4bd61a10b2f75]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 544, 552
        V1037 Two or more case-branches perform the same actions. Check lines: 923, 929
        V1037 Two or more case-branches perform the same actions. Check lines: 993, 1001
        
        Change-Id: I373ccdb56bee8d446e2aec3295ba9c0fb23ff82a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175229
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-12  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [fa1902c464f776d2a79a16598e5d713d13f3bcab]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1051, 1124
        
        Change-Id: Iffebecc9ae82633734fd585e40fe51b30fde56b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175211
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [459a45800c5ae1502f0f8829fa96401243e6686a]

        tdf#163486: PVS: call GetItemSet() once
        
        V656 	Variables 'aOldSet', 'aNewSet' are initialized through the call to the same function. It's probably an error or un-optimized code. Consider inspecting the 'pOldAttrs->GetItemSet()' expression. Check lines: 1181, 1182.
        
        Change-Id: I44b7be1bfb53872109b39323f909d5e1fcc1a809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176405
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c6972a49020e6e09936e6bece1347627a963337]

        add AbortOnLoadFailure to optionally assert on failure to load
        
        intended for use with crashtesting to detect when we export something we
        can't import
        
        Change-Id: I80c2f5198f8695c00a68cf09d4512d56c5a537a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176412
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Miklos Vajna  <vmiklos@collabora.com>  [0de900cec7b04d75cf9ab0779d7a1ca3c730ae32]

        cool#9992 lok doc sign, hash extract: time for getCommandValues('Signature')
        
        The final goal of this API is to give time & hash information about the
        PDF signature, so once a 3rd-party produces the PKCS#7 signature, that
        can be added to the document and the actual PDF sign can be re-run with
        the same parameters.
        
        This commit continues the replacement of XCertificate with
        svl::crypto::SigningContext up to the point that the timestamp used in
        svl/ can be exposed on the LOK API.
        
        This is done by updating DocumentSignatureManager::add(),
        PDFSignatureHelper::SetX509Certificate(),
        vcl::filter::PDFDocument::Sign() and finally the svl::crypto::Signing
        ctor to work with the signing context instead of an XCertificate
        directly.
        
        Time reporting works now, so add a test for that. The digest part still
        needs doing.
        
        Change-Id: I83f1274cd420b67194b7caf12b1027e623d4f7fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176404
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e02efcb136424958b18158f01d88d5f34966e523]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 11a434839b830d6527edbfae192f9ad044ec3572
          - Remove modules/smath screenshots (not used)
            
            Change-Id: I2b2ff5eb1ac27040d36f8fa5cca84e640ca9d6fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176433
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ee7e2d904cf2776b6a2a7dcc186acaf7dbc22342]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to adb7b314efd30d81f40d3504ba93188efdb2fd2a
          - Remove modules/schart screenshots (not used)
            
            Change-Id: Ie2e9eb7270c59c846b6a2c8f4a84707ae0fdb0d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176432
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [17c94f92e239c810452d9cf0ea786b139e17ba85]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 225f0abdfb0d61b56a535b259f5a3cc3fd3b659d
          - Remove modules/dbreport screenshots (not used)
            
            Change-Id: I58ad6a3b2dc611db6a23bfb2c6fb53fd4997d987
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176431
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b5319a3ee1a1d6e3aa2f81d49454d4ff1806cd72]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ae5a8bf4e2508dc8bac9fdf35928b17c8a808110
          - Remove BasicIDE screenshots (not used)
            
            Change-Id: I6410344b2df842974193af83b92f95482552c085
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176430
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cc2447477b5b73d7455c5df70fdbb3337818f045]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d52dc402b74583d37f1d1192b6ce07f57c8d2b80
          - Remove sfx screenshots (not used)
            
            Change-Id: Iede3f012134062349ad1319f23a5fe6eccab39a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176429
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cb43c6b88931beedd506b33bb77ca8089ba7094]

        clang-tidy: performance-unnecessary-copy-initialization in various
        
        Change-Id: Ib7d75d4d8207261898568402e7983e0f11da14bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [61d7bd4cd2117e8c4a9bb1cb8fe306438ec34245]

        clang-tidy: performance-unnecessary-copy-initialization in framework
        
        Change-Id: I2ebf2c49ec9aa03f46abdbd2149f04ed5a22f94b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [66c312696014677c57cd21a6b25fa06e92ae487e]

        clang-tidy: performance-unnecessary-copy-initialization in fpicker
        
        Change-Id: I9ba5dd3d13390db5d2c6d03caf087c453ee09ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d0f5d106529e39d1e2be51b76ee08a0de770945c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76a66b6a75f55ba8ed76192454c8662c107270b6
          - Remove svt screenshots (not used)
            
            Change-Id: I26c161839028e3a406e2051c52a7f7ada30ea348
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176428
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4a1b13147e03c05ee405d2d5cbb921f023ff4695]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26683469416013368a2c89229990f5ed795dc7de
          - Update svx screenshots
            
            Change-Id: Ic78564d464ecb1a5382004343f7cc82108342341
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176427
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff1a24de3ce9e052732bc4816e026c5725de5509]

        clang-tidy: performance-unnecessary-copy-initialization in filter
        
        Change-Id: I20d340f2093534424a5a81b84135326271563aa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176414
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [69089f1737a825c81d958785972bf15e9c340d91]

        loplugin:reftotemp in libreofficekit..oox
        
        Change-Id: I62d868f70e33850fa933c8f413f824a523422499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176400
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ce6abe3d47d7992145e7950b719af8c7eb3b2df]

        clang-tidy: performance-unnecessary-copy-initialization in extensions
        
        Change-Id: I85e9c4f7e6d1b20e83929bcfdbbedee7129ce4e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176413
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d71a40504b816035896fcb13f7ae79b0a53db7f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7957db2cfb76ae9da60f2ac6960c167d075bb934
          - Remove formula screenshots (not used)
            
            Change-Id: I1fcee34c14585d3d4b774a23b3fe80292b04ab5b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176422
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c4d14d3a744275a6ff88d3a8b93037b10329433]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66f8c525f5afad0b37a862c7cf990061d7477c63
          - Update writerperfect screenshots
            
            Change-Id: I4d74ccb4df4ffa817f20c40845418234248342bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176426
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f8747a031f253dd485494b66e4f81407bc081a41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13a862f5e9be286576e7be2aa601346d7a2fe516
          - Remove uui screenshots (not used)
            
            Change-Id: I10ea0c9fe4e7e4ae4c5e02f131513b38860b0d36
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176424
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d901c1c2389ff26d0d0f76989553bc419b6ff165]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 98f3d703be6e588c27a94e6ae41d5e4ce74cebbe
          - Remove xmlsec screenshots (not used)
            
            Change-Id: I1ed333e894796d04a79edc070bf675abf6ee9da1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176423
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f94498419cf8e20937e46aa99f80418fd8d57f6]

        loplugin:reftotemp in helpcompiler..i18npool
        
        Change-Id: I6f7794e6988d1e91c848a093ed85ddb0c6d1c67a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176373
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce8816ff95c06ce86dffee90431e6538b676b5e4]

        loplugin:reftotemp in drawinglayer..framework
        
        Change-Id: I31618b4ae7ea4e37834bffc89e352b4c33eda14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176372
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a9ac0a7f6c8475d97480318ebd1fe35e964a8600]

        tdf#144717: fix SwInsFootNoteDlg's next/prev button state check
        
        Trying to move the current cursor, which may actually be a selection,
        to find next/prev footnore, may try to expand the selection across a
        table boundary (from outside to inside), which would fail. This was
        incorrectly treated as "there's no next/prev footnote, the cursor is
        unchanged" case, and the cursor wasn't restored.
        
        Use a separate local cursor object for testing; and make it at least
        somewhat useful, to detect the case when there's no more footnotes
        in the document, so the prev/next buttons would get disabled.
        
        Change-Id: I7db100dfdd290fe01b3eebe17f1dec2784315243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176399
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92618090a370c0f57be64d9f19cead2e87cc0d02]

        cid#1607751 silence Overflowed constant
        
        Change-Id: I809149469d5393250e86116c37a41f7a52682484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7571696cdb075038e8a0d51d6fc8320a2c0d663f]

        cid#1607456 silence Overflowed constant
        
        Change-Id: I6b8391df0d404e1e39d27a979d5e27211661fbac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176383
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [98d80106a37399f6d2eca990fd3fd5412fc87fc2]

        cid#1607376 Overflowed constant
        
        Change-Id: Ib02923e0c40e97fa7a22c7f68079df48baf3fcb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176382
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d551b7234ebb02b8b1a837966b30990e18f0c0b]

        cid#1607427 Overflowed constant
        
        and
        
        cid#1607919 Overflowed constant
        
        Change-Id: Ifad54a4aa6863e23ee9432d4faacf2a61b4d93e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [8080459c1c91a1ccddb1b1607bb310d29e621548]

        tdf#163486: PVS: exception thrown by pointer
        
        Since
        commit a6ad198d097fb4a503c8d5831d484ff46721134b
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Sat Aug 17 13:19:54 2024 +0200
        
            tdf#158556 use more comphelper::ByteReader
        
        V1022 	An exception was thrown by pointer. Consider throwing it by value instead.
        
        Change-Id: I9218d79097975e47822f48838472ca2096d527d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176398
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [b350937ef36056b2f894063b2bef0362b0ad3091]

        sw: Dereference before null check
        
        Since
        commit 2a2c4dddf51c0d6ab726a8854123887bbfa7792a
        Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Date:   Tue Oct 29 12:11:41 2024 +0100
        
            tdf#153636 - Search for outline node only if index is for the current chapter
        
        Change-Id: If969db7c4eee4c542ff99f9d405aa7f1d2a8f414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176403
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [c96e390285d5262bd7c165763d0af571a2a8ab7f]

        tdf#163486: PVS: argument name is the same as one class member
        
        V688 	The 'nNegativeFormat' function argument possesses the same name as one of the class members, which can result in a confusion.
        
        Change-Id: Ia558367b2325820f1cdeedcd92a7a0e663cf9f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176402
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [39fe8e3f274a5d25afd455c253ebd96f97bd4f11]

        tdf#163486: PVS: pointer not released in destructor
        
        The 'm_pControlNumberStyles' pointer was not released in destructor. A memory leak is possible.
        
        Change-Id: Ie60806814ec65b73d0eaf07b53e7dc133b33bf24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176396
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [7743f64869d650d5e6a8fb34bb14b2d1be0b05ce]

        tdf#163486: PVS: simplify while loop
        
        V1044 	Loop break conditions do not depend on the number of iterations.
        
        Change-Id: Id43a749c090d26b6db174a1ad44df904d20863d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176397
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8030c5cfbb9e88038d34f0b753c415c207927441]

        loplugin:reftotemp in pyuno..sax
        
        Change-Id: Ia616256e06f64ad3c635ac30abf521e5dab107d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc7a5d01a0a87f3d125fba2a0c3e4293108bb23a]

        clang-tidy: performance-unnecessary-copy-initialization in drawinglayer
        
        Change-Id: I7ed82c26a5c9d5e7803776e96b19bd8f4d98259e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [40afc6f25a95fba8824b60d0ced265ff80e62a4b]

        clang-tidy: performance-unnecessary-copy-initialization in desktop
        
        Change-Id: I0e6ce8858fc058403020e2db863730f04cac70db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176392
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [08ed26c3b814896b2728b04cc006165f434e6ede]

        clang-tidy: performance-unnecessary-copy-initialization in canvas
        
        Change-Id: I1d08cfe979529614ab2c66702c33a9045b026f23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176391
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa48441b0bde7df62e338e1f466652fa560804c7]

        clang-tidy: performance-unnecessary-copy-initialization in binaryurp
        
        Change-Id: I8af73afaf063294786890a71abe97add283289a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176390
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc70c63f8f6277edc492700f4b33588591f6485b]

        clang-tidy: performance-unnecessary-copy-initialization in basic
        
        Change-Id: I38bc2711bdec2bdaf998401083ff9b62a5595616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f59d4e4e3e41326b6bb4d0175fb9ad812012f92d]

        clang-tidy: performance-unnecessary-copy-initialization in basctl
        
        Change-Id: Icc609ffded11c78c7052356a0ecc8b138a11f13e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176388
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [842c32c33c6356d72cb3adcf510f57d4f8ff9d87]

        remove dead comment
        
        because method is final after
        commit 5b2cd79aded5081ca8a4bc20fb851573ce890092 "loplugin:finalmethods"
        
        Change-Id: Ib530133c42343a512497df012e3d7ed21a8d96bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Harris Popal  <hapopal@csumb.edu>  [43a8f573ea596d75739323ed3878c0e9aecca604]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I7b082c51a7092e18bdbf5a1fbab3fa4e5a97a28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176039
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-11  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [afdf42181d0e25afbce7e3a9e958fdde67c2ce7e]

        lok: enable Zoom transition and RotateIn sub-trans. type
        
        Change-Id: I017403afe90a249cf4c703d813d44b02b0c1430b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176371
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [557b2dcb3ca5d86f411ae89969aec397bad3ec0c]

        cid#1607564 silence Overflowed integer argument
        
        Change-Id: Ib008987be1102782fd92214ae8bf35f8f862d2a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176381
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8bf5fa407e00f0a5c271a6e3d7b91330797c2726]

        cid#1607838 silence Overflowed constant
        
        Change-Id: I4201afc8ee115200f47de4e7b7974f82735a1f01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176380
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [09c0f1cfa63045c9ecdc9ed9190c26ef4acec865]

        cid#1607347 silence Overflowed constant
        
        and
        
        cid#1607622 Overflowed constant
        
        Change-Id: I596708e75118a281fcd8166caf89f2aa741ab605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176323
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2fc901be9252329fc4b2dac83475146830f13db]

        clang-tidy: performance-unnecessary-copy-initialization in connectivity
        
        Change-Id: Ibb485324c71b78ff569cb15b6cf6f7f3889e1dc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [681c7292b280b978a03faba74417207381bea0b2]

        clang-tidy: performance-unnecessary-copy-initialization in dbaccess
        
        Change-Id: If72f9eea59e5f2a4e183b98888a037ea26333cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176377
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-11  Michael Stahl  <michael.stahl@allotropia.de>  [80cda6954adc88eac3b99171acafea004976915b]

        tdf#163818 package: fix recovery of zip entry local header with ...
        
        ... compressed size = 0.
        
        The problem is that vector::data() on a vector of size 0 returns
        nullptr, and osl_readFile into a nullptr buffer returns E_INVAL, which
        causes an exception to be thrown.
        
        Catch the exception, so that there is a chance to read the values from
        the data descriptor instead.
        
        (regression from commit 32cad89592ec04ab552399095c91dd76afb3002c
         and/or commit a6ad198d097fb4a503c8d5831d484ff46721134b)
        
        Change-Id: I9b2d9a930997146faf224d8033955b142fe93f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176289
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [950cd20f5f210b06ed1cc34a858535f51acfe68a]

        clang-tidy: performance-unnecessary-copy-initialization in chart2
        
        Change-Id: I6f84cfea6390d6a263e5e43ec5a638260c10c00d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176374
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [0879fd8ea4920c51dab59a35b8df204f19796fad]

        clang-tidy: performance-unnecessary-copy-initialization in cui
        
        Change-Id: Idbce2978dee6c485e50dc6ceccf67d7d3722bb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Miklos Vajna  <vmiklos@collabora.com>  [1f7e854887c8715aa31beb55ba514c8b11c374eb]

        svx: prefix members of E3dScene
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia235f420f9ae00ad25be4ca2c06ee942ffc3e6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176369
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [719bb5c7197fecf11b89f4c503aae6b3ef3b99fe]

        vcl: Return unique_ptr in weld::Dialog::weld_content_area
        
        This is effectively the weld::Dialog equivalent of
        
            Change-Id: Ia839fac90ea93b9ac6be5819aa4bb3261a775f33
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 10 23:01:07 2024 +0100
        
                vcl: Return unique_ptr in weld::MessageDialog::weld_message_area
        
        Change-Id: I3eee2d3617c3576b442a5578090cd5de53e17f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176365
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-11  Arnaud VERSINI  <arnaud.versini@pm.me>  [f39f318a6f0b9e42de312fd1d606d8626e1b646d]

        vcl pdf : use frozen unordered_map instead of frozen map
        
        Change-Id: I6e9c3562fa13bf5e1adf7de55c48d1e7326d288e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-11  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [caeb32875a508e8e7d079d0e64a5a7e94f75d72c]

        tdf#162753 - Propose clipboard content only for option internet
        
        Change-Id: I030bc4c824ba8946104fe2e6adfd3b445de2b238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176348
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [46009c851764857e67202875cea7d4566bf6abeb]

        vcl: Return unique_ptr in weld::MessageDialog::weld_message_area
        
        The returned weld::Container* (but not the associated toolkit
        widget) is owned by the caller.
        Make that more obvious by returning a unique_ptr<weld::Container>
        instead of a raw pointer.
        
        This is also consistent with what other methods returning
        instances for which the caller takes over ownership
        (like weld::Widget::weld_parent) do, whereas
        e.g. weld::Notebook::get_page returns a weld::Container*
        that is owned by the weld::Notebook instance, not the caller.
        
        Change-Id: Ia839fac90ea93b9ac6be5819aa4bb3261a775f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176363
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [774786a019090b357fffa4008f562988d10b2c8f]

        tdf#130857 VclBuilder: Complete moving XML parsing to base classes
        
        Move VclBuilder::handleMenuObject to the WidgetBuilder template
        base class, and add a new purely virtual WidgetBuilder::insertMenuObject
        that the existing VclBuilder equivalent now overrides.
        
        This moves the remaining XML parsing logic from VclBuilder
        to one of the base classes (WidgetBuilder, BuilderBase),
        following the approach outlined in
        
            commit f61ecf25636d401f862c4de226c04237e1fb2f69
            Author: OmkarAcharekar <omkaracharekar12@gmail.com>
            Date:   Fri Sep 20 13:33:01 2024 +0200
        
                tdf#130857 refactor VclBuilder: Extract template base class
        
        Update the source code comments accordingly.
        
        For QtBuilder, initially add a dummy implementation
        that simply triggers an assert, but can be adjusted
        in the future to create native Qt menus.
        
        Change-Id: I3147cac28c7273cd4c4ea7344a083cd66af8337f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176362
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [73bb40c27449de7ef6029ed1744bb8c3a256711d]

        tdf#130857 Move VclBuilder::handleMenu{,Child} to WidgetBuilder
        
        Move VclBuilder::handleMenu and VclBuilder::handleMenuChild
        to the base class WidgetBuilder and add a new virtual
        WidgetBuilder::handleMenuObject method (used by
        WidgetBuilder::handleMenuChild) that
        the existing VclBuilder implementation now overrides.
        
        This prepares for allowing to use this by subclasses
        that create menus other than the VCL PopupMenu and
        continues the intended separation between XML parsing
        done in WidgetBuilder and actual widget creation
        (in subclasses implementing the vcl::Window or toolkit
        specific logic.)
        
        Change-Id: Idc896570e4b21f6997e548b7bdab8a9610042bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176361
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [5323a78637bceaa0d911a281ad6e680b2af6e62b]

        tdf#130857 Add WidgetBuilder::createMenu, use to abstract from VCL-specifics
        
        Add a new purely virtual WidgetBuilder::createMenu
        and use that in VclBuilder::handleMenu instead
        of directly calling VclPtr<PopupMenu>::Create there.
        
        This is in preparation of moving
        VclBuilder::handleMenu to WidgetBuilder as well,
        to make it reusable for other child classes, in
        particular QtBuilder.
        
        Change-Id: Icf3f937ea8e876c8393185e41a95e0f66458ce11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176360
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [df3483fa74baa0ee73b981df0c106d03dc964a68]

        tdf#130857 VclBuilder: Make MenuAndId a template
        
        Move the MenuAndId struct and the `m_aMenus` member from
        VclBuilder to the WidgetBuilder base class and add two template
        parameters `MenuClass` and `MenuPtr`, which VclBuilder
        specializes with `PopupMenu` and `VclPtr<PopupMenu>`,
        effectively leaving the logic unchanged.
        
        Move VclBuilder::get_menu accordingly.
        
        For QtBuilder, use `QMenu` and `QMenu*` for
        the new template class parameters.
        This can be used to implement support for
        native Qt menus in the future.
        
        Change-Id: Ib015b1b1e6968338ed7419b1822665a521ca748d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176359
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [c88cd599d445b3d5ee3c867a14ea14c67d18e9e9]

        VClBuilder: Avoid casting by using PopupMenu directly
        
        Now that GtkMenuBar support was dropped in
        
            Change-Id: I550c83c6d5d13a5e45dc9332e981bae8b0f0a9a3
        
            commit fa245e4eea218b3c707998e597c526b9d1fdb508
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 10 20:24:11 2024 +0100
        
                tdf#130857 VclBuilder: Drop unused "GtkMenuBar" support
        
        , use PopupMenu directly in MenuAndId instead of just the
        Menu base class, which makes it unnecessary to cast when
        a PopupMenu is wanted.
        
        Change-Id: I51a44f219970f29a12aa15ee58e8512c62fca43e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176358
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [3bdcd536db4356d769e84237139710b399968924]

        tdf#130857 VclBuilder: Drop unused "GtkMenuBar" support
        
        The last use of a "GtkMenuBar" object in .ui files
        was dropped in
        
            commit 7b4169c9d54c6e90e860141a6ced51464cf102d8
            Date:   Wed Jun 9 01:56:48 2021 +0530
        
                Implement Interface for Data Providers.
        
        Drop the code handling it, to simplify the existing code
        and an upcoming refactoring.
        
        Change-Id: I550c83c6d5d13a5e45dc9332e981bae8b0f0a9a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176357
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [d4edde13e808aee6ed1a4b8ae049a956733ee4b9]

        tdf#130857 qt weld: Call handlers when tab page changes
        
        Call the corresponding handlers to notify about
        the previous and current tab page when switching
        the tab page in QtInstanceNotebook, by remembering
        the identifier of the current page and using that
        in a slot connected to the QTabWidget::currentChanged
        signal.
        
        Change-Id: I387c75b3af138cf9b89f169f0a3c223c262c2a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176356
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [5000c5bdfe4778e24759ee0aeb57ecb9fbb3c73a]

        tdf#130857 qt weld: Hold SolarMutex in QtInstanceButton::buttonClicked
        
        Hold the SolarMutex when calling the button clicked
        handler.
        
        Otherwise, opening Writer's "Tools" -> "Footnote/Endnote Settings"
        dialog and closing with the "OK" button triggers an assert when
        using native Qt widgets (i.e. with env var
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 set).
        
        Backtrace:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7ffff789de5c
            2 __pthread_kill_internal pthread_kill.c 78 0x7ffff789debf
            3 __GI_raise raise.c 26 0x7ffff7849c82
            4 __GI_abort abort.c 79 0x7ffff78324f0
            5 __assert_fail_base assert.c 94 0x7ffff7832418
            6 __assert_fail assert.c 103 0x7ffff7842592
            7 ImplDbgTestSolarMutex dbggui.cxx 35 0x7fffeec2eb1e
            8 DbgTestSolarMutex debug.cxx 54 0x7ffff6d2bee0
            9 SwModify::Add calbck.cxx 174 0x7fffbe3b9f49
            10 SwClient::SwClient calbck.hxx 428 0x7fffbe3be8bb
            11 sw::ListenerEntry::ListenerEntry calbck.hxx 241 0x7fffbe3be845
            12 std::construct_at<sw::ListenerEntry, SwClient *, SwModify *&> stl_construct.h 97 0x7fffbe3be80f
            13 std::allocator_traits<std::allocator<sw::ListenerEntry>>::construct<sw::ListenerEntry, SwClient *, SwModify *&> alloc_traits.h 571 0x7fffbe3be5ec
            14 std::__cxx1998::vector<sw::ListenerEntry>::_M_realloc_append<SwClient *, SwModify *&> vector.tcc 634 0x7fffbe3be5ec
            15 std::__cxx1998::vector<sw::ListenerEntry>::emplace_back<SwClient *, SwModify *&> vector.tcc 123 0x7fffbe3be3ca
            16 std::vector<sw::ListenerEntry>::emplace_back<SwClient *, SwModify *&> vector 599 0x7fffbe3bd80a
            17 sw::WriterMultiListener::StartListening calbck.cxx 262 0x7fffbe3bb65d
            18 SwEndNoteInfo::GetCharFormat docftn.cxx 166 0x7fffbe6911c1
            19 (anonymous namespace)::lcl_ResetPoolIdForDocAndSync docftn.cxx 186 0x7fffbe69130b
            20 SwEndNoteInfo::SetCharFormat docftn.cxx 193 0x7fffbe691223
            21 SwEndNoteOptionPage::FillItemSet docfnote.cxx 342 0x7fffa88bdb58
            22 SwFootNoteOptionDlg::OkHdl docfnote.cxx 60 0x7fffa88bb484
            23 SwFootNoteOptionDlg::LinkStubOkHdl docfnote.cxx 55 0x7fffa88bb19d
            24 Link<weld::Button&, void>::Call link.hxx 111 0x7fffe4732de1
            25 weld::Button::signal_clicked weld.hxx 1519 0x7fffe47323ac
            26 QtInstanceButton::buttonClicked QtInstanceButton.cxx 102 0x7fffe473076c
            27 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceButton:: *)()>::call(void (QtInstanceButton:: *)(), QtInstanceButton *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7fffe47332b1
            28 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceButton:: *)()>::call(void (QtInstanceButton:: *)(), QtInstanceButton *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceButton:: *)()>::call(void (QtInstanceButton:: *)(), QtInstanceButton *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7fffe47331e9
            29 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceButton:: *)()>::call(void (QtInstanceButton:: *)(), QtInstanceButton *, void * *) qobjectdefs_impl.h 126 0x7fffe473311b
            30 QtPrivate::FunctionPointer<void (QtInstanceButton:: *)()>::call<QtPrivate::List<>, void>(void (QtInstanceButton:: *)(), QtInstanceButton *, void * *) qobjectdefs_impl.h 174 0x7fffe473309d
            31 QtPrivate::QCallableObject<void (QtInstanceButton:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 545 0x7fffe4732fc6
            32 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7fffe385ace2
            33 doActivate<false> qobject.cpp 4127 0x7fffe3919054
            34 QMetaObject::activate qobject.cpp 4187 0x7fffe390ecf3
            35 QAbstractButton::clicked moc_qabstractbutton.cpp 396 0x7fffe1a24d79
            36 QAbstractButtonPrivate::emitClicked qabstractbutton.cpp 381 0x7fffe1a24c77
            37 QAbstractButtonPrivate::click qabstractbutton.cpp 374 0x7fffe1a24ad1
            38 QAbstractButton::mouseReleaseEvent qabstractbutton.cpp 976 0x7fffe1a25fbf
            39 QWidget::event qwidget.cpp 8967 0x7fffe189d44d
            40 QAbstractButton::event qabstractbutton.cpp 933 0x7fffe1a25ddc
            41 QPushButton::event qpushbutton.cpp 684 0x7fffe1b9c251
            42 QApplicationPrivate::notify_helper qapplication.cpp 3296 0x7fffe17e1989
            43 QApplication::notify qapplication.cpp 2774 0x7fffe17e366d
            44 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1124 0x7fffe3843cca
            45 QCoreApplication::sendSpontaneousEvent qcoreapplication.cpp 1582 0x7fffe3844c09
            46 QApplicationPrivate::sendMouseEvent qapplication.cpp 2355 0x7fffe17e22a7
            47 QWidgetWindow::handleMouseEvent qwidgetwindow.cpp 667 0x7fffe18dc2ff
            48 QWidgetWindow::event qwidgetwindow.cpp 299 0x7fffe18daab5
            49 QApplicationPrivate::notify_helper qapplication.cpp 3296 0x7fffe17e1989
            50 QApplication::notify qapplication.cpp 3247 0x7fffe17e58bd
            51 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1124 0x7fffe3843cca
            52 QCoreApplication::sendSpontaneousEvent qcoreapplication.cpp 1582 0x7fffe3844c09
            53 QGuiApplicationPrivate::processMouseEvent qguiapplication.cpp 2465 0x7fffe267ee7a
            54 QGuiApplicationPrivate::processWindowSystemEvent qguiapplication.cpp 2192 0x7fffe267e036
            55 QWindowSystemInterface::sendWindowSystemEvents qwindowsysteminterface.cpp 1113 0x7fffe27640ed
            56 QWindowSystemInterface::flushWindowSystemEvents qwindowsysteminterface.cpp 1082 0x7fffe2763f9e
            57 QtWaylandClient::QWaylandDisplay::flushRequests qwaylanddisplay.cpp 511 0x7fffdfea8575
            58 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7fffdfec3cf5
            59 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7fffdfec3c1d
            60 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 126 0x7fffdfec3b3f
            61 QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay:: *)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 174 0x7fffdfec3ab1
            62 QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 545 0x7fffdfec39db
            63 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7fffe385ace2
            64 QMetaCallEvent::placeMetaCall qobject.cpp 621 0x7fffe390376c
            65 QObject::event qobject.cpp 1420 0x7fffe39055c0
            66 QApplicationPrivate::notify_helper qapplication.cpp 3296 0x7fffe17e1989
            67 QApplication::notify qapplication.cpp 3247 0x7fffe17e58bd
            68 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1124 0x7fffe3843cca
            69 QCoreApplication::sendEvent qcoreapplication.cpp 1568 0x7fffe3844b79
            70 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1923 0x7fffe38464b4
            71 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1755 0x7fffe38449a1
            72 postEventSourceDispatch qeventdispatcher_glib.cpp 246 0x7fffe3e2e311
            73 ?? 0x7fffea30c7df
            74 ?? 0x7fffea30ea17
            75 g_main_context_iteration 0x7fffea30f180
            76 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 399 0x7fffe3e2d50b
            77 QPAEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 89 0x7fffe2f59238
            78 QtInstance::ImplYield QtInstance.cxx 464 0x7fffe4709672
            79 QtInstance::DoYield QtInstance.cxx 475 0x7fffe470c6f1
            80 ImplYield svapp.cxx 385 0x7fffeed0fed6
            81 Application::Yield svapp.cxx 473 0x7fffeed0f86f
            82 Application::Execute svapp.cxx 360 0x7fffeed0f650
            83 desktop::Desktop::Main app.cxx 1679 0x7ffff7b2696b
            84 ImplSVMain svmain.cxx 228 0x7fffeed30756
            85 SVMain svmain.cxx 246 0x7fffeed32349
            86 soffice_main sofficemain.cxx 121 0x7ffff7ba04ba
            87 sal_main main.c 51 0x555555555a6d
            88 main main.c 49 0x555555555a47
        
        Change-Id: I23aab31c981483830245130cbd06991c1732fc5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176355
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [a7a9acc2cef24c532279f4d5db3418af26292127]

        tdf#130857 qt weld: Support "Footnote/Endnote Settings" dlg
        
        Declare support for the Writer "Tools" ->
        "Footnote/Endnote Settings" dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This is the first supported dialog making use of "GtkNotebook"/
        QtInstanceNotebook, i.e. of what was implemented in previous commit
        
            Change-Id: I52e11ecf053a48940b88b7e6d1e6f9ba8778d9bb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Nov 10 18:54:28 2024 +0100
        
                tdf#130857 qt weld: Implement QtInstanceNotebook logic
        
        For such dialogs, support doesn't only need to be declared for
        the dialog's top-level .ui file ("modules/swriter/ui/footendnotedialog.ui"),
        but also for the .ui files of the single tab pages
        (s. SwEndNoteOptionPage::SwEndNoteOptionPage), otherwise
        the tab page content isn't shown.
        
        Change-Id: Icb8c05cf0616651ae811185095232716bea21bcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176354
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [2f942db0c17512158747175ceee8cd2ed97cadee]

        tdf#130857 tdf#142608 qt weld: Implement QtInstanceNotebook logic
        
        Implement all of the QtInstanceNotebook methods,
        see also GtkInstanceNotebook and SalInstanceNotebook
        for the gtk3 and VCL implementations for comparison.
        
        Unlike weld::Notebook, QTabWidget doesn't have the
        concept of IDs for tabs in addition to indices.
        Introduce a PROPERTY_TAB_PAGE_ID property that
        gets set on the widget of the corresponding tabs
        and holds the tab identifier in order to support
        that.
        
        Implement QtBuilder::applyTabChildProperties
        to set the tab label and ID property by using
        the newly introduced QtInstanceNotebook::setTabIdAndLabel,
        so only QtInstanceNotebook needs to handle that
        property.
        
        The weld::Container* returned by QtInstanceNotebook::get_page
        is owned by QtInstanceNotebook, so keep create one
        on demand and keep a mapping between tab pages and
        the corresponding weld::Container.
        
        In QtInstanceNotebook::insert_page, create a new
        widget and set a QVBoxLayout for now. That could
        be changed to use a different QLayout class in the
        future if that turns out to be more useful.
        
        In QtBuilder::makeObject, as the tab pages are children
        of the "GtkNotebook" in the .ui file, they are initially
        created as child widgets of the QTabWidget.
        However, they need to be set via QTabWidget::setTab instead,
        so add special handling for that case towards the end and
        unset the parent relationship and call that method.
        
        Change-Id: I52e11ecf053a48940b88b7e6d1e6f9ba8778d9bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176353
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [632b211dfc4f859ab2d925dded3b0df7c2dee91f]

        tdf#130857 qt weld: Implement QtInstanceWindow::get_resizable
        
        Change-Id: If8814188ae5cfeabaf077f31f0ab43157ec71d7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176352
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [fc53fdc8c3ce611c4e4effdb696a967aa042f00d]

        tdf#130857 qt weld: Assert in more unimplemented methods
        
        Add asserts, so that it becomes clear if any dialog
        wants to use logic that's not implemented yet, rather
        than just not doing what was requested.
        
        This helps prioritize what to implement while
        adding support for more dialogs.
        
        Change-Id: Iee708d96260d836879974b65e240ba7343b205f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176351
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [343c63fd02a8685a01444659261c43d609fa5398]

        tdf#130857 qt weld: Implement QtInstanceWindow::has_toplevel_focus
        
        Change-Id: I62099b15349c6fec52a79c3f59f85492ec325dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176350
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-11  Patrick Luby  <guibmacdev@gmail.com>  [62baf23796132d6c0e17ae1ff37c3b9ee0556cf0]

        tdf#163764 Force pending timers to run after marked text changes
        
        During native dictation, waiting for the next native event is
        blocked while dictation runs in a loop within a native callback.
        
        Because of this, LibreOffice's painting timers won't fire until
        dictation is cancelled or the user pauses speaking. So, force
        any pending timers to fire after the marked text changes.
        
        Also, remove the fix for OpenOffice bug 106901 as causes any
        key down events to cancel dictation and removing the fix does
        not appear to cause the original crashing bug to reoccur.
        
        Note: inserting a character from the system Character Viewer
        window causes dictation to stop responding and the only way
        I have found to restart dictation is by toggling dictation off
        and then back on again. This same behavior occurs in Apple's
        TextEdit application so this appears to be a macOS bug.
        
        Change-Id: Iad2b54870ff1a315f2f71d72bef24af3cea808e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176100
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e064452b8fc37148752021f2ba08bec9b3e29eb2]

        tdf#163486: PVS: The variable was asign the same value.
        
        V1048 The 'bNumeric' variable was assigned the same value. See line 205 and 232.
        
        Change-Id: If047644a491c8c52933e9bc25d8d85dcbd3565c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175154
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7feaecc98a7301a0b05751010519b5c59407fe30]

        tdf#163486: PVS: The variable was asign the same value.
        
        V1048 The 'eEnableChildren' variable was assigned the same value. See lines 2537 and 2542.
        
        Change-Id: If1e7630ea3fc3bec8401977a011f29380c70da0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175156
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3a513d1ba42e5bf9ac70780d3fb290dd17309365]

        tdf#163486: PVS: Identical branches
        
        Change-Id: If68fa2c871472a21d9404370351828753db37ee4
        V1037: Two or more case-branches perform the same actions. Check lines: 727, 731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175159
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-10  Dione Maddern  <dionemaddern@libreoffice.org>  [c57d6827daedb114f76928751788b72cfda16f3e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c8d7f27a01462bf8e05b6fd5cdc979433d62412
          - Remove empty paragraph at line 78
            
            Removed empty paragraph at line 78 to avoid warnings and translation problems.
            
            Change-Id: I6d28f08bed4ec68921c1b8640504eff966cf517c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176349
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-10  Dione Maddern  <dionemaddern@libreoffice.org>  [f93681a70a859995d049e971104ce8f087d4286c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e9a188e016b3126a9b07d50084338dfead65bf6
          - Fix empty heading in 'Edit module' help page
            
            Added text to the heading in line 77, so that in now reads "Reset", to avoid the warning:
            > Helpex warning: invalid po attributes extracted from /home/timar/libreoffice-master/helpcontent2/source/text/shared/optionen/01010401.xhp
            > No string specified!> 
            > GroupID: hd_id3161832
            - and problems with translation.
            Change-Id: Ia5936a110fa1bbe663032f5fc36b07b7e1af210c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176347
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-10  Regina Henschel  <rb.henschel@t-online.de>  [1b7bdc29559caba53fb3de9820110c633bf00a27]

        tdf#162686 tdf#162687 ODF 1.4 extrusion-metal-type
        
        and extrusion-specularity.
        
        In ODF strict always value 'draw:MetalODF' was written. Changed the
        logic to write 'loext:MetalMSCompatible' too, depending on eMetalType.
        Using a QName as value requires a namespace declaration for the prefix
        'loext'. That is now written directly at the element, not as global
        declaration, to restrict its scope to the element. A global declaration
        would hide when attributes or elements are accidentially written in
        'loext' namespace.
        
        The pattern for nonNegativePercent had missed the percent sign.
        The export is adapted to write the percent sign.
        
        Validation is skipped for save to ODF 1.3, because currently the
        implicit validation uses always latest ODF version, see tdf#163806.
        
        Tests are extended to cover ODF 1.4 and value draw:MetalODF.
        
        Change-Id: I836d11b9cd327b9772e800d9797e04e1613ab2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176246
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-11-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [873b8146604589f31c7fc111462fc0348d431e94]

        drop a static
        
        Change-Id: Ic4eeb87e680cec3667f305e57de2f4688e1ea138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176321
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-10  Patrick Luby  <guibmacdev@gmail.com>  [5a38e4f9798c5ff247aa57581adf2671485627fd]

        tdf#163734 Revert commit f4c2c7c79cfe4464ac596afda37b8904d06969db
        
        Commit f4c2c7c79cfe4464ac596afda37b8904d06969db lowered the Skia
        flushing priority to solve tdf#157312. But the commit caused the
        "window will dock in rectangle" border to not be drawn when dragging
        a dockable window over a dockable position.
        
        Surprisingly, tdf#157312 does not reoccur without the commit so
        it appears that the commit is now unnecessary.
        
        Change-Id: Ibd74ef94e8448cf32fd690d7a26dd098191040b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176341
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4aae5b2c3ce8b66748f742a93eba5582225a3536]

        rRedlTable is rDoc.getIDocumentRedlineAccess().GetRedlineTable()
        
        so make this less confusing
        
        Change-Id: Icc4d4c43f0d35963bb71cdcd64bdd78b00ed9632
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176324
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bc173a20abbdcd03bc5c0f5dbf0b2631e53c141d]

        cid#1607160 Overflowed return value
        
        and
        
        cid#1606794 Overflowed return value
        
        Change-Id: I222f5fa18ed26ee92d970c744682bf21147265ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-10  Michael Weghorn  <m.weghorn@posteo.de>  [6c957f1b4978d89149da3b379f85a5a526428a8a]

        tdf#130857 qt weld: Add QtInstanceNotebook skeleton
        
        Add a new QtInstanceNotebook class that is the
        weld::Notebook implementation using a native
        Qt widget. It uses a QTabWidget.
        
        Initially, all methods trigger an assert;
        the actual logic still needs to be implemented
        in future commits.
        
        Let QtBuilder handle "GtkNotebook" objects by
        creating a QTabWidget and let
        QtInstanceBuilder::weld_notebook return
        an instance of the new class.
        
        Change-Id: I5a0671a1ba98bea3e0659e4f280706179bfb4d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176322
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-10  Michael Weghorn  <m.weghorn@posteo.de>  [7270c44e43a1c681dc55ce25f114b402bd8cf935]

        tdf#130857 VclBuilder: Split XML parsing + applying tab child props
        
        Split the existing VclBuilder::handleTabChild into two
        methods and make the logic not specific to vcl::Window
        available to other subclasses as well, to make it
        available for reuse by QtBuilder in the future.
        
        In order to do that, move the existing XML parsing logic
        from the beginning of VclBuilder::handleTabChild to the base
        class into WidgetBuilder::handleTabChild.
        
        Add a new purely virtual method `applyTabChildProperties`
        to WidgetBuilder and move the corresponding logic for
        vcl::Window to the new VclBuilder override of this method.
        
        Call that method at the end of WidgetBuilder::handleTabChild.
        
        For QtBuilder, just add a dummy implementation that
        triggers an assert initially, which matches what
        would have happened right at the beginning
        of the previous WidgetBuilder::handleTabChild
        implementation without this commit in place.
        
        Change-Id: Ie5664bd341182fa51035b547accf9393d65a0702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176320
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-10  Michael Weghorn  <m.weghorn@posteo.de>  [d18d05e2f7bfabef3d0783d4de550bf97b8937fd]

        tdf#130857 VclBuilder: Abstract tab control check from VCL details
        
        In VclBuilder::handleTabChild, move casting the vcl::Window to
        TabControl further down to avoid vcl::Window specific code in
        the XML parsing logic.
        Introduce a new purely virtual helper method
        WidgetBuilder::isHorizontalTabControl,
        implement for VclBuilder and QtBuilder and
        use that in the XML parsing logic instead
        of directly checking whether the parent is
        a TabControl widget.
        
        This  gets rid of one detail specific to the VCL
        implementation in the XML parsing part and is in
        preparation of further refactoring of
        VclBuilder::handleTabChild for reuse with QtBuilder.
        
        Change-Id: I05c637f81bce4a5cdd443960a1ad096c347df560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176319
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa0df21584f523fad9e3454cd8245cb1ff36dba7]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1ca6cb9f31503623a5efdab58dc17cf788989ecd
          - Update Danish dictionaries to v2.8.140
            
            Change-Id: I3e3260a3e6080949a7e09f00441a062d58206306
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/176344
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-11-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bb42adb99a501a128a459b747b19134a5e804acb]

        tdf#162753 - Propose clipboard content only for options internet and mail
        
        Change-Id: I11ac10ac4321f15cdd9f5096457f6ea4ab8204b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176269
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [1180b3473aed3251b5869256abc9c7774bab9ced]

        com::sun::star -> css
        
        Change-Id: I890ec73e30d3cc6b210903ecee29431f3cb5f635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175979
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7713d916e06a8388f849a758f928cbcfded6c0ae]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 94, 97
        
        Change-Id: If4eeadad5a9985a2d4e8336ab4cba9188655b6ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175227
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0488beff8bdcb1bb4014d28136ed5fda571b46ee]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 94, 99
        
        Change-Id: I406b94c79426cebbd4813a019389d0cac0616bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175226
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-10  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [cd398f3e740ef68221520f7947a361ddd66c8f2a]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 999, 1003
        V1037 Two or more case-branches perform the same actions. Check lines: 1557, 1566, 1595
        V1037 Two or more case-branches perform the same actions. Check lines: 2593, 2689
        
        Change-Id: I0a3ab375e9e8c72802615108948c96808a2ec0b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175208
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c4052eaa4e2731ab68df0c0a1ce841dfa7c334e9]

        cid#1607142 Overflowed constant
        
        Change-Id: I840fbf1b472dbf0a41dc9032e4e75839dec8dc2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c3133fc335ff88adb1780f09d34f9907b1ccb8f]

        cid#1634585 Use of auto that causes a copy
        
        and
        
        cid#1634580 Use of auto that causes a copy
        cid#1634578 Use of auto that causes a copy
        
        Change-Id: Iad2ec6285b1eb923f3f30e8b18ee577d53ca140b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6e9f865789e6c4fabe35c0eb28302217c5c5b9d8]

        cid#1634574 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1634579 COPY_INSTEAD_OF_MOVE
        cid#1634583 COPY_INSTEAD_OF_MOVE
        cid#1634586 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I24f4f0edf90546fe89ebecf0652f27298b5dd2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [dcd7be141f6f7f55b9fbf583a014b3add4d08dfe]

        XTopWindowListener is unused here
        
        Change-Id: Ib4c1464d709c41f019d1910000e71075c9f5e037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176310
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ce310aa33ad2c13776298b3b0ec282c098262aa9]

        Use OInterfaceContainerHelper4 per listener class for type safety
        
        Change-Id: I919fef7e981d2dbdd69eb3cce34b3236dd6ed7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176309
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [d0ea15aacebf4cad09dee90725dc06f5dde43ade]

        tdf#130857 qt weld: Add QtInstanceTreeView skeleton
        
        Add a new QtInstanceTreeView class that is the
        weld::TreeView implementation using a native
        Qt widget. It uses a QTreeView.
        
        Initially, all methods trigger an assert;
        the actual logic still needs to be implemented
        in future commits.
        
        Let QtBuilder handle "GtkTreeView" objects by
        creating a QTreeView.
        
        Let QtInstanceBuilder::weld_treeview return
        an instance of the new class.
        
        Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [99b465fc3c1f4b30182d56e4b1781218bd5a66f2]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_approximate_digit_width
        
        Similar to how OutputDevice::approximate_digit_width, used
        by SalInstanceWidget::get_approximate_digit_width does it,
        get the width for all a text containing all of of the 10 digits
        and divide by 10 to get the average/approximate width of a digit.
        
        This method e.g. gets called by the print progress dialog.
        
        Change-Id: Ib1779a0a211f571c10714a291fed8f84ae5906ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176306
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [c74924f0fe28229518172ca8f6410d9f7fe373b7]

        tdf#130857 qt weld: Assert in unimplemented methods
        
        Trigger asserts in more currently not (yet)
        implemented methods, so anything missing becomes
        clear more easily when working on adding support for another
        dialog in the future, rather than some functionality
        just not working as expected.
        
        None of the newly added asserts was triggered
        in a quick test of opening all of the dialogs
        currently listed in QtInstanceBuilder::IsUIFileSupported.
        
        Change-Id: Iea0c7aa22744cd7652ca6cbc2fbb287bfeaa4ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176305
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [43da73518240138fffac57abc8f3ddf0c2f11664]

        tdf#130857 qt weld: Implement QtInstanceWindow::present
        
        The gtk_window_present doc says:
        
        > Presents a window to the user.
        >
        > This may mean raising the window in the stacking order, unminimizing it,
        > moving it to the current desktop and/or giving it the keyboard
        > focus (possibly dependent on the user’s platform, window manager
        > and preferences).
        
        Therefore, call QWindow::requestActivate [2] for the Qt
        implementation of weld::Window::present.
        
        [1] https://docs.gtk.org/gtk4/method.Window.present.html
        [2] https://doc.qt.io/qt-6/qwindow.html#requestActivate
        
        Change-Id: I1c73dba1675523171a92c760836c6702a81f4c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176303
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [028a5259861ee8b2e922008f362eb3906a2d0b36]

        tdf#130857 qt weld: Signal container focus on window (de)activation
        
        Set QtInstanceWindow as an event filter for it's
        QWidget, and call `signal_container_focus_changed`
        when receiving a QEvent::WindowActivate or QEvent::WindowDeactivate
        event.
        This code path got triggered as expected in a
        quick test switching between e.g. the "Help" -> "About"
        dialog and other windows in KDE Plasma using the Alt+Tab
        shortcut.
        
        The VCL implementation does something similar by
        handling VclEventId::WindowActivate and
        VclEventId::WindowDeactivate events, see
        SalInstanceContainer::HandleEventListener.
        
        For non-top-level containers, a different solution
        will probably be needed.
        For now, adjust the assert in
        QtInstanceContainer::connect_container_focus_changed
        to only trigger for non-QtInstanceWindow containers.
        
        And call the base class implementation, so that the
        handler is actually set for the QtInstanceWindow
        case.
        
        A potential solution for QtInstanceContainer
        might be to connect to the QApplication::focusChanged
        signal in QtInstanceContainer::connect_container_focus_changed
        and in the slot check whether exactly one of the old and
        new focus widgets has the container's widget in
        hierarchy.
        
        Change-Id: I945c8bf0999d93ae91cf25dcffd3fd3ce164d214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176302
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [fe192195566d4de2939827a66ec521b341aa16c6]

        tdf#130857 qt weld: Support "LibreOffice Help Not Installed" dlg
        
        Declare support for the "LibreOfficeDev Help Not Installed"
        dialog that shows when pressing F1 in a build that doesn't
        include the local help.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I25254fd462b867a10e3ed6efc31d9b145466b0f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176299
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [19b09cbc7f9092afadb1ae4902d7d3d7b74c4371]

        tdf#130857 qt weld: Return actual msg dialog ret code
        
        If a synchronous message dialog is closed by means other than clicking
        a button, return the QDialog::exec response code in
        QtInstanceMessageDialog::run, comparable to what already
        happens in the async case (s. QtInstanceMessageDialog::dialogFinished)
        instead of always returning RET_CLOSE.
        
        This is relevant e.g. for the "LibreOfficeDev Help Not
        Installed" dialog that shows when pressing F1 in a build
        not including local help, which will be declared as
        supported in an upcoming commit. That dialog gets
        closed with a response code of RET_YES
        when the link button is clicked, see
        HelpManualMessage's DownloadClickHdl
        (in sfx2/source/appl/sfxhelp.cxx).
        
        Change-Id: Iaa1599dda618e61a5b19264f1984d570a45c6881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176298
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [eb479763e758c3ac2b886dc90272d03b0a63c5fb]

        tdf#130857 qt weld: Always set non-empty link target
        
        In QtHyperlinkLabel::update, always set a non-empty
        string for the link target, as otherwise the text
        in the QLabel will not be a clickable hyperlink, but
        just plain text. While that seems reasonable in general,
        this is problematic as the QtHyperlinkLabel is the widget
        used for QtInstanceLinkButton, and a weld::LinkButton
        should be clickable even if the link target is empty, as
        a custom signal handler can be set that doesn't make use
        of th URI anyway.
        
        Therefore, just set a single space character as the URI
        if the actual one is empty.
        
        This is relevant e.g. for the "LibreOfficeDev Help Not
        Installed" dialog that shows when pressing F1 in a build
        not including local help, which will be declared as
        supported in an upcoming commit.
        
        Change-Id: I1db4c405793109ae9af811d6dd08b1da37246271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176297
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [a43d2aa3bc063d264b5d0a968664f0edb4eedf9f]

        tdf#130857 qt weld: Extract setting label props
        
        Move logic to set "GtkLabel" properties on
        a QLabel to a new helper method
        QtBuilder::setLabelProperties and call it right
        after creating the QLabel for a "GtkLabel", and only
        for that case.
        
        This also prevents potentially overwriting the
        text of a QtHyperlinkLabel widget created for a
        "GtkLinkButton" object in a .ui file, as that
        class also derives from QLabel, but has specialized
        handling for setting the label text to be a hyperlink.
        
        Change-Id: I8bfcc31a503a1c9deec32bcd584e1a86c3dfff19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176296
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [57b6d2d6f15028e1b9966be85abf8271ef6e8594]

        Make Multiplex do what it claims
        
        Since the initial import, it used to only notify the first listener.
        I guess it was just an overlook of using 'if' instead of 'while' in
        the macro code, later flattened.
        
        Change-Id: If2b769e71f937271c004a7152da751b26a2e0f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176293
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-09  Justin Luth  <justin.luth@collabora.com>  [af0946b9eabe49636d5a732aa38bde954a803538]

        tdf#163812 sw: invalidate "Area" properties so sidebar updates
        
        Changes to the background fill were not being updated
        in Writer's sidebar, ever since the introduction in 5.3.
        
        Each of these invalidations can be observed to be necessary
        in the corresponding fill type and fill choice listboxes.
        
        It already worked in Draw, and I don't see anywhere
        this would be needed in Calc
        
        Change-Id: I42f94ee99036761ff69293bcbb44aeda61e1b321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176300
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-09  Pierre F  <fpy@bger.ch>  [259e610c495b8a53d7457ea64f6c4328e303745d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b0473042ff89f94b04e9c7ebe0cfeb5750c2cc4b
          - tdf#143846 split LEFTB LENB MIDB RIGHTB
            
            Change-Id: I57be1c7ea1642ef84798fadc6dd204bbac4c994e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176069
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7e8f74c7e5f0b7d1ae63fca524c12a6e05f33daf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7e9cbf3457ba40fdc2fbdfea743c2d8028e1f548
          - tagalog Add swriter screenshots, remove unused
            
            Change-Id: Ibad461bf00df910a53c7ac618a67a6afaa6a9451
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176304
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c2bb68516180ec2889c79a08d8aef2174cf5d856]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 417ad040381dd1be6e8efa9e07ef22b2f578c7cf
          - Remove ddesktop screenshots (not used)
            
            Change-Id: Iab34bd0e181153be708b7e292dd8562877ae7f12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176301
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [96fb0457f49975a7e9a90eb92442e678b5d279ba]

        gpgme: Upgrade to 1.24.0
        
        * external/gpgmepp/gettid.patch fixes
        /opt/rh/gcc-toolset-12/root/usr/libexec/gcc/x86_64-redhat-linux/12/ld: ./.libs/libgpgme.so: undefined reference to `gettid'
        
        * external/gpgmepp/strcasecmp.patch fixes
        libgpgme.lib(key.obj) : error LNK2019: unresolved external symbol _strcasecmp referenced in function __gpgme_key_append_name
        
        Downloaded from https://www.gnupg.org/ftp/gcrypt/gpgme/gpgme-1.24.0.tar.bz2
        
        Change-Id: I2f2587f5157db7610d6ffaa84b49f9677ba1cc4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176160
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [383067b41647e70e0a304bddf529aacfe015099f]

        be conservative on allowed temp font names
        
        Change-Id: Iefdc1a8c9b4c7e8c08c84f747f8287ac3c419839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176286
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-08  Miklos Vajna  <vmiklos@collabora.com>  [12e50825370dae276d44bea84b3eb2941b401220]

        cool#9992 lok doc sign, hash extract: initial getCommandValues('Signature')
        
        The trouble with signing via ca/cert/key PEM files is that usually the
        CA is not trusted by the received of the signature. 3rd-party services
        are available to do generate trusted signatures, but then you need to
        share your document with them, which can be also problematic.
        
        A middle-ground here is to sign the hash of the document by a 3rd-party,
        something that's supported by e.g.
        <https://docs.eideasy.com/electronic-signatures/api-flow-with-file-hashes-pdf.html>
        (which itself aggregates a number of providers).
        
        As a first step, add LOK API to get what would be the signature time
        during signing -- but instead of actually signing, just return this
        information. Once the same is done with the doc hash, this is supposed
        to provide the same info than what the reference
        <https://github.com/eideasy/eideasy-external-pades-digital-signatures>
        app does.
        
        This is only a start: incrementally replace XCertificate with
        SignatureContext, which allows aborting the signing right before calling
        into NSS, and also later it'll allow injecting the PKCS#7 object we get
        from the 3rd-party.
        
        Change-Id: I108564f047fdb4fb796240c7d18a584cd9044313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176279
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [e44f566a2c901d9c761759a20bbd767f18795d5b]

        tdf#163802 cui: Don't set temporary title for spelling dialog
        
        The window title set using SpellingDialog::SetTitle_Impl
        was overwritten right away by the next call to
        `m_xDialog->set_title(...)`, so was never meant to be used
        in practice anyway.
        
        The
        
            // use this function to apply the correct image to be used...
        
        comment suggests that SpellingDialog::SetTitle_Impl also
        sets some image, which was actually the case when the code
        was initially introduced in
        
            commit d32b3a714fe55892bdead03502c5a9b0e77fa61d
            Author: Mathias Bauer <mba@openoffice.org>
            Date:   Sat Oct 31 00:36:06 2009 +0100
        
                #i106421#: move svx/source/cui to cui
        
        , but that's no longer the case since
        
            commit bc3c10b5ce88869871761000e9724bcad9a0d556
            Author: Cédric Bosdonnat <cedric.bosdonnat@free.fr>
            Date:   Sun Oct 23 07:35:06 2011 -0700
        
                Grammar checking dialog: reworked how explanations are shown
        
        , so there's no more reason to call SpellingDialog::SetTitle_Impl
        before setting the actual title.
        
        Change-Id: I56d7478271b53a6ec033a8ead9b05d3eff6ad5b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176256
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [0f55739a75b418ff1b08abff2b8eaead2df8c997]

        Simplify using WeakImplHelper and OMultiTypeInterfaceContainerHelperVar4
        
        Change-Id: Ib83b93d6055d3006eecdb25f1ccd7baf1251a40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176284
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [774fe4b443f3ce5224522219c444fabc4608b8fd]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d1696029d8923ae697cb2d6d4d7d69791b1943f2
          - Upgrade Mongolian dictionary to 2024.11.08
            
            Downloaded from https://github.com/bataak/dict-mn/archive/refs/tags/2024.11.08.zip
            
            Change-Id: I5f3159f2162690cfd5c7f48cf3793fdbd4e2a6e6
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/176291
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-11-08  Batmunkh Dorjgotov  <bataak@gmail.com>  [ec1dc5c2397d843757db94bc415b767b26f2c174]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e9052a7afc28c3f8ef24dcc8a29f59da6c3ac5e5
          - Add license statement and update hyphenation rules
            
            Change-Id: Ie5fb948541f618a7ec3fc8bba1afdaa85bb2d707
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/164311
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-11-08  Batmunkh Dorjgotov  <bataak@gmail.com>  [7a2888ff37e39c5dab5c82e751851cc444ca2cc3]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 40d2ad1687d5a8450eba9dc2f24ec8822d8af37c
          - Update Mongolian dictionary
            
            Change-Id: Ide7f5149abacc1c9c043a551c0a4771b03c9cec8
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/161705
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-11-08  Miklos Vajna  <vmiklos@collabora.com>  [899089ddfb8c190af2e1d77536c99a30adbc2938]

        vcl: fix crash in findAnnotations()
        
        Crashreport signature:
        
        > SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
        > program/libmergedlo.so
        > 	vcl::ImportPDFUnloaded(rtl::OUString const&, std::vector<vcl::PDFGraphicResult, std::allocator<vcl::PDFGraphicResult> >&)
        > 		vcl/source/filter/ipdf/pdfread.cxx:335
        > program/libsdlo.so
        > 	SdPdfFilter::Import()
        > 		sd/source/filter/pdf/sdpdffilter.cxx:55
        > program/libsdlo.so
        > 	sd::DrawDocShell::ConvertFrom(SfxMedium&)
        > 		sd/source/ui/docshell/docshel4.cxx:502 (discriminator 2)
        > libmergedlo.so
        > 	SfxObjectShell::DoLoad(SfxMedium*)
        > 		sfx2/source/doc/objstor.cxx:786
        
        I.e. in case we search for a marker image inside the annotation's
        object, then handle the image type without a bitmap the same as
        non-image types.
        
        Change-Id: I443b5f448ea4544183fb4ed0b457e85a45f51acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176282
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [5962006370e818798099c75c21a392ee57e5b876]

        loplugin:reftotemp in dbaccess..editeng
        
        Change-Id: I51f5e47fb2fca37928ac58952a6a34b7351ca53c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176277
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-08  Michael Stahl  <michael.stahl@allotropia.de>  [d79790da8a4de4758f46ae4a8573382c681af974]

        tdf#162944 package: add test file
        
        Change-Id: Ie689e8dff3405fc2a0da3791089d077db8bf59b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176288
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-08  Szymon Kłos  <szymon.klos@collabora.com>  [cc76bf80760aa8e6d7e406cd76919f8e44ae506e]

        sidebar: move apply to all slides above repeat settings
        
        Button "apply to all slides" setups properties selected above
        to all the slides. Repeat options are common to the whole
        presentation. Let's move repeat section to the bottom so it
        is less confusing
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I19bb8d10c3969ceb033e2a6d26489999bb7451c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174357
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176283
        Tested-by: Jenkins

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fe9b3df62aebe68eed2daa4625b6f360b925a74]

        loplugin:reftotemp in codemaker..connectivity
        
        Change-Id: I9da2976410f7c4da8ab0d85150fc87f2b3df9e0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f691b4a160b2ed1bb503c5b52e925bfa974e1e5]

        loplugin:reftotemp in cppcanvas..cui
        
        Change-Id: I6c9ded2252462bcdeee6520bb7b7fa1752aa583b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176276
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [39b15dc8f0adec9e856a39cf319c7c8ae6750043]

        tdf#155447 a11y: Add test for accessible IDs expected by Orca
        
        Add a new AccessibilityTools::getAccessibleObjectForId
        helper that can be used in a11y tests to identify an object
        by its accessible ID.
        
        Add a test that checks that the accessible ID of the
        spelling dialog matches what Orca's logic expects
        in order to identify it, and that more UI elements
        with expected accessible IDs exist.
        
        This is to prevent breaking Orca logic without noticing.
        Any changes affecting this test should be discussed with
        the Orca maintainer first.
        
        See the comment above the newly added test for more details
        and a link to the corresponding Orca commits.
        
        The new test initially only checks that objects with corresponding
        IDs exist, could be extended to verify more of their
        properties as needed.
        
        Logic for checking availability of a dictionary, needed for
        spell check was taken over from the existing tdf155705 test in
        sw/qa/extras/accessibility/tdf155705.cxx, whose sample doc
        is also used.
        
        Change-Id: I0c5629272a89a4a570e080e62e99b6c105369cf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176281
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [4b7316e2ff6e63bbf73e0bcf04f90b807d9829ad]

        tdf#155447 a11y: Set accessible ID that Orca expects
        
        Orca commit [1]
        
            commit 40a2d302eb52295433fd84e6c254a7dbe5108a24
            Author: Joanmarie Diggs <jdiggs@igalia.com>
            Date:   Thu Nov 7 14:15:07 2024 +0100
        
                Spellcheck: Check for accessible id in more places
        
                Do the following case-insensitive checks:
                * If the object's accessible id starts with "suggestions" treat it
                  as the suggestions list.
                * If the object's accessible id starts with "replacement" treat it
                  as the object (likely entry) which contains the proposed replacement.
                * If the label's/widget's accessible id starts with "error" treat
                  it as the container displaying the misspelled word.
        
                Note that the first of the three is based on what LO 25.2 currently
                exposes ("suggestionslb"). The other two are not in use yet, but adding
                them facilitates implementation in, and getting feedback from, apps and
                toolkits.
        
                Also modify the existing check for the window. We were doing an exact
                match on "SpellingDialog". Making that case insensitive and limiting to
                starts with "spelling" works with the current LO implementation and
                removes an implementation detail ("dialog").
        
        introduced logic to identify more UI elements in the spelling
        dialog by their accessible ID.
        
        Adjust the GtkBuilder ID (which gets reported as accessible ID as well)
        of the drawing area that holds the misspelt text to match the
        expectations as mentioned in the commit message above.
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24
        
        Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-08  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [65606ffdb9fbb133b7c771184fa97284fe6f2c91]

        Refactor focus handling in `LevelHdl` and `SwTokenWindow`
        
        - Added a new `LevelHdlImpl` method with a `bool bGrabFocus` argument.
        - Refactored `LevelHdl` to call `LevelHdlImpl` with `true`.
        - Adjusted `SwTokenWindow::SetActiveControl` and `SwTokenWindow::SetForm` to skip `GrabFocus` when the argument is `false`.
        - Ensured focus behavior remains unchanged except for the initial "ActivatePage".
        
        Change-Id: If2f43e43f94c3762acd93974550ff0d2d66c6c21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174423
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit dbb054045fae8605794c17aae052a9d588fe33fc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175996
        Tested-by: Jenkins

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dcfec9756c17689791b8dbc3495146ff6cc1fbb4]

        cid#1555255 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556766 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie11d0279ec775034ee8e5a14b0e57eaed110fda6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176265
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed0b12f4eadf1f2242f06cbd56804f75376274b1]

        no need to take a copy of the getProcessComponentContext return value
        
        we can just take a "const &".
        
        (found by running clang-tidy with the
        performance-unnecessary-copy-initialization warning)
        
        Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-08  Jaume Pujantell  <jaume.pujantell@collabora.com>  [5ff283e3b841230a45715e48a251c3c4216d1cec]

        tdf#163803 oox: export fill on graphic object
        
        The fill contents of a graphic object are lost when saving a pptx.
        
        Change-Id: I055d778d4a92de18dfec59bd27c63a20c08b99f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176208
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit dfd8caa6c49bd33f549a37d6c0244e4cce8f16d8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176224
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2024-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [ca9e939f9481a092ca585da292d03c1c3308ed7f]

        expat: upgrade to 2.6.4
        
        Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_6_4/expat-2.6.4.tar.xz
        
        Change-Id: I9ae3b6e586847e8ba0439f1c42baa13a1e2cf427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176271
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c250130e576815b7d6d1645a7163e71550fd72f]

        remove dead code
        
        since
            commit 9cef1d069a21cb821b1ef880da0358aa2a959a40
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Sep 12 13:32:21 2023 +0200
            loplugin:unodispose in UnoControls
        
        Change-Id: I36b0bcdeb61dda176ac6778ef1116378d40531f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176264
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [05b9dd6ec67c91a03cd7339b6c10e0e06a96f08e]

        cid#1620539 Check of thread-shared field evades lock acquisition
        
        Change-Id: Ifd0008d8258b7fe9e72d40ae0384ff9f5e538190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-08  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [db0f9087e4a075bb319a4153e9dab621be42c61e]

        lok: disabled misc shape wipe non supported transition
        
        Change-Id: I1a2f67e20fb39a711a6da41ee1152499cf91c28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176266
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [21edde763dfc0c511421993ca6168730232f9f8e]

        Related: cid#1608068 Data race condition
        
        Change-Id: I10c6dd9c12c7558d1d71f39580b3fa470efe69e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176262
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [b61e0f2b53448debace84083550be228da06c1a6]

        loplugin:reftotemp in canvas
        
        Change-Id: I0a038cf32e05dab59b1cedcf06ecd38b48d76feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [df439565c81967872366c40a0d6a17361efea6ec]

        cid#1608068 Data race condition
        
        Change-Id: Iec72c56e1d58cbcd6463aa98e8d99d6c469c9dd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176261
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d86360c7d0ed6cfd35f9d64503d019922b3333ee]

        cid#1608267 silence Overflowed constant
        
        Change-Id: I10dfd5953e8f481c12111e2b541fece6aa2897e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [06221a8c08e8898491a73ac8c6cbb42410f768a8]

        cid#1634530 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iae03c8a982659503d7f73dbabbcece7bdb9c8e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176259
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [342483965ded93b1ba3a0675f612c884a1412d50]

        update credits
        
        Change-Id: Ia11d85351922cb190a7ae53d2510fa390a46e0e2

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3856dfc8a651725644b9705984cc1765df78e83]

        loplugin:reftotemp in chart2
        
        Change-Id: I0ce3c76e873921f04897955b62cc9c4cb15a5a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c518196d6f276a2651aa9720e2bbc69e87b2009]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 19979894c0f72f6ad2afb061d5cbd33167cb2946
          - Remove dbaccess screenshots (not used)
            
            Change-Id: Ibdfb28c3d844a7aad6187c23c892b2b02d968f3a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176251
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-08  Heiko Tietze  <tietze.heiko@gmail.com>  [0b7d01a1a20b291e5c0ca3082c7714a565381f4d]

        Related tdf#74386 - Improvements for text boundaries options
        
        * Default is Crop Marks now
        * Settings are persistent
        
        Change-Id: If5304c874706345fa943a106044155152c86bc0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176131
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-08  Patrick Luby  <guibmacdev@gmail.com>  [1e99b33b9ab77874a3483ce6e192a58842794f2a]

        Revert commit 2fe53b2e436cb236b2dc121ceec4f22de49a13a8
        
        Commit 709b1f3ddb87303a2dec6155dbe0106369c151ed fixes the
        root cause of the crash during a dynamic_cast so revert
        commit 709b1f3ddb87303a2dec6155dbe0106369c151ed as it was
        merely a workaround and is no longer needed.
        
        Change-Id: Ia052913eba7fd4d979054ea6a644f4ff9791277c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc9b55e8a8f8b8dbc81d17712cd848b1a6dfb206]

        loplugin:reftotemp in basic
        
        Change-Id: I41385d279cc81de9b5b2e9ff55b0b5c2f40aba66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176244
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4e9d1d8000321c6bcd591989f4ce4b68553cb86]

        loplugin:reftotemp in basctl,basegfx
        
        Change-Id: Ifbc294320cd717892544133e976ff776a0fdbd6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176243
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [aae76f4df1d4a554fa16c05a28d2e1d10ea558af]

        tdf#130857 vcl: Move weld::Window::{g,s}et_modal to weld::Dialog
        
        All calls to get_modal and set_modal are done for weld::Dialog
        instances, never for plain instances of/pointers to the weld::Window
        base class.
        
        Therefore, drop the methods from weld::Window and add them weld::Dialog
        instead.
        
        SalInstanceDialog was already overriding the SalInstanceWindow
        implementations of both methods.
        
        For QtInstanceWindow, these were not implemented yet, while
        QtInstanceDialog already has implementations.
        (If there were a real need, they could be implemented using
        QWidget::isModal/QWidget::windowModality and
        QWidget::setWindowModality.)
        
        For GTK, move the GtkInstanceWindow::get_modal implementation
        to GtkInstanceDialog and call gtk_window_set_modal directly
        instead of GtkInstanceWindow::set_modal in
        GtkInstanceDialog::set_modal.
        
        Change-Id: I71431347f3bca9571c6fd4b7cf995bb79fb5b11d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176252
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [7ede3b80bc9ce7c99637f4d2bbc9662cf1b77b65]

        tdf#130857 qt weld: Support Calc "Insert Cells" dialog
        
        Declare support for Calc's "Sheet" -> "Insert Cells..."
        dialog.
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and starting LO with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I73e514785d6e645f3c3a59a154eeb64e2b308418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176250
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [87bb5caf96d563c1dab38983d6e6f7b4453bab72]

        tdf#130857 qt weld: Support sw "Table" -> "Insert" -> "Rows" dialog
        
        Declare support for this dialog seen in Writer when
        taking the following steps:
        
        * start Writer
        * insert a table using "Table" -> "Insert Table" -> "Insert"
        * "Table" -> "Insert" -> "Rows..."
        
        This means that native Qt widgets are used for that dialog
        now when using the qt5 or qt6 VCL plugin and LO gets started with
        environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog makes use of QtInstanceSpinButton
        added in the previous commit.
        
        Change-Id: I0ecdf371278c86ddb8d841b1a95c38c52f53d8d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176249
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [ea790b37d991b6db818ff75f9d28ad10ef865810]

        tdf#130857 qt weld: Add initial SpinButton support
        
        Add new class QtInstanceSpinButton that is the
        weld::SpinButton implementation using native
        widgets. Initially, implement the actual logic
        of only some methods, and let the others trigger
        an assert for now. (These can be implemented once
        needed to support more dialogs.)
        
        Initially, assume that the value is an integer
        (which is the case for the "Table" -> "Insert"
        -> "Rows" dialog in Writer, for which support
        will be declared in an upcoming commit).
        However, already use a QDoubleSpinBox
        that supports floating point values instead
        of QSpinBox (that can only handle integer values)
        to prepare for extending the implementation
        accordingly later.
        
        In QtBuilder, handle "GtkSpinButton" objects,
        create a QDoubleSpinBox for them and evaluate
        the "digits" and "adjustment" properties to
        set the corresponding values for the
        QDoubleSpinBox.
        
        Let QtInstanceBuilder::weld_spin_button
        return an instance of the newly added
        class.
        
        Change-Id: I0808589a3e6bece749c0ae4541f2419410ea99bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176248
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-08  Michael Weghorn  <m.weghorn@posteo.de>  [a6dde76b2d29c33045d79cc2a69a01c6f3d96f2c]

        cui: Resave insertrowcolumn.ui with glade 3.40
        
        Change-Id: I0fd60e103be55b773274c830441a46f2a14c5980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176247
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [00b15057a39989dee9f14c76236ba140aa2bfa66]

        Simplify using WeakImplHelper / ImplInheritanceHelper
        
        Change-Id: Ieb3b8e07e0361da89da5b4a6db9e3c45389b636f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176200
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [9d6e1594a298c9d41f3dc64ad80edf4b9868c2e8]

        Deduplicate and unify using vcl::GetBitmap
        
        Change-Id: Ie940990b604cf23c961aa5b6fad124f1ebaf338c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176186
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [ef261d4e80e784519a94b23f78ca4fb42d8bcbd9]

        Factor out conversion of awt::XBitmap to BitmapEx in vcl
        
        As a step to unify and deduplicate this in several places.
        Three functional changes added to the new vcl::GetBitmal function:
        
        1. The mask is inverted from transparency to alpha, as done in
           VCLUnoHelper::GetBitmap (toolkit/source/helper/vclunohelper.cxx)
           since commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 (Convert
           internal vcl bitmap formats transparency->alpha (II), 2023-07-25).
        
        2. When awt::XBitmap::getMaskDIB returns no mask, use
           ReadDIBBitmapEx to also try to read the alpha inside the data
           in awt::XBitmap::getDIB, as done in InsertSubMenuItems
           (framework/source/fwe/helper/actiontriggerhelper.cxx).
        
        3. As an optimization, query awt::XBitmap for graphic::XGraphic
           before all the bit processing.
        
        Change-Id: I686751664a5bd612bda1d446b200a9386b1991b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176185
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d251b5b65a4b250f97542a2a26c14081724aebc0]

        Simplify a bit
        
        And drop unneeded solar mutex locks, that were used when the menu
        implementation was accessed directly.
        
        Change-Id: I06d3d872343fdd6204b4e8bbd8bcec67c17fdbe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176199
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d833992e7e06f7d385fca6ffe35ce66b79360a63]

        Avoid checking exact interface type of Any value
        
        Change-Id: Ic883c3a9fd8eb87469aec6b6570a39aadf575c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176184
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [56f3dbffdf5b3264c1c71201733e3ff6bb5e48cb]

        Simplify a bit
        
        Change-Id: I618b0f8bcb2e8032ee12367c73e1136685f66b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176183
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-08  Justin Luth  <justin.luth@collabora.com>  [27f7770e3e9be60b0caef8469666474151a753fb]

        tdf#95852 sd: not TopViewShell if mbFormShellAboveParent
        
        This fixes a 5.0 regression from
        commit 967a386bccb15b99915a1e878e42450fbe9a2d0e
        on Wed Nov 5 20:15:32 2014 +0100
            Fix for SUSE L3 bug 624546 (freedesktop 83733)
        
        Change-Id: Id5ec9a853f8abcc329d03434cd6cfcf35195bd2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176086
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-11-07  László Németh  <nemeth@numbertext.org>  [42533c94ec1a52c49b2587e53ab55e67fc4a449a]

        tdf#163720 sw smart justify: fix hyphenated single portion lines
        
        Hyphen length wasn't calculated in single portion lines at shrinking,
        because the width of the overhanging line without the hyphen overwrote
        the calculated correct line width. This resulted less shrinking, than
        needed, also lost hyphen in the PDF export.
        
        Regression from commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46
        "tdf#162220 sw smart justify: fix shrinking for single portion lines".
        
        Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I512e7f1f86f80ff6ea3d0b6a0b0db8255f5d0a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176207
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fdfc074c93447f9eb1c9a351ee4690126ba782c]

        loplugin:passstuffbyref make some small improvements
        
        Change-Id: Ib14a2e6b41165887fcf99c3d155850faa8564822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fe2b2545da977cd462c06e2a6ec6551b9903497]

        don't deref null m_pDocShell
        
        in the case of a failed load m_pDocShell is null and continuing
        is pointless.
        
         #0  0x00007efca0f0b157 in SwDocShell::GetView (this=0x0) at sw/inc/docsh.hxx:223
         #1  SwXTextDocument::getViewRenderState(SfxViewShell*) () at sw/source/uibase/uno/unotxdoc.cxx:3448
         #2  0x00007efcaec1d252 in doc_getCommandValues () at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/allocator.h:174
         #3  0x00000000005d8195 in lok::Document::getCommandValues (pCommand=0xb1ba39 ".uno:ViewRenderState", this=<optimized out>)
             at include/LibreOfficeKit/LibreOfficeKit.hxx:492
         #4  Document::load(std::shared_ptr<ChildSession> const&, std::string const&) () at kit/Kit.cpp:2012
         #5  0x00000000005da582 in Document::onLoad(std::string const&, std::string const&, std::string const&) () at kit/Kit.cpp:1227
        
        Change-Id: I5bc1415b06de4aea6a950486840e45773e61b78d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176221
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-07  Michael Stahl  <michael.stahl@allotropia.de>  [0f39e6fbb48dae29778c305ddd576d698a8251ad]

        tdf#162944 package: try to detect Zip64 via version
        
        https://rzymek.github.io/post/excel-zip64/ claims that it's sufficient
        for the version number to be 45 (4.5 - File uses ZIP64 format
        extensions) for Excel to read a zip entry's data descriptor as
        Zip64, while the Zip APPNOTE seems to require a zip64 extended
        information extra field to be present (see 4.3.9.2).
        
        Let's try to use the "version needed to extract" to be able to read
        zip files produced by Apache POI Zip64Mode.Always.
        
        Change-Id: I20f10471e3a85eb42d21c0cb08e36e345ef8fc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176211
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [138ff29f7e7cb504f2c8d6b30df56494687d443f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b566e3c0954b34d9f47c12f13c95e72b7b5ef1e
          - Removed exec bits on png files
            
            Change-Id: Ib0554a4197d2bd4aa5ee0a356e7e94f7c608e806
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176191
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Jenkins
            
2024-11-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2422e3a61f9dcaa8db8508f9fa679faff258028b]

        Remove duplicated includes
        
        Change-Id: Ia2c87a349df5bd4cca7cc632806b183ad64d1158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176192
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [d30d8f5f1c1f9af52dfb909c8baf8c697495d984]

        loplugin:passstuffbyref in sw
        
        Change-Id: I22f4f4a0f2729b953669322eda803ce298eea236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9395912202940a0b499a19f905177d35963f3b9]

        loplugin:passstuffbyref in sd
        
        Change-Id: I95a95b8962bf1d168fee92943c611ce70abf3cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176201
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1ecd89204925c80454a9f9f33a02430f33cb498]

        loplugin:passstuffbyref in ucb..xmlsecurity
        
        Change-Id: I734a4ca69e1b2770613beb3a05d770b7fc7343b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [6d6d11a2d26dfc5f4320bd7523ebbe61759eda8c]

        use more concrete UNO type in connectivity::ado
        
        Change-Id: I4a23e8847496166f1f9668830b97c71a248dd143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [8d0a0bc4d4bc9d6b453f98164c4ab33d0afa91f9]

        use more concrete UNO type in connectivity::ado
        
        Change-Id: Ia9bc0e4aade832373def4460e44750be4415967d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176205
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [2de45b85574063cfef3d6ccddc9efe959a8b1076]

        loplugin:passstuffbyref in cui..dbaccess
        
        Change-Id: Ie15974919f7c0764e661225ef14a9f50917ab083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176189
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [05dafbdc9d7e6755d67d63e58cec3cc1f9038848]

        cid#1634480 Use of auto that causes a copy
        
        and
        
        cid#1634481 Use of auto that causes a copy
        
        Change-Id: Ia301cc4ffae4ad451dfafb90c63cc8feb0eb0ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176194
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [33d4760998ccdb45dba13f0de9b6e599b38f2ba2]

        loplugin:passstuffbyref in lotuswordpro..pyuno
        
        Change-Id: I9cd7a98d74b1896951124740b66d873ca41cceae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176197
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-07  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [eb9174ac49fa69a2bfe33da7773c5aeb1d8c00cf]

        lok: enable MiscShapeWipe transition and sub-tras. Heart, FanOutHoriz.
        
        Change-Id: I6511da17b3222bc83c0870f100fb7e8eafc78bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176182
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd77b743a703daa09563218cc8158db0ca2a4b97]

        loplugin:passstuffbyref in sc
        
        Change-Id: Ic3ce1406aa2567ca676bb8f431c52f590fadaec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176198
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54f5e44f580aa3eb8c498f27049f0f7e92ba2ffe]

        cid#1606697 silence Overflowed constant
        
        Change-Id: I81d0b10f8e0c34f9d276e59b5eed2c3d879f05cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176195
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ec7e5bb895a1d8ac4c5fc9e1d2855d189f3685a]

        cid#1555009 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555173 COPY_INSTEAD_OF_MOVE
        cid#1555255 COPY_INSTEAD_OF_MOVE
        cid#1556619 COPY_INSTEAD_OF_MOVE
        cid#1556766 COPY_INSTEAD_OF_MOVE
        cid#1557131 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia581e7858d8ff4db08308b4118116781db1464a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176193
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e496ce2cf63daf792393bdb2b4881c77c095319]

        loplugin:passstuffbyref in forms..framework
        
        Change-Id: Ib5a013df49d532b139acd881127cfc82c7c5a6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [709b1f3ddb87303a2dec6155dbe0106369c151ed]

        Make sure VCLXPopupMenu has unique RTTI
        
        ...by providing a non-inline key function for that class.  This would have
        prevented the issue that has been addressed by
        2fe53b2e436cb236b2dc121ceec4f22de49a13a8 "Fix crash due to unexpected
        dynamic_cast failures in optimized build", where a dynamic_cast to VCLXPopupMenu
        failed on macOS (which uses pointer equivalence to determine RTTI equivalence),
        because VCLXPopupMenu is final, so the compiler, at least in optimized builds,
        just used a comparison between the object's recorded RTTI (from dylib A) against
        the type's RTTI in dylib B, which erroneously failed.
        
        Change-Id: I68ff864c266bf28d19032527f91de592ca1437f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176188
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e1207c9def3af1b979b57c3d19c51a2c33ecf2d]

        loplugin:passstuffbyref in chart2..connectivity
        
        Change-Id: Ic2c6606ea0ce1d5c3089bc4c1a879fed3f2c7aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [91106b5b6153f324399f4fbb74b0f90c6eccc7ec]

        loplugin:passstuffbyref in avmedia..canvas
        
        Change-Id: I916a6431eb0720af16dcb5aa46b758f92dbe4ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [e5570ce8e936ab07e5f5f676d7043d8f32bf7306]

        tdf#130857 qt weld: Don't set negative min width/height
        
        While gtk_widget_set_size_request supports -1 for the width/height
        as a special value to unset the requested minimum width/height [1],
        Qt doesn't, and warns when this gets passed.
        Therefore, ensure not to use negative values.
        
        [1] https://docs.gtk.org/gtk3/method.Widget.set_size_request.html
        
        Change-Id: I4ad6a3fa149138bcfdfeede1f2dc1bdfc5425e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176178
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [37c6c3bdcdeed22e99fd89dbd2cfa3d8fda75f09]

        tdf#130857 tipofthedaydialog.ui: Move checkbox out of button box
        
        Move the checkbox in the "Help" > "Show Tip of the Day"
        dialog above the button box rather than having it inside
        of the button box.
        
        That is consistent with e.g. the "LibreOfficeDev Help not installed"
        dialog that gets shown when pressing F1 in a build not including
        the local help, and it makes this work with the native Qt version
        of the dialog (SAL_VCL_QT_USE_WELDED_WIDGETS=1) which doesn't support
        arbitrary widgets inside of the button box.
        
        Change-Id: I79541d986df31325b43a17dbec81466ec8bfdca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176177
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [ce5f743b1f6333f15451bf1b9e8789bababcd303]

        cui: Resave tipofthedaydialog.ui with glade 3.40
        
        Change-Id: Icad97adfd0c4cb50a12ba8eda25d3802ed00dc55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176176
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [226980d063858d3d21096e5ed73b5312ef0728d7]

        tdf#130857 qt weld: Take SolarMutex in QtInstanceLinkButton::linkActivated
        
        Apparently the expectation is that the SolarMutex
        is held when calling weld::signal_activate_link.
        At least, not doing so would trigger an assert when
        clicking a hyperlink in the "Help" -> "Show Tip of the Day"
        dialog when using the qt6 VCL plugin started with
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 set:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7f083869de5c
            2 __pthread_kill_internal pthread_kill.c 78 0x7f083869debf
            3 __GI_raise raise.c 26 0x7f0838649c82
            4 __GI_abort abort.c 79 0x7f08386324f0
            5 __assert_fail_base assert.c 94 0x7f0838632418
            6 __assert_fail assert.c 103 0x7f0838642592
            7 ImplDbgTestSolarMutex dbggui.cxx 35 0x7f082fa2dd3e
            8 DbgTestSolarMutex debug.cxx 54 0x7f0837b2bec0
            9 vcl::WindowOutputDevice::AcquireGraphics window.cxx 822 0x7f082f306276
            10 OutputDevice::IsNativeControlSupported nativecontrols.cxx 139 0x7f082f584492
            11 vcl::Window::IsNativeControlSupported window3.cxx 77 0x7f082f2fd8b9
            12 Dialog::ImplInitSettings dialog.cxx 524 0x7f082f167189
            13 Dialog::ImplInitDialog dialog.cxx 495 0x7f082f167086
            14 Dialog::Dialog dialog.cxx 586 0x7f082f167d92
            15 MessageDialog::MessageDialog layout.cxx 2521 0x7f082f1df4a6
            16 VclPtr<MessageDialog>::Create<vcl::Window *&, long&> vclptr.hxx 129 0x7f082f0e8fa6
            17 VclBuilder::makeObject builder.cxx 1605 0x7f082f0c5326
            18 VclBuilder::insertObject builder.cxx 2454 0x7f082f0d09eb
            19 WidgetBuilder<vcl::Window, VclPtr<vcl::Window>>::handleObject widgetbuilder.hxx 213 0x7f082f145937
            20 WidgetBuilder<vcl::Window, VclPtr<vcl::Window>>::handleChild widgetbuilder.hxx 107 0x7f082f0f13ce
            21 WidgetBuilder<vcl::Window, VclPtr<vcl::Window>>::processUIFile widgetbuilder.hxx 49 0x7f082f0e1b78
            22 VclBuilder::VclBuilder builder.cxx 520 0x7f082f0ba596
            23 SalInstanceBuilder::SalInstanceBuilder salvtables.cxx 7088 0x7f082fa7b318
            24 std::make_unique<SalInstanceBuilder, vcl::Window *&, rtl::OUString const&, rtl::OUString const&> unique_ptr.h 1077 0x7f082fa99ef9
            25 SalInstance::CreateBuilder salvtables.cxx 7470 0x7f082fa7f468
            26 QtInstance::CreateBuilder QtInstance.cxx 843 0x7f08254e89e5
            27 non-virtual thunk to QtInstance::CreateBuilder(weld::Widget *, rtl::OUString const&, rtl::OUString const&) 0x7f08254e8a4c
            28 Application::CreateBuilder builder.cxx 198 0x7f082f0b7f02
            29 weld::MessageDialogController::MessageDialogController weldutils.cxx 65 0x7f082fb52635
            30 (anonymous namespace)::HelpManualMessage::HelpManualMessage sfxhelp.cxx 958 0x7f0834939fb0
            31 SfxHelp::Start_Impl sfxhelp.cxx 1283 0x7f08349369ec
            32 SfxHelp::Start sfxhelp.cxx 642 0x7f08349389fe
            33 TipOfTheDayDialog::OnLinkClick tipofthedaydlg.cxx 261 0x7f07b37ebb64
            34 TipOfTheDayDialog::LinkStubOnLinkClick tipofthedaydlg.cxx 251 0x7f07b37eb99d
            35 Link<weld::LinkButton&, bool>::Call link.hxx 111 0x7f082552dc26
            36 weld::LinkButton::signal_activate_link weld.hxx 1688 0x7f082552d95c
            37 QtInstanceLinkButton::linkActivated QtInstanceLinkButton.cxx 58 0x7f082552ba6d
            38 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QtInstanceLinkButton:: *)(QString const&)>::call(void (QtInstanceLinkButton:: *)(QString const&), QtInstanceLinkButton *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7f082552e074
            39 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QtInstanceLinkButton:: *)(QString const&)>::call(void (QtInstanceLinkButton:: *)(QString const&), QtInstanceLinkButton *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QtInstanceLinkButton:: *)(QString const&)>::call(void (QtInstanceLinkButton:: *)(QString const&), QtInstanceLinkButton *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7f082552df99
            40 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QtInstanceLinkButton:: *)(QString const&)>::call qobjectdefs_impl.h 126 0x7f082552ded3
            41 QtPrivate::FunctionPointer<void (QtInstanceLinkButton:: *)(QString const&)>::call<QtPrivate::List<QString const&>, void> qobjectdefs_impl.h 174 0x7f082552de4d
            42 QtPrivate::QCallableObject<void (QtInstanceLinkButton:: *)(QString const&), QtPrivate::List<QString const&>, void>::impl qobjectdefs_impl.h 545 0x7f082552dd76
            43 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7f082465ab72
            44 doActivate<false> qobject.cpp 4127 0x7f0824718ee4
            45 QMetaObject::activate qobject.cpp 4187 0x7f082470eb83
            46 QLabel::linkActivated moc_qlabel.cpp 386 0x7f08228ddb72
            47 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QLabel:: *)(QString const&)>::call(void (QLabel:: *)(QString const&), QLabel *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7f08228e29a8
            48 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QLabel:: *)(QString const&)>::call(void (QLabel:: *)(QString const&), QLabel *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QLabel:: *)(QString const&)>::call(void (QLabel:: *)(QString const&), QLabel *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7f08228e291d
            49 QtPrivate::FunctorCall<std::integer_sequence<unsigned long, 0ul>, QtPrivate::List<QString const&>, void, void (QLabel:: *)(QString const&)>::call qobjectdefs_impl.h 126 0x7f08228e28d7
            50 QtPrivate::FunctionPointer<void (QLabel:: *)(QString const&)>::call<QtPrivate::List<QString const&>, void> qobjectdefs_impl.h 174 0x7f08228e2841
            51 QtPrivate::QCallableObject<void (QLabel:: *)(QString const&), QtPrivate::List<QString const&>, void>::impl qobjectdefs_impl.h 545 0x7f08228e276b
            52 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7f082465ab72
            53 doActivate<false> qobject.cpp 4127 0x7f0824718ee4
            54 QMetaObject::activate qobject.cpp 4187 0x7f082470eb83
            55 QWidgetTextControl::linkActivated moc_qwidgettextcontrol_p.cpp 806 0x7f0822a5a415
            56 QWidgetTextControlPrivate::activateLinkUnderCursor qwidgettextcontrol.cpp 2962 0x7f0822a544c1
            57 QWidgetTextControlPrivate::keyPressEvent qwidgettextcontrol.cpp 1242 0x7f0822a50454
            58 QWidgetTextControl::processEvent qwidgettextcontrol.cpp 1024 0x7f0822a4f23b
            59 QWidgetTextControl::processEvent qwidgettextcontrol.cpp 984 0x7f0822a4f0c1
            60 QLabelPrivate::sendControlEvent qlabel.cpp 1557 0x7f08228db3c4
            61 QLabel::keyPressEvent qlabel.cpp 912 0x7f08228db7fe
            [...]
        
        Change-Id: I20f11ff2e7c00e65098bd7fb39afefdc4a622138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176175
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [473dccf597c551a03ae02a94a1a2f846ac0e6868]

        tdf#130857 qt weld: Declare support for "Tip of the Day" dialog
        
        Add .ui file for the dialog that can be triggered via
        "Help" -> "Show Tip of the Day" to the list of supported
        .ui files.
        
        This means that native Qt widgets are used for that dialog
        now when LO gets started with environment variable
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        This dialog makes use of the QtInstanceDrawingArea
        logic implemented in previous commits.
        
        Change-Id: Id252e38e2eb9265276457ab64d582f71d628e369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176174
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [a3400e0471e99a3f3cfa750d0a5cf61a9c3ee0cc]

        tdf#130857 qt weld: Implement simple drawing in QtInstanceDrawingArea
        
        Implement simple drawing in QtInstanceDrawingArea
        by handling the QEvent::Resize and QEvent::Paint
        events for the QLabel widget.
        
        While the QLabel does not emit any signals when
        these events occur, it's possible to handle them
        by setting an event filter using QObject::installEventFilter [1].
        
        Install QtInstanceDrawingArea as an event filter
        for its label, and implement handling of the Resize
        and Paint event in QtInstanceDrawingArea::eventFilter:
        
        On the QEvent::Resize event, adjust the output size
        of the output device and call the `weld::Widget::m_aSizeAllocateHdl`
        handler. (See also GtkInstanceDrawingArea::signal_size_allocate
        and SalInstanceDrawingArea::ResizeHdl to see what the
        gtk3 and VCL implementations do.)
        
        On the QEvent::Paint event, trigger drawing on the
        output device via the weld::DrawingArea::m_aDrawHdl
        handler, and get a QPixmap for what's painted on the
        output device and set that QPixmap for the label if
        it has changed.
        
        With this in place, the GtkDrawingArea in the "Help"
        -> "Show Tip of the Day" dialog displays the
        image as expected, and gets updated when moving to
        the next tip, once support for that dialog has
        been declared, which will be done in an upcoming
        commit.
        
        For more complex cases, a more performant solution
        might become necessary and can be investigated
        once support for these is implemented.
        
        For the "Tip of the Day" dialog, the `aRect` passed in
        QtInstanceDrawingArea::handlePaintEvent is irrelevant
        as CuiGraphicPreviewWindow::Paint doesn't make use
        of the passed rectangle. (This might also have to be
        reconsidered/adjusted in case a dialog actually making
        use of the rectangle doesn't work as expected.)
        
        [1] https://doc.qt.io/qt-6/qobject.html#installEventFilter
        
        Change-Id: I651e00043fac04a4c77aae921e6397e8d97cc69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176173
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [6e2dd3bed69355c028c2378bce81b98f390b50b2]

        tdf#130857 qt weld: Implement QtInstanceWidget::{g,s}et_size_request
        
        As described at [1], gtk_widget_set_size_request sets the
        minimum size. Therefore, get/set the QWidget::minimumSize
        property [2] for the QtInstanceWidget implementation using
        a native QWidget.
        
        [1] https://docs.gtk.org/gtk3/method.Widget.set_size_request.html
        [2] https://doc.qt.io/qt-6/qwidget.html#minimumSize-prop
        
        Change-Id: I38b9d02b81ed209b2acc94c2b9b015f32c6eec79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176172
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [5c85ef3df01daf7848753fe33f254aeb3d1dd8e6]

        tdf#130857 qt weld: Add QtInstanceDrawingArea basics
        
        Add a new QtInstanceDrawingArea class as the weld::DrawingArea
        implementation using native Qt widgets.
        
        Initially only add the "basic structure" (most of the actual
        functionality of drawing will be added separately):
        
        * Add the QtInstanceDrawingArea class with most methods
          currently still unimplemented and triggering an assert
          when they get called.
        * Add a `ScopedVclPtrInstance<VirtualDevice> m_xDevice`
          member and return that in `QtInstanceDrawingArea::get_ref_device`,
          as the gtk3 implementation (GtkInstanceDrawingArea) does.
        * Let QtBuilder::makeObject create a QLabel for a
          "GtkDrawingArea" object for now. That label will hold
          a pixmap (which should be sufficient for simple cases
          at least).
        * Let QtInstanceBuilder::weld_drawing_area return an
          instance of the new class.
        
        Change-Id: I5d509ccd9f5a7a826a166958af4a92ff01cc0225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176171
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [2d1de12ac8064dd3c73e4359b931fdccae3541fb]

        tdf#130857 qt weld: Support "GtkSeparator"
        
        Handle "GtkSeparator" objects in .ui files:
        Create a QFrame and, depending on the orientation
        set a shape of either QFrame::HLine ("QFrame draws a
        horizontal line that frames nothing (useful as separator)")
        or QFrame::VLine ("QFrame draws a vertical line that frames
        nothing (useful as separator)") [1].
        
        This will be used e.g. in the "Help" -> "Show Tip of the Day"
        dialog.
        
        [1] https://doc.qt.io/qt-6/qframe.html#Shape-enum
        
        Change-Id: I41e69dd211cbb69cb7b23cc54640cd1fad655efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176165
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [92a36bbd4f3e9ad5d2741f55fe4ac7f03f7e2531]

        [API CHANGE] a11y: Switch AccessibleRelationType to enum
        
        Switch css::accessibility::AccessibleRelationType
        from integer constants to an enum.
        
        This provides more type safety and improves the debugging
        experience, e.g. GDB now prints
        
            com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO
        
        instead of just "2" when printing the value of a
        corresponding variable, so it's no longer necessary
        to manually look up what constant has that integer
        value to know what relation this refers to.
        
        offapi/com/sun/star/accessibility/AccessibleRelationType.idl
        had this comment:
        
        > <p>We are using constants instead of a more typesafe enum.  The reason
        > for this is that IDL enums may not be extended.  Therefore, in order to
        > include future extensions to the set of roles we have to use constants
        > here.</p>
        
        However, the a11y UNO API is internal (not published),
        so that shouldn't be a concern.
        
        Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [f0d8873f511a3eb951f50bc2ee2ed9b2a2cad4e4]

        a11y tests: Map DESCRIBED_BY relation type to AT-SPI
        
        Change-Id: I9d0122459cf0a90ce1c49c6bdc07b24ff93bc417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176152
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [7599afa86eb0c9583e1c89764fa2f35f0c80bb86]

        editeng a11y: Use range-based for
        
        Change-Id: Ie686eb0c76e77139e9d59b1d08a7ac7e99f71316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176151
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [355f6466dc13d2ebd7e8ba323df0da832b0ed096]

        editeng a11y: Drop "typedef std::pair<short int,short int> RD"
        
        Use initializer syntax for the array elements.
        
        Change-Id: Ibe8dbc372cfb5f7134267f26d5bd27fd153a797b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176150
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-07  codewithvk  <vivek.javiya@collabora.com>  [d72dcbc4fcb7458955d8071f49d1a877a7d1d1a6]

        sw: add .uno:DeleteContentControl command
        
        This command removes formatting for content controls such as rich text, checkbox, dropdown, picture, and date controls. It deletes only the content control formatting, not the actual content of the section.
        
        Here are some todos:
        	- Add test case for delete
        	- undo/redo for this uno command
        
        Change-Id: Ib1b3b62ff7d62fd971472eff49a58c5afd786dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175927
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 5d4ae3db293b0f9c46cbc09d0391806e1ed7b362)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176067
        Tested-by: Jenkins
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d5d06da8d01d46ede24bfc8e2789830493a5a7d]

        loplugin:passstuffbyref in svtools
        
        Change-Id: I4e3d7d5fb6be857efc8327eb5113f874169bf778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1580c31f616ac62e7989efd846a419ac9f63b7c5]

        loplugin:passstuffbyref in sfx2
        
        Change-Id: I584393af7fe7bb36c95e1898f724fa1d58b1b5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [2ee7745225fb2c5340dc8eddd803a8de7eeb6865]

        aGraphic.IsNone was checked above
        
        It seems that the else branch position wasn't adjusted in commit
        7a8ed362eb163ac15a000ba1cfc74b58315800a1 ([API CHANGE] revert and
        deprecate *BackGraphicURL add *BackGraphic, 2018-05-07).
        
        Change-Id: Ib4b68ee813539b4d62ffd8664d496467d7789547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176158
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [dcf3a85e6e5d4c7761d73a9f018c0c09862351ce]

        Related tdf#162262 - sc: odf import/export of "Summary below data"
        
        Add new LO_EXT "summary-below" attribute for table:subtotal-rules.
        
        Follow up commit: 26c08356d1b2a963efdca570979cb04388371400
        (tdf#162262 sc add "Summary below data" option for Subtotal dialog)
        
        Change-Id: Ie7f43d3c76479cd9468552b5939de5dbb2082a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176058
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-11-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [330bd4679fcb2540776a9a31310e283ac8ab1d68]

        curl: upgrade to 8.11.0
        
        Downloaded from https://curl.se/download/curl-8.11.0.tar.xz
        
        Change-Id: If1b8175c0e6a32ac5b723a73b07f9971a6f8b739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176157
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e8eae6adb8c9515badd839c4f5247bb35257ad96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c232c2570bffe589012401b3a28a149916619800
          - Remove vcl screenshots (not used)
            
            Change-Id: Iea6f7275d1fa2c3b44998bc3297149e169ced3d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176170
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [98355e65aa105bfdaf7d7907d8be6bcc87784f72]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 562, 587
        
        Change-Id: I99c433daf9072b4e070a2ba0095d51591ebf7810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175359
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1259a073c18fa7f70799ca96fc6884915d29fe2d]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 601, 604, 607
        
        Change-Id: Iec91d390ae57b9a01af867cc8af34b442841dce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175356
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d98de2d0324c0e1cd808643633889423fccfc75e]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Iad298c2819b0fa1fd4d98a64f19008a7ef8d39be
        V1037: Two or more case-branches perform the same actions. Check lines: 353, 362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175050
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [49f7a5209f890c497d15782ef4c3cc7c199bc0c8]

        Update the reference rdbs to libreoffice-24.8.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-24.8.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-24.8.0.3/instdir/program/types.rdb \
         .../libreoffice-24.8.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I6b000c8e3e68635291a68c31eefee6ccdbce1af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176145
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5b6e92c87b28ffc3f8dfd17c5a03f044a707ac1f]

        Record external/zxing patch as sent upstream
        
        Change-Id: Ia84be07223cf8c7427aa899baf97b63ed8fc8794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-06  Sahil Gautam  <sahil@libreoffice.org>  [608e1452c51efa4f9bbcea8ed9a538ff974eed28]

        tdf#85976 Add 'Handle Duplicate Records' button to the notebookbar
        
        Add button under the data tab for 'Handle Duplicate Records'.
        
        Change-Id: I610985bcb8451172d2ae240c6cb2174912526578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175764
        Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-06  Sahil Gautam  <sahil@libreoffice.org>  [c85155cf6d43e328bfe31834a49fbfb55670e166]

        tdf#158943 Libreoffice Theme Part 3: Qt Color Customization
        
        Enable UI color customization in QT via the use of custom palettes and
        custom style objects for the application, and the native widgets like
        the menus and the menubar.
        
        Menubar in `kf6` doesn't follow the set palette's colors anymore, maybe
        some update from kde/qt (something to look into). Works fine for `kf5`.
        ticket: https://bugs.kde.org/show_bug.cgi?id=493550
        
        Change-Id: Ibedd6d66b8ea2855e049a85b3d51ea7e933b5c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168901
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-11-06  Sahil Gautam  <sahil@libreoffice.org>  [4bdb421440207c21bf2ea93fdf8a9494742beb08]

        Libreoffice Theme Part 1.0: Make registry colors accessible from VCL
        
        Enable UI color customization via an extension. This patch doesn't
        include any UI changes as that needs to be discussed with the community
        first (ticket: https://bugs.documentfoundation.org/show_bug.cgi?id=163620)
        
        Part 1.0 (this change) is responsible for loading all the ThemeColors
        from the registry into a `static ThemeColors` object, which then is
        accessed in various VCL_PLUGINS as a source for the application colors.
        
        The user now has to go to the registry (expert configuration), and
        enable the theme by setting "LibreofficeTheme" to "true". It can also be
        enabled via an extension (demonstrated in the Theme Template).
        
        `testGetViewRenderState` changes to  "Dark" scheme which is  not present.
        Changes in  this patch don't allow  that and use 'Automatic' as the
        fallback. This caused the unit test to fail. So the test was changed to
        have "Dark" scheme before changing to it.
        
        Theme Template: https://github.com/printfdebugging/libreoffice-theme-template
        Project Report: https://printfdebugging.in/libreoffice/01-themes-gsoc-2024/
        
        Change-Id: I5193d4d34fcd2f4c5d6f124a871bd5c7f14e95a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168016
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-06  Michael Stahl  <michael.stahl@allotropia.de>  [7fa083459eb5c5b620454c6e3092d35cdde1b281]

        tdf#162268 sw: formatting: paragraph style also applies to para marker
        
        ... so check it in SwTextFrame::IsHiddenNow().
        
        During RTF import, the \v produces a RTFSprm that may be deleted before
        inserting by cloneAndDeduplicate() because the style already has the
        same value; this happens in one paragraph in the table in the footer of
        the bugdoc and that's why that row is visible.
        
        (regression from commit 7b8cec8322b60673e686660caf875bc71117bbd0)
        
        Change-Id: I064ecdc04c26afab7ef2196ac4da338b9d0bb1f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176093
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-11-06  Michael Stahl  <michael.stahl@allotropia.de>  [a6d0b7f6832ed313b631484bee8d5bd83651530e]

        tdf#162268 sw: layout: hidden formatting is ignored on cell end marker
        
        ... in Word, so ignore it in Writer on the last paragraph in a cell.
        
        (regression from commit 7b8cec8322b60673e686660caf875bc71117bbd0)
        
        Word also uses hidden character formatting on the row end marker to
        determine if a row should be hidden; this isn't possible yet.
        
        Change-Id: I7ceaea0d807193155631083616a93cdd058e20d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176060
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [3e383f1441485de2b374530c05eda284ab636463]

        Simplify a bit
        
        Change-Id: Ie058f0856b64b4284ed9620857ed6dddfe5a3149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [5c9b00ff3d12cb5699cbd0158d12f8300488dc41]

        tdf#163748: checking Any's value type is anti-pattern
        
        The type could be XInterface - yet it may hold XGraphic. Testing
        for exact type would fail then.
        
        And it looks like Java bridge code does just that: a code like
        
          XGraphic graphic = xGraphicProvider.queryGraphic(v);
          xStyleProps.setPropertyValue("BackGraphic", graphic);
        
        sends the XGraphic as an Any with XInterface type (unlike a similar
        code in Basic). It's sad that we *move* tests to Python, instead of
        having both - it's not like "Python works -> Java would work, too".
        
        Change-Id: I5cd9b1f750e71895232b2c31174ef969a7b15b7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176149
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [c392f12d3379d51d3f24d3f58a15518aef84f951]

        tdf#130857 qt weld: Add layout/widget for extra msg dialog controls
        
        weld::MessageDialog::weld_message_area needs to return
        a weld::Container that can be used to insert additional
        controls into a message dialog.
        
        In order to implement this for QtInstanceMessageDialog,
        insert an additional widget with a QVBoxLayout layout
        into the QMessageBox layout, and return that one.
        
        In order to ensure that the extra controls are inserted
        in between the labels holding the text in the message dialog
        and the button box, make use of the known implementation detail
        that Qt's QMessageBox uses QGridLayout for its layout
        (see QMessageBoxPrivate::setupLayout in qtbase [1]),
        find where the last label is positioned, shift everything
        after the last label down by one row in the grid layout,
        then insert the extra widget in the now empty row.
        
        If QMessageBox internals ever change to use a different layout,...,
        then this will have to be adjusted in the future, but it
        works fine in my tests with both, Qt 5.15 and current
        qtbase dev (as of commit 4c0b45553862d3eff35906d02ea5e2afd9252bbd).
        
        This will be needed e.g. by the "LibreOfficDev Help Not Installed"
        dialog that shows up when pressing F1 in a build not including
        the local help.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/dialogs/qmessagebox.cpp?id=4c0b45553862d3eff35906d02ea5e2afd9252bbd#n290
        
        Change-Id: I2153add5145a4655800ca89f8e943610014b1021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176091
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [a1db771b40092a4e289d0bac52d1237afe7a1ec4]

        tdf#130857 qt weld: Implement QtInstanceContainer::move
        
        As documented in include/vcl/weld.hxx, the new parent
        can be null, in which case the widget is only removed
        from the current container. In that case, mark the
        widget for deletion, as there's no more parent
        that owns the widget and would take care of deleting
        it when getting deleted itself.
        
        Change-Id: I1b3374683629a841f5101098b967cc5cf75d4f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176090
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [225b902ad3f61a7456dd88ed116ffc4488f231f1]

        tdf#130857 qt weld: Implement QtInstanceWidget::weld_parent
        
        Change-Id: Ie26a40badb891f17b26b9e9202709a3edb909a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176089
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [790749fde3a008047d1aa20eb6db0d00d2c355de]

        tdf#130857 qt weld: Assert in unimplemented QtInstanceContainer methods
        
        This way, implementations needed by any dialog that will
        be declared as supported in the future will become clear,
        rather than going unnoticed, with the functionality not
        working as expected.
        
        Change-Id: I27eba58c829586fff5566cc88983013429ca0b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176088
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [10b28684f6aee277c42457f2e663d8e86acc6492]

        tdf#130857 qt weld: Implement QtInstanceBuilder::weld_container
        
        Create a QtInstanceContainer, passing the layout's
        parent widget in the ctor.
        
        See also preparatory commit
        
            commit bf42162fc50d0c6f8e567d8765f8b14b96d7cc50
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Nov 4 19:06:15 2024 +0100
        
                tdf#130857 qt weld: Add extra QWidget parents for layouts
        
        to ensure that layouts actually have an associated
        QWidget parent.
        
        Change-Id: Id95e1649d6a8b38eb2b685dc85b486920537d8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176087
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0481c2c75efb47e7ca8a106a6e9703a2c4e4f0f0]

        tdf#163486: PVS: Redundant code.
        
        V649 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 212, 216.
        
        Change-Id: Id596419cc3134355904b4ca93a44c017ffa6635c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [dd4ec48bcfc9ac2d6fd419b84650345e6f28e261]

        tdf#163486: FP PVS:  memory leak is possible
        
        V773 Visibility scope of the 'uriTools' pointer was exited without releasing the memory. A memory leak is possible.
        
        Change-Id: I4ea97b4ca0e6cb4c5b1def56013290eca9a330d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [68627693eccb8a9190412db06e1138b56a761dbd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 322ff6ee131f153c9438a6025ec880eff4d01dcb
          - tagalog add filter dialogs + refresh
            
            Change-Id: I61ddf8b14fa61b2b8dc66ec96081613670cdfb43
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176148
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [45fb7a2fd4fc0535687dd79d1602465f4acf4399]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 241, 445
        V1037 Two or more case-branches perform the same actions. Check lines: 283, 485
        V1037 Two or more case-branches perform the same actions. Check lines: 323, 439
        
        Change-Id: I3540ee8b2d545dcd3bea1443f0d0c43419ae7721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175223
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a6a68d655ed3474ed0526c2991db34b8d6d0a8ff]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 305, 361
        
        Change-Id: Ibab399391a23eea20d6a589123bbfc947d131bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175216
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-06  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3c32c9323968bd26e5b4524ed4045bc2829207ee]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1114, 1129, 1261
        
        Change-Id: I661f54f3aaa84002e3013439ea762afa4a251857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175210
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-06  László Németh  <nemeth@numbertext.org>  [3056c75db5b2a8a945621349fea9ee1183872989]

        tdf#95239 sw: fix wrong order of PDF ToC, if headings put in text frames
        
        PDF outlines (called also as PDF bookmarks or ToC) contained headings in
        the wrong order if they were placed in a text frame:
        
        Heading 2 (frame) ... 2
        Heading 3 (frame) ... 2
        Heading 1 ........... 1
        
        Now PDF export didn't list text frame headings only at the start of the
        ToC, but in their correct position and hierarchy, based on the page
        and vertical position of the headings:
        
        Heading 1 ................ 1
          Heading 2 (frame) ...... 2
             Heading 3 (frame) ... 2
        
        This is useful for the recently implemented inline headings, where
        e.g. APA Style Heading 4 and Heading 5 are there in text frames
        anchored as characters, see tdf#48459.
        
        Extend PDFium test environment for bookmarks, and add tdf#131728 DOCX
        and an APA Style .fodt unit tests.
        
        Note: if the higher headings are only in text frames, but not the
        lower ones, only the order corrected, but not the full hierarchy, yet.
        
        This is a follow-up to commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export",
        commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf#48459 sw inline heading: add Inline Heading frame style" and
        commit 49765a9e7be41d4908729ff7d838755276b244cb
        "tdf#48459 tdf#131728 sw inline heading: new frame style: fix DOCX
        export".
        
        Change-Id: I87dffb9244d8aea553c98bf16c70955bb9b732d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176050
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-11-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [315180b2a3977aadb0de3ff6d20774e87eaf9ffd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69d616f2dc90236195aedcc59d0b4ce1765f8cb1
          - Removed exec bits on png files
            
            Change-Id: I114b102191774199016e83e404396b6e5b9f8e6b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176140
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a96f11eb0a8e439166df88e01b75d8248d5ebfd]

        make the autotext shortcut warning dialog async
        
        Change-Id: I8fb0e61d48400d001cf6a3918c638bc087723288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175985
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [18a9092d7b9a9f4e7ee9203770423e50fa01d626]

        Simplify a bit
        
        Change-Id: I62299212957f491ff0ead9e64816d70cb7f19e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176061
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6c3f0b62a53692efcc4056fdaade9263e200756]

        loplugin:passstuffbyref in svx
        
        Change-Id: Ic5fd72cb64208c278ffc129591cd3d1131efdc08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d5b55513cdc05e8d622897201e233eb0ad5147b7]

        loplugin:passstuffbyref in basic
        
        Change-Id: I1aee08f0ff2a3dabcedc49a31e7ff4de9428007e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [95911bf6b8ae0d13f0c3cfc93c06badff822eefb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a82bde73fdb8cd157cb1f76518f6ad5ef0badd44
          - tagalog add slantcornertabpage + refresh
            
            Change-Id: I71f5a3bd90fcd27e18438b15c19bd0a600497d29
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176134
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [868cda6b33d5d436a1d035353c7dcc721908a80c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d58643f5775cd5684bfe83d26596791d9e533bfe
          - tagalog add pageformatpage + refresh
            
            Change-Id: Ie475fe669ce2ba1ebfbf7f0a2bcd5970f4a0f4a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176133
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b62db9ec69efbd3a5380695e199264dc731801a0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 27aaf37df77ab9380c4375cb4ebd40e587a969b5
          - tagalog add optviewpage + refresh
            
            Change-Id: Ifcc791a0b6a7a013f94afe007439003c9e431b96
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176132
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fcf7dcb56ac57b22253ef262a701f4dd2247f500]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7cd7cc5ef283cd3f0156a88646a5fee21ca12a89
          - tagalog add optsecuritypage + refresh
            
            Change-Id: Iec3bf839ea7317f126d5bd5faeda5a15a33c0018
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176129
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [96529c2d7f7ef6f8435717393d0b6006d3eed099]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2312f595505f21c2d1e114b64649ebba9e74c622
          - tagalog add optlanguagepage + refresh
            
            Change-Id: Iae5525ed545cd6711793f23d4b83a6aa72b9062b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176128
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bd8675f8a2fc215e5d0bef8bffeac3f3d4b63751]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 74ab7f1b9d07618843ff721543c38866a9e3639e
          - tagalog add opthtmlpage + refresh
            
            Change-Id: I17a32e55977e07db591567d4ed4f1bf13997070b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176127
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9fab4c29c99ee75524de5ced4c3e66f2fa7bfa77]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9d980a2674ca20d5fa84aa657382e747a250375a
          - tagalog add optgeneralpage + refresh
            
            Change-Id: I41ef17f489b077362525a0c572f10b8fb5a95e8d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176126
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6a89f7b9d02262770515c45a48cc1be09c52e5cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc787c47259c7cbbfcec1aff3e3685832afb382e
          - tagalog add optfltrlpage + refresh
            
            Change-Id: I157460629f8d191b97b1e9aa16c9b04814807d6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176125
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8ee147278565be532538d3a524b625593c675b2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 369d452ac5cf65193f7a8c04b0e381dfa3eea69f
          - tagalog add optactlpage + refresh
            
            Change-Id: I24d7d18bf213b0674b24b277ec66bf02e0e21182
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176124
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6decaaaabc41da498f4f32f8d2fb959d5fd302e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13e4c3be51c804c1be38660c50d93f25b1e7a3ca
          - tagalog add optasianpage + refresh
            
            Change-Id: I0629c9f8b777e840232519514f366d08e89c6fed
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176123
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c562e39e8616f8d1b177be0041bab942e49547bc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68422153146e6763b59c6d2ef02cc5a2918e7bae
          - tagalog add optadvancedpage + refresh
            
            Change-Id: I4aa465c674a75a0883674013c315aee129ebe2be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176122
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [0269fb72e886f0f04652fdadeaedf653f518ca61]

        ignore TypedWhichId in loplugin:rangedforcopy
        
        where using a "&" in a for loop is overkill
        
        Change-Id: Ic0d14f6d19c50b49cf7ce3bf2166d546a4d2685b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176130
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [2796d979fad388b32c466b8fb6d3dce8b5bdf31d]

        loplugin:passstuffbyref in editeng
        
        Change-Id: I015616d7a008692b63586cd5d2ae9cc5586ead4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Michael Weghorn  <m.weghorn@posteo.de>  [a43b5e3de41856407dbad337dac8e96d7e966429]

        win: Prefer integers instead of strings for OS version comparison
        
        * Add a WinOSVersionInfo struct holding the major and minor
          version and build number for a Windows release.
        * Extract a static WinSalInstance::getWinOSVersionInfo from
          WinSalInstance::getOSVersion that returns a corresponding
          version info.
        * Adjust the local getOSVersionString helper to take integers
          for major and minor version instead of an "NT version" string
          that is a dot-separated version number containing both of these.
        * Use WinSalInstance::getWinOSVersionInfo in ImplDrawNativeControl
          to compare the major version + build number to identify Windows 11
          instead of relying on WinSalInstance::getOSVersion to return
          a string starting with "Windows 11".
        
        Change-Id: I6fe727c1c0f928c03216e406cdb1b7735c1ab3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176059
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92f5913aef0668f1de5a20631128c84ad932fd99]

        cid#1556442 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1607753 COPY_INSTEAD_OF_MOVE
        cid#1554790 COPY_INSTEAD_OF_MOVE
        cid#1556463 COPY_INSTEAD_OF_MOVE
        cid#1554838 COPY_INSTEAD_OF_MOVE
        cid#1556231 COPY_INSTEAD_OF_MOVE
        cid#1556878 COPY_INSTEAD_OF_MOVE
        cid#1554913 COPY_INSTEAD_OF_MOVE
        cid#1558064 COPY_INSTEAD_OF_MOVE
        cid#1557043 COPY_INSTEAD_OF_MOVE
        cid#1556985 COPY_INSTEAD_OF_MOVE
        cid#1556766 COPY_INSTEAD_OF_MOVE
        cid#1557351 COPY_INSTEAD_OF_MOVE
        cid#1554863 COPY_INSTEAD_OF_MOVE
        cid#1556764 COPY_INSTEAD_OF_MOVE
        cid#1556279 COPY_INSTEAD_OF_MOVE
        cid#1555970 COPY_INSTEAD_OF_MOVE
        cid#1556942 COPY_INSTEAD_OF_MOVE
        cid#1557964 COPY_INSTEAD_OF_MOVE
        cid#1555166 COPY_INSTEAD_OF_MOVE
        cid#1556496 COPY_INSTEAD_OF_MOVE
        cid#1557175 COPY_INSTEAD_OF_MOVE
        cid#1558054 COPY_INSTEAD_OF_MOVE
        cid#1557392 COPY_INSTEAD_OF_MOVE
        cid#1557850 COPY_INSTEAD_OF_MOVE
        cid#1555118 COPY_INSTEAD_OF_MOVE
        cid#1557131 COPY_INSTEAD_OF_MOVE
        cid#1556614 COPY_INSTEAD_OF_MOVE
        cid#1609650 COPY_INSTEAD_OF_MOVE
        cid#1555114 COPY_INSTEAD_OF_MOVE
        cid#1555241 COPY_INSTEAD_OF_MOVE
        cid#1555442 COPY_INSTEAD_OF_MOVE
        cid#1556473 COPY_INSTEAD_OF_MOVE
        cid#1557654 COPY_INSTEAD_OF_MOVE
        cid#1554689 COPY_INSTEAD_OF_MOVE
        cid#1556316 COPY_INSTEAD_OF_MOVE
        cid#1557929 COPY_INSTEAD_OF_MOVE
        cid#1554807 COPY_INSTEAD_OF_MOVE
        cid#1554858 COPY_INSTEAD_OF_MOVE
        cid#1555103 COPY_INSTEAD_OF_MOVE
        cid#1555517 COPY_INSTEAD_OF_MOVE
        cid#1556424 COPY_INSTEAD_OF_MOVE
        cid#1557252 COPY_INSTEAD_OF_MOVE
        cid#1557566 COPY_INSTEAD_OF_MOVE
        cid#1608020 COPY_INSTEAD_OF_MOVE
        cid#1557742 COPY_INSTEAD_OF_MOVE
        cid#1555884 COPY_INSTEAD_OF_MOVE
        cid#1554809 COPY_INSTEAD_OF_MOVE
        cid#1555336 COPY_INSTEAD_OF_MOVE
        cid#1555173 COPY_INSTEAD_OF_MOVE
        cid#1556067 COPY_INSTEAD_OF_MOVE
        cid#1557040 COPY_INSTEAD_OF_MOVE
        cid#1556235 COPY_INSTEAD_OF_MOVE
        cid#1557366 COPY_INSTEAD_OF_MOVE
        cid#1555910 COPY_INSTEAD_OF_MOVE
        cid#1556716 COPY_INSTEAD_OF_MOVE
        cid#1558022 COPY_INSTEAD_OF_MOVE
        cid#1555769 COPY_INSTEAD_OF_MOVE
        cid#1555940 COPY_INSTEAD_OF_MOVE
        cid#1557077 COPY_INSTEAD_OF_MOVE
        cid#1555270 COPY_INSTEAD_OF_MOVE
        cid#1555660 COPY_INSTEAD_OF_MOVE
        cid#1556302 COPY_INSTEAD_OF_MOVE
        cid#1555678 COPY_INSTEAD_OF_MOVE
        cid#1556538 COPY_INSTEAD_OF_MOVE
        cid#1557689 COPY_INSTEAD_OF_MOVE
        cid#1555009 COPY_INSTEAD_OF_MOVE
        cid#1555433 COPY_INSTEAD_OF_MOVE
        cid#1555671 COPY_INSTEAD_OF_MOVE
        cid#1555255 COPY_INSTEAD_OF_MOVE
        cid#1557681 COPY_INSTEAD_OF_MOVE
        cid#1557512 COPY_INSTEAD_OF_MOVE
        cid#1554958 COPY_INSTEAD_OF_MOVE
        cid#1555758 COPY_INSTEAD_OF_MOVE
        cid#1555597 COPY_INSTEAD_OF_MOVE
        cid#1558040 COPY_INSTEAD_OF_MOVE
        cid#1556476 COPY_INSTEAD_OF_MOVE
        cid#1557646 COPY_INSTEAD_OF_MOVE
        cid#1557950 COPY_INSTEAD_OF_MOVE
        cid#1557019 COPY_INSTEAD_OF_MOVE
        cid#1557885 COPY_INSTEAD_OF_MOVE
        cid#1556402 COPY_INSTEAD_OF_MOVE
        cid#1557906 COPY_INSTEAD_OF_MOVE
        cid#1556619 COPY_INSTEAD_OF_MOVE
        cid#1554683 COPY_INSTEAD_OF_MOVE
        cid#1556549 COPY_INSTEAD_OF_MOVE
        cid#1554747 COPY_INSTEAD_OF_MOVE
        cid#1554929 COPY_INSTEAD_OF_MOVE
        cid#1555362 COPY_INSTEAD_OF_MOVE
        cid#1557053 COPY_INSTEAD_OF_MOVE
        cid#1557891 COPY_INSTEAD_OF_MOVE
        cid#1555043 COPY_INSTEAD_OF_MOVE
        cid#1555107 COPY_INSTEAD_OF_MOVE
        cid#1557203 COPY_INSTEAD_OF_MOVE
        cid#1556728 COPY_INSTEAD_OF_MOVE
        cid#1557773 COPY_INSTEAD_OF_MOVE
        cid#1556845 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I001fb67e597b096e992fd8a0cd6f3ec577767c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176098
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c235e6af9192db19cbbe6f8b00112a1f6534375e]

        cid#1606953 Overflowed constant
        
        Change-Id: Ife4caf4251076be5ddf289c701ec52c9828b9665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [adfab29d83a4143ae8046faa6d324aca5bc76bc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 410f88c0a7b8fc67bac17bc2c81d03d0ef509cb8
          - tagalog add optaccessibilitypage + refresh
            
            Change-Id: Ifb5f7fd72bb15c052a49b46537ca235e23e4566a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176121
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a608faf3cdcaf355278c002f5a50d8871778791]

        loplugin:passstuffbyref in xmloff
        
        Change-Id: I4837cb60c2c78b5a9008b6ffbb6323da50c7c705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [327c5dd14631a1a40af3b617af308cf5e88f1853]

        loplugin:passstuffbyref in ucbhelper
        
        Change-Id: I70f0774ec2f38c0ba250aee7999d72eaa4a82673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176110
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e60bca0b830edf791b73b71cf3c23ac0367d5b0]

        loplugin:passstuffbyref in vcl
        
        Change-Id: Id152f7321bb81ecb17b31775277d1466ccd91ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176108
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-06  Miklos Vajna  <vmiklos@collabora.com>  [bb51c57fd515bd2b2a9d97aa9a371901a3af8092]

        sw lok: async readonly dialog when pressing delete key on protected content
        
        Open online.git/test/samples/writer.fodt, ctrl-a, del, the read-only
        dialog is blocking.
        
        This was working already for the character insert case, but not when going
        via KEY_DELETE.
        
        Fix the problem similar to what commit
        0c03a97fb8844ad0de1abea79b5265617a509460 (sw edit win: fix read-only
        selections while handling ExtTextInput, 2021-01-13) did, by switching to
        the async path here.
        
        There doesn't seem to be any reason for the old sync behavior, other
        than the safe "keep things unchanged" default in InfoReadOnlyDialog().
        
        Change-Id: I9330cb235bf6c19f96e9d21889eb9639725daf8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176113
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcf9699a823775bb4c5ad2a1c3bd96e8e1c4fede]

        tdf#163731 Style names cropped in Stylist in Writer's Sidebar
        
        regression from
            commit 7f42f031ed1b9f374f3fcba9c814dc5862492026
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Oct 10 09:39:14 2024 +0200
            tdf#100894 speed up style tree creation
        
        Change-Id: I94f7f3edd4dc31a2a86ddd73a79f276d6c30509c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176107
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c59d82142bca9dc24211e733ce4f3f72865c5e8]

        fix memcpy in ImplExpandCompressedPortion
        
        regression from
            commit 11b15571475414ef853e21a6c96afa2ac81f848f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Oct 30 09:51:26 2024 +0200
            convert KernArray from sal_Int32 to double
        
        Change-Id: I43a3af79159944ac84cb473a0f258f0815228bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9879cadfc55f28f9bb8b53a818117c64f46daf78]

        tdf#162753 - Hyperlink dialog: preset only syntactically valid hyperlinks
        
        Change-Id: I682acfa4e41a3cce5f4639d79004bea985cabce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176112
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a74c599ea231f9b67a4c928ae4d029a983faf73e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ef21717396d8d0b92791b9ee79a1af4f63050b1
          - tagalog add hyperlinknewdocpage + refresh
            
            Change-Id: I0e3026cc92892fb254f3f40a08cb57582bc8ec93
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176116
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [af039ec90b0807716d9f0604da896753dbe459d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a58060c90a04d99e87144b6b47eb89573424480c
          - tagalog add hyperlinkmailpage + refresh
            
            Change-Id: I3bc0bc3e15d9db9ad70e78eed14f7a8c40371950
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176115
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cca1ff25db3ee0e1c31b5adcef421e80cb42a65f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c2b41423924611c97c70b6cb4a8b49e455c84a80
          - tagalog add hyperlinkinternetpage + refresh
            
            Change-Id: I307dc8753d39035439f34f6df10e6ad6bb446816
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176114
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [43c4488e584e7672ee55ce97a524967f47d0d649]

        Fix: Make the repeat slideshow property independent of the TransitionType
        
        Change-Id: I60b00f2935df8dc224736120b1e0d70c2821c0cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176105
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [797e215f7932d7c0bd551ad0b4c5d66a8b458cff]

        cid#1634477 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1634476 COPY_INSTEAD_OF_MOVE
        cid#1634474 COPY_INSTEAD_OF_MOVE
        cid#1634473 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iefa96ce12bc787bf86e3f02066c46e943d8b3ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3cf64b9d57198c42d6cef4d78fc563f69ad4c503]

        cid#1608064 silence Data race condition
        
        Change-Id: Ib8fa1a1027bef3516665f17c8c4c19b6d571e7ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176096
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [52357eefa7abdf4f648e311ce6ce9fd25b14f65e]

        loplugin:passstuffbyref in svl
        
        Change-Id: Ibc4628941b40159aa35a0a55900efb3dd882369e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [54a91f287ff75d2f66e547181961f7b25728a9b9]

        loplugin:passstuffbyref in tools
        
        Change-Id: Id902f711d14eb21dc14366e8fe8fc5a96c0afec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [69f4abaffd92233ccb32a01f1c297036a792b274]

        loplugin:passstuffbyref in unotools
        
        Change-Id: I0a63fc95f76664408a7ec3ee53a8d025eb5f560d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [47a1dccd17d106e880d51dad4aa51cd0795bf198]

        loplugin:passstuffbyref in comphelper
        
        Change-Id: I2c94b6e0bbdce4f4236815df8c4841327a33939e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176053
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd8539dfd1025dccac1f919ad698249379e036da]

        add an EMPTY_OUSTRING in OUString header
        
        we already declare the same thing in various places,
        and I intend to be using this some more, so it makes
        sense to only declare it in one place
        
        Change-Id: Ifea6b589e992dd9f6cd8f2301f837e71397481c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [34099cedc55d94616560895bcb21232d93b84c24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c0aba512effb26006837e7f9c9d3517f5f167e3a
          - tagalog add screenshot for effectpage and hyperlinkdocpage
            
            + refresh screenshots
            
            Change-Id: Idf0cbc11bdaa0ef61f84887f573bdda68964f2a1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176102
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d67c7f389552ebd2896df31b485f89afbf18ce68]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a9056f80c82213fee22c37d0815ec06ad5a651f6
          - tagalog: add screenshot colorpage colorpickerdialog
            
            + update respective screenshots for all languages
            
            Change-Id: I26c50fe9c55c28760c160238513c1499d17a4bb3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176101
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-06  Miklos Vajna  <vmiklos@collabora.com>  [27753561a1899949c5cbd5cc6b72a238769e1eeb]

        cool#9992 lok doc sign, create-certs.sh password-less mode: still create a .p12
        
        I have a case where LOK convert-to with ODT->PDF and
        SignCertificateCaPem/SignCertificateCertPem/SignCertificateKeyPem set
        creates a corrupted PDF signature, while more or less the same on the
        desktop works.
        
        The PDF signature is a hex dump, and once converted to binary, one can
        analyze the content using 'openssl asn1parse -inform der -in ... -i'.
        Still, the LOK and the desktop case differs, because this script
        generates random certificates and then the binary output in the two
        cases differs, so hard to see the actual difference.
        
        Fix the problem by still generating .p12 output (needed for the desktop
        case) in the no-password case, so a single run can emit ca/cert/key PEM
        files and a .p12 archive, so exactly the same input can be used for
        desktop and LOK signing.
        
        It turns out the actual problem I looked at was some setup problem,
        because now that the same input can be used in the two cases, the LOK
        signing during PDF export works fine.
        
        Change-Id: Ifc5ff73cd6fbbc057af536c84e4367ce1d489931
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176081
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [0c1ae785e3fb3a800f6b7743a03245dca6c01f14]

        tdf#122716: take encoding defined for font into account
        
        Before this, the non-ASCII Windows-1252 characters get exported to RTF
        without Unicode markup, regardless of the font-defined charset; and on
        import to Writer (and other compliant RTF readers), this 8-bit markup
        was interpreted using the font data, producing different characters.
        
        Change-Id: I2032930b6585287fde3eb3b5e6abed0298d29330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176048
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dc9dcb5c00503a8b82f7f6cc73097332ea3b802b]

        loplugin:redundantcast
        
        ...after 11b15571475414ef853e21a6c96afa2ac81f848f "convert KernArray from
        sal_Int32 to double"
        
        Change-Id: I61e7f25f1e1b1493d1f1164f96e09eb3ba14baa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176052
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [72890bd3b96dc235b77102a396322fe72ed72a85]

        loplugin:staticconstexpr (macOS)
        
        Change-Id: I294b9476413a0d7b12daef9f26881241afcbde29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176051
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e7cbcdf86e2d49f246064e9d10229104451b1274]

        external/zxing: Missing include (for std::nullptr_t)
        
        Change-Id: I731eb3039f9f43ac05d3b60d5387ff44c5986a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176049
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-06  Mike Kaganski  <mike.kaganski@collabora.com>  [e1beaf844f5d6fdb0a72cdd70f2bbe29b699fe46]

        Related: tdf#163730 Release the object in separate thread
        
        Using a local build having both commits
        9f53d40fd19b22fe1bdbf64e8ce751cf53f4f517 "Related: tdf#163730 Avoid
        deadlock", 2024-11-02, and 3015db08c9a8a1b29af1018044955c905c9015aa
        "Related: tdf#163730 Avoid potential deadlock", 2024-11-03, I got
        another deadlock (unfortunately, I didn't copy call stacks), where
        main thread, holding soler mutex, called CWinClipboard::setContents,
        and that tried to lock solar mutex in CMtaOleClipboard::run thread,
        which released the m_foreignContent data.
        
        This change releases m_foreignContent in a separate thread, which
        has no dependencies, and so its wait wouldn't block other threads.
        
        Change-Id: If4c486e6f3ba9201c4c9c6991992e38929ab3b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176047
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-06  Regina Henschel  <rb.henschel@t-online.de>  [c377e211785c799a56cd72a9ecba9611d5993311]

        tdf#162177 Adapt function EASTERSUNDAY to ODF 1.4
        
        This includes writing ORG.OPENOFFICE.EASTERSUNDAY for ODF 1.3 and
        ODF 1.2.
        
        Change-Id: Ifa19021060f0d0223234c1ca1109300908e2dda1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175736
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [957fea5f3d554c870903687d56e49d4777b69ef8]

        tdf#163486: PVS: variable is assigned but not used
        
        Since
        commit 2e25618fe7370e9f378da0b03bca8fac471f01f3
        Author: Mike Kaganski <mike.kaganski@collabora.com>
        Date:   Mon Jul 8 12:12:49 2024 +0500
        
            Make convert*Angle strict
        
        V1001 	The 'fAngle' variable is assigned but is not used by the end of the function.
        V1001 	The 'fAngle' variable is assigned but is not used by the end of the function.
        
        Change-Id: Ie0c9059e18518cae46854715fa7d39cc9c942549
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175933
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [be11f27453f83d6a624fee898a50af471069edbd]

        tdf#163667 speed up spreadsheet with lots of cond formatting (II)
        
        Attempt to avoid the cost of GetCondResult when dealing with large runs
        of identical cells
        
        This restructures my caching code to increase the chance of hitting the
        cache.
        
        Change-Id: Ic83ff467be05fd645c80276708adb627c6b297d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176007
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 2ebb1205485cdc0bdd868ee0abe83e6a288b50da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175997
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-05  Jim Raykowski  <raykowj@gmail.com>  [60a77c7ef46f6fa82b016c7605ec3451de291344]

        Resolves tdf#163770 BASIC Macro dialog Assign should select the macro
        
        name in Function list box in the Customize dialog Keyboard tab
        
        In SfxAcceleratorConfigPage Reset, RadioHdl is called just before
        m_xGroupLBox->SelectMacro. In RadioHdl an idle timer is started whos
        handler gets fired after m_xGroupLBox->SelectMacro is called in
        Reset. This makes the selection made in the functions list box by
        m_xGroupLBox->SelectMacro in Reset get bonked by the call to
        m_xGroupLBox->GroupSelected in SelectHdl called from the idle timer
        handler. m_xGroupLBox->GroupSelected always selects the first
        function in the function list box. This patch fixes this selection
        bonk by calling SelectHdl directly from RadioHdl instead of calling
        SelectHdl from an idle timer handler.
        
        Change-Id: I15d26d4611948d61e0a258e9a350d8c952b2b211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176038
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-11-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e0521498bcde9235ae5b20b4a83a1c37fb91574d]

        Related: tdf#163736 - sc: Fix wrong nSearchMode (0) in vlookup
        
        For VLOOKUP nSearchMode was 0. So static_cast<SearchMode>(nSearchMode)
        casts to a value which does not exist in SearchMode enum. That gives an
        "undefined behavior". Better to use the valid default forward search. (1)
        
        Change-Id: I1757b43073e13638704b96c4a9d036cb9a21e470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176043
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-05  Miklos Vajna  <vmiklos@collabora.com>  [ad3f929a738292a519128192293c92bd5f96f025]

        comphelper: test uno::Any parsing from JSON
        
        Fails with commit cccbf8608f3b76651993bc8576c672367c228fa2 (feat(json):
        Allow serializing any, 2024-10-16) reverted.
        
        Change-Id: Ifd59f9921f89cc4f52a21a597f433684c715f186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176044
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-11-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c8d59dad00a84a438eb47c2e12f84cf641be2d43]

        Update git submodules
        
        * Update translations from branch 'master'
          to 50f69fbf1374ebbe4f284d37c8280e972a2abd88
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I82c3048355e1bd1c6ddac5f8991019276b7a3f60
            
2024-11-05  Patrick Luby  <guibmacdev@gmail.com>  [ed9bd5c8bc1da7d06d39bf40c84d572e6354ecf7]

        Replace unnecessary #include with forward declaration
        
        The fix in commit 2fe53b2e436cb236b2dc121ceec4f22de49a13a8 still
        works on macOS with a forward declaration of the VCLXMenu class.
        
        Change-Id: I1080466d1783464c886111e9b47d445fb16f0d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176045
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7d0a5aeeefde23f588588a4414bfe6b29271e2ec]

        Don't need to send both text and html
        
        now that the other end can use html
        
        Change-Id: Idb7959b041ebbbd9284007594473019cf603981f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175166
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 9ed5dd5d1b48b9a17967d85c0fad4994c40caafa)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [25673aaedacdd2a345407e29155be5ce99bdbbd4]

        Fix implementation of loplugin::isDerivedFrom
        
        ...where clang::CXXRecordDecl::forallBases is documented as:  "This routine
        returns false if the class has non-computable base classes."  So, presumably
        since
        <https://github.com/llvm/llvm-project/commit/bf099f4682bf088aaa49b2c72fb1ef3250213fbb>
        "[llvm][ADT] Structured bindings for move-only types in `StringMap` (#114676)"
        changed
        
        > -template <std::size_t I, typename ValueTy>
        > -struct tuple_element<I, llvm::StringMapEntry<ValueTy>>
        > -    : std::conditional<I == 0, llvm::StringRef, ValueTy> {};
        > +template <std::size_t Index, typename ValueTy>
        > +struct std::tuple_element<Index, llvm::StringMapEntry<ValueTy>>
        > +    : std::tuple_element<Index, std::pair<llvm::StringRef, ValueTy>> {};
        
        in LLVM's llvm/include/llvm/ADT/StringMapEntry.h, our !forallBases check here
        started to trivially always be true for that struct tuple_element
        specialization, so the isDerivedFrom check in
        CheckFileVisitor::VisitCXXRecordDecl in
        compilerplugins/clang/sharedvisitor/analyzer.cxx started to erroneously be true
        for that struct, so it started to generate
        compilerplugins/clang/sharedvisitor/*.plugininfo files with bogus extra
        
        > InfoVersion:1
        > ClassName:tuple_element
        > InfoEnd
        
        content, which in turn caused the generated
        compilerplugins/clang/sharedvisitor/sharedvisitor.cxx to contain lots of
        
        > #include "tuple_element.cxx"
        
        and other nonsense, which caused the build to break with
        
        > [CXX] compilerplugins/clang/sharedvisitor/sharedvisitor.cxx
        > lo/core/compilerplugins/clang/sharedvisitor/sharedvisitor.cxx:20:10: fatal error: 'tuple_element.cxx' file not found
        >    20 | #include "tuple_element.cxx"
        >       |          ^~~~~~~~~~~~~~~~~~~
        
        etc.
        
        (And now spelling out the implementation of forAnyBase here also reveals that
        BaseCheckSubclass will never be called with a null BaseDefinition, so the code
        handling that has been removed.)
        
        Change-Id: I8a6e42260eae86852ec37a80d058777653fac394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176042
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bb9090c60b8731a35a273cb616a04d21a9b6a125]

        Fix USE_TLS_OPENSSL builds
        
        ...after c8cba8ae30baef6feca3b0613366d28df4a5e568 "move CryptTools from oox to
        comphelper so we can reuse it"
        
        Change-Id: Id899c9fac9f18833afd64f18d81a7ad50916872e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176041
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-11-05  Patrick Luby  <guibmacdev@gmail.com>  [2fe53b2e436cb236b2dc121ceec4f22de49a13a8]

        Fix crash due to unexpected dynamic_cast failures in optimized build
        
        When an optimized build of this branch is compiled on Silicon Mac,
        a dynamic_cast from com.sun.star.awt.XPopupMenu to VCLXPopupMenu
        will fail.
        
        The pointer being casted has not been deleted and is an undeleted
        instance yet dynamic_cast fails. However, a dynamic_cast to
        VCLXPopupMenu's superclass VCLXMenu succeeds so cast to that class
        instead.
        
        Change-Id: Ie9ab79df109eece46351545a71325d1e37bde94d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [bf42162fc50d0c6f8e567d8765f8b14b96d7cc50]

        tdf#130857 qt weld: Add extra QWidget parents for layouts
        
        For "GtkBox" and "GtkGrid" objects in .ui files,
        don't just create the corresponding QLayout objects,
        but create an extra QWidget object and set the
        layout for that widget, i.e. use that QWidget as
        the parent.
        
        While this generally wouldn't be needed to properly
        layout/handle things in Qt, having an associated
        QWidget for the "GtkBox" and "GtkGrid" children
        is needed in order to be able to create a
        corresponding weld::Container (QtInstanceContainer)
        for these, which derives from weld::Widget.
        QLayout itself doesn't have the methods required to
        implement weld::Widget, e.g. can't be hidden or shown.
        
        Therefore, create a QWidget for these in addition,
        except for special cases like the top-level layout
        in a dialog or the dialog's button box.
        
        For QGroupBox (created for "GtkFrame" objects),
        this now means that the direct child is no more
        necessarily a layout. Just setting a QWidget
        as a child wouldn't suffice for proper layouting.
        Therefore, explicitly create a layout for parent
        widgets that don't have a layout set yet.
        
        Adjust QtBuilder::applyPackingProperties
        accordingly as well. Now, there's no more
        use case to call QtBuilder::applyGridPackingProperties
        with a QLayout for the current child. Get the
        corresponding QWidget parent (if there is one)
        before calling the method instead, and switch the
        param from QObject* to QWidget* to simplify the
        method.
        
        Having an extra widget might have the side-effect
        that extra spacing/margins might be used. If that
        turns out to be a problem, these can presumably
        explicitly be reduced (e.g. set to 0 for the relevant
        objects) as needed later.
        
        At least the 19 dialogs currently listed as supported in
        QtInstanceBuilder::IsUIFileSupported still look OK to
        me in a quick test with this commit in place.
        
        Actually making use of the newly added widgets
        to implement more of the QtInstanceContainer logic
        will be done in separate commits.
        
        Change-Id: I3d3600ddfc7883239177aafed57629c107cbdf5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176033
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [742b2d2416b7d80c3127cabd5c01db0e439204a5]

        tdf#130857 qt weld: Declare support for password dialog
        
        Add .ui file for the password that can be triggered via
        "File" -> "Properties" -> "Security" -> "Protect..." in Writer.
        
        This means that native Qt widgets are used for that dialog
        now when LO gets started with environment variable
        SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
        
        Change-Id: I106444178cd89b0f37b97bb528a144652fbb2567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176019
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [c5bf243cb3734b19cb952d1dd7d628c704fab98a]

        tdf#130857 qt weld: Implement QtInstanceEntry::set_message_type
        
        For weld::EntryMessageType::Warning and
        weld::EntryMessageType::Error, set a warning/error
        icon from the icon theme at the end of the entry using
        QLineEdit::addAction.
        
        The GTK implementation (GtkInstanceEntry::set_message_type)
        also does this. That one also sets a background color, which
        the Qt implementation doesn't do for now.
        
        This method is used e.g. by the "File" -> "Properties"
        -> "Security" -> "Protect..." dialog in Writer, which
        will be declared as supported in an upcoming commit.
        
        Change-Id: I96b81e28faf82f17e33195cfa981c82522f59b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176018
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [a2f5b750471c2fb29026b169bd1121e58a96927c]

        tdf#130857 qt weld: Make opt-in for now
        
        Except for the simple message dialogs created in
        QtInstance::CreateMessageDialog, disable the use
        of native Qt dialogs by default for now, and only
        use those if the user explicitly opts in to use
        them by setting the SAL_VCL_QT_USE_WELDED_WIDGETS
        environment variable.
        
        While those dialogs declared as supported in
        QtInstanceBuilder::IsUIFileSupported are meant to be
        fully functional, they are only a small subset
        of all LO dialogs and not all properties for
        widgets are evaluated by QtBuilder at this point in
        time (e.g. not all spacing, margins, text formatting
        properties,...).
        
        Therefore, default to VclBuilder again for now in order
        to have a more consistent visual appearance for dialogs
        with the Qt-based VCL plugins.
        
        This can be reconsidered in the future, but at least for
        25.2, sticking to VclBuilder by default seems reasonable
        to me.
        
        Change-Id: I7b275d3d3759093a6680327faeb3b86d7c623cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176013
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2a2c4dddf51c0d6ab726a8854123887bbfa7792a]

        tdf#153636 - Search for outline node only if index is for the current chapter
        
        Otherwise, "Use level from source chapter" does not work for Graphics and Frames in user-defined indices.
        
        Change-Id: I148a097276cf8a60d69a208266ceb9def0444654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175783
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-11-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5de26fbf37f02a9c5a0ae96140ec50167709eaf2]

        tdf#137680 Add extended tips for Skia options
        
        Change-Id: If525c808a1ad350c878cf8f80ee3289a0c6fcbb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175938
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [962bd03938e3e5cf513b91ed897ac11c248e827a]

        Simplify a bit
        
        SVG diagonal percentage distances are defined in terms of
        viewBox diagonal length divided by sqrt(2) (normalized).
        
        See https://svgwg.org/svg2-draft/coords.html#Units
        
        Change-Id: I0d2101315d5f6c3333d021251eff17f6c13e804f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175991
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [35b3abf5831fe05360f58dd7d292602785a55281]

        Simplify a bit
        
        The expression can't be negative. It's a Pythagorean sum.
        
        Change-Id: Ic07783c5291da71de6701a139227def2f1c4f77b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175989
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9e3803ae438ddcf91ec0e15431be379561d28ba6]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 609, 637
        
        Change-Id: I4376e86a5484886025152a9a407b23b3d05c3911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175355
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [84f85e8ad10ce1913dd530a85fee22cbc4d11ea7]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 734, 739
        V1037 Two or more case-branches perform the same actions. Check lines: 1031, 1054
        
        Change-Id: I835ac504eadcbdd44b2ee507f40e6f40ff5e416d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175318
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9a917ff65690b00cebb53f0c67bd91622a33351f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 778, 793
        
        Change-Id: I2437bbac1bc952720d4ea3c43107c9d5e1ef1655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175308
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f0d1b3a0a3708864cdea1c04e90f666984b28575]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 764, 767
        
        Change-Id: Ia8da107d28249132b92e7cf533505b09c0037188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175310
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e877bd2a25b391244abff329a83d8a2b0c656493]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 574, 577
        V1037 Two or more case-branches perform the same actions. Check lines: 738, 752, 759
        V1037 Two or more case-branches perform the same actions. Check lines: 1949, 1953
        
        Change-Id: I2a6b6cc16ff58d432e5a7b14a6a1d7fa4f1a15b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175313
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [22297112c55bc907a8f0b798e0fc7fd5812567c0]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 767, 777
        
        Change-Id: Ie9a6d6376f5037ee075c95e62c2c7970b720e9a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175309
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2143961a14c39be485f3a99dfe82b0c0a215b41e]

        pdf: move encryption methods into PDFEncryptor files
        
        Moving more PDF encryption implementation into common encryption
        files. This will make it easier to add new encryption later on as
        the code will be in one place.
        
        Change-Id: Id40c2f876a2e92bb8db27024a0e251befc5059e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176030
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4866d7f5ec7495dd00fa1da53189d0427c309e75]

        pdf: move EncHashTransporter into own files
        
        Also rename to EncryptionHashTransporter.
        
        Change-Id: I20f984af4428e1182c77dbce4343d69c106063a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176029
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a1d367dbad0e754f5977db231d0d709322e2b8c5]

        pdf: move some encryption code into PDFEncryptor class
        
        Refactored the code to make encryption easier to change.
        
        Change-Id: I24b831781d4acd6329838dbf2468e9df6efad41e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176028
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c8cba8ae30baef6feca3b0613366d28df4a5e568]

        move CryptTools from oox to comphelper so we can reuse it
        
        Also move the relevant tests and clean-up the names a bit to make
        it mroe consistent.
        
        Change-Id: I929ef9c13b954fd6a506471231d1bc41e4ef9980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176027
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6adbc3c7179fc3977a15867e505b4ea919caf765]

        pdf: Don't emit metadata for /Info, allow XMP for PDF >= 1.4
        
        Metadata written to /Info dictionary is deprecated in PDF 2.0 with
        the exception of /CreateDate and /ModDate, so don't write it if
        we are writing to PDF 2.0.
        Instead of this allow to write the XMP metadata all the way back
        to PDF 1.4 (when it was added to the specs).
        
        Change-Id: I33e29d7d52e96d34e973032d7d8b42d876282dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176026
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [152780e4340e12397a64320bc66185000871be35]

        pdf: add m_nPDFA_Version to simplify PDF/A versions
        
        We have a bool for each PDFA version, which is inflexible when
        checking if the feature is supported in a range of versions so
        this adds a version number which simplifies checks a bit.
        
        Change-Id: If162e305766baa61278872297c9ab1eb41cb57d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176025
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b0a6a402f00e966c24f5b1e74b9c8aefeb62af8b]

        pdf: move encrypt code into emitEncrypt, add PDFStructureWriter
        
        Move the encryption code into emitEncrypt and rewrite that with
        the newly introduced PDFStructureWriter, which is now responsible
        to write the PDF basic structure elements into a string buffer.
        
        The PDFStructureWriter will be extended with new features when
        there is demand.
        
        Change-Id: I4f4099886860b72b4f1866b19a8afb7cc8fb4ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176024
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cbc51154c02ec7a52a3ad047f3bab1670c9d481a]

        pdf: initial PDF 2.0 and PDF/A-4 support
        
        Added PDF 2.0 and PDF/A-4 version to enums. Write the PDF 2.0
        support for the file headers. Add the identical considitons as
        for the PDF/A-4 as they were for PDF/A-3.
        
        Change-Id: Iccf5afbf09c4cd0cd1ae7122c860e8cbefe3a6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176023
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [29fb374c5260898b081aa8993bc68f6ab66b6057]

        CryptTools: simplify the define conditions a bit
        
        Change-Id: I6ef207eae6fbeec2ba77fa46a3274e43d02fe1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176022
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d9a0beb0b4dc22cf57ccb53ea0a4ab5442c43550]

        pdf: PDF dialog set the default member var. values in header file
        
        Just a simplification and clean-up as this is easier to read.
        
        Change-Id: I8a920849d2bac7ae89d0d7b5f90421a7fac3a0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176021
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c749c21c5abba12f7caa979e5be9d02decb26919]

        comphelper: move tostring to hash.hxx so it can be reused
        
        tostring to convert a vector of bytes into a hex string is useful
        in other tests and implementation, so move it into common hash.hxx
        
        Change-Id: Iebc71919c6209222eb01b78c307420afddc8caca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176020
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-11-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f510ce620fba08e6aa8bc40af2e47f0b51caa66d]

        Add experimental support for Emscripten JSPI
        
        ...which I've seen fundamentally working when building with recent emsdk against
        recent Qt6 trunk (and including <https://github.com/qt/qtbase/pull/108> "Update
        the check for WebAssembly JSPI support") and running on recent Chrome (with JSPI
        enabled under <chrome://flags/>)
        
        Change-Id: I98c11c5ee7e95b135ddc33c95c95752055ecd4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176031
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-11-04  Sakura286  <sakura286@outlook.com>  [060d2fe39f27ffbb0e843de5031f6806c9abfce8]

        tdf#147906: Use hypot in place of sqrt to avoid overflow
        
        Change-Id: I575bc0c1b6e49ad8dc5db6b3e523ca7e0860aad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175537
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-11-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [182140d53ac767f5f31aefb2f00ac1f812245703]

        Remove commented out includes
        
        Change-Id: I7aed7953f8d101f145a4267168c90623022677f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176012
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-04  Heiko Tietze  <tietze.heiko@gmail.com>  [117bca21b7b068266bb91f1d114e435e0a7ab525]

        Resolves tdf#160626 - Preserve sorting in SvxStyleToolBoxControl
        
        Inserts now up to 12 default styles and adds only user styles
        that are not among the default
        
        Change-Id: I60ea3e46092681a932cf3fe470c2ce9fb3553917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176011
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [81694d9a0082b6c36f3896c6639352cb69266fd1]

        reduce OUString ref-counting in writerfilter
        
        Change-Id: I4a757bf3fec10722524b656b07f189629100ea74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176009
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-04  Heiko Tietze  <tietze.heiko@gmail.com>  [18ab433bfa00c8a513f3d899f735fb844e2688a4]

        Resolves tdf#163689 - Long comments must not enlarge properties dialog
        
        Change-Id: Ic4433b8c7f27790ea070ba66ef72ab531d9670d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176008
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-11-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [223696267759326af4e436e0330026e4ff8ee8e0]

        tdf#163736 - sc: fix searchmode cached values for lookup functions
        
        Check the search mode option in cache for lookup functions, because
        different search modes can produce different results.
        
        Change-Id: I6127a644dc4eae6fad909a6bc83bde2c66e85201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175972
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-11-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a3c66a31334f70ee0af2ed991c6cffb495b98e91]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76fd6af8937397407aca836ce2ffcf8d08219e07
          - Typos
            
            Change-Id: I18a9e94a27f6e19c26c9076b9bd6be307717169b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175987
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-04  Miklos Vajna  <vmiklos@collabora.com>  [c8606fc09b81d2666095d4cb4d8a813ef0ba1cc2]

        svx: prefix members of E3dCubeObj
        
        See tdf#94879 for motivation.
        
        Change-Id: I0e1dcb44cd46fdf40ae21c264017c8fc9ca96b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175980
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [910d67e442953f7da669157fe678f764c9623121]

        check stream state
        
        Change-Id: Ic79b14565e4c84cfeb8ce87994ed45fcb45df4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176005
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-04  Weblate  <noreply@documentfoundation.org>  [449df239a2a33d6789c12c1011c031b055cf0950]

        android-viewer translated using Weblate
        
        Hebrew currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I5a39070be19791e0f85ee32487bcca8a1876a9b8
        
        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: Iea0eb23bf7d58d78fd99668a8b057f3d9295a3fc
        
        Added translation for android-viewer using Weblate (Tagalog)
        
        Change-Id: I2f97dbf569d5eda71dfdd2a62c5563bd7918d43b
        Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
        Co-authored-by: famese <hmcb2080@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175682
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d0a1664d3b0365a0f243669fb2862288a316580]

        delete useless parts of GalleryCodec::Read
        
        no point reading this to just to discard it later
        
        the only places reading this are just opening, using
        and close the streams afterwards, so the need
        to even skip over this data doesn't seem to arise.
        
        Change-Id: Ieb2498f458534770c167bbbfb3a4792162238986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176004
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-04  Rosh  <roshsiddiq@gmail.com>  [550abc0f37daf5f78def278de556b2dbb5ddf127]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I44df7baf1d5bfdd45647c5b2ed99958d587ff61e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176002
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-04  Ming Hua  <plateauwolf@qq.com>  [d1dd3fa84f8eb2c1dc1f34c1ef669cbc5384e5b1]

        cui: Fix a UI string in a11y check options
        
        Commit d14e79bf7680db2180e40ba52fc3305a84c586f6 (Correct grammar in
        strings for A11y, 2024-09-18) fixed many UI strings in the newly
        introduced a11y check options with correct English grammar, but
        mistakely changed this string from "heading order" (which means the
        chapter and section headings) to "table heading order".
        
        This commit reverts the change and slightly improved the wording.
        
        Change-Id: I2957004d6b82d35841f57a76ca25fbf9b851b9b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175918
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [491d6ef7f297206b99ce01d4f2d00c75719ef243]

        Simplify a bit
        
        Change-Id: If30cac2426fe6de498066dbe9ec8465450d7ce0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176001
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-04  Skyler Grey  <skyler.grey@collabora.com>  [3a9caad863554b1a3465e9eb898f55f516c378d1]

        feat(json): Allow serializing any
        
        Previously, as far as I can tell, there was no way to send a Size in a
        .uno command (as would be needed in, say, '.uno:InsertAVMedia').
        
        We do, however, already have a way to send an `[]any`, and we can use a
        similar method to allow sending arbitrary types with `any` rather than
        `[]any`.
        
        To use this, the type you really want to send has to be wrapped in any,
        so for example...
        
        {
          type: "any",
          value: {
            type: "com.sun.star.awt.Size",
            value: {
              Width: {
                type: "long",
        	value: 0,
              },
              Height: {
                type: "long",
        	value: 0,
              }
            }
          }
        }
        
        Change-Id: Ic33594dee955d475d81733adb21950c0458435e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174740
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit cccbf8608f3b76651993bc8576c672367c228fa2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175982
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-04  Skyler Grey  <skyler.grey@collabora.com>  [eeb72ef257742e9d67927e976779468a78f1d402]

        feat(lok): Add extra impress export formats
        
        Previously we had the ability to export to various formats, but these
        weren't exposed in a way that LOK could request them. We want to
        increase the options available for export, so we need to make these
        available.
        
        Change-Id: I1c05aeec8de32929481059bcfd02cac05a46788d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174602
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 541272d3eaa322ccdd1b926add031a39faeccf49)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175981
        Tested-by: Jenkins

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88fe9c4903f65593785b3895e43e4e3ee17ba2f3]

        Drop requirement that there is internal/shared autotext.
        
        A user's autotext was not examined unless there existed some
        internal/shared autotext. There seems to be no particular reason
        for that, except that internal/shared autotext happens to generally
        be available.
        
        Change-Id: I43a9fe5916d3a0895b175db52758104cc7fd65b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [910ae381bd97df03eaeb0822f56c1f8cec7ac594]

        merge creating variable and assigning it
        
        Change-Id: I1c8533f5adf5ab1db88dc279fc8e9a21c38c66bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175976
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [051365a71fa51f8ef01a4c91a83f3e38472be58f]

        cid#1606943 Overflowed constant
        
        Change-Id: I056e45e19bb3794acbdf7b5c2b4ecb787e52de0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175975
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bca5b23b783bf20b0a030bab0e5b678e811a4a3]

        cid#1606699 silence Overflowed constant
        
        Change-Id: Ib3cac90e56bd00a777871f1b07849fabd7e307a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3c1b7e4fe7146f51afe1205b16a4063d73f93055]

        cid#1607290 silence Overflowed constant
        
        Change-Id: Ic05b5a64a3be44d8aba4c9ffaf8867a45f2422db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175973
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5de73f04f3db9c8fb488bf75b1860bf8378a5b45]

        new loplugin:staticconstexpr
        
        Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [dce64cc7cfd5f696ef0c030524558306687ae3c7]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 883, 893
        
        Change-Id: Ie722bffb7aa8cbdb38a5b1a244f5c5a072c26c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b18d007ad8073c57db5bc1eef9c1e326b9ed163c]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 815, 819
        
        Change-Id: I86c8065de5bb83671bcc499bb46b5e5723ec01d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [3a22bb69724ba938e0c5340bd588308d83383a3c]

        Simplify a bit
        
        Change-Id: I5c6110cc26e8fb20066374dc235677f07e79ce1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175977
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [5debf32cf09e865f2b241df3edd8461b92b5c1bf]

        tdf#163486: PVS: pointer not released in destructor
        
        Since
        commit 7ef3b46fd5bdfb3a87e9b0a840287fdb6ff4734b
        Author: Gergő Mocsi <gmocsi91@gmail.com>
        Date:   Thu Mar 7 11:57:04 2013 +0100
        
            fdo#35546, implementing 'Create Photo Album' function
        
        V773 	The 'm_pGraphicFilter' pointer was not released in destructor. A memory leak is possible.
        
        Change-Id: Iee1c4f4f3ae5232506563a219ffdec61f74fcff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175884
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-11-03  MelvinYG  <melvingeorge204@gmail.com>  [e04742c0a55f0361bf9bae19c65fe21a3099e60a]

        tdf#145538: Use range based for loops
        
        Change-Id: I1865d2fab8d29bfbc81b10a9497b47c5c94f1af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175186
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [3015db08c9a8a1b29af1018044955c905c9015aa]

        Related: tdf#163730 Avoid potential deadlock
        
        Similar to commit 43e5118496ae0c9b8f81a54574874eda7d439dbb (Related:
        tdf#163730 Avoid deadlock, 2024-11-03). I haven't seen this scenario
        myself, but seems likely to be possible.
        
        Change-Id: Ie6bb69e7ebe12a69e4dabee9103de32611235807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175971
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-03  Barry-Thomas-Paul: Moss  <vibrationoflife@protonmail.com>  [c8c66eb20d8c3e51a425514ed82f6a07f3e7928f]

        Updated getPackageName2PathMap
        
        Update getPackageName2PathMap to use ExtensionManager
        
        Change-Id: I22c00aeb27913f138da00d304b9f238787459d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174877
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e2b4e9765503f0beb30cc5298c36ededc0063c1]

        tdf#163486: PVS: parameter is always rewritten
        
        Since
        commit a9a665ed7a3198f4c0f6e521520491353ccfb182
        Author: Szymon Kłos <szymon.klos@collabora.com>
        Date:   Tue Jan 5 14:54:52 2021 +0100
        
            pivot table: make partial sum message box async
        
        V763 	Parameter 'pSrcErrorId' is always rewritten in function body before being used.
        
        Change-Id: I51c2d1b0d01563d66e828d3ebfaf61f620992443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175876
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b1a6af0edd517e073545b89114169467c666a761]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 82, 118
        
        Change-Id: Iae91b2079c1c1d5aeb3000495364f3995266cbe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175274
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [937167cbc30f7f9b26e444eb03bc7dbda0464ff9]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 8172, 8405, 8484
        
        Change-Id: I85ff9c6258fc855323c1ee814b981b3453db7651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175275
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7455410b07183a843566d3ad8e8f66c564cd0a73]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 843, 850
        
        Change-Id: I82df65a66b98e115bebfccc6ca1c9567533bd651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175267
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c83f22357212e434d759a7fa9905bae1691b066c]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 91, 94
        
        Change-Id: Ie7c803398eb1ce016a2f7a2a71b5d1a283266cc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175237
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-03  lynn_edem  <m.edem27.me@gmail.com>  [961f8bdce4f81d56922670bcde3c0cd0238811d5]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: I3ff0f661a3b4109b79ec13dad4e3472378048ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175705
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-03  Justin Luth  <justin.luth@collabora.com>  [c8cfe6822f148d6f4ac545a9c66f17c4bcb1d9a3]

        tdf#161349 writerfilter: only copy page background vml fill
        
        This fixes my 24.8 regression.
        
        I had this clause in earlier versions of the patchset,
        but it moved along with most of the other logic
        to the initialization of the default page style.
        
        However, I certainly need to limit copying the properties
        of the default page style to ONLY the fill properties here as well.
        
        Change-Id: I168f13ebeea3720eba53703210314f069fb87ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175963
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [9f53d40fd19b22fe1bdbf64e8ce751cf53f4f517]

        Related: tdf#163730 Avoid deadlock
        
        Seen locally, with main thread querying clipboard state:
          vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 145
          vclplug_winlo.dll!CWinClipboard::getContents() Line 109
          vcllo.dll!TransferableDataHelper::CreateFromClipboard(const com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard> & rClipboard) Line 2162
          vcllo.dll!TransferableDataHelper::CreateFromSystemClipboard(vcl::Window * pWindow) Line 2188
          swlo.dll!SwBaseShell::StateClpbrd(SfxItemSet & rSet) Line 602
          swlo.dll!SfxStubSwBaseShellStateClpbrd(SfxShell * pShell, SfxItemSet & rSet) Line 2220
          sfxlo.dll!SfxDispatcher::FillState_(const SfxSlotServer & rSvr, SfxItemSet & rState, const SfxSlot * pRealSlot) Line 1726
          sfxlo.dll!SfxBindings::Update_Impl(SfxStateCache & rCache) Line 267
          sfxlo.dll!SfxBindings::NextJob_Impl(const Timer * pTimer) Line 1280
          sfxlo.dll!SfxBindings::NextJob(Timer * pTimer) Line 1225
          sfxlo.dll!SfxBindings::LinkStubNextJob(void * instance, Timer * data) Line 1220
          vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111
          vcllo.dll!Timer::Invoke() Line 75
          vcllo.dll!Scheduler::CallbackTaskScheduling() Line 509
          vcllo.dll!SalTimer::CallCallback() Line 53
          vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 169
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385
          vcllo.dll!Application::Yield() Line 473
          vcCMtaOleClipboard::runllo.dll!Application::Execute() Line 361
          sofficeapp.dll!desktop::Desktop::Main() Line 1679
        
        CMtaOleClipboard::clipboardChangeNotifier thread holding CWinClipboard's
        mutex in handleClipboardContentChanged, and waiting for the destruction
        of IDataObject released from m_foreignContent (which was redirected to
        CMtaOleClipboard::run thread):
        
          vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 235
          vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 163
          vclplug_winlo.dll!CAPNDataObject::~CAPNDataObject() Line 97
          vclplug_winlo.dll!CAPNDataObject::`scalar deleting destructor'(unsigned int)
          vclplug_winlo.dll!CAPNDataObject::Release() Line 137
          vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 235
          vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 163
          vclplug_winlo.dll!CDOTransferable::~CDOTransferable()
          vclplug_winlo.dll!CDOTransferable::`scalar deleting destructor'(unsigned int)
          cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 230
          vclplug_winlo.dll!cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable>::release() Line 115
          vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::clear() Line 234
          vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 291
          vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 385
          vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 721
        
        and CMtaOleClipboard::run thread waiting for CWinClipboard's mutex
        in CWinClipboard::onReleaseDataObject:
        
          vclplug_winlo.dll!std::_Mutex_base::lock() Line 52
          vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 145
          vclplug_winlo.dll!CWinClipboard::onReleaseDataObject(CXNotifyingDataObject & theCaller) Line 362
          vclplug_winlo.dll!CXNotifyingDataObject::Release() Line 75
          ole32.dll!CClipDataObject::Release() Line 960
          combase.dll!...
          rpcrt4.dll!Invoke()
          rpcrt4.dll!Ndr64StubWorker(void *,void *,struct _RPC_MESSAGE *,struct _MIDL_SERVER_INFO_ *,long (*const *)(void),struct _MIDL_SYNTAX_INFO *,unsigned long *)
          rpcrt4.dll!NdrStubCall3()
          combase.dll!...
          user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!CMtaOleClipboard::run() Line 655
          vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 673
        
        Caused by changes in commit 2e0664015255ffc0f76a11a9cb254564b34de496
        (tdf#148647: make sure to update own content on Win clipboard change,
        2024-07-14).
        
        Change-Id: I26d35726f3d3f650a2db2ac63709ed820a60fc4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175956
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-02  Chris Gill  <chrisgill948@gmail.com>  [594554e07a952c1aaee9b96d4259bc8418b46ee9]

        tdf#163738 use insert function instead of for loop
        
        In the unit test CppunitTest_xmlsecurity_pdfsigning
        use std::vector::insert() in place of a for loop.
        
        Change-Id: Ib51f0ec6932210befe3c7aad9a6b5c8989bfe839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175337
        Tested-by: Jenkins
        Tested-by: Hossein   <hossein@libreoffice.org>
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [ad686b26cec93653b67642f79bace16df0fd1348]

        No need to use SAL_THROW_EXTERN_C macro in CXX
        
        Change-Id: I6eb9f0431a9402479a2d90d5b6f68b611d52a9f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175957
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-02  Bayram Çiçek  <bayram.cicek@collabora.com>  [a9d1324b1dbf4a74ee0b02859eb3197005df1bb2]

        use row&column address for autofill preview popup
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I2206f13210f57db27d962f931ec9b1ced5ec8cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174502
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 2a3053921ee67e305130fc3dee6278c00f737e92)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175917
        Tested-by: Jenkins

2024-11-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [addad96a7a92f33746e2958bd398e4211015e957]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02fd40af9c8a62babb4d8549be8af8dcd39f7635
          - Tweaks for text function for navigation (3)
            
            Change-Id: I6a4246acf9e6ade45e9692a24fb358fc44a90a05
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175955
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-02  Dione Maddern  <dionemaddern@libreoffice.org>  [3946889b811c0610a5e7e3a21f8c8478b10b1964]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e2903bddbdf7d9a4b10aba32a30b48d70e2feb4e
          - tdf#163053 Add Help page for Comments sidebar panel in Writer
            
            Create a new page text/swriter/01/sidebar_comments.xhp to document the Comments sidebar panel feature.
            
            In AllLangHelp_swriter.mk
            - Add new page to repository
            
            In text/shared/01/04050000.xhp
            - Add section and variable tags to allow the page to be easily linked and embedded in other pages.
            
            In text/shared/optionen/java.xhp
            - Add section and variable tags to allow the page to be easily linked and embedded in other pages.
            
            Change-Id: I782c6483b07cc1b7d7b3566fe4664927740387af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175915
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [b800b10737b5df377d8e06e920f10f955b8ddcad]

        Simplify a bit
        
        Change-Id: Ia297a94b9fe06074e06ca573173a9e9c41834240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175954
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [4f1c88bb57ba0ceadb847e4ce6a00528ad9e7ada]

        Simplify a bit
        
        Change-Id: I2e4635c660a57abefa57b046e3f0da411939cf1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175953
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5f54f2e43ad5fcfbc0cc074045742956505df0b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3a67ce44369193e2089a35c5d106d3a115ec03c5
          - tdf#137680 About Skia
            
            + Added precision on the use of Skia graphic engine vs. system GDI
            + Added bookmark entries
            + refactor
            
            Change-Id: If47fb8a7f251f70db26c8ba060d0257a28b15dc3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175936
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-02  Pierre F  <fpy@bger.ch>  [6ead41a0fc113abd64cf3fac8cddae73c309d08d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b6506e4e1b6b4dd41f4e5e8fda8315426c57d9c
          - tdf#143846 split PROPER REPLACE REPT RIGHT SEARCH ...
            
            ...  SUBSTITUTE T TEXT TRIM UNICHAR UNICODE UPPER
            
            Change-Id: I2ef1a659fbaf481dac1329f86178b8cd9b786ce2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175912
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-11-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [41a2a201f0dd3636d63e43a9ee13e9a23482eba3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40bbfa8f4fb070b66481068b952755d04854db2c
          - tdf#145161 Update Help per renamed label, Change image resolution
            
            Change-Id: Ie62be5e67652512ea850654e83d5c873c5030cb5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175949
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e9cfad321b55a431fcfeaaa444322b6034e39a8]

        cid#1494598 Uninitialized scalar field
        
        since:
        
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        CommitDate: Wed Oct 23 18:26:07 2024 +0200
        
            tdf#131728 sw inline heading: fix missing/broken DOCX export
        
        Change-Id: I15971c085af3ec20a44dd49865a979e974f7572a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-11-02  Adesola Samuel  <adesolasamuel2022@outlook.com>  [9b2c470c317fcf3cb248c4fffbbe21f4311205b2]

        tdf#145538 Use range based for loop in textsh1.cxx
        
        Change-Id: I6e902b6947a27fe234d321ed3055dd0f867138a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175940
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-11-02  Adesola Samuel  <adesolasamuel2022@outlook.com>  [3b8d833dba336e3baf3552e89aeb2695dad41960]

        tdf#145538 Range based for loop cannot be used in SfxBroadcaster.cxx
        
        The loops in this file cannot be range-based because vectors
        can change size inside the loop.
        
        Change-Id: I0f3d3d768b69bb280962541a237f5ec02874dbdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175866
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [35dbbcefb2a31c211a879eb7d5cdd267dd763ccc]

        Fix unchecked dereference
        
        After commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1
        ("tdf#159565 prerequisite: make hidden sections have
        zero-height frames", 2024-02-15).
        
        Change-Id: Ie990dcaf519329382b5088f31e6f534445470229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175944
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-02  Aditya Sahu  <adityasahu1511@gmail.com>  [412a775d0ab90cd963216c40e9ae1189179809ba]

        tdf#145161: Change pdf and image compression dialog string
        
        Since image/pdf compression does not always reduce image
        or pdf resolution, change the misleading label from
        "reduce" to "change" wherever possible.
        
        Keep identifiers having "reduce" in their name as is
        as of now, only change the string values containing
        "reduce" to  "change".
        
        Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-02  LeSci-0x1  <sscire@csumb.edu>  [b53242ec23cd34f7f42750cd4d01f3384c827b76]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I8ace16d16c900b6cec8fa454250dcdb1698c0677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175890
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-11-02  Jonathan Clark  <jonathan@libreoffice.org>  [43cd683230bc05d294b1bd64f1e7932feccdd3fb]

        tdf#36709 Add loext:text-indent supporting font-relative units
        
        This change adds an ODF font-relative first-line indent paragraph style
        attribute as a LibreOffice extension. The corresponding ODF standard
        change is tracked by OFFICE-4165.
        
        This change only implements what is minimally necessary to serialize,
        deserialize, and check for ODF files containing this attribute. Further
        changes are necessary.
        
        * Added cssLength to schema, which is equivalent to length but also
          allows ic and em as units.
        * Added loext:text-indent to schema as a paragraph style attribute. This
          attribute is equivalent to fo:text-indent, but accepts cssLength
          instead of length.
        * Added XML_TYPE_UNIT_MEASURE to the ODF parser, which currently accepts
          only the font-relative measures and forces fallback in other cases.
        * Added loext:text-indent to the ODF parser. This attribute accepts
          font-relative metrics, and will behave as an import-only alias for
          fo:text-indent in other cases.
        * Updated SvxFirstLineIndentItem to handle unit-denominated measures.
        * Added proof-of-concept indentation handler to Writer. This
          implementation is incomplete and temporary, and will be revised in
          future changes.
        
        Change-Id: I7eb5c7382093cb18a9b0afbf93dacb34ba1d35ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175941
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [db7cd5032068c5b9faa4c707db204b58c1dbf2b2]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 2743, 2797
        
        Change-Id: Id998cf92bb6d1540b7498138546618b350e52363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175157
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c0975e6344bf93921655a8f362660b181f564ee2]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I2874ce6a61db592b43cfa5d8de682daa520d51b8
        V1037: Two or more case-branches perform the same actions. Check lines: 303, 315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175151
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [38dc12033fb609b3097b3100efb4a459aa233164]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I65edd548d9ed4fbc5589f354280dbfb90e2a9064
        V1037: Two or more case-branches perform the same actions. Check lines: 171, 177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175148
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e182b2a0a43022a371130874a41fbf4f0bb08ffe]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Ief90706c81423116efa2507e1e2bf2b4eee1a2fc
        V1037: Two or more case-branches perform the same actions. Check lines: 256, 287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175145
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6ce9e887158c20c37dc0f5c06f1e236c007229af]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I2f34381ccf0e9649874652b382e43fbd1737577a
        V1037: Two or more case-branches perform the same actions. Check lines: 121, 127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175147
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-01  Pranam Lashkari  <lpranam@collabora.com>  [dbf963f8995f3213b9c21b3893aa20c1cc5f0c27]

        sc: fixed incorrect conditional format list usage
        
        problem:
        incorrect list was fetched caused problem when edited the condition
        
        Change-Id: Idd277074b94bed13327fd1e58f80a5ab7697c7b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175766
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 5690f62d3226d6a91dfdc79489b74c726870f683)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175911
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-11-01  Pranam Lashkari  <lpranam@collabora.com>  [a9235b93ff7d2751a5cd96f6299a0507aba96713]

        sc: fixed crashing on conditional format entry selection
        
        Change-Id: I40e5b77cb98803664cff0db370f3079431820129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175765
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 69c6ce6d8c6c6a6f9e3f0ea1319dbdb2190ccaab)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175910
        Tested-by: Jenkins

2024-11-01  Jonathan Clark  <jonathan@libreoffice.org>  [6f16beca51c86e0decfde71236174b5e45a9e904]

        tdf#36709 Refactor Converter to separate parsing from unit conversion
        
        Previously, Converter::convertMeasure parsed measure strings and
        performed unit conversion in a single call. This was appropriate, as all
        such measure strings could be converted to a common unit ahead of time.
        
        tdf#36709, however, will introduce measures that are relative to the
        current font and font size. In order to perform layout, the original
        measure unit must be preserved and passed along with the original value.
        
        This change introduces Converter::convertMeasureUnit, which parses a
        measure string and returns both the value and the unit. Existing unit
        conversion code has been refactored to facilitate this change.
        
        Change-Id: Ic8dfda432e1ca117ad80c05c1939ebaf43e79a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175937
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e90e601d5b460d707b41dcb1c9da74b223aae584]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd5de8ddaf11d56768f31c675b03346aac1b7ff0
          - Tweaks for text function for navigation (2)
            
            Change-Id: I5fb676334f398441aa8505ccba3f3344b4c3c3e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175932
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c280a6de9cba0ba0cc9f1ae2ee120c0011eca09]

        tdf#163667 speed up spreadsheet with lots of cond formatting
        
        Attempt to avoid the cost of GetCondResult when dealing with large runs
        of identical cells
        
        Change-Id: If9192a9858e6785263ea1621e98d1b1d5de74c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175909
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 7d7d94b7713d86e2fd972c3b81845eaffb5761e5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175898
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-01  Pierre F  <fpy@bger.ch>  [0746914ed0778ff82329162508985fc6f7655aba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1fd4ec9539b4403f5a87ab42da93fe2f05a5388b
          - tdf#143846 split EXACT FIND FIXED LEFT LEN LOWER
            
            Change-Id: If4635fad96157ae6b91c77aa574c1bfb3351d35c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175858
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [f1367a41e1ba74f8bb851a7e748ad53d3260e64e]

        tdf#163703: export formats for FIELD_ID_ANNOTATION
        
        It was omitted from commit 842160190e2996efbd936191eed787f3f79ed7b7
        (INTEGRATION: CWS notes2 (1.77.24); FILE MERGED, 2008-02-19), and
        the field type was skipped from autostyle export phase. With commit
        69ed893087f89d176a5ec4b263ce8d75774be72b (tdf#160253: fix list
        identifier export decision code, 2024-04-24), this surfaced by not
        exporting comments' formatting.
        
        Change-Id: I84a8d5616c37af093404fefb4d1ed3a212000f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175899
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [f48198c5f35113f1a68e18ae100e129932928157]

        use double in SwFntObj::DrawText
        
        after
          commit 11b15571475414ef853e21a6c96afa2ac81f848f
          "convert KernArray from sal_Int32 to double"
        
        Change-Id: I9921ff98bc6f6eb82b0f94771b02d9b9f4dcec4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [92c39395127c869ee1014a70ed336496e26c974a]

        use double in SpaceDistribution
        
        after
            commit 11b15571475414ef853e21a6c96afa2ac81f848f
            "convert KernArray from sal_Int32 to double"
        
        Change-Id: I22f26e20f2115079dfe90189f580c4e7989a256b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175872
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f56a80b205555cfc85b01b4f641ab7f78968403]

        use double in SwScriptInfo::Compress
        
        after
        commit 11b15571475414ef853e21a6c96afa2ac81f848f
        "convert KernArray from sal_Int32 to double"
        
        Change-Id: I566fbb04a20e5d0ed64c1f43e51fe3323e5b2f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175868
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cb0d41896bf6ce206f5bc5bc0d24fb660c4cb38c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96790dd123586754c563544c30f303906fdbeb36
          - tdf#149220 Add help page for login/password dialog
            
            Change-Id: Ib8ed094d607bdfc62f608f7ea0fe61bb9fb03ca8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175889
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6768924eebc3e6bc731c69e9a3a53781e0cb6f8f]

        fix GetBackColorFilterEntries missing colors
        
        Because the bCondBackColor var is outside the loop, once it is set to
        true, it stays true for the remainder of the loop, which means we might
        miss picking up a new background color.
        
        ever since
            commit 8b2369236dea7d6863c2df3d4ce5e356c9c8010c
            Author: Henry Castro <hcastro@collabora.com>
            Date:   Thu Nov 23 11:49:15 2023 -0400
            sc: fix back color filter entries
        
        Change-Id: I85625941fcd67fac7aabc24d43b2a56999e337db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175896
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2024-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d0bb94b5501b0a9917944d2d6cac7a848dd7c580]

        Use one 'find' instead of three
        
        Change-Id: I2b2167ecc1e037d7ab2809202a1ac77d7d65a3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175906
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-01  László Németh  <nemeth@numbertext.org>  [49765a9e7be41d4908729ff7d838755276b244cb]

        tdf#48459 tdf#131728 sw inline heading: new frame style: fix DOCX export
        
        Export Inline Heading frame style as OOXML style separator,
        fixing interoperability of the newly created inline headings.
        
        Remove frame grab-bagging, use the new Inline Heading
        style for round-trip of DOCX documents. Note: paragraph
        grab-bagging is used only for the case, where no frame
        created for the inline heading (second or more inline
        heading paragraphs in the same paragraph layout).
        
        Now the DOCX import uses anchoring as character, fixing layout
        problems of short paragraphs with big size headings anchored
        *to character* previously.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words",
        commit d87cf67f8f3346a1e380383917a3a4552fd9248e
        "tdf#131728 sw inline heading: fix missing/broken DOCX export"
        and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
        "tdf48459 sw inline heading: add Inline Heading frame style".
        
        Change-Id: Idc5f366c7a34f6e018683744475fc87aed0a3d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175835
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-11-01  Michael Weghorn  <m.weghorn@posteo.de>  [1bcc1f5a00fb7de95ffca1b2d7b8bdb2d58576a8]

        tdf#130857 qt weld: Actually set link button URI as URI
        
        Fix copy paste error:
        Take the value for the "uri" property whose existence was
        just checked, not the "label" one again as a few lines above.
        
        Change-Id: I1bf1251c14ba9dbda2b2f4ea73d35b612f4d0bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175888
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [9732a89b6bfff019ca0ac816cd821f049ab6ebbf]

        Drop GraphicFilter's bUseConfig
        
        It controlled how the FilterConfigCache initialized, and also how
        the unused aFilterPath was initialized. The FilterConfigCache is
        reused, when there are other instances of GraphicFilter - so that
        means, that the "bUseConfig" flag doesn't necessarily mean that
        the initialization will happen as intended: the existing instance
        could have been initialized using the other value.
        
        Avoid this indeterministic behavior, and always use the config,
        except in fuzzing. The VCL tests, that could possibly once depend
        on that, now use config, so this is not an issue - and that means
        testing the same thing as used in the working code, not something
        different.
        
        Change-Id: I6555dc47328b362e020138cf454f5ede7f39d063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175894
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [5c2778037f16784482088aa4008a7bf27aa7bd50]

        Merge ImplInit into ctor
        
        Change-Id: I41ef9a3660cbb897074ec2bb2f234706d8b68de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175893
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-11-01  László Németh  <nemeth@numbertext.org>  [a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8]

        tdf#48459 sw inline heading: add Inline Heading frame style
        
        Add the new frame style Inline Heading with default variable
        width and anchoring as character to support UX better
        – and later, – interoperability.
        
        Note: the previous commit (7a35f3dc7419d833b8f47069c4df63e900ccb880)
        used the Formula style for inline headings.
        
        Note: adjust check_styles.py unit test according to the extended
        frame style list.
        
        Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
        "tdf#48459 sw inline heading: apply it on the selected words".
        
        Change-Id: I615a53803d755acfbabb77fe53b0e5b60fa9fcc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175834
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf14352cd8eeb202f0b3a57a14909435818931bb]

        no need to heap allocate these
        
        Change-Id: I28127f5943a80aca1689d5982cd1f6e6e11eb2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175863
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6bd9f1f93301756bdc6fa57911d163e9fa5ad313]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 78, 91
        
        Change-Id: I912657b129f90f03bbbb9d47d0d954db2c6c5e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175307
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [33b2824fb5328cd62e099d5d654194ca6de79452]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 7998, 8001
        
        Change-Id: I9ecb950ff3201265678816e42f1e7976112b7557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175305
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [42ee2dfc4065f92879d490bf9b3ad34e9564c0f3]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 736, 796
        
        Change-Id: I612647fcf1f5ebb86c36373501b505b503a8fef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175317
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [34e27e2cb8c2fd487a160bb57d27db9dae8ebf05]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 780, 786
        
        Change-Id: I9152c711ab25f0e4cc60ce67c2ad1089cca6992e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175306
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c818bbfb2c2703e29ce17cf4a319a6d520216e70]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 352, 369, 549
        V1037 Two or more case-branches perform the same actions. Check lines: 672, 689, 784
        V1037 Two or more case-branches perform the same actions. Check lines: 740, 771, 801
        
        Change-Id: Ifc34cc2c283138b226b5487a838a93d97e45056e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175312
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1b8c22c319c6d1dcbfcd64d209bc2ea496b1ee68]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 438, 446
        V1037 Two or more case-branches perform the same actions. Check lines: 442, 450
        V1037 Two or more case-branches perform the same actions. Check lines: 483, 659
        V1037 Two or more case-branches perform the same actions. Check lines: 492, 896
        V1037 Two or more case-branches perform the same actions. Check lines: 501, 791, 944
        V1037 Two or more case-branches perform the same actions. Check lines: 549, 725
        V1037 Two or more case-branches perform the same actions. Check lines: 552, 842
        V1037 Two or more case-branches perform the same actions. Check lines: 618, 642
        V1037 Two or more case-branches perform the same actions. Check lines: 648, 734
        V1037 Two or more case-branches perform the same actions. Check lines: 698, 854
        V1037 Two or more case-branches perform the same actions. Check lines: 974, 977
        
        Change-Id: Iadd03f3813deaffcebdb1a661489b86b83bf9d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175219
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-11-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [dea5d561ba3eb3db8e8d86423cf23acdfe0b2b84]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 632, 642. But it seems FRAME case was omitted, based on the above switch (line 591).
        
        Change-Id: I781aa8b47bdc969fa8e3e20297c94da71919a33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175351
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [665dce4442e48b133b9fe1a2eb792ed3ef81d90c]

        tdf#163486: PVS: check GetView
        
        V1004 	The 'GetView()' pointer was used unsafely after it was verified against nullptr. Check lines: 596, 606.
        
        Change-Id: I4bf5366f49794c2956b0f704c32829c9dac6d5b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175883
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c930b7e68998dfc9cfc1c10ea065c307e6608c3]

        tdf#163486: PVS: check getViewShellBase
        
        V522 	There might be dereferencing of a potential null pointer 'getViewShellBase()'.
        
        Change-Id: I19becd2a40a7e996b6634c20df309d171ebbaf1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175882
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [de4ef353503c794f72e6e0bbca41fd5beb25aafe]

        tdf#163680: fix fixed-length strings assignment
        
        Change-Id: I4aa8144df5dfb836ad0689c7855301b8b04da485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175878
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [9a07b6c34c12d998b0428a5f70a4833bade3ef1f]

        tdf#163697: avoid premature handling of following notifications
        
        This avoids re-entry to Document::handleParagraphNotifications, which
        already was known to be problematic (see comments in Document::Notify,
        and m_bSelectionChangedNotification introduced to avoid one such case).
        
        Change-Id: I9e0b451f13ad109d08b1afc9cc0346cd6049b026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175879
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [15eb26d0f22c621f81086fc8d3c6525838adb426]

        ofz: Undefined-shift
        
        Change-Id: Ibb42de616566aabdf6596b7c45d0afab90118bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [52a91c1e329f07ea0c7e1de364f0a6f50c039053]

        tdf#163486: PVS: Initial and final values of the iterator are the same
        
        Since
        commit 4a4602ad7513262a6c0423f17b42791a852b7e23
        Author: Michael Meeks <michael.meeks@collabora.com>
        Date:   Fri Mar 10 10:36:22 2023 +0000
        
            lok: add trimMemory capability, and expand dumpState to caches
        
        V625 	Consider inspecting the 'for' operator. Initial and final values of the iterator are the same.
        
        Change-Id: I9ddd2593ace4234f720a6561b0dcbd85dbc18ef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175880
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-10-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [288d720e4940d8fdd71715e6d339765e90716931]

        tdf#162666 Make SfxStateCache handle Items correctly
        
        SfxStateCache had problems processing the extra Item
        states disabled/invalid. Note that due to not using a
        Pool here it is not possible to use an ItemSet or an
        ItemHolder, those would automatically handle these
        cases correctly.
        In this cache, this currently needs to be done
        handish. Also note that because of that this may break
        again when changes in the Item/ItemSet/ItemHolder
        mechanism may be done.
        
        Change-Id: I007bc25c727e6432062fa0d2af8215a912cb2fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175871
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-31  Michael Weghorn  <m.weghorn@posteo.de>  [a58d37eb5061436b9732d933d1970938f55a5872]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd8e67a6f9d2cbf27e223f76bf96bc6cbae06b45
          - Drop help for removed "Support assistive technology tools" option
            
            This option no longer exists in the UI since LibreOffice core
            commit [1]
            
                commit 069d2c079664cf44fc471216b1204cb71a6362cd
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Mon Oct 28 21:12:48 2024 +0100
            
                    win a11y: Drop "Enable AT Tool support" from options UI
            
            , so drop the corresponding section from help, too.
            
            [1] https://git.libreoffice.org/core/commit/069d2c079664cf44fc471216b1204cb71a6362cd
            
            Change-Id: Icd48d2db877f18aa31500e590c485c7237a5d958
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175881
            Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
            Tested-by: Jenkins
            
2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [87b4701c07fa0bb80985319042e9139a2ffd6af4]

        cid#1607569 silence Overflowed return value
        
        and
        
        cid#1607406 Overflowed return value
        
        Change-Id: Ia7917f9046382c25232415b7eb1de3b60071957a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175838
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c0795f059191e0c3980b65b1621a27f988fced3]

        tdf#163486: PVS: parameter is always rewritten
        
        Since
        commit 1e589375228b4dcee4a38122b34aea0720f888c0
        Author: Szymon Kłos <szymon.klos@collabora.com>
        Date:   Wed Aug 10 14:43:51 2022 +0200
        
            Make Autofilter MessageBoxes async
        
        V763 	Parameter 'nCol' is always rewritten in function body before being used.
        
        Change-Id: Ibb8a8b63887d06913fffe310a6754fdbba8c61ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175875
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-31  Heiko Tietze  <tietze.heiko@gmail.com>  [1a5b1552d8cee042466fc4c4ae5383c0ffbeb194]

        Resolves tdf#163537 && tdf#131253 - Make Boundaries independent from NPC
        
        Sections and Objects are now toggled on/off independently from Text Boundaries. Both, single and multi-column sections receive a frame (multi-column in addition one for text boundaries).
        
        Partially resolves 5bf7df62645f73ad69772f318ea3058dfd6fce12ommit.
        
        Change-Id: I6d43f936c3d2e1c454fdc39f1bbbb2c6f7bef3e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175832
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-31  Julien Nabet  <serval2412@yahoo.fr>  [9c1f25609a8c93243d8a8f34e31596bf92c591db]

        Related tdf#163679: fix tip for Insert Field menu in notebookbar ui
        
        Change-Id: Id471cc037e23deab48644086682c7a09a8645ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175874
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9af5beb9dab7bba089bc4b632cfa9c3047645e8]

        use SAL_WARN_IF here instead
        
        Change-Id: Iaeac042caec04e5bda5c23d22995e509e9fe824a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [92de9528f4df53f829c524a26dbb8441ec296c3d]

        Don't store iterators
        
        The iterators are invalidated on insertion / deletion;
        store indices, and sanitize when obtaining iterators
        
        Change-Id: I96ef4ca5bef4f686b5633cc736981dd5454dbca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175852
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-31  Adesola Samuel  <adesolasamuel2022@outlook.com>  [71d2849bf62c21672626cc5fa9729677ef5ef292]

        tdf#153138 Add IgnoreTabsAndBlanksForLineCalculation compat opt to dialog
        
        IgnoreTabsAndBlanksForLineCalculation was added to the option->
        writer->compatibility options with the label "Make whitespace
        character height not affect line height"
        
        Change-Id: I8b99409b01ba2af635018d15cde2e549dff92732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175831
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50a0bb366da12eab4ac673609c8335102915171c]

        cid#1607783 Data race condition
        
        Change-Id: Ie1a4fac64db52c584c183b132d57c588bcc56567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175840
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1e9eca1af58d19820ce61a178bf6049def7cadc7]

        cid#1607945 Data race condition
        
        Change-Id: I8c00cab53b775d042f183abef324fcabc9a9c73e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175839
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-31  László Németh  <nemeth@numbertext.org>  [bb4da18c55dff7e6d1146fa70a83c84dea68807f]

        tdf#163699 sw: fix reported crash using the Navigator
        
        "On a specific file, when double-clicking multiple times on
        different images in the navigator panel, LO crashes."
        reported by Vladimir Tarakanov with a code pointer.
        
        Regression since 3e0650fb166cac116a43f6ce5d03bd69830e37b8
        "tdf#157533 sw: fix cursor position deselecting formula in table".
        
        Change-Id: I550d61d8ee10205ff2357c2511ae0062077d651e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175865
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c200de99582c0b961748202a3e40985b3f8aa4f]

        cid#1606874 silence Data race condition
        
        Change-Id: I6703ee228ac0717b04f58e14eedd02ab0722edf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175861
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [9ea9cd14ffc69e6597996da09943e1ce11a50d6f]

        tdf#163457 CairoSDPR: Need to apply 'damage' to gtk
        
        If a CairoSDPR does directly render to a Window the changes
        do not get reliably visualized due to the Cairo backend
        and gtk/QT usage being dependent of being told what
        'damage' is done to refresh the window accordingly.
        The VCLCairoBackend is doing that, but without reach
        from the outside.
        Note that this is a rare case, in fact the 1st one discovered
        where a CairoSDPR is painting to a Window directly, see
        comments in the task. Even this occasion should not do
        that - showing the Comments in Calc on the Overlay would
        be major to just painting to the Window roughly.
        There are other possible workarounds (also see comments in
        the task), but just adding to be able to set the needed
        'damage' in case target is a Window is simplest and
        potentially the fastest way to do this.
        Since usage of CairoSDPR is bound to use GetSystemGfxData
        anyways it is okay to react there and call a method
        ApplyFullDamage that exists on Graphics when the flag
        USE_HEADLESS_CODE is active. That forwards to the
        CairoCommon being responsible for that Window and does
        the minimal necessary to apply 'damage' to the full
        Window.
        This is done when constructing the CairoSDPR, thus
        from the timing that incarnation can then paint anything
        and it seems that at the next occasion something can
        handle the callback from gtk all is painted. If that
        should change it may get necessary to separate
        the usage of ApplyFullDamage from GetSystemGfxData,
        but works as intended for now.
        
        Change-Id: I5442f3413e43418954da29a18d66dea27e25e655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175794
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [298feac9c4d4204bdb6680f3bdd4ab97b2a6dad8]

        No need to heap-allocate it
        
        Change-Id: Ia6bbf6d3f5b9af2a5b52b8c6baec85bdcb579275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175847
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [11b15571475414ef853e21a6c96afa2ac81f848f]

        convert KernArray from sal_Int32 to double
        
        which allows us to eliminate a bunch of rounding at various layers, and
        consequently maintain a lot more precision
        
        Change-Id: I911dedd7c041c1d67396c082e5695346ea689acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [ef085d09e0c019f78a3d35f759c8fe567856b615]

        Merge init into ctor
        
        Change-Id: Id936b4bd9d5cb1a787667226c128ee023aa2b784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175848
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-31  Sahil Gautam  <sahil@libreoffice.org>  [965287a9edb982b4f1857e7a57a73f0bdfd7e330]

        tdf#85976 Make labels more intuitive in "Duplicate Records Dialog"
        
        Records is not a very intuitive label for the the treeview section of
        the dialog. Change to "Rows: " and "Columns: " based on what's being
        displayed in the dialog
        
        Change "Compare: " to "Compare by: "
        
        Change-Id: Idff5f4a6935856f2c5a16f5b45bf8ce0ba169ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175704
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8328c69858e7be8dbf82a8ec66948a3e1534a852]

        merge these lines
        
        Change-Id: Ic8bcfdd09c0f23e6584daf0e30c26aaccdab6fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175825
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [011d5bbd068f00c9477b1fd68e8ba297d4e6998a]

        cid#1607883 Overflowed constant
        
        Change-Id: Ib01a9c72b2e5684552af22e3ef64a33358eacb9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-31  Andras Timar  <andras.timar@collabora.com>  [774275231294b8b8f41024cb1d5216bbe3f23aba]

        Prevent 'Failed to dispatch .uno:None' message
        
        This was seen when checking grammar checker suggestion.
        When I click on the top element of the context menu of
        underlined text (e.g. Grammar error), I get
        
        warn:lok:1663798:1663791:desktop/source/lib/init.cxx:283:
        lok exception 'Failed to dispatch .uno:None'
        
        This .uno:None was introduced by Tamas Zolnai especially for
        LOK: 3616bb68f247735c46c1a4cd9568775e77be6441
        His intention was to add an empty command that does nothing.
        
        Change-Id: I12a9a1e17dcf65cdd78266f44e6201ed3d5fa01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175102
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit bdb0dd485da24a95b61df6136362ab189803bc27)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175845
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2024-10-31  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0e05add86cfb996fe6a11c088c36b3fa010e2445]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'bDoIncrement' variable was assigned the same value.
        
        Change-Id: Id5fd249b94429c80898e8ab1553ef32066313d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175204
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-31  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [589974b0cad8d5f552b5c919b24f10b713c9b6e3]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 962, 979
        
        Change-Id: Ic31a6129828a41bd3450567ca8cb8884d60691cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175220
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-31  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e2479ebd5c727a1e7d0eb40210f9fec9a1ad75ad]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 944, 957
        
        Change-Id: Ic637d4aa5e6024cc0011e8e51a0fba68c2644378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175225
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-31  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e386bbef8f5dbe28604f66c2f7c455ccad248935]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 579, 584
        
        Change-Id: Ifccc082caa5d8c13c92f3d4098f03fbf3c9782a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175215
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-31  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [aef81068f439be1be7dccbedc8548327f037167b]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 981, 984, 1056
        
        Change-Id: I5e1578341075dfb8f6699fca3f5468de1eeef70b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175212
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [06a2f461970288b569cc282c2913baab394c7075]

        Fix typo
        
        Change-Id: If3d4810cb2a5770b5432c398a3785d8bdcf19ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175829
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [24892ccbc2eaa943b3af904bb2bf4721361556aa]

        Remove duplicated include
        
        Change-Id: Ie69536fca492f0e8fcd8da5c167429d0f3de42ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175830
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-30  Pranam Lashkari  <lpranam@collabora.com>  [ce4ae4f082d8fe80da242836c57d55a456eac5e0]

        sw: redline changes may try to set broadcast on non PostIt fields
        
        broadcast was set from sw::UpdateFramesForRemoveDeleteRedline
        which triggered SwPostItMgr::Notify
        in that case SwFormatFieldHintWhich::INSERTED may have pField which maybe different from SwPostIt
        
        fixed regression from 0b7a9c231f66b5c2659ab3aa6a0f3c7991b9e721
        
        problem:(in LOK)
        with tracked changed on delete a merge field
        then reject the changes
        LOK will crash
        
        Change-Id: Ic1fafa1408d7a238133f5b3d18bf948d539aa991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175808
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175833
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-10-30  Sahil Gautam  <sahil@libreoffice.org>  [22949c16e65fccd40d6313c6b6c0d7906f72a999]

        tdf#85976 Change label from "Handle Duplicate Records" to "Duplicates"
        
        This is because the original label was taking a lot of space on the
        notebookbar. Other suggestion was 'Manage Duplicates', which didn't
        seem any better than 'Handle Duplicate Records' as when an icon for the
        command is added, it will end up taking a good amount of space.
        
        Change-Id: I852bd897d68648208102861de3d8131e103f4f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175826
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-30  Heiko Tietze  <tietze.heiko@gmail.com>  [1de5fc4671f789d1a9d0b5679a52349b9913a2f4]

        Resolves tdf#74386 - Make Text Boundaries independent from non-printable chars
        
        New option introduced under Formatting Aids to switch between full
        and crop marks, which was done before via NPC
        
        Change-Id: I920f68b571da740e47ae367ba1e8d28e03a131e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175828
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-30  Marc Mondesir  <timepilot3000@gmail.com>  [f9e2bc8d84fe729d7a501dc3acc6325e246f0b7d]

        tdf#163582: Fix scrolling distance increasing geometrically.
        
        New scroll distance was previous distance multiplied by speed factor, but distance was not reset to base values when mouse not moved (or outside app window on some platforms), resulting in continuous multiply amplification. Break out base scroll values to separate variables to prevent multiply feedback. Add comments to help future code maintenance.
        
        Change-Id: If11baff3b25521abce7436b44aaf8e6a19e54f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175657
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-10-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f69980d036b3f388982d7b1b2907cc165ee04b52]

        Don't call std::string::erase with end()
        
        Change-Id: I64afcbe7138de7c7655a8107fd25e3ac8393a55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175824
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [cf627ab2c8c070a620c81cff1faf7b6f04205255]

        tdf#163684 gtk3 a11y: Don't use combobox role twice for non-editable one
        
        Since
        
            commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 7 10:04:16 2024 +0200
        
                tdf#160971 gtk3 a11y: Set role for custom editable combobox
        
                Set the combobox a11y role for the box in the .ui file
                used for the custom gtk3 combobox implementation.
        
                With this in place, moving focus to the "Font Name" or
                another editable combobox in the Writer toolbar now
                makes Orca announce that one as "editable combobox"
                rather than just "text".
        
        , the combobox a11y role is set for the GtkBox of
        the custom combobox implementation used for gtk3.
        That box contains the edit (for editable comboboxes)
        and the button.
        
        While this is needed for editable comboboxes for
        AT to identify this as a combobox when the edit
        receives focus (by the fact that the edit's parent
        has a combobox role), this resulted in Orca no
        longer announcing the combobox role when the
        button receives focus for non-editable comboboxes.
        
        While the button also has the combobox role, Orca
        has logic to not announce the role of combobox
        children. (`SpeechGenerator._should_speak_role`
        returns `false` for that case [1].)
        
        To avoid this problem and make announcement for both,
        editable and non-editable comboboxes work as expected,
        no longer set a combobox role for the box in the .ui
        file, but set it only for the editable combobox
        in the C++ code.
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/blob/78e44c625ef5fb082907ca484230458624d24ee8/src/orca/speech_generator.py#L365-366
        
        Change-Id: Ia3ff00688f47e61d5a98c79f1a256061b2fb18a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175823
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9416bafc23bf2b9a3c6730a6c5add4a61c461ff1]

        Adapt to generation of .worker.js files gone from 3.1.68
        
        ...and just unused dummies since 3.1.58, so don't install them for >= 3.1.58,
        even if the dummies would still be available for < 3.1.68
        
        Change-Id: Ida55be2fa3b75982bfd764b7b2676e63c092fe79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175822
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-30  Pierre F  <fpy@bger.ch>  [13a91807edb3375e2fd122db3a3e80452a7caed7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8493c54bdde03bdc793b83402b9c341a5a97efac
          - tdf#143846 split DECIMAL() + DOLLAR()
            
            Change-Id: Iba787b44ad846fd2e7ec129fbb72bf916b23e2e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175756
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6af797a11a2f1c79303580c4d76401f0594dcc7d]

        We're not interested in using an empty reply
        
        Change-Id: I6925879c83e188e892a375df5b295a48fb0f464d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174974
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 18e1f0e92aa20ba9c08ce553523f8a2cdec2e23d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175759
        Tested-by: Jenkins

2024-10-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1113636c0a976387189b0f721c0721119ef12dff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f833371fbfb54ba9414f127c96cd2bcb2b985a0c
          - Mute L10n of embedded contents.
            
            + fix bad string
            
            Change-Id: Ie84c289310923c286cc843d42ffc2c361dcd9154
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175758
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [417d0d50c8822910d93fa9edddc4e53b0260a344]

        Missing test dependency
        
        Change-Id: I574ae3404ce4a9ad75176f2e2066563da60136ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175809
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [63a93d21d6f0c0312727541978ce0714360b538b]

        tdf#130857 qt weld: Implement QtInstanceComboBox::set_entry_completion
        
        Set a corresponding QCompleter [1] using
        QComboBox::setCompleter [2].
        
        [1] https://doc.qt.io/qt-6/qcompleter.html
        [2] https://doc.qt.io/qt-6/qcombobox.html#setCompleter
        
        Change-Id: I89cdd8bee676c8a208ffe944ca84225210e842a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175819
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [c8da0e06f7b3e5122826dda24167adc0688cee33]

        tdf#130857 qt weld: Declare support for print progress dialog
        
        Add .ui file for the print progress dialog that gets shown when
        starting a print job from the print dialog (Ctrl+P) to list of files
        supported by QtInstanceBuilder, so that native Qt widgets are used for
        that dialog now when using the qt5/qt6 VCL plugins, unless environment
        variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        Change-Id: I4bfdd34fcdb6d5844e04d99235fbf3ad5ef9f66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175817
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [ef1eaad00f3bd2c7536c0b8bcb37f9e3201ced11]

        tdf#130857 qt weld: Add a QtInstanceProgressBar
        
        Add a new QtInstanceProgressBar class that is
        the weld::ProgressBar implementation using a native
        Qt widget. The widget used is a QProgressBar.
        
        This will be used e.g. by the print progress
        dialog, for which support will be declared
        in an upcoming commit.
        
        Change-Id: Ic4b162014cd3a09801096cebd38dbdc923f5dbfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175816
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [af4bc7e3923c1aa7d47c050a6c3ab98523361e62]

        tdf#130857 securityoptionsdialog.ui Define grid children in order
        
        Switch the order in which the children of the "grid3" grid in the
        .ui file are defined so that the order matches the visual appearance,
        which makes sure that tab focus order with the Qt-based VCL plugins is
        correct as well in the "Tools" -> "Options" -> "LibreOfficeDev"
        -> "Security" -> "Options..." dialog.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        Change-Id: Iffba59ba04ecfd3fcb900e09ad013e6f498beff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175815
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Noel Grandin  <noelgrandin@gmail.com>  [faad724af54808998e47edad6bbb80aee3e3f4d1]

        no need to use std::unique_ptr in GetPartialTextArray
        
        Change-Id: I3c60f69d1693721a620faef4e1cda2f479c1bfda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175801
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [d47bfc293a151da16231c7643b038d75d1d4675f]

        tdf#130857 qt weld: Declare support for "Enter Safe Mode" dialog
        
        Add .ui file for the "Help" -> "Restart In Safe Mode" dialog that
        asks whether to really restart in safe mode to list of files
        supported by QtInstanceBuilder, so that native Qt widgets are used for
        that dialog now when using the qt5/qt6 VCL plugins, unless environment
        variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        Change-Id: Idec1c2dedd057aa2322453471c55022442941f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175807
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [775156dcea529a9adff714f0f55df825488e2f4e]

        tdf#130857 qt weld: Support hiding plain text in entry
        
        Evaluate the "visibility" GtkEntry property [1] [2]
        and set the QLineEdit's echoMode [3] to QLineEdit::Password
        if the visibility is set to false, so that replacement
        characters are shown instead of the actual text as
        expected.
        
        This is used e.g. in password dialogs, e.g. in Writer:
        "File" -> "Properties" -> "Security", press
        "Protect..." button.
        (But this dialog is not using native Qt widgets yet,
        more needs to be implemented first.)
        
        [1] https://docs.gtk.org/gtk3/property.Entry.visibility.html
        [2] https://docs.gtk.org/gtk3/method.Entry.set_visibility.html
        [3] https://doc.qt.io/qt-6/qlineedit.html#echoMode-prop
        
        Change-Id: I218e4721bbc21f3d6a3553647e92c1ea7cdc4a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175806
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [d247f2e9e6f488893dbe575d2c6087e7b4a61bb9]

        tdf#130857 qt weld: Add a QtInstanceLevelBar
        
        Add a new QtInstanceLevelBar class that is
        the weld::LevelBar implementation using a native
        Qt widget. The widget used is a QProgressBar.
        
        This is used e.g. in password dialogs where
        the level bar is used as an indicator for the
        password strength, e.g. in Writer:
        "File" -> "Properties" -> "Security", press
        "Protect..." button.
        (But this is not using native Qt widgets yet,
        more needs to be implemented first.)
        
        Change-Id: I4400b8d1a03e8978bc96152166dec87f8134f48f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175805
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [2c93a8b474f6fc2420c01aa1e9cad2963c6c9c16]

        tdf#130857 qt weld: Declare support for Calc "Select Source" dialog
        
        Add .ui file for Calc's "Select Source" dialog to list of files
        supported by QtInstanceBuilder, so that native Qt widgets are used for
        that dialog now when using the qt5/qt6 VCL plugins, unless environment
        variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        This dialog is e.g. used for "Insert" -> "Pivot Table" in Calc.
        
        Change-Id: I4e9397f665f83cff099a7fb91d5e310b249be933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175800
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [8bf22f69ffd2fb24b14297b8f869eb8371dfbb21]

        tdf#130857 qt weld: Signal when radio button gets toggled
        
        Call weld::RadioButton::signal_toggle when the
        QRadioButton::toggled signal gets emitted.
        
        Change-Id: Ib9713c452fef94448a4f101a7ef6b1dc1d93966c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175799
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [7adf81494411fa8401d70f4e4cda02547883a5d2]

        tdf#130857 qt weld: Declare support for "Security Options" dialog
        
        Add .ui file of the "Security Options and Warnings" dialog that
        can be triggered via "Tools" -> "Options" -> "LibreOfficeDev"
        -> "Security", then pressing the "Options..." button there
        to list of files supported by QtInstanceBuilder, so that native
        Qt widgets are used for that dialog now when using the qt5/qt6 VCL
        plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1
        is set.
        
        Change-Id: Ife7422cb82358d91e3b2092037768231669fcab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175798
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [77fc900cfaf9d8b8fa0edb48ef38e0bdf7f2091d]

        fix bug in XclExpXF::Init (tdf#163667 related)
        
        looks like a copy/paste error from
           commit d0f8daa0980ba8e403b32006831657c5a0a4ea17
            Author: Eike Rathke <erack@redhat.com>
            Date:   Wed Aug 22 13:16:19 2018 +0200
        Resolves: tdf#73063 preserve and roundtrip LCID from/to Excel number
        formats
        
        Found while debugging the file in the associated bug.
        
        Change-Id: I6816290c90d6271f43416a7417cb2a0341da928c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [b4a26ca791fd802a038f5a764517d515c01f05d9]

        win a11y: Move (Impl)InitAccessBridge logic to only caller
        
        Now, with previous commit
        
            Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Oct 29 15:08:37 2024 +0100
        
                win a11y: Stop using setting to indicate AT support
        
        in place, InitAccessBridge only gets called from the Windows-
        specific ImplHandleGetObject. Therefore, move the logic
        from ImplInitAccessBridge there and drop the InitAccessBridge
        and ImplInitAccessBridge functions.
        
        Change-Id: Id0d08478b84434b4ec03ab72b8af40e8ad51bd71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175796
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [c5b6e3ac564c35aa10744d498b372fa5d4f68bf3]

        win a11y: Stop using setting to indicate AT support
        
        No longer use a "Accessibility"/"EnableATToolSupport"
        VCL setting to control/report whether support for
        assistive technology is (or should be) enabled,
        which was primarily used on Windows.
        
        As described in previous commit
        
            Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Oct 28 21:12:48 2024 +0100
        
                win a11y: Drop "Enable AT Tool support" from options UI
        
        , that setting got automatically enabled when an assistive
        technology was active on Windows, and never got reset to
        "false" automatically, so AT support would be enabled
        next time LO starts as well.
        
        Instead of persisting this via a setting, enable the
        Windows a11y bridge if and when a WM_GETOBJECT message
        is received only, see `ImplHandleGetObject` (where this
        was already done earlier) and no longer alternatively
        start the a11y bridge in Desktop::Main when the mentioned
        setting is enabled.
        
        Drop MiscSettings::SetEnableATToolSupport altogether.
        
        Adjust MiscSettings::GetEnableATToolSupport to no longer
        read a setting, but return `true` if the AT bridge
        has been activated (or a SAL_ACCESSIBILITY_ENABLED
        environment variable is set, as was already checked
        before).
        This already returns `true` when called from
        MenuBarManager::FillMenuManager when starting
        LO while the NVDA screen reader is running.
        
        With this in place, the a11y bridge on Windows
        should now become active whenever an AT requests
        information (by sending a WM_GETOBJECT message),
        but not otherwise, and restarting LO will result
        in the a11y bridge no longer being active unless
        AT requests information again.
        
        Change-Id: I42f0059cecd43205690d958a875d3c17ff9a197b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175795
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Michael Weghorn  <m.weghorn@posteo.de>  [069d2c079664cf44fc471216b1204cb71a6362cd]

        win a11y: Drop "Enable AT Tool support" from options UI
        
        Drop the "Support assistive technology tools (program restart
        required)" checkbox from the "Accessibility" options page.
        
        It was only shown on Windows.
        
        While having this in the UI seems to suggest that this
        is a setting that users explicitly toggle on and off,
        the setting is automatically switched on when an AT is active
        anyway, see `ImplHandleGetObject` in
        vcl/win/window/salframe.cxx.
        
        Therefore, only switching explicitly off after using
        an AT, but no longer planning to do so any more is
        the only case I can think of where changing this
        option via the UI might have been a use case.
        
        The plan is to rework the handling in an upcoming
        commit instead: to enable AT support when an AT
        is active, i.e. in `ImplHandleGetObject`, and not
        persist that setting any more across LO runs.
        
        Related change for the Windows registry:
        
            commit 77e1c0bfa2e643f017b829cd775d08c5a40d9b6b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 23 12:17:02 2024 +0100
        
                win a11y: No longer read/write registry key
        
        Change-Id: I32624b830d39d08510e4731edd06fd7a77642c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175787
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [317e08edd800357f78ae35fe4f1b31a95b3bb9fc]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 872, 875
        
        Change-Id: Icb311dd2ae1ab6b62bcdf141a2139e2cc6dd0564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175265
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [929075ef07b0503a69355dda50c193100583aeaf]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 876, 881
        
        Change-Id: I03f7b39a9f1d2226bf85904ffa2c4165b84b0aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175264
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [558b5a1183e840007e554a05082ade0b8e3e3f92]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 836, 890
        
        Change-Id: If6036da666ea46a4e5c2bc0f4547c78aa43a26a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175270
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [167ebdaaf98ba0065081b6fe8319526586e54bbd]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 614, 624
        
        Change-Id: I0171d19f151719bc6faf8909d14327b63b4ac2ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175354
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ca7accad71b0c91bc935715bb89b935857d6a711]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 685, 689
        
        Change-Id: I3c35e7d89699e64693c04da554136f8747fd0dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175347
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9a23cce372741b08cb8819cf9c71f1cae567c7c4]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 718, 724
        
        Change-Id: Id39e264626634ab4288e41bd6d72303a3820a10d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175319
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc2e8daa4bdcac9ce79400269baee8e3d59f9e3d]

        sw/qa: use more getSwDocShell()
        
        Change-Id: I4df04a94bb63709e43fb887972fcab9756f6233b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175797
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [42ca17dd19a5a03c6c26c9b5e524cbb3499ffced]

        SwModelTestBase: add getSwTextDoc and use it everywhere
        
        Change-Id: I09f132a9c79f0aa4c3f4d3ca5f2fed233d0dcb06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175641
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4604ca7581a81d84eea1dcd517b9fe04b0371d82]

        cid#1607551 silence Overflowed constant
        
        Change-Id: Id632cf7933059e54b3cae9daabd981781e944313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175803
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [167a9b8caf40a95c736be1d360bc4ef55052a39e]

        cid#1607341 silence Data race condition
        
        clarify that the same mutex is held for writing and reading to
        maUsedLines
        
        Change-Id: Ifabe8006cc1eac3cf05e9d5c4e907e79f22c3de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175802
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-29  Henry Castro  <hcastro@collabora.com>  [6668f6e34860b7f42a1ee06a062496a0cb63ce8e]

        sd: lokit: add notes to presentation info
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I1293a392749b6cff75be02236fb570f8faeb2446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174613
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175757
        Tested-by: Jenkins

2024-10-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [af70b2b888e6baeb0da75eb0beb0dc51325adfed]

        Related tdf#162262 - Move "Summary below data" UI tests to
        
        separate file.
        
        Follow up commit: 26c08356d1b2a963efdca570979cb04388371400
        (tdf#162262 sc add "Summary below data" option for Subtotal dialog)
        
        Change-Id: I8e76fe2585993e79454f6079485f191e970e8f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175786
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [ec9da7217906f92169edf708a4ec36bac8b88e31]

        tdf#130857 qt weld: Declare support for "Switch to override" dialog
        
        Add .ui file of the "You are switching to the overwrite mode"
        dialog that gets shown when pressing the Insert key in Writer
        to list of files supported by QtInstanceBuilder, so that native
        Qt widgets are used for that dialog now when using the qt5/qt6 VCL
        plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1
        is set.
        
        Change-Id: Ib4f83af6d83e46a5bf1a816ffe7d1d494bc0b9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175792
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [8f52ba46133a000024ea58425d6a4f2671b1efda]

        tdf#130857 cui: Move checkbox out of button box
        
        In the "You are switching to the overwrite mode" dialog
        that gets shown when pressing the Insert key in Writer,
        move the "Do not show again" checkbox above the button
        box with the "No" and "Yes" buttons instead of having
        it inside of the button box.
        
        This aligns this with how it's done elsewhere, e.g. in
        the "LibreOfficeDev Help Not Installed" dialog
        (sfx2/uiconfig/ui/helpmanual.ui) that gets shown
        when pressing F1 without local help installed.
        
        It also prevents an issue with this case of a checkbox
        with quite some text inside a button box resulting in
        overlapping UI elements for the native Qt version
        of the dialog (once this gets enabled in
        QtInstanceBuilder::IsUIFileSupported).
        
        Change-Id: I005da330cca5a8d6ee468477472e0382c288b022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175791
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [a03853f2e62a7dd98e992cc8833285c3c835ed09]

        tdf#130857 qt weld: Implement QtInstanceImage::set_from_icon_name
        
        This will get used e.g. by the "You are switching to the
        overwrite mode" dialog that gets shown when pressing the
        Insert key in Writer.
        
        Change-Id: Icea593ad65d643b647408c29482d64b9084d4cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175790
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a2de9dd6b1b982c782daeb79da1291680408e319]

        Missing initialization of ScTable::mbTotalsRowBelow
        
        ...introduced in 26c08356d1b2a963efdca570979cb04388371400 "tdf#162262 sc add
        "Summary below data" option for Subtotal dialog"
        
        Follow up commit: 26c08356d1b2a963efdca570979cb04388371400
        (tdf#162262 sc add "Summary below data" option for Subtotal dialog)
        
        Change-Id: I9d8e12fc24e6e42f6ee28c4879ddcff497b88c18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175793
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7903e2b59fa000d67f8c5bc7a0536f40569489aa]

        tdf#162692 partial take back of tdf#160252
        
        to no longer make the wrong data appear when a
        CF gets changed on one tab. For more info, see
        text in task.
        
        Change-Id: I7bf582eb9a2fe59b9a4b3d280639661c3aa7e608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175779
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49fb356bac7459928a0c1688f35016efb74d9c1a]

        treat divs as requiring a new block/para
        
        but consider inserting a paragraph as fulfilling that requirement, and
        only insert a new para if content shows up before a new para does.
        
        Change-Id: I7455575a77a1f3b176ed8d5b16a7e5a688ba9dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174507
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 0287036fa4ae6d709aedc6b721329251fa6f412f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175754
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-29  Juergen Funk  <juergen.funk_ml@cib.de>  [bd1d232119dcff9ca0788554a8477d769964d5c6]

        fix enabled-mergelibs-more build
        
        ErrCode::toString is needed by desktop/source/app/ unit tests now
        
        Change-Id: Ie7a9e67aca763c958d08f3826bca5df4e0d828f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175769
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [30dee23a769ee81cef7c6b4fe95f2fd661e97b9b]

        UnoApiTest: check mxComponent right after loading
        
        Change-Id: Ia834d19a5af999440f7d5847aeeae863daacd952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175784
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-29  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [ca1f1962ae163345ecaedc288244448589ae2a0e]

        tdf#42982 Improve UNO API error reporting
        
        Add more information to UNO API error reporting in AccessibleDocument.cxx.
        
        Change-Id: I411df5c5e3eb69fcc045c92453aa3c37111145f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175331
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Hossein   <hossein@libreoffice.org>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [152896274aca291a5d2181db6dd639c3e36c2a02]

        tdf#161152 vcl: Set CUPS "sides" option for duplex mode
        
        When the PPD "Duplex" option is set in a print job,
        also set the CUPS "sides" option documented at [1],
        section "Printing On Both Sides of the Paper".
        
        This is apparently required for at least some Brother
        printers where the "Duplex" PPD option is not evaluated
        during the print process.
        
        [1] https://www.cups.org/doc/options.html
        
        Change-Id: Ib280c3c65eaf7bf74b611f0ce921eda51b1ebe19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175782
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [53bedc8bc19f90cfad9bdc921c9ecc90f4980104]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c600ec0146bca18fdcd998879dc0a520fb436eff
          - Tweaks for text function for navigation
            
            Change-Id: I1bc8d9ab8c73d94264c5774bd37cae2a9b54950e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175785
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a9d7ac5c8f7af0051b0df1c8a298f9823cd134aa]

        Allow replies with rich text content from command arguments
        
        Change-Id: I46d200048bdfef767882e94c7544f40f2e0b3c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174593
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3eae55420d1d8daee6efad456f651a9ff189723b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175752
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [4692b33314669515a973f69cddd27b688327ca99]

        tdf#130857 VclBuilder: Move extractResizable to BuilderBase
        
        Turn this local helper function into a static method
        in the BuilderBase class, for reuse in QtBuilder
        in an upcoming commit.
        
        Change-Id: Iee5d5c061c8b1bad3fefb7398111ad6815fc4c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175776
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [59d8a8b03a0c23842e567d5dc1fb2051d8685c0e]

        tdf#130857 qt weld: Set widget tooltip defined in .ui file
        
        If a tooltip is defined for a widget in a .ui file,
        set that tooltip using QWidget::setToolTip.
        
        This e.g. makes the tooltip for the copy button in the
        "Help" -> "About" dialog shown as
        "Copy all version information in English" when hovering
        over the button with the mouse.
        
        Change-Id: Ida22b3fb8b3626474d4377aac6c51d9f7c7ba2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175775
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [8dd7232a88803de15728b0b78df04b13bca4d944]

        tdf#130857 VclBuilder: Move extractTooltipText to BuilderBase
        
        Turn this local helper function into a static method
        in the BuilderBase class, for reuse in QtBuilder
        in an upcoming commit.
        
        Change-Id: Ib1129801bc7315b1745d1b2690d59747c8db7ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175774
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [638945011baabf86b2529ba68cb5cb4d49813a33]

        tdf#130857 aboutdialog.ui: Define grid children in order
        
        Reorder children of the top-level grid in the .ui file so
        that the order matches the visual appearance, which makes
        sure that tab focus order with the Qt-based VCL plugins is
        correct as well the "Help" -> "About LibreOffice(Dev)" dialog.
        dialog.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        Change-Id: I069fc7c290d2c98180345d350504068a2dc19d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175773
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [b243997d2fc52c525ecb5130d1749f8ac03722a4]

        tdf#130857 qt weld: Declare support for "About LO" dialog
        
        Add .ui file of the "Help" -> "About LibreOffice(Dev)" dialog
        to list of files supported by QtInstanceBuilder, so that native
        Qt widgets are used for that dialog now when using the qt5/qt6 VCL
        plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1
        is set.
        
        Change-Id: I57c83517e9f7cea16931107206f25f6a9013429c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175772
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Pierre F  <fpy@bger.ch>  [3fb8a8f7cd1d21124ca2beb1f54125cbc0730004]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b7ddc4bf507d27578f3bf17fd28dc40b95d6586
          - tdf#143846 split CODE() + CONCATENATE()
            
            Change-Id: Ic190564f4e7a7884900766cee26322f5ab7dfec9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175607
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d267d2e38b8950e22a79b1d6fb372628b35ff0a0]

        update credits
        
        Change-Id: I2d29266078124f3b28c45cf60145e0f6e6bebe4c

2024-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b91fc00a01e973937861a212750b12ffaaf9501]

        workaround loplugin:cppunitassertequals
        
        There is no operator<< for SfxPoolItem, so a straightforward convert to
        CPPUNIT_ASSERT_EQUAL is not possible.
        
        /home/noel/libo/sw/qa/extras/tiledrendering/tiledrendering.cxx:2725:5:
        error: rather call CPPUNIT_ASSERT_EQUAL when comparing 'const
        SfxPoolItem' and 'SvxWeightItem' (or rewrite as an explicit operator ==
        call when the operator itself is the topic)
        [loplugin:cppunitassertequals]
         2725 |     CPPUNIT_ASSERT(*pPoolItem == aBoldWeightItem); // a bold
              |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        1 error generated.
        
        Change-Id: Ia92779d54d252245e1d3b8e32c574e4226342f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175771
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [54a836fa5af3428d893cffe5d7a0963b092e9f70]

        Fix typo
        
        Change-Id: Icff1da2ae4dc70c699f48116b9e4658edb5c3000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175763
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-29  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [7d942fbff01e69d10c23c6d20d10ecc8558004f3]

        tdf#140226 use StaticWhichCast
        
        Replace static_casts informed by .Which() for SfxPoolItems with StaticWhichCasts
        where appropriate in htmlctxt.cxx and docxattributeoutput.cxx
        
        Change-Id: I0a905c9e92cf39396bab0620ed35b201f8e6a8c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175515
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [01b6f6936dbd1a6563aa071d5856f53f16e40b1a]

        cid#1556968 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557514 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie419092ef6c00039a8799bf208fd998001c108ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175738
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [e5a1742dcd8394e5fa98b32634b6dcc7eae9d565]

        test: Merge SwAccessibleTestBase and AccessibleTestBase
        
        Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [a38a22c7e55bf076f96589492e8f42f6c2f7639c]

        UnoApiTest: rename load to loadFromURL and use it everywhere
        
        Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [25a5172071e1eacb9ea124f17434ce2b1e039b33]

        Simplify a bit
        
        Change-Id: Ia0225e6053112a88db3641ba653e2af7cc702f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175749
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [cd2e3087642bb2849a089fb121f7b2c581fe0f00]

        tdf#130857 qt weld: Set button image set in .ui file
        
        Implement logic to set the image for a button, as specified
        via the "image" property for the "GtkButton" object in
        the .ui file.
        
        Similar to how VclBuilder::makeObject does it, extract
        an icon name and load an image using that one for
        "GtkImage" obejcts.
        Add another static `toQPixmap` variant that
        takes an Image parameter and use that one for conversion.
        
        For buttons, if the "image" property is set, get
        the corresponding QLabel object, get the pixmap
        from that one and set an icon in the button from that.
        
        With this in place, when opening the "Help" -> "About LibreOfficeDev"
        dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
        of .ui files in QtInstanceBuilder::IsUIFileSupported, the button
        to copy the version information now shows the corresponding icon
        when using the qt6 VCL plugin.
        
        Change-Id: If87866d7ab935cbc4162fb513074eefda22c981a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175761
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [6bf7069f72255518d7abc52d4756cddbffbe6512]

        tdf#130857 Move loadThemeImage from FixedImage to BuilderBase
        
        This static helper method is currently only used by VclBuilder.
        Move it to the BuilderBase class, for reuse by QtBuilder
        in an upcoming commit.
        
        Change-Id: I229bc98e0de2dbe0788f07c7f4ff5e5426203de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175740
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-29  Michael Weghorn  <m.weghorn@posteo.de>  [85fb5e98fcb837f2dae59c81f64963c2159fc95b]

        tdf#130857 VclBuilder: Move extractIconName to BuilderBase
        
        Turn this helper function into a static method
        in the BuilderBase class, for reuse in QtBuilder
        in an upcoming commit.
        
        Change-Id: I1e3318f22d83ddef4e7bf6269c7142f307ec6d1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175739
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-29  Muluh MG Godson  <godsonmuluh@gmail.com>  [1feb2466dccc0eee66bbfd50aff23ad7864e0c94]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: Ib779717653f17fdb83319d65313ae1a0ffc8fd3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175768
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-29  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [8f6cae354d0b068dc377583d5af12acc7dc9e675]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d375e51d98ce78857dc71f5a26b75058592d833d
          - tdf#163657 Adjust Thai spell check dictionary
            
            LibThai word list, a source of the Thai spell check dictionary,
            includes some common misspelled words for its word segmentation
            function to still work with documents in real life. But such
            entries should not be included in the spell check dictionary.
            
            * th_TH/th_TH.dic:
              - Remove entries from LibThai's tdict-spell.txt
              - Fix spellings of some related entries (ซิลิกอนเวเฟอร์ -> ซิลิคอนเวเฟอร์,
                ปรากฎการณ์ธรรมชาติ -> ปรากฏการณ์ธรรมชาติ)
              - Add the updated spelling for "ทุกกฏ". Still accept the old spelling
                "ทุกฏ".
            
            Change-Id: I792bd67a4a2cea85554442e30c952889898bbbac
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/175732
            Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a2ab1621b4cee87366b41564ae957fbd61e0a64]

        cid#1608231 silence Overflowed constant
        
        Change-Id: Idf24a404d332b5a63f8ae7ec7f133a7f3c74c97c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c79f67082c4f2457e447d16759070391f0378ece]

        cid#1608044 silence Overflowed constant
        
        Change-Id: I779a2354374279477fd330784d3ce5e4345fa83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b1d4d6cac7cda998f5219858353866f85a44933]

        cid#1607898 silence Overflowed constant
        
        Change-Id: Ief9b09c5db8ef687c50ab12894d59056be85e8b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [268a82d43425534761ef243d9204bfe4f4d3abc6]

        crashtesting: crash on loading ooo71160-2.doc
        
        since:
        
        commit 2d6addb180ad30383f4aaec198c22ccbf936fa87
        CommitDate: Mon Oct 21 15:16:57 2024 +0200
        
            tdf#163486 sw: PVS: identical sub-expressions
        
        Change-Id: I601a72a8a39f3591d1110f65a027e89923befaca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175702
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-28  Patrick Luby  <guibmacdev@gmail.com>  [d3895d7efd62576ce29132e823f3fdbdeb2e10ee]

        Fix unresponsive mouse moved events in Writer on macOS
        
        On macOS, when Writer is in a background task such as initial layout
        and spellchecking, mouse moved events appear to be unresponsive due
        to the fact that AquaSalInstance::AnyInput() returns false when flags
        include VclInputFlags::MOUSE even though there are native mouse moved
        events waiting to be dispatched.
        
        In contrast, on Windows WinSalInstance::AnyInput() will return true
        so make macOS behave the same as Windows and return true if there
        are any queued native mouse moved events.
        
        Change-Id: I4b3cf66f2fb0357c0eebaf869da0bdcdbb8f8516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175725
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-10-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [100743f8ad5a2328810af8b2ee19e535850ec901]

        tdf#162510 - Consider pinned items for the scroll bar in the start center
        
        Change-Id: If753ab1ea0df0bc7938532f6e614b94252fa3f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175681
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [c638ae429e500cee147b621ed30d9fed392edd0a]

        don't use iterateItemSurrogates for EE_FEATURE_FIELD
        
        Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb24239ef0744c9dfa2d0beae850791adc6edc21]

        cid#1606943 Overflowed constant
        
        Change-Id: If097a933e8d856e4528313cd351959ceb9041b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175718
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-28  Patrick Luby  <guibmacdev@gmail.com>  [e7f27f96f0789939436cf1cb3dff79579a67cf3d]

        Set the native tracking area in -[SalFrameView updateTrackingAreas]
        
        NSTrackingArea has an immutable rectangle so it cannot grow when
        the SalFrameView's window is resized. So, whenever the SalFrameView's
        bounds change, remove the old NSTrackingArea and add a new one with
        the SalFrameView's current bounds.
        
        Change-Id: I70a5be7fbe6dd6b5f4f2ed4878dd12a36ab3622b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175708
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-10-28  Pranam Lashkari  <lpranam@collabora.com>  [1ec575d1332060bbf5442e7d671e2d5749920fae]

        make quotes warning clearer for conditional format dialog
        
        Change-Id: I70fcc98962c46be32352fad72d5717fa685b881e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175133
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit d3bc1970fa9bd7acf7a6d0a2e1dba756cfc70e86)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175618
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-10-28  Pranam Lashkari  <lpranam@collabora.com>  [65fea94ac08fa9f428250098aa527ab072a378f3]

        tdf#163467 svx: calculate fill color with transparency
        
        calculate absolutely visible color based on transparency against the doc background
        
        TODO:
        calculate this color based on the object in the background to increase visibility more
        
        Change-Id: I56076c29f10c58c6ee13e1358da92a4685ea01e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175621
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit f8c87d617fc684e8e204a17cbd119c179a7e86e3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175616
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [c31a897f33fdce43b3392909feb0d8b82131e268]

        cid#1607622 Overflowed constant
        
        Change-Id: Ibc60439cd74d00b574d58df89058be625957dd02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d34249a8749bfac5c192b9a74d3580f030caf420]

        cid#1606790 Overflowed constant
        
        Change-Id: I2fbfefb47abb752bba609f2373c237ef39bd4e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175717
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [913efd48de1e052a0305d6c368c502158b35611c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0568f35bf55b1b028875f84a2108bc209c630eab
          - Fix Alt text of image
            
            + refactor
            
            Change-Id: I64832f28bccbf93f9786e1685d645294bd3811bf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175619
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-28  Balazs Varga  <balazs.varga.extern@allotropia.de>  [26c08356d1b2a963efdca570979cb04388371400]

        tdf#162262 sc add "Summary below data" option for Subtotal dialog
        
        With this option we can set where the summary rows should appear,
        above or below the datas when we create a new Subtotal area. The default
        option is "True" (which means the summary rows are below the datas)
        when we create a new subtotal area. Unless if we already have one subtotal
        area on the same sheet, in that case the sheet level property, "TotalsRowBelow"
        contains where should the summary rows be for the new Subtotal's.
        
        TODO: add new ODF xml attribute for Summary below
        
        Change-Id: Icf86c85041d75c24919cb528846d5bb2b517ca78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175556
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [c132233acfd5bdede5684ea2d224f62bebc13443]

        tdf#130857 qt weld: Don't expect packing props on implicit grid
        
        When the "left-attach" or "top-attach" packing
        properties are not set in QtBuilder::applyGridPackingProperties,
        just skip processing, but don't trigger an assert.
        
        While these packing properties should be set for every
        child of a "GtkGrid" object in .ui files, there's also
        the special case of QMessageBox, which uses a QGridLayout
        for its layout whereas the .ui file for a "GtkMessageDialog"
        uses a "GtkBox" instead.
        (See the special handling for "GtkBox" in QtBuilder::makeObject,
        where the QMessageBox's existing layout is used instead
        of setting another one.)
        
        Therefore, gracefully handle the case where the
        properties are not set. Without this, the "Save Document?"
        dialog triggered the assert since
        
            commit 3e28b4f0c97d011cf4222941f019ce05fe6b0313
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 25 21:21:25 2024 +0200
        
                tdf#130857 qt weld: Simplify QtBuilder::applyGridPackingProperties
        
        Change-Id: I03bc9799c142563ffbf0fa3eadb58bc63e6e23f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175722
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [79b28add29132e9fc3d5e9b445a72162f57cd6b4]

        cid#1606697 Overflowed constant
        
        Change-Id: Icc71db8d231737d8a401da05e836a552e31a4875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175716
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [286d8207d5ce6c4c76578ed3e88dce4ab5511052]

        cid#1607729 Overflowed constant
        
        Change-Id: Iebfcb18a764a432f3bd56b98225e27fb5081737f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [32e98ce4bfe7eef24aa6acca83a5f22199f486f5]

        cid#1607347 Overflowed constant
        
        Change-Id: Idd2afe534177fc1ff2fe216b9167e0107843628f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175719
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [5c3619468a5e19bec17439fe86adc263cfc993aa]

        a11y: Return early in VCLXAccessibleTabPage::getAccessibleAtPoint
        
        Change-Id: I217d8a699a55ee8da08fce2c17ff4a2ce51319da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175714
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [4c1fea101d56a78cf2c16cf4dedb61c2888a44c3]

        a11y: Return early in AccessibleBrowseBox::getAccessibleAtPoint
        
        Change-Id: Idbc3a08d7df6100fe073c2b4b805bfaab68d1c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175713
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [9437babbcdcb9a33d82a091d57957e8ff8702db7]

        a11y: Return early in AccessibleGridControl::getAccessibleAtPoint
        
        Change-Id: I0da4d4321f26e83fa8fba41ae49a4d23a0939e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175712
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [d8ab848c05c66695eba558530b0955221a3be886]

        a11y: Return early in OAccessibleMenuBaseComponent::GetChildAt
        
        Change-Id: Ia44d7341665e499549fd359f0daa69958647171d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175711
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [49f2b76f962c5cdbfb33f6f8fa08210676067af2]

        find-unneeded-includes: nicer output with --finderror option
        
        Change-Id: I9d60825fec879169228b18d0d57e59221c11623b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175550
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-10-28  Samuel Adesola  <adesolasamuel2022@outlook.com>  [dba98bdebcf99c957d883c18f44db2602956e281]

        tdf#159023 CPP unit test for Crash in SwTextFrame::MapModelToView Fix
        
        The commit 4b68824d18316762a6afc35d355221e0228aebf8 was reverted
        and the test was written, the test failed with the bug reverted and
        it passed when the bug was reintroduced. Original bug report can
        be found at https://bugs.documentfoundation.org/show_bug.cgi?id=159023
        
        Change-Id: Iba0242deb6a5423210345559f80b5ab040a8902c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175676
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ff8e1b98529b0b278730035a37412a5cc0f58c0d]

        Simplify a bit
        
        Change-Id: I3428aeb36ad35b6887e26c9abdabca64d11add70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175617
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-28  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [d239ac793f89c95cac95e5601a7d7a06c76dfd3c]

        tdf#76981 sd: Hide the document opening process when opening linked
        
        presentation in slideshow mode, only the presentation should be visible.
        The user should not see any intermediate loading processes or windows,
        providing a seamless transition directly to the presentation content.
        After closing the opened presentation, the running presentation should receive focus.
        
        Change-Id: Idc24de3d38523f044d7969f1eacb05c6bae91b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175706
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-10-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3e2feb8d3ff8e5fcfcee70e32e75483840eb8788]

        Reduce indentation
        
        Change-Id: Ibae17ff121e9b8400af080fc1fe0099b8c34470e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175074
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-10-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [edb96ed2d9270b601d8f23c0978f6bca05747ff1]

        tdf#162552 Revert "tdf#99528 Use vertical tabs in 'Format cells' dialog"
        
        This reverts commit 2199e603691a770ea6b67cbaba4ce1e0ce7b1919.
        
        Change-Id: Icd6db33094404f6583377fe0eaf5ec0f6380df8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175075
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d65d52bd208acde60e77ec49b995958985babe7]

        cid#1608014 Overflowed constant
        
        Change-Id: I113cdd5e4c127c4ebe54f8f879f9ea67397308db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175700
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7bbe74b2be45afff4418b29deca6448795d86715]

        cid#1555789 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556865 COPY_INSTEAD_OF_MOVE
        cid#1556871 COPY_INSTEAD_OF_MOVE
        cid#1556939 COPY_INSTEAD_OF_MOVE
        cid#1556951 COPY_INSTEAD_OF_MOVE
        cid#1556964 COPY_INSTEAD_OF_MOVE
        cid#1556966 COPY_INSTEAD_OF_MOVE
        cid#1556968 COPY_INSTEAD_OF_MOVE
        cid#1556971 COPY_INSTEAD_OF_MOVE
        cid#1556989 COPY_INSTEAD_OF_MOVE
        cid#1557001 COPY_INSTEAD_OF_MOVE
        cid#1557011 COPY_INSTEAD_OF_MOVE
        cid#1557032 COPY_INSTEAD_OF_MOVE
        cid#1557038 COPY_INSTEAD_OF_MOVE
        cid#1557041 COPY_INSTEAD_OF_MOVE
        cid#1557055 COPY_INSTEAD_OF_MOVE
        cid#1557056 COPY_INSTEAD_OF_MOVE
        cid#1557057 COPY_INSTEAD_OF_MOVE
        cid#1557065 COPY_INSTEAD_OF_MOVE
        cid#1557068 COPY_INSTEAD_OF_MOVE
        cid#1557087 COPY_INSTEAD_OF_MOVE
        cid#1557090 COPY_INSTEAD_OF_MOVE
        cid#1557093 COPY_INSTEAD_OF_MOVE
        cid#1557113 COPY_INSTEAD_OF_MOVE
        cid#1557122 COPY_INSTEAD_OF_MOVE
        cid#1557126 COPY_INSTEAD_OF_MOVE
        cid#1557145 COPY_INSTEAD_OF_MOVE
        cid#1557151 COPY_INSTEAD_OF_MOVE
        cid#1557152 COPY_INSTEAD_OF_MOVE
        cid#1557197 COPY_INSTEAD_OF_MOVE
        cid#1557216 COPY_INSTEAD_OF_MOVE
        cid#1557245 COPY_INSTEAD_OF_MOVE
        cid#1557272 COPY_INSTEAD_OF_MOVE
        cid#1557310 COPY_INSTEAD_OF_MOVE
        cid#1557314 COPY_INSTEAD_OF_MOVE
        cid#1557318 COPY_INSTEAD_OF_MOVE
        cid#1557333 COPY_INSTEAD_OF_MOVE
        cid#1557340 COPY_INSTEAD_OF_MOVE
        cid#1557358 COPY_INSTEAD_OF_MOVE
        cid#1557359 COPY_INSTEAD_OF_MOVE
        cid#1557365 COPY_INSTEAD_OF_MOVE
        cid#1557367 COPY_INSTEAD_OF_MOVE
        cid#1557395 COPY_INSTEAD_OF_MOVE
        cid#1557418 COPY_INSTEAD_OF_MOVE
        cid#1557488 COPY_INSTEAD_OF_MOVE
        cid#1557493 COPY_INSTEAD_OF_MOVE
        cid#1557506 COPY_INSTEAD_OF_MOVE
        cid#1557514 COPY_INSTEAD_OF_MOVE
        cid#1557528 COPY_INSTEAD_OF_MOVE
        cid#1557534 COPY_INSTEAD_OF_MOVE
        cid#1557537 COPY_INSTEAD_OF_MOVE
        cid#1557562 COPY_INSTEAD_OF_MOVE
        cid#1557563 COPY_INSTEAD_OF_MOVE
        cid#1557592 COPY_INSTEAD_OF_MOVE
        cid#1557608 COPY_INSTEAD_OF_MOVE
        cid#1557615 COPY_INSTEAD_OF_MOVE
        cid#1557619 COPY_INSTEAD_OF_MOVE
        cid#1557637 COPY_INSTEAD_OF_MOVE
        cid#1557648 COPY_INSTEAD_OF_MOVE
        cid#1557712 COPY_INSTEAD_OF_MOVE
        cid#1557750 COPY_INSTEAD_OF_MOVE
        cid#1557762 COPY_INSTEAD_OF_MOVE
        cid#1557765 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4c9f9736cdd90225b40aff7414d4479f3692613a]

        cid#1603630 Big parameter passed by value
        
        Change-Id: I8b0f01d6e93f40a2c7dbdbabcd299096c5bddae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175699
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [61dea4390979a7441f02f5a44f992987e533174e]

        Simplify a bit
        
        Change-Id: I92f7d39e449610609f8740c83e221e28eb018d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175697
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc211dc6f3ccf4aca96735564c4d5300c7f1bdcf]

        tdf#163486: PVS: Identical branches
        
        V1037: Two or more case-branches perform the same actions. Check lines: 106, 141, 288
        Change-Id: I160bc72851f24503f23a96048feb071f164cbdef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175090
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [91a75920166e1cb64d6b7e6be1980a93bd163c9a]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 425, 499
        V1037 Two or more case-branches perform the same actions. Check lines: 463, 469
        V1037 Two or more case-branches perform the same actions. Check lines: 552, 576
        V1037 Two or more case-branches perform the same actions. Check lines: 555, 582
        
        Change-Id: I1a41401569ee9893bf853bd3f56c2559aeb36a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175386
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [61198726b5e7a7bf81619785163d8058bd73f88f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 681, 686
        
        Change-Id: Ifbd5935a3bc2693d7d63c0791d7960f1a69e8d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175348
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a0aa09b34f68bef2b8fdd99776930430cb643958]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 473, 480
        V1037 Two or more case-branches perform the same actions. Check lines: 763, 768
        
        Change-Id: I6f770cff57cac225729e7e1fb82c9b36fec929e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175311
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4f868e11a445c2fd894091ea3fe20d8f3adb689c]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 702, 710
        
        Change-Id: I7a36383e2d5f19d5dbf0f8bb8d0b6a0c7880eaee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175342
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [de6b8b0ff1d2b4d081084bdce1556cc9c7fbee19]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 2335, 2338
        V1037 Two or more case-branches perform the same actions. Check lines: 2464, 2533
        V1037 Two or more case-branches perform the same actions. Check lines: 2503, 2506
        
        Change-Id: I71c1149ce64bcfdfd6b4af72fdf65a8f19b8a892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175393
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad9df93bf106adb1708abb7dbf61f757eee28a60]

        cid#1608184 silence Overflowed constant
        
        Change-Id: Ifb16694334fa0f0aa58cbe99075712046473404d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175698
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b76f63fbd329e0f3897339c7f975cd7e83598659]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1058, 1064
        
        Change-Id: I9491627220990b6263f2d6320b4bfa5d0759d60a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175430
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ba21e561705ef174c8c0f4e10985f2b24c76b3d]

        add a visitor contraption to avoid Reference counting costs
        
        brings my save times from 8.7s to to 5.85s
        
        Change-Id: I7f3ebbed78ee4d59f4ed9d04f1e35d2ea69a0c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175689
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b62173fdd1492a365211b1f8e0f267aedcd75a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68fd7de6c356ebab9289ba10d939dd8a4e3a7dd1
          - tdf#162607 disambiguate hid2file.js, InsertTimeField
            
            + Refactor
            
            Change-Id: I93476e7e2d71766be718f398a593d2674016c1d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175695
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b78e0e0ed7205eb549355dc370c96a25a7942bc6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67624ded171461c184c8286b510b4778e5be6465
          - tdf#162607 disambiguate hid2file.js, InsertFrameInteract
            
            + Removed bookmark from the wrong help page
            + Reorder text
            
            Change-Id: I51daef7752f8efeaa1736b756040af78a530e4d6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175694
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3770765ed28635db7921e3161ad37d2d86296906]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 43eb562f1d5c61c08c67be8b0f502a3858b6770c
          - tdf#162607 disambiguate hid2file.js, Scripts
            
            + Removed bookmarks from the wrong help page
            
            Change-Id: I15ade86f1359065ceb37e964d909722a1d55529d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175693
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12ec1bbcce7d8dd6389cbd4b6a006d536304377d]

        move fetching svl::SharedString inside ScQueryEvaluator::compareByString
        
        so we can defer actually calling getCellSharedString until we need to,
        as a setup to avoiding copying svl::SharedString in a follow up
        
        Change-Id: Ibd565e3cec3d455d76df75b9f135b38bc00df270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-27  Julien Nabet  <serval2412@yahoo.fr>  [70853a998b348fe2f48179061708182945c14c16]

        cid#1633859: COPY_PASTE_ERROR
        
        Change-Id: I8934e68b169fe94ea6fb6fbf47d2ab09eb314ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175692
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-10-27  ZOK  <zippyondiba@gmail.com>  [707469a8d9dd1c829720ceffab598fa70d3e9d94]

        tdf#143148 Replace include guards with #pragma once in header files
        
        Replaced include guards in header files with #pragma once
        
        Change-Id: I7378b84752b0c39ef16012afd3f468db47a75638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175683
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-27  Lorenzo Lovato  <lorenzo04lovato@gmail.com>  [7e705f6c80233943603cf0953a0188b0acc75d50]

        tdf#143148: #pragma once instead of include guards
        
        Change-Id: I573a36a488e5a76f5dbe9d629ae0aaf23d3fc711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175679
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-27  Julien Nabet  <serval2412@yahoo.fr>  [d4155f449726375b1499af49e610c61d4776914b]

        tdf#163486: PVS: disable FP Array overrun is possible
        
        Change-Id: I68c3c741ed9e0141e4a9a8359a2436dcc53ed292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175674
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-27  Julien Nabet  <serval2412@yahoo.fr>  [ed425db15b24b7f18ea3b5ffcd0c631f0bc7e2f7]

        tdf#163486: PVS: Array overrun is possible
        
        In both cases, we know nSubSelPos < aSels.size() since it's been tested some lines before
        
        Change-Id: I1e1e7c63f30bf0ea830f050284b5d2af18a597f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175673
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-27  Julien Nabet  <serval2412@yahoo.fr>  [1a1d67396c33fb768f67d9d1148de3ede205f25b]

        tdf#163486: PVS: Array overrun is possible
        
        Change-Id: Ib4b0984d828927b67200acd24ce4a22f4b0e57e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0545d627c69e0724972c279b0a6c3ff622d7b822]

        Simplify a bit
        
        Change-Id: I142800a20b187ee31fa1cb393803035ed0e347d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175691
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-27  Lue_lueita  <obienyi.p.o@gmail.com>  [a95b97adaa4a4a7ed76c832df9ed9ae64329a787]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: I045cfd010401ed4131b28aab2e94308c226cc154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175658
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7ee9cc0f6fdf7d459817f87018bd2bde31c7aa1f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 235, 249
        
        Change-Id: If20872264edda30a8854e40787b73060990d2224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175392
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f4a8954165eade1730a19a0e25fc08ae7f1825c8]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 804, 820, 832
        
        Change-Id: I25b810a91c6981f36fbad34c6ad64bc3656f6ddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175278
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a74ef20928828d5879f136bf075e4a3e1f3f451e]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 817, 830
        V1037 Two or more case-branches perform the same actions. Check lines: 1251, 1254
        
        Change-Id: I4e121ec3b0c4465f5637b114d2e91e5b639c398c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175276
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [3c9715a64c6552f3b4e920a435fa1ad10489882b]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 83, 99
        
        Change-Id: Ibe913d3662bb7cb731dd55327c0df4182b328b69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175272
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0878b2a522e4f5fbba2842a3862a0de0e7159195]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 331, 334
        V1037 Two or more case-branches perform the same actions. Check lines: 529, 532
        
        Change-Id: Id6ad82dd2cb570f7b9c04068e5f404077104a36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175387
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4fc95df9c32aa17b73c5bd08d2ab01e6f3c4c15c]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 589, 643, 648
        
        Change-Id: I808deb5f3a705ae18e97c51737213f280189fdb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175214
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c0dc8022f2d4adbc1f47a6f74e3ac69587f8ab24]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 643, 770
        
        Change-Id: I09ba00a35a9f837bba0ea7450fbf2afc0102e1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175350
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ba1d759187f7bc9b640927e9327182e487ed04d7]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 138, 144
        V1037 Two or more case-branches perform the same actions. Check lines: 174, 180
        V1037 Two or more case-branches perform the same actions. Check lines: 674, 683
        
        Change-Id: I34790e43cd06578f83185d7de04b2567732fe870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175349
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-27  Pranam Lashkari  <lpranam@collabora.com>  [3fd308fef39e6a5551e427dc1a41deccd3476841]

        sc: prefill easy condition dialog with editing condition data
        
        Change-Id: I207bcbf15bedf3dd51980f04899b2c751b64295d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175036
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175207
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0c6e26890a822c5891056f83690a477622b85c8a]

        cid#1556875 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556891 COPY_INSTEAD_OF_MOVE
        cid#1556903 COPY_INSTEAD_OF_MOVE
        cid#1556917 COPY_INSTEAD_OF_MOVE
        cid#1556925 COPY_INSTEAD_OF_MOVE
        cid#1557021 COPY_INSTEAD_OF_MOVE
        cid#1557092 COPY_INSTEAD_OF_MOVE
        cid#1557119 COPY_INSTEAD_OF_MOVE
        cid#1557218 COPY_INSTEAD_OF_MOVE
        cid#1557342 COPY_INSTEAD_OF_MOVE
        cid#1557727 COPY_INSTEAD_OF_MOVE
        cid#1557800 COPY_INSTEAD_OF_MOVE
        cid#1557821 COPY_INSTEAD_OF_MOVE
        cid#1557830 COPY_INSTEAD_OF_MOVE
        cid#1557677 COPY_INSTEAD_OF_MOVE
        cid#1557674 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I20dab0c49a17c28b4feaf97440a36d4962310b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [40468f0eb08ea8f83b23cceeeaf7f4beb3ba15ed]

        cid#1606758 Overflowed constant
        
        Change-Id: Ia1a3937159186b137b40036f1872d6156ebc0512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175685
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [868158d6b21a8446d75f1601fa39366b1f54d52c]

        cid#1608133 Overflowed constant
        
        Change-Id: I38651265938cf076078c34f359b7f3f9ea3728c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [6bcb6e7dcb9f06f4a2b709b26f33d2b07f0d711c]

        Fix wrong string ID's for the sensitivity report
        
        Change-Id: I4fe860e29eaf11601c633ff32c44d0c4e67b0958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175605
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-10-26  Arnaud VERSINI  <arnaud.versini@pm.me>  [b48dab459a32ef2cda9e1ff40ae74016eb5e670f]

        sdext replace OUStringLiteral with new OUString literal
        
        Change-Id: I3f2730024fa3cd81c38927d495cdff9c608bddbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169358
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [24ac64ca1beab50e59277b2ec25424a3badf87bb]

        cid#1556052 Data race condition
        
        Change-Id: Id7a5013cbb667ef728b633e2e17f3a16d36ec753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175680
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f1508f4de761e564146f3111345270403838468]

        cid#1555767 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555770 COPY_INSTEAD_OF_MOVE
        cid#1555788 COPY_INSTEAD_OF_MOVE
        cid#1555789 COPY_INSTEAD_OF_MOVE
        cid#1555798 COPY_INSTEAD_OF_MOVE
        cid#1555816 COPY_INSTEAD_OF_MOVE
        cid#1555822 COPY_INSTEAD_OF_MOVE
        cid#1555835 COPY_INSTEAD_OF_MOVE
        cid#1555845 COPY_INSTEAD_OF_MOVE
        cid#1555859 COPY_INSTEAD_OF_MOVE
        cid#1555864 COPY_INSTEAD_OF_MOVE
        cid#1555868 COPY_INSTEAD_OF_MOVE
        cid#1555892 COPY_INSTEAD_OF_MOVE
        cid#1555896 COPY_INSTEAD_OF_MOVE
        cid#1555921 COPY_INSTEAD_OF_MOVE
        cid#1555932 COPY_INSTEAD_OF_MOVE
        cid#1555935 COPY_INSTEAD_OF_MOVE
        cid#1555944 COPY_INSTEAD_OF_MOVE
        cid#1555952 COPY_INSTEAD_OF_MOVE
        cid#1555985 COPY_INSTEAD_OF_MOVE
        cid#1556024 COPY_INSTEAD_OF_MOVE
        cid#1556038 COPY_INSTEAD_OF_MOVE
        cid#1556042 COPY_INSTEAD_OF_MOVE
        cid#1556044 COPY_INSTEAD_OF_MOVE
        cid#1556060 COPY_INSTEAD_OF_MOVE
        cid#1556083 COPY_INSTEAD_OF_MOVE
        cid#1556085 COPY_INSTEAD_OF_MOVE
        cid#1556090 COPY_INSTEAD_OF_MOVE
        cid#1556136 COPY_INSTEAD_OF_MOVE
        cid#1556157 COPY_INSTEAD_OF_MOVE
        cid#1556159 COPY_INSTEAD_OF_MOVE
        cid#1556172 COPY_INSTEAD_OF_MOVE
        cid#1556179 COPY_INSTEAD_OF_MOVE
        cid#1556187 COPY_INSTEAD_OF_MOVE
        cid#1556255 COPY_INSTEAD_OF_MOVE
        cid#1556256 COPY_INSTEAD_OF_MOVE
        cid#1556266 COPY_INSTEAD_OF_MOVE
        cid#1556275 COPY_INSTEAD_OF_MOVE
        cid#1556290 COPY_INSTEAD_OF_MOVE
        cid#1556294 COPY_INSTEAD_OF_MOVE
        cid#1556301 COPY_INSTEAD_OF_MOVE
        cid#1556311 COPY_INSTEAD_OF_MOVE
        cid#1556318 COPY_INSTEAD_OF_MOVE
        cid#1556326 COPY_INSTEAD_OF_MOVE
        cid#1556369 COPY_INSTEAD_OF_MOVE
        cid#1556374 COPY_INSTEAD_OF_MOVE
        cid#1556387 COPY_INSTEAD_OF_MOVE
        cid#1556388 COPY_INSTEAD_OF_MOVE
        cid#1556417 COPY_INSTEAD_OF_MOVE
        cid#1556425 COPY_INSTEAD_OF_MOVE
        cid#1556435 COPY_INSTEAD_OF_MOVE
        cid#1556495 COPY_INSTEAD_OF_MOVE
        cid#1556497 COPY_INSTEAD_OF_MOVE
        cid#1556501 COPY_INSTEAD_OF_MOVE
        cid#1556503 COPY_INSTEAD_OF_MOVE
        cid#1556520 COPY_INSTEAD_OF_MOVE
        cid#1556523 COPY_INSTEAD_OF_MOVE
        cid#1556562 COPY_INSTEAD_OF_MOVE
        cid#1556573 COPY_INSTEAD_OF_MOVE
        cid#1556576 COPY_INSTEAD_OF_MOVE
        cid#1556598 COPY_INSTEAD_OF_MOVE
        cid#1556615 COPY_INSTEAD_OF_MOVE
        cid#1556626 COPY_INSTEAD_OF_MOVE
        cid#1556671 COPY_INSTEAD_OF_MOVE
        cid#1556689 COPY_INSTEAD_OF_MOVE
        cid#1556701 COPY_INSTEAD_OF_MOVE
        cid#1556713 COPY_INSTEAD_OF_MOVE
        cid#1556758 COPY_INSTEAD_OF_MOVE
        cid#1556759 COPY_INSTEAD_OF_MOVE
        cid#1556788 COPY_INSTEAD_OF_MOVE
        cid#1556811 COPY_INSTEAD_OF_MOVE
        cid#1556821 COPY_INSTEAD_OF_MOVE
        cid#1556824 COPY_INSTEAD_OF_MOVE
        cid#1556825 COPY_INSTEAD_OF_MOVE
        cid#1556862 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I4925a79688a983bb07252600430039ec0bcb75b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175678
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-26  László Németh  <nemeth@numbertext.org>  [7a35f3dc7419d833b8f47069c4df63e900ccb880]

        tdf#48459 sw inline heading: apply it on the selected words
        
        Selected text at the beginning of a paragraph (<= 75 characters)
        become text frame based inline heading at applying a paragraph style
        (using Formatting toolbar, context menu, Ctrl-1...Ctrl-5 or
        Styles sidebar panel).
        
        If the whole paragraph is selected, or if no or multiple
        paragraphs are selected, formatting is still applied on the
        whole paragraphs.
        
        Using text frames for inline heading is ODF 1.0 compliant
        and fully back-compatible with the older Writer versions.
        
        The new inline heading frame contains direct formatting
        to zero the upper and bottom paragraph margin to solve
        interoperability issues: in MSO, margins of heading styles
        are zeroed by using the style separators.
        
        Note: lack of inline heading was a showstopper for creating
        APA-, IEEE-, MIL-STD-961E-format, legal etc. documents.
        
        Note: recent Formula frame style will be replaced by the
        planned Inline Heading, which will be used by the DOCX filter
        to export OOXML style separators instead of text frames.
        
        Change-Id: I6722dcaef046bdbca2fe044d175806fa8c65278c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175580
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50cb6fb476a678e6826e02ae3ffb217baa276615]

        cid#1633842 Uninitialized scalar field
        
        Change-Id: I59d9164b191c13ac66d4a663cf5a420f7ccec44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [ec59d5aec570887758236d8955e620d7bbb34d33]

        tdf#130857 qt weld: Make link buttons focusable + handle activation
        
        Set the text interaction flags [1] for the QLabel used for
        hyperlinks so that the links can be highlighted and activated
        using mouse and keyboard.
        
        Connect to the QLabel::linkActivated signal that gets emitted
        when a link gets activated, and call signal_activate_link
        in response. If that returns false, open the URL using
        QDesktopServices::openUrl instead.
        
        Another way to only support opening the URL using
        QDesktopServices::openUrl automatically would be
        to set the `openExternalLinks` property [2], but
        IIUC, the custom activation handler should have
        priority.
        
        With this in place, when opening the "Help" -> "About LibreOfficeDev"
        dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
        of .ui files in QtInstanceBuilder::IsUIFileSupported, the tab
        order now includes the hyperlinks in the dialog, and pressing
        Enter while one is focused, or clicking on one of them opens them
        in the browser when using the qt6 VCL plugin.
        
        [1] https://doc.qt.io/qt-6/qlabel.html#textInteractionFlags-prop
        [2] https://doc.qt.io/qt-6/qlabel.html#openExternalLinks-prop
        
        Change-Id: I4e3cbca6d01a652a1038b9750ee9049e1c7491be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175670
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [7199e9a0d5313b253734fea5575ba00eceb2ecd8]

        tdf#130857 qt weld: Evaluate + set grid item row/col span
        
        When processing packing properties for grid items,
        also take the "width" and "height" properties into account,
        which specify the column span and row span, respectively.
        
        Pass these as params as well when re-adding the item
        to the grid, not just the row/col index.
        
        With this in place, when opening the "Help" -> "About LibreOfficeDev"
        dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
        of .ui files in QtInstanceBuilder::IsUIFileSupported, the
        "imAbout" image on the left hand side of the dialog is now no longer
        restricted to the top left cell in the grid, but uses more space
        as expected.
        
        Change-Id: Ia2edb147d7576d863d597c01d4d310e8798a9ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175668
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [e8e0a676b31596ce0d1fee7936ff934dfc9e3c09]

        tdf#130857 qt weld: Implement QtInstanceImage::set_image
        
        Extract a helper to convert a BitmapEx to a QPixmap
        from the existing helper function `loadQPixmapIcon`
        and add a new helper that converts a
        css::uno::Reference<css::graphic::XGraphic>& to
        a QPixmap reusing most of the code.
        
        Use that to implement the QtInstanceImage::set_image
        variant with that parameter type.
        
        With this in place, opening the "Help" -> "About LibreOfficeDev"
        dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
        of .ui files in QtInstanceBuilder::IsUIFileSupported now opens
        the dialog with brand image and LibreOffice Community logo present,
        but other aspects in that dialog still need attention before
        enabling this by default.
        
        Change-Id: Ide28c0dc126be511ec8e34e57f4f1df7e70297ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175666
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [6a7e1abd100d3aad2d23c96e835e182d191b505d]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_preferred_size
        
        Implement QtInstanceWidget::get_preferred_size by returning the
        size of the QWidget::sizeHint property [1]:
        
        > This property holds the recommended size for the widget
        
        With this in place, opening the "Help" -> "About LibreOfficeDev"
        dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list
        of .ui files in QtInstanceBuilder::IsUIFileSupported now triggers
        the assert in QtInstanceImage::set_image because that's no implemented
        yet, while this was not reached at all before, because
        
            const tools::Long nWidth(m_pCopyrightLabel->get_preferred_size().getWidth());
        
        at the beginning of AboutDialog::AboutDialog would previously
        set a preferred width of 0, and with that, there was no attempt to
        set the images at all.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#sizeHint-prop
        
        Change-Id: I6eaedf07f73ea5e71a36d3e9bc9a0f55e515ffe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175665
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [37cc6b8e46288c132ef3b7c5cf44560517a7a00e]

        tdf#130857 qt weld: Set actual positions for layouts inside grid
        
        Extend QtBuilder::applyGridPackingProperties to not only
        handle widgets (QWidget), but also layouts (QLayout), so
        that the proper position inside the grid is also set for
        these.
        
        This will be used e.g. by the "Help" -> "About LibreOfficeDev"
        dialog.
        (When adding "cui/ui/aboutdialog.ui" to the list of .ui files
        in QtInstanceBuilder::IsUIFileSupported, those UI elements
        that show up are now in the correct positions, but other things
        unrelated to this particular commit are still missing.)
        
        Change-Id: Ic7c342e0307526f29e1fa149acd25a27373069ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175662
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [3e28b4f0c97d011cf4222941f019ce05fe6b0313]

        tdf#130857 qt weld: Simplify QtBuilder::applyGridPackingProperties
        
        No longer try to retrieve the current row and column
        of the widget in the QGridLayout and apply the "top-attach"
        and "left-attach" properties to set the new row and column
        separately.
        
        Instead, assume (and assert), that both, the new row and column
        properties are set, get them and then set the position using
        both of them at the same time.
        
        If any of the properties is missing, that most likely needs
        to be fixed in the .ui file.
        
        As a side note, something similar to the previous algorithm to
        determine the grid position might be useful to implement
        QtInstanceWidget::get_grid_left_attach etc. at some point.
        
        Change-Id: I22e34275e3974f42ca3ee43fa6cb66624e917443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175661
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [b520cf15a3569d683ac39edb7fb0202317b927cf]

        tdf#130857 qt weld: Allow null func for async dialog
        
        Drop the assert that a function to call is set
        in QtInstanceDialog::dialogFinished and just skip
        that step if none is set.
        
        While `m_aRunAsyncFunc` gets set in both
        QtInstanceDialog::runAsync variants and
        QtInstanceDialog::dialogFinished shouldn't get
        called without these having been called first,
        QtInstanceDialog::runAsync can explicitly be called with
        null for the function, which is the case e.g. for the
        "Help" -> "About" dialog (s. the SID_ABOUT case in
        SfxApplication::MiscExec_Impl), so that assert
        triggers in a WIP branch for implementing support
        for that dialog using native Qt widgets when the
        dialog is closed.
        
        Change-Id: I18578a4b1780b05f59817ad85eee3c3a20ba3b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175660
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [4689363f7259a4364c38d40664bd9cf3d945ed30]

        tdf#130857 qt weld: Add child layouts to grid
        
        If a QLayout object is created as the child of a
        QGridLayout object (e.g. a "GtkBox" as the direct child
        of a "GtkGrid" in a .ui file), add that layout to the
        QGridLayout - initially in a new row, but rearranging
        that will be done as part of processing the "packing"
        properties of the children once that is implemented
        for layouts as well. (See  QtBuilder::applyPackingProperties
        and QtBuilder::applyGridPackingProperties where this
        is currently only implemented for QWidget children).
        
        This will be needed e.g. for the "Help" -> "About LibreOfficeDev"
        dialog.
        
        Change-Id: I292134b26efa0dfe5c8fe0684dc02dece338d579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175659
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [0846977a2280824006fb1620706cc785802336e3]

        tdf#130857 qt weld: Add a QtInstanceLinkButton
        
        Add a new QtInstanceLinkButton class that is
        the weld::LinkButton implementing using a native
        Qt widget.
        
        QLabel can be used to display a hyperlink, as it
        supports the HTML syntax for the text, so using ,
        
            QLabel myLabel;
            myLabel.setText(QLatin1String("<a href=\"https://www.libreoffice.org">LibreOffice Website</a>"));
        
        can be used to let the QLabel handle a hyperlink.
        
        To make it simple to set this as needed for a QLabel,
        implement a new QLabel subclass called QtHyperlinkLabel
        that provides convenient getters and setters to set
        the displayed text and the link target, and takes
        care of setting the QLabel text based on that as needed.
        
        Implement QtInstanceLinkButton using an instance
        of that class as the widget and create an instance of
        that class in QtBuilder when encountering a "GtkLinkButton"
        object while processing a .ui file and evaluate
        the "label" and "uri" properties.
        
        Change-Id: I71d28b6e5e3cbd110ec5b3d1232d55e9d2bb8a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175656
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [c5f68d9862ff0cf55b449bd2f638a4cd22d28501]

        tdf#130857 qt weld: Add QtInstanceImage skeleton
        
        Add a new class QtInstanceImage as a weld::Image
        implementation using native Qt widgets.
        
        It uses a QLabel that holds the Image, which can
        be set using QLabel::setPixmap [1].
        
        This commit adds the new class, lets
        QtInstanceBuilder::weld_image return an instance
        of the new class, and extends QtBuilder to create
        a QLabel when it encounters a "GtkImage" object.
        
        The logic to actually set the image when either
        processing the .ui file or when one of the
        weld::Image::set_from_icon_name or one of the
        weld::Image::set_image variants gets called
        still needs to be implemented in subsequent
        commits for the label to actually display
        an image.
        
        [1] https://doc.qt.io/qt-6/qlabel.html#pixmap-prop
        
        Change-Id: I3aa526b89487a5301dabd108723d7b68ca85ea66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175655
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a599e493f36cdfbc211debce81fab022121bd71d]

        reduce some rtl_uString_acquire/rtl_uString_release pairs
        
        Change-Id: I6d18b07bb0fb1ec355fb4fbfa166449c1041aa82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175667
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-26  Julien Nabet  <serval2412@yahoo.fr>  [6130b0f8cdc5bddbf96ea27a77882835b233c099]

        Revert "tdf#163486: PVS: Array overrun is possible"
        
        This reverts commit 433eb742c0ff81ff568e4a5f469a6ad4c827b8f5.
        
        Reason for revert: see Mike's comment
        
        Change-Id: I72832edf3d94e015a44e9764d9139fb41c521097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175613
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-26  Julien Nabet  <serval2412@yahoo.fr>  [433eb742c0ff81ff568e4a5f469a6ad4c827b8f5]

        tdf#163486: PVS: Array overrun is possible
        
        Change-Id: I53c32af196caabb6084936eb4dd7f360b6226782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175672
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-26  Julien Nabet  <serval2412@yahoo.fr>  [2bfcfb69ea7f9cb4221a9e96da812858ef5b1052]

        Try avoid "vector erase iterator outside range" in Windows build
        
        + adapt test case.
        
        Change-Id: I0edbe5543755ab09652ad9fda369748e567260dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175632
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [08d17df3c59531a9948de5d2e24b02b587b4d838]

        Removed exec bits on rtf file
        
        Change-Id: Ib24816de688a25e509ec416f7aaa475ea94b73e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175671
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [801280697cac41f41018da378b6d79bc8ff4e6dc]

        editeng: unnedded assigment
        
        After
        commit f04ab0ea41db4e91c3dd898a560426867a466988
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Wed Oct 23 16:13:04 2024 +0200
        
            tdf#163486: PVS: Expression is always true
        
        Change-Id: I33a3cbdc2c7013d5d739c55d3b129f05a329197f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175669
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a8278c42e14b03eb57987adf33b6d61bfb3f856]

        sw/qa: simplify a bit
        
        Change-Id: I5d75561f06ce4f981927afb333af5a99bd7ffe26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175645
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [a0042f104cc90b5fa049020e4622e4019d186eb3]

        tdf#130857 qt weld: Declare support for Math "Alignment" dlg
        
        Add .ui file of Math's "Format" -> "Alignment" dialog
        to list of files supported by QtInstanceBuilder, so that native
        Qt widgets are used for that dialog now when using the qt5/qt6 VCL
        plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1
        is set.
        
        Change-Id: Ic0b58b2f77be136eeea9ac8a29501cd30b24dce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175640
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [076deef1324b7db84f2a33ed005efe808b81a46e]

        tdf#130857 qt weld: Add QtInstanceRadioButton
        
        Implement initial support for native radio buttons
        using QRadioButton:
        
        * Let QtBuilder create a QRadioButton widget
          when it encounters a "GtkRadioButton" object.
        * Let QtBuilder::setProperties also handle the
          QRadioButton case. Both, QRadioButton and
          QCheckBox derive from QAbstractButton, so reuse
          the existing logic for QCheckBox to set label and
          checked status.
        * Add new class QtInstanceRadioButton as a weld::RadioButton
          implementation that uses a QRadioButton widget.
        * Let QtInstanceBuilder::weld_radio_button return
          an instance of the new class.
        
        For now, ignore the GtkRadioButton "group" property [1]
        that is used to group radio buttons.
        
        QRadioButton's are automatically grouped when they
        have the same parent widget, which is sufficient
        for the case of the "Alignment" dialog in Math
        for which support will be declared in an upcoming
        commit.
        
        For more complex scenarios, the use of QButtonGroup [2]
        could be implemented in the future to explicitly group
        radio buttons, as mentioned in the QRadioButton doc [3]:
        
        > If you need multiple exclusive button groups for radio buttons that
        > belong to the same parent widget, put them into a QButtonGroup.
        
        [1] https://docs.gtk.org/gtk3/property.RadioButton.group.html
        [2] https://doc.qt.io/qt-6/qbuttongroup.html
        [3] https://doc.qt.io/qt-6/qradiobutton.html
        
        Change-Id: Iaf8b0fef00fc10268c09410080156e7913634ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175639
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [3e0aecad5491bedbee94b4937fe7e08edf5ae203]

        tdf#130857 qt weld: Declare support for sw "Rename Object" dialog
        
        Add .ui file of Writer's dialog to rename objects
        to list of files supported by QtInstanceBuilder, so that native
        Qt widgets are used for that dialog now when using the qt5/qt6 VCL
        plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1
        is set.
        
        That dialog can be triggered e.g. as follows:
        
        * create new Writer doc
        * insert a bookmark ("Insert" -> "Bookmark")
        * in the Navigator sidebar panel, select the
          bookmark
        * righ-click, select "Edit"
        * press the "Rename" button in the "Bookmark" dialog
        
        Change-Id: I0ac8f66b977f5d999bb197cc68e8ce5533fe1ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175634
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [fac6d5da618f4f71e1bacc8a1dd07923407d907e]

        tdf#130857 qt weld: Prefer custom handler for dialog buttons
        
        If a custom handler is set for a button in a dialog's
        button box, skip the default handling (to close the
        dialog with the corresponding response code, unless
        it's the help button) in QtInstanceDialog::handleButtonClick,
        so that the custom handler gets processed instead
        (see QtInstanceButton::buttonClicked).
        
        This is similar to what the VCL implementation
        (see SalInstanceButton's ClickHdl) and the
        gtk3 implementation (see
        GtkInstanceDialog::asyncresponse) do.
        
        In order to be able to determine whether
        a custom click handler is set, make
        weld::Button::connect_clicked virtual
        and override it in QtInstanceButton::connect_clicked
        to set a property on the QPushButton object
        to indicate that a handler is set.
        Introduce a static helper method
        QtInstanceButton::hasCustomClickHandler
        that evaluates this property.
        
        Without this change in place, pressing the
        "Rename" button in Writer's "Rename Object"
        dialog that will be declared as supported
        in upcoming commit
        
            Change-Id: I0ac8f66b977f5d999bb197cc68e8ce5533fe1ebd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 25 10:41:45 2024 +0200
        
                tdf#130857 qt weld: Declare support for sw "Rename Object" dialog
        
        would not actually result in a bookmark getting
        renamed, only the dialog would be closed.
        
        Change-Id: If3e762100349ecd06c4e9415e9a8f9a44ec6491c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175633
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [17dfa97f642394f6ec583362032debaf9ea922ef]

        tdf#130857 exportepub.ui Define frames in order
        
        Move the definition of the "customize" frame above
        the "metadata" one in the .ui file so that it matches
        the visual appearance, which makes sure that tab focus
        order with the Qt-based VCL plugins is correct as well
        for Writer's "File" -> "Export As" -> "Export as EPUB"
        dialog.
        
        See
        
            commit 02692566ad9fc7c3484f8581ffa0004cd4e43987
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Oct 24 17:43:35 2024 +0200
        
                tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        for more background.
        
        Change-Id: I1db418d4c6394fd8dd0db5127dbcd8e3f0dc09c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175627
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [21bf1509f2ab445c5bc46c839e89d1d6ad1c6b6d]

        tdf#130857 qt weld: Declare support for "Export as EPUB" dialog
        
        Add .ui file of Writer's "File" -> "Export as"
        -> "Export as EPUB" dialog to list of files supported by
        QtInstanceBuilder, so that native Qt widgets are
        used for that dialog now when using the qt5/qt6 VCL plugins,
        unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        Change-Id: I6509dbccc3bcb8714a4cdeb23925c66057723a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175626
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [0a4ec73c23678cc1008f191a08963c331255db61]

        tdf#130857 qt weld: Add a QtInstanceFrame
        
        Add new class QtInstanceFrame as a native Qt
        implementation for weld::Frame.
        
        This uses a QGroupBox as a widget, see
        
            commit e2e59d2da1aa4c9f8df62e5a072f0f2cd931781b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 10:38:32 2024 +0200
        
                tdf#130857 qt weld: Create QGroupBox for "GtkFrame"
        
        Return an instance of it in QtInstanceBuilder::weld_frame.
        
        This is used e.g. by the "File" -> "Export as" -> "Export as EPUB"
        dialog in Writer.
        
        Change-Id: I099b8f38fb884881d8d8db38aa918c76f25b6d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175625
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cc7d8b01f03ba494d0fcfb735b6ec43522c97d0e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 3afbfbdd5fe5e3053aa67158a95897c21e142ad7
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I47284bc708fa842a1bb32efa8df4de4d3c296036
            
2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5a6cb358905b92ea09ccaf745c40b774d53d38e]

        we can remove a SharedString copy now
        
        given that there is no OUString* pValueSource2 case
        
        Change-Id: I5420ebf7cc7cd5d0b77256788e8ecd74d445a286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Miklos Vajna  <vmiklos@collabora.com>  [1e75155c6995e4f1534e2062c64fab35d49ea60b]

        cool#9992 lok doc sign: allow injecting sign cert/key during pdf export
        
        Interactive signing via the .uno:Signature command parameters were
        possible, but headless PDF export had no similar parameters.
        
        The primary difference is that the interactive signing works with the
        sign certificate of the SfxViewShell, while PDF export has its own
        vcl::PDFWriter::PDFWriterContext::SignCertificate.
        
        Fix the problem similar to what commit
        80723fccbb03c215bab84b10ac1eefaedef66b7c (filter: allow PDF export to
        sign from the cmdline, 2022-02-03) did, but here we don't refer to an
        already configured sign certificate by name, we take the sign cert/key
        from parameters instead.
        
        Test this in the NSS case where it's known to work, ignore the mscng
        signing case for now.
        
        Change-Id: Ib0c171736d2554fb3678ae4b8842541c43f9f3dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175644
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0ec8bc47a3e605667a3c6887feb4157e488f96b]

        ScQueryEvaluator::compareByString now never has non-null pValueSource2
        
        and always has non-null pValueSource1
        
        Change-Id: I5774e8beefeb5e40d316ea8557c656a126f4a7ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f0cf85983d0b04a9889c45e26ce8fd9dc022fc89]

        tdf#132253 tdf#163482 Use .uno:InsertHyperlinkDlg as alias
        
        to HyperlinkDialog.
        
        The purpose of the obsolete command was to open Character Formatting dialog
        with the Hyperlink tab focused.
        
        Change-Id: I8a3053a7bc7bd98c33224c0988d5c0994d4dca9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175412
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [32ab4b4b6364652294891f66a86f153b65abfbbe]

        tdf#139152 Exporting Image or Drawing to PNG is missing metada
        
        implement this in a similar fashion to how export to JPEG does it. Add a
        new method to calculate pixels-per-meter, because that is how PNG stores
        the values internally
        
        Change-Id: I1e4cd5a36af22e52a7c52f5b3bc2407f8523ef9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175636
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-25  Oliver Specht  <oliver.specht@cib.de>  [44edd6568533c135fb78ec2f4c202a87989319be]

        tdf#160621 follow-up to fix height of field value
        
        With 2b45427a567d1d52951b6f61aaea74147dab10cf the height and width
        of the edit variable field dialog has been increased but that
        didn't always work. Here the grid structure has been changed to
        give more space to the value field.
        
        Change-Id: I1ab0ee7cd31a046db95578801d435e988f039ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174714
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-25  Oliver Specht  <oliver.specht@cib.de>  [b310be24bc0af0871133e55057e3528148346660]

        tdf#161538 update page preview on changed printer settings
        
        Updates the print preview if show/hide automatically
        generated empty pages is changed.
        
        Change-Id: I8ee53c575edb31f16556a66037260cf79f0fb4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175416
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-10-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9fefe341d0c181d5832eef5ac1fcca5d4dd4649f]

        Fix typo
        
        Change-Id: I6bc22a78674982a9fafbda020bfa63f63b37995f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175643
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-25  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [c6803b18d85e8cbd2e76ff0d46e7f4ff2e312916]

        tdf#160553: writerfilter: RTF import: fix problem with first table in section
        
        Handles section properties between tables.
        JUnit test included
        
        Change-Id: I1db8b80749d18c0e73112e4fd1d13d6331aa7291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165286
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-25  Jack Honour  <JaxkDev@gmail.com>  [a308151714a2bc811f6f147055175de9767d313a]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I58be12e3b32a82f137486a314d28b1aaca2202fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175557
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6c9d1012d20541f6373b51ff3c25d8fd7bc8c69]

        flatten ImpGetScaledGraphic a little
        
        Change-Id: Iaefbfcb8d2f062c3b2f6a7d0c336ec46323de371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-25  codewithvk  <vivek.javiya@collabora.com>  [7a802001b06939476a8d8a3f4dc7e5c234d376a4]

        sc: simplify boolean checks by removing redundant comparisons
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: I2012a757ce9a70b9edb6a344973b5088b5cfa20b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175078
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 89fe841cdcccfd34e7e092af7d8cd4d952175a2f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175400
        Tested-by: Jenkins

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8805b6fa554f8a7b720c79599cff5d88ddccd05]

        tdf#95680 Convert - Metafile - Save Image... No function.
        
        The obvious fix seems to work
        
        Change-Id: Iabbde43f18b49f19149a9a7ee44efd0b6b445736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175624
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-25  JaxkDev  <JaxkDev@gmail.com>  [cf39ee6cbfed2ec6e82c136712910bf3f4954bdf]

        tdf#143148 Use #pragma once instead of include guards
        
        Few more files converted to #pragma once convention, plenty more in sw/inc (~150)
        
        Change-Id: I5f5a2604f0fe879a6318e5d174653057a53f9af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175511
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [cc06aa263cb980e851496c31ff3d42fc0370cdbf]

        Simplify a bit
        
        Change-Id: I74209dcd5be43362abed928411cccdc7e7c99602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175604
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [aeae8e9c030549f11c18f5e4a33a06f984e997f0]

        SwModelTestBase: assert SwDoc inside getSwDoc()
        
        Change-Id: Icf70904a963b099db6c8be0384cbed92b93a28eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-25  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [11e0e576f4e38adcbe16601b63ab353424acf610]

        fix: repeat slideshow duration display issue
        
        Change-Id: Id762a2f0ca9ad1603dff42fbd1ad992282933007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175629
        Tested-by: Jenkins
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>

2024-10-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [973d0f0bb5f8a166b0e545d0151444fcb201ba57]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 282, 296
        
        Change-Id: Ie74d4b31246ba279ad7e1e585036b1b06ad3fabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175424
        Reviewed-by: Jack Honour <JaxkDev@gmail.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a1336e81c84c3386658eff25da34eca7fd86b77]

        tdf#153182 PPTX Chart with datamodel rendered incorrectly
        
        Partial fix.
        
        (*) fixed bugs where the use of continue in loops meant that a tracking
        variable was not being updated
        
        (*) improved exception message in TableModel::getCellByPosition
        
        (*) rather than exiting the view generation process with an exception,
        log a warning and skip that part of the view process
        
        The root of the problem here is that we don't seem to be importing
        data-tables from PPTX properly. I suspect that we need more import
        code, in particular, we probably need to read some flag that
        indicates if we have header rows and columns.
        
        Change-Id: Iaa9a1593bc185a5bb4f36a434117bbd5bf323e18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175551
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d71cd10b5cefa9d0ce3c51340255ccd0399ef538]

        don't always need this object
        
        Change-Id: I1b9efe872bb31a2cd53adc30d63590b5bc9693ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175623
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [efcf065973b8b808b1fd1c0f5aa9d3b2a69943c5]

        Fix typo
        
        Change-Id: I6e53eb5cea9d325b995ec8d0794309efb06b29ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175631
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [2d25e27069ba01d564352d59a7ec8bd8317d092c]

        win a11y: Assert creating MSAAService succeeds
        
        Add an assert that creating the MSAAservice/a11 bridge
        succeeds in ImplInitAccessBridge on Windows, as this
        should never fail unless the LibreOffice installation is broken.
        
        Drop the return values of the ImplInitAccessBridge
        and InitAccessBridge functions accordingly and
        simplify code calling them.
        
        While at it, also switch to using `#ifdef _WIN32` for
        the Windows-specific code in `InitAccessBridge`
        instead of having it in the `#else` branch of
        `#if defined UNX`, to align this with the `#ifdef _WIN32`
        condition for the `ImplInitAccessBridge` declaration,
        as that's the function that gets called.
        
        Even if the creation of the service should fail for some
        reason, the DeploymentException in ImplInitAccessBridge
        is still handled, so unless I'm missing something, this
        commit shouldn't cause any harm. The "EnableATToolSupport"
        setting would then incorrectly be set to true indicating
        that AT support is enabled, but besides being used in
        the a11y bridge code itself, that's only used to determine
        whether or not to pre-populate menus, so they are
        available in the a11y hierarchy before the corresponding
        (sub)menu gets activated, s. MenuBarManager::FillMenuManager,
        the corresponding commit that originally introduced this,
        
            commit 08fe2669a0ed807812d005195b54cc41f092d09a
            Author: Rüdiger Timm <rt@openoffice.org>
            Date:   Fri May 13 06:29:54 2005 +0000
        
                INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED
                2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD)
        
        and the referenced bug report [1], in particular comment 3 [2]:
        
        > TBE->CD: As discussed, the accessibility hierarchy is built up, but part of the
        > information is missing, e.g. Menu::GetItemText()  returns an empty string.
        > Also keyboard shortcuts should be available.
        > In addition, the File/New menu and the File/Wizards menu are missing.
        > All this information is only available, after the corresponding menus have
        > been opened by the user.
        >
        > In OO.o 1.1.x all this was working. The AT tools require, that the whole menu
        > hierarchy is available as soon as the menu bar is visible, that means before
        > a user has opened a menu.
        >
        > The whole menu hierarchy must be only provided, if accessiblity is enabled.
        > This can be checked by
        > BOOL bAccessibilityEnabled =
        > Application::GetSettings().GetMiscSettings().GetEnableATToolSupport();
        
        This commit is also in preparation of further simplifying
        the handling for that setting.
        
        [1] https://bz.apache.org/ooo/show_bug.cgi?id=48612
        [2] https://bz.apache.org/ooo/show_bug.cgi?id=48612#c3
        
        Change-Id: I46149ed215c354d33003513d55defe4920a7c381
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175565
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [22074628b2a020ca7103be27c4aecbb3927ecad9]

        Simplify a bit
        
        Change-Id: I906051431efec691dce093f6e7e6e73f2f5187fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175602
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-25  Jaume Pujantell  <jaume.pujantell@collabora.com>  [9538d547a39581c7ef249fa4fd3dd360b971f2c0]

        cool#6382 lok: sw: text wrong format on inserted text
        
        When inserting text at the beginning of a list item the incorrect
        font is used. It used default style instead of the font applied to
        the item text.
        
        Added a test to avoid this regression, and also modified the test
        testIMEFormattingAtEndOfParagraph to better catch regressions there.
        
        This reverts some changes from:
        lok: IME: preserve formatting when inserting at the end of paragraph
        bf96d1f23e5c12f9263643dfdab94fd1361bb098
        lok: IME: directly copy formatting for inserted text
        d8dbd123bfa7f39489ceb15ac83142635531fd43
        tdf#146728 lok: IME: preset formatting in the new paragraph
        218acb48df79101392c2cc3a030ddb5dcee878c7
        
        Change-Id: I60071e06ff448b2e7c2d5a628a344fbfd15b30af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174657
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174869
        Tested-by: Jenkins

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7cf8cffcb8cfb722ab27a2884c146b464ef89041]

        cid#1633347 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1633346 COPY_INSTEAD_OF_MOVE
        cid#1633344 COPY_INSTEAD_OF_MOVE
        cid#1633343 COPY_INSTEAD_OF_MOVE
        cid#1633340 COPY_INSTEAD_OF_MOVE
        cid#1608137 COPY_INSTEAD_OF_MOVE
        cid#1608131 COPY_INSTEAD_OF_MOVE
        cid#1607860 COPY_INSTEAD_OF_MOVE
        cid#1607432 COPY_INSTEAD_OF_MOVE
        cid#1607394 COPY_INSTEAD_OF_MOVE
        cid#1607310 COPY_INSTEAD_OF_MOVE
        cid#1607156 COPY_INSTEAD_OF_MOVE
        cid#1607093 COPY_INSTEAD_OF_MOVE
        cid#1607090 COPY_INSTEAD_OF_MOVE
        cid#1607039 COPY_INSTEAD_OF_MOVE
        cid#1606709 COPY_INSTEAD_OF_MOVE
        cid#1558053 COPY_INSTEAD_OF_MOVE
        cid#1558052 COPY_INSTEAD_OF_MOVE
        cid#1558042 COPY_INSTEAD_OF_MOVE
        cid#1558038 COPY_INSTEAD_OF_MOVE
        cid#1558037 COPY_INSTEAD_OF_MOVE
        cid#1558034 COPY_INSTEAD_OF_MOVE
        cid#1558031 COPY_INSTEAD_OF_MOVE
        cid#1558027 COPY_INSTEAD_OF_MOVE
        cid#1557994 COPY_INSTEAD_OF_MOVE
        cid#1557977 COPY_INSTEAD_OF_MOVE
        cid#1557970 COPY_INSTEAD_OF_MOVE
        cid#1557966 COPY_INSTEAD_OF_MOVE
        cid#1557957 COPY_INSTEAD_OF_MOVE
        cid#1557954 COPY_INSTEAD_OF_MOVE
        cid#1557941 COPY_INSTEAD_OF_MOVE
        cid#1557933 COPY_INSTEAD_OF_MOVE
        cid#1557918 COPY_INSTEAD_OF_MOVE
        cid#1557907 COPY_INSTEAD_OF_MOVE
        cid#1557890 COPY_INSTEAD_OF_MOVE
        cid#1557883 COPY_INSTEAD_OF_MOVE
        cid#1557881 COPY_INSTEAD_OF_MOVE
        cid#1557861 COPY_INSTEAD_OF_MOVE
        cid#1557842 COPY_INSTEAD_OF_MOVE
        cid#1557840 COPY_INSTEAD_OF_MOVE
        cid#1557830 COPY_INSTEAD_OF_MOVE
        cid#1557830 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If5ee3396eafdb8b338d9e6cf0705be6e2b431fd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6177bb610a247e516903c500bf05dd7c11a8ca0]

        reason_pdf no longer exists
        
        since:
        
        commit 2a40505d00fcd79bfa433c301ddc05a35287bfb1
        CommitDate: Thu Jan 26 15:09:20 2023 +0000
        
            remove option to toggle IsPDFAsStandardPrintJobFormat from UI
        
        Change-Id: Ib4797709396009a7c54c467d6b00bf9cd3b348cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175578
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [fb41273bf460234a5636a37765bdba90860147d4]

        sw/qa: use getSwDocShell() when possible
        
        Change-Id: Ia2e3dad4e62fb084c3a88564deb137cbcc7728b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175573
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5211168bb020c53c8f870f3c6f391777df8ae363]

        cid#1633779 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1633350 COPY_INSTEAD_OF_MOVE
        cid#1633349 COPY_INSTEAD_OF_MOVE
        cid#1633348 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I58d82029647a6661983465efa2c2abc17a5744c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dfa9af835c19a441a0d0aee58920bfad9e1cbe01]

        Related: tdf#159860 inform if there is > 100 master slides
        
        which is atypical and easy to not notice when it happens
        
        Change-Id: I16546b0e841771c746cd33fefd7ec15e2877b08d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0c49bd1554885ed601ae9a9507a5689b2cc7914]

        cid#1633781 Initialization or destruction ordering is unspecified
        
        and
        
        cid#1633780 Initialization or destruction ordering is unspecified
        cid#1633778 Initialization or destruction ordering is unspecified
        cid#1633777 Initialization or destruction ordering is unspecified
        cid#1633776 Initialization or destruction ordering is unspecified
        
        Change-Id: I8ae7cbede6df2ad747fe57d0ac2800e1b6a31038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175576
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [8bcdd32f2fbb8825564ec4eeabe1d6f3eed808ce]

        tdf#130857 qt weld: Handle combobox entries from .ui file
        
        Implement handling for combobox items in
        QtBuilder::insertComboBoxOrListBoxItems, similar
        to the VCL implementation in , similar
        to what's done in VclBuilder::insertComboBoxOrListBoxItems.
        
        This will be used e.g. by the "File" -> "Export As" ->
        "Export as EPUB" dialog
        (writerperfect/uiconfig/ui/exportepub.ui).
        
        Change-Id: Ie7a0f17c1a8ad523ca55c09dfce65a0b5d9cc41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175572
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [05a38a21092c063126d6923d0dfb47ba5d39d5c2]

        tdf#130857 VclBuilder: Move extractActive to BuilderBase
        
        Turn this helper function into a static function
        in the BuilderBase class, for reuse in QtBuilder
        in an upcoming commit.
        
        Change-Id: I68c7e62816ff5fdd1c2a02cf5e42f90b32cff627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175571
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [02692566ad9fc7c3484f8581ffa0004cd4e43987]

        tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order
        
        Switch the order that the widgets are defined in the .ui file
        to match their logical order (to be top to bottom, left to right)
        as also described by their "left-attach" and "top-attach"
        properties.
        
        This only rearranges the order without changing anything else
        for the single children and doesn't have any effect for the gtk3
        and VCL implementations.
        
        But as described in more details in
        
            commit 0fe7b3cebc1a070b13b825635f4bd387a22e41ab
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 23 22:43:10 2024 +0200
        
                tdf#130857 printersetupdialog.ui: Define focusable widgets in order
        
        , Qt uses the construction order of widgets to determine
        the tab order as well, meaning that focus would unexpectedly jump from
        the edit to the checkbox, then back to the combobox without
        this commit in place for the qt5 and qt6 VCL plugins in this
        dialog ("Tools" -> "Options" -> "Languages and Locales" -> "Writing Aids"
        -> "New") now that native Qt widgets are used.
        
        Change-Id: Ib09137cb11dab60c4a1af4fbc3b007e801dea33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175567
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [9c52785e13f0e4ca8c314730f47b5e887da963fb]

        sw: Resave renameobjectdialog.ui with glade 3.40
        
        Change-Id: Ib977073b0c7b851f67abc78727b08ba559a501cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175566
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [912ef29867e8d5698ae6613e6a2227d12338abd1]

        tdf#130857 qt weld: Declare support for "New Dictionary" dialog
        
        Now that previous commits implemented the functionality
        required by this dialog, add the .ui file to the list
        of supported ones for QtInstanceBuilder.
        
        This dialog can be triggered via "Tools" ->
        "Options" -> "Languages and Locales" -> "Writing Aids"
        -> "New".
        
        Change-Id: Id5c73d49a374eb0e84944f734126a4164f753b00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175547
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [0d2188d376829115bfb096f946973f05fde31a51]

        tdf#130857 qt weld: Implement QtInstanceComboBox::{g,s}et_active_id
        
        This is made use of e.g. in the "Tools" ->
        "Options" -> "Languages and Locales" -> "Writing Aids"
        -> "New" dialog" in a WIP branch where that dialog's
        .ui file ("cui/ui/optnewdictionarydialog.ui") was added to the
        list of supported files for QtInstanceBuilder.
        
        Change-Id: I5099672bac495bf47cc0d6aa806a69e8729066e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175546
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [2db9f1c08e28d0ae06be7db5a20912f9198468f0]

        tdf#130857 qt weld: Notify about weld::Entry text/cursor changes
        
        In QtInstanceEntry, notify about cursor and text
        changes by connecting to the corresponding
        QLineEdit signals and calling
        weld::Entry::signal_cursor_position and
        weld::Entrysignal_changed accordingly.
        
        This is made use of e.g. in the "Tools" ->
        "Options" -> "Languages and Locales" -> "Writing Aids"
        -> "New" dialog" in a WIP branch where that dialog's
        .ui file ("cui/ui/optnewdictionarydialog.ui") was added to the
        list of supported files for QtInstanceBuilder.
        Without this commit, the "OK" button would remain
        greyed out even after typing a new name in the
        edit.
        
        Change-Id: I006ed711652c65b0af1d8af5ae5c4dc80691a9b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175545
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [4b1a85ec15de0c0aa3e6537e0b2fb10ccc0e38fe]

        tdf#130857 qt weld: Implement combobox text selection
        
        QComboBox::LineEdit provides access to the combobox's
        line edit, which can then be used to retrieve/modify
        the text selection.
        
        Make use of that to implement
        QtInstanceComboBox::get_entry_selection_bounds
        and QtInstanceComboBox::select_entry_region.
        
        Change-Id: I5aa0abd9e24c58cafda9032d631bd8c028c037ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175544
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [621caf93ce15a49a5f08599e45b047de08ee223d]

        speedup saving large XLS file with lots of query formula(2)
        
        reduce cost of OUString construction by avoiding
        initialising a temporary and then overwriting it.
        
        12s to 10s
        
        Change-Id: I889152ba71947004ca7d5c96f073182c94d95ed5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175539
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a958e09409b94b97c0d0aa67dd605d321dc42615]

        speedup saving large XLS file with lots of query formula
        
        make more use of svl::SharedString instead of
        unnecessarily creating OUString that then need to be
        interned. We were spending all our time inside the
        the SharedStringPool::intern function.
        
        20s to 12s
        
        Change-Id: I344f0acfd462fdb6d78e392881f066a56844fa94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [00c2d0c6e5dd567c0b235ad95f6b3c4282725821]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1097, 1100, 1121
        
        Change-Id: I2f0f1f657455eb769c75b219bafe4cde777a71fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175431
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9a235a550ff37157eb9a315eacfd9da3d8ca59a8]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 2404, 2441
        
        Change-Id: I3e929e8b465e77a6ad550bf35658abb36befa6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175426
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c01cac0654d7f11012e3755e942cbf391e82aaff]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 103, 106
        
        Change-Id: I761622d8c980c7f53ae4d9c77a83c918a2efb22c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175429
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [cf9b7e36fe7f5f9a817d9fee420f9c5439f69d63]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 105, 155
        
        Change-Id: I077ba811fb9050eca4ba97d225323c807ee8e9cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175390
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9517639bc3189e3ea4dc4d2f7004d4b33d754d47]

        -Werror,-Wunused-variable
        
        ...after 64e8d5d8b9a56f31caff66675180342773f847a0 "sw/qa: use getSwDoc() more"
        
        Change-Id: Ib13fe63cac26ff083da5d8c104921c510fa5bb7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175579
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1a7f87a71f25f3658af7b3b6d53637480fb5e85c]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/b9c5a10b9c0cbac84e3e63ce3ec0e6a09aab8f8d>
        "gvfs: Update gvfs-1.56.0.tar.xz to 1.56.1"
        
        Change-Id: Iaf20b7bb5662cdcd54817f15fa366df17dab53e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175548
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-24  Marc Mondesir  <timepilot3000@gmail.com>  [3ac4ea71d8fcd05d73b68397859056a14768dc03]

        tdf#119745: Improve horizontal scroll speed in Calc for Windows.
        
        Use a value for horiz scroll reduction on Windows that better suits scroll values from OS.
        
        Change-Id: Ie26c32fbed8ffd26094556d87a06d87938e98721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175187
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8f71364a582e39a2fb04a09c9ae1bf8470c43c4]

        tdf#163554: sc_subsequent_export_test4: Add unittest
        
        Change-Id: Id27b893d1bbf80d2dee7c5b3a6c18656d84b7d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175549
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [500060c71a0ac2457fcf917b34206d9641a49327]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d3349d68ca4d6a488d7226f18012f2a69de4f7d
          - Completion of CHAR and CLEAN functions
            
            Added link to wiki pages.
            
            Change-Id: I9c5b5d44f05c8d803994cd9efc864ab873bdd386
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175554
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [64e8d5d8b9a56f31caff66675180342773f847a0]

        sw/qa: use getSwDoc() more
        
        Change-Id: I742309d99c4d9839dcd4f8b747fc9aef549998ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175555
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b1ecafb2400672a894e4b8724bdaaa4c7a69b2b4]

        Remove archaic xmerge
        
        Formats like Aportisdoc can be opened via
        org.libreoffice.comp.Writer.EBookImportFilter instead.
        
        It doesn't look like there will be any support implemented for Nokia
        9210 Communicator PsiWord. No particular burning demand for that
        anymore apparently.
        
        Removal of the filters that used xmerge took place at:
        
        commit a5783fe922b2419b5b662eb5f544a1f401341dbf
        CommitDate: Sun Mar 3 19:19:26 2013 +0100
        
            remove stale javafilters
        
        Change-Id: I0a0087fb2ee015de42c1802b5e9bc6dc42a5efe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174563
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-24  Justin Luth  <justin.luth@collabora.com>  [dff45ef0141d6d2cbe4634dec5ef59cd363a6725]

        diff-pdf-page.py: remove intermediate composite step
        
        One convert step can be eliminated,
        which should help with performance.
        
        Change-Id: I860c90fec7f178b456b942d8ad4e4ec5d0412e05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175467
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-24  Justin Luth  <justin.luth@collabora.com>  [9254ed4a8b279152f84a02fccc670d7a845cdc66]

        diff-pdf-page.py: change assumed background to transparent
        
        The page background color of a document likely is white,
        so at least the overlay (the second PNG) must be transparent.
        
        [I saw (in Draw) that PRINT-TO-PDF tended to produce a PDF
        that would have a transparent background when converted to PNG,
        but that EXPORT-TO-PDF from LO would produce a white background
        that obviously would fully overlay and obscure the first image.]
        
        (Calc and Writer's export-to-pdf produced a transparent background.)
        
        In any case, it makes sense to try to force both of these
        to have a transparent background.
        
        NOTE: It was important to place -transparent before -fuzz,
        or else 95% of all colors will be considered white
        and turned into transparent.
        
        Change-Id: I26e6081fcd59e82b2aaedb86370bdbcc57b0a24e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175466
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-24  Justin Luth  <justin.luth@collabora.com>  [a50f65d6cc42c5815574a361525ad6dfa83fd5b5]

        diff-pdf-page.py: allow use of "magick" (on Windows)
        
        The ImageMagick package on Windows does not use convert,
        but uses magick (which is not used by Linux).
        
        So use a variable to make is simpler
        to make it usable under Windows.
        
        Note that cygwin's ImageMagick package does use "convert",
        overriding Windows built in disk convert tool.
        
        Change-Id: I658e0eb11400cf9e6c65ab4ba150ed2ab239c94e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175455
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-24  Justin Luth  <justin.luth@collabora.com>  [4a9a6c6786e141fb79d283b57e0cebb5de031139]

        diff-pdf-page.py: use magick order for -composite
        
        Apparently, "convert" allows a unix ordering
        which doesn't work when using the "magick" alternative under Windows.
        
        The point here is that -composite is an action
        for the third image argument,
        so it needs to come after the reading in of the source image-sequence.
        
        Change-Id: Ic9345d616c6c62c211c5b7eb359c4019501bef2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175454
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-24  Pierre F  <fpy@bger.ch>  [7c2bc3abfa63cd6dce4ec07e910c0f7a787ad98c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e60bf0a677ddf64ba4d5bda78399f9991c5a665e
          - tdf#143846 split CHAR + CLEAN. + helper
            
            to extract xhp files, run :
               perl helpers/calc_text_func.pl CHAR CLEAN
            ouput :
            TODO. add to git and  AllLangHelp_scalc.mk :
                helpcontent2/source/text/scalc/01/func_char \
                helpcontent2/source/text/scalc/01/func_clean \
            
            
            Change-Id: I986cb038748586c12bd09441070cf272de2d4106
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174677
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-24  Eike Rathke  <erack@redhat.com>  [472f17d203207f1ef9d75ecfc9facda2d5f43384]

        Resolves: tdf#163554 Read/write Excel 3D reference as 'Sheet1:Sheet2'!C4
        
        ... if at least one of the sheet names has to be quoted, instead
        of 'Sheet1':'Sheet2'!C4:C4 where 'Sheet1':'Sheet2' is more logical
        but not understood neither by Excel nor was it by Calc. A single
        C4 instead of C4:C4 is more cosmetical.
        
        Accept both forms now when reading OOXML documents to be able to
        read back such broken expressions.
        
        Change-Id: I228e458e2e3af387d9f89900fcfc16ab89757bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175514
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-10-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5c95a2a1a86d2eabdc5a0cc23e836283d14bcccf]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 2242, 2272
        
        Change-Id: Idcddf2a4d7522a368960e76256e28f1f0d36c9b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175394
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [148fa9e9405b143f9fc228d9b5f967cad3139967]

        tdf#157130 undo and track changes not restoring characters (macOS)
        
        Not sure about the real underlying issue here.
        
        In debug mode, we hit this assert. Changing it from an assert to a "do decrement mnEmptyMark if it would become negative" seems to help.
        
        Change-Id: Ie23a685552d2f8153b67e18f9c0203ecbaad0ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [caf1bc0c4c559999d44b83ff8ace43b5e7fcf3f1]

        assert on invalid param in OPropertyContainerHelper::getFastPropertyValue
        
        which flushes out a bug in OPropertySetHelper::getPropertyValueImp
        
        Change-Id: I5d3928e55eb9f019629896ad6478011520318fd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-24  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [19753c7176124d6c71840c774728094fd253d19e]

        slideshow: improve grammar for repeat slideshow in sidebar
        
        Change-Id: Ibe3ca1c11a9dcbb82cadc0ab531e9a69fe275769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175535
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-24  Heiko Tietze  <tietze.heiko@gmail.com>  [6cc1102abef4fa03d95923051f71b65da9b415f3]

        Resolves tdf148513 - Illustration for line break options
        
        Change-Id: I729c4a1e5c4b2a73cdb8d3a5c4969e3b43510deb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174038
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-10-24  Gülşah Köse  <gulsah.kose@collabora.com>  [daf2e27b96276dd51685f6510910c7f3fee0d496]

        Reapply "Prevent cursor invalidation if the cursor position doesn't change."
        
        This reverts commit 8da753752898984425c98a7f3db02b1aa69b74c8.
        Merge cells case were failing. Fixed now.
        
        Change-Id: I1dfd7e939c5590d64d096707edff40cb414ef3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174813
        (cherry picked from commit a260cc52b2fae1382805b4389c95f29ed8671f42)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175302
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [ac3b954ad37d679ead4420bc4826af766b72a841]

        tdf#130857 qt weld: Handle entry for editable comboboxes
        
        An editable GtkComboBox has a "has-entry" property of "true"
        and an internal GtkEntry child.
        
        Make the QComboBox editable depending on that "has-entry" property.
        Mark the QLineEdit object created for the "GtkEntry" for deletion
        again, as the QComboBox already has a QLineEdit by itself if it's
        editable, and the one created for the internal child would otherwise
        be useless and oddly overlap the combobox.
        
        (Seen e.g. with the "Tools" -> "Options" -> "Languages and Locales"
        -> "Writing Aids" -> "New" dialog" in a WIP branch where that dialog's
        .ui file ("cui/ui/optnewdictionarydialog.ui") was added to the list of
        supported files for QtInstanceBuilder. More work is needed
        on other aspects still.)
        
        Change-Id: I25ea74c732e60f50035604a4fc75dad50f4cf55f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175531
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [6565ce09647e5f7cb509776c3cd9615c062f821f]

        tdf#130857 VclBuilder: Make extractEntry a static helper
        
        ... in the base class BuilderBase, in order to reuse it in
        QtBuilder in an upcoming commit.
        
        Change-Id: Ia115804a9d2bf22b47afb94d97109e9495b21cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175530
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [ff1543fcd2db91e10f3aa6c42ceb3251d8fa092b]

        tdf#130857 qt weld: Implement QtInstanceComboBox::insert_vector
        
        Change-Id: I71b1e8c596ca1f6790e93bdd7d73a9e5c583c278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175529
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [6cc411801138f93b5b25b0822b1fdd723dc75869]

        tdf#130857 qt weld: Implement QtInstanceComboBox::insert_separator
        
        As can be seen in the
        SalInstanceComboBoxWithoutEdit::insert_separator
        implementation, -1 for the index means "Insert at the end",
        so do likewise.
        And also ignore the ID parameter, as QComboBox::insertSeparator
        (other than (QComboBox::insertItem) doesn't take a QVariant
        for user data.
        
        Change-Id: I98959abf61ec670d78bf341a726b9854127d95e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175528
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [787c305271b7abaa1bc43241f4c0ab3bb280d94a]

        tdf#130857 qt weld: Implement ID handling for combobox entries
        
        Implement methods related to IDs for combobox entries by
        handling OUString ID as a QString variant for the user data
        of the combobox item.
        
        Change-Id: I57750df203c333aa9dcc99c960c64de5f4ff50d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175527
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [8eacf7e372452277f7899f4bf6653adda6215415]

        qt: Have just a single toQString(const OUString&)
        
        Move the `toQString` helper function to
        include/vcl/qt/QtUtils.hxx where it can be used from
        multiple modules, instead of defining
        it twice for both, avmedia (avmedia/source/qt6/QtPlayer.cxx)
        and vcl (vcl/inc/qt5/QtTools.hxx).
        
        Change-Id: I7ffe06eaa3aaf3e7c8cc7aa1a4ac41b14db5c20c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175526
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [e1fa5664c99150a7ca59cf18e839b94871744b71]

        tdf#130857 qt weld: Implement QtInstanceButton::set_from_icon_name
        
        Make use of the `loadQPixmapIcon` helper function introduced
        in previous commit
        
            Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 23 23:21:23 2024 +0200
        
                tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxx
        
        With this commit, the native Qt version of Calc's
        "Tool" -> "Goal Seek" dialog looks OK at first glance
        (buttons have the icons set) in a WIP branch that adds that
        dialog's .ui file ("modules/scalc/ui/goalseekdlg.ui") to the
        list of supported files in QtInstanceBuilder::IsUIFileSupported.
        
        (But clicking a button doesn't yet behave the same
        way as in the non-welded/VCL version, so more work is needed
        before that can actually be enabled.)
        
        Change-Id: Icc83e874a76b7ccd600bd6741a9e02958759f4d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175525
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [2386540edfb015632ad5771ed048aa4bead315f8]

        tdf#130857 qt: Move pixmap helper to new include/vcl/qt/QtUtils.hxx
        
        Introduce include/vcl/qt/QtUtils.hxx as a new header
        for Qt-specific utility functions that can be used
        in multiple modules, e.g. avmedia and the Qt VCL
        plugins in vcl.
        
        This is meant to be used only by code that already
        links in Qt.
        
        There's already vcl/inc/qt{5,6}/QtTools.hxx for
        helpers needed in vcl only.
        
        Initially, add a `loadQPixmapIcon` helper function
        that can be used to retrieve a QPixmap for an icon name
        and is extracted from QtPlayer::createMediaPlayerWidget
        in avmedia.
        
        It will be reused to implement the
        QtInstanceButton::set_from_icon_name logic in an upcoming
        commit.
        
        Change-Id: I9f25aa5ca8f00da97d06ecdd164a8fae10e492dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175524
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [0fe7b3cebc1a070b13b825635f4bd387a22e41ab]

        tdf#130857 printersetupdialog.ui: Define focusable widgets in order
        
        Align the order in which the focusable widgets (combobox, "Properties"
        button) are defined in the .ui (XML) file with the order in which they
        should receive focus. While the position in the GtkGrid is defined
        by the "left-attach" and "top-attach" packing properties and
        QtBuilder evaluates those, the tab order in Qt by default matches
        the order in which widgets are created (s. e.g. [1]).
        
        Without this commit in place the "properties" button was constructed
        before the "name" combobox (because it was further up in
        the .ui file, i.e. the XML parser processed it earlier), resulting
        in an unexpected order when using the Tab key to navigate through
        the "Tools" -> "Printer Settings" dialog:
        
        From the "Options" button in the button box, focus would jump
        to the "Properties" button, and only then to the combobox, and
        from there, it would jump to the "Help" button in the button box.
        
        Now, it jumps from the "Options" button to the combobox,
        and after selecting the printer there, pressing Tab another
        time moves focus to the "Properties" button as expected, which
        can be used to open another dialog that allows to change properties
        of the previously selected printer.
        
        A potential alternative to adjusting the .ui file could be to
        explicitly set the tab order using QWidget::setTabOrder [2]
        in QtBuilder.
        
        [1] https://doc.qt.io/qt-6/designer-tab-order.html
        [2] https://doc.qt.io/qt-6/qwidget.html#setTabOrder
        
        Change-Id: If3aa014e20b97fe8bb772ef212741af1433b0244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175523
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [f1247eba6485a080df3486021b53072018113015]

        tdf#130857 qt weld: Declare support for "Printer Settings" dialog
        
        Add .ui file of the "File" -> "Printer Settings..." dialog
        available e.g. in Writer to list of files supported by
        QtInstanceBuilder, so that native Qt widgets are
        used for that dialog now when using the qt5/qt6 VCL plugins,
        unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175522
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [8c8a48eb06c692ded03e29c1ab493935e2a12228]

        tdf#130857 qt weld: Signal when current combobox item changes
        
        Connect to the QComboBox::currentIndexChanged signal and
        call `weld::ComboBox::signal_changed` to notify of that change.
        
        This is in preparation for upcoming
        
            Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a
            Author: Michael Weghorn <m.weghorn@posteo.de>
        
                tdf#130857 qt weld: Declare support for "Printer Settings" dialog
        
        and causes the infos for the printer previously selected
        in the combobox in the "File" -> "Printer Settings" dialog
        to be shown after selecting a printer other than the initially
        selected one in the combobox, then clicking the "Properties"
        button in that dialog.
        (Without this, properties of the initially selected printer would
        always be shown.)
        
        Change-Id: I9a8609e172fd1d6783a86395ff58e64b7cf5c4d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175521
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [c8ff967c4996318d25bcc0642b14cbc5e6d981bb]

        tdf#130857 qt weld: Implement combobox entry sorting
        
        Implement sorting for combobox entries by adding
        a QtInstanceComboBox::m_bSorted member that gets
        set to true when QtInstanceComboBox::make_sorted
        gets called, and sort entries then and whenever
        a new entry gets inserted afterwards.
        
        This is in preparation for upcoming
        
            Change-Id: I7806688102f690faa02fb5e712943d6ae216ff9a
            Author: Michael Weghorn <m.weghorn@posteo.de>
        
                tdf#130857 qt weld: Declare support for "Printer Settings" dialog
        
        Change-Id: I54140db4310c7b288fe3be0e73000860410068fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175520
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [f0a90a0d3f9c0a200603ee69a42fddf461068a22]

        tdf#130857 qt weld: Fix condition for not implemented combobox case
        
        The case where `pImageSurface` is non-null needs special
        handling, and that isn't implemented yet.
        
        (The assert would be triggered for the "File" -> "Printer Settings"
        dialog otherwise once declared as supported in an upcoming
        commit.)
        
        Change-Id: I1a7d352e24de13417aac28d1d4b514709a8e97d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175519
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [bf4d51b46c54a72038fbf46e9a5b025415acdde3]

        framework: Deduplicate code setting menu accelerator keys
        
        Introduce new helper method MenuBarManager::SetAcceleratorKeys
        and call that from both places that are setting accelerator
        keys, to deduplicate code and simplify future maintenance.
        
        The use in MenuBarManager::FillMenuManager was introduced in
        
            commit 08fe2669a0ed807812d005195b54cc41f092d09a
            Author: Rüdiger Timm <rt@openoffice.org>
            Date:   Fri May 13 06:29:54 2005 +0000
        
                INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED
                2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD)
        
        and looks like it was primarily copy-pasted from the
        other place.
        
        Change-Id: I2097619740d45260e534ce06f9941337177f1bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175509
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [4b19e22d713d13f768d5bfd67da49844e62e0bb9]

        framework: Move var declaration close to use, drop another one
        
        Move variable/code from the beginning of
        MenuBarManager::Activate to where they're actually used,
        to increase readability.
        
        Change-Id: I885c6039fd77a023204b60bfc8ef97089d98716a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175508
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [ca2900e6ed3de60ed143e6189a301132047b5b59]

        framework: Drop extra scope for setting accelerator keys
        
        This is in preparation of deduplicating code in an upcoming
        commit.
        
        (Use `git show --ignore-space-change` to see the "actual
        change" more clearly.)
        
        Change-Id: Ibc9b8d8f77c2b2182c359a287eb604a92ed9c4e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175507
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [59b7de0e8ffc3a4cfe5ac6873778fb2e8bafa74d]

        sw a11y: Don't prevent zooming into print preview when AT active
        
        In Writer's print preview ("File" -> "Print Preview"),
        allow zooming in or out using Ctrl + mouse wheel
        regardless of whether assistive technology is enabled
        (on Windows) or not.
        
        I see no reason to prevent this when AT is active.
        
        This was originally introduced in
        
            commit 70de0c38fd177b3c95837118c5fb35e380c87e90
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Thu Mar 27 14:45:43 2003 +0000
        
                MWS_SRX644: migrate branch mws_srx644 -> HEAD
        
        with a
        
            //#106746# zoom has to be disabled if Accessibility support is switched on
        
        comment, but that unfortunately only refers to a ticket
        in the StarDivision internal issue tracker, so the
        reasoning from back then remains unclear.
        
        (`git show --ignore-space-change` to see the "actual
        change" more clearly)
        
        Change-Id: Iccec17a334dbe19de14cf7889d7f70f0051f152e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175502
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [77e1c0bfa2e643f017b829cd775d08c5a40d9b6b]

        win a11y: No longer read/write registry key
        
        No longer attempt to write a registry
        "SupportAssistiveTechnology" in
        "HKEY_CURRENT_USER\Software\LibreOffice\Accessibility\AtToolSupport"
        when assistive technology support gets enabled (e.g. because a
        screen reader is running) and no longer try to read that registry
        key to determine whether or not AT tool support is requested.
        
        While the comment
        
            // Check in the Windows registry if an AT tool wants Accessibility support to
            // be activated ..
        
        seems to suggest that this is something requested by an assistive
        technology, it looks more like a way to persist whether the a11y
        bridge was ever used in LO, as LO itself writes that value.
        
        I don't really see the point, but think it makes much more
        sense to enable the a11y bridge if an AT is active
        *at the moment*.
        
        In addition, in my Windows 10 setup with LO 24.8 installed, there's no
        "HKEY_CURRENT_USER\Software\LibreOffice" in the registry, only a
        "HKEY_CURRENT_USER\Software\The Document Foundation\LibreOffice 24.8",
        so the code wouldn't have any effect in practice anyway.
        
        Maybe this was necessary at some point in the past
        when the Java Access Bridge was still in place, instead
        of supporting the platform API via today's MSAA/IAccessible2
        bridge
        
        Note that before
        
            commit bfbaeb8192447265bdd78d1be4990947d135eb6e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 18 17:01:43 2024 +0100
        
                tdf#160982 wina11y: Drop extra screen reader check to enable a11y bridge
        
        , the presence or absence of the SPI_GETSCREENREADER param
        or a SAL_FORCE_IACCESSIBLE2 environment variable would
        additionally have played a role.
        
        Change-Id: I4dddb599eedb4b29c9709fbb41093ef615e60b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175501
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [fe9ebbefb5f94d7d002b84c8732c1812d029775f]

        win: Drop local var assigned to but never read
        
        Change-Id: I302e014134d5f91a4d454d3b137743af3c455997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175473
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf16bbd105d1b78d3d3611e21d44b412efb50f09]

        Fix typo
        
        Change-Id: Ib40f9fa2d618cf4400a814d1d6e222768bf7bba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175505
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [624f01b02569f0a514b357a4d591b8526c3f73f2]

        tdf#163580 Open online Help, if warn option is not checked
        
        Change-Id: I438032955f399a8b4737d100bee8a3db54427525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175468
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-10-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e3583eff43d3aa54fc7e2c2ba890a0835d47e9d3]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 277, 297
        
        Change-Id: Ie30c5da744cb29de5db4a2b1e0f4096daf8b6bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175425
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-23  Regina Henschel  <rb.henschel@t-online.de>  [a3c40e732658d137352577e7e9378cdce0baba9b]

        tdf#157222 swap info texts of connector end point
        
        Change-Id: I3d1d1ed27afbdf7700882a12bcd25643e37c3564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175513
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-10-23  Julien Nabet  <serval2412@yahoo.fr>  [dedc053252160d78043a51096438938b275088bd]

        Following 250e00a51dcf60ac2e028983f5d29c0f68748b38 (JDBC4.3)
        
        Change-Id: I08b71b9c0504af7ed4af84456ce49dc2fe7274af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175472
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e28f5a9f662f3995db06743ed043cbd094b1a68]

        tdf#163486: PVS: check mpViewSh
        
        V595 	The 'mpView' pointer was utilized before it was verified against nullptr. Check lines: 719, 720.
        
        Change-Id: Ie1bda82df979fd5f293fb6eb9623917371e9da34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175113
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [87995efe7c1d49d87c12ced97033fa3f38bc76e4]

        unoxml: port testXText from java to c++
        
        Change-Id: I548bfde6a78832dbb53f3b154ae79223fdc69454
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175510
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [c69ce3a0c32374c2f328583be2c81674a208256a]

        tdf#163486: PVS: check pTabWinTmp
        
        V595 	The 'pTabWinTmp' pointer was utilized before it was verified against nullptr. Check lines: 496, 499.
        
        Change-Id: Ie263524d6a06adaf7f99555d7aa872e815cab96c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175504
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f04ab0ea41db4e91c3dd898a560426867a466988]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'eFunc == KeyFuncType::DONTKNOW' is always true.
        
        Change-Id: Ia88333958bfc80555ecabd7113ef6a1805714c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175506
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Michael Weghorn  <m.weghorn@posteo.de>  [4bdcb6169130a7cf40a1324527b41b643c811a78]

        tdf#130857 qt weld: Add initial combobox handling
        
        * Add new class QtInstanceComboBox as a weld::ComboBox
          implementation using a native QComboBox. Implement
          some of the most important and straightforward methods
          and trigger an assert for all others for now.
        
        * In QtBuilder::makeObject, handle the "GtkComboBoxText"
          case and create a QComboBox for that.
        
        * Implement QtInstanceBuilder::weld_combo_box
          to return a QtInstanceComboBox instance.
        
        Change-Id: I2ac2d0f55a948ea2f090c81096484e22899ddcbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175443
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-23  László Németh  <nemeth@numbertext.org>  [d87cf67f8f3346a1e380383917a3a4552fd9248e]

        tdf#131728 sw inline heading: fix missing/broken DOCX export
        
        Fix layout interoperability during DOCX round-trip by grab-
        bagging w:p/w:pPr/w:rPr/w:specVanish, i.e. the style separators.
        
        Note: use FrameInteropGrabBag to select the text frames, which
        are inline headings, exporting only their text content (a single
        paragraph), and use also ParaInteropGrabBag to export w:specVanish.
        
        Note: specVanish lost completely originally, converting inline
        headings to normal paragraphs.
        After commit 56588663a0fddc005c12afaa7d3f8874d036875f,
        text frames (the workaround for inline heading/ToC/bookmark
        support) were exported instead of plain paragraphs, which were
        broken at least in LibreOffice.
        
        Follow-up to commit 56588663a0fddc005c12afaa7d3f8874d036875f
        "tdf#131728 sw inline heading: fix DOCX paragraph layout
        interoperability".
        
        Change-Id: Ic61617f9c9652c9364f8262914c66dec093d6910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175372
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [448954835f5d55b62378f5d116984c24e68082d8]

        add Tagalog (tl) langauge- & helppack
        
        Change-Id: I9fdb30215f6b64ae025a7e8e468e84426044ff80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175503
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [b20877920ef11ff6682e4884da52892c6a31d7ff]

        tdf#163486: PVS: check stream read instead of EOF
        
        V1024 	The 'aIfstream' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data.
        
        Change-Id: I253513c47ec1482882bbfb1c6e32e25c15ace99c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175475
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [79e77a81fd3302321698ff1ecd92bc67a90e3382]

        tdf#163486: PVS: enum type as bool
        
        V768 	The variable 'eS' is of enum type. It is odd that it is used as a variable of a Boolean-type.
        
        Change-Id: I959f58e80cd0a2d82e6c9fffe140a442cf4dbb0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175477
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [ceec6eacfc69e71d85b360da6e25edbd9676628a]

        Try to apply indents a bit saner
        
        It was too convoluted; the three properties that were set there
        all used different logic (PROP_PARA_FIRST_LINE_INDENT was only
        set when the parent style id was present; PROP_PARA_LEFT_MARGIN
        was set when it was found either in the entry or in its parent;
        PROP_PARA_RIGHT_MARGIN was only set when parent style was found,
        and it had properties). It seems to be just some leftovers from
        iterative partial changes of the code.
        
        This makes the code more uniform. For PROP_PARA_RIGHT_MARGIN it
        keeps setting PROP_PARA_FIRST_LINE_INDENT/PROP_PARA_LEFT_MARGIN
        from getNumberingProperty; but otherwise, all three are handled
        similarly: if the property is set either in the entry itself or
        in its parent, it is processed. This changes the logic slightly,
        but hopefully in the correct direction.
        
        Change-Id: I1a8fb95d055101dcbc3aaec6207721146c94cc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175437
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f57203e5eba95a1f10e3a4f92c4c3f42e1360536]

        Deduplicate a bit
        
        Change-Id: Iace3fdfdaed79054fda2894b5d9f4275f80a5e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175440
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [dfaee8d8f43f8725a0e999279f99e552eeb0bee2]

        tdf#163486: PVS: enum type as bool
        
        V768 	The variable 'eType' is of enum type. It is odd that it is used as a variable of a Boolean-type.
        
        Change-Id: I38f0302d8edcaef144f6071dc86500937d305591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175478
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [95feb2877e5dbe9549b9aabe049c1c7a81e4dc23]

        tdf#163486: PVS: check stream read instead of EOF
        
        V1024 	The 'aInput' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data.
        
        Change-Id: Ie0c6d1928dad804b21d3c9920cc1de8035ea0367
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175476
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Sakura286  <sakura286@outlook.com>  [6a7dd6fcd95cb6086e447d1897bed750bceee8c2]

        tdf#152943: Add NaN payload check at the start of sc_ucalc test sequence
        
          Some archs does not support NaN payload(e.g. riscv64).
          It would be meaningless to continue building a test related
          to NaN payload if the builder doesn't support this feature.
        
        Change-Id: I895a8647bf7ff68f645faa7428d30b1c741669f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175293
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-10-23  Usman Akinyemi  <usmanakinyemi202@gmail.com>  [ad6f39b19c8853c1e8f71a32f88d4656029e4005]

        tdf#90341 Clean up excessive const_cast'ing
        
        These changes improve const-correctness and reduce the need for const_cast
        usage.
        
        Change-Id: I1275edfbc0ca5d49a5e8339d1ed11148f6decd1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174701
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [44ace0cbcaa1520d8d4654202850fb089318f840]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7ee58e4082404ba303bae416befc5022de55fce4
          - add Tagalog (tl) translations
            
            Change-Id: Ifa0fcaea9ea720297ba6957c3dacce8513344266
            
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ibbe54e16a51701c8559fbfa2b7619640e517c0e1
            
2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f9263bbf3c06dbaec7577f2c7e2622f149073e7a]

        tdf#163486: PVS: missing while loop iterator
        
        Since
        commit c5db3b93ee1058bd20ebcde2e757b52b9a67b74a
        Author: Michael Stahl <mst@openoffice.org>
        Date:   Thu Feb 10 16:45:02 2011 +0100
        
            xmlfix3: unoxml: prevent invalid child-parent relationships:
        
        V1044 	Loop break conditions do not depend on the number of iterations.
        
        Change-Id: I611911bdcdb812ed46a529a217ab6612a254f441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175174
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1ced61833d62905908e3ab250986356e68b0453]

        xmlsec: upgrade to 1.3.6
        
        Downloaded from https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.6.tar.gz
        
        Change-Id: I29714d220a07b600ea74e89ad62be8b50249c158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175471
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [a3680f886569cb37876756da42c9dcef9d26cc51]

        Simplify a bit
        
        Change-Id: I7d24774fb591fe2090523da29a2a0aa7608deccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175435
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b0195d40f3abc343b88f767f4fe109a9c1d44347]

        Avoid signed integer overflow
        
        ...as seen at
        
        > /tools/source/misc/fix16.cxx:79:53: runtime error: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int'
        >     #0 0x7fc2f9f50a60 in mask(int) /tools/source/misc/fix16.cxx:79:53
        >     #1 0x7fc2f9f505fd in fix16_div(int, int) /tools/source/misc/fix16.cxx:122:34
        >     #2 0x7fc2f00d12e0 in vcl::fixedDiv(int, int) /vcl/source/fontsubset/sft.cxx:127:12
        >     #3 0x7fc2f00d11c1 in vcl::fixedMulDiv(int, int, int) /vcl/source/fontsubset/sft.cxx:135:12
        >     #4 0x7fc2f00d0851 in vcl::GetCompoundTTOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >&) /vcl/source/fontsubset/sft.cxx:544:91
        >     #5 0x7fc2f00af5f1 in vcl::GetTTGlyphOutline(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&, vcl::(anonymous namespace)::TTGlyphMetrics*, std::__debug::vector<unsigned int, std::allocator<unsigned int> >*) /vcl/source/fontsubset/sft.cxx:621:15
        >     #6 0x7fc2f00aea34 in vcl::GetTTGlyphPoints(vcl::AbstractTrueTypeFont*, unsigned int, std::__debug::vector<vcl::ControlPoint, std::allocator<vcl::ControlPoint> >&) /vcl/source/fontsubset/sft.cxx:1239:12
        >     #7 0x7fc2f00b92de in vcl::GetTTRawGlyphData(vcl::AbstractTrueTypeFont*, unsigned int) /vcl/source/fontsubset/sft.cxx:1667:9
        >     #8 0x7fc2f00b23ed in vcl::CreateTTFromTTGlyphs(vcl::AbstractTrueTypeFont*, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned short const*, unsigned char const*, int) /vcl/source/fontsubset/sft.cxx:1374:32
        >     #9 0x7fc2f00bc71a in vcl::CreateTTFfontSubset(vcl::AbstractTrueTypeFont&, std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) /vcl/source/fontsubset/sft.cxx:1549:13
        >     #10 0x7fc2eff57836 in vcl::font::PhysicalFontFace::CreateFontSubset(std::__debug::vector<unsigned char, std::allocator<unsigned char> >&, unsigned int const*, unsigned char const*, int, FontSubsetInfo&) const /vcl/source/font/PhysicalFontFace.cxx:367:12
        >     #11 0x7fc2ee4e0472 in vcl::PDFWriterImpl::emitFonts() /vcl/source/gdi/pdfwriter_impl.cxx:3152:24
        >     #12 0x7fc2ee4e9cb9 in vcl::PDFWriterImpl::emitResources() /vcl/source/gdi/pdfwriter_impl.cxx:3363:10
        >     #13 0x7fc2ee53f91d in vcl::PDFWriterImpl::emitCatalog() /vcl/source/gdi/pdfwriter_impl.cxx:5288:10
        >     #14 0x7fc2ee567ae3 in vcl::PDFWriterImpl::emit() /vcl/source/gdi/pdfwriter_impl.cxx:6341:10
        >     #15 0x7fc2ee3d3f2a in vcl::PDFWriter::Emit() /vcl/source/gdi/pdfwriter.cxx:53:29
        >     #16 0x7fc249b4b82a in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdfexport.cxx:1127:39
        >     #17 0x7fc249bb2782 in PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:182:24
        >     #18 0x7fc249bb342b in PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /filter/source/pdf/pdffilter.cxx:247:23
        >     #19 0x7fc2a51ebec6 in SfxObjectShell::ExportTo(SfxMedium&) /sfx2/source/doc/objstor.cxx:2945:25
        >     #20 0x7fc2a51d7bec in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1943:19
        >     #21 0x7fc2a5213f83 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3459:39
        >     #22 0x7fc2a520b709 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:3249:9
        >     #23 0x7fc2a5147a8b in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objserv.cxx:320:19
        >     #24 0x7fc2a543024c in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3231:42
        >     #25 0x7fc2a54374f4 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1813:13
        >     #26 0x7fc2c74053ae in ScPDFExportTest::exportToPDF(com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, ScRange const&) /sc/qa/extras/scpdfexport.cxx:179:16
        >     #27 0x7fc2c7437e0f in ScPDFExportTest::testForcepoint97() /sc/qa/extras/scpdfexport.cxx:915:5
        
        during CppunitTest_sc_pdf_export
        (<https://ci.libreoffice.org/job/lo_ubsan/3346/>)
        
        Change-Id: I3074479ea3267417a73ecafa81b4a9898f19d1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175469
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0a347396d35876564031df7cf7ac3ee149e76fb7]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 152, 194
        V1037 Two or more case-branches perform the same actions. Check lines: 565, 592
        
        Change-Id: I52ec0921c898ca74473631ba36a76f6444ce07d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175358
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d3dd616f563e2cb32fa1e9ba983509096548e95f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 289, 293
        
        Change-Id: I9828b4d5b7faca449c5377a0bd8223cddf883a43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175423
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b4aea0f911764da759b3c2df0fd7803fec42547]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'pRedirectURL' is always true.
        
        Change-Id: I6cd071905a6e93782c1a6f5e6e4ddeaef0658feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175460
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [416f672b9da831b450da6be6f44ad0acff707bbe]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pRun != pEnd.
        V560 	A part of conditional expression is always true: pRun != pEnd.
        
        Change-Id: I1a99ae31346177bed731e26e883720efa018bcbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175451
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [9fb20b53416fdaabf50861941aed7f9b9e510478]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pRotate.
        V560 	A part of conditional expression is always true: pRotate.
        
        Change-Id: Icf39c1a7e3a31fb360dde684a5ebfbc176027f6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175450
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee21d9956b10593b5ec813308f61b190b1788ca0]

        tdf#163486: PVS: Expression is always false
        
        V547 	Expression 'pDocShell == nullptr' is always false.
        
        Change-Id: I0f79864cb5fbfe209cb0c2441665027355aced3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175463
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [22fd6966fe84af99a2c047260a4dcd8687da40a7]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'pChartWindow' is always true.
        
        Change-Id: I079b0aef18e4619f84e96dc07573884a9887faaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175464
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [a8f7368b76185b656b96755dde622715d08bb07b]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'pChartWindow' is always true.
        V547 	Expression 'pChartWindow' is always true.
        
        Change-Id: I3edefe4392386397e5666420b31cc40096c6f3cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175465
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [fb8644e8e102c9e34925b85d14a9100d33537f1e]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pDoc.
        
        Change-Id: Ie3947a3360d65a97a6a70c584c3e3f32485b4b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175458
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Noel Grandin  <noelgrandin@gmail.com>  [100e0a0163482645b50da21320bb67aeb2dc21fa]

        tdf#161359 fix opening RTF with broken images
        
        The try/catch block prevents an exception that looks like
           com.sun.star.lang.IllegalArgumentException message:
           "at /Users/noelgrandin/lode/dev/core/svx/source/unodraw/unoshap2.cxx:1423"
        which is inside
           SvxGraphicObject::setPropertyValueImpl
        
        Not sure where would be a better place to handle this.
        
        regression from
            commit 060b0fb4b93ee09770ed9398cca46e365dda5be8
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Thu Mar 8 16:37:46 2018 +0900
            change RTFDocumentImpl to use Graphic instead of GraphicURL
        
        Change-Id: Iec3df20a2192df2bf595293037c8214fea151ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [28d7ea2509eaabf17b78ebf156833d7a967814a9]

        tdf#163486: PVS: Expression is always true
        
        Expression 'pChangesSet' is always true.
        
        Change-Id: Ib1f654b0b30d0e8e73121a7448a392a134be888f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175459
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [adb561759ceb87b8bc0274a50b2ef546d137eae6]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'pFollowTextFlow' is always true.
        
        Change-Id: I07696ef443e7eaa263d325eed225dfb5c0b89c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175461
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6fc9dd338751f8d14ce66024238976fa7259fcc]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pItem.
        
        Change-Id: I4ae18820dc7ec3232bccb099e56dd0da2b4f59eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175456
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [156506630f8b03c3435d31448eb8bc9613a1d6b8]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pDrawLayer.
        
        Change-Id: Ibcb87390a41d835233625b7bea1e5e040ebe3b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175457
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [e0394fe4c0fe0900b502d5db266991464697cfd3]

        tdf#163486: PVS: Expression is always true
        
        V547 	Expression 'pWin' is always true.
        
        Change-Id: Ib7f302c06f1bbfded89d97767197447788ffdd71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175462
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [32e3427cd0da18eab825d3015a60d4329b47bd59]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pFlt.
        
        Change-Id: Ia05e42b8700ceb3dc1ab23becf71fd281695924e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175449
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f431b0c5cfa7801efd4e5aa12d0877d01a28403e]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pSection.
        
        Change-Id: If097740c8ea3b89da42c07c4e419fee731948fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175453
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [c025cb6d125d8187453e06055dcf3e65d83d532c]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pFlt.
        
        Change-Id: I208c6f64fe49dec422173b9465b18182c1aac318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175452
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-23  Oromidayo Owolabi  <owolabioromidayo16@gmail.com>  [80e8375828ac09fdb5a127b7690848075e37aa9c]

        tdf#143148 Use #pragma once instead of include guards
        
        Replace include guards to pragma once in some header files in sw/inc/
        
        Change-Id: I8e790a89ab2326748590d7a1ff2d1daee0ae0f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175191
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-23  Julien Nabet  <serval2412@yahoo.fr>  [250e00a51dcf60ac2e028983f5d29c0f68748b38]

        Declare missing methods and constants to synchronize with JDBC 4.3
        
        OpenJDK source has been used for the comments
        
        Change-Id: Ic443ef1f50894eccd5233f2c629e227b8816a8fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173568
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-23  Noel Grandin  <noelgrandin@collabora.co.uk>  [d2c4108dcaf321d378ead479a181eda79a5200b5]

        tdf#144702 Base Fields in Report Label Display Clipped
        
        This is probably not an ideal fix, I'm not sure where exactly the
        positioning is off, but this does the job for now.
        
        regression from
            commit 95ccc26ba71259be29fde8ba6b6f52ffbe5bd3c7
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Fri May 22 18:07:45 2015 +0900
        
        Change-Id: I2f02e68418b7adf2cba8dfa4e4e51d4416a91389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-23  Noel Grandin  <noelgrandin@gmail.com>  [f7e405cfa797bba4f0c0b62e3d3739bb62071aba]

        tdf#162245 Insert->Comment in Draw/Impress not incrementally numbered
        
        fix numbering.
        
        regression from
            commit e17c56bfc7930d3c14c3ff4cfd59828e8dcc0229
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Thu Jun 6 10:52:35 2024 +0900
            annot: new Annotation sdr object, replacing annotation tags
        
        Change-Id: I7f649346422886ab2e27a06b03b359ab395ec4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175411
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ffb4c73916321b12e7049e8f54b46ebc40a5266]

        libvisio: upgrade to 0.1.8
        
        Generated with:
        ./autogen.sh
        ./configure
        make dist-xz
        
        Change-Id: I6ff112ab2669d8ca7903f685486b5cd0f0348fd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175442
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2024-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [95e7d7c2715b061409c84e1b7d2e1b750c47f8c7]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pStyleSheetProperties.
        
        Change-Id: Ia6f0ecbf80d8de488695441c86b0b34e23c6348a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175444
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-22  László Németh  <nemeth@numbertext.org>  [270c96e12c4a14c4f9e130d15310843da3a6af68]

        tdf#163575 sw smart justify: fix size resolution for SwBidiPortion
        
        Negative space sizes (i.e. shrunk lines at image wrapping) stored
        over LONG_MAX/2, and these values had no resolution in SwBidiPortion,
        causing crash/assert in conversion of DOCX document containing e.g.
        Arabic text wrapping around images.
        
        Note: apply the resolution in SwDoubleLinePortion, too.
        
        Regression since commit 1fb6de02709a5f420f21ebd683915da50ce0d198
        "tdf#163149 sw smart justify: fix line shrinking at image wrapping".
        
        Change-Id: I6e45592c4eed247871d35e1f02fd5a038baddf85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175419
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a07b4b432f47902290ff698ec48c79c63d3419ad]

        tdf#163486: PVS: Expression is always true
        
        V560 	A part of conditional expression is always true: pNumFormat.
        V560 	A part of conditional expression is always true: pNumFormat != nullptr.
        
        Change-Id: I6c780fa67bd65da06cfdde37d34eda93bb4ab13c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175445
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a9b36e7af40b20ed75c9ff93e2f108a2d49265da]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 341, 345, 348
        V1037 Two or more case-branches perform the same actions. Check lines: 481, 487
        V1037 Two or more case-branches perform the same actions. Check lines: 689, 700
        
        Change-Id: Ib9f4b8047f7706667f79de0170a672818ffd9030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175346
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [746f66f4b1062f604cd1cfc638508c79477e13ee]

        cid#1607748 Overflowed constant
        
        Change-Id: Id077fdc914f461a3631c42c37b2d5be37632e0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [661aee7aac989647e99b88f5ca70e7af4805cf89]

        tdf#163486: PVS: Identical blocks
        
        V760 Two identical blocks of text were found. The second block begins from line 325.
        
        Change-Id: I5854337d4d1c0d946b096804b536433c48f0696f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175381
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-22  Noel Grandin  <noelgrandin@gmail.com>  [686b968ec3565c004d2d3e47dcf1370158b3dd90]

        pass by reference for ShouldDownscaleIconsAtSurface
        
        because the param is never null
        
        Change-Id: I58660a9e4e6c25def2a70099bffce322b477b702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ee4554b0ac88f673ac9998e317fb02dc5342de80]

        cid#1555259 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555264 COPY_INSTEAD_OF_MOVE
        cid#1555280 COPY_INSTEAD_OF_MOVE
        cid#1555303 COPY_INSTEAD_OF_MOVE
        cid#1555313 COPY_INSTEAD_OF_MOVE
        cid#1555314 COPY_INSTEAD_OF_MOVE
        cid#1555323 COPY_INSTEAD_OF_MOVE
        cid#1555333 COPY_INSTEAD_OF_MOVE
        cid#1555338 COPY_INSTEAD_OF_MOVE
        cid#1555349 COPY_INSTEAD_OF_MOVE
        cid#1555364 COPY_INSTEAD_OF_MOVE
        cid#1555379 COPY_INSTEAD_OF_MOVE
        cid#1555398 COPY_INSTEAD_OF_MOVE
        cid#1555410 COPY_INSTEAD_OF_MOVE
        cid#1555411 COPY_INSTEAD_OF_MOVE
        cid#1555416 COPY_INSTEAD_OF_MOVE
        cid#1555429 COPY_INSTEAD_OF_MOVE
        cid#1555434 COPY_INSTEAD_OF_MOVE
        cid#1555441 COPY_INSTEAD_OF_MOVE
        cid#1555446 COPY_INSTEAD_OF_MOVE
        cid#1555480 COPY_INSTEAD_OF_MOVE
        cid#1555490 COPY_INSTEAD_OF_MOVE
        cid#1555524 COPY_INSTEAD_OF_MOVE
        cid#1555527 COPY_INSTEAD_OF_MOVE
        cid#1555531 COPY_INSTEAD_OF_MOVE
        cid#1555578 COPY_INSTEAD_OF_MOVE
        cid#1555581 COPY_INSTEAD_OF_MOVE
        cid#1555591 COPY_INSTEAD_OF_MOVE
        cid#1555614 COPY_INSTEAD_OF_MOVE
        cid#1555619 COPY_INSTEAD_OF_MOVE
        cid#1555633 COPY_INSTEAD_OF_MOVE
        cid#1555654 COPY_INSTEAD_OF_MOVE
        cid#1555707 COPY_INSTEAD_OF_MOVE
        cid#1555712 COPY_INSTEAD_OF_MOVE
        cid#1555746 COPY_INSTEAD_OF_MOVE
        cid#1555763 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibcc1a3649c5663328e60474c06e51902aa74db52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175407
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-22  Miklos Vajna  <vmiklos@collabora.com>  [4aa8d30c095e08825bc983c699e11f2e88182124]

        cool#9992 lok doc sign: never remember previous .uno:Signature params
        
        Do this explicitly, so it can't happen that .uno:Signature with params
        gets dispatched, then .uno:Signature without params still has the old
        XCertificate.
        
        Change-Id: I35c4d5e0e4545fb1aabb9050aa6b11cd10c3ca85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175414
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-22  Julien Nabet  <serval2412@yahoo.fr>  [b2d35dfe19aec40d34f1a2cca0a83ef4cef23a7d]

        tdf#163284: Diagonal/criss-cross borders for tables is only implemented in Calc
        
        Change-Id: I645fd2a6fafb2607d94607599366d9442b4423fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175199
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [c8371b5f1a84191d38185820915f0d93741df1fe]

        a11y: Return early in AccessibleFactory::createAccessibleContext
        
        Return the XAccessibleContext reference right away, instead
        of assigning it to a local variable and returning at the end
        of the method.
        
        Change-Id: Iec47f4158dd40c25482366c33ed4a4642709f641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175405
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [51a482bc0452003dbbd396cb39bb9c2b1261df64]

        a11y: Return early in AccessibleTabBar::getAccessibleAtPoint
        
        Just return `xAcc` right away instead of first assigning it to
        a local variable.
        
        Change-Id: If11c88266b4ec72b2d5d927e3f28a14bf0cdc304
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175404
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f85366c407e71fc4e382c449504940aaedab354f]

        tdf#163486: PVS: Identical branches
        
        Since
        commit 97075a384aed0b4853b78bd5ffc681cdf9003f11
        Author: Michael Brauer <mib@openoffice.org>
        Date:   Wed Oct 24 13:16:17 2001 +0000
        
            #91961#: Support of language
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1462, 1465
        
        Change-Id: Ie27fb47ec7e22b9dbe9a2338c661c261bea8926b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175383
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  folandidi  <ndidiamakaogboi@gmail.com>  [33ca469ee6f0249582e0ed7f623b79848edbccb1]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I798ffbdf9acd44ba45cebc0a5c41249fd53c49bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175035
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-10-22  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [e4da2a54aafa0450e74a3107c26b3a5ba6471858]

        lok: fix repeat slideshow after duration issue
        
        Change-Id: I0b84d003ab3345bc89482e9940a4f0d11f33e427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175379
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [f558eb09dc4f1707313f09118b8574e405c64beb]

        tdf#163486: PVS: check stream read instead of EOF
        
        V1024 	The 'aStream' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data.
        
        Change-Id: I4f7b10bc896d13a31a97ed0dbacd413de990eb89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175363
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [75d6fd09138283b4af949d8071ecfee5e2545180]

        tdf#163516 Draw fails to restore Layer data Title and Description
        
        regression from
            commit c7b7153213619859d5f049b7c60eafa4c81f5225
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Nov 20 14:24:51 2020 +0200
            fastparser in SdXMLLayerContext
        
        Change-Id: I0db381fbd383efd23bb254703bea103ca0d270d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175378
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [993c87260690f79e1eb93ebe64a70d0af37490cd]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1241, 1244. Also, 1247 and 1251.
        
        Change-Id: Ibf474d045ae52bc0d7f655143e72117c29736dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175206
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [14a3ed6149c54e214569a292b2d0bbc5e09aeaff]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1048, 1053
        
        Change-Id: I24f2b4698ff8c0d57aa81b57b42a847caa6c1aeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175360
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9bcd990d5a287dbde14ccc77f214c8e469888140]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 628, 638
        
        Change-Id: I0979a4c245c2b550ab85072f3925082845f0915a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175352
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6884f6cd61b5a047375cf09c338c4055c919794b]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 692, 695
        
        Change-Id: I7a7b321b10437897b285c31403aee908da8cd929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175343
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [35e2aa6204925c74a988abc37d6486e5597b51c0]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 717, 733
        
        Change-Id: I57fc125abb8c9a4c9dea197945f45b95b90e41b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175320
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [eff1137fd2a5a48bea44a05f7891c5a31fffda7f]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 627, 632, 636
        
        Change-Id: If0f4f4da0d51389c12607770af58f4e34f3caafc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175353
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c91b61da00f418e20c28691b86f586ae10467961]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 674, 677
        V1037 Two or more case-branches perform the same actions. Check lines: 690, 693
        
        Change-Id: I7d9ac7ed40c6eaec4d8c6b5df0ed4299beae2f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175345
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a66a69795b6f98059feab22d3ee8afc1214bf57a]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 50, 53
        
        Change-Id: I909c0b5b219d5868a1a0197314f499e0253b3293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175388
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b5b2291366a098c4495df274ae1513b6301692fc]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 465, 472
        V1037 Two or more case-branches perform the same actions. Check lines: 497, 505
        
        Change-Id: I826e2236100727f19bb60662dc7145e8e4814421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175389
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [92bc85c42211fcfc6d2bfdeeaa1eb2d5c40ab6e1]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 1413, 1553
        
        Change-Id: I6b28e9d7055bdf120759dff38d869d1cb1e70cc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175271
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-22  Miklos Vajna  <vmiklos@collabora.com>  [47fd29a318513d26b86eb0cfa891969ce6c85879]

        cool#9992 lok doc sign: allow late-init of the sign cert
        
        The current setup is that doc_initializeForRendering() gets the signing
        key/cert earlier, even if no signing will be performed for this
        document.
        
        This has the downside that we needlessly share sensitive info.
        
        Add an alternative way so to only share the sign key/cert when the
        .uno:Signature command gets dispatched. This works similarly well for
        the signing, but this way the private info is only shared when we
        actually use it.
        
        The .uno:Signature UNO command brings up the interactive dialog on
        success, so it's not easy to cover this from CppunitTest_sfx2_doc.
        Anyhow, the format for these two parameters is PEM, i.e. base64 dump of
        the data, with the usual markers to show which one is the key and the
        cert.
        
        Change-Id: Ib424a1a490a3eb4aab35bc70a50791fc0d400920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175373
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bafc7384ba546f810abbfe17ff25ff78c7ff88c]

        cid#1545605 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545841 COPY_INSTEAD_OF_MOVE
        cid#1554682 COPY_INSTEAD_OF_MOVE
        cid#1554686 COPY_INSTEAD_OF_MOVE
        cid#1554715 COPY_INSTEAD_OF_MOVE
        cid#1554750 COPY_INSTEAD_OF_MOVE
        cid#1554759 COPY_INSTEAD_OF_MOVE
        cid#1554770 COPY_INSTEAD_OF_MOVE
        cid#1554779 COPY_INSTEAD_OF_MOVE
        cid#1554794 COPY_INSTEAD_OF_MOVE
        cid#1554800 COPY_INSTEAD_OF_MOVE
        cid#1554826 COPY_INSTEAD_OF_MOVE
        cid#1554836 COPY_INSTEAD_OF_MOVE
        cid#1554862 COPY_INSTEAD_OF_MOVE
        cid#1554865 COPY_INSTEAD_OF_MOVE
        cid#1554872 COPY_INSTEAD_OF_MOVE
        cid#1554883 COPY_INSTEAD_OF_MOVE
        cid#1554906 COPY_INSTEAD_OF_MOVE
        cid#1554921 COPY_INSTEAD_OF_MOVE
        cid#1554926 COPY_INSTEAD_OF_MOVE
        cid#1554946 COPY_INSTEAD_OF_MOVE
        cid#1554956 COPY_INSTEAD_OF_MOVE
        cid#1554970 COPY_INSTEAD_OF_MOVE
        cid#1554986 COPY_INSTEAD_OF_MOVE
        cid#1554991 COPY_INSTEAD_OF_MOVE
        cid#1555013 COPY_INSTEAD_OF_MOVE
        cid#1555037 COPY_INSTEAD_OF_MOVE
        cid#1555050 COPY_INSTEAD_OF_MOVE
        cid#1555057 COPY_INSTEAD_OF_MOVE
        cid#1555066 COPY_INSTEAD_OF_MOVE
        cid#1555067 COPY_INSTEAD_OF_MOVE
        cid#1555083 COPY_INSTEAD_OF_MOVE
        cid#1555097 COPY_INSTEAD_OF_MOVE
        cid#1555135 COPY_INSTEAD_OF_MOVE
        cid#1555140 COPY_INSTEAD_OF_MOVE
        cid#1555146 COPY_INSTEAD_OF_MOVE
        cid#1555148 COPY_INSTEAD_OF_MOVE
        cid#1555149 COPY_INSTEAD_OF_MOVE
        cid#1555155 COPY_INSTEAD_OF_MOVE
        cid#1555157 COPY_INSTEAD_OF_MOVE
        cid#1555168 COPY_INSTEAD_OF_MOVE
        cid#1555195 COPY_INSTEAD_OF_MOVE
        cid#1555196 COPY_INSTEAD_OF_MOVE
        cid#1555237 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I90531c19c28dca77fe99c72efdfc0972c311da98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [28c187c8f91e09dbcc3b1037d5076a3b1f661391]

        cid#1606773 Check of thread-shared field evades lock acquisition
        
        Change-Id: Ia1d9d91f1ca76e5fcf311c51fc560a41e72338d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7c76f391296ef129e89c724bff26cc1bd3aefa27]

        cid#1607845 silence Overflowed constant
        
        Change-Id: I97af2c10eab0ecc3c00416e1e7263b779964def8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175375
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-22  Noel Grandin  <noelgrandin@gmail.com>  [ce27c727294598eb99ac7b7e70e74a7dcecd87b3]

        no need to cache GraphicAttr in SdrGrafObj
        
        just retrieve the data when we need it, avoids marking
        this object dirty unnecessarily
        
        Change-Id: Ic3455e782365e8f2d3b89d8e5052da9d7bdaba2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-22  Jaume Pujantell  <jaume.pujantell@collabora.com>  [02d1b4923a9d8d859a299b59ff07aa312da2270c]

        sc: change how .uno:FreezePanesColumn/Row get the index
        
        On commit "sc: fix freeze row/column panes"
        44362e588686e33ff60ddcb6c1cd0c6082073fb0 the type of FreezePanesColumn and FreezePanesRow was changed from Int32 to Point. Since then, calls
        trying to set the frozen panes with this commands sending an index fail,
        setting the index to 1.
        
        This change allows again a way to set them passing only an index of type
        Int32.
        
        Change-Id: I9de12af5ec7dbb4e49b057c7c19c063424265581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174825
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3eec1925788387c7c5996052388f3fcac518dfe7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174956
        Tested-by: Jenkins

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [235c230cd348600ce7385cc580c45a7be3572704]

        We don't need a virtual here
        
        Only known SdPages need this
        
        Change-Id: Id504cd1ec318fa8cce43d11f03c628e7457f7634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175369
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [030cca8864262b65557f99df791900d52fee2f0e]

        drop newly unused Broadcast argument
        
        Change-Id: I80b4689bb6fe48e37217d5eb45007326672303fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [19bc8856c4b5444f80375919c2aed00c7de53a28]

        move vcl::DeleteOnDeinit to tools
        
        so we can fix a shutdown use-after-free in sot.
        
        Change-Id: I32f83bd94627d72d7bee7ea2ebd6ab77a7f78435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [76319347a83aecee7a423a614d67287182b31b00]

        set stylesheet parent at creation time
        
        avoids a bunch of broadcasting.
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        9.1 - 7.0s
        
        Some re-ordering of SVG output occurs, which means
        tweaking some unit tests.
        
        Change-Id: I447a4639a96c12c627a074f7e0f1ede8b3cbaf72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [620b293808f6111556c31674437917e70b106e9e]

        tdf#152534 Win 11 Dark: Draw toolbar button bg + frame manually
        
        When using the dark theme on Windows 11, the background
        color for toolbar buttons is light blue as with the light
        theme, which results in insufficient contrast.
        
        According to the comments in tdf#152534, this is
        is a in the Windows dark theme which can also be seen in
        other apps or has been worked around there, like in
        Notepad++ [1].
        
        Work around the issue by not letting the theme draw the
        background (using Win API function `DrawThemeBackground`)
        when on Windows 11 and using dark theme, but manually draw
        the background and a frame instead for now.
        
        For the background color, use a color that's a bit
        lighter than the background color for non-highlighted
        items.
        
        [1] https://github.com/notepad-plus-plus/notepad-plus-plus/commit/5d086f93a80d275fcc5e4047ae49c614680a7e5b
        
        Change-Id: Ie35937fde2e8c7078c4979a2ef60c28fc4679574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175334
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [162ef484df31829361950bb6cd19f6e7f010b54f]

        tdf#161625 Use SolarMutex instead of std::mutex in ExtMgrDialog
        
        Instead of using a custom (non-recursive) std::mutex in the
        extension manager dialog, hold the (recursive) SolarMutex instead.
        
        As the backtrace in attachment 197155 in tdf#161625 (s.a. below)
        shows, a recursive mutex is needed:
        
        dp_gui::ExtMgrDialog::TimeOutHdl (frame 17) locks the mutex, then
        dp_gui::ExtMgrDialog::startProgress (frame 6) wants to lock it
        again, causing a deadlock.
        
        (Switching ExtMgrDialog::m_aMutex to be a std::recursive_mutex
        could be an alternative, but follow the common pattern of holding
        the SolarMutex while doing UI stuff instead.)
        
        Somewhat similar commit:
        
            commit 406a7e9d452201f3fd53abc770da6eb9589fff92
            Date:   Wed Jul 10 12:46:50 2024 +0200
        
                fix locking in UpdateRequiredDialog
        
        Backtrace of deadlock:
        
            #0  0x00007f883f6adc70 in ?? () from /usr/lib/libc.so.6
            #1  0x00007f883f6b4b01 in pthread_mutex_lock () from /usr/lib/libc.so.6
            #2  0x00007f87f3ea068e in __gthread_mutex_lock (__mutex=0x5782aab26e48) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/x86_64-pc-linux-gnu/bits/gthr-default.h:762
            #3  std::mutex::lock (this=0x5782aab26e48) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/std_mutex.h:113
            #4  std::unique_lock<std::mutex>::lock (this=<optimized out>) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/unique_lock.h:147
            #5  std::unique_lock<std::mutex>::unique_lock (__m=..., this=<optimized out>) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/14.2.1/../../../../include/c++/14.2.1/bits/unique_lock.h:73
            #6  dp_gui::ExtMgrDialog::startProgress (this=0x5782aab26de0, _bLockInterface=0x80) at /home/user/libreofficetwo/desktop/source/deployment/gui/dp_gui_dialog2.cxx:779
            #7  0x00007f883b4080a1 in Link<void*, void>::Call (this=0x7f86b0000c08, data=0x80) at include/tools/link.hxx:111
            #8  ImplHandleUserEvent (pSVEvent=pSVEvent@entry=0x7f86b0000c00) at /home/user/libreofficetwo/vcl/source/window/winproc.cxx:2285
            #9  0x00007f883b40616a in ImplWindowFrameProc (_pWindow=0x5782a76df9f0, nEvent=SalEvent::UserEvent, pEvent=0x7f86b0000c00) at /home/user/libreofficetwo/vcl/source/window/winproc.cxx:2849
            #10 0x00007f883b6c711e in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=<optimized out>) at /home/user/libreofficetwo/vcl/source/app/salusereventlist.cxx:119
            #11 SalUserEventList::DispatchUserEvents (this=0x5782a62edb08, bHandleAllCurrentEvents=false) at /home/user/libreofficetwo/vcl/source/app/salusereventlist.cxx:120
            #12 0x00007f8833fb7827 in QtInstance::ImplYield (this=this@entry=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:447
            #13 0x00007f8833fb9e11 in QtInstance::DoYield (this=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:469
            #14 0x00007f883b70fc72 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:385
            #15 Application::Yield () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:473
            #16 0x00007f883b486415 in ProgressBar::SetValue (this=<optimized out>, nNewPercent=<optimized out>) at /home/user/libreofficetwo/vcl/source/control/prgsbar.cxx:199
            #17 0x00007f87f3ea14ca in dp_gui::ExtMgrDialog::TimeOutHdl (this=0x5782aab26de0) at /home/user/libreofficetwo/desktop/source/deployment/gui/dp_gui_dialog2.cxx:976
            #18 0x00007f883b6ff8c7 in Scheduler::CallbackTaskScheduling () at /home/user/libreofficetwo/vcl/source/app/scheduler.cxx:509
            #19 0x00007f8833fd4013 in SalTimer::CallCallback (this=0x5782a77b83d0) at vcl/inc/saltimer.hxx:53
            #20 QtTimer::timeoutActivated (this=0x5782a77b83c0) at vcl/qt6/../qt5/QtTimer.cxx:51
            #21 0x00007f88341a3397 in ?? () from /usr/lib/libQt6Core.so.6
            #22 0x00007f88341ab5e5 in QTimer::timerEvent(QTimerEvent*) () from /usr/lib/libQt6Core.so.6
            #23 0x00007f883418d859 in QObject::event(QEvent*) () from /usr/lib/libQt6Core.so.6
            #24 0x00007f8832efc8cc in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt6Widgets.so.6
            #25 0x00007f8834145aa8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /usr/lib/libQt6Core.so.6
            #26 0x00007f88342c7658 in QTimerInfoList::activateTimers() () from /usr/lib/libQt6Core.so.6
            #27 0x00007f88343a9f99 in ?? () from /usr/lib/libQt6Core.so.6
            #28 0x00007f8837877299 in ?? () from /usr/lib/libglib-2.0.so.0
            #29 0x00007f88378d9ec7 in ?? () from /usr/lib/libglib-2.0.so.0
            #30 0x00007f8837876795 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
            #31 0x00007f88343a82bd in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt6Core.so.6
            #32 0x00007f8833fb789d in QtInstance::ImplYield (this=this@entry=0x5782a62edad0, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/qt6/../qt5/QtInstance.cxx:458
            #33 0x00007f8833fb9e11 in QtInstance::DoYield (this=0x5782a62edad0, bWait=true, bHandleAllCurrentEvents=false) at vcl/qt6/../qt5/QtInstance.cxx:469
            #34 0x00007f883b70fc72 in ImplYield (i_bWait=true, i_bAllEvents=false) at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:385
            #35 Application::Yield () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:473
            #36 0x00007f883b70fb90 in Application::Execute () at /home/user/libreofficetwo/vcl/source/app/svapp.cxx:360
            #37 0x00007f883f8e1770 in desktop::Desktop::Main (this=0x7ffc2a5b0d28) at /home/user/libreofficetwo/desktop/source/app/app.cxx:1691
            #38 0x00007f883b717e1e in ImplSVMain () at /home/user/libreofficetwo/vcl/source/app/svmain.cxx:228
            #39 0x00007f883f90ef8a in soffice_main () at /home/user/libreofficetwo/desktop/source/app/sofficemain.cxx:121
            #40 0x000057829d6f683b in sal_main () at /home/user/libreofficetwo/desktop/source/app/main.c:51
            #41 main (argc=<optimized out>, argv=<optimized out>) at /home/user/libreofficetwo/desktop/source/app/main.c:49
        
        Change-Id: I96d746eb1493aaf5b56d50664c9d1817699f21bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175298
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [0cfa901448b8a2b979778fd066e1eda8a729def6]

        tdf#130857 qt weld: Declare support for "Word count" dialog
        
        Add .ui file of Writer's "Tools" -> "Word Count" dialog
        to the list of files supported by QtInstanceBuilder.
        
        This means that native Qt widgets are used for that dialog now
        by the qt5/qt6 VCL plugins, unless environment variable
        SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set.
        
        Change-Id: Id25d0de657dfa9acbc0d71cc3a851b2eb17c6059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175367
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [5794432281ccc6f8d3a5659d742113ca51807c8d]

        tdf#130857 qt weld: Evaluate grid positions
        
        Implement handling for the "left-attach" and
        "top-attach" packing properties of "GtkGrid"
        children, which describe the column and row
        of these children within the grid.
        
        Introduce a new static helper method
        QtBuilder::applyGridPackingProperties that
        implements the handling for QWidget children
        for now.
        
        (Support for QLayout items within a grid
        will have to be added later in order to
        supported cases where e.g. a "GtkBox" is
        located inside of a "GtkGrid" in a .ui file.)
        
        In order to move the item to the proper position
        within the grid, first locate it to determine
        it's current row and column index, remove the item
        from the layout, and re-insert it at the new
        position.
        
        While this might not be the most efficient
        way of doing this, it is fairly easy to
        implement, without having to change the
        overall approach that QtBuilder, VclBuilder and the
        WidgetBuilder base currently process .ui
        files.
        
        This is sufficient for Writer's "Word Count"
        dialog, for which support will be declared
        in an upcoming commit.
        
        Change-Id: Ia296373c408e6cd84ffcc29b9d9a03d3c2441816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175366
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [afb980283a9909aaecb6737018a05c891c9dc2b8]

        tdf#130857 qt weld: Create QGridLayout for "GtkGrid"
        
        Create a QGridLayout [1] when encountering a "GtkGrid"
        object in a .ui file.
        
        This will be needed e.g. by Writer's "Tools" -> "Word Count"
        dialog.
        
        With this commit in place, adding "modules/swriter/ui/wordcount.ui"
        to the list of supported .ui files in
        QtInstanceBuilder::IsUIFileSupported would already result in each of
        the labels in the dialog showing up, but each one as a single row rather
        than they being properly arranged in rows and columns.
        (That will be handled in an upcoming commit.)
        
        [1] https://doc.qt.io/qt-6/qgridlayout.html
        
        Change-Id: Ib9a9de4aa2820ac7e6771acf884072768508fe59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175365
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [7a7b1f9cbda97e06c71471adb3c0d00b3210a95c]

        Simplify a bit
        
        Change-Id: I224602738ce41529cc5eca681f09db31241a5cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175385
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd1870369618b2f1fcc7faa9c8e217e556e56c1a]

        don't need to const_cast away constness for SdPage
        
        Change-Id: I44fd36841319eeb3deda7becaf04ec3188586788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [7b2ea917cecbaa7deb67559fe09531bb2a3d98eb]

        Optimize JsonToPropertyValues a bit
        
        1. Make it take string view: helps to avoid extra string allocation
        e.g. in desktop::jsonToPropertyValuesVector, and will help more,
        when C++26 stringstream ctor taking string view is available.
        
        2. Factor out a function taking boost::property_tree::ptree, making
        implementation simpler for [][]com.sun.star.beans.PropertyValue and
        []com.sun.star.beans.PropertyValue, without writing a child node to
        a JSON string, and parsing it again.
        
        Change-Id: I16ac2641633ea67a7c9c054c9df09a790500e6fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175361
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa963e6273541e81921dffda85cb1a42ce8e6de4]

        tdf#163486 PVS: deprecated function
        
        https://stackoverflow.com/questions/20711740/gtk2-g-thread-init-deprecated
        
        V1109 	The 'g_thread_init' function is deprecated. Consider switching to an equivalent newer function.
        
        Change-Id: Idb3cdf277d9be0bcf73b4329d3504f6355a8001c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175339
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [c796878e6af0fc7c886e813a0010d9402312eb5c]

        tdf#163543: check GetDocShell()
        
        Similar to
        commit c5f4fe10589acff4d253cc3d32acaf67c7456bd7
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Thu Oct 3 15:14:05 2024 +0100
        
            check for null DocShell before deref
        
        Change-Id: I910fb934a36b0e68fd8bda59516c21aa9d27d09a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175338
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c2f827697b898c9d351b79c2dbb5aefc8b70dcc]

        improve style searching in SvXMLStylesContext
        
        We can searching without needing a std::map by sorting
        the style list. Which also allows to do prefix
        searching. Which we can use to dramatically reduce
        the number of styles we need to loop through in
        SdXMLStylesContext::ImpSetGraphicStyles.
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        13.5 - 9.1s
        
        Needed to adjust some unit tests because
        the order of iteration through styles is
        now different, which affects some file output.
        
        Change-Id: Ia7240fe520b70839d2519eba1fb70819a3c3bf81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175281
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [141b79e7c4cb5f0f684ec77e943289c9771ad266]

        starmath: prefix members of SmSymbolDialog
        
        Change-Id: I36430aa29665fea575633be6ab9e05aeede0c70a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175333
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b4d1e003c6ea6683bc34cb41b4457b5737e3c69]

        tdf#163486 sw: PVS: identical sub-expressions
        
        Since
        commit 47889e229cd51dd8a019d41dace6572e84771d18
        Author: Thomas Lange <tl@openoffice.org>
        Date:   Mon Sep 28 10:46:54 2009 +0000
        
            158766 avoid duplicating symbols in the catalog
        
        V501 	There are identical sub-expressions to the left and to the right of the '==' operator: aSymSetName == aSymSetName
        
        Change-Id: If204238eb0fca958e075ebb2ff4f3ad13a55630f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175332
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a61fa94f70409b7c86ea7a006a784a26a2a3da84]

        tdf#163484 Treeview not maximized in the StyleList
        
        regression from
            commit 7f42f031ed1b9f374f3fcba9c814dc5862492026
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Oct 10 09:39:14 2024 +0200
            tdf#100894 speed up style tree creation
        
        Change-Id: I953c2765090cfa56c7926c4cc10534f6ce60237b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175330
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [5cee433ef2d94e53764406f289af352750e03026]

        tdf#163486 sw: PVS: identical sub-expressions
        
        Since
        commit 22dac22fe256b28b78c8e0783f2625aee0f75ace
        Author: Winfried Donkers <winfrieddonkers@libreoffice.org>
        Date:   Thu Mar 27 13:33:15 2014 +0100
        
            fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL
        
        and later changed in
        
        commit 80f28e377db0ca04da57eed77d42f44cbdea363d
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Fri May 29 11:36:45 2020 +0200
        
            loplugin:simplifybool in oox..sd
        
        V501 	There are identical sub-expressions 'nRef >= nMax' to the left and to the right of the '||' operator.
        
        Change-Id: I78a36012dad89afa9980fcfd62772873817d871b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175327
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-21  Aditya Sahu  <adityasahu1511@gmail.com>  [c49ec77db3c99b6b45f70bee18244f399bd78a68]

        tdf#145161: Change image compression dialog string
        
        Since image compression does not always reduce image
        resolution, change the misleading label from "reduce
        image compression" to "change image compression".
        
        Change-Id: I9d2ab6c1d6409cdad32d4bf801a33f26cbba2f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175260
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-10-21  Noel Grandin  <noelgrandin@gmail.com>  [75936266771bda85c8e9c49e796bbca2167f4ef8]

        drop StyleSheetCreated
        
        the only place that references it, effectively ignores it.
        I cant find anything that really uses it, as far back in the
        git history as
            commit 59bb5ba445352f88e3ac2d00a5dc3f9bb872326a
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Wed Apr 11 18:36:28 2007 +0000
            INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED
        when it was introduced.
        
        Removing this removes a bunch of expensive broadcast operations.
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        20s -> 17s
        
        Change-Id: I84ee269aa0ea96e9f77601b01d4795edd3294044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175175
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea7cf71ad297e55750eb3df3f9eee9aca906d22c]

        only set parent style name if necessary
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        17s - 13.5s
        
        Change-Id: Ic20fc0a269ce59094732b1ea5292b24a18777a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [abe6ab7aec0993dd54746d9f0c743fc42cf7ce79]

        set master slide name at creation time
        
        which avoids some expensive broadcasting when the name is changed
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        48s -> 20s
        
        Change-Id: Ifcfd96077a9e83868ac96671ce9f208ae3ca418f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175126
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [3c0cd84287dc94858d9c92830d60eda59c626df3]

        tdf#163486: PVS: identical sub-expressions
        
        Since
        commit b7d2a9c824aca1a4dfd1b857a3620e73ade6bc0d
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Fri Oct 27 17:55:59 2023 +0200
        
            tdf#135586 sw a11y: Use BLOCK_QUOTE role for "Block Quotation" para
        
        V501 	There are identical sub-expressions 'xParaContext->getAccessibleRole() == AccessibleRole::PARAGRAPH' to the left and to the right of the '||' operator.
        
        Change-Id: I2c0c843c492aeffb2b1506821796d39804d01343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175329
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [f9077c3a7d03e4ba9e373b376a14a3142cb79b21]

        tdf#163486: PVS: Two similar code fragments were found
        
        Since
        commit 44569a657c4282757443ae06efc6441e571a0409
        Author: Release Engineers <releng@openoffice.org>
        Date:   Thu Jul 2 19:17:43 2009 +0000
        
            CWS-TOOLING: integrate CWS bubblechart
        
        V778 	Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'.
        
        Change-Id: I8a3515e2c3de97f82547786a8428f47c503335ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175321
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a2bed2a09185b2cb1a5aaf926544475a4cc4a2b0]

        sfx2: check mpViewShell in another place
        
        After
        commit 3cc367f426506e3165dda06feeb20e0a9b4c6194
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Fri Oct 18 16:40:05 2024 +0200
        
            tdf#163486: PVS: check mpViewShell
        
        Kudos to M. Kaganski
        
        Change-Id: Id1cfed6f199394720336581c87d11125cd147734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175328
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Michael Stahl  <michael.stahl@allotropia.de>  [2d6addb180ad30383f4aaec198c22ccbf936fa87]

        tdf#163486 sw: PVS: identical sub-expressions
        
        Copypasta in commit c799de145f7e289f31e3669646e5bd12814e6c5e, we want to
        compare the rows where the 2 objects are anchored.
        
        Change-Id: Ifdf267b8d70d6410ce50a507783d284ac128c1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175326
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-10-21  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [7c2b849a6d4e19308dd298d31ee32c1dec6e10a0]

        lok: enable additional transition uno commands
        
        Change-Id: I424f08cf6b7ffba54ff3e20b9a8a49c20c7dcd40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175295
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e397437ebb7ec5c4c63de9dfbef7c5a1738abef0]

        tdf#163486: PVS: Two similar code fragments were found
        
        commit 14a73d8de3f04e3087a8c2872cd1c53096f605ba
        Author: Ivo Hinkelmann <ihi@openoffice.org>
        Date:   Wed Jul 16 12:35:11 2008 +0000
        
            INTEGRATION: CWS tl55 (1.13.50); FILE MERGED
        
        V778 	Two similar code fragments were found. Perhaps, this is a typo and 'm_xGCIterator' variable should be used instead of 'm_xLngSvcMgr'.
        
        Change-Id: Ic8df89aa951761903d955c4b571bd0b70829ad3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175300
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [7ed91f371d2a3cd85d51e61aeff20aa045455e92]

        tdf#163486: PVS: duplicated items
        
        Since
        commit f1ec5dcfca45e9623d3da05503353df63e8dba4f
        Author: Rohit Deshmukh <rohit.deshmukh@synerzip.com>
        Date:   Mon Jan 6 11:26:46 2014 +0530
        
            fdo#69616: Fix for VML part missing for group.
        
        V766 	An item with the same key 'u"ooxml-rect"' has already been added.
        
        Change-Id: Iaf14b61d596102c18033a763f8a357d242760f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175325
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-21  Jim Raykowski  <raykowj@gmail.com>  [88162962222c12c8f75db97ab548d73c1318b98a]

        Resolves tdf#163515 - Basic Macro Organizer: After renaming a
        
        document macro library the original library also remains
        
        Change-Id: Ife89e1e164d288702d30e6b79f5e703ab9467e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175182
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-10-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [df90ef824778b1cb4f1c17435bfab906e14556df]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 80, 86
        
        Change-Id: I4f857ebdd950af1f52bea59a07b8846efcf89ae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175280
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Aditya Sahu  <adityasahu1511@gmail.com>  [c32210fdf31e57e7e91cd494dbbc36dd5ff6f088]

        tdf#151941: Show Alt_Shift_P as shortcut key for Page Style
        
        In Writer the Tools>Customize>Keyboard list did not show attribution
        for Alt_Shift_P which is the binding for Page Style dialog. The reason
        for this was that .xcu node for the shortcut was part of Global node.
        
        Change the Accelerators.xcu file to Modules node particularly,
        under TextDocument com.sun.star.text.TextDocument.
        
        Change-Id: I997c4e6dd292c46fe067a59f0309681d6c346a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175249
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-21  Mohit Marathe  <mohitmarathe@proton.me>  [9fca60fb13a7ac30bf763e630c5fdaed2e98b119]

        tdf#163551 fix filter comments by author bug
        
        This patch fixes the bug in which you have to reset the date filter
        for filter by author to work i.e. when switching the filter from one
        author to another
        
        Change-Id: Ib5d3bebf587c0e940d4984dd78f9d4a94f5cbb06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175189
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [7785b72d49051c052c829499d13cba4414df9540]

        tdf#163486: PVS: Two similar code fragments were found
        
        Since
        commit 4c2701d4cc8b27eed56172b4188b61efb8783c55
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Tue May 22 17:53:11 2007 +0000
        
            INTEGRATION: CWS chart2mst3 (1.1.4); FILE ADDED
        
        V778 	Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'.
        
        Change-Id: I24a904ee2e0fa81eb50756545d4b1127b93579fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175322
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a69a47ffe6d2cfd017d1b53711638305050f8369]

        tdf#163486: PVS: unused nested loop
        
        Since
        commit 75f0c33a051cb7a0f7665010c4bb8ff015211a3b
        Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Date:   Tue Jul 5 04:21:41 2011 +0200
        
            change from manual loop to ScMarkData::iterator in calc/source/core
        
        The 'i' counter is not used inside a nested loop. Consider inspecting usage of 'k' counter.
        
        Change-Id: Ia7d1aeae86fda108f97c03f6e5ea7724d6542578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175290
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [8fdf154cd8d4afafdbe068a3d764ac23f14549df]

        In MSVC, non-static constexpr objects are initialized at run-time
        
        Similar to commit c785399884650fd0a1a4ffc3008fbb665e47a9d3 (In MSVC,
        non-static constexpr objects are initialized at run-time, 2024-09-04).
        
        Change-Id: Id1c9ca961efdcbfd897a03e4f85869a6f4e5260b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175297
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [70d3278ad49dd8c3a41f8dbfcc53357124b245f8]

        cid#1608255 silence Overflowed constant
        
        Change-Id: I3b518782a82bd1f066a36c87d1a52e5e44e4abda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175259
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [729716c737f43cf93601aa028cd1967de31052c4]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 194, 200
        V1037 Two or more case-branches perform the same actions. Check lines: 796, 800
        V1037 Two or more case-branches perform the same actions. Check lines: 804, 810
        
        Change-Id: Icef65820f99405ca78d31dc9e1afc0a9d5c6b355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175279
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [25d6bd3ebcf4a5d6003288863620565749433787]

        Support FixedCellHeight in SdrAutoFitTextPrimitive2D
        
        That was missing with the result that for some cases the
        painted text (where it was missing) differed from the
        text in EditEngine mode (was set there).
        
        Change-Id: I23ddf8e90be2335c56e5a485308c753dfe72a878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175127
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-10-21  Miklos Vajna  <vmiklos@collabora.com>  [ac90d5a823ef95617e79f78dd83571b26f9ff662]

        svx: prefix members of Viewport3D
        
        See tdf#94879 for motivation.
        
        Change-Id: Ice9c1353d3411146f11d4ca34eb6369403cd4094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175294
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [6b2b85b93da86264abf2ac5604922cc6585a81ce]

        Document LIBO_TEST_DEFAULT_DESKTOP environment variable
        
        As defined by commit 69586e8381037417d106d8474d9f73638c5b9c55 (UI
        tests: use a dedicated desktop on Windows, 2024-07-17).
        
        Change-Id: Icd4ad6dfa95301fc1f6e699349278d3a0198fd08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175296
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3e239930a1f03bd38a9b1c05892c74a298bc5961]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b1d8f7ad81193f3a7ef7b5358edafcbf82cf604c
          - tdf#134503 precisions on Option Explicit statement
            
            Change-Id: Ic9f0efe82bf42e4e6abf492a2933cddef317cf2b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175304
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-21  Skyler Grey  <skyler.grey@collabora.com>  [0a8e62a0b28d616a3645861e4126ee97ffbc31da]

        fix(lok): Expose the import options dialog
        
        In a very similar way to the character encoding dialog, handled in
        Ibd36e695e733e07053bb6e22a510ac988be3ded2, we need to see this dialog
        before the document opens.
        
        I've used the same trick, where I've made the dialog into a JSDialog and
        registered an early listener, but I haven't asynced it as it's never
        useful to have more than 1 person using it at once.
        
        Change-Id: I1a61660523ae2d4812890b62d16f0e6cef133e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174269
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 335bb5b39c03b7ef7d7426259b41d479ff9ea7f0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174951
        Tested-by: Jenkins

2024-10-21  Skyler Grey  <skyler.grey@collabora.com>  [60fef0bfeb6df6512da07db899315f3480be3796]

        fix(lok): Expose the character encoding dialog
        
        The character encoding dialog appears when importing a dialog with an
        ambiguous character encoding. At the point when it appears, the document
        isn't loaded, so we have to handle it in a similar way to the text
        import dialog or password prompt dialog, allowing it to function early.
        
        It's also required to make the dialog into a jsdialog, as tunneled
        dialogs do not work this early in the document loading process.
        
        I have not asynced the dialog here because there's no point. I did write
        code where I set up a dialog factory to do this similar to how other
        modules (sw, sc, sd, etc.) handle dialogs and make them async.
        Unfortunately, this dialog is not useful with multiple users, since as
        it's used on opening a document. It may, in the future, be useful to
        someone to make a patch that asyncs the other writerperfect dialog (epub
        export) so I have uploaded and abandoned my dialog factory patch as
        Id8ec474510f3c8637639ad59331156c6e75dafb4.
        
        Documents that require this dialog, whether async or not, cause crashes
        when someone opens the document before the first person has finished
        responding to this dialog. I still consider this behavior better than
        crashing whenever we attempt to show this dialog at all.
        
        Change-Id: Ibd36e695e733e07053bb6e22a510ac988be3ded2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174044
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 283f771b92a14c06871c931b01174622b855abe5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174950
        Tested-by: Jenkins

2024-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [7e5f69aa33509a359b547b9a4a6569a55cd5d5c9]

        Make tools::Time ctor taking sal_Int64 private
        
        This ctor is meant to set the value of nTime directly; and that value
        is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK.
        But in some places, this ctor was misused for setting of nanoseconds,
        which would only accidentally work for values less than one second.
        All places that initialized tools::Time with 0, now use EMPTY.
        
        This makes the ctor private; and for the very few cases where really
        the encoded value of nTime is stored / restored, fromEncodedTime is
        introduced.
        
        Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [04921e20b4d3d08a4b78dbafe26c983075fe5630]

        cid#1633189 silence Unchecked return value
        
        and
        
        cid#1633190 Unchecked return value
        cid#1633191 Unchecked return value
        
        Change-Id: I4589ed1fe48067f493a1db04a468b7a8ed6ae178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a0f024b43217ea5fbf932bb36683966b7334711d]

        a little more natural to unconditional iterate after use
        
        Change-Id: Iac0adfdc9344b5c25736dbec151bae20d14b20fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175119
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [bc2ff9daf5d20bc9b8f260ffc59e820a1aa08772]

        vcl: move bitmap filter headers into vcl/bitmap global header directory
        
        Use #pragma once instead of header guards
        
        Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-10-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [eb37b2eb143815f17afbea6dfc344927f7b96e92]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 865, 868
        
        Change-Id: Icc108072231fd37a73f0a35eac15bb1960e50202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175266
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8c935c6ac1fb0b64cc35e6f610590f3a0e595a88]

        use frozen::make_unordered_set to skip the number of elements
        
        Change-Id: I715ab2bfc586f8854313b270580faa8e003f1c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175190
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [c67c9b04af1531d27ecdc2b6cc3928bc7c7715c0]

        qt a11y: Map BLOCK_QUOTE role to new Qt equivalent
        
        For Qt >= 6.9, map the BLOCK_QUOTE role to
        QAccessible::BlockQuote, newly introduced
        upstream in qtbase commit [1]:
        
            commit 0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd
            Author:     Michael Weghorn <m.weghorn@posteo.de>
            AuthorDate: Thu Sep 12 17:21:37 2024 +0200
            Commit:     Volker Hilsheimer <volker.hilsheimer@qt.io>
            CommitDate: Fri Oct 18 21:03:09 2024 +0000
        
                a11y: Add new BlockQuote role
        
        With this in place, paragraphs to which the
        "Block Quotation" paragraph style has been assigned,
        are now shown with the "block quote" role in Accerciser
        when using the qt6 VCL plugin with a current qtbase dev
        build.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd
        
        Change-Id: I3b9822e4a5ce6eed3ab4820a208f794bcf398e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173272
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [794cb79c0e738845000b1c7656a33db83c66696d]

        Optimize a bit
        
        Change-Id: Ief89a827c05ae1197142de46a2d9365f87455158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175282
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [dd41459378bca78a18f32e61bfac77aa48fabb8d]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 156, 164
        V1037 Two or more case-branches perform the same actions. Check lines: 898, 908
        
        Change-Id: Iec6ceda7c4506317860950857e516991d8a507a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175238
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4debd056292cd9c54cc3083c4490c07c40952de2]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 84, 90
        
        Change-Id: I3e11f666cc3db56ca4d406831841b8f5660097a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175268
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b1e8a2a2a96191ccf75f52e924d8e36755a85a4]

        tdf#163486: PVS: Remove forgotten else block
        
        Since
        commit 2f303d689ea7add6a94d14e2040a4d11ab866edd
        Author: Kurt Zenker <kz@openoffice.org>
        Date:   Thu Jun 10 12:20:58 2004 +0000
        
            INTEGRATION: CWS fwk02ea (1.6.38); FILE MERGED
        
        V705 	It is possible that 'else' block was forgotten or commented out, thus altering the program's operation logics.
        
        Change-Id: Id5a331b0338a38740b5ecf3ad881d7ce4dd6033b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175289
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Chizoba ODINAKA  <chizobajames21@gmail.com>  [e1a882e82331e3ee301332e3d10b36b5620073f9]

        tdf#75280 Convert sal_uIntPtr to size_t a more appropriate integer type
        
        Change-Id: Ia4bb455877a2c8c8c125c643c3ea6e4c162dea20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175248
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [41db41a3aac2e465b074ef9a75c9d557b8d9ff6a]

        tdf#163486: PVS: identical sub-expressions
        
        Since
        commit 0deea02b1da1001fa497dc5afa5e43207af491d5
        Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Date:   Sat Aug 19 17:18:50 2023 +0300
        
            tdf#138792: PDF export: add batch of dublin core attributes
        
        V501 	There are identical sub-expressions 'bKeywordsMod' to the left and to the right of the '||' operator.
        V501 	There are identical sub-expressions 'bThemeMod' to the left and to the right of the '||' operator.
        V501 	There are identical sub-expressions 'bTitleMod' to the left and to the right of the '||' operator.
        
        Change-Id: I438e0284a190241bf86b0e127de2f12f4a1a68b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175287
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b237267685bb48a5847fbc5264bd627126bd1b2a]

        tdf#163486: PVS: identical sub-expressions
        
        Since
        commit ad6f23d2a3842c40f7c812003af4031150ea8183
        Author: TokieSan <eltokhy@aucegypt.edu>
        Date:   Tue Jul 18 21:54:31 2023 +0300
        
            Added searching and filtering features to certificate chooser dialog
        
        V501 	There are identical sub-expressions 'rCharClass.uppercase(sIssuer).indexOf(aSearchStr) < 0' to the left and to the right of the '&&' operator.
        
        Change-Id: Ifdc4b371e6d8f79ad43236e10b86e8e5b03204a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175284
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [2219d42ca36ff0b49a488da9198384d8673096fa]

        tdf#163486: PVS: identical sub-expressions
        
        Since
        commit 78010a4db197ac44fb729a122464847931ee0e5b
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Oct 4 15:37:14 2018 +0100
        
            Resolves: tdf#106340 resize dialog when search/replace labels are shown/hidden
        
        V501 	There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator.
        V501 	There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator.
        
        Change-Id: Ib62557af291679c253162e3d72a39659691ef0b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175285
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b80001bbfd146fc62c491b78540216d41fd713f3]

        cid#1555723 Data race condition
        
        Change-Id: Icc056dffe6e81402aecf1363958d83101190186e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [972b33b14c3106d360ee2ba28bb780379e150b18]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 913, 922
        
        Change-Id: Ie9ef10d15c51b9b0702dbda41768afdee3655eab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175236
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [11a1b66554dbd8b05319a0d18008932057e41f17]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 871, 879
        V1037 Two or more case-branches perform the same actions. Check lines: 891, 899
        
        Change-Id: I027615d9acef9aae4c554f2dcbb033edac01940e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175239
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Julien Nabet  <serval2412@yahoo.fr>  [b83094d1198ae59ef7736fb3bbce5448459370e9]

        FilterEntry is just an OUString, simplify this (cui)
        
        Change-Id: I189922791e5ef3db111aa95fb9dc5af4c757a9ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175257
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-20  DaeHyun Sung  <sungdh86+git@gmail.com>  [061e1f7961aceb1c3b4e0d64ea0ef33a6a1475c5]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d0c939181ac181ce6479ae8604ef647055ccf44d
          - Update the Korean Dictionaries: ko-KR
            
            Update Korean dictionary file (ko_KR.dic) by DaeHyun Sung (2024.08.21)
            Also, update readme description
            
            Change-Id: I232b9eefba111f2d4969bc8e3add33984cff7381
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/172166
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f6ec0e9481225073835e6ef8a3a463889e66c4d]

        cid#1633319 Resource leak
        
        Change-Id: Icdbc973b6c0d40366a1a261706e21bbb50a8826e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175258
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [001c3919aabc6713835f67e9cd86ece88c68736e]

        tdf#163486: PVS: fix copy&paste error
        
        Since
        commit 95824f8636a604cb498f6e7d62ff0ed3d6b2d5ba
        Author: Noel Power <noel.power@novell.com>
        Date:   Tue Nov 2 16:55:17 2010 +0000
        
            initial import of latest cws container_controls
        
        V524 	It is odd that the body of 'removeTabListener' function is fully equivalent to the body of 'addTabListener' function.
        
        Change-Id: Iafa1f374564ab425e8c22f4e706d361f03d3183e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175255
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [c73c69db6b4cfb77dae5859525692f97c6ffd707]

        tdf#163486: PVS: fix copy&paste error
        
        Since
        commit 32cd4a92ef227bacd70be5c325a7e0d82bc90a7e
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Wed Jun 27 11:18:37 2007 +0000
        
            INTEGRATION: CWS awttree01 (1.1.2); FILE ADDED
        
        V524 	It is odd that the body of 'removeSelectionChangeListener' function is fully equivalent to the body of 'addSelectionChangeListener' function.
        
        Change-Id: I807520da4515ae8dfb070b29aa772bab1ade592b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175254
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [990d710bf772df3b5ec9b17bc43ef5b62042b39c]

        tdf#163486: PVS: fix copy&paste error
        
        Since
        commit f02e1a0abc42870dd863b53af0d9eb9c3e7f8bc8
        Author: Kurt Zenker <kz@openoffice.org>
        Date:   Thu Mar 6 16:58:17 2008 +0000
        
            INTEGRATION: CWS odbmacros2 (1.36.2); FILE MERGED
        
        V524 	It is odd that the body of 'removeStorageChangeListener' function is fully equivalent to the body of 'addStorageChangeListener' function.
        
        Change-Id: Ie5456f4ef7397d5f9144ac3167724f6c2ca32c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175251
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a901b1e307bf2a62e0af7ad5ebbfc77724fab657]

        cid#1606970 Overflowed constant
        
        Change-Id: I676b2db3baeca7e99d63c1078e2b280edb0336fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175184
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f42857302cc412f86af7166b534eb3961ccad7a6]

        cid#1607217 silence Overflowed constant
        
        Change-Id: I438da78c6589c796d56065878fcd4c98b2bb781b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175247
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46c1bc239d2f089197bcfe0d296ba745c543feb5]

        cid#1606920 Overflowed integer argument
        
        Change-Id: I6fc6a12e611a974e8feaecd398242226ab9ad930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175246
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d28365ecd2cc4e97eff56d01fa163be0852ec016]

        cid#1607805 Overflowed constant
        
        Change-Id: I14c02ef847f4cc2ab17fa6efb1a4d8c92c585eeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175245
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7e3a59c0ebce08ae623ae2df6a9135b78525ec1]

        cid#1607208 Overflowed constant
        
        Change-Id: I9e4aa51281e1fcaa208a0992281ac9050fe40306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175244
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e98801c0fe67d4c5b25827041a2051858a66cc1c]

        if this could happen, then this loop would never end
        
        so in practice it isn't happening. (Or the --i should be conditional
        on something getting removed)
        
        Change-Id: I0d74a46eced77c5bb1474c60c26e39061de791a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175243
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30f141ecd7bb7d92047eb501bc7902d74e7742bb]

        cid#1607360 Overflowed constant
        
        Change-Id: I3bc311b2a9eab23de8f8a4db095ce2e068721f21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86550dd734c4ca05ccb8af667bbcb0058d3eb7b4]

        cid#1608476 Overflowed constant
        
        just set nRead to an initial 2 and leave nLen2 alone, nRead and nLen2
        are only used for the loop condition
        
        Change-Id: I269db2d986070f010a05eb58f200d19afc1bff1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175241
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a14da9c96d8acca989175d94186037c31c84608b]

        nRead is just an alias for m_cbSTDBaseInFile, clarify that
        
        Change-Id: I6917a48b9e9d1169eb9155503ad7ece2fcb33d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175200
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [f03c221f5f4a4dfc0c75057f2505a7cc171a807b]

        tdf#163486: PVS: fix std:swap arguments
        
        Since
        commit 81c4be45829826ae73ac14e1cb862e38dd73344d
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Sat Dec 16 20:18:13 2023 +0000
        
            cid#1545561 std::swap COPY_INSTEAD_OF_MOVE
        
        V549 	The first argument of 'swap' function is equal to the second argument.
        
        Change-Id: Ieeb06744afe4ea09b986c78e8b25a5b5fc87d434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175253
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [17f2977cddfdcc7ecfb99616ab3aeb8b04c8f9a9]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'beforeColRow' variable was assigned the same value.
        
        Change-Id: I27ef13be81c9f94f452701fc1a47d6e908024a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175205
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [c64ac05bedd442066caee33c8137eebda99d0b8c]

        tdf#163486: PVS: variable is assigned values twice successively
        
        V519 	The 'sNewUrl' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 527, 554.
        
        Change-Id: I35e1b9e78f71958e99586385ba0c86e553e65997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175140
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f17e930b0fe857570d65b1882a367e63e13a48a8]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'bDirectionForward' variable was assigned the same value.
        
        Change-Id: I83343be3cfe93f0be97eae01869dd00cd0814c67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175203
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ca48b37054d68429e323235ff8dda86e85d02aa5]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 856, 860
        V1037 Two or more case-branches perform the same actions. Check lines: 918, 923, 958
        
        Change-Id: I2ef4a1cbcbbc54496b896153f08ebd0049c4dfc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175232
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [faafdec09ae2b17aa62d091f76e0cca1b0867d17]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 976, 983
        
        Change-Id: If40078b2a6ea2654d22f6cf559d19ed6c64bc44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175218
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ff25df18046af8ea2a038a165b7208e09edd1673]

        tdf#163486: PVS: Identical branches
        
        V1037 Two or more case-branches perform the same actions. Check lines: 92, 96
        
        Change-Id: Ibf8ca692e5d7208d99280c14190bda35a0fd7022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175231
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2005faca8c37f665cc5991f821990165df2ead8d]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'bDifferentParents' variable was assigned the same value. See lines 478 and 539
        
        Change-Id: Ieb29f0a089bedc3e52056f2b24284298b097fbc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175202
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [005eda09ef25dd09c1f69c163041dbb40c02ce02]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'bDec' variable was assigned the same value. Lines 1787 and 1799.
        
        Change-Id: Ia2acce92ee597d9ca801785e8c512d7351ead669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175160
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2b2b1cc59aee0a21783e53df545f8b335cd4a5bb]

        tdf#163486: PVS: The variable was assign the same value.
        
        V1048 The 'bDeleteMark' variable was assigned the same value. See lines 983 and 1001.
        
        Change-Id: I004d5fa043404a945498182d0a366c1e05158435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175201
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [a9f55e37e5ac6e282250fcfbe7a7f18b2596e574]

        Fix CppunitTest_sw_a11y crash: clear mxAccessBridge in DeInitVCL
        
        I see the crash locally on Windows 11, in a 64-bit build. Debugging it,
        I see this call stack:
        
          vcllo.dll!std::unique_ptr<comphelper::SolarMutex,std::default_delete<comphelper::SolarMutex>>::get() Line 3433
          vcllo.dll!SalInstance::GetYieldMutex() Line 142
          vcllo.dll!Application::GetSolarMutex() Line 492
          tklo.dll!SolarMutexGuard::SolarMutexGuard() Line 1340
          tklo.dll!VCLXDevice::~VCLXDevice() Line 45
          tklo.dll!cppu::ImplInheritanceHelper<VCLXDevice,com::sun::star::awt::XWindow2,com::sun::star::awt::XVclWindowPeer,com::sun::star::awt::XLayoutConstrains,com::sun::star::awt::XView,com::sun::star::awt::XDockableWindow,com::sun::star::accessibility::XAccessible,com::sun::star::lang::XEventListener,com::sun::star::beans::XPropertySetInfo,com::sun::star::awt::XStyleSettingsSupplier>::~ImplInheritanceHelper<VCLXDevice,com::sun::star::awt::XWindow2,com::sun::star::awt::XVclWindowPeer,com::sun::star::awt::XLayoutConstrains,com::sun::star::awt::XView,com::sun::star::awt::XDockableWindow,com::sun::star::accessibility::XAccessible,com::sun::star::lang::XEventListener,com::sun::star::beans::XPropertySetInfo,com::sun::star::awt::XStyleSettingsSupplier>() Line 155
          tklo.dll!VCLXWindow::~VCLXWindow() Line 336
          tklo.dll!cppu::ImplInheritanceHelper<VCLXWindow,com::sun::star::awt::XVclContainer,com::sun::star::awt::XVclContainerPeer>::~ImplInheritanceHelper<VCLXWindow,com::sun::star::awt::XVclContainer,com::sun::star::awt::XVclContainerPeer>() Line 155
          tklo.dll!VCLXContainer::~VCLXContainer() Line 42
          tklo.dll!cppu::ImplInheritanceHelper<VCLXContainer,com::sun::star::awt::XTopWindow3,com::sun::star::awt::XSystemDependentWindowPeer>::~ImplInheritanceHelper<VCLXContainer,com::sun::star::awt::XTopWindow3,com::sun::star::awt::XSystemDependentWindowPeer>() Line 155
          tklo.dll!VCLXTopWindow::~VCLXTopWindow() Line 240
          tklo.dll!VCLXTopWindow::`scalar deleting destructor'(unsigned int)
          cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 230
          tklo.dll!cppu::WeakImplHelper<com::sun::star::awt::XDevice,com::sun::star::awt::XUnitConversion>::release() Line 115
          tklo.dll!cppu::ImplInheritanceHelper<VCLXDevice,com::sun::star::awt::XWindow2,com::sun::star::awt::XVclWindowPeer,com::sun::star::awt::XLayoutConstrains,com::sun::star::awt::XView,com::sun::star::awt::XDockableWindow,com::sun::star::accessibility::XAccessible,com::sun::star::lang::XEventListener,com::sun::star::beans::XPropertySetInfo,com::sun::star::awt::XStyleSettingsSupplier>::release() Line 171
          tklo.dll!cppu::ImplInheritanceHelper<VCLXWindow,com::sun::star::awt::XVclContainer,com::sun::star::awt::XVclContainerPeer>::release() Line 171
          tklo.dll!cppu::ImplInheritanceHelper<VCLXContainer,com::sun::star::awt::XTopWindow3,com::sun::star::awt::XSystemDependentWindowPeer>::release() Line 171
          winaccessibility.dll!com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::set(com::sun::star::accessibility::XAccessible * pInterface) Line 247
          winaccessibility.dll!com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::operator=(com::sun::star::accessibility::XAccessible * pInterface) Line 351
          winaccessibility.dll!AccObject::~AccObject() Line 283
          winaccessibility.dll!std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>::~pair<com::sun::star::accessibility::XAccessible * const,AccObject>()
          winaccessibility.dll!std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>::`scalar deleting destructor'(unsigned int)
          winaccessibility.dll!std::destroy_at<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>>(std::pair<com::sun::star::accessibility::XAccessible * const,AccObject> * const _Location) Line 306
          winaccessibility.dll!std::_Default_allocator_traits<std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>>>::destroy<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>>(std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>> & __formal, std::pair<com::sun::star::accessibility::XAccessible * const,AccObject> * const _Ptr) Line 707
          winaccessibility.dll!std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>::_Freenode<std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>>>(std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>> & _Al, std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *> * _Ptr) Line 382
          winaccessibility.dll!std::_Tree_val<std::_Tree_simple_types<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>>>::_Erase_tree<std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>>>(std::allocator<std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *>> & _Al, std::_Tree_node<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>,void *> * _Rootnode) Line 760
          winaccessibility.dll!std::_Tree<std::_Tmap_traits<com::sun::star::accessibility::XAccessible *,AccObject,std::less<com::sun::star::accessibility::XAccessible *>,std::allocator<std::pair<com::sun::star::accessibility::XAccessible * const,AccObject>>,0>>::clear() Line 1365
          winaccessibility.dll!AccObjectWinManager::~AccObjectWinManager() Line 67
          winaccessibility.dll!AccTopWindowListener::~AccTopWindowListener() Line 100
          winaccessibility.dll!AccTopWindowListener::`scalar deleting destructor'(unsigned int)
          cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 230
          winaccessibility.dll!cppu::WeakImplHelper<com::sun::star::awt::XTopWindowListener>::release() Line 115
          winaccessibility.dll!rtl::Reference<AccTopWindowListener>::~Reference<AccTopWindowListener>() Line 126
          winaccessibility.dll!my_sc_impl::`anonymous namespace'::MSAAServiceImpl::~MSAAServiceImpl()
          winaccessibility.dll!my_sc_impl::`anonymous namespace'::MSAAServiceImpl::`scalar deleting destructor'(unsigned int)
          cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 230
          winaccessibility.dll!cppu::WeakImplHelper<com::sun::star::accessibility::XMSAAService,com::sun::star::lang::XServiceInfo>::release() Line 115
          vcllo.dll!com::sun::star::uno::Reference<com::sun::star::lang::XComponent>::~Reference<com::sun::star::lang::XComponent>() Line 114
          vcllo.dll!ImplSVData::~ImplSVData() Line 509
          vcllo.dll!`rtl::Static<ImplSVData,`anonymous namespace'::private_aImplSVData>::get'::`2'::`dynamic atexit destructor for 'instance''()
          ucrtbased.dll!_execute_onexit_table::__l2::<lambda>() Line 206
          ucrtbased.dll!__crt_seh_guarded_call<int>::operator()<void <lambda>(void),int <lambda>(void) &,void <lambda>(void)>(__acrt_lock_and_call::__l2::void <lambda>(void) && setup, _execute_onexit_table::__l2::int <lambda>(void) & action, __acrt_lock_and_call::__l2::void <lambda>(void) && cleanup) Line 204
          ucrtbased.dll!__acrt_lock_and_call<int <lambda>(void)>(const __acrt_lock_id lock_id, _execute_onexit_table::__l2::int <lambda>(void) && action) Line 974
          ucrtbased.dll!_execute_onexit_table(_onexit_table_t * table) Line 231
          vcllo.dll!__scrt_dllmain_uninitialize_c() Line 398
          vcllo.dll!dllmain_crt_process_detach(const bool is_terminating) Line 182
          vcllo.dll!dllmain_crt_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 220
          vcllo.dll!dllmain_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 293
          vcllo.dll!_DllMainCRTStartup(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 335
          ntdll.dll!LdrpCallInitRoutine()
          ntdll.dll!LdrShutdownProcess()
          ntdll.dll!RtlExitUserProcess()
          kernel32.dll!ExitProcessImplementation()
          ucrtbased.dll!exit_or_terminate_process(const unsigned int return_code) Line 138
          ucrtbased.dll!common_exit(const int return_code, const _crt_exit_cleanup_mode cleanup_mode, const _crt_exit_return_mode return_mode) Line 274
          ucrtbased.dll!exit(int return_code) Line 288
          cppunittester.exe!__scrt_common_main_seh() Line 295
          cppunittester.exe!__scrt_common_main() Line 331
          cppunittester.exe!mainCRTStartup(void * __formal) Line 17
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        where in Application::GetSolarMutex, pSVData->mpDefInst is nullptr,
        so in the end, the message is:
        
          Exception thrown: read access violation.
          this was 0x10.
        
        This change moves the hack introduced in commit
        05d2a415654e2b9324f70d92871df20ca964dc43 (INTEGRATION: CWS vcl37
        (1.52.38); FILE MERGED, 2005-03-29), which obviously solved the same
        problem. The CppUnit case is different, because there ImplSVMain is
        not used, but instead, DeInitVCL is called from Protector dtor
        (test/source/vclbootstrapprotector.cxx). So doing it in the start of
        DeInitVCL looks a reasonable solution to me.
        
        Change-Id: I5ba740a6b94bbdabc28538dbbcf8cd211bb56f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175198
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-20  Aditya Sahu  <adityasahu1511@gmail.com>  [33af9a8fa15cbe2d3f02f98c2bbf5dc650aa68cd]

        tdf#87605: Add new words to technical dictionary.
        
        Change-Id: I02867aa8bce8b80cc905b8a1e1f80812bd84affe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175250
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-19  Mike Kaganski  <mike.kaganski@collabora.com>  [341f3618866c622fa511f153a1b48621e04ddd17]

        tdf#163486: PVS: Numeric Truncation Error. Return value of the 'size' function is written to the 16-bit variable.
        
        Change-Id: Id912987800b9d5794fb1ab81a108163c4750d409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175213
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-19  Miklos Vajna  <vmiklos@collabora.com>  [d27f3cdfaeede871fa66dd813a0eb9967e90a139]

        sw: use frozen in SwXText::convertToTable()
        
        Switch from linear search to a fast lookup.
        
        Change-Id: Ie10435895c9a096fe0ae4bdda0a1a1eecf3c1bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154284
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-10-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c2308be74756ea024801c1449d77361cb65ca6bf]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I01aae9395213eb09c8bea990b2b6a811f7ab2ee2
        V1037: Two or more case-branches perform the same actions. Check lines: 1249, 1277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175150
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-19  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ba08d8f3a9b4421556284b76ed0635a8a62d7567]

        tdf#163486: PVS: Identical branches
        
        Change-Id: If000f1e0bb01c6d551ef970edae8058e8020a202
        V1037: Two or more case-branches perform the same actions. Check lines: 917, 945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175152
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-19  Justin Luth  <justin.luth@collabora.com>  [424329bb0b71fdb46b56be5638d5304dbef9e718]

        tdf#158460 xls/x export: don't force wrap-text for imported single-line
        
        Starting in LO 24.2, we started displaying imported XLS/X files
        that had contents-with-newlines on a single line
        if the cell did not have the wrap-text property - just like buggy Excel.
        
        So, now we need to round-trip that without setting wrap-text,
        so that we can continue to exhibit buggy behaviour
        (instead of fixing the document so that the newlines aren't ignored).
        
        A previous attempt to do this was reverted (for many reasons),
        significantly because it failed to handle the situation
        where a user entered new newline content (without forcing wrap-text).
        So in LO the new content DISPLAYS on multiple lines,
        but after a round-trip it was all squashed together.
        
        So it is important to keep the traditional behaviour of forcing wrap-text,
        and ONLY avoiding it when round-tripping imported content.
        It also preserves ODS -> XLS/X conversions.
        
        I also took the opportunity to rename mbWrapped.
        
        make CppunitTest_sc_subsequent_export_test3 \
            CPPUNIT_TEST_NAME=testPreserveTextWhitespace2XLSX
        
        Change-Id: Ia35b0679946b51626fabd4043779c1b43cc1ae37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174436
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [28c456c9c1d0d9ab7d894f51a9a345e0bda318ad]

        Fix typo
        
        Change-Id: I14a2953ec84d45844a3c83c47186cebef28feda6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175195
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aaf61a278a8f5c77059c33818e45f34e40a7fff6]

        Fix typo
        
        Change-Id: Ib3ee31656c5c9b99d77d359d28761713bb2479ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175193
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [beae2f54f2a25cc7a13b7c6ed7b4de3ff06519eb]

        Fix typo
        
        Change-Id: I14b77fc81781278925d9dab0133279eaa1acb726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175194
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [593cd3b3f508ea179109636c3e252113d58c758a]

        Fix typo in code
        
        Change-Id: I8f825d42024edc874e1f5aaff1de4eef2b3b1e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175170
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fabb52a12d0b28d37eb4f877bf707b74dd437dc0]

        Fix typo
        
        Change-Id: I06a0e9b697988f8d6ddd1d0d2be6ea4de8764a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175168
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c9be66176fcf381fa891e25ed359cdb9f8fbbcd8]

        Removed duplicated includes
        
        Change-Id: I2121743ddfca5994a7e7718cbbb9662b9029bc08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175169
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [797e5314d9e6ec910fe4ce4accc867085d81fd4b]

        Fix typo
        
        Change-Id: I776bcd6a4fb7d5f38f1aa3b5814b5c7cd455aaf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175171
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cfa3292c814ddedc48b92db856d65b10d16429ef]

        Fix typo
        
        Change-Id: Ib53d104b1600f23c8b50869ab37958829df63d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175167
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6fe9c3fb3798cd68816294d6c6b1715ebee86b81]

        cid#1633260 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1633259 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3148eddfa78e0dbdeb8ff4f1a6391420e8a635d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175176
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54f47ae4eb13d5342f7ef48ddf7ead5f792544d0]

        cid#1608219 silence Overflowed constant
        
        and
        
        cid#1608307 Overflowed constant
        cid#1606687 Overflowed integer argument
        
        Change-Id: I043f3e49810ca441453af88866a1156f47e6cd87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175177
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-19  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [baf179188d8b9e29188387fd4b7d887dd3168792]

        tdf#156333 Adding a tint/shade values to the model
        
        Before implementing text effects from the TextFill tag, their values
        must be directly saved in ComplexColor, without saving in GrabBag.
        To achieve this, DomainMapper has introduced separate processing
        of the LN_textFill_textFill tag using the new TextFillHandler class.
        
        TextFillHandler inherits from TextEffectsHandler. As a parameter in
        the constructor, it receives a reference to the ComplexColor to which
        changes will be added. This is done because some text effects
        (ThemeTint, ThemeShade) can be specified in the <color> tag, so
        TextFill must complement existing transformations. For the same
        reason, when processing LN_EG_RPrBase_color, the ComplexColor
        value is taken from the context if it was placed there previously.
        
        In docx export, existing "Tint" and "Shade" transformations are
        preserved only in <color ThemeTint=...> and <color ThemeShade=...>.
        Because the Tint and Shade values from TextFill must be
        distinguished from the values from color during export, the "Tint"
        and "Shade" transforms have been renamed to "ThemeTint" and
        "ThemeShade". Also added new "Tint" and "Shade" transformations,
        which are currently only saved in TextFill.
        
        Change-Id: I0ebba53eba83ccfc99fa812e60d6cebb2ff6bf0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157979
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-10-19  Justin Luth  <justin.luth@collabora.com>  [2bbd247f16d456eaa5591251e7a17ea198d3b39d]

        tdf#156505 sw: reset view options after export as graphic
        
        When creating an export graphic,
        the view options are changed to hide hidden stuff,
        not show the formatting marks etc.
        
        However, the user's view settings were not being restored
        after the export was done.
        
        Change-Id: I3e236e5ef47eddca487621c92ec639f7bac073de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175185
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-19  Mike Kaganski  <mike.kaganski@collabora.com>  [85a56048a004b85d232805cc3b15db0c100d8a5c]

        Windows/--disable-skia: fix D2DWriteTextOutRenderer to properly set AA mode
        
        This simplifies the process; in D2DWriteTextOutRenderer ctor, it
        uses the final mode for the call to CreateRenderTarget, applying
        the correct mode.
        
        Also, pass the AA flag from SalGraphics, and check the setting of
        GetUseFontAAFromSystem to use it, as done in e.g. CairoTextRender
        after commit e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966
        vcl: add a flag to determine if AA of fonts is used from the system,
        2018-07-28).
        
        This fixes the failures on Windows with --disable-skia, as seen in
        https://lists.freedesktop.org/archives/libreoffice/2024-October/092541.html
        
        VclCjkTextTest::testVerticalText needed to be fixed by a tweak in
        getCharacterRightSideHeight, to use color's IsDark, instead of
        comparing to the fixed black, because the correct AA mode that is
        used now, makes the vertical part of the character not completely
        black.
        
        Change-Id: Iee8fe98e29a80a242f8e761c9a23c68b34a45699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175188
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [a9be87a341af82623c04343835e6a76a4a9e561a]

        wina11y: Mention Accessibility Insights for Windows in README
        
        ... as a tool that can be useful for analysis/debugging.
        
        Change-Id: I310b04abfd3cacd403e2cfafc67f2471fa673c22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175173
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [04a2ab7ccbe6f25489e637729490d15047fa02ae]

        tdf#130857 qt weld: Use native widgets for "Rename Sheet" dialog etc.
        
        Add the .ui file used e.g. for the "Rename Sheet" dialog
        in Calc to the list of .ui files supported by QtInstanceBuilder.
        
        This means that a dialog using native Qt widgets gets
        used by the qt5/qt6 VCL plugins now when e.g. starting
        Calc, right-clicking the the tab for the current sheet at
        the bottom and selecting the "Rename Sheet" menu entry.
        
        Change-Id: Ie656e55cb2701596f6c6f1f7d395934eedf710fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175183
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [bfbaeb8192447265bdd78d1be4990947d135eb6e]

        tdf#160982 wina11y: Drop extra screen reader check to enable a11y bridge
        
        When initializing the a11y bridge on Windows, no longer
        check whether the screen reader parameter
        `SPI_GETSCREENREADER` [1] is explicitly set or require
        to explicitly enable by setting an
        `SAL_FORCE_IACCESSIBLE2` environment variable.
        
        For performance reasons, it of course makes sense to only
        enable the a11y bridge when there is actually assistive
        technology that makes use of it.
        
        However, `ImplInitAccessBridge` already only gets called
        when either support for assistive technology has explicitly
        been enabled in the settings (i.e. in "Tools" -> "Options" -> "LibreOfficeDev"
        -> "Accessibility", the "Support assistive technology tools (restart
        required" checkbox was checked) or when a `WM_GETOBJECT` message
        is received, whose documentation says [2]:
        
        > Sent by both Microsoft Active Accessibility and Microsoft UI Automation
        > to obtain information about an accessible object contained in a server
        > application.
        >
        > Applications never send this message directly. Microsoft Active
        > Accessibility sends this message in response to calls to
        > AccessibleObjectFromPoint, AccessibleObjectFromEvent, or
        > AccessibleObjectFromWindow. However, server applications handle this
        > message. UI Automation sends this message in response to calls to
        > IUIAutomation::ElementFromHandle, ElementFromPoint, and
        > GetFocusedElement, and when handling events for which a client has
        > registered.
        
        Both of these cases (explicitly enabled, AT requests information) justify
        enabling the a11y bridge by themselves, so drop the extra check.
        
        Qt's UIA bridge for example also gets activated when a WM_GETOBJECT
        message is received [3].
        
        This makes both, Microsoft Narrator (screen reader shipped with
        Windows, but which doesn't set the `SPI_GETSCREENREADER` parameter)
        and Microsoft Accessibility Insights for Windows (a tool for a11y
        analysis/debugging) work - at least to a certain degree - without
        having to explicitly set the environment variable
        `SAL_FORCE_IACCESSIBLE2`.
        
        While LibreOffice doesn't have a UIA bridge at this point in time,
        Windows provides an MSAA (IAccessible) to UIA proxy that provides
        some basic information via UIA at least, see [4]:
        
        > The LegacyIAccessible control pattern is supported by the Microsoft
        > Active Accessibility to Microsoft UI Automation Proxy.
        
        As expected, a breakpoint or assert in `ImplInitAccessBridge`
        only got hit in my testing when either an AT was active or the
        above-mentioned option was explicitly enabled, not otherwise when
        starting or using LO.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/winauto/screen-reader-parameter
        [2] https://learn.microsoft.com/en-us/windows/win32/winauto/wm-getobject
        [3] https://code.qt.io/cgit/qt/qtbase.git/tree/src/plugins/platforms/windows/uiautomation/qwindowsuiaaccessibility.cpp?id=e9662a4b665144a5eca418925d331024ec71fa2c#n40
        [4] https://learn.microsoft.com/en-us/windows/win32/winauto/uiauto-implementinglegacyiaccessible
        
        Change-Id: Iddafb149b50771412ba59972d0401bada6a9f680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175172
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [a2fab652b4001baa9d19e058668dc6400ad482c7]

        vcl: Use OUString literals in SalGetDesktopEnvironment
        
        Change-Id: Ibd28148772fcdc64a9fe6ebca38706c0445d38fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175139
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-18  Jonathan Clark  <jonathan@libreoffice.org>  [224fae69b224d28a1664c48117e77265ed67a136]

        tdf#163215: Enable kashida justification for AAT fonts
        
        Currently, we use HarfBuzz-provided kashida insertion position
        information to decide on positions to insert kashida. This data is used
        both while ranking kashida insertion positions, and to avoid inserting
        kashida in positions that would break shaping on a per-font basis.
        
        Unfortunately, HarfBuzz cannot validate kashida insertion positions for
        AAT fonts. As a result, kashida were previously not inserted for text
        using AAT fonts.
        
        This change updates kashida justification to skip validation against
        HarfBuzz when AAT fonts are used.
        
        Change-Id: If0d31512b1db0f1f8155963f9b1031eb01bacc45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175165
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [3cc367f426506e3165dda06feeb20e0a9b4c6194]

        tdf#163486: PVS: check mpViewShell
        
        V595 	The 'mpViewShell' pointer was utilized before it was verified against nullptr. Check lines: 368, 380.
        
        Change-Id: I5e8d53d3503ade1814d7436e89f0f407f1d9ccfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175164
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f48045f718ce90a693789bd3dd8cd544c72a680c]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Ibe65f4eca6009e8be4355974cdf33b5cabbe03e5
        V1037: Two or more case-branches perform the same actions. Check lines: 54, 60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175144
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [0d04f4957a6c264947ea75b0e700dac4ee983188]

        tdf#163486: PVS: The same value is assigned twice
        
        V570 	The same value is assigned twice to the 'pEntry' variable.
        
        Change-Id: I2c6a106f910a915065cdb3bc56a69e3873c3f3e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175163
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [3da6aee6a1ef879634068d384825f4da5ca686c4]

        tdf#163486: PVS: variable is assigned values twice successively
        
        V519 	The 'eResult' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1604, 1606.
        
        Change-Id: I1f778153539ac126f47d502958179c32d41a5a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175162
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [6250d512e5d3f05cb411d0816a18045422b86d50]

        tdf#163486: PVS: variable is assigned values twice successively
        
        V519 	The 'bParserSuccess' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1941, 1944.
        
        Change-Id: I4dac8d01533706a5423fd0d75e5ccdc0d3cf00c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175161
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [a84f4ef9a8694769fc942774bcf992de3a6abc88]

        svtools a11y: Set underline/mnemonic char for "Restart" dialog
        
        Set the "use-underline" property for the buttons in the
        "Restart %PRODUCTNAME" dialog and specify the accelerators.
        
        This way, the dialog can easily be closed using Alt+[accelerator]
        with the gtk3 and qt5/qt6 VCL plugin as well.
        
        Use those characters that the VCL logic was using as well.
        (The VCL implementation seems to have some way to auto-generate
        mnemonic characters if none is set automatically.)
        
        This dialog is e.g. seen when toggling experimental mode in
        "Tools" -> "Options" and closing the options dialog with the
        "OK" button.
        
        Change-Id: I50c3402fb89d5fbfc0e610c0e41f5f035cf0b0e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175137
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [ef7da29145c461877ba6aad0c72ec398eca650cb]

        tdf#130857 qt weld: Use native widgets for "Restart LO" dialog
        
        Add the .ui file of the "Restart %PRODUCTNAME"
        dialog to the list of .ui files suported by
        QtInstanceBuilder.
        
        This means that a dialog using native Qt widgets gets
        used by the qt5/qt6 VCL plugins now when e.g. toggling
        experimental mode in "Tools" -> "Options" and closing the
        options dialog with the "OK" button.
        
        Change-Id: I617bcb4d0815aeae8a30d7765ff7b4c0cc6992e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175136
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [ea6c0c3aef800431c5ce3ff705ad6e7e878d9fee]

        tdf#130857 qt weld: Leave dialog response codes unchanged
        
        Don't call `qtResponseTypeToVclResponseType` to convert
        an alleged Qt response code to a VCL one in
        QtInstanceDialog::run.
        
        In fact, the return code is already the VCL one, see
        
            commit 08b55df5c9e42c1ccb78a156261811875629342a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Sep 28 00:32:15 2024 +0200
        
                tdf#130857 qt weld: Close dialog on button click
        
        QDialog::Accepted and VCL's RET_OK both happen to be 1,
        so that mapping didn't have any effect, but everything
        else would be mapped to `RET_CANCEL` unconditionally.
        
        This wasn't a problem so far, most likely because the few
        non-message dialogs using native Qt widgets didn't use
        the response codes yet.
        
        For example, for the "Help" -> "License Information"
        dialog, only `RET_OK` is explicitly handled in
        `LicenseDialog::run` (sfx2/source/appl/appserv.cxx).
        
        Change-Id: If0a7cbf291ad94b21d6bbeecb9793b4afaa2c76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175135
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [8a4cb0af2c5ea8b9194aecae272ff93ce2544823]

        tdf#130857 qt weld: Implement QtInstanceDialog::response
        
        Move the QtInstanceMessageDialog::response
        implementation down into the base class
        QtInstanceDialog and simplify a bit, and drop
        the override in QtInstanceMessageDialog.
        
        This will be needed e.g. by the
        svtools/uiconfig/ui/restartdialog.ui
        dialog shown when toggling experimental mode in
        "Tools" -> "Options" and closing the dialog with
        the "OK" button.
        
        Change-Id: I147ea68554725a9d3b6bea6f77b15e7754cc962b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175132
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [8991553851ef07f81c7260cefa966654839684a1]

        vcl: Drop indirection via lcl_get_desktop_environment
        
        `lcl_get_desktop_environment` just calls
        `get_desktop_environment` and returns the result.
        
        Switch callers to use `get_desktop_environment`
        right away and drop `lcl_get_desktop_environment`.
        
        Change-Id: If18690a31c8b09631b3a1181e5eac3aad72a0037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175138
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-18  Mike Kaganski  <mike.kaganski@collabora.com>  [60e8be7f9dde44e1c8c0935826396c8bb907517a]

        tdf#163486: PVS: It's odd that this function always returns one and the same value.
        
        The old implementation used a UB (signed integer overflow).
        
        Change-Id: I1d8222b261f0db49c48b38defa2b58bc4770aae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175143
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [70b9a979dda072ddfe2d458d62396d853cd1f9cc]

        tdf#163486: PVS: check can be simplified
        
        V728 	An excessive check can be simplified. The '||' operator is surrounded by opposite expressions '!p3DProperties' and 'p3DProperties'.
        
        Change-Id: Iab3da21332f50a7414edff7283659106aa8d22e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175134
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f4a7af94cb747dd112d766f2d7f95a33b840b51]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'xExtra' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: I1e0d02621808b7eda104d06afe8882f72da6d87f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175131
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [33f254b48a8209ac0b6fd1a232f04e8fcb33fbc6]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'xExtra' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: Ie851b98f15eac9e7d8118fb919438fbd389cfbf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175130
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed4c5e3beb251e0ee13ad982ee7c512196c9923b]

        tdf#163486: PVS: check GetMenu()
        
        V595 	The 'GetMenu()' pointer was utilized before it was verified against nullptr. Check lines: 1582, 1612.
        
        Change-Id: I085320d3a5467e4e2c158bf2683b3156cb103e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175125
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Dr. David Alan Gilbert  <dave@treblig.org>  [af801eafd6b973dcd9e333898782ba43478a41d1]

        tdf#148526 sdext,pdfimport: Write clipToStrokePath
        
        'clipToStrokePath' is a variant of 'clip' it sets up a clip
        to a path that's been stroked with whatever width the current
        pen is.  Now that we have all the rest of the code in, we can
        start using it.
        
        This fixes the white blobs on page 3 of tdf#148526 which
        are clipped radial fills.  It has a separate problem with
        text corruption which this doesn't fix.
        
        It also fixes the geometry of the top left square in:
           https://gitlab.freedesktop.org/poppler/poppler/-/issues/178
        (although it still has colour problems with that test case)
        
        Change-Id: Ibe2c56927b45d44e90cfa2934fc905034a50e9c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172927
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b9e6cfc8fb63eb621c397a6c53e75ee60a0c2fb]

        Log using LOK_WARN instead of std::cerr
        
        Change-Id: I3a3cabd90154cb7293949d6a21f599417c364b9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174370
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        (cherry picked from commit 4baad2222e36fe2a71b2030b1a1292310821e104)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175123
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [59f8370e6286964ccf932d8f8295390dcec123d0]

        README: mention PVS-Studio
        
        Change-Id: I7116d28d1f94b1c8fe4f730b268411973de9a547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175093
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  MelvinYG  <melvingeorge204@gmail.com>  [429883310611da285561d57207d2322748abdc97]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Id648d25e47034e209b291bf73ac4878226b4e755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175105
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-18  Jean-Pierre Ledure  <jp@ledure.be>  [e74b731c80776af8fc2386f7538af4c5ca03d12f]

        scriptforge.pyi - Fix typo
        
        Change-Id: I993e30d3d228c639a69007a846b46f420f9297b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175097
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-10-18  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [feb80bccc3fcf91523a86569aab52dd650e3f8f4]

        lok: enable transition repeat after x property
        
        Change-Id: I61bd2ebaebfb19350aa3b3634f5877c0bfa05880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171773
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-18  Attila Szűcs  <attila.szucs@collabora.com>  [f51bf81cfb4330d57909e00aeca7229b71c02dd0]

        SW: Transform DocStruct: Added Log warnings
        
        Implemented warning loggings in case of transform charts or
        content controls.
        
        Change-Id: I77398ca5bf04f05743c99d63380a402c394739ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173689
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit d679849aca883c1a42d3bcee61b3bee5e3bbc6dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175122
        Tested-by: Jenkins

2024-10-18  Attila Szűcs  <attila.szucs@collabora.com>  [599365d293bb0c0fcc2b5b1183e50fa9b93a8e3f]

        SW: extract transform charts (using dialog code)
        
        Implemented chart data extraction, and transformation
        added insert/delete/modify row/column, and the ability to set
        resize data table
        setcolumndesc / setrowdesc .. for 1 descriptor,
        or with multiple descriptor to set
        set 1 cell value, or set the whole table cells values.
        it will resize the table, but you can still use partial arrays
        like
                    "data": [ [ 1,2,3,4 ],
                              [ 2,3,4,5 ],
                              [ 3 ],
                              [ 4,5,6,7 ],
                              [ 2,2,1 ],
                              [ 5,6,7,8 ] ],
        that means the 3. row 2,3,4th cell will not be overwritten.
        
        for insert column, it call codes from DataBrowserModel.
        (used by dialog code)
        
        added tests, fixed a contentcontrol date problem
        
        2. commit (made by Caolan) squashed into 1. commit:
        WIP hack this to link
        
        move stuff from chartcontroller to chartcore and adjust visibility
        until it links at least
        
        Change-Id: I5529f4da33f046eef7e947d755e29486fa966274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172849
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175121
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [9cb748847f63f73a7a0bbd63d34a5f3ebf789919]

        tdf#163486: PVS: recurring check
        
        V571 	Recurring check. The 'pData' condition was already verified in line 795.
        
        Change-Id: I0aebea88938a2e23bb1eb7c9f4e836b013f5664e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175124
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ce8e39bc9a2507e40f92275a4357fc4bf314e982]

        change misleading var prefix
        
        Change-Id: I0e59d51cbbb7b9d7481d028fb0c682e108b0e7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175118
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-18  Mike Kaganski  <mike.kaganski@collabora.com>  [f2808f9165b1b0a819bbacc5db5c4e2a5df6e3e6]

        Avoid deadlock
        
        As seen in the following call stacks:
        
        Main thread
        
          sal3!osl_acquireMutex+0x49 [libre-office-git-repo\sal\osl\w32\mutex.cxx @ 65]
          emboleobj!osl::Mutex::acquire+0x9 [libre-office-git-repo\include\osl\mutex.hxx @ 63]
          emboleobj!osl::ClearableGuard<osl::Mutex>::{ctor}+0xd [libre-office-git-repo\include\osl\mutex.hxx @ 182]
          emboleobj!osl::ResettableGuard<osl::Mutex>::{ctor}+0xd [libre-office-git-repo\include\osl\mutex.hxx @ 236]
          emboleobj!OleEmbeddedObject::getStatus+0x72 [libre-office-git-repo\embeddedobj\source\msole\oleembed.cxx @ 1133]
          sfxlo!SfxViewShell::CheckIPClient_Impl+0x42 [libre-office-git-repo\sfx2\source\view\viewsh.cxx @ 3563]
          sfxlo!SfxInPlaceClient_Impl::TimerHdl+0x40 [libre-office-git-repo\sfx2\source\view\ipclient.cxx @ 628]
          sfxlo!SfxInPlaceClient_Impl::LinkStubTimerHdl+0x53 [libre-office-git-repo\sfx2\source\view\ipclient.cxx @ 624]
          vcllo!Scheduler::CallbackTaskScheduling+0x130e [libre-office-git-repo\vcl\source\app\scheduler.cxx @ 511]
          vclplug_winlo!WinSalTimer::ImplHandleElapsedTimer+0x2e [libre-office-git-repo\vcl\win\app\saltimer.cxx @ 167]
          vclplug_winlo!ImplSalYield+0x14f [libre-office-git-repo\vcl\win\app\salinst.cxx @ 525]
          vclplug_winlo!WinSalInstance::DoYield+0xad [libre-office-git-repo\vcl\win\app\salinst.cxx @ 581]
          vcllo!ImplYield+0x367 [libre-office-git-repo\vcl\source\app\svapp.cxx @ 393]
          vcllo!Application::Execute+0xfa [libre-office-git-repo\vcl\source\app\svapp.cxx @ 369]
          sofficeapp!desktop::Desktop::Main+0x173f [libre-office-git-repo\desktop\source\app\app.cxx @ 1605]
          vcllo!ImplSVMain+0xda [libre-office-git-repo\vcl\source\app\svmain.cxx @ 229]
          sofficeapp!soffice_main+0xf3 [libre-office-git-repo\desktop\source\app\sofficemain.cxx @ 94]
        
        Request thread
        
          sal3!osl_acquireMutex+0x49 [libre-office-git-repo\sal\osl\w32\mutex.cxx @ 65]
          vclplug_winlo!osl::Mutex::acquire+0xa [libre-office-git-repo\include\osl\mutex.hxx @ 63]
          vclplug_winlo!SalYieldMutex::doAcquire+0x91 [libre-office-git-repo\vcl\win\app\salinst.cxx @ 148]
          emboleobj!SolarMutexReleaser::{dtor}+0xc [libre-office-git-repo\include\vcl\svapp.hxx @ 1425]
          emboleobj!OleComponent::StoreOwnTmpIfNecessary+0x1d3 [libre-office-git-repo\embeddedobj\source\msole\olecomponent.cxx @ 1365]
          emboleobj!OleEmbeddedObject::StoreObjectToStream+0x2f [libre-office-git-repo\embeddedobj\source\msole\olepersist.cxx @ 1032]
          emboleobj!OleEmbeddedObject::StoreToLocation_Impl+0x3cc [libre-office-git-repo\embeddedobj\source\msole\olepersist.cxx @ 1169]
          emboleobj!OleEmbeddedObject::storeAsEntry+0x152 [libre-office-git-repo\embeddedobj\source\msole\olepersist.cxx @ 1523]
          comphelper!comphelper::EmbeddedObjectContainer::StoreEmbeddedObject+0x490 [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 501]
          comphelper!comphelper::EmbeddedObjectContainer::InsertEmbeddedObject+0x6f [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 518]
          comphelper!comphelper::EmbeddedObjectContainer::RemoveEmbeddedObject+0x388 [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 945]
          comphelper!comphelper::EmbeddedObjectContainer::RemoveEmbeddedObject+0x46 [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 831]
          swlo!SwOLENode::SavePersistentData+0x20b [libre-office-git-repo\sw\source\core\ole\ndole.cxx @ 403]
          swlo!SwNodes::ChgNode+0x411 [libre-office-git-repo\sw\source\core\docnode\nodes.cxx @ 214]
          swlo!SwNodes::MoveNodes+0x18e6 [libre-office-git-repo\sw\source\core\docnode\nodes.cxx @ 868]
          swlo!SwUndoSaveContent::MoveToUndoNds+0x1c1 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 784]
          swlo!SwUndoSaveSection::SaveSection+0x559 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 1325]
          swlo!SwUndoSaveSection::SaveSection+0x55 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 1278]
          swlo!SwUndoFlyBase::DelFly+0x127 [libre-office-git-repo\sw\source\core\undo\undobj1.cxx @ 232]
          swlo!SwUndoDelLayFormat::SwUndoDelLayFormat+0x64 [libre-office-git-repo\sw\source\core\undo\undobj1.cxx @ 429]
          swlo!std::make_unique+0x22 [C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\memory @ 3382]
          swlo!sw::DocumentLayoutManager::DelLayoutFormat+0x283 [libre-office-git-repo\sw\source\core\doc\DocumentLayoutManager.cxx @ 242]
          swlo!SwTextNode::DestroyAttr+0x82 [libre-office-git-repo\sw\source\core\txtnode\thints.cxx @ 1204]
          swlo!SwTextNode::EraseText+0x18f [libre-office-git-repo\sw\source\core\txtnode\ndtxt.cxx @ 2813]
          swlo!SwTextNode::DeleteAttributes+0x115 [libre-office-git-repo\sw\source\core\txtnode\thints.cxx @ 1863]
          swlo!SwXFrame::dispose+0xdb [libre-office-git-repo\sw\source\core\unocore\unoframe.cxx @ 2692]
          mscx_uno!`anonymous namespace'::cpp_call+0x710 [libre-office-git-repo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx @ 214]
          mscx_uno!unoInterfaceProxyDispatch+0x2fa [libre-office-git-repo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx @ 430]
          binaryurplo!binaryurp::IncomingRequest::execute_throw+0x635 [libre-office-git-repo\binaryurp\source\incomingrequest.cxx @ 239]
          binaryurplo!binaryurp::IncomingRequest::execute+0xbf [libre-office-git-repo\binaryurp\source\incomingrequest.cxx @ 79]
          binaryurplo!request+0x1c [libre-office-git-repo\binaryurp\source\reader.cxx @ 84]
          cppu3!cppu_threadpool::JobQueue::enter+0x21e [libre-office-git-repo\cppu\source\threadpool\jobqueue.cxx @ 101]
          cppu3!cppu_threadpool::ORequestThread::run+0xa0 [libre-office-git-repo\cppu\source\threadpool\thread.cxx @ 169]
        
        where the call to OleComponent::StoreOwnTmpIfNecessary from
        OleEmbeddedObject::StoreObjectToStream was made with m_aMutex
        held; and that mutex was attempted to be locked from the main
        thread, holding solar mutex.
        
        Change-Id: I1914188728cdaa9cdf22d216ec71f733d7780692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175117
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d8e10f7d94365b32c29e9fc8a2a0901528888daf]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I27de9f10b54478fa265efcb2fa35b8c7e16666f2
        V1037: Two or more case-branches perform the same actions. Check lines: 821 and 827, 1962 and 1967, 2006 and 2011.
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175052
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Sakura286  <sakura286@outlook.com>  [7bd9aaccb99287e4e50fb18759edc7688502a1fb]

        tdf#158237 comphelper: Use C++20 contains() instead of find() and end()
        
        Change-Id: I3fc233ffc4c57b02e605306cb9bf3903a88401a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f6033dca9dc5e2640e796c2ba8853a8e157e338c]

        tdf#163486: PVS: Identical branches
        
        Change-Id: Id493bc317eb9cf358c79454b7778895b78b7c8aa
        V1037: Two or more case-branches perform the same actions. Check lines: 320, 323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175048
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5aa3f30a8e7dccd974f5ecd491663fb123005509]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I4afca4f9d7eb8968dc7a2465222f7c2060f10bd4
        V1037: Two or more case-branches perform the same actions. Check lines: 178, 194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175055
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a7571ddd146bba9b25708da288f898e5cd221f8d]

        tdf#163486: PVS: Identical branches
        
        Change-Id: I392760b8605588576049e5afda2da64faea3fd00
        V1037: Two or more case-branches perform the same actions. Check lines: 486, 489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175049
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [c0a9c3f97d7da054f40572667847274b725372d8]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'mpMarkedRanges' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        V668 	There is no sense in testing the 'mpMarkedRanges' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: Iba55f15534cdc9af5b86b288b5c42702ad83dc26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175107
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d9357eb5d996e4c70bbb4cd534daa9f70f78354]

        tdf#163486: PVS: check pDrawView
        
        V595 	The 'pDrawView' pointer was utilized before it was verified against nullptr. Check lines: 128, 133.
        
        Change-Id: Ic07658428e4eb74d42d800df23b198800a9bab09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175115
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c4a485194c158d970df7bf06d5a6d6791b76f42]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'indxc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        V668 	There is no sense in testing the 'indxr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        V668 	There is no sense in testing the 'ipiv' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: Ifecd9ef5b831e5b312bb428e4d4f72c03cc29b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175106
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [104cae64dfd9c881264ea03680ca01cff855c4fe]

        tdf#163486: PVS: recurring check
        
        V571: Recurring check. The 'xObj' condition was already verified in line 809.
        Change-Id: I4b782c9601893ad91598382ea2f999cbd46df75b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175104
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2032012612d28a3333863afb684d0ef7c6017c4]

        tdf#163486: PVS: recurring check
        
        V571: Recurring check. The 'if (rEntry.lateInit)' condition was already verified in line 400.
        Change-Id: I0a126691213440520bab4b5bd2f2363dfdd57e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175103
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a384cc2337183d13a3cafad389714a12eab7c1f]

        tdf#163486: PVS: recurring check
        
        V571: Recurring check. The 'if (m_pListener)' condition was already verified in line 104.
        
        After 4d07ee9a54e0b929ab116b08227e20f4a9c330e9
        "loplugin:virtualdead"
        
        Change-Id: I12e90376211f3625cdda482909a96d43fe55cc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [a21b9064e89306404c467b354a1bbff20efbe6a3]

        tdf#163486: PVS: check GetView()
        
        V595 	The 'GetView()' pointer was utilized before it was verified against nullptr. Check lines: 518, 531.
        
        Change-Id: I9c6ebccabece0923702e6a8fb4ee6beb9b6dc198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175114
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [954f061b93c9b8bc441af498dc19aaa1afcba791]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'pInfo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: Ie6a701c8fd8d6a0386e83012d59389edaccea93e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175109
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [47781b6733ed05c0f4ec1e0b6ab0b5d26f8415d9]

        tdf#163486: PVS: redundant nullptr check
        
        V668 	There is no sense in testing the 'pCommentAction' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
        
        Change-Id: I3fa6619f80edefd852693190ebf463f694c8b55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175108
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [eeca3ea10109aeea45d7da279c05ef278d4e2cd0]

        tdf#163486: PVS: check mpViewSh
        
        V595 	The 'mpViewSh' pointer was utilized before it was verified against nullptr. Check lines: 704, 713.
        
        Change-Id: I5c1902d9aa9a33e62cf2aa559bab9c0b3f45f688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175112
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [440286f8f7ae520c327e308221dd009eedf7f67b]

        tdf#163486: PVS: condition is always true
        
        V654 	The condition '!bFound' of loop is always true.
        
        Change-Id: Ib37444255641f902a6833e222dfe1ee001376ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175110
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [0f600f307b28f6e4d1c8063c8c59632c9e809934]

        tdf#163486: PVS: remove break
        
        Since 07f8216e5722d2288143367a07f4d567ab060431
        "Create string from token array directly from ScTokenArray. Still WIP."
        
        V622 	Consider inspecting the 'switch' statement. It's possible that the first 'case' operator is missing.
        
        Change-Id: I5916fb8db4db3a0c238660a35ad1b5d985387292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175111
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-18  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [511d5a487dac2b815242035c10adbeb190ad0392]

        find-unneeded-includes: add option to detect IWYU failures
        
        In some cases IWYU may fail to run and give back -1 status
        - A file does not have any headers included, such as
        sw/source/ui/vba/vbawordbasic.hxx
        - A header includes itself such as
        sw/source/ui/vba/vbaformfielddropdownlistentries.hxx
        - Checking headers is not called with correct -I switches
        such as with sw/source/writerfilter/dmapper/*hxx misses
        -I/home/gabor/core/sw/source/writerfilter/inc
        
        Such cases were not handled/reported separately so far, so add a
        debug-like option to detect similar errors.
        
        Solving such issues is still down the road.
        
        Change-Id: I47ac876eb4eb4a0c16bd838ce3c3e4d604a07a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175099
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-18  Heiko Tietze  <tietze.heiko@gmail.com>  [608353f563fa1a692f118cf3e4aab649269b43a8]

        Relates tdf#162979 - Fix typo
        
        Fixes patch 74e3f47723471f3ed4dc2dbffc95085bb04d9504
        
        Change-Id: I3cd596f15c1d0ebc600b9b5f1bffa87b5225d0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175091
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-10-18  Dr. David Alan Gilbert  <dave@treblig.org>  [b4faa1775dfd90e781ac2f94a7ae1ada31b9d49f]

        tdf#148526 sdext,pdfimport: clipToStrokePath: Set line join
        
        Set the line join type from our GC.
        
        Change-Id: I8f64ae032930e46028cd49efefb05af06d4866d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172926
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-18  Dr. David Alan Gilbert  <dave@treblig.org>  [84cc3180c8d42eb8528840d68fe52055f884120b]

        tdf#148526 sdext,pdfimport: rendering::PathJoinType to B2DLineJoin
        
        Pdfimport is one of the few none render pieces of code to use
        css::rendering::PathJoinType, switch to using basegfx::B2DLineJoin
        instead.
        Use that type consistently instead of throwing in sal_Int8's with it.
        
        Change-Id: Ie1384a06558925c796ce6c83b458b4c150bcecc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172925
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-18  Dr. David Alan Gilbert  <dave@treblig.org>  [53d5b3119feff3fe6653a38d13e21e6674055211]

        tdf#148526 sdext,pdfimport: Expand path to contour
        
        Poppler's 'ClipToStroke' call wants to clip to a paths rendered
        shape, i.e. with line thickness and possibly other attributes.
        
        Use get2DDecomposition to do that.
        
        Change-Id: I3ca54621dcb859520504e5c7d6cd41106f5c34d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172924
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [f488136a72f626c6752538fbc80efe13053cead5]

        tdf#163486: PVS: Expression is always false
        
        V547: Expression 'aMDHelper.ISSET_Storage' is always false.
        Change-Id: Ibdeb820b606301f729bf09a3641ab44d726e356c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175095
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [43cec3f814e509a257eec597baf8bbeb568eb7d9]

        tdf#163486: PVS: nullptr dereference
        
        V595: The 'pMethod' pointer was utilized before it was verified against nullptr. Check lines: 392, 394.
        
        Change-Id: I7c3cdcf9aacb76ca261733924dc238e836036433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175080
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3bcf854a2f3da83e641f74302ef3745166ca8137]

        cid#1557611 Data race condition
        
        Change-Id: Id8a60317bcf068132900d4aff8d64dd9ad6dd8c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [819cae19dbdf45188a004136dc3c5a0a6cdec1b8]

        tdf#159007 Revert "optimization to skip SdrObject::GetViewContent()"
        
        This reverts commit 313be607903a381830600c0a60b2e299fcaec685.
        
        Change-Id: I2dc7489ecc302473edd763fd0e4d6784fadc9bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175094
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9250f27dadfc2d73e2f3600052a783a0e82f370d]

        tdf#163486: PVS: Identical branches
        
        V1037: Two or more case-branches perform the same actions. Check lines: 996, 999
        Change-Id: Idfec4df06a578c63e52ef053b73dfa2d55b5cbf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175089
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ddac2a6e263a43741e2843068631e0d84561bd1]

        tdf#163486: PVS: identical conditional expressions
        
        V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 422, 426.
        
        Change-Id: Ib2bcd4b170b827c325628e0e7eabe6a19ca399ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175086
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad09bf747794ee591c62b5ce4e369cfb039c86c5]

        tdf#163486: PVS: identical conditional expressions
        
        V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 507, 520.
        
        Change-Id: Ia376cad05bd4327662cd3b7adcbe43e25270da2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175084
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a2e5c6d93aac9cee35c861cf259b46071832432]

        tdf#163486: PVS: identical conditional expressions
        
        V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 406, 410.
        V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 410, 418.
        
        Change-Id: I971f243870a96f7195d2819f2a0a44bb63840fac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175083
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [6958a8259c8ce75fd6d2625f39e3808c9ee88608]

        tdf#163486: PVS: identical conditional expressions
        
        V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 153, 157.
        
        Change-Id: I55b32aa4dfd479c3b64044a6749c3981f3b032a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175082
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Dr. David Alan Gilbert  <dave@treblig.org>  [a61eff73a16d891828e8723ad02fffe94b2d2216]

        tdf#148526 sdext,pdfimport: Parse clipToStrokePath
        
        Parse the soon to be created clipToStrokePath command and route
        it through the tree code.
        
        Change-Id: I8fa17457ffd062e91983b6ed80bd64259aa7114e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172923
        Tested-by: Jenkins
        Reviewed-by: David Gilbert <freedesktop@treblig.org>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7b218d6b4f3217b0fc629ef354b0fa4a94315597]

        cid#1555697 Data race condition
        
        Change-Id: Ib022e1fbccf456e89f16a26efb50e6c8d98372ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175065
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2dda4579d6b80526cd19cf97ea6cf6237e590c9]

        cid#1555171 Data race condition
        
        Change-Id: Ibb49dbd5ce386c4e31c1dfbacb23477d1a08a5ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175069
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Justin Luth  <justin.luth@collabora.com>  [4b675143b4d7f9b9d1bcc76c34d413de35ee56a1]

        tdf#34804 sd: enable keyboard shortcut for CharColor and CharBackColor
        
        A followup patch that adds keyboard shortcut support to Draw/Impress
        for .uno:Color and .uno:CharBackColor to use recentColor.
        
        Change-Id: I1eea3b8330ca3c10e20b13e0fa83c15418eee6a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174828
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-17  Justin Luth  <justin.luth@collabora.com>  [cdd00486a73ab94eeda2e403eba5df813f472e60]

        tdf#34804 sc: enable keyboard shortcut for CharColor and CharBackColor
        
        A followup patch that adds keyboard shortcut support to Calc
        for .uno:Color and .uno:CharBackColor to use recentColor.
        
        Note that for Writer, it was .uno:FontColor (SID_ATTR_CHAR_COLOR2)
        but the rest of the applications are .uno:Color (SID_ATTR_CHAR_COLOR)
        
        I purposely did not add CharBackColor support to native Calc.
        Notice that the "fill" icon on the toolbar is CELL-background, so the
        color used would NOT NECESSARILY match what is seen in the toolbar,
        and the sidebar also does not include a CharBackColor button.
        [See patchset 1 for stuff needed for implementation.]
        
        formatsh is for entire cells - .uno:Color opens dialog when no args: OK
        
        editsc is for cursor-in-cell and for cursor-in-formula-bar.
        
        drtxtobj is for comments, shapes, and textboxes (draw stuff).
        
        Change-Id: I104b39eab1d475fc5c88837addf4bdbbd313d1be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174827
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-10-17  Justin Luth  <justin.luth@collabora.com>  [1c7740f33b885eb20f913bff1283e509f86fba9d]

        tdf#34804 swdr: enable keyboard shortcut for CharColor and CharBackColor
        
        A followup patch that adds keyboard shortcut support
        for the draw objects (textbox, shapes, comments) in Writer.
        
        Change-Id: I69dea0feb75c77fec615a3e478d4bb90db4ca84f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174805
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-17  Julien Nabet  <serval2412@yahoo.fr>  [5206f500e72a3d9aca9960fa4ce90120e8a2ed93]

        Fix Gtk-warning in condformatmanager.ui
        
        (soffice:502622): Gtk-WARNING **: 13:08:51.061: Could not read property GtkBox:position with value  of type gint: Could not parse integer ''
        
        Change-Id: I43b1a0fd8d67ef60e9c252b914b4fe2d00d97c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175079
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84ed46d7ee195e7bb10b7e480dc596c76f4af40f]

        don't need to use dlsym for cairo_surface_set_device_scale...
        
        for bundled cairo case
        
        Change-Id: I8ca48433b3be144d8347defe3831b92cc87d7cbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7be32268e086e122e64f7aa12566b6a092c63d20]

        Fix experimental Emscripten --enable-qt6 build resource issues
        
        ...where window decoration icons and menu text glyphs were missing
        
        Change-Id: Iadff019a99fbe96442fc010df0d019ba5e2b98e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175088
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-17  Justin Luth  <justin.luth@collabora.com>  [bc21a85029a6b31cab07a4e3d481e059120ff510]

        tdf#34804 sw: enable keyboard shortcut for CharColor and CharBackColor
        
        The result of this patch is that a keyboard shortcut can now
        set the font fore-/back-ground color using the
        color shown in the toolbar/sidebar.
        
        This is now possible thanks to Maxim's work in 7.6.2
            tdf#154270 Sync toolbar button recent colors
        and Andreas Heinisch's 24.8 commit 8c822b764b35a0116a0865e991a87c8315e0
            tdf#72991 - Remember last used color depending in cui
        
        This patch does 3 things:
        1. SetRecentColor when the app initializes
        2. Uses SID_ATTR_CHAR_COLOR's recentColor for .uno:FontColor
           if no pItem was provided (i.e. a keyboard shortcut called it)
        3. Uses SID_ATTR_CHAR_BACK_COLOR's recentColor for .uno:CharBackColor
           if no pItem was provided
           (Note that without a selection,
           CharBackColor isn't so useful for a keyboard shortcut,
           since it turns the drag-and-drop template on.)
        
        Setting the recent color right away is critical for user acceptance.
        Otherwise, it would only function after they first modified the color
        in the toolbar/sidebar.
        
        make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf34804
        
        Unfortunately, I can't reliably know if this request
        came from an awt::KeyEvent or not, because in that case
        we could just avoid CharBackColor's template altogether.
        [While there is rReq.GetModifiers() as a good hint,
        it is not a guarantee (in case assigned to a function key,
        or CTRL held while clicking the toolbar, etc.)]
        
        Change-Id: I7377f087dcdf7011205af005cd0d172100bade2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174804
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4df8414e919f2ff82429dfa302db9cd2d1261b26]

        Adapt experimental Emscripten --enable-qt6 to recent Qt6 upstream
        
        At least when building against recent upstream dev branch, qtloader.js needs FS
        due to
        <https://github.com/qt/qtbase/commit/64007c749703090ebf7f9b1b49b4267bb9993b99>
        "wasm: add 'preload' qtloader config property"
        
        Change-Id: Ie505d531670649635774152032123389b6d106ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175085
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-17  Marco Cecchetti  <marco.cecchetti@collabora.com>  [c9f674d92b4a15c1fb32ffdffc070893b648e8ee]

        lok: sd: transition information: export fade color
        
        Change-Id: I955c18cc5d131cfa5a246bb4506a81b8cf40b7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175071
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-17  Jonathan Clark  <jonathan@libreoffice.org>  [e62dd2ca2c12ee02c5a2fba7bdd31dbcb17afc7b]

        tdf#161145 sw: Conform doc grid advance layout for DOC/DOCX import
        
        This change modifies the Writer document grid algorithm to behave more
        like Word when the MS_WORD_COMP_GRID_METRICS compatibility flag is set.
        This flag is automatically set when importing DOC/DOCX files.
        
        Change-Id: I99765a3ad689b319ebd14e3620b22f18661efcf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175077
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-10-17  Samuel Adesola  <adesolasamuel2022@outlook.com>  [8e7e59eddedac07ea32388168bcc71f3e521a526]

        tdf#140061 CPPUNIT Test for fix swlo!sw::WriterMultiListener::StartListening
        
        A CPPUNIT Test for the bug fix on swlo!sw::WriterMultiListener::StartListening
        crash.
        The sample file was added to the sw/qa/uiwriter/data.
        Without this fix, writer crashes when the reproducing steps were followed.
        The bug fix was reverted, when the test was ran, the test failed, i.e the
        assert was not reached. The bug fix was reintroduced and the test
        passed showing that the test catch the bug.
        
        Change-Id: I688672d96a36d89c940bf0d401daaaeb732590a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174908
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e7c9028de586a0dd8aeb0b79954ac67e55088f4]

        CppunitTest_sw_layoutwriter3: split in two
        
        it already has 133 tests
        
        Change-Id: Idb67ab8af7ead44db1330a0437cc099c39b65cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175073
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c74a07ade64d11231ba88bdb3edd750af92c9f54]

        cid#1557492 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6fd226cad714fab0eb0f8c0806dcf73c2ff20426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c316b9c03279af88888a1cc26f6cf9c18bb8dd76]

        cid#1608473 Data race condition
        
        Change-Id: I5152a3ba56aa9d739232ba6f6c95448b26fd22a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Juergen Funk  <juergen.funk_ml@cib.de>  [7303a0375bb3ae087fb4ff77d0efc9182c60a372]

        tdf#160163 improvment when reset placeholder in Text field
        
         - this patch improve e8a271dd53d605a835c493eef5c34e4fb077f16d
           when replace the empty-placholder, it was missing the selection
           of the whole placeholders.
         - with this change have solved a other problem, when select with
           the field with mouse or tab, and press backspace, then the cursor
           has the wrong position, after tip text the view was wrong.
         - reduce code
        
        Change-Id: I6c2c7b2849298552770ea2d257ab844d250a97a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174965
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c349892967ca97748fcd065918ada191c234b7c4]

        cid#1555042 Data race condition
        
        Change-Id: Ifc3e2134520a6947ab66014c40b962b1de8a22be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175066
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [0659bdb7f713a897e8e104d9ff992c2b43ddc9a4]

        sw: move these tests where they belong
        
        Since they use DECLARE_ODFEXPORT_TEST they should be inside
        sw/qa/extras/odfexport/
        
        Change-Id: Ia080f006c08ecf584232428563ec2aa94f6a4ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175067
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f55160f25600039cb584975b8ff893f0453e485]

        cid#1606687 silence Overflowed integer argument
        
        Change-Id: I692ac9745c0f2811e7e8d155d0aeeee578d358fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3163717d4cfe39ce510de748a14f3f588eb2c867]

        cid#1606973 silence Overflowed constant
        
        Change-Id: I333110570dba4b7410b9c4b5595afc5d2b06cb94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175062
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f5d0aac2b413ccedb10b0309451b79d5d9488ef3]

        cid#1606594 silence Overflowed constant
        
        Change-Id: I1aff57f76eac334feea9fba02233b9b004ca759c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175063
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-17  Sakura286  <sakura286@outlook.com>  [50656d54131abeefc88a6ceb77e7f60686ce2fea]

        extract NaN payload test from single unit test
        
        Change-Id: I51a029c9ac729352fe435b9a70c5e8bd2cf746b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174964
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-10-17  Đoàn Trần Công Danh  <congdanhqx@gmail.com>  [92f952971908e84ea1c32ab93c8d6b2b6d66b392]

        configure.ac: Drop bashism
        
        - ${var/pattern/replacement} and here-string are bashism.
        
        - here string (<<<<) is bashism too, depsited it's intended for Windows
          build only (which uses Bash inside msys), however the code block is
          still parsed on other platforms (without bash a /bin/sh) before
          evaluated. Let's remove that too.
        
        Change-Id: I3ba59d97b9e9a6b29496b3401c29c4fbf99f46d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170969
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a6029ba428269e75b67c0861bd9bd1f804dfc79]

        we don't need to copy the Name here, a reference is sufficient
        
        48s -> 47.8s
        
        Change-Id: Ib95b701d424b0b92aa3848b75f81c41eff0af2ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175029
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-17  Muluh MG Godson  <godsonmuluh@gmail.com>  [92b4b7d6bb2465fd806833c9ba7d2d6282b3dbed]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I7cfacc4fa2b302f01a284f750a99fc777b7ae43a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175037
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-17  Chizoba ODINAKA  <chizobajames21@gmail.com>  [2d84bab85c9c00ce552d7da5cee0c5d88a160726]

        tdf#145614 Convert #define to 'enum'
        
        Change-Id: I92cd029034015fe8b664ee75b4e4f107ba365e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175034
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-10-17  Michael Weghorn  <m.weghorn@posteo.de>  [ef92722b3cd92e5e96a9c8cf1bc9ee8a72eb7241]

        Partially revert "loplugin:unusedmethods" to fix --enable-cpdb build
        
        This PPDParser ctor is used by CPDManager::createCPDParser,
        which gets built with the `--enable-cpdb` autogen option.
        
        This partially reverts commit 5c4fac1e9f50832852e87452f3152f01b905f9e6.
        
        Change-Id: Ic22fc4e776c0b0ef2013b9296c7dbe9345c4e51c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175040
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-17  Mike Kaganski  <mike.kaganski@collabora.com>  [0794754e8540415eaac2dcf45069f500ed356859]

        Optimize a bit: only create std::locale once in parseDudenResponse
        
        Change-Id: If1aee9fa908b4ad730d858738f3e472a17fd235a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175039
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [a79acaf274dfe03d008e9fcd3fb8ded6c1724935]

        sw: reduce usage of DECLARE_SW_ROUNDTRIP_TEST
        
        Change-Id: Ib2884a766ff891aa768530e62cb2825402b84d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175026
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [302a0de82e1227e0e99b11e0157d859bfa96ccd7]

        tdf#161351 Revert "tdf#99528 Use vertical tabs in list style dialog"
        
        This reverts commit d9bcf481b40d2a20169a98eb53caf7b19a03f3b8.
        
        Change-Id: If3cffb089c22a32d558f299616ee1a4ec515d01c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174820
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-10-16  Jim Raykowski  <raykowj@gmail.com>  [5cf912b08e4a22f66ab1ec5fa601ba3e50e3c4cc]

        Resolves: tdf#163448 An unsaved new document don't allow moving
        
        headings with Content Navigation View option (by drag and drop)
        
        Change-Id: Id1f4cbc0538e75abfb2a133d2d6fb82ddaf580fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174986
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c3c9efc94f737e5f6c42db02b261d8fdb47f3d51]

        crashtesting: assert on fdo87790-1.ods
        
        and gnome704765-1.ods
        
        Change-Id: I037b3c7d1f3887634ead05e5464435ae0fbeea60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175028
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [c216b58631deda48531475f7a8f054ac266386f7]

        SwModelTestBase: Remove unused executeImportExport
        
        Since b67991ecdb12bfa385496731f192ac081947c779
        "CppunitTest_sw_htmlexport: use more CPPUNIT_TEST_FIXTURE()"
        
        Change-Id: I572649a1f70180084846aa47446689b331f35f11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175024
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0e31effd0c7231ec0517e01e9aec39cebc361e1]

        SwModelTestBase: remove obsolete comment block
        
        Change-Id: I4b4383c02cddc26e2f96ab4d252e55ac5f0dc3d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175023
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-16  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1d9ce0a67a71e51569cd33c26270eeece587a354]

        tdf#162571 - sd: Text box expands or shrinks on left or right or
        
        both sides, depending on the text alignment. Set the text anchor
        position based on the first paragraph alignment.
        
        WIP: testing...
        
        Change-Id: Ie1588c3eab5dd24eddb20baf342aca57c0dd39fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174885
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [3233383b2631788e7cfb0dd0b92d879322561616]

        tdf#160127: Improve grammar check popups from Duden
        
        When there is a grammar check error that it has no suggestions for, Duden
        may return a JSON without suggestions, but still informing about the type
        of the error, like
        
          ...
          {
              "offset": 468,
              "length": 8,
              "errorcode": 21,
              "type": "orth",
              "proposals": []
          },
          ...
        
        Before the change, we underlined the error, but right-clicking it would
        only bring the normal Writer's context menu, as if there were no error.
        This was made in commit 7697ef9d8fbbed7afba10c00ff9f5362d0540cdd (Proof
        reading suggestions:, 2023-11-28); before that change, the context menu
        was shown, but since it had no suggestions, and no explanation text, it
        was considered better to just not show the grammar check results. But
        no menu for an underlined word is no better; so let's instead show the
        explanation, based on the type of the error reported by Duden - that is
        stored in SingleProofreadingError::aShortComment. Also set aFullComment,
        which is used in the grammar check dialog.
        
        Incidentally, it even improves popups with suggestions, because it now
        has the explanation as well, where previously only was an icon without
        any text.
        
        It may be further improved in a follow-up, because there is "errorcode"
        in the message, which we may use to add more details to the explanation.
        
        tdf#160127 should be fixed with this, too; but if there are cases when
        there are neither suggestions, nor explanation available, it will need
        further work.
        
        Change-Id: I62cde204e0142d6226c9c9486f1cdb5ffc20dca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175017
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-16  Jean-Pierre Ledure  <jp@ledure.be>  [fc36eed73e5033a34698c30801f159d533018b08]

        ScriptForge session.ExecuteCalcFunction error handling
        
        1) Error handling in the ExecuteCalcFunction()
           function must be conditioned by the global
           error handling.
           True; display a user-friendly message
           False: abort on the erroneous line
        
           So far, an ambiguous error message was displayed
           in both cases.
        
        2) Above ambiguous error message was corrupted
           by the detour to SF_Array.Prepend() method
           in exc.RaiseFatal() and exc.RaiseAbort().
           A simple workaround fixes the ambiguity
           about the name of the faulty routine.
        
        Change-Id: Iab38b48e6291e1960fc288696a7ebd18ffe8ebae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175020
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [3889920c386ff208e9aed5c1a62355a730a6a22d]

        SwModelTestBase: drop isExported
        
        Change-Id: I4eb169909abff3eba935e4ad5ff7875b1b122953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175019
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb6db3aa4c86b92e8321d6734bcb34ba28dfeb27]

        tdf#163381 XBitmap.getMaskDIB() is inverted
        
        regression from the transparency->alpha work
        
        Change-Id: I2aaf8262191ca6136f87c59629e95bd9a7e7e419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174991
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-16  Abrar Emad  <eng.abraremad.ae@gmail.com>  [8e2369a7813ba7dca75ac30b5ae2a26e181503c6]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I9df35198804cca98cd71c19fa4ef74fb6f47fd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175013
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [d0ffbb841af2a3ca0c87b6d7275b33259a180892]

        ooxmlexport: drop isExported (part 2)
        
        Change-Id: I253b5a10214f494b1a9a77b09241cf6cdaa4dc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175018
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c4fac1e9f50832852e87452f3152f01b905f9e6]

        loplugin:unusedmethods
        
        Change-Id: I6ba4b4046190b701d4a15c6fa90b6009ecf4ab1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [44bb2c82870f83776eb26d41aeb9defbee97b102]

        loplugin:unusedfields
        
        Change-Id: If05b87f1e6c19b15b03b2695921a582e078d0f1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175011
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [49c0e81e7d25def3ec85b0c06c82053a7246f030]

        sw: drop DECLARE_FODFEXPORT_TEST macro
        
        Change-Id: I0b232aa689ffc70a2cfca1af5ba5529e34060371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175015
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2455a0d8e1fcc63e41b39ebf2cf8cc669803ad58]

        Drop extra quoting
        
        ...introduced in 074714fab8db751e2aa0138391a270124733977d ".NET Bindings: Create
        nuget package for LO SDK".  The assumption is that none of the variables used in
        that block of code represent paths that contain characters that would need any
        form of quoting.  (And if they did, the solution would not be to just wrap them
        in "..." quoting, but to use '...' and escape any contained ' properly.)
        
        Change-Id: Ie5b972c53a60c8c9a4bcfa03627a8e1998646285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175010
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [740c030e302cba0ee29ef8aa4288626cc5b4e3f7]

        ooxmlexport: drop isExported (part 1)
        
        Change-Id: I2c40a9290c89e4fd4da18de9f3cb2d735182bdf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175012
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0af36ddc635bd1d1e8399fd5687a71755cf5a26]

        rtfexport: drop isExported
        
        Change-Id: I5b5fd5e866c2e6c8df247fa70370d7404eb88423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174992
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-16  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [92f6b0ae399281fe49398ab1e009e1e5e14960b9]

        jsdialog: support textWithIconEnabled into Dump icon view
        
        Change-Id: Ib005da05fe500aae5729095533aab05578e567d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171679
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-16  Oliver Specht  <oliver.specht@cib.de>  [a157f82649e33f05c40aba7fc152733f38fe3f67]

        tdf#159286 FORMTEXT selection changed
        
        As long as FORMTEXT has default content of 5 en spaces a click
        selects the content. If the content has changed then the cursor is
        placed at the mouse position.
        
        Change-Id: If0e7717d04d29887b63ec20ed6b82c625400421a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173812
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b4161616bca8ee6404a0a4e4a167b5822f9a8b9]

        odfexport: drop isExported
        
        Change-Id: I5d143e9ede6fa9decf994afbe67f8c4116f2d4d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175009
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [9018cf4d1c39a21e22c720ddcaaa696bb8ea5761]

        ww8export: drop isExported
        
        Change-Id: I3eb65c8d9666d6f0a22360a691938e9e82ccd3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174990
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-16  László Németh  <nemeth@numbertext.org>  [1fb6de02709a5f420f21ebd683915da50ce0d198]

        tdf#163149 sw smart justify: fix line shrinking at image wrapping
        
        Limited line width at image wrap could result negative nSpaceAdd
        value, i.e. paragraph line with extra letter spacing instead of
        line shrinking.
        
        Regression from commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I76cc3004d246ff7af441ca9a92eaa8fc7b09f01b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174985
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-16  Miklos Vajna  <vmiklos@collabora.com>  [c8549fa3204802daec8597ba0f9f4f7ef23d5cd2]

        tdf#138711 sw textbox: capture fly when its draw object is captured
        
        Load the bugdoc, notice that the only shape in the document has a
        captured (inside the page frame) draw shape, but its inner fly frame is
        not captured inside the page frame, so a small top margin is paired with
        a larger right margin, which is unexpected.
        
        This is nominally a regression from commit
        9835a5823e0f559aabbc0e15ea126c82229c4bc7 (sw textboxes: reimplement ODF
        import/export, 2014-10-04), because previously the ODF markup for Writer
        TextBoxes were ignored, so we had correct position of the shape text at
        the price of losing complex content.
        
        Fix the problem similar to what commit
        a0b6587c4acb1d74e1b00904147821640c98b323 (tdf#161199 sw
        DoNotCaptureDrawObjsOnPage: capture wrap=none draw objects, 2024-06-13)
        did: if we detect that the fly frame is part of a TextBox, then work
        with the wrap type of the draw format, since these inner fly frames
        always have their wrap type set to "through".
        
        This fixes the unexpected position of the fly frame and keeps the import
        of complex content working.
        
        Change-Id: Ib0d861af0fac74d93a09178c10bc19a1b45e3ce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174987
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-16  Michael Weghorn  <m.weghorn@posteo.de>  [71d69554b25a59a8c8a594b3dc4394dcd3b65acb]

        gtk3 a11y: Drop unused DocumentFocusListener class
        
        Code calling the ctor was dropped in
        
            commit 4aa2cc878dae3b34b16ccacd9358fda5e6d6a197
            Date:   Thu Jun 20 10:46:59 2024 +0200
        
                loplugin:unusedmethods
        
        which dropped GtkSalData::GetDocumentFocusListener
        unused since
        
            commit c45c64aeb57dce91965d7be54601128946455c90
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        Change-Id: Iee8134371fce26cb21481695ab8379d4fc61065c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-16  Ashok  <ashokemailat@yahoo.com>  [ef36357ee9420956021560b5165708de19a62dc3]

        tdf#132293 Remove unused import from uitest
        
        Change-Id: Id248ccedd7e99a434528c2afb0d1b00631c927de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174984
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1e3f25b6591824be4455885e4d137f00fa4ff2da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4749ae5515f9e251131009425a1a558ff1434170
          - More typos and mute translation
            
            Change-Id: I6ec87cad813dad733fec52e5bc2adfd6f7ec0902
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174949
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6e069effb5f1daced33baa02a1d68ed31683d023]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ca20dece0550ecd127c85d835157b1ab648cf18
          - Typos
            
            Change-Id: I95d519d165bc0f7d331147392010e02b0cca1018
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174948
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f42f031ed1b9f374f3fcba9c814dc5862492026]

        tdf#100894 speed up style tree creation
        
        by using bulk_insert_for_each() more aggressively.
        
        Reduces the open time from several minutes to 18s on my machine.
        
        I had to pass down a flag, because the gtk and the gen weld
        backends work differently, and the gen backend absolutely
        has to know up front if the inserter function is going to
        call set_text, otherwise it asserts in SvTreeListBox::SetEntryText
        
        Change-Id: I84750888c0a80f4041cfe024e6570dd94f6d09db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-16  Patrick Luby  <guibmacdev@gmail.com>  [34b95e12a839cbcf4818bbb0b2ce26b85999e856]

        On macOS the "cp" command does not have a "-T" option
        
        Change-Id: Id7d81c23e79569a74c26e5a69890b3b41f4b2aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174982
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-10-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [337162e50b38875f626a64667ddb83f8930eab35]

        CppunitTest_sw_ooxmlexport13: fix dead code
        
        isExported() always returns true after loadAndReload
        
        Change-Id: Ia1ca4e5d1efa9dc4a8131574fac8c226aebada03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174983
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-16  Justin Luth  <justin.luth@collabora.com>  [bd6349d3fe1e2c9278aa333e2daf6a9e1a413075]

        tdf#121741 sd: not modified when leaving an empty placeholder
        
        When you ENTER a placeholder, it removes the placeholder text.
        In that case it doesn't treat this as a change
        (because SdrObject::SetOutlinerParaObject is never called).
        
        However, when you LEAVE the placeholder,
        it puts the placeholder text back in.
        This was being treated as a modification event (x2).
        
        I tested what happens if you delete text
        and then leave the placeholder.
        The deleted text is already handled before we can leave the placeholder,
        so that doesn't cause any concern.
        
        TODO: an undo event is also created.
        
        Change-Id: I366eb7a174284dc07415342258fcf65e50641be6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174860
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [21b5bb33f7ba3dbc3e888449b662df3a57755a1c]

        CppunitTest_sw_ooxmlexport12: simplify a bit
        
        Just use CPPUNIT_TEST_FIXTURE
        
        Change-Id: I3491c6c151b28f86866fd846fc12011ef69e93b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174980
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a473fa08642485e73427ee6bf4cba95192c0264]

        CppunitTest_sw_ooxmlexport12: remove dead code
        
        After calling loadAndSave, isExported always returns true
        Code added in 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving"
        If it's changed to check the layout from parseLayoutDump instead
        of the export, it also fails
        
        Change-Id: I0f8248db44ab299c3b6a6ed0901357d6e153e1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174979
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [013b832878f3d63ab9db4cf1866ce09c29a7df56]

        cid#1555171 double-locked-pattern Data race condition
        
        Change-Id: I2ef54091535cf511a74e19a037647d5baff9a825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174971
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0e97c24f2350e5a5c5f16812ca04b1cdfc559689]

        Remove duplicated include
        
        Change-Id: I573df37f25f4c2b4867b235627f81b7117013d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174967
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [85e4167c648eb7fff2f5537773c008e4b51abc21]

        Fix typo
        
        Change-Id: I2d58d52d5f331ae9b3f3c4d3dc91d86c075c2a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174968
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c0b61503c36a84c79917cd4c583a5eaccf5b458]

        Fix typo
        
        Change-Id: I30754af84f6f908de4200c025b84ccaf25bd1a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174975
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e2d0a65e349d78f18bc2157569dab687d6165e9]

        svx: check SfxObjectShell::Current()
        
        Change-Id: Ie8e504491d350d582620a5c421d6243239d437d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174976
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5f45b816e6e26439fa9e6e594b6972b100d13af]

        unoxml: port testXProcessingInstruction from java to c++
        
        Change-Id: I2112ac35f046ea0a9c3892c53e4c14a2c1b9e258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174972
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-15  Weblate  <noreply@documentfoundation.org>  [7a749b0c3427729b43e6b7ba537a1786eaddde95]

        android-viewer translated using Weblate
        
        Indonesian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I072e698547ef9bc602168563245aec265aac6db2
        Co-authored-by: Andika Triwidada <andika@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/id/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174780
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ff84bee9a22dfc5f383407fd4d390a0a78bcaddd]

        cid#1557492 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I093583db8ca8d244d05e8df365c35cdf3b4d6fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174969
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [28d8a59d9cd3819dc558e397a6b14cef17c55245]

        cid#1557682 alt fix for Initialization or destruction ordering is unspecified
        
        Change-Id: Ibbcc3808a7a7ec71a046b263757506f61ac48093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174970
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-15  Pranam Lashkari  <lpranam@collabora.com>  [570261954089695377cd6910b95fd3b6ee864062]

        sc: make sure autofilter color area is caluculated
        
        problem:
        in autofilter popup entries were made before color area was correctly extended
        
        Change-Id: I38f27666109e99e22e16804c0fdf8df9840864f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174755
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8903ddff872d579b06bd3acc413d3d14f4284228)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174781
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-10-15  Patrick Luby  <guibmacdev@gmail.com>  [633fad32611e39620218319327428050405a6b1a]

        Stop hiding of child windows when dragged to a different screen
        
        LibreOffice sets all dialog windows as a native child window of
        its related document window in order to force the dialog windows
        to always remain in front of their releated document window.
        
        However, for some unknown reason, if a native child window is
        dragged to a different screen than its native parent window,
        macOS will hide the native child window when the drag has ended.
        
        So, once the current drag has finished, unattach and reattach
        the native child window to its native parent window. This should
        cause macOS to force the native child window to jump back to the
        same screen as its native parent window.
        
        Change-Id: Ic859a44f4a0e113146f06cc5d311faf15b9c38dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174914
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-10-15  Michael Weghorn  <m.weghorn@posteo.de>  [8e551d8321ad2b2ea6eb6d64b9390633be3f313e]

        a11y: Drop intermediate local variable
        
        Assign to `xChild` right away and drop
        the extra local variable `pChild`.
        
        Change-Id: I2ac02b12a5e833821f51f35c74269aa67a628122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174963
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9dd7ad6e265d852416e46ee79f7b0cb6d174ca64]

        slideshow: add flag to skip animation rendering
        
        Animations currently don't work yet, so skip rendering them by
        default, or they cause infinite rendering loop in some cases.
        
        Change-Id: Iaf6e7d67197e86c21af65ecd3bba656c23fd74eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174962
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-15  Jean-Pierre Ledure  <jp@ledure.be>  [0f74a4c2bf156f38e188e0a4271ba37cf688181d]

        scriptforge.py Color args in exception.PythonShell()
        
        The
           exception.PythonShell()
        method opens the APSO console.
        
        It receives 2 additional arguments
           background
           foreground
        which specify the back- and foreground colors
        of the window to open as a Python console.
        
        Typical use of the method:
           exc.PythonShell({**globals(), **locals()}, \
               background = 0x0, foregound = 0xFFFFFF)
        opens the shell with all existing variables
        loaded and with white characters on a black
        background.
        
        The default values are those set in APSO:
           background = 0xFDF6E3
           foreground = 0x657B83
        No impact on existing scripts.
        
        The current change requires to be completed with
        the addition of the 2 arguments in the
        adequate help page.
        
        Additonal minor changes
        - typo in scriptforge.pyi
        - 'outsideprocess' replaced by 'remoteprocess'
        
        Change-Id: I9b1be123f049aa39bd0d814b6dd63fcc4f4ea310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174897
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-10-15  Miklos Vajna  <vmiklos@collabora.com>  [f8088294eb803eea9c8629bd25bc96f80bdd6604]

        svx: prefix members of Camera3D
        
        See tdf#94879 for motivation.
        
        Change-Id: I87d734dbfffb2335fb5e4d69c1ad753b52256ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174961
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-15  Szymon Kłos  <szymon.klos@collabora.com>  [693b230aed7b1ca5b6f1a95ed1a76d938f5a6645]

        Fix button alignment in the manage conditions dialog in Calc
        
        Change-Id: I562f5a21a625800107e5974ce76853a554411972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169780
        (cherry picked from commit 9b7904e0c14373492c886a2ed2f4fd040b54825b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174941
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-10-15  Pranam Lashkari  <lpranam@collabora.com>  [2ac55839b4fd6d4c13c8e1d92350a6ddaebb35d5]

        sc: give warning about condition input in easy condition dialog
        
        Change-Id: I3cea0ae966951b5ff554f4ce9aeec5a1ed11ca13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174779
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174906
        Tested-by: Jenkins

2024-10-15  Michael Weghorn  <m.weghorn@posteo.de>  [fc4ac9a331d6a81358ef437a5f8ffa32be15a487]

        vcl: Drop "value_type" typedefs in PPD classes
        
        Both of them are used only a single time, so
        just use the actual type right away.
        
        Change-Id: I32385580fa3a7919896f281ee4f318878b01fc1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174899
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-15  Pranam Lashkari  <lpranam@collabora.com>  [4bc4472108d67d8a95594ccc55ae07fbc1be56f7]

        loplugin:ostr in sc
        
        Change-Id: I9398b112be1329fff914d2014fcc0f59f27a968a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-15  Michael Weghorn  <m.weghorn@posteo.de>  [8bb38e1b3f1ba1d9c563598d161230fdf27e4685]

        tdf#163397 svx: Use field color for WeldEditView bg
        
        Use field color instead of the window color
        for the WeldEditView background.
        
        This is consistent with the color used for the other
        text edit controls like the VCL Edit, see
        Edit::ApplySettings.
        
        While field and window color are the same color for e.g.
        gtk3 or gen, they're different colors for macOS and
        Qt-based VCL plugins, at least when using the Breeze
        style that's default on KDE Plasma.
        
        With this commit in place, the background color becomes
        white for macOS and Linux with the qt5 VCL plugin with the
        Breeze style.
        
        For the latter, this had changed to light grey with
        
            commit 9dd26d7a2cc6b314dcc0b52000e0475bb4ced57d
            Date:   Thu Sep 5 01:37:44 2024 +0530
        
                Libreoffice Theme Part 0: Read correct colors from qt based VCL_PLUGINS
        
        Change-Id: I42232fd07891046b18cc7f112118cac673e2090d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174890
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-15  Szymon Kłos  <szymon.klos@collabora.com>  [6c1e3cd597cba07ff637173ab298794dba463054]

        lok: calc: fix formulabar after accept formula command
        
        Steps to reproduce:
        1. open calc
        2. start typing into cell
        3. click "accept formula" button
        4. click again at formulabar
        5. try to type
        
        result: no text is shown
        expected: can edit formula
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I52cffef5a3a7d1f4ffa88675964090e68c0e1f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174886
        (cherry picked from commit ce9ab2c38a2886e5eab3cae4f09b975d31840633)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174798
        Tested-by: Jenkins

2024-10-15  Jim Raykowski  <raykowj@gmail.com>  [dfeefe2e97a5412a445a3a508acb2d9ae05138e5]

        tdf#163191 Fix crash when dragging headings in Writer navigator
        
        by keeping track of the selected entry positions in SwOutlineNodes
        instead of iterators in the content tree.
        
        Change-Id: Iad0a477d6e3b25a1d602e3f827f2590c441eb236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174912
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-10-14  Jim Raykowski  <raykowj@gmail.com>  [c69b16a0f859d71a101e2c138887e7975ec71e2a]

        Resolves tdf#163411 NAVIGATOR: In Content Navigation View buttons to
        
        move heading disappear after first use
        
        Change-Id: I816ff3a7e5016d6316b63c49e5620617fe5a068f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174907
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-10-14  Eike Rathke  <erack@redhat.com>  [3275267d47c0bce28193dd6651e42b8a0f6c587d]

        Move {sat-IN} locale data to {sat-Olck-IN}, tdf#154987 follow-up
        
        ... and have inherited {sat-IN} as well as {sat-IN} locale data was
        introduced for tdf#154987 and may have been used by documents since 7.6,
        but {sat-IN} originally was meant for Devanagari script, as translations
        show.
        
        Change-Id: I7618d061b3eefa1ad2d49f97c9c1198361c8de36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174903
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-10-14  Noel Grandin  <noelgrandin@gmail.com>  [40931f8324c91ba69e99a07a41abcafe0200ab98]

        fix comment
        
        the original function was removed in
            commit 47bfbbdb73380335196887b36c4d14530c0461ec
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Feb 23 13:05:55 2024 +0200
            Create an UNO service to do the cui symbol lookup in vcl
        
        Change-Id: I0f72318fd3eae0c8b34624cc8f05800b9de4d0ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174904
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8af3358203e71564b69ae4a687989a57a2a8605e]

        tdf#100894 reduce time spent iterating styles
        
        Small difference, but an easy optimisation
        
        Change-Id: Ic5aeb759fb64af378a6cfcd83977d917be1b9a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174888
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [7122fcf862ce970c230f21ce4c47469cae4fa4f0]

        Avoid deadlock because of recursive lock
        
        As seen in the following call stacks:
        
        Main thread
        
          sal3!osl_acquireMutex+0x49 [libre-office-git-repo\sal\osl\w32\mutex.cxx @ 65]
          emboleobj!osl::Mutex::acquire+0x9 [libre-office-git-repo\include\osl\mutex.hxx @ 63]
          emboleobj!osl::Guard<osl::Mutex>::{ctor}+0x9 [libre-office-git-repo\include\osl\mutex.hxx @ 144]
          emboleobj!OleEmbeddedObject::getCurrentState+0x68 [libre-office-git-repo\embeddedobj\source\msole\oleembed.cxx @ 643]
          sfxlo!SfxInPlaceClient::IsObjectUIActive+0x23 [libre-office-git-repo\sfx2\source\view\ipclient.cxx @ 847]
          sfxlo!SfxViewShell::GetUIActiveClient+0x5b [libre-office-git-repo\sfx2\source\view\viewsh.cxx @ 2521]
          sfxlo!SfxDispatcher::FindServer_+0x282 [libre-office-git-repo\sfx2\source\control\dispatch.cxx @ 1627]
          sfxlo!SfxDispatcher::GetShellAndSlot_Impl+0x2f [libre-office-git-repo\sfx2\source\control\dispatch.cxx @ 703]
          sfxlo!SfxDispatcher::QueryState+0x5b [libre-office-git-repo\sfx2\source\control\dispatch.cxx @ 1979]
          swlo!SwView::CheckReadonlyState+0x64 [libre-office-git-repo\sw\source\uibase\uiview\view.cxx @ 627]
          swlo!SwView::TimeoutHdl+0x76 [libre-office-git-repo\sw\source\uibase\uiview\view.cxx @ 608]
          vcllo!Scheduler::CallbackTaskScheduling+0x130e [libre-office-git-repo\vcl\source\app\scheduler.cxx @ 511]
          vclplug_winlo!WinSalTimer::ImplHandleElapsedTimer+0x2e [libre-office-git-repo\vcl\win\app\saltimer.cxx @ 167]
          vclplug_winlo!ImplSalYield+0x14f [libre-office-git-repo\vcl\win\app\salinst.cxx @ 525]
          vclplug_winlo!WinSalInstance::DoYield+0xad [libre-office-git-repo\vcl\win\app\salinst.cxx @ 581]
          vcllo!ImplYield+0x367 [libre-office-git-repo\vcl\source\app\svapp.cxx @ 393]
          vcllo!Application::Execute+0xfa [libre-office-git-repo\vcl\source\app\svapp.cxx @ 369]
          sofficeapp!desktop::Desktop::Main+0x173f [libre-office-git-repo\desktop\source\app\app.cxx @ 1605]
          vcllo!ImplSVMain+0xda [libre-office-git-repo\vcl\source\app\svmain.cxx @ 229]
          sofficeapp!soffice_main+0xf3 [libre-office-git-repo\desktop\source\app\sofficemain.cxx @ 94]
        
        Request thread
        
          sal3!osl_acquireMutex+0x49 [libre-office-git-repo\sal\osl\w32\mutex.cxx @ 65]
          vclplug_winlo!osl::Mutex::acquire+0xa [libre-office-git-repo\include\osl\mutex.hxx @ 63]
          vclplug_winlo!SalYieldMutex::doAcquire+0x91 [libre-office-git-repo\vcl\win\app\salinst.cxx @ 148]
          emboleobj!SolarMutexReleaser::{dtor}+0xc [libre-office-git-repo\include\vcl\svapp.hxx @ 1425]
          emboleobj!OleComponent::GetExtent+0x102 [libre-office-git-repo\embeddedobj\source\msole\olecomponent.cxx @ 1134]
          emboleobj!OleEmbeddedObject::getVisualAreaSize+0x23f [libre-office-git-repo\embeddedobj\source\msole\olevisual.cxx @ 227]
          emboleobj!OleEmbeddedObject::saveCompleted+0x406 [libre-office-git-repo\embeddedobj\source\msole\olepersist.cxx @ 1603]
          comphelper!comphelper::EmbeddedObjectContainer::StoreEmbeddedObject+0x49b [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 501]
          comphelper!comphelper::EmbeddedObjectContainer::InsertEmbeddedObject+0x6f [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 518]
          comphelper!comphelper::EmbeddedObjectContainer::RemoveEmbeddedObject+0x388 [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 945]
          comphelper!comphelper::EmbeddedObjectContainer::RemoveEmbeddedObject+0x46 [libre-office-git-repo\comphelper\source\container\embeddedobjectcontainer.cxx @ 831]
          swlo!SwOLENode::SavePersistentData+0x20b [libre-office-git-repo\sw\source\core\ole\ndole.cxx @ 403]
          swlo!SwNodes::ChgNode+0x411 [libre-office-git-repo\sw\source\core\docnode\nodes.cxx @ 214]
          swlo!SwNodes::MoveNodes+0x18e6 [libre-office-git-repo\sw\source\core\docnode\nodes.cxx @ 868]
          swlo!SwUndoSaveContent::MoveToUndoNds+0x1c1 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 784]
          swlo!SwUndoSaveSection::SaveSection+0x559 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 1325]
          swlo!SwUndoSaveSection::SaveSection+0x55 [libre-office-git-repo\sw\source\core\undo\undobj.cxx @ 1278]
          swlo!SwUndoFlyBase::DelFly+0x127 [libre-office-git-repo\sw\source\core\undo\undobj1.cxx @ 232]
          swlo!SwUndoDelLayFormat::SwUndoDelLayFormat+0x64 [libre-office-git-repo\sw\source\core\undo\undobj1.cxx @ 429]
          swlo!std::make_unique+0x22 [C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\memory @ 3382]
          swlo!sw::DocumentLayoutManager::DelLayoutFormat+0x283 [libre-office-git-repo\sw\source\core\doc\DocumentLayoutManager.cxx @ 242]
          swlo!SwTextNode::DestroyAttr+0x82 [libre-office-git-repo\sw\source\core\txtnode\thints.cxx @ 1204]
          swlo!SwTextNode::EraseText+0x18f [libre-office-git-repo\sw\source\core\txtnode\ndtxt.cxx @ 2813]
          swlo!SwTextNode::DeleteAttributes+0x115 [libre-office-git-repo\sw\source\core\txtnode\thints.cxx @ 1863]
          swlo!SwXFrame::dispose+0xdb [libre-office-git-repo\sw\source\core\unocore\unoframe.cxx @ 2692]
          mscx_uno!`anonymous namespace'::cpp_call+0x710 [libre-office-git-repo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx @ 214]
          mscx_uno!unoInterfaceProxyDispatch+0x2fa [libre-office-git-repo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx @ 430]
          binaryurplo!binaryurp::IncomingRequest::execute_throw+0x635 [libre-office-git-repo\binaryurp\source\incomingrequest.cxx @ 239]
          binaryurplo!binaryurp::IncomingRequest::execute+0xbf [libre-office-git-repo\binaryurp\source\incomingrequest.cxx @ 79]
          binaryurplo!request+0x1c [libre-office-git-repo\binaryurp\source\reader.cxx @ 84]
          cppu3!cppu_threadpool::JobQueue::enter+0x21e [libre-office-git-repo\cppu\source\threadpool\jobqueue.cxx @ 101]
          cppu3!cppu_threadpool::ORequestThread::run+0xa0 [libre-office-git-repo\cppu\source\threadpool\thread.cxx @ 169]
        
        As seen, the request thread has OleEmbeddedObject::saveCompleted
        and OleEmbeddedObject::getVisualAreaSize on the stack; both acquire
        OleEmbeddedObject's mutex; but only getVisualAreaSize releases it
        for the call of OleComponent::GetExtent. The latter releases solar
        mutex, at which time, the main thread (locking the solar mutex)
        attempts to call OleEmbeddedObject::getCurrentState, which needs
        the object's mutex, which is still locked in the request thread.
        
        Avoid this, by passing the lock object to the implementation of
        getVisualAreaSize from saveCompleted.
        
        Change-Id: Ie44a20a8c89000e0e951e024c2bfde93cf2cc3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174891
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [aed0110831b06105890c9972d3eee477f0c0bbc0]

        Reorder to avoid useless assignments immediately reassigned
        
        Change-Id: Ia89e8d0ca5da12fdecc82f174d04f365ba682fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [c5703bbeebc6b4976dbf7cafb2e0bfda6345f864]

        Dereference before nullptr check
        
        After commit 2c8c436c4a8546276e285dd18f3f7ded091a2c4e (tdf#152992:
        for Impress/Draw add horizontal hit tolerance for quick text edit,
        2023-07-21).
        
        Change-Id: Ia19bca115f95c53851dc63cdc7e4336f0289d731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174793
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [17c4536ebd342bb917df0f5978b1b1b7281ef2b9]

        wsl-as-helper: fix paths to module/Makefile in builddir!=srcdir case
        
        while regular "make module" commands don't make use of those Makefiles
        (and instead cd to $srcdir/module before running make there), some
        users run "make -C module -rs SUBTARGET" in which case they would be
        read.
        autogen.sh did create wsl-style paths that the windows side can't
        resolve. So make sure to convert them to windows-style paths when
        running inside wsl with ming64 in path (=autogen is running inside wsl,
        but was started from windows-side, to distinguish from the case where
        autogen is started from within wsl to create a linux build)
        
        Change-Id: I0b3d9fda9bc22ebd27edaaad75233a84b33e61c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174900
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-10-14  Eike Rathke  <erack@redhat.com>  [8afc6cb5aa869b071caac38f248db566dbe13fd8]

        Add Santali, Ol Chiki {sat-Olck-IN} [0x06B3] to language list
        
        Change-Id: I3924672759bc12f1ee8a022e8b35c862aefff06d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174901
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3aa81e4735ea895a71852b18ed029ae15e53c7b4]

        cid#1607242 Overflowed return value
        
        Change-Id: I9efb14bf8395168043e8b3dbe94e7eb84577a175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c7cf67e9cda47df632b582d2bc0dc0233168b2a]

        cid#1607017 Overflowed integer argument
        
        Change-Id: I20af21e740e77e2b190c613346ed57bcd40b2a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174892
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6402a656cd0083001aaa6eeaac188ee16fcbfc8c]

        cid#1607163 Overflowed return value
        
        Change-Id: I403a2c5bb55e3a80d3bf99302b262aa507812d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174895
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-14  Marc Mondesir  <timepilot3000@gmail.com>  [274781b3082e36a150e08814dbdcb0c85536d2a0]

        tdf#119745: Use scroll distance from Windows to calculate scroll lines.
        
        Calculate lines scrolled using scroll distance from Windows message instead of fixed value. Use Windows macros for mouse wheel distance and modifier keys (from Microsoft WM_MOUSEWHEEL dev page).
        
        Change-Id: I30ddf1641103a15549f38983c60c35e0d514bb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174713
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-14  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [1b648b3705039cf8f708e57f1c91910cfe73b25b]

        tdf#114441 change the sal_uLong to tools::Long and sal_Int32 in svtools
        
        Change-Id: I1f5e2233b34e115723f3c1b49b7f0f982e16cfcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174264
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-10-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [9790e2275384f6687aab9c5a7b4fc3b6ff5df981]

        tdf#163413 Fix copy & paste error in Display Snap Guides toggle code
        
        Change-Id: Icb2c549c3b510a33f3be519f5582374d6a096f35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174870
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ab83b467e39d03953178f83f03b2fe4c4c9b6e5]

        shave some time off SdStyleSheet::setParentStyle
        
        much of the time the construction of curMaster isn't needed
        
        a similar mega-master-page scenario as reported in tdf#158773
        
        50s -> 48s
        
        Change-Id: Iedb1d0cf189eec7a9abca1836295d7afacdc301c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-14  Michael Stahl  <michael.stahl@allotropia.de>  [279f42fa8b19d4fe81c3bba4c7af21aa8ab135b9]

        tdf#163341 package: fix reading Zip64 produced by stream-write-ods
        
        1. Accept 0xFFFF as nEndDisk/nEndDirDisk - the Zip APPNOTE says that
           values that don't fit into 16 bits SHOULD be 0xFFFF but it doesn't
           prohibit values that do fit (like, uhm, 0) to be written as 0xFFFF
        
           (regression from commit ca21cc985d57fffe7c834159b17c095206304994)
        
        2. Fix misuse of o3tl::make_unsigned - it requires non-negative value,
           just do signed compare instead
        
        3. Fix bad conversion from pointer to optional in
           ZipFile::readExtraFields() which effectively prevented the offset
           from being read
        
           (regression from commit efae4fc42d5fe3c0a69757226f38efc10d101194)
        
        Change-Id: Ib5e7776a30834e507b297fb28266b5489d1ab68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174898
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23d7910c1e1fc41ab3b7b931cb91e007e09a4086]

        cid#1554844 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554878 COPY_INSTEAD_OF_MOVE
        cid#1554907 COPY_INSTEAD_OF_MOVE
        cid#1555082 COPY_INSTEAD_OF_MOVE
        cid#1555224 COPY_INSTEAD_OF_MOVE
        cid#1555301 COPY_INSTEAD_OF_MOVE
        cid#1555378 COPY_INSTEAD_OF_MOVE
        cid#1555395 COPY_INSTEAD_OF_MOVE
        cid#1555452 COPY_INSTEAD_OF_MOVE
        cid#1555466 COPY_INSTEAD_OF_MOVE
        cid#1555514 COPY_INSTEAD_OF_MOVE
        cid#1555566 COPY_INSTEAD_OF_MOVE
        cid#1555753 COPY_INSTEAD_OF_MOVE
        cid#1555782 COPY_INSTEAD_OF_MOVE
        cid#1555825 COPY_INSTEAD_OF_MOVE
        cid#1555842 COPY_INSTEAD_OF_MOVE
        cid#1555891 COPY_INSTEAD_OF_MOVE
        cid#1555917 COPY_INSTEAD_OF_MOVE
        cid#1555961 COPY_INSTEAD_OF_MOVE
        cid#1556021 COPY_INSTEAD_OF_MOVE
        cid#1556055 COPY_INSTEAD_OF_MOVE
        cid#1556307 COPY_INSTEAD_OF_MOVE
        cid#1556349 COPY_INSTEAD_OF_MOVE
        cid#1556436 COPY_INSTEAD_OF_MOVE
        cid#1556665 COPY_INSTEAD_OF_MOVE
        cid#1556696 COPY_INSTEAD_OF_MOVE
        cid#1556718 COPY_INSTEAD_OF_MOVE
        cid#1556775 COPY_INSTEAD_OF_MOVE
        cid#1556835 COPY_INSTEAD_OF_MOVE
        cid#1556877 COPY_INSTEAD_OF_MOVE
        cid#1556994 COPY_INSTEAD_OF_MOVE
        cid#1557010 COPY_INSTEAD_OF_MOVE
        cid#1557074 COPY_INSTEAD_OF_MOVE
        cid#1557111 COPY_INSTEAD_OF_MOVE
        cid#1557142 COPY_INSTEAD_OF_MOVE
        cid#1557163 COPY_INSTEAD_OF_MOVE
        cid#1557164 COPY_INSTEAD_OF_MOVE
        cid#1557214 COPY_INSTEAD_OF_MOVE
        cid#1557254 COPY_INSTEAD_OF_MOVE
        cid#1557322 COPY_INSTEAD_OF_MOVE
        cid#1557327 COPY_INSTEAD_OF_MOVE
        cid#1557492 COPY_INSTEAD_OF_MOVE
        cid#1557565 COPY_INSTEAD_OF_MOVE
        cid#1557663 COPY_INSTEAD_OF_MOVE
        cid#1557798 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I2ae9c184dcc18d44a65437e18c49e16b27f4d81d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174893
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-14  Michael Stahl  <michael.stahl@allotropia.de>  [3efad499bf4f7623610a54f9f14622de4954352f]

        tdf#163364 package: ask to recover for this invalid ODF package
        
        Bugdoc has a data descriptor on a folder entry, which is very odd and
        entirely pointless.  Which is also the first entry, so it's an invalid
        ODF package anyway.
        
        ZipPackageFolder throws UnknownPropertyException for "WasEncrypted",
        which results in General I/O error, but we want to ask the user if the
        file should be opened in recovery mode.
        
        (regression from commit 32cad89592ec04ab552399095c91dd76afb3002c)
        
        Change-Id: Iafe610d507cf92d2fd2e9c3040592c3e638a30dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174889
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-10-14  Noel Grandin  <noelgrandin@gmail.com>  [574874a554531363f379cba39a4685cdeb0e4806]

        cid#1606629 Overflowed constant
        
        Change-Id: Id0438b5ae8abdba4d9a87584f9586b8a53852ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3ef807504072fcdf09653f88927683ff4f90e503]

        version COVERITY conditionals
        
        so there's a recheck on each major if they are still needed
        
        Change-Id: I351f731fe4eaec0ebf735147a9a168cccba3bca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174883
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [85a2b2222da0e535446ce46bfcc60d13dad714f1]

        cid#1557682 Initialization or destruction ordering is unspecified
        
        Change-Id: I886733628601d551d544b5abf0eae947b49b8ca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174882
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac95c81c5cd9b0e1b9a86a5f138da7cc1d1f4aa0]

        cid#1632252 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I604b3a2065cdd61e0227a474af5acfc486c7f297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174881
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d848dfaa7ce3dc64c5e83f90e1ece69a8171818d]

        cid#1633173 silence Unchecked return value
        
        Change-Id: Ic3779f6922f855ad57b2c261696c76a06dac84f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174880
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-14  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [7001d61fd7dc2dae5b8458b6d504cafb61fb2c76]

        tdf#163346 Remove Thai AutoCorrect for "เพ็ชร"
        
        The correction for "เพ็ชร" caused some proper names to be unexpectedly
        modified.
        
        Change-Id: I785d2e4b54cca3b358ee397718ab0162ea6a8f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174878
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [92f694a300d15f5fa1aa9291fcfd229bbff60b08]

        lok: remove code that renders other slide layers to increase speed
        
        This (temporary) removes rendering the other layers so we speed
        up fetching and rendering of the slides as we will only render and
        send the main slide layer to the online.
        
        Change-Id: I40a809499ae87850922b48785842ae6eead3a001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174879
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-14  Jean-Pierre Ledure  <jp@ledure.be>  [af67aa7cc90775107ce42265d81e30b04fc0f54f]

        scriptforge.py - clarify pipe mode
        
        Introduction of a
          ScriptForge.outsideprocess
        property: when True the actual mode
        is via socket or via pipe.
        
        The property is for internal use only.
        Once set it cannot be changed anymore.
        
        Previous statements similar to
           if ScriptForge.port > 0:
        which returned True when socket mode
        are replaced by a broader
           if ScriptForge.outsideprocess:
        
        No effect on user scripts.
        
        Change-Id: Ice0efd8c2ab9925511fc8c6889cab714fd208ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174874
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c43454149eceb21e8b935d24c864b6e2ad577615]

        ofz#372757014 png_fp_sub Integer-overflow
        
        Change-Id: I0dfe44f8e8f20c137a12eafb4fa108d266f89370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174875
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-14  Miklos Vajna  <vmiklos@collabora.com>  [59c5a7d5c7502770896491a59c73de3c627afcc5]

        Update pdfium to 6764
        
        New fast_float header-only inner dependency.
        
        CppunitTest_vcl_pdfexport's testTdf154549 and
        CppunitTest_vcl_pdfexport2's testTdf71956 started to fail after this.
        Assuming that the code covered by these tests still works (since this
        commit doesn't change vcl/ or sw/ code), just update those tests to
        match the new PDFium API call results for now.
        
        Change-Id: I07b2f97fbbc9bd609e2f94593474393adcb5a839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174814
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f72c9777f510332105b39c1c9bb78c66e4550d82]

        -Werror,-Wdeprecated-literal-operator
        
        Change-Id: I4e2c4c1083587bfddd9f6a355f1ea7888573cc14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174876
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-13  Abraham Samuel Adekunle  <abrahamadekunle50@gmail.com>  [3287deb82ef0ee2048f733ae981961f527888727]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I70338b85b9c0205a7dd2349d10c621ceddacb176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174849
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [0e70c14134e899d3abb443761fe9f6a7249f724a]

        tdf#163410: fix missing text highlight color for outline text
        
        During slideshow, the combination outline text mode, and highlight
        background color never worked. Adding cppcanvas code to handle it.
        
        Change-Id: I9abb45fca4c89d206ebb431ff5675288e5deab43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174872
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-10-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [cf908e81491b62d6eba7161313a88b9b766ff87d]

        vcl: add font effects to mtf dump
        
        Change-Id: Ieb9a5b2e09e5d1d3c7c481b4eeb42e15fa2996d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174871
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-10-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bdbc89b6da2ef4797e496aa0db84069b838b2e73]

        tdf#163375 sc: fix sumproduct crash bacause of non exists token
        
        pair at formula editing.
        
        Check if both formula token truly exists.
        
        Regression commit: ba0ec4a5d2b025b675410cd18890d1cca3bc5a2f
        (tdf#159687 sc formula SUMPRODUCT performance fix: add more binary)
        
        Change-Id: I72d054313f1e9db74aa004dcd8b2012be95c18dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174862
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-13  Noel Grandin  <noelgrandin@gmail.com>  [927974d0bb84f3ee4021d3ef73de310585821576]

        cid#1608387 Overflowed constant
        
        the underflow is deliberate and fine, and there is no easy way
        to restructure this loop, so just use a signed type.
        
        Change-Id: Ib7b7c2e382c606548d73ecbf237146cf6345a223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174854
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-13  Noel Grandin  <noelgrandin@gmail.com>  [3fd420ec6375c1be646eda347805e71cfd9f501e]

        cid#1607998 Overflowed constant
        
        the underflow here is fine, and there is no easy way to restructure
        this code to prevent the underflow without making it very ugly, so
        just use a signed type for the loop variable.
        
        Change-Id: I4e37ce6d440b7a78732066d61729504f58e86c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-13  Noel Grandin  <noelgrandin@gmail.com>  [643cbc920b57a27fb4ff5227232c08afa07fdc49]

        cid#1608032 Overflowed constant
        
        Not sure if what the code is doing is valid, but this change
        fixes the underflow without changing the behaviour
        
        Change-Id: I0553968d9af71d0c5f1bd70703df923482d1a40e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174850
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-13  Noel Grandin  <noelgrandin@gmail.com>  [901483b8d846d22e9ef7bba48e521209fb450c5e]

        cid#1606581 Overflowed constant
        
        Change-Id: Ie00405c54a7f65fe5e852508dc2df5faeae1ca3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d649e297fde11efab2c681605e27e513a183e314]

        update to skia m130
        
        Change-Id: Ibfa3d8f5a86dd7474f5cc288c89eb33a8aa472cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174848
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [4924a9f73fae17c14cc445e2804d4025a17acd30]

        update to skia m129
        
        Change-Id: Iea920a34b11695aba32f15921018cf53f418d09a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174846
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [5009ac0153a6f02f62795e6ea650527c46bd2a5e]

        tdf#130857 qt weld: Set visibility based on "visible" prop
        
        Use BuilderBase::extractVisible to assess and set the visibility
        of a QWidget created from a .ui file.
        
        As described in the GTK 3 documentation of the corresponding
        GtkWidget property [1], the default value is false, i.e. if
        an object is not explicitly set as visible, it should not be
        shown.
        
        This will be needed e.g. by the
        svtools/uiconfig/ui/restartdialog.ui
        dialog shown when toggling experimental mode in
        "Tools" -> "Options" and closing the dialog with
        the "OK" button. Without this preparatory commit,
        using native Qt widgets would result in all the
        labels (with different reasons for restarting)
        being shown at the same time.
        
        This depends on previous commit
        
            Change-Id: Ic7a932556e02f47ee6007b5167f82bef152e1ef0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 11 23:01:44 2024 +0200
        
                tdf#130857 VclBuilder: Move internal child visible logic to base
        
        to not cause buttons in dialogs to become invisible if
        they're contained in the "internal" button box object
        whose visibility is usually not explicitly set to True.
        
        [1] https://docs.gtk.org/gtk3/property.Widget.visible.html
        
        Change-Id: Iff254324a852a2fe73b3d9fcfe499bc8639380b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174834
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [550f2558ef8b87a4e8a2b27210378ef7ba5c47ac]

        tdf#130857 VclBuilder: Move internal child visible logic to base
        
        Move the special handling for internal children in .ui files
        from VclBuilder to the base class and set the "visible" property
        to true for them, instead of directly
        calling vcl::Window::Show.
        
        This allows to have this special logic that
        internal children are visible by default, even
        if the "visible" property is not explicitly set
        in one place, and thus reuse it for QtBuilder as well.
        
        Change-Id: Ic7a932556e02f47ee6007b5167f82bef152e1ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174833
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [cf992140298b14212d99bdbb05253d2cd7863fb7]

        tdf#130857 VclBuilder: Make extractVisible a static helper
        
        ... in the base class BuilderBase, in order to reuse it in
        QtBuilder in an upcoming commit.
        
        Change-Id: I61e73f98be9e4f0e0fd15f92d6d16c4e6e617c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174832
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [bc1437fcf50e0016419c64ee0de534ab4a2802bc]

        tdf#130857 qt weld: Implement QtInstanceBuilder::weld_widget
        
        This will be needed e.g. by the
        svtools/uiconfig/ui/restartdialog.ui
        dialog shown when toggling experimental mode in
        "Tools" -> "Options" and closing the dialog with
        the "OK" button.
        
        Change-Id: Iad2c88f6ea75b9434fee239aa5016ba35d0cae33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174831
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [ff66941536720f14711d0bb14b6514ea37a6c0eb]

        tdf#130857 qt weld: Implement QtInstanceBuilder::weld_button
        
        This will be needed e.g. by the
        svtools/uiconfig/ui/restartdialog.ui
        dialog shown when toggling experimental mode in
        "Tools" -> "Options" and closing the dialog with
        the "OK" button.
        
        Change-Id: I7d7af45c0905c79ecc9dc2927dc6b91fade1684d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174830
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [f60072a76730194acab1c5103812f0d2e3271d18]

        a11y: Send value change event when checkbox value changes
        
        VCLXAccessibleCheckBox implements XAccessibleValue. The value
        returned by VCLXAccessibleCheckBox::getCurrentValue is based
        on the current checkbox state and is 0 if the checkbox is
        unchecked, 1 when it's checked, and 2 when it's indeterminate.
        
        Therefore, also send a VALUE_CHANGED event when the value changes,
        not just STATE_CHANGED events for the CHECKED and/or INDETERMINATE
        states.
        
        With this in place, changing the state of a checkbox (e.g.
        in the "Tools" -> "Options" dialog) now causes the value displayed
        in Accerciser's "Interface Viewer", section "Value" to be updated
        right away when a checkbox is (un)checked when using the qt6 VCL
        plugin, just as is the case for the "checked" state in the
        "Accessible" section in Accerciser.
        (Previously, the new value would only be shown after temporarily
        selecting another object in the a11y tree, then selecting the
        checkbox object again.)
        
        Change-Id: I1a7da3b15a18beb12637a632c1779601ad1f198d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174829
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d06cbf7f0071ea295ab140f8dc3c87593e3ba68]

        update to skia m128
        
        and add a patch to deal with a horrible windows COM header
        preprocessor thing, which resulted in:
        
        $ make skia
        cd C:/libreoffice/libo-core/external/skia && C:/cygwin64/opt/lo/bin/make -j 8 -rs
        [build DEP] LNK:Library/skialo.dll.d
        [build CXX] workdir/UnpackedTarball/skia/tools/window/VulkanWindowContext.cpp
        [build LOC] top level modules: skia
        In file included from C:/libreoffice/libo-core/workdir/UnpackedTarball/skia/tools/window/VulkanWindowContext.cpp:26:
        C:/libreoffice/libo-core/workdir/UnpackedTarball/skia\src/gpu/vk/vulkanmemoryallocator/VulkanAMDMemoryAllocator.h(33,69): error:
              invalid parameter name: 'struct' is a keyword
           33 |                                              const VulkanInterface* interface,
              |                                                                     ^
        C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\combaseapi.h(168,19): note: expanded from macro
              'interface'
          168 | #define interface __STRUCT__
              |                   ^
        C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\um\combaseapi.h(167,20): note: expanded from macro
              '__STRUCT__'
          167 | #define __STRUCT__ struct
              |                    ^
        1 error generated.
        make[1]: *** [C:/libreoffice/libo-core/solenv/gbuild/LinkTarget.mk:403: C:/libreoffice/libo-core/workdir/GenCxxObject/UnpackedTarball/skia/tools/window/VulkanWindowContext.o] Error 1
        make: *** [Makefile:125: skia] Error 2
        
        Change-Id: I48975bd503098a2c38d794307c7c55f60668232a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-12  Noel Grandin  <noelgrandin@gmail.com>  [7970ad40041b87a6ddb6829271208fe3993ed01c]

        cid#1608328 Overflowed constant
        
        Change-Id: I2a69dd73ee915299f803efae891cbbd991f43b2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174772
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [d923c227fa290ffdca175a5b903b5a745e2f4b3a]

        tdf#163337: keep gte attribute when saving to ods
        
        Change-Id: I9565f6dd9b23645b47f232d837553fb4d492dc8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174815
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [cc21552f1f228c86317ee86d2f065e40f26b7aaf]

        CppunitTest_sc_scriptforge_test: remove misleading comments
        
        Copy&paste issue
        
        Change-Id: I2eacb1b96568b010f255eadb41895a88bcd99182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174824
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-12  Laurent Balland  <laurent.balland@mailo.fr>  [01ddc139da08d79457dcae810837f3b5233ef9b0]

        tdf#163203 Add title to Japanese normal Writer template
        
        The title of this template was missing. So only the name of the file was apearing
        in Start Center
        Add also credit and a similar description as simplified Chinese one.
        
        Change-Id: Ia32d052ce057d4274cefbebe17ec91b1ddb68fb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174199
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-10-11  Miklos Vajna  <vmiklos@collabora.com>  [8a6919f39b4b871904a2a4199755ca619aa707e2]

        sw: use ForEachCharacterItem() in SwDoc::ForEachCharacterBrushItem()
        
        Avoids a lot of duplication.
        
        Change-Id: I6f743054b3ea09a6c945006fc2298514b04809e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174802
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-11  Noel Grandin  <noelgrandin@gmail.com>  [3ca44fbba078872e5f91e74d2e92cbef65b0358d]

        cid#1607965 Overflowed constant
        
        Change-Id: I743753e75c8c883c9dd88af8e062b73998e82047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174774
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [becc2cbaf376a5aabe294bcef370e7828c96d289]

        Simplify the "mode" argument of SwTextFrame::AdjustFollow_
        
        Is second bit is never tested separately; and it is only ever set
        together with the first - so a simple boolean is enough.
        
        Change-Id: I6e0ddf50d4e23c862da254acb2e43ed5ceb89b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174810
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-11  Oliver Specht  <oliver.specht@cib.de>  [038473595ed266d15a788d8f97781cbaf066cfe7]

        tdf#152839 add fill cells to tables imported wrongly from RTF
        
        In Word 'invisible' cells at the end of the row are usually marked
        with \trwWidthAN. If that information is missing the table needs to
        get addtional cells to smaller rows. This prevents extension of
        exisition cell to the full width of the table.
        
        Change-Id: I064f3da55665302d8198ed44d9f640a7707c34e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174385
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-10-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a0a781da0a56bc38435e556c22f2e7ad4bd1a31]

        Fix typo
        
        Change-Id: Ia7e162526621b8c6613e59d1bab6712e2d65dbc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174811
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-11  Noel Grandin  <noelgrandin@gmail.com>  [426019a4ed329a5b7af3ce998068ea3479e8bff7]

        cid#1606973 Overflowed constant
        
        Change-Id: Ibb81acb35baaf370beba7042d60a0f99f1d8852b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f052c18cee0a0245b4d26008b3d1cd7290ce64a4]

        Restore an accidentally dropped line in the Skia patch
        
        Regression since commit 4e9a21bb0e4981e834de22c1d666f7a83a2771c5
        (Update to skia m116, 2024-10-07) - actually it was about m117.
        The dropped line initialized fImageCount; and without it, that
        uninitialized variable held whatever garbage was there. E.g., I
        saw a value of 3452816845, meaning that it allocated 3.5 billion
        of VkImage, clearing the memory took about 10 seconds per each
        window initialization (main window creation, menu popup, dialog
        and so on), and crashes.
        
        Change-Id: I1d5fc9c6f29e302c46aa0380e528cac64f58c85b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174803
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9739e57e1029f48295079afe82aca0cb4db94854]

        further winget configuration files to complete the setup
        
        this is still a chicken-and-egg situation, since the steps are meant to
        run before the repository is cloned, however it makes some sense to
        have that in the repo since deps and similar are tied to the code after
        all.
        
        The user-side makes use of all script resources, which of course is not
        ideal, but still better than nothing.
        
        Unfortunately the admin side uses hardcoded paths - can be switched to
        also using script resources instead of the xRemoteFile DSC, but that is
        trading one bad thing for another…
        
        Future tweaks might include setting up a Dev Drive and/or whitelisting
        directories to be excluded from AV-checks
        
        Change-Id: Ide1f0efb94264a6c72a9e87c2c212aa527d7d330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173676
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-10-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ea6f4bb93ee87e3ab41fab006a97bba6170a125d]

        winget configuration files for installing Visual Studio Community 2022
        
        A first step into streamlining the dependency installation process
        using winget / DevHome
        
        You can apply winget configurations with DevHome or from commandline
        by running
        
        winget configure -f path-to-configuration.yaml
        
        The *.vsconfig files can also be manually imported into Visual Studio
        Installer to install missing components into an existing installation
        
        Two variants are provided in this commit, one set including the
        components needed to cross-compile for ARM64 (uses around 1GB)
        
        The version of the Windows SDK chosen is the one that matches the SDK
        from the recommended packages, to avoid installing two different SDKs
        when using the configuration that includes the recommended packages
        
        The *.vsconfig files don't include the implied packages/the ones
        required by the workload. For a list of the components and their
        corresponding friendly names, see
        https://learn.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-community
        
        Change-Id: Ie44ee3dd39c3e61fb2d7c597b71a4a81e0e6b8d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173336
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-10-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c17c2303d2475aa080bbc10a0c5d0e9f253d505]

        tdf#163219: sc_scriptforge_test: Add unittest
        
        Change-Id: I045f9e8ae8805c81f455e4171be95e1222ee908f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174765
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [c0e792cc6ed3eedd05f483e95415b996992a3b15]

        sc: Add simple unittest for ScriptForge
        
        Change-Id: Ief1808219862273643a3bfae212b1d0e454b3e86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174763
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4059c6351d9dc07ef2ab88149079cb2c59e22c32]

        tdf#161479 make presentation work on fractionally scaled display
        
        With fractional scaling on wayland the monitor sizes here are reported
        effectively with the fractional scaling factor rounded up to the next
        integer.
        
        So:
        1920 x 1080 at 125% scaling which appears like,
        1536 x 864 is reported the same as 200% scaling, i.e.
        960 x 540
        
        So using these values as constraints for GDK_HINT_MAX_SIZE
        with gtk_window_set_geometry_hints for m_bFullscreen are
        too small to allow filling the screen.
        
        Seeing as this was introduced as a workaround in the first
        place, drop the workaround under wayland.
        
        Change-Id: I7acfc929755728bbf77731d040f1f0f66cac836c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-10  Justin Luth  <justin.luth@collabora.com>  [5a617f77ee803eb65051e93f659ef66433879052]

        tdf#156707 xmloff import: always provide ControlBorder property
        
        The problem was that 3d textbox form controls
        were imported as flat.
        
        The default value for ControlBorder is 3d.
        
        Since caolan's 7.5.4 63b8e8bda29efbdde0e0bd7f7d2b18d5a9b7b135,
        all textboxes are initially created with a flat border instead of 3d.
        Since 3d is the fo:border default (and never specified),
        the newly created control had no override to force it to 3d.
        
        So this patch forces passing a ControlBorder property.
        
        On export, since the 3d property is the default value,
        ControlBorder is no even provided as something to be exported,
        and therefore only "solid" and "none"
        are ever exported as fo:border qualifiers.
        
        make CppunitTest_xmloff_style CPPUNIT_TEST_NAME=testTdf156707
        
        Change-Id: Ib4541d5e3599dc42af6055062fd709e105bf5d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174754
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [683c005c2c3b9909f7eae18f06a1142b23978bc4]

        cid#1557590 Data race condition
        
        Change-Id: I1c100c65eb2671802550db5629b994ebeb92580b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae98c87b7adda9c566fb75449e833c873c4bc132]

        update to skia m127
        
        Change-Id: Idffde7d5efc26a39dd119b657b7284527c013eb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [33aa490cd6c18474f83ddd2b5f91ffc5c42a34d9]

        Make --disable-emscripten-proxy-to-pthread configurable
        
        ...as is convenient for some experiments
        
        Change-Id: I74aedb38ecc0f7b5a0d913799f649dce77dc7bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174753
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-10  Miklos Vajna  <vmiklos@collabora.com>  [e9dcbf84f94b90ee8cd78628a0c9b5fb131d1085]

        sw: use ForEachCharacterItem() in SwDoc::ForEachCharacterBoxItem()
        
        Avoids a lot of duplication.
        
        Change-Id: Ic929bf0add04228953d2536d2d753609b4203738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174756
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f532894afd2d738c652164a52a34f319873008cf]

        update to skia m126
        
        Change-Id: Id5f93ad07171228cf0701bd330be1ccf51c32e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Marc Mondesir  <timepilot3000@gmail.com>  [e26afef055b8df5f0eb2f39caa282d47cbda6efe]

        Log SetGestureConfig failure. Remove redundant mutex.
        
        Log warning if SetGestureConfig fails. Remove mutex around ImplHandleGestureMsg call since mutex called inside function.
        
        Change-Id: Icd614d7119c1b8a39c410e203748d5e502c3f5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174306
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [646e4cfa4f8f1858d8ab762594f60a9c91cf19e4]

        cid#1555929 Data race condition
        
        Change-Id: I6748cdb95f4bcca12d6b3201ef2ff077e87081b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174746
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [0216369a736a83bc9440c24220c803127e671c5c]

        cid#1606699 Overflowed constant
        
        Change-Id: Ibd5179a015c2aa82111badb6d181294435b8ef21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174742
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ce8ac330eb4d995f29be4a4e12ef5f63481dcd03]

        Emscripten: For executables, only build .js files, not .html files
        
        ...as for the by-default --enable-qt5 case we generate an additional
        qt_soffice.html anyway (and for a --disable-gui --disable-qt5 build, client code
        probably wants to embed the results into its own HTML document and wouldn't rely
        on an soffice.html); this simplifies the build infrastructure a little
        
        Change-Id: Ib50799b5dd2fcfeb680f257f46ff65775dcddd71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [ae44d2affa524045735232c6e1b4f851bd4d48ad]

        cid#1607338 Data race condition
        
        move this logic to the destructor, like we do elsewhere
        
        Change-Id: Ie41c78b0a01d79020cb77fd5be70116f473e910f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [950c4537a65d6a9981c0b7e392190cf72837596d]

        cid#1607842 Overflowed constant
        
        Change-Id: I11bcbe62181ec85c9d61cb9b4f9d0a3adad92890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174743
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-10  Mike Kaganski  <mike.kaganski@collabora.com>  [5daac16a03c84f5908808be446c705e19445c150]

        tdf#160580: make cycling from first to last tab configurable
        
        This introduces Office/Calc/Input/CycleNextPrevSheetTab
        boolean property, that controls the behavior implemented
        in commit 552170c9c8ad6d215aa456ba9d622af01c25d275
        (tdf#156311 Cycling through tabs in Calc, 2023-08-16).
        
        Change-Id: I0510743b4ab6d92488ba73a7b8d5b83be9586b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174745
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [963255acd4cee20b861fe318667bfbb902e299af]

        cid#1608078 Overflowed return value
        
        Change-Id: If654c8c86b71fdf1179f9ea89d31bf6b530e5046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [be091490b6701f729dc991271a036a96967d4f0a]

        EMPTY_FRAMELIST can be constexpr
        
        Change-Id: I9b43ec53f9d808dd23f05b67248fe96435c649e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-10  Noel Grandin  <noelgrandin@gmail.com>  [30d2c8bbde0c465a2f87324eb974ad8e68e28cd7]

        cid#1606594 Overflowed constant
        
        Change-Id: Ie5445a5287de7d1752dd3aefaa2969d92fed6da1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174741
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-10  Eloi Montañés  <em@ilsrv.com>  [12407f0668b042f5cbdffbddf65dc864c809d180]

        tdf#163359: Fix duplication of TSA URLs on Signing Dialog
        
        When using the Signing tab on the "Export as PDF" dialog, the TSA URLs will be
        appended to the ComboBox each time a certificate is selected. Thus, if a user
        selects a certificate and then another (or the same) is selected the ComboBox
        will end up with duplicated values.
        This patch moves the code to append the TSA URLs to the function that sets up
        the signing page, fixing the problem.
        
        Change-Id: I93d9cb61e10f18b0c33765d63a5ce47c92e588bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174424
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-10  Oliver Specht  <oliver.specht@cib.de>  [2321626477d4ff930d8bc392efa6ea84e8825171]

        tdf#163340 replace list on paste
        
        Pasting paragraph with list should apply the source list to the target
        paragraph if the target is empty or completely selected.
        
        Change-Id: I27d462f121c03b6c5625f8c0967bc975d3ac2f88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174606
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-10-09  Miklos Vajna  <vmiklos@collabora.com>  [fe9dab32a3083059f46aba1ba5eab5840c2d07b5]

        CppunitTest_vcl_pdfexport2: relax testPdfImageHyperlink a bit
        
        This will start to fail on pdfium-6764 with:
        pdfexport2.cxx:4186:Assertion
        Test name: (anonymous namespace)::testPdfImageHyperlink::TestBody
        equality assertion failed
        - Expected: 0.0012626264
        - Actual  : 0.0012626261
        
        But the original problem was that the repriprocal was just 0.00126. If
        we require one less digit, 1/0.001262626 is 792.0001647360343 and
        1/0.0012626264 is 791.9999138304095, so the original problem that the
        rounded result is 794 points (and not 792) is still tested.
        
        Change-Id: Ia4489625fd25eca971261b14005b10bbf34343eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174724
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d70026abf786e860c893061ca16e1dd718bd99ce]

        Fix typo
        
        Change-Id: I0bb338567bc731fe38bc551e080a9ad60c80f969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174751
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ba432fcd7c7c988190fd994af53679c2e044eaaf]

        Fix typo
        
        Change-Id: Ibafe319dfbbb580228c3d6c761d9507278b2c0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174752
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8f20de4e8c5bf932ebcc5bc1431e63677617c319]

        Fix typo
        
        Change-Id: Ia94d191204cee8b21702d03429493d09427d62d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174750
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-09  Oliver Specht  <oliver.specht@cib.de>  [9400c0cf10bc14963a994ec0c0caeeb22a7c2513]

        tdf#132274 follow-up fix to Writer zoom options
        
        Applying the zoom value works now as expected. The prior
        fix mixed up zoom value and 100% and didn't always apply
        special zoom values.
        
        Change-Id: I7cf1f34fca5724eea14339535e7614cfecffdd79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174688
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [b09017c578cd905f8db64954f876693a1b0b0fcd]

        update to skia m125
        
        Change-Id: I92e2132f79ba9f3d2ec6cb6438e8040eb6cd0e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174738
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-09  Noel Grandin  <noelgrandin@gmail.com>  [069d53c414ec2fa38272e0a32d44d3f19e2d5e98]

        cid#1608473 Data race condition
        
        which requires some care, because these objects are linked
        together into a double-linked list, and they call back into
        each other.
        
        Change-Id: If5c128918a1ae901ab7789067dc47d30f7415b43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [9cf17d841a0c7b3b0c0811dd01f1536db6d7beda]

        update to skia m124
        
        Change-Id: I9bb712bdde8d2f2af792af5b439f4789e59f1595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Noel Grandin  <noelgrandin@gmail.com>  [36ba1f15ec7c89070cee81fc6188cc792300fdf4]

        cid#1607047 Overflowed integer argument
        
        Change-Id: Ic1b625dec3768fe5a5415b667bef3c32b0c13e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174709
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Mike Kaganski  <mike.kaganski@collabora.com>  [85d1e6662b09be414565c6aa512abf5bc9b83f3d]

        tdf#163362: write xlink:href in image:images, image:bitmap-index in image:entry
        
        Those were mandatory prior to commit d367ee2f8c204f351072c0eb10259fd7aa497770,
        and still mandatory e.g. in AOO. Restore writing those, for interoperability
        and backward compatibility.
        
        Change-Id: I84f33e13e6bade8b2f2dd0cc5e2e0f4a96d50e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174721
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-09  Rico Tzschichholz  <ricotz@ubuntu.com>  [b344877e37fc7f78625af4a9bf2b69ad61cced7b]

        vcl: Use fabs() for double argument
        
        Change-Id: I959786e42dc576cb72411bacccf1b9bd32fbe21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173626
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-09  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [0bf8a64f4104717c3584998f65b0d16c75df7a44]

        tdf#157811 Swap tooltips for stepped line types of line chart
        
        * chart2/uiconfig/ui/steppedlinesdlg.ui:
          - Correct the swapped tooltips for stepped line types
            "End with horizontal line" and "Step at the horizontal mean".
        
        Change-Id: Ieeff2e71b2e924060fb5ef3fca313c0d0bc2502d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174700
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-10-09  Gabriel Masei  <gabriel.masei@1and1.ro>  [565b619d57a3b98b0826c4b49dee6606f9ae70e0]

        tdf#160582 Preserve settings saving in csv import dialog
        
        Also, improve detection algorithm by replacing the limit
        of 20 lines with a time limit of 500ms.
        
        Change-Id: Iac519b6ebe675b91ce84b900646d9d320ea9ddc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165905
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2024-10-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [2f1dcf01d713f786ed1bfdc2ba3b6c9e06fb8ecf]

        tdf#157519 Implement Sensitivity Report in LpSolve solver
        
        This patch implements sensitivity analysis when using the LpSolve solver engine.
        
        It also adds the infrastructure needed for future implementations in other solver engines via the css::sheet::SensitivityReport struct.
        
        Change-Id: I74c2ed9c6201a0b2ffc29ef612d2b778d11a3bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173642
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [860ec21856a25c1aee45e64b5760a31294e62d54]

        update to skia m123
        
        Change-Id: Ic7687add0fce85b17bf77b003137649bc7be9042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174703
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [a16a0dc9d211e48da5799e8c10a3b5e4f58f2525]

        update to skia m122
        
        Change-Id: Ifdc602fa7007a9352cdd1a654555204955c89317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Noel Grandin  <noelgrandin@gmail.com>  [760ea7ee4917bf4d17054a9ce28c693275b35a4d]

        cid#1607822 Overflowed constant
        
        Change-Id: I4794c2393c48121e3e88b6054a60416ccf13b273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174708
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-09  Noel Grandin  <noelgrandin@gmail.com>  [ac4ea1ad3a2c1a65e53fac769cdd0c91bb236e2b]

        cid#1607798 Overflowed integer argument
        
        Change-Id: I561e86e07a61114523cad545646edf24cf50a260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Noel Grandin  <noelgrandin@gmail.com>  [a28f9a8cc21cf1ca6b552af64015a745c9a95b27]

        cid#1607224 Overflowed return value
        
        Change-Id: I62e153936f9f49fb12deee735ec665bad8a23ad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a4535300ebd146322bf7e788d0200e4b338f4ad]

        tdf#163275: sc: Add UItest
        
        Change-Id: Ic1a56c959ec45f3802e8bd6bf02f895c723df2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174696
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [94738e6def221e722ae726af1b8abb8840b59a39]

        improve ODF sheet saving performance
        
        GetODFSaneDefaultVersion() is surprisingly hot, mostly because it is
        called from every ScXMLExport::WriteCell call, so cache it
        
        Change-Id: Ibc54c007f4979315487badc23889eb264b11d4ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-09  Jim Raykowski  <raykowj@gmail.com>  [9f95e65730b273643d79d9a32cd11a8d5a40464c]

        Resolves tdf#161919 Two programatically composed UI strings not suitable
        
        for localization
        
        Change-Id: I20a914d9d158817b7c9605afc1972a91117fb5a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170789
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-10-08  Justin Luth  <justin.luth@collabora.com>  [0fb23379e63071ec155cb6683c19212859e399b5]

        related tdf#125038 DOCPROPERTY:fix spurious text outside IF field
        
        This builds on top of commit d09336fbdceaafd9320466b660a2b32a07dcc16a
        (tdf#125038 DOCX import: fix lost MERGEFIELD result inside an IF field,
        2019-10-31), and extends it for DOCPROPERTY.
        
        With this, all unexpected content is gone from the paragraph.
        
        [In a previous related commit, I wrote:
        Actually this is all somewhat irrelevant since DOCX doesn't import
        IF fields at all anyway - they are just left blank.
        So AFAICS, we should ALWAYS return false at this point.]
        
        make CppunitTest_sw_ooxmlfieldexport \
            CPPUNIT_TEST_NAME=testConditionalText4
        
        Not surprisingly, there were no existing unit tests that matched
        (because I already did a crash-testing assert last year).
        
        Change-Id: I4d737172ee278c07596eaf47e1bc320e4f42be55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174699
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-08  Patrick Luby  <guibmacdev@gmail.com>  [9240debe362a382389e7601073523162ea0cd80d]

        tdf#162843 replace the event's string parameters
        
        When using the Dvorak - QWERTY keyboard, the
        event's charactersIgnoringModifiers string causes
        pasting to fail so replace both the event's
        characters and charactersIgnoringModifiers strings
        with this menu item's key equivalent.
        
        Also, fix the following related bugs when using the
        Dvorak - QWERTY keyboard:
        
        - When pressing Command-V with a Dvorak - QWERTY
          keyboard, that single event passes through the
          -[SalNSMainMenu performKeyEquivalent:] selector twice
          which causes content to be pasted twice in any text
          fields in the Find and Replace dialog.
        
        - When using the Dvorak - QWERTY keyboard and the
          Command key is pressed, any key events that match a
          disabled menu item are handled in the
          -[SalFrameView noop:].  However, the Dvorak - QWERTY
          event's charactersIgnoringModifiers string can cause
          cutting and copying to fail in the Find toolbar and
          the Find and Replace dialog so replace the event's
          charactersIgnoringModifiers string with the event's
          character string.
        
        Lastly, fix temporarily disabled menu items failing to
        be reenabled when a modal dialog closes caused by the
        fix for tdf#126638 by returning the last enabled state
        set by the LibreOffice code. Apparently whatever is
        returned by -[SalNSMenuItem validateMenuItem:] will be
        passed to -[NSMenuItem setEnabled:] which can cause
        the enabled state to be different than the enabled
        state that the LibreOffice code expoects. This results
        in menu items failing to be reenabled after being
        temporarily disabled such as when a native modal dialog
        is closed. So, return the last enabled state set by the
        LibreOffice code.
        
        Change-Id: Iae9cc6f1b94484c1529b22ea3a7acdac2009a58b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174462
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-10-08  Julien Nabet  <serval2412@yahoo.fr>  [73c51868a1f2889edbd7565a80645b04ef8db2f9]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to b871dff9e73eefc187b2c979803c619ceccaed3a
          - tdf#163231: fix Italian spellchecking
            
            Change-Id: Ibffcdb66fd062425f1432d948a16a38143186911
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/174672
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-10-08  Noel Grandin  <noelgrandin@gmail.com>  [48db2edc9539d2d6d313cd225dadca6edc019559]

        cid#1608062 Overflowed constant
        
        Change-Id: I03b3cc85b3571806ad87bf678d83e4c89dca8a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174622
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Noel Grandin  <noelgrandin@gmail.com>  [c360c2a9a39af716014c610ea44d9e33d2f6fb3a]

        cid#1606728 Overflowed integer argument
        
        The problem here is that coverity thinks that ParaPortion::GetLineNumber
        can return -1, which it can, but only if things are already broken,
        so add an assert tbere.
        
        Change-Id: Iceea035edb49bb3e1e0a39a9b63a9176308346ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [979056319d93c1384ad54ca5224ae06a752c2c6a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a786c24008e843c00271cb324bb00563d451d281
          - tdf#162275 Fix typo
            
            Change-Id: If8ae57d1d7a92256ee4b9fef60ca47496d225be4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174704
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2024-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [de212916cbe14461f46eab59a17426ea50ddc1f3]

        update to skia m121
        
        Change-Id: Ic3ab29795af11470d4b41a73d02eac1cd56cadb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da07be044c5240cced612361187789aa53481abb]

        Fix typo
        
        Change-Id: Ice1845b319320fa4d9f5c4a5001e411fd54f9377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174618
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ecefe3e3608e73d8ba659f2b44bd07e24ee7ba8]

        update to skia m120
        
        The following patch appears to be upstreamed now
        incomplete.patch.0
        
        Change-Id: I36a4c62928c050ed4f8103a580899cdb3cf237cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [53f889780f6182de875675ac8e6f2e74131a04e6]

        Reimplement GetSystemDateTime using std::chrono
        
        Change-Id: I15bce244f96a8940df73f4b5933bcb95a547673e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174691
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [52ad4bb76d81e2bd9f6929294a7a14a08f084814]

        fix-up 2 slideshow: provide animations info
        
        wrong node name
        
        Change-Id: I57e91e708e0ec585aee2dd4873b60ab54e6aa8d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174687
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [7a119065fd56527b1c2163304d805d51557fd6db]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 73ca477c42d6a67cfd6bbe819016f4b1b9f4c3ce
          - upgrade Ukrainian dictionaries to 6.5.3
            
            Downloaded from https://github.com/brown-uk/dict_uk/releases/download/v6.5.3/hunspell-uk_UA_6.5.3.zip
            
            Change-Id: I1ff9b5ca99fc855407b4982b202ceb840f8bab23
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/174690
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a90ed2524785ab84a65a1b7979797b7297e3000]

        update to skia m119
        
        the SkImageGenerator patch seems to have been upstreamed
        
        Change-Id: Ic2af62b9479c36394c6c0cf19d1c6f61edfff6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [bbcd4765eeb18bece792cd4588b8e7f9288bfcef]

        Simplify tools::Time code
        
        Change-Id: I44a61a0ae2f6e2b81cce96ff96418484a611821d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174689
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-08  Justin Luth  <jluth@mail.com>  [6fe0de9c0bb903ced5ccf35a774f77bf9f3526c2]

        PDFDocument::ReadWithPossibleFixup: clear before reading fixup
        
        Ensure that a read of the pdfdocument
        does not use info from failed previous reads.
        
        The result in the problematic documents
        was that GetCatalog failed because it was looking
        for an m_aTrailerOffset[0] from the failed read,
        and thus only empty pages were exported.
        
        I failed to create a clean-room document,
        and the single existing unit test that needs a fixup
        has the trailer at the same GetPosition,
        which replaced the m_aTrailerOffset
        instead of creating a second entry.
        
        Change-Id: I470b922323a2b2ebb6d4bbaa58c98f5cc492b750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174652
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-08  Miklos Vajna  <vmiklos@collabora.com>  [eb8a5d4630dcb09fea320b182424d8b6140c1166]

        tdf#134198 sw: avoid losing char pos of anchor point on content copy
        
        Load the 5 pages bugdoc to Writer, notice the image on the last page,
        select-all, copy, new document, paste the selection: no image on the
        last page.
        
        Given the new document may have different compat flags, this may not be
        a bug, but bisect shows this was working before commit
        591673d1637b25f83e01baccc321a83f10fc0ce7 (use more SwPosition::Assign,
        2022-08-29). Also note that the image in question is anchored to-char
        and it has a non-zero content (character) index, that's why it's on the
        last page, and not on page 4. The old code kept the content index
        unchanged while changing the node index, the new code avoids touching
        the nNode member directly.
        
        Fix the problem by still not touching the nNode member directly (to keep
        the benefits of the above commit), but explicitly keep the content index
        unchanged.
        
        Changing the node index without changing the char index in general is
        not safe (the new node may have less characters), but it does work in
        this case, and this fixes the regression.
        
        Change-Id: I2a90e4a88608d7435543880f46f09bea21eba48a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174655
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ada9095716265900e476ac9f676ba4968ba2bfad]

        cid#1607238 silence Overflowed constant
        
        Change-Id: Ibb5bb59e00f6e16ea68ec37aaa8622eecdf9b8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174685
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [38c47c91abc96c32f319bd6bd4015d6d9c04332f]

        cid#1607834 Overflowed constant
        
        Change-Id: If09eb49bd8549defe512193817d23e27e565ffdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174683
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad6dd34fd1acef50ee90c582976d1e0702748ca6]

        cid#1603632 Big parameter passed by value
        
        Change-Id: I570c5357b2d14f1bfcf88fe1f95021f18c6151cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174682
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [393fec98820534613a351c17f7eb410045eaeb4f]

        cid#1620559 silence Using invalid iterator
        
        Change-Id: Iccfd99bf517630947abf76464b7e19f274377082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a5ce68dc34d3e14a7abe9625f8f6c88c0f5581c]

        cid#1632259 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1632258 COPY_INSTEAD_OF_MOVE
        cid#1632257 COPY_INSTEAD_OF_MOVE
        cid#1632256 COPY_INSTEAD_OF_MOVE
        cid#1632255 COPY_INSTEAD_OF_MOVE
        cid#1632254 COPY_INSTEAD_OF_MOVE
        cid#1632253 COPY_INSTEAD_OF_MOVE
        cid#1632252 COPY_INSTEAD_OF_MOVE
        cid#1632251 COPY_INSTEAD_OF_MOVE
        cid#1632250 COPY_INSTEAD_OF_MOVE
        cid#1632249 COPY_INSTEAD_OF_MOVE
        cid#1632248 COPY_INSTEAD_OF_MOVE
        cid#1632247 COPY_INSTEAD_OF_MOVE
        cid#1632246 COPY_INSTEAD_OF_MOVE
        cid#1632245 COPY_INSTEAD_OF_MOVE
        cid#1632244 COPY_INSTEAD_OF_MOVE
        cid#1632243 COPY_INSTEAD_OF_MOVE
        cid#1632242 COPY_INSTEAD_OF_MOVE
        cid#1632241 COPY_INSTEAD_OF_MOVE
        cid#1632240 COPY_INSTEAD_OF_MOVE
        cid#1632239 COPY_INSTEAD_OF_MOVE
        cid#1632238 COPY_INSTEAD_OF_MOVE
        cid#1632237 COPY_INSTEAD_OF_MOVE
        cid#1632236 COPY_INSTEAD_OF_MOVE
        cid#1632235 COPY_INSTEAD_OF_MOVE
        cid#1632234 COPY_INSTEAD_OF_MOVE
        cid#1632233 COPY_INSTEAD_OF_MOVE
        cid#1632232 COPY_INSTEAD_OF_MOVE
        cid#1632231 COPY_INSTEAD_OF_MOVE
        cid#1558073 COPY_INSTEAD_OF_MOVE
        cid#1557945 COPY_INSTEAD_OF_MOVE
        cid#1557916 COPY_INSTEAD_OF_MOVE
        cid#1557898 COPY_INSTEAD_OF_MOVE
        cid#1557808 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibf417c154255fe3b0598127df5b5805ed543c8d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174660
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8950ecd0718fdd5b773922b223d28deefe9adf59]

        an exit on a failed hwpfilter import is an atypical solution
        
        Change-Id: Iefe31df20ca3e7e91175e00d1f15ff6c851ec536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174659
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [698fd3fc0398722dca7d47ad4ea3bc3c5187085b]

        cid#1632260 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia9012f78b5ea0acb29cfd50807b5ca09331261e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d96527e9fdf2b981c176a0821b21d75203ee5950]

        Resolves: tdf#163275 crash in async dialog use after free
        
        since:
        
        commit b39c6082aa975ed8e5696c3dc24c3025ed07bbb6
        CommitDate: Wed Jan 31 10:33:48 2024 +0100
        
            Implement Async AutoCorrectQuery Dialogs for Formula Check in calc
        
        Change-Id: Ie184f72cfa858ed1fc6d9eb5205dea985767eec5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bf54247e247dda92b3805e28e3ed9b283958c1a]

        RegisterAnswer is never passed null
        
        Change-Id: I3d724c5ea77865de9850a655aaa23c9633b68d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174643
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [9526206b547f967e1246d5104896428ce964db29]

        unoxml: port testXNamedNodeMap_AttributesMap from java to c++
        
        Change-Id: I1a37c7a63622d38cd8d9148589ba999901453611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174612
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-08  Noel Grandin  <noelgrandin@gmail.com>  [388ec7f60945ea2dd639378870b921dfccffb90a]

        cid#1608272 Overflowed constant
        
        Change-Id: I280718f38900752d2c5090b0a25d7883a6062117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174620
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-08  Noel Grandin  <noelgrandin@gmail.com>  [d7069deb280d305fdf85006c30b859f7d61b5b84]

        cid#1607133 Overflowed constant
        
        Change-Id: I63d1ca446491b8b376bb54e410b3d9edc543a734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Justin Luth  <justin.luth@collabora.com>  [d63d93a06e2c926ca270b87f5a8bd7016020251a]

        avoid PDF export crash when ReadWithPossibleFixup falls back to Pdfium
        
        Unfortunately, I failed to create a clean-room example,
        even when I pasted some binary garbage at the end of the file.
        Somehow I was getting a sanitized version from getAsStream.
        
        In any case, this prevents crashing with the two examples I have,
        although there are still significant problems somewhere
        because the export just results in empty pages...
        
        The problem is that reading again with the Pdfium-fixed version
        gets mixed in with the original read results,
        and things get pretty garbled.
        Probably m_rElements and everything needs to be cleared
        before tokenizing the fixup-version.
        
        Change-Id: I01daefa23b8f92e2849d71bca269ba2b476199da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174648
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-08  Noel Grandin  <noelgrandin@gmail.com>  [61e569c5fc96919b5a6bc0ead2477ca3eb6b792c]

        cid#1607401 Data race condition
        
        coverity seems to be having trouble seeing through the function
        pointers
        
        and
        cid#1607619 Data race condition
        
        Change-Id: I94692f124dd82b58be6aee41b49cb309f66b213d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [9c9d2e21be06fa1c806c110812d6df783109d8b9]

        tdf#163344: improve Converter::convertDuration
        
        Let it use the same calculation as ImpSvNumberInputScan::GetTimeRef.
        Decreases rounding errors.
        
        Change-Id: I6474a1a5913d78c236adc511389c4abcebed2de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174650
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [46dec3ba08ac948d195bdf502792df987a02c0e2]

        update to skia m118
        
        The following patch appears to be upstreamed now
        0001-AvoidCombiningExtrememelyLargeMeshes.patch.1
        
        Add a patch to deal with a clang issue that only shows
        up when building for 32-bit Windows.
        The issue is reported upstream, but there is only
        a workaround so far, no fix.
        
        Change-Id: I1c50019a2afe39d245c6b02243789752e84445a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174585
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [81b864b6100d017c3742b82b4e458b07e06519b6]

        Use snprintf to output full double precision of expected/actual values
        
        OUString::number rounds to 15 significant digits, unfortunately; so
        where in a fix for tdf#163344 it was needed to output something like
        
          result: 0.60416666666666663, expected: 0.60416666666666674
        
        it used to print
        
          result: 0.604166666666667, expected: 0.604166666666667
        
        Change-Id: I099d91ce4ac05358a119c63a5b1e481107aa7343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174651
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0a004f1a1528b8a85245de4672852b574bdc2cb2]

        Emscripten: Silence -Wlimited-postlink-optimizations
        
        ...when building with --enable-optimized --enable-symbols --enable-werror,
        
        > em++: error: running limited binaryen optimizations because DWARF info requested (or indirectly required) [-Wlimited-postlink-optimizations] [-Werror]
        > make[3]: *** [Makefile:506: spellout] Error 1
        > make[2]: *** [Makefile:366: all] Error 2
        > make[1]: *** [external/libnumbertext/ExternalProject_libnumbertext.mk:25: core/workdir/ExternalProject/libnumbertext/build] Error 1
        
        etc.
        
        Change-Id: I62ff0a750d62d6bc50de670623e872beddfb4809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174642
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-07  Marco Cecchetti  <marco.cecchetti@collabora.com>  [862d9e03910318a8ca5f990fd1db09f51806ff1d]

        lok: slideshow: export animations tree as json: some improvements
        
        A wide set of smil elements and attributes is exported in json format.
        
        Change-Id: I900e3b1032417b62ae3144c14bcd466358a103e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172550
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174586
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [8f25697591ecfd615a3142528ca13ee4d0d2c562]

        tdf#163295: XMLFilterDetect: make sure to only detect own types
        
        Since commit 872dba61a1a45dceb4ffb662f6da61fb67d750e5 (INTEGRATION:
        CWS xmlfilter01 (1.1.2.3.2.1.16); FILE MERGED, 2003-04-04),
        XMLFilterDetect service uses Clipboardformat field in filterdetect.
        Thus, it detects any file starting with "<?xml" and having string
        "pwi" as "writer_PocketWord_File", because writer_PocketWord_File.xcu
        has the text "doctype:pwi" as the value of its ClipboardFormat.
        
        The problem is: since commit 1e6e891016ae926868de493ab0e29871a2d06b95
        (restore PocketWord filter, this time backed by libwps, 2020-09-27),
        this format is not handled by XMLFilterDetect service. So the filter
        mis-detects some else filter's data, which then isn't accepted there.
        
        This change makes the code of FilterDetect::detect to make sure that
        it only processes its own data, checking DetectService property, too.
        I didn't remove the ClipboardFormat property value from the mentioned
        XCU, because (1) I don't know if it may be used by other code; and
        (2) because it allows to have the sensible unit test.
        
        Change-Id: I02fafe8df10f64640305d45cf1461b0a37552630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174607
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-07  Jean-Pierre Ledure  <jp@ledure.be>  [0b6afed3b85b6599ecbd7e5ac97b080d3ffbbfbf]

        ScriptForge Fix tdf#163219 With blocks
        
        Reference:
          https://bugs.documentfoundation.org/show_bug.cgi?id=163219#c7
        
        Everywhere the With block variable is defined
        or redefined inside the With block, the Basic
        code has been reviewed.
        
        Found in
          SFDatabases/SF_Database.xba/SetTransactionMode()
          SFDocuments/SF_Document.xba/Styles()
          ScriptForge/SF_Dictionary.xba/ImportFromPropertyValues()
          ScriptForge/SF_UI.xba/SetStatusBar()
          ScriptForge/SF_UI.xba/ShowProgressBar()
        
        Most changes consist in isolating the With block
        variable before the With block itself.
        
        No functional change.
        
        This solution is a workaround for the bug.
        IT DOES NOT SOLVE THE ROOT CAUSE.
        
        Change-Id: I48af29d3d9c8b1e36ef5a85c8cfe28f9639ae483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174560
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-10-07  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [1f16b88e9dbfe1477dd90e361394f5ffeac3e932]

        slideshow: enable comb transition
        
        Change-Id: Iac0c07f83904055a30c65e4133443772246d9502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171422
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [75a030d577fb7dbe0233b54168a6cfb1ac289eb3]

        allow creating rich content comments via .uno:InsertAnnotation args
        
        Change-Id: I186f5955cad88c1d0d6cae66a7eb0a7845bb73a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [01479df14c14a4736dfbadf23c342b7ee835eba2]

        configure: Clean up kf5/kf6 version checks
        
        * Drop redundant "minor version >= 0" check
        * For kf6, require version >= 6.0, i.e. drop support
          for older pre-release development versions
        
        Change-Id: Idffbc8eef513887727f6b256cb47a770294435bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174587
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [5599ec55f0a2d752aae1ec235aa440713d32fe42]

        tdf#130857 qt a11y weld: Handle "accepts-tab" text view property
        
        Evaluate the "accepts-tab" GtkTextView property [1]
        and set the `tabChangesFocus` QPlainTextEdit property
        based on that, so tab moves focus to the next control
        when "accepts-tab" is set to false in a "GtkTextView"
        object in a .ui file, like the ones where this property
        was newly set in previous commit
        
            Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Oct 7 08:10:56 2024 +0200
        
                a11y: Leave accessible description text view on simple tab key
        
        (They're not yet supported by QtInstanceBuilder yet, but
        once they are, that will work as expected.)
        
        [1] https://docs.gtk.org/gtk3/property.TextView.accepts-tab.html
        [2] https://doc.qt.io/qt-6/qplaintextedit.html#tabChangesFocus-prop
        
        Change-Id: Ib1d33f37016a2601aa9ab9c370c9076dbae5bed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174570
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [faa6749592b7777773a51cb6f350a39aeb67b052]

        a11y: Leave accessible description text view on simple tab key
        
        Set the "accepts-tab" property to false for the GtkTextView
        where an accessible description can be set, so pressing
        the tab key moves focus to the next field in the dialog,
        instead of inserting a literal tab character.
        
        This simplifies using the dialog when using the keyboard only.
        For the VCL and GTK implementations, pressing Ctrl+Tab
        would previously be needed to move focus, which is less
        intuitive.
        
        Setting the property does not technically prevent inserting
        tabs, they could still be inserted by copy-pasting
        text containing tabs; just pressing the tab key while
        the text view has focus won't insert them any more.
        (I can't think of any reason to use actual tab characters
        in the accessible description, however.)
        
        Do this for the .ui files used for the following 2 scenarios:
        
        * select QR code object in Writer, open context menu,
          select "Alt Text" context menu entry
        * select an image in Writer, open context menu,
          select "Options" context menu entry, go to the
          "Options" tab page
        
        Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174569
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [bb8fb01dde1ccb29a8b3537e585b102413d9bfb0]

        fix skia m117 sha value
        
        so I messed up and uploaded skia m117 twice. But now there are two
        copies of skia m117 in various CDN caches, with different sha256
        output (no idea how that happened).
        
        So upload a THIRD COPY with a new name, and then I can fix the
        sha256 value in download.lst in a way that doesn't break the build for
        someone.
        
        Change-Id: I297ff4d9fa3a0edd902c85f2d674950945249a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174590
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-07  Đoàn Trần Công Danh  <congdanhqx@gmail.com>  [aac0f6081a5dcfb3c3d04b13f93d1c0c7813e272]

        configure.ac: support cross-compiling with KDE 6
        
        Those KDE version check can be moved into compile-time.
        This change will also reduce the time to check when native compiling,
        too, since we don't need to run the just-built binaries.
        
        Change-Id: I0d60ade17b1ab5aaf4f729e39aba1345f088e6b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174512
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [43de008d7871848c10a9d618aec8f817bb40f082]

        vcl: use correct var prefixes in BitmapScaleConvolutionFilter
        
        Change-Id: Idca191a21ef63a707d9c5230dad8c97552757c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173206
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ff3791f67a6421d64f5f9d6a09feaead1a63ff92]

        tdf#163219: only create local With variable for function results
        
        The problem is, that having a local variable referring the same value
        as the original expression 'foo' is not the same as referencing 'foo'
        itself. After 'foo' is re-assigned, the local variable still refers
        to the original value, not the new one.
        
        It seems impossible to implement the reference using existing codegen
        primitives, to imitate the true reference to 'foo', not to its value.
        If we implement it by changing the runtime, the bytecode won't work
        identically in older versions; if we introduce a new bytecode, that
        would be an incompatible change.
        
        As a workaround, only create the local With variable, when the block
        variable is created using some function (as much as known by parser).
        I think that there would be cases when this would still not work as
        intended: an example is a property implemented using getter function;
        the parser would likely treat the property as a variable, and avoid
        creation of the local variable; and the getter would be called every
        time a dot access will happen (which was the essence of tdf#132064).
        However, this seems a better alternative to the bug fixed here.
        
        Change-Id: I50bf679762fd2e73f215a000fa0ab60fd6ae7453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174564
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-07  Noel Grandin  <noelgrandin@gmail.com>  [0e76e830c234d72b1973cc5311285f178c93263c]

        cid#1606613 Overflowed constant
        
        Change-Id: I5340d46ef1264236c63bfd058e44dd984be2793c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-07  Noel Grandin  <noelgrandin@gmail.com>  [0d0f2e7b1f6851b07e65b42aca40f37a5f311deb]

        cid#1606611 Data race condition
        
        and
        cid#1607663 Data race condition
        cid#1606843 Data race condition
        cid#1608340 Check of thread-shared field evades lock acquisition
        
        Change-Id: I97b82d4302ead6b96ae19c15502c427952df2ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-07  Miklos Vajna  <vmiklos@collabora.com>  [837c60d29f23bd69d048e47b8667f78885a4c48b]

        svx: prefix members of SvxNumberingPreview
        
        See tdf#94879 for motivation.
        
        Change-Id: I75e86d37a88ce9c71c0c8886bf782666d23fd6dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174568
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ffd383c7051d02d8d9606fd6e5e0ae0be70b86f7]

        clarify this a little
        
        Change-Id: I75625dfefdfb9bb159235c1be5536d5f27739365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e1eaea2729c0e51eef6ede7d54601573cff638e]

        crashtesting: avoid null deref on failure of cairo_image_surface_create
        
        seen since:
        
        commit 1acd37a671b9d3633a7d31a0b60478815fbc685f
        CommitDate: Mon Sep 23 14:12:04 2024 +0200
        
            CairoSDPR: Activate globally to check builds/tests
        
        Change-Id: If3068b436eb57b48b048d30538b71563f38735d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f60d768fad73494fbfd600d8c7f8a0f1c7e3e857]

        flatten SwCollectTableLineBoxes::GetBoxOfPos
        
        Change-Id: I3a7908456ebd29f5c5bf1ad1e7dc593abce4928c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e9a21bb0e4981e834de22c1d666f7a83a2771c5]

        Update to skia m116
        
        The sort comparison patch seems to have been upstreamed.
        
        Lots of patches needed to be redone.
        
        Followed the skia release notes in replacing calls
        to SkCanvas::flush and SkSurface::flushAndSubmit.
        
        Change-Id: I13179565b95cc0720b4548cd4baecc5adacc7133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174554
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [921f677cdbf05f184bc942b91af933dc2e283862]

        increase fuzzing max lengths
        
        Change-Id: Ia1f1abfece4667baad4036d9bedb36d07e8212ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174565
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25b1840163c3643ecf0cccd66a2e1bc8bd674f4c]

        writer2latex is long gone
        
        since:
        
        commit c5ae3e6de97f1341ea236680af3f4a1b5698796c
        CommitDate: Thu Apr 23 11:44:51 2009 +0000
        
            CWS-TOOLING: integrate CWS native241correct_DEV300
            2009-04-06 15:56:56 +0200 rene  r270566 : autoconf
            2009-04-06 15:56:02 +0200 rene  r270565 : remove writer2latex
        
        Change-Id: I638a4369b9718e99446521bc8d0c45e480e145ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174562
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7661789352187e28a5f3daedcb7c3e4956d6d2c5]

        cid#1608598 silence Overflowed constant
        
        and
        
        cid#1607946 Overflowed constant
        cid#1608526 Overflowed integer argument
        cid#1608611 Overflowed integer argument
        
        Change-Id: Iec21df2f3d7dc8fba3872c6a70466ae12026a49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174557
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e32ab825cb0566b55011f630ed7b79df0fd6e04c]

        cid#1608393 silence Overflowed constant
        
        this code seems to be duplicated in
        sw/source/core/unocore/XMLRangeHelper.cxx
        too
        
        Change-Id: Ib41edfa33a72f32dff1f6720e6b0f356e9773f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174556
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc19fb1550234b3e1eae3fb50fbf791d84b0ebe1]

        cid#1608265 Overflowed constant
        
        Change-Id: I5221c986ee0292a59ef66325185a97fa08a40fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174555
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Mike Kaganski  <mike.kaganski@collabora.com>  [fe40a5ca030f72e31ce1b33d32b6b500131a2039]

        Simplify assignment of Nothing
        
        In commits f3f46b5fe729876d128f63f7ab158954ab6657d7 (tdf#132064: make
        With statement only evaluate its argument once, 2024-04-18) and
        40d0e6f4c4ca31f6525b4c84924f2330a166182c (tdf#162962: always create a
        local "Nothing" for the "WITH" variable, 2024-09-16), I used hacks to
        emulate the global Nothing.
        
        This change implements it properly, I think, It makes sure to use the
        RTL's Nothing; this saves compile-time checks, strings in pool, and
        makes code cleaner.
        
        Change-Id: I3d007c5aa187e9aa61c1c369511be969b8cf57f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174553
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f64f05d3e42cee53423d7b7b80783fbca0aed23]

        cid#1608177 silence Overflowed constant
        
        Change-Id: Ibd8620bdca333e78addad9efc5a340cbe6e2a6bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174540
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22df7aee96431312ccd43bc8288b8b31115fb8d4]

        cid#1608417 silence deliberate documented Infinite loop
        
        see: testtools/README.md
        Change-Id: Ie32624cc7c9262aff5666bc43b828158f0777259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [650c0240830dee519b1d587d90d7ede37653c5ed]

        cid#1608418 Overflowed constant
        
        since:
        
        commit 45435a680be065e44eba385bb2523b27b77fb451
        CommitDate: Mon Mar 25 15:54:01 2024 +0100
        
            tdf#126573 Add Excel2021 array function SORT to Calc
        
        Change-Id: I7b019b1d34528eadd03c8ef8e87118189b0390aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174538
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2ed39b9673474c59f3e38eb47263c99cdfb3c501]

        Fix typo
        
        Change-Id: I0e3779d845e48fe0ea5d91284f8701f34f9cd48e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174535
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [40beeb144a00c9725cde4239c251f67c658d31a8]

        increase max rtf len allowed
        
        Change-Id: Ifae0795de882d833865ba973cf8098c8b59b8eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174541
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73ba9a65834455cba992f1661222f881649af448]

        use ConvertStringToHTML for the URL too
        
        Change-Id: Iee10356c6311c4ac791dc59081ca2a208d3c0710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b9519e984adc16d1c66aa7a5c0cdf77b0d0ac5e9]

        cid#1608381 Data race condition
        
        Change-Id: I85d110e0465429a52a8286747ae9da3e271255c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174537
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad69113dbe01f10aed05a261870c98c784e7b962]

        cid#1607727 silence Overflowed constant
        
        Change-Id: I0bbd29231158379c9c7986033ce052b7f149ddc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174536
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5212833fa0ec1aa5cb9112c67a3715a9ddf57168]

        add a 'simple-html' export to editeng
        
        currently justs supports hyperlinks and nothing else over plain
        text.
        
        puts each paragraph in a separate div
        
        Change-Id: I645d28e0bb6ed13e930e1555753846d10ecf5dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174388
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-05  Sahil Gautam  <sahil@libreoffice.org>  [7a1636a24f8a4c856348bb6781aef4a494227691]

        tdf#85976 change labels as suggested in comment 73 on the ticket
        
        1) On first call, "by column" was selected although that is the less common case.
            > now by row is selected by default
        2) The meaning of "Orientation" is not really clear. Suggestion: Compare:  rows   columns
            > changed as suggested
        3) The purpose of "Items" is unclear.
            > renamed "Items" to "Records"
        4) Help page does not exist.
            > help page patch has been merged
        5) If a database range is selected, the dialog does not consider the property "Contains column labels" of the database range.
            > didn't quite get this one; require some help to reproduce
        6) It is not usual to use "Okay", but other dialogs have it named "OK".
            > changed as suggested.
        7) Command has no extended tip.
            > Added TooltipLabel
            ```
            <prop oor:name="TooltipLabel" oor:type="xs:string">
              <value xml:lang="en-US">Remove or select duplicate records from the selection</value>
            </prop>
            ```
        
        Change-Id: I9579af68b396cddeca608dc077af3b468191942b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174201
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-10-05  László Németh  <nemeth@numbertext.org>  [3393e52be0900ad63ceee0a43cd44d473ec8248a]

        tdf#163309 sw: show rdf:type as labels on bookmark boundary marks
        
        OOo's RDF handling had limited support to optional metadata visualization, like custom prefix/suffix of metadata fields.
        This is a similar visualization for bookmark rdf:type metadata,
        but without changing the text layout by enabling/disabling
        View->Field Shading.
        
        The labels, i.e. text content of rdf:type have left-aligned
        top position after the opening bracket of the optional bookmark
        boundary mark, and right-aligned bottom position before the
        closing bracket. The labels don't overlap at multiple brackets.
        
        Note: the labels are very next to the line text vertically
        to support fixed line height better.
        
        Follow-up to commit 412e0ab26618c38f548c340f85ef63bbe73ef6b2
        "tdf#150717 sw RDF metadata: add custom color bookmark boundary marks"
        
        Change-Id: I0756c91b51c706f4c7b70fa07f1c7e8fbbf0dc90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174486
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [229964ac9321530991639812050d0065c1d532ec]

        tdf#163285: consider page body frame height to allow the split
        
        This improves on commit b271cc46851c61ddef20dc869bf339c857f76b18
        (tdf#123116 sw layout: allow rows larger than page to split anyway,
        2020-03-12).
        
        Change-Id: I9327a18146d795c65528b0f16cefc81721266046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174534
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-05  Julien Nabet  <serval2412@yahoo.fr>  [b48286f558b5d2998f7528ba3afebbf852796212]

        cid#1620556: UNINIT_CTOR in textview
        
        Change-Id: I0e13c8c189211a97161c1eef5a0ad12e48817564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174533
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-05  Julien Nabet  <serval2412@yahoo.fr>  [f3c294093bcdb25a420ac9d068329cecca16c4d8]

        cid#1620560: REVERSE_INULL in condformatdlgentry
        
        Change-Id: I4e80e1d3b4c1e4b3f08dcdca6dd64473ff87364d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174532
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [a6a69211230226ac8b6c17d016fc19eb8ee11261]

        Use good old string literals in assertXPath and friends
        
        These are only sent to an external API expecting char*-like strings,
        or for comparison. Having every assertXPath having three of _[ou]str
        is too much syntactic noise, making the unit tests almost unreadable.
        
        Change-Id: Ic004a36ea75e7bfe0b96f405c40f926a957b51cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174416
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [95e2bdf97d987c845927bd44210547fd3c2f2387]

        tdf#130857 qt a11y weld: Convert accelerator for labels
        
        Convert the accelerator from GTK to Qt convention
        for labels as well, to not display a literal "_",
        but use the next letter as the accelerator.
        
        For Qt, a literal "&" would still be displayed
        if no buddy is actually set, i.e. there is no
        related widget that can receive keyboard focus
        when the accelerator key is pressed together with
        Alt.
        
        Setting buddies was implemented in previous commit
        
            Change-Id: Iba1e766c0f2c5162beb5b938c134afab0dac68b7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 22:56:05 2024 +0200
        
                tdf#130857 qt a11y weld: Set "buddy" (mnemonic widget)
        
        . Together with the above commit, this commit
        makes the "Alt Text" label in the "Alt Text" dialog
        (cui/ui/objecttitledescdialog.ui) show up as expected
        with qt6 in a WIP branch that declares that .ui file
        as supported in QtInstanceBuilder::IsUIFileSupported,
        while it was previously shown as "_Alt Text".
        
        Change-Id: Ief58dfc6864da9043766eec4eec36da44ae7017b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174511
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [9df896fe542f474f7fe6972b3c5ebc8bd228bb52]

        tdf#130857 qt a11y weld: Set "buddy" (mnemonic widget)
        
        Based on previous commits
        
            Change-Id: I878eec7be5e82fac3e1b944d7fed7bf6711744ce
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 22:04:08 2024 +0200
        
                tdf#130857 VclBuilder: Move mnemonic-widget bookkeeping to base class
        
        and
        
            Change-Id: I32c922f91e5e1d06c003e6d26a4342cbb98942e1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 22:18:17 2024 +0200
        
                tdf#130857 VclBuilder: Extract setMnemonicWidget helper + call from base
        
        , implement handling for mnemonic widgets for labels
        for native Qt widgets in QtBuilder:
        
        * call BuilderBase::extractMnemonicWidget when processing
          a "GtkLabel" object, in the same way that VclBuilder
          does that.
        
        * implement actually setting the mnemonic widget by calling
          QLabel::setBuddy [1] in QtBuilder::setMnemonicWidget to
          set the "buddy" (mnemonic widget)
        
        This makes Orca in a WIP branch to support a native qt6
        "Alt Text" dialog announce the label text as well when
        the corresponding QLineEdit/QPlainTextEdit receives
        focus, as setting the buddy also ensures that the
        accessible labelledy-by/label-for relations get
        reported on the AT-SPI layer, see also
        
            commit 09789838bbbe57d207a66532b38cbba67ec59d70
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 21:39:44 2024 +0200
        
                tdf#119931: cui a11y: Specify mnenomic-widget in "Alt Text" dialog
        
        which describes the scenario a bit more for the gtk3
        variant.
        
        [1] https://doc.qt.io/qt-6/qlabel.html#setBuddy
        
        Change-Id: Iba1e766c0f2c5162beb5b938c134afab0dac68b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174510
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [b54ffcb1337fb76c8c29ce6145c914f80c7f95b5]

        tdf#130857 VclBuilder: Extract setMnemonicWidget helper + call from base
        
        Instead of iterating over the map of mnemonic widgets
        in the VclBuilder ctor, split the logic:
        
        Add a new purely virtual WidgetBuilder::setMnemonicWidget
        method to the base class that passes the IDs of a single
        pair of label + the corresponding mnemonic widget as params,
        and let WidgetBuilder::processUIFile call the method
        once for every pair in the map.
        
        Implement that for VclBuilder (by moving the remaining
        logic for that previously in the ctor) to the new
        override VclBuilder::setMnemonicWidget and add a dummy
        implementation for QtBuilder that only triggers a warning for now.
        
        Change-Id: I32c922f91e5e1d06c003e6d26a4342cbb98942e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174509
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [9bf932c00ba1ee8a2554f1c3c4bbc7ebff8b1995]

        tdf#130857 VclBuilder: Move mnemonic-widget bookkeeping to base class
        
        Move the `m_aMnemonicWidgetMaps` member and related struct
        and typedef from VclBuilder's `m_pVclParserState` to the base
        class BuilderBase's `m_pParserState` and also move the
        VclBuilder::extractMnemonicWidget method to the base class,
        so the logic can later be reused by QtBuilder.
        
        Add a new getter BuilderBase::getMnemonicWidgetMaps to
        get access and use that in VclBuilder instead.
        
        At least for now, VclBuilder::extractMnemonicWidget
        still explicitly needs to be called by VclBuilder
        (and other subclasses) when encountering a "GtkLabel"
        object for the mnemonic widget relationship to
        be added to the map in the base class.
        
        Change-Id: I878eec7be5e82fac3e1b944d7fed7bf6711744ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174508
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [fbd0030b97c9878c098498eb9213e73d4ae31e94]

        tdf#119931: cui a11y: Specify mnenomic-widget in "Alt Text" dialog
        
        Specify that the mnemonic widget for the "Alt Text"
        label is the text view where the description can
        be entered. This e.g. ensures that the a11y labelled-by
        label-for relations get reported.
        
        Drop the corresponding suppression for gla11y.
        
        When using the Orca screen reader with the gtk3 VCL plugin,
        Orca now announces "Alt Text" when the
        text view gets focus, while that was not the case before.
        
        Dialog can be triggered by e.g. selecting a QR code
        in Writer, then opening the context menu and choosing
        the "Alt Text" menu entry.
        
        Change-Id: I5c8b06198a45cfbe5e1fc4a85ac568094b596819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174506
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [71e819a2d774aa12ae9093762f5ab6fdaaa74eac]

        tdf#130857 qt weld: Add a QtInstanceTextView
        
        Add a native Qt implementation for weld::TextView
        QtInstanceTextView, that uses a QPlainTextEdit,
        and let QtInstanceBuilder use it when it
        encounters a "GtkTextView" object in a .ui file.
        
        Implement methods which are probably the most relevant
        ones. For now, trigger an assert in case any of the not yet
        implemented methods gets called.
        
        None of the .ui files currently marked as
        supported by QtInstanceBuilder uses this new class
        yet, but it will be needed to support more in the future,
        e.g. for cui/uiconfig/ui/objecttitledescdialog.ui.
        
        With this commit in place, adding that file to the
        set of supported ones in
        QtInstanceBuilder::IsUIFileSupported makes the dialog
        somehow show up as a native Qt dialog with the qt6 VCL
        plugin when e.g. selecting a QR code in an existing
        document, then opening the context menu and choosing
        "Alt Text", but there are various issues that still
        need to be fixed before it can actually be claimed
        as working/supported.
        
        Change-Id: Id7217d4a8a86f953d8b289c8a09cb8d1e2040bf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174495
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [e0b4f69ef3885ab9bf1fd5a22430f1581259fb67]

        tdf#130857 qt weld: Add basic handling for "GtkScrolledWindow"
        
        Create a QScrollArea when encountering a
        "GtkScrolledWindow" object in a .ui file.
        
        This commit does not yet implement an
        actual Qt-native weld::ScrolledWindow,
        i.e. QtInstanceBuilder::weld_scrolled_window
        currently still triggeres an assert.
        
        This will help to support
        cui/uiconfig/ui/objecttitledescdialog.ui,
        which has a GtkScrolledWindow, but
        SvxObjectTitleDescDialog doesn't explicitly
        interact with it, so this basic implementation
        is sufficient for a start.
        
        Change-Id: I80d2565e57809be0cc3ae452359d0d1b827e46f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174494
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [778fb6b8f7273f8c792c3c7c78e5ec2acb5e3463]

        tdf#130857 qt weld: Add QtInstanceEntry
        
        Add a native Qt implementation for weld::Entry,
        QtInstanceEntry, that uses a QLineEdit,
        and let QtInstanceBuilder use it when it
        encounters a "GtkEntry" object in a .ui file.
        
        Implement the most straightforward and probably most
        relevant methods, and trigger an assert in case one of
        the not yet implemented methods gets called for now.
        These can be implemented when adding support
        for .ui files whose dialogs make use of these
        features.
        
        None of the .ui files currently marked as
        supported by QtInstanceBuilder uses this new class
        yet, but it will be needed to support more in the future.
        
        Change-Id: I56e26fe22b1cc0cb7d61cfd1503991273957e23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174489
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [5c114216707d5bbc52ac361c802a696f64f8016c]

        tdf#130857 qt weld: Show help when help button clicked
        
        Add special handling for the "Help" button in
        QtInstanceDialog::handleButtonClick:
        
        Don't close the dialog with the corresponding
        response code, but instead request help, by
        calling Help::Start with the widget's help ID
        and QtInstanceWidget as parameters.
        
        Together with the previous commit
        
            Change-Id: I274886d8045b31ccbc92f586e2ead20ff7407d15
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 14:41:29 2024 +0200
        
                tdf#130857 qt weld: Handle help ID
        
        that implemented setting/getting the help ID
        for a QtInstanceWidget, this makes the "Axes"
        (online) help page show up when pressing the
        "Help" button in the "Insert Axes..." dialog
        when using the qt6 VCL plugin, which is using
        a native QDialog by default since
        
            Change-Id: I15901f83192ba33ddc5c5eb779be680f26cb6b55
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 10:53:28 2024 +0200
        
                tdf#130857 qt weld: Declare support for chart "Insert Axes" dialog
        
        (See that commit's commit message for how to trigger
        the dialog.)
        
        See also Dialog::ResponseHdl for the VCL variant,
        which also has a corresponding special handling
        for the button with response code RET_HELP.
        
        Change-Id: I81e682822defec7a1e58d5a1b3b3eadc3f0040c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174482
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [1d4b1feeb47bddd1743c7080dd8bd778fa770ede]

        tdf#130857 qt weld: Handle help ID
        
        Implement handling for the help ID by using a
        new property PROPERTY_HELP_ID that is set
        on the QtInstanceWidget's QWidget.
        
        Implement QtInstanceWidget::set_help_id
        and QtInstanceWidget::get_help_id accordingly.
        
        For setting the ID, introduce and use a static
        helper method QtInstanceWidget::setHelpId
        and use that in QtBuilder::makeObject to
        set the help ID based on help root and widget
        ID, in line with what is done at the end of
        VclBuilder::makeObject for the vcl::Window-based
        builder.
        
        Change-Id: I274886d8045b31ccbc92f586e2ead20ff7407d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174481
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [fe39249c795446641e83c06d49ac3c9e196fd660]

        qt: Add SolarMutexGuard in QtInstance::CreateFrame etc.
        
        These methods call QtInstance::RunInMainThread,
        so must hold the solar mutex, see the call to
        
            DBG_TESTSOLARMUTEX();
        
        at the very beginning of that method.
        
        (I've seen QtInstance::CreateFrame getting
        called without the mutex held in a WIP branch
        to add support for the "Help" button for
        native (welded) Qt dialogs.)
        
        Change-Id: I46adb708a84c031d63d94768c7600cbf3940ad21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174480
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [115e812175ecc5c057bb265a97a8a4582c14bbb6]

        tdf#130857 qt weld: Move button clicked logic to QtInstanceDialog
        
        Move the logic to close the dialog with the corresponding
        respone code when a button gets clicked from
        an anonymous lambda function in QtBuilder::tweakInsertedChild
        to a new static helper method in QtInstanceButton:
        QtInstanceDialog::handleButtonClick
        
        This is in preparation of adding special handling for the
        "Help" button in an upcoming commit, which - unlike other
        buttons - should not just close the dialog with a corresponding
        response code.
        
        Change-Id: Idfd08d90df930a25437f99a609a38804bf80bff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174479
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [8e21f46f9524986d67cc4aaccf4188d3f1887570]

        tdf#130857 qt a11y weld: Apply ATK/a11y properties
        
        Set accessible name and description on the QWidget
        as specified in the .ui file.
        
        This e.g. makes Orca announce the a11y description
        of the checkboxes in the "Insert" -> "Axes" dialog
        newly supported by QtInstanceBuilder since
        
            Change-Id: I15901f83192ba33ddc5c5eb779be680f26cb6b55
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 10:53:28 2024 +0200
        
                tdf#130857 qt weld: Declare support for chart "Insert Axes" dialog
        
        Change-Id: I403139577e6a932bb92da851dabd3cb994453083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174468
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [c47029a8c5b7c376638aeb37c0e17bb0a3410a75]

        tdf#130857 qt weld: Convert GTK to Qt accelerator/mnemonic
        
        When setting the checkbox text, don't pass the
        string as is, but convert to Qt's convention
        for the accelerator, using "&" instead of "_",
        using the existing helper function.
        
        This addresses the following issue mentioned
        in previous commit
        
            Change-Id: I15901f83192ba33ddc5c5eb779be680f26cb6b55
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 10:53:28 2024 +0200
        
                tdf#130857 qt weld: Declare support for chart "Insert Axes" dialog
        
        > Mnemonic underlines for the checkboxes are currently
        > not the way they're meant to be, but that's a different
        > issue that will be addressed in a separate commit.
        
        Change-Id: I7b86adf396297de8de9b28fcb7e46c3428893c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174467
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [0a5354139af1a698eb372f839a8663a3f80d5fe3]

        tdf#130857 qt weld: Declare support for chart "Insert Axes" dialog
        
        Add the .ui file for the "Insert Axes" chart dialog
        to the list of .ui files supported by QtInstanceBuilder.
        
        Now that
        
            Change-Id: Ie917a501466bad8821fc3e7f5049db7c1a56995f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 4 10:38:32 2024 +0200
        
                tdf#130857 qt weld: Create QGroupBox for "GtkFrame"
        
        added support for "GtkFrame", all widget types used
        by that dialog are handled by QtBuilder.
        
        This dialog can be seen as follows:
        
        * start Calc
        * "Insert" -> "Chart", confirm with "Finish" button
        * "Insert" -> "Axes" (while the chart is still selected)
        
        X and Y axes are shown/hidden as expected according
        to whether the corresponding checkboxes are ticked
        or unticked before closing the dialog using "OK".
        
        Mnemonic underlines for the checkboxes are currently
        not the way they're meant to be, but that's a different
        issue that will be addressed in a separate commit.
        
        Change-Id: I15901f83192ba33ddc5c5eb779be680f26cb6b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174466
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Michael Weghorn  <m.weghorn@posteo.de>  [e2e59d2da1aa4c9f8df62e5a072f0f2cd931781b]

        tdf#130857 qt weld: Create QGroupBox for "GtkFrame"
        
        Handle "GtkFrame" objects from .ui files and create
        a QGroupBox [1] for them. While there's also a QFrame
        class in Qt, QGroupBox seems more suitable, as it
        allows setting a title, while QFrame doesn't.
        
        Add special handling for the label child of the
        "GtkFrame". Quoting from the GtkFrame doc [2]:
        
        > The GtkFrame implementation of the GtkBuildable interface supports
        > placing a child in the label position by specifying “label” as the
        > “type” attribute of a <child> element. A normal content child can be
        > specified without specifying a <child> type attribute.
        
        Example for a frame label in chart2/uiconfig/ui/insertaxisdlg.ui:
        
                <child type="label">
                  <object class="GtkLabel" id="label1">
                    <property name="visible">True</property>
                    <property name="can-focus">False</property>
                    <property name="hexpand">True</property>
                    <property name="label" translatable="yes" context="insertaxisdlg|label1">Axes</property>
                    <attributes>
                      <attribute name="weight" value="bold"/>
                    </attributes>
                  </object>
                </child>
        
        In order to set the label's text as the text for the
        QGroupBox, identify that label child in
        QtBuilder::tweakInsertedChild, take over its
        text as the QGroupBox title, and mark the label
        for deletion, as it's no longer needed, since
        the QGroupBox handles its title itself from
        then on.
        
        [1] https://doc.qt.io/qt-6/qgroupbox.html
        [2] https://docs.gtk.org/gtk4/class.Frame.html
        
        Change-Id: Ie917a501466bad8821fc3e7f5049db7c1a56995f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174465
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-05  Noel Grandin  <noelgrandin@gmail.com>  [e1e7a1ef0f4abc10a55cf9b093468ba6adf0505e]

        cid#1556892 Data race condition
        
        Change-Id: I69e3148fc01378a5cea5f23aa992658db3997edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-05  Noel Grandin  <noelgrandin@gmail.com>  [46f5aa4f5897b6c3a151cf7bca0d4fcc6cd985c4]

        cid#1607010 Data race condition
        
        Change-Id: Ic89cfabeb25b0b82f2b766ea81f13b0d91bd8de8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-05  Noel Grandin  <noelgrandin@gmail.com>  [5195aadf1cfcf53316ff4d5b36635548e95120cb]

        cid#1607477 Data race condition
        
        Change-Id: I8efcac94aebd10af8d6e749bbf9ad57a0097da49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174499
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [19566380abbb936104076ae42d34f2075a89dc65]

        Re-organise the skia makefile
        
        so it more closely corresponds to the GN buildfiles that it is derived
        from, in order to make updating to newer versions of skia easier
        
        Change-Id: Iffd934d0bb05f4abe2b97838eb18baccac4a5096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-05  Jonathan Clark  <jonathan@libreoffice.org>  [99c7cf2816b2d0016832552dbe6c55456ade42e0]

        crashtesting: fix font-dependent infinite loop in kashida justification
        
        Commit c3c29d31d77ff93aa50634cfd51c62d12dc0f6ec (tdf#140767 Implemented
        Syriac justification) indirectly introduced a font-dependent infinite
        loop in Writer layout by relaxing some restrictions on kashida candidate
        positions. The infinite loop was found in tdf97806-2.odt.
        
        This change fixes an underlying logic bug in Writer, which caused Writer
        to attempt to apply kashida justification to non-Arabic/Syriac CTL
        scripts. This change also reintroduces some of the previously-lifted
        restrictions on kashida candidate positions.
        
        Change-Id: I783bf327f4ef0f1f6a032f0d3dddbcfd60a026fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174503
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-10-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [75f3ee7e8a06ed5fec17c358c62e3efeb8d13e8d]

        Initialize sw::DocumentSettingManager::mbNoClippingWithWrapPolygon
        
        ...newly introduced in 3800ab58355385dcb482d3089accc7ce141f5ee9 "tdf#161233
        paint pictures completely also with contour wrap", and which started to make
        CppunitTest_vcl_pdfexport2 CPPUNIT_TEST_NAME=testTdf124272::TestBody fail with
        
        > pdfexport2.cxx:180:Assertion
        > Test name: (anonymous namespace)::testTdf124272::TestBody
        > assertion failed
        > - Expression: it != pEnd
        
        in some builds like <https://ci.libreoffice.org/job/lo_ubsan/3327/>
        
        Change-Id: Ie55e532d8490262020388a56299390f0dd158a4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174490
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [037efad7b73f183a5d54808fa12c519276a8e7ce]

        cid#1607024 silence Overflowed constant
        
        and
        
        cid#1607900 silence Overflowed constant
        
        Change-Id: I18ef4b6885f872697c272b9fedc6a3e92a0df587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ed75a40d3c971ed9b74a0a130d9d082bdf751589]

        cid#1606631 Overflowed constant
        
        Change-Id: I5dda80aaa2fa7ec47ad005048ec3738481e5b50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [67158da00e965c90495bb4f339ea25bbec898c60]

        cid#1608061 Data race condition
        
        and
        
        cid#1607995 Data race condition
        
        Change-Id: I18914bd2e70b60c6aa8b34435677f0278367b722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174485
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f37542a29121ce64a306abb2c7e4d572cf245e35]

        Make Start Center pin icon highlight behave as intended
        
        After
        commit 9a37652b79001bf5208841b9221dee851b9b6d0f
        Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Date:   Wed Sep 6 17:03:26 2023 +0200
        
            tdf#156959 - Remove pinned icons from thumbnail view item
        
            Remove pinned icons from thumbnail view item and pushed it down
            to the recent documents view item. This avoids that the pinned
            icon will be shown in a simple thumbnail view, e.g., in the
            thumbnail view of the side pane in base.
        
            In addition, fixed an error with the number of elements in the
            thumbnail view in the start center when items are pinned, i.e.,
            removed a spurious new line.
        
        ... the pin icon stopped changing its state to highlighted.
        
        I believe my commit makes it work like Andreas intended.
        
        Also fix a typo in a member name to prevent accidents in the future.
        
        Change-Id: I074b1ebb773466d72b9fc381b6f1066d2dbc353e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174493
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-10-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9a2c38530dd5e479a96953980ee7f6c448dce87a]

        tdf#163019 - Remove the formula of a cell during paste special
        
        Remove the formula of a cell during paste special and not only the required for insertion. Otherwise, the formula listeners are not updated correctly leading to a crash during the repaint process.
        
        Change-Id: I4bf1410ecc7b25e36e1cc91bc0cd5335decb1cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173975
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-10-04  Pierre F  <fpy@bger.ch>  [5ac3a1565101fdda980a28a26e3baca36293a472]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a3d5c1442a38c08407b4a0e4e54d4ca79d14e380
          - tdf#143846 split BASE + BAHTTEXT
            
            new helper : xsltproc  --stringparam func BAHTTEXT helpers/calc_text_func.xsl source/text/scalc/01/04060110.xhp > source/text/scalc/01/bahttext.xhp
            
            Change-Id: I40c33d486c45ef0a3316dba1c0aea4af68ff9f37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172748
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [67d01815daee05e7991b12a0696888e7c8f6b3d9]

        expand and drop getContext
        
        Change-Id: I8bfa5ba7d4767d2e2be1b32f8569d606e62debe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174484
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e98b65e47182dba766bb7e3b2cd26e90da89fb93]

        Update git submodules
        
        * Update translations from branch 'master'
          to d5e786eb569095ac348028ca7878e44bc4543dc1
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ic61d23eabfdbe3635267c095d71fc71cd0a455fe
            
2024-10-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [c914a9da325616cb7a6319ffdc80b584db236cb4]

        unoxml: port testXNodeList_ChildList from java to c++
        
        Change-Id: I75d4d9bb275ac1d50fe92f6bd193037f81e3ac64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174478
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [acc52f9bc0dbfcb5a8893b5aff2d18a2360d46e2]

        tdf#162948: Add support for gte attribute in conditional format
        
        Change-Id: I3dd1a9499ec8d3685b84f3745cf4156b75d1f76f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174470
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [df54f8a4bd8970cf13e6a6aaf9056afccf2cc758]

        related tdf#163291: revert workaround for tdf#137922
        
        It's no longer needed after bb0e5aa97965b2710200da677db032289c373afe
        "tdf#163291 Fix AdditionsDialog in start center"
        
        This reverts commit 63b0565ad137e5d81932f1fabba732ba40f6cb70
        
        Change-Id: Ib89ddaf9a9654220ade6f40a6c48933763ca4a30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174477
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f61cc4f12249bf4905355cee35bfc44e88d9fc39]

        allow editeng html import to treat divs as inserting a newline
        
        optional, currently cowardly defaulted off, except for the specific
        use-case.
        
        Change-Id: I8a6176ee356fa4d2b665d5325d9b7aba2a6579f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174472
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d94b7988f2fa90d7ca4790183cefea8950da834]

        support setting writer comment contents from simple-html
        
        Change-Id: I42002c1b1ade940603ca6d2ca0f6072f1672cce8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174471
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [71293e4c194850b9f56fe9cc6eee2531e225b94c]

        sc: convert import test into export test
        
        In preparation for a follow-up patch
        
        Change-Id: I3a981d28004e9888b749eb497ef871a9cac658c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174473
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-04  Hossein  <hossein@libreoffice.org>  [bb0e5aa97965b2710200da677db032289c373afe]

        tdf#163291 Fix AdditionsDialog in start center
        
        Previously, AdditionsDialog was not working while in start center. Also,
        there were a lot of code duplicates. This patch fixes these issues.
        
        The UNO command .uno:AdditionsDialog was incorrectly implemented as
        application specific. There were multiple duplicate conditions for
        checking SID_ADDITIONS_DIALOG in each and every application. Now, this
        is only done in sfx2/source/appl/appserv.cxx in a single point.
        
        The AdditionsDialog can now be opened while in start center in different
        places of "Tools > Options" for icons, dictionaries, etc. Also, this
        LibreOffice BASIC code snippet opens it:
        
        Sub Main()
            oDispatch = CreateUnoService("com.sun.star.frame.DispatchHelper")
            Dim args(0) As New com.sun.star.beans.PropertyValue
            oDispatch.executeDispatch(StarDesktop.ActiveFrame,
                ".uno:AdditionsDialog", "", 0, args)
        End Sub
        
        Change-Id: Ifb7e466449008b9bb6e5b678da2e54f58bc101e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174469
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-10-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5739280623bcc111a0d8b808ca4cc5e6598f9cce]

        Split out this html parsing hunk as a separate NewLine method
        
        Change-Id: I1fb034af2419306f96152ce6802d193d7a1560af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174441
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-04  Rashesh  <rashesh.padia@collabora.com>  [263e0c5665a45bc181ac00803127ce2e12dfadc0]

        cool#10040: fix: send LOK_CALLBACK_CELLFORMULA with LOK formulabar update
        
        - we were not getting the cell content when we are editing cell using
        formulabar in online. This message is important to autocomplete formulas
        in online.
        
        Change-Id: I62da49cb8800583931ffefcc39ab181ab9562eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173333
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 67699071ba8bf51055028ea185b0afc2a1540f9e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174006
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>
        Tested-by: Jenkins

2024-10-04  Marco Cecchetti  <marco.cecchetti@collabora.com>  [a983af222ef3c227b22101578a5dba2c18688df0]

        fix-up slideshow: provide animations info
        
        Avoid to export json node with the same name
        node name moved to nodeName property
        
        Change-Id: Ibefc6689e6af22e9d2a27b39fd1e08ced6756051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174464
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-04  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [37d3e978c95a99bffda6d6d2c6b76cbf7521b185]

        tdf#163124: Show correct PopUp when SlideShow running
        
        When the non-native SlideShow in DrawViewShell::Command
        in drviews4.cxx (see !bNativeShow) is active, the above
        checks/actions have to be done to make the EditView work
        normally, but use the "page" standard context menu
        fallback only when SlideShow is not running to get the
        SlideShow popup menu - as expected when SlideShow is
        running.
        
        Change-Id: I6e3bc69023218fc0decce61581ddbc498e00d39c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174437
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-04  Michael Weghorn  <m.weghorn@posteo.de>  [3370e122d7f9edf40895f90706047ceb8ee7229d]

        vcl: Merge ImpTextView into TextView
        
        The only thing that ImpTextView had were the
        class members, and then all access to these was
        done from TextView using `mpImpl->`.
        
        Move the class members from ImpTextView directly
        into TextView and drop ImpTextView.
        
        Change-Id: I9fd6ebbdc497b87e2440d3d6a810b7c24488430b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174461
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-04  Michael Weghorn  <m.weghorn@posteo.de>  [427371814dc96ae7798a607de5eb9565d7a023f0]

        tdf#163225 vcl: Erase listbox bg when redrawing on mouse move
        
        Somehow, moving the listbox invalidation code from
        ImplWin::PreNotify to ListBox::PreNotify in
        
            commit fd7cb42f7d17d03e4fac6d8c5f1d6c7c49a36fc6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 14 16:16:30 2023 +0100
        
                tdf#153520 vcl: Align listbox invalidation with mouseover check
        
        triggered rendering artifacts for the tdf#163225 listbox example.
        It seems that the previous rendering operation apparently seems a
        pixel or so off from the current one and as the InvalidateFlags::NoErase
        flag gets passed, what was drawn previously is not erased.
        
        Don't pass that flag any more to ensure that the background is
        properly erased, which fixes the rendering artifacts.
        
        The flag's docmentation says:
        
            /** The invalidated area is painted with the background color/pattern. */
            NoErase              = 0x0004,
        
        Dropping the flag doesn't negatively affect drawing a listbox
        that has an explicit background color set in my tests, s. modified
        sample document attachment 196871 in tdf#163225 .
        
        Stop passing that flag in ListBox::StateChanged, too.
        
        Change-Id: Ibcacbed01888449db062f84b4782feb9de69851c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-04  Oliver Specht  <oliver.specht@cib.de>  [3800ab58355385dcb482d3089accc7ce141f5ee9]

        tdf#161233 paint pictures completely also with contour wrap
        
        Pictures/shapes with contour wrap are clipped in Writer.
        Word paints the pictures completely while the text flows above
        around the contour. This is implemented here for imported documents.
        
        Change-Id: I2a5fd89c18cbb3e88b65bc63e8105cc07b95af82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173869
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c5f4fe10589acff4d253cc3d32acaf67c7456bd7]

        check for null DocShell before deref
        
        an effort to fix:
        https://crashreport.libreoffice.org/stats/signature/static%20void%20sw::%60anonymous%20namespace'::TextFormattingCheck::check(class%20SwNode%20*)
        
        Change-Id: I5adb0a1c244ec3372bd58e5a5493cbce80684ae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174425
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-03  Julien Nabet  <serval2412@yahoo.fr>  [378dd9025e39f7a4e575ba09b7bde8e038fc0b26]

        Revert "tdf#163213: do not show OpenType features if the font has "morx" table"
        
        Reason: regression
        See https://bugs.documentfoundation.org/show_bug.cgi?id=163213#c14
        
        This reverts commit 0679a5cee16ae96c0d11e7d4fc1e59fb0f9cc591.
        
        Change-Id: Ib1392e2ad44577f69e6197bad8ae79791f072086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174435
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [94c33fb4f2141d9015db5ec4ea889e28ba27fa68]

        cid#1556166 Data race condition
        
        Change-Id: I2b5e4fe19c8ba4792b3cb89a90278540733192d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [9c59f0bc666ff841bd51eaaddbb04bb6470a13eb]

        cid#1556833 Data race condition
        
        Change-Id: I8b6b929240d9bd730480c5559bc40f39e9c93511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174430
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [6f7265ef036ca421654670b2b5fd59222a99ecd7]

        cid#1608220 Data race condition
        
        Change-Id: I7ff30128d663ca3524dc95ef99ef8c64dd158643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174429
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [fa58e872794f23a84e6a741f0d3074bca9f93c19]

        cid#1606585 Data race condition
        
        and
        cid#1606993 Data race condition
        
        Change-Id: I291829f0b59fc228ad3f305f280f7f58aae0d40b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174428
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [95faca7cf8e8bf09b30c3ee9f4d6b5e81a660c2f]

        cid#1555162 Data race condition
        
        Change-Id: I0f1aa14732d6fe32ac6875e29cb678cb0b2d2872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174427
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [259624bc6883f9505a28355f046724ddcefdb951]

        We don't need to constantly fetch SvtCTLOptions::GetCTLTextNumerals
        
        we are already listening to SvtCTLOptions and triggering
        SwViewShell::ChgNumberDigits if it changes, so can just keep
        the initial value and update it at that point.
        
        Change-Id: I669aeb755506b9d703a7c638a82c03935779ce8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [2be7689549ca126de2cb404e79f60c3f503a51fd]

        cid#1606754 Thread deadlock
        
        Change-Id: I51985e5ac573aa42c011730b73848ab55a4b2130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [16569ed32638464b4b6857fc2c29f59a919baed7]

        simplify SvxShapeCollection::dispose
        
        Change-Id: Idb1605b27995cbf9eccb2710f74f6ccb37547646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174409
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [db20a13d452ac5599416f64729d964829536a033]

        cid#1607746 Data race condition
        
        and
        cid#1608428 Data race condition
        cid#1607985 Data race condition
        cid#1607894 Data race condition
        cid#1607463 Data race condition
        cid#1607218 Data race condition
        
        Change-Id: Ifb30dd8490f41e06d47442c3a2b090b184932a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174408
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-03  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [c92846d670ba5c7f3a7abbced8e88fd214c87ca2]

        tdf#163234: CairoSDPR: PixelSnap corrections
        
        PixelSnap has to also snap control points, also
        simplified some stuff in line geometry conversion
        to cairo, plus more precise detection of when to
        apply piyel snap
        
        Change-Id: I41d27d8d513a62609a727dfd80f073356c901c49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174418
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [36d4938894a0c4ac3fecd2fe00991328560d4b8a]

        use more concrete UNO class in SdXImpressDocument
        
        Change-Id: I61fb3e0c5f76fd6208255dc1f1bc403c25221ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [9b26255f03d6049bb9c7eeed4b63da070849d7be]

        use more concrete UNO class in ValueSetAcc
        
        Change-Id: I9d6c31ccda4ff05f33d437ab064a2a55d84627b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Usman Akinyemi  <usmanakinyemi202@gmail.com>  [760686f8810b1a2a742b3a51063e12fb51b0323b]

        tdf#143148 Use pragma once instead of include guards in svx directory
        
        Change-Id: I1b26987848f0a7772a52fc07a811abd7098e0793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174419
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-10-03  Justin Luth  <jluth@mail.com>  [55a8fce5d76bba0657ed76c85439fac8d1d00c8d]

        tdf#159690 tdf#159938 Revert "tdf#158252 sc: Enable text wrapping...
        
        ... when inputting line breaks in cell"
        
        This reverts 24.2 commit 17e362e56f9e15d0214c441e632c91d22e58519d
        because it was made as a regression fix
        for a commit that I just reverted,
        AS WELL AS having several (duplicate) regression bugs of its own.
        
        Duplicate Bug 163150 is a good example of why a linefeed shouldn't
        automatically imply wrap text - it specified "fit to cell size".
        
        Duplicate Bug 159834 complains about this happening on drag/drop.
        
        Change-Id: Iad5fb87f9ab71230221c402a84ca682dba0ed004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174402
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-03  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [c3d6ceea874af90e81322ad205fcda62a1ab9890]

        slideshow: enable mics shape transition
        
        Change-Id: I88ac6dbba007f67b2d3648f7303869825f86b377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174417
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [87519013cb9ed1eae27f799a1a35c8a3cd0e3dd7]

        cid#1606693 Data race condition
        
        Change-Id: I107174d36f2bfa0cdcb7017838b1b4404179fb0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174407
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [12e7a664f8e0accea5b52d9537d8133a5e7a2c2c]

        cid#1554974 Data race condition
        
        Change-Id: I9b9b1bb9f63b9eaf294b27afbde4c39e773ede8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174406
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Noel Grandin  <noelgrandin@gmail.com>  [74ed4d1937449009343676546a937420a1ef5570]

        cid#1608230 Data race condition
        
        and
        cid#1607831 Data race condition
        cid#1607761 Check of thread-shared field evades lock acquisition
        cid#1606784 Data race condition
        
        Change-Id: Icbc872531117fbd9c22e33ffc560e07322f39ef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [76e8a1a2d719b23a9bfd5533e163a0a49328df0b]

        Fix typo
        
        Change-Id: I48ef74823ee2574439c977098f412d6a885af57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174403
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-10-03  Jonathan Clark  <jonathan@libreoffice.org>  [3937143065b00fc0ec5709a41c2135c19a11fc4b]

        tdf#134166 sw: Fixed RTL/LTR toolbar buttons not updating
        
        This change fixes an intermittent issue causing the text direction
        toolbar button states to not reflect page text flow setting changes.
        
        Change-Id: Ia20283b7efd4402dfa3b4ea9532d2b8ca6b1c8e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174414
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-10-03  Justin Luth  <jluth@mail.com>  [dafb629f4f5739e326fdf6b3f072fe139ed27c3b]

        tdf#161453 tdf#158252 tdf#159690 Revert "sc: Fix wrapText ...
        
        ...not being applied correctly on export"
        
        This reverts 24.2 commit 1760ee4d328cfb6ba22a5b3c84016625b12adb25
        which was presumably made for tdf#158460.
        
        There are two bug reports in QA statistics - Regressions with most dups
        that relate to the chain of commits started by this patch.
        So just revert everything and let any initial fixes start again fresh.
        
        make CppunitTest_sc_subsequent_export_test3 \
            CPPUNIT_TEST_NAME=testCustomXml
        
        make CppunitTest_sc_subsequent_export_test4 \
            CPPUNIT_TEST_NAME=testTdf152980
        
        Change-Id: I3df533daa67dfec0080c99dcdc2f593b1b6da8f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174401
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-10-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [784a508bba5a15d454babe5ec698868ab3dc0e3c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e377c9e115198486cb2b1c6f0348453653a906a5
          - tdf#162607 disambiguate hid2file.js, writer bookmarks
            
            + Removed misplaced bookmark
            + refactor
            
            Change-Id: Ieeaf10cd3dc3ed99f1b2265c46051cb06fc04ce7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174413
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-03  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [4b8cec7e83e675eeafb8d722c5d6fb3181a051d1]

        tdf#163047 sc: fix more pages on a single sheet printing function
        
        issue caused by commit I5e494a0714e398221bee00744d7e25c419a41df7
        "tdf#155218 sc: fix different page orientation in print dialog".
        
        Change-Id: I0b6f645dc77af83b132a415570e5dfca4a5abddf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174404
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [25ad0ee3c83925c39160d7d567e35d636c916809]

        unoxml: port testXXPathAPI from java to c++
        
        Change-Id: Iaeb6713edc8d8b54066eaa5b8de2f600b1c10296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174395
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [d937166f5121a1b0c381d1991cdc932c45afcddb]

        unoxml: port testXXPathObject from java to c++
        
        Code for "count(//foo) = 2" was duplicated
        Same for "//foo" which is already tested in
        testXNodeList_NodeList
        
        Change-Id: I2144552f5b687e639fef66b82463aae3bf82f53c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174394
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [466134863b5ceb76df743017fa175fdce2bbc597]

        unoxml: port testXNodeList_NodeList from java to c++
        
        Change-Id: I1a059ecb13e35518828b395f9eb9863930a3d12e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174392
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [cc7f535f1615f65ce276eb9e9d27b8a6b11aaa3a]

        tdf#130857 qt weld: Add QtInstanceCheckButton
        
        Add a QtInstanceCheckButton as the native Qt
        implementation for a weld::CheckButton.
        This uses a QCheckBox.
        
        Handle the "GtkCheckButton" object type from .ui
        files in QtBuilder.
        
        This will e.g. be needed for the "Insert" -> "Axes..."
        dialog seen in Calc after a chart has been inserted
        and double-clicked -- once further
        remaining aspects needed to be able to support that dialog
        has been implemented and it will be enabled
        in QtInstanceBuilder::IsUIFileSupported.
        
        The handling for the "inconsistent" state
        is mostly based on the the VCL implementation,
        see SalInstanceCheckButton::set_inconsistent etc.
        
        QtInstanceCheckButton::QtInstanceCheckButton::set_label_wrap
        remains unimplemented for now and triggers an assert,
        can be implemented when adding support for a dialog
        that actually makes use of it.
        
        Change-Id: I1e43ba25a23312534ee7cc0e650cd6e7aae20000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174398
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [9dd1c9f9df5b0a60ee9fbe8d7db79561ac3eca0c]

        tdf#130857 qt weld: Add new layout to parent layout
        
        Similar to the way it's already done for widgets
        a few lines above, also add a newly created layout
        to the parent layout (if the parent is a layout).
        
        This makes the case where a QLayout is inside a
        QLayout (e.g. a "GtkBox" inside a "GtkBox" in the
        .ui file) work, where previously, the inner layout
        wouldn't be added to the hierarchy, and thus
        not be displayed in the dialog.
        
        Quoting from the QLayout::addItem doc [1]:
        
        > This function is not usually called in application code. To add a widget
        > to a layout, use the addWidget() function; to add a child layout, use
        > the addLayout() function provided by the relevant QLayout subclass.
        
        Therefore, cast to QBoxLayout, the only QLayout
        type used so far and call QBoxLayout::addLayout
        to add the child layout.
        (This might have to be extended when using e.g.
        QGridLayout in the future as well.)
        
        This will e.g. be needed for the "Tools" -> "Word count"
        dialog in Writer or the "Insert" -> "Axes..." dialog
        seen in Calc when a chart is selected -- once further
        remaining aspects needed to be able to support those
        have been implemented and they'll be enabled
        in QtInstanceBuilder::IsUIFileSupported.
        
        Change-Id: I518b9a33be1db419737a80aee44d93b2a7be1094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174397
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [938b9988626a1a9ed233b1a1a118c7af48d56942]

        chart2: Resave insertaxisdlg.ui with glade 3.40
        
        This dialog can be seen by inserting a chart using
        "Insert" -> "Chart" in Calc, then double-clicking on
        the newly inserted chart, then opening the dialog
        using "Insert" -> "Axes...".
        
        Change-Id: Ie726805f7ec1e4ec81e74e90da7a3e7851cb4f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174396
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-02  Michael Stahl  <michael.stahl@allotropia.de>  [d5fcc8ea25e416a4d2bea5e0f92c0e403997d845]

        tdf#163032 sw: fix painting of row frame with rowspan > 1 cell
        
        Super non intuitive representation of a rowspan > 1 cell split across
        pages is that the follow frame will be in a row that's 0 height, but its
        own height extends to the bottom of the following merged rows.
        
        (regression from commit 13495926390ba54fbcd45ec00fbe613b1f2b734b)
        
        Change-Id: I0e32477613ceb5b6dbcc590bf70e0b5fc62a5d0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174399
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-10-02  Jean-Pierre Ledure  <jp@ledure.be>  [74b79b7ac1fb8be447d31e27691d4d6510fcb9e2]

        scriptforge.pyi - Typo
        
        Change-Id: Ieff7ec790c457b1f4f67544d3f300fc68723d5aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174393
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-10-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ea5e3865b4d47c796a36852c5d5e5a7b736a21cf]

        Hack reordering includes to avoid Windows Yield macro fallout
        
        No idea why my local Windows build started to only now fail with
        
        > [build CXX] desktop/source/app/updater.cxx
        > C:\lo\core\include\vcl/svapp.hxx(491): error C2208: 'void': no members defined using this type
        > C:\lo\core\include\vcl/svapp.hxx(491): warning C4091: 'static ': ignored on left of 'void' when no variable is declared
        
        or how to potentially address that properly with prewin.h/postwin.h...
        
        Change-Id: I8afbc0c485505ee8ab2cb956c58835bb6a73cab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174390
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [064937d0b5f6786e3ec347fdc5b2c771de348ffa]

        Avoid C4847 with --with-latest-c++ when compiling CLR
        
        > [build CLR] cli_ure/source/climaker/climaker_emit.cxx
        > c1xx: error C2220: the following warning is treated as an error
        > c1xx: warning C4857: C++/CLI mode does not support C++ versions newer than C++20; setting language to /std:c++20
        
        etc., as seen now with at least VS2022 Preview 17.12.0 Preview 2.1
        
        Change-Id: I34d5bca2a81e849ba24b8df5f41ebb12f08a75fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174389
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-10-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3c3d7b313424596188a4916a6469d8c3da4019bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f232ea1618140f45dc1643338e9d75a5bf2e49eb
          - Mute L10N for embedvar
            
            Change-Id: I7c03f7326d14499b391ab6971e766350ed6fcc11
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174325
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f09dc4ba952854adfe0165efcca401436c8671e]

        Get SolarMutex before calling ImplClearAllFontData
        
        to avoid:
        
        vcl/source/app/dbggui.cxx:35: void ImplDbgTestSolarMutex(): Assertion `ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && "SolarMutex not owned!"' failed.
        
        Change-Id: I6d56bb05e8a89190838c5437043bc61034607d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa496381da895ffc0767349cff3c6f3161743703]

        CppunitTest_unoxml_domtest: merge BasicTest and serializerTest
        
        And convert it into a class
        
        Change-Id: Ie2090ab3426ebc15ccccad8bbbc91d777d376c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174383
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-02  Mohit Marathe  <mohitmarathe@proton.me>  [a5cd4276244b9a635dab750e0decdf0c89d2d176]

        sw: replace hardcoded strings with SwResId to improve localization
        
        Change-Id: Ife431999fb53a44a2fab15468a995d91b5b65fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174354
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-10-02  Patrick Luby  <guibmacdev@gmail.com>  [a4e9584c554ea018691b2c97d38cce3d83f8ea9a]

        tdf#163000 don't add any fonts with an 'hvgl' font table
        
        macOS Sequoia added a new PingFangUI.ttc font file which
        contains all of the PingFang font families. However, any
        fonts loaded from this font file result in the following
        failures:
        
        - Skia renders font with wrong glyphs
        - Export to PDF contain a damaged embedded font
        
        Despite the fact that the fonts in this new font file have
        a TrueType font type, they are missing a 'glyf' font table
        and, instead, have a new, undefined 'hvgl' font table. See
        the following link for more details about the new 'hvgl'
        font table:
        
        https://gitlab.freedesktop.org/freetype/freetype/-/issues/1281
        
        Change-Id: I18170b1b226de86f79402ad0e45df8620c693f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174305
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [16684eb4baab740fddc443490b19bf64af2be8e3]

        tdf#163212: context-fill/context-stroke can also use gradients
        
        Change-Id: Ic6f7f5e0817d8f5fccee64938004aa899bde47dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174382
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dfffddceb12fe25ac3dd97281c3006502e04934]

        flatten ScMyStylesImportHelper::AddDefaultRange
        
        Change-Id: I7a3afbed392786eea3533318421959d8e2b0dbd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f6b8b18dc16d290382187693861404e9a405b34]

        tdf#161986 speedup ODS with large merged range
        
        reduces load time from 90s to 25s
        
        Change-Id: I7523776e5f4e2c4dc8645ccdf303e51178a9848a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174376
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [cb7e14bf370647a3fe618492ff79d0202c64c71f]

        tdf#130857 qt weld: Move runAsync logic to QtInstanceDialog
        
        Refactor the handling for running a QtInstanceMessageDialog
        asynchronously, and reuse the logic for the QtInstanceDialog
        base class:
        
        Move implementations for both QtInstanceMessageDialog::runAsync
        methods and the involved class members from QtInstanceMessageDialog
        to QtInstanceDialog.
        
        Split the previous logic from
        QtInstanceMessageDialog::dialogFinished into two methods:
        
        * move most of the logic as is to a new virtual slot
          in the base class, QtInstanceDialog::dialogFinished
        * override the base class implementation to get the
          response code from the actually clicked button
          via the PROPERTY_VCL_RESPONSE_CODE property
          set on that button, and call the base class
          method with that one.
        
        For QtInstanceDialog, there's no QDialog::clickedButton
        method that could be used to retrieve the clicked button,
        but it's also not needed there, because there a slot
        connected to the QAbstractButton::clicked signal that triggers
        closing the dialog, and passes the proper response code of the
        corresponding button already, see
        
            commit 08b55df5c9e42c1ccb78a156261811875629342a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Sep 28 00:32:15 2024 +0200
        
                tdf#130857 qt weld: Close dialog on button click
        
        With this commit in place, QtInstanceDialog can now
        also be run asynchronously, instead of the
        QtInstanceDialog::runAsync methods
        just returning true without doing anything.
        
        This will be needed e.g. when adding support for the
        "Tools" -> "Word Count" dialog in Writer.
        
        Change-Id: I4edb9443cb11d1dc831a18f708cdbdd67c239aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174374
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [169c56518e1213ea29b7ccbe746f75e5f13825a3]

        tdf#130857 qt weld: Let QtInstancDialog subclass QObject
        
        ... and add the Q_OBJECT macro, in preparation of moving
        some logic from the QtInstanceMessageDialog subclass
        to QtInstanceDialog for reuse.
        
        Change-Id: Iaf76ae3efb352dd04d15716174818e8a902a16cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174373
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-02  Miklos Vajna  <vmiklos@collabora.com>  [d5d7883fdecfb2c98c880ee2e957a1e34cba45bf]

        desktop lok: fix crash in getStyles()
        
        Crashreport backtrace:
        
        > program/libmergedlo.so
        >       getStyles
        >               desktop/source/lib/init.cxx:6411
        > program/libmergedlo.so
        >       doc_getCommandValues
        >               desktop/source/lib/init.cxx:6666
        
        Which is probably a call on an already disposed document. Fix it similar
        to how getFonts() does it.
        
        Change-Id: I1744bd04b7ebdea1b69ca121b8cfa47314d67528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174372
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0e23cabf2fd00f50e221f4eea7f19ceadc65fd54]

        cid#1606631 Overflowed constant
        
        Change-Id: I9ed28057b0435b78743303d1d6edea928598787b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dba433c1ee35969d9adfef7462c97f07fe206c68]

        cid#1606791 Overflowed constant
        
        Change-Id: I540f58b42366a1053ca59c1d31cb44784dcd9ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174378
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-10-02  Mohit Marathe  <mohitmarathe@proton.me>  [1a09da6c7ed13139586e5400fea223bac65fcac6]

        sw: give warning when comment cannot be deleted in comments panel
        
        Instead of crashing LO, this patch gives a warning if it is not
        able to find the comment or thread to be deleted
        
        Change-Id: Ia36e1b31929cea6c70322265b3062b5b8458291f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174107
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [4dc04a10692dc932658d9d079bbe97fcaf0b4742]

        qa: use SetODFDefaultVersion everywhere
        
        Change-Id: I4a08abea9a6c61a0365d238abf1021806ae6df29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174375
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-10-02  Miklos Vajna  <vmiklos@collabora.com>  [1c7f6188eb5b2a2bbf0cf589843d644306e40d6d]

        cool#9992 lok doc sign: avoid storing the sign cert in the model after sign
        
        Open the signatures dialog in LOK mode, add a signature, close it, you
        get a (non-async) popup asking if you want to automatically re-sign the
        document on each save in the future.
        
        This makes sense when only one user edits the document, but the LOK mode
        stores the signing certificates in the view, so this would mean user A
        can enable this mode, then user B could edit + save, which is not
        wanted.
        
        Fix the problem by just not offering this functionality in LOK mode,
        where we assume that certificates are per-view and the save works on the
        model.
        
        Change-Id: I180fc2e6078623d44f8414f7891481218df7cebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174369
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [2857c0b9cd096a83c7d0de927116dac1fd7c0b09]

        cid#1607055 Data race condition
        
        Change-Id: I1b1a3c426226c6ed4b9bb58a89bf727f48c5fc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [d1a9740735bcafe71325cb82bcebd82d219e2172]

        cid#1608281 Data race condition
        
        and
        cid#1608132 Data race condition
        cid#1607743 Data race condition
        cid#1607393 Data race condition
        cid#1607038 Data race condition
        cid#1606543 Data race condition
        
        Change-Id: Id6075bf9f28d3e77a487116f522d38d9e9d3fab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174363
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [30f437f4fc21ec83a597432a15e0ab570252a93d]

        cid#1556822 Data race condition
        
        and
        cid#1555688 Data race condition
        cid#1554983 Data race condition
        
        Change-Id: Iea24c9567de33aeaa519bc6b832ff1338b6d67be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174362
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [187728c38a654e1505d976524899d66fca37e993]

        cid#1607345 Data race condition
        
        Change-Id: I30798e5bfc6182e1b436c5116b49b7a4ae2328ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [e376719201d8300cff467eb8098aa932723413b4]

        cid#1557069 Data race condition
        
        Change-Id: Ic4a20cb5682c575affa9933a55d677a8048c4c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [3b60abdc948f3101d2107bd515f4ca31b041bd04]

        cid#1608390 Data race condition
        
        Change-Id: I98a8addad50888e5969fce5bf47d67f96b06ecf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174359
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Noel Grandin  <noelgrandin@gmail.com>  [9ea9c6f0fc5e08167906b22817ad03c3fd072e62]

        cid#1606901 Data race condition
        
        Change-Id: Id1d8f0895021719670c5419ab464c247ae3bf29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174358
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-02  Miklos Vajna  <vmiklos@collabora.com>  [ba7199da2e6ec9d58475373f264326fbeb31f4bd]

        tdf#156218 sw hide whitespace: fix increased page size on new para at doc end
        
        Create a document of 1 page, add empty paragraphs, so the next empty
        paragraph would create a second page. Hide whitespace, then add that
        paragraph: no second page is created.
        
        Seems this is a regression from commit
        2c23d4ee1e1370b20560e47db7efaeaac1d94b26 (tdf#96515 sw Hide Whitespace:
        avoid creating unneeded page frames, 2015-12-16), because previously we
        had the opposite problem: creating new page frames all the time, even if
        the current page frame could grow.
        
        Fix the problem by:
        
        1) In SwPageFrame::MakeAll(), fix the size of the page frame when
        switching to hide whitespace mode, so margins are not part of the
        height. At least the last paragraph of the doc is now near the bottom of
        the page, so it's more likely to create a new page. This means now we're
        back to still tweaking the size of the last page: but we used to
        determine the height based on just content and here we just ignore
        top/bottom margin.
        
        2) In SwPageFrame::CheckPageHeightValidForHideWhitespace(), handle the
        top/bottom margins, otherwise we'll think that the page frame can
        still grow, when it should not.
        
        3) Finally in SwPageFrame::MakeAll(), when we determine the height for
        non-last pages, the text frame for the new paragraph is already
        inserted, so limit the page frame height: if "content height" is more
        than "height - whitespace", then that limit should be the height,
        otherwise the page frame height will grow forever.
        
        Change-Id: I1125c31ec8b387df41c0881af98469d56ed773db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174368
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6f9d381d395a7573fc0c1eba4b73b0fdf50f047]

        Add ODF 1.3 Extended / ODF 1.4 versions to configuration and UI
        
        The new default is ODF 1.4 Extended
        
        Change-Id: I50f60cccde81b5ea320478314482cc67a7bcc2e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174343
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-10-02  Michael Weghorn  <m.weghorn@posteo.de>  [fd6d5c836ac4439ec44c4633353f73ebfbf97f82]

        tdf#130857 qt weld: Add initial QtInstanceLabel implementation
        
        Add a new QtInstanceLabel class as the native Qt
        weld::Label implementation and implement the
        straightforward and most important methods, and let
        the less common ones trigger an assert for now.
        
        Implement QtInstanceBuilder::weld_label to return
        an instance of QtInstanceLabel.
        
        This will e.g. be needed when adding support
        for the "Tools" -> "Word Count" dialog in Writer
        in the future, once more missing aspects have been
        implemented.
        
        Change-Id: I911bd68ad641b15883a0c6aa0707fd590fc05f96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174366
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-01  sopy  <contact@sopy.one>  [6d949b587b192ca572c187c1131e2a8947269337]

        perf: improve ScFlatUInt16RowSegments::dumpAsString()
        
        Change-Id: Ie4db90ae6e7a40824ad082606e4573e74956fdd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174142
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: vivek javiya <vivek.javiya@collabora.com>

2024-10-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [489613b93846d77a8ee33f5069f079c59dee563b]

        tdf#160202 - Don't extend selection over two words
        
        Don't extend the selection over two separate string in the BASIC editor.
        Probably, the BreakIteratorImpl::nextWord needs to be corrected which could lead to unwanted side effects.
        
        Change-Id: I0e980006cca672fb63216dc860c12a7004bfd759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173900
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [52942df3125d8ea3725f2847695cf7281bb4580b]

        remove some dead code
        
        ever since
                commit 9c92eb6800468de34c5aec3690c1b990a4e763c9
                Author: Noel Grandin <noel.grandin@collabora.co.uk>
                Date:   Mon May 13 15:42:27 2024 +0200
                createFromAscii -> OUString literals in OLimitedFormats
        
        Change-Id: Ic0ab48b13be3799ca5b3b20b9aa8289d8bee03f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [dd58b893f0734916919b14dcfc9941bb9dc3575b]

        tdf#160837 qt a11y: Don't report window role for non-top-level
        
        Quoting from offapi/com/sun/star/accessibility/AccessibleRole.idl,
        AccessibleRole::Frame is for:
        
        > A top level window with a title bar, border, menu bar, etc.
        > It is often used as the primary window for an application.
        
        However, the FRAME role also gets used for frames that
        are not actually top-levels at least with the Qt-based
        VCL plugins, where there is an object of role FRAME as a
        child of the actual top-level for e.g. the Writer main
        window. (The actual top-level is a QtMainWindow.)
        That frame contains the window content starting right
        below the (native) menu bar.
        
        Mapping the AccessibleRole::FRAME a11y role to
        the Qt equivalent QAccessible::Window would result
        in window-relative positions reported via AT-SPI
        to be relative to that frame, instead of the actual
        top-level, s. the implementation in qtbase's
        AtSpiAdaptor::translateFromScreenCoordinates [1]
        which calculates the relative position to the
        first top-level in its a11y hierarchy.
        
        This resulted in Accerciser's highlighting of the
        currently selected object to be too far up, as the
        "window-relative position" was missing the menu
        bar height in the y coordinate when window-relative
        positions are used, which is the case on Wayland,
        s.a. the commit message of
        
            commit a499874d9c0685d79b629b4bb246394b6b15691a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 26 18:22:12 2024 +0200
        
                tdf#160837 qt: Rely on toolkit for frame positions, drop menubar hack
        
        for more background.
        
        To fix this, prevent reporting an invalid top-level
        window role for frames that are not actually top-levels:
        When mapping AccessibleRole::FRAME to a corresponding
        Qt a11y role, take into account whether the
        frame still has another (real) top-level window as a parent.
        
        This makes the highlighted area in Accerciser become correct
        when using LO with the qt6 VCL plugin and Accerciser with
        ACCERCISER_WINDOW_MANAGER=kwin in a KDE Plasma Wayland session.
        
        The same would generally make sense for
        AccessibleRole::DIALOG. However, there that
        would currently result in the additional
        semantics of this being a dialog (not
        another kind of top-level window) getting lost
        when doing so. As dialogs usually don't have a separate
        menu bar, at least the incorrect reporting of window-relative positions
        is less relevant.
        
        Leave dialog unchanged for now, maybe reconsider later
        as needed.
        
        Ultimately, using native Qt widgets for dialogs (see tdf#130857)
        should presumably fix the underlying problem of the extra frame
        on VCL side being used altogether.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=da4a6cf78ff42a4f69c2775997ff174ef647f3f3#n2401
        
        Change-Id: I5ae066bd996f042b370b067a30213d3a1045480e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174350
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [885c0b1948668243bbb6379017a89834e31fdbab]

        use more concrete UNO types in reportdesign
        
        Change-Id: Ic5d773bc063629b13293ff875cb5c894373e7d08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174317
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [54fa4c438bd458d72a8e23a6819c7be639eaee92]

        tdf#162713 Changed format for date-field and time-field in form
        
        regression from
            commit 9c92eb6800468de34c5aec3690c1b990a4e763c9
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon May 13 15:42:27 2024 +0200
            createFromAscii -> OUString literals in OLimitedFormats
        
        Change-Id: I620526e3e0efd9e9376e428881e0240e2d3017d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3e14cda790f9a48fb167aef3108c61ef243a33f2]

        Fix typo
        
        Change-Id: I39388963a7e9b37c91e6b39e0af68a21de114431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174344
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c0a1e0d0e45fba239b5808d509861751adba069]

        Fix typo
        
        Change-Id: I2758c5ebacea4917beb3bedd96fa01f8e4ad2917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174346
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ad06ec4c5b1f7910bffb1898f8697013fb56a281]

        Fix typo
        
        Change-Id: I7a3a2f7d7e98c8bb34b31a3fb20b6a92493f5b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174345
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1cfc64a12d678dadb8452cb98de169fb2a84ebb]

        Fix typo
        
        Change-Id: Ie611105ff1e487657b6aacec6c0c22af095e2c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174355
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [1ab8cc73e084f590b1b624219c7af567145401dd]

        wina11y: Drop duplicate handling for focusable state
        
        Setting the `isFocusable` var to true and
        calling `IncreaseState` for the focusable state
        further down is unnecessary, as that already happens
        in the line just below the variable is set.
        
        Therefore, drop this duplication.
        
        In addition, the now dropped call to `IncreaseState`
        should have used the UNO state, AccessibleStateType::FOCUSABLE
        as well, not the IAccessible state, STATE_SYSTEM_FOCUSABLE,
        as AccObject::IncreaseState takes the UNO state while
        CMAccessible::IncreaseState (called by the former)
        takes the IAccessible/MSAA state.
        The switch from the UNO to the IAccessible2 state for
        the param was accidently done in
        
            commit a241661862ef35774f560e4068a895dcaa6f2113
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Sep 30 13:37:14 2024 +0100
        
                wina11y: Bridge focusable state as is
        
        Change-Id: I4b3923897444fdc75b15fe2cd9e91ba5f405507e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174341
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [5ba7e1586f03b8227f9c5a09d0b85587412ee2ae]

        wina11y: Use enum class for navigation direction
        
        Switch the `DM_NIR` enum to an enum class
        `NavigationDirection` and move it to MAccessible.{h,cxx}
        which is the only place where it's used.
        
        The param name of "flags" previously used in
        CMAccessible::GetNavigateChildForDM was misleading,
        as any of the values can only be handled exclusively.
        
        Change-Id: I39d8d6afc5c8c845b3aa0add7bd314501f4c91b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174320
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [8e0a3ee310fa361ffee5b4f4c86a4c19512ebf7d]

        wina11y: Drop unused defines
        
        Change-Id: Ic16f46b19b3478069cc9bafb4e6605f9a88733d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174319
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [d7e2dd82f3216c9f2b055a782c9d712c8a66394b]

        wina11y: Drop unused includes + "using namespace"
        
        Change-Id: I3006690efbedd75970eea34412392a36847db8d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174318
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-10-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3bc4538f4ab76a71ac9f4edc62d32fba8924b637]

        No broadcast on ObjectChange when in destruction
        
        Saw that on a stack on gerrit, checking if that is
        okay for the rest of functionality, should be
        
        Change-Id: Ifa61a54edb46b0c98afc59b77674e3686fa29a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174311
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-10-01  Michael Weghorn  <m.weghorn@posteo.de>  [09b4991701965f9b224bdce63b5a46da7e435bdf]

        a11y: Only send active-desc-changed event when ValueSet has focus
        
        When the selected item in a ValueSet changes,
        only send an AccessibleEventId::ACTIVE_DESCENDANT_CHANGED
        event for the newly selected item if the ValueSet itself
        has focus, as the active descendant is the currently
        active child of the current focus object.
        
        This prevents incorrect events that e.g. broke Orca's
        focus tracking and thus announcement of the current slide
        in Impress when moving between slides in the "Slides" panel:
        
        1) start Impress
        2) select the "Beehive" presentation template
        3) move focus to "Slides" panel
        4) use up and down key to navigate between slides
        
        Instead of saying "Slide 1" and "Slide 2" respectively,
        Orca sometimes announced "Layout, list with 16 items", as
        the 2 slides use a different layout, and thus switching
        between slides implicitly leads to the selection of the
        corresponding item in the "Layout" deck in the sidebar,
        which resulted in a corresponding ACTIVE_DESCENDANT_CHANGED
        event being sent prior to this commit, making Orca think
        that that item received keyboard focus.
        
        With this commit in place, Orca now announces "Slide 1"
        and "Slide 2" according to the newly selected slide
        in the "Slides" view.
        
        Change-Id: I543a4c94bae75dede7274a8b35f183ccd2ac0515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174342
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-10-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [0acab5124c0682dee75674fa55c9250908c93655]

        Remove unused BColorModifierStack from VclProcessor constructor
        
        Was not used and - if needed - should be done by embedding
        the sequence of Primitives sent to it to a
        ModifiedColorPrimitive2D containing the intended
        BColorModifier. Keep clases as simple as possible.
        
        Change-Id: I99de18cc971d6b396ad291ef88b59bd7599f9196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174314
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc0cb364ae479ccb98e4c064da87ad151cdb5f39]

        create method for doing the "dispose-on-destruct"
        
        which is (a) a little tricky and (b) needs to be on the base class to
        get the locking just right
        
        Change-Id: I425d4747e7e0ca0741fded9a6a70f6fa9995e102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [9939f5cbf044c7d671e7c9f55fa489e3e479f921]

        use more concrete UNO types in reportdesign
        
        Change-Id: I29b3b85f8ff71d66ca874434d5412145e5cfb731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9dcb13707a0dea6d04d55d66383078128cfe232]

        use more concrete UNO types in reportdesign
        
        Change-Id: I30e391c1d5166ad24e129a20db1d7403644f8791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174315
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d5c0b3f93d33ce1e3d320ee74d6b7b5c5d53d176]

        tdf#163230: make loop control hack more specific
        
        Commit 0c49aa58cfbb81073e34b1d47861a5a1fdd44114 (tdf#161508: add
        another loop control hack, 2024-06-11) only checked the frame area
        sizes and positions, but ignores the "valid" frags. It turns out,
        that these flags also needed when checking the loop condition.
        
        Change-Id: If155f2424b9a02cad6bf6d5c931dfccfb110d4c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174310
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-10-01  Michael Stahl  <michael.stahl@allotropia.de>  [5f191abb7bebe46ef0c139076857d7b982763ce4]

        sw: fix hyphenation dependencies of CppunitTests
        
        testTdf123898 fails locally but passes on Jenkins, because in Jenkins
        builds the hyphenation data doesn't exist yet (as verified by a
        CPPUNIT_ASSERT(xHyphenator->hasLocale(lang::Locale("de", "DE", OUString())))
        in first revision of this patch.
        
        Add makefile dependencies to all sw tests that call hasLocale().
        
        The test still needs to check though in case --without-myspell-dicts is
        used.
        
        Failure looks ignorable, adapt the test:
        
         Test name: (anonymous namespace)::testTdf123898::TestBody
         equality assertion failed
         - Expected: PortionType::Para
         - Actual  : PortionType::Text
        
        Change-Id: Iaa94e248b01f7bab7f8451f6b0ff08a7d0a8e9b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168669
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c77d6568067e722d7251060e4d739889151b75ba]

        simplify
        
        Change-Id: I8ff1c3c333b2a44871150da3929501dec00613e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Miklos Vajna  <vmiklos@collabora.com>  [298c2d5c8a6791aa6e5846b698d521079aaa445d]

        cool#9992 lok doc sign: update sign status after modify the list of trusted CAs
        
        Load a document, sign it, "green" icon on the status bar. Reload the
        document, turns into a "yellow" icon saying the CA is not trusted, when
        it was already trusted before.
        
        The trouble is that the document signature status is calculated on load,
        and the CA to be trusted is only given later, as part of the
        initialization of the LOK view.
        
        Fix the problem by invalidating the signature state when a new CA is
        trusted.
        
        The test document was produced by signing an empty document using the
        keys from xmlsecurity/qa/xmlsec/data/, which gives us a way to create a
        signature that is initially not trusted.
        
        Change-Id: I1e1dbf616ce54c4823d62104f838342de6870f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174307
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-10-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0a3e1df7af87d5917e13c82b747cff27f20cb29a]

        also set TMP in addition to TMPDIR
        
        primarily for Windows where unittests also use Windows' GetTempPathW
        function that prefers TMP over TEMP over USERPROFILE over the windows
        directory/doesn't respect TMPDIR
        
        Unittests not using TMPDIR is annoying since bitdefender will block
        access on some CVE tests. While you can create "dev drives" now that
        also allow you to disable AV-scanning permanently on those, that of
        course won't help when the files are created outside the devdrive/in the
        default temporary directory.
        
        Using TEMPDIR allows to specify the dir in autogen.input and the user
        won't have to add the regular temp-dir to AV-exclusions or remember to
        always disable the real-time-scanning before starting a build.
        
        Change-Id: I47349e4318e8de99e45961a4989975cf4081fc07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174267
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [89aef7ec59390ff5bbff2c6cc0160948ab5d07bf]

        TRANSFER_ACCESSINGROOT is unused
        
        since
            commit 03b2320067ba3d9855e075044e0427bc7f040bc2
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon May 10 13:20:50 2004 +0000
            INTEGRATION: CWS relocinst (1.30.68); FILE MERGED
        
        Change-Id: I01ad2cc00526cd4308aec9cbddcee3ef97baddd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174304
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [1683847f0f6e4d964ac529e125e39e6b047fbe17]

        loplugin:constantparam
        
        Change-Id: Ibf1f8b8c01333f87f8e8cd73ccb0d62f30fbcd2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6fdad723729a458eaff7ca509cb202ad355832be]

        loplugin:constantparam
        
        Change-Id: I81c9647ec7166ba429f6f58e3bd86b3a5ee4848f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [0210aac7f9f52701a3b3b74d4de8eaf86a52e8b5]

        loplugin:constantparam
        
        Change-Id: I114331d1cb7860087d5f5bee77af771e537b0616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [3bffef8f40a0259df390575929261248f36b695f]

        PaintSwFrame is always called with a nullptr for pPrintData
        
        ever since
            commit 3735d43955a000db8b6fff04a2214793be649c4b
            Author: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
            Date:   Wed Jun 5 09:14:23 2024 +0200
            tdf#161340 Revert partially 6cdf523f179f3e7ed94267502a5fe3d1247398cc
        
        Change-Id: I2f01ad09e6d0f758ff4e51be96008e93750e9f8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174300
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8734eddf4cce6c2c54556fee383f2764dbb981d]

        loplugin:singlevalfields
        
        Change-Id: I8f844c40dcb48737d95a3004cd7e8c730656d955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174299
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6f1841aedae66915bcc10287bdec21fc2ebe8eb]

        loplugin:unusedmethods
        
        Change-Id: I3897ccb3349874672b778835b9c15642cb1a14f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174298
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [73637f83ee92453eb6249acf9ceb2b39b5a9c4ea]

        loplugin:unusedmethods
        
        Change-Id: I121a0e1323df7b6669f496ad63d771df8f76b429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174297
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b72343010e9cb673126411372162f6a0dff39bc]

        loplugin:unusedmethods
        
        Change-Id: I6c6073e139f573f1680a7e9e52e95a221c9805b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174296
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ccad64046ec871b8f4524497a703f9548ddbdfa]

        loplugin:unusedfields
        
        Change-Id: I391bcae0c8491a17c57083e1375c8ed50d72ee9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174295
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noelgrandin@gmail.com>  [9a2f11cc1fc9b0157e185b39abbd6a50c4cfc8cd]

        cid#1607861 Data race condition
        
        Change-Id: Ib58f6613b98b2b778c9894359fe92b6fcf33298d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noelgrandin@gmail.com>  [ccef1a40d420a8220ac07e1cc6387c3d77cebcd5]

        cid#1607958 Data race condition
        
        Change-Id: I1d5d0c9eae073f69e4308163dcc62371c31e0d78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174292
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-10-01  Noel Grandin  <noelgrandin@gmail.com>  [e9d1abc0b059a4b6174d3a855757b2f745515907]

        cid#1608000 Data race condition
        
        just remove the mutex, this class is only ever accessed from one
        thread
        
        Change-Id: I7c088c0cb33d21513a5566ae65f663877d829072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noelgrandin@gmail.com>  [21e2158fa11757e43ccd904bba48553b8caba2ca]

        remove unnecessary null checks
        
        Change-Id: I73805881eef49fc6886f7f4fbc212da3aac1fd6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Noel Grandin  <noelgrandin@gmail.com>  [5c7b565fa842b1d48e5b7f102e9594985fd17df5]

        cid#1608069 Data race condition
        
        just remove the mutex, this class is only ever accessed from one
        thread
        
        Change-Id: Ie2b42a6a141676ee4cb14549d44f15fd55194aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-10-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a57c9e1acad3d2be35920ca2bb399ba2e925a51f]

        CairoSDPR: Support direct RGBA for convertToBitmapEx
        
        Added general interfaces to be able to render directly
        to an RGBA target SDPR:
        
        - processor2d::createPixelProcessor2DFromScratch creates
          a target-SDPR with given pixel size and RGB or RGBA,
          owning and using a cairo surface internally
        - processor2d::extractBitmapExFromBaseProcessor2D extracts
          rendered content to BitmapEx, including alpha
        
        All this is currently only implemented for Ciaro, thus
        the internal impls are encapsulated by USE_HEADLESS_CODE,
        but already created gererally available. The return values
        have to be checked to see if an evtl. shortcut is possible.
        
        For convertToBitmapEx this means that it can do conversions
        much faster than up to now for cairo when CairoSDPR is
        available, else it has to to the older slower way that
        also works and is the default: Create RGB content, create
        Mask, RemoveBlendedStartColor (see convertToBitmapEx
        implementation). This works and has the same quality,
        but needs two renderings and one bitmap operation, thus
        is clearly slower.
        
        Note that these interfaces can and will be supported for
        other SDPR implementations in the future, thus will make
        this converter automatically faster on systems where we
        will have a SDPR in the future, too.
        
        Also note that this is the gereral converter from
        a sequence of Primitives to Bitmap data, already used in
        many places, inculding UNO API, thus is expected to have
        some impact on conversion efficiency - if Cairo is used,
        so e.g. also headless.
        
        Change-Id: Ia638a549a04b19622892d91651317ec6727b6cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174266
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-10-01  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a9f006bf03ace169663cd2697b7596c51ed4f273]

        Avoid some macOS loplugin warnings around SQLWChars
        
        ...like
        
        > connectivity/source/drivers/odbc/OPreparedStatement.cxx:285:136: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
        >   285 | void OPreparedStatement::setParameter(const sal_Int32 parameterIndex, const sal_Int32 _nType, const sal_Int16 _nScale, const OUString &_sData)
        >       |                                                                                                                        ~~~~~~~~~~~~~~~~^~~~~~
        
        and
        
        > connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx:851:117: error: directly use a 'std::u16string_view' (aka 'basic_string_view<char16_t>') value instead of a _ustr user-defined string literal [loplugin:ostr]
        >   851 |         SQLWChars aCOL = !uCOL.isEmpty() ? SQLWChars(uCOL.makeStringAndClear()) : SQLWChars(u"" SQL_ALL_TABLE_TYPES ""_ustr);
        >       |                                                                                                                     ^~~~~~~
        
        caused by SQLWCHAR being 32-bit wchar_t on macOS (rather than 16-bit unsigned
        short, as on Linux), so SQLWChars is CHARS<sal_uInt32> (rather than
        CHARS<sal_Unicode>) with a ctor taking a std::u16string_view argument (rather
        than an OUString argument)
        
        Change-Id: I194af5feda5ba6279ed87264bc467b5d574406cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174263
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-30  Julien Nabet  <serval2412@yahoo.fr>  [0679a5cee16ae96c0d11e7d4fc1e59fb0f9cc591]

        tdf#163213: do not show OpenType features if the font has "morx" table
        
        Change-Id: I589419f7ffe3db01848e711021c2efd1de07692b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174294
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Tested-by: Jenkins

2024-09-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [393ea89729e7a16a927c77836b338b8482562c36]

        chart2: No need to pass mxComponent around
        
        While at it, move some methods where they are used
        
        Change-Id: I56151046f068d355f9bfe9769c0aee7d9cf95f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174036
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [0e6f683de6301ace4582901367ea10cb6bc143bc]

        wina11y: Drop "using namespace css::accessibility::AccessibleRole"
        
        Change-Id: I7c801f3101b0d4ed642cab799d44da092faa3bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174279
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [a241661862ef35774f560e4068a895dcaa6f2113]

        wina11y: Bridge focusable state as is
        
        Drop all the special-casing of particular (parent) roles
        etc. when considering whether or not to set the focusable
        state.
        Instead, fully rely on the AccessibleStateType::FOCUSABLE
        state as reported by the underlying XAccessibleContext
        and report the IAccessible/MSAA STATE_SYSTEM_FOCUSABLE
        state whenever the former is set.
        
        I tend to think that if this this change results in
        unexpected behavior, it is likely that issues should best
        be fixed in the underlying XAccessibleContext
        implementations rather than worked around in the Windows
        a11y bridge.
        
        Change-Id: I6e2eee3a9cbe779de3b3d349f23efc6a68a8344b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174278
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [3d0230b918d0d18a2e1562dd23d5afbbc8bac128]

        wina11y: Unify handling for editable/readonly state a bit
        
        The LABEL, STATIC and NOTIFICATION roles are
        used for readonly text, so if the EDITABLE state were
        ever set on these, that should be fixed in the underlying
        XAccessibleContext implementation instead of special
        handling to always set the readonly state in the
        Windows a11y bridge. Therefore, rely on the
        EDITABLE state not being set for these in order to
        report the IAccessible/MSAA STATE_SYSTEM_READONLY
        like for the other roles handled here.
        
        Change-Id: Ie8398ad0186d57ebf92701ab3a2c0603b50f5a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174277
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [7bd37ba0bfcaf8e68db562227c489db08796b641]

        wina11y: Rename UNO_MSAA_UNMAPPING to MSAA_NO_STATE
        
        ... to make clear that this is a constant with
        no state set.
        
        Also, move the definition to the only source file
        where it's used.
        
        Change-Id: Iaaba8d7053f71c63caab57c2b692b8e5898d37cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174276
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [7f2fe1837d01a62ae38a06496fb6bd677d31ae2b]

        wina11y: Drop always default AccObject::InsertChild pos param
        
        This `pos` param never gets passed explicitly, so is
        always the default `LAST_CHILD`.
        
        Therefore, drop the param completely to simplify
        this.
        
        Change-Id: I8f51fe58b47bb2f0c18a853c81b8b6c85d4a6602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174275
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [fb779c2acf62332c27c4af56c54b3561adcde123]

        wina11y: Move AccObject::GetExpandedState logic to only caller
        
        Change-Id: I5505abf795c1133b77b9c4ec7bb762401b9a3826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174274
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [ecae424190e0d07316eb5cb6e62f86356750a5fc]

        wina11y: Simplify AccObject::GetExpandedState
        
        * Drop the `isExpandable` out param that's unused
          at the only call site.
        * Use a bool return value instead of an out param
          for the remaining `isExpandable`.
        
        Change-Id: I2a37f0fec752f5e8e802ec781acf49035b3fbf2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174273
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [347fe07246fcd8f844edf43dc9ce973e4e0a15a8]

        wina11y: sal_Bool -> bool
        
        Change-Id: I348e293981bbaeec650a463c958c5e301a804422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174272
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [557b161bd6925299ccc0983feff30237697317eb]

        wina11y: Simplify AccObject::GetMSAAStateFromUNO with early return
        
        Change-Id: Ieeb152ac6e6ba99758fad0d202cc74614871401a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174271
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [59abbdea415598a2944325b525382146879a8d78]

        wina11y: Drop "using namespace css::accessibility::AccessibleStateType"
        
        Explicitly specifying the `AccessibleStateType`
        namespace makes the distinction between
        the UNO and the IAccessible2 states clearer.
        
        Change-Id: If8dba19fa716753b1b838377546c5c810e588e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174270
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ccbf0c4d6d2c8fffcc10d85b50ce6f47b565c72f]

        cid#1607858 silence Overflowed constant
        
        and
        
        cid#1608350 Overflowed constant
        
        Change-Id: I63ad25445df936821c896628b95686a535ef52cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174209
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ab0eb26f6ab5d02dd9c44d0257a416068809ac08]

        cid#1608502 Overflowed constant
        
        and
        
        cid#1607222 Overflowed constant
        
        Change-Id: If145bae8d05470173d1af6e7f540f8f40d7ab8b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174208
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [989bee48c2e06abc32fcf045d762c68fdfb34e87]

        cid#1608448 Data race condition
        
        drop mutex, only allowed to be called from ctor
        
        Change-Id: I1878cf368caacafdcee96a7112a6cc768ce87520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174207
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73db214e2f4f15c068d4e946ab0face6d0420199]

        cid#1606905 Data race condition
        
        Change-Id: I138cc2ef0f30ae4dcb0d86ada3a62507efc22340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174206
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb73e2c8b66ef3539e68ee8150e119bbe437955c]

        SdrGrafCropItem needs its own SfxItemType
        
        Change-Id: I45bf4abf015dd493451f77e66dd70006867a2a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174268
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [84725adbdc3419b78fad567b59456fdb80db3a93]

        use more concrete UNO type in file::OConnection
        
        Change-Id: I6fe51ae569430d8f31217d7781b3e98e79e1c607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c69ea1dd5a993c23d5be6a0ec40a7cac15fb2ecc]

        use more concrete UNO type in file::OStatement_Base
        
        Change-Id: I9ce6ed7768e8c79e6105152f3907a5468e8fb828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174282
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6571e77d03491090c9d3a4ef74295bd4cfc3fda4]

        use more concrete UNO type in odbc::OStatement_Base
        
        Change-Id: I86073baf25e2f10a57879fcedbbb1c0e8c354813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174281
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-30  Noel Grandin  <noelgrandin@gmail.com>  [da8a36b4f4fa86831dabbfe7794c835cd5f975b4]

        CID#1607066:Data race condition (MISSING_LOCK)
        
        which means we need to push knowledge
        about the locking down into ucbhelper::Result
        since the implementation classes there
        want to call back into the parent.
        
        and also
        
        CID#1607968:Data race condition (MISSING_LOCK)
        CID#1606657:Data race condition (MISSING_LOCK)
        CID#1607112:Data race condition (MISSING_LOCK)
        CID#1608365:Data race condition (MISSING_LOCK)
        CID#1607159:Data race condition (MISSING_LOCK)
        CID#1607018:Data race condition (MISSING_LOCK)
        CID#1607421:Data race condition (MISSING_LOCK)
        CID#1607766:Data race condition (MISSING_LOCK)
        CID#1606872:Data race condition (MISSING_LOCK)
        CID#1608523:Data race condition (MISSING_LOCK
        CID#1607191:Data race condition (MISSING_LOCK)
        CID#1608345:Data race condition (MISSING_LOCK)
        CID#1608577:(#1 of 1):Data race condition (MISSING_LOCK)
        CID#1607210:Data race condition (MISSING_LOCK)
        CID#1607132:Data race condition (MISSING_LOCK)
        CID#1608256:Data race condition (MISSING_LOCK)
        CID#1607482:Data race condition (MISSING_LOCK)
        CID#1607935:Data race condition (MISSING_LOCK)
        CID#1608070:Data race condition (MISSING_LOCK)
        CID#1607901:Data race condition (MISSING_LOCK)
        CID#1608013:Data race condition (MISSING_LOCK)
        CID#1607506:Data race condition (MISSING_LOCK)
        CID#1607526:Data race condition (MISSING_LOCK)
        CID#1607044:Data race condition (MISSING_LOCK)
        CID#1607708:Data race condition (MISSING_LOCK)
        CID#1608041:Data race condition (MISSING_LOCK)
        CID#1608207:Data race condition (MISSING_LOCK)
        CID#1608028:Data race condition (MISSING_LOCK)
        CID#1608168:Data race condition (MISSING_LOCK)
        CID#1607561:Data race condition (MISSING_LOCK)
        
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        CID#1607689:Check of thread-shared field evades lock acquisition (LOCK_EVASION)
        
        Change-Id: Ifbe908a4a86ab8c5fa1c4ed3b6f9466508e4900e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [080913a6b9159f11de93c106669c0a2f60db2ebc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to adbc8637e059f407b7c209af6ee017de2f1f9736
          - tdf#162607 disambiguate hid2file.js, chart legend dups
            
            + Removed bookmark from the wizzard help page
            + refactor
            
            Change-Id: I24adbc3bd02c05bb5b406ef6c8101b73150ba506
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174288
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c4e489196f08056e71f0453afdf65f9bb08f27b3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f46253b8e0673dca57f94ba95392676a40b3a407
          - tdf#162607 disambiguate hid2file.js, InsertCtrl
            
            + Removed misplaced bookmark in Calc
            + review of Insert toolbar for Calc
            + Refactor
            
            Change-Id: Ifc908c22a5c8e69e6f8ccc86b637baa0b009c7f3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174286
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3495ba034ac6e8213ce41f147bb3070acd917656]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96ba26db0cb10e32fc6650eb54fe279498c9eecf
          - tdf#162607 disambiguate hid2file.js, mail merge
            
            + Removed misplaced bookmark
            
            Change-Id: I8a65e0b85273759323448accddf80d299ed8782b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174285
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-30  Justin Luth  <justin.luth@collabora.com>  [cd141a97c3a42f52e0207875c903433739336eb4]

        related tdf#162884 writerfilter: map to built-in Internet link, etc.
        
        This partial revert fixes a 24.2.4 regression from
        commit 72ea1005b987159a6a59f9379e63321e0b0dd44f
        Author: Michael Stahl on Mon May 6 15:58:36 2024 +0200
            tdf#160402 writerfilter: extend StyleMap with all Word styles
        
        By using the English localization name,
        the style was imported, used, and exported as English
        instead of being mapped to the built-in style
        whose name depends on the UI language in use.
        So, revert back to using the internal version of the style names.
        
        For English -> Dutch, that means that
        Internet Link -> (MS Word's) Hyperlink -> Internetkoppeling
        instead of remaining as the English "Internet Link"
        
        For non-English UIs, the Internet Link character style
        was duplicating on each file save (or perhaps each language switch).
        
        I didn't notice the endless duplication for the other styles,
        because they aren't used very much,
        and are only written if used.
        At worst, each localized versions was written once.
        
        Change-Id: Icf58d7d716ac40f05f170c31787d8a8a9942868e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173230
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-09-30  Miklos Vajna  <vmiklos@collabora.com>  [ced420ca708eb8df5b20c7d537166bd9ec29a0e5]

        cool#9992 lok doc sign: convert the certificate chooser dialog to async
        
        1) Move the try-catch around assing a signature inside the block that
           already got the response from the certificate chooser, it's unlikely
           that choosing the certificate (and not yet signing) would fail.
        
        2) Convert the dialog to async and allow it to be a jsdialog.
        
        3) Hide not relevant widgets for LOK: we have a single signing
           certificate, so the search entry is not useful.
        
           The refresh button has an unclear purpose, as it was initially added
           in commit fb9874231fb242b4a6a7d1ce097e66dd4ed8f32e (Caching
           Certificates in the CertificateChooser dialog session-wise, 2023-08-26),
           but later commit efe414c4a88fde0e2ee1d4016010f21fbd6d01d7 (Don't reuse
           CertificateChooser instances, 2024-02-07) disabled this chaching. In any
           case, the certificate won't change during the lifetime of a single LOK
           view, so hide that as well.
        
        4) Invoke the inner certificate viewer in an async way, too.
        
        Change-Id: Ibf618ea7632cf801d1d9180b9aa7dd193c45ffda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174215
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e7c4129a5cc55c52c16af049f74cf67c48a10878]

        Silence -Werror,-Wdeprecated-declarations (macOS 15.0)
        
        Change-Id: Ic765a5c7259896d7b8caebd50460be57dec9ba64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174262
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c3b3b27e57e476ba0ee7060ccd2fccd687188893]

        loplugin:noexceptmove (macOS, LLVM 20 trunk libc++)
        
        Change-Id: I77a48bbdfcb3d80af69155b11b31ee8e8223bd64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174261
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-30  Noel Grandin  <noelgrandin@gmail.com>  [3d0058306385d0322c18d397fce1cd6e94daa1a3]

        dont use GetItemSurrogates for gathering SvxBrushItem
        
        which is very expensive these days
        
        Change-Id: I6ef85e3f635d11263d87cfd57c5153a450da46e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [250f35740d0916845761f54f64c1f37f35420978]

        Revert "Fall back to old bootstrap.ini [Win32] section, for backwards compatibility"
        
        This reverts commit ebd3f0971b843527ed493a35b2303c8c15b94109.
        Conflicts:
        	desktop/win32/source/loader.cxx
        	vcl/win/window/salframe.cxx
        
        Reason for revert:  This fallback functionality was documented as deprecated at
        <https://wiki.documentfoundation.org/index.php?title=ReleaseNotes/24.8&oldid=738731>
        "fundamental.override.ini", to "be removed in a later version", which is
        happening now for LO 25.2.
        
        Change-Id: I40a1800f6a05fc7fd7188917083b269ce6a9f1d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163394
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-30  Miklos Vajna  <vmiklos@collabora.com>  [9a92a4355ee60ab5d161eb67a1f255f4d6c4b5b8]

        svx: prefix members of SdrSnapView
        
        See tdf#94879 for motivation.
        
        Change-Id: I898a1c638258397a1964e409db413b00ba3f149f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174212
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-30  Julien Nabet  <serval2412@yahoo.fr>  [c6cc724d8805215c7b5ad7b76cd167c6640e8e52]

        tdf#158323: CRASH when switch back from HTML to Normal View...
        
        after edit in HTML code.
        
        bt:
        0  rtl::Reference<SfxStyleSheetPool>::get (this=0xb8) at include/rtl/ref.hxx:205
        1  0x00007f4361f3857c in SwDocStyleSheetPool::GetEEStyleSheetPool (this=0x0) at sw/inc/docstyle.hxx:236
        2  0x00007f4362dcb8e2 in SwPostItMgr::SwPostItMgr (this=0x558439087f60, pView=0x5584387f7e80) at /home/julien/lo/libreoffice/sw/source/uibase/docvw/PostItMgr.cxx:229
        3  0x00007f43630e6b14 in SwView::SwView (this=0x5584387f7e80, _rFrame=..., pOldSh=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1003
        4  0x00007f43632fee79 in SwWebView::SwWebView (this=0x5584387f7e80, _rFrame=..., _pShell=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/web/wview.cxx:85
        5  0x00007f43632feb51 in SwWebView::CreateInstance (rFrame=..., pOldView=0x5584356fa360) at /home/julien/lo/libreoffice/sw/source/uibase/web/wview.cxx:67
        6  0x00007f4393710655 in SfxViewFactory::CreateInstance (this=0x558434c3a090, rFrame=..., pOldSh=0x5584356fa360) at /home/julien/lo/libreoffice/sfx2/source/view/viewfac.cxx:26
        7  0x00007f4393501e31 in SfxBaseModel::createViewController
           (this=0x558431de5a80, i_rViewName="Default", i_rArguments=empty uno::Sequence, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520)
           at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:4334
        8  0x00007f4393502a3f in non-virtual thunk to SfxBaseModel::createViewController(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) () at /home/julien/lo/libreoffice/instdir/program/libsfxlo.so
        9  0x00007f43936b4ce4 in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView
           (i_rModel=uno::Reference to (SwXTextDocument *) 0x558431de5b10, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520, i_rViewFactoryArgs=..., i_rViewName="Default")
           at /home/julien/lo/libreoffice/sfx2/source/view/frmload.cxx:577
        10 0x00007f43936b1f6c in (anonymous namespace)::SfxFrameLoader_Impl::load
           (this=0x558436633660, rArgs=uno::Sequence of length 18 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5584360bf520)
           at /home/julien/lo/libreoffice/sfx2/source/view/frmload.cxx:759
        11 0x00007f439441ea51 in framework::LoadEnv::impl_loadContent (this=0x7ffdd69352c8) at /home/julien/lo/libreoffice/framework/source/loadenv/loadenv.cxx:1176
        12 0x00007f439441b7d4 in framework::LoadEnv::start (this=0x7ffdd69352c8) at /home/julien/lo/libreoffice/framework/source/loadenv/loadenv.cxx:412
        
        Regression from:
        https://git.libreoffice.org/core/+/d934aeace6e7049db3959421538ae382cb97b1d1%5E%21
        tdf#103064 sw,editeng: make para styles work inside comments
        
        Change-Id: Ib9a1c9fe779ad14f93de0e1b3645beddb85e511d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [e5aff0ed177e218bfec7c9f57f393379c051166a]

        vcl: flatten BitmapReadAccess functions
        
        Change-Id: Ib18aeca38270192364a12b6496223b0cce476b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173205
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [89f0b965b26eca7ca9be18122881b955072f3fa8]

        vcl: flatten BitmapPopArtFilter::execute()
        
        Change-Id: Icfbf2e625fb01f336c0c5eec8553b24922376680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173204
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [b021286327abed031e75b6dd6fa67790f24a700a]

        tdf#130857 qt a11y weld: Set GtkBuilder ID as widget's accessible ID
        
        Set the GtkBuilder ID specified in .ui files as the accessible
        ID for the QWidget created for the object, in line with what
        happens for other implementations as well. This is basically
        the equivalent of
        
            commit c64b823b74cbd3063d6e87643bd68ea5343b2f54
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 16 13:57:41 2024 +0200
        
                tdf#155447 qt a11y: Report accessible ID
        
        for the case where native Qt widgets are used instead of
        vcl::Window.
        
        Other than QWidget, QLayout is not part of the a11y
        hierarchy of an application, so there's nothing to
        do for these.
        
        This e.g. makes Accerciser show an accessible ID of
        "LicenseDialog" for the "Help" -> "License Information"
        dialog.
        
        The accessible ID set this way currently isn't reported
        on the AT-SPI level for QMessageBox (e.g. the "Save Document?"
        dialog) however. Suggested upstream change to make that
        work as well: [1]
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/594390
        
        Change-Id: I50e8ca6f8bea628df5a80d101c4a0a7bfded9c19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174158
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-30  Michael Weghorn  <m.weghorn@posteo.de>  [a44d515dd61f8e715c86ce1f05c3b4117a10c50d]

        tdf#130857 qt weld: Set dialog title and modality
        
        If the "title" or "modal" properties are set,
        set the dialog title/modality for the QDialog
        accordingly.
        
        This makes the "Help" -> "License Information" dialog show
        the "Licensing and Legal information" title for the native
        Qt dialog as well, which gets used by default
        for the Qt-based VCL plugins since
        
            commit 178430733b0687a0f9334dda9a66e9b58ec8e7b0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Sep 28 00:43:21 2024 +0200
        
                tdf#130857 qt weld: Declare support for "License Information" dialog
        
        Change-Id: I5c89eef04967d6d456474600f860dca19a6009e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174154
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-30  Noel Grandin  <noelgrandin@gmail.com>  [bf340cc7d08545dd2fd9c1c53a9f2907df3ad533]

        cid#1606686 Overflowed constant
        
        Change-Id: Ib2e96b80ee91d5617ae643202187460df0eb05a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Patrick Luby  <guibmacdev@gmail.com>  [8f3e84133628c420b7cc9896d6e92e2d66eae0b2]

        tdf#163000 don't add any fonts in the system "reserved fonts" folder
        
        macOS Sequoia added a new PingFangUI.ttc font file which
        contains all of the PingFang font families. However, any
        fonts loaded from this font file result in the following
        failures:
        
        - Skia renders font with wrong glyphs
        - Export to PDF contain a damaged embedded font
        
        macOS Sequoia still has separate, downloadable Type 3
        bitmap fonts for the PingFang font family so ignore
        any fonts in the PingFangUI.ttc font file and, just to
        be safe, ignore any other font files in the system
        "reserved fonts" folder that may be added in the future.
        
        Change-Id: I8a025c8b6d84a661b173aa7d6d5b261c92452b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174160
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [358298fd29caf3f20f84445aad0a907ccf54aff7]

        simplify
        
        Change-Id: I18e27d76af250ab8fa6534fdb1876a90e3343d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174185
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [2b4375fcfa5f1f852ab6c85ca82d55c2be324b70]

        cid#1606690 Overflowed constant
        
        Change-Id: I7d3556cbaa43ba7605005059545c3d52685d33c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Julien Nabet  <serval2412@yahoo.fr>  [bda6201f811836c1ef2696b516b8999e268878e9]

        tdf#163190: [pyuno] SyntaxWarning: invalid escape sequence '\P'
        
        Use raw string to fix this.
        
        Regression from d8978a8c4ffabd6b36a691fd3e2df68563808234
        tdf#116156 tdf#157162 tdf#159528 Fix glitches in officehelper.py
        
        Change-Id: I6f68fdc5988c05b41dc91619947d0d97d04bc739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174108
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b566dab48c1448dbc5442b30396e9f6c482f2408]

        Related: tdf#161826 - A bit more accurate Glow effect for texts in shapes
        
        With a more accurate exponentiation function the text glow effect, maybe
        can be more accurate comaparing to the MSO.
        
        follow-up commit: 3eac847927a0cdfa40c3fea38c473ed2ad7faecc and
        5bb5a7ea60c4496d7ad21ad81a0f37f6f5fd2288
        
        Change-Id: I82d6fae0564b8d9f5b519408b54a0937a674c643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173980
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-09-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [15492ec2d25db324ce60d5994563eb86bbbf992f]

        Add "f" suffix to literals of type float
        
        ...to avoid
        
        > error CS0266: Cannot implicitly convert type 'double' to 'float'. An explicit conversion exists (are you missing a cast?)
        
        (as would e.g. happen if offapi/org/libreoffice/embindtest/Constants.idl were
        included in regular builds)
        
        Change-Id: I6a4d8b151755edd3a8b03d73e2bb546cf1d19e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174200
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [a8cc5deeb1d5f10120a9207018808ef712844890]

        avoid temporary OUString in lcl_getSingleCellAddressFromXMLString
        
        Change-Id: I3ec79a4ae0259babb8aa472c338cc78910abc800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [9e5321f46d175e827924a8040f6325cdcd7d751f]

        cid#1606810 Overflowed constant
        
        Change-Id: I831acf42054d16d16714ff3ec46eefbfaa24047e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174180
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [68110da8242677d67a48ad04e4279f7220da2086]

        cid#1606852 Overflowed constant
        
        Change-Id: Ib77efd3069d81a9c4b6cdb78e795def327e27368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [c2aad1b6b7e5c7976969824bb8707483333d9f24]

        cid#1606889 Overflowed constant
        
        Change-Id: I5c0b458aca0ffc1b16eba31ace4039cd359160f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174178
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-29  Arnaud VERSINI  <arnaud.versini@pm.me>  [5ea219eb86ce2520bcfea8d92afd1ffb54bd9c31]

        package : no need to use OUString here.
        
        Change-Id: I7e46e1c89e85c0baf941393237fee971f0a0863e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173770
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [0e955c4b236bcf9e66e7b49cc3ae285f1a4a9e32]

        cid#1607049 Overflowed constant
        
        Change-Id: I9f031fa3ad7a216435c72692d92d7b566417977b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [f213fcb8c75cde4a9ea5075ac87eea6af470bbac]

        cid#1606997 Overflowed constant
        
        Change-Id: I7973793a084c2bcd05f1ede9546094410ffc31cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ca68ddebe71a0d218c99c88c5595c128957b6f15]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f23809799bd7f131da88b4e25d5df5518fdbc12
          - Fix typo
            
            Change-Id: Ie5eb123d87c8d1993f3699c20687044835381e47
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174159
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Jenkins
            
2024-09-29  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [529dfc741a4ad6735937adaf10acdd567da4f84c]

        tdf#163170 Add support for MS Visio Template format with .vstx extension
        
        libvisio is already supporting .vstx template format.
        With this patch the LibreOffice is recognizing such file types,
        and successfully opening it.
        
        More information about format:
        https://learn.microsoft.com/en-us/office/client-developer/visio/introduction-to-the-visio-file-formatvsdx
        
        Change-Id: Ibee01288cdb2cd6a0ac3f371a22604d7bb5b471c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173997
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [b0aa70c9565f5ef4467db1711519edc9859e9fdb]

        cid#1607243 Overflowed constant
        
        Change-Id: Ia5d57d8612d8a2a8079c22e5dd739c249fa9262d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174151
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [2009ecbeb1b6b4c771c79ea695e34e7bf4e10965]

        cid#1607257 Overflowed constant
        
        this is a false positve, but perhaps we can help coverity work it
        out properly with some constexpr
        
        Change-Id: I8398153d6678585dacf4acaf7081ec32094bcda6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174150
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-29  Noel Grandin  <noelgrandin@gmail.com>  [df389675fc1e6c4f620b6769cc70c9c3b794175a]

        cid#1607205 Overflowed constant
        
        Change-Id: Ic70c6f866a78ee01947415fe2f4af9508490e351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174152
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-29  Kira Tubo  <kira.tubo@gmail.com>  [4cc532c0393914a743c11e806bd25dfa3d28fb5c]

        tdf#156374: Create hanging indent on paragraph without one
        
        If the paragraph has no First Line Indent applied, create a hanging
        indent.
        - In Writer: the indentation distance is based on the default tab
          distance.
        - In Draw/Impress: the indentation distance is based on the distance set
          for the Increase/Decrease Indent buttons (1000 twips), which is
        different from the default tab distance.
        
        Change-Id: Ifc36c63ad7e6aa852a4b10aca22b7b4de6e10e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174001
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-28  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [c7c52f60657baa65e104530247ed05a90479e99e]

        tdf#114441 change width,height to tools::Long in starmath
        
        Change-Id: I69e0968643c5c30fbe7f67dfb392d176ab796fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174000
        Reviewed-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b01d057df75096792c53ba7f7a80c3db5afb1ba5]

        This can be protected instead of public
        
        Change-Id: I8389173bd155d7334445b991754e54c7641e63e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174155
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e76c7bc413af5ca1d74acb71a5a8bb6095605a89]

        Revert "cid#1607805 Overflowed constant"
        
        This reverts commit f063ea562c6ba14db15b9773bdcbb18af4a72ff8.
        
        Reason for revert: bad idea. We're not going to re-evalute the loop condition if we use a goto
        
        Change-Id: I8b892cd35c3560396f65619cd095a9b186ecbd24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [8535d6741ec9bd5d6105181af28f0500148d034f]

        cid#1607100 Overflowed constant
        
        Change-Id: I930e8661845c3c089e8d3d5b180815b1d65d4423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174153
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-28  Justin Luth  <justin.luth@collabora.com>  [7f84c993d3d2b5f05b18e740fea960901da57f80]

        tdf#163154 revert "tdf120224 writerfilter: consume excess bookmark
        
        ... from fields"
        
        The intention of my 6.2 commit 579c0749bef8c980507229439715e72060c1b077
        hack was to avoid importing duplicate LO-exported bookmarks.
        (LO exported the bookmarks inside the field definition,
        while MS normally has the bookmarks outside the field.)
        
        So the impact of this revert should be neglible,
        affecting mainly documents that LO round-tripped before 6.2
        which would just import one more "Copy" of a bookmark.
        
        The reason for doing the revert is also not terribly important.
        For a few odd documents that otherwise wouldn't import a bookmark
        around a field, it will allow the LO navigator a way to quickly
        jump to the field (since Legacy Fields are not included
        in the Navigator's field list).
        
        Note that what I am reverting was a HACK any way.
        It did a pretty good job of only ignoring LO-exported bookmarks,
        since MS Word usually puts the bookmark around the OUTSIDE
        of the field, while LO always puts the bookmark
        inside the field definition (and thus IsOpenField())
        
        make CppunitTest_sw_ww8export3 \
            CPPUNIT_TEST_NAME=testTdf79435_legacyInputFields
        
        make CppunitTest_sw_ooxmlexport12 \
            CPPUNIT_TEST_NAME=testTdf120224_textControlCrossRef
        
        Change-Id: Iefaf1173794c66b2a6f3e5c2143ed594de7efe35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174081
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8d4efbe1faf6e3a4a048ab4bb8f23516ce13268]

        cid#1607041 PA: Public Attribute
        
        Change-Id: I8ec74e943232f98c861e035c0da11e8d75f8fa29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174106
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [645ae19dfc1645cd49df620cc62857f399974e99]

        cid#1606705 Overflowed constant
        
        and
        
        cid#1607841 Overflowed constant
        
        Change-Id: Ia84d2c0d29e485379fe6338a784306bc8ff5343b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174105
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8536bb07ac92ecf5a4046d5bacd968c4f8ed5763]

        cid#1607672 silence Overflowed constant
        
        Change-Id: I8f66304c961d78c9f8745c68f2e7c6a3d8283586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33c4af119d9e6370316727a5b2271f80e4eef1fb]

        cid#1608030 Check of thread-shared field evades lock acquisition
        
        and
        
        cid#1608103 Check of thread-shared field evades lock acquisition
        
        Change-Id: Ifb3191512434f4938f02bfa1a1b6ed038b3e555e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174103
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e02696b32588e3a1eca3885450873f62213244e]

        cid#1557088 Data race condition
        
        since:
        
        commit d181d8acbf49e2fe87c8cf53a9431e503ccced55
        CommitDate: Fri Aug 25 12:44:33 2017 +0200
        
            tdf#84237 use XErrorHandler in CDocumentBuilder
        
        Change-Id: Iac1d2b88f2910298d30de4d12798bb38c36a0de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9bd20c306e3a7d049b656a96e5eef9c65a8e7994]

        cid#1620316 Uninitialized scalar variable
        
        Change-Id: I3ef7f30dc2045b0386bd7f14c0e9be34f7e67726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174101
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [4ff5a7b810d293e3d9d457049145ef5c3b1d95d0]

        cid#1607680 Overflowed constant
        
        Change-Id: I8522cfe5422c187b9045858c2f94753d0f2c8714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [2596131a1fcb40cd134200035049c23113d3e141]

        cid#1607687 Overflowed constant
        
        This code does not appear to be handling the case where there
        is no anchor correctly, all the way back to
        
            commit c5718b941491ffaa937767c579627444c0957b86
            Author: Andreas Bille <abi@openoffice.org>
            Date:   Wed Oct 31 12:08:14 2001 +0000
            #83054#
            Now reading the necessary variables( provider.cxx ),
        
        Change-Id: Ia8f514a95ca2e3ae17129b34f0ed444cd9d0ade8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [2264538ec245839651de4e34cec45958460c4021]

        cid#1607691 Overflowed constant
        
        Change-Id: Ib3f32065334769298483d4cf9131040ab28a3a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [980f28fce8ccf317ee099179b07e68a50119dc6e]

        cid#1607692 Overflowed constant
        
        use less convoluted logic here
        
        Change-Id: I786d7f857c7104358559782247c4272914299314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174112
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-28  Sahil Gautam  <sahil@libreoffice.org>  [54fe022f298c98ea40b175e5e671363a5a413160]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d61990c85ed2135a6064b6caf1e989e820cd65c
          - tdf#85976 Help page for HandleDuplicateRecords dialog
            
            https: //gerrit.libreoffice.org/c/core/+/160685/comments/9dd92aa8_beae1c5f
            Change-Id: I4ce7ad0022ed34b3704a3a5b17416eabcf91dd03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173142
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [aea48c1eb8f42ba620008a1b2119f80dbbb9c4ba]

        cid#1607751 Overflowed constant
        
        help out coverity by asserting what should be true here
        
        Change-Id: I1c98c29cccf0fd40eb6cc19699428872a5bf56a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [c2306ddbac82e643cf05773ce39fe09195937af6]

        cid#1607790 Overflowed constant
        
        Change-Id: Ia2b180d6a93f139a0f83653ee45b4ad929ccef45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Noel Grandin  <noelgrandin@gmail.com>  [f063ea562c6ba14db15b9773bdcbb18af4a72ff8]

        cid#1607805 Overflowed constant
        
        Change-Id: Id146853a86a54597a1e07efba6c86abc10d93796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2a49cbbebe11a7394bcfc9145794f8659a8c9471]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14476c266b8097805df0292dc9a07468024c12f0
          - tdf#162607 disambiguate hid2file.js, DBNew*
            
            + Removed bookmark from the toolbars help page
            + refactor
            
            Change-Id: Ie51d6b61f735f041b677d711203729476af4625d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174148
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5297f109ae5748867f65df795e9452a4abdad21b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 909308152bef7ce6bc4bdac384aaf55f2431b7eb
          - tdf#162607 disambiguate hid2file.js, paste special
            
            + Removed bookmark from sdatabase file
            
            Change-Id: I9922d86768ea79ed7fa652fb0af62ba165d82aee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174147
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a80a28f4d325087a1e482b699aa09bab65596d06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac18fb999e675f78ce6f2b687a67ea001edf5ccd
          - tdf#162607 disambiguate hid2file.js, SaveGraphic
            
            + Removed bookmark from simpress file
            
            Change-Id: Ia9ddb3cd9f2c1d6b8a611e958d5b966d882092d9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174146
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b6236cb8f79c2d149e8f66753602a335fd0e97c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d81dc3348d3ac27155b0f9b021d95c7599848150
          - tdf#162607 disambiguate hid2file.js, TableBoundaries
            
            + Removed bookmark from the options help page
            
            Change-Id: If3b3aa13283e0f6733640676137d834fb8662475
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174145
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [52d1da1f9a163bcee3954e4a78fa4014f7c5edfc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 446f60711a2d62504ac3011987ad22fb64af6ffc
          - tdf#162607 disambiguate hid2file.js, uno:ScrollBar
            
            + Remove useless bookmark
            
            Change-Id: I38689febf073c29353fb1b7e089617eed3d52b69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174144
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a7a43dd7a85efeb1febf822101c6828cf4050660]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b038ab4ef42ff67d505cdf5deddfe492852ad56b
          - tdf#162607 disambiguate hid2file.js, uno:SheetMenu
            
            + Remove singleton help file used nowhere (superseeded by scalc/main0116.xhp)
            
            Change-Id: I5e675d84c9e54fcf0d2bf7c3f0c46bd6de6d43aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174143
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Julien Nabet  <serval2412@yahoo.fr>  [32fccb862ff54558895b147e387bfa048d4dea17]

        cid#1620317 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7d31cf2a977cb095a6d3cd89f9cadf82bea3bddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174099
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-28  Julien Nabet  <serval2412@yahoo.fr>  [6a2333c1663d862dec7b3e0450148c31afd83ca5]

        cid#1620321 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9030fafe12bb48d43049493102de23ca8212cd9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174087
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-28  Julien Nabet  <serval2412@yahoo.fr>  [bb22876320b47c009898fee548df47ed772463ec]

        cid#1620328 UNINIT_CTOR
        
        Change-Id: I4c56bf457920bb3800413d5e2289e49e5d64eb0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174085
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-28  Julien Nabet  <serval2412@yahoo.fr>  [9f50e047135cd104a9b5081239617a679bb5610d]

        cid#1620326 UNINIT
        
        Change-Id: Ic99797c2e286e25e7803668480a1aabd26cdca27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174086
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-28  Julien Nabet  <serval2412@yahoo.fr>  [1f578b6244b9e2e434e4a746490047007acf330b]

        Typo: bDuplicatRows->bDuplicateRows
        
        Change-Id: I307c81013723d6b47cf2e7f98ce9ac2e179136f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174100
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6e9b04320c79b0105444242d0c8209bcb50d8dcc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ad81aa6d12b615374b39d0eb7e2dec4e12ebcbc
          - More tweaks in XHP DTD
            
            Added more entities
            
            Change-Id: Idc529efd6f26496e22ac56586622c4b54742531f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174037
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [157ce1e1278ab03e2276f7a4c22978d80255bd79]

        tdf#163183 Improve Tip of the day 8/225
        
        Change-Id: Ib9bb049afc56a889d764aa9d3a9c0bcf5a1ea1f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174009
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [247aeeebc9add39e13b05ac9a7dbc852633b5d92]

        setParentStorage is always called with an empty reference
        
        Change-Id: I973811b3e8aa41bc331362a96a7cb519aec363a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [178430733b0687a0f9334dda9a66e9b58ec8e7b0]

        tdf#130857 qt weld: Declare support for "License Information" dialog
        
        Now that previous commits have implemented what's
        needed to display the dialog and for button clicks
        to result in the expected action, add the .ui file
        for the "Help" -> "License Information" dialog to the
        list of supported .ui files for QtInstanceBuilder, so
        native Qt widgets will be used for that one with
        the Qt-based VCL plugins unless starting LO with
        the SAL_VCL_QT_NO_WELDED_WIDGETS environment variable set.
        
        Change-Id: I8a2dff1c751739567a3c9c0728e3357859069a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174080
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [08b55df5c9e42c1ccb78a156261811875629342a]

        tdf#130857 qt weld: Close dialog on button click
        
        For QDialogs (created for "GtkDialog" objects in .ui files)
        that have a button box, let clicking any of the buttons
        that have a response code set close the dialog with
        that response code by connecting to the
        QAbstractButton::clicked signal.
        
        This addresses the remaining aspect for the
        "Help" -> "License Information" dialog
        mentioned in earlier commit
        
            Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Sep 28 00:07:28 2024 +0200
        
                tdf#130857 qt weld: Add initial support for dialog and label
        
        > However, currently (...) clicking the buttons doesn't yet have any
        > effect.
        
        Actually using Qt(InstanceBuilder) for that dialog
        will be enabled in an upcoming commit.
        
        Change-Id: Ie3c26963318fd5832688e3ed73f6952e09da4bb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174079
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [8f5d8342e47852eac0fd5f42b69b6ac28ebfe7c5]

        tdf#130857 qt weld: Move button response prop to QtInstanceDialog
        
        It will be used for QDialog as well, not just QMessageBox
        
        Change-Id: I887b3fe45beea40cc92f2b0b77f316ad73d7f922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174078
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [70bbd7f6bd6719ecde1dd3fbb1c2a89e68575a2e]

        tdf#130857 qt weld: Ensure dialog button box is last in layout
        
        For QDialog, make sure that if a button box is included in
        the dialog's layout, that this is the last item in the layout,
        by removing from the layout and adding it at the end again.
        
        I don't see any explicit child index explicitly being set in
        the .ui file for the "Help" -> "License Information" dialog
        ("sfx/ui/licensedialog.ui").
        
        Potentially GTK implicitly visually makes the dialog's
        button box the last item in the dialog.
        
        Corresponding child is this one:
        
                <child internal-child="action_area">
                  <object class="GtkButtonBox" id="dialog-action_area1">
        
        Potentially the `<child internal-child="action_area">`
        identifies this as the dialog's button box that should
        be last, at least dialog newly created in glade
        also has that set.
        
        For QMessageBox, which is a QDialog subclass, this
        special handling is not needed, as its default
        button box is used, which is already at the right
        place.
        
        This addresses the first aspect mentioned in
        previous commit:
        
            Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Sep 28 00:07:28 2024 +0200
        
                tdf#130857 qt weld: Add initial support for dialog and label
        
        > However, currently buttons and the label with the text
        > are in the wrong order (i.e. buttons are above the text)
        
        Still missing:
        
        > and clicking the buttons doesn't yet have any effect.
        
        Change-Id: Id991551548c1e54fdf2e169886a6c67fc307931f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174077
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [4c7f4ed28e093963f58130c52ebcd5f6c66b4bbc]

        tdf#130857 qt weld: Add initial support for dialog and label
        
        Add initial support for the "GtkDialog" and "GtkLabel" objects
        in .ui files by creating corresponding Qt widgets
        (QDialog for "GtkDialog" and QLabel for "GtkLabel").
        
        This makes the elements of the "Help" -> "License Information"
        show up once the .ui file of that that dialog
        ("sfx/ui/licensedialog.ui") is added to the set of supported
        .ui files.
        
        However, currently buttons and the label with the text
        are in the wrong order (i.e. buttons are above the text)
        and clicking the buttons doesn't yet have any effect.
        Those aspects will be addressed in separate commits
        before actually claiming support for the dialog
        in QtInstanceBuilder::IsUIFileSupported.
        
        Change-Id: Ic9393755ec474f77ff22a1115e3cccba9d7b26cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174076
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [f14b6a9c2d906f11049326a69cd4bddd072ab626]

        tdf#130857 qt weld: Use QDialog* as param for findButtonBox
        
        Don't restrict to QMessageBox, but allow using the
        method with any QDialog, and don't assert that
        the dialog has a layout set in this case.
        
        The method will be reused in an upcoming commit.
        
        Change-Id: I1992f2eb4f34b25e487bbd349631b6ecd4365c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174075
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [592665ce867d51ed3dcf95fd0f06fd22dc2804e8]

        tdf#130857 qt weld: Avoid unnecessary OUString copy
        
        Change-Id: I36802f84070e579b714b696144536a2f130e2f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174074
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [a9c637da431485f2e0e27045ccae10866c587538]

        tdf#130857 qt weld: Use "p" prefix for pointer param name
        
        Change-Id: I732b67ef6f864fcbb1724b6d6bc3290417660dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174073
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [0aa5380c22e19ae43a251a2d2fae12a31069b8d9]

        tdf#130857 qt weld: Set widget layout and add to parent layout
        
        When creating a QLayout, pass the parent widget
        to the ctor as well, which makes the layout be
        set for the widget. Quoting from the QVBoxLayout ctor doc [1]
        
        > Constructs a new top-level vertical box with parent parent.
        >
        > The layout is set directly as the top-level layout for parent.
        > There can be only one top-level layout for a widget. It is returned
        > by QWidget::layout().
        
        Also add widgets to their parent layout if the parent
        is a QLayout, and not a QWidget.
        
        This makes the items of the "Help" -> "License" dialog
        actually be part of the dialog in a WIP branch
        that has "QtInstanceBuilder::IsUIFileSupported" in
        the set of supported files in QtInstanceBuilder::IsUIFileSupported.
        
        [1] https://doc.qt.io/qt-6/qvboxlayout.html#QVBoxLayout-1
        
        Change-Id: Ib823896a28520b6f7e1e89244239d3204d1d10e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174072
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [0d927b52a079e73a0ab8760f583360466628db0b]

        tdf#130857 qt weld: Ignore placeholders
        
        In QtBuilder, ignore placeholders as encountered e.g. in
        "sc/uiconfig/scalc/ui/checkwarningdialog.ui" (that's not
        yet in the list of supported .ui files for QtInstanceBuilder
        yet).
        
        VclBuilder mostly ignores them as well, see
        VclBuilder::makeObject.
        
        Change-Id: I68481e31365561719af5e72ee20adb428b642941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174071
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [4dc918239879fe3252d803b62834592c6d1c495b]

        sc: Resave checkwarningdialog.ui with glade 3.40
        
        Change-Id: Idb8efd7a8be06436b16572bfcf1d352a823e2497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174070
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [e9761fb11c41f18655e33fce82171e3737111686]

        tdf#130857 qt weld: SAL_WARN and assert on unsupported widget type
        
        Change-Id: I45b0eac84a5820d0ef8a3bb36de35827f0ae1e33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [685c4aea78af552418e072a2951da31f91149fd4]

        qt: No longer use SalFrame::maGeometry in QtFrame at all
        
        With previous commit
        
            Change-Id: Icaf712c956297dbc7a774bbd995d42eb8a63a1bb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Sep 27 11:06:55 2024 +0200
        
                qt: Query screen on demand in QtFrame
        
        in place, all relevant members are explicitly set
        for the returned SalFrameGeometry in
        QtFrame::GetUnmirroredGeometry, so there's no more
        reason to start with a copy of `maGeometry` instead of
        a default-constructed SalFrameGeometry.
        
        Margins for decorations are never set for the Qt-based
        VCL plugins (using methods like SalFrameGeometry::setLeftDecoration),
        so the default of 0 is fine for all of these.
        
        Change-Id: Ibed98c665e61a4ba06bf9087a159048417598798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174035
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [be0d89bea01fe89f619f701cd4e5e40420c9a1e2]

        qt: Query screen on demand in QtFrame
        
        Similar to how
        
            Change-Id: Ifa0eff271c7d3fa2b6db9bdc1669e62333bd3094
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 26 18:22:12 2024 +0200
        
                tdf#160837 qt: Rely on toolkit for frame positions, drop menubar hack
        
        implements it for the frame/widget position and size,
        also retrieve the current screen number by querying
        the QWidget for it's current screen instead of doing
        own bookkeeping of the current screen in SalFrame::maGeometry
        by getting/setting it using `SalFrameGeometry::{getS,s}creen.
        
        Only set it in the returend SalGeometry when
        the current SalGeometry explicitly gets requested
        by calling QtFrame::GetUnmirroredGeometry.
        
        Change-Id: Icaf712c956297dbc7a774bbd995d42eb8a63a1bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174034
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [95283b72cf60208fb1df0fd1eb5ec021cd43eb9e]

        qt: Just ignore request to set frame to invalid screen number
        
        Instead of setting the screen to the primary screen,
        just ignore the request when QtFrame::SetScreenNumber
        gets called with an invalid screen number.
        
        The previous handling was introduced in
        
            commit f806a2832aee62efc0e0404f7c24d53aaaf814d0
            Date:   Mon Oct 22 16:35:21 2018 +0200
        
                tdf#120451: Use primary screen if requested screen doesn't exist
        
        to fix a crash, but just ignoring the request
        avoids crashing, too.
        
        (`git show --ignore-space-change` helps to see
        the "actual" change more easily.)
        
        Change-Id: I272ec64f89ef835161fa68c7fdc8cd0e407b7495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174033
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [0218519537f6b77e06ae1e3020ed681b5a4f812c]

        qt: Make screenNumber() a QtFrame method
        
        Don't explicitly pass a QScreen, but use the
        current one. Both callers set the screen
        just before calling the method.
        
        Change-Id: I57b3ffc4341cabc0370dda3c26d85f2f63ec9292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174032
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [bce84c97257b986dfdfeaf69042278128d005a8c]

        gen: Use std::vector::at instead of operator[]
        
        std::vector::at does bounds checking.
        
        Change-Id: Id173ad08fb3bf54e4b3e625b45bc439c59b4d9d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174031
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [be28117cf6ac2b9d433f0990d26fe9590cd61345]

        qt: Use QList::at instead of operator[]
        
        Change-Id: I366ec4439d2647f433a9dc480c6efa6160a451a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174030
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [be6312f8c5ce4003d3e299493db7b4eb1c498d7d]

        qt: Use QList::indexOf instead of reimplementing logic
        
        Change-Id: If78bc419ccffd874e47419bc06ed2841ffbeab96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174029
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [25e5f050756bb25d67b6a90433c0a50a149d5dc0]

        qt: Let GetQtInstance return ref instead of pointer
        
        The return value was dereferenced in all callers
        anyway.
        
        Change-Id: Ib91eddd23222d086f9a4edac980a05cd96c75ad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174026
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [a499874d9c0685d79b629b4bb246394b6b15691a]

        tdf#160837 qt: Rely on toolkit for frame positions, drop menubar hack
        
        Make `SalFrame::GetUnmirroredGeometry` overridable
        (and let it return a copy of the SalFrameGeometry
        instead of a const reference) and document that
        subclasses can either make sure to keep the
        `SalFrame::maGeometry` member (which is returned by
        the default implementation of
        `SalFrame::GetUnmirroredGeometry`) up to date or override
        the latter in order to always return the current
        geometry.
        
        Override the method in `QtFrame` and fully rely on Qt
        to report and set the position of the frame, via
        the corresponding QWidget: Set the position, width
        and height in the returned `SalFrameGeometry`
        to the ones of the widget (factoring in the
        scale factor).
        
        Stop updating `maGeometry` size/position whenever
        the widget position or size changes, as that is no
        longer used anymore now that `GetUnmirroredGeometry`
        is overriden.
        
        This also allows to drop earlier hacks where
        position calculation in some places had to be adjusted
        by the height of the native menu bar, as that one
        doesn't have a corresponding vcl::Window, but results
        in everything else being shifted down a bit.
        
        Using Qt directly to set other members of the
        returned `SalFrameGeometry` (like the screen number)
        would probably be possible, but is not included
        in this change. (It can still be done separately
        later.)
        
        This makes Accerciser highlight the correct area
        when using the qt6 VCL plugin and using Writer
        with the standard interface (where the y position
        reported via AT-SPI2 would previously always be
        too small, missing the menu bar height) and thus
        e.g. also allows to make use of it's "select object
        under mouse" feature (s. tdf#160837).
        The position via AT-SPI is however currently only
        correct on X11/XWayland where global/screen coordinates
        are reported via AT-SPI2.
        Wayland, where window-relative coordinates are used,
        still suffers from another issue that will be addressed
        in a separate commit.
        
        The highlighting in Accerciser is also still wrong
        when a screen scaling factor other than 100% is set,
        but that's broken for other applications (e.g. gtk3-demo)
        just the same, so might be an issue in Accerciser instead.
        
        I successfully tested that these behave as expected
        when using the qt6 VCL plugin with this change in place:
        
        * Combobox popup positions, with either 100% screen scaling
          or a scaling factor of 150% or 200% on both, X11 and
          Wayland.
        * When enabling RTL mode via env var `SAL_RTL_ENABLED=1`,
          RTL layout is used and things look OK at a quick glance.
        * The following bugs (somewhat related to positioning and/or
          the now dropped menu bar hacks) are still fixed, i.e. don't
          reappear:
        
            * tdf#149805 "kf5: Gap when expanding comboboxes in toolbar"
            * tdf#151677 "tip on "formula bar" for "formula making" is
              displaying over the formula itself."
            * tdf#152217 "Black box in Basic IDE where the status bar
              should be (kf5 only)"
            * tdf#153458 "Connecting to database: wrong cursor position
              for dropping data to Calc sheet"
            * tdf#153800 "Calc sheet tab drag-and-drop target area has
              shifted vertically (kf5-only)"
            * tdf#154043 "Change object layer via drag and drop has target
              shifted down (KF5-only)"
            * tdf#154447 "Clicking a dropdown tool button shouldn't
              place the context menu on top of the button (kf5)"
        
        Unrelated to this commit, popup positioning and rendering in
        in a multi-screen setup on Wayland with different scaling
        factors set for the single screens is still broken (see
        tdf#141578).
        
        Change-Id: Ifa0eff271c7d3fa2b6db9bdc1669e62333bd3094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173996
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [b2743ac25485f0909838fae370401e21ee85950f]

        tdf#160837 SalFrame: Replace direct uses of maGeometry member
        
        Call `GetUnmirroredGeometry()` instead of directly
        using the `maGeometry` member in order to get the
        current SalFrameGeometry.
        
        This is in preparation of allowing to override
        `SalFrame::GetUnmirroredGeometry` in subclasses in
        an upcoming commit.
        
        No change in behavior intended (yet).
        
        Change-Id: I72b44052ba5e8ed61a1c54130ea088f1bb0b3941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173995
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [54bdc8cb95584aba8de06564ea45f05d0babc032]

        tdf#160837 qt: QtFrame: Use getters instead of SalFrame::maGeometry
        
        Replace some direct uses of SalFrame::maGeometry
        in QtFrame with corresponding getters:
        
        * SalFrame::GetUnmirroredGeometry() to get the
          SalFrameGeometry
        * the more specific SalFrame::GetWidth() and
          SalFrame::GetHeight() where only the width/
          height is of interest
        
        No change in behavior intended yet.
        
        Change-Id: I1b4e13c5efef7b78f082f6444e1e8d0ee591db41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173994
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-28  Michael Weghorn  <m.weghorn@posteo.de>  [c9b7d8cc749884ce2c26a1b944413a1d301fbf1a]

        android: Update Android Gradle Plugin to 8.6.1
        
        as suggested by Android Studio.
        
        Change-Id: Idbd71e7766d44374b4972362fb917f385b4fc5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174042
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f7fbf6504fd6190187f6e4d092af880ba8c7bf6a]

        Fix typo in code
        
        Change-Id: I10ed53c4d85b3b83b608bdd051742c6000162390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174060
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [79e4910620049ad88e9ccbd9a1e0a081ed43404b]

        Remove duplicated includes
        
        Change-Id: Iaef510a5b79e6a213be1580a469fe145adabca88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174057
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [397cf22d845e6ff6ba166c73a72df1a76ff88d2e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8cdedc9880681f9c51c0d54f7d1109c173ddb75d
          - Fix typo
            
            Change-Id: I3084421a7390178d8b6cecf8752b3223994e41fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174056
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0dab76c5ce944b816cf28b30495e9071e3ec053e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d91ca5cb94128baa047ee0187ead1f99c70544b2
          - Fix typo
            
            Change-Id: I4ecf82ce4ebf13c9147f08c960f2624a4997a3e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174054
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bc6fc27fe94113b15668ce348f1a3e6767d85a86]

        Fix typo
        
        Change-Id: I6eb94e2733f3b55564c0e04dd69cb4c8c197b259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174061
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b574a35a86db5fd9dbfdab4809f8dd6026a4d504]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9e8e9ac861dc080105ee93dcc4c4dd76445e7e2
          - Fix typo
            
            Change-Id: I32cf04e2b4e9f1b05a904d7cecdc12ca719ff696
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174055
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ddf05a8856c33fb7d333e4bf81f36d74f849540b]

        Fix typos
        
        Change-Id: Ie35705bf4559f977c7a7b67edb6b05b6cd564249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174062
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4ae702d6757454fb5c9b3ac904a9b25e955875ae]

        Fix typo
        
        Change-Id: Ie14012caf6bb97c779e647c84ea7d5bbb576f24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174059
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5a505cfa269f56baaa93e3471d2dd661e628a1c2]

        Fix typo
        
        Change-Id: I2745fe4a7ffdae1e22fb103023c5555505f49548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174058
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3e069a6fd5bbbe56dc1bac2c57752405accd5344]

        Fix typo
        
        Change-Id: I0e967db5c0d116528313c192cb4ea68c2bbe87e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174063
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [131ad0b930e756782450c3348128bc1c1eee4d53]

        Fix typo
        
        Change-Id: I86f217216acffcd020b3e08e3cc90a87d62cd5cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174064
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6762578ee5d9c0b7670c5feea5b837130308a1be]

        use the same early return as the other ::dispose cases in this file
        
        as done with:
        
        commit 2bfd51eab364c6b00603e2fa1e9c354eec90dc7f
        CommitDate: Fri Jul 31 11:00:25 2020 +0200
        
            loplugin:flatten in sw/core/unocore
        
        for consistency with the rest, no logic change intended
        
        Change-Id: I69cc24c8ba4ec3aa483e869e68b79ab8b406afff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [25399d65d4d6f2217c4389ec82d35ccbce0c6f3e]

        tdf#162855 Draw a guide line while resizing the comment sidebar
        
        This patch draws a guide line while the user is dragging the comment sidebar edge, to provide a better feedback of the size that will be applied.
        
        Thanks to Jim Raykowski for his comments and contributions. It should be noted that he authored much of this patch.
        
        Change-Id: I08d4761a25c021c3ddda563a70fc0324000e4e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173017
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-09-27  Michael Stahl  <michael.stahl@allotropia.de>  [037a765f03c95301f987e1d1d4ef715b05b25c94]

        tdf#162268 sw: IgnoreHiddenCharsForLineCalculation
        
        The other problem here is that if hidden text isn't displayed,
        SwLineLayout::CalcLine() doesn't ignore the hidden text portion when
        calculating the line height.
        
        This is apparently the case all the way back to OOo 3.3, but it doesn't
        make much sense, so change the default to ignore hidden text here,
        except if a pre-existing ODF document is imported.
        
        Change-Id: Ief3f62bbdb6ac0ac79b54d6885a711128ad8d81f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174041
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-27  Michael Stahl  <michael.stahl@allotropia.de>  [7b8cec8322b60673e686660caf875bc71117bbd0]

        tdf#162268 sw: ApplyParagraphMarkFormatToEmptyLineAtEndOfParagraph
        
        Commit 2b47fae7e3e23ee7c733708500cb0482ad7f8af1 introduced the
        compatibility setting ApplyTextAttrToEmptyLineAtEndOfParagraph, but that
        was probably a mistake.
        
        What Word is doing there is not applying a text attribute but applying the
        formatting of the paragraph marker; add a new compatibility setting
        ApplyParagraphMarkFormatToEmptyLineAtEndOfParagraph to do this.
        
        Change SwAttrIter to apply the RES_PARATR_LIST_AUTOFMT formatting when
        the position behind the last character is reached, and use it to set the
        height of the last line in SwLineLayout::CalcLine() in case it is empty
        or contains only spaces/tabs.
        
        Frustratingly this requires another change to fdo74110.docx to get rid
        of some odd font that's applied to the paragraph marker.
        
        Also, change SwTextFrame::IsHiddenNow() to take into account paragraph
        marker formatting; if all characters are hidden but the paragraph marker
        isn't hidden, the paragraph is still displayed in Word.
        
        Change-Id: Icccd3e822ad0301ccbe373b50431c3254f691d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173880
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-27  Dione Maddern  <dionemaddern@gmail.com>  [ecc03c0b3727fd96612e8e8ee2097592b4a9a207]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e172e94687ea10cf2a7ddd5a8b61f3aff819fd1
          - tdf#162275 Add documentation for "database table references"
            
            Added new help page source/text/scalc/01/database_table_reference.xhp
            to cover the "database table references" feature in Calc, also called
            "structured references".
            
            Added new help page to repository AllLangHelp_scalc.mk
            
            Added section and variable tags to allow pages to be more easily linked
            and embedded in other pages in:
            - source/text/scalc/01/04060101.xhp
            - source/text/scalc/01/04060107.xhp
            - source/text/scalc/01/12010000.xhp
            - source/text/shared/optionen/01060900.xhp
            
            Added Related Topics links to make it easier to access relevant
            information in:
            - source/text/scalc/01/04060101.xhp
            - source/text/scalc/01/04060107.xhp
            - source/text/scalc/01/12010000.xhp
            - source/text/scalc/guide/database_define.xhp
            
            Change-Id: Ic3bf69b8ad773828efeea35a7539ebf29bae6856
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173999
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-27  Dr. David Alan Gilbert  <dave@treblig.org>  [aec41175e8e150e0cb728aa5fa1a4f40cd1fb718]

        tdf#162887 sdext.pdfimport: Fix tilingPatternFill crash
        
        regression from
          commit 8ac5f40b330c6cd248073b8686c05f566ecd7195
          Author: Dr. David Alan Gilbert <dave@treblig.org>
          tdf#113050 sdext.pdfimport: Write the tiling pattern image
        
        The logo in the test file in tdf#159115 appears to be a tiling pattern
        fill where the fill is actually rendered text (instead of just an image)
        and this triggers splash to try and look at it's font code (even though
        I've already got EnableFreeType off) and that was initialised by
        startDoc which I'd failed to call.  Call it.
        
        Note this doesn't fix tdf#159115, which originally had 4 copies of the
        logo, the current state is it has one unrendered white blob, but lets
        get rid of the crash first.
        
        Change-Id: I4e3f29cedcb8aefbb5adf96f696bf08457fbd58a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173139
        Tested-by: Hossein   <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Hossein   <hossein@libreoffice.org>

2024-09-27  Sahil Gautam  <me.sahilgautam@gmail.com>  [29fd68bb682006ccaa5aaed516c064b5b6368463]

        tdf#85976 [RFE] Add a "Remove Duplicate Records" command
        
        Add a "Remove Duplicate Records" entry under Calc > menu Data
        to remove duplicate records from a rectangular selection
        of cells in Calc.
        
        Change-Id: Ic8340d7f1e19461ef3666fd2ef65294b73577d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160685
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-27  Heiko Tietze  <tietze.heiko@gmail.com>  [b8368ad96e779196f7fdaa4dfd5e26a51e1bd829]

        Resolves tdf#108697 - Update default bullets
        
        Change-Id: I35387f5399a18ecd15237485458233b28f88ea37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174028
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-27  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [59fc2b5ca9678855feb30345761dad739b546edc]

        tdf#163125: CairoSDPR: Take virtual OutDevs into account
        
        Unfortunaletly we have 'virtual' OutDevs, that means their
        PixelSize is bigger as they claim and they use an internal
        offset. This is used to not have to create too many Windows
        inside Windows (AFAIR initial reason was that Windows has
        a fix number of Windows per process that can be incarnated).
        
        The offset was/is already supported by SDPRs using
        ViewInformation2D and adding ot to the ViewTransformation,
        but the evtl. existing PixelSize has to be clipped against.
        The fallback VclPixelProcessor2D supports that indirectly
        by doing that in the OutDev commands that get called, so
        it does not need to be done by that renderer.
        
        I have now added code to support that for the
        CairoPixelProcessor2D, see code and comments. It uses an
        existing method of cairo to do that elegantly inside the
        system-dependent code of the SDPR.
        
        Note that the Windows SDPR D2DPixelProcessor2D will
        have the same problem that will have to be solved there,
        too. Since it's currently in experimental state I made
        myself a note about that.
        
        Change-Id: I68915985102bb4a63c84299f8d022ab013633510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173998
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f53881f444051898e6dce2cbc343057cb6fc6b9]

        null-deref seen in testing
        
         #2  0x0000000000ac8c3e in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
         #3  0x00007fa92f2fa26f in std::unique_ptr<WindowImpl, std::default_delete<WindowImpl> >::operator* (this=<optimized out>)
             at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:443
         #4  std::unique_ptr<WindowImpl, std::default_delete<WindowImpl> >::operator* (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:443
         #5  vcl::Window::CallEventListeners (this=this@entry=0x34eb4f40, nEvent=nEvent@entry=VclEventId::ObjectDying, pData=pData@entry=0x0)
             at libreoffice/vcl/source/window/event.cxx:272
         #6  0x00007fa92f38277a in vcl::Window::dispose (this=0x34eb4f40) at libreoffice/vcl/source/window/window.cxx:159
         #7  0x00007fa92f678064 in VclPtr<HelpTextWindow>::disposeAndClear (this=<synthetic pointer>) at libreoffice/include/rtl/ref.hxx:88
         #8  ImplDestroyHelpWindow (rHelpData=..., bUpdateHideTime=<optimized out>) at libreoffice/vcl/source/app/help.cxx:576
         #9  0x00007fa92f6780f8 in ImplDestroyHelpWindow (bUpdateHideTime=<optimized out>) at libreoffice/vcl/source/app/help.cxx:565
         #10 0x00007fa92f679125 in ImplShowHelpWindow (pParent=0x334cfb90, nHelpWinStyle=<optimized out>, nStyle=QuickHelpFlags::NONE, rHelpText="Chart Area", rScreenPos=Point = {...}, rHelpArea=...)
             at libreoffice/vcl/source/app/help.cxx:532
         #11 0x00007fa92f679544 in Help::ShowQuickHelp (pParent=pParent@entry=0x334cfb90, rScreenRect=..., rHelpText="Chart Area", nStyle=nStyle@entry=QuickHelpFlags::NONE)
             at libreoffice/vcl/source/app/help.cxx:189
         #12 0x00007fa91ae862e0 in chart::ChartWindow::RequestHelp (this=0x334cfb90, rHEvt=...)
             at libreoffice/chart2/source/controller/main/ChartWindow.cxx:227
         #13 0x00007fa92e2e88a0 in (anonymous namespace)::LOKPostAsyncEvent (pEv=0x35b4a320) at libreoffice/sfx2/source/view/lokhelper.cxx:1103
         #14 0x00007fa92e2e076a in LokChartHelper::postMouseEvent (this=this@entry=0x7ffd226dd650, nType=nType@entry=2, nX=nX@entry=15405, nY=nY@entry=4089, nCount=nCount@entry=1,
             nButtons=nButtons@entry=0, nModifier=0, fScaleX=fScaleX@entry=0.10000000000000001, fScaleY=fScaleY@entry=0.10000000000000001)
             at libreoffice/sfx2/source/view/lokcharthelper.cxx:294
         #15 0x00007fa92e2e5b80 in SfxLokHelper::testInPlaceComponentMouseEventHit (pViewShell=pViewShell@entry=0x337e52a0, nType=nType@entry=2, nX=nX@entry=15405, nY=nY@entry=4089,
             nCount=nCount@entry=1, nButtons=nButtons@entry=0, nModifier=0, fScaleX=0.10000000000000001, fScaleY=0.10000000000000001, bNegativeX=false)
             at libreoffice/include/rtl/ref.hxx:69
         #16 0x00007fa91dba1e0e in ScModelObj::postMouseEvent (this=0x4593d10, nType=2, nX=15405, nY=4089, nCount=1, nButtons=0, nModifier=0)
             at libreoffice/sc/source/ui/unoobj/docuno.cxx:799
         #17 0x00007fa92e39567f in doc_postMouseEvent (pThis=0x334b8290, nType=2, nX=15405, nY=4089, nCount=1, nButtons=0, nModifier=0)
             at libreoffice/desktop/source/lib/init.cxx:5597
         #18 0x0000000000578631 in lok::Document::postMouseEvent (nModifier=0, nButtons=0, nCount=1, nY=<optimized out>, nX=<optimized out>, nType=<optimized out>, this=<optimized out>)
             at libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:297
         #19 ChildSession::mouseEvent (this=this@entry=0x317e3cf0, tokens=..., target=target@entry=LokEventTargetEnum::Document) at kit/ChildSession.cpp:1906
         #20 0x0000000000588485 in ChildSession::_handleInput (this=<optimized out>, buffer=<optimized out>, length=<optimized out>) at kit/ChildSession.cpp:634
        
        Change-Id: Ic67c8b7c4553853d0ab36dd448642564b6b6fb69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173922
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c4db29e740c85064f1465aaf3e143c19d1f5362]

        cid#1607206 PA: Public Attribute
        
        Change-Id: Ic76b397921c97314005cd0e05646fc45b303ded8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [911a57c4d6fc2cbe9d4350189e06a8b733e6f7d3]

        tdf#160062 Uno API to set solver settings at the sheet level
        
        This patch creates the API necessary to create solver models via macros, so that the model is visible in the Solver dialog, and the model is saved to the file.
        
        This patch also includes a comprehensive unit test in scsolverobj.cxx.
        
        Visit the bug ticket for a file with some examples of such macros.
        
        Change-Id: Ib9cfbbdaab8243cd6b901a2bcd99e46c27be97e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171769
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [646479d23436ef3493049f25384bc30fd515d978]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58b1983c442d5a7f0694789b341c2caeb661fc3c
          - Fix switch for regular expressions.
            
            Change-Id: I40f0abc285a7effb71a18d37862fdd9b606edc84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/174007
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-27  Adam Seskunas  <adamseskunas@gmail.com>  [aa5fdd39570004df0a8e89e4eebe4ad675274266]

        Add file stats to check-missing-unittests.py
        
        Get files modified, insertions and deletions for
        each of the missing unit tests.
        
        Change-Id: I7b6c2f0f988137c533d7b9283faa9a2753ef41e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173481
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-27  Miklos Vajna  <vmiklos@collabora.com>  [a581dbf9829d8407a611907c35c8af632b1397b5]

        cool#9992 lok doc sign: only take sign cert from the view in the cert chooser
        
        Have two views, in case both of them haver sign certs configured in the
        NSS database, then the cert chooser would present both, which is not
        wanted.
        
        The problem is that the NSS database contains sign certs from all views,
        so working from the database is not what we want for the LOK case.
        
        Fix the problem by passing the SfxViewShell from the sign dialog to the
        certificate chooser dialog, and then the chooser can work from the view
        in LOK mode.
        
        Searching for other uses of getPersonalCertificates(), the comphelper/
        one is not relevant for the LOK case (gpg is disabled there); the PDF
        case is only for the UNO API, so those don't necessarily need adjusting.
        
        Change-Id: Ic7027b8d218b2bde3c8bf134a4b11c14fd9c3570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174002
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [522d2aaf1ca830bcf3bca816b06cc8faa893cd0d]

        vcl: flatten BitmapMosaicFilter::execute()
        
        Change-Id: I9e56c285cffe14374a66204ef8126a20f0e7c07c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173203
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-27  Jonathan Clark  <jonathan@libreoffice.org>  [c3c29d31d77ff93aa50634cfd51c62d12dc0f6ec]

        tdf#140767 Implemented Syriac justification
        
        This change extends kashida justification to Syriac, using custom
        insertion rules.
        
        Change-Id: I7508d2c32e95abb12a098e989c7153828ba81c87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173990
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-26  Jonathan Clark  <jonathan@libreoffice.org>  [d8f430e4bef414616fd80bbf4ea16d767991b5b9]

        tdf#163105 Use HB data while selecting kashida insertion positions
        
        Previously, Writer and Edit Engine would skip inserting kashida in words
        if the highest-priority candidate position is marked as invalid by
        HarfBuzz. This would happen even if the word contained multiple
        lower-ranked valid candidate positions.
        
        This change updates Writer and Edit Engine to pass HarfBuzz kashida
        position data to the selection algorithm. The algorithm has been updated
        to return the highest-priority valid position, if any. The algorithm has
        also been updated to use raw positions marked as valid by HarfBuzz as a
        fallback, if no better positions could be found.
        
        Change-Id: I40c6432c4607aee197e8767e5667db504469956a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173963
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-26  Oliver Specht  <oliver.specht@cib.de>  [348efa75b992fe863bf85b39e5d0e71eb7ba8aba]

        tdf#132274 follow-up fix
        
        Width of zoom radio buttons increased to prevent overwriting
        of zoom value control in e.g. German translation.
        
        Change-Id: I1e78840ede6aa1899ec7b62fdd0ce2bc92edea9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173948
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [b532d79f39ae047d2f59535679230a8d053b5b35]

        tdf#162687: ODF 1.4: fix import
        
        Change-Id: Ic728c1c92ff5815c0780ba18e1a473d26e13e63f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173993
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc9155f8cdbddfb60f42f1514974846ec8a917a0]

        CppunitTest_xmloff_draw: simplify a bit
        
        Change-Id: Ic36e2c50953e99d7509c1d16ffef2f9f5f3a7bf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173992
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [b617ac73222d837af7ab6790764518174c517e1b]

        ODF 1.4: add ODFVER_014_TEXT constant
        
        Change-Id: I219c854b11a5bd4be3d789b93a96e045e3dca29f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173991
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [dc8718385bdfe911e11b77dd6d48a45dac523377]

        CppunitTest_xmloff_draw: remove leftover
        
        after 146dac7d30823678b9e87f8128904f5815c1a2ed
        "tdf#162690, tdf#162687: Adapt to ODF 1.4"
        
        Change-Id: I1236b89186e51e594610272a2ea490274ddc41e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173979
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-26  Oliver Specht  <oliver.specht@cib.de>  [ba02bfc98ae7f7103ba629e160ce792d670c1921]

        Revert "tdf#162268: Import - add zero width space after line break"
        
        This reverts commit d6f2f115c721e0b8337679472e1e106a998a62d4.
        
        Reason for revert: While the change improves the document attached to tdf#162268 it breaks other documents with similar but slightly different settings e.g. https://bugs.documentfoundation.org/attachment.cgi?id=191094&action=edit
        
        Change-Id: Ic1f17307118979586287f000d460caa16e26367d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173394
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0c534406b00062459638b12df4bddcab4505da8d]

        Clean-up Primitive2D XML dump
        
        Use static_cast instead of dynamic_cast when it makes more sense
        to do so and use auto to make the code more readable (when we
        write the type 2 times).
        
        Change-Id: I433885ab11437b1e086e0b8e255ed9dbe7e43b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173978
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-09-26  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [52adaa2a1a75c91d1a97431cc14d15d7b9595c00]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a8dda1b93bf192540e81417bc6abc2c6bc9a077
          - Removal of hard-coded split window shortcut
            
            I9d3692640d7bfb6283445cf7f103986cf72581af
            
            Change-Id: I00f75b4481a5795674a3a18eea7ca8701dc542fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173095
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            Tested-by: Jenkins
            
2024-09-26  Heiko Tietze  <tietze.heiko@gmail.com>  [2ac51182e63c109bb44334f86b6ab3bcdf247494]

        Related tdf#146906 - Remove hard-coded access to split window
        
        * Calc users can customize .uno:SplitWindow
        * Help modification in I00f75b4481a5795674a3a18eea7ca8701dc542fc
        
        Change-Id: I9d3692640d7bfb6283445cf7f103986cf72581af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173122
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-26  Mike Kaganski  <mike.kaganski@collabora.com>  [70a183875aaa11f3099b8280ff76cff1a3db0d2b]

        Fix build: move CrashReporter code to vcl/source/window/builder.cxx
        
        This problem appeared after commit 1a1bf2b78d689a570cc71b7bcb3e0100947a2fb1
        (tdf#130857 VclBuilder: Extract helper to start parsing UI file, 2024-09-26):
        
        [LNK] Library/libvclplug_qt5lo.so
        /home/mk/core/include/vcl/widgetbuilder.hxx:55: error: undefined reference to 'CrashReporter::addKeyValue(rtl::OUString const&, rtl::OUString const&, CrashReporter::tAddKeyHandling)'
        collect2: error: ld returned 1 exit status
        make[1]: *** [/home/mk/core/vcl/Library_vclplug_qt5.mk:20: /home/mk/build/instdir/program/libvclplug_qt5lo.so] Error 1
        
        Change-Id: I212aa3cbc381770de8fec07ea6454ab209edefc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173977
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Patrick Luby  <guibmacdev@gmail.com>  [e4ab68142c7bc4e04ffe429567dda974b86985a7]

        tdf#163152 don't convert image's sRGB colorspace
        
        With Skia/Raster or Skia disabled, converting the image's
        colorspace to match the window's colorspace causes more than
        an expected amount of color saturation so let the window's
        underlying CGContext handle any necessary colorspace conversion
        in CGContextDrawImage().
        
        With Skia/Metal, this bug is caused by the CAMetalLayer being
        set to the same colorspace as its matching window. So set the
        CAMetalLayer's colorspace to sRGB so that, like with Skia/Raster
        and Skia disabled, any colorspace conversion is handled when the
        CAMetalLayer is drawn to the window.
        
        Change-Id: Ifa2abe46d34bfcf5acd478fffd346603f869157b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173962
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0724127c6dd8f72b597ce1bdd3ba3aa4cd658e7f]

        cid#1607041 PA: Public Attribute
        
        Change-Id: Iedea5a5e42fa311441a77ee4e18a1b3cbfdf0c44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72423868bd74afe143cad7245f0cc6c3c4d179de]

        cid#1607381 PA: Public Attribute
        
        Change-Id: I44377535cabfd0c34a7f2b0815d779b17fbf8f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173972
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b9e15ba06f25c5d16c25e11b244892b5aee6e4fc]

        cid#1608290 PA: Public Attribute
        
        Change-Id: I710d0d90122f4b2a82084a32a98a3877b3fae5bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173971
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Mike Kaganski  <mike.kaganski@collabora.com>  [e5b18c7d00bd0e60919c1f6f3d63d6dd24c8e0a4]

        Make slideshow objects' debugging semi-transparency and shift conditional
        
        It was introduced in commit cfd7bf7f6eeede43027dd72f923b2a8b2920a376
        (INTEGRATION: CWS presfixes12 (1.1.2); FILE ADDED, 2007-07-17); and
        back then, it was guarded by VERBOSE define. The VERBOSE condition
        was replaced by OSL_DEBUG_LEVEL >= 2 condition later in commit
        912e36e911201742633e7c0a0a56f247735ee09c (Remove VERBOSE part 3,
        2012-04-10); and then, it was completely dropped in commit
        e5ec6304149cdcad0d6495b5187c245748b408b5 (stop inclduing
        canvas/verbosetraces.hxx and canvas/debug.hxx, 2015-08-11).
        
        But this code is definitely harmful by default, when an unaware
        developer (like myself) tries to debug an animation problem, and
        suddenly sees a very different problem in the debug build (the shift
        and transparency of objects), which obviously is a new regression in
        master, but it can't be bisected using bibisect repos, which makes
        you to question your sanity, until you realize that it must be some
        debug-only feature.
        
        Thorsten wrote on IRC:
        > the semi-transparency & shifting is needed for actually noticing
        > what's behind (shapes get moved to sprites, then erased from the
        > static canvas, then moved around)
        > so I believe it's useful debugging tools, but of course should not
        > randomly enable for normal dev builds
        
        So use environment variable to control this behavior-changing code.
        
        Change-Id: I493cdde26c95fdde4a5d542a0bdad8e329fdfda8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173965
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-26  Chris Sherlock  <chris.sherlock79@gmail.com>  [8e1f8e9b701839ff141bebb715de5eeee6772a85]

        vcl: move variables closer to first use in BitmapFilterStackBlur functions
        
        Change-Id: I7ce550928cf3aadf55006d43dc6aff6d109ec826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173202
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cec1197603f7a1631546ccbef18ea16b6c08453f]

        Fix typo
        
        Change-Id: Iee9830ee99e2ae6416e441aea0f3007a8710dcaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173988
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [47dda09d3e6046d4da96518e0ec2ee22dba7ab38]

        Fix typo in code
        
        Change-Id: Id3115847fec65fea5a4060ec0f65fe752eef8f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173950
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-26  Chris Sherlock  <chris.sherlock79@gmail.com>  [3cf0b46327111830dc4e22a1f9f9af2c3e3b30ed]

        vcl: flatten functions in BitmapEx.cxx
        
        Change-Id: I62a876ae2d517e47efc0d8abccaece3f6059b4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173200
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eb227657d91c94f151434434e31087ae74efdd24]

        cid#1608414 Double lock
        
        since:
        
        commit f3e127217d8daa443b8eda52ac4810e375cc7d63
        CommitDate: Wed May 10 13:28:09 2023 +0200
        
            use comphelper::WeakComponentImplHelper in DocumentEventNotifier::Impl
        
        problem:
        
        108        std::unique_lock aGuard(m_aMutex);
        109        if ( !impl_isDisposed_nothrow(aGuard) )
        110        {
        111            acquire();
        CID 1608414: (#1 of 1): Double lock (LOCK)
        4. double_lock: dispose locks this->m_aMutex while it is locked.[show details]
        112            dispose();
            /include/comphelper/compbase.hxx
            73    virtual void SAL_CALL dispose() noexcept final override
            74    {
            1. lock: dispose locks this->m_aMutex.[show details]
            75        WeakComponentImplHelperBase::dispose();
                /comphelper/source/misc/compbase.cxx
                20    void SAL_CALL WeakComponentImplHelperBase::dispose()
                21    {
                1.        lock: unique_lock locks this->m_aMutex.
                22        std::unique_lock aGuard(m_aMutex);
        
        Change-Id: Ibd9dc0564adf86c6409794f584a743aecd9d36e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [27fc6242c7153fcc3f41e38cc2ea649a3fe0c4cf]

        cid#1607525 silence Overflowed constant
        
        and
        
        cid#1607982 Overflowed constant
        
        Change-Id: Ib7be7f8e17deb6184e25e543eab68dd704673eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cfc0fcd729e8e1e4395523a2ef2409fffc071f0d]

        cid#1619687 Not restoring ostream format
        
        Change-Id: Id47cdffca6e597f3bf60ac9def5e92916443b117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173967
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bebb6406a8ca0fa9de1051e8518bf84e070a3ef]

        cid#1619696 Dereference after null check
        
        Change-Id: I52bf93d2561c94da0f9129c5df90ec8dd21e4deb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173966
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-26  Miklos Vajna  <vmiklos@collabora.com>  [c57434559cf5ffd82c3c72e8a0884d4874885dca]

        cool#9992 lok doc sign: conditionally show the add button in the sign dialog
        
        Open the sign dialog, the Add button is hidden, even if the LOK clients
        initializes the view with a working signing certificate.
        
        SfxMedium::SignContents_Impl() knows the correct view, but by the time
        the execution arrives to the DigitalSignaturesDialog ctor, this info is
        lost, so we don't know what is the current view.
        
        Fix the problem by looking up the view of the object shell at UNO
        command dispatch time, and passing that around, so the signature dialog
        can also access it. If the view has a signing certificate configured,
        then allow signing.
        
        The certificate chooser triggered by this button still needs fixing.
        
        Change-Id: I1fae63cea27ea1e68e938879f4507f53ade484f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173964
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-26  Matthew Kogan  <matthew@epoq.co.uk>  [2b68729253437600db43f5c24838677b963a8c2f]

        tdf#162566 sw: Make it optional for moved text to be displayed as green
        
        by the new config option "DisplayMovedTextInGreen", as a temporary fix
        to hide incorrect changes in corner cases.
        
        Change-Id: Ie629ca22a2411db4ddbfc9f6b96fe6fe69681213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173127
        Tested-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-09-26  Sohrab Kazak  <sohrab.kazak@gmail.com>  [185899c145dba0c67e1d15e37dce206da8abc283]

        tdf#148320 Toggle ToC/Index Title
        
        Implements the checkbox to toggle the title in the ToC/Index.
        The checkbox does not disable the text entry of the title only
        hard codes the title to be an empty string.
        Solution could use more work.
        
        Change-Id: I752953ebb6b970dd3e802d76bdc15f478b535a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172477
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-26  László Németh  <nemeth@numbertext.org>  [7a78be5090d2dabf03e18471ba718f2c4f25f740]

        tdf#163060 sw smart justify: fix unwanted line break inside words
        
        End-of-line narrow line portion was broken into the
        following line, despite that it was inside a word,
        if the remaining free space for the line portion
        was negative in the line (GetLineWidth()), because
        of missing calculation with the extra available
        line width resulted by space shrinking.
        
        Regression from commit 53de98b29548ded88e0a44c80256fc5e340d551e
        "tdf#158333 sw smart justify: fix multiple text portions".
        
        Change-Id: I802b8469c82250be7ac6f3a73a4dc457deb72a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173961
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [eacc3489392bf4006acdd10bcd191afe2a5c92e2]

        tdf#160837 vcl: Protect SalFrame::maGeometry access
        
        Make SalFrame::maGeometry a protected instead
        of a public class member.
        
        This restricts direct access to subclasses
        and friends, making it easier to keep
        track and preventing direct access (including the
        possibility to set a different geometry) from
        "random" places.
        
        Other code previously directly accessing
        SalFrame::maGeometry was adjusted in previous
        commits.
        
        Change-Id: I8b41f382228e48afb94da88f99d1cfb3c3b8f834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173960
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [25f8b88ac9d602c1c518561c0f641a1e21699338]

        tdf#160837 win: Move UpdateFrameGeometry to WinSalFrame
        
        Turn the previously static helper function
        UpdateFrameGeometry into a WinSalFrame method.
        
        It requires write access to the maGeometry member, which is
        currently still, but soon no longer public.
        
        Change-Id: Ief0dfee6061a5ea4e8ce497f1605b7c46c6e40c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173959
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [b00d322c5fc7e275244a7848b735f7f93fec5791]

        tdf#160837 win: Move SetMaximizedFrameGeometry to WinSalFrame
        
        Turn the previously static helper function
        SetMaximizedFrameGeometry into a WinSalFrame method.
        
        It requires write access to the maGeometry member, which is
        currently still, but soon no longer public.
        
        Change-Id: Iceef8a5366e6f4f5bf2163011651ee99ee908b2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173958
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [c3e89c03d340db7b80a36ada7cbd2ea9009ac075]

        tdf#160837 win: Replace some direct access to SalFrame::maGeometry
        
        Replace some direct access to the (currently still, but
        soon no longer public) SalFrame::maGeometry member in
        Windows-specific code by using the public getter
        SalFrame::GetUnmirroredGeometry, or more specific getters
        for the height and width (SalFrame::GetWidth, SalFrame::GetHeight).
        
        Change-Id: I49babdc0f40fe41b44f968ce0a7d3c219a3f93d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173957
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [22393b8f71d3a46a60ff0be5c938a5da6e5fabb0]

        tdf#160837 macOS: Replace direct access to SalFrame::maGeometry
        
        Replace direct access to the (currently still public)
        SalFrame::maGeometry member in macOS code by using the
        public getter SalFrame::GetUnmirroredGeometry, or
        more specific getters for the height and width
        (SalFrame::GetWidth, SalFrame::GetHeight).
        
        Change-Id: Ic14fa480c58b09e5d0dd9ea7042d82c5f82c6eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173956
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [460b11312214bb4cf08cecc22a35699e9e7c1889]

        tdf#160837 vcl: Use getter to get frame geometry
        
        Instead of directly accessing the (currently still
        public) class member SalFrame::maGeometry, use the getter that
        returns a const reference to it.
        
        Change-Id: Iac7dd70b82160acba06d8016d94a1ac4380e779e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173955
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [0879fff079965065935c88a1ba48385548176a13]

        tdf#160837 vcl: Use existing SalFrame::GetWidth
        
        Call `SalFrame::GetWidth` instead of directly accessing
        `SalFrame::maGeometry` and calling its `width()` method
        to simplify and abstract a bit from the implementation
        details in the callers.
        
        Change-Id: I06f960c4984e57a728c301e10fc62a28a8af6199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173954
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [7511fd100d0b4e4b10f3e0a986a4cb1db7a1637c]

        tdf#160837 qt: Move logic for QPaintEvent handling to QtFrame
        
        Add a new QtFrame::handlePaintEvent and move the
        logic from QtWidget::paintEvent to the new method
        and call the new method in QtWidget instead.
        
        This decouples QtFrame and (its friend class) QtWidget
        a bit more.
        
        Change-Id: I974a55d8f967dd85c3dd98e2ac8e28fa53c38c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173953
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [f5a20c68b3ed72bdb81bf8a6533f793520bd72c7]

        tdf#160837 qt: Move logic for resize event handling to QtFrame
        
        Add a new QtFrame::handleResizeEvent and move the
        logic from QtWidget::resizeEvent to the new method
        and call the new method from QtWidget::resizeEvent.
        
        This decouples QtFrame and (its friend class) QtWidget
        a bit more, and also prevents direct access to the
        (currently public) SalFrame::maGeometry member from
        QtWidget.
        
        Change-Id: I8969687c64b87677836b436b7815298a8e8d5cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173952
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [79773cf27636a99c2a37373046fb448e1d754c0d]

        tdf#160837 qt: Move logic for move event handling to QtFrame
        
        Add a new QtFrame::handleMoveEvent and move the
        logic previously duplicated in both,
        QtMainWindow::moveEvent and QtWidget::moveEvent
        there, then call the new method from these two.
        
        this also prevents direct access to the
        (currently public) SalFrame::maGeometry
        member from QtWidget and lets the subclass
        do it instead.
        
        Change-Id: I468802f204d3ac5869d833526286ca8ab349697b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173951
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7198c5e49eff0b82cb423424eaed0ee94d66db7d]

        add a rtf to pdf fuzzer
        
        Change-Id: Ib805b2e8245903f63096cc21f511ba7ae0a4f488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173466
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Noel Grandin  <noelgrandin@gmail.com>  [747e2676ec0681c6cd8789ab9218b437e17474b5]

        fix Printer::EmulateDrawTransparent
        
        after
            commit 9153a36b59f2efc2bfb2c9256c39eb5687808deb
            Author: Chris Sherlock <chris.sherlock79@gmail.com>
            Date:   Fri Mar 28 23:30:02 2014 +1100
            fdo#74702 Refactor OutputDevice::DrawTransparent()
        
        where it looks like a copy/paste error resulted in the metafile
        and mpAlphaVDev being restored too early.
        
        Change-Id: Ib2989927166bc2da7c8da6274f295a73218386fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173935
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [f513741bdc91f1871bdb8b01b21058e208a96eb0]

        fix basegfx.py
        
        after
            commit 3c82f49fcee3f1e4ddae8919993dde57e8bbab2d
        Author: Armin Le Grand (allotropia)
        <armin.le.grand.extern@allotropia.de>
            Date:   Mon Sep 23 17:57:00 2024 +0200
            Adapting basegfx.py due to blocking in some situations
        
        Change-Id: Ie266c7b5aeb5dccaae03c26b7cd73cd65841748c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173949
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [eb688cf19d870909938690fd333bf3a5e5c97273]

        tdf#130857 qt weld: Use native "Save Document?" dialog
        
        Now that
        
            Change-Id: If6e03bfa48b9052016539a25aadf40b599095918
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Sep 25 12:10:12 2024 +0200
        
                tdf#130857 qt weld: Implement QtBuilder::set_response
        
        implemented handling for button response codes,
        let QtInstanceBuilder create the "Save Document?"
        dialog that shows when closing LibreOffice while
        an unsaved modified document is open.
        
        This means that a native QMessageBox is now used for
        that dialog as well, unless env variable
        SAL_VCL_QT_NO_WELDED_WIDGETS is set.
        
        Change-Id: Ifb6c6f181d95d88138ed49f382b9eaad4d3ad944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173932
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [9b08982ff4a77603249af5edb013db7c6e03f82b]

        tdf#130857 qt weld: Implement QtBuilder::set_response
        
        Implement QtBuilder::set_response to set the
        given response code for a button:
        
        Set the `PROPERTY_VCL_RESPONSE_CODE` property
        on the QPushButton.
        `QtInstanceMessageDialog` makes use of that property
        to return the corresponding response code of the
        pressed button.
        
        (Make `PROPERTY_VCL_RESPONSE_CODE` a static
        member of `QtInstanceMessageDialog` to make
        it available outside of the class as well.)
        
        This works for buttons in message dialogs.
        An implementation for other dialogs still needs
        to be added when adding suppor for these to `QtBuilder`
        and extending `QtInstanceDialog`/`QtInstanceButton`
        accordingly.
        
        Change-Id: If6e03bfa48b9052016539a25aadf40b599095918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173931
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [547b99e0a8071ba92380f8d5f3751d02836942a4]

        tdf#130857: Move .ui -> VCL respone code mapping to handleActionWidget
        
        Move mapping the (GTK) response code set in the .ui file
        to the VCL equivalent from VclBuilder::set_response
        to BuilderBase::handleActionWidget.
        
        As VCL response codes are used by all implementations, this
        is not specific to the vcl::Window implementation and
        also allows an upcoming QtBuilder::set_response_code
        implementation to use the passed value as is.
        
        Change-Id: I5b6d262a657932038c423c0c2cdcf1fd32c8b6be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173930
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [ac0989b02fc6b8ff8fa7c985f8dcaf71547c489b]

        tdf#130857 VclBuilder: Use existing VclBuilder::get
        
        ... instead of reimplementing the logic in
        VclBuilder::set_response.
        
        Change-Id: I634d918a356caddc79419b94dda7bd0657fa8c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173929
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [92820328943623ef29a76cf7721a52bc7d051c90]

        tdf#130857 Use std::u16string_view for VclBuilder::get param
        
        This prepares for reusing the method elsewhere in
        `VclBuilder`.
        
        Only the `SAL_WARN_IF` (a no-op in release builds without
        `--enable-sal-log`) previously needed a `OUString`.
        Call `OUStringToOString` for that one explicitly, which
        is what previously happened implicitly by
        
            template< typename charT, typename traits >
            inline std::basic_ostream<charT, traits> & operator <<(
                std::basic_ostream<charT, traits> & stream, OUString const & rString)
        
        defined in include/rtl/ustring.hxx.
        
        Change-Id: I57ebac8c2189afeca33bfa483b8d5d5c7866d904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173928
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [fa3e77680b4f953a069ec62f75a5370db6d5d751]

        tdf#130857 Consolidate to one VclBuilder::get method
        
        Convert the single caller of the other variant to use
        the same as all other places, and drop the now unused
        method.
        
        Change-Id: Icde971b50f39cb8c8f32d1a6ddf4d0cc84f90440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173927
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  OmkarAcharekar  <omkaracharekar12@gmail.com>  [7282421451f4a85c06c34430e37a8e98a84f0919]

        tdf#130857 qt weld: Implement QtBuilder + use it for first msg dialog
        
        This implements an initial QtBuilder, which is used by
        QtInstanceBuilder to create weld::Widget instances
        using native Qt widgets.
        
        This tries to be close to the VCL implementation (VclBuilder).
        The selected approach is based on Caolán's suggestion in [1] to
        rework VclBuilder to have overridable methods for widgets creation.
        
        This way, we can have common code for the UI parser but the
        function for widget creation is different.
        
        Qt equivalents for Gtk's widget classes in the .ui files:
        
        * GtkMessageDialog -> QMessageBox
        * GtkBox -> QLayout (can be QVBoxLayout/QHBoxLayout based on
          property in .ui file)
        * GtkButtonBox -> QDialogButtonBox
        * GtkButton -> QPushButton
        
        As QMessageBox already comes with a layout and
        a QDialogButtonBox, don't create new ones, but
        return the existing ones in QtBuilder::makeObject.
        
        This commit implements initial support for the
        above-mentioned widget types and adds the first
        message dialog to the list of supported .ui files
        in QtInstanceBuilder::IsUIFileSupported,
        so a native QMessageBox is used for it now, unless
        environment variable SAL_VCL_QT_NO_WELDED_WIDGETS
        is set when starting LibreOffice.
        
        The dialog ("modules/swriter/ui/inforeadonlydialog.ui")
        gets shown when taking the following steps:
        
        * start Writer
        * type "hello world"
        * select text
        * "Insert" -> "Section"
        * tick the "Protect" checkbox in the "Write Protection" section
        * close dialog via "Insert" button
        * try to type in the protected section
        
        The dialog can be dismissed using the default "OK" button.
        (Handling for response codes for buttons is not implemented
        yet, which will be needed when welding dialogs that have multiple
        buttons resulting in different behavior depending on what button
        gets clicked.)
        
        This change was originally submitted as a WIP change as part of
        Omkar Acharekar's Outreachy project "Implement Qt/KDE Frameworks
        theming using native Qt widgets" (see [2]), then further refined
        by Michael Weghorn.
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2023-December/091288.html
        [2] https://lists.freedesktop.org/archives/libreoffice/2023-December/091281.html
        
        Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
        Change-Id: I6dd010a2138c245dc1e6d83dd08123898e9d9048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161831
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [1a1bf2b78d689a570cc71b7bcb3e0100947a2fb1]

        tdf#130857 VclBuilder: Extract helper to start parsing UI file
        
        Extract logic to start parsing/processing the VclBuilder's
        .ui file from the VclBuilder ctor to a new helper method in
        the base class, WidgetBuilder::processUIFile.
        
        This will allow to reuse it in the upcoming QtBuilder.
        
        Change-Id: Ia7d31563e5aeef0786b0db34abb1a32a3a479947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173902
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [ad19f3b9f23ddd4179589e9a641094f3e7642e72]

        tdf#130857 VclBuilder: Pass UI dir/root to BuilderBase
        
        Pass the UI file root down to `BuilderBase`, and add
        a new getter `BuilderBase::getUIFileUrl` to get the
        URL composed of the UI dir and the UI file passed to
        the ctor.
        This is in preparation of moving the `XmlReader`
        creation out of the `VclBuilder` ctor, so the code
        can be reused by the upcoming `QtBuilder`.
        
        Change the UI directory param from `const OUString&` to
        `std::u16_string_view` as suggested by the clang plugin.
        
        Change-Id: I3f7719e30e55bae3c774da704e642e4227165a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173827
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [385bbbd6e1f602d066b00c0913aefa36e75ce5a6]

        tdf#130857 Move VclBuilder::handleObject to WidgetBuilder base
        
        Move `VclBuilder::handleObject` to the template base class
        `WidgetBuilder` introduced in previous commit
        
            Change-Id: I2d81cc6dd54d796b549357a4444b95627661c623
            Author: OmkarAcharekar <omkaracharekar12@gmail.com>
            Date:   Fri Sep 20 13:33:01 2024 +0200
        
                tdf#130857 refactor VclBuilder: Extract template base class
        
        Add new virtual methods to that base class to override in the
        subclasses. These are currently the ones that `VclBuilder`
        already implements for `vcl::Window`.
        
        More refactoring - in particular for those methods that currently
        still do XML parsing themselves is planned for the future
        once the relevant functionality will be implemented in
        other subclasses. For now, those methods that do XML parsing
        themseslves trigger an assert in the base class implementation
        and remain unchanged in the `VclBuilder` implementation.
        
        One aspect to be aware of is that `WidgetPtr` should explicitly
        be initialized to `nullptr` if not assigned a different value:
        While `VclPtr` that gets used for `VclBuilder` has a default ctor
        that takes care of proper initialization, that's not the case for
        the upcoming `QtBuilder` [1] that just uses `QObject*` for `WidgetPtr`.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I5c1b7201c82ca2c0c2d7389642aee407ebea16ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173737
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-25  OmkarAcharekar  <omkaracharekar12@gmail.com>  [f61ecf25636d401f862c4de226c04237e1fb2f69]

        tdf#130857 refactor VclBuilder: Extract template base class
        
        Refactor `VclBuilder` by extracting the `handleChild` method
        and moving it into a new template base class `WidgetBuilder`,
        so both `VclBuilder` and an upcoming `QtBuilder` (see [1])
        can share the common logic to parse the .ui file and override
        the virtual methods like `applyPackingProperties`,
        `tweakInsertedChild` etc. to handle toolkit specific cases,
        as mentioned as one potential approach in Caolán's email [2].
        
        The new class has 2 template parameters `Widget` and `WidgetPtr`
        to account for the fact that `VclBuilder` doesn't just use
        `vcl::Window*`, but there's a specific class, `VclPtr`.
        
        As the inline comments say, more refactoring will be needed
        to abstract the current `VclBuilder` implementations
        of various methods from the `vcl::Window` specifics and
        make them reusable for other subclasses as well, but this
        commit is a start. The idea is to allow for incrementally
        refactoring aspects relevant for specific .ui files/features
        rather than having to refactor everything and implement
        support for all widget types at once, see also
        
            commit 9b3a2996e710fee11145dcbbe38a6f1e6f646ec8
            Author: OmkarAcharekar <omkaracharekar12@gmail.com>
            Date:   Wed Sep 18 09:35:09 2024 +0200
        
                tdf#130857 qt weld: Add QtInstanceBuilder skeleton
        
        which adds an initially empty list of .ui files that
        should be handled by the upcoming Qt-based implementation.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        [2] https://lists.freedesktop.org/archives/libreoffice/2023-December/091288.html
        
        Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
        Change-Id: I2d81cc6dd54d796b549357a4444b95627661c623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163103
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3cbe17c83c4846fd57a3f45074864367b5139011]

        cid#1606825 Data race condition
        
        Change-Id: If2a0385a0b9d7d09c05cacc9bbc1034bd14f53b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d26313ea1931be1a9224ede0f599260177ca6ad6]

        cid#1607206 PA: Public Attribute
        
        Change-Id: If140f3256a7e1afaae723147cb4870fa01b4e52e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173946
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca4f427d021b67dfc855dcb10c1e978b278c5bd5]

        cid#1608290 PA: Public Attribute
        
        Change-Id: I46bd84741d3958cb807df4f3080426fc2afdd6fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173945
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [48b2bfdb2131ef4873210a01b9db513cb8046606]

        cid#1608090 PA: Public Attribute
        
        Change-Id: I9bf9de822851bbf4f28614ae686e79a9c7438aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173944
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c78ce59f87f809c3a26b7b92284030d8d5b3438]

        remove call to getCatalogSeparator where return is ignored
        
        since:
        
        commit 43cc8ad33e815522e2b23ac87a4a9c4526cd85c9
        CommitDate: Mon Jan 5 08:23:29 2015 +0200
        
            java: remove dead code
        
        Change-Id: Ib2b3e7a45ef1c9f1a7edf06ed6d474375bfe1c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173943
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1cb1e96979593ce51ff8a09a13a250552a2ce5bb]

        cid#1606775 PA: Public Attribute
        
        Change-Id: Ie5034470b02310f329c041224ebf035769374e50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173942
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eea21fab2b3c5bd692b71cf446de2f37e049a153]

        cid#1606722 PA: Public Attribute
        
        Change-Id: I23f518a7b492ae92417657f5a319eb1aae4dac3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2c2fc06966dc91306ff83f7d0f2c37925b6b57f4]

        Related: cool#9735 allow LOK_CALLBACK_DOCUMENT_SIZE_CHANGED during paint
        
        we want this to get through because of a scenario like
        
         #0  ignoreLibreOfficeKitViewCallback (nType=13, pImpl=0xf9bd620) at /home/caolan/LibreOffice/co-24.04/sfx2/source/view/viewsh.cxx:3219
         #1  0x00007fd4a2428979 in SfxViewShell::libreOfficeKitViewCallback (this=0xf9bd090, nType=13, pPayload=...) at /home/caolan/LibreOffice/co-24.04/sfx2/source/view/viewsh.cxx:3278
         #2  0x00007fd4a23ab80b in SfxLokHelper::notifyDocumentSizeChanged (pThisView=0xf9bd090, rPayload=..., pDoc=0xec53578, bInvalidateAll=true) at /home/caolan/LibreOffice/co-24.04/sfx2/source/view/lokhelper.cxx:711
         #3  0x00007fd484eba265 in SwViewShell::SizeChgNotify (this=0xf9bf3c0) at /home/caolan/LibreOffice/co-24.04/sw/source/core/view/viewsh.cxx:1154
         #4  0x00007fd484775a62 in AdjustSizeChgNotify (pRoot=0xed16880) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/pagechg.cxx:842
         #5  0x00007fd48477e029 in SwRootFrame::CheckViewLayout (this=0xed16880, pViewOpt=0x0, pVisArea=0x0) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/pagechg.cxx:2436
         #6  0x00007fd484775da2 in SwPageFrame::Cut (this=0x120350f0) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/pagechg.cxx:914
         #7  0x00007fd484779ec8 in SwRootFrame::RemovePage (this=0xed16880, pDelRef=0x7ffe90279548, eResult=SwRemoveResult::Prev) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/pagechg.cxx:1511
         #8  0x00007fd48477a187 in SwRootFrame::RemoveSuperfluous (this=0xed16880) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/pagechg.cxx:1550
         #9  0x00007fd4847336b2 in SwLayAction::InternalAction (this=0x7ffe90279a60, pRenderContext=0xf9bb5f0) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/layact.cxx:694
         #10 0x00007fd4847323b8 in SwLayAction::Action (this=0x7ffe90279a60, pRenderContext=0xf9bb5f0) at /home/caolan/LibreOffice/co-24.04/sw/source/core/layout/layact.cxx:396
         #11 0x00007fd484eb5fc2 in SwViewShell::ImplEndAction (this=0xf9bf3c0, bIdleEnd=false) at /home/caolan/LibreOffice/co-24.04/sw/source/core/view/viewsh.cxx:309
         #12 0x00007fd483fa3f78 in SwViewShell::EndAction (this=0xf9bf3c0, bIdleEnd=false) at /home/caolan/LibreOffice/co-24.04/sw/inc/viewsh.hxx:637
         #13 0x00007fd484ebf56b in SwViewShell::ApplyViewOptions (this=0xeddec90, rOpt=...) at /home/caolan/LibreOffice/co-24.04/sw/source/core/view/viewsh.cxx:2235
         #14 0x00007fd484577013 in SwEditShell::ApplyViewOptions (this=0xeddec90, rOpt=...) at /home/caolan/LibreOffice/co-24.04/sw/source/core/edit/editsh.cxx:1094
         #15 0x00007fd48574a5cf in SwWrtShell::ApplyViewOptions (this=0xeddec90, rOpt=...) at /home/caolan/LibreOffice/co-24.04/sw/source/uibase/wrtsh/wrtsh1.cxx:2137
         #16 0x00007fd484ebe79e in SwViewShell::PaintTile (this=0xeddec90, rDevice=..., contextWidth=1792, contextHeight=768, tilePosX=0, tilePosY=113280, tileWidth=13440, tileHeight=5760)
             at /home/caolan/LibreOffice/co-24.04/sw/source/core/view/viewsh.cxx:2019
         #17 0x00007fd4855fc5f0 in SwXTextDocument::paintTile (this=0xec53280, rDevice=..., nOutputWidth=1792, nOutputHeight=768, nTilePosX=0, nTilePosY=113280, nTileWidth=13440, nTileHeight=5760)
             at /home/caolan/LibreOffice/co-24.04/sw/source/uibase/uno/unotxdoc.cxx:3145
         #18 0x00007fd4a24c5ada in doc_paintTile (pThis=0xed2fa10, pBuffer=0x12871f30 "", nCanvasWidth=1792, nCanvasHeight=768, nTilePosX=0, nTilePosY=113280, nTileWidth=13440, nTileHeight=5760)
             at /home/caolan/LibreOffice/co-24.04/desktop/source/lib/init.cxx:4431
         #19 0x00007fd4a24c6bb3 in doc_paintPartTile (pThis=0xed2fa10, pBuffer=0x12871f30 "", nPart=0, nMode=0, nCanvasWidth=1792, nCanvasHeight=768, nTilePosX=0, nTilePosY=113280, nTileWidth=13440, nTileHeight=5760)
             at /home/caolan/LibreOffice/co-24.04/desktop/source/lib/init.cxx:4629
         #20 0x00000000005f0f0e in lok::Document::paintPartTile (this=0xf521420, pBuffer=0x12871f30 "", nPart=0, nMode=0, nCanvasWidth=1792, nCanvasHeight=768, nTilePosX=0, nTilePosY=113280, nTileWidth=13440, nTileHeight=5760)
             at /home/caolan/LibreOffice/co-24.04/include/LibreOfficeKit/LibreOfficeKit.hxx:621
         #21 0x00000000005c2627 in RenderTiles::doRender(std::shared_ptr<lok::Document> const&, DeltaGenerator&, TileCombined&, ThreadPool&, std::function<void (unsigned char*, int, int, unsigned long, unsigned long, int, int, LibreOfficeKitTileMode)> const&, std::function<void (char const*, unsigned long)> const&, unsigned int, int, bool) (document=..., deltaGen=..., tileCombined=..., pngPool=..., blendWatermark=..., outputMessage=...,
             mobileAppDocId=3, canonicalViewId=1000, dumpTiles=false) at ./common/RenderTiles.hpp:123
         #22 0x00000000005cd29d in Document::renderTiles (this=0xe6eefc0, tileCombined=...) at kit/Kit.cpp:933
        
        where otherwise the browser gets no update of the document size.
        
        Change-Id: I396daa9c7ee5c306ee107839f6fba6b26a70683d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173936
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ed75469d322f61abef634d417c5c81bb28585023)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [146dac7d30823678b9e87f8128904f5815c1a2ed]

        tdf#162690, tdf#162687: Adapt to ODF 1.4
        
        After this, the workaround introduced to
        OpenDocument-v1.4+libreoffice-schema.rng in
        afa4965e4df6f1f0c43c0a059f216e7f8a21ba82 "schema: update to ODF 1.4 OS"
        can be removed
        
        Change-Id: Iecf31cec0bf187155a97e5b6ccf8173b6aba82fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173940
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [71aeb561e7e4e87f69e438705a59146ad02cbc71]

        NotoSerif: upgrade to v2.014
        
        Downloaded from https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSerif-v2.014/NotoSerif-v2.014.zip
        
        Change-Id: I867b69c95d16c08f051569a2021a772272444dca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173926
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-25  Mike Kaganski  <mike.kaganski@collabora.com>  [12e08b3cba0e75f1bd3a42f30e4830d723b24ece]

        tdf#163145: revert commit 6f224a17dbf635319503a81ce4038b1ae2ad6de0
        
        I can't reproduce the problem from tdf#136933 anymore (using kf5
        and qt5), while it's reproducible using v.7.0 bibisect repo with
        qt5. I conclude, that the problem got resolved in the meanwhile.
        So it seems to make sense to just revert the problematic commit.
        The incorrect line drawing still may need to be fixed eventually.
        
        There seem to be no way to test SlideImpl::getCurrentSlideBitmap,
        which eventually calls CanvasHelper::strokePolyPolygon. So this
        change has no unit test, unfortunately.
        
        Change-Id: I1d82b6f734a4f69d93c9d61732f55ef8158cfbe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173933
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [828a836031463ff12b787d1599628568b8c5e5cb]

        Fix typo
        
        Change-Id: Id1e54ad708501733282851b6538bc946119742b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173934
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [f709c1e7a8060661d3f32d86ce035b95f3fdfd52]

        NotoSans: upgrade to v2.014
        
        Downloaded from https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSans-v2.014/NotoSans-v2.014.zip
        
        Change-Id: Ief6598bb959bfc408e7455e6a4f55a6cdc8db8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173925
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-25  Jaume Pujantell  <jaume.pujantell@collabora.com>  [34d242f5099fdb9234ac047e5712aea6df113e4c]

        tdf#163092 sw: fix broken anotations on save to docx
        
        Opening an odt file and saving it as docx would break the comment
        threads into unconnected comments.
        
        This also fixes a regression from commit
        3bb2668f5e753e9fa6aa7eea74454bf11cdfc853 where creating a commet
        thread with multiple children and saving to docx would break it
        into separate threads.
        
        Change-Id: I76a0ec49bd69b953d816b3b5d3cc6d14065d5846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173681
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173872
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2024-09-25  Jaume Pujantell  <jaume.pujantell@collabora.com>  [98cd8bac764b5d2a0a6a1cd8ee619529f1ab88b7]

        sw: add new command to make a response comment root
        
        Adds the option to convert a reply comment into a new top comment
        while preserving the parent-child realtions of the other comments
        in the thread.
        
        Change-Id: I3cd5e5466fadc2226651d7c244b5139ec2d1f949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173051
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173870
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        Tested-by: Jenkins

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3e308fd3d29748d6a8fd1463df0a847a52a36d0]

        cid#1606875 Data race condition
        
        Change-Id: Ic4932568bb3f0348595358fa19032aba56bfa6c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173899
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bbac45eabed6464f85738e372ea6c2e4f23a11a0]

        cid#1606887 Data race condition
        
        and
        
        cid#1607140 Data race condition
        
        Change-Id: Ie27b42012b945bfad0c7344c734dc0b8f0816e70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173898
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c30fa95c5d0e03c523d22d01be3ae4ce3b79c723]

        cid#1607313 silence Overflowed return value
        
        and
        
        cid#1608099 Overflowed constant
        
        Change-Id: I10e08c1184bb6630b849c3e24a0c9b26302fd18a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173896
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [695a46783e7dfd7cee0e083d9a8c2864dd7ac884]

        cid#1606918 Data race condition
        
        and
        
        cid#1606991 Data race condition
        cid#1607010 Data race condition
        cid#1607323 Data race condition
        cid#1607335 Data race condition
        cid#1607635 Data race condition
        cid#1608162 Data race condition
        
        Change-Id: I65edcf08f92fb564d56d0e8954212533c1cbec91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cd5dcc6e43c669d99133b8de7d8559ba3145ba6d]

        cid#1619687 Not restoring ostream format
        
        Change-Id: Id46d2317a0eeef612836fc58dc9da18cf7ee99a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82584fe1b9976a6aafc84d5d0233b46eac7656a2]

        cid#1619686 Invalid iterator comparison
        
        Change-Id: I731cc791b1efab895bddbea9a235a9add3288058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173893
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fea3c9d69cad1a0408883bf5dc44670cc53fcbc2]

        Confine a hack to known-broken --enable-pch
        
        The hack was introduced in 7db1150b2c4a9adb993084d2dceedb450781b1dc "fix macos
        build with clang 16".  (And for our --enable-pch for Clang being known-broken,
        also see ffc1ab15ae358315516aab319778a254688afbd3 "Work around some Clang PCH
        consteval issue by disabling HAVE_CPP_CONSTEVAL".)
        
        Change-Id: I5dcd7f96ba39bf4d0748940778699cb7d368f449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173891
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-25  Miklos Vajna  <vmiklos@collabora.com>  [d95ab8d3a3a102c00b69f0b0b49d7eb49e34051e]

        cool#9992 lok doc sign: fix import of the private key
        
        Once the signing key is taken from the matching SfxViewShell (not yet
        done), signing with a certificate specified via initializeForRendering()
        failed with:
        
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx:330: X509Certificate_NssImpl::getPrivateKey() cannot find private key
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:812: Can't get the private key from the certificate.
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: keys.c:1347: xmlSecKeysMngrGetKey() '' '' 45 'details=NULL'
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:822: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL'
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:537: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' '
        warn:xmlsecurity.xmlsec:13020:13005:xmlsecurity/source/xmlsec/errorcallback.cxx:53: xmldsig.c:301: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' '
        
        The trouble was that we wanted to keep the private key in-memory,
        presumably because initially the whole NSS database was in-memory for
        the LOK case. This was changed in commit
        87eec1b90b6ecd83455f09168430c23f73c25c86 (NSS: create a temporary
        database instead of in-memory, 2018-12-31), so there is no problem with
        a not-in-memory private key anymore.
        
        Note that the problematic codepath was only triggered when first the
        certificate chooser was ran and only then we signed. So the testcase
        also gets the cert flags before signing, otherwise the test would
        succeed even without the fix.
        
        Change-Id: I5086b205c91b630ddd343c0eb91bd9e63b3ea238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173892
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-25  Kira Tubo  <kira.tubo@gmail.com>  [dd181a31d897ca6785191e727ed6c57a53c22ad3]

        tdf#139619 Add Line Style to Impress standard toolbar
        
        Change-Id: I00e07e80cf86bc60cb7323eedaf27931cfc71a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173696
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-25  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [dad5b34d011da41d536eb0db9635ac84e51bfcd5]

        tdf#163131 CairoSDPR:
        
        Added BColorModifierStack to SVG linear and radial
        gradient direct support, was missing.
        
        Change-Id: I1405ea0653180fa695b40082bf8b8520441d0620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173871
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-25  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3c82f49fcee3f1e4ddae8919993dde57e8bbab2d]

        Adapting basegfx.py due to blocking in some situations
        
        I have stumbled over the GDB integration in vscode hanging
        when there is a BP and *below* a declaration of e.g. a
        basegfx::B2DPolygon. This seems to happen due to the
        instance not yet being incarnated, but the variable view
        already listing it and triggering methods in basegfx.py
        to evalualte stuff.
        It just hangs/loops, I guess it's fetching the PointCount
        from a random mem ptr'ed Polygon, then tries to evaluate
        something with the Points.
        I do not really know about what to do here, but I figured
        out that testing 'if self.exists()' where the instance
        gets accessed (using gdb.parse_and_eval) helps.
        Thus this solves the problem for me and - after stepping
        over the incarnation of the object I can see it's true
        content.
        I hope someone who might have more knowledge about that
        GDB and python stuff can have a look and maybe tell if
        tis is OK or should be done in a different way.
        
        Change-Id: Ia844b0aded97220df7f4605fdcffeac5e2270db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173826
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-09-25  Heiko Tietze  <tietze.heiko@gmail.com>  [e0808a1f84c40ea15d2d88beebd97659e7d46348]

        Resolves tdf#161574 - Individual labels for TOXes in the UI
        
        + Upper-case for Delete Index
        + User-Defined amended with Index
        
        Change-Id: I972ee22fa3681a0f1159426836a0ec1b83fa5e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173849
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-25  Miklos Vajna  <vmiklos@collabora.com>  [b248260bf88360ff3ca41bb3c0ab6ca5a74f42c4]

        sw: extract SwDoc::ForEachCharacterItem() from Underline/ColorItems
        
        This is meant to avoid copy&paste while keeping the public interface
        template-free.
        
        Change-Id: I3bc27d35b135df1693737de6b0e02444a06e4cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-25  Ashok  <ashokemailat@yahoo.com>  [dbccdea9744c5400a5dad908bce5d2973ac60f3c]

        tdf#42982 Improve Error Messages with RuntimeException in UNO API
        
        Improved UNO API RuntimeException to return descriptive message.
        
        Change-Id: Idae14c2ae095270c30b86cfad64936ccead5e4d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173686
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-25  Mike Kaganski  <mike.kaganski@collabora.com>  [40a38b305c4f8908f24192bd5dc796ebd6cf6d6e]

        Simplify a bit
        
        Change-Id: Ib82f6456707217412097473a4387d2e6088bd3f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173801
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-25  Mike Kaganski  <mike.kaganski@collabora.com>  [8b23abac4929bbb15a52afb083259cd2d24b4995]

        tdf#163091: check rParam.mnX before passing it to RowInfo::cellInfo
        
        When moving to the left, the RowInfo may have e.g. cells 21 to 41,
        and rParam.mnX may be 15, which is outside of the RowInfo data.
        
        It seems that in this case, when we handle the data outside of
        the visible area, setting clip marks may be safely skipped anyway.
        
        Change-Id: I2f507dc166468c44e34645bc34c827456f1ab1ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173857
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-25  Jonathan Clark  <jonathan@libreoffice.org>  [5b494880e86dfdb702f9cda807253fa575814d6f]

        tdf#163105 Require kashida after Seen, even before a final Yeh
        
        Small tweak to the kashida insertion rules to restore some previous
        behavior. Kashida should not be inserted after a final Yeh, but should
        be inserted after an initial or medial Seen, even if it is followed by a
        final Yeh.
        
        Change-Id: I1fef2d32961c6f55006b2df456827588f62af40b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173889
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-25  Jim Raykowski  <raykowj@gmail.com>  [6573d0ed5479fd543303e82ec23195bdc101ceb4]

        Resolves tdf#152297 Track comments in the Navigator also by focus
        
        inside the comment box
        
        Change-Id: I7ced30c606d89a11012e21bfce18939b7660f038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173824
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-09-25  Jonathan Clark  <jonathan@libreoffice.org>  [a3b0ef4088183c4a3b2ec3fef08ef91314eaef54]

        tdf#163105 Restore some missing kashida opportunities
        
        This change partially reverts the fix for tdf#65344, to allow more
        candidate kashida insertion positions.
        
        The final position fallback from the original ruleset has been restored.
        Instead, tdf#65344 is now fixed by explicitly prohibiting kashida under
        a final-position Yeh.
        
        Change-Id: I9fe8c656768777c160205ad9892f2fe916a2a926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173887
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-25  Jonathan Clark  <jonathan@libreoffice.org>  [41671d732ad933175779b61159b56824ff77b2fe]

        tdf#163105 sw: Add some whitespace expansion to kashida justification
        
        Tihs change updates Writer kashida justification to include some
        whitespace expansion, mirroring the behavior of Edit Engine and other
        word processor programs.
        
        Each kashida and space character are given 1 unit each of extra space.
        
        Change-Id: I8c9031a0d51844e532b9d1f7e3619c2c9ba23f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173884
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-25  Justin Luth  <justin.luth@collabora.com>  [9112a4a4cc700569f8321b8191abb4238697a404]

        tdf#162916 writerfilter TOC: import "no page number" flag
        
        The field command "TOC \n 2-2" means that
        level 2 entries should not display the page number,
        so in LO just exclude those portions from the definitions.
        
        The impact only becomes noticable when you update the TOC,
        because the initial content is just read from document.xml.
        
        The export part was already handled at LO initial import,
        since DOC format needed the proper sFieldCmd string.
        DOC format already imports this just fine.
        
        Note that the unit test also specifies 'TOC \o "2-3"'
        which means that the first level should not show,
        but I don't think LO supports skipping earlier levels.
        
        make CppunitTest_sw_ooxmlexport10 \
            CPPUNIT_TEST_NAME=testTdf162916_nastyTOC
        
        Change-Id: I9661c56c84bcd28bf1664d808a0e9c38051cf67b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173885
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-09-25  Jonathan Clark  <jonathan@libreoffice.org>  [fe4687ed174c54f2eb25f8088bf3fb6cb4858175]

        tdf#163105 Consolidated duplicated kashida justification code
        
        The kashida candidate position selection logic was copied-and-pasted
        from Writer into Edit Engine. This change consolidates the shared code
        into a library. This change also adds some minimal characteristic tests,
        which previously did not exist.
        
        Change-Id: I2bfbfa79858347803474b754566436f3e74d1a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173883
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-24  Patrick Luby  <guibmacdev@gmail.com>  [2fc1034de4fd23d810593533b70ff674b0ccd706]

        tdf#163135 eliminate native "secure coding" warning
        
        Starting in macOS Sonoma, a warning is printed at launch that complains
        that -[NSApplicationDelegate applicationSupportsSecureRestorableState:]
        is not implemented so implement that selector.
        
        Change-Id: Idfb62c271af5256270361efdd458f2ef9ea4c40b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173882
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-09-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3b6dbc60d1344f290367fe9f887855f408700bf5]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/fb1a63fc872e6ddc8c9ae4b0b366072253e58ddc>
        "gvfs: Update gvfs-1.54.2.tar.xz to 1.56.0 (#303)"
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/8b55ceec9bf4f3298672ad6685455b0bb035d470>
        "Update org.freedesktop.Platform to 24.08 (#302)"
        
        Change-Id: Ib0bffe9652ed3e9c4107c15dfff75a0f57f682c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173881
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d17898aafa6f39e1e71959922209656b2243ae67]

        prefer the per-ViewShell rendering data for default document bg color
        
        Change-Id: Ie67d6317641d63524c20a3001179ad958ebce300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173866
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 927fd9820bcdbed35b34c7bb7081a19535aa041b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Ashok  <ashokemailat@yahoo.com>  [51fdc8eccda853878c26821c4ded027fb65a0022]

        tdf#114441 Use sal_int32 instead of sal_uLong
        
        Changed data type from sal_uLong to sal_Int32.
        The constant value is fixed at 1000.
        
        Change-Id: Iddc0aafb252ca44feb8ae018de18296b8b46769b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173753
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-24  Jim Raykowski  <raykowj@gmail.com>  [d5b76e32f99738301c253840ff089cfc830874dc]

        tdf#163100 Need more FIND details
        
        This enhancement patch for the quick find panel makes the document
        order index of the match entry selected in the finds list be shown in
        the found times label at the bottom of the panel. For example,
        selecting the 6th entry in the finds list for a search that has 25
        matches will display "Match 6 of 25 matches."
        
        Change-Id: Iea39e754b0cd75d3ca446781a4b8d2e8651e7d08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173835
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [efa381c59bf3539b5dba2249e692539056a4162e]

        cid#1606653 PA: Public Attribute
        
        Change-Id: Iab539e41702f0decc071be13ef02c0fb14b11e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a9889e1aa88dbbd1fd5312d57b73eb4f2957b9c9]

        cid#1606721 PA: Public Attribute
        
        Change-Id: I62fbc3ee8fc05facb4c1542706c46266005c363f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81d920a9655c29a723b1257996555dc221c0eae3]

        cid#1606722 PA: Public Attribute
        
        Change-Id: Icf37c5cc813ef80252f557d8896e163fe90e97b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173846
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3f581b462d45233a37de6636687f2b2c06b388c]

        cid#1607022 PA: Public Attribute
        
        Change-Id: I0c0a107643b67395a2f4835aab70c58ca6edec9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173845
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3c3657cbabe711d057c09e8869b2751a78c34e3a]

        cid#1607041 PA: Public Attribute
        
        Change-Id: I991d0213a2f429a89e6b1431d9dc900400b60a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173844
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a90d2bcb3d18787e3c9dec9a762d88492a9ba934]

        cid#1607206 PA: Public Attribute
        
        Change-Id: I70a2b4fbbde93f9ce839129441a17afe3d2059e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173843
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f903afd4e94594a396f7e9087bd04c0eb84541c]

        cid#1607381 PA: Public Attribute
        
        Change-Id: I9aa852422a0ce3daa527599f9d3ed033b5943d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b3a14ae7efa82473998c04d9e23748c878566acf]

        cid#1607483 PA: Public Attribute
        
        Change-Id: I4712b1523cc54feb3b84b5435960e4d5707735a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173841
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [96427ee2e19479fb4a88e08ad176361aaae1a5a6]

        cid#1607639 PA: Public Attribute
        
        Change-Id: I58d91c2d89b175dc8b8c062e1e291fe9c5192017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173840
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5fcc0a0c65a1856a1fb9930b0c64bedeb0a2878a]

        cid#1608090 PA: Public Attribute
        
        Change-Id: I8ea0d65e01affa7b2a7b787bebcf5bc2ca3b63f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173839
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3e831187387c7b3fc584c1164c4497a140911f3c]

        cid#1608290 PA: Public Attribute
        
        Change-Id: I3fe12f088e6bd2951a9dfdf62b156eb33a44750b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173838
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Noel Grandin  <noelgrandin@gmail.com>  [c2f32dbd8a64bb986b01aed746e7448fadb8cbe0]

        dont use GetItemSurrogates for gathering SvxShadowItem
        
        which is very expensive these days
        
        Change-Id: I93833d703407304e8ed20be0783e0562352b927a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173867
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-24  Noel Grandin  <noelgrandin@gmail.com>  [a8161a4aea3fc7e2f24435c30befdf82421653e6]

        dont use GetItemSurrogates for gathering SvxBoxItem
        
        which is very expensive these days
        
        Change-Id: I0cb9af2afcbdb802e6a783df6cd30f5905e1ff1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173854
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-24  Noel Grandin  <noelgrandin@gmail.com>  [a32c551d75fadfdfcbf4299320b88264123d6805]

        fixes for "dont use GetItemSurrogates for gathering SvxTabStopItem"
        
        improvements to commit 01ab23b13297c9d7b091dfbe2850cd343fcd3e0e,
        thanks to vmiklos for review
        
        Change-Id: I2d4c5fb07405988b56156370db2e73ba0a24fa36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173763
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1c4f7139e9a20d495f1577792758cf742d34dc2e]

        Let test operate on temp copy of source document
        
        The CppunitTest_xmlsecurity_signing
        CPPUNIT_TEST_NAME=testImplicitScriptSign::TestBody introduced in
        e5a0209d4b1e1f09191a442e04d626b21c49b9df "cool#9992 lok doc sign: allow sign of
        macros & the document itself in one step" failed on a read-only source tree with
        
        > An uncaught UNO exception
        > - com.sun.star.ucb.InteractiveAugmentedIOException: {Message: "an error occurred during file opening (18/28) at /home/libo/src/core/ucbhelper/source/provider/cancelcommandexecution.cxx:83", Context: @0x7ff5cb43cf90, Classification: com.sun.star.task.InteractionClassification 0, Code: com.sun.star.ucb.IOErrorCode 1, Arguments: [com.sun.star.beans.PropertyValue: {Name: "Uri", Handle: -1, Value: string: "file:///home/libo/src/core//xmlsecurity/qa/unit/signing/data//macro.odt", State: com.sun.star.beans.PropertyState 0}, com.sun.star.beans.PropertyValue: {Name: "ResourceName", Handle: -1, Value: string: "/home/libo/src/core//xmlsecurity/qa/unit/signing/data//macro.odt", State: com.sun.star.beans.PropertyState 0}]}
        
        Change-Id: I9198ca1eba03d55e745a0bbb344963139941496f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173852
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-24  Heiko Tietze  <tietze.heiko@gmail.com>  [ada128e5f206e9eee249101236344b111d0ee99f]

        Resolves tdf#142120 - Respect app color for text with lines breaks
        
        Change-Id: I33ebfc1d542da06bd9d69f8e9a57797b8541a7f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173856
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [34c4a18d78b0b8a2eb2bc4376190d894b8c3d6f4]

        tdf#162686: Adapt to ODF 1.4
        
        Change-Id: I47f29a88eb0e98dc0fd312a3895d3a578fa04d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172768
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [a36e806c21108af3a6985625c983265ba8404930]

        ODF 1.4: Add ODFVER_014 and ODFSVER_014
        
        Change-Id: I0aa1b6a1f9eec3932b76f5ad0649c462884ffa68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172767
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cdfa19a797da82aa238ba21cef92682d9a069a0c]

        lok: render the whole slide temporary (with bg and master content)
        
        This changes the rendering of the main slide layer content to also
        render the master page and the background. This is needed because
        of the issue with the white background (instead of transaprent).
        
        (cherry picked from commit 99f9d663a26da00bebd8595f1e0819ebc6c3e4f0)
        
        Change-Id: I88b6f0287482ad1ee498b0bbda8e19d015649879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173853
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-24  Pierre F  <fpy@bger.ch>  [0b5d753b5025774f928293a2996cc35e2633a170]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to db426f52a985e90199d4834581478d46b39e5d13
          - tdf#121697 readability/maintainability factorization
            
            first step for
            * h1 - h6
            * note, warning, tip
            * bascode, pycode, sqlcode
            * common attributes
            
            Change-Id: I249c660636a3714f40d88fbe3afc2bed2275169f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173022
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [746c35baf6de94f2aaf7c732a9441acd0383e2ba]

        ODF 1.4: schema: rename to OpenDocument-v1.3*
        
        Change-Id: I83ac72accf2bbddd3ca74790654327bb9e86dba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172765
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3af9cc7e2514641f2e9a1238ddaaf578271ab832]

        cid#1607586 explicitly return after JNI ThrowNew
        
        Change-Id: Ib863d3c9769602088fae8d4d51d0449101979cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c8b5ac2a54af99e32f77aa07dec0dda2be074289]

        cid#1607586 Overflowed return value
        
        and
        
        cid#1608074 Overflowed return value
        cid#1607598 Overflowed return value
        
        Change-Id: Ib884c10083c01578a7a0926d5f2f3c2d1f7501c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173833
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [fff43a2e76dd6e6892a9c447edf60a44ba1a345e]

        use more concrete UNO types in dbaccess
        
        Change-Id: Ibcf54e3bbdad4888c5da1f52f636951356e0aa51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-24  Noel Grandin  <noelgrandin@gmail.com>  [59915ec9211b90e5b7be164d0bfa26d9d9be4f5a]

        in OUString find functions, assert that fromIndex >= 0
        
        otherwise, the pointer calculations mean that we will start searching
        inside data that does not belong to the character array.
        
        which flushes out a couple of problem cases
        
        Change-Id: Ide9edf23900289343077c406d95614057c1d1a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173807
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-24  Miklos Vajna  <vmiklos@collabora.com>  [4787fd4fc86230893a6da309f45964116b3a67df]

        cool#9992 lok doc sign: store signing cert in the view
        
        In case signing certificate would be stored in the model (like it
        happens on the desktop), then the certificate viewer would show all
        signing certs of the currently editing users, which is far from
        expected.
        
        At the same time, there is just one NSS database per process, so it's
        hard to not have them in the same database.
        
        Fix the problem by storing a reference to the signing key in the view
        shell, then we can show only that in xmlsecurity/ in LOK mode, and thing
        else.
        
        This is just the sfx2/ side of things, the xmlsecurity/ part still needs
        implementing.
        
        Change-Id: Id7a56f28598ec60217c6bac095c2ff350f39bc3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173837
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [afa4965e4df6f1f0c43c0a059f216e7f8a21ba82]

        schema: update to ODF 1.4 OS
        
        * The change in schema/odf1.4/OpenDocument-v1.4-schema.rng
        is the same as 56d8007a197b095b09423c691a51515567648e80
        "tdf#134734 tdf#141059 tdf#122508 cui,sw,xmloff: BackgroundFullSize"
        
        Change-Id: I79bdebbee4d250af9c5822bf2f205ef386f1b97d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172392
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [7244f5eaf7c2879e7b18f8d650c88d1aaff31c24]

        ODF 1.4: Add schema
        
        Source: https://github.com/oasis-tcs/odf-tc/tree/master/docs/odf1.4/schemas
        Change-Id: I8b00d6c3c6c3df9c7fc40bcda9379199ff74a7b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172253
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-24  Heiko Tietze  <tietze.heiko@gmail.com>  [8192a3bde845d6ff51e81ee05c297e7c9ffcd79e]

        Resolves tdf#163049 - Name the sidebar find deck
        
        Change-Id: I7638f25f4c8afb8896a77aa30c46bce08c8907fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173836
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c46c109204675d9a04ed16b8c53fdba71519ef4a]

        cid#1607535 silence Overflowed constant
        
        and
        
        cid#1608504 Overflowed constant
        cid#1607518 Overflowed constant
        
        Change-Id: Ife45a2f414ea703f627b7083d746bc11f6d4f359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-24  Kira Tubo  <kira.tubo@gmail.com>  [f528d18f99f5d45ccb4ac0beb12045e51fbea477]

        Reinstate margin paddings on default Comment Style
        
        This partially reverts commit 9286ac87abe4eeaf878585bdc5bb4fee40f950cc
        
        Margin paddings should not have been removed due to request on tdf#159531
        
        Margin paddings initially removed as part of tdf#161657
        
        Change-Id: If840a3a57d1fbbcb894e192b98f05ccbe53e89be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173687
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c37d95fbbcc97c2dc824ecee8369140a6442980]

        Don't change focus from sd navigator if it will be immediately refocused
        
        Instead of grabbing focus away from the treeview, and then grabbing
        focus back to the treeview (which disrupts the vcl treeview's ability to
        enter inline editing mode on 2nd click), just don't change focus at all
        if the focus will up in the initial location.
        
        git show -w is your friend here
        
        Change-Id: Idb53fa95495f1819cd121079f3f51c39cc629336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173829
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [5aea0dd59cf15c0f93d432aa722c1e0e1df703e4]

        sfx2: move DocumentProperties from Java to CppUnittest
        
        Change-Id: I007ff75fb63a20304726a22fa3d949eb3616069e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173820
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ceff2c65cc2ae80a11a1787400ca22dea9c3500]

        use more concrete UNO types in dbaccess
        
        Change-Id: If34294e2db4dc3365a7308c90658d5fa0c0e6532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173817
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-24  Laurent Balland  <laurent.balland@mailo.fr>  [c2017f839162a5236afcd73636ecfa73349b9ea9]

        tdf#162878 Freshes template: autosize for title
        
        With other languages than English, texts for placeholders ("Click to add
        Title") may be be much longer and overlap on other placeholders, which
        looks ugly.
        This change adds
         draw:auto-grow-height="false" draw:fit-to-size="false" style:shrink-to-fit="true"
        to titles and subtitles to avoid overlaping
        
        Slide 8: replace dummy Lorem texts with subtitle placeholders
        
        Change-Id: Id7754b9e860a30e78d2ea2a400e30a28f6e22305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173363
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a446bfd0f379a2a976cf707c85a5f3c8ed68de0c]

        Surround printed struct/exception members with {...}
        
        Change-Id: I41d661e5d89c784715e4e07a3c7f7f27737ba3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173831
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d7a608cc25f81c7c5de0edacf91b36cde2803410]

        Make an exceptin message more informative
        
        Change-Id: Icdac7a7dc2f7b5a76fbbec996bc0e05ca1450a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173834
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-24  Heiko Tietze  <tietze.heiko@gmail.com>  [91c11939b477a0542edb05c45cd735752accbb40]

        Resolves tdf#137298 - Show document info for respective fields
        
        Change-Id: I3e410fe88a6402684153d1e1d1d074c2fe65dee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173613
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-24  Heiko Tietze  <tietze.heiko@gmail.com>  [74e3f47723471f3ed4dc2dbffc95085bb04d9504]

        Resolves tdf#162979 - Avoid oversized online update options
        
        Don't wrap at every semicolon but only after 50 chars
        
        Change-Id: I91993d503c574a9c60d390afde159ade73567861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173552
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7ccfc0277a44d0a9eee943fdbb952e16df36590c]

        Best effort to print more details about caught UNO exception
        
        Change-Id: Ia8f098e4e441b6aba0d76d7184dc6cec2210f793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173813
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-23  Oliver Specht  <oliver.specht@cib.de>  [a593c27e8897280871dc310184ff568bf34a6ebe]

        tdf#162326 remove character formats and styles on style apply
        
        Removes the character attributes and character styles when a paragraph
        or a character style is applied and the Ctrl button is pressed.
        
        Change-Id: I8b2809d1a2b91e501ed8a11ac9f3aebec6c12c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173154
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [87039e3e772c7b36480e70019dea0faa15feef6b]

        use more concrete UNO types in dbaccess
        
        Change-Id: I3f689e6ec296fe0c8876ba5cc68133f28902b3fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fb48fb349d106bab8f24e042a9fbd92368b06ca]

        use more concrete UNO types in connectivity
        
        Change-Id: I313dae1589d8097d3c9f3c16ae978cdc07d54ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-23  Miklos Vajna  <vmiklos@collabora.com>  [90beea9a9a9ab1a5d4a154704acabadfc83870c9]

        cool#9992 lok doc sign: handle .uno:SignatureCert/Key/Ca view options
        
        The desktop way to sign documents is to manually import a .p12 file into
        your Firefox user profile, and then the signing key is available in all
        views. The LOK case wants per-view signing certificates, set in a way
        similar to the name of the user.
        
        Start implementing this by:
        
        1) Extending initializeForRendering() to have JSON entries for the
           signing cert/key/ca chain.
        
        2) Importing the CA chain as trusted certificates, using a new
           SfxLokHelper::extractCertificates() + test for this.
        
        3) Marking a certificate as trusted is tricky, extract
           SfxLokHelper::addCertificate() from the existing doc_addCertificate()
           to do this.
        
        4) Parsing the signing certificate, but just warn if that fails, still
           need to connect that to the SfxViewShell later.
        
        Change-Id: I00e40b3cdd68dbe8994f28861dc7b0f578189643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173806
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2be38378f1e1b939986403aa766d6783c234ef0a]

        Fix typos
        
        Change-Id: If1e5d6c8a24df6b8448fe393eb25dfe20d4b89b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173823
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84299f3da389987b1dd5c354d67c6ee5217a474c]

        Fix typo
        
        Change-Id: I9d623cde2b6132b508f8f2ced30edcf705d31963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173821
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cb874333a88e48f8cb340a934c9d0225d220fb1c]

        Fix typo
        
        Change-Id: I459945f142055186fc103a2e0e7b3f347e02c680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173822
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [64c62fb4e58bee42a5aaafdf3bdd56ae475d19bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ef934fb7ae13c5713effa050d9858629af66675
          - tdf#162607 disambiguate hid2file.js, misc
            
            + mute bookmarks that are followed by hidden paragraphs
            + remove from options
            + minor refactor
            
            Change-Id: I12da2c0a86a748244e2363fced3c69ac8b3824b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173819
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-23  Michael Weghorn  <m.weghorn@posteo.de>  [249d37a8c4ae113d4043f7bdc1213fbd1a22f3b8]

        reportdesign: Use NC_ to create a TranslateId
        
        I don't see any reason for handling `RID_STR_EXPLANATION`
        differently than all other translatable strings here.
        
        Change-Id: Ica678557124f4daf48c3759fe3640fe95a2bc8ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173810
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-23  Michael Weghorn  <m.weghorn@posteo.de>  [d12c622da8934ae7bafed8eeff897e2717d9419b]

        unotools: Use existing OUString::fromUtf8 instead of local helper
        
        `OUString::fromUtf8` already implements the logic
        that the local helper function `createFromUtf8`
        reimplements except that it doesn't allow passing
        a string length other than the length of the passed
        string.
        
        However, all callers pass the string length anyway,
        so use OUString::fromUtf8 and drop the
        local helper function.
        
        Change-Id: I7710e465d1159db0862382df5a954692dbc3cf5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173808
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8687cc4eba0478ea0432dd1290f95be61919f172]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5fb6ba7d66d194949fea559d9afced94bad04f8c
          - tdf#162607 disambiguate hid2file.js, RTL/LTR
            
            + Created files for uno:ParaRightToLeft and uno:ParaLeftToRight commands
            + Adjust embeds and links, how to get
            
            Change-Id: Ide954868ecaa513c439d4950b097aefa96ffb69a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173814
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-23  Oliver Specht  <oliver.specht@cib.de>  [1ea2bbae1aa0f0f8455039271960985292212b6a]

        tdf#163003 increment frame y position
        
        In RTF vertical position of paragraphs in frames is handled differenty
        than in docx. y position is incremented in docx. To get the same result
        in RTF import the y position needs to be incremented, too.
        Additionally the state of '\hyphcaps' needs to be imported to fix
        the formatting of the wrapped paragraph of the bugdoc tdf#152865.
        
        Change-Id: Ibb9851eb11a0e57ec7b9b1114264456d941cec24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173525
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ceb4141ec291129dfbf0c1a220c9c498bc50585]

        dont use GetItemSurrogates for gathering SvxFontItem
        
        which is very expensive these days
        
        Change-Id: I43e19c77eee024fd4875aa57d9c28d5c9e0ad465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-23  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [1acd37a671b9d3633a7d31a0b60478815fbc685f]

        CairoSDPR: Activate globally to check builds/tests
        
        This is to check all builds/tests with activated
        CairoSDPR to evtl. make needed additional changes
        as preparation to activate this in the future.
        
        adapted for testTdf139000():
        Use no AA offset (0.5) for applying mask.
        
        Adapted for testDoublePixelProcessing:
        The trick (hack) to create a PixelProcessor and then
        attact a metafile to start recording to it does no
        longer work/make sense since the VclPixelProcessor2D
        is no longer the only PiyelProcessor you might get.
        If it is a SDPR one (e.g. CairoSDPR) it *cannot*
        record metafiles - and is not intended to do so.
        Since this test was already adapted 6 years ago to
        the modernized decompose of a double line to just
        two lines anyways it is OK to now change to use
        a VclMetafileProcessor2D now initially.
        
        Adapted for CppunitTest_svgio:
        In SvgFeBlendNode::apply execute the calls for
        convertToBitmapEx without AntiAliasing to get better
        edges. Input data is SVGToken::FeFlood, so a
        rectangular area, so no AA needed.
        Taking this back: The reason must be in the renderer,
        nothing else changed. Debugged in detail through
        both, problem is that VclPixelProcessor2D ends up in
        CairoCommon::drawPolyPolygon and draws the polygon
        AntiAliased, but just the fill and thus *not* with
        the AA-offset of 0.5, that is only done for fill.
        I have to re-consider the AA offset decision for filled
        polygons. Checked CairoCommon again, indeed AA offset
        is ony done for lines, not for fill - that corresponds
        with my thoghts from the weekend. Somehow this must
        have come in with copy/paste (?). Same is already
        in D2DPixelProcessor2D, have to remove there, too.
        
        Adapted for CppunitTest_sd_png_export_tests:
        This was a hard one, debugged all the components used
        for ConvertToBitmap/MaskCreation. Cumulated to be
        some diff in processTransparencePrimitive2D, but
        found no error after checking all tranmsformations.
        The orig errof ro the failing test (tdf#158743)
        seemed to give a hint, but ObjectTransformation
        was just handled well. At the end the diff was
        that VclProcessor2D uses the same processor, while
        CairoPixelProcessor2D creates local instances
        (what is cheap). Thus the content rendering for
        TransparencePrimitive2D was *not* using the set
        BColorModifierStack. Added as needed to be able
        to transfer that to the content rendering
        instance.
        
        Adapted for CppunitTest_sd_png_export_tests:
        Gerrit says PNGExportTests.cxx:1041 asserts,
        but I cannot reproduce. Maybe at the build
        system a slightly different font is used.
        My only idea is to add the mentioned point
        at (12,120) to the rectangles, obviously the
        bottom one.
        Next one is (13,82), again bottom one,
        adapting.
        
        Adapted for CppunitTest_sw_ooxmlexport16:
        The test 'testTdf136841' uses a WMF that contains
        XOR paint parts. This showed that that part in
        CairoSDPR did not work yet as needed. Adapted
        that, also the test slightly due to the color
        result slightly changed with CairoSDPR.
        
        One last change before activating in master: Add
        DISABLE_SYSTEM_DEPENDENT_PRIMITIVE_RENDERER in
        case it urgently needs to be switched off or to
        be able to simply test if something happening is
        related to CairoSDPR
        
        Change-Id: Idb8237a05d7594efe20edfa1707ca0002185645a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173330
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bd47a75cc118a6a0e9460e6bf9cc65ff4c74b34a]

        update credits
        
        Change-Id: Ia8d537cbfca12e77bc139ab690e734a8e110214a

2024-09-23  Chris Sherlock  <chris.sherlock79@gmail.com>  [c32e874a4f13acb87966731dbc5554fc95fa8e2b]

        vcl: mask scale regression in BitmapFastScaleFilter
        
        Masks are not scaled in the fast scaling filter. The issue occured when
        migrating to the BitmapFastScaleFilter class - maSize was never set.
        The size is now calculated in execute() locally.
        
        Regression from:
        
        commit	d246aa574571409046619254292698184c2545a3
        date    Sun Apr 15 10:14:10 2018 +1000
        author	Chris Sherlock <chris.sherlock79@gmail.com>
        
        vcl: move Bitmap::ImplScaleFast() and Bitmap::ImplScaleInterpolate()
        
        Change-Id: I9cc36f609059ae2db9c4cdb169bd5110382cfb21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173766
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-23  Mike Kaganski  <mike.kaganski@collabora.com>  [8733ffc6a4e79e007ec9725a183ef04a7fbf0fb6]

        Simplify even more
        
        Change-Id: I425020cdbf140b159c5af9341de74572624d09e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173788
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-23  Marco Cecchetti  <marco.cecchetti@collabora.com>  [3b4b7edbdf35d3747e72e9614af4ea83a2b74659]

        lok: sd: slideshow: provide animations info
        
        This patch is an initial effort for collecting animations information
        and make them available in json format.
        
        Change-Id: I00470ea3b56c215c591f7e1e56227b63cf3be014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173805
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-23  Mohit Marathe  <mohitmarathe@proton.me>  [fc5983f470e5b0e54a75da3285a2c2ec64f7af79]

        tdf#162999 Fix comments sidebar resizing issue
        
        Earlier it was not possible to resize the comments sidebar due to
        no text wrapping for author's name. This patch fixes allowing text
        wrapping for author's name, comment and truncates the commentedtext
        label.
        
        Change-Id: I7a7c2a72c44b1c5e4bcf3b02096425d26d3c0d6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173755
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08964038e1432bcda91de1a7e5454ab4e8b114a8]

        cid#1607989 Overflowed constant
        
        and
        
        cid#1607976 Overflowed constant
        cid#1607855 Overflowed constant
        cid#1607731 Overflowed constant
        
        Change-Id: I18e8ffb8a9b5a55e0ecb71862549a94ff5c2fc1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173781
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dcde476695d287d836e74a1cb5cc42379aa6a469]

        SfxStyleSheetBase::GetHelpId return sal_uInt32
        
        Change-Id: I52c5ed939fd4cf26bf9f94651681650047f90030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173780
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1db66dbdc0336c7de5916a14cbbc0d6a8be50f30]

        cid#1606721 PA: Public Attribute
        
        Change-Id: I2d5c28e7fb220426b5a7c4881e35a4d269322883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173778
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-23  Miklos Vajna  <vmiklos@collabora.com>  [92b811e50b024ecbdf1132e77b91c9eb4981e203]

        svx: prefix members of SdrPolyEditView
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib50e86f1ec207de37074f953eb062c2c46c3a2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173784
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-23  Mike Kaganski  <mike.kaganski@collabora.com>  [da75e4750ec0d85aff72d9b7bf47289915488ab2]

        Simplify a bit
        
        Change-Id: I7d889137af443139e9a411a57c9bbaeb1af72ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173787
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-23  Arnaud VERSINI  <arnaud.versini@pm.me>  [af9b429a138e9cd6403fd8e399080c2913cde739]

        vcl builder : no need to use OUString here
        
        Change-Id: I82219272ae06db45968f2aecf2583c0b7196e3b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173768
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-23  Mike Kaganski  <mike.kaganski@collabora.com>  [6e626657d971bf276fa1afb852e9ea86b9fff5b0]

        Use OUString here, to avoid allocations
        
        Change-Id: I7e1ba222c7a8fa48071123baf2b9a49c8d19da35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173773
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-23  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [e610847df369f02681603e34092fe7d39b749729]

        tdf#163086 Resize SVG pin icons to 24x24 and clean them up
        
        This also reverts commit 13a42d5c2d433da6c2c69159bfc6df0e37643333 which
        worked around the issue of oversized SVGs.
        
        Sukapura Dark's pin_document.svg was already 24x24, gets a cleanup anyway.
        
        Editing the SVG source, I changed the 64 (and in one case 512) to 24.
        
        Then, I opened each one in Inkscape, clicked the lock icon for width and height,
        input /2.6667 (or 21,3333 in case the viewbox used to be 512) to the end of the
        existing width and hit Enter to apply. Then in Object - Align and Distribute
        panel, I set Relative to: Page and centered on vertical and horizontal axes.
        
        Finally, I used svgcleaner to clean out all the useless crap in the source.
        
        Change-Id: Ic42bd5fce3227f008fe98eed304b1d565cf13651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173774
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-23  Mohit Marathe  <mohitmarathe@proton.me>  [854d4e6e6a98688118a71357ba1171218f6e64f3]

        tdf#163040 Fix comment panel showing only latest comment
        
        Change-Id: I5e0c454a371691ba17866006cb5763ec6d7f9058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173769
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a48511a90ccbb1c04c97e278490c4fb713b60254]

        cid#1607483 PA: Public Attribute
        
        Change-Id: Ib31c45ffb51db8ec7b3a8c8809b212515cee0437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173777
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [77e1eadff7a221d0c26cf1021d3a896a9c6ccfe4]

        cid#1608290 PA: Public Attribute
        
        Change-Id: Id4afe36a78851205d79850800407966387cc43fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fdb4575214d0232be2d16b140d7c761b61ac4eb8]

        cid#1607710 silence Overflowed constant
        
        and
        
        cid#1607916 Overflowed constant
        
        Change-Id: I54d59d9b4afbc3af2039b049a6e23111861204db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [52b3b38f1448d2468a3e9edec758515151dc067b]

        Adapt to RPM 4.20
        
        ...which builds the spec file's code in a dedicated directory now, see
        <https://github.com/rpm-software-management/rpm/issues/2078> "RFE: introduce an
        rpm-controlled per-build directory to builds", and no longer in the directory
        from which rpm is invoked.  So invent some libo_start_dir parameter to
        communicate that directory into the rpm build.
        
        Change-Id: I28268837caafe3b892f76e936dfa747fe13fb9bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173779
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-22  Noel Grandin  <noelgrandin@gmail.com>  [3194b9b42eda967dc57c2d244fb7b800a98c09d2]

        remove some dead code in DrawDeviceBitmapEx
        
        ever since we added the call to DrawDeviceAlphaBitmap
        
        Change-Id: Ia329e355839ffc27c88135513898e7ea460242fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173772
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4605d36e7ee5ebe4776ab4bc78b255ac5f33c3ab]

        cid#1607080 Overflowed constant
        
        this doesn't make any sense to me with:
        
        m_xEditEngine->GetText(nParaCount - 1)
        
        before a check against non-0 nParaCount
        
        int nPara = nParaCount ? nParaCount - 1 : 0;
        
        surely GetText(nParaCount - 1) can at best
        return an empty string
        
        like this since:
        
        commit c9596fa3c6e7137ad9c4f8cdaa69c625d37e7bc6
        CommitDate: Mon Mar 7 16:35:17 2005 +0000
        
            INTEGRATION: CWS os49 (1.4.84); FILE MERGED
        
        Change-Id: I6c605f27fee0b8c9f58a0e2bc7bc975a2efd1f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173750
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [490e64cdc890c5998d54d4ad3c3ac85e7e8e3bee]

        cid#1607175 Overflowed constant
        
        and
        
        cid#1606656 Overflowed constant
        
        Change-Id: I278d3745ca5d22defde8ab268e644e9ee312a3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-22  Patrick Luby  <guibmacdev@gmail.com>  [13a42d5c2d433da6c2c69159bfc6df0e37643333]

        tdf#163086 downscale excessively large pinned document icons
        
        For some unknown reason to me, some of the SVG icon sets have their
        pinned document icons set to a viewport of 64x64. So downscale such
        icons to more closely match the size of the pinned document icons
        in the PNG icon sets.
        
        Change-Id: Ic7e51ff194968e09d13a5bff341ccbbf80cfb26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173765
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-09-22  Mohit Marathe  <mohitmarathe@proton.me>  [ac38f7d53755459a6fdc4cc9064b93e07501fe56]

        sw: fix comment sidebar crash in generic backend
        
        Change-Id: Ie16d7bc61ebeeb7da2b31926d1ef0046d993e1f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173759
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-22  Julien Nabet  <serval2412@yahoo.fr>  [c69fbc94827ddb8788e27204a2e8597de9f13ac3]

        tdf#163084: add Histogram chart in sidebar
        
        Change-Id: I7f5d2f22c340d4f04b6c04fac04079ae2a29b32c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173767
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f6cd97220fca3d00647a5a1641f2e3f8b9f3533]

        cid#1607193 silence Overflowed constant
        
        Change-Id: If3728d8b5410c26637411335ac2bb28a29a55fc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173749
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08db0792562f23be138c56e347a6c3121ad1512c]

        cid#1607013 silence Overflowed return value
        
        and
        
        cid#1607569 Overflowed return value
        
        Change-Id: Ie83b1e4c9942e5d74b23c5ef00032d0a8721d982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173742
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e2bf07ea2553acf204f94c90bb4f547b15b12861]

        cid#1607126 silence Overflowed constant
        
        and
        
        cid#1607075 Overflowed constant
        cid#1606969 Overflowed constant
        cid#1606652 Overflowed constant
        
        Change-Id: I7f7ee294438b73785b4005eb529bda98fdddfc97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-21  Mike Kaganski  <mike.kaganski@collabora.com>  [275aebc5085cd4b0fd3d045ef1ec65c99e1d5b56]

        tdf#163064: pic element is required here, after all
        
        In commit cf15306ccf49da290b391517e2c5dd22a4f1be45 (ERROR: Invalid
        content was found starting with element 'p:pic'., 2014-12-22), the
        pic element inside the oleObj element was only alloswed for the old
        revision of ECMA-736 export, because that was considered invalid by
        officeotron. However, as of ECMA-376-1:2016,  this element is
        mandatory; CT_OleObject definition in Annex A has:
        
         <xsd:element name="pic" type="CT_Picture" minOccurs="1" maxOccurs="1"/>
        
        and Annex L (Primer) has L.7.2.5 "Embeddings in a PresentationML
        Document" saying:
        
         The oleObj element shall have a pic child element that (optionally)
         contains the image data to be used in place of loading the actual
         object data.
        
        The omission of this in the export is the reason of tdf#163064. So
        here I filter out the error from the validation results, which is
        not ideal (I have no way to know if the found pic is really in the
        oleObj, or somewhere else), but a lesser evil, compared to required
        exclusion of all tests that export OLE objects.
        
        Change-Id: Ia73a49da7347e8ff22c626e211b55ba1e0625070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173761
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [03467e12660a61c467e4947681e827435c3beaea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9426607bb843538b580738195af7316b5683623c
          - tdf#162607 disambiguate hid2file.js, DrawGraphicMenu
            
            + This uno:DrawGraphicMenu does not exist (anymore)
            + drop duplicate page in scalc/01 folder
            + adjust format_object.xhp for Writer and Calc
            
            Change-Id: I45b58ca078115a564e06a3b02bd93c0f50dc1e26
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173764
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0920dbd3d915f362ddca86891ef75a07af96d204]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37daca381f38f17887b57789d021cd3820533487
          - tdf#162607 disambiguate hid2file.js, SelectAll
            
            Change-Id: I8f8d8ed584af930a8a6fd88962a64b813ad1aecf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173762
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7549a402ddc75bd5b8e3a3a2e3aa98d5be85b36]

        no need for a template here
        
        it is instantiated only once
        
        Change-Id: I0545219a390eb382bcffd3b1a551245f54c47f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [370cb9f2e0be392c6798442e0ddfe4ecdea4317f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 198614b76c835e3fedf4918510a8c310832a3d77
          - tdf#162607 disambiguate hid2file.js, ShowGraphics
            
            Change-Id: I735dc52ff1838f3a51e99b95df4eb88c6f17a8e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173760
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf133dd95e774e67a4ff4bc2394babdcc3d1879e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 29e946d0b946aeafb4ab98a96924184db149c110
          - tdf#162607 disambiguate hid2file.js, Style menu
            
            Change-Id: If76719ba4d12902b0420895ca8a592d674fc3d86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173758
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-21  Mike Kaganski  <mike.kaganski@collabora.com>  [7749f931389ada7f25e3c1d52c1a760ec41a3019]

        Make replacement graphic management more atomic
        
        Commit 8872f7121b4ae4dd0b51820366d3510a88f7aac2 (crashtesting: crash
        on exporting kde274105-6.docx to .rtf, 2024-03-27) added some safety
        code in EmbeddedObjectRef::GetReplacement. It mentioned, that there
        are likely some bugs in the management of the graphic.
        
        This tries to fix this management, avoiding the intermediate states,
        and only changing the graphic when all the data is ready. This also
        reverts the changes of the mentioned commit, obsoleted now; and of
        commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4 (svtools: fix lost
        replacement grpahic when updating it via OLE fails, 2018-10-30);
        but keeps commit 24231f2a336c50eac5e6a1621c57e60ebe1e1cf4 (svtools:
        fix lost replacement non-rendered graphic when updating it fails,
        2022-02-17).
        
        This has revealed that the second part of unit test for tdf#143222
        ("Check export of embedded worksheet in slide"), introduced in
        commit 92a407b7f90a98704a238c5ffa3a3491eaf3263a (tdf143222 Handle
        alternate content of graphicData element., 2021-07-08), has never
        really worked: the "pGraphic != nullptr" check would never fail;
        in fact, that used to always return an empty graphic. The problem
        was filed as tdf#163064, and the test was modified accordingly.
        
        Commit 5d997c029e53c31a3651a08f5012645097cec48f (sw XHTML export:
        improve dummy OLE object handling, 2018-08-30) made ReqIF export
        handle missing replacement graphic. However, it had assumed that
        SwOLENode::GetGraphic always returns a valid pointer even for the
        missing data. That is fixed here in OutHTML_FrameFormatOLENodeGrf.
        
        Other places, where the pointer was dereferenced unconditionally,
        were fixed (keeping current behavior).
        
        Change-Id: Ica97a691ecc11b856bdb003f89467ea3392684bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173716
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [95dddf884f0be111db3c244c7f65bc3fc699bcb6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 580c4b56bec3947b7338a376f2e81ed5405f4979
          - tdf#162607 disambiguate hid2file.js, ZoomOptimal
            
            + adjust terminology: Math uses "Show All" for optimal view
            + drop unused how-to-get
            + adjust ZoomOptimal how-to-get
            + adjust menus pages
            + drop redundant smath/01/03060000.xhp, merged in shared/01/ZoomOptimal
            + refactor
            
            Change-Id: If2f2f63e1f129de1ea9728b103346e437e1649bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173757
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-21  Noel Grandin  <noelgrandin@gmail.com>  [809808f56bc79c229ca7ce84eb03274271ff1044]

        dont use GetItemSurrogates for gathering SvXMLAttrContainerItem
        
        which is very expensive these days
        
        Change-Id: I1880ae272e422baca7b0540f58c9e8f9c3bb1287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d8607221d42818f6168dc094f2ad28c4c4145497]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d33037d906bfd3ceea8ae13e8f35d82cb323d9c
          - tdf#162607 disambiguate hid2file.js, Page/Column
            
            + drop uno.ColumnMenu from sdraw (bad bookmark)
            + drop page_properties of sdraw (singleton, not used)
            + drop unused how-to-get
            + fix heading of Page Properties
            + refactor
            
            Change-Id: Ied4e0e62d0de2d64411b474a7b011a9e0a597342
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173756
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4472dc48faf320dba758b6d816c06bd760dda721]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9dba486fe729d68268585c3962b1b4159723945d
          - Fix some "D'oh! you found a bug"
            
            Change-Id: I3f842ab100595ba9aa55092ada078fc2c19b5fe5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173754
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [77bfa8885aba015d546b308e88312960060a218f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a7cb494bd4f72fbf38c539babd018b593082f70
          - tdf#162607 disambiguate hid2file.js, DuplicatePage
            
            + merged the two pages for the same UNO command
            + fix menus
            + drop unused menus
            
            Change-Id: I88bcc94101ec6e09c64ecbaae7d82586d09cf6f0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173752
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-21  Laurent Balland  <laurent.balland@mailo.fr>  [5b907b2ccaa62a62ec343f62acea4a5e76bee164]

        tdf#162878 GrowingLiberty template: autosize for title
        
        With other languages than English, texts for placeholders ("Click to add
        Title") may be be much longer and overlap on other placeholders, which
        looks ugly.
        This change adds
         draw:auto-grow-height="false" draw:fit-to-size="false" style:shrink-to-fit="true"
        to titles and subtitles to avoid overlaping
        
        + slide 5: replace Lorem dummy texts by subtitle placeholders
        
        Change-Id: I751b5b6ce2de536eb9fd0dff836c9dc4b9cf91b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173367
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [3624a60fff9570815d64ceb03cccc01a01f892ab]

        sfx2: move rdf java test to CppUnittest
        
        Change-Id: Id66b752fdcf23546416b3b7f99e2f61756c3a76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173664
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [281a006bbabc9c2c67820c25d08fb69844db5fad]

        tdf#130857 VclBuilder: Extract helpers to insert combo/list box items
        
        Extract code to insert items into the VCL implementations
        ComboBox and ListBox from VclBuilder::handleObject into a
        new helper method VclBuilder::insertComboBoxOrListBoxItems.
        
        This is in preparation of being able to make `handleObject`
        reusable for an upcoming QtBuilder, s. WIP Gerrit change [1]
        (which still duplicates `handleObject` in current patch set 28).
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: Ic6d014e6c9886c34a889b70bbf06a979664daba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173736
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [fd67141bbfd7a9167f5a7f49441adb41d117e8b3]

        tdf#130857 VclBuilder: Extract helpers to set prio/EnumContext
        
        Move setting these in a vcl::Window specific way
        from `BuilderBase::handleObject` to separate helper
        methods.
        
        Change-Id: I2df05e298dc9d2ef5af7b67104ce0b904cce4d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173735
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [46467794b73050fe4f87ac715c993b9dc2ad6269]

        tdf#130857 VclBuilder: Avoid using vcl WindowType to detect toolbar
        
        Instead of checking that the type of the vcl::Window
        is WindowType::TOOLBOX, rely on the class name of the
        current item to be one of the toolbar item classes
        in `VclBuilder::handleObject` and instead double-check
        and make the code in `VclBuilder::applyAtkProperties`
        conditional on this actually being a `ToolBox` instead
        of asserting.
        
        (Not sure whether there's a valid case for using toolbar
        items outside of toolbars, but avoid potential regressions
        here if that's used anywhere.)
        
        This gets rid of one vcl::Window specific way of handling
        things in `VclBuilder::handleObject`, which is one step
        for preparing it for reuse by other builders in the future
        in particular QtBuilder from pending WIP Gerrit change [1].
        
        In a quick test, the accessible name of
        "Show Up to Outline Level" is still properly set
        for the corresponding toolbar item in the navigator only
        and not for the toolbar, see
        
            commit ad1167b92b8b8fdabf6b21e945682c0bafc80946
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 27 13:12:43 2024 +0100
        
                tdf#159910 a11y VclBuilder: Apply tool item's a11y name to itself
        
        for background.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I8a7dbbee9b88bcb7c0cd6bc862d2c5cc4a290af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173734
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [a055c9a8b5441e578defe2763a504ed2329a4257]

        tdf#130857 VclBuilder: Move handleActionWidget to base class
        
        Move the `handleActionWidget` Method from `VclBuilder` to
        it base class, `BuilderBase` and make `set_response` that
        gets called by `handleActionWidget` a purely virtual
        method in the base class.
        
        The existing `VclBuilder::set_response` that now overrides
        the base class one implements the `vcl::Window`-specific
        handling for it.
        
        Change-Id: I7664fc77dc98ab0edca1aa7e6982f28822b7caef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173733
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [b1c2d718af1c6fe9a3e7c2467ae15b049547d59a]

        tdf#130857 VclBuilder: Move "packing" parsing to base class
        
        With previous commit
        
            Change-Id: If29cbd7a13da2732c46e4a0b0b50d0963525e729
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Sep 20 12:21:05 2024 +0200
        
                tdf#130857 Refactor VclBuilder::handlePacking/applyPackingProperties
        
        having split the XML parsing logic for the "packing"
        property from applying it to vcl::Window, slightly
        refactor further to have the XML parsing logic in the
        new base class method `BuilderBase::collectPackingProperties`
        that doesn't take any vcl::Window param, and call
        `VclBuilder::applyPackingProperties` from
        `VclBuilder::handleChild` instead.
        
        Change-Id: I5a52fa85cc8c68a9f7c5c2da1c8d392e031d4fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173715
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [73dbd4229b6a73a62ccb2923102d3eede9595ec7]

        tdf#130857 Refactor VclBuilder::handlePacking/applyPackingProperties
        
        Instead of doing XML parsing in
        `VclBuilder::applyPackingProperty`, call
        `BuilderBase::collectProperty` in
        `VclBuilder::handlePacking` to get a string map
        of the properties and pass that as a param
        to the renamed `VclBuilder::applyPackingProperties`
        that can then work with the key-value pairs right
        away.
        
        This is one step to split XML parsing out of methods
        that directly work with vcl::Window, in order to
        be able to reuse the logic for other implementations.
        
        (`git show --ignore-space-change` shows the
        "actual" change more clearly.)
        
        Change-Id: If29cbd7a13da2732c46e4a0b0b50d0963525e729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173714
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [f6ab08f6f463975d6651dc3296ec04c67b9151fd]

        tdf#130857 VclBuilder: Reduce var scope
        
        Change-Id: I20e48e308b2c25c3b328cc7c30271a05479da22b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173713
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [0d3433d74f1e9f1e6b3fc8b110c3892186d4aa71]

        tdf#130857 VclBuilder: Use existing toBool helper
        
        Don't duplicate the logic here.
        
        Change-Id: I83f1b964c74f097563d8d1c33a2fce7d9fe7f7f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173712
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [b6049f4758b76a2d1c704725b4c06a5f42ce8e7e]

        tdf#130857 VclBuilder: Use OUString instead of OString
        
        Use OUString here as well, and drop the now
        unused toBool variant taking a `std::string_view`
        instead of a `std::u16_string_view`.
        
        Change-Id: I8879b4dcf170db4911fd0f0a2759cbb8c067f4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173711
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [bcfe1de41e8f707a1911ff9cb68ef3b606c625f7]

        vcl: Move UTF-16 toBool helper to it's local non-UTF16 equivalent
        
        include/vcl/builder.hxx declares a
        
            VCL_DLLPUBLIC bool toBool(std::u16string_view rValue);
        
        (taking a UTF-16 `std::u16string_view`) and
        vcl/source/window/builder.cxx defines a local helper
        function
        
            static bool toBool(std::string_view rValue)
        
        (taking a non-UTF16 `std::string_view`), while the
        function declared in builder.hxx was actually
        implemented in vcl/source/window/layout.cxx.
        
        Then, vcl/source/window/builder.cxx makes
        use of both functions, which was quite
        confusing.
        
        Move the definition of the function declared
        in the builder.hxx to builder.cxx as well.
        
        Change-Id: Ib1f3e3c92c4d3df56c83437e5078ddfe1f887c96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173710
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [98f2f49b5ac098ee0b7e33a7c8282e687d22d730]

        Use '#pragma once' in include/vcl/builder.hxx
        
        Change-Id: I7651640bc01cd216a930bdd8b4490ea0f43f5bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173709
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [c6c5f088549c654f44ba0feffbf82e4fd2425bce]

        tdf#130857 qt weld: Drop accidently added empty files
        
        I accidently left them as empty files and committed
        them when extracting a separate commit
        
            commit 9b3a2996e710fee11145dcbbe38a6f1e6f646ec8
            Author: OmkarAcharekar <omkaracharekar12@gmail.com>
            Date:   Wed Sep 18 09:35:09 2024 +0200
        
                tdf#130857 qt weld: Add QtInstanceBuilder skeleton
        
        based on a part of the pending WIP Gerrit change [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: Ic7e13e4a24ec064a658283ccd43d0e9f656a21fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173708
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [7bdbce0fd80a9a4ed29e92f80c7020323d638e06]

        tdf#130857 vcl: Move BuilderBase to an own header
        
        Change-Id: If959579996764888b791a32d711dcc828d9771db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173707
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-21  Marc Mondesir  <timepilot3000@gmail.com>  [44ed3d5e009ba9819bfebb4032022ea33d2622ba]

        tdf#143148 Use pragma once in animationnodehelper.hxx
        
        Change-Id: Ic9ecff62285292c45af5b6965b10686bf36b68bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173688
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [5b54f68599d9a9b6f4d21fd8c0cdac746ea71ecb]

        vcl: migrate BitmapArithmeticBlendFilter to use BitmapFilter class
        
        Change-Id: I524b8c87747b79a8698cce4bd092493ffc9c1235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173350
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [6d159f4dcf170644b98a01727d740406c7849fab]

        lok: sd: slideshow render: some bug fixes
        
        The suggested canvas size need to be passed to createSlideRenderer.
        masterPageObjectsVisible -> masterPageObjectsVisibility as on client.
        Last json message should be reset on each call to renderNextLayer.
        In order to avoid to send empty layer check if the json message has
        been set.
        After rendering the background layer we need to return or the layer
        is never received.
        
        Change-Id: I9a83895d4f3895f3363c1b6a86fac9bd22c9fe87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173728
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3b4ecb07a6f0295441317ab889796034506bc8af]

        Invent --with-extra-cc/cxx-flags
        
        Change-Id: I22ce959f1fe74b8eb1fa0d0fbffe8b257e7f3110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173731
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [944fbe89fd48fa7814c0b33ef22910e8221da9de]

        tdf#161562 Sluggish scrolling after saving and changing text color
        
        This reverts
        commit eb13c889c760cfe153d5b41188e218bdda797d52.
        "Speed up scrolling through large document with lots of patterns"
        
        Which seems (according to buovjaga testing) to be a pessimisation now.
        
        I can't reproduce this either way, so lets just revert it for now.
        
        Change-Id: I6b7f95173eb875d215f1192b3a7ca44014c50886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f65b2049428cda9b65199efdac46577926b1efe7]

        no need to do UNO_QUERY here
        
        Change-Id: I52d13a7e4806d8fc34c4ff6f4cc5ab1e785a8b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3de3f660af5afad6f4a78cc021ed20dada936bbd]

        add a --with-system-java-websocket
        
        there was a system Java-WebSocket in Fedora 35, f.e. but unaware
        if this is actively packaged standalone in contemporary distros,
        but useful for the coverity build case.
        
        Change-Id: Id6393dbfb1c449b75391752a8bb5e5ea4481a084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173725
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [74774c101eab155106b176a1f77a3131a4fc3ac9]

        cid#1606721 PA: Public Attribute
        
        Change-Id: I7f67264abf3ab6e52fe74c3e0bbac86a363b45c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173724
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0f7619735ede9bbed904309c119cccdc5aee040]

        cid#1606722 PA: Public Attribute
        
        Change-Id: Ideb3c4523dc6210f56c978fdab52690a54b88d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173723
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad9d635bffc4afa32250583dc28b053aaab91501]

        cid#1607041 PA: Public Attribute
        
        Change-Id: I3e162e3b58f750b92c5939f3866fdcb8a148de99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173722
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e65acc30dbaef1f21796eaf4d42e2568bb7b0b15]

        cid#1607131 PA: Public Attribute
        
        Change-Id: Ief73e86c6fa4459e25d98befa0dc383326f22a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b642c711e3c60651a189073e594acc26e0d381d]

        cid#1607206 PA: Public Attribute
        
        Change-Id: I27a8247f0674c90ea16f896c1aba465aeeaa9992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6cbd95b560016d7e55c42bec622f06e22b6d4ac6]

        cid#1607639 PA: Public Attribute
        
        Change-Id: Ie7a2e95cb46c0472692e91c57f0bbf4714a4a1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173719
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45eb7e7cf2e29fed5e5bdce7197871cd115e1cb6]

        cid#1608090 PA: Public Attribute
        
        Change-Id: I9bd34262523a7eaa430824749adee6f3e326c59e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173718
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c9ce398635c7712d493a1d7112b7afdb442fb2d7]

        cid#1608290 PA: Public Attribute
        
        Change-Id: Ifb9bedaaaf152c6c43454811b63bdf55a157cf2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173717
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4506cd04c78baf628c8c6fd7e9c5f27a407d8f87]

        tdf#162431 - Check for missing parameters
        
        Don't silently convert missing parameters including their error code to the request target typen when the target type can't handle the conversion.
        
        Change-Id: I2300aa594ae3cc1045a6397c1195718b6662aa61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172593
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-09-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f231ca7a43c7ac6d31973eb45168f2dd87f694bd]

        GCC_HOME no longer needs to be SUBST'ed
        
        ...since 411e8c24a289649797c679afc084113f7f61667a "vscode: make it work better
        when srcdir=buildir and add mac lldb config" removed its use in
        .vscode/vs-code-template.code-workspace.in
        
        Change-Id: I7454f5d4443eedbb8ca143eb3e140cd0a0d708f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173694
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [2469e69af85bb5fa03f38f85801f4cdda29e5f54]

        Make sure to have a graphic here
        
        Commit 8872f7121b4ae4dd0b51820366d3510a88f7aac2 (crashtesting: crash
        on exporting kde274105-6.docx to .rtf, 2024-03-27) made sure to provide
        a graphic in all cases, to avoid crashes revealed by crashtesting.
        In commit f317746f55044927a180657f81e21d662102b0c5, I removed that.
        This reinstates the safety measure for cases when there's no graphic
        yet.
        
        Change-Id: Ida3eecd5c7ccff087c2ca8b6076ca01b8a145adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173697
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [66cf2087187651c10293472ae139c366f38cb1a3]

        use more concrete UNO types in various
        
        Change-Id: Ia28cffdeae8ced2e19dcf695ee5c3417d4f97d64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7f83d301f81431d0d0627c58367c9380d3b5713f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8487420fa9d824abcd4482cf988ccc0ed945aca6
          - name= attribute is not supported in HTML5 for <a>
            
            Change-Id: Ic2fd82900811f86c9e06f46afa547466e2831538
            ref: https://www.w3schools.com/tags/tag_a.asp
            ref: https://www.w3schools.com/jsref/dom_obj_anchor.asp
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173678
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-20  Jonathan Clark  <jonathan@libreoffice.org>  [2b030ded43f440a898733290af087d4aeed53368]

        tdf#85435 sw: No longer clear AddExtLeading for doc files with grid
        
        This change removes a problematic workaround from the doc importer,
        which was clearing the AddExtLeading compatibility flag for any doc file
        containing a document grid.
        
        The original intention for this workaround was to fix tdf#129808. At
        some point, the workaround was disabled by inverting the value assigned
        to the compatibility flag. Unfortunately, either way causes unfortunate
        side effects.
        
        Since tdf#129808 is now fixed elsewhere, this workaround no longer
        serves any apparent purpose.
        
        Change-Id: Ice46f1473916b072e183010f8888f6be62761bb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173695
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [92067587039473db38b139ecb56a3c64544e975b]

        Correct usage of premultiply for ENABLE_WASM_STRIP_PREMULTIPLY
        
        The order of parameters for vcl::bitmap::premultiply and
        vcl::bitmap::unpremultiply was wrong because when doing
        that I just used the same order that the indexing that was
        to be replaced used it. Corrected that.
        
        Change-Id: I59473acca8afdc58105b3381d1fdcedd6c0fd83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173683
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-20  Michael Stahl  <michael.stahl@allotropia.de>  [5725374d6286653fbcdd50ec4999606e4932824d]

        i#94666 sw: layout: fix problem with WIDOW_MAGIC in sections
        
        This was already fixed in CWS sw301bf03 with commit
        5559afee02fc2be18cded35a17a03aa8191b08f5 but then broken again, perhaps
        by commit f2e3655255db4032738849cd4b77ce67a6e2c984 "Avoid
        -fsanitize=signed-integer-overflow", which changed a magic constant,
        effectively disabling the fix.
        
        The problem (in a different document than attached at the bug) is that
        the first text frame 128 in a section frame 258 gets its height set to
        WIDOW_MAGIC in CalcPreps(), which grows the section frame to the maximum
        allowed by its upper, and then when the real size of the text frame is
        set it shrinks the section frame to be far too small, so the last text
        frames and the whole table remain formatted at a position on the page
        but are not painted because the paint is cut off at the (wrong) bottom
        of the section frame.
        
        (On master, the problem with the internal document cannot be reproduced
        due to some other change which causes the text frame at the cut-off
        position to have mbFramePrintAreaValid=false which causes it to MoveFwd
        and that calls SwSectionFrame::SimpleFormat() which fixes the height,
        but that all looks accidental.)
        
        Change-Id: If13d993a0cab5701f45223a70b2c5c8b0690ebeb
        (cherry picked from commit d77d3af9e4983edd7cd1cac5faecd8253db1a6ee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173672
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-20  Jonathan Clark  <jonathan@libreoffice.org>  [2155684c819dcdc52968c59276046fb0cad83561]

        tdf#129808 sw: Use ext leading for text grid spacing on DOC import
        
        This change adds a Writer compatibility flag, MS_WORD_COMP_GRID_METRICS.
        When set, Writer will always use the font's external leading when
        calculating line height for text grid, even if ADD_EXT_LEADING is unset.
        
        This change also automatically sets the MS_WORD_COMP_GRID_METRICS
        compatibility flag when importing DOC and DOCX files.
        
        Change-Id: I63a94d7d20354163f1f97745a38e286686d6a4a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173693
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-20  Miklos Vajna  <vmiklos@collabora.com>  [7bad76c3a5b319f8ede74be8f78e5645f9ffd050]

        cool#9992 lok doc sign: extract duplicated code to SfxLokHelper
        
        I want to improve extractCertificate() so it can work on a certificate
        chain, but that's easier when this code is not directly in desktop/, but
        at some lower level.
        
        This allows covering the code with tests from CppunitTest_sfx2_view in a
        follow-up change.
        
        If this code will be needed by some non-LOK area as well, then it can be
        moved down further, but let's wait for a second area first.
        
        Change-Id: I6291da0c3e56aed7dca1a8dc1446209044cace92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173691
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [f317746f55044927a180657f81e21d662102b0c5]

        Avoid wrong "no replacement graphic" state when updating OLE graphic
        
        Connecting from an external Java process on Windows, and running a
        code similar to this:
        
         XComponent xComponent = xComponentLoader.loadComponentFromURL(url, "_default", FrameSearchFlag.ALL, args);
         XTextEmbeddedObjectsSupplier textEmbeddedObjectSupplier = cast(XTextEmbeddedObjectsSupplier.class, xComponent);
         XIndexAccess embeddedObjectsAccess = cast(XIndexAccess.class, textEmbeddedObjectSupplier.getEmbeddedObjects());
         XEmbeddedObjectSupplier2 embeddedObjectSupplier = cast(XEmbeddedObjectSupplier2.class, embeddedObjectsAccess.getByIndex(0));
         for (int i = 0; i < 100; i++)
         {
           XGraphic replacementGraphic = embeddedObjectSupplier.getReplacementGraphic();
           String graphicStatus = replacementGraphic == null ? "missing" : "present";
           System.out.println("The replacement graphic is: " + graphicStatus);
         }
        
        (when 'url' points to a file with OLE) could produce output like this:
        
         The replacement graphic is: present
         The replacement graphic is: present
         The replacement graphic is: missing
         ... 94 more copies of "missing"
         The replacement graphic is: missing
         The replacement graphic is: present
         The replacement graphic is: present
        
        i.e., the replacement graphic suddenly disappears, and then re-appears.
        This happens when some idle needs to update the replacement graphic,
        e.g. when generating a thumbnail. This happened because the code in
        EmbeddedObjectRef::GetReplacement cleared the graphic prior to calls
        to OLE object's async methods to get the graphic stream.
        
        The code does not depend on the current content of mpImpl->oGraphic,
        so this change takes care to avoid this transient "no graphic" state.
        
        Change-Id: Ia825185a6e9b749697209443ee5db187b5ddbd16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173690
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-20  Laurent Balland  <laurent.balland@mailo.fr>  [8722639f3a270e2903810b85ef40a68cb0a14646]

        tdf#156047 Avoid white title on Vivid and BlueCurve
        
        When pasting a title on slide with a white title on a white background,
        user may think that paste failed.
        This change modify font colors to let pasted text visible
        
        Change-Id: I72c82850c4ecca47e54b5de1044b0c7806a443a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173361
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9a21ce2aa66009583839e3629bafabcda53ca6a4]

        lok: add media (video) info to the presentation info JSON
        
        Change-Id: Iba8f58d48cbe252b12f10ba20f9f5e2b10029c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173658
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-20  Noel Grandin  <noelgrandin@gmail.com>  [01ab23b13297c9d7b091dfbe2850cd343fcd3e0e]

        dont use GetItemSurrogates for gathering SvxTabStopItem
        
        which is very expensive these days
        
        Change-Id: Iae80c9d677fd1db8606a6a3f9462fe16b110a540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173682
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-20  Noel Grandin  <noelgrandin@gmail.com>  [1442dc4ee12251eed04e51eb324a34dc4b7973c3]

        dont use GetItemSurrogates for gathering SvXMLAttrContainerItem
        
        which is very expensive these days
        
        Change-Id: Idf133fc0532f12d297c0f44a3aad48b6eaa2206a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173680
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [f0baab027df46d4e74b7808ff5d976b8efb1ea33]

        tdf#152298: Handle "keep with next, allow split, span some rows" case
        
        All the rows on the table in bugdoc require to be kept with next
        (their first cells' first paragraphs have that flag). The layout
        finds the table break position after row 39;  but then it checks
        that that row should be kept with row 38,  that with row 37, and
        so on.  The layout loop happens because the search for the break
        position can't find a row.
        
        But cell A38 spans over four rows;  in this case, Word checks if
        this row can split, and splits the spanning cells, apparently as
        keeping "part" of the row with next.
        
        This change implements that algorithm.
        
        Change-Id: I234694138ac6b660781ad773cef20151daf874eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173675
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [afb6671d669120f213da0aa9f3973a02905a4088]

        Check if split is forced when calculating fixed-height row's min height
        
        Change-Id: Ib5780d229041823e9aa7ba1c086655eb7c8590eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173601
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [b9e439874477f40732b9687cae99a3d9d0770db8]

        When split is forbidden, avoid useless calculations
        
        Change-Id: Ibfc8b839d4455c21293906f7e4625a09b0d3f4f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173600
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [bfefb2bebd71fc63026b92b23555ce57e4feb536]

        Re-calculate the available space before calling lcl_RecalcSplitLine
        
        Because we could change the split row several times after first
        remaining space calculation, thus obsoleting the old value.
        
        Change-Id: Ia8027b0df2b04089c31b7031ddb05bd33e6ade98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173674
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [223a51801f0b75ae5036a8bcecc6eb81d99b113e]

        Optimize rows height calculation a bit
        
        Instead of adding heights in a loop, just get the distance between
        the top of the first row and the bottom of the last.
        
        Change-Id: I2082026c1c525f8230393ee8b59d1019f321fae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173596
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c1020d1ebb95615b68ffda0adf936f38fb2a06af]

        Related: tdf#152298 Consider bottom margin in remaining space calculation
        
        The value passed to lcl_RecalcSplitLine could be too large; then
        the call to rTab.Shrink succeeds, and the height of rTab changes
        as requested;  but then the values of  nDistanceToUpperPrtBottom
        and nDistanceToFootnoteBodyPrtBottom are negative,  resulting in
        failed split and layout loop.
        
        Change-Id: I797baee701b6a07e0c9310ea8cf902795c053642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173595
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb08fb797c58a4d21e7ae3a700b0e9ed30524a90]

        null-deref seen on rtf2pdf with tdf94049-1.rtf
        
        Change-Id: I9cd64f5fb20ccea84446909414624314b7eb956b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173684
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a54488dae3a9aba78a4e1d5cbea94f63ed2a446a]

        Remove duplicated include
        
        Change-Id: I9dc7bb716b29b0e9980734f254e8e385a571a560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173679
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-09-19  László Németh  <nemeth@numbertext.org>  [2baaf66b71fd429479dddb41f6b06aa7bba61039]

        tdf#163042 sw smart justify: fix cursor of single portion lines
        
        Fixed problems with cursor/pilcrow positions in a shrunk last
        line of a paragraph with a single portion:
        
        – clicking before the last or the last but one characters of the line,
          the cursor could be positioned at the end of the line, not before
          the last or the last but one characters (especially a line with
          more spaces and bigger space shrinking).
        
        – when the text cursor was there at the end, the visible cursor position
          was inside the line instead of the end of the line;
        
        – pilcrow symbol was inside the line instead of the end of the line.
        
        Follow-up to commit 6b857398a59d16308d6185d01e003e401439f060
        "tdf#162109 sw smart justify: fix overhanging last line"
        and commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46
        "tdf#162220 sw smart justify: fix shrinking for single portion lines".
        
        Change-Id: I0057f17fe187381c4c5d78574dcd99e0dafc11b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173662
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-09-19  Noel Grandin  <noelgrandin@gmail.com>  [7db1150b2c4a9adb993084d2dceedb450781b1dc]

        fix macos build with clang 16
        
        Undefined symbols for architecture arm64:
          "o3tl::strong_int<unsigned short, LanguageTypeTag>::strong_int<int>(int, std::__1::enable_if<std::is_integral<int>::value, int>::type)", referenced from:
              sfx2::(anonymous namespace)::SvxInternalLink::Connect(sfx2::SvBaseLink*) in linkmgr2.o
              SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o
              SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o
              SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o
              SfxHTMLParser::GetTableDataOptionsValNum(unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>&, rtl::OUString const&, std::__1::basic_string_view<char16_t, std::__1::char_traits<char16_t>>, SvNumberFormatter&) in sfxhtml.o
        ld: symbol(s) not found for architecture arm64
        clang++: error: linker command failed with exit code 1 (use -v to see invocation)
        make[1]: *** [/Users/noelgrandin/lode/dev/core/sfx2/Library_sfx.mk:20: /Users/noelgrandin/lode/dev/core/instdir/LibreOfficeDev.app/Contents/Frameworks/libsfxlo.dylib] Error 1
        make[1]: Target 'build' not remade because of errors.
        make: *** [Makefile:296: build] Error 2
        
        Change-Id: Ia8c338a89156e18a1c96630ecad2bccbba7bb745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-19  Sohrab Kazak  <sohrab.kazak@gmail.com>  [984f92ca04b0ca604a2ece0b19b422da9d6d922d]

        tdf#114441 Convert sal_uLong to sal_uInt32
        
        Change the variable that relates to the position of a footnote. Maintains the
        unsigned from previous because the variable is a position. The value doesn't
        seem to exceed the max.
        - ftnfrm.cxx
          + Change return types of the function lcl_FindFootnotePos
            + Change initialized types of variables that call above function, or use its value.
        
        Change-Id: Id44b8024eaa6e20d119f52ef03f62b30e6ae1c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173578
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [67dd735a040e93ddd7b098d013eca9526a321f88]

        ofz#71782 fix build failure
        
        Change-Id: I4be65927215dbf9c10ecd51baca42b59b569d75b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173677
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b64f3e5b837e7ceb1ccfd7771e972dd724e61f27]

        Fix typo
        
        Change-Id: Ib2f0d76465482663c7fd388ef065539c5ab2b330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173673
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [863d4390f07c541baaf10d9d91585e7fce71cdb2]

        cid#1608386 PA: Public Attribute
        
        Change-Id: Ie82c097a6c3241a9ed3642ba4985acc77cdd7f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [35939de2a9f59b79edbc574a7e429708a688b750]

        cid#1607067 Overflowed constant
        
        Change-Id: I039c80f489657cc4f47727af2e95b095592d6946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173668
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [795940e4acb56d4085c93072b4def0310bf2b4eb]

        cid#1606864 Overflowed constant
        
        Change-Id: I08beb9bd76065ea846171e07fbf6e427ada37360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173667
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f4c8f896f38e9d4999addff980278154e3b9322]

        cid#1606656 Overflowed constant
        
        Change-Id: I1503ebd911abf6e1e2060ce6dc3f0ac05e325982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173666
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [4722174f2132b1f0d29ab491d687fee6274d216f]

        qt: Use more qobject_cast instead of dynamic_cast
        
        Change-Id: I236d016dd51f219b63a7d7fb6b0cb83a06b960c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173661
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [be113bcfef5a411af43bcbcc7e51fc959eb4bcae]

        qt: Use qobject_cast to cast to QtMimeData
        
        Use `qobject_cast` instead of `dynamic_cast` to
        cast to QtMimeData.
        
        Add the `Q_OBJECT` macro to the class, as the
        the qobject_cast doc [1] says:
        
        > Warning: If T isn't declared with the Q_OBJECT macro, this function's
        > return value is undefined.
        
        Change-Id: I5de2d8dbf62ed1293f3660acae44e3b13ab5df71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173660
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [eac62756e7e74d0cf2ff78d52b1c24e9f6c5800c]

        qt: Use qobject_cast in QtFilePicker
        
        Use `qobject_cast` instead of `dynamic_cast`
        when casting to native Qt widgets.
        It should be faster.
        
        Quoting from the doc [1]:
        
        > The qobject_cast() function behaves similarly to the standard C++
        > dynamic_cast(), with the advantages that it doesn't require RTTI support
        > and it works across dynamic library boundaries.
        
        [1] https://doc.qt.io/qt-6/qobject.html#qobject_cast
        
        Change-Id: I20d4cca6936eeeb6f8367f82a9d11f12ada63e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173659
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [2284e26a0731a606568eda706e8e4451aaf880d8]

        qt a11y: Destroy QWindow when popup gets hidden
        
        When a popup gets hidden, destroy its associated
        QWindow.
        
        This prevents a "top-level" a11y object being reported
        when a popup gets shown, then hidden again, e.g. after
        expanding the Paragraph Style combobox in Writer's
        Formatting toolbar, then closing it again.
        
        Showing the popup results in a QWindow being created
        that would not implicitly be destroyed when the
        popup gets hidden again.
        
        Due to popups in LO currently not using the Qt::Popup
        type, but Qt::ToolTip, they are considered for top-level
        a11y children of the app, see the commit message of
        
            Change-Id: I7aff5c435dfa8b6aadcbbedb0d84db19bb86c8ab
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 19 09:15:37 2024 +0200
        
                qt a11y: Defer QWindow creation until frame gets shown
        
        for more details.
        
        Only delete the QWindow for non-spontaneous hide events,
        as the QWidget::hideEvent doc [1] says:
        
        > Note: A widget receives spontaneous show and hide events when its
        > mapping status is changed by the window system, e.g. a spontaneous hide
        > event when the user minimizes the window, and a spontaneous show event
        > when the window is restored again. After receiving a spontaneous hide
        > event, a widget is still considered visible in the sense of isVisible().
        
        With this commit in place, after starting Writer, opening the
        Paragraph Style combobox, then closing it again, only the
        Writer window is shown as a top-level child of the app
        in Accerciser when using the qt6 VCL plugin, as expected.
        
        Showing the popup again works just fine, as a new QWindow
        is implicitly created then.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#hideEvent
        
        Change-Id: Iefa5d05ea128966c4417d53d122a6a0f1178fc00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173657
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [fcaa903461ec0f5d4c8ce730f4c64adb3cec2262]

        qt a11y: Defer QWindow creation until frame gets shown
        
        Calling QtFrame::windowHandle makes sure that the
        QWindow exists, by calling
        QWidget::setAttribute(Qt::WA_NativeWindow).
        
        QWindows that don't have the Qt::Popup or Qt::Desktop
        type, are listed as accessible children of the application,
        see QAccessibleApplication::child [1] in qtbase and the
        `topLevelObjects()` [2] helper method it uses.
        
        This resulted in various dummy "top-level" objects being
        reported as children of the LibreOffice a11y app object,
        and therefore shown in Accerciser.
        
        For Writer, there are 2 instances for each of the popups for
        the comboboxes in the formatting toolbar that get reported
        as toplevels, as can seen by printing the accessible ID of
        their parent objects in Accerciser (they have a parent different
        from the app, since they're not actually top-levels):
        
        Paragraph style combobox:
        
            In [4]: acc.parent.accessibleId
            Out[4]: 'applystyle'
        
        Font name combobox:
        
            In [5]: acc.parent.accessibleId
            Out[5]: 'fontnamecombobox'
        
        Font size comobobox:
        
            In [6]: acc.parent.accessibleId
            Out[6]: 'fontsizecombobox'
        
        While these *are* popups, the Qt::Popup type is currently
        not used for them in LO to work around another issue
        with these popus on Wayland, but the Qt::Tooltip type
        is used, see the QtFrame ctor and comments there.
        
        To prevent these wrong "top-levels" from always being
        part of the a11y tree due to that, defer creating the QWindow
        by calling QtFrame::windowHandle to when the window
        is actually needed, in QtFrame::Show.
        
        Pass the Qt::UniqueConnection connection type param
        in the call to QObject::connect [3], to avoid
        duplicate connections if the frame gets hidden/shown
        multiple times. (Other than the ctor, QtFrame::Show
        could potentially get called multiple times.)
        
        With this in place, Accerciser now only shows a single
        top-level frame after starting LO Writer with the qt6
        VCL plugin, which is the actual Writer window.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/qaccessibleobject.cpp?id=0681e720a9851f1873ce5a5f99b5567d2b418261#n160]
        [2] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/qaccessibleobject.cpp?id=0681e720a9851f1873ce5a5f99b5567d2b418261#n122
        [3] https://doc.qt.io/qt-6/qobject.html#connect
        
        Change-Id: I7aff5c435dfa8b6aadcbbedb0d84db19bb86c8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173656
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-19  Michael Weghorn  <m.weghorn@posteo.de>  [b87df743b5d987e607c769e3c8f52cd3034dcaa8]

        qt: Run whole QtFrame::Show in main thread
        
        Instead of running only parts of the method
        explicitly in the main thread, ensure this
        for the whole method.
        
        Also, add a SolarMutexGuard at the beginning.
        
        Change-Id: I9c510b2d58ee5a3b05c1a16ce8e53077c7075caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173655
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-19  Mohit Marathe  <mohitmarathe@proton.me>  [8ae911e1d98029e17e6ffb1d336fbfa7e5ea9ed4]

        sw: add icons in sidebar's comment widget
        
        Change-Id: I41c27573f065796c729773f484154f5f404cfa75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172380
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-09-19  Mohit Marathe  <mohitmarathe@proton.me>  [b8d6171ddee0c7c2b8d7377d311482ed41a65bd0]

        sw: make show option work in comments panel
        
        Change-Id: I49e5feb7c6585c14d22a57715329290029cbadcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172379
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-19  Mohit Marathe  <mohitmarathe@proton.me>  [1bc03ef24fe3d1de6c2e2300a85d22b8e2cd2009]

        add context menu for comments & some other changes
        
        Besides adding a context menu for comments in the comments panel,
        this commit adds the ability to make comments editable only when
        needed (through the context menu)
        
        Change-Id: I208a6531ce56d7ee2d7ed50703178babda9c5a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170996
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-19  Mohit Marathe  <mohitmarathe@proton.me>  [1efe756d46cb5144da749a3b5279a8bc178dc802]

        display reference text on thread
        
        Change-Id: Ieeabde081c88473efa127c906b7ba12ba14bec17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171233
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-09-19  Mohit Marathe  <mohitmarathe@proton.me>  [8d70677c621959d1788e8ffa41641db06ef3cdb2]

        filter by author & time
        
        Change-Id: Ia32a9a3672e3e3a81245e67e388218559120e449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170497
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-09-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ef2f2129b78a5997e988ef723ff8a6c66269285]

        unoxml: move these two tests where they belong
        
        so they can make use of CPPUNIT_ASSERT_STATEMENT_EQUAL
        They were moved ported from Java to CppUnittest in
        
        commit e42be49887e75c6ec748b6c48bb4e5eda295c715
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Wed Jul 3 10:09:54 2024 +0200
        
            tdf#123293: port test from Java to CppUnitTest
        
        and
        
        commit d6ad09ca884fb7f35e2e24d532d85f6d818a7f1b
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Tue Jul 2 18:00:26 2024 +0200
        
            sfx2: port checkRDFa from Java to CppUnittest
        
        Change-Id: I7b91bde6d968081a5b1c0bbee42208590e062ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173622
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-19  Miklos Vajna  <vmiklos@collabora.com>  [a7830e04f2c33fb8d684d48d00ffc752f7207dea]

        cool#9992 lok doc sign: add password-less mode to create-certs.sh
        
        Now one can use './create-certs.sh RSA NOPASS' to create signing certs
        without encrypting them with a password. This is meant to be useful for
        the case when these certs have to be imported using the LOK API, and not
        interactively in Firefox, where one could ask for a password.
        
        Change-Id: I4cfc49ac8ff8c2420baa943b553a7a180a71e3bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173651
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-19  Michael Stahl  <michael.stahl@allotropia.de>  [d838b0d4af154b5c31818ceaac4bcdf8b2214c94]

        libtiff: upgrade to release 4.7.0
        
        Fixes CVE-2023-52356 CVE-2024-7006
        
        ofz65182.patch was apparently merged upstream and then reverted;
        Caolán suggested to drop the patch and see if ofz still finds a problem
        there.
        
        Change-Id: I0967708f19a7151b020372eca3c906b30f693db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173602
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-19  Michael Stahl  <michael.stahl@allotropia.de>  [aeb92985f58629a112b4d1f4d105de8c372735b8]

        package: add unit tests with invalid zip packages
        
        Change-Id: I687028391833ea48884912b0e5f586b95eee3244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170054
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ceff75b533654154ac077a7313ebebd53aedaa5e]

        Resolves: tdf#141577 explicitly set current frame as active frame
        
        of the current frame window. Creating the popup will grab focus
        into the dropdown, making the embedded frame lose focus, so it considers
        itself inactive (like right clicking in main frame area makes the
        embedded frame lose focus), so for this embedded object in another frame
        case make the original frame the active child of its parent after
        the popup has been created.
        
        Change-Id: Id6e12babcf4ebce05c297888b7b04756f2a12ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173624
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e3c181331dbd5fca36576bac4e79ddcceb7369e5]

        ofz: Timeout in schtmlfuzzer
        
        use same fuzzing rowspan limit as xml import
        
        Change-Id: Id75d8cb8859bb2a6494d6aea160905cc6b75cb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-19  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [bff514dea53e0c8c02663fda1b7f1ee469e2c536]

        tdf#162955 PDF export: avoid the popup rectangle with zero size
        
        Change-Id: I9a3cdda4d1dfa0b23a3ea6dd99341cb17ca47490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173580
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-09-19  Regina Henschel  <rb.henschel@t-online.de>  [35c5d496645e64463ff4ba1e7b0b78f6b55741d9]

        tdf#162963 export property TotalsRow to ODF
        
        DatabaseRange has got the property TotalsRow with UI and UNO. But this
        property was not written to ODF. The patch adds this as attribute
        calcext:contains-footer to <table:database-range> element.
        Related is issue OFFICE-4169 at OASIS.
        
        Change-Id: I99a51198585b9b7dfb840217bdf1312f2462c9bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173612
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-09-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [56507ad26c2827257f201e096beac95d8c725d5f]

        Fix typo
        
        Change-Id: I291dcc19e429493289cd2be8367a0d1e0c6d2296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173646
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [a386837e4ea4a15609623916df5217e572480598]

        use more concrete UNO types in WeakRefWrapper
        
        Change-Id: I5805a681833003c01b5c06c4719606cb27ab600c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173608
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fdc026250c9d691730e2062a7b5e2d5a6a81575]

        use more concrete UNO types in sc
        
        Change-Id: I5b70733fb5be0a4f9a51e48197454ff0452770bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173611
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [c629d8322d89e6c318a772f74a7be5370f830bef]

        pull some code out of hot loop
        
        Change-Id: Ic19888296d1a7be7c691714b0353f18a1ea074f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173591
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d02310ba14a4c400eef4821c99287c797d376714]

        Remaining GCC -Wcast-function-type issues
        
        As Clang supports that warning now too, lots of occurrences have meanwhile been
        cleaned up for good (0c29c417ef3f0b749042e5a461abae9c36cf655b "Avoid
        -Werror,-Wcast-function-type-mismatch", 1344e6261a1d856c71eca1e0cc29215a586bf335
        "Avoid -Werror,-Wcast-function-type-mismatch",
        85a2bb9f52a0d834b02681344ce56e0b091e1abd "Avoid
        -Werror,-Wcast-function-type-mismatch", etc.), so
        ce99754e9b5b954be4360f39356ed7198b298265 "Globally disable -Wcast-function-type
        new with upcoming GCC 8" in solenv/gbuild/platform/com_GCC_defs.mk should no
        longer be necessary.
        
        One remaining issue I encountered was dae7304df68493afcf6e9c9e490d65ea20d8211f
        "Silence Clang 19 trunk -Werror,-Wcast-function-type-mismatch", where GCC needs
        a different way for silencing the warnings in pyuno/source/module/ than had been
        used there for Clang.
        
        Change-Id: I5d0404b957d798114051209c31e022a898cf91f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173623
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [d500848976b6244048684a9972322b582559910a]

        libxml2: upgrade to 2.13.4
        
        * 0001-ofz-70675-XML_ERR_FATAL-not-ending-parse.patch.0
        is no longer needed. fixed upstream
        
        Downloaded from https://download-fallback.gnome.org/sources/libxml2/2.13/libxml2-2.13.4.tar.xz
        
        Change-Id: I7d39940ad5b197b302c57110e147aef7d2b911d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173621
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [42f8b7ab7f76676987e5b3aabedffcc3466bcaed]

        reset m_bEnd after use to quit lcl_workerfunc
        
        so lcl_workerfunc can be launched again on-demand
        
        Change-Id: I23dd48dc433190413f5c63464dcce112128b81ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173564
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit fd88a5bcb271a1711f484a319ee23d6b7013b232)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173502
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80d4e666dde9954a1f7387e7833e8a52d24e22df]

        Do not hardcode --with-locales=en for Emscripten build
        
        ...which had been done in 7a9e4c4ba8c6b8e068005f3831b989e3c929e8eb "WASM add
        strip flags to configure.ac", but without giving a rationale.  For
        --enable-assert-always-abort builds, it could have caused the
        
        >                     assert(pUpperMonthText[0] == "JANUAR");
        
        in ImpSvNumberInputScan::GetMonth (svl/source/numbers/zforfind.cxx) to fire when
        running in a German-locale browser, because the rule to generate the
        DISABLE_DYNLOADING-specific localedata_static.hxx in
        i18npool/Library_i18npool.mk then only included English-locale fallback
        locale data, so pUpperMonthText[0] was always the English "JANUARY", regardless
        of locale used.
        
        With with_locales left uninitialized here, the generated localedata_static.hxx
        now includes the full set of locale data.  Which comes with a small increase in
        size, though:  For one non-debug build scenario, sofice.data stayed at ca. 68M
        but soffice.wasm grew from ca. 138M to ca. 143M.
        
        Change-Id: I46dae3f5c795ae30fc44d3ac4cb8dd162cd72966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173619
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b97b725312767dc5baf0a80c00c2ceda0f8dfa57]

        use more concrete UNO types in sd
        
        Change-Id: If731da0f4839dc98b0dab1fa61669b92d5cc70f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173610
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b09c52542fc431ff9e31e5bc1d24623c6bf42ac9]

        use more concrete UNO types in sd
        
        Change-Id: I60977cf7e0690b8a01daa2fe6700e89c8a29516b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173609
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff632abcc3e907304c31c5bd8bbd7c7d4e38d2ab]

        use more concrete UNO types in sd
        
        Change-Id: I1176da07dae2ac510ac4acf310ce3e4d499573d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [77a58b5f7c85e8036606791ee6fe2fb763eaab0d]

        use more concrete UNO types in sd
        
        Change-Id: I07e1db5a771c0a2391afbd715c91ea5919e19ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173606
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [20c7dd09f2485838a0d230efe0a1c36d5b22723f]

        use more concrete UNO types in sd
        
        Change-Id: I01e30ca54b909da84c3bf535842d2c2283c31451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173605
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1972d0d9d63639ce35096e412f3157a708dbb60a]

        Resolves: tdf#162538 explicitly make buttons gain focus on activatation
        
        even if by keyboard. So spinbuttons that depend on losing focus to
        update will update before 'ok' is called.
        
        Change-Id: I1eddd4c29c3ffeb06ead058c9efbdfde01418589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173616
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [35dfb73889a084fc4a428071471429396a7d1287]

        cid#1607355 silence Overflowed constant
        
        and
        
        cid#1607426 Overflowed constant
        cid#1608151 Overflowed constant
        cid#1608163 Overflowed constant
        cid#1608208 Overflowed constant
        cid#1608228 Overflowed constant
        cid#1608299 Overflowed constant
        cid#1608549 Overflowed constant
        cid#1607982 Overflowed constant
        cid#1608078 Overflowed return value
        
        Change-Id: Id4ccc03b610f4dcf7912c239c7c079da1aef4ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173615
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [57ecae2843c80d67ab9a3aaaf004fe131c4f13ae]

        tdf#162760 Fix solver crashing with unset parameters
        
        This patch fixes 2 related issues:
        1) Solver engines may crash internally and we need to catch these exceptions and inform the user instead of letting Calc crash entirely.
        2) When initializing solver settings, we only set the default values for the first engine; we need to set the defaults for all engines.
        
        Change-Id: Ia598f7c17c25b5d6277f2ce24d2f4d552f897fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172955
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-09-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c54b8e5682373934c826702a965f97f4a7a36193]

        Avoid -Werror,-Wunused-function
        
        Change-Id: I95ca13db07a778fc260cbb78364916cc7400e378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173590
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [5fb127ffaf6628ac9a757638705948aa5cb94b55]

        tdf#130857 qt weld: Pass parent to QtInstanceBuilder
        
        Instead of always passing `nullptr` for the
        parent to the `QtInstanceBuilder`, use
        `QtInstance::GetNativeParentFromWeldParent` in order
        to find a QWidget that can be used for the parent.
        
        This makes the "Save Document?" dialog in the
        WIP Gerrit change [1] (patch set 24 that actually
        makes use of the parent) properly modal on top
        of the Writer window, so the dialog no longer
        disappears behind the Writer window when using
        Alt+Tab.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I84de0c4808d76020103f10ebaacb03908a6ee815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173594
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [10590d4f1f072630238a1e62fe48afb20ab41644]

        tdf#130857 qt weld: Move logic to find native Qt parent to helper
        
        Move the logic to find a QWidget parent mostly introduced
        in
        
            commit 1e2836665a1839f61cd8bfa46c54687f010e7e9d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 30 18:17:53 2024 +0200
        
                tdf#162696 tdf#130857 qt weld: Get parent via SalInstanceWidget
        
        to a helper method, for reuse in `QtInstance::CreateBuilder`
        in an upcoming commit.
        
        Change-Id: Ied41e7f5054f08382668292042f2a9978c6bed91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173593
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-18  OmkarAcharekar  <omkaracharekar12@gmail.com>  [9b3a2996e710fee11145dcbbe38a6f1e6f646ec8]

        tdf#130857 qt weld: Add QtInstanceBuilder skeleton
        
        Add new `QtInstanceBuilder` that derives from
        `weld::Builder` and is meant to use
        `weld::Widget` implementations using native
        Qt widgets.
        
        Override `SalInstance::CreateBuilder` in
        `QtInstance` to return an instance of the new
        `QtInstanceBuilder` for UI files that that one
        can handle/supports.
        
        As of now, `QtInstanceBuilder` doesn't yet
        implement what's needed, so
        `QtInstanceBuilder::IsUIFileSupported` currently
        still always returns `false`, meaning that
        `SalInstanceBuilder` is still always used in
        practice.
        
        The idea is to implement funcationality needed for a
        specific UI file/dialog in `QtInstanceBuilder`, then add
        it to the set of supported UI files in
        `QtInstanceBuilder::IsUIFileSupported`.
        This allows looking at one .ui file at a time and only having
        to implement what is relevant for that particular one, without
        having to implement the full weld API at once.
        
        The use of `QtInstanceBuilder` can completely be
        disabled by starting LO with environment variable
        `SAL_VCL_QT_NO_WELDED_WIDGETS` set.
        
        This commit is mostly extraced from Omkar Acharekar's WIP
        Gerrit change [1] (patch set 22) with some further
        adjustments by Michael Weghorn. Patch set 23
        of that WIP Gerrit change demonstrates adding
        support for a dialog (the "Save Document?" one), but
        still needs more work.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
        Change-Id: If2d1ea30d43c2c1d84d64e577035489c8e158a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173592
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b35a1ee2aa85d42a749c4380feb252dc4c1e143c]

        cid#1607362 Overflowed constant
        
        and
        
        cid#1607419 Overflowed constant
        cid#1608605 Overflowed constant
        
        Change-Id: Ia63cc771021d8a8031c62582a2fa6a68dc214f08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173614
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8c56ecafb87754116bc5a2e37b65b92e1b59514]

        Fix typo
        
        Change-Id: I5647da0ca8d5432899fc8de57be846315d3dea6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173604
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ba0c69e66b4d36af2ac067075a8ab31d6a8d07e2]

        Fix typo
        
        Change-Id: I917ad7304c479d8f0c807cfd77d87c56cfb25b93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173603
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfd170112f74c7e4cb0b3031b78718f11deb6b7e]

        curl: upgrade to 8.10.1
        
        Downloaded from https://curl.se/download/curl-8.10.1.tar.xz
        
        Change-Id: If65882b06172e9caf93d941011baa49c84d4f054
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173586
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-18  Michael Stahl  <michael.stahl@allotropia.de>  [81e0b7e7c05d324fb77da7eda0d736fac5526b3e]

        xmlsecurity: add unit test with docx that can only be opened with repair
        
        Change-Id: I4f705dd2124383a90b69d04d8b2de0e37f83a495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170053
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f48c9d59cc1799d7eb1523af9e3b2df147676d22]

        use more concrete UNO in basic
        
        Change-Id: I6606008d9b45e00295cf441a7321a677d62317f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173581
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7da920fa17b4006b2d26cd3963d5cedf0a375a41]

        cid#1608459 PA: Public Attribute
        
        Change-Id: I6dccead2abe3062558a1b87c56c6efc14cf0fb19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173589
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-18  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [25c758df711d473dcc65161f80802b21ab6e9d1e]

        slideshow: add transitionDuration and highResDuration properties for impress
        
        Change-Id: I77805d7ee801917c8f8b37e4d85aa7b1ec3f4d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171423
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bbef07065433ecc33e22724e65974e2b7509929a]

        cid#1619460 Uninitialized scalar field
        
        since:
        
        commit 4855bbfa4d0cbc6376ab2a40151886f84fafac40
        CommitDate: Tue Sep 17 03:44:46 2024 +0200
        
            tdf#132274 add zoom defaults to Writer options
        
        Change-Id: Ie7dae9add87fe14c87b53d9b86d77a84ce0c2a7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173587
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f445e42b6148c37c9de9180d1f192f585061479]

        use more concrete UNO in extensions
        
        Change-Id: I67215b2b5ae03cf3c93915a7590b645914b505de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173582
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Michael Stahl  <michael.stahl@allotropia.de>  [ab10484cf12578aed039c6947088f6d6e3126885]

        package: remove superfluous assert
        
        Change-Id: I20bc36c4e3c3c2cb05d4f89f0687b9d87f02999d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173558
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36b988312ae8013deefcdf4800592230e7c95ad8]

        cid#1555574 drop unused copy ctor
        
        Change-Id: Ibaad87cc2f481f3bc7f726ecde0c466a563a96a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173588
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-18  Michael Stahl  <michael.stahl@allotropia.de>  [e22f1a2993d1c675ed8017090d1557d74d8b2917]

        package: tweak password fallback in ZipPackageStream::getDataStream()
        
        Fallbacks are only useful if an existing file is imported.
        
        It looks like it might have been possible to hit this case by storing a
        new document as ODF 1.1, and that sets m_bIsEncrypted but not
        m_oImportedAlgorithms (as Mike Kaganski pointed out), haven't tried it.
        
        Change-Id: Ia82c2e43372f50aa4e7ad9c2c62878986295c815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173551
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-18  Noel Grandin  <noelgrandin@gmail.com>  [b6a5cdc0f753c8ed6ed080f9189ac2e2601dce9d]

        dont use GetItemSurrogates for gathering SvxBrushItem
        
        which is very expensive these days
        
        Change-Id: I010d174fbd256da0b220e13cbc50d9b4d8c6b1bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173576
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-18  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [750be5370638917361ec9cc2e7d016e4caf2416e]

        tdf#158939 Karasa Jaga: optimise icons by removing bitmaps
        
        Change-Id: If6a285f03e3c97525c9de1267193347323964e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173566
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [52f19726b4ac5e06a47c188e2ec90d85426716a8]

        unoxml: move testXDocumentBuilder from Java to CppUnittest
        
        Change-Id: I15996b72745dd9d3f00e917cc6b459094ec51f30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173569
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [b42b218bd72ed490ed765588d97da67b9b309f59]

        unoxml: move checkRDF from Java to CppUnittest
        
        Change-Id: If4e3120643c40f52b99bb71782c4c34a34871031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173567
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [b8d5b98b06be493de6f57cf39f2e75393120392d]

        unoxml: introduce CPPUNIT_ASSERT_STATEMENT_EQUAL
        
        Change-Id: I4e28939452e164bf368df5f222d535b29d7951bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173557
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-18  RMZeroFour  <ritobroto04@gmail.com>  [b4289da0b4074a219aec899814378c71952e934a]

        .NET Bindings: Ported examples for Native bridge
        
        This patch include the following SDK examples ported to .NET
        to test the new Native bridge:
        - FirstLoadComponent
        - HelloTextTableShape
        - PathSettings
        - PathSubstitution
        - TerminationTest
        - WriterDemo
        
        The examples include VB.NET and F# as well to test support for
        non-C# .NET languages.
        
        Change-Id: I044df4777c7c091241d5b4284f4b6ee6c5de74f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172778
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-09-18  RMZeroFour  <ritobroto04@gmail.com>  [c3c7b48fa9d4fd5b8f28033ca7453151df9d5f7f]

        .NET Bindings: Native bridge for .NET
        
        This patch includes all marshalling and proxy handling code on the
        .NET side as well as the native side needed for a fully functional
        UNO bridge.
        
        It also includes some changes and corrections to net_basetypes and
        netmaker needed for the bridge to work properly.
        
        It also includes the FirstUnoContact example in C# as demonstration.
        
        Change-Id: I406932938a4415d24408fb41ddfa7d8eeb5d1f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170916
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-09-18  RMZeroFour  <ritobroto04@gmail.com>  [074714fab8db751e2aa0138391a270124733977d]

        .NET Bindings: Create nuget package for LO SDK
        
        This patch includes:
        1. CustomTarget to build and place the LibreOffice.Bindings NuGet
           package in <sdk>/dotnet/
        2. net_bridge (.NET library) to declare bootstrap() on the C# side,
           and net_bootstrap (C++ library) to wrap bootstrap() on the native side
        3. Changes to LO SDK scripts to find .NET SDK and DOTNET_ROOT on the
           users machine
        
        Change-Id: Ia29ae56a2ad0f808f1563ef6167a3bd7c476642e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170172
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [26fd88df801c91117b8819e2a1afb898d2612eba]

        remove OSubComponent from RowSet
        
        which attempts to implement a very dodgy and almost but not actually
        thread-safe dispose function. Rather just hold a weak reference to the
        rowset that created us.
        
        Change-Id: I1881ac34320b61866eefc3641b455f618d0759d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173573
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7354e18731ae41ab86584b04b0b23bee844f3dd]

        remove OSubComponent from OStatementBase
        
        which attempts to implement a very dodgy and almost but not actually
        thread-safe dispose function. Rather just hold a weak reference to the
        connection that created us.
        
        Change-Id: I01e4f5fc0a8aeb33adc14a2981ce09522a0306bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [05c01410f3c0fcb791f60b19ce2085beee1dabe0]

        vcl: test BitmapAlphaClampFilter
        
        Change-Id: Ie44884a3010cd26b057bac593059a4bd0a3aabc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173345
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [393b1a5de4e113336ca5fa87cc77555679fa8e03]

        tdf#130857 VclBuilder: Move m_sHelpRoot member to base class
        
        Add a protected getter, `getHelpRoot()` to access it.
        
        Change-Id: Idb2f6834e13f6b7d04abe0a3c607444383e6ee1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173577
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [5cb3f13e3d5e11d7deba3e0d9750a941d19ba1a3]

        tdf#130857 VclBuilder: Move TextBuffer bookkeeping to base class
        
        This is basically the same as
        
            Change-Id: Iba98406817906e36fb8dc723c8e9b4b554eb2258
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Sep 17 19:35:22 2024 +0200
        
                tdf#130857 VclBuilder: Move adjustment bookkeeping to base class
        
        , but for the `TextBuffer`s instead of the `Adjustment`s.
        
        Change-Id: I0f53718892f70a285a7f8b0d8e9e112d48dedb50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173575
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [24406f5ae529e355474b43d4770617ecb264ccff]

        tdf#130857 VclBuilder: Move Adjustment bookkeeping to base class
        
        A GtkAdjustment represents a value with an upper and
        lower bound. Move bookkeeping of the adjustments from
        `VclBuilder` to the base class `BuilderBase`, so this
        can be reused by other subclasses in the future.
        
        For now, adding adjustments by calling
        `BuilderBase::addAdjustment` only happens in the
        (currently still) VclBuilder-specific `VclBuilder::handleObject`,
        but this is one step towards making it useful outside of it.
        
        Change-Id: Iba98406817906e36fb8dc723c8e9b4b554eb2258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [58fd872ffb4f81e58a764545fcefc93d39adb906]

        tdf#130857 VclBuilder: Move class/id/custom prop extraction to helper
        
        Extract parsing of these attributes from `VclBuilder::handleObject`
        to a new helper method `BaseBuilder::extractClassAndIdAndCustomProperty`
        in the base class.
        
        Change-Id: I248448407db446fd61bf91bf13c9bc187e0706d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162918
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-18  Jonathan Clark  <jonathan@libreoffice.org>  [3bd4a797724cf432d09a7d8ffe5f4a53a1e7c78d]

        tdf#119785 Implement the EMF TA_RTLREADING alignment flag
        
        EMF has two ways to indicate that text should be treated as RTL:
        
        - The ExtTextOut ETO_RTLREADING flag
        - The SetTextAlign TA_RTLREADING flag
        
        Previously, only the former was implemented. This change implements the
        latter.
        
        Change-Id: If1023b4a0a3b6eb2ce47d2b764edbfd1a5c0dd5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173579
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-18  Dione Maddern  <dionemaddern@gmail.com>  [d14e79bf7680db2180e40ba52fc3305a84c586f6]

        Correct grammar in strings for A11y
        
        In cui/inc/strings.hrc
        - Ensure that strings for A11y options use correct English grammar.
        
        Change-Id: I80a6fbc07d6c34b52d674c3650905a2865ce3e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173565
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-09-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5b6f384f940d40b8d40675306e103cfdd29bf700]

        tdf#162988 - A11Y sidebar: fix hyperlinks false warning
        
        Better to check the SwpHints of the textnodes then iterate
        through on the xParagraph's xTextRanges to search for a11y
        hyperlink warnings.
        
        Change-Id: I19a3eddd53f122bd4290e5b93e4784b89f65427d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173560
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [2f6504dd84fc37bbf8d7798d4a60fc592aa7a67e]

        tdf#163006: fix keep-together rows height calculation
        
        In commit dcb682563b24bf487a40a9fe7710b4d500850a52 (INTEGRATION: CWS
        swnewtable (1.92.14); FILE MERGED, 2007-02-28), a code was introduced
        in sw/source/core/layout/tabfrm.cxx, that considers the rows having
        m_bIsRowSpanLine set. In SwTabFrame::CalcHeightOfFirstContentLine,
        when getting pFirstRow, such a RowSpanLine was skipped when counting
        the keep-together rows.
        
        However, it was implemented incorrectly: the resulting number of rows,
        excluding the RowSpanLine, then used in a call to lcl_GetHeightOfRows,
        which didn't skip the said row, and thus calculated its (zero) height
        instead of an actual keep-together line.
        
        This fixes the said calculation, and also another place in the same
        file, where the same calculation is done, where RowSpanLine's weren't
        checked at all.
        
        Change-Id: I125a8f6de389d6b7600f3e13343594ac82249d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173559
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [905270a2b483043e12c28806e3c4d3be850b479d]

        wina11y: Drop CAccImage::GetXInterface
        
        Just use the `m_xImage` member directly, as already
        happens just a few lines above.
        
        Change-Id: I00f7e871a2cb5eb301ba033944d8d529cc10bbae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173536
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [612e6aaa1f2d0b3603da686a0297193832511b3d]

        wina11y: Just assign the Reference
        
        Change-Id: Ibe0e9f1c8c6838044355db987d08298b267bed64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173535
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [5ccd777b33d070ca056ac18cec59ba741b73d48e]

        wina11y: Rename CAccImage::{pRXImg -> m_xImage}
        
        Adhere to naming conventions to make clearer this is a
        class member, and a uno::Reference.
        
        Change-Id: I804bb66d88675d1f5e7e0ee31f9244db5abf0125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173534
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [ec2d705c16db5854ac51dd54fd67f32f0f15a5cc]

        wina11y: Check reference in CAccHyperLink::get_startIndex
        
        Check the reference is valid in this method as well,
        just like in all of the other API methods.
        
        Change-Id: Ibb1a6a8b290ffefc502966ed0372c4e421fe68fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173533
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [1941c32c90674c5b2870002c0791fb32ff4ff137]

        wina11y: Drop CAccHyperLink::GetXInterface
        
        Just consistently use the `m_xHyperlink` member directly.
        
        Change-Id: If2ac4150b5b733005b916d0c5f11e8c711d95c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173532
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [cdd0af36f4057a8750992d7b4a82cd0e50183d04]

        wina11y: Just assign the Reference
        
        Change-Id: I8ca9cd55723b1775284b23e13db409fc5d47005c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173531
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [e22172ebed6f019a153e485b4bda64e6b6859b2d]

        wina11y: Rename CAccHyperLink::{pRXLink -> m_xHyperlink}
        
        Adhere to naming conventions to make clearer that this
        is a class member, and a `uno::Reference`.
        
        Change-Id: I29caf6ad2d0adcfca430df72c2638dbd4ee06f1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173530
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [76cc9a987e5d5b2cdab302280c243e72d5905957]

        wina11y: Drop CAccEditableText::GetXInterface
        
        Be consistent and just use CAccEditableText::mxEditableText
        directly, as already happens in each of the methods just
        a few lines further up.
        
        Change-Id: I70637714623f0410a60778e7bc1f4b007e034ddf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173529
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [74bfaa04b81819c61e9eb8aa9c02ecafa4fbfd2a]

        wina11y: Just assign the reference
        
        operator= knows what to do, no custom handling needed.
        
        Change-Id: I9a64cc371e5b14c146e311364d1b4212d519d746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173528
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [087d876c76c77b278062b2649308155e395f1dfd]

        wina11y: Rename CAccEditableText::{pRXEdtTxt -> m_xEditableText}
        
        Adhere to naming conventions and use a less cryptic name.
        
        Change-Id: I13ff9f515351fbbf0c749522edfb739e15626a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173527
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [882e63489c9104d3204e168438bdbfbd4a25a290]

        wina11y: clang-format CAccEditableText sources
        
        This in particular ensures that try/catch blocks
        are indented by an additional level, improving
        readability.
        
        Change-Id: I7fd538434bd8edb5748bb551fdfd2d4966293bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173526
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [6d64384d93b6ae256a529d524c15719b872fcab7]

        Colibre: fix typehistogram_16.png icon
        
        Change-Id: Iebbe9f31d9c42dc2af82a9afefdae1fd711a4677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173562
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4bbe329ef07bb38c939c6bef53ae4aa9928b9a52]

        Avoid -Werror,-Wcast-function-type-mismatch
        
        ...as seen when building LOWA (i.e., --disable-dynloading) with a recent Clang
        with
        <https://github.com/llvm/llvm-project/commit/999d4f840777bf8de26d45947192aa0728edc0fb>
        "Split -Wcast-function-type into a separate group (#86131)", where
        -Wcast-function-type-mismatch generally warns about casts between incompatible
        function types...
        
        > cppuhelper/source/shlib.cxx:294:23: error: cast from 'void *(*)(void *, void *)' to 'ImplementationConstructorFn *' (aka 'css::uno::XInterface *(*)(css::uno::XComponentContext *, const css::uno::Sequence<css::uno::Any> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
        >   294 |                     = reinterpret_cast<ImplementationConstructorFn *>(
        >       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   295 |                         map[i].constructor_function);
        >       |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        ...but not for the special case of casting from/to void(*)(void).
        
        (Using the correct function type
        
        > css::uno::XInterface * (*)(css::uno::XComponentContext *, css::uno::Sequence<css::uno::Any> const &)
        
        throughout would be even better, but doesn't easily fit into this C code that is
        included in low-level places that don't know those UNO types and is shared
        between LOWA and Android etc.)
        
        Change-Id: Ic4dbabbff0f772b34cf692db968c3ad257c37cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173463
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [45ffeed6674e4f3c5b92f951094d41a0d0ec8002]

        Fix missing quotation
        
        ...that appears to be broken ever since 9892af3cbf85e9793f21683aa16c84354d866ad5
        "Modernize wasm debug symbol generation" and to have gone largely unnoticed, but
        now happened to cause
        
        > ./configure: line 14652: -gpubnames: command not found
        > checking whether ccache emcc supports ... configure: error: no
        
        in an odd Emscripten build of mine where I accidentally used a broken emcc (so
        that autogen.sh started to draw bogus conclusions and get into otherwise
        untested code branches)
        
        Change-Id: Idff3a52d61464f00f2c811b207c5a214672b5b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173480
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bfb66b4ee83e5f92239ea02417ef4c1e4c8f659e]

        ofz#71606 use extended upstream solution
        
        Change-Id: Id4c511572792da1edd7ebbe15c1fb994ac30bdd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173561
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9671a3d31e279a40378a7ddf05e57df982e4bc98]

        This should iterate over the thesaurus languages, not the spelling ones
        
        Change-Id: I94410274f7afbc0a6bc33fe43beb9810a905dfe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173467
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173556
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [848ff3ffadf6f366ca952af15e6b770ad6a167dc]

        cid#1607992 silence Overflowed constant
        
        Change-Id: Ib5ceaa4f8f42c897dba8f941e4b094d9f522b3bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173555
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fda9371ce530d1c79e6eb404afd7127371f7975]

        cid#1608032 Overflowed constant
        
        Change-Id: I4b74a139483ff932e71102ec73ab6d352e533245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173554
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4017cb924304d040df8a2ed51f72f9fec28f810a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 74180ce0f912f7a432f509b8c5ac9239e4f74d9a
          - tdf#163012 Add description of \w and \W to regex page
            
            Change-Id: I11dc5b3eee4af0447a7450fa71fa25f8c1327a03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173571
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1751adc9030df53ab2c610ac0af08d3942a75b05]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 589c8137e03b1bbb7647cbfaf0a6585d60fbfc9b
          - tdf#162847 Resize icon in page.
            
            + refactor partially
            
            Change-Id: I9e547dcab48fe5413f92076c365bf7db952c06c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173570
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [f23081f61950e67a911e8afb1271636f3733a66f]

        tdf#130857 VclBuilder: Turn extractOrientation into static helper
        
        Turn the `extractOrientation` helper function into
        a static helper method `BuilderBase::hasOrientationVertical`
        for reuse in the pending WIP Gerrit change to implement
        a `QtBuilder` [1], which currently duplicates this method
        in patch set 18.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831/18
        
        Change-Id: I8255188ae66727d0832e8d6b41952649de07a679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173546
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Jim Raykowski  <raykowj@gmail.com>  [d925bfdb152e47772d1b3436f73c3193b3023c29]

        Resolves tdf#152440 BOOK VIEW: Switching page view to book view
        
        or from book view results in a switch to a semi-random page
        
        Change-Id: I2e3e63430fb2ed04d2f71cf2e716844b85f440f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173510
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4a361fdf9c0ec4f16862eca3b90ac4daea1a2a10]

        cid#1608125 Overflowed constant
        
        Change-Id: Iec74e8824eab7d9e49ebe4d46912a717a3990c92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173553
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4cbf139c638d792e9400881b21d91e8102be71af]

        cid#1608157 silence Overflowed constant
        
        Change-Id: Ie19c388b983800b514ed3b309955968eccd24efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173550
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c69ad797408fd93afec2c5ac47ba94eba5e4c81c]

        use more concrete UNO types in sw
        
        Change-Id: I0f84ce7116441abb2359ee756c912ae663baa2fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08b8585f66073d90e5e11db9b8b3fbcbdaf2adc2]

        cid#1608165 Overflowed constant
        
        Change-Id: Ie360d3c479e639c3b97ab532d5f0778809ca2d44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f145e82a0f088fe3fa0b69ea205568d96affd9e7]

        cid#1608224 Overflowed constant
        
        Change-Id: I6a76e85754120ef0bc9d3b357a622d312362a72c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173548
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [086941f0e60c4a41b84cad9c67ad24f8a70133fc]

        cid#1608244 Overflowed constant
        
        Change-Id: Ia96ff4eb0840c6136cb6cd0eefee1cc487bce355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173547
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8ef51bc0130f2832b86214dc6ce6315faae325c]

        cid#1608322 silence Overflowed constant
        
        Change-Id: I23229d2bb29c926f9840f11b09ebc591f1b0047f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173544
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b289d5f5cbd9d138832bb8871543763e728c8135]

        cid#1608561 Overflowed constant
        
        Change-Id: I3115263da1c76f635d544e41c3cf96e068b34324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173543
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0810f7d891a8b94bd77d02d7bb1efd2a3f9440fc]

        cid#1608578 Overflowed constant
        
        Change-Id: Id7f5b94208f75a0fdc8ebb769b5a8265312c0995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173542
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf6dd625a440e250dc7edf13d03d7a8734a5ea7d]

        ofz#71606 use better upstream solution
        
        Change-Id: I088db3a8defd4cddee657c25d35724932339b983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173541
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22daa770c2bc5d7105f1477410f2410f5a15b487]

        these can be const
        
        Change-Id: Id560175cc69162b362e8f96b2dc0255118387f8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173539
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f9d39b4b518eb6316d822c63d7b9b456de9e1c0]

        Output what languages are handled by LanguageTool
        
        to explain the absence of languages that are listed by 'Preloading'
        because the languages handled by a remote LanguageTool are removed
        from the languages handled with local data.
        
        Change-Id: I203657f68a7b9399e39ebf9ab9447c7ae56efe68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173448
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit c5fc86e770901eb90356cb31d4ac71ac7dad9ce6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0bf27ee5226496f844361e2c8cc0fbf625ec1466]

        move setLanguageToolConfig out of extern "C" zone
        
        no logic change here
        
        Change-Id: I29153a11e1b841fa078d29a6431cd5af1179672e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173450
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 26e433e0e3c6dfbf2569c3b6f0a14249dc4d0c1f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173537
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9a70d822ce54fc6976542a48ff938a1adc6661d]

        unoxml: move checkSPARQL from Java to CppUnittest
        
        Change-Id: Id8adaec00b9920966c91471fdd32720337a8c414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [c600065569bba3c2bbbaceba0b7998f8ad9ec8f9]

        unoxml: move checkRDFa from Java to CppUnittest
        
        Change-Id: Ife5cd7398bdbacbd8189c8451dab6351590052e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173484
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-17  Marco Cecchetti  <marco.cecchetti@collabora.com>  [1ce7c354024ec348459ec137797b5351cbaf27dd]

        lok: sd: slideshow render improvements
        
        Changed the slide layer message layout.
        Sometime some text field layer was missing.
        Try to skip empty layers.
        
        Change-Id: I52f00e637da7ab705a1fcb52a70af88cf619c8f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173540
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [8dba09031bac4744f489bfa23be3c669640b0c93]

        sc: use SAL_RET_MAYBENULL() in GetViewBindings
        
        Change-Id: I67e3e7921869a22d2bf6ce713fd581a9c3881aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173521
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-17  Kira Tubo  <kira.tubo@gmail.com>  [9286ac87abe4eeaf878585bdc5bb4fee40f950cc]

        Related tdf#161657 Define default Comments style attributes
        
        * Line spacing = Single
        * Indents/Margins = 0
        * Top/Bottom spacing = 0
        * Font color = COL_AUTO
        * Highlight = None (COL_TRANSPARENT)
        
        Change-Id: Idd0d4d896a0cc6021c99c7c13280ef6e18ae2602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173507
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6d8c6e6fe23628596ceb537b1bab9219d909d80]

        cid#1607476 Overflowed return value
        
        Change-Id: I38c72db66e47b0e09a53413457f167159c599202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d3959ecab9a12d947db4904aa71a39dc9ec37476]

        cid#1606987 silence Overflowed integer argument
        
        Change-Id: I77380d12a5d51c3debb1365a5fc9b57c33299eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d7d094b46149a6c2472a6e8966f88daefd644d88]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 614dd5fba24a70bc5b5a4cb43eb431fc4dacd3c0
          - tdf#162607 disambiguate hid2file.js, InsertAuthor
            
            + moved insert author to shared/
            + Document access command, delete old command paths
            
            Change-Id: Ic2ce72a47f842b6bdaf8cdb7469beaded3f43f06
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173483
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2e01d101ac9e62d5b91059a93b2d2bac681d84c6]

        cid#1608367 silence Overflowed return value
        
        Change-Id: If60d9607678ac9193923cad63895d654b8283ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173522
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7de90affa22668cf140f61aae44bcc4042f02555]

        cid#1608226 Overflowed integer argument
        
        and
        
        cid#1607920 Overflowed integer argument
        cid#1606589 Overflowed integer argument
        cid#1606576 Overflowed integer argument
        
        Change-Id: I2b1c0e871e7f7a913e0f14128fb13fc04d993ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173520
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0a2e0a069f6d864f566067f75f6d2e75cbaeae7e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7b6ce51459426167f1f17ea209ba38707788673
          - tdf#162607 disambiguate hid2file.js, Select Row/Col
            
            + deleted singleton pages not a target
            + deleted embed how-to-get not used anymore.
            
            Change-Id: I3e93b758fcd7d87f8c37a0ae47ffe39fc794d0c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173482
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1eb2dcf15a752c7732252046795cae445fbc01f9]

        cid#1608289 silence Overflowed constant
        
        Change-Id: Ia42be7ae929767dbb02cecd0f87d6b3a994b8f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [08e9e422fd55bea1d77f1a0df65f6ff4a977778b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 42ecd2971a60e08485dbafbace2f2ed7245cd48c
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ic6577d3caf2dfad168da2a61b78bf2bc26e5d361
            
2024-09-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b72068ba689af7f292eca707df5765fda8109fb5]

        tdf#162990 Colibre (and Dark) SVG: fix unlocked icon and add locked icon
        
        Change-Id: Ic2121cdddc5bafb38b5082f4ba6e6774670a1543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173509
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [344945158b2b9e85eebb8e81c71f4ded90d0d0ed]

        cid#1557158 Unguarded read
        
        Change-Id: If749fd6fd232beaa44162956bd4f1e992d8e976d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-17  Jean-Pierre Ledure  <jp@ledure.be>  [acbbf33d6735ca071859433370a91ad2cdd25392]

        scriptforge.py - improve debugging mode
        
        To facilitate the debugging of the
        ScriptForge Basic code called by the
        python scripts, 2 methods have been
        added to the ScriptForge() class:
        
        - initializeRoot(force = False)
          Initialize the global scriptforge
          data structure.
          - When force = False, only when
            not yet done.
          - When force = True, reinitialize it
            whatever its status.
        
        - errorHandling(standard = True)
          Determine how errors in the ScriptForge
          Basic code are handled. Either
          - the standard mode, i.e. display a "crash" message
            to the user
          - the debugging mode, i.e. the execution stops
            on the line causing the error
        
        Example (cfr. tdf#162962)
        
        from scriptforge import CreateScriptService, ScriptForge
        sf = ScriptForge()
        sf.errorHandling(False)
        
        def testSF():
            srv = CreateScriptService("Calc")
        
        g_exportedScripts = (testSF,)
        
        Change-Id: I25d7d8e36e71d95ff8a04191bb8344794886d69e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173458
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-09-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8b07b631f3294e9357e3ab091ca00af069fb5951]

        -Werror,-Wunused-variable
        
        ...in code newly introduced with 56588663a0fddc005c12afaa7d3f8874d036875f
        "tdf#131728 sw inline heading: fix DOCX paragraph layout interoperability"
        
        Change-Id: I676c7cd1605e7eb94dd56108160a8b841065abee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173465
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-09-17  Noel Grandin  <noelgrandin@gmail.com>  [3b5b421eed8de62d06a1f53a4d7d88c8fe90795d]

        dont use GetItemSurrogates for gathering SvxUnderlineItem
        
        which is very expensive these days
        
        Change-Id: Ia8485f38b7aeb763a49a1acb433e22d1360694e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173513
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-17  Miklos Vajna  <vmiklos@collabora.com>  [a95b90bc0cf0f8a58fc20684acc23bb89b827cd1]

        cool#9992 lok doc sign: fix signature status after load
        
        Load a document, see the 'signaturestatus: 4' callback
        (SignatureState::NOTVALIDATED, "signature is OK, but certificate could
        not be validated"), wait till the view is initialized, notice the
        strange later arriving 'statechanged: .uno:Signature=3' callback, which
        hints that the document was modified, but we're right after load, so
        that should not happen.
        
        I already tried to prevent doc modified status in commit
        654f972a97c374fa90eb3984a44c7f54ddba9c61 (sw lok: make sure author name
        change doesn't mark the doc as modified, 2023-01-16), but this is not
        enough for the doc sign case, where SfxObjectShell::SetModified() ends
        up refreshing the doc title, which calls
        SfxObjectShell::GetDocumentSignatureState() and then caches the wrong
        SignatureState::INVALID state.
        
        Fix the problem by adding a flag to not mark the document as modified
        during "init view" in the first place: that keeps the document unchanged
        after updating fields, but doesn't break the doc sign status.
        
        Now LOK clients get a first 'signaturestatus: 4' on load, and a
        'statechanged: .uno:Signature=4' on initializing the view, which is a
        bit redundant, but at least is consistent.
        
        Change-Id: I42d50525ba96900eeeb927a50f1484c882347b13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173514
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45399721e1497bc9731eacc1b001335ef4314579]

        cid#1607788 Overflowed return value
        
        Change-Id: I302dc99a70ccaa1c995065df5c72202a7c025dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173516
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-17  Michael Stahl  <michael.stahl@allotropia.de>  [9012355a60bd88db582078e38123863a4959b72f]

        tdf#162866 package: fix loading AutoCorrect file with case-insensitive
        
        ... duplicates; the directory names of AutoCorrect entries are
        user-editable, so this needs to be supported.
        
        AutoCorrect uses an ODF package because the ODF document loading code
        requires the ODF document to be in an ODF storage with a MediaType
        property.
        
        AutoCorrect writes an empty mimetype file, and if such is present in an
        .odt file that is being loaded, existing checks will detect it as
        corrupted, so we can use this to check that the file is an AutoCorrect
        file and turn off the case-insensitive check.
        
        (regression from commit 4833f131243bdb409ddfaff8b4db87d4ed2af98f)
        
        Change-Id: I43887f7dad0c8cbb465b4c0f1c38bcc3244a7675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173477
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-17  Michael Stahl  <michael.stahl@allotropia.de>  [eae540e38b3841d88e9102f9977a3ced953d7864]

        sw: fix assert due to invalid nEndPos in SwAutoCorrDoc::ChgAutoCorrWord()
        
        Happens when using a "non-text-only" replacement (which can be created by
        selecting text before opening AutoCorrect dialog).
        
        asserts in SvxAutocorrWordList::WordMatches():
        
          /usr/include/c++/14/string_view:256: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char16_t; _Traits = std::char_traits<char16_t>; const_reference = const char16_t&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
        
        The "IsTextOnly()" branch adjusts nEndPos, clearly it's needed in the
        else branch too.
        
        Change-Id: I442042a5560d8143f1293ac29476aff6e93d7f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173476
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-17  László Németh  <nemeth@numbertext.org>  [857dd6000c877f2c6d8bb73806a8557fa0baea73]

        tdf#161810 sw smart justify: fix overhanging lines containing tabs
        
        Length of tabulator portions wasn't taken into account
        during calculating overhanging lines, resulting missing
        space shrinking.
        
        Regression from commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I34bb007940b91e861b24413e76c910ee62aed158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173451
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [29d6065d9a687f1d86f26f53587e108f8c951a4a]

        sfx2: Synchronously set control state in file picker on all platforms
        
        Unify the handling to initialize the control state
        in `FileDialogHelper_Impl::preExecute` and set the
        state of the controls synchronously (right away)
        for all platforms.
        
        This was already done for Windows and macOS, but
        not for Linux, where this was delayed by doing
        so asynchronously in a user event.
        
        The asynchronous way of doing it was introduced
        in
        
            commit e1d6dc26677c9ef24360cd3b2b40acfc7dee13a0
            Author: Frank Schönheit <fs@openoffice.org>
            Date:   Tue Oct 30 13:12:46 2001 +0000
        
                #93977# do an asynchronous InitControls
        
        and the the comment gives this reason:
        
            // allow for dialog implementations which need to be executed before they return valid values for
            // current filter and such
        
        However, this doesn't work everyhwere, so this
        was already switched back to being synchronous
        for macOS in
        
            commit 420c7215ad52ce0a2fc652c9b537af20c80e86f0
            Author: Kurt Zenker <kz@openoffice.org>
            Date:   Wed Mar 5 15:44:58 2008 +0000
        
                INTEGRATION: CWS aquafilepicker02_DEV300 (1.134.22); FILE MERGED
                2008/02/11 17:38:41 fheckl 1.134.22.2: RESYNC: (1.134-1.138); FILE MERGED
                2008/01/14 08:40:47 fheckl 1.134.22.1: Allowing for corrrect fpicker init on MacOSX
        
        and for Windows in
        
            commit 9ebe7641b7f5f5ceebbe0b2dad73e8bb73997967
            Author: Oliver Bolte <obo@openoffice.org>
            Date:   Fri May 30 10:34:06 2008 +0000
        
                INTEGRATION: CWS hro35_DEV300 (1.142.32); FILE MERGED
                2008/05/26 09:16:01 hro 1.142.32.1: #87244# Dialog initialization sequence has to be done synchronous for modal Vista dialog
        
        . The asnyc way also doesn't work for the Qt-based VCL
        plugins as mentioned in
        
            Change-Id: I9edf65a31f8268feb13fd6abf627744d68fd79e3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Sep 16 14:06:39 2024 +0200
        
                qt: Add "Sign with default certificate" to QtFilePicker
        
        :
        
        > When no signing key is set there, the checkbox currently
        > isn't disabled as expected, but that's a separate issue,
        > also seen with the "Edit filter settings" checkbox that
        > is disabled with gtk3, but not with qt6 independent of this
        > commit.
        
        Unify to set the state synchronously everywhere again, which
        makes the Qt-based VCL plugins work, and also works as
        expected in my tests with the gen and gtk3 VCL
        plugins on Linux, even when locally disabling the
        `CommonFilePickerElementIds::LISTBOX_FILTER` handling in
        `FileDialogHelper_Impl::handleControlStateChanged` for
        testing. (That gets called for these implementations
        when the dialog shows and would otherwise take care of
        setting the proper state as well.)
        
        The gtk4 file dialog currently doesn't shown these checkboxes at
        all, independent of this commit.
        
        Since the first commit mentioned above only
        refers to an issue in the internal StarDivision
        bug tracker, it's not clear on what platform the
        synchronous handling was causing problems in the
        past, but it seems that the issue is gone by now.
        
        Change-Id: I4bbc7f8d03061f9858b2e355b6d1874a0b71adfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173456
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [80b72123c6ed8b6b44a96111234072c2205190f1]

        Update "Sign with default" checkbox in FileDialogHelper_Impl::preExecute
        
            commit 426c641976688e3e4d1ce66f76b27ccbd2dca55a
            Date:   Wed Jul 17 12:47:22 2024 +0200
        
                tdf#159040: add sign with default certificate to save dialog
        
        added a call to `FileDialogHelper_Impl::updateSignByDefault`
        to `FileDialogHelper_Impl::InitControls` that gets asynchronously
        called for non-Windows and non-macOS, see
        `FileDialogHelper_Impl::preExecute`.
        
        Also explicitly call it for the Windows and macOS case, like
        all of the other methods that also get called there in that
        code path.
        
        This makes the "Sign with default certificate" checkbox
        disabled when no GPG key is set up in "Tools" -> "Options"
        -> "User Data" -> "Signing Key" even if commenting the call to
        `FileDialogHelper_Impl::updateSignByDefault`
        in `FileDialogHelper_Impl::handleControlStateChanged`
        on Windows, i.e. the correct state of the checkbox no longer
        depends on an implicit filter change when the dialog
        gets started.
        
        This is mostly in preparation of using the same code
        path for the Qt-based VCL plugins on Linux, where
        no implicity filter changed signal happens and the
        "Sign with default certificate" and "Edit filter settings"
        checkboxes are currently always enabled after
        starting Writer and opening the "Save As" dialog.
        
        Change-Id: Ibc6c2a16dc04f0fe7e41317aeb98ea159e7aec8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173455
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [a6ace3c8d735b7c44d80c98d8fdb94a6bc13ef4a]

        sfx2: Drop duplicate MACOSX check
        
        There since:
        
            commit e103887c8c158e7059a586ef5a5f7b234c547dfe
            Date:   Fri Jan 11 11:07:23 2013 +0200
        
                QUARTZ is equivalent to MACOSX
        
        Change-Id: I34d04913af45c529e01249a5f1a9c5f66b7260b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173454
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [8429fcf97c64f62c158acd7cc29bdff87477ad33]

        qt: Add "Sign with default certificate" to QtFilePicker
        
        Extend `QtFilePicker` to implement the new feature
        added and implemented for other file picker implementations
        in
        
            commit 426c641976688e3e4d1ce66f76b27ccbd2dca55a
            Author: Sarper Akdemir <sarper.akdemir@allotropia.de>
            Date:   Wed Jul 17 12:47:22 2024 +0200
        
                tdf#159040: add sign with default certificate to save dialog
        
        This makes the checkbox show up when opening the
        "Save As" dialog in Writer using Ctrl+Shift+S and
        behaves as expected when a GPG key has previously been
        set in "Tools" -> "Options" -> "User Data"
        -> "Signing Key".
        
        When no signing key is set there, the checkbox currently
        isn't disabled as expected, but that's a separate issue,
        also seen with the "Edit filter settings" checkbox that
        is disabled with gtk3, but not with qt6 independent of this
        commit.
        
        Change-Id: I9edf65a31f8268feb13fd6abf627744d68fd79e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173453
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [25058a278582f3d84d668fe5286a312f06c06290]

        wina11y: Drop CAccValue::GetXInterface
        
        Be consistent and just use the `m_xValue` member directly,
        as is already done elsewhere in the same methods.
        
        Change-Id: I9b7a1e91cbe224115863cde9bb8d4fed14448436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173447
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [857655b1dc092daff4a46bedb3ce4c88cb389c68]

        wina11y: Prefix and rename CAccValue member
        
        Use m_ and x prefixes, as it's a class member and
        a uno::Reference.
        
        Change-Id: I3b345749c256bccb3c6c59b54eed4db8f38c5a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173446
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [5e80fbb94ef291c9e825a9e7927f4e3ae062d885]

        wina11y: Merge CAccComponent{,Base}
        
        Merge the `CAccComponentBase` class into its
        only subclass `CAccComponent`.
        
        While at it, make the `m_xComponent` member
        private, which was previously protected for no reason
        anyway.
        
        Change-Id: I029348c51aefd1b7cdc3db68bac6abc31de15d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173445
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [9ac7d0ae4d9351fed9d3505612c2562bd60a7442]

        wina11y: clang-format AccComponent.h
        
        ... in preparation of merging `CAccComponent`
        and `CAccComponentBase`.
        
        Change-Id: Ic7f436ec1bf1d4cbebfe27e86a29710719a33785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173444
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [730f154090194c88b62551a7ed724f93eda67427]

        wina11y: Drop CAccComponentBase::GetXInterface
        
        Just use the `m_xComponent` member directly, as
        already happens elsewhere in these methods.
        
        Change-Id: I1f3020e568d0d9b29576d0f446dea2f159119880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173443
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [935b17929ed3124f22ed3f1386d0658ba916e4fd]

        wina11y: Use standard naming prefixes in CAccComponentBase
        
        Use an `m_ ` prefix because it's a class member, and `x`
        because it's a uno::Reference.
        
        Change-Id: I084f41f4bca97b39d3bf365dd9025b0a9d145d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173442
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [e20f03372bec243258c01d1098cb185138471cbc]

        wina11y: Drop "//special query" comments
        
        It's unclear to me what these
        
            //special query
        
        comments above the null checks refer to and I
        find them more confusing than helpful.
        
        Remove them.
        
        Change-Id: I3a3d886a664d03ec37085e2f074928c2a3055820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173441
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [397fb1a565199c0de34f373a7287476b8d51c1cb]

        wina11y: Just assign the reference
        
        No need to manually use the pointer, and have
        special handling for an empty Reference.
        
        Change-Id: I414cfdccacecc79594c0bc5b57d782ea98b811fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173440
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [1661ca09a398504cda0698f36a7228ba628afcc7]

        wina11y: Drop unused CAccComponentBase::grabFocus
        
        Accessible's `IAccessibleComponent` interface [1] has no
        `grabFocus` method and `CAccComponentBase::grabFocus`.
        
        Therefore, drop it.
        
        The `IAccessible` interface has an `IAccessible::accSelect`
        method that can be used to request focus by passing the
        `SELFLAG_TAKEFOCUS` flag [3], but that is implemented in
        `CMAccessible::accSelect`.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_component.html#a8709fdbf3f51ae079af274854a8bffd4
        [2] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-accselect
        [3] https://learn.microsoft.com/en-us/windows/win32/winauto/selflag
        
        Change-Id: I1ae99fdbf60aa18a041c086a73f9bd7c6a80cace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173439
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [1c80f3951d8513bef234fd3ae78d5ca23a9f1c54]

        wina11y: Drop unused CAccComponentBase::get_locationOnScreen
        
        While IAccessible's `IAccessibleComponent` interface [1]
        has a `get_locationInParent` method and
        the implementation in `CAccComponent::get_locationInParent`
        calls the base class one,
        `CAccComponentBase::get_locationInParent`, there is no
        `IAccessibleComponent::get_locationOnScreen` equivalent,
        and `CAccComponentBase::get_locationOnScreen` is simply
        unused.
        Therefore, drop it.
        
        The `IAccessible` interface has a `IAccessible::accLocation`
        method to return the location on screen, but that is
        implemented in `CMAccessible::accLocation`.
        
        Therefore, drop
        `CAccComponentBase::get_locationOnScreen`.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_component.html#a8709fdbf3f51ae079af274854a8bffd4
        [2] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-acclocation
        
        Change-Id: I1a38844101b4eca10afdc6356c46156ad2091f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [032cf092f2476ad7e0009274073b467d36c6bd47]

        use more concrete UNO types in sd
        
        Change-Id: I04578521e86759af7fdd6d2d19d8313ed8bc1bf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173457
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [508d1dd7ac4ff2c2c8d0e43343f41e2b4f0b55c5]

        use more concrete UNO types in sd
        
        Change-Id: I9205552d45fb4a77b51419f04256a9d0609823d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173452
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-17  Noel Grandin  <noelgrandin@gmail.com>  [08c58ac51962b65b57c5b76a45467d45807ef02d]

        dont use GetItemSurrogates for gathering SvxColorItem
        
        which is very expensive these days
        
        Change-Id: I26da48f3b29bc3029d359214e0c50fa51e9e2194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173479
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [539856dbb789d23c7904163c85fb72fcc710fbbf]

        Fix formatting of dates
        
        Redression after commit 81e1e0a2a671f19950c1bd3c69f9aa24b0c562e7
        (Refactor SbxValue::Format, 2024-09-13).
        
        Change-Id: Ie7eb50c32f3c1a3aec73fc882dc33cce42734747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173449
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [a462c46b2cdbd072c620c097615f8ec945cd26a6]

        Only call GetViewBindings once
        
        Change-Id: I172937f7f2dd6a9a5b128777ea95271c565f3ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173437
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5eab23392c5c80ae9cf712c4e7fba21cfff02dae]

        Check return value of GetViewBindings
        
        ... as done in all other places where it's called
        
        Change-Id: Ic941cf433e96bb8bfa6ea81c52c044cc424100eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173436
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [7cebd7df0cfcbf906848bfbbdee614fdbd90af8a]

        tdf#162987: check return value of GetViewBindings
        
        Change-Id: Iaeec22ed07e18aa59f2ab87b2ea7d8a0c7ae1467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173435
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [71ea7520ebee3081445be5f0cac80e81247f3e14]

        Related: i#109051 There's no "Exit Let/Get/Set"
        
        Before, these incorrect combinations were allowed, together with
        the correct "Exit Property", which had been implemented in commit
        5ed103d2dd5f8ee2f13183263c0930f84437bdc7 (mib16: contributed
        bugfixes and various new symbols in VBA compatibility
        implementation, 2010-06-15).
        
        Change-Id: Ic132c0860bb04007766977975a6ce9c8887138dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173427
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [196c89fc9da3ea240c27ab433f02a54c48407edd]

        i#109051: also handle Exit Property for Property Set
        
        An omission from commit 5ed103d2dd5f8ee2f13183263c0930f84437bdc7
        (mib16: contributed bugfixes and various new symbols in VBA
        compatibility implementation, 2010-06-15)
        
        Change-Id: I1e08406eb1dcb64eeef5d925d22475f1b9f74de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173426
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7b8ae2bf7cf9d4d637b40030bb9f482f6fba5194]

        tdf#162890 - A11Y sidebar: fix unecceserry warning in case if we have
        
        no any direct format or we have a style which are not applied to the page.
        (In that case no need to show the warning since the 'goto' can lead us nowhere.)
        
        Also check the direct formats by comparing them to the character styles,
        paragraph styles or to the default character properties.
        
        Change-Id: I154379dc6deaa3af3fe17e51367cc229067216dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173317
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-09-17  Oliver Specht  <oliver.specht@cib.de>  [4855bbfa4d0cbc6376ab2a40151886f84fafac40]

        tdf#132274 add zoom defaults to Writer options
        
        Zoom value is sometimes stored at documents. But users
        might prefer local zoom settings over stored values.
        Users are now able to set preferred values in Writer's
        option dialog.
        
        Change-Id: Ia1c3926aac3dd236f15f84d8dc535d8aa3758238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171482
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-09-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [636f853bda69a889146968116b276d88f105b47f]

        tdf#162937 Set default comment position to the right
        
        Change-Id: Ibd665ca861efcf60d382d018b71a6b470792e01b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173387
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-09-16  Adam Seskunas  <adamseskunas@gmail.com>  [3411a334740fcbfd011de09a9381b198c74d47d6]

        tdf#61000 Add Unit test
        
        Change-Id: Ia414dc598145f3648cbd2425dfe5560278888663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173372
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [25b80cd5700c9e6fa19e2cb342eac157681dd601]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 301f67b6b028ba0b0acf0d590c7ced1e4b142356
          - tdf#162607 disambiguate hid2file.js, DistributeColumns
            
            + deleted extra bookmark
            
            Change-Id: I8fd9556ddc3499c8751c2cdafc0236342e17c14f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173475
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [94760087d1ef4b5c9c0e7e4c96df5c27e96a9dc5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9635575ec590d4220326d4f7a8eb7ea7264a14c3
          - tdf#162607 disambiguate hid2file.js, CustomAnimation
            
            + deleted extra bookmark
            
            Change-Id: I753cb1c51f66170621c906a511ef813507ae1407
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173474
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b5bcd1e63e7a694c175f7b38c14391b9d965b4c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cac10e6d59de03039adeedc23b6e703b13318725
          - tdf#162607 disambiguate hid2file.js, Distribute Rows
            
            + deleted extra bookmark
            
            Change-Id: Ic7781ff3e55538f398e407e4d8804034d80aa771
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173473
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6752d3e6568bbd2dcb90628690475594e1a2cb41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 65ae3daf7a941356e6167e70c505ea6ab06cefb6
          - tdf#162607 disambiguate hid2file.js, GridFront
            
            + deleted extra bookmark
            
            Change-Id: I70492349881360ede33affd57b33d4b272f9dce8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173472
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c4267d33509ba16da5c22bc2c29ea0df796bb9b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6914f5c5f29d428a79f221ba02a988ad02b27f88
          - tdf#162607 disambiguate hid2file.js,Grow/Shrink
            
            + deleted extra bookmark in main0202
            
            Change-Id: I6ebfdcc8f5b3f48e6c5c672b7ecd800498fddadc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173471
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b34c7530a178a61f2f21150f59e7ed01571233c2]

        use more concrete UNO types in SwAccessibleContext
        
        Change-Id: I9f4af4ea7faa047dbc44240aa9ac4cff49fe08ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [1793f175e38c774bde774aada28f9e480009ea92]

        use more concrete UNO types in SwAccessibleHyperTextData
        
        Change-Id: Id11b63079ff336026d2994d17b5067e00ca7fa26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173431
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-16  Noel Grandin  <noelgrandin@gmail.com>  [2a5fd3b76c7dcfb53e2f10339d60380863f2de41]

        dont use GetItemSurrogates for gathering SvxBoxItem
        
        which is very expensive these days
        
        Change-Id: I654b85db2c22e95483c369b0aa9fd36f1f7c3849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [995edab80d310981db256bdeff7a183d34d033ab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eac52efacdfd3244f84d1860a8b8fa2fe883de5a
          - Fix some "d'oh! you found a bug!"
            
            Change-Id: I06ef75b8ea07adbbc0c65c1cc45c1a699c162b62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173468
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ada8843ec8afe1eee99a2a1b3d2c58d34268aca6]

        Fix typos
        
        Change-Id: I7b2347682cd5f0c625b0bc35b4f73e259262cc52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173461
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-16  Michael Stahl  <michael.stahl@allotropia.de>  [6e76e8a210e51e7c79e0e845c7a4c0db9fb55abc]

        tdf#162841 package: fix loading AES-GCM encrypted macros from ODF
        
        The problem is that ZipPackageStream::GetEncryptionData() doesn't handle
        the checksum correctly; what is required here is *no checksum* but the
        check of m_oImportedChecksumAlgorithm results in calling
        m_rZipPackage.GetChecksumAlgID() instead, so it ends up in invalid
        situation and assert:
        
          package/source/zippackage/ZipPackageStream.cxx:656: virtual bool ZipPackageStream::saveChild(): Assertion `xEncData->m_nEncAlg != xml::crypto::CipherID::AES_GCM_W3C' failed.
        
        Refactor this so all the imported algorithm identifiers are in a struct
        in a std::optional member.
        
        (regression from commit 09f23a3dc5cd571df347cba9b003195de35f3ddd)
        
        Change-Id: I4b705520cd9bc800ce3c8611f8ad01a1e1008929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173342
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0224b9861c07b93a5fb711392522ef8e3cda4e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f18fea8ff35d803fbce36aee5900379d3f7b5d7
          - tdf#162607 disambiguate hid2file.js,header/footer
            
            + deleted extra bookmark,
            + deleted invalid bookmark (typo)
            + some refactoring
            
            Change-Id: I5e57e96fde34113f47643317db36c0ae4835e133
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173464
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2420aab6465e98f2575a18b605f1f172e4459e1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35ffc7e66df2965e4c52ed54bd028f4ba54e5a28
          - tdf#162607 disambiguate hid2file.js,CMIS setup
            
            + deleted extra bookmark
            
            Change-Id: I5f83beea69bb3814faadbbef2c9e32a82e720a7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173460
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2a7bfe40d0d503c3d51be44e52ca28d50466ca9c]

        tdf#162889 - A11Y sidebar: fix warning does not disappear when
        
        page header is deleted. Check if nodes have contentframe.
        
        Change-Id: Ie7f79cedb577b856d518d23326e9d7ceba2b825c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173215
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [245a20b6093237fc247f9515e37dc70556448812]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f91e9c96f05403874f81d0a273a19a86428e20d
          - tdf#162607 disambiguate hid2file.js, Print preview
            
            + Moved Print Preview and Close Preview to shared/01/print_preview.xhp
            + deleted 01120000.xhp from swriter/01 and scalc/01
            
            Change-Id: I85e7d0c73f1a0f886657f8cabff774c0d3b67606
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173459
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-16  Miklos Vajna  <vmiklos@collabora.com>  [40ba7a5c25f0d2ea90a976d4e7d56b9e61dbedd1]

        cool#9992 lok doc sign: implement signature removal
        
        Open an already signed document, click on the sign icon on the status
        bar, notice how the button to remove a signature is hidden.
        
        This was added in commit 71a8bad4b96627fd965b23288dea14aae3f0f468
        (jsdialog: enable Digital Signatures dialog, 2022-01-24), which exposed
        the signatures dialog as a read-only jsdialog. The dialog was improved
        recently to be a read-write jsdialog, so this is no longer needed.
        
        But then DigitalSignaturesDialog::canRemove() had an inner non-async
        message dialog. Fix that by converting canRemove() to async.
        
        An additional problem could be that the document is not marked as
        modified, so the LOK client code doesn't notice the document is updated
        (to not have a signature), but we do update the last mod timestamp of
        the file, which is meant to be enough.
        
        Change-Id: I8e7ee22e4b1b8ce59dee3617bb2f22f8d734f31d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173428
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-16  Miklos Vajna  <vmiklos@collabora.com>  [6c7500e11f6d0b0f8ddf2fe4c133038915781d16]

        svx: prefix members of XPolygon
        
        See tdf#94879 for motivation.
        
        Change-Id: I7541248dbdc911d07167b0041ec571d877c9572f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173429
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4a2cfa1bf746a4c1d379757c99d35ef5ac42cd3]

        use more concrete UNO types in reportdesign
        
        Change-Id: I688cbfe44cebd95e2321d3b75a2ee397cc4aa4f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Miklos Vajna  <vmiklos@collabora.com>  [63cb8d9ddd6db64e41f66df937f42875637bede5]

        tdf#161876 sfx2 store: refuse to overwrite read-only files
        
        Create a read-only file, try to save-as the current document and select
        the existing read-only file, accept to overwrite it, works fine.
        
        This is a regression from commit
        2157a3536f97ff5ae7c82611a801fef7e3708983 (sfx2 store: try rename before
        copying, 2018-01-09), previously such read-only targets were rejected.
        
        Fix the problem by explicitly checking if the target is writable: if
        not, then avoid the rename optimization, because the fallback path will
        reject the request as expected.
        
        Fix this inside an '#ifdef UNX' block, the problem is reportedly not
        there on Windows.
        
        Change-Id: Ifd8798e07a1be504c6747514a53cfc4ff2338a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173344
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-16  Mike Kaganski  <mike.kaganski@collabora.com>  [40d0e6f4c4ca31f6525b4c84924f2330a166182c]

        tdf#162962: always create a local "Nothing" for the "WITH" variable
        
        Other "WITH" blocks create the symbol that can be found by pPool->Find,
        but can be not accessible at the call site.
        
        Change-Id: I85ecc763a1bb3fd692c2c98e674047fdbde3f8f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173417
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-16  Chris Sherlock  <chris.sherlock79@gmail.com>  [08b62f16a9fb6abcc2b28e1664624cbbc820bf6a]

        tdf#143148 Use pragma once in BitmapAlphaClampFilter.hxx
        
        Change-Id: I45a31288207c0b238351c2cd47e3122e1d381a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173346
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c4eb14b51634b73f61df7803ccc9414b9e143ab]

        Fix typo
        
        Change-Id: I57b3d9e0d160a80074a629880c5b4b7608597745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173434
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-16  Heiko Tietze  <tietze.heiko@gmail.com>  [0a39eb2f583ed25e1ab51a18e2fb3419775d68dc]

        Resolves tdf#162927 - Hiding non-hierarchical styles should not just dim it
        
        Also show hidden styles with normal font color if the view mode
        is not hierarchical
        
        Change-Id: I4cc5ca7441294302b3e751c5fa49a2f3579b3c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173334
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50ee38cffa133e10f0e852ff79bf911fbbfe28b7]

        cid#1607161 Overflowed constant
        
        make this an assert, it will crash and burn anyway if its not > 0
        
        Change-Id: Id4780efbae45e984a162df182c3297536546bf04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [31c8213d066678ba0bd00e322689ad5d27ee6183]

        cid#1606833 Overflowed constant
        
        Change-Id: Ie104c67f2bc796babee3bc9823f25cc3850b19c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173424
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [281596e7324fbf1f5e16245382cfddae2df18a8d]

        cid#1606823 silence Overflowed constant
        
        Change-Id: I0ca0556b75e258ba89271c3cb428b267976bfb09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173423
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30be1d807d4e1fbec73d92d7740490b69e0bb751]

        cid#1607350 Data race condition
        
        Change-Id: Ibd30f03513661762613cc0b386acc48eb994bc2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173422
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [44e1bc0f0eff27846703c697fc45c67e46922881]

        cid#1554972 silence Check of thread-shared field evades lock acquisition
        
        these are protected by SolarMutex so its not actually an issue
        
        Change-Id: Ief887abf12093afeaa1c6a2182c45f727e0c6a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e4db0815d35e680d9defa2af6eb58f4bf38f1dbc]

        cid#1607658 silence Overflowed constant
        
        Change-Id: I1faf0147d9013e8fdab4968ab603b71be4728960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173420
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [38d8896b7366100bc0f8623306fd95068dacedc0]

        cid#1557316 Unguarded read
        
        Change-Id: I8befd0a4442cba88ed308a9ef296e995ba8ed53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173419
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3852449a5eedf2c4d2dbc00b5403e810708e28ae]

        cid#1619429 Dereference null return value
        
        Change-Id: I831952ac99f94296485f8bfaa9aaa84540f86a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173418
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d774c231f7564b5fde645ef1ba526c77376f0aa8]

        use more concrete UNO types in sfx2
        
        Change-Id: I2012b2df46b546118f4604b77e1efd5f74dfece5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173411
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb44989385113a20a0d45ca59a1457a4d16eaef0]

        use more concrete UNO types in sw
        
        Change-Id: I2650eff8bd5bb222c123255a7e3cb4aa3c36fc10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fb7f81c7e543f5b9b38aa1bc118e1f07046ce4c]

        use more concrete UNO types in sd
        
        Change-Id: Ia8d04372662af5fb6234be87403daa48a6d41390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173414
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2f6a5df1e8bcedc2dc675573ada5eb426867dbb]

        use more concrete UNO types in sc
        
        Change-Id: I2da6016abf4c7302a725fa4e3b413296a70035a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173413
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd53efb7917540c5f3b85957ed56a767c258e89a]

        use more concrete UNO types in unoxml
        
        Change-Id: I50e22d15e02bde4c0e97c89b42fe3399d7a1dfe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173412
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [daba3bc2344a42e6f0a3796735a2f1f7d7063162]

        use more concrete UNO types in forms
        
        Change-Id: I2e8bbea33be2ac62692230e5da4bb4c748bae73c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [26cc060303b98a64daf2c71457811241dc4a0b45]

        tdf#162524 Remove themself from autocorrect lists
        
        Style guides such as Chicago Manual of Style have accepted its use
        in the context of gender-neutral "they".
        
        Change-Id: I9f25430c92f1167fb1a2c5dbf7314ce23f5ce4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173246
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [122493e9a0118a5b7412423c5e72ed8a1610a948]

        tdf#162952 Fix regex example in tip of the day
        
        Change-Id: If19fec6f58b8944096e6a6beb9f53916a80bf453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173375
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-16  Sohrab Kazak  <sohrab.kazak@gmail.com>  [7109e1ea64a12e74d5e9a1b00cfbd447d61e8e61]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I58a82179181cc1f783fc40b146c09668508a8883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173149
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [905e7c1105536c9757fa2c2faf670738aab02595]

        ofz#71606 don't ignore CRCs when fuzzing
        
        got a case similar to
        
        https://github.com/pnggroup/libpng/issues/587
        
        with a backtrace of:
        
        /work/workdir/UnpackedTarball/libpng/png.c:1475:23: runtime error: signed integer overflow: -1703155269 - 692774662 cannot be represented in type 'png_fixed_point' (aka 'int')
         #0 0x59bbf901eab0 in png_XYZ_from_xy /work/workdir/UnpackedTarball/libpng/png.c:1475:23
         #1 0x59bbf901eab0 in png_colorspace_check_xy /work/workdir/UnpackedTarball/libpng/png.c:1610:13
         #2 0x59bbf901d8bc in png_colorspace_set_chromaticities /work/workdir/UnpackedTarball/libpng/png.c:1717:12
         #3 0x59bbf9046855 in png_handle_cHRM /work/workdir/UnpackedTarball/libpng/pngrutil.c:1302:10
         #4 0x59bbf902d064 in png_read_info /work/workdir/UnpackedTarball/libpng/pngread.c:175:10
         #5 0x59bbf7c331d6 in (anonymous namespace)::reader(SvStream&, Graphic&, GraphicFilterImportFlags, BitmapScopedWriteAccess*, BitmapScopedWriteAccess*) /src/libreoffice/vcl/source/filter/png/PngImageReader.cxx:404:5
         #6 0x59bbf7c36960 in read /src/libreoffice/vcl/source/filter/png/PngImageReader.cxx:845:55
         #7 0x59bbf7c36960 in vcl::PngImageReader::read() /src/libreoffice/vcl/source/filter/png/PngImageReader.cxx:850:5
         #8 0x59bbf786fe57 in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/pngfuzzer.cxx:52:19
        
        (gdb) print *xy
        $1 = {
          redx = 9,
          redy = 131616,
          greenx = 598048,
          greeny = 538976288,
          bluex = 0,
          bluey = 151551,
          whitex = 538976288,
          whitey = 538976288
        }
        
        but not reproducible with a typical utility because we're unusually
        ignoring crc errors for fuzzing so reenable those and see if a testcase
        can be generated anyway.
        
        Change-Id: Ifc050ee082800906b087609154ec29ca39cd8fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173409
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [089640feca921f7838debed120b2f7c2c9458158]

        null deref in SwXTextDocument::initializeForTiledRendering
        
         #0  SwDocShell::GetWrtShell (this=0x0) at sw/inc/docsh.hxx:226
         #1  SwXTextDocument::initializeForTiledRendering(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
             at sw/source/uibase/uno/unotxdoc.cxx:3634
         #2  0x00007f6bb1d40734 in doc_initializeForRendering () at include/com/sun/star/uno/Type.h:163
         #3  0x00000000005d7988 in lok::Document::initializeForRendering (
             pArguments=0x342d0e48 "{\".uno:Author\":{\"type\":\"string\",\"value\":\"1（访客）\"},\".uno:ChangeTheme\":{\"type\":\"string\",\"value\":\"Light\"},\".uno:InvertBackground\":{\"type\":\"string\",\"value\":\"Light\"}}", this=<optimized out>) at /home/collabora/jenkins/workspace/package_cool_24.04_rpm/rpmbuild/BUILD/coolwsd-24.04.7.2snapshot/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:245
         #4  Document::load(std::shared_ptr<ChildSession> const&, std::string const&) () at kit/Kit.cpp:1949
         #5  0x00000000005da3b2 in Document::onLoad(std::string const&, std::string const&, std::string const&) () at kit/Kit.cpp:1226
         #6  0x000000000057f7c1 in ChildSession::loadDocument(StringVector const&) () at kit/ChildSession.cpp:906
         #7  0x0000000000586464 in ChildSession::_handleInput(char const*, int) () at kit/ChildSession.cpp:298
         #8  0x0000000000613e48 in Session::handleMessage(std::vector<char, std::allocator<char> > const&) () at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:987
         #9  0x00000000005c67ac in Document::forwardToChild(std::string const&, std::vector<char, std::allocator<char> > const&) () at kit/Kit.cpp:2052
         #10 0x00000000005c7b29 in Document::drainQueue() () at kit/Kit.cpp:2279
         #11 0x00000000005c80d8 in KitSocketPoll::drainQueue (this=0x34316d30) at kit/Kit.cpp:2676
        
        Change-Id: I6f18f1a542ca96fe3fda0248e15ee1254eb9ca95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-15  Laurent Balland  <laurent.balland@mailo.fr>  [735ca7328e2303ff39523f75b59547bd356e33a0]

        Blueprint Plans Impress template SVG background
        
        Replace PNG background images by SVG pictures.
        Now background can be modified: right clic on picture > Break
        Move and resize any element of the picture
        
        Credit Rizmut for SVG pictures
        
        Change-Id: I4b1db5d1652ef8b400ab98d5f0d705c5e12396a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173408
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [53325c4e54dba494d5e3e812a5e59b00aa935d5b]

        use more concrete UNO types in filter
        
        Change-Id: I5b50a5a3f9e6876717c9ec1579761d137bd54d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173384
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [827c1fd17755262c8b3aa0621be5e3b51afc0131]

        use more concrete UNO types in fpicker
        
        Change-Id: I1596b36b9dc2cb8d2987ec481ce997c7a935fc10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-15  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [60bbbd5593b81d9211375ac3841e2b2e20b6c93d]

        Writer View options: Right-aligned should be disabled,
        
        if Vertical ruler is unchecked.
        
        Regression since
        
        commit 745c7bce5fe8b218f7d300667a5409bc7ef58c34
        Author: Mihály Palenik <palenik.mihaly@gmail.com>
        Date:   Thu Aug 6 15:16:41 2015 +0200
        
        Delete unnecessary writer options from Options dialog
        
        Change-Id: I17096e87f83dfd831599d316495c58ac08927895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173407
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [e877d6ae742bda366336c9b6749c799508d68359]

        use more concrete UNO types in dbaccess
        
        Change-Id: I6cb15b347dae28878110f76064645095d5771e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-15  Laurent Balland  <laurent.balland@mailo.fr>  [2c88a374e2ade4e8614c210195415ad0e4078e4e]

        tdf#162878 YellowIdea template: autosize for title
        
        With other languages than English, texts for placeholders ("Click to add
        Title") may be be much longer and overlap on other placeholders, which
        looks ugly.
        This change adds
         draw:auto-grow-height="false" draw:fit-to-size="false" style:shrink-to-fit="true"
        to titles and subtitles to avoid overlaping
        
        Change-Id: If5bbf6889ebae6cc99982f58c23b577e8a365c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173368
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-15  Laurent Balland  <laurent.balland@mailo.fr>  [aa803323a6309c28188039031606fd5620c8c105]

        tdf#162878 Grey Elegant template: autosize for title
        
        With other languages than English, texts for placeholders ("Click to add
        Title") may be be much longer and overlap on other placeholders, which
        looks ugly.
        This change adds
         draw:auto-grow-height="false" draw:fit-to-size="false" style:shrink-to-fit="true"
        to titles and subtitles to avoid overlaping
        
        Change-Id: I9a8cf4027e1793bf881795a1d31fb926d94d9704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173366
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [8896b00efb8a8c455caef04c1bb1d3ec94348b80]

        tdf#162911: autocorrect: Add unittest
        
        Change-Id: I292ec05871abf3c5e07897a8f3ff642f00ef444f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173376
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-15  László Németh  <nemeth@numbertext.org>  [56588663a0fddc005c12afaa7d3f8874d036875f]

        tdf#131728 sw inline heading: fix DOCX paragraph layout interoperability
        
        Fix layout of paragraph – which contains two paragraph styles –
        by importing OOXML style separator using a text frame.
        
        Inline headings – where there is no paragraph break after
        the heading, i.e. it's followed by the normal paragraph content –
        specified by w:specVanish in OOXML, i.e. a special paragraph with
        hidden paragraph mark. These headings were loaded as normal, separated
        paragraphs, breaking the paragraph layout with their paragraph breaks.
        Map inline headings to inline ODF text frames to keep paragraph layout.
        The frame contains the original inline paragraph, still keeping
        ODF ToC and PDF bookmark support.
        
        Change-Id: I370245218b860c737e45dc15c6f29d79819c9783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173326
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-09-15  Laurent Balland  <laurent.balland@mailo.fr>  [082d15982c4dd2bebb6ab3b95fd0febaf06792c9]

        tdf#162878 Candy template: auto for titles
        
        With other languages than English, texts for placeholders ("Click to add
        Title") may be be much longer and overlap on other placeholders, which
        looks ugly.
        This change adds
         draw:auto-grow-height="false" draw:fit-to-size="false" style:shrink-to-fit="true"
        to titles and subtitles to avoid overlaping
        + remove duplicates of Notes styles in content.xml
        + enlarge placeholders in slide 2
        
        Change-Id: I428cf2c8e9887e7f65ad0a39801e0b1c27cd39de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173359
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [61deab29ca5d792aeea2201010481b7219913c21]

        Avoid nedless buffer initialization
        
        Not possible yet to use std::make_unique_for_overwrite, baseline
        compiler versions are not ready.
        
        Change-Id: Ie14ac5210fa63dcdc7755bb8c722800a877acd44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173381
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7d30c7b93848f46f6ba3bfee7e93b12ac75af6a6]

        cid#1607343 silence Overflowed constant
        
        and
        
        cid#1607447 Overflowed constant
        
        Change-Id: If9be20f1e6a42343844c887c1e16d4c066ff3949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173365
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [71ab742c8e36dc10b2dbccfb3bacbffbfaed1178]

        cid#1606633 Overflowed constant
        
        just return early on this failure
        
        Change-Id: I0f8d1455e5349af0604818db1a519f2147d51f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [29339e2d13e0d6798c8b48d2a17786101538296a]

        Related: cid#1608226 make this more direct
        
        Change-Id: I255d70adf055e36c722b0cd52b7843a878eb9a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173379
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [90cac13b13da5688f7e7724ef36fe54bf36b9120]

        crashtesting: null-deref on loading fdo36711-1.doc
        
        since:
        
        commit d6f2f115c721e0b8337679472e1e106a998a62d4
        CommitDate: Mon Sep 9 11:09:52 2024 +0200
        
            tdf#162268: Import - add zero width space after line break
        
        Change-Id: I452844682cd29352c2a556cca7acd8104fd2bd16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92ab4166ecc74eff8675e7da319c3249e8c285d0]

        Resolves: tdf#162958 When using formula with Impress Style is lost
        
        regression since:
        
        commit 125cf1525361c6cd699574f60b4cf12868188568
        CommitDate: Thu Sep 7 08:54:56 2023 +0200
        
            add referer to ole objects
        
        where these service names changed there should be listed here too
        so they get the same post-create setup they do on the bare
        "no-argument" route.
        
        Change-Id: I21fb9a92f63cac46e4a0fd46f7c2b8d2956ec829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173377
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [698ae0fc16bcfecb2772ea61019df0a45ccfe0e1]

        Related: ofz#71490 replace reserve with resize
        
        when we are going to write to data()
        
        Change-Id: I1412849911d7bbb990a5f0d712f3ac51a5fea163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173373
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [1091e04fbd04b18a9fff3e0ead004fa4c843caf5]

        Simplify use of connectivity::OConnectionWrapper
        
        Make it use cppu::WeakComponentImplHelper, because all its derived
        classes used that template. In the derived classes, switch to use
        of cppu::ImplInheritanceHelper. That simplifies the hierarchy, and
        doesn't require to re-implement many basic methods.
        
        Change-Id: I40ec05a471af4437098586d20540f9a815677952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173370
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6be4ec010bd5e9fc15a423ad3c5ec39b07f305e]

        ofz#71490 Container-overflow in SvMemoryStream::GetData
        
        since:
        
        commit a6ad198d097fb4a503c8d5831d484ff46721134b
        CommitDate: Tue Aug 27 09:10:04 2024 +0200
        
            tdf#158556 use more comphelper::ByteReader
        
        reserve doesn't make any guarantees about validity of subsequent data()
        
        Change-Id: Ifb155b349b15103c367d841bbef7d5d0e2cbb5f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173371
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92e3c25d4829e1680bfa798f5ff3aeadd19398f7]

        cid#1619417 silence Arguments in wrong order
        
        Change-Id: I9a3acd50b7938325cb9c7cf68b6f435545461e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173362
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-14  Heiko Tietze  <tietze.heiko@gmail.com>  [dbd851c35720ac6f0ebea8a212fa54e79259e36c]

        Resolves tdf#33714 - Option to disable "only active sheet"
        
        Based on work by Martin van Zijl in I5f5b65b132d91beb24aa6e9282390dead235d849
        
        Change-Id: Ie4543a2fc4b52715b5d87783a57e982c20274114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173220
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6227476c81a4f2e53259d7ff32fd4cd9e81ee6b5]

        use more concrete UNO type in SwAccessibleEvent_Impl
        
        Change-Id: I8785016caed0d56c50eceb3611091fffdc2a353e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173358
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [df87686917376179de937c824396d236a02eba7a]

        use more concrete UNO type in CDocument
        
        Change-Id: Ifd7306ab7219d940c55b3cc1054f65f64141616e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173352
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [b8401506b5643979566a67c74a2388b1723d92c9]

        use more concrete UNO type in SwXCellRange
        
        Change-Id: I177f37127a7856ade21b0ace4c93121000967cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [dc5fac0c88f365ad55f539a4552de9ed7fb705dc]

        qt: Use modern connect syntax in QtInstance
        
        Change-Id: I3126ca571e8120797ca9d61da6a902398f57b337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173349
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [247fa8af6ce0ba8138e733f97ff6ec4a577c4692]

        qt: QtFilePicker: Use modern connect syntax, port from deprecated signal
        
        Use modern connect syntax and address the warning about
        the use of a deprecated signal that this revealed:
        
        `QCheckBox::checkStateChanged` was introduced in Qt 6.7 [1]
        and `QCheckBox::stateChanged` was deprecated in Qt 6.9 [2].
        
            In file included from .../libreoffice/vcl/qt6/QtFilePicker.cxx:10:
            .../libreoffice/vcl/qt6/../qt5/QtFilePicker.cxx:693:44: error: 'stateChanged' is deprecated: Use checkStateChanged() instead [-Werror,-Wdeprecated-declarations]
              693 |             connect(pCheckbox, &QCheckBox::stateChanged, this,
                  |                                            ^
            .../qt5/qtbase/src/widgets/widgets/qcheckbox.h:40:19: note: 'stateChanged' has been explicitly marked deprecated here
               40 |     QT_MOC_COMPAT QT_DEPRECATED_VERSION_X_6_9("Use checkStateChanged() instead")
                  |                   ^
            .../qt5/qtbase/src/corelib/global/qtdeprecationmarkers.h:179:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_9'
              179 | # define QT_DEPRECATED_VERSION_X_6_9(text) QT_DEPRECATED_X(text)
                  |                                            ^
            .../qt5/qtbase/src/corelib/global/qtdeprecationmarkers.h:29:33: note: expanded from macro 'QT_DEPRECATED_X'
               29 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
                  |                                 ^
            .../qt5/qtbase/src/corelib/global/qcompilerdetection.h:1004:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
             1004 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
        
        [1] https://doc.qt.io/qt-6/qcheckbox.html#checkStateChanged
        [2] https://doc.qt.io/qt-6/qcheckbox-obsolete.html#stateChanged
        
        Change-Id: I0787b378855009abea740a0f5c1aab537c41987e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173348
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [9005798c6249008a1dacae467e47f174d48f8de2]

        qt: Use modern connect syntax in QTimer
        
        Change-Id: Ic4a6c64de834b133a2708807d45c39d6ada4a00c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173347
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [c14db753bec1a44068b71940a603b1e9b05003b4]

        qt: Use nullptr instead of Q_NULLPTR
        
        There's no reason to use that macro.
        As the doc says [1]:
        
        > /* * Compatibility macros for C++11/14 keywords and expressions.
        >  * Don't use in new code and port away whenever you have a chance.
        >  */
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qcompilerdetection.h?id=07749de7ef59827a2deb2719cd20208bdce201e2#n935
        
        Change-Id: I93ef0ae34a737a6ff93270f52ba308bd90bfc505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173343
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3afc0e38bb00cc69dd199663f15bacce1dd792d]

        remove OSubComponent from OConnection
        
        which attempts to implement a very dodgy and almost but not actually
        thread-safe dispose function. Rather just hold a weak reference to the
        data source that created us.
        
        Change-Id: I431bb43aef1d6ce92d7987e7d731b724b64a9767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [b20e79494c8e7627e941343b0acc3dd74df6cb75]

        use more concrete UNO type in DOM::CElementListImpl
        
        Change-Id: I5a480714fc85d623e524e7862e90e76cd65b5c0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173351
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee6de54dde08a607ea3590804436678ee6363f7e]

        use more concrete UNO types in svx
        
        Change-Id: I55fd67a66067f0c4f43ef182101c8d72a22fe3f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173325
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [79c586220b2a843ff7c7b458f507d4c1d549d331]

        use more concrete UNO type in SwXDocumentIndex
        
        Change-Id: I502c37a0d3ac27896e2b9237ade0c285933c922a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173356
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [05fd239f277fe6236a9cc7474959f60557404813]

        use more concrete UNO type in vba::ColumnsEnumWrapper
        
        Change-Id: Ie674fdb503e49d465a13eca9afdca9fc5c7e7eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173353
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [78267fd98f7d85a9280e7765f303ed0bf25ae03d]

        use more concrete UNO type in SwXTextTable
        
        Change-Id: I5db405a6da6bd9820b3e3f09fb89eb5f7ece1bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173355
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-14  Jim Raykowski  <raykowj@gmail.com>  [fb39ae1bc7e4b1cbfc3108efca52ec310faf7363]

        Resolves tdf#133041 New list style is not added back after
        
        undoing and then redoing it
        
        by following the approach used by commit
        c4d82fc21c5e155472f6a30244b3fce806ada85c
        
        Change-Id: I09c877aecdcf49d4be5451e247bf1010856c2d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173312
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [b383d43feb8ad3c779d93a1aec49dd1f3fa327fd]

        sc: fix revert conflict
        
        After 27be65a7d5326608f75839e3964ac322e88224a1
        "tdf#162938: Revert "tdf#61313 Replace the static ">="..."
        
        I saw it right after I clicked the submit button :|
        
        Change-Id: I8a1abf583714c288e6d6ed2c42615d333527e6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173328
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8de7794d048b5e7e977370b6d1345e5a36d4878]

        use more concrete UNO type in librdf_NamedGraph
        
        Change-Id: I97b8965bc73923c35aa086e10bfef081a263de58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-13  Julien Nabet  <serval2412@yahoo.fr>  [396f396a5b9220031982c8b3c26e34806450d074]

        Fix regression from 27be65a7d5326608f75839e3964ac322e88224a1^!
        
        Crash when:
        - open https://bugs.documentfoundation.org/attachment.cgi?id=196417
        - select a cell with icon
        - Format/Conditional/Icon Set...
        => popup dialog with message which at the end proposes "No" or "Yes"
        - Click "No"
        => Crash with bt:
        0  0x00007f35e28acb66 in ScIconSetFrmtDataEntry::SetFirstEntry (this=0x55b37f0244d0) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1357
        1  0x00007f35e28ad4cc in ScIconSetFrmtEntry::IconSetTypeHdl (this=0x55b37ee14940) at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1422
        2  0x00007f35e28ad1ac in ScIconSetFrmtEntry::ScIconSetFrmtEntry (this=0x55b37ee14940, pParent=0x55b37ad5a4e0, pDoc=0x55b37ae30350, rPos=..., pFormat=0x0)
           at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlgentry.cxx:1391
        3  0x00007f35e289185d in ScCondFormatList::init (this=0x55b37ad5a4e0, rDoc=..., pFormat=0x0, rRanges=..., rPos=..., eType=condformat::dialog::ICONSET)
           at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:117
        4  0x00007f35e2894ef0 in ScCondFormatDlg::ScCondFormatDlg
           (this=0x55b37eed53b0, pB=0x55b37ae6fd50, pCW=0x55b37ef0eb00, pParent=0x55b37af94cc8, pViewData=0x55b37b17c160, rItem=std::shared_ptr<ScCondFormatDlgData> (use count 2, weak count 0) = {...})
           at /home/julien/lo/libreoffice/sc/source/ui/condformat/condformatdlg.cxx:479
        
        Change-Id: Ifd79edd1fe04ebbf50fd736989e5dd787cf91aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173338
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3adfdb2d93f7ee1f7559bcec1e0461f840a4a6e]

        tdf#162798: python3: Add lib/importlib/readers.py
        
        Somehow I missed to add it in a1295cb177295752f8cbfbb49e13d5bb69ed7dc7
        "python: upgrade to 3.10.14 (master only)"
        
        Change-Id: I53e5fa6b89a7ac799041fd28ef4c2558df9743e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173323
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [451a66438a58505d2e89e76c7559a9dac1bbc00e]

        use more concrete UNO types in chart2
        
        Change-Id: Id2d58ad76b6e8ff569bd7b65f86a7fdd0152f3d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-13  Michael Weghorn  <m.weghorn@posteo.de>  [366dec115e3805e50071c39da2cf847b99aa8f7a]

        tdf#161444 sc a11y: Send focused event when switching sheets
        
        When switching to another spreadsheet table
        in Calc (e.g. using Ctrl+Tab or Ctrl+PageUp),
        send an `AccessibleEventId::STATE_CHANGED`
        for the `FOCUSED` state of the newly active/focused
        sheet before sending an `ACTIVE_DESCENDANT_CHANGED`
        event for the currently active cell in that sheet.
        
        Call `ScAccessibleSpreadsheet::GotFocus`
        instead of `ScAccessibleSpreadsheet::FireFirstCellFocus`
        to achieve that, which takes care of both events.
        
        With that in place, the corresponding events when
        using the gtk3 VCL plugin now are shown as expected
        in Accerciser's event monitor:
        
            86.3 object:children-changed:remove(0, 0, [table | Sheet Sheet2])
                    source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets]
                    application: [application | soffice]
            86.3 object:children-changed:add(0, 0, [table | Sheet Sheet3])
                    source: [document spreadsheet | Untitled 1 - LibreOfficeDev Spreadsheets]
                    application: [application | soffice]
            86.3 object:state-changed:focused(1, 0, 0)
                    source: [table | Sheet Sheet3]
                    application: [application | soffice]
            86.3 object:active-descendant-changed(212998, 0, [table cell | G14])
                    source: [table | Sheet Sheet3]
                    application: [application | soffice]
        
        This however still doesn't make Orca as of commit
        6f6e0f79ff5d8669591c7c19ecdaca5ec45ab67d, i.e. the
        commit prior to the Orca-side workaround [1]
        
            commit 4ead75fdaebdde60535cfbadca108ccaeeeb9401
            Author: Joanmarie Diggs <jdiggs@igalia.com>
            Date:   Thu Sep 12 19:56:48 2024 +0200
        
                Hack around https://bugs.documentfoundation.org/show_bug.cgi?id=161444
        
                Because removing workarounds is regressing the end user experience,
                add the following hack: When we receive an active descendant event
                from LO, and the event source is not an ancestor of the current focus:
        
                1. Silently set the locus of focus to the parent of the event source.
                   Otherwise we'll be super chatty in response to the next item.
                2. Non-silently set the locus of focus to the event source. This will
                   cause us to present the sheet name.
                3. Allow the default script to do its thing which will set the locus
                   of focus to the cell with the common ancestor being the table and
                   thus it will not be double-spoken.
        
        speak the newly active sheet before announcing the
        cell, but still requires further changes on Orca side,
        s. discussion in tdf#161444 and attached Orca diff there.
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/commit/4ead75fdaebdde60535cfbadca108ccaeeeb9401
        
        Change-Id: I699258ba395dd212fa45c7d1546b26a7c241db97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173331
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-13  Michael Stahl  <michael.stahl@allotropia.de>  [15e238757a5f0bd0076eda7046ceddfc5d4db284]

        package: m_nMagicalHackSize appears superfluous
        
        Change-Id: Idc32af25b7835b04b777a2a0767e1982d074f6d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173322
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-13  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [fcb7bb06bdef712cf59874a60e6dd105ac452596]

        ITEM: adapt SfxPoolItemHolder::operator=
        
        I formally tried to avoid un/re-register if Item needs
        surrogate support, but there are more aspects to this,
        e.g. the pool could be different or even the WhichID
        of the Item, so just do the necessary here. These cases
        are also not too often used.
        
        Change-Id: I8d1e8854f5ce3cac5566c076797162ba2e4b4b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173329
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-13  Michael Stahl  <michael.stahl@allotropia.de>  [524461f8080793ac7d7dc282c0dd52551e556d30]

        tdf#162911 sw: add an assert not to use default items
        
        Change-Id: I6234b132bb741a3910a4a3f9a11efc0e3340fb21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173321
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-13  Jean-Pierre Ledure  <jp@ledure.be>  [0419b8c8f9803e23cdd940107d1b78d641f7767c]

        scriptforge.py Connect via pipe
        
        Python scripts using ScriptForge start like:
           from scriptforge import CreateScriptService, \
                   ScriptForge
           ScriptForge(...)		(*)
           sv = CreateScriptService(...)
        
        The (*) statement has next syntaxes: either
           (1)   ScriptForge()
           (2)   ScriptForge(host: str = ..., port: int = ...)
           (3)   ScriptForge(pipe: str = ...)
        
        Syntax (1) is implicit at the first invocation of
        CreateScriptService() without a former call to
        ScriptForge()
        
        Syntax (2) exists in previous versions.
        
        This commit implements syntax (3) to connect a Python
        process to a LO process on the same system via a pipe
        mechanism.
        
        The change impacts only Python scripts.
        
        The documentation should be upgraded to include
        the new functionality.
        
        Change-Id: I50457b6fffc8c9d6a9ad5c5289de1c363c6680e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173252
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-09-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [51f25098302e738a7d256620bd8e13bace8d060e]

        Resolves: tdf#162455 svg->curve causes text in objects to disappear
        
        Rather than assuming there is a uniform unchanging MapMode scaling,
        follow the same pattern as SVGWriter and map positions/sizes back
        relative to the original MapMode.
        
        Examples of #i119125#, tdf#162455 and tdf#160625 work
        
        Change-Id: I8229cebee6173fa4905828afb3b973c80ede3315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d22d47e940da3bea13fe20199b5ab410d9d6ac50]

        ofz: 22 byte .zip is min size
        
        at which point nPos is 0 on entering this test.
        
        If the buffer does not start with PK\x5\x6 then nPos is decremented
        before checking against 0, so nPos is -1 and doesn't throw as an
        unhandled .zip.
        
        Change-Id: I4a7fed6e863582324945a75bc077f6346ddd5c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173208
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [dff484283dcd562f60840fb9800800187c013b87]

        use more concrete UNO types in dbaccess
        
        Change-Id: I017d4fd7131735dfd2dba6e1b046fbe691522745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-13  Mohit Marathe  <mohitmarathe@proton.me>  [c1936307755ae75741c91f89f9bda3a4eed1a274]

        sort comments by time or position
        
        Change-Id: I1f4014e20b4baaca0dde742e7384397c1311f926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170492
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-09-13  Mohit Marathe  <mohitmarathe@proton.me>  [be16c6cf5c14c17ec3e7d860636e5c7b2cd7f654]

        sw: add Comments Panel in sidebar
        
        This commit adds a sidebar deck for comments.
        It has all the functionalities of the old comments
        shown via annotation window.
        
        Change-Id: Ibab0e21a54c097d0f42bddb1d07da74319970135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167840
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [59c123d62a7d155e0b5715e5d1804f2a0cee77fa]

        ICU: fix aclocal dependency
        
        Patch configure directly instead of configure.ac
        
        Change-Id: Iaaf3e10dc435d5d8f546c009b27c9a4aa7c09141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173315
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-13  Michael Stahl  <michael.stahl@allotropia.de>  [33d55465d9f81863b88d649a46353cc4d19cd253]

        tdf#162823 package: fix loss of ODF encrypted basic macros
        
        The problem is that there is a ZipEntry ZipPackageStream::aEntry which
        does not necessarily correspond to the values read from the Zip central
        directory, because of a call to ZipPackageStream::setSize() in
        ZipPackageStream::successfullyWritten() to override nSize and nMethod
        for encrypted entries.
        
        This triggers the consistency checks in readLOC(), where this aEntry is
        passed.
        
        Refactor things so that ZipPackageStream::aEntry and thus hopefully all
        ZipEntry instances correspond to the Zip file's central directory.
        
        For encrypted entries, store the decompressed size (which is read from
        manifest.xml) in m_nOwnStreamOrigSize and pass it as a separate
        parameter to the ZipFile functions that need it, and ultimately to
        XUnbufferedStream, resolving multiple TODO comments.
        
        (regression from commit efae4fc42d5fe3c0a69757226f38efc10d101194)
        
        Change-Id: Ib6ea32595c6027b98da9196a2e2bd0a99b62a983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173273
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25c9a3e9a5b8c3ea02210271a789f9ebfa90352a]

        add a comment of an example where this dialog appears
        
        Change-Id: Icca2eb703b9fd926e7145822e9671c23c6e83356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173316
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [27be65a7d5326608f75839e3964ac322e88224a1]

        tdf#162938: Revert "tdf#61313 Replace the static ">="...
        
        ... with a dropdown of different operators"
        
        Why was this patch submitted in the first place?
        It added a call to convertToOldCondFormat in testTdf101104,
        testComplexIconSetsXLSX and testTdf64401 to make those tests
        pass but the issue was already reproducible with those files
        
        This reverts commit fcc5770dd1e33dcb4f4f0c28683569af5d1d8368.
        
        Change-Id: Ifd8904de26d39d23e52ec2188d917bec34ad93b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173310
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [0874f235e6779317ae215c438b6e642694b40af1]

        vcl: move variables closer to first usage in BitmapEmbossGreyFilter::execute()
        
        Change-Id: I711b82e2c86035aa1bfbb245c125be65277043f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173198
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [dc451a30d4a42dcf7bc7f3a9b42721aa9d0dbd43]

        vcl: just return a BitmapEx() in BitmapDisabledImageFilter::execute()
        
        Change-Id: I2a257211d7fdf22abb8d6e1f994293873348b38e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173191
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [8f6f57e126c8e44f23fde6d35f027214a3fd557b]

        tdf#43157 vcl: remove OSL_ENSURE from BitmapEx functions
        
        Change-Id: I8232751174dccc55139ab4878950636c32b1d6a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173199
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-09-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e5ef04874a73d87bc66578b73b44ca3e3a0e76ee]

        UBSan CppunitTest_editeng_borderline etc. need more RTTI now
        
        ...presumably since 5ba893dfb8838b0ef946b52de9ef1336d2ab0512 "use more concrete
        UNO type in editeng",
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_editeng_borderline.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libeditenglo.so: undefined symbol: _ZTIN3vcl9unohelper18DragAndDropWrapperE"
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3306/>)
        
        Change-Id: I4501c3df9f353d9b1244f92b5bbc6fb2dafc24bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173311
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-13  Michael Stahl  <michael.stahl@allotropia.de>  [f6dc87fc730bc48a7c809d2ff460cc36024630b9]

        tdf#162911 sw: fix crash after autocorrect inserts hyperlinks
        
        The problem is that SwDoc::SetFormatItemByAutoFormat() inserts a static
        pool default item of SwFormatINetFormat as SwTextINetFormat into the
        document.
        
        SfxPoolItemHolder::SfxPoolItemHolder() does not clone a static pool
        default item, hence it will be deleted multiple times.
        
        The code that was added in SwDoc::SetFormatItemByAutoFormat() to fix
        tdf#62536 is for the RES_CHRATR_* items, it is not needed for any of the
        other items that autocorrect/autoformat may insert (RES_TXTATR_INETFMT
        or RES_PARATR_TABSTOP).
        
        (regression from commit fe444d1f74abe417962be0bcd3340f40f2446b58
         and/or commit ca3c6d468f68af1506bf4e56b47655e5d56306a8)
        
        Change-Id: I8b0414995f9fd8f94d1903a8e66f0c25c7038ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173267
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b63718d27adeec99a94f1012aa11056bf601475]

        libpng: upgrade to 1.6.44
        
        Downloaded from https://unlimited.dl.sourceforge.net/project/libpng/libpng16/1.6.44/libpng-1.6.44.tar.xz
        
        Change-Id: I0132e6edb0078d1d4479bb79b7f740c23719d72b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173309
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-13  Miklos Vajna  <vmiklos@collabora.com>  [81d3aefd8598fba835eeb21404fc4bd7dddf98b9]

        [API CHANGE] XDocumentDigitalSignatures: remove deprecated / unused functions
        
        Some functions were already a stub and only aborted on calling them.
        The *Package* functions were added in commit
        c9ed2f359a9e899c3046c8151c831e24250fddbb (INTEGRATION: CWS xmlsec08
        (1.4.24); FILE MERGED 2005/02/22 13:07:19 mt 1.4.24.1: #i36682# Accept
        separate Stream for signatures..., 2005-03-10), but it seems nobody
        called them.
        
        This also means that DocumentSignatureMode is now never set to
        DocumentSignatureMode::Package, so remove that as well.
        
        It seems to be unlikely that this non-published service was used by
        3rd-party code, since it was specific to the needs of sfx2/ code, not
        generic functionality that could be useful in other contexts.
        
        Change-Id: Icfed9a0e6568f6eb21f9236901af01f1915bf2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173313
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e6e7b8498aba69af8eee8edd1d3a1fb17c36836a]

        lok: export transition info to getPresentationInfo JSON structure
        
        Added only basic transitions (type + subtype conversion)
        + added test case
        
        Change-Id: Ibebc34005ee0ffe1fdc2d1587c746538f657fbdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169620
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172869
        Tested-by: Jenkins

2024-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [76c6436faa5e87132cc13be42ac4510baf1c9f8a]

        convert OKeySetValue to a struct
        
        for better readability
        
        Change-Id: I9750668a31740bb1de0b6f024912d5cc73f7e766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [79365762bddbc101cd327b972043c9282756303a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 75f5dff8c972fff4a32e4ea8434722c277f02a3f
          - Updated Slovak dictionaries to v2.4.8
            
            Downloaded from https://github.com/sk-spell/hunspell-sk/archive/refs/tags/v2.4.8.zip
            
            Change-Id: I369a4703c7accc635572a0f711c5c0304429e4e9
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/172738
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2024-09-13  Justin Luth  <jluth@mail.com>  [343bfc6808320d435686527f3a28b88faa6a3398]

        tdf#162926 Revert "tdf#100037 vml import: add AS_CHAR images...
        
        ... to zOrder calculation"
        
        This reverts my 24.8 commit 6c2ab0f3ca440f6e10b438e6ee0e235cbe155216.
        
        Change-Id: Ia163c5adf7edfa70e49a85be6eea7908ae93ef79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173240
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-09-13  Justin Luth  <jluth@mail.com>  [0125a92e0168646f1f0b5dfdaabb841eb6358a78]

        tdf#162926 Revert "tdf#100037 vml import: set fly-anchored AS_CHARs...
        
        ...above fly's zOrder"
        
        This reverts my 24.8 commit f714fb262ad8561afcababf4b7a97dedb1b72c15.
        
        Some activeX binary (I assume) seemed to be composed of two parts
        and yet didn't have a TextBox property, but when sent to the background
        the textbox part of it disappeared.
        I assume it was some kind of two-part monstrosity,
        but nothing in the ServiceInfo indicated anything excludable.
        
        Change-Id: I6e088a74e62db8b2bb732ba66e2cb3319b9c401e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173239
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-09-13  Mike Kaganski  <mike.kaganski@collabora.com>  [47a348bb0fd6dfdd93c1975d216daadc4f6b9b6f]

        tdf#162935: use PUTC for WITH variable assignment: it doesn't copy value
        
        SbiRuntime::StepPUT, SbiRuntime::StepSET, SbiRuntime::StepVBASET call
        checkUnoStructCopy eventually, which copies the UNO struct by value.
        This is not what we need. On the other hand, SbiRuntime::StepPUTC only
        makes the by-ref assignment, and makes the reference const; but Basic
        code never assigns anything to the internal variable itself, only to
        its members.
        
        I hope that this time, I get it right.
        
        Change-Id: I2b4a51a2dca9e7106e14e03360ef0d5a50b60079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173305
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-13  Mike Kaganski  <mike.kaganski@collabora.com>  [81e1e0a2a671f19950c1bd3c69f9aa24b0c562e7]

        Refactor SbxValue::Format
        
        Change-Id: I1a55f2c6148246733699c1ff1086436af9d450b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173254
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [3a37d8320c0b8a7bced8e67f7ed2581d4013e38b]

        Optimize TokenMap and AttributeList in oox and xo
        
        Shaves lots of string allocations, and uses optimized code paths
        
        Change-Id: I8e33e2aecdc7e0d2f2c31b774daa36304b3973ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173179
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [128b19c33088dcd3dab55074a70a545e4b47a190]

        Fix typo
        
        Change-Id: I8659ec30e8cabbbbd693bc50266fa0a386fb007c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173271
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-12  Jonathan Clark  <jonathan@libreoffice.org>  [5a45f7925b8c88baeb23ee253491888bfa6233cc]

        tdf#156543 sw: Added base text mono feature to Asian Phonetic Guide
        
        This change adds a new button, Mono, to the Asian Phonetic Guide.
        Clicking on this button will automatically separate each base text
        character into its own base text run.
        
        Change-Id: I973e2c3259918db59e46dc7b89cb7e8ee4f45469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173276
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [623eb17d6b699a280e6d096fb1be4d543cf9f064]

        tdf#155488 svg export "peek-ahead" didn't see MapMode changes
        
        normal 'playback' case is ok, but during the peek-ahead to get text positions
        then the MapMode was skipped over so the rotate values were created with
        the wrong MapMode.
        
        Change-Id: I2b51dbc1b15e8d0d24b00b2bd4decb4c71772208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [0c43f532229f17a5f6d8b98a674f810a0b4988ab]

        Simplify a bit
        
        Change-Id: Ib684a85f31d7416793fed6d560b3976840565800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173184
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5eae298370e8d0f062054a3ffda088c5a0bab8ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 03b22cedc167f609b4ef43a327a2967e8ca8251c
          - tdf#162607 Remove dup's in hid2file.js, EXTENSIONS*
            
            Change-Id: If744d3c1912c340aef689db3da5b1e80906d6cef
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173278
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [943fb5e2ec6be7941667555099b9733197cb0a7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b555962ae0d13de84fd471e390e503bb4611902f
          - Refactor - no changes
            
            Change-Id: I22687316796c23402191f74e3eb9e0d9402821e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173277
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3d9b6c0fceba9d7f50ce00e82c1e5b70bbaf1431]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6185c0d3fdc17d2e02cb9e40ae3bd3e75315f36d
          - tdf#162607 Remove dup's in hid2file.js,uno:CellVert*
            
            + Removed bookmarks from hidden ahelp
            
            Change-Id: Iedabdb16caa8b97882e787322bc5731d6bce19fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173275
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d94d138566dd0017bdbe240c5ce7aad2d467153b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37ce48a19c58e36486e71461eed545d5f6e30836
          - tdf#162607 Remove dup's in hid2file.js,uno:Align*
            
            + Removed bookmarks from hidden ahelp
            + refactor
            
            Change-Id: I075adfbfbe6cc0113e70ca151adc518a94131420
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173274
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f976823a66858d3ecc749544be50fdda0c8c40f6]

        use more concrete UNO class in chart2
        
        Change-Id: Ifbdcf39f6f621dc63746a8c389a19c52aab847b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173264
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [925b8da69413708249c6d3f08c86ce54faf4b2e3]

        use more concrete UNO types in ucb
        
        Change-Id: I3f3c94c6aa320d9e2a7658f0ee7005ae25100fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173269
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [4000d57869fda437f0361dc4ac991858905a40e9]

        use more concrete UNO types in xmloff
        
        Change-Id: Idf2bcf23497ef5d673ab36f776f562e8c964b3a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-12  Ashok  <ashokemailat@yahoo.com>  [ca44362491b8f823b4d36cddfd5e6242074cc211]

        tdf#135335 Use font family name as the value of BulletFontName property
        
        instead of style name.
        
        Change-Id: Id1e5734384bc850435a084ae1b1d9610032e6161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19437715eb41cbe4853d3926e627206709f6810e]

        null pattern deref seen in ScViewData::SetEditEngine
        
        warn and use the default pool pattern if this happens
        
         #0  WhichRangesContainer::getOffsetFromWhich (this=this@entry=0x38, nWhich=nWhich@entry=129) at libreoffice/svl/source/items/itemset.cxx:1895
         #1  0x00007fe0179fa4ac in SfxItemSet::Get (this=0x10, nWhich=129, bSrchInParent=<optimized out>) at libreoffice/svl/source/items/itemset.cxx:1152
         #2  0x00007fe00736aa2e in ScPatternAttr::GetItem (nWhichP=129, this=0x0) at libreoffice/sc/inc/patattr.hxx:71
         #3  ScPatternAttr::GetItem<SvxHorJustifyItem> (nWhich=..., this=0x0) at libreoffice/sc/inc/patattr.hxx:73
         #4  ScViewData::SetEditEngine (this=this@entry=0x3323c540, eWhich=eWhich@entry=SC_SPLIT_BOTTOMLEFT, pNewEngine=<optimized out>, pWin=pWin@entry=0x32eec4f0, nNewX=nNewX@entry=-1, nNewY=nNewY@entry=-1)
             at libreoffice/sc/source/ui/view/viewdata.cxx:1613
         #5  0x00007fe00731c2f1 in ScTabView::UpdateEditView (this=this@entry=0x3323c538) at libreoffice/sc/source/ui/view/tabview3.cxx:2248
         #6  0x00007fe00731c9ae in ScTabView::UpdateFormulas (this=this@entry=0x3323c538, nStartCol=nStartCol@entry=-1, nStartRow=nStartRow@entry=-1, nEndCol=nEndCol@entry=-1, nEndRow=nEndRow@entry=-1)
             at libreoffice/sc/source/ui/view/tabview3.cxx:2393
         #7  0x00007fe007338bc5 in ScTabViewShell::Notify (this=0x3323c330, rBC=..., rHint=...) at libreoffice/sc/source/ui/view/tabvwsh5.cxx:219
         #8  0x00007fe017a29bb9 in SfxBroadcaster::Broadcast (this=this@entry=0x2fd10a70, rHint=...) at libreoffice/svl/source/notify/SfxBroadcaster.cxx:40
         #9  0x00007fe006f27c3f in ScDocShell::PostDataChanged (this=this@entry=0x2fd10a70) at libreoffice/sc/source/ui/docshell/docsh3.cxx:95
         #10 0x00007fe006f17dfc in ScDocShell::SetDocumentModified (this=this@entry=0x2fd10a70) at libreoffice/sc/source/ui/docshell/docsh.cxx:3050
         #11 0x00007fe007382e7c in ScViewFunc::DeleteTables (this=this@entry=0x3464aa28, TheTabs=std::vector of length 1, capacity 1 = {...}, bRecord=<optimized out>, bRecord@entry=true)
             at libreoffice/sc/source/ui/view/viewfun2.cxx:2656
         #12 0x00007fe007350825 in ScTabViewShell::ExecuteTable (this=0x3464a820, rReq=...) at libreoffice/sc/source/ui/view/tabvwshf.cxx:910
         #13 0x00007fe0175d0cef in SfxDispatcher::Call_Impl (this=0x340a1b70, rShell=..., rSlot=..., rReq=..., bRecord=<optimized out>)
             at libreoffice/sfx2/source/control/dispatch.cxx:254
         #14 0x00007fe0175d8daa in SfxDispatcher::Execute (this=0x340a1b70, nSlot=<optimized out>, nCall=nCall@entry=SfxCallMode::RECORD, pArgs=pArgs@entry=0x7ffe3c51edf0, pInternalArgs=pInternalArgs@entry=0x7ffe3c51ed90, nModi=0)
             at libreoffice/sfx2/source/control/dispatch.cxx:813
         #15 0x00007fe0176166f5 in SfxDispatchController_Impl::dispatch (this=<optimized out>, aURL=..., aArgs=uno::Sequence of length 1 = {...}, rListener=empty uno::Reference)
            at libreoffice/include/sfx2/ctrlitem.hxx:63
        
        Change-Id: Ib4851414a277a293d6bc44b4ffcd33d332e3c57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173183
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-12  Miklos Vajna  <vmiklos@collabora.com>  [e5a0209d4b1e1f09191a442e04d626b21c49b9df]

        cool#9992 lok doc sign: allow sign of macros & the document itself in one step
        
        Sign a document with macros (via file -> digital signatures -> digital
        signatures), realize that you still get a warning on file open, sign the
        macros in the document (via tools -> macros -> digital signature),
        realize that you did this in the wrong order, so now you have to re-sign
        the doc content.
        
        The reason for this is that the macro signature only signs the macro
        parts of the document (so you can still edit the document and the
        signature is valid, as long as you don't touch macros), while the doc
        content signature signs everything, including the macro signature, so
        the order of the two matters.
        
        Solve this trouble by adding a new setting that allows doing the two
        signatures in one step. Do this by extending the doc content signing
        code with an optional pre-step that first signs the document macros.
        This is a bit tricky to do, since xmlsecurity/ gets an RW signature
        stream and a RO document storage from sfx2/, but transferring one more
        signature stream can solve this trouble.
        
        Other tricky parts of the change:
        1) The crypto signing is always done by libxmlsec, so
           DigitalSignaturesDialog::SetScriptingSignatureStream() has to update
           the storage of the sign manager's sign helper, otherwise, the hashes in
           the macro signature will be empty.
        2) Signing reads the RO storage, so normally the macro signature
           would not be part of the doc signature when creating both signatures
           inside a single dialog. (The storage is only committed after the
           dialog ends.) Fix this problem by extending
           DocumentSignatureManager::add() and UriBindingHelper::OpenInputStream()
           to provide kind of an overlay when xmlsecurity/ gets a script signature
           stream: this way the macro signature will be part of the doc signature
           while the dialog is in progress. No overlay is needed later, once both
           streams are committed to the storage on dialog end.
        
        Change-Id: Ic2728689997165595991d5ec59c7a2683286e22d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173263
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-12  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [4b399dbfc4c3081174be1703a0c98fec1afd761f]

        tdf#162405: check if there's a matching singing cert only when saving
        
        previously Save as dialog's "Sign with default certificate"
        checkbox's senstivity was decided depending on if there was a
        matching key.
        
        Doing that forces a dialog pop-up for password protected NSS
        databases.
        
        Now if there's a value in
        "/org.openoffice.UserProfile/Data/signingkey", the checkbox
        is sensitive.
        
        Matching key is checked during save, and reported if it isn't
        found & signing failed.
        
        Change-Id: Ia714b70ce6456752200088cc5382ab6374af9587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173129
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4c0bb0ce626fa24eddb886e3bf6444da292df25]

        use more concrete UNO classes in unotools
        
        Change-Id: Iaf743ae040a3a7bd808bf3cac033197001c31b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173250
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ebbaa05d83ffa06a657398430b50fdf135945f32]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30b104a12fa9d2f95cd7edcfec42431da7a022d3
          - tdf#162607 Remove dup's in hid2file.js, Print dialog
            
            + disambiguate bookmark between optionen and print dialog
            + remove dups in print dialog page
            + refactor
            
            Change-Id: I101db8feaaf391509554a7b11d202d8cbf57a066
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173265
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [ef33c1e17052509a1541c0a0182ba3adafafe2cf]

        SwModelTestBase: remove duplicated code to print execution time
        
        This is already handled in class TimingListener
        in sal/cppunittester/cppunittester.cxx
        
        Change-Id: I77d330351d53ef084597e6f46099d1d16f59aae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173258
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [133902f4ad6a8b0301fd9d34d424e27a5cb50570]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ec63fc11d91d92f31fd7aca15820fafd84d2c957
          - tdf#162607 Remove dup's in hid2file.js, DBACCESS_HID*
            
            + bad bookmarks removed from tablewizard02.xhp
            + refactor
            
            Change-Id: I6aa3aa5c339319ad6c9d330986168d3c347a57c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173259
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [308c9bd730ab3296b437a6999f60dd8e03de02e0]

        sw a11y: Send table selection-changed event for correct object
        
        Send `AccessibleEventId::SELECTION_CHANGED_ADD`/
        `AccessibleEventId::SELECTION_CHANGED_REMOVE` when
        a cell in a Writer gets (un)selected on the table's a11y
        object and set the cell as the `NewValue`, as documented
        in the documentation for these events
        (see offapi/com/sun/star/accessibility/AccessibleEventId.idl).
        
        For the cell, an `AccessibleEventId::STATE_CHANGED`
        event for the `AccessibleStateType::SELECTED` needs
        to be sent instead, which already happens in
        `SwAccessibleCell::InvalidateMyCursorPos` (where the
        cell is also added to the vector of elements used
        here to send the `SELECTION_CHANGED_*` events).
        
        This now gives the expected result when using
        the following pyatspi script and selecting
        the first 2 cells in a Writer table with
        the gtk3 VCL plugin:
        
            pyatspi script:
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if not e.host_application.name.startswith('soffice'):
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, 'object:state-changed:selected')
            pyatspi.Registry.registerEventListener(listener, 'object:selection-changed')
            pyatspi.Registry.start()
        
        Relevant output from the script:
        
            object:state-changed:selected(1, 0, 0)
                    source: [table cell | A1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:state-changed:selected(1, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table | Table1-1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table | Table1-1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        Change-Id: I12a871f748c86fa271fafb839fd9ce8275f93cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173257
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [7d4def4d942bbbdb1688c2947cb621f7f55fa966]

        sw a11y: Don't resend obsolete table selection events
        
        When a table cell was (un)selected, it is added to
        the vector of added/removed cells.
        `SwAccessibleTable::FireSelectionEvent` iterates over
        the cells in those vectors and sends an event for every
        element.
        
        The elements were never removed from the vector, however,
        meaning that obsolete events of previous selection activity
        would be resent every time any selection change occured.
        
        Clear the vectors after sending the events to prevent that.
        
        pyatspi script with which the issue could be seen with the gtk3
        VCL plugin:
        
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if not e.host_application.name.startswith('soffice'):
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, 'object:selection-changed')
            pyatspi.Registry.start()
        
        Selecting the first 2 cells in a newly inserted Writer table would
        result (among others) in these events for the cells:
        
            object:selection-changed(0, 0, 0)
                    source: [table cell | A1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        (The fact that "selection-changed" events are sent for
        the cells instead of the table is another issue that will be
        handled separately.)
        Unselecting the second cell would then trigger these
        "selection-changed" events:
        
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | A1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        (Note the two last "selection-changed" events being
        resent from before.)
        
        Selecting the second cell once again would then trigger
        4 events despite only a single cell having been newly
        selected:
        
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | A1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        With this commit in place, only a single event
        for the newly (un)selected cell B1 is sent in
        steps 2 and 3:
        
            object:selection-changed(0, 0, 0)
                    source: [table cell | B1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        Change-Id: I36505d56b032196fa084492a87a118f5366db1dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0d84eba568aaa9aef6ad812f19410946a274640]

        use more concrete UNO classes in connectivity
        
        Change-Id: I5c70278add0aa0b0c4a7680c6615b75b688f2180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173247
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9714b19590f651cbd48ae763b5a9558dd1e9e972]

        no need to dynamic_cast so much in AccessibleTableShapeImpl
        
        when we know the underlying object is a sdr::table::TableModel
        
        unfortunately this reveals that the underlying object does not, in fact,
        implement XSelectionSupplier
        
        Change-Id: I29336a7cf945dcec1a8d7aecc78f793e95bae259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fbc623a5e8183b0042e886af9e2a4e0ac7e51f7]

        use more concrete UNO classes in scripting
        
        Change-Id: I4eddf7ccdf2d0720a4204e578c9f21d8c78dbd35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [99243746d26035b91b7301028007dbd6d5c50763]

        use more concrete UNO classes in comphelper
        
        Change-Id: I1a81d2264a450c23a5196f980e91a686f69edca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [994834e07234c7cae90b509adad54f767d612934]

        ICU: upgrade to 75.1
        
        Downloaded from https://github.com/unicode-org/icu/releases/tag/release-75-1
        
        Change-Id: I882c57bf5ab613dc71f7ae1c31305596e1ca791f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168750
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-12  Laurent Balland  <laurent.balland@mailo.fr>  [8a978834e273c3b389a3beb27f0be8ce5341eb04]

        Update Yellow Idea Impress template
        
        - simplify Header/Footer/Page/Date elements
        - remove some unused styles
        
        Change-Id: Ie8c75f9dd8dafe9ecf16ffc820832a88391b3507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173048
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [976567aee323afd09629b6adf13537908f43d2a8]

        Simplify a bit
        
        Change-Id: Id46a5029ce86f20ffae34aa6495d7311044999a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173177
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-12  Andras Timar  <andras.timar@collabora.com>  [c4283c5309e92c8b86c58362fcc15327484730cc]

        tdf#162921 on this error dialog there is 'Abort' button, not 'Cancel'
        
        Change-Id: I28b86fa7fa0175d5b9737854ad0ece4e3a00760e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173217
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-09-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b6775ce2b397276237dfb9eecd54b9682aca79b1]

        Temporarily skip unit tests on native arm64 build
        
        which indicating unit test fails.
        
        Change-Id: I2689b0dda888e15e52ca60cc18e1705a1aefe968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173143
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-09-12  Justin Luth  <justin.luth@collabora.com>  [3fddae6812f91e5c5f57dacf641f964cd995f2f5]

        tdf#162884 writerfilter: map to built-in footnote style name
        
        This partial revert fixes a 24.2.4 regression from
        commit 72ea1005b987159a6a59f9379e63321e0b0dd44f
        Author: Michael Stahl on Mon May 6 15:58:36 2024 +0200
            tdf#160402 writerfilter: extend StyleMap with all Word styles
        
        Footnote anchor character formatting is controlled by
        the character style set in Tools - Footnotes Settings.
        
        The default name of that style is UI dependent,
        so only the English UI was importing properly
        when the localized name was used in the mapping.
        
        "Footnote Symbol" is the internal name - both the internal name
        and the localized name are find-able at the same time,
        so the only things that will have a problem are things
        that don't connect to the style, but just hold the string name.
        
        The unit test change is also a revert from mstahl's commit.
        make CppunitTest_sw_ooxmlexport9 \
            CPPUNIT_TEST_NAME=testTdf109310_endnoteStyleForMSO
        and is an indication of another problem that this fixes,
        namely that a new Footnote Characters style is added
        with each round-trip.
        
        Bug 162884 was only reproducible with a non-English UI.
        To reproduce, I compiled with autogen.input
        --with-lang=de
        
        Thus no unit test...
        
        Change-Id: I63d37f13f435ff7ec41d6b22d74db83dc495150a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173141
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [a7468f083f79f5cf8b37665ea46a563ec1c3bd3e]

        tdf#149865: reduce size of sample file
        
        Change-Id: Ic0751f22f3158536dc5753db2ea9f133692e0d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173213
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c88efbcfa0310c9b492af2f9144efd76ad5fdf0]

        external: remove a couple of gcc9 patches
        
        Baseline uses GCC 12 now
        
        Change-Id: Id9a0f79aa801aa342fd943cebeb0f528f4964d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173235
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d39e7878b32a68aa34759737000aa6e138b87999]

        use less dynamic_cast in svx table stuff
        
        we already statically know the types of all these objects
        
        Change-Id: I976dbf2b150fcd2176df18a07c2e9f21b1d2fe65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173214
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ba893dfb8838b0ef946b52de9ef1336d2ab0512]

        use more concrete UNO type in editeng
        
        Change-Id: I5cad4808a1e5f10022f8a0441eb81a279d9b6386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173196
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [294b4cc5458b9e20da98d12405a5942ae1551aee]

        These bogus -Wdangling-reference still hit with current GCC 15 trunk
        
        Change-Id: Ice2be2156474cf486ad1c461d65e2711ebf43d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173232
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [e94a35275670e0e3775c1bba305115d9941751f1]

        tdf#161256 gtk4 a11y: Don't crash on missing context or invalid child index
        
        If an `XAccessible` doesn't have a context or
        `XAccessibleContext::getAccessibleIndexInParent()` returns
        an invalid index of -1, don't crash/assert, but
        let `lo_accessible_get_next_accessible_sibling` return
        `nullptr`.
        
        This works around potential bugs in underlying
        `XAccessible`/`XAccessibleContext` implementations for now.
        
        This is meant to fix the assert/crash seen in the backtraces
        attachment 196363 and attachment 196383 from tdf#161256
        which I cannot reproduce locally on Debian testing.
        
        Change-Id: Ic1779d875161469bf296c558039e19f1d426a259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173216
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [071b626079243908cfa85a5bd49620235fdf48cf]

        tdf#91739 wina11y: Create AccObject for parent as necessary
        
        In `AccObjectWinManager::InsertAccObj`, when no HWND
        was explicitly passed, it is attempted to retrieve the
        HWND from the parent's `AccObject`.
        
        If no parent AccObject exists yet, create/insert that
        one first.
        
        This fixes the following assert seen when using NVDA's SayAll
        feature to read the whole document with sample document mentioned in NVDA
        issue [1], also attached as attachment 196385 in tdf#91739
        for reference:
        
            Assertion failed: pIAccessible && "Couldn't retrieve IAccessible object for relation target.", file C:/tools/cygwin/home/user/development/git/libreoffice/winaccessibility/source/UAccCOM/MAccessible.cxx, line 2755
        
        It's also reproducible when manually trying to get the next
        flows-to relation target via NVDA's Python console when the
        first cell in the table has focus:
        
            >>> focus.flowsTo
        
        The issue is not reproducible when focus had been in the
        second cell before, as an accessible object has already
        been created otherwise in that case.
        
        Backtrace:
        
            1  abort                                   ucrtbase             0x7fff3b72286e
            2  get_wpgmptr                             ucrtbase             0x7fff3b7241b5
            3  wassert                                 ucrtbase             0x7fff3b7244f1
            4  CMAccessible::get_relationTargetsOfType MAccessible.cxx 2755 0x7fff1e028729
            5  NdrSendReceive                          RPCRT4               0x7fff3d4ca2d3
            6  NdrStubCall2                            RPCRT4               0x7fff3d4625a7
            7  CStdStubBuffer_Invoke                   combase              0x7fff3cfbc4ac
            8  RoGetAgileReference                     combase              0x7fff3cf669c3
            9  RoGetAgileReference                     combase              0x7fff3cf6674e
            10 HSTRING_UserSize                        combase              0x7fff3cfbefb6
            11 DllGetClassObject                       combase              0x7fff3cf470b3
            12 CoWaitForMultipleHandles                combase              0x7fff3cf6774d
            13 RoGetActivatableClassRegistration       combase              0x7fff3cf2eb26
            14 CoGetMarshalSizeMax                     combase              0x7fff3cf5cfba
            15 CallWindowProcW                         USER32               0x7fff3ccbef5c
            16 DispatchMessageW                        USER32               0x7fff3ccbe684
            17 ImplSalDispatchMessage                  salinst.cxx     475  0x7ffed452d378
            18 ImplSalYield                            salinst.cxx     552  0x7ffed452da9d
            19 WinSalInstance::DoYield                 salinst.cxx     581  0x7ffed452cfa1
            20 ImplYield                               svapp.cxx       385  0x7ffed78befc4
            21 Application::Yield                      svapp.cxx       474  0x7ffed78c2cd2
            22 Application::Execute                    svapp.cxx       361  0x7ffed78bc656
            23 desktop::Desktop::Main                  app.cxx         1691 0x7ffeecf689b7
            24 ImplSVMain                              svmain.cxx      228  0x7ffed78d3d4c
            25 SVMain                                  svmain.cxx      261  0x7ffed78d45a2
            26 soffice_main                            sofficemain.cxx 121  0x7ffeecfb9064
            27 sal_main                                main.c          51   0x7ff782681013
            28 main                                    main.c          49   0x7ff78268105a
            29 __scrt_common_main_seh                  exe_common.inl  288  0x7ff782681344
            30 BaseThreadInitThunk                     KERNEL32             0x7fff3bb07374
            31 RtlUserThreadStart                      ntdll                0x7fff3d85cc91
        
        [1] https://github.com/nvaccess/nvda/issues/8152#issuecomment-2342167620
        
        Change-Id: I246251f06d1885e0da96600ffc7dd0549854382f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173224
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [e6965d03288b70b4565730120c73d51b4033bffe]

        wina11y: Drop superfluous AccObject::m_pIMAcc null checks
        
        The `AccObject` ctor already asserts it's non-null,
        so there's no need to check again in various places.
        
        Change-Id: Ibba363d326198a89e391a4da54cff25c95eef776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173223
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [07a7551f60010614825ad52f18c03f7a1bf1b8d0]

        wina11y: Move var decl to first assignment
        
        ... and rename to use the "x" prefix for this uno::Reference.
        
        Change-Id: Ibf422aa48d6fbada49975fa8c5f43ad6c4c3ddee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173222
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-12  Michael Weghorn  <m.weghorn@posteo.de>  [0792cf256f437279f7ae2595dc49eceb608620c8]

        wina11y: Move var declaration to where it's assigned
        
        ... and rename the variable to use the "x" prefix
        in line with naming conventions.
        
        Change-Id: Ife49161162654efdf1d543909218e31e464d2fc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173221
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-12  Jonathan Clark  <jonathan@libreoffice.org>  [3d9b8701cb1751e4139ffa24f72bb836eb877fd1]

        tdf#107184 sw: Added base text group feature to Asian Phonetic Guide
        
        This change adds a new button, Group, to the Asian Phonetic Guide.
        Clicking on this button will automatically merge all base text runs into
        a single base text run.
        
        Change-Id: I8bc2881f0c31d501f8a347156145a483bb4c96cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173241
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0a5b29f653a314727e23489a3e98daff8386ff6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a1a76e6b7c74f0903b7695f137160e4c7e622f7
          - tdf#162607 Remove dup's in hid2file.js Standard filter
            
            + Deleted shared/02/12090000.xhp because 12090100.xhp has much more info and duplicates contents
            + rebuild links to reach 12090100.xhp
            + renamed references to Default filter to Standard filter.
            + add section to standard filter icon for embed purposes
            + refactor
            
            Change-Id: Ib88b7574fa12910c4cf9c8af9cbf79577b600e4b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173237
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [22d3de16dc65b0708cf260205f6e94637f39859c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f0cce1baf94f2645e5eac9bd3dbc72de359179b5
          - tdf#162607 Remove dup's in hid2file.js, NewTableDialog
            
            + Removed bookmarks not appropriate
            + moved some <ahelp> to UI and deleted here
            
            Change-Id: Ic85a4c43cd4861cefa1bf67348d386464234ed65
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173236
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1c5de2934d2e3fa1c7718c57152f471e2b17a575]

        cid#1608244 Overflowed constant
        
        Change-Id: I0af85988e04b479b7dae5d68a97bdc41332e9d7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f3bf4d62d57f6f0fdce3539a67e0777afcd83e61]

        Add extended tips to newtabledialog.ui
        
        Change-Id: I3ef67bfb5989ce12cb4d64ebff555d7b5fe8c8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173226
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-09-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [77cbb62a7b4530c06c987527821e7fd3fa9edfb7]

        Bump to latest Glade - no changes
        
        Change-Id: Ia447b0322b270915c1865f2d93473bc6b2a32291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173225
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-09-11  Laurent Balland  <laurent.balland@mailo.fr>  [53537bc41584dbad3bf75d33abf122d75140605d]

        Update Growing Liberty Impress template
        
        - remove duplicate picture (add a rotation)
        - simplify Header/Footer/Date/Page elements in Handout, Notes and Master
          slides
        
        Change-Id: I933294fce99614448317ef572552f57bb585bc9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173047
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2ee9929c8a4a8b6d4b6857db79f0b64e230d9f6]

        use more concrete UNO type in svl
        
        Change-Id: I794fba1f111709e0469812d48eb81cc4dc1f11d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [2c5718353658fce9f40157ee49c1f0af1f5cc0df]

        tdf#162899 Accept BYTE and SHORT types in the Solver Options dialog
        
        ScSolverUtil::GetDefaults should also accept values of types BYTE and SHORT. It currently only accepts LONG.
        
        As described in the bug ticket, this is important when creating Solver extensions using Python, since pyObject2Any forces small integer numbers to be either BYTE or SHORT instead of LONG.
        
        Change-Id: I17c7a344777c31ea333a4d21a2543d2de0b448fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173093
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-11  Jaume Pujantell  <jaume.pujantell@collabora.com>  [26754f3c8577ce65c73b896b56456b5121941a62]

        lok: sw: restrict deletions on comment only mode
        
        On Writer, when in readonly mode with comments activated restrict
        the hability to delete comments to only those made by the same user.
        
        Change-Id: Iaefb1166c680726c9c73a305ef67be812d3b97d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172596
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit f93d46429c68770dd432fa6e7edcfc876891f8e1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172890
        Reviewed-by: Andreas Mantke <andreas.mantke@googlemail.com>
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e7da2b370c882d63d9087d2ea646fd9939023506]

        cid#1607469 Data race condition
        
        Change-Id: Id9d55ce38c9348c5f8da3ce65af0cd1e0da96196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173187
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [37896449768b5dd08b0251385102d7caa33059af]

        cid#1607383 silence Overflowed constant
        
        Change-Id: I61b233714e613128d84bb19539727ac5a620a425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173192
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8bf1abfdc6955004e034343a475ed0f9b9920b8d]

        cid#1607403 silence Overflowed constant
        
        Change-Id: I5edaf48b4d6fb42d73bc34c2a028f5372ecbdc45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173190
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b2f6da24313f416370c3bec17f7eb7d52256ac88]

        cid#1607412 silence Overflowed constant
        
        Change-Id: Ie4ca362c936c8cbb4850d438e0bd6c2ed91f95d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173189
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f59a5d59083c1aa5a54133cb4bad4c5540d35c9]

        cid#1607446 silence Overflowed constant
        
        Change-Id: I175a7b4808641797efec33151353d0164921aa86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173188
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [f44c334a3e2eb8f0fb57df6805c12fc1c128ea99]

        tdf#159032: minimize sample file
        
        it still crashes if the fix is reverted.
        Also rename it since the filename is confusing
        
        See https://gerrit.libreoffice.org/c/core/+/161652/comments/14d0a095_4e005629
        
        Change-Id: I1a629b8be171d17600024ebdc4ab0584af2342f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173197
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f24cf13f0eaa3fb2f5e159d83eaf4c705b4388a8]

        Related: tdf#158092 add a comment to avoid symbols localization
        
        The localizable string is to allow different position/precision of the
        components; but the localization of the symbols themselves (decimal
        and thousand separator, currency) happens in code.
        
        This comment is shown in Weblate UI.
        
        Change-Id: Ib2f62fc8edf12ad3b182b40e3a8981c43b7ed67f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173104
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [c95229bf8e3bd643b8529046f0754e2de4c6625b]

        curl: upgrade to 8.10.0
        
        Downloaded from https://curl.se/download/curl-8.10.0.tar.xz
        
        Change-Id: I1eb9506a73162ce2e2adf1fe1e02267c34bc78ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173194
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca8c59c7e645a072352b775cc32ea1af06b53413]

        use more concrete UNO type in framework
        
        Change-Id: I3ee54f3967339ab52c04f48a047bc29fc5161680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f86862b8adc25b2979b2afa2811bd9390a6ca8c]

        use more concrete UNO type in toolkit
        
        Change-Id: I3527b51948e6b23cc9448a2c98dbe2765cef48b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173158
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0d45b3736aa236a61e3aecb0824d2c943b2b0dd]

        cid#1607478 Overflowed constant
        
        aFormMap is std::pair<SwPosition, sal_uInt32> and GetTabIndex returns
        sal_uInt32, so change nCurTabIndex to sal_uInt32 and continue use of
        SAL_MAX_UINT32
        
        Change-Id: Ie404e8b649f37f753f943f90a648114f080ed6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173185
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Mike Kaganski  <mike.kaganski@collabora.com>  [7cfff4751befd678b3db4b6f16b020d38f4e9c32]

        Related: tdf#129061 Avoid formula import and use fallback for now
        
        Until we support the correct inline formulas, their import fails badly
        in Impress, because we completely lose them in boxes with other content,
        and even where they are the sole content, they stretch to the size of
        the box incorrectly.
        
        Commit 4038d6c393c3cf6330671124ba69cdba98b24960 (tdf#117658 PPTX import:
        fix duplicated math object handling, 2019-11-13) opted to enable the
        Choice variant from the AlternateContent representing formula boxes.
        This change switches to Fallback graphic, losing the option to edit
        standalone imported formulas, but instead, allowing to see the formulas
        as they were created in PowerPoint.
        
        Unit test in sd/qa/unit/export-tests-ooxml2.cxx, created in commit
        331a0a347e2ed238ff41c8cd7815b946cc95ac0f (starmath: fix OOXML export
        of non-BMP Unicode, 2016-01-21) was changed, because it depended on
        importing the formula from PPTX, which is disabled here. Since it
        was fixing the export part, the FODP source seems to be a reasonable
        replacement.
        
        Change-Id: Ibd0e2bcd68296020c3bc057cb6a563918926cf2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173163
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f7c6394bf21a3311cbfb5e80f87e6067e09add0b]

        cid#1607652 Overflowed constant
        
        Change-Id: I624949cf61caa1f4448375208a3d3db2315c43cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173162
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-11  Julien Nabet  <serval2412@yahoo.fr>  [a42270bb4d56a538333aa317cb6425a95c37bb8c]

        tdf#161007: Report Builder Wizard fails
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=161007#c7
        
        Change-Id: Ide92b70f9006e229b59fab0c3eacfb37e0625ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173186
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0420602f80522498b5791d988b6d7713c4d5181e]

        cid#1607586 Overflowed return value
        
        doesn't make sense to compare to
        std::numeric_limits<sal_Int64>::max
        here, while sal_Int32 does
        
        Change-Id: Ic19beb6c2a0a46c5b45d37e833d566d91ddc10cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173161
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd88ea52affff0902963f9c616d0d9984a6dd533]

        use more concrete UNO type in package
        
        Change-Id: I95283bf49b8966d73035dd718fbcfcbdcacc78c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173157
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1bbf42240efe8f48a1a761faa6c8a03dc9b1b5a7]

        cid#1607928 silence Overflowed constant
        
        Change-Id: I0e2fafbde9e311177f42a4db3477760749021f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [43c8ec415a25637231ffa4ae0825fec58431e300]

        lok: test for getPresentationInfo LOK API function
        
        Also fix getting the slides, so we don't rely that a WeakReference
        is set, as it is not set (yet) when running the test.
        
        Change-Id: Icd338e31fbd0bb7c45a06357b955b85081ed38c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172868
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-11  Miklos Vajna  <vmiklos@collabora.com>  [482c7c585160681b263c6245a745c21df70e7507]

        cool#9992 lok doc sign: async read-write DigitalSignaturesDialog
        
        This finally allows removing the hack for the LOK case in
        SfxObjectShell::CheckIsReadonly() to show the signatures dialog
        read-only.
        
        Also fix a case while signing PDFs where the file stream was on the
        stack, but now that we finish signing in an async callback, signing
        crashed due to a use-after-free.
        
        Fix that by giving the std::unique_ptr to the utl::OStreamWrapper ctor,
        which knows to take over ownership in this case, and that wrapper is
        reference-counted.
        
        Next problem is that the add/remove buttons in the dialog are still
        hidden in the LOK case, that's not yet fixed here.
        
        Change-Id: I71ee50ae55d4e62f5d265a35e3810e3b2b63a9b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173155
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [070682854800cb983b452a5b5bd16943433c4b2b]

        tdf#149865 - FILEOPEN PPTX: fix table lacks border
        
        Fix wrong border line styles if we have merged cells.
        
        Change-Id: I238aa08c65b9aefd7b77b0f4ae3c3df979a7171d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173109
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-09-11  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [b4c52eb467b3f2164abfdece25830c8347f1ced9]

        Revert "Resolves tdf#162732 - Donate label not vertical centered"
        
        This reverts commit 91f0b84675b20332e618922494809d75d49e4fd6.
        
        Reason for revert:
        
        commit 6ca8cf32d2f879dbead2f402eeef60edd3f0266e
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Mon Sep 9 13:33:47 2024 +0100
        
        tdf#162732 force centered alignment for donate button text
        
        bit of a bodge, gtk defaults to baseline alignment here, so force
        what we want instead in a separate "Donate" button.
        
        Change-Id: I6301d158e97c279a86f8fe541ce336bdd3535645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173094
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [94a4d30494e2fc31917fc7b32a5a7a8b7dd2c360]

        cid#1606920 Overflowed integer argument
        
        Change-Id: I04bf4e51c64d09b3e8e15d2b3fc98c8ff4c3f6ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173147
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e53df700aa6d50003cd86d3190a3e4348f66e240]

        cid#1619294 Dereference null return value
        
        Change-Id: I07246237df3ebd6040353938984622e530b9ce2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173146
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b14a6c9e8d259233ffa666c08e314598932cb3c3]

        ImplFillExchangeData always derefs its first arg
        
        Change-Id: If5afecc8c0e821a6abe98ededad2e0ea8b98ccbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173145
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bae7ca08693c171dc1dea75e92c35826041e2603]

        these can be const
        
        Change-Id: I2d544ff797cc9c9e7dfabb6c30e916d519941d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173144
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-11  Dione Maddern  <dionemaddern@gmail.com>  [ca92667f876505777f95d4019d329afa14d55a26]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 772d0921f2f832deff089cad653e726bff6580ff
          - tdf#162504 Add links and missing content to Styles Deck help page
            
            In source/text/shared/01/styles.xhp
            - Removed paragraph about the context menu, because it is now covered in
            more detail below.
            - Added a link to the "Show Previews" section to make navigation easier.
            - Added help for the "Show Previews" widget.
            - Added help for the Styles Window and its context menu.
            - Added help for the Filter combo box.
            - Added the Spotlight Styles page to Related Topics
            
            Moved source/text/swriter/01/EditStyle.xhp to
            source/text/shared/01/edit_style.xhp
            - Updated content to apply to all apps, instead of just Writer. Most of
            the page is embedded, and the few native elements needed updating, so it
            was easier just to move the file.
            - Embedded the description in source/text/shared/01/new_style.xhp
            
            Created the following new pages for individual context menu options in
            the Styles Window and embedded the descriptions in
            source/text/shared/01/styles.xhp
            - source/text/shared/01/delete_style.xhp
            - source/text/shared/01/new_style.xhp
            
            Updated AllLangHelp_shared.mk and AllLangHelp_swriter.mk to reflect new
            and deleted files.
            
            In source/text/shared/00/00040500.xhp
            - Added Howtoget instructions for accessing Edit Styles/General Tab from
            the Keyboad and Sidebar
            
            - Added variable and section tags so the page title and descriptin cna
            be embedded in other pages in:
            - source/text/shared/01/02010000.xhp
            - source/text/shared/01/05040100.xhp
            - In source/text/swriter/01/05130000.xhp
            
            In - source/text/shared/01/02010000.xhp
            - Added a switchinline so that the page will show a different title for
            Calc
            
            In source/text/swriter/01/SpotlightMenu.xhp
            - Added the Spotlight Styles guide to the Related Topics section.
            
            In source/text/swriter/guide/spotlight_styles.xhp
            - Added variable tags to the page description can be embedded in other
            pages.
            - Added menubar instructions to howtoget
            - Added variable Tags to the
            - Added the help pages for Spotlight Menu and Styles Deck to the Related
            Topics section.
            
            Change-Id: I320883415c5ad4e1f2c21fc9c6cebc35c8e07bbb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173081
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b418f3d8d332276e6990cf7532a8f66aeb1d2f6c]

        Demonstrate that Embind is not multi-threading capable
        
        Enabling the line commented out with "TODO" in embindtest.js would fail with
        something like
        
        > Aborted(Assertion failed: invalid handle: 8)
        > worker.js onmessage() captured an uncaught exception: RuntimeError: unreachable
        > RuntimeError: unreachable
        >     at soffice.wasm.__trap (http://localhost:6931/soffice.wasm:wasm-function[446445]:0x8f952b3)
        >     at ___trap (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:16657:54)
        >     at abort (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:1091:5)
        >     at assert (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:731:5)
        >     at HandleAllocator.get (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:7212:11)
        >     at Object.toValue (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:7270:30)
        >     at __emval_call_void_method (blob:http://localhost:6931/7e945427-df90-49c0-a2b5-28c5ecfbe1a5:10183:22)
        >     at soffice.wasm.the_wrappers::com::sun::star::task::XJobExecutor::trigger(rtl::OUString const&) (http://localhost:6931/soffice.wasm:wasm-function[77042]:0xafbb24)
        >     at soffice.wasm.(anonymous namespace)::JobExecutorThread::execute() (http://localhost:6931/soffice.wasm:wasm-function[243534]:0x43250b5)
        >     at soffice.wasm.non-virtual thunk to salhelper::Thread::run() (http://localhost:6931/soffice.wasm:wasm-function[87641]:0xdff5cf)
        
        Change-Id: I4e35dc19c5c0f97de7158bf9c07fd31716ffff84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173132
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-10  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [a781e5ad356ad0fb86eb8210a2c570fdd276ceac]

        tdf#76981 sd: opening linked presentation in slideshow mode (part2)
        
        If an MSO presentation(pptx,ppt) is opened via a document link while in
        slideshow mode, the linked presentation should open in slideshow mode
        and close when finished. If it is opened while in editing mode, the
        linked presentation should open in editing mode.
        
        Change-Id: Ia9df1e4daa55dc697285a3778102a850e2f6098c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173130
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-09-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b472e1cedddf083d6b04d233cdefe686c8aa07ae]

        -Werror,-Wunused-private-field
        
        ...since f9ff22db058180d161b32f5dcd87e72cfa3b6889 "tsan:lock-order-inversion in
        forms"
        
        Change-Id: I6a31c661a6604e7c701e49b147d5372bef50dc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173133
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cd1f77618ec3d74c8c9c0743b9daef7108bc80a]

        use more concrete UNO type in vcl
        
        Change-Id: I157109d11b349e1304a3279471d4ab90b65b5841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b922fb69982f41962740f2abebaccf13e8c357a4]

        use more concrete UNO type in ucbhelper
        
        Change-Id: I1ad512564e58aed731639dbf9dbb3e7d6ee7acef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173137
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b103bcee12afacef5316081bdacb32fc2eeefa31]

        use more concrete UNO type in stoc
        
        Change-Id: I5e5196b5d0c67a697140af417f23b64e809bd074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [369c3bb5f0e47586bd743e68690d128758f3ce7c]

        use more concrete UNO type in comphelper
        
        Change-Id: I290b3ca15d9fc50e5c272c8e6a6634811a595d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173134
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f56c8da07485bb0d3b7755e25c5eb7fc8c95257]

        use more concrete UNO type in sax
        
        Change-Id: I3b3423242012b4f637195fb3c35c0315830e06a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [763b86a5fac81783525442d5ec262e91ca1047ac]

        Add arguments to Last 4 UNO Commands in CrashReport Dump
        
        Change-Id: I8ea1e95abb62374b51de7b1d37055c216b29e04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173125
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e663655d04b6f2d65722a83475bf4d997b4a4078]

        Fix certain build configurations
        
        ...after 8849c1d9cc7fbf990b1e1633b59a09c818dabc72 "dont use GetItemSurrogates
        for gathering SwFormatField",
        
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_wasm/sw/source/core/doc/docfld.cxx:941:37: error: use of undeclared identifier 'bIsDBManager'
        >   941 |             [this, eGetMode, &rDoc, bIsDBManager] (const SwFormatField& rFormatField) -> bool
        >       |                                     ^
        
        (<https://ci.libreoffice.org/job/lo_daily_tb_linux_wasm/825/>)
        
        Change-Id: Ic6335797f68f082971e46535479ee8a9c44d6bc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173119
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [bacaa3e5243e4aabc7fad795af2b25d79611f18c]

        tdf#143148 Use pragma once in BitmapConvolutionMatrixFilter.hxx
        
        Change-Id: If220df8a3bba570e00ba7891f7141892d80da3bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172974
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [eb3d1b3cade22c323d83973e8a087fe2d1b7bff0]

        vcl: variable refactoring BitmapConvolutionMatrixFilter::execute()
        
        Renamed variables, moved to declare closer to first use.
        
        Change-Id: I60b909c79d7c12c81247af2013228be84b42991e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172916
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-09-10  Michael Stahl  <michael.stahl@allotropia.de>  [4529ffc6439250bf3edc705117f9af1ad116dc36]

        expat: upgrade to release 2.6.3
        
        Fixes CVE-2024-45490 CVE-2024-45491 CVE-2024-45492
        
        Change-Id: I17f7d9a5c540e7d2005515f1f4fd79e0a5c631ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173124
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-10  Michael Weghorn  <m.weghorn@posteo.de>  [e77031f370ff99de10d3dd48734e1d831a6d7fd9]

        wina11y: Drop suspicious fallthrough case
        
        Don't fallthrough from the `AccessibleEventId::TEXT_CHANGED`
        case to the `AccessibleEventId::VISIBLE_DATA_CHANGED` one.
        
            commit 3ec901fab2cb3e1a1c8222498761e72c28175bd3
            Date:   Wed May 25 08:38:19 2016 +0200
        
                Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???" (in Win-only)
        
        had already added a TODO comment.
        
        The IAccessible2 IDL describes `IA2_EVENT_VISIBLE_DATA_CHANGED` like
        this:
        
              /** A visible data event indicates the change of the visual appearance
                of an accessible object.  This includes for example most of the
                attributes available via the IAccessibleComponent interface.
              */
              IA2_EVENT_VISIBLE_DATA_CHANGED,
        
        I see no real reason to always send that event as well
        when text is updated.
        In particular, since the description of the UNO equivalent
        `AccessibleEventId::VISIBLE_DATA_CHANGED` matches the IA2
        one very closely, it should explicitly be sent by the corresponding
        XAccessible(Context) implementation in addition to the
        `AccessibleEventId::TEXT_CHANGED` event if there are cases where
        both events should actually be emitted on the platform layer
        rather than being implicitly added in the platform-specific a11y bridge.
        
        Change-Id: I00402e08278b0b0c70f8d784939344a952dfa668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173120
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f70276214149b8497c755f117bed8104cc1f783a]

        use concrete UNO type in ControlContainerBase
        
        Change-Id: Ibbdde51c7257ab7d8db690dd97670ef570b52556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173123
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Miklos Vajna  <vmiklos@collabora.com>  [07df95e75a728fbbce03f6d6efdf9dbceab6c581]

        cool#9992 lok doc sign: async DocumentDigitalSignatures::ImplViewSignatures()
        
        Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
        to show the signatures dialog read-only, as only that is async.
        
        The next step is to make DocumentDigitalSignatures::ImplViewSignatures()
        async, though that requires all callers of the function to be async, so
        make DocumentDigitalSignatures::signScriptingContent() async as well.
        There is also DocumentDigitalSignatures::signPackage(), but turns out
        that's dead code, so just remove it.
        
        Once this is in place, we had a problem that the callbacks tried to
        interact with libxmlsec, but the dialog was still alive in
        DocumentDigitalSignatures::ImplViewSignatures() by the time the callback
        was running, so there were two DocumentSignatureManager instances at the
        same time, and both assumes it should call the global libxmlsec
        init/uninit, which resulted in failing to verify the just created
        signature.
        
        Fix this similar to how Tomaz fixed the same problem around pdfium in
        commit 067a8a954c8e1d8d6465a4ab5fb61e93f16c26c2 (pdfium: only init
        pdfium library one and destroy on LO exit, 2020-06-03).
        
        Change-Id: I3fb63c06195564732e1576dbd755157e676fb762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173117
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-10  Heiko Tietze  <tietze.heiko@gmail.com>  [854107d275aac0f4042a154145b95c34543f24c5]

        Resolves tdf#146906 - Keyboard shortcut conflict: Ctrl+F5
        
        * Removes ToggleControlFocus from accelerators
        
        Change-Id: I566307f680a528bb229cf640718e175602a42a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172870
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-10  Gökay Şatır  <gokaysatir@collabora.com>  [81780168e35dce08e3d30d95eb3b9e65849d5a14]

        Simplify GetObjectRectangles function with JSonWriter.
        
        This is a follow up for:
        * https://gerrit.libreoffice.org/c/core/+/171374
        
        Change-Id: I66bf8c100053907a0e2999730a6ef19e1144ae58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172883
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-10  Noel Grandin  <noelgrandin@gmail.com>  [880096c3a970389de9f1272509d2d03df046570a]

        no need to use dynamic_cast in SwDrawContact::GetTextObjectsFromFormat
        
        Change-Id: Ia970b120d338fc2924d5f2a86a7e85b276a01776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173107
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Noel Grandin  <noelgrandin@gmail.com>  [08d9f27a8f4d5a526b0e207a0bed03c0909322a0]

        fix casting of SpzFrameFormat
        
        we need to check before casting the items in GetSpzFrameFormats.
        
        The code in SwCursorShell::SelectNxtPrvHyperlink dates from
            commit 9624a1307c5317652af8961a560a8798029039ee
            Author: jp <jp@openoffice.org>
            Date:   Fri Feb 8 14:06:36 2002 +0000
            Task #96967#: add travel to next/prev hyperlink
        
        and the code in SwDoc::ForEachFormatURL is from
            commit 68566c28b962bf46d3ffc30c635efb37df19a58e
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Sep 8 10:29:21 2024 +0200
            dont use GetItemSurrogates for gathering SwFormatURL
        
        (Yes, I spotted the bad code __after__ I copied it, sigh).
        
        Change-Id: Iebbfba06e974bf780b644aa9c563ca23580c6870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173106
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Noel Grandin  <noelgrandin@gmail.com>  [e164e61f46d15612e6f3ef1eaaec758bed2a05c7]

        fix ubsan, partially revert
        
        this
           commit 43be09b29c28284c6585eaa48117e168f7c9c7b5
           Author: Noel Grandin <noel.grandin@collabora.co.uk>
           Date:   Fri Sep 6 15:27:43 2024 +0200
           return SwDrawFrameFormat  from SwContact::GetFrameFormat
        since we can also have SwFlyFrameFormat* being returned there
        
        Change-Id: Ide064ec39ccb99f3a166b869c552f54f482b9bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173108
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-10  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [7eef225e423698a51912cb09e0c247141062d24d]

        package : reduce varaible scope and use string_view
        
        Change-Id: I3d159edc47390375aae6857fa972c582e13f2774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172725
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-10  Oliver Specht  <oliver.specht@cib.de>  [3e8183e0c4b4c116cbd9187bfdfa7dfdf447805e]

        tdf#134902 Test added
        
        Import test added as follow-up to
        0d512cb88757ced10a825a3d544e41696a54341a
        to check that the imported shape is not visible.
        
        Change-Id: I9671930a5613021be20c75e021213dfda5e763cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171587
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-09-09  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [9c0cd7c60b138fa5265969dae3847a5e8e1ca923]

        tdf#76981 sd: opening linked presentation in slideshow mode
        
        If an Impress presentation(odp) is opened via a document link while in
        slideshow mode, the linked presentation should open in slideshow mode
        and close when finished. If it is opened while in editing mode, the
        linked presentation should open in editing mode.
        
        Change-Id: I3fd410872472ed6391b2150151810b5da32fa29b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172984
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ca8cf32d2f879dbead2f402eeef60edd3f0266e]

        tdf#162732 force centered alignment for donate button text
        
        bit of a bodge, gtk defaults to baseline alignment here, so force
        what we want instead in a separate "Donate" button.
        
        Change-Id: Iac7044c37f2e4c0e48b769c52612a3f5a2dfd350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-09  Justin Luth  <justin.luth@collabora.com>  [cea35086310d16f3f53f83fc18c1b8f26bae19da]

        writerfilter line spacing: don't convert PROP to PROP
        
        The default is FIX, and so the code assumed that if we got an AUTO
        then we would have to convert a FIXed height to a PROPortional height.
        
        But in this bizarre case, the pPrDefault had already been parsed once,
        so the property already had a proportional 108%
        which would never happen in any regular circumstances.
        
        But regardless, if we have a defined value that is proportional,
        and now we get an "auto",
        we can just leave the value as it is.
        
        Change-Id: I1562d736cbf3f2833a4a1f1edfc40897a7d4f92f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173105
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-09-09  Noel Grandin  <noelgrandin@gmail.com>  [56d35ad0eaccd353c8acd2a259293199e233e8ec]

        RES_CHRATR_HIGHLIGHT does not need surrogate support
        
        It is not queried anywhere using the surrogate APIs
        
        Change-Id: I056546b897d396bee49f600605e43f7e8f0addf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173082
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-09  Michael Weghorn  <m.weghorn@posteo.de>  [555eda2285aa727e0a67df85685f8c3ae5a114af]

        wina11y: Send IA2_EVENT_TEXT_UPDATED when text changes
        
        When the text changes, don't only send an
        MSAA/IAccessible `EVENT_OBJECT_VALUECHANGE` [1]
        event, but also an IAccessible2 `IA2_EVENT_TEXT_UPDATED` [2]
        event in the Windows a11y bridge.
        
        As described at [2]:
        
        > This event indicates general text changes, i.e. changes to
        > text that are exposed through the IAccessibleText interface.
        
        This e.g. makes that event type be sent when the value/text in
        one of the editable combobox in Writer's "Formatting" toolbar
        changes, e.g. the font size, which exposes its current text
        via the IAccessibleText interface.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/winauto/event-constants
        [2] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/_accessible_event_i_d_8idl.html#ae26846b6d521727ab696d20c3f43c0b5af9d3d9355e2cfd10b126d21513241609
        
        Change-Id: I83d3f2299c59bd9da4246723f99d1c55a351e6d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173080
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-09  Michael Weghorn  <m.weghorn@posteo.de>  [8cd08e0fb0d6a5fccfad6fbeb08b92b3429d49cb]

        wina11y: Replace deprecated IA2_EVENT_TEXT_CHANGED
        
        Send `IA2_EVENT_TEXT_UPDATED instead of the deprecated
        `IA2_EVENT_TEXT_CHANGED` event. Quoting from the
        IAccessible 2 doc [1]:
        
        > IA2_EVENT_TEXT_CHANGED: Deprecated. This event is
        > equivalent to IA2_EVENT_TEXT_UPDATED.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/_accessible_event_i_d_8idl.html#ae26846b6d521727ab696d20c3f43c0b5af9d3d9355e2cfd10b126d21513241609
        
        Change-Id: Iec1ba33ba4591c7608438dfdf7ac597e1746fc52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173079
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-09-09  Noel Grandin  <noelgrandin@gmail.com>  [8849c1d9cc7fbf990b1e1633b59a09c818dabc72]

        dont use GetItemSurrogates for gathering SwFormatField
        
        which is very expensive these days
        
        Change-Id: I830e7829ee3b919647f44ab060bf170e5cf42189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173035
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-09  Henry Castro  <hcastro@collabora.com>  [4f2a44849e74074b5c2741a8dec52229cf7d45e4]

        Resolves: tdf#162819 fix "NatNum12" preview string format
        
        The default value 0.00 does not translate the appropriative
        number literals.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I6577def4ccc7ff04c6b891a4df9384d1d58f4e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172909
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit a54bedd7924445abe74748110e54f3901380d469)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173086
        Tested-by: Jenkins

2024-09-09  Mike Kaganski  <mike.kaganski@collabora.com>  [b2257d1f78d7d678b87e2c3d590aba47bfec90f0]

        Improve run-time Currency type support in Basic
        
        Change-Id: I1e04c6022944034a30ef896b8cd24050ebe3bbd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173042
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-09  Miklos Vajna  <vmiklos@collabora.com>  [caff013bee53216efeb49db4bcda44b55c223b58]

        cool#9992 lok doc sign: async DocumentDigitalSignatures::signDocumentContent()
        
        Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
        to show the signatures dialog read-only, as only that is async.
        
        The next step is to make
        DocumentDigitalSignatures::signDocumentContent() async, but passing an
        std::function via the UNO API is tricky.
        
        Notice how DocumentDigitalSignatures in xmlsecurity/ also implements
        sfx2::DigitalSignatures, add a new SignDocumentContentAsync() there and
        adapt all uses of signDocumentContent() to go with that instead.
        
        This requires introducing some lambdas for code after
        signDocumentContent() in general and for ODF/OOXML specific code in
        particular, to avoid code duplication.
        
        Change-Id: If771ced711041364988af45ad9dd0dd1a2a8660d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173060
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [602466268467b0f4b356d4613c6c649449503d1c]

        sw: remove long commented out code
        
        Since:
        commit d6274bdd7062d08920dfdaff5b6a154d27298cca
        Author: Frank Meies <fme@openoffice.org>
        Date:   Fri Nov 23 13:47:18 2001 +0000
        
            Fix #95173#: Do not crash if no screen font available
        
        Change-Id: I2a7da5ba64c48c76bb8aa32d00837db001bfb2c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173075
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9ff22db058180d161b32f5dcd87e72cfa3b6889]

        tsan:lock-order-inversion in forms
        
        ==================
        WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
        (pid=14614)
        Cycle in lock order graph: M0 (0x720c004ac190) => M1 (0x720c004a8200) =>
        M0
        
        Mutex M1 acquired here while holding mutex M0 in thread T43:
        2 osl::Mutex::acquire() /home/noel/libo-tsan/include/osl/mutex.hxx:63
        (libuno_cppuhelpergcc3.so.3+0x8fdd9)
        3 osl::Guard<osl::Mutex>::Guard(osl::Mutex&)
        /home/noel/libo-tsan/include/osl/mutex.hxx:144
        (libuno_cppuhelpergcc3.so.3+0x8fdd9)
        4 cppu::OBroadcastHelperVar<cppu::OMultiTypeInterfaceContainerHelper,
        com::sun::star::uno::Type>::addListener(com::sun::star::uno::Type
        const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&) /home/noel/libo-tsan/include/cppuhelper/interfacecontainer.h:468
        (libuno_cppuhelpergcc3.so.3+0x8fdd9)
        5
        cppu::OPropertySetHelper::addPropertiesChangeListener(com::sun::star::uno::Sequence<rtl::OUString>
        const&,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener>
        const&) /home/noel/libo-tsan/cppuhelper/source/propshlp.cxx:912
        (libuno_cppuhelpergcc3.so.3+0x8fdd9)
        6
        comphelper::OPropertySetAggregationHelper::addPropertiesChangeListener(com::sun::star::uno::Sequence<rtl::OUString>
        const&,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener>
        const&) /home/noel/libo-tsan/comphelper/source/property/propagg.cxx:495
        (libcomphelper.so+0x1a1865)
        7 comphelper::OPropertySetAggregationHelper::startListening()
        /home/noel/libo-tsan/comphelper/source/property/propagg.cxx:466
        (libcomphelper.so+0x1a1416)
        ^^^ Mutex M0 previously acquired by the same thread here:
        8
        comphelper::OPropertySetAggregationHelper::addPropertyChangeListener(rtl::OUString
        const&,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener>
        const&) /home/noel/libo-tsan/comphelper/source/property/propagg.cxx:488
        (libcomphelper.so+0x1a181a)
        9 non-virtual thunk to
        comphelper::OPropertySetAggregationHelper::addPropertyChangeListener(rtl::OUString
        const&,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener>
        const&) /home/noel/libo-tsan/comphelper/source/property/propagg.cxx:?
        (libcomphelper.so+0x1a181a)
        10 frm::OInterfaceContainer::implInsert(int,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>
        const&, bool, frm::ElementDescription*, bool)
        /home/noel/libo-tsan/forms/source/misc/InterfaceContainer.cxx:787
        (libfrmlo.so+0x23e03c)
        11 frm::OInterfaceContainer::insertByIndex(int, com::sun::star::uno::Any
        const&)
        /home/noel/libo-tsan/forms/source/misc/InterfaceContainer.cxx:904
        (libfrmlo.so+0x240644)
        12 non-virtual thunk to frm::OInterfaceContainer::insertByIndex(int,
        com::sun::star::uno::Any const&)
        /home/noel/libo-tsan/forms/source/misc/InterfaceContainer.cxx:?
        (libfrmlo.so+0x240716)
        13 FmXUndoEnvironment::Inserted(FmFormObj*)
        /home/noel/libo-tsan/svx/source/form/fmundo.cxx:424
        (libsvxcorelo.so+0x41b2a4)
        14 FmXUndoEnvironment::Inserted(SdrObject*)
        /home/noel/libo-tsan/svx/source/form/fmundo.cxx:336
        (libsvxcorelo.so+0x41a982)
        15 FmXUndoEnvironment::Notify(SfxBroadcaster&, SfxHint const&)
        /home/noel/libo-tsan/svx/source/form/fmundo.cxx:292
        (libsvxcorelo.so+0x41a8a0)
        16 non-virtual thunk to FmXUndoEnvironment::Notify(SfxBroadcaster&,
        SfxHint const&) /home/noel/libo-tsan/svx/source/form/fmundo.cxx:?
        (libsvxcorelo.so+0x41acd2)
        17 SfxBroadcaster::Broadcast(SfxHint const&)
        /home/noel/libo-tsan/svl/source/notify/SfxBroadcaster.cxx:40
        (libsvllo.so+0xe7c3d)
        18 SdrObjList::InsertObject(SdrObject*, unsigned long)
        /home/noel/libo-tsan/svx/source/svdraw/svdpage.cxx:351
        (libsvxcorelo.so+0x6fdf3a)
        19 FmFormPage::InsertObject(SdrObject*, unsigned long)
        /home/noel/libo-tsan/svx/source/form/fmpage.cxx:79
        (libsvxcorelo.so+0x3c1e05)
        20
        SvxDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&) /home/noel/libo-tsan/svx/source/unodraw/unopage.cxx:191
        (libsvxcorelo.so+0x850c7b)
        21
        SwFmDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&) /home/noel/libo-tsan/sw/source/core/unocore/unodraw.cxx:649
        (libswlo.so+0xc30712)
        22 non-virtual thunk to
        SwFmDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&) /home/noel/libo-tsan/sw/source/core/unocore/unodraw.cxx:?
        (libswlo.so+0xc31732)
        23 gcc3::callVirtualMethod(void*, unsigned int, void*,
        _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int,
        unsigned long*, double*)
        /home/noel/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:87
        (libgcc3_uno.so+0xd92a)
        24 cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*,
        bridges::cpp_uno::shared::VtableSlot,
        _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*,
        void*, void**, _uno_Any**)
        /home/noel/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:229
        (libgcc3_uno.so+0xcc3c)
        25 unoInterfaceProxyDispatch
        /home/noel/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:409
        (libgcc3_uno.so+0xc1f6)
        
        Mutex M0 acquired here while holding mutex M1 in thread T44:
        3 osl::Guard<osl::Mutex>::Guard(osl::Mutex&)
        /home/noel/libo-tsan/include/osl/mutex.hxx:144
        (libcomphelper.so+0x1bde34)
        4
        comphelper::OPropertyChangeListener::setAdapter(comphelper::OPropertyChangeMultiplexer*)
        /home/noel/libo-tsan/comphelper/source/property/propmultiplex.cxx:58
        (libcomphelper.so+0x1bde34)
        5
        comphelper::OPropertyChangeMultiplexer::disposing(com::sun::star::lang::EventObject
        const&)
        /home/noel/libo-tsan/comphelper/source/property/propmultiplex.cxx:120
        (libcomphelper.so+0x1bde34)
        6 non-virtual thunk to
        comphelper::OPropertyChangeMultiplexer::disposing(com::sun::star::lang::EventObject
        const&)
        /home/noel/libo-tsan/comphelper/source/property/propmultiplex.cxx:?
        (libcomphelper.so+0x1bdf12)
        7
        cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject
        const&)
        /home/noel/libo-tsan/cppuhelper/source/interfacecontainer.cxx:272
        (libuno_cppuhelpergcc3.so.3+0x66524)
        8
        cppu::OMultiTypeInterfaceContainerHelperInt32::disposeAndClear(com::sun::star::lang::EventObject
        const&)
        /home/noel/libo-tsan/cppuhelper/source/interfacecontainer.cxx:577
        (libuno_cppuhelpergcc3.so.3+0x68af0)
        9 cppu::OPropertySetHelper::disposing()
        /home/noel/libo-tsan/cppuhelper/source/propshlp.cxx:246
        (libuno_cppuhelpergcc3.so.3+0x8be45)
        10 comphelper::OPropertySetAggregationHelper::disposing()
        /home/noel/libo-tsan/comphelper/source/property/propagg.cxx:366
        (libcomphelper.so+0x1a0321)
        ^^^ Mutex M1 previously acquired by the same thread here:
        11 frm::OControlModel::disposing()
        /home/noel/libo-tsan/forms/source/component/FormComponent.cxx:705
        (libfrmlo.so+0x19eecc)
        12 frm::ORichTextModel::disposing()
        /home/noel/libo-tsan/forms/source/richtext/richtextmodel.cxx:295
        (libfrmlo.so+0x267bdb)
        13 cppu::OComponentHelper::dispose()
        /home/noel/libo-tsan/cppuhelper/source/component.cxx:159
        (libuno_cppuhelpergcc3.so.3+0x4504f)
        14 non-virtual thunk to cppu::OComponentHelper::dispose()
        /home/noel/libo-tsan/cppuhelper/source/component.cxx:?
        (libuno_cppuhelpergcc3.so.3+0x45379)
        15 frm::OControlModel::disposing()
        /home/noel/libo-tsan/forms/source/component/FormComponent.cxx:708
        (libfrmlo.so+0x19ef13)
        16 frm::OBoundControlModel::disposing()
        /home/noel/libo-tsan/forms/source/component/FormComponent.cxx:1340
        (libfrmlo.so+0x1a507f)
        17 frm::OEditModel::disposing()
        /home/noel/libo-tsan/forms/source/component/Edit.cxx:301
        (libfrmlo.so+0x161208)
        18 cppu::OComponentHelper::dispose()
        /home/noel/libo-tsan/cppuhelper/source/component.cxx:159
        (libuno_cppuhelpergcc3.so.3+0x4504f)
        19 non-virtual thunk to cppu::OComponentHelper::dispose()
        /home/noel/libo-tsan/cppuhelper/source/component.cxx:?
        (libuno_cppuhelpergcc3.so.3+0x45379)
        20 SdrUnoObj::~SdrUnoObj()
        /home/noel/libo-tsan/svx/source/svdraw/svdouno.cxx:214
        (libsvxcorelo.so+0x6f471b)
        21 FmFormObj::~FmFormObj()
        /home/noel/libo-tsan/svx/source/form/fmobj.cxx:119
        (libsvxcorelo.so+0x3bd8cf)
        22 FmFormObj::~FmFormObj()
        /home/noel/libo-tsan/svx/source/form/fmobj.cxx:112
        (libsvxcorelo.so+0x3bd985)
        23 SdrObject::release()
        /home/noel/libo-tsan/svx/source/svdraw/svdobj.cxx:486
        (libsvxcorelo.so+0x6634df)
        24 rtl::Reference<SdrObject>::~Reference()
        /home/noel/libo-tsan/include/rtl/ref.hxx:126 (libsvxcorelo.so+0x61610d)
        25 void std::destroy_at<rtl::Reference<SdrObject>
        >(rtl::Reference<SdrObject>*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88
        (libsvxcorelo.so+0x61610d)
        26 void std::_Destroy<rtl::Reference<SdrObject>
        >(rtl::Reference<SdrObject>*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149
        (libsvxcorelo.so+0x61610d)
        27 void
        std::_Destroy_aux<false>::__destroy<rtl::Reference<SdrObject>*>(rtl::Reference<SdrObject>*,
        rtl::Reference<SdrObject>*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163
        (libsvxcorelo.so+0x61610d)
        28 void
        std::_Destroy<rtl::Reference<SdrObject>*>(rtl::Reference<SdrObject>*,
        rtl::Reference<SdrObject>*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:195
        (libsvxcorelo.so+0x61610d)
        29 void std::_Destroy<rtl::Reference<SdrObject>*,
        rtl::Reference<SdrObject> >(rtl::Reference<SdrObject>*,
        rtl::Reference<SdrObject>*, std::allocator<rtl::Reference<SdrObject> >&)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948
        (libsvxcorelo.so+0x61610d)
        30 std::vector<rtl::Reference<SdrObject>,
        std::allocator<rtl::Reference<SdrObject> > >::~vector()
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:735
        (libsvxcorelo.so+0x61610d)
        31 SdrModel::ClearModel(bool)
        /home/noel/libo-tsan/svx/source/svdraw/svdmodel.cxx:623
        (libsvxcorelo.so+0x61610d)
        32 SwDrawModel::~SwDrawModel()
        /home/noel/libo-tsan/sw/source/core/draw/drawdoc.cxx:108
        (libswlo.so+0x714650)
        33 std::default_delete<SwDrawModel>::operator()(SwDrawModel*) const
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:99
        (libswlo.so+0x5a3082)
        34 std::__uniq_ptr_impl<SwDrawModel, std::default_delete<SwDrawModel>
        >::reset(SwDrawModel*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:211
        (libswlo.so+0x5a3082)
        35 std::unique_ptr<SwDrawModel, std::default_delete<SwDrawModel>
        >::reset(SwDrawModel*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:509
        (libswlo.so+0x5a3082)
        36 sw::DocumentDrawModelManager::ReleaseDrawModel()
        /home/noel/libo-tsan/sw/source/core/doc/DocumentDrawModelManager.cxx:162
        (libswlo.so+0x5a3082)
        37 SwDoc::~SwDoc()
        /home/noel/libo-tsan/sw/source/core/doc/docnew.cxx:585
        (libswlo.so+0x5457c8)
        38 SwDoc::release() /home/noel/libo-tsan/sw/source/core/doc/doc.cxx:129
        (libswlo.so+0x4b8993)
        39 rtl::Reference<SwDoc>::clear()
        /home/noel/libo-tsan/include/rtl/ref.hxx:193 (libswlo.so+0x104c301)
        40 SwDocShell::RemoveLink()
        /home/noel/libo-tsan/sw/source/uibase/app/docshini.cxx:444
        (libswlo.so+0x104c301)
        41 SwDocShell::~SwDocShell()
        /home/noel/libo-tsan/sw/source/uibase/app/docshini.cxx:372
        (libswlo.so+0x104bf36)
        42 SwDocShell::~SwDocShell()
        /home/noel/libo-tsan/sw/source/uibase/app/docshini.cxx:362
        (libswlo.so+0x104c469)
        43 non-virtual thunk to SwDocShell::~SwDocShell()
        /home/noel/libo-tsan/sw/source/uibase/app/docshini.cxx:?
        (libswlo.so+0x104c469)
        44 cppu::OWeakObject::release()
        /home/noel/libo-tsan/cppuhelper/source/weak.cxx:230
        (libuno_cppuhelpergcc3.so.3+0x105ae7)
        45 rtl::Reference<SfxObjectShell>::~Reference()
        /home/noel/libo-tsan/include/rtl/ref.hxx:126 (libsfxlo.so+0x5209e5)
        46 IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer()
        /home/noel/libo-tsan/sfx2/source/doc/sfxbasemodel.cxx:265
        (libsfxlo.so+0x5209e5)
        47 void
        std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88
        (libsfxlo.so+0x51f4e6)
        48 void
        std::_Destroy<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149
        (libsfxlo.so+0x51f4e6)
        49 void std::allocator_traits<std::allocator<void>
        >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<void>&,
        IMPL_SfxBaseModel_DataContainer*)
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:675
        (libsfxlo.so+0x51f4e6)
        50 std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer,
        std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose()
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/shared_ptr_base.h:613
        (libsfxlo.so+0x51f4e6)
        51 SfxBaseModel::dispose()
        /usr/lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/shared_ptr_base.h:175
        (libsfxlo.so+0x4e7c7c)
        52 SwXTextDocument::dispose()
        /home/noel/libo-tsan/sw/source/uibase/uno/unotxdoc.cxx:562
        (libswlo.so+0x13896e1)
        53 SfxBaseModel::close(unsigned char)
        /home/noel/libo-tsan/sfx2/source/doc/sfxbasemodel.cxx:1526
        (libsfxlo.so+0x4eed16)
        54 SwXTextDocument::close(unsigned char)
        /home/noel/libo-tsan/sw/source/uibase/uno/unotxdoc.cxx:575
        (libswlo.so+0x138999c)
        55 non-virtual thunk to SwXTextDocument::close(unsigned char)
        /home/noel/libo-tsan/sw/source/uibase/uno/unotxdoc.cxx:?
        (libswlo.so+0x1389ad3)
        56 gcc3::callVirtualMethod(void*, unsigned int, void*,
        _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int,
        unsigned long*, double*)
        /home/noel/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:87
        (libgcc3_uno.so+0xd92a)
        
        Change-Id: Ie16fc0ff7462632a591a46025a38344006d43c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173068
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [07db23624497d303dca142ba9376cdcf265b20d8]

        tsan:lock-order-inversion in forms
        
        ThreadSanitizer: lock-order-inversion (potential deadlock)
        Cycle in lock order graph: M0 (0x720c00011640) => M1 (0x720c00474120) =>
        M0
        
        Mutex M1 acquired here while holding mutex M0 in thread T8:
        3 osl::Guard<osl::Mutex>::Guard(osl::Mutex&)
        4
        comphelper::OPropertySetAggregationHelper::setAggregation(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&)
          ^^ acquires cppu mutex
        5 frm::ODatabaseForm::impl_construct()
        6
        frm::ODatabaseForm::ODatabaseForm(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&)
        7 com_sun_star_comp_forms_ODatabaseForm_get_implementation
        12
        cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&)
        13
        cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, bool)
        14 cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString
        const&,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&)
        15 cppuhelper::ServiceManager::createInstance(rtl::OUString const&)
        16 non-virtual thunk to
        cppuhelper::ServiceManager::createInstance(rtl::OUString const&)
        17 FmFormPageImpl::getDefaultForm()
        18
        FmFormPageImpl::findPlaceInFormComponentHierarchy(com::sun::star::uno::Reference<com::sun::star::form::XFormComponent>
        const&,
        com::sun::star::uno::Reference<com::sun::star::sdbc::XDataSource>
        const&, rtl::OUString const&, rtl::OUString const&, int)
        19 FmXUndoEnvironment::Inserted(FmFormObj*)
        20 FmXUndoEnvironment::Inserted(SdrObject*)
        21 FmXUndoEnvironment::Notify(SfxBroadcaster&, SfxHint const&)
        22 non-virtual thunk to FmXUndoEnvironment::Notify(SfxBroadcaster&,
        SfxHint const&)
        23 SfxBroadcaster::Broadcast(SfxHint const&)
        24 SdrObjList::InsertObject(SdrObject*, unsigned long)
        25 FmFormPage::InsertObject(SdrObject*, unsigned long)
        26
        SvxDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&)
        27
        SwFmDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&)
          ^^ acquires solar mutex
        28 non-virtual thunk to
        SwFmDrawPage::add(com::sun::star::uno::Reference<com::sun::star::drawing::XShape>
        const&)
        33 binaryurp::IncomingRequest::execute() const
        35 cppu_threadpool::JobQueue::enter(void const*, bool)
        
        Mutex M0 acquired here while holding mutex M1 in thread T8:
        6 SolarMutexClearableGuard::SolarMutexClearableGuard()
        7 SfxModelGuard::SfxModelGuard(SfxBaseModel const&,
        SfxModelGuard::AllowedModelState)
          ^^ acquires solar mutex
        8 SfxBaseModel::getArgs2(com::sun::star::uno::Sequence<rtl::OUString>
        const&)
        9 SfxBaseModel::getArgs()
        10 SwXTextDocument::getArgs()
        11 non-virtual thunk to SwXTextDocument::getArgs()
        12
        dbtools::isEmbeddedInDatabase(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&,
        com::sun::star::uno::Reference<com::sun::star::sdbc::XConnection>&)
        13 frm::ODatabaseForm::setFastPropertyValue_NoBroadcast(int,
        com::sun::star::uno::Any const&)
        15 cppu::OPropertySetHelper::setFastPropertyValue(int,
        com::sun::star::uno::Any const&)
          ^^ acquires cppu mutex
        16 comphelper::OPropertySetAggregationHelper::setFastPropertyValue(int,
        com::sun::star::uno::Any const&)
        17 cppu::OPropertySetHelper::setPropertyValue(rtl::OUString const&,
        com::sun::star::uno::Any const&)
        18 non-virtual thunk to
        cppu::OPropertySetHelper::setPropertyValue(rtl::OUString const&,
        com::sun::star::uno::Any const&)
        20 cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*,
        bridges::cpp_uno::shared::VtableSlot,
        _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*,
        void*, void**, _uno_Any**)
        /home/noel/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:229
        (libgcc3_uno.so+0x2118a)
        22 binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*,
        std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny>
        >*) const
        23 binaryurp::IncomingRequest::execute() const
        
        Change-Id: I00de2ad02b7ab247ee0aa62abcb11f5d46c9b157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173067
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22cb250074606a9e637787245f8e18a11ac5c252]

        Resolves: tdf#162113 prefer restoring explicit font style selection
        
        so when scrolling through fonts that might not have the original or
        explicitly picked style, then on moving to the next font that does have
        that style, then the original bold/italic/etc gets picked again.
        
        Change-Id: If818a116ed4ab248cb67f60845acad2cd4eeb8ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173071
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-09  Jonathan Clark  <jonathan@libreoffice.org>  [6eb0523e27473fe2ebe281b2682a5045f3b39312]

        tdf#162803 editeng: Fix invalid kashida array after layout
        
        This change updates editeng to clear the kashida array during layout, at
        the same time it clears other justification data.
        
        Previously, editeng could recycle stale kashida arrays and apply them to
        lines with different lengths. This would result in stray kashida
        rendered at inappropriate positions in lines, or accessing memory past
        the end of the kashida array, resulting in assertions or
        nondeterministic crashes.
        
        Change-Id: I9c06239298d630f2d61b5e67a54f4c3e079c1193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172967
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-09  Rashesh  <rashesh.padia@collabora.com>  [7e93e2721f200940547a23814eccc2348e1d6adf]

        sc: make SelectRange dialog async
        
        Change-Id: Id1ac622d7a2f15d432fa122b87217c0bfa9a39a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172626
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 832eee15118babf772f19a820ef88603fb6e5ccd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173066
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-09  Rashesh  <rashesh.padia@collabora.com>  [9672841f6d4afb11debe268ee45a686643c54a4e]

        lokit: calc: send named ranges as well on calcfunctionlist callback
        
        Change-Id: Ib8082d81da0eec54ba201b5958b86770a508ec91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172099
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit d805785b2cf7c570fc0bb480100bc50d8fbc5077)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172745
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [93441942a9032c290996abfa68f27ef32f1a4e0d]

        fix GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel'
        
        Change-Id: I35d615948c4d7fe0fd95014d225fff188de5639d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173072
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-09  Bayram Çiçek  <bayram.cicek@collabora.com>  [886d9d3e25ea051b19ad27e5769d097d3782df5d]

        add autofillpreviewtooltip type for LOK_CALLBACK_TOOLTIP
        
        - during autofilling of cells, there is a preview shows the cell value before filling
        - we need to send tooltip text and location info by using LOK_CALLBACK_TOOLTIP
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I9961764007aece9122c03eff7c155e7f3f25d9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172589
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 4a8731411bfdc51d042c6df52d0c2391a03ea028)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173023
        Tested-by: Jenkins

2024-09-09  Justin Luth  <jluth@mail.com>  [1de6bea27ed36167ec138818607da7b49e92ec4a]

        tdf#143899 compat15 layout: restrict body fly to PAGE_PRINT_AREA
        
        For some inexplicable reason,
        Microsoft decided to change a non-table layout restriction
        for DOCX >= 2013.
        
        Now most floating objects are not allowed to cross
        the vertical margin (header/footer) boundaries
        (although floating tables are one exception)
        (and so are framePr textboxes)
        (and horizontal margin boundaries can still be crossed).
        
        This is similar to layoutInCell's
        whimsical vertical aversion to margins.
        
        There are already good unit tests in place
        to ensure compat14 works, and for the compat15 table exception.
        (see earlier patchsets for all affected unit tests)
        
        make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf103544
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf143899
        
        Change-Id: I5788c35e57cbc84a6b5fcd0ef97dc4394b0f6395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172536
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dce8738344e8fb6d000c71feb6a02e570e4660ec]

        update credits
        
        Change-Id: Ic881ef1c3575c8bd922db829aedcb7a22f9a6c72

2024-09-09  Oliver Specht  <oliver.specht@cib.de>  [d6f2f115c721e0b8337679472e1e106a998a62d4]

        tdf#162268: Import - add zero width space after line break
        
        If a paragraph ends with a line break Word applies the paragraph
        properties to the last line. Writer extends the properties of the
        las run.
        The new line could be smaller or bigger as it would be in Word.
        To prevent that a zero width space is added at the end of the
        paragraph if the character properties of the run differ to
        the properties of the paragraph.
        Additionally attributes are not applied to the current font if the
        portion is hidden.
        
        Change-Id: I128d67bb621fb99d9db008cccbb93733f255294e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170629
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-09-09  Miklos Vajna  <vmiklos@collabora.com>  [7aece6a3399c0fe29a49e3d7218f98d5f0383e65]

        svx: prefix members of SdrPageView
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia11aaae771deb99f72af86670318c3822c1d139f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173056
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4768ee57da0f4e2004c1bc60b19cae49eafe0497]

        can only be mbInsPolyPoint or IsInsertGluePoint()
        
        Change-Id: I5378895e936cfcc524f769754148f96cfbd8685d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173053
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe42f7c23b8816a930a204c0d5f104dee207b345]

        cid#1556149 disentangle this undo code a little
        
        Change-Id: Id4bf243276f16a7e840df0cacf2ca4151b49ca46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173052
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1ff238e5703507ad9d60810d20817052e5b43390]

        enforce null checking of AcquireTheme return
        
        Change-Id: I184603be25be734ec377439622872406ef74898a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9988b57b3acaf2541b4cf4bbf7c972f056b37e9]

        Fix typo
        
        Change-Id: I9e50718206fa2f139dca586688eb468667b28172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173054
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [005eaf799a1e5424751d059afc09c92ea9b29566]

        tdf#162852 Fix minimum comment sidebar width
        
        If the mouse is released over the document, the value of nPxWidth can get negative, so we need a signed integer variable here to make std::clamp work as expected.
        
        Change-Id: I721b53e9eddee4f02ad31718f8c7187242ba44e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173016
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-09  Noel Grandin  <noelgrandin@gmail.com>  [5650b8a66231033a03ae9e4c35d5aaab907655d6]

        dont use GetItemSurrogates for gathering SvxOverlineItem
        
        which is very expensive these days
        
        Change-Id: I0ac24ba8ef4df9310b9e6ca5cfd7a132a61bb889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173049
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-09  Oliver Specht  <oliver.specht@cib.de>  [b59df057122f5819140d844bd395cff95fbabfcc]

        tdf#137335 follow-up to f806fc136b3410ec9a1e09320d100c78b33c867b
        
        Fixes 'always true'  part in else statement
        
        Change-Id: Ie8a8926601a23ee3259469452619ab5dde2e5132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171266
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>

2024-09-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3231db0341baffd2547c50d36ef7c00aaa11601d]

        cid#1618764 Operands don't affect result
        
        Change-Id: I4faf81b030f3f7b704b25e4817f0ec6c07be4e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [248777ee5135870faecf4188cac0ab3cf708e8e2]

        Add a comment about possible use of standard functions, when/if available
        
        Change-Id: Ia5c217c7388c1f8198cfb09fb5733c1ab08bc12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173043
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-08  Laurent Balland  <laurent.balland@mailo.fr>  [752235a69024f36e28107fde1b3648fe1ea6174c]

        Update Freshes Impress template
        
        - correct position for Footer and Page in Notes view
        - set black font color for all elements of Notes and Handout
        - simplify Header/Footer/Date/Page elements
        
        Change-Id: I973f6a770fa1b4ac0a22375cff8ae1a5e440ae0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173046
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-08  Laurent Balland  <laurent.balland@mailo.fr>  [0efa92a4b0896ab2270a25f5b5bdce25e336972a]

        Update Candy Impress template
        
        - some simplification in Header/footer in Handout/Notes/ Master slides
        - remove some useless styles
        
        Change-Id: I197575f3b1b6d19254874b31e45f4f206490091a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173045
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-08  Noel Grandin  <noelgrandin@gmail.com>  [68566c28b962bf46d3ffc30c635efb37df19a58e]

        dont use GetItemSurrogates for gathering SwFormatURL
        
        which is very expensive these days
        
        Change-Id: I6dbd6d1c66cd28c4f916842cd95f000215e52bc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-08  Jean-Pierre Ledure  <jp@ledure.be>  [70f3fea2f3956ec7344be45d035aafe12905896f]

        ScriptForge (Dictionary) support case-sensitive keys
        
        To enhance the compatibility between
         - sf dictionaries
         - python dicts
         - arrays of PropertyValues
        it was necessary to propose the support
        of case-sensitive keys, i.e. keys are
        different if a case-sensitive comparison
        finds them different.
        
        So far only not case-sensitive keys
        were supported.
        
        This required a re-visit of the implementation
        of the ScriptForge.SF_Dictionary service. So far
        it was built upon a Basic Collection class which
        differentiates keys not case-sensitively. The
        new implementation uses sorted arrays.
        
        The invocation of the service is now:
           dict = CreateScriptService("Dictionary", True/False)
        True means case-sensitive keys.
        Default = False, which preserves the compatibility
        with the past.
        
        ScriptForge uses dictionaries internally in
        several places. For each of them it has been
        assessed if the new attribute was justified
        or not. For most of the contexts, it was.
        
        The functionality makes sense only for Basic
        user scripts.
        
        The documentation of the Dictionary page
        should be revised according to the new invocation
        syntax.
        
        Change-Id: If1f695bcbf1673a2b71c1e41487b1781caab71c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173044
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-09-08  Laurent Balland  <laurent.balland@mailo.fr>  [7639d707034cbd6e578be7e074e73d4ab4b3563c]

        Update Grey Elegant Impress template
        
        - simplify font definition
        - remove writing mode tags
        - remove empty text from shapes
        - remove unused styles
        - replace PNG/SVG pictures by path
        - remove useless miror information
        - replace puzzle shapes on Jingsaw master slide
        
        Change-Id: I3009511616f29a3ac98dfcf0ca48dd20b6a901ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173041
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-08  Jean-Pierre Ledure  <jp@ledure.be>  [609a6dc2df2492d75bad2a77b24c588a977d408d]

        ScriptForge New IsAlive property
        
        When a document is closed inadvertently
        by the user during a macro run, or between
        two macros triggered by events, the actual
        behaviour is an error message and a stop
        of the execution of the macro.
        
        As this can be counter-productive, the macro
        may test at any moment if everything is ok
        with the
           IsAlive As Boolean (True = OK)
        property applied on next service instances:
           Document
           Base
           Calc
           FormDocument
           Writer
           Datasheet
           Dialog
        
        The functionality is available both for
        Basic and Python user scripts.
        
        The user documentation should be completed
        accordingly.
        
        Change-Id: I0b055dacc06c9da70c611dbb4e7bf841160168fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172970
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>

2024-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a6a957405e5c9d8639e709916fe7b5bbd472676b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1c125b79ba1140d894aa2ef71692394218bf3ff
          - tdf#162607 Remove dup's in hid2file.js, signature
            
            + fixed bad bookmarks in signature
            + in load/save options
            + refactor
            
            Change-Id: Ia2fa2c981775b1a6a951f100d52de97cb45e81cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173030
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5df98564ce5a55d2f68a31bb4fd055100401f916]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd76f630da7ec75c86340f62aee37dd6c1280ba8
          - tdf#162607 Remove dup's in hid2file.js, SD_HID*
            
            + deleted dup SD_HID_SD_CUSTOMANIMATIONPANE_PRESETPROPERTYBOX
            + refactor
            
            Change-Id: Idc35560497ba5b79cdfb2e62ec06d74013ab8a79
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173029
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-08  Julien Nabet  <serval2412@yahoo.fr>  [403075b4614d2926a07cb43806c3e9ef311ee779]

        tdf#155751: dBase: BETWEEN won't include first and last value in queries
        
        Since the beginning:
        commit 86c5930e98a48fef73253535fa7508c187a093f0
        Author: Jens-Heiner Rechtien <hr@openoffice.org>
        Date:   Mon Aug 2 16:04:09 2004 +0000
        
            INTEGRATION: CWS insight01 (1.19.14); FILE MERGED
            2004/06/03 14:48:29 oj 1.19.14.3: #i18836# imple between key word
            2004/05/28 11:16:26 oj 1.19.14.2: RESYNC: (1.19-1.20); FILE MERGED
            2004/05/12 10:48:11 oj 1.19.14.1: change SQLFilterOperator
        
        Change-Id: I75d00c313072e08279ca2f37cb65bb3414447d16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173036
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-08  Noel Grandin  <noelgrandin@gmail.com>  [7f50471615fb1b083e6c4735892359d269573e81]

        dont use GetItemSurrogates for gathering SwFormatINetFormat
        
        which is very expensive these days
        
        Change-Id: I7b552d9fec5e2971bb3c171b7dd132ee31b1a46e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-08  Noel Grandin  <noelgrandin@gmail.com>  [1669fc8b94adf37e4a23feedc0fa486ac2592030]

        dont use GetItemSurrogates for gathering SwFormatRuby
        
        which is very expensive these days
        
        Change-Id: I67a37cfdd758f843902dc76ebb5da34b76ad9853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c8eb95e8407ef24436e0e8e218dce535df6bb2e5]

        cid#1619147 Dereference before null check
        
        maybe it possible in --headless that ShowMarkWnd launches
        
        weld::DialogController::runAsync(mxMarkWnd, [this](sal_Int32 /*nResult*/) { mxMarkWnd.reset(); } );
        
        and the auto-cancel calls mxMarkWnd.reset() immediately?
        
        Otherwise, not sure how this could come about.
        
        Change-Id: I761ee7450a8ba54b2a7f75d4ee116c30319ddaa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172976
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec1a56b2e13f3a70a53adc6308f34ecc950600fa]

        sd: fix deref before null check
        
        Seen in https://crashreport.libreoffice.org/stats/signature/static%20const%20class%20com::sun::star::uno::Reference%3Ccom::sun::star::drawing::framework::XResourceId%3E%20%60sd::ViewShell::BroadcastContextForActivation'::%602'::%3Clambda_1%3E::operator()()
        
        Regression from
        commit 5e143492320dac8cdf8b2956799ca366f3d8e72c
        Author: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Date:   Fri Jun 7 21:14:44 2024 +0200
        
            tdf#33603: fix notespane (side/tool)bar interactions
        
        Change-Id: Ic6b821a660d5b5aa444224fcb6b0b4eccba5a85a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172999
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [c9f2ec93939417a120f26d64c2b2dff380e81286]

        xmloff: fix deref before null check
        
        Seen in https://crashreport.libreoffice.org/stats/signature/SvXMLExport::ExportThemeElement(std::shared_ptr%3Cmodel::Theme%3E%20const%20&)
        
        Change-Id: I12b9c3cf064100fb6cfeaaf2828dbf08e7dd8a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173000
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-07  Julien Nabet  <serval2412@yahoo.fr>  [c0fd5f82ff96ab8d5df166aae654243dce0beea2]

        tdf#162833: don't use an OUStringBuffer directly in a concat to assign itself
        
        SUM( CASE WHEN \"dtPayTyp\" = 1 THEN \"dtPayBetrag\" * - 1 ELSE \"dtPayBetrag\" END )
        is transformed into:
        Sum(Sum( WHEN \"dtPayTyp\" = 1 THEN \"dtPayBetrag\" * - 1 ELSE \"dtPayBetrag\" END)
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=162833#c3
        
        Change-Id: Ie73dd6871bcda1c22cf6f469bd05ecc4d9dacb4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172989
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [eef52a368001c4b99381eecde0945601004e55ef]

        svx: maLocalListner -> maLocalListener
        
        Change-Id: Ie9ba310fcc57f27bcdbeb8dcb9ca1e0ecb35df0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a0c79aace5b93b597d827485da87b10d0d6cecc]

        svx: fix Dereference before null check
        
        Seen in https://crashreport.libreoffice.org/stats/signature/GalleryBrowser1::FillThemeEntries()
        
        Regression from
        commit 09c6204b6309321aa25c542f918fde9f5f3f7fe2
        Author: Oliver Specht <oliver.specht@cib.de>
        Date:   Thu Feb 29 17:15:23 2024 +0100
        
            tdf#81880 Search the Gallery
        
        Change-Id: I4c19920b5f7a56fff37587cd1acf579f3a96ae4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172997
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-07  Noel Grandin  <noelgrandin@gmail.com>  [774b578c65c2443f2ea2b95bc6402a49f0020ea0]

        dont use GetItemSurrogates for gathering SwTOXMark
        
        which is very expensive these days
        
        Change-Id: I412c30310f001a7b7c9350a7e0da62bdcddc498c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Patrick Luby  <guibmacdev@gmail.com>  [50d373a275626d894dc885d4c2cc28a9f9b8b912]

        tdf#161945 increase sensitivity for negative horizontal deltas
        
        A side effect of the anti-jitter code is that it tends to
        reduce the sensitivity of horizontal scroll events towards the
        first column. It is particularly noticeable with horizontal
        scroll events from a scrollwheel when the view position is in
        column B or C. This results in a very small delta from the
        anti-jitter code.
        
        So, to balance things out, apply a constant adjustment factor
        to increase the sensitivity more for small deltas than for
        large deltas.
        
        Also, while the fix for tdf#135478 reduces the horizontal
        scroll delta applied to the tab view, the horizontal scrollbar
        is set before that with the original delta. As a result, the
        horizontal scrollbar is now mispositioned so update the
        horizontal scrollbar position to match the position of the
        tab view's visible columns.
        
        Change-Id: I4be66c40692d4b92557f31235339ac6c40755ae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172619
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-09-07  Noel Grandin  <noelgrandin@gmail.com>  [ad74339c052667b4d10fc655e1753db92420e2bb]

        dont use GetItemSurrogates for gathering SwFormatRefMark
        
        which is very expensive these days
        
        Change-Id: I8698d3bb9a7d49a5444ed901859f636647e4d116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172996
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [911c3a840f5ce34e1fb7e34a144e4e44204eb7d9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce3c29b0ba0db095049bb4792db3b0df10ad0a94
          - tdf#162607 Remove dup's in hid2file.js, SC_HID*
            
            + fixed bad bookmarks
            + refactor
            
            Change-Id: Ie466ecff62f4bdcbecfe737a80c5ff2a93e02d9d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172992
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e05dc87dbca32fa591b8ff5f7fa8e12763660d53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b9174d7844e4e6df7820b63fd62c9c1eb70752d3
          - tdf#162607 Remove dup's in hid2file.js, pdf export
            
            + fixed bad bookmark
            + refactor
            
            Change-Id: I48f2395c9b1b667333f81f2d6ced11d0cb6efae8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172991
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [044c40afcd2576ad954aaff14b4053e683e730c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 970df2d1be6b52393668f2554c2f6cdf1f2f05dc
          - tdf#162607 Remove dup's in hid2file.js
            
            + fixed Fourier bad bookmark
            + needless bookmark in shared/00/00000001.xhp "delete".
            + deleted page shared/01/06130500.xhp because of full duplicate of sbasic/ homonym
            
            Change-Id: Ib9506e93f868dbc6c35b7dfbd73cad72c807d6f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172990
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [84f6d117808702498dd76f3de175652b04a9b36c]

        Use unique_ptr to pass ownership of ZipEntry
        
        Change-Id: I09ffa752d2cd0367579e9384b992215b2d79b251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172963
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [7220412c789e755b51747a1dfed6e72846e7cf8c]

        python: upgrade to 3.10.15
        
        Downloaded from https://www.python.org/ftp/python/3.10.15/Python-3.10.15.tar.xz
        
        Change-Id: I269ff9fa4565b5fdda6ba29bf6ac93bcf8daaa03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172995
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [62cce75a8d68cf7689c741dfbf91f639ddfab16b]

        Simplify a bit
        
        Change-Id: I88f36b1590febda09dd088c5dd48f76078a63c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172962
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [c16cbc8aac87bc7d7a98d6b667f5b8d4c440c8dd]

        Simplify a bit
        
        Change-Id: Iec00d4a2499c92f853a7942ed0659973663819eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172961
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [edd0e3ac9f9728ff88d63113d64911cee1e29a06]

        Simplify a bit
        
        Change-Id: I8756f02ca9cb641528d621704cbed09d964c6ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172959
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [fade348ab2e8caddaa0248f686aa952fde1b5bdb]

        Drop a redundant line
        
        Change-Id: Ic6584178ad83fb2b6aeaadde2c46770c355d3084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172960
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca5113d4f862700a3b97f7fe98a720e084ecec0e]

        fix asan build
        
        Change-Id: Ie7970629bcf09b8b9c0f4c052d0a9187d56d9d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172988
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [f42932f23c20122cb7b4537efaf943a8b481752e]

        tdf#162829: Dereference before null check
        
        Regression from:
        commit 1de1c47471278db2344c986e9d597d6a05e559e9
        Author: Gökay Şatır <gokaysatir@gmail.com>
        Date:   Thu Feb 22 13:54:06 2024 +0300
        
            Moving parts of readonly checks from model to view.
        
        Change-Id: I8d0ba914df909bc1a13ce7181b6d05cd0216e468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172978
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-07  Michael Meeks  <michael.meeks@collabora.com>  [c95b1189822bc860ec084e93f5de942d718f6be9]

        lok: add SAL_DISABLE_FSYNC environment to disable fsync.
        
        For state-less containers there is no benefit in fsync'ing,
        file data is safe when it is up-loaded back to storage - but
        profiling shows latency from stray fsyncs.
        
        Change-Id: I9f03d5866dec05e5507deb56b0dca93b6876225e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167490
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 90bd45d7a96c8c7084db13e4b6f86753db67655a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172947
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [e4344d13de05b83859a2800bc0b2e7ea0db9fdfc]

        Avoid wrong "unknown attribute" warnings for nested tables
        
          warn:sw:29504:31312:sw/source/filter/xml/xmltbli.cxx:550: unknown attribute urn:oasis:names:tc:opendocument:xmlns:table:1.0 table:name value=Table2
          warn:sw:29504:31312:sw/source/filter/xml/xmltbli.cxx:550: unknown attribute urn:oasis:names:tc:opendocument:xmlns:table:1.0 table:style-name value=Table2
        
        This makes no sense: these are just normal table attributes, handled
        in a different place; and here the code is only interested in one
        specific attribute, not handling everything else.
        
        Change-Id: I36ca1a0e7b04cf9c8ddb7cb61b290e92832fe4d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172949
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-07  Kira Tubo  <kira.tubo@gmail.com>  [6836e6f7900907ab6ba72a34e7ef62705a5aee69]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c0678cb66b35d04a3aa791383ff6b9007700e5e
          - tdf#157230: Help: Adjust path for Open/Save buttons in Tabbed UI
            
            Update navigation path for following buttons in Tabbed UI:
            - Recent Documents*
            - Open Remote*
            - Save As**
            - Save Remote**
            
            *Buttons now located in File > Open popup menu
            **Buttons now located in File > Save popup menu
            
            Related to changes in commit 406f879af36c8cc524d87292ddffca7426811fa0
            
            Change-Id: I09f2ab65a14953f9e80bd8a45ae016bd3831b672
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172986
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [713592e2503c7fb2acfc713b9db2c15cd2ec806d]

        return SwTableBoxFormat from SwTableBox::ClaimFrameFormat
        
        since that is always the SwFrameFormat subclass we are attached to
        
        Change-Id: If4bcff17d3983f1fc55b4a25c7c4e40e9087a1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [c659d65ce1c980bbf836ce95fbdb3729bf3234f1]

        dont use GetItemSurrogates for gathering SwTableBoxFormula
        
        which is very expensive these days
        
        Change-Id: If7ab76173e2b17fe767042a9461969babc16cb6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172965
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [43be09b29c28284c6585eaa48117e168f7c9c7b5]

        return SwDrawFrameFormat  from SwContact::GetFrameFormat
        
        since that is always the SwFrameFormat subclass we are attached to
        
        Change-Id: Icdd7cb162c9778aa4d63227f1a69c1c41eef3db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [ba12acd18aed96a9d00a560066c1d0ff6718e84c]

        Move mnemonic to logical, unique place
        
        Change-Id: I603a11980f05863402b7c1abedf293ba4c76923b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172985
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [42241fe7c59251c6bae2122ebcdf0c451bc66c46]

        loplugin:redundantcast
        
        two of my patches landed close together, and the one caused a clang
        warning in the other
        
        commit 7b16c7db04affde593bfaf75965c4271e4c3ea58
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Wed Sep 4 20:02:14 2024 +0200
        
            use less GetItemSurrogates in SwTable::UpdateFields
        
        commit edc20f4d34d102b385ece53a60abad0047661661
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Thu Sep 5 19:30:48 2024 +0200
        
            return SwTableBoxFormat from SwTableBox::GetFrameFormat
        
        Change-Id: I49a00ad27e3e8bcb86e16d8ed81f35116a785aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172971
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3a7aa38b8b0210252467f42d9cbf580ba7896f4f]

        Update git submodules
        
        * Update translations from branch 'master'
          to fdf5842af43208afc5a3d4feb0bb2b26c96e50ca
          - update translations for 24.8.1 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I11ee3ec1824e5919a25bcc23230794fd9add4d83
            
2024-09-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [8a82a7cb706796c5fc5638b7364d438fb41c59a7]

        Related: tdf#149085 fix IDs in context attributes
        
        Change-Id: Ieb7d89e8a0304782bf32e2169230de1e3eabf446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172943
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-06  Michael Stahl  <michael.stahl@allotropia.de>  [0c6ec63c81676ed675931d9aa8a78d91ed0d9b6e]

        sw: fix hiding of flys in hidden sections, part 3
        
        Sigh... the new section frame can be deleted! Missed that...
        
        (regression from commit e2f3ba12c238c895dfd61ad09fcd76789ebbfd53)
        
        Change-Id: I48f2b09ececf8fb8469c53a5ec0a3c75be5f7306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172966
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [52eceeb51b03afc4e3b003fad773a3f99fa74738]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a88ae62e116a47c32a0fa679544eee79160616a9
          - Related tdf#140347: remove colons from headings
            
            Change-Id: Ic0f7fa6dc262466a5fed8ddfac0a1b95ba2351af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172973
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-09-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [e266da95e0522fd9896f92f1c2ca3235e0e6fd66]

        poppler: upgrade to release 24.08.0
        
        Fixes CVE-2024-6239
        
        Downloaded from https://poppler.freedesktop.org/poppler-24.08.0.tar.xz
        
        Change-Id: I70373c367cc3da87d9847c00b02a17f514b52ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171667
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-09-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [78a2addbfe500ff14bf09b0cc0a5183f830add99]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to edcc3ca5f71bb680059d4713b095246f876837b4
          - tdf#149085 Protect section in Writer object properties moved to
            
            Position and Size tab.
            
            I removed the <ahelp> tags as the .ui file already has extended tips defined.
            
            Also update the label Automatic to AutoSize to match current UI.
            
            Change-Id: Iddb9dfa48e983879fba8233a37b64f954b5787fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172941
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d99cc908365a27f275ae8f221958a8282e668fc]

        tdf#162467: fix measurement units in impress/draw
        
        Regression from
        commit 055e7d866680390dca6e18864ca4297cc0ebda84
        Author: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Date:   Tue Apr 23 20:04:43 2024 +0200
        
            Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfg
        
        This code was removed for no apparent reason.
        Reintroduce it and adapt it
        
        Change-Id: Iea23ba824cdc20e59edbc316fefc7325c73926a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172940
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3f3da299e54a78efd01f952f410cebe2bc67a77e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b4c5d498e409d98da283dcaa25a8e3d8591aac76
          - tdf#140347 Labels changed in Settings of Footnotes and Endnotes dialog
            
            Change-Id: I6c3f9c626c24bddf5cd72ce5c0a65732ad3073ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172968
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad3fa69eeb89573c77feba64dab3380154a90953]

        reduce time spent in RecalcPageNums when importing PDF
        
        when we have lots of pages, we trigger a O(n^2) loop.
        
        Do two things to reduce this
        (a) be smarter about recalculating page numbers, so we only recalculate
        the set of page numbers that need recalculating
        (b) duplicate the last page repeatedly, instead of the first page, so we
        don't recalculate all the page numbers for each page we duplicate
        
        Change-Id: I40aca812b47a9551039c5855b1c8d26f5f171f41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172942
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7abbdb5eb30d269fcdd97eab9dcf0b7f5526c880]

        return SwTableLineFormat from SwTableLine::GetFrameFormat
        
        since that is always the SwFrameFormat subclass we are attached to
        
        Change-Id: I02645ac4ab5078e5fd201fef5fdae5232652a9f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b16c7db04affde593bfaf75965c4271e4c3ea58]

        use less GetItemSurrogates in SwTable::UpdateFields
        
        which speeds up loading a large document with lots
        of nested tables from several minutes to under 15s
        
        Regression from
            commit ae7807c889c19145f89cec40afac82eee191837c
            Author: Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>
            Date:   Wed Jan 10 20:07:47 2024 +0100
            ITEM: No longer register Items at Pool
        
        Change-Id: If44bbc50074fc324e9458a4ac498f402500981e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-06  Miklos Vajna  <vmiklos@collabora.com>  [de0bc0a2c30a76144b47e9abb17770043813133c]

        cool#9992 lok doc sign: make SfxMedium::SignContents_Impl() async
        
        Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
        to show the signatures dialog read-only, as only that is async.
        
        The next step to get rid of this hack is to make
        SfxMedium::SignContents_Impl() async, now that
        SfxObjectShell::SignDocumentContent() is async.
        
        This requires all callers of SfxMedium::SignContents_Impl() to be async,
        most notably SfxObjectShell::SignScriptingContent() has to be converted
        as well.
        
        Note that no lifecycle problem is expected here for the callback, since
        the object shell and its medium is typically around for as long as the
        document is loaded.
        
        Change-Id: I57f2c747f8448b9adc0398f874ede36211fed817
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172934
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1da035600affe1b79854f0089009c4fadd19e251]

        drop unused eventtesting cmd line option
        
        Change-Id: I90edb80f3b414cbe0a81ecccbf1080106708a131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-06  Jonathan Clark  <jonathan@libreoffice.org>  [1d3ba3ba5dfd55dccc71b671645dced82795b31d]

        tdf#152142 sw: fix RTL as-char textbox compat flag special case
        
        Fixes an issue causing incorrect textbox positions when the containing
        shape is anchored 'as character' inside RTL text, with the
        DoNotMirrorRtlDrawObjs compatibility flag set.
        
        Change-Id: I58cade8b91925dda188a1ef8fd078ccfdc3fea56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172938
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [edc20f4d34d102b385ece53a60abad0047661661]

        return SwTableBoxFormat from SwTableBox::GetFrameFormat
        
        since that is always the SwFrameFormat subclass we are attached to
        
        Change-Id: Iaac0503818c7c9c8e2563ad0dd7d689bdddb8438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-06  Kira Tubo  <kira.tubo@gmail.com>  [60934c3a6a0c0e20dd83de28e1fb51280626339e]

        tdf#149085: Move "Protect" section to "Position and Size" tab
        
        - Within properties dialog of Image, Frame, Object, move "Protect" section
        (including checkboxes Contents, Position, Size), from "Options" tab to
        "Position and Size" tab.
        - Rearrange positioning of UI elements.
        
        Change-Id: Ie55832404f47505e31202a12484cd8dedcda6bcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172728
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-06  Adam Seskunas  <adamseskunas@gmail.com>  [2bacf24d46350e451db444d72a88a3c407b419f3]

        tdf#54862 Add Unit test
        
        Change-Id: I321b8fc30cb814c17b397eb5353fb05fc2b2410c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172878
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-06  Michael Stahl  <michael.stahl@allotropia.de>  [c647937e6066fb911b8ddc5a77b2621d5cb874e4]

        sw: fix problem with 0-height tables after unhiding section
        
        Mysteriously this works the first time the section is made visible, but
        then hide it again and unhide it and a table has height 0 because only
        the table itself is invalidated and none of the text frames inside it.
        
        SwTabFrame::MakeAll() does Prepare(PrepareHint::FramePositionChanged) on
        all contained text frames, but that may actually do nothing in common
        cases.
        
        So just recursively invalidate everything in the section, that should
        fix things.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: I26e72193947685fde52fb8da78e95592a3866c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172920
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ffcd108d6eb233130e7c740bea235b923a4883f]

        tdf#161724: svx_unit: Add unittest
        
        Change-Id: Ie7d2707faa1aaec8e946efe1e8e4a826bf3ea091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172928
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-06  Miklos Vajna  <vmiklos@collabora.com>  [0f8329d83426e03309b4bc3a0a71179ad7a0f0ae]

        sw doc model xml dump: show start node of headers
        
        Without this, it's hard to see which header node section belongs to the
        header of which page desc.
        
        Change-Id: I9994b511c8df7b992350a13ac1cf4fcf875c49ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172930
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-06  Mike Kaganski  <mike.kaganski@collabora.com>  [2c7358f5d2618c3f13b94752808d7073bf80cde5]

        Deduplicate some code
        
        Change-Id: Ic095e3665c98752493d1b47aa6962e87a3d1e319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73ef706f3f700b0f9953c69396668270462b7786]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35f143f5b52cf1b8203562e4016b75ba7e568c53
          - drop removed 'eventtesting' cmd line option
            
            Change-Id: I8f22828134b0b5354621a1e2bf18adf8af1203a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172932
            Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
            Tested-by: Jenkins
            Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
            
2024-09-06  Justin Luth  <jluth@mail.com>  [09df48f87f04b0176593cb5f649ac3cd2244891e]

        tdf#161741 undo nits: NeedsClearRedo is private + prioritize TopLevel
        
        moNeedsClearRedo is an implementation detail,
        so there should not be public functions for it.
        
        Plus, NeedsClearRedo can be called either against
        the CurrentLevel stack or the TopLevel stack
        (whatever that implies - there is no documentation...)
        and since it is a delayed call that means that
        multiple NeedsClearRedo attempts could be made,
        theoretically against both stacks.
        
        My initial implementation was "last one wins",
        (which may very well prove to be the best one)
        but whatever happens, it should be clearly intentional.
        Based on my limited skill at code reading,
        it sounds like CurrentLevel might be more of an implemention detail
        or a temporary expansion of a ListUndoAction,
        so I am guessing that any request for TopLevel clearing
        should be given priority.
        
        For Writer, it is always clearing the TopLevel stack
          sw/source/core/undo/docundo.cxx: ClearRedo()
            return SdrUndoManager::ImplClearRedo_NoLock(TopLevel);
        
        Change-Id: I195aefb696599f018712135a2e015549d534791f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171984
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-09-05  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [1e905680c85c4b79cc72df5dcece38a65898a90d]

        tdf#162359 sw: fix the export of comments as PDF annotations
        
        Change-Id: If4a8a1a73c382f496b2c6dd4d52271dc6bc87dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172877
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-09-05  Sahil Gautam  <sahil@libreoffice.org>  [9dd26d7a2cc6b314dcc0b52000e0475bb4ced57d]

        Libreoffice Theme Part 0: Read correct colors from qt based VCL_PLUGINS
        
        See `QtFrame::UpdateSettings()`, where `StyleSettings::WindowColor` is
        set to aBase (QPalette::Base) and `StyleSettings::DialogColor` is set to
        WindowColor in a call to `StyleSettings::BatchSetBackgrounds`.
        
        The issue is that without this patch in place, "GetWindowColor()" doesn't
        return the color of the window, instead it returns the "base color" from
        QPalette.
        
        It had some unintendedd consequences like the "Animation Panel" in the
        Impress's Animations sidebar not being painted with the correct color,
        as it was expecting the old WindowColor. This patch also fixes that by
        changing WindowColor to FieldColor in `SalInstanceWidget::set_stack_background()`
        
        https://gerrit.libreoffice.org/c/core/+/168901/comment/0e5201bd_2cae07b9/
        
        Change-Id: I36f8c5efd8c3e87ded19a1efc00ed9c69a7fccf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171916
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-09-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c4d2570b4f1830d733f3569d6cd3e4eb6c09a9cb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6cf58ad72402089f3bface5930dad6ab7ecdd0c3
          - Fix typo
            
            Change-Id: I02a273ae82c96388efeee5ea2d88b7162d8d2022
            Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172921
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [6605f58aeddb21629b842040b81df55a29443fd0]

        cui: fix another plausible crash
        
        Similar to 6633afe0ff18e5921eb96be2f863f28bd7e1110d
        "fix crash in Hyperlink dialog"
        
        Change-Id: Ia53ffeffaca775c66fb269e109d5fdb8c32d0066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172917
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [629a9d68eeadd1f1349c97c0131c7d1d55ad867b]

        drawinglayer: getHeight() -> getWidth()
        
        Since 01ded1e6d362dbcd7148334c6965d6ad00981d4a
        "WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt"
        
        Change-Id: Ib99e940c954fe44f2dbee2b14dfa9d2c79468500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172919
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-09-05  DaeHyun Sung  <sungdh86+git@gmail.com>  [e830f2a041271f4af65dabb2d8c0968b7f3bac6e]

        tdf#157029 changed Korean Font priority for LibreOffice UI
        
        changed Korean Font priority for LibreOffice UI
        
         * Change list order, "맑은 고딕;Malgun Gothic;애플 SD 산돌고딕 Neo;Apple SD Gothic Neo"
         after Noto Sans CJK & Nanum Gothic.
         * Change list order, Make Noto Serif CJK KR font read first for  Korean-Serif Familys
        
        Because, Noto Sans CJK KR, Nanum Gothic are mostly used on Windows, Linux, and Mac.
        "맑은 고딕;Malgun Gothic;" is used on Windows,
        "애플 SD 산돌고딕 Neo;Apple SD Gothic Neo" is used on Mac.
        
         * Modified dotum's Korean name.  `돋음` to `돋움`
         * default TEXT font use Sans instead of Serif.
        In Korean environment, MS products were adopted Sans-family's Malgun Gothic font as a default font since Vista
        Also, HWP(South Korea's a proprietary word processing application) is adopted Sans-Family's HCRDotum(함초롱돋움) since HWP 2010.
        As a result, I changed Sans-family font as a default Text font instead of Serif-family font on LibreOffice UI.
        
        Change-Id: I3c7803b63a52d5569ca36d788d944a038e6fd8bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157494
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-09-05  Justin Luth  <jluth@mail.com>  [47bb0e2b7d0690f06150c7e110e6992f3d62bd10]

        Revert "tdf#162612 mso import NOT-layoutInCell: effectively are wrap-through"
        
        This reverts my 25.2 commit c8e272734a8fa26d93b057d1c9def8dc6c401143.
        
        Reason for revert: I found an example where wrapping does apply.
        In addition, wrap-through images are not restricted to the paper area, but in this case the shape should still be restricted.
        Needs more testing..., so just completely revert for now.
        
        Change-Id: I559942fee98f5693c90f7e16f65fefb7ecb9ab48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172899
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-09-05  Rico Tzschichholz  <ricotz@ubuntu.com>  [ac1600f9d13f6aa66b635ed5c48bc8d26ec83f6f]

        sw: Add missing #include <cstring>
        
        /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx: In member function ‘com::sun::star::uno::Sequence<rtl::OUString> SwContentViewConfig::GetPropertyNames() const’:
        /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:120:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
          120 |     static_assert(std::strcmp("Update/Link", aPropNames[g_UpdateLinkIndex]) == 0);
              |                        ^~~~~~
        In file included from /<<PKGBUILDDIR>>/include/rtl/string.hxx:36,
                         from /<<PKGBUILDDIR>>/include/rtl/ustring.hxx:45,
                         from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.h:30,
                         from /<<PKGBUILDDIR>>/include/com/sun/star/uno/Any.hxx:35,
                         from /<<PKGBUILDDIR>>/include/o3tl/any.hxx:21,
                         from /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:23:
        /usr/include/string.h:156:12: note: ‘strcmp’ declared here
          156 | extern int strcmp (const char *__s1, const char *__s2)
              |            ^~~~~~
        /<<PKGBUILDDIR>>/sw/source/uibase/config/usrpref.cxx:121:24: error: ‘strcmp’ is not a member of ‘std’; did you mean ‘strcmp’?
          121 |     static_assert(std::strcmp("Display/DefaultAnchor", aPropNames[g_DefaultAnchor]) == 0);
              |                        ^~~~~~
        /usr/include/string.h:156:12: note: ‘strcmp’ declared here
          156 | extern int strcmp (const char *__s1, const char *__s2)
              |            ^~~~~~
        make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:338: /<<PKGBUILDDIR>>/workdir/CxxObject/sw/source/uibase/config/usrpref.o] Error 1
        
        Change-Id: Ie6c89500c554e0027d9b14c082baca519a454c10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172860
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        (cherry picked from commit f20592f7baf1b07f1b60c1625e69cee6e2e9be88)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172891

2024-09-05  Michael Stahl  <michael.stahl@allotropia.de>  [e2f3ba12c238c895dfd61ad09fcd76789ebbfd53]

        sw: fix hiding of flys in hidden sections, part 2
        
        Didn't notice that this depends on a global variable "bObjsDirect" so it
        only works for some documents; move the HideAndShowObjects() call to the
        end so it works in all cases.
        
        (follow-up to commit 8a13277f797c6e2f1b0d9060ad6e5e4d72eb76d0)
        
        Change-Id: I26a7cecdb660179f3ac1c3ea1e5d19067806b741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172915
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [295e1039649de030babf3ac9235cc80f9b9ca33c]

        tdf#161724: Revert "tdf#153008 svx: impl crop for stretched bitmap fill"
        
        This reverts commit c30c1d12f283e75fdcc5bb508a79a9d33a431d28.
        
        it even broke the original sample file reported in tdf#153008
        See https://bug-attachments.documentfoundation.org/attachment.cgi?id=196248
        The original issue was reported in tdf#95165 but it doesn't work
        in all cases, making it much worse in some cases where images
        become very stretched
        Reverting for now, specially towards libreoffice-24-8 and
        libreoffice-24-8-1
        
        Change-Id: Ib94d2784d701d37853ce9b17135b36f26a5c084b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172913
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-05  Miklos Vajna  <vmiklos@collabora.com>  [0255283974894f5ad9ba92c3a52912657ed4bdf6]

        cool#9992 lok doc sign: add SfxObjectShell::AfterSignContent()
        
        Currently SfxObjectShell::CheckIsReadonly() has a hack for the LOK case
        to show the signatures dialog read-only, as only that is async.
        
        The first problem for the read-write signatures dialog is that
        SfxObjectShell::ExecFile_Impl() has code after invoking
        SfxObjectShell::SignDocumentContent(), which will be executed too early
        if the dialog is executed async.
        
        Fix the problem by moving the code in question into a new
        SfxObjectShell::AfterSignContent(), and only invoke that as a callback
        after the async run finished.
        
        The message dialog in the moved code is still non-async, but we can deal
        with that later.
        
        Change-Id: I32f0895118ac0da72105ec3a24c0294e18c05545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172914
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-05  Michael Stahl  <michael.stahl@allotropia.de>  [8087f479b373299d45469ff3996dba793a9cdb28]

        sw: fix empty pages after hiding section due to SwTabFrame
        
        The problem with a full customer doc is that a table doesn't MoveBwd
        because ShouldBwdMoved finds that the rows don't fit as the rows still
        have non-0 heights, and the result is an empty page at the end; also the
        table later splits.
        
        Turns out that setting bDontSplit prevents both problems; the inner
        frames are all set to 0 height by lcl_RecalcTable().
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: I5012142a0019ee2e978d5b8a9eb445ff0949e569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172910
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-05  Dione Maddern  <dionemaddern@gmail.com>  [4fdeff11d8c1fb27eca887a400b16adccaa7c8ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e9d2c728aa5f30b4fa97922a85e5f56912869d9
          - tdf#162504 tdf#152161 Create help pages for Properties sidebar panels
            
            Created a new page text/shared/01/sidebar_properties.xhp
            This page is a WIP but it proved to be easier to created pages for the
            individual panels one at a time. I've included it in the patch because
            some of the other pages have embedded content from the howtoget section.
            
            Created a new page text/shared/01/sidebar_character_panel.xhp
            - to document the Character options in the Properties sidebar
            
            Created a new page text/shared/01/sidebar_paragraph_panel.xhp
            - to document the Paragraph options in the Properties sidebar
            
            Created a new page text/shared/01/table_design.xhp
            - to document the Table Design options in the Properties sidebar in Draw
            and Impress
            
            Created a new page text/swriter/01/paragraph_hyphenation.xhp
            - to document the Hyphenation options in the Paragraph panel of the
            Properties sidebar in Writer
            
            In text/shared/00/00040502.xhp
            - Removed outdated How to get information for the Double Underline
            option
            - Added section tags so that content can be easily embedded in other
            pages
            
            In text/simpress/main0203.xhp
            - Added Help instructions for the Character Highlight widget.
            - Added icons for the "Increase Font Size" and "Decrease Font Size"
            widgets.
            
            In text/shared/01/05020500.xhp
            - Added Icon for "Spacing"
            
            In text/swriter/guide/using_hyphen.xhp
            - Changed title from "Hyphenation" to "Using Hyphenation" to match H1
            and avoid confusion with the two other pages titled "Hyphenation".
            
            Added section and variable tags to allow content to be easily embedded
            in other pages in:
            source/text/shared/00/00040500.xhp
            source/text/shared/01/05010000.xhp
            source/text/shared/01/05020100.xhp
            source/text/shared/01/05020200.xhp
            source/text/shared/01/05020500.xhp
            text/shared/01/05030100.xhp
            source/text/shared/01/05030700.xhp
            source/text/shared/01/05070410.xhp
            source/text/shared/01/05070510.xhp
            source/text/shared/01/05070610.xhp
            source/text/shared/01/05110100.xhp
            source/text/shared/01/05110200.xhp
            source/text/shared/01/05110300.xhp
            source/text/shared/01/05110400.xhp
            source/text/shared/01/06050300.xhp
            source/text/shared/01/06050500.xhp
            source/text/shared/01/StyleNewByExample.xhp
            source/text/shared/01/StyleUpdateByExample.xhp
            source/text/shared/01/formatting_mark.xhp
            source/text/shared/02/02010000.xhp
            source/text/shared/02/02020000.xhp
            source/text/shared/02/02130000.xhp
            source/text/shared/02/02140000.xhp
            source/text/shared/02/02160000.xhp
            source/text/shared/02/03110000.xhp
            source/text/shared/02/03120000.xhp
            source/text/shared/02/paintbrush.xhp
            source/text/swriter/01/05030200.xhp
            source/text/swriter/guide/using_hyphen.xhp
            
            Change-Id: If8071612709aeae514dbd591eba4c1d0d0928a64
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172844
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-05  Jean-Pierre Ledure  <jp@ledure.be>  [d2d14c36d1820da2290d13fb668533269a976743]

        ScriptForge (Database) DMin, DMax return strings or dates
        
        Python only:
        
        Reset a flag in SF_Database.DMin and DMax methods
        to allow dates to be returned.
        
        Review typing hints to accept strings and dates
        
        Integration of remarks from Microsoft/VSCode
        about minor syntax issues in scriptforge.pyi
        (syntax was accepted by PyCharm).
        Now, syntax commonly accepted by both IDE's.
        
        Change-Id: I752d9f1d7a5293222d81748f8fb2e8f46f4317de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172912
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8deb64c3c1d5baa8532a92bc16d1712f42aaa12]

        throw more useful exception from OPropertySetHelper::getPropertyValue
        
        Change-Id: I90e7ab5763bf368cec795a8c39ece17579dd851d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172905
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d6422b3ff0c3b252f87f76f1777a357aafeaea7]

        tdf#162772 Crash in "Target in Document" in Hyperlink dialog
        
        regression from
            commit a6ad198d097fb4a503c8d5831d484ff46721134b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Aug 17 13:19:54 2024 +0200
            tdf#158556 use more comphelper::ByteReader
        
        Change-Id: I7343159d5e3ec7619ba95a98417fd3b4e25dbf6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [70b6d04570b22e766d1f04921cf05f9f9cdd3108]

        tdf#162728 Crash on saving in Math Formula editor
        
        regression from
            commit ece0729e18b4b306933439d1a329df192fc504d3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Aug 13 13:43:25 2024 +0200
            use less exception throwing for flow control
        
        Change-Id: I52dcb717e309c70d10a0609b04b2c9c659c423cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172908
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [6633afe0ff18e5921eb96be2f863f28bd7e1110d]

        fix crash in Hyperlink dialog
        
        which I managed to trigger by hitting escape repeatedly while it was
        trying to load the targets window
        
        Change-Id: I4c7cb3a30104c58bfc6652923a0aa2169c1bf3bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172907
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-05  Heiko Tietze  <tietze.heiko@gmail.com>  [5c64b81b4d5bd347e57ba156bb0c34d09fb6aa5b]

        Resolves tdf#160937 - Minimize document properties dialog size
        
        * Scrolled view behind Description items
        * Width for preferred image resolution set to 5 chars
        
        Change-Id: Id29c0109a3dd2998bc5d09cfbed4a848cf2d3f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172881
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [d50f3fa9f5811204fbf2350e4745a26154fce6d5]

        tsan: data race
        
        Read of size 1 at 0x7250000be3fd by thread T19:
         0 dbaccess::ODatabaseDocument::queryInterface(com::sun::star::uno::Type const&)
         1 non-virtual thunk to dbaccess::ODatabaseDocument::queryInterface(com::sun::star::uno::Type const&)
         2 com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&)
         3 com::sun::star::uno::Reference<com::sun::star::frame::XFrame>::iquery(com::sun::star::uno::XInterface*)
        
        Previous write of size 1 at 0x7250000be3fd by thread T8 (mutexes: write M0):
         0 dbaccess::ODatabaseDocument::storeAsURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
         1 non-virtual thunk to dbaccess::ODatabaseDocument::storeAsURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
         2 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
        
        Change-Id: I40ce0b5995f94455b5d9ca1d652a58df96b5f553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-05  Oliver Specht  <oliver.specht@cib.de>  [497d328042b18853c5236e95a0f38a4ab733688c]

        tdf#159027 test added
        
        Test added as follow-up to f60126a6bfae5dad4a11afcc94ddf4a58c5ce8ab
        checking table calculation on page break
        
        Change-Id: Icb4e8b8509db18d82647c66a6abdb87648ad4cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171592
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-09-05  Michael Stahl  <michael.stahl@allotropia.de>  [8a13277f797c6e2f1b0d9060ad6e5e4d72eb76d0]

        sw: fix hiding of flys in hidden sections
        
        There are 2 different ways to hide flys, either destroy the SwFlyFrames
        (as is done for delete redlines or fieldmarks) or move them to an
        invisible layer (as is done for field-hidden paragraphs).
        
        Previously for hidden sections the FlyFrames would be destroyed, but
        it's easier now to move them to invisible layer.
        
        HideAndShowObjects() needs to be recursive so it can hide flys that are
        anchored in a table.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: Ideab0343315e575c066eb9e2e901d2ee0acabe3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172865
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-09-05  Pierre F  <fpy@bger.ch>  [d8217dd8f857ab6064d84cb055e7c8620937b106]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06c4d05a7e39feb276bbd70ed3639a8c10157d54
          - tdf#161401. explicit "Delete comment" for Calc Navigator
            
            Change-Id: Id44e12ddde6bcdab5d4628634fd90bb6543e6a38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172820
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-05  Rico Tzschichholz  <ricotz@ubuntu.com>  [937ec1d808b5609d8f9904d1d13ce9dcdccdcd09]

        kf6: Use the intended qt6 includes
        
        Change-Id: Ieaed72cbb0f915be4676d0df9bffe20e9fbfd0da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172616
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [090b60167a03bcc6aa11d6c858fe5ef22e17ba90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d984c2e53073403920ff738525fa7b34910bdc7d
          - tdf#162791 Update BASIC now() help page.
            
            BASIC Now() function changed internal calculation to match Calc's =NOW() function.
            
            Change-Id: I10653e8120c34d57db9f06ad70768174a47cba59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172876
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [898ff23a664a4b114a31941bff9efbaec3dc9e73]

        no need to use dynamic_cast here
        
        Change-Id: Icc5ad5972afdad128db19c6b2d6d0aa55da47f0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172880
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ebe316635b7d4a2d8a82f79cc99eab95b0aabff]

        tsan: data race
        
        Atomic write of size 4 at 0x7254000f5f08 by thread T38 (mutexes: write M0, write M1, write M2):
        0 configmgr::Access::acquireCounting()
        1 configmgr::Components::initGlobalBroadcaster(configmgr::Modifications const&, rtl::Reference<configmgr::RootAccess> const&, configmgr::Broadcaster*)
        2 configmgr::RootAccess::commitChanges()
        3 non-virtual thunk to configmgr::RootAccess::commitChanges()
        4 utl::OConfigurationTreeRoot::commit()
        5 dbaccess::(anonymous namespace)::DatabaseRegistrations::registerDatabaseLocation(rtl::OUString const&, rtl::OUString const&)
        6 non-virtual thunk to dbaccess::(anonymous namespace)::DatabaseRegistrations::registerDatabaseLocation(rtl::OUString const&, rtl::OUString const&)
        7 dbaccess::ODatabaseContext::registerDatabaseLocation(rtl::OUString const&, rtl::OUString const&)
        8 dbaccess::ODatabaseContext::registerObject(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
        9 non-virtual thunk to dbaccess::ODatabaseContext::registerObject(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
        10 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
        
        Previous read of size 4 at 0x7254000f5f08 by main thread (mutexes: write M3, write M4):
        0 cppu::OWeakObject::disposeWeakConnectionPoint()
        1 cppu::OWeakObject::release()
        2 configmgr::RootAccess::release()
        3 non-virtual thunk to configmgr::RootAccess::release()
        4 com::sun::star::uno::Reference<com::sun::star::util::XChangesBatch>::~Reference()
        5 SvtLinguConfig::~SvtLinguConfig()
        6 SwDoc::GetGCIterator()
        7 SwDoc::StartGrammarChecking(bool)
        8 sw::DocumentTimerManager::GetNextIdleJob()
        9 sw::DocumentTimerManager::IsDocIdle()
        10 sw::SwDocIdle::UpdateMinPeriod(unsigned long) const
        11 Scheduler::CallbackTaskScheduling()
        
        Change-Id: Idaf2707e5902338a873a325228e9c97e646ea768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172874
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1799fb8a5ab568519f00a575ec2fb0190ae0c19d]

        Fix typo
        
        Change-Id: I799609afc33913fc09f7020a5bc53c83de36bff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172879
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac9eaf5d11e5f44d7faa628233438a3b1bb89d6f]

        use less dynamic_cast when broadcasting SfxHint
        
        Change-Id: If4d33cbbf36a9ad495b80a7347b39d0f4bc0405e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-05  Heiko Tietze  <tietze.heiko@gmail.com>  [0266763e05d1ca9413321533dcea73c4643db476]

        Resolves tdf#140298 - Improve UX for SQL dialog
        
        * dialog made resizable
        * user input remembered across session
        * number of results shown (inkluding plural form)
        
        Change-Id: I5b08064ed68a02a2c20fa658dbc6ed5cde656417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172803
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-05  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [3631c6ffcb2f27090cfc1b1c9dd492451d3d485c]

        Resolves tdf#162738 - Revert tdf#160937
        
        This reverts commit 2164406a973fd40fcc56b8839a21854f6b50a53b.
        
        Reason for revert: Going to implement a scrolled window
        
        Change-Id: Icc7dc71860bfcafaea1323a3d0c6f7e1f7dd380f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172758
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [1b61a0737e3600aadf42f28a15c70aface9ab61e]

        tdf#143603: disable undo in DrawDocShell::ImportFrom
        
        Change-Id: I6fbc317d9f72f1bec70ff97e915487ac2b5a2f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172872
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e9265998c296e9829ef030f7584a80949dc356eb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e0980a281484ae01ed6e1f11a4fbed5daf5452b9
          - tdf#162607 Remove dup's in hid2file.js, epub
            
            + splitlb is dup and one of them renamed to layoutlb
            + refactor
            
            Change-Id: I728a9cb43b8713d59d0a3ba2083c659186cd4ef7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172871
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1309730b8a5419d48a29edf6d3caf524311ed2e]

        use less dynamic_cast when broadcasting BulkDataHint
        
        we never read the hint id that we pass in to the constructor, so drop it
        
        Change-Id: I8ec377e51bddbc2a12a2fd226fc1a915afef59e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172862
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-04  Jonathan Clark  <jonathan@libreoffice.org>  [7ff601feca1796b6656e66c7ce2e77edcf0bdd67]

        tdf#151748 editeng: Fix crash in kashida justification after update
        
        Commit 937023bca427f803a9e7085d5090d5d2b17623ed aggravated a bug that
        would cause editeng to use stale kashida positions after document
        changes (for example, font changes). This could cause crashes or
        spurious kashida, and both much more often after the above commit.
        
        This change fixes the underlying logic error.
        
        Change-Id: Id6465e739740a38ed11c9d9378d30faa51948731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172866
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-09-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [691308125bf53dfde7f1735dc73467d55f6a5966]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8a102908be2a86209d4a2e94a5ef0031445803b
          - tdf#162607 Remove dup's in hid2file.js, SFX2_HID*
            
            + refactor
            
            Change-Id: I3b435b46a9ddb7d235531844a3667888d3f644a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172848
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-04  Jean-Pierre Ledure  <jp@ledure.be>  [3f3ea3351c25068b663ddfee023e16fe487ba893]

        scriptforge.py - Platform & TextStream
        
        Since
          https://gerrit.libreoffice.org/c/core/+/172600
        a better categorization of properties
        has been done between 4 distinct levels.
        
        The SF_Platform and SF_TextStream services
        still needed an update to avoid
        redundancy on some of their properties.
        
        A choice had to be made, either:
        - put them in the serviceproperties dict
        - or define them explicitly with @Property
        Not both, for clarity.
        
        Change-Id: I787c7e57235622abf5deb5c7fd42c4c28aa82ec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172863
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [47d8d0cbe73ae4050b3264a465efa695dc621bf2]

        Avoid deadlock
        
        Seen when running an external Java code, with these call stacks:
        
        Main thread:
        
         win32u.dll!NtUserMsgWaitForMultipleObjectsEx()
         sal3.dll!osl_waitCondition(void * Condition, const TimeValue * pTimeout)
         [Inline Frame] vclplug_winlo.dll!osl::Condition::wait(const TimeValue *)
         vclplug_winlo.dll!SalYieldMutex::doAcquire(unsigned long nLockCount)
         [Inline Frame] emboleobj.dll!SolarMutexReleaser::{dtor}()
         emboleobj.dll!OleComponent::getTransferData(const com::sun::star::datatransfer::DataFlavor & aFlavor)
         emboleobj.dll!OleEmbeddedObject::getPreferredVisualRepresentation(__int64 nAspect)
         comphelper.dll!comphelper::EmbeddedObjectContainer::GetGraphicReplacementStream(__int64 nViewAspect, const com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> & xObj, rtl::OUString * pMediaType)
         [Inline Frame] svtlo.dll!svt::EmbeddedObjectRef::GetGraphicReplacementStream(__int64)
         svtlo.dll!svt::EmbeddedObjectRef::GetGraphicStream(bool bUpdate)
         svtlo.dll!svt::EmbeddedObjectRef::GetReplacement(bool bUpdate)
         svtlo.dll!svt::EmbeddedObjectRef::UpdateReplacement(bool bUpdateOle)
         swlo.dll!SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef & xObj, const SwRect * pFlyPrtRect, const SwRect * pFlyFrameRect, const bool bNoTextFramePrtAreaChanged)
         swlo.dll!SwContentNotify::ImplDestroy()
         swlo.dll!SwContentNotify::~SwContentNotify()
         swlo.dll!SwNoTextFrame::MakeAll(OutputDevice * pRenderContext)
         swlo.dll!SwFrame::OptPrepareMake()
         [Inline Frame] swlo.dll!SwFrame::OptCalc()
         swlo.dll!SwLayAction::FormatContent_(const SwContentFrame * pContent, const SwPageFrame * pPage)
         swlo.dll!SwLayAction::FormatFlyContent(const SwFlyFrame * pFly)
         swlo.dll!SwObjectFormatter::FormatObj_(SwAnchoredObject & _rAnchoredObj)
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject & _rAnchoredObj, const bool _bCheckForMovedFwd)
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame * _pMasterTextFrame)
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObjs()
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction)
         swlo.dll!SwLayAction::FormatContent(SwPageFrame * pPage)
         swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext)
         [Inline Frame] swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext)
         swlo.dll!SwLayIdle::SwLayIdle(SwRootFrame * pRt, SwViewShellImp * pI)
         swlo.dll!SwViewShell::LayoutIdle()
         swlo.dll!sw::DocumentTimerManager::DoIdleJobs(Timer * __formal)
         vcllo.dll!Scheduler::CallbackTaskScheduling()
         vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer()
         vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents)
         vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents)
         vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents)
         vcllo.dll!Application::Execute()
         sofficeapp.dll!desktop::Desktop::Main()
         vcllo.dll!ImplSVMain()
         sofficeapp.dll!soffice_main()
         [Inline Frame] soffice.bin!sal_main()
         soffice.bin!main(int argc, char * * argv)
         [Inline Frame] soffice.bin!invoke_main()
         soffice.bin!__scrt_common_main_seh()
         kernel32.dll!BaseThreadInitThunk()
         ntdll.dll!RtlUserThreadStart()
        
        Request thread:
        
         ntdll.dll!NtWaitForAlertByThreadId()
         ntdll.dll!RtlpWaitOnCriticalSection()
         ntdll.dll!RtlpEnterCriticalSectionContended()
         ntdll.dll!RtlEnterCriticalSection()
         sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex)
         [Inline Frame] emboleobj.dll!osl::Mutex::acquire()
         [Inline Frame] emboleobj.dll!osl::Guard<osl::Mutex>::{ctor}(osl::Mutex &)
         emboleobj.dll!OleComponent::addModifyListener(const com::sun::star::uno::Reference<com::sun::star::util::XModifyListener> & xListener)
         svtlo.dll!svt::`anonymous namespace'::EmbedEventListener_Impl::Create(svt::EmbeddedObjectRef * p)
         svtlo.dll!svt::EmbeddedObjectRef::EmbeddedObjectRef(const com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> & xObj, __int64 nAspect)
         swlo.dll!SwXFrame::getPropertyValue(const rtl::OUString & rPropertyName)
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc)
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException)
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments)
         binaryurplo.dll!binaryurp::IncomingRequest::execute()
         binaryurplo.dll!request(void * pThreadSpecificData)
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob)
         cppu3.dll!cppu_threadpool::ORequestThread::run()
         cppu3.dll!threadFunc(void * param)
         sal3.dll!oslWorkerWrapperFunction(void * pData)
         ucrtbase.dll!thread_start<unsigned int (__cdecl*)(void *),1>()
         kernel32.dll!BaseThreadInitThunk()
         ntdll.dll!RtlUserThreadStart()
        
        Change-Id: I54d3fd91d8bbf4f52eee2f498c91e06ebc82d836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172864
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-04  Gökay Şatır  <gokaysatir@collabora.com>  [558b1a9155dc6918a0731277330e27c2f72b7b13]

        Add SdrModel "IsImpress" function.
        
        Functionalities like "SetMarkHandlesForLOKit" can now use this to send data selectively.
        
        Change-Id: I8d300d1d6fe0d953f4798ec3ee0c48e258054335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172854
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins

2024-09-04  Miklos Vajna  <vmiklos@collabora.com>  [0a89d65e6bb7be293c1a7b4615a08292701694dc]

        tdf#162782 SVG export: fix handling of semi-transparent text inside a list
        
        Open the bugdoc, try to export as SVG, results in an assertion failure
        in debug builds, the produced XML would not be well-formed.
        
        Commit 666f252457bdb4371d15380a0289e107b2dfbe84 (SVG export: fix lost
        semi-transparent text on shapes, 2020-07-17) added support for text
        opacity on shapes, but this assumes that the entire shape has the same
        opacity, while this shape has 3 paragraphs and only the middle one has
        an opacity set, at a text span level. Additionally, it's a bullet, so
        the text (for the bullet, has no transparency set) starts before the
        transparency metafile action would start. This means that the existing
        logic won't realize that opacity should be exported using the
        fill-opacity attribute instead of a <g> element.
        
        Fix the problem by checking for the isTextShapeStarted() case in
        SVGActionWriter::ImplWriteMask(): if we're already inside text, then we
        always want to map a transparency mask to the fill-opacity attribute
        instead of a <g> element.
        
        Leave the shape-level code at SVGTextWriter::setTextPosition()
        unchanged, that continues to deal with per-shape text opacity.
        
        Change-Id: I8cb0ca2e839fba911a75e1925cf79145f69af151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172856
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [6d3a98a0011b70570ce3ef0b7873d0d1ee26a35a]

        tdf#162781: also shift down tables with text::HoriOrientation::RIGHT
        
        As said in commit 7b1c03ed87f7a21606e09863b23074e6b96e26d1 (tdf#154775
        sw: layout: avoid breaking this with following commits, 2023-08-24), it
        would be best not to check HoriOrient at all, but needs checking first
        what Word does in other cases. So I just add another case that is known
        to require the shift.
        
        Change-Id: I05a8e17ec53741e99b004369629fd9fecf78526d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-04  Justin Luth  <jluth@mail.com>  [309aded3145f8ecec9e9af61a3c64804258f8336]

        NFC prep for tdf#143899: move TextBoxIsFramePr into SwTextBoxHelper
        
        Now that writerfilter is part of sw,
        this helper function can be moved into a generic location
        so it can be used elsewhere.
        
        It will be needed for a layout exception,
        where floating tables and framePr frames
        are laid out differently from all other floating objects
        thanks to some new Microsoft inconsistencies.
        
        Change-Id: Ibb30a8831426b9dfd3e86ed082ecef22476fe018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172620
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2d096099a220e4caa2d532a5230785cbdb91eed]

        use less dynamic_cast when broadcasting SfxHint in sc
        
        Change-Id: I25ee079b5b14f82012f868ae6b348fa6982571a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172853
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-04  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [12f5c69ead6765dd3711db335763caf2df4e049f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef0468c99468c3f58211d9d327f8d8deaae90d86
          - tdf#155153 Change "Group" to "Group Shapes"
            
            Change-Id: Ia27e5bc2176f74642732c257692c1e9cdcf6e5a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172819
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [8fae3b4d33898d6703c2bca0e4ad8c7c02a08a67]

        Clarify the logic a bit
        
        Change-Id: Ia7ff63f6651e3003e25b1552f6fe22548df2fb81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172814
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [028ae168ca787e5c92560d051009a0f115911b57]

        Use value-initialization instead of conditional compilation
        
        Also fix loplugin:stringviewparam warning, unexpectedly appeared here - see
        https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/169049/consoleFull#-882392342baec2b5c-2b20-4190-a3fa-ceac4be9cf93
        
        Change-Id: I789f23c946a55194baa2b4e9a3f3c2a70385301d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172852
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-04  Eloi Montañés  <em@ilsrv.com>  [16a9df36380a24380d4eee77bee3c36223661907]

        Fix signature hash on NSS backend
        
        When using the NSS backend, the SignedAttributes were added after the hash
        computation for the timestamp request, altering the final signature and
        rendering the timestamp unverifiable.
        This patch changes the order in which the attributes are added and uses a copy
        of the signer for the hash computation in order to generate a correct hash.
        
        Change-Id: I14cecf1819e80d7a2e470e0f1dee2d09bcbe852c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171384
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-04  Jean-Pierre Ledure  <jp@ledure.be>  [87bfd87ecf1a613a979a829b915dd1ddac3eb9f2]

        ScriptForge (scriptforge.py) fine tune getattr/setattr()
        
        Several minor changes
        - comments
        - 'cls' used where relevant i.o. class name
        - dynamic getting/setting properties reviewed
        - SF_Platform properties:
          set level = 1 i.o. 0 when returned
          by PythonHelper module
        
        Change-Id: I4e9877bc16efd340dc14693833c032c998329b6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172836
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-09-04  Noel Grandin  <noelgrandin@gmail.com>  [0272d39589ad36a38f85928d6a21eb13d28d2904]

        convert SwFindNearestNode to regular class
        
        and simplify the GetInfo(), it is only used for this single
        purpose.
        
        Change-Id: I462cc10ff9341ace66581bd6af0cacc632866281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [10363c80eb3fd0637d91714fe977de77b43d3aa3]

        No need to copy the data, only to limit the size of bytes copied later
        
        Change-Id: I76d5c3cccf64a69efe41dd850fa2542e54c71428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172851
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [c785399884650fd0a1a4ffc3008fbb665e47a9d3]

        In MSVC, non-static constexpr objects are initialized at run-time
        
        Yes, it's a memcpy from a compile-time blob, but still they are
        stack-allocated, so cycles are spent on their initialization.
        
        Change-Id: I152369887a7769087e5dfe139ea82498533835b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172850
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-04  Kira Tubo  <kira.tubo@gmail.com>  [406f879af36c8cc524d87292ddffca7426811fa0]

        tdf#157230: Remove redundant Open and Save buttons in notebookbar
        
        In "Tabbed" UI toolbar, remove redundant buttons:
        - Recent Documents*
        - Open Remote*
        - Save As**
        - Save Remote**
        
        *Buttons/functionality already appear in "Open" popup menu
        **Buttons already appear in "Save" popup menu
        
        Affects Writer, Calc, Impress, and Draw toolbars.
        
        Change-Id: I0e37adae57333979bfd232e07c772998b91208d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172622
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-04  Julien Nabet  <serval2412@yahoo.fr>  [3c6e5d3750fd9c31bd374808c984374bf30e4d28]

        Typo mnClipRecurstionCount->mnClipRecursionCount
        
        Change-Id: I7ce859d402626da156ff36247d987a3fe3010e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172837
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7f50a49e6395dc36f97fda0082883e5981d1315a]

        Fix typo
        
        Change-Id: I24b0dc42a8b710aaa502f590a7071e463d1aeb14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172841
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-04  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [7c50ae543e8750729e9696685caf4afe87c39968]

        Revert "Resolves: tdf#162015 don't expand combobox when grid expands"
        
        This reverts commit cf0ba2bc29a351245f248802a8c04adb2428eb6e.
        
        Reason for revert: Going to implement a scrolled view, see tdf#162738
        
        Change-Id: Ib5d1e8ecc4309cca22a8f12e5f8f857eddfc8b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172760
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6557a73f12fbb2344baf51f22f9ad256ff83e4c]

        make ScAccWinFocusLostHint and siblings final classes
        
        that all directly extend SfxHint, as a precursor to use more SfxHintId
        to avoid dynamic_cast
        
        Change-Id: I35d908740f4200badd456e1cd5edc9457745c499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172804
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [fef0256122442a6536601f28914c516b036f7935]

        Optimize taking powers of 10, and move to the only place it's used
        
        Change-Id: I78b1ecb037f84ba4e7894d2a5ab088b7acb3f210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172802
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [677750f3f3d21c40e37cc4296673c931a0cb3779]

        Latest VS 2022 Preview is 17.12.0 now
        
        Release Notes:
        https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes
        https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-preview
        
        Change-Id: I5eb752972cb812d41f53d5c0daa10c2dac435e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171867
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-09-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [15bdbbb1bcd5be4046466669d6de78f6ddff647b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89f535d534780afd0dd684223c684b29e33c2009
          - tdf#162607 Remove dup's in hid2file.js, .uno:LoadStyles
            
            + touch insert new page/slide
            + refactor
            
            Change-Id: I9d4a1fa6ec31bd68b5fc6cbabc13a714ef595c5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172846
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [e21e07f24bfdbe802e3ed8e611a135ab2ad2fe4c]

        openssl: upgrade to 3.0.15
        
        Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.15/openssl-3.0.15.tar.gz
        
        Change-Id: Ic1598fe8fafe610c7a3b409c5811bcc52658b130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172830
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5bb5a7ea60c4496d7ad21ad81a0f37f6f5fd2288]

        Related: tdf#161826 - Add uniform Glow effect for texts in shapes
        
        Using text-properties for the glow-text attributes in odf import/export
        instead of graphic-properties.
        
        Change-Id: I94f5a76f33a03891fa0bfed988e7e3cd0e842cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172741
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5e70ede56af526fce71672a120e5e9cea6e3365b]

        use less dynamic_cast when broadcasting SfxHint in sw
        
        Change-Id: I308887f377b6b97b4949ab3a8815d3d423806e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7a32682f650a2a0f59ce52c91b30640d07e0a6a]

        use less dynamic_cast when broadcasting SfxHint
        
        Change-Id: I24c947c20afeffffebe5ac794108c4ccecb680f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-03  Jonathan Clark  <jonathan@libreoffice.org>  [6594b279a926e497261a4e802a5e74d2f3b97369]

        tdf#92064 sw: Improve large paragraph layout performance
        
        This change includes the following scalability improvements for
        documents containing extremely large paragraphs:
        
        - Reduces the size of layout contexts to account for LF control chars.
        
        - Due to typical access patterns while laying out paragraphs, VCL was
          making O(n^2) calls to vcl::ScriptRun::next(). VCL now uses an
          existing global LRU cache for script runs, avoiding much of this
          overhead.
        
        Change-Id: Iee03938683c95776a817d4819fe9a43c65a7c3fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172801
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-09-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7d3251adf2e95768c9169b92c8b3366c95f71bfa]

        Emscripten: Move -sEXPORT_EXCEPTION_HANDLING_HELPERS to gb_LinkTarget_LDFLAGS
        
        ...following up on 95e719730dc62cee3edc959bd9d96edfb992a642 "Emscripten:
        Explicitly set -sEXPORT_EXCEPTION_HANDLING_HELPERS".  For one, it should indeed
        only be relevant for linking.  For another, the previous change had caused at
        least ExternalProject_libtiff to fail with "checking whether the C compiler
        works... no" because of "emcc: error: EXPORT_EXCEPTION_HANDLING_HELPERS requires
        either of -fexceptions or -fwasm-exceptions".
        
        Change-Id: I477731c1cffd2b6ee895116043eda91fca44d08f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [590ad7d36bb1c6adc849c22095a54b71bba73ee5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 841ae9a6d8f803c873ad9b8461ee054c29cbb9af
          - Fix bad link
            
            Change-Id: I7ddb8eabf39856b32035b763c81af2912e65417a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172843
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-09-03  Mike Kaganski  <mike.kaganski@collabora.com>  [58458c6706a2cba6939043f2310c676407233a06]

        tdf#162761: fix rounding
        
        Regression after commit a245fd604c11f4bdbd1fdc4dd52e2a7f3880d85b
        (tdf#156530: fix OPreparedStatement::setString); when the Any has
        a double, its rounding must take its sign into account.
        
        Change-Id: I783454f1fbb1b1775a06d611f212575631fd5e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172800
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4568240bdfd173c274a392e61c05445afb73dd2]

        SwRedlineHint is dead
        
        ever since
            commit 43a36b36986dd2112fc90340e7a8a11ea5369def
            Author: Robert Roth <robert.roth.off@gmail.com>
            Date:   Mon Nov 1 02:50:47 2010 +0200
        Commented out code, bogus comments removed, some german comments
        translated.
        
        Change-Id: I9a6424080728ee42e1705e144cd53aa6069f2abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172826
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [41490b50e5a1c21b9a9cd064e2f3137c8ef44dfa]

        tdf#162764: make the two dialogs modal
        
        Change-Id: I4df5b44793487dbcb9f48c77d7f7835108cdc3fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172797
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b4773fe4d03c5a3ffa165b5b01f7928cf6b8278b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aae6ef303f218873f1df1b39a56dee2975df4bd2
          - tdf#162607 Remove dup's in hid2file.js, .uno:InsertMenu
            
            + .uno:InsertMenu scattered in 4 files
            + Same content in each
            + moved to shared/
            + refactor links from trees and main menus
            
            Change-Id: Iafd166596991c3d92e1e721837466456e090e2a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172835
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-03  Mike Kaganski  <mike.kaganski@collabora.com>  [74533c1f1d5e8e48a65d33bef236f1382d32aa06]

        tdf#162746: sanitize width in SwTextFormatter::FeedInf
        
        Since commit 7e9c23894bd45e015accf26ae0a77035b7eed452 (tdf#161368:
        use SwTwips for twip sizes, instead of sal_uInt16), the result of
        rInf.Right() - GetLeftMargin() is not cast to an unsigned type,
        so may happen to be a negative value. Make sure it's not negative;
        this doesn't fix the layout of this document (it still opens with
        table having wrong width, as before the mentioned commit), just
        avoids the infinite layout loop.
        
        Change-Id: I4930c8718d5fd09064ae0febd9b5adbdb0e2cd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172789
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-03  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a28cae7899a6fd0977919fd907396c70d92e41c2]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I5fc9823b6d0ca88505e8d4e6127fac7e776fa1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171784
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-03  Gökay Şatır  <gokaysatir@collabora.com>  [de9e0ee798df858d124abbfaff10608672dee69d]

        When a shape is selected, send other shapes' rectangles.
        
        GitHub issue link:
        * https://github.com/CollaboraOnline/online/issues/9689
        
        Also add OrdNum property to ExtraInfo in order to exclude the selected shape from the list.
        Check new properties in tiledrendering test.
        
        Change-Id: I544e2c8089510f47b0cc0f25e368cad6d459cb2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172730
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-03  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [c37d18c0a8dbe77ead043a1f3dce86192ca74a79]

        CairoSDPR: Fixed a problem with cairo_clip (see comments)
        
        Change-Id: I14d477dbeb9a18cc6f9d750b5d1f837117c22eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172798
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-03  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [1d31fb085c93218fddecc5de75f3c38a16c87b38]

        Revert "select first entry in dropdown by default"
        
        This reverts commit d8a5f0b15ed4ab4b61fb982d85e39939a23ba771.
        
        Reason for revert: Going to implement a scrolled view, see tdf#162738
        
        Change-Id: I24802846fe9e0af42a9ca3f4982c0cb165b82506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172759
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-09-03  Heiko Tietze  <tietze.heiko@gmail.com>  [91f0b84675b20332e618922494809d75d49e4fd6]

        Resolves tdf#162732 - Donate label not vertical centered
        
        Icon size matters
        
        Change-Id: I20919c16b32c9c810a57eeb70eef540587ff879e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172792
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-03  Mike Kaganski  <mike.kaganski@collabora.com>  [38f34257dfd7048b30df0c46b9d4639182a4cb13]

        Don't throw on a no-op
        
        Trying to set IsWidthRelative to true throws, showing warnings in the
        console. It happens during DOCX load in SwXText::convertToSwTable; so
        just do not throw when it's already enabled, as a no-op.
        
        Change-Id: I2c57a1f34a9b186cf76e2e422d446bee06134a63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172795
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f610a602c94925f2cae7765bae4a53816dd46aa5]

        tdf#160945: queryInterface must pass back indirect return value address in x0
        
        Change-Id: I28dacffbbcdf26ee453fd32aeb82166484612846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172791
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [24a3a7c72714c4f45c46cd2b6274013503d444d6]

        Emscripten: workerID is only defined under -sASSERTIONS
        
        ...and explicitly passing in pthread_self() on the calling side is better than
        trying to identify the calling thread on the callee side, anyway
        
        Change-Id: Ib26a7cbdede246280b6985b6eb1582baf172bf59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172786
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9778a09b858f6f11c3bea988bff409215e495ad1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1db70497366b3cdf27c5a5890959dcec53590729
          - Add missing file
            
            Change-Id: I65d9df6123b5229c42d9b9049c0384cd6d3d29fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172794
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-09-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [95e719730dc62cee3edc959bd9d96edfb992a642]

        Emscripten: Explicitly set -sEXPORT_EXCEPTION_HANDLING_HELPERS
        
        ...so that getCppExceptionTag and
        getCppExceptionThrownObjectFromWebAssemblyException are available in
        static/emscripten/uno.js.  Those apparently happen to already be available due
        to -sASSERTIONS=1, but better make that explicit (e.g., when we ever want to do
        -sASSERTIONS=0 builds).
        
        Change-Id: I3d94580930603eaf0f609d7878f97d12fb026714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0e621992d02f4872eb42da51ad3c3c136ce40379]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 299d2d8680d24b037047a8a70391960dba9d501c
          - tdf#162607 Remove dup's in hid2file.js, .uno:ViewMenu
            
            + .uno:WindowMenu scattered in 5 files
            + Same content in each
            + moved to shared/
            + refactor links from trees and main menus
            
            Change-Id: I1324aff453df2870a70926321a2211bc12901cd4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172793
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [046a8efdae37a3055fc42816bf69ecb399761eef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6b347432e6370b425c34cad64603626ca363916
          - tdf#162607 Remove dup's in hid2file.js, WindowList
            
            + .uno:WindowList scattered in 5 files
            + Same content in each
            + moved to shared/
            + refactor links from trees and main menus
            
            Change-Id: I1232812d662fa838b24385bf769941c6fafcc5d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172777
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-03  Miklos Vajna  <vmiklos@collabora.com>  [5130d240be13b62fe76769754d138fbe3e0e1581]

        cool#9956 uui lok: avoid showing the password dialog for now
        
        Select some HTML content on a password-protected webpage that has
        images, copy, paste into Writer when it's in LOK mode -> hang.
        
        What seems to happen is that the HTML content itself is on the
        clipboard, but not resources referred by that content, like images.
        Which means our code in SwHTMLParser::InsertImage() will at the end call
        into ucb/ code to get the HTTP image, which will call into uui/ code to
        ask for the password. This has multiple problems: 1) the popup dialog is
        not async (and not trivial to convert to async) and the dialog hints
        that the password can be saved, but LOK document edit sessions always
        start from a clean profile, so that's not working. The non-async dialog
        even results in a hang in practice.
        
        Fix the problem by not showing the password dialog in the LOK case at
        all: it's better to have an image placeholder in the paste result than
        hanging your entire document edit session.
        
        Non-password-protected images continue to work, unless
        HostFilter::isForbidden() rejects the URL.
        
        Change-Id: I1e55ab7adecd9c90ba38a97bcdc52b2b01f7ff2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172781
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-03  Michael Stahl  <michael.stahl@allotropia.de>  [d25f3a9eac1690e1d05840a4f00796d6ddba669b]

        sw: fix problem with 0-height text frames after unhiding section
        
        Not sure how this happens, apparently only in some specific
        circumstance, but the problem is that the SwTextFrame::Format() does
        nothing because !aAccess.GetPara()->GetReformat().Len().
        
        Also adapt the loop in SwSectionFrame::SwClientNotify() to columns.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: Iba0b1657f915530ab9841823ad5ad1e7faa15e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172776
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45934a7b57a519e751beb27d6e1ced72e896dc58]

        ofz#70815 Timeout, reduce this limit for fuzzing
        
        Change-Id: I49f971796ed880f14514cc3f52bcd4405c16ecce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172787
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-03  AhmedHamed  <ahmedhamed3699@gmail.com>  [d05e0be5f4ab2bdb31d6cf14528a9a8ee5ac965c]

        tdf#161543 Enhance the searching functionality in FD & FW
        
        Change-Id: I1a21595228f886c942ae46d90e41705443d31550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170073
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-09-03  Miklos Vajna  <vmiklos@collabora.com>  [5b0256f30ee154edb28b999bc4faba2453fc32b8]

        tdf#162507 sw floattable: fix not wanted join of two different split anchors
        
        Open the bugdoc, go to the end of the "Cannot press Delete here"
        paragraph, press delete, layout hangs.
        
        The trouble seems to be that this creates a doc model where multiple
        multi-page floating tables are anchored to the same paragraph, which is
        not something the layout supports. We explicitly avoid this at import
        time from DOCX since commit 01ad8ec4bb5425446e95dbada81de435646824b4 (sw
        floattable: fix lost tables around a floating table from DOCX,
        2023-06-05), but there was no mechanism to prevent the UI creating the
        same unsupported doc model.
        
        Fix the problem by extending SwWrtShell::DelRight() to prevent joining 2
        paragraphs in the unwanted case, interesting Word doesn't allow deleting
        at the end of that paragraph, either.
        
        Regression from commit 693ad3aadbf84afa750af73c330fe7e09b38a2e7
        (tdf#120262 sw floattable, legacy: go outside body only for page frame
        vert pos, 2023-07-31), which restricted the amount of cases where some
        weird legacy behavior was performed, so good to keep that side as-is.
        
        Change-Id: I4d8a6702d8ac1689690fa464014c99fcd5ef7bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172780
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-03  Gülşah Köse  <gulsah.kose@collabora.com>  [0036a8c05cd160c66121a5c630cfadcb2cfec54a]

        ONLINE: Fix multi user dark mode link color problem
        
        If one user change the theme to dark mode, other user's link color is
        changed to dark mode link color too. In this commit we prevent that
        problem.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I65838e106794d649c362cf181ca300045053f169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169984
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 1ae9e6fc33bac1ba0ac49a61ca567965dc81a6d6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172668
        Tested-by: Jenkins

2024-09-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [1c834f936691bac191e7cde0a9856545d6c90f32]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e67095e7efaa4cb698e57d64d397fe9b56602680
          - tdf#162476 Adapt help accordingly (vd. core commit e372b38)
            
            Change-Id: I66a85f0a3ff6c33901639f68028891271c1bd200
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172779
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-09-02  László Németh  <nemeth@numbertext.org>  [bcadc9a6ec5be2541e259f0fa18022c0661c8df7]

        tdf#162725 sw smart justify: fix last line with multiple portions
        
        Fix last lines of paragraphs, which contains multiple portions,
        and exceeded the width of the paragraph because of missing space
        shrinking.
        
        Follow-up to commit 6b857398a59d16308d6185d01e003e401439f060
        "tdf#162109 sw smart justify: fix overhanging last line" and
        commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46
        "tdf#162220 sw smart justify: fix shrinking for single portion lines".
        
        This reverts (and improves) the code removed in tdf#162220 (commit
        22eac3145ca62d15b47d95f4df60ce38d4f5aa46), because that code
        still needs for lines with multiple portions.
        
        Change-Id: Id87d87defc79742513ceb0f90b83e6d4f0e4b271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172692
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-09-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c56ae17de53e37b971fc815199bd500b0b663981]

        scp2: simplifiy language snippet creation rules
        
        get rid of some needless redirection/nesting for stuff that's only
        used a single time.
        
        Change-Id: Ie72c006ae1ad1839ae72a1eb19c67d2122798af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172737
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-09-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a444f410e222edb7fd6452645d40fd3cfc51628c]

        scp2 template generation: don't duplicate make's job in the script
        
        it is make's job to determine whether the script should be run
        again/whether the prerequisites have been touched since the target
        was made. Also the case where the list of languages didn't change
        had already been disabled/never was active in the first place
        
        Change-Id: I065faa00162f2d734330b798d9ac17ea47861686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172736
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-09-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4295077072cb4ccce167cf1e02a6477c2d65f0c]

        cid#1608081 silence Overflowed array index write
        
        Change-Id: I3d44664c4a54797911a1be6bb0b0feb5ccd15b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172773
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07a01c26a6c86ab67a42ecb29a63a18518802dba]

        cid#1608218 silence Overflowed return value
        
        Change-Id: I42f536c0c48b750ba7f8db0784bf5f525af99c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [228946f64c2725e9662d3aa2983b8835d34d99fe]

        cid#1607774 silence Overflowed integer argument
        
        Change-Id: Iebe15d0323253ebb06b26fc42e78993be5fa92d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172771
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b4a5e047283a23be2a7b4b2b057ee97c7c99113]

        cid#1608421 silence Overflowed constant
        
        and
        
        cid#1608468 silence Overflowed constant
        cid#1608519 silence Overflowed constant
        cid#1608531 silence Overflowed constant
        cid#1607216 silence Overflowed constant
        cid#1606854 silence Overflowed constant
        
        Change-Id: I805be34fe58895af3898ff9729aa3b3d3964221e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172770
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [02f01fea46f3697b59a9b37870c51d23ff406530]

        cid#1608532 Data race condition
        
        and a bunch of dups
        
        Change-Id: I700cd803b9550a0577604ebe0f4fbe16d56aa6a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172769
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-02  Jim Raykowski  <raykowj@gmail.com>  [e589ea5eb50dcc1a6894084df3cdaa02060835b9]

        Fix Basic Macro Organizer library list after import of library
        
        with Insert as reference (read-only) option checked
        
        The last entry in the list always shows the link location of the just
        imported library. This will only be correct if the imported library is
        alphabetically the last entry in the list.
        
        Change-Id: I03472dc75582e92b87923faf96d14615b8adecf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172561
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-09-02  Jim Raykowski  <raykowj@gmail.com>  [9f79c01035fb5851bcba1f8fc646437be84f7194]

        Related: tdf#162580 When upgrading from Find toolbar search to
        
        advanced Find and Replace search dialog, inherit (pre-fill) search
        field's term from current value of find bar's focused search entry
        
        Makes the Writer quick find panel behave as such.
        
        Change-Id: I2164f443d6ef120d86b001499f67795eaeaf224d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172375
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-09-02  Patrick Luby  <guibmacdev@gmail.com>  [bb1ce025ae6479bc3044197f25990d8c41ae09de]

        tdf#162646 suppress drawing hairlines when scaling
        
        Previously, drawing hairlines (i.e. zero line width) was only
        suppressed when running unit tests. But drawing hairlines causes
        unexpected shifting of the lines when using a Retina display on
        macOS and antialiasing is disabled.
        
        Change-Id: I6e788099c110862afc1f7a085dfac4a2908ca51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172742
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-09-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7ace91cad46d78b85936464b3e77e236b20ef0fb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 662d3b9e8aa7359d8d503046eee2067aeb8e937b
          - tdf#162607 Remove dup's in hid2file.js,
            
            + SVX_HID_GRID*
            + refactor EDIT_WIN
            
            Change-Id: I2009edc697dda32b12a15664ef2aab80de25c779
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172705
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-09-02  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [e372b380d27efa024bc8259f26a6c59241dcad27]

        tdf#162476 Pluralize command name to reflect its effect beyond the current cell
        
        Change-Id: I7f1c66d1e6aff049f5990a332cbe1d4e70fbcc5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172739
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-09-02  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [1a95aa91f7cfe7765a5277cca09b35c398638a23]

        tdf#155153 Change "Group" to "Group Shapes" and remove duplicated node.
        
        Change-Id: I7adeea4abb1ae188ef1af401d098f0c4967c3f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172278
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-09-02  Michael Stahl  <michael.stahl@allotropia.de>  [5f0f69ba9b7d083cf7c0169be6e9c916008787bb]

        sw: fix iterating columned sections in SwSectionFrame::SwClientNotify()
        
        This was asserting in JunitTest_sw_unoapi_3 on libreoffice-24-2 branch
        but strangely enough not on master.
        
        (regression from commit a97e245ba11598050e1800fde9ace796d20e9df2)
        
        Change-Id: Id71dac03992fff0294ab1b2c6d9f3bf10b8c3974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172740
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-02  Michael Stahl  <michael.stahl@allotropia.de>  [1dc58a1d801b030b4d8fb9ae1e1042aca08db875]

        sw: view settings for testHiddenSectionPageDescs
        
        Should be more reliable.
        
        Change-Id: If04f1e246112b1a133773263b2b07ac3870d1676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172656
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-09-02  Eike Rathke  <erack@redhat.com>  [79ed97b93be2711bab5530d8ddc18e318be644d9]

        Add-In CompatibilityName: for "en-US" try the most likely fallback of "en"
        
        As this needs to be resolved for every occurrence of the function
        name during export to OOXML and .xls and Add-In authors tend to be
        lax with en-US vs en-GB, also because function names usually don't
        differ, and use "en" at least in DisplayName.
        
        Change-Id: If0b1b60c4806028c76296e5feaa74e7ddb307bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172735
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-09-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b9be7cb9486f0566a7dec973867e1fe7c5ebc5d]

        tdf#152919: Add comment about unittest
        
        Covered by unittest added in a97e245ba11598050e1800fde9ace796d20e9df2
        "sw: layout: fix page breaks when unhiding a hidden section"
        
        See https://gerrit.libreoffice.org/c/core/+/172663/comments/86259634_a0fdbeff
        
        Change-Id: Ib1913c04c6a487c2009228d66788c8d065e3405f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172734
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [21cc1049c5dace75aedbf182520ed9b285b4fbbb]

        update credits
        
        Change-Id: I3dbd9cd17162a6d74d792c9634ea85d16db073a0

2024-09-02  Mike Kaganski  <mike.kaganski@collabora.com>  [bb169c209cddc1bfe5c383b18f0dd514ea1b74fd]

        Fix ImpCurrencyToString to handle SAL_MIN_INT64
        
        It can't be negated; so avoid the negation, and skip the minus in the
        string result. Also, avoid needless creation of OUString.
        
        Change-Id: If867c189b2ffd2794a58f66fd2511004ed4fc25a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172733
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [6386a1612042ea8ccec3913ce56f0e2d119e739f]

        CiaroSDPR: Small optimizations
        
        Change-Id: Iecfec4668a465cc2fd3687d66f67de6e0d1e33c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172687
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-09-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [32ce555c9daff2d4044c041e220fde44cf4aff67]

        Explicitly .delete() one more interface object in uno.js
        
        ...accidentally left over from 91842724235bca73690d67d8084ec7581512d791
        "Explicitly .delete() type and interface objects in uno.js"
        
        Change-Id: I84b1b7b5ee283a1a87f5d3aa894776b1bf23c607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172731
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-09-02  Adam Seskunas  <adamseskunas@gmail.com>  [50097952a8ec6abd2b383d219bdcf26cc7b055d5]

        tdf#61309 Add Unit test
        
        Change-Id: I4160a5fc8a14c383b5249eed539ae8044b2a8e7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172555
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-09-02  Miklos Vajna  <vmiklos@collabora.com>  [20ea8a89aa5fc733ddc9ade7b3d40a2ca62a563f]

        svx: prefix members of XPolyPolygon
        
        See tdf#94879 for motivation.
        
        Change-Id: I09d2827c7e2dd91f9bf160e47c22180bde682932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172727
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-09-02  Justin Luth  <jluth@mail.com>  [23a97ce1d501a7b98d438007c4cfe5b5c77fa295]

        tdf#162539 layoutInCell: limit vert to cell margin
        
        Although horizontal offsets can go to the cell edge,
        vertical offsets are limited to the cell margin.
        Don't ask me why.
        
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf162551
        
        Change-Id: I3741b46396b67f5e7ea3596e49730aea24e40c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172612
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-09-01  Chris Sherlock  <chris.sherlock79@gmail.com>  [77aa9c210ad79af443191860ee1a7233d2d007cf]

        vcl: flatten Animation.cxx functions
        
        Change-Id: I613c630bdbd9eefa4c9196e4647fb0f26f5efcd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172691
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fc7e5f54edcc0fccf3b9c2f8395336e7dbc0bfc4]

        null deref of pTableView seen
        
         #0  ImpEditView::GetOutputArea (this=<optimized out>)
             at editeng/source/editeng/impedit.hxx:366
         #1  EditView::GetOutputArea (this=this@entry=0x0)
             at editeng/source/editeng/editview.cxx:442
         #2  0x00007fc50355663a in ScModelObj::setTextSelection(int, int, int) ()
             at sc/source/ui/unoobj/docuno.cxx:870
         #3  0x00007fc51206e910 in doc_setTextSelection ()
             at desktop/source/lib/init.cxx:5653
         #4  0x0000000000577c54 in lok::Document::setTextSelection (nY=<optimized out>, nX=<optimized out>, nType=<optimized out>,
             this=<optimized out>)
        
        Change-Id: If30a32b6c365fb7fdcfcfcaa27e08ed39c75116f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172678
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [c83afed32fbcec2a22862d97e8974ba202029051]

        Piano template: replace pictures with shapes
        
        Pictures in Piano Impress template can be replaced by simple shapes.
        Illustrations are now sharper. User may modifiy colors or adds music
        notes.
        Set font color to black for Handout and Notes elements
        Remove text:span empty tags
        
        Change-Id: Icf91ce91eb51e3871be23f1d901b510a781aa43e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171752
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4487e60a4a4928430fb743601e73fffa86fe7792]

        forward argless ctor to the single arg ctor
        
        and inline and remove init then
        
        Change-Id: I5c4d62ef84223cbb6a47df376be5b4512aacba7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5c04238908c055dd5a04abc6d2b4a0430be8830]

        use final upstream merged fix for this boost issue
        
        Change-Id: I33a347d3c0efc4a38389d525f3c9e5f41a957d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172723
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [883d19101edd2794e972b3cbc4f70ee737fab4cd]

        cid#1607226 silence Overflowed constant
        
        Change-Id: I49bdb9916f7c54621e8853c6bb1e7957c9b552a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172722
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [740c0a33816fc979e5facb731e2d23e9a8411c75]

        cid#1607081 PA: Public Attribute
        
        Change-Id: I8b2e8bce03062ffe4c721ac3d3db64b6bd3f15eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e640d4e47366548ab1f2d938db1d9256ebfdbe70]

        cid#1606637 Overflowed integer argument
        
        Change-Id: I83a94ce7bd2d926ca925860cc712ec5ece87ae86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Sohrab Kazak  <sohrab.kazak@gmail.com>  [b28fdc6b412c30b2d16c622483be4e6ee1359121]

        tdf#145538 tdf#153109 Use all_of / range-based for loops
        
        Change-Id: I7717c85fa55083794b07433e0b0807424cf7f39e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172221
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [58a41f2c62cbe871151ce45bb3838f9a000ffa36]

        drop [[fall-through]] and expand in the case
        
        Change-Id: I34f76a9cb54c0d7d05f029f8ddf4ccac23719668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172719
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b3118bebb5eb942fb2b871617b6591af18349291]

        split this hunk into a standalone function
        
        Change-Id: I5079c615efa09e6db1920892910c810375b42ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172718
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4064be6b29c791af45d61a7b394130156c44f483]

        cid#1618765 Big parameter passed by value
        
        Change-Id: I16b53c5be24a9698c50c025f7f7cec8cca31ed1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172717
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fcd432494a6e760afbf2206dea3a1f07ffe92c03]

        cid#1607035 silence Overflowed integer argument
        
        Change-Id: Iddf32ee09c8cbc4a7f80c943a0e472f018881be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172716
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [881f924e6bfc2ba6f22ea3d1199848095a1a2110]

        cid#1607430 Overflowed integer argument
        
        and
        
        cid#1606956 Overflowed integer argument
        
        Change-Id: Ie940530f1538a36ab995407bc0fe01386cd10367
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172715
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f6f581dad7817f19a575063dc6e60e57b0f47ccd]

        cid#1607909 silence Overflowed constant
        
        Change-Id: I83f504fcbc345753e9eb5b322b89ae76995794de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172714
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84ef34c1b20e5c1ceafd98072e47d4172b0ca21d]

        cid#1607865 silence Overflowed constant
        
        Change-Id: Ie008b4e09d4839726ae0e2db912393552d92c23a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172713
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b3f2171cc6296b575a2b3bd5a0504d99042c5c9]

        cid#1618766 Unchecked return value
        
        Change-Id: I600d536db7069209ffd14fb704b1c02a3ff85121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172712
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-01  Noel Grandin  <noelgrandin@gmail.com>  [5456431aff45c7080ad894f055bcd7513a93a6a6]

        ImplB2DPolygon could do with a move constructor
        
        somewhat surprising coverity did not flag this
        
        Change-Id: I52684c6adbf3e051c3ada88fc427078cf0867460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172709
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [e0b3f78e66227ecc4cf314f43616e7b08b5e6d2b]

        Pencil template: replace pictures with shapes
        
        Pictures in Pencil Impress template can be replaced by simple shapes.
        Illustration is now sharper. User may modifiy pencil colors.
        
        Change-Id: I266f9ac47661e4eb050d68afe4f72841d10edb0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171714
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Noel Grandin  <noelgrandin@gmail.com>  [9686a654506999a806a51ee1a13c871be4ba27a0]

        avoid intermediate copy in B2DPolygon::append
        
        Change-Id: If187028195afcef42f9171f54651ada35bf3be4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172708
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f903bd3ad0619eb55941904d8a49b1e86d39e26]

        ofz#70815 optimize this a little
        
         #5 0x558251409124 in operator new[](unsigned long) /src/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:98:3
         #6 0x558255fb4937 in ImplPolygon::ImplPolygon(ImplPolygon const&) /src/libreoffice/tools/source/generic/poly.cxx:74:26
         #7 0x558255fbbfd3 in impl_t /src/libreoffice/include/o3tl/cow_wrapper.hxx:195:17
         #8 0x558255fbbfd3 in cow_wrapper /src/libreoffice/include/o3tl/cow_wrapper.hxx:236:26
         #9 0x558255fbbfd3 in tools::Polygon::Polygon(tools::Rectangle const&) /src/libreoffice/tools/source/generic/poly.cxx:887:53
        
        shouldn't need to create a copy here
        
        Change-Id: I44122aaca0b49f31dd85e95920c9911b96e4227f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172706
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [d19c5e0c60685b0a46cd92a6dac1463b8f90e602]

        Update Sunset Impress template
        
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo-cft (CubaLibre)
          - remove writing mode tags
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
        https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - set font colot to black for Footer/Header/Date/Page in Notes and Handout
          - remove unused styles
          - set bullet color of outline to black
          - add shadow+blur to rectangles
          - add gradient transparency to sun rays
          - remove text:span empty tags
        
        Change-Id: I9df314d05a867befa568be6cc103e0666ad7acc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171831
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [2e49a080822bf52c063e909cc996987d55f8764e]

        Nature_Illustration template: replace background jpg
        
        To ease modifications by user, this change replace both background
        pictures, by their equivalent in shapes. Now, trees, sun, clouds, flowers can be
        moved, removed or duplicated. Illustration is sharper.
          - add shadow and blur to clouds on 2nd master
          - add shadow and blur to other shapes (1st and 2nd master), to have a more consistent presentation
          - move light green tree in the foreground for a more logic perspective
          - remove unused styles
          - remove text:span empty tags
        
        Change-Id: I6164df062902db8aa991fcc7ccab8a85f5fc3bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171700
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d66974cd5401f5a5fe71e174d2f788400623bd99]

        Fix typo
        
        Change-Id: Ie249679230c38dd1eaa42d87597401d430771a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172710
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [6eba92c7964e093b9fc7fa0df029fb99604ac547]

        Update Vivid Impress template
        
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - change Source Sans Pro font to Noto Sans (as Source xxx Pro are no more bundled)
          - remove Objekt_20_ohne_20_Füllung_20_und_20_Linie style
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
        https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - remove unused styles
          - remove writing mode tags
          - correct misalignment in Handout and Notes view of Header/Footer
          - set font colot to black for Footer/Header/Date/Page in Notes and Handout
          - use Accent style for filling
          - remove text:span empty tags
        
        Change-Id: I3c24ad82b0ad30a6d28b6bd9e0b6cfa09cb171c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171873
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [4090f47b95dd0fdde3847f59aa39b7677f8e1b4b]

        Update Vintage Impress template
        
          - simplify definition of font names (replace Liberation Sans with Liberation Serif)
          - add initial creator in meta.xml according to
        https://wiki.documentfoundation.org/Design/Call_for_Templates
          - remove unused styles
          - slide 1 replace outline with subtitle
          - move date/time field on a more readable place
          - better position for two columns slide
          - remove last slide as authors' credit is in File > Properties
          - remove text:span empty tags
        
        Change-Id: Iafd4beb6319aa2a122c70e1c0ea4e4d353427360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171857
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [0cd313c4d8c5a890eede5689e25860357bae012d]

        Update Pencil Impress template
        
          - remove unused styles
          - simplify definition of font names
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - remove writing mode tags
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - set all title font size to 32pt
          - use same orange color for both master slides
        
        Change-Id: I2d074e97a7ff02ee8f63d63a474583c5af5e5f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171713
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [c7344d039b07d474b11493af70152369d5430826]

        Update Metropolis Impress template
        
          - remove PNG image to keep only SVG image
          - protect position and size of background image
          - simplify definition of font names
          - remove unused styles
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo-cft
          - remove text:span empty tags
        
        Change-Id: Ib4879f38113182a7bbae60e4be456c7a189ffb94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171331
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [e63921556cf919da5e5dcdc8d88ee6b42b5eadd5]

        Update Forestbird Impress template
        
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - group drawing objects
          - remove unused styles
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - remove text:span empty tags
        
        Change-Id: Idc2a26d47dda504c01ecf8f5886b9617642618a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171220
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Laurent Balland  <laurent.balland@mailo.fr>  [6c6fc60e1bbd72f734ac325d614a4164b759a366]

        Update Nature_Illustration Impress template
        
          - remove unused styles
          - simplify definition of font names
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
        
        Change-Id: Ifbe3954bafe7b1e957a928e1d7aaa34db764a237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171515
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [7bbf1f2a7d4cb3230bf69723b6864cff1a52d531]

        Refactor ImpCurrencyToString for simplicity
        
        Change-Id: Ie7acafb3c81348f03340f1aaa53b3849c8dae4a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172694
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a795fddafad69e8a7ce600352c7236b35539cebb]

        tdf#162724: use localized decimal separator in ImpCurrencyToString
        
        Same as in ImpCvtNum
        
        Change-Id: Icbaa237e944a39309b01fdb18e668d054ff61c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-09-01  Patrick Luby  <guibmacdev@gmail.com>  [9147506aa6c4d5b783a367d89609ec1e8d7fe966]

        tdf#162646 don't move orthogonal polypolygons when scaling
        
        Previously, polypolygons would be moved slightly but this causes
        misdrawing of orthogonal polypolygons (i.e. polypolygons with only
        vertical and horizontal lines) when using a Retina display on
        macOS.
        
        Change-Id: I314b22aaa84131e7e987d0ed99cc67a99297daf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172707
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95f23282edb0bdf834b71d7dec2b584e18c82015]

        cid#1608435 Use of auto that causes a copy
        
        Change-Id: Iaff34cb1974932baa27b261041a91fd9a2da9fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172702
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [900f47904517878530b88776a09a3268f4cc1a84]

        cid#1608098 Overflowed constant
        
        Change-Id: I9056a3a75bff9948ad04eb36da4996820bf5a32d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172701
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [beb7dc01ebf8558232ae41976e88b1ee7ed7be0f]

        cid#1607713 silence Overflowed constant
        
        Change-Id: I0b3b924689685cfb7ae5cd64db5e3ef371541769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172700
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c8468882296f38288b86ccf369e5df2272b6e1e4]

        bump these allowed fuzzer input sizes
        
        Change-Id: I8c2071cf8fef16201365ba8e4cb356f5605383c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172704
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f635441715501aed14f480f72caf1e870b2689ca]

        use the rtf dict for the calc rtl fuzzer
        
        Change-Id: I8d98054b4e1fe5ea2d2f04f38ccb3ccfea11e9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172703
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [372feea4bfc95454845b608d1d313a1402262203]

        cid#1607670 Overflowed constant
        
        Change-Id: I4eb19393eec6a7fb8d482597751d5fd7730213b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172699
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d40b5f9cfcc971620bcd0400433fd032c46ff8ca]

        cid#1606767 Overflowed constant
        
        Change-Id: I9f2db2175da45fc42a14f193700692c069f5cf3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172698
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7c49f6c89e7501f4b5ca28a45a91c6cdac5eb01b]

        cid#1608005 Overflowed constant
        
        Change-Id: Iecc3ff0e7651ec52a2372d383f1d82c454d9dbd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172697
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [68730a0e14d2ea37d5aa78bb19d16d5a5ee9d9ae]

        assign immediately
        
        Change-Id: I2e92313a2428252422b68dd5fd353425add21025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172696
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d6b5a0a7dc6594497628010dca7797953b48a0a]

        cid#1607209 PA: Public Attribute
        
        Change-Id: Ice339715762177e7a2905ec1de1703da7d9b74ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172695
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25209dbefbb21fcaa9bc00e7ad8ad064cea92e39]

        cid#1607947 silence Overflowed array index write
        
        Change-Id: I35b8db34e722e700df2771da99d76d42fe2cada6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172640
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [18746c7efe0b6eb78ec19a99b65c40a8291eb8d7]

        Update Progress Impress template
        
          - simplify definition of font names (replace Liberation Narrow with Liberation)
          - remove writing mode tags
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo-cft
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
        https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - remove unused styles
          - remove useless shapes
          - correct misalignment in Handout and Notes view of Header/Footer
          - Slide 1: center Title/subtitle
          - rotate outline in last slide
          - remove text:span empty tags
        
        Change-Id: Ibbc4b469edd78af6b8ce0766137d4e2218b8b35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171812
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [aab11d61997d11c23facf9e2ab34b6a9d5787b68]

        Update Portfolio template
        
          - simplify definition of font names
          - remove writing mode tags
          - correctly rename first master as "Portfolio"; see
        https://bugs.documentfoundation.org/show_bug.cgi?id=158496
          - restore bullets for Portfolio-outline1 (bug was hidden due to a display-name different from its name)
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
        https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo-cft
          - remove unused styles
          - remove text:span empty tags
        
        Change-Id: I3931f0ab80f0533e49496417e4852d7bfcabd778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171799
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b28339494dcaf837a3dd45fc3fd3ae538bfad751]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d41c733d4d966f47cc0212a526d78722eee81ca8
          - tdf#162607 Remove dup's in hid2file.js WIZARDS
            
            + Deleted dups for
             WIZARDS_HID_QUERYWIZARD_CMDMOVEUP
             WIZARDS_HID_DLGFORM_CMDNEXT
             WIZARDS_HID_QUERYWIZARD_CMDMOVEDOWN
            
            + refactor
            
            Change-Id: I1fc23411cdf26464629cc0621cf8e889a004fc84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172690
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [f7f87ca21e20badfde3b7328e71f259d69c01391]

        Update Piano Impress template
        
          - remove unused styles
          - simplify definition of font names
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - remove writing mode tags
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        
        Change-Id: Ibf57a515dce0952c2d08fe1abfaef1bff462f433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171751
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-31  Pierre F  <fpy@bger.ch>  [4745d42051915cbf36007f8e0ddb8768eb12579a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc7a2b091a7652d4907391f8e39262b65ae6c780
          - clarify Instr(). tdf#129436, tdf#139840
            
            Change-Id: I14f70db80e2a09f9c1e614d0e079830016cbea0f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171778
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [1e2836665a1839f61cd8bfa46c54687f010e7e9d]

        tdf#162696 tdf#130857 qt weld: Get parent via SalInstanceWidget
        
        Since only welding for simple message dialogs has been
        implemented for the Qt based VCL plugins so far, the
        `weld::Widget*` parent passed to `QtInstance::CreateMessageDialog`
        is usually not a `QtInstanceWidget`.
        
        The initial implementation to get a parent from
        
            commit 9e40fc8c9458b937200ea56c96b89113c74b67f5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Feb 14 10:54:59 2024 +0100
        
                tdf#130857 qt weld: Set msg dialog parent
        
        implemented a fallback to use of the currently active
        window if no native Qt parent is set.
        
        That is however not sufficient to reliably set the
        correct parent for the QMessageBox for the tdf#162696
        scenario, where the "Extension" dialog that is the
        parent and the message box and the message box itself
        are created shortly after each other, and the extension
        dialog does not reliably have focus yet when the message
        box is created, so the start center window would sometimes
        be set as the parent of the message dialog instead.
        
        Adjust the logic to make use of the implementation detail
        that non-Qt parents are `SalInstanceWidget`s.
        Retrieve a `QWidget` to use as the parent via
        the `SalFrame`/`QtFrame` in that case.
        
        This makes setting the correct parent work for both,
        the case described in the commit message of the
        above-mentioned commit and for the tdf#162696
        case, fixing the issue mentioned in tdf#162696#c13:
        
        > One small thing I noticed is that after clicking OK on the warning
        > dialog, the Extensions dialog has to be manually brought into focus. So
        > it's not layered below the warning dialog during the first installation
        > action in a session.
        
        Change-Id: I4de403a8ed78a649a17f6cabc0e0f5fdecae09c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172686
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [5ef991ffc226424a673662b6e478db124825022a]

        tdf#162696 qt: Always run QtFrame::SetPosSize in main thread
        
        This fixes the following assert seen with the qt6 VCL plugin
        when run with a current Qt 6 dev debug build for the tdf#162696
        scenario when when native Qt widgets (currently only message dialogs
        are implmeneted) are explicitly disabled using
        `SAL_VCL_QT_NO_WELDED_WIDGETS=1`.
        
            ASSERT failure in QWidget: "Widgets must be created in the GUI thread.", file /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp, line 958
            terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException'
        
            Fatal exception: Signal 6
            Stack:
            #0 sal::backtrace_get(unsigned int) at /home/michi/development/git/libreoffice/sal/osl/unx/backtraceapi.cxx:42
            #1 (anonymous namespace)::printStack(int) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:289
            #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:330
            #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:427
            #4 /lib/x86_64-linux-gnu/libc.so.6(+0x3f590) [0x7f73cbe55590]
            #5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 (discriminator 1)
            #6 raise at ./signal/../sysdeps/posix/raise.c:27
            #7 abort at ./stdlib/abort.c:81
            #8 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xa1a3d) [0x7f73cbaa1a3d]
            #9 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xb306a) [0x7f73cbab306a]
            #10 std::unexpected() in /lib/x86_64-linux-gnu/libstdc++.so.6
            #11 /home/michi/development/git/qt5/qtbase/lib/libQt6Core.so.6(+0xed562) [0x7f73b78ed562]
            #12 QMessageLogger::fatal() const at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:901
            #13 qt_assert_x(char const*, char const*, char const*, int) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:0
            #14 QWidgetPrivate::init(QWidget*, QFlags<Qt::WindowType>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:959
            #15 QWidget::QWidget(QWidgetPrivate&, QWidget*, QFlags<Qt::WindowType>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:878
            #16 QMenuBar::QMenuBar(QWidget*) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qmenubar.cpp:715
            #17 QMainWindow::menuBar() const at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qmainwindow.cpp:468
            #18 QtFrame::menuBarOffset() const at /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx:462
            #19 QtFrame::SetDefaultPos() at /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx:479
            #20 QtFrame::SetPosSize(long, long, long, long, unsigned short) at /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx:565
            #21 vcl::Window::setPosSizePixel(long, long, long, long, PosSizeFlags) at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:2786
            #22 vcl::Window::SetSizePixel(Size const&) at /home/michi/development/git/libreoffice/vcl/source/window/window2.cxx:1344
            #23 SystemWindow::setOptimalLayoutSize(bool) at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:1085
            #24 SystemWindow::DoInitialLayout() at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:1098
            #25 Dialog::StateChanged(StateChangedType) at /home/michi/development/git/libreoffice/vcl/source/window/dialog.cxx:761
            #26 MessageDialog::StateChanged(StateChangedType) at /home/michi/development/git/libreoffice/vcl/source/window/layout.cxx:2706
            #27 vcl::Window::CompatStateChanged(StateChangedType) at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:3921
            #28 vcl::Window::ImplCallInitShow() at /home/michi/development/git/libreoffice/vcl/source/window/event.cxx:496
            #29 vcl::Window::Show(bool, ShowFlags) at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:2312
            #30 Dialog::ImplStartExecute() at /home/michi/development/git/libreoffice/vcl/source/window/dialog.cxx:1021
            #31 Dialog::Execute() at /home/michi/development/git/libreoffice/vcl/source/window/dialog.cxx:1071
            #32 SalInstanceDialog::run() at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:1898
            #33 dp_gui::(anonymous namespace)::ProgressCmdEnv::handle(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:459
            #34 dp_misc::interactContinuation(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, bool*, bool*) at /home/michi/development/git/libreoffice/desktop/source/deployment/misc/dp_interact.cxx:114
            #35 dp_manager::ExtensionManager::checkUpdate(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::deployment::XPackage> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:1348
            [...]
        
        Change-Id: I9eb0ac63c50de3c713328d0466cb01ea90251741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172685
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [e40544bcc5a671b2bc753faa5f843f8fe97ff793]

        Update Midnightblue Impress template
        
          - change Source Sans Pro font to Noto Sans (as Source xxx Pro are no more bundled)
          - restore green border on Midnightblue2 master slide (resolution of tdf#114746)
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - remove writing mode tags
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo51-templates
          - correct misalignment in Handout view of Header/Footer
          - remove bolding of Header/footer/... in Notes views
          - use base styles "Filled Blue", "Filled Green" for objects (so filling colors could easily be reused)
          - correct ODF validator error for graphic properties in Mdp2 style
          - remove text:span empty tags
        
        Change-Id: I18e9c234b1f086f72e4d475d8861654459537b61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171511
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [baf7cb96d46c3304c5be6a6a2565534b02824bc7]

        tdf#162229 DNA Impress template: smarter DNA chain
        
        - resort elements in more logical order
        - modify position to more regular place
        - modify darkness according to distance
        - update thumbnail.png
        - remove text:span empty tags
        
        Change-Id: Ib260c15aaf420837f24cde93b667f1cb9dbb6a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171021
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [1da2778bc4df3209689dc32dfa0c91848d384556]

        Update Lights Impress template
        
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - remove writing mode tags
          - simplify definition of font names
          - remove duplicate Date and Page placeholders on masters Lights2 and Lights1
          - set font colot to black for Footer/Header/Date/Page in Notes
          - change slide 3 to Title+Content
          - restore white+ transparency background to content of master Lights2
          - remove unused styles
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - remove text:span empty tags
        
        Change-Id: I50aa21fd0f77d808bb0d4d3d554dc68e09f528ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171252
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-31  László Németh  <nemeth@numbertext.org>  [1a87cd290282ea723c5d1a0d80c958b705b9d7ec]

        tdf#162109 tdf#162220 sw smart justify: add unit tests
        
        Follow-up to commit 6b857398a59d16308d6185d01e003e401439f060
        "tdf#162109 sw smart justify: fix overhanging last line"
        and commit 22eac3145ca62d15b47d95f4df60ce38d4f5aa46
        "tdf#162220 sw smart justify: fix shrinking for single portion lines".
        
        Change-Id: I046bc3c5f45659442b288952ed1cd5b5cb6c16e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172689
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [e180a6657a68ad5d31e79e22c00b2fe4ace2cd2d]

        Update Inspiration Impress template
        
          - styles.xml: set draw:fit-to-size at "false" instead of "shrink-to-fit" (suggested by Regina)
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
          - remove writing mode tags
          - remove unused styles
          - set font color to grey for subtitle and outlines
          - set font colot to black for Footer/Header/Date/Page in Notes
          - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
          - remove text:span empty tags
        
        Change-Id: I7b739dc506cc4526c27c98a1496968aa289d52f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171221
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7944f998a3e2d14b29fdd1e00a9ad539324e2328]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eee5d2a36a440d54d5e793ea747239f9f782b9cf
          - tdf#162607 Remove dup's in hid2file.js, bad hid
            
            + Deleted HID_GLOBAL_FALLBACK, removed long time ago, pre-LibreOffice
            + refactor simpress/main0210.xhp
            
            Change-Id: I152d556f7ade460356de2292799d814018871210
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172655
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [13d27a60ec301874a5d0d171dcdf86f20e5f7473]

        Update Focus Impress template
        
        - replace Liberation Sans by DejaVu Sans
        - simplify definition of font names
        - remove writing mode tags
        - modify bundled styles to use same color as the template for Filled Color and Outline Color
        - move Handout elements to better places
        - move Notes elements to better places. set font color to black
        - remove used styles
        - set Title font size to 32pt to all slides, and enlarge font size for outlines
        - change draw:fit-to-size="shrink-to-fit" to draw:fit-to-size="false" to be ODF valid according to
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        - add initial author to meta.xml (according to
          https://github.com/dohliam/libreoffice-impress-templates/blob/master/lo51-templates/README.md
        - remove text:span empty tags
        
        Change-Id: Ie7e62927b2de56b5603694d58af7cd15d7d844a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171101
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [d145692f4e4e66f622f90e6a61261a28468d496a]

        Update Blueprint Plans template
        
        - remove uselless styles
        - move contributor to meta.xml
        - remove lr-tb tags
        - correct ODF validator errors: draw: fit-to-size should be set to false according to
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        - simplify inheritance of fonts
        - force footer/header/date/page font color to black for Handout view, to
          get them visible
        - add licence and initial creator in meta.xml according to last slide
        - remove last slide as it is a duplicate of 1st slide
        
        Change-Id: If27084f26306c34ba73389c5594d3e662cb551f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170704
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [a31c52d93fcfffe5bda3d8937e6a934cf76eed54]

        Update DNA Impress template
        
        - remove useless styles
        - correct ODF validator errors: draw:fit-to-size to false
        see https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        - remove lr-tb tag
        - uniformization of fonts (only Serif)
        - change German name of styles to English
        - create a group for DNA drawing
        - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo-cft
        
        Change-Id: I06c3aeb3708f011d29796098800ca6c863ac1ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170706
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Mike Kaganski  <mike.kaganski@collabora.com>  [3cf243ac31098de2d275c722a474a36b330df6e1]

        tdf#162715: do not import theme when pasting from clipboard
        
        This change makes the two code paths consistent, that are used to paste
        native ODF data into the Writer document: that uses own transferable in
        usual copy/paste procedure; and that uses "foreign" clipboard data from
        another Writer session.  The path using own transferable already didn't
        set document theme. This change passes the "IsInPaste" flag down to the
        XML reader, to let the latter code path skip the theme when reading ODT.
        
        Change-Id: I44d36e4583c58500febd647bb3def6421e585ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172688
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [688ddd1eaaa7064a0c3fc6018ca2c37a6e323f46]

        Update Blue Curve template
        
        - remove useless styles
        - remove German style Without Fill Without Line
        - remove lr-tb tag
        - change color of header/Date/Footer/Page # to black to make them
          visible on Notes and Handout
        - draw: fit-to-size should be set to false according to
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
        - simplify font definition
        
        Change-Id: I2653c62b3050100782c0fd76c553f7d414086152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170096
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Laurent Balland  <laurent.balland@mailo.fr>  [9dfb1b77e7f4191327048f24318ddeff7aae8108]

        Beehive Impress template: correct fit-to-size
        
        - draw:fit-to-size should be set to false according to
          https://bugs.documentfoundation.org/show_bug.cgi?id=103317#c18
        - add licence and initial creator in meta.xml according to
        https://github.com/dohliam/libreoffice-impress-templates/tree/master/lo5-design-candidates
        - simplify font definition
        - remove unused styles
        
        Change-Id: I651619a992958f478942f008b6fa0fcb9716c41e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171136
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-08-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [91842724235bca73690d67d8084ec7581512d791]

        Explicitly .delete() type and interface objects in uno.js
        
        These objects use smart proxies, so Embind adds them to a JS finalizer (in JS
        runtimes where FinalizationRegistry is available), so it shouldn't be necessary
        to manually .delete() them, but Embind then emits "Embind found a leaked C++
        instance..." warnings about them, which clutter the JS console.
        
        While it is probably impractical for client code to manually .delete() all such
        instances, we can at least explicitly .delete() those that occur in uno.js
        itself.
        
        Change-Id: Ia21ca5f0bdb246cc5ea272599befd9a16bc970a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172661
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-31  Mike Kaganski  <mike.kaganski@collabora.com>  [712bddcec53a8f3ef5f70d4d9e9201b186452cf6]

        Move variables into their usage scope
        
        Change-Id: I8d708ecdc94c19069d955b19daf1a5c5c4bc2f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172584
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [2bed82490cb644b7f8506858186183b761fd42ff]

        a11y: Set a11y name for "Font Size" combobox
        
        With this in place, the Orca screen reader announces the
        "Font Size" combobox in the Writer formatting toolbar as such
        with qt6 VCL plugin on Linux, instead of just
        the current value without context.
        
        Change-Id: Ifa3d8ac40bdc5e62c37483ca908b61747ea3fbce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172660
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [73acd822e2666cc9242304147bff69b90fe70f0f]

        svx: Resave fontsizebox.ui with glace 3.40
        
        Change-Id: I1b4c19db902585fc0d5d68811450cd35d69f6d7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172659
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [52ca766e81d325f8af277a5f6081bb86aea74f2e]

        a11y: Set a11y name for "Font Name" combobox
        
        With this in place, the Orca screen reader announces the
        "Font Name" combobox in the Writer formatting toolbar as such
        with qt6 VCL plugin on Linux, instead of just
        the current value without context.
        
        Change-Id: Idac70ea207a9c5e42836232d11654adf2057e5d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172658
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [f6facfa6d08d8825bbb43543790ab7925cff68e6]

        svx: Resave fontnamebox.ui with glade 3.40
        
        Change-Id: Ib439117457c92fb43f54e637de321eaeac44e1fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172657
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-31  Pranam Lashkari  <lpranam@collabora.com>  [663ad4abfc295741790daa77f733fb33b6013be9]

        sc: maintain calc function list per language
        
        problem:
        when multiple users used calc in kit in different languages,
        all the users will be shows formula autocomplete in first language
        list was created in, and later or new list creation was skipped.
        
        Change-Id: I92af9b3481825e554b6aaeb4b46e7873dadc39c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172669
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-08-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1732bf1c47d7b53cee55097620aa574ab78d85b8]

        Consistenly terminate statements with semicolons in JS code
        
        Change-Id: Ie52917f6f487f5de2d67179f67f2935a1f6c838a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172662
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [68f4eaa3135e77924f6bf76eed90ca212462d3ae]

        wina11y: Drop unused default params for AccObject ctor
        
        Change-Id: I6a92f442e6540714f8f8f652d67a213e28a1f35a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172650
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [d48f391a88e74af4732072e3e9d93248d0f72dda]

        wina11y: Drop always null param from AccObject ctor
        
        The param is never explicitly passed, so is always
        nullptr.
        
        Change-Id: I7838a9e5e990ebef18f9f622e587aa2a64070e92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172649
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [e8cc4dbd1db8ab59343f6f1c5cbd947cca3777b7]

        wina11y: Drop unused AccObject::getListener
        
        Change-Id: I95c591e2b79e59a50671967e6ab35b384d8d6c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172648
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [30e52b155cb21d0ad61acb0a857fbe52c88a6816]

        Simplify a bit
        
        Change-Id: Icaf2e821984d9cdb16dbc4910b65b9b2b824435a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172583
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce20d92a2cdc6e81a71e465a8585b512a8030b09]

        frozen: upgrade to 1.2.0
        
        * external/frozen/defines_h_constexpr_string.patch.0 is no longer
          necessary
        
        Downloaded from
        https://codeload.github.com/serge-sans-paille/frozen/tar.gz/refs/tags/1.2.0
        
        Change-Id: Ie0b8488461860b1aaad3d18d0e76a619aa876c67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-30  Hossein  <hossein@libreoffice.org>  [7c2d17141c0889dca6308606443ecb86cc8264b5]

        Fix dotnet build issues on WSL Linux build
        
        In wsl, Windows path is also added to the WSL shell path. Therefore,
        dotnet.exe from Windows is also found, if it is searched for, causing
        build issues.
        
        To avoid the build problem, and in general, to avoid using Windows
        builds from outside the WSL container, search for dotnet.exe is only
        done on Windows builds.
        
        Change-Id: I2c8c412f08008b24faf50d00dc166ad7a3c09b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172175
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-30  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [1eadf17f4bdcbc18d7b9488fd47a4bf8fb12eb58]

        Send statechange info after .uno:TableCellBackgroundColor
        
        - statechange information should be send to online after we change table background color.
        
        Change-Id: Ib16bd2469517052b5f55eac4eee938aaa3bef05a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172646
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-30  Pierre F  <fpy@bger.ch>  [4fce95ee5251f1466938b0aa69006b25886d8d8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 759025310872d7c8ad6d360e15ec4af55e7012ac
          - MsgBox not a Statement. tdf#162447
            
            originally from https://ask.libreoffice.org/t/msgbox-statement-vs-function/108929
            
            Change-Id: I62e871b878ec463e9d82a7506124a5c99de7ac28
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171415
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-30  Jonathan Clark  <jonathan@libreoffice.org>  [937023bca427f803a9e7085d5090d5d2b17623ed]

        tdf#151748 editeng: Improve kashida position validation
        
        Previously, editeng did not validate whether kashida insertion positions
        had enough room for at least a single kashida glyph. This caused kashida
        glyphs to overlap other characters in some situations.
        
        Editeng will now drop candidate kashida insertion positions from the
        beginning of the line, until there is enough room to safely justify the
        remaining text. This approximates Writer's behavior.
        
        Change-Id: I804cae72503332bea8dc9e60cdfe08bd3429dc52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172641
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-08-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6475adeb03962c6c1aa1696e4b96928b9a3286ef]

        wsl: avoid another case of redirection / piping
        
        in high-parallelsim/high load case the issues with piping commands
        with wsl1 can result in an incomplete file being generated
        
        in b87da3e9402c8b56ce2a16213802224f9288de4d a similar problem when
        appending with wsl was addressed by splitting the targets, but in
        this case just separating the commands is more straightforward
        
        Change-Id: I92cc06bf489b2cb4f8ffd412a91656fb6ca48233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172482
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-08-30  Miklos Vajna  <vmiklos@collabora.com>  [32b667acd665ce9e66ec6db952e1effb7b4c1031]

        tdf#162707 DOCX export: fix lost paragraph styles with many numberings
        
        Open the bugdoc, style of the only para of the only footer is Footer,
        save as DOCX, reopen, style changes from Footer to Default.
        
        What seems to happen is that the document has too many numberings, and
        each numbering has 9 levels, so if we have a char style for each level,
        that easily runs into the MSWORD_MAX_STYLES_LIMIT limit, after which we
        silently start dropping styles during export.
        
        Fix the problem by tweaking the fix done in commit
        7376a47680b65cbdfd747a736f288e06f51f7f2d (tdf#92335 DOCX: fix
        multiplying of "ListLabel" styles, 2019-05-28): if we don't just avoid
        writing those ListLabel styles (where the real info is written as a
        non-style in numbering.xml, so no formatting is list) but we filter them
        out earlier, then MSWordStyles::BuildStylesTable() will count styles
        correctly and we'll still have space for the lost Footer style.
        
        Regression from commit f9c8d97d82a85b897520a2fe897352ee5ad879d9
        (tdf#95213 DOCX import: don't reuse list label styles, 2016-01-07).
        
        Change-Id: I7a6b0b7b5a7b3c813a844c5fd185cf2f419e1a5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172647
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-30  Oliver Specht  <oliver.specht@cib.de>  [4f5b896d004af023f210f235aeafa9abc50068d2]

        tdf#155229 Calculate row height incl. border if 'atLeast' is set
        
        Word includes the width of horizontal borders when calculating
        row height in case the row height is set as "atLeast"
        
        This is now handled via a compat flag for doc/rtf/docx formats.
        The default for ODF is unspecified,
        which (sanely) continues to treat the row size
        of "atLeast" and "fixed" as measuring the same thing.
        
        Change-Id: I37778e5cdc6e083e94a17f50bd0b75a291ededcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169611
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [47e82cfa883b41e6a43285d78b16d20238f166cf]

        no need to heap allocate the collector
        
        in its empty state it is only three words big
        
        Change-Id: I5e3984126bcc5efe8fd2cc6c717d31fb2272408f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-30  Michael Stahl  <michael.stahl@allotropia.de>  [a97e245ba11598050e1800fde9ace796d20e9df2]

        sw: layout: fix page breaks when unhiding a hidden section
        
        Commit ff7f1b59e22092d8548459e75fe912db852f056f removed the
        DelFrames()/MakeFrames() in SwSection::ImplSetHiddenFlag(), which was
        handling the page breaks previously.
        
        Add some code to SwSectionFrame::SwClientNotify() to call
        SwLayHelper::CheckInsertPage() which appears to be the important part
        called by InsertCnt_() previously.
        
        Change-Id: Id6560d8706abf92fba259a5d534d6cd5067c8e6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172609
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4bc57fbde9a4ff06c57047b2f09899bc81e44b35]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71c24af82c60bcbaf4a02bcdfa7a762bc0e3da92
          - tdf#162607 Remove dup's in hid2file.js, .uno:ZoomPlus/Minus
            
            + The .uno:ZoomPlus/Minus are global (shared)
            + Added ZoomPlus, ZoomPanning and ZoomMinus help pages
            + Deleted similar files in swriter/02/
            + Wrapped how-t-get icons in sections for import
            + refactor simpress/main0210.xhp
            
            Change-Id: Ie5d58c0d43dd2d899e4849ec11cc72fae82ca515
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172618
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [1eb49aa3a5abc81c4a23b5371a9f733689edb1b4]

        tdf#162696 qt weld: Destroy QDialog in main thread
        
        Besides the obvious cases handled in previous commit
        
            Change-Id: Ifa84a038fc56f34958cd732caeb9c436b48b3c75
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 30 10:12:21 2024 +0200
        
                tdf#162696 qt weld: Do GUI things in main thread
        
        , the destruction of `QtInstanceDialog::m_pDialog` (that
        previously implicitly happened due to it being a
        `std::unique_ptr`) also needs to happen in the main
        thread.
        
        Otherwise, it triggers this assert with a debug Qt build
        for the tdf#162696 of installing an extension via drag'n'drop
        into the start center:
        
            ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread QThread(0x7f4b14003390). Receiver 'QDialog(0x562e6ba77450)' was created in thread QThread(0x562e69709f60, name = "Qt mainThread")", file /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 551
            terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException'
        
            Fatal exception: Signal 6
            Stack:
            #0 sal::backtrace_get(unsigned int) at /home/michi/development/git/libreoffice/sal/osl/unx/backtraceapi.cxx:42
            #1 (anonymous namespace)::printStack(int) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:289
            #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:330
            #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:427
            #4 /lib/x86_64-linux-gnu/libc.so.6(+0x3f590) [0x7f4be7455590]
            #5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 (discriminator 1)
            #6 raise at ./signal/../sysdeps/posix/raise.c:27
            #7 abort at ./stdlib/abort.c:81
            #8 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xa1a3d) [0x7f4be70a1a3d]
            #9 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xb306a) [0x7f4be70b306a]
            #10 std::unexpected() in /lib/x86_64-linux-gnu/libstdc++.so.6
            #11 /home/michi/development/git/qt5/qtbase/lib/libQt6Core.so.6(+0xed562) [0x7f4bd2eed562]
            #12 QMessageLogger::fatal() const at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:901
            #13 qt_assert_x(char const*, char const*, char const*, int) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:0
            #14 QCoreApplicationPrivate::checkReceiverThread(QObject*) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:0
            #15 QApplication::notify(QObject*, QEvent*) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2583
            #16 QCoreApplication::notifyInternal2(QObject*, QEvent*) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1170
            #17 QCoreApplication::sendEvent(QObject*, QEvent*) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1614
            #18 QWidgetPrivate::setVisible(bool) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:8415
            #19 QDialogPrivate::setVisible(bool) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:832
            #20 QMessageBoxPrivate::setVisible(bool) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qmessagebox.cpp:1676
            #21 QDialog::setVisible(bool) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:750
            #22 QWidget::hide() at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:8176
            #23 QDialog::~QDialog() at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:390
            #24 QMessageBox::~QMessageBox() at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qmessagebox.cpp:879
            #25 QMessageBox::~QMessageBox() at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qmessagebox.cpp:878
            #26 std::default_delete<QDialog>::operator()(QDialog*) const at /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:94
            #27 std::unique_ptr<QDialog, std::default_delete<QDialog>>::~unique_ptr() at /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:398
            #28 QtInstanceDialog::~QtInstanceDialog() at /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtInstanceDialog.hxx:14
            #29 QtInstanceMessageDialog::~QtInstanceMessageDialog() at /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtInstanceMessageDialog.hxx:16
            #30 QtInstanceMessageDialog::~QtInstanceMessageDialog() at /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtInstanceMessageDialog.hxx:16
            #31 QtInstanceMessageDialog::~QtInstanceMessageDialog() at /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtInstanceMessageDialog.hxx:16
            #32 std::default_delete<weld::MessageDialog>::operator()(weld::MessageDialog*) const at /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:94
            #33 std::__uniq_ptr_impl<weld::MessageDialog, std::default_delete<weld::MessageDialog>>::reset(weld::MessageDialog*) at /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:206
            #34 std::unique_ptr<weld::MessageDialog, std::default_delete<weld::MessageDialog>>::reset(weld::MessageDialog*) at /usr/bin/../lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/unique_ptr.h:504
            #35 dp_gui::DialogHelper::installExtensionWarn(std::basic_string_view<char16_t, std::char_traits<char16_t>>) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_dialog2.cxx:379
            #36 dp_gui::(anonymous namespace)::ProgressCmdEnv::handle(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:477
            #37 dp_misc::interactContinuation(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, bool*, bool*) at /home/michi/development/git/libreoffice/desktop/source/deployment/misc/dp_interact.cxx:114
            #38 dp_manager::ExtensionManager::checkInstall(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:1315
            #39 dp_manager::ExtensionManager::doChecksForAddExtension(com::sun::star::uno::Reference<com::sun::star::deployment::XPackageManager> const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, com::sun::star::uno::Reference<com::sun::star::deployment::XPackage> const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:565
            #40 dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:655
            #41 non-virtual thunk to dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:0
            #42 dp_gui::ExtensionCmdQueue::Thread::_addExtension(rtl::Reference<dp_gui::(anonymous namespace)::ProgressCmdEnv> const&, rtl::OUString const&, rtl::OUString const&, bool) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:864
            #43 dp_gui::ExtensionCmdQueue::Thread::execute() at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:738
            #44 salhelper::Thread::run() at /home/michi/development/git/libreoffice/salhelper/source/thread.cxx:39
            #45 threadFunc at /home/michi/development/git/libreoffice/include/osl/thread.hxx:190
            #46 osl_thread_start_Impl(void*) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:245
            #47 start_thread at ./nptl/pthread_create.c:447
            #48 clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:80
        
        Change-Id: Idb5b20bde8c306ed14efd5467887d55fdf470202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172643
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [5e4c1638eaf16908add86fbf6d9d83204178f100]

        tdf#162696 qt weld: Do GUI things in main thread
        
        Creating or modifying native Qt UI elements needs
        to happen in the main thread.
        
        This commit takes care of the obvious cases where
        such interaction happens.
        
        Otherwise, the tdf#162696 scenario triggers asserts
        like the following with a Qt debug build:
        
            ASSERT failure in QWidget: "Widgets must be created in the GUI thread.", file /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp, line 958
            terminate called after throwing an instance of 'com::sun::star::uno::RuntimeException'
        
            Fatal exception: Signal 6
            Stack:
            #0 sal::backtrace_get(unsigned int) at /home/michi/development/git/libreoffice/sal/osl/unx/backtraceapi.cxx:42
            #1 (anonymous namespace)::printStack(int) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:289
            #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:330
            #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at /home/michi/development/git/libreoffice/sal/osl/unx/signal.cxx:427
            #4 /lib/x86_64-linux-gnu/libc.so.6(+0x3f590) [0x7fdb05455590]
            #5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44 (discriminator 1)
            #6 raise at ./signal/../sysdeps/posix/raise.c:27
            #7 abort at ./stdlib/abort.c:81
            #8 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xa1a3d) [0x7fdb050a1a3d]
            #9 /lib/x86_64-linux-gnu/libstdc++.so.6(+0xb306a) [0x7fdb050b306a]
            #10 std::unexpected() in /lib/x86_64-linux-gnu/libstdc++.so.6
            #11 /home/michi/development/git/qt5/qtbase/lib/libQt6Core.so.6(+0xed562) [0x7fdaf0eed562]
            #12 QMessageLogger::fatal() const at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:901
            #13 qt_assert_x(char const*, char const*, char const*, int) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:0
            #14 QWidgetPrivate::init(QWidget*, QFlags<Qt::WindowType>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:959
            #15 QWidget::QWidget(QWidgetPrivate&, QWidget*, QFlags<Qt::WindowType>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:878
            #16 QDialog::QDialog(QDialogPrivate&, QWidget*, QFlags<Qt::WindowType>) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qdialog.cpp:377
            #17 QMessageBox::QMessageBox(QWidget*) at /home/michi/development/git/qt5/qtbase/src/widgets/dialogs/qmessagebox.cpp:838
            #18 QtInstance::CreateMessageDialog(weld::Widget*, VclMessageType, VclButtonsType, rtl::OUString const&) at /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtInstance.cxx:825
            #19 Application::CreateMessageDialog(weld::Widget*, VclMessageType, VclButtonsType, rtl::OUString const&, vcl::ILibreOfficeKitNotifier const*) at /home/michi/development/git/libreoffice/vcl/source/window/builder.cxx:224
            #20 dp_gui::DialogHelper::installExtensionWarn(std::basic_string_view<char16_t, std::char_traits<char16_t>>) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_dialog2.cxx:371
            #21 dp_gui::(anonymous namespace)::ProgressCmdEnv::handle(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:477
            #22 dp_misc::interactContinuation(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, bool*, bool*) at /home/michi/development/git/libreoffice/desktop/source/deployment/misc/dp_interact.cxx:114
            #23 dp_manager::ExtensionManager::checkInstall(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:1315
            #24 dp_manager::ExtensionManager::doChecksForAddExtension(com::sun::star::uno::Reference<com::sun::star::deployment::XPackageManager> const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, com::sun::star::uno::Reference<com::sun::star::deployment::XPackage> const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, com::sun::star::uno::Reference<com::sun::star::deployment::XPackage>&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:565
            #25 dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:655
            #26 non-virtual thunk to dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) at /home/michi/development/git/libreoffice/desktop/source/deployment/manager/dp_extensionmanager.cxx:0
            #27 dp_gui::ExtensionCmdQueue::Thread::_addExtension(rtl::Reference<dp_gui::(anonymous namespace)::ProgressCmdEnv> const&, rtl::OUString const&, rtl::OUString const&, bool) at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:864
            #28 dp_gui::ExtensionCmdQueue::Thread::execute() at /home/michi/development/git/libreoffice/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:738
            #29 salhelper::Thread::run() at /home/michi/development/git/libreoffice/salhelper/source/thread.cxx:39
            #30 threadFunc at /home/michi/development/git/libreoffice/include/osl/thread.hxx:190
            #31 osl_thread_start_Impl(void*) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:245
            #32 start_thread at ./nptl/pthread_create.c:447
            #33 clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:80
        
        Change-Id: Ifa84a038fc56f34958cd732caeb9c436b48b3c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172642
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fb1d5274bf4669692a500005416e300d10d77270]

        cid#1606821 silence Overflowed constant
        
        Change-Id: I7766f17113f83f849289e50524aeb63503bc4c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172639
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4570a7cebdebf9ac89c0c23971f68bde2f2de608]

        cid#1606819 silence Overflowed array index write
        
        Change-Id: I349ee3b02d25b43571c66ae9dcfcaa1e7dbea8e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172638
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [89b88b168bf59df52f2320aef2a5881cec8fa4b8]

        cid#1606757 Overflowed constant
        
        Change-Id: Iefc06368d1d37c22907a72a27065fba88488db02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [90e4ea2489918f391953dd3405174ea7a1013ef8]

        cid#1606837 silence Overflowed constant
        
        Change-Id: I73b29037344056c8649214d110859bbb705e628e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172636
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [14d846655766e4bf4498482b2c7710170b052f94]

        cid#1607087 Overflowed constant
        
        Change-Id: I0d1e943d08cdcded264c44e0cf7a55385a0e2523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [afe3a9313fb35179231f14aa0ba5c9f357e09fa0]

        cid#1607168 Overflowed constant
        
        Change-Id: I18856301045008938d5222ceb6774ff6fbb557fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172634
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [91b1f91ca7d41a79647a0bca40fed276ec51c859]

        cid#1607414 silence Overflowed constant
        
        Change-Id: Ie52e2acd26494229ee6b0874c91e240eab9f8c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d98bd5695e87019caebd02929231f3b0c6e9f35]

        cid#1608060 silence Overflowed constant
        
        Change-Id: Ica2563ab6dc6d00f694965cd2353c29ea4e3fe8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172632
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9d2326fe5264a079dde623d99c20195a029fbbe]

        cid#1618704 Dereference after null check
        
        and
        
        cid#1618705 Dereference after null check
        cid#1618707 Dereference after null check
        
        Change-Id: I942a9d67d127fa965730a5c38ea8e71397397e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bf878dd7c8aabd975f7ba99daba3fa9e959d1d2c]

        cid#1618703 Dereference null return value
        
        Change-Id: I9c0dc25565e8c11d3c0b4328a493d5fc746184e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [045e38a1b50050b5df632723da109234bb7031ab]

        cid#1618706 Overflowed constant
        
        Change-Id: If9d327c3ca9ea300421adc78e603a85206095add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172629
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-30  Michael Stahl  <michael.stahl@allotropia.de>  [29b5a4f5777e089fe940ba6120f9d6af0f91dd2f]

        sw: downgrade SAL_WARN on every mouseover to SAL_INFO
        
        Change-Id: I5e6f965e0cc47f9a4e5776f452ef216ee19c9f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172608
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-30  Jean-Pierre Ledure  <jp@ledure.be>  [f2f7dbb78c54bbb23be87c991f8375bf494373c8]

        scriptforge.py Improve properties performance
        
        When considering next python user script:
           a = CreateScriptService(...)
           a.prop = ...
           print(a.prop)
           print(a.prop)
        so far, the evaluation of a.prop was done
        either once or twice depending on
        - a parameter of the class a is an instance of
        - the read-only status of prop (True/False)
        
        Now the recomputation of the expression
        depends on a parameter of prop which can take
        one of next values:
          0: prop is read-only and not re-evaluated
          1: prop is read-only but re-evaluated
             f.i. because a user action can change its value
          2: prop is editable and not re-evaluated
             f.i. because it can be changed only by code
          3: prop is editable and always re-evaluated
        
        The change will decrease the number of useless
        and more costly recomputations of properties.
        
        Change-Id: I11412a58772147dab2e6b9b06c31477135932603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172600
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-08-30  Miklos Vajna  <vmiklos@collabora.com>  [d04844f42022f0675f188f8f21881779d0afbbc6]

        sw doc model xml dump: show start node of footers
        
        Without this, it's hard to see which footer node section belongs to the
        footer of which page desc.
        
        Change-Id: I6fb4158684f6f6ae38293df4e7d982c5d8fddf72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172625
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-30  Sahil Gautam  <sahil@libreoffice.org>  [083651ef9c6492359380248c958908d9aa490e89]

        Use the correct color for Formula Bar in calc.
        
        Mainly affects QT based VCL_PLUGINS. before https://gerrit.libreoffice.org/c/core/+/171916/14
        patch, WindowColor actually the Base color from QPalette. Changing it to
        the actual window color, the calc's formula bar became indistinguishable. from
        the window So this patch sets the Formula Bar's color to FieldColor, which is same as
        the BaseColor from the QPalette.
        
        This also makes the color used on macOS consistent with Edit and VclMultiLineEdit.
        
        Change-Id: I94dcfc67de942314b67126e984b40bb5073e1bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172617
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [1ecde0f5d1384946c3e684846e681121b3001219]

        Simplify default ImpScan usage
        
        Drop LibreOffice6FloatingPointMode, and move the check introcuced in
        commit 47aabde053a1472dc32770da29d68c8de5bd7919 (Make the tdf#97983
        changes to BASIC optional) into a simplified ImpScan overload.
        
        Change-Id: Ibef723878179113a5403d2a3c55ded9df9cb292d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172595
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-30  Jim Raykowski  <raykowj@gmail.com>  [41ad19c719decfdce1f26359277db6bb00002836]

        Resolves: tdf#146800 Linked libraries don't show shource path in Macro
        
        Organizer for VCL plugins that use SalInstanceTreeView
        
        Change-Id: Ide1ea8a14e956836573e8a3aacd2b289d76616ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172560
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-08-30  Eike Rathke  <erack@redhat.com>  [044980edc41544dd5973d5aa57f134d4bfe6d0e7]

        Resolves: tdf#161599 Write Add-In CompatibilityName (if any) to OOXML
        
        First "en-US" (preferred) or "en" or any first if no "en-US" nor "en".
        
        Change-Id: Ifdb60547b588f224ee9ddca39af2352a87385bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172604
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-08-30  László Németh  <nemeth@numbertext.org>  [22eac3145ca62d15b47d95f4df60ce38d4f5aa46]

        tdf#162220 sw smart justify: fix shrinking for single portion lines
        
        Follow-up to commit 6b857398a59d16308d6185d01e003e401439f060
        "tdf#162109 sw smart justify: fix overhanging last line".
        
        Regression from commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I6e2dbdbf3628bdae765c235d5f29c1aa0b8987ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172599
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-08-29  Laurent Balland  <laurent.balland@mailo.fr>  [21c9751b56e3bd238369414cbf25c08fdda9f6c3]

        tdf#108034 Resume Writer template
        
        Replace sections with tables to fix export bug to MS Word format
        
        Change-Id: I5527bf9181cecb23ce756daa67f9284d3f6c58ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171849
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9626fe5447e0ce71e0d13a5cea5c323c77113304]

        cid#1607370 Check of thread-shared field evades lock acquisition
        
        apparently since:
        
        commit 8228227168a7eb3ebf14629bec87f01536c23970
        CommitDate: Thu Dec 8 17:27:05 2016 +0000
        
            convert OSL_ENSURE to assert in AccessibleEventNotifier
        
        Change-Id: If4ad0459e39e44a9417dd074560538f2a87586b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172615
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [42546d4a0a6f73bf2408108a767be91030cc17f6]

        cid#1607212 Check of thread-shared field evades lock acquisition
        
        it changed to this at:
        
        commit 0c876d497dd3320cbc06cf21b7b14ab859755bac
            AccessibleEventNotifier AccessibleSlideSorterObject (sd)
        
        Change-Id: I8b272b8466a05f817eb9cad5673920b54b599a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-29  Eike Rathke  <erack@redhat.com>  [59d2745d4ab0bb44d474bab56d3f06a8e1dfb788]

        Related: tdf#161599 Accept Add-In CompatibilityName when reading OOXML
        
        Must be first "en-US" (preferred) or "en" or any first if no "en-US" nor "en".
        
        Change-Id: I1549d6650b19fbb37952bd093692bbbcba1420c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172603
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-08-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [265914ee3e99e70a9b1f5a9a80f3574fc9af5392]

        freetype: upgrade to 2.13.3
        
        Downloaded from
        https://sourceforge.net/projects/freetype/files/freetype2/2.13.3/freetype-2.13.3.tar.xz/download
        
        Change-Id: Id38ce5fe5c04d515f4e8298326336cfb60f7ed36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172607
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [3eac847927a0cdfa40c3fea38c473ed2ad7faecc]

        tdf#161826 - Add uniform Glow effect for texts in shapes
        
        - Add new text Glow effect properties for shapes
        
        - Using TextGlowPrimitive for rendering uniform text glow in shapes
        
        - Add/allow new UI Glow Effect for texts in shapes on sidebar
          (Only for Impress/Draw and Calc)
        
        - Import/Export ooxml files with Glow effect on texts in shapes
          (Only PPTX/XLSX)
        
        - Import/Export odf files with Glow effect on texts in shapes
        
        - Add unit test for glow text attributes in ODF
        
        - Add uni tests for OOXML import/export
        
        Note: Also this patch effects on
        tdf#144061 - Effects: Allow GLOW to apply to Text (as we have for shapes)
        
        Change-Id: I16586c01654f197f532129e4e06aa2ef9f214395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172216
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-08-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [786aed3a35a50c0e147e15d29c88987aaf523775]

        culmus: upgrade to 0.140
        
        Downloaded from
        https://sourceforge.net/projects/culmus/files/culmus/0.140/culmus-0.140.tar.gz/download
        
        Change-Id: I6ab2f1d59fad7e0da0dfc5754740c7e3fda12438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172605
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-29  Eike Rathke  <erack@redhat.com>  [6159c597b5e20db2cee919b116bb7a0b663ca9d7]

        Related: tdf#161599 Do not skip first of fallbacks of CompatibilityName locale
        
        It's actually needed if the locale to check is already a fallback.
        
        Change-Id: If6ab24209f88a1cb372e04bd29e0eb2ad9fdb243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172601
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-08-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [c4c5b3b96a500dce1a7827043dd6c72e728b6476]

        mariadb-connector-c: upgrade to 3.3.11
        
        Downloaded from https://mariadb.org/download/?t=connector&p=connector-c&r=3.3.10&os=source&pkg=tar_gz
        
        Change-Id: I44dca1da8e7ba142f6cb14b7f7a2c4cd6b9c6dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172598
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-29  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [7241460e15af2e8aa3ba299aea27fbfeb0d147f7]

        Fix insert comment not working after document load.
        
            - In document with comments present insert comment not working document after load.
            - remove this condition for insertposIT to work for onload
            - this patch wil fix this issue
        
        Change-Id: I6128053b23678e61548d04979e3b199678a6b708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172587
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-29  Pierre F  <fpy@bger.ch>  [484cfb8c2496d9fb09af822a128f333a0f2c2d06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 31c843427f47cf1746687d5554a822f24346ae41
          - tdf#128595 (comment 11) extra spaces with copy/paste in Writer
            
            Change-Id: I6a95b7f0d7fa4fbabbbe34e79e9361223fbbda3b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172496
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-29  Dr. David Alan Gilbert  <dave@treblig.org>  [b416c5b8e32632a63e1e791c34896e17d89f7982]

        tdf#101611, tdf#108813, tdf#86211, sdext,pdfimport: Clip fills
        
        The pdf processor carefully records clip paths, but does very little
        with them.  It's currently just used in the recently added
        tiling pattern fill.
        
        Make the existing solid fills use the clip path.
        
        This resolves 101611, 108813, and helps some
        side issues in tdf#155170 In particular, the fish bowl on p.15
        now looks about correct, but the fishes are still very, erm, square.
        
        (I think there may be a longer term task to rework the clipping
        completely)
        
        Change-Id: Ie48901dbc6070465bac4fdb47b0bbc65a35c5792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172448
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db92117fae3034dea59c8e589d93756406678427]

        Resolves: tdf#160675 reformat 'blanked' metricspinbutton after setting value
        
        click on background, set_text sets a blank for the content of the metric
        spin button, so explicitly reformat when a value is set afterwards.
        
        Change-Id: Idac3f805bcf1baad1cdeaa3caa1c48a976f2f738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172591
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-29  Eike Rathke  <erack@redhat.com>  [5755b5515b8e97b638f2fb1f7553130760f12e94]

        Related: tdf#161599 pre-initialize ScCompiler ODFF and OOXML final OpCodeMap
        
        ... to avoid temporary maps through base class
        formula::FormulaCompiler::GetOpCodeMap().
        
        Change-Id: I372355b57326eab00d4ccde651df4d0fe69166c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172588
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-08-29  Michael Weghorn  <m.weghorn@posteo.de>  [214a7d7399ffedea6b5eb4214e3b00c184a801ab]

        wina11y: Update comment now that IAccessible2 PR was merged
        
        IAccessible2 PR [1] was merged now as upstream commit [2]
        
            commit 2b8c2c79417bad4b464761a142fab45ffde8bfa8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Aug 29 07:55:56 2024 +0200
        
                Add an "id" object attribute. (#31)
        
        , so is part of the official IAccessible2 object
        attribute specification now.
        
        [1] https://github.com/LinuxA11y/IAccessible2/pull/31
        [2] https://github.com/LinuxA11y/IAccessible2/commit/2b8c2c79417bad4b464761a142fab45ffde8bfa8
        
        Change-Id: Ia613a673b832d35bcc6e3801325dc9f55b393a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172585
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-29  Miklos Vajna  <vmiklos@collabora.com>  [710fa4e68cc134d9970a6d0c034a84c3419be14a]

        sw: call HasFullPageFly() later in SwTextFrame::FormatAdjust()
        
        Suggested at
        <https://gerrit.libreoffice.org/c/core/+/172562/2#message-01333d4017922b8d2c834519ea7d94517110112a>,
        the other conditions are trivial to check, so best if we do the
        expensive condition only at the end.
        
        Change-Id: I54e4914095e2e06cf162e340754ba7859f0903d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172586
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-29  Andras Timar  <andras.timar@collabora.com>  [71f2a391237c1c770c6372a8d0e888b53f1d6777]

        Fix Repository.mk after 'add --with-docrepair-fonts option' (tdf#161941)
        
        Change-Id: Ic74620e61db5cb8f0988c9477314544394e80368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172503
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-29  Jonathan Clark  <jonathan@libreoffice.org>  [4de9d58daefef6da0b64c3db0637f9f9d314dd09]

        tdf#152142 sw: fix RTL as-char anchored textbox positioning
        
        Fixes an issue causing incorrect textbox positions when the containing
        shape is anchored 'as character' inside RTL text.
        
        Change-Id: I4a68348b778adbdb893a62a29a1fb31ffbcf55e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172529
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1aed9e3dae4b17e677a2af9e9f76a67d7c57dec0]

        If there editeng backcolor is unknown, assume bg is the doccolor
        
        Change-Id: I65b2cd329db2c5868e6e84592303fd277ed63d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172534
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172564
        Tested-by: Jenkins

2024-08-29  Pranam Lashkari  <lpranam@collabora.com>  [a37c185bbc598d57385ab461c0a85c1b1b78c325]

        LOK: avoid dark auto color font on dark background
        
        Change-Id: I259d1af222af33c0226a3d11c7b146a8a5fd72f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172527
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172563
        Tested-by: Jenkins

2024-08-29  Adam Seskunas  <adamseskunas@gmail.com>  [c60fdc26f1ade0c6a1f8404baf749f5dab6abd84]

        tdf#120629 Add Unit test
        
        Change-Id: I2f5ee20bfe16c8da414504a717a6fdcfbaf6eeca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172558
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2c8610f51ef704187ee88226d631ecdf2dd85272]

        Fix typo
        
        Change-Id: I67f1349aeac4d73c69a2fe3dd68658f1ae1f1030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172551
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-29  Pierre F  <fpy@bger.ch>  [b6a3a843c1ee20e2befbb91928e9bea3c1d31cbb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76b3d288ebdcd58824245aaf9fb3cce1a475bc35
          - tdf#127338 Calc split and freeze cannot be used at the same time
            
            Change-Id: I8d97fbed6cef5aa8b45cae12de1cbbd46921f875
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172497
            Reviewed-by: Pierre F <fpy@bger.ch>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7b596f4632326e1e07c44ec42ba3d6b24a4be6c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8914196b95890d066eac338c9d1243c89edea43f
          - tdf#162607 Remove dup's in hid2file.js, .uno:ZoomOut
            
            + The .uno:ZoomOut is a Math command
            + Added min zoom factor for other modules.
            + refactor here and there
            
            Change-Id: I475cab22f08f0e30305ef938156ee71ef446ef43
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172557
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ba737991e20df89c5ffee36f3ce0c8a2170c5529]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b6f313e24d791be85d9c62dea03905f86e2df35
          - tdf#162607 Remove dup's in hid2file.js, .uno:ZoomIn
            
            + The .uno:ZoomIn is a Math command
            + Added max zoom factor for other modules.
            + refactor here and there
            
            Change-Id: Ib4c67e6b70a519f8778a1408eefa53aaa15d0821
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172556
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-29  Noel Grandin  <noelgrandin@gmail.com>  [1f5a6dd3590432f3582bd62f6c896e0c6200113c]

        flatten ooxml::Value hierarchy
        
        into a std::variant. Since it is always one of a very small set of subclasses.
        Which means we can pass it around by value and avoid allocating
        it on the heap, which reduces parsing time.
        
        Change-Id: Ic83b48cb3fdec17779a2ad59abbc585156f5ffa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172451
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-29  Jean-Pierre Ledure  <jp@ledure.be>  [2f9a4a80c04b2ef0586bf017ddf044e8c965bd19]

        ScriptForge (SF_Utils._Valudate) Improve robustness
        
        All arguments passed to ScriptForge methods
        are checked for validity.
        
        A.o. a string may be compared with a closed
        list of allowed values.
        The comparison may now optionally be made
        with a
           CaseSentitive As Boolean
        parameter.
        
        All occurrences where this check makes sense
        were identified, inventoried and modified.
        A True argument has been inserted where
        appropriate.
        
        Change-Id: I1a5cb7fb42618bc83fc8ec57c2727fc2a1bfcdb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172530
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-29  Michael Weghorn  <m.weghorn@posteo.de>  [21b29f25660db973fa1480de77e6a69d76a5de53]

        tdf#155447 wina11y: Report accessible ID as "id" obj attribute
        
        Report the accessible ID as an "id" object attribute.
        Firefox also already uses that object attribute.
        
        Pending PR suggesting to add the "id" attribute to the
        official IAccessible2 object attribute specification: [1]
        
        Sample use in NVDA's Python console, with the caret/focus
        in the Spelling dialog's "Not in Dictionary" edit:
        
            >>> focus.parent.IAccessibleObject.attributes
            'id:sentence;'
        
        [1] https://github.com/LinuxA11y/IAccessible2/pull/31
        
        Change-Id: I42250c3f46afbb2ab64c884d8bf5f2bf7d2a5ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172538
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-29  Michael Weghorn  <m.weghorn@posteo.de>  [a38d969d5b113aa6e10fc128d6607fbb438035ac]

        a11y: Set "Paragraph style" as a11y name for that combobox
        
        Set an accessible name of "Paragraph" style for
        the combobox where the paragraph style can be set.
        
        The one used in Writer's formatting toolbar didn't
        have any a11y name set, resulting e.g. in the Orca
        screen reader not announcing what this combobox is
        for with either the gtk3 or qt6 VCL plugin.
        
        The one used in Writer's "Properties" sidebar
        was using an accessible name of "Font style", which
        is less precise than "Paragraph style", so use the
        latter consistently.
        
        Change-Id: I357e11347118dbf0db39084ae58c2d188d8aa235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172542
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-29  Michael Weghorn  <m.weghorn@posteo.de>  [3624c588328179204448e66118f2363ba2a92b93]

        svx: Resave applystylebox.ui with glade 3.40
        
        ... before doing any "actual changes".
        
        Change-Id: I3af9f5a94affb252724b922e5ab37ae18821baa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172541
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0e3eae5de89027e8e4c03391ebeec1fb9729fa1b]

        tdf#157198 auto correct done on EndExtTextInput not seen until next update
        
        Change-Id: I57f6c08e97f1f53411fd9e1e83c7faa0ae5788d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172553
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ba2c87354d97448fc2b6f5ca0eea6ce0eeefb8a]

        Resolves: tdf#162651 area under removed editview needs to be refreshed
        
        which has become a problem since:
        
        commit 6d71c21890c908225945f0fc3566255ed150f660
        CommitDate: Mon Jan 22 20:47:16 2024 +0100
        
            don't always invalidate the entire width of the calc window
        
        Change-Id: Ic0db4932091806c79fd9e773d7be35727560a1ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172552
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [635514553abdd830951d3ba91651c9f0b208360b]

        Resolves: tdf#162659 toggle buttons have no "weight" property
        
        so those extra columns don't make sense, they make sense if those
        were text entries.
        
        and add sensitive as a property we expect to see in tree/list-stores if
        sensitivity or later properties are used.
        
        Checking all the existing cases shows the only other cases like this are
        where we've just used the -1 'col' arg to set all columns to the desired
        sensitivity and previously shared a single sensitive property between
        checkboxes and the main 'text' case.
        
        Change-Id: I0b22fb93b935a06bfcda6f6a3169df0e24d8b9e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172546
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84d5908189aa258c7d30485e5f40dcd25109257e]

        this sensitivity mapping isn't used
        
        Change-Id: Ib5591e00e1bed62edbf30c6cc9106bcabe5f6ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172544
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-29  Moritz Duge  <moritz.duge@allotropia.de>  [c888329adf68d8459d19784779cb6b5eea4f9195]

        use emrun with explicit "--hostname 127.0.0.1" for testing
        
        Minor security improvement. See
        https://github.com/emscripten-core/emscripten/issues/22077
        
        Change-Id: I05d632f6023883672d0e1b2586f53df87dd7d874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172540
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>

2024-08-29  Pranam Lashkari  <lpranam@collabora.com>  [0427231a1485d324519e94246ff702bc0cb18b89]

        sc: LOK: automatic text color was based on doc color instead background
        
        problem:
        when document was in light mode but cell had black background,
        automatic font color was black based on the doc color but ideally
        it should have been while based on the background color
        
        partially reverts 8534ad7b7b9aae2520d731cf748ff0aadfe2f0ed for online
        
        Change-Id: I155cc6044dd97e642619b88f24b82fb98a7b393f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172483
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 2ca381b31e40d516c5d79ce4e59cecbf9683b616)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172495
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-08-29  Patrick Luby  <guibmacdev@gmail.com>  [33863317e216b1ecd843f5eb584e99998a76305f]

        tdf#162646 set extra drawing constraints when scaling
        
        Previously, setting stroke width and cap was only done when running
        unit tests. But the same drawing constraints are necessary when
        running with a Retina display on macOS and antialiasing is disabled.
        
        Change-Id: I816e8aed1ca62f01f2145af741ae5540379cd34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172559
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-08-28  Pranam Lashkari  <lpranam@collabora.com>  [c52f139b4f7140033144dde29f70a39ebedb6aa0]

        svx: fixed textbox text always black on dark theme
        
        problem:
        when doc is in dark mode and a textbox is inserted,
        even though text has automatic color it will be black on unselecting textbox
        
        Change-Id: I8736c15a1254682f06218a1eb1039b1985eda552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170537
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 41b277224310b63a181d65a279e1d77950db9309)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172494
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-08-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [54385e8952e89fd00feb0e8c3e623c522bc6eb09]

        `ImplGetSVData()->mpDefInst` is `this` here
        
        Change-Id: I8f9e00b4b3cefca62d214ee37fd4b6d0634db50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172539
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [858fed2a98ad5a04ca65dc504722e2db52746e64]

        Emscripten: Support --disable-gui
        
        Change-Id: Iab28ee0bb533b0cdabb374c982fbb898bf04aac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172537
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-28  Eike Rathke  <erack@redhat.com>  [599b1711eab1adf05aab7ac9b977cff3bc4f1878]

        Remove superfluous unused temporary ScCompiler instances
        
        Obsolete already since
        
            commit f304a7a14a4af4d3f46eab18d5494194028e61ef
            CommitDate: Tue May 5 09:30:39 2015 +0200
        
                loplugin:staticmethods
        
        Change-Id: Ibd84962b2e0394b9eba4829c13ab06b4a690b15b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172545
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-08-28  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [e68715944f26cf3171dde12c4a2dfef64f0e684a]

        CairoSDPR: Use integer & shifting in LuminanceToAlpha conversion
        
        Change-Id: I8a6b6341295487d7590d166d327ea90b7d1315db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172480
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ba0ea7c7fbbca6ebe6ef339d0304e66852895fd4]

        Refactor impl_packLocalizedProperties
        
        Make it more C++ish.
        The change made two functional modifications:
        
        1. It now doesn't filter out non-string values of the localized
        properties. Since commit a5649055a0ec54ded05a879d018903628bfe2f0b
        (INTEGRATION: CWS xmlfilter01 (1.38.18); FILE MERGED, 2003-04-04),
        'OUString sLocaleValue' intermediate local variable was used for
        values taken from XNameAccess::getByName before storing it to the
        Sequence<PropertyValue>. It contradicts the documentation of the
        impl_packLocalizedProperties function, created in commit
        4bbc40bf5c29606c44934b18ed5962db8a0bc5d1 (#84766# new mode for
        locale=*, 2001-04-11), which explicitly tells that the value type
        "depends from cfg entry". The commit message of the later commit
        is not clear, mentioning some "repair ALLO_LOCALE mode"; but it
        likely refers to the change of CONFIG_MODE_ALL_LOCALES check that
        was made bitwise, instead of direct ==. I think that sLocaleValue
        was used during debugging, to check the value, similar to another
        debug variable - sLocaleName - also introduced in that commit; it
        was simply erroneously kept in the final patch.
        
        2. When lOutValues has an XInterface, but not XNameContainer, it
        now is copied to the out sequence (it was dropped before). Likely
        it won't really happen in practice, but the limitation reason was
        unclear.
        
        The use of a sequence declared out of the loop, and realloc'd in
        the loop, is in fact pessimization, because such a realloc would
        need to copy the existing values, only to discard them later.
        
        Change-Id: I726c7dbeae58cbf92b53233ae4eeb3cd070375ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172507
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-28  Mike Kaganski  <mike.kaganski@collabora.com>  [b54f188b38b2fdb7e3224e5826162d7186c23288]

        Drop newly unused ToggleUnicodeCodepoint::CharsToDelete
        
        Change-Id: I25654d911b1cc11f8c0e7d0ef3e87898418c3408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172535
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ac0117713e6ce248c7725b57d709390f27dc4e62]

        tdf#162657: re-check the result of combining surrogates
        
        They may constitute a combining mark, and require more characters
        to the left to be processed.
        
        Change-Id: Ie626badf66edaf44c56e0ba2d294304f139d2bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172533
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-28  Mike Kaganski  <mike.kaganski@collabora.com>  [5f1579c6fe56960f529e96f629d9a37352752345]

        tdf#162656: make sure to replace correct range
        
        ToggleUnicodeCodepoint::CharsToDelete returns number of codepoints,
        while SwWrtShell::DelLeft operates glyphs, which may consist of a
        number of combining codepoints.
        
        Change-Id: I394ee76c576f2e6f921cb30d125cce2f83559608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172532
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [df6293ad0634a29ff4d0196d1f9230062ccc95ca]

        tdf#161983 Page background image follows scrolled view
        
        regression from
            commit 2a9b53bb9f85c2869c779dde36a2d77353fef14b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 27 10:18:15 2024 +0200
            tdf#160345 Slow rendering of filled polygon
        
        Change-Id: I38abd82d33cc25a56a26d8ccac26fb5f90e9c0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [741909fea54b49de295af6685efa69b8444dc382]

        crashtesting in abiword doc
        
        regression from
            commit 60aeca980bbe6cd35d9ce530ea8704bc4ade7b7b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Aug 14 09:32:51 2024 +0200
            tdf#158556 bypass some more logic for toggle properties
        
        re-introduce some of the logic I elided
        
        Change-Id: If20ca9eb0134d743ca62335fb4eae400e8c8221a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b076e6a0b92ee989d31a8525cfab4636737b30dc]

        tdf#158556 avoid a ton of temporary OUString
        
        Change-Id: I5256210d73eb54d4e6ea98b68c1e9eabf8770ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172525
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-28  Michael Meeks  <michael.meeks@collabora.com>  [47fbbd7c6b9ea6b4a20f05fdf8870cb9e125fb21]

        lok: elide various unhelpful events during background save.
        
        In particular TEXT_SELECTION and TABLE_SELECTED seem to be favorites,
        but nothing good would come of getting these others either.
        
        Change-Id: I1f014824452bffaeddb1dfaf6565542c3c7c9e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166158
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 95f1f2143ae53469417fcebc9b2020c34b53ff30)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172522
        Tested-by: Jenkins

2024-08-28  Michael Meeks  <michael.meeks@collabora.com>  [4149b79c0a04e80610a34087a8b874494e7075e3]

        lok: avoid sending jsdialog messages during background save.
        
        This creates lots of enable/disable traffic that is no longer
        needed, and may trigger a fallback to non-background-save.
        
        Change-Id: I3dd789d13b6c28540422d99128014c9c17e00d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166157
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e005690e9c648ce516c1ed60da6341c7215bf2c9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172521
        Tested-by: Jenkins

2024-08-28  Michael Meeks  <michael.meeks@collabora.com>  [df27f612240b32242799f3cd57607ce36eaf3162]

        lok: add method to allow explicit cleanup of temporary files.o
        
        Special case fast destruction of background saving children.
        
        Change-Id: I8fba4d0818d23a8b0e1bb4d074e1afae7dacde33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165448
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 7d784910689172014b8cf6144e654402696d8801)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172520

2024-08-28  Miklos Vajna  <vmiklos@collabora.com>  [e7e89eaf687310a31762ef5d325c22d7cc259a0b]

        sw: fix uninitialized read in SwContentTree::IsDeletable()
        
        Seen while running online.git unit-perf with asan:
        
        > sw/source/uibase/utlui/content.cxx:6203:17: runtime error: load of value 48, which is not a valid value for type 'bool'
        
        And indeed SwDoc::HasTableAnyProtection() may leave this out parameter
        uninitialized.
        
        Change-Id: Iaaf08469580510b1dbcbad999c141884a8d8a4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172528
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-28  Patrick Luby  <guibmacdev@gmail.com>  [d3dd080524d98bcf0560d3b54ad2309610b22c20]

        tdf#127610 subtract width of shortcuts from width available for tab items
        
        Change-Id: Ia520f6b982e52e7154b3b02ba77562a3b212efd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172301
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [12ce43bda25015dc3e681312b64680a996f5a8dd]

        tdf#162589: Revert "nss: 3.101.2 is the ESR release"
        
        This reverts commit 4a5b52f8bcb7b5d4eb2fc4ba6560ba1e88c36503.
        
        It seems going from nss-3.102.1-with-nspr-4.35.tar.gz
        to nss-3.101.2-with-nspr-4.35.tar.gz breaks the installation.
        See https://bugs.documentfoundation.org/show_bug.cgi?id=162589#c11
        and https://bugs.documentfoundation.org/show_bug.cgi?id=162589#c13
        However, going from nss-3.99-with-nspr-4.35.tar.gz to
        nss-3.101.2-with-nspr-4.35.tar.gz doesn't break it, See
        https://bugs.documentfoundation.org/show_bug.cgi?id=162589#c12
        
        Change-Id: Idc2e118c7efe5ba570e68f998460bc05ac74a714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172493
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-28  Miklos Vajna  <vmiklos@collabora.com>  [5bd78c7dc4d17378c31207e6640e4d141d2ef5c3]

        tdf#162662 sw: fix layout loop with full-page anchored shape that wants to wrap
        
        The bugdoc has a full-page group shape on page 2, with wrap type set to
        "above and below", which is Writer's "no wrap" type. Open this document
        in Writer, the layout loops before showing the first page.
        
        What seems to happen is that SwTextFrame::FormatAdjust() splits the
        anchor of the group shape at position 0, splits, then
        SwFlowFrame::MoveFwd() moves it to the next page. Now page 2 is empty,
        so later SwFlowFrame::MoveBwd() moves the content back from page 3 ->
        loop.
        
        Fix the problem by checking for this "we would split at para start due
        to full-page shape" case and in case wrapping is requested, but at the
        same time to size is so large that it can't be provided, then don't try
        to split as we'll join later anyway, so it's pointless.
        
        This matches Word behavior, which also doesn't try to move the body text
        of page 2 to a 3rd page in this conflicting case. An alternative would
        be to not tweak the "should we split" logic, but instead change the
        layout to assume "wrap through" instead of "no wrap" in this case.
        Fixing this in SwTextFrame::FormatAdjust() has the advantage that the
        i#84870 problem (similar, but for as-char images) was also fixed here,
        so this looks more consistent.
        
        Change-Id: Icfb58183c89a32b5f97c901d17cfae0fcc4e711f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172523
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-28  Michael Meeks  <michael.meeks@collabora.com>  [4a5ab80057ca832693a4cf49e653dbbd985ebaaf]

        lok: avoid perturbing parent background save process' temp file.
        
        The temporary file that typically contains the content of thes
        currently open document is re-written, and deleted on save. Avoid
        deleting the original when we are background save worker.
        
        Change-Id: Ibbb3a963cb3420088623994c067115ff77b96f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165408
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 53316a6b8228885a17bf53c4fae6fe9d8ef80d2d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172519
        Tested-by: Jenkins

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf9ff60833fbae0e7101dc7ee470b4c506018957]

        cid#1556212 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555768 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I587f47cefc30eeb53dc7a42d865f242d6986d615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172518
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46eb93f107df4b6d2ce1ad67dbfe386a5f12bd00]

        cid#1608204 silence Overflowed integer argument
        
        Change-Id: I088af4b396a1114f00e47aa44439be9d838e2433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a2634d526e80236bfc0f925192f4a7201835f74f]

        cid#1616925 Unintended sign extension
        
        Change-Id: Ifdcd817fe8b10a8eee6a8fabf767fdc1b311f800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172516
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [783f943ebaf84731767a176012f4329dc3ae39d5]

        cid#1555526 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555615 COPY_INSTEAD_OF_MOVE
        cid#1555637 COPY_INSTEAD_OF_MOVE
        cid#1555640 COPY_INSTEAD_OF_MOVE
        cid#1555768 COPY_INSTEAD_OF_MOVE
        cid#1555840 COPY_INSTEAD_OF_MOVE
        cid#1556731 COPY_INSTEAD_OF_MOVE
        cid#1556751 COPY_INSTEAD_OF_MOVE
        cid#1556807 COPY_INSTEAD_OF_MOVE
        cid#1558026 COPY_INSTEAD_OF_MOVE
        cid#1558032 COPY_INSTEAD_OF_MOVE
        
        just silence these
        
        Change-Id: I8a120bb0badc8d2987c41768ec116a78324e9821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172515
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4f12805f6e2d5bf68278dd6ab95b8111f36d07eb]

        cid#1606710 Overflowed constant
        
        Change-Id: Iaf8b6f7ccd5c8dc39901fee4e386c6e0b9c6d4e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172514
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fd78b325894bf7dc8c300949dcd822a97c2c8f1c]

        cid#1606736 silence Overflowed constant
        
        Change-Id: Iedad6ed6e21c6ead9bb923bcb319122a834763f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172513
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25552416c07a0841c32d71663cf2df75cbd174ea]

        cid#1606904 silence Overflowed constant
        
        and
        
        cid#1606871 silence Overflowed constant
        
        Change-Id: Ibfa7b63bf6879b24dc28df9d889c6692ec5a4e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172512
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [17181dfd0ff3abed78f00b5812e9652a8344bab9]

        cid#1606906 Overflowed constant
        
        Change-Id: I8ac1aabb50c5ef061b8ac359cb9d7ce8fe66c62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172511
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2e937d93f0646480d92101115e5b4a4f41f2acc]

        cid#1606927 silence Overflowed constant
        
        Change-Id: I4c111bbdbf9d600a1d75a071010164b56d0ed06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172510
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10464b74097f114bb73e6e4aaece7aebc43ed680]

        cid#1607037 silence Overflowed constant
        
        and
        
        cid#1606925 Overflowed constant
        cid#1606695 Overflowed constant
        
        Change-Id: I2162e9b5da1f31ea1dfc603d6e60b96d98f82be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172509
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6e5ff9c5966b70becb4121c600859a580af1b7dc]

        cid#1618664 Self assignment
        
        used to be:
            Sequence<sal_Int8> aFileName;
            aGrabber.readBytes(aFileName, aEntry.nPathLen);
            aEntry.nPathLen = aFileName.getLength();
        so aEntry.nPathLen ended up as the the count of read bytes actually
        read when aEntry.nPathLen was requested
        
        Change-Id: I50b2c4c7be086e4b846998ee52fbabed6159279d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172508
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9520ff2c4d08123490496a914f2d4c1a2039d258]

        cid#1618667 Uninitialized pointer field
        
        Change-Id: Iaf23214c6931d068b37dbb04cfc73ae7f9a3d7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172506
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-28  Michael Stahl  <michael.stahl@allotropia.de>  [ffcd44ce7c109ca6daf9b9a339609af92f163ecf]

        vcl: fix testMultiPagePDF with zlib-ng
        
        After upgrading to Fedora 40, which replaced zlib with zlib-ng, this
        test fails on different compressed stream sizes, but the uncompressed
        content of the stream is the same as before (only checked first one).
        
          vcl/qa/cppunit/pdfexport/pdfexport2.cxx:808:(anonymous namespace)::testMultiPagePDF::TestBody
          equality assertion failed
          - Expected: 230
          - Actual  : 228
        
        Change-Id: I27a6d4ac47691258793e18442fb1b59ac1b581c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172471
        Reviewed-by: David Gilbert <freedesktop@treblig.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-28  Heiko Tietze  <tietze.heiko@gmail.com>  [a200d9580b36ab11a4d21285dd5a723db091afac]

        Resolves tdf#162615 - Long label must not overside sidebar in start center
        
        Change-Id: Ia8205dd32ee7fd3f67ae2c3f6fec4366c2c4d4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172455
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-28  Skyler Grey  <skyler.grey@collabora.com>  [4e04e96334a841865914c1629202912e343c4cb2]

        fix(invert): Avoid spurious LOK invalidations
        
        Using the same mechanism as with theme changes, we can avoid LOK getting
        invalidations if we have an invert-background change that doesn't apply.
        
        The trouble is that this method of inverting the background causes *lots
        of* properties to change, so there's no single "If we inverted the
        background" to check...
        
        To get there, I've checked if all of the following are true
        - We didn't change the color scheme
        - We didn't have any new colors after this change
        - All of the properties we were changing should have been within this
          color scheme
        
        While they don't necessarily mean "there was a background inversion",
        they do mean "something changed in your theme but no action is needed
        from you" - which should only be a background inversion - and if we
        added anything else that could fit in that category, it should also
        avoid LOK invalidations
        
        Change-Id: Idb680d5241db7879d9be834268ab616848c1f165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172505
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [07fda011173917aaad75678b86e2b0570e004f93]

        Put back the mkdir
        
        ...that 1c84943890afea8eaa8fdaeabbd4394680d657f9 "run msguniq .. | msgfmt in a
        subshell to help out wsl1", and which caused all kinds of from-scratch builds to
        fail now with
        
        > [build MO ] accde
        > msgfmt: error while opening "/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/MoTarget/accde.mo" for writing: No such file or directory
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/AllLangMoTarget.mk:40: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/MoTarget/accde.mo] Error 1
        
        etc. (<https://ci.libreoffice.org/job/lo_ubsan/3288/>
        
        Change-Id: I756ebdf68f09367d24181ed47b6b5735c45aebf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172484
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-28  Adam Seskunas  <adamseskunas@gmail.com>  [d5d2f4ae1cb5f31f0fa1c5cd96df5e9d21311f4e]

        tdf#89731 Add Unit test
        
        Change-Id: I4821148c0db374dd5ac5012fae0a69c0c9d31a83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172474
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [bf1099e360193e18c29e7b042dcc1480050a4e48]

        tdf#158556 reduce allocations in ZipFile
        
        we can allocate these buffers one caller up in ReadCEN and then re-use
        them
        
        Change-Id: I07e98168ee2884286f4a1c281acd86e365416149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172481
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-28  Noel Grandin  <noelgrandin@gmail.com>  [1e0ba98adf0123aed4a0f9a208d1b132a6d2b7ab]

        GetMainViewShell is not trivial
        
        Change-Id: I86eec22a6ebb8957d983f63d37bf11b8bfa1a2bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172475
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-28  Pierre F  <fpy@bger.ch>  [dd18efa1fd245bbbd23d560662bbf7ce7d702956]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a27fa416765ce8ceecfbf1bd70ef1343dcc8e2a
          - tdf#158180 - description of ERROR Value as argument of T()
            
            Change-Id: I9e31c35c74b265ef2b6c67bdcd5b0c99b8116991
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172490
            Reviewed-by: Pierre F <fpy@bger.ch>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-27  Adam Seskunas  <adamseskunas@gmail.com>  [ccb05fabe67cd378ecd4637a3e81a52c50cfe087]

        tdf#127048 Add Unit test
        
        Change-Id: Ideace5650c71fc55adc56437914573fa5b3413f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171977
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [385c4c3fca2dc7201626b66d616fbc8511d7a101]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce7c46b6887bf4c74252e8d6b047013a22675bb6
          - tdf#162607 Remove dup's in hid2file.js, .uno:Sort*
            
            + Added separate help files for uno:Sortup and uno:SortDown commands
            + Removed bookmark from sdatabase/11090000.xhp and shared/02/12020000.xhp
            + updated menuview.xhp
            + refactor here and there
            
            Change-Id: I4c6038a89fe3eddf95b052f155e91a34ee4b164d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172479
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [00f7985b835b487934e82b25113a7785425806c2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b1770981d7d8fec3d72e03bb652262cf8e02b7f1
          - Remove TOTD duplicate page
            
            + fix bookmarks for TOTD dialog
            
            Change-Id: I584f62a2202dcaccbd34c41b540b3ef9a1c56cd2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172478
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-27  Eike Rathke  <erack@redhat.com>  [d65ccee2917baadbc1ebf85e61107cfdfcc159cf]

        Related: tdf#161599 ChildAccess::asValue() must return Reference<XInterface>
        
        ... otherwise the unotools/source/config/configitem.cxx
        ConfigItem::impl_packLocalizedProperties() checking for
        (getValueTypeName() == "com.sun.star.uno.XInterface") would not
        hit and thus not pack the properties, returning just the useless
        XWeak pointer as property.
        
        This in ScUnoAddInCollection::ReadConfiguration() lead to English
        names not being extracted from configured Add-Ins' DisplayName or
        CompatibilityName, nor any CompatibilityName added to the list.
        
        Fallout from
        
            commit bc70f674c2487ad826f8fe04e626de1829f5b40d
            CommitDate: Sun Jun 18 08:41:27 2023 +0200
        
                Use getXWeak in configmgr
        
        Change-Id: Ibaab8c08a06113b27ceffe1c45ef548c1d6fa225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172476
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-08-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1c84943890afea8eaa8fdaeabbd4394680d657f9]

        run msguniq .. | msgfmt in a subshell to help out wsl1
        
        handling stdout / pipe / redirections seems to be fragile when using
        
        wsl command1 | wsl command2
        
        when multiple of those are run concurrently. So as a woraround make
        that a single invokation of
        
        wsl shell -c "command1 | command2"
        
        Change-Id: I9e67fddd6cf377aa0461515036ea7b709714153d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172468
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [de1c7a2f54117202d91b1d2d693fa4c1a761aa87]

        tdf#161805 cui: Populate line tab menus when page gets created
        
        Since
        
            commit f075fa01cb4f74185f13eb0a8d7f84cf1f47af49
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 22 10:26:32 2023 +0200
        
                tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        , the menu button toggled handler is no more called before
        the menu shows.
        
        `SvxLineTabPage` was relying on the old behavior and
        only populating the menu entries in the handler,
        resulting in them not being present any more the
        first time the menu gets opened after the above
        commit.
        
        Populate the menu items when the tab page gets created
        instead, by changing the handler to a regular method
        `SvxLineTabPage::PopulateMenus` that gets called
        from `SvxLineTabPage::Construct` (which already takes
        care of updating the list boxes in the tab page).
        
        Move the call to `SvxLineTabPage::Construct` to the
        end of `SvxLineTabPage::PageCreated`, as
        `SvxLineTabPage::PopulateMenus` makes use of
        `m_pSymbolList` and `m_xSymbolAttr` that were previously
        only set after the call to `SvxLineTabPage::Construct`.
        
        Change-Id: I521a50f3a3695f20f789add89ffd88749e3b5cd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172472
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [6b0b28d66ae79c1cbb7545b4b40dd3682f20ff72]

        tdf#162003 qt: Add fall back for dark mode detection
        
        For Qt >= 6.5, only rely on the color scheme reported
        via `QApplication::styleHints()->colorScheme()` if it
        is explicitly `Qt::ColorScheme::Light` or
        `Qt::ColorScheme::Dark`.
        
        For the `Qt::ColorScheme::Unknown` case, fall back
        to the same mechanism used for Qt < 6.5, where
        that API was not available yet.
        
        This e.g. works around an issue with plasma-integration
        currently always reporting `Qt::ColorScheme::Unknown`.
        Suggested upstream fix:
        https://invent.kde.org/plasma/plasma-integration/-/merge_requests/149
        
        Change-Id: Iae022f7bcff3e7758d655006ec78602e08b50b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172467
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-27  Sohrab Kazak  <sohrab.kazak@gmail.com>  [84662e0454eddd928dfdf3cd8f7fe675db6a1fcf]

        tdf#158237 Using C++20 contains instead of find() and end()
        
        Change-Id: I1f0253474fa026c1bc48caaa41af037d4fdf43c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172446
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [fcc1b0d637807830c684741aad885986bc5b86db]

        tdf#158556 avoid some temporary OOXMLPropertySet
        
        no need to allocate a new one here, the caller will hand us a new one if
        we need it
        
        Change-Id: Ib569535c76631c52ed997228055bbc2f36e4749b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172466
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9d806a68f4d8b21d80b8c0f35cb3a38d4b460aa]

        tdf#158556 prevent lambda from allocating on heap
        
        bit of a hack
        
        Change-Id: Icf60fc1bc69e8c44e5612c05469164439f14a249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172465
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a47d1e00ddadce2c4dc9e6d10fc815f8c7d9e59]

        tdf#158556 unnecessary temporary OUString in ZipFile
        
        Change-Id: Iea3bf5fa9ba5210eabca521316cfd68b440ec806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-27  Michael Stahl  <michael.stahl@allotropia.de>  [6f5eb77023d50114ae9e837b7d81fe414abbef4a]

        vcl: fix testTdf129085
        
        For unclear reasons, after upgrading to Fedora 40 and pulling the latest
        master, testTdf129085 started to fail:
        
         pdfexport2.cxx:328:Assertion
         Test name: (anonymous namespace)::testTdf129085::TestBody
         equality assertion failed
         - Expected: 0x0(Error Area:Io Class:NONE Code:0)
         - Actual  : 0x8203(Error Area:Vcl Class:General Code:3)
        
        The test runs in the libreoffice-24-2 branch, and the difference is that
        in the old brach a JPEG was exported into the PDF as expected, but in
        master a DIB was exported instead, because it turned out to be smaller
        than the JPEG, because the quality level of the JPEG was 90 in master
        and 80 in the old branch, due to the old branch test passing FilterData
        with UseTaggedPDF, which was later removed from the test due to being
        the default.
        
        Pass in an explicit low quality to prevent this problem.
        
        Change-Id: Ic26c25b15fecd52c5195a7d30c603bda34fe88d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172470
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-27  Michael Stahl  <michael.stahl@allotropia.de>  [2a2b565880b39c8ff76edde68e2b61f24839113f]

        vcl,filter: replace about 5 hard-coded JPEG PDF export qualitys
        
        ... with a constant; depending on whether FilterData is passed, the
        effective default is either 80 or 90.
        
        Change-Id: Iffaf8baf8f0ae8ea1cc96c299e4c415d91f818f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172469
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-08-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a662e7a4eb3c897b213ce578ff6ff276fe60e11c]

        MSAN: Use-of-uninitialized-value
        
        ==10765==WARNING: MemorySanitizer: use-of-uninitialized-value
         #0 0x5a74216f620b in _cairo_path_fixed_fill_rectilinear_tessellate_to_boxes workdir/UnpackedTarball/cairo/src/cairo-path-fill.c:288:5
         #1 0x5a74216f620b in _cairo_path_fixed_fill_rectilinear_to_boxes workdir/UnpackedTarball/cairo/src/cairo-path-fill.c:345:12
         #2 0x5a7421735497 in _cairo_spans_compositor_fill workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:1121:11
        
        num_limits is 0 here so this is apparently cosmetic
        
        Change-Id: Ib07259ce653414c9381c800355a648ab025d1919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172457
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-27  Heiko Tietze  <tietze.heiko@gmail.com>  [4702e9ecfc66dc0f624ec73670092fd3062ae327]

        Resolves tdf#162582 - Muted color for search info on dark themes
        
        Change-Id: Ia4dddc05e0f90c4d3bca1ef8ab860b588743af3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172456
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-27  Adam Seskunas  <adamseskunas@gmail.com>  [25107330fbc5b79a4ae8bad9d1433cb28bd8b765]

        tdf#131288 Add Unit test
        
        Change-Id: I4984f0993c1012f78811865803b5287aa593b88b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171605
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-27  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [bf3cd8e50f886084500e3a8ff72ff4ffab05ddd7]

        CairoSDPR: Make using SDPR dependent of ExperimentalMode
        
        Change-Id: Ia25fe2f3c5ff4904530ea8c296d10bbbe2823af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172394
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-27  Pierre F  <fpy@bger.ch>  [67fe2bff5a19f5be603ad9f151938c96ca87ce63]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7a7ddf852c82611ffbcd9ecde78266102cc667c
          - tdf#154017 reference a more recent version of MS Office
            
            Change-Id: I7ee84211e1bc302669f481289ea4d32b724afd15
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172411
            Reviewed-by: Pierre F <fpy@bger.ch>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-27  Jonathan Clark  <jonathan@libreoffice.org>  [b558b96493f3e78445f2071232d59ac1ddbaa78e]

        tdf#162639 sw: Fix kashida justification affected by zoom level
        
        Writer kashida justification layout was using the output device to
        measure the space available for kashida glyphs, rather than the
        reference device. This caused layout to change depending on zoom.
        
        Change-Id: I9b3d400ea7a31503d85cbe71253068f7e8a037aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172454
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cf0ab5c55214d75c852b5df4ee16dc669079addc]

        Fix typo
        
        Change-Id: I2431ca67c36ae7cb0443a7bd5c49ac0c4243f025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172460
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-27  Michael Meeks  <michael.meeks@collabora.com>  [e4176371a0aa9c2364a9f6cffaaaaf82711c1b72]

        lok: ensure our 'main thread' concept is updated post-fork.
        
        Otherwise we fall foul of assertions and behavioral differences
        around the main thread as the new forked main-thread has a
        different thread-id.
        
        Change-Id: I0bd97e5173767ac6c697326aaf0d0822037e480f
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166319
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit ddeec9754cb2871a709d22efb460e141ab4c6f33)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172453
        Tested-by: Jenkins

2024-08-27  Aron Budea  <aron.budea@collabora.com>  [2cad06de3f7d9b6a6a9b4365badc40bcc9f24649]

        sc: fix crash in ScModelObj::initializeForTiledRendering()
        
        Crashreport signature:
        
        > Fatal signal received: SIGSEGV code: 1 for address: 0xd2
        > program/libsclo.so
        >	ScDocShell::CalcOutputFactor()
        >		sc/source/ui/docshell/docsh3.cxx:382
        > program/libsclo.so
        >	ScModelObj::initializeForTiledRendering(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        >		sc/source/ui/unoobj/docuno.cxx:1346
        > program/libmergedlo.so
        >	doc_initializeForRendering
        >		include/com/sun/star/uno/Sequence.hxx:120
        > /usr/bin/coolforkit
        >	Document::load(std::shared_ptr<ChildSession> const&, std::string const&)
        >		bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:578
        
        Change-Id: Id31229001951f4444781d173bf89d3e981f61b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172365
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 4edf109f9ccc31c3daa880df91bcb81c55ff6ede)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172412
        Tested-by: Jenkins

2024-08-27  Miklos Vajna  <vmiklos@collabora.com>  [45c7bb44b4d76a387dbb0dc6b10e353440cb3923]

        tdf#162574 sc HTML paste: handle not well-formed json for td data-sheets-value
        
        Regression from commit f5f6db55a5938f37a1c136be904ad7f10a3438ef
        (tdf#159483 sc HTML paste: handle data-sheets-value here, too,
        2024-02-08), in case the HTML markup is like:
        
        <td data-sheets-value="... garbage ...">
        
        then just ignore it, as if the attribute would be missing. We're only
        interested in the case where it contains well-formed JSON.
        
        Change-Id: Id625205e56ae2bfe05a26296a1a0f3abf6d5a4f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172452
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-27  Mike Kaganski  <mike.kaganski@collabora.com>  [d3d93f51af01ddc4bbb4f8bac86a2909465e08d0]

        GetMainViewShell is not trivial
        
        Change-Id: Ida2c1ec4f55c95c2a880a6d7cda46058c877a92a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172410
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b4734c8a4c1b414375c987c840a30c30e913854]

        SbClassModuleObject never take a non-null arg
        
        Change-Id: I1be4710a32355c104ba25005ec4f46c6f650b9c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [740194221e096ce437e8ac64fdc49e3957b6918e]

        use a shared_ptr for SbiBreakpoints pBreaks as well
        
        Change-Id: I3dec5ffe5fdf937d761c902970a94b73878a2cd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172441
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fb841d90a8b6cb3e45436489763a875d5bf4c59]

        cid#1554789 Different smart pointers managing same raw pointer
        
        lets just use a shared_ptr here
        
        Change-Id: I31ec113da2c060e8b89ea4e438d182f0f22e810f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172440
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [94273b45b57319e770e8c355392e75390e12811d]

        cid#1608497 Double lock
        
        Change-Id: Idacac84614411efe7516de9aa7740d7d47863ad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172438
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-27  Kurt Nordback  <kurt.nordback@protonmail.com>  [4c45ce3493e9ee842fff42228913cc11b173ca93]

        tdf#90733 - support invertIfNegative for bar and bubble chart
        
        Extend the existing initial support for the OOXML invertIfNegative tag to pass
        the data down into bar and bubble chart rendering. Also add corresponding unit
        tests. This does not include a UI control to select/deselect the invert-if-
        negative option, nor support for export of the flag to OOXML, nor any support
        in ODF.
        
        Change-Id: I45b24b816edc379c9b431e86269dd5ff37977b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6ad198d097fb4a503c8d5831d484ff46721134b]

        tdf#158556 use more comphelper::ByteReader
        
        which avoids a ton of temporary uno::Sequence being created
        
        Change-Id: I237bb69395f692bb0272ca0daec05b81af828e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171968
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-27  Adam Seskunas  <adamseskunas@gmail.com>  [03b31a8ad48e3b8a9e54203ff3856702557757b5]

        tdf#128460 Add Unit Test
        
        Change-Id: Ia83b87db09256aedf8f6e8c04986d4476099b4aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171877
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-27  Adam Seskunas  <adamseskunas@gmail.com>  [c387604cc58f3214f4fda9d9c32969115bda7b2e]

        tdf#56738 Add Unit test
        
        Change-Id: Ie0292472833c3f62f42f67877c1c4896deee0d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172089
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [5c24f11c54fcfbe825e845e7e32b1bc6f3fd2d6f]

        vcl: Use cups_option_t** param instead of void**
        
        Use `cups_option_t**` for the param type instead of
        passing the `cups_option_t**` as `void**` and casting
        to `cups_option_t**` again everywhere it is used.
        
        Make the `<unx/cupsmgr.hxx>` include in
        vcl/unx/generic/printer/ppdparser.cxx depend
        on `ENABLE_CUPS`, to not require the CUPS header
        newly included in cupsmgr.hxx otherwise.
        
        Change-Id: Iac1362866099496f59101149ca02f1477cbd2b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172402
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [f4c665b530d7fd29495c86a34cdae133907b86d7]

        Make CPDB work with --enable-cpdb --disable-cups
        
        The `PrinterInfoManager` implementation in
        vcl/unx/generic/printer/printerinfomanager.cxx
        takes care of actually using the `CUPSManager`
        or the `CPDManager` for handling printers/printing.
        
        Therefore, build that one also when `--disable-cups`
        is used in addition to `--enable-cpdb`, and only make
        the CUPS-specific bits depend on `ENABLE_CUPS`,
        rather than building the dummy version of the
        `PrinterInfoManager` implemented in
        vcl/null/printerinfomanager.cxx.
        
        This makes the CPDB printers show up in the print
        dialog with WIP Gerrit change [1] in place in
        addition.
        
        [1] https://gerrit.libreoffice.org/c/core/+/169617/25
        
        Change-Id: I5dddc72b8e679a84225f1dfb9c87d7562613a9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172401
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [f139d60d424f7fdf9fd4d73d29298894737a3ea2]

        vcl: Merge PrinterUpdate code into SalGenericInstance
        
        Move the logic from `PrinterUpdate::update` and
        `PrinterUpdate::doUpdate` directly into
        `SalGenericInstance::updatePrinterUpdate` and
        drop the extra helper class `PrinterUpdate`
        altogether.
        
        This also allows dropping retrieving the
        `SalGenericInstance` using
        
            SalGenericInstance *pInst = GetGenericInstance();
        
        , as that is the object itself (`this`) in
        `SalGenericInstance::updatePrinterUpdate`.
        
        Change-Id: Ie201bead42f51b976c4bbffd6da650280bb45925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172400
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [6ff0fde4c31196312d0f6fc74db1d67117a0e486]

        vcl: Drop always null PrinterUpdate::pPrinterUpdateIdle
        
        After
        
            Change-Id: I431171094d4981552f641af89940d877147ffa71
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Aug 26 14:18:46 2024 +0200
        
                vcl: Drop logically dead "PrinterUpdate::nActiveJobs > 0" code
        
        , it's clear that `PrinterUpdate::pPrinterUpdateIdle`
        is always nullptr, so drop it and
        `PrinterUpdate::jobEnded`.
        
        Change-Id: Ieb1e1fdabc98d8d612a0af2c68f1dcdfc17852cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172399
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [ee472dcaedccad37de0ff326d6c79bdd9bbc9e52]

        vcl: Drop logically dead "PrinterUpdate::nActiveJobs > 0" code
        
        `PrinterUpdate::nActiveJobs` is initialized to 0 and
        never increased, so cod paths for it being >= 0 are
        logically dead.
        Therefore, drop them and `PrinterUpdate::nActiveJobs` altogether.
        
        Also drop the now unused `UpdateTimerHdl`.
        
        `PrinterUpdate::jobStarted` that would have increased
        `PrinterUpdate::nActiveJobs` was dropped in
        
            commit 3564e11a41c8d3f06c8be387691d5997942e9738
            Date:   Sun Jul 30 23:20:36 2023 +0200
        
                tdf#156230 remove now unused various bit and pieces
        
        Change-Id: I431171094d4981552f641af89940d877147ffa71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172398
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [c5cad121e5b68c2209fee2aa4611b1b609e2d4cf]

        Add a CUPS config header
        
        In line with what's done for most optional,
        build-time configurable features, use a config
        header `config_cups.h` that has a `ENABLE_CUPS` define,
        include that header in the relevant source file and use
        
            #if ENABLE_CUPS
        
        for code depending on CUPS being enabled instead of defining
        a macro and using
        
            #ifdef ENABLE_CUPS
        
        This also aligns this with the `ENABLE_CPDB` macro used
        in the same source file.
        
        Change-Id: I71a5205fd63f9fc18470afcaf808c489ff833319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172397
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-27  Jim Raykowski  <raykowj@gmail.com>  [d80363beb10fd43045913bb4b54268b1df26737a]

        Resolves: tdf#120748 Using the mouse wheel to change tabs in the
        
        sidebar tabbar leaves the key input focus in a control that is not
        visible
        
        Change-Id: I9d0b85607b660e3059c6cd528528d773bc3b8ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172449
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [715b5c430e14609b15d18a5a607f13b9476b3c2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 124dce1174ef02d2af1b13e06e5d8b4dd7b7ec24
          - Fix some "D'oh! you found a bug!"
            
            Change-Id: Ia0610061cb87aa9aac47ebb9312363d435cbf2fb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172447
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0f47796899666e32bc0763f0846542ed199799f]

        cid#1608206 Double lock
        
        Change-Id: I162e10b672277c77a7e0591b532d9197a79fc6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172437
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5924bdc228d8ff7ae6e4ff47bf2b79488c6dcfe]

        cid#1607801 Data race condition
        
        Change-Id: I8825eb9cd1a8a3b26f66fd345f7a7f9b827cd50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172436
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bb2fa97f6bf20b982976c1b9cfdb652d81465d86]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c740b6ad9675129ad839903fe69afd10e1cddfb4
          - tdf#162607 Remove dup's in hid2file.js, Bad hid/
            
            Change-Id: I4e3c09cad78de5b1ce59b81430f925780a459a3d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172445
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0b6935e70996ef8f0ef35ae9595b352897ccab50]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1cc198e9dec6e7493e7a7b80d8f7be5a64906fa
          - Refactor file, no changes
            
            Change-Id: Ibb6c8e184bb88c4623680bf597ed4faa5209c213
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172444
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f7e474ff50488f8e297373b74475e00ce36984f2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9dc4502905e6364b8bc5069c3c561b44d7b896a9
          - tdf#162607 Remove dup's in hid2file.js, .uno:DeleteColumns
            
            + Deleted simpress/01/05120500m.xhp as it is not linked from any other page.
            + Deleted swriter/01/05120500.xhp as redundant
            + refactor here and there
            
            Change-Id: I38cd8a5c576bd209dabf8df129d3054aa83e4394
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172442
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d80abcc13077b066fced9be4dc1b832a0ca18dde]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 15dbb24419ea408415a5dffd3c883f196d0bb891
          - tdf#162607 Remove dup's in hid2file.js, .uno:DeleteRows
            
            + Deleted simpress/01/05110500m.xhp as it is not linked from any other page.
            + Deleted swriter/01/05120500.xhp as redundant
            + Review Table toolbar page at swriter/main0204.xhp (part)
            + Review Table toolbar page at shared/main0204.xhp (part)
            + refactor here and there
            
            Change-Id: Ibc0f90680a04749cf7e8a075364ea7290020e61e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172439
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-26  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [0247616169502d741a596519d36e005bc412ac72]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 990dbc0f0480c8c9820e2079d0c9964467e6e8b0
          - tdf#153732 Add outline to status bar and reorder items
            
            Change-Id: If07a96d2995b16551966d6deece888c615870fbc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172270
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [023e284f7844c64f042a407fb6ecba80751068cf]

        cid#1557116 dangling reference
        
        CreateFrameTabDialog takes an argument of a reference
        to the aSet ItemSet and SwFrameDlg keeps that reference
        but the SwFrameDlg will outlive that local.
        
        Change-Id: I9a0c55b86baf84cfa586952755e5a470a44562c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172432
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a2cbcb061d50cd8ac455a8eec2f1dafe0b46573a]

        cid#1607636 Data race condition
        
        Change-Id: I33bba104b43ca73435d10bf48334c34e85ca97c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172433
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [161809f2f20ce0cc6cba413f6dee06133cae1dc2]

        cid#1556212 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556339 COPY_INSTEAD_OF_MOVE
        cid#1556900 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iaf503afab3f8133f051ae08982d412c6e8587dcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172431
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9d1c1ca6c231e14b3706f5451e5079d79d2d1ce]

        cid#1556160 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iefeb8ec1803312b45989147272926266dec6b6d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172430
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [af1f7d66861e81717881f632ac9860e719b62e5f]

        cid#1554754 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6e34552074ba76f67a93686c70e26c68a884f794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172429
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [328b4c40784cb5e28535d73f0e1220b3f47f0b2e]

        text drawing boxes don't redraw with a new text autocolor choice
        
        when light/dark mode themes are toggled on off in calc. This works fine
        in writer though, so follow the same pattern as SwViewShellImp::PaintLayer
        and set a default background color on the Outliner when we draw.
        
        So SdrTextPrimitive2D::get2DDecomposition will see that the outliner
        should have a new background, and drops its cache, even if
        setSuitableOutlinerBg has no reason to set anything explicit.
        
        Change-Id: I19ca407853238e6533085c6aa617206ee122d3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aceb413b2001c64edb077e9ea98db4eeff7de3b9]

        a SdrPage* is sufficient, don't need to case to SdPage*
        
        Change-Id: I1bbbf5f885dffecae071a06e313e1a91f5a9a776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172403
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [780728041982ff6980a9552a5b84dd9db6b9680c]

        tdf#158556 no need to clone in OOXMLPropertySetValue::getProperties
        
        the callers just want to read the data
        
        Change-Id: I037766ac007266ea81765df94021d05528a60c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172396
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-26  Pierre F  <fpy@bger.ch>  [6ef4d6bebf92a0410a7c55f81cbaed312e11d8bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f9c2c4f00d219221d8e06a0961b0594835d94958
          - tdf#152463 tdf#144511 AutoRecovery and backup on by default
            
            Change-Id: I108b677c082ccca038ac73203fb42b88f8c16e1a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171987
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [56a50be3ea6d2073bffd6bfc55c5349eedef8c75]

        sw: fix indent
        
        Change-Id: Ic058c403fd4229216844ae21472d673c481e2368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172393
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5b1b02e7e31583aff0d2300b8815aa8407c6fe4]

        cid#1554835 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic9e07bb0f571b89af2c8b2dd9ca0a660dfb1b1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [39de116b733685881f0defe9cc10070c826ad9c2]

        +WARN is the default with an unset SAL_LOG env var, anyway
        
        Change-Id: Ia8bbc1bdc09705f1ecab783d0d73a417f0ef84e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172378
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a3a71ed916994df700f42b58b6400dafed3db8e4]

        'use strict' is of no use here...
        
        ...in snippets that are included with --pre-js/--post-js
        
        Change-Id: I928aa16b78284314796a0645479dce0dfc7b42cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172383
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-26  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [42f677c5f67a23e0cfb4fcc664efce078718489d]

        related tdf#68274: switch on MAR-based auto-updater by default
        
        On platforms built with --enable-online-update-mar, make the automatic
        online update the default now.
        
        Change-Id: I4d8355023f185b89aa25701bcc02a15986d3d969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172335
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c3a4e4a778c673bdc46468157ea5b5e5e1d9142]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1acfb22433aba0a648dd3df3d365671b690d2b6d
          - tdf#162607 Remove dup's in hid2file.js, .uno:InsertColumns
            
            + Deleted simpress/01/04040000m.xhp as it is not linked from any other page.
            + Review Table toolbar page at main0204.xhp (part)
            + Review InsertColumnsAfter / Before
            + Wrap icons to make embed-able in other Help pages
            + left swriter/02/04100000.xhp as unique entry for .uno:InsertColumns command
            + refactor here and there
            
            Change-Id: Ibbfcf7ae5d848161d2e696b1cae14b4073f78a94
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172395
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1a0bc1f8c21284959e4d512e82a9d6279ad1261c]

        In desktop we want to update all the calc shells for dark/light mode
        
        while in kit mode we just want the current, before this in desktop
        mode none of the desktop shells for their dark/light mode updated
        
        Change-Id: I319f067afefedddf3d92c5cff675dac35e046179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172391
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c5a3f5ae337d615f43d21aa47d3d76847c52f99]

        p is already checked against m_pColorConfig.get in outside condition
        
        Change-Id: I6c5d51b395b742fa6cc5fc7d49b08bddb19e1f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5a0576db4b7c0e2597e71d454c87f43ffda74fd2]

        cid#1608542 PA: Public Attribute
        
        Change-Id: Idb368b38229ae9c02172a58997591df80da2a8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172387
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e4110d1a8056b2bd071b1efba4330d1f4fd2ef8b]

        cid#1608341 Overflowed return value
        
        Change-Id: I0deb43c8bf998f914368115f1dfd176278cfe274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172386
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86afa54110d48ffcd5abd849f15ac75ab92a480e]

        cid#e608033 silence bogus Overflowed array index read
        
        Change-Id: I37da01ba951cd2db0398b58627b00c0c72a2e57a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172385
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-26  Jonathan Clark  <jonathan@libreoffice.org>  [f18d56d298cc9ec9c1c6e0ad4ffce63afc40e2c2]

        tdf#162603 vcl: Fix sporadic non-subpixel label cutoff
        
        Fixes an issue causing occasional truncation of the final column of
        pixels when rendering text without subpixel positioning.
        
        Partially reverts
        commit 560e5406f3c6e8e6ed0f1c251b6910465266ed8d.
        tdf#153966 vcl: Fix precision loss laying out right-aligned text
        
        Change-Id: I9372e842c8bea59dd8e6d87a8b6887ba7e34897b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172388
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [60b4bca6bda086c1ed265cecc52e530f3ed5119c]

        cid#1618310 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic53365af1b6e075016ba61c438e3bb7dd4c25f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172382
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-26  Justin Luth  <jluth@mail.com>  [c8e272734a8fa26d93b057d1c9def8dc6c401143]

        tdf#162612 mso import NOT-layoutInCell: effectively are wrap-through
        
        The way Microsoft implements the layout of in-table-anchored shapes
        that are NOT marked as layoutInCell
        is to treat them all as wrap-through.
        
        So, lets explicitly mark them as they ought to be during import.
        
        tdf154863-img-move-crash.docx is a fine example of this,
        although the document itself is ugly and too complex for a unit test.
        
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf162612
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf162541
        
        There is a SLIGHT danger here, as shown by testTdf162541.
        LO looks VERY different from Microsoft's VERY WEIRD LAYOUT,
        but will "correct" it with a round-trip.
        I'm not too concerned - LO is exporting the document
        the way it sees it.
        
        Change-Id: I14d8ea9dcef257a3239a9601b63c04cde780cb33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172364
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1cf86074147e89da880d539055b1804ca135b679]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef154ba2a37e2b20fe667c9d704fc7749536cbac
          - tdf#162607 Remove dup's in hid2file.js, .uno:InsertRows
            
            + Deleted simpress/01/04030000m.xhp as it is not linked from any other page.
            + Review Table toolbar page at main0204.xhp (part)
            + Review InsertRowsAfter / Before
            + Wrap icons to make embed-able in other Help pages
            + left swriter/02/04090000.xhp as unique entry for .uno:InsertRows command
            + refactor here and there
            
            Change-Id: I9455abab6301103cf751e9f24f93ce34e03786f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172373
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-26  Noel Grandin  <noelgrandin@gmail.com>  [6e62e021e88f244c2de9a53a104e67b676fc2913]

        tdf#158556 simplify StylePool API
        
        StylePool is only used inside writer, and only in very limited
        ways. Rather move the logic for the limits functions inside StylePool
        so I can then reduce the complexity of the iterator.
        
        Change-Id: I12bc5965b74abace28ae9190b35661a34f5005be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172371
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-26  Justin Luth  <jluth@mail.com>  [6ea40d129e53c676970d3c0ca1db561394422419]

        typo: THROUGHT -> THROUGH
        
        There is no need to test for both - they are the same value...
        
        Change-Id: I1f833d514a8e7ee710025d1e414e04459503f555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172366
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-26  Heiko Tietze  <tietze.heiko@gmail.com>  [cd2eba5c698081355d51c491398119f38068bfb2]

        Related tdf#160226 - Math inline editing Off by default
        
        Introduced per
        I63672c054d1ead269863079e7f9c118a44b3ba19
        Ib2ca942c537e466f6ff100be7f95adaead99f1d5
        
        Change-Id: Iff2bd250c004e57800c84287483965ec3ae49187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172241
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-26  Kira Tubo  <kira.tubo@gmail.com>  [1fefb68a916918620f0bad7c879ff805c416bec4]

        tdf#153722 Move Headings from "Text Styles" to "Document Structure"
        
        In Paragraph Styles, move "Heading" and "Heading [1-10]" from "Text Styles" to "Document Structure"
        
        Change-Id: Ie8bbfa7d3f31e68f1c2579ec2acaded3bfe37397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172340
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-26  Miklos Vajna  <vmiklos@collabora.com>  [9844a7347608a6bbc85e680a2e222aa106c01db7]

        svx: prefix members of SdrObjEditView
        
        See tdf#94879 for motivation.
        
        Change-Id: Id344aa38c431608432a6a274ee4ec6772b434557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172376
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [64312cdae5d810dd02ef4c2a4d51b3d30cd6ac6e]

        sw: drop macros
        
        Change-Id: I6ec8e2e62f59be9633e66c9c24950c16d7ed9324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172372
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-26  Mike Kaganski  <mike.kaganski@collabora.com>  [ed0ef16bb01225ab4ab1c6fd5a4959f76d77b11d]

        tdf#162593: blind crash fix
        
        The stack trace was:
        
        Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
        0x00007ffff32175ee in rtl::OUString::OUString (this=0x7fffffffaac0, str=...) at /home/cono/git/lo/libreoffice/include/rtl/ustring.hxx:197
        197	        pData = str.pData;
        #0  0x00007ffff32175ee in rtl::OUString::OUString(rtl::OUString const&) (this=0x7fffffffaac0, str=...) at /home/cono/git/lo/libreoffice/include/rtl/ustring.hxx:197
        #1  0x00007ffff3521e4f in GalleryBrowser1::GetItemText(SgaObject const&, GalleryItemFlags) (rObj=..., nItemTextFlags=GalleryItemFlags::Title) at /home/cono/git/lo/libreoffice/svx/source/gallery2/galbrws1.cxx:1412
        #2  0x00007ffff352265d in GalleryBrowser1::FillThemeEntries() (this=0x55555c0c9240) at /home/cono/git/lo/libreoffice/svx/source/gallery2/galbrws1.cxx:1505
        #3  0x00007ffff351a602 in GalleryBrowser1::GalleryBrowser1(weld::Builder&, Gallery*) (this=0x55555c0c9240, rBuilder=..., pGallery=0x55555c0a4aa0) at /home/cono/git/lo/libreoffice/svx/source/gallery2/galbrws1.cxx:196
        #4  0x00007ffff354c291 in svx::sidebar::GalleryControl::GalleryControl(weld::Widget*) (this=0x55555c04e470, pParent=0x55555be85558) at /home/cono/git/lo/libreoffice/svx/source/gallery2/GalleryControl.cxx:32
        #5  0x00007ffff45c72ea in std::make_unique<svx::sidebar::GalleryControl, weld::Widget*&>(weld::Widget*&) () at /usr/include/c++/12/bits/unique_ptr.h:1065
        #6  0x00007ffff45c5f7a in (anonymous namespace)::PanelFactory::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x55555c0494e0, rsResourceURL=..., rArguments=...) at /home/cono/git/lo/libreoffice/svx/source/sidebar/PanelFactory.cxx:180
        #7  0x00007ffff6412417 in (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x5555564db3e0, ResourceURL=..., Args=...) at /home/cono/git/lo/libreoffice/framework/source/uifactory/uielementfactorymanager.cxx:440
        #8  0x00007ffff5593a35 in sfx2::sidebar::SidebarController::CreateUIElement(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, rtl::OUString const&, bool, sfx2::sidebar::Context const&) (this=0x55555b0a8100, rxWindow=..., rsImplementationURL=..., bWantsCanvas=false, rContext=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:1044
        #9  0x00007ffff5593341 in sfx2::sidebar::SidebarController::CreatePanel(std::basic_string_view<char16_t, std::char_traits<char16_t> >, weld::Widget*, bool, sfx2::sidebar::Context const&, VclPtr<sfx2::sidebar::Deck> const&) (this=0x55555b0a8100, rsPanelId=u"GalleryPanel", pParentWindow=0x55555c040718, bIsInitiallyExpanded=true, rContext=..., pDeck=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:989
        #10 0x00007ffff5592150 in sfx2::sidebar::SidebarController::CreatePanels(std::basic_string_view<char16_t, std::char_traits<char16_t> >, sfx2::sidebar::Context const&) (this=0x55555b0a8100, rDeckId=u"GalleryDeck", rContext=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:789
        #11 0x00007ffff5591dbe in sfx2::sidebar::SidebarController::CreateDeck(std::basic_string_view<char16_t, std::char_traits<char16_t> >, sfx2::sidebar::Context const&, bool) (this=0x55555b0a8100, rDeckId=u"GalleryDeck", rContext=..., bForceCreate=false) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:737
        #12 0x00007ffff5592b96 in sfx2::sidebar::SidebarController::SwitchToDeck(sfx2::sidebar::DeckDescriptor const&, sfx2::sidebar::Context const&) (this=0x55555b0a8100, rDeckDescriptor=..., rContext=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:899
        #13 0x00007ffff5591b89 in sfx2::sidebar::SidebarController::SwitchToDeck(std::basic_string_view<char16_t, std::char_traits<char16_t> >) (this=0x55555b0a8100, rsDeckId=u"GalleryDeck") at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:708
        #14 0x00007ffff5591936 in sfx2::sidebar::SidebarController::OpenThenToggleDeck(rtl::OUString const&) (this=0x55555b0a8100, rsDeckId=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:664
        #15 0x00007ffff558d884 in operator()(rtl::OUString const&) const (__closure=0x7fffffffb7c0, rsDeckId=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/SidebarController.cxx:123
        #16 0x00007ffff5598e13 in std::__invoke_impl<void, sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, const SfxViewFrame*)::<lambda(const rtl::OUString&)>&, const rtl::OUString&>(std::__invoke_other, struct {...} &) (__f=...) at /usr/include/c++/12/bits/invoke.h:61
        #17 0x00007ffff559851c in std::__invoke_r<void, sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, const SfxViewFrame*)::<lambda(const rtl::OUString&)>&, const rtl::OUString&>(struct {...} &) (__fn=...) at /usr/include/c++/12/bits/invoke.h:111
        #18 0x00007ffff5597b76 in std::_Function_handler<void(const rtl::OUString&), sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, const SfxViewFrame*)::<lambda(const rtl::OUString&)> >::_M_invoke(const std::_Any_data &, const rtl::OUString &) (__functor=..., __args#0=...) at /usr/include/c++/12/bits/std_function.h:290
        #19 0x00007ffff55e2bed in std::function<void (rtl::OUString const&)>::operator()(rtl::OUString const&) const (this=0x7fffffffb7c0, __args#0=...) at /usr/include/c++/12/bits/std_function.h:591
        #20 0x00007ffff55e09aa in sfx2::sidebar::TabBar::Item::HandleClick(rtl::OUString const&) (this=0x55555b133290) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/TabBar.cxx:274
        #21 0x00007ffff55e0933 in sfx2::sidebar::TabBar::Item::LinkStubHandleClick(void*, rtl::OUString const&) (instance=0x55555b133290, data=...) at /home/cono/git/lo/libreoffice/sfx2/source/sidebar/TabBar.cxx:264
        #22 0x00007fffe688a6b7 in Link<rtl::OUString const&, void>::Call(rtl::OUString const&) const (this=0x555556f7ee38, data=...) at /home/cono/git/lo/libreoffice/include/tools/link.hxx:111
        #23 0x00007fffe68821c9 in weld::Toolbar::signal_clicked(rtl::OUString const&) (this=0x555556f7ee30, rIdent=...) at /home/cono/git/lo/libreoffice/include/vcl/weld.hxx:2512
        #24 0x00007fffe683260b in (anonymous namespace)::GtkInstanceToolbar::signal_item_clicked(GtkToolButton*) (this=0x555556f7ebe0, pItem=0x55555b13a9a0) at /home/cono/git/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:12009
        #25 0x00007fffe6832553 in (anonymous namespace)::GtkInstanceToolbar::signalItemClicked(GtkToolButton*, gpointer) (pItem=0x55555b13a9a0, widget=0x555556f7ebe0) at /home/cono/git/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:12000
        ...
        
        I suspect that there is a corner case of some element giving a nullptr
        in xSgaObject; but since I can't repro locally, it's just a guess. Other
        places using AcquireObject in the file do check its return, so it seems
        reasonable to do the same here.
        
        Change-Id: I40c0d64a7219d483ec94f56c56a6df0ce79e9c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172280
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-26  Jim Raykowski  <raykowj@gmail.com>  [7ae0542f7208573b18dadb0dee550f34ce8e41f4]

        resolves: tdf#162337 Initial selection of tracked change when Manage
        
        Changes dialog is initially opened
        
        Restores behavior of tracked change selection in the document and tree
        entry selection in the Manage Changes dialog on opening to that of
        commit
        d9466e9e09f8aa618f722d9d7bef7469aa51dc14 with the exception that the
        tracked change selected when the cursor is after the last tracked change
        in the document is now wrapped to the first tracked change in the
        document, see commit 8e6203bd8f4390698f83a74a04f901437a9a61a3.
        
        Change-Id: Ic1be06bb99787393d7962bd19fc791959408956e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171451
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [d1c5ed30d1128c0500d3fab72bb5505f81a1bdc1]

        tdf#162614: report the reason why a frame couldn't grow
        
        ... and use it in SwTextFrameBreak::IsBreakNow to decide if the content
        needs to go to a follow or not.
        
        The problem was, that in a specific case of the bugdoc, the follow text
        line was taller than the fixed row height on that page; that resulted
        in an attempt to break it again, creating an empty follow in the same
        table cell; it was not moved to the next page, detecting the problem in
        SwTextFrame::CalcFollow, and the formatting looped, until loop control
        fired, calling SwLooping::Drastic, which validated all page's content,
        including tables below, that had invalid zero client (prn) height.
        
        It was very difficult to tell when the break is needed, and when it's
        not, without the information why some frame eventually denied growing
        its height by the requested amount. In the bugdoc case, I failed to
        find at the SwTextFrameBreak::IsBreakNow level anything that could be
        used as a reliable distinction; some heuristic conditions used there
        broke layout in unit tests left and right. So eventually, I came with
        this mechanism of reporting the "why I can't grow" reason back to the
        caller, using the new out argument.
        
        I believe that, beyond this use case, it might be useful in many other
        cases, both to ease the decision, and to prevent needless trial-and-
        error iterations, increasing stability and performance. The enum used
        for the reason reporting includes 'FlowToFollow' and 'BalancedColumns',
        that could be used in those other cases. However, for my needs here, I
        only need the FixedSizeFrame reason, telling that it's not a case when
        breaking to a next frame is possible, so preventing the break.
        
        The choice of reported reasons in this patch is mostly best guess; it
        may be wrong in some places. The crucial for the current fix is the
        assignment inside the '!(GetType() & nTmpType) && HasFixSize()' check
        of SwLayoutFrame::GrowFrame.
        
        Change-Id: I9ce5dd4d2298b60e186fdf485efb85ab304308ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172362
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cd8ad433f04223193d270ba583ffa881984acf11]

        tdf#161941 add --with-docrepair-fonts option
        
        to enabling bundling or not bundling the docrepair fonts of
        https://github.com/docrepair-fonts
        
        (which provide replacments for: Agency FB, Baskerville Old Face,
        Berlin Sans FB, Cooper Black, Lucida Calligraphy, Lucida Grande,
        Lucida Handwriting)
        
        Change-Id: I4ea442fa54d21f213ccbdccba9aea1b9c0675c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [29749031cde3802d0fb117bfd770c4e6cc93e243]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ed4eb232dc24516441b980e6437bc04a649448f
          - tdf#162628 Review Writer Status Bar Help page
            
            + Reorder status bar elements
            + added Accessibility entry
            + Update Combined display with document elements type
            + Refactor
            + Update a11y page with how-to-get from Status Bar
            + update Document Modified help page and add icons
            
            Change-Id: I2a297e4eb2c72a3088229ac029f17388ae2d8f25
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172370
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [26b8818481c7e99684f734261f7281070fb0f386]

        cid#1608296 silence Overflowed integer argument
        
        and
        
        cid#1606815 Overflowed integer argument
        cid#1606617 Overflowed integer argument
        
        Change-Id: I4569190edd9b8d65e9b080a7ad0fac391f4a657e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-25  Jim Raykowski  <raykowj@gmail.com>  [472644f5a30b47f7855ee988a207bab8960e954d]

        Resave with newer Glade version
        
        Change-Id: I00b96d10f7890631f915beeb0c41f714685e34db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172367
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [459bf1c5890d6ae7ac99646f2721dd8c7fa9b283]

        crashtesting: null deref in swxtextframe_createtextcursorbyrange.sample
        
        Change-Id: Ie34db8edfb6bf45022ccb8a180eec091885eaea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-25  László Németh  <nemeth@numbertext.org>  [cfb4b20ddbbd330d878d1b11afa932ad72aac945]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 2ae8fab6fe32bbd3d9817d41a823dc3a9dc6a07f
          - Fix Hungarian hyphenation
            
            ké=rüg=ma, and not kér=üg=ma,
            reported by Gellért Gyuris.
            
            Change-Id: I2e34d93ab456c6180f80b94c136d32767717bf8e
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/172369
            Reviewed-by: László Németh <nemeth@numbertext.org>
            Tested-by: László Németh <nemeth@numbertext.org>
            
2024-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [99b8446dacda9bdeba9609d17dca34b365cc7763]

        ofz#69874 make a failed seek for libtiff poison the stream
        
        ...for the reset of the tiff reads/seeks.
        
        Comparing our fuzzer against the libtiff fuzzer, that one uses the
        libtifxx std::stream integration so std::stream badbit rules apply and
        after the first failed (seek) operation all subsequent operations fail,
        so do the same for our tiff importer to align with the libtiff
        expectations.
        
        Change-Id: Ic881389bf78643803de70afeda55112a54b09c1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172363
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9b5dad09dbdd56ff064096695a946b03e9e2914]

        cid#1608301 silence Overflowed constant
        
        Change-Id: I7cca8a62307b434b34781d8b1ba3ee312cafde0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172351
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20bd1ab3bfcc2d89d36b5dc284df200ece76f885]

        cid#1616072 Different smart pointers managing same raw pointer
        
        Change-Id: Ia6e1a911b9d5af906fedfe01225e95396f34dd99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [97649f5d39107c6354fc9b4e4eba223b0a1c1e41]

        cid#1555386 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic8aff9bb5e2ce7a717460fc167dfd23b9401855b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172350
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0ac9f7971090a7735e4f78f843dcf72185907202]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6930aa0207190cdb8113b74dbbfb61b40ddafe4b
          - tdf#162607 Remove dup's in hid2file.js
            
            + Case of some (but not all) dup's in schart/main0000.xhp
            + refactor
            
            Change-Id: I22e548735b5efda9b634a3c21daaf6bf1def2543
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172360
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-24  Jean-Pierre Ledure  <jp@ledure.be>  [8a4ee0fb39dfabb590fb2b12c87f545da664e449]

        ScriptForge (SFWidgets) new ContextMenu service
        
        Complete a predefined context menu with new items
        placed at its bottom.
        
        A context menu is obtained by a right-click
        on several areas of a document. Each area has
        its own context menu.
        Each component model has its own set of context menus.
        
        A context menu is usually predefined at
        LibreOffice installation. Customization is done
        statically with the Tools + Customize dialog.
        The actual new service provides a mean
        to make temporary additions at the bottom of a
        context menu. Those changes are lost when
        the document is closed.
        
        The name of a context menu is the last component
        of the resource URL:
           "private:resource/popupmenu/the-name-here"
        
        Context menu items are either usual items or
        line separators. Checkboxes or radio buttons
        are not supported.
        Items run a command or a script when clicked.
        
        The service implements 2 methods:
           AddItem() adds an entry in the menu hierarchy
           Activate() shows or hides the added entries
        
        A context menu can be defined from both Basic
        and Python user scripts.
        
        An update of the documentation is required.
        
        Change-Id: Id77f1f2565d75e36c09b13972330d0f83b3f1db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172355
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a241f2d96d6ea0c1f17eb3836537ba00b51de72f]

        Fix typo
        
        Change-Id: I26e273eccd4f1fcb525628a47a24c9a9f6f6f585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172353
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19e588c6dae2ab1720d51aa934e2f5dcfe49dd1c]

        cid#1607908 silence Overflowed return value
        
        Change-Id: Iafc85f656b0703cd6a4e19469f4752203789477e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172347
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb115be987c4aa3dc2daed02dcd1b419e8d6a61e]

        cid#1616924 Dereference after null check
        
        Change-Id: Ia326d99b11d18f7c561c988f0299feb2ebf84b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172346
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4cbe3e2fca5752296b67dfb796155c62ed99396f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3542a6dade252f7d6b9e8332437e88a52e782db6
          - tdf#162607 Remove dup's in hid2file.js
            
            + Case of placeholder "zzzz" left here and there
            + refactor
            
            Change-Id: I048ad7a9db45a8931ffca0ed801cb49c7888e02a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172356
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8ce9a3e343c136a97004bc3612ed9c0c75d48aa8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 81f8551d4281a11d2a9ac7d89d1660f32fda6187
          - tdf#162587 Drop of case sensitivity for function UNIQUE
            
            + No impact on string freeze.
            + This will remove a "D'oh!" from the help page of UNIQUE once cherry picked
            + Help page will be completed once tdf#162601 is fixed.
            
            Change-Id: I10f7a3824132bb4a69b0769140a85b51ced9cdbb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172354
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-24  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [79ab5c3775f8d0685585810583b84c0f4d49a1bf]

        CairoSDPR: Let VclPixelProcessor2D use RedLining decompose
        
        VclPixelProcessor2D used PRIMITIVE2D_ID_WRONGSPELLPRIMITIVE2D
        to render WrongSpellPrimitive2D using processWrongSpellPrimitive2D
        and there renderWrongSpellPrimitive2D. That again used
        DrawWaveLine at OutputDevice.
        
        This again does some very special things, e.g. it uses the set
        Font at the OutputDevice which hopefully is the one the
        redlining refers to (info from that has to be added to the
        WrongSpellPrimitive2D if needed, in this case the
        LogicalFontInstance's GetWavelineUnderlineSize result). It
        seems to rely on the Text being redlined being 'painted'
        directly before this.
        It also renders the WaveLine to a BitmapEx and does pixel-
        based operations on it (probably to 'clip' the WaveLine instead
        of adding needed partial curve geometry), and adds that
        BitmapData to a cache.
        It also mentions it 'make sure the waveline does not exceed the
        descent to avoid paint problems', probably because when not
        handling it as Primitive from a PrimitiveProcessor the
        invalidation Range will not fit (it still uses the getB2DRange
        of the WrongSpellPrimitive2D to do that part indirectly), so
        these regions will probably not always have fit.
        
        Nothing of this is needed, after I made the
        WrongSpellPrimitive2D to use view-independent (aka pixel-
        oriented scaling, fixed size) to behave like the current paint
        the VclPixelProcessor2D can just use the decompose and render
        the view-dependent and buffered visualization of the WaveLine.
        
        NOTE: It is not possible to completely get rid of
        OutputDevice::DrawWaveLine since it is used in some cases in
        Writer directly, also in ImpEditEngine::Paint when the
        EditEngine is painting directly (very rare now).
        
        NOTE: Also impCreateTextPortionPrimitive did swap start/end
        in preparationm to create a WrongSpellPrimitive2D (look for
        tdf#151968), this will no longer be needed.
        
        Change-Id: I31aec8ea9c2e3c574ad471082612a10d95810f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172331
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-24  Justin Luth  <jluth@mail.com>  [a8125cd58309dfec84ea9d3de749fadb0f0505f8]

        tdf#162541 docx import NOT-layoutInCell: hori-para => PAGE_PRINT_AREA
        
        This was copied from DOC import.
        Since compat15 is always layoutInCell, the impact for DOCX is minimal.
        
        If the fly is not layoutInCell,
        then MSO applies the para-orientation
        against the paragraph that contains the entire table,
        not the cell paragraph it is anchored to.
        
        For the horizontal case, this table-paragraph is equivalent
        to the page margin, so change it to a meaningful value.
        
        The vertical case cannot be meaningfully mapped to an equivalent,
        so someone will need to implement that in layout code.
        
        Wrap through has NOTHING to do with this.
        
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf162541
        
        Change-Id: I17b28f9d77cd85b4104e8c8f0c347e61b6c8f5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172297
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-24  Justin Luth  <jluth@mail.com>  [34f04196575fd52bb117696df92177c3b7d2d190]

        tdf#162541 doc import NOT-layoutInCell: hori-para => PAGE_PRINT_AREA
        
        If the fly is not layoutInCell,
        then MSO applies the para-orientation
        against the paragraph that contains the entire table,
        not the cell paragraph it is anchored to.
        
        For the horizontal case, this table-paragraph is equivalent
        to the page margin, so change it to a meaningful value.
        
        The vertical case cannot be meaningfully mapped to an equivalent,
        so someone will need to implement that in layout code.
        
        Wrap through has NOTHING to do with this.
        
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf162541
        
        Change-Id: I66212a9cda89e63e7b17daba0661a90f681fc0e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172218
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-24  Justin Luth  <jluth@mail.com>  [0640a0f673635f861a28d14d21e40599e7a54553]

        tdf#162551 mso formats: line(vert) or char(hori) forces layoutInCell
        
        Already DOCX compat15 always forces layoutInCell,
        but even earlier than 2013, if the shape is oriented
        vertically to the line, or horizontally to the character
        then everything is treated as if it was layoutInCell.
        
        So let's make it explicit while we import.
        That seems to make the most sense.
        
        make CppunitTest_sw_ooxmlexport21 CPPUNIT_TEST_NAME=testTdf162551
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf162542
        
        No existing unit tests found.
        
        Change-Id: Ibdb4933e248c86ab595df68f81fad1f23345c2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172296
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-24  Justin Luth  <jluth@mail.com>  [9af17e84ec12e279c81020c172a682c066aba8a5]

        NFC ww8graf.cxx: mark never-changing, important variables as "const"
        
        I'm trying not to polute my patches with NFC changes.
        
        Change-Id: I057c01b945e24cf85b633c694c34824ee786face
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172295
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-24  Justin Luth  <jluth@mail.com>  [77bbf007cd9db81c141bb123b83aac72c13a436f]

        tdf#162542 doc import NOT-layoutInCell: do not change char into margin
        
        It was simply wrong to equate an char-orientation
        with a page margin orientation.
        
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf162542
        
        Change-Id: I08f1449bfbb8e24311bc77e164d3fa57f25ee35f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172217
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-24  Justin Luth  <jluth@mail.com>  [c63cce999629ef1aedfa688d1ef8753e13020c36]

        tdf#157637 ODT->DOC: use layoutInCell for para-oriented fly
        
        This is a very sticky business.
        LO and Word implement aspects of FollowTextFlow so differently.
        
        But for native LO documents, it is clear that at least
        the image placement of paragraph-oriented flies
        is based on the cell paragraph, which in MSO layout
        means the layoutInCell paragraph.
        
        Prior to 7.4, we never wrote anything related to layoutInCell,
        and since the default is true, layoutInCell was always true,
        so writing layoutInCell = false less often can't cause a regression.
        
        But of course there are implications.
        The main side effect is that the cell will expand to contain the fly,
        or the UI might, on an "OK", move or squish the image into the cell.
        But we already had that prior to 7.4 anyway.
        
        WrapThrough shouldn't come into play here
        (although they tend to look better, with less side effects).
        
        make CppunitTest_sw_ww8export3 \
            CPPUNIT_TEST_NAME=testTdf79186_noLayoutInCell
        
        ----
        This cannot fix LO inserting images into a doc-formatted file though.
        That can only be handled by "fixing" the layout to orient the newly
        inserted image relative to the table-paragraph
        instead of the cell-paragraph.
        
        LO currently does not properly reflect the layout
        when layoutInCell=false for DOC/DOCX<=compat14 flies,
        so simply looking at LO results is very deceiving.
        Make sure you also check how the end result looks in MS Word.
        
        Change-Id: Ia631c56a25ad103ac448f1f46a8553ab1478330b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157662
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [c2337ff12896b2ae09437d2cbc726971c9fb170f]

        Simplify a bit
        
        Change-Id: Ia18d2d28d1026e3a695374dd523fb23ee97b96b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172344
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [3caa0db8cfcf2ed2469e7a4cecba8a57d142dc04]

        Flatten SwFrame::Grow
        
        Change-Id: I0357a2b773ce7039697593df5f44b7ee35f89511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172342
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ba2b87ba52bf26e8cef667a35bfb7f2232acf11]

        tdf#158556 make SvxAdjustItem hashable
        
        Change-Id: Ic6bda5fad24ef0d9676bfb3d997da9c32aa959f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [513b20a5f38cb3492d31e0262f0b278d77f653b0]

        tdf#158556 make SvxRightMarginItem hashable
        
        Change-Id: Iad6fef862eb0b7002bbe28ed80efe1e533ffeec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-24  Andras Timar  <andras.timar@collabora.com>  [1d11b27384972a4a5822da44402d998d60c53dc4]

        jsdialog: enable new style dialog
        
        to test:
           1. Open sidebar in Writer
           2. In Styles section press the rightmost icon [New]
        
        Change-Id: I03230c5ef2921da6b1671a2e67e3ba6d1e088e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169965
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172334
        Tested-by: Jenkins

2024-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [bc473907dbd5ca1048243d13b7cbe00d74a3d157]

        Flatten SwSectionFrame::Grow_
        
        Change-Id: Ia83785525cbb49a02a10b6c248fe2060bc6407d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172339
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [e725fb61365032343256b929b009cff07bbaa799]

        Flatten SwFlyFrame::Grow_
        
        Change-Id: I6fe29fef686e00dce30a024063f684f1eeaf3f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172338
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-24  Andras Timar  <andras.timar@collabora.com>  [62826a4c54c67d4925aa5a79e5ecaf3b07ffefdd]

        jsdialog: enable name dialog
        
            to test:
            1. Help - Accessibility Check
            2. If document title is not set, press [Fix]
        
        Change-Id: I9694679874c58515856edf8e3d31600258b8319c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169943
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172333
        Tested-by: Jenkins

2024-08-24  Andras Timar  <andras.timar@collabora.com>  [3968d46e20dc56c7470436c2332c79ee5aa694dc]

        LOK: fix UI language fallback, e.g. zh-HK -> zh-TW
        
        The original author wanted to handle de-CH as special case, but
        he wrote a general condition.
        - comphelper::LibreOfficeKit::isActive() is redundant, because we
          call SfxViewShell::SetLOKLanguageTag() from LOK.
        - AFAIK there are no other, similar cases. We know about only de-CH,
          so let's make it explicit in the condition.
        - This fixes UI language setting when the integration asks for zh-HK.
          Previously it falsely fell back to en-US here, instead of zh-TW.
        
        Change-Id: Ie42e09b8e202b654b109ab8d777ab36a5ef56dca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169363
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172332
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8843081f91e206b4749b83b186caaceaf1f8c4e3]

        Resolves: tdf#162597 'ok' in chart range dialog doesn't commit datarange
        
        so nothing happens.
        
        since:
        
        commit 4965b055b5998dc345ecaeb80fc8c3874b19e2a5
        CommitDate: Fri Feb 16 12:08:55 2024 +0100
        
            Chart: Make Data Range Dialog Async
        
        async conversion missed that there is a DataSourceDialog::run
        override so the use of asyncRun means the body of that isn't run.
        
        To keep things simple we can add an explicit 'ok' handler and move
        the special dialog ok code into that instead, so all the existing
        asyncRun's used with this dialog run the same code originally called
        in the previous non-async case.
        
        Change-Id: Ibdb4b764b1a1e48c01ee1528bc260f694e840221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172336
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [96f3aeaa70d91b26861ac28f0b077b46546d3676]

        Emscripten: Only resolve Module.uno_init after Module.uno_mainPort is set
        
        Otherwise, client code (which is run as soon as Module.uno_init is resolved)
        could try to use Module.uno_mainPort before it has been set.
        
        Change-Id: Ibac992d965f43e9f6766d06e3bd80f1964258b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172326
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7d37241dcb7aa20adfa7510323cfd7984ff5e911]

        Emscripten: Module.uno_scripts are relative to document.baseURI
        
        ...so explicitly make them absolute, in case the WorkerGlboalScope used in
        runUnoScriptUrl would make them absolute relative to a different base URL.
        
        (See <https://github.com/mdn/content/issues/35568>
        "WorkerGlobalScope.importScripts URLs relative to what base URL?" for my
        confusion of what base URL should actually be used there.  But at least with an
        emsdk that uses recent Emscripten trunk towards 3.1.65, and where meanwhile
        worker threads no longer load an soffice.worker.js but instead use some blob:
        URL, a
        
        > Module.uno_scripts = ['example.js'];
        
        now failed with
        
        > Error: Failed to execute 'importScripts' on 'WorkerGlobalScope': The URL 'example.js' is invalid.
        
        on Chrome 127.)
        
        Change-Id: I9f9b43d501a7b5d933c8506debdebe67ff1b5795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172325
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-23  Pierre F  <fpy@bger.ch>  [50fab30736a47754adf7d7df029551af5d4a6638]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3caa53e99709b7099611b67cf73e9bdbd8801ea
          - more (simple) regex examples + fix note on paragraph limitation. tdf#38261, tdf#159607
            
            Change-Id: Ib96d4d8a4cef38bd90e33672f0d7c4445b2cd2fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171538
            Tested-by: Jenkins
            Reviewed-by: Pierre F <fpy@bger.ch>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c25bc0c046d176eb4221dc2acb42563b62eb9454]

        make joinThreadsIfIdle return false if it cannot join
        
        Change-Id: I52e22bf5e68809d6787d2d135b6a35384cf79391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168785
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit c7ff8768db58aaee5ce0acbabe97faeaf450f017)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172329
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a5c998d4cdfd54ba65b93318292dab542beaabd]

        allow an exemption to be made for a specific host
        
        Change-Id: Ie423df7839e793a9c07561efb56d5649876947ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168826
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172328
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [31d2e0e7b431285b11455a321845371411c09795]

        map LO_CERTIFICATE_AUTHORITY_PATH to CURLOPT_CAPATH
        
        curl has both CURLOPT_CAINFO for the single-file collection
        of certificates case and CURLOPT_CAPATH for the multi-file
        exploder view of certificates, this adds support to
        use CURLOPT_CAPATH as well as CURLOPT_CAINFO
        
        Change-Id: I28163bbe81fa389eea70ef1289ed04a50a029c5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168825
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Hubert Figuière  <hub@collabora.com>  [ff3a316f8865ea0ba118b258ca9391abcfa3d5ae]

        LOKit: Enable the Execute Interaction command for Impress
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I5b3b3cc8e1e8c0ad3ec933ea9047da3367583767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172088
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit ad124b2de2bcbb6a093b551633fc7e50f4cecfaf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172190
        Tested-by: Jenkins

2024-08-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [659842c2048aad10e7793f5e80fdc4956d9274d3]

        tdf#162586: Check GetUpper is not nullptr
        
        Change-Id: I3d56edda8de16a2d04d8f902d3db340fc191a506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172322
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5dbc995f73da45ad99b95bc3119c75451b2c415d]

        Emscritpen: Use WorkerGlobalScope.importScripts
        
        Change-Id: I19be38564aca4fdd3d827657055b41a867582ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172315
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [978f0071425e89d21225bdd2976abe15e964b6c1]

        tdf#158556 make SvxLineSpacingItem hashable
        
        Change-Id: I19d88a35332ab3aa07e88085742d92cb48d5ff79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a648f23ecb67fbdbd29ac7a1d81db19f769ebb3]

        tdf#158556 make SwFormatDrop hashable
        
        Change-Id: I87508693abce928c9dfd22fd888e2aa441631f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8a5f0b15ed4ab4b61fb982d85e39939a23ba771]

        select first entry in dropdown by default
        
        Change-Id: I423c02ebf53b6ed237587b534a713dd6509f7b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172320
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9594ac00a65c0a55286900265eadaa997e3f6ec]

        tdf#158556 make SwGammaGrf hashable
        
        Change-Id: Ia65013ffee3ef72b61331fd3b4f7ab0b913bf01e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172304
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [01d183d2290668c310d592bf2e4c298ddcfb10b4]

        tdf#158556 make SvxBrushItem hashable
        
        Change-Id: I82794dbf004781a86c8443b72263528167fe0359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172316
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c4b613cda515e678a914a9bde4af3cc557532a6]

        tdf#158556 make SvxColorItem hashable
        
        Change-Id: I39cfd46a8255b6231b0215ff22f4ac5f77fa38e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-23  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [8bdddee0897034976bbbea57eedf4c7611228d5d]

        CairoSDPR: Adapt WrongSpell Primitive to View-Independent
        
        Change-Id: If739dd9f28f56874978c7b3a76e1234e5f430c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172319
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf0ba2bc29a351245f248802a8c04adb2428eb6e]

        Resolves: tdf#162015 don't expand combobox when grid expands
        
        Change-Id: I4157e52131257cf62e2e2224d3f2276a0831c7ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172318
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-23  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [54374c97b86730d97f5ad622dc88c0798af4be1c]

        tdf#159895 sw: fix "Stack empty" error in tagged PDF export
        
        Change-Id: I8a2e0d51d1cfe6d4b517f193c73e512600638cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172302
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-08-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [3b4a8406c2e7f4f6a7ac43e192fdb8ef266d4b6d]

        tdf#161709 Remove extra space between cursor and cell edges
        
        Change-Id: Icfdb88928b0d9f076a3c6190c241825ef918d5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172266
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f43404759d8bcce7066bd8672dd4205b9e3e98bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd929fb9dafbfece153cb93bbb94448feeab8cd3
          - tdf#162529 CLI graphic export option Help page
            
            Change-Id: Id335318a28c2d733f01f3e2248f30d3ef4c1060e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172285
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-23  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bee09884a65013ab01584c71f70b37c99900a1bf]

        tdf#140394 - Manage names dialog: check if formula is a valid print range
        
        Change-Id: I65572967987fcc2ef0cdf840eb1ba042b4f298e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164434
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [a111a1eff73b141c28b5ab87715eed62696f91a3]

        tdf#158556 make SwFormatPageDesc hashable
        
        Change-Id: I609c63ec22c94ce9d5ccc10e9608787c5189937b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172305
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d591ae8ac55195762e155f93c39c046a4bcba82]

        Fix typo
        
        Change-Id: I7db2f31467f79c05595cf0ac2fa8b1d457a4cc3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172313
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f7d98ec5e7f90433875b1cb251873a2c951ab6f1]

        Update git submodules
        
        * Update translations from branch 'master'
          to d2facdfc4eb8ce6be28a4db5125f163a99b68bea
          - update translations for 24.8.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I646d58ad1259cabceb12542d1e4bd4e829f2249e
            
2024-08-23  Julien Nabet  <serval2412@yahoo.fr>  [6e51d65c3d8031967727092ee2f48b8577db9b85]

        Silence some bogus -Werror=array-bounds etc. also with GCC 14 and -std=c++20
        
        Change-Id: If7a3e0d7536642ae672ba6096183bb8413b36a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172310
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-23  Julien Nabet  <serval2412@yahoo.fr>  [73884e28faeb457c01b80051a701c073112ad564]

        -Werror=maybe-uninitialized in sfx2
        
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx: In member function ‘void SfxSplitWindow::InsertWindow(SfxDockingWindow*, const Size&)’:
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:462:23: error: ‘nL’ may be used uninitialized [-Werror=maybe-uninitialized]
          462 |                 nLine = static_cast<short>(nL);
              |                 ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:433:16: note: ‘nL’ was declared here
          433 |     sal_uInt16 nL;
              |                ^~
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx: In member function ‘void SfxSplitWindow::MoveWindow(SfxDockingWindow*, const Size&, sal_uInt16, sal_uInt16, bool)’:
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:552:21: error: ‘nL’ may be used uninitialized [-Werror=maybe-uninitialized]
          552 |     if ( nLine > nL && GetItemCount( GetItemId( nL ) ) == 1 )
              |          ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libo_perf/sfx2/source/dialog/splitwin.cxx:548:16: note: ‘nL’ was declared here
          548 |     sal_uInt16 nL, nP;
              |                ^~
        
        Change-Id: I816ec49fe2c63e4f448ae83251d3a24b08383903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172306
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [25541338ae51435b9c23fe69cfa4219096e2dd50]

        tdf#158556 make SfxGrabBagItem hashable
        
        Change-Id: I0af373e9c5c93a82eb37437ac365677700d45853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172311
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-23  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d613252fd9ecebc90d0ecf6afbfdab18eec4e808]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b27934a3330f48716085cacbc2054a605675f2a5
          - tdf#162559 Clarify conditional formatting example
            
            Change-Id: Ia87562a5e74aa18cc95b0d769d1ed9800aac643f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172309
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [833d842e0909b9ef461c9db7ea05c91202fe1dcd]

        cid#1202814 Overflowed return value
        
        Change-Id: I9f87efa1eabd3ed2bb4fdfcc66de405841d5fcc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172308
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8aa643a07c2280a22c12adee4e358e100028d20]

        Resolves: tdf#157486 measure with font used in the csv grid
        
        and not with the font of the parent widget
        
        Change-Id: Idddf63022a5f838c73c04735829335a3056c82af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2b6a04f37e24e47984eb2539771a86cf7b08d4b]

        tdf#158556 make SvxFirstLineIndentItem hashable
        
        Change-Id: Ic23d0956b87eefb575696dad7af775a37cd50b10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-23  Julien Nabet  <serval2412@yahoo.fr>  [4d8fdb32e7f054f2d8704121a60f830524fe7796]

        vcl: WhitespaceToSpace() spurious -Werror=maybe-uninitialized (gcc14)
        
        Change-Id: Ie683c1f8cc8b88da4ca3b26f4621a16f742f03f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172303
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ea61bee5bcca7ad7cb05bc66fdf973c04b3d3396]

        ofz#68994 Timeout on unreasonably narrow header/footer area
        
        Change-Id: I4135609bdb0adf5b6d87dbb81137961ea39cf78f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172298
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Alain Romedenne  <alain.romedenne@libreoffice.org>  [58b5c524e9869e797104efcf1ac835f26d753068]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 192db7f5be7cc894d444f043747b1fd0865e4efc
          - update to make file
            
            Change-Id: I282097ced36b0642bd6dc8debe19a41e29de538d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172269
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba0f68732ed89e11157dc618a697bfeb173c6252]

        tdf#158556 make SvxTextLeftMarginItem hashable
        
        Change-Id: Idc91bf66e8ba050fcd133ef98f8364fbbb2e8efa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172294
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b073da79be064ca026e26629f4b79dd0bfb7e23]

        drop the fuzzer workaround now
        
        Change-Id: I01837d1d5fd0f43d0e29465af985bfa0b619c200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172292
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a02973962f63da4f96009b61bc8584d8ed87f8d]

        don't need to ctor + assign, ctor is enough
        
        Change-Id: I880ec68c907000829b81318fb3bf3eb7ac0109d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172225
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d3817289586d8765e066fee6551b66ddb5d0ab3]

        tdf#158556 improve SvxTabStopItem::hashCode
        
        to provide more discrimination, which means we spend less time in
        operator== when searching the pool
        
        Change-Id: I9beb8218fdd4b4fb3d60ecf6db461ae818d2a9ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172291
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [2318b823732df3820557943e56dd5243381dc558]

        tdf#91739 wina11y: Implement IAccessible2_2::get_relationTargetsOfType
        
        Implement the `IAccessible2_2::get_relationTargetsOfType`
        method [1] in the Windows accessibility bridge.
        
        As described in NVDA issue comment [2], this method is
        the preferred way that NVDA uses to get e.g. the target
        object of the "flowsTo" relation.
        
        With this commit in place, retrieving the next Writer
        paragraph in the NVDA Python console using that relation
        now also works with the fallback code path in NVDA [3]
        dropped in a local build of NVDA:
        
            >>> focus.flowsTo
            <NVDAObjects.Dynamic_SymphonyParagraphSymphonyTextEditableTextWithAutoSelectDetectionIAccessible object at 0x0B8F5890>
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2__2.html#a63f214b322c663caf01d4bb67277f5af
        [2] https://github.com/nvaccess/nvda/issues/4115#issuecomment-2299084993
        [3] https://github.com/nvaccess/nvda/blob/df6bd0770db12ff73905251054d12f01911030dd/source/NVDAObjects/IAccessible/__init__.py#L1861-L1874
        
        Change-Id: Ifcd15527b4a3f5302168942f19248a0ba9a4d306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172258
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [002a29b8dd0d4c61194227e4151b4847480cb8b1]

        tdf#91739 wina11y: Add skeleton IAccessible2_2 implementation
        
        Derive from the `IAccessible2_2` insterface [1] instead of
        directly from (its base interface) `IAccessible2` and
        add dummy implementations for the corresponding methods
        that return `E_NOTIMPL` to indicate that there's no
        real implementation yet.
        
        An actual implementations for at least
        `CMAccessible::get_relationTargetsOfType`
        is planned for a separate upcoming commit.
        
        Support for the interface can be checked e.g.
        in Accerciser's Python console:
        
        Before:
        
            >>> from comInterfaces import IAccessible2Lib as IA2
            >>> focus.IAccessibleObject
            <POINTER(IAccessible2) ptr=0x9667f24 at 6841850>
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessible2)
            <POINTER(IAccessible2) ptr=0x9667f24 at 6822120>
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessible2_2)
            Traceback (most recent call last):
              File "<console>", line 1, in <module>
              File "C:\tools\cygwin\home\user\development\git\nvda\.venv\Lib\site-packages\comtypes\__init__.py", line 831, in QueryInterface
                self.__com_QueryInterface(byref(iid), byref(p))
              File "C:\tools\cygwin\home\user\development\git\nvda\source\monkeyPatches\comtypesMonkeyPatches.py", line 33, in __call__
                return super().__call__(*args, **kwargs)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            _ctypes.COMError: (-2147467262, 'No such interface supported', (None, None, None, 0, None))
        
        With this commit in place:
        
            >>> from comInterfaces import IAccessible2Lib as IA2
            >>> focus.IAccessibleObject
            <POINTER(IAccessible2) ptr=0x988c784 at 6363580>
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessible2)
            <POINTER(IAccessible2) ptr=0x988c784 at c55d7b0>
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessible2_2)
            <POINTER(IAccessible2_2) ptr=0x974d824 at 6847f80>
        
        And calling one of the methods gives a "Not Implemented" COMError
        as expected:
        
            >>> ia2_2 = focus.IAccessibleObject.QueryInterface(IA2.IAccessible2_2)
            >>> ia2_2.attribute("dummy")
            Traceback (most recent call last):
              File "<console>", line 1, in <module>
              File "C:\tools\cygwin\home\user\development\git\nvda\.venv\Lib\site-packages\comtypes\_memberspec.py", line 482, in __call__
                return self.fget(self.instance, *args)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            _ctypes.COMError: (-2147467263, 'Not implemented', (None, None, None, 0, None))
        
        [1] https://github.com/LinuxA11y/IAccessible2/blob/34f96c2a28f4974ad488703b41599a6c6059a7e0/api/Accessible2_2.idl
        
        Change-Id: I77bed1f27353c4d08229ffe17afee03b813a4d4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172256
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [d38de2e655617c72976e9df327c89fef73abf422]

        wina11y: Explicitly map UNO to IA2 relation type
        
        Use switch/case to explicitly map from UNO's
        `AccessibleRelationType` to the IAccessible2 relation
        type strings, instead of implicitly using the integer
        values of the `AccessibleRelationType` as indices into
        a map.
        
        Let the caller allocate the string to return.
        
        Use `sal_Int16` for the `AccessibleRelationType` param
        to match the type of the actual integer values.
        
        Change-Id: I8c094d763ca602131a578f20719d00cad53088d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172257
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [408cf7e91bba3c727d48ade8b587976f1a1c82b7]

        wina11y: Drop misleading comment
        
        The methods have actual implementations, not just empty dummy
        implementations by now, so this
        
            // These methods only declare here, and their implementation bodies are empty now.
        
        is misleading, maybe was true in an earlier stage of the process
        of implementing IAccessible2 support?
        
        Change-Id: I4a50f7199e18766947322d040cac52c0585c2567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-23  Heiko Tietze  <tietze.heiko@gmail.com>  [75440a7694ab0c996593132df11f6b1bc8631a78]

        Make the Themes category available in tight additions
        
        Change-Id: I45b6d59f49dab1b07f3795f7b74000f0a0bcff7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172260
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e1a4cdb3564c38ac1b75cc076c6762369e79137c]

        cid#1555847 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555851 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I826dbd7810398bf60be64702f11b912200f16b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e241c2babf3ad705619a120ffc71e475ce7bb7a]

        tdf#158556 make SvxULSpaceItem hashable
        
        Change-Id: I381379bb4be4e27cb8af32a77505dfbb357dd720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172288
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [086fd5d0de83e5dbff8b69ed86b85274d9fa1c7a]

        tdf#158556 make SfxInt16Item hashable
        
        Change-Id: Id4e6feb4d0072a204d68e5dc834c6828221ea617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc37b184eeaecee2f4d1d5cc7d6d032e59802cae]

        tdf#158556 make SvxBoxItem hashable
        
        Change-Id: I33557df66341ec0d201b66f97ed33c1c61155d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172262
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-22  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [13366d4951bd4ed92cdeed3c8fdeb1ab0543a3db]

        CairoSDPR: Add support for SVG Gradient direct rendering
        
        Change-Id: I7fb1c885e46a23e999ea4c98a73d3d526a2923e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172245
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c06eee519d8a235385b4910d9ec96e5492dd0e9b]

        crashtesting: crash on hyphenation of ooo56629-9.odt
        
        a problem I think since:
        
        commit b5e275f47a54bd7fee39dad516a433fde5be872d
        CommitDate: Fri Jan 19 17:37:41 2024 +0100
        
            tdf#106733 sw: implement CharNoHyphenation
        
        Change-Id: Ic49c136019e93f79818bec7811317bb4f37d6ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b8292342f53bf0f5d9ce3bc729078fb5ed49b9d]

        update comment to refer to 'GetLangOfChar' intead of 'GetLang'
        
        since:
        
        commit e621b1cda4de9c0765e489a7c80642dd1e819f25
        CommitDate: Fri Jun 8 21:51:32 2018 +0200
        
            sw_redlinehide: add SwTextFrame::GetLangOfChar()
        
        Change-Id: I23264cee245e4698cf5ce111bb4ddafc916ca5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172286
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0b49ac534a532b00bee69e96c4e9bc352fc82c4e]

        tdf#158556 make SvxGrfCrop hashable
        
        Change-Id: I30c8f44156a05519dc2f6db59734013e217c91b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172261
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ceec55249ed454b61a342358935d8b254539ff73]

        cid#1607844 Overflowed integer argument
        
        Change-Id: If6fc59a827983840c27701382c201ee16e690472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172254
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Regina Henschel  <rb.henschel@t-online.de>  [fcccd6bf9feb46feb14a07aa22de5f9ea52d394c]

        tdf#153421 On Windows exclude cropmarkers.svg from scaling
        
        The file cropmarkers.svg is used to create individual crop markers.
        That methods expects a certain, fixed size in unit pixel. The number of
        pixels was wrong on Windows, if display scale is set so large that
        resulting dpi is larger than 120.
        The patch excludes this special file from scaling.
        
        For testing you need to set display scale to larger than 125% in Windows
        (125%*96dpi=120dpi). And remove any existing cropmarkers.png in
        cache/themename_svg/DPI/svx/res/. 'DPI' therein is not your actual dpi
        but the scaling factor from CountDPIScaleFactor.
        
        Change-Id: I6b508e28f2f3782441ad1283cfe85c4bd1588383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172019
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-08-22  Alain Romedenne  <alain.romedenne@libreoffice.org>  [90576177b0723b3e5fc7cada42e9e6e50ddeb60d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fed269e1f9315e50e277c54ffc1053d48385ca9
          - tdf#162470 Fix to If statement syntax diagram
            
            Change-Id: Icafc95df09367a9e7401742630ae06d7ebcc89b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172198
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Reviewed-by: Pierre F <fpy@bger.ch>
            
2024-08-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [c9ee92d38cdb71d9b3fc142fd01a6b391f41b814]

        boost: upgrade to 1_86_0
        
        <https://dev-www.libreoffice.org/src/boost_1_86_0.tar.xz> has been generated (on
        Debian 12) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.86.0/source/boost_1_86_0.tar.bz2
        > $ printf '1bed88e40401b2cb7a1f76d4bab499e352fa4d0c5f31c0dbae64e24d34d7513b boost_1_86_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_86_0.html>
        > boost_1_86_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_86_0.tar.bz2
        > Unpacking boost_1_86_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_86_0.tar.xz ...
        > Cleaning up ...
        > efd6d4ce7e8571ba86f77a30bee2d3dd8dccd306721351464fc6998dd00b0c8c  boost_1_86_0.tar.xz
        > Done.
        
        Change-Id: I9e22d34b55aa1dd483655df011545c1516ae003a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172247
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [14f00ee63fba32ccf1b91e71da6de38b57794a32]

        libcmis: fix build against boost-1.86.0
        
        Based on https://github.com/tdf/libcmis/issues/67
        
        Change-Id: I0de90a423110b03a649bd7b20f7392f3aa5a45c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172246
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Michael Stahl  <michael.stahl@allotropia.de>  [20b8f3922a374378cef7b87ee30cde2ae1d6264e]

        sw: layout: allow table in hidden section to move back
        
        The problem is that a SwTabFrame in a hidden section will never MoveBwd
        because its height is always set to 1 erroneously in
        SwTabFrame::Format() due to some border or so, and thus it doesn't fit.
        
        So prevent Format() from being called by disabling invalidations.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: I25232b31b22b98c852c2f28eefff34f51e088eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172251
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-08-22  Keldin Maldonado (KNM)  <kemaldonado@csumb.edu>  [2c9821d391c243ae83a408163f054d7a7a9a1daa]

        tdf#130924 use SAL_INFO/WARN instead of f/printf
        
        Change-Id: I60ea17f286fd057e8179a14cd682398f2ccac61c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170829
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3446419b22a50a9baa5e57aa3939025b4417d843]

        null deref seen in SdXImpressDocument::getPostIts
        
        Change-Id: Idb222476c6d2a6bb8e3ffea528ec4bed0c869ac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172252
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [873bf8a7544fb1a9969e6a2670cf61645efc71ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aca0c0200340e2e14528cf423e65224c5d3359fe
          - Update 24.8 teasing video on online Help pages
            
            Change-Id: I5ae7cc9aa8ba40b4d9212327817511fe76153866
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172259
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-22  Michael Stahl  <michael.stahl@allotropia.de>  [13495926390ba54fbcd45ec00fbe613b1f2b734b]

        sw: do not paint hidden frames
        
        Table frames in hidden sections may still paint their border lines.
        
        Check that the height (or width, if vertical) is not 0 before painting.
        
        (regression from commit ff7f1b59e22092d8548459e75fe912db852f056f)
        
        Change-Id: I6ace6d6608d5e23ff2f3c5a61d37e3f6da958977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172250
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d29d6b49c42658e3cfe3874af078f1575029ef4f]

        Avoid slicing in operator==
        
        Change-Id: I6f0f1b67dee717d9fa16f4ae9e7b6441d7c5002b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172197
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ab99d91d5ee4b49c6bae7583ba52dae6935ea6a9]

        pMark is the same as *ppMark, so static_cast followed by dynamic_cast
        
        We have already used
        
        static_cast<Fieldmark*>(*ppMark)
        
        when we then use
        
        dynamic_cast<Fieldmark*>(pMark)
        
        so replace both with
        
        static_cast<Fieldmark*>(pMark)
        
        Change-Id: I27334da0a867243d2af87f86711d793e18ec507b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172238
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2d9f8f45be0c9bc5f56864f66a37c3cc60069fe5]

        Emscripten: Experimental -sPROXY_POSIX_SOCKETS support
        
        ...see
        <https://emscripten.org/docs/porting/networking.html#full-posix-sockets-over-websocket-proxy-server>.
        
        This requires
        <https://github.com/stbergmann/emscripten/commit/4aff1f28b88480791236adcc6d5cb2d919ad4bf3>
        "-sPROXY_POSIX_SOCKETS: Add websocket_proxy_poll".  When configured with
        --disable-socketpair (which appears to have no negative consequences),
        external/curl appears to only call poll(2) with socket-related file descriptors,
        so we can use websocket_proxy_poll instead.
        
        The URL on which the websocket_to_posix_proxy process listens must be specified
        as Module.uno_websocket_to_posix_socket_url.
        
        Change-Id: I4ad23098b5bbc0646fa50859c0aeb9870d1cc92a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172243
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [0afb4cfc5ed1e926dfd287007c5a35585584daec]

        tdf#162555: change rtl::Reference creation order
        
        GalleryDrawingModel takes ownership of passed model; so when it
        gets destroyed, the model is destroyed, too. Destroying SdrPage
        tries to set the model modified.
        
        Change-Id: I2f00f21ee8b74711fb62e409351cbdb33abe5f0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172196
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-22  Michael Weghorn  <m.weghorn@posteo.de>  [480281006ff9ea43fe6e9c357909ed55d0011c8f]

        wina11y: Use sal::systools::BStr::newBSTR here, too
        
        As
        
            commit 02c0e5f970dee4d064fcb26b378cbfe6f3a1bc05
            Author: Mike Kaganski <mike.kaganski@collabora.com>
            Date:   Wed Aug 21 13:42:28 2024 +0500
        
                Simplify BSTR construction from OUString a bit
        
        did in other existing code, switch to using
        `sal::systools::BStr::newBSTR` in this case newly
        added in
        
            commit dfd23124096b9428f2f7084a24de032750389c79
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Aug 21 10:16:51 2024 +0100
        
                wina11y: Retrieve default action description on demand
        
        , merged shortly after existing code was adjusted.
        
        Change-Id: Ic27a31ce22410d6d976295336bf97ada3881788b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172236
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [6084a2904d1cb38c47874e260ce0b7ccc7899154]

        Make OleEmbeddedObject locking stricter
        
        This is an attempt to reduce areas that execute with mutex unlocked
        because the called code may deadlock. Also, this copies objects on
        stack before unlocking, using lambdas' own variables.
        
        I hope that it somewhat improves reliability. OTOH, this runs more
        code with lock active, has a potential of new deadlocks, so risky.
        
        Change-Id: I558b7f5f18f63622fed3a9c3978327d0d76fe90d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172237
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b572bf6a716cd0e4da07cb0bcc6a9861077c1895]

        cid#1557276 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I1142fa211526743248afac248b97fbbe40a753ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d4e2135b78015bc739f0f5b238cf184305ebcba]

        read count doesn't need to be a class member
        
        Change-Id: Icac6d1ea5659d875551b7b218fc47235fec34dc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d4cba825b217e4361551b8551cdaf9bc5ef7ca0]

        cid#1608175 Structurally dead code
        
        trivial, no real change here
        
        Change-Id: I0e93412c930d60d94a9e9406579226026f449897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172222
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [df15c207fb583178b5f2beac4580b5906645237b]

        lxml: upgrade to 5.3.0
        
        Downloaded from https://github.com/lxml/lxml/releases/download/lxml-5.3.0/lxml-5.3.0.tar.gz
        
        Change-Id: I39825586d2cbb32f97046719a6ab5cb2b8d0be40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172235
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [53b834fc44abe04bbfd3cdfc844149e233acc645]

        tdf#162004 crash after notes pane loses focus in impress
        
        I cannot reproduce this at all, but from the debugging traces
        supplied it looks like mpTextObj ends up pointing at something
        that has already been freed.
        
        To prevent that, instead of caching mpTextObj, fetch it every
        time we need it.
        
        Change-Id: Ia8000f8f0b65fbe7c4ac4850179708a025af3cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-22  Gülşah Köse  <gulsahkose@collabora.com>  [c00c95aa73144f005a287cb53b4e98db0219c305]

        ONLINE: Insert slide to specific position
        
        Online was appending new slides at the end.
        With this change we can handle position argument.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I8d5ff041b7dc4c4bbe6bcfe43d842f8ca87ae2e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172113
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-08-22  László Németh  <nemeth@numbertext.org>  [6b857398a59d16308d6185d01e003e401439f060]

        tdf#162109 sw smart justify: fix overhanging last line
        
        Last line of justified paragraphs is excluded from justification
        normally, but not in the case, where it fits only with shrinking
        spaces. This line was overhanging because of the missing
        justification and space shrinking.
        
        Regression from commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I83ac8562b46999d7fd676d737bed0b9c141a89b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172228
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [53ac9e0f3ceff4a18929818667bb8aae9c05ad12]

        Make OleEmbeddedObject::GetRidOfComponent safer when releasing lock
        
        Thanks Michael Stahl for the useful advise - see
        https://gerrit.libreoffice.org/c/core/+/171996/comment/4dc20148_5ec861ad/
        
        Change-Id: I16e1876a81a52f291ede49572f012c15d4cd9a6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172233
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d255a8306e7a26476fe11dbdcf38f6cb5665a48b]

        tdf#158556 return 'const Value*' from Sprm::getValue
        
        instead of cloning a fresh object instance, which is not necessary
        most of the time
        
        Change-Id: I3ee1f5952e01a7c6207213522cac9cabb15246d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172211
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0c485676b753ad520f6fdaa83f3c6698fbb7369]

        tdf#158556 map->unordered_map
        
        faster lookups for this cache
        
        Change-Id: I4c0c2da5937bdc0cbcb1041557a8784474d2be0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172209
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-22  Jonathan Clark  <jonathan@libreoffice.org>  [560e5406f3c6e8e6ed0f1c251b6910465266ed8d]

        tdf#153966 vcl: Fix precision loss laying out right-aligned text
        
        Previously, characters would appear to 'fidget' while typing
        right-aligned right-to-left text.
        
        This fix contains the following changes:
        
        - Removed a floating point truncate during right-align positioning.
        - Removed unnecessary repeated multiply-add from the main layout loop.
        
        Change-Id: I2f070efb6a1387db1595b41023bd0f076064afda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172230
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b93c179b44e8b76e036e6fba560325c5cceb7103]

        cid#1608491 silence Overflowed constant
        
        Change-Id: Id0f2c3b40cf0282b393b6d076497dc390708fa75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172220
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [962c76d85bef03fb717914d8eddda9295427614a]

        Allow building against emsdk that uses Emscripten trunk
        
        (see
        <https://github.com/emscripten-core/emsdk/?tab=readme-ov-file#how-do-i-track-the-latest-emscripten-development-with-the-sdk>),
        which has emscripten/main/ instead of upstream/emscripten/
        
        Change-Id: I10dfc7e30cddf8a798cb70104126b45757fcba63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0d424c707a380205f4c6e1530013ac3a3ea66cc]

        tdf#158556 map->unordered_map
        
        Change-Id: If428a51a6eabad2fcaaead4572413754549cc137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [4ac1015b58a676324443de54188c16abf28d642f]

        tdf#91739 wina11y: Ensure IAccessible for relation target exists
        
        When retrieving the `IAccessible` for the relation
        target's `XAccessible` and
        `CMAccessible::get_IAccessibleFromXAccessible` initially
        returns nullptr, insert the a corresponding object
        and retrieve it then.
        
        The same is already done in most places calling
        `CMAccessible::get_IAccessibleFromXAccessible`, e.g.
        `CAccTableCell::get_columnHeaderCells` or
        `CEnumVariant::Next`.
        
        This makes sure that a proper `IAccessible` is
        returned instead of triggering an error if no
        such object has been created yet.
        
        This is the case e.g. for off-screen paragraph
        objects in Writer that can still be accessed
        on the UNO a11y level via the
        `AccessibleRelationType::CONTENT_FLOWS_TO` relation.
        However, when testing with the test docs from tdf#91739,
        the issue even occured much earlier, with on-screen
        paragraphs already that weren't available via the
        FLOWS_TO relation from their preceding paragraphs.
        
        With this commit in place, having NVDA read out
        the whole sample documents using the NVDA + Down shortcut
        works now for the tdf#91739 sample docs, in the same way
        it already does for Orca on Linux.
        
        For more details, see also the previous analysis in
        NVDA ticket [1].
        
        [1] https://github.com/nvaccess/nvda/issues/4115#issuecomment-2299084993
        
        Change-Id: I2ef06c6efa368f10dcf5d917d781dabc8ce9a65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172215
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b55635172405350c8cdfb18737ddd74eb5c2e26a]

        use less exception throwing for flow control
        
        Change-Id: Iaf273c1f54977d4b422a327ffbc1086da991cc4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [b08e52a2f4c179aa0cf990f414bdc797da2cf651]

        wina11y: Drop COM indirection to get other CMAccessible's XAccessible
        
        Instead of having a COM method `CMAccessible::GetUNOInterface`
        to get the `CMAccessible::m_xAccessible` for another
        `CMAccessible` via COM, simply cast the `IMAccessible`
        to `CMAccessible` and access the member directly.
        
        Change-Id: Ic91c6cde3eb1ebb2bfaabdeb0a5e38017233949c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172214
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [e5adf2b514f04e4ec9800ab6cdc5592efea86007]

        wina11y: Clarify + reduce variable scope
        
        In `CMAccessible::GetNavigateChildForDM`:
        
        * reduce scope of local variables and the union
          used only in one of the cases
        * don't reuse the `pChildXAcc` union member
          at the end of the method for something that's
          completely unrelated
        
        Change-Id: I2169bbf5a7af3c806181ab284294514ff68a1506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172213
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [2acf6f42533146888920e2e70ed80fd01b8048dc]

        wina11y: Query XAccessibleAction iface on demand
        
        Despite the
        
            // initially m_xAction and m_xContext are the same object
            // but they may be different once AccObject::UpdateAction() is called?
        
        comment in winaccessibility/source/UAccCOM/MAccessible.h,
        `MAccessible::m_xAction` is supposed to point to the same
        underlying object as `MAccessible::m_xContext`, see
        `AccObject::UpdateAction` (which queries for the
        `XAccessibleAction` interface and sets that).
        
        Simplify this by just querying `MAccessible::m_xContext`
        for the `XAccessibleAction` iface on demand in those
        places where it's needed.
        
        Change-Id: Id3d89213937c2c72a936947da69ca7fddc8f1b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172205
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [e6c471dd7b2738b6575ac533daad33af2d6bbaa7]

        wina11y: Only require action iface for the actual object
        
        Quoting from the `IAccessible::accDoDefaultAction` doc [1]
        for the `varChild` param:
        
        > Specifies whether the default action belongs to the object
        > or one of the object's child elements.
        
        If the default object of a child and not the object itself
        should be triggered, there's no need for the object
        itself to also support actions itself.
        
        Therefore, only perform such a check in the
        `CHILDID_SELF` case.
        
        Also, return `S_FALSE` in case there's no action, as this is
        not a case of "An unknown or generic error occurred.", which
        is the meaning of `E_FAIL` [2].
        
        as other places do
        move that check in `CMAccessible::get_accDefaultAction`, if a child
        object is specified instead of requesting
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-accdodefaultaction
        [2] https://learn.microsoft.com/en-us/windows/win32/winauto/return-values
        
        Change-Id: Idcd3ab8a415e73e496cf027506428518a9f4a203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172184
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [dfd23124096b9428f2f7084a24de032750389c79]

        wina11y: Retrieve default action description on demand
        
        Instead of doing extra work to keep
        `CMAccessible::m_pszActionDescription` up to date,
        move the logic to retrieve the action description
        from the underlying `XAccessibleAction` into
        `CMAccessible::get_accDefaultAction` and do that
        on demand.
        
        This is similar to what was done for the accessible
        description in this commit:
        
            commit fcf4a26275d7503835f9aa23cb94938809840300
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 5 13:41:53 2022 +0000
        
                tdf#146306 wina11y: Retrieve accessible desc on demand
        
        As expected, the example mentioned in the commit
        message of
        
            Change-Id: I5569f70739135172ddb604f1f1bd958e32626ab0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Aug 21 09:49:51 2024 +0100
        
                wina11y: Unify handling to set action description
        
        still behaves the same as without this commit in place.
        
        Change-Id: I7d1ea0ce302df955314c8e46c530cc24d30fcd4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172183
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [525ba5e4d7936dbf4209354dd5a143af93270b95]

        wina11y: Unify handling to set action description
        
        Drop `AccObject::UpdateDefaultAction` and let
        `AccObject::UpdateActionDesc` take care of
        setting the action description for all roles.
        
        It's unclear to me
        
        * why the action description would only be set
          for particular roles
        
        * why `AccObject::UpdateActionDesc` would call
          `AccObject::UpdateDefaultAction` for particular
          roles if it was basically setting the description
          the same way that `AccObject::UpdateActionDesc`
          does directly for other roles (except for
          `AccObject::UpdateDefaultAction` not checking
          that there's at least one action).
        
        Also simplify the code a bit while at it.
        
        Testing with the "Don't Save" button in the "Save Document?"
        dialog seen when pressing Alt+F4 with a modified Writer doc
        gives the expected result in NVDA's Python console:
        
            >>> focus.role
            <Role.BUTTON: 9>
            >>> focus.name
            'Don’t Save'
            >>> focus.IAccessibleActionObject.nActions()
            1
            >>> focus.IAccessibleActionObject.description(0)
            'press'
        
        If any particular reason for not setting the action description
        for particular roles should show up in the future, they can
        still be excluded in one central place now.
        
        Change-Id: I5569f70739135172ddb604f1f1bd958e32626ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172182
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [0c7a5e6f419a679afef35cb8b3f203eae9e6231c]

        wina11y: Drop AccObjectWinManager::GetRole
        
        For the only in `AccObjectWinManager::InsertAccObj`,
        there's already a reference to the `XAccessibleContext`,
        so just call `XAccessibleContext::getAccessibleRole`
        directly.
        
        Change-Id: I9e0a96d67ac8550b4988de6c3cefc8d6e0b319ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172181
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [2eb96649c9430256e37fc64fd731831d556894ea]

        wina11y: Drop extra check in AccObjectWinManager::InsertAccObj
        
        The `AccObject` ctor asserts that `AccObject::m_pIMAcc`
        is non-null, so there's no need to check here again.
        
        Change-Id: Ieb80dfa4f7229b63dbf53ed77ae54f8d4b1f5211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172180
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [ad1e6a99fc3b258b5c8d0ed99a82cdccd8eaae4e]

        wina11y: Consistently assert COM obj creation succeeds
        
        The `AccObject` ctor already has an assert
        that creating the COM object succeeded,
        so be consistent and drop additional checks still
        handling the theoretical case that it might have failed
        for some reason. (Running out of memory could be one,
        but we don't handle that case in other places that construct
        simple objects, e.g. using the `new` expression, either.)
        
        Change-Id: Ic71ca8a256f1e224f0050c2ee9b039d8823e577a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172179
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [ca546a00ffdd66d2a6f1f9d32474a6fc98d4e6e2]

        wina11y: Add missing include in acccommon.h
        
        This makes sure that typedefs like `REFGUID` and `LONG` are
        known and can e.g. be processed by Qt Creator's code model.
        
        The missing include was not causing build problems because
        the source files including acccommon.h include stdafx.h
        first themselves.
        
        Change-Id: Ifd93cdc263471314f6ed777ba71b15f2bff35417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172178
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [114e827c883896167672597d9b4ad5569c80fe4b]

        wina11y: Drop AccObject::ImplInitializeCreateObj
        
        As the method name and comment suggests, this method
        was doing more in the past, but that's no more the case.
        
        The only thing it does is doing an assert, but
        there's no need to have a separate method for this,
        so just do that right away in the (so far) only caller.
        
        Change-Id: Ief41c8d4ec350622eb043340a4b0bd1079d337a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172177
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e13ec6c0f447e9699b3b46e0d896c3ec2920979c]

        tdf#162258 - fix accessibility check sidebar deck is too wide
        
        Regression from commit: 33ea719d6c6ad23dfca088853d95d5688782da2d
        (tdf#157233 - A11y: Add global Accessibility check options for)
        
        Change-Id: Ia6cf7d9e08488867c7e2dc4f89dfc417a950dbc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172208
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-08-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5a8171415c29f101865f762cbe855fe71a414df3]

        external/freetype: Enabling debug logging only works for DISABLE_DYNLOADING
        
        Change-Id: I603d3fe9f34925997f847f91db8266beeb944cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172206
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-21  Mike Kaganski  <mike.kaganski@collabora.com>  [d5da67752e8adab792ed43f072b3d553bd3b0272]

        Simplify a bit
        
        Change-Id: I35ca6c1981bff2e7b91f7c1900fd3bdf3f98ef3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172174
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [f0575619d1c30131b7959ee8fc35eb57e5cf12b2]

        these can be static
        
        Change-Id: Ia4ecf6dfb6703e2e601c1c70ab08ce574374da4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172168
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0ad3fe411de2056640f432ab87b4d4ad63fcb43]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I007c8ee7d5b6d752346f670a7b650d35afb27d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172156
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-21  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [38f6f44a2cc854e652c09bbd7ee3511b5fed3f8e]

        tdf#162283 PPT export: fix regression...
        
        ...was made by: Iefb9d97e0eb10a04c39b515b11e549aeb7be8f25
        
        This regression occurred because there is a feature in MSO that allows
        the shape of a placeholder to be changed. In this case, the placeholder
        is converted into a custom shape after the import and saving custom shape from .pptx to .ppt didn't work.
        
        Change-Id: I85305b65742da8b4966d4956b9141c59b4563973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172091
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d78a07573eac1960c8c6c736e6c05bf304f96cb1]

        tdf#158556 make SvxTabStopItem hashable
        
        speeds up searching for it in the item pool
        
        Change-Id: I37e8889e41d63a41e1a4bf2a35b4aa303745e15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172171
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a5b52f8bcb7b5d4eb2fc4ba6560ba1e88c36503]

        nss: 3.101.2 is the ESR release
        
        See https://gerrit.libreoffice.org/c/core/+/171425
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_101_2_RTM/src/nss-3.101.2-with-nspr-4.35.tar.gz
        
        Change-Id: I88ab41039ec957ab6230072544d8365a5271ca95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172158
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fc6e0d8a39f38e339668d382890ff02c205ed92e]

        Fix typo
        
        Change-Id: I85261133e191b40de21fd25e9c34351f71a1a219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172176
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-21  Mike Kaganski  <mike.kaganski@collabora.com>  [02c0e5f970dee4d064fcb26b378cbfe6f3a1bc05]

        Simplify BSTR construction from OUString a bit
        
        Use the known string length into account (and I definitely like to
        not rely on the undocumented implementation detail that OUString is
        null-terminated).
        
        Change-Id: I0e7478d25e802f8f8e31f02cf8d77613c1325bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172170
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [02e2870c86a00380549266f944c9218187a002ec]

        sw: 0.03928 -> 0.04045
        
        According to https://www.w3.org/TR/WCAG21/#dfn-relative-luminance:
        "Before May 2021 the value of 0.04045 in the definition was different
        (0.03928). It was taken from an older version of the specification and
        has been updated."
        
        Change-Id: I7cd7c0ee3e0d04795c7db9d93053e159e011fc62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172146
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e180d2a8fda78d1373dc3ecec4bd69992bc4337c]

        Emscripten: Enable the WebDAV UCP
        
        *  Which also requires external/curl.  But implicitly use --without-gssapi,
        checking for it in configure.ac would fail with
        
        > configure: error: could not find function 'gss_init_sec_context' required for GSSAPI
        
        And building ExternalProject_curl needs to see the -pthread from
        gb_EMSCRIPTEN_CPPFLAGS, otherwise linking Executable_soffice_bin would fail with
        
        > wasm-ld: error: --shared-memory is disallowed by libcurl_la-easy.o because it was not compiled with 'atomics' or 'bulk-memory' features.
        
        *  By default, GetCABundleFile in include/systools/opensslinit.hxx will fail
        now.  (But to make https work, applications could bring along their own such
        file in the Emscripten FS, in one of the places where GetCABundleFile checks for
        it.)  So, for Emscripten only, make failure of GetCABundleFile non-fatal in
        InitCurl_easy.
        
        *  Some code in sw was erroneously hidden behind !ENABLE_WASM_STRIP_EXTRA (off
        by default for Emscripten), but is needed with HAVE_FEATURE_CURL.
        
        *  See <https://emscripten.org/docs/porting/networking.html> for how to actually
        use networking in an Emscripten application.
        
        Change-Id: I2bbe9f3fd0e20143e18eb1e8104568b1c7a304de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172167
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-21  Adam Seskunas  <adamseskunas@gmail.com>  [b20e7aaac5b35972e0b7c40a34841417e5514824]

        Move testTdf160301 from ww8export to ww8import
        
        testTdf160301 only tests importing of .doc, so move to ww8import
        
        Change-Id: Ic97d758dcff5e6c6e184f994ce02031f6f700521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172160
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [6d137da1038a80736f7d60d62bf3eb947f3d34a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d16cddc3602213ef22fc4f778f632d43c89d8304
          - Apply english grammar
            
            Change-Id: Ibe65885931c5dca006a298eeef9b5b383137b2fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172186
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ba45589492c0fe542b75ebe5294fc1d3f27b9bb]

        cid#1555812 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556056 COPY_INSTEAD_OF_MOVE
        cid#1556907 COPY_INSTEAD_OF_MOVE
        cid#1556957 COPY_INSTEAD_OF_MOVE
        cid#1556970 COPY_INSTEAD_OF_MOVE
        cid#1607095 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I51112b3a63b8e9333e3eaaeb55b764e6c449a5ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172117
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [b5701f5b3d2805c8b9fb7a21e1e3763ebc7314af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7e13a37beb1d13ac072f88b0b85607677ab6d67e
          - Missing link to BASIC programming guide in wiki
            
            Change-Id: I7f552389440c2eb006197fefb54d1cee32d5f053
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172185
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [c179bf9ae8d0d27d78b72c026256a56b5458d973]

        wina11y: Drop superfluous check in CAccTable::get_accessibleAt
        
        There's already a
        
                if(!pRAcc.is())
                {
                    *accessible = nullptr;
                    return E_FAIL;
                }
        
        further up in that method, so no need to check again.
        
        Change-Id: Ifb855dce067b3bff5a654917e79817da72e156be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172153
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [a10a99b0c6693b448d388793e451a49ed8c8b795]

        wina11y: Retrieve a11y name on demand
        
        Instead of doing extra bookkeeping to keep
        `CMAccessible::m_pszName` as a class member up
        to date with the current value of the accessible
        name, just retrieve the current a11y name directly
        from the underlying `XAccessible` when it is requested
        via the IAccessible2 API in `CMAccessible::get_accName`.
        
        This is basically the accessible name equivalent of the
        the following commit that did similarly for the
        accessible description:
        
            commit fcf4a26275d7503835f9aa23cb94938809840300
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 5 13:41:53 2022 +0000
        
                tdf#146306 wina11y: Retrieve accessible desc on demand
        
                Adapt 'MAccessible::get_accDescription' to directly
                retrieve the accessible description on demand via the
                corresponding XAccessible, rather than keeping
                track of it in a class member.
        
                This simplifies the handling and makes it
                unnecessary to "manually" update the description
                on 'accessibility::AccessibleEventId::DESCRIPTION_CHANGED'
                events, since the new value will
                be queried next time it is needed anyway.
        
                This also fixes the problem that a significant
                amount of time was spent generating accessible
                descriptions for all newly inserted a11y objects when
                entering values into Calc cells with the NVDA
                screen reader in use, resulting in several
                seconds of delay.
        
                Querying up-to-date values from the underlying
                UNO interfaces on demand instead of doing extra
                manual bookkeeping in the winaccessibility code
                may be possible for more a11y attributes in addition
                to the accessible description handled in this commit,
                but each one will have to be looked at separately.
        
        This also allows to drop the
        `AccContainerEventListener::HandleNameChangedEvent` and
        `AccObjectContainerEventListener::HandleStateChangedEvent`
        overrides of the base class implementations unnecessary,
        as the only thing they did in addition was updating the
        a11y name.
        
        This commit has no effect on events sent on the platform
        layer, those are still sent as before to notify about the
        name change.
        
        Change-Id: I4d1df1d0b73ce963cdaec91d642ff5bbf2b371bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172148
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [efb4ad90713bcc728a258a87e8ff294f67248cc4]

        wina11y: Query new a11y name instead of passing it around
        
        Drop `AccObject::SetName` et al. taking a string param
        with the new a11y name to set in favor of using
        `AccObject::UpdateName` et al. that updates the a11y name
        by querying the current value from the underlying
        `XAccessible`.
        
        This makes it unnecessary to pass the new value
        around when a `AccessibleEventId::NAME_CHANGED`
        event is received, and the new name has to
        already be set on the a11y object at the point in
        time that the event is received.
        
        Change-Id: I1510bde22ef6d1271f6aeaffe245441cd9e11f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172145
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [a7568b0555b2c616e7cab857400ff6d7911f290d]

        wina11y: Use UNKNOWN as fallback for a11y role
        
        Let `AccEventListener::GetRole` return
        `AccessibleRole::UNKNOWN` in case there's no
        accessible object instead of -1.
        
        The latter doesn't map to any a11y role.
        
        This doesn't make any difference in practice right now,
        as none of the callers explicitly handles the UNKNOWN
        role either, but could e.g. simplify switching
        `AccessibleRole` from an integer type to an enum in the
        future.
        
        Change-Id: I8b0d78642621ce997d55d12905e31e7978962ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172124
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [ead6cb42592880012ab12aada57cf1165ef084e4]

        wina11y: Drop special a11y name handling for paragraph/block quote
        
        The ARIA spec prohibits setting an a11y name for paragraphs [1],
        which may have been the reason why an empty name was always
        explicitly set in `AccObject::UpdateName`, and that was just
        extended to apply for the block quote role when that new role
        was added in
        
            commit f44eae4912e8f2ba34d93a71a609473df976a2cb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 27 14:53:59 2023 +0200
        
                tdf#135586 a11y: Add a new BLOCK_QUOTE a11y role
        
        Wile it makes sense to always report an empty a11y
        name for paragraphs, ensuring that is not the task of the
        platform a11y bridge, but it should be done properly in
        the underlying `XAccessibleContext` implementation already,
        as this is not specific to Windows/IAccessible2.
        
        At least paragraphs in Writer already report an empty
        a11y name. If anything else doesn't, that should be
        fixed there.
        
        [1] https://w3c.github.io/aria/#paragraph
        
        Change-Id: I7ffd42acc02fc41cf73174e60c32e8938161c4d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172123
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [8370d441cd0719e8580937aca3c151d2eb1b3d70]

        wina11y: Don't set a11y name that gets overwritten right away
        
        It's unclear to me why an a11y object of a TEXT_FRAME
        role with a SCROLL_PANE parent should be treated specially
        and use the a11y name of its parent.
        
        But the a11y name set this way is unconditionally overwritten
        right away in the lines below anyway.
        
        Therefore, just drop the special handling.
        
        Change-Id: I3cfe63e0882803524f51fe760d38880b30105317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172122
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [d02d8cf8957c08f479f612ffe3f731b8be46219c]

        wina11y: Just use ref instead of having extra pointer var
        
        The extra null check for the pointer is also redundant,
        as there is a check for `xContext.is()` just above it.
        
        Change-Id: I9c0d0ab95c3031d8560506691e78e7994c5dce95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172121
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [353436b265d5e734a3f1a7d5e08d73c88dafb03d]

        wina11y: Drop duplicate check for a11y context
        
        The first thing that
        `AccTopWindowListener::AddAllListeners` does is to
        retrieve the accessible context and it returns if
        it's not valid, so there's no need to do check that
        already before calling the method.
        
        Change-Id: Ie825a9694b5c94bc9f9f2917ba5ae85e50670a66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172120
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [04b526f17ac60cbd4a3b743be335606ee4e7994e]

        wina11y: Drop extra pointer vars, just use the ref
        
        Change-Id: If373619e6b8203d2f2f88fac4d834d44cb6e346d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172119
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [59c7678a52dcbc9b6413784ba5e8078f9e304b30]

        wina11y: Don't use "m" prefix for local vars
        
        The "m" prefix is for class members. Using it for
        local variable names is misleading.
        
        Change-Id: I79d62f59ac1093fcd9160ea4d8ae097d32eb40d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172118
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [98b4b2f4fa5bfc5a78a34847aeb274089e74f738]

        wina11y: Drop commented code and duplicate comment
        
        Change-Id: I192fe62a666c86654b0352d202675c33a72bf89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172152
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [d1843de829567e4216c782d241adb3de13eaea7a]

        wina11y: Drop unnecessary try/catch
        
        Returning S_OK certainly won't throw.
        
        Change-Id: Ided99c26efb42cba21889890fa37d652d1e118ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172151
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Michael Weghorn  <m.weghorn@posteo.de>  [8fd7eed3020841f4094e6d4882a03ad220f16794]

        wina11y: clang-format CAccRelation
        
        This in particular ensures that try and catch blocks
        are indented by an additional indentation level
        as expected, increasing readability.
        
        Change-Id: Ic2c3c1500c07df75e3b606ab957a44b220f52194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172150
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [399ed986e5a15988c8b08dc715ad698ef3f4fe83]

        Clean up conditions in Module_unoidl
        
        unoidl-check and unoidl-write are needed during the build.
        unoidl-read and unoidl-write are part of the SDK.
        
        Change-Id: I82fc79a09524fa14638b4d2daeafeeb024f1fd66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172159
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [85e4dc15d09dc3193870041b2814263971a27791]

        A more precise SAL_WARN message
        
        Change-Id: I37d61f33c7b7cccde70b49d8926d21586e006964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172155
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b88b5f53a2e5a40a673bbb587571cc068cae6d6e]

        More useful to have an EMSCRIPTEN_EXTRA_SOFFICE_PRE_JS
        
        ...than an EMSCRIPTEN_EXTRA_SOFFICE_POST_JS.  That way, we can e.g. set up
        Module.arguments there.
        
        Change-Id: I4990ab6daac2f74326ab2ee9508828f1b79bceb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172154
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce2a5f6bc80a7a206051d7a81fcc6e87f1fab972]

        tdf#162459 Validation list is always displayed in ascending order
        
        Revert 
        commit 639a1f39dd45a6ff71eec2c073a84a9f181e350f.
        optimise GetDataEntries a little
        
        Change-Id: I6a08ddfaebea7c8f7a00f01d0237f75dae9abd98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172129
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [370398910a23cf313c94a7ac279da94bce9e4de8]

        external/freetype: Enable debug logging support for --enable-dbgutil
        
        Change-Id: I4f605166f5a6e0b2bd9196472db9ea3ad400d44c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172108
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0aaf0a624859b7f04717b0e8f70476658dd010fe]

        doesn't look safe to move this dxarray
        
        given the use of rDXArray after move
        .
        Change-Id: I27ed26228bb4a43b6dcb6edb4586e0727389dcbb
        
        Change-Id: I66e0a6dd1837e598b620692b405bb32f79470e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172116
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10b662b8bc0b42303df567603455ab92549284ce]

        cid#1557276 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556657 COPY_INSTEAD_OF_MOVE
        cid#1556654 COPY_INSTEAD_OF_MOVE
        cid#1556397 COPY_INSTEAD_OF_MOVE
        cid#1556339 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I20be9764c327ebda9beeb62b54c399998180bfab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-20  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [b3c7c30ca1e9102be7246d97792147997b5696a2]

        CairoSDPR: Finetuning some Cairo-Values
        
        Experimented with painting 'problematic' bitmaps
        e.g. RGBA 1xN or Nx1 pixels -> Cairo paints out of
        bounds (?), so had to clip that. For more info,
        see added code comments.
        
        Change-Id: I4dcd488e5e0c692e236136a216ad7b460d681233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172112
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-20  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [dbaf35467b4d07485bdcc4d7eb8e8aac1ae3a073]

        tdf#143148 Use pragma once in svx
        
        Change-Id: I22a1e384b6d6a90e412c9c0c36785f0cba73a90c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172054
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [20b16048236598880dc94bac146079426ae8f309]

        tdf#162528: handle exceptions from JSON parser in GraphicExporter
        
        Similar to commit 218695f947dfecaa92209adf0c5572b99f0c021f "tdf#150846:
        FilterOptions in descriptor could come from import filter", 2022-09-21
        
        Change-Id: I3123bb2c136d1bc5545d0412eb1db5e5fd9c91b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172105
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-20  Michael Weghorn  <m.weghorn@posteo.de>  [81a9a5c5d24cf6825600d47cd5877f98e35d45b0]

        emscripten: Show actual Emscripten version in "About"
        
        Display the actual Emscripten version instead of a literal
        "__EMSCRIPTEN_major__.__EMSCRIPTEN_minor__.__EMSCRIPTEN_tiny__"
        for the environment information in "Help" -> "About LibreOfficeDev".
        
        Change-Id: I6a29e8c323e8874e89201b2cce7c28d2218fc8cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172107
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef8fd1a72a6b45bfb046efad47e61c11e8277e4a]

        tdf#158556 no need to create another cursor here
        
        we already have one for the insertion point
        
        Shaves 2% off load time
        
        Change-Id: I86d2d54c0eda3b74fde8929f075f744da4a083f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [17aae4ddab1aad624779347d0fb914f635e7a4c7]

        tdf#158556 avoid dynamic_cast
        
        reduces load time by 2%
        
        Change-Id: I8b31257baacd49657cccf7cc6bd04408581803c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172102
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3e76f5e7524dc93554b7575ce0bf12b47b9b38ce]

        cid#1608021 silence Overflowed integer argument
        
        Change-Id: Icba77c62877c552b1754dbe4e408e2d0a44d8e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-20  Michael Weghorn  <m.weghorn@posteo.de>  [42e517ca2fbf3cbec7500ff0b8e0efe19d0b7adf]

        qt/kf: Drop obsolete -DQT_CLEAN_NAMESPACE -DQT_THREAD_SUPPORT
        
        `QT_CLEAN_NAMESPACE` and `QT_THREAD_SUPPORT` seem to
        have long been dropped from Qt (are only seen in Qt 3 changelogs
        in current qtbase git dev history) and the most likely explanation
        why they were still defined for the Qt based VCL plugins seems
        to be that they were just copied over from the KDE 3 support
        that was dropped in
        
            commit 72699595aaa3ecb8975050b6dfc6fde437770493
            Date:   Wed Sep 2 14:37:23 2015 +0200
        
                remove KDE3 support, --enable-kde and --enable-kdeab
        
        Drop the obsolete defines for qt5, qt6, kf5 and kf6.
        
        Change-Id: I052e5e082455150c04e57d3be2e23b6245ad940d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172062
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-20  Heiko Tietze  <tietze.heiko@gmail.com>  [64ae1fd48ad7c8c672b78622a4f43b52e3e7f307]

        Resolves tdf#143848 - Adjust boundary color for dark mode
        
        TABLEBOUNDARIES and WRITERSECTIONBOUNDARIES now visible on dark backgrounds
        
        Change-Id: I25bad39e503665cef486f197bbeaa34374f22c5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172096
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [a27a5dda1cb92b0eb46f41dfad596e34988737cd]

        Do not try to notify, if the thread is already killed
        
        On a particular system, I see unit tests reliably hung at the exit time
        (at a DLL unload), when it waits indefinitely in notify_all. It is the
        only thread in the process left; TimerManager thread was likely killed
        by that time.
        
        This is the call stack of the hung state:
        
         ntdll.dll!ZwReleaseKeyedEvent()
         ntdll.dll!string "Enabling heap debug options\n"()
         msvcp140d.dll!Concurrency::details::stl_condition_variable_win7::notify_all() Line 178
         msvcp140d.dll!_Cnd_broadcast(_Cnd_internal_imp_t * cond) Line 93
         salhelper3MSC.dll!std::condition_variable::notify_all() Line 590
         salhelper3MSC.dll!salhelper::TimerManager::~TimerManager() Line 221
         salhelper3MSC.dll!``anonymous namespace'::getTimerManager'::`2'::`dynamic atexit destructor for 'aManager''()
         ucrtbased.dll!_execute_onexit_table::__l2::<lambda>() Line 206
         ucrtbased.dll!__crt_seh_guarded_call<int>::operator()<void <lambda>(void),int <lambda>(void) &,void <lambda>(void)>(__acrt_lock_and_call::__l2::void <lambda>(void) && setup, _execute_onexit_table::__l2::int <lambda>(void) & action, __acrt_lock_and_call::__l2::void <lambda>(void) && cleanup) Line 204
         ucrtbased.dll!__acrt_lock_and_call<int <lambda>(void)>(const __acrt_lock_id lock_id, _execute_onexit_table::__l2::int <lambda>(void) && action) Line 974
         ucrtbased.dll!_execute_onexit_table(_onexit_table_t * table) Line 231
         salhelper3MSC.dll!__scrt_dllmain_uninitialize_c() Line 399
         salhelper3MSC.dll!dllmain_crt_process_detach(const bool is_terminating) Line 182
         salhelper3MSC.dll!dllmain_crt_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 220
         salhelper3MSC.dll!dllmain_dispatch(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 293
         salhelper3MSC.dll!_DllMainCRTStartup(HINSTANCE__ * const instance, const unsigned long reason, void * const reserved) Line 335
         ntdll.dll!LdrShutdownProcess()
         ntdll.dll!RtlExitUserProcess()
         ucrtbased.dll!exit_or_terminate_process(const unsigned int return_code) Line 144
         ucrtbased.dll!common_exit(const int return_code, const _crt_exit_cleanup_mode cleanup_mode, const _crt_exit_return_mode return_mode) Line 280
         ucrtbased.dll!exit(int return_code) Line 294
         cppunittester.exe!__scrt_common_main_seh() Line 297
         cppunittester.exe!__scrt_common_main() Line 331
         cppunittester.exe!mainCRTStartup(void * __formal) Line 17
         kernel32.dll!BaseThreadInitThunk()
         ntdll.dll!RtlUserThreadStart()
        
        This check prevents that hang.
        The behavior is *possibly* related to my commit
        8a0c43fa86bd32b4d47fd7e46d3ed414c9282ffa (Use _beginthreadex instead of
        CreateThread, 2023-08-09), which put the threads under control of CRT;
        and also to the specific version of CRT on the affected system, which
        might affect the order of statics destruction and thread termination.
        
        Change-Id: I6da95ea369ac9433a426a12d62cbd2a09cb4ce4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172093
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b95059acaf33af93606d4459d5e97d5ccdfcce8e]

        cid#1607396 silence Overflowed integer argument
        
        Change-Id: I756688604ce80d0e9ca6494826767f49dcc13af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172095
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [edb352c241dddbe2afa20dd3a85ad1aacdb77950]

        cid#1607042 silence Overflowed integer argument
        
        Change-Id: I416f9f22c6ba464ef6a3416a3a0cebc34f2b6725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172094
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6ff644abc32dd1d60bdf345dea803ca930a353f]

        Resolves: tdf#148830 ensure SplitWindow has enough space for splitter
        
        Change-Id: Ib60b0e8acdffcda5b6835ff7207fffc4123d5c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172086
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-20  AhmedHamed  <ahmedhamed3699@gmail.com>  [e1183fb68ef9479d6ca718020b65866179bcbc31]

        Make help button in FW has a fixed width
        
        Change-Id: I79122e8ae1c05d1ad647dc990b641971c8bbca50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171929
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [af6a5ba20f7c69cb2f4818c780db9a60862d06a3]

        Remove wasm-qt-mandelbrot demo
        
        ...that had been added with f90c68316c622971706568303a025bbc58351df3 "WASM: add
        Emscripten demo application".  Whatever the original intention, it has probably
        served its purpose by now---and now only negatively impacts (re-)build times.
        
        Change-Id: I2bda8d12b91e741c4d0f7d3f02597e0e9505a73a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172087
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [4a32b04fd1d320f9d86bc1979ea491002d2565ac]

        Explicitly request antialiasing in a test
        
        See commit a8d677035a6565ebc051375206786dab3a353578 (Make sure to
        anti-alias fonts on Windows, when required, 2024-08-19).
        
        Change-Id: I67f863b61002da883a91ca09aa432162985c755b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172042
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [a1b18eba354dc773c214fc3b7ee92c3473ec4a5e]

        Implement Custom Font Collections on pre-Windows 10 systems
        
        Commit 68818db0ec0e9c308c8a0772d46af551f439b32c (build a
        IDWriteFontCollection1 of our FR_PRIVATE fonts, 2022-01-11) used
        dwrite_3.h, which has API available only starting from Windows 10.
        For pre-Windows 10 versions, there is a different way to implement
        this, as explained at
        
        https://learn.microsoft.com/en-us/windows/win32/directwrite/custom-font-collections
        
        This change implements that more complex way as a fallback, until
        we bump the baseline. Allows to not fall back to gdi in Skia, like
        with the original commit, just on older Windows versions.
        
        Change-Id: Ieca13e4a04bc72ce877ab9b512c7821d5466cb70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172090
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [a05432f02b6441b66addc0f22f1b8444557ac37b]

        sw: remove duplicated check
        
        after 3a961b522a82d41a0a3cd09b7fbb9bde6b79f3d8
        "sw: use SAL_RET_MAYBENULL in GetTableBox()"
        
        Kudos to M. Stahl for flagging it
        
        Change-Id: I44879da9206a1c04869b22c7a7b3bb18955f1953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172052
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-19  Justin Luth  <jluth@mail.com>  [f019943851e138fc3a73fcc9a9692f83d50f1e51]

        tdf#161139: add unit test to sw filters pass
        
        make CppunitTest_sw_filters_test
        
        Change-Id: I6764dfb19ec8af12da44821bf1a55ff300780369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172051
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [9304cfdc8318d32cb3360ee1199d706164b11c8f]

        mariadb-connector-c: Upgrade to 3.3.10
        
        Downloaded from https://mariadb.org/download/?t=connector&p=connector-c&r=3.3.10&os=source&pkg=tar_gz
        
        Change-Id: Id7193af1d21e2641f3e1e097272cbe358eca05df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172053
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e9899b5c29bc9390d9b47b40faab6d27797ac4d3]

        fix indent
        
        Change-Id: Ia61f604c65b0eb220b61f6d66c194a96d9e51845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172049
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c16380a550ae41ac1120fe96b1bb11927bde12a]

        GtkBox does not have a child property called left-attach
        
        Change-Id: Ifefc2394747edbbf19601d8bdb9beac418571962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172048
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [0b67a633bb6f109bce93b330fb3bbf3972ea40be]

        Don't fix already correct data
        
        Change-Id: I3e9798507cb9ed04797449e790078e5c2809a1ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171989
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52ca0dd6ccdda4df3860d8b9e24f2f5eedd9a482]

        invalid cast from 'GtkToggleToolButton' to 'GtkToggleButton'
        
        These are toolbar items, and not GtkToggleButton's so use the toolbar
        api here instead.
        
        The "ToolbarUnoDispatcher" thing is to auto dispatch uno:whatver when
        the toolbar items have names like that, these ones have custom handlers
        so that doens't really fit here.
        
        Change-Id: I93fc11bf364ba7ae145ff52bc78a1544c9bae412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172047
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8dc546c049f39dbca0494c6e1ff422ab04cfe06d]

        GtkToolbar does not have a child property called position
        
        Change-Id: I91d2b78ea90c623016540e32ba4b67a8281396f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172046
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [19cea16244956382f7e985c934c008392e13552f]

        CairoSDPR: Make PixelSnap better aligned
        
        Change-Id: I64ca3e6bd0690ea14e95f3ed0969c320a45f30d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172043
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-19  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [fe27013495d58beedf982414bbd00f6ea577ff81]

        CairoSDPR: Text render needs MultiSalLayout support
        
        Change-Id: I418675012392a9707dc515eb1e05a2689ec902aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172039
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [14599c131345cc8847cdb72cfd6fe9e8239d5d1f]

        tdf#158556 only set header flags once
        
        which shaves 5% off the load time.
        
        I suspect this is a copy/paste of the similar logic in
           DomainMapper_Impl::PushPageHeaderFooter
        where it says
        // Set both sharing left and first to off so we can import the content
        regardless tha what value
        // the "titlePage" or "evenAndOdd" flags are set (which decide what
        the sharing is set to in the document)
        
        I suspect that
            commit 4b0fa253a4540f5461397815d290586f9ddabe61
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Tue Nov 28 13:46:21 2023 +0900
            tdf#136472 adjust ooxml import to handle first header/footer
        sufficiently cleaned up the header/footer handling that this is no
        longer necessary.
        
        Change-Id: I05145c0f3706bd100dc200a949b9a05a1600d370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfd5541f9c77543851ef2f33d91aa9396b3fd87a]

        postgresql: Upgrade to 14.13
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.13/postgresql-14.13.tar.bz2
        
        Change-Id: I2854bca1ba3ac0a9beda61718d3a2e2002a2815c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172035
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-08-19  Pierre F  <fpy@bger.ch>  [86e8ccaaab339920619019d8d0eba94048baa2c9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 258bcb03c8a488b14413b6fb7f8bdd88309d8c69
          - misc. simplify sentences  (Basic Function call)
            
            Change-Id: I9a597897f60642832089973926c67f1ac69ed55d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171780
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-19  Pierre F  <fpy@bger.ch>  [5feed5bd975e3033b5245829390785490b2a8a5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76c9502e7138e55ec47073c721ede98fc3d65229
          - add image to record change list. tdf#144206
            
            Change-Id: I5940dc8453b8e2a66b5065ed27ec4a321b996679
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171782
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d4deae62e490691acde9777e78835163d0733fa3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 848fec1e61c6a592ba91fbf4cfe2bce6cdb57476
          - tdf#150760 Fix Bad link for Base Table Row height
            
            + Removed obsolete HID numbers
            + Fixed Column Width menu commands
            + Add switch for CALC/BASE differences
            
            Change-Id: I8026155c352c17aa41c7aef5f5b5111e8cf7db2f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171969
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [86c0772fee71a202c43868cab2e7871af15e9ba0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 709b64df4d40a4972dea43511be7faef204e443f
          - Add Help page on Sidebar settings
            
            Note: Some entries are not mapped because it has not help ID.
            
            "reset to default" omitted but can be added depending on
            https://gerrit.libreoffice.org/c/core/+/171906
            
            Change-Id: Ie8754e58deb76e95b2a366e1e7f4d712d3983694
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171913
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dcf23ba463d4c7ea33c5d9fb240d63351e995d7d]

        tdf#105131 Remove Restore Defaut from sidebar custom menu
        
        Refer to tdf#105131 comment #13
        
        Change-Id: Ia3b33ed4ab971b6f6dd3c751c5f6e3dc6f30f5da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171906
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1ff0a84e4a6fa0139b553b74f4e7d69b15cb9a38]

        SalLayout::InitFont doesn't do anything
        
        there is a MultiSalLayout::InitFont that overrides it, but only forwards
        InitFont to the first child sub SalLayout, which itself then doesn't do
        anything.
        
        This is possibly the case since:
        
        commit 6c436ba09cb35235ce6f4065cf74c9a6ff14a4bd
        Date:   Thu Dec 1 03:33:30 2016 +0200
        
            Kill old Windows layout engines
        
        Change-Id: Ic0d347843257d13ee6d6f695488bd053f5a931fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172040
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [30faedfa35f6fbcd2c02f872903bc5d0ac36103a]

        tdf#161347 Harmonise API docs for UserDefinedAttributes a bit
        
        Change-Id: I85ce6e42d292b85ca0a54652dd733b14137afe9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172033
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [a8d677035a6565ebc051375206786dab3a353578]

        Make sure to anti-alias fonts on Windows, when required
        
        GetUseFontAAFromSystem was introduced to make sure that texts in generated
        raster file match the requested antialiasing selection, not system display
        settings (VCL plugins usually render text according to system settings for
        screen display, even when lines are not anti-aliased).  The use case there
        was disabling antialiasing,  to produce clear output in tests - see commit
        e6538f5bdd876911ea30f84a6512c03908e620fd tdf#118966 vcl: add a flag to
        determine if AA of fonts is used from the system, 2018-07-28.
        
        But the opposite case is also valid:  bitmap file export with antialiasing
        must smooth text,  even when system display antialiasing is disabled. This
        has hit testTdf162259 on a particular buildbot,  where the output happened
        to be black-and-while (see commit 7a08c89b5af8f98045ad825ace6be2f035ad91af
        Workaround a non-antialiased output on one of Windows buildbots, 2024-08-17).
        The problem turned out to be RDP settings  used to connect that particular
        buildbot,  which happened to disable AA.  This basically means that output
        of '--convert-to png' would depend on the system where it's called.
        
        This change extends the effect of GetUseFontAAFromSystem to not only force
        disabled text AA, when it returns false and line AA is disabled,  but also
        force enabled text AA, when it returns false and line AA is enabled.  This
        is a Windows-only change. I will change the test to use this in a separate
        commit.
        
        Change-Id: I7071f1bdefb77cbb9156dde3f70feb4cf8be73f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172031
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a4dfd23e4472b9cea97d5073208b77926e87eef0]

        cid#1557694 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557162 COPY_INSTEAD_OF_MOVE
        cid#1556896 COPY_INSTEAD_OF_MOVE
        cid#1556893 COPY_INSTEAD_OF_MOVE
        cid#1556873 COPY_INSTEAD_OF_MOVE
        cid#1556872 COPY_INSTEAD_OF_MOVE
        cid#1556789 COPY_INSTEAD_OF_MOVE
        cid#1556570 COPY_INSTEAD_OF_MOVE
        cid#1556519 COPY_INSTEAD_OF_MOVE
        cid#1556516 COPY_INSTEAD_OF_MOVE
        cid#1556451 COPY_INSTEAD_OF_MOVE
        cid#1556396 COPY_INSTEAD_OF_MOVE
        cid#1556237 COPY_INSTEAD_OF_MOVE
        cid#1556113 COPY_INSTEAD_OF_MOVE
        cid#1556094 COPY_INSTEAD_OF_MOVE
        cid#1555991 COPY_INSTEAD_OF_MOVE
        cid#1555982 COPY_INSTEAD_OF_MOVE
        cid#1555885 COPY_INSTEAD_OF_MOVE
        cid#1555702 COPY_INSTEAD_OF_MOVE
        cid#1555610 COPY_INSTEAD_OF_MOVE
        cid#1555450 COPY_INSTEAD_OF_MOVE
        cid#1555327 COPY_INSTEAD_OF_MOVE
        cid#1555145 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I38cc1a38e8cb2c33f33e0fc3afd34a0fb39e5ec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172028
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c3d7113cdfc64a2e954b9f5a1b4f39db97af5a94]

        cid#1607270 silence Overflowed integer argument
        
        Change-Id: I6238fe6fdf28e876c636ce12022c0458e9548578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f286afec5fccfee4bde8c1d7894483bf71863294]

        cid#1606552 silence Overflowed constant
        
        Change-Id: Ia93330fa9b6b0fa4ca09a89e57c3dcf55d357383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172026
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7a20237bd62821e45849fb2d5f90b20148035a8]

        cid#1558041 silence COPY_INSTEAD_OF_MOVE
        
        Change-Id: I176158eb311fa1ae61ba39fd1d810b9faacef1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8a86dfaf59822605fce1e856672100c28a399500]

        cid#1607580 silence Overflowed constant
        
        Change-Id: I61c1728293347aec967a95cdf7a9f40aa52b7aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172024
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a971a176b476eae49784261e6b6e46f3210e43af]

        cid#1616524 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idb3775f795056ec848b01b666cc258604eda7588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172023
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [372060b8a3d74c854dff7abe24eed5856a9ce3d4]

        pAttr is always dereferenced, use a reference here
        
        Change-Id: I183a522704d0fbe2ba2907e75e8794621e94c178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172022
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe2c7f209b0ecfcf81ba775bd39cd355af2a64df]

        cid#1616525 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I508df311ec1785be11077c1f657be57b84ed8cfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172021
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [93c17f16b064ded262b23eb8aa60ff58bda18bc7]

        tdf#150461: deselect all when clicking outside of all list items
        
        Change-Id: I72185ccee716825b5e7b1bb7ae6bddb533604f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171988
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1565181908a06dcdb8d97d6be8ff773acd1d05cb]

        Fix typo
        
        Change-Id: I3277386244f3a00c2756525829924870e3a3d2bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172030
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a221bc219756cb00a07d0031b4d03b5ee913632e]

        Fix typo
        
        Change-Id: I0c09927dd928281a9a006bd03872b5484d6151ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171963
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [56c33b87e128804c6f0462063808e874880cd3cc]

        Fix typo
        
        Change-Id: I3fac3dcde5aad559dcbc4c64aeedfd0f6fc1cd6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172029
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-19  Deepanshu Sharma  <129deepanshusharma@gmail.com>  [85699f54fec281aa0ddc94fce96cdc588c56d55e]

        tdf#147021 Use std::size() or std::ssize() instead of SAL_N_ELEMENTS()
        
        Change-Id: Ib32452077e625395e29569f56c55c6cb6285d82b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171626
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-08-19  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [e099249fd13a9379525de15a94acec531b7d4d00]

        Remove now useless include in package
        
        Change-Id: I8085fb69a752e69820113cf3074bf5e4e7c942de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172020
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
        Tested-by: Jenkins

2024-08-18  Jaume Pujantell  <jaume.pujantell@collabora.com>  [cd4498d32867af26e95de84836b724b4f85ba1b0]

        tdf#162466 calc: added handling of firstHeaderRow="0" on xlsx files
        
        Calc ignored the firstHeaderRow attibute on xlsx pivot tables causing
        it to add an extra row when firstHeaderRow="0". And then changed the
        value to "1" on export.
        
        Some xlsx pivot table filter tests have been changed because removing
        this extra row changed the position of the values.
        
        Change-Id: I95b722e4f4cc40083c752a045df4ffe37e7159c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171836
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171869
        Tested-by: Jenkins

2024-08-18  TH Huang  <tzhsn.huang@gmail.com>  [5af8a83351622e069331cb69eb9e36d34af61a4c]

        tdf#154018: Change corners to points for polyline and polygon context strings
        
        Change-Id: Ic6b0835238e463e5c155b01a292a5eed72e446d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171743
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e0178cfdba827dafcb192fec005ea45bd041c485]

        Emscripten: Document how Qt builds its own freetype, but we link against LO's
        
        Change-Id: I6413c64db3d50f163ee9cc4feda395a54aab3cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172012
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4f41c19a03072b8c0ab7e882eea55a7f51619ef7]

        Emscripten: Increase the main thread stack size
        
        At least when LO tries to download a document and
        UUIInteractionHelper::handleErrorHandlerRequest wants to show a MessageDialog
        via Qt, the stack grows relatively large, and gray_convert_glyph
        (workdir/UnpackedTarball/freetype/src/smooth/ftgrays.c) alone allocates on the
        stack a buffer of size FT_MAX_GRAY_POOL * sizeof(TCell) = 1024 * 16 = 16K, which
        causes (silent, due to no -sSTACK_OVERFLOW_CHECK=2) stack overflow.
        
        So (somewhat randomly) double the size of the main thread stack to 128K; but, at
        least for now, keep the default value of 64K for other threads (which would
        otherwise inherit the explicitly set -sSTACK_SIZE value via the
        -sDEFUALT_PTHREAD_STACK_SIZE=0 default).
        
        Change-Id: I96583f4af93c84b15c67f310068c5631fb129d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172011
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3d27d68c21bb868e9571a75f219dd8eac0063b16]

        Drop obsolete comment
        
        ...after 6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4 "Emscripten: Move the Qt event
        loop off the JS main thread"
        
        Change-Id: Iea9cb74fa2fc3dd036ee865e1bd8ede93fb33c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172010
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [83d1f9c2dd85d2793028c7afaa3459d1f76898b6]

        Simplify a bit
        
        Change-Id: I7b927cd3dade5bc73039541c3ec8c72a9de400b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172009
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [2a122f47dfa1b127c35838afb0ddac4e8524e400]

        Add missing property to com.sun.star.graphic.MediaProperties service
        
        An omission from commit 8484e52675052848d2d3ffe07378ce2ad29fd288
        "tdf#117427 missing API for determining and loading linked graphic",
        2018-05-12, that introduced it.
        
        Change-Id: Ibf4c754931f813c5234daa5f7b7c907ed84efdef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172008
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [50cd19debbd3f94df0fc4b370f6f6e69d4a1e085]

        Emscripten: Clean up SolarMutex
        
        ...before disappearing through the QApplication::exec() hole, or else the
        SolarMutex would remain locked forever on the application's main thread.
        
        This requires changing SalInstance::ReleaseYieldMutexAll() to
        SalInstance::ReleaseYieldMutex(bool all).  (Further recursive locking of the
        SolarMutex via SolarMutexGuard instances that would be present on the call stack
        leading up to the call to QApplication::exec() would be released during the
        stack unwinding, so just undo the one acquiring done in InitVCL, not all of
        them.)
        
        Change-Id: I9ef57abb7da7f840999700e4eaeeefd2da784645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171956
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [38b9d5e86dcab74288163bb8c6ad798e93e3bedf]

        Those XTest::is... methods return boolean, not any
        
        Change-Id: Ie76e3551cac714fee56a087aed6aa851c4569209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171957
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-18  Hubert Figuière  <hub@collabora.com>  [729e333c90d48baf80177971cffedeb1d131d1d0]

        LOKit: Enable the "Interaction..." command for Impress.
        
        Also enable the dialog for JSDialogs
        Fix the layout of the dialog.
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I4581da34921eb355ce8f59d7bfdf2f7d5d7493f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171961
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [149c51daed056e256aefc3402d79010a1040f590]

        cid#1556978 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556976 COPY_INSTEAD_OF_MOVE
        cid#1556965 COPY_INSTEAD_OF_MOVE
        cid#1556956 COPY_INSTEAD_OF_MOVE
        cid#1556953 COPY_INSTEAD_OF_MOVE
        cid#1556946 COPY_INSTEAD_OF_MOVE
        cid#1556934 COPY_INSTEAD_OF_MOVE
        cid#1556897 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6cf90b385042e7ca7d07138c28c0e95f97de8f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171983
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd689fb9145bcb43f4be3b62fffb98d37666ffb1]

        cid#1557699 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557435 COPY_INSTEAD_OF_MOVE
        cid#1557307 COPY_INSTEAD_OF_MOVE
        cid#1557209 COPY_INSTEAD_OF_MOVE
        cid#1557192 COPY_INSTEAD_OF_MOVE
        cid#1557184 COPY_INSTEAD_OF_MOVE
        cid#1557183 COPY_INSTEAD_OF_MOVE
        cid#1557171 COPY_INSTEAD_OF_MOVE
        cid#1557150 COPY_INSTEAD_OF_MOVE
        cid#1557148 COPY_INSTEAD_OF_MOVE
        cid#1557123 COPY_INSTEAD_OF_MOVE
        cid#1557118 COPY_INSTEAD_OF_MOVE
        cid#1557116 COPY_INSTEAD_OF_MOVE
        cid#1557103 COPY_INSTEAD_OF_MOVE
        cid#1557078 COPY_INSTEAD_OF_MOVE
        cid#1557075 COPY_INSTEAD_OF_MOVE
        cid#1557071 COPY_INSTEAD_OF_MOVE
        cid#1557070 COPY_INSTEAD_OF_MOVE
        cid#1557067 COPY_INSTEAD_OF_MOVE
        cid#1557049 COPY_INSTEAD_OF_MOVE
        cid#1557046 COPY_INSTEAD_OF_MOVE
        cid#1557042 COPY_INSTEAD_OF_MOVE
        cid#1557036 COPY_INSTEAD_OF_MOVE
        cid#1557030 COPY_INSTEAD_OF_MOVE
        cid#1557024 COPY_INSTEAD_OF_MOVE
        cid#1557012 COPY_INSTEAD_OF_MOVE
        cid#1557009 COPY_INSTEAD_OF_MOVE
        cid#1557008 COPY_INSTEAD_OF_MOVE
        cid#1557004 COPY_INSTEAD_OF_MOVE
        cid#1556999 COPY_INSTEAD_OF_MOVE
        cid#1556992 COPY_INSTEAD_OF_MOVE
        cid#1556987 COPY_INSTEAD_OF_MOVE
        cid#1556984 COPY_INSTEAD_OF_MOVE
        cid#1556981 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6a71f5daf8c8d1efa8b2273137c92a8ac2650b1]

        Related: ofz#70815 Timeout, don't need this copy
        
        Change-Id: I8d870a6e6743b98da3d0a173cff12748d513d8d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171982
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [af15f1eb6642a8c21b6404dc8405396eaa50c17d]

        Simplify a bit
        
        Change-Id: Ibe34a1c17d856146d191e784af06b8cb6301b912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172007
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [fa8a0f514a4c722974410e4cbfa8ea12f3304003]

        Related: tdf#132064 Use set to clear the With internal variable
        
        In commit f3f46b5fe729876d128f63f7ab158954ab6657d7 (tdf#132064: make
        With statement only evaluate its argument once, 2024-08-17), I made
        a mistake, clearing the internal variable in the end of SbiParser::With
        using an Erase call, which does not just clears the variable itself,
        but destroys the underlying object, which is not what we need.
        
        I don't know how to refer to a global Nothing object to assign to the
        variable; so just create an own internal Nothing, and use it in the
        assignment.
        
        Change-Id: Ic8ce52e0402d8461a9b9e4ee07614c4f0a46a95e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172006
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [afb46ee8803a04664f26da3e1f8f88a75d92cb7f]

        tdf#150458: evaluate for loop's end and step once in VBA support mode
        
        As required by [MS-VBAL], and actual VBA implementation.
        It is a question if we also need to change it likewise in other
        modes (normal, compatible) - see tdf#150460.
        
        Change-Id: I1e83d57fe4be3bf264a64fe977909cf7684bc798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172005
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [4e1ee0ba1dd6b2de4ff78b8fb7daa72b40bb940a]

        Revert "Workaround a non-antialiased output on one of Windows buildbots"
        
        This reverts commit 7a08c89b5af8f98045ad825ace6be2f035ad91af.
        
        Reason for revert: the cause of the failures on tb88 was low quality of
        RDP connection settings, which is fixed now. The bug that it affects
        the export still needs a separate fix.
        
        Change-Id: I36aece47108781abc3578092d5fb479a56fce050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171986
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-18  Jim Raykowski  <raykowj@gmail.com>  [d5143c058bfdc0f5674c3e0a88fae2f9cbe28a0a]

        tdf#156926 related: Ability to Delete all images in Writer
        
        Adds the ability to delete all content of a content type, excluding
        the Headings content type, using the content type's context menu in
        Writer Navigator.
        
        Change-Id: Ie5666b6b9b7ef2f3cdb63957b1b42b236b8674db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170643
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-08-17  Justin Luth  <jluth@mail.com>  [e6a5fa797333ebc526a5ff75e8ec866f3e1cf95c]

        tdf#162304 layoutInCell: native ODT handling from top of PRINT_AREA
        
        Making ODF work the same way that MSO does.
        Since this was the intention all along,
        I'm not going to bother with a compat flag
        for older documents.
        
        It is highly unlikely that a native ODF user would have all these:
        -turned on follow text flow
        -used "page text area" when trying to orient from top of cell
         (more likely to use "entire page" if they do associate page<->cell.
        -set a larger border spacing (since default is a miniscule 0.05cm).
        -this code-path is only in effect with FROM_TOP,
         an unlikely combination with "page text area".
        
        Change-Id: I979e6e0526102004c56285db6e7479c0ff6d660e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171610
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [e4317008765b06aba3ec3462564ac50852c2b07f]

        Move the check out of the loop
        
        Change-Id: I151ac6399d2cc5870971f258614480fcbdff5c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171979
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-17  Justin Luth  <jluth@mail.com>  [7144a9c791ab587b4621c2b35611ba2020baab58]

        tdf#162211 tdf#153909 layoutInCell vml: don't discard layoutInCell
        
        This is just a clean-up patch,
        doing for the VML code path what was handled for drawingML
        
        This effectively reverts my patch for tdf#153909
        commit ad0266eb84eafa32ccc4e0ddf3c6392860bc9b13,
        but it depends on all the changes made for tdf#162211.
        
        Change-Id: I3b5942c406ee73e91cdff1f1f73a2b92e0688474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171609
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Justin Luth  <jluth@mail.com>  [abb8272350419e480ae25b71bdc8ac631d1b7e00]

        tdf#91632 doc import layoutInCell: vert page->margin, *->top
        
        The same thing was done early in this series of patches for DOCX
        
        Microsoft's layoutInCell is very buggy for vertical orientation.
        So, instead of making our own implementation just as buggy,
        instead, alter the document so that the settings match the implementation.
        That way if MSO ever decides to re-fix layoutInCell,
        we are in a position to easily avoid the mapping
        to accommodate a new compat version.
        
        make CppunitTest_sw_ww8export4 \
            CPPUNIT_TEST_NAME=testTdf91632_layoutInCellD
        
        Change-Id: I6d1a6c341dc1fdd51facb965c75f7d2578973eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171975
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Justin Luth  <jluth@mail.com>  [10bc43d6885a38ca4cccaf201df33ebea64736c3]

        tdf#162211 tdf#160077 layoutInCell: use row margin for MSOLayout
        
        I think the bottom margin functions might be buggy,
        so I'm glad I don't need to use them
        (since MSO only does vertical layout against the top).
        
        This is only needed for "from top",
        because the only other choice, "top",
        is based on the print area, while this function
        uses GetFrameArea. GetFramePrintArea is invalid,
        so that can't be used directly.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCell
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCellB
        
        Before this patch could pass sw.check,
        I had to fix the following unit test in a previous patch
        make CppunitTest_sw_layoutwriter2 CPPUNIT_TEST_NAME=testTdf116256
        
        Change-Id: Iac487b94c81ce44165356f447eb37964da1985ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171507
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Justin Luth  <jluth@mail.com>  [0c2d2ca64f796b3f3f0bc8a8d123aa1be99414f1]

        tdf#162211 tdf#158384 layoutInCell: doTextBoxPositioning better
        
        by simply honouring FollowTextFlow as the comment states.
        
        I needed to look into this because of a failing unit test.
        
        I can't say I understand why sync needs to lay out two things
        instead of just laying out one and copying the screen position,
        but bug 158384 indicated that the wrong value was added,
        so I looked for alternatives to use instead of nLeftSpace.
        
        A better sounding alternative was textbox spacing to border,
        but that is already taken into account.
        
        Then I realized a negative offset was being applied
        against the cell edge - which is only allowed for bWrapThrough.
        
        Unfortunately, that once again breaks the unit test
        I have been trying to accommodate.
        I can only assume that the unit test's pressuppositions are false.
        So I'm changing the unit test to test things that are certain!
        make CppunitTest_sw_layoutwriter2 CPPUNIT_TEST_NAME=testTdf116256
        
        Given how wonky textbox sync is,
        I'm not confident that ANYTHING here is actually correct.
        
        Change-Id: I2e73b7345b4d4c3da78d62644032cb573dc6821e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171577
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [f3f46b5fe729876d128f63f7ab158954ab6657d7]

        tdf#132064: make With statement only evaluate its argument once
        
        This is implemented by creating a unique variable at entry of the
        block, using it as the "with parent", and clearing afterwards. It
        uses an invalid name, so can't be used by a user. The  generation
        of the bytecode is done in compatible way;  only existing opcodes
        were used (which was the reason to choose the implementation with
        a variable), so compiled binaries in password-protected libraries
        are expected to work with older versions.
        
        The functional changes are:
        
        1. The argument of With statement is evaluated immediately at the
        start of the block; previously, it evaluated first time, when the
        leading dot operator was used,  and could even be never evaluated,
        if the operator wasn't used. This is consistent with VBA, and has
        a benefit that the lifetime of the object  is guaranteed to cover
        the whole block (might be useful if other block statements depend
        on the object, similar to Python's 'with' statement contexts).
        
        2. The primary goal of the change: it is only ever evaluated once,
        no matter how many times was the dot operator used in the block.
        
        Change-Id: I4dbd520538a57e3668ab706e8f45740db5d33393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171980
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [79b931027ef682c71040cea8833a6f65e27f7982]

        tdf#158556 improve FindNumRulePtr
        
        we dont need to scan the table if the entry does not exist in the map
        Shaves 2% off the load time of a large DOCX file
        
        Change-Id: Idf001487ae4a25a37f63218f1e98dbd6cc2a6ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52eb804cf043a905a2720601f0dcea9b0f33612a]

        cid#1606639 silence Overflowed constant
        
        and
        
        cid#1606583 silence Overflowed constant
        
        Change-Id: I7cbd62b45126d66a4b9eeb2e2b61a7625c177708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8eafcd47ed9a8556ba28ed2e99e800c36a86d661]

        cid#1616506 Resource leak
        
        and fixup headers
        
        Change-Id: I0a3e5f71f1dbfa9c1119c5b4bef634f27797927d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171972
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f74e50d705ed2c8ae3a42ab8bddd4b57031a5d8e]

        cid#1616505 Uninitialized scalar field
        
        Change-Id: I6521d25f7763ebe7f1b0d1213ab641c284c5e228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-17  Hubert Figuière  <hub@collabora.com>  [25b61215ca91ec474c46f5ab8af067b4568f0bf9]

        impress/draw: make the SdActionDlg (Interaction...) dialog async
        
        Make SdAbstractSfxDialog_Impl support async for all.
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I9e2df8369f8f1fde252d079464a188c155a26057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171781
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ddec502caa272b9e19872329ed5c5cd2fe3f40eb]

        tdf#160459 embedded starmath doesn't fit inside allocated area
        
        much to and fro with MapModes and rounding issue obscured that
        fundmentally that the 'etched-out' GtkScrolledWindow frame requires
        space which eats into what is available to show the formula, and
        in embedded mode we want the editing area to be equal in size
        to the area used for the preview.
        
        Change-Id: I1d126ddcc953131cf4add7da58ccd89e7fa86b66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171964
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [52a2dd0eea2ecf62b1db5f379cf65aed705446cb]

        Support for non-AA text on Windows
        
        In commit 3ecd8f19a91ed7141304a2080fb11612b5ff30b3 (vcl cairo text
        renderer: support non-AA text, 2018-07-26) and its follow-up commit
        e6538f5bdd876911ea30f84a6512c03908e620fd (tdf#118966 vcl: add a flag
        to determine if AA of fonts is used from the system, 2018-07-28),
        non-antialiased text got supported in bitmap export using cairo.
        
        This change makes that support available on Windiws, including Skia.
        
        Change-Id: I1fae726539347f826e2d62246d35315e7954cf83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171967
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dac249a0de613cce6c3f3de756cd1a0c8464f38c]

        chart2: move histogram calcualtion into HistogramChartType
        
        Histogram is special in the way that the input data is not the
        data that is being shown in the chart - it needs to be calculated
        separately usign the input data. First we put the calculation in
        the (Histogram)DataInterpreter but that is not a very good place
        to calculate as we don't have the access to the chart properties
        and can't influence the calculation with it. This change puts the
        calculation into (Histogram)ChartType instead and will trigger
        the calculation when the data is requested.
        
        This is the first case of such a thing where we calculate the data
        on demand from the input data, so we will probably need further
        changes the chart code to better support calculated data sequences.
        
        Change-Id: Ia66f9d245f7d42973c728e1dd9a406b66eb2610a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171952
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-08-17  Kurt Nordback  <kurt.nordback@protonmail.com>  [d0092c5627f3dc2db33846e3b81ce19780372529]

        tdf#161230 - Pie-of-pie and bar-of-pie chart data labels are misaligned
        
        Implementing label support for of-pie charts. This involves using the existing
        pie label code with an added horizontal shift, and adding special (simple)
        handling for the bars in bar-of-pie. This also fixes tdf#161228
        
        Change-Id: Ifc7c1f28548caf216aba5c7dc411d05a0c9d8726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169566
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [1ecf44c57dae3d810a77e78351c10c5b55239faa]

        Fix wrong = where == was intended
        
        Introduced in commit cd740ff560a88a62bc79f5ea5b92bdadf71ba728.
        Thanks Caolan for spotting this!
        
        Change-Id: Ieb046013f7bd09b539b01b5d360f52a9cb39e245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171783
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-17  Justin Luth  <jluth@mail.com>  [86a5c48cdce4b8392ade2858d7835b48af8afc00]

        tdf#161741: LO crashed on redo of header changes: unit test
        
        make CppunitTest_sw_uiwriter8 CPPUNIT_TEST_NAME=testTdf161741
        
        Change-Id: I3f62fa600d4c1392f76fff02d51443ed51729e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171960
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-17  Eike Rathke  <erack@redhat.com>  [612e4d7731cc2890d6e58e8b712757fccd06ae2d]

        OnCalculate sheet event is fired before, not after recalculation
        
        Change-Id: Ida6455457d40b06d90028c5c294a42e857fb3939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171908
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-08-16  Skyler Grey  <skyler.grey@collabora.com>  [8d9a96fca21118da6676f56b4abd48594fc1956e]

        feat(invert): Allow inverted background on init
        
        Previously for Online there was no way to save the background invert
        state and reload it. Worse, when someone changed the state it would
        become the default for new document loads.
        
        This patch allows Online to specify whether it wants the background to
        be inverted, which should allow smooth tab refreshes while also avoiding
        mingling state from different people.
        
        There is a change to online to support this here:
        https://github.com/CollaboraOnline/online/pull/9652
        
        Change-Id: I8c22c03d3b4589736d48509004f7789dd5166389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171955
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [7a08c89b5af8f98045ad825ace6be2f035ad91af]

        Workaround a non-antialiased output on one of Windows buildbots
        
        Seen as
        
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/sd/qa/unit/PNGExportTests.cxx(1006) : error : Assertion
        Test name: testTdf162259::TestBody
        greater assertion failed
        
        Expected greater than: 350
        Actual : 271
        
        See e.g. https://ci.libreoffice.org/job/gerrit_windows/183201/consoleFull#-530547713d893063f-7f3d-4b7e-b56f-4e0f225817cd
        
        Change-Id: I0042138a728e1ca08c2b142db7f97635bffd7d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-16  Dione Maddern  <dionemaddern@gmail.com>  [202e68fb4b54f44eb90dc38a554decaac1e0d2c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a2c5184f0ddc6b4b2c86889a536655aa8ec19472
          - tdf#162483 Update instructions for enabling remote control in Remote User Guide
            
            In text/simpress/guide/impress_remote.xhp
            - Updated instructions to reflect the current UI options
            - Replaced the outdated screenshot with the one shown in
            text/simpress/01/06080000.xhp, which depicts the current location of the
            "Enable remote control" checkbox.
            - Added a link to the Slideshow Settings page in the "Related Topics"
            section
            
            In text/simpress/01/06080000.xhp
            - Added self-link and section tags so that content can be easily
            embedded in other pages.
            
            Change-Id: I1f7f488d0678d28d69543f45f066884e81186c4b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171958
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-16  Miklos Vajna  <vmiklos@collabora.com>  [3974af7dca82f887dfdfe88f087583508c19e7ab]

        sfx2: fix crash in SfxObjectShell::IsHelpDocument()
        
        Seen while running the online.git unit-quarantine testcase:
        
        	#0  std::__uniq_ptr_impl<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::_M_ptr() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:191
        	#1  0x00007f2f25fa398a in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::get() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:462
        	#2  0x00007f2f25f9fae2 in std::unique_ptr<SfxMedium_Impl, std::default_delete<SfxMedium_Impl> >::operator->() const (this=0x10) at /usr/include/c++/12/bits/unique_ptr.h:455
        	#3  0x00007f2f25f8bbd2 in SfxMedium::GetFilter() const (this=0x0) at sfx2/source/doc/docfile.cxx:3272
        	#4  0x00007f2f260067ce in SfxObjectShell::IsHelpDocument() const (this=0x5c6adc0) at sfx2/source/doc/objcont.cxx:589
        	#5  0x00007f2f0f6991c1 in SwLayIdle::isJobEnabled(IdleJobType, SwViewShell const*) (eJob=IdleJobType::SMART_TAGS, pViewShell=0x5a573f0)
        	    at sw/source/core/layout/layact.cxx:2218
        	#6  0x00007f2f0f69926d in SwLayIdle::DoIdleJob(IdleJobType, IdleJobArea) (this=0x7ffc9daf4180, eJob=IdleJobType::SMART_TAGS, eJobArea=IdleJobArea::VISIBLE)
        	    at sw/source/core/layout/layact.cxx:2234
        	#7  0x00007f2f0f699d81 in SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) (this=0x7ffc9daf4180, pRt=0x5a8fad0, pI=0x5a58860)
        	    at sw/source/core/layout/layact.cxx:2355
        	#8  0x00007f2f0fdccf21 in SwViewShell::LayoutIdle() (this=0x5a573f0) at sw/source/core/view/viewsh.cxx:826
        
        Assume that in case the object shell has no underlying medium, then
        that's not a help document.
        
        Also fix the higher level problem that the LOK AnyInput callback should
        not be invoked while doing a LOK background save, as the object shell in the
        forked process has no underlying medium. That fixes the failure seen
        while running the online.git unit-save-torture test.
        
        Change-Id: Idcdd62cc177ac4b7edfbcef8906da2e42610ee98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171950
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-16  Bayram Çiçek  <bayram.cicek@collabora.com>  [f91d74da5571b877126f4f753c4134054fa606bb]

        tdf#158857: [Power Query] export xl/drawings/drawing*.xml
        
        xl/drawings/drawing*.xml:
        - import&export "macro", "textlink", "fLocksText" and "fPublished" attribute of <sp> element (using GrabBag).
        - import&export "descr" and "title" attributes of <cNvPr>
        - import "r:id", "invalidUrl", "action", "tgtFrame", "tooltip", "history", "highlightClick", "endSnd" attributes of <hlinkClick>
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: Idd865fc86c3538107e4c9808b0886733c798b01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170691
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Dione Maddern  <dionemaddern@gmail.com>  [ef25059c74b7fd756548da07aec68a71f235b12a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad12e6e2b68b89d95e1fa92a8905348523ae8ec2
          - tdf#156332 Fix broken links to Navigator and Navigation Toolbar help pages
            
            Create new file text/shared/01/navigator.xhp
            - Help link from the Navigator Sidebar Deck is broken. The Navigation
            Sidebar deck contains the same widgets as the Navigator window, so I've merged everything into one file.
            - Embedded help content from the existing help pages for Navigator where
            possible, to avoid retranslation and used switches to show and hide the
            relevant content.
            
            Created new file text/swriter/01/navigator_context_menu.xhp
            - There are a lot of items in the context menu for Writer, and the page
            was getting overly long and difficult to read.
            
            In AllLangHelp_shared.mk
            - Added file text/shared/01/navigator.xhp
            
            In AllLangHelp_swriter.mk
            - added file text/swriter/01/navigator_context_menu.xhp
            
            In text/swriter/01/02110000.xhp
            - Added variable and section tags to make content easier to embed in
            other pages
            - moved bookmarks to text/shared/01/navigator.xhp or
            text/swriter/01/navigator_context_menu.xhp as appropriate, so that
            pressing F1 will open that page
            
            In text/simpress/01/02110000.xhp, and text/scalc/01/02110000.xhp
            - Added variable and section tags to make content easier to embed in
            other pages
            - moved bookmarks to text/shared/01/navigator.xhp so that pressing F1
            will open that page
            - removed bookmark for the Pointer function because it doesn't seem to
            exist in the current version of Impress.
            
            In text/scalc/01/02110000.xhp
            - - Added variable and section tags to make content easier to embed in
            other pages
            - moved bookmarks to text/shared/01/navigator.xhp so that pressing F1
            will open that page
            
            In text/swriter/01/02110100.xhp
            - Added variable and section ids so that the summary section can be
            embedded in text/shared/01/navigator.xhp instead of re-stating the same
            information.
            - Moved the bookmark for
            .uno:AvailableToolbars?Toolbar:string=navigationobjectbar to
            text/swriter/navigate_toolbar.xhp
            
            In text/swriter/navigate_toolbar.xhp
            - Added bookmark for source/text/swriter/navigate_toolbar.xhp so that
            pressing F1 while hovering over View > Toolbars > Navigator opens the
            correct page.
            
            In text/shared/00/edit_menu.xhp
            - Updated howtoget instructions for the Navigator window to include
            instructions for the Sidebar
            
            Updated links to text/scalc/01/02110000.xhp to lead to
            text/shared/01/navigator.xhp in
            - source/text/scalc/01/04070000.xhp
            - source/text/scalc/01/06050000.xhp
            - source/text/scalc/guide/background.xhp
            - source/text/scalc/guide/cellreference_dragdrop.xhp
            - source/text/scalc/guide/format_table.xhp
            - source/text/scalc/guide/webquery.xhp
            - source/text/scalc/main0103.xhp
            
            Updated links to text/simpress/01/02110000.xhp to lead to
            text/shared/01/navigator.xhp in
            - source/text/sdraw/main0103.xhp
            - source/text/simpress/main0103.xhp
            
            Updated links to text/swriter/01/02110000.xhp to lead to
            text/shared/01/navigator.xhp in
            - source/text/swriter/main0103.xhp
            - source/text/shared/01/nav_rename.xhp
            
            Change-Id: If5509dcbe9c9babf2ef84be492f0edfb2e2a3792
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171921
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [3ad771ee7acaf4e64151d30e799339f14bc8bd29]

        Fix some copypaste errors in IDL documentation
        
        Change-Id: I1f35df106ac4e41a7cce244b89b05407d7a14651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171942
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-16  Skyler Grey  <skyler.grey@collabora.com>  [3a597235ea95621d386bf85d747f763bda275837]

        test(invert): ensure background-invert separation
        
        I0aed702185e642f631854b1f8234355c9e69ff6e made inverted backgrounds
        separated by view. This change adds a test to make sure that it really
        works, based on the work in I05486860c5f562c3cfa59b4a7fc492d48913a181 to
        allow a specific theme to be stated on a per-view basis
        
        Change-Id: I3d0c4814cde5cafe069f984fe7904080660f10d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171953
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [768d919f8fd91f4a82d663bbdff9cd03c596ab5f]

        TempFileFastService should implement ByteReader/ByteWriter
        
        avoids some Sequence overhead in some hot paths
        
        Change-Id: I9d248cc088d423c8dc05895db934d6402c8baa44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-16  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [cd6529a0501d49e0cd6344523d509fa7186687c9]

        CairoSDPR: Add support for Relief for Text Rendering
        
        Change-Id: Idcb33e0f799b2219a4e737d0421bc21d85b5c7aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171915
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f5d694e5840b0b9bda15dc120e8b07d18d4cbd0]

        tdf#158556 ByteGrabber does not need a mutex
        
        it is only used from one place, and that place already locks a mutex
        around all usage
        
        Change-Id: I85a8d89220bee7806db5457d69cfcf2f11c1734d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c767e78e629721771c1b9b16b647963ef652732d]

        Keep SessionManagerInhibitor disabled for Emscripten
        
        ...after 2f6f717073084b17e9be80e32a87200bacd1b74c "qt: Drop X11 condition for
        session/screensaver inhibition" caused
        
        > em++: warning: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/workdir/UnpackedTarball/argon2/libargon2.a: archive is missing an index; Use emar when creating libraries to ensure an index is created [-Wemcc]
        > em++: warning: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/workdir/UnpackedTarball/argon2/libargon2.a: adding index [-Wemcc]
        > wasm-ld: error: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/instdir/program/libvclplug_qt5lo.a(QtFrame.o): undefined symbol: SessionManagerInhibitor::inhibit(bool, std::__2::basic_string_view<char16_t, std::__2::char_traits<char16_t>>, ApplicationInhibitFlags, unsigned int, char const*)
        > wasm-ld: error: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/instdir/program/libvclplug_qt5lo.a(QtFrame.o): undefined symbol: SessionManagerInhibitor::inhibit(bool, std::__2::basic_string_view<char16_t, std::__2::char_traits<char16_t>>, ApplicationInhibitFlags, unsigned int, char const*)
        > em++: error: '/home/tdf/lode/emsdk/upstream/bin/wasm-ld @/tmp/emscripten_3x0hflai.rsp.utf-8' failed (returned 1)
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_wasm/desktop/Executable_soffice_bin.mk:10: /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/instdir/program/soffice.html] Error 1
        
        (<https://ci.libreoffice.org/job/lo_daily_tb_linux_wasm/800/>).  Most likely its
        implementation would not work on Emscripten, anyway.
        
        Change-Id: Ie7a643a8326df8c90645526930af21d54847a3ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171941
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e3d7473a5611f414bfcf1a3e812248c82f9e9b83]

        Add extended tips to styles sidebar
        
        Change-Id: I161be41fa80a1e2d841b5c1b00d6e249469f3247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171932
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-08-16  László Németh  <nemeth@numbertext.org>  [98f7f540463c533da17d4e8595c091d9e98a6c83]

        tdf#162491 tdf#125032 add hyphenation settings to sidebar
        
        Add .uno:NoBreak to the Character sidebar panel to disable
        automatic hyphenation for selected words. The icon is enabled
        only on hyphenated words and words with disabled hyphenation.
        
        Add .uno:Hyphenate icon to the Character sidebar panel, with
        tooltip "Insert Soft Hyphen...", which opens the dialog for
        (semi-)automatic insertion of soft hyphens.
        
        Add paragraph-level hyphenation settings to the Paragraph
        sidebar panel. Only the toggle button icon "Hyphenation"
        is visible to enable hyphenation, if the paragraph is not hyphenated.
        If it's enabled, show all paragraph-level settings.
        
        These new sidebar controls allow adjusting paragraph layout and
        hyphenation quickly, like DTP software do.
        
        Note: to add icon to .uno:NoBreak, modify "Properties" of
        officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu.
        
        Note: it's possible, that high resolution icon sizes will need extra
        dispatcher calls (the draft is attached to the issue in the bug tracker).
        
        Change-Id: I292527589ed3a38e4400cfd97ea54cbc7ff56a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171883
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [49cb475862e12d3470ec88db518f6e84e7164d73]

        convert TASKHANDLING constants to scoped enum
        
        Change-Id: I693765375fd372ed81a1efdc85c7821afb5ee666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [ab873780fd855940fe064f387ad1265da29d7169]

        Clarify that XText::insertTextContent only accepts range that belongs to it
        
        This is a widespread error; even out wiki has it.
        
        Change-Id: Ia5a8b90a9b69bd868167ed1cfae86572c56e451c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171943
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4be515e8acf3259a93c712f4ab7cecc82435febc]

        Fix typo
        
        Change-Id: Iacc615bf1998f224562f8f8ac08c0ea6911c80a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171937
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [edefc201d061fe8718a522ef4422273c7d89daff]

        Fix typo
        
        Change-Id: I1fd336113d307d50cc98a75e14c9fd085bb6d884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171938
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c584e5f09112b15420c877b22e3c786fb1e11b3c]

        Fix typo
        
        Change-Id: I2439bdbaf57e3ac96b11951b9b936c19871f202a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171935
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [536d5f9be7831440fd94030d4e4cba804a6bfd02]

        Fix typo
        
        Change-Id: I7097a6bc16902814bcd27b7487f96952817c96f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171936
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-16  Michael Stahl  <michael.stahl@allotropia.de>  [241111f35d7ee570b64c112caaf819f0adf17048]

        libpagemaker: add missing include
        
        Change-Id: I785a94c0e6afad93d5934b3e5546a8a7631cc62c
        (cherry picked from commit 0786a5995c3c9903ea222243a7d5c4c2a1547fc8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171917
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-16  Michael Stahl  <michael.stahl@allotropia.de>  [32cad89592ec04ab552399095c91dd76afb3002c]

        package: ZipPackage: add additional check for entries STORED with
        
        ... data descriptor; only allow it for encrypted ODF entries, which
        requires reading the manifest first.
        
        Change-Id: If36d31a4cb93e7af78f48be3ed899ad9d9bb28f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171911
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d9841ab37825c220f887ff43ecab1522d770d5bd]

        cid#1606710 Overflowed constant
        
        Change-Id: Ic1ed59ffa3d3dd8224e3eaaf2cf98db9fb920a6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c93eb54c872ea279ee43bbf0abe00cc92e9a72e2]

        cid#1557618 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557535 COPY_INSTEAD_OF_MOVE
        cid#1557520 COPY_INSTEAD_OF_MOVE
        cid#1557513 COPY_INSTEAD_OF_MOVE
        cid#1557503 COPY_INSTEAD_OF_MOVE
        cid#1557487 COPY_INSTEAD_OF_MOVE
        cid#1557483 COPY_INSTEAD_OF_MOVE
        cid#1557479 COPY_INSTEAD_OF_MOVE
        cid#1557474 COPY_INSTEAD_OF_MOVE
        cid#1557461 COPY_INSTEAD_OF_MOVE
        cid#1557446 COPY_INSTEAD_OF_MOVE
        cid#1557445 COPY_INSTEAD_OF_MOVE
        cid#1557441 COPY_INSTEAD_OF_MOVE
        cid#1557435 COPY_INSTEAD_OF_MOVE
        cid#1557433 COPY_INSTEAD_OF_MOVE
        cid#1557429 COPY_INSTEAD_OF_MOVE
        cid#1557375 COPY_INSTEAD_OF_MOVE
        cid#1557372 COPY_INSTEAD_OF_MOVE
        cid#1557356 COPY_INSTEAD_OF_MOVE
        cid#1557350 COPY_INSTEAD_OF_MOVE
        cid#1557344 COPY_INSTEAD_OF_MOVE
        cid#1557339 COPY_INSTEAD_OF_MOVE
        cid#1557332 COPY_INSTEAD_OF_MOVE
        cid#1557330 COPY_INSTEAD_OF_MOVE
        cid#1557328 COPY_INSTEAD_OF_MOVE
        cid#1557323 COPY_INSTEAD_OF_MOVE
        cid#1557315 COPY_INSTEAD_OF_MOVE
        cid#1557313 COPY_INSTEAD_OF_MOVE
        cid#1557304 COPY_INSTEAD_OF_MOVE
        cid#1557297 COPY_INSTEAD_OF_MOVE
        cid#1557291 COPY_INSTEAD_OF_MOVE
        cid#1557290 COPY_INSTEAD_OF_MOVE
        cid#1557271 COPY_INSTEAD_OF_MOVE
        cid#1557266 COPY_INSTEAD_OF_MOVE
        cid#1557262 COPY_INSTEAD_OF_MOVE
        cid#1557259 COPY_INSTEAD_OF_MOVE
        cid#1557246 COPY_INSTEAD_OF_MOVE
        cid#1557242 COPY_INSTEAD_OF_MOVE
        cid#1557241 COPY_INSTEAD_OF_MOVE
        cid#1557236 COPY_INSTEAD_OF_MOVE
        cid#1557228 COPY_INSTEAD_OF_MOVE
        cid#1557225 COPY_INSTEAD_OF_MOVE
        cid#1557221 COPY_INSTEAD_OF_MOVE
        cid#1557217 COPY_INSTEAD_OF_MOVE
        cid#1557213 COPY_INSTEAD_OF_MOVE
        cid#1557211 COPY_INSTEAD_OF_MOVE
        cid#1557209 COPY_INSTEAD_OF_MOVE
        cid#1557205 COPY_INSTEAD_OF_MOVE
        cid#1557204 COPY_INSTEAD_OF_MOVE
        cid#1557193 COPY_INSTEAD_OF_MOVE
        cid#1556082 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I07f195a79a69d4bac0d14317854efc88d6fe94d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171927
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4551356827e7c506f76a3da744ac8c8d4a3d0fac]

        cid#1615990 silence Overflowed integer argument
        
        Change-Id: I37ff85c8d6363bd1e9fb1097dc107bca2ad73738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [898594dc5d90087b6c711551ed698802c99571f2]

        cid#1608509 silence Overflowed array index read
        
        Change-Id: Ie42eb4de09968e5c21030936c693ad348c05bbdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171925
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0398e4ec1d0643663f9baf25ca9e9c6dd9377c5c]

        cid#1607030 silence Overflowed integer argument
        
        Change-Id: I90676cf47d7eef441cfabe5a77dfaf81986a1f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [06aaed0fd7e44f6c54331851e276dfb51dc561bb]

        cid#1616498 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1616499 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I21b089cab036902a7ba5b725a6eae0f1212f2b31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171923
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [523465dbcc147178188bc3446a0eccf580c001ac]

        tidy up some unnecessary this use
        
        Change-Id: I490817b99cb95dac216b89369e91ccb48c64f358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-16  Jim Raykowski  <raykowj@gmail.com>  [dd93375dcebe4eb7d7cc9696c18728f83aaed86e]

        related tdf#63967: Ability to Quickly Get Word Count of Sections
        
        Using Navigator
        
        Adds word count information of headings outline content to the
        headings content tooltip.
        
        Change-Id: I31163d95139cdc1ef770591684e9cb585ed49a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171920
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-16  Justin Luth  <jluth@mail.com>  [0a9da9e43c53406c867fe95cdd5c7192ce08bcb6]

        tdf#161741 tdf#161705 undo: delay ClearRedo until Undo finishes
        
        I know NOTHING about the intricacies of Undo/Redo.
        However, this is my feeble attempt to add some sanity to it.
        It should not be the responsibility of the caller
        to know when they are allowed to call ClearRedo.
        
        This patch reverts commit 0cd000bb83719982c1fd2265ea040c82af5bf98e
        author  Daniel Arato (NISZ) on Mon May 10 15:41:28 2021 +0200
            tdf#141613 sw: avoid possible crash when undoing header creation
        which was not a sufficient hack.
        
        I hope this patch lays a better framework
        to handle future similar issues.
        
        vvv NAIVE OPTIMIST ALERT vvv
        
        mbDoing was added with
        commit 9cb53122e9e098bc8a6bf53c14b18415e369dd6d
        Author: Frank Schoenheit on Fri Oct 22 15:00:39 2010 +0200
            undoapi: more I/SfxUndoManager changes
            in preparation of new Undo API features
        
        and has been untouched since then AFAICS,
        and there was never any mechanism to change mbDoing.
        In other words, it has been sitting there doing NOTHING.
        
        So, I am taking it over and using it how I imagine it was intended,
        and how it is documented.
        
        Change-Id: I7aa355cc6458ac8ba34ddb9ee73fc850dcbca702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170793
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-16  Heiko Tietze  <tietze.heiko@gmail.com>  [74d910231c5591f5e497fc52f2a0132c8f41a271]

        Resolves tdf#161766 - WCAG 2.1 compliant luminance for isDark()
        
        Alternative solution to I63b85694584cdc6213e7b904ed6402b6c2f2b422
        
        Change-Id: Ifca47de30616295a9965b9313886456313921401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171862
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-16  Jonathan Clark  <jonathan@libreoffice.org>  [63fbb71f362b16eaa7b7d8617ae3b7e482b41492]

        tdf#141466 sw: Fix incorrect output after editing Ruby base text
        
        Previously, the Asian Phonetic Guide dialog could scramble base text
        during editing due to incorrect handling of PaM after calling
        ReplaceRange(). This issue has been fixed. The implementation has also
        been modified to allow base text deletion.
        
        Change-Id: I43350272359c7984459aea1604dae0d3f6428cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171934
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [afe19beb79c3f88e42fd4b1d9b87cd324092197f]

        tdf#158556 cache SwDocStyleSheet
        
        so we dont keep creating it again. Shaves 3% off the load time.
        
        Change-Id: Id67927f854d55769f76e56c6bc9a9e9bb05eea6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd0c2772f843dd9ae6c82d00665e303c20a48a73]

        SfxScriptOrganizerItem should not subclass SfxStringItem
        
        it never actually uses the superclass value. It has been this way since
        initial import.
        
        Change-Id: I99708c3ad8f1f2727ef87af56c62165d55f348d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-15  Michael Weghorn  <m.weghorn@posteo.de>  [2f6f717073084b17e9be80e32a87200bacd1b74c]

        qt: Drop X11 condition for session/screensaver inhibition
        
        The DBus based session/sreenlock inhibition work on Wayland
        just fine, and in a quick test with the qt6 VCL plugin on
        Plasma 5 Wayland on Debian testing, the screen saver is
        inhibited as expected and doesn't start while an Impress
        presentation is running.
        
        The code in `QtFrame::StartPresentation` being
        guarded by a `CHECK_ANY_QT_USING_X11` at first
        looks like this was all X11-only code.
        It already worked just fine on Wayland before
        that commit however, as it's a build time check only,
        and X11 is enabled by default at build time,
        and the code would run just fine on Wayland then
        with a null X11 Display.
        
        Drop the `CHECK_ANY_QT_USING_X11` (build-time)
        condition altogether, now that `USING_X11` is no more
        required after
        
            Change-Id: Ic46c3f18151340a5ea6c0b62a82c957fd1cd6484
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Aug 15 10:13:27 2024 +0200
        
                vcl: Allow DBus-based session inhibition without requiring X11
        
        Move the X11-specific code into the `#if CHECK_QT5_USING_X11` block
        and call the overload that doesn't require an X11 Display otherwise.
        
        Change-Id: Idee0564d136e59ce54945670dee26df0cfc64d85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171896
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-15  Michael Weghorn  <m.weghorn@posteo.de>  [445ab7c94ca547f1d8d37c85a26fac2ef8d86ce6]

        vcl: Allow DBus-based session inhibition without requiring X11
        
        So far, building `SessionManagerInhibitor` code was
        conditional on `USING_X11`.
        
        Besides direct X11 API calls, it uses DBus calls to inhibit
        lockscreen, power management, etc.
        
        The DBus based ways don't depend on X11 at all.
        Therefore, build the `SessionManagerInhibitor`code on
        relevant platforms unless the GUI feature is disabled
        altogether, and make only the X11 specific code conditional
        on `USING_X11` in addition.
        
        Move the non-X11 specific code from the existing
        `SessionManagerInhibitor::inhibit` to a new overloaded
        version that doesn't require an (X11) `Display` param.
        
        This builds successfully in an
        `--enable-gui --without-x` build.
        
        Change-Id: Ic46c3f18151340a5ea6c0b62a82c957fd1cd6484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171895
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-15  Michael Weghorn  <m.weghorn@posteo.de>  [e8d59edf9dddf809a08cf827235ebb033590f819]

        desktop: Fix '--enable-gui --without-x' build
        
        The code in this block is X11-specific, so
        make it conditional on `USING_X11`, not
        `HAVE_FEATURE_UI`.
        
        This fixes an `--enable-gui --without-x` build
        that previously failed like this
        
            ld.lld: error: undefined symbol: XineramaQueryScreens
            >>> referenced by splashx.c:441 (desktop/unx/source/splashx.c:441)
            >>>               .../libreoffice/workdir/CObject/desktop/unx/source/splashx.o:(splash_init_display)
            [AIN] draw_brand
            clang: error: linker command failed with exit code 1 (use -v to see invocation)
            make[1]: *** [.../libreoffice/desktop/Executable_oosplash.mk:10: .../libreoffice/instdir/program/oosplash] Error 1
            make[1]: *** Waiting for unfinished jobs....
            make: *** [Makefile:296: build] Error 2
        
        Change-Id: If02395d2461de4b6aac340898ce99583653d45c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171894
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-15  Michael Weghorn  <m.weghorn@posteo.de>  [2a9f97a26ffe2ef78e71c41a2310a269ed4a6f7c]

        vcl: Drop MATE <= 1.10 session inhibit support
        
        This was added in:
        
            commit 68570131013cfcf29f4c934a727053c2903e35b1
            Author: Andrzej Hunt <andrzej@ahunt.org>
            Date:   Tue Oct 20 17:24:44 2015 +0200
        
                Add org.mate.SessionManager support
        
                This is valid for Mate <= 1.10
                (As of writing, 1.10 is the current stable release - so we'll have
                 to keep shipping this for quite a few years to come.)
        
                Change-Id: I4d1f81c50923148e710eac22f5428b2a1c41f0e9
        
        As the commit message and code comments say, MATE >= 1.12
        also uses the "org.gnome.SessionManager" interface (which is still
        supported), so drop the "org.mate.SessionManager" one only needed
        for older versions.
        
        MATE 1.12 was released on 2015-11-05, which is long enough ago
        by now.
        
        [1] https://mate-desktop.org/blog/2015-11-05-mate-1-12-released/
        
        Change-Id: I062261c6396b35be1a0f452826f8ee2c545f4906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171893
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [16c9053fe54b7c751b5c8c41ec7609199ebd6610]

        tdf#158556 move m_vIndices to SwNode
        
        When we load complex documents we end up with very large
        amounts of SwNodeIndex objects, and we also need call
        RemoveNode often, which means we end up scanning tons of objects.
        
        So move the linked list from SwNodes to SwNode, so we can
        scan just the objects that we are interested in.
        
        Shaves 10% off the load time of a complex docx file.
        
        Change-Id: Id62388dbc7e41fae30acb7910a982710c80e563e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171888
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [bdd06e255cf89cbc1ee100306d27739dbb5290a4]

        tdf#162475 sc: now conditions can be edited from easy conditional format dialog
        
        now when a conditional format entry is edited,
        instead of editing entry in the same format,
        we delete entry from the origianal format and create
        a new format with modified entry alone.
        
        This way it easier to manage formats, and it also aligns
        with implementation of how format manager adds new
        format condition(it adds new format for each condition instead
        of adding new entry to existing format)
        
        Change-Id: Iaa92292ca67eaf90374d2af44d2402f9ebe29787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169537
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170915
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-15  Jean-Pierre Ledure  <jp@ledure.be>  [fcd18913d5e8450681522c85cf5313f1d3f43aa9]

        ScriptForge (SF_Calc) Typos
        
        Comments needed to be made compliant with code
        in relation to Calc sheet limits.
        
        Change-Id: I67962540e484ab1d51bc79f8ee7e7a73f9f25a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171872
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-08-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e952204b4010a80775ce63a9986506f16d8d7cb9]

        Emscripten: Establish a channel between browser and LO main threads
        
        ...to be used by external code, to mitigate the issue mentioned in the commit
        message of cccc983eb3f0532dbf7e3edf4477ce63ec3d2795 "Emscripten: Run external
        code on LO's main thread":  "Alternatively, running external code on the
        browser's main thread rather than on LO's main thread could be more ideal in the
        sense that the external code would then have access to the browser's document
        object."
        
        On the browser main thread, external JS code can now await a Module.uno_main
        Promise that provides one port of a MessageChannel.  And on the LO main thread,
        external JS code has access to the other port of that MessageChannel as
        Module.uno_mainPort.  (And the external code is completely free in what
        onmessage handlers to set up and what form of postMessage calls to use on those
        two MessagePorts.)
        
        Change-Id: Iab6bc7676c744eacb70ddd9f3f80f64e9efd1cf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171907
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [f684f284deda654893a097b6363bee7ec5b955f5]

        fixed tdf#162471: display comment time in ods if available
        
        Change-Id: I2fe2621458608a2bf6c382397ec5acdaeffe3748
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [2ca75d4133e2388b67d09a9d88969cd20dc68f26]

        Fix the test failing when invalid certificate is in cert store
        
        testPDFAddVisibleSignature was failing for me locally because of
        an expired certificate present in my store.
        
        Change-Id: I03243f6707b1b5ca94ea87e9f8c809dd47b6a93a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171901
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [1faf46589626f7e21db4b421a9b5e804fb520630]

        Add asserts to a unit test
        
        It helped me to easily see which unit test failed, when working on
        another change, instead of seeing a segfault
        
        Change-Id: Id0345f508eac3c60265cd62b8aa20d895c3a1d01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171897
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [58f45fdf1968b6605e55fa36c3cbd250b332ae95]

        make SfxStringItem hashable
        
        which shaves some time off loading complex files.
        
        Note that this class is often used as a superclass, so I checked all of
        the subclasses and marked some of them as "does not support hashing"
        until they can be independently verified to be safe
        
        Change-Id: Id4187eda8d6145e89e17dc10c2e3113b7a93da85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171891
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [fb282d552f5a8ecd89c6fd845a6db116d8362114]

        merge CntUnencodedStringItem into SfxStringItem
        
        which simplifies the hierarhcy.
        We never allocate such a thing, we always allocate subclasses, and it
        has no real meaning by itself.
        
        Change-Id: Ie6b716c9ea6ca0efe0ae4f39ac345608c45534f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-15  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [6ab0c616d72f224c5de87b8afd2b228c223bb056]

        CairoSDPR: Add outline to direct text rendering
        
        Change-Id: I8c8820066a402653bf0f49bd78a98be692530e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171892
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [0e4266dd904ffb79c84f6b281bd822460cc64fde]

        Use MacrosTest::IsValid to check certificates
        
        Change-Id: I015fae42cf95ab7ff4f384b17f6ac4994d4c81ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171902
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [cd740ff560a88a62bc79f5ea5b92bdadf71ba728]

        tdf#162480: Make sure to use correct anchor point for text box creation
        
        In the ODF import, when importing a table, initially a placeholder 1x1
        table is created. When this is done from SwView::InsertMedium, frames
        are created for the table and its single cell at that stage. Then the
        actual table nodes are created, but frames are not created in parallel,
        until the table import is finished.
        
        Importing a text box, it used to be created anchored at the end of the
        document, and then the anchor was moved to the correct place.
        
        When a text box was anchored to a cell, the process was like this: the
        text content was inserted in the last paragraph outside of the current
        table;  and then it was moved to the current cell.  When this was done
        from  SwView::InsertMedium,  creation of the text content also created
        the frame; then the movement fired client notifications, including the
        SwFlyAtContentFrame::SwClientNotify,  which needs the new anchor frame.
        With cell other than A1, there was no frames for the new anchor in the
        table, and that crashed.
        
        This change inserts the text content into the correct place from start,
        which avoids the need to move the anchor later.
        
        Co-authored-by: Miklos Vajna <vmiklos@collabora.com>
        Change-Id: I9dd3a2c5527f3c2dd860244456c617558943453a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171898
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-15  Miklos Vajna  <vmiklos@collabora.com>  [41aec3e9a088ad4e99e43e033c7653e2c25a85ba]

        Related: cool#9735 sw lok: handle the AnyInput() callback during idle layout
        
        Open the 300 pages bugdoc, paste a oneliner plain text content in a
        paragraph which is part of a numbered list, observe a 274 ms hang till
        layout is done for all pages, then we get an updated tile.
        
        We already do the layout in two passes: once for the visible area and
        then an idle pass for the rest of the pages. But we didn't notice that
        the LOK client has pending input events, so the list of events were like
        this:
        debug:20492:20486: SwTransferable::PasteData: finished in 5 ms
        debug:20492:20486: SwLayAction::InternalAction: finished in 273 ms
        debug:20492:20486: SwViewShell::PaintTile
        
        With this patch, the order of evens is rather like:
        debug:7541:7535: SwTransferable::PasteData: finished in 4 ms
        debug:7541:7535: SwViewShell::PaintTile
        debug:7541:7535: SwLayAction::InternalAction: finished in 261 ms
        
        Which means that once a LOK client opts in to provide an any input
        callback, the end-to-end time from the paste uno command dispatch to
        receiving the first tile update decreases from 963 ms to 14 ms.
        
        Change-Id: Ia9e734f84121b7d87150cb3479fc265ca8ee0292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171885
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [8090d7a54f71ccf897d725bbae3f55eb346a240a]

        tdf#162475 sc: display all the conditions of same ranges in conditional format manager
        
        Change-Id: I775f96f4cea19e8da34c2d64ac601e5ea3fc5c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169482
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170914
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [367c2319a8067e6929a4df5c199698db9b07cc56]

        tdf#162475 sc: preview style in easy format dialog
        
        Change-Id: If9c96129daefd5100b4211c9b3b07953b603166d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169483
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170913
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cc9fbb8a5f8b9e224f9a822b78f9f8f6af684642]

        Fix typo
        
        Change-Id: Ib6cd9cceb41e7b741907cbdc05fe485004568ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171903
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-15  Heiko Tietze  <tietze.heiko@gmail.com>  [836abb5b367f438f18ab58953a6f3d5b4bc903e4]

        Resolves tdf#162450 - Hide sidebar tab button
        
        Change-Id: I568976e2f6c8ca03f1aeea35d7607fdd5ea53649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171887
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-15  Miklos Vajna  <vmiklos@collabora.com>  [0cde8913d8cb183224d03d5cbb37072e63e745d1]

        Update pdfium to 6656
        
        Drop external/pdfium/annot.patch.1, it has been upstreamed as
        <https://pdfium-review.googlesource.com/c/pdfium/+/120750>.
        
        Update PDFiumPageObjectImpl::getFontName() to match
        <https://pdfium-review.googlesource.com/c/pdfium/+/121911> "Rename
        FPDFFont_GetFontName() to FPDFFont_GetFamilyName()".
        
        Extend external/pdfium/build.patch.1 to work around:
        
        > C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/pdfium/fpdfsdk/fpdf_annot.cpp(1083): fatal error C1001: Internal compiler error.
        
        Change-Id: I94ed21265a79d484759f240f3baeb51c92365c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171884
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [1e29baa755f2d46304563bb2d3578866b5d8364a]

        sc: now formula conditions can be managed from condition format manager
        
        Change-Id: I52cab33f5486c835dd13720eff93b497331561ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169536
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170912
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [723e035e1fbafdedf7ed64b8de4c14ef0ef038ea]

        tdf#162475 sc: added date condition option in conditional format manage dialog
        
        Change-Id: I453b4ef47bed1607f42fbb3e48303531c6f355a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169323
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170911
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-15  Pranam Lashkari  <lpranam@collabora.com>  [20350c7f1085b0a73191e318e14f2dbd69553e0b]

        sc: tdf#162475 manage conditional format with simpler dialog
        
        now we can add new conitions for formating from manage conditional formating dialog
        
        Change-Id: I69660f108068a64e66301d62a61c485c81e8b97b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169322
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170910
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [f8da93d33ddadb6f60c385b5ee93a55d303d916f]

        Simplify a bit
        
        Change-Id: I05a8aa354b68331712768b1d696736d69ce8dacb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171775
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-15  Skyler Grey  <skyler.grey@collabora.com>  [9f47fe2bfd791bdce28c0b9e7226d329a2b9537e]

        feat(invert): Allow specifying a theme
        
        In Online, we previously weren't able to specify what we wanted the
        theme to be after an invert. This led to the theme being "whatever the
        *last* person toggled it to" rather than "whatever isn't our current
        theme"
        
        This commit also lays the groundwork for loading the same invert theme
        after a reload/rejoin/new doc in Online
        
        There is a change to online to support this here:
        https://github.com/CollaboraOnline/online/pull/9652
        
        Change-Id: I05486860c5f562c3cfa59b4a7fc492d48913a181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171889
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-15  Justin Luth  <jluth@mail.com>  [da249b2c386f0e16a0e63e38ec363c4a5ffd8fdb]

        tdf#162211 writerfilter: don't discard layoutInCell
        
        I DON'T KNOW IF I REALLY WANT TO SUBMIT THIS PATCH.
        I'VE ALREADY DECIDED IT IS BEST TO CHANGE THE IMPORT
        TO MATCH REALITY, AND KILLING layoutInCell
        CERTAINLY DOES THAT.
        The Ok button on the UI is the real convincer...
        although one unit test had beneficial side effects.
        
        It is very tempting to turn off "layoutInCell".
        After all, MSO has rather bizarre exceptions to the rule,
        and the whole concept in general is competely unnecessary
        (except to fix their horrible initial implementations).
        
        But by discarding layoutInCell,
        we are going in the opposite direction
        of Microsoft, who in compat15 (2013+),
        treats layoutInCell as true
        regardless of whether it is set to on or off.
        
        However, there still is one downside to preserving layoutInCell.
        In LO's UI, when looking at the properties,
        it will change the values to enforce layoutInCell,
        so pressing OK will shift an outlying shape.
        
        shape - FRAME/FRAME
        -fdo68607.docx [same]
        -test_segfault_while_save.docx [zOrder is fixed somehow]
        -layout-in-cell-wrapnone-column.docx [same]
        
        make CppunitTest_sw_writerfilter_dmapper \
            CPPUNIT_TEST_NAME=testLayoutInCellWrapnoneColumn
        
        Change-Id: I6d66cb2f14507847e346443d42879a60025bc9d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171437
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ac73760cc545e69704ddbee59be84351f1c3fa13]

        tdf#134791 Back to fixed size, but increase it a bit
        
        Turns out the approach implemented in 058f1d1b5246a9d57942541bef144143b0302383
        doesn't work out when a smaller tab page is activated at first,
        since only the first tab page will define the dialog size.
        
        Change-Id: I1201a0e9174c842d4c023e8438763d6d538d3036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171755
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [df19cc6cddc794eb6e289831707e690bd01eb227]

        vcl: add "fillWithData" function to BitmapTools - used in lok
        
        Change-Id: Ia143a39d2285bbdebf7fcfe709b0c6418d35585c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171589
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-08-15  Jonathan Clark  <jonathan@libreoffice.org>  [dda85e275d70d6365009042b8e207337f2e712c2]

        tdf#156211 sw: Fix spurious kashida inserted after undo
        
        This change fixes an issue presenting as incorrectly-positioned kashida
        glyphs overlapping Arabic text after certain edit operations.
        
        During layout with kashida justification, Writer builds a table of lines
        that require fallback to whitespace justification. Normally, this table
        is built sequentially from the first line, but it may be updated
        out-of-order following certain edit operations.
        
        Due to an off-by-one error, if Writer cleared the exclusion for a line
        immediately before a legitimately-excluded line, Writer would also clear
        the legitimate exclusion. In such a situation, portions of excluded text
        would be redrawn with kashida justification, and because that text
        usually does not have enough free space, the kashida glyphs would be
        drawn on top of the base text.
        
        Change-Id: I204661286531fa6064f7a6adc35f1606e35e5d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171878
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-14  Adam Seskunas  <adamseskunas@gmail.com>  [fe7b39884ccb5e540e10f3294d8f7b35bf3e6ebb]

        tdf#160301 - Add Unit test
        
        Change-Id: Icfd8aa7066ea837103a332c3b61950574b7799fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171840
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-14  Ashok  <ashokemailat@yahoo.com>  [272b30f8fab429ddf5d276ce14589358c4bbd630]

        Simplify initialization of font name vector in vcldemo
        
        Replace the classic For loop with vector initializers.
        
        Change-Id: I60ee577ef395127e99148a32e02009e0cc1c1d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171568
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b497f99fd2c857910f3039bb4d6e082ea1d143a0]

        cid#1557718 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib81c9afd8d7fdc76d8d23818b50316b46ccb3f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cccc983eb3f0532dbf7e3edf4477ce63ec3d2795]

        Emscripten: Run external code on LO's main thread
        
        ...and not the browser's main thread.  Those are different threads now since
        6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4 "Emscripten: Move the Qt event loop off
        the JS main thread".  Running `Module.uno_init.then` on the browser's main
        thread would never trigger, as that promise is only resolved on LO's main
        thread.
        
        When external code was included in soffice.js via
        EMSCRIPTEN_EXTRA_SOFFICE_POST_JS, that didn't make a difference:  Emscripten
        effectively replicates that code to all the worker threads, so whatever worker
        thread resolved the Module.uno_init promise (i.e., the LO main thread) had the
        external code available and ran it.  But when external code was included
        directly in some HTML file (which "manually" provides a canvas and loads
        soffice.js, not relying on the qt_soffice.html convenience functionality), it
        was available in the browser's main thread but not in LO's main thread.  For
        that use case, introduce a new Module.uno_scripts array that can be set up in
        the HTML file to contain an array of URLs (represented as strings) of scripts to
        load into LO's main thread.
        
        (Alternatively, running external code on the browser's main thread rather than
        on LO's main thread could be more ideal in the sense that the external code
        would then have access to the browser's document object.  But, for one, it would
        be less ideal in the sense that we would then potentially again execute LO code
        (which we call into from the external code via UNO) on the browser's main
        thread, which would bring back the issues that
        6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4 "Emscripten: Move the Qt event loop off
        the JS main thread" solved.  And, for another, when I experimentally tried it
        out, it caused massive Qt threading issues, so I quickly gave up again.)
        
        Change-Id: If01a7859751706f168e93ccac75758ae5ce17cd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171870
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d193bf5cec65ab55d5a76b3a4f68eb52e5a747f3]

        cid#1557731 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557724 COPY_INSTEAD_OF_MOVE
        cid#1557721 COPY_INSTEAD_OF_MOVE
        cid#1557720 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib8ae103008fa3cc800e085666e536f6333b9aa72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171838
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-14  Eike Rathke  <erack@redhat.com>  [e6f6dbb61a4905299170f48881fed9fcf0c141d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to afa0a94db4d511a638cb81ff7e000fb6f285c830
          - OnCalculate sheet event is fired before, not after recalculation
            
            Change-Id: Ief7019183946fa8c8a32e0571ebc21c10f0417dd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171874
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2024-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ece0729e18b4b306933439d1a329df192fc504d3]

        use less exception throwing for flow control
        
        Change-Id: Ib376a1bcb75e72d6e5754818a353b0d9c7dbd26d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-14  Weblate  <noreply@documentfoundation.org>  [52d0e53fa8a90b51332f5db9702816cd294dbaa6]

        android-viewer translated using Weblate
        
        Slovak currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Ibc6247bf6000bbdaee75f4eb303eac5a4b6138bb
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I9696da414ca126b4b84b789d04f28c9fffd4cf0f
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Co-authored-by: Miloš Šrámek <msramek22@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sk/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171584
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-08-14  Jean-Pierre Ledure  <jp@ledure.be>  [ad76fa9e59753dfc643f0df33b2bab9a2edf6523]

        ScriptForge (SF_Array) Sort an empty array
        
        SF_Array.Sort() of an empty array
        returned prevously an "Index out of range"
        error message.
        
        From now on it returns correctly an empty array.
        
        Change-Id: I7869a267c1ae160611fffd51838447d0f1539ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171866
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [403b6522cc7104e18f752f395e1fcd259b4db1b3]

        Fix typo
        
        Change-Id: I9a61081ad045bcc22e7ab5f89118270674654f2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171865
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [77ce0a14719fa6d20f3824b458272b3c47aaeea8]

        Fix typo
        
        Change-Id: I26e89e37c6606221f95105e7104355113fe5febf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171864
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-14  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2038d4a42103cebe38667d78632f32377c406fc1]

        tdf#150698 Improve tip of the day
        
        Change-Id: I0518ac67c8a64db1cc7082ab69cc8e38a1b366aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171351
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-08-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85e2105be603c782973fb5fbe1e7fc3478897c88]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9d2a16b7eb33cf0ff58e010d502d64c6dfcdff4f
          - tdf#129492 Similarity search examples
            
            + Added example for add/remove characters for similarity
            + Suppressed hidden <ahelp> (already moved to dialog)
            + Link to wikipedia
            + reorder paragraphs
            
            Change-Id: Idb041e31a2041a4603766a75da22459fa74d75b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171841
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63b4b3f097c18ed9c1413373b49679f8b37cb9b0]

        cid#1557708 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557707 COPY_INSTEAD_OF_MOVE
        cid#1557706 COPY_INSTEAD_OF_MOVE
        cid#1557705 COPY_INSTEAD_OF_MOVE
        cid#1557704 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I2346348d9d896e352db3471e8137c0eca8b21507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-14  Jean-Pierre Ledure  <jp@ledure.be>  [0640e342628ef82cc8f25e99cd3eae32e0f20c02]

        ScriptForge (SF_Writer) TextRange implementation
        
        Many methods will require a "TextRange" as argument.
        
        A textrange is a shortcut describing the scope
        on which to apply the method.
        Such a textrange corresponds either with a single
        insertion point or with a (text) interval between
        2 insertion points.
        Multiple textranges are not supported in this context.
        
        TextRange = a string containing one of next variants :
        (names may be surrounded with single or double quotes)
           "~" or "SELECTION" or "SEL" = current selection
              (if multiple selections, its 1st component)
           "BODY" = the main text of the actual document instance
           "FRAME!name" = the text contained in a text frame
           "BOOKMARK!name" = the given bookmark,
              may be zero or more characters long
           "FIELD!name" = a user text field
           "SECTION!name" = the text contained in a section
           "TABLE!name!cellrange" = a cell (cellrange = "B3")
           "WORD+n" = n words after the current selection
           "SENTENCE-n" = n sentences before the current selection
           "PARAGRAPH" or "§" = the paragraph containing
              the current selection (+0 is the default)
        optionally combined with next control character:
        "|": start or end of string
           E.g.
              "|~" = the point immediately before the current visible
                 selection (starting point)
              "~|" = the point immediately after the current visible
                 selection (ending point)
              "~", "|~|" = the full visible selection
        
        Implemented properties in this commit:
           Bookmarks
           CurrentSelection
           Fields
           Frames
        (More will follow)
        
        Example: doc.CurrentSelection = "SECTION!sect01|"
           => the visible cursor is set at the end
              of the given section
        Change-Id: Ib2a2110e25b0a15cd95c782f6ba8b0db1052bf39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171832
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [60aeca980bbe6cd35d9ce530ea8704bc4ade7b7b]

        tdf#158556 bypass some more logic for toggle properties
        
        Change-Id: I9004ae8d6a13beb81cd00a227b711baebfdb82a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-14  Mike Kaganski  <mike.kaganski@collabora.com>  [8fc13f7d54e8cabd655afb6e04281ed5a58f5d95]

        Disallow closing document during idle layout
        
        Similar to commit 99c1bd1a4ef5365d8c26a41c8e858c67e673beb4 (Disallow
        closing document during generation of preview, 2024-03-11), it may
        happen that an external process is closes a document that is being
        in the process of the background layout, leading to use-after-free.
        
        The request thread at the crash time, executing XComponent::dispose:
        
         swlo.dll!SwNoTextFrame::~SwNoTextFrame() Line 170
         swlo.dll!SwNoTextFrame::`scalar deleting destructor'(unsigned int)
         swlo.dll!SwFrame::DestroyFrame(SwFrame * const pFrame) Line 397
         swlo.dll!SwFlyFrame::DeleteCnt() Line 424
         swlo.dll!SwFlyFrame::DestroyImpl() Line 358
         swlo.dll!SwFlyFreeFrame::DestroyImpl() Line 89
         swlo.dll!SwFrame::DestroyFrame(SwFrame * const pFrame) Line 396
         swlo.dll!SwLayoutFrame::DestroyImpl() Line 516
         swlo.dll!SwFrame::DestroyFrame(SwFrame * const pFrame) Line 396
         swlo.dll!SwLayoutFrame::DestroyImpl() Line 540
         swlo.dll!SwPageFrame::DestroyImpl() Line 317
         swlo.dll!SwFrame::DestroyFrame(SwFrame * const pFrame) Line 396
         swlo.dll!SwLayoutFrame::DestroyImpl() Line 540
         swlo.dll!SwRootFrame::DestroyImpl() Line 570
         swlo.dll!SwFrame::DestroyFrame(SwFrame * const pFrame) Line 396
         swlo.dll!std::_Ref_count_resource<SwRootFrame *,void (__cdecl*)(SwFrame *)>::_Destroy() Line 1222
         swlo.dll!std::_Ref_count_base::_Decref() Line 1164
         swlo.dll!std::_Ptr_base<SwRootFrame>::_Decref() Line 1380
         swlo.dll!std::shared_ptr<SwRootFrame>::~shared_ptr<SwRootFrame>() Line 1685
         swlo.dll!SwViewShell::~SwViewShell() Line 354
         swlo.dll!SwCursorShell::~SwCursorShell() Line 3440
         swlo.dll!SwEditShell::~SwEditShell() Line 63
         swlo.dll!SwFEShell::~SwFEShell() Line 699
         swlo.dll!SwWrtShell::~SwWrtShell() Line 2065
         swlo.dll!SwWrtShell::`scalar deleting destructor'(unsigned int)
         swlo.dll!std::default_delete<SwWrtShell>::operator()(SwWrtShell * _Ptr) Line 3302
         swlo.dll!std::unique_ptr<SwWrtShell,std::default_delete<SwWrtShell>>::reset(SwWrtShell * _Ptr) Line 3447
         swlo.dll!SwView::~SwView() Line 1196
         swlo.dll!SwView::`vector deleting destructor'(unsigned int)
         sfxlo.dll!SfxViewFrame::ReleaseObjectShell_Impl() Line 1140
         sfxlo.dll!SfxViewFrame::~SfxViewFrame() Line 2059
         sfxlo.dll!SfxViewFrame::`scalar deleting destructor'(unsigned int)
         sfxlo.dll!SfxViewFrame::Close() Line 1192
         sfxlo.dll!SfxFrame::DoClose_Impl() Line 138
         sfxlo.dll!SfxBaseController::dispose() Line 928
         fwklo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun::star::uno::Reference<com::sun::star::awt::XWindow> & xComponentWindow, const com::sun::star::uno::Reference<com::sun::star::frame::XController> & xController) Line 1496
         fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1707
         sfxlo.dll!SfxFrame::DoClose() Line 104
         sfxlo.dll!SfxViewFrame::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 1820
         svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 40
         sfxlo.dll!`anonymous namespace'::SfxModelListener_Impl::notifyClosing(const com::sun::star::lang::EventObject & __formal) Line 154
         sfxlo.dll!SfxBaseModel::close(unsigned char bDeliverOwnership) Line 1511
         swlo.dll!SwXTextDocument::close(unsigned char bDeliverOwnership) Line 574
         sfxlo.dll!SfxBaseModel::dispose() Line 745
         swlo.dll!SwXTextDocument::dispose() Line 561
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
         binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
         binaryurplo.dll!request(void * pThreadSpecificData) Line 84
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
         cppu3.dll!cppu_threadpool::ORequestThread::run() Line 165
         cppu3.dll!threadFunc(void * param) Line 190
         sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67
        
        Main thread, doing an idle layout of the same document:
        
         emboleobj.dll!OleComponent::SetExtent(const com::sun::star::awt::Size & aVisAreaSize, __int64 nAspect) Line 1099
         emboleobj.dll!OleEmbeddedObject::setVisualAreaSize(__int64 nAspect, const com::sun::star::awt::Size & aSize) Line 138
         swlo.dll!SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef & xObj, const SwRect * pFlyPrtRect, const SwRect * pFlyFrameRect, const bool bNoTextFramePrtAreaChanged) Line 777
         swlo.dll!SwContentNotify::ImplDestroy() Line 926
         swlo.dll!SwContentNotify::~SwContentNotify() Line 1037
         swlo.dll!SwNoTextFrame::MakeAll(OutputDevice * pRenderContext) Line 584
         swlo.dll!SwFrame::OptPrepareMake() Line 412
         swlo.dll!SwFrame::OptCalc() Line 1110
         swlo.dll!SwLayAction::FormatContent_(const SwContentFrame * pContent, const SwPageFrame * pPage) Line 1969
         swlo.dll!SwLayAction::FormatFlyContent(const SwFlyFrame * pFly) Line 1994
         swlo.dll!SwObjectFormatter::FormatObj_(SwAnchoredObject & _rAnchoredObj) Line 312
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject & _rAnchoredObj, const bool _bCheckForMovedFwd) Line 133
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame * _pMasterTextFrame) Line 414
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObjs() Line 348
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction) Line 160
         swlo.dll!SwLayAction::FormatContent(SwPageFrame * pPage) Line 1802
         swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext) Line 607
         swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext) Line 390
         swlo.dll!SwLayIdle::SwLayIdle(SwRootFrame * pRt, SwViewShellImp * pI) Line 2372
         swlo.dll!SwViewShell::LayoutIdle() Line 827
         swlo.dll!sw::DocumentTimerManager::DoIdleJobs(Timer * __formal) Line 176
         swlo.dll!sw::DocumentTimerManager::LinkStubDoIdleJobs(void * instance, Timer * data) Line 156
         vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111
         vcllo.dll!Timer::Invoke() Line 75
         vcllo.dll!Scheduler::CallbackTaskScheduling() Line 509
         vcllo.dll!SalTimer::CallCallback() Line 53
         vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 169
         vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525
         vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
         vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385
         vcllo.dll!Application::Yield() Line 473
         vcllo.dll!Application::Execute() Line 361
         sofficeapp.dll!desktop::Desktop::Main() Line 1652
         vcllo.dll!ImplSVMain() Line 229
         vcllo.dll!SVMain() Line 262
         sofficeapp.dll!soffice_main() Line 121
         soffice.bin!sal_main() Line 51
         soffice.bin!main(int argc, char * * argv) Line 49
         soffice.bin!invoke_main() Line 79
         soffice.bin!__scrt_common_main_seh() Line 288
         soffice.bin!__scrt_common_main() Line 331
         soffice.bin!mainCRTStartup(void * __formal) Line 17
        
        Change-Id: I92102a9cd11ccde307b070ebc1984eb3d17d65bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171856
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-14  Mike Kaganski  <mike.kaganski@collabora.com>  [29f59dad0e23385a23143008509c15ebae4c2b2d]

        Unlock the mutex to avoid deadlock
        
        The request thread was calling OleComponent::CloseObject, which executed
        on main thread; OleEmbeddedObject::m_aMutex as locked by request thread:
        
         emboleobj.dll!OleComponent::CloseObject() Line 1004
         emboleobj.dll!OleComponent::Dispose() Line 451
         emboleobj.dll!OleComponent::close(unsigned char bDeliverOwnership) Line 1513
         emboleobj.dll!OleEmbeddedObject::GetRidOfComponent() Line 235
         emboleobj.dll!OleEmbeddedObject::Dispose() Line 269
         emboleobj.dll!OleEmbeddedObject::close(unsigned char bDeliverOwnership) Line 498
         comphelper.dll!comphelper::EmbeddedObjectContainer::CloseEmbeddedObjects() Line 208
         sfxlo.dll!SfxObjectShell::~SfxObjectShell() Line 322
         swlo.dll!SwDocShell::~SwDocShell() Line 380
         swlo.dll!SwDocShell::`vector deleting destructor'(unsigned int)
         cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 229
         sfxlo.dll!rtl::Reference<SfxObjectShell>::~Reference<SfxObjectShell>() Line 126
         sfxlo.dll!IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() Line 265
         sfxlo.dll!IMPL_SfxBaseModel_DataContainer::`scalar deleting destructor'(unsigned int)
         sfxlo.dll!std::_Destroy_in_place<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer & _Obj) Line 293
         sfxlo.dll!std::_Ref_count_obj2<IMPL_SfxBaseModel_DataContainer>::_Destroy() Line 2113
         sfxlo.dll!std::_Ref_count_base::_Decref() Line 1164
         sfxlo.dll!std::_Ptr_base<IMPL_SfxBaseModel_DataContainer>::_Decref() Line 1380
         sfxlo.dll!std::shared_ptr<IMPL_SfxBaseModel_DataContainer>::~shared_ptr<IMPL_SfxBaseModel_DataContainer>() Line 1685
         sfxlo.dll!std::shared_ptr<IMPL_SfxBaseModel_DataContainer>::reset() Line 1732
         sfxlo.dll!SfxBaseModel::dispose() Line 794
         swlo.dll!SwXTextDocument::dispose() Line 561
         sfxlo.dll!SfxBaseModel::close(unsigned char bDeliverOwnership) Line 1523
         swlo.dll!SwXTextDocument::close(unsigned char bDeliverOwnership) Line 574
         sfxlo.dll!SfxBaseModel::dispose() Line 745
         swlo.dll!SwXTextDocument::dispose() Line 561
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
         binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
         binaryurplo.dll!request(void * pThreadSpecificData) Line 84
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
         cppu3.dll!cppu_threadpool::ORequestThread::run() Line 165
         cppu3.dll!threadFunc(void * param) Line 190
         sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67
        
        Main thread was acquiring OleEmbeddedObject::m_aMutex, which deadlocked:
        
         sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 65
         emboleobj.dll!osl::Mutex::acquire() Line 63
         emboleobj.dll!osl::ResettableGuard<osl::Mutex>::reset() Line 250
         emboleobj.dll!OleEmbeddedObject::setVisualAreaSize(__int64 nAspect, const com::sun::star::awt::Size & aSize) Line 148
         swlo.dll!SwWrtShell::CalcAndSetScale(svt::EmbeddedObjectRef & xObj, const SwRect * pFlyPrtRect, const SwRect * pFlyFrameRect, const bool bNoTextFramePrtAreaChanged) Line 777
         swlo.dll!SwContentNotify::ImplDestroy() Line 926
         swlo.dll!SwContentNotify::~SwContentNotify() Line 1037
         swlo.dll!SwNoTextFrame::MakeAll(OutputDevice * pRenderContext) Line 584
         swlo.dll!SwFrame::OptPrepareMake() Line 412
         swlo.dll!SwFrame::OptCalc() Line 1110
         swlo.dll!SwLayAction::FormatContent_(const SwContentFrame * pContent, const SwPageFrame * pPage) Line 1960
         swlo.dll!SwLayAction::FormatFlyContent(const SwFlyFrame * pFly) Line 1985
         swlo.dll!SwObjectFormatter::FormatObj_(SwAnchoredObject & _rAnchoredObj) Line 312
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject & _rAnchoredObj, const bool _bCheckForMovedFwd) Line 133
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame * _pMasterTextFrame) Line 414
         swlo.dll!SwObjectFormatterTextFrame::DoFormatObjs() Line 348
         swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction) Line 160
         swlo.dll!SwLayAction::FormatContent(SwPageFrame * pPage) Line 1793
         swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext) Line 605
         swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext) Line 389
         swlo.dll!SwLayIdle::SwLayIdle(SwRootFrame * pRt, SwViewShellImp * pI) Line 2363
         swlo.dll!SwViewShell::LayoutIdle() Line 827
         swlo.dll!sw::DocumentTimerManager::DoIdleJobs(Timer * __formal) Line 176
         swlo.dll!sw::DocumentTimerManager::LinkStubDoIdleJobs(void * instance, Timer * data) Line 156
         vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111
         vcllo.dll!Timer::Invoke() Line 75
         vcllo.dll!Scheduler::CallbackTaskScheduling() Line 509
         vcllo.dll!SalTimer::CallCallback() Line 53
         vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 169
         vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525
         vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
         vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385
         vcllo.dll!Application::Yield() Line 473
         vcllo.dll!Application::Execute() Line 361
         sofficeapp.dll!desktop::Desktop::Main() Line 1652
         vcllo.dll!ImplSVMain() Line 229
         vcllo.dll!SVMain() Line 262
         sofficeapp.dll!soffice_main() Line 110
         soffice.bin!sal_main() Line 51
         soffice.bin!main(int argc, char * * argv) Line 49
         soffice.bin!invoke_main() Line 79
         soffice.bin!__scrt_common_main_seh() Line 288
         soffice.bin!__scrt_common_main() Line 331
         soffice.bin!mainCRTStartup(void * __formal) Line 17
        
        Change-Id: Iaf5133c488d4f26f43530ea19584e99cce12d81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-14  Michael Weghorn  <m.weghorn@posteo.de>  [754a8591f4e8ac6aea06436430e774143b190c81]

        qt: Remove "5" from render backend name
        
        The previously named "qtsvp5" and "qt5" render backends
        are used for both, qt5 and qt6 since the qt6 VCL plugin
        exists, so drop "5" from the name.
        
        Change-Id: Ia97eb14d9229bf33d40a6a383d7656f9467ad460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171854
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-14  Julien Nabet  <serval2412@yahoo.fr>  [53730cc3b0a6b0228f680962f79ae6bec9e7fe02]

        Related tdf#135561: read ase palette with Lab colormodel
        
        I took example on colorConversions.js from avisek, see
        https://gist.github.com/avisek/eadfbe7a7a169b1001a2d3affc21052e
        
        2 steps: convert Lab to XYZ, then XYZ to RGB
        
        credit Avisek Das and István Ujj-Mészáros
        
        Change-Id: I3a80259b6de1aca7fe3c308d9024e9b9f2a5a425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171729
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-14  Justin Luth  <jluth@mail.com>  [893f055c75393e9f0a08823e25ca7ee6703e7ffa]

        tdf#146769 menuBarManager: dispatch with KeyModifier Shift/Ctrl/Alt
        
        If any of the modifier keys are held down while a menu item is selected,
        dispatch the modifier keys along with the command.
        
        There is not anything using this yet,
        but (in an abandoned patch)
        I wanted to let the "Quit" command know if KEY_SHIFT is pressed,
        so I can imagine this ability could be very handy elsewhere.
        
        The infrastructure is all there behind the scenes,
        just this piece needed to be plugged in.
        
        So instead of abandoning it completely,
        let me put this piece in place so it is ready
        for the next guy who could use it.
        
        Change-Id: Iff45928872f8958bdb694771cae8dfb347c646ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171843
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-14  Justin Luth  <jluth@mail.com>  [a104332a59c62305506d80a94d2193f69614d5f0]

        tdf#162458 doc export: don't change "margin" to "page"
        
        I'm a little baffled at this code.
        The only thing I can imagine is that at some earlier time
        it converted TOP of PAGE_PRINT_AREA to FROM_TOP of PAGE.
        That at least was true of my example document in LO5.3,
        and I see similar things happening for horizontal.
        
        For vertical, in the case of FollowTextFlow,
        this is exactly backwards anyway,
        because MSO implements PAGE_FRAME as if it were PAGE_PRINT_AREA,
        which is the exact opposite of what we are doing here...
        For horizontal FTF, there doesn't need to be any adjustment.
        (see tdf#160077)
        
        DOC format knows about all 4 valid vertical positions
        (TOP/CENTER/BOTTOM/FROM_TOP),
        and all 4 valid horizontal positions (LEFT/CENTER/RIGHT/FROM_LEFT)
        and DOC format also knows about both hori and vert PAGE_PRINT_AREA,
        so there is no need to do any adjustment for "margin".
        
        For PAGE_FRAME it is irrelevant because that is what it sets anyway,
        so there is literally no change in that case.
        
        make CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testBnc787942
        make CppunitTest_sw_ww8export \
            CPPUNIT_TEST_NAME=testTextVerticalAdjustment
        
        Change-Id: I201966f00909d4a6e7fcd873582096da259c776d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171842
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-14  RMZeroFour  <ritobroto04@gmail.com>  [641d082c44b189cc476200d9a4b2bb2d68b77627]

        .NET Bindings: Fix netmaker and net_basetypes
        
        This commit makes a few misc. fixes to netmaker and net_basetypes
        - Renamed css.uno.Exception to css.uno.UnoException to avoid name
          conflicts with System.Exception
        - Added a new css.uno.Any constructor and setValue function that
          deduces the type of the any from given object at runtime
        - Changed the AnyTests unit tests to match changes made to css.uno.Any
        - Removed the in keyword from UNO 'in' parameters. Was a premature
          optimisation that might have a negative effect for certain types.
        - Generated struct and exception field members were not marked public
          earlier by accident, fixed.
        - Generted struct and exception constructors had parameters in order
          opposite to expected, fixed.
        - Generated services tried to instantiate the interface, not the
          service earlier, fixed.
        
        Change-Id: Ia63f9db469db13a5d01617617095b8f568b39c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171706
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [14b7b50701e3874034f7f98a73794ba8a79792bf]

        use less exception throwing for flow control
        
        Change-Id: I289f1a2204af02576a585392b7f428a5dc65cf1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171850
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [efe65eaaacfd155bfc38b91f51ed4e7e1d41c659]

        GetMarkStart/GetMarkEnd is hot
        
        when importing docs with lots of fieldmarks.
        But once we have computed the one, computing the other is essentially
        free, so instead of doing the computation twice, return both values when
        we need both
        
        Change-Id: Icdd9d4ed4cf1e6c9b26fdb20507c4f964f9e9f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171853
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-14  Justin Luth  <jluth@mail.com>  [a4418c907fb40707f07a5794dd07a93e51140636]

        tdf#162211 tdf#137590 layoutInCell: vertical escaping with wrapThrough
        
        This patch allows shapes to go "from top" above the cell frame.
        (This was already working horizontally,
        and for positive, downward values).
        
        In theory, this should not be needed for ODT layout.
        ODT UI shouldn't allow cell-escaping values to be used.
        
        It does not currently affect FRAME/FRAME _shapes_
        because those forcefully turn off layoutInCell,
        but it does affect FRAME/FRAME _images_
        whose code path does not forcefully turn off layoutInCell.
        
        There are a few more places in the code
        where AdjustVertRelPos() is called,
        but most had no matching unit tests.
        I assume it is probably because we already don't CheckBottom.
        
        The following unit tests are affected by this patch
        PAGE/PAGE
        -tdf81345.docx (81345_045Original) [big green gradient - fixed]
        -tdf115883.docx [compat15 - miniscule .03cm offset]
        
        image - FRAME/FRAME
        -tdf135595_HFtableWrap_c12.docx [after round-trip - fixed]
        -tdf135595_HFtableWrap.odt [footer logo moves up - fixed]
        -layout-in-cell-2.docx [extremely minor offsets]
        
        make CppunitTest_sw_ooxmlexport14 \
            CPPUNIT_TEST_NAME=testTdf135595_HFtableWrap
        
        These will be affected if layoutInCell is not forced off.
        shape - FRAME/FRAME
        -fdo68607.docx
        -test_segfault_while_save.docx [even zOrder is fixed somehow]
        -layout-in-cell-wrapnone-column.docx
        
        Change-Id: I13b030a2e7117557dd9794c0eb9bd74a0d67b82f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171436
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-14  AhmedHamed  <ahmedhamed3699@gmail.com>  [b8593ef96da5a6090a03812247a0a7c3651546a6]

        tdf#162069 Initial focus is in the document when creating a new sheet
        
        Change-Id: Iabd5401397bbdd5b45275da06235d879ce4ac984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171709
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-08-14  Miklos Vajna  <vmiklos@collabora.com>  [a22fe103e7a26270b7213448c570400a563c18ba]

        Related: cool#9735 vcl lok: add an AnyInput() callback
        
        Open the 300 pages bugdoc, paste a oneliner plain text content in a
        paragraph which is part of a numbered list, observe a 274 ms hang till
        layout is done for all pages, then we get an updated tile. This could be
        better, there is no such hang in the desktop case.
        
        What happens is that 1) vcl doesn't try to invoke the poll callback of
        the LOK client when there was a processed timer and 2) Writer layout
        doesn't try to split its work into pieces because the LOK client has no
        way to inform vcl that it has pending input events.
        
        Fix the first problem in this commit: add a new API that allows a LOK
        client to inform vcl that it has pending input events and use that
        SvpSalInstance::ImplYield(): if a LOK client has pending input events,
        then invoke the poll callback after each processed timer. For example,
        this allows the LOK client to process emitted callbacks between two idle
        layout jobs, word counting, etc.
        
        The second problem around Writer to use
        comphelper::LibreOfficeKit::anyInput() is not yet fixed.
        
        Change-Id: I2e39253bfc4d1b5546bc60eef9ff05ccdc0868b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171846
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d27a88f4fed168068bce5fc36d0bf62301641e25]

        dubious to enable/disable help button based on IsContextHelpEnabled
        
        in just the SingleTabController, which is a specific subset of all
        dialogs, the case of a dialog that hosts a page typically seen in a
        multi-table dialog. Why should such a dialog have no help, while
        its sibling containing the same page alongside others would have help,
        or vice-versa.
        
        Change-Id: I3f54c0088e30a396e83e990510ebe7f1f3bc7bda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-14  Hubert Figuière  <hub@collabora.com>  [67c0fe349aaec504144fe55ce282dbc92aa01b62]

        cool#9699 - Don't show Help button when there is no help
        
        The SfxSingleTabDialogController was explictely showing the Help button even
        if it was previously hidden by the VclBuilder due to lack of Help URL in
        Collabora Online
        
        This was the case in the spelling option dialog.
        See https://github.com/CollaboraOnline/online/issues/9699
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I4454f3d1f0c097faeebf912c3282335fed67ec84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171697
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171847
        Tested-by: Jenkins

2024-08-14  Hubert Figuière  <hub@collabora.com>  [e4eb676691eb75abf3704d46217ff0a9c9edb3bb]

        LOKit: enable the Distribute command
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: Id26ac3cd02198bbd3d4dcf0539cbc372a5e08c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171830
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit d7349b9ac4d56adfaf9bbd7c8dac84152bd230fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171772
        Tested-by: Jenkins

2024-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a42fe00169c3a7d46db2e1a09d4b58b56dfccba]

        tdf#158556 bypass some logic for toggle properties
        
        hardcode a direct route through most of the logic in SwXStyle.
        Shaves 20% off the load time.
        
        Change-Id: I52ae8b4e870e07893195ce2eaedcf9069dbcae8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-14  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [4a0cd8990467466a04bafd7bb1a780247535ab83]

        CairoSDPR: Handle EmphasisMarks
        
        Handling EmphasisMarks for direct text rendering
        was a hard task - the EmphasisMark stuff is deeply
        buried in vcl (would have needed to move quite some
        includes from vcl to public) and thus hard to use.
        It is also quite old (tools Polygon, Rectangle).
        
        It was missing in the decomposition of the
        TextDecoratedPortionPrimitive2D (for good reason),
        but is needed now.
        
        I found a way using a callback lambda function to
        create the needed geometry in vcl and hand back the
        needed data to the caller, in this case to the
        decomposition. Adding it to the decomposition of
        TextDecoratedPortionPrimitive2D also guarantees
        that other renderers/usages will do the correct
        thing and all will look identical.
        
        Interestingly EmphasisMarks were never added to
        Metafiles (see OutputDevice::ImplDrawEmphasisMarks)
        so they were not 'missing' in Metafile-based
        exports. But for SDPRs they have to work. I added
        another encapsulating TextHierarchyPrimitive to
        encapsulate primitives that do represent
        EmphasisMarks and added to ignore these in the
        VclMetafileProcessor2D (as needed).
        
        Change-Id: I5b5c1528d86a123df2beb57d8366f05aa71e77cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171826
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-14  Michael Stahl  <michael.stahl@allotropia.de>  [cf23025faabdae03f4d4706410c80c7c46c683e9]

        package: clarify comment
        
        Change-Id: Id1a262dee4bd182c0aa3f938efb3808e3182602d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171834
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-14  Miklos Vajna  <vmiklos@collabora.com>  [b8374587db8952b8353e815f1e6f3d37b2fe03a1]

        svx: prefix members of SdrUndoSetPageNum
        
        See tdf#94879 for motivation.
        
        Change-Id: I4231a19a562ede125f0f1819cbb224935a20c801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171844
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [437412d79b6b628ab28f15ccdc7aa95fc84cb3c1]

        cid#1557980 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557869 COPY_INSTEAD_OF_MOVE
        cid#1557807 COPY_INSTEAD_OF_MOVE
        cid#1557804 COPY_INSTEAD_OF_MOVE
        cid#1557799 COPY_INSTEAD_OF_MOVE
        cid#1557781 COPY_INSTEAD_OF_MOVE
        cid#1557781 COPY_INSTEAD_OF_MOVE
        cid#1557766 COPY_INSTEAD_OF_MOVE
        cid#1557746 COPY_INSTEAD_OF_MOVE
        cid#1557737 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-14  Heiko Tietze  <tietze.heiko@gmail.com>  [aabb5be81a066c70142e9c15e64ebfbed9994e3c]

        Resolves tdf#80054 - Customization for non-printable character color
        
        Change-Id: I82783a49d3a1c2096dcfa7c97a3fce14c555c988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171814
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-14  HakimOttey  <hakimotteybusiness@gmail.com>  [6aa87b23c445b42690a2461817b7ad24f6c31ec9]

        Related: tdf#42982 replace IllegalTypeException with RuntimeException
        
        Change-Id: Ibe6004e43a7553c6694d7938603023a9f95535a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170035
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-08-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f8c9e602a11e4fb3951a714ce026848aa9419085]

        solenv/bin/uiex: more helpful error message for context issues
        
        Change-Id: I82b092a18b2fa2bacef7a27ad4e79350b42bc1d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171711
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0f186fb79d292d5123153873286addfb29ebd8da]

        UBSan SAL_USE_VCLPLUGIN=qt5 needs SvpGraphicsBackend RTTI
        
        ...as it leaks out of Library_vcl into Library_vcplug_qt5 via
        GenPspGraphics::m_pBackend in vcl/inc/unx/genpspgraphics.h, included from
        vcl/qt5/QtInstance_Print.cxx
        
        Change-Id: Id89217f1eef346b70a7f9269c2dc76e28b78ca69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171835
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-14  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [134fb4747a80726e808909e6a2d2c9aa950bd6d1]

        tdf#158510 Added fallback for media files in MediaWindowImpl
        
        When launching media from Properties -> Media Playback,
        no sound is currently playing. This is due to the fact that
        there is no fallback URL defined for MediaWindowImpl.
        
        To fix this problem, new methods have been added for
        setting and getting the fallback URL, passing the path to
        the presentation folder from "unoshap4.cxx" to
        "mediawindow_imp.cxx".
        
        Because the setURL method starts the media immediately,
        calls to "setFallbackURL" method must be made BEFORE
        calling "setURL".
        
        Change-Id: I3054c90c648c5839a2eb3fc463eaefbf97500c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170644
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [935afa6d82f7c1d799ee15782aae4c686a38e0b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44301eb01fd63f299d8e9d982a4dc31b6ab04a91
          - tdf#102265 - Impress Format menu update
            
            Change-Id: I5c8725b3ebee70e05b82c86bdfc1a180075034d6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171839
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-13  Noel Grandin  <noelgrandin@gmail.com>  [0ad257a6f314aa6e916042b4a5f58683f46f4c13]

        use more concrete UNO type in writerfilter
        
        Change-Id: I9c4a71b1a32bf42ea54ca9f108ee22d4eabc205c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171470
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0e49a0ab061bb46d580fdeddfd2b70951029701]

        cid#1557699 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557696 COPY_INSTEAD_OF_MOVE
        cid#1557695 COPY_INSTEAD_OF_MOVE
        cid#1557690 COPY_INSTEAD_OF_MOVE
        cid#1557671 COPY_INSTEAD_OF_MOVE
        cid#1557661 COPY_INSTEAD_OF_MOVE
        cid#1557626 COPY_INSTEAD_OF_MOVE
        cid#1557624 COPY_INSTEAD_OF_MOVE
        cid#1557622 COPY_INSTEAD_OF_MOVE
        cid#1557618 COPY_INSTEAD_OF_MOVE
        cid#1557617 COPY_INSTEAD_OF_MOVE
        cid#1557607 COPY_INSTEAD_OF_MOVE
        cid#1557559 COPY_INSTEAD_OF_MOVE
        cid#1557538 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8bcd61f21e6b5284d641ff8c6bd09008c2458baf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [ef1eedc76bf8ad0d34a76645e46823d70dd9f59b]

        vcl a11y: Report "top-level"'s frame again
        
        If a top-level windows has a border window that's
        a frame as parent, report that again as the a11y parent,
        which was no longer the case after
        
            commit 97d3baf3f92c4ab3e5dbd5a9c585dd1a1ad2b3d5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 9 15:59:28 2024 +0200
        
                vcl a11y: Don't report parent window for top-levels
        
        Other than the "Save document?" case described in
        the commit message of that commit, where the dialog
        parent is actually a completely different window
        (the LO Writer main window), the "top-level" window's
        frame actually contains the top-level (i.e. they do belong
        to the same window on the platform level), and the frame
        does report the top level as an accessible child, so
        it's consistent to report the parent the other way
        around, too.
        
        This e.g. makes Accerciser's "Inspect under mouse" feature
        work again on Wayland with Accerciser's "kwin" backend
        for e.g. the "Format" -> "Paragraph" dialog in Writer,
        while still working for the "Save Document?" dialog case
        the above-mentioned commit addressed.
        
        It still seems a little odd that the "Paragraph" object
        in the a11y tree with "dialogue" role still has a parent
        of the same name with a "frame" role when using the qt6
        VCL plugin, as can be seen in Accerciser.
        (The "dialogue" AT-SPI role is meant to be an actual
        top-level with no additional parents, and that's the
        way it actually is for the same dialog when using the
        gtk3 VCL plugin using native GTK widgets.)
        
        That's a different story, however. For now,
        report the parent again to have a consistent a11y
        hierarchy.
        
        Change-Id: I07cf287aaf3effbcda0bb4982aafb0fa4bf4f22f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171825
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [e101a7a521195739d6114e939a53dae42768af8c]

        Fix SectionPropertyMap::ApplyProperties_
        
        after
            commit 1e8ace631fb8518cea3fdf94b54e73616d7229c5
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Aug 9 12:38:54 2024 +0200
            use more concrete UNO type in writerfilter
        where I forgot to remove unnecessary logic, so we ended up setting the
        properties twice
        
        Change-Id: Ie1e5aae3ff199c3bec4bf95b0d660461552acb60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171827
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ade52eb721524e3717f47ccd97e0aa2018b96cb0]

        use less exception throwing for flow control
        
        Change-Id: I7ad023479229f89918e588eb8dc7431b5830b45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [cd72aca086ff84467d51f6864c58648c3322c53f]

        tdf#130857 VclBuilder: Move handleAtkObject to base class
        
        Change-Id: I0f29b53b58f2d65d3409f6416406ba21c2411b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171821
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [612d20103f4fd26020c7f5ab7af80a4f504f06a3]

        tdf#130857 VclBuilder: Move handleItems to base class
        
        Let the base class do the parsing for items and return
        a `ComboBoxTextItem`. It has nothing `vcl::Window` specific.
        
        (`vcl::Window` specific part is only when this gets applied
        in `insertItems`, which could probably be reimplemented
        differently for other subclasses).
        
        Change-Id: Ica2f435b48c69fbdfff450b713d91a6fbe985de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171820
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [2833ba26c85b468960f69133941182be0c4ad74e]

        tdf#130857 VclBuilder: Move size group parsing to base class
        
        Move the parsing of size groups from `VclBuilder` to
        the base class, `BuilderBase` and add a getter,
        `BuilderBase::getSizeGroups` that currently gets
        used from `VclBuilder`.
        
        Since the parsing is not specific to vcl::Window,
        make it possible to reuse it from other subclasses.
        It could e.g. be useful for the WIP
        QtInstanceBuilder from Omkar's WIP change [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I0c44bfda1d5c850679695ab6bd436e4e487df9c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171819
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [e19683d65a678a1c47c4af709c761531354d7d25]

        tdf#130857 VclBuilder: Move list store handling to base class
        
        This has has nothing vcl::Window specific, so make it reusable
        by other subclasses, like the WIP QtInstanceBuilder from
        Omkar's WIP change [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I8ef00b9534c8f9d6bf756371133401ac06c05168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171818
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [cfd94adadb88ce0518d61269d47585192b0f0dfa]

        tdf#158556 flatten SwStyleBase_Impl a little
        
        less pointer chasing
        
        Change-Id: I117880dcfaef730f1d19b6b3b4b1f5d8188e0c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171817
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f222adca86d88ce8ee18c50b31485253a5398f9]

        tdf#158556 avoid unnecessary work
        
        in SwXStyle::PrepareStyleBase, which is called multiple times during
        getProperties(), but we only need to do the GetStyleSheetBase() the
        first time
        
        Change-Id: I18438f11402588e5172f6b1638769fc9ba0b1784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-13  Pierre F  <fpy@bger.ch>  [a3111d394d0591f710a9a7754a78b0ab5afcd1a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e0f5a2be15540e180ce9c1873276d185c0ba52fc
          - document word count tooltip in navigator (implemented in 7.0 tdf#63967)
            
            Change-Id: I6136dc2097605159aef537d585f037a46b51cfab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171771
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-13  Mike Kaganski  <mike.kaganski@collabora.com>  [97fa167baa062ef4d26053924527d114e0394fff]

        Handle possible exceptions in SwView::ImpSetVerb
        
        This reportedly may crash on unhandled exception, with the following stack:
        
         KernelBase.dll!00007ffaa227fabc()
         [External Code]
         emboleobj.dll!OleComponent::GetVerbList() Line 1013
         	at D:\lo\embeddedobj\source\msole\olecomponent.cxx(1013)
         emboleobj.dll!OleEmbeddedObject::getSupportedVerbs() Line 1000
         	at D:\lo\embeddedobj\source\msole\oleembed.cxx(1000)
         swlo.dll!SwView::ImpSetVerb(SelectionType nSelType) Line 162
         	at D:\lo\sw\source\uibase\uiview\view.cxx(162)
         swlo.dll!SwView::SelectShell() Line 309
         	at D:\lo\sw\source\uibase\uiview\view.cxx(309)
         swlo.dll!SwView::AttrChangedNotify(LinkParamNone * __formal) Line 574
         	at D:\lo\sw\source\uibase\uiview\view.cxx(574)
         [Inline Frame] swlo.dll!Link<LinkParamNone *,void>::Call(LinkParamNone *) Line 111
         	at D:\lo\include\tools\link.hxx(111)
         swlo.dll!SwCursorShell::CallChgLnk() Line 2903
         	at D:\lo\sw\source\core\crsr\crsrsh.cxx(2903)
         swlo.dll!SwRootFrame::EndAllAction() Line 1941
         	at D:\lo\sw\source\core\layout\pagechg.cxx(1941)
         swlo.dll!UnoActionContext::~UnoActionContext() Line 212
         	at D:\lo\sw\source\core\unocore\unoobj2.cxx(212)
         swlo.dll!SwXFrame::setPropertyValue(const rtl::OUString & rPropertyName, const com::sun::star::uno::Any & _rValue) Line 1605
         	at D:\lo\sw\source\core\unocore\unoframe.cxx(1605)
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
         	at D:\lo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(214)
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
         	at D:\lo\bridges\source\cpp_uno\msvc_win32_x86-64\uno2cpp.cxx(430)
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny> > * outArguments) Line 239
         	at D:\lo\binaryurp\source\incomingrequest.cxx(239)
         binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
         	at D:\lo\binaryurp\source\incomingrequest.cxx(79)
         binaryurplo.dll!request(void * pThreadSpecificData) Line 84
         	at D:\lo\binaryurp\source\reader.cxx(84)
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
         	at D:\lo\cppu\source\threadpool\jobqueue.cxx(101)
         cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169
         	at D:\lo\cppu\source\threadpool\thread.cxx(169)
         cppu3.dll!threadFunc(void * param) Line 190
         	at D:\lo\include\osl\thread.hxx(190)
         sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67
         	at D:\lo\sal\osl\w32\thread.cxx(67)
        
        Change-Id: Ifef15938c7986c4179d61cfa07973ad9b13d4ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171823
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2c2097a826f907cc5c70600c6c71f1d0a9eaeded]

        fix null deref on fetching postit outliner
        
        Change-Id: I950c2c2e68090ad002401d3ff038dcd3d18e7da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171822
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-13  Pranam Lashkari  <lpranam@collabora.com>  [8f591839b9715e186708f661c95a2cf60d63cc73]

        Resolves: tdf#157851 sc comments loaded incorrectly in xlsx
        
        problem:
        1. when loading xlsx files, comments in that format does not store date,
        there for libreoffice loaded comments with current date and time.
        
        2. Author names were not loaded at all in xlsx, and by default
        name of user was used as author instead
        
        Change-Id: I7b1f7fcda01565a6ba131fbae72e7d86e5eaaf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171805
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171809
        Tested-by: Jenkins

2024-08-13  Mike Kaganski  <mike.kaganski@collabora.com>  [65f311e22509b37e14e2429f9f15dd9ed6c07f67]

        Move RTF control word data to where it's used, and make it constexpr
        
        Change-Id: I188207b03dbe45cd353fcb751c90b6f9a1713133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171807
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8d47de1bd283206b7860433a4ee570ed48beda41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f06edc4d07ae6db146347d412e0b975d209271d0
          - Document python comparison operators for UNO objects
            
            Referenced from
            
            https://gerrit.libreoffice.org/c/help/+/65828/2/source/text/sbasic/python/python_programming.xhp#241
            
            Change-Id: I2d28a2d1f432656258fade03a9af0b3ffab119f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171804
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-13  Dione Maddern  <dionemaddern@gmail.com>  [5535804563d5f4d94eb1827c928b68232044e72b]

        tdf#113803 Add Extended Tips for Page Sidebar Deck
        
        Add accessible names and accessible descriptions to:
        - sw/uiconfig/swriter/ui/pagefooterpanel.ui
        - sw/uiconfig/swriter/ui/pageformatpanel.ui
        - sw/uiconfig/swriter/ui/pageheaderpanel.ui
        - sw/uiconfig/swriter/ui/pagestylespanel.ui
        
        In sw/uiconfig/swriter/ui/pagefooterpanel.ui
        - Moved footertoggle to its own row and changed the label to "Enable
        Footer" to make it clear that it does not affect the "Margins" dropdown.
        - Added a new label for the "Margins" dropdown.
        
        In sw/uiconfig/swriter/ui/pageheaderpanel.ui
        - Moved headertoggle to its own row and changed the label to "Enable
        Footer" to make it clear that it does not affect the "Margins" dropdown.
        - Added a new label for the "Margins" dropdown.
        
        Change-Id: I7880a249b534188ea4d981669bdfc969cacd5a5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171430
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-08-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [509aa9e70535ab9b0e317983b1ca0f0423ce70b6]

        UBSan CppunitTest_sw_writerfilter_misc needs the SwXTableRows now
        
        ...presumably since 883febd60593e8a3c0c85c9859006cc0a35b10c2 "use more concrete
        UNO type in writerfilter",
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI12SwXTableRows"
        
        (<https://ci.libreoffice.org//job/lo_ubsan/3273/>)
        
        Change-Id: I856ff7e2d7f31c83ad75b301caf4f8084f3e19a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171806
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c91ae1ec1ae239a3b1438398325b48b04d8a9d82]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0fbb94c57efcb6b30b88a6e181de54651e395e7c
          - Remove "por cada" cacophony in pt-BR grammar check
            
            ref: https://community.documentfoundation.org/t/sugestao-de-gramatica-da-expressao-por-cada/12257
            Change-Id: I3dcd554c29d13e9454ea9556fe469284ff8722a0
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/171802
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [516e9c79093511f0156886e92e1de6bd4918f12f]

        Fix typo
        
        Change-Id: I0495b414fb542b92bdf0e2cde7fe1a010ab315f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171803
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-13  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [afea67b1d324090db05f33a703925cb2926c008d]

        Resolves tdf#162435 - TC author colors inherit anchor colors
        
        Fix to regression from I773793de8cfbdc0d23124db790604b93030375c2
        
        * base color is now anchor, light/dark calculated as luminance
        * default colors adjusted respectively
        
        Change-Id: I9872a959d51714c736cd2adb216d76a0846aeec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171753
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b833e6b121b6ed653e19daa9d2bf0e1899f375b]

        use less exception throwing for flow control
        
        Change-Id: Ib125a5ab01891d4195544e489596c10e16fba3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171808
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-13  Noel Grandin  <noelgrandin@gmail.com>  [00b3d2aa9a8ec1a6af7bb9dbe8affbd8dae2dfeb]

        use more concrete UNO type in writerfilter
        
        Change-Id: Id21630fb997c11574b76f5c22de1a2a31d099d4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [798df0ff16c1cedb1c3f68eddb6c82640ae16d00]

        tdf#130857 VclBuilder: Move collectProperty to base class
        
        With the translation/localization moved to the base class
        in
        
            Change-Id: I2cefddae0a7e2e2dd4487cc9b9796afb215e2616
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Aug 12 12:52:16 2024 +0200
        
                tdf#130857 VclBuilder: Move locale handling to base class
        
        , `VclBuilder::collectProperty` can now be moved there
        for reuse as well.
        
        Change-Id: I159aac8b59dd429b3c7d991c0d2546ae6739bcca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171790
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [013b3895225fbd92c14ecd3c28bd7e1ac9ed62df]

        tdf#130857 VclBuilder: Reuse existing helper method
        
        Reuse the existing helper method
        `BuilderBase::finalizeValue` introduced in previous
        commit
        
            Change-Id: I76a41dbe9c830de02cb38b17d3587d49f64d0ff8
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Aug 12 13:24:46 2024 +0200
        
                tdf#130857 VclBuilder: Extract helper to finalize value
        
        in `VclBuilder::collectProperty` instead of duplicating
        the logic there.
        
        Change-Id: Id04b27e880647150f8fb9aad321e3d216f92844c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171789
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [2244cf03057f57df8a724177c8ed1f48e83c56e0]

        wina11y: clang-format CAccHypertext
        
        This in particular ensures that try and catch blocks
        are indented by an additional indentation level
        as expected, increasing readability.
        
        Change-Id: I82af846dfe9707895d146406b6ed79b5a1f8a467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171798
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [c7060bf1b2cab506a81fdfc40296f3d3e1867898]

        wina11y: clang-format CAccHyperLink
        
        This in particular ensures that try and catch blocks
        are indented by an additional indentation level
        as expected, increasing readability.
        
        Change-Id: I8cfe89e80b9d8713a69037f1f5bda9ee7eaf782a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171797
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [b2a4833ee2a52358ad3dba170d9e4b34cc87c136]

        tdf#130857 VclBuilder: Extract helper to finalize value
        
        Extract helper method `BuilderBase::finalizeValue`
        to "finalize" a value, i.e. translate (if applicable)
        and apply the string hook (if set) from
        `VclBuilder::handleItems`.
        
        It will be reused in `VclBuilder::collectProperty`
        in an upcoming commit to reduce duplication.
        
        Change-Id: I76a41dbe9c830de02cb38b17d3587d49f64d0ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171788
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [8cf0133973a8aaeb0e434cfe758ee2596b604b4b]

        tdf#130857 VclBuilder: Avoid unnecessary work for empty prop
        
        If `sProperty` is empty, `sValue` and `sFinalValue` are
        irrelevant, so only assign (and potentially translate)
        for the case it's non-empty.
        
        This also prepares for extracting part of this method to
        a helper method used by both, `VclBuilder::collectProperty`
        and `VclBuilder::handleItems`.
        
        Change-Id: I5b6acb1fe3c857c578b88b29d0b17e887134f687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171787
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [cad292adaba986c04f5bc8e73c11871075b5abe5]

        tdf#130857 VclBuilder: Move locale handling to base class
        
        * Introduce `ParserState` in the `BuilderBase` base class
          and move the `std::locale m_aResLocale` there from
          `VclParserState`.
        
        * Add a virtual `resetParserState()` method to reset both
          parser states.
        
        * Move `VclBuilder::handleInterfaceDomain` to the base class
          to let it take care of the handling of the translation
          domain/locale.
        
        * Instead of directly accessing the `m_aResLocale` member
          of the parser state, introduce a new getter,
          `getResLocale()`.
        
        Moving more of the members from `VclBuilder::m_pVclParserState`
        to `BuilderBase::m_pParserState` might make sense in future
        commits in order to reuse code for other implementations
        (like the WIP QtInstanceBuilder from [1]), so start
        with a corresponding struct right away instead
        of a member for just the locale.
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I2cefddae0a7e2e2dd4487cc9b9796afb215e2616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171786
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [f2ca1c058b3400db54bd440dd00daf81c9bab04a]

        tdf#130857 VclBuilder: Rename ParserState -> VclParserState
        
        This is in preparation of reintroducing `ParserState` in
        the base class, `BuilderBase`, with the plan to move
        things not specific to `vcl::Window`s there in the longer
        run, for reuse for subclasses not using `vcl::Window`, like
        the WIP `QtInstanceBuilder` from Omkar's pending WIP Gerrit
        change [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/161831
        
        Change-Id: I54758554b0093d3eefcd6f1f13f3479bdd07a0ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171785
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [5fff519d2be5a16be2d7bb22b1f6b6b609132014]

        tdf#130857 VclBuilder: Extract helper for interface domain
        
        Extract a helper method `VclBuilder::handleInterfaceDomain`
        that handles the "domain" attribute for the "interface" node
        that specifies the translation domain.
        
        This is more or less extracted from Omkar's WIP Gerrit change
        <https://gerrit.libreoffice.org/c/core/+/163103/9>.
        
        Co-authored-by: OmkarAcharekar <omkaracharekar12@gmail.com>
        Change-Id: I30ae1362b4d25ca478d2872cd695006a133d73f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171764
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [6c50f685c527f3fa67d7cd9b4842d7e9735e42a1]

        tdf#130857 Drop VclBuilder::m_pStringReplace
        
        Just use a local variable and call the
        `Translate::GetReadStringHook` getter directly in
        the currently 2 places using it.
        (Those will be further consolidated to use a helper
        method in upcoming commits.)
        
        Change-Id: I787a4794e6fd727e19bad12d5f61df66f41964c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171763
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [bfca3583e0df069b9e18ec1d7ca988276cc91f3f]

        tdf#130857 VclBuilder: Move m_bLegacy to base class
        
        ... and introduce a protected getter instead of accessing the
        member directly.
        
        Change-Id: I105cb10b015887ee14bba0c519f03e9ba8b4c3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171750
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [eb7c82c423ee40f78ff48d7e3182b2766ed0f115]

        tdf#130857 VclBuilder: Move 2 static methods to base class
        
        They're not `vcl::Window`-specific and might be helpful
        for other implementations as well.
        
        Change-Id: I8c04706ac36f80bc225a9ad89352b3d4a7c6464f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171749
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-13  Michael Weghorn  <m.weghorn@posteo.de>  [911850e7f3194c1f3d6184ae230b390027909fe6]

        VclBuilder: Drop UStringPair in favor of StringPair
        
        They're the same since
        
            commit 116b9d6ddf2b61186b29f0370234eec9c1bbe306
            Date:   Sun Apr 2 01:18:42 2023 +0300
        
                Avoid conversions between OUString and OString in VCL
        
        , so consistently use `StringPair` and drop
        `UStringPair`.
        
        Change-Id: I7120760b006957a81dfac50c85a00c9583242cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171745
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-13  Moritz Duge  <moritz.duge@allotropia.de>  [6c640ee2662318f32a22d8293ad7498109681933]

        tdf#161909: show where the certs in the CertificateChooser are from
        
        The NSS password dialog naming the Mozilla profile only shows up for
        X.509 certs outside Windows. And the user may wrongly assume GPG keys
        are from Thunderbird.
        
        Change-Id: I23706309d57fe30cddcbcac16d7f3e20ee397f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171645
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-08-13  Moritz Duge  <moritz.duge@allotropia.de>  [684b7b5a8bc9a0632e0cb87c18133814acc20188]

        tdf#161909: show NSS cert DB path (MOZ profile) in password dialog
        
        When selecting a X.509 cert on Unix/Linux/macOS. (ODF+PDF signing)
        
        Helps the user to know which password is requested.
        Previously only asked for the "NSS Certificate DB" password.
        
        Change-Id: Ic44d3c4b2f98185c07b11f9880d64016aa0b60ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171641
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-08-13  Moritz Duge  <moritz.duge@allotropia.de>  [8f9f04297602a29726089227a0903ca177c98f43]

        tdf#161909: make showing GPG keys only an explicit functionality
        
        Before this change, selecting only GPG keys for ODF encrpytion relied on
        the fact, that all X.509 implementations (nss+mscrypt) implement listing
        public keys (getAllCertificates) as a stub.
        See previous change Ia6b8ecb9
        
        Change-Id: Icb36a4cefd60b94407129ff73fe62f9250bfbee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171639
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-08-13  Moritz Duge  <moritz.duge@allotropia.de>  [9383f83b05f3049c350bbc784618da3d6f1a5556]

        tdf#161909: request GPG keys exclusively for chooseCertificatesImpl
        
        For ODF encryption, only GPG keys are allowed. And key selection for this currently only works correctly, because all X.509 implementations (nss and mscrypt) yield empty results when asked for public keys (encryption).
        
        This commit is a first step to make the selection for GPG keys explicit.
        Other code still needs to be changed to make use of this new function
        argument.
        
        Change-Id: Ia6b8ecb901c0f54a9a58b1bd0efaa7154ffbd285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171638
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b05f6d7d5fd85d666a6d8b65864a46eea13b86d]

        cid#1606844 silence Overflowed array index read
        
        Change-Id: I87a0489377b12b930b7aca45c5bf384f28da8ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3bab16f821995e70f03463397020879d30755325]

        cid#1608100 silence Overflowed array index read
        
        Change-Id: I882c93a09697f57971bccfcc74c7cebcc1b265ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7d2a65cca389b38f631b4d5c6edc68a4895f3587]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44b68cf05d29f55f7e86f4b426cf5f20c9933e45
          - tdf#162379 functions AND and OR in array context.
            
            Change-Id: I816cedf34226f0975a3307c08b25f0b922f05b4b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171717
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-12  Pierre F  <fpy@bger.ch>  [e8eb8a651096788b9e0c4d11ffed2d875879aac3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 384d13b8a4793f8aa068f8c73fe8d40b65b1fd3f
          - split syntax paragraph for MID() function / statement.
            
            see also https://ask.libreoffice.org/t/msgbox-statement-vs-function/108929/5
            
            Change-Id: I520df9a2df289e102e265368768e03b53e8c0e2a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171408
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-12  Noel Grandin  <noelgrandin@gmail.com>  [53413b863e1b6df7f4276c54a341ef20fe2fe9a7]

        use more concrete UNO type in writerfilter
        
        Change-Id: Ibbb6faed161c110416a93236eeee6adfa9c2cd86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171796
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed887c85ef2463af1d9c8cbf67c45f6afd4c4d48]

        fix clang crash
        
        with clang version 17.0.6 on openSUSE 15.6 we seem to be getting a crash
        here (originally reported to me by mmeeks)
        
        Change-Id: I7b0b1b986a7f66af988e58d4fec019b9e29a64da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [2e77a93b10399b31882dbba5e5b1f2211f6b5e42]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a9977f6be56c826404b695ce22f61dd4fc8e0e1
          - tdf#155459 Fix grammar
            
            Change-Id: I15f1dfeab5e11bd27feb0d9d9d392c4eba33ecd6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171800
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-08-12  Jim Raykowski  <raykowj@gmail.com>  [4437f5874203298715157cd858caf8cf7992342b]

        Resolves: tdf#112932 Pressing enter in read-ony Table of Content
        
        doesnt jump to heading
        
        Allows jump to heading using the Enter key or key modifier one in
        combination with the Enter key (Ctrl+Enter) when table of content is in
        protected mode. This changes the previous behavior of only allowing the
        Enter key to jump to the heading when the document is in read-only mode
        to also allowing key modifier one in combination with the Enter key to
        jump to the heading.
        
        Change-Id: Ib7451cef40d3ecf56295c2b23a6e663fad18fece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171554
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [a9577dd52d4bcf273bae4abbc8f168eab777172d]

        Another case of pointers comparison
        
        Similar to https://gerrit.libreoffice.org/c/core/+/171756, this was
        this way since commit 7333881bb7b04f7e4e2a28638024ae82a9c14e81 (Formula
        tokens, formula cells and formula interpreters to use shared strings,
        2013-10-11). I don't know if this causes actual problems, but looks
        suspicious, and string comparison compares pointers for optimization.
        
        Change-Id: I544846b8b839606bdf2f118b87e5ea0c5961852f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171757
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [a23662fa4a2093c4d7798b8537ef0303b28e83c3]

        Simplify a bit
        
        Change-Id: I4079253afde4385eeb493cdb701ed735998365d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171768
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [26931fa1ce1c22f0c54ab2916e9924b1c78f8efe]

        tdf#162439: compare strings, not pointers
        
        Change-Id: Id107eaee553531f49da4ad06c681a34cdc08e4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171756
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a9eeeb43c3b0254efbc69be82e1b7c8e34accf7e]

        cid#1608408 silence Overflowed integer argument
        
        Change-Id: I769e235a3fd8760c34c9b31b4b94b652ad74cde5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fc54a739ec51e9ffcf06c87c24dc35a83b6d3534]

        cid#1616198 silence Arguments in wrong order
        
        Change-Id: I7be4ef1b27ddceb8ecdbe67c7985ad1e5bf47c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171759
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6e6451ce96f47e0ef5e8ecf1750f394ff3fb48e4]

        Emscripten: Move the Qt event loop off the JS main thread
        
        ...so that spawning and joining new threads works now and we no longer need a
        hardcoded -sPTHREAD_POOL_SIZE of pre-spawned threads (see
        b84ef4d67eaf9f9fd7fd700ca05339cb0cdff742 "Adapt comphelper::ThreadPool to
        Emscripten's threading needs"; lets keep MAX_CONCURRENCY capped at 4, at least
        for now, though).
        
        This requires
        <https://github.com/allotropia/qtbase/commit/167b08844df06e3cea85c98161b26e97442ab242>
        "Minimal support for Emscripten -sPROXY_TO_PTHREAD=1" and
        <https://github.com/allotropia/qtbase/commit/c722a25630a5390f18a4d974aa942f6376fcb8e1>
        "Implement QWasmCursor::changeCursor for Emscripten PROXY_TO_PTHREAD case" (see
        TODOs there).
        
        Change-Id: I8cea827bd7786e3c9fd9401b4b2bef9d3ec00d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171758
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-12  Michael Weghorn  <m.weghorn@posteo.de>  [221667db03fcefefc07525fb233316c14326901c]

        icon choice ctrl: Drop EVENTID_SHOW_CURSOR
        
        The code that would have posted an event of that
        type was dropped in
        
            commit 40971354138e14a2aacfa4605ba0c096e000d578
            Date:   Tue Mar 1 08:30:03 2016 +0200
        
                loplugin:unuseddefaultparam in svtools
        
        , so there's no need to keep the handling for an event
        that's never emitted in place.
        
        Change-Id: Iec6bf17e040a44eb1dccabbb1273ae112dedc45a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171746
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc9a58ec2f0f0314fb95a17d3f0f5a765120715b]

        ofz: sc-html "ClusterFuzz Unreproducible" reset
        
        so reenable this and bump up min fuzz length
        
        Change-Id: Iaafe917d75c0e9c6482957b368e39196b5c0ead8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171748
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [278cfa9b3042eefe921ee85531f1bbf485a4a76f]

        Simplify a bit
        
        Change-Id: Iff0e31d1f8a9bab30e10164b974622395993b203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171767
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-12  Noel Grandin  <noelgrandin@gmail.com>  [883febd60593e8a3c0c85c9859006cc0a35b10c2]

        use more concrete UNO type in writerfilter
        
        Change-Id: I238cc9f5079dd7b3ca171b6a4b9da12534b53d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ebf13e890766f4cadbba81444784cfe3c8e1bbc3]

        tdf#156857: sd ooxml import: fix shape size if spAutofit is set
        
        and the size of the shape from ooxml file is different then the
        inew calculated by TextAutoGrowHeight.
        
        Furthermore, no need to check and resize the shape size during
        the spell checking.
        
        Change-Id: Iffd15e02579942d4f5f20db73f2194f8298c0838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171621
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9d1f0f58c6e4e343736c8fae3dbcb70de64a7c9f]

        speedup lcl_FillAnnotationStartArray
        
        we can binary search for the start position
        
        Change-Id: Id87d33a191b0a0dcda90aeb149a9e7da4dfd5d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171712
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-12  Noel Grandin  <noelgrandin@gmail.com>  [f0a080babb9ae7bdd9eebc29343017606c5e18bf]

        SwContentIndex owner pointers
        
        we already have two things that "own" a SwContentIndex, for which
        we store a pointer in the SwContentIndex. I want to add more things,
        so rather than add more fields to a very heavily used structure,
        generalise the mechanism so we can store a single field (since
        only thing at a time will ever own a SwContentIndex).
        
        Also add an enum and a GetOwnerType() method so I can avoid
        dynamic_cast, this is a pretty performance-sensitive area.
        
        Change-Id: Ifb03a06b0bb69a325f41a8041e9d23cfc82c3268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171606
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Michael Stahl  <michael.stahl@allotropia.de>  [e6282cff7857999b031bb847a6ca8d996a090db1]

        more_fonts: ship "hinted" instead of "full" for "Noto Sans Arabic"
        
        There is a really annoying problem with "Noto Sans Arabic" on Fedora:
        
        The fontconfig file /etc/fonts/conf.d/56-google-noto-sans-arabic-vf.conf
        in the google-noto-sans-arabic-vf-fonts rpm is sorted before
        /etc/fonts/conf.d/56-google-noto-sans-vf.conf and sets it as default
        without any "lang" restriction:
        
          <alias>
            <family>Noto Sans Arabic</family>
            <default>
              <family>sans-serif</family>
            </default>
          </alias>
        
        This is not an issue with the google-noto-sans-arabic-vf-fonts rpm's
        /usr/share/fonts/google-noto-vf/NotoSansArabic[wght].ttf because it
        contains only appropriate languages:
        
            lang: ar|az-ir|fa|ks|ku-ir|ps-af|ps-pk|ug|ur|ku-iq|ota|pa-pk|sd|lah(s)
            fontversion: 131858(i)(s)
        
        However the instdir/share/fonts/truetype/NotoSansArabic-Regular.ttf
        contains extra languages:
        
            lang: aa|ar|ay|az-ir|bi|br|bs|ch|co|cs|cy|da|de|en|es|et|eu|fa|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|hr|hu|ia|id|ie|io|is|it|ks|ku-ir|lb|lt|lv|mg|mh|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pl|ps-af|ps-pk|pt|rm|ro|sk|sl|sma|smj|smn|so|sq|ss|st|sv|sw|tk|tl|tn|tr|ts|ug|ur|uz|vo|vot|wa|wen|wo|xh|yap|zu|an|crh|csb|fil|hsb|ht|jv|kj|ku-iq|ku-tr|kwm|lg|li|ms|ng|ota|pa-pk|pap-an|pap-aw|rn|rw|sc|sd|sg|sn|su|za|lah(s)
            fontversion: 131727(i)(s)
        
        Now the combination of the rpm config file and the LO bundled ttf causes
        fontconfig to prefer "Noto Sans Arabic" over "Noto Sans" for latin
        script, which is a problem because the fonts have different ascent,
        which causes test CppunitTest_sw_uiwriter8 testTdf157129 to fail in a
        rather non-obvious manner.
        
        Instead of the "full" build of the font, bundle the "hinted" build,
        which contains only appropriate languages.
        
        There is also an inconclusive Fedora bugreport about similar but
        different problem:
        https://bugzilla.redhat.com/show_bug.cgi?id=2262410
        
        Change-Id: I6632ef454191fbb3ebec7c2daa83cc0e6acd829c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171401
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-12  Noel Grandin  <noelgrandin@gmail.com>  [9b7a6c3f2cf3bbdf96517f08ad86c5daa2c1824e]

        use more concrete UNO type in writerfilter
        
        Change-Id: I307f83dc95be7d74ba0b847eb82cca42ac7dbbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23be1f562f1de9e05cfdb0dcbb9757634a20229b]

        ofz#68761 Timeout when fuzzing
        
        Change-Id: Id6612bb33550843a91eb99657d3526391fb44ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171738
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e277b374feb20206f5767eeb486da8edbb15ce92]

        Fix typo
        
        Change-Id: Ia803e09bd581d3d21d2c1df1b9e3a29e219cce20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171740
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e081e03342ca8c262403bd9febdc01151a2935be]

        prevent accessibility check from locking up the UI
        
        there is probably a better approach, and there should be a UI warning
        that the list is truncated
        
        Change-Id: I6df11b16fee3ac6da38e47ac11b1cd0b29e2959d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-12  Michael Weghorn  <m.weghorn@posteo.de>  [82b648edd78ade6051d35657ac8e143946ce1254]

        gtk4 a11y: Avoid explicit std::max template specialization
        
        Thanks to Mike Kaganski for pointing out this is the better
        way to do it in [1]:
        
        > In these cases, it's best to avoid the explicit template specialization,
        > but instead, do something like
        >
        >     std::max(sal_Int32(0), xText->getCaretPosition())
        >
        > because this latter form makes sure that it will not create problems
        > later at some unknown point in time, when we decide to change the
        > type of the returned value of the function. When that happens, your
        > form would silently continue to cast both its parameters to
        > sal_Int32, maybe overflowing. In the proposed form, this max would
        > break again, because the sal_Int32(0) would now not match the type
        > of getCaretPosition, and require us to revisit this code, and make
        > correct changes.
        >
        > It is indeed ~impossible in the specific case of the UNO API method;
        > but the best practice is that, and having inconsistency in the
        > codebase is sub-optimal ;-)
        
        [1] https://gerrit.libreoffice.org/c/core/+/171687/comment/35580611_5d9dfe85/
        
        Change-Id: I489bf4fe5ca12833bc17849434822b984a8586a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171744
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [058f1d1b5246a9d57942541bef144143b0302383]

        tdf#134791 Let options dialog determine its own size based on tab pages
        
        Instead of forcing some random size on it, which leads to widgets being cut off.
        
        Change-Id: I4acd350b380988a2ae7bb091241daa985025b5ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171662
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59cb37a210675d4269c2fcd48feeffe942538891]

        cid#1606900 silence bogus Overflowed integer argument
        
        Change-Id: I227775c53ed041539ea8c6ab80827c7a6cc1db02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171735
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [00ca817d536a510cd0a9164a3652d2446c32c7e1]

        cid#1606650 silence Overflowed integer argument
        
        Change-Id: Iefd28e80400ff3d0bf555996853e6decb3c06079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Dione Maddern  <dionemaddern@gmail.com>  [9740c4e547071e46c7e0c71b09213263808dd071]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f8545f321c3569849c0bde94c225e1af922ed7f
          - tdf#153917 Add hid  bookmark for TOC Entries dialog
            
            In text/swriter/01/04120220.xhp
            - Add a hid bookmark for hid/modules/swriter/ui/toxentrywidget/entry, so that pressing F1 while hovering over widgets in the "Structure and Formatting" section opens the correct help page.
            
            Change-Id: I2445b4464217be20d4161b2ceae560c47aa6c5f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171718
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec63dfe3f47fc6ce0f53312fdb47617a5355fd78]

        cid#1607249 silence bogus Overflowed integer argument
        
        Change-Id: Ib31c6f49a36f4f78bebb0abc164361c7a6e14190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171733
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7056b145691dab9a0220daeecf0625644e176a9]

        cid#1558088 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1558080 COPY_INSTEAD_OF_MOVE
        cid#1558077 COPY_INSTEAD_OF_MOVE
        cid#1558055 COPY_INSTEAD_OF_MOVE
        cid#1558043 COPY_INSTEAD_OF_MOVE
        cid#1558039 COPY_INSTEAD_OF_MOVE
        cid#1558015 COPY_INSTEAD_OF_MOVE
        cid#1558014 COPY_INSTEAD_OF_MOVE
        cid#1558009 COPY_INSTEAD_OF_MOVE
        cid#1558002 COPY_INSTEAD_OF_MOVE
        cid#1557998 COPY_INSTEAD_OF_MOVE
        cid#1557996 COPY_INSTEAD_OF_MOVE
        cid#1557990 COPY_INSTEAD_OF_MOVE
        cid#1557986 COPY_INSTEAD_OF_MOVE
        cid#1557980 COPY_INSTEAD_OF_MOVE
        cid#1557971 COPY_INSTEAD_OF_MOVE
        cid#1557968 COPY_INSTEAD_OF_MOVE
        cid#1557967 COPY_INSTEAD_OF_MOVE
        cid#1557961 COPY_INSTEAD_OF_MOVE
        cid#1557959 COPY_INSTEAD_OF_MOVE
        cid#1557958 COPY_INSTEAD_OF_MOVE
        cid#1557956 COPY_INSTEAD_OF_MOVE
        cid#1557953 COPY_INSTEAD_OF_MOVE
        cid#1557949 COPY_INSTEAD_OF_MOVE
        cid#1557947 COPY_INSTEAD_OF_MOVE
        cid#1557940 COPY_INSTEAD_OF_MOVE
        cid#1557931 COPY_INSTEAD_OF_MOVE
        cid#1557930 COPY_INSTEAD_OF_MOVE
        cid#1557915 COPY_INSTEAD_OF_MOVE
        cid#1557913 COPY_INSTEAD_OF_MOVE
        cid#1557910 COPY_INSTEAD_OF_MOVE
        cid#1557886 COPY_INSTEAD_OF_MOVE
        cid#1557884 COPY_INSTEAD_OF_MOVE
        cid#1557880 COPY_INSTEAD_OF_MOVE
        cid#1557875 COPY_INSTEAD_OF_MOVE
        cid#1557871 COPY_INSTEAD_OF_MOVE
        cid#1557862 COPY_INSTEAD_OF_MOVE
        cid#1557847 COPY_INSTEAD_OF_MOVE
        cid#1557845 COPY_INSTEAD_OF_MOVE
        cid#1557844 COPY_INSTEAD_OF_MOVE
        cid#1557843 COPY_INSTEAD_OF_MOVE
        cid#1557838 COPY_INSTEAD_OF_MOVE
        cid#1557835 COPY_INSTEAD_OF_MOVE
        cid#1557834 COPY_INSTEAD_OF_MOVE
        cid#1557828 COPY_INSTEAD_OF_MOVE
        cid#1557823 COPY_INSTEAD_OF_MOVE
        cid#1557817 COPY_INSTEAD_OF_MOVE
        cid#1557813 COPY_INSTEAD_OF_MOVE
        cid#1557812 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I55d4a920daa2d148683419169eb828325fd3c757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171732
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [85acb1724e617c5f6f4877cf51f11d97691bbb39]

        cid#1608302 XML external entity processing enabled
        
        reformat to get it seen by scanner
        
        Change-Id: I44ce2c6ecd24e81e3b146b7f8b42b51f7d426e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [941c0614ff1821cb5254ed674afdb6283a6a4e60]

        cid#1608541 bogus Overflowed constant
        
        Change-Id: I3785eb10dae32ddd05cfa1a59cdae99965a41169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171730
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a3c6a06f3b3283ce66b3bf2b0e224c4d0d6b32c2]

        cid#1608578 Overflowed constant
        
        Change-Id: Icb68d37af087b01a4e47e2afbc7499d6b3b4cc1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171728
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a18b0b4aa56c47cadd0b6d6d1ad5842cf16e9835]

        speed up menu construction at app startup
        
        we spend a lot of time constructing menus, mostly because we trigger
        events for every tiny change to a menu item
        
        Change-Id: I8f81e406b577c27c9f4bcfe23bf644d751bb5d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f07b271a21f157550f31b4081ba296688305cb3e]

        Resolves: tdf#145847 points only uses one decimal place
        
        while the other use two, and the assumption built in here seems
        to be that there will always be two decimal places
        
        Change-Id: I5718f220c521243b54eba8e19a86f4e86263b69e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f736e3a0c23acf908462bfd184e1224c78244224]

        Related: tdf#154959 suitable label printer paper size not auto-selected
        
        a) If the printer is the default, then it doesn't get a paper size auto
        selected in the paper combobox, even though the preview shows it rendered
        on a paper size that the printer supports.
        
        b) With that fixed, then if the printer is the default one then right
        paper gets selected automatically, but starting with another and then
        switching to it gets different results, so throw away the "page cache"
        on switching pages and get it again.
        
        Change-Id: Idd5254eac2668164b02b41a63943f65a222656d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9555b793082db56ff5b61708bbbd4d4a088ccf4b]

        tdf#162426: make sure to only output new tags after all attributes were written
        
        In commit 03fe839d6e76ed8b1dfb65093ab59a8904852ff6 (html export: rework image
        output to use HTML writer, 2014-09-22), optional export of linebreak tag was
        implemented in the end of SwHTMLWriter::writeFrameFormatOptions. But it is
        called in the middle of img arrtibutes output in OutHTML_ImageStart; so when
        br was output, all following img attributes got discarded.
        
        This makes writing the tag a separate function with appropriate name, which
        is called after all attributes are already written.
        
        Change-Id: I2a7df56e73150d93c565a7240c047b09f3336641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171722
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [54a9b4a20e5da303ed01e570a424f38b49ba911f]

        reduce dynamic_cast and SolarMutex overhead in sw UNO layer
        
        since we can pass the concrete type and avoid a bunch of unnecessary
        work
        
        Change-Id: Ic95e4b4306210a7c11ce70ad981c3dc5b979b402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [473da8d2f046b4ded2feb7d4626e408f481a64a9]

        Fix typo
        
        Change-Id: Id434deda33cc74903183b636e6da4d016e174df7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171715
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [62de2163967c8a55193f126922dc21261644784d]

        speedup sorting of marks in markmanager
        
        when we modify them in ContentIdxStoreImpl, we typically only modify a
        tiny subset of the marks, so do a partial sort instead of fully sorting
        the array. Shaves 10% off the load time of a large docx with lots of
        fieldmarks and bookmarks
        
        Change-Id: Ia271e465fb71559b0d4da3242dc4a6e6f07ddc28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171716
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-11  Heiko Tietze  <tietze.heiko@gmail.com>  [919e13fb3ba254312593727f92a6cf8f060e3051]

        Resolves tdf#61242 - Customization of comment background color
        
        * COL_AUTHOR<1..>_DARK/LIGHT/NORMAL removed Author1..9 added
        * dark variants calculated from light with 50% brightness
        * light does In/DecreaseLuminance(30) and dark (sd) resp. anchor (sw) In/DecreaseLuminance(80) depending on GetUseDarkMode()
        * sw: font color depends on outline background, which now picks up DOCCOLOR; this does not work for dark colors in light mode, for example
        * sd does not update on changes and requires a restart
        
        Change-Id: I773793de8cfbdc0d23124db790604b93030375c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171523
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-08-10  Evaggelou Panagiotis  <e.panos4.mail@gmail.com>  [2fec61240fed71923e5e2172e8536438df2a2432]

        tdf#158803 Fix issues detected by pyflakes
        
        Change-Id: Ifb14cc9dc23c87c79336755544854e4b6681fab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171573
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-08-10  Jim Raykowski  <raykowj@gmail.com>  [cee67dd7d7348f853066a160eed4618dc4ab52ff]

        Resolves: tdf#162392 Impress Sidebar 'Animation' deck text overlaps
        
        by reworking the custom animation list entry item custom rendering
        layout a bit.
        
        Change-Id: I1c71dd5ef40de5369890b0b9aea1294baa3be120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171659
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-08-10  Dione Maddern  <dionemaddern@gmail.com>  [ccf764aaaabd03cf183149838b5573a680d27d22]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 31cafd2cf719c70e6d26be0b2a23f871e0b1583f
          - tdf#162403 Update help page for "Edit Module"
            
            In text/shared/optionen/01010401.xhp
            - Add variable id for H1 so it can be easiliy linked from other files
            - Change heading "Back" to "Reset" to reflect current dialog options
            - Add a Relate Topics section.
            
            In text/shared/00/00000406.xhp
            - Add howtoget information for accessing the "Edit Module" dialog from
            the TabUI
            
            In text/shared/optionen/01000000.xhp
            - Add variable id for H1 so it can be easiliy linked from other files
            
            In text/shared/optionen/01010400.xhp
            - Add variable id for H1 so it can be easiliy linked from other files
            
            Change-Id: I5e708022352763b65b42f24597ad90cb262dc111
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171720
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ee015dc915b3a43e13d2f4c76f2811b36067e835]

        cid#1556058 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556064 COPY_INSTEAD_OF_MOVE
        cid#1556066 COPY_INSTEAD_OF_MOVE
        cid#1556072 COPY_INSTEAD_OF_MOVE
        cid#1556075 COPY_INSTEAD_OF_MOVE
        cid#1556077 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie2992d321ecff15f104547e3a3cad6e8c1a786a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-10  Justin Luth  <jluth@mail.com>  [e21cea677e787b4580cdc14e8b8aaea35bf9574c]

        Revert "tdf#91632 doc import layoutInCell: vert page->margin, *->top"
        
        This reverts commit 183f4e8f1b8dc405e3febd2f0a82769403730a4d.
        
        Reason for revert:build failures. Must be dependent on something the DOCX one is not dependent on.
        
        Change-Id: I81fe415c6ef82d7d100a2c7b99e47c49c4d6423e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171680
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-08-10  Jean-Pierre Ledure  <jp@ledure.be>  [5111caa82918ce02f12abfd02cd61ab9942a3392]

        ScriptForge (SFDialogs) Closure of non-modal dialogs
        
        Before LibreOffice 24.2 the window
        Close button was inoperant.
        Now a com.sun.star.awt.XTopWindowListener
        listener is set on the dialog closure
        by the
           dialog.Execute(Modal := False)
        method.
        
        In summary, when the window Close button
        is clicked:
        - a modal dialog is stopped as if a Cancel
          button was pressed
        - a non-modal dialog is made hidden
        
        Termination and disposal of the dialog instance
        remain roles for user scripts.
        
        This change requires minor changes in the help
        documentation.
        
        Change-Id: Ia4a3e39422b4050fc48f5552fadecfd984e46524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171703
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-10  Michael Weghorn  <m.weghorn@posteo.de>  [7d9acc2862d0c279dbc1b2641a5f6f825eba174f]

        gtk4 a11y: Fix 32-bit build
        
        Take over the fix that Ubuntu has as a patch in its
        LibreOffice package.
        
        Thanks to Rene Engelhard for pointing it out on IRC:
        
            [10:43] <_rene_> michaelweghorn: see armhf and i386 at https://buildd.debian.org/status/package.php?p=libreoffice&suite=experimental. gtk4 and 32bit
            [10:44] <_rene_> michaelweghorn: i saw https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/commit/?h=wip/oracular-24.8 in ubuntu for that somrhow only mentioning armhf
        
        Change-Id: I7666fb56f5e36195d5b320689bed6cfda2140e38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171687
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>

2024-08-10  Justin Luth  <jluth@mail.com>  [183f4e8f1b8dc405e3febd2f0a82769403730a4d]

        tdf#91632 doc import layoutInCell: vert page->margin, *->top
        
        The same thing was done early in this series of patches for DOCX
        
        Microsoft's layoutInCell is very buggy for vertical orientation.
        So, instead of making our own implementation just as buggy,
        instead, alter the document so that the settings match the implementation.
        That way if MSO ever decides to re-fix layoutInCell,
        we are in a position to easily avoid the mapping
        to accommodate a new compat version.
        
        make CppunitTest_sw_ww8export4 \
            CPPUNIT_TEST_NAME=testTdf91632_layoutInCellD
        
        Change-Id: I1a8ad18872ba7c0f08cc5dff517be6e6079e8b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171705
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [97d3baf3f92c4ab3e5dbd5a9c585dd1a1ad2b3d5]

        vcl a11y: Don't report parent window for top-levels
        
        For top-level `vcl::Window`s, don't report any accessible
        parent from the `vcl::Window` hierarchy. Even though e.g.
        a parent for a dialog may be set in the widget hierarchy,
        that shouldn't be reflected in the a11y hierarchy.
        As top-level windows are direct children of the application
        (on Linux) or the desktop (on Windows), reporting another
        window as the parent would be inconsistent.
        
        Reporting the dialog's parent as a11y parent is also
        inconsistent because the parent itself doesn't report
        the top-level dialog as a child either.
        
        With this commit in place, e.g. the "Save Document?"
        dialog in Writer no longer reports the main window
        ("'Untitled 1 — LibreOfficeDev Writer 25.2") as its
        parent when using the qt6 VCL plugin, but reports
        the app as its parent instead.
        
        This makes highlighting the correct area
        work when clicking on any of the children of
        the dialog in Accerciser's a11y tree of the LO
        hierarchy when run on Wayland, and also makes
        the "Inspect under Mouse" feature work to detect
        (and select) the object currently under the mouse
        pointer.
        
        Change-Id: I8c8789cd40598ed9370fa5d34e0429d024af14bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171695
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [b160db48a583bf3657e988f5b6fc7366954fb8da]

        speedup lcl_storeAnnotationMarks
        
        we can binary search for the starting point, and we can exit the loop
        early
        
        Change-Id: Ia1ec208f097d3a20c4188968987be87129d4b659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-09  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [4c1aa38025d79400e0aa539fba2ba8c3f51316f5]

        CairoSDPR: Support TextDecoration
        
        Change-Id: I923069582bb7c5022cfbff7e869c1d577a9123ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171691
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-08-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [523aff41792dd956e2cc1d214fbfc37a04bed1a6]

        simplify makeAnnotationBookmark
        
        it is always called with the same value for the MarkType parameter
        
        Change-Id: If82bb362c2c293e44c200994312ee45b35bc8a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e63da1689db1e3801f0baa149c847dc3712f63cc]

        cid#1556026 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556027 COPY_INSTEAD_OF_MOVE
        cid#1556030 COPY_INSTEAD_OF_MOVE
        cid#1556032 COPY_INSTEAD_OF_MOVE
        cid#1556036 COPY_INSTEAD_OF_MOVE
        cid#1556049 COPY_INSTEAD_OF_MOVE
        cid#1557490 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If694c4d518323a8ae58bb13569f401b2b36cd427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171704
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c71d1c296e8a1976aa418e9a6c8e4af1b157c93]

        simplify
        
        Change-Id: I7d8e8b13166537d0e9c60ff0be01f680a817ca5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-09  Noel Grandin  <noelgrandin@gmail.com>  [dd87f62ed7163098c5497fa1caddfebb947e27eb]

        make writerfilter redlines more type-safe
        
        and pass by const& to reduce copying
        
        Change-Id: I0f21f0b0f9430571292ed2ddabd7cd2b5cc2f093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171694
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-09  Noel Grandin  <noelgrandin@gmail.com>  [1e8ace631fb8518cea3fdf94b54e73616d7229c5]

        use more concrete UNO type in writerfilter
        
        Change-Id: I22b22eebdbff24389e1a4aecb5a089904483207e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171690
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-09  Noel Grandin  <noelgrandin@gmail.com>  [a32457632ffc236a7505c7ef9d5c6433482577a9]

        use more concrete UNO type in writerfilter
        
        Change-Id: Ie2adf7fb339d29f58e4a0eeabe341f57834c77f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171689
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-09  Mike Kaganski  <mike.kaganski@collabora.com>  [8d4d80dd86994fbac570bd92d239bffb7883cf45]

        It seems that SdrPage must not contain nullptr
        
        It takes precautions to not insert nullptr (see SdrObjList::InsertObject),
        so it would be a programming error to find one here.
        
        Change-Id: If5e267743ac6d786575f2c7ca6e7b3e9cc67b082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171671
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-09  Mike Kaganski  <mike.kaganski@collabora.com>  [76a1a9bbb14e6c9278f1e4fc5da1621d748ba3cc]

        Simplify a bit
        
        Change-Id: I5d876ce05f070df48d36acbd988de5781fcd1543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171670
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-09  Patrick Luby  <guibmacdev@gmail.com>  [7b7347bb2112d89b2ad463a464cabe0c8926e0d0]

        tdf#140061 keep SwCharFormat instances alive while SwDoc is alive
        
        Change-Id: I22a7fc1e109e641932f348e9ac3b85f11ce46c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171608
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [da00cd9ef98bd1910be1d91d2d7a57278f818c76]

        Avoid -Werror,-Wunused-command-line-argument in CompilerTests
        
        ...after
        <https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353cf5600e9c>
        "[Driver] Don't claim -c/-S",
        
        > [CPT] sal/qa/rtl/strings/compile-oustring.cxx
        > clang++: error: argument unused during compilation: '-c' [-Werror,-Wunused-command-line-argument]
        
        etc.
        
        Change-Id: I2a128c21fdc8a8858981a359880cf1d92c60cd68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-09  Jean-Pierre Ledure  <jp@ledure.be>  [4591b440697758d0a6b347f1c3ea9fdfa61ad73f]

        ScriptForge Revisit error handling in user scripts
        
        In Basic, any
            On Error ...
        statement resets the Err, Erl, Error$ system variables.
        
        Most ScriptForge public interfaces contain such
        a statement.
        
        To enhance error handling in user scripts, the usual
        interfaces expected in error handling routines
        start (before the On Error statement) with the
        capture of the actual system error status.
        
        The concerned interfaces are:
        - all methods in the Exception service
        - the CreateScriptService() method to create
          the Exception service
        
        The functionality is particularly useful
        to manage user script errors in events.
        
        Only Basic scripts are concerned.
        
        Change-Id: I602311ceedcafddd46481bdd9cc20d9946db3186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171649
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [f45d2fa85ba89eb7d71b51c3324f5938509b3201]

        sw: HTML import: apply existing hard formatting at insert position
        
        When selecting a placeholder field and pasting some HTML over it, the
        existing formatting of the placeholder field is inconsistently retained
        on the first paragraph of the pasted text, but not on subsequent ones.
        
        Fix this by retaining it on all of the pasted text; copy it after doing
        the 2 SplitNode() calls in SwHTMLParser::CallParser() and apply it
        directly to new paragraphs in SwHTMLParser::SetTextCollAttrs() after
        applying the paragraph style (which resets hard formatting).
        
        Change-Id: I8c3596372b415fece46f6bb018cb8c26ff89c5ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171648
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-09  Skyler Grey  <skyler.grey@collabora.com>  [71d98f04b94a34e8174942d594d2bbaa4f2c8455]

        fix(invert): Use separate view IDs when inverted
        
        Previously in Online the document background inversion was tied together
        such that if someone inverted the background, everyone in dark theme
        would end up with an inverted background.
        
        By adding whether the document background is dark to the view render
        state, we can create a new view when the background is inverted, and
        avoid everyone getting an inverted view.
        
        Change-Id: I0aed702185e642f631854b1f8234355c9e69ff6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171664
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9065a5b7b7fdcc2425bac78d64d6deb61edbfc57]

        Under Application::IsOnSystemEventLoop, do nothing in Application::Reschedule
        
        ...as e.g. loading an HTML document via SwHTMLParser calls it at various places,
        presumably to make loading more responsive for the user, but without any
        functional impact beyond that.  So instead of aborting better just do nothing.
        
        Change-Id: I99350ab98b1b75be9a8c7adcc72973174bc258e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171688
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-09  Mike Kaganski  <mike.kaganski@collabora.com>  [3661064257bcd37b5a0a67fe7a675caea5fe5112]

        Refactor SwView::InsertGraphicDlg for clarity
        
        This avoids creation of the dialog, when the name has already
        been passed as an argument.
        
        Change-Id: I94f0634b79f5f3757045cf8fb3f7234381901f50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171673
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [e14fc683536ec2926c70ea94dfd7a549a9bc1460]

        sw: fix SwTextNode::MoveTextAttr_To_AttrSet()
        
        ... and use it on both on the SwTextNodes after the split.
        
        The problem is that it doesn't do anything because it puts a
        RES_TXTATR_AUTOFMT directly into the node's item set, but that can
        contain only RES_CHRATR* items.
        
        Change-Id: I0274652651d1223e905cbd42f4da5458f0106d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171644
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [204e39d0b6958f18b550acc4a99370700db51982]

        sw: AccessibilityCheck: check SwTextNode attr set even if hints exist
        
        This is required for testOnlineNodeSplitAppend if
        MoveTextAttr_To_AttrSet() is fixed.
        
        Change-Id: I2a8815b7426f468bd8a3cdec5dc6e03e6a9ac306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171643
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-09  Miklos Vajna  <vmiklos@collabora.com>  [419c9f40eca646a59b57486ef13f8b8fefb9ba8f]

        tdf#160583 sw HTML export: fix empty field content on copy
        
        Regression from e09d7acd6148b8417487a4473fdc038c7e30d1c4 (sw: fix crash
        in OutHTML_SwFormatField(), 2023-04-24), copy a mail merge field to the
        clipboard using the HTML export, the value of that field is now lost.
        
        Digging deeper, this started with
        1916d161902bdd52b8cfa5b29153c8f8c39fce52 (De-static-izing colors in
        SwViewOption, 2023-03-16), previously the field shading setting was not
        part of the view, so the HTML copy of the document could take it into
        account, even if clipboard documents don't have a view.
        
        Fix the problem by shrinking the scope of the "do we have a doc shell"
        check, so field content is exported again, we just assume that no
        shading is wanted for clipboard documents.
        
        Test this via getTransferData(), normal HTML export would work on the
        non-clipboard document that has a doc shell, and then the problem is not
        visible.
        
        Change-Id: Ib9094eb1d5fc51819279fc58c442e5a507ef2e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171661
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [61702277dcef91c2b38428e1276f484351c8510b]

        we can drop cached text check workaround
        
        the root problem was found as:
        
        commit e75a1eb21834fa872864df2cc5811c6463aceb78
        Date:   Tue Jun 11 11:29:44 2024 +0100
        
            more stale hyphenation data after skipping blanks
        
        commit f050103c3324d878b310f37429ea3580a8230905
        Date:   Fri Jun 7 20:14:15 2024 +0100
        
            stale hyphenation data after skipping blanks
        
        Change-Id: Ia92dcb779ef75d15dd47479458154ba04ff1ef52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170255
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dae592f7741b29898d384e09369956512eed183b]

        cid#1616089 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1616088 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9af46a95aadb7574a32e0542b7e4ed4a8495da5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171651
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fb443c4f8e218dadc9c8d0c85ef61cf4be8f71ef]

        cid#1616070 XML external entity processing enabled
        
        reformat to get it seen by scanner
        
        Change-Id: I9b9a40078e6474d87f4fe7cc6b19992023e24144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171652
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c103bf49619a0a3f0fbb0d89bf3b7e7261a7b8a7]

        UBSan CppunitTest_sw_writerfilter_misc needs the SwXFootnotes now
        
        ...presumably since 5b1bf578fb23ab929602715077138a5362dcb5ce "use more concrete
        UNO type in writerfilter",
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI12SwXFootnotes"
        
        (<https://ci.libreoffice.org//job/lo_ubsan/3268/>)
        
        Change-Id: I3be4a8b804cd02d62e38075b3b601360c5c299ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df385d85b5292749b69c2772cdf35c803ae03b69]

        Fix typo
        
        Change-Id: If3f742f5d0c98e8a60e45ed476cf322ac87ea118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171647
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-09  Justin Luth  <jluth@mail.com>  [31f87f369fdb40fc746d98443d75af2e9ce2452d]

        tdf#162211 tdf#160077 tdf#91632 layoutInCell: vert page->margin, *->top
        
        Microsoft's layoutInCell is very buggy for vertical orientation.
        So, instead of making our own implementation just as buggy,
        instead, alter the document so that the settings match the implementation.
        That way if MSO ever decides to re-fix layoutInCell,
        we are in a position to easily avoid the mapping
        to accommodate a new compat version.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCellD
        
        Change-Id: Ic02a9b12226fd510656444ed37be470455bc4370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171433
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0943769a8c0530dcdaa96ed72ffd36fa2839d2ff]

        Fix typo
        
        Change-Id: Ib6f651bd8ddbb406b7b41710cd9b522011315b66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171656
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [4c42b1c21192eb43648452254d172a1bdcc20cb3]

        a11y: Clarify XAccessibleHyperlink doc
        
        The API looks like it was modeled after
        IAccessible2's `IAccessibleHyperlink` [1].
        
        The doc was saying
        
        > /** Returns an object that represents the link anchor, as appropriate
        >     for that link.
        
        for both, `XAccessibleHyperlink::getAccessibleActionAnchor`
        and `XAccessibleHyperlink::getAccessibleActionObject`.
        
        However, `XAccessibleHyperlink::getAccessibleActionObject` can
        be used to get the link target, not the anchor, i.e. is the
        equivalent of `IAccessibleHyperlink::anchorTarget` while
        `XAccessibleHyperlink::getAccessibleActionAnchor` is the
        equivalent of ` IAccessibleHyperlink::anchor`.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_hyperlink.html
        
        Change-Id: I7e28ac648f698592afb031fcb433f385f902c6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171635
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [95c014c30deef6321ae7bde77caecadb5e986acf]

        sw a11y: Introduce helper method to cast to SwTextFrame
        
        Introduce a new private helper method
        `SwAccessibleParagraph::GetTextFrame` that returns
        the `SwFrame` returned by the base class's
        `SwAccessibleFrame::GetFrame` cast to an
        `SwTextFrame`, instead of casting all over the place
        inside `SwAccessibleParagraph` methods.
        
        Change-Id: Id0be8241acf7cd50a3e16cb1a1f8e6c45aa6ab60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171632
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [cb2b11ed4de8c3d55818da10835f7be17c0b8e94]

        sw a11y: Simplify Reduce nesting when getting hyperlink
        
        In the loop, only iterate over the hyperlinks to find
        the relevant `SwTextAttr`, and move the rest of the
        logic outside.
        
        Throw right away if there's no `SwTextAttr` for the
        given index.
        
        Change-Id: I588df568dceabc5aeb2c8c2f58b04325f2bc16fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171631
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [cc4edd9d4b6db142db21d20390d86cb1982054d7]

        sw: Return early in SwAccessibleParagraph::getHyperLink
        
        Reduce scope of `xRet` and return early for the
        case there is a hyperlink, to simplify this a little
        bit.
        
        Change-Id: Ia9a4a63bbeb1583d798e7521d236220822c5bbe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171629
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [f8efcc70d548870ca715dd76f8d93578bb94740b]

        sw a11y: Use slightly less cryptic var names
        
        Change-Id: Ic8610ba534f400dab2ce5e30f2a74fc125748b63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171627
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [b5e818c8104e7a3c0a153fbe2cd14c8a946c4a1f]

        sw a11y: Drop unnecessary const_cast
        
        A `const SwTextAttr*` is just fine here.
        
        Change-Id: I6b46d47ba9e395e04ca8458b9be0f2e618c94536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171625
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f675638d9cee8ed90eda4f6ecca5f122cfbe3cdf]

        Fix typo
        
        Change-Id: Ib0d3d4b35c6b63189f3fa6b68c73c87f8f3f99dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171657
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-08-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fde7e6f4991fa54c474d25c50e3e7cdf611e45c0]

        Fix typo
        
        Change-Id: Idff087ba5ed07ac914c8c4c568db65ef9397623c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171654
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2ab5c08b29f358a2f9955cb576bb03e67d3577d8]

        Fix typo
        
        Change-Id: I0c2b998511ef417818e7813ae6c87d71de55c963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171655
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-09  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [bf07fa341a72838bd42ea54ce5d09925d75ce700]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8f378c137df5311da024b67b61e230ad1d3d8f0
          - tdf#115884 tdf#133941 tdf#161909 Update help text to match UI
            
            Change-Id: I4611a260674a370f7198554ef022b12b11f186e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171658
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-08-09  Moritz Duge  <moritz.duge@allotropia.de>  [4923331a2bc0c7d31cdb0af18b62f92e8433a071]

        tdf#113278 tdf#115884 tdf#161909: Add X.509 in static labels for PDF signing.
        
        PDF signing only supports X.509 and not GPG.
        
        Change-Id: Ic49e82ebc0c4c2aa69b801e275b9ab7ad6bddaa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171498
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8632088f95050cea4b44b519d04466bb7a98ebac]

        update credits
        
        Change-Id: I5619e8dcc9670ea09f6f27bc15a5b248e83378d9

2024-08-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [649d1bf5729c08b22ee3858e9f019fac47fb3e40]

        Fix typo
        
        Change-Id: I3f4abdeed10c659ec49a6d4601ccef28a991b4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171646
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f25f43763e502b9f967b8e1c826c546d087aec06]

        Update git submodules
        
        * Update translations from branch 'master'
          to 45533a00382950d51c74afc962e9c35d1dea5515
          - update translations for 24.8.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: Ib855d52b14ef3d675be15e941d8eba65eed1a814
            
2024-08-08  Rene Engelhard  <rene@rene-engelhard.de>  [d9e818f3d706145aba95587d685cbcfdeb797edb]

        fix build on armhf with gcc 14
        
        /uno2cpp.cxx: In function ‘void {anonymous}::callVirtualMethod(void*, sal_Int32, void*, typelib_TypeDescriptionReference*, sal_uInt32*, sal_uInt32, sal_uInt32*, sal_uInt32, double*)’:
        /<<PKGBUILDDIR>>/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx:278:5: error: ‘asm’ operand has impossible constraints or there are not enough registers
          278 |     __asm__ __volatile__ (
              |     ^~~~~~~
        make[2]: *** [/<<PKGBUILDDIR>>/solenv/gbuild/LinkTarget.mk:338: /<<PKGBUILDDIR>>/workdir/CxxObject/bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.o] Error 1
        
        Just removing them makes it work, they are mentioned before anyway, too
        (thanks Caolan)
        
        Change-Id: Ibb9118b268a587ebdcfce343e2ee2605ac979915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171650
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-08  Mike Kaganski  <mike.kaganski@collabora.com>  [4cb1849ebd38fde513e15c3087f74871dc5e5124]

        tdf#162398: InsertItem_ may modify items
        
        ... which would invalidate the iterators of the for loop.
        
        Change-Id: I4962441e75a304a46d6f8ef5bc44fae1f4e03cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171642
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [7967d01a5cc9deb76a1c2e72784b7cbc2862fcd7]

        simplify
        
        Change-Id: I771e78413022d0e8ff1ac842d6f6ee38ae3b68f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-08  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [ebe1543250b9729a6560545e58f50ea68e62be11]

        CairoSDPR: Support ColorPolygon with AlphaGradient
        
        Cairo can render RGBA gradients directly and the
        CairoSDPR supports that. If we have a PolyPolygon
        filled with single color combined with a gradient
        alpha the renderer could map RGB to that color
        and combine with the real alpha gradient steps.
        
        To support that I added another Primitive called
        PolyPolygonAlphaGradientPrimitive2D. It decomposes
        as needed (TransparencePrimitive2D if needed), so
        no other renderers have to be touched.
        
        The Cairo renderer supports it directly, though,
        what makes it much faster.
        
        Change-Id: Ie90c8bd84d6458d12443db815ced55bdea93c15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171628
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-08  Moritz Duge  <moritz.duge@allotropia.de>  [b1fcc20db80e7b1ba86594b3eef199965057d499]

        tdf#161909: mention that keys/certs preselection is for ODF only
        
        ODFs can be signed with GPG or X.509, so both key types are listed for
        selection as a permanent setting in the options.
        
        PDF signing doesn't respect the preselected key/cert. And that makes
        sense, because PDFs can only be signed with X.509. So a preselected
        GPG key wouldn't work.
        
        Change-Id: I1b5dc36e40a9a2c82ca9044bf1b481968982befd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171636
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-08-08  Gülşah Köse  <gulsah.kose@collabora.com>  [e0daa8a142387494d8f8b331d0802da552622073]

        ONLINE: Add Invert document background color command.
        
        Change-Id: Ia8868a80e4eba9a9a1c0b31077d9eca0c5b00466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171633
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-08  Noel Grandin  <noelgrandin@gmail.com>  [9612789609a74980447cd0309404cecb125374c3]

        use more concrete UNO type in writerfilter
        
        Change-Id: I46e94d5329cab5922e4a254277d47519076744ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-08  Noel Grandin  <noelgrandin@gmail.com>  [1c4c9bc01572956b7c3cf16e260aed231c8ff510]

        use more concrete UNO type in writerfilter
        
        Change-Id: Ib2c6277f8398e223060440a3844b6d322572d11a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-08  Noel Grandin  <noelgrandin@gmail.com>  [5b1bf578fb23ab929602715077138a5362dcb5ce]

        use more concrete UNO type in writerfilter
        
        Change-Id: I25af4b33b1a1a98e93ff9564175ec4d067b0aae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-08  Justin Luth  <jluth@mail.com>  [2c9f8ad2705834cdbe208373e10a0daad1040fd2]

        tdf#162211 revert "tdf#160077 writerfilter: shape vertRelation is FRAME
        
        ... for layoutinCell"
        
        This reverts my 24.8 commit d210667c72ff821b8cb50b386a83ed55d65ae9bf
        because I'm finding that PRINT_AREA is a better fit than FRAME.
        
        Plus, add a few bits in addition to the revert.
        Restrict killing layoutInCell to shapes
        where the vertical offset is based on the paragraph too.
        (If it is based on the page,
        then treating as FRAME only works correctly
        if the shape is anchored to the first paragraph.)
        Also, just make clear this only makes sense to do
        if layoutInCell is not already false, and if isInTable.
        
        Existing unit tests affected were not interesting:
        -tdf151704_thinColumnHeight.docx [two off-paper textboxes]
        -tdf92157.docx [sync-separated textboxes, not seen in Word2010]
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCellC
        
        Change-Id: I25e9a68f2bc096bddec6ba9d0dc1bb13a226999e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171339
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ce18ff2e7df7f5162ac18da18796b2623b500768]

        cid#1607356 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1607117 COPY_INSTEAD_OF_MOVE
        cid#1607089 COPY_INSTEAD_OF_MOVE
        cid#1606977 COPY_INSTEAD_OF_MOVE
        cid#1606899 COPY_INSTEAD_OF_MOVE
        cid#1606785 COPY_INSTEAD_OF_MOVE
        cid#1606769 COPY_INSTEAD_OF_MOVE
        cid#1606740 COPY_INSTEAD_OF_MOVE
        cid#1606738 COPY_INSTEAD_OF_MOVE
        cid#1606675 COPY_INSTEAD_OF_MOVE
        cid#1606533 COPY_INSTEAD_OF_MOVE
        cid#1558100 COPY_INSTEAD_OF_MOVE
        cid#1558098 COPY_INSTEAD_OF_MOVE
        cid#1558083 COPY_INSTEAD_OF_MOVE
        cid#1558077 COPY_INSTEAD_OF_MOVE
        cid#1558074 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ica17dec2c2102ef85283fd883a0a4e64aec307c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171620
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-08  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [e4a1c45a0bad3677d0b131ef9c6ac6e3c4bdb03c]

        slideshow: change transition drawing view to icon view
        
        Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
        Change-Id: I109d2268824d3be233c5c7b560c1777b95aa4276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171385
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-08-08  Miklos Vajna  <vmiklos@collabora.com>  [e1e77b313c9fe0fff814384a67de415e33c8b27f]

        cool#9735 sw lok: take LOK vis area into account when deciding idle layout
        
        E.g. paste into a paragraph that is part of an Arabic numbering in the
        bugdoc (or perform any other action that invalidates all pages), the
        desktop case does a synchronous layout of the visible page and does the
        layout for the other pages in idle.
        
        The LOK case is worse, there we do the entire layout synchronously,
        which can result in a 274 ms hang for the bugdoc. The root of this is
        that the visible area in Writer is used both to decide if invalidations
        are necessary for that area (this is wanted in the LOK case) and also to
        decide if the layout has to be done synchronously (this is not wanted in
        the LOK case).
        
        Fix the problem by taking the LOK visible area from SwViewShell and
        work with that if possible. This reduces the time spent in the
        synchronous layout to 4 ms.
        
        This should help the interactive editing of large Writer documents in
        general, but pasting into a numbering is a good example, because there
        you can precisely measure if just 1 page is laid out instantly or all
        pages.
        
        Change-Id: Ia423079c76f8d93263a023da4bfbf2a9a5ccbf33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171619
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-08  Moritz Duge  <moritz.duge@allotropia.de>  [156c3c1e5a32d5eee507c3d776574af272f52d21]

        tdf#161909: Show key type in CertificateViewer.
        
        Change-Id: I4277e342c573525dd668d0365b1d686fe33fd914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171500
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-08-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d36dda5d52d56bf684b7ebe3cc26d8c1e49382c0]

        UBSan CppunitTest_sw_writerfilter_misc needs the SwXTextFieldMasters now
        
        ...presumably since 85b2d335a4ec0af84ca4801ba04f45f0ed5a7c10 "use more concrete
        UNO type in writerfilter",
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI19SwXTextFieldMasters"
        
        (<https://ci.libreoffice.org//job/lo_ubsan/3266/>)
        
        Change-Id: I312cad93ec81546bbd7c67ec725815a07378b462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171617
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-08  Skyler Grey  <skyler.grey@collabora.com>  [784a1468354c3ed8a8bdee216771aa234ab38407]

        test: Refactor pixel assertion
        
        When a test fails, the line the assertion failed on is printed.
        Unfortunately, in the case of this assertion, it was always inside the
        same function.
        
        If we instead change the function to only return the pixel color, and
        perform the assertion inside the test, assertion failure error messages
        are more helpful
        
        Change-Id: Ia56da1b245882c8ddbf21ad98f69facc36d3ec3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171593
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-08  Jonathan Clark  <jonathan@libreoffice.org>  [e459d2dc2ddafa14c442132493e39b987892cd16]

        tdf#162358 Fix missing fallback run inside grapheme cluster
        
        This change fixes an issue causing certain diacritics to be rendered as
        the replacement character. The root cause was failing to consistently
        populate fallback runs for the first grapheme cluster, when a layout
        begins inside a grapheme cluster.
        
        Change-Id: I7ce368c815d33b26fc05d726d4f4efd050ed9a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171607
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-08-08  Justin Luth  <jluth@mail.com>  [ce0429edab26e961c73af2d4bdf1516cca05205b]

        tdf#162211 layoutInCell: clean-up unit tests and make some pre-emptive
        
        These unit tests look good with FollowTextFlow killed.
        Ensure the layout, so it still looks good
        when FollowTextFlow is restored.
        
        make CppunitTest_sw_writerfilter_dmapper \
            CPPUNIT_TEST_NAME=testLayoutInCellWrapnoneColumn
        
        make CppunitTest_sw_ooxmlexport20 CPPUNIT_TEST_NAME=testTdf128646
        I tweaked tdf128646.docx's distance of the "FROM TOP"
        to emphasize the problem (that Microsoft mistakenly
        maps "page" to cell margin instead of cell frame).
        
        Change-Id: Ie7f535e4cc516411c57d5658f2b5d146b0925e16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171094
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-08-07  Noel Grandin  <noelgrandin@gmail.com>  [85b2d335a4ec0af84ca4801ba04f45f0ed5a7c10]

        use more concrete UNO type in writerfilter
        
        Change-Id: Ib9b78a7759b783d207fcd0f6db86ca8f95d2e7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171518
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95bda80c626b4632a90e076060f0669146f7ed44]

        cid#1557545 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557556 COPY_INSTEAD_OF_MOVE
        cid#1557583 COPY_INSTEAD_OF_MOVE
        cid#1557587 COPY_INSTEAD_OF_MOVE
        cid#1557591 COPY_INSTEAD_OF_MOVE
        cid#1557598 COPY_INSTEAD_OF_MOVE
        cid#1557600 COPY_INSTEAD_OF_MOVE
        cid#1557653 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I050bed7c088678e1d767d6edbe656eab2aee235d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-07  Jean-Pierre Ledure  <jp@ledure.be>  [4c514dc78b68fc9c69a8425ee93d199bef1deac8]

        ScriptForge - Optimize process synchro between Python & Basic
        
        Tests with non-modal dialogs and sleeping (time.sleep)
        Python processes show a more fluid reactivity
        when a
            Wait 0
        statement is inserted before returning to Python,
        and this at a minimal cost.
        
        Change-Id: I6d69d0e8f2970c7e4bf440fdfa11f2ad7593ac15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171599
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2024-08-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [146fafa691e63de00d6030d88626833ab43d7a65]

        I finally understand why we need that hack
        
        ...that 77129fbb74bcefde4551d494f029169e7c6026e3 "Emscripten: Add hack to
        prepare for --enable-wasm-exceptions" was puzzled about
        
        Change-Id: Iba54a77e3c2a71fe45b97795ca2da0606c3adf41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171594
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-07  Jean-Pierre Ledure  <jp@ledure.be>  [e7aa613e751c159881cb2448d5c7e08549f3fe49]

        ScriptForge - Upgrade to version 25.2
        
        Change-Id: Icc7cbdeed7685118408896c52b0415310d7b20fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171590
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [8950ae3095c43d6217cb53d1e8969ccf3a0b56ac]

        sw a11y: Add a11y names for bg settings in side bar
        
        Set a11y names for UI elements related to the page
        background in Writer's "Page" sidebar deck, section
        "Styles."
        
        Some of those combo boxes/menu buttons are reused for
        multiple background types, so set an a11y name
        depending on the currently selected background
        type in C++ code instead of a static one in the .ui
        file for these.
        
        This allows screen readers to announce what those
        comboboxes/menu buttons are for when they receive
        focus.
        
        Lack of some of those led to gla11y failures in pending
        Gerrit change [1], but is actually a preexisting issue
        as mentioned in [2].
        
        (The gla11y issue even showed up after simply resaving
        pagestylespanel.ui with glade 3.40, see CI failure for [3],
        a previous change doing that in preparation for this
        commit, but now squashed into this commit.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/171430
        [2] https://gerrit.libreoffice.org/c/core/+/171430/comments/6fac1506_50ddcce5
        [3] https://gerrit.libreoffice.org/c/core/+/171582
        
        Change-Id: I4e78c61cfd5d5b9f198887eec53be368cb6a0716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171583
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-07  Michael Stahl  <michael.stahl@allotropia.de>  [0633189fabe85f73062ff2ce67b5f40af7d3f504]

        tdf#162121 sw: fix tab stop position in columned ToX
        
        There is a SvxTabAdjust::End but this only exists in the definition of
        index entry templates, it is not possible to set this on a tab stop on a
        text node.
        
        So the ToxTabStopTokenHandler converts this into a SvxTabAdjust::Right
        tab stop with a fixed position.
        
        DefaultToxTabStopTokenHandler::CanUseLayoutRectangle() has inverted
        condition but that doesn't matter because there are no layout frames at
        that point.
        (regression from commit 3aca57fb9c7c979d971cae6bb3ad73c6dc412685)
        
        The main problem is that getting the with from the layout rectangle
        never works because there's no layout frame, and the alternative only
        takes into account the page dimensions and not any margins of the
        section, columns, or gap between columns, not to mention that the ToX
        could also be in a table etc.
        
        Refactor this so that the tab stops are set only after all the layout
        frames are created.
        
        An unfixable problem remains in case the ToX has columns of different
        width.
        
        The wrong tab positions are problematic if TabOverMargin is enabled
        since commit 10d753b8aadb50ec4309551b97d4cf2163ea3e3d
        
        Change-Id: Ia712c9bf42b2518e396f1b9e7efd65869ebc5ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171585
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [ce871166dad9d1cc618fae1684c8f8031cb4e635]

        tdf#130857 qt weld: Implement newly added 'escape_ui_str'
        
        Implement actual Qt-specific handling in
        `weld::QtInstanceWidget::escape_ui_str`, newly added
        in
        
            commit ee749f4b43fea3b666c9c3613b232bc8fecf73fa
            Date:   Tue Aug 6 16:47:30 2024 +0200
        
                add polymorph function for VCL/ui specific string escaping
        
        For a sample use, see also
        
            commit fb56e1e284925937eff4386a7e3655c0f3182640
            Date:   Wed Jul 31 22:25:01 2024 +0200
        
                tdf#161909: Escape filepaths for password dialog.
        
        (See also `vclToQtStringWithAccelerator`, but which
        would result in the accelerator character '~' to be
        preserved/converted as an accelerator, which is
        unintended here.)
        
        While at it, also fix a typo in the doc.
        
        Change-Id: Ic557a1aa8c6b46257a231627d817f1f7e1d101cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171586
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Miklos Vajna  <vmiklos@collabora.com>  [66e59cd1a988d2c8aa4c81b4183269e2f56e9b9f]

        sw: fix typo in SwLayAction::InternalAction()
        
        Went wrong in commit d491791dad8c3a946dac8c4dfd28ef0c4cb65ce5 (Fix
        infinite loop in sw_ooxmlexport17 unit test on macOS Intel, 2022-12-13).
        
        Change-Id: I4e35702e69016c854d7a17d64c71f07be8d09705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171588
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcf4b998741da342d8612dfa2ac8b9d5d95269d4]

        no need to do lookup here
        
        when we have just created the object, we already know what it is
        
        Change-Id: I79ccc178219ff32a1c88ce7a0b2f4948a6bd4dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171567
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-07  Skyler Grey  <skyler.grey@collabora.com>  [3215fcdc58f0835857dedfc91573b9c891f3ae0a]

        cool#9654 fix: Skip invalidation if it won't go through
        
        On Android, we often hit this condition where we should get an
        invalidation. Unfortunately, the invalidation is skipped due to being in
        LOK Tiled Painting, leaving us to deal with whatever tile was rendered
        on this go-around...
        
        ...Also because of this condition, the tile rendered here is broken.
        pFrame->PaintSwFrame is never called, leading to a tile which renders
        without things like its text. Normally, this wouldn't be a problem as
        it's about to get invalidated, and is more of a nice performance
        optimization...
        
        ...However given we don't invalidate it, we really see that tile without
        any text. Similar workarounds were considered (such as skipping the
        condition in another case that appears to be true on Android or
        rendering the tile anyway, even if we're about to invalidate it) but
        this seems to be the safest bet to avoid something like this happening
        on other platforms...
        
        ...The true solution is still elusive. It probably includes figuring out
        why this happens on Android without happening on other platforms, and
        fixing that, as well as perhaps figuring out what to do about this
        condition if we *do* genuinely trigger it on Android - as the previous
        solution of invalidating everything nearby won't work
        
        Change-Id: Id58f5bae8ae357d116c5f2345e88ec3364cb2172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171578
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c6599ca14ff4ff63224a7e34e93eb30e1ce2adc]

        simplify bookmark name calculation
        
        Change-Id: I19a55158b50ac8b8a66e74484d0dc4b531729de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed172f76005d6e7b861b51199b5d897254b0c76b]

        simplify IMark hierarchy (11)
        
        The only thing using findFirstBookmarkNotStartsBefore is code
        that is only interested in Bookmark's, so change the name
        and return type, and use the m_vBookmarks vector, which is
        much more efficient.
        
        Change-Id: I7f7e6f98b9b7851756c06e57f1cd18cee98713d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [49bca657d7d66ce75a49d2912d1fc86b3e89bcc4]

        simplify IMark hierarchy (10)
        
        use more type-safe container for AnnotationMark, which also avoids some
        dynamic_cast
        
        Change-Id: I1b1d44f81f2a3d626a1f13fbe952eecd1ea0390a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-07  Moritz Duge  <moritz.duge@allotropia.de>  [fb56e1e284925937eff4386a7e3655c0f3182640]

        tdf#161909: Escape filepaths for password dialog.
        
        For example needed for underscores which are removed by VCL=gtk3 when
        interpreted as mnemonics.
        
        Change-Id: Ic80b64efc81ab5a219b1db1395974a4b59c46833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-07  Moritz Duge  <moritz.duge@allotropia.de>  [ee749f4b43fea3b666c9c3613b232bc8fecf73fa]

        add polymorph function for VCL/ui specific string escaping
        
        Change-Id: Ie896a1050158acc85f66b8705812e5f6b9717070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171509
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [3bd2e9db408ebe31e6044ff9e4345692c7496c2d]

        simplify IMark hierarchy (9)
        
        use more type-safe container for Bookmark, which also avoids some
        dynamic_cast
        
        Change-Id: I0d2d94e1f6d4129a6e5edde797c042cab6230bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171563
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-07  Jaume Pujantell  <jaume.pujantell@collabora.com>  [88219419bd99349453471272e9c59424c014826d]

        cool#9704 calc jsdialog autofilter send disabled entry information
        
        Added the code necessary to disable already filtered entries on
        jsdialog autofilter, like it is done on desktop UI.
        
        Change-Id: I095b7fe0054efcaff2717d05a2ab7bd1d8248b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171246
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2815d11bb608a933e14b799cc802825423426d28)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171530
        Tested-by: Jenkins

2024-08-07  Noel Grandin  <noelgrandin@gmail.com>  [3a6e28a489132afd12a9bee023c4ba94a3678e4e]

        use more concrete UNO type in writerfilter
        
        Change-Id: I2b8519f3b07e825ad236cca2cd4028f93c1cb168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171517
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [458b803e4cd5a6e074970c3c4cdeb0762c89df36]

        tdf#130857 qt weld: Implement QtInstanceWidget::get_clipboard
        
        Like the gtk3 implementation, simply return the system
        clipboard.
        
        Change-Id: I643b31163954f2648b3bbee74397fc23c616ddef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171561
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [3f66d9a0b715e2f45e3ebb30d6f65dcf762fbef4]

        tdf#130857 qt weld: Implement {s,g}et_tooltip_text
        
        Change-Id: I02ab861a9e82840c62bbb61ba53a699881519796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171560
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [b3f00e730f5a63b962bea9776238d13c58a412a2]

        tdf#130857 qt weld: Implement QtInstanceWidget::{show,hide}
        
        Change-Id: I557ef20ef0a4d173e5a54a4a568f1ebb127c072e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171559
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [f9fccb9023a2610480dde60d570d2b3f3169de57]

        tdf#130857 qt weld: Implement QtInstanceWidget::has_child_focus
        
        Change-Id: I97ac73943969ecb8f1f189adc1cf4b5c4b052fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171558
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [70b6d20e930453a963118744c747fb08935a86ee]

        tdf#130857 qt weld: Implement QtInstanceWidget::is_active
        
        For now, let it be the same as
        `QtInstanceWidget::has_focus` as there seems to be no
        direct equivalent, and the comment in weld.hxx also
        questions whether there is much value in having two
        different methods:
        
            // return if this widget has the keyboard focus within the active window
            // TODO: review if this has any practical difference from has_focus()
            virtual bool is_active() const = 0;
        
        Change-Id: If90377d734a6c721c369a2d206c0e6122ac61853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171557
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [fcb6b33eafdc756d2c821a58c0e8cdc1f4cc352c]

        tdf#130857 qt weld: Implement focus-related methods
        
        Change-Id: I064ff205ceb9d008667cf3a3a6e73047ea5ca3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171556
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [a8d894be5d6f39b9dde6f144858f58bb1081eb12]

        tdf#130857 qt weld: Implement QtInstanceWidget::{get,is}_visible
        
        Implement according to the comments in include/vcl/weld.hxx:
        
            // return if this widget's visibility is true
            virtual bool get_visible() const = 0;
        
            // return if this widget's visibility and that of all its parents is true
            virtual bool is_visible() const = 0;
        
        Change-Id: Ic3a6193b04094331ec3818620c078269409c4fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171555
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [0d8d95cadf4ead4418bdae5bc519a944a2fae260]

        tdf#130857 qt weld: Implement QtInstanceWidget::{g,s}et_sensitive
        
        In a quick test, this makes the "More" button in the dialog
        from the tdf#162351 use case to become insensitive (i.e. greyed
        out) as expected with this additional local change applied for
        testing:
        
            diff --git a/dbaccess/source/ui/dlg/sqlmessage.cxx b/dbaccess/source/ui/dlg/sqlmessage.cxx
            index 07891f773cfd..ad06210c8149 100644
            --- a/dbaccess/source/ui/dlg/sqlmessage.cxx
            +++ b/dbaccess/source/ui/dlg/sqlmessage.cxx
            @@ -509,6 +509,7 @@ void OSQLMessageBox::impl_addDetailsButton()
                     m_xDialog->add_button(GetStandardText(StandardButtonType::More), RET_MORE);
                     m_xMoreButton.reset(m_xDialog->weld_widget_for_response(RET_MORE));
                     m_xMoreButton->connect_clicked(LINK(this, OSQLMessageBox, ButtonClickHdl));
            +        m_xMoreButton->set_sensitive(false);
                 }
             }
        
        Change-Id: I0b7a21364eddb707435a796c54b274ff438f8063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171553
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [c1d671b0d89e1af4e629e11366b1f678f689e152]

        tdf#162351 tdf#130857 qt weld: Handle button click
        
        In `QtInstanceButton`, connect the
        `QPushButton::clicked` signal with a newly introduced
        slot that calls `signal_clicked` from the `weld::Button`
        base class, which calls the click handler.
        
        With this in place, clicking the "More" button
        in the dialog shown when following the steps from
        tdf#162351 now actually results in an "Error Details"
        dialog with more information to show up.
        
        Change-Id: I6df43af3ad3bf35b94e712aaaf0158bd7ab57907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171552
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [573f21a6383cec270a9d25dfafb87a8241cbc5de]

         tdf#162351 tdf#130857 qt weld: Implement weld_widget_for_response
        
        ... for `QtInstanceMessageDialog`.
        
        This fixes the crash reported in tdf#162351 due to a nullptr
        deref in `OSQLMessageBox::impl_addDetailsButton` that was seen
        with the base class implementation
        `QtInstanceDialog::weld_widget_for_response` that
        just returns nullptr.
        
        Clicking the "More" button in that dialog doesn't
        yet show the corresponding dialog, but that will
        be implemenated separately.
        
        Change-Id: I8cd4fac4fd57be993dba1713bb2e19860dfc334b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171551
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [877075e3abe5378b359cf7f069a859b91eb2d6d7]

        tdf#162351 tdf#130857 qt weld: Extract helper function to get button
        
        ... for response code.
        
        The new helper method
        `QtInstanceMessageDialog::buttonForResponseCode`
        will be reused elsewhere in an upcoming commit.
        
        Change-Id: Ie7ee065fb68f936b79ac96ba70dc85ffa18c9859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171550
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [f0ad3a95c1e841281048a784bd96e8d34e090c5b]

        tdf#162351 tdf#130857 qt weld: Add basic QtInstanceButton
        
        Add a very basic native Qt implementation for `weld::Button`.
        It currently doesn't really implement many methods and
        just triggers an assert when they get called.
        
        Change-Id: I7a15266e978ca3bb030c847822a82d8d58c4c189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171549
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [2d08e1e348d99b55a6b58f94a57d7f68f59e63f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f15160e46f503beb4c8d0f6442be2a2bc6cf036
          - Don’t localize file extensions
            
            Change-Id: I73b2200c8a2a2069b2fe799181b524674c6a6442
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171576
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-06  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [c399b5b2c3f49a012fb8a3ffdd74fc66424f5bba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1544cc6acf3c32f80d5cb76c90aeef04e1e5265f
          - Remove unnecessary comma and add missing article
            
            Change-Id: Ie6d2eba45357e55d3b8c564213b43661d5f4afff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171574
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [336d5403099a68d561c499a24af4027a3a8a190b]

        Ref: TDF#157930 Refine conditionaleasydialog.ui
        
        + Add Help button
        + Add extended tips
        + reword labels
        
        Change-Id: Ic1b24aedc3eb4c43fc1cf19f6bbcb8b3b72c94e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171210
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59768e605182dde4aabfd384d38b47b6317022e2]

        cid#555593 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555849 COPY_INSTEAD_OF_MOVE
        cid#1555936 COPY_INSTEAD_OF_MOVE
        cid#1555951 COPY_INSTEAD_OF_MOVE
        cid#1555955 COPY_INSTEAD_OF_MOVE
        cid#1555960 COPY_INSTEAD_OF_MOVE
        cid#1555964 COPY_INSTEAD_OF_MOVE
        cid#1555965 COPY_INSTEAD_OF_MOVE
        cid#1555975 COPY_INSTEAD_OF_MOVE
        cid#1555979 COPY_INSTEAD_OF_MOVE
        cid#1555987 COPY_INSTEAD_OF_MOVE
        cid#1555990 COPY_INSTEAD_OF_MOVE
        cid#1555991 COPY_INSTEAD_OF_MOVE
        cid#1556002 COPY_INSTEAD_OF_MOVE
        cid#1556008 COPY_INSTEAD_OF_MOVE
        cid#1556011 COPY_INSTEAD_OF_MOVE
        cid#1556015 COPY_INSTEAD_OF_MOVE
        cid#1556017 COPY_INSTEAD_OF_MOVE
        cid#1556023 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8ab99d8e52a1780173a4272c59d408432c29de9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fdc9c3d592f8a0d4ad75910f2a23ae77a14c3328]

        cid#1615230 silence Overflowed constant
        
        Change-Id: Iffa09b68794ff7942c1d2780097f0021c070ed96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [40686d6c2fcccadc2004f187c443f105ef5fe070]

        cid#1607096 silence Overflowed constant
        
        Change-Id: Ifa89ef67ffd7f5842c60a34f6705365f3de94770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171570
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Jonathan Clark  <jonathan@libreoffice.org>  [981c5780da8ec6b6878de58909b7cc7e736ad33a]

        tdf#160786 sc: Fix repeat char format code inaccuracy
        
        Number format codes allow arbitrary repeat characters. These repeat
        characters are inserted while formatting numbers to pad strings to the
        width of the containing cell. For example, this is used in some default
        format codes to left-align currency symbols with right-aligned digits.
        
        Previously, Calc determined the number of repeat characters to insert
        based on the assumption that the pixel width of a string containing N of
        the repeat character would be N times the pixel width of a string
        containing 1 of them. This is not a safe assumption.
        
        This change updates the algorithm to instead look at the average width
        of a repeat character when used in context as part of a padding string.
        This approach is still not entirely correct - it doesn't account for
        ligatures around the padding sequence, for example - but in practice it
        is a reasonable compromise between cost and accuracy.
        
        Change-Id: I240cf38ec0376ee2d2896e7a7da6760a374b3034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171548
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [166f0bcae39d4b6842f7578afb28fff3cf950d68]

        cid#1606751 silence Overflowed array index read
        
        Change-Id: I92dd8fb7212bbf8935ed6f312ef7bd3775b5b8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171569
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-06  Michael Meeks  <michael.meeks@collabora.com>  [b954a2409bdae5b22e35c150ca035a3b3d43538f]

        Avoid excessive progress updates unconditionally.
        
        This may make short lived progress bars somewhat more 'blocky' and less
        smooth - but inevitably make loading faster, particularly for loaded
        machines with ultra-beautiful, slow to render themed progress-bars.
        
        Change-Id: I5a7e43690f5e7eff35c980cae4991376204eb5fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [ad24ca100f0785f1ff638a2e06e72784bf3c4151]

        tdf#162370: check if nNext is valid, too
        
        0xfff is a special value for a style slot on MS formats export: see
        MSWordStyles::GetSlot and BuildGetSlot. The slot in nNext must be
        checked the same way as nBase and nLink around it.
        
        Change-Id: I94836bc3f624eb99655e005217707e0ea7210c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171547
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-06  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [bece17ca694093f9cd19ec99e45f5e603ecd2851]

        CairoSDPR: Support TextBackgroundFill
        
        Change-Id: Ifa00a230ad88d49ccda7c7f47b3d87870d4dfc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171489
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-08-06  Adam Seskunas  <adamseskunas@gmail.com>  [f8eac9eaf0b513460341ef158b610865d68fd536]

        tdf#135710 - Add Unit test
        
        Change-Id: I17189845ba273f1843a922e5b8aa521a8580dcb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171467
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-08-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [860c8c7262fced0284994cf8421f3916abd27be9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c289e0b3649626a7b88aa88c0106f2f9b2251c8a
          - Place find toolbar in 02 folder.
            
            (folder 02 has most of toolbars help pages)
            
            Change-Id: Ib5c4dadc3c2be386ff105e60081912904f25a7ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171488
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-06  Adam Seskunas  <adamseskunas@gmail.com>  [11fa654dab2b7e35d724c804e1a11a1d72dde88e]

        tdf#122452 - Add Unit Test
        
        Change-Id: Ifce16dd9ec093c515e61f65b58e0414b1a157a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171126
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-08-06  Noel Grandin  <noelgrandin@gmail.com>  [6addfadec1794679fc44613fd8067914a4685560]

        use more concrete UNO type in writerfilter
        
        Change-Id: I468f3b4b6e3ccf2221ad1f5088f2b4a009966c0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171469
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [1bc52b8ae3b7913eef449ecfa5b807784fb760f3]

        Simplify a bit
        
        Change-Id: Iffc22c60572f230e3c13d6e4de89856d50244eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171521
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a5b08e3ad777295e5977eb9880184fc3ad21249f]

        ofz#70966 use final upstream fix
        
        Change-Id: I8423be9fdcd0c224d5d7993a4d982176c404035d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171520
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [900af9c53788d5d274900f796e3aee14926abf2d]

        reduce use of dynamic_cast in marks
        
        which is hit quite hard during import of documents with lots of marks,
        mostly because of the resorting that occurs in
        ContentIdxStoreImpl::Restore
        
        Change-Id: I1e5e3d8cfc0e65f9bf74449df8e048cd061022ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171522
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-06  Moritz Duge  <moritz.duge@allotropia.de>  [a833f9dfc7e1f0bd865c01d9b777cd44b8a6f767]

        tdf#133941 tdf#161909: Label the "Certificate Manager" with "GPG".
        
        Change-Id: I74a7349ece014f7bf26dd8d75723751b344f1b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171499
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-08-06  Sven Göthel  <sven.gothel@collabora.com>  [ca466a4a01657e2dad61ca909bd6ab5188f8ccc9]

        cool#7710: Make Slide Properties Dialog in Impress Async
        
        How to reproduce the synchronous dialog:
        - Build in debug mode
        - Click on 'Format' menu, then sub-menu 'Slide Properties'
        - The sync-dialog warning shows up
        
        This commit updates the dialog from synchronous to asynchronous processing.
        
        How to manually test the asynchronous dialog:
        - Apply patch
        - Build in debug mode
        - Click on 'Format' menu, then sub-menu 'Slide Properties'
        - The 'Slide Properties' modal dialog box opens and is functional.
        
        Tested manually within COOL 24.04 (online) with
        - Changing aspect-ratio and background color
        
        FuPage's lifecycle is extended by wrapping itself into rtl::Reference<FuPage>
        and passing a copy to the async-action lambda-capture,
        as it is being called from FuTemporary and managed as rtl::Reference<FuPoor>.
        Otherwised resources are passed to the async-action simply using std::shared_ptr<>.
        
        Signed-off-by: Sven Göthel <sven.gothel@collabora.com>
        Change-Id: I692204403e8a6ee526e7b463c8bf8a41c1416489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171393
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171508
        Tested-by: Jenkins

2024-08-06  Miklos Vajna  <vmiklos@collabora.com>  [cf22d66c5837f108296b37bc98f17ee96869a7ef]

        Related: tdf#162295 DOCX import: optimize copying headers/footers
        
        The original DOCX bugdoc has 150 sections on 88 pages, which means that
        copyHeaderFooter() in the domain mapper is a significant cost.
        
        Setting a property on a page style involves making a copy of the
        SwPageDesc, working on that copy and then copying it back. Which means
        that setting UNO properties one by one vs working via
        setPropertyValues() is a big difference.
        
        - old cost: 11984 ms
        
        - new cost: 7764 ms (65% of baseline)
        
        Change-Id: Iea99fb3ad9d3e61494c9f012c4c7fa10cc7ab09d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171519
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [39616be78b2e2744e08c65af217d23e1db4a1e27]

        Fix typo
        
        Change-Id: Ia32b0224be6cda50ece367b9bc30813ce62f5655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171504
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [40f97d1cf52490e8ae1b24833af07843e47f98e8]

        ofz#70966 Integer-overflow
        
        Change-Id: If91c4db8e1180f6408ef72031299f0b88e3c9a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171510
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [874e93d02ae4875db226a855ac06c33d3b093cd5]

        Resolves: tdf#141398 auto-select first entry of filtered results
        
        apparent regression from:
        
        commit c403c86c6da4db0a6f2864ad4e13def9a3898cd4
        Author:     Caolán McNamara <caolanm@redhat.com>
        AuthorDate: Sun Mar 17 19:22:08 2019 +0000
        
            weld SwFieldRefPage
        
            Change-Id: I5ae3965aa681ea1f5a005fbc8dad4d0ce36af1b3
            Reviewed-on: https://gerrit.libreoffice.org/69373
        
        Change-Id: Icb868403d31e1a6b57ae957f4eb98deafcc7f940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171514
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac0514fb3d7e93c06242dc72c5f56031dcb8a3c9]

        cid#1555415 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555430 COPY_INSTEAD_OF_MOVE
        cid#1555497 COPY_INSTEAD_OF_MOVE
        cid#1555542 COPY_INSTEAD_OF_MOVE
        cid#1555543 COPY_INSTEAD_OF_MOVE
        cid#1555564 COPY_INSTEAD_OF_MOVE
        cid#1555593 COPY_INSTEAD_OF_MOVE
        cid#1555602 COPY_INSTEAD_OF_MOVE
        cid#1555610 COPY_INSTEAD_OF_MOVE
        cid#1555667 COPY_INSTEAD_OF_MOVE
        cid#1555693 COPY_INSTEAD_OF_MOVE
        cid#1555719 COPY_INSTEAD_OF_MOVE
        cid#1555757 COPY_INSTEAD_OF_MOVE
        cid#1555795 COPY_INSTEAD_OF_MOVE
        cid#1555826 COPY_INSTEAD_OF_MOVE
        cid#1555847 COPY_INSTEAD_OF_MOVE
        cid#1555851 COPY_INSTEAD_OF_MOVE
        cid#1555863 COPY_INSTEAD_OF_MOVE
        cid#1555865 COPY_INSTEAD_OF_MOVE
        cid#1555867 COPY_INSTEAD_OF_MOVE
        cid#1555869 COPY_INSTEAD_OF_MOVE
        cid#1555879 COPY_INSTEAD_OF_MOVE
        cid#1555890 COPY_INSTEAD_OF_MOVE
        cid#1555893 COPY_INSTEAD_OF_MOVE
        cid#1555900 COPY_INSTEAD_OF_MOVE
        cid#1555922 COPY_INSTEAD_OF_MOVE
        cid#1555925 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-06  Eike Rathke  <erack@redhat.com>  [6e12713a7938e464b55a54b9dfd662000057a85f]

        Do not assert TableRef inner reference for dumb sequence, tdf#159343
        
        ... of FormulaToken that's only created to extract a range from an
        expression because that OOXML import part doesn't know to operate
        on a ScTokenArray.
        
        Change-Id: I4011723b682c3eae0e1c8d8e768553154c024061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171516
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [56796ffc8f58c99204638702a0e09308956a4b99]

        simplify IMark hierarchy (8)
        
        we can declare the fieldmark methods with better type-safety now, and
        with much less dynamic_cast
        
        Change-Id: Ia515050967afdee191b96dd81b139d89be9179df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [b25164a3a4c47a9c5a9f31a8feb08a8aa0f8f401]

        tdf#162340: handle target column scale in setObjectWithInfo
        
        In commit f1121362f3dd4287577dd7952c6f00a524a81111 (tdf#156530: fix
        OPreparedStatement::setString, 2024-07-03), I misused the method's
        'scale' argument, as the number of decimals in the target column.
        It seems that the method was modelled after JDBC's setObject taking
        four arguments [1], which use is also unclear to me, but it likely
        is intended to describe input data. Anyway, all our implementations
        either pass the scale to next implementation, or ignore it.
        
        The problem was when 'x' was a string like '0.1370', and 'scale' was
        0. The passed 'scale' was used, instead of the target column's; and
        that incorrectly truncated the number to 0.
        
        [1] https://docs.oracle.com/javase/8/docs/api/java/sql/PreparedStatement.html#setObject-int-java.lang.Object-int-int-
        
        Change-Id: Ib507d32706551517cc0a8a3cba351093549d7026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-06  Michael Weghorn  <m.weghorn@posteo.de>  [d76a932e7b98cfcc955911321116bb396c3cb790]

        tdf#150397 vcl: Don't select SalInstanceTextView text on focus
        
        Disable selecting the text view's text when receiving
        keyboard focus (see `TextWindow::GetFocus`) for the
        `SalInstanceTextView` implementation.
        
        This aligns this with the GTK implementation
        (`GtkInstanceTextView`) that also doesn't do that.
        
        This e.g. prevents selecting the full license
        text in the license dialog when installing a
        new extension when the qt6 or gen VCL plugins
        are used on Linux.
        
        Change-Id: I2f57848f441387fe03abb6d6163416c830cebc4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [aed5979ecc6befd64a024ba07064696f24640fec]

        Fix off-by-1 error
        
        Regression after commit af5a1b5925dbc816dced8813282d953fd5adbaaa
        Drop uses of css::uno::Sequence::getConstArray in dbaccess, 2024-04-30.
        
        Change-Id: Ifaecdeb2898f2e9089b1f893a1e9ba46352cc353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171505
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [ec5235ddfd62ca490d13fbc2c91e740a44f9950e]

        tdf#159146 Fix layout after resizing commend width in Writer
        
        This patch ensure that resizing the comment sidebar will update the entire layout.
        
        Change-Id: Ia3c805569525c558191b253d694ac1f2e99f2ace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171039
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7e464f04014f820f3e935708de432205a7507b1e]

        Fix CURLSHOPT_UNLOCKFUNC function signature
        
        (cf. <https://curl.se/libcurl/c/CURLSHOPT_UNLOCKFUNC.html>; I noticed this with
        an experimental Emscripten --enable-curl --with-webdav build that failed with a
        "RuntimeError: null function or function signature mismatch" during the call to
        
        >     rc = curl_easy_setopt(m_pCurl.get(), CURLOPT_SHARE, g_Init.pShare.get());
        
        in the CurlSession ctor)
        
        Change-Id: Iec4bd5a263484e2e615d0b7bb08928feb7dc4658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171487
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-05  Moritz Duge  <moritz.duge@allotropia.de>  [25331a0e4a8ca6dc61fcbe57ba9c032d809d3915]

        Resave with newer Glade version
        
        Change-Id: I225dba56297d8b8022eb02ea296cda72c57cd306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171496
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [755330cbaf8b0c924cbe46ac62986576b523e3d0]

        cid#1616049 Use of auto that causes a copy
        
        and
        
        cid#1616044 Use of auto that causes a copy
        
        Change-Id: Idb8e7abb72c5a3b2492f48bd617c0f297bb200da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171478
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e67e5155709bc1b39779750a194a535ae4e28e83]

        fix @since tags
        
        after
            commit 1bbcc3fdf312971ffb681b332f47369739d95dde
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue May 14 14:56:47 2024 +0200
            O[U]String overloads that return view for rest parameter
        
        Change-Id: Ie1d844f4286a14aa9d7cbb3831460c17103582c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [73f39720dfc0450b8b179c6c516dc578684af40e]

        Fix typo
        
        Change-Id: I38f2c4a86ac65e3e7014108153b937eb6f755371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171495
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-05  Michael Meeks  <michael.meeks@collabora.com>  [c41401adeb97de52df75ce55e17efc6d2d8c77d1]

        lok: avoid excessive progress updates.
        
        Perhaps for desktop 40 updates per second can provide a nice smooth
        status experience for a full screen-width progress bar in some cases;
        but it seems likely that five per second over a remote protocol
        might be better.
        
        Change-Id: Ic77b3b76d680771cb766984bdbcd9c8af4af303d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171407
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [43a72edb16545300352e49c00811634430e1ea4f]

        vcl: Drop obsolete CUPS version check
        
        This CUPS >= 1.7 version check was was introduced back in 2017 in
        
            commit 7fbf98d99737ac916cc2dc374f3139e2ea81e47b
            Date:   Thu Jul 27 08:11:34 2017 +0530
        
                Add Common Printing Dialog Functionality
        
        and is obsolete by now.
        According to [1], our AlmaLinux baseline has CUPS 2.2.6
        by now.
        
        Replace by a simple check whether CUPS is enabled for
        the build.
        (`pwg_media_t` used in that conditional code block
        is from a CUPS header and e.g. not available in
        the Android CI builds, see [2].)
        
        [1] https://pkgs.org/search/?q=cups
        [2] https://ci.libreoffice.org/job/gerrit_android_x86_64/40875/console
        
        Change-Id: I4683c86c2c9e44ff41ee8093d8f045bc955cba99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171485
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [afe5e625c3bd4ce939152e15baa46d3834244377]

        Fix typo
        
        Change-Id: I5cef95873cd6a67ba2994dcb6c2c8ed231c0b2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171494
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-05  Michael Stahl  <michael.stahl@allotropia.de>  [c9f801f527634a4ec1b5712d345a5ff669e26bbd]

        tdf#155228 vcl: appease Adobe Acrobat Pro, always produce /Tabs
        
        Reportedly Adobe Acrobat Pro complains if any page is missing "/Tabs"
        even though ISO 14289-1:2014 requires it only for a page with
        annotations.
        
        Change-Id: I84d750da12ca55519aa61c196d2d93aa33f1abad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171486
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [43cb4360e9e9211bd131178c9f96ec3ce6bae682]

        tdf#162345 Allow splitting, when we have columns
        
        This makes a similar exclusion as above in bLoneAsCharAnchoredObj
        case. I don't know exactly why should this depend on columns, but
        this works (so this is basically a monkey programming here).
        
        Change-Id: I6f15da77a16629d9146076e0a4ef50f82ebdc04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171481
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-05  Oliver Specht  <oliver.specht@cib.de>  [f828a9fe44bfef9af58035340b6d6afd67d5a870]

        tdf#162065 Fix format paintbrush in draw/impress
        
        With tdf#160069 the format paintbrush was disabled outside of text
        selection and with tdf#160069 target selection was reduced to
        text only. The change of tdf#160069 is mostly undone with this
        patch.
        
        Change-Id: I8e23ef56206c6749913e2c95870537c3e378f946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170672
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-08-05  Miklos Vajna  <vmiklos@collabora.com>  [9ebf3c84a6496b3931a4522c7475c541a2d9015b]

        sw: fix missing includes for the SwXStyle header
        
        It's a bit easier to navigate while code-reading when the header is not
        full of syntax errors, due to missing headers.
        
        Change-Id: If8417d17e6180b6a9679aade3893733fc47956c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171490
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-05  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [f965f2d5be13e191ae6cc284f048d3731d74d190]

        tdf#153866: fix .uno:IndexMarkToIndex
        
        - sw::FindContentFrameHint send by SwTOXType is handled by SwTOXBaseSection
        - SwTOXBaseSection/SwTOXBase is still an oldschool SwClient to SwTOXType
        - thus we need CallSwClientNotify() for now
        - once SwTOXBase is switched over to register at the Broadcaster, we can
          revert this
        
        Change-Id: Ia471a5785f49dc85c9777ae4681616842c1addf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171440
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-08-05  Jonathan Clark  <jonathan@libreoffice.org>  [cb7c70cd19237268b748d3e35f8bbed2150042ea]

        tdf#162314 sw: Fix hang while laying out bidi portions with underflow
        
        Regression from 04184aa7e3aada8f4d938d20dfdb54b3a7dd3896
        (tdf#157829 sw: Implemented line break underflow for bidi portions)
        
        Change-Id: If5d550bd6e0f1099bc37532b2172436c12805104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171432
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e94b85019d607f83b626d4ff3756d8f04c0dfb3f]

        simplify IMark hierarchy (7)
        
        drop the iterator wrapper, no longer necessary
        
        Change-Id: I41697c062805c3fadd0210cffbc8f7beffe01f2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171472
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a81e51afcbc98a266115af4fb4a5f6a78c1d015c]

        ofz#70675 XML_ERR_FATAL not ending parse
        
        Change-Id: I3b07ff6e208bf33053540548176a06f28138a6a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171479
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-05  Miklos Vajna  <vmiklos@collabora.com>  [f31c60023243459b0565945790b094d10fe1c13c]

        tdf#162075 sw textbox: map a shape's wordwrap=no to the frame's width type
        
        Regression from commit c761df1e42fd11acc5fc05b0baacd803c3788ca6
        (tdf#84678 DOCX import: fix handling of textbox margins, 2016-10-25),
        the header hape was supposed to have a single line, but it had a
        separate line for each character in the shape text.
        
        What happened is that the nominal size of the shape was not enough to
        provide enough space for the text, now that we handle spacing between
        the frame border and text, and the shape had automatic height set,
        instead of automatic width.
        
        Fix the problem by extending SwTextBoxHelper::create() to map the
        shape's TextWordWrap property to the inner frame's WidthType. As the
        tdf#81567 testcase points out, this requires extending the matching
        shape update code as well, because word wrap is always disabled
        initially, and it's enabled only after the shape's text is processed.
        
        Also adjust sw/qa/extras/layout/data/tdf138951.odt, which expected word
        wrap but didn't request it -- the original tdf#138951 bugdoc keeps
        working after this commit.
        
        Change-Id: I17c896f83731a6653e3a0a1493949e27d5259232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171475
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ad3ff5b28988ddbd223b58467c0b5946fbff91d]

        loplugin:redundantcast fix crash
        
        found while working on a patch
        
        Change-Id: Ic8a960c033d1841fc7c4af89b10f4b672996cb7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-05  Pierre F  <fpy@bger.ch>  [11b76046fb63c6cb8e96f8569d4fb2ed33de9674]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bedc78ea365c832245bea752d832257bd5b3513b
          - add note on "Custom" limitation. tdf#153345
            
            Change-Id: I39a2bbd4143e3fcb43e4a5139b56b059836f2397
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171363
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [31c05aca2715e199fb52bfc995dee6d3fecd96ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e243381394a0183b0d598da102986fe99950c9e
          - Place fontwork toolbar in 02 folder.
            
            (folder 02 has most of toolbars help pages)
            
            Change-Id: I0aae6adbdbd1fb3c3880cc286b3a9f99cccc0110
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171484
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5f4f75cdfc27a6b84e59d43aa051d52166bc10b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0fd8bada65ccc592c1cee2b472735f702b4ec268
          - Place mediaplay toolbar in 02 folder.
            
            (folder 02 has most of toolbars help pages)
            
            Change-Id: I68452fa229d07427bc9f343eef65ab29d0ef9315
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171483
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [48c86048c638a5bde0b2a210fed0fa1561021dc9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09d1dd40e463553da661692c6fd5fde9193059f7
          - Housekeeping Help page on Similarity command.
            
            Change-Id: I43ebdc6c09e78c35513b65a6f0c3aa1c39aea918
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171480
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-05  Miklos Vajna  <vmiklos@collabora.com>  [c88af36d32241458ce9b30eed35d4753716b4169]

        svx: prefix members of SdrUndoReplaceObj
        
        See tdf#94879 for motivation.
        
        Change-Id: I70d2a1c4b1918683085d40208bed6f5f28ebee1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171471
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-05  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [9786f8ea59ccc9225871888d23b5af9ed16a5e5f]

        tdf#159040 tdf#162206: better the user key selection and test sign with default
        
        fix GPG CertificateImpl::getSHA1Thumbprint not returning a
        sequence of bytes as the thumbprint. (that is what the
        documented API states, and what all of the code assumed.)
        
        now /org.openoffice.UserProfile/Data/signingkey and
        encryptionkey stores the key's SHA1Thumbprint for better
        identification of keys. Previously on the key name was being
        used.
        
        fix annoying NSS Certificate Database password prompt
        appearing on Tools->Options if the certificate database is
        password protected.
        
        improve Tools->Options->UserData user key selection and
        display of information.
        
        add a ui test for "Sign with default certificate"
        interaction in the save dialog.
        
        Change-Id: I1036856003f58f494838e0f81ca0fe18e821f528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171395
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-08-05  Dione Maddern  <dionemaddern@libreoffice.org>  [50455fa6a223f34b59aca3c837ce79aebf9bb5aa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d9353df5521cc5e1949868174cc46b669116a988
          - tdf#162273 Add help page for Sidebar Quick Find
            
            Add new file text/swriter/01/sidebar_quickfind.xhp to provide help
            content for the Find Sidebar Deck.
            
            Add new file text/swriter/01/sidebar_quickfind.xhp to
            AllLangHelp_swriter.mk.
            
            Add variable and section tags to
            - source/text/shared/01/02100000.xhp
            - text/shared/01/02100100.xhp
            - text/shared/find_toolbar.xhp
            to allow content and headings to be easily embedded in other documents.
            
            In - text/shared/find_toolbar.xhp
            - Add bookmark so that pressing F1 when the "Match Case" checkbox is
            selected opens the correct help page.
            - Fix link at line 106 so that it opens the correct page for "Find and
            Replace"
            
            Change-Id: Ifc6725941224277521ea8a8486fcc347278487b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171416
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-05  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [bf9e8d5ffd3f29fa027f0009a70f27d3456b648b]

        CairoSDPR: direct text rendering using Cairo
        
        I have added basic support for the text primitives
        (TextSimplePortionPrimitive2D) to the SDPR Cairo
        renderer. It can now basically render Text using
        a fallback to the already existing CairoTextRender.
        
        NOTE: This is not yet complete, but for discussion.
        Change-Id: I9b0c7b6bb4892905576593ef4e2b4071c7663c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171429
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e6d470293243f1a8dd3dbcb42258dd22e408e127]

        UBSan CppunitTest_sw_writerfilter_misc needs the SwXStyleFamilies now
        
        ...presumably since f13e5718f53c3e460a6aacdb8f429d18ac011fa3 "use more concrete
        UNO type in writerfilter":
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/sberg/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so
        > /home/sberg/lo/core/instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI16SwXStyleFamilies"
        
        Change-Id: I55014caff2c7b662edf1a552e496d4c9955ce23e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171468
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-05  Per99  <solare99@gmx.de>  [3afc933ca3d7b88e6f9d3283baed9ef4e3ce2000]

        tdf#161765 part 2: In optaccessibilitypage.ui, align the Comboboxes.
        
        In https://gerrit.libreoffice.org/c/core/+/170827 ,
        the comboboxes weren’t aligned. This patch corrects that mistake.
        Additionally, there are some minor vertical alignment adjustments..
        
        Change-Id: I4410c0701b636974f7857a07fff7af75f6cd0a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171388
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-05  Alain Romedenne  <alain.romedenne@libreoffice.org>  [54b642f4b81ad3abb04b120f665b517a95288c74]

        VBA QA new unit test for IF THEN statement
        
        Intent is to cover:
        - EndIf / End If equivalence
        - repeating ElseIf blocks
        _ nested IF statements
        - IF THEN one liner
        
        Change-Id: I667f0381529afcc82fc44ae461081f7ba84b01d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-05  Pierre F  <fpy@bger.ch>  [cf4014748eed9f907b500c091faf2afd5a8081cb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9307abb31d6575e714e454861b810bb2122759fe
          - calculation_accuracy, obsolete example with dates and times. tdf#162332
            
            Change-Id: I7c631c271eeae7a207a0d2246bf54caca6e06ad5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171418
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Tested-by: Jenkins
            
2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7197e574cdbd7410fcadab1632bcce2626dca5a]

        simplify IMark hierarchy (6)
        
        merge IMark into MarkBase
        
        Change-Id: I5d3c648c950f97497c96912c25081906de434056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171464
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-04  Noel Grandin  <noelgrandin@gmail.com>  [59471bb949e8d8d64023b17136921f59e0bf705e]

        use more concrete UNO type in writerfilter
        
        Change-Id: I70dd95a647c5a1e89d505da6d971c48662026d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171456
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9c4fd0b981d7a0ebf76d3110955e16809dd6068]

        simplify IMark hierarchy (5)
        
        merge into IFieldmark into Fieldmark
        
        Change-Id: Ide5c01fe49bae0be45746f6b581d72342da9c3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171463
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f5afe4cb08f4aa23c5f68630281098d5626ba61]

        simplify IMark hierarchy (4)
        
        merge IDateFieldmark into DateFieldmark
        
        Change-Id: Ibb77ee4e1a65f6e3edde63b98c7a67f11507ca51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171462
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5e2dc736700b5b626006e16a9726e9be391f34d]

        cid#1608462 XML external entity processing enabled
        
        and
        
        cid#1608334 XML external entity processing enabled
        cid#1608302 XML external entity processing enabled
        cid#1608234 XML external entity processing enabled
        cid#1608094 XML external entity processing enabled
        cid#1607973 XML external entity processing enabled
        cid#1607890 XML external entity processing enabled
        cid#1607706 XML external entity processing enabled
        cid#1607366 XML external entity processing enabled
        cid#1607026 XML external entity processing enabled
        cid#1606764 XML external entity processing enabled
        
        Change-Id: I7894d335f244ed3ddbbe43d9bdbc2818065830f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171461
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2610e15e9df17bd8a627037d7aeab8be0c8e6121]

        unset what's selected when we clear the paper size box
        
        Change-Id: I47de9bf12fb0e22fce8b0bbb9450b11ee0ad6008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171450
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2fbd16ed37ad0312faef79d1147d57731cfd980e]

        simplify IMark hierarchy (3)
        
        merge IDropdownFieldmark into DropDownFieldmark
        
        Change-Id: I5dd9a166bc3f0710237b45fb0b063973547f2eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [61a63b97c31b33adf69ef8bf3f187dfd6762f854]

        simplify IMark hierarchy (2)
        
        merge ICheckboxFieldmark into CheckboxFieldmark
        
        Change-Id: Iaed990a9ac509b031d31e62c8878d8a5988476ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Noel Grandin  <noelgrandin@gmail.com>  [3e05f32dbe8416ec95736174d036cab758f76c1f]

        use more concrete UNO type in writerfilter
        
        Change-Id: If112eea759f828cb07a9a42bd3d86d43078b4bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1b582772bb47fb421886fa268d469c1b5ba41bb]

        Resolves: tdf#154959 label printers no longer rotate
        
        a) partly revert this piece of:
        commit 598ff4e2433a419a432fd54ed5dac560663ec107
            loplugin:constantparam in vcl
        
        b) fix the thinko mismatch of "true" for bSwaped detected
        by that plugin
        
        Change-Id: I2d31a969538d1cfa8d22a089fa61fdaa5454cc0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171449
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b61a652c1e19ff0ce2765e374fb179189235926]

        cid#1556583 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556585 COPY_INSTEAD_OF_MOVE
        cid#1556588 COPY_INSTEAD_OF_MOVE
        cid#1556593 COPY_INSTEAD_OF_MOVE
        cid#1556597 COPY_INSTEAD_OF_MOVE
        cid#1556605 COPY_INSTEAD_OF_MOVE
        cid#1556617 COPY_INSTEAD_OF_MOVE
        cid#1556635 COPY_INSTEAD_OF_MOVE
        cid#1556790 COPY_INSTEAD_OF_MOVE
        cid#1556792 COPY_INSTEAD_OF_MOVE
        cid#1556796 COPY_INSTEAD_OF_MOVE
        cid#1556799 COPY_INSTEAD_OF_MOVE
        cid#1556815 COPY_INSTEAD_OF_MOVE
        cid#1556836 COPY_INSTEAD_OF_MOVE
        cid#1556840 COPY_INSTEAD_OF_MOVE
        cid#1556842 COPY_INSTEAD_OF_MOVE
        cid#1556859 COPY_INSTEAD_OF_MOVE
        cid#1556860 COPY_INSTEAD_OF_MOVE
        cid#1556866 COPY_INSTEAD_OF_MOVE
        cid#1556869 COPY_INSTEAD_OF_MOVE
        cid#1556870 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3df8698a4aecbb03999c084517e37e12ff46ee97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [2bb84e874bd17afcf3e417d2e4fc32aaafe841c3]

        tdf#111816: allow special characters filtering by Unicode value
        
        When the Search box starts with U+ (or u+),  the rest will be treated
        as beginning of a Unicode value in hexadecimal notation (ignoring any
        leading zeroes). E.g., "U+12" would match U+0120 and U+12F90, but not
        U+0112. "u+012" will match exactly the same codepoints.
        
        Change-Id: Ia4a3ccc99d049dc208d556f3f2a0fb8b2ef6b689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171458
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-04  Julien Nabet  <serval2412@yahoo.fr>  [bf2c4cead1980c2e36fa9d51b704d2753e517edf]

        tdf#162339: MariaDB: Table with spaces in table name couldn't be deleted by GUI
        
        Use ::dbtools::qualifiedNameComponents to retrieve elements of table name (catalog/schema/table)
        Use ::dbtools::composeTableName to compose the full table name
        
        Change-Id: Ia6ebc1a46a4222315e43909356fb8c1d36990419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171457
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-08-04  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [5850b22e04a7a055e5b4c6b23a1d32d74270506d]

        speed up getInnerFieldmarkFor some more with bisectional and reverse search
        
        prerequisites:
        - the fieldmark vector is sorted by field start
        - a fieldmark start and end either have to both be in any other
          fieldmark, or both be outside of it
        
        strategy:
        - first we find the last fieldmark before our position (those behind it
          will never cover the position)
        - then iterate backwards to find the first that ends behind the position
          (and thus covers it)
        - the innermost fieldmark is now either the fieldmark found, or another
          fieldmark starting at the same position:
          * fieldmarks starting before the one we found will not be the innermost
          * thus we only need to iterate check to the first fieldmark starting
            earlier
        
        There are further optimizations, that likely arent worth it, e.g.:
        - sort the fieldmarks with the same start position by length or end
          position (longest first), this would remove the need for the last step
        
        Change-Id: I49164697a44ff0a5e11809dfba82029c160c5d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171442
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2024-08-04  varshneydevansh  <varshney.devansh614@gmail.com>  [aebe61498bd226b2392cdfcfe5ad7db4489bd48e]

        tdf#82716 Implement Correct Calculation for Histogram Chart
        
        - Add Scott's rule for bin width calculation
        - Correct upper and lower limit for the Bin Range in the X-Axis
        
        This commit introduces Scott's Reference Rule as we are currently
        using the sqrt for histogram calculation, improving bin width
        determination and overall histogram accuracy.
        
        Change-Id: I4a430416e365781ebef8b1e0872dd4ed50492b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170526
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-08-04  Noel Grandin  <noelgrandin@gmail.com>  [f13e5718f53c3e460a6aacdb8f429d18ac011fa3]

        use more concrete UNO type in writerfilter
        
        Change-Id: Idf3fd445994e0b42cffc173ed68475398d74cdd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171447
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cad11120687b5dcb6812e88a03712686ff78333]

        simplify IMark hierarchy (1)
        
        The undoes some of the "reduce god objects" work, but leaves the primary
        utility of that work in place.
        
        The hierarchy invented to hide the MarkBase hierarchy is an unnecessary
        abstraction, and it results in considerable costs in dynamic_cast'ing in
        various places, and makes it much harder to optimise and maintain
        type-safety.
        
        In this first stage, I move the bulk of the declarations from
        bookmark.hxx to IMark.hxx, and remove the IBookmark interface class in
        favour of using the concrete Bookmark class (which already exposes some
        dead code).
        
        Change-Id: I9712506bd6f58bdddc5193823888e65d24d79ddf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171445
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [45290d41fbd82a9b5846e456eaaa5c27b3d2c8c1]

        Clarify MsgBox buttons handling code
        
        Change-Id: I0095b4b5312c851f1f64ec013c64f26e1b24ce09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171454
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-03  Mike Kaganski  <mike.kaganski@collabora.com>  [055c906d7b3f2e3709292d1410358d4e66a500ed]

        tdf#123527: use the new font in SvxSearchCharSet::RecalculateFont
        
        Taking the font from the render context makes no sense, when the
        intention is to set the new font set in SvxShowCharSet::SetFont.
        Basically, it now does a similar thing as in overridden parent's
        SvxShowCharSet::RecalculateFont.
        
        Change-Id: I1077a44b41d881415e1424146bda8aeb47d8ab17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171446
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-03  Noel Grandin  <noelgrandin@gmail.com>  [1db0a141021778c66f2a922ddef8494b7a755ca2]

        use more concrete UNO type in writerfilter
        
        Change-Id: I80128e6b76c36070612fc2e9dda3ad82c865f6ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-03  Mike Kaganski  <mike.kaganski@collabora.com>  [b76af7f488217cb244a68cf4294576237c115aeb]

        Refactor basic methods representing constants
        
        Makes them more comprehensible; uses semantic names instead of magic
        numbers. Added comments to the constants that are unclear.
        
        Change-Id: Ifcb8a0d93ce057b8af08859b87ad3af8c67479e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171443
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [62cc13b766610e1f359eee250df2f524e4dfb0aa]

        Related: tdf#161662 bring bullet combobox height down
        
        similar to
        
        commit db2a7489fa7ac758c1ab35f49fff284f460c5d4c
        CommitDate: Fri Jul 19 17:53:36 2024 +0200
        
        There are some Arabic, etc numbering options in there that cause gtk to
        allocate a large odd-looking height for the combobox.
        
        Change-Id: I6f16e82a71955c3df943279109bce02a10d773eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171434
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-03  RMZeroFour  <ritobroto04@gmail.com>  [e8a8d32fb3cc8b1f8fc17788ab00dffff1f4a950]

        .NET Bindings: Add DotnetTest class to gbuild
        
        This commit adds the DotnetTest gbuild class to build a unit test
        suite using the .NET SDK and the NUnit testing framework.
        
        Also adds a DotnetTest target for the net_ure module, with unit tests
        for the Any type, as well as some minor changes to the Any type that
        came about when writing the test cases.
        
        Change-Id: Idbc08ac8f0736dd7355092dd1e69a5f1b4137c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168956
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-03  RMZeroFour  <ritobroto04@gmail.com>  [eca841476386bc78639b24c42e5e95ff201fd4a4]

        .NET Bindings: Move built .NET libraries into instdir
        
        This commit adds Package targets for the net_basetypes, net_uretypes
        and net_oootypes libraries to install them into instdir/program/dotnet.
        Also adds a LIBO_SHARE_DOTNET_FOLDER variable mirroring the
        LIBO_SHARE_JAVA_FOLDER variable.
        
        Change-Id: I28cdb2dac799bd72d11c3e550bba1a946db8b49c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170098
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-03  RMZeroFour  <ritobroto04@gmail.com>  [2ddeef9ff5facd3551039504badd31d5cac7f2eb]

        .NET Bindings: Improve DotnetLibrary gbuild class
        
        This commit rewrites the DotnetLibrary gbuild class to build a .NET
        library. Logic for handling various .NET languages is now consolidated,
        while earlier there were separate functions for each language. Usage
        has been made much more similar to the Jar gbuild class.
        
        The CustomTargets used to build net_uretypes and net_oootypes have
        also been reworked, and a function has been added to DotnetLibrary
        to consume sources generated by a custom target, for cleaner usage.
        
        Change-Id: Ie494b2547d30c43f9bb0aedeac4d140f1f3a830b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170168
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-03  RMZeroFour  <ritobroto04@gmail.com>  [5f4083ffa9e4ecd073063c904412f83986b8e813]

        .NET Bindings: Upgrade --enable-dotnet to --with-dotnet
        
        This commit changes the existing --enable-dotnet switch into
        --with-dotnet, allowing users to pass in a different dotnet
        executable than the one on their PATH, similar to --with-java.
        This is used to determine the variables DOTNET and DOTNET_ROOT.
        
        Change-Id: Ia4f02dfdbd33d7629a800a076f758b26bb186d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169656
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-03  Hossein  <hossein@libreoffice.org>  [67afda89557cd0d3bd181e7c3c8d1406075ea364]

        No LibreOfficeKit headers and examples for macOS
        
        LibreOfficeKit has issues in macOS, as discussed in LibreOffice
        development mailing List and also in tdf#145127.
        
        LibreOfficeKit unrunnable on macOS
        https://lists.freedesktop.org/archives/libreoffice/2024-July/092256.html
        
        Therefore, let's not ship the LibreOfficeKit headers and examples with
        LibreOffice Community for macOS. If the above issue is solved, then it
        will be possible to ship those again later.
        
        Change-Id: I5ba62ee84432a09732d96a5d86eb0a1bf866671f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171095
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-08-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [fa89130d4980662642cb81a05ec044dbe21fd5d0]

        tdf#162297 Wrap tooltips in Qt5
        
        Acoording to the Qt documentation, in order to wrap the tooltip a rich-text style needs to be set.
        
        This patch sets a dummy style to make sure the tooltip gets wrapped in LO.
        
        Change-Id: I7e950932572030581abc1c81fb4c146cb4394eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171411
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [644b5130ed20b9176776d1e09d93df1e73a67c7f]

        Fix typo
        
        Change-Id: Ia72c18614df83479a89d1d03d7a548346adf11c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171439
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23d421184eaf155a492463c8ee192dbfa38e18ed]

        Fix typo
        
        Change-Id: I37b7b8458a59e32c1ab86ddd6ab8b0b4e0a3aa7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171328
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-08-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32d13514951be9be9b18448b88404465448ba02b]

        m_aPixelSize should be in pixels, but GetPrefSize depends on GetPrefMapMode
        
        i.e later we do:
        
        Size aSize = PixelToLogic(rEmit.m_aPixelSize, MapMode(m_aMapMode.GetMapUnit()));
        
        and PrefSize is in PrefMapMode units.
        
        Change-Id: I387316804496fc0a05c3370f370f5f562c288d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171251
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit de15d0a566ce72f2d508ceb7b3fbf60d2aa31329)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171358
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [7247f3ad59d64c85dc891bd5195b83c714ce1ce4]

        tdf#153343 Show settings for the actual default font in control properties
        
        Since
        
            commit ea36e0502c0bc381577cfa1b1a7fedf0f05d1d72
            Date:   Tue Oct 4 12:42:33 2022 +0100
        
                tdf#150786 use a 'standard' theme for form controls
        
        , form controls in Writer/Calc/Impress documents are
        supposed to no longer make use of the system style,
        but use style settings independent of the platform
        and system style/theme.
        
        Edits in forms actually use the standard font (set
        in `ImplStyleData::SetStandardStyles`) by default
        since that commit.
        
        However, the font dialog in the control properties
        was still showing data for the application default
        font that depends on the system style for font
        attributes not explicitly set for the control, which
        was incorrect and inconsistent with the visual
        appearance of the font actually used.
        
        Take `PROPERTY_STANDARD_THEME` introduced in the
        above-mentioned commit into account for the dialog
        as well when deciding what default font to use.
        Add inline comments that the 2 places setting and
        making assumptions about the default style of
        controls need to be kept in sync.
        
        With this in place, the actually used font height
        of 8 (as set in `ImplStyleData::SetStandardStyles`)
        is now displayed in the dialog for a newly inserted
        edit in Writer instead of something dependent on the
        style (e.g. 10 for the kf5 VCL plugin with the Breeze
        style in use, or 9 for the qt6 VCL plugin with the Fusion
        style).
        
        For the font family, the dialog now shows
        "Segoe UI;Tahoma;Arial Unicode MS;Lucida Sans Unicode;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans L;Interface User;Geneva;Dialog;Lucida;Helvetica;Helmet;Interface System;Sans Serif"
        (and "This font has not been installed. The closest available
        font will be used.") instead of "Noto Sans", which seems a bit
        odd, but is presumably "correct" based on the standard style
        font. (In order to change that, it would potentially be necessary
        to adjust what style settings are set in the
        "standard style settings" for controls.)
        
        Change-Id: I1fbee69fdcd6f73a126df64294eb1bcc44078642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171426
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [001c0934aab5c33b37a75798deb84c20b4b9d365]

        tdf#155636 tdf#155637 tdf#156962 Consistently use non-native controls
        
        Since
        
            commit ea36e0502c0bc381577cfa1b1a7fedf0f05d1d72
            Date:   Tue Oct 4 12:42:33 2022 +0100
        
                tdf#150786 use a 'standard' theme for form controls
        
                i.e. ignore system theme so we get the same results on export to pdf
                regardless of the theme (esp dark) and don't follow the system theme
                when hosted with a writer/calc/impress document (do continue to use
                system theme for StarBasic dialogs as seen in BasicIDE)
        
                Didn't reuse 'NativeWidgetLook' for this because is currently defaults
                off, while we currently do use the colors derived from the system theme
                even when this is off, its really the NWF flag to render using the
                platform theming engine
        
        , form controls in Writer/Calc/Impress documents are
        supposed to no longer make use of the system theme,
        but use style settings independent of the platform
        and system style/theme set.
        
        However, `ImplSmallBorderWindowView::Init` could still
        decide to enable native drawing of borders, in which case
        it would enable transparency for the control and the control
        background color would no longer be seen with at least the Qt-based
        VCL plugins after
        
            commit 0e14dbc9ecdf6abae3ae3089e3b4e22f27dd4cb1
            Date:   Thu May 4 10:24:53 2023 +0100
        
                Resolves: tdf#155029 set StandardStyles before updateFromModel
        
        e.g. for the multiline edit control in attachment 195659
        from tdf#155637, where `mbNWFBorder = true;` would be set like this:
        
            #0  ImplSmallBorderWindowView::Init(OutputDevice*, long, long) (this=0x55af6388e700, pDev=0x55af62d49770, nWidth=214, nHeight=365) at vcl/source/window/brdwin.cxx:458
            #1  0x00007fed4de9f168 in ImplBorderWindow::InitView() (this=0x55af638bdb50) at vcl/source/window/brdwin.cxx:1793
            #2  0x00007fed4dea08f4 in ImplBorderWindow::UpdateView(bool, Size const&) (this=0x55af638bdb50, bNewView=true, rNewOutSize=Size = {...}) at vcl/source/window/brdwin.cxx:1808
            #3  0x00007fed4dea0847 in ImplBorderWindow::DataChanged(DataChangedEvent const&) (this=0x55af638bdb50, rDCEvt=...) at vcl/source/window/brdwin.cxx:1771
            #4  0x00007fed4de6fc32 in vcl::WindowOutputDevice::SetSettings(AllSettings const&, bool) (this=0x55af62d49770, rSettings=..., bChild=false) at vcl/source/window/settings.cxx:68
            #5  0x00007fed4de6fb19 in vcl::WindowOutputDevice::SetSettings(AllSettings const&, bool) (this=0x55af62d49420, rSettings=..., bChild=false) at vcl/source/window/settings.cxx:52
            #6  0x00007fed4de6fa8f in vcl::WindowOutputDevice::SetSettings(AllSettings const&) (this=0x55af62d49420, rSettings=...) at vcl/source/window/settings.cxx:44
            #7  0x00007fed4e12d376 in vcl::Window::SetSettings(AllSettings const&) (this=0x55af62fbb530, rSettings=...) at vcl/source/window/window3.cxx:209
            #8  0x00007fed501e3374 in UnoControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x55af62c79380, rxToolkit=empty uno::Reference, rParentPeer=uno::Reference to (VCLXContainer *) 0x55af61cbc178) at toolkit/source/controls/unocontrol.cxx:1299
            #9  0x00007fed5023dc39 in UnoEditControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x55af62c79380, rxToolkit=empty uno::Reference, rParentPeer=uno::Reference to (VCLXContainer *) 0x55af61cbc178) at toolkit/source/controls/unocontrols.cxx:241
            #10 0x00007fed05f6009f in frm::ORichTextControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x55af62c79380, _rToolkit=empty uno::Reference, _rParentPeer=uno::Reference to (VCLXContainer *) 0x55af61cbc178) at forms/source/richtext/richtextcontrol.cxx:163
            #11 0x00007fed05e34126 in frm::OControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x55af61e17c60, _rxToolkit=empty uno::Reference, _rxParent=uno::Reference to (VCLXContainer *) 0x55af61cbc178) at forms/source/component/FormComponent.cxx:272
            #12 0x00007fed50201095 in UnoControlContainer::impl_createControlPeerIfNecessary(com::sun::star::uno::Reference<com::sun::star::awt::XControl> const&)
                (this=0x55af5eb108c0, _rxControl=uno::Reference to (frm::OEditControl *) 0x55af61e17cc8) at toolkit/source/controls/unocontrolcontainer.cxx:595
            #13 0x00007fed501ff973 in UnoControlContainer::impl_addControl(com::sun::star::uno::Reference<com::sun::star::awt::XControl> const&, rtl::OUString const*)
                (this=0x55af5eb108c0, _rxControl=uno::Reference to (frm::OEditControl *) 0x55af61e17cc8, _pName=0x55af5f0d2670) at toolkit/source/controls/unocontrolcontainer.cxx:608
            #14 0x00007fed50201183 in UnoControlContainer::addControl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::awt::XControl> const&)
                (this=0x55af5eb108c0, rName="com.sun.star.form.control.TextField", rControl=uno::Reference to (frm::OEditControl *) 0x55af61e17cc8) at toolkit/source/controls/unocontrolcontainer.cxx:628
            #15 0x00007fed517f1aff in sdr::contact::ViewObjectContactOfUnoControl_Impl::createControlForDevice(sdr::contact::(anonymous namespace)::IPageViewAccess const&, OutputDevice const&, SdrUnoObj const&, basegfx::B2DHomMatrix const&, basegfx::B2DHomMatrix const&, sdr::contact::(anonymous namespace)::ControlHolder&) (_rPageView=..., _rDevice=..., _rUnoObject=..., _rInitialViewTransformation=..., _rInitialZoomNormalization=..., _out_rControl=...)
                at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:1126
            #16 0x00007fed517ee55b in sdr::contact::ViewObjectContactOfUnoControl_Impl::impl_ensureControl_nothrow(sdr::contact::(anonymous namespace)::IPageViewAccess const&, OutputDevice const&, basegfx::B2DHomMatrix const&)
                (this=0x55af6389c6b0, _rPageView=..., _rDevice=..., _rInitialViewTransformation=...) at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:1044
            #17 0x00007fed517ee1d2 in sdr::contact::ViewObjectContactOfUnoControl_Impl::ensureControl(basegfx::B2DHomMatrix const*) (this=0x55af6389c6b0, _pInitialViewTransformationOrNULL=0x55af6380a1f0)
                at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:960
            #18 0x00007fed517f36a1 in sdr::contact::(anonymous namespace)::LazyControlCreationPrimitive2D::create2DDecomposition(drawinglayer::geometry::ViewInformation2D const&) const (this=0x55af61d38c40, _rViewInformation=...)
                at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:1545
            #19 0x00007fed5467691a in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const
                (this=0x55af61d38c40, rVisitor=..., rViewInformation=...) at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:133
            #20 0x00007fed517f358c in sdr::contact::(anonymous namespace)::LazyControlCreationPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const
                (this=0x55af61d38c40, rVisitor=..., _rViewInformation=...) at svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx:1530
            [...]
        
        Introduce a new flag `WindowBorderStyle::NONATIVEBORDER`
        and set it for the newly created control in `UnoControl::createPeer`
        if the use of the "standard theme" instead of the system style
        is enabled.
        
        Evaluate the flag in `ImplSmallBorderWindowView::Init`
        to never enable native drawing if it is set to consistently
        not apply system styling for such controls.
        
        Change-Id: Ib12685a3cf98acba035899221feb536f40cda84c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171396
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f9f32aa11852e8ea9588f6fbe3416484cadd229]

        cid#1556472 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556481 COPY_INSTEAD_OF_MOVE
        cid#1556486 COPY_INSTEAD_OF_MOVE
        cid#1556491 COPY_INSTEAD_OF_MOVE
        cid#1556507 COPY_INSTEAD_OF_MOVE
        cid#1556515 COPY_INSTEAD_OF_MOVE
        cid#1556518 COPY_INSTEAD_OF_MOVE
        cid#1556519 COPY_INSTEAD_OF_MOVE
        cid#1556533 COPY_INSTEAD_OF_MOVE
        cid#1556536 COPY_INSTEAD_OF_MOVE
        cid#1556559 COPY_INSTEAD_OF_MOVE
        cid#1556577 COPY_INSTEAD_OF_MOVE
        cid#1556581 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I2ad2f2194e2a89c7246e8742b2fc8be7580e38c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171394
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f29d94c7b1bf9bee3e3598d90ba6e9dfd684ecfc]

        tdf#162259: correctly handle font width on Windows
        
        Unlike other platforms, on Windows, the font width is not relative to
        font height, but to average width of font's glyphs. This is mentioned
        in LogicalFontInstance::GetScale.
        
        1. In VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D,
        when calculating the correction for width / height (introduced in
        commit cc3663bbaed4f65d64154e5f9abb51a5f622f710, 2024-04-20), the
        already applied X scale is now calculated using unscaled font's width.
        
        2. Commit 8557ea84c9336ba8061246f1f46ddb6e02f413a1 (Exclude getHScale
        from DirectWrite font rendering, 2024-04-08) was effectively reverted,
        because I was wrong assuming that the code there was unnecessary.
        
        3. Commit 2092df2a9044f1c2ae4379f48a3201e5867575a8 (tdf#161154: pass
        "scaling is done externally" information down the stack, 2024-05-18)
        was also reverted.
        
        Change-Id: I8cff39b67a6efd380f7807f5655f401bdb62cc3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171382
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5d87f7f3477728767790eafa11d52b95623dd7c5]

        Fix typo
        
        Change-Id: I37bc06381cd3a36648e32cfb3eff1b5b72ccdd05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171427
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-08-02  Michael Stahl  <michael.stahl@allotropia.de>  [f60b3b894daa9d498e8b71c7ac78cb33621f5819]

        nss: upgrade to release 3.102.1
        
        Not sure what moz#1905691 is but they did an ESR release for it...
        
        Change-Id: I271d592dd9d61157f4fbe819258c90414c1b4e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171425
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-08-02  Skyler Grey  <skyler.grey@collabora.com>  [07dec064c2a05d13812cd85c1047743468843f7f]

        test: send document bg color on new theme
        
        In I27c8409a6fcb771d741b07d77c5598c87e178f3b we fixed this feature,
        here's a test to make sure we're doing the right thing
        
        Change-Id: I32f3c410da6bc607f2e0cc3e48a440a09d92d6eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171398
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [af5c4092052c98853b88cf886adb11b4a1532fff]

        Expose WorkWindow fullscreen mode via new XTopWindow3
        
        ...deriving from the existing XTopWindow2.  (Exposing this functionality via UNO
        is useful e.g. for some embedded LOWA example application.)
        
        Change-Id: Ib92f75510b7a2ca26933ea35afcc78882a7804fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171403
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-08-02  Heiko Tietze  <tietze.heiko@gmail.com>  [35003f56dce36326777900b8562643651537a489]

        Resolves tdf#140347 - Terminology in foot/endnote dialog
        
        Patch submitted by olagu@ogundersen.net with a few modifications
        on spacing
        
        Change-Id: Ib197b96df87a62a4ddc732f62b699a3670ecd948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171400
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-02  Pierre F  <fpy@bger.ch>  [89263335fd8d98a8c6e82fb216b16af4be15c2b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b457ef1b8cf5a62891e5aa747a2ebd3959c2f206
          - HYPERLINK tip. tdf#134896
            
            Change-Id: Ieaabf7f81c077b54ab1aef8578f19fc15e576c7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171361
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [37b24e1bc7c4d85cd517e6c884bbc5bb6627ac12]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8ad5069b9f29e8dd95003f7dda969617f013efb
          - Fix bad link in Content tree
            
            Change-Id: I1fe82a202df8ce1b3749154ea7534cf2a4276437
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171402
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-02  Heiko Tietze  <tietze.heiko@gmail.com>  [6e20a5d6b930ea4ea121345e909aa0803638c6c0]

        Resolves tdf#161725 - Toggle module-specific file types in MRU
        
        Change-Id: I254659718f26800d8dab94e51e8cf66857b0992e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171399
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-08-02  Justin Luth  <jluth@mail.com>  [49763e1fc4ec4308d52a3d578246ecc4ad3108b2]

        tdf#134204 : notify change unless all properties are handled #3
        
        So, hopefully all the logic is nice and tidy now.
        
        Change-Id: I9016cc07bdcf0297961e4d2c2456bb2fe9fbde3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169899
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-02  Mike Kaganski  <mike.kaganski@collabora.com>  [8bd57009d38f7551a77566a0e782a7b371aece23]

        Fix wrong / misleading uses of fTools::(more|less|equal) with literal 0
        
        These will never compare with tolerance (the zero is a special case
        in rtl_math_approxEqual used internally), so the calls like those
        don't do what they appear to do in these cases.
        
        Change-Id: I495ac92b7f45637e118e4fdc04bb6fad6fff31ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171391
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-02  Miklos Vajna  <vmiklos@collabora.com>  [cfd3b14fd4e1ee889dd356523e5cdaa639786d37]

        tdf#162295 DOCX import: optimize the check if the header/footer is empty
        
        The original DOCX bugdoc has some 813 shapes and 150 sections, which
        means that isContentEmpty() in the domain mapper is a significant cost.
        
        We don't have layout at import time, so checking if a shape has its
        anchor in this header/footer is still expensive, but using internal sw
        API makes the 2 other checks constant and the shape check is faster this
        way.
        
        - old cost: 16638 ms
        
        - new cost: 11910 ms (72% of baseline)
        
        Change-Id: I22f75ef82b0e2f618e425e076377eea3640b83cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171390
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e747986af4dbb6b48957092dadce26a95b910a82]

        tdf#161189 - CopyFromClip: improve handling of deleting notes
        
        Instead of adding additional deletion flags, just remove the note deletetion flag when needed.
        
        Change-Id: Iba0dd4f922694c9fff98f4b74bccad1b8ee16d49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170803
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-08-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5ad9c0777602541fb39dea5da71e7bfd70595fb]

        cid#1556086 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556087 COPY_INSTEAD_OF_MOVE
        cid#1556093 COPY_INSTEAD_OF_MOVE
        cid#1556094 COPY_INSTEAD_OF_MOVE
        cid#1556105 COPY_INSTEAD_OF_MOVE
        cid#1556121 COPY_INSTEAD_OF_MOVE
        cid#1556184 COPY_INSTEAD_OF_MOVE
        cid#1556399 COPY_INSTEAD_OF_MOVE
        cid#1556405 COPY_INSTEAD_OF_MOVE
        cid#1556419 COPY_INSTEAD_OF_MOVE
        cid#1556421 COPY_INSTEAD_OF_MOVE
        cid#1556444 COPY_INSTEAD_OF_MOVE
        cid#1556448 COPY_INSTEAD_OF_MOVE
        cid#1556457 COPY_INSTEAD_OF_MOVE
        cid#1556468 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I1f352682daebd4e3ed2e7fe669aa0943dcc33edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171372
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-02  Miklos Vajna  <vmiklos@collabora.com>  [c7bc52f8e69f772edad9c4f695155281e19b1952]

        sw doc model xml dump: add SwFormat::dumpAsXml()
        
        SwFormat's name was dumped at 4 different places, extract that to a
        single function.
        
        Change-Id: I64026a267676ca5b0a5920b1a3ee0efa323defc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171389
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-02  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [9ed09fb1327e6cd10febe45c7f76ee1e46d99b5f]

        tdf#158504: add unit test
        
        Change-Id: Ie0b11ea04e3ad50206dfa219ebe7f138c00861e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171089
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [2d6aa340faf5409f1beb50193590b411f515d004]

        tdf#162289 Update printer info before getting default printer
        
        Move the call to `Printer::updatePrinters` to update the printer
        infos from the print dialog ctor to the beginning of
        `Printer::PreparePrintJob` (which is the only method
        potentially creating a print dialog) to make
        sure that the printer infos (including the default printer)
        are already up to date there.
        
        This e.g. makes sure that the current CUPS default printer on
        Linux gets preselected the next time the print dialog gets
        opened if it was changed while LO is running.
        (Otherwise, it would only be preselected as expected when
        the print dialog gets opened, closed and reopened again.)
        
        For macOS, there was already code to explicitly call
        `Printer::updatePrinters` in case the dialog was not shown.
        Drop that, as it happens unconditionally at the beginning
        now.
        
        Change-Id: I5cd530c0c9801bde88e40f5ac2220feb0e8d4247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171371
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [1d1640dbeda76fcecd7b81200a60c267cea5f2f7]

        tdf155447 gtk3 a11y: Report accessible ID for drawing area
        
        Override `GtkInstanceWidget::get_accessible_id()`
        for `GtkInstanceDrawingArea`, similar to what
        is done for the handling of the accessible name
        and description.
        
        While accessible name and description don't
        have to explicitly be set on the AtkObject
        because they can be retrieved from the
        underlying XAccessible on demand as
        `AtkObjectClass::get_name` and `AtkObjectClass::get_description`
        are overriden (s. LO's `atk_object_wrapper_class_init`, and
        the ATK implementations of `atk_object_get_name`
        and `atk_object_get_description` [1]),
        there's no such function to override for the
        accessible ID (s. ATK's `atk_object_get_accessible_id`),
        so explicitly set it for the drawing area's
        AtkObject each time the accessible is queried in
        `GtkInstanceDrawingArea::GetAtkObject`.
        
        With this in place, the accessible ID
        "sentence" shows up in Accerciser with gtk3 for
        the corresponding edit view in Writer's spell check
        dialog, as is already the case for qt6 since
        
            Change-Id: I5cf8958118c84c01ecb3545381a05b306ca53163
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 31 13:25:45 2024 +0200
        
                tdf#155447 a11y: Set accessible ID for WeldEditView
        
        [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/fddfd5ae5d44b09c3e587f41f450e05b95262bd9/atk/atkobject.c#L686-729
        [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/fddfd5ae5d44b09c3e587f41f450e05b95262bd9/atk/atkobject.c#L1717-1733
        
        Change-Id: Ib1e889a06dccf4522148d8a17b62259dc08e2b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171321
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [57f6105c90019f6a2070ab52335d7a4e852466ff]

        tdf#155447 a11y: Set accessible ID for WeldEditView
        
        Let `WeldEditAccessible` derive from `XAccessibleContext2`
        and implement `XAccessibleContext2::getAccessibleId`
        by returning the accessible ID set in the underlying
        drawing area.
        
        This makes an accessible ID of "sentence" show up
        in Accerciser for the corresponding edit view in
        Writer's spell check dialog when using the qt6 VCL plugin,
        since that is the ID set in the .ui file
        (cui/uiconfig/ui/spellingdialog.ui).
        
        It's not set for gtk3 yet, which uses native GTK
        widgets, and where the accessible ID is not set for the
        drawing area yet.
        
        Change-Id: I5cf8958118c84c01ecb3545381a05b306ca53163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171320
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [0dd7751df292f5135be13b13e74e415b20053c67]

        tdf#155447 a11y: Introduce weld::Widget::get_accessible_id()
        
        This will be used in an upcoming commit to implement
        reporting of the accessible ID for `WeldEditView`.
        
        For Qt 6, this uses the API introduced in qtbase commit [1]
        
            commit b8b7c58402740204da72e1b1f4ea7321b7bfa540
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 15 16:53:58 2024 +0200
        
                a11y: Add property for QWidget's accessible ID
        
        For GTK 4, there is currently no corresponding API;
        issue [2] suggests to add it.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=b8b7c58402740204da72e1b1f4ea7321b7bfa540
        [2] https://gitlab.gnome.org/GNOME/gtk/-/issues/6870
        
        Change-Id: I9bf38b3c2d6d0cf627ac4288695dcc1137c3d120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171319
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-02  Patrick Luby  <guibmacdev@gmail.com>  [3ee53d75d253fb7fe2eb8db44afca95fda7f156d]

        tdf#162264 check if rReq.GetArgs() is a nullptr
        
        Change-Id: I04d613cf5f2b8ee672334bafd59c460fd9028320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171250
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-08-02  Pierre F  <fpy@bger.ch>  [38ce16a9519ad7c612b782d6f645c7b8f3fa353c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b2a9c64b866c0978f37f8847ac46b527896268c
          - POWER(). tdf#121398
            
            Change-Id: Ie652aa1adf1efde0eabb63bfc5d7e75f9b3ae0f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171350
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-01  Pierre F  <fpy@bger.ch>  [5fa6e7948c0092a14c08c0f331dfa3fbb3274be3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88362088ede770a13b8b5585d85db26ce0108d07
          - dashes in word count. tdf#62799
            
            Change-Id: Ic0cd01793eae26020942e59a643b97946ac00bc3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171354
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-01  Pierre F  <fpy@bger.ch>  [02d99cce7044c0340ce3a7c62a8b24662a1b55a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58d853c3ded5efc70a3ca23f89fa334e346a702b
          - clarify DAYS()  tdf#158215
            
            Change-Id: Ic7dae4b334ab8a5c9aac01e433c0b402a3f1ce1e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171345
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-08-01  Pierre F  <fpy@bger.ch>  [d6efb4eb80c3086f490d4fdd193a76e8e952e4dd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b4da8e88b89d877bf4a0c6c2d047c992fc26476
          - NPV() example. tdf#131140
            
            Change-Id: I551522d382b9239ac4f566c7109ac032eb7e9a04
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171348
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-01  Noel Grandin  <noelgrandin@gmail.com>  [639a1f39dd45a6ff71eec2c073a84a9f181e350f]

        optimise GetDataEntries a little
        
        instead of swapping variously between std::vector,
        std::set<ScTypedStrData> and ScTypedCaseStrSet, just use the last
        one, which is the one that we want.
        
        Note that this is a behaviour change, because even though most of
        the code carefully used case-sensitive comparison, the code
        in ScColumn::GetEntries used the default ScTypedStrData::operator<
        which is case-insensitive.
        
        I think that case-sensitive is what we really want.
        
        Change-Id: I097dac6f5b5b1caa1d3dd7000aee516e9923c6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [528f1451c950160650968d791a241d9501661069]

        Add extended tip to definedatabaserangedialog.ui
        
        + totals row
        + available ranges
        
        Change-Id: I5beef214d118ac07bd707d094a2156f83b9ca095
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171381
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-08-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b8b03ba2764c89fed9f44fbe941aa93ec27e4f42]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ffbbfc987819e0bb37eb58c8faa3554acc77b685
          - Review Calc Define database range Help page
            
            + Merge database range option page into main database range page
            + drop extra page
            + Add description for Operations in options
            + Add description for Totals row
            + in preparation for tdf#162275
            
            Change-Id: Ifd0e3b36375b7db97bf77ce3f6baa0ae5bc37e84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171379
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-08-01  Mike Kaganski  <mike.kaganski@collabora.com>  [7a1a0607501e47ff03b1b66e1189a221d327bad4]

        tdf#162282: restore correct handling of EMF
        
        Commit 166a16594eb4e7e78f3f5b00a1432637d109bf8d (Simplify logic in
        XOutBitmap::WriteGraphic a bit, 2023-04-01) changed the logic, so
        that when the graphic's data reported VectorGraphicDataType::Wmf
        type, it wasn't further checked if its link's IsEMF returns true.
        That made isKnownVectorFormat return false for such EMFs, and so
        the graphic was exported to a new EMF, instead of using its data.
        This restores the original behavior.
        
        Change-Id: I68b807e735e501de6bf37172390623938e401e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171377
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-01  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [af014d1b5dea3419560b1df7933e3ac61db2c76b]

        CairoSDPR: Simplify EditEngine text decomposition
        
        The EditEngine decomposes it's content mainly to
        Prmitives (there is still a direct paint mode used
        in rare remaining cases which we not yet got rid
        of). For TABs the special case for 'extended' TABs
        (see format/paragraph/Tabs, FillCharacter) was
        handed through all layers using method DrawingTab,
        put into a DrawPortionInfo and held at the text
        primitive (TextSimplePortionPrimitive2D). While
        for direct paint the expansion was already done in
        ImpEditEngine::Paint anyways (and always painted,
        independent from bStripOnly what was unneccessary
        and I corrected that, too) it had to be done for
        text paint in VclProcessor2D for each repaint.
        This is not needed, so now the extended text
        created in EditEngine decompose gets used.
        
        This makes a lot of stuff simpler, including
        EditEngine/Outliner and some involved classes.
        If it somehow should show that it might be
        necessary to do that for each paint it should
        be done in the obvious way then - using an own
        primitive that creates the expansin in the
        decomposition (and buffers it).
        
        Change-Id: Ieb02219142af8f6bee01dcd658e08b185a4212cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171380
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-08-01  Noel Grandin  <noelgrandin@gmail.com>  [4726058aa522bf72df4938bf76075ff68f8bacc3]

        optimise ScTable::dumpColumnRowSizes a little
        
        use an OStringBuffer to accumulate the result
        
        Change-Id: I7d585b48183208200c62fe4f1d9e639cc3b1d466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-08-01  Skyler Grey  <skyler.grey@collabora.com>  [5292d8d52c2fd1f2556d0691738961f2e3ddda46]

        fix(writer): send document bg color on new theme
        
        In Ic025e542417da004c1c4a2bfd58a858deb4caa58, we intended to start
        sending the document background color to kit after a configuration
        change, which is useful when we change the document theme.
        
        Unfortunately, we mistakenly sent the *application* background color
        instead, which is normally darker/lighter than the document background
        color, causing color flashes if you tried to use the document color as a
        background before tiles were sent
        
        Change-Id: I27c8409a6fcb771d741b07d77c5598c87e178f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171373
        Tested-by: Jenkins
        Reviewed-by: Skyler Grey <skyler.grey@collabora.com>

2024-08-01  Jaume Pujantell  <jaume.pujantell@collabora.com>  [75aeaab5ef36f819cdc11e88244f59efc4fbc5a6]

        cool#9352 unassign cursor on SdrObjEditView to avoid crash
        
        On stress test with shapes and typing a segfault ocurred due to
        using a freed vcl::Cursor.
        
        On SdrObjEditView::SdrEndTextEdit, delete pOLV can delete the cursor
        remembered in pTECursorBuffer. But if it is set to the window before
        the deletion, it will be safely removed from the window.
        
        And on SdrObjEditView::ModelHasChanged a re-anchoring sets a cursor
        on the window that sholdn't be there and other SdrObjEditView can
        see, remeber, and use it even after this one died and freed the
        cursor.
        
        Change-Id: I3cfef3b68b77e6e6b49c3b68297a6a20e1f9394a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171184
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3b5738ab1a646d089fa7cc59ffaeda7d011c1e07)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171288
        Tested-by: Jenkins

2024-08-01  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [39fd178b86608ebb0717bf15992bdf6b16d6e92a]

        tdf#160843: fix page count reset
        
        - SwTextFormatColl and SwTextNode: explicitly forward page count hint
        - add test
        
        Change-Id: Ic37bece92828f21632acff8f802d4847e820542f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171329
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-08-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [514d7384470434a0b0b119e369ff615e2a1499c9]

        tdf#161968 UI Assign macro to shape crashes CALC
        
        regression from
            commit f690e8218a74a0f7792407a1d46198883d2528ff
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jan 23 13:24:29 2024 +0200
            make event config dialog async
        
        Change-Id: Ie68aeb1171831da3b457afd945ccaaa248e652af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171370
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-08-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe727997949d94cda5e867b7d2f3cb68f7b3a4b8]

        cid#1615991 Logically dead code
        
        revealed as such since:
        
        commit a1be5ede8e7a8042683efa10b823d952e1bd9513
        Author:     Noel Grandin <noel.grandin@collabora.co.uk>
        AuthorDate: Wed Jul 31 07:41:52 2024 +0200
        
            reduce number of GetItem calls
        
        Change-Id: I7856c0cd035f1225f629f8f2d1e275928fabff05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-08-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [04073f55c9eaa7e8049bdc3601ad25f9768a647c]

        cid#1607424 Double unlock
        
        and
        
        cid#1607211 Double unlock
        
        Change-Id: I5d26d0f225cc6ba5b3daf0d8308ddc6c590aa1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171369
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-01  Julien Nabet  <serval2412@yahoo.fr>  [572011827a59e93448745294f3fe3eea3e028ffc]

        tdf#162279: Base Forms: details of the warning only on debug mode
        
        As Mike noticed, the pb is more general than just Base forms.
        So here's the general fix suggested by Mike (thank you for the help!)
        
        Change-Id: Ic57039c9c37f26d2ea2d0e0bda89f277ba7044cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171337
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-01  Michael Stahl  <michael.stahl@allotropia.de>  [8ed755cfb0779c3e1119d17a7877768af1a01682]

        pyuno,unotest,xmlsecurity: copy GPG test files for UITtest
        
        The problem was that running UITest_xmlsecurity_gpg changed the files in
        test/signing-keys/ ... prevent that by copying the directory in that
        test, which is more complicated than initially expected.
        
        Change-Id: Ie3be922e0b2e9dae49f9a70e35ad5270c90b4fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171322
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-08-01  Pierre F  <fpy@bger.ch>  [e3d5b3a5ea384fff2553ede8873be274af0f11f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8479815de951772ce09480296b9e90dd360bbd3
          - ISO in WEEKSINYEAR.  tdf#152986
            
            Change-Id: Iebee1743e7b8fad3d75fe2541032cb7e7df7b61b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171347
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-01  Pierre F  <fpy@bger.ch>  [97ac30537207e3879a34cdbac5cad7644688afc7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ddaa10674f949aa3203a30ebc2ae4be695655900
          - list CDate(). tdf#154612
            
            Change-Id: Icfa71c0ac83c88feb2d89b301af480037f0f05fd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171346
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [ca74f594d698b0b7dd138f90d6eaa7edd4a22cf7]

        gtk3 a11y tests: Always use dbus-daemon for the AT-SPI bus
        
        at-spi-bus-launcher launches a separate DBus instance for
        AT-SPI, and prefers dbus-broker over dbus-daemon when the
        corresponding build option was set and dbus-broker is present.
        
        However, trying to launch a bus using dbus-broker fails
        in the environment created for the gtk3 a11y tests, which
        are run using `xvfb-run` and use a separate session bus
        created using `dbus-launch`, (i.e. the dbus-daemon
        implementation).
        
        See [1] (and other messages of that email thread) and [2]
        for more details.
        
        Avoid the problem of mixing different DBus implementations
        by setting an environment variable that makes at-spi-bus-launcher
        use dbus-daemon instead of dbus-broker regardless of how
        it was configured at build time.
        
        This depends on at-spi2-core commit [3] for at-spi-bus-launcher
        to actually evaluate the environment variable:
        
            commit e735ed9135517532d37f7dab546786f8b4d39283
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 31 11:27:27 2024 +0200
        
                at-spi-bus-launcher: Introduce env var to select DBus implementation
        
                In at-spi-bus-launcher, introduce evaluation
                of an environment variable `ATSPI_DBUS_IMPLEMENTATION`
                to allow explicitly overriding the DBus implementation
                to use.
        
                In case of `ATSPI_DBUS_IMPLEMENTATION=dbus-daemon`, don't try
                to use dbus-broker, and vice versa.
        
                This can e.g. be useful for tests in environments where
                dbus-broker is installed and was configured as the
                preferred DBus implementation at at-spi2-core build time,
                but cannot be run in the test environment, e.g. when
                tests are run via
        
                    xvfb-run --auto-servernum dbus-run-session [...]
        
                Thanks to Colomban Wendling for mentioning that idea
                in [1].
        
                [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/49#note_1854645
        
                Related: #49
        
        This makes
        
            make CppunitTest_vcl_gtk3_a11y
        
        pass on a current Fedora Rawhide when using a self-built at-spi2-core
        from its git main branch.
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2023-August/090853.html
        [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/49
        [3] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/e735ed9135517532d37f7dab546786f8b4d39283
        
        Change-Id: Ifd84ef1f993398423ac0e0f695c1c0323adf02b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171366
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-08-01  Alain Romedenne  <alain.romedenne@libreoffice.org>  [0a9135e0d901d13422a7c17c6e00ba86b1cc1ae5]

        Basic QA new unit test for IF THEN statement
        
        Intent is to cover:
        
        - repeating ElseIf blocks
        _ nested IF statements
        - IF THEN one liner
        
        Change-Id: Iee37707e26a563f336438ce7ba17271a7f06e6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171285
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [257b635dfa9bb65206b10b9a11810b30a7f345e8]

        ofz#70815 Timeout
        
        I see the cow_wrapper up copies the ImplB2DPolyPolygon during
        construction when it doesn't need to do that.
        
          #9 0x5ad39043b7f4 in void std::__1::vector<basegfx::B2DPolygon, std::__1::allocator<basegfx::B2DPolygon>>::__construct_at_end<basegfx::B2DPolygon*, basegfx::B2DPolygon*>(basegfx::B2DPolygon*, basegfx::B2DPolygon*, unsigned long) /usr/local/include/c++/v1/vector:1144:25
         #10 0x5ad39043b48d in void std::__1::vector<basegfx::B2DPolygon, std::__1::allocator<basegfx::B2DPolygon>>::__init_with_size[abi:v180000]<basegfx::B2DPolygon*, basegfx::B2DPolygon*>(basegfx::B2DPolygon*, basegfx::B2DPolygon*, unsigned long) /usr/local/include/c++/v1/vector:776:9
         #11 0x5ad393935cee in vector /usr/local/include/c++/v1/vector:1279:3
         #12 0x5ad393935cee in ImplB2DPolyPolygon /src/libreoffice/basegfx/source/polygon/b2dpolypolygon.cxx:46:9
         #13 0x5ad393935cee in impl_t /src/libreoffice/include/o3tl/cow_wrapper.hxx:195:17
         #14 0x5ad393935cee in cow_wrapper /src/libreoffice/include/o3tl/cow_wrapper.hxx:236:26
         #15 0x5ad393935cee in basegfx::B2DPolyPolygon::B2DPolyPolygon(basegfx::B2DPolygon const&) /src/libreoffice/basegfx/source/polygon/b2dpolypolygon.cxx:221:9
         #16 0x5ad390b31418 in CairoCommon::drawPolygon(unsigned int, Point const*, bool) /src/libreoffice/vcl/headless/CairoCommon.cxx:864:46
         #17 0x5ad39014ec77 in OutputDevice::ImplDrawPolygon(tools::Polygon const&, tools::PolyPolygon const*) /src/libreoffice/vcl/source/outdev/polygon.cxx:451:21
        
        Change-Id: I801cf20d7fbc815ea285fde5c1f80f5b2681e6f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171336
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-08-01  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b740afe2fe42a4bb639157a63f44e8d0c0f7310d]

        Add --with-package-format=emscripten to distro-configs/LibreOfficeWASM32.conf
        
        Change-Id: Ic5f07aa77b7c073264326dcbac56e6d2593bdc96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171281
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-01  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [817164a9de1bf497954446afe5ca5448f4a1c090]

        scripting: fix issues found by Ruff linter
        
        Change-Id: I104f1b1e1d907fbd01feeb37e3fc69ee3e2fc121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171332
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-08-01  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9dfcb5f6b61b67596a86facd35806e38da16e12b]

        Use gb_SUPPRESS_TESTS to control inclusion of embindtest.js
        
        Change-Id: Ic020678e531322b9c3af194c3529464775fd1a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171318
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-08-01  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [fb6dd47f16396b3cd65f3f3ed0b16c10671edea1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f94811a49658a3843450a74b2b31c04ced4592d6
          - Backtranslate a confusingly worded string
            
            I only got its meaning from reading the French and Portuguese
            translations. It’s very straightforward — we have a concrete
            transitive verb here — so just use it without helpers.
            
            Change-Id: I3fd6aaf7909a977e73c4b3b0c1f728efdece0bfe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171365
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-08-01  Mike Kaganski  <mike.kaganski@collabora.com>  [e47197b4ef1753af4d005a6918c26e6a3d589c67]

        tdf#148367: avoid using SQLBulkOperations with SQL_UPDATE_BY_BOOKMARK
        
        ... because that fails with MS Access ODBC 64-bit driver (bug in the
        driver). And SQLSetPos does the job anyway.
        
        Change-Id: I2d356a6a3f6de4d3c2c9a2e49cb3dd8c66af7794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171270
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-01  Mike Kaganski  <mike.kaganski@collabora.com>  [1c8a48ba766f30c9babc80db46e2cf24074486b8]

        Fix OTools::ThrowException
        
        First, it used 5-character buffer for SQL state, where MS documentation
        for SQLGetDiagRec specifies, that the buffer is for five-character code
        plus terminating NULL. The declaration of the function in Windows Kit's
        sqlucode.h uses decoration '_Out_writes_opt_(6)' for the parameter.
        
        Next, SQLGetDiagRec may fail or return SQL_NO_DATA;  and then, the data
        in buffers will be undefiled.
        
        Change-Id: Ia36555b4fe4f49c8803a25f8fc1cc1a3b6ac4ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-08-01  Mike Kaganski  <mike.kaganski@collabora.com>  [6c413b1e75c98175bc2b498e8980150d9f69d13e]

        This special case handling is redundant
        
        The same check and effect is done in the overload called later.
        
        Change-Id: I91baa1f3318d55a3f4ae3564064d8ccf66016853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171286
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-08-01  Eike Rathke  <erack@redhat.com>  [01e6e4303e5a9966f102e0357fe0354a2f74a1c4]

        Use proper CharClass for uppercase, tdf#122718 follow-up
        
        Change-Id: I1109734136e5f7e6fca026228a293498858f82a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171333
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-07-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f92897cfcd6ea9a57bbeec792733111eb49e7dc5]

        Resolves: tdf#162278 get popup position relative to the dest parent
        
        since:
        
        commit 85511e27d259d6b19cc6c463fc06368c14511bb8
        Author:     Caolán McNamara <caolan.mcnamara@collabora.com>
        AuthorDate: Sat Jul 27 20:25:35 2024 +0100
        
            Resolves: tdf#160509 use BorderWindow client for dialog parent
        
        we now use the clientwindow of toplevel frames as the parent window to
        use as the parent for dialogs/etc so we get the right SystemWindow for
        dialogs.
        
        So we need to also adjust the calculation of where we put child popups
        of such toplevel frames to be relative to the clientwindow instead of
        borderwindow
        
        Change-Id: I896e75a5ad709a51a445dc1be2c0fb9f985f01a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171330
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-31  Patrick Luby  <guibmacdev@gmail.com>  [93cd479aef9b12bc277c76a53a8d6f5804b1db6c]

        Codesign *.jnilib files like *.dylib and remove $other_files variable
        
        *.jnilib files no longer need to be codesigned before *.dylib files
        so just codesign them at the same time as *.dylib files.
        
        Also, none of the files in the $other_files variable need to be
        explicitly codesigned since all of those files get codesigned
        elsewhere in the script.
        
        Change-Id: Ia6f22f6d849ca76c1bf8a491c43fc00fee2af4a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171129
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-07-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [eff240546328f15f4f88c782637913d5eef18c74]

        use const
        
        found by Caolán in
        https://gerrit.libreoffice.org/c/core/+/171036/comment/12f98f00_83e60540/
        
        Change-Id: I1d8cd36c0ebd883c0d2e438addf510bbf1ad5262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171316
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4177e553e067a6bbbf113c39ba3b81aa8ee194fe]

        cid#1555587 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555589 COPY_INSTEAD_OF_MOVE
        cid#1555593 COPY_INSTEAD_OF_MOVE
        cid#1555596 COPY_INSTEAD_OF_MOVE
        cid#1555602 COPY_INSTEAD_OF_MOVE
        cid#1555608 COPY_INSTEAD_OF_MOVE
        cid#1555610 COPY_INSTEAD_OF_MOVE
        cid#1555620 COPY_INSTEAD_OF_MOVE
        cid#1555623 COPY_INSTEAD_OF_MOVE
        cid#1555625 COPY_INSTEAD_OF_MOVE
        cid#1555626 COPY_INSTEAD_OF_MOVE
        cid#1555634 COPY_INSTEAD_OF_MOVE
        cid#1555638 COPY_INSTEAD_OF_MOVE
        cid#1555667 COPY_INSTEAD_OF_MOVE
        cid#1555682 COPY_INSTEAD_OF_MOVE
        cid#1555686 COPY_INSTEAD_OF_MOVE
        cid#1555702 COPY_INSTEAD_OF_MOVE
        cid#1555710 COPY_INSTEAD_OF_MOVE
        cid#1555750 COPY_INSTEAD_OF_MOVE
        cid#1555752 COPY_INSTEAD_OF_MOVE
        cid#1555761 COPY_INSTEAD_OF_MOVE
        cid#1555762 COPY_INSTEAD_OF_MOVE
        cid#1555771 COPY_INSTEAD_OF_MOVE
        cid#1555772 COPY_INSTEAD_OF_MOVE
        cid#1555784 COPY_INSTEAD_OF_MOVE
        cid#1555785 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib9724230c05b2027b4edf64e6a0bb5e22a270a88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-31  Miklos Vajna  <vmiklos@collabora.com>  [ef1870810ec8c069e26538fd7626ad0656bed276]

        tdf#162280 vcl: consider font family type for glyph caching
        
        Open tdf105820-1.doc from crashtesting in a dbgutil build, save as PDF,
        we assert in checkGlyphsEqual().
        
        This is a problem since commit 6dfac38bacd449c64a13363797b56aff49cf8f52
        (tdf#162072 vcl, fontconfig: consider font-family-generic for
        substitute, 2024-07-18), because now the font name no longer determines
        the fallback name alone, so 2 paragraphs may share the cached vcl-level
        text layout, even if the underlying fallback font is different. One
        would naively expect that in the SalLayoutGlyphsCache::CachedGlyphsKey
        ctor, the fontMetric.GetFamilyType() already has the correct family
        type, but it turns out that is always the default, and only
        outputDevice->GetFont().GetFamilyType() has the up to date setting:
        
        debug:12372:12372: SalLayoutGlyphsCache ctor: output device font family name is 'Verdana', output device font family type is roman, font metric family name is 'Verdana', font metric family type is 'swiss'
        debug:12372:12372: SalLayoutGlyphsCache ctor: output device font family name is 'Verdana', output device font family type is swiss, font metric family name is 'Verdana', font metric family type is 'swiss'
        
        Fix the problem by explicitly including the output device font family
        type in the cache key.
        
        Note that this only happens in practice if the same font is used in the
        document with different family types, which is probably never the
        intention of the user. E.g. Verdana is meant to be sans, a serif Verdana
        is some weird corner-case.
        
        Change-Id: Id6cc60809a35a3dcdc6e83122a559ddfbe5d5d0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171280
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed9a557e1ceb4ffa4060024b20785f04d227e06c]

        curl: upgrade to 8.9.1
        
        Downloaded from https://curl.se/download/curl-8.9.1.tar.xz
        
        Change-Id: I7a8ddd798c41ee6c9163b771b6c57f100fdc8af0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171284
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-31  Attila Szűcs  <attila.szucs@collabora.com>  [c3159b941c329e707484e6202f2dd4a518ec7acf]

        SW: fix EOL in transform Document Structure
        
        Changed the transform parameter to uri decoded string, and
        encode it here.
        
        This way special characters will survive the transfering.
        
        Change-Id: Ibfa890f98a35559992317ac1f01596b9ca24a07b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171276
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-31  Michael Stahl  <michael.stahl@allotropia.de>  [97dcffe188f0dec4dbd0af894fe7739e1a2abcbb]

        tdf#162035 sw: fix crash with field in SwMultiPortion
        
        SwTextCursor::GetModelPositionForViewPoint() is recursive for
        SwMultiPortions, overriding m_pCurr via SwTextCursorSave, so the
        SwSpecialPos counting code needs to be recursive too.
        
        (regression from commit 468e5b8e0a7fefe1ca53faeb15f5f6527c37a268)
        
        Change-Id: Ic3f2f359a21dcae692400efdd693cc4042f9426e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171247
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a26552de2e692f205695e581166f5eeca67b100]

        tdf#161846 only need to get the local time once
        
        Change-Id: I5f24ab2357346ff3d515ab58d380ca1f844df11a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171278
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-31  Kira Tubo  <kira.tubo@gmail.com>  [5cef51f30d9dccfa35683bd0a023cffdc43fbc85]

        tdf#157129: sw unit test: cursor position after paste
        
        Test to see if the cursor position moves to the end after paste.
        
        Without the fix in tdf#157129, the cursor position remains at the
        beginning of the document.
        
        Change-Id: Id577b262b6c885d38eecdd21ae83467c9aa5eed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171132
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [f09775c69bbdd5c43ad375f4869c0d329bccebf2]

        CppunitTest_vcl_pdfexport: simplify a bit more
        
        after 159d823c7b7502ee07d897d74c4e74c6e1873596
        "tdf#153040 PDF export: disable export of form fields as PDF forms by
        default"
        
        Change-Id: I1da61a7ccddc362b8d8ab08f7e48c7da57d47337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171308
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-31  Adam Seskunas  <adamseskunas@gmail.com>  [b53c654552e2bec837ea996c60ab929e0398640d]

        tdf#135709 - Add Unit Test
        
        Change-Id: I35b2d894ce1dbffed013983585bc8cc14b93b59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171222
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [374c785daff03f10116781d364f3024aff19d46c]

        external/libexttextcat: Only pass gb_DEBUGINFO_FLAGS in debug builds
        
        broken since 797681b4f569212a0f306151167534e23a2e37af "Pass all relevant CFLAGS
        on to external/libexttextcat"
        
        Change-Id: Idd648c8cd7eaa7e78815dd2071d0a3b786fa6d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171273
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8118d1be1be11e8c8c70a0a12da25f0fb3c250f1]

        tdf#161846 use more GetItemSurrogatesForItem
        
        lots of time spent searching surrogates, and we can use
        GetItemSurrogatesForItem here.
        
        Also, add another SfxItemType which I missed in my earlier changes
        
        Change-Id: I9b989d75dbc3cdcdc1e97bf41836b92dd2852113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171272
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [550ef55881f992b53f860b7f29f4716846779ea0]

        Reintroduce OUString::replaceAt taking an OUString to LIBO_INTERNAL_ONLY
        
        This allows optimizations when 'this' is empty, avoiding allocations, and
        making it possible to not special-case it in other places, as was done in
        ContentNode::Insert in commit 8ab44b114c6706ab2e3d8a19884daeb544d3c2e1
        (tdf#161846 avoid allocation in ContentNode::Insert, 2024-07-30).
        
        A couple of disambiguation templated overloads was introduced.
        
        Change-Id: I2b5e94c2175379b2696c34e600393d32731f0ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [31c5e451f57ad6172188fddfde5b66ead6f97627]

        Fix typo
        
        Change-Id: Ia3762c73a2787f404efb8f6005366283373641c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171267
        Tested-by: Jenkins
        Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1be5ede8e7a8042683efa10b823d952e1bd9513]

        reduce number of GetItem calls
        
        if we already call GetItemState, we can use that call to fetch the item
        
        Change-Id: I736dec9bb56ad3bd66bb53e1cef2cf1e3092821d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07d357756922e35220a924dab82d315fea22cecb]

        cid#1555417 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555423 COPY_INSTEAD_OF_MOVE
        cid#1555430 COPY_INSTEAD_OF_MOVE
        cid#1555436 COPY_INSTEAD_OF_MOVE
        cid#1555440 COPY_INSTEAD_OF_MOVE
        cid#1555443 COPY_INSTEAD_OF_MOVE
        cid#1555454 COPY_INSTEAD_OF_MOVE
        cid#1555459 COPY_INSTEAD_OF_MOVE
        cid#1555461 COPY_INSTEAD_OF_MOVE
        cid#1555468 COPY_INSTEAD_OF_MOVE
        cid#1555477 COPY_INSTEAD_OF_MOVE
        cid#1555484 COPY_INSTEAD_OF_MOVE
        cid#1555511 COPY_INSTEAD_OF_MOVE
        cid#1555515 COPY_INSTEAD_OF_MOVE
        cid#1555519 COPY_INSTEAD_OF_MOVE
        cid#1555534 COPY_INSTEAD_OF_MOVE
        cid#1555537 COPY_INSTEAD_OF_MOVE
        cid#1555544 COPY_INSTEAD_OF_MOVE
        cid#1555553 COPY_INSTEAD_OF_MOVE
        cid#1555559 COPY_INSTEAD_OF_MOVE
        cid#1555561 COPY_INSTEAD_OF_MOVE
        cid#1555563 COPY_INSTEAD_OF_MOVE
        cid#1555564 COPY_INSTEAD_OF_MOVE
        cid#1555568 COPY_INSTEAD_OF_MOVE
        cid#1555571 COPY_INSTEAD_OF_MOVE
        cid#1555580 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia42a78bffddc80d0e82144f4db51dc6e4d2e9a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-31  Per99  <solare99@gmx.de>  [ef7429f86788f0616db5b274ec77eb67cd41cb3d]

        tdf#161765, tdf#115688 Let user choose which animation settings to use
        
        In the accessibility option page, the user can now choose which
        animation settings to use (OS's or LO's animation setting) and what
        animations to allow.
        This fixes also tdf#115688: "Add Checkbox option to disable animated
        overlay to Tools -> Options -> Accessibility panel"
        
        Changes due to this patch:
        1. Changes in the GUI of the accessibility option page:
          - New option "Allow other animations"  (Used for "Marching Ants"
            animation, instead of old expert option "AnimationsEnabled"), now as enum.
          - Changed option "Allow animated images", now as enum: "System", "No", "Yes"
          - Changed option "Allow animated text", now as enum: "System", "No", "Yes"
          - The old animation options in Common.xcs are not renamed, but marked
            as deprecated and obsolete in their text.
        These above changes are in the files: [optaccessibilitypage.ui,
        optaccessibility.hxx, optaccessibility.cxx, Common.xcs]
        
        2. Added functions to compute if the animations of images/text/other
        are allowed. If "System" is chosen, then use OS’s animation setting.
        See files: [settings.hxx, settings.cxx]
        
        3. Respect the animation settings of animated images/texts in Draw and
        Impress. Don't prohibit the user to enable animations in Draw and
        Impress if the OS's animations are disabled.
        See file: [objectcontactofpageview.cxx]
        
        4. Respect the animation settings of animated images in Writer.
        See file: [viewsh.cxx]
        
        5. Respect the "Allow other animations" setting in Calc
        (for "marching ants" animation). Don't prohibit the user to enable these
        other animations in LO if the OS's animations are disabled.
        See file: [overlayobject.cxx]
        
        Change-Id: I5173f9b3d8652a17a6ae07164e874143738bcd66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170827
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf47539b805a3c654fa8ab3638123875b53565d5]

        Remove exec bits on rtf file
        
        Change-Id: I818e97fd6f1eab460c34728fe90226495b9214e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171268
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b3994c04c30cee9ed2df05812b28fdcc4ac36436]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a734e158c1bc2f5445ec79cc1662534f4c9bfac1
          - Reorder LO Options contents tree
            
            Change-Id: Ie8aa940f45bf85c493f8c912e00b080da3b15b61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171265
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [523a46c3a4df0bf9007f1665a115cc33d610bd73]

        tdf#161846 reduce number of PropertySetInfo objects
        
        Change-Id: I28919d3268fc695108b325830ae32104e6c1821a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171248
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [952ded08943731b6e367d7a2b7a54ee7f35464a8]

        tdf#161846 no need to CloneAsValue() here
        
        the methods are already returning by value
        
        Change-Id: Ie9eaf2ba3ae0ca4ad79b05229dd6856537580044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171249
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [42f44a42b625002c8f0e4e832ec457481d89a54c]

        tdf#124341: special-case applying autoformat to whole rows
        
        The problem of allocating thousands of columns can be usually avoided
        when whole rows are selected (e.g., whole sheet). ApplyPatternArea
        (which does the real format application) has a special processing for
        'nEndCol == GetDoc().MaxCol()' case, when it only changes the default
        beyond the already allocated columns. So we can try to pass a single
        range per row (or per row range) where possible, instead of applying
        the format to body without the right column, which would disallow the
        mentioned optimization.
        
        To make that possible, this change detects if whole rows are selected,
        and then it assumes that the user doesn't need the rightmost column
        format of the autoformat. This change also rearranges application of
        format to be by rows rather than by columns where possible. This is
        expected to not slow down the cases that allow by-column application,
        because these cases would either apply to whole body block, or not
        allow by-row application (alternating columnar pattern).
        
        Indeed, this won't help when the autoformat has checkerboard pattern.
        Also, this won't prevent following slow save of the resulting file,
        which would be a separate problem.
        
        Change-Id: Id18a0edb7d6d09fccc3ebb1de3c12eaa45b34501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171223
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-30  Oliver Specht  <oliver.specht@cib.de>  [f806fc136b3410ec9a1e09320d100c78b33c867b]

        tdf#137335 calculate paragraph height in RTF/DOCX
        
        TabStops and spaces are not included in height calculation of paragraphs in Word.
        With a compatibility option this is now also set in RTF import.
        But if spaces or/or tabstops are the only parts of a line their font size
        is taken into account.
        The fix 89e7341025b607491c90efdb74708e63d875c1e5%5E%21 from tdf#142404
        has been removed because it broke formatting of follow lines.
        
        Change-Id: Id28488438462114bd54c4f8bd15e2ada606c4192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168788
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-30  Oliver Specht  <oliver.specht@cib.de>  [3b8aad9781654a392b973690fb62f69433366c58]

        tdf#161878 Ignore nested SYMBOL field inside IF field
        
        Adds SYMBOL field to the list of content that cannot be nested into
        an IF field. Prevents importing of SYMBOLs before the IF field.
        
        Change-Id: I0c2f92d7893c189a42e835ffd4b9fd6e0e23a17b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169900
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9bf97034601af0fd679a2d4349b6ac31be5e315d]

        tdf#161846 remove one layout operations (v)
        
        of the 6 we perform per caption
        
        Change-Id: I57b3f12ca73e08e18be4d22da74e688969ae35b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-30  Noel Grandin  <noelgrandin@gmail.com>  [bc0d05bdc0dbd45c9d1605d689e5d02867ebfb74]

        try to fix crash in JunitTest_svx_unoapi
        
        Seen by vmiklos locally, and by myself on jenkins. I cannot
        reproduce this locally, so this is somewhat of a blind fix.
        
        Program terminated with signal SIGSEGV, Segmentation fault.
        $#0  0x00007f3e995c273a in sdr::properties::AttributeProperties::Notify (this=0x7f3e7000deb0, rBC=..., rHint=...)
            at /home/vmiklos/git/libreoffice/core/svx/source/sdr/properties/attributeproperties.cxx:464
        464                                         pNewStSh = static_cast<SfxStyleSheet*>(rModel.GetStyleSheetPool()->Find(
        [Current thread is 1 (Thread 0x7f3e6d2566c0 (LWP 18774))]
        (gdb) bt
        $#0  0x00007f3e995c273a in sdr::properties::AttributeProperties::Notify(SfxBroadcaster&, SfxHint const&) (this=0x7f3e7000deb0, rBC=..., rHint=...)
            at /home/vmiklos/git/libreoffice/core/svx/source/sdr/properties/attributeproperties.cxx:464
        $#1  0x00007f3e995bd674 in sdr::properties::TextProperties::Notify(SfxBroadcaster&, SfxHint const&) (this=0x7f3e7000deb0, rBC=..., rHint=...)
            at /home/vmiklos/git/libreoffice/core/svx/source/sdr/properties/textproperties.cxx:549
        $#2  0x00007f3e9b421176 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x7f3e683ce5f0, rHint=...) at /home/vmiklos/git/libreoffice/core/svl/source/notify/SfxBroadcaster.cxx:40
        $#3  0x00007f3e9b35fdad in (anonymous namespace)::StyleSheetDisposerFunctor::Dispose(rtl::Reference<SfxStyleSheetBase>) (this=0x7f3e6d2532a0, styleSheet=rtl::Reference to 0x7f3e6830c260)
            at /home/vmiklos/git/libreoffice/core/svl/source/items/style.cxx:762
        $#4  0x00007f3e9b31b2bd in svl::IndexedStyleSheets::Clear(svl::StyleSheetDisposer&) (this=0x7f3e685ebd50, disposer=...)
            at /home/vmiklos/git/libreoffice/core/svl/source/items/IndexedStyleSheets.cxx:187
        $#5  0x00007f3e9b35fe8d in SfxStyleSheetBasePool::Clear() (this=0x7f3e683ce5f0) at /home/vmiklos/git/libreoffice/core/svl/source/items/style.cxx:773
        $#6  0x00007f3e9b35f0d7 in SfxStyleSheetBasePool::~SfxStyleSheetBasePool() (this=0x7f3e683ce5f0, __in_chrg=<optimized out>)
            at /home/vmiklos/git/libreoffice/core/svl/source/items/style.cxx:580
        $#7  0x00007f3e4c4d217e in __static_initialization_and_destruction_0(int, int) (__initialize_p=32574, __priority=1748821488) at /usr/include/c++/12/iostream:74
        $#8  0x00007f3e4c4cedba in std::construct_at<ScSortKeyState, ScSortKeyState>(ScSortKeyState*, ScSortKeyState&&) (__location=0x7f3e683ce5f0) at /usr/include/c++/12/bits/stl_construct.h:94
        $#9  0x00007f3e683ce5f0 in  ()
        $#10 0x00007f3e6d253380 in  ()
        $#11 0x00007f3e4c4ceddc in std::construct_at<ScSortKeyState, ScSortKeyState>(ScSortKeyState*, ScSortKeyState&&)
            (__location=0x7f3e4c4ceddc <std::construct_at<ScSortKeyState, ScSortKeyState>(ScSortKeyState*, ScSortKeyState&&)+36>) at /usr/include/c++/12/bits/stl_construct.h:97
        $#12 0x00007f3e9e756ce4 in cppu::OWeakObject::release() (this=0x7f3e683ce668) at /home/vmiklos/git/libreoffice/core/cppuhelper/source/weak.cxx:229
        $#13 0x00007f3e4c460e26 in std::__uniq_ptr_impl<SvNumberFormatter, std::default_delete<SvNumberFormatter> >::operator=(std::__uniq_ptr_impl<SvNumberFormatter, std::default_delete<SvNumberFormatter> >&&) (this=0x7f3e683ce668, __u=...) at /usr/include/c++/12/bits/unique_ptr.h:184
        $#14 0x00007f3e4c460c30 in rtl::Reference<ScStyleSheetPool>::~Reference() (this=0x7f3e683ce5f0, __in_chrg=<optimized out>) at /home/vmiklos/git/libreoffice/core/include/rtl/ref.hxx:126
        $#15 0x00007f3e4c460175 in ScPoolHelper::ScPoolHelper(ScDocument&) (this=0x7f3e683ce5f0, rSourceDoc=...) at /home/vmiklos/git/libreoffice/core/sc/source/core/data/poolhelp.cxx:33
        $#16 0x00007f3e4c4601fc in ScPoolHelper::ScPoolHelper(ScDocument&) (this=0x7f3e682a3370, rSourceDoc=...) at /home/vmiklos/git/libreoffice/core/sc/source/core/data/poolhelp.cxx:34
        $#17 0x00007f3e4bddcf52 in cppu::OWeakObject::operator delete(void*) (pMem=0x7f3e4bddcf52 <cppu::OWeakObject::operator delete(void*)+3>)
            at /home/vmiklos/git/libreoffice/core/include/cppuhelper/weak.hxx:90
        $#18 0x00007f3e682a3370 in  ()
        $#19 0x00007f3e6d253480 in  ()
        $#20 0x00007f3e4c0bda00 in VclPtr<VirtualDevice>::disposeAndClear() (this=Python Exception <class 'gdb.MemoryError'>: Cannot access memory at address 0xffffffffffffffd8
        
        Change-Id: I936b5042a368b08a20ea9f545892ef8a6625f5fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171235
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [e552de24b646f8dc59551203edd901dad6af0ff5]

        tdf#156689: don't initialize the last columns from the default attributes
        
        Regression from dd8e061406fac581d399da088c7f0187278035dc
        "tdf#153437 sc: fix broken formatting without performance regression"
        
        Change-Id: Ifacc48db93f28ec7b539af640e95eff8ad5ec535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171242
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-30  Jonathan Clark  <jonathan@libreoffice.org>  [142ce290a2a29f9794ba9a689f35d6f7e3ff588c]

        tdf#162194 sw: Fix for auto-hyphens inside ligatures
        
        Fixes an issue causing Writer to print ligature glyphs in front of
        automatic hyphens, instead of breaking ligatures at the hyphen insertion
        point.
        
        Regression from commit ab0a4543cab77ae0c7c0a79feb8aebab71163dd7
        (tdf#124116 Correct Writer text shaping across formatting changes)
        
        Change-Id: I7d6fbfdc892cce0c50552629f520deedc5304c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171245
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b8071baaf3e72ca793560428a1b1bbdab71be2a]

        tdf#153437: sc_ucalc: Add similar test for columns
        
        Change-Id: I183c6c900a618b434896ecbb5c08755d8513b47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171241
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d48438750068ec9fa0ed5703d2340fc737aa201]

        CppunitTest_sc_ucalc: these tests are not related to copy/paste at all
        
        Change-Id: I044443fd0f259f326476dc657c505b8934922d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171240
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-30  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b4ddc6e9514ddd82259d49dbae70a7e7185bf011]

        tdf#152919: update UserFields
        
        - fixes regression from 86d11097cd4a2ae4a6b4e6b35e28a6075376d67a
        - Unfortunately SwUserFieldType::SWClientNotify has sideeffects that we
          rely on
        
        Change-Id: Ic0cbac0c584e28dd5f49405d116d78eab0e3083e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171099
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ccdf1096a6103d2ab8690e8e97dcf3496160ecff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 482dc7100c9eeecc6bee79db2a1232d1e01378e5
          - tdf#103587 Add wildcards to Find &Replace Help page
            
            + Added wildcard contents/links
            + Refactor file
               + join specific settings into switch, instead of switchinline
               + move UNO bookmarks to find toolbar help page
               + deleted many <ahelp visibility="hidden"> ...
            
            Change-Id: Ic5265374fb15511addfea4f411679126136ec378
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171244
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-30  Leonard Sasse  <l.sasse@fz-juelich.de>  [14d15cf61437c144031d4e95e6e104a6f2969597]

        tdf#158803: F401 Remove unused imports.
        
        Also did some extensive reformat in this one as trailing whitespaces
        and bad formatting prevented commiting because it gave the following
        error:
        
        *
        * You have some suspicious patch lines:
        *
        * In scripting/source/pyprov/mailmerge.py
        * indent with Tab (line 446)
        scripting/source/pyprov/mailmerge.py:446:                       return PyMailSMTPService(self.ctx)
        * indent with Tab (line 448)
        scripting/source/pyprov/mailmerge.py:448:                       return PyMailPOP3Service(self.ctx)
        * indent with Tab (line 450)
        scripting/source/pyprov/mailmerge.py:450:                       return PyMailIMAPService(self.ctx)
        
        Change-Id: Ie6a7a81dda851548a06057fb712cd3e094c9b97d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165498
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0bf2e317ac34512b348dcf0e7d9a8c10a47d6aef]

        More exhaustive org.libreoffice.embindtest.Struct
        
        Change-Id: I91085ef8cd7cd80852c0d0ab4f87fd3226a10a00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171236
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [3371a9b36fb455501449d6575250ff19e5ffa18b]

        sw: get rid of parseDump
        
        So parseLayoutDump is only called once per test
        
        Change-Id: Ia199e0a7eeac26fbde94f6450d2aa49828940806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171219
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4f0c25dda41b5a8f418c1e283a4a85143393ae4c]

        Fix typo
        
        Change-Id: I908619bca56ac82b4f6696736907a51fbe825ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171231
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4e246af74bb4cf8d3efe3462fbf97594a9a6f66c]

        Fix typo
        
        Change-Id: I3d42b46e8f1c83a1979f04e8b4c103b9e181b467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171232
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a13e5ff9661a60c6e6032fb16a10350b67f4dde5]

        Fix typo
        
        Change-Id: I637045d189aea162aec63297c1aed6372f09cd38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171229
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f8b4f328b1dfef64bada82069a56e6d1fa63eb1]

        Fix typo
        
        Change-Id: I4181f5d1988a9ddb90b2a5e545143a3e794a5a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171230
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-30  Dione Maddern  <dionemaddern@gmail.com>  [21d51ac71d320c6b2b7d83266d246e1e31cfe03d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e51cdc8311022a27867898738ff0a7220078e9d
          - Add help page for Page sidebar deck
            
            text/swriter/01/page.xhp
            - Created new help page for Page sidebar deck
            
            In AllLangHelp_swriter.mk
            - Added new help page to list
            
            Added self-links and section names to the following pages to allow linking and embedding from other pages:
            - text/shared/01/05040200.xhp
            - text/shared/01/05040300.xhp
            - text/shared/01/05040400.xhp
            - text/shared/01/05210100.xhp
            - text/shared/01/menu_view_sidebar.xhp
            - text/swriter/01/05040000.xhp
            - text/swriter/01/05040500.xhp
            
            Change-Id: Iaee8741558a64544a6abdca6da068864f2c14d32
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170865
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [24a0ecfc9c8d76dc2af6a44212d5a0a6ed6ffe6b]

        tdf#161846 reduce re-alloc in ImpEditEngine::GetSelected
        
        we can fairly easily allocate the exact buffer size we need and avoid
        needing to extend the buffer
        
        Change-Id: I7f0b2533dab03452db60ddaa5b8a5f3471c195ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171225
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-30  Miklos Vajna  <vmiklos@collabora.com>  [159d823c7b7502ee07d897d74c4e74c6e1873596]

        tdf#153040 PDF export: disable export of form fields as PDF forms by default
        
        Open <https://bugs.documentfoundation.org/attachment.cgi?id=195586>,
        notice that from "bbb", the middle "b" is bold, export to PDF, none of
        the "b"s are bold.
        
        The reason for this is that by default we map form controls and content
        controls to fillable PDF forms, which can only contain plain text.
        
        Fix the problem by defaulting to not exporting form controls / content
        controls to PDF forms: most users just want a PDF that is close to what
        they saw in the edit window -- and the ones who want a fillable PDF form
        can still opt in. Once the UI checkbox is enabled, we even remember
        that.
        
        Based on <https://gerrit.libreoffice.org/c/core/+/152622>, thanks
        Justin!
        
        Change-Id: Iddb75d1dbd969045321e139154f254c059eebf16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171226
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f504bd1ac99fe9464d6a5e41febbdcab08af1c97]

        Embind: Missing support for UNO polymorphic struct types
        
        Change-Id: I6bb29a951e6e5a3ed7d825172ba7b92ef95a5619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171228
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ab44b114c6706ab2e3d8a19884daeb544d3c2e1]

        tdf#161846 avoid allocation in ContentNode::Insert
        
        which is fairly common
        
        Change-Id: I3b1ec65d880cb71b8894f292061e23376af177bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171224
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-30  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [c17659cc51e4eea7b26f936604c2c3a29b308ba7]

        tdf#159168: consider dflt char format 'applied', even if it apparently is not
        
        Change-Id: Id525b934a0e329e5c630f81e2e959f29b5dffc0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171096
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b6f8df8a6006037bf986e3f6c784d27e4d83aea0]

        tdf#162250 - Fix Assertion failure Accessibility page on GTK
        
        follow-up commit: Ib01e7d76e74b0b9cc9df259295edbee135b1c8a2
        (Add global Accessibility check options for
        managing which a11y issue should be checked. In default mode all the
        a11y issues are checked.)
        
        Change-Id: I5f936e8bbf7277e156594d51673fe48ff7cf6cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171216
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-07-30  Pierre F  <fpy@bger.ch>  [2f28eb5e907d958077168a762695c97e2106e374]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7be715626c3b06bcb69faa60338f6de486918f74
          - cleanup Local. tdf#154595
            
            Change-Id: Ie0809e49fe6c9d0d43ed4f2a8e59a7947011008c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171044
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [510d3585d22d4a6bbaad9832141b5a3005c0c626]

        tdf#161846 remove one layout operations (iii)
        
        of the 6 we perform per caption
        
        Change-Id: I5afbc296a9be4fcb732cfbe28d43a2ad45aa6c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [426adcbadc66fd79859e50ddc0064e899fc019e3]

        tdf#161846 remove one layout operations (iv)
        
        Change-Id: I0c09c7b4636a7ac4c3dc87a8a17efd278109c3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171213
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-30  Aron Budea  <aron.budea@collabora.com>  [d671bceed0ba7195eae1e063d4a363074f8483a0]

        LOK: Mention name of unknown command in exception
        
        Change-Id: I665c9aebaa4e215b8bc4622f3e245e5f2c47deab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171133
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 8fe4ca79d4b3cc2a62c59b7dfd2849b7a79d9437)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171196
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-07-30  Oliver Specht  <oliver.specht@cib.de>  [0d512cb88757ced10a825a3d544e41696a54341a]

        tdf#134902 evaluate visibility of VML shapes
        
        VML shapes from docx should be invisible if "visibility:hidden" is set.
        
        Change-Id: I8299a5c3a7fca8deae2ec37523c3f2e240376893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167989
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-30  Oliver Specht  <oliver.specht@cib.de>  [2b45427a567d1d52951b6f61aaea74147dab10cf]

        related tdf#160621: request extra height for field value entry
        
        With this, both edit and add fields dialog should look near-identical
        at this spot (seems extra rows are needed for native dialogs like gtk,
        while Windows wants the extra height-request).
        
        Change-Id: Iafee3d60d33c9eee6020e9ef49aaac900222a0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170835
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [67d02a8fc91df1044a6d9715a07c258b6669659f]

        sw: get rid of discardDumpedLayout
        
        Change parseLayoutDump to make it the
        only place where the layout is dumped
        and once it's not needed anymore, discard it
        
        Change-Id: Ia89ff569752e1e592209fa4ccb0b4753eee17e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171075
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [27dea7e1fecade10a528d95e484359b8d80f057a]

        CppunitTest_sw_mailmerge: simplify a bit
        
        Change-Id: I5eacde6d4622a9ff464cc30f6cb6124b1d2ca9af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171218
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c60be7cdfabe6fbe55166041f2df19ecdd82f73]

        CppunitTest_sw_mailmerge: replace usage of parseDump
        
        Change-Id: I04f75abb16249fc384ea63b456696f8edf278b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171215
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dfa78d2eac7632c93d1e76e52c9d46050dd932a2]

        fix macOS codesigning: only mach-o files allowed in Contents/Framework
        
        put the other files in Contents/Resources and have them signed with the
        overall bundle-signature.
        
        Putting them into Contents/Framework or Contents/MacOS would require the
        use of extended attributes and is not recommended, see also
        
        4b9190fc29aec0f005f08c0269bb9ff081f19fe3 /
        https://gerrit.libreoffice.org/c/core/+/109537
        
        Change-Id: I582e3198b1a006e76d6ad37bd945e0712d17c669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171217
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [78ff4793f9ad45d84f923686095acb670e7a3ea0]

        tdf#161846 remove one layout operation (i)
        
        of the 6 we perform per caption object
        
        Change-Id: I8af5a0a4c859241fa350fcd3c45cfdfe1cfb6475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-29  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [129e69f005d4752bb5ec10a8c12d842037394822]

        testtools, wizards, xmlsecurity: fix issues found by Ruff linter
        
        Change-Id: I03edbaa7c9a643ca7503fa0e93c2bf0de3ac4e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171211
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-29  Eike Rathke  <erack@redhat.com>  [4c3f65ea3b1f2e7f6d92c732f72936fecc017b29]

        Resolves: tdf#159343 Implement TableRef API token conversion
        
        Change-Id: I1b0d9e002d267e62dc7cbbbfc9f5c5c728374345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171165
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [212ffc410aeac602efb2c2bfca3eb2d14a31f490]

        CppunitTest_sw_mailmerge: factour out common code
        
        Change-Id: I82de04eaabc7efd2440c263064f0c074b30473ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171181
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [62992442e44787abd5d2fd14fcac9b46856d11d4]

        Simplify a bit
        
        Change-Id: I0aeb003cd1e1846da729514a39e9190751996fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171167
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [18ed2be7f1406b879c1add35f8f86e68202d0876]

        Prevent rtl::Reference -> css::uno::Reference -> rtl::Reference implicit path
        
        Replace up-casting conversion constructor with respective conversion operator,
        similar to existing css::uno::Reference conversion operator. Thic change will
        not allow code like
        
          rtl::Reference<Foo> foo;
          rtl::Reference<Foo> bar(foo, uno::UNO_QUERY_THROW);
        
        which was possible because compiler could use temporary css::uno::Reference.
        
        Change-Id: I54b79af3e2508b26e9cd59f2cc7e2ae92f6efbbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171166
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c39978f41dccbeb2e973c919a67d9b1d974f8f3c]

        tdf#161846 use unordered_map in SfxItemPropertyMap
        
        with large property maps, even a binary search starts
        showing up, but we can do a O(1) search here by using a map
        
        Change-Id: Ie7916076073e6dd393f0a1fb5a0db1b973999408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171173
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f008bf4b968f219d2fe97ef8175ef6be0555943]

        cid#1554812 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555227 COPY_INSTEAD_OF_MOVE
        cid#1555329 COPY_INSTEAD_OF_MOVE
        cid#1555384 COPY_INSTEAD_OF_MOVE
        cid#1555387 COPY_INSTEAD_OF_MOVE
        cid#1555399 COPY_INSTEAD_OF_MOVE
        cid#1555400 COPY_INSTEAD_OF_MOVE
        cid#1555406 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I85dc45e2686c6b3e8b97a23872cb26416edc27c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171178
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4993539cacdee41b7b10fc0dc14d92b7aee9ae5b]

        cid#1615230 silence Overflowed constant
        
        bogus but lets see if this makes any difference
        
        Change-Id: I7b9a91826eb9fd65e39c0c337e05019c374773a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [847738e5a93f63ead959a7cc60d65fd55737fee7]

        use more GetItemSurrogatesForItem
        
        since it is considerably more efficient
        
        Change-Id: I224ff890f6dd52481621b46f912f1e8dbf65126c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171182
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-29  Oliver Specht  <oliver.specht@cib.de>  [44d129870795da2e370ad5f2f8abc95c5c6873aa]

        Use NDEBUG to show/hide m_bDeleted
        
        "#ifndef NDEBUG" is now always used to hide/show member m_bDeleted
        
        Change-Id: I10f5111cd36e13b8101d2a69ed9268bee622344a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171012
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>

2024-07-29  Jonathan Clark  <jonathan@libreoffice.org>  [89ff0796a812179a56d6802a5397c4f51e0c2e09]

        tdf#162205 sw: Fix incorrect baseline adjust for vertical bidi portions
        
        Bidi portion rendering was performing baseline adjustment twice. This
        caused vertical left-to-right bidi portions to be rendered to the left
        of their proper position.
        
        Change-Id: Ic5258f58d8c8260194ec5ea0921d72f8dd738556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171071
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-29  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [06dec3ba4f508798822b63aeae46e8b0ec6d6d70]

        tdf#158504: fix 'applied' for page styles
        
        Here is how checking for a used page style used to work before 140079362502408c75ceee67e86d779f61c0ac1b:
        - SwDocStyleSheet::IsUsed called SwDoc::IsUsed on the page style
        - ... that used to call GetInfo on the SwPageDesc
        - ... which then called GetInfo on Master, Left, ... (SwFrameFormats)
        - ... which then ends up in a SwPageFrame which confirms the page style
          to be in use
        
        To get this to work again after 140079362502408c75ceee67e86d779f61c0ac1b,
        one would need to reimplement the forwarding in SwFrameFormat (and the
        other intermediates). However, instead of replicating that encapsulation
        breaking maintenance nightmare, we instead:
        - introduce a properly named SwPageDesc::IsUsed
        - which directly calls SwFrameFormat::IsUsed
        - use that in SwDocStyleSheet::IsUsed
        - and then assert in SwDoc::IsUsed if called on random types (as
          essentially most of Writer derives from sw::BroadcastingModify in some
          way)
        
        Change-Id: I4ca300af61a1f2af383ef2b7ded32ddbee6ec975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171088
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-29  Kurt Nordback  <kurt.nordback@protonmail.com>  [37bca7e571b1356b29addeb631066350e03e64ea]

        tdf#161090 - Spec how many / which values are in remainder of-Pie chart
        
        This commit moves bar-of-pie and pie-of-pie chart types into a separate
        line in the chart type selection UI from 'plain' pie chart types. This
        allows for separate UI controls, including a spin button added in this
        commit for of-pie types to specify the number of entries to be included
        in the composite wedge and broken out in the right-hand subchart. Per
        discussion in this and related bugs, this may not be the long-term best
        approach for specifying which entries go into the composite, and it
        still only allows for the last entries in the composite. But it is a
        step towards allowing greater control.
        
        I've also changed the default number in the composite from 3 to 2, to
        better match MSO.
        
        I/O of the 'number in the composite wedge' parameter is not included
        in this commit. Implementing that for ODF and OOXML perhaps should be
        a separate bug or bugs.
        
        Change-Id: If4afc1417ea94c15e86a9a4dfe967a6f8ecb7ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168690
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-29  Michael Stahl  <michael.stahl@allotropia.de>  [ca21cc985d57fffe7c834159b17c095206304994]

        package: ZipFile: check Zip64 end of central directory for consistency
        
        Change-Id: Iae873ec8175922e210398ef8e0f83e148a795c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170783
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2e2581ec85512be2e7df7a81960ac6106676fa72]

        ofz: sc-rtf "ClusterFuzz Unreproducible" reset
        
        so reenable this and bump up min fuzz length
        
        Change-Id: Ia5a8c725aa827c18f68c46077fae020831608395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-29  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [b788be3f380d36f38bb1a0eefade110f40c855b4]

        tdf#85677: fix the vertical panning gesture in Impress
        
        Change-Id: I574f802e5f7de260ecb56032098e60018f2675da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171137
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [82f837102e1efbf979bb139c52d9b60d68eeeae1]

        Consistently name UITest targets
        
        Change-Id: Ibdf28a56f66f9513a3d4abb25cea8176e47da941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171174
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-29  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d7628892b04d1a1ed47d6d6c355940f9915dcd99]

        testtools, uitest, unotest: fix issues found by Ruff linter
        
        Change-Id: I4a848b0f1f114d1262b5242786e088eb50a33cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171145
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac41bc3c908c815cf9725b6316d0537d43401ddb]

        tdf#161846 remove one layout operations (ii)
        
        of the 6 we perform per caption object
        
        Change-Id: Ib062a7cc0b4691ec0badb759893b737f6f2c4a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171171
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-29  Miklos Vajna  <vmiklos@collabora.com>  [84bd222947aeea27cf7705bdde615f5417e57ce4]

        svx: prefix members of SdrUndoObjSetText
        
        See tdf#94879 for motivation.
        
        Change-Id: I414fc94c35dc9caa2619b92eeaa436ad17fae5ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171168
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-29  Alain Romedenne  <alain.romedenne@libreoffice.org>  [088635001acc15e7bba4f8d58874572e7487035e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f68a0232112cfa6a8b2baa298c0282442fc2db2
          - VBA supported objects
            
            Change-Id: Ie2f51790fa25e589a05a8f9a0cf25cc4f891c4c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171038
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-07-29  Weblate  <noreply@documentfoundation.org>  [128a1332d6dc96a21dc4b00f5efa0949a5a38982]

        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.8% (88 of 116 strings)
        
        Change-Id: Ic8de20a48ed2bd6c8756b3158432cba86811577b
        Co-authored-by: SoftInterlingua <softinterlingua@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171103
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-29  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [be5fad6d0755e3d1e7ab5c9d4bfda8248b4e51d2]

        tdf#161875 buffer NameOrIndex Items for fast Surrogates
        
        Problem is that collecting the Items using the ItemSets and
        PoolItemHolders is too expensive when used too often. For
        read-only access it is okay to have the Items directly
        registerd (for write access we *need* the ItemSets and
        PoolItemHolders, see iterateItemSurrogates).
        This is limited to Items which need to support surrogates,
        but can further be limited to the here critical ones - the
        ones derived from NameOrIndex.
        This is done here by checking if the Item is a NameOrIndex
        based one by adding a bool to the item that gets set in the
        NameOrIndex constructor. If needed this can be changed,
        e.g. by using besides the SFX_ITEMINFOFLAG_SUPPORT_SURROGATE
        another flag signaling this.
        Since only Items that are currently held by an ItemSet or a
        PoolItemHolder get registered it is not necessary to change
        the Item's RefCount in any way, doing that may lead (again,
        we had that with directly set Items at the Pool in the past)
        to long-living Items that only get cleaned-up when the pool/
        document gets destructed.
        This buffering is now SfxItemType-based, no longer using the
        WhichID, so the result needs to be checked for WhichID
        additionally - if needed (?).
        All in all it's anyways a compromize, every usage of the
        surrogate mechanism is a 'hack' in the sense that for lazy
        reasons not the model data is traversed directly, but assumed
        that all Items set at a pool/model *are* model/document data
        (what is not always true).
        
        CheckNamedItem does not need to be static, changed that.
        Also all accesses to maRegisteredNameOrIndex *have* to
        work on the MasterPool instance, same as buffered ItemSets
        or PoolItemHolders, corrected that, too.
        
        Number of instances in the buffer need to be counted, else
        an instance will be removed too early: The same instance
        of an Item can be referenced by multiple sets/holders,
        so the first remove from the buffer would already remove
        even when the Item is referenced multiple times. Added
        that.
        
        Added more asserts & made sure that all constructors/
        destructors of SfxItemSet do take care of registering
        Items for the surrogate mechanism as needed.
        
        Change-Id: Ib33e7f0bd4abd32a3bb68278f33b0abb9a4754c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171084
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-28  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [46f7dcc5f499892ef093147b3f739c258bbf6b81]

        related tdf#115474: improve warning msg for slow autoformat
        
        Perhaps this alerts users that they've unintentionally selected a very
        large range (Ctrl-A vs. Ctrl-End for selecting content)?
        
        Change-Id: I8d60cf6186d1faf94c58684cad2ead49381819d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170995
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d01dcab81a6a66fd5b4448ccff348f69c82c538d]

        Related: tdf#162072 compare fallback to what "serif" resolves to
        
        instead of assuming that the resolved serif font will have
        serif in its name.
        
        Change-Id: I3f85e2a8abd1dbf851debec9196e55d5c2da4e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171144
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8fddfdde9291cdb7db9912e86b59dc11624dedb]

        ofz: Null-dereference READ
        
        Change-Id: I872cd2b0c32f88a5ac09ea3082f05b7d3c41feb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171141
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [221e3fb4afe662a040479494b6789325bc9155db]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to eff9495b70722d8e590e97b1710cfc7c00f6ce72
          - Lightproof: undo some import order changes advised by Ruff linter
            
            Change-Id: Iec2b9a1ed9bf2f9a41dc098fcf6ee8026917e3a3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/171140
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [046a3f5d879d489affdb3ae98329020db209dc6a]

        crashtesting: fix ImplCalcMapResolution assert
        
        seen on converting moz1297206-1.svg to odg
        
        Change-Id: I56c424eb76f55a52522d519a0faa6df30b017c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171142
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [329e913b0b82875a9f2f427cf1fae9e7f90b021a]

        cid#1556624 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556622 COPY_INSTEAD_OF_MOVE
        cid#1556629 COPY_INSTEAD_OF_MOVE
        cid#1556632 COPY_INSTEAD_OF_MOVE
        cid#1556634 COPY_INSTEAD_OF_MOVE
        cid#1556642 COPY_INSTEAD_OF_MOVE
        cid#1556644 COPY_INSTEAD_OF_MOVE
        cid#1556663 COPY_INSTEAD_OF_MOVE
        cid#1556674 COPY_INSTEAD_OF_MOVE
        cid#1556682 COPY_INSTEAD_OF_MOVE
        cid#1556683 COPY_INSTEAD_OF_MOVE
        cid#1556685 COPY_INSTEAD_OF_MOVE
        cid#1556694 COPY_INSTEAD_OF_MOVE
        cid#1556708 COPY_INSTEAD_OF_MOVE
        cid#1556711 COPY_INSTEAD_OF_MOVE
        cid#1556712 COPY_INSTEAD_OF_MOVE
        cid#1556714 COPY_INSTEAD_OF_MOVE
        cid#1556719 COPY_INSTEAD_OF_MOVE
        cid#1556727 COPY_INSTEAD_OF_MOVE
        cid#1556744 COPY_INSTEAD_OF_MOVE
        cid#1556757 COPY_INSTEAD_OF_MOVE
        cid#1556782 COPY_INSTEAD_OF_MOVE
        cid#1556784 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5d5bc884cd7351a81c18b35aaf4e304256242988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171128
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-28  Michael Meeks  <michael.meeks@collabora.com>  [b707ca9651a3d1b679b81b7d2aec1baf3d596090]

        cool#9082 - lok: cleanup WakeUpThread before forking, then re-start.
        
        It seems likely that this lingering briefly after various un-identified
        and tough to reproduce, longer running operations in calc - which is a
        big ScProgress user - caused problems with background save.
        
        Change-Id: I1d0ec56c759dff30c48c8562b6400b57be4a25b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168033
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168052
        Tested-by: Jenkins

2024-07-28  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [c658efe24f7a7eb4234c1c64668ea115788272e7]

        tdf#158510 Don't change the initial URL when using fallback
        
        The current aURL conversions in the file "unoshap4.cxx"
        result in the URL obtained when importing the file being replaced with a
        new one formed from the presentation directory and file name.
        As a result, the model changes and saving is requested
        even if no changes were made to the presentation.
        
        To fix this problem, we added saving the
        presentation directory URL into the context for
        transfer from SlideImpl to ViewMediaShape.
        
        Regression after: fe897b36aef28dfe175461c43614e22588fcfd84
        
        Change-Id: Ifda8610d0a4874ffa17e759fd45ddbbd2f934c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170528
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [78090581d246cd391d99575680b5b8f8d9de7840]

        restore WakeUpThread::joinThread
        
        removed with:
        
        commit 4aa2cc878dae3b34b16ccacd9358fda5e6d6a197
            loplugin:unusedmethods
        
        Change-Id: Ie6006defdfdab23aef0fa9d9b66b125862b760f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [21250dc9c5787d9274837b2bf39c32c2627e44b4]

        ofz#68339 Timeout
        
        ofz took the reduction in size limit to 256 bytes as a challenge so
        produced a hang with a 187 byte testcase
        
        Change-Id: Ia9a93e6fd846127be2f842949f4338e819432ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [dffa7b7d0b6553a5b37081cd164d3ffc0b215040]

        sfx2, solenv, sw: fix issues found by Ruff linter
        
        Change-Id: Iab375e8c8aa4c4915f3c70a9ef6aede268e4619f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171138
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [85511e27d259d6b19cc6c463fc06368c14511bb8]

        Resolves: tdf#160509 use BorderWindow client for dialog parent
        
        the BorderWindow has no ultimate SystemWindow parent so dialogs
        using this as a parent end up automatically picking a parent
        of whatever happens to be in the foreground and not the intended
        associated frame
        
        Change-Id: I713e3c40b0cad934b978ba0b1b46a3c6064be24f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171104
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [c371b9a708fb1dd1fc0b6d9359bc41685eb26d61]

        sd: fix issues found by Ruff linter
        
        Change-Id: I96dae5eca3bb493500ca1145e141371a5572e29e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171134
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [fac23917fcc6b8846c5cf1e6f88c03e74e332f9e]

        tdf#68676 Fix textual data length sent to SQLBindCol
        
        The problem was that using Access ODBC drivers, text fields couldn't
        be set after commit 5ed1415d1cf03a3d671ebd11582dfaa90f1168bd (tdf#68676,
        tdf#131238: implement and use Unicode ODBC functions on Windows). I had
        changed the length sent to the function from SQL_NTS into the actual
        string length; and that caused the problem. Restoring previous behavior.
        
        Change-Id: I9ea1f33f30505232a02d42e3182d5449fc8d8f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171135
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd0f7e66b88d4f58c7068057eeb9f87624043427]

        Fix typo
        
        Change-Id: I7a135a47e5bdbbf37a08f7e876a0ed1d979d4c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171131
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c2d132af3d41da9694b5aaccb27d5923e6241703]

        Remove duplicated include
        
        Change-Id: Ic50852db74fd6e3b227875932b730e077efbe709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171130
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [233af54afb6e493c3538efe7c93d0f53f1b4c3ab]

        tdf#162219: pass correct DecimalDigits value to SQLBindParameter
        
        ... when setting DECIMAL / NUMERIC.
        
        Passing 'scale' from setObjectWithInfo to SQLBindParameter was wrong
        anyway: in setObjectWithInfo, the scale is needed if it converts the
        object 'x' to the requested format before sending to the database.
        
        In this case, it mismatched with the actual count of decimals in the
        string sent to ODBC: it could be "1" or "1.2"; but 'scale' is always
        equal to the scale of the parameter in the database (4 in the bugdoc),
        which resulted in the error returned by driver.
        
        Note that there is code that truncates excessive decimals - it is in
        OKeySet::impl_convertValue_throw, implemented for i#106772; it would
        be best to remove that code, and let the database do its magic: e.g.,
        passing a string like "1.99999" to a DECIMAL(19,4) field in MS SQL
        Server would round it to 2, while our code truncates it to 1.9999.
        The ODBC driver can handle more digits itself. But that isn't in the
        scope here, and may need to tweak other database connectors.
        
        Change-Id: Ib50c6d78bfd0cbf5ecd59f46f300107076ec0037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5373679b695e5bd4f68fe4554234dd9facc3e54f]

        sc: fix issues found by Ruff linter
        
        Change-Id: I6710db13549c42e9ae7231e0434a26b6357083e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171102
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [2c3bf9471d779ea40112a3ae70eec40eaf57cf6f]

        odk, oox, pyuno: fix issues found by Ruff linter
        
        Change-Id: I79d56453877a10502768b522ca93da3990891c0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171098
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4d18fa7694bae0b3d4364aa3072216782b7a5f26]

        In embindtest, also test Any included in Struct
        
        Change-Id: Id268692c750873629c1ceaf232e1e61912164872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171078
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [64da0afacf13bc5b1a294f90d5c1cc305d43d28f]

        tdf#162227: use strict order of evaluations accessing columns
        
        ODBC SQLGetData requires that data must be retrieved in increasing
        column number order, unless the driver supports SQL_GD_ANY_ORDER extension (see
        https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgetdata-function).
        We can't emplace_back(getString(4), getInt(5), ..., getString(12), getInt(17)),
        because MSVC would reorder calls into getInt(17) -> getString(12) -> ..., and then
        MS SQL Server ODBC driver will give error on access of column 12 after column 17.
        
        This partially reverts commit e8248b5e4b19df8ba469d1ca3a762960c1a053b5 "cid#1545222
        COPY_INSTEAD_OF_MOVE", 2023-12-19.
        
        Change-Id: I9bf53086e526c886c4794af51a60e61d4cce89ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171097
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [1a05155f51bb8891d98d936cc7b4e9160e36cc4d]

        Change some string types to avoid unnecessary allocations
        
        Change-Id: I45a12adb0d04ea2e048816203a6439692c2372b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171093
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [558b20d1acc553f4ffc4361e74e1b955b98a661d]

        comphelper, msicreator, odk: fix issues found by Ruff linter
        
        Change-Id: I5ef65baeb0100b9d70b5c59c1d5f6f43ab951a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171092
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [5ed1415d1cf03a3d671ebd11582dfaa90f1168bd]

        tdf#68676, tdf#131238: implement and use Unicode ODBC functions on Windows
        
        It also prepares for using it on other platforms as well; the code is
        generic, and should work with 32-bit SQLWCHAR, too. But I can't test
        it, so it is not enabled on other platforms for now (see bUseWChar,
        which was moved to connectivity/source/inc/odbc/OTools.hxx).
        
        Change-Id: I29fe117910bbab62aba37e85dd27d65a742d28c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171081
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [abb0ec365b82982154fda661538c5b31b37c104a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 54a753654845ecd253d7af7693bbcfbc9d952716
          - Fix issues found by Ruff linter
            
            Change-Id: I0517a69b52e9f5b3da2648e82e63bc35a48e3e99
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/171091
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-07-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [656c48d4a2b444ccceed18c0dc09664c8cf46213]

        cui, dbaccess, desktop, external, filter, librelogo: fix issues found by
        
        Ruff linter
        
        Change-Id: I34df4c10520406a2b9d2d8f3487f877698a324f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171090
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c5ae132faf03d451d6a041d822b97b9a1c04d9a]

        sw: use calcLayout() everywhere
        
        Change-Id: Ie03a3f13808456c831db10f2203fbfb84a50b999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171076
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-27  Patrick Luby  <guibmacdev@gmail.com>  [b147debad0cb980317c6915382a12f8dfcef6dfb]

        tdf#162190 handle Command-w
        
        On macOS, Command-w should attempt to close the key window.
        
        Also, pressing Command-m would fail to close the key window
        due to the same cause as tdf#162010 if the resulting key
        event was an input method event.
        
        Change-Id: I0d90547d7a0833bcc18b36f6d888e1065e91ec57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171086
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [4be345abd678babcbb989db1e7a16021ad1da562]

        HTML/ReqIF export: introduce RelativeOwnObjectURL filter option
        
        When the use cases require use of absolute URLs at export (Options->
        Load/Save->General, Save URLs relative to file system and Save URLs
        relative to internet), the fles generated from the document itself
        (e.g., images that aren't embedded into HTML/ReqIF itself) may still
        need to be referenced relatively.
        
        This introduces the export filter option, named RelativeOwnObjectURL,
        that overrides the general export settings specifically for these
        self-generated objects.
        
        Change-Id: I09aeb931db5712271a40c683370316783507775a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171083
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-27  Eike Rathke  <erack@redhat.com>  [0b683547bbb22cab46e92dfd65c129630bd9ca94]

        Related: tdf#159343 Handle TableRef separator in brackets for Function Wizard
        
        ... not breaking to next argument of a function parameter.
        
        Change-Id: Ibc7a64c4ea64c415098a213f0ff3d96b8a9dd73c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171085
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-07-26  Mike Kaganski  <mike.kaganski@collabora.com>  [ed2d890d69b64c8f1f19914ef75fa8dcf08e6cbc]

        Refactor ODBC functions code for clarity
        
        Change-Id: I5f3de97fc178b11c82655f65435c637fdff65e99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171080
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-26  Mike Kaganski  <mike.kaganski@collabora.com>  [bb48e26c9256fcf33938c66447e91987135a4ea7]

        HTML/ReqIF export: make sure to close input tags
        
        Change-Id: If550cb3765f6f3eb6fbf7425061c1cec90f5470f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171082
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c91c190379f727f2a98bbdf6e7c0846b830433a4]

        Fix --with-package-format=emscripten
        
        For one, a dependency on gb_Postprocess_get_target,AllModulesButInstsetNative
        was missing, so copying from instdir might have kicked in too early, before the
        instdir files had been updated (e.g., in an incremental build).  For another, in
        a from-scratch build, files like instdir/program/qt_soffice.html might not yet
        have been around, but I'm too dumb to get gbuild to do what I want here (i.e.,
        copy files from instdir to workdir once the files are available in instdir and
        only if the files in instdir are newer than those in workdir).  So just make
        this .PHONY and always copy all the files (in line with how other PKGFORMATs
        also always rebuild their artifacts, IIUC).
        
        Change-Id: I8b84677cdf867a2b66027ec4a4d781cd1fe623b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171077
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [71e29326d20448a96faa8c2437d91a422d7db66d]

        fix enabled-mergelibs-more build
        
        DocumentToGraphicRenderer is needed by sw/qa/ unit tests now
        
        Change-Id: Idf1aac26afa0001a8affc846b78288a6b588a1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171073
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [80a69f6780c899df0443abd7e49a68c203378fac]

        CppunitTest_vcl_pdfexport2: simplify a bit
        
        TaggedPDF is enabled by default since 544d6d781b3c8aa108ced362d708693b5127f3d7
        "tdf#39667 Enable tagged PDF by default"
        Only disable it when needed
        
        OTOH, using writer_pdf_Export as a FilterName works when
        exporting calc/impress/draw documents too
        
        Change-Id: I970406b8a87cad937c3023815e4f5caa9b4f7143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171069
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-26  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [c5823a2e276a26194aec82297bade6648626b690]

        android, compilerplugins: fix issues found by Ruff linter
        
        Change-Id: Idab013bf2ff1f274a07911ec8b545cd26142139c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171050
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e598ba08311adaaaad5b9ea2b4279102ff0f379]

        CppunitTest_sc_uicalc: Test pasting with return key
        
        Initially this test was created to test tdf#161461
        but it needs some tweaks in order to reproduce it
        See https://gerrit.libreoffice.org/c/core/+/169341/comment/7c8fc703_8d6797d5/
        So at least add this test to test the paste with
        return key feature on Calc
        
        Change-Id: Ie3ae0975fa164fbf4c1d249649ab25cf0eeef0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169341
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [7274fcf957314d4c3fffb02fb8bd156835df0510]

        tdf#162087: sc_uicalc: Add unittest
        
        Change-Id: Iafac32e5bfd02665c75b109fa136ff9d700bc93c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171074
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f6fd656c72027adb1459ca4f10f284f314c7562b]

        ofz: ww2 "ClusterFuzz Unreproducible" reset
        
        so reenable this and bump up min fuzz length
        
        Change-Id: Ic493e1a55899761f6bc88dc7f4b598a82dd00411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Kira Tubo  <kira.tubo@gmail.com>  [5f001eb9ceaff1398a65e21ed3fff4aba2450149]

        tdf#139631: sw unit test: cut preceding space w/ redline
        
        Test to see if preceding space is cut when cutting a word with redline
        turned on.
        
        Without the fix from tdf#139631, the preceding space is not cut in certain
        situations.
        
        Change-Id: Ic815fd04ee50ce116a8552205c24e8422d734b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171058
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a961b522a82d41a0a3cd09b7fbb9bde6b79f3d8]

        sw: use SAL_RET_MAYBENULL in GetTableBox()
        
        This could have caught tdf#162180
        
        Change-Id: I71e86b402ae0c603d1c7ace209d55f5808b9ebe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171054
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5133fb0416a98ff727747e873fbb508c5ac3168]

        CppunitTest_vcl_pdfexport: simplify a bit
        
        TaggedPDF is enabled by default since 544d6d781b3c8aa108ced362d708693b5127f3d7
        "tdf#39667 Enable tagged PDF by default"
        
        OTOH, using writer_pdf_Export as a FilterName works when
        exporting calc/impress/draw documents too
        
        Change-Id: I5dc0c9eedbb6716f1ef58ffd1faa16e9cc015f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171070
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-26  Alain Romedenne  <alain.romedenne@libreoffice.org>  [0f12a330af9f317742238fe11d6cbc99bd270b07]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80cfa06de7bb382c30ead55837378dcd568d2e30
          - tdf#161883 Fix to IF Basic statement syntax diagram
            
            Change-Id: Idcd12d05cd424360cd29bbb7cd7ee73e766bef52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171025
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e03fced7ce1a3c45e8e48090373f85cc11c1fad]

        fix in some missing SfxItemTypes
        
        Change-Id: I7dcb9768a8cd63200b8f8c50d8170e78ff5aeec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171068
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-26  Pierre F  <fpy@bger.ch>  [8cfb92737336200ac31be358d2f757a6e779b6a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 56220af4577d0f685ca40595f7f57254f92628c4
          - adjust FACT. tdf#162044
            
            Change-Id: I605283ca535de89fb4d7dbce9d9f7751301fc054
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170956
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-26  Julien Nabet  <serval2412@yahoo.fr>  [fef3a69df76b2f7527a9280b5b408370977b72f8]

        tdf#162136: fix crash when formatting data series in Histogram chart
        
        Change-Id: Idc05b82363eca3066b291f05a7e05be4996d28a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171065
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [92986f8e0433d8d61a7ac9bc9f8a56863785cd5b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 6d1d800bd75a27d84866b7e8931d0cb1e12dbdd3
          - update translations for 24.8.0 rc2/master
            
            and force-fix errors using pocheck
            
            Change-Id: Ic1ff9c85e537794ed5410c93b09f5d8b1d8a1e9f
            
2024-07-26  Michael Meeks  <michael.meeks@collabora.com>  [f9df8d71a9d4ad2e7bc2e221551d9ee007f9fc60]

        lok: join Webdav Ticker thread.
        
        Add 'startThreads' lok method for the few thread scenarios where
        we need to have a background thread running that cannot be started
        opportunistically.
        
        Also add that to the ThreadJoinable interface so we can get into
        UNO components' implementations to handle their worker threads
        easily.
        
        Implement joining and re-starting in WebDAV ucp too.
        
        Change-Id: I329ef9decb32b263197e4c03a0d54952985fdd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167858
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170979
        Tested-by: Jenkins

2024-07-26  Fridrich Štrba  <fridrich.strba@bluewin.ch>  [dbfa56584cac08cae733513c13803a9c6ece22f6]

        Fix build with Java 8
        
        Unlike later versions of Java, JDK 8 does not create the last
        directory segment pointed by the -d option, even if the other
        segments exist. So, create the "content" segment too and allow
        building with Java 8.
        
        Change-Id: Ie7ee75ca311270e02a3e1b6b5eeb28b5a1ccdad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169477
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7d5c62537cce395fb46aac9403d42b1597c8186d]

        Add --with-package-format=emscripten
        
        ...to have $(WORKDIR)/installation/LibreOffice/emscripten populated with just
        the relevant files from $(INSTDIR).  (This doesn't reuse the complicated
        CustomTarget_instsetoo_native/install used for other PKGFORMATs; as a special
        case, it uses a much simpler CustomTarget_instsetoo_native/emscripten-install.)
        
        Change-Id: I9c7509aadbc0e6e49ec95bf51c748c2ff9f778b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171066
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e571123891968b60333ef161e68e2d45ccc25a94]

        cid#1557746 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557751 COPY_INSTEAD_OF_MOVE
        cid#1557771 COPY_INSTEAD_OF_MOVE
        cid#1557775 COPY_INSTEAD_OF_MOVE
        cid#1557786 COPY_INSTEAD_OF_MOVE
        cid#1557787 COPY_INSTEAD_OF_MOVE
        cid#1557790 COPY_INSTEAD_OF_MOVE
        cid#1557793 COPY_INSTEAD_OF_MOVE
        cid#1557794 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I1b02b6eca303b1a08975ea8aae7c9dbefbada47f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171061
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a79f9a79329fa0cbb385c6f9995ae113fa9b4c55]

        Delegate match to main internal starts/endsWith*
        
        This simplifies and deduplicates the code, and even where it was simple,
        it has an advantage that if a change in algorithm is decided, it is done
        in a single place.
        
        Change-Id: I9ec55a29c5f2b2c972ac81bf07c20fc0a52a2a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171033
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fa10be85d2ae4b8198979c4c1024fe43e2e8e4be]

        cid#1607270 silence Overflowed integer argument
        
        lets see if this works instead.
        
        Change-Id: Ib0a5df7deed2972cfed7c3afbe5c65229c208f26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171056
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19a73f096a76dd3b650e1f0849dbd42424c50d5b]

        ofz#70674 Null-dereference READ
        
        xCursorTunnel.get() is a SvxUnoTextCursor in this case
        
        Change-Id: Iaa50a4895923bc1635dc69325203de7bfb77886b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6148e1a0e01eac6159a6ce618f30975569dc5c94]

        Looks like Emscripten LO doesn't need explicit --norestore --nologo
        
        ...mostly because the relevant parts of the code are hard-disabled (even if you
        would --disable-wasm-strip) with ENABLE_WASM_STRIP_RECOVERYUI=TRUE and
        ENABLE_WASM_STRIP_SPLASH=TRUE.  (And if there are places in the code that would
        need the equivalent of either --norestore or --nologo after all, we could
        probably better add explicit #if EMSCRIPTEN there instead.)  This allows to get
        rid of hard-coding the Qt Emscripten LO command line arguments, which means that
        e.g. web applications embedding LO would now be able to specify them themselves.
        
        Change-Id: I8e2dcfd170cc32276bfb9007f098f6ae6a7f9ec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171063
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6ea2464edbe3df1282fa96aeb6c53770dbc04860]

        Bump minimum emsdk to known-good 3.1.46
        
        ...as 3.1.3 has compilation issues with our code now, see
        <https://git.libreoffice.org/lode/+/197e973f8ce3ba8495f9c0c7baa5695335b39e13%5E%21>
        "update emsdk to known-good 3.1.46 to avoid clang segfault"
        
        Change-Id: Id500cdde2f776eaaedcc1bcbd43c5b3c727eef2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171017
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-26  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [4461173a4d0dff82e6223bdc1376230a9cd6b1cc]

        CairoSDPR: Support direct transparency for gradients
        
        FillGradientPrimitive2D/ and PolyPolygonGradientPrimitive2D
        now support both alphas, a gradientAlpha and a unified one.
        This allows a processor to directly handle a gradient with
        a unifiedAlpha if he wants. Adapted other places accordingly.
        
        NOTE: In VclMetafileProcessor2D handling of the primitive
        PolyPolygonGradientPrimitive2D has to do a local compromize,
        see comment there.
        
        Change-Id: I536f4935dafde0369f768dbd281d547b7bb08eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171052
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a9ae694832202bec6c966a1ec8015c1ae215908]

        tools#1608074 silence Overflowed return value
        
        Change-Id: Id1db2d006a82e08e6e011be5c5fcfa515381ad44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171060
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8da216bb4b40f285317247a2c2d8bd1076c332cd]

        cid#1608367 silence Overflowed return value
        
        Change-Id: I842a64e70814bfed4c04d25734a8b43dca85ca15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171059
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1eb3b00c827dbfd606cbe482a2dde4c03d928c39]

        cid#1608295 silence Untrusted loop bound
        
        Change-Id: I925f4a73118fbf81a48b32a096bdddf194148120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171057
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1df4e4be8c991a87c41018c0686cdad95aa8d1b8]

        cid#1615138 Use of auto that causes a copy
        
        Change-Id: I5752fa3aa4bd67401194dc88aa8bf7b8d8e485c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171055
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [07e0c5d7bede25776f2e118715e07c6071baf21e]

        Fix typos
        
        Change-Id: I52c4ca5b90ad60c971d713c235d84d7e52a59953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171048
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-25  Eike Rathke  <erack@redhat.com>  [dc9486f2443fa52588b625c0a2a288bff56a7a45]

        Resolves: tdf#162087 FormulaCompiler::OpCodeMap::maHashMap must be uppercase
        
        which is the case for all English function names, but not the
        TableRef item specifiers like #All, #Data, ...
        
        Change-Id: I7f675e05b0d52eac9596b96b4d2cf299351fb82a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171022
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-07-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c671e999f8b84c15d012dbfcf37b3a54acd26cba]

        fix pid_t type mismatch on win64 between libassuan and gpgmepp
        
        typedef long long pid_t in case of #ifdef _WIN64 is the only change,
        the rest of the change to the patch is just rediffing
        
        Change-Id: Iaad34bf42ad06fc6a636b773535f199a19c863e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171023
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-25  Mike Kaganski  <mike.kaganski@collabora.com>  [9b911aaa3d2c7258fd41a896b7d57ca8c2a476fb]

        tdf#124213: handle private URLs as non-remote
        
        Since commit 26c106a5aeca3e50d1e3c3d37e622b2743a23bca "append '(Remote)'
        in the titlebar when remote file is opened", 2015-08-14, the titlebar
        shows "(remote)" for documents with non-empty URLs that are not file
        scheme.
        
        When recovering a non-existing document, the URL is a factory one like
        "private:factory/swriter"; and INetURLObject::GetProtocol() call returns
        PrivSoffice.
        
        Indeed, recovery of a non-existing document doesn't make sense itself,
        and is fixed by Justin elsewhere; but let's fix the general logic here.
        
        Change-Id: Ibaf095981c37a2fd64f745ad0966465d98a4ed4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171027
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ac175a43c95457129c418ae0efb9cbe5f32f9ee5]

        Add a toDelete parameter to Module.throwUnoException
        
        ...as there can be situations (cf. the newly added test code in embindtest.js)
        where objects that need to be deleted are passed as payload of the exception
        value to be thrown.  So there now is a (mandatory, as Embind doesn't allow to
        implicitly pass undefined) third parameter now that must be an array of objects
        on which to call .delete().
        
        (75fe059974dcb80c3f78110c73ab799afc6f4ca3 "Embind: throwUnoException from JS"
        had deliberately made throwUnoException take two arguments, because if it
        "directly took a css::uno::Any argument, JS client code would need to create one
        with `new Module.uno_Any(...)` and call .delete() on it, but there is no place
        where it could call .delete()".  There now would be such a place, but it would
        probably still be tedious most of the time to explicitly construct a new uno_Any
        to pass into throwUnoException both as the exception and in the toDelete array.
        So keep that design decision to have throwUnoException take individual type and
        value arguments.)
        
        Change-Id: Idec029d9e500457b02d20d899b9a2328cd7a5d7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171024
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [532a8d7ac217b4adae2d091013b745db87a23760]

        CppunitTest_xmlsecurity_signing: simplify a bit
        
        Change-Id: I197e37f6520644c594baa6936d831ea456d60f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171051
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4b4abd2ffb94380fe0b4f1d2192f1c920089e465]

        Fix typo
        
        Change-Id: I44d09c767b1037503b187711965c72fefea1039b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171047
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-07-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [145c606d01e0ee673dee69271477155fef6aa81b]

        tdf#162180: GetTableBox might return nullptr
        
        Change-Id: I31091b5bd06ba30a2e9bbddad66c5c597b22a6fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171007
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [94b8f312528d2e7737381a957399c97eed81b5c1]

        CppunitTest_sw_htmlexport: simplify a bit
        
        Change-Id: I7091c59583b7fadd5504567c4dcadde844b02b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171049
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [9471fce06e996e4433a8000ead704fda91588d1d]

        bin: fix issues found by Ruff linter
        
        Change-Id: I44e546defb278bb5217ed028dcaebc9fb2d23f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171020
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6f3a37d074440d29048239bc9cc0175d90f51d9f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cae074ae04dab3236f79dd34fc286af2da23060e
          - Fix typo
            
            Change-Id: I8cecd6cd928829e135e8f22f2d1451c4518e4418
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171046
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-07-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa5a10016b1d78c4913775ac8990cebe48f1e38e]

        tdf#162093: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: Ib936cdb890cff18b6fac37ebbdd781c4aacc1986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171013
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dd332f72ce68d2a6109e390b8e45e84143d10960]

        Enable start center in Emscripten build
        
        ...and let it open with that instead of with a hard-coded example.odt.  (But
        keep that example.odt in CustomTarget,static_emscripten_fs_image and adapt the
        example code in static/README.wasm.md to explicitly load it now.)
        
        Change-Id: Ie43e3795e44542acba5a8e755f65acc56fa753f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171019
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [33ea719d6c6ad23dfca088853d95d5688782da2d]

        tdf#157233 - A11y: Add global Accessibility check options for
        
        managing which a11y issue should be checked. In default mode all the a11y issues are checked.
        
        Change-Id: Ib01e7d76e74b0b9cc9df259295edbee135b1c8a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170324
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-07-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [19c6fe6463e9c21be6ad876b26904ab9ec06f891]

        sw: C6011: Dereferencing NULL pointer 'pVSh'
        
        Change-Id: Ife344c9d88a68abb784b094152c4c3f9d8ce271d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171016
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-25  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [125752096bf00069b329217ec61464ec8224c9b3]

        CairoSDPR: Added more care to TransparencyGradient
        
        In VclMetafileProcessor2D for handling the
        PolyPolygonGradientPrimitive2D the case that is may have
        now a alphaGradient has to be handled with more care for
        adding a gradient itself and also for added SVG information,
        see BGRAD_SEQ_BEGIN stuff
        
        Change-Id: Ifab5ec9581a5e400549189a5a41190a91c0cb4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171009
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-25  Ashok  <ashokemailat@yahoo.com>  [44522c38eca2955d2728dd7f0c433dcabb729f3b]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I4d29ac20dc56b32d394beada19f7f1d8f99d22ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170985
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-25  Patrick Luby  <guibmacdev@gmail.com>  [3c30273d72e1cb6ff6cc1d9afd464ab927e16459]

        tdf#67919 access toolbar button dropdown menu from macOS VoiceOver
        
        The fix was copied from the following NeoOffice source code files which
        are licensed under the Mozilla Public License, v. 2.0:
        
        https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/accessibility/source/standard/vclxaccessibletoolboxitem.cxx
        https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/include/vcl/toolbox.hxx
        https://github.com/neooffice/NeoOffice/blob/NeoOffice-2022_7/vcl/source/window/toolbox.cxx
        
        Change-Id: Ibd24c6df4ecd7fdac1c56763d1daec09936a9b31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170426
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [be1b9f955be3bf1f207967b4590e4b66450b275c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff6b674fc9034f2f70f78159c0bb16924d8ff2c1
          - helpers: fix issues found by Ruff linter
            
            Change-Id: I0fd932259a79bef030d6450a2770cb28c4c840b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171015
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [79d74f036f65dcf128fb9b967b345a9009028f53]

        libassuan: upgrade to 3.0.1
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libassuan/libassuan-3.0.1.tar.bz2
        
        Change-Id: Ie56dd4d88998c6b2a825a502aa34bae3436d2b25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169198
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-07-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5fc6ef5990fa66982a3803916f32f7aa8d7f9692]

        bin: fix issues found by Ruff linter
        
        Change-Id: Ic81d21a90059f5db87543c8ce2abb8007f278f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171008
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8ee0b01f226665c877d5ed59b23eec278800a667]

        workaround clang-14 bug
        
        affects both macOS XCode 14 as well as the em++ / emsdk clang 14 used by
        the wasm builder
        
        Change-Id: Id3e9a923b7f18ca8d18fd4bc2fd5de83ab3c591f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169031
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-07-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bba1193359fd9191bb0e3cdb82cf8911692d675f]

        workaround segfault in compiler on macos-clang-intel
        
        XCode 14 seems to be allergic to the string-literal in this lambda
        expression
        
        Change-Id: I1de59883923352c7aa83cc81adafb0218432381a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169030
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e6d98900a9b035e616083416302759a28acdeb26]

        -Werror,-Wunused-variable
        
        ...in code newly introduced in 62974cf6a8148377091cb709e7e00dacac152093
        "tdf#158661 docx import plaintext sdt: remove unnecessary goRight"
        
        Change-Id: I8d05c4936cdf17d2c819f8ab93ddab3ba6bfdc61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171005
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-25  Jonathan Clark  <jonathan@libreoffice.org>  [04184aa7e3aada8f4d938d20dfdb54b3a7dd3896]

        tdf#157829 sw: Implemented line break underflow for bidi portions
        
        Previously, bidi portions did not handle underflow in word wrapping.
        This caused bidi portions to break at format changes during wrapping,
        instead of backtracking to a valid break opportunity.
        
        Change-Id: Ib86effe2642a9d133242c28538026d9b4a7e90e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171006
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33629ff9348a0df88c11257a3921129df4875238]

        force max len for some oss-fuzz fuzzers
        
        on a temp basis to reset auto-reporting state
        
        Change-Id: I2af7bc6b1e6c2d92ce58f548a28dc76fb0584432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171002
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [1bbcc3fdf312971ffb681b332f47369739d95dde]

        O[U]String overloads that return view for rest parameter
        
        Add new overloads to OUString methods that have a
        "OUString* rest" style parameter.
        
        Instead return a view, which does not require allocation.
        
        To avoid overload ambiguity, split the methods into
        different variants that do not use default parameters.
        
        Change-Id: I1aa366115750f1f7ea4fe665804195f59f7c4b69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167632
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b84ef4d67eaf9f9fd7fd700ca05339cb0cdff742]

        Adapt comphelper::ThreadPool to Emscripten's threading needs
        
        ...by keeping the worker threads around by default instead of joining and later
        re-spawning them; see 5b1df7709d75c6dd993da5a272e7e37e55a70174 "Document the
        Emscripten threads issue".  But lets be cautious and change the bJoin default
        only for Emscripten.
        
        Also, cap the thread pool size to MAX_CONCURRENCY=4 and increase to
        -sPTHREAD_POOL_SIZE=6.  In an experimental setup where the Emscripten build
        starts up with the start center rather than a Writer document, that is just
        enough to cover the thread-spawning needs when executing the start center
        window's paint task:  Four threads for the comphelper::ThreadPool (used from
        within drawinglayer::convertToBitmapEx -> ... ->
        BitmapBasicMorphologyFilter::filter), and one each for
        configmgr::Components::WriteThread (see e8358d0a0f7c2c4b1ccf800fe9ec8a7f2bf7066a
        "Keep around a single configmgr::Components::WriteThread instance") and
        salhelper::TimerManager.
        
        Change-Id: I5b1d0e9dc09f05fb3b679c8dc1c38ee45c61c0f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171004
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b6390290fcfdea882fde93facef00ac33dd8b88]

        cid#1557678 Check of thread-shared field evades lock acquisition
        
        and
        
        cid#1556287 Check of thread-shared field evades lock acquisition
        
        (1) std::mutex can be initialised at load time, since it is a
        single-word object, i.e. no need to use a static function local.
        (2) std::mutex is really fast, so no need to use tricky double-checked
        locking
        
        Change-Id: Ieb2239908204baaaccfe9d1e0e2c8ed369d108fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-25  Regina Henschel  <rb.henschel@t-online.de>  [4aa2d5ede17ddf7345804deb200983367990a7e2]

        Related: tdf#162093 TableRef item specifier may occur standalone
        
        also in lexical canner.
        
        Change-Id: Ic265bbd8a0d9baa81039b8d1748c63ad6686bfc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170989
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ebada44e9bac76d6ccbdc387ed673d938830bfd0]

        Read of uninitialized bool
        
        after 426c641976688e3e4d1ce66f76b27ccbd2dca55a "tdf#159040: add sign with
        default certificate to save dialog", causing
        
        > /sfx2/source/doc/guisaveas.cxx:307:54: runtime error: load of value 190, which is not a valid value for type 'bool'
        >     #0 0x7f1ab45ca7d6 in ModelData_Impl::IsSignWithDefaultSignature() const /sfx2/source/doc/guisaveas.cxx:307:54
        >     #1 0x7f1ab45957de in SfxStoringHelper::FinishGUIStoreModel(__gnu_debug::_Safe_iterator<std::__detail::_Node_const_iterator<std::pair<comphelper::OUStringAndHashCode const, com::sun::star::uno::Any>, false, true>, std::__debug::unordered_map<comphelper::OUStringAndHashCode, com::sun::star::uno::Any, comphelper::OUStringAndHashCodeHash, comphelper::OUStringAndHashCodeEqual, std::allocator<std::pair<comphelper::OUStringAndHashCode const, com::sun::star::uno::Any> > >, std::forward_iterator_tag>&, ModelData_Impl&, bool, short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, bool, bool, bool, std::basic_string_view<char16_t, std::char_traits<char16_t> >, std::basic_string_view<char16_t, std::char_traits<char16_t> >, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, rtl::OUString) /sfx2/source/doc/guisaveas.cxx:1896:20
        >     #2 0x7f1ab45b49b0 in SfxStoringHelper::GUIStoreModel(com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, bool, SignatureState, bool) /sfx2/source/doc/guisaveas.cxx:1626:12
        >     #3 0x7f1ab46b6ac3 in SfxObjectShell::ExecFile_Impl(SfxRequest&) /sfx2/source/doc/objserv.cxx:1096:26
        >     #4 0x7f1ab46a2ea4 in SfxStubSfxObjectShellExecFile_Impl(SfxShell*, SfxRequest&) /workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:221:1
        >     #5 0x7f1ab343ae1e in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9
        >     #6 0x7f1ab3450745 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
        >     #7 0x7f1ab34515ab in SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short) /sfx2/source/control/dispatch.cxx:812:9
        >     #8 0x7f1ab3861c1b in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:675:46
        >     #9 0x7f1ab3864f41 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:270:16
        >     #10 0x7f1a86be9616 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:164:30
        >     #11 0x7f1a86be84eb in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:121:16
        >     #12 0x7f1a86be9ec4 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
        >     #13 0x7f1aaea0e879 in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:94:33
        >     #14 0x7f1ad66c521e in ScPDFExportTest::exportToPDFWithUnoCommands(rtl::OUString const&) /sc/qa/extras/scpdfexport.cxx:196:5
        >     #15 0x7f1ad66d1e94 in ScPDFExportTest::testUnoCommands_Tdf120161() /sc/qa/extras/scpdfexport.cxx:376:9
        
        during CppunitTest_sc_pdf_export
        (<https://ci.libreoffice.org/job/lo_ubsan/3255/>)
        
        Change-Id: If9e1b4b75a430506b999ecff916191ab1d3d58d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171000
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-25  Julien Nabet  <serval2412@yahoo.fr>  [e219fc0ede27854a82681fde8c1fa3d4f60b2068]

        tdf#162174: fix crash when opening Bullets and Numbering dialog a second time
        
        It seems we must first retrieve the array of values from:
        - officecfg::Office::Common::BulletsNumbering::DefaultBullets
        - officecfg::Office::Common::BulletsNumbering::DefaultBulletsFonts
        before retrieving the value by index.
        
        Change-Id: I9cdf124f73c52f3027ae8e97a73e01e0efb73603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171003
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-25  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [042c62954be6ca55287e64cc725e71db4ddd7d8c]

        tdf#85677: Add support for Windows touch gestures (panning,zooming)
        
        Change-Id: Ib0243889621663ddb9b6789ede7643d54f06041e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170988
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [566fbd5cc3b56fdfae88274e6f01fa3451cc1b79]

        Fix typo
        
        Change-Id: I465502f90e0ce458f6746efa6e558896f6bea5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170999
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-07-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [6817badaf268f49106406157cf5005871314dc32]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e35fb29cb092771840ff876bbb4350e7570e1627
          - Related tdf#69192 better placeholder string for command line example
            
            Change-Id: I0a151668cd213906f6a7e523eacac48da8e50b20
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/171001
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-25  Julien Nabet  <serval2412@yahoo.fr>  [7dc921e2252dbb60be98695180893e7ae499870d]

        Related tdf#162136: typo GapWidthSequence instead of GapwidthSequence
        
        Fixes the crash with bt:
        8  0x00007fd839b91fef in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=0x5578a9fb8b08, nHandle=-1) at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:553
        9  0x00007fd839b8e1c9 in cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&) (this=0x5578a9fb8b08, rPropertyName="GapwidthSequence")
           at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:277
        10 0x00007fd7ef4e19e5 in chart::wrapper::SeriesOptionsItemConverter::ApplySpecialItem(unsigned short, SfxItemSet const&)
           (this=0x5578a3989070, nWhichId=77, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...})
           at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx:212
        11 0x00007fd7ef4d3939 in chart::wrapper::ItemConverter::ApplyItemSet(SfxItemSet const&)
           (this=0x5578a3989070, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/ItemConverter.cxx:186
        12 0x00007fd7ef4ba805 in chart::wrapper::DataPointItemConverter::ApplyItemSet(SfxItemSet const&)
           (this=0x5578a3767050, rItemSet=SfxItemSet of pool 0x5578a9fde810 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx:291
        13 0x00007fd7ef532167 in chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr<chart::UndoGuard>, rtl::OUString const&, bool)::$_0::operator()(int) const
           (this=0x5578a3916fb0, nResult=1) at /home/julien/lo/libreoffice/chart2/source/controller/main/ChartController_Properties.cxx:801
        
        but not the following one:
        8  0x00007f06e6d91fef in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=0x561ec293bb88, nHandle=-1) at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:553
        9  0x00007f06e6d8e1c9 in cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&) (this=0x561ec293bb88, rPropertyName="OverlapSequence")
           at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:277
        10 0x00007f06a4ce19e5 in chart::wrapper::SeriesOptionsItemConverter::ApplySpecialItem(unsigned short, SfxItemSet const&)
           (this=0x561ebb729a90, nWhichId=76, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...})
           at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/SeriesOptionsItemConverter.cxx:212
        11 0x00007f06a4cd3939 in chart::wrapper::ItemConverter::ApplyItemSet(SfxItemSet const&)
           (this=0x561ebb729a90, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/ItemConverter.cxx:186
        12 0x00007f06a4cba805 in chart::wrapper::DataPointItemConverter::ApplyItemSet(SfxItemSet const&)
           (this=0x561ebc2cdd90, rItemSet=SfxItemSet of pool 0x561ec2921fb0 with parent 0x0 and Which ranges: [(1, 13), (17, 17), (29, 38), (39, 39), (71, 71), (74, 74), (75, 75), (76, 78), (82, 89), (1000, 1012), (1014, 1034), (1177, 1232), (4021, 4076), (10085, 10086), (10932, 10932), (11090, 11090)] = {...}) at /home/julien/lo/libreoffice/chart2/source/controller/itemsetwrapper/DataPointItemConverter.cxx:291
        13 0x00007f06a4d32167 in chart::ChartController::executeDlg_ObjectProperties_withUndoGuard(std::shared_ptr<chart::UndoGuard>, rtl::OUString const&, bool)::$_0::operator()(int) const
           (this=0x561ec2939c20, nResult=1) at /home/julien/lo/libreoffice/chart2/source/controller/main/ChartController_Properties.cxx:801
        
        Change-Id: I53d8f9130a0a6cc17214c881398a6679a92606cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170902
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-07-25  Moritz Duge  <moritz.duge@allotropia.de>  [f2f1782d23abc48dadc21a82181417c557b2090d]

        tdf#161909: Fix resize for cert listings (GtkBox instead of GtkGrid)
        
        - "Certificate Path" dialog (select Mozilla profile for NSS)
          - resizing broken since commit db9e1ef04d13ecc1b8f8f156b059173143ea03ea
          - also increased default width to account for long filesystem paths
        - "Digital Signatures" dialog
        - "Select Certificate" dialog
          - resizable=True is the default (Glade removes explicit defaults)
          - Make long translations wrap instead of being cut.
        
        Glade set expand=False and fill=True as defaults inside GtkBox.
        
        Change-Id: I2d7719e83e5162d06d30e25b3e307fa23e0d605e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170694
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-25  Moritz Duge  <moritz.duge@allotropia.de>  [36a589989660338bfaec65736f6a6b5b129d5e37]

        tdf#161909: Fix resizing and behavior for "View Certificate" dialog.
        
        - Set appropriate larger default size.
        - Disable editing of details area.
        - Add comments to distinguish GPG and X.509 code.
        
        Change-Id: Idcca012c1eef96c6daa78498e85da6f70c97a90f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170004
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-25  Pierre F  <fpy@bger.ch>  [27e5a74960f50ec041ef7c9e5026afe70a2b4adc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 421ecbe5b8f35dc9a50ac6a329662231914132d4
          - clarify + link. tdf#155459
            
            Change-Id: I422016b32edf3d2bf898eb5ef4b1651eb7ee7c0c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170360
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-07-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e8358d0a0f7c2c4b1ccf800fe9ec8a7f2bf7066a]

        Keep around a single configmgr::Components::WriteThread instance
        
        ...instead of joining and later re-spawning one.  This helps with the current
        Emscripten setup (see 5b1df7709d75c6dd993da5a272e7e37e55a70174 "Document the
        Emscripten threads issue"), and probably doesn't matter much either way on other
        platforms (so just get it in unconditionally).  (Renaming the delay_ member
        variable to delayOrTerminate_, to make its overall role more clear.)
        
        (I ran into this when trying to turn the Emscripten build from starting up with
        a Writer document to starting up with the start center, and then manually
        opening a new Writer document.  The resulting different usage scheme happened to
        exhaust our current -sPTHREAD_POOL_SIZE=4 pool quickly, so this is one of
        multiple commits to address that.)
        
        Change-Id: I1bd28604b4640d2afad982bfd82b1acee8200e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170993
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-25  Pierre F  <fpy@bger.ch>  [4a608aa02d497e4642df02c3c98685e9e8184255]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 287be903d8fad56a92ee79f88ab4a6b863614459
          - Note on  Cannot toggle edit mode on New (unsaved) Documents. tdf#128836
            
            Change-Id: Ic2d416ec2f9add41958485bfb7b2db375eae432a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170882
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-07-25  Đoàn Trần Công Danh  <congdanhqx@gmail.com>  [b6edb370a189573e0006269b9252ca1ae666e530]

        gtk4: fix -Wmaybe-uninitialized
        
        Despite that we bailed out when both old and new value set,
        gcc-13 cannot see that.
        
        Change-Id: Ie727a14bb29a4b1cc304d2ce077c62f72cece19f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170973
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-25  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [35efb60e20be3d2e2d86544039f160cfe45b6abc]

        slideshow: Enable venetian transition for impress
        
        Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
        Change-Id: I068864c5b383ca142fd0da8c274c485c3d7399d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170261
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 379de66f0758cdc1a03811ef497e6fd456a16c4a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170876
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-07-25  Jim Raykowski  <raykowj@gmail.com>  [c60dd66d89dab2174aa71c26c653f68908c7ba78]

        tdf#162018 Unexpected loss in focus in the "Manage Changes" window
        
        when adding a change in the document (Track changes mode), round 4
        
        Addresses "situation 4" when a new change makes a change to an entire
        previous change or to multiple previously tracked changes.
        
        Change-Id: I02175db6c7bc1258f8e7c05835b05ff79b7d7b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170984
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-07-25  Jim Raykowski  <raykowj@gmail.com>  [cac1b706ecf9b1b95c2ca31e029135533fd6bf83]

        related tdf#161717 Use a better approach to determine RedlinData
        
        ::pData type
        
        Casting a void* RedlineData::pDate to either a SwRedlineDataParent*
        or SwRedlineDataChild* works because of the order and variable types
        declared in the SwRedlineDataChild and SwRedlineDataParent classes
        match until an OUString is declared in SwRedlineDataParent. That
        explains why the non-patched code behaves as expected even though
        testing if the entry has children to determine which cast to do is
        flawed. Better is to test the iterator depth which is what this patch
        does.
        
        Change-Id: I24ca0990a4edbd50a7e3dc5d0be4c5312c240921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170860
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-25  Eike Rathke  <erack@redhat.com>  [f1f5e9c8d7be16a969e58ebf7cfae99eef5bcb6e]

        Resolves: tdf#162087 TableRef item specifier may occur standalone
        
        This is what
        https://learn.microsoft.com/en-us/openspecs/office_standards/ms-xlsx/3d025add-118d-4413-9856-ab65712ec1b0
        specifies as  keyword  in
        
         intra-table-reference = spaced-lbracket inner-reference spaced-rbracket / keyword / ("[" [simple-column-name] "]")
        
        with
        
         keyword = "[#All]" / "[#Data]" / "[#Headers]" / "[#Totals]" / "[#This Row]"
        
        Change-Id: I52b200aad41d53a49e662d6238576f6f4f0deb37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170986
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-07-25  Juergen Funk  <juergen.funk_ml@cib.de>  [e8a271dd53d605a835c493eef5c34e4fb077f16d]

        tdf#160163 reset placeholder in Text field when empty
        
          for all the Text field made a global define
          of the NonBreakSpaces mask
        
        Change-Id: I7107f941ee9008415325aefe5487555d91dbf1ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170596
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ee9da9e3e3e141b304512e7fb7934eac891670da]

        Fix typo
        
        Change-Id: Iec45b32fce6381564f21c79d999a8db9a7757518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170981
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [77548ff9193cec40fe4954819bf425d3ae58aaa6]

        Fix typo
        
        Change-Id: Id89680653dec2edcb0529550d54a50036b736cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170982
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [59c781f29b5a0c5ad4d2b62453e8b07135f07a74]

        Fix typo
        
        Change-Id: I582bf693085251725b314b6caab9247650b25c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170980
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a369532d48335de66d7684f07e3a81de06c2b41]

        Fix typo
        
        Change-Id: I78bf0f3c03c190fcb577e5342041330aee15a6d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170983
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8cdf186fac523959d011d76dc0ae8083cc266614]

        Remove bExitWasCalled-handling from confgimgr::Components dtor
        
        That code had been added with 9fa4eff9be5e440099517a522a83e20debaf2955
        "profilesafe: Enhancements to BackupFileHelper", but it looks dubious:
        
        For one, I cannot find proof for the claim that MSVC would run destructors of
        static objects upon _exit.  Building a simple C++ test program
        
        > #include <iostream>
        > #include <stdlib.h>
        > struct S { ~S() { std::cerr << "hello\n"; } };
        > S s;
        > void f() { _exit(1); }
        > int main() { f(); }
        
        with contemporary MSVC 17.10 and executing it shows no "hello" stderr output
        (see
        <https://gcc.godbolt.org/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,selection:(endColumn:13,endLineNumber:5,positionColumn:13,positionLineNumber:5,selectionStartColumn:13,selectionStartLineNumber:5,startColumn:13,startLineNumber:5),source:'%23include+%3Ciostream%3E%0A%23include+%3Cstdlib.h%3E%0Astruct+S+%7B+~S()+%7B+std::cerr+%3C%3C+%22hello%5Cn%22%3B+%7D+%7D%3B%0AS+s%3B%0Avoid+f()+%7B+_exit(1)%3B+%7D%0Aint+main()+%7B+f()%3B+%7D%0A'),l:'5',n:'1',o:'C%2B%2B+source+%231',t:'0')),k:32.19670284753087,l:'4',m:100,n:'0',o:'',s:0,t:'0'),(g:!((h:compiler,i:(compiler:vcpp_v19_40_VS17_10_x64,filters:(b:'0',binary:'1',binaryObject:'1',commentOnly:'0',debugCalls:'1',demangle:'0',directives:'0',execute:'0',intel:'0',libraryCode:'0',trim:'1',verboseDemangling:'0'),flagsViewOpen:'1',fontScale:14,fontUsePx:'0',j:1,lang:c%2B%2B,libs:!(),options:'',overrides:!(),selection:(endColumn:1,endLineNumber:1,positionColumn:1,positionLineNumber:1,selectionStartColumn:1,selectionStartLineNumber:1,startColumn:1,startLineNumber:1),source:1),l:'5',n:'0',o:'+x64+msvc+v19.40+VS17.10+(Editor+%231)',t:'0'),(h:output,i:(compilerName:'x86-64+clang+18.1.0',editorid:1,fontScale:14,fontUsePx:'0',j:1,wrap:'1'),l:'5',n:'0',o:'Output+of+x64+msvc+v19.40+VS17.10+(Compiler+%231)',t:'0')),k:67.80329715246913,l:'4',m:100.00000000000001,n:'0',o:'',s:1,t:'0')),l:'2',n:'0',o:'',t:'0')),version:4>).
        
        If there indeed were issues with MSVC and non-standard _exit, a solution might
        be to use standard _Exit instead (in FatalError in desktop/source/app/app.cxx).
        
        And for another, when bExitWasCalled was true in
        configmgr::Components::~Components, it would still have called
        writeThread_->join() (i.e., it would potentially still have called
        writeModFile from within configmgr::Components::WriteThread::execute()), but (a)
        only after waiting out its full
        
        > delay_.wait(std::chrono::seconds(1));
        
        (because it missed to call configmgr::Components::WriteThread::flush, which
        calls delay_.set()), and (b) potentially running into a deadlock because it
        called writeThread_->join() with *lock_ locked, which
        configmgr::Components::WriteThread::execute wants to lock too.
        
        (I came across this because it got into my way when trying to adapt the
        lifecycle of configmgr::Components::WriteThread to the needs of the Emscripten
        build.)
        
        Change-Id: Icb4ebf00d1d316b80c29f7bd91b86614ef4ac430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170940
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5b1df7709d75c6dd993da5a272e7e37e55a70174]

        Document the Emscripten threads issue
        
        Change-Id: Ia26b48d46283a9528a665eb5028bd5b9bd0dd953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170972
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f135227a93ac122015048e84717b5e9cdbb9215]

        cid#1556131 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1556135 COPY_INSTEAD_OF_MOVE
        cid#1556146 COPY_INSTEAD_OF_MOVE
        cid#1556164 COPY_INSTEAD_OF_MOVE
        cid#1556171 COPY_INSTEAD_OF_MOVE
        cid#1556177 COPY_INSTEAD_OF_MOVE
        cid#1556181 COPY_INSTEAD_OF_MOVE
        cid#1556182 COPY_INSTEAD_OF_MOVE
        cid#1556183 COPY_INSTEAD_OF_MOVE
        cid#1556192 COPY_INSTEAD_OF_MOVE
        cid#1556201 COPY_INSTEAD_OF_MOVE
        cid#1556208 COPY_INSTEAD_OF_MOVE
        cid#1556215 COPY_INSTEAD_OF_MOVE
        cid#1556224 COPY_INSTEAD_OF_MOVE
        cid#1556227 COPY_INSTEAD_OF_MOVE
        cid#1556228 COPY_INSTEAD_OF_MOVE
        cid#1556238 COPY_INSTEAD_OF_MOVE
        cid#1556246 COPY_INSTEAD_OF_MOVE
        cid#1556247 COPY_INSTEAD_OF_MOVE
        cid#1556288 COPY_INSTEAD_OF_MOVE
        cid#1556293 COPY_INSTEAD_OF_MOVE
        cid#1556305 COPY_INSTEAD_OF_MOVE
        cid#1556310 COPY_INSTEAD_OF_MOVE
        cid#1556317 COPY_INSTEAD_OF_MOVE
        cid#1556321 COPY_INSTEAD_OF_MOVE
        cid#1556322 COPY_INSTEAD_OF_MOVE
        cid#1556331 COPY_INSTEAD_OF_MOVE
        cid#1556339 COPY_INSTEAD_OF_MOVE
        cid#1556342 COPY_INSTEAD_OF_MOVE
        cid#1556351 COPY_INSTEAD_OF_MOVE
        cid#1556358 COPY_INSTEAD_OF_MOVE
        cid#1556370 COPY_INSTEAD_OF_MOVE
        cid#1556379 COPY_INSTEAD_OF_MOVE
        cid#1556390 COPY_INSTEAD_OF_MOVE
        cid#1556423 COPY_INSTEAD_OF_MOVE
        cid#1556532 COPY_INSTEAD_OF_MOVE
        cid#1556561 COPY_INSTEAD_OF_MOVE
        cid#1556662 COPY_INSTEAD_OF_MOVE
        cid#1556704 COPY_INSTEAD_OF_MOVE
        cid#1556730 COPY_INSTEAD_OF_MOVE
        cid#1556988 COPY_INSTEAD_OF_MOVE
        cid#1557071 COPY_INSTEAD_OF_MOVE
        cid#1557081 COPY_INSTEAD_OF_MOVE
        cid#1557177 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I2c723f0fe9a4eefa62a68f47049ed690d06eb0ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e22dfeef0c0bfb4ed11ae08b2331a0103384f3f5]

        related tdf#161865: fix another ODR violation
        
        Change-Id: I082ad91c0c060e7231d0af15868960cb2399b088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170971
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-24  Patrick Luby  <guibmacdev@gmail.com>  [4bbdb2f0718d71840a4e55cc7e9c82157422b0dd]

        tdf#162171 alpha mask pixels are now alpha instead of transparency
        
        Starting with commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
        alpha masks now store alpha instead of transparency values.
        
        Change-Id: I74d7a536e0ae1aea3b462d660ae3e4b815cf89c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-07-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ddd8287d27736032c02084f124dab95c4715dda]

        libxml2: upgrade to 2.13.3
        
        it fixes CVE-2024-40896
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.3.tar.xz
        
        Change-Id: Icba636106cc9d1f096f5479bd80d5e30712c2e6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170975
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-24  Justin Luth  <jluth@mail.com>  [926372b8de7f283c5fd890c23b6d0755ff6bed87]

        tdf#157952 sw content controls, drop-down: remove when obsolete
        
        One place that was missed was when moving from one content control
        to another (for example, using the tab key).
        
        Change-Id: I62a3af2a5a7036aaac605d592c244a58f5b65a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170967
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [84929c43df529ad9fcb6382349015b3d9aa2e202]

        tdf#155447 qt a11y: Map TEXT_FRAME role to QAccessible::Pane
        
        This makes the "sentence" drawing area from the spelling
        dialog (cui/uiconfig/ui/spellingdialog.ui) show up with
        role panel instead of "unknown" in Accerciser when using
        the qt6 VCL plugin.
        
        This is the same as with gtk3, where the `TEXT_FRAME` role
        is mapped to `ATK_ROLE_PANEL`.
        
        Change-Id: I41133c51c64749ccd808cb675fe647a0daefac33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170944
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [0435460d22752f67979b1c54b90dbc892ee98c40]

        nss: upgrade to 3.102
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_102_RTM/src/nss-3.102-with-nspr-4.35.tar.gz
        
        Change-Id: I0a045b91deb4540771aade2c7965dafaa269f762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170943
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-24  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [1b74b95bba6b84225248e5b7badf1de7ae401a79]

        CairoSDPR: Improve animated tiled fills
        
        Up to now these needed to be decomposed to be
        rendered and did not support animation. I already
        added animation, but that was a compromize.
        Done that now in the correct way, so that animation
        is possible and can be directly rendered using
        a FillGraphicPrimitive2D if wanted, including one
        extra layer of alpha, too.
        This will also enhance other primitive processors,
        but of course most those that do handle that now
        directly, so CairoPixelProcessor2D does that.
        Note that it does not need to support animation
        in any way (that is part of the primitive stack),
        but just direct tiled rendering.
        
        Change-Id: I8860098dfb3f2369e361579cf1deea7c67b662b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170937
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab704c00fd7a80e412b00cce9a8fb64e8937cc15]

        tdf#161865 Base Table Design View not editable
        
        we had an ODR violation with a constant named PROPERTY_DATASOURCE which
        is also defined inside dbaccess
        
        regression from
        commit bacb92275c0c474d09146c0409cb547aef6551cf
        "add dbu to --enable-mergelibs=more"
        
        Change-Id: I315ba82e0bccc49e01bd6a438b7e671b971410dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170939
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3e99775689b7c0fa8217c6e77bec288ed5a9cc13]

        ofz#70572 build failure
        
        Change-Id: Ib313e1c6ace119e1480587e2bd519a5841e51a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-24  Jonathan Clark  <jonathan@libreoffice.org>  [15d92cd882e7d8280d6d9bdc44b6f29a951aef46]

        tdf#157390 Fix overlapping CJK characters in PDF export
        
        This change fixes a vertical text glyph metrics regression that was
        introduced while migrating PDF export to use metrics from HarfBuzz. The
        root cause was incorrectly caching CJK glyph heights in place of widths
        for vertical text.
        
        Change-Id: I8426fc902658d1c045b42e760028f26b09eeef93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170935
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [f3d7d24b99fec4a26afb7b53dded069649fa8fab]

        tdf#161501 icon choice ctrl: Actually set text colors for non-selection
        
            commit 24103bdf3fa3d6962efcc6fb6ee5c95b62e29cc4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jul 18 08:58:10 2024 +0200
        
                tdf#161501 icon choice ctrl: Use tab text colors
        
                Instead of using the generic window or highlight
                text color, use the specific text colors for tabs
                when painting entries of the vertical tab control,
                similar to how it's done for the non-vertical
                tab control (see `TabControl::ImplDrawItem`).
        
                (...)
        
        had added code to set the font color for the different
        states of a vertical tab control item, but as this
        was in the `if (bSelected)` block, only the one
        for selection was actually used, so the other cases
        were consequently removed in
        
            commit a4befb29f325d4800b3408abb6e6df608a97ecf9
            Author: Caolán McNamara <caolan.mcnamara@collabora.com>
            Date:   Sat Jul 20 19:20:13 2024 +0100
        
                cid#1610738 Logically dead code
        
        again.
        
        Thanks to Chris Sherlock for pointing this out!
        
        Reintroduce setting colors, but drop the `bSelected`
        condition altogether. Drop explicitly setting a fill
        color, which the implementation for the non-vertical
        tab control in `TabControl::ImplDrawItem` also doesn't
        do and which would e.g. result in an odd grey background
        for non-selected entries when used unconditionally with
        the gen VCL plugin.
        
        I see no visual difference with or without this commit
        in place on Windows or for the gen VCL plugin or the kf5 VCL
        plugin with the Breeze style on Linux, but other theming/styles
        could depend on according colors being set.
        
        Change-Id: Iccf7170f2de04cead23607977ac8cf7acbc471f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170926
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [87671a72505603a4cf9b3118c867654e788086da]

        tdf#161501 icon choice ctrl: Stop hover-highlight when mouse leaves
        
        When the mouse leaves the vertical tab bar,
        unset the entry to highlight as mouse-hovered,
        as the previously one no longer is when the
        mouse is outside the area of the tab bar.
        
        This fixes the issue of the previously
        mouse-hovered entry still being painted
        with mouse-hover feedback when slowly moving the
        mouse to the right away from an entry in the
        "Insert" -> "Page Style" dialog with gen or kf5
        at least, as shown in attachment 195467
        of tdf#161501.
        
        Change-Id: I646cab54f5031ed6a8aa88d4a162bb3a2456eec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170923
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [b3626b0142fc8b72d2249279c34badbb971addce]

        tdf#161501 icon choice ctrl: Drop WB_HIGHLIGHTFRAME
        
        It is always set, so no need to have an
        icon choice control specific window bit to
        specify whether or not to highlight the
        currently mouse-hovered entry. Just always
        do it.
        
        Change-Id: Ib259b6b1576e1968221c4f98661a3a93e600c93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170922
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [282da64a8fbcc71b59479bf13820a0b93c5f5889]

        curl: upgrade to 8.9.0
        
        Downloaded from https://curl.se/download/curl-8.9.0.tar.xz
        
        Change-Id: Id8198dcc73e1679e8f672459b19d84606ae3e762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170934
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-24  Justin Luth  <jluth@mail.com>  [3974c4748b9a2bcd054e0b9f9e3d42bdca45bef2]

        tdf#138093 tdf#131722 docx import: sdt lost first date character #2
        
        While GetIsDummyParaAddedForTableInSection() is true
        for the entire section, it should only be used
        against GetIsFirstParagraphInSection()
        where the dummy para exists.
        
        make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf138093B
        
        Change-Id: I457c0aa25eb7bd086c5c15bd889d9cd89c51db95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170921
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-24  Justin Luth  <jluth@mail.com>  [62974cf6a8148377091cb709e7e00dacac152093]

        tdf#158661 docx import plaintext sdt: remove unnecessary goRight
        
        This fixes a 24.2 regression
        from commit 5082d50d24c3fec4487c724a15eb0d54a82ecd0d
           writerfilter: use content controls for text in block SDTs
        
        which was made even worse
        with 24.2 commit 7c4dba1deffd81f647a4a3be7a79f68f3bf9f1ba.
        
        Initially, the starting mark was made as soon as SdtContent was seen.
        After that, you could get a w:tbl, or a w:tc which could trigger
        the start of a table, and potentially add a dummy paragraph
        which needed to be jumped over (at least for the first SDT,
        but not for subsequent SDTs).
        
        In the second patch, the starting mark was made just before
        the text was appended, so all of the cell/table creation
        has already been completed, so there is no more need to
        jump over any dummy paragraphs, even for the first table.
        
        Affected unit tests were
        - table-start-2-sdt.docx
        - sdt-company-multipara.docx
        - paragraph-sdt.docx
        
        make CppunitTest_sw_ooxmlfieldexport CPPUNIT_TEST_NAME=testParagraphSdt
        make CppunitTest_sw_ooxmlfieldexport \
            CPPUNIT_TEST_NAME=testTdf158661_blockSDT
        
        Change-Id: I4a8359cec27f88f6a2fc0464aa240b523a279e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170920
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [167897b7766babc014564d89543da82ccd588819]

        Update git submodules
        
        * Update translations from branch 'master'
          to d3e4d5213d29f57c45e2199822f2a68df9a884f6
          - update translations for 24.8.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: If72ef1ab34b88547d6caa85763242e8f2a231015
            
2024-07-24  Tuukka Orava  <tuukka.orava@outlook.com>  [f0a79b4dc1e96eb5dda35097d0975aae9f3e0c98]

        tdf#147021 Use std::size instead of SAL_N_ELEMENTS in editeng
        
        Change-Id: I6cf0557b1e44dff08fa1efa4aefa14dec276458e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167134
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [52f2edaa596159828b95313e55d8df3bb289aaee]

        qt: Move resolution calc to static helper method
        
        Instead of duplicating the same code in both,
        `QtGraphics::GetResolution` and
        `QtSvpGraphics::GetResolution`, create a static
        helper method `QtGraphicsBase::ImplGetResolution`
        in their base class and call that.
        
        While at it, also move `QtGraphics::GetResolution`
        to the source file where all of the other
        `QtGraphics` methods are implemented.
        
        Change-Id: I721459e8b65756f214fee77ac4d3cb8e500f0b57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170930
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [7de061883ddd185e5f36fe39cab0326d8a73b947]

        tdf#130857 qt weld a11y: Implement getting/setting a11y name/desc
        
        Change-Id: I24149951d9d56d24ceac334c25357084a27708d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170905
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [426c641976688e3e4d1ce66f76b27ccbd2dca55a]

        tdf#159040: add sign with default certificate to save dialog
        
        Include X.509 certificates under Tools->Options->UserData
        among the keys for signing.
        
        Add a new checkbox to Save file dialog, to sign with that
        selected key easily.
        
        The checkbox is disabled if there's no matching key found.
        
        Change-Id: I9fc16790c479819cd1f35bcad040d0ebc7c4bdef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170619
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [6ca02ef177df62edb124881248a1ebcd9876ff4c]

        icon choice ctrl: Drop unnecessary cast
        
        Change-Id: Ic9de7dae6f9341889fc4dec9ecf798aae63dd4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170899
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [aebf3d38201521905f6b6739b723f04bb4e93c22]

        tdf#161501 icon choice ctrl: Don't modify bound rect to center content
        
        Don't modify the bound rect of tab items used used e.g.
        for drawing the focus/selection/mouse-hover rectangles/indicators
        in order to center the content horizontally and vertically.
        
        Making the bound rect smaller in vertical direction
        in `SvxIconChoiceCtrl_Impl::Center` resulted in margins
        between entries for the non-native drawing path (e.g. the
        gen VCL plugin on Linux) for the text-only case
        (e.g. "Format" -> "Page Style" dialog in Writer).
        
        Making sure that the content is centered should rather
        happen in the drawing routine.
        
        Horizontally centering already happens for the icon-case
        anyway, as the `PAINTFLAG_VER_CENTERED` gets passed as flag
        to the `PaintItem` call for the `WB_ICON` case in
        `SvxIconChoiceCtrl_Impl::PaintEntry` anyway.
        
        And for text-only mode, which was apparently the only one
        for which centering vertically in `SvxIconChoiceCtrl_Impl::Center`
        had an effect, vertically drawing text was implemented in the drawing
        code path in
        
            commit 180f0c1ec8e195043b5f4298737a219026a8b944
            Author: Rafael Lima <rafael.palma.lima@gmail.com>
            Date:   Tue Jul 16 20:52:28 2024 +0200
        
                tdf#161501 Improve visuals of selected entries in Vertical tabs
        
        . This commit addresses the
        
        >   For the gen VCL plugin, there's still a small gap between
        >   text-only items (e.g. in the "Format" -> "Page Style" dialog
        >   which has a different cause and will be addressed in a separate
        >   commit.
        
        aspect mentioned in earlier commit
        
            Change-Id: Iac34098ef8d0f90f1ac0844df63839a6a99b83a7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 22 11:39:48 2024 +0200
        
                tdf#161501 icon choice ctrl: Drop extra space between items
        
        Change-Id: I2077efc8ce1e97d52cf078d63bb4e4b528e389eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170895
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [7b645998e691c3a6279f5e5a7452981d77d29e20]

        tdf#161501 icon choice ctrl: Use a single member for entry rect
        
        `SvxIconChoiceCtrlEntry` has two members for maintaining
        the bound rect:
        
        * `aRect`, used almost everywhere
        * `aGridRect`, used very rarely
        
        `SvxIconChoiceCtrl_Impl::FindBoundingRect` calculates
        a new bounding rect and assigns it to `pEntry->aGridRect`,
        then calls `SvxIconChoiceCtrl_Impl::Center`, which
        at first assigns the same value to `pEntry->aRect`,
        so both are the same there.
        
        The other place using the `aGridRect` member is
        `SvxIconChoiceCtrl_Impl::CalcMaxTextRect` where
        it's used as a fallback if `aRect` has not been
        assigned a proper value yet.
        
        However, since `aGridRect` is never assigned a
        useful value apart from `aRect`, there doesn't
        seem to be much value in doing that, so use
        `aRect` there, too, and drop the `aGridRect`
        member altogether and assign directly to `aRect` in
        `SvxIconChoiceCtrl_Impl::FindBoundingRect` instead.
        
        Instead of falling back to `aGridRect` in
        `SvxIconChoiceCtrl_Impl::CalcMaxTextRect`,
        add an assert that `aRect` is valid instead,
        which never triggered in my tests with the
        "Insert" -> "Hyperlink" and "Format" -> "Page Style"
        dialogs, so should presumably be fine already.
        
        Change-Id: I99f368672523279f530b937a73c3afb655f7853e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170894
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [14e1f10793d1ec994ab70f928feeecdb384a307e]

        tdf#161501 Drop unused SvxIconChoiceCtrl_Impl::InvalidateEntry
        
        Unused since:
        
            Change-Id: If309f84fcd9a99337bc5896ce5c3238333427da5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 23 11:00:42 2024 +0200
        
                tdf#161501 icon choice ctrl: Drop debug-only mode switch feature
        
                Drop code that allows switching the text mode of
                the currently selected tab item in a vertical tab
                bar using Shift+F10 or Ctrl+F10, which is only
                available in dbgutil builds, and was therefore
                likely meant to be used for debugging purposes
                only.
        
                As related code will be changed in a follow-up
                commit, this would have to be adjusted to keep
                it working. Instead of spending time on that,
                just drop it. Testing how using another mode is still
                possible e.g. by locally changing the value assigned
                to `SvxIconChoiceCtrlEntry::eTextMode` in the
                `SvxIconChoiceCtrlEntry` ctor instead.
        
                Change-Id: If309f84fcd9a99337bc5896ce5c3238333427da5
        
        Change-Id: I418fbf862ec94b04dbcfa4e7ff30cd5a8f9100e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170893
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [c8234947b60d320565fe0ca843e095858eb9975a]

        tdf#161501 icon choice ctrl: Drop debug-only mode switch feature
        
        Drop code that allows switching the text mode of
        the currently selected tab item in a vertical tab
        bar using Shift+F10 or Ctrl+F10, which is only
        available in dbgutil builds, and was therefore
        likely meant to be used for debugging purposes
        only.
        
        As related code will be changed in a follow-up
        commit, this would have to be adjusted to keep
        it working. Instead of spending time on that,
        just drop it. Testing how using another mode is still
        possible e.g. by locally changing the value assigned
        to `SvxIconChoiceCtrlEntry::eTextMode` in the
        `SvxIconChoiceCtrlEntry` ctor instead.
        
        Change-Id: If309f84fcd9a99337bc5896ce5c3238333427da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170892
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [efd060187aadb768f12a5b5e510db9e6e7687e23]

        tdf#161501 icon choice ctrl: Drop extra space between items
        
        Drop the extra spacing between vertical tab bar items, which
        became quite noticeable as extra white area between the otherwise
        light-grey entries when using the Breeze (light) style and the
        kf5 VCL plugin for the "Insert" -> "Hyperlink" dialog now that
        the tab items are drawn natively since
        
            Change-Id: Ie0c8ba1b56f6bb76ece6761253b93a109bb3a3f4
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 22 11:05:30 2024 +0200
        
                tdf#161501 icon choice ctrl: Draw whole entry natively
        
        and which is also more visible for non-natively drawn items
        since
        
            Change-Id: I578755a8a82ea811765b2e0dc3815fb47f67863c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 23 10:41:16 2024 +0200
        
                tdf#161501 icon choice ctrl: Draw selection within item bounds
        
        With this in place, the extra margin between entries
        in tab items with icons in the "Insert" -> "Hyperlink"
        dialog in Writer is gone for both, the gen VCL plugin
        and the kf5 one (tested with the Breeze style).
        
        For the gen VCL plugin, there's still a small gap between
        text-only items (e.g. in the "Format" -> "Page Style" dialog
        which has a different cause and will be addressed in a separate
        commit.
        
        Change-Id: Iac34098ef8d0f90f1ac0844df63839a6a99b83a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170850
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [42024245c72d44104ebd26bae3c601de7a876eea]

        tdf#161501 icon choice ctrl: Draw selection within item bounds
        
        In the same way that the calculated focus rect of an item
        is used for drawing selection and focus indicators, use
        it for mouse-hover highlighting as well, instead of
        drawing a rectangle that reaches beyond the bounds
        of the item itself for the non-native drawing path
        of vertical tab bar items.
        
        With this in place, hovering over an entry other than
        the selected/focused one now shows a rectangle of the same
        size as that for the focused entry, which is more
        consistent and also aligns this with the case
        where the native drawing API for drawing the item is used,
        e.g. on Windows or with the kf5 VCL plugin on Linux.
        
        This also means that a small gap can now be seen
        between selected item and mouse-hovered item when
        hovering over an item next to the currently selected
        one for the gen VCL plugin as well, just as was
        already the case before for the kf5 VCL plugin.
        (Dropping that extra margin will happen in a
        separate commit.)
        
        Change-Id: I578755a8a82ea811765b2e0dc3815fb47f67863c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170891
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [22a2ddcb77ea33fb5df0e62849a60d15cfe6e8fa]

        tdf#161501 icon choice ctrl: Consistently use bound rect
        
        In `SvxIconChoiceCtrl_Impl::MakeEntryVisible`, always use
        the bound rect as the area to make visible.
        
        I see no reason to not do so when an entry is clicked
        (s `SvxIconChoiceCtrl_Impl::MouseButtonDown`, which is
        the only case that didn't do it yet.
        
        Drop the `bBound` param accordingly.
        
        Change-Id: I7a96e97585521943e7171c278fbd3509037cb7d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170849
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [766417d8d7de5fe3b082add4094781eadcaab072]

        tdf#161501 icon choice ctrl: OSL_FAIL -> assert
        
        Change-Id: Ifa6528f9994c471828efcaedebee83bc0027775a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170848
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [c59730b46b4d7dd0af0c49ecbc852cda2871a5a0]

        tdf#161501 icon choice ctrl: Draw whole entry natively
        
        When native drawing of tab items is supported,
        natively draw the whole (vertical) tab item (except for the
        text) in `SvxIconChoiceCtrl_Impl::PaintEntry`,
        instead of using native drawing API only for highlighting
        the mouse-hovered entry, as originally introduced in
        
            commit 8708e8cf90d0ac0acbbce34b82f10ef7352d5062
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jul 11 10:47:50 2024 +0200
        
                tdf#161026 tdf#161355 tdf#161501 icon choice ctrl: Natively draw mouse-hover
        
                ... feedback.
        
        Set the corresponding state flags for selected and
        focused entry, so that the native drawing routine
        can take care of drawing the selected/focused
        entry accordingly instead of using the native drawing
        API to draw a `ControlType::WindowBackground` for that
        purpose.
        
        With this commit in place, all entries (not just the
        mouse-hovered, focused or selected) entry are now
        drawn using the native drawing API.
        
        For the kf5 VCL plugin with the Breeze style, this
        makes them look similar to the entries for the
        non-vertical tabbar used elsewhere in LibreOffice,
        or actual native `QTabBar`s.
        
        Due to
        
            Change-Id: Idf1e41d3bc309d152a4a36d14e8617bd6429940c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 22 08:25:32 2024 +0200
        
                tdf#161501 vcl: Make TabitemValue position-aware
        
        , the selection indicator is drawn vertically as expected
        when using the Breeze style.
        
        Restrict manually drawing entries (including focus
        and selection indicator) to the case where native drawing
        is not implemented (e.g. the gen VCL plugin).
        
        Further tweaking the visual appearance (e.g.
        getting rid of extra white margins and space between the
        entries for the variant where icons are used,
        like the "Insert" -> "Hyperlink" dialog in Writer) can be
        done in separate commits.
        
        Change-Id: Ie0c8ba1b56f6bb76ece6761253b93a109bb3a3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170847
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [72408ffd0673894da48ae344653af3b5c6c93775]

        tdf#161501 icon choice ctrl: Merge two methods
        
        Merge `SetBoundingRect_Impl` into
        `SvxIconChoiceCtrl_Impl::FindBoundingRect` as that is the
        only caller.
        
        `SvxIconChoiceCtrl_Impl::SetBoundingRect_Impl` was ignoring
        the bounding size being passed.
        To be sure, still call `CalcBoundingSize` at the beginning
        even though the return value itself is not used,
        as the call to `SvxIconChoiceCtrl_Impl::CalcBoundingHeight`
        that it does can result in class members like
        `nMaxBoundHeight` getting updated.
        
        Change-Id: I53b70bb8ddbf53afd9f95c38ce3dd05922e1110c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [3f1c3a0faa6e0023e326f88d1bd9b84aef386a7e]

        tdf#161501 Drop bSelected param for SvxIconChoiceCtrl_Impl::PaintEmphasis
        
        The method doesn't do anything for `bSelected = true`,
        so drop the param, and only call it for the `bSelected = false`
        case in `SvxIconChoiceCtrl_Impl::PaintEntry` instead.
        
        Change-Id: I5e180a42f2960531d16e5df35ce0a4e9c63a1f91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170845
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [9288e66770adc0cb5eda2dc3e242da1472172def]

        tdf#161501 icon choice ctrl: Simplify and drop extra local variable
        
        No need to have a `bSolidTextRect` variable here,
        just do the relevant call right away.
        
        That also means that there's no need to save
        and restore the previous fill color for the
        `bSelected = true` case (it never gets changed),
        so move that into the if block as well.
        
        Change-Id: I57637e570b01e2a09708fc7776c867817a131d31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170844
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [3720078422b2c44faf8c4cbb53f4aa09875ad0bc]

        tdf#161501 icon choice ctrl: Drop extra drawing of entry bg
        
        Drop extra drawing of a rectangle with the background
        color just for selected entries.
        
        It's unclear why that is done, and why it's done
        only for selected entries, since the background
        color used here is unrelated to actual selection
        (e.g. is just white when using the gen VCL plugin
        or kf5 with the light Breeze theme).
        
        Drawing of the actual selection background
        happens further down.
        Therefore, drop drawing that extra rectangle
        to simplify code and having one place less
        to care about when switching to using native
        drawing for the whole entry in an upcoming
        commit.
        
        I see no visual difference with or without
        this commit in place with either gen or kf5
        with either the "Insert -> "Hyperlink" or the
        "Format" -> "Page Style" vertical tab pages
        dialogs in Writer.
        
        Change-Id: Ia1a7275238a919d245420b5ab4abaf7b3e85bcf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170843
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [a82e98f60e37d1b1d507df6645588e19a82dc72e]

        tdf#161501 icon choice ctrl: Drop handling for WB_NOHIDESELECTION
        
        `WB_NOHIDESELECTION` never gets set for `SvxIconChoiceCtrl_Impl`,
        which is only used by `SvtIconChoiceCtrl` to implement
        the vertical tab bar.
        Therefore, drop handling for that flag to simplify code.
        
        Change-Id: I488edf6680f25dbafae61ec0435784d693d222b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170842
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [92454bca2045b9e9ca636d086cb8520ccf03be22]

        tdf#161501 vcl: Make TabitemValue position-aware
        
        Add a new `TabBarPosition` enum that describes whether
        a tab bar is at the top, left, right, or bottom
        (relative to the tab page content) and make use of
        that for the new `meTabBarPosition` member for
        `TabitemValue` that gets used for drawing tab items
        via the native rendering API.
        
        Set the position accordingly for both the vertical
        tab control (`TabControl`) and `SvxIconChoiceCtrl_Impl`,
        which implements the tab bar for `VerticalTabControl`.
        
        For Qt-based VCL plugins, implement mapping to
        the corresponding `QTabBar::Shape`. [1]
        
        At least the Breeze Qt style uses that shape to decide
        whether on what side of the tab item to draw the
        selection/focus indicator.
        
        This change by itself doesn't yet make any visual
        difference for the Breeze style, as the "Top" value/
        `QTabBar::RoundedNorth` is the default anyway, and
        `SvxIconChoiceCtrl_Impl` doesn't yet use the
        native drawing API for drawing focus/selection, but
        only for mousehover feedback.
        The plan is to implement that in a follow-up change.
        
        [1] https://doc.qt.io/qt-6/qtabbar.html#Shape-enum
        
        Change-Id: Idf1e41d3bc309d152a4a36d14e8617bd6429940c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170841
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-24  Patrick Luby  <guibmacdev@gmail.com>  [57f46e0244bdc1165ebbc5e09e4069cc075ff7ae]

        tdf#162010 match based on key equivalent instead of key event
        
        The original fix for tdf#49853 only looked worked in the
        case when both a key shortcut was pressed and the resulting
        key event was not an input method event. If either of these
        conditions weren't true, tdf#49853 would still occur.
        
        Since we know which menu item is being triggered, check if
        this menu item's key equivalent has been set to one of the
        edit actions.
        
        This change basically expands the fix for tdf#49853 to
        include all cases that trigger a menu item, not just simple
        key events.
        
        Also, the fix for tdf#126638 would also fail when a key
        shortcut was pressed in a modal window if the resulting key
        event was an input method event.
        
        Change-Id: Iaa2e06affe0e347380a383755684568fcdc26b9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170908
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ea2c60501a600d1f53bfc130e123c0996837b2fa]

        Resolves: tdf#162161 reexport of specific pdf appears blank
        
        the contents of the referenced colorspace obj disappears so it gets
        rendered blank
        
        Change-Id: Iaa76d355b5903c695e74edadc329043156bad3b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170904
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8a83a62410bc3f9bbcd6d0dabb260814c6172bf8]

        cid#1555167 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555172 COPY_INSTEAD_OF_MOVE
        cid#1555184 COPY_INSTEAD_OF_MOVE
        cid#1555188 COPY_INSTEAD_OF_MOVE
        cid#1555197 COPY_INSTEAD_OF_MOVE
        cid#1555209 COPY_INSTEAD_OF_MOVE
        cid#1555211 COPY_INSTEAD_OF_MOVE
        cid#1555215 COPY_INSTEAD_OF_MOVE
        cid#1555216 COPY_INSTEAD_OF_MOVE
        cid#1555217 COPY_INSTEAD_OF_MOVE
        cid#1555218 COPY_INSTEAD_OF_MOVE
        cid#1555222 COPY_INSTEAD_OF_MOVE
        cid#1556674 COPY_INSTEAD_OF_MOVE
        cid#1555229 COPY_INSTEAD_OF_MOVE
        cid#1555233 COPY_INSTEAD_OF_MOVE
        cid#1555234 COPY_INSTEAD_OF_MOVE
        cid#1555242 COPY_INSTEAD_OF_MOVE
        cid#1555250 COPY_INSTEAD_OF_MOVE
        cid#1555251 COPY_INSTEAD_OF_MOVE
        cid#1555254 COPY_INSTEAD_OF_MOVE
        cid#1555304 COPY_INSTEAD_OF_MOVE
        cid#1555307 COPY_INSTEAD_OF_MOVE
        cid#1555317 COPY_INSTEAD_OF_MOVE
        cid#1555329 COPY_INSTEAD_OF_MOVE
        cid#1555340 COPY_INSTEAD_OF_MOVE
        cid#1555347 COPY_INSTEAD_OF_MOVE
        cid#1555352 COPY_INSTEAD_OF_MOVE
        cid#1555358 COPY_INSTEAD_OF_MOVE
        cid#1555363 COPY_INSTEAD_OF_MOVE
        cid#1555365 COPY_INSTEAD_OF_MOVE
        cid#1555367 COPY_INSTEAD_OF_MOVE
        cid#1555374 COPY_INSTEAD_OF_MOVE
        cid#1555380 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I343194c10749488a1143e2517ee0638ab19da218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-23  Jim Raykowski  <raykowj@gmail.com>  [ac0a497d09d8b4c0b624f788c8db34081fb8caa9]

        related tdf#160817 SwNavigator: update content functions toolbar
        
        on right-click selection of entry to show context menu for
        
        Change-Id: I045bd02103a37c94d6eb3fc1885ab19de79685c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170885
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-23  Julien Nabet  <serval2412@yahoo.fr>  [3bb3052ee95da72a59b0ce354e98111a426110e8]

        tdf#162139: make 2 buttons in the date form control translatable
        
        Context modified because the same strings are in svtools/uiconfig/ui/calendar.ui
        Don't know at all if these could be merged.
        
        Change-Id: I72e37b54b53e4717f513dd313757af7318bbc4f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170898
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7f9de9bc1abfe4562aea730d9f0b1a61fbd6d21]

        loplugin:unusedmethods
        
        Change-Id: I1863f86f064f02c7e37425ff6c74e7b370460295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-23  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [462d85709ead9c7cec33ce58fc608997263cb6aa]

        CairoSDPR: Support alpha for BitmapPrimitives
        
        To more directly support an additional alpha channel
        for BitmapPrimitive data I have done some deeper
        changes to the primitive stack, in a compatible
        way. Quite some more graphic types and primitives
        now support an additional direct alpha value. All
        that is decomposed/created/broken down in a way
        that needs no changes for existing renderers, in
        already described ways.
        The CairoPixelProcessor2D already uses this in the
        processFillGraphicPrimitive2D implementation and
        thus in the FillGraphicPrimitive2D. This works since
        primitive productions now all try to create that
        FillGraphicPrimitive2D type including an additional
        alpha value - if possible and necessary.
        
        Change-Id: Ib1b16491a2b3aee16f14cc8196e28af30a7cf9be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170900
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-23  Jim Raykowski  <raykowj@gmail.com>  [863b90e33c4b9964a697684887aeb42cc538b019]

        Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"
        
        window when adding a change in the document (Track changes mode),
        round 3
        
        Done to address loss of selection when an entry is added to the
        beginning of the changes list. The patch reworks round 1 and 2 to
        handle any entry insert position. It also keeps the selected entry
        selected after a sort by document order.
        
        Change-Id: Icb6f6b6b80ad9ddc5d008a00d195ceb7c1d6dc3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170828
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e9bd8614e28421d4907b06ed2e84bda9ba08e12f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44f0c2b1cd054a94ff7d4b3b563bc4a8674314e1
          - Fix term in TOC help page
            
            The term "Outline" was changed to "Headings"
            
            Change-Id: I9185775e323088a2576c76f10a8ba1eae367e6d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170886
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [512357eafd80d7b1942f59170b4267ce76a46e16]

        improve ImpEditEngine::SetParaAttribs a little
        
        avoid doing GetItemState if we don't have a wrong list (the common case)
        
        Change-Id: I3a1a22da657835ae37e8025d8ce21ad14d4e2c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [23f268d0772cd9ad024d6747ed4e65068a31e17e]

        avoid OUString construction in lcl_GetDelimitedString
        
        for the common case of having no paragraphs
        
        Change-Id: I56ad9b5069021690954730188e406c133894dbee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170889
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [43812baa4ccd804cf441e45021d835783d4ebdf9]

        dbaccess: Fix --without-java build
        
        ENABLE_FIREBIRD_SDBC condition was added in
        9aaf21b2851410492797a7dcf9193396c8bde770
        "sd: function to return a presentation info in a JSON document"
        for no apparent reason.
        
        Change-Id: Ia9a68340a73b87ed51a8b9c4a7fb3e67c59e7b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170887
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-23  Heiko Tietze  <tietze.heiko@gmail.com>  [98706cbfa6307de2f5a11ff0e5edb4120ad57bb8]

        Related tdf#159541 - Fix font color issue in Calc
        
        Follow-up to I954c9e3f8502a5243c664ed0bf066fb4c4cb4ccc
        
        Change-Id: Ib0a5b38739e7b5f73d1e5fbb57687b89b3e86233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170851
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82b7823cd83be3c31720c8a3b8eea33c22b312bc]

        cid#1555070 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555069 COPY_INSTEAD_OF_MOVE
        cid#1555128 COPY_INSTEAD_OF_MOVE
        cid#1555131 COPY_INSTEAD_OF_MOVE
        cid#1555137 COPY_INSTEAD_OF_MOVE
        cid#1555142 COPY_INSTEAD_OF_MOVE
        cid#1555152 COPY_INSTEAD_OF_MOVE
        cid#1555154 COPY_INSTEAD_OF_MOVE
        cid#1555161 COPY_INSTEAD_OF_MOVE
        cid#1555163 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I86a5b7049ac8f31ca703add11381f5293233d9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [a7de9cc5e89cd0d0c2f6363b2c0cc265c528b121]

        tdf#162104 Make sure the standard palette gets selected in a clear profile
        
        Commit [1] introduced localization of color palette names. However, the name defined in Common.xcs is not localized, so we need to make sure that the standard palette gets selected on a clear profile.
        
        [1] 5e45351c52584fb116d2cc54da969734e5effab9
        
        Change-Id: I2f03b3ab4bdbb77327388a754e1fc6f9d7413ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170732
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-22  Laurent Balland  <laurent.balland@mailo.fr>  [7c5cf7578eebd37918f4ea649f6b27f72883aa49]

        tdf#161799 Preserve default styles in Yellow Idea
        
        Same as https://gerrit.libreoffice.org/c/core/+/169661
        for Yellow Idea template
        
        Change-Id: Iceb74c267285e51b98346c01b0804ab15ff471d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169944
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-07-22  Laurent Balland  <laurent.balland@mailo.fr>  [c81943ae93f5faf71f9a6c359dd3c3a084c6f5e7]

        tdf#161799 Preserve default styles in Growing Liberty template
        
        Same as https://gerrit.libreoffice.org/c/core/+/169661
        for Growing Liberty template
        
        Change-Id: I58b1d3d24f55217fa5dd4019fbfa147a9ab1da01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169843
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-07-22  Julien Nabet  <serval2412@yahoo.fr>  [a8e738cb2e903ec40d4e38d06193f070fcb4885a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 95ad46565d8b72a66bff7201b14040f031e8c615
          - Python: use is None/is not None instead of == None/!= None
            
            Change-Id: Id5d2fdd780ad703deb893df567e716e913efdf64
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/170361
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1e86b37eceda74e45624251e0b52c979083b167]

        Fix typo
        
        Change-Id: If48f6b33e37d97b6e9bc086c26be34dbd6f975cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170862
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-22  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [3dcee7e08008588181e69f13e223d3ed4d667dda]

        CairoSDPR: Prepare BitmapAlphaPrimitive2D
        
        This provides a BitmapPrimitive2D extended by a unified
        transparency component. It will decompose to a
        UnifiedTransparencePrimitive2D containing a
        BitmapPrimitive2D and the transparence, so no primitive
        processor has to support this primitive directly - but
        can if feasible. I plan to use that ASAP
        
        Change-Id: I83ec84eaadc8ba2b21f0ba0cb1fdcf43bdc455db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170852
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-22  Zainab Abbasi  <101zabbasi@gmail.com>  [2b25d81905684bff16a37972c7c6de26ce8447f6]

        tdf#145538 Use range based for loops
        
        Change-Id: I18d00da91253d6ce3b4d2c5af94d919a84309a3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170329
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f08fdf3e81e63469609eaafaf790cb3fea6b27c4]

        crashtesting tdf135164-3.docx
        
        ./instdir/program/soffice --headless --convert-to odt
        ~/Downloads/tdf135164-3.docx
        
        fails after
            commit f98f684d22e6323185104ca9c082241c53dfc2b3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Jul 13 18:50:34 2024 +0200
            remove RecalcObjOrdNums in DoTextBoxZOrderCorrection
        
        add a check to catch this case and flatten the method to make it more
        readable
        
        Change-Id: I7827807c77f51b28f16b1042b77b8211ab5416ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-22  Patrick Luby  <guibmacdev@gmail.com>  [d81ffa179df1d1279e98ff4aa5c58e1ea4720db1]

        tdf#161858 prevent crashing by catching any JSON exceptions
        
        Change-Id: I733ac428c96a96be668d6334db8c71efaf51beff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170818
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b5c24d544f3a56a22bef47bf9639580748a5d9cd]

        no need to dynamic_cast when using GetItemSurrogates
        
        since the items returned are guaranteed to be of the right type
        
        Change-Id: I7912c0ec171b4617a7ac393786f553a1f0b6c78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170836
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [546f8dc0574a06b17d2d4f7abe2bf22f3971f0bd]

        speed up O(n^2) loop in UpdateFieldContents
        
        Change-Id: I53af2d1af22ed58acd384d33396e517d8a395f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170834
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1c247acd6b88db0f52c46517373a6fe81408d79]

        Revert "improve perf of lcl_GetUniqueFlyName"
        
        This reverts commit a61128c95e324b096bf26fec5ad78e67567e0f82.
        
        Reason for revert: Causes trouble with UITests because the names of some objects are not predictable
        
        Change-Id: I6320efd694849542ae79f0dc67c15d35eedfb750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-22  Heiko Tietze  <tietze.heiko@gmail.com>  [8534ad7b7b9aae2520d731cf748ff0aadfe2f0ed]

        Resolves tdf#159541 - Fix font color must not change depending on background
        
        Change-Id: I954c9e3f8502a5243c664ed0bf066fb4c4cb4ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169991
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ba9f87966feb61ba093f080d41e19b408a8355ff]

        add a static_assert for sizes of m_nFieldTagAlways and m_nFieldTagBad
        
        Change-Id: I4d847c74d8d069c76f874a19e6fbc99425757a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8145fef39120402af49dfb32d3a60e5e9ef08651]

        cid#1608488 avoid COPY_INSTEAD_OF_MOVE
        
        can drop the copy and use the orig instead
        
        Change-Id: I1463ee677677a7861162742f0c74c33d4a5951ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170825
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [a3081afb197dfd55055657eb89c6305a24e9e530]

        CairoSDPR: Better support for XOR
        
        Change-Id: Ib6a8489e655640e7a12eaec943977867e94d2793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170799
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-22  Noel Grandin  <noelgrandin@gmail.com>  [c3e8dbc139c3b1644ea07101a8c1111572ffa017]

        Improve the perf for pool item scanning..
        
        for large complex documents with lots of shapes.
        
        When that happens, we spend a lot of time scanning the std::unordered_set inside DefaultItemInstanceManager.
        
        Since most of our items are already capable of being hashed, and thus avoiding the scanning cost, make it so we can use the HashableItemInstanceManager most of the time.
        
        Change-Id: I43f4c04e956d316c976bea67d1941529d2d91182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170813
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Tested-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3133788fb5b8598ae275c566a9f55f88a668abf3]

        cid#1608424 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1607592 COPY_INSTEAD_OF_MOVE
        cid#1607487 COPY_INSTEAD_OF_MOVE
        cid#1607480 COPY_INSTEAD_OF_MOVE
        cid#1607444 COPY_INSTEAD_OF_MOVE
        cid#1607369 COPY_INSTEAD_OF_MOVE
        cid#1607356 COPY_INSTEAD_OF_MOVE
        cid#1607342 COPY_INSTEAD_OF_MOVE
        cid#1607329 COPY_INSTEAD_OF_MOVE
        cid#1607327 COPY_INSTEAD_OF_MOVE
        cid#1607303 COPY_INSTEAD_OF_MOVE
        cid#1607284 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia2d5d4e2de8ca96a9557df5266754e52efa4f60e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170826
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Weblate  <noreply@documentfoundation.org>  [b547d13a4672ebc3fd355f6f1751965d82fdcdfc]

        android-viewer translated using Weblate
        
        Japanese currently translated at 83.6% (97 of 116 strings)
        
        Change-Id: I0f1a0b85fa02badf103683cc589b8cc0a3a99a6b
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170788
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d4aa7861cf036f503e19a6bac460e26b78aa27a]

        cid#1608362 Double unlock
        
        and
        
        cid#1608276 Double lock
        
        Change-Id: I64529c0b9e9b4df2ee51a024522f82051ccea25d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170824
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1cf263e8387a21e740d49890fe00a8e684a117cc]

        cid#1608288 silence Overflowed constant
        
        Change-Id: Ic20c62c06f67792b263a15adcc4855297f2fefef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fdd5d471c10b3e349b51b9f4396cbbbd6d2190d8]

        cid#1607270 silence Overflowed integer argument
        
        Change-Id: Ie5973c23d2d106815af0d1300a99687a84cfed1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [041b3d8166fcfe38aa04c39f94c2ada140eaf991]

        drawpage::getCount is expensive
        
        so only call it once at the start of the loop. Shaves 1% off the cost of
        loading complex documents with lots of shapes.
        
        Change-Id: Ieb985b2523f6b4db3313eb000cf64e9c689e65c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [180f0c1ec8e195043b5f4298737a219026a8b944]

        tdf#161501 Improve visuals of selected entries in Vertical tabs
        
        This patch improves the following in vertical tabs:
        1) Selected entries are painted natively when possible
        2) Entries are a bit taller
        3) Text is now vertically centered (for items that are text-only)
        4) In native controls a mark is drawn on the selected tab
        
        Change-Id: I42a8e002130030d1484c4149b146258921436af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170554
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ba0e0093b0ed2816a18e54eef0a92220d7b04a4d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 805241fc011cf160c349548bcb532f487aa18e38
          - tdf#144986 Blank cells vs. empty string.
            
            Change-Id: If9c718e476625a137881805757f1011938ac9986
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170816
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c783662b9eff425ecb1661f2de18ccaa1b1943c]

        cid#1556239 Use of auto that causes a copy
        
        and
        
        cid#1557287 Use of auto that causes a copy
        cid#1558003 Use of auto that causes a copy
        cid#1557568 Use of auto that causes a copy
        cid#1556546 Use of auto that causes a copy
        cid#1557377 Use of auto that causes a copy
        cid#1608325 Use of auto that causes a copy
        
        Change-Id: I84e59d2b14bb1e5856f9cac521ad6542b1784243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170821
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a97efa53de6037d4603582e10e6dd7818f2dd3a1]

        cid#1606961 silence Overflowed array index read
        
        and
        
        cid#1606751 Overflowed array index read
        
        Change-Id: If9681a61b14b68e6d1f12b0d4907ab23180972f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170819
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4eb2718367ade73bde438db56cfa9b82341a17f6]

        GetEmptyBrushItem is used readonly
        
        Change-Id: I7994e48ffdedeaf99d8422c02d235e89ebf10366
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170815
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [6e51784dc54d08732f63c1f9fd114d2b66025b85]

        Use tools::Duration / DateTime to avoid use of boost
        
        Change-Id: Idec79929952929d1720b67fc865ac4a0c4908678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170817
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-21  Laurent Balland  <laurent.balland@mailo.fr>  [d9c156e70edd344ccdf7a0b57059d810ceddef01]

        tdf#161799 Preserve default styles in Candy template
        
        Some default styles ("Filled Blue", "Filled Red", "Filled Yellow",
        "Outlined Blue", "Outlined Red", "Outlined Yellow") were modified. But
        when slide is copied to other presentation, these new styles are
        replaced by default styles.
        This change duplicates the formats to preserve them when slides are
        copied outside Candy template.
        
        Change-Id: I38ccacbe65912c5b2cfecfa0d309a412bc34a867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169661
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [a245fd604c11f4bdbd1fdc4dd52e2a7f3880d85b]

        tdf#156530: fix OPreparedStatement::setString
        
        The problem was, that the function only considered the target XSQLVAR's
        sqltype,  ignoring sqlsubtype.  This led to a situation when assignment
        to NUMERIC or DECIMAL  was treated as assignment  to an underlying type,
        like SQL_LONG, performed without taking scale into account.
        
        Use ColumnTypeInfo and its getSdbcType, which provides the correct type,
        and add missing cases to setString.  Fix setObjectWithInfo to make sure
        that the resulting number is correct.
        
        This also fixes export of NUMERIC/DECIMAL in HSQL migration. Previously
        it miscalculated the position of decimal separator,  which accidentally
        went unnoticed in the existing unit test, because it was compensated by
        broken handling in Firebird SDBC for the specific numbers in the test.
        
        OResultSet::makeNumericString was also fixed; it didn't handle properly
        the case of zero fractional part:  initial number 1200 with scale 2 was
        converted to a string "12.000" instead of expected "12.00".
        
        Change-Id: I5adac59737d21f91c782fe867d4827fb880fd62a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170812
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b53ea34333154c3f98ef0f8b5fea175437a7d8ef]

        ofz#70572 build failure
        
        Change-Id: Id52104ee937306fc628d99c6f9dc6083fb054ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170814
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c55e4263036a127c04db050a7e4def94d5995bf]

        Remove duplicated include
        
        Change-Id: Ie0ab653d1301b6cc401738fb35e51f49b4e526ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170811
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-07-21  Eike Rathke  <erack@redhat.com>  [d6030b66f1cfb4b7cf9fc98996bb4674ea495377]

        Pull today DateTime out of loop
        
        It's unnecessary to obtain system time twice or thrice and also prevents
        different today values when looping over midnight.
        
        Change-Id: Ifcf4917769bb1d853e326049711e295d54408eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170699
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a61128c95e324b096bf26fec5ad78e67567e0f82]

        improve perf of lcl_GetUniqueFlyName
        
        reduces the load time of a complex document from 18s to 16s
        
        Change-Id: I5382e27bf1b6beaf7276ef46f10d43d5bf9822d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-21  varshneydevansh  <varshney.devansh614@gmail.com>  [07ae0e5ada7cb595eb4815413a5bdd442c32a6ab]

        tdf#82716 Add initial implementation of the Histogram Chart
        
        - Add the Histogram selection to the UI
        - Histogram bars showing with No Gap
        - Convert X and Y axis to group data into bins and frequency
        - Adjusted failing UI test (tdf138556) as a new chart type was added
        
        Change-Id: Id1f161adac943ead5e17c7fbb7e14c9ab7f1655e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167068
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [b92b1ca8c14979550ec962464ec8d782cdd69d82]

        Refactor for clarity
        
        Change-Id: Ie15fe9d2542000132c9928099f515dca8d287d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [8705cfecd5a10f817d3a2a02041d85e77282aa30]

        Unchecked dereference of UNO_QUERY result
        
        Change-Id: I85599f303e45ea003b5e214206e4ae3e5216509d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170735
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [3bc868b8a4c9d81dc397e2a022e1c8e75982742d]

        Optimize a bit
        
        Change-Id: I3ad48edd96dd7d390174626cda6841be04b2db07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170736
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b2cbdb00696c3aa66a17e1e3a41fdb2b0863fa5]

        cid#1608102 Double unlock
        
        Change-Id: I8cb89726926d2f079735e81491f2b9f1d61f6416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170807
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a4befb29f325d4800b3408abb6e6df608a97ecf9]

        cid#1610738 Logically dead code
        
        Change-Id: I5f10539adb2c109c19ec6ec41ec84c0db03b4d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170801
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0e195e073423ad5346bee331664652afa917e68a]

        Fix typo
        
        Change-Id: Icfce04f91f76119f970073bbcdbe65770f0e31c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170798
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81a51936290da5b743ac59c03afb22c62ce29bad]

        Fix typo
        
        Change-Id: I0f82c1ef158213cdf77621fb0b46be9b7424feb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170797
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d33d592801fa3c865613d9bdf4d715d8b1f637ca]

        cid#1554791 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554819 COPY_INSTEAD_OF_MOVE
        cid#1554837 COPY_INSTEAD_OF_MOVE
        cid#1554881 COPY_INSTEAD_OF_MOVE
        cid#1554882 COPY_INSTEAD_OF_MOVE
        cid#1554884 COPY_INSTEAD_OF_MOVE
        cid#1554891 COPY_INSTEAD_OF_MOVE
        cid#1554892 COPY_INSTEAD_OF_MOVE
        cid#1554897 COPY_INSTEAD_OF_MOVE
        cid#1554904 COPY_INSTEAD_OF_MOVE
        cid#1554918 COPY_INSTEAD_OF_MOVE
        cid#1554928 COPY_INSTEAD_OF_MOVE
        cid#1554931 COPY_INSTEAD_OF_MOVE
        cid#1554944 COPY_INSTEAD_OF_MOVE
        cid#1554945 COPY_INSTEAD_OF_MOVE
        cid#1554959 COPY_INSTEAD_OF_MOVE
        cid#1554960 COPY_INSTEAD_OF_MOVE
        cid#1554963 COPY_INSTEAD_OF_MOVE
        cid#1554966 COPY_INSTEAD_OF_MOVE
        cid#1554969 COPY_INSTEAD_OF_MOVE
        cid#1554973 COPY_INSTEAD_OF_MOVE
        cid#1555011 COPY_INSTEAD_OF_MOVE
        cid#1555012 COPY_INSTEAD_OF_MOVE
        cid#1555015 COPY_INSTEAD_OF_MOVE
        cid#1555044 COPY_INSTEAD_OF_MOVE
        cid#1555051 COPY_INSTEAD_OF_MOVE
        cid#1555055 COPY_INSTEAD_OF_MOVE
        cid#1555063 COPY_INSTEAD_OF_MOVE
        cid#1555068 COPY_INSTEAD_OF_MOVE
        cid#1555073 COPY_INSTEAD_OF_MOVE
        cid#1555074 COPY_INSTEAD_OF_MOVE
        cid#1555078 COPY_INSTEAD_OF_MOVE
        cid#1555080 COPY_INSTEAD_OF_MOVE
        cid#1555091 COPY_INSTEAD_OF_MOVE
        cid#1555099 COPY_INSTEAD_OF_MOVE
        cid#1555101 COPY_INSTEAD_OF_MOVE
        cid#1555121 COPY_INSTEAD_OF_MOVE
        cid#1610739 COPY_INSTEAD_OF_MOVE
        cid#1608424 COPY_INSTEAD_OF_MOVE
        cid#1608059 COPY_INSTEAD_OF_MOVE
        cid#1607952 COPY_INSTEAD_OF_MOVE
        cid#1607653 COPY_INSTEAD_OF_MOVE
        cid#1607614 COPY_INSTEAD_OF_MOVE
        cid#1607592 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie9f922a9fe1b8001dfab31e2741fe8bd5558e442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170802
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-20  Stanislav Horacek  <stanislav.horacek@gmail.com>  [f12f05dae44bab39aed24fdc63f52e0e1d2e5bdc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 401844aa0d051bad2cb8861a185b9a7c0f88cf48
          - allow localization of XLOOKUP example
            
            Change-Id: I024907e9fbc45c41ef4240eaca018c1af1491f4e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170804
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-07-20  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7185e17512cbace37c1158bc46143c7c234d8e70]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to de354a5e67e0e079d471c3ba7d806044f997c238
          - use same names of XMATCH arguments as in UI
            
            Change-Id: I1ce3a68d071bdccb1caa9af3c4389d8c0db82979
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170805
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-07-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bfd5670ab7dd87167ba47905857bc0b9958395a5]

        cid#1610739 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I618fbda65c66985c3179578d1fa106514c5aef30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170800
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-20  Jim Raykowski  <raykowj@gmail.com>  [de9a7a593630d3319e0e311b641c7c52c96b9e4a]

        Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"
        
        window when adding a change in the document (Track changes mode),
        round 2
        
        Addresses two situations where the list still jumps to the top:
        
        Situation 1:
        When an entry is added to the end of the changes list.
        
        Situation 2:
        After editing a comment for a change list entry with the 'Comment'
        dialog.
        
        Change-Id: I4a75e6bcba13fb9cc735cf78756fe736b9d4665d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170598
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-07-20  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [45c45e97e1b3a54689557644edd2ea6c3e6af149]

        CairoSDPR: make use of RGBA PolyPolygon in more cases
        
        Change-Id: I7cd93e5452bce96eef295c766f4cb391ddd67250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170792
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0eb68857daef5b0fcda8bfe501d3f0a683590a1f]

        ofz#70412 Integer-overflow
        
        Change-Id: I3c12382110fa9a22474adba12c6e5772e45c65e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [07cc2fdc3d447479ca3afd2f91c9bc80be745dff]

        tdf#162115 Add intl data for Firebird
        
        Change-Id: I1dff81bc1ae8e794279b217cced042783293635d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170791
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1edfbb310889d18cdd19aa8b339a510ffb25cf66]

        tdf#136637: handle SQLException in OStatementBase::disposing
        
        The problem was unhandled exception thrown from destructor, resulting
        in a crash.
        
        Change-Id: Ib9d2deb2fe9745bf8df060c4e5bf6436b4ca468d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170790
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0999687367a673d08d836c1cd47b4b0339d7ee2e]

        cid#1607830 Use of auto that causes a copy
        
        and
        
        cid#1607722 Use of auto that causes a copy
        cid#1557606 Use of auto that causes a copy
        cid#1557569 Use of auto that causes a copy
        cid#1556239 Use of auto that causes a copy
        cid#1556043 Use of auto that causes a copy
        cid#1554961 Use of auto that causes a copy
        cid#1554818 Use of auto that causes a copy
        
        Change-Id: I9f74c7bc4da2c6b1df80d0fb4504dd4d03eb1053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e93e4ac7cdf135b5c331bba7feb4b884ba7441c]

        RES_PAGEDESC does not need to be a surrogate pool item anymore
        
        Change-Id: Iba1ed6c0791196708b18fefeb2839601bd3df61e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-20  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [7297b0788f8f20ba6ab0973f944a4d522d666108]

        CairoSDPR: Support direct RGBA paint of PolyPolygons
        
        Change-Id: Id1480297126bcc422945df7cd47993cc7fe5c22a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170768
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-20  Patrick Luby  <guibmacdev@gmail.com>  [926ed71244c20d5a96d0f20b7c4edfb9e645a667]

        tdf#161729 clear style sheets in same order as they were added
        
        std::vector::clear() appears to delete elements in the
        reverse order added. In the case of tdf#161729, a style
        sheet's SfxItemSet can have a parent SfxItemSet and that
        parent is the SfxItemSet for a style sheet added later.
        
        Deleting from the end of the vector deletes a style sheet
        and its SfxItemSet. If the now deleted SfxItemSet is a
        parent SfxItemSet of a style sheet that was added earlier,
        the style sheet added earlier will now have an SfxItemSet
        with its parent set to an already deleted pointer. And so
        a crash will occur when that earlier style sheet is deleted.
        rxStyleSheet.clear();
        
        Change-Id: I8ce7023fce8b01432cb3c9288a8f83e7a2f0f2d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170707
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6c0db491f000c55e6bf6061d33ba2312b0ec303f]

        tdf#43157 Use SAL_WARN_IF instead of OSL_ENSURE
        
        Change-Id: Id4674025a6abcacd5a8096630908c3e2f7a2821c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168129
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [722d0c8b9df2cddd2f783076ca626329909218f4]

        tdf#43157 Use SAL_WARN instead of OSL_FAIL
        
        Change-Id: I753254e2e6963e78420288d4c4919cb24282ac81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168128
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [78dff684cbf390191516a3c889822a685dbc51c2]

        Fix typo
        
        Change-Id: Ibf0f3b94f1a51f86b53ddbe04aa2ee0900c31e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168678
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e1a351ca191367ed74282a66e53658af66d6e54d]

        Remove now unneeded osl/diagnose.h
        
        followup to commit 57c228803e55ed343c6693de7d0857ad7d3cd9e3
        
        Change-Id: Iebfb23bb65e2bf898bf27f367cc9641f47a14cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167998
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ec758dbfccc9856eacae8db08f5bf9333b9d69dc]

        Fix typo
        
        Change-Id: I197ce7d28e92a9a73ae506c11e407dea838837e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170786
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1b796287df8b3dc40ddd905c6f4822c53b36f9b1]

        tdf#162111: promote integer types automatically
        
        The problem was, that importing an HTML table into Firebird, and creating
        a primary key, called OParameterUpdateHelper::updateInt for each record's
        primary key field.  Since commit c07548447a564b2d142cc439a124b76e6a71dfbd
        (Related: tdf#108057 Use autoincrement for automatically added primary key,
        2024-03-20), the type of autocreated primary key in Firebird databases is
        SQL_INT64, and before this change, OPreparedStatement::setInt failed when
        the real field's type wasn't strictly SQL_LONG.
        
        This allows Firebird SDBC's  integral OPreparedStatement::set* methods to
        promote to larger numeric types capable to represent the values.
        
        Change-Id: I7615c8e9ffa29271d04cf264bb950cb76946dfd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170787
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-20  Eike Rathke  <erack@redhat.com>  [553c128e3fdc4b9612c1150b30d7b89df2ae6fdd]

        Eliminate unnecessary DateTime conversions
        
        Change-Id: I7bda80e01d37ecd8c2d7e3f8b9ad6fac1e74f3a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170698
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-07-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7118f7e8003cf6c5c7244dac1ffd9eaa408e22d9]

        Fix typos
        
        Implementing Christian fixes from comments here:
        https://gerrit.libreoffice.org/c/core/+/169901/3
        
        Change-Id: I66c2e596820f481a78e8129d5e77ac292eb8b925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170779
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [6cbfaee591ffd51a5e10003c09ca80cc751e324a]

        CppunitTest_sd_annotation_tests: remove redundant ProcessEventsToIdle
        
        it's already called inside dispatchCommand
        
        Change-Id: I037fca27b55db2001364fa2b97c661413389f421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170781
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [dea33b0863baa306c61df6fa04c0e9fb1a4ff468]

        tdf#161899: sd_annotation_tests: Add unittest
        
        Also add a test for uno.DeleteAllAnnotation
        
        Change-Id: Icc8cfbad50879b5bc0e9e2b9996666cff0a85cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170780
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-19  Miklos Vajna  <vmiklos@collabora.com>  [d06de2e049761b7b9e8a95f17557d309812f7acc]

        Related: tdf#162072 DOCX import: handle font family for characters
        
        Open the bugdoc, the first paragraph is meant to be sans and the second
        paragraph is meant to be serif, but both of them are serif.
        
        The bugdoc uses the fonts 'IBM Plex Sans' and 'IBM Plex Serif', which is
        not something we bundle, so the font fallback is expected, but the
        fallback should have a matching font family (roman vs swiss).
        
        Fix the problem by implementing support for <w:family w:val="..."> in
        the DOCX import, which was just ignored previously.
        
        Now the DOCX import result in on par with the ODT import result.
        
        Change-Id: I321b9fc6f63126ca5ad61af57af8a5bc7456d5b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170772
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-19  Moritz Duge  <moritz.duge@allotropia.de>  [6fd88230b543e98ff6981472cc075fd7bd2f6d9b]

        tdf#161909: Repair certdialog columns with VCLPLUGIN != gtk3
        
        Second column was broken since commit cd384e2d31f74223948ea70d8aa3c318d3ceeb50
        
        Change-Id: I4351ff2b3c2ca23884ab0f73906bfe120dc4f298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [46e21942bf412eda1750f850c328cb41f1ff70ca]

        configure,curl: enable GSSAPI on Linux/MacOS/etc.
        
        This will link libgssapi_krb5.so.2 which is in krb5-libs (ABI CL1 in
        RHEL8, ABI CL2 in RHEL9).
        
        Change-Id: I2dbaa64e70f4502c5a47c6c85123c94b9ad41277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170758
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3ffd9de3c4bac6bfa46472698e6146713185a3f2]

        resave with latest glade
        
        Change-Id: I9ff2454c5226c224a5211f2b4cb977e84a8c4219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170777
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dfb3b6568292614a6eeedc7aac2973c7fb301e57]

        getting the "manual cert path" throws unexpectedly
        
        OUString sManualCertPath = officecfg::Office::Common::Security::Scripting::ManualCertDir::get();
        
        in CertPathDialog::Init throws rather unexpectedly
        
        since:
        
        commit eca31344795f7dca5b3407c56ab240c11a97c58f
        AuthorDate: Tue Oct 1 15:24:26 2019 +0000
        
            tdf#127909 save manually selected certificate path
        
        Change-Id: Icafb8001e8cae2dff350f2267994d19dd73fe1a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170776
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Attila Szűcs  <attila.szucs@collabora.com>  [352e564dd1de09a04a2fb1f9b40780b305da7c80]

        SW: random ID for new content controls
        
        Make the generated unique ID random for new content controls.
        This way if we copy paste them from different documents,
        they may still be unique.
        
        Change-Id: I2adb6577e08b5798ae88a63b6178352aa76280d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170773
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d54ef79c77fa6537d86850434c1bb6ef5f9b292a]

        don't use GetItemSurrogates in SwNode::FindPageDesc
        
        They are quite slow, and we want to reduce usage of them
        
        Change-Id: Idae1d6035942d29d67269a22b2a771616ea836af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd18aed100405dff88b881c9c8c3e8cf88553dfe]

        don't use GetItemSurrogates in SwPageNumberFieldType::ChangeExpansion
        
        They are quite slow, and we want to reduce usage of them
        
        Change-Id: I5ab3b55e9270419877a08dd1d711ba2fa757a1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170774
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ee4b0339c3f3fd2f39f7193e2cf54df63a071b6]

        reduce cost of dynamic casting in SdrMarkView::CheckSingleSdrObjectHit
        
        which shows up when navigating large complex documents with
        lots of shapes
        
        Change-Id: I0631daf1365387f1192815402921ada191ab6046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170760
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f3379949100367532d63d29731cd77a222d0606e]

        Fix typo
        
        Change-Id: Iafef7f75454b20e941ab149035284927d6dc28f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169479
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [beaea6538f14e7681162f4828b9d0e6c6e58b43c]

        Fix typo
        
        Change-Id: I1b4316e9b02acbea96b596b26005bf1c774f9f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169228
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9653335b8730a73c06e11c0eb7f7e59882499f5b]

        Fix typo
        
        Change-Id: Ic8196943a5b24541642a117555c2d695fb848db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170754
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [99c660a95cb431b4c0330ab4fba54a5eef2e24b6]

        Fix typo
        
        Change-Id: I3116ab658b21b0069c8b5f8e87723bbf4b84572e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170755
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [3b7b1fedd7ad46c875f14ad779460e25ff1bf5cf]

        uui: improve Authentication dialog
        
        "Remember password" will also remember whether the "Use system
        credentials" was checked.  Rename it to "Remember credentials" and place
        it at the bottom of the dialog.
        
        Change-Id: I672715edfa2080a325a0c492b53d6461591e1192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170752
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f0b9cec9274b5770ec6f78ec958b2ce08baf9260]

        Drop obsolete "Ideas for an UNO bridge implementation"
        
        Change-Id: Ibf1de9cf8dc18e62b5ee67b31a8e3f3748c3941b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170769
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [9a3018ee0bbf6e4a1c99f622fa9920d5bdb1ed46]

        android: Drop unused import
        
        Change-Id: Idd578c2f1a984f1ecb9618ddfa8563cc467a6af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170767
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [2546dd1b28855c97fde9994925cf4279371de672]

        android: Drop unused ViewportMetrics class
        
        There's still the `ImmutableViewportMetrics` class that
        actually gets used.
        
        Change-Id: I4645a33812441a2de36d666423742b164da76bda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170766
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [f1a130a87a24ee5da37b51c7ab68c461d736ed37]

        android: Drop unnecessary semicolon
        
        Change-Id: I6e47003e4c890da9c09b23f64a0e2eac24d2e6bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170765
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [2180a868ccfaeb376ad13f8cff8dbdd3b0c5a5cf]

        android: Drop unused TextLayer class
        
        Change-Id: Id4be67dc7c3ac7ad7a820fca6af730c776ec88f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170764
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [74d1b4e2d6183d641300653c9ba6786de12ae470]

        android: Drop unused local var
        
        Change-Id: I31f02d8fbc0bb3b5b5cd57665ebd2c02138b654e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170763
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [d8f08430c1b416fc57fd613def060b13f905a591]

        android: Drop unused imports
        
        Change-Id: Ic7f38227d982d1f402b12df85cf37fcda2558ad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170762
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [f9f1e215cb61aea91d3e22cb5b91603a5d78c203]

        android: Drop unused IntSize#nextPowerOfTwo(float)
        
        Change-Id: Idec5616195875e4adec22a193d8d8a569de079e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170761
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [2dad8286cf0b8630e4f3c7aeaa9d30141525292f]

        improve doc for SwFormatPageDesc
        
        based on a comment from vmiklos
        
        Change-Id: Ic627ec5eeee35c8a81854e083814c57c151bac13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170770
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db2a7489fa7ac758c1ab35f49fff284f460c5d4c]

        Resolves: tdf#161662 use some hackery to bring bullet combobox height down
        
        There are some Arabic, etc numbering options in there that cause gtk to
        allocate a large odd-looking height for the combobox.
        
        What we can try is to remove top/bottom padding for this widget, but
        then sync it with a sizegroup to another combobox and then it gets a
        more natural looking height.
        
        Change-Id: Idecbb3ee7b61fe55805d26cabdbaf1885574b3cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d924018f3ea58050081936bde067391714a8bb5]

        don't use GetItemSurrogates in SwFrame::GetVirtPageNum
        
        So lets implement this just by walking the document node structure.
        I have tried to limit how much of the document this method now scans,
        to avoid it also turning into an O(n^2) problem, but I might
        have missed something, so
        (a) the loop might be too conservative, in which case
        performance could be better.
        (b) the loop might not go far enough, in which case we might see
        bugs with virtual page numbers.
        
        This shaves 10% off the rendering time of large complex docx
        documents.
        
        Change-Id: I69711c65197caf278bd3ad2931c4817e72b28c5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170451
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5915280c4193ba6a129ddb4f7ad911f106873ffa]

        Fix typo
        
        Change-Id: I005cbaafeb3f630bd5e5713181aa1ea64ae22ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170757
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [2648907f51e230627f3a5b767b19985231a68412]

        make pop-up on Encrypt With GPG Key modal
        
        Not setting any parent window for XDocumentDigitalSignatures
        causes the key selection window to be non-modal, letting the
        user keep editing the document without completing the
        encryption interaction.
        
        Change-Id: Ic7e66cb43606355beaffc720b7c23cdf4f81d934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170630
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-07-19  Justin Luth  <jluth@mail.com>  [f8c68d3499512a7f559fa990ec8a1648e3a7e5d5]

        related tdf#134204 : notify change unless all properties are handled #2
        
        This patch is the biggest logic change in this patchset:
        - no notify if single property (!pNewChgSet) didn't cause a change
            -bContinue can now be set false - avoiding a false notify
        - multiple properties: don't block notify
            -by doing this, I can remove my earlier fix.
        ------------------------------------------------
        Here is my logic:
        
            else if( pNewChgSet )
                bContinue = false
        simply was incorrect logic. There is no way we can say that
        no notification is needed simply because one property is unchanged.
        AT BEST (which will be done in a follow-up patch)
        we will need to track how many bContinue = false's there are
        and see if they match the number of properties that were passed.
        But sufficient should be to only block when Count == 1,
        like pOldChgSet now does.
            bContinue = pNewChgSet->GetChgSet()->Count() > 1;
        
        The variable pNewChgSet had been used earlier because it then
        was checking if pNewChgSet->GetChgdSet...
        But we can easily substitute pOldChgSet here, becoming
            else if (pOldChgSet)
                bContinue = pOldChgSet->GetChgSet()->Count() > 1;
        
        There are three mutually exclusive code paths to consider:
           pOldChgSet, bNewParent, or just a single property
        Since bNewParent overrides bContinue elsewhere, ignore it
        and it also doesn't make sense to continue for a single property,
        so this could simply become
            else
                bContinue = pOld... && pOld...->GetChgSet()->Count() > 1;
        which is identical to the bContinue in the if clause,
        and thus they could be combined.
        
        Change-Id: Ifa5ba56226f4e77a00f3bc8089a8dcaaca2b91ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169898
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [188218fbe8ea412c371e94b7cfe69669a1b93d11]

        Fix typo
        
        Change-Id: I7a2a583f7646a6d881fecc47ba4cf9158d6d8dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170756
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95100bd7326131c519ce98f4c14d3a676bb24fc4]

        cid#1609598 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554697 COPY_INSTEAD_OF_MOVE
        cid#1554709 COPY_INSTEAD_OF_MOVE
        cid#1554764 COPY_INSTEAD_OF_MOVE
        cid#1554804 COPY_INSTEAD_OF_MOVE
        cid#1554821 COPY_INSTEAD_OF_MOVE
        cid#1554833 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3ee0bf523b1c8dfde3674ac5088abe5182cbfb34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3a018f568beab436ea360bbb24d9730973d1d531]

        Fix typo
        
        Change-Id: I4eb00c710a940371b2916ae52127f1ff7f808427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170501
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7be0d9dfe5934f11368e979c6245d2de917d1abf]

        Fix "lets" -> "let's"
        
        Change-Id: Ie9b6961a2786a518876db7b26258e67e8afee848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169760
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-19  Miklos Vajna  <vmiklos@collabora.com>  [cb3ab04adaed834341f6324c7e77f46f56f1f049]

        CppunitTest_sw_uiwriter3: avoid font fallback in testTdf133967
        
        I'm not sure when this started, but the testcase fails with:
        
        - Expected: 6
        - Actual  : 7
        
        I.e. the initial page count is meant to be more than 1, but we
        explicitly assert that page count.
        
        Once gb_CppunitTest_set_non_application_font_use is set to abort for
        this suite, then vcl says the font fallback is:
        
        vcl/unx/generic/fontmanager/fontconfig.cxx:1195: PrintFontManager::Substitute: missing font: 'Albany' try: Liberation Sans instead
        
        Do that replacement, that restores the 6 pages on load even in cases
        where it was 7 previously.
        
        Change-Id: I0cf40c0cdbbb5c1e894468371ea260f0d15a3e40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170759
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [ed984edae683d82132af6b12e1328a8e3cd67c93]

        libreofficekitgtk: Add include for SAL_DLLPUBLIC_EXPORT
        
        `SAL_DLLPUBLIC_EXPORT` is defined in `include/sal/types.h`,
        so add a corresponding include in
        `include/LibreOfficeKit/LibreOfficeKitGtk.h` before using it.
        
        Without this, Qt Creator's Clang code model would'nt find it,
        resulting in errors like
        
            .../libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx:15: error: In included file: unknown type name 'SAL_DLLPUBLIC_EXPORT'
        
        being shown when editing the file
        `libreofficekit/qa/gtktiledviewer/gtv-lokdocview-signal-handlers.cxx`
        in Qt Creator.
        
        Change-Id: Iedd3490be9de72b931573b305d283d80b25a4645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170749
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca84e561a0d0bce89258671ab32bcf5fb5a4ca29]

        cid#1608321 Double lock
        
        Change-Id: I831db1632e2a8fab9194ffb54df61f55e6304864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3f13edb33f38da7fdf89d1e397f5fe56395b9bd]

        cid#1608112 Copy-paste error
        
        Change-Id: Ia2bb23be913324569e7e5588086f1de52d03fa67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [435b4d01e1b8e42dd57d9e6d3c64c93c20b69ea9]

        android: Drop unused imports
        
        Change-Id: Ie26eb3ee5e068b75912d0392ca81c966972e72bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170717
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [9cd74570a1d85396db039f14e9c58394e328874b]

        android: Drop unused DisplayMentrics#toJSON
        
        Change-Id: I631932c4f4a6d61e89816b5d276bfe8384194939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170716
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [a91464d10f53c4b203ffcae308a5f6fd76220c7b]

        android: Drop unused CairoImage.FORMAT_INVALID
        
        Change-Id: I4cd9aba81129921bae523f8afe182732119471c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170715
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [3ed11168c5a778d0f54de19a341f96f6e55767be]

        android: Make constant final
        
        Addresses this warning/suggestion shown in Android Studio:
        
        > Field 'LOGTAG' may be 'final'
        
        And: Drop an unused import.
        
        Change-Id: I6ce730a80690c2701a91cc7900cc801b370dc605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170714
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [f70a8cc859b2300c7f450dfd21a689dbcaca3ccf]

        android: Drop obsolete '@TargetApi(19)'
        
        Obsolete since:
        
            commit c2fc2c8c7c63ca4e43bca6e8c9b82c50418422d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 5 09:57:22 2023 +0100
        
                android: Bump minSdkVersion to 21 (Android 5.0)
        
        Change-Id: I0b8d115b5be1e066a3232c8297de75ea1cea6cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170713
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [45eb67728fdf587531cce460c88fa45f60318f9f]

        android: Drop unused Event#getTypeString
        
        Change-Id: I5f6d553de58cde78099b503bbf1a958fa0bd8813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170712
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [9e8db6126180c9aff2309c91546e1033f2d3c84d]

        android: Drop unused imports
        
        Change-Id: Ic39f84002e4521a33f8f4209ae64a919b28cb538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170711
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [938d4ceea55d13851234af108c3018c8b19584e1]

        android: Use String.equals for string comparison
        
        Change-Id: I05ea3f7ee488328425743fd96e854f20c84600ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170710
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [aa7605571c62ed333af79aa7414277b6e6d50d39]

        android: Make constant static
        
        Makes this warning/suggestion disappear in Android Studio:
        
        > Field can be converted to a local variable
        
        Change-Id: I710cd83c19fe1f83b756b035f05560974b349d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170709
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [55a62bbfc2f39d673fc802840e4121355dcf1469]

        android: Drop unused mAlpha member from Cursor
        
        Change-Id: I141abc523fb975fde997bdd961840456032fdcfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170708
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e047ccb70fe84baee100b1013585558beefc85e]

        sfx2/qa: remove unused code
        
        Change-Id: I41087f4fc1ab29fb8635b33317390c4b784ae086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170723
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7eaa4868e66293b995ef75b310d3831fc5d1a671]

        cid#1607792 Dereference after null check
        
        Change-Id: Ib0d7380efe77b32c9c49b1d36fbf8c19fa83d783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3693894529856ed0ee84357bf8a5c60d57c8d215]

        cid#1554837 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554847 COPY_INSTEAD_OF_MOVE
        cid#1554850 COPY_INSTEAD_OF_MOVE
        cid#1554857 COPY_INSTEAD_OF_MOVE
        cid#1554860 COPY_INSTEAD_OF_MOVE
        cid#1554870 COPY_INSTEAD_OF_MOVE
        cid#1554874 COPY_INSTEAD_OF_MOVE
        cid#1557899 COPY_INSTEAD_OF_MOVE
        cid#1608424 COPY_INSTEAD_OF_MOVE
        cid#1608402 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iaa6e39cf24cd56cdc4a9be5cbf2b8073a1f635c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170722
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-19  Miklos Vajna  <vmiklos@collabora.com>  [647bbcd7f3adc2146dbb003d80d9811c355f1311]

        Update libxmlsec to 1.3.5
        
        Change-Id: Ibc4328348cba29ae684daa69b4699c1b458b0b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170718
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-19  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [aac4974f2a50ebd34137d0384a5e21567c6ae646]

        CairoSDPR: Direct support for RGBA Gradients (III)
        
        I thought about this functionality again and decided
        to change doing it in a way that will support more
        alpha more directly in existing primitives - that will
        be better for also supporting e.g. PolyPolys with alpha,
        etc. Will need checking of existing usages of e.g.
        FillGradientPrimitive2D, but it's worth it.
        Note that when your primitive processor (usually a
        renderer) does *not* support alpha in gradients
        directly it is now requuired to continue using the
        decomposition (what renderers do automatically when
        calling 'BaseProcessor2D::process' in the default
        case. Checked that for existing processors.
        
        Change-Id: I840c9feb8c98549b790ef16285a309b42c4b1b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170687
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [27198ec7031e9ef3bbc592423e5c12e333e206ee]

        (related tdf#126008) sw: add config to disable table autoformat ...
        
        ... automatic updates when editing the table.
        
        Office::Writer::Table::Change::ApplyTableAutoFormat
        
        Change-Id: I84667c68c9372d7594bb3a688da80495ef46168f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170702
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [1e978fffddc3d7044f3def026340844b59d2d656]

        (related tdf#126008) sw: when removing table auto format, don't...
        
        ... change the formatting.
        
        Change-Id: I50fbb290f0a7f2cccc2559059859fa820d5c9aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170688
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fc08b4aa00e4157e10923bfbc1f4744f0acf5580]

        Fix typo
        
        Change-Id: I8df5045c61bd792a2be0eaae2b1fcdc0bae134d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170703
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8dd2f7609b1b108e185ac6d1bf31f61a05637760]

        Fix typo
        
        Change-Id: Ie99b65cd73fc4c3ab9626723d3be0d0c1f793b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170580
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1a808e205756ae2ad160fd959190abce2a9c257d]

        Remove exec bits on rtf file
        
        Change-Id: I4a297e40f907d2d530e3231f5258eb57791da2db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170579
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-19  AhmedHamed  <ahmedhamed3699@gmail.com>  [5bd284583fe1f891bac3192d8e20083a57830a0a]

        tdf#161296 Convert functions list in FD & FW into collapsible sections
        
        Change-Id: I9211c0cf02be8d21e343d57f53d14e50d7b5fd0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169639
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [24103bdf3fa3d6962efcc6fb6ee5c95b62e29cc4]

        tdf#161501 icon choice ctrl: Use tab text colors
        
        Instead of using the generic window or highlight
        text color, use the specific text colors for tabs
        when painting entries of the vertical tab control,
        similar to how it's done for the non-vertical
        tab control (see `TabControl::ImplDrawItem`).
        
        This is also in preparation for changes to make more
        use of the system colors for the entries.
        
        It e.g. ensures that black text color is used for the
        text of the focused entry with Breeze (light) in my Debian
        testing KDE Plasma 5 setup with Rafael's pending change [1],
        preventing the issue of too low contrast mentioned in [2]
        that is otherwise seen in my setup, but not Rafael's for some
        reason.
        
        [1] https://gerrit.libreoffice.org/c/core/+/170554
        [2] https://gerrit.libreoffice.org/c/core/+/170554/comments/f9d0f988_6a0f5eec
        
        Change-Id: I718d08f717bd896b7fca9fc39eedae68fba4bd25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170677
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-07-19  Justin Luth  <jluth@mail.com>  [b657b6c6c918fb7c239ad835db44de249b1c1763]

        related tdf#125469 docx im/export: better precision percent<->value
        
        A line spacing difference of 1.07 and 1.06 is significant for layout.
        Use rounding to get better round-trippability.
        
        This patch was created based on a code read, finding a DOUBLES unit test
        and having related coding attempts noticing integer precision loss.
        
        make CppunitTest_sw_ooxmlexport13 \
            CPPUNIT_TEST_NAME=testTdf118947_tableStyle
        
        The export change is a blind fix
        (but older LO now opens ooxmlexport13's RT as 1.07% (256.8)
        because we now write w:line="257" (1.07083) instead of 256 (1.066).
        
        The import change is confirmed by ooxmlexport13 (matching Word 2010).
        
        Change-Id: I196af783b80688839c59058feb82bf00d40d9088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170669
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-19  Justin Luth  <jluth@mail.com>  [965d83d3a729b0c01c882e200d8bf18dd347c027]

        related tdf#125469 writerfilter: support negative exact and atLeast
        
        When vmiklos added support for negative auto -> FIX,
        he indicated that there was no documentation for it.
            commit f575f70b8303ba187f6989920281ff02e7a431c9
            Author: Miklos Vajna on Thu Jun 22 13:41:30 2017 +0200
            tdf#108682 DOCX import: fix <w:spacing w:line=...> for negative
                I didn't find UI in Word to create
        
        In working on bug 125469, I hand-crafted a nasty example document
        which had negative exact and atLeast examples,
        and this patch matches what I saw happening in Word 2010.
        Too bad MS isn't completely consistent...
        
        Change-Id: Iaab32aa3f0bbe90dfd0ef8973f9aefd2d6ca3fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170671
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-19  Justin Luth  <jluth@mail.com>  [e3dfb54117f5325d8f38f58ef892c2808d601e54]

        tdf#125469 writerfilter: use "auto" for not-provided lineRule
        
        This fixes the problem where a programmatically generated document
        didn't specify a w:lineRule, and thus the w:line size
        was treated as a FIXed spacing of 12pt instead of as single spacing.
        
        ------------------------------------------------------------
        lineRule (Spacing Between Lines)
        Specifies how the spacing between lines is calculated
        as stored in the line attribute.
        
        If this attribute is omitted, then it shall be assumed to be
        of a value "auto" if a w:line attribute value is present.
        ------------------------------------------------------------
        However, our implementation (wisely) defaulted to ::FIX
        instead of ::PROP (which keeps precision in w:line sizes
        since PROP is a integer percentage instead of a float
        and thus loses precision when switching between FIX and PROP).
        
        Note of course that if neither w:line nor w:lineRule is provided,
        then we go with the LO default of mode=0, height=0 (aka AUTO).
        
        This gets tricky because the lineRule can be inherited,
        so just because it is missing in a pPr doesn't necessarily mean
        we can just substitute "auto".
        
        It is also tricky because w:spacing
        deals with more than just line spacing.
        
        Not surprisingly, no existing unit tests matched this case.
        However, the unit tests were VERY helpful in pointing out
        limitations as I attempted to code the fix.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf125469_singleSpacing
        
        Change-Id: Id5e95f2983f4fb435810d5a1f3fd25ded5118ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170670
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-19  Justin Luth  <jluth@mail.com>  [e4e35dca3f93b4d235731fa5a98d45c9cc8fbd87]

        NFC tdf#125469 writerfilter: move code into SetLineSpacing function
        
        I didn't make any logic changes to the function yet,
        just moved it to a shared location so it can be called elsewhere.
        
        This is preparation for fixing bug 125469,
        and I want to keep the fixing patch clean to show the real changes.
        
        Change-Id: I50a9ad1c61c7e885f40defc38554e0cb2ca51a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170668
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-19  Jonathan Clark  <jonathan@libreoffice.org>  [e9a37656b75b4ce82b3e48af727f03f386e64a08]

        (related tdf#56408) crashtesting: assert on exporting ooo30385-2.doc to odt
        
        since:
        
        commit 6a54d08e6e52623f9769d17d7ea7390052cb275b
        Date:   Fri Jul 5 15:19:23 2024 -0600
        
            tdf#56408 Writer always breaks lines at text direction change
        
            Change-Id: If4627f4d65d2c44b65653c689ee00a2e0cb4456a
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170154
        
        Assertion occurs when underflowing a bidi portion after a field portion.
        When attempting to reproduce the issue in GUI, this was accompanied by
        an infinite loop. This change fixes both issues.
        
        Change-Id: I85f6fa769756138fe000681a4663925ddfc7ed83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170705
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-07-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4dbaa38315605d2051a5127c96c555565e95444e]

        tdf#55693: port test to CppunitTest_sw_autocorrect
        
        so we can get rid of TestAutoCorrDoc, only used for
        test purposes
        
        Change-Id: I0931fa76550358d071ebdec364fd6b55485bb3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170680
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dcd16a4f73edaf59981c0ffc6b165dac5aac36c4]

        Fix typo
        
        Change-Id: I7ce85668113e8f3df983f43a9e584b913f783230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169939
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [49b3245b3e53ccee250e62df69b257abdec4b439]

        Fix typo
        
        Change-Id: Iedb3495fe6cdbcdea9f6a60c004b518665ef4b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170375
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a8a47ab344f29676267feae64c250b3775db5cfc]

        Fix typo
        
        Change-Id: Idaa3bb659133a9bc4d9253d814ab3026ee784af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170503
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fa6e2f1bdde818c5f13d003fb2130ffbff51e0ab]

        Fix typo
        
        Change-Id: Ieedbda914b5272e700a36f691f159f449603f264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170502
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15f015b17a77baa2577306115260c1450a316669]

        Fix typo
        
        Change-Id: I362a6a0802c27d273228725c9023092b7909cdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170642
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5cc3e2fa66b0e0320c1a961594c68ea5338bbfbc]

        Fix typo
        
        Change-Id: Ia6ea67804f637cf89db9569a47fbaf7cca4049ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170576
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a72988bfdbbe7c9d5e27402670dc631384127a5e]

        Fix typo
        
        Change-Id: I16e88e1ecb0174605871031a614285911e6fff58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170689
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-07-18  Miklos Vajna  <vmiklos@collabora.com>  [6dfac38bacd449c64a13363797b56aff49cf8f52]

        tdf#162072 vcl, fontconfig: consider font-family-generic for substitute
        
        Open the bugdoc, it has two paragraphs: first with a sans font, second
        with a serif font. These fonts are missing, but their metadata clearly
        state that they are sans vs serif. Still, Writer renders both as sans.
        
        Investigating a bit, the ODT case imports the "font-family-generic" of
        these fonts fine, but in the Linux case the fontconfig code ignored this
        info when building the search pattern for the font fallback.
        
        Fix the problem by extending vcl's PrintFontManager::Substitute() to
        also take the vcl-level "family type" into account, which is about sans
        vs serif (roman vs swiss). Note that FC_FAMILY is a string list, so once
        the actual font name is added to the pattern, the next "add" will append
        to this list, not drop the already added font name.
        
        The same problem is still there with the DOCX equivalent.
        
        Change-Id: I61f31ae73e524471a5261ac9426e5b566454a09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170681
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-18  Lars Jødal  <lajo@rn.dk>  [d1bcb2f83a068ac27ff9ca43d2b004026e34f934]

        Correcting <aboveWord> and <belowWord> in the Danish locale.
        
        Changed <aboveWord> from 'over' to 'ovenfor', and <belowWord> from 'under' to 'nedenfor'.
        
        In Danish, 'over' is a correct translation if 'above' is followed by an object, for instance 'the caption is above[over] the table'. But <aboveWord> is used for cross-references where no object is following: 'see the figure above[ovenfor].'
        
        Likewise for <belowWord>: one object is below[under] another object, but 'see below[nedenfor]'
        
        Change-Id: Ib428342acf83c5961234aebbd50cb6a4a5d28d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170563
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-07-18  Michael Stahl  <michael.stahl@allotropia.de>  [f2ec0058ec60da4f3617b5d68373946e4cfd1c0d]

        solenv: gdb: adapt ItemSetPrinter to unordered_map
        
        (regression from commit 290c8f6e048fedf63437e3fdf629555ac89dd3ad)
        
        Change-Id: I85f3dd2a719d13f35cf7246e0787604ddb9f47fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170685
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [23ee72264ed802dc7839c1ae73b1b14382cf1f33]

        make ScRange single-arg constructor explicit
        
        Change-Id: Ie24e1e601b639dd62dbb8a201378a970699b20ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170686
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [91bedcab61424cdfb2f3ba9e48481406fe141ceb]

        Change from Module.intiUno() to Module.uno_init promise
        
        ...that is resolved from within C++ Desktop::InitApplicationServiceManager once
        UNO is fully initialized, so client code can trigger on
        Module.uno_init.then(...)
        
        Change-Id: I2d4c542d9729d09f434502e3f966e9ee474e926c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170683
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-18  Michael Stahl  <michael.stahl@allotropia.de>  [a7c1163684fa5c0376efebe8dc6225a7dfb8e700]

        (related tdf#126008) sw: allow removing table autoformat from a table
        
        ... via the Table->AutoFormat Styles... dialog:
        add a "None" option like already exists in Table->Insert Table...
        
        Change-Id: I41d5cb0a7dcd1bfe3e93fe56f0f42765149ff42b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170641
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-18  Noel Grandin  <noelgrandin@gmail.com>  [7f5a7ef6384956a6089f1def275a86cb7024c568]

        make UStringLess single-arg constructor explicit
        
        Change-Id: I0fb4723fa878f8ebdbe5ac0fe080559ffd4736dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170679
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0705c05480401fd46349879ad456ae208cb1180b]

        make some single-arg constructors in starmath explicit
        
        Change-Id: I4b9a010a2cf42076b02c80732c8e35686482f9e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170684
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c997461bfa0bb40189a96f478cb80e5b4d8a1dc]

        make XFCellListener single-arg constructor explicit
        
        Change-Id: If519af401dca2ec77ff448409888bbc2871a0c9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170682
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-18  Noel Grandin  <noelgrandin@gmail.com>  [cd3382cd727f905723c95167733836a90a89a101]

        make EditSelection single-arg constructor explicit
        
        Change-Id: Id7a81db385dd3ca30daa37ba74a82d06c417a51c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [1d1f47e6ca6367bf8fb828dd09cce197a96f643c]

        tdf#162006 Use contrast outline for the AutoFill/Cursor handle as well
        
        This patch draws a white line around the AutoFill handle for better contrast.
        
        It also adds an internal white outline to the cursor overlay.
        
        See bug ticket for screenshots.
        
        Change-Id: I1567d272fd5a2835192c50973e84cb8c269fb04e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170354
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-18  Michael Meeks  <michael.meeks@collabora.com>  [7635a5eefdca16d40c4d78cfe9e102cacec96977]

        lok: joinThreads - take down configmgr's write-thread.
        
        Change-Id: I1f9b6b88ef7e97da02fecf2035f953584cd28c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170674
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ad383c896ab9a003c9ba9b891c3c20cb41cd9cbf]

        use the new linker on macOS (introduced in XCode 15)
        
        the classic linker will be removed in upcoming versions of XCode and is
        deprecated
        XCode 15.0 has a bug that would cause runtime crashes on macOS 11, but
        that bug has been fixed with XCode 15.1 and all users of XCode 15.0
        could update to 15.1 or 15.2 (15.3 or later requires newer version of
        macOS) - so remove the workaround of using the old linker and instead
        require a fixed version of Xcode (or a different minimum deployment
        target)
        
        Change-Id: If516ac85539da83f54b1792450cf43ea55d0d808
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170640
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-07-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3dcc288468eb2a71ba1381412dd7e25b9fb329d9]

        cid#1555824 Check of thread-shared field evades lock acquisition
        
        Change-Id: Ic0e8e87138ca86a1618e110516f3d8cef481dec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170626
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec96dfdf2cf478c3f38873e1c4f01564ebb19b71]

        CppunitTest_package2_test: Add unittest for 0fb25ce9ff9a3
        
        For that, use a minimal oxt file with no funtionality
        
        Change-Id: I5f72e0d0362451a7d0069ad3f9d0626c43ff9d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170665
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-18  Justin Luth  <jluth@mail.com>  [cafb0235fde21065770fd34a36b97c738c4174b0]

        related tdf#134204 : notify change unless all properties are handled #1
        
        This is an NFC-ish patch.
        
        SetFormatAttr immediately calls a ClientNotify
        about the single property that it has changed.
        So if this was a direct property change,
        or the set included only one property,
        then there is no need to re-notify about this parent change.
        
        The problem with the logic so far has been a failure
        to notify about changes. In this patch, we had the opposite
        problem of notifying unnecessarily, which isn't terrible.
        The main benefit will be seen in a follow-up patch
        which allows a single bContinue assignment per property.
        
        Change-Id: I51d961f03910f0b8f50c6402894c5269f15bf00d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169897
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-18  Noel Grandin  <noelgrandin@gmail.com>  [3519027515b7ba66aa5303311916b951a8f29e4c]

        make date/time single-arg constructors explicit
        
        Change-Id: I943f755d95b90ef8aeb7d5b339f617ff50db4e29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b97e1d6c119bd58966df5d87d853f62bc06b7b87]

        Fix typo
        
        Change-Id: I391cdffe679f664af8cdb0fa3ce0b987232e422c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170597
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f60a6fa11d8ef5227abec6d59b359ea16bc1f795]

        make SwFormatPageDesc single-arg constructor explicit
        
        because I spent a couple of hours on a compile failure trying to figure
        out what was calling what, because of the implicit construction that
        happens here
        
        Change-Id: I974ec06325c518d47f40c497786b9d6d8a1f1924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170628
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-18  Michael Weghorn  <m.weghorn@posteo.de>  [43f0022fcaed2d9d1b1b3707173acd562c7f0ebe]

        tdf#155447 macOS a11y: Report accessibilityIdentifier
        
        Implement `accessibilityIdentifier` [1] for
        macOS/NSAccessibility by retrieving the accessible ID
        via `XAccessibleContext2::getAccessibleId` if that
        interface is implemented.
        
        This is the macOS equivalent of
        
            commit c64b823b74cbd3063d6e87643bd68ea5343b2f54
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 16 13:57:41 2024 +0200
        
                tdf#155447 qt a11y: Report accessible ID
        
        [1] https://developer.apple.com/documentation/appkit/nsaccessibilityprotocol/1527792-accessibilityidentifier
        
        Change-Id: I43c40f5309467ddb00911297fadb6716500c2dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170624
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-18  Adam Seskunas  <adamseskunas@gmail.com>  [d5d4e1334957abc29c5c4f543a8cd15a5aaf8748]

        tdf#71749 Unit test for sw: WW8: don't loop on tables in footnotes
        
        Change-Id: I5ca830b2ec0c883a23bab1ece006f8c88310f3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170169
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4504d921a6ac45617ab700316182e68c3248a045]

        cid#1555694 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555695 COPY_INSTEAD_OF_MOVE
        cid#1555696 COPY_INSTEAD_OF_MOVE
        cid#1555705 COPY_INSTEAD_OF_MOVE
        cid#1555711 COPY_INSTEAD_OF_MOVE
        cid#1555713 COPY_INSTEAD_OF_MOVE
        cid#1555727 COPY_INSTEAD_OF_MOVE
        cid#1555742 COPY_INSTEAD_OF_MOVE
        cid#1555745 COPY_INSTEAD_OF_MOVE
        cid#1555749 COPY_INSTEAD_OF_MOVE
        cid#1555760 COPY_INSTEAD_OF_MOVE
        cid#1555773 COPY_INSTEAD_OF_MOVE
        cid#1555774 COPY_INSTEAD_OF_MOVE
        cid#1555778 COPY_INSTEAD_OF_MOVE
        cid#1555790 COPY_INSTEAD_OF_MOVE
        cid#1555831 COPY_INSTEAD_OF_MOVE
        cid#1555847 COPY_INSTEAD_OF_MOVE
        cid#1555851 COPY_INSTEAD_OF_MOVE
        cid#1555853 COPY_INSTEAD_OF_MOVE
        cid#1607763 COPY_INSTEAD_OF_MOVE
        cid#1607504 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I991f15f12e773d325ed9725498df5725b049a858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170625
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [499141ecf2c3a0ece03e0c4ad01f4575c92869c8]

        Restrict SAL_RET_MAYBENULL to LIBO_INTERNAL_ONLY
        
        ...at least for now, as long as it is not needed in any published UNO include
        files
        
        Change-Id: I25a1697e1b9ffa5afce0e29cc64be66bf2ebbc57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170637
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88d10b3344d03860b470da236a64304564c1a558]

        cid#1606633 Overflowed constant
        
        in the end, it doesn't make sense to allow either of these to be 0
        
        Change-Id: Ie07620c9a168876abd7532a6f52bc7ebd12b83c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Patrick Luby  <guibmacdev@gmail.com>  [ee76e5041c79843ef0942c6427d4cd3717820ff6]

        tdf#162062 only apply fix for tdf#161833 if there is a palette
        
        Change-Id: I50d13ed336110eb5e65e99dd5d4a6c6defe6bc50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170627
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-07-17  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [0c6642ed3a2dbcd54456f61706606fa3371b70ba]

        vcl: support for Windows ITaskbarList3 interface
        
        And a demo implementation for these features as a taskbar window
        will become red once LO is displaying any error message.
        
        Change-Id: Ifc04026c699059da2e457de2c69e7363e756109c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166740
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-17  Moritz Duge  <moritz.duge@allotropia.de>  [a7327e95cee60d59bdec1b62e144179efa9f2eb8]

        xmlsecurity: Add UItest (save GPG encrypted ODF)
        
        Change-Id: I09dd13334e0d3da5f6004312bae69b5c77120434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167904
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d82fffff53e824b571fd7b7c65c51324ddf9549e]

        cid#1555302 Different smart pointers managing same raw pointer
        
        ScUndoWrapper::ForgetWrappedUndo resets the std::unique_ptr
        and deletes the owned pointer, that's not what we want to happen here.
        
        looks to have gone wrong in:
        
        commit 9767537e22e178eb23872de138ea70e57c1a6725
        AuthorDate: Tue Jan 17 10:11:31 2017 +0200
        
            new loplugin: useuniqueptr: sc part 2
        
        Change-Id: Ib4a7d615bc2e354f76b044b5b5e5d2f17dbebf0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170632
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bc5c936e18ccfe20f219c8bf92bf6652d965269]

        cid#1606961 Overflowed array index read
        
        using a constexpr sal_uInt16 for the eMax limit, and dropping
        o3tl::narrowing might be enough to clear this bogus warning
        
        Change-Id: I6f7fd468333b39d597eccacf37e6a64926dfc015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6449247af9b5509723f2c0e616504b468e2afc49]

        cid#1606549 Dereference null return value
        
        Change-Id: Ic9c25d9b4ac3d8e368848cb9bbc42f5076bc321f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [4058ca814a794cc80a4ebb2089df95798b2de85e]

        tdf#158803 related: remove unnecessary comments
        
        Change-Id: I25093100db0473bb907036b4f80e1bbc440cfb8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170639
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [68a96f747345dd55bcb6abdd8eee0e2d9768c9ec]

        Use IsRunningUnitTest / IsRunningUITest consistently
        
        The functions are moved to o3tl as inline functions.
        
        Change-Id: Ief7d7e292ef15e055ad04ab5707e5e6a2a05b916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170636
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a20a894b0752e5b7f28547ed9a90570739e8bea]

        cid#1608071 Out-of-bounds access
        
        Change-Id: Ia258bb10c015150f3ff8f978e975a033e981aa92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [69586e8381037417d106d8474d9f73638c5b9c55]

        UI tests: use a dedicated desktop on Windows
        
        Similar to commit 1f24d35033c2f02335ce254bbcf6ba89e1b7565e (cppunittester:
        use a dedicated desktop on Windows, 2023-07-09), this change allows to run
        UI tests on Windows without them interferring with what you are doing.
        
        The code testing LIBO_TEST_DEFAULT_DESKTOP environment variable to avoid
        the separate desktop, and creating it, is extracted to a new function in
        systools.
        
        Change-Id: I6df3cb4ae581ae289e49b47d3135d01f632fbd95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170615
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-17  Jonathan Clark  <jonathan@libreoffice.org>  [aa938fe03cfb968f7f4ed9760dcbe579a74bdc02]

        tdf#150621 Changed Korean word counting to use words
        
        Previously, Writer counted characters for all CJK languages, rather than
        words. This is the correct behavior for Chinese and Japanese, which make
        extensive use of ideographs. However, it is not correct for Korean.
        
        This change adjusts the Writer word count algorithm to count Korean
        words, rather than Korean characters.
        
        Change-Id: I6e77136867baca1a7b51248886ee5fd7073ad364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170621
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-17  Justin Luth  <jluth@mail.com>  [c9a96f272430a8ba5a29207d3365354c82d08e60]

        NFC tdf#134204: ensure style modify signaled if parent changed
        
        If the parent changed, we have no idea how many properties might
        be involved. Therefore, there is no way that anything could
        legitimately say that we haven't actually changed/don't need to notify.
        
        This is a No Functional Change.
        bContinue was never set to false when bNewParent.
        bNewParent and pNewChgSet are mutually exclusive,
        and the only other time bContinue was changed was if pNewChgSet.
        
        So this patch is just a simplification.
        It more clearly shows that the notify should always happen,
        and is helpful to demonstrate logic changes in the following patches.
        
        Change-Id: Iabef5ba305c80d68655a0c880301ab32ffc90792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169896
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [69e7000ed420faf513002076089aca82bddfbc28]

        Simplify checking for "running under unit/ui test"
        
        In various places, the code checks if we are running as a unit test or a
        UI test. This code grew organically, and is most re-using environment
        variables that were designed for narrower purposes.
        
        Rather than being clever, just add two new explicit and simple
        environment variables in the natural place (the command that runs them),
        and check for those variables in the code.
        
        Change-Id: Icce0997914fa0be30a5ac1f29bd870bdb5893a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170618
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c1b00424f17eaea8f55565dae285521c1ec4d042]

        fix raptor build when using system-icu
        
        Change-Id: I1671e5872deb583c1c0395ab49ab33b171d0e086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170620
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de4be295993f6bdd255475604056ad3f48478fb1]

        Resolves: tdf#158753 GtkAssistant loses current page on hide+show
        
        gtk_assistant_unmap ...
        {
            ...
            priv->current_page  = NULL;
            ...
        }
        
        gtk_assistant_map
        {
            page_num = 0;
            ...
            set_current_page (assistant, page_num)
            ...
        }
        
        It doesn't automatically restore itself to the page it was on
        when it was hidden, so do that explicitly.
        
        Change-Id: If23b255193c4a65b286e036c8796d9d8a2ffcb5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170611
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-17  RMZeroFour  <ritobroto04@gmail.com>  [5aeb53c4b09e8c5fa8f67268e97cce00cab0f186]

        tdf#137525 Update ColumnValueSet (and others) to use push/pop
        
        This patch updates the ColumnValueSet and some other parts of the
        drawing code to use the Push/Pop functions of RenderContext.
        
        Change-Id: I3fbdee9afa167facb45242bc8bad9a35758b3c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165587
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-07-17  Michael Stahl  <michael.stahl@allotropia.de>  [0fb25ce9ff9a3ede8d43ee1502c44b4c02135b3f]

        package: don't check case insensitive duplicates for ZIP package
        
        Turns out there's a TexMaths extension that contains files with names
        differing only in case.
        
        https://ask.libreoffice.org/t/zipexception-when-installing-an-extension/108256
        
        There isn't a separate ZipPackage mode for OXT so just don't check in
        the ZIP mode.
        
        Change-Id: I7680c93f5f24ac566a59b131b36d855bd85100b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170616
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2f4d06747b533d962078cd25370f433037098359]

        Remove exec bits on rtf file
        
        Change-Id: Ic975ecb00db43fadb3134a592e9d6fe5cd0f847b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170578
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [33b80794ce49bc2f0a35afce6406a8ca497987ce]

        Fix typo
        
        Change-Id: I38bd197f3531b0caa4ae08ce617f0b79e66c183a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170577
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-17  Noel Grandin  <noelgrandin@collabora.co.uk>  [b7b1013fa7ce85090763565426d10cb6435e4a53]

        fix skia crash (tdf#160646 related)
        
        while testing the document attached to this bug I get a repeatable
        skia crash (only skia is in native mode, not software rendering).
        
        This reveals that there a couple of data structures that need to
        be cleaned up while holding the SolarMutex.
        
        Change-Id: I3ff460a4febf1ffcb27ad904224e1594ead4aa3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170612
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [97b827aa6135fa95235742122d49222b3c1b9109]

        android: Port from deprecated "archivesBaseName"
        
        Port from deprecated Gradle API that is planned to
        be removed in Gradle 9.0, as was warned about in the
        build output previously:
        
            > Configure project :
            Script '/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle': line 22
            The org.gradle.api.plugins.BasePluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#base_convention_deprecation
                    at liboSettings_bbauwf0uak693a4tmdwwty192$_run_closure3.doCall$original(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:22)
                    (Run with --stacktrace to get the full stack trace of this deprecation warning.)
                    at liboSettings_bbauwf0uak693a4tmdwwty192.run(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:20)
                    (Run with --stacktrace to get the full stack trace of this deprecation warning.)
            Script '/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle': line 22
            The BasePluginExtension.archivesBaseName property has been deprecated. This is scheduled to be removed in Gradle 9.0. Please use the archivesName property instead. For more information, please refer to https://docs.gradle.org/8.7/dsl/org.gradle.api.plugins.BasePluginExtension.html#org.gradle.api.plugins.BasePluginExtension:archivesName in the Gradle documentation.
                    at liboSettings_bbauwf0uak693a4tmdwwty192$_run_closure3.doCall$original(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:22)
                    (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        
        As described in the upgrading guide [1], use the "base"
        configuration block in build.gradle instead.
        
        [1] https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#base_convention_deprecation
        
        Change-Id: I358569a72b508efd31d2872d5009ac4f060398d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170610
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [89fd1a2adaa05329eead62573a084238e5e57ebf]

        android: Show all gradle warnings
        
        Set the gradle property to show individual warnings during the
        build. Without this, the build output showed:
        
        > Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
        >
        > You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
        >
        > For more on this, please refer to https://docs.gradle.org/8.7/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
        
        Now, it shows the individual issues that need to be addressed:
        
        > > Configure project :
        > Script '/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle': line 22
        > The org.gradle.api.plugins.BasePluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#base_convention_deprecation
        >         at liboSettings_bbauwf0uak693a4tmdwwty192$_run_closure3.doCall$original(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:22)
        >         (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        >         at liboSettings_bbauwf0uak693a4tmdwwty192.run(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:20)
        >         (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        > Script '/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle': line 22
        > The BasePluginExtension.archivesBaseName property has been deprecated. This is scheduled to be removed in Gradle 9.0. Please use the archivesName property instead. For more information, please refer to https://docs.gradle.org/8.7/dsl/org.gradle.api.plugins.BasePluginExtension.html#org.gradle.api.plugins.BasePluginExtension:archivesName in the Gradle documentation.
        >         at liboSettings_bbauwf0uak693a4tmdwwty192$_run_closure3.doCall$original(/home/michi/development/git/libreoffice-WORKTREE-android/android/source/liboSettings.gradle:22)
        >         (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        
        Actually addressing them still needs to be done separately.
        
        Change-Id: Ib749e9e21d3d5f5893c348a5070a1e994a395c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170609
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [27f1851eb2452a25358d455de2566dc4f651c2b7]

        android: Set minSdkVersion without "="
        
        Addresses this warning shown in Android Studio:
        
        > Do not use assignment with the minSdkVersion property (remove the '=')
        
        Change-Id: I2d9e7037f7fb6e4d1625a8625a1b3820fb6e205f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170607
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [053d9feec432ca4dff4d85593d9cad0d975388b3]

        android: Handle cursor keys
        
        In Android Viewer, forward the left/right/up/down keys
        as such by adding the corresponding mapping to
        `LOKitTileProvider#getKeyCode`.
        
        This allows navigating through the document using those
        keys e.g. on a hardware keyboard.
        
        This addresses this comment from a Google Play Review:
        
        > Editing, the cursor doesn't respond to the cursor keys
        
        Change-Id: I688e5d0cc1db4f9315f9c9cb2139c22117a210e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170605
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [a360543249fb850ec2fa5f26102d5cc270b6b870]

        android: Update Android Gradle Plugin to 8.5.1
        
        ... and gradle to 8.7, as suggested by Android Studio.
        
        Change-Id: I572c1e0d62a477278fd63e613610d8d422d14a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170601
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-17  Miklos Vajna  <vmiklos@collabora.com>  [8af3bab06ed27a01df370bb5f79e5f15892e778d]

        Related: cool#9504 sw: don't invalidate num rules when pasting into bullets
        
        Open the bugdoc, navigate to the last para of the first page, enable
        bullets for that paragraph, paste a one-liner plain text string, observe
        a 274 ms hang.
        
        Commit dc3e022866893d8c0950f2269c0c8d61c24ed9bf (cool#9504 sw: don't
        invalidate num rules when pasting into a non-num paragraph, 2024-07-15)
        already fixed a not needed invalidation when pasting plain text at a
        non-list paragraph, but here the insert point is part of a list, so we
        still invalidate.
        
        Improve this further to also not invalidate when we paste a paragraph
        which is part of a list, but the numbering type is a bullet, which again
        doesn't need an invalidation.
        
        If the invalidation still happens, then the LOK case still calcs the
        entire layout in one go, that's not yet fixed here.
        
        Change-Id: I97c92aebb67ba8ca66b5820943dc1550d62bb467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170606
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a24a534ad05472a2fae03b85ff650f30efe66d2d]

        Missing gb_Library_use_libraries,embindtest
        
        ...which went unnoticed for this Emscripten-only library due to the static
        nature of the Emscripten build, but is probably better to do properly anyway
        
        Change-Id: Ie0e0b463057fbc60e17741f362a129f784f7154d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170603
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-17  Attila Szűcs  <attila.szucs@collabora.com>  [84d63cfccf7af8f2b3b689ab0e622f8b408eb470]

        Sw: extract/transform document structure 2
        
        inserting a ContentControl, now generate a unique ID for it...
        search the lowest possible non used (non negative) number
        
        added a GetType() function for SwXContentControl that get it from
        SwContentControl, and used it for extract and transform.
        
        Added some support for all other types.. some are not really usable
        yet.
        
        Fixed a problem when setting checkbox check, did not changed its
        content.
        
        If content is set to “”. It now set as placeholder,
        and reset its content to the initial placeholder value, like:
        “Choose an item” or  “Click here to enter text”
        (work for checkbox, and picture CntentControl.)
        
        Change-Id: I0fc696f73734bdfb9ac5b8fdc6891168b8d4ed5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170600
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ddcc9515bc4313b580fad6474b603266ef2b9c15]

        Resolves: tdf#161989 unset gtk emphasis defaults to light
        
        Change-Id: Id347671ed7f9b1b36c29578566c4a82e9181aeb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170594
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bee938aaa2d7aab824496ad2fcebe6620c00beb7]

        Fix typo
        
        Change-Id: I702043c566f79a81c6b40b7062cd1a83dcdaf652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170575
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [8495e77f4d49733f645cdacfb71729b91e5c4f30]

        tdf#155447 gtk3 a11y: Use GtkBuilder ID as accessible ID
        
        Set the GtkBuilder ID (the ID set in the .ui file)
        as the accessible ID of the GtkWidget for welded
        widgets in the gtk3 VCL plugin.
        
        For non-welded widgets, that would happen
        in `atk_object_wrapper_new`, similar to how
        
            Change-Id: I2281d15c38a229410469c29a14fdc4221aeb3e1e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 16 13:57:41 2024 +0200
        
                tdf#155447 qt a11y: Report accessible ID
        
        implements it for the qt6 VCL plugin.
        
        However, since native widgets are now used
        almost everywhere for the gtk3 VCL plugin,
        the implementation in `atk_object_wrapper_new`
        does not take effect for most of the UI, including the
        spell checking dialog mentioned in tdf#155447.
        This commit makes sure an accessible ID is set for
        such cases as well.
        
        Using the GtkBuilder ID is also mentioned
        in the `atk_object_set_accessible_id` doc [1]:
        
        > Sets the accessible ID of the accessible. This is not meant to be
        > presented to the user, but to be an ID which is stable over application
        > development. Typically, this is the gtkbuilder ID. Such an ID will be
        > available for instance to identify a given well-known accessible object
        > for tailored screen reading, or for automatic regression testing.
        
        GTK 4 currently doesn't have API to set an accessible ID.
        
        [1] https://docs.gtk.org/atk/method.Object.set_accessible_id.html
        
        Change-Id: I6061888f38aa40a0d3c4e680b7daa1649d5954e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170586
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [c64b823b74cbd3063d6e87643bd68ea5343b2f54]

        tdf#155447 qt a11y: Report accessible ID
        
        For Qt >= 6.8, report the accessible ID provided by
        `XAccessibleContext2::getAccessibleId` when
        `QtAccessibleWidget::text` gets called with param
        `QAccessible::Identifier`, as introduced in
        qtbase commit [1]:
        
            commit 9ec1de2528b871099d416d15592fcc5ef9242a64
            Author: Jens Trillmann <jens.trillmann@governikus.de>
            Date:   Wed Mar 13 14:00:38 2024 +0100
        
                Add Identifier role to QAccessible and use it in OS interfaces
        
                * Unify the default identifier creation for QAccessibleInterface on
                  all platforms to be the same as the previous identifier on Linux.
                  This may change some identifiers on Windows.
        
                [ChangeLog][QAccessible][QAccessibleInterface] Add possibility to
                add unique identifier to QAccessibleInterface to give a11y elements
                consistent identifiers.
        
                Task-number: QTBUG-123361
                Change-Id: I8c42956a4c497e71909d71dcb27bc87433937b69
                Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
        
        `VCLXAccessibleComponent::getAccessibleId` returns the ID
        of the corresponding `vcl::Window` which equals to the GtkBuilder ID
        set in the .ui file, e.g. "SpellingDialog" for the spelling dialog
        (see `cui/uiconfig/ui/spellingdialog.ui`).
        
        This could be used for reliable identification by ATs, e.g.
        to identify the spelling dialog and specific widgets in it
        (see tdf#155447) or for automated tests.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=9ec1de2528b871099d416d15592fcc5ef9242a64
        
        Change-Id: I2281d15c38a229410469c29a14fdc4221aeb3e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170583
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-17  Michael Weghorn  <m.weghorn@posteo.de>  [5b9dec4caa727cd46ae9163812ecfc3142157cd1]

        tdf#155447 qt a11y: Don't report "Unknown" for unsupported props
        
        Return an empty string instead of "Unknown" for
        unsupported properties/text types in
        `QtAccessibleWidget::text`. Explicitly returning
        a non-empty string can be misleading, and e.g.
        also prevents the default calculation of an
        accessible ID that Qt does internally when an
        empty string is returned for `QAccessible::Identifier`
        which was introduced into qtbase in [1]
        
            commit 9ec1de2528b871099d416d15592fcc5ef9242a64
            Author: Jens Trillmann <jens.trillmann@governikus.de>
            Date:   Wed Mar 13 14:00:38 2024 +0100
        
                Add Identifier role to QAccessible and use it in OS interfaces
        
                * Unify the default identifier creation for QAccessibleInterface on
                  all platforms to be the same as the previous identifier on Linux.
                  This may change some identifiers on Windows.
        
                [ChangeLog][QAccessible][QAccessibleInterface] Add possibility to
                add unique identifier to QAccessibleInterface to give a11y elements
                consistent identifiers.
        
                Task-number: QTBUG-123361
                Change-Id: I8c42956a4c497e71909d71dcb27bc87433937b69
                Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=9ec1de2528b871099d416d15592fcc5ef9242a64
        
        Change-Id: I5eb5bd7adbc998a74a25f3c6c9ef373bd8faf1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170582
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-17  Patrick Luby  <guibmacdev@gmail.com>  [0d1b6f9ffb9d9908dddd3b895bf2458c524abda8]

        Enable building with Xcode 16.0 beta 3 on macOS 15.0 public beta
        
        Change-Id: Ia6d7fc9d8ec4e047d63a5ceb973ada997f3bf2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170595
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [27e8099a740562bd46d716ccc65c8fb42424a557]

        tdf#42893: sw_autocorrect: Add unittest
        
        Change-Id: I9a01eafea95e121f98153f43691bdb87fbb19e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170573
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [f8c89be7f1548902f8f6449222f87e00d845a303]

        tdf#158051: sw_autocorrect: Add unittest
        
        Change-Id: Ibde8357f37176b826683771924912ac31e31098d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169719
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f68f3b4d83e8975cee216cd7a90a2a5ed459a69]

        CppunitTest_sw_autocorrect: split into different tests
        
        It seems CI fails on Windows sometimes.
        See https://gerrit.libreoffice.org/c/core/+/170573
        
        Change-Id: I3e48d2656f31451e07a8bd52e98c793fa409f4c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170591
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-16  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [d1c6eeba13c2551e270e8ff0ba919fc9bac101c9]

        CairoSDPR: Direct support for RGBA Gradients (II)
        
        This step wil now use the new primitive
        PolyPolygonRGBAGradientPrimitive2D inside the
        CairoSDPR/CairoPixelProcessor2D to directly
        render gradients as RGBA, without painting
        RGB (content) and A (alpha) separate and mixing
        the results.
        Note that this is only possible for gradients
        which use the same graphical definition, see the
        method 'sameDefinitionThanAlpha' and it's usages
        in the code.
        
        Change-Id: I6c46a211ea26d3e4b7bb39c7f2aaff09ec38dec5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170584
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-16  Mike Kaganski  <mike.kaganski@collabora.com>  [f7c9ecf3d740f53d7a860157aba4fa1a8e32cca8]

        Use IsRunningUnitTest / IsRunningUITest in vclplug_win, too
        
        Change-Id: I2ae0236b13ea7e562e7c585bf308c2ef7e09176a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170589
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b40ecb9bff633ad6f301d8a8bf169a94b52ccbb2]

        tdf#158397 freeze hovering mouse above animating gif
        
        Improve the hit-test machinery so we don't need to rerender the graphic
        when moving the mouse over it
        
        Change-Id: Ide088296aa9c2be1348b8908194f47378454ae40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170587
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-16  Miklos Vajna  <vmiklos@collabora.com>  [09da7fd9cec9b36f2e09c1105a9263b83e2c66e4]

        tdf#162002 DOCX import, font embed: only discard subset fonts with few glyphs
        
        Commit a9f3c11375525a7708378dd3648febc40db1ad20 (tdf#162002 DOCX import:
        ignore subsetted embedded fonts for editing, 2024-07-12) decided to
        ignore all subsetted fonts for editing, improve this a little so we only
        ignore subsetted fonts when they can't even provide an English alphabet
        in any form (lowercase, uppercase).
        
        This avoids the possible problem that a font is marked as subsetted but
        it's good enough in practice and we would still throw it away for
        editing.
        
        Change-Id: I0bc0e14ffc0c039f029220991bd16d9e3254f059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170570
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [828b26bdc22743974655d64dada69e154159435a]

        use generic clipboard when running UI tests
        
        rather than the system clipboard, which makes no sense, since then the
        tests interfere with each other
        
        Change-Id: I911e88f5547dfc4f3558b9ed3ef670cef4903420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170574
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-16  Michael Stahl  <michael.stahl@allotropia.de>  [efae4fc42d5fe3c0a69757226f38efc10d101194]

        package: add additional consistency checks for local file header
        
        Check it contains same as central directory header, also check data
        descriptor if available.  Also check there are no gaps or overlaps.
        
        This causes 3 fuzzer generated test documents to fail to load; adapt
        tests.
        
        Change-Id: If5813652f3bd03e90fdf95eb97e1e1523455b2b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170571
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f81046033bb4082f888edfa94685d2dcc2689aa]

        cid#1554709 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554745 COPY_INSTEAD_OF_MOVE
        cid#1554758 COPY_INSTEAD_OF_MOVE
        cid#1554766 COPY_INSTEAD_OF_MOVE
        cid#1554771 COPY_INSTEAD_OF_MOVE
        cid#1554787 COPY_INSTEAD_OF_MOVE
        cid#1554802 COPY_INSTEAD_OF_MOVE
        cid#1554820 COPY_INSTEAD_OF_MOVE
        cid#1554828 COPY_INSTEAD_OF_MOVE
        cid#1554829 COPY_INSTEAD_OF_MOVE
        cid#1554832 COPY_INSTEAD_OF_MOVE
        cid#1554842 COPY_INSTEAD_OF_MOVE
        cid#1554885 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I43ec20250a04dc087f3d7fdeafc75f0c1dd0de25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-16  Justin Luth  <jluth@mail.com>  [671290e8054366997e512572b2e4e38efbf95f80]

        Revert "tdf#159013 writerfilter: link to the correct first-page header"
        
        This reverts commit 25.2 358ac0da827f908ce312c6d392a3d9102f36428e.
        which was backported to 24.8
        
        Although this patch made the situation "better than it was"
        for most cases, it will inevitably make some documents worse.
        
        Ultimately, this approach is wrong.
        See tdf#158977's 158977_linkNonEmptyFirst.docx.
        
        We can't only copy from the styles that "express" a H/F
        (and UNO doesn't let us copy from styles that hide it).
        
        A COPY appropach would need to ALWAYS import every header/footer
        into a dedicated "header/footer repository" page style,
        and every page style would need to copy its "expressed"
        headers/footers from the repository to its page style.
        
        That would mean our copy procedure would need to be very robust,
        and all of this is way too big for a bug-fixer like me to consider.
        I don't want to be the one on the hook expected to fix it properly.
        
        Change-Id: I2af4a03a219daabf186473839ba444ff9797ec2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170530
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-16  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [a073b6133960734b809c1bc93e39a76fdf1e7c15]

        CairoSDPR: Direct support for RGBA Gradients (I)
        
        Detect where created when a RGBA gradient could be
        used directly and create a primitive representing
        that, a PolyPolygonRGBAGradientPrimitive2D.
        That primitive decomposes to what was created before,
        so no primitive renderer has to be touched, all will
        work as before.
        NOTE: That helper primitive just holds references to
        what would be created anyways, so one depth step
        added but not really any additional data.
        This is the 1st step for direct support, the 2nd is
        to then detect and use that primitive in SDPR
        implementations directly.
        
        Change-Id: I4f247636ce58a8a1fd1e0df32dabed0d6cc10d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170527
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f10d51709d08bdafdbd5c92f73ddb62cb217b6dd]

        Embind: Implement UNO interface attributes as JS accessor properties
        
        Change-Id: I39b1f5676b2e5ba6071b39bf031c10d9c85f1ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170566
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e8e6a5f7951da0cf94171fd4b9457864e9528a08]

        Add test code for UNO attributes implemented in JS
        
        Change-Id: I74f5ef53e7850ab783ae4cd94525a55c63512bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170544
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d2550cf13123702207097c2a09220a0ec8c89eda]

        Test calling directly from JS a UNO method implemented in JS
        
        Change-Id: I46855474d2c183db9204bfea68cac94112e7766a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170543
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-16  Michael Weghorn  <m.weghorn@posteo.de>  [5495a2ef9c5e0a457c44e2fe0f6a62effda43ebc]

        a11y tests: Double the timeout for UI tests
        
        Increase the timeout for a11y UI tests from 1 to 2 min,
        to see whether this helps with one slow Windows Jenkins
        builder running into the timeout every once in a while,
        as was mentioned in ESC calls.
        
        Example from [1]:
        
            timeout waiting for dialog 'Bookmark' to show up
            warn:vcl.schedule:6600:11456:vcl/source/app/scheduler.cxx:524: Uncaught exception during Task::Invoke()!
            abort() has been calledwarn:sal.cppunittester:6600:11456:sal/cppunittester/cppunittester.cxx:601: CAUGHT SIGABRT:
            [...]
        
        [1] https://ci.libreoffice.org/job/gerrit_windows/181051/console
        
        Change-Id: I5b16ea8c538f6e2b5a30ebac714e177e696aac92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170569
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-16  Michael Weghorn  <m.weghorn@posteo.de>  [4f63dd8b374ce6e5c6fd783625c287eef6079265]

        a11y: Clean up XAccessibleAction doc
        
        The `XAccessibleAction::getAccessibleActionDescription`
        and `XAcccessibleAction::doAccessibleAction` doc mentions
        that an `IndexOutOfBoundsException` exception is thrown
        when the index is invalid, which is indeed the expected
        behaviour. However, they mentioned in addition that false
        or an empty string is returned, which doesn't make sense
        when exception gets thrown, so drop that.
        
        Also slightly improve wording at 2 other places.
        
        Change-Id: Idcc1fd669f32ff5a160cb35d2fbf6c2d23f65ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170567
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [38fe96dbd246f139c26c824b03265ee092be0133]

        cid#1606914 Double lock
        
        and
        
        cid#1607256 Double lock
        cid#1608253 Double lock
        cid#1608333 Double lock
        
        probably since:
        
        commit 155dd761e85600445e95f1f2a844d44544446a64
        Author:     Noel Grandin <noel.grandin@collabora.co.uk>
        AuthorDate: Mon Feb 13 19:00:27 2023 +0200
        
            osl::Mutex->std::mutex in ContentResultSetWrapper
        
        Change-Id: I93864a3fbf9596f1f02d882592e904fd80d25da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-16  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [450739e92e6f90060e5fdfa42ae291b1abaebd7a]

        Rhino: upgrade to 1.7.15
        
        Change-Id: Id3c6aa8dc5d398b7ecb749a149d54703bfe8b838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170457
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-16  Kira Tubo  <kira.tubo@gmail.com>  [6d5de74fb33d0bdd0fa4f44bfc6bc2b02c37aa11]

        tdf#155069 Make "Run Graphics Test" button experimental
        
        Hide "Run Graphics Test" button unless Experimental Mode is turned on.
        
        Change-Id: Idcfe2627e525626cce9dd866a9b697c69599626f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169480
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-16  Heiko Tietze  <tietze.heiko@gmail.com>  [5e45351c52584fb116d2cc54da969734e5effab9]

        Resolves tdf#105000 - Make shipped palette names translatable
        
        Change-Id: Ifd062cf25c6e930da56571e01c21bd9d2ddf6ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170394
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-16  Attila Szűcs  <attila.szucs@collabora.com>  [913e26de02067d49cdbe2746f9e3c3c9bed63236]

        SW: transform document structure
        
        Added a new UNO command: .uno:TransformDocumentStructure
        it need a sring parameter conaining a JSON strucure, that
        list what to change (transform), like this:
        
        {
            "Transforms": {
                "ContentControls.ByIndex.0": {
                    "content": "new value for the first content control"
                },
                "ContentControls.ByTag.name": {
                    "content": "John Smith"
                }
            }
        }
        
        this is just a 1. version it can only set text of a plain-text
        content control,
        or the state of a checkbox,
        or the alias (i may will be removed .. we have to decide later
        about all setable propertyes of contentc controls, what to let
        transform)
        
        Change-Id: I1772d979a7eb43961d62896f3c393482ed7dfa89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170538
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac03c0ed332ab0dcd319c72f46a32c76b88c4812]

        tdf#42893: sw_autocorrect: Add unittest
        
        Change-Id: Ic94061b9255f058c249fd853ad4856b284f8cfa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170532
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [f31d940b3777018f385541eed351f859a58c1989]

        tdf#57640: sw_autocorrect: Add unittest
        
        Change-Id: I2b0ccbc9826c7694b81458c540d78bb480e61f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170531
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ed6db07fa5bf14bdddbf181106f3985dc8a44bd]

        CppunitTest_sw_autocorrect: move some more tests here
        
        Change-Id: I89c1975d83dd52181f7d6c8dc92acd798f14291c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170529
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-16  Justin Luth  <jluth@mail.com>  [eaa1e3ec05600974334f6ce757253958bf2b33e4]

        NFC sw fmtcol.cxx: expression was always false
        
        the NEW property by definition comes from pNewChgSet->GetChgSet(), and
        the OLD property comes from GetAttrSet via GetItemIfSet.
        
        It can never be "unless we set it", because by definition
            SfxPoolItem::areSame(pOld, pNew)
        and therefore would not have gotten to this point of setting bContinue.
        
        This logic has been there since initial import.
        I assume the SfxPoolItem::areSame idea was added afterwards to
            // Avoid recursion (SetAttr!)
        which obsoleted that clause.
        
        -------------------------------------------------------------------
        Note: Setting bContinue to false is simply wrong in the first place,
        because just a single recalculation of a relative value
        can halt the proliferation of other legitimate changes.
        
        So, I'm rebuilding the logic one piece at a time
        to more clearly document the logic changes I am making,
        which should also help in case any of these cause a regression.
        
        Change-Id: Ida57aaf519a82292137b5ed896763907db1971be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169895
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-16  Jaume Pujantell  <jaume.pujantell@collabora.com>  [d54f049ee7ca9b4bb0452412196d2d709ef048d8]

        lok calc: allow remove and edit hypelink outside of edit mode
        
        Right now .uno:EditHyperlink and .uno:RemoveHyperlink only work on
        edit mode or inside a draw object, but LOK_CALLBACK_HYPERLINK_CLICKED
        is dispatched outside of edit mode.
        
        Change-Id: I26fb0c2e1ac438631ea71e33282e201f0a215d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170171
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit decb72c909b3f8296fb5c6b57b267c1079a865be)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170478
        Tested-by: Jenkins

2024-07-16  Justin Luth  <jluth@mail.com>  [1d2c42037c6704122581c2c6f0dd9d7979f49211]

        tdf#158977: restore disabled rtfexport2 testFdo44176
        
        Some unit tests were disabled with
            tdf#136472 adjust ooxml import to handle first header/footer
        
        This unit test seems pointless currently,
        but apparently back in 3.5 days it means something.
        The point is that the header space on the two pages
        is supposed to be identical, which measureably
        means that the body area of the pages should be identical.
        
        Adapted to try to keep the test alive and potentially relevant.
        
        Change-Id: I9e03839a9a755ad604269ff46bdd556e8cae4393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170533
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-16  Jonathan Clark  <jonathan@libreoffice.org>  [8c063d4e293e76982d4310ddc162b565a9a3c16e]

        tdf#114160 Regression tests for non-breaking ZWJ
        
        Per Unicode rules, ZWJ shouldn't be treated as a line break opportunity.
        This change adds regression tests to verify lines do not break at ZWJ.
        
        tdf#114160 was a regression introduced during a prior ICU upgrade. This
        was fixed by commit 44699b3de37f07090ac6fee1cd97aa76036e9700, but no
        tests were added for ZWJ at that time.
        
        Change-Id: Ieca919daea11dc161ae35fb6ffe5bd366cf4a6f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170534
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-16  Jonathan Clark  <jonathan@libreoffice.org>  [174aa6e980f973cea9b1c402d03bd6dba951f5ae]

        tdf#46950 Allow intra-word right double quotation mark
        
        Hebrew text may use the character RIGHT DOUBLE QUOTATION MARK as a
        substitute for HEBREW PUNCTUATION GERSHAYIM. This change customizes the
        ICU word BreakIterator rules to that end.
        
        Change-Id: I03a48729de103505a2f68f9a1635c0f0cd7d126a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170536
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-07-16  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [07468c71ad47e027bdadbf2cdf35e903734a8078]

        libffi: Upgrade to 3.4.6
        
        * external/libffi/implicit-function-declaration.patch was obsolete after
        https://github.com/libffi/libffi/pull/764
        * Backport external/python3/0001-bpo-45898-Remove-duplicate-symbols-from-_ctypes-cfie.patch.1
        from upstream to fix build errors on Windows.
        
        Change-Id: I6d7cd70dd29ea0ce4b22738637afa0e7eb76a93f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167337
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-16  Hossein  <hossein@libreoffice.org>  [abf2f24e5b58608bc6526a2703ef68c66ab1df0f]

        Add lokconvert odk example
        
        This exmaple converts a file to PDF using LibreOfficeKit library.
        
        Change-Id: Idc4afafc9541986617f0cc4d46cd89e25ae12051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169998
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-07-16  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9ee8b3b8d9b36fa0f0988db5e9ebb664f5d81da0]

        tdf#161914 Rename "Pen Width" to "Pen Thickness"
        
        Change-Id: I3a6bc7143a7a621c7c1ebdfd2b33d6021f6b4a66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170482
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-07-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bc3fd0c8110256c920669e6e355b42504b17c7b2]

        -Werror,-Wgnu-folding-constant
        
        > desktop/unx/source/start.c:788:23: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
        >   788 |             char resp[strlen("InternalIPC::SendArguments") + 1];
        >       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        since
        <https://github.com/llvm/llvm-project/commit/e4163c0927772f2ec73cf16d53e000614c419c45>
        "[clang] Emit bad shift warnings (#70307)" (and see the comments starting at
        <https://github.com/llvm/llvm-project/pull/70307#issuecomment-2228342153>
        "[clang] Emit bad shift warnings" for how this new warning is indeed
        intentional)
        
        Change-Id: Ie439a0f5f6f3b256fa82ec3a05fdc5fb3b840715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170510
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a14f0b14c4a0904d37c5ad5b18400d832bde7804]

        CppunitTest_sw_autocorrect: move some tests here
        
        and name them by language
        
        Change-Id: I634d31cd968ffdcbf2b92766980cae8bfb2afdb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170506
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [5d0de0b3451754652b840b77c0765c2b1153add8]

        Simplify use of close_dialog_through_button: allow button by name
        
        Change-Id: I59a74e7221808308853f0d893a416fababaf2318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170493
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-15  Justin Luth  <jluth@mail.com>  [626a9e73a0ed8072a5a078dceaf1b4e2ec9ef0d5]

        tdf#158977: remove obsolete rtfexport testFdo44174
        
        Some unit tests were changed or disabled with
            tdf#136472 adjust ooxml import to handle first header/footer
        
        This unit test is basically the same file as rtfexport2's fdo44176.rtf
        except that one actually has two pages, while this one SAYS
        it has two pages but only actually has one.
        
        Nor are there any headers or footers involved,
        so it is a completely pointless test.
        
        Change-Id: I4ce90f5749ce95426f93d7d0e4fd507c7fdfe5d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170507
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-15  Justin Luth  <jluth@mail.com>  [aec34ae349aee866db628e7a48cd1b5f6cc6dca1]

        tdf#158977: restore disable ooxmlimport unit test
        
        Some unit tests were disabled with
            tdf#136472 adjust ooxml import to handle first header/footer
        
        This one simply needed to be re-written to reliably test
        if it was laid out on page 1.
        
        Change-Id: Id749ff9d049691feba7fb155605291a2081a54c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170505
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [9fdb7eca0c14c2449ab185014d132035d985b5d2]

        Use WeakReference to CWinClipboard instead of pointer
        
        Change-Id: I30cbbec885e9132d45bf19293890b3e2f581e928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170515
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-15  Oliver Specht  <oliver.specht@cib.de>  [dce68b5f9f286a8b6af42fcad1331d7e9bb07f4c]

        tdf#161264 don't hide paragraph with empty mail merge fields
        
        With tdf#35798 db04be037b611e296ef9f2542322c52ed82d7a2b
        paragraphs containing empty mail merge fields are hidden by default
        to remove empty lines in address blocks.
        This is now switched off when importing Word documents.
        
        Change-Id: I0f550ff3d29ac499446df9a04676a08d914d12f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169469
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-15  Oliver Specht  <oliver.specht@cib.de>  [0b7201bc4299f76c8a3e085f213ffeb7ea9e8556]

        tdf#161864 Apply character properties to SYMBOL field
        
        In RTF import character attributes are applied to symbols
        imported from \field{ SYMBOL }.
        
        Change-Id: I088c47e799380813dce19fd9823cdba6b8048af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169864
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [6113d5dc45232b602bee0e68cf7560d0b8656546]

        tdf#161782 Focus document when Esc is pressed in the Gallery/Navigator
        
        When Esc is pressed on a Panel that has no visible title, move focus to the document.
        
        Change-Id: Ib5571dbd9f8a37017e21d2e01e7b546eb2330751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169668
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-07-15  Moritz Duge  <moritz.duge@allotropia.de>  [76f4e6d9764048d98f3fdd1620b0e0a6787385c1]

        tdf#121140: GPG checkbox only for file formats with GPGENCRYPTION flag
        
        Only ODF-1.2 and ODF 1.3 support GPG encryption.
        Flat ODF and other formats do NOT, so lets not offer an option that
        subsequent code path ignores.
        
        Change-Id: Ie43be433fbcaa56c76b25e12b58b084ea9bcfd6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168001
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Moritz Duge  <moritz.duge@allotropia.de>  [86276a0ae8ae86fdafcf2af48df1054f8d8ad3c4]

        Simplify boolean logic locally for mbIsPwdEnabled.
        
        Change-Id: I2b2611e51ce0fdffdd25a75b211ce06b5bfd6b43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167999
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Oliver Specht  <oliver.specht@cib.de>  [13cd36248069d32688cfb8adfe0955ca5229e075]

        tdf#148554 RTF import - reset borders on fill cells
        
        In documents containing tables with rows having different right margins
        an additional cell is added to fill the gap.
        These cells should be 'invisible' and therefore need to have no border.
        
        Change-Id: I802310251f36fb6b2c00f3cb38786f438e4565a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170179
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-15  Oliver Specht  <oliver.specht@cib.de>  [3e4aa127416a5947882e6644409468aa1ca039ae]

        tdf#122756 clone formatting includes table number format
        
        In clone formatting the number format of the current cell(s)
        is copied and applied if the target is a table
        
        Change-Id: I0b7dc1d5015aeb2262c8d37f76442519c5b6d655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168184
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [b3922a8d0051a656228f80aeee5360692c9bba2e]

        Release the lock for getClipboard call to avoid deadlock
        
        The call stacks that deadlock in my testing:
        
        Thread A: CMtaOleClipboard::clipboardChangedNotifierThreadProc()
        
          win32u.dll!NtUserMsgWaitForMultipleObjectsEx()
          user32.dll!MsgWaitForMultipleObjects()
          vclplug_winlo.dll!`anonymous namespace'::Win32Condition::wait(void * hEvtAbort) Line 92 C++
          vclplug_winlo.dll!CMtaOleClipboard::getClipboard(IDataObject * * ppIDataObject) Line 353 C++
          vclplug_winlo.dll!CWinClipboard::getIDataObject() Line 158 C++
          vclplug_winlo.dll!CDOTransferable::tryToGetIDataObjectIfAbsent() Line 413 C++
          vclplug_winlo.dll!CDOTransferable::getClipboardData(CFormatEtc & aFormatEtc) Line 426 C++
          vclplug_winlo.dll!CDOTransferable::getTransferData(const com::sun::star::datatransfer::DataFlavor & aFlavor) Line 252 C++
          vcllo.dll!TransferableDataHelper::GetAny(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 1484 C++
          vcllo.dll!TransferableDataHelper::GetSequence(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 2078 C++
          vcllo.dll!TransferableDataHelper::InitFormats() Line 1344 C++
          vcllo.dll!TransferableDataHelper::TransferableDataHelper(const com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> & rxTransferable) Line 1156 C++
          svtlo.dll!TransferableClipboardListener::changedContents(const com::sun::star::datatransfer::clipboard::ClipboardEvent & rEventObject) Line 52 C++
          vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent>::operator()(const com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardListener> & listener) Line 275 C++
          vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::forEach<comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent>>(std::unique_lock<std::mutex> & rGuard, const comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent> & func) Line 304 C++
          vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::notifyEach<com::sun::star::datatransfer::clipboard::ClipboardEvent>(std::unique_lock<std::mutex> & rGuard, void(com::sun::star::datatransfer::clipboard::XClipboardListener::*)(const com::sun::star::datatransfer::clipboard::ClipboardEvent &) NotificationMethod, const com::sun::star::datatransfer::clipboard::ClipboardEvent & Event) Line 327 C++
          vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 302 C++
          vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 386 C++
          vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 723 C++
          ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        Thread B: CMtaOleClipboard::run()
        
          ntdll.dll!NtWaitForAlertByThreadId()
          ntdll.dll!RtlAcquireSRWLockExclusive()
          msvcp140d.dll!mtx_do_lock(_Mtx_internal_imp_t * mtx, const _timespec64 * target) Line 93 C++
          msvcp140d.dll!_Mtx_lock(_Mtx_internal_imp_t * mtx) Line 165 C++
          vclplug_winlo.dll!std::_Mutex_base::lock() Line 56 C++
          vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 149 C++
          vclplug_winlo.dll!CWinClipboard::onReleaseDataObject(CXNotifyingDataObject * theCaller) Line 363 C++
          vclplug_winlo.dll!CXNotifyingDataObject::Release() Line 77 C++
          combase.dll!CStdIdentity::ReleaseCtrlUnk::__l5::<lambda>() Line 1408 C++
          combase.dll!ObjectMethodExceptionHandlingAction<void <lambda>(void)>(CStdIdentity::ReleaseCtrlUnk::__l5::void <lambda>(void) action, ObjectMethodExceptionHandlingInfo * pExceptionHandlingInfo, ExceptionHandlingResult * pExceptionHandlingResult, void * __formal) Line 135 C++
          combase.dll!CStdIdentity::ReleaseCtrlUnk(unsigned long dwDisconnectType) Line 1411 C++
          [Inline Frame] combase.dll!ObjectLibrary::ReferencedPtr<CObjectContext>::operator int ObjectLibrary::Details::BoolStruct::*() Line 1313 C++
          combase.dll!CStdMarshal::DisconnectWorker_ReleasesLock(unsigned long dwType, bool logEventIsActive, CObjectContext * explicitServerContext, bool performCallback, CIDObject * pIDDelayRelease) Line 4783 C++
          combase.dll!CStdMarshal::Disconnect(unsigned long dwType) Line 4452 C++
          [Inline Frame] combase.dll!CStdMarshal::HandlePendingDisconnect(HRESULT) Line 4285 C++
          combase.dll!CRemoteUnknown::RemReleaseWorker(unsigned short cInterfaceRefs, tagREMINTERFACEREF * InterfaceRefs, int fTopLevel) Line 1307 C++
          rpcrt4.dll!Invoke()
          rpcrt4.dll!Ndr64StubWorker()
          rpcrt4.dll!NdrStubCall3()
          combase.dll!CStdStubBuffer_Invoke(IRpcStubBuffer * This, tagRPCOLEMESSAGE * prpcmsg, IRpcChannelBuffer * pRpcChannelBuffer) Line 1479 C++
          [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec>::operator()() Line 1151 C++
          combase.dll!ObjectMethodExceptionHandlingAction<<lambda_c9f3956a20c9da92a64affc24fdd69ec>>(InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec> action, ObjectMethodExceptionHandlingInfo * pExceptionHandlingInfo, ExceptionHandlingResult * pExceptionHandlingResult, void *) Line 94 C++
          [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing(IRpcStubBuffer * pMsg, tagRPCOLEMESSAGE *) Line 1149 C++
          combase.dll!DefaultStubInvoke(bool bIsAsyncBeginMethod, IServerCall * pServerCall, IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 1218 C++
          combase.dll!SyncServerCall::StubInvoke(IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 791 C++
          [Inline Frame] combase.dll!StubInvoke(tagRPCOLEMESSAGE * pMsg, const _GUID &) Line 1483 C++
          combase.dll!ServerCall::ContextInvoke(tagIPIDEntry * ipidEntry) Line 1421 C++
          [Inline Frame] combase.dll!DefaultInvokeInApartment(ServerCall *) Line 3257 C++
          combase.dll!ReentrantSTAInvokeInApartment(ServerCall * serverCall, tagIPIDEntry * ipidEntry) Line 110 C++
          combase.dll!ComInvokeWithLockAndIPID(ServerCall * pServerCall, tagIPIDEntry * pIPIDEntry) Line 2152 C++
          combase.dll!ThreadDispatch(ServerCall * pServerCall) Line 1637 C++
          combase.dll!ThreadWndProc(HWND__ * window, unsigned int message, unsigned __int64 wparam, __int64 params) Line 720 C++
          user32.dll!UserCallWinProcCheckWow()
          user32.dll!DispatchMessageWorker()
          [Inline Frame] combase.dll!CCliModalLoop::MyDispatchMessage(tagMSG *) Line 2959 C++
          combase.dll!CCliModalLoop::PeekRPCAndDDEMessage() Line 2563 C++
          combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2055 C++
          combase.dll!ModalLoop(CSyncClientCall * pClientCall) Line 169 C++
          [Inline Frame] combase.dll!ThreadSendReceive(tagRPCOLEMESSAGE *) Line 7259 C++
          [Inline Frame] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5735 C++
          combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5297 C++
          combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus, ClientCall * pClientCall, bool * pbIsAutoRetry) Line 1502 C++
          combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext * pRetryContext, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 582 C++
          combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 564 C++
          combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 787 C++
          combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 659 C++
          combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 1989 C++
          rpcrt4.dll!NdrpClientCall3()
          combase.dll!ObjectStublessClient(void * ParamAddress, __int64 * FloatRegisters, long Method) Line 366 C++
          combase.dll!ObjectStubless() Line 176
          combase.dll!CStdMarshal::RemoteAddRef(tagIPIDEntry * pIPIDEntry, OXIDEntry * pOXIDEntry, unsigned long cStrongNeed, unsigned long cSecureNeed, int fGiveToCaller) Line 8489 C++
          [Inline Frame] combase.dll!CStdMarshal::GetNeededRefs(tagSTDOBJREF *) Line 3654 C++
          combase.dll!CStdMarshal::ConnectCliIPIDEntry(tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, tagIPIDEntry * pEntry) Line 3338 C++
          combase.dll!CStdMarshal::MakeCliIPIDEntry(const _GUID & riid, tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, tagIPIDEntry * * ppEntry) Line 3108 C++
          combase.dll!CStdMarshal::UnmarshalIPID(const _GUID & riid, tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, void * * ppv) Line 2621 C++
          combase.dll!CStdMarshal::UnmarshalObjRef(tagOBJREF & objref, void * * ppv) Line 2479 C++
          combase.dll!UnmarshalSwitch(void * pv) Line 2112 C++
          combase.dll!UnmarshalObjRef(tagOBJREF & objref, EffectiveUnmarshalingPolicy policy, void * * ppv, int fBypassActLock, CBaseCall * callMarshalingContext, CStdMarshal * * ppStdMarshal) Line 2261 C++
          combase.dll!InternalGetWindowPropInterface2(HWND__ * hWnd, unsigned __int64 dwCookie, int fCallStrongNamedProcesses, const _GUID & iid, void * * ppv, int * pfLocal) Line 285 C++
          ole32.dll!UnmarshalFromEndpointProperty(HWND__ * hWnd, int fDragDrop, int fCallStrongNamedProcesses, IUnknown * * ppUnk, int * pfLocal) Line 407 C++
          ole32.dll!GetInterfaceFromWindowProp(HWND__ * hWnd, const _GUID & fCallStrongNamedProcesses, int ppunk, IUnknown * *) Line 440 C++
          ole32.dll!CClipDataObject::CacheDataPointer() Line 223 C++
          ole32.dll!CClipDataObject::QueryInterface(const _GUID & riid, void * * ppvObj) Line 886 C++
          [Inline Frame] combase.dll!IUnknown::QueryInterface(INoMarshal * *) Line 138 C++
          combase.dll!CoMarshalInterface(IStream * pStm, const _GUID & riid, IUnknown * pUnk, unsigned long dwDestCtx, void * pvDestCtx, unsigned long mshlflags) Line 1133 C++
          combase.dll!wCoMarshalInterThreadInterfaceInStream(const _GUID & riid, IUnknown * pUnk, IStream * * ppStm) Line 1046 C++
          combase.dll!CoMarshalInterThreadInterfaceInStream(const _GUID & riid, IUnknown * pUnk, IStream * * ppStm) Line 709 C++
          vclplug_winlo.dll!MarshalIDataObjectInStream(IDataObject * pIDataObject, IStream * * ppStream) Line 158 C++
          vclplug_winlo.dll!CMtaOleClipboard::onGetClipboard(IStream * * ppStream) Line 465 C++
          vclplug_winlo.dll!CMtaOleClipboard::mtaOleReqWndProc(HWND__ * hWnd, unsigned int uMsg, unsigned __int64 wParam, __int64 lParam) Line 547 C++
          user32.dll!UserCallWinProcCheckWow()
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!CMtaOleClipboard::run() Line 656 C++
          vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 673 C++
          ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        Thread A locks the mutex, and calls CMtaOleClipboard::getClipboard, which is synchronous; the call is marshaled to Thread B, which eventually tries to release a data object, which requires the mutex.
        
        Change-Id: I5ad8847b98ca23ad84c0595a2baad2c13f1e809e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170504
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4e96e685c553327e83dc46f937d44b9f7c0c004]

        delay parsing of formula in EnhancedCustomShape2d
        
        We create a bunch of temporary copies of these during layout in writer,
        and we don't appear to need the equation results at that point.
        
        Speeds up display of a complex DOCX file load by 10%
        
        Change-Id: Ic5870931caba13cd79b07617d04b70616f06c5b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170498
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-15  Miklos Vajna  <vmiklos@collabora.com>  [dc3e022866893d8c0950f2269c0c8d61c24ed9bf]

        cool#9504 sw: don't invalidate num rules when pasting into a non-num paragraph
        
        The bugdoc has ~300 pages of content, most of that is bullets, but
        otherwise not complex, pasting a trivial string at doc end (which is not
        a bulleted paragraph) takes a noticeable time:
        
        debug:20449:20330: SwLayAction::InternalAction: start
        debug:20449:20330: SwLayAction::InternalAction: end, took 268 ms
        
        Profiling points out that we re-layout the internal document, which is
        not expected: we just pasted on the first page, causing no layout change
        on page 2 and later pages. Watching who turns on m_bInvalidContent on
        the page frames, it can be noticed that SwReader::Read() invalidates all
        numberings after pasting.
        
        Fix the problem by not doing that in case we paste plain text and we
        know the insertion point is not in a numbering: the invalidation is not
        useful in this case and fixes the unexpected delay.
        
        Other related ideas are 1) don't do the layout for all pages in one go
        2) recognize that the bullets need no invalidation, unlike an actual
        numbering with numbers. Neither of these are done in this commit yet.
        
        Change-Id: Id7b2c022b31acb358f42ddd77195db70ae451109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170499
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [272f776b322cfd017506a6b67638ae7d2b83c014]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c6956d32c0cfa26e219bd2e32f66d3fe7796ad76
          - tdf#162025 Fix param separator of several functions
            
            Change-Id: Ib4622836fbdfa5084edf38cd9fb13db815382c6d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170494
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [45ce7da65adf9721e6deb23d2bb40d95a97288df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6dccce115b41c89de6b25b6b4fbddd0a34434115
          - tdf#161914 Rename "Pen Width" to "Pen Thickness"
            
            Change-Id: I15c6106b23e72f6fb0e7b427645eb236172803fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170481
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            Tested-by: Jenkins
            
2024-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [0967050fa77c265ec215d43d5a118a709481787f]

        tdf#125051: rework and improve uitest
        
        The test still fails if f7936b8ccd0ce9bea3a5e780443e4ae8f35b9da1
        "tdf#125051: fix spellchecking on Calc" is reverted.
        Change the test to avoid having the second dialog prompted when launching the spell dialog. The options dialog part is removed because it's not needed for testing the crash
        
        Change-Id: I337376dd9ad0f5454534821d259589a9bd68af35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170495
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-15  Michael Weghorn  <m.weghorn@posteo.de>  [63ea3783bd49e2d005f2fe9821732615166867dd]

        vcl: Use nNewPos consistently
        
        Use the `nNewPos` variable for assigning to
        `mnCurPos` in `ToolBox::MouseButtonDown`
        as well, rather than `i` which was the loop
        variable above, and whose value was
        assigned to `nNewPos` for the case that this
        code path is entered.
        
        Using `nNewPos` consistently makes a bit
        more obvious that this is the same as in
        the surrounding lines.
        
        Change-Id: I5ce2da04310f21070931549a599248fdcad45317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170489
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a19aa4754651e685ca07131bfa454c3360191269]

        tdf#161871 Revert "Removed Type and Usage Columns from Certificate Chooser"
        
        The commit broke the display of all columns except the first one in all
        backends except gtk3.
        
        Also it's not clear why those columns are deemed superfluous;
        see discussion in tdf#161871
        
        This reverts commit 9f327102c435887bbae650b3a573f44500b6f534.
        
        Change-Id: Idc3496122137f98c23bb7df8e36b17281fc948d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170491
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5389d8ed8b235086b3e7954341a1aa2c589adbe0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0e95a8dfb0b499b18834776b911c0b60725c215e
          - update translations for master/24-8
            
            Change-Id: I959d23423e7f5f6f5cf91533b3ed9888e4b0a999
            
2024-07-15  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [dd08e194447355d7f3a009a0415999de3d762fb1]

        ITEM: secure HashedItemInstanceManager
        
        This one still used just a hash to feed a unordered_map
        what is not safe. Changed to unordered_set and added
        hash and equal operators.
        
        Change-Id: I2a426c449536747ad59f8bd8781a7eadceea9183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-15  Michael Weghorn  <m.weghorn@posteo.de>  [92c30fd8320cd340a0daaac3a45475cbea4c3e99]

        tdf#161501 icon choice ctrl: Highlight full entry area
        
        For background and borders/frames drawn to highlight
        the currently selected/focused/mouse-hovered entry in
        the icon choice control, use the entry's full area
        and don't restrict the bottom edge to where the text
        ends.
        
        It's also unclear to me why 1 pixel would be subtracted
        for the top and right edge when calculating the rect -
        drop that as well.
        (There is a line of a pixel or so in between the entries,
        but since that actually doesn't belong to any of the
        entries -- clicking there doesn't change the selected
        entry -- also don't highlight it as part of one of the
        entries.)
        
        This addresses this (preexisting) issue mentioned in [1]:
        
        > Maybe for a future patch... but the height from `CalcFocusRect`
        > is too low. It barely covers the item and leaves gaps with
        > respect to subsequent items.
        
        [1] https://gerrit.libreoffice.org/c/core/+/170341/comment/57dc568d_1c0a8cf2/
        
        Change-Id: I3369401c0bbdb77a054da9f57ac70f30f97c9cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170393
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-07-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [f98f684d22e6323185104ca9c082241c53dfc2b3]

        remove RecalcObjOrdNums in DoTextBoxZOrderCorrection
        
        (1) We already do this recalculation automatically using a dirty flag.
        
        (2) Add a custom method so we don't trigger that recalculation here
        
        Speeds up display of a complex DOCX file load by 10%
        
        Change-Id: I2a8c975ba0711172bc3e0c20c0e89f08351b6126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8d279e8c4fbef0599d4d84c98695871fb5b42275]

        cid#1607843 Use of auto that causes a copy
        
        and
        
        cid#1555160 Use of auto that causes a copy
        
        Change-Id: I2e2056ddbfb2d11d288a5b2df273e8bc049387fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170455
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [1d91ab661b2fe0f307c0742999b40e6d848117af]

        Unused return value
        
        Change-Id: Ibe3d508cfb45314fa81a5ee4f85eda7207482274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170488
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e48cbfcef0b81fc9bf9bea5ddf1b4d01e5ea7a2]

        cid#1607327 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554706 COPY_INSTEAD_OF_MOVE
        cid#1554733 COPY_INSTEAD_OF_MOVE
        cid#1554736 COPY_INSTEAD_OF_MOVE
        cid#1554738 COPY_INSTEAD_OF_MOVE
        cid#1554740 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I766cff4ef8eb4256d26f51d7d9dc64442c4bc728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170453
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-15  Miklos Vajna  <vmiklos@collabora.com>  [3e1b67dabf585e04a34e82810387ae943b38ee41]

        svx: prefix members of SdrUndoObjOrdNum
        
        See tdf#94879 for motivation.
        
        Change-Id: I0ab21ca5171b5d5b66542dbf7157db0c156e45b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170487
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-15  Moritz Duge  <moritz.duge@allotropia.de>  [2e52ac48e58efa5f1204ac61eec820eb3fb561ba]

        Added pyuno demo for key and mouse handlers and listeners.
        
        Change-Id: I5b2f70061c5eee7a1068ec110d34ddadc5200bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169584
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0e1592094e7463b07e9bc9725b4c85d5244bf997]

        tdf#108828 Prevent leaking keys from previous signing sessions
        
        Usuccessful signing sessions (e.g. abort when password is requested)
        left their key in the context.
        On the next try, the former key would also be used to sign.
        
        Change-Id: I55b9201df229cae40863a0a19b238029607d1848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170388
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-07-15  Jim Raykowski  <raykowj@gmail.com>  [d16ac2a8ed46bdc0f20d49850b9c4989697acd49]

        Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"
        
        window when adding a change in the document (Track changes mode)
        
        Change-Id: Iecb49346cfe5d4f447b07ec5451c753c90dddb44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170460
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-15  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [bbd5079c58e352ece8f10328f8dcda9819c4cfbe]

        tdf#161914 Rename "Pen Width" to "Pen Thickness"
        
        Change-Id: Ic16370a0e583ed74da4c6c3548b9eb2cea9d1b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170363
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-07-14  Ming Hua  <plateauwolf@qq.com>  [091f9a595313b6cf23c5b595fc9e0c1dbd624b36]

        Make extended tooltip translatable
        
        Change-Id: Ic626f31c0257a7f70cfeee5d16a3269a7958f01c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170353
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [2e0664015255ffc0f76a11a9cb254564b34de496]

        tdf#148647: make sure to update own content on Win clipboard change
        
        Before, only a new call to setContents, or destruction of the data
        object referenced from CWinClipboard, would force CWinClipboard to
        clean its m_pCurrentClipContent. A data object could be referenced
        elsewhere, and so not get destroyed on clipboard change; this kept
        the value of m_pCurrentClipContent, and all the following calls to
        getContents would still return that stuck own data object.
        
        This change makes CWinClipboard  store new own data object pointer
        into temporary m_pNewOwnClipContent.  In onClipboardContentChanged
        notification, the value is moved to m_pCurrentOwnClipContent. This
        ensures that following onClipboardContentChanged events will clear
        m_pCurrentOwnClipContent, preventing stuck clipboard content.
        
        Change-Id: Idd0a64a820d79bede9deceba8d5800b7fc61e66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170459
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a0d5d9dd9d8c11ec4c63251633081b3270c3ea3d]

        drop these fuzzers to short lengths temporarily
        
        oss-fuzz has got into that annoying state where the original bugs are
        not reproducible, and probably fixed, but some follow up issues trigger
        the same problem so the original won't close and its not easy to see the
        new cases.
        
        Change-Id: I8e515c0c5b8eafe40bfda695774ef56ec24948c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [68b782a2791f23d44f4d5185003c33ddaaef9b1f]

        cid#1607572 silence bogus Copy-paste error
        
        Change-Id: Id8355a033089a47299d76e1743b7da5a1b4a5d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170454
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c28c61e528cab4368a593b1a3c3705b0936da0e4]

        Revert "boost::unordered_map to std::unordered_map in configmgr::Partial"
        
        This reverts commit 154b2040102d74aeb4c5d0cf07f1bdc90d265d52, which is known
        broken, as (unlike for boost::unordered_map) there is no guarantee that
        std::unordered_map works for incomplete value types, and indeed there is build
        environments that started to fail now with
        
        > In file included from /home/libo/src/core/configmgr/source/partial.cxx:23:
        > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/set:60:
        > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:63:
        > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_algobase.h:64:
        > /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_pair.h:218:11: error: field has incomplete type 'configmgr::Partial::Node'
        >       _T2 second;                ///< The second member
        >           ^
        [...]
        
        Change-Id: Ie8d041bcf3d3b1b6aeede73adbaf14676250c4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170467
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [8d956615d05f655795c7d79eca3553a3a3bceac9]

        Try to simplify Windows clipboard locking
        
        Having three mutexes for one object is a bit too much. It is impossible
        to handle it properly. Issues like tdf#148647, that affect many users,
        but have no reliable reproducer, hint that possibly there is a deadlock
        somewhere in the code that should clear m_pCurrentClipContent, or maybe
        something similar.
        
        This drops both local mutexes, and uses inherited m_aMutex everywhere
        to guard accessto all the local data. I hope that this this will make
        debugging of the problems around the clipboard possible. But it looks
        invasive, of course.
        
        Change-Id: I2311b1b4702f766e3e5e0d104f9b2b2999aa53c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170450
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [309dc58aee022ea804d04f33c80dddefcdafb987]

        cid#1555652 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1555655 COPY_INSTEAD_OF_MOVE
        cid#1555658 COPY_INSTEAD_OF_MOVE
        cid#1555665 COPY_INSTEAD_OF_MOVE
        cid#1555667 COPY_INSTEAD_OF_MOVE
        cid#1555670 COPY_INSTEAD_OF_MOVE
        cid#1555675 COPY_INSTEAD_OF_MOVE
        cid#1555684 COPY_INSTEAD_OF_MOVE
        cid#1555687 COPY_INSTEAD_OF_MOVE
        cid#1556539 COPY_INSTEAD_OF_MOVE
        cid#1556542 COPY_INSTEAD_OF_MOVE
        cid#1557448 COPY_INSTEAD_OF_MOVE
        cid#1557449 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3567528e559bca0031c4f5b46801e3130073633b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [990490781cdea757a25a14da30e575a6a9dfb6a7]

        cid#1555646 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I477cb9b74c99b32eb06e054fa38dd3ffa6bb77da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170447
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f3d6cf4d8d6a6aa48bf5d080451214360c9a81c]

        cid#1608181 Double lock
        
        Change-Id: Id6121213f11c4ce0c855a0937fd2d7c81946c076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170446
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [069fd3f54e3f330fd072eff11b34a22e73413c21]

        cid#1608236 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3f46c1d7e68dbf79ddbc9dc50d2735ebe1727b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e3e325d0ce4a3520761eeb18aa606c479eafa381]

        cid#1607284 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iacaf551260e878f39a36adc8b6d0ea142c092f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170444
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [18b7d1895d5ca160761955fd70a09ce0de1171c8]

        cid#1608349 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I00f4afb09907b91c4d180a9dd7464226bb327af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6d168749b41483d184d0882feae7d8486aa3da3]

        cid#1608424 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id56d0bf130e2c0a5935a577b82db6c6edd4c7610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170442
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a625049ead3d61f4ed5721b0abafad335aa5f081]

        cid#1608453 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I059fb6a6b3af58ecedcf14c347adbb698348da1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170441
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [524ec386b2438fbcda42a1264ad372285a91be7f]

        cid#1608516 Overflowed constant
        
        Change-Id: I0d494f512a45e93933fdb03f64238f12ed2570a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170440
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa8f60c90f40a489b5cd112f6b1c5b1b4955a48f]

        move declares to first uses
        
        Change-Id: Ia05d12b87093e1b9a87f4d4e144d4d98c2fbeaac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170439
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [884dd38e57c6c655f0ecf3014a86e06fce366e83]

        cid#1608572 silence Overflowed integer argument
        
        try to convince coverity of the errors of its ways
        
        Change-Id: I4e847f3773931dccaff1724166072bfde0b97941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170438
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b904816f7375ef63c6c86578bed58f8dc06b6125]

        cid#1608584 Overflowed constant
        
        Change-Id: Ieefa43899f84938ba12227b30a2c9b273ac2c202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170437
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-14  Arnaud VERSINI  <arnaud.versini@pm.me>  [be1c9ee5b3fd326d16f41c45a53123053507687e]

        i18npool : use new OUtring literals
        
        Change-Id: I2000f4c5409d988c9030e2eec70247d8f79059e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166970
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
        Tested-by: Jenkins

2024-07-14  Yuki Joou  <yukijoou@kemonomimi.gay>  [cfe6ce1656754776568be5b30217efc08aa70dc0]

        tdf#145538 - related: Make tools::PolyPolygon iterable
        
        This patch allows tools::PolyPolygon to be iterated using c++11's
        fancy range-based for-loops. It also upgrades a bunch of old-style
        for-loops iterating over polypolygons to the new style to make code
        more readable.
        
        Note that not all for-loops iterating over polypolygons have been
        upgraded, as I didn't find a way to automatically find those. I just
        did a few I found manually.
        
        Change-Id: Ifa8d0d44e6f0aa28fdcfd87d70058b12f48c1349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168730
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-14  HakimOttey  <hakimotteybusiness@gmail.com>  [63fe0d6c07eed6a4b125c6ee0fb2d53ed689385f]

        tdf#114441 replace sal_uLong with tools::Long
        
        Make variable nHScrX have tools::Long data type as it is expected to be tools::Long when used in SetPostSizePixel
        
        Change-Id: If7e0c1ee1a9832b215c766cbf8bf916c731edfd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167804
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-07-14  Julien Nabet  <serval2412@yahoo.fr>  [f9de7bc9514596cecd51419c83901d24518a9109]

        Fix Python: use is None/is not None instead of == None/!= None
        
        Thank you Kevin for having spotted this!
        
        Change-Id: Ic63469d2d8dfd3f7848b6fc2250f90271055c027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170449
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-14  Jim Raykowski  <raykowj@gmail.com>  [2c46d3c2ff6bbdcd387771f823aa5b3b812c80a8]

        tdf#161811 Changes in TC manager dialog should be in order of
        
        appearance in document
        
        Adds a drop down control to the Writer Manage Changes dialog/sidebar
        panel that can be used to select how the changes list is sorted.
        
        Change-Id: I9602322ec61ae6e15a08fbc26aa69de1b64294e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170390
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3f7d0f79f1c43222bd160cffd9e443bb5fc91c99]

        annot: make all keys work when writing in annotation window
        
        We did not call the method on the superclass when we don't handle
        the key ourselves, but we should.
        
        Change-Id: I67d55773b7e86297c00727b4791c16a1adcc37f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170430
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [aff09d7cb464af3223ee43cac0483ae3bf22fddd]

        tdf#161994 annot: trigger selection of the current annotation
        
        Delete annotation isn't active if no annotation is selected, but
        we do not report a new selection anymore, so fix this.
        
        Change-Id: Idb455d0c0d42412c55de4a7ca037342b58da548b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170429
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [45d8c51610ce8e8989961135249af0b89544c094]

        annot: simplifx getting the proper window for popup
        
        Change-Id: Ic9e01d57137ddfbb6f4ec741a275b579741675a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170428
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [ccc3996cfcbebe14e9d5f3511906cfc64ddf3452]

        tdf#161990: take MapMode's origin point into account
        
        Regression from commit cc3663bbaed4f65d64154e5f9abb51a5f622f710 (tdf#160702:
        improve text positioning, 2024-04-20).
        
        Change-Id: I03f461d7f03c3e67ccdb8c4376720feb69903d6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170432
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [86fc557c70e69d6c0a2d6a89b7a7f2cd261a1f40]

        Add a note about autogen.input into autogen.sh --help output
        
        Change-Id: Ie983645114817d3cadca8b5f243f4a47db054e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170435
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4724386984b476a303e092a133905c20aaa34687]

        cid#1609652 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0d8901983a81b84d653b4279e90fd961b97ed0d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170436
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22909e7e94c542698f8a1c13151f67fbf2d0073a]

        cid#1610240 Unchecked dynamic_cast
        
        Change-Id: Iee9088344bb3319b751bc3c611ad0ab5e42374b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170434
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72922587b9f8755bd06ea1a50a0387cb072f17dc]

        cid#1610241 silence Improper use of negative value
        
        Change-Id: If258376bb3303ea6cd497c30c0610f22f7fe2f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170433
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-13  Noel Grandin  <noelgrandin@gmail.com>  [154b2040102d74aeb4c5d0cf07f1bdc90d265d52]

        boost::unordered_map to std::unordered_map in configmgr::Partial
        
        Change-Id: I030a175af694d1e0025ac2c047141913b08c3be4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170395
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-13  Noel Grandin  <noelgrandin@gmail.com>  [3fcdebc47275d739d8b68e66eca5cbafea8ffc7f]

        use DeleteOnDeinit for EditEngine pool
        
        to avoid it accidentally coming to life during shutdown.
        
        Change-Id: I016a3396639c30350432b60c375c9777e551eb84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170425
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [b5907f1d6e06bf6c28a06c87cfc4de7b7e96b454]

        Simplify a bit
        
        Change-Id: I7eaedfcd630a71ca2966d9622121c40aefae1e03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170427
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-13  Laurent Balland  <laurent.balland@mailo.fr>  [9eeffa4d2bd09e6f6f9ada7dd2fd10ed6ab8cde4]

        Update Beehive template
        
        - group hexagons
        - replace correctly hexagons
        - use Outlined Yellow and Filled Yellow as styles for hexagons
        - correct ODF validator errors
        
        Change-Id: I5f618f9812230ccf54763638c51adf197e87efea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170066
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-07-13  Laurent Balland  <laurent.balland@mailo.fr>  [45a306ddd18a448254cce92c6b9301aabc9558a9]

        tdf#161799 Preserve default styles in Freshes template
        
        Same as https://gerrit.libreoffice.org/c/core/+/169661
        for Freshes template
        
        Change-Id: I20630ef6a1b1c31c9b91bfc4c3389609586c6414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169768
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-07-13  Julien Nabet  <serval2412@yahoo.fr>  [1f8a9bfcdb83446b49e74dba241f9924d3b74748]

        Python: use is None/is not None instead of == None/!= None
        
        Change-Id: I1c34181897506ad29a063865d752cb85ab76dbc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170408
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-07-13  Jonathan Clark  <jonathan@libreoffice.org>  [4c8f88bef948b18f3d810c29a7f83496367758a9]

        tdf#92064 sw: Improve Tibetan layout performance
        
        This change includes the following scalability improvements for
        documents containing extremely long paragraphs:
        
        - Reduces the size of layout contexts to account for line breaks.
        
        - Disables a misbehaving glyph cache performance optimization for long
          strings.
        
        Change-Id: Ie9a3365076c0d112a7a655988d672a9f4609b42b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170420
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-13  Julien Nabet  <serval2412@yahoo.fr>  [08e117def0dc8541c177a2a1a0700fac9635f0fc]

        Reindent mailmerge.py to use 4 spaces instead of tabs
        
        No functional change.
        I used reindent.py from https://github.com/certik/python-3.2/blob/master/Tools/scripts/reindent.py
        
        Change-Id: I03c5425ef26131f09e0b9de56737b2e069722e7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170419
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ddcca37dbf96bf05912c4ab30b43702138896677]

        cid#1607312 silence Overflowed integer argument
        
        Change-Id: I5de8e5756bbbe1d47d9dd40c2d49122ef8e7f15b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170418
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b11c113e9f07d1b60ad2a3d19ef8d089bfb4ab1]

        cid#1607641 silence Uncaught exception
        
        Change-Id: I26b4c999cfd6d782c340a7a101b11c979d0a8329
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170416
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [725d235c53efc3665736d49c7b27e025c3ccbad0]

        cid#1607932 Unused value
        
        since:
        
        commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62
        Author:     Jens-Heiner Rechtien <hr@openoffice.org>
        AuthorDate: Mon Sep 18 23:08:29 2000 +0000
        
            initial import
        
        Change-Id: Ic853ca130d45c2393f0f6b20877a4461ef6fa585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170415
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e55d482b19812e2fc3063eb7e718d7013635b33]

        cid#1555962 Use of auto that causes a copy
        
        and
        
        cid#1556100 Use of auto that causes a copy
        cid#1556199 Use of auto that causes a copy
        cid#1556239 Use of auto that causes a copy
        cid#1556313 Use of auto that causes a copy
        cid#1556373 Use of auto that causes a copy
        cid#1556680 Use of auto that causes a copy
        cid#1557020 Use of auto that causes a copy
        cid#1557099 Use of auto that causes a copy
        cid#1557251 Use of auto that causes a copy
        cid#1557334 Use of auto that causes a copy
        cid#1557468 Use of auto that causes a copy
        
        Change-Id: Ib5ab5b33eabcac3d18899ceaaa9119e13b0139f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170412
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f0f0bbaebfc0added603a04918324df58b6c27b]

        cid#1555513 silence Use of auto that causes a copy
        
        Change-Id: I9c079460215ca2c62126a04caec2b1246dff0f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170411
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6fb455deeef8f5199a53dda4ee6fdad9667d482]

        cid#1555260 Use of auto that causes a copy
        
        Change-Id: I256705562832a408b751b28c0bb133f4561e5522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170410
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a0f3225984f865b9604c420543a5951a21185ba6]

        Turn org.libreoffice.embindtest.Test from singleton to service
        
        ...so that testing its StringAttribute stars out with a known state.  And which
        revealed that the test code in unotest/source/embindtest/embindtest.js was
        actually wrong in assuming that that UNO attribute would be represented by a JS
        accessor property, when actually it is represented by a pair of
        get-/setStringAttribute member functions.
        
        Change-Id: I1a6e7c9f26e9a08cd089b7972a23f4c608c6b1bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170414
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [f74bb604ff043caa552d809bd8e9157ac7854f96]

        Make SystemDependentData mechanism type-based
        
        Up to now that genereal buffering mechanism used
        typeid.*hash_code to identify the class. As we
        have learned this is not safe. Thus I changed it
        to use enum'ed SystemDependentDataType definitions
        
        Change-Id: I803912ec419290db1d40bae0bc41364fad64cbfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170385
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [943ee532597d24c50e650b8910241c0b7a3a6fef]

        cid#1555177 Use of auto that causes a copy
        
        Change-Id: I35cd8baa84fdbca49c17143968a71dcc9a0d760f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170409
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [629a20b97f186531d73d78ef8a02e5def35f22e1]

        tdf#159776 - A11Y sidebar: Fix no warning about multiple tabs
        
        used for creating spacing.
        
        Change-Id: I9a2725954406140efa27ccc3ae30f19d0bd1fa8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170387
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [8b8fd948cfe1b0f146f2fbe4779efe1fb7a37a59]

        Optimize a bit
        
        Change-Id: I676533742f1a91bb1f68b0098a1d54a93d09c6ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170402
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [79b6c25a2a0bf64f08f19a6c81549932b34fc3e6]

        cid#1555445 silence Using invalid iterator
        
        Change-Id: I7a4084a9b35f808f41abb4509315d5441eb526e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170396
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [64021a103945f8c77787b7281192643002712b1e]

        PyUNO bridgetest: adapt to alias removals in unittest module and
        
        fix syntax errors
        
        Change-Id: I7e853ba25fd0b541ea7d2770335810b2d9dcb207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170399
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [2f113fe5b2aeb2b9ca7866d88c31c0cc09889e2a]

        tdf#161785 Fix order overlays are repainted
        
        Prior to this patch, the selection overlay was painted above the cursor when scrolling/resizing the window. This patch reorders it so that the selection overlay is always below the cursor.
        
        Change-Id: I5a9a66eeb6285b4a9b8954a44189ddcb6039d155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170299
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [410da49f0116dc76f9b8438af8109501e8a9dcd4]

        tdf#129244: fix thinko
        
        Change-Id: I838dfce7d9d329a938c09a2a114dbafffe149ace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170405
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-12  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [fe897b36aef28dfe175461c43614e22588fcfd84]

        tdf#158510 Launch media from a presentation dir path
        
        Added a check for the existence of a file at a given URL.
        If the specified file could not be found, the path formed from the
        directory containing the presentation file and the file name is used.
        
        Change-Id: Ia4124f4fa5e5cef19c81f325676749a2540e486a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164023
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7fbce44cac0dc5e233ef1367b0162d7fab46bd86]

        Fix typo
        
        Change-Id: I1782388a1d6d3e554867427532f4eb98d7ca200a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170403
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [c2eb8d81e01ff016358c573b6d2f6c28e14f575a]

        tdf#129244: Let ImpGraphic update its buffer for new pixel sizes
        
        It used getVectorGraphicReplacement once,  getting a bitmap with pixel
        size that depended on the default device DPI,  unrelated to the needed
        bitmap size. It was not updated later, using the cached bitmap for any
        requested size.
        
        The DPI passed to convertPrimitive2DSequenceToBitmapEx  must represent
        the relation  between the vector logic size  and the pixel size of the
        generated bitmap, not the target device DPI.
        
        This change introduces VectorGraphicData::getBitmap to obtain a bitmap
        for any requested pixel size, and uses it every time in the introduced
        ImpGraphic::updateBitmapFromVectorGraphic method every time it needs a
        new size of the image.
        
        Change-Id: Ife1305821fff28f0cd4070615ab032211a5d8c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170391
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ee63aeb69a0d5758a1f7acb65167c0a251e2da9a]

        A mechanism for annotating the embindmaker-generated JS UNOIDL data
        
        As we need to generate data upfront for all the UNOIDL entities anyway, we might
        just as well extend that with annotations (keyed to some new
        Module.unoTagSymbol) that are useful at runtime.  The general idea is to let
        such annotations be objects with certain well-known keys, the main one being a
        string-valued `kind` representing the UNOIDL kind of the annotated data.
        
        As a first thing, individual UNOIDL enum type enumerators are annotated with a
        `type` representing the UNOIDL enum type they belong to.  That turns out to be
        useful for some experimental approach of mine where I wrap the Embind-based JS
        binding in something that makes the result more idiomatic JS.
        
        Change-Id: Iec466bab05ba3d1b56b2398e5c361465af49dc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170398
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-12  Miklos Vajna  <vmiklos@collabora.com>  [a9f3c11375525a7708378dd3648febc40db1ad20]

        tdf#162002 DOCX import: ignore subsetted embedded fonts for editing
        
        Open the bugdoc, some characters use a fallback font, some not, while
        the same font is used in Word for all characters.
        
        It turns out that the bugdoc has a subsetted embedded font, and the font
        only has 8 glyphs, which explains the inconsistent rendering.
        
        Fix the problem by ignoring subsetted fonts for the editing case: if a
        font is subsetted then only use the embedded font for viewing. First
        also had to fix up the tokenizer, as it had the wrong type for the
        subsetted attribute, so we couldn't get its boolean value
        (OOXMLStringValue doesn't override getInt(), so OOXMLValue::getInt()
        returns 0 unconditionally).
        
        Note that in theory we can have embedded fonts which are nominally
        subsetted but in practice they have a "reasonable" amount of glyphs in
        them, those are currently discarded, but should be probably still kept
        in a follow-up change.
        
        Change-Id: I3e6dfbb246d464fede64f183a3f244edc70e7b8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170397
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-12  AhmedHamed  <ahmedhamed3699@gmail.com>  [f5685bdfff370be57cf37f1dc746026c6bfd6113]

        tdf#161534 Add a Help button in FD & FW to open respective Help documentation
        
        Change-Id: I35f5965401e970e02fa196f767bbd08d00de424f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170181
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-12  Attila Szűcs  <attila.szucs@collabora.com>  [f8e7da23b64580d4bc45abb159651c63b578be8d]

        SW: exctract document structure
        
        It extract form controls, and write its data to JSON.
        
        It is a basic 1. version, for now it only recognize:
        -PlainText (and write its text)
        -CheckBox (and write its state)
        
        but it writes some common data for any type of controls:
        ID, alias, Tag, TabIndex, and its index.
        
        Change-Id: I9ff74cd013c6f1118942207059181678713504af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170381
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-12  Michael Stahl  <michael.stahl@allotropia.de>  [e2d82681a8055d0d4e7007b8dacf38f5675bc70f]

        sw: layout: ShrinkFrame() may do nothing for layout frames...
        
        ... which may cause empty pages, so explicitly set the height to 0.
        
        (regression from commit 2dce213ce9f399c6ce1a3e928f34fa27988fa833)
        
        Change-Id: Ife5c2873b375431d2dd90c9b7e8b3b8c40a9cf7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170383
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-12  Miklos Vajna  <vmiklos@collabora.com>  [2b7beea2872fd0b2c9bd1d838a0a82dafd546036]

        sw doc model xml dump: show parent of char styles
        
        Similar to how SwTextFormatColl::dumpAsXml() does it for paragraphs.
        
        Change-Id: I23dd3da9ce60d5e11f93cec75c54254ada4e9244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170392
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-12  Patrick Luby  <guibmacdev@gmail.com>  [c2061f21b1a88c9692a4e081280ed2c52e0b9141]

        tdf#67943 tabs must have radio button role and tab button subrole
        
        Also, reimplement -[AquaA11yWrapper tabsAttribute] to return children
        for tab bars. This will cause VoiceOver to announce that the currently
        selected tab is "X of Y" tabs in the tab bar.
        
        Change-Id: I2c3b890fd445c22842b90d60170a71e4e8aa91ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170389
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [1c892a7729234202e6ce14e116e91786b248835a]

        icon choice ctrl entry a11y: Use OAccessibleComponentHelper as base
        
        Let `AccessibleIconChoiceCtrlEntry` derive from
        `comphelper::OAccessibleComponentHelper` which
        allows simplifying the class. It just requires
        implementing the virtual `implGetBounds()` method
        and provides implementations for the the other
        location/size-related methods using that, so drop
        the custom implementations doing the same.
        
        This also makes it unnecessary to implement the
        `XAccessibleEventBroadcaster` methods ourselves,
        so drop the custom handling and
        `AccessibleIconChoiceCtrlEntry::m_nClientId`
        altogether as well.
        
        Change-Id: Iaa14293a911ea7b199a21baf8c5c3cfb5075efcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170380
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [a8314f77a4735d50b51dacddc810a3790faf35dc]

        icon choice ctrl a11y: Drop extra check
        
        `AccessibleIconChoiceCtrl::getAccessibleChildCount`
        returns the the number of elements in the
        `SvxIconChoiceCtrl_Impl::maEntries` vector, and
        `SvtIconChoiceCtrl->GetEntry` returns the
        the element at the given index.
        
        Given the index check above, a valid entry
        should always be there, so drop the extra check
        that would throw a RuntimeException
        in `AccessibleIconChoiceCtrl::getAccessibleChild`.
        The `pEntry` isn't otherwise used right here anyway.
        
        Change-Id: I446b6d8d92780d484ebf5fc531bfa51a7c87cac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170372
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [705d64253357313ce9630e533fd6b6823fc50dfc]

        icon choice ctrl a11y: Clean up/simplify selection handling
        
        As mentioned in
        
            Change-Id: I852b5bf7480daf18bfdf26c3105849c27624ad8c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 10 10:18:42 2024 +0200
        
                icon choice ctrl a11y: Don't allow unselecting entry
        
        , only a single entry can be selected, and that one can be
        retrieved via `SvtIconChoiceCtrl::GetCursor` and set via
        `SvtIconChoiceCtrl::SetCursor`.
        
        Therefore, don't try to set multiple cursors in
        `AccessibleIconChoiceCtrl::selectAllAccessibleChildren`
        and don't loop over all entries in
        `AccessibleIconChoiceCtrl::getSelectedAccessibleChildCount`.
        
        Change-Id: I9b01c76a546b3d385a91e87d1a8e29e80a4aef17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170371
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [8442163e22a271f19347f5584ef18a7e7a13b9af]

        icon choice ctrl a11y: Don't report selectable state for list/tabbar
        
        While entries can be selected and the `SELECTABLE` and
        `SELECTED` states are reported accordingly for them in
        `AccessibleIconChoiceCtrlEntry::getAccessibleStateSet`,
        reporting the selectable state doesn't make sense for the
        `AccessibleIconChoiceCtrl` itself, so drop that.
        (The `SELECTED` state also was never reported,
        without which the `SELECTABLE` state doesn't make
        much sense.)
        
        Change-Id: I8e7e501b9052b47babc835b6e03266f2cbfcf699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170370
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [b3f8d9212e477bca4f94392bcc8e2d3efdcd65fa]

        icon choice ctrl a11y: Don't allow unselecting entry
        
        `SvtIconChoiceCtrl` is (only) used in
        `VerticalTabControl`, and having no tab
        selected doesn't make much sense. Support
        for non-single selection modes was dropped in
        
            commit af9413cb4ad49c0b4854c08cc2804644220755ae
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 11:53:27 2024 +0200
        
                tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        Consequently, also drop support for explicitly
        unselecting one or all entries via the
        `XAccessibleSelection` interface in the corresponding a11y class,
        `AccessibleIconChoiceCtrl`.
        
        Drop the now unused `SvtIconChoiceCtrl::SetNoSelection`
        and `SvxIconChoiceCtrl_Impl::SetNoSelection`.
        
        This is also in line with handling for the the non-vertical
        tab control used elsewehere.
        
        Change-Id: I852b5bf7480daf18bfdf26c3105849c27624ad8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170369
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [791c5b52f297f13746f4c23b005820b5e1adaddb]

        icon choice ctrl a11y: Don't explicitly unset selection
        
        `SvtIconChoiceCtrl::SetCursor` already takes care of
        unselecting all other entries when one is selected,
        so there's no need to explicitly call
        `SvtIconChoiceCtrl::SetNoSelection` first.
        
        This can e.g. be tested by triggering the action
        of the entries in the "Insert" -> "Hyperlink" dialog
        in Writer from Accerciser when running LO with the
        qt6 VCL plugin. The action causes the corresponding
        entry to get selected.
        
        Change-Id: Ic0c31d987b286095d58756fd92aacc662a723680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170368
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [818619567daf5ea72f4c10eb0728717744d36550]

        icon choice ctrl a11y: Drop misleading comment
        
        There's only a single action, so the "only three actions"
        comment is misleading. Drop it.
        While at it, switch from `#define` to `constexpr`
        for the `ACCESSIBLE_ACTION_COUNT` constant.
        
        Change-Id: I2a031419d6166dee7f63612c6d51cc1232151110
        
        Fixup
        
        Change-Id: Iea85d528468d7ae97b98439715cb9e18ee1d1fab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170367
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [69fc5c396059603804b17b0f0cb076fff7188cba]

        Rename wasmcallgen -> wasmbridgegen
        
        ...to acknowledge the tools' more general role since
        74829f2a64b6989ddf1d126a6fd2f2d2e9000d3b "Fully implement the Wasm UNO bridge
        cpp2uno direction"
        
        Change-Id: Ie89255579774035f7b726d1d4b029dc536893ca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170382
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b7a6d5752a3f60dc29cde6ea05ee6b7112dc4780]

        tdf#108828 Show certificate selector again after cancelling password dialog
        
        Change-Id: I0a57204c1885ca300d22832e5469d8918aec9ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170384
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [406a7e9d452201f3fd53abc770da6eb9589fff92]

        fix locking in UpdateRequiredDialog
        
        Ever since
            commit 838036c304d474fc4c19e2fc59cadc6ba457c9ee
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Mar 7 13:46:29 2023 +0200
            osl::Mutex->std::mutex in UpdateRequiredDialog
        
        Calling from disableAllEntries, which takes a mutex, to
        hasActiveEntries, would deadlock.
        
        Noticing that this class is trying to use a mix of the SolarMutex and
        its own mutex, rather just use the SolarMutex everywhere, which is much
        safer, and not a problem in a place where performance is not an issue
        
        Change-Id: Id241c3b811f314d75de03c4c647c0594b8d498bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170283
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f03610e9700c811158d034e54016e9ee3d1645b1]

        Resolves: tdf#161965 missing UpdateControlStates on page switch
        
        since:
        
        commit a70ad1568ea0fb5b4d7f888fb56fcee130afc433
        Date:   Mon Dec 5 11:44:48 2022 +0000
        
            Resolves: tdf#121297 weld Presentation Minimizer
        
        Change-Id: Ibe28ba79d958d306440807adec9c5bbb64a8801d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170151
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [8708e8cf90d0ac0acbbce34b82f10ef7352d5062]

        tdf#161026 tdf#161355 tdf#161501 icon choice ctrl: Natively draw mouse-hover
        
        ... feedback.
        
        Instead of always using `SvxIconChoiceCtrl_Impl::DrawHighlightFrame`
        to draw a frame around the currently mouse-hovered item in
        the icon choice control/vertical tab page, use the native
        drawing API to let the backends draw a `ControlType::TabItem`
        with the `ControlState::ROLLOVER` state set.
        
        This also aligns this more with the horizontal tabbar used in other dialogs
        (s. `TabControl::ImplDrawItem`).
        
        With this commit in place, the hovered vertical tab in
        e.g. the "Insert" -> "Hyperlink" or "Format" -> "Page" vertical
        tab dialogs is now displayed "properly" and in line with what
        happens for non-vertical tab pages (like the "Format" -> "Paragraph"
        one) on Windows or with the Breeze and Breeze Dark themes and
        the kf5 VCL plugin on Linux.
        
        Instead of just using the native drawing API for the mouse-hover
        feedback, this could likely be extended to also take care of focus,
        selection, etc. in a follow-up step.
        
        Change-Id: I5437d18cb78e8da0736c9ab920c55b90af4d0e25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170341
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [6a3f91c4e9c669fc445eab8f3c526233cd68fdb9]

        tdf#161026 tdf#161355 icon choice ctrl: Draw icon + text at the end
        
        Draw the entry's icon and text after drawing other things, to
        make sure it is on top, i.e. always visible.
        
        This shouldn't make any difference by itself yet as currently
        only frames/borders are drawn after it, but that will change
        with an upcoming commit to use the native drawing API for
        taking care of at least the highlighting part.
        
        Change-Id: I97cebdf2470ea1ab92e56642e4b4fd4255542994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170340
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [5db251640b24747a349eec2c3e53902f3f91eec9]

        icon choice ctrl: Decouple focus from text/icon drawing
        
        Move focus drawing out of `SvxIconChoiceCtrl_Impl::PaintItem`,
        where it was drawn for the `IcnViewFieldType::Text` case,
        since that's not actually related to drawing the text.
        
        Move it to just after the (only) call to
        `SvxIconChoiceCtrl_Impl::PaintItem` with the
        `IcnViewFieldType::Text` parameter instead.
        
        Change-Id: I7c2bda33cb9107535569492db70d3b23b9280a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170339
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0e613527051dc1bc00129039a405bebd75feefb]

        svgio: simplify and rename to make it easier to understand
        
        Change-Id: Ia1cc5451d4075237f369ecda45300bccdc02c974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170378
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [626357f53c934e7f57dc80c3c83ad080767961f3]

        Use configured bullet symbol when clicking bullets button
        
        Instead of the generic default symbol
        
        Change-Id: I0923d4ede5d7cc09d61bb57d5cb6dbf6f2af8058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170373
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-07-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [74829f2a64b6989ddf1d126a6fd2f2d2e9000d3b]

        Fully implement the Wasm UNO bridge cpp2uno direction
        
        ...after 875997c8962da7f6b72950b201186a19b3c20d3a "Properly implement
        cppu::throwException for Emscripten" had implemented only those parts that were
        absolutely necessary for that exception throwing.  As detailed in the commit
        message there, wasmcallgen has been extended to additionally generate all the
        required vtable slot call trampoline code (which cannot be generated on the fly
        for Wasm, as would be done for other platforms).  Consequently, some of the
        "callvirtualfunction"-centric file names have been changed to "generated" as the
        output of wasmcallgen is now more general.  (And wasmcallgen itself should also
        be renamed, in a follow-up commit.  And when adding to the wasmcallgen code
        here, some existing parts of its implementation have been cleaned up, too.)
        
        There is no direct way to test this half of the Wasm UNO bridge directly from
        unotest/source/embindtest/embindtest.js, so a new
        org.libreoffice.embindtest.BridgeTest singleton has been added, which triggers
        new test code in unotest/source/embindtest/embindtest.cxx that tests the bridge
        in a way similar to testtools' bridgetest machinery.
        
        Change-Id: I521a1d6c2160aedc814f7603b0b99861e5fbd1eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170374
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c5f93ee35f0d9ecaa01e3243ae6bfa1bc148df9]

        tdf#161985: getOpacity is also called from other places
        
        Partially revert 56039daae4a436d7ea1b093a02cf0e8ad3bda4a9
        "tdf#149673: only check opacity from parent..." to make
        getOpacity behave as before and move the new behaviour
        of getOpacity inside add_postProcess
        
        Change-Id: If475cddbc4967308fa06adacda621cb3790c6f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170376
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8f9b8b6d5ddcdb4e0422f55d67f38063d53b8c21]

        Don't save bullet changes when dialog was cancelled
        
        Change-Id: Ia2a7feb2f47a59f7c693e2023f9c2c8b3b934f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170336
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-07-11  Pierre F  <fpy@bger.ch>  [40e3a66db506b5b4f123325fcb1844764367565b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3836c655e7d419cd3d401e51e4572996b4308a85
          - clarify SUBTOTAL example. from https://ask.libreoffice.org/t/autofiltre-sous-total-nb-si/107742/7
            
            
            Change-Id: I8947feee1c862751124d372ac84f68ab838e34f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170294
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-11  Patrick Luby  <guibmacdev@gmail.com>  [05d304ce155bb8a967c55f7b037dfbfe3ad6a416]

        Move break inside conditional statement to match macOS code
        
        Commit 839346d3f20af0c6db1377486cbff3f2ff3e2387 for iOS was miscopied
        from commit e4cbe169bd1236698a573bf4758d8ae8519a1c08 so correct the
        copy error to bring the iOS code back in sync with the macOS code.
        
        Change-Id: I3bb8cc85465adf978e50fab1a802c3f062b7a728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170067
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit e1cfc655e5112b4767da7c53000b859f3844b8e3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170110
        Tested-by: Jenkins

2024-07-11  Dione Maddern  <dionemaddern@gmail.com>  [72c45103ebdf94af6254eaf01bec1182c967a17f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b719a26a02e1789d393a33156ab43a6b9d43b094
          - Consolidate help pages for the Styles Sidebar deck into one page
            
            Create new page text/shared/01/styles.xhp
            
            Delete pages
            - text/scalc/01/05100000.xhp
            - text/simpress/01/05100000.xhp
            - text/swriter/01/05140000.xhp
            
            In AllLangHelp_scalc
            - Remove reference to text/scalc/01/05100000.xhp
            
            In AllLangHelp_shared
            - Add entry for text/shared/01/styles.xhp
            
            In AllLangHelp_simpress
            - Remove reference to text/simpress/01/05100000.xhp
            
            In AllLangHelp_swriter.mk
            - Remove reference to text/simpress/01/05100000.xhp
            
            In source/text/scalc/01/cell_styles.xhp
            - Add variable tags to H1 to allow the page to be more easily linked from other pages.
            
            In text/swriter/01/05130000.xhp
            - Add variable and link tags to H1 so that the page can be more easily linked from other pages.
            
            Replace links to deleted page text/scalc/01/05100000.xhp with links to text/shared/01/styles.xhp in:
            - text/scalc/01/05120000.xhp
            - text/scalc/main0103.xhp
            - text/shared/01/05140100.xhp
            - text/shared/02/01230000.xhp
            
            Replace links to deleted page text/simpress/01/05100000.xhp with links to text/shared/01/styles.xhp in:
            - text/sdraw/main0103.xhp
            - text/sdraw/main_format.xhp
            - text/shared/01/05140100.xhp
            - text/shared/02/01230000.xhp
            - text/simpress/guide/masterpage.xhp
            - text/simpress/main0103.xhp
            
            Replace links to deleted page text/swriter/01/05140000.xhp with links to text/shared/01/styles.xhp in:
            - text/shared/01/05030000.xhp
            - text/shared/01/05040100.xhp
            - text/shared/01/05060000.xhp
            - text/shared/02/02010000.xhp
            - text/shared/menu/style_menu.xhp
            - text/swriter/01/05030800.xhp
            - text/swriter/01/05130000.xhp
            - text/swriter/01/05130004.xhp
            - text/swriter/main0103.xhp
            - text/swriter/main0503.xhp
            
            Change-Id: I20fc2a142107b3984abf1491459f3f485cd01f46
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169950
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-11  Heiko Tietze  <tietze.heiko@gmail.com>  [3d4986cf3c94524a2cbb1a3313d7669ad369ea11]

        Always show donate icon in startcenter
        
        Issue on gtk3 environment only
        
        Change-Id: I251cf91fd04ed455383e443b5479e199486f7aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170325
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-11  Justin Luth  <jluth@mail.com>  [e83f301172525fc342f155772bf2c83a3a7ead35]

        NFC sw fmtcol.cxx: use better naming for "old" and "new"
        
        No Functional Change: at least to me it makes reading easier.
        aNew led me astray many times.
        
        Plus, don't use |= when there is only a single assignment.
        [This came about recently, when LRSpace was split into three,
         so originally it was doing the same as ULSpace which
         has the double assignment. So it made perfect sense before...]
        
        Change-Id: I67b587cf5853e1743b9faf414f95e713c3b0f006
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169894
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-11  Szymon Kłos  <szymon.klos@collabora.com>  [2fe59dc6e8b5ac9c6b312d1e4a3f4c71e1d0f5bc]

        lok: sd: slideshow render: avoid using nullptr
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I9368a256185aa336c6cc3ed398ff1d28f6498453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170306
        Tested-by: Jenkins

2024-07-11  Michael Stahl  <michael.stahl@allotropia.de>  [2dce213ce9f399c6ce1a3e928f34fa27988fa833]

        sw: layout: invalidate upper when hiding frame
        
        If a text frame is in a fly frame, and View->Field Names is turned off,
        the text frame is hidden but the fly frame is still the same size as
        before.  Call ShrinkFrame() to do some invalidations.
        
        (regression from commit fc1e6a64bd0517a7e67f08860c29b44d030220eb)
        
        Change-Id: I154551ebaa2370d088b12e178954f92d33056711
        (cherry picked from commit b77ebc93844f1b54c74ae5db9253a1d3ff618968)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170323
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [e02349160012837dd2b8d330e474b2da7cec7dc9]

        update tsan suppressions
        
        Change-Id: Idf0a98869e46de08165aacb7f3836b0d6c3dffcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170335
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-11  Heiko Tietze  <tietze.heiko@gmail.com>  [dd4d32797c7c4cb915f1f81ad92abb195985afb5]

        Fix to temporary variable name
        
        Change-Id: I87be9a7b5cd2627844ab7b5f0c838eddbeb01b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170319
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-11  Justin Luth  <jluth@mail.com>  [aaf93cd9629acd476284a4933a656ddd188a80aa]

        tdf#160139 sw RTF paste: don't empty headers/footers
        
        Regression from quikee's 24.2
        commit 4b0fa253a4540f5461397815d290586f9ddabe61
            tdf#136472 adjust ooxml import to handle first header/footer
        
        RTF paste is particularly nasty because it calls CloseSectionGroup,
        which is rather strange for just pasting some characters...
        
        Fix the problem by leaving the paste alone:
        we already omit a number of actions in this case,
        and was similarly done initially by quikee in copyHeaderFooter.
        
        setHeaderFooterProperties() was newly added by quikee,
        so relatively safe to start avoiding on paste.
        
        make CppunitTest_sw_writerfilter_dmapper \
            CPPUNIT_TEST_NAME=testPasteHeaderEmptied
        
        Change-Id: Iad997481a75bb971f9e71373175134cbec9aa7d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170328
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [858c0780563b9dcb1e08f945e427b3fd61af653a]

        Update preprocessed_command with the end result of the path checks
        
        So we don't rely on ShellExecuteExW doing the same.
        
        Change-Id: I83efe08b0e0fe062c6e0402fab8ebbf36e56cadc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169908
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ece698a575710ac7de0c628ef7b8dc7f59e03108]

        ITEM: replaced typeid/hash_code with SfxItemType
        
        for the ItemInstanceManager the identification was done
        using typeid/hash_code, but that has problems - it is
        only defined to be identical for two instances of the
        same type, but other types can have the same code.
        Thanks to Noel to find that out, that is not reliable
        to be used.
        In the meantime we have SfxItemType to identify Item
        instances, so I changed the code to use that.
        The master had five additionally added Items that
        use the (2a) method of this mechanism (see comments
        in svl/source/items/globalpool.cxx for that). The
        gloal is to use as less as possible of this Items in
        that mechanism, so I checked.
        For four of these hashing was used, so the mem/runtime
        aspect is okay -> access is fast enough to prefer
        mem over runtime. Adding hashed Items (or any other
        fast mechanism) is always okay.
        One did not have that (SvxBoxItem) and used just the
        fallback ItemInstanceManager, so I removed it. We
        now have 18 Items for which that mechanism is
        initialized immediately.
        Noel also already moved the countdown for starting
        to use the mechanism in case of default handling
        (case (1), NUMBER_OF_UNSHARED_INSTANCES) to the
        unorderd_set. someting I had already planned to do,
        too - thanks!
        
        Change-Id: Icf6f427e5ea64672f385357aaad75bb5b7fcbf98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170314
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [27829e4a6c5a4a1162599550c46b5e7f974aba91]

        CairoSDPR: Improve BColorModified Bitmaps
        
        There is the complete BColorModifierStack support for
        primitives for Bitmaps, e.g. hue/saturation, etc, but
        it was slow due to not being buffered, so had to be
        re-created often. I changed this to use the common
        buffering mechanism to improve this.
        Up to now a fallback to use the old Graphic
        manipulators for that purpose was in place since this
        was faster, but had to be done every time. I have now
        changed the priority to using the primitive way to
        handle things, but kept the fallback code - just in
        case.
        Note that the new stuff is faster, but even much faster
        when the bitmap is copied and appears multiple times ->
        the same buffered instance is used, and SDPRs then use
        the system-dependent data buffered at that prepared
        data.
        Also note that this change does not only speedup
        CairoSDPR, but all PrimitiveRenderers, including the
        VCL and Metafile ones. In principle everything that
        uses BitmapEx::ModifyBitmapEx.
        Had a 2nd thought: Only the content Bitmap gets changed,
        so for this case we do not need AssociatedAlpha and
        watch for it to not have changed. Removed that.
        
        Change-Id: I2ee36cc84bdc1c723aa01f872edbfd1f51e11c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170305
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-11  Juergen Funk  <juergen.funk_ml@cib.de>  [c92e4d1a944019dd5b14cdce3d85213d2a8d9e92]

        tdf#161538 fix empty page inserted into specific file
        
          - the empty pages can be switch off with
            "Print automatically inserted blank pages"
        
          but when the switch is off, the view of the
          "Print Prewiew" was wrong when scrolling,
          this patch fix that
        
        Change-Id: I62627b8d65db325e12818c91fee3e3c7c89c7751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170278
        Tested-by: Jenkins
        Reviewed-by: Oliver Specht <oliver.specht@cib.de>

2024-07-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [35e5abe8e569c67fbb0afe84afbd826373470a8c]

        Improve tab order in paragraph dialog
        
        Group similiar tabs, put the most used ones (font settings) first, etc.
        
        Change-Id: I4e2931b30605086da588b3fdcd523faa34bb452a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166770
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a15e387775b02489e5aafcee7cf3250dad9a10d0]

        cid#1608274 silence Overflowed return value
        
        Change-Id: Ia4472781f51117e3a9cdcfbdb6fe62cd56f9dfe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170322
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e68f28ec9f68a1f70afce7acfa38ce7a63ccdafe]

        cid#1607892 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1607910 COPY_INSTEAD_OF_MOVE
        cid#1607818 COPY_INSTEAD_OF_MOVE
        cid#1557402 COPY_INSTEAD_OF_MOVE
        cid#1556530 COPY_INSTEAD_OF_MOVE
        cid#1557396 COPY_INSTEAD_OF_MOVE
        cid#1556522 COPY_INSTEAD_OF_MOVE
        cid#1555628 COPY_INSTEAD_OF_MOVE
        cid#1554705 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iae3fbf4a04bf3714f416995640b9d70fe204cf73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170321
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3aac0f9b378e12cb51d8e8239f8c0f7627d0f8ca]

        cid#1555404 silence Different smart pointers managing same raw pointer
        
        Change-Id: I6de83a2209129745667e0d3f3768e87a226252e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170320
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-11  Justin Luth  <jluth@mail.com>  [0abe0f62b9913ceb77c7ac067f1074ce0395ab93]

        tdf#160976 rtfexport: export first header as well as default header
        
        LO has never handled exporting "different first header"
        ever since it was introduced in LO 4.0-ish.
        
        In 24.2, quikee change the RTF import to default to putting
        headers into "different first header" instead of "First Page Style"
        with commit 4b0fa253a4540f5461397815d290586f9ddabe61,
        so this existing problem has become more pronounced.
        
        Unhandled still is any attempt to handle different even/odd pages.
        
        This patch also reduces the number of \titlepg duplicates.
        
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf160976_headerFooter
        
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf160976_headerFooter2
        
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf160976_headerFooter3
        
        Change-Id: Idc12c57b69ff83cbdcbac3f6a469fadd8f26fe2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170326
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-07-11  Justin Luth  <jluth@mail.com>  [eaca93b19ebf91e495c0985f304bfa6687c55c8d]

        tdf#159013 writerfilter: link to the correct first-page header
        
        We have always done this wrong, but previous to
        quikee's 24.2 4b0fa253a4540f5461397815d290586f9ddabe61
        it left the first page blank (I expect),
        while recently it was copying the "normal" header.
        
        In order to avoid a UNO copy assert (if copying an empty footer)
        track the header and footer style separately.
        Alternatively I could have probably removed the UNO assert.
        Alternatively, I could track if we ever had a first header
        and a first footer - at that point they will be copied to same style.
        
        make CppunitTest_sw_core_header_footer \
            CPPUNIT_TEST_NAME=testTdf1159013_firstHeaderCopy
        
        Change-Id: I7c5046731766a70625b1a6a8696239297369e2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170259
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b547e9f19de339531709c14931998125b9a41649]

        tdf#161911 annot: fix for annotation with 0 size
        
        We need to set the size to something non-zero or it will stay
        zero even if we try to adapt the frame to the text content.
        
        Additionally when we adapt the frame to text, we need to update
        the annotation with the new size.
        
        Change-Id: I4125f95fe6d0e55ab3b00a6a457cd2c9e04ec7c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170260
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [c0a8112de1a86d2f8b926a7b016eb35325372552]

        tdf#161659: icon choice ctrl: Make use of the extra space
        
            commit f6ea343e6fb2dc3539823dee60c9c6f96fc16275
            Date:   Thu May 30 12:26:11 2024 +0200
        
                tdf#161030 Improve vertical Tab list display
        
        increased the width for items in the vertical tab
        control.
        Make use of the new space also for items using an icon.
        
        This causes them to be centered again (tdf#161659).
        
        When using the kf5 VCL plugin with the default
        Breeze style, this also causes the "New Document"
        text of the last item in the "Insert" -> "Hyperlink"
        dialog to no longer be cut off (see attachment 149544
        from tdf#123623 for the previous behavior).
        (As a side note, switching `SvxIconChoiceCtrlEntry::eTextMode`
        from `SvxIconChoiceCtrlTextMode::Short`
        to `SvxIconChoiceCtrlTextMode::Full` would generally
        allow text to wrap and use multiple lines instead of
        cutting off text at the end of the single line.)
        
        Change-Id: I7ec2575bbeb895c034dfc9f2033cea3e3986305a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170262
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [2fdee9fd60bc4bb61f773fa1f766e84f4ee0dae3]

        Unify/Port to use VCLUnoHelper for AWT <-> VCL conversions
        
        Following
        
            Change-Id: Id48f81deb05aee2026509037f7d14575735e5be0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 10 14:49:03 2024 +0200
        
                VCLUnoHelper: Align AWT <-> VCL helpers with convert.hxx impl
        
        , port all uses of the helper functions defined in
        `include/toolkit/helper/convert.hxx` to use the
        `VCLUnoHelper` equivalents instead, to unify usage
        and avoid duplication.
        
        Drop `include/toolkit/helper/convert.hxx` now that
        it's unused.
        
        Change-Id: I22695a93e40e47bb2b14d191a2e0a4eb7c856895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170317
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-11  Michael Weghorn  <m.weghorn@posteo.de>  [f111fbf5d508c8215615f037d7e1c1f563812a13]

        VCLUnoHelper: Align AWT <-> VCL helpers with convert.hxx impl
        
        There are currently (at least) 2 sets of helpers
        for converting from AWT to VCL point, rectangle
        and size classes - and the other way around:
        
        * the ones in `include/toolkit/helper/convert.hxx`
        * the ones provided by `VCLUnoHelper`
        
        Align the `VCLUnoHelper` implementations with the
        ones in `include/toolkit/helper/convert.hxx` and
        make them inline as well.
        
        Switch params from the specific subclasses to the
        more generic base classes as well
        (e.g. `css::awt::Point` -> `PointTemplateBase`).
        
        Otherwise, `VCLUnoHelper::ConvertToVCLRect` is the only one
        that didn't implement the functionality in the
        exact same way as the counterpart, `VCLRectangle`,
        as it was manually calculating the right and bottom
        edges.
        
        The `VCLRectangle` implementation
        gives the same result for valid rects, so take over
        that one. (It shouldn't make a difference for the
        only 2 current callers, `ControlHolder::getPosSize`
        and `VCLXGraphics::clear`.)
        
        This commit is in preparation of consolidating all uses
        to use the `VCLUnoHelper` variants and getting
        rid of the other one in following commits.
        
        Change-Id: Id48f81deb05aee2026509037f7d14575735e5be0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170316
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Mike Kaganski  <mike.kaganski@collabora.com>  [37217909f2e7c042eab9a8b5eb1ab0a88cdda513]

        tdf#161979: Render GDI metafile using drawinglayer in XOutBitmap
        
        After the changes related to EMF+ reworking,  much of the code was removed
        from VCL, e.g. commit 217ad59a412ebab07a106b14c8976d20bddb9356 (tdf#111486
        Removed not used EMF+ code, 2018-12-07).  EMF+ code is now in drawinglayer
        (see EmfPlusHelperData::processEmfPlusData).  Unfortunately, we can't make
        ImpGraphic::draw in VCL to use drawinglayer for rendering,  because VCL is
        lower in dependency tree (it only can use drawinglayercore).
        
        Change-Id: I08f8c8ec66baf3dde1f35481144d5e1819bb5fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170311
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2cb093d8bd8fbfa4204cb10daec52ec6c283e04]

        python3: fix macosx installer
        
        Since a1295cb177295752f8cbfbb49e13d5bb69ed7dc7
        "python: upgrade to 3.10.14 (master only)"
        because the regex expression no longer matches
        "error.cpython-310.opt-1.pyc" with two digits after "error.cpython-3"
        
        Change-Id: I78f566da20e6b591bfa76c36dc69ea3125946d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170315
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-10  Jonathan Clark  <jonathan@libreoffice.org>  [c012c74e69360dd78890c1d935b802c0baf79da2]

        tdf#146081 sw: Fix inconsistent prop line spacing
        
        Previously, when using proportional line spacing <100%, Writer applied
        inconsistent height and ascent adjustments to the first and non-first
        lines of paragraphs. This caused Writer to render text at inconsistent
        vertical offsets.
        
        Height and ascent adjustments are now consistent.
        
        Change-Id: I303d6aa379007f3fa3e8c1ebb981ef205864708a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170307
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [f5b2e0f1eb7d888714bf58a5aa0f151e5ad8ecbc]

        merge-app-bundles: fix _ctypes.cpython path
        
        Change-Id: I247c9674de88c9b97297d01b24232a562bcade01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170318
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [f6c017fe3c62dae2aa2980b4e105d872a70e4024]

        tdf#159348 Update Highlight Overlay when window is resized
        
        When the window is not maximized, the highlight overlay outside the current view is not painted when the window is resized. This patch fixes this issue by repainting the overlay when the window is resized.
        
        Change-Id: I4ad35dcdabc0c95fd24c52a7b9cf7bc6f2583c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168192
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-07-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [115f60037409c511ae01006dedd32306ddf274ff]

        tsan: ImplB3DPolygon cannot have mutable state
        
        because it lives inside a cow_wrapper, which means multiple threads will
        see inconsistent state.
        
        WARNING: ThreadSanitizer: data race (pid=1448100)
          Read of size 1 at 0x7218002d5a48 by thread T333:
        0 ImplB3DPolygon::getNormal()
        basegfx/source/polygon/b3dpolygon.cxx:998 (libbasegfxlo.so+0xef47a)
        1 basegfx::B3DPolygon::getNormal() const
        basegfx/source/polygon/b3dpolygon.cxx:1477 (libbasegfxlo.so+0xe1834)
        2
        drawinglayer::processor3d::DefaultProcessor3D::impRenderPolyPolygonMaterialPrimitive3D(drawinglayer::primitive3d::PolyPolygonMaterialPrimitive3D
        const&) const drawinglayer/source/processor3d/defaultprocessor3d.cxx:424
        (libdrawinglayerlo.so+0x1ed388)
        3
        drawinglayer::processor3d::DefaultProcessor3D::processBasePrimitive3D(drawinglayer::primitive3d::BasePrimitive3D
        const&) drawinglayer/source/processor3d/defaultprocessor3d.cxx:531
        (libdrawinglayerlo.so+0x1edb6f)
        4
        drawinglayer::processor3d::BaseProcessor3D::process(drawinglayer::primitive3d::Primitive3DContainer
        const&) drawinglayer/source/processor3d/baseprocessor3d.cxx:57
        (libdrawinglayerlo.so+0x1e91c1)
        5
        drawinglayer::processor3d::DefaultProcessor3D::processBasePrimitive3D(drawinglayer::primitive3d::BasePrimitive3D
        const&) drawinglayer/source/processor3d/defaultprocessor3d.cxx:543
        (libdrawinglayerlo.so+0x1edbe4)
        6
        drawinglayer::processor3d::BaseProcessor3D::process(drawinglayer::primitive3d::Primitive3DContainer
        const&) drawinglayer/source/processor3d/baseprocessor3d.cxx:57
        (libdrawinglayerlo.so+0x1e91c1)
        7
        drawinglayer::primitive2d::ScenePrimitive2D::create2DDecomposition(drawinglayer::geometry::ViewInformation2D
        const&) const::Executor::doWork()
        drawinglayer/source/primitive2d/sceneprimitive2d.cxx:462
        (libdrawinglayerlo.so+0x12469f)
        8 comphelper::ThreadTask::exec()
        comphelper/source/misc/threadpool.cxx:319 (libcomphelper.so+0x2bd587)
        9 comphelper::ThreadPool::ThreadWorker::execute()
        comphelper/source/misc/threadpool.cxx:85 (libcomphelper.so+0x2c3930)
        10 salhelper::Thread::run() salhelper/source/thread.cxx:39
        (libuno_salhelpergcc3.so.3+0x5d22)
        11 non-virtual thunk to salhelper::Thread::run()
        salhelper/source/thread.cxx:? (libuno_salhelpergcc3.so.3+0x5ed9)
        12 threadFunc include/osl/thread.hxx:189
        (libuno_salhelpergcc3.so.3+0x6b1e)
        13 osl_thread_start_Impl(void*) sal/osl/unx/thread.cxx:237
        (libuno_sal.so.3+0xfc937)
        
          Previous write of size 8 at 0x7218002d5a48 by thread T334:
        0 operator new(unsigned long)
        /home/noel/llvm-project/compiler-rt/lib/tsan/rtl/tsan_new_delete.cpp:64
        (discriminator 8) (cppunittester+0x10c8a1)
        1 o3tl::cow_wrapper<ImplB3DPolygon,
        o3tl::ThreadSafeRefCountingPolicy>::make_unique()
        include/o3tl/cow_wrapper.hxx:304 (libbasegfxlo.so+0xfe798)
        2 o3tl::cow_wrapper<ImplB3DPolygon,
        o3tl::ThreadSafeRefCountingPolicy>::operator->()
        include/o3tl/cow_wrapper.hxx:329 (libbasegfxlo.so+0xef0e5)
        3 basegfx::B3DPolygon::getNormal() const
        basegfx/source/polygon/b3dpolygon.cxx:1477 (libbasegfxlo.so+0xe1825)
        4
        drawinglayer::processor3d::DefaultProcessor3D::impRenderPolyPolygonMaterialPrimitive3D(drawinglayer::primitive3d::PolyPolygonMaterialPrimitive3D
        const&) const drawinglayer/source/processor3d/defaultprocessor3d.cxx:424
        (libdrawinglayerlo.so+0x1ed388)
        5
        drawinglayer::processor3d::DefaultProcessor3D::processBasePrimitive3D(drawinglayer::primitive3d::BasePrimitive3D
        const&) drawinglayer/source/processor3d/defaultprocessor3d.cxx:531
        (libdrawinglayerlo.so+0x1edb6f)
        6
        drawinglayer::processor3d::BaseProcessor3D::process(drawinglayer::primitive3d::Primitive3DContainer
        const&) drawinglayer/source/processor3d/baseprocessor3d.cxx:57
        (libdrawinglayerlo.so+0x1e91c1)
        7
        drawinglayer::processor3d::DefaultProcessor3D::processBasePrimitive3D(drawinglayer::primitive3d::BasePrimitive3D
        const&) drawinglayer/source/processor3d/defaultprocessor3d.cxx:543
        (libdrawinglayerlo.so+0x1edbe4)
        8
        drawinglayer::processor3d::BaseProcessor3D::process(drawinglayer::primitive3d::Primitive3DContainer
        const&) drawinglayer/source/processor3d/baseprocessor3d.cxx:57
        (libdrawinglayerlo.so+0x1e91c1)
        9
        drawinglayer::primitive2d::ScenePrimitive2D::create2DDecomposition(drawinglayer::geometry::ViewInformation2D
        const&) const::Executor::doWork()
        drawinglayer/source/primitive2d/sceneprimitive2d.cxx:462
        (libdrawinglayerlo.so+0x12469f)
        10 comphelper::ThreadTask::exec()
        comphelper/source/misc/threadpool.cxx:319 (libcomphelper.so+0x2bd587)
        11 comphelper::ThreadPool::ThreadWorker::execute()
        comphelper/source/misc/threadpool.cxx:85 (libcomphelper.so+0x2c3930)
        12 salhelper::Thread::run() salhelper/source/thread.cxx:39
        (libuno_salhelpergcc3.so.3+0x5d22)
        13 non-virtual thunk to salhelper::Thread::run()
        salhelper/source/thread.cxx:? (libuno_salhelpergcc3.so.3+0x5ed9)
        14 threadFunc include/osl/thread.hxx:189
        (libuno_salhelpergcc3.so.3+0x6b1e)
        15 osl_thread_start_Impl(void*) sal/osl/unx/thread.cxx:237
        (libuno_sal.so.3+0xfc937)
        
        Change-Id: I9a12e2178cfad07f0a23b5dc4c502ce16ef92fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170275
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-10  Noel Grandin  <noelgrandin@collabora.co.uk>  [ac431b399f9fe3b772abd8fda6d0727bfa6c9135]

        make MSVC /analyze a configure option
        
        My debug build is slow enough already, no need to make it worse.
        
        People who want it, can turn it on explicitly.
        
        Change-Id: I8677534d8f0142699baa6b95a249ae5f70c5cc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-10  Patrick Luby  <guibmacdev@gmail.com>  [8e8036491ff0a6c2df2075af66609df17ee594cd]

        tdf#160427 native menu changes can only be done on the main thread
        
        Change-Id: I7dbe9913eaa087e143acb95bdae625c69888c3dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170308
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [4241f171ad3deb1d272dba12acde50011dd90c3c]

        sd: Switch DBG_ASSERT to assert
        
        This fixes Windows/MSVC build errors like the one reported in [1]:
        
            C:/BuildLO/core/sd/source/ui/view/drawview.cxx(394): error C2220: the
            following warning is treated as an error
            C:\BuildLO\core\sd\source\ui\view\drawview.cxx(372) : warning C6011:
            Dereferencing NULL pointer 'pSheet'. : Lines: 285, 287, 289, 292, 293,
            294, 313, 333, 336, 339, 341, 343, 345, 347, 349, 353, 354, 355, 369,
            373, 372
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2024-July/092158.html
        
        Change-Id: Ib63cc2d48203a4c6ba2f1239feb7dc306de5d11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170279
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0c2e0ea495b5f6317d8f7459d3af5f35b2a4b962]

        Consolidate common code
        
        Change-Id: Ic24163970fd5b97c2426f0786d9b7d97a1796f87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170309
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [62a0eb9b088818239c4d2fa16f84e356a63389b1]

        loplugin:casttovoid
        
        Change-Id: I07f5220c44077ddb7737d00a8dc5e598a00c3c59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170310
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-07-10  Jim Raykowski  <raykowj@gmail.com>  [d9856b2ca5f3e80c978bd34330648b6345765202]

        tdf#161811 related: Fix change manager dialog context popup menu
        
        Sort By > Document Position results
        
        With out the patch installed gtk sorts by the Action column. x11 and qt
        also do something other than expected.
        
        Change-Id: Ic36e79cf928e5ba142b7ff435999e806b1d56214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170059
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [80a6f398eb19a5808b3b7c2a682be2e1bb0f17ed]

        regain the SvxCharacterMap "pre-run" logic in async mode
        
        since:
        
        commit 6a5ef1a2b009f208745a251828bf8e8c51146bfe
        Date:   Mon Jan 22 12:35:50 2024 +0200
        
            make charmap dialog async
        
        Change-Id: I5fc13e759eb8f1d1e6ab7c09f39cabc1d4c4ad7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170276
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6c4d733f15bb779f02afa910149408df8c7fda2]

        cid#1556474 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1557319 COPY_INSTEAD_OF_MOVE
        cid#1557320 COPY_INSTEAD_OF_MOVE
        cid#1558101 COPY_INSTEAD_OF_MOVE
        cid#1606536 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibe10ee3fad7f6ca1f3c5b316fdafe4bf15f0ead7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170280
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-10  Jim Raykowski  <raykowj@gmail.com>  [8afc4d10f917cfb5faadac0a1dd8856373693630]

        tdf#161717 Enhancement to identify click on tracked change
        
        This is a followup that fixes tracked change comments are not always
        highlighted in the Manage Changes dialog/sidebar panel when the
        anchor triangle is clicked on in the document.
        
        Change-Id: I0bf8bebf8133777e79101e908afd268ab44c0d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170258
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0862a12208919f0c8171a4dd4ff356d8833b9221]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a7045ca49e06f1e84bee74cdac6d8d6a399ddd8
          - tdf#159596 match XLOOKUP Help terms to UI terms
            
            Change-Id: I5c2c7739ae6e6a7413bd99a72fa448981c560b50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170312
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-10  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [df9055254c0db96f3233a952fca9b167907c186c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 33ffaf1eaac11bb5770eadce49fac96a4ae4ba86
          - tdf#160197 remove mention of removed GetLocale BASIC function
            
            Change-Id: Icc3223e4f6ceb83abe542beb538f5ade052e495e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170313
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b3300387f2e14ea59c70db513a8f6eda6fe17afa]

        Fix UBSan build of ExternalProject_redland
        
        ...after c75c21eef670fce33eb5a501357935dbd25be923 "Upgrade raptor to 2.0.16",
        where it now started to fail with
        
        > libtool: link: LD_RUN_PATH="/usr/local/lib:" /usr/bin/ccache /home/tdf/lode/opt_private/clang-llvmorg-12.0.1/bin/clang --gcc-toolchain=/opt/rh/gcc-toolset-12/root/usr -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/tdf/lode/jenkins/workspace/lo_ubsan/sanitize-ubsan-excludelist -fno-sanitize=function -DLIBRDF_INTERNAL=1 -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program -o .libs/redland-db-upgrade db_upgrade.o  -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/raptor/src/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/libxml2/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/libxml2/.libs/libxml2.so -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/rasqal/src/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/rasqal/src/.libs/librasqal.so ../src/.libs/librdf.so
        > /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_vptr_type_cache'
        > /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_handle_function_type_mismatch_v1'
        > /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
        > clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[3]: *** [Makefile:489: redland-db-upgrade] Error 1
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3239/>) because $(CC) is used to link
        a (nominally C-only) executable that links against C++ ICU shared libraries that
        in turn require a C++-specific UBSan library to be linked in.  So just use
        $(CXX) for linking instead.
        
        Change-Id: If7c61c6ee7e1b43965a928b1560f8ab4ae2b0603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170277
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff55c7d386a8dca90bc6e4b15cf4fd3506b7190c]

        sw: uitest for c519de2296
        
        Change-Id: If5e03591ba4aef6a111268b32bff305e1ec6ba8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170284
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3374417097edcee8c8951fd1df6044e2d24b74a6]

        cid#1608592 Double lock
        
        since:
        
        commit 9301f4d486b13dac2a66b797d5e24eb6dc9f7582
        Date:   Thu Feb 16 14:31:25 2023 +0200
        
            osl::Mutex->std::mutex in ResultSetDataSupplier
        
        Change-Id: I6be50541e00f8f8de3bdebe1690e14e805bee14e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170281
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-10  Henry Castro  <hcastro@collabora.com>  [4645a8502559c58027b3042adc086bd2e0773b12]

        lok: sc: fix warning autofilter message box
        
        Do not send the warning dialog to other users.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I53ce2f24a17d853a9e7e6d302e101e4fa9d556dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169205
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 57f781eee6eac7a10210f7b8b539b4b00c6d08e8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170118
        Tested-by: Jenkins

2024-07-10  Heiko Tietze  <tietze.heiko@gmail.com>  [a9e23d1dcd361d95e046ab2d521ee55df9a77747]

        Resolves tdf#161421 - Draw soft hyphen in black on PDF export
        
        Change-Id: I69a19a0919fd31f8ea2fee962e994d61873e51c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170211
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d35deb92f8029a40fa1cc579c4481a5c5eaf2791]

        update credits
        
        Change-Id: If9db88d33699c5cd3c48dca42bc3c86e6f3eea3b

2024-07-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b84691d5e2c02429c53fe9a8dc2f20e39a9d35c]

        make query set ins mode dialog async
        
        Change-Id: I1951abc34cca59aaffb85540d38e2f002ddc3f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170256
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-10  Pierre F  <fpy@bger.ch>  [cda866cff5131c80f65895c5e14ce252a0ae2060]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c2abcb72746a4354ff3e13aa8343c3f123ebc763
          - misc fix scalc/01/data_form. tdf#158426
            
            Change-Id: I18c4e057305daed9ae8bdb23766173a0cbcee6a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169959
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b560515604931039a903c87d8ac78d667d10712]

        add more tsan suppression
        
        Change-Id: I8d937e098fb422c3bf12ef0fa51cb48337e0b0c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170274
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [875997c8962da7f6b72950b201186a19b3c20d3a]

        Properly implement cppu::throwException for Emscripten
        
        ...by implementing (for now) just enough of the cpp2uno half of the Wasm UNO
        bridge to make it work.  In general, that half suffers from the same issue as
        the already-implemented uno2cpp half, namely that Wasm doesn't allow to generate
        code on the fly (which, in this case, would be needed to implement the vtable
        slot trampoline functions).  So, for now just hard-code the few
        vtableSlotFunction_* that are needed by the UNO interfaces for
        cppuhelper/source/exc_thrower.cxx.  (A proper fix would probably use the same
        approach as for the uno2cpp half, and use something like wasmcallgen to generate
        at least all the vtableSlotFunction_* needed for udkapi/offapi upfront.)
        
        The RTTI for the exceptions needs to be unique across the executable for
        exception catching to actually work (as it compares exception types by RTTI
        address rather than by name).  We thus need to export all the relevant RTTI
        symbols (which I hacked into the existing wasmcallgen for now, even if that
        makes that executable's name a slight misnomer now), and access them with a new
        jsGetExportedSymbol.  (This exporting would also be needed by the "classical"
        approach of using dlsym on the main module, cf.
        <https://gerrit.libreoffice.org/c/core/+/167187> "WIP: Emscripten: Set up
        support for dlsym from main module".  And while that dlsym approach would work,
        it is much simpler to just use that jsGetExportedSymbol than to use a dlsym
        detour, and thereby avoid all the hassle of -sMAIN_MODULE detailed in the commit
        message of that Gerrit change.)
        
        It also turned out that including Emscripten's <cxxabi.h> needs
        __USING_WASM_EXCEPTIONS__ to be defined, because it uses that in its declaration
        of __cxa_throw.  (The source for setting that define internally in Emscripten is
        get_cflags in the emsdk's upstream/emscripten/tools/system_libs.py, which
        defines __USING_EMSCRIPTEN_EXCEPTIONS__ for the non-Wasm, Emscripten JS
        exception mode, and defines __USING_WASM_EXCEPTIONS__ for
        --enable-wasm-exceptions, which we use.  The commit message of
        f4ec967599f5dafa1ce477631d7c2e8de005e28f "Fix redefinion of Emscripten
        __cxxabiv1::__cxa_exception" documents my prior confusion of when one or the
        other would be defined.)
        
        Change-Id: Id08765ab5b4ce1553dc3a61648324526185cb64c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170246
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-10  Michael Stahl  <michael.stahl@allotropia.de>  [4833f131243bdb409ddfaff8b4db87d4ed2af98f]

        package: ZipFile: don't accept duplicate entries (case insensitive)
        
        This is required for OOXML, but not for ODF.
        
        Unclear if there are use cases for this with ODF, can add some
        conditions if it turns out to be a problem.
        
        Change-Id: I3810da5c2273574135d133b4a9bbad98dc97af44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170223
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-10  Marco Cecchetti  <marco.cecchetti@collabora.com>  [bf972de2c193540c36f8d9fde0879da478c0ab8c]

        lok: expose presentation info and slide render functions
        
        This exposes the (impress only) function to get the current
        presentation info in JSON format and the slide rendering functions
        that enable rendering of slide layers to a bitmap.
        
        Change-Id: Id0591d5894f730eae48b3edc986ae5d804ce7c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170263
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-10  Patrick Luby  <guibmacdev@gmail.com>  [99fda8da4e0a1b24c9aaecacfeeba0fe593fe730]

        tdf#161712 invoke ScSimpleUndo::EndUndo() before ShowBlock()
        
        If this is an instance of ScUndoAutoFill, ShowBlock() will invoke
        ScTabViewShell::MoveCursorAbs() which will delete this instance
        so invoke ScSimpleUndo::EndUndo() first.
        
        Change-Id: I7ef6dfa0444c38974e1d8c5af6672144f045d22d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170254
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63910ad6e5471b282803d6a25bb2e2546d1ce562]

        prefer higher version of "Noto Sans Arabic" of system vs bundled
        
        I have "Noto Sans Arabic" installed system wide:
        
        file: "/usr/share/fonts/google-noto-vf/NotoSansArabic[wght].ttf"(s)
        
        fontversion: 131858(i)(s)
        
        and there is the bundled version:
        
        file: "./instdir/share/fonts/truetype/NotoSansArabic.ttf"(w)
        
        fontversion: 131727(i)(w)
        
        what we generally want to do is pick just one font, the version with the
        higher number, but in this case we don't see them as near-duplicates and
        so add both of them.
        
        In my case then using any font/glyph fallback for a "en" font suggests
        "Noto Sans Arabic", presumably because the bundled one has those glyphs,
        but we seem to end up rendering with the system one which doesn't have
        them, so font/glyph fallback for fonts that are non explicitly
        configured somewhere in fontconfig end up with missing glyph symbol.
        
        So additionally disregard the FC_INDEX and FC_POSTSCRIPT_NAME fields
        when comparing fonts to find the higher version.
        
        https://bugzilla.redhat.com/show_bug.cgi?id=2262410 has a similar
        sounding problem but in the end I think it is a different issue, but
        maybe the same trigger of having "Noto Sans Arabic" at the start of
        the list of possibilities.
        
        Change-Id: I500fb9cad793b63d0fbeb8c4bc1246fd68be39fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170251
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-10  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [1bfebb926df434618a79672f3cc30c96cba89021]

        CairoSDPR: Handle FillGraphicPrimitive2D better
        
        Avoid decomposition of it in AnimatedExtractingProcessor2D
        by handling there directly. Goal is to find/extract animation
        primitives, so only do something when the contained Graphic
        is active
        
        Change-Id: I1d168428ddbaaac2c9d5fde7b26be380ba442c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170203
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-10  Miklos Vajna  <vmiklos@collabora.com>  [597806350152b746b192a66b4789ca7c8c5377a9]

        tdf#161970 sw content controls: fix PDF export for the ExportNotesInMargin case
        
        Have both a content control and a comment in a document, export to PDF
        while "Comments in margin" is enabled, now the default text of the
        content control has an incorrect position / size.
        
        The transform for normal writer comment was added in commit
        eb1c0480050a1328287c4a85468afbec50b0e29d (Resolves: fdo#36815 enable
        printing WYSIWYG sidewindow comments, 2014-04-16), and e.g. the
        hyperlink rectangles are transformed correctly, but the content control
        PDF export code added in commit 82d90529dc2b3cb8359dec78852cbd910a66d275
        (sw content controls, rich text: add initial PDF export, 2022-09-12)
        missed this.
        
        Fix the problem by extracting the actual transform to a new
        SwEnhancedPDFExportHelper::MapSwRectToPDFRect() and then using it in
        both SwEnhancedPDFExportHelper::SwRectToPDFRect() (e.g. hyperlinks) and
        SwContentControlPortion::DescribePDFControl().
        
        Note that the font size of the PDF widget also needs scaling down, also
        fix here.
        
        Change-Id: I9cccbd569070336e1720ba2a82e91793083722f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170266
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ffd41d7ae80079ba53792495720b926599ef37bf]

        Remove duplicated includes
        
        Change-Id: I83eedc544f19999d36da8e2090c0dd55ef432fd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170224
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a97e6246928abfbe0478a493bb715e6fd92e1553]

        Fix typo
        
        Change-Id: Ic166e36a90c09df9cab49f3b2b8092e64730d05f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170245
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [180d33c69af4fbfa9841cffc10a623ea82874e15]

        Remove duplicated include
        
        Change-Id: Id309c3775e1704ab65cea86ece65e960d1f2cd1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170264
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1bceae90fc87b0e85bef5288f1e5ee667df8fca5]

        Fix typo
        
        Change-Id: I769aaab7e5a879c99a1db5cc87a0b5118fb42eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170265
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [c48307b552249f64b5fc2a558c3ae19ae51b188d]

        icon choice ctrl: Drop unused forward-declaration
        
        Change-Id: I7035f9495b6b2fb0f602f88fef9b3c837417b875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170250
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [7a4e4ca8882ae5553133c2b6f187de54c04fe98b]

        icon choice ctrl: Drop code for non-autoposition mode
        
        As shown by
        
            Change-Id: I8d19e15d8c6e95cdc5e797e6b9524d9299dc1fdd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 9 17:32:01 2024 +0200
        
                icon choice ctrl: Always use SvxIconChoiceCtrlPositionMode::AutoArrange
        
        , `SvxIconChoiceCtrlPositionMode::AutoArrange` is the only
        positioning mode that actually gets used, so simplify the code
        by dropping the effectively unused code for
        `SvxIconChoiceCtrlPositionMode::Free`.
        
        (`git show --ignore-space-change` can help to see the "actual
        changes" more easily.)
        
        Change-Id: Icd5ee30eafefafbf597681e28521d5a566ea0af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170249
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [cc2ddc12c3700b53f0444eb8afce9b0ff0aae160]

        icon choice ctrl: Always use SvxIconChoiceCtrlPositionMode::AutoArrange
        
        `SvxIconChoiceCtrl_Impl` is only used by `SvtIconChoiceCtrl`
        and that one explicitly sets
        `SvxIconChoiceCtrlPositionMode::AutoArrange` in its ctor
        to override the `SvxIconChoiceCtrlPositionMode::Free` default.
        
        In a first step, default to `SvxIconChoiceCtrlPositionMode::AutoArrange`
        and drop the setter, to simplify the code.
        Further cleanup will be done in a follow-up commit.
        
        Change-Id: I8d19e15d8c6e95cdc5e797e6b9524d9299dc1fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170248
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [633ad5fd673fd80db8d091c5f90927af30471b4d]

        icon choice ctrl: Simplify list pos handling
        
        Instead of storing the current list position in
        the `SvxIconChoiceCtrlEntry` and having to take
        care of updating that when entries are added to
        or removed from the `SvxIconChoiceCtrl_Impl` in
        order to keep it in sync with the elements in
        the vector, just calculate and return the vector
        index in `SvxIconChoiceCtrl_Impl::GetEntryListPos` on
        demand.
        
        Change-Id: Iec4e700c1ccc1261fde778b1b38af4dbac5a14c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170247
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [46d55cf7960ecea3bc8af29f7a05159e5979c3ac]

        tdf#161964 - sc Fix Lookup functions error with only-row reference
        
        as a lookup_array parameter. ($1:$1)
        
        Regression from commit: 85f733a9242339d8e92f992ff1ad6d1b99d3f383
        (Related: tdf#160725 - Add horizontal binary search mode for SortedCache)
        
        Change-Id: I3ef7c612e7bc92ecab81a3e52aed9873da907f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170221
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-07-10  Mike Kaganski  <mike.kaganski@collabora.com>  [982a021bb74a9b44a1412cf7688b98785a20aac4]

        Simplify and flatten a bit
        
        Change-Id: Ida5f925f0c87f27cc5ed3578221959a4d59f3f43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170240
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-10  Mike Kaganski  <mike.kaganski@collabora.com>  [78a6b95b1e8e92c5da282c641419e528d0969884]

        Drop redundant code
        
        GetMarkedObjBitmapEx works on BitmapEx now, and does exactly
        the same.
        
        Change-Id: Ia7333515996803fcf1ac10515950ce2f96ab01fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170239
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-10  Marco Cecchetti  <marco.cecchetti@collabora.com>  [1f0fd06bc0cfe5036661ce2c23911f34eccf678a]

        sd: slideshow render interface and implementation
        
        Interface and implementation to expose the ability to render
        the slide's layers to a bitmap.
        
        Change-Id: I3da48585e498354592e163d84bd29659b233c255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170214
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-10  Noel Grandin  <noelgrandin@gmail.com>  [6f96e7720f765d4e5e8fdef6a2a2b8cbb75c81ef]

        Revert "tdf#158556 speedup docx load"
        
        This reverts commit ab29c857c669bcca3d8eea8a5a9e6ad5eae622d7.
        
        As jluth points out, my logic here is wrong.
        
        Change-Id: I8887526a0a96070ad615aa07ef0e77e36214d0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170252
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [c9f5f3d4e0c5da84a2ad9293c073a54b73abb01f]

        add more tsan suppressions
        
        Change-Id: I3e397763581340d6f0ae5136e0022c939cbf2997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170216
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [0b1bbffe49e7830d69be44450ed7841352cde309]

        icon choice ctrl: Drop unused GRID_NOT_FOUND define
        
        Unused since:
        
            commit 5db79db0f0c7c432d933433192506d234f6cd26e
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:54:48 2024 +0200
        
                tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::GetPredecessorGrid
        
        Change-Id: I146da489fcc1faa4915d2af5449131729cf042bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170213
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [54351d0a5f22ec9a0d76b424111d163704714a9e]

        icon choice ctrl: Drop SvxIconChoiceCtrl_Impl::nMaxVirtWidth
        
        Since
        
            Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 9 11:55:26 2024 +0200
        
                icon choice ctrl: Drop WB_ALIGN_TOP
        
        , it is only written to, but never read, so drop it.
        
        Change-Id: Iee03649a1ff99bf77383710835995b393cab689e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170212
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [c4e8c40815d3e8c6e2d96f3b9cd24e88609bbbe0]

        icon choice ctrl: Update doc on WB_* flags
        
        `WB_NOSELECTION` and `WB_SMART_ARRANGE` were
        dropped earlier, so drop their doc as well.
        
        There's no `WB_SMALL_ICON`, but `WB_SMALLICON`,
        so adjust the name in the doc as well.
        
        Change-Id: I8eb36d1184743f8e7a3e501f05e3f4b5a374e51d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170210
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [2f0bbee9d4ebc7d5b396de2d28254951d314137f]

        icon choice ctrl: Drop WB_ALIGN_LEFT
        
        At least since
        
            Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 9 11:55:26 2024 +0200
        
                icon choice ctrl: Drop WB_ALIGN_TOP
        
        , it's quite clear that the `WB_ALIGN_LEFT`
        is always set, so drop the flag and code paths
        only relevant if the flag were not set.
        
        Change-Id: If736ffc386833d3ff188d4174baf36bd2bcca57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170209
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [2fa8dd663c68541ba61f6f91a62915d1875ae2b4]

        icon choice ctrl: Drop WB_ALIGN_TOP
        
        The `WB_ALIGN_TOP` flag is never set, last
        code path that would have set it (but was
        apparently already unused back then) was dropped in
        
            commit 80bf2654d72995f6b13c5addcd7c5e89ec76b0d9
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Mon Jun 23 15:34:02 2014 +0100
        
                meChoicePos is always PosLeft, simplify
        
                Change-Id: I40085b0db89484f0d24ecaccf910f4399198294d
        
        Therefore, drop the flag and all related code
        altogether.
        
        Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170208
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-10  Michael Weghorn  <m.weghorn@posteo.de>  [9a359416d7e78fbeb82936de53f402ae4fe4d561]

        icon choice ctrl: Don't explicitly call base class impl of method
        
        `SvtIconChoiceCtrl` doesn't override any of these methods,
        so there's no need to explicitly call the base class
        implementations.
        (And `Control` also doesn't implement them, so the
        `Window` base class implementations are used anyway.)
        
        Change-Id: I8196a568433416e10c2d0d50fad64b4525577679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170207
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [872e0d3c8a17b582f04b82aa2525e614080acda9]

        Remove duplicated include
        
        Change-Id: I454f1763640ae2a8cef62dcc5eac354a6fc17197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170180
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac2d7723fa8426b34c9f19b30e5bfcefcfcaca17]

        cid#1556801 Use of auto that causes a copy
        
        Change-Id: Ida76c23f30c32ea6999ea9ed8656a0a655ad2d85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c42d9ce26f88a53e2b12ac0c22edba3b27bb4917]

        cid#1555119 Use of auto that causes a copy
        
        Change-Id: If77650947fb787b6122452bf896345cf2f852ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170202
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0f643befa3169a1e43a924c08e9595929fa16f96]

        use a throwaway TMPDIR for ghostscript-using helpers
        
        Change-Id: Iba5a475399589c9e2c4fd485d613f0dedfe0dc44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170215
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [fddda044b5983497f7423f8a32376301480d58fe]

        Revert "fix and simplify the ItemInstanceManager mechanism"
        
        This reverts commit 85fd526fc681a994415bb422090d1d23aa7d54f6.
        
        Change-Id: I5019f72f88497f50a77666d57f2d16c2749bd1c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec77620279c27da7e3901e69fccf42a882224065]

        Java-WebSocket: upgrade to 1.5.7
        
        Downloaded from https://github.com/TooTallNate/Java-WebSocket/archive/refs/tags/v1.5.7.tar.gz
        
        Change-Id: Icb5719fa04b0a12f7f87501777554af326bde439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170220
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c04de7a6f2e6bd98ccd1c3ec217e60b00d2014b1]

        tsan: fix data race in o3tl::cow_wrapper
        
        where the use_count() call was happening without any kind of
        synchronisation - switch to use std::atomic which does the right thing
        for us
        
        Change-Id: I79a6452f42bd425ea494bb0298dc134de5678813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170217
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [02786af7ea5cde45522cdd4ac29eb6fff51977eb]

        loplugin:unusedenumconstants
        
        Change-Id: Ifd22f5cc618137d715f78f0a04550256987752ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170186
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [14e216986b7353c7c57c31ff791c2c0baffbced6]

        loplugin:unusedmethods
        
        Change-Id: I799129a3449ebcbb7b7005b933349cd2e6287860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c11c5f9b87dfb7a7620341c2bffbd73b4d8eca58]

        cid#1557551 Use of auto that causes a copy
        
        Change-Id: Id3b31e1a5ca54f6bc3c61ad325f37bb6896dc760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170200
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f675395370a81c5668a6b95c31aa1d2b5a3b4dac]

        cid#1558011 Use of auto that causes a copy
        
        Change-Id: If828a232a28f87c0677f83e0cccf2e940c3339e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170199
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5cc0af1faa5496c7afcfd5984cfee0d8888769a3]

        cid#1606955 Use of auto that causes a copy
        
        Change-Id: I62bef7596c14174b543b64628cedadc108b75590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170198
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Michael Meeks  <michael.meeks@collabora.com>  [7232d70476aee963633a89d8b62f87fed28d8f52]

        Avoid potential negative array index access to cached text.
        
            if ((nIndex != 0 || nLen != text.getLength()) && !skipGlyphSubsets)
        	seems unlikely to protect us from this:
        
        	/opt/rh/devtoolset-12/root/usr/include/c++/12/string_view:239: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char16_t; _Traits = std::char_traits<char16_t>; const_reference = const char16_t&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
        
        	coolwsd[16958] ... SIG   Fatal signal received: SIGABRT code: 18446744073709551610 for address: 0x7300004e16
        
        	SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr<OutputDevice const>, rtl::OUString const&, int, int, long, vcl::text::TextLayoutCache const*)
        		/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/vcl/source/gdi/impglyphitem.cxx:399
        	GetTextArray(OutputDevice const&, rtl::OUString const&, KernArray&, int, int, bool, vcl::text::TextLayoutCache const*)
        		/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/include/rtl/ref.hxx:128
        	SwFntObj::GetTextSize(SwDrawTextInfo&)
        		/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/txtnode/fntcache.cxx:766
        	SwSubFont::GetTextSize_(SwDrawTextInfo&)
        		/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/txtnode/swfont.cxx:1022
        	SwTextSizeInfo::GetTextSize() const
        		/home/collabora/jenkins/workspace/build_core_co-24.04_for_online_snapshot/sw/source/core/inc/swfont.hxx:314
        
        	blind fix - but seeing a lot of these.
        
        Change-Id: Icb6ca25e4b8c6ef8a5e5b89dfa01b56bb788378d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168539
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2ae2fa78ffd5c38f16624b17faa9dd263d2f573]

        lxml: ignore warnings when calling setup.py build too
        
        Reverts dc97b366ab9ce3d38c84da06b8b37131579f87f3
        "python3: silence distutils deprecated warning"
        and f41773d684dfb1bfebe484bbf6d1ec4b5937d348
        "python3: silence distutils deprecated warning (take 2)"
        and c920605dd4c4520ab8ee80f9fb4746287835918c
        "external/lxml: Fix --enable-python=fully-internal build"
        
        Change-Id: I9131fa5ac22cf4f0279e7bf0edc5c50b61845044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170206
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [6dc23b7bfffd5b9baa2d63f8a58df51e3447e9e0]

        lxml: do not apply replace-setuptools-with-distutils on macosx
        
        it has setuptools support
        
        Change-Id: Ia66d3e6398044fc6ae8ac1f70afc3a8fdf23fe2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170175
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [f52dc148f2f425288333feecd7b807a2e27084ac]

        lxml: ignore warnings when calling setup
        
        Since a1295cb177295752f8cbfbb49e13d5bb69ed7dc7
        "python: upgrade to 3.10.14 (master only)"
        
        macosx builds with:
        Building lxml version 5.2.2.
        Building without Cython.
        Building against libxml2 2.9.4 and libxslt 1.1.29
        Building against libxml2/libxslt in the following directory: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib
        running install
        Traceback (most recent call last):
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/lxml/setup.py", line 208, in <module>
            setup(
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/__init__.py", line 87, in setup
            return distutils.core.setup(**attrs)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 185, in setup
            return run_commands(dist)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
            dist.run_commands()
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 968, in run_commands
            self.run_command(cmd)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/dist.py", line 1217, in run_command
            super().run_command(command)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 985, in run_command
            cmd_obj = self.get_command_obj(command)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 860, in get_command_obj
            cmd_obj = self.command_obj[command] = klass(self)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/__init__.py", line 158, in __init__
            super().__init__(dist)
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 64, in __init__
            self.initialize_options()
          File "/Users/libreoffice/releases/r/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.10/lib/python3.10/site-packages/setuptools/command/install.py", line 34, in initialize_options
            warnings.warn(
        setuptools._deprecation_warning.SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        /Users/libreoffice/releases/libo-core/external/lxml/ExternalProject_lxml.mk:25: recipe for target '/Users/libreoffice/releases/r/workdir/ExternalProject/lxml/build' failed
        make[1]: *** [/Users/libreoffice/releases/r/workdir/ExternalProject/lxml/build] Error 1
        Makefile:125: recipe for target 'lxml' failed
        make: *** [lxml] Error 2
        
        Because we bundle setuptools on macosx, and for that reason,
        this deprecationwarning is triggered. In the long run,
        external/lxml/ExternalProject_lxml.mk should be changed to
        use build and pip as the message says, but for now, just
        ignore the warnings.
        
        Change-Id: I05373363aba746fa40e5039c08aaa0f320908c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170205
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-09  Jean-Pierre Ledure  <jp@ledure.be>  [b2b29283c21640d02b12c031963dbd50a646552c]

        ScriptForge (Document) tdf#161946 Fix CreateMenu() / Before
        
        A too strict validity check of the Before argument
        prevents the use of numeric values.
        String values work fine.
        
        Fix the arguments of the call to SF_Utils.Validate()
        in SFDocuments.Document.xba
        
        Change-Id: Id1d21cef1c3f056078b0208a8e15c503e1ecb201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170165
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [44f42499e20895cce8a3a4defc21b0613cc80bfd]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ibacb8bd52f5a9838540a68d238c3ed76eff6571b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f1b91a2bb7af2823c7c1dc9a30a0e822aa902cc]

        loplugin:virtualdead
        
        Change-Id: I9a0b0ae315aad6daa2a209d70e3bc60af61b2ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170183
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-09  Szymon Kłos  <szymon.klos@collabora.com>  [43025e02d400d025634387ab061cf860bcdea8e8]

        jsdialog: enable interaction handler without LOKNotifier cool#9453
        
        When pasting content with URL to remote content behind
        basic authentication - we ask for user and password.
        That dialog didn't have LOKNotifier set. It's new case
        because we create the dialog controller and we setup the
        window id = 0, later when we run the dialog we did correct
        setup of LOKNotifier and id was changed to eg. 7.
        Then client had out of sync identifier because we already sent
        the old value. Setup the "default" notifier directly in
        weld_dialog to avoid that.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I7b6ceef722f7f9827b1fb41cc0229b0170693d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170159
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170192
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [beb9959896bf15c306fdbbd9d130e8dffb7062c1]

        loplugin:unusedenumconstants update for new clang AST node
        
        Change-Id: I5838f4fded09ad0f4eabc2dbf38ac2eb5c60777e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170182
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Marco Cecchetti  <marco.cecchetti@collabora.com>  [9eb79d196472b5ff6bb0f25561208a39e52ae7c5]

        slideshow: add removeAllShapes to the LayerManager
        
        The method will be needed in a follow up patch..
        
        Change-Id: I3a0bde78e40f45bcf26cb20dea5bf5a5dd06a7ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170178
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-09  Taichi haradaguchi  <20001722@ymail.ne.jp>  [c75c21eef670fce33eb5a501357935dbd25be923]

        Upgrade raptor to 2.0.16
        
        - Fixes CVE-2017-18926 and CVE-2020-25713.
        - drop 0001-Calcualte-max-nspace-declarations-correctly-for-XML-.patch.1:
          merged upstream
        - drop 0001-CVE-2020-25713-raptor2-malformed-input-file-can-lead.patch.1:
          merged upstream
        - drop libtool.patch: merged upstream
        - drop most of raptor-freebsd.patch.1: merged upstream
        - drop most of raptor-msvc.patch.1: merged upsttream
        - drop most of ubsan.patch: merged upstream
        - drop Wint-conversion.patch: merged upstream
        
        depend on package icu_ure to have libicuuc delivered and add corresponding
        directory to rpath-link to make sure the right copy is picked up
        use $(strip ...) in LDFLAGS to avoid having to escape , with $(COMMA)
        
        Change-Id: Ic05269ade5dae3761d98432ee504a51434a4c753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161704
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f8fdd226f500197f76172141085c3d06dbb06f49]

        cid#1608488 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id2e09641f4095eca73a16dd1fcec64d91ab5395a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170197
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d8ac3bf7663b44a7f92b36e07b3eb0c85419ce0]

        cid#1607431 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib60f297d9be6a914a85bf6ab109813ccdcc12f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170196
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b457b5789b2406dbc943d8eccd79c77f185fa258]

        cid#1607395 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7cecc8a0ced4a9889cf9efd78d7c0341a78c9b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170195
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7b75fc87f03282205b04669402fbff49d82415c9]

        cid#1557346 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifcd2f402bdf0295aee13d02ad713262ab51f9743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170194
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ce14edb625ed14adac1ba00e8d2ea045112150e]

        cid#1556502 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I467e85ad7fd15863a9b52193d8cd815cb66875b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170193
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f5940dbd719be738ad25f4e9e03d87cd491896cc]

        cid#1554702 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1554729 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I39b5e679ea0adf7d3ab543d828730067aef273f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170191
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aac1adf9c5dca96906a2bd206479af767f01f105]

        cid#1554691 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I49597d2f1dc09e843951d10618aa75f702dc70eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170190
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c3385a2479fd511be512e202189c6ad3801a034c]

        cid#1554688 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Icf7c8f12259f8d2023fadc4a62318ee392e71f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170189
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9bb112df79b6e17486d71e2c79d5eb44a16ad61f]

        cid#1554685 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9014693a2baa5dfe727e925f2aae170c11f4b8fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170188
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f77f5e3444102dc7de2322b120af174582aee49]

        cid#1609760 Uninitialized scalar field
        
        Change-Id: If49be901e95dab514d98328d9723f3194dbbb144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170187
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6b80e0554e4b11f9c1eb955c2d26445bc6855371]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/4bed50e14d9d106093b027bc8bb780023fb42b55>
        "gvfs: Update gvfs-1.54.1.tar.xz to 1.54.2 (#295)"
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/88a0d0718a9ddcd75a0842b5173e6d6ecd4d3bde>
        "--enable-ext-nlpsolver (#297)"
        
        Change-Id: Ie39c22c2611a31a8e2a82ae200b7a3836393dff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170177
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-07-09  Dr. David Alan Gilbert  <dave@treblig.org>  [63e023f342bbd4dfaecead6b206a8329b0025e44]

        valgrind: dhat is no longer experimental
        
        The valgrind dhat plugin is no longer experimental as of
        valgrind commit 441bfc5f5 in 2018, update the switch.
        
        Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
        Change-Id: Iba74eeed1cc5e2350d715454bf32192e0bc3692b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170072
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-09  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [329b22498195211af7d0ff7144b8be4bb18c1b4d]

        SDPRCairo: Add support for InvertPrimitive2D
        
        Change-Id: I0e722e9438e7e21d4fa8ba05a9bd56719db521fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170144
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [24bf1dbb32272d6d1846c76ec902b53fc0525f6b]

        python3: easy_install no longer exists on macosx
        
        /bin/sh: line 1: easy_install-3.10: No such file or directory
        
        Also seen in libreoffice-24-2 branch with python 3.8
        /bin/sh: line 1: easy_install-3.8: No such file or directory
        
        Change-Id: Ia4b26c4526c03bec2f06f19ec6ea8539332d43da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170176
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [f9cd7e2801e7bbc620521f2ce3ee4be4c66cdc21]

        tdf#161947: test setuptools is imported on mac
        
        Change-Id: Ie0908e610b3eade41aa5e7f1953ddaa55afce68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170173
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [36a8f4d1a0754e8eefdaabe4bad771355e5ea3a9]

        make SvxGrfCrop hashable
        
        Change-Id: I529b642072becd1171d02598d57a9237e893fa2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Bayram Çiçek  <bayram.cicek@collabora.com>  [045ebdb369ab21a3be7a32dc1c85ad2243eb9129]

        tdf#158857: [Power Query] export connections.xml
        
        - import&export connections stream
        - insert xl/connections.xml reference to [Content_Types].xml
        - add Relationship::CONNECTIONS
        - add support for xr16 namespace
        - add ../customXml/item1.xml relationship to xl/_rels/workbook.xml.rels
        - add import&export support for following xml elements in xl/connections.xml:
        
        <connections>
          <connection>
        
            <dbPr />
        
            <olapPr />
        
            <webPr> (Web Query Properties)
              <tables>
                <m />
        	<s />
        	<x />
              </tables>
            </webPr>
        
            <textPr>
              <textFields>
                <textField />
              </textFields>
            </textPr>
        
            <parameters>
              <parameter />
            </parameters>
        
            <extLst>
              <ext>
                (Any element in any namespace) <- TODO/LATER
              </ext>
            </extLst>
        
          </connection>
        </connections>
        
        Change-Id: I1d1c10675b3fe5ffd6a35f1b91d4b83401be2cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164290
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-09  Heiko Tietze  <tietze.heiko@gmail.com>  [4e606c5b38139c4424fe9334aed32515c7547418]

        Resolves tdf#161568 - Feedback for QFS in floating mode
        
        As band-aid for the lack of proper toolbar resizing,
        feedback is given via entry message type
        
        Change-Id: Ic2b2a2aff93040f558775d63c18c21370fabcb39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170167
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-09  Weblate  <noreply@documentfoundation.org>  [dd56ce1bbf5b8ea51aeaaa3319f3247654f43df8]

        android-viewer translated using Weblate
        
        Hebrew currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: I7f7c03b86b360ba3574882f189b7e45d0b661760
        Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170170
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [1131ccd5ace26906bbb136ff2b4d4d7aa870aa60]

        StyleSheetUndoAction stylesheet param should be a reference
        
        Change-Id: Ib162befb88f7b9671efaa40ea699f0bb21b02adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf1fa49906d041226c715728edce7a7b476b63d3]

        GetOrCreateDrawModel should return a ref not a pointer
        
        Change-Id: Ied3eb7ef805acfcb1093445bd65d1154cab312ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170163
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [726ac1d0c6c32a27646117788428907cc3b57278]

        checkForUniqueItem should take a reference parameter
        
        Change-Id: Ibd9638f9716c4ce8db7ee5e652dc2f207617e7de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-09  Szymon Kłos  <szymon.klos@collabora.com>  [fcad7309358bc66dd37f37b64d30be841bd61832]

        jsdialog: support on demand rendering for icon view
        
        - rename action: rendered_combobox_entry -> rendered_entry
        - change generic get json property callback to more specialized
          image getter as it wasn't used anywhere apart of that and we need
          image enceded as base64 only not JSON
        - add to the full update of icon view "ondemand" property to the entries
          with images so LOK client will know it has to download the render
        - it will be possible to support HiDPI renders in the future: added TODO
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I83a6e91133f8f9cb03e0bc794b51e1947435fa90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170160
        Tested-by: Jenkins

2024-07-09  Mike Kaganski  <mike.kaganski@collabora.com>  [2e25618fe7370e9f378da0b03bca8fac471f01f3]

        Make convert*Angle strict
        
        Only the permitted units are accepted, and must follow the number immediately.
        
        Change-Id: Iccfcbe044334f28f31ba0f8e336f96e6147af694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170137
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-09  Mike Kaganski  <mike.kaganski@collabora.com>  [aa7cf0ec4b7eb9bd709ba695461578311b5ffae8]

        Simplify m_xNumFormatAgg use
        
        Change-Id: I48017e8b1bca2f857afebdd1e90deca86b69451c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170134
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-09  Mike Kaganski  <mike.kaganski@collabora.com>  [493b8ab997d543cb133d3896559f4a733186d659]

        Simplify comphelper::query_aggregation
        
        Change-Id: Id673c27e21c6706367f2effc92bbea61c83a5482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170133
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-09  Jonathan Clark  <jonathan@libreoffice.org>  [6a54d08e6e52623f9769d17d7ea7390052cb275b]

        tdf#56408 Writer always breaks lines at text direction change
        
        This change implements line breaking underflow for bidi portions.
        
        Previously, Writer would always treat the start of a bidi portion as a
        valid position to insert a line break. This caused incorrect line
        breaking behavior in certain situations where LTR text is followed by
        RTL text with no valid break position between, or vice-versa.
        
        Now, Writer will correctly insert the break at the previous valid
        position, rather than always breaking at the direction change.
        
        Change-Id: If4627f4d65d2c44b65653c689ee00a2e0cb4456a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170154
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [81f2185c111b7d8154a2de128d490a0a9e822f19]

        tdf#161709 Make selection rectangle symmetric at any zoom level
        
        The previous method to calculate the rectangles used to draw the cursor did not play well with fractional numbers, making them look asymmetrical at some zoom levels.
        
        This patch makes sure that the cursor is symetrical at any zoom level.
        
        Change-Id: I196177e6722772db3a8c8ad343e35c148e4772a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169546
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-07-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [7383298e141dcc3df23c8c849513b7782b0785e2]

        tdf#161817 Fix Autofill overlay when zoom is low
        
        Prior to this patch, the calculation of the offset to draw the outline was incorrect, which caused the two lines of the outline to overlap.
        
        This patch fixes this issue and makes the outline work at any zoom level.
        
        Change-Id: I95d0b240a53beda872cdf6f0e7d75b48966217d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169665
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b0a522bddff7108523c4c9754bc3084f0e238db]

        cid#1607756 PA: Public Attribute
        
        Change-Id: Ib2f9bff17f865dad2574e5dfe53fba107e4aa81a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [257551a929ff40c9b94bb1313da88eeb242acd36]

        cid#1606535 PA: Public Attribute
        
        Change-Id: I1ef55ce7a2ba32ae67a881505ad202fdb8873661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170139
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e274df5d149fc272277f234bf14d558a77d4bc1]

        make some of the SfxStringItem subclasses hashable
        
        Change-Id: I7ad748b67266926f1e4e67e843a90b5ac3fe58b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170152
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6f89b388365dab9e2df90edd1017370dc7607ea]

        make SdrCustomShapeGeometryItem hashable
        
        Change-Id: Id27784da750e2cc9913c0d00df6e0b10d080f663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [9aaf21b2851410492797a7dcf9193396c8bde770]

        sd: function to return a presentation info in a JSON document
        
        The presentation info includes properties like document size, if the
        slide is visible, master slide information and similar.
        
        [ Miklos: don't refer to removed tools::ScopedJsonWriterArray. ]
        
        Change-Id: I5b0acff2ee0df351dd1859e02695ca249e17c391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170155
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6211461c50a4b713c81fc53ccafcfdf701c7388f]

        Update git submodules
        
        * Update translations from branch 'master'
          to a9266fc54a66142dba20625f94d196898070ca0d
          - update translations for 24.8.0 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: I696fda5336e4c075c43ebbdddc1974e5f1c6fe65
            
2024-07-08  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [611dc34f19deab7f13d00a4058f6a6ac6b50edb2]

        tdf#159900 sw: fix Figure tag placement attribute when exporting to PDF
        
        Paragraph tag is a possible parent element for the Figure tag.
        Figure tag and (any structure element) may have a value of “inline”
        as a placement attribute and thus, may be a child of a Paragraph tag.
        
        Change-Id: Ie1e0221976dbcfbae9ff01b1c9b76dd2d2e7edcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170015
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-07-08  Heiko Tietze  <tietze.heiko@gmail.com>  [3d0411ef53ccd6bb0af21b69aa557f1f40beffd0]

        Resolves tdf#161421 - Keep soft hyphen always visible
        
        Soft hyphen is now visible as printable character unless
        the non-printable is switched on together with the respective
        option; and soft hyphens are always black in the printout
        
        Change-Id: Ief84f986e3d1fa5b11eed827d1a94cf0aef46d10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170158
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7a5d0c413f37e02356d0bd1e1da7a9445ee25fe8]

        Resolves: tdf#161478 Insert button not updated on switch tabs
        
        regression since:
        
        commit fbd79c6125fd302dde9af2d76171dd5ca794af4d
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Wed Mar 20 11:56:03 2019 +0000
        
            weld SwFieldDlg
        
        Change-Id: Ifb4f107bb8d4d53ae81b8ce38a87c9774112b617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170150
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [71f0883939f5851ee69478ca1a022d63963f580f]

        cid#1609594 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib21902ed1279710ae1cd15b6e153ff155b57d35e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170100
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [04a5eff9fa12485da54314c85f2009aff9d9cbf6]

        cid#1608405 silence Unchecked return value
        
        Change-Id: Iceb414227a67c13efb549857c2943eb3bc495bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170130
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b7bd732e28de6a7a4189cf98d2a6d8897d89d83]

        cid#1608145 silence Unchecked return value
        
        and
        
        cid#1606678 Unchecked return value
        cid#1607752 Unchecked return value
        
        Change-Id: Ic611e2d9db17350a5aacbfb2b7c3f933aaea4afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6f1c2c2e837f5682996d761fd4ed1367cc3bd4a]

        cid#1555801 Unchecked return value
        
        Change-Id: I2fbc0b65b081da5776c49962ff3b6a36b76808da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170128
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d9365813abe4b8213415d7aae1269a420380160d]

        cid#1608463 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7f7473fa9f0f5985460bc3e5f48b2d6c413f8d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4564b803bd00ce7b0db29725576e95538d2d980]

        cid#1608336 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I71288cc765b4bcdda35a2a1415537966018806ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22802bf3c32e0ea6e1ebf59bca824a9b6b9279ae]

        cid#1557639 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I02c8486503a54d1ddcdf80f9d7c7ee6389e4e05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170104
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f8480844a6a23b97a2b81381389b566a29eead97]

        cid#1556887 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7e93494191e11c82af9e66ddd467a73f6bc60490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170103
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [698e89b4fd11947814c58adbbf001fb9f9514011]

        cid#1556141 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8bc73176ab44a08553938bb0e9b236639b39a5cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170102
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4f2389362714a6f83d9e11efe0d76d378af37348]

        cid#1556123 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib09e27591987ac1565205cff5c1396ba674c5bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e560140d9bbc4f593f5a67b2327b644c310551b]

        make SvxMarginItem hashable
        
        Change-Id: I9e0d23a81186231ebe314c14993b93e7c8a9d844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170149
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d05a451fcd8c985e860813183de0ec4dfdea0e02]

        make SvxDoubleItem hashable
        
        Change-Id: Ia52a4ce4bd9390872a89bdea0182de697e209180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170148
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d3dd30b535f7283b8f1d8a577986b47ef5528ce]

        make SvxB3DVectorItem hashable
        
        Change-Id: I759d5f225769d3833c6da664793a9d400a398a51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170147
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-08  Miklos Vajna  <vmiklos@collabora.com>  [62fb52cd43d7c0d41dd4e35a1c128947b6a14918]

        tdf#161771 sw content controls: fix DOCX export of empty dropdown list item
        
        Open the bugdoc, save as DOCX, try to open in Word: Word refuses to
        open, saying that the file is corrupted.
        
        Each dropdown item has a value and a display text, it seems it's OK to
        omit the display text, but the value really should not be empty.
        
        Fix the problem by first trying to copy the display text to the value if
        the value would be empty; and if both are empty, then just omit the
        dropdown item.
        
        Note that the trick used at display text won't work here, omitting the
        value attribute (instead of writing an empty one) is still invalid DOCX.
        
        Change-Id: I4ae86aaf1a11cc8fd7c276634647f5737a9b04e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170142
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-07-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d3aa5853552faeb277db18598767fd7add411ebf]

        make SvxGraphicItem hashable
        
        Change-Id: I2cfca6f61c0247947855f40d6b1cdee521e8382d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [343e9126f4930a7744e94a404004d2124582292d]

        cid#1609651 Pointer to local outside scope
        
        since:
        
        commit 5b57fe250108a9ea30b87e40e306af8a79043354
        Date:   Sun Mar 31 00:07:58 2024 +0900
        
            vcl: clean-up and refactor GraphicFilter::ImportUnloadedGraphic
        
        Change-Id: Iea3438863df4ac23860cea403d1633a1d3892970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [427f0b402d6bc2ea2cfd796915ffb1354f9dc6dd]

        cid#1546429 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If781c94f9a86ff91a64e014af5f04392e2380d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170081
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-08  Miklos Vajna  <vmiklos@collabora.com>  [2a22025e1819be82f51938ed7ab705f656ad693c]

        svx: prefix members of SvxGrfCrop
        
        See tdf#94879 for motivation.
        
        Change-Id: Idbba42dd3af7a47db6a56c3a129a4da54af076d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170135
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-07-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5f12f5b2ba3a7ee4ba1086047854929fbaabec58]

        Fix typo
        
        Change-Id: I2803d7c8ad026af902fdc4260219a397026f6f51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170136
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-07  Martin Srebotnjak  <miles@filmsi.net>  [d8c694b5d64b05da8c515e4ffe23c4bcc2376b0f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7ff3bfd58e3959a0f996a42e40de927d38600252
          - Updated Slovenian translation
            
            Change-Id: Iac317055c86ee98e93a504375865f987e91fd08e
            
2024-07-07  Patrick Luby  <guibmacdev@gmail.com>  [7e45017b5156e2e6c5a426edc654f7f022c79863]

        Fix build breakage
        
        Commit 942864606dcb770485e8fc11fb312f12cceadace removed m_bObjectValid
        from the SwXTextDocument class but one instance of that data member
        was still left in the code.
        
        Change-Id: I0addd63173f62f6e8832f54ba94f526d50f22a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170097
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-07  Adam Seskunas  <adamseskunas@gmail.com>  [3c8f9d02e8d9238f6e3dd6a4c769bb26fe8e9093]

        dbaccess complex/DataSource.java to extras/dataSource.cxx
        
        Port the Junit test in DataSource.java over to CppUnit.
        In order to port the test as written in Java the
        CRM Database was ported, so add a test for that here as
        well.
        
        Change-Id: Ib9ac369e3faaa30207b83368889763f0eb063876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169071
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-07  Regina Henschel  <rb.henschel@t-online.de>  [c8bec7d4b311723141d509cfeb74c5118661461c]

        tdf#161483 enable chart read text rotate angle unit
        
        Without the patch chart has ignored the units in ODF attribute
        style:rotate-angle. The patch uses the method
        sax::Converter::convertAngle(), that was introduced in commit
        9f62c7a0f2333d1b7d179a43b3b0341dba7554a1
        
        Change-Id: I606dc1e64c6ba5ee7d1f77d67a936e85f437ed93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170083
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-07-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [18da0b566d5dbcd8e26f2e6bff41249189fb05cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2bf7ec5f1192052bc00bdb113885a41e6fb901b
          - Fix example for COUPDAYS.
            
            Change-Id: Id63a3d2a80aa0c829d1507185467ff575beaac3a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170036
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [942864606dcb770485e8fc11fb312f12cceadace]

        sw: simplify code by checking pointer directly
        
        Change-Id: I873e2d8856e9ceb23a5d0ca5b907c332a8238441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170087
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-07  Julien Nabet  <serval2412@yahoo.fr>  [a74d99644626421fa8e4ba0728f876afe72f28e4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a1ed29aa5320041c72f025e43a9eeabe3bdc2289
          - Fix dup in sbasic/shared/vba_objects.xhp
            
            Change-Id: Ia9019ca5f5129f5d2741941df19622de5ee403eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170109
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-07-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [07821a3516a85c4208e519d93eb018b823d33aed]

        Fix typo
        
        Change-Id: I68649c1b71fa5455f2bc2edd9d773820299e60f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170095
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb57efe8db91d90f45b1f31e583520e0046133aa]

        cid#1546226 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie7bc7b7164f12e167fd6a102c5ed10b71077239a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170080
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [98ae74f85e08644be95e955449f0021d2f4151c2]

        cid#1546189 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia286c035d64aa1534606a7561f3b5a89d66315df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170079
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c13cfd43dff1050b046633f6ebe8dce3298680d]

        cid#1546123 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I648c23c4dc739aae73e8ec39be801400cb16c79a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [578a9d4ab0fead1639bfaa432bfe6f189ddc2038]

        cid#1545993 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3234bce1f3b71f10529d5874552566d7abcb3a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8e46cb2f5d7433f5ed88b02a4a9d0186409d84b]

        cid#1545961 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I40a4dc9bc13bfb769b2f9f15b0ab1ff9490639da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170076
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9320cb2f78b65d0ba1898e95e617194e6031370c]

        cid#1545821 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I41fd2d990c83b88138b18652d41b8b2e55aaa8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170075
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c10a40e2b7c7ae849ce0590aa784f7d770241dfb]

        cid#1545729 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0a811d37996e53b9a9a0bddcc265521a1125d594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [c396c55adf0ff26ba35cd4a77345af541ec85c20]

        sw: simplify code by using UnoApiTest
        
        Change-Id: I0c8ea8468058de9f78cabaa905f84f674b9be93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170082
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d258b218e81a2aa815fa9dac695260c3a40445b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce6b950180c0174cd1b73b37b9fbf7310fe56dbf
          - Fix typo
            
            Change-Id: Ie15138e64d647d669a57a4cfa7c530cd43ad294a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170085
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-07-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c0653c1e268ff8f6a6fe422aadb27675d8b1f583]

        vcl: add more GIF metadata to GraphicFormatDetector
        
        Change-Id: Ie85947371df087495a80179e4e0f2f660877e368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166277
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [02c91f82c2f8de24c6c2097d41725d9bae9d164a]

        move UniqueID to tools and rework to increase counter in constructor
        
        In the tools module it can be used in more other modules.
        
        Changed the instantiation to increase the counter already in the
        constructor, so no need to check if the ID is 0.
        
        Also test for UniqueID
        
        Change-Id: I77c80461875c69496a7e218534d16d6550c168c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170061
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7cc291a8f2db3b2a65d07eded04e51c3c848c709]

        vcl: inch-size.emf is actually PICT format, rename to inch-size.pct
        
        Change-Id: I69c1cf65415546811777ec3df914db3596887db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166276
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [267083e9e7768adcd5316851ce51e1cc22d4627e]

        vcl: remove GraphicDescriptor::ImpConstruct
        
        It's not really needed - it sets values to defaults, which are
        already set.
        
        Change-Id: If61edace7975cd438d86ee9774535c0f14868fd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166275
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-07  Jim Raykowski  <raykowj@gmail.com>  [294cb227e0d2979a55e04dc2ed7aced6ad9e0630]

        Make Managed Changes panel fill remaining vertical space
        
        Affects x11, qt, win, and possibly mac. Gtk fills the remaining vertical
        space with or without this patch.
        
        Change-Id: I30a8f9f97ee4de2c11b8c0c05054d9783a1fb191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170060
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-06  Jim Raykowski  <raykowj@gmail.com>  [adad59c6f71532488b54804c09f0ecb7663b3a22]

        tdf#161717 Enhancement to identify click on tracked change in the
        
        document by highlighting the corrosponding entry in the "Manage
        Changes" dialog and sidebar panel
        
        Change-Id: I1f31580a4fe764dd800c6db1e9a4e2024db14c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169692
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f960d27f158372d4f2d28cd84fee74742f7fbe4d]

        cid#1554774 silence Use of auto that causes a copy
        
        Change-Id: Ie562fa0c4942286cb7dec01473455234f6ebd56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170048
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12a94012cae2c1415d772dd6883c5a49ff46b625]

        cid#1554717 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Icb1df2b857568cf085b597e378094e7231286fce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170047
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8ed305052341a19390471f4747a4e5df1a1926a]

        cid#1554704 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I844d0bfcdb5b16d0e6e06499ceac2add0e26bb9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170046
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ef1337b7326841fac4cf03d42c8172e57566dc06]

        cid#1545304 silence Using invalid iterator
        
        Change-Id: I653c9b9313a854646028c7b2d9982c1233377ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170045
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95ef9610aaabde34fac54574d60427c1e619659b]

        cid#1609596 silence Unintended sign extension
        
        Change-Id: Ia0e95e0dd82e28f155ddf79c48832a9e0ddc3d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170024
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25a1ac878bbb4d8088030286b82ad6031c2def06]

        cid#1609597 silence Using invalid iterator
        
        Change-Id: I08e9ee6016ca0d67be76b0a04e7205e6d90bb46e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170023
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6c58ec277ac9801d57428d23c99644915fdff41]

        cid#1609595 Dereference null return value
        
        Change-Id: I6ae93f46c50e0fe4a29d03fdf02797f808d4d1c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170022
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9e8c9944b9e00e883597495a27f2f03d69016ce2]

        return early if there is no m_pDocShell
        
        Change-Id: Id53115f9cb098b9b8ff1a529f5237054cdfd391e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170014
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170049
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1227e651bcf3e7adae49670bb849abd71c231b8c]

        cid#1608554 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I466a68048496fa4f4aa8177621a6484a261d2069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170021
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0faabc057096631d660725318716638695173298]

        cid#1555223 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I991ea6869a22476d793bf301183ccc984d411a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bc6215f80972a3b48a576edc3bd712a161b8217b]

        cid#1545593 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8252fcd741996b8019edd1fac63e27908fe362d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170019
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4889e0de067761c6e2f8ab661f26af39555ca10e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e859581bf5302296634127cd7bb6576f6e3ec932
          - tdf#149786 tdf#161495 VBA objects & properties & methods (WiP)
            
            - ActiveSheet object
            - (Calc).ExportAsfixedFormat method
            
            This initiates a documentation help page intended to aggregate MSOffice VBA objects
            features that are currently supported.
            Change-Id: I679e9a64923b69fd0d1a5ac99d39651fd8353fc7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168530
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b988ab22f48e4fa118711740f19d0b208b674f36]

        Fix typo
        
        Change-Id: I5d2030f1057f0a2232680ed60f4312331eca2926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170063
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [f41773d684dfb1bfebe484bbf6d1ec4b5937d348]

        python3: silence distutils deprecated warning (take 2)
        
        Since a1295cb177295752f8cbfbb49e13d5bb69ed7dc7
        "python: upgrade to 3.10.14 (master only)"
        
        Now it fails with
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 23, in <module>
            import setupinfo
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setupinfo.py", line 7, in <module>
            from distutils.command.build_ext import build_ext as _build_ext
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/command/build_ext.py", line 13, in <module>
            from distutils.sysconfig import customize_compiler, get_python_version
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/sysconfig.py", line 58, in <module>
            warnings.warn(
        DeprecationWarning: The distutils.sysconfig module is deprecated, use sysconfig instead
        make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/lxml/ExternalProject_lxml.mk:26: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/lxml/build] Error 1
        
        Change-Id: I9000018390b31a65a30ef87d0c500872fc6c9343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170069
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [dc97b366ab9ce3d38c84da06b8b37131579f87f3]

        python3: silence distutils deprecated warning
        
        Since a1295cb177295752f8cbfbb49e13d5bb69ed7dc7
        "python: upgrade to 3.10.14 (master only)"
        Some builds started to fail with
        
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 15, in <module>
            from setuptools import setup
        ModuleNotFoundError: No module named 'setuptools'
        
        During handling of the above exception, another exception occurred:
        
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/lxml/setup.py", line 17, in <module>
            from distutils.core import setup
          File "/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/python-core-3.10.14/lib/distutils/__init__.py", line 19, in <module>
            warnings.warn(_DEPRECATION_MESSAGE,
        DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
        make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/lxml/ExternalProject_lxml.mk:26: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/lxml/build] Error 1
        
        The problem is that python 3.10 doesn't bundle setuptools so
        it's not possible to replace it at the moment
        
        Change-Id: I9a9d077b51f49e912dab4941efe8751c2fcc76e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170068
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5b57fe250108a9ea30b87e40e306af8a79043354]

        vcl: clean-up and refactor GraphicFilter::ImportUnloadedGraphic
        
        - Remove code duplication - Z decompress with a helper function.
        - Split up the code to make it better readable.
        - Default status to ERRCODE_GRFILTER_FILTERERROR and only return
        ERRCODE_NONE on success.
        
        Change-Id: I27c1ba6198120c66d5348702a6af1ffbfa7c5031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166274
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-06  Peter Hagen  <peter@willow-media.nl>  [1d4cecf2f37cd0de9e8e4bcf0c163799e9bca3f3]

        Related tdf#161461: break out of loop once data flavor is set
        
        Change-Id: Ia56514e83e09c6747f582117e77de89f69495862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170034
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2024-07-06  Noel Grandin  <noelgrandin@gmail.com>  [ae2235ccf0663329f0ef69432298b71424a4217b]

        use o3tl::sorted_vector in DefaultItemInstanceManager
        
        Change-Id: I16426008dd8983d56a49b3334b3f163ec350be0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [7aba05331b0e14d3ce2c811a4dc18d4714a7a575]

        DBTestBase: call close at tearDown
        
        Otherwise, calling different tests one after the other
        will fail with
        
        warn:vcl:994718:994718:vcl/source/app/svmain.cxx:497: DeInitVCL: some top Windows are still alive
        text = "lu9947181i0ytl.tmp — LibreOfficeDev Base" type = "10WorkWindow", ptr = 0x555b3ab76810
        
        Change-Id: I6124b768e165ed841738d29c6071e7950b58229f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170058
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3f7cc820f9dcc215ea768da31f213c0e275baf04]

        UniqueID class that generates and stores a uniqueID for an object
        
        UniqueID generates an unique ID (unique for all users of UniqueID)
        and keeps the value for the object's life time.
        
        Change-Id: Ic2cc1665e57b1984c231a050f82a330c9dcf1ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169691
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170017
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-06  Justin Luth  <jluth@mail.com>  [cdf2681d996286953dffa8a033de1b947ae23768]

        tdf#134204 sw: notify when para style inherited a new property
        
        The current logic is totally flawed.
        
        This is one step better. Don't allow one of the special conditions
        to prevent a non-special attribute from being propogated
        down the style inheritance tree.
        
        Change-Id: Ib24ba688700e3c1156449a64d89431043a5c85b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169724
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [a1295cb177295752f8cbfbb49e13d5bb69ed7dc7]

        python: upgrade to 3.10.14 (master only)
        
        Downloaded from https://www.python.org/ftp/python/3.10.14/Python-3.10.14.tar.xz
        
        * external/python3/macos-11.patch.0 should be long
        obsolete by now
        
        Change-Id: I454851f7684e699519370bdbbcd9bb9a2cccd077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170051
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a3706db4fa737ea0047a3605312591698392617]

        pyuno: fix deprecated warnings
        
        * Replace PyUnicode_FromUnicode(str, len) with PyUnicode_FromWideChar(str, len)
        * Replace PyUnicode_AS_UNICODE(PyObject) with PyUnicode_AsWideCharString(PyObject, size)
        
        Change-Id: I1d8b46059d72f4de261d99393e1681f1e41eafdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169625
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-05  Peter Hagen  <peter@willow-media.nl>  [e4cbe169bd1236698a573bf4758d8ae8519a1c08]

        Related tdf#161461: break out of loop once data flavor is set
        
        Change-Id: I37126d2d77a7a80168bd5ab08fa26e8eabfa22cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170055
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-07-05  Noel Grandin  <noelgrandin@gmail.com>  [5e7c94c6026117ee12f72432e3ab101262586e8a]

        fill in more SfxItemType values
        
        found by doing some git grepping, we should now have values
        for all items in the hierarchy
        
        Change-Id: I397ca7e8f53f53737201385c4c8029b436895c1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170016
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-05  Michael Stahl  <michael.stahl@allotropia.de>  [c409c83d777fdb6291c7cd03186b69fe4e7fd902]

        package: avoid throwing RuntimeException in getZipFileContents()
        
        Translate it to ZipIOException.
        
        Change-Id: I7a07a59c0ba301b92f31696355c73ccbdf119ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170013
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-05  Andras Timar  <andras.timar@collabora.com>  [958cabd2e933ec85caf6eca4f0aacee77195fe7a]

        Bundle fonts of Google's DocRepair Project
        
        See https://fonts.google.com/?query=The+DocRepair+Project
        DocRepair project intended to improve compliance with the
        ISO/IEC 29500 standard by providing fallback for proprietary
        fonts that minimizes text reflow in Office Open XML documents.
        
        Agency FB -> Agdasima
        Baskerville Old Face -> Bacasime Antique
        Berlin Sans FB -> Belanosima
        Cooper Black -> Caprasimo
        Lucida Calligraphy -> Lugrasimo
        Lucida Grande -> Lunasima
        Lucida Handwriting -> Lumanosimo
        
        Change-Id: I82a29bd9eeda88198290134a7906a35b6349a1b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169765
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169828
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [7216a5a4ff2210e04732a37b16dbebeb5cce0e31]

        CppunitTest_dbaccess_embeddeddb_performancetest: fix dependencies
        
        Otherwise it fails with
        
        EmbeddedDBPerformanceTest::testPerformance finished in: 426ms
        macros_test.cxx:74:Assertion
        Test name: EmbeddedDBPerformanceTest::testPerformance
        assertion failed
        - Expression: xComponent.is()
        
        After this patch, the tests still fail, but for another reason.
        
        Change-Id: I4fc11a9feef79efd71be8d6bab76f8777c92d115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170012
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-05  Pranam Lashkari  <lpranam@collabora.com>  [4c3f2194bb28fed66b79efe99bad01f70bd83c16]

        LOK: fixed incorrect Logic point calculation for Map mode
        
        problem:
        it was very difficult to select line in online,
        specifically in writer if line is very think and
        it was almost impossible to select line
        
        Change-Id: Ib641cd3d9795b93d47c78bc8f57211f51714844d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168837
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit a0612242a395e1be1fe8383537bc5a82d6b882ac)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169011
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [355e553505a250f137b8bfc714b13084b83f0465]

        libxslt: upgrade to 1.1.42
        
        Downloaded from https://download.gnome.org/sources/libxslt/1.1/libxslt-1.1.42.tar.xz
        
        Change-Id: I77de8a0922c5271161640eae5c92b425c5be82c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170011
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-05  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [74b312d6f255e3bb056dbb7fdf9158fb7b2aecad]

        Add escape direction support for glue points in the preset shapes
        
        Change-Id: I6727def5dd42ecd5dae3ddd27d2af733b5883e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170006
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-07-05  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [a14531e4135a82df53615254cac5e9ea0c357ef4]

        The connector shape is losing its connection
        
        The issue is that we are trying to set the connector shape properties
        too early, but the shapes that we want to connect to have not been created yet.
        
        Follow-up to commit Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa
        "tdf#157172 tdf#157460 PPTX import: fix connectors adjustment values"
        
        Change-Id: I63c76535cc718bc46d5c3ed5489b752925cd6a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170007
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-07-05  Michael Stahl  <michael.stahl@allotropia.de>  [2afdc61dd3138b383fb73dae2242ba1a9c8de901]

        package: ZipFile: treat junk at the start of zip as invalid
        
        Probably the only legitimate use of such is self-extracting archives,
        irrelevant for LO.
        
        ofz56826-1.zip is an example; given what Info-Zip unzip prints about
        this file we don't want to successfully open it.
        
        Change-Id: I9568710227e4a152f9dc7bc356184394d7da8eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170002
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [48e76366ea5932a75792ba5d5e6a474e8003733f]

        annot: don't show the annot. object if LOK and not PDF document
        
        In online the client side comments/annotations are used, so to
        keep this behavior for presentations we only enable the core side
        rendering of annotations when the document is a PDF. No change in
        the desktop applitation.
        
        Change-Id: I50ffd1b6d81d2fcf6ef9f821e783ae228e39e4e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169969
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [269654fe179384f994bf0fe47e2af8c731cac377]

        fix asan build
        
        after commit 85fd526fc681a994415bb422090d1d23aa7d54f6
        "fix and simplify the ItemInstanceManager mechanism"
        
        The problem is that some *Item classes in sw/ and sc/
        share WhichIds, and a whole bunch of SfxBoolItem
        subclasses share the same SfxItemType enum value.
        So we ended up mixing and matching objects
        of different concrete subclasses in a given
        *ItemManager collection.
        
        Add some asserts to the global pool code to catch
        issues like this earlier on.
        
        Add unique value of the SfxItemType enum for all
        the SfxBoolItem subclasses
        
        Change-Id: I3c8d4e02be1cd412b0292e973a6498df5f8e7102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-05  AungKhantOo  <wildgugu2020@gmail.com>  [07a166790b6c6c0b0bce96ce25d970a636ba55d6]

        tdf#159380 Fix for Add an UNO command to close all documents
        
        Change the condition if the documents are immediately closeable.
        Now, save locked documents are not immediately closeable.
        
        Remove the check if in quit or closing docs in SID_CLOSEDOC in
        objserv.cxx as it becomes unneccessary.
        
        Remove some extra new lines which are unnecessary changes from
        before the patch.
        
        Change-Id: Iab16629fe436f4365000fb2a016bbb1fb49c181c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169983
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8cf0bc36a8baa1d53b0a5fb169c6a9d5d8455289]

        tdf#158110 - Paste special: improve check for cells with notes
        
        Change-Id: Ia18d8f91ee2d4493174255424ce7e3b7310c369d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169355
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-07-05  Mike Kaganski  <mike.kaganski@collabora.com>  [96c3d78f39ac4385880ae6f92f15f7ab3564ffcf]

        Make window's default mouse position a large negative
        
        Some operations, like DrawViewShell::Activate, trigger FuDraw::ForcePointer.
        The latter may call SdrView::PickAnything to test if the pointer is over an
        object. In SdrMarkView::CheckSingleSdrObjectHit, the bound rectangle of the
        object is tested first, which doesn't need the object's deep processing. If
        the point in in the rectangle,  the object is processed further,  which may
        render the object. The hit test is performed using a tolerance.
        
        Commit 56a1f9bea2f1b64dee4111ec6671caf42ef63c91  (sd:  extend test to check
        the PDF pages aren't rendered when loaded,  2020-03-26)  made sure that the
        rendering doesn't happen in the LOK mode.  In that mode, the mouse position
        is unchanged from the values  set in the ImplFrameData ctor.  Previously it
        was enough for the test, that the initial position was [-1, -1], which made
        the point outside of the bounding rectangle of the objects. But an upcoming
        fix for the map mode calculations  makes tolerance large enough to consider
        the point inside the rectangle, which triggers rendering and fails the test.
        
        This change  makes the default position  [-32767, -32737],  which should be
        reliably outside of the tested rectangle.
        
        Change-Id: Ie1142729448f7ac3c628880140f123cde66b404e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170005
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ab5d79c90fc33b0a32604e3cbbbc686d01d85d39]

        tdf#161653 Fix selecting from numbering dropdown (Impress/Draw)
        
        Change-Id: Ia066a8ff4b7ab4760fec7a4475afbceee084d115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169995
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [e142fa40fa721bf76da09c1fdc2d32705b5f74b3]

        cpdb: Don't include cpdmgr.hxx if not building CPDB support
        
        Don't include the header when building without
        `--enable-cpdb`, as the code there is CPDB-specific.
        
        This prepares for Biswadeep's pending Gerrit change series
        starting at [1] that implements CPDB support using
        the CPDB C API, and includes the corresponding
        header. (See CI failure [2] due to missing headers
        when not building CPDB without this change in place.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/168633/5
        [2] https://ci.libreoffice.org/job/gerrit_linux_gcc_release/168688/consoleFull#1916232175cd06c086-ffd7-48da-8ce2-d58b9387379c
        
        Change-Id: I8b5395d2ad45d50c63c2dbdd0a5459890fc6f6a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170001
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [24403f4448954b20ff21c81dc92662e2da408fa6]

        fix --disable-firebird-sdbc build
        
        Change-Id: I92e4f1b834b9afe806c29f45af94a562fcb3d78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-04  Michael Stahl  <michael.stahl@allotropia.de>  [6005260078c126bf3f1cf4d6f1ebb631453f5ac7]

        comphelper: treat zip file path segments '.' and '..' as invalid
        
        This will prevent also opening with RepairPackage, would need to adapt
        ZipPackage::getZipFileContents() a bit, but let's hope nobody acutally
        has such files.
        
        Also treat path that starts with "/" as invalid, presumably it's not
        allowed by APPNOTE.TXT:
        "The name of the file, with optional relative path."
        
        Change-Id: Ic694ea2fb34f5de1d490a9a251cf56e4004e9673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169994
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [55032dae6950405ec8efe886e7327dbb863fb4df]

        Fix typo
        
        Change-Id: Ieae6dd42fc2e3b8021356145a676cd96c6fb9e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169999
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8eaaeb50aea08748102f2f52bd7341f867634224]

        Fix typo
        
        Change-Id: Id187ef0b7d1d705dfc45a806fc6db459a278fdcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170000
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e2c17a35057abf81395b381e290ccb07c09bb38]

        tdf#116412: Add unittest
        
        Change-Id: Iab051c91900768a3bf3f26b6de3b443dc18a6928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169990
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [b7bcc716fc4819c52ec0ff02cf4e8c0fda622930]

        pyuno: re-enable pytest_ssl on mac
        
        it was disabled in 731f7fe778c19378dfcbc1a5e9165f666ebb90df
        "disable pytest_ssl on mac" with no apparent reason
        
        Change-Id: I7d867ad771f1459a598c4ca346390e732929d705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169985
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-04  Michael Stahl  <michael.stahl@allotropia.de>  [8d869b5fe47842df52965804db87db0941f4f2a0]

        sfx2: fix signature infobar being shown for every repaired document
        
        (regression from commit 8b333575ee680664fa3d83249ccec90881754ad7)
        
        So it should only be set if the state is still UNKNOWN.  But
        SfxObjectShell::ImplGetSignatureState() is called before the repair
        dialog is shown, so make sure that the second import (with
        RepairPackage) finds both members as SignatureState::UNKOWN.
        
        Change-Id: Ic914016dde6425a4d95fba7f6f66411305553930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169989
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2175d3a847d8644a059c3cb6f3b668ac73c7bdda]

        annot: add tests that checks annotation after an text edit
        
        Change-Id: I18bad2e086330bce335299147af8317232d95ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169644
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [65f672060c5f4bb18e7fd9152912d38241e4bde2]

        annot: add test that checks annotations after page is duplicated
        
        Change-Id: Ic2463272d024acda4f4f5bceadbf8d5779967f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169643
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [d0e063fbc7e689c7f7221d74e01d9bdd007a5373]

        VS natvis: improve css::uno::Any handling
        
        Change-Id: Id982ff1e1e963f6a88cf74cef0a284f6463af923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169988
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-04  Noel Grandin  <noelgrandin@gmail.com>  [59ec1c43222bfb6188f932f6ff458bafb657b21d]

        make SvxColorItem hashable
        
        Change-Id: Ic96d53c113cd6ae5b805df5a8e80d4da7adfec59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169966
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-04  Patrick Luby  <guibmacdev@gmail.com>  [3da1d8a791cff6cf2dad29b64c9ad15b1a65d5b3]

        tdf#161833 treat semi-transparent pixels as opaque
        
        Limiting the contour wrapping polygon to only opaque pixels
        causes clipping of any shadows or other semi-transaprent
        areas in the image. So, instead of testing for fully opaque
        pixels, treat pixels that are not fully transparent as opaque.
        
        Also, tdf#161833 would cause semi-transparent pixels to be
        treated as fully transparent pixels when calculating the wrap
        contour for an image. To force the correct contour when loading
        a document, force the contour to be recalculated by ignoring
        the saved polygon if the contour is set to "recreate on edit".
        
        Change-Id: Ibe256f54e1c82de30c2b7d5b92a69344b4a7ba10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169745
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-04  Julien Nabet  <serval2412@yahoo.fr>  [d9dcada2ed467cd4b892388c9c57ac795cc4c3fb]

        Fix regression Gtk-CRITICAL+Gtk-WARNING on vcl/wizard.ui
        
        (soffice:40467): Gtk-CRITICAL **: 11:08:58.517: gtk_assistant_set_page_has_padding: assertion 'child != NULL' failed
        (soffice:40467): Gtk-WARNING **: 11:59:34.471: ../../../gtk/gtkcontainer.c:1348: container class 'GtkHeaderBar' has no child property named 'expand'
        
        Regression from 2f3f1170a7ae8bb06c6cd66a8ba3eb85cc63c2ac
        Resave with newer Glade version
        
        Change-Id: I9fd86af43149f2ea6bd25e63c1c04360fdae0bcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169987
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07e310498f04dd28f69fc7c3633b881d597c8aff]

        cid#1608601 silence Unchecked return value
        
        Change-Id: Iab18edb8ddb0860b337c0caf5c1fcf661521541f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169982
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a14ef3ee8d34e5a1e31f50eb49b29200feaafa1a]

        cid#1607240 silence Copy-paste error
        
        and
        
        cid#1607649 Copy-paste error
        
        Change-Id: I9b0bfc1b2403ecaa514b6086bc5a4c37b0fdf7ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169981
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a6a95c0ce4334fda99cba0528d08207a7514e8a1]

        cid#1608568 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7509b0033855c66324d655b66bef9cc14f5e8074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169980
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5d9267b81c0123f2148ee91e102b9ebfae4e3373]

        cid#1557397 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9c33fe01e6f48b61df4130b548d9a6c793aa7e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169979
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fec0684c86b71d1b6305a8058a0163dd92fb979c]

        cid#1555756 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I07acff7c5e3cba4afa144843bfeb44c99de81ae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0bd99358cbfaca06436c357a23c2a36bf9287434]

        cid#1555201 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9fcb4b4e1a9c9d7413a2f3cec0d0f408f9b59691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169977
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0d72c7f9dea605ace647712fd6599bf293635208]

        cid#1554775 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I75b3205b23b43ba639b75808d0a832418f7d7c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169976
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cefb16451a15322a8caa62f4d7340978ea047b8b]

        cid#1554763 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I03ad4f979fef11681a3b0a0205cfb143db28b63d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169975
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b0b6f6092eba8685b45a4d38b5814e7944364804]

        cid#1545560 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I38fb9bfb4703c05f3f07634fbed81254a18ad37d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169974
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-04  Regina Henschel  <rb.henschel@t-online.de>  [e9aadbc0ed4916f31693018e65178b21559c73ef]

        tdf#161483 angle unit import for cell text rotation
        
        Currently style:rotation-angle of table-cell-properties is imported
        using ::sax::Converter::convertNumber. That imports only integer values
        and ignores units. But ODF uses the data type 'angle'. That is a double
        with optional units 'deg', 'rad' or 'grad'. A unit-less value is
        treated as degrees.
        
        The patch changes the import to use the new method
        ::sax::Converter::convertAngle(), that was introduced in commit
        9f62c7a0f2333d1b7d179a43b3b0341dba7554a1.
        
        Change-Id: I98c35a762e90b959a005f5bcdf810c5676cc8b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169891
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4e97c21ab32f3e6f28a842ad14bad41f00fefda5]

        annot: AnnotationObject should be the size as the text content
        
        This makes the AnnotationObject to resize the frame to the size of
        the text content, or else the text that is too big will be shown
        outside the object's frame (rectangle). For some reason we need to
        set the object as a "text frame" (mbTextFrame = true) or else it
        will not allow to automatically adjust the frame to the text
        content.
        
        Change-Id: Ib2b9a7c07626fe8b0a2286cfd67c3bf37cf9af03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169642
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [daca6c1e86c9db1ffe400178d13b8c90b6e7579d]

        svx: ImpChainLinkProperties cleanup
        
        Change-Id: I89eb9598dc2cc00284ee6f32a3caf624b405b21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169849
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [38514aecba9bede86d1ca195f9e30592157d1681]

        tdf#152104 speed xls->ods convert part 2
        
        We are doing a lot of work in ScAttrArray::SetPatternAreaImpl,
        where we move the mvData vector of CellAttributeHolder around,
        so inline and reduce some of the work.
        The move operator= can be simplified, leaving some of the work
        to the destructor (which may well be elided when moving
        arrays of elements around).
        
        Reduces time from 50s to 39s
        
        Change-Id: I358f48fa30f785f7b3f221079db93ab0288a7f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-04  Noel Grandin  <noelgrandin@gmail.com>  [2fcad7783d055c6222227bd1672124320eb77a2e]

        make SvxAdjustItem hashable
        
        Change-Id: Ic5c78a0de4e7edafc0ba97bf69d43c377f7b5503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-04  Noel Grandin  <noelgrandin@gmail.com>  [6e1a55dfbdd7651b22be542f3ce048fb769e8aec]

        make SvxEscapementItem hashable
        
        Change-Id: Ic03c78f6dde68f5557d474147336fa62be6f3aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [890916578fc765845922284101599dcf4ece1e58]

        tdf#152104 speed xls->ods convert part 1
        
        we now have 16k columns, so storing a flat array of columns
        where most of them are empty is bad for performance.
        Rather store a sorted data-structure of all the ranges,
        reduces time from > 5 mins to ~50s.
        
        Change-Id: I92327daf06469c1b9d1f4c427b8ebf812641a8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169940
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [31398962c1700e17eff979277ec4d6ce20c0bb34]

        VS natvis: improve handling of SwFlowFrame derivatives
        
        Change-Id: I3fe2169c3b6f016a850dc0df6a248d207a65fb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169973
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [a52b152b4152db97bac70cd31dd707373c574400]

        tdf#144981 tdf#161853 icon choice ctrl: One selection border is enough
        
        The previous `if (bSelected)` body a little bit further
        up in `SvxIconChoiceCtrl_Impl::PaintEntry` already
        has
        
            rRenderContext.DrawRect(CalcFocusRect(pEntry));
        
        to draw a border around the selected entry.
        
        One border is enough, so don't draw another one
        using
        `vcl::RenderTools::DrawSelectionBackground`
        (pass false instead of true for the `bDrawBorder` param).
        
        For the gen and the Qt-based VCL plugins that use
        Cairo rendering by default, this avoids the
        additional misplaced and not properly cleared selection
        rectangle.
        See tdf#144981 comment 6 for where the problematic
        handling in the Cairo rendering path is, but which also
        mentions that changing this would break other things.
        
        For then gen VCL plugin using Skia (`SAL_FORCESKIA=1`)
        or on Windows, I see no visual change for either the
        "Hyperlink" dialog (Ctrl+K) or the "Page Style" dialog
        (Alt+Shift+P) in Writer with this change in place while
        moving focus between entries.
        On Windows, when moving focus out of the icon choice
        control (into the tab page), the border now remains
        black on all sides instead of being partially black
        (at least the top border) and partially blue (at least
        the bottom border), so it's more consistent there as well
        now.
        
        Change-Id: I6db415344e9276ce89d41c6b40fb93fc38ddf9a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169972
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [f4a755cf7de2d028f5c47c1d0223422d00a05e47]

        tdf#161853 Simplify SvxIconChoiceCtrl_Impl::RepaintSelectedEntries
        
        * Drop superfluous check at the start. (Loop will
          just do nothing if there are no elements.)
        * Use range-based for.
        
        Change-Id: Idbe0ba67268cf76d38b27fcf94e59eb8abd5f566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169971
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [4d43de52e0597076a81b8f8e5cee1afbf0b84b8b]

        tdf#161853 Drop IconChoiceFlags::SelectingRect
        
        Since
        
            commit 35775e291d6570b29dc0120e4839c720152b5149
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 12:34:57 2024 +0200
        
                tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRect etc.
        
        , that flag is never set, so there's no need to check
        for that. Drop it.
        
        Change-Id: Ibc2efdfc9b54c19bb90c2e71cc80e0cb4a0321a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169970
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3958f65b8e5d28bf2e4a7854f7446bebf427e23b]

        pptx: Import comment author initials
        
        Change-Id: Ic5838c929db9c08d6d9c6e1c87160dc2530105e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169847
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9b72524722efbc60532a04bb55660a3c35696adf]

        pptx export: Respect user defined initials
        
        instead of generating new ones.
        
        Change-Id: I8979eaa694642cebd552534eeddcff5483831e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169846
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2dfcc67fbc80892d136a11322e68d24ed0511171]

        Fix TODO
        
        Change-Id: I77b4609d796978fefab1c60034310f890e3b973e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169845
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-07-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9df3294ed8d3224910dc182eca1650ff637b9e22]

        ppt export: Respect user defined initials
        
        instead of generating new ones.
        
        Change-Id: If64690ac2aa22542e6b3939f3ed9cdc3c9f3be84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169844
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [93516e9181d321fe2579308d95de85cefe21a05d]

        tdf#161853 SvxIconChoiceCtrlEntry: Drop means to manually set neighbours
        
        This mechanism to manually sort the entries by setting
        a link/pointer to the neighbours isn't actually used, so
        drop the code to maintain a linked list.
        
        See
        
            Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:44:46 2024 +0200
        
                tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead
        
        Change-Id: Ib939145999725232d803103dc1fd0b49fa2d425a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169916
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [5db79db0f0c7c432d933433192506d234f6cd26e]

        tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::GetPredecessorGrid
        
        Unused since:
        
            Change-Id: I4a412389669f9cbc6701b7ed78bd45f838e13590
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:34:20 2024 +0200
        
                tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::{Set,Find}EntryPredecessor
        
        Change-Id: I3688c74d0cdf01c68913767f6aa214c54ab719cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169915
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [c04fd602ea58b9a373b3363441f0e5971165c1a6]

        tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead
        
        With
        
            Change-Id: I13ae34ffc51972bef746e53fcd46e65ea9fbf82c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:38:56 2024 +0200
        
                tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::InitPredecessors
        
        in place, it can be seen that `SvxIconChoiceCtrl_Impl::pHead`
        is always nullptr as it's initialized to that and never
        assigned a different value afterwards.
        
        Therefore, drop it and all related code.
        
        Drop the now unused `bKeepPredecessors` param
        from `SvxIconChoiceCtrl_Impl::Arrange` and
        `SvxIconChoiceCtrl_Impl::ImpArrange`.
        
        (Use `git show --ignore-space change` to more clearly
        see the "actual changes").
        
        Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169914
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [5b94bedf779f36f2b77b04171e7f6cc28cecbfc6]

        tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::InitPredecessors
        
        Unused since:
        
            Change-Id: I4a412389669f9cbc6701b7ed78bd45f838e13590
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:34:20 2024 +0200
        
                tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::{Set,Find}EntryPredecessor
        
        Change-Id: I13ae34ffc51972bef746e53fcd46e65ea9fbf82c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169913
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [8809bbc87e83488509391052b27ad690615f65ac]

        tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::{Set,Find}EntryPredecessor
        
        Both methods are unused since:
        
            Change-Id: I926b03a0f2054c21f8ab96eeee0083156443d2c0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:17:41 2024 +0200
        
                tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::SetEntryPos
        
        Further cleanup will be done in following commits.
        
        Change-Id: I4a412389669f9cbc6701b7ed78bd45f838e13590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169912
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [14c88b770ad1d03897b9514b6ab0c696bf376f6b]

        tdf#161853 Drop unused SvxIconChoiceCtrl_Impl::SetEntryPos
        
        Unused since:
        
            Change-Id: I63ab1272140a0d5386538e6b749ba0f652f49c38
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 10:15:27 2024 +0200
        
                tdf#161853 Drop SvxIconViewFlags::POS_MOVED
        
        Change-Id: I926b03a0f2054c21f8ab96eeee0083156443d2c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169911
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [0583a07e5fad562b7d404aa5d17579114c285219]

        tdf#161853 Drop SvxIconViewFlags::POS_MOVED
        
        The flag is never set, so there's no need to
        check or clear it either.
        
        Change-Id: I63ab1272140a0d5386538e6b749ba0f652f49c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169910
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [fed3e5d4ea03d12d17dd380359689e4f00c7f90e]

        tdf#161853 Drop SvxIconViewFlags::POS_LOCKED
        
        The flag is never set, so there's no need to
        check or clear it either.
        
        The only method setting it
        (`SvxIconChoiceCtrl_Impl::LockEntryPos`) was dropped in
        
            commit 18d18c8a5646868a8229dea9ffe3f46888c2bad5
            Author: Joseph Powers <jpowers27@cox.net>
            Date:   Sat Jul 23 07:16:14 2011 -0700
        
                unusedcode.easy: svxIconChoiceCtrl_Impl
        
                Doing List cleanup, I ran into SaveSelection() and decided to delete it.
                While I was in the class, I went ahead and cleanup them all up.
        
        , but that method was already unused by then.
        
        Drop the flag and related code.
        
        Change-Id: I9b886f3a63444d502ef8c488437889a2b05e065a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169909
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [ed3c987a60dddcf3a75a15cbb5251d57a9bccdb7]

        tdf#161853 Drop SvxIconChoiceCtrl_Impl::bUpdateMode
        
        It's initialized to true and since
        
            Change-Id: I0c6f191017b13fffee57d1e5eba1c03c05736ee2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 3 09:09:22 2024 +0200
        
                tdf#161853 icon choice ctrl: Drop WB_SMART_ARRANGE handling
        
        , the value never changes, so drop it and simplify
        accordingly.
        
        Change-Id: I05007727e29a7884165fa25c668f139a96b7c4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169905
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [11169e6b29cbe7d782a6236d2a866b07b7501417]

        tdf#161853 icon choice ctrl: Drop WB_SMART_ARRANGE handling
        
        That flag is unused since `OApplicationIconControl`
        was ported away from using `SvtIconChoiceCtrl` in
        
            commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b
            Date:   Wed Aug 19 14:59:33 2020 +0100
        
                weld OApplicationSwapWindow
        
        , so drop it.
        
        Change-Id: I0c6f191017b13fffee57d1e5eba1c03c05736ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169904
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [1bffb064a0fbffebd2e33e3b6fdfdbc17b310489]

        tdf#161853 Drop SvxIconChoiceCtrl_Impl::MouseButtonUp
        
        Since
        
                commit af9413cb4ad49c0b4854c08cc2804644220755ae
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Tue Jul 2 11:53:27 2024 +0200
        
                    tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        , the `IconChoiceFlags::DownDeselect` and `IconChoiceFlags::DownCtrl`
        flags are never set, so `SvxIconChoiceCtrl_Impl::MouseButtonUp`
        wouldn't effectively do anything.
        
        Drop it and the now unused flags.
        
        Also drop the `SvtIconChoiceCtrl` override for
        `Control::MouseButtonUp`.
        
        Change-Id: I06808726389f31a426cba36e627b4305fb362bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169903
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [d4d81421918209456c4669ef48c3f4f2afd8d97f]

        tdf#161853 Drop SvxIconChoiceCtrl_Impl::bHighlightFramePressed
        
        Since
        
            commit af9413cb4ad49c0b4854c08cc2804644220755ae
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 11:53:27 2024 +0200
        
                tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        , `SvxIconChoiceCtrl_Impl::bHighlightFramePressed` is always
        false, so drop it and the corresponding handling.
        
        This also means that the `bKeepHighlightFlags` param
        for `SvxIconChoiceCtrl_Impl::SetEntryHighlightFrame`
        is now unused, so drop that as well.
        
        Change-Id: I278318b2bda14b06339a375b683a49f8594e2e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169902
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e650777fa21ed8b88b4dde2ff3607238928f3aa5]

        Fix Help build with --with-lang=...
        
        Variable gb_POLOCATION is empty.
        include langlist.mk after TargetLocations.mk
        
        Change-Id: I3e82624df84700c922d116b32a366c0e6b424235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169928
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-07-03  Jim Raykowski  <raykowj@gmail.com>  [8616a49d37dec0d17bd2355a3cf4cdb447ba6514]

        tdf#160817 related: fix tooltip-text translatable context assignments
        
        Fixes copy-paste oversights in commit
        94891dce760817686600f3a8d25e5eb735a1a133
        
        Change-Id: Ibe8ea0e7d58ea748ac90732f09af0e5bee0dff45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169892
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [25b37b4c8c8c5aef7cd530d919258bd8e5dce068]

        raptor: Use --without-www
        
        it seems not used. Besides, it fails when upgrading
        to libxml2 2.13.
        See https://gerrit.libreoffice.org/c/core/+/169327
        
        Change-Id: If383130eac3b5d6de911c4c273c8e371a4980f23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169933
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-03  Mike Kaganski  <mike.kaganski@collabora.com>  [d7d14e91f7525010c375c3302b75b4b22579849d]

        SHGFI_EXETYPE doesn't need SHFILEINFOW
        
        Change-Id: Ib18d5a3992174c0b56f11970d02515bc6d0ea615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169907
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-03  Mike Kaganski  <mike.kaganski@collabora.com>  [afa5ade8b51d609ece8408506a14e3f169774960]

        Optimize a bit
        
        Change-Id: Icccf4a93054780c7a111f664117b25821c47f700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169906
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-03  Jonathan Clark  <jonathan@libreoffice.org>  [71b7313aa2324b8f7da2026e7b7c2d1c942b497c]

        tdf#101686 Writer textbox direction changes depending on zoom
        
        Previously, DrawingLayer would apply RTL flags in the case of RTL text,
        but it would not clear them in the case of LTR text.
        
        In certain situations, it is possible for Writer to draw the contents of
        a text box while the VCL output device is configured for RTL output. As
        a result, whether DrawingLayer correctly drew LTR text as LTR would
        depend on the order that text was rendered. This issue would manifest as
        text boxes appearing to spontaneously mirror themselves while zooming
        and scrolling through Writer documents containing RTL text.
        
        This change updates the relevant portion of DrawingLayer to also clear
        the RTL flags in the case of LTR text.
        
        Change-Id: I3a75561d08cdf3ee6c74b8f6e62f75a1dfcf165e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169942
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [cdda6533b44333b18d3dc6306dfd0f7058e40b32]

        unoxml: port checkCVE_2012_0037 from java to CppUnittest
        
        so CI will be able to catch the problem reported in
        https://gerrit.libreoffice.org/c/core/+/169327
        
        Change-Id: Id00e5f50fbf43f63f4bad5af13a62e4db88f82d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169932
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc256da45a9d4907ecaa61f4912d0c26a97ca266]

        cid#1607629 Uninitialized scalar field
        
        Change-Id: Iaaef519741b6cec7aabe0e4b9b58ebe1a858e03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169926
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f2e48a6f2a12f44b9afd779f91e708e52cdf5978]

        cid#1607231 Uninitialized scalar field
        
        Change-Id: I33d78ff590d9debd3013d4082688f44f4c00a9e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [74f0a22ab268fb2d15c7f7ac8ea15fb4a3fae122]

        cid#1607108 silence Unchecked dynamic_cast
        
        Change-Id: I4bd000f16e0e75beff4877ccff43a8a81e8d393f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169924
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cd91074bc087b0f85293c2756cdb96f53024c489]

        cid#1606556 Overflowed constant
        
        Change-Id: I7748094d226b8201cfbdf43d6ae7df0cd776f9e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169923
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [e42be49887e75c6ec748b6c48bb4e5eda295c715]

        tdf#123293: port test from Java to CppUnitTest
        
        Change-Id: I5297a041970871ab0fba6a71d59639b07072b64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169889
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-03  Justin Luth  <jluth@mail.com>  [433c4180acd5c5a699e71ab2f749713db36dc165]

        tdf#161646 sw page number wizard: fit into existing margins
        
        Often page numbers are inserted when a document is finished,
        and at that point it would be annoying to repaginate everything,
        so offer this option of trying to fit the page number
        into the existing margins.
        
        I was tempted to enable it by default,
        except that it would then mismatch any pages
        that had header/footers created via other methods.
        
        Problem:
        -how to know which font is really needed: western, CTL, CJK?
        
        This patch depends on NFC b7fce2b26ee4ba585544457adc742807a2129d2c
        
        Change-Id: I285a99f8e2f12c87a8bdee20a9c86a1d79f80dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169349
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [79a77bba092dce84f7fee3e72da9600ec2d1bd2b]

        Fix typo
        
        Change-Id: I5c4735345bdb2a574e4b79ba7bfc88e95d0bf878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169936
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8c8cb76bbdafa5005a8cb4ab9c4810745ffbe918]

        Fix typo
        
        Change-Id: Ib5752f1301c95d3941ecacac13918184dfe7c945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169935
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [15168f9453cf6a623a494817289b98695dcb5a05]

        cid#1608717 Logically dead code
        
        Change-Id: I06f5912a914936a08f68bddb7fa32fb87ffc0876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169922
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eb16a84eda6accabfc07067b7a85d7846036e5ce]

        cid#1606793 Dereference before null check
        
        Change-Id: Ia2d5c0e347322828a0fa3c6b5af2b6a27956d4aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169921
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b743425a1dbb7e662eb9bdedb1a08c20716c71fb]

        cid#1607891 Dereference after null check
        
        Change-Id: Ie446d2623ca41254e3f72ac05f3f090265af48ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169920
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3cc88383f99da0b2cb2557b6788d474c44ae88f]

        cid#1266442 Dereference after null check
        
        Change-Id: I07df88d2593b7887ec87ac4aca1c46c7dfb556cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169919
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ab8716ffaf27d68c50b151e19360d896b66dea3]

        cid#1556879 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6fa1fb410a815a5eb8ff9f799c35f8af0b3ac7de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [424c149ee0eef3b407939f39d98baae347ee46b1]

        cid#1555210 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0a863bc4e9726a4f4ffb348576abd0ae0c812de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169917
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-03  Moritz Duge  <moritz.duge@allotropia.de>  [c792fe496ef8913c4d2fec7739d197d6f1a18693]

        --with-doxygen is only relevant with --enable-odk since b0228e4d3
        
        Change-Id: I24eeb3a28658ba631dc8f7389b6e2933111657f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169568
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9f40f8be73fd4ae0f0e2bfd7a034950d15d5d27]

        Fix typos
        
        Change-Id: Ie2960818431638d8c233ef710069da410f194180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169901
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-03  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [3fbf01513a9de76f4c4cdc6c92b3aa6e71796e2b]

        tdf#33603: handle outliner setup for notes pane search
        
        User can start search from subviewshell context of Notes pane, so
        disambiguate & delegate to actual main view shell (same fallback logic
        as for non-Notes pane case).
        
        Change-Id: I129505f452690ca5fde23dc6953cc3f34438d267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169710
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6ad09ca884fb7f35e2e24d532d85f6d818a7f1b]

        sfx2: port checkRDFa from Java to CppUnittest
        
        TESTRDFA.odt is still used by checkTdf123293.
        (To be ported in a follow-up commit)
        while at it, move existing 'hello.odt' file from
        misc to data, this is the normal folder name
        for files everywhere
        
        Change-Id: I3ab12550e1d2e7654cb59c55c6da40b6c28b7e46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169888
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [85fd526fc681a994415bb422090d1d23aa7d54f6]

        fix and simplify the ItemInstanceManager mechanism
        
        The mechanism is currently broken because it uses hash values as keys,
        in two different places. But hash values are not required to be unique,
        and as soon as there are enough items of a given type, a collision is
        inevitable.
        
        So just simplify this whole mechanism. There is no reason we need
        type-specific item managers. Stuff everything into a single global pool,
        that uses hashing correctly.
        
        Notes
        
        (*) Performance, as far as I can tell, is the same or slightly better.
        
        (*) I removed the NUMBER_OF_UNSHARED_INSTANCES thing, in favour
        of just having a simpler mechanism
        
        Change-Id: I9068baf9bf6fae2500ae5748c6d1aabe6c3a18a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169709
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c3318d7597956314feac7c61a7ef2da6d3f41a1]

        disable most of tdf159102 UITest again
        
        because it fails reliably on my machine and on the ASAN box
        
        Change-Id: I4eddbcc04f96837783a41fb30e4d003d11c14aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169890
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-03  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [b2aa4319f90788410d40bac723a2cc9fbf3f8d97]

        tdf#33603: make notes pane searchable
        
        Flattens DocumentIteratorImpl, getting rid of the
        intermediary ViewIteratorImpl.
        
        Now the DocumentIteratorImpl, iterates in the following
        pattern:
        1-) For all slides, visit the NormalView and
            the NotesView before advancing to next slide.
        2-) Master Pages
        3-) Handouts
        
        Now when a search result is found in the NotesView that is
        displayed on the NotesPane instead of the NotesView.
        
        Change-Id: I8133c6a74861e783ab1a23f51ac5faf362a0f512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169659
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [d52136a8335024c32c81bbe79fef3557baf8fc45]

        tdf#161853 Drop SvxIconChoiceCtrl_Impl::GetSelectionCount
        
        Support for anything except single selection mode was dropped
        in
        
                Change-Id: I0acde664d695571e9058b9829ad02745a4abaad2
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Tue Jul 2 11:53:27 2024 +0200
        
                    tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        , so the selection count will usually be 1.
        
        The only use is in `SvxIconChoiceCtrl_Impl::GetFirstSelectedEntry`,
        and should it be possible for no entry to be selected,
        that will still return `nullptr` anyway.
        
        Change-Id: I46562b448b59ba7013ff2e98cfba5925347e01a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169886
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [0ec47906c488d20b4ce43a4df78bbed9ae7cd6b8]

        tdf#161853 icon choice ctrl: Drop unused async select handler
        
        `SvtIconChoiceCtrl` and its implementation class,
        `SvxIconChoiceCtrl_Impl`, is only used in `VerticalTabControl`.
        
        That one sets the `WB_HIGHLIGHTFRAME` bit, so the code path
        using the asynchronous handling in
        `SvxIconChoiceCtrl_Impl::CallSelectHandler` never gets used.
        The comment in there also explains that this should happen
        synchronously in case of single-select mode, which is by now
        the only implemented mode.
        
        Therefore, drop the asynchronous handling altogether.
        
        Change-Id: I238f3bb26b590df32f6dc7e67c402b2fb1762a62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169879
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [e04b97acf2dc410c2e6380abdf23f9a2df792284]

        tdf#161853 icon choice ctrl: Drop unused WB_NOASYNCSELECTHDL
        
        That bit is never set, so drop it.
        
        Change-Id: Iffa13bd0a679505bdc47bc3fb5d828969ac9eb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169878
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [35775e291d6570b29dc0120e4839c720152b5149]

        tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRect etc.
        
        `SvxIconChoiceCtrl_Impl::SelectRect` is unused since:
        
            Change-Id: Ifd60c030b91636acc58298f0e7b97b69c1312be1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 12:02:05 2024 +0200
        
                tdf#161853 Simplify SvxIconChoiceCtrl_Impl::SetCursor_Impl
        
        Drop it, and drop the `GetHotSpot` helper that was only
        used by it.
        
        Also drop `SvxIconChoiceCtrl_Impl::aCurSelectionRect`
        that is by now only written to, but never read.
        
        Change-Id: I1fb833acce1d4a0d96c45bca2eda2d5969baff77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169877
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [150f61fb0056b9f26796e491ffe6e3094b805236]

        tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRange
        
        Unused since:
        
            Change-Id: Ifd60c030b91636acc58298f0e7b97b69c1312be1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 12:02:05 2024 +0200
        
                tdf#161853 Simplify SvxIconChoiceCtrl_Impl::SetCursor_Impl
        
        Change-Id: I770e859e1bfd3610413f125cbfa3de0a9be4e66a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169876
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [8a204bc8504a06ee4f2f1d358a54a5bad1c39f8b]

        tdf#161853 icon choice ctrl: Drop tracking selected rects
        
        `SvxIconChoiceCtrl_Impl::AddSelectedRect` is unused since
        
            Change-Id: Ifd60c030b91636acc58298f0e7b97b69c1312be1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 12:02:05 2024 +0200
        
                tdf#161853 Simplify SvxIconChoiceCtrl_Impl::SetCursor_Impl
        
        That means that no rects are ever added to
        `SvxIconChoiceCtrl_Impl::aSelectedRectList`, so drop
        it and the methods to manage its content.
        
        Change-Id: Ia2221ab2d4e8319e8fd103c7e4e02c4fdf5926fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169875
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [681b69ab5de3e8aa735a150613837e7ab801939e]

        tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectAll
        
        Unused since:
        
            Change-Id: I0acde664d695571e9058b9829ad02745a4abaad2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 11:53:27 2024 +0200
        
                tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        Also drop the now unused `SvxIconChoiceCtrl_Impl::pAnchor`.
        
        Change-Id: I70351b1ad37a691ba18bf981972f97ab981cbe1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169874
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [21661ce368a3458a51fc6fccab8defebb9b9e59c]

        tdf#161853 Simplify SvxIconChoiceCtrl_Impl::SetCursor_Impl
        
        Since
        
            Change-Id: I0acde664d695571e9058b9829ad02745a4abaad2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 2 11:53:27 2024 +0200
        
                tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        , the `bShift` and `bMod1` params passed to
        `SvxIconChoiceCtrl_Impl::SetCursor_Impl` are always false,
        so drop them and their handling.
        
        With that dropped, the `pOldCursor` param also becomes
        unused, so drop that as well.
        
        Change-Id: Ifd60c030b91636acc58298f0e7b97b69c1312be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169873
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [af9413cb4ad49c0b4854c08cc2804644220755ae]

        tdf#161853 icon choice ctrl: Drop support for non-single selection modes
        
        Since
        
            commit fd2ea8e03510c6a99ec8be6228b7422f6c5b182b
            Date:   Wed Aug 19 14:59:33 2020 +0100
        
                weld OApplicationSwapWindow
        
        , the `SvtIconChoiceCtrl` and its implementation
        class, `SvxIconChoiceCtrl_Impl`, is only used
        in `VerticalTabControl`.
        That one was explicitly enabling
        `SelectionMode::Single` in its ctor.
        
        Therefore, other modes are unused.
        Drop support for them altogether to simplify
        the implementation.
        
        This commit primarily drops `SvxIconChoiceCtrl_Impl::eSelectionMode`
        and uses thereof, and allows for further simplification in
        upcoming commits.
        
        Change-Id: I0acde664d695571e9058b9829ad02745a4abaad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169872
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-03  Michael Weghorn  <m.weghorn@posteo.de>  [65013d5d0d5c5348d51b037fb6719fd25ddedda4]

        tdf#161853 icon choice control: Drop WB_NOSELECTION
        
        It's never set, so drop it, also to prepare for further
        cleanup in upcoming commits.
        
        Change-Id: Id1751b68e3666130a69b981f9095303115d30caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169871
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-03  Michael Meeks  <michael.meeks@collabora.com>  [2456746bc20796c20d23498967e0b3a976decc54]

        lok: Avoid launching an un-necessary thread.
        
        It seems this happens rather regularly with online; and yet we
        are running the main-loop, seems this was introduced to allow
        UNO usage without a main-loop, but this is not really our case.
        
            cf. commit 168a67f4b3ace8c4b46567651429e956547bc1f9
            Author: mm <mm@openoffice.org>
            Date:   Thu Feb 22 17:22:48 2001 +0000
        
                VCL without main
        
        Change-Id: Ibd10a4966157f30557eff88c124e63ffae2e1f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169821
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-07-02  Justin Luth  <justin.luth@collabora.com>  [6adfa5811d4dc65b28544169825b88846bc55596]

        sw fmtcol.cxx: fix copy/paste error
        
        I don't think it makes any functional difference,
        except that the wrong which ID would be returned.
        Otherwise they are all identical AFAIK.
        
        From commit fcb6e076d9004ef907a2616d04bf9c39908e6e8a
        Author: Bjoern Michaelsen on Sat Jan 9 21:49:51 2021 +0100
            SfxPoolItem: introduce StaticWhichCast and DynamicWhichCast
        
         case RES_CHRATR_FONTSIZE:
        -    aFontSizeArr[0] = static_cast<const SvxFontHeightItem*>(pNew);
        +    aFontSizeArr[0] = &pNew->StaticWhichCast(RES_CHRATR_CJK_FONTSIZE);
                 break;
         case RES_CHRATR_CJK_FONTSIZE:
        -    aFontSizeArr[1] = static_cast<const SvxFontHeightItem*>(pNew);
        +    aFontSizeArr[1] = &pNew->StaticWhichCast(RES_CHRATR_CJK_FONTSIZE);
        
        
        Change-Id: Ie85aacb8d28cadaa509cd9bc050cb9cf98b9967a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169747
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [79c710438abbaa204df77f9b9ebebddbdf4ab02b]

        Don't pass unused optional agrument
        
        IShellLinkW::GetPath allows to pass nullptr to its third argument:
        see https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinkw-getpath
        
        Change-Id: Icf1ca402448b8dfcc3a5ab2834341e67e8dc0b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169869
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-02  Armin Le Grand (Collabora)  <Armin.Le.Grand@me.com>  [8a6fb1793d98a11114322195dffc608a32216264]

        SDPRCairo: enhance CairoPixelProcessor2D
        
        Added and corrected quite some stuff to this basic
        construct provided by Caolan (thanks again!). No
        detailed descriptions here, but it's getting more
        complete and faster.
        
        May contain errors and is primitive-complete in the
        sense that all gets rendered, but some basic stuff
        that should be directly supported is still missing,
        e.g. text rendering.
        
        Adding this to allow people to check it out (speed)
        also since it's not yet used as default in master,
        so it's safe and also safes the changes publically.
        
        To test it, use TEST_SYSTEM_PRIMITIVE_RENDERER as
        set EnvVar in linux systems.
        
        Change-Id: I25f795c9ea4ad4f3b99591304f8803dffa499436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168911
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [6144341c8ee50c5623d9352c5dbb43785a728bca]

        Add source location to ComError
        
        And use in CSysShExec::execute to improve location reporting
        
        Change-Id: I624df0418b99a79207f5aeefa38d2bfe5ea7ffe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169880
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [3b824baa863880ada2a8e8178c35d56c1aafab8f]

        Simplify error handling in CSysShExec::execute
        
        Change-Id: I6c9723d67eeda6deea088ac28b843628a5b3200f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169867
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [2467e7c874aea2099048fcfc0b5d7934d8b90f48]

        Simplify a bit
        
        Change-Id: I97277866d1a81854b45ddb8403f2efaa67215f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169868
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-02  Michael Stahl  <michael.stahl@allotropia.de>  [8b333575ee680664fa3d83249ccec90881754ad7]

        sfx2: SfxObjectShell should not trust any signature on repaired package
        
        Change-Id: I0317f80989e9dabd23e88e3caab26ede3fb5bd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169883
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-02  Michael Stahl  <michael.stahl@allotropia.de>  [67dca5a47d1be1b38edee7d0d81fa9adfce5a22e]

        package: ZipFile: check Info-ZIP Unicode Path Extra Field
        
        Change-Id: I829eb449e8a0947341f066399be549f56b0f02da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169882
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-02  Michael Stahl  <michael.stahl@allotropia.de>  [67cb6af482bc5b0f4d310f0a42a85057f3db0267]

        package: ZipFile: don't accept duplicate CEN entries
        
        Change-Id: Ice341a11346b445c555cba276bf2284e4f9b6685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169881
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-07-02  Jaume Pujantell  <jaume.pujantell@collabora.com>  [b32aa67f17a645c1d6f2b544d315f12bad123547]

        lok calc: allow copy hyperlink outside of edit mode
        
        Right now .uno:CopyHyperlinkLocation only works on edit mode or
        inside a draw object, but LOK_CALLBACK_HYPERLINK_CLICKED is
        dispatched outside of edit mode and the copy command from
        the pop-up is ignored.
        
        Since there is no text cursor, the position of the hyperlink is
        needed to discriminate the correct field, since there could be
        multiple hyperlink fields inside the same cell.
        
        Change-Id: If545cf56e631adcdb914c4e799a309bc8bd0422f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169507
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 0533474cb0188aede59841bf4d547106949f2760)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169729
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2024-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [83a8d5a275e9ba636a133ff25bdb53974aae87ae]

        BootstrapFixture: get rid of mxComponentContext
        
        Change-Id: I0318485c3c0159277e47096e0c7e0df8ed109ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169865
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [49e3ebcaa1ff06e9ae35ba4117e2465e447cee78]

        CppunitTest_toolkit: simplify code
        
        Change-Id: Id5fd9d1ebe11551b73b44b6d12414d5418dd4de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169863
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f457046fa40af781a518a4962571c1056a2c326d]

        cid#1556572 Use of auto that causes a copy
        
        Change-Id: Id6b1c25a12e43ee60dc01293e96c02d4f027c7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a3fe1c6fa79c00dad9c62c8f45a084a938083a01]

        cid#1557889 Use of auto that causes a copy
        
        Change-Id: I6c510fa69e8db6ddc6ca6b9a169f4181ef62adab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169861
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52dc33d76ff990ca7a264583dc1c22f474ee3290]

        cid#1608558 Use of auto that causes a copy
        
        Change-Id: Ie09084cdd9060db28905cb693c5b010a760876d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169860
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d8ba2f283435553184e7ef67b8b09b85905ee6b]

        cid#1545549 silence Using invalid iterator
        
        Change-Id: I6374cdc5230f46c8064ca34d57ff1abc4f3d84aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169859
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [21f58d0411deb3962de0270e3adbdabf2027a7ab]

        cid#1545929 Using invalid iterator
        
        Change-Id: I7d798b233eae9906f9caff9da411b27d3e26ebb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169858
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9661b8694c46b8c3a4856e50e2c1f3b82108a973]

        cid#1606605 Logically dead code
        
        Change-Id: I54d6445efb3e63cd5c74dc0da115a75fea66edef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169857
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a0fe67b2456f5ffb66b6eb0b27c1a19c1347e25e]

        cid#1606744 Dereference after null check
        
        Change-Id: Ifbb6417903a2751068597815ad91e90ce6d8f35a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169856
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [62077cdf444dabe512e65abef7fa832c82f78c41]

        cid#1608155 Argument cannot be negative
        
        Change-Id: I60ca191631f3874e2c7f1d037272189db140f25b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169855
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Heiko Tietze  <tietze.heiko@gmail.com>  [544524820715c659c05524aae68b69bfa0422898]

        Related tdf#161796 - Label change on gtk3 together with icon
        
        Sequence matters
        
        Change-Id: I0a591cc1ec8c3c506ece47dc89f368096f6c8e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169850
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-02  Julien Nabet  <serval2412@yahoo.fr>  [4eb077f3216c5516a45d1a6951339e8fc5686f3e]

        tdf#161859: Typo in AutoText (Polish)
        
        Change-Id: I66c5c2b12abdc0aa71e4c6afaa8520024874a230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169851
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-02  Beeram_12  <pranithreddy16.beeram@gmail.com>  [458f5a7e8c2cd2e38eb744f6046f27874f0a0fa0]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: Ia581b91ce0b08ff1117daba691197be555951992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166971
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-07-02  Hossein  <hossein@libreoffice.org>  [b7a5d0e5669863033156ef15190c9fd509c45fa3]

        tdf#149256 Ship LibreOfficeKit headers in packages
        
        Add LibreOfficeKitGtk.h
        
        Change-Id: Ia575b9b9cb46ce4225d9030bf01453c5b3359325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169623
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6a0d4d45d9e5933028f437ebd6756946a127e4a4]

        cid#1554879 Use of auto that causes a copy
        
        Change-Id: I5989905a2efeff23cf803832a5d65857c64b036e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d581a8a2236b13a84ba9fbc5c1837bee3f7b7a0]

        cid#1607340 Use of auto that causes a copy
        
        Change-Id: I46bd4bf5cf6df3dba8518b40a8a9ace7dfef2e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169853
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [9877ab0b5ebadf70a138db582f298bf0e5d1cd9e]

        tdf#161853 vcl: Drop unnecessary indirection for icon choice control
        
        Just call `SvxIconChoiceCtrl_Impl::SetEntryTextMode` directly,
        instead of doing so via the `pView`, and drop the now unused
        `SvtIconChoiceCtrl::SetEntryTextMode`.
        
        Change-Id: I9b42f1bee6984e2c34814addd998cefd56dbe7f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169837
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [01fa9762bcf761e5a1fd9eac6740e6829f21b5b1]

        tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::SetEntryTextMode
        
        It never gets called with a null SvxIconChoiceCtrlEntry,
        so change the param from pointer to reference
        (also in `SvtIconChoiceCtrl::SetEntryTextMode`), and drop
        the handling for the never-reached null case.
        
        This also makes SvtIconChoiceCtrl::eTextMode become unused,
        so drop it.
        
        Change-Id: I428c47dcbc85568009be3454ffa7a8b977c6d095
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169836
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [f9f0bf9b47a627e13477ac893bcb9436c72a49d5]

        tdf#161853 vcl: Drop SvtIconChoiceCtrl::GetEntryText
        
        Just call `SvxIconChoiceCtrlEntry::GetText` directly
        instead of having an extra level of indirection to
        get the same result.
        
        Change-Id: I6a299f5de4e7979044ade11e5441260383ce0b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169834
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [212196344c99982aa42ec1eecb36006c9a12655f]

        tdf#161853 vcl: Drop SvtIconChoiceCtrl::DrawEntryImage
        
        Just draw the image using the render context right in
        `SvxIconChoiceCtrl_Impl::PaintItem` instead of
        having a very specialized static method that's only used
        from there.
        
        Change-Id: Idf8967f6df3823742445906e558fcd7f532271af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169833
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [9780e0843f5ee6165b8d8bc4c01071e7a2be9742]

        tdf#161853 vcl: Drop outdated icon choice control comment
        
        The `sal_uLong` out param that the outdated comment
        refers to was dropped in
        
            commit 497c589802a788de78af28ea88cec947b25355b3
            Date:   Tue Jun 16 14:36:06 2015 +0200
        
                sal_uLong->sal_Int32 in SvtIconChoiceCtrl
        
                and drop the pass-by-reference param from GetSelected, nothing
                uses it
        
        Change-Id: I95334361b8d91ffd9497317a066718d466457c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169832
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [9fb6ebd42bc5e2c416ffbc222261cc781c9cc3bc]

        tdf#161853 vcl: Drop unused SvxIconChoiceCtrlColumnInfo
        
        Unused since:
        
            Change-Id: I113a00d41a40b10df9d4d6dbb71565d462d9f8ae
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 1 13:24:56 2024 +0200
        
                tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::GetColumn
        
        Change-Id: Ie32fcc443323bd2840aa14edefc533b743e1ed75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169825
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [25d1c2f7f7451e6be1b172ae1f97f3c0ad052276]

        tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::GetColumn
        
        Since no column is ever set, see
        
            Change-Id: I06a877d5ebffef95495cc3e57be088cdc08d71fe
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 1 13:19:18 2024 +0200
        
                tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::SetColumn
        
        , there are also no columns to get, so drop
        `SvxIconChoiceCtrl_Impl::GetColumn` and
        `SvxIconChoiceCtrl_Impl::m_pColumns` altogether.
        
        Change-Id: I113a00d41a40b10df9d4d6dbb71565d462d9f8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169804
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [3c9822d36e1f03be604491961be9f7c3981c2704]

        tdf#161853 vcl: Drop unused SvxIconChoiceCtrl_Impl::SetColumn
        
        It's unused since
        
            commit b64751ba28fd69fb2a93a21b10a92b68f4dd2097
            Date:   Fri Apr 26 10:47:00 2024 +0200
        
                tdf#99528 Properly layout vertical tabs without icons
        
        Change-Id: I06a877d5ebffef95495cc3e57be088cdc08d71fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169803
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [d3c82ab9255a019229ac9f3bc9429a63fc9d89a6]

        tdf#161853 vcl: Simplify SvxIconChoiceCtrl_Impl::CalcTextRect
        
        Drop the `OUString* pStr` param and always use the entry
        text instead. This is the default, and all callers explicitly
        passing a string were passing the entry text anyway.
        
        Change-Id: I0ef46ca001fe568febb02e132df379c360d8282a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169802
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [7c467736fd3b08ec7ea0bd930bfd96add9f77a2d]

        tdf#161853 vcl: Pass vector by const ref instead of pointer
        
        Pass the vector of rectangles by const ref instead of
        as pointer for both variants of
        `SvxIconChoiceCtrl_Impl::SelectRect`, which also
        makes it clearer that this is never nullptr.
        
        Change-Id: I10c9ff27602128eb878d03125d966e1fbf198237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169797
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [72ef986133be94fd872ceaef57f3e0ffd7a538d8]

        tdf#161853 vcl: Use range-based for
        
        Change-Id: I69824a42b74071678c2c8f102fff78453e1718de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169796
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [99d45ab7275af130485e52f71abaf7f72fd1239a]

        tdf#161853 vcl: Use const ref instead of pointer
        
        Pass a const reference instead of a pointer
        to `SvxIconChoiceCtrl_Impl::IsOver` and dereference
        in caller instead of (unconditionally) in the
        method itself.
        
        Change-Id: Ib530c33ccaffd794116f0acc042c96e4c29dee1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169795
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [c08ea5efd1a67ff63881fa830c37c1f4da24bbb8]

        tdf#161853 Translate rest of German comment
        
        Somehow, these 2 words previously remained in German
        when the comments were translated.
        
        Change-Id: I9d40b7df14d9328f52ba3d9ee8217f9ec1128272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169794
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [1582d803e1de1fb8863a9d8eaea959fd2ea588ec]

        tdf#161853 vcl: Move logic into SvxIconChoiceCtrl_Impl::DrawFocusRect
        
        Move calculating the focus rect from
        `SvxIconChoiceCtrl_Impl::PaintItem` to
        `SvxIconChoiceCtrl_Impl::DrawFocusRect`.
        
        The former is currently the only caller
        of the latter, so behavior should remain
        unchanged.
        
        Change-Id: I1c3dd73acb3a1a6b8bb61034c06a79d75c5ed3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169793
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [23a5be4d6d04944dcbbb06912c434eedd3719b3b]

        tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::HideDDIcon
        
        It's superfluous, as the only place calling it already calls
        `pView->PaintImmediately();` manually right after that, which
        is the same that `SvxIconChoiceCtrl_Impl::HideDDIcon` does.
        
        Change-Id: I8bf6e27e598fc5070dd551e3152dcc4cad91f1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169792
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-07-02  HakimOttey  <hakimotteybusiness@gmail.com>  [7153b25d4da845bfb309c75df48f9ea00ec70c47]

        tdf#42982 Use IllegalTypeException Error with message
        
        within impl_initValues_throw
        
        Change-Id: I03942ac2e3478e57b7d94b77b6f100367a53f7ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166648
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [dc5adb7ca805186763e23c365192e2a379d25eb6]

        Use more getters/setters instead of direct member access
        
        Change-Id: I8e0077f9040f0036f16e97da65c93c3fd6a87747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169744
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-02  Adam Seskunas  <adamseskunas@gmail.com>  [57de44900938ce13cfd1aa0c6fd0c841ba7e6b23]

        Port CRMDatabase from Java to C++
        
        --Port createTables and createQueries
        --Add a general test for the CRMDatabase
        --Edit Make file
        
        Change-Id: Ifbbb9010c8d8b8a4a199af73539b1f6a9ec45a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169573
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-07-02  Heiko Tietze  <tietze.heiko@gmail.com>  [216d1ba73281fe7098dc115e64ff288cc781a770]

        Related tdf#161796 - Update donate icon
        
        Based on artwork by Ravi Poovaiah / ITT Bombay free to use for any purpose
        taken from https://commons.wikimedia.org/wiki/File:Heart-hand-shake.svg
        
        Change-Id: Ib9716b5ca18727eb50e637decc008a80089875cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169829
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-02  László Németh  <nemeth@numbertext.org>  [6eee182e46bb568a58620a02e5827532d15c8220]

        tdf#159102 sw: add missing get_url_for_data_file to the unit test
        
        Partial revert of commit 5fa3abd3b28b7c30d015dc058f7719112003f51e
        "tdf#158803 Remove unused imports from uitest".
        
        Follow-up to commit c6d7b7fa686b742c6ffef42aa6cc280358babe0d
        "tdf#159102 sw: enable unit test again with extended test document".
        
        Change-Id: Id6397d322f25f1b3e981d8e206a54bb79a54b831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169848
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-07-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [bff48f885e3aad560776a42e451a735ed6c72c57]

        Revert "libxml2: upgrade to 2.13.1"
        
        This reverts commit 2b27f0eb5858a4fd296170fb7e4533e5fc7aa3e9.
        
        Reason for revert: JunitTest_unordf_complex fails
        
        Change-Id: I5c9b6ec454c46a737a7052cc8dd450044dd48495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169817
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-07-01  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [05041641da82fc0382503195ae9bdeb5182f764b]

        tdf#157172 tdf#157460 PPTX import: fix connectors adjustment values
        
        Change-Id: Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169830
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-07-01  László Németh  <nemeth@numbertext.org>  [c6d7b7fa686b742c6ffef42aa6cc280358babe0d]

        tdf#159102 sw: enable unit test again with extended test document
        
        It seems, incomplete document settings resulted broken unit testing
        on some platforms, so complete the test document with the removed
        document settings, and enable the test again.
        
        This reverts also commit 1b83ebf42c535528b73baac2407b347f19070d07
        "disabling UITest tdf159102".
        
        Change-Id: I53f008a096aa209fb2c634e7e2464a1a4acbab71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169842
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-07-01  László Németh  <nemeth@numbertext.org>  [83733601124f611938c365426485d0001e1fe454]

        tdf#160170 sw: test for fix overshrank lines with hyphenation
        
        Follow-up to commit ca540209a8c20a2734f180d4706d5153bdf64523
        "tdf#160170 sw: fix overshrunk justified lines at hyphenation".
        
        Change-Id: Ia983e7f560b996f9b11b679d346186ad39e85598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169840
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-07-01  Jim Raykowski  <raykowj@gmail.com>  [94891dce760817686600f3a8d25e5eb735a1a133]

        tdf#160817 SwNavigator expose main functions for selected entry
        
        Replaces the headings/outline move action buttons in the tools area
        with a toolbar to expose the main functions for the selected entry in
        the content tree.
        
        Change-Id: Iedb5b53375088a159d640fb986bfcf9376fa2072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168174
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-01  Jim Raykowski  <raykowj@gmail.com>  [53c027335fe272616b5ece3f7e20da8a0868a1c5]

        SwNavigator: Add a function to delete all content of a content type
        
        and use it to delete all footnote/endnote content
        
        Done in preparation of following patches that provide the ability to
        delete all content of a content type.
        
        Change-Id: Ie329e60033ea10e936049d70c4654f4c6473e55e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168173
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [001d8041aebfaf460bf8420af311e240a9d42183]

        move global item pool to own source file
        
        Change-Id: I91365c844370ef423630d5679cadd91cbf0597b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169799
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [af2175bb87b8e8a7184916e110e2b22ec542357d]

        crashtesting: divide by zero
        
        since:
        
        commit 7b807a6b793198c00db9b2c2c3a5eb3ebfe16ad9
        Date:   Fri Jun 21 12:28:30 2024 +0200
        
            tdf#161086 bitmap location wrong with SVG with an embedded PNG
        
        bodge it by using the requested width/height and not the possibly
        zero on fail actual sizes
        
        Change-Id: Ic55ba6ce3cc14fa598299cdd1f844ee7c63fb174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169800
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f02d75147e69b7010e642e9e32de08ee873cf480]

        cid#1604131 Dereference null return value
        
        Change-Id: Id790c9f8433e7dd780aeaec1a1dd614c6ab3daa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169791
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3c93be675990190513ee379812d79896236c1aec]

        cid#1604130 Dereference null return value
        
        Change-Id: Icd6bf3bc72ac9728b4a7f3c602cb919bfdef18e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169790
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b3ecc330b4e68769ad0b96a9a2859fcd1bdc9f8]

        cid#1604129 Uninitialized scalar field
        
        Change-Id: Id75a73a8fc4cb06bdc1cbccab8921e1794e13382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169789
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [a18c31569c281cb8b3e7dcc8e545a698c5e86df3]

        Resave with newer Glade version
        
        Change-Id: Ia6e4011bff54f8c471def8f2b4d764beb462c05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169384
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [39ece7a6a44b83e50a442a7bf88251951c121ba8]

        cid#1604132 Identical code for different branches
        
        revealed after
        
        commit 50f3443d59d457da8dd19e0520f317851f050469
        Date:   Wed Jun 19 15:21:12 2024 +0900
        
            pdf: remove CHECK_RETURN macro from code
        
        Change-Id: I35b7c5493e377f691e783ac09a56b72b8463868c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169787
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [17d7694fd9951e3ae50958ca073bf4edb30b85fe]

        Remove duplicated include
        
        Change-Id: I9042bd1573e97164233ae9289193301ed01fc3c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169783
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-07-01  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7575946c8dac10d755411ff88563f356bc6681d6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5e39c70b93559a266ba9f68344fe8c4c3f2feacf
          - Update menu item path to Field Hidden Paragraphs
            
            Change-Id: I6f89dcd355ac8cea53b8e94137a6c3b2faade74b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169801
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-07-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f9d10ce76f16a29969a7cae0eda4294f15699379]

        Resave with newer Glade version
        
        Change-Id: Ic9492bb1a2c94a5d47dbad8f9360aba5c4b8f8c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169600
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [832a096cb02cf01e0b3839e959f2da43e27620b9]

        Call to EndListening here no longer necessary
        
        after
            commit 4d0ba0badeb5a83d8eb5373ba5d7ef931dcf62c9
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jun 26 11:18:47 2024 +0200
            reduce number of SvxTextEditSourceImpl listeners on SdrModel
        
        Change-Id: Iba5c0e863713aa76d2b3ddafdca2bc44bc92c753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169788
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-01  Hossein  <hossein@libreoffice.org>  [830ba03622b89992b1aef6fb8bf25680a68d5fdf]

        Fix unwanted code behavior change in sc/
        
        While changing the code to use std::optional instead of bool, some
        unwanted code behavior changes were introduced in this commit:
        
        commit fbe8071e4f6be57d3e372d69a4c7cc4d37a83eb9
        Date:   Sat Oct 15 14:20:31 2022 +0200
        
            refactor functions: return optional instead of bool
        
        Part of those unwanted changes are fixed in this commit:
        
        commit 243e811abc441ec7f55e1395f23343dfa6f7c812
        Date:   Wed Jun 5 10:14:49 2024 +0100
        
            cid#1603200 Uninitialized scalar variable
        
            cid#1603199 Uninitialized scalar variable
        
        This commit undoes changes in the above (second) commit, and tries to fix
        the problems by making the code look closer to what it was before the
        first commit.
        
        Change-Id: I47d692a5cf46abad582d7f162e2180e6c26b7e5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169037
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [7b428b160780c1a60a947ecc99b148456d9f4eea]

        Only use -Wv:18 in Visual Studio 2019
        
        And fix the warnings discovered in Visual Studio 2022:
        
         C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(714): warning C4456: declaration of 'numMethods' hides previous local declaration
         C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(681): note: see declaration of 'numMethods'
         C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(1032): warning C4457: declaration of 'pUnoI' hides function parameter
         C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(918): note: see declaration of 'pUnoI'
         C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(109): warning C4456: declaration of 'param' hides previous local declaration
         C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(84): note: see declaration of 'param'
         C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(256): warning C4456: declaration of 'param' hides previous local declaration
         C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(240): note: see declaration of 'param'
        
        Change-Id: I99abcf17c7c431a403a488c53b65ef34d66d0940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169782
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [263dc5c171af8ef77f44c2295a21bdb65fea641b]

        Fix the warning description
        
        Change-Id: I355e4ab73f58303c3b423ec4230bd55ded95da05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169785
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-07-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b6cdd1d7ffff87d16b3a5767ad33ac178f73cd34]

        doc: Don't export notes author/date when in privacy mode
        
        Change-Id: I54459ed5f556f2dbe88d149ea859105db35f1cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169647
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [463c3739c697cf824c87720caaa2520f7f83837c]

        ofz#69444 Integer-overflow
        
        Change-Id: I86b612ec964915084ba207aa0be120cdf4ede389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169778
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [743796b2a94fbbb6fd79b1880734c5fdf9f8953e]

        upgrade to tiff-4.6.0t
        
        Change-Id: I6e521a84dc6d08d754c42200094ebec214637de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169777
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d30ecb5fb07f005ebd944e864f0a15678289a4ed]

        ofz#69809 Integer-overflow
        
        Change-Id: Ie4e19b4f1d12de7b8f71b50dac56e4559ea0027b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169775
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-07-01  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [fddc381856aba41b95faccaa803c7fe9cf4ec721]

        Resave with newer Glade version
        
        Change-Id: I427437cf861ea75413d5bee14cca2dba73add1a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169603
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-07-01  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [4b3995bf5d0058ec70e35679abf1940a5c0e2f69]

        Resolves tdf#161796 - Add a donate button to the start center
        
        Set Common::Misc::ShowDonation to false in order to get the
        legacy Extensions button
        
        Icon by Muhammad Haq on freeicons.io (slightly modified)
        
        Change-Id: I83d10d7230722d38914934d59d70ece471e62599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169628
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-01  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [c65127e5f6efcc5db93d2f80b9592f458200d596]

        tdf#158416: restore infobar text colours
        
        ...which were lost with de1b926fa294273caefb29a507e117b8487e882b.
        rMessageColor is put back into the switch, but uses the settings' warning
        and error colours introduced by d7fd378b533c42f51d1d363f5da30b1fa1281f67
        where applicable.
        Colours were checked for sufficient contrast in
        https://gerrit.libreoffice.org/c/core/+/47825
        
        Change-Id: Iba42020b665e35c34f09b3788bcc973b0f8531d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168761
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-07-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [21120ae0ed8025bca68dc05a359b175b3ff9b980]

        doc: Don't export changes author/date when in privacy mode
        
        Change-Id: I48c5688b76d895eac3850bf69ff1a08cf6c0879f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169650
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [09c5cdfed1a9f7a690f6b4d8bfff98ca4ab1911c]

        Use correct config option to keep changes info
        
        copy/paste error
        
        Change-Id: Iaccd96aced4ac0aa9bd93265aee34b66b6e23a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169648
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-07-01  Noel Grandin  <noelgrandin@gmail.com>  [4637bad647b15892cb954731ad8fd8ff6533a4eb]

        call fillDecimal() in SvxTabStop constructor
        
        otherwise we get the weird behaviour where two SvxTabStop instances
        which are constructed the same, return false from operator==
        because one instance has had getDecimal() called on it, and the
        other not.
        
        Change-Id: I1f708c1b1e03efcd9fc554eaf2777c4c3e8a80b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169774
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-07-01  Noel Grandin  <noelgrandin@gmail.com>  [26ae64ae9f1feafac0219de75d6c23b54ceefaae]

        remove hashCode from SvxBorderLine
        
        because they are unused and incorrect. They are incorrect because
        hashCode and operator== are not mutually consistent, as I found
        out when I tried to use them.
        
        They were introduced in
            commit c39e4f6b8a942680bc7250177c34fd034a0605e0
            Author: Oliver Specht <oliver.specht@cib.de>
            Date:   Wed May 22 12:26:46 2024 +0200
            Add SfxItemType to SfxPoolItem
        but were not used in that commit.
        
        Change-Id: I1c3c67e904823117401a0f72a49c80f4bb6398a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-07-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [73a180c39f6c893c94be8a1b36b645682621adcc]

        Fix typo
        
        Follow-up to 1f3c82e3b0171bac89cbc7d1ec1ca89fac1c7eec
        
        See https://www.unicode.org/charts/PDF/U1400.pdf
        
        Change-Id: Iece91e51f1eea21495849368950747f3056f197d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169769
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-06-30  Michael Weghorn  <m.weghorn@posteo.de>  [5bf58785ba2831de4efc2afe9df463b4a753ccb1]

        gtk4: Require GTK >= 4.10
        
        For the gtk4 VCL plugin, require GTK version >= 4.10
        and drop code for older versions.
        
        This simplifies maintenance, in particular since
        requiring 4.10 ensures that the basic GtkAccessible API
        is available.
        
        GTK 4.10 was released on 2023-03-04 [1], so it
        will be almost 2 years by the time that LO 25.2
        will be released.
        
        Given that the gtk4 VCL plugin is still experimental,
        providing support for older GTK 4 releases shouldn't
        have to be a concern.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/blob/4.10.0/NEWS?ref_type=tags
        
        Change-Id: I6f361b533391225d0e74c174e0479b767b9d827a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169324
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0e3394f7123b6d63b91c1c55f227253f21cba343]

        vs-ide-integration: set correct solution / project platform
        
        This allows the IDE to show active #ifdef conditions, type sizes,
        alignment, memory layout, selected overloads, and so on.
        
        Change-Id: Idd1211df3b3745658f1996a494929b07cf7aa573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169772
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [76a52cb698801d9689a9bd92995a2a792a11639a]

        Optimize SystemWindow layout a bit
        
        And simplify its ctor, using default member initializers.
        
        Change-Id: I08f06182c51d38299956cdf7ad2705c926c937d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169770
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [a597b52b76855d91f147a4483139997a25082524]

        Make SystemWindow::mbIsDeferredInit private
        
        This optimizes its layout a bit, deduplicates, and exposes less guts
        
        Change-Id: If522747fdc2c666ac7876b39e72cc689f3c5c89f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169767
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2ffd958fcdd17ccffb6394e3515c83458464775b]

        Resave with newer Glade version
        
        Change-Id: I502cda571288fa8b4a1aeaffe78705e47de5d379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169601
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [58ed26938f254e1952dfaed4b208ad5a89b89387]

        tdf#161844: AbsoluteScreenPixelRectangle is a closed interval
        
        Change-Id: If52fd8e97b6b9c3eed72720b8dc7151b278a0183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169766
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-30  Aron Budea  <aron.budea@collabora.com>  [696eb4b4e55ce26cee9aee2c76a7125df91ae0d6]

        tdf#161310 Translate My AutoText in Insert toolbar
        
        Use same pattern as 42e6e26255b21c1bfde893f5aaf23d4a37ecee91
        and dffdc0b1995e2b24304ce0651ca886bbf9cf4f95
        
        Change-Id: If36ecdcbb771bfcde9836203e84586045d039c8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [786ed5c3ad3048d638df5f19d4bf6b8f28271e69]

        Resave with newer Glade version
        
        Change-Id: I062f3dc2671beb0c82b43905f2b9afb5050f9e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169429
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [02a536fa7642b01fb486f69a18c2e509702a5db0]

        Resave with newer Glade version
        
        Change-Id: I9e8672e92648359ff8ec7e3f7b667e785b51f0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169602
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-30  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8e035840d18cb29cca9f2304891054f58c64e9d0]

        Resave with newer Glade version
        
        Change-Id: Ia6374adeb4ef15f6d3d0d3bca365b269562bb640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169597
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-29  László Németh  <nemeth@numbertext.org>  [b0b691aa32719aa0d41bc0f72480cc455bc414ec]

        tdf#161563 sw: fix invisible light gray underline for No Break
        
        Light gray underline visualization depended on IsShowHiddenChar()
        instead of the correct IsViewMetaChar() (Show Formatting Marks).
        
        Follow-up to commit 2f0c7d5691acd4010443856788a54b0abc03098b
        "tdf#161563 tdf#161565 sw: add No Break to word context menu &
        visualize" and commit 41916d9fb045654fa19b4eac90a3099550a890f7
        "tdf#161563 sw: show "No Break" context menu only on a whole word".
        
        Change-Id: I3d10011962732ab3730e5f833e95252e9fe6bfee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169721
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-29  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [e6b974fd699dcef28a7c26a96c74f3b9a8df9cab]

        tdf#157216 PPTX: add "glue points" to flowchart shapes
        
        Change-Id: I1595c3ddcca08e4e95da608edbe18edc57b41362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166457
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [eb56caec68477d11f281090a09c130a416626d88]

        Fix VBA Table's *Padding properties type
        
        In VBA, it is Single, not Double. See VBA documentation:
        https://learn.microsoft.com/en-us/office/vba/api/word.table.bottompadding
        https://learn.microsoft.com/en-us/office/vba/api/word.table.leftpadding
        https://learn.microsoft.com/en-us/office/vba/api/word.table.rightpadding
        https://learn.microsoft.com/en-us/office/vba/api/word.table.toppadding
        
        Change-Id: I9262462424fc11b5c062a61754ab0fab9103f549
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169763
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [203bd3f6744649638703d1b4f7f9d517226557ce]

        Fix VBA get*Padding, which returns a floating-point value
        
        Introduced in commit f3234f4f14702da71528561418f07ee6670a8c2a (VBA
        Add Padding properties to XTable, 2022-08-05). The unit test is
        edited to test that the value returned by the methods is equal to
        the initially set value, with precision of 0.1 pt.
        
        Change-Id: I24144cd0e3c1e72bd2664a2a052ac3c7006595ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169762
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c910d8cd67a042ce722c416f879f566bca5bdd81]

        Fix typo
        
        Change-Id: Ic80446b21443a025a4d4877730ef097ba39ca66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169752
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [63f36e4b76992b0ecb568cf2f61d953caa2834c4]

        Move MapToO3tlLength and FieldToO3tlLength to respective enums' headers
        
        Decreases dependency on <tools/UnitConversion.hxx> a bit.
        
        Change-Id: Ia469c08ca2844c522f508a724ddc879120d0b50d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169761
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [2adf50be3df057e36562af1bf69ffc26c012d1f1]

        Rename some ConversionHelper functions
        
        Make their names more explicit. This avoids ambiguity; previously,
        convertTwipToMM100 was very similar to tools' convertTwipToMm100,
        provoking the former function's use where the latter is better.
        
        Drop convertTwipToMM100WithoutLimit, and use the unconstrained
        function from tools directly instead.
        
        Change-Id: Icdd1a67721cdd8a578bc786fda67c341b07ec84a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169759
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [102cbf4626dc80191a21af53c65f4817a0baef9b]

        Fix "lets" -> "let's"
        
        Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Tested-by: Jenkins

2024-06-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36d898b3bc635e996cad074fc81341d43a650a3f]

        Fix "lets" -> "let's"
        
        Change-Id: I3f55e97561323cff8a4148d8388ecd3a5550c704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169753
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [819194eb3b60ce53533678d6dd57bebed58996c0]

        Use better types here
        
        Change-Id: Icc9c6fdea2c3d10db51728389187589a26a887c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169758
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [dfe1f8fddeab73a75d9849aa59a95e8d52e55af4]

        Related tdf#64028 - COPYDELETE must not update references
        
        in order to behave like cut
        
        Change-Id: Ia30428edee00950e2874c0f615e4033167c1031b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169754
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [6756a753e933135c6ed033137153f4c1c9255655]

        Use a matching type here
        
        Change-Id: I23dbadd27838a3cacad51a6b67aef10faed71640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169757
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ccff60b4ae951f28be8bc10f9621ed75b3097d7b]

        Decrease rounding errors a bit
        
        Change-Id: If9f078c96d03046aba4db19125a17fcf7fd68a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169756
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0748844975b1b241b9e80e82605177f7d31a724f]

        Simplify some uses of convertTwipToMm100
        
        Change-Id: I073ac7358c1bcb82992ec7746f4b3986d6d35633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169755
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [11ad465075d7f99627997dcc2b6c50117a549562]

        Simplify a use of convertTwipToMm100 a bit
        
        For some reason, MSVC fails to find the o3tl::convert overload for Size
        defined in <tools/gen.hxx>, unless the call to convert is unqualified,
        accompanied by a 'using namespace o3tl' in convertTwipToMm100.
        
        Change-Id: I7100ef55156b6944b5adc5aefa52eee38b3fe69e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169751
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [291c380fcf220880cd59d30bbdabc34bb871f228]

        warning C6011: Dereferencing NULL pointer 'pArgs'
        
         C:\lo\core\sw\source\uibase\uiview\viewsrch.cxx(237) : warning C6011:
         Dereferencing NULL pointer 'pArgs'. : Lines: 132, 134, 135, 136, 137, 140, 141, 149, 151, 196, 198, 200, 204, 205, 219, 228, 229, 237
        
        Change-Id: Id06d08b310dffa15823b1d40996467888ff4ea7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169750
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [4982e260bb75665287b071cefb349550c200914e]

        Simplify WrapPolygon
        
        Use doubles instead of fractions.
        Simplify correctWordWrapPolygon, which used redundant arithmetics
        (it scaled by a fraction with nWrap100Percent in multiplier, then
        by another fraction with nWrap100Percent in divisor).
        
        Change-Id: I69a38ac7e3afda33a1e7725cab711d50dc80eed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169746
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-29  László Németh  <nemeth@numbertext.org>  [39dfb6393ac95787e4259b9509a12b686a9a0dae]

        tdf#96787 AutoCorrect: find item with ".*" and between :colons:
        
        It was very hard to disable autocorrection of (c)->© and other
        AutoCorrect items, because the searched Replace string "(c)"
        etc. didn't jump the list cursor to the corresponding ".*(c)"
        item.
        
        Now skip ".*" pattern matching marks, also colon (emoji
        replacement) characters, so the list cursor jumps to the
        line ".*(c)"->© typing only "(c" etc., allowing users to press
        Delete to disable its autocorrection without knowing about
        the special AutoCorrect patterns.
        
        Follow-up to commit 50be3fa1f0f3b8870af5bda88b65f835ef37d77e
        "tdf#141773 AutoCorrect: fix broken [All] dictionaries".
        
        Change-Id: I72be1ecb2fdc5ae67c72727ce7fbd70b28a4125b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169714
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-29  László Németh  <nemeth@numbertext.org>  [50be3fa1f0f3b8870af5bda88b65f835ef37d77e]

        tdf#141773 AutoCorrect: fix broken [All] dictionaries
        
        This reverts commit ae56dc05b27f05ffcee99845d661a237e70a7a51
        "tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used".
        
        Change-Id: Ifb4cf1b359b852c7610337d4bd389a8ca5dce610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169713
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-28  Jim Raykowski  <raykowj@gmail.com>  [3621ddfb9a490c58cfa70679d9bd89099a91e663]

        Resolves tdf#115665 Format in the CTRL+H search affects
        
        the CTRL+F search
        
        Change-Id: I51ccd2186c47a91958c262efac9a1514b9c3b138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169606
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [2cb5e2256c607acd766e8693ea22b62459d93cbc]

        Simplify solar.h a bit
        
        Use std::copy / std::reverse_copy for double serialization. Also
        remove __cplusplus conditions, because the header is not included
        in any C files. And simplify the functions uses, where casts were
        unneeded.
        
        Change-Id: I1d8375e601851231fdffcf52e3f3e3bdcbcbde7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169706
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aa80eaeeabd9424f7e09227940c2f8b6c817f07f]

        Fix "lets see" -> "let's see"
        
        Change-Id: I7aa939681720bc0dc81c8f114a3608a8cdfb4f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169722
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [16d58ad8d3423380aeb8588c50eaef10fc92c18d]

        Fix "lets" -> "let's"
        
        Change-Id: Ibe6cbbd618aab5c145913235dc90fec3c98cd504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169723
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [93987194f5dee2b917e32c18b8a377be95f0ab71]

        tdf#92029: sw_autocorrect: Add unittest
        
        Change-Id: I7ac855ac826353869c3a905ea70448d0c8dc1b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169711
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [6c949328650ccc8eeb149631a6368692dc08a309]

        tdf#158051: fix *σ’ -> σ’
        
        While writting a test for 7f593484a1f929663ec9ec7def76b63ec3a832b2
        "tdf#158051 AutoCorrect: don't apply final sigma before apostrophe"
        I realized the added rules where *σ’ -> ς’ ( which was the old behavior
        )
        instead of *σ’ -> σ’
        
        Change-Id: Ibff92e74da3d353ba715025b244b614b7fb8f9fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169717
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-28  Miklos Vajna  <vmiklos@collabora.com>  [94094d86883ea78e3b09d1d237e9f1b757ec0136]

        oox, drawingml: use more bLineShape in Shape::createAndInsert()
        
        As suggested at
        <https://gerrit.libreoffice.org/c/core/+/169615/1#message-39aa9a1b288ff3a7459fc68c09d10c312efbaa33>.
        
        Change-Id: I72f9cc905f18a48dcae2cf4b96d4560ad0a6080b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169701
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b17171b949fed99c55c35bcb8203129c8fef41f1]

        improve lifecycle of SdrItemPool
        
        I ran into a problem where this global object would be destroyed and
        then resurrected during shutdown.
        Rather than make the existing code more complex, extend the existing
        vcl::DeleteOnDeinit code and re-use that here.
        
        Change-Id: Ib63739f57f489b1131111e9bab1db5fba7fd17bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-28  Michael Weghorn  <m.weghorn@posteo.de>  [802a10654151c00302bc7b7479673101f2d47b20]

        tdf#157009 android: Add missing subdir for Triple-T/F-Droid icon
        
        Even with
        
            commit 69189de8fa9a9d4973a4304a82780d32e79fbe6f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu May 16 09:26:44 2024 +0200
        
                tdf#157009 android: Add icon symlink for F-Droid
        
        (and its 24-2 backport) in place, the icon is not shown
        for LibreOffice Viewer in the F-Droid app and on the repo
        website [1].
        
        Revisiting the related specs [2] [3], it turns out
        that the icon needs to be in an "icon" subdir in the
        "graphics" directory, so add that missing "icon" subdir
        and move the symlink there.
        
        From [2]:
        
        > └── listings
        >     ├── en-US                           (en-US is the default locale in F-Droid)
        >     │   ├── title.txt                   (app name)
        >     │   ├── short-description.txt       (short description, max 80 chars, mandatory)
        >     │   ├── full-description.txt        (full app description, mandatory)
        >     │   ├── video-url.txt               (URL to a video introducing the app)
        >     │   ├── whatsnew                    (alternative changelog location; single file, no .txt)
        >     │   └── graphics
        >     │       ├── icon                    (app icon; mandatory if your app doesn't include any png icon)
        >     │       │   └── *.(png|jpg)         1 image, usually 512x512
        
        [1] https://f-droid.org/en/packages/org.documentfoundation.libreoffice/
        [2] https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#triple-t-structure
        [3] https://github.com/Triple-T/gradle-play-publisher?tab=readme-ov-file#uploading-graphic-based-listings
        
        Change-Id: I43c23040bf63a34f8f9648b45fab6c47a8816b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169700
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f60e65e196a9c3fe50c5ee2dd2058731b435bfc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8351b40030008eec294de3712fc1b67d99d00931
          - Organizer -> General in Help pages
            
            Change-Id: Ibe5a9e819138b964a5f7336f9d4a71c5d43dc1bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169683
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80715756c6bd44f24dd6270ccb646f690861901a]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/09d348eefc7d1367073ee4a95513b48f799700f0>
        "krb5: Update krb5-1.21.2.tar.gz to 1.21.3 (#294)"
        
        Change-Id: If99afd812eca43258398d79c1a7c009988d374e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [86f296e82b426364c9675f5c0fbecf7613e7d72b]

        use more ASSERT_CHANGE_REFCOUNTED_ITEM
        
        which did I not see when I did
            commit cb3c65fb706cb1c7c9224222fd16875e924a9759
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 27 19:24:28 2024 +0200
            assert when SfxObjectItems are modified while in a pool
        
        Change-Id: I16e2ee72eda4b3ca69f83eb70ad4f4b0a14748a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169696
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d900a952eb2267717797c7e91326a0ce3f222063]

        reduce number of SvxUnoShape listeners on SdrModel
        
        when we have a lot of shapes, the number of listeners attached to
        SdrModel becomes a serious bottleneck because of the number of
        broadcast/notify function calls.
        
        So
        (1) make SvxUnoShape listen to the SdrObject
        which achieves the same end, and reduces the bottleneck on the SdrModel.
        (2) repurpose the maAllIncarnatedObjects set, which tracks all
        objects linked to the SdrModel, so we can shut down the associated
        UNO shapes during ClearModel. There is no other good way of doing
        this, and if we don't do it, we get various use-after-free
        issues during shutdown.
        
        This takes the load time of a large DOCX with lots of shapes,
        from 35s to 17s on my machine.
        
        Change-Id: I34a6ac35c90de8b7103a7373aafe6e9607cc01c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169612
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c519de229627f3c6bb7736c810405b441c07f369]

        Fix autotext shortcut generation
        
        The first character was replaced with a number.
        
        Fallout from 1f93816dd5d75aca98f210017d0b58b7ef1d08da
        
        Change-Id: I3b9a39336d5f6f3c10c85231f86fd196a29e3644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169621
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-06-28  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [9fdb50763720a2970ebab39debf26010a8e6bc62]

        licence: Fix div tag and move License Statements
        
        Change-Id: I9547679d0749e1bf539867cb1038c78ef8dcae12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169586
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-28  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [5e143492320dac8cdf8b2956799ca366f3d8e72c]

        tdf#33603: fix notespane (side/tool)bar interactions
        
        Introduces OverridingShells that when set, makes the view
        act like the MainViewShell.
        
        The main use case is having more then one ViewShell in a
        single window, where context (toolbars, sidebars etc.) can
        jump in between different ViewShells.
        
        Uses OverridingShells to enable NotesPane to react
        ToolBarShells. Accessing the functionality of ToolBarShells
        without the previous hacks with slot forwarding.
        
        Change-Id: Icc9721d7f54097025bc9dc7ef7069aed856e6d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169658
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-06-28  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [a7d1a6f313b1ee73b8bd360a7dfb3f0fc56e64bf]

        languagetool show cURL errors with the interaction handler
        
        Only shows the error once for a given checkerURL.
        
        Change-Id: I1873dc09584df33162c93d9d133b12eb8dfede04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169518
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-06-28  Patrick Luby  <guibmacdev@gmail.com>  [2e87c644245751aea9f50faf16c4ca4d57b0c2f1]

        tdf#159680 fix memory leak of CTFontRef
        
        The CTFontRef in CoreTextFontFace::GetVariations() was never
        released and a new CTFontRef was allocated in every call to
        CoreTextFontFace::GetVariations(). So release the CTFontRef
        and only allocate it once when mxVariations is populated.
        
        Change-Id: I08999956501d5860fff67e48001ef85a62ca8079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169690
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2fd72ed9cb8bb1fd7c5402194ac36e43fc2c0963]

        makefile simplification: cleanup template packaging mess
        
        the tmplate packaging code was full of copy'n'paste code with little
        understanding on how the rules actually work/what the statements
        actually do. (e.g. using separate calls to addprefix can be a matter
        of taste, but adding the call to get the extra files each time is
        pointless and just adds the same set of files multiple times).
        
        Unifying the fixed list of files and standardizing the base path for the
        relative filenames further allows to streamline the recipes
        
        Change-Id: I814fdb6f6534a9d5046281c45b6da87110f2093e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169342
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-28  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [2ad7d5cfb0288559921b0d9ccad0a23d95cde452]

        make additionsdialog show connection errors
        
        use non-scoped interaction handler instead of the scoped
        SimpleFileAccessInteraction so that errors will be handled
        with correct pop-up dialogs.
        
        Also throw the correct type of DAVException for
        USC_CONNECT_FAILED in Content::Open
        
        Change-Id: If2031dfa2796f91fad6866bc9608194c92658b96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169519
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [93dbba5361b2fd4b4b9a62725edab5e59b8be575]

        Update git submodules
        
        * Update translations from branch 'master'
          to b87971d7ac97460271cb13bd0e4cb2e554654a45
          - update translations for 24.8/master
            
            and force-fix errors using pocheck
            
            Change-Id: I512d2cb5e312ef9dcec6426c13ad33d10441b017
            
2024-06-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [50b982570efec6bbbd805f906729280365cb0857]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c187e488710f930d4d0ec5291308af2e3776a46
          - Fix broken links on Insert Table Help pages
            
            + refactor of the files
            
            Change-Id: I60dbaf848250abefc80272b5885ad01536cc218f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169652
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-28  Miklos Vajna  <vmiklos@collabora.com>  [b3e01bd3bdd37961057026ab7f2b57cbfab35d4a]

        Related: tdf#161708 sw content controls: fix custom default of dropdown to PDF
        
        Export the bugdoc to PDF without noticing that there is a content
        control around some of the content and notice how the PDF export lacks
        some words from the body text.
        
        What happens is that content controls are exported to PDF as PDF forms
        by default, and the selected option of a dropdown has to be an index, so
        in case the text of the dropdown content control is not one of the
        options, then the PDF will miss those words.
        
        Fix the problem by inserting the text of the dropdown at the start if
        there would be no valid index for it.
        
        Also add a bit of padding around the rectangle of the content controls,
        it turns out there is a default 1pt border in PDF, and this would lead
        to a cut-off text at the end if we don't compensate for that border.
        
        Change-Id: I99447894b320b42ad9ffe0d54d0190000621616b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169694
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [912c55537b11331e030d915e5857bccf182c9087]

        item-specific instance managers for SwFormatFrameSize and SwFormatVertOrient
        
        and add some asserts to catch if we modify these things when they inside
        a pool, which now that they are in hash-based container, will cause
        trouble.
        
        Change-Id: I2779f25cbcf056fbf71e417731d9b1f09ae33dd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169629
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb3c65fb706cb1c7c9224222fd16875e924a9759]

        assert when SfxObjectItems are modified while in a pool
        
        which has always been a problem, but becomes a more obvious problem when
        I implement some upcoming optimisations
        
        Change-Id: I8b0368b0b8e9a726c71d241841afeed3876281d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169657
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5b33bc443859d376efd578f070e3d3d81c93fd24]

        Fix typo
        
        Change-Id: I8a970902688bdece46774e73b76ee2bdeea3de57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169608
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0381750784107b28926180f6e67ca18c60e30384]

        Fix typos
        
        Change-Id: I0418baac572db21f3b87af6281572e61b983e11d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169689
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [390bfad2bb6389e7e25c6b63df0e0bc9a1949f75]

        Resave with newer Glade version
        
        Change-Id: If3fb270c17a32410fdd23ac37e46389c9cfdf56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169604
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [97833217ebacd77d01b8e06ee1eb05cc06c17afc]

        Resave with newer Glade version
        
        Change-Id: Iaa30a56068f7db4a735793d99e04f31054f8e17c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169426
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2668a9bb592fd7665087d6ea36abc10fcb8a852e]

        Resave with newer Glade version
        
        Change-Id: I7524659a266204a470f2fd407112a2d8fc47c99d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169422
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e9dd8d2311e6c40128f769dcc7477026dc59da23]

        Resave with newer Glade version
        
        Change-Id: Ic951f42f5a6dd7ab2d972a5ccc2d6e7fd3b5fa91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169596
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-28  Justin Luth  <jluth@mail.com>  [5c6c6a73e9c58ad934a4f89505d5b3e2b781e0b9]

        tdf#43767 mso-format layout: no smallcaps applied to numbering
        
        If the paragraph marker is formatted as Uppercase,
        then Uppercase is applied to that line's numbering as well.
        However, if the marker is formatted as SmallCaps,
        it MUST NOT be applied for MSO formats.
        
        Apparently MSO only supports Uppercase and SmallCaps,
        not Lowercase or Titlease.
        
        I don't like these adhoc exceptions, so I didn't
        attempt to apply them to ODF formats.
        Let's keep it simple for ODF - any char format that applies
        to the entire paragraph should apply to numbering as well
        (except for the existing underline/overline exceptions).
        - if you don't like that char attributes apply at all, blame MSO.
        - if you don't like that DOCX is missing your goofy formatting,
          blame MSO for being inconsistent.
        
        ooxmlexport12's tdf143384_tableInFoot_negativeMargins.docx
        is almost interesting because it applies superscript
        and small caps. However, the list is already uppercase,
        so it can't be used for the test.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf43767_caseMapNumbering
        
        Change-Id: I273baebc996adfd001e1c591dbb9aef9272a42f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169476
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-27  László Németh  <nemeth@numbertext.org>  [8fc2fd284bca88d491ff5975a7110c188344976b]

        tdf#92029 AutoCorrect: correct 's and 't in Dutch to apostrophe
        
        “In Dutch (in Belgium as in the Netherlands), when you type "'s"
        or "'t" in sentences like: "Ik ben 's morgens opgestaan", the
        apostrophe is changed into an opening quote by the autocorrect
        feature, which is incorrect and requires a manual correction.”
        
        The bug reported with the suggested AutoCorrect extension
        by Pierre François. The difference here is always to use the
        de facto standard typographic apostrophe in the replacement.
        
        Change-Id: I2ede612f72145abcca2bc1477ffae3cabc9e5641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169645
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-06-27  Patrick Luby  <guibmacdev@gmail.com>  [1ac602f6ccd75f3b79d6c7a9d40e64677dd5741a]

        tdf#161498 use COL_ALPHA_OPAQUE for finding opaque pixels
        
        Starting with commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
        pixels now contain an alpha value instead of a transparency
        value.
        
        Change-Id: I07dd39859057bbbbd153a21ee38625049039b106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-27  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [df61a5846197a01c10322ac54731b6df7e0faf07]

        tdf#157019 PPTX import: Workaround for object placeholder shape preset
        
        Follow-up to commit Ic8a8ab3f6dfb7367ecd2c619ce888bf77abef460
        "tdf#132557: PPTX import: Workaround for slide footer shape presets"
        
        note:
        This is a workaround because there is no custom shape support for
        placeholder shapes in LibreOffice.
        
        Change-Id: Iefb9d97e0eb10a04c39b515b11e549aeb7be8f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169626
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [a337a6ed162826f95cf52b88241d45c2b392d751]

        warning C6011: Dereferencing NULL pointer 'sNewPath'
        
         C:\lo\build\instdir\sdk\include\LibreOfficeKit\LibreOfficeKitInit.h(161) : warning C6011:
         Dereferencing NULL pointer 'sNewPath'. : Lines: 136, 137, 138, 140, 143, 144, 157, 159, 160, 161
        
        Change-Id: I0fba0db79b4a36f293e867da262a970eb152e3d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169651
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [589bce37764d4e539a3c3ebf37fdd039be30bd51]

        avoid OUString temporary
        
        in a hotspot
        
        Change-Id: I9fc3abc90c73e17b82fc7a4b197a91557c2ac6f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169610
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-27  László Németh  <nemeth@numbertext.org>  [7f593484a1f929663ec9ec7def76b63ec3a832b2]

        tdf#158051 AutoCorrect: don't apply final sigma before apostrophe
        
        Don't change Greek sigma with final sigma, if the sigma is
        followed by an apostrophe, which means removed word part (vowel)
        here.
        
        Follow-up to commit 5ecc0cad3f0aeb1c7643fae7b414b1a2316ed59f
        "tdf#116387 Autocorrect greek character σ (sigma) to ς (final sigma)".
        
        Change-Id: I6b7045502c04993cbad92f21f96ca5799abd1fd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169637
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-27  RMZeroFour  <ritobroto04@gmail.com>  [dd13569254e832d48bcdc7e612aaa1d7909708b0]

        .NET Bindings: Remove absolute path check in DotnetLibrary
        
        This commit removes the gb_DotnetLibrary__ensure_absolute gbuild
        function that was breaking out-of-source directory builds.
        
        Code using that function was changed to accept already absolute paths
        as arguments.
        
        Change-Id: I6d9d3dac33e296cf0e69910f16564d822047857e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169353
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f5f5ff719f30fccd207e36627f2e42b34d0a6fb1]

        Related: tdf#127293 Ignore 'search-criteria-must-apply-to-whole-cell'
        
        dependency for XLOOKUP and XMATCH because of better compatibility.
        
        The idea is to specify, that the global setting 'search-criteria-must-apply-to-whole-cell'
        is ignored and XMATCH and XLOOKUP always behaves as if 'search-criteria-must-apply-to-whole-cell'=true.
        
        That would affect exact search in Match_mode value 0. Users would need to use wildcard or regex
        to get a match to part of the content. But removing dependency to the global setting increases
        interoperability with MS Excel.
        
        Also the ODF TC will follow that in the final specification of these functions:
        https://issues.oasis-open.org/browse/OFFICE-4154
        
        Follow-up commit: 17d578ba91f9c78a0e41d19b58183d2214c0b7a4
        (Related: tdf#127293 Add new Match_mode option for XLOOKUP and XMATCH functions.)
        
        Change-Id: I1317865631d2925eaff72e9c1425d93386c3d016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169582
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins

2024-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e3d865274ba8628b29872bb533fcf257279c6fb6]

        annot: rename testAnnotationUpdate and add comments
        
        testAnnotationUpdate is not specific, so rename the test name to
        testAnnotationPositionUpdate.
        
        Change-Id: I1608025143455ad789cf2cce84b80e8b8b6b2e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169641
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [16d8f37cae3e6b68e4c41fbbacd94f48c3e304ab]

        tdf#159777 - A11Y sidebar: Add warning about ParaTopMargin
        
        and ParaBottomMargin direct formats.
        
        Change-Id: Ifac19eba9d3c2e3631ebede1a5f9f172bbaf8927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169541
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [189aed797b52284aad5777788218742f65e64ee3]

        use ESelection::NoSelection() instead of manually setting values
        
        Change-Id: I65f378d0178c0fcd209dc629f49befacfce02de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169640
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5173341825ffb3f97462d2485c909e8fd45f8daa]

        tdf#159925 - A11Y sidebar: Check for missing hyperlink name
        
        Check if the hyperlink have missing name and add a fix button
        to fix the warning.
        
        Change-Id: I3a69490aa81cf0ed9d0edb04eaa3401e4b47eb7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169508
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-27  László Németh  <nemeth@numbertext.org>  [2b9fee5a3e9d1eae65932fb0f08f0216f8a30cf7]

        tdf#161737 i18npool: fix bad word selection with NNBSP
        
        Fix word breaking rules also for editing. Previously
        the word was selected with the following narrow no-break
        space, e.g. at French words before exclamation and question
        marks (where narrow no-break space allows to get correct
        typography, if the OpenType/Graphite font doesn't have
        this feature).
        
        Add this and the previous fixes for Hungarian, which
        handled by extra word-breaking rule files.
        
        Follow-up to commit 6e002da1615b52cda4e9331e87878458b1fe9677
        "tdf#161737 i18npool: fix fake spelling alarms with NNBSP".
        
        Change-Id: I7230bd356e5f0360172b652e615a61d96131d336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169624
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-27  László Németh  <nemeth@numbertext.org>  [6e002da1615b52cda4e9331e87878458b1fe9677]

        tdf#161737 i18npool: fix fake spelling alarms with NNBSP
        
        Fix word break by excluding narrow no-break space at the
        end of the words for spell checking.
        
        This was a problem e.g. for French, where (automatically? or
        manually) inserted narrow no-break space is used to get correct
        typography before exclamation and question marks, also after and
        before guillemets, if the OpenType/Graphite font doesn't have this
        feature).
        
        Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700
        "tdf#49885 BreakIterator rule upgrades".
        
        Note: this fixes also the problem, when digits separated
        by NNBSP thousand separator weren't handled by spell checking,
        alarming fake spelling mistakes, when "Check words with numbers"
        was enabled in Tools->Options->Languages and Locales->Writing Aids.
        (TODO: at the case of thousand separators, remove NBSP by the
        linguistic module or by the spell checking dictionaries to allow
        to check numbers with thousand separators and with correct suffix.)
        
        Change-Id: I36e10add7e0ba840f207a375ccc8668dbfef9572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169618
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-27  Miklos Vajna  <vmiklos@collabora.com>  [274ecfa4e27f0d4198c1d351c285d3dfc2cdd075]

        sw: simplify SwShellCursor::Show()
        
        If we carefully dereference the shell and its sfx view shell, then no
        need to do this again, as pointed out at
        <https://gerrit.libreoffice.org/c/core/+/169509/2#message-087d761946aeeb8e6a25ed46dafa10adc5dacc67>.
        
        Change-Id: I4da444d1f4001849c7fe70ac0acd5e8af26b3415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169636
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [374a76adc567ad9fe4fa09099f7038c0f388a28e]

        vcl: Remove graph. reader context from {Imp}Graph and GraphicReader
        
        This removes the mpContext member variable from ImpGraph, which
        also make {Get,Set}ReaderContext on Graphic obsolete and is also
        removed. GraphicFilter and other code is adjusted and simplified.
        
        Change-Id: Icd1927d7b1bd4624b523d0f49a4343911ec6cd0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165214
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0acac1a2741d47b98ae600800e2db0e7a5fb3efe]

        xlsx: Don't export notes author when in privacy mode
        
        Change-Id: Id0b3f0aca7bd4e21f41c2a8307964423debcf5bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169616
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9d0d9d8aa0ba4bb465e376621b426fb9ff00507e]

        xlsx: Don't export changes author/date when in privacy mode
        
        Change-Id: I1b1ef4dd75f02cc545721d5458617cfa92b26615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169453
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a9b53bb9f85c2869c779dde36a2d77353fef14b]

        tdf#160345 Slow rendering of filled polygon
        
        Partial fix of this problem.
        The tiled image is a single pixel big, so we can do a solid color fill.
        Ideally vcl needs to pass the operation down to skia/cairo and let those
        layers do the tiling.
        
        Change-Id: Ifcb1d1a71f0b23b772bbacf1b1e2b15ea315f578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169619
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [534b8f6d8a7cc0bb98c243c8086ed0c81f87901d]

        reduce boilerplate code for type-specific ItemInstanceManagers
        
        create a template class to reduce repetition
        
        Change-Id: I8c9c71fdfdac20a3b34432affac07aa1d46e8373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169613
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-27  László Németh  <nemeth@numbertext.org>  [3a02490e1a04c32e18ce5bad5f3c3cb70501a7a4]

        tdf#138258 i18npool: allow ASCII double quote to match typographic quote
        
        Similar to the straight (typewriter or ASCII) apostrophe, straight
        double quotation mark (") matches its typographic variants now,
        like other word processors do.
        
        Note: regex search doesn't use this matching, similar to the apostrophe
        search.
        
        Follow-up to commit d40f2d02df26e216f367b5da3f9546b73f250469
        "tdf#117643 Writer: fix apostrophe search regression".
        
        Change-Id: If6a3ee00750828583cd0cfc4aa7f7b656ea9bd1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169605
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-27  Miklos Vajna  <vmiklos@collabora.com>  [8bc8f073e81d125a8e8f1adce966ddb2c7d6bacb]

        Related: tdf#161652 sw, RTF paste: avoid duplicated numbering styles
        
        Open the DOCX bugdoc from
        <https://bugs.documentfoundation.org/show_bug.cgi?id=161652#c6>,
        select-all, copy, open a second document, paste as RTF, paste as RTF
        again, the number of char styles in the document change from 27 to 55,
        then to 73. That is surprising, paragraph styles work by first creating
        them then a 2nd paste just refers to them.
        
        It seems what happens is that paragraph styles are handled in
        StyleSheetTable::ApplyStyleSheetsImpl(), and we have an explicit "When
        pasting, don't update existing styles" code there; on the other hand
        ListDef::GetStyleName() solves the style name collision by appending
        enough "a" characters at the end of the style name till there is no
        collision.
        
        Fix the inconsistency by adapting the list style behavior to match what
        paragraph styles do: if we don't open an RTF file but paste into an
        existing document, then try to use the existing style on collision.
        
        Fixing this on the RTF producing side would be less effective, also one
        could argue that in case a numbering uses e.g. 3 levels, then it still
        makes sense to emit the definition for all levels to help the editor
        once numbering levels are increased in the pasted content.
        
        Change-Id: Ia211cb4300c3c41dae8c815ddfaf30cc2f0de8b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169609
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5292ef333b0fa935b76f88808485b8dfc8b41a88]

        Resave with newer Glade version
        
        Change-Id: I258621ed37dd79e1254ebaa98a76964be6a98c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169403
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-27  AungKhantOo  <wildgugu2020@gmail.com>  [9d9cd7804919c518ed12875a81f520bee878d737]

        tdf#159380 Add an UNO command to close all documents
        
        Add an UNO command which closes the documents and also prompts the user to save while
        closing unsaved documents.
        
        This command also open the start center after all the documents are successfully closed.
        
        Change-Id: I9c502cfa2e550c6f60fa8867fb42e36aded65999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166041
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-27  Moritz Duge  <moritz.duge@allotropia.de>  [c8f72c2a3a7b347c54089d96b0794b4586022688]

        Improve documentation on key and mouse handlers and listeners.
        
        Change-Id: I443fd0c53f1fb11df3b4e13806771c2c649cae23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169473
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-06-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c983881b821f10b081336129ce547435b45d1704]

        Resave with newer Glade version
        
        Change-Id: Id30a7872e3f0d2689f77ece82d138696e3249882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169560
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [315960e7bb7acd3bdd5fe570de06624120e32f18]

        vcl: remove partial JPEG image loading
        
        Change-Id: Ibacf2c0eac963cdaf233f2af3f2277bc2b79c590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165213
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b27f0eb5858a4fd296170fb7e4533e5fc7aa3e9]

        libxml2: upgrade to 2.13.1
        
        Building with --without-system-libxml fails with
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPScanProxy'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPClose'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPReturnCode'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPRead'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPCleanup'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPMethod'
        /usr/bin/ld: /home/xisco/libreoffice/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so: undefined reference to `xmlNanoHTTPInit'
        collect2: error: ld returned 1 exit status
        
        so use --without-www in external/redland/ExternalProject_raptor.mk
        since it seems no to be used by raptor.
        Libxml2 disabled http support by default in
        https://gitlab.gnome.org/GNOME/libxml2/-/commit/3018842c07e9b88d6bb0257f5644e7695cdeb2e2
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.13/libxml2-2.13.1.tar.xz
        
        Kudos to Michael Weghorn for helping me with this patch
        
        Change-Id: I2e41021e8aea3551eb9eec29cf12f6cd9f6ff89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169327
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [f8ade4e11d49f6c32146254aa7f8d024c3798321]

        Resave with newer Glade version
        
        Change-Id: Iee7c65b65d545224fe4518e9c91d97dc3352eef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169504
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ccf633ea0ae00afa1f2dad3eaf1f9049a5603513]

        Resave with newer Glade version
        
        Change-Id: Ia53a3474107874d5b97156e8bc9a971db7a1e21a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169545
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Julien Nabet  <serval2412@yahoo.fr>  [3c91fb758a429f51b89dfe9cea088691ced6d0c1]

        tdf#161786: fix Math crash when typing "oper"
        
        Change-Id: I8332e87e703f9138b8d13985b8697ad4b9f2191e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169539
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d0ba0badeb5a83d8eb5373ba5d7ef931dcf62c9]

        reduce number of SvxTextEditSourceImpl listeners on SdrModel
        
        when we have a lot of shapes, the number of listeners attached to
        SdrModel becomes a serious bottleneck because of the number of
        broadcast/notify function calls.
        
        But SvxTextEditSourceImpl can just as well listen to the SdrObject,
        which achieves the same end, and reduces the bottleneck on the SdrModel.
        
        We do have to adjust some of the broadcast sites to broadcast the
        event to the SdrObject listeners as well as the SdrModel listeners.
        Possibly as another change we can remove the broadcasting to the
        SdrModel listeners.
        
        This shaves 10% off the load time of a large DOCX with lots of shapes.
        
        Noting that we do no need to listen to SdrHintKind::ModelCleared because
        we will get called via SvxTextEditSourceImpl::ObjectInDestruction when
        the model is destroyed.
        
        Change-Id: I3f7f6aa2a2146e4c4f59c974aa3fed92becf5eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-26  Michael Stahl  <michael.stahl@allotropia.de>  [68e7413b5f9ce4abd2a4e23bf27cfc335e52f03f]

        tdf#156724 sw: layout: ignore footnotes when splitting float table row
        
        (regression from commit 534d3818aedfa95ad73935235462f5ec2817f5da)
        
        Change-Id: I169d88375a93c288604a89ef89f7e895830446c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169570
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-26  Michael Weghorn  <m.weghorn@posteo.de>  [879bcc88759d7dd033e0ee667daee0d2a743cf06]

        tdf#159835 sfx2: Skip sidebar menu update for gtk4 to work around crash
        
        After
        
            commit daed96f0818b1baae5de8b74b866009d7d89f853
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jun 19 13:08:34 2024 +0200
        
                tdf#159835 sfx2: Keep sidebar menu up to date
        
        , starting LO Writer with the gtk4 VCL plugin resulted
        in a crash (backtrace below) due to the current menu
        implementation for the gtk4 VCL plugin being
        incomplete/broken.
        
        For now, until the underlying issue has been fixed,
        at least avoid crashing by skipping the menu update
        when using gtk4.
        
        This effectively reverts back to the old behavior
        for gtk4, where before the above commit,
        `mxMenuButton->get_active()` in `TabBar::OnToolboxClicked`
        would always return false when clicking the menu button
        in the sidebar, so the code path triggering the crash
        wouldn't be hit, thus not triggering the
        pre-existing underlying issue.
        
        Backtrace of the crash:
        
            Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
            0x00007fffe9d25afe in g_atomic_ref_count_inc () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #0  0x00007fffe9d25afe in g_atomic_ref_count_inc () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #1  0x00007fffe9cfb3b6 in g_hash_table_ref () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #2  0x00007fffe90ff92e in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #3  0x00007fffe90feaf4 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #4  0x00007fffe90fef2c in g_menu_model_get_item_attribute () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #5  0x00007fffe44fd500 in (anonymous namespace)::MenuHelper::get_item_id(int) const (this=0x55555c78dbf0, pos=0) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:5748
            #6  0x00007fffe44fc976 in (anonymous namespace)::GtkInstanceMenu::get_id(int) const (this=0x55555c78dbf0, pos=0) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:11711
            #7  0x00007fffe44fcd40 in virtual thunk to (anonymous namespace)::GtkInstanceMenu::get_id(int) const () at vcl/unx/gtk4/../gtk3/gtkinst.cxx:11745
            #8  0x00007ffff3fae52b in sfx2::sidebar::TabBar::UpdateMenus() (this=0x55555c7ce530) at .../libreoffice/sfx2/source/sidebar/TabBar.cxx:342
            #9  0x00007ffff3faf86a in sfx2::sidebar::TabBar::TabBar(vcl::Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, std::function<void (rtl::OUString const&)>, std::function<void (weld::Menu&, weld::Menu&)>, sfx2::sidebar::SidebarController&) (this=0x55555c7ce530, pParentWindow=0x55555c62cea0, rxFrame=..., aDeckActivationFunctor=..., aPopupMenuSignalConnectFunction=..., rParentSidebarController=...) at .../libreoffice/sfx2/source/sidebar/TabBar.cxx:76
            #10 0x00007ffff3f1c84d in VclPtr<sfx2::sidebar::TabBar>::Create<VclPtr<sfx2::sidebar::SidebarDockingWindow>&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*)::$_3, sfx2::sidebar::SidebarController::$_3(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*)::$_4, sfx2::sidebar::SidebarController&>(VclPtr<sfx2::sidebar::SidebarDockingWindow>&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*)::$_3&&, sfx2::sidebar::SidebarController::$_3(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*)::$_4&&, sfx2::sidebar::SidebarController&) (arg=..., arg=..., arg=..., arg=..., arg=...) at include/vcl/vclptr.hxx:129
            #11 0x00007ffff3f1cc86 in sfx2::sidebar::SidebarController::SidebarController(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*) (this=0x55555c6f1fc0, pParentWindow=0x55555c62cea0, pViewFrame=0x55555abb87a0) at .../libreoffice/sfx2/source/sidebar/SidebarController.cxx:119
            #12 0x00007ffff3f1d59f in sfx2::sidebar::SidebarController::create(sfx2::sidebar::SidebarDockingWindow*, SfxViewFrame const*) (pParentWindow=0x55555c62cea0, pViewFrame=0x55555abb87a0) at .../libreoffice/sfx2/source/sidebar/SidebarController.cxx:147
            #13 0x00007ffff3f1a997 in sfx2::sidebar::SidebarDockingWindow::GetOrCreateSidebarController() (this=0x55555c62cea0) at .../libreoffice/sfx2/source/sidebar/SidebarDockingWindow.cxx:64
            #14 0x00007ffff3f1ac24 in sfx2::sidebar::SidebarDockingWindow::SidebarDockingWindow(SfxBindings*, sfx2::sidebar::SidebarChildWindow&, vcl::Window*, long) (this=0x55555c62cea0, pSfxBindings=0x55555abdafe0, rChildWindow=..., pParentWindow=0x55555abdb6a0, nBits=137975825761) at .../libreoffice/sfx2/source/sidebar/SidebarDockingWindow.cxx:55
            #15 0x00007ffff3f19e79 in VclPtr<sfx2::sidebar::SidebarDockingWindow>::Create<SfxBindings*&, sfx2::sidebar::SidebarChildWindow&, vcl::Window*&, long>(SfxBindings*&, sfx2::sidebar::SidebarChildWindow&, vcl::Window*&, long&&) (arg=@0x7fffffff45f8: 0x55555abdafe0, arg=..., arg=@0x7fffffff4600: 0x55555abdb6a0, arg=@0x7fffffff45e8: 137975825761) at include/vcl/vclptr.hxx:129
            #16 0x00007ffff3f1960e in sfx2::sidebar::SidebarChildWindow::SidebarChildWindow(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*) (this=0x55555c7d3130, pParentWindow=0x55555abdb6a0, nId=10336, pBindings=0x55555abdafe0, pInfo=0x7fffffff4878) at .../libreoffice/sfx2/source/sidebar/SidebarChildWindow.cxx:36
            #17 0x00007ffff3f19d0c in std::make_unique<sfx2::sidebar::SidebarChildWindow, vcl::Window*&, unsigned short&, SfxBindings*&, SfxChildWinInfo*&>(vcl::Window*&, unsigned short&, SfxBindings*&, SfxChildWinInfo*&) (__args=@0x7fffffff46c0: 0x55555abdb6a0, __args=@0x7fffffff46be: 10336, __args=@0x7fffffff46b0: 0x55555abdafe0, __args=@0x7fffffff46a8: 0x7fffffff4878) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:1070
            #18 0x00007ffff3f19344 in sfx2::sidebar::SidebarChildWindow::CreateImpl(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*) (pParent=0x55555abdb6a0, nId=10336, pBindings=0x55555abdafe0, pInfo=0x7fffffff4878) at .../libreoffice/sfx2/source/sidebar/SidebarChildWindow.cxx:30
            #19 0x00007ffff38b2b4b in SfxChildWindow::CreateChildWindow(unsigned short, vcl::Window*, SfxBindings*, SfxChildWinInfo&) (nId=10336, pParent=0x55555abdb6a0, pBindings=0x55555abdafe0, rInfo=...) at .../libreoffice/sfx2/source/appl/childwin.cxx:241
            #20 0x00007ffff39592dd in SfxWorkWindow::CreateChildWin_Impl(SfxChildWin_Impl*, bool) (this=0x555556828e50, pCW=0x55555c4e3a00, bSetFocus=false) at .../libreoffice/sfx2/source/appl/workwin.cxx:1351
            #21 0x00007ffff3958fdc in SfxWorkWindow::UpdateChildWindows_Impl() (this=0x555556828e50) at .../libreoffice/sfx2/source/appl/workwin.cxx:1300
            #22 0x00007ffff39584da in SfxWorkWindow::UpdateObjectBars_Impl2() (this=0x555556828e50) at .../libreoffice/sfx2/source/appl/workwin.cxx:1248
            #23 0x00007ffff3957a0b in SfxWorkWindow::UpdateObjectBars_Impl() (this=0x555556828e50) at .../libreoffice/sfx2/source/appl/workwin.cxx:1096
            #24 0x00007ffff39cbeb5 in SfxDispatcher::Update_Impl(bool) (this=0x55555abd9fc0, bForce=false) at .../libreoffice/sfx2/source/control/dispatch.cxx:1122
            #25 0x00007ffff4059a69 in SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame) (this=0x55555ac3f8b0, i_eConnect=SfxBaseController::E_CONNECT) at .../libreoffice/sfx2/source/view/sfxbasecontroller.cxx:1206
            #26 0x00007ffff4058aac in SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) (this=0x55555ac3f8b0, xFrame=...) at .../libreoffice/sfx2/source/view/sfxbasecontroller.cxx:530
        
        Change-Id: I9c04b4faff4da084bfa8f932d9f95a233bc1f528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169534
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [750a77bf3df5813c6b7ca7ca38cf4f41474a7395]

        simplify logic in DoTextBoxZOrderCorrection
        
        which is doing things in an unnecessarily complex way.
        
        The simpler way makes a complex DOCX file load 20% faster
        
        Change-Id: I507e2bfd5e315f50e4fa790711286785e0f11445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169529
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [d20cdbf9b6482e2ee8edc1fd7d5e4d79468f77bd]

        svgio: Add missing 'rebeccapurple' color
        
        you can find more about the sad story behind this color
        in the internet
        
        Change-Id: I0aa201bdc62aebe96f0ae764a359f1f6286027d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169544
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-26  Michael Stahl  <michael.stahl@allotropia.de>  [3e845b10be7ae7f2ac91e37fe6404dd390aaa49d]

        tdf#161718 sw: fix background flys blocking footnotes
        
        The problem is that the document has an unwanted page break on the
        paragraph with the footnote.
        
        The reason is that lcl_GetFootnoteLower() tries to evade flys, but
        doesn't take into account that background flys (Wrap Through) should be
        ignored.
        
        (somehow regression from commit c303981cfd95ce1c3881366023d5495ae2edce97)
        
        Change-Id: I02578f14644e232fac127142fe12801101f87f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169530
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d44784a24a8ff2a6f92618585b786192ef55a6ab]

        Missing includes
        
        Change-Id: I519cdb9b5a1c475a1d36293b77c85c250baf3c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169520
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-26  Miklos Vajna  <vmiklos@collabora.com>  [fba0193fcfb250d931c54baab2d1b79ce4be2f12]

        sw: fix crash in SwShellCursor::Show()
        
        Crashreport signature:
        
        > Fatal signal received: SIGSEGV code: 1 for address: 0x0
        > program/libswlo.so
        >       SwShellCursor::Show(SfxViewShell const*)
        >               sw/source/core/crsr/viscrs.cxx:991
        > program/libswlo.so
        >       SwCursorShell::ShowCursors(bool)
        >               sw/source/core/crsr/crsrsh.cxx:2769
        > program/libswlo.so
        >       SwViewShell::ImplEndAction(bool)
        >               sw/source/core/view/viewsh.cxx:?
        > program/libswlo.so
        >       SwViewShell::EndAction(bool)
        >               sw/inc/viewsh.hxx:638
        
        (cherry picked from commit cefe556b9198b5dba18256d30ddcfcfda03f18c8)
        
        Change-Id: I31e453fae20957b906ff82f967dd97bb571d58d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169538
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-26  Miklos Vajna  <vmiklos@collabora.com>  [6c09c85ec384e88c89bff0817e7fe9889d7ed68e]

        tdf#161779 DOCX import, drawingML: fix handling of translation for lines
        
        Open the bugdoc, it has a line with a non-zero horizontal offset from
        the anchor paragraph, it shows up as a horizontal line, while it should
        be vertical.
        
        Checking how the ODT import and the DOCX import works for lines, one
        obvious difference is that the ODT import at
        SdXMLLineShapeContext::startFastElement() only considers the size /
        scaling for the individual points, everything else goes to the transform
        matrix of the containing shape, set in
        SdXMLShapeContext::SetTransformation(). The drawingML import is way more
        complex, but it effectively tries to not set any transformation on the
        shape and just transorms the points of the line instead.
        
        Fix the problem by changing Shape::createAndInsert() to also not put any
        scaling to the transform matrix, to not transform the points of the line
        and finally to apply the transform matrix to lines as well.
        
        Do this only for toplevel Writer lines, that's enough to fix the bugdoc
        and group shapes / Calc shapes need more investigation, so leave those
        unchanged for now. Tests which were failing while working on this
        change:
        - CppunitTest_sc_shapetest's testTdf144242_Line_noSwapWH: do this for
          Writer shapes only, for now
        - CppunitTest_sw_ooxmlimport's lineRotation: this is already broken
          partially, now looks perfect
        - CppunitTest_sw_ooxmlimport's testTdf85232 / group shape: this points
          out that lines in group shapes are some additional complexity, so
          leave that case unchanged, for now
        - CppunitTest_sw_ooxmlexport3's testArrowPosition: manual testing shows
          this is still OK
        - CppunitTest_sw_writerfilter_dmapper's testTdf141540GroupLinePosSize:
          manual testing shows this is still OK
        
        Change-Id: I246430148e3b3c927e010f360fa317e8429c82d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169533
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [ccb557636ea87a40d5fcc370b7434029c0153588]

        speed up complex doc with lots of footers/headers
        
        setting the header/footer property values is extremely expensive, so
        check before setting them.
        
        Shaves 30% off the load time of a large DOCX
        
        Change-Id: I7ac61434b8b4f59e199620dfcc11680164efe203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169532
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f07af61f6bc8c3e0a2d7be4afa0d1e3c0882d9f6]

        Fix translation
        
        Change-Id: Iedd595952eca24083068c33a5ec7391c125d2934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169524
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e8a241d1cb1abb30d6b1b76520f742f16311318b]

        Fix typo
        
        Change-Id: Id4ff56962a9a02dbd7d6a449cc26805b30ec271e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169531
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [32b295b7392c4a14def87e4fa0b9fa74f9441ffd]

        speed up DefaultItemInstanceManager
        
        we can store the registered items in a map indexed by which-id, and
        avoid most of the search cost
        
        Change-Id: Ib3fbed436bc034e603819cfef8223dcc77eb7f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-26  Michael Weghorn  <m.weghorn@posteo.de>  [085510962a4455f07d7be713adbb6084302c121e]

        gtk4 a11y: Handle when there's no a11y context
        
        Handle the case where `XAccessible::getAccessibleContext`
        returns an empty reference, as e.g.
        `VCLXWindow::getAccessibleContext` does when already
        disposed.
        
        Fixes an assert/crash seen with the gtk4 VCL plugin
        when experimenting with missing menu item handling
        in Writer's "Tools" -> "Bibliography Database",
        expanding the search filter menu, then closing the dialog
        and LO altogether.
        
        Backtrace:
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (rr) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007fe8f96a6b6f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007fe8f96584e2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007fe8f96414ed in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fe8f9641415 in __assert_fail_base
                (fmt=0x7fe8f97b7ba8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7fe8e5f1ba3a "_pInterface != NULL", file=file@entry=0x7fe8e5f46536 ".../libreoffice/include/com/sun/star/uno/Reference.h", line=line@entry=387, function=function@entry=0x7fe8e5f41e71 "interface_type *com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::operator->() const [interface_type = com::sun::star::accessibility::XAccessibleContext]") at ./assert/assert.c:92
            #5  0x00007fe8f9651002 in __assert_fail
                (assertion=0x7fe8e5f1ba3a "_pInterface != NULL", file=0x7fe8e5f46536 ".../libreoffice/include/com/sun/star/uno/Reference.h", line=387, function=0x7fe8e5f41e71 "interface_type *com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::operator->() const [interface_type = com::sun::star::accessibility::XAccessibleContext]") at ./assert/assert.c:101
            #6  0x00007fe8e6034e42 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::operator->() const (this=0x7ffe3fddc640) at include/com/sun/star/uno/Reference.h:387
            #7  0x00007fe8e6038c14 in map_accessible_role(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&) (rAccessible=uno::Reference to (VCLXWindow *) 0x5603d155bba8)
                at .../libreoffice/vcl/unx/gtk4/a11y.cxx:56
            #8  0x00007fe8e6038a16 in lo_accessible_get_property(_GObject*, unsigned int, _GValue*, _GParamSpec*) (object=0x5603e5e9fde0, property_id=2, value=0x7ffe3fddca00, pspec=0x5603bfdc1820)
                at .../libreoffice/vcl/unx/gtk4/a11y.cxx:559
            #9  0x00007fe8f47be345 in g_object_get_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #10 0x00007fe8f47be8b7 in g_object_get () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #11 0x00007fe8e54d81f8 in gtk_accessible_get_accessible_role (self=self@entry=0x5603e5e9fde0) at ../gtk/gtkaccessible.c:296
            #12 0x00007fe8e54d9447 in gtk_accessible_should_present (self=self@entry=0x5603e5e9fde0) at ../gtk/gtkaccessible.c:1304
            #13 0x00007fe8e575dab8 in get_index_in (parent=parent@entry=0x5603e4203030, child=child@entry=0x5603e5ea13a0) at ../gtk/a11y/gtkatspicontext.c:398
            #14 0x00007fe8e5760213 in gtk_at_spi_context_child_change (ctx=0x5603e41f8670, change=GTK_ACCESSIBLE_CHILD_CHANGE_REMOVED, child=0x5603e5ea13a0) at ../gtk/a11y/gtkatspicontext.c:1260
            #15 0x00007fe8e575ed8f in gtk_at_spi_context_state_change
                (ctx=0x5603e5ea15a0, changed_states=GTK_ACCESSIBLE_STATE_CHANGE_HIDDEN, changed_properties=0, changed_relations=<optimized out>, states=0x5603e5ea1770, properties=0x5603e5ea16b0, relations=0x5603e5ea1710)
                at ../gtk/a11y/gtkatspicontext.c:979
            #16 0x00007fe8e54e2bdf in gtk_at_context_update (self=0x5603e5ea15a0) at ../gtk/gtkatcontext.c:831
            #17 0x00007fe8e54d839a in gtk_accessible_update_state (self=self@entry=0x5603e5ea13a0, first_state=first_state@entry=GTK_ACCESSIBLE_STATE_HIDDEN) at ../gtk/gtkaccessible.c:364
            #18 0x00007fe8e5684d4b in gtk_widget_unmap (widget=0x5603e5ea13a0) at ../gtk/gtkwidget.c:2895
            #19 gtk_widget_unmap (widget=0x5603e5ea13a0) at ../gtk/gtkwidget.c:2879
            #20 0x00007fe8e5684e25 in gtk_widget_real_hide (widget=0x5603e5ea13a0) at ../gtk/gtkwidget.c:2811
            #21 0x00007fe8f47b4939 in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #22 0x00007fe8f47ca33f in  () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #23 0x00007fe8f47cff06 in g_signal_emit_valist () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #24 0x00007fe8f47cffc3 in g_signal_emit () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #25 0x00007fe8e56872cd in gtk_widget_hide (widget=0x5603e5ea13a0) at ../gtk/gtkwidget.c:2787
            #26 0x00007fe8e61de10e in GtkSalObjectWidgetClip::Show(bool) (this=0x5603dafec8f0, bVisible=false) at vcl/unx/gtk4/../gtk3/gtkobject.cxx:534
            #27 0x00007fe8efc96b3d in vcl::Window::ImplSysObjClip(vcl::Region const*) (this=0x5603e5ebb940, pOldRegion=0x0) at .../libreoffice/vcl/source/window/clipping.cxx:352
            #28 0x00007fe8efc96fa0 in vcl::Window::ImplSetClipFlagChildren(bool) (this=0x5603e5ebb940, bSysObjOnlySmaller=false) at .../libreoffice/vcl/source/window/clipping.cxx:424
            #29 0x00007fe8efc97227 in vcl::Window::ImplSetClipFlag(bool) (this=0x5603e5ebb940, bSysObjOnlySmaller=false) at .../libreoffice/vcl/source/window/clipping.cxx:466
            #30 0x00007fe8eff2307b in vcl::Window::Show(bool, ShowFlags) (this=0x5603e5ebb940, bVisible=false, nFlags=ShowFlags::NONE) at .../libreoffice/vcl/source/window/window.cxx:2238
            #31 0x00007fe8efc6a189 in vcl::Window::Hide() (this=0x5603e5ebb940) at include/vcl/window.hxx:881
            #32 0x00007fe8efeac189 in SystemChildWindow::dispose() (this=0x5603e5ebb940) at .../libreoffice/vcl/source/window/syschild.cxx:121
            #33 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603e5ebb950) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #34 0x00007fe8e61ad349 in VclPtr<SystemChildWindow>::disposeAndClear() (this=0x5603e5ea49f0) at include/vcl/vclptr.hxx:207
            #35 0x00007fe8e60a30ca in (anonymous namespace)::GtkInstanceBuilder::~GtkInstanceBuilder() (this=0x5603e5ea4900) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:24349
            #36 0x00007fe8e60a3169 in (anonymous namespace)::GtkInstanceBuilder::~GtkInstanceBuilder() (this=0x5603e5ea4900) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:24342
            #37 0x00007fe8efe748cf in std::default_delete<weld::Builder>::operator()(weld::Builder*) const (this=0x5603e41d6730, __ptr=0x5603e5ea4900) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:99
            #38 0x00007fe8efe747fc in std::__uniq_ptr_impl<weld::Builder, std::default_delete<weld::Builder> >::reset(weld::Builder*) (this=0x5603e41d6730, __p=0x0)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:211
            #39 0x00007fe8efff1ffd in std::unique_ptr<weld::Builder, std::default_delete<weld::Builder> >::reset(weld::Builder*) (this=0x5603e41d6730, __p=0x0)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:509
            #40 0x00007fe8efff16b3 in InterimItemWindow::dispose() (this=0x5603e41d6660) at .../libreoffice/vcl/source/control/InterimItemWindow.cxx:49
            #41 0x00007fe8a6f57e51 in EditControl::dispose() (this=0x5603e41d6660) at .../libreoffice/extensions/source/bibliography/toolbar.cxx:209
            #42 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603e41d67b8) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #43 0x00007fe8a6f5d5f6 in VclPtr<EditControl>::disposeAndClear() (this=0x5603e5e8e9f0) at include/vcl/vclptr.hxx:207
            #44 0x00007fe8a6f5a13c in BibToolBar::dispose() (this=0x5603e5e8e580) at .../libreoffice/extensions/source/bibliography/toolbar.cxx:272
            #45 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603e5e8ea68) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #46 0x00007fe8a6edbf09 in VclPtr<BibToolBar>::disposeAndClear() (this=0x5603e06c1578) at include/vcl/vclptr.hxx:207
            #47 0x00007fe8a6edab2e in bib::BibBeamer::dispose() (this=0x5603e06c1340) at .../libreoffice/extensions/source/bibliography/bibbeam.cxx:205
            #48 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603e06c1588) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #49 0x00007fe8a6ef2b49 in VclPtr<vcl::Window>::disposeAndClear() (this=0x7ffe3fdddcb0) at include/vcl/vclptr.hxx:207
            #50 0x00007fe8a6ef173a in BibWindowContainer::dispose() (this=0x5603e70e5ed0) at .../libreoffice/extensions/source/bibliography/bibcont.cxx:81
            #51 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603e70e5ef8) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #52 0x00007fe8a6ef2b49 in VclPtr<vcl::Window>::disposeAndClear() (this=0x7ffe3fdddd90) at include/vcl/vclptr.hxx:207
            #53 0x00007fe8a6ef2043 in BibBookContainer::dispose() (this=0x5603de460610) at .../libreoffice/extensions/source/bibliography/bibcont.cxx:126
            #54 0x00007fe8f01cd7ca in VclReferenceBase::disposeOnce() (this=0x5603de460878) at .../libreoffice/vcl/source/outdev/vclreferencebase.cxx:38
            #55 0x00007fe8f1d624a9 in VclPtr<vcl::Window>::disposeAndClear() (this=0x7ffe3fddded8) at include/vcl/vclptr.hxx:207
            #56 0x00007fe8f1d52fe4 in VCLXWindow::dispose() (this=0x5603d155bb40) at .../libreoffice/toolkit/source/awt/vclxwindow.cxx:926
            #57 0x00007fe8f6c28644 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&)
                (this=0x5603e4174370, xComponentWindow=empty uno::Reference, xController=empty uno::Reference) at .../libreoffice/framework/source/services/frame.cxx:1525
            #58 0x00007fe8f6c2abc8 in (anonymous namespace)::XFrameImpl::close(unsigned char) (this=0x5603e4174370, bDeliverOwnership=0 '\000') at .../libreoffice/framework/source/services/frame.cxx:1707
            #59 0x00007fe8f6a3a23a in framework::pattern::frame::closeIt(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (xResource=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x5603e41743e0)
                at framework/source/inc/pattern/frame.hxx:57
            #60 0x00007fe8f6a38445 in framework::CloseDispatcher::implts_closeFrame() (this=0x5603e93410a0) at .../libreoffice/framework/source/dispatch/closedispatcher.cxx:500
            #61 0x00007fe8f6a37ab1 in framework::CloseDispatcher::impl_asyncCallback(LinkParamNone*) (this=0x5603e93410a0) at .../libreoffice/framework/source/dispatch/closedispatcher.cxx:379
            #62 0x00007fe8f6a35fed in framework::CloseDispatcher::LinkStubimpl_asyncCallback(void*, LinkParamNone*) (instance=0x5603e93410a0, data=0x0) at .../libreoffice/framework/source/dispatch/closedispatcher.cxx:246
            #63 0x00007fe8efc40828 in Link<LinkParamNone*, void>::Call(LinkParamNone*) const (this=0x5603eb162878, data=0x0) at include/tools/link.hxx:111
            #64 0x00007fe8f06cff25 in vcl::EventPoster::DoEvent_Impl(void*) (this=0x5603eb162870) at .../libreoffice/vcl/source/helper/evntpost.cxx:52
            #65 0x00007fe8f06cfedd in vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) (instance=0x5603eb162870, data=0x0) at .../libreoffice/vcl/source/helper/evntpost.cxx:48
            #66 0x00007fe8eff4ca78 in Link<void*, void>::Call(void*) const (this=0x5603dfaf31a8, data=0x0) at include/tools/link.hxx:111
            #67 0x00007fe8eff48759 in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x5603dfaf31a0) at .../libreoffice/vcl/source/window/winproc.cxx:2287
            #68 0x00007fe8eff45110 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x5603c9d5cf10, nEvent=SalEvent::UserEvent, pEvent=0x5603dfaf31a0)
                at .../libreoffice/vcl/source/window/winproc.cxx:2851
            #69 0x00007fe8f0bd5ba0 in SalFrame::CallCallback(SalEvent, void const*) const (this=0x5603cb949f00, nEvent=SalEvent::UserEvent, pEvent=0x5603dfaf31a0) at vcl/inc/salframe.hxx:312
            #70 0x00007fe8f0c0072f in SalGenericDisplay::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x5603bec36aa0, aEvent=...) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:66
            #71 0x00007fe8f06e433d in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7ffe3fddefd0) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119
            #72 0x00007fe8f06e41e4 in SalUserEventList::DispatchUserEvents(bool) (this=0x5603bec36aa0, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120
            #73 0x00007fe8f0c00685 in SalGenericDisplay::DispatchInternalEvent(bool) (this=0x5603bec36aa0, bHandleAllCurrentEvent=false) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:51
            #74 0x00007fe8e607b706 in call_userEventFn(void*) (data=0x5603beaa55d0) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:824
            #75 0x00007fe8ead1ce3f in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #76 0x00007fe8ead1eec7 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #77 0x00007fe8ead1f4e0 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #78 0x00007fe8e607a2bf in GtkSalData::Yield(bool, bool) (this=0x5603beaa55d0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
            #79 0x00007fe8e6080123 in GtkInstance::DoYield(bool, bool) (this=0x5603beaa5480, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:429
            #80 0x00007fe8f07c4d5c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:384
            #81 0x00007fe8f07c466b in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:472
            #82 0x00007fe8f07c4402 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:359
            #83 0x00007fe8f9926be0 in desktop::Desktop::Main() (this=0x7ffe3fde1018) at .../libreoffice/desktop/source/app/app.cxx:1652
            #84 0x00007fe8f07e796e in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229
            #85 0x00007fe8f07e9999 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261
            #86 0x00007fe8f99a9b2c in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:99
            #87 0x00005603bca36a5d in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #88 0x00005603bca36a37 in main (argc=2, argv=0x7ffe3fde1228) at .../libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Ia3f19d700de66c72f2896595a0e387bd3c42d7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169451
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-26  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [72aa32b3c5ed7bc739d7567bf607d767f195b651]

        licence: add zxing-cpp
        
        Change-Id: Ia347ea638cb1ccdc4f0a351509f010c3444a4c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169432
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2f3f1170a7ae8bb06c6cd66a8ba3eb85cc63c2ac]

        Resave with newer Glade version
        
        Change-Id: I8acca3d2c035fea8caf41b5d5072f5b27604568a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169417
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [00ba5eba45c8334170668621852c0b2b10b7661e]

        Resave with newer Glade version
        
        Change-Id: I2294ec1df9924d1406b2a9e5b1833dfb8471b154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169415
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [31267f0b04729a41619850f8eceb7232be8a4c7b]

        Resave with newer Glade version
        
        Change-Id: I39d580296f845460b7bef6f66fa97b99b36787a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169398
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2d5eafef0824ece762c460022f4a9dd7dccc3afb]

        Resave with newer Glade version
        
        Change-Id: I79863a21c54986c24ba437f4ce3c0d9ce7f8708c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169394
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6ee000dad6ee476b12dc9745f10b11c05b417967]

        Resave with newer Glade version
        
        Change-Id: I011102a87a3d8abce96a64d4be822377018f5df7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169396
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2a553c08102d7f0eba665b6686124898ac72135d]

        Resave with newer Glade version
        
        Change-Id: I8c955f20b4976178ac25d7590ff6cc0f37a10f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169393
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [656e0de5a0313d4e2ab90508fd7c00f31d005212]

        Resave with newer Glade version
        
        Change-Id: If14a6b528b1dc75ccb2ee6db81088426128c3d87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169395
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8edd336e92f1599032aa49ad6aeba098ab84a587]

        Resave with newer Glade version
        
        Change-Id: I143d715d8b5b8630f5153af525b83521555cabb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169378
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [baf3d52f7d9fd72345ce7c0b7aaaa8ecf9c7120c]

        Resave with newer Glade version
        
        Change-Id: Id58e4f779ed2ee3559cba744056e2e0be8cedd91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169388
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-26  Justin Luth  <jluth@mail.com>  [9c1a48f844eaefc505a5914338b6f444011bf315]

        NFC edundo.cxx: remove unused bRet
        
        Orphaned with commit 20e5f64215853bdd32c5f16394ba7f2f36745904
        Author: Noel Grandin on Fri Jan 19 14:40:12 2018 +0200
        loplugin:unused-returns in sw
            Reviewed-on: https://gerrit.libreoffice.org/48189
        
        Interestingly, Noel removed bRet from ::Repeat(),
        but not from these identical situations.
        
        Change-Id: I3544bac6b5c087bb10c8f94005d3bc89bd2727d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169526
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-06-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d9fee55c634b500f1d7d0edaa25cecfc276b0869]

        vcl: remove partial GIF image loading
        
        This removes the code that handles the IO_PENDING and the graphic
        "context" handling from GIF image format.
        
        Partial loading of images complicates the image filter life cycle
        a lot (many exceptions) and is not really needed so much today as
        this was needed in the past. In most cases we load the whole image
        in one pass anyway. Even loading from the network should be fast
        enough to not cause issues for the user.
        
        Most image filters don't even implement this like PNG and nobody
        noticed for many years that this is not supported.
        
        To handle IO_PENDING case it is probably better to load the
        bitstream into memory and then load the whole image after that
        in one pass. This can also be implemented all inside (Imp)Graphic
        in a very straight forward way.
        
        In addition some broken GIF files for testCVEs now fail to load
        completely and those need to be moved from pass/ to fail/.
        
        Change-Id: I5fb7004a4aff957da872bb3f5c66b61bf95f18d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165212
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-25  Patrick Luby  <guibmacdev@gmail.com>  [12dbf0e6b6b485a1d73c7e33bd0ecfb13e6efdac]

        tdf#159175 Do not allocate a CGLayer for each NSWindow when using Skia
        
        Skia surfaces can be copied directly to an NSWindow's CGContextRef
        so disable allocation of a CGLayer for each NSWindow to significantly
        reduce memory usage when Skia is enabled.
        
        Change-Id: I8e3001e4f2ae8dd36156c06db68447c6b1bc67df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169242
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-25  Michael Stahl  <michael.stahl@allotropia.de>  [4acedb794c1ba0de24f2c8703e07d7f2d5143bdb]

        tdf#161721 sw: text formatting: TabOverMargin allow 55cm of crazy
        
        Also remove the limitation to a single text portion after tab, seems it
        was overly cautious.
        
        Change-Id: I07da5fdc97d84a056db87c8b74cdfc5bca85cf1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169521
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-25  Patrick Luby  <guibmacdev@gmail.com>  [ef2c71d3a78904a917b3001f6ec043d00fc3f71f]

        Related tdf#148569: do not apply macOS fix to non-macOS platforms
        
        Setting the stroke width and cap has a noticeable performance penalty
        when running on GTK3. Since tdf#148569 only appears to occur on macOS
        Retina displays, revert commit a4488013ee6c87a97501b620dbbf56622fb70246
        for non-macOS platforms.
        
        Change-Id: I2435434c6f66b84483046ea558bac3d47b8803ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169475
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-25  Regina Henschel  <rb.henschel@t-online.de>  [9f62c7a0f2333d1b7d179a43b3b0341dba7554a1]

        tdf#161483 enable LO to read ODF angle units
        
        ODF uses in several places data type 'angle' (18.3.1, ODF 1.3). That is
        a double followed by unit identifier 'deg', 'grad' or 'rad' or a unit
        less value in degrees. LO uses in the API angles in degrees, 1/10 of
        degrees and 1/100 of degrees in data types 'double', 'short' and 'long'.
        
        Without the fix LO does not interpret the units, but takes only the
        number part.
        
        Change-Id: Ib3f2a518a25199e3cf7a7a8572e169785f75c427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169360
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-06-25  Chris Mayo  <aklhfex@gmail.com>  [7a13e4a9edca15a8f3410417ef15c6b002f3de64]

        Remove duplicate vnd.stardivision.writer-global MimeType
        
        Change-Id: Iec722f05ff2770311f36c38c7dd7e69adbbd6daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169474
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-25  Michael Stahl  <michael.stahl@allotropia.de>  [78705c3b977aaeb0608538e63df3b78ec67bcae6]

        tdf#161721 sw: text formatting: TabOverMargin not crazy enough
        
        Word will use a center or right tab position in the margin without
        limiting it, and even put text after it.
        
        Change-Id: Ibae5758467620f355544963acb7941689fae2602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169517
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [af0042ba6518ab07059992d25aadd932b1e2aa8b]

        align conditional re dotnet/netmaker - only use in --enable-odk case
        
        that's what the check for creating the tool used already
        (Module_codemaker.mk), while the targets using the tool only was behind
        a ENABLE_DOTNET check.
        
        fixes the android CI builds
        
        Change-Id: Ie859a6409bb523926a619e87b693ec4c17a875cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169512
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [c13528abd69ea256cfde5ef1933c4e7f51219d33]

        Fixes copy/paste error
        
        follow-up to Iff407da8907b761236ebc2aa8877b9d6b8294e10
        
        Change-Id: Icb5b3703809e5df80df5e269e6160c1c78dc186d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169364
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-06-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a69521271092968fc53afdf346026700e04fc50]

        Fix typo
        
        Change-Id: I1835209f48896e01af2cb3fad10a758b704087dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169515
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [34669af1ce80e4f8ea5c582736155a79338ffd12]

        Fix typo
        
        Change-Id: I6d1130f6d59439420dccbdf94a4df43504e7cd36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169514
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef0e2c9f970ac59c8b27f79fb0cda6106f2f3013]

        Fix typo
        
        Change-Id: I696c8d2a1f18704c5907136e5acc5b9723fdd983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169516
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [52afd5d2679229ffb0f84143fe80b50472cd7e3b]

        Fix typo
        
        Change-Id: Ic7b080780a924e0d824b3163487c21b6515844b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169513
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [ffa17012ef1757a964908b5cdc069d9125e98d43]

        LOK: Do a ".uno:DocumentStatus" "state changed" callback
        
        ... along with proper state changed callbacks for .uno:SlideMasterPage,
        .uno:NormalMultiPaneGUI, .uno:NotesMode, and others.
        
        The ".uno:DocumentStatus" payload is a notification for the callback
        that it may need to collect the document status.
        
        This allows to avoid the bond between the mentioned true UNO command
        names, and the status collection: since we now send the status updates
        for all of them, the document status collection would be performed for
        each of them in the absence of a dedicated signal.
        
        This re-implements commit bbd32b39eae24e99d135ed5c48586db8c9b0fb23,
        without introducing a new callback enum value.
        
        Change-Id: I942e17298196ff39ef8817a4cd59ad0fb8fa0da1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169468
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2c2d84fefc5b3cc35c1db0d8244902362dc0531c]

        Revert "LOK: Introduce LOK_CALLBACK_STATUS_UPDATE"
        
        This reverts commit bbd32b39eae24e99d135ed5c48586db8c9b0fb23.
        A following commit will implement an alternative method without a
        new enum member.
        
        Change-Id: Id00a4a0abe68fc69b1a3a81c731c8085e3dbca2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169467
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d208c4e42595bb85fd0ef726a89e10dd32b48b1]

        tdf#161210 speed xls load
        
        instead of applying row styles to all 16384 columns, only apply them to
        columns that have data.
        
        That takes the load time for this file from 19s to 1s for me.
        
        Change-Id: Ifec56995e0053938dc5a7ed0d15ae3a173614dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169506
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [87c81bb409cb5cd826eb21366a8e3222cb924ca1]

        remove commented out code
        
        I accidentally left behind in
            commit 168eb2e64b7ad08645f62b45e15af2ee7260100c
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Jun 23 19:44:06 2024 +0200
            tdf#144208 speedup doc with lots of redline(15)
        
        Change-Id: I6fa4765db48d158a12c6ea547ede0d0e13f0e61f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169448
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [bdc8d3dec0beb167c40e6d0eea02c3b401e5117d]

        tdf#161210 speed up XLS load
        
        flatten XclImpXFRangeColumn a litte, no need to allocate this separately
        
        Change-Id: Ic33131626b41ca19b964387b3d7f6e74cefdd91c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cc1f1e0e6dcabee2b6ca28f4f1341f0099814966]

        Fix typo
        
        Change-Id: I4f82345a558a991d4297dabdfd6b80041bda47a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169478
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [e932e2ab943a9941fcfc7073c9b6c11b982c2c4c]

        Resolves tdf#161641 - Select data area before select all
        
        Advanced option SelectRangeBeforeAll to restore original behavior
        
        Change-Id: Iab4b4e61dffc1ecf2ffed01a994c9894c84ab74d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169276
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-25  Pierre F  <fpy@bger.ch>  [3cb32bf100a0f50390ae3390fa84f2b8bba6e6ff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c796230a7363073c9763dff5d157fd5711ba590d
          - fix typo
            
            Change-Id: I353e1a52697f5d7ac055ad870d1415885a3b5a5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169439
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-25  Miklos Vajna  <vmiklos@collabora.com>  [e005d2165794cb16efe79adf967271c6e0ee4047]

        sw: fix assertion failure in SwView::ExecTabWin()
        
        Crashreport signature:
        
        > /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_algo.h:3623: constexpr const _Tp& std::clamp(const _Tp&, const _Tp&, const _Tp&) [with _Tp = long int]: Assertion '!(__hi < __lo)' failed.
        > program/libswlo.so
        > 	long const& std::clamp<long>(long const&, long const&, long const&)
        > 		??:?
        > program/libswlo.so
        > 	SwView::ExecTabWin(SfxRequest const&)
        > 		sw/source/uibase/uiview/viewtab.cxx:1139
        > program/libmergedlo.so
        > 	SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
        > 		sfx2/source/control/dispatch.cxx:257
        
        Change-Id: I659fce002e5672c1c8c75fd130c7aae5b6a44460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169447
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-25  Leonard Sasse  <l.sasse@fz-juelich.de>  [96ffaadbcd3010515b2465f7f87b599909db5913]

        tdf#158803 F821: xrange undefined, should be range in py3; remove some unused variables
        
        changing range(len()) to enumerate as suggested
        by Arkadiy Illarionov
        
        Change-Id: I5000204281a5f6ded9c411525e612bf84b552f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165505
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [70b3e128aef631e18e6451362c2e6315c28b857e]

        Resave with newer Glade version
        
        Change-Id: I5e97ebd5cb357673d7bfda563e83c2e75934b88d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169391
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0bd78576cabee83b7e3e617c271d67bc54a78f7f]

        Resave with newer Glade version
        
        Change-Id: Ifbf7623bb1478f47c28b292049506ba6854d68b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169399
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [4220b8be72b6d168dc9d11d35fd400d0b15e6f7d]

        Add newline at end of file
        
        Change-Id: I731d8d80e075c8df8a104ec963b89337a91d536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169376
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6c724c2456eba6198c9c7c8f0cbf04e759083097]

        Resave with newer Glade version
        
        Change-Id: I6720f2d2435b53c3cead37c1d2cd68e957e9066b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169400
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Jim Raykowski  <raykowj@gmail.com>  [601cf05456073c082ac6bbe43b501eb81256711b]

        tdf#160543 Quickfind sidebar enhancements
        
        * Makes the search independent of find and replace options.
        * Adds a button to launch a dialog for match case, whole words only,
        and similarity search options.
        * Adds a button to launch the find and replace dialog.
        * Makes the find entry control have visual feedback when there are no
        matches.
        * Adds a label at the bottom of panel that shows the number of matches.
        
        Change-Id: I2cffcf86978773471bb86c5e5cf8b967c24efa7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168834
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-24  Jim Raykowski  <raykowj@gmail.com>  [35d42ca07159a7fa4958c35dba05c527f3be29e6]

        Partially resolves tdf#160540 Quickfind sidebar: make better use of
        
        space for search results
        
        Making the row space behavior of SalInstanceTreeView the same as
        GtkInstanceTreeView would fully resolve this.
        
        Change-Id: I5fd5fc755afe3ba2c2e4f4ed56dc1c7f8f541817
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168833
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-24  Leonard Sasse  <l.sasse@fz-juelich.de>  [6f9f643b6d7929423fc83fc7857ed70e140a96ed]

        tdf#158803 F821: fix a number of undefined names and related issues in wizards/
        
        make CharLocale a class attribute in TextDocument.py
        similar to line 109
        
        fix import of AnyConverter in Configuration.py
        
        it turns out LetterWizardDialog.py was
        importing HID from LetterWizardDialogConst.py
        but not using that import. But removing it
        broke LetterWizardDialogImply.py because
        this was importing HID from LetterWizardDialog.py
        so now LetterWizardDialogImpl.py is directly
        importing HID from LetterWizardDialogConst.py
        
        Change-Id: I36bf54dcfca084b9cd25cef0f80ae814ef83643a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165507
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-24  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [a35cd97feb6647facd11ebf06154bab2dcdb444f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to fc2dc383a40e56c0118866c9110954bebc6ea41d
          - tdf#150433 Add Thai thesaurus
            
            Change-Id: I0d833c01a76a5c6957487b6cfcd1d4bc0279a5f3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/149147
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-06-24  Michael Stahl  <michael.stahl@allotropia.de>  [25cdebe70a9f1c1be9ae9f2ca7c2e1bf9565756d]

        libcmis: fix failing AtomTest::authCallbackTest()
        
        (regression from commit f91effb36b2be1ff8937d684191fb2f19d6ac97d)
        
        Change-Id: I24c8da1c8ca70739ac047918c7036d72c7f7330b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169465
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-24  Miklos Vajna  <vmiklos@collabora.com>  [f58e3e3402c87755a2dd3cb83f29d00c40b94f1a]

        Related: tdf#161652 sw, RTF paste: only keep used paragraph styles
        
        When pasting from old enough Impress that doesn't have commit
        afb4ea67463d9f0200dc6216cfd932aec0984c82 (tdf#161652 editeng, RTF copy:
        only write used paragraph styles, 2024-06-20), it still happened that we
        got many styles from an Impress slide's paragraph in Writer than just
        the style of that paragraph itself.
        
        The problem is that if we want to avoid problems with bad user input,
        that has to be handled on the RTF paste / import side, not on the
        producing side.
        
        Fix the problem by filtering out unused paragraph styles also on the RTF
        import (paste) side, in the IsNewDoc() case, which is the clipboard case
        (not RTF file open).
        
        With this, we attempt to filter out not needed paragraph styles both on
        the import and export side.
        
        Change-Id: Ic2c63e5f45245bb4296ec0d1a95558c459667e29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169445
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-24  Noel Grandin  <noelgrandin@gmail.com>  [857eee7c2cf8baaab556db6ce888db0db1c8a858]

        tdf#144208 speedup doc with lots of redline(16)
        
        SwXParagraph is heavily used. Reduce the allocation cost of
        this class by de-pimpl'ing this class.
        
        Change-Id: Iebdb9faebfd64416d581641e275e9a4389e2c90e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169362
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-24  Noel Grandin  <noelgrandin@gmail.com>  [a07c6264660d782b396c4a4b2939f8c9767a1bf3]

        no need to use a mix of pimpl and normal fields for SwXFrame
        
        Change-Id: I90a6f1f1854ac1c5da2133122f17c14c58ec2d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [da278e421909653ba85054daf6103991e56ffa26]

        flatten XMLParaContext a little
        
        to avoid pointer-chasing in some hot methods
        
        Change-Id: Ie0dc1e47628a8ae1279abe2e95894dabae82f3ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169454
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-24  Jim Raykowski  <raykowj@gmail.com>  [6fb5e52479b0a3e6f63ae96886884b3653abddaf]

        tdf#160541 Resolves Quickfind sidebar: present results with some
        
        indication of location in document
        
        Change-Id: I9262511c46b9a89fd7c5d7fe93551fecbd21cecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168832
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [1f26aa7f42795aed775646cbb616f5ee4e60326c]

        tdf#161743 Calc Sidebar Functions deck: move focus to document upon
        
        Esc while in empty search field
        
        Change-Id: I7bb6aaeb69712b293c74bfcf34ab65c4869c860c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169352
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-24  Michael Stahl  <michael.stahl@allotropia.de>  [3725d51647b318b680a003afc7cf20c02dc06ef8]

        ucb: webdav-curl: try to get the curl error message for more errors
        
        Change-Id: Iad39deeeef55498628616762b6b8dddc5a8f7475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169345
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-24  Miklos Vajna  <vmiklos@collabora.com>  [23f7ef1c6d06262d1557f8978b48c5275b3d9585]

        svx: prefix members of SdrUndoMoveObj
        
        See tdf#94879 for motivation.
        
        Change-Id: If81831d76617da9b9d6ac5aef2e223065e939c4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169446
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6670727bbbe26e6b2b9bf9b93fb85bf2b2b1aca6]

        Resave with newer Glade version
        
        Change-Id: I66bcfe5859bfc9f89cfcd8fc11e0ce6532e3eeb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169387
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b3f58b0058bc507952e5678eb5c4dcd9f1979364]

        Resave with newer Glade version
        
        Change-Id: If519ec2547d462b418ce51dbd56f0f497c29b4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169406
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b2613a9fef8b359c4bc000c8ce82da65cf561c2c]

        Resave with newer Glade version
        
        Change-Id: I85e6a1df5196f8e071a94142f429687417f59b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169411
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c50f771ec85d05ae7396b4503d575244484c37de]

        Resave with newer Glade version
        
        Change-Id: Ibc7f9eb2d9fd0db2861ab7dd62410d534eab1459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169414
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6b04c3ff862633896ec1607d3d8a860e310566e0]

        Resave with newer Glade version
        
        Change-Id: Ia4b40678632d825143c7e9ac2e8719b7e109a64a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169410
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9a074032582deafe8faa7f56c639e54900b3174c]

        Resave with newer Glade version
        
        Change-Id: Ieaa8a90ddef6a49a3dfbb59575bf8defebeaa854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169382
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [aa1c24888d8b2c5edec553f29ceaafd7bb57337b]

        Resave with newer Glade version
        
        Change-Id: Id2bc88f90d5e73ffa2c99d0fc4c3aa1fb55f568d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169386
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [21249bc76ac8aca79d99ef109bf4130609a687a6]

        Resave with newer Glade version
        
        Change-Id: I658a8a32cda30ecacd92dda284c924aa0137e14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169418
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [52c3ff2e32ea7db2656571c0188733a0cfcd3540]

        Resave with newer Glade version
        
        Change-Id: Ia266b96c1cc558ca4eb17194a58a1623c3f3ed54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169392
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Michael Stahl  <michael.stahl@allotropia.de>  [9413f2b39cb48417d75dfd3b5a28dac18541839e]

        ucb: cmis: remove CertValidationHandler
        
        Bothering users with a dialog for a problematic TLS certificate just
        conditions them to click OK and compromise their security.
        
        WebDAV UCP already doesn't show such a dialog since LO 7.3, now remove
        the dialog from CMIS UCP too.
        
        Users can add any self-signed CAs they want to use to the operating
        system trusted CA store, for example with p11-kit's trust(1).
        
        Change-Id: Iedb8518923f9ac75c33a3b0df6ff795a7810a18a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169338
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-24  Michael Stahl  <michael.stahl@allotropia.de>  [62529d1eee91f3a781a4ef9117f23aa65ec82e86]

        libcmis,ucb: cmis: improve AllowInsecureProtocols implementation
        
        1. in libcmis, pass the CurlInitProtocolsFunction to all subclasses of
           HttpSession that need it, and add 2 upstream fixes to pass it around
        
        2. Arrange for InitCurl_easy to be called in UCP RepoContent as well
        
        3. If AllowInsecureProtocols is disabled, automatically upgrade
           http connections to https, as is already done in webdav-curl.
           Do this in Content and RepoContent; hopefully should work
           to convert when m_aURL member is initialised;
           the m_xIdentifier on the other hand should have the original
           URL because ContentProviderImplHelper::queryExistingContents()
           caching likely relies on that.
        
        Change-Id: I20d36ed03ba7ce221d6946b1c996071f4130ec7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169114
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-24  Michael Stahl  <michael.stahl@allotropia.de>  [e598cfd1d84b9eb4144e36cba0e514ea6c31f118]

        ucb: cmis: remove NSS initialization
        
        Upstream curl has removed NSS backend.
        
        Change-Id: Iaf69ceb6b71db4c9553e8d4f7b30a702d0dd0f44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169336
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fefc609559f1f81e9e88b6b2d77c1bb1f6bff31a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 47eaabaeb6b90551dccb72ad5ba9f241ad7608cf
          - Fix %PRODUCTNAME
            
            Change-Id: I30533473a81ecf7bb9ca3befbe5bac75d010b16d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169375
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-24  Pierre F  <fpy@bger.ch>  [b0ad1a7b51cf21e17fdeccaf32893a8012a979d6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ade7397aed9febc73918d93ffdf6477d3f4d4175
          - explicit \s and \d +  put the note first for full ICU spec. tdf#113975
            
            Change-Id: Ie06115c051def1da7b94357a392796d15a21df34
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169402
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-24  Justin Luth  <justin.luth@collabora.com>  [a9bdf3adf3292f6eff94f6c373c5336992c15ed5]

        NFC cleanup duplicate entry in sc/IwyuFilter_sc.yaml #2
        
        found by sed -i  -f ref.sed */*.yaml
        --------------------ref.sed --------------------
        {
        N;
        s#\([^\n]*\n\)\1#\1#g;
        P;
        D;
        }
        ------------------------------------------------
        
        meaning: by default it reads in one line from the file
        then the N; command says "add a \n and read in the next line
            which leaves a one-line pattern containing 2 lines separated by \n
        then search for line1\n repeated \1
        and replace with \1.
        
        likely nothing has happened, so P; print up to the first \n (aka line1)
            so that we don't lose that line
        D; delete up to the first \n
            so that it isn't in the pattern buffer any more,
            and next search starts line2
        and then repeat.
        
        Change-Id: Ib5d38af77568f59f36083f5348762d852acaa3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169047
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-24  Justin Luth  <justin.luth@collabora.com>  [160ef8e6c3161ba99ee72f2ab8be91a539b7dc0e]

        NFC cleanup duplicate entry in framework/IwyuFilter_framework.yaml
        
        found by sed -i  -f ref.sed */*.yaml
        --------------------ref.sed --------------------
        {
        N;
        N;
        N;
        s#\([^\n]*\n\)\([^\n]*\)\n\1\2#\1\2#g;
        P;
        D;
        }
        ------------------------------------------------
        
        meaning: by default it reads in one line from the file
        then the 3 N; commands say "add a \n and read in the next line
            which leaves a one-line pattern containing 4 lines separated by \n
        then search for line1\nline2\n repeated \1\2
        and replace with \1\2.
        
        likely nothing has happened, so P; print up to the first \n (aka line1)
            so that we don't lose that line
        D; delete up to the first \n
            so that it isn't in the pattern buffer any more,
            and next search starts line2
        and then repeat.
            Note that the pattern gets rather huge
            because while we only remove one line at a time,
            we unnecessarily append 3 more lines (instead of just one).
            But that doesn't seem to cause the search to fail...
        
        Change-Id: I440bca873483dc7f1716881113807fe121fe6a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169045
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-06-24  Noel Grandin  <noelgrandin@gmail.com>  [168eb2e64b7ad08645f62b45e15af2ee7260100c]

        tdf#144208 speedup doc with lots of redline(15)
        
        SwXText is heavily used. Reduce the allocation cost of
        this class by de-pimpl'ing this class.
        
        Change-Id: I01b06c978075ae312131dfff29b4f304caf69e18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169359
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-24  Noel Grandin  <noelgrandin@gmail.com>  [ba28df4fb2c1bc151eebb2d1d2c385be0b71c49d]

        tdf#144208 speedup doc with lots of redline(14)
        
        SwXTextRange is heavily used. Reduce the allocation cost of
        this class by de-pimpl'ing this class.
        
        One strange thing I noticed is that the destructor of the Impl indicates
        that deleting the bookmark via deleteMark() has to happen under the SolarMutex,
        but there are two places in the existing code which violate this already.
        
        Change-Id: I171a0d82d6d020d9a43808c424f308722770783f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2d60017a66cca4668c87f64f6d048566656b3b1c]

        ods: Don't export changes author/date when in privacy mode
        
        Change-Id: I8c542f398bb70da96a64b61a9931398b6a78ea72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169258
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [dae21034a459ca77cd40616399e8cebf076ccdd9]

        Resave with newer Glade version
        
        Change-Id: I78c7d3d4ae4643fa9f669177263d8c7bf4f681e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169377
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [7cfb1165ff881f361a0190e9c39a6329b1392907]

        Resave with newer Glade version
        
        Change-Id: I86065d81a449360f09268fe617f8f09e7a917411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169385
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ce117075a60b1dc0568cad1d726b32c9bb7662a1]

        Resave with newer Glade version
        
        Change-Id: I21efa82c67aa8e7a7af7a9fcb80f61ee64adaba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169383
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6806659182e3482b3aca9fa0e3809fb5e3b9b61c]

        Resave with newer Glade version
        
        Change-Id: I6abcf8d983550e92a2ccc768de47c2ccb6d8583b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169381
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [87cf6f4dda69f1c8b5783a65621ea8eb91f739a5]

        Resave with newer Glade version
        
        Change-Id: I56f5bbeed4850a742403ffd7dd43fca25101ad17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169380
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e2e107aebb1fdddc08008eec2c85443bd862e732]

        Resave with newer Glade version
        
        Change-Id: I49158bd13ace3cd0b5e577e7964ae3b64822ac25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169379
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2b7a3b870d4d035bd98906203038514b89d4bfdd]

        Resave with newer Glade version
        
        Change-Id: I83aa9920a5bdb339aeaed1b659b2f6786fa1390f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169420
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8b3e6cc6143c26794252908ac6779370db251959]

        Resave with newer Glade version
        
        Change-Id: Ia740b979dcb8e21f7031020b8e2c708cfa43c0f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169407
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2722385c102d5a8ffce4be101257ddf959cf6fc8]

        Resave with newer Glade version
        
        Change-Id: I39c00ad75b1dd2c769ed89a3b1aa2e028ab64efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169419
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [ec92c4883bb171ee91c5887f372056358e2b88db]

        Resave with newer Glade version
        
        Change-Id: I214857e837fb0293228df934e8ccdbc89395ceb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169412
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c32128b35d177808df47ca98a91c2ef75e922c4a]

        editeng: add convenience creators to ESelection All, NotFound
        
        ESelection::All() select all text
        ESelection::NotFound() sets seletion to not found state
        ESelection::NoSelection() sets selection to no / invalid selection
        
        Introduce max paragraph and position constants in ESelection,
        use for EE_PARA_APPEND, EE_PARA_ALL, EE_PARA_MAX_COUNT,
        EE_TEXTPOS_ALL, EE_TEXTPOS_MAX_COUNT.
        
        Also simplify some ESelection constructs.
        
        Change-Id: Ib110c5a730a1deabe4f988baa5a600249b3a31e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169356
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [2f9c7d0e1ed37ea223be3f31dd9e070e37f2a0d2]

        Resave with newer Glade version
        
        Change-Id: Ief1e76e4888d33d353b73d26a2aca914b5b087dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169405
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [9bfa4637dd993c01ee0db167b9c87cd5b9de4964]

        Resave with newer Glade version
        
        Change-Id: Id6148c524201850b19c345c70dee6c205b255e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169404
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0bc317e7a0b7b97b00a0d77ff54b17baf45fd08f]

        Resave with newer Glade version
        
        Change-Id: I84dcacf811ce007144ecb8d1473d4b6887887422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169397
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [e824393f513b96b44601065bfdc376ba4bc8211b]

        Resave with newer Glade version
        
        Change-Id: I397231ded31f3aea7227b0251cf45abaa165faed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169413
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5412dba69bdacda7a476002f8c9d8b11b72e226d]

        Resave with newer Glade version
        
        Change-Id: I970e33e166efe611dbaae16ab0ed6491298a6751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169409
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d55b8b47285503aa69574d18c29e203879116202]

        Resave with newer Glade version
        
        Change-Id: I011489b4d87a078af6083001d076f71140b98a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169401
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-24  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [321f1533cd2a57e480462e70f7e6b5acf7f655f3]

        Resave with newer Glade version
        
        Change-Id: I814a09020221fd19f6739475cbf8b06f4ab52e18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169408
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-23  Hossein  <hossein@libreoffice.org>  [1305edfbc27121d7fc8973ccafb92f76d5401ac1]

        tdf#149256 Ship LibreOfficeKit headers in packages
        
        With LibreOfficeKit (LOK) headers in place, it would be possible to
        create C++ applications that can access LibreOffice functionality
        without building LibreOffice, only by installing SDK and build tools.
        
        Change-Id: I8efc8ac1cec7b3b89e4d7eb2c8d15afeb595672c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134863
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-06-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ecb0d08e3cfcad18006c0090b9b5b19c1c0f7b9c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9acd72cd9faa94ec85826293f1e95da3e6175d35
          - tdf#159596 tdf#159771 Update XMATCH and XLOOKUP pages
            
            + Added 3 as matchtype
            + removed reference for "search-criteria-must-apply-to-whole-cell"
            + set that matchtype 2 and 3 cannot be combined with binary search.
            
            Change-Id: I1fd2171aa92fb0a2df1c9ee85a1fb5f7f755efdb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169334
            Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4420d77a501835d92c00cfbe965281eacb094389]

        Resave with newer Glade version
        
        Change-Id: Ia9330a82d3dd6796cb613e6244c3149de872a852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169372
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [547167a27cdc744bbd7ebcdcf18b43a04f91afa7]

        Resave with newer Glade version
        
        Change-Id: Ib3b198c2030b86cdd2cc9558407feefdde0b40dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169374
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [4bba6c0ef497749a03a790dc377bda9095875fc5]

        Resave with newer Glade version
        
        Change-Id: I1edfac23ae17ffcdf8959265bce51322a34c4f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169373
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [cb2dffae805f3526a008fc0d0fe38c36e3cc699d]

        Resave with newer Glade version
        
        Change-Id: I6de6bacbdccd83b08e5e0b41adef23efd51d80dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169371
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6daffa1d9c56954e21259f394f966e79830257e4]

        Resave with newer Glade version
        
        Change-Id: I3b06e8341b71d816df2cfa1f4343d48d4156cfbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169370
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-23  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [25287c44b6b61369837ca2bd7e9b9ad6193f4db5]

        Resave with newer Glade version
        
        Change-Id: Ibebe4caede19886e47a9ebbbcaf53c79df8511cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169369
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-22  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [513c2bdbb1e7c0ad669d03043db61c94d6524aba]

        tdf#157529 PPTX import: fix transparency value
        
        if the paragraph, which uses transformation (Arch, Circle, etc.),
        contains multiple texts and the first text is only a space character,
        then we use the transparency value of the following text.
        
        Change-Id: Ia87242e34b495802cbecf5dc0dd13d490312f435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169351
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Jenkins

2024-06-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [c3e80cbaaa62d1150860cc5281dfc784dbbde8af]

        tdf#161658 Limit new selection overlay to Calc only
        
        Previous patches [1] and [2] introduced a contrast white line to the selection overlay that was supposed to affect only Calc, but it ended up affecting other areas of LO, such as the star math editor as well as Writer.
        
        This patch makes sure the changes only affect cell selection in Calc.
        
        [1] dc243f0122ba656d2630e93bebfb84a2bfe4042a
        [2] 3c0db898092c2cf6148c01f6c561acc199d484f5
        
        Change-Id: Ie910120e4b71c55ad8c00a905e1204e291a711f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169292
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-06-22  Noel Grandin  <noelgrandin@gmail.com>  [40e08851304e5c179842dcf2e1e3b352f1baee21]

        fix O(n^2) behaviour when fetching field info from EditEngine
        
        Change-Id: I324a1814fc1b3321eed5b29922790600e7092c17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169344
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-22  Noel Grandin  <noelgrandin@gmail.com>  [858bc4d76bb49ff1766e5d4bd404b04d61201c37]

        no need to call FormatDoc() after calling CheckIdleFormatter()
        
        CheckIdleFormatter() already does that
        
        Change-Id: Ie6b9e3285303899e3f67cccb0fc5f5625c8db684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169343
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-22  Justin Luth  <jluth@mail.com>  [b7fce2b26ee4ba585544457adc742807a2129d2c]

        NFC sw textfld.cxx: make rDoc an actual reference
        
        Change-Id: I84d65e80f27cdc2cbfc4f56c89e5a391e0fd9e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169350
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-22  RMZeroFour  <ritobroto04@gmail.com>  [4031659233958a5bf93ea86e8fe117fd0dd45c10]

        .NET Bindings: Switch for old windows CLI bindings
        
        This commit adds an --enable-cli/--disable-cli switch to autoconf to
        control generation of the old CLI bindings (Windows only). It is
        enabled by default, to not be a breaking change to users just yet.
        Over time, when the old bindings are deprecated in favor of the new
        .NET bindings, it could be set to disabled by default.
        
        Change-Id: Ib60b372459cb0c735275ed17d004d037279357eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168751
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-06-21  Michael Weghorn  <m.weghorn@posteo.de>  [89372e62454a72c6c400f00bfe3221bc0fe6d23e]

        tdf#149461 qt5: Provide a QWindow for OpenGL rendering on X11
        
        When using the qt5 or kf5 VCL plugins on X11/XWayland
        (as can be forced using QT_QPA_PLUGIN=xcb on Wayland),
        ensure that a QWindow exists for the QtObjectWidget
        created in the QtObject ctor, as that is needed for
        OpenGL rendering.
        
        This makes OpenGL Impress slide transitions like the
        "Tiles" one work.
        
        Don't force native windows on Wayland, as that causes
        other issues, see also QtFrame::ResolveWindowHandle
        and the bugs referenced in there.
        
        Change-Id: I8fac34d2f1cc7cc723ad4570546276a05641dd88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169348
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-21  Michael Weghorn  <m.weghorn@posteo.de>  [b296b33cfbde5113f27ddef71a48380cb6ce5e06]

        tdf#149461 qt6: Provide a QWindow for OpenGL rendering
        
        As described at [1], "QWindow supports rendering using
        OpenGL [...]".
        
        Using a QWindow for OpenGL rendering had been introduced
        in
        
            commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3
            Date:   Fri Dec 14 12:44:20 2018 +0300
        
                tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL
        
        , but then
        
            commit 4366e0605214260e55a937173b0c2e02225dc843
            Date:   Tue May 24 11:34:59 2022 +0200
        
                tdf#148864 Qt switch QtObjectWindow to QWidget
        
        had switched from QWindow to QWidget, and OpenGL slide
        transitions like the "Tiles" one stopped working.
        
        At least for qt6, which now uses QtMultimedia for video
        playback (see the tdf#145735 commits), issues like tdf#148864
        ("Kubuntu 22.04 LTS LibreOffice Impress 7.3.3 Fails to Play Embedded
         Videos") and tdf#125517 ("LO Impress: Can't stop presentation
        with video and go to the next slide") related to video playback
        appear to be no problem, so switch back to using QWindow there.
        
        Explicitly set the window background to transparent
        in `QtOpenGLContext::ImplInit`, as not doing so
        caused slide content in presentation mode to not
        be updated properly when testing with the attachment 183972
        from tdf#149461 on Wayland.
        (This was not an issue when running on XWayland, i.e.
        with QT_QPA_PLATFORM=xcb).
        
        With this in place, OpenGL transitions work with qt6.
        With QT_QPA_PLATFORM=xcb, it looks all fine in my tests
        on Debian testing.
        
        With QT_QPA_PLATFORM=wayland, the slide text from attachment 183972
        sometimes incorrectly showed up for a fraction of a second after
        the slide transition finished, then disappeared again until
        it was triggered to show as it should (e.g. by pressing the right
        arrow key), s. screencast attachment 194899 in tdf#149461.
        A multitude of warnings like the following are shown on stderr
        in that case, which don't show up for xcb:
        
            warn:vcl.opengl:47352:47352:vcl/source/opengl/OpenGLHelper.cxx:709: GL Error 0506 (invalid framebuffer operation) in file /home/michi/development/git/libreoffice/slideshow/source/engine/opengl/TransitionImpl.cxx at line 398
        
        That looks like a separate issue to me, however which would
        need further analysis.
        
        Keep using the QtObjectWindow approach for qt5 to
        not regress on video playback.
        
        [1] https://doc.qt.io/qt-5/qtgui-index.html#opengl-and-opengl-es-integration
        
        Change-Id: I6e1eb989254e2cbbfada6f719ee0518571df4c42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169347
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-21  Michael Weghorn  <m.weghorn@posteo.de>  [22270a54a2d73f96109ca851b1e1627910213645]

        tdf#149461 qt: Move setting layout to QtObject ctor
        
        Move setting the layout for the QtObjectWidget
        from the QtObjectWidget ctor to the QtObject ctor,
        in preparation to also use that for QWidgets other
        than the QtObjectWidget.
        
        Change-Id: Ifbb0d853659bc8099bed40db2bbe8a8778077aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169346
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-21  Noel Grandin  <noelgrandin@gmail.com>  [6e3cefc89e80ec0f7fab058a583d3ac4c702400e]

        move ensureDocumentFormatted from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I851578ff553b01fb7d48cf5aa8f7a2d795496751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169340
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-21  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [76c96ca7c9a6e0d847ec5dc186c6e47ab6061f5f]

        tdf#158454 Add Thai Autocorrect Support, coding part
        
        SvxAutoCorrDoc::ChgAutoCorrWord() implementations: correct multiple patterns
        
        * include/editeng/svxacorr.hxx, editeng/source/misc/svxacorr.cxx:
          - Add classes SvxAutocorrWordList::{Iterator,WordSearchStatus}.
          - Make SvxAutocorrWordList::SearchWordsInList() return WordSearchStatus
            so the search can be continued with the added
            SvxAutocorrWordList::SearchWordsNext() method.
          - Make SvxAutoCorrect::SearchWordsInList(), and its lcl_SearchWordsInList()
            companion, return WordSearchStatus propagated from
            SvxAutocorrWordList::SearchWordsInList().
          - SvxAutocorrWordList::WordMatches():
              The existing mechanism of preventing collision of patterns like in
            tdf#83037 (→ and ← and ↔ autocorrect collisions) was by storing
            the matched string of wildcard pattern back to the list without
            overwriting existing one. If the matched string was found in the list,
            it would just be treated as no matching.
              While this worked well for collision prevention, it caused failure
            on the new exhaustive wildcard pattern visiting method when autocorrecting
            the second text chunk with the same content. In such situation,
            all intermediate stages of corrections of the first text chunk would be
            recorded into the list. And, in the second chunk, the first stage would
            just be applied from the recorded pattern, but all the next stages
            would be refused due to the "collision" with the recorded patterns.
            Moreover, the new method would cause the list to grow more quickly
            as the autocorrections are done.
              To solve the problem, just "peek" for the collision instead of
            actually storing it. And SvxAutocorrWordList::ContainsPattern()
            is added for this purpose.
        * editeng/qa/unit/core-test.cxx:
          - Modify TestAutoCorrDoc::ChgAutoCorrWord() to iterate through all patterns,
            instead of finishing at the first one.
        * editeng/source/editeng/edtspell.cxx:
          - Ditto for EdtAutoCorrDoc::ChgAutoCorrWord().
        * sw/source/core/edit/acorrect.cxx:
          - Ditto for SwAutoCorrDoc::ChgAutoCorrWord().
          - SwAutoCorrDoc::ChgAutoCorrWord(): Remove old dead code for autocorrection
            on text with redlines.
        * sw/qa/extras/uiwriter/uiwriter6.cxx,
          +sw/qa/extras/uiwriter/data/tdf158454.odt:
          - Add unit test "testTdf158454".
        
        Change-Id: I8fb4a628a977b79b0ed2f239fd3749f15823b5df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160160
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a820696263e62ffc7ebe0a9f6d51bec2e1354926]

        tdf#161631: sw_ooxmlexport21: Add unittest
        
        Change-Id: I1496b82e67c5f408bd682b4998e3afaf74c37318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169339
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-21  Jim Raykowski  <raykowj@gmail.com>  [c5bbbe987321d8f9e101fab9d67ddbf3d4f8dfca]

        tdf#161537 fix Filter Navigator no longer shows the name of the field
        
        Change-Id: I3dae3458ac5795b217743b1e6897345a22f1bf61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169310
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-21  Jim Raykowski  <raykowj@gmail.com>  [28438a5b1f1903fe0a69d53f9bba7d3837380b57]

        Resave with newer Glade version
        
        Change-Id: I2b3adc322b4dc928069f306ccb673fa23fba70a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169309
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b807a6b793198c00db9b2c2c3a5eb3ebfe16ad9]

        tdf#161086 bitmap location wrong with SVG with an embedded PNG
        
        we need to transform the location of the wallpaper rect to match where
        we want the wallpaper to start tiling from.
        
        regression from
            commit 3cbe3a0259bea4dec70e72191ec3c03441926a07
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jun 14 15:05:59 2021 +0200
            tdf#101083 speed up SVG rendering with pattern fill
        
        Change-Id: I624edd63135875fdc9526015f0f5642d5c694934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [f91effb36b2be1ff8937d684191fb2f19d6ac97d]

        libcmis,ucb: get more informative error messages for CMIS UCP
        
        Currently it reports pretty much everything as
        "The specified device is invalid."
        but clearly we can do better.
        
        Try not to change the public API of libcmis too much; it has 2 string
        members in libcmis::Exception, add a bunch more type values such as
        "dnsFailed", "connectFailed", "connectTimeout", "transferFailed".
        
        Also there were 2 HttpSession functions that convert libcmis::Exception
        to CurlException - very odd, was apparently done to appease Coverity,
        but the exception specifications that caused Coverity to complain were
        removed from libcmis anyway; let's remove that, every caller of these
        functions i looked at would immediately convert it back to
        libcmis::Exception anyway.
        
        Change-Id: Iee853af8bb541e6b071b75d593b6c031f67a886d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169335
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-21  Jonathan Clark  <jonathan@libreoffice.org>  [c7f1e41ca672f6bb1055b92012fff0d92a5ff805]

        tdf#107209 Writer correct vertical text break after fly portions
        
        This change fixes an issue causing Writer to corrupt layout for vertical
        text following a fly-out. This bug manifested as overlapping or
        incorrectly-reordered lines of text, sometimes appearing many pages
        after the initial fly-out.
        
        Change-Id: I05abdbf3ff122398b995220ec4e410434931fdf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169307
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-06-21  Miklos Vajna  <vmiklos@collabora.com>  [4499e123614be1de2c021c0c4f5f80d5c3e18401]

        sw doc model xml dump: show parent of para styles
        
        At some stage needs an SwFormat::dumpAsXml() but that's not yet done
        here.
        
        Change-Id: I10d2e0f653fc6d0e351bc0aa17f98de8f01766fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169337
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a3bcf0840dec6f91acbe0fe9bc2f733f2a4ae3c7]

        tdf#159907 - A11Y - Fix highlighted text does not show its attributes
        
        in the Style inspector.
        
        Set the cursor at the end of the highlighted text.
        
        Change-Id: I68af50d5bcf91c3cfe603aeef9e88c088b391590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169259
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [60e8446323e03d097b7272f37c3b9e92a66a7cbc]

        tsan: fix data race in VCLXWindowImpl
        
        Change-Id: I68894dabdaa22ac3733d08ae85df5c82e3b9654c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169333
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-21  Zainab Abbasi  <101zabbasi@gmail.com>  [b00183ebb29d19cb59145a3d240554f8e3573a0b]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I9ebe5e8c966a21b99a5229a4418738e4178716a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169312
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [bbd32b39eae24e99d135ed5c48586db8c9b0fb23]

        LOK: Introduce LOK_CALLBACK_STATUS_UPDATE
        
        This allows to send status messages separately from statechanged;
        this is needed in Impress to notify about any mode update, not only
        masterview-related.
        
        Also send SlideMasterPage updates automatically from core.
        
        Change-Id: I0a50dbe61a5f2f28cd418eb4416819a6a76810b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169314
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [319e62915b35d7129a13e069d1a4213b254ce389]

        LOK: differentiate page kinds in sd::ViewShellBase::setEditMode
        
        A follow-up to commit 4ff2e148fa25933e64b7bbecbcd3ed551ad686ab (LOK:
        differentiate page kinds in sd::ViewShellBase::getEditMode, 2024-06-16).
        
        Change-Id: Ib982c9ee45ca71445f09d56f9165bc33b43e8540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169313
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a7283a0eb880c5273ea48b0d1a6f881c4297b1a]

        libgpg-error: upgrade to 1.50
        
        Add external/libgpg-error/undeclared-environ-macOS.patch
        from https://github.com/gpg/libgpg-error/commit/a59e902b887fd92337c9728f668cf9c89da3957a
        to fix
        
        spawn-posix.c:345:5: error: use of undeclared identifier 'environ'
            environ = act->environ;
            ^
        1 error generated.
        
        on macOS.
        
        Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.50.tar.bz2
        
        Change-Id: Ica3a181626429da39651c29482326134ba25d556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169200
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [d2d973950bf35aa07251c77fae5b7283b4c91ea3]

        libcmis: improve Sharepoint authentication
        
        Sharepoint 16 apparently won't authenticate with NTLM unless the header
        "X-FORMS_BASED_AUTH_ACCEPTED: f" is sent.
        
        Change-Id: I13fe658a1fc5a18c22a49488dd634cbc07607aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169306
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [b02eb998c1f05ccb2c1e82f4ba24779398bce72e]

        uui,ucb: webdav-curl: display curl error message on connection failure
        
        Show this in the dialog, which requires extending DAVException to store
        2 strings for this case.
        
        Store it in the Exception::Message member of
        InteractiveNetworkConnectException, which appears to be unused.
        
        Add another UI string ERRCODE_INET_CONNECT_MSG so that the text can be
        shown optionally in the dialog.
        
        Change-Id: Iaf139d77051e7480113eb4df82ef40eb498f329e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169278
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [eedbe966bba1c070041b3a3ff836b4ef28e5bdaa]

        Embind: Fix C++ UNO exception catching
        
        ...with a new Module.catchUnoException JS function that can be used in a JS
        catch block to provide the thrown UNO exception as an Any.  (For a non-C++
        exception, it rethrows the exception, and for a non-UNO C++ exception it maps it
        to css.uno.RuntimeException.)
        
        The implementation reuses parts of bridges/source/cpp_uno/gcc3_wasm/, which have
        been moved to a new StaticLibrary_emscriptencxxabi.
        
        Change-Id: I708fe6121c43a1b9736de5dff449f6c4f32a45f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169325
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-21  Michael Weghorn  <m.weghorn@posteo.de>  [54f7308641c79d4907bd30cf6afc5bb62481637a]

        tdf#161648 sc a11y: Set a11y names for items in border style control
        
        Set accessible names for the items in the "Borders"
        control in the Calc Sidebar, "Properties" deck, section
        "Cell Appearance". Use the same text as is used for the tooltip.
        
        With this in place, Orca now announces what each item
        is about when using the gtk3 VCL plugin, instead of just saying
        "Button".
        
        Move the gla11y suppressions to the .false file, as they
        have been dealt with now, see doc at [1].
        
        [1] https://wiki.documentfoundation.org/Development/Accessibility
        
        Change-Id: Id1856e4b116acad9bf6d14132bc6d9c91a01ae06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169321
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-21  Michael Weghorn  <m.weghorn@posteo.de>  [ad3b33d01baaef1f1a950cd2c54d9649f0383446]

        tdf#161648 vcl a11y: Add weld::Toolbar::set_item_accessible_name
        
        Add API to set the accessible name of toolbar items
        and implement it for the VCL, gtk3 and gtk4 implementations.
        
        This will be used in an upcoming commit to set a11y names
        for the border items in Calc's sidebar.
        
        Change-Id: I958390d8736da8f1281f91586cacbefb5975e229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169320
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-21  Miklos Vajna  <vmiklos@collabora.com>  [0f165b7f2f03d806eb14ba7529223d31e30674a8]

        tdf#161708 sw content controls: handle font color when exporting to PDF form
        
        Export the bugdoc to PDF, the orange "date" lost its font color.
        
        This went wrong in commit 82d90529dc2b3cb8359dec78852cbd910a66d275 (sw
        content controls, rich text: add initial PDF export, 2022-09-12), we
        export the content control as a PDF form widget by default since then.
        Various properties like checkbox status and dropdown items were handled
        already, but not text color.
        
        Fix the problem by mapping the SwFont color to the widget descriptor
        color, this fixes the color of the already filled in content of the
        widget.
        
        Note that given this is a property of the form widget, the color is
        correctly applied also to strings filled in via PDF readers, interacting
        with the form.
        
        Change-Id: Id3e8611e415c0d571afe1cd14561c97b8a910ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169317
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [17d578ba91f9c78a0e41d19b58183d2214c0b7a4]

        Related: tdf#127293 Add new Match_mode option for XLOOKUP and
        
        XMATCH functions.
        
        Introduce a value "3" for parameter Match_mode for Regular Expression mode
        in XMATCH and XLOOKUP, to seperate the original Match_mode value "2",
        which was used for both, Wildcard and Regular Expression mode as well.
        
        Note: "The ODF TC will follow that in the specification of these functions and
        at the same time specify, that the host dependent properties HOST-USE-REGULAR-EXPRESSIONS
        and HOST-USE-WILDCARDS (file format table:use-regular-expressions and table:use-wildcards)
        will be ignored by these functions."
        https://issues.oasis-open.org/browse/OFFICE-4154
        
        Also Microsoft Office will introduce this new value for Match_mode in XLOOKUP and XMATCH:
        https://insider.microsoft365.com/en-us/blog/new-regular-expression-regex-functions-in-excel
        
        Follow-up commit: 0ca20dca3349daa303b89251443f550491968a39
        (Related: tdf#127293 Add unit test for xlookup regex search mode)
        
        Change-Id: Ibcbfa4cf227ab9a9d317d94c1bab8254b1f91822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169275
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-06-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d9d63ba76555c4cefea6ab5ff9caf21fc699d039]

        Don't expect _LIBCXXABI_DTOR_FUNC to be available
        
        ...as apparently happens to be the case with some older emsdk versions, see
        <https://ci.libreoffice.org//job/lo_daily_tb_linux_wasm/743/> choking on that
        
        Change-Id: Ie2f4b9684c794fdd51142eb81d96dd3332911272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169319
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [d32153d3217350b6646227d9239e3fd191e2b4c3]

        Make sure to clear the guard around OleEmbeddedObject::changeState
        
        The method itself clears its own guard; the caller still holding the
        guard results in hangs seen in some Java code.
        
        See also commit e2bfc34d146806a8f96be0cd2323d716f12cba4e (Reimplement
        OleComponentNative_Impl to use IGlobalInterfaceTablem 2024-03-11).
        
        Change-Id: Ib22e71e7500ccceb946f7b1d6606f8f61ae2afe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169315
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6958d226e6ce75c1b676ac041b5b59140c1f646b]

        Fix typo
        
        Change-Id: I05003d690d10ad03aa498a69063368e33340596d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169210
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-06-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c51d428510c855423c9e264e7eaa355f7c26a215]

        Fix typo in code
        
        Change-Id: I2d9c6e1c90c445bc6b2df257ed5c2e845225e987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169152
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-06-21  Kira Tubo  <kira.tubo@gmail.com>  [e5c55b2cfc47dcc5b711811fedc75ee982e3d46e]

        tdf#146468: Fix typo and move comments
        
        Fix typo on variable RID_SVXSTR_TABLE_PRESET_OUTER and move comments
        about consolidating border tooltip strings to solenv/sanitizers/ui/modules/scalc.suppr
        
        See comments on Gerrit for more information: https://gerrit.libreoffice.org/c/core/+/169052
        
        Change-Id: Ic5283e568e13023242858850dbce8922e2c80d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169308
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [151d997365f7bf271d63af535d29a9c3439c6d46]

        Fix translation
        
        Change-Id: I9a3fd130260b2db4a19830465035a51c25ace041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169219
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-06-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d5e00871def3d67be63a240991dd0888ff8ac3bb]

        Fix typo
        
        Change-Id: I7faabbb1906ce12978de4c8ddad7b1edf5bad4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169230
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-06-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f4ec967599f5dafa1ce477631d7c2e8de005e28f]

        Fix redefinion of Emscripten __cxxabiv1::__cxa_exception
        
        <https://github.com/emscripten-core/emscripten/>
        system/lib/libcxxabi/src/cxa_exception.h has two different definitions of that
        struct, a short one for when __USING_EMSCRIPTEN_EXCEPTIONS__ is defined, and a
        long one for the other case.  In 7175431a4b2154113c2c3c28f7ae8a8f14a84c7a
        "Implement exception catching", I had naively copied the short version, assuming
        that __USING_EMSCRIPTEN_EXCEPTIONS__ was something that sounded like it would be
        defined with --enable-wasm-exceptions.  But some debugging of actual exception
        handling now showed that the assumption had apparently been wrong (though I
        still have no idea about the semantics of that __USING_EMSCRIPTEN_EXCEPTIONS__
        define, and when it would or would not be defined), and that I had copied the
        wrong version.
        
        The relevant test code
        
        >         try {
        >             const ret = invoke.invoke('throwRuntimeException', params, outparamindex, outparam);
        >             console.assert(false);
        >             ret.delete();
        >         } catch (e) {
        >             const [type, message] = getExceptionMessage(e);
        >             console.assert(type === 'com::sun::star::reflection::InvocationTargetException');
        >             console.assert(message === undefined); //TODO
        >             //TODO: inspect wrapped css.uno.RuntimeException
        >             decrementExceptionRefcount(e);
        >         }
        
        in unotest/source/embindtest/embindtest.js had apparently happened to not cause a
        crash with the wrong version of __cxxabiv1::__cxa_exception, but had also
        happened to not detect the mistake due to the relevant parts being commented out
        with TODO (because, in turn, proper UNO exception catching is still lacking in
        our Embind-based JS binding).
        
        Change-Id: I718087c7ed2c17808696267ece17237d5cdf2f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169305
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-20  Patrick Luby  <guibmacdev@gmail.com>  [dd86e0a51a6539872f51a653580867bf0cfc22c5]

        tdf#161461 stop crashing by retaining NSString
        
        OUStringToNSString() returns an autoreleased NSString so it
        needs to be retained for the life of maOfficeOnlyTypes.
        
        Change-Id: Ic3777f818b7cada8e88e97965531fc0a7f2e825c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169284
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9288a75f716972bb5d65031c624cb22ea4cb8ee8]

        Fix build
        
        ...after 4eb9cde4db28616e0b0c9cd6825830ab7d2f3c96 "libxslt: uprade to 1.1.41",
        
        > external/libxslt/ExternalPackage_libxslt.mk:28: *** file workdir_for_build/UnpackedTarball/libxslt/libexslt/.libs/libexslt.so.0.8.21 does not exist in the tarball.  Stop.
        
        at least during an Emscripten cross-build
        
        Change-Id: I7fcde7f8708fba68d5d9b751420e402c5da41f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169280
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Miklos Vajna  <vmiklos@collabora.com>  [b49c6551fcdeb2ff9c965fcbe885344f5f108e59]

        CppunitTest_sw_writerfilter_ooxml: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23):
        
        - sw/qa/writerfilter/ooxml/data/recursive_header_rels.docx: Aptos ->
          Calibri
        
        Change-Id: I6bcf3f39861426f2e94d0d88e301007501636e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169283
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [431e3d8a525de715b967e8b7ecee53a5acc6bc4f]

        Fix typo
        
        Change-Id: Ib6bfd1938d8d2da3d3aa9ccbb7b80750c4671f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169279
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-06-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [04bd09866f656bd265f5631297070dcf14c5f77f]

        Fix typo
        
        Change-Id: Ia197c0eb16227f1dbee0c0eef65d4c2821edfa83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169170
        Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [321284dde91854a7583c11a207da3bb94691d12d]

        -Werror,-Wunused-function
        
        Change-Id: I11af8dfbcdda6bbb77f2ccfaf2c994492bc3f807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169282
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Michael Stahl  <michael.stahl@allotropia.de>  [21279261fda69855924271230e3ac736615fc95c]

        ucb: webdav-curl: don't mash together HTTP_CONNECT and HTTP_TIMEOUT
        
        First a DAVException with DAV_HTTP_CONNECT is thrown, then it's
        converted to USC_CONNECTION_TIMED_OUT, then that is converted to
        DAVException with DAV_HTTP_TIMEOUT, a bit misleading.
        
        Change-Id: Ie5089d67d363f57eaa9e1ed057b36adb41e846d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169277
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [1be12e6d298a1e22871cdb9eecb7b6440b0d1d88]

        tdf#144208 speedup doc with lots of redline(13)
        
        Add a custom method to SfxItemSet, to avoid some of the function calling
        overhead in a hot loop
        
        Change-Id: I525c9a696af941c6e39aa1677eb2a85f69c621bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169271
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ab4c442a57686eae47a9d9f06d3662544aa591b]

        tdf#144208 speedup doc with lots of redline(4) II
        
        exit early in DelBookmarks if the redlines are not in the range we need
        to fix
        
        (Second attempt at landing this)
        
        Change-Id: I371623ad5840e56bc4ed80565befc7b26e3f5e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5a7ae5989cb05f3121a9fe1373c3f23a7b00ad6]

        Update git submodules
        
        * Update translations from branch 'master'
          to 755fc723ca53063e9481f8ca26b14e6b00d46d38
          - update translations for 24-8/master
            
            and force-fix errors using pocheck
            
            Change-Id: If076c515de168ad573ccd927faf405d15c6dff34
            
2024-06-20  Michael Stahl  <michael.stahl@allotropia.de>  [af79ac4bf4a27e2d77e60b64049de21102a8ba85]

        libcmis: don't retry if the connection failed at TLS level
        
        ... for example due to bad certificate; it is pointless as it will
        fail exactly the same way.
        
        Change-Id: I654261b2691987453e4ac9a3e2f3019dce20da48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169268
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Michael Stahl  <michael.stahl@allotropia.de>  [31ac510f0d8e8cb79d564c147ccf7265894cdcda]

        libcmis: fix UAF on invalid certificate
        
        headers_slist may be used again on the 2nd call to curl_easy_perform()
        in the CURLE_SSL_CACERT case.
        
        Change-Id: I146d7f5dd72e2abd580a68c8ea4c9e56b7adeca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169267
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a611a5d1078631cf49b78c7c30b3046329b503f6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1178a2c5645336fa720a1fe6cc023df8a8e7895f
          - Update term Organizer -> General in swriter/ pages
            
            Change-Id: I33ac397dd8c1f831b832c9d385a14e236853a9de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169273
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [022ace59fa76a7ca6aa0e73fa276197ea569d633]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b0425a000fa79d8152652b031c1be8d3d3b2af56
          - Update term Organizer -> General in shared/ pages
            
            Change-Id: I455cc5e0f115638fb1c9312db8d8cd50e7b1b0cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169272
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [fb8f4b57ceaa2462cd966de7afeb0971a655f647]

        DBTestBase: Add createDBDocument
        
        it can be used later on when porting the java tests
        to CppUnittest
        
        Change-Id: I17420fdf490d979392f5aeb90c3b3bfb319d7764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169274
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [39714d3e66f92954ed08b817d56947f555054567]

        CppunitTest_dbaccess_embeddeddb_performancetest: use maTempFile
        
        Change-Id: Ib63008ddaf9aeb0ed02dd5cbc9680eda2cefbfac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169269
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-20  Heiko Tietze  <tietze.heiko@gmail.com>  [ec5e0d0cd7074a912415761f779b00f8b7117fcf]

        Resolves tdf#64028 - Command to retain source cell on cut
        
        .uno:CopyDelete copies the cell and deletes the content,
        assigned to shift+ctrl+X
        
        Misses to block the command while in edit mode, see tdf#161712
        
        Change-Id: I479008b0484ef8ced86b709a0dc2bdbfa6c44cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169266
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8730575016b15da4892c5adc0d26620688d174bc]

        tdf#161469 - Basic: align implementation now with the now function in calc
        
        Align the implementation of the now function in basic with the now function in calc to include the also nanoseconds. The precision is limited to milliseconds to avoid comparision inaccuracies.
        
        Change-Id: Ia85b653898f5849f67a171749725faab976b2a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168706
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [4eb9cde4db28616e0b0c9cd6825830ab7d2f3c96]

        libxslt: uprade to 1.1.41
        
        Downloaded from https://download.gnome.org/sources/libxslt/1.1/libxslt-1.1.41.tar.xz
        
        Change-Id: Ib06a013d85cc47a901fbe55a880f3ad6a5edcea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169265
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6289ad39e851c709111b582e4390a097b30e2cae]

        annot: clone annotations in SdrObjects when the page is duplicated
        
        When the page is duplicated we need to clone all SdrObjects and
        with that also all the annotations contained in the SdrObjects.
        The annotations must also be added to the page, so that we can
        find them quickly.
        
        Previously we only cloned the annotations and relied that the
        SdrObjects would be automagically be created, but as the SdrObject
        are also cloned this creates a mess with duplicated objects with
        annotatins for the wrong page or annotation objects with missing
        annotation.
        
        Change-Id: I4bf53e4bd387fad9b0a8e4f43edd57c3d0fd34cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169256
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit c3281e071526f7efa9b7646a993476fc3f6ff8db)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169260
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [51dfbb1fce61dfb2e1d4c91350d2299e6dc3e04d]

        tdf#161219 Exporting XML filter as package results in empty jar
        
        regression from
            commit a04bf69bccfbc266643b418ef57030a42bbb5c05
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 16 10:36:59 2023 +0200
            XUnoTunnel->dynamic_cast in ZipPackageEntry
        
        Change-Id: I12915bb093ea050f4290c02cc5a6e1dc2c7b903a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [86a827da7c71305be81624d25220d125ef00137a]

        loplugin:unusedfields
        
        Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [50f3443d59d457da8dd19e0520f317851f050469]

        pdf: remove CHECK_RETURN macro from code
        
        Doesn't help with code readability and makes code more complex.
        
        Change-Id: I0c1dc421d5fb173e610ab303d7c4f707dc65a093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169203
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-20  Martin Srebotnjak  <miles@filmsi.net>  [635add71c428eac6f4c080307b19c4f2cb63e889]

        Update git submodules
        
        * Update translations from branch 'master'
          to cf2e53f45d2727aa4c1b587362eb2e5f1a83f498
          - Updated Slovenian translation
            
            Change-Id: Ifd238155fe7ef5bd93520acb24c0c4f7ad659313
            
2024-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4aa2cc878dae3b34b16ccacd9358fda5e6d6a197]

        loplugin:unusedmethods
        
        Change-Id: Ia216da9bd7764f2d21aaee761a02eafda88d892e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169257
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-20  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e74a5bea04483dc96ef6d4b34edd8735ec73bcd8]

        tdf#159906 - A11Y: Add new direct character formatting group level
        
        for Formatted warnings and keep them not expanded (default) to avoid
        to many visible warning message on the sidebar.
        
        Change-Id: Ic251909d793198c3c4ce5e132b763c15ac1c9a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169110
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-20  Szymon Kłos  <szymon.klos@collabora.com>  [494161a9c8a9acca4d200d06c44ef6db794c0bea]

        cool#9309 lok: sync language in comphelper::LibreOfficeKit on view creation
        
        If new view is created using createViewWithOptions API call
        we pass language of that view. We do a setup of that language
        in SfxLokHelper::setViewLanguage but it was only set inside
        ViewShell.
        
        Unfortunately just after we create the view we call setView which
        later checks if comphelper::LibreOfficeKit::getLanguageTag()
        has matching value with ViewShell field.
        It was showing warning in the logs:
        warn:lok:31748:31654:sfx2/source/view/lokhelper.cxx:206: LANGUAGE mismatch at setView! ... old (wrong) lang:de new lang:fr
        
        Let's check if the view we try to modify is the current one and
        in that case synchronize value we can get using global
        comphelper::LibreOfficeKit function.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Icddfda003522dda661066c4d1c43ca1dec9e5c55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169107
        (cherry picked from commit 800d8580ec8d99f5c610727a9d53ab143019c014)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169144
        Tested-by: Jenkins

2024-06-20  Miklos Vajna  <vmiklos@collabora.com>  [afb4ea67463d9f0200dc6216cfd932aec0984c82]

        tdf#161652 editeng, RTF copy: only write used paragraph styles
        
        Copy a single world from the Impress bugdoc to Writer, number of
        paragraph styles increase from 126 to 221, while only +0 or +1 are
        expected.
        
        It seems the problem is that the editeng doc of the shape refers to all
        styles of the masterpage and we write the style table before the
        content, so we export all styles to be on the safe side.
        
        Fix the problem by iterating the paragraphs of the selection in the
        "copy" (not "export") case, assuming that typically the selection
        doesn't refer to all available styles in the document, and the number of
        paragraphs in a shape is not a large amount.
        
        An alternative would be to limit the style import on the RTF reading
        side, but not producing those not needed styles in the first place looks
        superior.
        
        Change-Id: I43e4c542e530ff6422357a28399718e89fdbabe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169251
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [41d26f14fffdb701f6e7ef459a11577725cd0d27]

        tdf#161653 Fix selecting from numbering dropdown
        
        Change-Id: I5ba2133395619ec96b32940a6ceddf0c32615a03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169252
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [63b46c2136d95960bab30a15e27bc94e6eefe6e6]

        rtf: Don't export changes author/date when in privacy mode
        
        Change-Id: Id8f8dea4563df3cfb0ea9009783886bdabf91b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168996
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-06-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [16c7a6f77e59c475bbb580ef1fd85428907a00f2]

        rtf: Don't export notes author/date when in privacy mode
        
        Change-Id: I6dd318fcae9470bb8fc911a8b4d7ff7c7d8f9636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168984
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-20  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [baf95a7e8e7312891aed73adb26de74e5bc9ad62]

        Resolves tdf#153223 - Suppress variable line height when skia is off
        
        Change-Id: I9194c25bf2fc104574bd27e6b8683b63111e6ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169192
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-20  Kira Tubo  <kira.tubo@gmail.com>  [14231e45ce5c8f2615fc5a448479960dfe1ed22b]

        tdf#146468: Match border tooltips in toolbar/sidebar
        
        Update the border tooltips within Calc's toolbar and sidebar so that they
        have matching descriptions.
        
        Also update tooltips in Writer toolbar so that descriptions match across
        both apps.
        
        Change-Id: Ib7c682ed5035fe61d991209c4f2cf7f0a1a08a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169052
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [dd6bc1243af8d20cb19c96598f805cc6c9703ce7]

        qt opengl: Drop superfluous check
        
        The `m_pChildWindow` is created in the lines
        above if not set before, so there's no need to check
        whether it's set. Assert instead.
        
        Change-Id: I1058897bc423b24be0f92c4dcc59c18801da45bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169243
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [1bde8595bde911063f200e9aac6f1ade87d4ad59]

        tdf#161648 sc a11y: Set a11y name for border style button in sidebar
        
        Set accessible name for the button to open the popup
        to select a border style.
        
        This is announced by Orca with the gtk3 VCL plugin
        when the button gets focused as expected.
        
        Setting accessible names for the items in the
        popup still remains to be done, s.a. discussion
        in pending Gerrit change [1] that's related.
        (If that gets merged, setting a11y names should
        probably be done in C++ code, not the corresponding
        .ui file.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/169052
        
        Change-Id: I200e160e64735e8701866428bf51e8b955dcc930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169188
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [daed96f0818b1baae5de8b74b866009d7d89f853]

        tdf#159835 sfx2: Keep sidebar menu up to date
        
        No longer update the menu for the menu button
        in the sidebar in the handler that gets called
        when the button gets clicked, but continually
        keep the menu up to date instead.
        
        This ensures that the menu is up-to-date when
        it gets shown. Updating the menu in the button handler
        is too late since
        
                commit f075fa01cb4f74185f13eb0a8d7f84cf1f47af49
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Tue Aug 22 10:26:32 2023 +0200
        
                    tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        , as the handler is now no more called before the menu
        gets shown.
        
        Do the update in method `TabBar::UpdateMenus` instead
        and call that one whenever items change or the
        sidebar gets docked/undocked, as menu entries
        are shown for the items and for (un)docking.
        
        This makes the menu show all entries again
        when opened the first time after starting Writer,
        which was no longer the case after the
        above-mentioned commmit.
        
        Change-Id: I9a7e341e88d2de5f34e8f85ebada3ff2ebf6b47d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169196
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [c2c6a5d32f8c536ab816630583f986860202c4a9]

        tdf#159835 vcl: Notify when floating window toggled
        
        Notify listeners using an `VclEventId::WindowToggleFloating`
        event when the floating mode was toggled in
        `DockingWindow::SetFloatingMode`.
        
        This will be used in upcoming commit
        
            Change-Id: I9a7e341e88d2de5f34e8f85ebada3ff2ebf6b47d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jun 18 13:41:03 2024 +0200
        
                tdf#159835 sfx2: Keep sidebar menu up to date
        
        to react to that toggling.
        
        Change-Id: I5286ab727c30d4dd4bbc3cf5d42f19ff649b39f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169195
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [504e5501fce3f53d15b53f344c20e4404ff8f3db]

        tdf#159835 sfx2 Connect SidebarController menu handlers earlier
        
        Instead of connecting the SidebarController handlers
        for handling activation of `TabBar` menu items
        every time in `TabBar::OnToolboxClicked` (which is the
        handler that gets called when clicking the menu button),
        do so once in the `TabBar` ctor.
        
        This also ensures that the handlers are connected
        before the menu shows for the first time, which is
        no longer true for the previous approach since
        
            commit f075fa01cb4f74185f13eb0a8d7f84cf1f47af49
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 22 10:26:32 2023 +0200
        
                tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        Now, clicking on the sidebar menu and selecting the
        "Undock" entry works to undock the first time, not only
        when opening the menu for the second time.
        
        Populating all menu entries before the menu gets
        opened for the first time still needs to be implemented
        separately.
        
        Change-Id: I7e5d5e511c2ce2c7304e8f88676970d76e6319df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169193
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [908334f85ee9ecd1d7aa4825e25c48a59516f804]

        svx: adjust the values for impress/draw ruler to work with LOKit
        
        The values in impress/draw don't need to be converted to 100th mm
        as the vales are already in 100th mm.
        
        However the null offset and page size needs to be adjusted,
        because in impress/draw the actual document doesn't start at 0,0
        but there is one document width or 1/2 document height margin to
        the left, right, up and down of the document. So the null offset
        returns the number of the document width or 1/2 document height.
        For LOKit the null offset needs to be subtracted.
        
        Similar needs to be done for page width and height. The page width
        is docuemnt width * 3 and page height is document height * 2. So to
        get expected numbers for LOKit, the page width needs to be divided
        by 3 and page height divided by 2.
        
        Change-Id: I8d5561d5273b4bbeab475565504fa64c7f882fd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168276
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 54d8c1b8f2934d6196a8b19400879fb6b67c255b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168986
        Tested-by: Jenkins

2024-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [66247fe7bdb089a897f9a02b96c888b92b67154d]

        svx: move lok's NotifyKit in the ruler to the SvxRuler super-class
        
        We want to make the ruler work in other components and also not
        only for horizontal orientation. For this we want the NotifyKit
        already in the SvxRuler, which is used by all rulers. This change
        moves the functionality to the from SwCommentRuler to SvxRuler and
        partially reverts the previous attempt as changing the ruler
        instance for vertical ruelr to SwCommentRuler caused test failures.
        
        Change-Id: Ie618b5dc5b936f9dc53d09b624eefdbc506d98f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167740
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 9f26e04c8f97af9139e2f4be335fe6999d26a387)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168985
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-20  Michael Weghorn  <m.weghorn@posteo.de>  [d7aeaeafc32f78ca38942868f965bae0e6c376b1]

        tdf#159835 Deduplicate a few lines in DockingWindow::SetFloatingMode
        
        They're the same for both branches.
        
        Change-Id: I73c3433fe3cfbb3eaa1b25cc2a76613d59d894a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169194
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-19  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [7e13d34086d67ecfe47db5a85a4877b5ba96f874]

        tdf#160490 PPTX import: fix automatically resized placeholder height
        
        See also commit Ia7f94d7452d1a1c3f004aebd73b6ed5cbfd9b43b
        "tdf#157285 PPTX import: fix placeholder height".
        
        Change-Id: I6203af3fe86a60e29121685ffeb435f4ff25368a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169206
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f788fe2811c651228322aa71098d739210980148]

        Fix typo
        
        Change-Id: I5a95344bc561e13a34ec558225f6ce8fc43dfb4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169211
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [50e8f3a076b66c844f38b0f15e61dc9f397f4ca5]

        Fix typo
        
        Change-Id: I9bac90a35b82367ba5e6a543e3567b5304cc276b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169212
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [07a84353fbff4e681b0d64d64d6789caaa5b15b2]

        Fix typo
        
        Change-Id: I84a64e6a2e90d462ed7eb5fe4adeb3c6966c91c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169215
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d09a6808fecc9c3df40631e5a9e1f482e2a4d75d]

        Fix typo
        
        Change-Id: Ic19939f0601ec60ca002da9aa02d0974f2db9ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169216
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fda1827a74fa21e39d3fa66d7bc561f587823f1e]

        Fix typo
        
        Change-Id: I517be535c68037fb92a44ed52f59be115fcef129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169225
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3d6100fd048f6bef6a80f2c3b652987a73bc1ce3]

        Remove useless semicolon
        
        Change-Id: Icc37bef413799c3e11af993e36455c30e6f67d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169213
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b73771b169bb1d95093e1e202ba5c0a283f245cc]

        Fix typo in code (maybe...)
        
        Change-Id: I398d0560d9c0ef3ec3062cea0739175154ee046d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169221
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [62f74053eabe79980aaa69292c630dd671d2a236]

        Fix typo
        
        Change-Id: If0583a49b417b7bb913201a1ccb4ab539856e389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169220
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fad225678a91d5852bb0e2b399f172a11785d5c7]

        Fix typo
        
        Change-Id: Ib6087b4ae41474926139f9e4d8b1b1244746938e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169224
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb7bff32e7f2bb5cdddb1f7d450c1612ff6386f3]

        Fix typo
        
        Change-Id: I498add76660119e80fae0bb48f1b60739c08578c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169222
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [52aafb61afc45677e5c9f17f791c75f9a2ba5941]

        Fix typo
        
        Change-Id: I6dc27f359ac5b9993d794c15c96712d95c4d476a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169235
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [29c32b59d5c0d91d28ba5086ee253fa39a784440]

        Fix typo
        
        Change-Id: Iee7b1093d5e426fb956229e9d5a57f4e1f163a06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169226
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [796863113f8c981ed93cfa22ee45878d8429ed85]

        Fix typo
        
        Change-Id: I832fe265269f8735903ffdf011f15e2bbd51bc7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169234
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0989bc478e75e466509b09905e5286cffd1643c9]

        Fix typo
        
        Change-Id: I0b82778c57b0da2dc4f1e685349d5f423a3d4090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169241
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d1c271bdbadd07681c59dd58fa05d0bbe84be139]

        Fix typo
        
        Change-Id: Ic6be6e966787bf03072adb02908e04e8c5616dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169233
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cdcc76802d7dbdc78c344d25b754125ba161e8ad]

        Fix typo
        
        Change-Id: I30c31ea6c17bd4a27109d2dfb641b9cb5d6922a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169240
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eb08a328843409acc1e0350a8b440b080de4bb2d]

        Fix typo
        
        Change-Id: If2717fd1d82bb6e017a55f9b29b2af60ab57a835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169236
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9a86b1f336ffca2910428dc0df4ab26c7d0f5846]

        Fix typo
        
        Change-Id: I3bcbaa4005e65ecdb8d1344a792a465b83aec9fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169237
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a725356d1fe160dcb6291d63275f2ab37891f348]

        Fix typo
        
        Change-Id: I04f646e812b9c8dcf1a0e207529ece61a74de00d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169239
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [264bfc974d3e6f7f2bb50ce231a4d2792782596d]

        Fix typo
        
        Change-Id: I7a3ee45fd6e52f3313c69da15b1eda75e3b21c67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169229
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3ee6d513b3b0988219e47d0ea8546c605291682a]

        Fix typo
        
        Change-Id: If2eb7ee036a06d23a4b82ab474244efcbcbf2905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169238
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1822d3ddf3d9618af946deb6986bc1bbc403b5a6]

        Fix typo
        
        Change-Id: Ib728d9c9f8e2b319123f1d7ee7b807760e9d3f2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169227
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bace77df5d6e65a4bdb5da1510ca4a05d5a015e4]

        Fix typo
        
        Change-Id: I8f9ac262bf47bdc2f0d7937502e62b79118255b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169223
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cc33a630ee6eb9b9f47501c3c0cf9dbacbc214a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba5e40d637b9dac0575f982d48666bb45423c628
          - tdf#161638 Update Calc View options Help page
            
            + Added images of visual features
            + reordered dialog section description
            
            Change-Id: I8cb7158b7e88b55f686372b8e790e0165a25d8cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169232
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e56a8300d36a7998e492e87bc514d14d931cf01d]

        use gb_StaticLibrary_WORKDIR and gb_Library_DLLDIR more consistently
        
        same for gb_Executable_BINDIR[_FOR_BUILD] and fold
        gb_Library_WORKDIR_FOR_BUILD into gb_Library_DLLDIR_FOR_BUILD (the
        latter also has a workdir variant)
        
        Change-Id: If7e4cf9aab46728182c89344546065bc33b452b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169201
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8ddd3f1c9faa3338703217967bae5c363df0e45]

        Revert "tdf#144208 speedup doc with lots of redline(4)"
        
        This reverts commit 5fe53e6b2e951f2f8f834386827bf96610d6acb6.
        
        Reason for revert: crashing reveals a SwContentIndexReg::~SwContentIndexReg assert
        
        Change-Id: I68554db3e62b7a20f105369eb9b09b7c27dc853d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [38f16494f8555bd3d0713095ee240468564700dd]

        use local var to simplify code in MsLangId::getScriptType
        
        Change-Id: If3b0709cb2d755ac4e031e2c14d29a1e49fe603f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169202
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-19  Michael Stahl  <michael.stahl@allotropia.de>  [ef77086255821d61838a7e26fee9baadaca0b9e0]

        tdf#161631 writerfilter: move another member to SubstreamContext
        
        The problem is that the bugdoc contains a table in the footer, which
        causes m_bDummyParaAddedForTableInSection to be set, which erroneously
        causes the last paragraph in the body to be removed.
        
        (regression from commit 86ad08f9d25110e91e92a0badf6de75e785b3644)
        
        Change-Id: I148785c54c37dc25f7d239b5898aec9fb5455f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169191
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0740c9cde9ad77a2fbdd3429be1fbd98e1943fd4]

        makefile simplification: replace $(call gb_AutoInstall_get_target,foo)
        
        by a simple/static $(gb_AutoInstall_targetdir)/foo and also drop the
        custom .dir target
        
        Change-Id: I4893c2675cb076cb8a0b61c0c207a223658b43d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168709
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-19  Sahil Gautam  <sahil@libreoffice.org>  [86cd6036273a9031212e131141c03ed4e16e011b]

        tdf#159543 - Proper feedback needed when resizing a frame...
        
        When autosize (a frame property) is enabled, then the (text) frame
        manages it's height/width based on the content such that all the text
        is visible. The user cannot decrease the height/width to be less than
        the content height/width, but the resize  handles show up, and clicking and
        dragging is enabled, which shows a blue virtual resize frame.
        
        This patch adds UI feedback mechanism such that if the drag leads
        to some change in any dimention of the original frame, then the
        frame color will remain blue, otherwise it turns red.
        
        Change-Id: Id4b3e3ae2c9864154e6028ca03008261bbc3e1b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165817
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b344a611d7636d4fdf8cf221fb7b8bcfdcdb6824]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e6ef90ff763ee24c62f15dd4a312020a04b93655
          - tdf#161579 Fix on Save options Help page
            
            Change-Id: I58f37e50d5579b76b2b4b95a885ae2ef9e6856c2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169126
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-19  Kira Tubo  <kira.tubo@gmail.com>  [59540d082f4f2ef72b3b8728f5fa2ec8a1bb4fa0]

        tdf#62603: sw unit test: replace string mix font style
        
        Test to see if font style is retained when performing find/replace on
        strings containing mixed font style/sizes.
        
        1) For example, with a doc containing the string: "test
        - Normal font: "
        - Italic font: test
        
        2) Search for: "t (this contains both normal and italic font)
        3) Replace with: "gu
        
        4) Resulting string should be: "guest
        - Normal font: "
        - Italic font: guest
        
        An additional test has been added to test for changes in font sizes (per
        comment 24).
        
        Change-Id: I957077efbcced0b981c31d0e547299e12a61609b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168486
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [81ac96498691f899ca521aa124d5e8425586819b]

        Consistently 'use strict' for JS code
        
        Change-Id: I6f6e06ad32ffa87242f5a0f41c176149b754e2ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169187
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5feafc1e2089a715fa94f206204cec73d58c189a]

        Fix typo
        
        Change-Id: Ifc1cbeec10fabd83ab3461e9a8c268c7f3b84f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169161
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Miklos Vajna  <vmiklos@collabora.com>  [61692b82ae4ff62662509b5979a7aabc7d380678]

        tdf#161635 sw DoNotCaptureDrawObjsOnPage: fix handling of left padding
        
        Open the bugdoc, the shape has an 5cm left padding for its text, but
        only 4cm of that is visible in Writer.
        
        Checking the shape, part of that is outside the page frame, so the first
        1cm of the left padding is not visible, visually resulting in a 4cm left
        padding in Writer, but not in Word.
        
        Fix the problem by extending SwFlyFrame::MakePrtArea(), so in case the
        shape is partially outside the page frame, then we make sure to increase
        the left padding enough that the nominal (5cm) left padding is inside
        the page frame.
        
        With this, the text on the title page of the document is visually
        centered also in Writer, even if not using an explicit paragraph
        alignment.
        
        Change-Id: I5dcbcf407ed7f12f0bc13820fa39621a76e23fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169186
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9bdb7ce3a9bdc039f0f81f09547ac40c5c330ba2]

        Fix typo
        
        Change-Id: Ic182dcf4a1e258d9a7cd450ca45f514a7fb7f262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169175
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-19  RMZeroFour  <ritobroto04@gmail.com>  [e597e712b6e1c199a6241df3c29f35baeef9f457]

        .NET Bindings: Add netmaker (.NET codemaker)
        
        This commit adds the netmaker executable to the codemaker/ module, to
        generate C# code from UNOIDL specifications.
        
        Also adds some Makefiles in the net_ure/ directory to generate code for
        udkapi and offapi, to build the net_uretypes and net_oootypes assemblies.
        
        Change-Id: Ifb61fe6a0f8f594eaa6ff95b025ba57f247b0d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168710
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-06-19  László Németh  <nemeth@numbertext.org>  [64365dfa67d5a1d8fbc710238a4ea9c492645de4]

        tdf#161643 sw DOCX import/export of maximum consecutive hyphenated lines
        
        Fix line break interoperability by importing w:consecutiveHyphenLimit to
        ParaHyphenationMaxHyphens, and exporting ParaHyphenationMacHyphens to
        w:consecutiveHyphenLimit in OOXML import/export filters.
        
        Change-Id: I5f40bcff34ebebeabc0de9898955abda4dc34cde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169127
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cd8cab9c7662800e7cd28f79e8e3b40f60b96b5b]

        Fix typo
        
        Change-Id: I80dd506275bf8032316bba5eff152635e62268d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169150
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ee4cdfb6fad52779030cf9c9d75d6218e077b997]

        Fix typo
        
        Change-Id: I2044da5e2b973f410531fee8d2b24a59c6279fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169128
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e34d63230cb6ec45f4c547dc8f3be2dcc8f84dd3]

        Fix typo
        
        Change-Id: I8613fc1be864f79af407f66b486f0e9cab9862db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169129
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4a85d3c12ade35e49d90eec72152d1779abc8de7]

        Fix typo
        
        Change-Id: I91c9d457aa7b0675df59415416121d2e21c78c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169153
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e864b49deb25658ecc92d3a0e723c4103be3694]

        Fix typo
        
        Change-Id: Ib82dd3d35d0fab5815c97a7c5f93592598ffaeed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169151
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [839cac2c7021ab6ee03a98974bc1c5034973c8da]

        Fix typo
        
        Change-Id: Icbcac3a6a69ecf8d958f7196bfde46ed32dc703a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169154
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [41559f8c52ae2d91b886fe510cc34c0bca334c27]

        Fix typo
        
        Change-Id: Icd8c5e8101d112d76da23f877c55c9627438e179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169184
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [58ef023d63bb4a37ac3073fbb6bf49d807c99888]

        Fix typo
        
        Change-Id: I30f0d9517bd244606ce596fbb88da1cc6ed54cd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169162
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a9b462758b0b66bba4e192300565265d613e16a1]

        Fix typo
        
        Change-Id: I4750989bffaa95c652fe5f90962342638296b026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169156
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [602e00b9610cdacc078846bb845c306df65b29dc]

        Fix typo
        
        Change-Id: I99c1b5973e8a173f4b4fefe588f0bef825f2444f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169183
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a1c7ff92d2d2299644ae082a152a0878417102b1]

        Fix typo
        
        Change-Id: I77229760404a8739755508a5991d00ce0ceed8d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169158
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [677366d3c9992b56b2b8c5278b29e694e0d8bfd4]

        Fix typo
        
        Change-Id: Ifae040774dff2e75d4ddcfd38e8e67192f70d69a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169160
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6ecadb3ed3a9e597df31798a0d899a792d71f9ed]

        Fix typo
        
        Change-Id: I4603be77e1d69a3e7d26946d656ef008d64836db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169159
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7cfefdd01bd79b517338a2e63c0ae55d9ff67e4a]

        Fix typo
        
        Change-Id: I633ad7aa1a8167795e76bfacfaeec9a42b9db3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169157
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [05f4724aab004ec057563a80911500bb7ce1a108]

        Fix typo
        
        Change-Id: Ibd328464edc6e3906c2ad3155e3d9f6ae4ef2641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169155
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [59cfd8f4f69bd5918cb704b0a38b73ea2c9831bf]

        Fix typo
        
        Change-Id: I69c4e0794217e25ec15c953421c838d124b7d2f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169167
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9539ea2c9129433c60ffa2848d7fe28a2ee074a6]

        Fix typo
        
        Change-Id: Ie1a1e7b6da8303d3811df32d2ed524576c6be29e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169164
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [758f1230f8b9dc96ff6f121f8ee5e88d5a3854c0]

        Fix typo
        
        Change-Id: I0a68063a64d0a80b521cd69a1abf146476f27bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169169
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [637072a9b6d27cc7c8c5461f75bad021c726a9b7]

        Fix typo
        
        Change-Id: Ia7e36299a15fd4096f2e8e50efad2e8e1b61bec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169166
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2eb9a61ca9d4c5f59bab5158e0fa97ed96899b44]

        Fix typo
        
        Change-Id: Id2140f45ea676324094741c331c4666ee74aea04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169163
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [664167bb248ae07dc5fa5af102de50568a846abe]

        Fix typo
        
        Change-Id: I782d794bd4acc760ec53e226796a4ac0424fd0d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169168
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [382b4e0a08257efdffa972f832598d28430042d7]

        Fix typo
        
        Change-Id: If21c8e5bf48da78b505f826513673c5da0df2538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169165
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a0fa7f8245d207071e25e2f6b7268becf7cb49e4]

        Fix typo
        
        Change-Id: I5db57545327b839f71676aadcc688eb8bc26b8bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169172
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bbf9d0a9345e1b91c44e605feb1dcb109eecff1e]

        Fix typo
        
        Change-Id: I080533a791c8ad0034b4b24ea630c6ab7265e31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169171
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dbfa98d162e6327e1c01fc6f1918306171503c09]

        Fix typo
        
        Change-Id: I339f7b48db82d52faea5343412554c4c4939068e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169181
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bc1ed15460aff7e84cb198d7552fdcc5eb9fc15b]

        Fix typo
        
        Change-Id: I4df37ec7637c4b9719ea77e48f9fc49e2ff6fc54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169180
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e07e5e76f43a1ababb8ccdd1596473b95c71be32]

        Fix typo
        
        Change-Id: I392dc943c4a423ca6bd7c3a3efd2a68adb75bf1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169176
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef38bc24551a4d344c5bf1d528534fcf6977e560]

        Remove exec bits on docx file
        
        Change-Id: I8aef24c3536493ab73df7637990c48a2c94c2bf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169182
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e5f1b4cdec3802df5e2bd824089d6c18b58a3689]

        Fix typo
        
        Change-Id: I33b497fd707e5100d0a03cf9868b0627859922ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169178
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c499b6af566ad4c51a3b1ce1a90115b7556c3e52]

        Fix typo
        
        Change-Id: I5d7c48261ddf6f36c35c8ee84e7bc98f32dd83bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169177
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e9cc36ab1051d016074f2275a79f96694e198d67]

        Fix typo
        
        Change-Id: I7ee174497b9f6ca7256ef71297c20c04b52ecae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169179
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3909a1186cf423105c30c91136f131daf66e18c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88885d0ae30d7d89219d86d263b1a31d77fb6de0
          - tdf#191639 Fix macOS command path
            
            + refactor
            + moved command description above how-to-get
            + added tabbed UI how-to-get for Expert config
            
            Change-Id: I026ef0f1891c18ea50ce187b6fba35dd5a194ac9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169119
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [996558b30209c8c43f13e247d35204bee1b48627]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 840359bcb401b17e55a0370a9a0d15890a824abe
          - tdf#161579 Further rework on Save options Help page
            
            + refactor
            + removed outdated screenshot from page
            + deleted outdated screenshot from build
            + change paragraph tag to a tip tag for better reading.
            
            Change-Id: I8ec7330ffe501e7b68ee1ccc9591e45dbe35c05b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169116
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-18  Justin Luth  <jluth@mail.com>  [47af7ba63ce7f5c47cfef74d4606c0d8e92f7894]

        tdf#161579 userautosave: fix wording to match 24.2 implementation
        
        The implementation changed with my LO 24.2
        commit 63bb760acc8aa50c352f3349e8adf3db381b4911
        https://gerrit.libreoffice.org/c/core/+/155273 for bug 57414
        
        When the document successfully saved, there was no reason
        to create a recovery version of it immediately afterward.
        
        Change-Id: If62b9c60cf6b39d25ee42001eb6344593479c716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168897
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-06-18  Oliver Specht  <oliver.specht@cib.de>  [52b95cfbb0aba120229f9f92570f2aa6f1fe3e33]

        Add warning and progress to AutoFormat
        
        Applying AutoFormat to large selections may take really long.
        A warning has been added to warn users.
        Additionally a progress is shown while AutoFormat is working.
        
        Change-Id: I74909a6243748ebfe0089406ebe947bb48eb93d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167950
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-06-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4b80b643c142d3e5c9e47c091c95155246d6d0e3]

        Embind: Add the lifecylce fix also for attribute getter return values
        
        ...which had accidentally been left out at
        04658a706757dabbedfd87717e6f1f354b4c8961 "Embind: Fix lifecycle of UNO any and
        sequence values returned from JS to C++"
        
        Change-Id: I7ec1766850049cb5032020b65ccc171027f739b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169113
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [cac37fefae32fc6a0df2c579e08619568087af81]

        tdf#131562: move test to svl and extend it
        
        based on the commit message from 7186541219599e1b51ad35601c2cd015a329f360
        "Resolves: tdf#131562 decimal separator may not be surrounded by blanks"
        
        Change-Id: I19c2a687663304003566e9d93504f0baf33f1d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169111
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [60fb7edc6dc485870b944e5981dd38d02a718e9e]

        tdf#48706: svl_qa_cppunit: Add unittest
        
        Change-Id: Ia57006f88c8d0d0658178edb4d645b9d63de37c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169089
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-18  kubak  <kuba@openoffice.com.pl>  [2769feccbf026dd318c4afa08ba3692f287d7c5d]

        tdf#131688 - RemoveDirectCharFormats <Ctrl>+<Shift>+X usage tip
        
        Change-Id: I89c2c7d6af663904223834664aeb635cb99068bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167164
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-18  László Németh  <nemeth@numbertext.org>  [ee6bf912d615d0afa438f743ddf3e4f6f5f890aa]

        tdf#161637 linguistic: fix apostrophe in spelling suggestions
        
        Use the correct typographic (curly) apostrophe instead of the
        obsolete straight (typewriter or ASCII) apostrophe.
        
        Follow-up to commit e6fade1ce133039d28369751b77ac8faff6e40cb
        "tdf#38395 enable smart apostrophe replacement by default" and
        commit 8de1941fe61b461be617e1e88bb362bbd8315654
        "tdf#150582 linguistic: fix always rejected words with U+2019 apostrophe".
        
        Change-Id: Ic0e9aabcce7e95703601dd74e039f2838c89c769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169087
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [5dfa4bda2cb023a6a2fbccd4ff63a704f958851f]

        tdf#118226, tdf#161462: sc: Add UItest
        
        Change-Id: Ifd7b8a92dff30fee25b1431dde0f3426b2f8bab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169083
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-18  Dione Maddern  <dionemaddern@gmail.com>  [53afc7b4b9b79f2f982f030f3baf7b6f636450c2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f70c8aa2a700cad40257f020998c8dce5ed3dda
          - tdf#118588 Relevant help information for Impress Insert Table
            
            Created a new file text/shared/01/insert_table.xhp
            - Moved help content for Insert > Insert Table in Impress and Draw from text/simpress/01/04080100.xhp to a new file.
            - Moved hid bookmarks from text/simpress/01/04080100.xhp and text/swriter/01/04150000.xhp to the new file. Even though these are technically different ui components, they all use the same HID and pressing F1 or Help was opening the help file for Writer.
            - Embedded relevant help content for Writer to avoid retransalation.
            
            Deleted text/simpress/01/04080100.xhp
            
            In AllLangHelp_shared.mk
            - Added a reference to text/shared/01/insert_table.xhp
            
            In AllLangHelp_simpress.mk
            - Removed the reference to text/simpress/01/04080100.xhp
            
            In text/simpress/guide/table_insert.xhp
            - Changed title and H1 to make it clearer that the article is about both Tables and Spreadsheets.
            
            In text/simpress/main0104.xhp
            - Added variable tags so that the page can be more easily linked from other pages
            
            In text/simpress/00/00000404.xhp
            - Updated howtoget information to include information for the TabUI
            
            Change-Id: I16626a0bb467e475571185571348f26ce745af8c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169013
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [20f9fc1030ffc0f37d5dc528e010d4167210eb02]

        tdf#37341, tdf#43693: move UItest to CppUnittest
        
        and remove duplicated test, tdf43693.py, which is
        basically the same as tdf37341.py
        
        Change-Id: Ib29638ecbc2f89e717712ad03afccc70c5aa47ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169079
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0572ef356be49b95b22a4794b7937c8c0914468f]

        loplugin:ostr in various
        
        Change-Id: I7aa8ed716998a185996482dc561219b398a1c919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-18  László Németh  <nemeth@numbertext.org>  [89a80d637e2831d49cdf48921f961b04fd03cffc]

        tdf#161628 sw DOCX: export zero hyphenation zone, if it's not defined
        
        To keep the layout of the document, export zero hyphenation zone
        instead of nothing, otherwise it would be 360 twips after importing
        the document with the default hyphenation zone.
        
        Follow-up to commit 8d8bc48b5efacde6f99d78a557cd052ce9e0ed07
        "tdf#161628 DOCX import: set default hyphenation zone (1/4 inch)".
        
        Change-Id: I7be4a001f894bcdf10fff5f1b2e211a5a45566d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169078
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-18  László Németh  <nemeth@numbertext.org>  [8d8bc48b5efacde6f99d78a557cd052ce9e0ed07]

        tdf#161628 DOCX import: set default hyphenation zone (1/4 inch)
        
        Default value of hyphenationZone is 360 twips (0.25"). Apply this
        value, if hyphenationZone is not defined, according to the OOXML
        standard.
        
        Follow-up to commit 5a079652c1b1f968a851f47995b0a65b84d2d192
        "tdf#149421 DOCX: import/export hyphenation zone".
        
        Change-Id: Idadae973d93a14fbbe828fa74562db6262c40904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169070
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-18  Noel Grandin  <noelgrandin@gmail.com>  [d42957a83660565695ada1a91547148860a5c10b]

        move GetParaBounds code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I103c53783b286be0c8472b1850e3cf3e3d6a925f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-18  Miklos Vajna  <vmiklos@collabora.com>  [77c9e4bdbaae0a96d2c64a8e7e6b54f3e0f3a067]

        sw: document SwVbaParagraphs
        
        What is the uno service in xray, and a simple VBA sample.
        
        Change-Id: I4c86f28481631e82cf9ddfb734b7acc9525aed5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169072
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-18  Michael Stahl  <michael.stahl@allotropia.de>  [d0c979b4baee55b4d7352f7ebab201e65d6c1fcd]

        tdf#161346 add unit test
        
        Change-Id: I7f441a1fcf92f40678811faf26ec40eac98a7ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169046
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-18  Noel Grandin  <noelgrandin@gmail.com>  [960f0508fb2bd80e6299a79d5b71ef54a0723758]

        move GetDocPosTopLeft code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I437ab776ccf50dda6c34d458c6a7eaaea09e4d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-18  Noel Grandin  <noelgrandin@gmail.com>  [37e655a8a2dda13511f7e47c7d455bff71b9f9c4]

        move GetLineHeight code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ic2387c75209496ea9301e4c5a129c56e15cfe955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-18  Noel Grandin  <noelgrandin@gmail.com>  [da6647b5ae8b9d26d3b4a85cd8f943553a31b1ae]

        move GetLineNumberAtIndex code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I9ca9c6cfe1b92de8ef6fa93ccc0a4c84a11e8686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-18  Noel Grandin  <noelgrandin@gmail.com>  [11b4159b520fc6f84527cd510d44ffd248f1fac0]

        move GetLineBoundaries code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ic0d740d336f291f80d82989283dafc0704e97958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169053
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-18  Attila Szűcs  <attila.szucs@collabora.com>  [dfffe516199b595e78a23178bc6e508a28ee48e6]

        tdf#161571 chart: OOXML export of piechart label positions
        
        Custom Positions of lables was not exported in case
        of piechart.
        
        As far as i know, Best Fit Placement in PieChart may can
        cause issues, because MS, and LO may calculate it differently,
        so i left that case unchanged, to avoid possible regressions.
        
        Change-Id: I84e94f30390eb323c7311ae1d97ca3c63da0bc6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168972
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-18  Attila Szűcs  <attila.szucs@collabora.com>  [ada05b8874aa2c5161550dbc87d79b47f40f0df8]

        tdf#161607 Chart: import-export LeaderLines data
        
        Implemented Importexport of some leaderLines data
        (color and width of the lines) from/to OOXML.
        
        It now supports only the solidFill color.
        Used properties: "LineColor" and "LineWidth"
        
        Change-Id: Ib33392d0404e1186328176fd93322e02b4006f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168974
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [62c99a31de22561e0e38dd10f3b3fd2b6dd9971d]

        language-subtag-registry: upgrade to 2024-06-14
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2024-06-14.tar.bz2 data/language-subtag-registry
        
        Change-Id: Ib85b9072590a97fde37be85b9866bf53f77d1f4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169061
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [eefa6c05b40d8ecbccfdd4563b0bcc7b6de4980d]

        Remove duplicated include
        
        Was added in https://gerrit.libreoffice.org/c/core/+/140403
        
        Change-Id: I51f2edf52a8272b803370477fdc60bd3a6b6f87a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169093
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [cfbef58cbae004cd807906f922d31ab8506ec816]

        Remove duplicated include
        
        Was added in https://gerrit.libreoffice.org/c/core/+/165672
        
        Change-Id: I0943e08bdfa200d849ccaa366937eb90d4e76e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169095
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [8deef56243b4ddac3292f8b10924c35177cf7037]

        Remove duplicated include
        
        Was included in https://gerrit.libreoffice.org/c/core/+/132404
        
        Change-Id: I4af9d5a4764cb81d4069798ea9cd04bfb75e91b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169092
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [16c06873b66ebdfcc70c7a1fcaf8c3cac60be2df]

        Remove duplicated include
        
        Was added in https://gerrit.libreoffice.org/c/core/+/105028
        
        Change-Id: Ib15b1ac91aa0453a5db1dccd3efae8f95c428a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169094
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [41031823555f7c8cdd17a88571d3e21574aae8f0]

        Remove duplicated include
        
        Was added in https://gerrit.libreoffice.org/c/core/+/153356
        
        Change-Id: I22e47ca0bcff45f22e288251c1aaa46cd4e29315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169090
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-18  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [c6a8f960570f125d9ef387fc61c6a249ca86b806]

        Remove duplicated include
        
        Was added in https://gerrit.libreoffice.org/c/core/+/166807
        
        Change-Id: I023b101366c2cdde756d780732e83d083b905ee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169091
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [4df2a30c57c150d30d34e4cd1641a076cf3010f6]

        tdf#145735 qt avmedia: Don't deadlock with QGstreamerMediaPlayer
        
        While opending a slide with a video worked fine for
        me with the qt6 VCL plugin and a local Qt development
        build on Debian testing (qtbase as of
        8915ae3a75c4a356d94962dd9b31e1458f2a506f,
        qtwayland as of deae8b9ce9f551b29ef98d0bb827a8543af2797e,
        qtmultimedia as of 235ba5f273fbb7dfed8ba3736e4444a85aee5770),
        this resulted in a freeze when using Debian's system-provided
        Qt packages instead (libqt6multimedia6:amd64 6.4.2-11+b2).
        
        While the self-compiled Qt dev is using `QFFmpegMediaPlayer`
        which asynchronously loads media, the system QtMultimedia
        is using `QGstreamerMediaPlayer` (s. frame 37 in below backtrace)
        that apparently doesn't use multiple threads.
        
        Therefore, using `Qt::BlockingQueuedConnection` is problematic,
        as its documentation [1] says:
        
        > Same as Qt::QueuedConnection, except that the signalling thread blocks
        > until the slot returns. This connection must not be used if the receiver
        > lives in the signalling thread, or else the application will deadlock.
        
        Use `Qt::AutoConnection` (= 0, the default) instead and specify the
        `Qt::SingleShotConnection` flag in addition to ensure the slot
        gets called only once:
        
        > This is a flag that can be combined with any one of the above connection
        > types, using a bitwise OR. When Qt::SingleShotConnection is set, the
        > slot is going to be called only once; the connection will be
        > automatically broken when the signal is emitted. This flag was
        > introduced in Qt 6.0.
        
        Drop the now no longer needed manual disconnect.
        
        This makes the scenario work with both, the custom-compiled
        Qt dev using `QFFmpegMediaPlayer` and the system-provided
        Qt 6.4.2 using `QGstreamerMediaPlayer`.
        
        Side note: Unrelated to the issue addressed here, using the
        system-provided Qt with `QGstreamerMediaPlayer` results
        in a crash when started via the soffice shell script wrapper
        with a LibreOffice debug build or when using soffice.bin directly
        and manually setting `MALLOC_PERTURB_=153`, which indicates
        some memory issue. That could be within Qt, though, haven't
        analyzed that further.
        
        Backtrace of deadlock:
        
            1 syscall syscall.S 38 0x7f40a83249f9
            2 QSemaphore::acquire(int) 0x7f40948714e2
            3 ?? 0x7f409477fede
            4 QVideoSink::videoFrameChanged(QVideoFrame const&) const 0x7f4095195376
            5 ?? 0x7f405c219f5c
            6 ?? 0x7f405c21a25b
            7 QApplicationPrivate::notify_helper(QObject *, QEvent *) 0x7f4093782d62
            8 QCoreApplication::notifyInternal2(QObject *, QEvent *) 0x7f40947356d8
            9 QCoreApplicationPrivate::sendPostedEvents(QObject *, int, QThreadData *) 0x7f40947358b7
            10 ?? 0x7f4094925257
            11 ?? 0x7f409ab0de3f
            12 ?? 0x7f409ab0fec7
            13 g_main_context_iteration 0x7f409ab104e0
            14 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) 0x7f4094922f60
            15 QtInstance::ImplYield QtInstance.cxx 455 0x7f4094e534e0
            16 QtInstance::DoYield QtInstance.cxx 464 0x7f4094e568a5
            17 ImplYield svapp.cxx 384 0x7f409f3c48cc
            18 Scheduler::ProcessEventsToIdle svapp.cxx 419 0x7f409f3c4bc8
            19 avmedia::qt::QtFrameGrabber::grabFrame QtFrameGrabber.cxx 106 0x7f405cac5524
            20 non-virtual thunk to avmedia::qt::QtFrameGrabber::grabFrame(double) 0x7f405cac564e
            21 avmedia::MediaWindow::grabFrame mediawindow.cxx 385 0x7f40a03e41ad
            22 SdrMediaObj::getSnapshot() const::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const svdomedia.cxx 195 0x7f40a249e5b5
            23 std::__invoke_impl<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(std::__invoke_other, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) invoke.h 61 0x7f40a249e52d
            24 std::__invoke_r<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) invoke.h 111 0x7f40a249e4dd
            25 std::_Function_handler<void (com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&), SdrMediaObj::getSnapshot() const::$_0>::_M_invoke(std::_Any_data const&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) std_function.h 290 0x7f40a249e345
            26 std::function<void (com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&)>::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const std_function.h 591 0x7f40a03e96cd
            27 avmedia::PlayerListener::callPlayerWindowSizeAvailable mediawindow.hxx 76 0x7f40a03e6bf1
            28 avmedia::PlayerListener::preferredPlayerWindowSizeAvailable mediawindow.cxx 496 0x7f40a03e5055
            29 avmedia::qt::QtPlayer::notifyListeners QtPlayer.cxx 395 0x7f405cacfd53
            30 avmedia::qt::QtPlayer::notifyIfReady QtPlayer.cxx 326 0x7f405cacfb42
            31 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus)>::call qobjectdefs_impl.h 135 0x7f405cad477b
            32 QtPrivate::FunctionPointer<void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus)>::call<QtPrivate::List<QMediaPlayer::MediaStatus>, void> qobjectdefs_impl.h 172 0x7f405cad46cd
            33 QtPrivate::QSlotObject<void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus), QtPrivate::List<QMediaPlayer::MediaStatus>, void>::impl qobjectdefs_impl.h 383 0x7f405cad4612
            34 ?? 0x7f409477fbbe
            35 QMediaPlayer::mediaStatusChanged(QMediaPlayer::MediaStatus) 0x7f4095184a05
            36 ?? 0x7f405c210740
            37 non-virtual thunk to QGstreamerMediaPlayer::processBusMessage(QGstreamerMessage const&) 0x7f405c2009f7
            38 ?? 0x7f405c21aa94
            39 QObject::event(QEvent *) 0x7f40947723e0
            40 QApplicationPrivate::notify_helper(QObject *, QEvent *) 0x7f4093782d62
            41 QCoreApplication::notifyInternal2(QObject *, QEvent *) 0x7f40947356d8
            42 QCoreApplicationPrivate::sendPostedEvents(QObject *, int, QThreadData *) 0x7f40947358b7
            43 ?? 0x7f4094925257
            44 ?? 0x7f409ab0de3f
            45 ?? 0x7f409ab0fec7
            46 g_main_context_iteration 0x7f409ab104e0
            47 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) 0x7f4094922f60
            48 QtInstance::ImplYield QtInstance.cxx 455 0x7f4094e534e0
            49 QtInstance::DoYield QtInstance.cxx 464 0x7f4094e568a5
            50 ImplYield svapp.cxx 384 0x7f409f3c48cc
            51 Scheduler::ProcessEventsToIdle svapp.cxx 419 0x7f409f3c4bc8
            52 avmedia::qt::QtFrameGrabber::grabFrame QtFrameGrabber.cxx 106 0x7f405cac5524
            53 non-virtual thunk to avmedia::qt::QtFrameGrabber::grabFrame(double) 0x7f405cac564e
            54 avmedia::MediaWindow::grabFrame mediawindow.cxx 385 0x7f40a03e41ad
            55 SdrMediaObj::getSnapshot() const::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const svdomedia.cxx 195 0x7f40a249e5b5
            56 std::__invoke_impl<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(std::__invoke_other, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) invoke.h 61 0x7f40a249e52d
            57 std::__invoke_r<void, SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&>(SdrMediaObj::getSnapshot() const::$_0&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) invoke.h 111 0x7f40a249e4dd
            58 std::_Function_handler<void (com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&), SdrMediaObj::getSnapshot() const::$_0>::_M_invoke(std::_Any_data const&, com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) std_function.h 290 0x7f40a249e345
            59 std::function<void (com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&)>::operator()(com::sun::star::uno::Reference<com::sun::star::media::XPlayer> const&) const std_function.h 591 0x7f40a03e96cd
            60 avmedia::PlayerListener::callPlayerWindowSizeAvailable mediawindow.hxx 76 0x7f40a03e6bf1
            61 avmedia::PlayerListener::preferredPlayerWindowSizeAvailable mediawindow.cxx 496 0x7f40a03e5055
            62 avmedia::qt::QtPlayer::notifyListeners QtPlayer.cxx 395 0x7f405cacfd53
            63 avmedia::qt::QtPlayer::notifyIfReady QtPlayer.cxx 326 0x7f405cacfb42
            64 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QMediaPlayer::MediaStatus>, void, void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus)>::call qobjectdefs_impl.h 135 0x7f405cad477b
            65 QtPrivate::FunctionPointer<void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus)>::call<QtPrivate::List<QMediaPlayer::MediaStatus>, void> qobjectdefs_impl.h 172 0x7f405cad46cd
            66 QtPrivate::QSlotObject<void (avmedia::qt::QtPlayer:: *)(QMediaPlayer::MediaStatus), QtPrivate::List<QMediaPlayer::MediaStatus>, void>::impl qobjectdefs_impl.h 383 0x7f405cad4612
        
        [1] https://doc.qt.io/qt-6/qt.html#ConnectionType-enum
        
        Change-Id: Ia8bfd19b0c0c4f970a5eb200c2a0b45784ef25fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169036
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [12c4b7ee91c6fb1e2a1e4a5c8828372ddfad5a9f]

        tdf#145735 qt avmedia: Show audio placeholder for audio files
        
        So far, `QtPlayer::createPlayerWindow` was unconditionally
        creating a video widget.
        
        However, audio-only media files can be used as well,
        therefore handle that case, too and create a widget
        holding an audio icon as a placeholder instead if
        the media doesn't contain video.
        (This is the same icon shown when using qt5 that
        doesn't use QtMultimedia).
        
        As described in
        
            commit a99575f04fa9c858bfcd996f037444135810d43f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Jun 1 07:32:22 2024 +0200
        
                tdf#194504 qt avmedia: Don't wait for video frame if there's none
        
        , `QMediaPlayer::hasVideo()` only returns a useful
        result once loading media has finished. Therefore,
        if the player is still in that state in
        `QtPlayer::createPlayerWindow`, defer
        creating the widget to when the media status
        changes.
        
        With this commit in place, opening an Impress presentation
        that contains an audio file (like attachment 194504
        from tdf#145735) and starting presentation mode now shows an
        "audio icon" as placeholder as expected when using
        the qt6 VCL plugin.
        
        (This commit here makes that work for presentation
        mode, while the above-mentioned commit already made
        the icon show as expected for non-presentation mode.)
        
        Change-Id: I1ff7e8b8659162a748abc3f97a8d2181375c0e7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169009
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [ca364f8f16f0c64589d15e7bc44fe6eaebe8f5b2]

        tdf#159835 sfx2: Simplify TabBar::OnToolboxClicked
        
        Now that the logic from `SidebarController::PopulatePopupMenus`
        has been moved here in
            Change-Id: I8236f2467239e6a2f485d468656e961478eeb09c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jun 17 13:35:12 2024 +0200
        
                tdf#159835 sfx2: Move logic to populate sidebar menus to TabBar
        
        as well, simplify `TabBar::OnToolboxClicked`:
        No longer use one loop to build a vector of entries
        and another to process these, but use a single loop
        for that instead.
        Drop the now unused `DeckMenuData` class.
        
        Change-Id: I884f3b70bb4d85b9a52421e9de6042cda80cfa0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169006
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [008c3049b8aaaf3d40675bddc31b0198493fa761]

        tdf#159835 sfx2: Move logic to populate sidebar menus to TabBar
        
        Move the logic to populate the menus from
        `SidebarController::PopulatePopupMenus` (called
        by `SidebarController::ShowPopupMenu`) to
        `TabBar::OnToolboxClicked`. The latter called
        `SidebarController::ShowPopupMenu`.
        (In a first step, take over the existing implementation
        but leave further changes for following commits.)
        
        `TabBar::OnToolboxClicked` already collects all the deck
        data relevant for the menus and the menus are members of that
        class, so it seems more straighforward to populate
        the menus there right away.
        The only information needed from `SidebarController`
        is whether the sidebar is docked or not, so add a
        new method `SidebarController::IsDocked` to retrieve that
        information.
        
        Rename `SidebarController::ShowPopupMenu` to
        `SidebarController::ConnectMenuActivateHandlers` as
        it only connects the signals now, and rename
        `PopupMenuProvider` to `PopupMenuSignalConnectFunction`
        accordingly.
        
        This commit does some refactoring in preparation of
        fixing tdf#159835, no change in behavior intended (yet).
        
        Change-Id: I8236f2467239e6a2f485d468656e961478eeb09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169005
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [8a10012039204b208aea3bc2f9da9fe1162c4a2a]

        tdf#159835 sfx2: Use reference instead of pointer
        
        This e.g. makes it clear that this is never null.
        Also use an `m` prefix for the class member.
        
        Change-Id: Ia66245f17e7f0ca9e57750e8606c8ccc1387eb97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169004
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-18  Oliver Specht  <oliver.specht@cib.de>  [c39e4f6b8a942680bc7250177c34fd034a0605e0]

        Add SfxItemType to SfxPoolItem
        
        The SfxPoolItem has a new member SfxItemType m_eItemType to
        compare types based on enums instead of typeinfo() which
        consumes a lot of time e.g. while AutoFormat is running
        
        Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-06-18  Oliver Specht  <oliver.specht@cib.de>  [8ef9573f087b86f93860c8d07d04b60a40512836]

        tdf#161521 fix page margins on first page with mirrord layout
        
        Documents starting with an even page on a mirrored layout need
        to switch left/right margin on the first page.
        Applies also to docx export.
        JUnit test included
        
        Change-Id: Ia363941c6a7a25f9208acc7e40b77baa88080780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168658
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-06-18  Justin Luth  <justin.luth@collabora.com>  [4376c6db01947637e700b3ece516d0608be1bf29]

        NFC cleanup duplicate entry in clang/buriedassign.cxx
        
        amid lots of junk, found by   sed -i -f ref.sed */*/*.cxx
        --------------------ref.sed --------------------
        {
        N;
        s#\([^\n]*\n\)\1#\1#g;
        P;
        D;
        -------------------------------------------------
        
        Change-Id: I2788c098d91b149a3728fd597ee227078ccfc038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169059
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d399fad19d002e05a19f0acf069ae9ee1364e32a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c8b04c8d9d3a2367bb3205b852f2d7b75082f90
          - tdf#154226 Add link to LO books on Help pages
            
            Added a row of icons on the footer of the Help pages.
            
            Change-Id: I40e1e697e5defa21ba3fb6f93198489ac401924b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169033
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dbcb204bd00a91f243fce8bcd03ddf4dfc4d4298]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f43bf5caf95051c06f0c08f326f8d864c501d58
          - tdf161612 Precisions for XMATCH function Help page
            
            Change-Id: Id50a01c9c33284124f022540ac51c1f1651848e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169007
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [04658a706757dabbedfd87717e6f1f354b4c8961]

        Embind: Fix lifecycle of UNO any and sequence values returned from JS to C++
        
        When a JS function implementing a UNO interface method returns any or a sequence
        type (like queryInterface, getType, and getImplementationId in uno.js), it
        could not create a new instance of that type and return it, as it would have
        needed to call .delete() on that instance, but couldn't.  In uno.js, getType and
        getImplementationId solved that by returning pre-instantiated instances that
        were deleted in the final release call.  But that did not work for
        queryInterface, as pre-instantiating the relevant any instances would have
        caused cyclic references that would have caused the final release call never to
        occur.
        
        So redesign the C++ the_wrapper classes (used by the Embind allow_subclass
        machinery):  If a UNO interface method returns any or a sequence type (i.e., a
        type on which .delete() must be called), change the JS implemenation's return
        type from by-value (which meant that the C++ code received a copy) to
        by-reference---which means that now the C++ code can access the original
        instance and delete it.  But which also means that the JS code must always
        return a fresh instance now!
        
        (Ideally, the embindmaker-generated code would use by-pointer rather than
        by-reference for that return type, but that caused
        
        > emsdk/upstream/emscripten/cache/sysroot/include/emscripten/wire.h:116:19: error: static assertion failed due to requirement '!std::is_pointer<com::sun::star::uno::Any *>::value': Implicitly binding raw pointers is illegal.  Specify allow_raw_pointer<arg<?>>
        >   116 |     static_assert(!std::is_pointer<T*>::value, "Implicitly binding raw pointers is illegal.  Specify allow_raw_pointer<arg<?>>");
        >       |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        errors with no obvious place where to put such allow_raw_pointer markers, so
        lets go with this little hack at least for now.)
        
        Change-Id: I3c37b79b8fbf09c19782c6532bc95d4d63505c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169008
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [3b551da96e1ddb0824002c06ee668055ab077a0e]

        move GetLineLen code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ied2b0ed968987f44446abf1066b7e9af106e909d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169039
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [adf72803071cf96e7aafb1b9fcd0480d0a14de3a]

        move GetText code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I3979577a82539c6b9d36bef0faa2a34689be2a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [98c74adf2e1945599f693c26d72141553bd7955b]

        tdf#161616: do not set error when XGoalSeek fails
        
        Change-Id: I2fcec37cd9d22862dd136c97e5b4097e69fd41cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169035
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [90ff738d1ba1df253d66cc1137b7c0adf450d1d7]

        EditEngine::GetTextHeightNTP is unused
        
        ever since
            commit 2d8056d884ee3ab7b4454c378618dceb6f5a7ae8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Apr 4 10:55:36 2024 +0200
            loplugin:unusedmethods
        
        Change-Id: I2ccdbf45ac688e39df23fd69b8ec21efebad044c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169003
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [8fb67b3cf6d893aabb82ac77e6f9cb14c4dc37d1]

        move GetText code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I153b36b8cc5e91f46bff42dba2f36fce733a8df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [3caf57f9823a5b178e9f2d391dc09ed4a599ce0c]

        move GetLanguage code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I75995fb7640977276feeea2e2963725974adbe42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169001
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [04eedb4aec5ffa3966dd4e21ae2f594b289ac53b]

        move SetControlWord code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ie653fc6880e096ca4fad4dc1cf77bb3f16915dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [43ec63461428f05ee2decf68e791bde94d839ff9]

        move RemoveAttribs code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I55f419e08323d0fe7cc16bc525fc93920980f4c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Miklos Vajna  <vmiklos@collabora.com>  [4e5dd2c0774242e44ac6edf2bd5ada220541b06b]

        tdf#161570 DOCX import: fix lost numbering in paragraph style
        
        Regression from commit ca71482237d31703454062b8b2f544a8bacd2831
        (tdf#153083 writerfilter: import locale-dependent TOC \t style names, 2,
        2023-01-31), open the doc, apply 'Level 2 Heading' on the first para,
        then switch back to 'Signature' again using e.g. the sidebar, the
        numbering of the first paragraph is gone.
        
        This was initially a wider problem, but since commit
        ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be (tdf#160402
        filter,writerfilter: import locale-dependent STYLEREF names,
        2024-05-06), the problem only affects built-in styles. There were two
        remaining problems: 1) the separator for the TOC field can contain
        whitespace, which resulted in a style named ' Signature' and 2) the
        style was always cloned, even if the name was not localized.
        
        Fix the problem by first trimming the style name in
        DomainMapper_Impl::handleToc() and then only cloning in
        DomainMapper_Impl::ConvertTOCStyleName() if we see that the style name
        is localized. A localized style name can be observed when opening e.g.
        sw/qa/extras/ooxmlexport/data/custom-styles-TOC-semicolon.docx that has
        Intensives Zitat vs Intense Quote.
        
        One remaining question is why the numbering is lost when the cloning
        happens, that's not addressed here, as the cloning should not happen for
        this document in the first place.
        
        Change-Id: Ibc2ea20cc3c9ec6bec9bdcdabce1469a0457317a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168994
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [76bf4f177d2c9d7962ca325887035d57a67f416f]

        Update git submodules
        
        * Update translations from branch 'master'
          to b6092afde898f454189047221479af58e31049fa
          - update translations for 24-8/master
            
            and force-fix errors using pocheck
            
            Change-Id: I4a4726ec04a147df4f78d95213a82bf9e0c13a61
            
2024-06-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0dd0a928b3abcbb50895f6e7716fa24876a147b5]

        Fix thinko re JS for...in loop
        
        Change-Id: I31647952090224e3195afc636613d1ae56ecb10e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168995
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-17  Michael Stahl  <michael.stahl@allotropia.de>  [0cbfd84b0c57a831b2ff48239aa9926482f49f8b]

        package: remove experimental mode check
        
        It should check for the wholesome encryption more directly; PBKDF2 is
        unreachable from the UI in this case anyway, this can only be tested
        with LO_ARGON2_DISABLE=1 in the environment.
        
        Change-Id: I5e74471300df1c6ef3892dc544f13328e5898abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168998
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-17  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [a3ac49ebe78b7fc164dbc766492faee084bad254]

        tdf#159924 sw: fix hyperlink name export to PDF
        
        If there is a Name attribute set for a hyperlink, the text is exported
        to PDF as tooltip.
        
        note: not every PDF reader displays this text
        
        Change-Id: Ib9f1c13403c1555bfae733d662754c0e052378f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168993
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-17  Patrick Luby  <guibmacdev@gmail.com>  [a4488013ee6c87a97501b620dbbf56622fb70246]

        tdf#148569 set extra drawing constraints when scaling
        
        Previously, setting stroke width and cap was only done when running
        unit tests. But the same drawing contraints are necessary when running
        with a Retina display on macOS.
        
        Change-Id: I74f7347d30a410f7d3485388ffec61b32730b948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-17  Michael Stahl  <michael.stahl@allotropia.de>  [31698044cd1fe7a7662740b97ea58f9904b3bb0e]

        tdf#160888 package: fix opening password protected scripting library
        
        The problem is that XBufferedThreadedStream does not implement
        XSeekable, so the new code in ZipFile::checkValidPassword() throws an
        exception, and then joining the UnzippingThread hangs.
        
        Implementing XSeekable doesn't appear to help, as the mutex that
        is used by XBufferedThreadedStream and the UnzippingThread is already
        locked by checkValidPassword() [fixably] and by getDataStream().
        
        So just disable threading for AEAD streams, these are read immediately
        anyway so threading isn't much of a benefit.
        
        (regression from commit 2f512aaa6c39390a5a0eb1d1e37f070127d068a4)
        
        Change-Id: I16027d5b03ba6e102bc143c22383eb7f08590e5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168893
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-17  Miklos Vajna  <vmiklos@collabora.com>  [279246a6e8058d4b0125e5a59c46974af7f09d73]

        svx: prefix members of SdrUndoGroup
        
        See tdf#94879 for motivation.
        
        Change-Id: I9aa439b2fba8c10710ea0f491272a5f9823a27a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168979
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [422b5c86e2b9bbf312d9e73a353cfb320aac3a47]

        move SetText code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ie755b1cbc175d98756f6e6ecc173f32c65c7ff7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168955
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [1b743310a2a5d84fc9048c8ceab3fa8479591203]

        move InsertParagragh code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I061481f7218bc0365c6783662c24642da5f63370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168954
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a063a8bc391ae3017a114a9a5edd8073067168dc]

        Move duplicate code into shared method
        
        Change-Id: I3859c3a491abbe74d12f08d86948196dddb462ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168822
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a298ba36047e17cf6a0f6b3d17ae40aed282f47b]

        ppt: Don't export notes author/date when in privacy mode
        
        Change-Id: Id748b79e7685f5e99df142aa2aa9449a18a32d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168821
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5fe7062f2a5f7785a15abbfbe0c0394826412e0e]

        pptx: Don't export notes author/date when in privacy mode
        
        Change-Id: Ia2f20b05b043d45df090f2843a4d365c692770fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168813
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4bca6e024fc7bf3be5db1dd8cfde44d7304d6ff6]

        annot: use createBitmapFromBuffer also when rendering the PDF
        
        This removes the duplicated code.
        
        Change-Id: I54ada6875f7897b7eb480f10b8e1c8be887ca5ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168978
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4fbb4242d924c0a7a43a10c4ecd4a33f8b339310]

        annot: update object text when annotation text changes
        
        When the annotation text changes we need to sync this with the SDR
        object (if the object is showing the annotation text - like free
        text annotation).
        
        Also move annotation object searching to the annotation class, so
        it can be reused in AnnotationWindow.
        
        Also change uso of UNO XAnnotation in AnnotationWindow and use
        concrete type (sdr::annotation::Anootation) instead.
        
        Change-Id: I46db479ae8471c82ac58487a0125df15697245be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168977
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [23052214e026745fc5d8e780b91630e1f8dea205]

        annot: add undo to annotations inserter when synching
        
        Change-Id: If4b8ddcbee9468655944effb931347c8077abc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168976
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-17  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [40ddb619cfc88d161cb74a1f516dd39196658d50]

        Add new LOK CALLBACK for vertical ruler
        
        - We're adding a new LOK callback LOK_CALLBACK_VERTICAL_RULER_UPDATE.
        - The reason is that we currently override the existing callback.
        - Using the same callback for both vertical and horizontal rulers causes an issue.
        - override will create problem like it will only send any one of the ruler orientation update.
        - It results in online updates being limited to just one ruler orientation.
        - By introducing a new callback, we ensure updates for both vertical and horizontal rulers both are captured correctly in online.
        
        Change-Id: I02d0e3e7e4ac8a07a83644460aa0ba36e0f3c013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167481
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 11b936629dd4ef9308d63b312900b8b7c8ff19b4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167464
        Tested-by: Jenkins

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [4f74afd4cdfce405933e155e8fb9937e42fe30c0]

        move RemoveParagragh code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ifc82d3dd2624868f812533b9df9a34af51a06888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168953
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-17  Noel Grandin  <noelgrandin@gmail.com>  [4ac56fa47e5f525a403d7ef7fa1d0a0243fb6604]

        move CreateTextObject code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Iec53dad76756241b0f0ec31e76def89e336ee6ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168952
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ab48fd9b1a65579b2a63077cd3d2192b57af2a5]

        fix crash in "delete comments by author" in impress
        
        insert comment, click on it to expand it, click on menubutton and
        use "delete all comments by..."
        
        crash on use of invalid iterator as callback trashes the vector
        being iterated over
        
        Change-Id: Ia86de87207f706f35a023efa433c5e67b8bb436a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25bd91293cd3ac7bf24f491e8eab254aa78d9fcb]

        Resolves: tdf#160681 draw impress comment similarly to how writer does it
        
        so we get the same filled MenuButton in both applications
        
        Change-Id: Iea41a17285287ec2794e4cdce6eaae0906fff291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168969
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [15cf55b0a6a504772b051d957a51e7c3bc2d2b38]

        cid#1603617 Big parameter passed by value
        
        and ~20 of similar warning
        
        The current size of SfxItemSet is 144 bytes, and std::function is 32
        bytes of that.
        
        If we reintroduce Changed as a virtual method we can avoid the need for
        this callback. All of the calculation work that was originally
        unconditionally done, and then thrown away, was moved into the specific
        SwAttrSet case of this so the other normal cases don't do any wasted
        work anymore.
        
        Change-Id: Ieec90f6d28dad8a6bf1cf8f402042812bd81c331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168967
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-17  Justin Luth  <justin.luth@collabora.com>  [5b419af59e30b3383930ec11e130aa1b09b0547e]

        NFC cleanup duplicate entry in IwyuFilter_sc.yaml
        
        from 2018 commit 7dc9fb33db45c269fece6cfec993b124491c68f6
            tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[a-e]*
        
        Change-Id: Ia6ada37ff06355198d00fbf0f7fdfa0e0aede71c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168896
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [698a58bf2a6ca61a6646abce98e0bb171e10f49a]

        annot: remove too much "using namespace ..." declarations
        
        Change-Id: Ief36190e10dc03246497d4fd9475d9141dd1d7b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168975
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [58aca139242e6cfbb66c37bf40009d5201ff007f]

        LOK: Use frozen map instead of a chain of hundreds string comparisons
        
        Besides expected performance improvement, this helped to find several
        elements that were duplicated in the long list. Frozen map does not
        allow duplication of the keys, helping avoid these mistakes.
        
        Change-Id: I2192d0ed50b6b8611fd08715f713742a993b28dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168961
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7d93b585f5366ce22aaf174a1b463b004739f588]

        Remove exec bits on pdf file
        
        Change-Id: Ia3bb4a2c100e7dccafe9710c7af3a99268e53239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168963
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b63474a999f02a0f5b9eb5030d6611991dc34e7d]

        Fix typo
        
        Change-Id: I3be6bd8effb33183f67d63d910663d2741b24de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168965
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac4649188ba89d758b56addf2d61233d542bcf04]

        Fix typo
        
        Change-Id: I3d26c49a46f7382b34bd1619cfe7ff09db5e200c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168964
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1aeba4201846baeca2701dbf06a9b278b672e4ae]

        Fix typo
        
        Change-Id: I767eb6e62285434ff70e65f631e8bc77caf02995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168966
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3459a691eedde416ca8ba13fc8d44ee55e8ee88f]

        cid#1603806 Using invalid iterator
        
        Change-Id: I87d963e254607e7389429cba2839b6a318f44107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168962
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [a14ec822c9c571a32eb0565158f1976b2d0dbf28]

        LOK: Send view modes status change notifications
        
        Change-Id: If9a36dcd447eef355f137b5afe16f917e9c0cfa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168960
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1a1f1e9aaeefacc49c14551e235a711387ab5dc]

        cid#1603803 Unchecked return value
        
        Change-Id: Id7f4d7a27720856c5e53dab4333a8ecf370004dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c003f792183b63ca3f282a6fd53ceae0167f2a5e]

        cid#1603805 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ieb2c72dbdfec8431bd23da8a5e4844f3c1a5b74e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168958
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1ad74a0212a4882426ed4a8c9ed9e5e56c9c159d]

        cid#1603804 Unchecked return value
        
        Change-Id: I40d3a2dba67a3e0f7d65964396c6fa5b875a287c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168957
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [402368f7ed1be95c12a1514e4341cd926e3d5a56]

        Resolves: tdf#159741 canceling printing results in 'modified' document
        
        Change-Id: I627487a79f819351ec38e34b3fac432c36670d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168915
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec3d7ca054f63ad76fa1bd5a5fdf23a3a3eaed1d]

        fix gtktreestore.c:1047: Invalid column number 6 added to iter warning
        
        probably since:
        
        commit 35f59457ff434b7b97cad6ce1dbef6ff07f7bc96
        Date:   Thu Nov 16 17:03:39 2023 +0100
        
            tdf#158135 - UI: Part 30 - Unify lockdown behavior of Options dialog
        
            for Writer - Compatibility Page.
        
        Change-Id: Icaf1320f4f819294d49f99b3f1728fa025c51e11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168914
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [b2e52c203e89e29f28931634df5a2d9b8d522f7b]

        move Read/Write code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I07642b427461d76f4fb0a48158598d62f1d2d24e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168951
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [fda97ba70a59bfd52e5b0c1c83a31cec79f2d128]

        move PostKeyEvent code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I65f827cd4cf5fdb2a9f0db5f0a26bfce38629222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168950
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [41d6c0895b2d9964113fbe468bca9b82fece1b7c]

        move GetScriptType code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: I5aa2d12ff0c85893e2facd491d3c5ed00db77de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [197bca4e4cb36c0edbdc3ad51aeb165df6a3c09f]

        move SetPaperSize code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ia58dd654872f96cb0eaf964df6a9cc7d3b5628f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168928
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [37702339ec543710de7a122f4b9d01650e24d0ee]

        move SetDefTab code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ia887c46c70971f51a77a74fd03132b7eebb6c192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [02f51dc8f51f431e99062ae1ac144ff3e0ecdd94]

        move InsertView/RemoveView code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Iec4edf42c3047823b4dce6af789a94a849dd5039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168926
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [fab293ebc59c583f4cd17a6802f7d538b6b53556]

        move Draw* code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Iba2a42344aa5f8d00e4201d9a4ed72ca4c2b2193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168925
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [0ef72b2142db256165450d840f7f0d94be059fad]

        move UndoAction* code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ic7084dd7ab935f0a24f7284745b8d6e8c179545b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-16  Noel Grandin  <noelgrandin@gmail.com>  [965052fac15f00ce80f2747323c0dca9d1641e79]

        move SetPolygon code from EditEngine to ImpEditEngine
        
        so we have the implementation in one class, instead of bouncing
        back and forth between two.
        
        Change-Id: Ia91df69b95159f5487d914a67848fb3f18a69dc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168923
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4ff2e148fa25933e64b7bbecbcd3ed551ad686ab]

        LOK: differentiate page kinds in sd::ViewShellBase::getEditMode
        
        E.g., sending a LOK_CALLBACK_GRAPHIC_VIEW_SELECTION payload, the
        "mode" must be different for notes view and for normal view.
        
        Change-Id: I1f328290087f3185b7bef69560b28df6adb82e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168917
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [47efcbdcb4c56e3f29e9c7755eede365eb2a2ac3]

        Simplify a bit
        
        Change-Id: Ibb0165d0ce1ec1159a7d5446f746c4cdfcd0d748
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168916
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [52a2c19fc403affea4e609add8fd3aebe1bbb220]

        Remove some unneeded casts
        
        This also changes the API used in WriteLibraryToRegistry.
        
        Change-Id: Iba4c20567275a64684be8695c771e4c5535956ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168912
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aaf2967d74a9a7ba2d28433e1872422ce38b6244]

        Gtk warnings about missing labels
        
        a problem since:
        
        commit 164596c00b4361b5b378609f026a1b11ac653970
        Date:   Tue Nov 14 12:13:21 2023 +0100
        
            resave with newer glade version
        
        Change-Id: I2b69229c59ee07939da43b3013f64041c74f5967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168913
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [2086f693a31fa8f4afda5ea640a652dd13287687]

        Simplify a bit using newer registry API
        
        Change-Id: I0bd2a238662e1da0c62cdaec96b9892df82298f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168909
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [01a60798c63a9e3f4246f2df6c64cd7815b6b4b5]

        Simplify a bit using newer registry API
        
        Change-Id: I8e0106464260126983a1d55c66c218e78da7f94e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168908
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [c529cd74f26f778fd7282cf2efac40f7690b7fad]

        Simplify a bit using newer registry API
        
        Change-Id: Id5e13ec253f04ecae972d671cbafd1433717bca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168907
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [7b2c82ff14094aad4cb64a9d2531fd8fe48229b1]

        tdf#161585: fix DllRegisterServer implementation
        
        The buffer was prepared with a wrong length (one too few spaces); thus,
        the resulting registry key path was wrong, and opening it failed.
        
        While at it, use a normal WinAPI to stringify GUIDs, and simplify code.
        
        Change-Id: I9a51a5aa70791106055c615fd15a32e5e07847a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [04c1a93f8b718f6cd824696f9ffac10acfd32731]

        tdf#144208 speedup doc with lots of redline (12)
        
        Avoid a bunch of allocation/deallocation work in
        SwXText::compareRegionStarts
        
        Change-Id: I18398ab0e281da11ac3539e8e114574a0005dc1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168905
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [f1e4a97b03e1eacd679c3ef1dcb7ab4b577dd928]

        tdf#35568 Repeat "first run" procedure on upgrade
        
        1. In isProductVersionUpgraded, if it was upgraded, set FirstRun. This
           will run in runGraphicsRenderTests, early enough in Desktop::Main().
        2. This will make sure that Desktop::CheckFirstRun() will do its tasks,
           including creation  of the quickstart shortcut.  It is simplified a
           bit, to use a better WinAPI.
        3. Setting FirstRun to false is moved to m_firstRunTimer's handler, to
           make sure that it gets run eventually, even if the first launch was
           terminated before the timer fired.
        
        This will not make installer itself create the quickstart shortcut: it
        will happen on the program's first run after an upgrade. But users now
        won't have to enable the option manually each time.
        
        Change-Id: Ica6cc41f1e56b8970db27d14e2be3c47910293e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168902
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-15  richtrimble  <rich.trimble52@gmail.com>  [5d92f4dbb6ba0af39693564b83a44cc7610b577d]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I1c9dff3b7d4dbaa3b3de224576b2182d1f893619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168649
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [cfffcbc39b2c6794eaeddae5134fb59848a76d41]

        Simplify a bit
        
        Change-Id: Iae8af8904a445a523c1aecda6777ea4e2ce30598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168900
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6b3712dc0077644a28368592c5856e9914838dd7]

        SequenceAsHashMap::contains can be const
        
        Change-Id: I1f908eec2b8b809f5d1d9f8cac27bac9ba60df8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168899
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [cdcfd8b1df94a9e58557bfb195accd7cb43d2e3c]

        Reduce console noise
        
         warn:unotools.misc:21376:31920:unotools/source/misc/mediadescriptor.cxx:372:
         url: 'private:factory/scalc' com.sun.star.ucb.ContentCreationException
         message: "No Content Provider available for URL: private:factory/scalc
         at C:/lo/core/ucbhelper/source/client/content.cxx:205"
         eError: (com.sun.star.ucb.ContentCreationError) NO_CONTENT_PROVIDER
        
        Change-Id: Ibb430ed0779f2064975b8fcc43204164adaeb8d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168895
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-15  László Németh  <nemeth@numbertext.org>  [41916d9fb045654fa19b4eac90a3099550a890f7]

        tdf#161563 sw: show "No Break" context menu only on a whole word
        
        It's possible to set CharNoHyphenation on shorter character sequences,
        than a word, but the result is not correct (use soft hyphens for
        alternative hyphenation within words), so limit "No Break" menu item
        only for selected words. (Not completely, because only Point() is
        checked for word boundary yet, not also Mark().) If no selection, cursor
        position must be within the hyphenated word (where "No Break" applied
        for the whole word automatically).
        
        This fixes also the assert in SwTextFrame::IsInHyphenatedWord(),
        when multiple nodes were selected.
        
        Follow-up to commit 2f0c7d5691acd4010443856788a54b0abc03098b
        "tdf#161563 tdf#161565 sw: add No Break to word context menu &
        visualize".
        
        Change-Id: I41b64e6a2eb0daf08f488420fc1eaba2045a28db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168898
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9e00fa69fabbde8b9ff5a08a9ffc02a322cc7445]

        annot: support fill and line transparence for PDF annotations
        
        Change-Id: Iafff527a094e6cb550a9e060a191510f74d86075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168841
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [d474b972ce63407d2a91b56808d6df37164b9cef]

        Fix MSVC build
        
         C:/BuildLO/core/svx/source/table/tablehtmlimporter.cxx(500): error C2220: the following warning is treated as an error
         C:\BuildLO\core\svx\source\table\tablehtmlimporter.cxx(446) : warning C6011: Dereferencing NULL pointer 'mpActDefault'. : Lines: 428, 429, 430, 440, 441, 443, 444, 445, 446
        
        Change-Id: I2af1635a714cba3d27eb6b8b25db9b4c4aeaaade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168894
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-06-15  Patrick Luby  <guibmacdev@gmail.com>  [ab5ad0c8b5056da8f699cea233dd31eceb3d80a4]

        tdf#158914 add back reusing weakly cached ScAccessibleCells
        
        While commit 8e886993f32b7db11a99bdecf06451e6de6c3842
        fixed tdf#157568, moving the selected cell rapidly creates
        a large number of stale ScAccessibleCell instances that
        aren't deleted until the Calc document is closed. So reduce
        memory usage by adding back the ScAccessibleCell cache that
        was in commit f22cb3dfab413a2917cd810b8e1b8f644a016327 now
        that a new fix for tdf#157568 has been implemented.
        
        The new fix for tdf#157568 is to do the following:
        
        - Check if the edit engine text has changed. If the input
        string is different than the edit engine's existing text,
        force update of the edit engine's text. Otherwise, the edit
        engine will still to be set to its existing text.
        
        - Before a cell loses focus, check if any accessible text
        changes have occurred and fire text and value changed
        notifications if needed.
        
        Change-Id: I106ad0138d5d834367be59ca625d41a692696d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167961
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [7e123665eb8afb9b46422e28ade5bb512fafe12c]

        tdf#68034: sc_goal_seek: Add unittest
        
        Change-Id: I675d59cd7e22c09ea1c673e016d71f8d3ed404a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168890
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-14  Weblate  <noreply@documentfoundation.org>  [2f350b868f3746f8a5877fcb77edbf969b732db4]

        android-viewer translated using Weblate
        
        Interlingua currently translated at 75.0% (87 of 116 strings)
        
        Change-Id: I863bf24dd6469ec7a263811d3c7b6cb1dbd907f2
        Co-authored-by: SoftInterlingua <softinterlingua@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168820
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-14  Michael Weghorn  <m.weghorn@posteo.de>  [0c7928dc10da2c8c5ce9910fe20cea439573f2ae]

        wina11y: Fix handling for special text offset -1
        
        As described in the IAccessible2 spec [1], -1 can be used as a
        special text offset:
        
        > Using IA2_TEXT_OFFSET_LENGTH (-1) as an offset in any of the
        > IAccessibleText or IAccessibleEditableText methods is the same
        > as specifying the length of the string.
        
        Replace -1 by the text length *before* doing the
        check whether end offset is smaller than the start offset.
        
        Otherwise, trying to query the whole text of a Writer paragraph
        containing the text "hello" in NVDA's Python console would
        incorrectly trigger an error:
        
            >>> focus.IAccessibleTextObject.text(0,-1)
            Traceback (most recent call last):
              File "<console>", line 1, in <module>
              File "comtypes\__init__.pyc", line 856, in __call__
              File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__
            _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None))
        
        With this commit in place, it works as expected:
        
            >>> focus.IAccessibleTextObject.text(0,-1)
            'hello'
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/_general_info.html#_specialOffsets
        
        Change-Id: I489a42270a56178cc8ee0564eec3dc82e15969c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168853
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-14  Sujatro Bhadra  <sujatrobhadra@gmail.com>  [194adf065e572699e0d77d359e6625c1713c31c1]

        tdf#147864 Replace 'Show All' and 'Hide All' in the Comments category
        
        context menu of Writer Navigator with togglable commands 'Show Comments' and
        'Show Resolved Comments'
        
        Change-Id: I7ac00c5366327f8d245ca49595eca2fd1fac472c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166539
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [365e356b66ed98426ba06347ef29e58a02885579]

        tdf#144208 speedup doc with lots of redline (11)
        
        reduce the amount of sorting work we need to do in the m_HintsBy*
        maps, by storing the range of elements we need to resort
        
        Change-Id: I93bd22c9bfcf41f7c02828e184ff1170700cdcc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168857
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [278008f76835a128025b2a37ba8c9a7613284b6d]

        tdf#161573: Do not show unrelated messages during broken ZIP detection
        
        Change-Id: Iab7f4bb492e24eb2ca6448f3540d219a18c15d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168869
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64da52a94738aa73cbcf2411952914d4e8e0f9ef]

        crashtesting: avoid eventual assert when double inf is cast to sal_Int32
        
        seen on loading forum-mso-en4-604220.xlsx and asserting on export to ods
        
        lets assume that an infinite Y position equates to ALIGN_BOTTOM which is
        the case seen in this example, and assume the same for infinite X and
        ALIGN_RIGHT if it arises
        
        Change-Id: I009a9cd94b7bd9ed66e18f8dbbb9eb91d37eaa65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4890e08519103b0252767e0dd8b810894293f815]

        crashtesting: out of bounds on reexport of forum-mso-en4-290152.pptx to pptx
        
        probably since:
        
        commit 805fd61f8efaaac119bbe28ab51617c07f0d7058
        Date:   Thu Jun 6 19:47:45 2024 +0200
        
            tdf#160591 PPTX export: fix colormap mapping in slide master
        
            Change-Id: I154f0ff1769fbda361ec62f1dd589ca0d7686bd9
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168506
        
        Change-Id: I3ec45b2a0b78324e8512acbcc3a7544c196f670d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168851
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33dcc576c4b73515bb24548c832f4bfbdf8595ce]

        when SAL_CUPS_PPD_RETAIN_TMP is set output what the ppd file was saved as
        
        Change-Id: Ib17ec39a5b2691190c5eb1291d1977e1b83eba15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [cade37fa17665b97abb51ff17da21c4be7934c69]

        loplugin:ostr in sw
        
        Change-Id: Ibc8c3ce70d572e2e07ee6ae1e46996943cf90a5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168840
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-14  Miklos Vajna  <vmiklos@collabora.com>  [b39b15c639960a37ed53d82cef44e64ef58c141e]

        sw doc model xml dump: SwStartNode::dumpAsXml() is never called for tables
        
        SwTableNode is a subclass of SwStartNode, and SwTableNode provides its
        own SwTableNode::dumpAsXml(), so this is dead code.
        
        Change-Id: I051398c0e004839b750ea642dc636eeab8d73fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168891
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [f1872f6e47478dfd990c0031e823624de60fa079]

        tdf#161511: sc_goal_seek: Add unittest
        
        Change-Id: Icc05195a4870d5bb4f8c5ffc9b3bcae89367a89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168866
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [6fc21353bb30e71e2fc4d47394bf7ec2e704a454]

        tdf#68034: set the variable cell to value temporarily if needed
        
        Change-Id: I35fed710862ed87c477686e26bc8c82379c5e5a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168854
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [013282b1421c0bba66ef54ccbfe4a649a4b97628]

        tdf#160522 Chart > 4 columns, Only 4 colors
        
        regression from
            commit 337a9a454c1bc95214111578d3f9c0622c55c509
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon May 18 09:17:04 2020 +0200
            use for-range on Sequence in chart2
        
        Change-Id: I94f9460e45e5910af1de905605158f9dc1dbedfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-14  László Németh  <nemeth@numbertext.org>  [8de1941fe61b461be617e1e88bb362bbd8315654]

        tdf#150582 linguistic: fix always rejected words with U+2019 apostrophe
        
        During spell checking, words added to the user dictionaries still
        weren't recognized by Calc, Impress and Draw because of the unnecessary
        conversion their typographic apostrophes to ASCII apostrophes.
        
        Note: Writer has no such problem because of its (obsolete) apostrophe
        conversion for the user dictionary.
        
        First skip the obsolete apostrophe conversion in isValid(), but keep
        it as a fallback for Writer users.
        
        Change-Id: I09870a35d7a91017281ba4b228d338336e7bd9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168858
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-14  Jonathan Clark  <jonathan@libreoffice.org>  [e78bb77c3c5930b20113bff3de2dd02065cead85]

        tdf#92091 Writer save and restore VCL state during recursion
        
        This change updates Writer to save and restore VCL device state while
        laying out text. This fixes issues caused by Writer mutating device
        state while recursively laying out text, particularly overlapping RTL
        and LTR text when used together along with footnotes.
        
        Change-Id: I077352551ce2072f5c5eab9bff4b98bbcc6e78f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168835
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [efd665b931fdc46f226964ac838fb72a73782b98]

        sw: add update button to a11y check sidebar when using LOKit
        
        Running the a11y check when the sidebar gets enable takes some
        time, because populating the widgets is quite expensive. Instead
        of running the check right away, add a "update" button to the
        sidebar, that needs to be clicked first to start running the
        accessibility check. This does not check the behavior of the
        sidebar in desktop LibreOffice.
        
        Also change the populate call to be async, which helps a bit to
        make the UI interaction more fluent, but doesn't fix the issue.
        
        Change-Id: Ia04f4a5fbae952035c1b8d4d7c56211e061d8251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167855
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 5e6d7927e27551aa63a2b22134b1a9ee6408d39a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168784
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [e44904ba22ce0a350c1070d53f897a712001fc3d]

        CppunitTest_sc_copypaste: inherit from ScModelTestBase
        
        Change-Id: I0847ba4455cec24332030e87244c0d9c9ad2ad2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168859
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3783bf8d135bbd247d412d3ca01ac8b43753c0dd]

        reduce code duplication in SwpHints
        
        Change-Id: Id62389b1a11cd0ec2d04923d037ddcf3ab6b71f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168856
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [a9bc3ea1bef2a6b622a729dfa18eb3851ce7101e]

        tdf#161346 sw: PDF export: fix crash on field in hidden text frame
        
        When creating a link rectangle for a SwGetRefField, the problem is that
        the cursor is positioned on 2 different nodes with 2 different text
        frames, neither of which is the node that contains the field; this
        happens because that node's text frame has a height of 0, so IsSelOvr()
        moves the cursor to a previous node.
        
        Check that SwCursorShell::GotoFormatField() did in fact go to the field.
        
        (regression from commit 9ba8d68c2b2fd06340bbdcb61dc3d57f6e3eb974)
        
        Change-Id: Ib74533f46dce8fb05224fddfff12e49577346b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168860
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [006540e773bc552fa5d7eda47be43a151b91aed9]

        CppunitTest_sc_jumbosheets_test: inherit from ScModelTestBase
        
        Change-Id: Ifc35741c0d46dfbf3366696ea70284c382617a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168861
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [00ed1c5c02c20b98dc70ef9e01c9280d9d6b5193]

        Make isProductVersionUpgraded update ooSetupLastVersion again
        
        This was changed in commit dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1
        (Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog,
        2024-03-27).
        
        This change doesn't require opening a module (and checking if WhatsNew
        dialog is needed) to update the configuration - it will be updated
        immediately in runGraphicsRenderTests.
        
        Change-Id: I595b6898c46998e7a0805ffbf7a710dbf0d2a5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168855
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-14  Miklos Vajna  <vmiklos@collabora.com>  [99500569187101cd47b2a491ca8d8878eb034b2e]

        Update pdfium to 6536
        
        Drop part of build.patch.1, which is no longer needed.
        
        Change-Id: Ie68364d473d344904fd55ced2cd0915534fa816c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168838
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [69d873e1c46f3cc8c524e18ac5a307a8d32ddd0f]

        tdf#158658 sw: text formatting: make TabOverMargin even more crazy
        
        ... to better match Word's formatting.
        
        The bugdoc has a special case where a right-aligned tab is positioned at
        the right margin exactly, which causes the bFull condition in
        SwTabPortion::PreFormat() to be true.
        
        An obvious change to replace rInf.Width() - rInf.X() with
        rInf.GetLineWidth() in the condition makes no difference because
        m_pLastTab was already reset previously; instead, pass in the last tab
        from Format(), which indicates that the right edge position of the
        previous text portion was found via that tab.
        
        Additionally, change the condition that checks for TabOverMargin to also
        allow equal positions, i.e., exactly at the end of the paragraph.
        
        Change-Id: I5d3b1c13eca0bffa640745d7c5f4113699f79cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168823
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [10d753b8aadb50ec4309551b97d4cf2163ea3e3d]

        tdf#158658 sw: text formatting: try to make TabOverMargin more crazy
        
        ... to better match Word's formatting; this commit is not based on a
        complete diagnosis of Word's compatibility-mode tab-in-margin
        formatting disorders.
        
        1. in SwTabPortion::PreFormat() allow a left aligned tab beyond the
           width of the paragraph, like already done for TabOverSpacing
        
        2. in SwTextFormatInfo::GetLineWidth() add some extra width to the
           paragraph so text can be hidden in the right margin.
           (it's very unclear what Word does here exactly, in one case it puts
           339 additional "a" characters in the margin but then the 340th "a"
           goes onto a new line...)
        
        3. in SwTextFormatter::NewTabPortion() allow manual tab stops to be
           positioned beyond the width of the paragraph, like already done
           for TabOverSpacing
        
        testTdf118672, testTdf120287b, testTdf120287c fail but the files,
        converted to RTF, render in Word 2013 basically the same as in Writer
        with this change.
        
        Change-Id: I5f74ced09c704bfd9967df61351c8bac6540e714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168819
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [37422f16fe56ca10cda549af03b165bf28c9e099]

        sw: show "wait" pointer while accessibility check is running
        
        Change-Id: I234af45560db7940d07669be9abd1b1ec50a74cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167880
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 10ef0f03bb6a9efc0dcabe8710b59bd7b41a2fcf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168783
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-14  Oliver Specht  <oliver.specht@cib.de>  [6a36c75fae892edcfd058abf9fd075216573c330]

        prefer simple HTML format over RTF while pasting clipboard content
        
        This changes applies to draw text, only
        JUnit test is included
        Basic HTML table import is included.
        
        Change-Id: I00387f3932c0aa54099c9bc7390ad86b4398b417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162871
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e33dff4252f3124c7ecc591befa56f0fb0e1895]

        tdf#144208 speedup doc with lots of redline (10)
        
        don't call SwRDFHelper::getStatements for every single paragraph, we can
        call this once and re-use the result
        
        Change-Id: I0277ecbb113b8333839172bddd7978f4b3a7259a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168850
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [f97008c50ff88a7cf0a80a583a743ee1fb041327]

        sw: fix SwTextFrameInfo::GetSpaces() for line containing only spaces
        
        This would assert:
        frminf.cxx:139: void AddRange(): Assertion `rRanges.empty() || rRanges.back().second <= nPos' failed.
        
        Change-Id: Ib41f4c6c971fee9307140c108e74d5df7d94c973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168824
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-14  László Németh  <nemeth@numbertext.org>  [2f0c7d5691acd4010443856788a54b0abc03098b]

        tdf#161563 tdf#161565 sw: add No Break to word context menu & visualize
        
        Add No Break option to context menu of words hyphenated automatically,
        giving as easy access to fix paragraph layout, as context menu of
        misspelled words – like DTP software do. Also add this option to context
        menu of words with enabled "No Break" to disable it.
        
        To avoid unwanted paragraph layout during further text editing or
        formatting, visualize words excluded from hyphenation with a light
        gray dotted underline, when Formatting Marks is enabled.
        
        Follow-up to commit b5e275f47a54bd7fee39dad516a433fde5be872d
        "tdf#106733 sw: implement CharNoHyphenation" and
        commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372
        "tdf#106733 xmloff: keep fo:hyphenate in character formatting".
        
        Change-Id: I81bb410abcf999c8d9a3dca28acfc5c21aa0f260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168827
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbcc7f7c609ff9254ff3f44f0cb6cc4ae20e72e7]

        tdf#144208 speedup doc with lots of redline (9)
        
        only compute start/end once, the cost of calculating them is not trivial
        
        Change-Id: I48d001be00359c50ec8ca28134079d062867a520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168839
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [e7455c7e38e3fe4538faf9bbbe834d01815a7678]

        Flatten a bit
        
        Change-Id: If021f2edf8e4029d22118a2ed369b21a3a7215da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168836
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ad5e3b9b509a455b481a9e6bdf4902dbf60c305a]

        annot: make sure the annotation subtypes in PDFium match with ours
        
        Change-Id: Ic18f394b532118f39988a650d046880b049c9ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168810
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [647642468d42aba2e259d85d068652756d5aa20c]

        annot: read PDF FreeText annotation "DS" and "RC" keys
        
        DS (DefaultStyle) and RC (RichContent") contain xhtml, css3 rich
        text content for the text presented by the FreeText annotation in
        the document. This adds reading of those 2 things to the PDFium
        library, PDFium based import and the PDFAnnotationFreeTextMarker
        class.
        
        Change-Id: I32f89640611c730c8a1a8d1a2107e2e11669ec18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168787
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [ffa5c8e13970403319a6761811fd79fb51dbaff7]

        tdf#161338: Pass a flag to ScDocument::Solver to avoid #NA! on error
        
        This fixes the remaining problems:
        1. It didn't restore variable cells with text of formulas properly.
        2. Undoing after accepting the "closest value" dialog gave #NA! in
           the variable cell.
        
        This doesn't change the behavior of XGoalSeek::seekGoal.
        
        Change-Id: Ic9fbd3c99e6491b1c54b2e3b334090e51b1be661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168763
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [16f990255128ec32996ea92a726ffc34d9ea2fac]

        vcl: convert PDFiumLibraryTest to CPPUNIT_TEST_FIXTURE
        
        Change-Id: I5022bec2622c7dc7ddf1e58b4a370551574281c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168786
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [66a68fcb5639c3f0e42385fcdb08f16b9c96f243]

        annot: add support to import Stamp annotation from PDF
        
        Stamp annotation shows an arbitrary bitmap in the document, where
        the most common bitmaps are stamps like "Approved", "Confidential",
        "Expired", "Sold",...
        
        Change-Id: I332e34cbb346a686ee16eac7ca437ec4048e65ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168760
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0fb1e4e9a74b566fb075a58ae2c7632f2cc068de]

        annot: add annotation marker for free text annotation
        
        Added new class PDFAnnotationMarkerFreeText as we need a marker to
        know if the annotation is a special one.
        
        Change-Id: Ica0e72dd6bf62b322676c8e87659a3850074522a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168759
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-13  Hossein  <hossein@libreoffice.org>  [0e2409e5e3c73ec25c61aa4ea140d114869ea512]

        tdf#156717 Fix "LibreOffice Community" in PDF metadata
        
        These settings are available to set the brand when building LibreOffice:
        
        1) Community flavor: yes / no
        This is set via --disable-community-flavor, that defines
        HAVE_FEATURE_COMMUNITY_FLAVOR, which is used in cui/source/dialogs/about.cxx.
        
        2) Product name: A string (set via --with-product-name='name')
        This defines PRODUCTNAME, which is used in many places in the code.
        
        Not every LibreOffice build is a "LibreOffice Community" flavor. This
        patch fixes this issue by using community brand only when variable
        HAVE_FEATURE_COMMUNITY_FLAVOR is set.
        
        Change-Id: Ib74450f380fed7c24222f88e389ddb5363bda3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168676
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-06-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [a38180b5393e07d55d21bc2d43a8febe574fe240]

        README.md: add Python baseline
        
        Change-Id: Iffb83588cead716b009578d0f571f3d9cd2e83d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168818
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-06-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7f8b22df80a29b1cb787ca78d3112f62e550632e]

        Let ScDocShell::GetLinkUpdateModeState honor isUntrustedReferer
        
        Change-Id: I358911ad5180548767eadac3d15d0583598fe5e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168814
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2b250d2dbfa907a2eb571c5c4cb36b00c908bdc6]

        Let LinkManager::UpdateAllLinks honor isUntrustedReferer
        
        Change-Id: I3714061376afaf1186e4f7cfe5b28bfb54aa7a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168789
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [902541d805c7de0c2f10b1c9ed5520a1e6ce5d12]

        loplugin:ostr in sw/qa
        
        Change-Id: Ib67997a3f491afaec380ef65bc60588362d9cc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [12e48f91d488e6ce42cf1c361e782ab8a2737c4c]

        loplugin:ostr in sw/../core
        
        Change-Id: I69cf0cc769861a24a7239ad82c0c46a12dbed5f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168811
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [91955babdb99cddef764a8467ee7e2e5bfa6f7d3]

        use more concrete UNO types in OStorage
        
        Change-Id: Iab01137ad1ad8ea68b5a98ae4c251389a1748da1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5dc1d4453738876c0576c45b826b9f01d29e8905]

        use more concrete UNO types in StatusIndicator
        
        Change-Id: I7266cded882bb2d4eb00bdfe565b7c4085c1459d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168777
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [78edbb9f6f6957c625fdf6ae4e9834e10e20a57a]

        use more concrete UNO types in XFrameImpl
        
        Change-Id: I5cb9a5bc02fd2d526d39c637e34715f501769034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168776
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [e133fd4eaec490da100b4fae45657573f466f0e1]

        use more concrete UNO types in ProgressBarWrapper
        
        Change-Id: Ia7f3f3cef44ee7db6850a75c3de307a8b35e3263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad51d8b6f691524f3c6d270419264e3d2e1201b6]

        tdf#144208 speedup doc with lots of redline (8)
        
        re-arrange the loops so that we only do the insert if we
        see a mark or a redline that we are actually interested in.
        This avoids a chunk of work when we hit the nasty nodes that have
        600 marks attached to them.
        
        Change-Id: I9dae831ceaf0f09ac5a2d985a54f6690f7eef0a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [cdde0d59ac67cd9a26671822b02d04b07b2dd754]

        libxslt: upgrade to 1.1.40
        
        Downloaded from https://download.gnome.org/sources/libxslt/1.1/libxslt-1.1.40.tar.xz
        
        * libxslt-1.1.26-memdump.patch is no longer needed
        
        Change-Id: I72829ce590d7fd73a1364139bf3c373d6cd4d1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168782
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [752436502c8ef19d93e4a211431b9be637261d07]

        annot: update annotation object when annotation position changes
        
        + add tests which check annotation object position changes
        
        Change-Id: Iad5de3d319c14ddb69d6c1994ce5949d57d76de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168744
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-13  HakimOttey  <hakimotteybusiness@gmail.com>  [c0adf5a90a51f500d633aad9786015f187531d31]

        Related: tdf#147906 Rename fQuadDist to pointDistance
        
        after
        
        commit 9dad7c0f1095e85ad40ad874215f1051137b0347
        Author: HakimOttey <hakimotteybusiness@gmail.com>
        Date:   Mon May 6 12:44:29 2024 -0400
        
            tdf#147906 implement hypot function for s1 x s1 + s2 x s2 statements
        
        where the names were kept, but became confusing.
        
        Change-Id: If2bfa4b5fc1dd04bb4f1026b6f89e3c97a43caf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167850
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-13  Laurent Balland  <laurent.balland@mailo.fr>  [bd2ffb6f33e549483b41f6235ba64fa735205d38]

        tdf#159930 Treat special case with no integer digit
        
        Number format with no integer digit, such as "+.##;-.##"
        was placing string with the decimal separator.
        This change insert string at the begining of the number string as
        expected.
        This format code is saved as "+#.##;-#.##" in ODF, but display is the
        same; so no change is made on this side.
        
        Add unit test for this format
        
        Change-Id: I74fbe0e9a5303672ac7927d37922c06a762feba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168577
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-06-13  Michael Weghorn  <m.weghorn@posteo.de>  [542e590f6a35a350cb6bc53645462a273017258d]

        gen: Handle null client ID when SmcOpenConnection fails
        
        Trying to start LO with the gen/x11 VCL plugin in my KDE Plasma 5
        Wayland session triggered this assert:
        
            soffice.bin: .../libreoffice/sal/rtl/strtmpl.hxx:148: sal_Int32 rtl::str::getLength(const T *) [T = char]: Assertion `pStr' failed.
        
            Thread 1 "soffice.bin" received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a6b6f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff78584e2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78414ed in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007ffff7841415 in __assert_fail_base
                (fmt=0x7ffff79b7ba8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7ffff7ea47e1 "pStr", file=file@entry=0x7ffff7e9fa78 ".../libreoffice/sal/rtl/strtmpl.hxx", line=line@entry=148, function=function@entry=0x7ffff7ea58ba "sal_Int32 rtl::str::getLength(const T *) [T = char]") at ./assert/assert.c:92
            #5  0x00007ffff7851002 in __assert_fail
                (assertion=0x7ffff7ea47e1 "pStr", file=0x7ffff7e9fa78 ".../libreoffice/sal/rtl/strtmpl.hxx", line=148, function=0x7ffff7ea58ba "sal_Int32 rtl::str::getLength(const T *) [T = char]") at ./assert/assert.c:101
            #6  0x00007ffff7f33e2b in rtl::str::getLength<char>(char const*) (pStr=0x0) at sal/rtl/strtmpl.hxx:148
            #7  0x00007ffff7f36ac9 in rtl::str::newFromStr<_rtl_String>(_rtl_String**, std::remove_extent<decltype (_rtl_String::buffer)>::type const*) (ppThis=0x7fffffff7970, pCharStr=0x0) at sal/rtl/strtmpl.hxx:862
            #8  0x00007ffff7f32e9d in rtl_string_newFromStr(rtl_String**, char const*) (ppThis=0x7fffffff7970, pCharStr=0x0) at .../libreoffice/sal/rtl/string.cxx:567
            #9  0x00007fffe46efea7 in rtl::OString::OString<char*>(char* const&, rtl::libreoffice_internal::CharPtrDetector<char*, rtl::libreoffice_internal::Dummy>::Type) (this=0x7fffffff7970, value=@0x7fffffff7978: 0x0)
                at include/rtl/string.hxx:315
            #10 0x00007fffe4711954 in SessionManagerClient::open(SalSession*) (pSession=0x5555567f1bf0) at .../libreoffice/vcl/unx/generic/app/sm.cxx:514
            #11 0x00007fffe4710f94 in X11SalInstance::CreateSalSession() (this=0x5555555ee3d0) at .../libreoffice/vcl/unx/generic/app/sm.cxx:73
            #12 0x00007fffee985cfc in (anonymous namespace)::VCLSession::VCLSession() (this=0x555556903480) at .../libreoffice/vcl/source/app/session.cxx:115
            #13 0x00007fffee985ba9 in com_sun_star_frame_VCLSessionManagerClient_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) ()
                at .../libreoffice/vcl/source/app/session.cxx:411
            #14 0x00007ffff5bed248 in std::__invoke_impl<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(std::__invoke_other, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
                (__f=@0x5555557170f8: 0x7fffee985b80 <com_sun_star_frame_VCLSessionManagerClient_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, __args=@0x7fffffff8600: 0x5555555e7f08, __args=empty uno::Sequence) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61
            #15 0x00007ffff5bed1e5 in std::__invoke_r<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
                (__fn=@0x5555557170f8: 0x7fffee985b80 <com_sun_star_frame_VCLSessionManagerClient_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, __args=@0x7fffffff8600: 0x5555555e7f08, __args=empty uno::Sequence) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:114
            #16 0x00007ffff5bed0dd in std::_Function_handler<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__functor=..., __args=@0x7fffffff8600: 0x5555555e7f08, __args=empty uno::Sequence) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290
            #17 0x00007ffff5bb8d98 in std::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const (this=0x5555557170f8, __args=0x5555555e7f08, __args=empty uno::Sequence) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591
            #18 0x00007ffff5ba1599 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
                (this=0x555555717040, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08) at .../libreoffice/cppuhelper/source/servicemanager.cxx:701
            #19 0x00007ffff5ba1461 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool)
                (this=0x555555717040, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08, singletonRequest=false) at .../libreoffice/cppuhelper/source/servicemanager.cxx:670
            #20 0x00007ffff5ba73ad in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&)
                (this=0x555555618b60, aServiceSpecifier="com.sun.star.frame.SessionManagerClient", Context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08)
                at .../libreoffice/cppuhelper/source/servicemanager.cxx:1002
            #21 0x00007ffff5ba7d94 in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) ()
                at .../libreoffice/instdir/program/libuno_cppuhelpergcc3.so.3
            #22 0x00007ffff4e6a528 in (anonymous namespace)::SessionListener::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x555556935c80, args=uno::Sequence of length 1 = {...})
                at .../libreoffice/framework/source/services/sessionlistener.cxx:254
            #23 0x00007ffff5ba1b79 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x555555684900, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08, arguments=uno::Sequence of length 1 = {...})
                at .../libreoffice/cppuhelper/source/servicemanager.cxx:727
            #24 0x00007ffff5ba19e3 in cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x555555684900, context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08, singletonRequest=false, arguments=uno::Sequence of length 1 = {...})
                at .../libreoffice/cppuhelper/source/servicemanager.cxx:689
            #25 0x00007ffff5ba7e35 in cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x555555618b60, ServiceSpecifier="com.sun.star.frame.SessionListener", Arguments=uno::Sequence of length 1 = {...}, Context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08)
                at .../libreoffice/cppuhelper/source/servicemanager.cxx:1014
            #26 0x00007ffff5ba7eec in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at .../libreoffice/cppuhelper/source/servicemanager.cxx:1015
            #27 0x00007ffff7b3787f in com::sun::star::frame::SessionListener::createWithOnQuitFlag(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, unsigned char)
                (the_context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x5555555e7f08, AllowUserInteractionOnQuit=0 '\000') at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/frame/SessionListener.hpp:48
            #28 0x00007ffff7b2c353 in desktop::Desktop::OpenClients() () at .../libreoffice/desktop/source/app/app.cxx:2094
            #29 0x00007ffff7b2b0a3 in desktop::Desktop::OpenClients_Impl(void*) (this=0x7fffffffd708) at .../libreoffice/desktop/source/app/app.cxx:1952
            #30 0x00007ffff7b2939d in desktop::Desktop::LinkStubOpenClients_Impl(void*, void*) (instance=0x7fffffffd708, data=0x0) at .../libreoffice/desktop/source/app/app.cxx:1936
            --Type <RET> for more, q to quit, c to continue without paging--
            #31 0x00007fffee140c78 in Link<void*, void>::Call(void*) const (this=0x555556f67218, data=0x0) at include/tools/link.hxx:111
            #32 0x00007fffee13c959 in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x555556f67210) at .../libreoffice/vcl/source/window/winproc.cxx:2287
            #33 0x00007fffee139310 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x555556dcc250, nEvent=SalEvent::UserEvent, pEvent=0x555556f67210)
                at .../libreoffice/vcl/source/window/winproc.cxx:2851
            #34 0x00007fffeedb53e0 in SalFrame::CallCallback(SalEvent, void const*) const (this=0x5555568f41f0, nEvent=SalEvent::UserEvent, pEvent=0x555556f67210) at vcl/inc/salframe.hxx:312
            #35 0x00007fffeeddff6f in SalGenericDisplay::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x5555567e8960, aEvent=...) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:66
            #36 0x00007fffee8d856d in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const (this=0x7fffffffb240) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119
            #37 0x00007fffee8d8414 in SalUserEventList::DispatchUserEvents(bool) (this=0x5555567e8960, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120
            #38 0x00007fffeeddfec5 in SalGenericDisplay::DispatchInternalEvent(bool) (this=0x5555567e8960, bHandleAllCurrentEvent=false) at .../libreoffice/vcl/unx/generic/app/gendisp.cxx:51
            #39 0x00007fffe46feb44 in SalX11Display::Yield() (this=0x5555567e8960) at .../libreoffice/vcl/unx/generic/app/saldisp.cxx:1860
            #40 0x00007fffe46f2e97 in DisplayYield(int, void*) (fd=5, data=0x5555567e8960) at .../libreoffice/vcl/unx/generic/app/saldisp.cxx:321
            #41 0x00007fffe46ee64c in (anonymous namespace)::YieldEntry::HandleNextEvent() const (this=0x7fffe47fe078 <yieldTable+200>) at .../libreoffice/vcl/unx/generic/app/saldata.cxx:559
            #42 0x00007fffe46ede15 in SalXLib::Yield(bool, bool) (this=0x5555555ee6e0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/unx/generic/app/saldata.cxx:655
            #43 0x00007fffe470ce8d in X11SalInstance::DoYield(bool, bool) (this=0x5555555ee3d0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/unx/generic/app/salinst.cxx:192
            #44 0x00007fffee9b8e6c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:384
            #45 0x00007fffee9b877b in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:472
            #46 0x00007fffee9b8512 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:359
            #47 0x00007ffff7b26f10 in desktop::Desktop::Main() (this=0x7fffffffd708) at .../libreoffice/desktop/source/app/app.cxx:1652
            #48 0x00007fffee9dba7e in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229
            #49 0x00007fffee9ddaa9 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261
            #50 0x00007ffff7baaa7c in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:99
            #51 0x0000555555555a5d in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #52 0x0000555555555a37 in main (argc=2, argv=0x7fffffffd918) at .../libreoffice/desktop/source/app/main.c:49
        
        `SmcOpenConnection` in frame 10 above failed, `pClientID` is null:
        
            (gdb) frame 10
            #10 0x00007fffe4711954 in SessionManagerClient::open (pSession=0x5555567f1bf0) at .../libreoffice/vcl/unx/generic/app/sm.cxx:514
            514                 m_aClientID = OString(pClientID);
            (gdb) p pClientID
            $1 = 0x0
            (gdb) l
            509                                                       aErrBuf );
            510                 if( !m_pSmcConnection )
            511                     SAL_INFO("vcl.sm.debug", "  SmcOpenConnection failed: " << aErrBuf);
            512                 else
            513                     SAL_INFO("vcl.sm.debug", "  SmcOpenConnection succeeded, client ID is " << pClientID );
            514                 m_aClientID = OString(pClientID);
            515                 free( pClientID );
            516                 pClientID = nullptr;
            517             }
            518
            (gdb) p aErrBuf
            $2 = "None of the authentication protocols specified are supported", '\000' <repeats 963 times>
        
        Add a null check.
        
        Quoting from [1]:
        
        > If SmcOpenConnection succeeds, it returns an opaque connection pointer of type SmcConn and
        > the client_id_ret argument contains the client ID to be used for this session.
        
        [1] https://www.x.org/releases/X11R7.6/doc/libSM/SMlib.html
        
        Change-Id: I412b5a68e88548718231354b0410c56bc0f0bb90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168771
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-13  Michael Weghorn  <m.weghorn@posteo.de>  [f281b70282bcead3fca9c5a783e4584144d92a51]

        tdf#160462 qt a11y: Open menu bar on F10
        
        F10 is used as a shortcut to open the menu bar (or main menu)
        on various platforms and toolkits, and KDE adapted that
        for KF 6 as well, see [1].
        
        Do the same for the Qt-based VCL plugins: Connect a slot
        to the F10 shortcut that opens the first menu item.
        
        [1] https://wordsmith.social/felix-ernst/f10-for-accessibility-in-kf6
        
        Change-Id: I27e34f87a115b89e047b08aed334207c64b0b9e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168765
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [96f22f5e5302e030fcbc939ef94b7c1fd2748df2]

        tdf#160401: vcl_pdfexport: Add unittest
        
        Change-Id: I92649734bad553d07e0b37d80f804638aacd89fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168780
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-13  Mike Kaganski  <mike.kaganski@collabora.com>  [231722a7791df5e4315aefa1cc902bc1c0dc2e00]

        tdf#161511: create column if not exists
        
        Change-Id: I56a4792beab4c98a676b10d975fcd9be3fbef3ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168767
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ee206e25852ba47824ceb910fe67a83825bb19b3]

        put the font test before the script test
        
        no difference at all, just annoying to be different to its sibling
        checks
        
        Change-Id: I1713958f2d2d425d47c626f72a3aa0f3c687526e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a902f5c5a269621139c933ad50e2b178bf764df3]

        cid#1603615 silence Using invalid iterator
        
        and
        
        cid#1603624 Using invalid iterator
        
        Change-Id: I9a067b92feb57771eaa1743646113b026753a410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168770
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b04a6494cdf462266333c23ebc943ceca40c20cf]

        cid#1603626 silence Dereference null return value
        
        Change-Id: I2da354ffc2ed28df1744bad7762413431b894f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168769
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [254c8b1cc2a05ac4f2058c8d06eff3c4638b406d]

        cid#1603616 silence Dereference null return value
        
        Change-Id: I121cf996cda47f355a603c2e6274e50622930d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5a72adc1c39e4e2765da00475213d193350de84c]

        cid#1603631 Dereference null return value
        
        pColList is unused anyway, so just remove it
        
        Change-Id: Iac5667d55c78463a0eca2edfa8699dcd87cfc16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168766
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [1a7c927f6fb8fc4f6f2277a8442ce4b37f1ffccf]

        tdf#161213: fill can use context-stroke and vice versa
        
        Change-Id: Id127bd4943ff1b67915d1de3ba4fcf93dab21423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168774
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [27e9fd67260b8ad321cf0f8722e2db8a08473927]

        tdf#144208 speedup doc with lots of redline (7)
        
        reduce dynamic_cast cost
        
        Change-Id: I724fb5cfa7961d68c7011255d4ed5c2c89974566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168764
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-13  Miklos Vajna  <vmiklos@collabora.com>  [a0b6587c4acb1d74e1b00904147821640c98b323]

        tdf#161199 sw DoNotCaptureDrawObjsOnPage: capture wrap=none draw objects
        
        Regression from commit af313fc149f80adb0f1680ca20e19745ccb7fede
        (tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat
        option, 2017-01-06), the second page of the document has an off-page
        positioned draw shape, which is still kept inside the page frame in
        Word, but not in Writer anymore.
        
        Reading the SwAnchoredObjectPosition::GetInfoAboutObj() code, there are
        a number of conditions at play here, but the relevant one is that fly
        frames have the restriction that the "do not capture" behavior is
        restricted to wrap=through, but the wrap type was ignored in the draw
        shape case.
        
        Fix the problem by being consistent here: require wrap=through for both
        fly frames and draw shapes that moves the shape back inside the page
        frame.
        
        Note that Word goes a bit further here and even keeps the shape inside
        the body text area, but that doesn't seem to be a regression, so leave
        that unchanged for now.
        
        Change-Id: I3b6331c13d2376cac9b0de90f6f57289a7a0f0e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168762
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-13  Michael Weghorn  <m.weghorn@posteo.de>  [e702e27795bc32de9c68ed05fd4f3476b8d1ebc2]

        Handle CPDB lib in configure/build system
        
        In preparation of Biswadeep's upcoming GSoC changes (see [1])
        to update the CPDB (Common Print Dialog Backends) support to the
        latest version and use the CPDB C API, add a
        corresponding `--enable-cpdb` autogen option
        (disabled by default).
        
        When CPDB is enabled, check for the cpdb-frontend
        library, define `ENABLE_CPDB` and set the compiler
        and linker flags for building the `CPDManager`
        (in vcl/unx/generic/printer/cpdmgr.cxx).
        
        Add checks for existing code using `CPDBManager`,
        so it only gets used when when CPDB is actually enabled.
        
        While the cpdb-frontend library is currently not
        actually used in `CPDManager` yet (as the previous approach
        tried to use some DBUs API directly), it will be in
        Biswadeep's upcoming changes.
        
        With this commit in place, an `--enable-cpdb` build
        works with this additional local test change in place
        to actually make use of the library:
        
            diff --git a/vcl/unx/generic/printer/cpdmgr.cxx b/vcl/unx/generic/printer/cpdmgr.cxx
            index 7dc17cede353..0c3b71d519db 100644
            --- a/vcl/unx/generic/printer/cpdmgr.cxx
            +++ b/vcl/unx/generic/printer/cpdmgr.cxx
            @@ -22,6 +22,8 @@
             #include <cstddef>
             #include <unistd.h>
        
            +#include <cpdb/cpdb-frontend.h>
            +
             #include <unx/cpdmgr.hxx>
        
             #include <osl/file.h>
            @@ -259,6 +261,7 @@ CPDManager* CPDManager::tryLoadCPD()
                     }
                 }
             #endif
            +    cpdbPrintFile(nullptr, nullptr);
                 return pManager;
             }
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2024-May/091911.html
        
        Change-Id: Ifc50d2cd6496346bea55c73cb703e3c2d3eb44b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168656
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Biswadeep Purkayastha <bpdps95@hotmail.com>

2024-06-13  Mike Kaganski  <mike.kaganski@collabora.com>  [e74c94c1a6ae47eb507eec610e231ebb6b02a8be]

        tdf#161509: Output the same special style names and identifiers as Word
        
        Take care to match the case of the names. Some tools rely on specific
        case; so standardize on what Word outputs.
        
        getXPath is modified to tell which XPath has failed (needed for the
        unit test).
        
        Change-Id: I3e71f5905b26d7e784d68ba11ff205eefedaaa2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168755
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [daedc81fa22690ce1a08b477a52360f05e4f5ed9]

        tdf#161462 Remember Goal Seek settings
        
        Each time the user opens the Goal Seek dialogs, all settings are reset. This patch makes these settings be remembered during the same session.
        
        Change-Id: I60a121b4001f4666ee25ab807fdc3860cf798296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168683
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-12  Jonathan Clark  <jonathan@libreoffice.org>  [95dd795e7510e62e9fc316e5ac8c1057b58a8f4e]

        Related: tdf#161533 Test fixes for CJK systems
        
        Previously, `CppunitTest_sw_txtexport` and `CppunitTest_sw_txtimport`
        passed on most systems, but failed on fontconfig systems with CJK
        fallback fonts available.
        
        This change updates `CppunitTest_sw_txtexport` to remove the CJK
        requirement.
        
        This change also updates `CppunitTest_sw_txtimport` to temporarily
        remove `SAL_NON_APPLICATION_FONT_USE=abort`, which was responsible for
        the test failure.
        
        Change-Id: I0a91f5cccb367825adbcd0f93abbc3b8e9005698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168752
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f463d9e8e93aa9feca889ad7a0ea30f62d797df4]

        Fix typo in code
        
        Change-Id: Id4174ad178558c6016925007c0f62e0886750279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168754
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bd5854b7d5ca488b200c78fce7174ca3b0e94170]

        Fix typo
        
        Change-Id: I4982c9cb6e45c05a336919bfce47cfc757fb89e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168753
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  László Németh  <nemeth@numbertext.org>  [ca540209a8c20a2734f180d4706d5153bdf64523]

        tdf#160170 sw: fix overshrunk justified lines at hyphenation
        
        Smart justify uses 2 SwTextGuess::Guess() calls to break a
        line, but using the same SwTextGuess object resulted overshrunk
        lines, if the first call resulted hyphenation, because of the
        bad state of the object for the second call. If we need a
        second call, now instantiate a new object for it.
        
        Regression from commit 36bfc86e27fa03ee16f87819549ab126c5a68cac
        "tdf#119908 tdf#158776 sw smart justify: shrink only spaces".
        
        Note: the reported test document was already fixed by
        commit f050103c3324d878b310f37429ea3580a8230905
        "stale hyphenation data after skipping blanks".
        
        Change-Id: I478407dc7650206d3feb72d5b89e78b1194590c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168693
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-12  Patrick Luby  <guibmacdev@gmail.com>  [195ed184dd1552816bdebfe9c54fb6408bf91cc1]

        tdf155212 clear the cached system font list after loading a font
        
        If the system font is not cached in SalData, loading embedded
        fonts will be extremely slow and will trigger each frame and each
        of its internal subframes to reload the system font list when
        loading documents with embedded fonts.
        
        So instead, reenable caching of the system font list in SalData
        by reverting commit 3b6e9582ce43242a2304047561116bb26808408b.
        Then, to prevent tdf#72456 from reoccurring, clear the cached
        system font list after a font has been loaded or unloaded.
        This should cause the first frame's request to reload the cached
        system font list and all subsequent frames will avoid doing
        duplicate font reloads.
        
        Change-Id: If2a36f8c17d8e25f818275f30a19af8517478884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168734
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d28a000130e5739af90e771d46faa630823add29]

        Resolves: tdf#160635 allow larger tiff images
        
        Change-Id: I67a21877e7e75c2753218a7e6c978f691d679583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [5723e2054bb90f07fff7368e3f38fbe0311f6b83]

        tdf#144208 speedup doc with lots of redline (6)
        
        implement a mechanism to look up annotation by name instead of iterating
        through all of them.
        Shaves 5% off the load time
        
        Change-Id: I14bf46cf2aebc5d4b019a3428107b46ac82c5087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168705
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-12  Henry Castro  <hcastro@collabora.com>  [c69b0d3b58523a1c981e973d1c9d3107257dd84c]

        lok: sw: fix PageDown position when cursor is not visible
        
        If PageDown key is pressed and the cursor is not visible,
        in the PageDown increment the new cursor position will not update,
        cause the Visible area is the full document.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I57b9ae1e80cb8aaaa78867ee215d7e80de990aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168646
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168746
        Tested-by: Jenkins

2024-06-12  RMZeroFour  <ritobroto04@gmail.com>  [6538b3b09cf5a3c8fc6d9882dc817afd59c3599c]

        .NET Bindings: Add DotnetLibrary class to gbuild
        
        This commit adds the DotnetLibrary gbuild class to build a .NET assembly
        using the .NET SDK.
        
        Also adds an option to enable or disable building .NET components with
        --enable-dotnet (default) and --disable-dotnet to the autogen script.
        
        Also adds a net_ure/ directory for the updated .NET bindings, currently
        consisting of the net_basetypes library.
        
        Change-Id: I9256387a2463ff8476deee85d886c6b3dce8257b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166380
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ad110499343d2ec0469e605168c1c1cd129d0e7]

        Resolves: tdf#160401/#i78474# small caps do not exist in CTL fonts
        
        so turn that off here in editeng where we know the script type
        
        Change-Id: I8e385d35910e378655deb21bce89c4335724a36d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [e406fc87d631cb2edf3c6dec70772cd0511a251c]

        libxml2: upgrade to 2.12.8
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.12/libxml2-2.12.8.tar.xz
        
        Change-Id: Ie6c0d102b44eaec14fabaf932ba140a113ff5073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168708
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8eaea7ee848a68094532522e5f634105cfc42998]

        Fix typo
        
        Change-Id: I4dd1f818a0b9e14ec0ec48533b0dc3682ff9e407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168735
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [100ef8c97ccabad3601f0ec4541583e29692541c]

        Fix typo
        
        Change-Id: I59c693c258077fbc36587526901a5453218496ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168736
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [102deebcee2608a18ed73affef6c64da29653c89]

        Fix typo
        
        Change-Id: I2a1f8989d9d9d59dd5660efe7dd2c8cfde95b838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168738
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f538c3533ba4f967a60154fdd7d93fa73e46420b]

        Fix typo
        
        Change-Id: I4e7145380f70db50f8dee898318eee52e6f03f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168737
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [343140f53ede3a66ad2b96f347e3d988d64e2eaf]

        Fix typo
        
        Change-Id: I435a2feb59c895f4f0e0ea04eb5a028058a724a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168739
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f82529f388a1109ee1ef7ac1e108a4614805a833]

        Fix typo
        
        Change-Id: Ie49ab628ecf6ce6a02514e45867195dfd897afab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168741
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f7e2b7111c49d4dcb29be7be67a7eaa2a3cf08b]

        Fix typo
        
        Change-Id: I970ffb2ebf8554af5bd0a3edc975c56f609accc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168740
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4f439ac8d52d2f9736332591909b6f0d5238e6fb]

        Fix typo
        
        Change-Id: I80cdffc91086cfa06125d3399c4b896de3836e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168743
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c8bfcb2aa1723b67d1b4f0ec7c3b6a80562de09]

        Fix typo
        
        Change-Id: Icad08d56c54b79733aa7737c312d704feb9b6554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168742
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5459254a88c89af173085e45f425fd739fd63f4e]

        Embind: Let unoObject return a css.uno.XInterface reference
        
        ...and confine the _impl map to an internal detail.  Client code should have no
        need to access that _impl map (renamed here to impl_interfaces), nor the
        Module.uno_Type_*.reference functions (nor the Module.uno_Type_*.implement
        functions).
        
        Change-Id: Ic9c74f22cedb9b5eeecb42d7c13ee0555e92690d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168732
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a17f27e77bef2262ffa9b4e769c71e1c4d4fa6c2]

        Remove leftover work-in-progress line
        
        Change-Id: I0faf224ea51df733cba2edc5e52b1a71c0e96140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168731
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [d05f1ec2e20eb86ceb99e9ff5d4efb9ff9356dbb]

        tdf#161338 Do not change variable cell when Goal Seek fails
        
        When Goal Seek fails, N/A error is inserted in the cell even if the user chooses No in the message dialog.
        
        Note that the solver definition in ScDocument::Solver forcefully inserts N/A when the solver fails, which seems to be usefull when creating scripts that use the Goal Seek. However, this behavior is not usefull when using the UI.
        
        This patch restores the original value of the variable cell when Goal Seek fails.
        
        Change-Id: I52d83b9de9b13667a81dd4a3ae8ab1c8545d6958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168537
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-06-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [887ebfd6e56069d281cd0c1ce893b794a3d854d3]

        Embind: Centrally initialize via Module.initUno() in a new uno.js
        
        ...so that the unoObject function can be moved there too (so that other code
        outside embindtest.js can reuse it)
        
        Change-Id: Id3edb7cede56321db29ba435f221cb7702a3513c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168700
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [13874ba730ed94a38271e3b053e11a28f7d8268f]

        tdf#144208 speedup doc with lots of redline (5)
        
        no need to call compress-redlines during load
        
        Change-Id: Ib26a1123b96e299974507e167bcb8ce8b3e3c924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b0aff34ccb12e1af815a059957d7c4f6a14eeaea]

        tdf#161352 - Set ChangeCase* requests as done for macro recorder
        
        Change-Id: Ie66cb5e2f4095d40e081b9441b46dff7bd0a0d26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168698
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-06-12  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [1f3c82e3b0171bac89cbc7d1ec1ca89fac1c7eec]

        Fix Unicode block names
        
        === Unicode block names ===
        * Change "Basic Greek" to "Greek and Coptic".
        * Change "Canadian..." to "Unified Canadian...".
        * Change "C1 Controls and Latin-1 Supplement" to "Latin-1 Supplement"
          because "Latin-1 Supplement" is the more commonly used name.
        
        These modified Unicode block names are based on the descriptions on the following pages:
        https://www.unicode.org/charts/PDF/U0370.pdf
        https://www.unicode.org/charts/PDF/U1400.pdf
        https://www.unicode.org/charts/PDF/U18B0.pdf
        https://www.unicode.org/charts/PDF/U11AB0.pdf
        https://www.unicode.org/charts/
        https://en.wikipedia.org/wiki/Latin-1_Supplement
        
        === Others ===
        * Remove unused RID_SUBSETSTR_GREEK_SYMS_COPTIC.
        * Change RID_SUBSETSTR_BASIC_GREEK to RID_SUBSETSTR_GREEK.
        
        Change-Id: I91573a825a7b34349f29143ea8940da2383b260f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166790
        Tested-by: Jenkins
        Reviewed-by:   <20001722@ymail.ne.jp>

2024-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e75a1eb21834fa872864df2cc5811c6463aceb78]

        more stale hyphenation data after skipping blanks
        
        m_xHyphWord is stale if m_nBreakStart changes
        
        turn maybeAdjustPositionsForBlockAdjust into a member
        to make it easier to discard m_xHyphWord on change
        to m_nBreakStart
        
        Change-Id: I6ca37371bf6b8362ebd16a08594afcff3222fa12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168681
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-12  Yuki Joou  <yukijoou@kemonomimi.gay>  [26e90920acc3c0511ce4028b5810384133808a96]

        tdf#145262 Add missing option to tables' context menu
        
        The right-click popup shown when right-clicking a footnote, index
        entry, or other similar fields was missing the options related to
        those fields. This patch brings them back, in a section near the
        bottom of the list.
        
        Change-Id: I8cb98660d8348791dafc4826e55b4ed292225b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168645
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9e6b4732ca2ad37a7bcfa6e406b3b244accd0508]

        Fix --disable-runtime-optimizations build
        
        ...after 19e9e49bdaeebc314c892c000385ec778edf759b "python3: upgrade to 3.9.19",
        by making external/python3/python-3.3.3-disable-obmalloc.patch.0 apply again
        
        Change-Id: I295e470f3e86740ee276336dd04c227b2b316140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168695
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-12  Laurent Balland  <laurent.balland@mailo.fr>  [c49da95942f456623e91ae1f5c1a68efd83fec6c]

        tdf#161173 Replace HTML template and idxexample
        
        with their XML code
        Change html.stw to html.oth
        idxexample: simplify font list
        
        Change-Id: I6a7cdcce916222a979d0bef78ac19160ca9f744e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168269
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-12  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [b76765b5a02447532bb20768ca834c53a5d48d96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40ce7008376b0dd3cf9e427cf88385386aaafc73
          - fix @@nowidget@@ HID for Go to Page dialog
            
            At 0aef8c7bd50b6f82a196358584fabc91ebd64795, pressing F1 when any
            element of the dialog was focused would lead to a 404.
            
            Change-Id: I7b8596fab723a3b2581b730bb1894a2fcc59881c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166584
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [cd30c141caa8a0d034541d50b5d41fcfd96bb4c3]

        postgresql: fix arm64 build
        
        after e4e2c7ca00151b27c8928f785af1845f918ed721
        "postgresql: Upgrade to 14.12 (master only)"
        
        Change-Id: Ie2b1a08b2bbc1504d5f8bac15b5ffc6708b6b1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168697
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-12  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [2beaa3be3829303e948d401f492dbfd239d60aad]

        remove ability to trust not validated macro signatures in high security
        
        Giving the user the option to determine if they should trust an
        invalid signature in HIGH macro security doesn't make sense.
        CommonName of the signature is the most prominent feature presented
        and the CommonName of a certificate can be easily forged for an
        invalid signature, tricking the user into accepting an invalid
        signature.
        
        in the HIGH macro security setting only show the pop-up to
        enable/disable signed macro if the certificate signature can be
        validated.
        
        Additionally present a ViewSignatures button in the Macro Disabled
        infobar, so that the user can inspect what are the invalid signatures
        and why (wihtout the ability of enabling macros).
        
        Change-Id: Ia766fb701660160ee5dc9f6e077f4012a44ce721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168667
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-06-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a0f45ceb570d47a9edbadd8bfeeda9b3ee4cf8c6]

        Embind: A nicer unoObject construction function
        
        Change-Id: Ied532cf271644f424fbf9661a0b8d246124ca324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168689
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-11  Patrick Luby  <guibmacdev@gmail.com>  [6f4adc1274cfac30b9097411bb193bd4386969f0]

        tdf#160801 fix crash by delaying resetting of attributes
        
        Calling SwWrtShell::ResetAttr() will sometimes delete the
        current SwTextShell instance so call it after clearing the
        direct formatting flag.
        
        Change-Id: I43a66527cee30271447dff30f166086c6759e162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168304
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-06-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8fadd44f5947e1022d3431e3ac781b0924c7652e]

        Fix typo
        
        Change-Id: I8dee411e1f3b4f182791e45b286f24d20f4c98da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168680
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [02b858e78667de122331a056af29d362d1cef56e]

        Fix typo
        
        Change-Id: Ib50cf36b56ff0a77870948e7ce73eb5da84a6f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168679
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed54d14d5c9bf46b48741e37a12664921aed1c2a]

        CppunitTest_dbaccess_macros_test: remove redundant test
        
        This was added in 0f4451c0b3bda3d14c7672ca670b4de959495365
        "first part of a c++ based test for base" as an example on
        how to test base documents.
        At this point we already have other base tests doing
        more interesting stuff so I believe this test is not needed
        anymore
        
        Change-Id: Ice747800f3ab6d887d63595fe9dbdd531acf9014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168684
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [81f73ee5128eaa6328a2b08b0398202d747312ca]

        tdf#161204 Fix selection outline with overlapping ranges
        
        The previous commit [1] caused a regression in the outline when two or more ranges overlapped in the selection. This patch fixes the issue.
        
        [1] dc243f0122ba656d2630e93bebfb84a2bfe4042a
        
        Change-Id: Ib5ec72504ba0efaae715c47628c3d5a47557f506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168618
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2024-06-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0c49aa58cfbb81073e34b1d47861a5a1fdd44114]

        tdf#161508: add another loop control hack
        
        It beats me how to resolve the oscillation cleanly, when in a row
        split mode, lcl_CalcMinRowHeight calculates a small value, but in
        a non-split mode,  it returns a larger value  (which is expected),
        and that resulted in recalc,  getting stuck forever in the nested
        SwTabFrame::MakeAll.
        
        So this puts an oscillation control here. The placement is mostly
        heuristical.  It is hackish also in the sense that it only checks
        the frame size and position,  but ignores the state;  so it might
        turn out that it returns too early,  when a different combination
        of flags was about to be attempted.
        
        The unit test tests two things:
        1. The main aspect of freeze;
        2. The expected correct layout.
        
        If (when) the hack turns out problematic,  and its fix happens to
        break the second part of the test,  that is unfortunate,  but the
        most important thing is to keep it from hanging.
        
        Change-Id: If31d8527b4677b5211dcd3308578118c7066d68c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-11  Bayram Çiçek  <bayram.cicek@collabora.com>  [9bbb02bcd7cf26b3e69e12481ffd041019d76082]

        tdf#161502: change Structure label of Function Wizard dialog
        
        - label "Structure:" changed to "Content:"
        - this change also removes the duplicated "Structure" text from the dialog which makes the UX better
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I6d70e019b80d4ef0d7207b62e1d0aa6d1f0a3b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168161
        Tested-by: Pedro Silva <pedro.silva@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        (cherry picked from commit dc3e624b52e43bb197417b5d9339890afe7c5379)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168612
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [e4e2c7ca00151b27c8928f785af1845f918ed721]

        postgresql: Upgrade to 14.12 (master only)
        
        Postgres 13 will reach the EOL in November 13, 2025
        https://www.postgresql.org/support/versioning/ so upgrade it
        now after the creation of the libreoffice-24-8 branch towards
        LibreOffice 25.2
        
        Downloaded from https://ftp.postgresql.org/pub/source/v14.12/postgresql-14.12.tar.bz2
        
        Change-Id: I1f78f682ef14b486a98912ed23a08163d819837e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168687
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [290c8f6e048fedf63437e3fdf629555ac89dd3ad]

        ITEM: Change SfxItemSet to use unordered_set
        
        With all the changes done for Items we can now do deeper
        basic changes to the ItemSet itself with manageable risk.
        
        I already did https://gerrit.libreoffice.org/c/core/+/166455
        aka 'ITEM: Add measurements for SfxItemSet usages' to
        get some statistical information about the fill/usage grade
        of the ItemSet's fixed PtrArray to SfxPoolItems, check
        that out to get an own picture.
        
        Those results show that an average usage is between some
        extremes ranging from 0% to 50%, but when using more checks
        and using multiple files/interactions/edits in all
        applications we end up with around typical 12%-19% of that
        array used, the rest is nullptr's.
        
        Thus I thought about one of the initial ideas of this
        series of changes (ITEM), to use a std::unordered_map
        (A) instead of that fixed array of SfxPoolItem Ptr's (B).
        Tthat again was for a complete type-based rewrite, which
        I once did a POC, but the code cannot be adapted to that,
        just too much work.
        
        Those are very different in architecture, (B) is done
        since a long time (since ever), but as pointed out above,
        (A) is now possible. There are many aspects to it, let's
        grep some:
        
        Speed (iterate): (A) and (B) are both linear. (A) has
        less entries, but may touch different mem areas
        (buckets). (B) is linear, but many empty spaces which
        are usually uselessly iterated.
        
        Speed (access Item by WhichID): (A) is hashed by
        WhichID, so mostly linear for unordered_set/hash.
        (B) is in a linear array, but has to calculate the
        offset for each WhichID access.
        
        So I guess speed will mostly equal out.
        
        Memory: (A) will be dynamically allocated (buckets),
        but stl is highly optimized and may even re-use areas,
        has to provide some extra info but will need less
        places for Items since it's dynamic and can start empty.
        (B) will be allocated once (except AllItemSet) and may
        even be 'derived' to the ItemSet (SfxItemSetFixed), but
        has to allocate all space at once.
        
        I can go in lots of more detail here, but due to the
        results of the statistics I just made a test now,
        including measuring some results (will include in
        gerrit, not here). I used two pro versions for that.
        That way I have some data now.
        
        Result is:
        - It is now possible to do this, it runs stable :-)
        - Speed: As expected, mostly no change
        - Memory: Depending on usage, 0% to 25% less,
          usually around 8-10%
        
        Side effects:
        - SfxAllItemSet could be done without WhichRanges,
          thus without expensive 'merges'
        - SfxItemSetFixed is not needed. While the idea is
          good, it needs a lot of extra stuff
        - Access to Items is linear if set
        - WhichRanges: Still needed, but for vaildity
          checking/filtering of ItemSet content
        - WhichRanges: Worth to think about if these are
          needed at all, probably just exist for historical
          reasons since allocation/number of added Items
          was never ever dynamic -> just not allocatable
        
        Putting the current version on gerrit, may still
        trigger some UTs (checked SW/SC/SD...)
        
        I did not like that functionality at ItemSet that
        hands out a vector of the set items for cases where
        to avoid iterating and deleting items at the same
        time at an ItemSet, so changed to using a local
        vector of remembered WhichIDs and deleting after
        the iterator is done. I also saw some strange
        usages of SfxItemIter in sw which i will have to
        check.
        
        Since there are still problems with UTs which I can
        not reproduce locally I have now added asserts to
        the case that an ItemSet gets changed with still
        having active SfxItemIter(s). That is always an
        error, but with the architecture of that fixed
        array of ItemPtrs did not have devastating effects
        (purely by coincidence).
        With that asserts, UTs run well in SC and SD, but
        in SW I get 11 (eleven!) asserts from the UTs, all
        of them from 'ITEM: SfxItemSet ClearItem' BTW.
        I guess these have to be fixed before thinking
        about this change...
        
        Good news is that all 11 cases were the same in SW,
        in SwHistorySetAttrSet::SwHistorySetAttrSet which
        does some strange things using two SfxItemIter in
        parallel. Thus SW UTs are also clear and I see no
        more errors caused by ItemSets being changed while
        SfxItemIters are alive.
        Bad news is that I still have errors to hunt...
        
        NOTE: Have now cleaned all UTs, this showed that
        there are some unexpected side-effects of the Items
        being processed in another order when SfxItemIter
        is used, also found one case where a
        WhichRangesContainer is constructed for a
        SfxItemSet using the set items from another ItemSet
        and SfxItemIter to do so. There *might* be more
        cases not covered by UTs.
        
        NOTE: While speed stays the same and mem is reduced
        up to 25% (see measurements in 1st comment) another
        *important* aspect is that this frees the way for
        using ItemSets *without* WhichRanges - these are
        necessary mainly to create that fixed array of
        pointers to the Items in a *manageable* size. With
        a dynamic structure like unordered_set there is
        in principle *no need* anymore to use WhichRanges
        to pre-define the Items a Set could hold. There
        is one exception: We have cases where one ItemSet
        is set at another one with defined WhichRanges to
        *filter* the contained Items - these would have to
        be identified. This is a rare case and we would have
        to check cases where an ItemSet gets set at another
        ItemSet. This would be as if all ItemSets would be
        AllItemSets in principle - much easier for everyone.
        
        NOTE: Waited for 24.8 split just to not take
        unnecessary risks.
        
        Change-Id: I75b0ac1d8a4495a3ee93c1117bdf618702785990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166972
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-06-11  Michael Stahl  <michael.stahl@allotropia.de>  [48659fa6cf8b2c5e3810696cf0c9257ddb57dd4d]

        (related: tdf#161215) sw: layout: fix another floating table loop
        
        The full bugdoc loops; text frame 3160 (on which a floating table is
        anchored) is split, immediately joined, and split again...
        
        SwTextFrame::IsEmptyWithSplitFly() has a wrong condition that compares
        document coordinates with relative position inside the frame; try to use
        the confusing SwRectFnSet to compare instead, which prevents this frame
        from splitting because it actually fits into its upper.
        
        Another problem in that function is that it checks RES_PAGEDESC but not
        RES_BREAK; try to fix that too.
        
        (regression from commit 16b5b21d36da87be9b50235acbbb8008ed23b8bb)
        
        Change-Id: I94251b7443e51303b28d14f0597b0bf782142480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168668
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [373bb35740e0e908acafce743bda3e186f1e36c5]

        CppunitTest_sw_odfimport: add assert
        
        Change-Id: I8a9ccb490fdd717538e368f73fefca425f94b405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168673
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [1bcd3df23c146184d8adc83119469df92175f60f]

        dbaccess: use createTempCopy instead of doing it in make
        
        Change-Id: Ib1e550dbe5ea74827562e3706c4a310171df77af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168675
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dc01a6e7efd3e4c41287dc10c7ea1fdfa1ab5cb5]

        Some missing "block untrusted referer links" for form controls
        
        ...where "Referer" is now passed in as an additional property, so that the
        relevant objects can decide whether to obtain graphics while loading a document
        
        Change-Id: Ie3dabc574861713212b906a0d7793f438a7d50a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168674
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [46c261603fc60ad30e80cbf6903b573ac98a66ee]

        annot: document new annotation classes and methods
        
        Change-Id: I71d1055a30e0e8eedcd8fa71b47e74e90f1aac93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168595
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f55cfda525af718070f6a39de01de738ef660cb3]

        annot: don't render objects marked as annotation in PDF export
        
        Objects that are marked as annotation shouldn't be rendered to the
        PDF document. Those should be written to the PDF as annotations
        (if output of annotations is enabled in the PDF export options).
        
        Change-Id: I60650b5a64dc52da6d32d8ac92441e4b21900126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168574
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2efd36571f4ec9745354bdda31328673716e48f9]

        annot: add custom selection overlay for the annotation object
        
        Make annotation objects selection similar like it was with the
        old annotationg tags.
        
        Change-Id: I0623ddf56274dc996ed9dd16096256e03ad65270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168523
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac2db9b4726e92153a7be2ed0fd2987a7922caf0]

        tdf#160877: call lcl_getRDF since graph-names can change
        
        partially revert 3750d0533e0e00941e5aef92fe5a26b6e7e27734
        "sw: paragraph-sign: get graph-names only once"
        
        Change-Id: I7f99679f4a361acdd841037b782421a53350dbbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168477
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5a3f8809fe489d4e9bf21f1d68ae3be5ad71349e]

        annot: change include to forward declaration
        
        Change-Id: Ibf35554b707254fa5f901e3137adb28ba46a98ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168515
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7235eec702299190754af3a81186ac0aa82d5be3]

        annot: make annotation pop-up window working again
        
        The code to open AnnotatationWindow was removed in the previous
        change as it needed to be changed to make it work with annotation
        (sdr) object.
        
        Change-Id: Ic75e4fca6b46359f29762bc4735a76204aeb90f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168514
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2dc9d587cb38145141a4821006a09606e6625c35]

        annot: update annotation position, size, text when those change
        
        Change-Id: I345f4c714ed4ca0c8277e0aedf5ea4b5cd70ea70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168513
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c89131d1c6dc4fe19f214ec800412c173c2420f0]

        annot: Add tests for annotations - insert, delete, undo/redo
        
        Change-Id: Ie9d88c15af13fb481bb48c838b3b0ef2f41f11e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168512
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e17c56bfc7930d3c14c3ff4cfd59828e8dcc0229]

        annot: new Annotation sdr object, replacing annotation tags
        
        Previously the annotations are shown as annotation (smart) tags,
        which just mark in the document the existence of an annotation at
        a certain position. For PDF support the annotations can be more
        complex, so they can show many forms of vector graphic, ink,
        bitmaps, text boxes,... and for this a normal tag is not enough.
        
        This change moves the annotations from simple tag to use the sdr
        objects, so any SdrObject can be created as an annotation. The
        previous tag annotations are using SdrObject (actually SdrRect)
        subclass AnnotationObject and the code that previouslly worked
        with the tag annotations has been adapted.
        
        The (PDFium based) PDF import has been changed to use subclasses
        of the SdrObjects for the PDF annotations.
        
        Change-Id: I4746b85b5b679499e470987e61ed356397e56bf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168485
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4c179c1e62778274e7604b3317300f6df809cd80]

        bump product version to 25.2.0.0.alpha0+
        
        Change-Id: I56a7aa68ad934dc7fb7f1fc1e3f95bdb78ca120f

2024-06-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [798b43c4ef433d9f2cbfa431ebdf9ec35c3b8a39]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0d53fb56250d16d87e001ef05b52d289dff5b1df
          - update translations for master / 24.8.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I92f8e74d5cf8127e8f85e83c600472b6b84c97ed
            
2024-06-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5c9040c16506d5ef2708416ea280d97b707092b4]

        tdf#161496 - Fix single ocPush tokens in LET function Name values
        
        If the Name - Name Value pairs contains already an ocPush result
        no need to interpret, so the Calculation parameter can reuse it.
        
        Change-Id: I55465d674eb31aea7c3123c889250c9fa127f1fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168661
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-11  Miklos Vajna  <vmiklos@collabora.com>  [013300c751d7a9ede12c1bf1c784254d1c6c5433]

        tdf#161443 DOCX import, table style: handle para border in table cell paras
        
        Open the bugdoc, the in-table paragraphs have some top and bottom
        paragraph borders in Word, not in Writer -- because the cell and
        paragraph UNO object both have a property named TopBorder as mentioned
        in commit 39c54c0ef837e0e23a676a4d1fa5da667e18939c (tdf#161443 DOCX
        import, table style: fix para border leaking into cell border,
        2024-06-07).
        
        The previous fix avoided the problem that the unwanted border affects,
        the cell, but re-routing the property to affect the in-table paragraph
        were not done.
        
        Fix the problem by adding 3 new meta-properties with a "Para" prefix for
        all 4 border locations (top/left/bottom/right), this way the paragraph
        borders defined in a table style can affect the in-table paragraphs, but
        not the table cells.
        
        Apart from the border itself, this also affected the border spacing,
        which means that the position of all text inside and below the table is
        now also correct. Unfortunately this also means we need to move away
        from the constexpr frozen container that is only suitable for a limited
        number of items:
        sw/source/writerfilter/dmapper/PropertyIds.cxx:394:6: error: ‘constexpr’ evaluation operation count exceeds limit of 33554432 (use ‘-fconstexpr-ops-limit=’ to increase the limit)
        Returning to std::unordered_map is good enough for our needs.
        
        Change-Id: I478f274800a1d0b200f10226438ab4cfd4957b74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168659
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [19e9e49bdaeebc314c892c000385ec778edf759b]

        python3: upgrade to 3.9.19
        
        Downloaded from https://www.python.org/ftp/python/3.9.19/Python-3.9.19.tar.xz
        
        * python-3.8-msvc-sdk.patch.1 is no longer needed
        
        * Comment out deprecated warnings for now:
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/pyuno/source/module/pyuno_util.cxx(42): error C2220: the following warning is treated as an error
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/pyuno/source/module/pyuno_util.cxx(42): warning C4996: 'PyUnicode_FromUnicode': deprecated in 3.3
        C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/pyuno/source/module/pyuno_util.cxx(64): warning C4996: 'PyUnicode_AsUnicode': deprecated in 3.3
        
        Change-Id: Iaa358ffaaea63cf6ec47914759d0469e70e1cc65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168551
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [3f686bfe0e83de59b9f641b08e880c5319f9d8e1]

        nss: upgrade to 3.101
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_101_RTM/src/nss-3.101-with-nspr-4.35.tar.gz
        
        Change-Id: I8314faf1af069a5dc438f0d53f327ae2193ca59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168663
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-11  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [efb805eb244ad9f0317083502412b5d38d7f048d]

        tdf#159897 docx import: fix broken hyperlink
        
        If the ScreenTip contains quotation marks, the link will be incorrect
        
        Change-Id: I10f5039144c71bf5105cbd4dd9e82076a4d92fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168648
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-11  Regina Henschel  <rb.henschel@t-online.de>  [567dbcf68711402736f65f4a0a47ef57549fe50f]

        tdf#161327 Interpret angle units in dr3d:end-angle ..
        
        .. and draw:rotation in <draw:hatch> element.
        
        ODF 1.1 has not specified the syntax of datatype 'angle'. Since ODF 1.2
        it is specified as double with unit "deg", "grad" or "rad", or without
        unit. The unit-less value is specified to be in degrees. But OOo, AOO
        and all LO versions had written the value unit-less in 1/10th of a
        degree in some cases.
        
        To fix it, LibreOffic will be enabled to read units. When then the
        active versions are able to read units, starting with the then actual
        version, LibreOffice will write angles with unit 'deg'.
        
        This has already be done for gradients, see tdf#89475. This patch
        starts the first step to make LibreOffice able to read units for
        dr3d:end-angle (UNO D3DEndAngle) and for draw:rotation (UNO
        FillHatch.Angle). I have not found further cases of writing 1/10deg.
        
        The patch still writes unit-less 1/10th of a degree for export to
        ODF 1.3 and earlier. When it is time to write unit degree or when
        LibreOffice supports the next ODF versions, some places need to be
        adapted. They are marked.
        
        The converter convertAngle is renamed to convert10thDegAngle() to
        indicate, that it is special. The parts, which were specific to
        gradients are moved to the gradients, so that it is now usable for
        dr3d:angle and draw:rotation too.
        
        I intend to write next a patch that enables LibreOffice to read angle
        units for cases where LibreOffice already writes unit-less values in
        degree. That is not so urgent, but to bring LibreOffice nearer to ODF,
        reading angle units should be implemented nevertheless.
        
        The file xmlbahdl.hxx is moved from xmloff/source/style to xmloff/inc
        to have access to it from xmloff/source/draw.
        
        Change-Id: I8ffc2735f8bcfefb86efa80eb05f900c32403f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168336
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-06-11  Jaume Pujantell  <jaume.pujantell@collabora.com>  [a2b6ce5d21b7f5c84ced8485f5af279f1bf8135f]

        lok: sw: do not add a table style on insert dialog
        
        This brings the default beahivour of the insert table dialog closer
        to the behaviour of the uno command, where a table is inserted
        without a table style and with visible borders.
        
        Change-Id: Ifcadbce78c0623aec91fd9320bf90a87efc16448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168183
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit a17e087e26774c4e33d371322fbef426cd387639)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168610
        Tested-by: Jenkins

2024-06-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2f2a43f0410e159508a88b3de39b44085eec5eb2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1522a9b569d146c27d7fcaf06fc5a4cb18256088
          - Fix syntax error
            
            ...introduced in 1658fb55defb5a08d3adbd7637745f8a62c58f89 "Update
            Basic/Python TOC with Calc samples"
            
            Change-Id: I5be787dfc60bef363757143171484020de7f1288
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168657
            Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
            Tested-by: Jenkins
            
2024-06-11  Andras Timar  <andras.timar@collabora.com>  [719958306782ef7e79c2f0e07f621ba9a050a623]

        LOK: do not use deprecated .uno:BackColor
        
        .uno:BackColor was deprecated in
        be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928 
        which changed the label to 
        "Character Highlighting Color (deprecated - use CharBackColor)"
        We do not want this label to appear in LOK based product.
        The corresponding online patch set:
        https://github.com/CollaboraOnline/online/pull/9225
        
        Change-Id: Ieb780d278cd45bf82a2b4acee0abd17af2dc71eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168519
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit db27cd2246cfc54abd94885ce5edbdca69688af0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168616
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-06-11  Michael Weghorn  <m.weghorn@posteo.de>  [7d334ba7467d03e2d890e2926244f783d403878f]

        tdf#158914 sc a11y: Remember new cell text again
        
            commit 5f9a955042822d05af5c04b2c852738c7e1e21a2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jun 7 13:03:19 2024 +0200
        
                tdf#158914 sc a11y: Send TEXT_CHANGED event when text changes
        
        had made sending a `AccessibleEventId::VALUE_CHANGED` event
        conditional on the cell having a *numerical* value.
        
        Assigning the new string to `m_strCurCellValue`
        should always happen independent of this, though,
        as this is the string value, not the numerical
        value.
        
        Thanks to Patrick Luby for noting the difference
        in [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/167961/comment/1af95eb6_7db33e0b/
        
        Change-Id: I1d1da2caeb7f2199251599313ec4412d7b6e47b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168635
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-11  Justin Luth  <justin.luth@collabora.com>  [852cd511258e97a0df3b6fbe9fc0ae670c3fc843]

        tdf#57414 tdf#160769 autorecovery: keep open docs in RecoveryList
        
        This reverts parts of the LO 24.2 patches commited for bug 57414.
        
        There were lots more vocal people than I expected
        that want the crash-recovery to restore their session state.
        
        Since there is no working alternative to trigger a session save,
        just revert the bits that made the RecoveryList clean
        (as I and other users had requested)
        and revert back to the original, historic behaviour.
        
        This means that now the following files will again be recovered:
        - saved documents (opened from file URL)
        - read-only documents (opened from file URL)
        - files that were opened, but never modified (opened from file URL)
        - files from now-potentially-unavailable disks/servers/temp-dirs
           - recovery will attempt to access those file URLs
        
        At least one benefit remains:
        - new, unmodified documents will not be in the RecoveryList
        
        Maybe I'll look into a session save option for 25.2.
        
        Change-Id: I2477f194bf94f14620d284728027846ec5b6119e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168650
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2254c416261c8001f002067c306c13b32adab5fa]

        Fix typo
        
        Change-Id: I65fa0676119a2e52e23acddc564143cd1e519df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168647
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-11  Justin Luth  <jluth@mail.com>  [468b17bd06e56b406f5651d7f0e9c7bef54090e0]

        NFC docxattributeoutput loop: skip if empty, exit early if duplicate
        
        No need to loop through all of the textboxes
        if the rName.isEmpty() since that is never accepted as a duplicate.
        As soon as a valid duplicate is found,
        we can quit search the rest.
        
        Change-Id: I785c2cf4cc619fc45fc2b95f492fe1b5ff0f1a55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168582
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-06-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [db153afbac7acc1ae46f78beef4221e9aad07305]

        tdf#161457 - Fix autofilter result is wrong when cells contain
        
        formatted rounded values.
        
        Filtered formatted values were not sorted with the rounded values
        but with the original values and the duplicated values caused wrong
        filter results.
        
        Regression from commit: 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1
        (tdf#117276 sc: Show hidden filter elements as inactive elements)
        
        Change-Id: I7540ba5fa98e6bbe0b014448bf2449432261d542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168592
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-10  László Németh  <nemeth@numbertext.org>  [b285cf49dffe8a74f0ba54b88b781db6a68a4f3b]

        tdf#157833 tdf#155692 sw: fix hit area to resize row/col
        
        Fix 1) missing or too narrow hit area (tdf#157833),
        and 2) not recognized click inside hit area (tdf#155692).
        
        It was impossible or very hard to resize text table
        columns and rows using the mouse:
        
        1) Double arrow, i.e. "resize row/col" mouse pointer shows
        the hit area of text table row/column borders. This was
        missing or was very narrow with normal zoom, because of an
        obsolete constant for low resolution displays.
        Change this constant used in IsSame() with scale-dependent
        values to support the same hit area on different zoom levels
        and with different screen resolutions.
        
        2) Especially on bigger zoom, "resize row/col" mouse pointer,
        i. e. the visible hit area didn't guarantee drag & drop any
        more because of too small hit area in pixels in the svruler
        code base: clicking on not exactly center of the hit area
        resulted selection of cells or the cell content instead of
        drag & drop the border, violating WYSIWYG. Enlarge the default
        1 pixel to 5 pixels to cover the whole hit area. Note:
        only for resizing table borders inside the document, not on
        the horizontal and vertical rulers.
        
        Change-Id: I398a0de782040b0ad18835658ed625117a6e0e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168605
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4cd4be3e7cc77953813a6f1713b6b8245ca92214]

        poppler: Upgrade to 24.06.0
        
        Downloaded from https://poppler.freedesktop.org/poppler-24.06.0.tar.xz
        
        Change-Id: I6b679ae014edd7a9897eed39a6e91c63251cc016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168642
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [dc243f0122ba656d2630e93bebfb84a2bfe4042a]

        tdf#161204 Improve visibility of outline in the selection overlay
        
        As discussed in the design meeting, this patch adds an internal white outline to the selection overlay to provide better contrast.
        
        FTR: This is the same approach used by other office suites (Excel, OnlyOffice, etc).
        
        Change-Id: I9b279ebfa9efbd2b5d9894b94ebda653c3dba6e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168538
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-06-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [34f2a655f3dd2e6338cc577a0b9d6e1c146607ed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1658fb55defb5a08d3adbd7637745f8a62c58f89
          - Update Basic/Python TOC with Calc samples
            
            Change-Id: I1ce9b023b0e90dae868cc323af3e9d0296a66bdc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168534
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fe53e6b2e951f2f8f834386827bf96610d6acb6]

        tdf#144208 speedup doc with lots of redline(4)
        
        exit early in DelBookmarks if the redlines are not in the range we need
        to fix
        
        Change-Id: I4e558835ec2a5bd6a92b2da29a94db16e52064ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168640
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2b6caa40d682e04e47a03d426e1359cdd74efbdc]

        tdf#160321 - Added missing VB test
        
        Change-Id: I4019599aa9d7803a63e4270b06841915ea428392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168637
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ed5bac73c8e09c606b271f385431c5a57b84bbb5]

        Related: tdf#161430 add test case to guard against its return
        
        Change-Id: Ia2b12ab696632a4f08fd4c20472646dcfd9058c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168634
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-10  Jonathan Clark  <jonathan@libreoffice.org>  [976b16b1c6ad6e6eaded7a9fb24388c4512e21e2]

        tdf#152024 Diacritics cut off at top and bottom of paragraph
        
        This change fixes issues causing Writer to clip paragraphs at the ascent
        of the top line, and descent of the last line, of a paragraph. This
        issue caused certain diacritics to render incompletely, or not at all.
        
        Change-Id: I99a3a25335f8b1d798fc8a55ff42d5c78749fca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168557
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b68dadb846dac063421ed975abecafbd120cbac]

        drop unused suppressions
        
        Change-Id: Ibaf8856839e134432297b96e1d68f5ecd484335c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [edf7f296f11d6572c05aec58e6e576bc0811a202]

        fix Gtk-WARNING **: Could not load image 'res/unlocked.png'
        
        use icon-name instead of pixbuf
        
        Change-Id: Ibb0a09047ada6ac3301ca0a40dbeb25351c41ed1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168609
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d52d82140e14d75487243c8d57dbb88e6a968c59]

        fix GLib-GObject-CRITICAL **: invalid cast from 'GtkImage' to 'GtkLabel'
        
        Change-Id: I29024237cc2d92d16433cf432f87e2b42107a487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa6993e35c38c8be81da326ef41afc980ccc3ef3]

        add test for hyphenation related crash
        
        of:
        
        commit f050103c3324d878b310f37429ea3580a8230905
        Date:   Fri Jun 7 20:14:15 2024 +0100
        
            stale hyphenation data after skipping blanks
        
        Change-Id: I9743d67b49db054968e9f13c5fc6a13136953733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168606
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-10  Weblate  <noreply@documentfoundation.org>  [29525b020c3599e2786e04fec1aef0094a36874d]

        android-viewer translated using Weblate
        
        Japanese currently translated at 82.7% (96 of 116 strings)
        
        Change-Id: I823d969cd027cbdd3778c5ca6887722831d01fbf
        
        android-viewer translated using Weblate
        
        Hebrew currently translated at 99.1% (115 of 116 strings)
        
        Change-Id: I610c1282074f709b2b08baf6303cd70e2eef19c1
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168567
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [84e8758d429d5cfaa049cd0bf7777a437f539029]

        tdf#160321 - Don't execute jump statement if the expression is out of range
        
        Don't execute On expression GoSub Statement; On expression GoTo
        Statement if the expression lies out of range.
        
        Change-Id: I5c1de25918b5e812d7ec82034f8d56351374d56a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165960
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [18ef391582e1f8db5838dfc1aaff36f78ce51447]

        loplugin:ostr in sw/../uibase
        
        Change-Id: I4f4284b55d481caa006743688e6d83cc3c713b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d25de4a04671c2f380fc86a58259b073c49dfe19]

        silence unknown property 'HyphNoLastWord'... etc warnings
        
        warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphNoLastWord'
        warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeepType'
        warn: linguistic:3688232:3688232:linguistic/source/lngprophelp.cxx:636: unknown property 'HyphKeep'
        Change-Id: I4f99961e17bd4e0f90925b8530e25729d964d42e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168600
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c41e714497fdb13cdcbc4d6ba31887d4aaa4b61]

        loplugin:ostr in sw/qa/extras
        
        Change-Id: Ia11b13ec7ed2402e717a4e64e7c7e4aa0b41d70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-10  Julien Nabet  <serval2412@yahoo.fr>  [71e905b62b02f28e6eca728f763a845509bf5a1a]

        Related tdf#134193: declare right-to-left in Math.xcs
        
        Change-Id: I4341f8dd84a17b4f8dd9da2e4f031ed38590d881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168568
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-10  Miklos Vajna  <vmiklos@collabora.com>  [fd7418c1f75e855a19078c6288a024b1b465f614]

        svx: prefix members of SdrGrafObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Icc587c31582fb5fdfbdfe375005b96ea219bf4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168597
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-10  Mike Kaganski  <mike.kaganski@collabora.com>  [bf02c5fa586d2ff7dbfac37d3ea0a07675efc15e]

        tdf#161488: allow failed image loading in repair mode
        
        Change-Id: I19a68f2f016b5ab95565c7fbcc4c435cf13c6b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168596
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-10  Jim Raykowski  <raykowj@gmail.com>  [99ed68ac1fbaf883ddc730936299bba95d9e1d6f]

        tdf#160538 Quickfind sidebar list finds in frames and footnotes and
        
        endnotes in the order of occurance in the document
        
        Change-Id: Ifd91065ed416495084ba7f396f740daef5233c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168566
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-06-10  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [30380c2f9888685ddceaafc9fb3a637e7167a3ac]

        tdf#99528 Use vertical tabs in para dialog
        
        Change-Id: I7ec61c07f75e9a8aa124ac5b3d67c90077cca033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166625
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5a75414d1772d1fd998f405e3b9bd80b1f10c51f]

        tdf#161454 - Fix new array functions handle empty matrix cells
        
        Newly added calc array functions didn't handle empty matrix cells
        as empty cells but they were handled as empty strings.
        
        Change-Id: Ie24a38dd8c3f947cfe10ba05b234807891453824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168591
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e52b555a1d9fb40aa923adcd73f3021c3380db84]

        Related: tdf#137543 - fix LET function jump count number
        
        Clean-up and fix wrong jump count.
        
        Change-Id: Ie64ff95f63c17d2726b3a522af981bcaea2a9a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168590
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-09  Julien Nabet  <serval2412@yahoo.fr>  [2ee02727497475f7abf50f734daaebf4e7a64727]

        tdf#161467: fix assertion in Impress when inserting table (gtk4)
        
        Change-Id: Ib3b21c46e7c19be27a64b52badc618480f0a86c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168593
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6cd7d9322e24ffed4dbaa4cd9b09c3c8e65d9128]

        ofz#69444 Integer-overflow
        
        Change-Id: I24d93f4c61256cd0750ab01cf5a8f313e875d35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168580
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2eab48f697a1e6097778158f623f11306ac7a3d]

        cid#1603563 Unchecked return value
        
        Change-Id: Ie41d77d8809b28e44b2fa084f2f9e6cdfb6e167f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168579
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f050103c3324d878b310f37429ea3580a8230905]

        stale hyphenation data after skipping blanks
        
        what I see is that after skipping the blanks that the m_xHyphWord
        remains describing the word at the original m_nBreakStart, but we have
        changed that m_nBreakStart and in the example I have the m_nBreakStart
        is at the next word, so the contents of m_xHyphWord bear no relationship
        to the current break position.
        
        Change-Id: I07c91495f0cd7ef6d78c0f0d5cef70070ebb6ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168561
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-08  Eike Rathke  <erack@redhat.com>  [c988d9e5cbb7bc6795d9555e86acb3543e66b863]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95755ff59d2fc074796f341d2dc781660c52ce74
          - Tip link to INDIRECT wiki page
            
            Change-Id: I53d0bb0932617785ff64adc84c890d0be115125f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168578
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2024-06-08  Justin Luth  <jluth@mail.com>  [f714fb262ad8561afcababf4b7a97dedb1b72c15]

        tdf#100037 vml import: set fly-anchored AS_CHARs above fly's zOrder
        
        Normally an AS_CHAR is the lowest in the heaven-layer zOrder,
        but if it is inside a fly, it should be just above the fly's zOrder.
        
        In order to get at the parent's properties,
        I had to remove the stack abstraction
        so I changed the stack to a vector.
        That seemed a lot saner than popping and re-pushing.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder2
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder3
        
        Change-Id: Idc159e8203b3f304133a9b110c135e4d0f001dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168565
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-07  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [8ecdff7ac3e867b3e0e43a0df24695785abc5962]

        Modernize wasm debug symbol generation
        
        Rolling a few suggested split debug changes from
        https://developer.chrome.com/blog/faster-wasm-debugging/ into our code.
        
        Added emdwp after linker line, to collect .dwo DWARF info into one
        single file (otherwise Chrome lacks local variable support)
        
        Still not working:
        * -gdwarf-5 does not work yet with neither -O1 nor -Og
        * -Og results in massive binary sizes, -O1 still required to not blow
          up browser mem right after load
        
        Change-Id: Ibf9ea42882df88d947f9bb3881430f0745c0df54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168562
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-06-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [57c228803e55ed343c6693de7d0857ad7d3cd9e3]

        tdf#43157 Use SAL_WARN_IF instead of OSL_PRECOND
        
        Change-Id: I9876ac2bb83f8dc96c41c20dfd2bf779ffe105fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167997
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b71e059c1b3d32110152feeb0c85d51e2775ec7]

        crash on exit with std::optional created from u"FOO"_ustr
        
         #0  0x00007ffff7edaa90 in rtl::str::release<_rtl_uString> (pThis=0x7fffd8fa7c00) at sal/rtl/strtmpl.hxx:745
         #1  0x00007ffff7eeb385 in rtl_uString_release (pThis=0x7fffd8fa7c00) at sal/rtl/ustring.cxx:1151
         #2  0x00007fffed56d058 in rtl::OUString::~OUString (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>) at include/rtl/ustring.hxx:546
         #3  0x00007fffed6084e9 in std::_Optional_payload_base<rtl::OUString>::_M_destroy (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:287
         #4  0x00007fffed608497 in std::_Optional_payload_base<rtl::OUString>::_M_reset (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:318
         #5  0x00007fffed608459 in std::_Optional_payload<rtl::OUString, false, false, false>::~_Optional_payload (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:441
         #6  0x00007fffed608435 in std::_Optional_base<rtl::OUString, false, false>::~_Optional_base (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:512
         #7  0x00007fffed607885 in std::optional<rtl::OUString>::~optional (this=0x7fffef433c28 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+560>)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/optional:707
         #8  0x00007fffee14d910 in ImplSVAppData::~ImplSVAppData (this=0x7fffef433b20 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+296>)
             at vcl/source/app/svdata.cxx:526
         #9  0x00007fffee14d480 in ImplSVData::~ImplSVData (this=0x7fffef4339f8 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance>) at vcl/source/app/svdata.cxx:518
         #10 0x00007ffff785ea2d in __cxa_finalize () at /lib64/libc.so.6
         #11 0x00007fffed55d287 in __do_global_dtors_aux () at instdir/program/libvcllo.so
         #12 0x00007fffffffd0f0 in ??? ()
         #13 0x00007ffff7fca0f2 in _dl_call_fini (closure_map=0x7ffff7657580) at dl-call_fini.c:43
        
        presumably since:
        
        commit 40dde4385cd913ac08292ad3be28bf17de9d296c
        Date:   Fri May 10 13:19:35 2024 +0200
        
            loplugin:ostr in vcl
        
        Change-Id: Ie7562a933291522a2c458bdca70ca9b0a5f4048c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168560
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-07  Michael Stahl  <michael.stahl@allotropia.de>  [724c17602fac7476f068e6b66f30e9ef3c9f0940]

        tdf#161215 sw: layout: don't move into section frame on same page
        
        The problem is that in SwFrame::GetNextFlyLeaf() pLayLeaf is in the body
        on the same page as pFlyAnchor, so the MoveSubTree() effectively removes
        the pNext chain from the layout into a circular structure whose upper is
        an indirect lower, causing an infinite loop later.
        
        Change-Id: I08f96cf483205d6213d7cec7b239f750fff5d3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168529
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-07  Michael Stahl  <michael.stahl@allotropia.de>  [e607bf096d4fb182388ccaefb1179cdd924af02a]

        tdf#161217 sw: layout: don't move into to-be-deleted section frame
        
        The problem is that in SwFrame::GetNextFlyLeaf() pLayLeaf is found
        inside a SwSectionFrame that has no m_pSection because it has been
        scheduled for deletion via SwRootFrame::InsertEmptySct().
        
        Skip such frames, now it goes into infinite loop later...
        
        Change-Id: I93e5febba19213c1503fd699c8e4517067c6ec6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168528
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [50ca981f5597969adad4cb80b4d24aee0f05077d]

        Make Embind-related code also available under --disable-dbgutil
        
        ...and just keep embindtest.js --enable-dbgutil--only.  For convenience when
        using EMSCRIPTEN_EXTRA_SOFFICE_POST_JS recently introduced in
        82640810efd1636e358c047a1a5b3e4e3fc9d28a "New EMSCRIPTEN_EXTRA_SOFFICE_POST_JS
        configure variable".
        
        Change-Id: I03311d89ff14a70f84e03e99ab8e609641ea589b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168552
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d599b5a9702863be8c5927ab657d4a3805570e7]

        prep AutoFill menu in kit mode only
        
        Change-Id: Id533d78e1433b616ce661e855dad0d571d24cf8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-07  Bayram Çiçek  <bayram.cicek@collabora.com>  [e2128b2ea88460bd33ec9b70974366699ef5ccae]

        add AutoFill menu items - LOK_CALLBACK_CONTEXT_MENU
        
        - added AutoFill menu items "Copy cells" and "Fill series"
        - send information with LOK_CALLBACK_CONTEXT_MENU
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I3118f5535f74cfa4ab049e643930df83512b6850
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168086
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit a3f4d31783721f61b8436c5f8032321b4c97de1a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168531
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [571c082c2e753eb387326f482f64201f7c21a780]

        Revert "framework/qa/complex/dispatches/checkdispatchapi.java to CppUnit"
        
        This reverts commit 227f5c77278c96f7f1b126aade457422949a095c.
        
        Reason for revert: I clicked the push button to fast. it needs more checking
        
        Change-Id: I092691c6ebcf7921d26df58ba4c0a38cfdd418b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168532
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [7023e0e8e50acc0a04f202352d948ab7606217b3]

        CppunitTest_framework_CheckXTitle: simplify code a bit
        
        Change-Id: I1e3fe2d081daf6c7b4097c266695f69c2f377b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168521
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-07  Michael Weghorn  <m.weghorn@posteo.de>  [5f9a955042822d05af5c04b2c852738c7e1e21a2]

        tdf#158914 sc a11y: Send TEXT_CHANGED event when text changes
        
        Don't always send an `AccessibleEventId::VALUE_CHANGED` event
        when the string value of a Calc cell changes, but send a
        `AccessibleEventId::TEXT_CHANGED` event instead.
        
        Only send an `AccessibleEventId::VALUE_CHANGED` event in
        addition if the cell actually has value data, as the
        `XAccessibleValue` interface and the related `VALUE_CHANGED`
        event are meant to handle numerical values only.
        
        Together with changes like the one in PS 11 of [1],
        sending the `TEXT_CHANGE` event might help with
        missing text updates on the AT side, e.g. the NVDA or
        Accerciser scenarios described in [2], s. further
        discussion there.
        
        [1] https://gerrit.libreoffice.org/c/core/+/167961
        [2] https://gerrit.libreoffice.org/c/core/+/167961/comments/16394c5a_338dbbf2
        
        Change-Id: Ideba61a9200100c66d55fa18e81ea28e75092905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168526
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-07  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [805fd61f8efaaac119bbe28ab51617c07f0d7058]

        tdf#160591 PPTX export: fix colormap mapping in slide master
        
        Change-Id: I154f0ff1769fbda361ec62f1dd589ca0d7686bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168506
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [82640810efd1636e358c047a1a5b3e4e3fc9d28a]

        New EMSCRIPTEN_EXTRA_SOFFICE_POST_JS configure variable
        
        ...which can be useful during development, to add e.g. additional test code to
        the generated qt_soffice.html
        
        Change-Id: Ic498dcd4c812b7b4c8e48b07c2bff411a9f19438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168522
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bff196c0d34f540f459ced613ac379a730f46149]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4167f524c4718c3960cae2e4f390d04ffdb20839
          - tdf161442 Help page for Calc LET function
            
            Change-Id: I81a5304786f626eaf7b556bb5faf6fa90f2eab34
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168508
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-07  Justin Luth  <jluth@mail.com>  [6c2ab0f3ca440f6e10b438e6ee0e235cbe155216]

        tdf#100037 vml import: add AS_CHAR images to zOrder calculation
        
        Inline shapes are at the level of body text,
        so any heaven-layer floating objects should be above it,
        and any hell-layer flys should be below it.
        
        DML images already do this in applyZOrder().
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder
        
        Change-Id: I51ab2eb4c1b59ebf048f16dca60a02b327c5e6b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168511
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-07  Justin Luth  <jluth@mail.com>  [69dd3061882971d18bb07e829c20241916f26fc5]

        NFC related tdf#100037: unify duplicate PropertySets, etc
        
        This is supposed to be a No Functional Change commit,
        as cleanup prior to fixing the untracked zOrder of
        as-character VML shapes.
        
        There shouldn't be any reason why both xProps
        and xShapePropertySet need to be defined separately.
        Initial duplicate xShapePropertySet was introduced by vmiklos
        in 2013's commit 8738ded7bb1bb6262fe1038e310b5110407f4cfa.
        
        Plus, all clauses of the if statement will need
        the GraphicZOrderHelper, so lets just pull that out
        ahead of everything.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf100037_inlineZOrder
        
        Change-Id: I6bbd9ab8b3062258f010ac9fb7eda7035722cfbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168510
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d155febef6a3d9b469f78ed4c5e70730032e3d38]

        Embind: Add some type-inquiry functions to uno_Type and uno_Any
        
        ...that proved useful in experiments wrapping a JS Proxy around the Embind
        representation of C++ UNO objects.
        
        Change-Id: Ia4018ec8dee2c222fb76ba8e2f529f4845f0134c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168518
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ea2ecd04dd70e228f0ffdc6830b69c837eab8d67]

        replace fpicker-related Help::GetHelpText with core-side translations
        
        Change-Id: I109554a3282c4c919cfbf859918cf0f9d75cc967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168509
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-07  Adam Seskunas  <adamseskunas@gmail.com>  [227f5c77278c96f7f1b126aade457422949a095c]

        framework/qa/complex/dispatches/checkdispatchapi.java to CppUnit
        
        Ports the checkDispatchOfXXX tests including the three database
        dependent tests. The other tests in the file will be ported in
        another commit, to be merged with this one.
        
        Change-Id: I6bcbcbf91ad4d9cc52c817f4efef9779a17f2198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168482
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-07  Miklos Vajna  <vmiklos@collabora.com>  [39c54c0ef837e0e23a676a4d1fa5da667e18939c]

        tdf#161443 DOCX import, table style: fix para border leaking into cell border
        
        Open the document with a single table, notice that start of the text in
        A1 cell is missing.
        
        Seems what happens is that the cell has some positive border distance,
        then the para has the same negative left margin, so in total there is 0
        left margin for the text, which makes this readable in Word. On our
        side, we map the paragraph border from the table style to the
        LeftBorderDistance property, then throw this on the cell object, which
        gives us 0 border distance, so the negative para left margin results in
        an unwanted shift of text towards the left: the start of the text is
        hidden by clipping to make sure the painted text is inside the cell
        frame. (Both paragraphs and cells have a LeftBorderDistance property, by
        accident.)
        
        Given that a visible paragraph border from table style is not actually
        imported, first just do the minimal fix and make sure we don't import
        paragraph borders from table style at all: this solves the problem of
        unwanted 0 cell border distances and the full text is now readable.
        
        In case the paragraph border in the table style would be actually
        visible, that would be useful to route to the paragraphs in the cell,
        that's not yet done here.
        
        Change-Id: I79907a2487c48659effcc55253b9d9881550284d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168516
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-07  Alain Romedenne  <alain.romedenne@libreoffice.org>  [eb8898579f828ea7f73c09614fca1fcfb1c427f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 842cf7acf0f77bbffdb61b42fc5b935773094dcb
          - Precision about Win environment variable
            
            Change-Id: I2105960d58fa0342dde9d7f762ecc1a18b3e9bb5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168448
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-06-06  Dione Maddern  <dionemaddern@gmail.com>  [6d39b1a6068bbbd5ca4947f668f989dbfb73342d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef98081ca946d506c0bc0198f508358ef6e3a9aa
          - tdf#106335 Add info for Impress tables to Clone Formatting Guide
            
            In source/text/shared/01/03020000.xhp
            - Added variable tags to make the page easier to link from other pages
            
            In source/text/shared/02/paintbrush.xhp
            - Added variable tags to H1 to make page easier to link from other pages.
            - Hid the "From Sidebar" heading in the How to Get section behind an application switch, so there isn't an empty section for Impress and Draw.
            
            In source/text/shared/guide/paintbrush.xhp
            - Added links to the help pages for Standard Bar and Clone Formatting tool.
            - Added information for copying attributes within Impress
            - Added a Related Topics section
            
            In source/text/shared/main0201.xhp
            - Added embedded link to the Paintbrush icon.
            
            Change-Id: Ib6a7b380bcbe70a0626c69e409a7b05142e1b30b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168326
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d557d2ae8c3c259bcf01465e6380cad77ed4bdb9]

        Related: tdf#137543 - Add new LET function to Calc
        
        Fix parsing name strings in Let function, so the invalid names
        will be parsed as an ocBad - svString like before.
        
        follow-up commit: 521a56d8d1e12b7471fda6b62b21d51776c9fbaf
        
        Change-Id: If4645584500ffd85556695b12fa7c99eaa8f7662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168503
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33111d134b0703f682687d144a38acdb48717f3b]

        the remaining Help::GetHelpText calls don't want their parent as fallback
        
        so we can drop the hierarchical search
        
        these probably do nothing in the absence of the classic help. fpicker
        case might benefit from moving some a11y translations out of help into
        core.
        
        Change-Id: I01b8d0c7cc1a1b3697d3332e330c6b4654e76af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168507
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dc346060164e800c7fed7859b17c19ddd2e027c9]

        drop searching for widget extended tips in the offline help
        
        by now these extended tips for the widgets of the general ui appear in
        the .ui file directly instead as accessibility descriptions instead.
        
        In any case, the default build configs of
        
        distro-configs/LibreOfficeLinux.conf
        distro-configs/LibreOfficeMacOSX.conf
        distro-configs/LibreOfficeWin64.conf
        
        use --with-help=html
        
        where these ahelps are not available. So, existing in the classic help only.
        
        Change-Id: Ie27736e9140e445c7f8986a741c2002f2efa9ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [69ebf09889c551c41aac951d2df97ff0e75d841c]

        customization entry help never wants to search for parent widget help
        
        it's not a widget context help where help about the parent widget might
        help in the case of nothing available for the child widget, but help
        for the specific selected command/script
        
        see also: https://bugs.documentfoundation.org/show_bug.cgi?id=116494
        
        Change-Id: Ib4b5650ca00c90b4b4b2a76ef0e3d8a438023327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168504
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [37b0c15c6a360758d1648b2ca47eff1de41f4f84]

        ICU: upgrade to 74.2
        
        Downloaded from https://github.com/unicode-org/icu/releases/tag/release-74-2
        
        Change-Id: I35a1b087f658541903a368fcaaad22c1c1e41d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168502
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-06  Justin Luth  <justin.luth@collabora.com>  [ec73b2894009a4cbb3446f8370b3de7bbbd5a35f]

        tdf#146756 unit test font: substitute Carlito for Calibri font
        
        I first substituted the theme font with Liberation Sans,
        but with those font metrics the label looked OK.
        
        So I tested with Carlito, which is metric-compatible with Calibri,
        and indeed it did give the same numbers both for the broken state
        and for the fixed state.
        
        Change-Id: I65c29443d6a867ef70a344eaddea6852b953f6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168497
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7a7df094ebe8c1a1205c64a410df893c3acf652]

        loplugin:ostr in sw/../utlui
        
        Change-Id: I542c3ab519f1b154e606943e867794127ec279c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168488
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [9aac754d39e9018ff70185956f488402ecac064c]

        loplugin:ostr in sw/qa/core
        
        Change-Id: Iaafc85d9b9042769f30c5662dbc9bf8c0e415312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168487
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84c75676bfe6f745d5bc70a74f8a7e82778227e2]

        if we don't have local help then Help::GetHelpText will be empty
        
        anyway, so we can skip that work on Window::GetHelpText.
        
        It might even be that by now all the a11y/extended-tips are in the local
        .ui files and the whole fallback to local help is redundant and should
        be removed. But that's not done here.
        
        Change-Id: I03b759aba6d1619aff37ded6764fbe3b6ded9555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168494
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7cea20d132f8f419bab28ed954635e29a16e5ae2]

        mar: allow parallel creation of diff packages
        
        also include the version number in the base-URL for the mar files in the
        json-file
        
        Change-Id: I613ac7c1cf3aeb1eff856c58f00a67151267606c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168100
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e4b420dfb57dec361032cf1fb1fe47cc69b46358]

        mar: use OS version in User-Agent
        
        this will allow the server to handle cases when we have to drop support
        for older versions of Windows for example
        
        Change-Id: I13f85a97179df6aa91e00853dbf6576d78854061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168152
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-06-06  Michael Stahl  <michael.stahl@allotropia.de>  [0d1c8e0427756414d3296b06a6f2c0e7b96ba250]

        sw: evaluate undocumented STYLEREF field heading switch
        
        forum-mso-de-86231.docx contains funny fields that use undocumented
        switch and style name:
        
         STYLEREF 2 \s
         StyleRef \2 \n
        
        Word can evaluate both and find the paragraph with style "Heading 2".
        
        Change-Id: I4c577fc633a56ef37ca5556e6d60f425c4171a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168496
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-06-06  Michael Stahl  <michael.stahl@allotropia.de>  [aac625cf1cc502de5d55c0b30afb962147ccf3e1]

        writerfilter: import undocumented STYLEREF field heading switch
        
        forum-mso-de-86231.docx contains a funny field that uses undocumented
        switch:
        
         StyleRef \2 \n
        
        Word can evaluate it and find the paragraph with style "Heading 2".
        
        Translate it to "2" in DomainMapper, which is also evaluated by Word.
        
        (regression from commit d4fdafa103bfea94a279d7069ddc50ba92f67d01)
        
        Change-Id: I587e6df1ea72642278d93723ed6692ff5011ed57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168495
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [be462215766a2bc53e50de24e0a95950e0afa6f8]

        Update git submodules
        
        * Update translations from branch 'master'
          to e792da64bdd30891f9403604d68eebfea07c82e0
          - update translations for master / 24.8.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Icb1e64bed6621dec76e972ecaf58197d4c0f1d6e
            
2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f20ee5c9b50e1a4596da1eb27994556f32fe622]

        crashreporting: crash in CustomAnimationPane::UpdateAnimationLB
        
        speculative fix
        
        sd/source/ui/animations/CustomAnimationPane.cxx:2189
        vcl/source/control/ctrl.cxx:298
        sd/source/ui/animations/CustomAnimationPane.cxx:2189
        vcl/source/control/listbox.cxx:907
        vcl/source/window/paint.cxx:781
        vcl/source/control/ctrl.cxx:485
        vcl/source/control/listbox.cxx:906
        vcl/source/control/listbox.cxx:189
        vcl/source/control/imp_listbox.cxx:722
        vcl/source/control/imp_listbox.cxx:686
        vcl/source/control/imp_listbox.cxx:1133
        
        Change-Id: I707fcbcd8a86ef7cf736b5244d9e4a78fd7b4ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Patrick Luby  <guibmacdev@gmail.com>  [ab37b88edd3298f1bd0a15470f5718c8784b4110]

        Fix a memory leak
        
        CreateNSString() expects the caller to release the returned string.
        
        Change-Id: I578488dd99c4c2737894287ab3e597ba8607669e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168040
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2802ba82d2ac0b9d831117dcc47375fd1dd01415)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [dadbad32eefec9a887da0aef2ad0237f89680dfa]

        Online: send color preview JSON property to online
        
        - Autofilter has submenus like `filter by font color` and `filter by bg color`
        - to display it's color preview in online we some data from core to identify that it's a color base dialog
        - this patch will help to add color preview of following
        
        Change-Id: I71c4e276f8c6dd35d6d318ce67cedf9c15a91d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165298
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 5d7910f21e881998f142aef473b27ebfd29eb020)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6b9ce4b5bd839868642086dc86262204312ac2d]

        cool#8570 try to reduce CPU spent in MsLangId::getScriptType
        
        for some reason the optimiser does not like the o3tl::anyOf template
        method and does not inline it nicely.
        
        Change-Id: Iab504989185c05caaefae3df34e85b8898c6f0c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167761
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Jonathan Clark  <jonathan@libreoffice.org>  [0eedac9d666659a0e4b4892cff36a735db10c81f]

        tdf#161397 Fix incorrect glyphs for RTL font fallback
        
        This change fixes an issue causing incorrect font fallback for certain
        RTL grapheme clusters.
        
        Change-Id: I6cff7f175b766d40c4faf204d1d65c8c366eb3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168410
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-06-06  Weblate  <noreply@documentfoundation.org>  [d106539f8f9a871ba081082291a6976d294aef58]

        android-viewer translated using Weblate
        
        Japanese currently translated at 80.1% (93 of 116 strings)
        
        Change-Id: I558bd48e66a90ad580a7b3f54379072af9c16dff
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 78.4% (91 of 116 strings)
        
        Change-Id: I42d1e535c6ef14d4f5f3d66a10b5562a487015ae
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 77.5% (90 of 116 strings)
        
        Change-Id: I26cb3b9e8a1c9ed4b92fb1ed8ba08d81a0d646d3
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168333
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-06-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1383303f28b42c2fb2f6fb2aebfb856f73a6ebd8]

        Flatpak build needs an explicit --without-system-rhino now
        
        ...after
        <https://git.libreoffice.org/core/+/479a39cbf0f4564abe93066d7a3f6b2e82de0e76%5E!/>
        "clean up after removal of patched rhino" made it default to --with-system-jars
        (which in turn defaults to --with-system-libs)
        
        Change-Id: Ie2656c4af8d7fc5175cec317eadbf120132cfdf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168490
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [3735d43955a000db8b6fff04a2214793be649c4b]

        tdf#161340 Revert partially 6cdf523f179f3e7ed94267502a5fe3d1247398cc
        
        so that hiding drawing shapes from Print Dialog still works
        with the 'Images and other graphic objects' option
        
        Change-Id: I3c6612f1074e31d1007523709858e2c8ab6de809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168467
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-06-06  Andras Timar  <andras.timar@collabora.com>  [e765cc07e5fb95c5cdfd76f672777e665cc6ca34]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to a2bf59878dd76685803ec260e15d875746ad6e25
          - Make Italian dictionary usable e.g. for Italian (Switzerland)
            
            Change-Id: I16bd7e8735e96009bf7138519c1db962d11b98d2
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/168489
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-06-06  Michael Stahl  <michael.stahl@allotropia.de>  [3e7478ef9706e74ac551c1f94090e163e74c7fd8]

        tdf#157931 sfx2: fix modified status of Base forms
        
        The problem is that when a Base form is not in design mode, it's not
        expected that it will be stored.
        
        There are checks for m_bOpenInDesign in ODocumentDefinition::save() and
        ODocumentDefinition::saveAs() that were added in commit
        9cfe62966ff1e0039d95a07d0c613675a53e3075 "CWS dba201b" but removing
        these runs into another check in OCommonEmbeddedObject::storeOwn()
        of m_bReadOnly and then it still fails, presumably because the storage
        was opened readonly.
        
        Let's restore SfxObjectShell::IsEnableSetModified() to check
        IsReadOnly(), but only for Base form documents, which seems simplest.
        
        (regression from commit bde746141f9b382156a5ce79ebf82c5e32fc455b)
        
        Change-Id: I886389e2bd462d27ed5c46bfd2132893bb2d5a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168481
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-06-06  Attila Szűcs  <attila.szucs@collabora.com>  [c30c1d12f283e75fdcc5bb508a79a9d33a431d28]

        tdf#153008 svx: impl crop for stretched bitmap fill
        
        The ticket had a pptx with a:
        <a:blipFill> <a:stretch> <a:fillRect ...>
        Impress loaded the fillRect as a crop, but never used.
        
        Implemented a crop in
        SdrFillGraphicAttribute::createFillGraphicAttribute
        because in the case of stretching, it blindly used the whole picture.
        
        Cropping data was not available there so it is copied
        into OffsetPosition, and Size
        
        Change-Id: I195cc40a35dc24c708e7c0e3cdbe40d6e47b8ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168391
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-06  Bayram Çiçek  <bayram.cicek@collabora.com>  [734914261347d51dfd4f1140b037c52c86060277]

        tdf#159375: turn cursor into a wait cursor while search
        
        - Tools>Options: change cursor type to "wait cursor" while search is running
        - m_xSearchEdit->set_busy_cursor(true) adds a spinner next to/(or in place of) the mouse cursor.
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I944db49b14a652b4a52f0d38696f60385ee9f85b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168402
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-06-06  Miklos Vajna  <vmiklos@collabora.com>  [c6a2fb62947ae8411a8a336d74f2ceb2258c899c]

        sw: remove unused DECLARE_RTFEXPORT_TEST()
        
        Replaced by CPPUNIT_TEST_FIXTURE().
        
        Change-Id: I6966e94bf39f8353ca00287939aa348176e001ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168484
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5b6340d3df48b266843fad276e638c309b02e6e5]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/84d2c9ed4f9644e5afa385ec3ef345a43a3a8525>
        "Update gvfs-1.54.0.tar.xz to 1.54.1 (#291)"
        
        Change-Id: Ifeeecca84d4e01f0abe05dc8c6ead65dbedd3da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168483
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-06-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [521a56d8d1e12b7471fda6b62b21d51776c9fbaf]

        tdf#137543 - Add new LET function to Calc
        
        Add new LET function to Calc which assigns names to calculation results.
        
        TODO: oasis proposal
        
        Change-Id: Ia0d56a30751a44a72e364a28b64fd8f617e997dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168349
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-06-06  Jim Raykowski  <raykowj@gmail.com>  [200f74b8004564d226dce5cde7d4aa2d109f258f]

        tdf#160539 Quickfind sidebar: Words are cut-off at beginning and end
        
        Adjust the search finds list entry text subview of paragraph text
        around the search find to start and end at a pseudo word boundary.
        
        Change-Id: Ib1e94b0fa7f5b3f557a19259b1c83bf43ca6fa14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168355
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-06-06  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [4e21f1df31b6e792490f67178aefae370a91ffb7]

        tdf#161151 finish renaming gradient geometries in sidebar
        
        Change-Id: I8ffa123427302cb091c5bb603aede711a32ecdbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168415
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9fa0b6977ba8292bfcc313caf080733090974c3f]

        Resolves: tdf#161430 reindex the correct style if there are duplicate names
        
        Change-Id: I6d4e96faef3ec6caa038edf7595f91f20d964807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [039a18ff147be304966caf529e6f14ad4996a3e0]

        compute these using floating point
        
        which means we can avoid the checked_multiply complexity
        
        Change-Id: I2badbde7bf9c6f18337913034b24672fddce3af8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c32d97c5a5d6f94713feaf7867abb1ce11cf9a14]

        sfx2: more diverse colors from string hash creation
        
        Change-Id: I3aa1ddefd26435cd20ec17ec7750073ac1407dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166945
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9e873da55c925b0a960950e9edd1e615e54b8edd]

        embindmaker: Fix names for "uno_Sequence_unsigned hyper" etc.
        
        ...to rather be "uno_Sequence_unsigned_hyper" etc. (without an embedded space)
        
        Change-Id: I1a02a12077a1e0a5468dc3c0d04f86bb0e951670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168478
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-05  László Németh  <nemeth@numbertext.org>  [886cbcd7627985692d4d2ad3197b1af08378d430]

        tdf#161426 sw: fix selection in multicolumn floating table
        
        It was not possible to select text content of a cell, if
        one of the previous cells in the same row contains a cropped
        image hovering this cell, too.
        
        Follow-up to commit f3b899655018397e71300dbb32cdf4f82940a68b
        "tdf#160842 sw: select cell content instead of cropped part of image".
        
        Also clean-up to commit 2f7bb481c57458a38769ebd961f07cc45767f1f7
        "tdf#161332 sw: fix missing selection of floating table".
        
        Change-Id: Ib033f7238d9513c8ed18c472ce4afbd4d6ad1172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168475
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-05  Heiko Tietze  <tietze.heiko@gmail.com>  [22cce3ece004a89e1ed9025437d96f150cc98857]

        Resolves tdf#161293 - Alt+9 shortcut for Find sidebar
        
        Change-Id: I5ab6916c7cf065f986117b12ebbb9a15b6c2147e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168469
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [78eb0a3c67ba2285f3737a584a133536beee3b17]

        loplugin:ostr in sw/.../uiview
        
        Change-Id: Id50d9549bb925f3ff2f4db79058b600a25349576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168426
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [20ba17a928acbba022b2f19b7a88a6cc5cdebfde]

        reduce some SAL_WARN spam
        
        Change-Id: I175677bc41c4113e030094afbc45d57ace773b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168450
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [870200f9ce451dfbb6188d4c2a024f59adb09f47]

        Simplify make.clean in helpcontent2 gbuild
        
        Change-Id: I795aa46943b4433624dfc04e9962e2a40528d188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168470
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e467cb52d68692e936eb07c2c1faa45f03dd1f82]

        annot: add {add,remove}Annotation that don't notify
        
        Add addAnnotationNoNotify method, that doesn't broadcast that an
        annotation was added, and change addAnnotation to call the method
        and in addition call the broadcast bits. Previously all this had
        happened in the addAnnotation without the choice to not broadcast.
        
        Change removeAnnotation in a similar way.
        
        Change-Id: Ie15a386a8b8d4493d5b41fcbcb55924a693b46d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168429
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [367ba88092fbc0ba06a7f77157cd012ff0fe3caf]

        Related: tdf#153008 bump XFillBmpPosOffsetXItem to sal_Int32
        
        and XFillBmpPosOffsetYItem. To avoid sal_uInt16 overflows on large input
        values.
        
        Lets use sal_Int32 instead of sal_uInt32 given the amount of existing
        casting to sal_Int32 of XFillBmpPosOffset[X|Y]Item::GetValue()
        
        Change-Id: I8329c11b75c9ad01011e10130257963737ffe553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168398
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Tested-by: Jenkins

2024-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4cd2737d829e8a3413ad3d60a17dded4dcc8938c]

        annot: prepare SdrObject to represent an annotation
        
        Change-Id: Iabcc2166ea20cbeac6d2ada7120700a4e8b19303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168428
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ad9f15a0b9b7b481e03f66bfb9564deefcfd13af]

        sd: simplify NotifyDocumentEvent, remove duplication
        
        Change-Id: I4f16925c1271261d37e3b9146bc2458581798924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168421
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [11ee53f9f14191453c12189d20423eb2fad008f9]

        nss: upgrade to 3.100
        
        Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_100_RTM/src/nss-3.100-with-nspr-4.35.tar.gz
        
        Change-Id: I44782e3bcc82f879cb8e4888509b876fa05b43bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168452
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e91404b8b6e5c95ab9bfc055006edc0a17df2e94]

        Fix typo
        
        Change-Id: I4706e1f5a2de6f1a0e48bd5e297eb904ac66f581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168458
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f32848500aa25a0e4e29053900c7827ec9a3b535]

        Fix typo
        
        Change-Id: Ice2853eb7a14bd614b9bb53ce13667602c6e07eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168457
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-05  Miklos Vajna  <vmiklos@collabora.com>  [937bdd08ee8ff9ce90db06fd463719ba8e9da996]

        tdf#161417 RTF export: handle endnotes at section ends
        
        Similar to commit 566c7017a84e3d573de85a6d986b81d3f59de0fa (tdf#160984
        sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd,
        2024-05-29), but this is RTF, not DOCX.
        
        Additional complexity is that it's not enough to just write \aendnotes
        (sect end) or \aenddoc (doc end) to export the position, also \fet and
        \endnhere needs writing, otherwise Word ignores this.
        
        Last bit is to ignore section formats which are not nullptr but are -1,
        ignore these in RtfAttributeOutput::SectionBreak(), similar to how
        DocxAttributeOutput::SectionBreak() does the same already.
        
        Change-Id: I2327c979d5af402eb15523d97149f6409fcf4adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168468
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3a70a28b0becc9c872f2a92c35dfdaac4822600]

        openssl: upgrade to 3.0.14
        
        Downloaded from https://www.openssl.org/source/openssl-3.0.14.tar.gz
        
        Change-Id: Ib75738f257210532d0f01f429ec3b78a1a2410a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168456
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-06-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [243e811abc441ec7f55e1395f23343dfa6f7c812]

        cid#1603200 Uninitialized scalar variable
        
        cid#1603199 Uninitialized scalar variable
        
        and other fixups for:
        
        commit fbe8071e4f6be57d3e372d69a4c7cc4d37a83eb9
        Date:   Sat Oct 15 14:20:31 2022 +0200
        
            refactor functions: return optional instead of bool
        
        Change-Id: I192017d0fc710ada7686e4c6dd313727b02f3889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168453
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [309768c2f54ce0ff5fa4b3409996733afa96bc02]

        loplugin:ostr in sw/.../uno
        
        Change-Id: I70205955fdfa261fdf2b8d66d546eded549464a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168427
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2b7dca2eb1da105fe139b3f14bb9dfaae11d549]

        loplugin:ostr in sw/.../misc
        
        Change-Id: Id64ac6bdebe93af6364ccf39d4ae8df333e775d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168425
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [31f46cec1406bb39453f5d909da1321980b0e405]

        tdf#144752: UNDO/REDO: make sure to select the replaced content
        
        In the specific case of the bug, the non-empty selection means that
        the spell check won't skip the word with the cursor. But this also
        establishes consistency with other Undo/Redo cases, which generally
        select the text.
        
        Change-Id: Ib7c1c911908dc59947e610d735907be7a363ca87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168423
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ea67891bb9a554efb93f43ae73fc6a9a58dcc040]

        Fix make 'clean' command in helpcontents2/
        
        Change-Id: I1bc66a8f4a4c258983e1fa141cc106bd52c27dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168412
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-06-05  Miklos Vajna  <vmiklos@collabora.com>  [ad8fa1b5912a04f4cc016965175315e4784fa229]

        tdf#161417 RTF import: handle endnotes at section ends
        
        This is similar to commit 2d2dd56e0b2dc708f1f758d7fc9a1263ff09b83c
        (tdf#160984 sw continuous endnotes: DOCX: import <w:endnotePr> pos ==
        sectEnd, 2024-05-28), but that was for DOCX import, this is for RTF
        import.
        
        Change-Id: I6772f78360f681d18559556e71526eb76670bec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168424
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-05  László Németh  <nemeth@numbertext.org>  [78a9afc5ea493a703467b72475a9d80a9fa8a6db]

        tdf#77388 sw: add missing comment
        
        Change-Id: Ie288374f7d14171b84488adf5573915d8a5e6f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168417
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-05  László Németh  <nemeth@numbertext.org>  [3e0650fb166cac116a43f6ce5d03bd69830e37b8]

        tdf#157533 sw: fix cursor position deselecting formula in table
        
        Fix lost cursor by deselecting formula object anchored as
        character as single content of table cells. In this case, the
        cursor was positioned inside the frame of the formula,
        disappeared in a flash.
        
        Fix also bad cursor position by deselecting formula object
        anchored as character at beginning of text lines in table
        content.
        
        Follow-up to commit 014e5f559a9acf319af24c721dbe6b0bc3bc5882
        "tdf#161360 sw: fix cursor position deselecting image in table".
        
        Change-Id: Ia1a96359f473071c4cead580322aa9c1af1d3f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168416
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e03d54c2652049a1315fcddcb6a8e881a0ca65cb]

        sd: change CHECK_RANGE macro to template function
        
        Change-Id: Iecd6f37324b2788fac77b272ac56c3a2eb122dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168420
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bd7638485220f17472157a02608e1080c25376cc]

        annot: improve PDF annotation export and clean-up PDFNote class
        
        Add support for exporting more PDF annotation types and props.
        Prefix member variables in PDFNote class, extract it out of
        pdfwriter.hxx file into it's own header file.
        
        Change-Id: I99fb4cbb0c68fcec6585c9c21d81daaef26344cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168418
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b4f416abc245ae63c164d51ee9fd4d4c849e0411]

        Clean up example code
        
        * Consistently use `const` to introduce variable bindings.
        * Don't rely on `xText` from the first example in the second one.
        * No (more) need to query for base interfaces.
        * No (more) need to delete interface references.
        * Add a missing delete of Any `next`.
        * Remove a redundant empty line.
        * Adapt to our 100 character line width.
        
        Change-Id: Ie116021a4b0cc6d88c6204e7ea5147a837c251f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168405
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [44e618096511e8f6e0a6344fab19403503c25148]

        tdf#136294: trigger pending spellcheck in SwCursorShell::UpdateCursor
        
        This allows to drop the partial fix created for tdf#124603  (except for unit
        test). The problem solved in commit 4c91e94e892943ef5e031d65f6f42864233cb4cd
        (tdf#92036: sw: fix idle spelling loop,  2015-09-09)  is kept solved; when a
        word is marked pending,  this is signalled  to the viewshell.  SwCursorShell
        stores that as a flag,  which will then start an idle on cursor update,  and
        finally call SwViewShell::LayoutIdle, which does the spell checking.  If the
        cursor is still in the word that is pending the check, the cycle will repeat,
        trying spell checks only at cursor update, not as a busy loop.
        
        Change-Id: I5dc77baabffa723e261d553e40d40e5ace4266bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168413
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-06-05  RMZeroFour  <ritobroto04@gmail.com>  [32eaef8ddb7acbd8ab40c69acd9b8ca06a26b015]

        tdf#143123 Port Java clipboard examples to Python
        
        This commit ports the Clipboard example from
        odk/examples/DevelopersGuide/OfficeDev/ to Python.
        
        The original Java example code was moved to a java/ subdirectory, and
        the new Python code was added to the python/ subdirectory. Necessary
        changes were made in the corresponding Makefiles.
        
        Along with the sample code in Clipboard.java, the ClipboardListener,
        ClipboardOwner and TextTransferable classes were ported.
        
        Change-Id: Ic3a48023cfc78b770ae64adb2aee2b4d0bcefaff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165225
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [cbf2513facdf75b76cc01aafbffebb0e1c4c4c44]

        NotoNaskhArabic: upgrade to v2.019
        
        Downloaded from https://github.com/notofonts/arabic/releases/download/NotoNaskhArabic-v2.019/NotoNaskhArabic-v2.019.zip
        
        Change-Id: I2441e446d19a5f4b81aa6344e3937f4afe86be55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168409
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [79a277aa58887240eacc63b55a26ee3ff59d8391]

        NotoSansHebrew: upgrade to v3.001
        
        Downloaded from https://github.com/notofonts/hebrew/releases/download/NotoSansHebrew-v3.001/NotoSansHebrew-v3.001.zip
        
        Change-Id: I4c39f7b3f56bbdb1b8e8ced58129f15177841da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168407
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d6607a9d9a3076c1d7c9a3e284631c5f57c24137]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1eb2e622fbd81928bc7e8b48f75332c787c01225
          - tdf#161413 Don't allow note icon SVGs to shrink
            
            Change-Id: I0d760f0e784f3ef2beb0fa9f80fdb52f7222b298
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168411
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-04  Miklos Vajna  <vmiklos@collabora.com>  [e42b7ab0c796f5b2a985cdac56b1c342c5501984]

        bin: add a diff-pdf-page.py script to diff reference vs our rendering via PDF
        
        Thanks László Németh for the idea, the mechanism used in the tool was
        also used to generate the visual diff visible at
        <https://wiki.documentfoundation.org/ReleaseNotes/24.2#New_line_break_algorithm_for_interoperability>.
        
        Change-Id: I51afb08c60c7134f75a54acdb94b49d2ff94befd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168404
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [da4259bd7fef35185418cad7a695268add6341a2]

        windows packaging: reduce parallelism further to three
        
        Some jenkins daily builders still run into issues from time to time, and
        even at a reduced parallelism of three it doesn't affect overall
        buildtime when building with just two or three languages and also not
        when building with all languages. There might be a number of languages
        where this has a penalty, but probably not a significant one.
        
        Change-Id: I778b5fe21fe8f9bb1fcca1da3c4c0eeeda6c29d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168403
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-06-04  RMZeroFour  <ritobroto04@gmail.com>  [21d7936b320e084a08ef70211a3a51106503ab98]

        tdf#143123 Port Java PathSubstitution example to Python
        
        This commit ports the PathSubstitution example in
        odk/examples/DevelopersGuide/OfficeDev/ to Python.
        
        The original Java example code was moved to a java/ subdirectory, and
        the new Python code was added to the python/ subdirectory. Necessary
        changes were made in the corresponding Makefiles.
        
        The example can be run with: ./instdir/program/python \
        ./odk/examples/DevelopersGuide/OfficeDev/PathSubstitution/\
        python/path_substitution_test.py
        
        Change-Id: I6c7a8af86cee2dc9cb5384e42bd9644847f28767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166264
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-06-04  Miklos Vajna  <vmiklos@collabora.com>  [24ab535087991f1ce8dee9a561476bc0a987bac5]

        tdf#161417 DOC export: handle endnotes at section ends
        
        Similar to commit 566c7017a84e3d573de85a6d986b81d3f59de0fa (tdf#160984
        sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd,
        2024-05-29), but this is for DOC, not DOCX.
        
        Change-Id: I4301d97115ba48f7ed1dacfdd5b29336bdaf9e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168401
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [87e8e79da0769fbc37a274049d31da07359713f4]

        loplugin:ostr in sw/.../shells
        
        Change-Id: Ie8d62b127cfa521d28dbd26073e4d6d89dfdcdf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168396
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-04  Heiko Tietze  <tietze.heiko@gmail.com>  [199ffecd9586d3a8c3365bdbc979c93600f25899]

        Resolves tdf#161395 - Rename Whole Number to Integer
        
        Change-Id: Id4cce115823781e5f2a4870d38d1f456cdf417a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168395
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-04  Miklos Vajna  <vmiklos@collabora.com>  [31490e9bd93bfd622ddda79e927114b3fafba6c1]

        Revert "svtools: fix crash in BrowseBox::GetControlArea()"
        
        This reverts commit ec5aa7e88b0d412041f8575111f0da295065cecb (svtools:
        fix crash in BrowseBox::GetControlArea(), 2024-06-04), not needed after
        commit 6f2b5043613bea755f01b413fd86ece0b3a29e5d (crashtesting:
        BrowseBox::GetControlArea crash, 2024-06-03).
        
        Change-Id: I1e86380041266b1fb83f11df37700f10cc88e5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168399
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-04  Andrea Rosetti  <andreamassimo03@gmail.com>  [fbe8071e4f6be57d3e372d69a4c7cc4d37a83eb9]

        refactor functions: return optional instead of bool
        
        Change-Id: Ic4ff3ddaac161df13bf1e3e1372811a0685ec6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141417
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-06-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c9245c153d349ee414fdd4f878fd10cbd8471cff]

        Related: tdf#128425 tdf#127293 - Extend function wizard description
        
        about match_mode and search_mode options.
        
        Also do not allow wildcard match mode with binary search mode
        as it was decided at the odf meetings.
        
        Change-Id: Iadc1b6735ae62bb07675a664d9954ebc27519691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168366
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-06-04  Laurent Balland  <laurent.balland@mailo.fr>  [76463bc0b18df16043d6a57f3f3e3a443c3224bb]

        tdf#160712 Update Yellow Idea template
        
        - use only Noto fonts
        - rename master slide "Cover" to "Yellow Idea" (see tdf#158496)
        - rename master slide "Contens" to "Contents" and Illustration3 to
          Illustration2
        - change Thumbnail
        - use placeholder instead of dummy text
        - create groups of objects to ease manipulation
        - create styles Outlined Thick and Thin
        - use styles Outlined Yellow to keep same yellow everywhere
        - remove unused styles
        - remove pictures which were used only for shadow
        - replace drawing of figures with text on master Contents
        - master Infographics2:
           - replace drawings of figures with text
           - replace arcs with modifiable segments
        
        Change-Id: Ia04522d4e9196a14db8431d05922618648a68c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168027
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-06-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [1d4aa9ab30d97060b7069f844264bf1c9c74837f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b256e08a31624c1c55894b4f11065c75423af30e
          - tdf#161413 Prevent SVGs without width from overflowing the container
            
            Change-Id: Idaf3a4f4d0d286520565623b29bbc186fbfd79d8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168400
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [36b09bd8099e0ce4da588a693d1e3b45511b3716]

        basctl: use SAL_RET_MAYBENULL in GetBindingsPtr()...
        
        ... GetDispatcher() and FindBasicManager()
        
        Change-Id: I6de6035f17b74313a5cbb9964ceafcbe3161ef2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168397
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-04  Miklos Vajna  <vmiklos@collabora.com>  [ec5aa7e88b0d412041f8575111f0da295065cecb]

        svtools: fix crash in BrowseBox::GetControlArea()
        
        UITest_writer_tests4 sometimes (but not always) crashes for me,
        typically not when it's execute alone, but when it's executed as part of
        'make check'. The soffice process crashes on shutdown, after all tests
        passed without problems.
        
        coredumpctl gives this in gdb:
        
        	Program terminated with signal SIGSEGV, Segmentation fault.
        	#0  BrowseBox::GetControlArea (this=0x9bd3f90) at svtools/source/brwbox/brwbox1.cxx:2137
        	2137        auto nHeight = aHScroll->GetSizePixel().Height();
        	(gdb) print aHScroll
        	$1 = {m_rInnerRef = empty rtl::Reference}
        	(gdb) bt
        	#0  BrowseBox::GetControlArea() const (this=0x9bd3f90) at svtools/source/brwbox/brwbox1.cxx:2137
        	#1  0x00007fbbd2022ed9 in DbGridControl::RearrangeHdl(Timer*) (this=0x9bd3f90) at svx/source/fmcomp/gridctrl.cxx:2646
        	#2  0x00007fbbd2022ea3 in DbGridControl::LinkStubRearrangeHdl(void*, Timer*) (instance=0x9bd3f90, data=0x9bd4468) at svx/source/fmcomp/gridctrl.cxx:2643
        	#3  0x00007fbbcedb8d79 in Link<Timer*, void>::Call(Timer*) const (this=0x9bd4488, data=0x9bd4468) at include/tools/link.hxx:111
        	#4  0x00007fbbcedb8c01 in Timer::Invoke() (this=0x9bd4468) at vcl/source/app/timer.cxx:75
        
        Let's assume the problem is that somehow we can get here after the
        VclPtr is already disposed and just return early to avoid the crash.
        
        Change-Id: Ic27727dc3622d8da88256c80f873dc79795864b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168393
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-04  Adam Seskunas  <adamseskunas@gmail.com>  [4078428a401f4a99045451b59863d6001cdcc20b]

        Port framework/qa/complex/XTitle/CheckXTile.java to Cppunit
        
        framework
            - Remove CheckXTitle.java from makefiles
            - Create new makefile for CheckXTitle
        
        framework qa complex XTitle
            - Remove JUnit test
        
        framework qa cppunit
            - Add new CppUnit test suit CheckXTitle.cxx
            - checkDefaultTitle: tests if default title is the same after cycling through the default window and print preview
            - checkTitleDefaultFileName: tests if a window title set with  SuggestedSaveAs is in fact set with said name
            - setTitleAndCheck: tests if after setting window title and cycling through default window and print preview, there is infinite recursion
        
        Change-Id: If7794f0f853ef427bb735a22752cff3635f5ff63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168168
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [ecd42fe1885e8fca0ec302a6d0a666f925fa62d9]

        Make sure that the big value doesn't readily overflow
        
        As shown in https://gerrit.libreoffice.org/c/core/+/168235/6#message-5e7ed6fecf7fd36dc167193e25c3ec94daa11cb3
        
        > looks like this started to break e.g. CppunitTest_sw_mailmerge2 with
        >
        > /sw/inc/swrect.hxx:251:48: runtime error: signed integer overflow: 13569 + 9223372036854775807 cannot be represented in type 'long'
        >     #0 0x7f30b337cb90 in SwRect::Bottom() const /sw/inc/swrect.hxx:251:48
        >     #1 0x7f30b337234f in SwRect::Overlaps(SwRect const&) const /sw/inc/swrect.hxx:376:30
        >     #2 0x7f30b699354b in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3316:23
        >     #3 0x7f30b699376f in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3317:17
        >     #4 0x7f30b699376f in lcl_CheckFlowBack(SwFrame*, SwRect const&) /sw/source/core/layout/frmtool.cxx:3317:17
        >     #5 0x7f30b698d21e in Notify_Background(SdrObject const*, SwPageFrame*, SwRect const&, PrepareHint, bool) /sw/source/core/layout/frmtool.cxx:3415:13
        >     #6 0x7f30b5b941b4 in lcl_NotifyBackgroundOfObj(SwDrawContact const&, SdrObject const&, tools::Rectangle const*) /sw/source/core/draw/dcontact.cxx:955:13
        >     #7 0x7f30b5b7c9b9 in SwDrawContact::DisconnectFromLayout(bool) /sw/source/core/draw/dcontact.cxx:1689:9
        >     #8 0x7f30b5ba0cae in SwDrawContact::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/draw/dcontact.cxx:1544:17
        >     #9 0x7f30b399e3c2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:311:18
        >     #10 0x7f30b399e6c5 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:316:15
        >     #11 0x7f30b6656d23 in SwDrawFrameFormat::DelFrames() /sw/source/core/layout/atrfrm.cxx:3525:5
        >     #12 0x7f30b51785f8 in sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat*) /sw/source/core/doc/DocumentLayoutManager.cxx:235:14
        >     #13 0x7f30b4df70ac in sw::DocumentContentOperationsManager::DelFullPara(SwPaM&) /sw/source/core/doc/DocumentContentOperationsManager.cxx:2343:55
        >     #14 0x7f30b42b5701 in SwDoc::RemoveInvisibleContent() /sw/source/core/doc/doc.cxx:1576:57
        >     #15 0x7f30ba70c920 in SwDBManager::MergeMailFiles(SwWrtShell*, SwMergeDescriptor const&) /sw/source/uibase/dbui/dbmgr.cxx:1468:35
        >     #16 0x7f30ba6f7eff in SwDBManager::Merge(SwMergeDescriptor const&) /sw/source/uibase/dbui/dbmgr.cxx:556:20
        >     #17 0x7f30bbe0d561 in SwXMailMerge::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) /sw/source/uibase/uno/unomailmerge.cxx:786:24
        >     #18 0x7f30bbe103ce in non-virtual thunk to SwXMailMerge::execute(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&) /sw/source/uibase/uno/unomailmerge.cxx
        >     #19 0x7f30d009b8ed in (anonymous namespace)::MMTest2::executeMailMerge(bool) /sw/qa/extras/mailmerge/mailmerge2.cxx:195:31
        >     #20 0x7f30d00eb3e5 in (anonymous namespace)::testTdf123057_file::verify() /sw/qa/extras/mailmerge/mailmerge2.cxx:597:5
        >     #21 0x7f30d00a11eb in (anonymous namespace)::MMTest2::executeMailMergeTest(char const*, char const*, char const*, char const*, int, char const*) /sw/qa/extras/mailmerge/mailmerge2.cxx:99:9
        >     #22 0x7f30d00efc32 in (anonymous namespace)::testTdf123057_file::MailMerge() /sw/qa/extras/mailmerge/mailmerge2.cxx:594:1
        > (<https://ci.libreoffice.org/job/lo_ubsan/3194/>;)
        
        Change-Id: Ic34ad5c39d3b89c84f124e145a30714ba3752103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168364
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [587870297963b35ae8953adadbdc5ea8933004a7]

        sfx2: use SAL_RET_MAYBENULL in GetDispatcher() and GetFrame()
        
        Change-Id: Ic9876dbdd0dc0ce887a6eb135bd411f8e3dc9e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168288
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d947d39bedbae88b19be99fd3b43c612a25ea500]

        Fix typo
        
        Change-Id: I2c8899e5ab779dbd94c5096c72e2fbb09e40d4ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168377
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eb6c458bc97d18da342c7cd1aca5306b2ffe04e9]

        Fix typo
        
        Change-Id: I29b5c1f75c9126ec274c4e4324c6f4577b9dae7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168378
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8501cb20627e5bc36d760b53b0990f4105c4ff65]

        tdf#160844 we don't want scrollbars to be a target for Ctrl+F6, etc
        
        Change-Id: Ie24c10fa16889a70717cbee15aef38a20308934d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2c0157fbe9b9338f98e66d300664fe3c710eb415]

        cid#1602449 Resource leak
        
        Change-Id: Ide5575adb3346a0ad36a484078dc02ef46a4c043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [16b0ad3cf76d9932ebbd169af64b7ad292e68426]

        cid#1459023 Dereference null return value
        
        Change-Id: I3ff5f121a76a30d07a80b46d469b669010318701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168388
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f2b5043613bea755f01b413fd86ece0b3a29e5d]

        crashtesting: BrowseBox::GetControlArea crash
        
        see with forums/ods/forum-en-11050.ods
        
        Change-Id: I2b1dadf51ab8efa1b66f5b7463b05ad4dc52f91d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168386
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-03  László Németh  <nemeth@numbertext.org>  [03aa8a1d9bfe4af2f37df0bde42193c2cf90ffb4]

        tdf#77388 sw: fix missing table border at cropped images
        
        At images cropped by the bottom or right cell boundaries,
        or at images with zero padding in table cells (e.g, in
        test document of tdf#160836), table borders were hovered
        by the image, resulting missing table borders.
        
        First paint the cell content, and after that the DOCX-like
        "collapsing" cell borders in SwTabFrame::PaintSwFrame.
        
        Note: this doesn't modify painting of the objects
        anchored to characters (which still hovers the cell borders),
        and painting of the text content of the cells (which are
        still hovered by the cell borders at zero padding, despite
        their non-transparent background color).
        
        Change-Id: Ie41ab275fd101bb9e26d4165362063f0332ac3c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168384
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [e10ca8d250b39cc2778e9df47a06fd6ba4f2fced]

        tdf#160371: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: Ife3a319359391f0614260170c9ddfbac16e13cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168379
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b8a89b3356275e95e3fc78c79f55a209f8056556]

        tdf#69724 Disable 'Change Bullet' btn until selection exists
        
        Change-Id: I9c1fdeb4423a8fe45121ff58097582dcccdd12ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168359
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [782f7c23af25187b9205e7ca036cb819834be2df]

        loplugin:ostr in sw/.../sidebar
        
        Change-Id: Ic905099e9b7266998a414416c288fe0db87a618c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168373
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-03  Miklos Vajna  <vmiklos@collabora.com>  [b79b50c8f06a5c977451995b2d632e5738d7d335]

        tdf#160984 sw continuous endnotes: add enable/disable option UI
        
        Doing this via a macro was possible already, but that didn't invalidate
        the endnote positions on the layout, so required a document reload,
        which was ugly.
        
        Implement the new SwViewShell::SetContinuousEndnotes() by removing the
        endnote frames in the document, so they'll be re-created at the expected
        place as the layout action ends.
        
        Change-Id: If96e70ab29c5a6c95fce36775e9a9a61277fc8a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168383
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [04954ffee19bb2357dca69f929ac660f99d80f16]

        tdf#161301: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I9eece5baa5c283caee74131151519c5e72e9cc45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168376
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d804d6aff49054bad1719ec3c2d136b545bbc7e7]

        tdf#158789: sc_mathematical_functions: Add unittest
        
        Change-Id: Ia19dadffa511cb012e4d0271e1e3768e1e374be0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168365
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-03  Javiya Vivekkumar Dineshbhai  <vivek.javiya@collabora.com>  [d5c5732ada2f9f616e26ef514676adee2245c5e5]

        Remove unused 'numTiles' from glitter vertex shader
        
        The 'numTiles' variable is not being used in the vertex shader. To test this PR, apply the Glitter transition. If it works as expected, then the change is successful.
        
        Signed-off-by: Javiya Vivekkumar Dineshbhai <vivek.javiya@collabora.com>
        Change-Id: Ia1f833e6009b1f8c774329945ba260d20b8c9f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168222
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d620821608a4b89d10ce4b93aa03e6e6d5d04fa8]

        loplugin:ostr in sw/.../fldui
        
        Change-Id: If2c0761dc0c607cf5a0275f240521c0aaa916888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168363
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [00c92662a688e04c0dcec0db6c253689d662faeb]

        tdf#161248 Don't duplicate bullets used in document
        
        Change-Id: I0ef01a6be8207d4cffc89b95dc9ca3bf1baf38d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168358
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-06-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0fc56575b69e0083d66149adeeb90662e29cdac7]

        Update git submodules
        
        * Update translations from branch 'master'
          to fbbd7b927a869cfe63dfbf0542b967da94eef28e
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I49098e6b67b2b13457c5f911910aac85b0d70b5d
            
2024-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d7311b4f1ff824c74e9cef6cf12454115e5ccc0b]

        sd: use SAL_RET_MAYBENULL in GetViewFrame()
        
        Change-Id: If895a550fb2404f1a7cfcc4fb427674a3f6e5fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168287
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-06-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c2f9689cd489f44122b50d7c0d7841c47381df99]

        disable MSVC -analyse when run in CI - build time penalty is too much
        
        times went from 55min to 88min when doing a single build
        
        Change-Id: I9304eae9f2326c206bd571e7b8a3ef861206282f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168362
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [b3d23096e8f6e9f562a6d1f5a73922cf677870e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0bcda201437649d9a6cfc0c7b7875e19c511ea22
          - fix SUMIF function name
            
            Change-Id: I8da7fc131856a68ff10dea1c219fc0aabdbff867
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168353
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-06-03  Miklos Vajna  <vmiklos@collabora.com>  [61f5006c18b3194f6aaa03e260425dc878cfff79]

        svx: prefix members of SdrUndoGeoObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic34b5e1c7a1b73d688cc4dfc87c03417fe8e987b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168357
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [83d0b6bd8da7495bc962b83a6638e2aaab90a5ae]

        loplugin:ostr in sc
        
        Change-Id: I72438d38c75a7facb9bd5f9cfb7be1213ac3d141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [24b06580577425681e22472ee68ab00e9c509a83]

        cid#1602448 Unchecked return value
        
        and
        
        cid#1602447 Unchecked return value
        cid#1602444 Unchecked return value
        
        Change-Id: I8c6b8788b42e1abe171f5ab24aa4601a8fea7084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168346
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f6ea343e6fb2dc3539823dee60c9c6f96fc16275]

        tdf#161030 Improve vertical Tab list display
        
        * Increase width a bit to allow for longer tab names
        * Avoid jumping while moving through the list with arrow keys
        
        Change-Id: Ie418dd40c5f69dcdea8fa07743ff26e3c9e04ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168251
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-03  Zainab Abbasi  <101zabbasi@gmail.com>  [606bde742eb94767c9713f58a7b844c0c2957d60]

        tdf#157664 Drop operator !=, where respective operator == is defined
        
        Change-Id: Ib6f2338bf457b7a7e7b36152337bd777b9e1d293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166192
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-03  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [e5e3188165e2e3dd81f5e7ec554fe66f20f7b8fc]

        Fix typo
        
        Change-Id: I2901abfb392caba672259c056af7dd53388050ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168350
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-06-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [797e879990f9db3373197a5a83639ad5aebba8c8]

        Rename 'Organizer' to 'General' in style dialogs
        
        This tab page has general information about the style - name, inheritance, etc.
        
        Change-Id: Ie06cf8b149a369117c5102ba7e2aae0d97249b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166773
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f15d097cace14ca6e44e7652f460aa3fa7bd150]

        cid#1602446 silence Unchecked return value
        
        Change-Id: Idddff2f08dda1d43a197824fca82b69f7c212648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [68060a0213abbb9a6e16358f8deea4980dd22565]

        cid#1602445 silence Uncaught exception
        
        Change-Id: I3427f747859d9c1f144932b5966dc44c699b0ec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168344
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0d32c94b7ec01e8e1bb4b6d0d1f4f092260a6b00]

        cid#1602450 Dereference after null check
        
        Change-Id: I1953e75066d008f2d4f905e4419752278f73c908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168343
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [17992bf328ffe68a8573e638f7c94beb991c5fdc]

        cid#1602442 Uninitialized pointer field
        
        Change-Id: I3586685ba132fd09b00d778fc3fe8e479d1a8aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb982975c16e380f88282f03d07f8cfb8421ed77]

        svx: use SAL_RET_MAYBENULL in GetSfxViewShell()
        
        Change-Id: I05e66544c08a1ed55a5571f6061b23346235224e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168293
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-06-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e8392bc1c984da1f09674055b1bac95e12de59a6]

        allow low-translation-completion-langs for dev-builds (e.g.: Sundanese)
        
        will be included when using --with-lang=ALL in non-release configuration
        (i.e. tinderbox provided daily builds), but not when using
        --enable-release-build.
        Change the way how configure fetches the list of all supported languages
        from a fancy sed call to running make with a dummy-recipe.
        
        Change-Id: I8bbea5fd95d37eac5bbce2e55ae34830b0ab4ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168334
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [7e9c23894bd45e015accf26ae0a77035b7eed452]

        tdf#161368: use SwTwips for twip sizes, instead of sal_uInt16
        
        Change-Id: I9179b55eb27f1bf2f28c2c86f1e67f2a4daf4819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168341
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-06-02  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [594aa1f74c70ec82444779ef503f329970d45d6e]

        Remove unwarranted CamelCase from translatable string
        
        Change-Id: I3f4a9392a1449f9131861779279d85022f46f981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168337
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-06-02  Julien Nabet  <serval2412@yahoo.fr>  [74376c76285f6d38e559d7425e6a31148df10263]

        READMEs update: presenter console is now in sd instead of sdext
        
        since 02c4386a09c7364d58c50a388ff77db14810a218 (in 2023)
        move presenter console from sdext/ to sd/
        
        Change-Id: Ia88cdf437aa5546b251fa0eb95cde8a6b6c64391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168347
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcc30f482b0833460e38a48c07295a8e86b23478]

        tdf#144208 speedup doc with lots of redline(3)
        
        Shave 5% off load time by using ItemInstanceManager subclasses for some
        the more heavily used pool items
        
        Change-Id: Id389ebb397e2fccfcbae28c8043fe05011b8f1cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168307
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-02  Julien Nabet  <serval2412@yahoo.fr>  [fc37066963a866eeb342b3a41b916f2574f5de28]

        cid#1602443: use_after_free
        
        Change-Id: Ic7525bbd2d4d26f6bf07ecfb6ba6cf056a98580a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [71e2d887dcf0947328bac137ad1f3a3e58121310]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 540ea4b3f6f10a77fc06665de7c550c1eb9df00e
          - Improve example in Advanced Filters
            
            Change-Id: I1773fdfee5cc067551cbf7a7bad06cd705eecedf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168340
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2024-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [61f1a311ee174ee115af73a653b36ff62fa5dda0]

        Fix typo
        
        Change-Id: I3d86a73b9bf74256337243d99677295317e5eafc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168338
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-02  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [65526f6c81776c58d86a801093aeee85c9444785]

        Latest VS 2022 Preview is 17.11.0 now
        
        ...while latest proper VS 2022 is 17.10.0
        
        Change-Id: Ibc8c1c331659cb607e0dd51793097ac0495badb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168303
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-06-02  Michael Weghorn  <m.weghorn@posteo.de>  [a99575f04fa9c858bfcd996f037444135810d43f]

        tdf#194504 qt avmedia: Don't wait for video frame if there's none
        
        If the media doesn't have video, then don't try to
        grab a frame, but stop waiting for the
        `QVideoSink::videoFrameChanged` signal to be emitted
        in `QtFrameGrabber::grabFrame`.
        
        Don't call `QMediaPlayer::hasVideo` while the media
        is still being loaded, as the result is only valid once loading
        the media has been finished (`false` is returned otherwise
        even if the media file contains video), s. the platform
        implementation in qtmultimedia's `QFFmpegMediaPlayer::setMedia`,
        which loads the media in a separate thread: Once the media
        has been loaded, `QFFmpegMediaPlayer::setMediaAsync`
        calls `QPlatformMediaPlayer::videoAvailableChanged`
        to specify whether video is available.
        
        With this commit in place, opening an Impress presentation
        that contains an audio file (like attachment 194504
        from tdf#145735) now shows an "audio icon" as placeholder
        as expected and the application exits properly on close,
        rather than blocking as it's still waiting for a video frame.
        
        Change-Id: I5448a9f7396d4c419d76a2400e3f2a1ef52a7e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168305
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1071db05c2b5a5a9974ec9ece12f60217ab86db6]

        ofz#69356 Integer-overflow
        
        Change-Id: I5ce3b5858306dbc0f7bd8258dc306dc1195a8ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168335
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-06-01  Eike Rathke  <erack@redhat.com>  [a523e9bf2d54fc84583c9da05af592297b055e40]

        Resolves: tdf#158789 operate on query array if no extra array or range given
        
        Also push error and bail out early if there was an error, or more
        important pResultMatrix is nullptr.
        
        Change-Id: I1094ed9d14795ea1bc3f4ff61d687cc28d0b94fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168300
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9ffaeaf7b2dce382474dbbb61819a2c039c0bf6]

        loplugin:ostr in sc/../view
        
        Change-Id: I24e84cd42e3f55761fbc1fb8ae9b2cf3fc7bd385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [97265258cc102def076f057857cef3022325ab8f]

        Advanced Diagram support: Load fill DiagramModel
        
        In the case the input file does have a graphical
        representation of the Diagram as image file, the
        DiagramModel was not fully loaded. For being able
        to edit the Diagram in the future it is necessary
        to re-create the geometry, thus a full model is
        needed.
        
        Needed to know at recreation if this is the first
        time the geometry gets self-created using the
        layout/creation mechanism to decide if to apply
        the style or use the saved/reapplyable data from
        secure/restoreDataFromShapeToModelAfterDiagramImport
        mechanism, added that.
        
        Change-Id: Icb7590306ab59728e83b800b8637333e0d372de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168223
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-06-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9265dd87222763453784938553f9be41277acd6a]

        Update git submodules
        
        * Update translations from branch 'master'
          to 113c6c3c2498ffc2f99f20c088367bca1fecc50b
          - add files for Sundanese (sun)
            
            Change-Id: Ic64f8f20a409024e8e0bf8d07aa644d7caa38bda
            
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I9e8399ac390552903a010f54802d722a2acf36f4
            
2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [832211d7c5803d38997dddff55632ae0e582f5fc]

        loplugin:ostr in sc/../docshell
        
        Change-Id: I181b23558eedd690492d804619a0f9345d1d532f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168308
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6302535030fc0e4853eb3793bb57a32e34a82ad3]

        loplugin:ostr in sw/../filter
        
        Change-Id: Ia1a96f966324e37cea55bd093f8fdbd9d9f99c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168330
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1868ec03260efd5d90db733ed5e9927f04d8961]

        Fix typo
        
        Change-Id: Ifaadd20fd08f1f1c2c74ba9e24f32d41b4ba81b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168331
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-06-01  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [6c583b38bc96b397f1a742127ea7ac99cadd024f]

        tdf#159897 docx import: fix ScreenTip of hyperlink
        
        Note: if the ScreenTip contains double quote marks, the link will be
        broken after the import
        
        Change-Id: I4ed3e4e9e87335407e01d50cc5c440d04598a33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168105
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [1291edd7ed369ee97177cab2910f2396302ebacf]

        tdf#144208 speedup doc with lots of redline(2)
        
        use iterators to avoid indexing and cost of repeatedly calling size(),
        shaves 1-2% off load time
        
        Change-Id: Id6e39beabeb47cae479154e0636e504b7f7ba2fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168306
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-01  Jeff Huang  <jeff.huang@ossii.com.tw>  [a3f537e13ee64c5bf3155864035c1591e7099101]

        tdf#161288 Traditional Chinese minus character is U+8CA0(負), not U+5069(偩)
        
        Co-authored-by: Firefly <firefly@ossii.com.tw>
        Change-Id: I22fe8b31aa59d08f982d2b4586471f4cc13653b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168089
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-06-01  Julien Nabet  <serval2412@yahoo.fr>  [fbe57382eef1138999f63e01b6152d4d05749807]

        Update git submodules
        
        * Update translations from branch 'master'
          to 833ed440d8cae32801d2e6a4b6e45d8210e99251
          - Fix "\n" mismatch in Slovenian translation
            
            Change-Id: I4fc43467fa7d68113583d426b019a4dae37728d1
            Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/168313
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec49191e58df2f5cb37e2608f3262e9604385fb0]

        loplugin:ostr in sc/../drawfunc
        
        Change-Id: I5191883a86a004f2e7c283dc0e0e77de2f7eda04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168281
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a06946271e7139352501e0840256402ac43f4c65]

        tdf#144208 speedup doc with lots of redline
        
        This takes my load time from 48s to 6s.
        
        The specific problem site is DocumentRedlineManager::SplitRedline,
        which is hard hit when loading DOCX files.
        Speed it up by caching the redline with the max end pos, which works
        because most of the time we are trying to split around a position
        which is the past of the end of the existing redlines.
        
        Possibly a better solution would be not to call SplitRedline
        at all, but propogating that information around is tricky given
        that we are crossing module boundaries here, calling from xmloff/
        into sw/
        
        Change-Id: Ia8e5703c1cc9e861e27a24c24f207f12e594ff44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167892
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-06-01  Noel Grandin  <noelgrandin@collabora.co.uk>  [302a221856809e2b046cb9fb1675bfff4d86a37d]

        tdf#161198 tdf#161322 fix selection overlays
        
        revert
            commit 7b1405689d4246e0e37e8759f03e1962af964cec
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 19 22:56:04 2024 +0200
            reduce the number of drawing primitives we create in
            OverlaySelection
        
        Change-Id: I868540aadb3a75582990ae4491807991617215b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168253
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-06-01  Heiko Tietze  <tietze.heiko@gmail.com>  [0a0d3d1f8a34e0b8542c71fe9c3bd3b75d974e7c]

        Resolves tdf#152923 - Make column header outstanding from background
        
        * Background color made darker/lighter depending on system settings
        * Separator lines with less contrast (ShadowColor instead of DarkShadowColor)
        * Extra line for selection removed as it extends the actual header
        * Todo: Vertical header starts at a few pixels distance to the edge (patchset 4 fails)
        
        Change-Id: If3c47b77ad0bca2db1c25ec46b488a2e338b8133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168225
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-06-01  Justin Luth  <jluth@mail.com>  [51f2f5ca45a9f9aade210ca674b167a9a11f87bf]

        tdf#97618 DOCX import: VML shape: fix missing text wrap #2
        
        The default value is to wrap text.
        
        mso-wrap-style: Specifies the wrapping mode for text
        in shapes in WordprocessingML documents. *Default is square*.
        
        Allowed values are:
           square - Wraps text inside the shape in a square.
           none - Text does not wrap.
        
        Change-Id: Ia5f6d635d6d2ac4c8e28b27a993dcbff8bab249d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168301
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [a20d5df3f9546947e23cbe6f5718049a1a61a823]

        sc: use SAL_RET_MAYBENULL in GetTabViewShell()
        
        Change-Id: Icbe2b301aea66a74baf100609f726fc0a6e824c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168292
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d9053bb778d3d230f2f3cf946c4823caa2e0f385]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 692e37447c9af746a7c34bfe46a1b78e0b15322d
          - Unmute translation on func_weeknum.xhp
            
            + refactor
            
            Change-Id: Ibba4e057864ccb6339bf2d8a5d93899bd0744380
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168299
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-31  Miklos Vajna  <vmiklos@collabora.com>  [8f3e11dc9a4b3fd9ad1985d88b241df7bcb66fec]

        tdf#160984 sw continuous endnotes: hide not functional UI in this mode
        
        Previous commits bug have fixed cases where opening a Word document
        rendered a different foot/endnote separator than expected for Word. The
        followings were modified:
        
        - distance between body text and separator, between separator and first
          note
        
        - the vertical position of the line
        
        - the length of the line
        
        Now ODT files keep the original feature set and Word files look as
        expected, but a couple of UI controls are ignored by the layout, hide
        these as they intentionally don't do anything while we're in Word compat
        mode.
        
        Change-Id: I72a3dde637d3e224038886a79550fa069253a4f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168295
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-31  Dione Maddern  <dionemaddern@gmail.com>  [65b5569459ae19d2404864edb8fa68020ad699cc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3de7c68c52bfe0beadcd791092aaea420cb43a97
          - tdf#140811 Update help page for Bullets and Numbering Image tab
            
            In text/shared/01/06050000.xhp
            - Added variable tags to H1 so the page can easily be linked from other pages
            - Replaced link to text/simpress/01/bulletandposition.xhp with embedded text.
            - Moved index and HID bookmarks from text/simpress/01/bulletandposition.xhp so that searches and pressing F1 in the menu bar will open this page. Strictly speaking, Draw and Impress use a different dialog box, but pressing F1 opens this help page.
            
            In text/shared/01/06050400.xhp
            - Added index bookmarks to make the help page easier to fing
            - Added section tags so that content can be easily embedded in other pages
            - Removed the "Link Graphics" section because it no longer appears in the dialog
            - Added a section describing the "Add and Resize" feature.
            - Updated the "Related Links" section because the titles of linked articles have changed. Added a link to the "Bullets and Numbering" page.
            
            In text/shared/01/06050500.xhp
            - Added variable tags to H1 to make it easier to link from other articles
            
            In text/simpress/01/bulletandposition.xhp
            - Moved HID and index tags to text/shared/01/06050000.xhp
            - Updated howtoget section to reflect slight differences accessing the feature in Draw
            - Added section tags so that content can easily be embedded in other pages.
            - Removed the "Keep Ratio" feature because it does not appear in this dialog.
            - Hid the "Apply to Master" feature behind an application switch because it doesn't appear in Draw.
            
            Change-Id: Id645d31f1e5275ff4b2f8f0f30f3107e0e3f9d69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168201
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-31  László Németh  <nemeth@numbertext.org>  [014e5f559a9acf319af24c721dbe6b0bc3bc5882]

        tdf#161360 sw: fix cursor position deselecting image in table
        
        In tables, when the selected image was anchored as character
        at beginning of the table row, pressing Escape resulted completely
        lost text cursor (after a short blinking, not visible, missing
        typing etc.) or – in the case of floating tables – cursor in
        a bad position (after the table instead of before the image).
        
        Change-Id: Ib49211ec3531110fc8f5f65fb700318884519666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168289
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [5995f21774754d306ead2763e1bf4ef357f5a23b]

        Avoid race
        
        There are reports that RuntimeUID may be some unexpected value like
        1206137128392, in unclear cases. This is a blind shot at that.
        
        Change-Id: I724f082c361243beb4bd2ac14edf3176259f15d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168209
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-31  Martin Srebotnjak  <miles@filmsi.net>  [682d7d044ca2d7d6f8d2d48c164c99b3031fe82f]

        Update git submodules
        
        * Update translations from branch 'master'
          to d829869b1ed2c8917f1b6df400154e73270884cc
          - Updated Slovenian translation
            
            Change-Id: I375b96ff395205f50f4bc2fa1f9b76aa4fe813bf
            
2024-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ebb50b6d89dcbd04073830ec05c9df368a235786]

        partial revert to restore existence of Expander wrappers
        
        partial revert of:
        
        commit 8288d2e3061327fd91e241c0b514cd973e3fcea8
        Date:   Mon Nov 21 11:04:53 2022 +0200
        
            loplugin:unusedfields
        
        because the existence of the welded expander wrappers matters
        for some of the backends to fully work
        
        Change-Id: Ie75e27329a47f708514466401e24eae6ddcd4c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168208
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [72b5eb77aa3388dc0832ca4f94a8122bb9f66694]

        Fix typos
        
        Change-Id: I1abaec8ec9a678d31e62bb685c39e9bc9d406edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168291
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [847781ea88cdb122e6f75199d9238e6d76a75f18]

        Fix typo
        
        Change-Id: I904fb00c7aa934b27d6e4435a2495607f18b3abf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168290
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-31  Miklos Vajna  <vmiklos@collabora.com>  [6450159e0e7c5fac9c998087e99f3fec602ff84d]

        tdf#160984 sw continuous endnotes: fix the endnote continuation separator len
        
        See e.g.
        <https://bug-attachments.documentfoundation.org/attachment.cgi?id=194455>,
        one remaining difference for the Word vs Writer note separator is the
        length of the endnote continuation separator: it's body frame width in
        Word, shorter in Writer.
        
        Seems this is specific to the endnote continuation separator, i.e.
        normal endnote separator, footnote separator and footnote continuation
        separator is not affected. Additionally, it's really footnote vs
        endnote: if you put footnotes to the end of the document in Word, it
        still doesn't make the separator longer.
        
        Fix the problem by extending SwFootnoteContFrame::PaintLine() to handle
        this: if in Word compat mode, first note frame is a follow endnote
        frame, then paint the longer separator.
        
        The usual render test way via SfxObjectShell::GetPreviewMetaFile() only
        works with 1st pages and we want to assert the 2nd page here, so go via
        DocumentToGraphicRenderer, similar to how
        EPUBExportFilter::CreateMetafiles() does it.
        
        Change-Id: Ia0ba1138070f1a68f62ea6f5a6a85fbe0f76d482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168263
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [94160cabee03ad1ea96bc28060d52f7b357df947]

        LOK: Disable map mode in DrawViewShell's ctor
        
        This allows to use views other than normal and master (these two use the same
        shell, and are initialized in SdXImpressDocument::initializeForTiledRendering).
        
        Change-Id: I52f3ce46738f9feca1a16d008efca76cb478dceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168286
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [efe386b01668c9a67224857773849916d44d56cd]

        loplugin:ostr in sc/../miscdlgs
        
        Change-Id: I9cc24ed6692d9495e6ace3ccacbbe488ef82eea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168282
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-31  Eike Rathke  <erack@redhat.com>  [b3f6d4f0d380b26fb88ff586a09b4525ed6585b9]

        Related: tdf#161301 strip single stray leading "[$]" garbage from formatCode
        
        Which is the case if the actual format code is in an
        x16r2:formatCode16 attribute that isn't handled yet.
        
        Change-Id: Id35e774f8ccb167af2a46a8cc0f7611da76d708c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168232
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [48190a8f3783135c65538977cd38f34ba733f071]

        Make sure updates dir exists when writing updating.log
        
        Change-Id: Ib652fedde970d01b701ad4b61e75028cd43974f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168258
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-31  Justin Luth  <jluth@mail.com>  [068befc95ab8d7c368e76f08447827dbdea21014]

        tdf#114398 ods export: output <text:line-break/> when CELLTYPE_EDIT
        
        assume regression since LO 4.2
        based on LO 7.5 a7589f621fcbe6305335730d2dd86b9230a18594
        for tdf#103829.
        
        Change-Id: I12726697565722e132941875fb32cad95c8f9768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168270
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-31  Justin Luth  <jluth@mail.com>  [71c49057deb1a696e4b0ce9d2091aaa28572b57a]

        tdf#149258 sw ms export: no separator for NONE numbering level
        
        This is to benefit ODT->DOCX.
        
        LO does not show the separators specified after a numbering level
        that has no numbering type (since LO 7.2.5).
        However, MSO does show any specified separators.
        So export this the way that LO sees it.
        
        Note that in the very odd case where an MSO user actually wanted
        these separators to be visible, LO fails to show them,
        and thus this will end up exporting as "data loss". How sad.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf156105_percentSuffix
        
        Change-Id: I2c084de319ef4b1e77b6f377708c71a62dcc5910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167898
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [64bf123ebae9873758c30cb41aaf3a1098c5e678]

        update credits
        
        Change-Id: I8f3b3bbed98c026302400be448d621ce530d5e79

2024-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [691c585637951ddad5ca9b497bb7330b147630ed]

        wsl-as-helper: enable gb_COLOR by default when using git-bash
        
        Change-Id: I3c24e8b3049e9bd669952ac3b24678bb3c5e1014

2024-05-31  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c64c710d045333a8ae5f6fc6b74c674a6bcbc6f1]

        Set strings as translatable
        
        ...in the quick find deck on the sidebar of Writer
        
        Change-Id: I9661741c04b99c710f458f7bb43e5455363627a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167659
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c00014019e6d33bfb4729c563062db1645c48e9d]

        tdf#161292: Fix create-partial-info for newly added files
        
        084c64982ef6187292fd73e6deaa4448e0b6f3de "Create MAR updates from msi rather
        than from archive" had patched make_add_instruction (in
        workdir/UnpackedTarball/onlineupdate/tools/update-packagin/common.sh) to
        unconditionally use add-if (with the file itself as test file) rather than plain
        add (because we can't reuse Mozilla's extension logic there to determine
        optional installation parts), and it noted in its commit message that "addition
        of files will cause a MAR update to miss them".
        
        Which turned out to be a problem with
        <https://update-mar.libreoffice.org/24.2.2.2/LibreOffice_24.2.2.2_Windows_X86_64_d56cc158d8a96260b836f100ef4b4ef25d6f1a01_from_bf759d854b5ab45b6ef0bfd22e51c6dc4fb8b882_partial.mar>,
        updating from 24.2.2.1 with instdir/program/python-core-3.8.18/ to 24.2.2.2 with
        instdir/program/python-core-3.8.19/:  All the files in python-core-3.8.19 were
        recorded as add-if testing on themselves, so were never added.
        
        So a better approach is, for newly added files to make them add (so they get
        added unconditionally, even if they are part of some optional component that
        happens to not be installed; this hopefully won't cause further issues) instead
        of add-if.  (Existing files that are added instead of patched still use add-if,
        though.)  This does not address the create-update-info target for full mar
        updates (which is not used currently?), just the create-partial-info target.
        
        (The existing calls to make_add_instruction in the upstream Mozilla code already
        have a seemingly rotten mix of two-argument calls and calls with three arguments
        where the third argument is ignored, and would check for a fourth "forced"
        argument but which is never passed in.  So avoid extending that mess further,
        and just replace this never-use-add-if call to make_add_instruction directly
        with that function's (accordingly tweaked) body.)
        
        Change-Id: Ib596f3aa72c3ab9f896b20f7d623bc574eb15fd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168285
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-31  Michael Weghorn  <m.weghorn@posteo.de>  [eff8497fa2ab9c0e4889e1cf38fdeff1b2ec195a]

        kf5be: Make fromQStringToOUString work for Qt 6
        
        Sync `fromQStringToOUString` with the `toOUString`
        implementation in `vcl/inc/qt5/QtTools.hxx`, which
        makes it work with Qt 6 as well.
        
        Without this, building this with a planned upcoming
        change that introduces a KF 6 desktop backend would fail
        like this:
        
            In file included from /home/user/development/git/libreoffice/shell/source/backends/kf6be/kfaccess.cxx:10:
            /home/user/development/git/libreoffice/shell/source/backends/kf6be/../kf5be/kfaccess.cxx:53:60: error: non-constant-expression cannot be narrowed from type 'qsizetype' (aka 'long long') to 'sal_Int32' (aka 'int') in initializer list [-Wc++11-narrowing]
               53 |     return { reinterpret_cast<char16_t const*>(s.utf16()), s.size() };
                  |                                                            ^~~~~~~~
            /home/user/development/git/libreoffice/shell/source/backends/kf6be/../kf5be/kfaccess.cxx:53:60: note: insert an explicit cast to silence this issue
               53 |     return { reinterpret_cast<char16_t const*>(s.utf16()), s.size() };
                  |                                                            ^~~~~~~~
                  |                                                            static_cast<sal_Int32>( )
        
        Change-Id: Ic2b1ddcaa290379187db69b33e4a700c148650e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168275
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-31  Michael Weghorn  <m.weghorn@posteo.de>  [9214b80fe67f6771a4120b6eeaddd85cea1d6f2a]

        kf: Drop "5" from KF 5 desktop backend file names
        
        ... and namespace.
        
        This is in preparation of implementing a KF 6
        backend that will reuse most of the code.
        
        Change-Id: I0c0f499ff57dd18e7e0bc7dd838acfeffa30d88c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168274
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-31  Michael Weghorn  <m.weghorn@posteo.de>  [cc733542fecc2e63bc794559dfa6320d788e9254]

        tdf#143148 kf: Use pragma once in kf5access.hxx
        
        Change-Id: If2d8d2dc13088ba2b2972198b8386be55401871d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168273
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [049dd8300b1b5f97612e18ec2ef893645a38b9fa]

        sc: Reduce number of calls to GetMarkedObjectList()
        
        From 152 to 102
        
        Change-Id: I43907965e5b1ef0819495d6a1e7b18597a1b5947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168283
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-31  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [68260d7525aeaf38ac09ca9920fa1fa76dc8018a]

        tdf#99528 Move through tabs with Ctrl-PageUp/Down keys
        
        As required by test_tab_navigation unit test
        
        Change-Id: Ia77aa57de420574922b4fd4a0759f18c2dc778f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166856
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-31  Miklos Vajna  <vmiklos@collabora.com>  [e00479404af5058b982c447e485af995d552e372]

        tdf#161318 sw clearing break: fix this at section end
        
        Regression from commit 19bca24486315cc35f873486e6a2dd18394d0614
        (tdf#126287: docx import: use defered linebreak, 2022-02-07), the bugdoc
        has a single paragraph in the first section, containing a clearing
        break, which is lost. This leads to overlapping text as the text is
        shifted up.
        
        Seems the intention was to avoid a line break at the very end of the
        document, as that can lead to an empty page with "next page" section
        breaks, with non-clearing line breaks.
        
        Fix the problem by only doing this for non-clearing line breaks: that
        keeps the old use-case working, but the new, clearing line break then
        shifts down the text, so no text overlap happens.
        
        Switching from appendTextPortion() to HandleLineBreak() helps because
        HandleLineBreak() does exactly appendTextPortion("\n") in the
        non-clearing case, but knows about the stream stack's line break clear
        status.
        
        Change-Id: I38868eeeac55e20e86b668e9baf7e0d6a4976608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168278
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-31  Heiko Tietze  <tietze.heiko@gmail.com>  [0764a44e185d7b940f442cc054f5f1afd8c5cc64]

        Resolves tdf#161082 - Set focus on topmost item (Printer)
        
        Change-Id: Ib5b8f2587efaa683a28f1d8298eb9bcba2539705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168280
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [de4708fcafbdd99ee0c585f980edcc3bb230c105]

        Avoid --enable-compiler-plugins=debug loplugin:overrideparam TODO warning
        
        > cui/source/factory/dlgfact.hxx:531:116: fatal error: TODO: Unexpected 'IdenticalDefaultArgumentsResult::Maybe' [loplugin:overrideparam]
        >   531 |                                             const OUString& rName, const OUString& rDesc, const OUString& rTitle = u""_ustr) override;
        >       |                                                                                                                    ^~~~~~~~
        > include/svx/svxdlg.hxx:380:116: note: TODO: second argument is here [loplugin:overrideparam]
        >   380 |                                             const OUString& rName, const OUString& rDesc, const OUString& rTitle = u""_ustr ) = 0;
        >       |                                                                                                                    ^~~~~~~~
        > MaterializeTemporaryExpr 0x1732504d0 'const OUString':'const class rtl::OUString' lvalue
        > `-ImplicitCastExpr 0x1732504b8 'const OUString':'const class rtl::OUString' <NoOp>
        >   `-CXXBindTemporaryExpr 0x173250498 'OUString':'class rtl::OUString' (CXXTemporary 0x173250498)
        >     `-UserDefinedLiteral 0x173250468 'OUString':'class rtl::OUString'
        >       `-ImplicitCastExpr 0x173250450 'OUString (*)(void)' <FunctionToPointerDecay>
        >         `-DeclRefExpr 0x173250430 'OUString (void)' lvalue Function 0x14a24f188 'operator""_ustr' 'OUString (void)'
        > MaterializeTemporaryExpr 0x14a250658 'const OUString':'const class rtl::OUString' lvalue
        > `-ImplicitCastExpr 0x14a250640 'const OUString':'const class rtl::OUString' <NoOp>
        >   `-CXXBindTemporaryExpr 0x14a250620 'OUString':'class rtl::OUString' (CXXTemporary 0x14a250620)
        >     `-UserDefinedLiteral 0x14a2505f0 'OUString':'class rtl::OUString'
        >       `-ImplicitCastExpr 0x14a2505d8 'OUString (*)(void)' <FunctionToPointerDecay>
        >         `-DeclRefExpr 0x14a24f298 'OUString (void)' lvalue Function 0x14a24f188 'operator""_ustr' 'OUString (void)'
        
        (Unfortunately, there appears to be no way to get at the actual string literal
        content here to check it for equality, so keep returning Maybe for now.)
        
        Change-Id: I4beac3c7f17a689488a41efe5da0554af7beff65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168246
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [be2638603b85974cc452e3d453f4adb9d9f5d97f]

        tdf#161354: drop incorrect assertion
        
        Change-Id: I49eb5c52ef843f4615f1cf1549cd59c365e5ce1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168277
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-31  Laurent Balland  <laurent.balland@mailo.fr>  [15160b7af066579b7600ecf6b28c2099d2553563]

        tdf#160564 Treat xlink:type for embedded chart
        
        xlink:type is a valid attribute for chart:chart according to ODF [1]
        As this attribute is not yet used, this change just avoids the warning message
        
        [1] https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part3-schema/OpenDocument-v1.3-os-part3-schema.html#__RefHeading__1419428_253892949
        
        Change-Id: I836c8ff4a284bafa8e0c8049ae6ae60c9fbe7a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165853
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2024-05-31  Patrick Luby  <guibmacdev@gmail.com>  [29ef1d698c7f8bb38c0af21215a24577ced656ff]

        Fix some macOS memory leaks due to overretaining Objective-C objects
        
        Change-Id: If826476ad6c6692d22519f4eb0fb45621240fdbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168271
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c22ad4f8cbefa68a675cc4eec3045bd9519b5342]

        unique_ptr->optional in SwLinguIter
        
        Change-Id: Ie0939645ca7e3619ed6c5a58f80d991652027ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168259
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f188026e9163aec6317160059c4b0e98290a4de2]

        loplugin:indentation (macOS)
        
        Change-Id: I989ad1a8d8100a9bbd60d2bbd8aa1c206860d966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168243
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-31  László Németh  <nemeth@numbertext.org>  [2f7bb481c57458a38769ebd961f07cc45767f1f7]

        tdf#161332 sw: fix missing selection of floating table
        
        A fixed-height cell can contain a bigger image, which is
        cropped by cell boundaries. In this case, it was not
        possible to select the floating table by clicking on its
        right border.
        
        Note: fix also tests of tdf#44773 and tdf#160836 related
        to DPI-dependent platforms, see tdf#160992.
        
        Follow-up to commit 30de13743f144aced83bc43d310592f82788c910
        "tdf#160836 sw: resize rows at images cropped by row height"
        and commit f3b899655018397e71300dbb32cdf4f82940a68b
        "tdf#160842 sw: select cell content instead of cropped part of image".
        
        Change-Id: I22c3e34f4c8147736c29b62722f7fc43c862ba48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168237
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [ae92ffe8f058a86b35318517e6136701f1886d74]

        Drop direct uses of SwRectFn; use SwRectFnSet instead
        
        Change-Id: I4eadf4fc132ef838581dcd6afdc9540195e80151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168268
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [c60ad7e0fbf3cc86af167f5e98b38c25620ada7e]

        tdf#160958: merge hidden section's follows; move first-on-page section back
        
        Change-Id: I6bd6707089dcea58d5df4bef63aa769769d97ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168235
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [5da4acd4818741c3b68be211bd7a21e4c080ed4d]

        sd: Reduce number of calls to GetMarkedObjectList()
        
        From 211 to 129
        
        Change-Id: I2ccb4261f5f842e7f1514bc0c8eab2591ead173e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168256
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac3f2bd367743cc28fe4728279c65125c6f30e7a]

        svx: Reduce number of calls to GetMarkedObjectList()
        
        from 447 to 208
        
        Change-Id: I7b289b61a4ec416b9809f1433bb7a824ef488cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168227
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-31  Michael Weghorn  <m.weghorn@posteo.de>  [f04e711ea34ad3ad5ee642047be5d56a18fa0b53]

        tdf#145735 qt avmedia: Implement frame grabber
        
        Add a new `QtFrameGrabber` class that implements
        the `css::media::XFrameGrabber` interface and
        return an instance of it in
        `QtPlayer::createFrameGrabber`.
        
        As there seems to be no direct way to retrieve
        the image/frame of a video at a certain point
        in time, create a separate `QMediaPlayer` instance
        for the `QtFrameGrabber`, set a video sink, connect
        to its `&QVideoSink::videoFrameChanged` signal and
        start playing the video (and stop it again once the
        first frame has been received) in order to retrieve
        a corresponding frame.
        
        From that `QVideoFrame`, a `QImage` can be retrieved
        that can then be converted to an `XGraphic`.
        
        With this in place, a frame from the actual video
        is now displaced in Impress in non-presentation
        mode instead of just a generic "video icon" placeholder
        when opening a presentation containing a video,
        (e.g. attachment 145517 from tdf#120452) when the
        qt6 VCL plugin is in use.
        
        Change-Id: I3bba3c0fb62a219ac632ceed03ec17f9078f18d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-31  Heiko Tietze  <tietze.heiko@gmail.com>  [2269b418f7af598ff8194acb9929c8bd6c4baeb1]

        Resolves tdf#160324 - Larger hitarea for column header
        
        Finalizes patch I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5
        
        Change-Id: Iff5cd4f6252e42cf8fad0aa2f37f70db0b8a15ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168210
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-05-31  Oliver Specht  <oliver.specht@cib.de>  [0d3bb65620de64709d45c6e9b5591381a7da8dcf]

        tdf#159695 Disable Data Validation in protected sheets
        
        While the menu entry Data/Validity was disabled the context
        menu entry Data Validation was still enabled. This is fixed now.
        
        Change-Id: Ifa183f79ed85e5c46e73b4fa3e282c48e9de6c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167964
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9e1ada2c6b85e9c6413084840939ca835ec84964]

        loplugin:fakebool
        
        Change-Id: Ifbb27bf3486a88621f5ca125845e603f9e3925a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168245
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b8b7a0936d5860e56239d60b0b5073d983df32f7]

        loplugin:rangedforcopy
        
        Change-Id: I743695dde8928e1a742006518e7d6374087d5cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168244
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [faa421fbbef7761b29f639e1ebfaef940e99f604]

        Clean up using directives
        
        Change-Id: Iaf343b3dabec951e1fd2d998a11fca8f593afdb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168260
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [253bd05e95ae5093e61a4685a9d28f31edc6f585]

        Consolidate on a single Updater::log overload
        
        Change-Id: Id812788f30ac4a327d450255cfe19181c69ae81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168257
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-31  Weblate  <noreply@documentfoundation.org>  [858e9e48ac2439ddc1eebab14d76b493bed352ed]

        android-viewer translated using Weblate
        
        Georgian currently translated at 100.0% (116 of 116 strings)
        
        Change-Id: Iaf9193bd950b9bbc1cb25828fb6ee2af53ae158b
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 75.0% (87 of 116 strings)
        
        Change-Id: Idd317334a8a1e30f427fae91a38fa3300d0b9c5d
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 74.1% (86 of 116 strings)
        
        Change-Id: Iebd923daef4f9bc7693e15340e2d7f6d9eb21159
        Co-authored-by: Ekaterine Papava <papava.e@gtu.ge>
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ka/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168189
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-05-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [a78e908093d5c5e1b1f1401b0863c98b9b523ea9]

        tdf#161309 Update AutoFill overlay after changes
        
        Right after the cursor changes, the AutoFill overlay needs to be updated as well.
        
        Change-Id: Ie82d36a3ff60635225c794650aaba6e6bfbed5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168191
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [010551e5c1277ed32e8b279660c27490bace0767]

        sd: drop mpDocShell from DrawView
        
        ::sd::View already has mpDocSh
        
        Change-Id: I77af258115fad54aab6120f0dbbaa72a1faa71a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168261
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-30  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [7629d31f02a9fdbdf71295744c8869dee5cb4c54]

        tdf#161006 tdf#161049 tdf#161020 tdf#161047 fix VertTabCtrl size calculation
        
        * don't rely on initial dummy pages
        * so instead override GetOptimalSize() and do the math again
        * this assumes that all tab pages have been inserted at the time time
          GetOptimalSize() gets called for the last time
        
        Change-Id: I668347744d8ec9b94824f38cfc4b7ca00771a476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168081
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [782eda5992585a2a67f28d4453c7994f01b41ad9]

        loplugin:ostr in sd
        
        Change-Id: Icfd8d1eb21953f44fb7bfb62188247e911734bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c497cd602d543b48888212f79ba1ecf378e415fc]

        ubsan: runtime error: reference binding to null pointer of type 'const SwFrame'
        
        since:
        
        commit 124a988ea99096ea5080060c0d1a801528bd7a5c
        Date:   Wed May 22 11:57:57 2024 +0100
        
            create comment reply synchronously
        
        Change-Id: I62a6499c4dda7155e95bf8ffb344bfa81750844f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168247
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1962ec376759ef0043eb3c342fd113aa315d6bdc]

        external/libetonyek: Missing include (std::front_inserter)
        
        Change-Id: I4caeb6dd3d042b1a5ccbd3355c1b4ae192ab4925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168242
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ba6f0678eb8749decc5e31aa4dff9f4858e3ab1]

        loplugin:ostr in sc/../optdlg
        
        Change-Id: Ia441dd7c41cebec5fa40f9eb1e5b8fbb993b453a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [be568bf78939942153294727556a466e235e04d3]

        loplugin:ostr in sc/../StatisticsDialogs
        
        Change-Id: I739610e0b3b089fbb009cfca445b60d165694661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Noel Grandin  <noelgrandin@gmail.com>  [ebbb0674b4d98b1807c2fa94afaa3003111a9dc8]

        simplify
        
        Change-Id: I596765e0f0922e1b1ca4c185560f29fef31c4d06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168229
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Miklos Vajna  <vmiklos@collabora.com>  [304cc248f15d795bc9fe8b751b0d98841b8ff5d1]

        tdf#161318 sw clearing break: ignore wrap-through anchored objects
        
        Import the bugdoc: we expect just a single page for the 2 paragraphs,
        but the second paragraph goes to a 2nd page.
        
        What seems to happen since commit
        f86d1482bef285f90079b5130e410646db96cf58 (sw clearing breaks: add DOCX
        import, 2022-03-08) is that on one hand, SwTextFly::ForEach() ignores
        wrap-through shapes, but at the same time SwTextFly::GetMaxBottom() did
        not, and this lead to a loop: the first paragraph kept growing till the
        shape was shifted to page 2, but then the same first paragraph was
        reduced to just 2 lines, goto 1.
        
        Fix the problem by extending SwTextFly::GetMaxBottom() to also ignore
        wrap-though shapes: this is the intention, just clearing breaks were not
        tested with wrap-though wrap mode before.
        
        This is a reduced bugdoc, the original one even produced warnings like:
        warn:legacy.osl:12034:12034:sw/source/core/layout/flowfrm.cxx:2667: <SwFlowFrame::MoveBwd(..)> - layout loop control for layout action <Move Backward> applied!
        without the fix, and these are now gone.
        
        Change-Id: Iaf9849dbf8e1a8e5d625d3c19b99636247804cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168239
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-30  Hubert Figuière  <hub@collabora.com>  [f67e7fc5c71308e1866c78a1c48c9a6c070886cc]

        cool#9174 - Enable .uno:ChangeBezier
        
        This allow Convert to Curve in COOL
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: Id1aa0bc68238ac29221edb1c1ec7dda6e16ce103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168170
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit c5a7ff366fd9094c3ee1aba4c016b59c5635ea9b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168194
        Tested-by: Jenkins

2024-05-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc94f402853bbdce40165a00fe317910d6270562]

        'tagged' pdf export of spreadsheets doesn't perform well
        
        m_aStructure is appended to for every row and cell, so a spreadsheet
        with 20 cols and 100,000 rows is many seconds slower to export in 24.8
        than 24.4
        
        since:
        
        commit b3c93b16d62e809500005edc749af4b8ad10162c
        Date:   Wed Jan 3 11:18:19 2024 +0100
        
            tdf#123870 sc: fix tagged content for accessible PDF export
        
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161581
        
        shave a sliver of work off.
        
        Change-Id: Ibeb817083fef3c9499326abe381527a31917303b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e303b3bba8caaefd3a7897a773deb69643967047]

        Implement attribute handling
        
        Change-Id: Ic30d2de582f952555ec672984da78a07a9319443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168224
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-30  Noel Grandin  <noelgrandin@gmail.com>  [91dbd5ca9fa2e689dcdbc5be4a60c8b65cbefc9f]

        avoid some dynamic_cast in SwTextFrame
        
        Change-Id: Ib73063871472727f27b552b1074d9d3872269b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168231
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Noel Grandin  <noelgrandin@gmail.com>  [50a27ef3fb3d7ceab2acacdccd4048cbedb866f1]

        reduce allocation of SwPaM
        
        Change-Id: I32536dbdb178a5f234cf64a8e7627a569986d942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168228
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Noel Grandin  <noelgrandin@gmail.com>  [ee4d61b08dabe1c184a49c7301a301ed0dcfc710]

        reduce heap allocation
        
        Change-Id: I9e99244cb6a5e79e8856eefceac16cacbca49a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168230
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [322a6ca8f912513f69747a68fe5497ee6b643293]

        AreObjectsMarked -> GetMarkedObjectList().GetMarkCount() != 0
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: Ib2eb7c88338e64744f886a338acca65f782f8170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168218
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d362fab91fb70fbe7026c1e96452fe06fa5736e]

        GetMarkedObjectByIndex -> GetMarkedObjectList().GetMark()->GetMarkedSdrObj()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: I57ab7d2d8edd98da5175bd1066dfab0fa2cc888e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168220
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1da1ef5766d1910b29d98b62a842ccfd7bacf08]

        svx: GetSdrPageViewOfMarkedByIndex() -> ...
        
        ... GetMarkedObjectList().GetMark(nNum)->GetPageView()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: If79125cc13fff7b8944c50202e0564de6bf8302e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168219
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-30  Justin Luth  <justin.luth@collabora.com>  [a2b00082114b443962715a671b8bbb17733d6453]

        tdf#131098 docx export: write fill property of graphic
        
        All these are round-tripping (at least at a basic level):
        - bitmap
        - hatch
        - solid color
        - transparency (unit test)
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf131098_imageFill
        
        No existing unit tests had an image with a fill.
        
        Change-Id: I745fa064db83bdb3bb7ec67eef1ae803f3930a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168134
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-30  Justin Luth  <justin.luth@collabora.com>  [2862f1989591f4666ed0f7b994c80a0d0fd8ae52]

        tdf#131098 oox import: apply fill properties to graphic
        
        The fill properties picked up by oox import
        were not being transferred to the final graphic.
        
        For some reason, the shape didn't import at all
        if I copied over the Fill*Name properties.
        
        All these are importing (at least at a basic level):
        - bitmap
        - hatch
        - solid color
        - transparency (unit test)
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf131098_imageFill
        
        Change-Id: Ia891db8059c33132a75bef2c4922205315b7ecaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168127
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-30  Jim Raykowski  <raykowj@gmail.com>  [24c28600430668c0bef6c24679a2fd0279d6253f]

        SwNavigator: simplify table delete
        
        Change-Id: Ic26712972e3465eba10dbaba9cfce20365c5644a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168172
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-05-29  Stanislav Horacek  <stanislav.horacek@gmail.com>  [0d9da34ad098ef81b5fee7535c1eace2bd813b1e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8bfe0f3ed238264aa0afd0975eefaec525b8da1c
          - initial value of SEQUENCE is in upper-left corner
            
            Change-Id: Ia2530dddce0c25a0b9920f11a64882a5900ebc37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168233
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-29  László Németh  <nemeth@numbertext.org>  [dece7d80c31c3c489859200bc93d9c948a535cbf]

        tdf#161261 sw: fix lost size of image resized in fixed-height cell
        
        A fixed-height cell can contain a bigger image, which is cropped by
        cell boundaries. It was not possible to resize this image with a simple drag & drop, because its size changed to the cell size immediately.
        Now it's possible, like MSO does.
        
        Follow-up to commit 30de13743f144aced83bc43d310592f82788c910
        "tdf#160836 sw: resize rows at images cropped by row height".
        
        Change-Id: I6b4e911432e784a96d393ee225ce69a1f2986d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168186
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2024-05-29  Miklos Vajna  <vmiklos@collabora.com>  [566c7017a84e3d573de85a6d986b81d3f59de0fa]

        tdf#160984 sw continuous endnotes: DOCX: export of <w:endnotePr> pos == sectEnd
        
        In case a DOCX file is re-exported to Word and it collected endnotes at
        section end, this setting was lost on save.
        
        The relevant markup seems to be <w:endnotePr> -> <w:pos
        w:val="sectEnd"/>, though that's a per-section setting in Writer, and is
        a per-doc setting in Word.
        
        Fix the problem by doing it similar to
        DocxExport::WriteDocumentBackgroundFill(), which takes the first page
        style in a similar case; here we take the first section format.
        
        This is meant to be good enough for the DOCX editing case, where we know
        all sections have the same endnote position properties anyway.
        
        Change-Id: I95508296e31c9be34196bdc0da2177101647abf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168187
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-29  Miklos Vajna  <vmiklos@collabora.com>  [ff0cb77a6c9fec7127c26f63a420e877ac4f852e]

        lok: document some guidelines on how to not end up with too many callbacks
        
        In general, the existing command dispatch, command value getter &
        command state callback is meant to be enough for most needs.
        
        Change-Id: Ibba5455b461a8eac052f17ac5e824ddea42755f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168178
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [941d03968cc12a6f7badc2641decd91dbd8f0244]

        simplify and reduce allocation in SwRedlineTable::getTextOfArea
        
        Change-Id: Iea119c61aef1c5459c8c9d00c6e1c7de93ec29c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-29  Dione Maddern  <dionemaddern@gmail.com>  [a4b95c4a15d6b7eccc7a3116183cb8d9dfb3b209]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7679f04728767fc2d89c853ded5f751688c2390e
          - tdf#161319 Fix mismatched H1 and Title in Cell Reference Help
            
            Update Title and H1 so that they match in
            -  text/scalc/guide/cellreferences.xhp
            -  text/scalc/guide/cellreferences_url.xhp
            
            Change-Id: I590a8222150a74c28d726801f0acaaace487154f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168195
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-29  Dione Maddern  <dionemaddern@gmail.com>  [7cd7ab6c65074dd42e11b89bb7c1d6cbc05ab48d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b9cb0eb716e2d003ed4b5c2481d335c2eff180eb
          - Add missing content to help page for Shapes menu in Draw
            
            In AllLangHelp_sdraw.mk
            - Add new entries for 
              - text/sdraw/01/equalize_height.xhp
              - text/sdraw/01/equalize_width.xhp
            
              Create new page text/sdraw/01/equalize_height.xhp for Equalize Height menu option
            
              Create new page  text/sdraw/01/equalize_width.xhp for Equalize Width menu option
            
              In source/text/sdraw/01/consolidatetext.xhp
              - Change H1 from "Text Box Consolidation" to "Consolidate Text" to reflect the current menu option.
            
              In source/text/sdraw/main_shape.xhp
              - Added a HID bookmart so that F1 will open the correct help page for the Shape menu
              - Added embed links to content describing the options listed in the Shape menu
            
              In text/shared/02/01140000.xhp
              - Added section tags for each function described so that content can be easily embedded in other help pages.
            
              In text/shared/02/05090000.xhp
              - Added variable tags so the page can easily be linked from other help pages
            
              In text/shared/02/05110000.xhp
              - Added variable tags so the page can easily be linked from other help pages
            
              In text/shared/menu/insert_shape.xhp
              - Added appliction switch tags to display a different H1 for Draw
              - Added application switch tags and additional menu options for Draw
            
              In text/simpress/01/02150000.xhp
              - Added section, variable and link tags to allow the page to easily be linked from other pages
            
              In text/simpress/02/10120000.xhp
              - Added section, variable and link tags to allow the page to easily be linked from other pages
            
            Change-Id: I35f3cf6b8948527a333979606b871bd45c87761d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168069
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [da95e7ae392368ca414be5c62a08879221cb71e9]

        SortMarkedObjects() -> GetMarkedObjectList().ForceSort()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: Ia74949a47308f95607881a7d44c8c26404902745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168217
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [f527bc48fc5c8812f6bc22ce10d7131d64e096ef]

        GetDescriptionOfMarkedObjects() -> GetMarkedObjectList().GetMarkDescription()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: I2a2c87c2552cfc9002a9afc7d8eefb16a601b784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168216
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [e73c7982b7c374b1b28535883bd8898edad25e50]

        svx: GetDescriptionOfMarkedPoints() -> ...
        
        ... GetMarkedObjectList().GetPointMarkDescription()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: I5886fd20ffd9df115e12947f4dc7293c98b50bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168215
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab659f2020d5320c3b2655b2909a1bd808f388b7]

        svx: GetDescriptionOfMarkedGluePoints() -> ...
        
        ... GetMarkedObjectList().GetGluePointMarkDescription()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: I7eb9bd7cfdaa53b9afcae5bc05cc2c014e0ce1e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168214
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [12c76a4fa169ee2362e79ea19284ed132eac9084]

        GetMarkedObjectCount() -> GetMarkedObjectList().GetMarkCount()
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: Id94f66545950f0fdf124ba7b985a5215a01d63fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168213
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [be76f48d602e5d0a1091973b2df7f20cb7f1a545]

        svx: TryToFindMarkedObject -> GetMarkedObjectList().FindObject
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: If05f5630e9413c162821370532f36598fc2e0341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168212
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c5485ef6826b5b2483df869056aac4499aff229]

        svx: GetSdrMarkByIndex -> GetMarkedObjectList().GetMark
        
        In order to reduce number of calls to GetMarkedObjectList() later on
        
        Change-Id: Iec0ad9ed33329719116e39232f86d92dbd6e0da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168211
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-29  Pranam Lashkari  <lpranam@collabora.com>  [124a988ea99096ea5080060c0d1a801528bd7a5c]

        create comment reply synchronously
        
        so we can bundle the creation of the comment and the insertion
        of its "reply" characteristics together as a single Undo group.
        
        wrap the new combination with a single undo operation showing "Insert
        Comment" using Rewriter
        
        Change-Id: I5927fa5501da0c49cc1182c60e23be290b8c37c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168190
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [a764f661e0e1b94af128cc2290ee6510adad5ffd]

        tdf#161234 New design for the cell outline
        
        The change introduced by commit I9df98 made the cell outline a bit wider than the actual cell. However, that change did not play well with higher zoom levels because:
        1) The AutoFill handle disconnected from the cell outline
        2) The distance between the outline and the cell was too far in at higher zoom levels
        
        This patch proposes an alternative design that deals with both issues.
        
        Change-Id: Ic3cd7d240f6cfc1af4a39409537e264912ef61b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167945
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [fc1e6a64bd0517a7e67f08860c29b44d030220eb]

        tdf#161202: lowers shouldn't move forward because of lack of space
        
        ... in hidden section. So make sure to set heights of lowers to zero, too.
        testOldComplexMergeTableInTable turned out to be a nice test for this.
        
        Change-Id: I334aaaf2becf0ac1ff61faed2e5f697f344c78d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168151
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [981542c1d218ae7ecf30431555560aed152f8ab1]

        Clean up gcc3_wasm bridge_noopt_objects
        
        There appears to be no good reason that cpp2uno.cxx and uno2cpp.cxx are noopt
        (presumably that was just cargo-culted from another platform?), and except.cxx
        appears to be completely unused anyway.
        
        Change-Id: Ic5f4142308a56b798dad61e9ec589046cad2ae13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168182
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4ca7aa44ad9856c2e5753e749dc031f8fec6a3f]

        simplify and reduce allocation in SwRedlineTable
        
        Change-Id: Ib8b031f0d4f12c52c64e699b7aef516b59c16945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [5edbc4fd99db9fa568143aa4fa15b29de4bcc48b]

        loplugin:ostr in sw/../writerfilter
        
        Change-Id: Ib3fe74f1522f3c0a2b203e49b98c10cc825160a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167737
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-29  Noel Grandin  <noelgrandin@gmail.com>  [2be07e3c42b2c59a75f6ebb90e6f806c369483cb]

        avoid dynamic_cast in SwCursorShell
        
        Change-Id: Ic66c427f5096aea53d6634874d98620dd91744b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168165
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-29  Noel Grandin  <noelgrandin@gmail.com>  [3a604beae75a1157e9bb4cf620cc7ad4d007ab45]

        avoid dynamic_cast in SwTOXBase
        
        Change-Id: Iac8f502bf200f599d44f52504a3b70a1a21b370b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168164
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [73eed7cfe08624227214378c50e2f09c9a868ee3]

        Properly fix use of uninitialized value
        
        Following up on 66322c5f4a5465c74fa3ceefaa2f76e86a277c16 "Silence warning C4701:
        potentially uninitialized local variable" (which had apparently wrongly assumed
        that that MSVC warning was a false positive) and
        b1a6bd87b803f760f5bf0e2b7bc519b3b2fbfa4e "ofz: Use-of-uninitialized-value in
        ImplConvertUtf8ToUnicode", which had demonstrated that this was indeed a true
        positive, as per the comment at
        <https://gerrit.libreoffice.org/c/core/+/168079/2#message-8b941c986658cb41641c0a317937bd0d3574e0b9>
        "ofz: Use-of-uninitialized-value in ImplConvertUtf8ToUnicode", and which could
        also be observed with a local patch of
        
        > diff --git a/sal/textenc/tcvtutf8.cxx b/sal/textenc/tcvtutf8.cxx
        > index 05290cc204fd..319acd41c627 100644
        > --- a/sal/textenc/tcvtutf8.cxx
        > +++ b/sal/textenc/tcvtutf8.cxx
        > @@ -56,7 +56,7 @@ void ImplResetUtf8ToUnicodeContext(void * pContext)
        >  {
        >      if (pContext != nullptr)
        >      {
        > -        static_cast< ImplUtf8ToUnicodeContext * >(pContext)->nBytes = int();
        > +        static_cast< ImplUtf8ToUnicodeContext * >(pContext)->nBytes = 1234;
        >          static_cast< ImplUtf8ToUnicodeContext * >(pContext)->nShift = -1;
        >          static_cast< ImplUtf8ToUnicodeContext * >(pContext)->bCheckBom = true;
        >      }
        > @@ -74,7 +74,7 @@ sal_Size ImplConvertUtf8ToUnicode(
        >  {
        >      bool bJavaUtf8 = pData != nullptr;
        >      sal_uInt32 nUtf32 = 0;
        > -    int nBytes = int();
        > +    int nBytes = 1234;
        >      int nShift = -1;
        >      bool bCheckBom = true;
        >      sal_uInt32 nInfo = 0;
        > @@ -208,6 +208,7 @@ sal_Size ImplConvertUtf8ToUnicode(
        >          continue;
        >
        >      bad_input:
        > +        assert(nBytes != 1234);
        >          switch (sal::detail::textenc::handleBadInputTextToUnicodeConversion(
        >                      false, nBytes != 1, 0, nFlags, &pDestBufPtr, pDestBufEnd,
        >                      &nInfo))
        
        and seeing CppunitTest_sal_rtl CPPUNIT_TEST_NAME=Test::testInvalidUtf8 fail by
        hitting that assert.
        
        So initialize nBytes to 1 to make that bad_input scenario call
        handleBadInputTextToUnicodeConversion with a bMultiByte=false argument.
        
        Change-Id: Ib8a326d497071f4249169e9d4f5871f06cfccbdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168181
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-29  Noel Grandin  <noelgrandin@gmail.com>  [7449378435627e466e69c2becd07b17ad7d7ff9b]

        avoid dynamic_cast in SwTextNode
        
        Change-Id: Id7ee5e922b7e99d1f3bade3b94285283eb07ae68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168163
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [db94d1079a83eae9ac0c8d92f4547698d016daf8]

        Revert "tdf#161261 sw: fix lost size of image resized in fixed-height cell"
        
        This reverts commit 4da6f52f5fd164082fd42fc58fc7d31da567c924 plus follow-up
        24f65bf5940adb0aa3590443752110119e2bea5e "Fix typo".  It caused
        CppunitTest_sw_uiwriter6 to fail with
        
        > /sw/source/core/layout/flylay.cxx:1426:51: runtime error: downcast of address 0x606000c4b620 which does not point to an object of type 'const SwDrawContact'
        > 0x606000c4b620: note: object is of type 'SwFlyDrawContact'
        >  00 00 00 00  50 3d 2f b8 99 7f 00 00  c0 3d 2f b8 99 7f 00 00  00 00 00 00 00 00 00 00  d0 64 50 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwFlyDrawContact'
        >     #0 0x7f99ae257936 in CalcClipRect(SdrObject const*, SwRect&, bool) /sw/source/core/layout/flylay.cxx:1426:51
        >     #1 0x7f99ad5b2607 in SwDrawView::TakeDragLimit(SdrDragMode, tools::Rectangle&) const /sw/source/core/draw/dview.cxx:694:13
        >     #2 0x7f99c317c1a0 in SdrDragView::BegDragObj(Point const&, OutputDevice*, SdrHdl*, short, SdrDragMethod*) /svx/source/svdraw/svddrgv.cxx:199:21
        >     #3 0x7f99c18eef25 in E3dView::BegDragObj(Point const&, OutputDevice*, SdrHdl*, short, SdrDragMethod*) /svx/source/engine3d/view3d.cxx:1243:21
        >     #4 0x7f99adcfa821 in SwFEShell::BeginDrag(Point const*, bool) /sw/source/core/frmedt/feshview.cxx:741:20
        >     #5 0x7f99b3ea5ffd in SwWrtShell::BeginFrameDrag(Point const*, bool) /sw/source/uibase/wrtsh/select.cxx:761:20
        >     #6 0x7f99b27a8238 in SwWrtShell::Drag(Point const*, bool) /sw/source/uibase/inc/wrtsh.hxx:124:56
        >     #7 0x7f99b2742135 in SwEditWin::MouseMove(MouseEvent const&) /sw/source/uibase/docvw/edtwin.cxx:4489:25
        >     #8 0x7f99dcdc6f64 in testTdf161261::TestBody() /sw/qa/extras/uiwriter/uiwriter6.cxx:1613:14
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3185/>)
        
        Change-Id: Idf0c0c75d39a28671c852fc526549439892d0902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168177
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7175431a4b2154113c2c3c28f7ae8a8f14a84c7a]

        Implement exception catching
        
        (Without 22ce8ed05be37d676739a578b05cc5217109fd87 "Emscripten: Unconditional
        --enable-wasm-exceptions", this would have failed to link due to missing
        __cxa_current_exception_type and __cxa_get_globals.)
        
        Change-Id: If89a3c62e4d2ac24d68f867b2fd7a4cd813d5a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168176
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [405cf00e4818886b0d3053d03cfb2e3f3a5e8eb8]

        related tdf#160971 gtk3 a11y: Keep new combobox value
        
        Selecting a new value in an editable combobox using
        the gtk3 VCL plugin using the popup didn't work when
        that popup was opened using the keyboard, sample
        scenario:
        
        1) Start Writer
        2) Press F6 until the Formatting toolbar has focus
        3) Press Tab until the "Font Name" combobox has focus
        4) Press Alt+Down to open the combobox popup
        5) Press Down key a few times to select another font, e.g.
           "Carlito"
        6) Press Enter to confirm
        
        Rather than the newly selected font, the previously
        set one would still be set in the combobox.
        
        Selecting a new font using the popup would work however
        when clicking the combobox's button using the mouse
        instead of steps 1-4 above.
        
        The problem was that restoring focus was resulting
        in the newly selected value not getting saved.
        
        Backtrace for how the value already got properly saved
        for the case where the button was previously clicked
        using the mouse:
        
            1 weld::ComboBox::save_value weld.hxx 853 0x7f19a7af3f81
            2 FontNameBox::save_value ctrlbox.hxx 369 0x7f19a7b01f3d
            3 (anonymous namespace)::SvxFontNameBox_Base::statusChanged_Impl tbcontrl.cxx 3432 0x7f19a7ad95e0
            4 (anonymous namespace)::SvxFontNameToolBoxControl::statusChanged tbcontrl.cxx 3439 0x7f19a7ad8312
            5 SfxStatusDispatcher::sendStatusChanged(rtl::OUString const&, com::sun::star::frame::FeatureStateEvent const&)::$_0::operator()(com::sun::star::uno::Reference<com::sun::star::frame::XStatusListener> const&) const unoctitm.cxx 132 0x7f19a98ae241
            6 comphelper::OInterfaceContainerHelper4<com::sun::star::frame::XStatusListener>::forEach<SfxStatusDispatcher::sendStatusChanged(rtl::OUString const&, com::sun::star::frame::FeatureStateEvent const&)::$_0>(std::unique_lock<std::mutex>&, SfxStatusDispatcher::sendStatusChanged(rtl::OUString const&, com::sun::star::frame::FeatureStateEvent const&)::$_0 const&) const interfacecontainer4.hxx 304 0x7f19a98a4411
            7 SfxStatusDispatcher::sendStatusChanged unoctitm.cxx 129 0x7f19a98a42aa
            8 SfxDispatchController_Impl::sendStatusChanged unoctitm.cxx 802 0x7f19a98a907c
            9 SfxDispatchController_Impl::StateChanged unoctitm.cxx 885 0x7f19a98a987a
            10 SfxStateCache::SetState_Impl statcach.cxx 424 0x7f19a98308cc
            11 SfxStateCache::SetState statcach.cxx 328 0x7f19a98306f2
            12 SfxBindings::UpdateControllers_Impl bindings.cxx 1211 0x7f19a97aeffd
            13 SfxBindings::Update_Impl bindings.cxx 274 0x7f19a97ae5cf
            14 SfxBindings::Update bindings.cxx 353 0x7f19a97af682
            15 SfxDispatcher::Call_Impl dispatch.cxx 280 0x7f19a97c731c
            16 SfxDispatcher::Execute_ dispatch.cxx 753 0x7f19a97cbc4b
            17 SfxDispatcher::Execute dispatch.cxx 812 0x7f19a97cc02f
            18 SfxDispatchController_Impl::dispatch unoctitm.cxx 671 0x7f19a98a6673
            19 SfxOfficeDispatch::dispatch unoctitm.cxx 250 0x7f19a98a511a
            20 SfxToolBoxControl::Dispatch tbxitem.cxx 253 0x7f19a9df168f
            21 (anonymous namespace)::SvxFontNameBox_Base::Select tbcontrl.cxx 2007 0x7f19a7adb44a
            22 (anonymous namespace)::SvxFontNameBox_Base::SelectHdl tbcontrl.cxx 1962 0x7f19a7adafb4
            23 (anonymous namespace)::SvxFontNameBox_Base::LinkStubSelectHdl tbcontrl.cxx 1960 0x7f19a7adab9d
            24 Link<weld::ComboBox&, void>::Call link.hxx 111 0x7f199a19ddd8
            25 weld::ComboBox::signal_changed weld.hxx 731 0x7f199a19dd8c
            26 (anonymous namespace)::GtkInstanceComboBox::fire_signal_changed gtkinst.cxx 21229 0x7f199a0e1880
            27 (anonymous namespace)::GtkInstanceComboBox::handle_row_activated gtkinst.cxx 21891 0x7f199a0e17f9
            28 (anonymous namespace)::GtkInstanceComboBox::signalRowActivated gtkinst.cxx 21876 0x7f199a0dd299
            29 ?? 0x7f1999695931
            30 ?? 0x7f19a87b4939
            31 ?? 0x7f19a87ca33f
            32 g_signal_emit_valist 0x7f19a87cff06
            33 g_signal_emit 0x7f19a87cffc3
            34 ?? 0x7f199993384b
            35 ?? 0x7f1999697085
            36 ?? 0x7f19a87b4939
            37 ?? 0x7f19a87ca33f
            38 g_signal_emit_valist 0x7f19a87cff06
            39 g_signal_emit 0x7f19a87cffc3
            40 ?? 0x7f19997b317e
            41 g_cclosure_marshal_VOID__BOXEDv 0x7f19a87b7b76
            42 ?? 0x7f19a87b4939
            43 ?? 0x7f19a87ca33f
            44 g_signal_emit_valist 0x7f19a87cff06
            45 g_signal_emit 0x7f19a87cffc3
            46 ?? 0x7f19997b0213
            47 ?? 0x7f19997b1803
            48 ?? 0x7f19997b4a42
            49 gtk_event_controller_handle_event 0x7f1999779361
            50 ?? 0x7f19999488bd
            51 ?? 0x7f1999690db8
            52 ?? 0x7f19a87b4939
            53 ?? 0x7f19a87c9693
            54 g_signal_emit_valist 0x7f19a87cff06
            55 g_signal_emit 0x7f19a87cffc3
            56 ?? 0x7f199994a314
            57 ?? 0x7f19997fc84e
            58 gtk_main_do_event 0x7f19997fe4be
            59 ?? 0x7f199a7b1a79
            60 ?? 0x7f199a7e5586
            61 ?? 0x7f199ed1ce3f
            62 ?? 0x7f199ed1eec7
            63 g_main_context_iteration 0x7f199ed1f4e0
            64 GtkSalData::Yield gtkdata.cxx 405 0x7f199a08827f
            65 GtkInstance::DoYield gtkinst.cxx 427 0x7f199a08d6e3
            66 ImplYield svapp.cxx 384 0x7f19a47bf65c
            67 Application::Yield svapp.cxx 472 0x7f19a47bef6b
            68 Application::Execute svapp.cxx 359 0x7f19a47bed02
            69 desktop::Desktop::Main app.cxx 1652 0x7f19ad928434
            70 ImplSVMain svmain.cxx 229 0x7f19a47e226e
            71 SVMain svmain.cxx 261 0x7f19a47e4299
            72 soffice_main sofficemain.cxx 93 0x7f19ad9aca7c
            73 sal_main main.c 51 0x55cb2e25aa5d
            74 main main.c 49 0x55cb2e25aa37
        
        However, for the keyboard-only case, `GtkInstanceComboBox::m_bChangedByMenu`
        got reset to false in `set_active_including_mru` with this backtrace:
        
            1  (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru gtkinst.cxx     21976 0x7f199a0e812b
            2  (anonymous namespace)::GtkInstanceComboBox::set_active               gtkinst.cxx     22406 0x7f199a0de9dc
            3  FontNameBox::set_active_or_entry_text                                ctrlbox.cxx     897   0x7f19a64d904c
            4  (anonymous namespace)::SvxFontNameBox_Base::set_active_or_entry_text tbcontrl.cxx    1823  0x7f19a7ad983d
            5  (anonymous namespace)::SvxFontNameBox_Base::FocusOutHdl              tbcontrl.cxx    1872  0x7f19a7adb9e2
            6  (anonymous namespace)::SvxFontNameBox_Base::LinkStubFocusOutHdl      tbcontrl.cxx    1868  0x7f19a7adac5d
            7  Link<weld::Widget&, void>::Call                                      link.hxx        111   0x7f199a13b618
            8  (anonymous namespace)::GtkInstanceWidget::signal_focus_out           gtkinst.cxx     2630  0x7f199a0a1ef6
            9  (anonymous namespace)::GtkInstanceComboBox::signal_entry_focus_out   gtkinst.cxx     21427 0x7f199a0e83f6
            10 (anonymous namespace)::GtkInstanceComboBox::signalEntryFocusOut      gtkinst.cxx     21412 0x7f199a0dd525
            11 ??                                                                                         0x7f1999690caa
            12 g_closure_invoke                                                                           0x7f19a87b4730
            13 ??                                                                                         0x7f19a87c887c
            14 ??                                                                                         0x7f19a87c9ad1
            15 g_signal_emit_valist                                                                       0x7f19a87cff06
            16 g_signal_emit                                                                              0x7f19a87cffc3
            17 ??                                                                                         0x7f199994a314
            18 gtk_widget_send_focus_change                                                               0x7f199995c0ea
            19 ??                                                                                         0x7f199996153b
            20 ??                                                                                         0x7f1999961822
            21 g_closure_invoke                                                                           0x7f19a87b4730
            22 ??                                                                                         0x7f19a87c8f08
            23 ??                                                                                         0x7f19a87ca281
            24 g_signal_emit_valist                                                                       0x7f19a87cff06
            25 g_signal_emit                                                                              0x7f19a87cffc3
            26 ??                                                                                         0x7f19a87b4939
            27 ??                                                                                         0x7f19a87ca33f
            28 g_signal_emit_valist                                                                       0x7f19a87cff06
            29 g_signal_emit                                                                              0x7f19a87cffc3
            30 gtk_widget_grab_focus                                                                      0x7f199994e7fa
            31 (anonymous namespace)::GtkInstanceComboBox::menu_toggled             gtkinst.cxx     21320 0x7f199a0ea4b8
            32 (anonymous namespace)::GtkInstanceComboBox::signal_popup_toggled     gtkinst.cxx     21356 0x7f199a0de2e9
            33 (anonymous namespace)::GtkInstanceComboBox::signalPopupToggled       gtkinst.cxx     21236 0x7f199a0dd375
            34 g_closure_invoke                                                                           0x7f19a87b4730
            35 ??                                                                                         0x7f19a87c887c
            36 ??                                                                                         0x7f19a87ca281
            37 g_signal_emit_valist                                                                       0x7f19a87cff06
            38 g_signal_emit                                                                              0x7f19a87cffc3
            39 ??                                                                                         0x7f19998f7ac5
            40 ??                                                                                         0x7f19a87b4939
            41 ??                                                                                         0x7f19a87ca33f
            42 g_signal_emit_valist                                                                       0x7f19a87cff06
            43 g_signal_emit                                                                              0x7f19a87cffc3
            44 gtk_toggle_button_set_active                                                               0x7f19998f7868
            45 (anonymous namespace)::GtkInstanceComboBox::handle_row_activated     gtkinst.cxx     21890 0x7f199a0e17f0
            46 (anonymous namespace)::GtkInstanceComboBox::signalRowActivated       gtkinst.cxx     21876 0x7f199a0dd299
            47 ??                                                                                         0x7f1999695931
            48 ??                                                                                         0x7f19a87b4939
            49 ??                                                                                         0x7f19a87ca33f
            50 g_signal_emit_valist                                                                       0x7f19a87cff06
            51 g_signal_emit                                                                              0x7f19a87cffc3
            52 ??                                                                                         0x7f1999935562
            53 ??                                                                                         0x7f1999693eca
            54 g_closure_invoke                                                                           0x7f19a87b4730
            55 ??                                                                                         0x7f19a87c8f08
            56 g_signal_emitv                                                                             0x7f19a87cfcf2
            57 ??                                                                                         0x7f19996c773d
            58 ??                                                                                         0x7f19996c7bf8
            59 ??                                                                                         0x7f19996c7d80
            60 gtk_bindings_activate_event                                                                0x7f19996c922b
            61 ??                                                                                         0x7f1999936b18
            62 ??                                                                                         0x7f1999690db8
            63 ??                                                                                         0x7f19a87b4894
            64 ??                                                                                         0x7f19a87c9693
            65 g_signal_emit_valist                                                                       0x7f19a87cff06
            66 g_signal_emit                                                                              0x7f19a87cffc3
            67 ??                                                                                         0x7f199994a314
            68 gtk_window_propagate_key_event                                                             0x7f199996cdeb
            69 ??                                                                                         0x7f199997143b
            70 ??                                                                                         0x7f1999690caa
            71 g_closure_invoke                                                                           0x7f19a87b4730
            72 ??                                                                                         0x7f19a87c8f08
            73 ??                                                                                         0x7f19a87c9ad1
            74 g_signal_emit_valist                                                                       0x7f19a87cff06
            75 g_signal_emit                                                                              0x7f19a87cffc3
            76 ??                                                                                         0x7f199994a314
            77 ??                                                                                         0x7f19997fc8ff
            78 gtk_main_do_event                                                                          0x7f19997fe4be
            79 ??                                                                                         0x7f199a7b1a79
            80 ??                                                                                         0x7f199a7e5586
            81 ??                                                                                         0x7f199ed1ce3f
            82 ??                                                                                         0x7f199ed1eec7
            83 g_main_context_iteration                                                                   0x7f199ed1f4e0
            84 GtkSalData::Yield                                                    gtkdata.cxx     405   0x7f199a08827f
            85 GtkInstance::DoYield                                                 gtkinst.cxx     427   0x7f199a08d6e3
            86 ImplYield                                                            svapp.cxx       384   0x7f19a47bf65c
            87 Application::Yield                                                   svapp.cxx       472   0x7f19a47bef6b
            88 Application::Execute                                                 svapp.cxx       359   0x7f19a47bed02
            89 desktop::Desktop::Main                                               app.cxx         1652  0x7f19ad928434
            90 ImplSVMain                                                           svmain.cxx      229   0x7f19a47e226e
            91 SVMain                                                               svmain.cxx      261   0x7f19a47e4299
            92 soffice_main                                                         sofficemain.cxx 93    0x7f19ad9aca7c
            93 sal_main                                                             main.c          51    0x55cb2e25aa5d
            94 main                                                                 main.c          49    0x55cb2e25aa37
        
        As a consequence, `GtkInstanceComboBox::changed_by_direct_pick` would
        then return false when called in `SvxFontNameBox_Base::SelectHdl` (s.
        frame 21 in the first backtrace above), so the new value wouldn't get
        saved, but the previous one would get used instead since
        
            commit 131c1c7da8c567636ca55751e49d24cb6d6c9b9e
            Date:   Sun Nov 21 19:53:47 2021 +0000
        
                Related: tdf#145786 cooperate between our own grabs
        
        , which introduced grabbing the focus for the combobox
        in `GtkInstanceComboBox::menu_toggled` (s. frame 31 in above
        backtrace).
        
        Fix this by calling `fire_signal_changed` before
        `gtk_toggle_button_set_active` in
        `GtkInstanceComboBox::handle_row_activated`
        (s. frame 26 in the first and frame 44 in the second
        backtrace above), so `m_bChangedByMenu` only gets reset
        to false at the end of `fire_signal_changed`, not before it gets
        called.
        
        With that in place, the new value now gets set and the
        combobox shows the newly selected value as expected.
        
        Change-Id: Ib1919a99b46c33981593d9c5ec9a0d21443890b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168146
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [ceca4cde363154b0c7e276d65fc87ec94eb0bb9a]

        a11y: Don't report dummy a11y name for icon choice control
        
        If no a11y name is set for the `SvtIconChoiceCtrl`, don't
        report any, rather than using "IconChoiceControl" as
        accessible name.
        
        Having the Orca screen reader (when used with the qt6 VCL plugin)
        announce "IconChoiceControl" and then the name of the actually
        selected item e.g. in Writer's "Insert" -> "Hyperlink" or the
        "Format" -> "Page Setup" dialog is rather confusing when an
        entry in the control gets focus.
        
        Change-Id: Ie7e25d5a65c57be118abf2dcaff0648430f26154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168155
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-29  Michael Weghorn  <m.weghorn@posteo.de>  [c61f6a78022de6b29f031f3ac6726520032de187]

        a11y: Report focused state for icon choice control entries
        
        Handle the FOCUSABLE and FOCUSED a11y states in
        `AccessibleIconChoiceCtrlEntry::getAccessibleStateSet`.
        
        Without this, the currently focused tab item would
        e.g. not be reported by Orca when using the qt6 VCL
        plugin in Writer's "Insert" -> "Hyperlink" dialog
        or in "Format" -> "Page Style" that was recently
        converted to use vertical tabs.
        
        Monitoring AT-SPI events showed that an
        `object:state-changed:focused` event was sent
        on the AT-SPI layer (see also
        `AccessibleIconChoiceCtrl::ProcessWindowEvent` that sends
        an `AccessibleEventId::ACTIVE_DESCENDANT_CHANGED` event):
        
        However, the focused state is not set, so Orca
        would not report the item as the new focus item:
        
            95.1 object:state-changed:focused(0, 0, [list item | Mail])
                    source: [list item | Mail]
                    application: [application | soffice.bin]
        
        With this change in place, the state is properly
        set now and Orca announces the newly focused item:
        
            31.0 object:state-changed:focused(1, 0, [list item | Mail])
                    source: [list item | Mail]
                    application: [application | soffice.bin]
        
        Change-Id: I41667c842e607f494b9e0e236b8c6f2f9ca95dfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168154
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-29  Jonathan Clark  <jonathan@libreoffice.org>  [0b6a07f07dd05d0db4ddeedb9b112e26b5fd5eb5]

        tdf#81272 Improved CJK fallback rendering performance
        
        This change includes the following performance fixes:
        
        - Removes an expensive vector sort from fallback run computation.
        
        - Reduces unnecessary BreakIterator use while collecting grapheme
          clusters requiring fallback.
        
        Change-Id: I760825596e0609059ef0c5ca97e210ab6647e466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168175
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-05-29  Heiko Tietze  <tietze.heiko@gmail.com>  [2164406a973fd40fcc56b8839a21854f6b50a53b]

        Resolves tdf#160937 - Improve dialog size for document properties
        
        linefragment.ui and documentinfopage.ui modified to keep
        the usual dialog dimension
        
        Change-Id: I1777e4094e584d676a48855717827aaed413e251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168139
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [22ce8ed05be37d676739a578b05cc5217109fd87]

        Emscripten: Unconditional --enable-wasm-exceptions
        
        (...which will be beneficial, in turn, to implement exception handling in the
        work-in-progress bridges/source/cpp_uno/gcc3_wasm UNO bridge).
        
        As per
        <https://developer.mozilla.org/en-US/docs/WebAssembly#browser_compatibility>,
        Wasm exceptions appear to be supported by most if not all relevant engines by
        now.
        
        * Lets see whether the "Note that to really use WASM exceptions everywhere" for
        external libraries in solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk does have
        any practical consequences (but ignoring it for now).
        
        * This change depends on the preceding 77129fbb74bcefde4551d494f029169e7c6026e3
        "Emscripten: Add hack to prepare for --enable-wasm-exceptions" to work around
        the issue that was mentioned in static/README.wasm.md.
        
        * In unotest/source/embindtest/embindtest.js, getExceptionMessage started to
        work now, no longer exhibiting the RuntimeError that had been documented there
        for non-Wasm-based exceptions.
        
        Change-Id: Ifa2165b62208cc927844684911ddf21a4a2b624f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168169
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-28  Oliver Specht  <oliver.specht@cib.de>  [6084962f93efc005b6827edceae12d3170f17ccd]

        Set minimal size to variable field page
        
        To see the increased height of the name and value fields
        the edit field dialog needs a appropriate minimum size
        
        Change-Id: Ic6c4a01bd969247f770f023ec5c368fed5322550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168147
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6b6f18ed52e25df12347057f276712bd95d20fec]

        Emscripten: Document failing getExceptionMessage
        
        (and add a console.assert(false) to verify that an exception actually gets
        thrown)
        
        Change-Id: I885301a5730b54c817c8a9ed97e60f49f8c8baf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168149
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [281edd0831ab72b19887c64e084ee4f431dd9c4c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a61cdc9fb845956ccec780550684b3bcf01e4194
          - Fix typo
            
            Change-Id: I9f394ff23bdf67a1385f25f4417f44e0717d26c1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168160
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3fc5bfaf902052b9e0a1b6e162f9ed836efd090]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ib5220d2f44344455e6333f24b0dc2a20e5f9b0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168126
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a5f822897434cffe1991325ea18014734bfa24e]

        tdf#161048 Revert "move opencl check at startup inside its own thread"
        
        This reverts commit 7d1242b01d3ad9be1cfcf2bd3fbee9ce63dddddf.
        
        Intel's OpenCL driver gets stuck during shutdown and blocks the process from exiting
        
        Change-Id: I0e1360fd183dacd7331e1dd4122154d705f567fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168067
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [592947c1a421eae46d6268798cf3eab6bc6f0dc6]

        loplugin:ostr in sc/../unoobj
        
        Change-Id: I182a5f28c872eb4dd96b930b86b9aef42459f191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [2cb410d1a7e39f01bd1e8488b220d1bc6d9674a3]

        avoid dynamic_cast in ModifyChangedHint
        
        Change-Id: I78d9fc4984bf4313222c943816f81d31924dff26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168133
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [aea4dd58521b5621463c653a47275808a315edd6]

        avoid dynamic_cast in SwXRedline
        
        Change-Id: Id39e34c0f1b68639d3adf0092d753cb5dfb4cb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [57c7269fb48237573a0d2a0429dd6e82fe62fd71]

        loplugin:ostr in sc/../dbgui
        
        Change-Id: Ife9bda0112a9f76b767c6c8f5afba464da8d8464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168144
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Miklos Vajna  <vmiklos@collabora.com>  [2d2dd56e0b2dc708f1f758d7fc9a1263ff09b83c]

        tdf#160984 sw continuous endnotes: DOCX: import <w:endnotePr> pos == sectEnd
        
        Word can have per-section endnotes, but if endnotes are collected at the
        end of the section vs document end is a per-document setting.
        
        The DOC import already handles this in wwSectionManager::InsertSection()
        when it constructs an SwFormatEndAtTextEnd with FTNEND_ATTXTEND.
        
        Fix the problem by doing the same in writerfilter: in case settings.xml
        wants at-section-end endnotes, set EndnoteIsCollectAtTextEnd to true
        when applying section properties.
        
        The export side still needs doing.
        
        Change-Id: Ibad9c2d62a2945ee42877c849482feee60a50178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168148
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [e70b7edfb1bb8bcbde272f0152c51ae193e115d7]

        no need to dynamic_cast here
        
        Change-Id: I636f29e253d4fa9f0263d0ec79580e96b432cd3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168122
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [77129fbb74bcefde4551d494f029169e7c6026e3]

        Emscripten: Add hack to prepare for --enable-wasm-exceptions
        
        (...which will be beneficial, in turn, to implement exception handling in the
        work-in-progress bridges/source/cpp_uno/gcc3_wasm UNO bridge).
        
        Once setting --enable-wasm-exceptions, plus the corresponding
        -sSUPPORT_LONGJMP=wasm in qt5, I indeed started to see the "RuntimeError: null
        function or function signature mismatch" that was already mentioned in
        static/README.wasm.md.  I could track it down to the early destruction of the
        aDesktop local variable in soffice_main, as I now explain there.  However, it
        beats me why that variable gets destroyed early.  The desktop::Desktop::~Desktop
        dtor claims to be called from within main -> soffice_main ->
        desktop::Desktop::~Desktop, but at a time when the call to main -> soffice_main
        -> SVMain has not yet returned.  There also does not appear to be any C++
        exception handling stack unwinding going on.  (It could be related somehow to
        -sSUPPORT_LONGJMP=wasm, I don't know.)  And everything appears to just work fine
        after turning that aDesktop local variable into a (leaked) heap instance
        instead, so go with that hack for now...
        
        Change-Id: I8e00c988ee9a44fd3befbe41c844eec050f0e509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167694
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-28  Miklos Vajna  <vmiklos@collabora.com>  [f4ec4f6068a1ca265dd25c479cc40c546ae9223e]

        sw doc model xml dump: show SwFormatEndAtTextEnd
        
        Decides if endnotes are collected at section end or the normal doc end.
        Previously only the pool item name was visible, not the value.
        
        Change-Id: I141a687764b2069e2ddf65cbfdec514a4a0eb1e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168137
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0753aa966eba18ddf0534abd21ff92edcfdb7982]

        sw: use SAL_RET_MAYBENULL in getOtherTextBoxFormat()
        
        Change-Id: I854f0d2f38fc9c6b3f8afc4b05d42fbc26e76bc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168138
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c0593719836f6969262c7ed798ee9e528cf03e4b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b824f49fb1a71b173ed318241f99aeb7320eac0
          - tdf#159872 Review Help for SORT/SORTBY function
            
            + Fix syntax definition
            
            Change-Id: I9b24b25bdeb4298f6ba12f605b783324b3b921d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168115
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [88aff5815c76b30ecff03891906ffc932b4ec03d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 99ebed65db57abb67aa4765f636de2c3c60c10a9
          - tdf#159872 Review Help for RANDARRAY function
            
            + Fix syntax definition
            
            Change-Id: I9acde26c9d6237409813939b1bd1c23e3d61f862
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168110
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [afeee5c2489660a9d8d91ee51c6ad0f96ed35128]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5edd31fd783de27dec830907b18651ec8f8c9261
          - tdf#159872 Review Help for FILTER function
            
            + Fix syntax definition
            + Fix "Result not found"
            
            Change-Id: I80a2f9adafd03c79b199e069134413df2546f124
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168109
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [59104b191c386198c2c682ed8b650b2bb9a9f60f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 390dd2b9aaf82a2d859224173364ae207c51ba62
          - tdf#159872 Review Help XLOOKUP XMATCH functions
            
            From comments in by Regina and Ady in
            https://community.documentfoundation.org/t/comments-on-help-for-new-xlookup-fucntion/12086?u=ohallot
            and following.
            
            + Note on "case sensitive"
            + Details on array and range
            + Fix #N/A to "returns the #N/A error"
            + Reworked examples (re-use HLOOKUP table)
            + Grammar and linguistics here and there
            + Fix syntax definition
            + Fix "Not found" definition
            + Fix MatchType using verb "attempt"
            + Position of optional arguments
            + Longer user cases to be addressed in wiki
            
            Note: the function clones Excel XLOOKUP but it is not a copy. Therefore
            the name of the arguments were set to differentiate from Excel. The
            Calc function arguments usual naming were mostly mnemonic and
            not verbose. The current XLOOKUP names in the function wizard is
            verbose and has several words. Review is needed.
            
            Patch set 2: fix xml DTD
            Patch set 3: XMATCH
            + Reworked example (re-use HLOOKUP table)
            + Link to MATCH
            + Fix function syntax
            + Refactor
            Patch set 4:
            + typos
            + Fix case insensitive
            
            Change-Id: I9f085dcadbdb013cf3a3b892791e18c729aa6431
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168072
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6426583d0e73ea3d38c4b3baa80b7b10c020996d]

        Fix typo
        
        Change-Id: Ib67e06df1e730d6e23b30d590f6132e7ad7315b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168142
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9b072ee21a31127b008323749fe343f406da0fe4]

        odk: don't run compiler -dumpversion for eaach include of settings.mk
        
        VAR=$(shell … ) will run the shell command each time the line is parsed,
        i.e. for each include of the settings.mk from the examples. Use
        simple/one-time expansion using := avoids that.
        
        Change-Id: I46e6c486fbbe03bba37436d4ca98ddd0b6562ad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168091
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9ec0fa7ec3a62586f95e38f070b0d95e85fce6c3]

        use internal python for gbuild-to-ide on windows and python=fully-internal
        
        env python3 likely won't work in that case
        
        Change-Id: I1b24119af21db9db04c9fa6445e59cb328f39252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167162
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [71ce1181942741d0899d9dbbf035632dffe2b323]

        loplugin:ostr in sw/../ww8
        
        Change-Id: I48cc8f196e116c9c20c2930bb043e1d1ccf1de33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [550e50c529f8be00320cfd7ab1c305d9e6912dea]

        ofz#69290 Integer-overflow
        
        Change-Id: I20b49bf5e3a507979332cd854205f290a3b3971c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168118
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [b81ff51a8ccac942effdd309f014591604376ecc]

        sd: use SAL_RET_MAYBENULL in GetDrawView()
        
        Directly return nullptr instead of calling SfxViewShell::GetDrawView()
        which return nullptr to make it obvious
        
        Change-Id: I5e81d23f541a73181bb6f7d9e7f1d6ec56ff57ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168116
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [f60fd89e3d4ee60d9b9d0a02ed96c36ff8667188]

        sd: warning C6011: Dereferencing NULL pointer
        
        Change-Id: Id073e5d340fc91836b4689fb3e7a558ef3263e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168119
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [072bd5d40a149bd50e95d24fc54417094193077e]

        no need to dynamic_cast here
        
        Change-Id: I2a2f6929f3a79dc3209b5dfec7a09b07dd78d267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168123
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [25caf7dfd01534f9cdb044676c05c798fac96917]

        avoid dynamic_cast in PostItMgr
        
        Change-Id: Ieb571b8f39de1ffbc5cf1ce257204dca9bdb649e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [e7fcca88ce9acc78a402c5929d063e3cfc573be4]

        avoid dynamic_cast in SwView::Notify
        
        Change-Id: Id2b8f0f85165d442a5e3a54ee2e3b433f53b3613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168120
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-28  Laurent Balland  <laurent.balland@mailo.fr>  [2ec54f082e27d4b16540a146edde77f4874b8398]

        tdf#160712 Update Growing Liberty template
        
        + Use only Noto fonts
        + remove duplicate PNG pictures
        + update Thumbnail.png
        + add date/time, footer and slide # to master slides
        + replace dummy text with placeholders
        + remove object names as they are not translated and there are many duplicates
        + remove unused styles
        
        Change-Id: I9982885a87c6f5fa0e33be5eb483d5ce482eea70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167032
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-28  Laurent Balland  <laurent.balland@mailo.fr>  [c2c345a6d61092560b897d1f3a8b9a92a45215e4]

        tdf#160712 Update Freshes template
        
        + change name of first master to Freshes (see tdf#158496)
        + remove Lato, Freestyle, Nimbus fonts and replace with only one defined
          in top styles: Noto Sans, Noto Sans CJK SC and Noto Sans Devanagari
        + remove ODF validator warning about table:first-row-end-column (and so
          on) attributes that were missing
        + remove unused styles
        + change Thumbnail
        + use placeholders instead of dummy text
        + remove styles.xml and meta.xml of embedded charts
        + table:
           - decrease values below 1000 as thousand separator is language
          specific
           - correct sums on colomns and rows
           - remove preview image
        + reorder master slides in same order as slides
        + use same blue everywhere with styles "Filled Blue" and "Outlined Blue"
        + update description for File > Properties: remove font topic and
          correct chart types
        + update last slide
        
        Change-Id: I53b668bc398b7c85d93e75dfbdbf1f23e42a5c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166932
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>

2024-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4d53515faac28e7749b0c4d9a4e6b59aad63225]

        loplugin:ostr in sd/../ui
        
        Change-Id: I19acde24fd8a4014807318d97433b81814cadd75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167768
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Noel Grandin  <noelgrandin@gmail.com>  [9376df3c03d361a4c01493066db2a11a770d6cc9]

        no need to dynamic_cast here
        
        Change-Id: Ib2e08e58fc2f09161eda0cd32bf7ba2704387070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [4b53712cccfa48fc7d1f754d6a596204e041d554]

        tdf#160971 gtk: Don't select combobox text on entry selection
        
        In the same way that
        
            Change-Id: I17ce71198ec37cb1735194818bae17d1a5654d89
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 27 13:35:52 2024 +0200
        
                tdf#160971 qt a11y: Don't select combobox text on entry selection
        
        together with
        
            Change-Id: Ia2c77245049d708885cbd374c20ce1892259329b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 27 13:29:39 2024 +0200
        
                tdf#160971 vcl a11y: Make combobox text selection mode style-able
        
        sets the style option to not select combobox text when switching
        between entries in an editable combobox for the Qt-based VCL plugins,
        do the same for the GTK-based VCL plugins, except for putting the
        text cursor at the beginning of the entry text instead of the end,
        as happens when using a native GtkComboBox (see tdf#160971 comment 11).
        
        Since the GTK-based VCL plugins use native GTK widgets
        in most places, the behavior for e.g. the "Font Name"
        combobox in Writer's Formatting toolbar is already like that
        without this change in place and is unaffected by this change
        (even though LO's gtk3 VCL plugin is using a custom combobox
        implementation, see vcl/uiconfig/ui/combobox.ui).
        
        However, the new behavior applies for combobox form
        controls, as can be seen e.g. with the sample doc
        attachment 194376 from tdf#160971.
        
        Change-Id: I5b17efaa167ab49d07f19b3649ff934cf0f34754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168104
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [3776874c20b4d4b2b24850c5f21e3b89a7feaaea]

        tdf#160971 qt a11y: Don't select combobox text on entry selection
        
        In order to align the behavior with that of the native
        `QComboBox`, don't select the entry text when selecting
        a different combobox entry, e.g. using the up/down arrow
        keys in the editable combobox for the font name in
        Writer's Formatting toolbar.
        
        In order to achieve that, set the corresponding
        style setting newly introduced in the previous commit,
        
            Change-Id: Ia2c77245049d708885cbd374c20ce1892259329b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 27 13:29:39 2024 +0200
        
                tdf#160971 vcl a11y: Make combobox text selection mode style-able
        
        With this in place, the current Orca development version
        (git main as of commit c702b5acb9bd78a5812886a5d1c51409115e3900)
        also no longer announces "selection deleted" every time another entry
        is selected this way when using the qt6 VCL plugin, but only
        announces the text of the newly selected entry.
        
        Change-Id: I17ce71198ec37cb1735194818bae17d1a5654d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168103
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [98f9e9aa6c0dcfdb1ae9ec0ca9a3f6a557ae7396]

        tdf#160971 vcl a11y: Make combobox text selection mode style-able
        
        When selecting an entry of an editable combobox,
        the whole text of the text entry currently gets
        selected.
        
        That matches the behavior observed with a sample
        Windows Forms application.
        
        However, both native GTK and Qt applications
        behave differently and do not select the combobox
        entry text (s. tdf#160971 comment 11 and the
        referenced sample programs and screencasts).
        
        The extra text (un)selection makes the Orca
        screen reader on Linux announce an extra
        "selection deleted" every time
        another entry is selected using the up/down keys
        e.g. in the font selection combobox in Writer's
        Formatting toolbar when using the qt6 VCL plugin
        and the combobox popup is not shown.
        
        Introduce a new style setting to define the
        text selection behavior when switching between
        entries in a ComboBox and take that
        into account in `ComboBox::ImplSelectHdl`.
        
        The default behaviour remains unchanged.
        
        Behavior for the Qt and GTK based VCL plugins
        will be aligned more with the behavior of corresponding
        native widgets in separate upcoming commits.
        
        Change-Id: Ia2c77245049d708885cbd374c20ce1892259329b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168102
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-28  Jim Raykowski  <raykowj@gmail.com>  [ae94c420e6269f99cdaa611d19e73fc92ebd234b]

        SwNavigator: Improve Indexes context menu
        
        * Removes "Remove Index" menu item in favor of the repeated function
        "Delete index" menu item.
        
        * Hides the "Update", "Delete Index", and "Rename..." menu items when
        the document or index is set read-only.
        
        Change-Id: Ie907c33e2fe991ba6c02ad987193db481f375116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167913
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-05-28  Oliver Specht  <oliver.specht@cib.de>  [b860aea9d6f8ac46f6d2575ead25337495ec9a88]

        tdf#160198 Compatibility in background shapes/pictures
        
        Paint Word background shapes/pictures (wrapped through) above
        header and footer if the anchor is in the document body.
        
        Change-Id: Ic32ba8d64f82c64e502788007e49a9dce4c4c76f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164802
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-28  Miklos Vajna  <vmiklos@collabora.com>  [350a2dfa74bbc9d82f6555c0f3d679b6c53fe353]

        sw: rename SwIndexes to SwContentIndexes in comments
        
        Leftover from commit 9fdb06d65a8f2c3401392bffee9c4639e178aada (rename
        SwIndex->SwContentIndex, 2022-07-25).
        
        Change-Id: I68e5f64b57e629c6e6ddc2fed0326410facb3954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168085
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-27  Eike Rathke  <erack@redhat.com>  [ea1221867af90b452ec2d96b6b141abd6b8408cd]

        FunctionsTest: get detailed error also for string results
        
        That always was "result: 0, expected: 0" because it created a
        number from string.
        
        Also, while it looped over all sheets starting with the second,
        values were always obtained from the second sheet.
        
        Change-Id: Ib2d2a51d757c12fd9cd2a76b0b194c2112747e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168107
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [75776e7fb94affecb60ae5b9816d72ecafa3e340]

        sc: use SAL_RET_MAYBENULL in getBestViewShell(), getDocShell()...
        
        ... getCurrentBestViewShell() and getViewFrame()
        
        See 286a1c03fa10acf60f076a0af987112d24cb2ff5 "sc: check
        excel::getDocShell"
        
        Change-Id: Ibdd3f83d4f0571dccdd009f4b1790043144def0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168090
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [fbf3ef5e32d88655eb28b83cad3b1cf84dcc83b0]

        sc: warning C6011: Dereferencing NULL pointer
        
        Change-Id: I37d541f4c75f053023f67fc3617492bf38a13ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168095
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bd91407294358745553c9c364728c8fc83a85f2f]

        Adapt CustomTarget_postprocess/check_dynamic_objects
        
        ...to 441d8ed9be0e7f831b455a69b8688dcb79a8bc00 "tdf#145735 avmedia qt: Use
        QtMultimedia for Qt 6 media playback", which caused
        
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6Core.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6Gui.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6Widgets.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6Network.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6Multimedia.so.6
        > instdir/program/libvclplug_qt6lo.so has suspicious NEEDED: libQt6Multimedia.so.6
        > instdir/program/libvclplug_qt6lo.so has suspicious NEEDED: libQt6MultimediaWidgets.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libQt6MultimediaWidgets.so.6
        > instdir/program/libavmediaqt6.so has suspicious NEEDED: libxcb.so.1
        
        Change-Id: Iccbef5048ddb8375da33517ca0f797fe8f8d5565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168093
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-27  Moritz Duge  <moritz.duge@allotropia.de>  [55e74a33c757ffa40ce2ea50d986c60b9c84732b]

        Related tdf#158839: pw and GPG encryption, add comments and TODOs
        
        Change-Id: I53dbc43dcd5dbf594b7cd562bfff0bd3bdcb8ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168000
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [369a3b5ab389222bbbc9aafaa5c2d9f269ba5775]

        sfx2: use SAL_RET_MAYBENULL in GetFrameWeld()
        
        Change-Id: I78c4d190f8fcb96abaad267b19ab6cb3732a1807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168112
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [bcb863f132ebe8502b0f13f17cbd6185c2acdb78]

        sd: use SAL_RET_MAYBENULL in GetViewShellBase()
        
        Change-Id: If2f9662f87b02fe42cd144daa7855424ef31db0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168097
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [d561f52ac8e5355c4a50f38beb81b6aff9255cca]

        sd: warning C6011: Dereferencing NULL pointer
        
        Change-Id: I29d7f1174c79262afd84ab8399050366dda95a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168106
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [2429b8b511d2c856ae72489da4ded5f9daaee58b]

        sd: use SAL_RET_MAYBENULL in GetViewShell()
        
        Change-Id: I2074bd17c8d4069c170d3567970960e43b10a641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168098
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [10fbca7ebde81fc7246402f7025f219777c12488]

        starmath: use SAL_RET_MAYBENULL in GetEditWindow()
        
        after 359e2be93a4560a86237f076003c23a6635fb1bb
        "starmath: check GetEditWindow()"
        
        Change-Id: I6a93c00a3b67338e7f2816d1ef31ccf7afe8555e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167865
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f890f5a50d32b7985d0ab5146bfb9c3ff312fc4]

        sd: use SAL_RET_MAYBENULL in GetShell(), GetTopShell()...
        
        ... and GetTopViewShell()
        
        Change-Id: Ia6de13c078994978e7223a7d8ba3b3f604fcd0c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168094
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9fa1573c0e33d56f21734a519e4496cd8b10b04f]

        sd:  use SAL_RET_MAYBENULL in getViewFrame(), getDispatcher()...
        
        ... and getBindings()
        
        Change-Id: Ieb7c2181238faa7c7175822ef455f6e3ce04fa8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168092
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-27  Dione Maddern  <dionemaddern@gmail.com>  [af24f8df41a4159d16a6beb3f58b0f1cfc84c6ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8cba63bac0833eb8af14e507c2f2123a39c4d595
          - tdf#129097 Remove extra word in help pages
            
            Removed extra "box" after "Name Box" in:
            text/scalc/01/04070100.xhp
            text/scalc/04/01020000.xhp
            
            Change-Id: I7901f94af65956382bf2563757a9e7a7fc5727b5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168060
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2024-05-27  Jaume Pujantell  <jaume.pujantell@collabora.com>  [c8838d6dded9bcf77da657af50b48a7bfa90b85b]

        sc: don't overwrite Special Positioning on MakeEditView
        
        On LOK, calling UpdateEditPos after SetEditEngine overwrote the outer area
        of mpLOKSpecialPositioning, making the text show on the wrong position on
        right alined cells with overflowing content.
        
        Changing the order of the calls fixes that.
        
        Change-Id: I8ddb31103bb6f0bab1a9a6532af55797ef011214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167991
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3009eebbad4b1d9883a68066d758a67eeaf3c379)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167946
        Tested-by: Jenkins

2024-05-27  Miklos Vajna  <vmiklos@collabora.com>  [3f2d0414686a8f9a042413c47c4c8ffa5d61f436]

        tdf#160984 sw continuous endnotes: fix crash on loading forum-mso-en-7731.docx
        
        Regression from commit 1ae5ea3f78cca11ba18f2dd1a06f875263336a3b
        (tdf#160984 sw continuous endnotes: enable DOCX import, 2024-05-21), the
        bugdoc crashed in SwSectionFrame::GetEndSectFormat_().
        
        What seems to happen is that the first endnote is added to page 1, then
        more content is inserted, so the endnote is moved to page 2, which
        leaves an empty endnote section on page 1, which is marked for deletion
        in SwSectionFrame::MakeAll(), and will be deleted in
        SwRootFrame::DeleteEmptySct_(). At some point (after marking for
        deletion, before deletion) SwFootnoteBossFrame::AppendFootnote() tries
        to find the first endnote section in the layout, and finds this section,
        but it crashes because there is no SwSection attached to it, as marking
        for deletion in SwSectionFrame::DelEmpty() clears that.
        
        Fix the problem by ignoring to-be-deleted sections in
        SwFootnoteBossFrame::AppendFootnote(): this way a new, usable section
        will be created and the to-be-deleted section go away as the layout
        finishes.
        
        An alternative would be to check for SwSectionFrame::GetSection()
        earlier, as we iterate on pages (hoping that this way we find a later
        page that has a not-dead endnote section), but that leads to 6 pages
        instead of 4 pages for the bugdoc, so don't go that way.
        
        Change-Id: I9a21cbccb5a088314520c7ade55dbdf9966d1265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168084
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-27  Miklos Vajna  <vmiklos@collabora.com>  [2ef33247b7a3c07dde18d3cd6fd989fcb8ea4ddc]

        svx: prefix members of FmFormView
        
        See tdf#94879 for motivation.
        
        Change-Id: I142e2259e150fd0247193dcb941fb2fe37018486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168083
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-27  Julien Nabet  <serval2412@yahoo.fr>  [a9f77afabf98d98e14308a82aab86a2a3715fced]

        Bump emscripten minimum to 2.0.32 for as_handle
        
        Reading https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md
        val::as_handle() has been added with 2.0.32
        
        It'll allow WASM Jenkins to fail at the configure check step instead in the build with:
        /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/static/source/unoembindhelpers/PrimaryBindings.cxx:231:37: error: no member named 'as_handle' in 'emscripten::val'
                        = _emval_as(rObject.as_handle(), getTypeId(rUnoType), &destructors);
                                    ~~~~~~~ ^
        /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/static/source/unoembindhelpers/PrimaryBindings.cxx:240:37: error: no member named 'as_handle' in 'emscripten::val'
                        = _emval_as(rObject.as_handle(), getTypeId(rUnoType), &destructors);
                                    ~~~~~~~ ^
        2 errors generated.
        
        Change-Id: I7531256de46cd4b86b6eac9b1f8d16cad7b46ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168035
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [73064240850c78e93ee6c534a388aba617e4c234]

        False loplugin:staticmethods with LLVM 19 trunk
        
        > In file included from libreofficekit/source/gtk/lokdocview.cxx:26:
        > In file included from include/vcl/event.hxx:28:
        > In file included from include/vcl/outdev.hxx:30:
        > In file included from include/vcl/bitmap.hxx:31:
        > In file included from include/vcl/region.hxx:26:
        > In file included from include/basegfx/polygon/b2dpolypolygon.hxx:27:
        > In file included from include/basegfx/range/b2drange.hxx:27:
        > In file included from include/basegfx/point/b2dpoint.hxx:27:
        > include/basegfx/tuple/Size2D.hxx:30:10: error: this member function can be declared static [loplugin:staticmethods]
        >    30 |     TYPE getWidth() const { return Tuple2D<TYPE>::getX(); }
        >       |     ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > include/basegfx/tuple/Size2D.hxx:32:10: error: this member function can be declared static [loplugin:staticmethods]
        >    32 |     TYPE getHeight() const { return Tuple2D<TYPE>::getY(); }
        >       |     ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > include/basegfx/tuple/Size2D.hxx:34:10: error: this member function can be declared static [loplugin:staticmethods]
        >    34 |     void setWidth(TYPE const& rWidth) { Tuple2D<TYPE>::setX(rWidth); }
        >       |     ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > include/basegfx/tuple/Size2D.hxx:36:10: error: this member function can be declared static [loplugin:staticmethods]
        >    36 |     void setHeight(TYPE const& rHeight) { Tuple2D<TYPE>::setY(rHeight); }
        >       |     ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        ...but no idea why exactly that started to hit me just now
        
        Change-Id: Ibb2b57b54b07461a50375ee64670ff21e4670b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168082
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b1a6bd87b803f760f5bf0e2b7bc519b3b2fbfa4e]

        ofz: Use-of-uninitialized-value in ImplConvertUtf8ToUnicode
        
        probably since:
        
        commit 08e78607ec6bc820c52ab3df1a5d3738e049b90d
        Date:   Wed Sep 13 08:28:32 2017 +0200
        
            Make reading UTF-8 strict
        
        Change-Id: I4754e8c1314d37c7a863db4a1d9823d53fb343f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168079
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [24f65bf5940adb0aa3590443752110119e2bea5e]

        Fix typo
        
        Change-Id: I9e45b3667e2fadbeba46ddab5fdc135743a5d5bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168046
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-27  Eike Rathke  <erack@redhat.com>  [838f6adc9bdde2f656eb26bdc2870adfa7aa412b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40c26a09bc1350905c00f263858bf0398597c408
          - Add CSV Export/Import to last added options.
            
            Change-Id: Iae12e37d8e3ee9d5b7137cf10fa2a7797020caa3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168080
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2024-05-27  Stanislav Horacek  <stanislav.horacek@gmail.com>  [70f8315f0595111f9cee73062c983ef5496c9082]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ec34796b207530ada33ddcf74b4a0c207e7d49f
          - second column in Search results shows the cell
            
            Change-Id: I5b10788fac417331d7a72ad0afb56e1d004e8089
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168037
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [32d8a539ced92168958a6b608708bd77a375ad9f]

        tdf#154774 Sifr: Adjust contrast for dark variant
        
        Change-Id: Ifef5be9023d09f75d526f92e326f361072ea288b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168039
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-05-27  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [9f55ef05d6ed0732217729d90f79a57ab0a21ff0]

        Fix WASM build
        
        Wrong line for closing brace, after 1bd9747a126a3e82b6093c2b4af3b3a74774a3e9
        
        Change-Id: I552853f0eafc92c3d5435e4292de6c88db4d1260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168078
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-05-26  Dione Maddern  <dionemaddern@gmail.com>  [f1d624aae128988962b6cc877b68a726930b4c9a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 12e13425715a23ff426715e0bb7248d4aea55be9
          - tdf#129097 Fix inconsistent names for Name Box/Sheet Area Box
            
            In text/scalc/01/04070100.xhp
            - Added variable tags to H1 to allow the page to be more easily linked from other pages
            - Updated reference to "Sheet Area" to read "Name Box" instead
            
            In text/scalc/02/06010000.xhp
            - Added index bookmarks to make the page easier to find
            - Added a hid bookmark so that pressing F1 opens this page when the Name Box is selected in Calc
            - Added variable tags to H1 to allow the page to be more easily linked from other pages
            - Added variable tags to name in syname_box so it can be embedded in other pages. Changes to the menu option will update the name in linked pages.
            - Added a Related Topics Section
            
            In source/text/scalc/04/01020000.xhp
            - Replaced reference to "Sheet Area" with an embedded link to text/scalc/02/06010000.xhp
            
            In source/text/scalc/main0206.xhp
            - Replaced reference to "Sheet Area" with an embedded link to text/scalc/02/06010000.xhp
            
            Change-Id: Iddd26877397f3ffcf7ee38b95c38550f1a216d87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167947
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0960e05c2f540c99062867236419c2a70c1160b]

        Resolves: tdf#155364 resize buttons and change widget font sizes on zoom
        
        Change-Id: Ied951e6c96881bd56a40ae01077cd7f76f9b7853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168071
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f292fd3ac15109ad9ced85f2141922f403460618]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I8e43bdea51b7ab4943a2243e4d2ddb9d714f1895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168049
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07a372592cea4bded282b2ad9a67ca9e7b08c3cd]

        drop unused __SIMPLE_FUNC
        
        presumably unused since:
        
        commit a3ce60eb3c8bb5c69ab41556398efa8316286477
        Date:   Tue Nov 27 14:41:16 2012 +0200
        
            We only support MSVC 2008 (_MSC_VER 1500) or later
        
        Change-Id: Ica1c319ac485a1bd539ccd7df604df5786608698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168048
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3a647dd08e29dfb18382ede5506e913e8bd3bc04]

        presumably __SIMPLE_FUNC is unused
        
        Change-Id: I49cb3f981d913082bcf37b9142139c6831c79e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168047
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-26  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [e6ea581519a09e7b816d795b3bb3ec42538510cc]

        Add gssapi/kerberos libs to mariadb connector lib check
        
        After https://gerrit.libreoffice.org/c/core/+/159954 this started to
        fail with:
        
            > instdir/program/libmysqlclo.so has suspicious NEEDED: libgssapi_krb5.so.2
            >
        
        Change-Id: I6014136a053ba7ef92aef55a80517fb38c75e4ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168042
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-26  Eike Rathke  <erack@redhat.com>  [62e88a17fd5f803806a31ef6f56a241b55a88f5d]

        Resolves: tdf#160371 Relax significant whitespace intersection pre-check
        
        Change-Id: I3bef7c70571ee6ce8c98d60e6f6f017f3760530f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168070
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [741ab3c45335869f866f5616d97d5420fb41be77]

        Use Rectangle::expand instead of four Adjust* calls
        
        Change-Id: I0d1cf1e1609fee235d8df12714d59b408d3193bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168056
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [560f0f10a137f98ed2204bf8e00f892333d2dae8]

        ofz#69256 Integer-overflow
        
        Change-Id: I564635a52282ee632a0c028199ec86dd4bff99a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168044
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fda349ab8e834578fbefe9e9407d006eec47c7cd]

        ofz#69246 Integer-overflow
        
        WTMM takes/returns a double anyway, so just promote earlier
        
        Change-Id: I055fa7e7b155abfd15ef51335b34c2e6cfa8a209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168043
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-26  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [aa4188b8a60a46154657013640c0f160b057fa79]

        Remove remaining dynamic exception specifications in odk/examples
        
        as begun in
        
        commit ddcc98fa50dd9d86a60dada4daa00f4d95ffe005
        Author: Stephan Bergmann <sbergman@redhat.com>
        Date:   Wed Jul 22 13:41:12 2020 +0200
        
            Remove obsolete dynamic exception specifications from SDK example C++ code
        
        Change-Id: I70a799655f7633e255d80e829f12a88a27a3c2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167289
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [c9571914b8170128a68496ec2dd299e21243d1c1]

        tdf#161222: LOK: do not fine-tune text scaling for tile rendering
        
        For unclear reason, this shifts text on all tiles except the top left one.
        I wasn't able to track where the coordinate is changed: it seems that the
        pixel offset of the virtual device, its MapMode's origin, as well as the
        start point passed to the DrawTextArray method, are all only changed by a
        tiny amount, if at all, so it should be no more than a pixel off compared
        to before commit cc3663bbaed4f65d64154e5f9abb51a5f622f710 (tdf#160702:
        improve text positioning, 2024-04-20). However, it is already more than
        half the tile size (more than 128 pixel) offset in 75% scale case for the
        second tile; and it's completely off the tile for all the rest (third+ in
        a row), and for greater scales (100%+) even for second tile.
        
        Change-Id: I64dc24bea4bab0cac90f11f2500bba0fd9bc7855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168041
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-26  Patrick Luby  <guibmacdev@gmail.com>  [0735a4306da86c6fa0390b85f1f391ec404b2699]

        Related tdf#158914: fix memory leaks by calling (auto)release selectors
        
        Found the following memory leaks using Xcode's Instruments application:
        
        1. Posting an NSAccessibilityUIElementDestroyedNotification
           notification causes [ AquaA11yWrapper isAccessibilityElement ]
           to be called on the object so mark the object as disposed
           before posting the destroyed notification and test for disposed
           in all of the standard NSAccessibility selectors to prevent
           any calls to likely disposed C++ accessibility objects.
        
        2. In [ AquaA11yWrapper accessibilityHitTest: ],
           [ AquaA11yFactory wrapperForAccessibleContext: ] already retains
           the returned object so retaining it until the next call to this
           selector can lead to a memory leak when dragging selected cells
           in Calc to a new location. So autorelease the object so that
           transient objects stay alive but not past the next clearing of
           the autorelease pool.
        
        3. [ AquaA11ySelectionWrapper selectedChildrenAttributeForElement: ] is
           expected to return an autoreleased object.
        
        4. [ AquaA11yFactory wrapperForAccessible: ] is not a getter. It
           expects the caller to release the returned object.
        
        5. CreateNSString() is not a getter. It expects the caller to
           release the returned string.
        
        Change-Id: I824740d7e3851b0c3e31e2c009860aa822c94222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168034
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d1e065ea7ac98c31997f1af9be82c5da18c38369]

        ofz#69215 Heap-use-after-free
        
        maybe since?
        commit 397d7af2cbb1f2786ba857d350fb4641525e3bb2
        Date:   Wed May 22 15:03:40 2024 +0200
        
            tdf#161210 speedup loading large XLS
        
        ==344604== Invalid read of size 4
        ==344604==    at 0x1D74DEC5: XclImpXFRange::XclImpXFRange(int, int, XclImpXFIndex const&) (xistyle.hxx:555)
        ==344604==    by 0x1D746AFB: XclImpXFRangeColumn::SetXF(int, XclImpXFIndex const&) (xistyle.cxx:1777)
        ==344604==    by 0x1D747483: XclImpXFRangeBuffer::SetXF(ScAddress const&, unsigned short, XclImpXFRangeBuffer::XclImpXFInsertMode) (xistyle.cxx:1908)
        ==344604==    by 0x1D747629: XclImpXFRangeBuffer::SetXF(ScAddress const&, unsigned short) (xistyle.cxx:1929)
        ==344604==    by 0x1D2C0334: ImportExcel8::Labelsst() (excimp8.cxx:250)
        ==344604==    by 0x1D32AB78: ImportExcel8::Read() (read.cxx:1196)
        ==344604==    by 0x1D29FC2A: ScFormatFilterPluginImpl::ScImportExcel(SfxMedium&, ScDocument*, EXCIMPFORMAT) (excel.cxx:256)
        ==344604==    by 0x1D2A28BC: TestImportXLS (excel.cxx:483)
        ==344604==    by 0x405D76: sal_main_with_args(int, char**) (fftester.cxx:393)
        ==344604==    by 0x40363D: main (fftester.cxx:100)
        ==344604==  Address 0x2ab5fc08 is 8 bytes inside a block of size 12 free'd
        ==344604==    at 0x48463F3: operator delete(void*) (vg_replace_malloc.c:1051)
        ==344604==    by 0x1D761DDC: std::__new_allocator<XclImpXFRange>::deallocate(XclImpXFRange*, unsigned long) (new_allocator.h:172)
        ==344604==    by 0x1D761B27: std::__cxx1998::_Vector_base<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_deallocate(XclImpXFRange*, unsigned long) (allocator.h:210)
        ==344604==    by 0x1D76170E: void std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_realloc_insert<XclImpXFRange>(__gnu_cxx::__normal_iterator<XclImpXFRange*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, XclImpXFRange&&) (vector.tcc:519)
        ==344604==    by 0x1D763576: std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_insert_rval(__gnu_cxx::__normal_iterator<XclImpXFRange const*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, XclImpXFRange&&) (vector.tcc:372)
        ==344604==    by 0x1D763409: std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_emplace_aux(__gnu_cxx::__normal_iterator<XclImpXFRange const*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, XclImpXFRange&&) (stl_vector.h:1887)
        ==344604==    by 0x1D762F29: __gnu_cxx::__normal_iterator<XclImpXFRange*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > > std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::emplace<XclImpXFRange>(__gnu_cxx::__normal_iterator<XclImpXFRange const*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, XclImpXFRange&&) (stl_vector.h:1344)
        ==344604==    by 0x1D762CCB: __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<XclImpXFRange*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >, std::random_access_iterator_tag> std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::emplace<XclImpXFRange>(__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<XclImpXFRange const*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >, std::random_access_iterator_tag>, XclImpXFRange&&) (vector:545)
        ==344604==    by 0x1D74E0FD: __gnu_cxx::__enable_if<!std::__are_same<XclImpXFRange, bool>::__value, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<XclImpXFRange*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >, std::random_access_iterator_tag> >::__type std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::insert<XclImpXFRange>(__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<XclImpXFRange const*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >, std::random_access_iterator_tag>, XclImpXFRange&&) (vector:580)
        ==344604==    by 0x1D74712E: XclImpXFRangeColumn::Insert(XclImpXFRange, unsigned long) (xistyle.cxx:1798)
        ==344604==    by 0x1D746AD8: XclImpXFRangeColumn::SetXF(int, XclImpXFIndex const&) (xistyle.cxx:1776)
        ==344604==    by 0x1D747483: XclImpXFRangeBuffer::SetXF(ScAddress const&, unsigned short, XclImpXFRangeBuffer::XclImpXFInsertMode) (xistyle.cxx:1908)
        ==344604==  Block was alloc'd at
        ==344604==    at 0x4842F95: operator new(unsigned long) (vg_replace_malloc.c:483)
        ==344604==    by 0x1D761C4A: std::__new_allocator<XclImpXFRange>::allocate(unsigned long, void const*) (new_allocator.h:151)
        ==344604==    by 0x1D761A33: std::__cxx1998::_Vector_base<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_allocate(unsigned long) (allocator.h:198)
        ==344604==    by 0x1D7615F1: void std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::_M_realloc_insert<XclImpXFRange>(__gnu_cxx::__normal_iterator<XclImpXFRange*, std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> > >, XclImpXFRange&&) (vector.tcc:459)
        ==344604==    by 0x1D76148D: XclImpXFRange& std::__cxx1998::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::emplace_back<XclImpXFRange>(XclImpXFRange&&) (vector.tcc:123)
        ==344604==    by 0x1D761371: XclImpXFRange& std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::emplace_back<XclImpXFRange>(XclImpXFRange&&) (vector:519)
        ==344604==    by 0x1D74DE8C: __gnu_cxx::__enable_if<!std::__are_same<XclImpXFRange, bool>::__value, void>::__type std::__debug::vector<XclImpXFRange, std::allocator<XclImpXFRange> >::push_back<XclImpXFRange>(XclImpXFRange&&) (vector:508)
        ==344604==    by 0x1D7467AD: XclImpXFRangeColumn::SetDefaultXF(XclImpXFIndex const&, XclImpRoot const&) (xistyle.cxx:1727)
        ==344604==    by 0x1D7478A7: XclImpXFRangeBuffer::SetColumnDefXF(short, unsigned short) (xistyle.cxx:1956)
        ==344604==    by 0x1D2713A5: XclImpColRowSettings::SetDefaultXF(short, short, unsigned short) (colrowst.cxx:175)
        ==344604==    by 0x1D30E12F: ImportExcel::Colinfo() (impop.cxx:682)
        ==344604==    by 0x1D32A34E: ImportExcel8::Read() (read.cxx:1141)
        
        Change-Id: I55cc65d511878e31646d10dc7f367f30bd4454f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168038
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [034b68eb3a015553254c7238b13db8f94514080d]

        ofz#68840 another putcontig8bitYCbCr22tile issue
        
        Change-Id: I6e119cf1b3bec609f94784eb0c439835875d6112
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-25  Michael Meeks  <michael.meeks@collabora.com>  [c28bcfd7a0c40e8c839a14868e211b7ff003cde5]

        WakeupThread - re-factor to have a single shared wakeup thread.
        
        The WakeupThread is an attempt to avoid needing to call gettimeofday
        and/or update a visual status bar very regularly, and to have a thread
        marking the passing of time to emit progress updates infrequently.
        
        Re-factor this to have a single time-keeping thread, so it will be
        easier to shutdown and re-start for LOK; and also to simplify some
        of the complexity lurking here.
        
        Change-Id: Ia95890e5d6041a029484aa3f7df13b59a0397086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167949
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-05-25  Michael Weghorn  <m.weghorn@posteo.de>  [4d2c41e8171139e210d94b0c3c2b6b3d6392665a]

        related tdf#158914 sc a11y: Release references when disposing sheet
        
        Clear all `ScAccessibleCell` references that are owned by
        `ScAccessibleSpreadsheet` when disposing the sheet instead
        of when the sheet is deleted.
        
        While `ScAccessibleSpreadsheet::disposing` is always called,
        `ScAccessibleSpreadsheet::~ScAccessibleSpreadsheet` is not called
        until all of the sheet's `ScAccessibleCell` instances have been
        deleted. So make sure that `ScAccessibleSpreadsheet::disposing`
        releases all `ScAccessibleCell` references.
        
        This might possibly reduce some of the leaks mentioned in [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/167961/comments/15a6a4e4_91a77291
        
        Change-Id: Iaf14338945c1899d54c8e7f8a16f38a48316ac98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167985
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b227481b63000b556e648ad607ffeb86681482a0]

        pViewShell arg is never null, just use a reference here
        
        Change-Id: I29b5e9084da5b5f0817ffad37e3e5496577372fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168029
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50c718557da8d3141377a10a4a944736111a1494]

        cid#1598442 Dereference null return value
        
        Change-Id: Id44fb940ba17549068c5be554d5738ce81ced79a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168028
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [da15cb3d111f65356726ee5ed15bd82c73d5ccce]

        use same pattern as elsewhere for consistency
        
        Change-Id: I126fbbee916fd515a7057e3793f239e6f69748fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167835
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [137f423cc18e23f64b3b2bc6075c5f1581ac6537]

        tdf#161210 speedup loading large XLS (2)
        
        shave 2% off time by inlining GetDoc which is quite hot
        
        Change-Id: I20ede177e6032761598b1b977e90ff969bd2162a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168012
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-24  László Németh  <nemeth@numbertext.org>  [4da6f52f5fd164082fd42fc58fc7d31da567c924]

        tdf#161261 sw: fix lost size of image resized in fixed-height cell
        
        A fixed-height cell can contain a bigger image, which is cropped by
        cell boundaries. It was not possible to resize this image with a simple drag & drop, because its size changed to the cell size immediately.
        Now it's possible, like MSO does.
        
        Follow-up to commit 30de13743f144aced83bc43d310592f82788c910
        "tdf#160836 sw: resize rows at images cropped by row height".
        
        Change-Id: I9d63e6e526135b6d8541f904c363b9186bb3cfc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168023
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-24  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [293e3e683f98de949484c880147fee9a562c7df4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f26ce1d963abdd6d0503d2f225abc9423a77ccdd
          - Fixups
            
            Change-Id: I9b66bb7e7bf2e5cee67ad3e6f952a0b98afda66f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168025
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [397d7af2cbb1f2786ba857d350fb4641525e3bb2]

        tdf#161210 speedup loading large XLS
        
        takes the time from 22s to 20s for me
        
        Change-Id: Ib401c03ba13f82047c8376741e3547aadf5b18df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [79644440bd204bdecb73522c1eda6c101c40edda]

        tdf#145735 qt avmedia: Return video resolution for preferred win size
        
        In `QtPlayer::getPreferredPlayerWindowSize`, retrieve the
        video resolution from the meta data and return that for the
        preferred window size if available, instead of always returning
        an empty rect.
        
        For the sample presentation referenced in tdf#145735,
        the size retrieved this way also matches what
        `GtkPlayer::getPreferredPlayerWindowSize` returns
        (720x400).
        
        As mentioned in
        
            commit 441d8ed9be0e7f831b455a69b8688dcb79a8bc00
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 20 16:25:09 2024 +0200
        
                tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback
        
        , the behaviour without this was:
        
        > * In non-presentation mode, the placeholder
        >   shown until the video gets started using the controls
        >   in the sidebar is just an "audio icon", not a frame
        >   from the actual video. (This might be related to the
        >   fact that `QtPlayer::createFrameGrabber` currently
        >   returns an empty reference.)
        
        With this in place, the placeholder is now a different
        icon, a "video icon" (but still not a frame from the actual
        video).
        
        Change-Id: I295abe6b7973fece3fcaf9a38af2602cb08610a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168013
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [81c94af71206013cb200f5612bc3bd61c799cf83]

        tdf#145735 qt: Set margins for video widget/layout to 0
        
        Set all of the content margins of the layout that
        holds the widget for video playback to 0.
        
        Quoting [1]:
        
        > Sets the left, top, right, and bottom margins to use around the layout.
        >
        > By default, QLayout uses the values provided by the style. On most platforms,
        > the margin is 11 pixels in all directions.
        
        This makes the odd margin/frame shown around the video
        on video playback mentioned in
        
            commit 441d8ed9be0e7f831b455a69b8688dcb79a8bc00
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 20 16:25:09 2024 +0200
        
                tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback
        
        disappear.
        
        [1] https://doc.qt.io/qt-6/qlayout.html#setContentsMargins
        
        Change-Id: I29f1093caa986e6818fd575b031375ded0a572bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168010
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-24  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [a50b13f357ffa403542a09de0552c048d6374011]

        related tdf#33603: update current page on SlideSorter view
        
        Make SlideSorterView update the current page properly when it is the
        MainViewShell.
        
        Also fixes Notes Pane not properly updating on SlideSorter
        view mode.
        
        Change-Id: If4fed4e84951cb4a1707874b288ac46e6d5c26da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168022
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-05-24  Miklos Vajna  <vmiklos@collabora.com>  [8112883acf0015066f21dece7e1109dbda3e4cae]

        sw qa: rename writerfilter/cppunittests to just writerfilter
        
        15:47 <vmiklos> noelgrandin: any objections to go further with your writerfilter rename and turn sw/qa/writerfilter/cppunittests/* into sw/qa/writerfilter/* ? (suggest to either do it now or not at all if we're past the libreoffice-24-8 branch-off)
        15:59 <noelgrandin> vmiklos, not at all, go for it
        
        Change-Id: Ic0eb6907463389f3be326cdf183002f1bfcb42be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168024
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c88ce0eb999f86ecde956c9444d9970b73e70551]

        fix up assert
        
        Change-Id: Ib7276af8adc1e8e8957486b6e95db4005ce45b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168020
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-24  Heiko Tietze  <tietze.heiko@gmail.com>  [1e9a5ee8671f9a48894849d3cba4d65afa181554]

        Resolves tdf161196 - Visibility of formatting marks
        
        * Special indicators such as "°" for no-break space but also
          "," for zero width space are hidden if non-printable chars
          are disabled
        * Special indicators use the same color (NON_PRINTING_CHARACTER_COLOR)
        * Hard hyphen becomes blueish with non-printable chars on
        * Hard blank as well as hard hyphen are controlled by Formatting Aids >
          Non-breaking spaces; and both highlighting and indicator are hidden
          with non-printable chars off
        
        Change-Id: Ifa29371587ba44d825e04368c5f5c5bf7ed94c7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167987
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-24  Mike Kaganski  <mike.kaganski@collabora.com>  [98dd23286a09e10830c1103039dca5609e8c73a9]

        Avoid more cases of unneeded GetTextWidth
        
        Change-Id: I45ccf6e3c84f22d46b42c36179cb380ca803d08b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168014
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-24  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [8fc4eb1149e58ed5bcc4bb2b57807cdc92d93785]

        related tdf#33603: sd: outlineview: update current page on moving cursor
        
        The "early rejection test" removed here is a historical
        artifact when UpdateForKeyPress was created.
        
        in the current state it checked if
        pOutlineViewShell->GetActualPage() was different from
        itself.
        
        In the OutlineViewShell::UpdatePreview, there's an
        additional check if we have actually moved to a new page, so
        we can just safely remove this.
        
        Also fixes Notes Pane not properly updating on Outline View Mode
        
        Change-Id: Ic9de2e7302e76260809f90360533f0bfe6e05d2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168017
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-05-24  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [dc208a0de04b29a53fe8384043f1fc925761a912]

        tdf#33603: sd: notes pane: properly handle movement keys
        
        Makes it so that notes pane handles some previously
        incorrectly handled keys itself. e.g. PageUp & PageDown
        
        Change-Id: I19f73fa2782900a752889544dcc79fc180ee52d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168008
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
        Tested-by: Jenkins

2024-05-24  Miklos Vajna  <vmiklos@collabora.com>  [6de49dee825c6bd093007b4c954f97812c3fdb47]

        sw: rename SwIndex to SwContentIndex in comments
        
        Leftover from commit 9fdb06d65a8f2c3401392bffee9c4639e178aada (rename
        SwIndex->SwContentIndex, 2022-07-25).
        
        Change-Id: I9a410e9b9ca8529454c50e93afd48b731a0fa320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168018
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-24  Miklos Vajna  <vmiklos@collabora.com>  [a3150fc8a59662ce8630cfc64fec9cd083ac7d36]

        tdf#145972 sw image dialog: fix bad rel width w/ pt units and kept aspect ratio
        
        Regression from commit 02c435082058ecf7f9d4d73cb47d31d0218dc10d (sw keep
        aspect ratio: add filter for this setting, 2021-06-07), once UI units
        are set to poins (instead of cms), the image dialog for the bugdoc was
        showing 5% width instead of 48%.
        
        48% is roughtly correct, visually the image is taking half of the body
        frame width. Previously the bad rel size didn't happen because we didn't
        save the "keep aspect ratio" to documents, so it was off by the time the
        dialog was initialized.
        
        Fix the problem by introducing a new flag, so we can differentiate
        between the user changine the width or height vs the dialog being
        initialized. RelSizeClickHdl() is meant to adjust the other axis in the
        user case, and this is not wanted in the init case.
        
        A higher level fix would be to make sure once aspect ratio is kept,
        that ratio is stored in documents explicitly, so we can say 50% wide
        with e.g. 4:3 ratio, that would avoid all this trouble by even looking
        at the calculated sizes when we want to work with percents. This storing
        of the aspect ratio is not done here.
        
        Change-Id: I901e7f6d5e6f7f1349d7beeb05985ddbf99a34a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168015
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-24  Miklos Vajna  <vmiklos@collabora.com>  [755f3bebd96ec7ae43b1dcf247f907b9c15c1995]

        tdf#160984 sw continuous endnotes: fix the endnote separator length
        
        See
        <https://bug-attachments.documentfoundation.org/attachment.cgi?id=194324>,
        Word has a longer separator line for the foot/endnote than Writer for
        this bugdoc.
        
        Writer defaults to 25% of the body frame width in the SwPageFootnoteInfo
        ctor, and we don't seem to change that in the DOCX import. Word has a
        static 2 inches setting, which is only reduced if it would go outside
        the body frame.
        
        Fix the problem by extending SwFootnoteContFrame::PaintLine() in the
        DocumentSettingId::CONTINUOUS_ENDNOTES case to do the same.
        
        I searched the OOXML spec and the MS implementer notes, they don't
        specify this 2 inches length, but it seems static: the value doesn't
        change with the page size. With this, the single-section bugdoc is now
        rendered fine.
        
        Change-Id: I3bb23680937580179b8d37c940ea14e0f80fc7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168009
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-24  Henry Castro  <hcastro@collabora.com>  [7cd07676dfb6a27957d60fb968fd2d3b8abc873c]

        lok: sc: fix print mode document back color
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I334ff51230ef01d7a87790409a6d76541c57ba54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167911
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 11eaf501798cec2c5758cd7fd447998e202ae1f9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167944
        Tested-by: Jenkins

2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [248a19ad2b21669be6f76dbacb0f89ea41fe6d96]

        a11y: Rename m_aAccessibleChildren1 -> m_aAccessibleChildren
        
        Was previously changed the other way around in
        
            commit 28c89e58d90ea73513e273db274eb46ff9081c35
            Date:   Wed Aug 30 15:16:01 2023 +0200
        
                use concrete type for OAccessibleMenuBaseComponent::m_aAccessibleChildren
        
        for no apparent reason.
        
        Change-Id: I0d0c6627134bcef8ac9732cc8a5213ab266afbf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168005
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [56572e8b9ab256373b9b1be2bf4b94519c7dd151]

        a11y: Drop AccessibleChildren typedef
        
        ... which is only used in the next line anyway.
        
        Change-Id: I3bb038cfba3b3b31df45ca316242d54442db7220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168004
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d568fe29bd95755746248fc54624d5dec03d9b7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7fe9ae80c7df68c70dae06b9d6002fbc42d1ab7e
          - Fix typo
            
            Change-Id: Ia0a17632d7e505bff252bb788384a83869aef00b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/168003
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [87c41bbf04c361746bf9c2373aa144a02d971303]

        gtk3 a11y tests: Increase timeout for AT-SPI method calls
        
        As discussed in the ESC call of 2024-05-23,
        CppunitTest_vcl_gtk3_a11y fails relatively often recently:
        
        >     38 CppunitTest_vcl_gtk3_a11y                gerrit_linux_clang_dbgutil
        >    + this week: have a new problem with CppunitTest_vcl_gtk3_a11y (Cloph)
        >      + failure is not new, but the frequency increased recently
        >      + assume: timing issue
        
        Jenkins logs show that failures are due to running into
        timeouts, example from [1]:
        
            [...]
            found run attribute: CharTopBorder=<Any: (com.sun.star.table.BorderLine2) 0x6831c50>
            found run attribute: CharTopBorderComplexColor=<Any: (void)>
            found run attribute: MMToPixelRatio=<Any: (float) 1.25>
              matching atspi attribute is: mm-to-pixel-ratio=1.25
            unknown:0:Test1::TestBody
            An uncaught exception of type com.sun.star.uno.RuntimeException
            - timeout from dbind at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:302
        
        Increase the timeout for method calls from 2.5 to 10 seconds
        in the hope that will help.
        (Issue is not reproducible locally for me.)
        
        [1] https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/162811/consoleFull
        
        Change-Id: Ib0eef753cf9f574ee5b2a013a46a0a600c91eb34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168002
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-24  Michael Weghorn  <m.weghorn@posteo.de>  [ee168614ddea2f349e80372599296e835080f264]

        tdf#160971 gtk3 a11y: Manually unset focus for combobox popup
        
        The gtk3 VCL plugin uses a custom implementation that
        has a listbox in a popup (s. vcl/uiconfig/ui/combobox.ui).
        
        The popup window gets shown when expanding the combobox, e.g.
        using Alt+Up/Alt+Down while the edit has focus.
        
        Once the popup is closed again, focus is given to the edit
        again.
        
        That one correctly reports focus when checked via
        `gtk_widget_has_focus`, but for some unknown
        reason, the listbox in the popup assumes/claims
        it still has global keyboard focus as well, despite it no
        longer being visible and the `gtk_widget_has_focus` doc [1]
        explicitly mentioning:
        
        > Determines if the widget has the global input focus.
        > See gtk_widget_is_focus() for the difference between
        having the global input focus, and only having the focus
        > within a toplevel.
        
        The tree view listbox still assuming focus leads to it
        emitting invalid active-descendant-changed a11y events
        when the selected entry changes, which e.g. breaks focus
        tracking by the Orca screen reader.
        As a consequence, current Orca git main
        (as of commit d70919051ef01384c473e08321a88cec52549cd2)
        doesn't doesn't announce the new value of e.g. the "Font Name"
        combobox in the Writer toolbar when changing it via the
        Up/Down arrow keys any more once the popup has been shown.
        (It works fine before showing the popup for the first time.)
        
        To avoid that problem, manually unset the focus
        using `gtk_widget_send_focus_change`.
        Its doc [2] mentions
        
        > This function is not meant to be used by applications.
        
        , but since the focus is apparently not unset
        automatically, still use it as a workaround for now.
        
        [1] https://docs.gtk.org/gtk3/method.Widget.has_focus.html
        [2] https://docs.gtk.org/gtk3/method.Widget.send_focus_change.html
        
        Change-Id: Ifd32c2a66b4a7b9e827f5c8dc2927c7e359a42aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167994
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-24  Weblate  <noreply@documentfoundation.org>  [7ae9dc04202cd0e1582c09218254c52fd5f5c3d8]

        android-viewer translated using Weblate
        
        Japanese currently translated at 68.1% (79 of 116 strings)
        
        Change-Id: I1c42877ea415bdf3830bbee64c97589eafa7fa1c
        
        android-viewer translated using Weblate
        
        Change-Id: I9efdbae451a5313cb5b8ef4a169696969696969b
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167986
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-23  Bogdan B  <buzea.bogdan@libreoffice.org>  [322b158c5c517cb0242e95240928949ab41d95a0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 25f4e3d465bed888952ef7cafa2e47736bb0214d
          - tdf#148903 Improve Help about positioning
            
            Change-Id: I695530a298d61ec7e7c83603addccf40741fad6c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149886
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-23  Dione Maddern  <dionemaddern@gmail.com>  [d4243c3646c37f9f057636442e9fd65f2530f4c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c9ef3ec7d50ab940d9f9d2a4c255c2cd16a47048
          - tdf#130838 tdf#154996 Add warning about copying/moving in record mode
            
            In text/scalc/01/02180000.xhp
            - Add statement that sheets can't be moved or copied in Record Changes mode.
            
            In text/shared/00/edit_menu.xhp
            - Updated howtoget instructions for "Track Changes" and "Record Changes", including adding Tabbed UI instructions for "Record Changes" and hiding instructions for the Track Changes toolbar behind an application switch, because Calc does not have a Track Changes toolbar.
            
            In text/shared/01/02230000.xhp
            - Added variable tags to H1 so that the page can be more easily linked from other pages
            
            In text/shared/01/02230100.xhp
            - Moved howtoget function to text/shared/00/edit_menu.xhp
            - Updated embed link for howtoget section
            
            Change-Id: I4776c0d45cd5d58a822cf00ede81ae3769ef8218
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167943
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-23  Dione Maddern  <dionemaddern@gmail.com>  [93510ceb3dc446af84aa7803e4d1fc169ba5d363]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35c331d42654a28c9852187474b102db1c987e53
          - tdf#105988  tdf#130024 Update Edit Points Bar help page
            
            Created new file text/shared/02/eliminate_points.xhp so that more detailed information on "Eliminate Points" mode is on its own page.
            - Updated the description of the "Eliminate Points" feature to more accurately describe how the feature works.
            
            In AllLangHelp_shared.mk
            - Added new page text/shared/02/eliminate_points.xhp
            
            In source/text/shared/01/05270000.xhp
            - Added section and variable tags to allow content to be easily embedded in other pages.
            
            In source/text/shared/main0227.xhp
            - Added section and variable tags to allow content to be easily embedded in other pages.
            - Moved the link to "Converting 2D Objects to Curves, Polygons, and 3D Objects" to a new Related Topics section
            - Replaced "Edit Points" section with an embedded link to the description in text/shared/01/05270000 (Edit Points mode) to avoid repetition
            - Replaced "Edit Points" section with an embedded link to the description in text/shared/02/eliminate_points.xhp to avoid repetition.
            - Created a Related Topics section
            
            In text/simpress/02/10080000.xhp
            - Added variable tags to allow the page to be easily linked from other pages
            - Changed the Title and Heading 1 from "Curve" to "Curves and Polygons" to reflect current menu options.
            
            Change-Id: Ib9038f35b97b4177e11171bfdedd10c0a4149dd2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167939
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-23  Miklos Vajna  <vmiklos@collabora.com>  [f1d0b4e34a1f467e9f54baa7ac31ca28fdae3efb]

        tdf#160984 sw continuous endnotes: fix the endnote separator position
        
        See <https://bugs.documentfoundation.org/attachment.cgi?id=194306>, the
        total height of the endnote separator is now correct, but the
        distribution of upper space, line width, lower space is still bad, when
        compared to Word.
        
        Our model is 2 spacings and a line width, while Word seems to simply
        split the amount of available space: 60% goes above the separator and
        the rest goes below.
        
        Fix the problem by breaking up the monster expression for the separator
        rectangle in SwFootnoteContFrame::PaintLine(), and then the compat +
        horizontal case can do the 60% spacing in the Word compat mode.
        
        The width of the separator is still not correct.
        
        Change-Id: Ic065c138041892225b3c1b7d4bd64d4f1c625611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167990
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [b46b0e92e54d871af8c2f2471c991c5d243a089d]

        use SAL_RET_MAYBENULL in GetViewBindings(), GetBestViewShell()...
        
        ... GetViewData() and GetShellByNum()
        
        Change-Id: I9a53e2d4cf1241195985cf095d274f596abd6427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167993
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ebf7f55cee69386353185372dabb406031d74da]

        sc/qa: warning C6011: Dereferencing NULL pointer
        
        Change-Id: I6556217bd132c0cd80ffa40fef397b9f86cae09d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167996
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [64b14cc6ab688abbea2f87bc25ba42159b5dc904]

        sc: warning C6011: Dereferencing NULL pointer
        
        Change-Id: Ib6535d167ec741ea0641208d01f01bee334c0e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167992
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Noel Grandin  <noelgrandin@gmail.com>  [f91a411340ae204ce1e6997f22e0352a4c6a8355]

        reduce cost of calc column height calculation
        
        avoid calling GetTextWidth unless we really need to
        
        Change-Id: Ibb0f378e632fa3fce68b4819028630759baf4eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167988
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-23  U-AMANDAQUARESMA\quare  <quaresmaamanda4@gmail.com>  [fc3e2c8bba202a3ea3e92672f566d6ec16f18681]

        tdf#145538 Use range based for loops
        
        Change-Id: Ib672cd1968de7bb99cd5f8737a09ce02b0490bf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167995
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-23  Michael Weghorn  <m.weghorn@posteo.de>  [6bab5485913ca99feb00855a20171a8a770f0469]

        android: Use "compact_fonts" LibreOfficeKit option
        
        For Android Viewer, set the "compact_fonts" LibreOfficeKit
        option via environment variable `SAL_LOK_OPTIONS` introduced in
        
            Change-Id: I3dc9f5de876def6e4afc09a43105b1740f7c621f
            Author: Michael Meeks <michael.meeks@collabora.com>
            Date:   Fri May 17 21:25:29 2024 +0100
        
                lok: stop amazing waste of repeated font sizes in each font element.
        
        and adjust the handling in `FontController` to process
        the flat lists for font names and sizes that is reported
        with that options set, rather than processing
        font sizes for each individual font.
        
        (See also discussion in original Gerrit change
        for the distro/collabora/co-24.04 branch: [1].).
        
        [1] https://gerrit.libreoffice.org/c/core/+/167799
        
        Change-Id: I85734c1876d152f4f95f9182629affd6b250fdbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167963
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [693b21954581c608b7ef456c799ecbd3f46b9918]

        use SAL_RET_MAYBENULL in GetActiveWrtShell(), GetActiveView()...
        
        ... GetFirstView() and GetNextView()
        
        after 25b38765d6e500af196ce312a3e1d819c6a7d09c
        "check GetActiveWrtShell() and CheckAndGetWrtShell()"
        and 74f398bb58510087cc4a11bb2253715771a2c6b2
        "sw: check GetActiveView()"
        
        Change-Id: I0840309a28e2fb54a5abd386ceeddb21006d9368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167866
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9f9493b43f89ad1560e9779796ade7854aa2b74]

        sw: warning C6011: Dereferencing NULL pointer
        
        Change-Id: I612ec139354345f48fb5d3b41bdb10c37ad85ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167983
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bd4b345ac6017483839091102d732ff3d899ec87]

        Update git submodules
        
        * Update translations from branch 'master'
          to b46612b5cf30742f137cc685ff3bb75b42a75619
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I062d883de199aa7dd9015d72f519e190614c6d86
            
2024-05-23  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [1396347c8e9b036f15bc646b9475073344e69e74]

        tdf#159899 sw: show hyperlink name as tooltip
        
        Change-Id: I48f841d1c42f9541e03632a88e1a4f65975a5335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167971
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [9990ac8143e81241be311f117bd2133bdf0ea343]

        tdf#161092 KJ: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: If677a878ef80994b5b05e628064fb1ab49298e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167982
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Michael Meeks  <michael.meeks@collabora.com>  [aaf4613a0aeb9cf7c27c731f2391de14bdcff880]

        lok: stop amazing waste of repeated font sizes in each font element.
        
        These days all sensible fonts are scalable, so anything else is madness.
        
        With the compact_fonts option we go from:
        
            INCOMING: commandvalues: {"commandName":".uno:CharFontName","commandValues":
            {"Albany AMT":["6","7","8","9","10","10.5","11","12","13","14","15","16",
            "18","20","21","22","24","26","28","32","36","40","42","44","48","54",
            "60","66","72","80","88","96"],"Amiri":["6","7"
        
                    <truncated 58,418 chars>
        
            INCOMING: commandvalues: { "commandName": ".uno:CharFontName", "FontNames":
            [ "Albany AMT", "Amiri", "Amiri Quran", "Amiri Quran Colored", "Andale Mono",
            "Andale Sans", "Andy MT", "AR PL UMing CN", "AR PL UMing HK", "AR PL UMing TW",
            "AR PL UMing TW MBE", "Arial",
        
                   <truncated 6,948 chars>
        
        An 8x size win.
        
        Change-Id: I3dc9f5de876def6e4afc09a43105b1740f7c621f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167799
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit 628f56a1802ad76cbe84a9a5590b04ed81a57a9e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167962
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [c7a09ea9d58fbf41090508e32334be3c0356b050]

        use SAL_RET_MAYBENULL in GetUserCall
        
        after 495b5db74f0db59395ff68bacc8d8ca67595b66e
        "sw: check GetUserCall"
        
        Change-Id: I14b69c1d95ddea2c4c92e6c682930cd501ea7612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167787
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [08241a507985ac66d5fb5670cbd390e99fc9ac97]

        Sukapura: Delete underlying bitmap in chart type vector files
        
        Change-Id: I299a283a1729f3ab0595218b7b29ca36a1c257f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167975
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a175b29c7f6b55ac96b9046653486041e98e11f]

        sw: Use SAL_RET_MAYBENULL in GetEditShell()
        
        after 24889135773204c6e3002dcb417c75ff1a99ccd0
        "check GetEditShell()"
        
        Change-Id: I5650e23e0c2a1c3eb81cfa71c57b809d8abc4b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167906
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [be9c71df2283523a3bc87f040afb7daa0da0bfdf]

        sw: warning C6011: Dereferencing NULL pointer
        
        Change-Id: Ia4b7f98525e07c5a58b752d7e68d89705f87ac9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167969
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-23  Michael Meeks  <michael.meeks@collabora.com>  [9d1956031ed326e3d377800530993dcd2571f99a]

        lok: stop amazing waste of pretty-printed JSON sent over the API.
        
        before:
        
        INCOMING: commandvalues: {
            "commandName": ".uno:CharFontName",
            "commandValues": {
                "Albany AMT": [
                    "6",
                    "7",
                    "8",
                    "9",
                    "10",
                    "10.5",
                    "11",
                    "12",
        
                <truncated 199,811 chars>
        
        after:
        
        INCOMING: commandvalues: {"commandName":".uno:CharFontName","commandValues":
        {"Albany AMT":["6","7","8","9","10","10.5","11","12","13","14","15","16",
        "18","20","21","22","24","26","28","32","36","40","42","44","48","54",
        "60","66","72","80","88","96"],"Amiri":["6","7"
        
        	<truncated 58,418 chars>
        
        A 3x size saving.
        
        Change-Id: I574b8bdf790078c61b7605137a47a531dee16f1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167685
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-05-23  Miklos Vajna  <vmiklos@collabora.com>  [a4ec8307e342bd83e287b197ffac822ac7e9f599]

        CppunitTest_sw_rtfexport8: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I10256d2cd8d214489b52600ccbb45b0ba1526950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167979
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6715899547fd8960e236b090d44367eafef3eb71]

        sfx2: use SAL_RET_MAYBENULL in GetBindings() and GetShell()
        
        after 9eb083ab732512c3ab64007c3be1c54be97172f6
        "check GetShell"
        
        Change-Id: I0dcef57019fde7639ddbb981cbd41c13f857b4af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167905
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [50fa7d2581a69ffec4da6e3cce6a6f0e514b7aa5]

        sfx2: warning C6011: Dereferencing NULL pointer
        
        Change-Id: Ie65284c3ded0c5789f0be5bbd770d190a92fecec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167922
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [16a56dfccbd3abd01ec370ce611880ad5c2cb8b8]

        sw/qa: warning C6011: Dereferencing NULL pointer
        
        Change-Id: I2e84af9463b82600079660a1b136bc9a85d8eb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167925
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [dddba389b79647f69f447e576cf7e880be5661c6]

        loplugin:ostr in sw/../vba
        
        Change-Id: I73491b481fb82785a21f7239fff62f812dd7440c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167953
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b1f4a39a326bcaf06068914c03c3dea6f9aeebd8]

        tdf#161092 Sifr: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: I10dafbcee04f51babb965ba8d7ddf1d1894dee8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167977
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [87734c11fd634b3123559b1994b179e96810dd7c]

        tdf#161092 elementary: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: I70cef278536b3a64551d0b0e4548f666bbdac373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167978
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f45270827c8bb32c58790a75e3fec3770be6b16f]

        tdf#161092 Breeze: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: I6f0f794abe567020f4e7e0d758ac9132b57611fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167976
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Weblate  <noreply@documentfoundation.org>  [15e60dfeacbc7acf4ccaabe2b3e062a01d18f658]

        Added translation for android-viewer using Weblate (Georgian)
        
        Change-Id: I4058a4698582256a31ebb21379c0a66b22e2a1cc
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 65.5% (76 of 116 strings)
        
        Change-Id: I74e48d5d605e25ebf39e2a8bd73495274ee94855
        
        Added translation for android-viewer using Weblate (Hebrew)
        
        Change-Id: I491b69291975d22c0552cc20e93f2042cc70e4b0
        
        Update translation files for android-viewer
        
        Updated by "Cleanup translation files" hook in Weblate.
        
        Change-Id: Iea28e4d8bf859accdb1c16bb4c6836237a4d2b26
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 61.0% (72 of 118 strings)
        
        Change-Id: I741c23b1048d4857605d73aad34668c29234dd6f
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I9cbcf579a5c634adf0686e43aa4dca069c2dd577
        
        Added translation for android-viewer using Weblate (Esperanto)
        
        Change-Id: Ibcf6e82a860c5e789d6ee89dace30d1457a60c22
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 39.8% (47 of 118 strings)
        
        Change-Id: I9efdbae451a5313cb5b8ef4a1abca6969696969b
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Ekaterine Papava <papava.e@gtu.ge>
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167895
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a46736cfe6b5188e840129b6aa26fc2970893474]

        tdf#161092 Sukapura: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: Ib28fb1e40c76c951cb7bec4a98b2aecefb3c83ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167974
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Jenkins

2024-05-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [eb3ae3234e098e1ee605624b0cac4c90436628d0]

        tdf#161092 Colibre: Graphics for bar-of-pie and pie-of-pie chart type
        
        Change-Id: I6af94e0792b17c58dc673732a0c96a844143315b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167972
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2024-05-23  Justin Luth  <jluth@mail.com>  [cdbd4139790383052f004def482f32fdec604fbb]

        Revert "tdf#126095 sd notebookbar: don't force table/media toolbar"
        
        This reverts my 24.2 commit e58e251756ecb0312cb6891d4df23e17ef8f6fcb.
        
        Unintended side affect in Draw (not Writer) sidebar.
        
        Change-Id: I948263c1e8be1202e0504f109d84ce4469ddf45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167970
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-22  Justin Luth  <jluth@mail.com>  [fe5b4257d852b937652d55f2272ed535835d85c5]

        NFC IsInline includes GetAnchorId() == RndStdIds::FLY_AS_CHAR
        
        m_bIsInline is either forced true,
        or is set by GetAnchorId() == RndStdIds::FLY_AS_CHAR.
        Nothing sets it to false, but it can become true with
        ForceTreatAsInline.
        
        So, no need to check for FLY_AS_CHAR if we also allow IsInline.
        
        Change-Id: I5f7a158962dcde1fd2d642ffd54e0995a69ad841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167966
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [80f7f3e8099e05632201d7b18de0112153ebc1ba]

        split a piece of code out as a standalone GetOrCreateAnnotationWindow
        
        Change-Id: I674d96976f265eeac719ed06a657af07aaae2325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-22  Heiko Tietze  <tietze.heiko@gmail.com>  [1bd9747a126a3e82b6093c2b4af3b3a74774a3e9]

        tdf#161209 - Reverts WhatsNew/Welcome dialog
        
        dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1
        
        Change-Id: Idf0594c546e4d9ca263272ed1534b27948e8e930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167956
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-05-22  Mike Kaganski  <mike.kaganski@collabora.com>  [08da27fc377f443d1d6698f4a061fa462849062d]

        Handle empty range correctly
        
        Otherwise, the translation gets MAX_DBL value, and scaling becomes 0.
        After commit 690526f95e3ee4fd25bb2c987e093543e4bc435b (Generalize basegfx::fround
        for templated return type, 2024-04-15) this made some documents (e.g., bugdoc
        in tdf#85132) fail an assertion in debug builds, which allowed to find and fix
        this problem.
        
        Change-Id: I14cb0afd0c8d884f505efb921907cc8e86418da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167965
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d44b86964353cc2e65eba6c2e06529fd9b716cc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1686a72bcddf4f28d0510e02a1596baf5e6ebdc6
          - Reinstate screenshot for presentationdialog
            
            + Screenshot updated recently.
            + refactor
            
            Change-Id: I840eabe97d90c7725b44c63746a3f7bd8cad800b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167912
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-22  Jonathan Clark  <jonathan@libreoffice.org>  [ab0a4543cab77ae0c7c0a79feb8aebab71163dd7]

        tdf#124116 Correct Writer text shaping across formatting changes
        
        Previously, Writer performed shaping for each span of text separately.
        In certain situations, this caused incorrect glyph use, or incorrect
        glyph positioning. This change updates Writer so it will also consider
        neighboring text while performing shaping.
        
        This change resolves the outstanding duplicates filed against tdf#61444.
        As a side effect, this change also fixes tdf#134226.
        
        In addition to the shaping fix, this change implements rendering for
        individually-styled glyphs, which is required to fix tdf#71956. However,
        this change does not implement diacritic selection, which is also
        required for that issue.
        
        Change-Id: Iab4774ffaab5ad6113778c54d02cb260a70c1010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167699
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
        Tested-by: Jenkins

2024-05-22  Miklos Vajna  <vmiklos@collabora.com>  [d1ddd136a1b0e452492464d58715eaec144fd811]

        tdf#160984 sw continuous endnotes: fix the endnote container's top margin
        
        Comparing the Word vs Writer output for the bugdoc, the vertical
        position of the endnote text is not correct: the y pos should be larger
        than it is, see the red reference at e.g.
        <https://bug-attachments.documentfoundation.org/attachment.cgi?id=194265>.
        
        Seems this is caused by the different height of the rectangle around the
        endnote separator: the top margin is 124 twips in Writer, which is a
        hardcoded default from the SwPageFootnoteInfo ctor, while Word has this
        separator as a special character, inside a paragraph, which inherits the
        height of the default paragraph style.
        
        Fix the problem by extending sw::FootnoteSeparatorHeight() to also work
        from RES_POOLCOLL_STANDARD in the Word compat case. Note that it's not
        enough to take the font size (11pt in this case) from the paragraph
        style, we want to work with the real font, which knows the spacing
        between lines (15% in this case). SwFont::GetHeight() has this logic,
        it's also what e.g. SwTextFrame::FormatEmpty() uses.
        
        Note that footnotes have the same problem, but given that they grow from
        the bottom of the page, the text position was correct, even if the
        separator height is incorrect. Also, the separator line itself is not
        changed in this commit, we just make sure that the height is OK, so text
        below the line has the correct position.
        
        Change-Id: If1f4757908355abc81ee711de5ab9db4c751354c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167959
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-22  Dione Maddern  <dionemaddern@gmail.com>  [7ba662caf1c408dcf18a8624c707ce24d37d55de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 74121a4068a305b871e5aa5d0aada26012bced22
          - tdf#148587 Update How to get section for Summary slide and Expand slide
            
            In text/simpress/00/00000404.xhp:
            - Remove sections on Summary Slide and Expand slide because those options no longer appear in the "Insert" menu
            
            In text/simpress/00/slide_menu.xhp
            - Add updated howtoget information for Summary Slide and Expand Slide, including information for TabUI
            
            In text/simpress/01/03090000.xhp
            - Add variable tags to h1 so that the page can easily be linked from other help pages
            
            In text/simpress/01/04130000.xhp
            - Add variable tags to h1 so that the page can easily be linked from other help pages
            - Update embed link in howtoget section to link to updated instructions in source/text/simpress/main_slide.xhp
            - Add a related topics section
            
            In text/simpress/01/04140000.xhp:
            - Add variable tags to h1 so that the page can easily be linked from other help pages
            - Update embed link in howtoget section to link to updated instructions in source/text/simpress/main_slide.xhp
            - Add a Related Topics section
            
            In text/simpress/main_slide.xhp
            - Add variable tags to h1 so that the page can easily be linked from other help pages
            
            Change-Id: Icc67e3b4745aa1f70fab898436c4b28e64fec578
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167932
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ea31765aed87a67698a67e0f8920df16abe8e97e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 861553cf61b80a1fd90546561862ca3e4703603a
          - Remove exec bits on PNG files
            
            Change-Id: Ic902d3788d15cc5a3156a00e5836c1e114f37a4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167960
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [46b497f5462848c51c8dd204a45128f606425637]

        Drop unused ATTR_OPTIONS_SNAP
        
        after commit 563573068fe0835b1fa132d18b53f991be0e15a0
        
        Change-Id: Iafa5ec21cd833ed9b8ebbdaea03086f4fa1784c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167884
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebb1444a17d56acc93ffbb06b435065399991dd6]

        loplugin:ostr in sw/../dbui
        
        Change-Id: I0ccf6f61781d9104c82ec0acf7f10b5be47d6dc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [027881928b48c4ea030f5e807cb6bfd45ee977da]

        openldap: upgrade to 2.6.8
        
        Downloaded from https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.6.8.tgz
        
        Change-Id: Id071786e90ffa2756b1820dc3b59214c2f2faf6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167958
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ee802917bd37665df3fe4116eb31b2a9f6be494]

        Partially revert 860d11230d6 "sc: check GetActiveViewShell()"
        
        See https://gerrit.libreoffice.org/c/core/+/167923/comment/3b02cf2c_feea2a9f/
        
        Change-Id: I54f9609c934c5d56528fc4175462ff1d4deffaae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167951
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [aaf14d96cd9d2273e7828bfa3bd496fc9cb1d61e]

        curl: Upgrade to 8.8.0
        
        Downloaded from https://curl.se/download/curl-8.8.0.tar.xz
        
        Change-Id: Ib6ecbdb774f4d2643d8e848d8826704a51884eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167929
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2a2eb189c45b4eaf53bd2b5656185fa72512322]

        loplugin:ostr in sc/../Accessibility
        
        Change-Id: Ibf9981ee800054c10b663d9fc91602d326175a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [343ca5c8ae6f7216683c78b961816bf149f957a0]

        sfx2: bGlobalOnly is always false
        
        Change-Id: Iaba1a77ae0ac7537f1dbf05fa097b3235b36f64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167921
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-22  Michael Weghorn  <m.weghorn@posteo.de>  [554c06b2f66ff7c26df0ac29f89894fff89eecd6]

        sw: Change OSL_ENSURE -> assert
        
        This fixes my local Windows/MSVC build that previously
        failed like this:
        
            C:/tools/cygwin/home/user/development/git/libreoffice/sw/source/core/doc/tblrwcl.cxx(3187): error C2220: the following warning is treated as an error
            C:\tools\cygwin\home\user\development\git\libreoffice\sw\source\core\doc\tblrwcl.cxx(3105) : warning C6011: Dereferencing NULL pointer 'pLineFrame'. : Lines: 3031, 3033, 3034, 3037, 3038, 3039, 3040, 3042, 3044, 3046, 3049, 3061, 3063, 3083, 3084, 3085, 3086, 3093, 3094, 3098, 3100, 3102, 3103, 3104, 3105
            make[1]: *** [C:/tools/cygwin/home/user/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:338: C:/tools/cygwin/home/user/development/git/libreoffice/workdir/CxxObject/sw/source/core/doc/tblrwcl.o] Error 2
            make: *** [Makefile:294: build] Error 2
        
        Change-Id: I50faeba555d307ec27d1dccec7dbc3034c543830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167918
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-22  Miklos Vajna  <vmiklos@collabora.com>  [080afd6a345e5dffd924100b5a3ff9c028f5b094]

        Related: tdf#145972 sw images: fix rounding error in relative size calculation
        
        Open the bugdoc, see that the image is roughly half of the page width,
        right click, properties, UI shows that the width of the image is 5% of
        the width of the entire page. This only happens if tools -> options ->
        writer -> general sets the UI units to points, the default cm case is
        fine.
        
        This went wrong with commit 9e8712ed6f9fb5dbd971e352a5709bd45fadc74f (sw
        image dialog: fix fallback width/height for images with relative sizes,
        2022-03-17), because the layout size started to matter more after that
        commit. This lead to the nWidth !=
        m_xWidthED->get_value(FieldUnit::TWIP) check in SwFramePage::Init() to
        be true, because 11906 * 0.48 is 5714.88, so you got 5714 in the layout,
        but got 5715 with rounding in SwFramePage::Reset() (which tries to calc
        the page width based on the 48% and the fly width). And once we had that
        mismatch, we went down the wrong path.
        
        Fix the problem by using rtl::math::round() in SwFlyFrame::CalcRel(), so
        the relative width twips value is 5715 everywhere: once we have
        consisteny, the UI value is correct, too.
        
        Note that the original bugdoc needs more fixing, this just fixes the
        bugdoc where KeepRatio is false.
        
        Change-Id: I1e8782c95a0cf9d97375c36d41134735c01f3e46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167916
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-22  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [76941af9837406b1526b2f2d13c89df7a2023072]

        tdf#158110 - Paste special: Remove special ADDNOTES flag handling
        
        Remove special ADDNOTES flag handling and just add it to existing NOTE flag to ensure no content will be deleted. However, the check for empty cells needs to be improved.
        
        Change-Id: I44ae75aa3997a0b1041447106bc3c07146043351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167202
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-05-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [101b08fe1ec77ffe8c1a9b2b8f9f20884269a1ed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3ffed2bfd797c22fe28472898d2d9a72aa2ae41
          - Update screenshot for simpress/presentationdialog.ui
            
            Change-Id: Ie514503c603cd1c40917486a5f5c2096301a3f94
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167910
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-21  Pranam Lashkari  <lpranam@collabora.com>  [66f968242ecb17ea82d72ca6198aeec4aa865f05]

        sc: LOK: invalidate sheet geometry on row height changes
        
        sometimes if undo/redeo affected row heights (i.e: undo an autofill)
        sheet geometry was not updated in LOK
        
        Change-Id: I995d23752712f6baf3c348f6fe5fb292f7c9043b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167878
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit bb605f31f92eeeca292824931ef0e8d1db750702)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167828
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins

2024-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5529ada78fcc8fd0a556038bc54a7bb7c9e97fe3]

        Fix typo in code
        
        Change-Id: Ic416b58498274cbd49cbb0a5fea934bfbe356722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167901
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6f30afeb72e224a8f3f74ea745ab01e1891f0256]

        Fix typo
        
        Change-Id: I17f474cc3b749beccc6cce7a8175f46a1f2c646f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167801
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0a6f0d7ea70783b10f27c64977d5f34aeac1ef8a]

        Fix typo
        
        Change-Id: Id44f05e97f04bfd624f3fe12dc729659183963d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167800
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [1ff9bc004e5df7d0dfbd7e58c0cbaadf225fb68d]

        use SAL_RET_MAYBENULL in GetActiveViewShell()
        
        Change-Id: I739a9be7486978b19f34939c7d6d7bb2d1adbf77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167899
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [860d11230d67900238f97a06fd2ebd0262c16ae4]

        sc: check GetActiveViewShell()
        
        See the recently introduced
        https://crashreport.libreoffice.org/stats/crash_details/3da2dcd1-ca3e-409a-a665-dcb09d2a3ba0
        
        Change-Id: If6ddc71bc2946232d57d5fd8fd6029b45b19495f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167903
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-21  Leonard Sasse  <l.sasse@fz-juelich.de>  [6138f19537e8fc8a1207e9f210dab4257d9c6c84]

        tdf#158803 F821: remove unused variables and unused imports in librelogo/
        
        Change-Id: I105a72f07d91231aa9ec471701784838e07b0c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165579
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [26796cc201efc7862990b814887d73ef22d368bb]

        Fix typos in sparklines extended tips
        
        Change-Id: I96848ed20e9a6d3e2d18e07c5f781bb98ed72f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167902
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc456ccf9f81bd36216c199ab42fa2fe77c5e17c]

        loplugin:ostr in sc/qa
        
        Change-Id: If731102d69667eaaa088cf804a8c7563b24ded5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167893
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [441d8ed9be0e7f831b455a69b8688dcb79a8bc00]

        tdf#145735 avmedia qt: Use QtMultimedia for Qt 6 media playback
        
        Similar to the way that GTK 4's native facilities for
        video playback are used for the gtk4 VCL plugin, initially
        added in commit
        
                commit d0a527ec09516bc7215baf229adb90cd21ffa27a
                Author: Caolán McNamara <caolanm@redhat.com>
                Date:   Thu Feb 10 12:55:18 2022 +0000
        
                    first cut at using Gtk4 built in video playback
        
        , implement media playback using QtMultimedia for the
        Qt 6 based VCL plugins (qt6/kf6) via a new service
        "com.sun.star.comp.avmedia.Manager_Qt".
        
        Video playback with the mechanism used for qt5 no
        longer works with qt6, as "qwidget5videosink"
        that gets used on Wayland for qt5 wasn't ported
        to Qt 6 and is unmaintained, s. the commit message of
        
                commit 88d57cf241209ffec9eaed3e523942ab51af6db6
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Wed Sep 29 11:09:51 2021 +0200
        
                    qt6: Add a qt6 VCL plugin
        
        for more details. Additionally, this also doesn't work
        properly any more on X11/with the xcb Qt QPA platform, see
        tdf#145735 comment 7.
        
        Instead of using GStreamer directly, let Qt handle
        the low-level stuff by using the QtMultimedia module [1]
        instead.
        
        This adds a new dependency on QtMultimedia.
        For building, this requires installing the Qt 6 QtMultimedia
        development headers (e.g. package `qt6-multimedia-dev`
        on current Debian testing).
        
        Except for WASM, the use of QtMultimedia is enabled by
        default when building with autogen options `--enable-qt6`
        or `--enable-kf6`, but can explicitly be disabled using
        `--disable-qt6-multimedia`.
        
        In tests with the qt6 VCL plugin on Debian testing, with a
        sample presentation containing an embedded
        video, attachment 145517 from tdf#120452, video playback
        generally works for both, the xcb and the wayland
        Qt QPA platforms:
        
        * Video and audio are played as expected on the external
          screen in presentation mode when using the presenter
          console
        * Video and audio playback work in non-presentation
          mode by clicking on the video and using the controls
          in the Impress sidebar (play, pause,...).
        
        However, the following issues were observed with
        the current implementation:
        
        * There's an odd frame/margin around the video.
        * In non-presentation mode, the placeholder
          shown until the video gets started using the controls
          in the sidebar is just an "audio icon", not a frame
          from the actual video. (This might be related to the
          fact that `QtPlayer::createFrameGrabber` currently
          returns an empty reference.)
        * At least on Wayland (issue not observed with
          QT_QPA_PLATFORM=xcb so far), when using the presenter
          console,   video playback in the presenter console (i.e. on the
          non-presentation screen) is unreliable: The video
          sometimes shows, but sometimes doesn't. At least the
          (more important) one on the presentation screen was
          reliably shown in my tests, however.
        
        Tested with git dev versions of qtbase
        (as of commit 8d5e7d50d8dbf1ad79bd8ff9f6ef6028eba481c9),
        qtwayland (as of commit 6f0ebd916f176f6fbe35af28caeb52b62768ac94)
        and qtmultimedia (as of commit
        264b7e8d7d5683252102b5e5149685c8b8a70c2d).
        
        [1] https://doc.qt.io/qt-6/qtmultimedia-index.html
        
        Change-Id: I29c3c7ded01c61b49b192fa5c313d8a92c942185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167869
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-21  Dione Maddern  <dionemaddern@gmail.com>  [4316851ec8d2b44bbbcca84200f50eae91451e48]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bfc9b74f251bd2aca3605732c30b61bd6715a7eb
          - tdf#160382 Document new features in Slide Show Settings help page
            
            In text/simpress/01/06080000.xhp
            - Added additional index bookmark values to make the page easier to find.
            - Remove screenshot because it does not represent current dialog options
            - Updated the link to the embedded How to get section, to reflect changes to text/simpress/00/00000407.xhp.
            - Added information for the
              -  Live-mode slideshow editing
              -  Buttons size
              -  Enable insecure WiFi connections
              features.
            - Added a heading to the description of the Download App option.
            - Added Related Topics section.
            
            In text/simpress/00/00000407.xhp
            - Added TabUI instructions for accessing Slideshow Settings.
            - Created a new section called "slide_show_settings" to allow multiple paragraphs to be linked.
            
            In text/simpress/guide/presenter_console.xhp
            - Add variable tag to heading so that the page can be easily linked from other pages.
            
            Change-Id: I71a836cefd8f0aa176dfaec0d539f043b1e973c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167824
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6725ae0d7d6f2d677fbf62bc58bfd83c4418f485]

        loplugin:ostr in sw/qa/api
        
        Change-Id: Ib8ad745095eceb588e502c44644136d943e79013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167894
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-21  Heiko Tietze  <tietze.heiko@gmail.com>  [6ddb49bc32c534d196ff3913835aceb88cbc8dfc]

        Resolves tdf#160834 - Unclear meaning of "Ignore pieces of length"
        
        Access in the UI removed
        Find the options under ooO.Writer.Comparison.IgnoreLength and IgnorePieces
        
        Change-Id: Ic76277ba6838bf5cf858089303f4882bc9a7c2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167888
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-05-21  Julien Nabet  <serval2412@yahoo.fr>  [7da5bb1ff4a691fb5b55a4bccc0f6c87c9e17692]

        tdf#161190: fix crash when exporting spreadsheet as PDF...
        
        with "whole sheet export" option'
        
        See bt here:
        https://bug-attachments.documentfoundation.org/attachment.cgi?id=194240
        
        Change-Id: I453882be5c8bb761a722482f9c94a2b2bb5c7dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167890
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-05-21  Miklos Vajna  <vmiklos@collabora.com>  [f2ba39c5e7ae28a832e707667a0a61736f65ebda]

        svx: prefix members of SdrUndoDelPage
        
        See tdf#94879 for motivation.
        
        Change-Id: I6ef4ca1df66f22e4fb6a13a7b39ca0152484fd6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167883
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-21  Chris Mayo  <aklhfex@gmail.com>  [4dd9e8fd585210a31bd8a99630a4d958d794ab28]

        Fix bashism in configure tests for curl and libcmis
        
        When /bin/sh is dash:
        
        ./configure: 35165: test: yes: unexpected operator
        checking whether to enable breakpad... no
        ./configure: 35218: test: yes: unexpected operator
        
        Causing HAVE_FEATURE_CURL not to be set to 1 and build to fail:
        
        sw/source/ui/misc/translatelangselect.cxx:160:24: error: no member named 'TranslateDocumentCancellable' in namespace 'SwTranslateHelper'
          160 |     SwTranslateHelper::TranslateDocumentCancellable(m_rWrtSh, aConfig, m_bCancelTranslation);
              |     ~~~~~~~~~~~~~~~~~~~^
        
        Introduced in:
        
        5bf7c2fa5794 ("Fix --disable-curl build", 2023-09-14)
        
        Change-Id: Ifbc4bc1a7cde86101ff13b05ec7cee6836798605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167831
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-05-21  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [2e1350593c26a70408b3cf7d1bac2f2ff8309852]

        tdf#69724 Allow to change default bullet symbols in UI
        
        Change-Id: Ife700096fb55ebc752ae289398a36ee78b3e5ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167660
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-21  Hubert Figuière  <hub@collabora.com>  [09f23b8c6cd369b5d0594119f3df62941346a610]

        cool#9019: draw/impress: disable the Grid for now
        
        So that the grid isn't shown in the thumbnail.
        This will need to be reverted later for cool#7406
        
        Change-Id: I01fbc7ebc9e33a27fb866b7ea6dbaaac68ae8f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167872
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 41130a39ad68310a0136605cbced1f191396c456)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167826
        Tested-by: Jenkins

2024-05-21  Leonard Sasse  <l.sasse@fz-juelich.de>  [f97944cca2f64ce8cdf1d001b6ba9c751047d45a]

        tdf#158803 pyflakes F821: undefined name 'com' and remove bare except clauses
        
        Change-Id: Id116753a19a4fa5a29ad9a4f61f5ba3bf1ce95d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165451
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-21  Leonard Sasse  <l.sasse@fz-juelich.de>  [52b08068c90875ec5fd55ddea5662695216611b2]

        tdf#158803 compilerplugins: remove semicolons; improve membership checks
        
        Change-Id: Ifd5fdee23e5adba2b5a667f74c38ba6fb28f54b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165446
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [39f36dc445f917a5a263033f734a1f146728e9a5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f39dc88044b1f0c431b90458ff8ae606b05ec67
          - Fix typo
            
            Change-Id: Ia07532dd18408e39d03cfbc8d9125ba89f3e8a1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167889
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-05-21  Jaume Pujantell  <jaume.pujantell@collabora.com>  [c94a870f22a59bfce6ea828a0ea12b3ac567548d]

        lok: translate formula bar functions to each locale
        
        On calc the native formula symbols were loaded once on start-up and
        assumed to not change.
        
        This adds a map language to symbols when LOK is active and chooses
        the correct set of symbols on each call.
        
        Change-Id: I821fb3ad4a06d764399e3fdf4a2ec628909312db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167870
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
        (cherry picked from commit 421ef056cf5e991ae3072cd1acb5ef23aa7c780a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167825
        Tested-by: Jenkins

2024-05-21  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [708d619e32f251f06af8e8a057bf802627b81fbd]

        fix crash when push the Bullets button on the toolbar and then press the
        
        dropdown part of the button
        
        caused by commit I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4
        (tdf#161056 Show bullets used in document in bullets dropdown)
        
        Change-Id: I215d7cb677825821917a4fd8c498deaaab9fc9b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167838
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-05-21  Miklos Vajna  <vmiklos@collabora.com>  [1ae5ea3f78cca11ba18f2dd1a06f875263336a3b]

        tdf#160984 sw continuous endnotes: enable DOCX import
        
        This was working for DOC already.
        
        For DOCX, this was already enabled once with commit
        f9982c24066d6dd2f938cc20176af0f196bc018f (tdf#58521 DOCX import: enable
        ContinuousEndnotes compat flag, 2021-07-13), but then it was reverted
        later with commit commit eeda1b35a6e87d5349545464da33d997c52f15e3
        (Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag",
        2021-08-10), because of tdf#143456.
        
        Enable it again, now that the section-based layout seems good enough to
        handle larger number of endnotes, e.g. the 48 endnotes from tdf#143456.
        
        Change-Id: Id221f31f9208e84db2c358546d4d6ceea991b6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167881
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-21  Leonard Sasse  <l.sasse@fz-juelich.de>  [71f3be3bee2e8a07f85594c02a9b44627b219e95]

        tdf#158803 Remove E999: SyntaxError's and some other minor edits
        
        Change-Id: I32d75eb03b1f1fd011dcbc6950bf74800446a422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165464
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [575ab78504c5082590970812e723ec01299787a2]

        qt a11y: Don't leak QAccessibleEvent
        
        Create the `QAccessibleEvent`s passed to
        `QAccessible::updateAccessibility` as local
        stack variables instead of on the heap, to not leak
        them, as `QAccessible::updateAccessibility` does
        not take over ownership, i.e. doesn't delete them.
        
        This is also what the example in the Qt doc [1]
        does.
        
        This fixes leaks reported by Valgrind, for example:
        
            ==104242== 416 bytes in 13 blocks are definitely lost in loss record 23,612 of 27,514
            ==104242==    at 0x4840F83: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
            ==104242==    by 0x186F6884: QtAccessibleEventListener::HandleStateChangedEvent(QAccessibleInterface*, com::sun::star::accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:144)
            ==104242==    by 0x186F8478: QtAccessibleEventListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject const&) (QtAccessibleEventListener.cxx:401)
            ==104242==    by 0x61B2756: comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun::star::accessibility::AccessibleEventObject const&) (accessibleeventnotifier.cxx:256)
            ==104242==    by 0x61ADB50: comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&, int) (accessiblecomponenthelper.cxx:127)
            ==104242==    by 0xBAA46FB: VCLXAccessibleComponent::ProcessWindowChildEvent(VclWindowEvent const&) (vclxaccessiblecomponent.cxx:173)
            ==104242==    by 0xBAA4285: VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent&) (vclxaccessiblecomponent.cxx:124)
            ==104242==    by 0xBAA3BBC: VCLXAccessibleComponent::LinkStubWindowChildEventListener(void*, VclWindowEvent&) (vclxaccessiblecomponent.cxx:114)
            ==104242==    by 0xD56C687: Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const (link.hxx:111)
            ==104242==    by 0xD56977E: vcl::Window::CallEventListeners(VclEventId, void*) (event.cxx:296)
            ==104242==    by 0xD6C83A1: vcl::Window::ImplSetReallyVisible() (window.cxx:1328)
            ==104242==    by 0xD6C846C: vcl::Window::ImplSetReallyVisible() (window.cxx:1344)
        
        [1] https://doc.qt.io/qt-6/accessible-qwidget.html
        
        Change-Id: I82af810f0c618ffd5c5e4c8f568f4b4358df5900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167862
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [ad4f75bdb49c28de626cce10da0bb7554a24681d]

        qt a11y: Use "r" prefix for reference
        
        Change-Id: Icf3021872321bc1ea23c09497008b5fc401a3591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167861
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-21  Jaume Pujantell  <jaume.pujantell@collabora.com>  [e39c57022afbe84601f58ef5bae0f12e69d33fc5]

        writerfilter: avoid infinit loop when resolving embeddings on docx
        
        If a docx file contains a loop on the .rels files for headers and/or footers
        the code would enter an infinite recursion while looking for embeddings.
        
        Change-Id: I2122fd6b1677812f561e96a9511a61b0e938e94a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167784
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ae798781ef4df7a1fdef13af0bc459bf4f6e7b4c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2662257ca9594a0c5fc1371c8e397f562c726f8c
          - tdf#159872 UNIQUE function help page
            
            - Attempt to address issues raised by Regina.
            
            Change-Id: I85892d15a5bf8bb798f733cd4fddc309e5906894
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167755
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [d573e2ae17d2ff589ec7adc0dddf6a78db4cc93a]

        loplugin:ostr in various
        
        Change-Id: I9f399b3752da9df930e0647536ffcd4e82beb1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167856
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [41c04ceb3b1b14c3c99ede86524df8f3de4f5daa]

        use more concrete UNO types in sw
        
        Change-Id: I3cf017e74e7cc9902486d6dba1d89f70c47c978a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167864
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b9ff63cf448da9b49ca9485b276c7ecc1023a23]

        remove hole in SwFrameAreaDefinition struct
        
        since this is used in various performance sensitive places
        
        Change-Id: Ibdce6bd0de458a5a970654a88b984aff49210ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167863
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [9851311055da1a050405f7bc0b7e12ad7cff3cbe]

        Drop remnants of a long-obsolete hack
        
        In commits 6dd5a96e1e3a6bb307f8f2d43cce2b5f2cde659d
        (INTEGRATION: CWS unopkg1 (1.1.2); FILE ADDED, 2004-04-14),
        19a10039a59002b68291e7f200f85fd962592d75 (INTEGRATION: CWS
        unopkg2 (1.2.4); FILE MERGED, 2004-06-11), and
        886715b6b6f30fed36d50a4ddf84ed5984f4f993 (INTEGRATION: CWS
        scriptingf7 (1.3.4); FILE MERGED, 2004-07-23), a hack was
        introduced to allow empty substorages.
        
        Later, in commits 0d6b24a721f05fedef9cd32b596a0fec71a5089f
        (INTEGRATION: CWS tdoc3 (1.7.24); FILE MERGED, 2004-11-09)
        and 5f4d17724f7323077191114486edff8cdce05b2f (INTEGRATION:
        CWS scriptingf9 (1.6.2); FILE MERGED, 2004-12-23), that
        hack was removed, but one place was kept, which is removed
        now.
        
        Change-Id: Iaaf46421ddbe942878ebe17ca1e585be9db5999d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167823
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-20  Dione Maddern  <dionemaddern@gmail.com>  [e503518c14cfa2f1fda709db017d6e0de3f39141]

        tdf#160969 Update extended tip for Comment Indicator
        
        In sc/uiconfig/scalc/ui/tpviewpage.ui
        - Updated extended tip for "Comment Indicator" to reflect the current appearance of the Tools > Options> Scalc > View dialog
        
        Change-Id: Iff0d7b0c05d54099818816e6146bc678d06a1e32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167867
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-05-20  Dione Maddern  <dionemaddern@gmail.com>  [6a3273ddf6a754b14d47448b8bf9cd335e7de502]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cbb8c2d8d957f8a4729b32ac098c8a88f72d797a
          - tdf#160909 Update help page for Scalc View Options
            
            In text/shared/optionen/01060100.xhp
            - Added index bookmarks for new features
            - Removed old comment.
            - Updated "How to get" section to reflect current menu options.
            - Updated help page to cover new options:
              - Pointer
              - Comment authorship
              - Column/Row highlighting
              - Edit cell highlighting
              - Summary on search
            - Removed the section describing the "Color" option because that option no longer appears in the "View" dialog.
            
            In text/shared/optionen/01060000.xhp
            - Added link and variable tags to the title, so that the page can be easily linked from other pages.
            
            Change-Id: Ib738453b33efcded574576052b7add3cb6bb25c0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167463
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-20  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [625c1507712adedb85a276921aa6aacbbd1e142d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 975d11c1c7bc9f57a7bce5ab8901ea1ec9f29d5c
          - related tdf#69192 document --show=slide_number option
            
            Change-Id: I9944a6d4dbaa7ec7f5283c677063cac74bc7e80d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167614
            Reviewed-by: Justin Luth <jluth@mail.com>
            Tested-by: Jenkins
            
2024-05-20  Justin Luth  <justin.luth@collabora.com>  [3d4a3b30aea603b98da447ec6587b5d3eb20da66]

        tdf#69192 fix cmdlinehelp: --show[=slide_number], etc.
        
        I had skimmed the help file earlier, and concluded that { }
        are used elsewhere to indicate optional paramaters.
        However, there is --quickstart[=no], and -env:<VAR>[=<VALUE>]
        which exactly match my optional addition.
        
        Thanks Stéphane for pointing this out.
        Also included are some other changes we made
        to clarify the help wording in general,
        so the documentation and the cmdline help are in sync.
        
        We dropped
            Files other than Impress documents are opened in
            default mode, regardless of previous mode.
        because:
        -from an initial reading it doesn't convey any useful meaning.
        -searching for other uses of "mode" in the file suggests it means
         that prior --print/--convert-to/--view modes
         no longer apply. This override of prior modes is true for all modes,
         but only this argument tries to spell this out.
        -it seems rather inconceivable that any user would attempt
         to mix --show with any other arguments or more than one file.
        
        Change-Id: I191e572506cf2b39ed6c9ff4ebaf66f258a176a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167633
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-20  Justin Luth  <justin.luth@collabora.com>  [382801ee5368a4c3d59931450dec0d2d9f369285]

        documentation: list format placeholder has been "%1%" since LO 7.2
        
        Vasily's commit aa5c6d127559912ad60a63fbd972b78fb8f9691b
            new ODF numbered list parameter loext:num-list-format
        
            Internal LO format for list format is changed:
            instead of placeholders like %1, %2, etc
            we right now use %1%, %2%... Reason: for ODT documents,
            having more than 9 levels there is ambiguity in "%10":
            it is "%1" followed by "0" suffix, or "%10"?
        
        It was introduced in 6.4.5 for DOCX support with
        Vasily's commit 7459b9ecb54a298f02d19089620149718f8d8d48
            tdf#116883: sw: support for lists level format string
        
        Change-Id: I5962ed04c555356c6a3fc05ab7e036975d7eee40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167833
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-20  Justin Luth  <justin.luth@collabora.com>  [a94db2e3b6e130fe90de31cbd909ce54f5450601]

        tdf#156105 sw: make SvxNumberFormat GetPrefix/Suffix more trustworthy
        
        As soon as SetPrefix or SetSuffix are called,
        any partially formed sListFormat is invalid (unless nothing changed).
        
        ListFormat creates sPrefix/sSuffix as a convenience/compat item,
        and changing it directly is NOT reflected in the sListFormat itself.
        Trying to keep them in sync would be very complicated.
        
        Any process that uses these functions OUGHT TO be doing it as
        building blocks to eventually call SetListFormat(prefix, suffix, lvl),
        at which point a proper sListFormat will be created.
        
        Change-Id: I05f681c812ea5207cb8127b30dafbd543ffea219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167832
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2024-05-20  Justin Luth  <justin.luth@collabora.com>  [65e226aff6a946ae4884b9f5afdccaa1c745bcd4]

        tdf#156105 sw: trust SvxNumberFormat GetPrefix/GetSuffix
        
        After LO 7.4 (backported to 7.2.5) created this
        function that manually identifies the Prefix/Suffix,
        there was some work done to ensure
        GetPrefix and GetSuffix were trustworthy in
        LO 7.5's commit 835cda561217bd8c53af2de927158dd5712b06c0
        Author: Justin Luth on Tue Aug 2 13:30:31 2022 -0400
            related tdf#150197: use SetListFormat or SetPrefix/Suffix
            GetListFormat DEPENDS on having managed prefix/suffix itself...
        
        So, lets make sure we use and fix these functions in only one place.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf156105_percentSuffix
        
        Change-Id: I44c021a200ba45960e39983087c6af268751fbc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167792
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
        Tested-by: Jenkins

2024-05-20  Justin Luth  <justin.luth@collabora.com>  [047e3f62901ae89da30bf1367218104e57439f70]

        related tdf#156105 sw UI: recognize '%' in numbering prefix/suffix
        
        bug 156105's listWithPercents.odt is an example of a
        properly defined ListFormat which contains a percent symbol
        in the prefix and suffix, which looked fine in the document itself,
        but was cut off short in the UI.
        
        sw/qa/extras/ooxmlexport/data/tdf116883.docx is also an example,
        which can be seen if you reduce the first entry to level 1
        instead of level 2.
        Level 1 is improperly defined as "1%>". This is invalid formatting,
        so the entire thing should be considered a suffix.
        MS Word also considers it to be a suffix.
        
        This code segment still isn't completely comprehensive
        because it won't properly parse "%1xyz%1%." and "%1xyz%10%."
        but I'm losing patience.
        
        There is still a potential problem with the
        nInclUpperLevels calculation in case
        a '%' is used as an in-between separator,
        but that seems extremely theoretical and irrelevant to me.
        IIUC, the main impact is that it shows some extra dots
        in the bullets and numbering UI preview.
        
        Change-Id: Ic1b8fbda62917ad4c7b88bf4fff136d72242f977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167782
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
        Tested-by: Jenkins

2024-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [02c01942328bd40183a61c054c00d8b292f9dfd0]

        update language-subtag-registry to 2024-05-16
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar cvjf language-subtag-registry-2024-05-16.tar.bz data/language-subtag-registry
        
        Change-Id: I1070881fac9d88508e58715c9a87d547ddf86a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167860
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [267f1f65173c980d582e1e7e8c20f829509f0f4b]

        Fix typo
        
        Change-Id: I4ba7595b39be27161c333f8731ec4b0b35dab50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167852
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9487549d2a0ed5ed3ff9632cc05baab5e0f693db]

        Fix typo
        
        Change-Id: I439e80659a6e4aeba9c3f35decb0e2c7a8c87eeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167851
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-20  Michael Weghorn  <m.weghorn@posteo.de>  [ba41718095a790e2a39d569f5cdd9006c5169545]

        avmediagtk: Use gb_Library_set_include for GTK4_CFLAGS
        
        In the same way that `vcl/Library_vclplug_gtk4.mk` does
        it, set the `GTK4_CFLAGS` (which have the includes) via
        `gb_Library_set_include`, not `gb_Library_add_cxxflags`.
        
        This makes sure that they end up in the `INCLUDE`
        section in `workdir/GbuildToJson/Library/libavmediagtk.so`
        and thus end up in the IDE integrations as includes,
        which makes Qt Creator's Clang Code Model  find them
        instead of showing an error
        ("gtkplayer.cxx:28:10: 'gtk/gtk.h' file not found").
        
        See also this similar commit for more details:
        
            commit 6a53832080cf201e960113de8e1887d99e857606
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 17 15:35:58 2018 +0100
        
                Use 'gb_Library_set_include' for GTK3_CFLAGS
        
        Change-Id: I5ef01aff32073d37b8add0b2250402ccaa48b2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167857
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a602ed852b872f87893169062ec47041e013fb9]

        loplugin:ostr in sc/.../vba
        
        Change-Id: Ifdf0ebba617432f49e2c14c8a52c495dc1c6a36a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167853
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [9312f954b6d636f232a72e35aa2767e450690793]

        loplugin:ostr in sw/.../access
        
        Change-Id: Ib859d48d62ffcb9d82d3c63cc778430f45fe1d1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167854
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b0b0164939e0350f4dced5a6f136b1cec9f4482]

        don't need -I ... YaccTarget/connectivity/source/parse in forms
        
        since:
        
        commit f0c8312bc6630ed64f174acc6f65bb5172765951
        Date:   Sat Feb 1 22:47:11 2020 +0100
        
            tdf#42949 Fix IWYU warnings in forms/
        
        Change-Id: I77835488ef0b19d4c271ad39018138cc371a352d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167849
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e3bd3c7e3178dc091fd002628f052666b4db3be6]

        Fix typo
        
        Change-Id: I10d05b41028df776713db37d60e688d4f04bb739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167774
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eadcbef8b30da2704a8bdc9dc0c11b8db258b13e]

        Fix typo
        
        Change-Id: I22cd12c51d91bd7620bca29227871b3081813a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167776
        Reviewed-by:   <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-05-20  HakimOttey  <hakimotteybusiness@gmail.com>  [9dad7c0f1095e85ad40ad874215f1051137b0347]

        tdf#147906 implement hypot function for s1 x s1 + s2 x s2 statements
        
        Change-Id: I50a2f4cf7738ee3797723929fb6840d2633c882c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166814
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-20  HakimOttey  <hakimotteybusiness@gmail.com>  [ad3f86880bd6f5a0800a2820177715dc88c13a3c]

        Change for loop to have getAccessibleChildCount in accessibletabbar
        
        Change-Id: Ic020b1cd36abe2c568a119dfd400c718dc9de452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166989
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0702a3f17c1fbd1b8ffb9ca0b275943e1a1f442]

        Resolves: tdf#151382 we want to save the FN_KEEP_ASPECT_RATIO state
        
        and not if it is implied to be toggled on by SwFormatFrameSize::SYNCED
        in which case on "ok" FN_KEEP_ASPECT_RATIO is set from the ui state
        
        so both tdf#151382 and tdf132591 work
        
        Change-Id: I039de0e8f0f9adcc3c02f0e07c12d83cd807887b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167845
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-19  Eike Rathke  <erack@redhat.com>  [d4ae5abb4d00cc8adb3c45a9410fc71e56211c46]

        Resolves: tdf#160804 sc: ResizeMatrix: Use document grammar
        
        API grammar (old GRAM_PODF_A1) here was always wrong and could
        never had matched the formula string obtained from the document,
        but in earlier days array separators weren't configurable so this
        may have worked accidentally.. Likely GRAM_PODF_A1 was introduced
        being confused by existance of older bApi parameter that never was
        true though and got eliminated later.
        
        Change-Id: Ie77ad4047c21d999bea1ff97c7c2b451f01121eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167844
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c5fb86f91c3d799cb3817706a5c9a344939a4f1e]

        Resolves: tdf#157453 support FM_PROP_LINECOUNT for combobox dropdow rows
        
        Change-Id: I3d18ed505c2eea7305903f9a476c332db0148113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [445ee505b63686161962abfe7a2aaafe8a03b4be]

        cid#1598293 silence Unchecked return value
        
        and
        
        cid#1598292 Unchecked return value
        
        Change-Id: I9880932b8fb2340ec122c907aea0374881238283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e36bbd142ea80969c15f384759102d8175dedc3]

        cid#1598236 silence Unchecked return value
        
        Change-Id: Id5dfed646336847607df0bd2fd10d345ac8ed64e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-19  Mike Kaganski  <mike.kaganski@collabora.com>  [bb5740bb4c79c6c9507d4dc127e9f4bac78afc2f]

        tdf#161172: Also record history for !bChangeOfListStyleAtParagraph
        
        Change-Id: I6443d7ef76a27ac3ab75f88edd271a8b36e06c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167839
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-19  Khaled Hosny  <khaled@libreoffice.org>  [44f2bc12779645bce1000289caf9c66804ecb14e]

        tdf#160884: Apply scale to position of embedded images in Type 3 fonts
        
        Regression from:
        
        commit bc3f6c3a47411a3b5dafadca4e5c55cd24e30662
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Tue Aug 22 10:47:33 2023 +0300
        
            tdf#155610: Workaround Acrobat bug with Type 3 fonts and unusual UPEM
        
        Change-Id: I5e352292268d19fb8348a038d251f2d395a0be46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167830
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Tested-by: Jenkins

2024-05-19  Printf Debugging  <printfdebugging@gmail.com>  [cc389f64a500fde75a632173cba9b9e1ee5abb86]

        tdf#150082 tdf#161141 fix typecasting error in Makefile
        
        In patch https://gerrit.libreoffice.org/c/core/+/167057 , cast
        to st_mysql_client_plugin instead of st_mysql_client_plugin_AUTHENTICATION
        
        Change-Id: I76e0717eb3fe5e665c262a33852908c4b6b38ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167806
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-19  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [12d4e47155a52e17a5cc980e1ac41c16285430b3]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 7272a82714ca91947b4573c09bce4938861a9877
          - Updated the English dictionaries: GB+ZA (2024.05.01)
            
            Change-Id: Ie9586a0ff5a823893e059c0190f9239548448173
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/167028
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            Tested-by: Aron Budea <aron.budea@collabora.com>
            
2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e23cac5767c164b93491d46deef039409ea286c]

        Resolves: tdf#161057 draw/impress auto font color not updated on theme change
        
        Change-Id: Id3d02c38e3bbda34f65f5623fff1a5f39238e46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167803
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64557ef9fa57507455f196dd3c96e8a25be64c53]

        cid#1598235 Uninitialized pointer field
        
        Change-Id: I8c403a0bcfa56e58fdf12cb045c98b2087889235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167794
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [551c8230b495e8c0e0502b73445f6edd1510633e]

        use more concrete UNO type in sw/../writerfilter
        
        Change-Id: I41f06a26c226894e7e9aa4475b6f02d5b67f28dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167790
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [29ec8099d078182ea461e278c13d4ab869ae3cd9]

        Resolves: tdf#161133 read-only widget should have deactivated calendar
        
        a problem since:
        
        commit 6e7e19d9c300dbdd279789b09f94781e946fad52
        Date:   Wed Jul 15 12:10:32 2020 +0100
        
            weld DateControl
        
        Change-Id: I367c4237903655ad02c0c4af70ae0383b8a89f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167802
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0902472462334d76fb3773de7e769590603c0d3]

        cid#1598237 Uncaught exception
        
        Change-Id: Iab0a585048d028fda27a8b3edaad666edd0f55b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-18  Mike Kaganski  <mike.kaganski@collabora.com>  [60600b5bc07487a5e31f643029357211d70c0481]

        WaE: Dereferencing NULL pointer
        
         C:/lo/core/vcl/win/gdi/salprn.cxx(180): error C2220: the following warning is treated as an error
         C:\lo\core\vcl\win\gdi\salprn.cxx(172): warning C6011: Dereferencing NULL pointer 'pWinInfo4'. : Lines: 160, 161, 162, 163, 164, 166, 167, 169, 171, 172
        
        Change-Id: Id20f4bc308259a706cc55fc8331a5119b2172a14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167807
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b2dc515e2a3c8420c7f39c0b4396632c2086126a]

        Related: tdf#146326 restore correct focus when on submenu launched
        
        we still "cancel" a submenu if it never gets around to getting launched
        so at least set the restore focus wiget to where we initially grab focus.
        
        Change-Id: Ida157823a282d08ca908c20f0135db61881adb7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167798
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-18  Michael Meeks  <michael.meeks@collabora.com>  [e2aab0d02e7be66881f2ac0f08b6ac5007f65648]

        lok: dump more SfxViewShell state, and LOK notifier state on Windows.
        
        This should help to associate the right view-ids, with the right
        windows, and help to catch any stray / lingering windows from closed
        sessions - hopefully.
        
        Change-Id: I197a3280d5d2aeddd356ee037c51e4887f43278b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167765
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8d979fae0c435b820302c76fcfdc2642b4820360)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167684
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1ef9379fd9679775eadeecc598aa8087d09bb77]

        cool#8570 single-element cache in MsLangId::getScriptType
        
        this method is hit pretty hard, so try a single element cache
        
        Change-Id: I7c9f9285037a181ee24fbdf04cabc15b40a2ff03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167781
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 18102e3d7f832b8d5e445e427b55654f5bfd30b0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167687
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-18  kubak  <kuba@openoffice.com.pl>  [8d1b7585fb019ea9f6f93be6a9b21cf8597fbfa5]

        tdf#115357: Set Start Menu folder under Windows to \LibreOffice\
        
        Enhancement request.
        
        Change-Id: I128520432d33bd900d4385395f28a32d181485cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167141
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-18  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [563573068fe0835b1fa132d18b53f991be0e15a0]

        Drop now unused SdOptionsSnap, SdOptionsSnapItem classes
        
        Change-Id: Ifa2a7b7447e3659ea331ca4c3ec5c05dcc9a5841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167542
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe599b2e081aa671d19ccbcea922c201f66eb955]

        drop SAL_RET_MAYBENULL from bodies
        
        looks like we can get away without it and its tidier for us
        if we don't need to do it
        
        Change-Id: I29a68724a0cd2f33367c700b11c0d40397f607cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167788
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-18  Mike Kaganski  <mike.kaganski@collabora.com>  [2092df2a9044f1c2ae4379f48a3201e5867575a8]

        tdf#161154: pass "scaling is done externally" information down the stack
        
        VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D does the
        scaling, taking into account the font scaling. Before commit
        8557ea84c9336ba8061246f1f46ddb6e02f413a1, D2DWriteTextOutRenderer was
        doing own scaling in addition, but it seems that it somehow didn't
        affect the result much. The said commit removed the scalng from
        D2DWriteTextOutRenderer. As tdf#160901 demonstrated, the scaling is
        necessary in different code paths - and it turns out, that we need to
        know, if the caller does its own scaling or not, to make a decision,
        if the scaling should be fone in D2DWriteTextOutRenderer.
        
        This hack passes this from VclProcessor2D to D2DWriteTextOutRenderer
        through OutputDevice. Thanks to Miklos for the isea. I still don't
        understand, why all this seemingly doesn't affect other renderers.
        
        Change-Id: I001036f4574898b8e7606652525638df43c35240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167786
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [2f4103da5625a9b90eb41d5c767a248a8d0b4255]

        tdf#160565 tdf#145735 qt: Avoid native window handles for Qt 6
        
        Similar to the tdf#122293 scenario with Qt 5 on Wayland,
        using native windows causes unresponsive UI even with
        the xcb Qt QPA plugin when using Qt 6.
        
        Therefore, don't call `QWidget::winId()` at all when
        using Qt 6, but just refuse to resolve a native window
        handle, the same way that is already done here for the
        wayland Qt QPA plugin with qt5.
        
        Add a comment based on the one originally added with
        
            commit 0e3c3b842e14b9646d3697cf1266be21359e0f13
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 11 21:31:33 2019 +0200
        
                tdf#122293 qt5: Use "alien widgets" by default on Wayland
        
        that was later dropped during a refactoring.
        
        This code path is triggered when trying to resolve the
        parent window for a file picker (s. `QtFilePicker::initialize`).
        In a quick test in a KDE Plasma 5 Wayland session on Debian testing,
        the modality behavior was unchanged with or without this change in
        place:
        
        * With qt6 xcb, the main window nicely gets grayed out and is
          unresponsive while the file dialog gets shown  when using
          e.g. "File" -> "Open" in Writer.
        
        * With qt6 wayland, the main window is not grayed out and looks
          more "active" still, but doesn't actually accept keyboard
          or mouse input.
        
        This is basically the same in other Qt/KDE applications, e.g.
        a self-compiled Kate from git master, so not LO-specific.
        
        If resolving the parent for the file picker turns out to be necessary,
        maybe something similar to what commit
        
            commit 3ff4800fe400de916c97f587322104af06cc0879
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Wed Apr 4 10:22:34 2018 +0100
        
                weld SvInsertOleDlg
        
                and
        
                weld SfxInsertFloatingFrameDialog
        
                and smuggle in the parent widget for the Gtk File dialog via
                an XWindow interface
        
        did for gtk3 might be worth looking into.
        
        However, I can at least not reproduce issues like the one described
        for gtk3 in
        
            commit 203d96787969f707c78101be18d51b44ace98f93
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Mon Jun 21 13:01:52 2021 +0100
        
                give folderpicker an optional parent
        
                so, like a file picker, it can make its parent modal while its
                operating. Otherwise its possible to interact with the parent dialog in
                undesirable ways, e.g. file, export as, export as epub, the folder
                picker of 'media directory'
        
        with the qt6 VCL plugin even with this commit in place.
        
        Another scenario relying on a native window handle is video
        playback with GStreamer's x11 video sink.
        
        That still works for qt5 with the xcb plugin as the handle is
        still returned for that one.
        
        For qt6 with the xcb plugin, that didn't work properly
        without this commit either (at least not in my tests with
        current qtbase dev as of commit
        70a2e7f32b9f9ce19d1538f14fbde7b0d1e77ffd), s.
        tdf#145735 comment 7.
        It's now broken a different way than before
        (extra windows show up instead of no video being shown).
        This will be further tracked together with a solution for
        Wayland in tdf#125219.
        
        As a side note, forcing native windows for everything
        using `QT_USE_NATIVE_WINDOWS=1` as described at [1]
        causes more sever brokenness with the qt6 xcb plugin
        (mostly black window in Writer instead of showing the
        actual content).
        
        [1] https://doc.qt.io/qt-6/qwidget.html#native-widgets-vs-alien-widgets
        
        Change-Id: I9718c680bd8bc4ff0574f171403d965c1beac781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167783
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [12f51f079a7ef3a0f2cc7a9942835de810d4e943]

        qt: Run QtFrame::SetWindowState in main thread
        
        Fixes this crash/assertion seen when starting Writer with
        the qt6 VCL plugin with a fresh user profile with qtbase debug
        build (as of commit 70a2e7f32b9f9ce19d1538f14fbde7b0d1e77ffd):
        
            ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread 0x0x7fff9c454020. Receiver 'QtMainWindowClassWindow' (of type 'QWidgetWindow') was created in thread 0x0x55555560dc50", file /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 547
        
            Thread 19 "soffice.bin" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fffada006c0 (LWP 10947)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a6b7f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff78584e2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78414ed in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe34f95c9 in qAbort() () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:49
            #5  0x00007fffe350d459 in qt_message_fatal<QString&>(QtMsgType, QMessageLogContext const&, QString&) (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2112
            #6  0x00007fffe35063e6 in qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *)
                (msgType=QtFatalMsg, context=..., msg=0x7fffe3b8afa8 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fffad9fb108) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:380
            #7  0x00007fffe35084b1 in QMessageLogger::fatal(char const*, ...) const (this=0x7fffad9fb350, msg=0x7fffe3b8afa8 "ASSERT failure in %s: \"%s\", file %s, line %d")
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:880
            #8  0x00007fffe34f969c in qt_assert_x(char const*, char const*, char const*, int)
                (where=0x7fffe3bae469 "QCoreApplication::sendEvent", what=0x7fff9cd289a0 "Cannot send events to objects owned by a different thread. Current thread 0x0x7fff9c454020. Receiver 'QtMainWindowClassWindow' (of type 'QWidgetWindow') was created in thread 0x0x55555560dc50", file=0x7fffe3bae098 "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=547) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:114
            #9  0x00007fffe35f54e6 in QCoreApplicationPrivate::checkReceiverThread(QObject*) (receiver=0x55555bb8b4a0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:547
            #10 0x00007fffe15a786e in QApplication::notify(QObject*, QEvent*) (this=0x55555560d9d0, receiver=0x55555bb8b4a0, e=0x7fffad9fb7f0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2580
            #11 0x00007fffe35f68be in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55555bb8b4a0, event=0x7fffad9fb7f0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1154
            #12 0x00007fffe35f7677 in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55555bb8b4a0, event=0x7fffad9fb7f0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1598
            #13 0x00007fffe24f6299 in QWindowPrivate::create(bool) (this=0x5555569bd9a0, recursive=false) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:589
            #14 0x00007fffe24f6759 in QWindow::create() (this=0x55555bb8b4a0) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:720
            #15 0x00007fffe1643f45 in QWidgetPrivate::create() (this=0x55555b24c140) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1341
            #16 0x00007fffe16433c3 in QWidget::create(unsigned long long, bool, bool) (this=0x5555572554a0, window=0, initializeWindow=true, destroyOldWindow=true) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:1206
            #17 0x00007fffe1649dd5 in QWidget::setWindowState(QFlags<Qt::WindowState>) (this=0x5555572554a0, newstate=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:2946
            #18 0x00007fffe4235db6 in QtFrame::SetWindowStateImpl(QFlags<Qt::WindowState>) (this=0x55555bba8cf0, eState=...) at vcl/qt6/../qt5/QtFrame.cxx:340
            #19 0x00007fffe4237fc0 in QtFrame::SetWindowState(vcl::WindowData const*) (this=0x55555bba8cf0, pState=0x7fffad9fbdc0) at vcl/qt6/../qt5/QtFrame.cxx:677
            #20 0x00007fffee0a4c63 in SystemWindow::SetWindowState(vcl::WindowData const&) (this=0x7fff9d689d50, rData=...) at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:708
            #21 0x00007fffee0a5802 in SystemWindow::SetWindowState(std::basic_string_view<char16_t, std::char_traits<char16_t> >) (this=0x7fff9d689d50, rStr=u",,,;4;") at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:840
            #22 0x00007ffff4ddc4c4 in framework::LoadEnv::impl_applyPersistentWindowState(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&) (this=0x7fffad9fcbb8, xWindow=uno::Reference to (VCLXTopWindow *) 0x7fff9c003810)
                at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:1809
            #23 0x00007ffff4dd6f5b in framework::LoadEnv::impl_loadContent() (this=0x7fffad9fcbb8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:1081
            #24 0x00007ffff4dd48e4 in framework::LoadEnv::start() (this=0x7fffad9fcbb8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:412
            #25 0x00007ffff4dd21b2 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures)
                (this=0x7fffad9fcbb8, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", lMediaDescriptor=uno::Sequence of length 1 = {...}, xBaseFrame=uno::Reference to (framework::Desktop *) 0x5555569d5c68, sTarget="_blank", nSearchFlags=0, eFeature=LoadEnvFeatures::NONE) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:308
            #26 0x00007ffff4dd0998 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
                (xLoader=uno::Reference to (framework::Desktop *) 0x5555569d5c78, xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x555555623d38, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", sTarget="_blank", nSearchFlags=0, lArgs=uno::Sequence of length 1 = {...}) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:168
            #27 0x00007ffff4e06a3f in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
                (this=0x5555569d5c00, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", sTargetFrameName="_blank", nSearchFlags=0, lArguments=uno::Sequence of length 1 = {...})
                at /home/michi/development/git/libreoffice/framework/source/services/desktop.cxx:592
            #28 0x00007ffff4e06b34 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #29 0x00007ffff7ba9147 in desktop::testOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&, rtl::OUString const&)
                (xDesktop=uno::Reference to (framework::Desktop *) 0x5555569d5c58, rURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods")
                at /home/michi/development/git/libreoffice/desktop/source/app/opencl.cxx:132
            #30 0x00007ffff7ba7f54 in desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&) (xDesktop=uno::Reference to (framework::Desktop *) 0x5555569d5c58)
                at /home/michi/development/git/libreoffice/desktop/source/app/opencl.cxx:241
            #31 0x00007ffff7b5719d in std::__invoke_impl<void, void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> >(std::__invoke_other, void (*&&)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2>&&)
                (__f=@0x555556fbe460: 0x7ffff7ba7760 <desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&)>, __args=...)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61
            #32 0x00007ffff7b5712d in std::__invoke<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> >(void (*&&)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2>&&)
                (__fn=@0x555556fbe460: 0x7ffff7ba7760 <desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&)>, __args=...)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:96
            #33 0x00007ffff7b57102 in std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=0x555556fbe458) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:292
            #34 0x00007ffff7b570c5 in std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > >::operator()()
                (this=0x555556fbe458) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:299
            #35 0x00007ffff7b56e69 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > > >::_M_run() (this=0x555556fbe450) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:244
            #36 0x00007ffff74dee24 in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #37 0x00007ffff78a4dbb in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444
            #38 0x00007ffff79269f8 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78
        
        Change-Id: I35024670cf4e4a6c00762be71fa051cc9417ef75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167779
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [9a4f7a093bcf252edac458ed6b5411a73264fdc0]

        qt: Run QtFrame::SetIcon in main thread
        
        Fixes this crash/assertion seen when starting Writer with
        the qt6 VCL plugin with a fresh user profile with qtbase debug
        build (as of commit 70a2e7f32b9f9ce19d1538f14fbde7b0d1e77ffd):
        
            Thread 19 "soffice.bin" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fffada006c0 (LWP 150142)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a6b7f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff78584e2 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78414ed in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe34f95c9 in qAbort() () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:49
            #5  0x00007fffe350d459 in qt_message_fatal<QString&>(QtMsgType, QMessageLogContext const&, QString&) (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2112
            #6  0x00007fffe35063e6 in qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *)
                (msgType=QtFatalMsg, context=..., msg=0x7fffe3b8afa8 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fffad9faab8) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:380
            #7  0x00007fffe35084b1 in QMessageLogger::fatal(char const*, ...) const (this=0x7fffad9fad00, msg=0x7fffe3b8afa8 "ASSERT failure in %s: \"%s\", file %s, line %d")
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:880
            #8  0x00007fffe34f969c in qt_assert_x(char const*, char const*, char const*, int)
                (where=0x7fffe3bae469 "QCoreApplication::sendEvent", what=0x7fff9d691f60 "Cannot send events to objects owned by a different thread. Current thread 0x0x7fff9c456670. Receiver 'QtMainWindowClassWindow' (of type 'QWidgetWindow') was created in thread 0x0x55555560dc60", file=0x7fffe3bae098 "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=547) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:114
            #9  0x00007fffe35f54e6 in QCoreApplicationPrivate::checkReceiverThread(QObject*) (receiver=0x55555bb8a180) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:547
            #10 0x00007fffe15a786e in QApplication::notify(QObject*, QEvent*) (this=0x55555560d9e0, receiver=0x55555bb8a180, e=0x7fffad9fb120) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2580
            #11 0x00007fffe35f68be in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55555bb8a180, event=0x7fffad9fb120) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1154
            #12 0x00007fffe35f7677 in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55555bb8a180, event=0x7fffad9fb120) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1598
            #13 0x00007fffe24f74d0 in QWindow::setIcon(QIcon const&) (this=0x55555bb8a180, icon=...) at /home/michi/development/git/qt5/qtbase/src/gui/kernel/qwindow.cpp:1094
            #14 0x00007fffe165564d in QWidgetPrivate::setWindowIcon_sys() (this=0x55555b24b370) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:6208
            #15 0x00007fffe1655598 in QWidget::setWindowIcon(QIcon const&) (this=0x55555735d7a0, icon=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:6198
            #16 0x00007fffe42362a9 in QtFrame::SetIcon(unsigned short) (this=0x55555bba7d30, nIcon=4) at vcl/qt6/../qt5/QtFrame.cxx:378
            #17 0x00007fffee0a2aa6 in SystemWindow::SetIcon(unsigned short) (this=0x7fff9d68a7c0, nIcon=4) at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:332
            #18 0x00007ffff4c843f1 in framework::TitleBarUpdate::impl_updateIcon(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&)
                (this=0x7fff9c452fe0, xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x7fff9d68c690) at /home/michi/development/git/libreoffice/framework/source/helper/titlebarupdate.cxx:278
            #19 0x00007ffff4c831c2 in framework::TitleBarUpdate::impl_forceUpdate() (this=0x7fff9c452fe0) at /home/michi/development/git/libreoffice/framework/source/helper/titlebarupdate.cxx:214
            #20 0x00007ffff4c8304b in framework::TitleBarUpdate::frameAction(com::sun::star::frame::FrameActionEvent const&) (this=0x7fff9c452fe0, aEvent=...) at /home/michi/development/git/libreoffice/framework/source/helper/titlebarupdate.cxx:95
            #21 0x00007ffff4e25397 in (anonymous namespace)::XFrameImpl::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&)
                (this=0x7fff9d68c620, aAction=@0x7ffff4a01f68: com::sun::star::frame::FrameAction::FrameAction_COMPONENT_ATTACHED) at /home/michi/development/git/libreoffice/framework/source/services/frame.cxx:2960
            #22 0x00007ffff4e1df33 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&)
                (this=0x7fff9d68c620, xComponentWindow=uno::Reference to (VCLXContainer *) 0x7fff9dd02cd0, xController=uno::Reference to (ScTabViewObj *) 0x7fff9d8d82d8)
                at /home/michi/development/git/libreoffice/framework/source/services/frame.cxx:1552
            #23 0x00007ffff40291b3 in utl::ConnectFrameControllerModel(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&)
                (xFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x7fff9d68c690, xController=uno::Reference to (ScTabViewObj *) 0x7fff9d8d82d8, xModel=uno::Reference to (ScModelObj *) 0x7fff9c471680) at include/unotools/fcm.hxx:45
            #24 0x00007ffff402551a in (anonymous namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, comphelper::NamedValueCollection const&, rtl::OUString const&)
                (i_rModel=uno::Reference to (ScModelObj *) 0x7fff9c471680, i_rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x7fff9d68c690, i_rViewFactoryArgs=..., i_rViewName="Default")
                at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:584
            #25 0x00007ffff402272f in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&)
                (this=0x7fff9c451600, rArgs=uno::Sequence of length 11 = {...}, _rTargetFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x7fff9d68c690) at /home/michi/development/git/libreoffice/sfx2/source/view/frmload.cxx:759
            #26 0x00007ffff4dd7b61 in framework::LoadEnv::impl_loadContent() (this=0x7fffad9fcbb8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:1176
            #27 0x00007ffff4dd48e4 in framework::LoadEnv::start() (this=0x7fffad9fcbb8) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:412
            #28 0x00007ffff4dd21b2 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures)
                (this=0x7fffad9fcbb8, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", lMediaDescriptor=uno::Sequence of length 1 = {...}, xBaseFrame=uno::Reference to (framework::Desktop *) 0x5555569ad308, sTarget="_blank", nSearchFlags=0, eFeature=LoadEnvFeatures::NONE) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:308
            #29 0x00007ffff4dd0998 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
                (xLoader=uno::Reference to (framework::Desktop *) 0x5555569ad318, xContext=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x555555623d48, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", sTarget="_blank", nSearchFlags=0, lArgs=uno::Sequence of length 1 = {...}) at /home/michi/development/git/libreoffice/framework/source/loadenv/loadenv.cxx:168
            #30 0x00007ffff4e06a3f in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
                (this=0x5555569ad2a0, sURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods", sTargetFrameName="_blank", nSearchFlags=0, lArguments=uno::Sequence of length 1 = {...})
                at /home/michi/development/git/libreoffice/framework/source/services/desktop.cxx:592
            #31 0x00007ffff4e06b34 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) ()
                at /home/michi/development/git/libreoffice/instdir/program/libfwklo.so
            #32 0x00007ffff7ba9147 in desktop::testOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&, rtl::OUString const&)
                (xDesktop=uno::Reference to (framework::Desktop *) 0x5555569ad2f8, rURL="file:///home/michi/development/git/libreoffice/instdir/program/../program/opencl/cl-test.ods")
                at /home/michi/development/git/libreoffice/desktop/source/app/opencl.cxx:132
            #33 0x00007ffff7ba7f54 in desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&) (xDesktop=uno::Reference to (framework::Desktop *) 0x5555569ad2f8)
            --Type <RET> for more, q to quit, c to continue without paging--
                at /home/michi/development/git/libreoffice/desktop/source/app/opencl.cxx:241
            #34 0x00007ffff7b5719d in std::__invoke_impl<void, void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> >(std::__invoke_other, void (*&&)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2>&&)
                (__f=@0x5555573c20b0: 0x7ffff7ba7760 <desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&)>, __args=...)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61
            #35 0x00007ffff7b5712d in std::__invoke<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> >(void (*&&)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2>&&)
                (__fn=@0x5555573c20b0: 0x7ffff7ba7760 <desktop::Desktop::CheckOpenCLCompute(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&)>, __args=...)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:96
            #36 0x00007ffff7b57102 in std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) (this=0x5555573c20a8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:292
            #37 0x00007ffff7b570c5 in std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > >::operator()()
                (this=0x5555573c20a8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:299
            #38 0x00007ffff7b56e69 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (*)(com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> const&), com::sun::star::uno::Reference<com::sun::star::frame::XDesktop2> > > >::_M_run() (this=0x5555573c20a0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_thread.h:244
            #39 0x00007ffff74dee24 in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #40 0x00007ffff78a4dbb in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444
            #41 0x00007ffff79269f8 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78
        
        Change-Id: Ic611eb26b140c060cba4d81603e506806cf43bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167778
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-18  Dione Maddern  <dionemaddern@gmail.com>  [028ac95c0e9991b59a835527b6fed2f8d3e2bddf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d2649657002eeabbf686333faccd2b141d3bc9dc
          - tdf#161091 Document new bar-of-pie and pie-of-pie chart types
            
            In text/schart/01/type_pie.xhp:
            -  Updated "How to get" section to include specific instruction on how to access the Pie chart type, instead of just the Chart Wizard.
            - Added a description for the Bar-of-pie and Pie-of-pie chart subtypes.
            
            Change-Id: I3b8e53abd5bfde03c2e266de4953e4e99bf68379
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167681
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-18  László Németh  <nemeth@numbertext.org>  [0e40ccfa6749ab2fe86124a28e1ceee1462ba302]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d5b1a072e025a692cee803310d2ceff0296b083
          - tdf#132599 add "Hyphenation across" -> Last full line of paragraph
            
            Document new option of LO 24.8 to control hyphenation
            in last full line of a paragraph. Fix also the changed IDs
            of the other "Hyphenation across" options.
            
            Follow-up to commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b
            "tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'".
            
            Change-Id: If38c922c379506d3dc4a9c11cd428f7a28039b1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167773
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [8d16b7a9e6dad1c3590c74af3eee952bd8fc3284]

        tdf#160835 Fix the use of "population" in Calc functions
        
        Change-Id: If72058a34534dc477d07e9683c0d38d7169eecf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167688
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [359ae74cc138c59d18285cea301a7382da14668d]

        loplugin:ostr in sw/../unocore
        
        Change-Id: Ibf48c1fcdc2ed53784bb73ca718d8f9886d983d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b0686234cc72f562ec5ec695c4594894838a46e]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I92ff04181d3c4ec4f0e1cd9f63ce5a1dc869ffc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167797
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [2bcaa374ea418cd81f9dbf62cd7e896f5977992a]

        tdf#161137 sw: AutoText or Paste should copy paragraph indents for lists
        
        The first commit made the start and end node of the paste look like the
        list it was inserted into, but the middle nodes may have different
        paragraph styles and may have different left margin / first line indent.
        
        In addition to the SwNumRule, also copy any left margin or first line
        indent if it is effective on the node that the SwNumRule was taken from.
        
        Now all the list labels should be in the same place.
        
        Change-Id: Ia5794687ea0ff542f23289b1ca63ea99dae85bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167777
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [7698f386413e514a4478a1af69a8a3be93dfecab]

        tdf#161137 sw: fix AutoText or Paste overriding paragraph indents
        
        The problem is that when a paragraph style specifies a SwNumRule, then
        this style's indents override the indents of the SwNumRule, but if the
        same SwNumRule is also added to the SwTextNode's mpAttrSet, then the
        style's indents no longer take effect.
        
        This happens both when inserting an AutoText, and when Pasting, into a
        list item, because DocumentContentOperationsManager::CopyImplImpl()
        sets the pNumRuleToPropagate as direct formatting on every pasted node.
        
        Add another flag to SwDoc::SetNumRule() to check if pNumRuleToPropagate
        was already in effect due to the paragraph style.
        
        Change-Id: Id98ad2a21eab4f8636fb36f9298a054cfe4f7784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167766
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3ddd11d18a24ebd8cbc3e5ac8d460b4888cade07]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I18b18f5d430e626dea9163aec0bf99ab09c5c71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167780
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1148d6ad13b444c179aacdb693bd82e37d0ed32d]

        introduce SAL_RET_MAYBENULL
        
        which for debug builds and MSVC uses _Ret_maybenull_ and -analyze to
        enforce null checking
        
        Change-Id: Id7f0ad854be7841819fdbdcd56c862d1a2df86c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166734
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-17  Jonathan Clark  <jonathan@libreoffice.org>  [30d376fb7ded4c96c85ad1112a0e44b5929657c9]

        tdf#61444 Correct Writer text layout across formatting changes
        
        Previously, Writer performed text layout for each span of text
        separately. This caused incorrect kerning when the text style changed
        mid-word, for example by highlighting or changing the color of a single
        letter.
        
        This change updates Writer so it will also consider neighboring text
        while performing text layout.
        
        Change-Id: I511096c009343f39cc1b9ba745909c5b8cbad86f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167016
        Tested-by: Jenkins
        Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>

2024-05-17  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5e88d86d8c41b6790a365fddadbcea76712c11f3]

        Use less SdOptionsSnapItem->Get/SetEliminatePolyPointLimitAngle
        
        in favor of officecfg
        
        Change-Id: I8a8d910578a438b494567eed30a632db6f191101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167541
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-17  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fa16f9e19ea9ff29086e1759a8e66ccabf553ac0]

        Add missing officecfg call
        
        accidentally omitted from f1c91993e54858f9bc7ed78d25485a09157c04be
        
        Change-Id: I19a95e4e767792543bf04bbd8ca572017eee8992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167772
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0c3ba42a45c4fd7eabbad9c2a57a82486cfd9eab]

        Review of UNIQUE function arguments text
        
        Feel free to consider this as suggestion.
        
        Change-Id: Ia3addb8ee7157ab0e5c5a10230adabc5963f94d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167756
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7c25b9c2a0770a66c18b4cd2f5d09d47fa7e057e]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ic67e884555517620acb6d43bafc28e8291720913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167770
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb4e9a7bf2231716d4809c682ae4b6b8b91b09b4]

        loplugin:ostr in sc/../tool
        
        Change-Id: I04c41c79613397745a2e97c2e8a247e11f114c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167767
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-17  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [bdb47881a214b659b6102c78e5e082197ecf15c7]

        Revert "tdf#109347: don't verify SSL certificate for crashreport upload"
        
        With recent improvements in libcurl CA usage on Linux, this workaround
        is no longer needed. See also 11f439b861922b9286b2e47ed326f3508a48d44e
        
        This reverts commit ec4229bc49a315f3f17664bb43e61d3b2e13fb87.
        
        Change-Id: I09124691687297f3b6ae0b9ca64652809caf3a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167752
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5a37d8239dd2c7f31d8a107add1f84b69b68422]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I4bb077ea634d9ca3e238981cfcc307a1b6caf7c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167757
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [000aaf1f8c6b3520a604327445a41ca6b8f568dc]

        loplugin:ostr in sc/../filter
        
        Change-Id: I3c986d9e7f9780f08653131205626471ac75896f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2c46e9630567848e5aac3e88d98c4bfa1a4750f]

        loplugin:ostr in sd/../filter
        
        Change-Id: I0a48a71fd1386fd5baf091e041bfa82255144779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-17  Pranam Lashkari  <lpranam@collabora.com>  [45e0c28a6911ef19c8c11e0195c6f01362d53611]

        Added parent / child relationship to comments.
        
        Adding parent name of a comment into odf file when there is a parent.
        
        problem:
        adding reply to any comment, saving and reopening doc will not show
        reply in same thread.
        regression from: c0187d9f5e6ab5129b6fc4682555f2f8775d6f67
        
        this part affects core only, similar thing online was done in 62cc2217217650d23c72e4646ccd793f76722d94
        
        Change-Id: I563e3a2785543da69d717f8770f91a514699e604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167711
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2a040bfe3e9f58db5c9f6503796778f07e2beba9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167680
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f025bdad98dfa2e806391142844a727a2014aac]

        beanshell: upgrade to 2.1.1
        
        * Adapt external/beanshell/java9.patch.0 to fix
        
        [javac] error: Source option 6 is no longer supported. Use 7 or later.
        [javac] error: Target option 6 is no longer supported. Use 7 or later.
        
        Downloaded from https://github.com/beanshell/beanshell/releases/download/2.1.1/bsh-2.1.1-src.zip
        
        Change-Id: I969813fd2bb2a910004b6c28f5ed9ba95c39895f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167764
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-17  Weblate  <noreply@documentfoundation.org>  [903e71eb452a0d9be4007497ca06b22765600188]

        Update translation files for android-viewer
        
        Updated by "Cleanup translation files" hook in Weblate.
        
        Change-Id: Iea28e4d8bf859accdb1c16bb4c6836237a4d2b26
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 61.0% (72 of 118 strings)
        
        Change-Id: I741c23b1048d4857605d73aad34668c29234dd6f
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I9cbcf579a5c634adf0686e43aa4dca069c2dd577
        
        Added translation for android-viewer using Weblate (Esperanto)
        
        Change-Id: Ibcf6e82a860c5e789d6ee89dace30d1457a60c22
        
        android-viewer translated using Weblate
        
        Japanese currently translated at 39.8% (47 of 118 strings)
        
        Change-Id: I9efdbae451a5313cb5b8ef4a1abca4bbc696969b
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167748
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-17  Miklos Vajna  <vmiklos@collabora.com>  [b969e692000f50aafacc2eb577f545b8836dcc26]

        tdf#160952 sw: ignore top margin only at page top, not in fly
        
        See
        <https://gerrit.libreoffice.org/c/core/+/167671/2#message-8603b129dd8bd72608259571056ded950182ca96>,
        multi-column shape text can't appear in DOCX files, so collapsing upper
        spacing in that case is not correct, avoid it.
        
        Change-Id: Icf69c8d84fdd15d6e3289ff614b2f6ba7cee1e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167758
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-17  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [fa4ceeb487f89671efc8bf533192bf237c35b51e]

        Revert "LOK: Allow image upload from WOPI-like host with self-signed cert"
        
        This reverts commit d95ac1c608caba9cabaa503f1a5589285547aed5.
        
        Change-Id: I4bc104272d4c41efab1a7e5eae78267675c1b32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167753
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-05-17  László Németh  <nemeth@numbertext.org>  [b538729c90af470c33aeb3002750321ac8ac88be]

        tdf#160518 sw: fix DOCX import/export of hyphenation-keep
        
        – export hyphenation-page="page" setting of native ODF documents,
          if hyphenation is enabled in the default paragraph or in
          the text body style with this setting. It's lossless for
          hyphenation-keep-type="column", while the other values are
          converted to hyphenation-keep-type="column", which is
          the default layout of MSO 2013 and later.
        
        – fix LO roundtrip of DOCX documents which were created in MSO
          originally: while the roundtrip kept useWord2013TrackBottomHyphenation
          and allowHyphenationAtTrackBottom, the exported redundant
          suppressAutoHyphen = "false" settings of the paragraph
          resulted broken layout in Writer, because the repeated import
          overwrote every paragraphs with bad hyphenation setting
          (hyphenation-keep = "auto" instead of hyphenation-keep = "page").
        
        – export also "Hyphenate CAPS" and "Hyphenation zone" settings,
          if hyphenation is enabled in text body style with these settings,
          and not in the default paragraph style. Setting hyphenation only
          in "Text Body" is more common in documents created in LibreOffice.
        
        Follow-up to commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463
        "tdf160518 DOCX: import hyphenation-keep to fix layout".
        
        Change-Id: I9dbaf1e37416758388e3b2b19db3317f3f5652b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167749
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-16  Dione Maddern  <dionemaddern@gmail.com>  [708ad04b60407deeb7de073ed95fd9f391de4fcc]

        tdf#160969 Add missing tooltips for Tools > Options > Scalc > View
        
        In sc/uiconfig/scalc/ui/tpviewpage.ui
        - Added extended tips for:
          - Comment indicator
          - Comment authorship
          - Formula indicator and tip
          - Summary on search
          - Grid lines
          - Pointer
          - Objects/Images
          - Charts
          - Drawing objects
        
        Change-Id: I1610e5282e85904d8aff30417466ec1015f97235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167613
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-05-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [56f4272f407fed0e013ef694276e640955add154]

        Use less SdOptionsSnapItem->GetAngle/SetAngle
        
        in favor of officecfg
        
        Change-Id: I3196fb36a1513fed983998a33acce05e03a20cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167540
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4e42bce5581e6c1956607a5cb49837ad85b862b]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I710ff75d387b2d452cb80911c9f0092948453ef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167751
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f1c91993e54858f9bc7ed78d25485a09157c04be]

        Use less SdOptionsSnapItem->GetSnapArea/SetSnapArea
        
        in favor of officecfg
        
        Change-Id: I0457f565f3f5d68018a307de7afbed9dbd009d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167539
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [57ed936badf1e8bb1931fd8c4eb27b13a7c7171d]

        loplugin:ostr in sd/../console
        
        Change-Id: I93a0373087f93d2ca754c95e5eba283b6cfb8ebe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167745
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb4f17adcd6fb25aeab78dc0754c591968e40d76]

        loplugin:ostr in sd/../core
        
        Change-Id: I3f69635be67215a3b351fa54f6024651a4e85a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a2007364e77aebbbc45fa8fab2c58f95a821dd18]

        always restore existing interaction handler after save
        
        In an error case we end up removing any existing interaction handler.
        So in all cases leave with the same interaction handler that
        existed before the save attempt.
        
        See also:
        
        commit 3b294f6139028014e72379ebe8eda24a2bd32195
        Date:   Thu Jun 8 20:53:16 2023 +0100
        
            restore, not clear, existing interaction handler after save
        
        where the same problem can be reproduced of every change is a
        full-document invalidation once someone else joins a document which has
        had a save-fail.
        
        Change-Id: I211183c551b1d64898cfe4aaf11dd9ef23f8ca15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167678
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-16  Hossein  <hossein@libreoffice.org>  [12447b7c70cd1314c35fe7e2ae89078abdd9a4a6]

        Fix odk examples build on 32 bit systems
        
        It is required to cast integer literals to sal_Int32 when passing them
        to Any().
        
        Change-Id: I377f88fc3441d8e4bc7afdb2411c1fd140853134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167739
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: René Engelhard <rene@debian.org>

2024-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [9d3c6b31158aedc33bd616981f0f80af8a0ed1b0]

        tdf#161035: The previous bookmarks can legitimately be not processed
        
        The enumeration may be called for a partial paragraph selection, and
        then the bookmarks prior to the selection are not processed.
        
        Change-Id: Ib725ffb320ec5a81b39ce77f06392a82bd6d8ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167720
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [239641a4df8c137dc59eb4040608e5d7d9f79320]

        loplugin:ostr in sc/../data
        
        Change-Id: I5fef1585ccc9492961328affd284f2c60a004e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167738
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [16da2bc87145f07f6f84fa69c76d461a31aea139]

        tdf#156955 Add test
        
        Change-Id: I02d2f437c3847970441dd489cc60beaf278b8d78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167741
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-16  Bayram Çiçek  <bayram.cicek@collabora.com>  [35c93c5f8e40dff4819849b240044cd9d99221a0]

        make AutoFill work for Copy cells and Fill series
        
        FID_FILL_AUTO (.uno:AutoFill):
        - added new parameter: SfxBoolItem Copy FN_PARAM_1
          - if the parameter is true, we use "Copy cells", otherwise use "Fill series"
        
        Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
        Change-Id: I639828021dcbba52f6bc21366f23faf7e38bb03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167726
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 95575b8bd026e3ae4aaddf3a023488d7a5fa0976)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167677
        Tested-by: Jenkins

2024-05-16  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [6c4ed5685b6dc08c9734cfcfd37b294ac892ad7e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0672dfb42c298cc3411bfb74b2eaf662427a4e4c
          - Minor corrections
            
            Change-Id: Iec645f6ff0d578b5d8463ea1a6cb845717ce678f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167744
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0abc01c13638f92ddce191c7ff2c29ba31d9527d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1b06c45742f070d204183a7e24ccb5e2386d59a7
          - tdf#159872 Link RAND* to RANDARRAY function
            
            + refactor
            
            Change-Id: I54fdfca2d15f0ddca0e36a9513da011896e886cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167743
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [86050dc7c72b98cf7af98d78e664965c9d9bb383]

        android: Disable multidex, only needed for minSdkVersion < 21
        
        multidex was enabled in
        
            commit 037680488b56aa2c4eb21900168aa88ef35d5b07
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 27 12:51:54 2022 +0100
        
                android: Enable multidex, update com.google.android.material to 1.7.0
        
        as it was needed when building for minSdkVersion <= 20, see [1]
        and the full commit message of the above-mentioned commit
        for more details.
        
        However, since
        
            commit c2fc2c8c7c63ca4e43bca6e8c9b82c50418422d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 5 09:57:22 2023 +0100
        
                android: Bump minSdkVersion to 21 (Android 5.0)
        
        , the minSdkVersion is greater than that, so this
        is no longer needed.
        
        [1] https://developer.android.com/build/multidex
        
        Change-Id: I31502ec74e9c4201a8a11be42820f70e5fd5a1fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167735
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-16  kubak  <kuba@openoffice.com.pl>  [bf067777fee9fccd361fecc106eafc587b1c8a88]

        MSI: Adds the missing ExtendedType column in the CustomAction table
        
        ICE06 WARNING Column: ExtendedType of Table: CustomAction is not defined in database.
        
        https: //learn.microsoft.com/en-us/windows/win32/msi/ice06
        https: //learn.microsoft.com/en-us/windows/win32/msi/customaction-table
        
        Change-Id: I5f9368fedf421b23a397f5dcd77f383cb9f42ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166951
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-16  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [51436ecfd3d3f31d50dc1f617cb6793398b5dad6]

        tdf#33603: sd: notes pane: force proper flush on page change
        
        After clearing the notes pane outliner and filling with then
        new content, if the new content didn't overfill the
        previous' area there was a residue from the last content
        visible.
        
        Make sure it is flushed by triggering onResize() on page
        change.
        
        Which also fixes the notespane sometimes keeping the
        scrollbar & scrollarea from the previous content.
        
        Change-Id: Ibbcb0f4f316bd283e5e65bb2ebd9cf17a3b38c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167489
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-05-16  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [9d075157ccf3e9468b5208291e398a9d7e4728b8]

        tdf#33603: sd: make state of notes pane persist across runs
        
        Introduces new NotesPaneModule which manages the visibility
        of NotesPane across modes and different runs.
        
        Also introduces new three config values under
        Office/Impress/MuliPaneGUI/NotesPane/Visible ImpressView,
        OutlineView and NotesView.
        
        Similar to what was there for SlideSorterBar.
        
        Change-Id: Id540c508e81878e5a8e1aebd6544839e70b813c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167348
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [45f9627659e882b9157782dfc5981e31567a306e]

        loplugin:ostr in tools
        
        Change-Id: I0e601100b034eaa99b08c7cbf09e5f817e69b507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167736
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4c7ffc8edf83529550eb3897024792cbb6e48e0]

        loplugin:ostr in ucbhelper
        
        Change-Id: Ic0513708b208ec4cba54eedc15e308410eef8d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167731
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [98142886f21e40d0f7052f18108d9586f4b2fbc5]

        loplugin:ostr in unoxml
        
        Change-Id: Iffacc269c97371597188254b44623c011d1cf9db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Justin Luth  <jluth@mail.com>  [1a38ff09bef969ad13877e3e752b04e1d590323e]

        NFC use more GetTrueWhichIDFromSlotID
        
        We already check if nWhich is not equal to 0,
        so instead of returning nWhich == nSlotId
        (which we immediately check for an reject),
        use this version of the function which returns a 0
        instead of the slotid when there is no nWhich.
        
        Change-Id: I7ee3286f535db2c89ec458decd0ab6bdc4d3cc5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167713
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-16  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e0b930e1ddf008d202c3620fdc6652483f914835]

        VCL: Windows: more usecases for FlashWindow() API to inform on changes
        
        FlashWindow() can be used to bring user attention to application
        in background. Right now in LO it has implementation only for
        Windows. Here some new cases were added when flashing is used:
         * dialog window did open
         * document loaded
         * LO started
        
        Some redesign of previous solution is also performed: no manual
        search for top window, let's reuse existing code.
        
        Changed behavior for bringing LO window to foreground: it is made always and not depending on current value of NewDocumentHandling:ForceFocusAndToFront. It has no sense to tweak this behavior: if user clicks on document in file explorer, LO should came to foreground, no exceptions.
        
        Change-Id: I22b5b4e2b170cd25632083a55b3e9f0358bcae03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166615
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-16  Heiko Tietze  <tietze.heiko@gmail.com>  [7fc7d3b9fe6eabeddf43fbf72a041854fda51b27]

        Related tdf#159573 - WhatsNew dialog: 1px glitch with Wayland
        
        Change-Id: I6565fa32f4484e74abecc795c67e7afa13f7f55b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167734
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [69189de8fa9a9d4973a4304a82780d32e79fbe6f]

        tdf#157009 android: Add icon symlink for F-Droid
        
        Add a symlink to the app icon at the expected
        location when using the Triple-T data structure
        that can be used to provide metadata for F-Droid. [1]
        
        As Android Viewer currently uses a non-default directory layout,
        this currently needs to be placed in a different subdirectory than
        the actual source code in order for F-Droid to find it, see the
        discussion in [2] for more details.
        
        This should cause the app icon to show up in F-Droid
        after the next update.
        
        [1] https://f-droid.org/en/docs/All_About_Descriptions_Graphics_and_Screenshots/#triple-t-structure
        [2] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/13643#note_1538888683
        
        Change-Id: Ic1a987e430b6e92134ac19d7f1c264953cd3cf0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167732
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [e63fa1ab17a082b14927079cfc04843061024947]

        android lint: Udate lint-baseline.xml
        
        Some of the issues have been addressed in
        the meanwhile, so regenerate the file to
        reflect that.
        
        Change-Id: I5c0f8a112cf02a89fe652c79ed8d70213f6fbc1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167725
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [91fa1f792de325f0fb95e56c59a52d5fc97d860d]

        android: Avoid unnecessary prefs processing
        
        When the experimental editing mode preference
        was toggled, it was processed twice:
        
        Toggling that pref requires starting the
        `SettingsActivity`, and when returning to
        `LibreOfficeMainActivity`, its `onResume` method
        was called which updates `mIsExperimentalMode` as needed.
        In addition, the `LibreOfficeMainActivity#onSharedPreferenceChanged`
        callback was called that also processed that preference.
        
        The latter is more "targeted" and only called when a preference
        actually changes.
        Call `updatePreferences()` from there so other preferences
        are also handled and drop the call to `updatePreferences`
        from the `onResume` method, which is no longer needed
        with that in place.
        
        Change-Id: Ic0cacd8ad551137d5aea14cda6838d2ac50de8db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167724
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [3865c81e96432638f3f4cc2ba4eeb481da1c6ebb]

        android: Drop indirection listening to pref change
        
        Let `LibreOfficeMainActivity` implement the standard
        Android `SharedPreferences.OnSharedPreferenceChangeListener`
        interface directly, rather than having a custom
        `SettingsListenerModel.OnSettingsPreferenceChangedListener`
        indirection and the `SettingsFragment` implementing the
        standard interface.
        
        This simplifies the code and removes one level of
        indirection.
        
        Drop the now unused `SettingsListenerModel`.
        
        Change-Id: I8c7d6088e711631409f9189bba966439db3daa44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167723
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [4d4c31349468e68a405887050114d2f3da3547c6]

        android: Apply enabled experimental mode when doc open
        
        Use a `mbReadOnlyDoc` member that keeps
        track of the readonly status of the document only
        instead of a `mbISReadOnlyMode` that at the same
        time also was taking into account whether experimental
        editing features were enabled.
        Let `LibreOfficeMainActivity#isReadOnlyMode()` take
        experimental status into account instead.
        
        With this in place, opening a (writable) document
        with experimental editing mode disabled, then enabling
        experimental editing mode makes editing possible after
        clicking on the LibreOffice logo in the toolbar.
        
        Previously, it was necessary to open the document
        anew.
        
        Change-Id: Ia5fde9b6019251d76d46df97fad2ffd64a0f5a30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167721
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [39ed595d608efd852a0239f6cf74f1168981cfc2]

        android: No longer manually set UI language
        
        Drop the possibility to manually set a UI language
        introduced in
        
            commit f2e35a695671028b32139df1824ff536e7610d35
            Author: Mert Tumer <merttumer@outlook.com>
            Date:   Tue Sep 18 23:29:57 2018 +0300
        
                Added language support on Android Viewer
        
        Since
        
            commit 5bf2ec9ed8728a2042e110122ea2b0e4ff55104a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 20 10:40:34 2019 +0100
        
                android: Use system locale by default
        
        , Android Viewer defaulted to the system
        language for its UI language as well.
        
        In addition, current Android versions allow to set
        a specific language for apps: [1]
        
        The previous approach of manually setting a language
        in Android Viewer shouldn't really be necessary any more.
        
        With the app now being available for translation on
        Weblate and having been translated to more languages,
        the list of available languages had become out of sync.
        
        Additionally, the manually selected language wasn't
        consistently applied everywhere:
        
        * On the start activity where a document can be selected,
          it was only applied after closing the app, then opening
          it again.
        
        * in the Settings, the language was not applied at all,
          that was always using the system locale anyway
        
        Changes to the system locale are applied immediately
        and consistently, so stick to the default Android mechanism
        and reduce the overall complexity and maintenance burden.
        
        [1] https://support.google.com/android/answer/12395118?hl=en
        
        Change-Id: Ida61650b888a563f2346ea94a14b260802b1d24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167718
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [567891fdf7912ae173429539bc97c68075c00c1f]

        android: Port Settings{Activity,Fragment} from deprecated API
        
        API used in `SettingsActivity` and `SettingsFragment` has
        been deprecated, e.g. `PreferenceFragment` was deprecated in
        API level 28 [1].
        
        Port that to non-deprecated API from the androidx.preference
        library [2].
        
        This addresses these deprecation warnings:
        
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:14: warning: [deprecation] PreferenceFragment in android.preference has been deprecated
            import android.preference.PreferenceFragment;
                                     ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:15: warning: [deprecation] PreferenceGroup in android.preference has been deprecated
        
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:23: warning: [deprecation] getFragmentManager() in Activity has been deprecated
                    getFragmentManager().beginTransaction()
                    ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:23: warning: [deprecation] beginTransaction() in FragmentManager has been deprecated
                    getFragmentManager().beginTransaction()
                                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:24: warning: [deprecation] replace(int,Fragment) in FragmentTransaction has been deprecated
                        .replace(android.R.id.content, new SettingsFragment())
                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:25: warning: [deprecation] commit() in FragmentTransaction has been deprecated
                        .commit();
                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:28: warning: [deprecation] PreferenceFragment in android.preference has been deprecated
                public static class SettingsFragment extends PreferenceFragment implements SharedPreferences.OnSharedPreferenceChangeListener {
                                                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:28: warning: [deprecation] PreferenceFragment() in PreferenceFragment has been deprecated
                public static class SettingsFragment extends PreferenceFragment implements SharedPreferences.OnSharedPreferenceChangeListener {
                              ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:30: warning: [deprecation] onCreate(Bundle) in PreferenceFragment has been deprecated
                    public void onCreate(Bundle savedInstanceState) {
                                ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:31: warning: [deprecation] onCreate(Bundle) in PreferenceFragment has been deprecated
                        super.onCreate(savedInstanceState);
                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:32: warning: [deprecation] addPreferencesFromResource(int) in PreferenceFragment has been deprecated
                        addPreferencesFromResource(R.xml.libreoffice_preferences);
                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:34: warning: [deprecation] PreferenceGroup in android.preference has been deprecated
                            PreferenceGroup generalGroup = (PreferenceGroup) findPreference("PREF_CATEGORY_GENERAL");
                            ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:34: warning: [deprecation] PreferenceGroup in android.preference has been deprecated
                            PreferenceGroup generalGroup = (PreferenceGroup) findPreference("PREF_CATEGORY_GENERAL");
                                                            ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:34: warning: [deprecation] findPreference(CharSequence) in PreferenceFragment has been deprecated
                            PreferenceGroup generalGroup = (PreferenceGroup) findPreference("PREF_CATEGORY_GENERAL");
                                                                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:35: warning: [deprecation] findPreference(CharSequence) in PreferenceGroup has been deprecated
                            generalGroup.removePreference(generalGroup.findPreference("ENABLE_EXPERIMENTAL"));
                                                                      ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:35: warning: [deprecation] removePreference(Preference) in PreferenceGroup has been deprecated
                            generalGroup.removePreference(generalGroup.findPreference("ENABLE_EXPERIMENTAL"));
                                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:36: warning: [deprecation] findPreference(CharSequence) in PreferenceGroup has been deprecated
                            generalGroup.removePreference(generalGroup.findPreference("ENABLE_DEVELOPER"));
                                                                      ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:36: warning: [deprecation] removePreference(Preference) in PreferenceGroup has been deprecated
                            generalGroup.removePreference(generalGroup.findPreference("ENABLE_DEVELOPER"));
                                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:41: warning: [deprecation] onResume() in Fragment has been deprecated
                    public void onResume() {
                                ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:42: warning: [deprecation] onResume() in Fragment has been deprecated
                        super.onResume();
                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:43: warning: [deprecation] getPreferenceScreen() in PreferenceFragment has been deprecated
                        getPreferenceScreen().getSharedPreferences()
                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:43: warning: [deprecation] getSharedPreferences() in Preference has been deprecated
                        getPreferenceScreen().getSharedPreferences()
                                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:48: warning: [deprecation] onPause() in Fragment has been deprecated
                    public void onPause() {
                                ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:49: warning: [deprecation] onPause() in Fragment has been deprecated
                        super.onPause();
                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:50: warning: [deprecation] getPreferenceScreen() in PreferenceFragment has been deprecated
                        getPreferenceScreen().getSharedPreferences()
                        ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:50: warning: [deprecation] getSharedPreferences() in Preference has been deprecated
                        getPreferenceScreen().getSharedPreferences()
                                             ^
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/SettingsActivity.java:58: warning: [deprecation] getActivity() in Fragment has been deprecated
        
        [1] https://developer.android.com/reference/android/preference/PreferenceFragment
        [2] https://developer.android.com/reference/androidx/preference/package-summary
        
        Change-Id: I3365a487345787056c91fa7addf987edca38e94f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167717
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [7b0d2829fe691e013486578b6e93cf94ceb0cd36]

        android: Port to non-deprecated androidx PreferenceManager
        
        The `android.preference.PreferenceManager` class was
        deprecated in API level 29 [1].
        
        Port to `androidx.preference.PreferenceManager` from
        the AndroidX Preference library instead.
        
        All that needs to be done for this is to add the new library
        dependency and adjust the import, no further code changes
        needed for this step. (There are uses of more deprecated
        preferences-related classes, though. Those will have to be
        dealt with separately.)
        
        This addresses depreaction warnings like
        
            > Task :compileStrippedUIEditingDebugJavaWithJavac
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/src/java/org/libreoffice/LibreOfficeMainActivity.java:16: warning: [deprecation] PreferenceManager in android.preference has been deprecated
            import android.preference.PreferenceManager;
                                     ^
        
        [1] https://developer.android.com/reference/android/preference/PreferenceManager
        
        Change-Id: Ied168ffbd0591d69e0797e2a0a5bab067e133d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167716
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-16  Michael Weghorn  <m.weghorn@posteo.de>  [f895ee6de44cddfb86cdb0912693f7aa56cb3340]

        android: Set android.ndkVersion for Gradle
        
        Set the `android.ndkVersion` property [1] for
        the Android Gradle Plugin, in addition to `android.ndkPath`
        that is set there already.
        
        This addresses the warning
        
            > Task :stripStrippedUIEditingDebugDebugSymbols
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            [CXX1100] android.ndkVersion is [26.1.10909125] but android.ndkPath /home/michi/Android/Sdk/ndk/25.1.8937393 refers to a different version [25.1.8937393].
            Unable to strip the following libraries, packaging them as they are: libc++_shared.so, libfreebl3.so, liblo-native-code.so, libnspr4.so, libnss3.so, libnssckbi.so, libnssdbm3.so, libnssutil3.so, libplc4.so, libplds4.so, libsmime3.so, libsoftokn3.so, libsqlite3.so, libssl3.so.
        
         that started to show up in a local
        `--with-android-ndk=$HOME/Android/Sdk/ndk/25.1.8937393`
        Android build after
        
            commit 1610ebc06b34263bf3e525babe1e583b932f6242
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 13 10:47:49 2024 +0200
        
                android: Update Android Gradle Plugin to 8.4.0
        
                ... and gradle to 8.6, as suggested by Android Studio.
        
        As described at [2], that Android Gradle Plugin defaults to
        NDK 26.1.10909125.
        
        [1] https://developer.android.com/studio/projects/install-ndk#apply-specific-version
        [2] https://developer.android.com/build/releases/gradle-plugin
        
        Change-Id: Ied81f13f535303f9578177646f177b4ef791eefa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167715
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [49192335f8671a948bf729a929e1ccdbb88df4e4]

        loplugin:ostr in unotools
        
        Change-Id: Ieda6fe806da2cfd17a7891cefa7f55666ee6b728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Noel Grandin  <noelgrandin@gmail.com>  [bab6d9c44ba39d08bbee43bca4a461bca52c07e1]

        use more officecfg in xmlhelp::Databases
        
        Change-Id: Iba6c3d0ed3d4d029a4497f56a8412c88bde5246c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Kurt Nordback  <kurt.nordback@protonmail.com>  [86dcdfd097b0fdd91d69ecb8be0e72a84112a514]

        tdf#159547 of-pie connector lines aren't quite geometrically correct
        
        Fixed code computing the left endpoints of of-pie connector lines, so
        that they're tangent to the circle when the composite slice is large enough
        (and they terminate at the tangent point).
        
        Change-Id: I4ff4d8e31f47259f0f48721b532dc245ede83003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167712
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [5ae1379fcdd00228e683ae90991e275f570cd92d]

        writerfilter: fix parsing of invalid STYLEREF field
        
        forum-mso-en-3309.docx contains a funny field that doesn't follow
        the grammar in the OOXML spec:
        
        STYLEREF \t "Heading 1" \* MERGEFORMAT
        
        Word can evaluate it and find the paragraph, so make the parser a bit
        more flexible, by adding known switches that don't have arguments, so
        that any argument following these becomes a field argument,
        for now only for STYLEREF.
        
        (regression from commit d4fdafa103bfea94a279d7069ddc50ba92f67d01)
        
        Change-Id: Ic42cd2be58fd65a817946e21a9661d357b02a99a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167697
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-16  Miklos Vajna  <vmiklos@collabora.com>  [d74fb6b571304b41c13b7a6dcdd2b853bfca7210]

        tdf#160984 sw continuous endnotes, DOC import: enable this unconditionally
        
        DOC files with <= 2 endnotes were imported fine, but not if they had
        more endnotes.
        
        This was added in commit dc11f5b151e1a2ea2623fc8cf806a400763955d9
        (tdf#143445 DOC import: limit the usage of the CONTINUOUS_ENDNOTES
        compat flag, 2023-05-23), because mapping endnotes to footnotes was a
        dead-end.
        
        The limitation can be dropped: I checked that the tdf#143445 bugdoc with
        all its 72 endnotes is laid out reasonably.
        
        Also add a new SwFrame::DynCastColumnFrame() to easily get a column
        frame from a frame using our own RTTI, if we have it anyway.
        
        Change-Id: If7fd856f5dc5f1feb1366fca69a2ad6b3602044d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167722
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-16  Justin Luth  <jluth@mail.com>  [7fcd5ac42086f1374c3bd5eb2be9a59e6f38f2e3]

        tdf#72511 tdf#78510 ww8import: recombine into SvxLRSpaceItem for EE
        
        This fixes Michael's 7.6 regression,
        commit db115bec9254417ef7a3faf687478fe5424ab378
        which split RES_LR_SPACE into (mainly) three pieces.
        
        The regression caused paragraphs in textboxes
        (and anything else that ends up in EditEng)
        to lose left and right paragraph indents.
        
        Accidentally, that regression fixed indents for comments,
        since MSO ignores them for DOC format,
        so I made sure that these properties were not passed to commments.
        
        make CppunitTest_sw_ww8export4 \
            CPPUNIT_TEST_NAME=testTdf72511_editengLRSpace
        
        Change-Id: I95121e4b32193701af3e1d77ba92c36aca7f16cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167651
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [601ae6910288c7f3abdbb11de644c17b3b2d0cb5]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: If4ca47bc4d8203ed7d20e1bbf1c3ebe2587c403f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167709
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c8a5dc46d11f2ef1e3a66d633730d9a700ced24a]

        tdf#161056 Show bullets used in document in bullets dropdown
        
        Change-Id: I40cfc39501006146f7c6c04a1f3c7cf877c6f1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167186
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [28c64afa68f52fb847e9915cde108b856fa39987]

        loplugin:ostr in xmlscript
        
        Change-Id: Iaa78cb8994fc1f1b40f02d26e4e1218882ac4b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167706
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a19fefaee65b62377fa296698a4ca16dc279c4f]

        loplugin:ostr in uui
        
        Change-Id: I17bab541e4efb6cff0818ee0fad48800d7ff73be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167708
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [07b673a1a6fb5edc7d58ed496f4181d59070a2a6]

        loplugin:ostr in sdext
        
        Change-Id: I0b67b8c8f9dbdf2fdc8192e22b838c15db960cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167704
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb9c3c754c1c13172925974318e853adffda07bc]

        loplugin:ostr in writerperfect
        
        Change-Id: I3fddb38d4bac2aeba7533163e7e6779732a5448c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [aeb099ec66fedbfc6a430f5c6b851989d2461b9b]

        loplugin:ostr in shell
        
        Change-Id: Ia3b9f7dc0ae67f420c3bed370f549a492251156b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-16  Miklos Vajna  <vmiklos@collabora.com>  [55eb6fc8b83fe2f846a4f7448271a5b0fe03fbfc]

        CppunitTest_sw_rtfexport7: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: Ib8badf6c7a75ee58bace05dfc3ef8732fd8bc264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167719
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-16  Noel Grandin  <noelgrandin@gmail.com>  [f3cced4ab2c3ddb7a83fd697334df490b11a9c8f]

        use more officecfg in xmlhelp::TVChildTarget
        
        Change-Id: I3d5762e275317937c4ce3aafaf9e3a359efc2907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167703
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8cda679913bac83324c222c31c417f2ee7e2924b]

        tdf#146619 Drop unused 'using namespace com::sun::star'
        
        now that find-unused-includes was expanded with detecting these
        
        Change-Id: I9f21ad1a85c1e3178cad98464b2ba407d909b62d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167638
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e3ca92bcfda624136af5ba741fef8f732f2856fc]

        Drop unneeded 'using' instances
        
        found with bin/find-unused-using.sh
        
        Change-Id: I647f493ee313e79e7a9967960ea089b729de59a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167637
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [84da5e360a635d9d0f2e1e4e6ac56eb81df8b5b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c42e46cb11f0d46bf918f3cc276750e380ed4af5
          - tdf#159872 More precision on RANDARRAY function
            
            after https://gerrit.libreoffice.org/c/core/+/167645
            
            Change-Id: I1ab0d6da97e0552bdf39d3670ddb953e00f2e81f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167700
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-05-16  Weblate  <noreply@documentfoundation.org>  [da7ad97bd014252d9757c407487929a518eee4f5]

        android-viewer translated using Weblate
        
        Japanese currently translated at 39.8% (47 of 118 strings)
        
        Change-Id: I9efdbae451a5313cb5b8ef4a1abca4bbc69e434b
        Co-authored-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ja/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167630
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-05-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1b45ca1aa7d7cb8e7adcc07f8c60e26a413eca8c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to de95bc710fa1d7d50842da37e06063a9157d2223
          - Fix bad link in contents tree.
            
            Change-Id: I571354d3cc458c88230cdb5b6b51f98baefa92ec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167701
            Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
            Tested-by: Jenkins
            
2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8814788dc077ea810da0473b996a6a2d1ff402f]

        Fix typo in code
        
        Change-Id: I2529fd2bf9e79b704fbe594bd6b7399cba5c3a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167443
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6a8342d2afa4b961d3428cada96002ea01cdd4eb]

        Fix typo
        
        Change-Id: I4db8ceaa0703aeab5b1b6737ad2f768e4ad8c89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167442
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4e0a5d65003ecafdc3c0cc8b764003d8015327b8]

        Fix typo in code
        
        Change-Id: Ib7286237ae037bf5ba9018a80f642454c6c5b2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167441
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c431b016bc3bb56d014eaff0dabefc837797461e]

        Fix typo
        
        Change-Id: I628ba1da49bbcc4d7ce11901abc01525ee8b5abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167440
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b1fcb78dd112395e86c3ecc1820f588cf3ea4f2f]

        Fix typo
        
        Change-Id: I9a62adf2557fec84d18dd4df72d94a0466f0cf98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167439
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f597c881033c0cdbeade324f18130e2b55368d90]

        Fix typo
        
        Change-Id: Ia19534f38ed01a44262b47ad04e98dde6948669b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167601
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2fb694785d057418c23a90f16eade5b8c4767ff0]

        Fix typo
        
        Change-Id: Ie9ba968e786d5af66bd9bf78a1ba4359e6a6621c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167666
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-05-16  Justin Luth  <jluth@mail.com>  [ebf7d87fa4cb7ceac80190f48b7d035aa9469acf]

        NFC typo: rename to consistent bFirstLineOfstSet
        
        One version spelled "Line" wrong (Lin),
        and the other version had poor "Ofst" capitalization(OfSt).
        
        I decided not to make it "Ofset" because then you get
        "OfsetSet" which looks a bit more redundant,
        and then m_aTextNodesHavingFirstLineOfstSet should also be renamed...
        
        Change-Id: I7e443827491abf79a826ec4698f22292e8f15e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167650
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [f85f2a1fffaeb9fdd0ec5247dd3a414133d5991b]

        lpsolve: remove obsolete dmake patch
        
        Added with 249a4da9cd5217b0c340edd779bd17e44e21d678
        "warn free build of dmake, concat-deps and lpsolve"
        
        Change-Id: I1c8eb1e4882526749fe5f46906cdea05e62386a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167698
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5835c23cdf533be015e64d61ce1df250180f1fb]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I1d603f804bada2a6cd9fd8784da4de125a2b87fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167663
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-15  Szymon Kłos  <szymon.klos@collabora.com>  [d5ff0410e7df5ca95ec3076386881e49eb46ddca]

        lok: don't show separator conversion dialog
        
        in online it is more likely that you run file not
        created with your user locale. Don't show annoying
        dialog about separator conversion in LOK as we didn't
        show it before. Recently we enabled it and it become visible.
        
        Change-Id: I5a37865dbe63bca0c55205b59be3a64ceb824b17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167281
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 83269aa84a0af8b9a32424af6b01815aaad4f42a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [12008e10549aa3fe23063eb1af38fb3e86064d3e]

        loplugin:ostr in xmloff
        
        Change-Id: I24f5626e57e03217e4bcf77289c785e255b9f904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167667
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ffd199021ec24e3fb2028708a6a191bf5dd49e41]

        Use less SdOptionsSnapItem->IsRotate/SetRotate
        
        in favor of officecfg
        
        Change-Id: I7c08ed5154d8f3c369c28d05381e551fa9639ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167538
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [4527af4388dae61c4cc5feabd40c0a04e32c8a98]

        Java-WebSocket: Upgrade to 1.5.6
        
        Downloaded from https://github.com/TooTallNate/Java-WebSocket/archive/refs/tags/v1.5.6.tar.gz
        
        Change-Id: Ie6c86b3f7e41147133919daca699a6c96372e44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167665
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-15  AmandaQuaresmaCoutinho  <quaresmaamanda4@gmail.com>  [450edc617aa28b003f02204a1748986a21da3ddf]

        tdf#158337 Use C++20 std::erase instead of std::remove followed by erase
        
        Change-Id: Ia75e19d21f0566ba589974bc2bad6da77c6252e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165925
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2024-05-15  Michael Meeks  <michael.meeks@collabora.com>  [113dabb58dcab72ad17d5c2ab21a86e6825d90dc]

        lok: get faster ModifiedStatus from the core.
        
        Gives a more responsive UI, closes a number of races, and helps us
        to make better decisions, more quickly on whether to save.
        
        Change-Id: I6e2548f06f715ba56ba75fd746273bdd57dc20dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167635
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 44e79f02241fbc213462df03a37b621cb72f9d05)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167469
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-15  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c1565b8b94548ef85508b0302ef9299f18ff09be]

        tdf#126573 Add Excel2021 array function UNIQUE to Calc
        
        Add new function called UNIQUE to the function list.
        
        (TODO: dynamic array in separate patch, oasis proposal)
        
        Change-Id: Ie138aee545995d4af1e66be5a4cf4e99e6e2f581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167484
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-15  Patrick Luby  <guibmacdev@gmail.com>  [2a9eb581f0edfae8123018006df5cc9de1e1fd45]

        tdf#160690 set an opaque alpha mask for non-transparent frames
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, an empty alpha mask
        is treated as a completely transparent bitmap. So revert all
        of the previous commits for tdf#157576, tdf#157635, and tdf#157793
        and create a completely opaque bitmap instead.
        
        Note: this fix also fixes tdf#157576, tdf#157635, and tdf#157793.
        
        Change-Id: Ic2ccad6ab94e4d43b1b66013f85955d474dc0151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167563
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [eee70d4e776a970a700db5379355292c480f8a02]

        loplugin:ostr in xmlhelp
        
        Change-Id: I8330bfe9cd4f551824b0c908f7902f10b1111efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e267990695548db227c918679b907c60263cb81]

        loplugin:ostr in xmlsecurity
        
        Change-Id: Ifb936c230f68447b3bb5993705adb5e5b790371f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167668
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-15  Eike Rathke  <erack@redhat.com>  [11bfced0a4f1d5f3ccaf8e1c87c11733ca71f29d]

        Unit test for tdf#160985
        
        Change-Id: I721d127b145b6524a946c42eb23f8004c700db11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167648
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-05-15  Eike Rathke  <erack@redhat.com>  [1ea85e8f2d815e6c0834215714ed3dad1101b971]

        Resolves: tdf#160985 Max integer representation for rtl_math_StringFormat_G
        
        Same as for rtl_math_StringFormat_Automatic we want to preserve
        the highest accuracy of integer values also with
        rtl_math_StringFormat_G if nDecPlaces is large enough, instead of
        possibly rounding into 15 digits. This occurred with
        FastSaxSerializer::write(double) but rtl::OString::number(double)
        and rtl::OUString::number(double) and rtl_math_doubleToString()
        and rtl::str::valueOfFP() and rtl_str_valueOfDouble() and all
        places calling with rtl_math_StringFormat_G are similar affected.
        
        Question might remain why those places use
        rtl_math_StringFormat_G with fixed nDecimalPlaces calculated from
        RTL_STR_MAX_VALUEOFDOUBLE - SAL_N_ELEMENTS("-x.E-xxx") + 1
        instead of rtl_math_StringFormat_Automatic with
        rtl_math_DecimalPlaces_Max.
        
        Change-Id: Ib388b119faed441c9020dca803649a4089da5b07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167647
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [045a21f08abff10592fe303abf0f311a83777e81]

        loplugin:ostr in ucb
        
        Change-Id: Ic2209e0fbc7035a909eebdbb085d77c9353988cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167655
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-15  Michael Stahl  <michael.stahl@allotropia.de>  [534d3818aedfa95ad73935235462f5ec2817f5da]

        tdf#160897 sw: layout: fail SwTabFrame::Split on footnote overlap
        
        The bugdoc has a table in a section, and the cells contain many
        footnotes.
        
        Somehow commit c303981cfd95ce1c3881366023d5495ae2edce97 introduced some
        layout looping, and it also looks worse than in 7.5.
        
        During lcl_RecalcRow(rLastLine) it may happen that first some footnotes
        are moved off the page, then the table/section grow during text
        formatting, then the footnotes are moved back onto the page, so the
        footnote container is the same size as before, the body is the same size
        as before (because it shrinks whenever the footnote container grows),
        but the section and table don't fit into the body any more.
        
        This fixes the layout loops, and also there are no visible overlaps of
        body(table) and footnotes any more; however, the layout is obviously not
        perfect, many footnotes are on the wrong page and there are some gaps of
        empty space on some pages, but at least none of the footnotes are
        numbered "0" any more.
        
        In 7.5, there was overlap of the body and the footnotes on page 1 and 3,
        and also the irritating effect that moving the mouse over
        the bottom of page 3 would relayout the document multiple times...
        
        Some other ideas that don't work:
        
        * it doesn't help to call Shrink() on the section frame, because it has
          ToMaximize() and does not actually shrink.
        * one aspect of the loop is that the section is always size-invalidated
          even when it doesn't change its size during SwTabFormat::MakeAll()
          and the idea was to detect this (invalidation flag set on upper but
          same area as before) and reset the flag, but this prevents shrinking
          the section to fit on the page
        
        Change-Id: I6074b5c2615a0d7f613edebe92b5350efdd7fe02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167693
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-15  Miklos Vajna  <vmiklos@collabora.com>  [82dd81a9d2049ac95535880fc67c1867f90e1427]

        tdf#161083 sw continuous endnotes: fix layout with a section at doc end
        
        Open the bugdoc, notice warnings like:
        
        warn:legacy.osl:15059:15059:sw/source/core/layout/wsfrm.cxx:910: Frame tree is inconsistent.
        
        Which means we try to insert the new section frame under body frame, but
        the insert point is behind a frame which is not a direct child of the
        body frame.
        
        This went wrong in commit 6885dcd7ec7b82a946d8344bfc27a3e88eecc44a
        (tdf#160984 sw continuous endnotes: switch to a section-based layout,
        2024-05-14), where I didn't consider the case of having a continuous
        section break at the Word doc end, which maps to a section frame before
        the section frame of the endnotes in Writer.
        
        Fix the problem by walking up the parent chain till we find the last
        direct child of the body frame, which is typically not required, except
        when having one or more (nested) section frames at the end of the
        document.
        
        Interestingly tdf#143456 had the same problem, which was the bugdoc to
        trigger the revert of the old continuous endnotes code for DOCX in
        eeda1b35a6e87d5349545464da33d997c52f15e3 (Revert "tdf#58521 DOCX import:
        enable ContinuousEndnotes compat flag", 2021-08-10).
        
        Change-Id: I664672b91087217008a42120e8201c39e2a0a423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167691
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [81e7c91e7d55f20705855d18e6a74db8ae45057d]

        Review RANDARRAY arguments explanation
        
        - As discussed in IRC, remove potential ambiguities in Min and Max
        - changed "Whole number" to "Integer" to distance terms used in other
          suites
        - Rephrased main RANDARRAY definition
        
        Change-Id: I5e557f1e11ce321652df04a300f2cc4103fe1161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167645
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-05-15  Michael Meeks  <michael.meeks@collabora.com>  [06f1787d50fd6dd510917e53f4842d88725b32d1]

        lok: use of lok random hook in NSS.
        
        This allows us to avoid opening /dev/urandom which may not be there.
        
        Change-Id: I51727fe4a2a28be802afdf6d9ccca5a198167b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165851
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 708663da401e1cc5c4531c8cbb3370c4cf2843d6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167670
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea49dde289c9c5799c8b85983bae1c0ab294a3cb]

        loplugin:ostr in toolkit
        
        Change-Id: Ia70d03713bfb7621196d2bd12473d3cf1c2ef1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-15  Miklos Vajna  <vmiklos@collabora.com>  [6025ac371bd5cd07c0af550d78db323ad394173b]

        tdf#160952 sw: ignore top margin only at page top, not e.g. table top
        
        The bugdoc has a table at the top of the 2nd page and we ignored the top
        margin inside the table cell (for the first paragraph), while this
        doesn't happen in Word.
        
        As mentioned at
        <https://gerrit.libreoffice.org/c/core/+/167221/3#message-c03abf8e8e3cd20d49006058e6b3eb130585ff8f>,
        the old code assumed "top of the page" for all frames not having a
        previous frame, while that code was only tested with text frames
        directly in the body frame of a page frame.
        
        Fix the problem by limiting this "collapse upper spacing" behavior to
        frames directly in body frames. This keeps the old bugdoc working, but
        is meant to restore the old, wanted behavior in other cases like e.g. in
        table cells.
        
        If later it's discovered that upper spacing collapsing is wanted in
        other contexts, those are best added on a case by case basis.
        
        Change-Id: Ieb93facd8b2e7f6412fd20873c10ce6c8b775619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167631
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [75111c745a29552aca864fc218aec9b731e7d106]

        loplugin:ostr in svgio
        
        Change-Id: I9869f8558a69d5a6b6ac3165c627b943c00e787e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167653
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [436f823c7c5497f2b22762cec5849a0ff84c220b]

        tdf#161073 handle is supposed to be freed automatically on failure
        
        and is since:
        https://gitlab.gnome.org/GNOME/glib/-/commit/747e3af9987b37847d7d5acbf882d1ee4a6bd91b
        
        Change-Id: Ibb648ccf69ff892fc1e2a3c3dc4da1fffd577c92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167657
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [56f7ebbc0988a64cdc9ea41dcca37c4290497c2b]

        add explicit png build dependency to xpdfimport
        
        src/sfnt/pngshim.c:298: error: undefined reference to 'png_create_read_struct'
        
        Change-Id: Iafb7b685f09347f711b9221362f999b3d48c9bda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-15  László Németh  <nemeth@numbertext.org>  [4c7686b7e1f4d012c00892f1cac1ae8a3298da5a]

        tdf#156792 sw Catalan AutoCorrect: no superscript ordinal indicator
        
        According to the orthography, disable superscript for the Catalan
        ordinal indicators (only used for -a): 20a, 20è, 20ns, 20es.
        
        Change-Id: I2a3cd17b51a29300e9cfcacdcf0cb123d225248a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167652
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-15  László Németh  <nemeth@numbertext.org>  [7cc712eaa6757a461ac68532d77add2a49bd9181]

        tdf#44293 sw AutoCorrect: fix Portuguese ordinal indicators
        
        Add missing dot, support plural and alternative forms with 'r':
        
        – add missing dot: 1a -> 1.ª, 1o -> 1.º
        
        – support plural forms: 43as -> 43.ªˢ, 43os -> 43ºˢ
        
        - support alternative forms:
        
          1ra -> 1.ª, 1ro -> 1.º, 43ras -> 43.ªˢ, 43ros -> 43.ºˢ
        
        Change-Id: Ibaeae958ca209edffb13f611ee8a71c80bf15a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167649
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-15  Noel Grandin  <noelgrandin@gmail.com>  [9091fb1c1ee9628e5e43d9d1776fae7b0559228c]

        use more officecfg in SvObjectServerList
        
        Change-Id: I049dedc577e2dc9c44417b041004a9180c19dc59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-15  Noel Grandin  <noelgrandin@gmail.com>  [0b8f585f8a3123e06d700dc18f4df1ec7d463440]

        use more officecfg in OSDBCDriverManager
        
        Change-Id: I2b1758572a6436d829d547d60bca5fa2d1a3c98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167641
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9f4dd488e76e20ec29169afdd608144ad8625a4f]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I613c77b9aa34433fab9cfaee83d7468cbf5971d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ad7e95531d791e9c16a38aeeeb17ecaea44d69e3]

        Drop unnecessary ConfigurationAccess
        
        Change-Id: I8ae3273ab048df66fa6a7006cb00af7a4958e337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167569
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-15  Venetia  <venetiarosita@gmail.com>  [a82aaae3686daa7f40b4ba41e837d2e47408153c]

        tdf#70526 Provide start up time measurements
        
        Added support for measuring the start up time between each Splashscreen
        update.
        
        Change-Id: Id38058c89c8524d782bf15cd956c8fba5de056de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163965
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-15  Noel Grandin  <noelgrandin@gmail.com>  [0cf10e8669c6f40a2187624469682c5bbc0bfb4d]

        use more officecfg in DefaultNumberingProvider
        
        Change-Id: I3b11bed579ec2ea86cac7fef57049a2279567a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167642
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-15  Noel Grandin  <noelgrandin@gmail.com>  [6555238fc62a08ef1e8c44e96dc18d38345dd419]

        use more officecfg in CanvasFactory
        
        Change-Id: I3d2b09a0e951a7901af85108537485fdea1dbc43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167640
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [658a212585c56540a17c41111e6829716d4ef4e3]

        Use less SdOptionsSnapItem->IsBigOrtho/SetBigOrtho
        
        in favor of officecfg
        
        Change-Id: Id8b995bba0567108bb372ea9548e58c5f192f3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167537
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d7365c0ff8f5b1ed62e3e2c50511d9255b79ee04]

        tdf#146619 Drop unused 'using namespace' in: ucb
        
        Change-Id: Id415488b11e4d1ee3399388851775d97cc317b25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167639
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b09e436a8b821d6a31d29de99ca610eaf8619c43]

        Remove obsolete TODO
        
        This was implemented recently with find-unneeded-includes --ns
        
        Change-Id: I703f68890f383a474ca33e0b2e122f9f0420a829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167636
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0a6a1f9c161a676df7f7eb96a346e73266bef3b6]

        drop some unused suppressions
        
        Change-Id: I09c0f9740fea3e42ab0bfd00ce839bc5849241ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167611
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23fbbea60768626b033f3c597d24193bb0d2dd79]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I02eb573814e851fcb042f4a4018a3e41c24a68b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [23e3de725e32c05c615a7fd352edcc9f579e5bce]

        use more string_view in i18nutil::PaperInfo
        
        Change-Id: I54e75c14b7dbfbfb03e827b5c6167f1256f2733e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167628
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f6c9cb470e2786ada58b7ba401975375239b610b]

        bump product version to 24.8.0.0.alpha1+
        
        Change-Id: I96d168560db02ea3cad2eb3e428e1d17bc8d10d6

2024-05-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0a2d308343314423fa60188a54c289cef44e43a3]

        Update git submodules
        
        * Update translations from branch 'master'
          to fa6c5405a7696a8b954d555a8373058fb4853bd1
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I40dc7118de79bc8c73cc06ead82fdf936e132ad3
            
2024-05-14  Adam Seskunas  <adamseskunas@gmail.com>  [3e7de6b1bc9f28ba6b69489e7f5c7dc645abc695]

        tdf#144576 Copy a table from Writer to plain text editor as a Matrix
        
        sw ascii filter
         - check for table nodes, output them seperately with formating
           to be displayed as a matrix when copy/pasted to a text file
        
        sw qa filter ascii
         - add new test suite along with test to check for correct output
        
        Change-Id: I8ca31bced3860e8e9752db8530ea6caaf31f2e5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164833
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [779a3b26edb31c3bb70e96e2cfa7ca17f53496ce]

        createFromAscii -> OUString literals in SvxMSDffManager
        
        Change-Id: I5561df377fe3b67f3d21121502d93e0977ed4dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f8a73a379d97829080367b21d54f9b5fab781c9]

        tdf#161019 tdf#159846 spreadsheet border rendering
        
        regression from
            commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jun 19 12:23:55 2023 +0200
            tdf#150534 reduce the memory consumption of cells when calculating
        
        Change-Id: Id8b52a3a0880bbb6a7aff28f55bcd57cb1cae048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a525895a5f820350dc307969b1e8fd5d218a1ddd]

        Resolves: tdf#146326 restore focus on autofilter submenu popdown
        
        to where it was before the submenu popup, unless the keyboard was used
        in the submenu, in which case restore focus to the menu instead.
        
        Change-Id: Iaa24b4eadf206b877a093529678667927488de8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167580
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-14  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [bcc1b9f22d4b2772c735176e78dfa1e7c8c39b3a]

        Use less SdOptionsSnapItem->IsOrtho/SetOrtho
        
        in favor of officecfg
        
        Change-Id: Iff78afb987bab8829ea595248b8ad434fe9b4cd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167536
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb2655206a1a2684ead8038601c70f4389a5d7aa]

        libcmis: upgrade to 0.6.2
        
        Downloaded from https://github.com/tdf/libcmis/releases/download/v0.6.2/libcmis-0.6.2.tar.xz
        
        Change-Id: I96f00da6a102bf720705060df009f57c6b93b1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167626
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c92eb6800468de34c5aec3690c1b990a4e763c9]

        createFromAscii -> OUString literals in OLimitedFormats
        
        Change-Id: I8acbc47f17da765189a824b067f89e590e661790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167619
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [fcaf6cee081b8e3282ee85672ba376a9bd0aeeb9]

        loplugin:ostr in vbahelper
        
        Change-Id: I7763dd628ba3d4288e52b51e08a5af301f916c1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-14  Michael Stahl  <michael.stahl@allotropia.de>  [9aa22abcbdfe42e516ecc791605e3a1b7ef80327]

        sw: make testTdf131963 less strict
        
        Asserting number of pages is rather questionable because any number of
        things can change that and you will spend days debugging that.
        
        For some reason this test has 12 pages on my libreoffice-24-2 branch
        build and 11 pages on my master build, either of which are clearly
        better than the 2 pages result of the bug that was fixed there.
        
        Change-Id: Ie1e97d5cc973f317a2d6ca8a7d13822385b134f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167627
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [461dac862c6e8ceb71d4b46ae43c9073b344fcea]

        harfbuzz: Upgrade to 8.5.0
        
        Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/8.5.0/harfbuzz-8.5.0.tar.xz
        
        Change-Id: I1a6df8f5ecb91d93a88c9b6770e603c8df4bc2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167623
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07234f2b7ccc1ffa1e253344193982bad04104f1]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I3a65485cc890d6bb6bf1197a3f296634ebffa02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [194e5bfaf79c0a15fee07bfe8326c3f3ceb783b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fa4dcadb1517c66282f5fc33bf5e42a6cb305609
          - tdf#159279 On page numbering
            
            Added link to Title Page feature
            
            Change-Id: If802ebc475caee266dce5257d46662ecc7a0a515
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167610
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2eb5a202bb5c20658aa8ef030f811b626709a6f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c31e6a310406bf57c7c9dbdc06b0466b46593d3
          - tdf#159872 Help for RANDARRAY function
            
            Change-Id: I5ee6dba1f757bf2ab2c4659cc9a151e4210cf97d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167608
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [426084531b730dbde95351e17187da888da83636]

        vcl: document and simplify PDFAnnotationMarker
        
        Change-Id: I0e03e5a009500144abcf9b35ca2224b60837872d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167568
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2791964914ba19b636ce49a60508bcab7af675cd]

        annot: move TextAPI to svx and adapt the code
        
        TextApiObject is derived from SvxUnoText and holds and handles the
        text in the annotation. This functionality is changed to get rid
        of sd module specifics and moved to svx module. This now allows to
        move the most improtant parts of the Annotation object to svx.
        
        Change-Id: I34e238616e7fac973e75e79bb60a8d093c493258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166497
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7dd7cb6f6c6812fc9ef56de3114d07c68e02f2b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bc1435efdd13fb2f2b6cf78e946c7836db54d9c8
          - tdf#127477 Description of date & time functions in the help
            
            Add precision on rounding and trunking of date and time values
            
            SECOND() rounds value to nearest integer
            MINUTE, HOUR, DAY, MONTH, YEAR truncates to integer part.
            
            Change-Id: I115557dd85a9328185b197abfcd233b62b0beb78
            reference: https://bugs.documentfoundation.org/show_bug.cgi?id=127476#c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167605
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e08c22500af085712a2514561996ae882b477ec6]

        annot: use smart pointers in TextAPIEditSource and clean-up
        
        rename TextAPIEditSource_Impl to OutlinerHolder and use smart
        pointers (std::unique_ptr) in OutlinerHolder instead of manually
        taking care of the destruction.
        
        Change-Id: I7b8397be35ad9a7a5c6a461ecb522af15eb5c6ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166496
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-05-14  Miklos Vajna  <vmiklos@collabora.com>  [6885dcd7ec7b82a946d8344bfc27a3e88eecc44a]

        tdf#160984 sw continuous endnotes: switch to a section-based layout
        
        The original layout added in commit
        4814e8caa5f06c4fe438dfd7d7315e4a2410ea18 (tdf#124601 sw: add
        ContinuousEndnotes layout compat option, 2019-09-30) puts endnotes to
        the footnote container on the last page, which fixes the page count but
        the endnote position is wrong: should be after the body text, not at the
        bottom of the page.
        
        Now that we can have an endnote section (with one or more section frames
        at a layout level), we have a container that can span over multiple
        pages, is at the end of the document and is inline.
        
        Fix the bad position by:
        
        1) Reverting the layout changes from the old approach, which gives us a
           bad position for the endnote.
        
        2) Creating an endnote section frame on demand in
           SwFootnoteBossFrame::AppendFootnote().
        
        3) Moving part of the endnote to a next page works out of the box, but
           moving part of the endnote to a previous page needs explicit handling
           in SwFlowFrame::MoveBwd(), similar to how SwFrame::GetPrevSctLeaf()
           does this in the simple section case. This needs explicit handling,
           because the body frame of the endnote section is empty, all content goes
           to its endnote container.
        
        Note that this just reimplements the compat flag, but its enablement
        (only for DOC import, only for <= 2 endnotes) stays unchanged for now.
        
        Change-Id: I8b271895aeff378418aed8705fe6b99a69232bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167616
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [204c5e14188022f34afb05776eb20669b01ea6d4]

        tdf#160753 - sc: fix XMATCH function in search for empty cell
        
        gave back a wrong result. With this fix the we can search for empty cells
        and return as a result.
        
        follow-up commit: 8df17c340193c89549d8c563b04d015156afa3fb
        (tdf#160711 - sc fix XLOOKUP function search for empty cell)
        
        Change-Id: I48a545125bdfa23c98a4fcb866ea782156a0b32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167596
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [008f4273ae201b5bebfd728a3b59958de49279bf]

        loplugin:ostr in test
        
        Change-Id: Ie261167fc3e1ed9073210e0f8b179455da340c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167620
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [b56ca52cef77d4d1f99bc3edd89b2557e5cb2cfb]

        loplugin:ostr in starmath
        
        Change-Id: Ied15eb71ae3ae2d80ba839a6c99ea3cf620ca52f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167598
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-14  Jaume Pujantell  <jaume.pujantell@collabora.com>  [1d83ac544dcd2fbfb0aa19065e16ed82c40d0c86]

        sw: avoid unwanted row height changes
        
        When changing a row's height with SID_TABLE_CHANGE_CURRENT_BORDER_POSITION
        avoid knock-on effects to lower rows.
        
        Change-Id: I0af5a6ec2ceb685ec5dd97e4a00237a4c7857589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167438
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit c6c1c7afc18f32453c06a3af25f389ccb9074a1b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167459
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [320555963d69cbe19570a555a476d0ae757fef98]

        loplugin:ostr in svl
        
        Change-Id: Idae670a53d6d9aab0ec7132077f3e7b7f6fa5287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167595
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [e99991216e47751b80238825aaeb21702d46dc34]

        android: Fix taking photos by dropping permission
        
        At least on recent devices (seen e.g. on an AVD
        with API level 34 and a Fairphone 3 with LineageOS 20
        (based on Android 13)), inserting a picture by
        taking a photo using the camera didn't work,
        "nothing was happening" when choosing the corresponding
        option from the formatting toolbar with experimental
        editing mode enabled.
        
        This is due to the system filtering information about
        other apps/packages with target API level >= 30 for
        privacy reasons, see [1] for more details.
        
        As described at [2], requesting the `CAMERA`
        permission is not required:
        
        > Users might take pictures in your app, using the pre-installed
        > system camera app.
        >
        > In this situation, don't declare the CAMERA permission. Instead,
        > invoke the ACTION_IMAGE_CAPTURE intent action.
        
        In fact, specifying the permission is even counter-productive
        and would cause this to not work, as also described at [2]:
        
        > Note: If your app declares Manifest.permission.CAMERA
        > permission and is not granted, then the action results in
        > a SecurityException.
        
        Rather than explicitly requesting the permission, just
        drop it from the AndroidManifest, as it's not needed.
        Also drop the additional code interacting with the package
        manager, as that doesn't work with newer API
        versions as described above.
        
        With these changes in place, inserting a photo works fine
        in tests in API 21 and API 34 AVDs and on the
        above-mentioned Fairphone 3.
        
        [1] https://developer.android.com/training/package-visibility
        [2] https://developer.android.com/privacy-and-security/minimize-permission-requests#take-photo
        
        Change-Id: Ia1ee4e4de577a269e2b79bf5460d08b1bf2bee56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167603
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [5ad26dfac2a4d3f209721c5c3c9b7b6d6ad71a6f]

        android: Don't restrict taking photo to rear camera
        
        Check for `FEATURE_CAMERA_ANY` ("The device has at least
        one camera pointing in some direction, or can support an
        external camera being connected to it.") [1] instead
        of only the rear camera via `FEATURE_CAMERA`
        ("The device has a camera facing away from the screen.") [2]
        when taking a photo is selected in the "Insert" menu, as
        there's no need to restrict this to the rear camera.
        
        This addresses this warning shown in Android Studio:
        
        > You should look for any camera available on the device, not just the rear
        
        Note however that trying to use that feature (with or
        without this change in place) currently doesn't actually
        work at least on a current device (e.g. an API 34 AVD),
        "nothing happens" rather than the camera showing up to
        be able to take a photo. This will be addressed
        in an upcoming commit.
        
        [1] https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_CAMERA_ANY
        [2] https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_CAMERA
        
        Change-Id: I52d2147df8fb3f1fdfb277376d7796380f9a8da0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167602
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [a24b79b91357a451d2bfa22a8543b076a2f4873e]

        android: Update com.google.android.material:material to 1.12.0
        
        Change-Id: I4ac5b67ddf978d6646dbbd67f858ffad3a6adeca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167587
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [1610ebc06b34263bf3e525babe1e583b932f6242]

        android: Update Android Gradle Plugin to 8.4.0
        
        ... and gradle to 8.6, as suggested by Android Studio.
        
        Update the lint baseline file to initially ignore
        new warnings that the new version reports.
        These can be handled separately.
        
        Change-Id: I6ecd7300072c16ea583b5ba19b03de89d671b87e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167586
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-14  Michael Weghorn  <m.weghorn@posteo.de>  [869b88488ac443cc64943254064da20b0f361c56]

        tdf#160824 vcl: Require mouse over spinfield to mouse-wheel through values
        
        In the same way that
        
            commit 22250df05830700b2555348b8ac46ee1007d0e5d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 8 11:50:40 2023 +0100
        
                tdf#158548 vcl: Require mouse over listbox to mouse-wheel through entries
        
        restricted changing listbox values for the focused
        listbox on mouse-wheel to the case when the listbox
        is also hovered over by the mouse, do the same for
        `SpinField` as well, to avoid accidently changing
        the value as described e.g. for the tdf#160824
        scenario.
        
        This is also in line with Qt spin boxes that
        only change their values on mouse-wheel when
        the mouse pointer is above them.
        
        For the gtk3 VCL plugin that uses native spin boxes,
        this commit has no effect, and the value doesn't
        change on mouse-wheel at all.
        
        Change-Id: I22277294f76655cd13b1dc57416c82afe44460d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167604
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [1201d3d6b0457bac30105bf5371c76a4ef69f29a]

        tdf#161054: drop support of last empty span as paragraph mark format
        
        Commits 6249858a8972aef077e0249bd93cfe8f01bce4d6 (sw: ODT import/export
        of DOCX's paragraph marker formatting, 2022-12-19)
        and 209dce614c43f63f63f5b42a746665c0ec1cbfe3 (sw: fix ODT import of
        paragraph marker formatting, 2022-12-20) introduced support for paragraph
        marker formatting in ODF, using an empty trailing span. Later, commit
        1a88efa8e02a6d765dab13c7110443bb9e6acecf (tdf#155238: Reimplement how
        ListAutoFormat is stored to ODF, 2023-05-11) changed how the data was
        stored in ODF. Then, in commit 69ed893087f89d176a5ec4b263ce8d75774be72b
        (tdf#160253: fix list identifier export decision code, 2024-04-24), some
        remnants of the older "trailing empty spans" were removed, but a code
        was added in XMLParaContext::endFastElement, to keep backward compatible
        with documents created in the frame between December 2022 and May 2023.
        
        The said compatibility code brings own problems, requiring new hacks
        like commit 2ca93eb5df7ddb8641ff7d884a109261c9700aca (tdf#161023: Empty
        spans may only define paragraph marks in text documents, 2024-05-13),
        and keeping the code would need more hacks on top, e.g. to fix the case
        in ODT documents.
        
        Instead, let's bite the bullet, and drop the compatibility with this
        initial implementation, because it was only a brief period during which
        the documents could be created, which can be affected by this drop. This
        makes the code simpler.
        
        A testdoc for testNumberPortionFormat was edited to use the new markup
        for the paragraph marks formatting.
        
        Change-Id: I053e72dd1cc2ead83baa6ce7d24c8522b494c8fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167583
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-14  Regina Henschel  <rb.henschel@t-online.de>  [47664e282da4999b8e471a6a916d7ec80414ac18]

        tdf#84507 move contour text to correct place in rotated...
        
        ...path objects.
        
        I first tried to change the UnitPolyPolygon in
        ViewContactOfSdrPathObj::createViewIndependentPrimitive2DSequence().
        But it is needed in that way to draw the geometry of the object.
        Now the change is made in SdrTextObj::impDecomposeContourTextPrimitive().
        
        The basic idea is to recover the original PolyPolygon and transform it so,
        that the transformed text is placed into the transformed PolyPolygon. The
        ObjectMatrix gets a translation then, which moves the transformed text to
        the correct position in the PolyPolygon.
        
        For East Asian writingmode tb-rl, the text start needs to be top-right.
        Added that, which resolves bug 128433.
        
        If the shape has a fat stroke the text reaches into the stroke currently.
        I have changed the code so that now a reduced area for the text is used.
        The polypolygon behaves now same as the legacy rectangle.
        
        Sometimes not all text is drawn although the rotated PolyPolygon would
        have enought place for it. Or in other cases the text spills out of the
        PolyPolygon. But I don't know a solution yet. As the other changes are
        an improvement, this problem can be solved later.
        
        Change-Id: I951024bf0d6d992587ec9cf2ed37665f322b66fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167299
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5265c69ed6aa2a5f88cf939c64683552e587e575]

        poppler: Upgrade 24.05.0
        
        * external/poppler/char_traits.patch is no longer neeeded
        after https://cgit.freedesktop.org/poppler/poppler/commit/cpp/poppler-global.h?id=b4ac7d9af7cb5edfcfcbda035ed8b8c218ba8564
        
        * Adapt external/poppler/disable-nss-and-gpgmepp.patch.1
        after https://cgit.freedesktop.org/poppler/poppler/commit/?id=d40bb7e308c9e3299e50d3e2880229cd6272587e
        
        Downloaded from https://poppler.freedesktop.org/poppler-24.05.0.tar.xz
        
        Change-Id: I87ed833f92e504f0a39b5f64c1db42d579050a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167582
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [25e53d411097849ae9a00af40c6d786fa1daf2b6]

        Use less SdOptionsSnapItem->IsSnapPoints/SetSnapPoints
        
        in favor of officecfg
        
        Change-Id: I578fa667f3a21ebdfacb8602c009558a03facd97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167535
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e6d9c38a7ef4027734064b83ca328df258a575c]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ib7a0f2db7e076eb40f65df5b88d617c459611fbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [df4b0ba2f631e2a99d72011e58ac5e81fbc1dec5]

        loplugin:ostr in stoc
        
        Change-Id: I638b1e12781264770ce742d3303693e3b7fa82c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9cf09844ee35610cbf102895014a7f03f8de100]

        loplugin:ostr in sot
        
        Change-Id: I782a071672b8c1fa2a843637fc5d7e993dbe0ef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [16a9092595761acca0392b4e177b309371d04f15]

        loplugin:ostr in svtools
        
        Change-Id: If00c16527fb861a86f5dde195ab612bbab3a53c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167594
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f739e1f35a600984a4f99d6394e821a71b69712]

        createFromAscii -> OUString literals in ControlLayouter
        
        Change-Id: Ie26d310540944bd17cf25e1521878964f3026562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167593
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d7faf2916f47a0d807d53da32114fff391eb104]

        createFromAscii -> OUString literals in FmSearchConfigItem
        
        Change-Id: Ic4c2e2825c50e3977ac5773b3eb8ae0de2c86ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167592
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4133e187c99b19bd5986d0c8af923e9f1400f82b]

        lxml: fix --enable-python=fully-internal
        
        Originally I downloaded the tar file from https://github.com/lxml/lxml/releases/download/lxml-5.2.2/lxml-5.2.2.tar.gz
        and pushed it to extern
        https://gerrit.libreoffice.org/c/extern/+/167571
        Later I realized the lxml website was pointing to
        another file https://lxml.de/files/lxml-5.2.2.tgz
        which I also changed in extern https://gerrit.libreoffice.org/c/extern/+/167588
        But make fails with
        
        tar: This does not look like a tar archive
        tar: Skipping to next header
        tar: Exiting with failure status due to previous errors
        
        so change download.lst back to point to the first tar file
        
        The commit is extern was also reverted with
        https://gerrit.libreoffice.org/c/extern/+/167606
        
        Change-Id: I8f335d4a0b9d9b41c9c596f188f63bb0691ae11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167607
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8467a1123fd101bf1209ce19a7bb33a5da9d3ce]

        SKIA_IMPLEMENTATION is always defined, either 0 or 1
        
        rather than !defined in the not-building-skia case
        
        Change-Id: Ib27783c958e327b01ab9c8496eee969c6f9c50a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167591
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b3a9032378528a691bc97b71a7464712e18c8f4e]

        tdf#157657 - sc: add option to make data validity case-sensitive
        
        Add option to check data validity with case sensitive and case
        insensitive. The default set would remain the original case insensitive
        mode for data validity.
        
        Change-Id: Ic4fe56e2b31b7fc348b742f3b95fb44cd35bc49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167280
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [96f74d85983fd693d349d593c4389a8f990fdaaa]

        lxml: Upgrade to 5.2.2
        
        Downloaded from https://lxml.de/files/lxml-5.2.2.tgz
        
        Change-Id: I0beaabac69029cb768eff10cf55c6691eb2d322d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167572
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [ae182240328f20508c7a8936daf74a088627540b]

        Update to ICU 74.1
        
        https://icu.unicode.org/download/74
        
        Unicode 15.1
        https://blog.unicode.org/2023/09/announcing-unicode-standard-version-151.html
        
        CLDR 44
        https://cldr.unicode.org/index/downloads/cldr-44
        
        New Unicode blocks:
        UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_I
        
        Change-Id: Ic9196e10138663d07235f5ebd9cc4bf3a9750824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158749
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [b6f9caeb081da2004f067ad9216875c86eead8b1]

        postgresql: Upgrade to 13.15
        
        Downloaded from https://ftp.postgresql.org/pub/source/v13.15/postgresql-13.15.tar.bz2
        
        Change-Id: I17d103c7b489645215b4a54d81f494506e9e90a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167590
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [96698d3a72d8496358786ffedc7b6eb22af3648c]

        Update language-subtag-registry to 2024-03-07
        
        How the file was created:
        mkdir data
        cd data
        wget
        https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
        cd ..
        tar -cvjSf language-subtag-registry-2024-03-07.tar.bz2 data
        
        Change-Id: If1bdeab0ee5853855949dcbbfb00170e897c80e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167341
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [02dc762466c655e9ca6fb7cef92b1495915b34ed]

        libxml2: upgrade to 2.12.7
        
        * Fixes CVE-2024-34459
        
        Downloaded from https://download.gnome.org/sources/libxml2/2.12/libxml2-2.12.7.tar.xz
        
        Change-Id: Ie45ad54b3f781a54a278e2542fccafb8d06542bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167585
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [8a73c5725f0ef0494e0a933cbfc22a8f04328ddd]

        odk: classes in java.lang package do not need to be fully qualified
        
        Change-Id: Idcc8af34095496aa6e7f516d9b2b975f7e58799f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167555
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [98746cca55dd088c34339682e98504dadb11d2c7]

        createFromAscii -> OUString literals in StylesPreviewToolBoxControl
        
        Change-Id: Ica3c79facee725effcfb160738305c599c5de1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167575
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [57dc0cbd8ebfe465f9e21a47c253a8437f8860a9]

        do less OString->OUString conversion in tools datetime functions
        
        Change-Id: I93d012f32b8006019c431b8bf88ab9c7ffb4d3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167574
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6652dae45a469bc0e357ff4755a92992b0856e9]

        loplugin:ostr in slideshow
        
        Change-Id: I87b391b95a75a1ddc4e26dcd0bbd557f8bd3b17b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167578
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c76913a5a8fa73f06197dc6b69ba6f4b7a9b33f]

        loplugin:ostr in sccomp
        
        Change-Id: I45243c0616a70d140293619f57221a609bf473f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167577
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c76b36437625cb533b9e2c28aa0dc2c41630b22]

        loplugin:ostr in scripting
        
        Change-Id: Idde1ec2254cebc9acd8aab092e52632b1625877f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167576
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Printf Debugging  <printfdebugging@gmail.com>  [3eb427b31e624af9b2fe2bd68fee859d3d76a661]

        Resolves tdf#63374 and tdf#160908
        
        Show edit highlight only when arrow keys won't commit.
        Use shorter UI label.
        
        Edit mode can be activated in two major ways, in which arrow keys
        behave differently.
        
        a) F2 | double_click | edit > Cell Edit Mode, in which case, the
           arrow keys either move the caret "|" or "reference cell frame".
        b) just start typing on the cell, in which case, pressing arrow
           keys commit the change.
        
        Edit highlight should be shown in case "a" to differentiate between
        the two. If the cell has some background color, or multiselection,
        then highlight is not shown.
        
        Change-Id: I710aa641cd47e8ca279dd8bd0e3b4e857d1b0c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167092
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0ce15b8a86f950b0ee84a51c901f4261b64e7cf9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71a04be1be73ec7cd27e14e152c01521b3c4b33e
          - tdf#160057 Help update for first and rest page style in Calc
            
            Change-Id: I728452dac691507e0aa2651dac8bcc9908eca70e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167482
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-13  Dione Maddern  <dionemaddern@gmail.com>  [37929d4be4623e1060a7b913e1693e92d823f135]

        Update extended tips for File > Properties > Description
        
        Updated extended tips in descriptioninfopage.ui to make them clearer and match the updated help page.
        
        Change-Id: Iec7fffe75baed29985525ce04c3f4a6168bb3bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167367
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [05d4420c5e3c87dc458dd775039b58fc2baa0489]

        createFromAscii -> OUString literals in INetURLObject
        
        Change-Id: I3c564f469635271d27fa0513d676241ce7ded51d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1942d4c6f9b48554d0dc7ea95c8ec38624f40045]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ib624737d838dfde29018e343f6b51501a5d7f7f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167265
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-13  Miklos Vajna  <vmiklos@collabora.com>  [9c7acbc937b3b341c10187b837e09cc20399f04e]

        tdf#160984 sw continuous endnotes: fix CppunitTest_sw_layoutwriter3
        
        These are similar to commit ab3416cad1dd4e706432f9b1a3592cec823c76b0
        (tdf#160984 sw continuous endnotes: fix
        testContinuousEndnotesMoveBackwards, 2024-05-10).
        
        I've manually verified that the use-case still works as intended, so fix
        the failing tests by relaxing the assert a bit: now we accept endnotes
        directly under the page frame or under the column frame as well.
        
        This way these tests won't break when we switch to section-based
        continuous endnotes.
        
        Change-Id: Ib98d6277534cc2e934595f19927836744eec64d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167567
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-13  Patrick Luby  <guibmacdev@gmail.com>  [4e5040dc44024f8313ca51627b6871675865cdf6]

        cool#5839 fire a clipboard changed event in the iOS app
        
        A clipboard changed event needs to be fired whenever the
        native general pasteboard changes. Otherwise, if the clipboard
        is empty when a document is opened, the Paste and Paste Special
        menu items and toolbar buttons will be disabled and will never
        be enabled even after something has been copied to the general
        pasteboard.
        
        Change-Id: I8a70a2ac4de55593a886233d144dc18c3c57178e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166073
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-13  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [78e0626bc7bf37d1eda2e3151dd1a44056f92032]

        tdf#45705 Integrate zoom UI commands into Calc
        
        This patch uses basegfx::zoomtools to zoom in and out, making it smoother.
        Similar to commit c96e1ec61835bc01e2969ec97fce9a1674fbf6d7 done for
        Writer view shell, this patch makes zoom in and zoom out commands
        functional for Calc the preview shell.
        
        Change-Id: I1612f51d39c507d192237bf2361b91e6e5723c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167389
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-13  Miklos Vajna  <vmiklos@collabora.com>  [74bd51629eed7eb34aef9acbb93c110525f8ef7d]

        svx: prefix members of SdrUndoAttrObj
        
        See tdf#94879 for motivation.
        
        Change-Id: Icecf1b75055c9f487d35ae72589ccb6197cfeaff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167566
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [daf7e7dc3ee1a8ab0d519c1537b9bd83379b98ed]

        createFromAscii -> OUString literals in ConvertChar
        
        Change-Id: Ib430f39042e50036821e957b3406f07276a63fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167562
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [f363b211a6b3900fbf26c7166f8b11b4de9f083f]

        createFromAscii -> OUString literals in CURI
        
        Change-Id: Ife54c8585d87a436e1f754bad42128d2b5631dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167561
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [bf059e3d267c2dbbb11c0735794198ad72ce5dfa]

        createFromAscii -> OUString literals in XMLIndexTOCContext
        
        Change-Id: I93aaf16d75a883b733ebedecfe5625e10bbdc753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a110585d9fd710ba9ca30256cbddb09c77aec96]

        createFromAscii -> OUString literals in AnimationsExporter
        
        Change-Id: I20c35e06fb98df5ffb9d9fd521459e267e4a2fa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167559
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d9d699756125db28bd45d7c92d4c9c2dc243f418]

        Use less SdOptionsSnapItem->IsSnapFrame/SetSnapFrame
        
        in favor of officecfg
        
        Change-Id: Ia9d36f3c2d0f85250da6f3483176c551226164a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167534
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [f4d15c1cf34f8dac870c2771d6317a56b3fdf038]

        Revert "reduce symbol visibility in sw"
        
        This reverts commit 1a6711276f0c8abeb0028a47cc345a7453374a38.
        
        After some discussion and experiments, it turned out this rather
        fundamentally breaks clang's PCH build. Conclusion was: this change is
        not significant enough to warrant making life harder for developers.
        
        Excerpt of errors (affected were vbaswobj, msword & swui libs):
        
        - ld.lld: error: undefined symbol: SwFormat::~SwFormat()
          >>> referenced by fmtcol.hxx:37 (sw/inc/fmtcol.hxx:37)
          >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_vbaswobj.o:(SwFormatColl::~SwFormatColl())
        - ld.lld: error: undefined symbol: SwFrameFormat::SetPositionLayoutDir(short)
          >>> referenced by precompiled_msword.cxx
          >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_msword.o:(vtable for sw::SpzFrameFormat)
        - ld.lld: error: undefined symbol: SwFrameFormat::SetLayoutDir(SwFrameFormat::tLayoutDir)
          >>> referenced by precompiled_swui.cxx
          >>>               core/workdir/CxxObject/sw/inc/pch/precompiled_swui.o:(vtable for sw::SpzFrameFormat)
        
        Change-Id: I1dcf115cc191b1ebf1f8d5023c0c5015f891287a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167549
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-13  Michael Weghorn  <m.weghorn@posteo.de>  [737a07897e7414228d727fd3d16b3bd47ff226fa]

        vcl: Merge ComboBox and ComboBox::Impl
        
        This removes one level of indirection.
        
        `ComboBox::Impl` had originally been introduced in
        
            commit ece8699f8f22f6bae137c601bc29b83b75dc3bf3
            Author: Michael Stahl <mstahl@redhat.com>
            Date:   Fri Jul 10 12:05:48 2015 +0200
        
                vcl: pImplify ComboBox
        
                The boost::signal stuff is quite heavy (33 kloc), so try to hide it
                from the header.
        
                Change-Id: I87826ccfd2a151aff274ffa6b7159a988f751808
        
        , but all of the boost usage in here has been replaced
        since then.
        
        Change-Id: Ia8fb5cb895800edae104857c7713fa65e509a3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167485
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [2ca93eb5df7ddb8641ff7d884a109261c9700aca]

        tdf#161023: Empty spans may only define paragraph marks in text documents
        
        Change-Id: I40607652a0fd8e31c609732daa54bb796e3fffa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167557
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0dcaff6043e1f24ce0fa354dff80a86e40622247]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I6d1ea7e14f5d2a75d485dae69d51cec8c2343445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [3df9a50322dc9f24c87d0095316aadf1ad09ec3e]

        Use less SdOptionsSnapItem->IsSnapBorder/SetSnapBorder
        
        in favor of officecfg
        
        Change-Id: Iaa6801ef773de7d3dcb1f08d4eac4a4f62ac656b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167533
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c79a48a75f7f44b5a042109251e185fc4695cde6]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ica8b3c8c5476f2f0f3bebf0cfcd80b08090c6119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167556
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [24b178cfb6b35789e69d80857e73e911abe338a3]

        createFromAscii -> OUString literals in attribute_set_map_to_property_values
        
        Change-Id: I98f40cba9baf2a21d095af84a07cd794723cb75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8701b4fd4ea9a006c97207bd542dd072f6a92b41]

        replace createFromAscii with OUString literals in FilterConfigCache
        
        Change-Id: I31a16e4b709955cb01d6aebaf169d40f71f7ea09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167551
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [a25333429d2800cd42db866346afbdbed9741c12]

        replace createFromAscii with OUString literals in getImportFormatShortName
        
        Change-Id: I3f62ea563af8e2c9aa5ed558370b49f05804c632
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167550
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0025c300d6e952a4252fb3bdb7b4b91d1f7e59ec]

        cid#1597307 silence Unchecked return value
        
        and
        
        cid#1597304 Unchecked return value
        cid#1597303 Unchecked return value
        cid#1597306 Unchecked return value
        cid#1597305 Unchecked return value
        
        Change-Id: I2fa1c467751405d3b69f1d9b552232e4d52b610e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167554
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [970ee1d96cedef06a65997e40bf4d0402347fadd]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I19824cd8fdc3ac5b5afb4e769527bf71513212fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167553
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [034eb5078096d146fb5c5e6246a407f2aad09094]

        help msvc -analyzer out wrt C6011 Dereferencing NULL pointer
        
        Change-Id: Ied22e4ea805ab5a94f89a71438962bdd6d118771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167548
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [512e28bf8d10f9246df2d535f92c1ccef1628192]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I7a4df11c23a92d0c5538cea4290dcc5e2c9ac3c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb08b5e8617ea7b278eef0acc0606585b294e1db]

        replace createFromAscii with OUString literals in DefaultFontConfiguration
        
        Change-Id: I550a9a2c069b43cc8824d3b26736f656393a5afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167546
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd77596dd8e3f6d3660ce5b096d8160502e13a70]

        replace createFromAscii with OUString literals in OConfigurationValueContainer
        
        Change-Id: Ib94018bfc542c91c01894006076eb16023d104ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b075d020ce25cff28a12fabad69d8677f7b8f2d]

        replace createFromAscii with OUString literals in INetURLObject
        
        Change-Id: Ibad8181624afd745e2fa501cdcc7a5d915dfe6ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [cae37f77232f142f5d27c945715a9d3f6e06a9e2]

        replace createFromAscii with OUString literals in SvxStyleToolBoxControl
        
        Change-Id: Ibdf5f7b0100cafbecc263a038b2234012da10fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52a06992f1404a4b85f99aedd75377fd60a489b9]

        help msvc -analyzer out wrt SkASSERT
        
        Change-Id: I32387c80273d0bc080e47a1d9ccf7454a4a3d79a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ec327662a11554fe407c83abaf0ddbb97e73ed7]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ieabea4a0ddf8f95ea01b8b0275be0924ad055694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db6f4c29ad2cb5cef009f78bbe6387a9e65a45a6]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I83952aef1fd44d2b49cbaa2324283c14c83723de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167522
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4eda68181eb422f4e58e4dccd93b1d9165afff8]

        add noreturn to boost::spirit::throw_
        
        Change-Id: Iac1d998a408d756f50f7c18944f4e1f8afef2e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167523
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [642e1809eb59872e6ca02e1bc8fb5dd897c63212]

        extend comment on parallel group calculation a titch
        
        Change-Id: I3cdb757d1959af17b74a8b973010a8d0f477cfe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Szymon Kłos  <szymon.klos@collabora.com>  [fd14f65baf4de94c053cb3e2cc277e7d3650d4fa]

        jsdialog: enable Object Name and Description dialog
        
        and send uno command enable/disable status
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Id643a27308809b6960be72fb368b9f078ff9cf6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167296
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167521
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c24f8262c884d9587ca40f3abb6b1a760c6522da]

        Use less SdOptionsSnapItem->IsSnapHelplines/SetSnapHelplines
        
        in favor of officecfg
        
        Change-Id: I3f9d62380449c888b47020b4ffc765e9e8aa36ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167532
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [017045b6545a56c5980c63c80e04a80d502b21bb]

        replace createFromAscii with OUString literals in SvxSearchItem
        
        Change-Id: Ie1dc68bd5c5550718103f9ecbbb2fa707c950ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ffe136bc2951c3be5005c1bc304ca7b9742fd78]

        replace createFromAscii with OUString literals in OConfigurationNode
        
        Change-Id: I487828fd11e1b22da2cc651b413f0744bf43b6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12099436f782ec27b1dd8eb4b7dd3baf34d55168]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I2fddf8ae5803041344fe63c4375fe5a3ee46fed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167520
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4a110f8c274731959868c1f899360cc69694a71]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I85aa6c2f100823d1d39e24ab3ffcb0c44f66354e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167519
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [744dfe387bc7512cd028b1de43b956bd0974377c]

        replace createFromAscii with OUString literals in EnhancedCustomShapeTypeNames
        
        Change-Id: I69b89d7ee86c1d0b2dbdc4553cc12c01bdd76d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167530
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad40932a04fe0b71669651675417765c82ccbb79]

        replace createFromAscii with OUString literals in ScIconSetFormat
        
        Change-Id: I5af0128c55608bf6192af4dc46f9476393a15afa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167528
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [210aff2347afb95b683a591469db611dc263272a]

        replace createFromAscii with OUString literals in ScXMLEditAttributeMap
        
        Change-Id: I7ab70713b2ee69eccedebeb09b8ea5879736a830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167527
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [0bcb62c6b71eb3f886e6d4885b1c2b691ce810b6]

        Related: tdf#96671 Also handle other Windows architectures
        
        Change-Id: I8b3a9c10781450083ae2cdeb8614b42e33bf9520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167531
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [ccdb98c0e590281f63a8c180a2eb87086210efbd]

        Drop some uses of css::uno::Sequence::getConstArray
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I64683093afc48ddf2307dc1dee2302cf0b3cbecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167110
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4f07d4c08724602d0a13045bec957e285d45c0d]

        replace createFromAscii with OUString literals in OConfigurationNode
        
        Change-Id: I19017bc993f0adafdae32313e0e01e69e1bbe80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167517
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9dac3118ee80bea900cede71e4ef616bad165401]

        replace createFromAscii with OUString literals in OConfigurationNode
        
        Change-Id: I6029cd4c894c6ab079cc508ba15df41ec5d4f8db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167516
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [18c4a2592e650c71f11d0443a3eb9b262c176c3a]

        replace createFromAscii with OUString literals in ImageManagerImpl
        
        Change-Id: I995f3f565c01ba85ae470c506facb1f6e5d517a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167515
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c2ec1708ea58cb723c9dc2f35683dc2f318136d3]

        Drop now unused SdOptionsZoom class
        
        Change-Id: I73100a18f9edb37bb93b7612e7e34fdf510a5308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166630
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e4643d9653e18e5c1690289e72f589907550970]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I95441e62c33bdc5c22dad2fc25a072d9ce93e4d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167514
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b901f746a2c2c7979cb2a06f3a165ff0dd41a36b]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ic703c92165ba7f0a43d25bb2899b6455e2e2f312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167513
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2545fffcbdd9d88a57abd4842719b40d0ed45ec]

        replace createFromAscii with OUString literals in ControlFeatureInterception
        
        Change-Id: If0fbaafbaa318ec541341fde723f92f3e8e92cfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167510
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4f2dbe6001109a61f009fc0df74f14071ac8645]

        replace createFromAscii with OUString literals in OpenDocumentButton
        
        Change-Id: I989f5f82fe65e0f877d86b7eb98ba8ad57147988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167509
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ea8e12e50579c60ccc244fc8e3414026ad82c61]

        replace createFromAscii with OUString literals in SbaTableQueryBrowser
        
        Change-Id: Ic822faea02d1d598e7b5deb846a88ae59994535d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167508
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  kubak  <kuba@openoffice.com.pl>  [dc03e4fd524384963bafc529d0843d048e159106]

        tdf#96671 - Correctly detect windows 64-bit OS
        
        Adds detection:
        - Windows X86_64,
        - Windows X86_32
        - WoW64 (Windows 32 on Windows 64).
        
        Change-Id: Ic40ec8bdfb206a7ad3045edf7ecef3cb97cc08f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167144
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-11  László Németh  <nemeth@numbertext.org>  [016d61f529f9d9ec2520fb7a808da41cf17d7295]

        tdf#132599 sw: fix unit tests for hyphenation-keep with frames
        
        Fix en_US language of the test documents to be consistent with the
        hyphenator condition in the related unit tests of
        commit d4304cd0a4fedd0117fea3625dff1fca2945a0e6
        "tdf132599 sw: fix hyphenation-keep for linked frames, also for spreads".
        
        The problem was reported by René Engelhard.
        
        Change-Id: Iee7fd83aea294fb32c5f358cd25a1d1cb9a76d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167512
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [89d35be82851d820f36e31ac1866b1d58be0aa07]

        replace createFromAscii with OUString literals in CommandImageResolver
        
        Change-Id: I668062d2e6e220be16e3aa74b01db281d54876ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167511
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [0652885ffeddac94c47fe7c53a58c172a63f9d56]

        replace createFromAscii with OUString literals in ReadThroughComponent
        
        Change-Id: Ic92b15ea369e420faf6bfc40f509bba6e454710f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Noel Grandin  <noelgrandin@gmail.com>  [ed699baa9226f94d912cd2646ed8e2ce37bb1869]

        workaround clang segfault on macos-intel
        
        Change-Id: Icfced4a990e2d02995bff4078f14b8ee26e9cca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [57fce217fa6ee9d11b4899bbb2d11c05b76becb3]

        cid#1597279 Unchecked return value
        
        Change-Id: I603d8269f6831c07dc48b767545180120388831d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc3a8a025b816fd94e98070d84140c392f142f91]

        cid#1597280 Dereference null return value
        
        Change-Id: I0275c178a478b7143b0cf4ed19f030009b7bd2fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167504
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-11  Michael Meeks  <michael.meeks@collabora.com>  [fbfeb33b38cc0a644c0315448f6a2d8637a0007e]

        lok: Don't dump empty aria properties in every JSON element.
        
        They simply bloat the json to no benefit if the properties are
        empty, avoid serializing empty values.
        
        Change-Id: I83c780d01820ec39acc85899d45ad9e929ad7e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167496
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 24876e5611abbaec9b2fe5fcbcf4be71a10ee366)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167457
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-11  László Németh  <nemeth@numbertext.org>  [9668c9b8fe1d4afba335ab1f9d3309ad91bd56da]

        tdf#132599 sw: fix test of "fix hyphenation-keep for tables and no widow"
        
        Follow-up to commit a4970f4eeb94b8c405c5e3ec094d47061253efac
        "tdf#132599 sw: fix hyphenation-keep for tables and no widow".
        
        Change-Id: I94f2028fbc0f74b606fce2e921140ae9698955e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167507
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-11  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [75ff14d9cba2fca20d8ff958bdd9f6a931f88333]

        Update Hunspell URL in readmes
        
        Change-Id: Ic1a993029060a1260dffa126a930e29d4135fe61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167506
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b513772e558e2982d1dc4a56626b0e4303f5869]

        replace createFromAscii with OUString literals in SubComponentManager
        
        Change-Id: I165b93ff8986f288b03fb001e8ceda12b5076872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167502
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e8fd61044aa290e9c809fa4472f2406202dc881]

        replace createFromAscii with OUString literals in ResourceManager
        
        Change-Id: Iea6430d5f56a1f30a5dd168fcf2fee2ba7198f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167499
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [3908d2aa90df3f600fdf2acd9f570b895669feab]

        replace createFromAscii with OUString literals in DBContentLoader
        
        Change-Id: Iaa1169be4ab9db824af4406dd18e6c36326bdcd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [40b89a47890eb706939f4d75d11c6eceee300841]

        replace createFromAscii with OUString literals in OApplicationDetailView
        
        Change-Id: Icb7961ad247711e6a3b4761e7d6922ba7e4848a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167501
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [57374ccc5b08818f14479d403899209b6259fbaf]

        replace createFromAscii with OUString literals in ODsnTypeCollection
        
        Change-Id: I943e784bf3becd48e617b814b008f1f946987d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167498
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc91cc47505c448ded7297074ccff809b59e8ed1]

        loplugin:ostr in svx
        
        Change-Id: Ia765a03e033acb82e367873380d289587ea87d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167449
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Alain Romedenne  <alain.romedenne@libreoffice.org>  [28a43d53b25c183a7997cc18819d6ee0c675df19]

        Unit tests for officehelper.py
        
        Depend upon previous patch d8978a8c4ffabd6b36a691fd3e2df68563808234 for
        officehelper.py which fixed some glitches.
        
        Change-Id: Icc5c717d7f0f5a0a08202b6b57e475e7afe6f5c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164195
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>

2024-05-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [124252aa0be6ff13212f59f50352fb934e1c280c]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Iab647d1f98bb532bc0a2c42971e747708e52a875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167495
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0635101b42657ec1c12f961fccff9604f577efa]

        replace createFromAscii with OUString literals in ODatabaseModelImpl
        
        Change-Id: I861bf52bb49a54ec546a4465fb9053a5ebdaa641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167491
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1f3e9af6a71150da95b48dbcd81451806332812]

        replace createFromAscii with OUString literals in DocumentEvents
        
        Change-Id: I5cf5401afafc1c6d2d72445e898903c95288531b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167494
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [589d35da30e6640413f272d617337e9febb127fe]

        replace createFromAscii with OUString literals in ODatabaseDocument
        
        Change-Id: I57f1de3781ee413ad987222b8b960a266ef21e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167492
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9921b0b99aae17e15eb5daf56f0c3125f725a547]

        Drop now unused SdOptionsLayout, SdOptionsLayoutItem classes
        
        Change-Id: I5d4e77f8377eead4581f590a4cc160a3fa97e2a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166601
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8088bd350da2a38f7e582c6452d506a572a19cae]

        Fix typo
        
        Change-Id: Ia2aa4d36dcb056171bcf2aaac0f0f326db1deb3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167483
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-05-11  Pranam Lashkari  <lpranam@collabora.com>  [2b85bceca88ab119fff5cbdc41fe913435a479ca]

        sc: undo: unify height adjust logic in undo with regular logic
        
        in ScBlockUndo::AdjustHeight now we use device like ScViewFunc::SetWidthOrHeight
        This provides unified behavior with user adjusting height or triggered it by undo
        
        problem:
        in online sometimes undoing would cause wrong selection due to incorrect height set
        steps to reproduce(happened in certain files only):
        1. autofill down a couple of cells
        2. undo it
        3. try to select the same cell again
        
        cell selection will act like auto filled cells are merged cells
        
        Change-Id: I81b798c4150284792ac3953caf822fefab0ccee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167424
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 726b133fd8c823c7f05a30c1995de26db372174d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167454
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [14f65dc1ad3dc7bdc2e8638b5fb0130f8f22eaaa]

        replace createFromAscii with OUString literals in DocumentEventNotifier
        
        Change-Id: I6987033a461ec91b59de8e2aabef513471f887f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167493
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [16357c68bdb2fb9c1b7eb77fdbcb50c41948c6db]

        libmwaw: Upgrade to 0.3.22
        
        Change-Id: I95169f11e7b188ab9b4667b2d4736bd0d5a4a083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167477
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [ab7a94b8403e7fc89398a603a10e9002bd7e2077]

        tdf#160971 a11y: Send full text on changed combobox text
        
        When the text of an editable combobox is changed
        (e.g. using the up/down keys), the Orca screen
        reader on Linux announces the newly inserted text.
        
        This has been the case for other GTK or Qt
        applications for a while, and with recent Orca
        commit [1]
        
            commit 3a9e6b8d7b16bf2fc7919868cfd1a16e44422710
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri May 10 10:16:58 2024 +0200
        
                soffice: Use default logic for editable combobox value change
        
        , the same logic is used for LibreOffice as well.
        
        For the gtk3 VCL plugin which has a custom combobox
        implementation using native GTK widgets, this generally
        works since
        
            commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue May 7 10:04:16 2024 +0200
        
                tdf#160971 gtk3 a11y: Set role for custom editable combobox
        
        However, the qt6 VCL plugin uses the VCL combobox
        implementation, and only the actual difference between
        the text of the previous and current entry was sent
        in the TEXT_CHANGED event, resulting in Orca only
        announcing those letters that were added/changed,
        e.g. just "ans Narrow" when changing the font in the
        Writer formatting toolbar from "Liberation Serif"
        to "Liberation Sans Narrow".
        
        This doesn't really make clear what entry is selected.
        Align the a11y event with what GTK and Qt do
        and set the full old and new entry texts in the event.
        
        To do that, add a new virtual
        `VCLXAccessibleTextComponent:PreferFullTextInTextChangedEvent`
        that defaults to false to keep the previous behavior as default,
        and override it for `VCLXAccessibleEdit` to return true
        in the case that the edit is the subedit of a combobox
        (the parent has a combobox role).
        Use this in `VCLXAccessibleTextComponent::SetText` to
        determine whether to notify just of the changed characters
        or to send the whole old/new text.
        
        With this in place, Orca also announces the whole new
        entry text (e.g. "Liberation Sans Narrow" for the above
        example) when using the qt6 VCL plugin.
        (It currently additionally announces an extra "Selection
        deleted" when switching entries, as the text selection
        also changes, but that aspect is to be handled separate
        from this change here.)
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/commit/3a9e6b8d7b16bf2fc7919868cfd1a16e44422710
        
        Change-Id: I240aa0ad5ac9585e007d67a8c69e305cf1f38185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167479
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-10  Michael Meeks  <michael.meeks@collabora.com>  [b1c77f927aced5eeaebd5c17c30efdc1df74c4f9]

        lok: dumpState should truncate very long JSON messages.
        
        Otherwise we get huge dumps which can overwhelm our logging and hide
        more useful information, and/or the journal can drop them on the ground.
        
        Change-Id: Ie942c70a90a6df60ccd8986444362d622c213e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167456
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-10  Kurt Nordback  <kurt.nordback@protonmail.com>  [4425741937fbd240fe414a68a7d5e9ac4b40affd]

        tdf#161013 Rendering error when changing chart type for saved of-pie chart
        
        Reset pie sub-type property in XDiagram after passing it down,
        so that it does not persist and overwrite the modified sub-type
        
        Change-Id: If23ef2b1cff29efa5232d49381676592a0f39d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167487
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3563fca550f678a6797769cd3b5e529e95ca7e36]

        replace createFromAscii with OUString literals in SvxPathTabPage
        
        Change-Id: I831bc78f4934c7d1c137ad70c7bb189d75237e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [40dde4385cd913ac08292ad3be28bf17de9d296c]

        loplugin:ostr in vcl
        
        Change-Id: I5b6ee5bda0c5ff69d297f7f8e87d4c3f3d21791c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167470
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca5c9591ba38ad83415a2d4ced98bfc74d30b032]

        loplugin:ostr in sfx2
        
        Change-Id: I6306260d03c1208ec250c2f9a3860fa569f6d9c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167448
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e888503ee0aecbce8f3075b106243cf68b8dddc7]

        replace createFromAscii with OUString literals in OfaTreeOptionsDialog
        
        Change-Id: Ibe4de7e2ac6f0f00ba495ecbd18d97154283169c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7d4029e6f0551a9b425839cde03445c0967aac0]

        replace createFromAscii with OUString literals in SvxMacroAssignDlg
        
        Change-Id: I360d1dc46909f904ac9f984b2f06bb80f4a72c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [51a970b8b0c8f8d5e8d33cd50c88930be3a653d8]

        make sure KEEP_AWAKE_CMD gets only evaluated once
        
        if using deferred evaluation then the creation of targets via $(call
        gb_Top_GbuildModuleRules,foo) would result in it getting processed over
        900 times, and on windows spawning a shell with the two ps and awk
        command that takes 5 minutes.
        
        If future commands need to be run when the rule is run, then an
        alternative is to escape the variable in the define for the
        gb_Top_GbuildModuleRules macro via double-$ → $$(KEEP_AWAKE_CMD) - but I
        cannot think of any method where that should be necessary
        
        Change-Id: I126e4d317bd77f359ca9f39adf00cc88846af281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167351
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eb8f353f8b201dd2a1e24b03c7cc496b5ed32f22]

        help msvc -analyzer out wrt CPPUNIT_ASSERT
        
        so it can code following the CPPUNIT_ASSERT doesn't need
        to check what condition might have failed in the assert
        
        Change-Id: Ife7e5e54b17a8316425222d2a0efd694c9467089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167480
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [c24db71bc56c5d81a6e8fb744442b6d6358992d0]

        tdf#160971 a11y: Add null check in AccessibleListBox::getAccessibleRole
        
        Add a null check in `AccessibleListBox::getAccessibleRole`.
        
        Otherwise, LO Writer crashes on exit when using the qt6 VCL
        plugin with Orca running for this scenario:
        
        1) start Writer with the qt6 VCL plugin
        2) press F6 until focus is in the formatting toolbar
        3) use tab key to get to the editable comboboxes
        4) use up/down keys to change entries
        5) use Alt+Down to expand combobox
        6) switch between entries using up/down keys
        7) close Writer
        
        The reason is that the window gets unset when when
        `SvTreeListBox::dispose` emits the
        `VclEventId::ObjectDying` event, see
        `VCLXAccessibleComponent::ProcessWindowEvent`.
        
        But then, Qt's AT-SPI adaptor wants to query the accessible
        role when the `AccessibleEventId::CHILD` event is forwarded
        in our Qt a11y bridge, which previously resulted in a
        nullptr dereference with the below backtrace.
        
        Just return `AccessibleRole::LIST` for the null case.
        
        Backtrace:
        
            1  std::__uniq_ptr_impl<WindowImpl, std::default_delete<WindowImpl>>::_M_ptr                         unique_ptr.h                  199  0x7f0c1ee0b055
            2  std::unique_ptr<WindowImpl, std::default_delete<WindowImpl>>::get                                 unique_ptr.h                  470  0x7f0c1ee0b035
            3  std::unique_ptr<WindowImpl, std::default_delete<WindowImpl>>::operator bool                       unique_ptr.h                  487  0x7f0c1ee4abc5
            4  vcl::Window::GetStyle                                                                             window2.cxx                   989  0x7f0c1f0e594d
            5  accessibility::AccessibleListBox::getAccessibleRole                                               accessiblelistbox.cxx         347  0x7f0be055205a
            6  QtAccessibleWidget::role                                                                          QtAccessibleWidget.cxx        380  0x7f0c151cc242
            7  AtSpiAdaptor::pathForInterface                                                                    atspiadaptor.cpp              1771 0x7f0c13a8b112
            8  AtSpiAdaptor::notifyAboutDestruction                                                              atspiadaptor.cpp              1419 0x7f0c13a86e81
            9  AtSpiAdaptor::notify                                                                              atspiadaptor.cpp              988  0x7f0c13a8246b
            10 QSpiAccessibleBridge::notifyAccessibilityUpdate                                                   qspiaccessiblebridge.cpp      85   0x7f0c13ad9bf2
            11 QAccessible::updateAccessibility                                                                  qaccessible.cpp               940  0x7f0c13a603aa
            12 QtAccessibleEventListener::notifyEvent                                                            QtAccessibleEventListener.cxx 232  0x7f0c151c1363
            13 comphelper::AccessibleEventNotifier::addEvent                                                     accessibleeventnotifier.cxx   256  0x7f0c270ee1b7
            14 comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent                                     accessiblecomponenthelper.cxx 127  0x7f0c270e95b1
            15 VCLXAccessibleComponent::ProcessWindowEvent                                                       vclxaccessiblecomponent.cxx   229  0x7f0c20e80720
            16 VCLXAccessibleComponent::WindowEventListener                                                      vclxaccessiblecomponent.cxx   109  0x7f0c20e7fbbe
            17 VCLXAccessibleComponent::LinkStubWindowEventListener                                              vclxaccessiblecomponent.cxx   98   0x7f0c20e7f58d
            18 Link<VclWindowEvent&, void>::Call                                                                 link.hxx                      111  0x7f0c1efa2898
            19 vcl::Window::CallEventListeners                                                                   event.cxx                     262  0x7f0c1ef9f62e
            20 vcl::Window::dispose                                                                              window.cxx                    163  0x7f0c1f0f6513
            21 Control::dispose                                                                                  ctrl.cxx                      65   0x7f0c1f177a06
            22 SvTreeListBox::dispose                                                                            treelistbox.cxx               1340 0x7f0c1f464d1b
            23 SvTabListBox::dispose                                                                             svtabbx.cxx                   243  0x7f0c1f407a09
            24 VclReferenceBase::disposeOnce                                                                     vclreferencebase.cxx          38   0x7f0c1f3a957a
            25 VclPtr<vcl::Window>::disposeAndClear                                                              vclptr.hxx                    207  0x7f0c1eebfb19
            26 VclBuilder::disposeBuilder                                                                        builder.cxx                   814  0x7f0c1ee96f91
            27 VclBuilder::~VclBuilder                                                                           builder.cxx                   806  0x7f0c1ee96df9
            28 std::default_delete<VclBuilder>::operator()                                                       unique_ptr.h                  99   0x7f0c1ef6375b
            29 std::__uniq_ptr_impl<VclBuilder, std::default_delete<VclBuilder>>::reset                          unique_ptr.h                  211  0x7f0c1ef9da3c
            30 std::unique_ptr<VclBuilder, std::default_delete<VclBuilder>>::reset                               unique_ptr.h                  509  0x7f0c1ef9cfcd
            31 SalInstanceBuilder::~SalInstanceBuilder                                                           salvtables.cxx                7436 0x7f0c1f900b3e
            32 SalInstanceBuilder::~SalInstanceBuilder                                                           salvtables.cxx                7431 0x7f0c1f900ba9
            33 std::default_delete<weld::Builder>::operator()                                                    unique_ptr.h                  99   0x7f0c2490445f
            34 std::__uniq_ptr_impl<weld::Builder, std::default_delete<weld::Builder>>::reset                    unique_ptr.h                  211  0x7f0c2490438c
            35 std::unique_ptr<weld::Builder, std::default_delete<weld::Builder>>::reset                         unique_ptr.h                  509  0x7f0c24900e5d
            36 PanelLayout::~PanelLayout                                                                         PanelLayout.cxx               76   0x7f0c24f71c06
            37 SfxTemplatePanelControl::~SfxTemplatePanelControl                                                 templdlg.cxx                  163  0x7f0c24bd3d51
            38 SfxTemplatePanelControl::~SfxTemplatePanelControl                                                 templdlg.cxx                  160  0x7f0c24bd3d99
            39 std::default_delete<PanelLayout>::operator()                                                      unique_ptr.h                  99   0x7f0c24f1bedc
            40 std::__uniq_ptr_impl<PanelLayout, std::default_delete<PanelLayout>>::reset                        unique_ptr.h                  211  0x7f0c24f1bfdc
            41 std::unique_ptr<PanelLayout, std::default_delete<PanelLayout>>::reset                             unique_ptr.h                  509  0x7f0c24f1b06d
            42 sfx2::sidebar::SidebarPanelBase::disposing                                                        SidebarPanelBase.cxx          86   0x7f0c24f1a1df
            43 comphelper::WeakComponentImplHelperBase::dispose                                                  compbase.cxx                  26   0x7f0c2715c7a4
            44 comphelper::WeakComponentImplHelper<com::sun::star::ui::XContextChangeEventListener, com::sun::star::ui::XUIElement, com::sun::star::ui::XToolPanel, com::sun::star::ui::XSidebarPanel, com::sun::star::ui::XUpdateModel>::dispose compbase.hxx        75   0x7f0c24f1b235
            45 sfx2::sidebar::Panel::~Panel                                                                      Panel.cxx                     124  0x7f0c24f6fa51
            46 std::destroy_at<sfx2::sidebar::Panel>                                                             stl_construct.h               88   0x7f0c24f17315
            47 std::_Destroy<sfx2::sidebar::Panel>                                                               stl_construct.h               149  0x7f0c24f172f5
            48 std::allocator_traits<std::allocator<void>>::destroy<sfx2::sidebar::Panel>                        alloc_traits.h                675  0x7f0c24f170ff
            49 std::_Sp_counted_ptr_inplace<sfx2::sidebar::Panel, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose                                                       shared_ptr_base.h             613  0x7f0c24f170ff
            50 std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release                                     shared_ptr_base.h             346  0x7f0c2481f0ce
            51 std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count                                  shared_ptr_base.h             1071 0x7f0c2481f04a
            52 std::__shared_ptr<sfx2::sidebar::Panel, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr                shared_ptr_base.h             1524 0x7f0c24f15469
            53 std::__shared_ptr<sfx2::sidebar::Panel, (__gnu_cxx::_Lock_policy)2>::reset                        shared_ptr_base.h             1642 0x7f0c24f0cc84
            54 sfx2::sidebar::Deck::dispose                                                                      Deck.cxx                      93   0x7f0c24f5842b
            55 VclReferenceBase::disposeOnce                                                                     vclreferencebase.cxx          38   0x7f0c1f3a957a
            56 VclPtr<sfx2::sidebar::Deck>::disposeAndClear                                                      vclptr.hxx                    207  0x7f0c24f0bc96
            57 sfx2::sidebar::ResourceManager::disposeDecks                                                      ResourceManager.cxx           800  0x7f0c24f79791
            58 sfx2::sidebar::SidebarController::disposeDecks                                                    SidebarController.cxx         250  0x7f0c24efde01
            59 sfx2::sidebar::SidebarController::unregisterSidebarForFrame                                       SidebarController.cxx         212  0x7f0c24efd7e3
            60 sfx2::sidebar::SidebarController::frameAction                                                     SidebarController.cxx         1619 0x7f0c24f07542
            61 (anonymous namespace)::XFrameImpl::implts_sendFrameActionEvent                                    frame.cxx                     2960 0x7f0c25e25207
            62 (anonymous namespace)::XFrameImpl::setComponent                                                   frame.cxx                     1457 0x7f0c25e1d8b2
            63 (anonymous namespace)::XFrameImpl::close                                                          frame.cxx                     1706 0x7f0c25e20158
            64 framework::Desktop::impl_closeFrames                                                              desktop.cxx                   1699 0x7f0c25e03be4
            65 framework::Desktop::terminate                                                                     desktop.cxx                   205  0x7f0c25e0315b
            66 framework::CloseDispatcher::implts_terminateApplication                                           closedispatcher.cxx           552  0x7f0c25c33510
            67 framework::CloseDispatcher::impl_asyncCallback                                                    closedispatcher.cxx           406  0x7f0c25c326af
            68 framework::CloseDispatcher::LinkStubimpl_asyncCallback                                            closedispatcher.cxx           246  0x7f0c25c30b7d
            69 Link<LinkParamNone *, void>::Call                                                                 link.hxx                      111  0x7f0c1ee22718
            70 vcl::EventPoster::DoEvent_Impl                                                                    evntpost.cxx                  52   0x7f0c1f8a1485
            71 vcl::EventPoster::LinkStubDoEvent_Impl                                                            evntpost.cxx                  48   0x7f0c1f8a143d
            72 Link<void *, void>::Call                                                                          link.hxx                      111  0x7f0c1f12d138
            73 ImplHandleUserEvent                                                                               winproc.cxx                   2287 0x7f0c1f128e19
            74 ImplWindowFrameProc                                                                               winproc.cxx                   2851 0x7f0c1f1257d0
            75 SalFrame::CallCallback                                                                            salframe.hxx                  312  0x7f0c15240b90
            76 QtInstance::ProcessEvent                                                                          QtInstance.cxx                516  0x7f0c15263e3f
            77 SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const                               salusereventlist.cxx          119  0x7f0c1f8b585d
            78 SalUserEventList::DispatchUserEvents                                                              salusereventlist.cxx          120  0x7f0c1f8b5704
            79 QtInstance::ImplYield                                                                             QtInstance.cxx                442  0x7f0c15260541
            80 QtInstance::DoYield                                                                               QtInstance.cxx                464  0x7f0c15263945
            81 ImplYield                                                                                         svapp.cxx                     378  0x7f0c1f995c9c
            82 Application::Yield                                                                                svapp.cxx                     466  0x7f0c1f9955ab
            83 Application::Execute                                                                              svapp.cxx                     353  0x7f0c1f995342
            84 desktop::Desktop::Main                                                                            app.cxx                       1615 0x7f0c28b275a9
            85 ImplSVMain                                                                                        svmain.cxx                    229  0x7f0c1f9b84ae
            86 SVMain                                                                                            svmain.cxx                    261  0x7f0c1f9ba4f9
            87 soffice_main                                                                                      sofficemain.cxx               93   0x7f0c28bab36c
            88 sal_main                                                                                          main.c                        51   0x5644eb5ffa5d
            89 main                                                                                              main.c                        49   0x5644eb5ffa37
        
        Change-Id: I3fefaed31c6557620ecbe1627d265f2065fe9747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167475
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [34bfb9f506fa661a19498176f20bf3dfb7d8ff6c]

        chart2 a11y: Drop ChildListVectorType typedef
        
        Change-Id: Ie7ad5157bdcd261c8e5e6507b93b2820424c9125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167432
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-10  Michael Weghorn  <m.weghorn@posteo.de>  [2684a1be8dceb0864772b57ce89ab822d198da04]

        chart2 a11y: Use XAccessible ref, not XInterface
        
        Use the more specific type that
        `Window::GetAccessible` returns.
        
        Change-Id: Ied837b043997b4a51b280c71d0b35ca7eaa07385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167431
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [49a0203e7aa3a98bbed4412ab4364614505f88eb]

        librevenge: upgrade to 0.0.5
        
        * Add C2039-unique-shared_ptr.patch.0 to fix
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/librevenge/src/lib/RVNGBinaryData.cpp(96): error C2039: 'unique': is not a member of 'std::shared_ptr<librevenge::`anonymous-namespace'::DataImpl>'
        C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/librevenge/src/lib/RVNGBinaryData.cpp(86): note: see declaration of 'std::shared_ptr<librevenge::`anonymous-namespace'::DataImpl>'
        make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:398: C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/GenCxxObject/UnpackedTarball/librevenge/src/lib/RVNGBinaryData.o] Error 2
        
        on Windows
        
        Change-Id: I31023633426fc902e2298c696826d8371bb4d63b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167388
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-10  László Németh  <nemeth@numbertext.org>  [a4970f4eeb94b8c405c5e3ec094d47061253efac]

        tdf#132599 sw: fix hyphenation-keep for tables and no widow
        
        Now hyphenation-keep works without widow settings, too, e.g.
        in tables (where despite the existing widow settings,
        widow handling is always disabled).
        
        Follow-up to commit 6e8819f29b6051a0e551d77512830539913ec277
        "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type",
        commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b
        "tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'
        commit d4304cd0a4fedd0117fea3625dff1fca2945a0e6
        "tdf132599 sw: fix hyphenation-keep for linked frames, also for spreads".
        
        Change-Id: Id3db9631bb75d220e6fee7ebc9a5e7adad735273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167447
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [be7813b880def3aaea9ae00664067b9946235b59]

        ofz#68874 avoid Integer-overflow
        
        rather than detect it after the fact to keep ubsan happy
        
        Change-Id: I1336f7a23fa7170b754b818c1ec42ca85f5c27d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [edcfc1ba8ea4159c3c6f24b43f65ffe0b7b897a3]

        Use less SdOptionsZoom->GetScale/SetScale in favor of officecfg
        
        Change-Id: I34fca9ba9546f10268d22f92aaa5249d88f607d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166629
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [dd8cf8a3f061d77ed7781a8b591cee86067ab973]

        Use less SdOptionsLayout->Get/SetDefTab in favor of officecfg
        
        Change-Id: I028790b7e5750893f38ef7775cac1671104cd603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166600
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b27a39e26bdb1178c6d6a3f6880b9d40a1f9b1ab]

        tdf#156484: sw_ooxmlexport13: Add unittest
        
        Change-Id: I3bcda136eff62a61783b4e52132125c4b1794ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167446
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [79f4f724b9fed2fce6039049e60baaa19dc61a9e]

        loplugin:ostr in pyuno
        
        Change-Id: I54555110b5c66ea92f2675edc50dccd252558e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167435
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [166f81f38e78d85202c3880e4656759ff0d5fda1]

        loplugin:ostr in reportdesign
        
        Change-Id: I49d112d1a068ff265aa2242e62f53919f43fa15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [509ed148fc37731e021840f4cd8900d7a9a9b716]

        loplugin:ostr in sax
        
        Change-Id: Ia7572db738f1a3d6f7bec8c3a93ec02d93a531ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ce6b49c8a6c014f286deb98c353058483ae4bd95]

        cid#1597274 Identical code for different branches
        
        Change-Id: I9672db1e788265c806336f0bf077d0bb8144dc9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167433
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4c602fd2554952fa3d2d2144fed3a19bdbfe4481]

        cid#1597273 Unchecked return value
        
        Change-Id: Ia48abe54185c23f740b1385ca2bfd45950209f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167434
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-10  Oliver Specht  <oliver.specht@cib.de>  [f60126a6bfae5dad4a11afcc94ddf4a58c5ce8ab]

        tdf#159027: Fix calculation in tables with merged cells
        
        Calculation in tables with merged cells over multiple pages is fixed.
        It's more a workaround than a fix as it skips an empty SwRowFrame
        returned from SwTabFrame::GetFirstNonHeadlineRow()
        
        Change-Id: If11838da9769e0f6b0e54da8f422b4884684e30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166254
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [766d88bd73fb6b82082ccf77b1968cd863f9d211]

        loplugin:ostr in linguistic
        
        Change-Id: Iebc2db1c5750a8cea835722c396d6f708fe6e0be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167426
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noelgrandin@gmail.com>  [3c5d5d8ae3dfb876386e434257b5b3a81cb96c07]

        no need to convert from Sequence to std::set here
        
        we are never actually going to need a set, so just iterate over
        the Sequence
        
        Change-Id: I0de6ff9e0661227a69b7fbe6cccc5268f9eba58f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167430
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [baaeca870f5c8ae40d33eff2b530bd4b3670ee45]

        gbuild: don't create empty services.rdb on "make postprocess"
        
        Since commit db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3 "make
        postprocess.clea; make postprocess" will result in an empty
        services.rdb, because the components are added in makefiles in other
        modules.  Detect the problem and tell the user to run top-level make.
        
        Change-Id: Iab1a15efa5a4c9bb3e90e44f82a9510dff724c80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167354
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [9fb9bd54a82ee20f5916aa68e428e0fb67f02ed6]

        tdf#156484 svx,sw: fix visibility of shapes in header/footer
        
        Similar to commit ae132145ff42a95dc24fb124847c04af4b8c8dab, also forward
        IsVisible() and IsPrintable() from SdrVirtObj to its real object;
        evidently the properties aren't copied when creating SdrVirtObj but
        there is no reason for that to have these properties independent.
        
        This triggers an assert in VOCOfDrawVirtObj::createPrimitive2DSequence()
        because that is called during layout from getObjectRange(); the assert
        was added in commit ae3ec0d53a22ae5d2b7fb244a6056d0627b71873 and
        intended for painting, but this isn't painting, and it's not easily
        possible to detect if the function is called during painting, so remove
        the assert.
        
        Change-Id: Id2a04a5d07f43b86eb9c524b30ba74ecaf6a95c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167350
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [609d1e353cfd7a9b138fcbe656a2faae9f84c36a]

        sw: Navigator: don't show virtual drawing objects
        
        These can return a non-empty name now, so exclude them explicitly.
        
        (regression from commit ae132145ff42a95dc24fb124847c04af4b8c8dab)
        
        Change-Id: Ia7f7b9fd7abe67f3302e95b38e3b9fa30b769b5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167349
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-05-10  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [06c4dfc743a2314138835d4c4f39b98b96645d86]

        tdf#33603: do not block SID_SAVEDOC slots on NotesPanelViewShell
        
        Change-Id: Icc7320b0960f0d73027359b7525a37b44bdd7ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167365
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper@libreoffice.org>

2024-05-10  Sarper Akdemir  <sarper.akdemir@allotropia.de>  [423d240dc680817efae645d8305402f922bb452d]

        sd: properly read values of optional config items for SlideSorterBar
        
        Guessing this has regressed with
        9fc28d7ef5def30a23960cf15334af1aec27460f
        
        Read the values from std::optional<bool> properly.
        
        The default values are taken from the configuration
        officecfg/registry/data/org/openoffice/Office/Impress.xcu
        
        Change-Id: I93d5537a9e06dc6985a2ec375353d9869b92e08c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167353
        Reviewed-by: Sarper Akdemir <sarper@libreoffice.org>
        Tested-by: Jenkins

2024-05-10  László Németh  <nemeth@numbertext.org>  [d4304cd0a4fedd0117fea3625dff1fca2945a0e6]

        tdf132599 sw: fix hyphenation-keep for linked frames, also for spreads
        
        Linked text frames are hyphenated as columns on the same page,
        i.e. do not shift the hyphenated line, if hyphenation-keep-type="page"
        or "spread".
        
        For "spread", check also that the hyphenated line is on the previous
        left page, because checking only right page wasn't enough for linked
        text frames and blank left pages.
        
        Follow-up to commit 6e8819f29b6051a0e551d77512830539913ec277
        "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type" and
        commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b
        "tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'".
        
        Change-Id: I8965b42aa26c3c2571e07ad1b45dce6a9f61c633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167390
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e00f6e0b9df5ef8629738b551def2464d9a8e2ed]

        loplugin:ostr in lotuswordpro
        
        Change-Id: Ifea660ab9e0663312f9013670c27d3feda314d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167427
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [239ceb315521d9e88fb8290ba391c70a53095af4]

        loplugin:ostr in oox
        
        Change-Id: I08124ce2da1facbe2e84aa4a7a8e25fec24fa962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167428
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [58a9c936bb065384d50e122ee2ac9037dd60cc32]

        Use less SdOptionsLayout->IsHelplines/SetHelplines in favor of officecfg
        
        Change-Id: Ic6d0c80a4f95a08d969b8400704f25fc50147ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166599
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-05-10  Méven Car  <meven.car@collabora.com>  [6f993ff3c16fe3a826cfb2d9c82f45a401d77666]

        sd: prevent some work outside of LibreOfficeKit
        
        fbd8cfb046fd0882402e01c2e0b2955e6972737f added a stateChange event for Is/GetStartWithPresentation.
        This is needed only in case we are in LibreOfficeKit context.
        
        Change-Id: I9d853c4d50fd07c45c40fb20c27bd26ab30c1680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167362
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-10  Miklos Vajna  <vmiklos@collabora.com>  [ab3416cad1dd4e706432f9b1a3592cec823c76b0]

        tdf#160984 sw continuous endnotes: fix testContinuousEndnotesMoveBackwards
        
        Once continuous endnotes are in a section, this failed, even if the
        generated layout is an improvement.
        
        The layout will put the endnotes to a section, which will be directly
        after the end of the body text, which is closer to what Word does, but
        makes the test fail, since the foot/endnote container is no longer
        directly under the page frame (the new tree is page -> body -> section
        -> column -> ftncont).
        
        Fix the problem by relaxing the assert to only check which pages have
        footnote containers, which passes with and without the move to
        section-based continuous endnotes, but still fails if endnotes go to
        their own page, which was the original problem to be tested (endnotes
        remained on page 3 and didn't move backwards).
        
        The assert for the number of pages can remain unchanged.
        
        Change-Id: I9a46803463c82dac317c303721de30fae48c6924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167425
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-10  Gökay Şatır  <gokaysatir@collabora.com>  [8ab95722bc2e64a8cc1fd6b5aa36ecc599a8e1b6]

        Fix row deletion bug.
        
        When multiple users are editing a Calc document:
        * If one user selects a whole row and another one deletes a range of rows including or above the selected row, app crashes.
        * This PR fixes the crash.
        * Also when multiple rows are deleted, other user's selected row is moved only one row. This PR moves the selected row according to the deleted row count.
        * The cursor position was also causing a crash, fixed.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ie4b893fee7192492efacbb167b747434336384e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158650
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167374
        Tested-by: Jenkins

2024-05-10  Gökay Şatır  <gokaysatir@collabora.com>  [61ada4483c50d78387ff0ac45a97f2ee5b328029]

        Fix column deletion bug.
        
        When multiple users are editing a Calc document:
        * If one user selects a whole column and another one deletes a range of columns including or on the left of the selected column, app crashes.
        * This PR fixes the crash.
        * Also when multiple columns are deleted, other user's selected column is moved only one column to the left. This PR moves the selected column to the left according to the deleted column count.
        * The cursor position was also causing a crash, fixed.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ib00488f387a91aa0109bcc30feacad52e1b14a30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158503
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167220
        Tested-by: Jenkins

2024-05-10  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [69980bb2f951f780e63718215ca522a69676febf]

        odk/README.md: easy way to build examples on Linux and macOS
        
        Change-Id: Ib511e81830a3e4b83f391d3f2d771dc657ee12b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167333
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-10  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3d1a96d85d1a0e54e37cc8cd83c6216709360729]

        odk/examples: grammar and comment fixes
        
        Change-Id: I86174573d9f59135865496a4f3ee5efb86141ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167410
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-05-09  Noel Grandin  <noelgrandin@gmail.com>  [0ffdfb58a07e2a1b89a36bc241c6a2767e82cd2c]

        workaround segfault in compiler on macos-clang-intel
        
        Change-Id: I291599cd35d3f8be44949a57514bab5ac9f1a7e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Jonathan Clark  <jonathan@libreoffice.org>  [44699b3de37f07090ac6fee1cd97aa76036e9700]

        tdf#49885 BreakIterator rule upgrades
        
        This change re-bases the BreakIterator rule customizations on top of a
        clean copy of the ICU 74.2 rules.
        
        Change-Id: Iadcf16cab138cc6c869fac61ad64e996e65b5ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166273
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3956472eb249e54d5b96af59b33646ee3ceec897]

        Fix missing UNO<->C++ argument/return value conversions
        
        Change-Id: I5ac6013d6c0bd72fe840a592628fd0d5b265b8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167391
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-09  Noel Grandin  <noelgrandin@gmail.com>  [27e398b88066a4d1e236ce8b298f466754c41de0]

        workaround segfault in compiler on macos-clang-intel
        
        Change-Id: Ic4ee6c80eb340c1a6db50b9176fcbffcb6419483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Noel Grandin  <noelgrandin@gmail.com>  [03f13aa770c71795a1e69cf7f77c51aa6bf9ac0a]

        workaround segfault in compiler on macos-clang-intel
        
        Change-Id: I4327849c2c58c1656b82ea43fdc218dd7b9578c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167392
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-09  Justin Luth  <justin.luth@collabora.com>  [0f9abf6a5f95dd48cb74cc6bbbadf319aab140fe]

        document why GatherFields messes up sorted order
        
        Of course, UNO gets a list of fields through some esoteric
        broadcast system. This answers the big question in qa swfields
        about why the sorting order is stable, but wrong.
        
        An earlier version of the patchset has the code
        that would keep the sorted order for at least comments.
        But it isn't as efficient, and who knows what the implications
        would be, so I have no intention of making such a generic change.
        
        Change-Id: I178fdba7def8522ab5d94bdd61526af77f42c903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166767
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c6f39e2deedd93ccf52ca5bb4402cabc3e8bdda7]

        Embind: Fix uno_Any.get for null interface values
        
        ...which had caused an additional getNull/isNull check for
        a469aea9c0b532d928cd41e389c9c51de1af06f0 "Emscripten: Towards a working C++ UNO
        bridge" to fail
        
        Change-Id: Ibe87ca05f795253c9ede8cab6f96da8fe4496f87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167344
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [227078bc8d1e37d80eab2d50478ec5fc6345a616]

        loplugin:ostr in javaunohelper
        
        Change-Id: I641f2d107e3a8aaabdd2f8ede10e7e6b13078602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167384
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [38c980d472b5d311de60ee7cfcce880f66a55df8]

        loplugin:ostr in lingucomponent
        
        Change-Id: I1910fd2a7cba63404c37b7bb80b77de2443dd7a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167386
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [927e66058a0a29dcb327c6751984e19373a476c2]

        loplugin:ostr in jvmfwk
        
        Change-Id: Ie21df5b25d15a15ba7a1660970ff7064bb8ec1d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167385
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cc3d3a4433f538394c4c65b1a80a9ea7e4d7ce6]

        Revert "tdf#160706 speed up loading conditional formatting rule in XLS (3)"
        
        This reverts commit e1268721d4266ed1254da99581a7c2c3dfb72ba6.
        
        caolanm:
        
        With the old "bForceName" of true then previously if the style name existed it was renamed to something else and then a fresh style with the requested name created. While now we just reuse it.
        
        I'm not very clued in to what calc does, but in writer we might do something like this if we are inserting into an existing document and don't want to clobber existing styles. Except here we sort of did clobber existing styles by renaming them. So I'm unsure of what on earth the original idea was.
        
        So I wonder about a "insert into existing calc document" scenario?
        
        noelg:
        
        Caolan, I was operating under the assumption that this comment here is the desired behaviour.
        But now that I read it again, I am not so sure.
        This commit should probably be backed out.
        
        Change-Id: If503efa9fa1a7886eb57bb62d1327f81e4410981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167318
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-09  Hubert Figuière  <hub@collabora.com>  [fd0a249ad1f4a55677e97bd6355e5316a863f9e6]

        lokit: Properly handle state update for .uno:ToggleSheetGrid
        
        This is a follow up on cool#8066
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I7d6ce4c9dfe7c2e9a2dda110e587c8c825c4df2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167370
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 9bbe40cc2d39f89ffcae57875d4c7ef7688d83d7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e1b8d1595ded1ad4da27339060b55283024c2698]

        svx: a11y check entry box - provide accessible name and description
        
        If the accessible name and description is not set in the .ui file,
        the code will look into help for accessible description, which will
        always return an empty string as the widgets are added dynamically.
        Searching in help takes some time (2ms), which can add up and is
        "felt" in accessibility check sidebar in online when the documents
        has a lot of accessibility issues (it can add up to seconds). To
        avoid this cost and for better accessibility info, it is better
        to provide some general description for this widgets.
        
        Change-Id: I91c5a091781532068c517be937d225fc9345dc5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167346
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 31b3d5a1062366a7ab0cf0fa42359b90d1ed3c4b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167316
        Tested-by: Jenkins

2024-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [65e09958920057b3a15d38dcb2e26e752f42179c]

        lok: don't try to search for legacy label from/to
        
        Searching for legacy label from/to can take quite some time in
        complex hierarchies (wallclock timed to 100ms) and this quickly
        can add up. In case of accessibility checker sidebar with many
        entries it could add up to 10s or more (depending on the amount of
        accessibility issues found in the document).
        
        The legacy label from/to is not used when we load from .ui file so
        it is not relevant for online currently. It is only relevant for ui
        found in extensions or starbasic ui.
        
        Also avoid making a copy of the vector of mnemonic label for no
        particular reason.
        
        Change-Id: I72002e6440a06f6e8548b7bddb46c3ab283ea283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167347
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 1353ae001ed83c1f20b81df1708f694427c587a4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167315
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd3d2daa20f17079c087636b4362fc8527a392bd]

        loplugin:mergeclasses update
        
        (*) remove some debugging code
        (*) loosen constraints a little so I can see if there are more
        interesting opportunities
        (*) rename some local vars to make it read better
        (*) strip const/& modifiers from types before comparing
        (*) ignore vars/fields that are references, they do indicate that a
        class was instantiated
        
        Change-Id: I66014b8f0aa24c2e3ca34af75b75e6cd6c939ea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167383
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e49fd672b17ba382d78a130648e714fa130d39c5]

        Fix typelib_TypeDescriptionReference -> typelib_TypeDescription conversion
        
        Change-Id: Idfe74f1523ec866ed9926d3385a1605ad8a5547e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167352
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [11c66ea0f49417a30aae1ff250f7f18ec797753e]

        loplugin:ostr in hwpfilter
        
        Change-Id: If99a50251332e89e09ad97bb74178c4651cde44e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [36703975a046d9271a919b9fa52be13204742b67]

        loplugin:ostr in io
        
        Change-Id: I68bb665798edf464020c8c3a6f7d9c9f5e85869e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167379
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [43f4c075740671450766f632f2ddab5dc3563d3d]

        loplugin:ostr in i18npool
        
        Change-Id: I0176d93b38788e28fa42baad293597f98eaa7a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [0479f870e05d5d231d2d57aaeedff11544bd370c]

        tdf#154581 tdf#157411 tdf#158549: sw_htmlimport: Add unittest
        
        Change-Id: I0bf120b4761447a0acc9286e7181f7cf7c40c65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167380
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [654150ffd05f43813332eedb969ab07fffa51b21]

        tdf#58038 - chart: make available format characters toolbar for
        
        text boxes or shapes *inside* charts (as created with the Drawing toolbar).
        
        follow-up commit: 4f994cec388377cc5c2bddb804bd92eb4cd7dc8d
        (tdf#39052 - Chart: make characters formatable in editable chart textshapes)
        
        Change-Id: Iccc5ee350ea0a37d8bda9652e09d3d61339f1d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167366
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-09  Miklos Vajna  <vmiklos@collabora.com>  [8bae684c93bd23bbe98707ba9cf75d1a39427131]

        tdf#160984 sw continuous endnotes: add a way to find the endnote section start
        
        Existing code with endnotes on separate page at the end of the document
        works by searching for a current or next page that is an endnote page in
        SwFootnoteBossFrame::AppendFootnote(), and in case none is found, then
        an endnote page is created.
        
        Add similar infrastructure for the inline endnotes case: here we want to
        find the first page that has an endnotes section, which also requires
        being able to tell if a section is an endnotes one.
        
        The newly introduced SwPageFrame::GetEndNoteSection() is not yet used in
        SwFootnoteBossFrame::AppendFootnote(), though.
        
        Change-Id: Ib08267f9bf6c7b06576624e3fa8e90e8b8b1b232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167371
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-09  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [da0e9240bf6505ac3a67ff985705950566c66144]

        tdf#158447 Use PyConfig for setting Python home directory with Python >= 3.8
        
        Change-Id: Ic5b7c60613b22f5215cb1a2a13fecf3e0946ca49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161089
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [880e093555386e866ef85949ab42cc8f9422994f]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I6ef2f39cca9e657a05b9b55d8ff87607261dd1ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167369
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b009ffb1620bb7a51f027c0f7fbc3ea9297cef69]

        update crcs for --enable-cairo-rgba case
        
        Change-Id: If0588a018564a708361b0246b294520ac5d2d1db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d884c4be18a82f61fe6db6f22cb1bf1092afd48a]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I37166c03ffd0f8f76ddc03ce556b6e6341a02b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167355
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-09  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ad1f0bdeac30fca1dc56a08803ef23f2aca4db05]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 761a64f3ca3e8f66c711bcadaa8c5ced105a99cd
          - fix row/column type of labels in description of their recognizing
            
            Change-Id: I4b9dcd95b432aea717eeb017fc94fa02a3bc84d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167247
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5ce5ffe817479faecf7889d0024e91c8a2ad6a2c]

        Use less SdOptionsLayout->IsHandlesBezier in favor of officecfg
        
        Change-Id: Id2f005413f255b4a0f0e0cd240cb8700c27ee204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166598
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-05-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [055e7d866680390dca6e18864ca4297cc0ebda84]

        Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfg
        
        Change-Id: I12c9f69e0db1bf3e726b7d642e9a6855b031d3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166597
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9427b9f0c291bd24e5e5e53e3f415c724dad746]

        loplugin:ostr in fpicker
        
        Change-Id: I891d31ae35419fb26d7070c8a9e3437b86e124d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167338
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [24d78fcb5399b2c783ab7908263a1b54bb687a22]

        tdf#160906 use SfxPoolItemHolder
        
        to avoid handling already deleted SfxPoolItems.
        
        Change-Id: I1f1f8f93cae8db7f7c8df66c2c7f3c02b59a39c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167274
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-05-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d68f2394afc3372d867ea6157123e51b278ba81b]

        tdf#126573 Add Excel2021 array function RANDARRAY to Calc
        
        Add new function called RANDARRAY to the function list.
        
        (TODO: dynamic array in separate patch, oasis proposal)
        
        Change-Id: I34bad3b7e8d631d649a0350d7c1170b26161331d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167003
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f5f24a4a3dac22e0f2c0d4832e0cbdd566263b9]

        loplugin:ostr in framework
        
        Change-Id: I2fdc32aa5de6a1315fe69997f9b531259aa78605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-08  Justin Luth  <jluth@mail.com>  [22dd422f7ccf7a1ce4dc7fe5b274263a55e464c7]

        Revert "tdf#150037 Writer: text fieldmark behaviour changed"
        
        This reverts 24.8 commit 96323a10d3a55d212c350886e2a1344c0cd2ba95.
            A mouse click selects the fieldmark to be able to overwrite
            the field with the next text input.
        But I did not revert:
            Additionally the EN SPACE (0x2002) character is visualized
            by the DEGREE symbol when 'View/Formatting Marks' is active.
        
        The problem was that the field itself was also selected,
        so not only was the placeholder text overwritten,
        but so was the entire field.
        
        Additionally, it is ONLY placeholder text that should be selected,
        but this was also selecting non-placeholder
        (i.e. custom user-entered text) that was being pre-selected
        which is NOT what happens in MS Word.
        
        The whole point of the patch in the first place was to
        emulate MS Word's response to placeholder text,
        so we should also be emulating what happens
        to non-placeholder text. That would require tracking
        whether the field's text was placeholder or not,
        which is not currently track in legacy fields.
        
        Change-Id: I0a1a22f82827cd5f9d9abfb52cd562dff4651b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167139
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a551290fc46d5f91b89615700c88b863a403bc7a]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ia64d863baa72a2d32a8bee40968af4f6aacd88bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167332
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4fc4e24fb0ac549b7684aac8e020253c0cc76603]

        Move call code out into a function of its own
        
        ...so that it can be reused in the future for attribute getters/setters
        
        Change-Id: I3dde796eb0c2f3812b7aee1a2c000bad31b33158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167345
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [5e1aaaf07d70cb8eda1c7f14a458680d9323ff74]

        gtk3 a11y: Drop superfluous check
        
        If `nStateSet` is 0, no states will be set int the
        loop anyway, so the extra check is not needed.
        
        Change-Id: Id26f2210c51cb6bf952720f9a84696a327992df6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167330
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [addb7abeb8ec1a145d9ba35d3be8518f2502325b]

        gtk3 a11y: No longer manually add focused state for focus object
        
        No longer manually add `ATK_STATE_FOCUSED` to the
        ATK focus object.
        
        The focused object should should have the
        `css::accessbibility::AccessibleStateType::FOCUSED`
        state set on UNO level, in which case this is already
        mapped to the focused state in the lines above the
        newly removed code, so explicitly addding it
        again shouldn't be necessary.
        
        If the state is missing, that most likely needs
        to be fixed in the underlying `XAccessibleStateSet`
        implementation.
        
        Therefore, remove what looks like a workaround.
        If any issues show up after this, let's rather take
        a look at the underlying issues and try to fix things
        there.
        
        Change-Id: Ie7252c4b2dd2ec15c7a3bbc6a1a5e2830cdd39a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167309
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a469aea9c0b532d928cd41e389c9c51de1af06f0]

        Emscripten: Towards a working C++ UNO bridge
        
        ...by making the general UNO -> C++ function call case work (modulo handling
        exceptions, which I'll look into later).
        
        Wasm call_indirect unfortunately needs to statically know the call target's
        signature, so we statically need to know all possible signatures.  So introduce
        wasmcallgen helper to scan the existing UNOIDL API upfront and generate the
        relevant callvirtualfunction-wrapper.cxx and callvirtualfunction-inst.s code.
        (The good thing is that the number of different signatures is somewhat limited,
        each parameter can only be one of i32, i64, f32, or f64.  So even if 3rd-party
        extensions bring along new UNOIDL interface methods, chances are relatively high
        that the signatures needed for them would already be covered by the existing
        ones.)
        
        Testing this can nicely be done in unotest/source/embindtest/embindtest.js via
        css.script.Invocation (which internally exercises the relevant code).  (Instead
        of adding individual org.libreoffice.embindtest.StructLong/String etc., it would
        be nicer to introduce some polymorphic StructOne<T>, but the Emind UNO binding
        does not support polymorphic structs, so the embindtest.js code would not work.)
        
        Change-Id: If829c9e3772bfd27561f3ad743d38a71d11545b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167308
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-08  Miklos Vajna  <vmiklos@collabora.com>  [90f19126fa405a0632eae4ee8525b66bbce12625]

        tdf#160984 sw continuous endnotes: introduce an endnote section
        
        Word lays out endnotes at the end of the document inline after body
        text, Writer puts them on one or more separate endnote pages.
        
        There was already an attempt in the past to resolve this difference, see
        commit 4814e8caa5f06c4fe438dfd7d7315e4a2410ea18 (tdf#124601 sw: add
        ContinuousEndnotes layout compat option, 2019-09-30). The approach back
        then was to map such endnotes to footnotes, so the extra, unwanted page
        doesn't appear. This turned out to be not working too well, the compat
        option is only enabled for DOC, and even there commit
        dc11f5b151e1a2ea2623fc8cf806a400763955d9 (tdf#143445 DOC import: limit
        the usage of the CONTINUOUS_ENDNOTES compat flag, 2023-05-23) limited
        the usage of the compat flag to 1 or 2 endnotes only.
        
        Coming back to this, try a new approach: create a section that more or
        less exists only at a layout level and put endnotes into that section.
        This allows reusing all the complex logic on how to lay out endnotes
        inline, on one or more pages. The plan is that this new approach is more
        robust, can replace the old continuous endnotes layout code and then can
        be enabled for DOCX as well.
        
        This commit just introduces the backing section format and SwSection for
        that special "endnotes section" (it's special because SwSection is
        usually owned by an SwSectionNode, but here there is no doc model node
        for the SwSection), SwFootnoteBossFrame::AppendFootnote() doesn't try to
        use the new SwEndNoteInfo::GetSwSection() yet.
        
        Change-Id: Ib32f04ceb6f46c682a5d36bdcea206d2c4017227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167305
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b97bfa88ffebf31778f0f68e883e046822cd264]

        return early on empty ORelationTableConnectionData*
        
        we test for pData existing, but it it doesn't then we continue and
        will typically dereference it, so test looks inverted
        
        Change-Id: Iddcab25d5620942bb617bd1e9985322f5e497839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167331
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5aa87aeeb66a8f8068b41275d23c491f2dbd0f2]

        drop requirement for rtl_random_getBytes to have "Pool" arg
        
        Seeing as since:
        
        commit e9531b792ddf0cfc2db11713b574c5fc7ae09e2c
        Date:   Tue Feb 6 14:39:47 2024 +0100
        
            sal: rtlRandomPool: require OS random device, abort if not present
        
            Both rtl_random_createPool() and rtl_random_getBytes() first try to get
            random data from the OS, via /dev/urandom or rand_s() (documented to
            call RtlGenRandom(), see [1]).
        
        we don't use the initial arg to rtl_random_getBytes anymore, drop the
        requirement to have one. Then simplify our usages of that, and
        addtionally deprecate rtl_random_createPool and rtl_random_destroyPool.
        
        Change-Id: I13dcc067714a8a741a4e8f2bfcf2006373f832c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1eaae3966db362b5094feee4ac9a462ee9993d90]

        loplugin:ostr in forms
        
        Change-Id: Ifee5d86b54aa746dbd3b17ff966794f32fbc23bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [12215925202d6d540e4a22b93a8f49b4ec35c111]

        loplugin:ostr in formula
        
        Change-Id: Iac66906636e64c0547122ac413bee494631c7c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167304
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1d980bef0d0aaf6cfe87ddbebefd5c771c4f26e]

        loplugin:ostr in filter
        
        Change-Id: I9468cb2bf7b3614e5ee2e1ca6969282041699371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167302
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e22e7ca9488b160df4f00481b10993262a4db5d3]

        flush CallbackFlushHandler queue via PostUserEvent instead of Idle+Timer
        
        Looking at when Invoke was called from Idle (or from auxiliary Timeout
        if there was no chance to run the Idle within 100ms) and when duplicate
        merging and modification of the queue is done before getting dispatched
        and cleared; Then the pattern is that duplicates are collected and
        merged during the current block of events to be processed, and
        dispatching the flush via PostUserEvent instead gives the same results.
        
        During startup, scheduling via PostUserEvent drops the need to have the
        aux timeout, and while the number of messages seen in the first queue
        flush (now via PostUserEvent instead of 100ms Timer) remain the same as
        before, subsequent queue flushes can get processed earlier while
        smaller, though typically at the same time as before once the document
        is fully loaded.
        
        Change-Id: I64c6bbc3dea9fb3a512c2a9521303a8f143d4a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167064
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-08  Oliver Specht  <oliver.specht@cib.de>  [04dd541becd9232555e4d6d1e41462359f253993]

        Design change in variable page of the field dialog in Writer
        
        Improves the commit 8e86df886f84fe69f13cfc367a5dd843e6ea917c
        
        Change-Id: I69bc7a8ddcc9593e1e0deb26311c31032f3f9ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167285
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-08  Oliver Specht  <oliver.specht@cib.de>  [de8eaca887762568e158024ad5bdbfb21526b734]

        Case Rotation in Impress and Writer improved
        
        Word boundaries at the end of the paragraph are now correctly detected.
        Sentence case is not applied without multi word selection in Writer anymore.
        
        Change-Id: If6e2eeaa1ecca215d583e8f33364db466bf7c57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166928
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-08  Justin Luth  <justin.luth@collabora.com>  [90eb9ea881a7497bb2ec348b3e4cba5aa5d51fa8]

        tdf#69192: add StartingSlide to SID_PRESENTATION and cmdline show=
        
        Allow the user to start the presentation at a specific slide
        using command-line parameters.
        
        This patch depends on the previous variable renaming patch.
        
        Change-Id: I87797cbccb463904e5d2fe9b078e3921be27c91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167066
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-08  Justin Luth  <justin.luth@collabora.com>  [ddc4cd3d0cf9e8bde440df3e92e98a2a2017c797]

        NFC dispatchwatcher.hxx: rename aPrinterName to aParam
        
        It is rather confusing to have a generic parameter variable
        named aPrinterName.
        
        I'm going to use that in my patch, so first clean it up separately.
        
        Change-Id: I3e73eeddbc506d369ba5d6e2b569d30eef78bfb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167059
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-08  Miklos Vajna  <vmiklos@collabora.com>  [af3d52e444595a4a3b50528c0f02fa798e7a2b08]

        CppunitTest_sw_rtfexport6: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I36e31fdacabdda2b9fd3b3aab49df37a34e7ab44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167301
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ddf32ef202b48081fca020c06b5be3a6faf0a467]

        loplugin:ostr in embeddedobj
        
        Change-Id: I644042d0ca6041174a8e11f780c546bcf7d4571a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167282
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c67e94cf7a4349f365e1669d99e598dfd9c665c]

        loplugin:ostr in drawinglayer
        
        Change-Id: I80d424ca042371f4d2e0a1d6be68683c7bad1784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167271
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-08  Patrick Luby  <guibmacdev@gmail.com>  [92815f3a464b447898ecf52492247335228e4a72]

        tdf#160767 skip fix for tdf#155266 when the event hasn't changed
        
        When scrolling in Writer with automatic spellchecking enabled,
        the current event never changes because the fix for tdf#155266
        causes Writer to get stuck in a loop. So, if the current event
        has not changed since the last pass through this code, skip
        the fix for tdf#155266.
        
        Change-Id: I97265a7698756c5fb65b6686f6bb77c1caa08862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167298
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-05-07  Noel Grandin  <noelgrandin@gmail.com>  [b1432ad59d6210da49e8c5c113ef2585d2203ca9]

        workaround compiler crash on macos-intel
        
        Change-Id: I779785c068fd04e314b4d6c22d9fe66d9aa88736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167294
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dfec385f3c80848abd5ead6f1ae682fcefc06b16]

        Add gb_Library_add_generated_asmobjects
        
        ...to be used by a follow up commit in EMSCRIPTEN's bridges/Library_cpp_uno.mk
        
        Change-Id: Iaebc18d40241d9b7918061100b25cca8a8bc4e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [06a2805d88244adb7276327bc4539fd9bf651539]

        cool#7015 fix rgba emojis
        
        We initially added this for android so we could match the OpenGL GL_RGBA
        layout available there. Later we made it available for all platforms via
        --enable-cairo-rgba which is useful for the kit case.
        
        But along the line color emoji support was added to cairo which wasn't
        present at the time of the original patch, so now capture those uses
        as well.
        
        https: //github.com/CollaboraOnline/online/issues/7015
        Change-Id: I6039607a46a58a7e9cbf5c052e6fb34234fd19b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167225
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b517dfae3558127be332029daf969c548b6b0e5]

        Revert "make skia into static library"
        
        This reverts commit 6517ce70e50e61441484e7ee7a4be0e265020175.
        
        Reason for revert: 
        
        <_rene__> noelgrandin: ping?
        <_rene__> noelgrandin: /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/LinkTarget/StaticLibrary/libskia.a: error adding symbols: archive has no index; run ranlib to add one
        <_rene__> noelgrandin: caused by your skia static library change. I think I pointed that out once already...
        <_rene__> $ ld -v
        <_rene__> GNU ld (GNU Binutils for Debian) 2.42
        <noelgrandin> hmm, it's not an ld version issue, because I have ld 2.41
        <_rene__> gcc version 13.2.0 (Debian 13.2.0-24) 
        <_rene__> and
        <_rene__> Debian clang version 16.0.6 (27)
        <_rene__> fwiw, too
        <noelgrandin> is that a mergelibs build, or a regular build?
        <_rene__> mergelibs
        <_rene__> (the "normal" one, not =more)
        <_rene__> noelgrandin: ... and LTO
        <_rene__> noelgrandin: (saying because googling gives me https://github.com/mesonbuild/meson/issues/8371. and yes, .a is built with clang and the rest with gcc "of course")
        <_rene__> noelgrandin: but the Linux release builds _do_ that:
        <_rene__> $ grep -E "(lto|merge)" distro-configs/LibreOfficeLinux.conf 
        <_rene__> --enable-mergelibs
        <_rene__> --enable-lto
        <_rene__> $
        <loircbot> LibreOffice (core) [libreoffice-7-6-7] lohmaier+LibreOffice · readlicense_oo/license/CREDITS.fodt · update credits
        <noelgrandin> oh yeah, good spotting
        <noelgrandin> yes, LTO is going to be a problem because skia is built with clang
        
        Change-Id: I96c63109d2856c6e4cb22cf9ac945d4cfa9848c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167227
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins

2024-05-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6b62ff0eaf499eb8c2ed4af3413757f38bc97dcb]

        update credits
        
        Change-Id: Ibdf64d7605c81e9006c1637a85a4a539993dffa6

2024-05-07  Oliver Specht  <oliver.specht@cib.de>  [5e5e5832df6ed11bc664ef33ae833d2501b516c4]

        Sidebar: Direct update of FillStyle
        
        FillStyle is directly updated to prevent deferred resize
        when additional controls are created.
        
        Change-Id: I48ed987971cf6c711af31d552e8d64fa9982a416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165993
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [f49d8ce4614bb12a6c9f0c6e83812aa69b9b2454]

        loplugin:ostr in extensions
        
        Change-Id: I32f74fe67e8eb0b6b12ee60405c3d99932b75182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [c920881f399a2f679c2ed45f86b93468aa62a5d3]

        loplugin:ostr in emfio
        
        Change-Id: I3ec70a070fec1e62992eead0405ef689debb9fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c7c6ba98fba651c8ae4015dbbf450c23611667a]

        libatomic_ops: Upgrade to 7.8.2
        
        Change-Id: I7fcf8011cbb1fb5e5ba2f0a9737190bffa13114d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167287
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-07  Jim Raykowski  <raykowj@gmail.com>  [9ccdb4c63445ad9ca7bdba869e1bb967b7f622c8]

        tdf#160598 follow up to make delete key work
        
        Adds delete key handling for delete all footnotes/endnotes from the
        Navigator.
        
        Change-Id: Ic1d49377631344ac5e6fdc81c07eebde0470a6be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167180
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-05-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [83d3f9b819ee23efa314953fc2fde4412d90a60b]

        use windows doxygen in wsl-as-helper case
        
        basically reverts f7fe6a0bed2c2aee19535a26181a2edfb103e587
        
        avoiding the penalty for accessing files in the windows-realm from
        within the wsl-container significantly accelerates the doc-generation
        
        Change-Id: I95af905bda7225a9c1924a41e952656dffbfbc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167279
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-07  Méven Car  <meven.car@collabora.com>  [fbd8cfb046fd0882402e01c2e0b2955e6972737f]

        Impress: transmit document's property StartWithPresentation
        
        This is transmitted as stateChanged event.
        
        This property is set for ppsx/pps files.
        
        Change-Id: Ic2f495cb9923b385bce7d93a2d8121d2945221ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163652
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit b951c57d4b723621d211b552f2cd238ae0dc246a)
        
        Change-Id: I7eedc855255a30abdfdf61c8315b4f8238c07ca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165094
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167277
        Tested-by: Jenkins

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [9f078ed7b625e86182d64d5ccfbb410cdd38081c]

        tdf#160971 gtk3 a11y: Set role for custom editable combobox
        
        Set the combobox a11y role for the box in the .ui file
        used for the custom gtk3 combobox implementation.
        
        With this in place, moving focus to the "Font Name" or
        another editable combobox in the Writer toolbar now
        makes Orca announce that one as "editable combobox"
        rather than just "text".
        
        See also
        
            commit 1e851093f0148d2c55fc3fd377d274f6703c71c9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 18 14:02:25 2024 +0200
        
                tdf#159910 gtk3 a11y: Keep a11y props for combobox
        
        for a very similar change that caused the proper
        role to be announced for non-editable comboboxes.
        
        Change-Id: I3062e5c062911040ef0ec5721d15fee78d85d0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167262
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [26e7ddb2c87642099f1320279c96a9176ef18dfe]

        gtk3 a11y: Drop WindowEventHandler completely
        
        As mentioned in
        
            commit c45c64aeb57dce91965d7be54601128946455c90
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        , the a11y bridge should not have to handle VCL events itself,
        but all relevant events should be forwarded to the a11y
        event listener as appropriate `AccessibleEventObject` and be handled
        by the a11y event listener instead, see `AtkListener::notifyEvent`
        for the gtk3 implementation.
        
        Now that handling of all VCL events has been dropped in
        previous commits, drop the `WindowEventHandler` completely.
        This also means that the call to `InitAtkBridge` when initializing
        the `GtkInstance` and the `DeInitAtkBridge` on destruction
        is no longer necessary.
        
        In a quick test with the Orca screen reader and the gtk3
        VCL plugin, nothing suspicious showed up, things were
        still working as expected and experienced prior to the
        change series dropping the VCL event handling from the
        gtk3 a11y bridge.
        
        Change-Id: Ieed270b636f361c57cd4e78aceaecc7d174409d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167256
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [047475fb4c50f0c99aa283c3a882763ae57b8c85]

        gtk3 a11y: Drop VclEventId::TabpageActivate processing
        
        Drop the manual processing of `VclEventId::TabpageActivate`
        in the gtk3 a11y bridge.
        
        As mentioned in
        
            commit c45c64aeb57dce91965d7be54601128946455c90
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        , the a11y bridge should not have to handle VCL events itself,
        but all relevant events should be forwarded to the a11y
        event listener as appropriate `AccessibleEventObject` and be handled
        by the a11y event listener instead, see `AtkListener::notifyEvent`
        for the gtk3 implementation.
        
        By now, most if not all tab pages should be native GTK widgets
        anyway.
        For non-native ones, `VCLXAccessibleTabControl::ProcessWindowEvent`
        contains handling for the `VclEventId::TabpageActivate` event that
        should be taking care of forwarding that as the corresponding
        a11y event to the a11y bridges. If anything is still missing after
        this commit, that's probably a good starting point for further
        analysis.
        
        Change-Id: I5b3f64c973d4030d2b68be6dff1d771bc0cef405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [fedd4886b0b63ea3254ea4ce4b7f9b5b73af95f0]

        gtk3 a11y: Drop VclEventId::MenuHighlight processing
        
        Drop the manual processing of `VclEventId::MenuHighlight`
        in the gtk3 a11y bridge.
        
        As mentioned in
        
            commit c45c64aeb57dce91965d7be54601128946455c90
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        , the a11y bridge should not have to handle VCL events itself,
        but all relevant events should be forwarded to the a11y
        event listener as appropriate `AccessibleEventObject` and be handled
        by the a11y event listener instead, see `AtkListener::notifyEvent`
        for the gtk3 implementation.
        
        In a quick test, menu items were still announced
        just fine by the Orca screen reader when using the
        gtk3 VCL plugin with this commit in place.
        
        By now, most menus should be native GTK widgets anyway.
        For non-native menus,
        `OAccessibleMenuBaseComponent::ProcessMenuEvent` contains
        handling for the `VclEventId::MenuHighlight` event that
        should be taking care of forwarding that as the corresponding
        a11y event to the a11y bridges. If anything is missing after
        this commit, that's probably a good starting point for further
        analysis.
        
        Change-Id: Ia8686101dc559ed98b48285eac15c35fc10818af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167254
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [f44b1cf1fc2925d54512f1f04361ac2c2fc7d276]

        gtk3 a11y: Drop VclEventId::ToolboxHighlight{,Off} processing
        
        Drop the manual processing of `VclEventId::ToolboxHighlight`
        in the gtk3 a11y bridge.
        
        As mentioned in
        
            commit c45c64aeb57dce91965d7be54601128946455c90
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        , the a11y bridge should not have to handle VCL events itself,
        but all relevant events should be forwarded to the a11y
        event listener as appropriate `AccessibleEventObject` and be handled
        by the a11y event listener instead, see `AtkListener::notifyEvent`
        for the gtk3 implementation.
        
        In a quick test, toolbar items were still announced
        just fine by the Orca screen reader when using the
        gtk3 VCL plugin with this commit in place.
        
        `VCLXAccessibleToolBox::ProcessWindowEvent` handles
        `VclEventId::ToolboxHighlight` and
        `VclEventId::ToolboxHighlightOff` whose manual processing
        is now dropped from gtk3, so the former might be a good place
        to further look into if anything is still missing after
        this commit.
        
        The now dropped handling was originally added in
        
            commit e9816343cd71dfe556e6ace12d67c642a8dde635
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Thu May 11 12:32:22 2006 +0000
        
                INTEGRATION: CWS atkbridge2 (1.2.4); FILE MERGED
                2006/05/08 13:45:15 obr 1.2.4.1: #135353# fixed crashes when closing sub-toolbars and application exit
        
            Change-Id: Ib6cfafbc3711fce6a48120439654dc6e6c15971a
        
        Change-Id: I87061fdc595a0a29c2a3dce88ab13c9d7d7ba1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167253
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Noel Grandin  <noelgrandin@gmail.com>  [6517ce70e50e61441484e7ee7a4be0e265020175]

        make skia into static library
        
        (1) we only use it from inside vcl
        (2) it exports a boatload of symbols
        (3) its a performance hotspot
        
        so lets link it inside and give the optimiser as
        much room as possible.
        Change-Id: If19d5556e3b45f40ef09d1e9225d12ef5f1ec32a
        
        Change-Id: I3d5edca20f5a15e8981f17fe9fcb9a338006eaff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167273
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Heiko Tietze  <tietze.heiko@gmail.com>  [f1d69a84ac82034d7f98877780c549f06d93792d]

        Resolves tdf#160324 - Larger hit area for col/row resize actions
        
        Tentative solution made optional depending on experimental settings
        
        Change-Id: I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167041
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-07  Heiko Tietze  <tietze.heiko@gmail.com>  [a5d0114bbb40f5bffcb19d6e6b3a5bf43aab1446]

        Resolves tdf#156885 - Make comment authorship optional
        
        Change-Id: I3422c9e5606fa9eb9aa450f518af8426e598ab8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167260
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [606623d0fc5321754d9a054881ae9cac94cd9f04]

        lxml: upgrade to 5.2.1
        
        * 0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 got
          obsoleted with https://github.com/lxml/lxml/commit/9686dd9c7670d18acff6360c8444520273d5f1b2
        
        * Wincompatible-function-pointer-types.patch and
        Wincompatible-pointer-types.patch got obsoleted with
        https://github.com/lxml/lxml/commit/6bdf4c321b92e002123b4c162c75524dbeb4d54d
        
        Change-Id: I8f0dcba3bd64a1766a2292b687c8959c739ced6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167278
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [11dcaad533553999dc643807f6f21f8f98bc9e20]

        Fix typo
        
        Change-Id: I8772d0e12b169559a3bf99347097939ede5db582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167266
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [37722469bee4fe170e9514e32d6112ca31c2d934]

        loplugin:ostr in editeng
        
        Change-Id: I7353710e1558d486130ace09844ce97150eb4c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167272
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [9422879a5cf74120c1057b0f8150529e304f7c95]

        loplugin:ostr in desktop
        
        Change-Id: Ib43d1c3a182badddd870bcb8e052ac7fd0a16fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [c87077f653739d00ed5237d54838c1a454d65c4f]

        fix Windows incremental build
        
        after
            commit 4c86718e78c6b18c84774e48ca025694364c251a
            Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Date:   Thu Apr 18 12:45:01 2024 +0200
            initial support for running autogen.sh inside wsl from git-bash
        
        otherwise we end up with mixed cygwin/windows paths in our .d
        files, which the make executable we use will not like.
        
        Change-Id: Ia1325793f47657a23774c216df319ae6afd6d638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167269
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-07  László Németh  <nemeth@numbertext.org>  [c8a99cb8dce54de506ba66d1cc0818b9b5f7858b]

        tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'
        
        Add new hyphenation option to limit hyphenation
        of the last full line of the hyphenated paragraph.
        
        Move also loext:hyphenation-keep-type to paragraph-properties,
        following the associated hyphenation-keep.
        
        Note: value "always" is defined by CSS 4 hyphenate-limit-last,
        see https://www.w3.org/TR/css-text-4/#hyphenate-line-limits.
        
        Follow-up to commit 6e8819f29b6051a0e551d77512830539913ec277
        "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type".
        
        Change-Id: I2121269205fc89fb5367dccdca00195aac68f3e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167232
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-05-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0ca20dca3349daa303b89251443f550491968a39]

        Related: tdf#127293 Add unit test for xlookup regex search mode
        
        Add unit test for regex search mode in case of xlookup.
        
        Follow-up commit: 51abf44808c6793a184e986b62c0786753e11ded
        (Related: tdf#127293 Fix regex search mode in XLOOKUP wildcards mode)
        
        Change-Id: Id23c340ab6735c2c40defc8d231dc3da18c8694e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167192
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ee04612875b30d122849038a00382356def6bc1]

        loplugin:ostr basegfx
        
        Change-Id: I79212cbfd1c7cae810f8e24dbd73372b9f97f9ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167190
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [01fe29c78d21951be45bf8957092786d67c70b8e]

        glm: Upgrade to 1.0.1
        
        c++20.patch.0 got obseleted in
        https://github.com/g-truc/glm/commit/6fdeff4d67f3db493d47c44da20aa1efaa6574ef
        
        Change-Id: I8698968b55f299c55777fe280b3eda9e2bea9cdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167268
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [d52a4dba6a247a0ee2e1c419533818fbfd281f71]

        loplugin:ostr in dbaccess
        
        Change-Id: I6d720ef94d9f29c120f292b844721621e6630856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167259
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [04d383191403f400d7917412ea72a441e120b333]

        loplugin:ostr in cppcanvas
        
        Change-Id: I59c10b0d82297157a87cb366be69c8e757638c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bd9cd4365efd03223d619e0044fbeda0e687b0d9]

        tdf#149252 Add extended tips to sparklines dialog
        
        Change-Id: I62487894a2e507b9f63f88745e1ce54ce471e863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167246
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [ecf6f6f25663e81ebf18589b895a22bc5b6ffbab]

        loplugin:ostr in cui
        
        Change-Id: I593eb3c02768423fc8cea8d93c112655860228d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Laurent Balland  <laurent.balland@mailo.fr>  [00b3bcc64fc32165d19e78b99cc6f78317824806]

        tdf#160712 tdf#160899 Update Candy template
        
        + Use only Noto family fonts
        + remove language and country tags
        + rename master pages
           -"Title of Content" to "Table of Content"
           -"Title content 3" to "Title Content 3"
           -correct first master page as "Candy" (tdf#158496)
        + remove error messages (tdf#159199 Comment 3)
        + replace dummy text with placeholders (tdf#160712)
        + use styles for Filled colors
        + move credits to meta.xml
        + replace gradient picture with gradients
        + remove credits picture
        + remove unused styles
        + remove area color for background objects (tdf#160899)
        
        Change-Id: I03f2d2c86c3adbc9c5b8bdff31279c0c4c51ed69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165602
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>

2024-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [39ca26c6705d1544b7007bf930c9e862c0aa4b25]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I3f13b457025280486d6cb4d2935c1ef5a52b0637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167250
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db68bf7859f79676cd7addb2565e6ce0fbf4e570]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Iaef14644b8d9fa0c26de39871e9352d5d79ebb08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167248
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0b87bf9a34a06d344f4b803c31442c2f723a8ee]

        cid#1596888 Explicit null dereferenced
        
        Change-Id: I8b6b99a66913a1a6f30046d1cba9fce87d469415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167249
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-07  Michael Meeks  <michael.meeks@collabora.com>  [a2605a66fdb8ab18018f3a0f8e49043e73854986]

        lok: reseed comphelper's random number generator on fork.
        
        Also avoid std::random_device it doesn't work in a COOL
        kit process.
        
        Change-Id: Ie2d063611a73e734afd92d6fd779f34a2f316230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167070
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-05-07  Michael Stahl  <michael.stahl@allotropia.de>  [72ea1005b987159a6a59f9379e63321e0b0dd44f]

        tdf#160402 writerfilter: extend StyleMap with all Word styles
        
        There doesn't appear to be an accurate and complete documentation of all
        the Word built-in style names, but fortunately Word writes them all into
        styles.xml in a w:latentStyles element anyway.
        
        It turned out that a lot of the Writer built-in style names here were
        obsoleted by renaming and did not match any more.
        
        Change-Id: Ic69785a34524f667b83a06a267715b2c8b0165d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167242
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-07  Miklos Vajna  <vmiklos@collabora.com>  [6200d89b905d51776ff4f3c8a84f338655ffaa7f]

        tdf#160952 sw: ignore top margin of para on non-first pages with newer DOCX
        
        The 2nd page of the bugdoc has a single paragraph, with a non-zero top
        margin. This is ignored in Word, but wasn't ignored in Writer.
        
        Experimenting with the document, it looks like old Word files also don't
        ignore this top margin: it started when the compat mode is upgraded
        (from binary DOC or Word 2010) to Word 2023 or newer. Also the top
        margin is only ignored for the first paragraph on the page, and only in
        case it's not on the first page.
        
        Fix the problem by introducing a new SwFrame::IsCollapseUpper() function
        to decide if the upper margin should be collapsed or not, and then by
        using it in SwFlowFrame::CalcUpperSpace() at one place where we read the
        top margin from the doc model. Take advantage of the fact that we have
        related, existing compat flags that tell us if we're in "Word >= 2013"
        compat mode: see e.g. GetFlyAnchorBottom(), which explains
        DocumentSettingId::TAB_OVER_MARGIN is a good indicator that this is a
        "Word <= 2010" document. Also, DocumentSettingId::TAB_OVER_SPACING is an
        indicator that this is a Word document, so we want the "TabOverSpacing
        && !TabOverMargin" case.
        
        This doesn't change all reads of the upper spacing of a text node, but
        is enough to avoid the unwanted top spacing, as demonstrated by the
        bugdoc.
        
        Change-Id: Ibdebdf5f0555256a0b6ed85d07079f14ef69a576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167252
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-07  Justin Luth  <justin.luth@collabora.com>  [e7ea91a4af1242fcfa5f5ba5f04bbc6662453e28]

        tdf#160814 writerfilter: insert comment after other comments #2
        
        Since writerfilter moved into sw in 24.8,
        this section can be seriously optimized.
        
        Change-Id: I6a228b1a910181c38ba5c8faf9566954fffc47fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166988
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-05-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [7d1242b01d3ad9be1cfcf2bd3fbee9ce63dddddf]

        move opencl check at startup inside its own thread
        
        shaves 30% off the startup time for me.
        
        Change-Id: Ibabb2a6b283243aaaaafb8257e99e82e2ef112c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1de066d04f73a0e901e875597b8244a3ecdf624c]

        loplugin:ostr in chart2
        
        Change-Id: I2985b6793a776639214a25bf9732c000b9026bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167236
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d97239b7a92c8dc1c1ee9a6474768ed1e744ef5]

        loplugin:ostr in connectivity
        
        Change-Id: Ice633719b05240ab5a052b62ca4eafe89f97e12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167238
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [b667543a2a63b3933630032b5470db8bc3eefaf9]

        loplugin:ostr in configmgr
        
        Change-Id: If1caaee8e54b5861e1435e900b3ae7bd90ecae5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167237
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-07  Zainab Abbasi  <101zabbasi@gmail.com>  [ae4f76363dd25eaaa7d332512af067567e78ca0a]

        tdf#145614 Convert #define to enum
        
        Change-Id: I50cad24e9cbda04cfe1209d824cad61da2287def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166191
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-07  Zainab Abbasi  <101zabbasi@gmail.com>  [837c9af957a4935d44f7e4ad6d290be915bcced2]

        tdf#147021 Replace SAL_N_ELEMENTS with std::size
        
        Change-Id: I2df519a73f283c3a74353222826e82beaa98f017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166194
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-07  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [971eb758132994b5dfacf0af456fbb96f1863534]

        odk/examples: grammar fixes
        
        Also remove outdated comment related to RTL_CONSTASCII_STRINGPARAM
        (only the first line was removed in the past)
        
        Change-Id: Iebef1bf83ab049a96c846e714cb700df4dacd878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167233
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [b420a5cd2424d2fc5efa3fcc395d14366f4b2773]

        a11y: Drop AccessibleChildren typedef
        
        Change-Id: I13946bb4a991dceeb26a0a9364f6067397b94001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167197
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [0feb490c7625ed1bef7c59d197436fc849bd8dfa]

        wina11y: Return E_INVALIDARG if out param is null
        
        Change-Id: Ia7abdd7fe1fbc5b1a6eaecf7d842852bc3815e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167201
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [593923ee108b01c03ee3b14295fedfb8d07e7ea0]

        tdf#160806 tdf#160837 gtk3 a11y: Drop VclEventId::ToolboxButtonStateChanged
        
        Similar to how the previous
        
            Change-Id: I00e62016ced2fbb8796960671f5e58a3ceac4b29
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon May 6 14:44:36 2024 +0200
        
                tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        dropped handling for `VclEventId::WindowGetFocus`
        and `VclEventId::ObjectDying` in the gtk3 a11y bridge,
        do the same for `VclEventId::ToolboxButtonStateChanged`.
        
        And drop `VclEventId::ObjectDying` completely, as the
        gtk3 a11y bridge was the only place processing it.
        
        That event and the handling had been introduced in
        
            commit 3b40f502341272e989ae5266a1f8a03f2736449b
            Author: Ivo Hinkelmann <ihi@openoffice.org>
            Date:   Tue Feb 5 11:30:51 2008 +0000
        
                INTEGRATION: CWS fwk83_SRC680 (1.7.186); FILE MERGED
                2008/01/30 12:40:39 obr 1.7.186.2: fix for fedora tinderbox (64bit)
                2008/01/15 23:49:28 obr 1.7.186.1: #i70872# create wrapper for toolbox items that change state
        
            commit a1cbbd113da4ce3d5342d9ae5ff1c8d2137aa59c
            Author: Ivo Hinkelmann <ihi@openoffice.org>
            Date:   Tue Feb 5 11:30:25 2008 +0000
        
                INTEGRATION: CWS fwk83_SRC680 (1.51.160); FILE MERGED
                2008/01/14 14:35:26 cd 1.51.160.1: #i70872# Added VCLEVENT_TOOLBOX_BUTTONCHANGED to notify accessibility implementation that an action happens to a toolbox button
        
            commit 3f1afd178875babe7ab79d22ab260221665bfb3f
            Author: Ivo Hinkelmann <ihi@openoffice.org>
            Date:   Tue Feb 5 11:29:57 2008 +0000
        
                INTEGRATION: CWS fwk83_SRC680 (1.2.262); FILE MERGED
                2008/01/14 14:35:26 cd 1.2.262.1: #i70872# Added VCLEVENT_TOOLBOX_BUTTONCHANGED to notify accessibility implementation that an action happens to a toolbox button
        
        to ensure that an a11y object is created for toolbar
        buttons whose state changes, so that the corresponding
        a11y events are forwarded to the platform layer, see
        the referenced OOo bug #i70872# [1] for more details.
        
        This seems to be no longer necessary.
        By now, at least the scenario of toggling the
        bold/italics/underline status of text is
        announced just fine by Orca 46.1-1 on Debian
        testing with this change in place.
        
        (FWIW, tdf#123864 and the corresponding commits are more
        recent tickets/commits related to the topic.)
        
        Like for the above-mentioned change,
        dropping that handling addresses another case where the
        work window/root pane's a11y object when walking up
        the a11y hierarchy would be problematic, as it doesn't
        take into account the GtkWidget hierarchy.
        
        Sample backtrace of how the "problematic" a11y object
        was created (frame 1 below is the one where the a11y object
        with role root pane is created.)
        
            1  atk_object_wrapper_new                                              atkwrapper.cxx             983  0x7f620365672b
            2  atk_object_wrapper_ref                                              atkwrapper.cxx             948  0x7f62036560a0
            3  atk_object_wrapper_new                                              atkwrapper.cxx             1000 0x7f6203656952
            4  atk_object_wrapper_ref                                              atkwrapper.cxx             948  0x7f62036560a0
            5  atk_object_wrapper_new                                              atkwrapper.cxx             1000 0x7f6203656952
            6  atk_object_wrapper_ref                                              atkwrapper.cxx             948  0x7f62036560a0
            7  atk_object_wrapper_new                                              atkwrapper.cxx             1000 0x7f6203656952
            8  atk_object_wrapper_ref                                              atkwrapper.cxx             948  0x7f62036560a0
            9  create_wrapper_for_child                                            atkutil.cxx                359  0x7f620364c740
            10 handle_toolbox_buttonchange                                         atkutil.cxx                376  0x7f620364c1ef
            11 WindowEventHandler                                                  atkutil.cxx                438  0x7f620364bd7f
            12 Link<VclSimpleEvent&, void>::Call                                   link.hxx                   111  0x7f620dfd4ef8
            13 VclEventListeners::Call                                             vclevent.cxx               46   0x7f620dfd3f1a
            14 Application::ImplCallEventListeners                                 svapp.cxx                  725  0x7f620df96b0d
            15 vcl::Window::CallEventListeners                                     event.cxx                  225  0x7f620d59f6ee
            16 ToolBox::SetItemState                                               toolbox2.cxx               1197 0x7f620d6afd81
            17 ToolBox::CheckItem                                                  toolbox.hxx                515  0x7f6214502c53
            18 (anonymous namespace)::PopupMenuToolbarController::statusChanged    popuptoolbarcontroller.cxx 180  0x7f621454205d
            19 (anonymous namespace)::GenericPopupToolbarController::statusChanged popuptoolbarcontroller.cxx 373  0x7f6214540855
            20 SfxDispatchController_Impl::addStatusListener                       unoctitm.cxx               797  0x7f6213090e95
            21 SfxOfficeDispatch::addStatusListener                                unoctitm.cxx               279  0x7f6213090ade
            22 svt::ToolboxController::bindListener                                toolboxcontroller.cxx      558  0x7f620fe9fbce
            23 svt::ToolboxController::update                                      toolboxcontroller.cxx      235  0x7f620fe9f207
            24 framework::ToolBarManager::UpdateControllers                        toolbarmanager.cxx         726  0x7f62145b0f25
            25 framework::ToolBarManager::AsyncUpdateControllersHdl                toolbarmanager.cxx         2291 0x7f62145bdbfc
            26 framework::ToolBarManager::LinkStubAsyncUpdateControllersHdl        toolbarmanager.cxx         2278 0x7f62145aff9d
            27 Link<Timer *, void>::Call                                           link.hxx                   111  0x7f620dfbc618
            28 Timer::Invoke                                                       timer.cxx                  75   0x7f620dfbc46c
            29 Scheduler::CallbackTaskScheduling                                   scheduler.cxx              509  0x7f620df5fa08
            30 SalTimer::CallCallback                                              saltimer.hxx               54   0x7f620368b566
            31 sal_gtk_timeout_dispatch                                            gtkdata.cxx                733  0x7f620368a573
            32 ??                                                                                                  0x7f62097110d9
            33 ??                                                                                                  0x7f6209714317
            34 g_main_context_iteration                                                                            0x7f6209714930
            35 GtkSalData::Yield                                                   gtkdata.cxx                405  0x7f62036888ef
            36 GtkInstance::DoYield                                                gtkinst.cxx                435  0x7f620368dd73
            37 ImplYield                                                           svapp.cxx                  378  0x7f620df94dfc
            38 Application::Yield                                                  svapp.cxx                  466  0x7f620df9470b
            39 Application::Execute                                                svapp.cxx                  353  0x7f620df944a2
            40 desktop::Desktop::Main                                              app.cxx                    1615 0x7f62171254fc
            41 ImplSVMain                                                          svmain.cxx                 229  0x7f620dfb760e
            42 SVMain                                                              svmain.cxx                 261  0x7f620dfb9659
            43 soffice_main                                                        sofficemain.cxx            93   0x7f62171a7eb3
            44 sal_main                                                            main.c                     51   0x56162eceea5d
            45 main                                                                main.c                     49   0x56162eceea37
        
        [1] https://bz.apache.org/ooo/show_bug.cgi?id=70872
        
        Change-Id: I7409806071a00f32b201b08a831dc6941f072047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167209
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [c45c64aeb57dce91965d7be54601128946455c90]

        tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
        
        Drop custom handling for VCL events `VclEventId::WindowGetFocus`
        and `VclEventId::ObjectDying` in the gtk3 a11y bridge.
        
        In my understanding, the a11y bridge should not have to
        handle any of these by itself, but all relevant a11y
        events should be forwarded to the a11y listener
        as an appropriate `AccessibleEventObject` and be handled
        by the a11y event listener instead, see
        `AtkListener::notifyEvent` for the gtk3 implementation.
        
        In a quick test with Orca, I didn't notice anything not being
        announced anymore with this change in place.
        
        If something is still not announced due to this change, a
        proper fix is likely to make sure that a proper a11y event
        is emitted and handled in `AtkListener::notifyEvent` instead.
        
        Note how `VCLXAccessibleComponent::ProcessWindowEvent` already
        handles the `VclEventId::WindowGetFocus` and
        `VclEventId::ObjectDying` window events. This (or
        a corresponding override in a subclass) and
        `VclEventId::ObjectDying` are potentially good places to
        start analysis if this change here results in any regressions.
        
        Dropping this custom handling also fixes one problematic
        way that an accessible object would be created for the
        work window/root panel (e.g. in Writer) from the corresponding
        XAccessible independent of the corresponding GTK Widget hierarchy,
        thus breaking the a11y hierarchy (ascending the tree doesn't
        work, see tdf#160806).
        
        This could be observed by starting LO Writer with the gtk3 VCL
        plugin first, then start Accerciser.
        
        Printing the a11y info for the parent of the object with role
        root pane as shown in Accerciser:
        
            In [1]: acc.parent
            Out[1]: <Atspi.Accessible object at 0x7f1f0f5b7780 (AtspiAccessible at 0x41f9c60)>
            In [2]: acc.parent.role
            Out[2]: <enum ATSPI_ROLE_FRAME of type Atspi.Role>
            In [3]: acc.parent.role
            Out[3]: <enum ATSPI_ROLE_FRAME of type Atspi.Role>
        
        Selecting the object shown as the parent in Accerciser's tree
        of LO's a11y hierarchy shows that this is not the same object:
        
            In [4]: acc
            Out[4]: <Atspi.Accessible object at 0x7f1f05f92100 (AtspiAccessible at 0x2d45c80)>
            In [5]: acc.role
            Out[5]: <enum ATSPI_ROLE_PANEL of type Atspi.Role>
        
        and consequently, the first child of that accessible doesn't
        report the accessible itself as its parent:
        
            In [6]: acc.get_child_at_index(0).parent == acc
            Out[6]: False
        
        The commit message of
        
            commit 252b1591d5e4e3adbf7063b56c2b578fe046ad3d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 30 15:30:52 2024 +0200
        
                tdf#159369 tdf#160806 tdf#160837 gtk3 a11y: Don't skip parents one way
        
        has some more background information.
        
        Extra local change in place showing where the accessible object gets
        created (used for analysis with rr):
        
            diff --git a/vcl/unx/gtk3/a11y/atkwrapper.cxx b/vcl/unx/gtk3/a11y/atkwrapper.cxx
            index db0aa1dbc907..c73d28987f26 100644
            --- a/vcl/unx/gtk3/a11y/atkwrapper.cxx
            +++ b/vcl/unx/gtk3/a11y/atkwrapper.cxx
            @@ -977,6 +977,10 @@ atk_object_wrapper_new( const css::uno::Reference< css::accessibility::XAccessib
        
                     AtkObject* atk_obj = ATK_OBJECT(pWrap);
                     atk_obj->role = mapToAtkRole(xContext->getAccessibleRole(), xContext->getAccessibleStateSet());
            +        // NOTE: the object of interest is root pane, breaks the a11y hierarchy
            +        // as it reports wrong parent
            +        if (atk_obj->role == ATK_ROLE_ROOT_PANE)
            +            SAL_WARN("vcl.gtk", "Creating wrapper for root pane");
                     atk_obj->accessible_parent = parent;
        
                     ooo_wrapper_registry_add( rxAccessible, atk_obj );
        
        Sample backtrace of how the problematic accessible object
        got created without this commit in place:
        
            1  atk_object_wrapper_new                                              atkwrapper.cxx       983  0x7fb5dda5ae8b
            2  atk_object_wrapper_ref                                              atkwrapper.cxx       948  0x7fb5dda5a800
            3  atk_wrapper_notify_focus_change                                     atkutil.cxx          47   0x7fb5dda4cab0
            4  handle_get_focus                                                    atkutil.cxx          451  0x7fb5dda4debd
            5  WindowEventHandler                                                  atkutil.cxx          512  0x7fb5dda4d9e3
            6  Link<VclSimpleEvent&, void>::Call                                   link.hxx             111  0x7fb5e81d4ef8
            7  VclEventListeners::Call                                             vclevent.cxx         46   0x7fb5e81d3f1a
            8  Application::ImplCallEventListeners                                 svapp.cxx            725  0x7fb5e8196b0d
            9  vcl::Window::CallEventListeners                                     event.cxx            225  0x7fb5e779f6ee
            10 vcl::Window::PreNotify                                              event.cxx            70   0x7fb5e779f58c
            11 SystemWindow::PreNotify                                             syswin.cxx           245  0x7fb5e788e470
            12 vcl::Window::CompatPreNotify                                        window.cxx           3941 0x7fb5e790cddd
            13 ImplCallPreNotify                                                   winproc.cxx          69   0x7fb5e791d061
            14 vcl::Window::ImplGrabFocus                                          mouse.cxx            383  0x7fb5e782ffc5
            15 vcl::Window::GrabFocus                                              window.cxx           2988 0x7fb5e78fa027
            16 vcl::Window::ImplAsyncFocusHdl                                      winproc.cxx          2061 0x7fb5e7923386
            17 vcl::Window::LinkStubImplAsyncFocusHdl                              winproc.cxx          2035 0x7fb5e792318d
            18 Link<void *, void>::Call                                            link.hxx             111  0x7fb5e792c298
            19 ImplHandleUserEvent                                                 winproc.cxx          2287 0x7fb5e7927f79
            20 ImplWindowFrameProc                                                 winproc.cxx          2851 0x7fb5e7924930
            21 SalFrame::CallCallback                                              salframe.hxx         312  0x7fb5e85a0310
            22 SalGenericDisplay::ProcessEvent                                     gendisp.cxx          66   0x7fb5e85cae6f
            23 SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const salusereventlist.cxx 119  0x7fb5e80b49bd
            24 SalUserEventList::DispatchUserEvents                                salusereventlist.cxx 120  0x7fb5e80b4864
            25 SalGenericDisplay::DispatchInternalEvent                            gendisp.cxx          51   0x7fb5e85cadc5
            26 call_userEventFn                                                    gtkdata.cxx          824  0x7fb5dda8e216
            27 ??                                                                                            0x7fb5e47110d9
            28 ??                                                                                            0x7fb5e4714317
            29 g_main_context_iteration                                                                      0x7fb5e4714930
            30 GtkSalData::Yield                                                   gtkdata.cxx          405  0x7fb5dda8ccef
            31 GtkInstance::DoYield                                                gtkinst.cxx          435  0x7fb5dda92173
            32 ImplYield                                                           svapp.cxx            378  0x7fb5e8194dfc
            33 Application::Yield                                                  svapp.cxx            466  0x7fb5e819470b
            34 Application::Execute                                                svapp.cxx            353  0x7fb5e81944a2
            35 desktop::Desktop::Main                                              app.cxx              1615 0x7fb5f13254fc
            36 ImplSVMain                                                          svmain.cxx           229  0x7fb5e81b760e
            37 SVMain                                                              svmain.cxx           261  0x7fb5e81b9659
            38 soffice_main                                                        sofficemain.cxx      93   0x7fb5f13a7eb3
            39 sal_main                                                            main.c               51   0x55b83ad6da5d
            40 main                                                                main.c               49   0x55b83ad6da37
        
        Sample backtrace for how the root pane a11y object is created for the
        good case, i.e. the case where the root pane's parent is set properly
        as it uses the GTK widget hierarchy (backtrace obtained from an rr run
        when first starting Accerciser, then LO, with master as of
        7a895ec4205659038aa95941b65715fed1a3e7be + the same local change as mentioned
        above):
        
            1  atk_object_wrapper_new            atkwrapper.cxx  983  0x7f3799a5b48b
            2  wrapper_factory_create_accessible atkfactory.cxx  83   0x7f3799a2c9c1
            3  ooo_fixed_get_accessible          atkfactory.cxx  95   0x7f3799a2c6d2
            4  ??                                                     0x7f37993ec4c8
            5  ??                                                     0x7f3798c536d3
            6  ??                                                     0x7f379f9110d9
            7  ??                                                     0x7f379f914317
            8  g_main_context_iteration                               0x7f379f914930
            9  GtkSalData::Yield                 gtkdata.cxx     405  0x7f3799a8d2df
            10 GtkInstance::DoYield              gtkinst.cxx     435  0x7f3799a92743
            11 ImplYield                         svapp.cxx       378  0x7f37a4194dfc
            12 Application::Yield                svapp.cxx       466  0x7f37a419470b
            13 Application::Execute              svapp.cxx       353  0x7f37a41944a2
            14 desktop::Desktop::Main            app.cxx         1615 0x7f37ad3254fc
            15 ImplSVMain                        svmain.cxx      229  0x7f37a41b760e
            16 SVMain                            svmain.cxx      261  0x7f37a41b9659
            17 soffice_main                      sofficemain.cxx 93   0x7f37ad3a7eb3
            18 sal_main                          main.c          51   0x560d4a1f4a5d
            19 main                              main.c          49   0x560d4a1f4a37
        
        Similar changes for other events will follow.
        (Keeping them separate for easier bibisecting/analysis if any
        of those changes causes regressions.)
        
        Change-Id: I00e62016ced2fbb8796960671f5e58a3ceac4b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167208
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [1b9041a7c97c31a12afe7b69f0e1e4005a819509]

        tdf#160806 tdf#160837 gtk3 a11y: Port from deprecated atk_focus_tracker_notify
        
        `atk_focus_tracker_notify` takes care of sending an
        "AtkObject:focus-event" event for the given object.
        However, both, `atk_focus_tracker_notify` and the "AtkObject:focus-event"
        ATK event (which triggers a "focus" AT-SPI event) are
        deprecated, quoting [1]:
        
        > Focus tracking has been dropped as a feature to be implemented by ATK
        > itself. As AtkObject::focus-event was deprecated in favor of a
        > AtkObject::state-change signal, in order to notify a focus change on
        > your implementation, you can use atk_object_notify_state_change()
        > instead.
        
        Move the existing call to `atk_object_notify_state_change` up and
        use instead of the deprecated function.
        
        For the example of the "Print" button in
        Writer's standard toolbar, it can now be
        seen that a "object:state-changed:focused"
        instead of a "focus" event is received with
        a corresponding listener when tabbing to
        the button and then further:
        
        Before:
        
            88.7 focus:(0, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
            88.7 object:state-changed:focused(1, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
            89.4 object:state-changed:focused(0, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
        
        After:
        
            80.0 object:state-changed:focused(1, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
            80.0 object:state-changed:focused(1, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
            80.8 object:state-changed:focused(0, 0, 0)
                    source: [push button | Print]
                    application: [application | soffice]
        
        The first event is the one emitted fromt this place,
        the others are from elsewhere.
        
        This also already shows that duplicate events are
        sent. Eliminating those which also cause
        other problems is planned in upcoming steps.
        
        [1] https://docs.gtk.org/atk/func.focus_tracker_notify.html
        
        Change-Id: Ieb9d25445b620681b01b887c0c120c80a43379ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167207
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [c1a7de292c3f1d1ec52dbda4c027dc91a9718777]

        tdf#160806 tdf#160837 gtk3 a11y: Don't use idle
        
        Don't use and idle to call the (deprecated) ATK focus tracker,
        but do so right away.
        
        Since this is no longer called in an idle, the SolarMutexGuard
        should also no longer be needed, so drop it.
        
        It's not clear why the focus event was handled in an
        idle ever since
        
            commit 3b5c378706e465f59d78f95fddc5eff9e1a8fe19
            Author: Rüdiger Timm <rt@openoffice.org>
            Date:   Fri May 5 09:58:25 2006 +0000
        
                INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED
                2006/04/27 14:47:54 obr 1.1.2.17: #134576# move focus clearing code to atkwindow.cxx
                2006/04/27 08:18:11 obr 1.1.2.16: #134571# toolbox items are no VCL windows
                2006/03/31 12:19:40 obr 1.1.2.15: #i63583# eliminated warnings
                2006/03/03 11:07:09 obr 1.1.2.14: #i47890# fixed a crash when event source does not implement XAccessibleContext
                2006/03/01 11:04:11 obr 1.1.2.13: #i47890# recursivly attach listeners to windows of type TREELISTBOX
                2006/02/16 11:07:11 obr 1.1.2.12: #i47890# ORoadmapIDHyperLabel is derived from FixedText
                2006/02/15 12:42:56 obr 1.1.2.11: #i47890# simulate focus events for page tabs
                2006/02/07 09:26:21 obr 1.1.2.10: #i47890# reduce amount of focus notifications
                2006/01/12 13:56:14 obr 1.1.2.9: #i47890# Solaris compile fixes
                2006/01/05 14:06:32 obr 1.1.2.8: #i47890# override toolkit name and version and reworked bridge initialization
                2005/11/16 15:57:57 obr 1.1.2.7: fixed for menu state ARMED only valid during notification
                2005/10/24 07:36:05 obr 1.1.2.6: #i47890# reset focused object on WINDOW_DEACTIVATE
                2005/10/20 11:57:32 obr 1.1.2.5: #i47890# initially set name and description + disabled some tracing
                2005/10/20 07:09:12 obr 1.1.2.4: #i47890# made cxx files standalone, avoid queryInterface on each API call and demacrofied try/catch to include appropriate warnings
                2005/09/28 07:24:13 obr 1.1.2.3: #i47890# changed ref-counting/life cycle once again, adjust tree and role of dialogs and filter sub-menu windows
                2005/09/26 11:01:01 obr 1.1.2.2: #i47890# reworked lifecycle of atk wrapper objects
                2005/06/14 13:57:24 obr 1.1.2.1: #i47890# global focus event listening stuff
        
        With this in place, watching for "object:focus" events in
        Accerciser still shows such an event when e.g. tabbing
        through the standard toolbar in Writer. Example for when
        the "Save" button receives focus:
        
            37.9 focus:(0, 0, 0)
                    source: [push button | Save]
                    application: [application | soffice]
        
        This is one step to port from the use of that deprecated
        focus tracker and clean up a11y event handling in the gtk3 VCL plugin.
        (Take one step at a time to keep the scope of the changes clearer
        and simplify identifying causes of any potential regressions.)
        
        (`git show --ignore-space-change` helps to see the
        "actual change" more clearly).
        
        Change-Id: Ia71b70bdf5d9db8fbb389f3c7366af48ee723af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167206
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [505803e2cb4d60153be2218a17ede8e34d95b42e]

        Point to TDF wiki
        
        Change-Id: Ib20ecddcdbbfbb39b1160508349e092db4a04e4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167200
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [80fcd2290dfc9748bb7f4e322b22b773b61daa67]

        tdf#160153 Restore Storage config item
        
        Revert "[API CHANGE] Remove deprecated Storage config item"
        
        This reverts commit 3cee7edeb31ac64e078159c7a63ebf4f54793da7.
        
        As documented in the bug report, the config item is still used.
        Thus, remove the deprecation notice, too.
        
        Change-Id: Ia9beefe8e98bce8d70c546d27999d81c5cc9fd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166904
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2f141c543494f44eab05db79533c60d342213901]

        tdf#99528 Use vertical tabs in frame style dialog
        
        Change-Id: Iae4fa2ef7050f963a8dddd5b8f348269cbe8f2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166861
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [3b0f96a0773f19f7d5bdb5725ff9667eb4809215]

        tdf#155651: Add support for "context-fill"
        
        Change-Id: I6f96cc7c059ece5f9401fc0ae552cf279e53109c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167230
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2fdcdad742bc26be509dde53f061f96a9620fd0a]

        tdf#160961: hide open remote file button from startcenter if the
        
        .uno:OpenRemote command is not available (e.g disabled in a config file).
        We also hide the Open remote file (and other) buttons in the Menubar
        if they are settled to disable.
        
        Change-Id: Ieb45c63b5d6aaf81d0eb7fa8947a9e109bee86f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167040
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [f840d3c9399cd257c8cfb757bd7666fe2e827773]

        loplugin:ostr in canvas
        
        Change-Id: I6fe0ed24a42394936975e763aba9dc3625a373ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [42e38e671cd2866e876dcf4bfa5e01741a7104e9]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I396bada76e47f5bccca8296e844822a564b1ea0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-06  Noel Grandin  <noelgrandin@gmail.com>  [39ca990a6e6a1e9b18241683ca7e9a2013db2356]

        throw more obvious error when a UITest fails to find a ui object
        
        otherwise we might hit the assert inside the UIObjectUnoObj
        constructor
        
        Change-Id: I546964c0ec21bf4f874825dfd7dc11fc99ace502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [14cca2c88f86e06ec0c58e36397ddcce9b36a461]

        loplugin:ostr in binaryurp
        
        Change-Id: I8fbb3a64cd101f219408103a771e1197e1e69776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [171f984c909dcfd9bd76809ad01060395c6c9a75]

        loplugin:ostr in bridges
        
        Change-Id: I6e0b9006924f058aceb2b0a4639f6987cec314a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167204
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-06  Patrick Luby  <guibmacdev@gmail.com>  [8d9f54165d28d83092667b7bfcd0ee48ade54c87]

        tdf#160855 fix crash due to Skia's internal maximum pixel limit
        
        Somewhere in the tens of thousands of selected fill cells,
        the size of the VirtualDevice exceeds 1 GB of pixels. But
        Skia, at least on macOS, will fail to create a surface.
        Even if there is ample free memory, Skia/Raster will fail.
        
        The second problem is that even if you disable Skia, the
        crash is just delayed when a BitmapEx is created from the
        VirtualDevice and malloc() fails.
        
        Since this data flavor really triggers one or more system
        memory limits, lower the resolution of the bitmap by keeping
        the VirtualDevice pixel size within an arbitrary number of
        pixels.
        
        Note: the artibrary "maximum number of pixels" limit that
        that Skia can handle may need to be raised or lowered for
        platforms other than macOS.
        
        Change-Id: Ie087f2db152470aa70521fbe5fe6c7cedd8504af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167145
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-05-06  Michael Stahl  <michael.stahl@allotropia.de>  [d4fdafa103bfea94a279d7069ddc50ba92f67d01]

        tdf#160402 writerfilter,sw: STYLEREF field can refer to character style
        
        Adapt SwGetRefFieldType::FindAnchor() to search for SwTextCharFormat,
        and ApplyClonedTOCStylesToXText() to replace "CharStyleName".
        
        Works for the "Intensive Hervorhebung" field in bugdoc.
        
        Change-Id: Iee126eeb4cc2ff1c570941e3beefd93527c56fee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167098
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Michael Stahl  <michael.stahl@allotropia.de>  [ab1697cb4c17fd7a2fbf8d374ac95fc03b4d00be]

        tdf#160402 filter,writerfilter: import locale-dependent STYLEREF names
        
        * Handle STYLEREF style the same way as TOC style on import.
        
        * Word 2013 does not uppercase the first letter
          ("Überschrift 1" -> "berschrift1") and there doesn't
          appear to be any justification why the code does that.
        
        * The style that's applied is actually the display style name
          so convert from source's m_sConvertedStyleName.
        
        * Change the logic in DomainMapper_Impl::ConvertTOCStyleName() to
          explicitly check and clone only known built-in Word styles, which are
          the ones that are translated.
        
        * This requires some refactoring, and to add the built-in styles in the
          bugdoc to the "StyleNameMap", which is probably still incomplete...
        
        * Exporting to DOCX appears to work without changes.
        
        * Somehow this causes the testFDO77715 to have an outlinelevel of 1 on
          the TOC paragraphs now, but that turns out to be a bugfix.
        
        Change-Id: I73bc1d1819e5cecbba2fef9cd6d290682a02a638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167097
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Bayram Çiçek  <bayram.cicek@collabora.com>  [dd3953f705cc19aad4b0fcec7fd2961246b659e3]

        tdf#159375: remove initialization on Tools>Options
        
        - Initializing some dialogs at the startup of Options
        makes it opening very slow on some low-power systems.
        
        - This patch removes this initialization. This means,
        all dialogs will be initialized at the time of search.
        Therefore, we should wait a bit longer when typing
        on the search bar to get the results...
        
        - remove the default parameter "nNumberOfNode" from
        initializeFirstNDialog()
        
        - rename initializeFirstNDialog() to initializeAllDialogs()
        
        Change-Id: I4fd9c5673f7edecfe6a6621b6018d5d405f112a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167023
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Moritz Duge <moritz.duge@allotropia.de>

2024-05-06  Heiko Tietze  <tietze.heiko@gmail.com>  [abccf22947294cfc2d9c4b727b7fd059bed55f0b]

        Resolves tdf#136917 - Focus rectangle barely visible on toolbar widgets
        
        eg. Toggle Unordered List
        
        Change-Id: I9298fcbcbf715402a59c7a8ccaa2cd341e7cda8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166916
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-06  Weblate  <noreply@documentfoundation.org>  [06ab9f194b30fa76e661b99cc50b1068114c15c1]

        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I5f400c4bcecb6021add6197190e235193fcca4bb
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167105
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4de99bb16a4c5d8c32449ddcf2f53e58c54d6f30]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3bc0152a9ce77d7ac1c27331cc176cd80af96692
          - Fix typo
            
            Change-Id: I1372a93f7e99a1265ba35d7ac841aedb6b6b2475
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167199
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6041c6df89bcb78df30c7b996c57cd15d6e58d71]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d9a6cdc569fe476f93d2cb6721a7de400b09048d
          - Fix typo
            
            Change-Id: If4371b5bce0f6864cff07f64999953bd145a9ecd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167198
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b091048d1e02f73dfc80b7e981bcd58fb801902]

        loplugin:ostr avmedia
        
        Change-Id: Ice017029f0b93ae92e76d3905f38c730cc5a2fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [64a50c65ee15c03f58ccf25308a70dfd24e791fe]

        The previous behavior of using the TerminationVetoException has changed
        
        "Since LibreOffice 5.3: Throwing this exception will only prevent termination. Exiting LibreOffice will close all the windows but the process will keep running."
        
        Currently, the behavior is different, because not only is LibreOffice
        prevented from terminating, but the last document cannot be closed either. The expected behavior is all windows should be closed, but the
        process should be kept running when using a TerminationVetoException.
        
        Change-Id: I8764aefccc4c9feec3ee0e45a54bf0aebcf16c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167194
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e5e9ed7b87072c3c6366f50127cf2b9cf6bf4499]

        tdf#99528 Use vertical tabs in page dialog
        
        Change-Id: Ie4a905be356848c998b3fca457abfec9856c9383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166746
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d6e751faa545552de7859cd6530926676caf09f]

        loplugin:ostr basic
        
        Change-Id: Ie5fc4676bd1cab2c0417b479bf08dda00936469a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167191
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [84687944439f5a2d96d771429bf58bf49b084d8c]

        replace createFromAscii with OUString literals in XMLTransformerOASISEventMap
        
        Change-Id: I48e04ebfac7898747b3481d4359f3ed4dd4c351d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167169
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2a41f854ceb2860239b1d7ec8fbc3d460c7499a1]

        tdf#99528 Use vertical tabs in Calc paragraph styles dialog
        
        Change-Id: I1528a3b38dac3c69b80b294a156359b5dc34f5bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166859
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Michael Stahl  <michael.stahl@allotropia.de>  [7178d6197b892e456a8db8a3d085a24bfd52cf32]

        tdf#40142 sw: only check level for table of contents
        
        Only Table of Contents has level settings, the level is always 0 for the
        other ToX types, which erroneously excludes nodes (as can be seen with
        testFDO77715 failing with upcoming tdf#160402 bugfix).
        
        (regression from commit 5c04c4474236cc50009aea6d89f7c443c861af19)
        
        Change-Id: Iec1c2b8eaba0ad20b2ad7d8c6b20603315a7a83d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167096
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2199e603691a770ea6b67cbaba4ce1e0ce7b1919]

        tdf#99528 Use vertical tabs in 'Format cells' dialog
        
        Change-Id: Id3ea15b1ae2ea22762f9c645e42548399eec3b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166748
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d71ea85d286a9a89e6cf784da90a820a09c0db2e]

        tdf#99528 Use vertical tabs in Calc page styles dialog
        
        Change-Id: Ia08a7351470a1561269238c29af3da58fc0b8e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166858
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [18b70ec7d9c4a0288f206cb64708f87a83789c00]

        wrong ScContentTree::SelectEntryByName early return condition
        
        Change-Id: I974f5aea545a80b0e48b50e2a2eae0729ff59691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167174
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0cd07e1fb7afc0a6831eaafabcead7e0c5f7ac3b]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I71d20c4d35b5123216da55a8b314400c93cae6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ef2066cdfe86019a3099b3530fb091ca2a4d2446]

        ScGlobal::GetUserList never returns null
        
        Change-Id: Ibce3fc1b6d85fc6183fc2552a71ead6443b45fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [09c7447e27fcf4b28b51403273b542713006aac8]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I9659627ce90d6e23bbb3c27e01c365f1167b39ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167171
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [76d762fea934df31cd81768d467d5d40d439cb67]

        do the casts just once so this is readable
        
        Change-Id: Idb9eefa31c084604a134f28892b333c56f6d6fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167161
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [5326e00cf37ebc796c650bff774441b7ec40dec8]

        replace createFromAscii with OUString literals in xforms
        
        Change-Id: I30e56eb11635227616a5cf2dee2c166bdd383498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d9bcf481b40d2a20169a98eb53caf7b19a03f3b8]

        tdf#99528 Use vertical tabs in list style dialog
        
        Change-Id: Ia9bcf82a3966e01fab2181235313c54f6898f0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166862
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Noel Grandin  <noelgrandin@collabora.co.uk>  [49ebf692a0e4a9cbf8b550996589464064d12e54]

        fix jenkins Windows build
        
        after
            commit defc7a92064832423242635d48a7db4440a0b347
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri May 3 09:20:04 2024 +0200
            replace createFromAscii with OUString literals in vcl::pdf::BuildinFont
        
        my local version of Visual Studio seems to have better support
        for constinit than the jenkins one.
        
        Change-Id: If6aec53e8280c5afbd27bf53b7ac0cd1a5e742b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [875a1bf2e132e9083f3cf23b0fc59aeedaf61574]

        makefile simplification: replace $(call gb_UnpackedTarball_get_dir,foo)
        
        …by a simple/static $(gb_UnpackedTarball_workdir)/foo
        see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f
        
        Change-Id: I8e6aa55c85534c4446556548910c950ddbe7c6fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167163
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [971db10d73a0fe80cceca70d19edd02de30be414]

        tdf#99528 Use vertical tabs in Calc draw styles dialog
        
        Change-Id: Idff126955c7b4721a2009febbde6a138bc4af93e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166857
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [76a74ae8a295e5a677a20507a8c855c376c0d23f]

        Lets see if "MSVC '12 'unreferenced formal parameter'" workaround can go now
        
        Change-Id: Iea4cd4ccec178ff32832eb2bf9a6586d6014b89b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167184
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Miklos Vajna  <vmiklos@collabora.com>  [2f79dc2bc2ddf4006646f235f228b61e3f9ffde0]

        Related: tdf#160833 sw DoNotMirrorRtlDrawObjs: add enable/disable option UI
        
        Doing this via a macro was possible already, but that didn't invalidate
        the object positions on the layout, so required a document reload, which
        was ugly.
        
        Change-Id: I65dec046727588952f8e41a89eae25f81feb7f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167182
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [67dc0edb688d345607ae6afe3ad849f143804e28]

        tdf#99528 Use vertical tabs in 'Edit Style' dialog
        
        Change-Id: Ia581c92952d16d71ace8511b502304cdb9014479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166760
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-06  Miklos Vajna  <vmiklos@collabora.com>  [9683305264568d77a1d912f4b0d2e063455feeae]

        svx: prefix members of SdrUndoAction
        
        See tdf#94879 for motivation.
        
        Change-Id: Ieca2f1d0a8b781a908e3b4bd7fd7698305248a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167181
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-06  Julien Nabet  <serval2412@yahoo.fr>  [6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de]

        tdf#150082: LO Base MariaDB/MySQL connector don't accept auth via gssapi...
        
        take 2 + add sspi support for Windows
        
        Thank you Mike for the suggestion and explanation about error I had done on initial commit!
        
        We need to link with Secur32 to have:
        - AcquireCredentialsHandleA
        - __imp__FreeCredentialsHandle
        - _InitializeSecurityContextA
        - __imp__DeleteSecurityContext
        referenced by function _auth_client
        without this, we've got for example on Windows Jenkins:
        mariadb-connector-c.lib(sspi_client.o) : error LNK2019: unresolved external symbol _AcquireCredentialsHandleA@36 referenced in function _auth_client
        
        Change-Id: I138224942f16c0c6a23bb2854ef0ca561e82b061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167057
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d700acbcba68e8b56e22db53bfcdfeb4c5777b9c]

        tdf#99528 Use vertical tabs in Frame dialog
        
        Change-Id: Ie0de985765cd00e376b6e15782fb8ba666af8bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166741
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-06  Justin Luth  <justin.luth@collabora.com>  [7ae84ed99b133cdb4c197ecb43e2454f90b0439a]

        tdf#160814 writerfilter: insert comment after other comments
        
        If multiple comments all have on the same range
        (comment replies typically, but not necessarily)
        then make sure that later replies are not inserted
        in front of the earlier replies.
        
        MSO can anchor their comments anywhere in the document,
        so this is not a perfect, fool-proof solution.
        However, it should handle the typical cases.
        
        make CppunitTest_sw_ooxmlexport21 /
            CPPUNIT_TEST_NAME=testTdf160814_commentOrder
        
        Change-Id: I8ebdae83e4dec25ee34dffc3e84bbd3068a15f57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166765
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fe2ab985d974440265f48c6f70dbf813a760c40]

        replace createFromAscii with OUString literals in SdXMLNumberFormatImport
        
        Change-Id: I17c9bad132b55b120a3b67cdda39d5a603baeae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167154
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [6db3a365772c3874ba212738163869fe057266a1]

        replace createFromAscii with OUString literals in XMLBibliographyField
        
        Change-Id: I17ba2bce9bd94b8054211d4ea689166ad1227ce8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167168
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7dafe7d3b61060b8e9469594c86ed49e55874c78]

        replace createFromAscii with OUString literals in MultiPropertySetHelper
        
        Change-Id: I4b4cef2d7afac3963ab9b3f2fda10d11b754fd00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167165
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c5424629903299c92f27a35bb287bea824fa007]

        replace createFromAscii with OUString literals in XMLSectionExport
        
        Change-Id: Ia9c4c7ad04bb17e24b017bef074e5636f3a960a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167167
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [11bf2d8599bd6262d7d1b24d04bf52440daeb4b1]

        replace createFromAscii with OUString literals in XMLIndexTemplateContext
        
        Change-Id: I9ebc4835c2cc1e525360e89a19514be48b5a77dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7a895ec4205659038aa95941b65715fed1a3e7be]

        Avoid loplugin:noexceptmove failure with recent Clang 19 trunk
        
        > CallExpr 0x7fae572c85e0 '<dependent type>'
        > `-UnresolvedMemberExpr 0x7fae572c8580 '<bound member function type>' lvalue
        >   `-DeclRefExpr 0x7fae572c8560 'WeakReference<reference_type>' lvalue ParmVar 0x7fae572c76d0 'rWeakRef' 'WeakReference<reference_type> &&'
        > In file included from tools/source/ref/ref.cxx:21:
        > include/tools/weakbase.hxx:52:5: error: what's up doc? [loplugin:noexceptmove]
        >    52 |     rWeakRef.reset();
        >       |     ^~~~~~~~~~~~~~~~
        
        Change-Id: I5693fda3c4e5afb02e6229bcb8ea952a62f0e363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167157
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [42794558768d4beb0321271457f675976970241f]

        cid#1596834 Identical code for different branches
        
        which has become detectable since:
        
        commit 7d070fa5e4b055501cc59d3ea1b4e049db4bd4ae
        Date:   Thu May 2 14:51:24 2024 +0200
        
            replace createFromAscii with OUString literals in SwCalc
        
        Change-Id: I589a3db5c0377f1b676daee714ff2ada4ea28179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167160
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8c49dab215ed012fea195ea71cea079ddaa97ba3]

        Avoid loplugin:casttovoid with recent Clang 19 trunk
        
        > In file included from sc/source/core/data/autonamecache.cxx:23:
        > In file included from sc/inc/dociter.hxx:23:
        > In file included from sc/inc/formulagroup.hxx:17:
        > sc/inc/stlalgorithm.hxx:52:9: error: unnecessary cast to void [loplugin:casttovoid]
        >    52 |         (void)p; // avoid bogus MSVC '12 "unreferenced formal parameter" warning
        >       |         ^~~~~~~
        > sc/inc/stlalgorithm.hxx:51:9: note: first consumption is here [loplugin:casttovoid]
        >    51 |         p->~value_type();
        >       |         ^
        
        Change-Id: I14bcc32fcaf3026a9c3c36e522b1e61da15f224f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167158
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-05  Dione Maddern  <dionemaddern@gmail.com>  [c44be10034e66569e1db8f9dc52918caf4f9cb6a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 63b848dba62b3f77c13a091f50ae2a0952152995
          - tdf#159830 - [LOCALHELP] Update Help page on File Properties additions (DUBLIN CORE)
            
            In /text/shared/01/about_meta_tags.xhp
            
            - Added bookmark information to make the page easier to find in the Help index and search function
            - Added instructions for accessing the Description tab to the "How to Get" section.
            - Updated description.
            - Restructured page to improve readability.
            - Added descriptions and DCMI definitions for new elements: Contributor, Coverage, Identifier, Publisher, Relation, Rights, Source, and Type.
            - Added DCMI descriptions for elements: Title and Subject.
            - Added descriptions for "Help", "Reset", "OK", and "Cancel" buttons.
            - Added a "Related Topics" section, including a link to the DCES page on the DCMI website.
            
            In /text/shared/01/about_meta_tags.xhp:
            - Added Variable and Link tags to allow the file to be easily linked from other pages.
            
            Change-Id: Ib0d5226bb0aea6799575709248f0d3004082de47
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167071
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [66916b20818e4fc4a25d711b3860b4096e575a5c]

        cid#1596833 Uninitialized pointer field
        
        Change-Id: I1f05ef494e7e28bd105b7658072c33b2d274a803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167159
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e756c168c28b54a825bdc7481b47be9a89f7e77e]

        use [[noreturn]] for these throw helpers
        
        Change-Id: Ia50d6f2be91e830201689cc428e55203eeb41eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [719c8f44780c2c9c4096c5ea3582fd4b55b095ef]

        replace createFromAscii with OUString literals in OElementImport
        
        Change-Id: Ic6e93f47b903b69f1d8a15fc62be138c13b7b01a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167156
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [4910509d6e780ffc96fc484ffe34b058a5088b11]

        replace createFromAscii with OUString literals in SdXMLNumberStyles
        
        Change-Id: Ice3a35bcaa9ea0005fb97fef5bbcc2c3e2259f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167155
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7d508c60ef15dd867139b2a03cd143327c161480]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5217d34ba89beaa113bb30e4eb76b6c2c0a7ee26
          - tdf#160903 Advanced Filter help page needs description of "criteria" syntax
            
            + refactor
            
            Change-Id: Ib60247386284d9041136dc3cda0f1fef174b2051
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167104
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-05  Arnaud VERSINI  <arnaud.versini@pm.me>  [a123c5b39a4e936121f51c4fc705f5652db3a700]

        basic : use more OUString literals
        
        Change-Id: I38f57c64c0d110e892982eaed2619c0915fe93b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166825
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-05-05  Arnaud VERSINI  <arnaud.versini@pm.me>  [7ab8d335226a74b864dc61775050b2fbddfaa18a]

        basic : use std::u16string_view and new OUString literal
        
        Change-Id: Id3cd708b98e1b0551955562afe3ac594bdc6e50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [864d0f0d8da33f6f5c0a99ae54a52c0172449901]

        always check return of SfxViewShell::Current()
        
        Change-Id: If8f50536295a44a4a8cf692d758ca03e726902e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b50d8183c63b61dc0c5ba4b202171ff2139a57a]

        replace createFromAscii with OUString literals in uui
        
        Change-Id: I5a1694015603a7ef8a421c0349cfe4319cc4e9fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167150
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [defc7a92064832423242635d48a7db4440a0b347]

        replace createFromAscii with OUString literals in vcl::pdf::BuildinFont
        
        Change-Id: Ia5bf95a5474363e745517edce96a123764dcab73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167151
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [219cd2e88a0dd33de49b63d8d5ea0868183c1300]

        replace createFromAscii with OUString literals in EnhancedCustomShapeToken
        
        Change-Id: I1d7f6a22891b40c540cff0cee4150c95e52ba728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167152
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [29c32b847ebc1eabb33523d7f153b30520c60468]

        replace createFromAscii with OUString literals in SvtSearchOptions_Impl
        
        Change-Id: I3bb07f03f5832dc77df9d186fd254b17e2e11cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [67d9ef519b4480e630ec4de5edd1e77d5809a45e]

        replace createFromAscii with OUString literals in SvtLinguConfigItem
        
        Change-Id: I5afccd4103aeb54bb6fd6f0084480dd19ab5ccf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167135
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [be9f2bdfb74e6a3917752cf462160e100457ca28]

        replace createFromAscii with OUString literals in SvtUserOptions
        
        Change-Id: I472c132513622a8b2064ea78ef38161804b1f5ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [76e6c60b67351095bf8756c374ec7ced77696376]

        replace createFromAscii with OUString literals in SvtPathOptions_Impl
        
        Change-Id: I1740e4be5ea2295cdf89fd5771d2902c620af301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-05  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [fc2f2568786cad0c96a8a940a715de595e8bf3c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d4e6c5745193e2a265e6561dbc25151763d61f5
          - I submitted the previous commit too fast
            
            Change-Id: Idcb9537cea90ef446106267d0b16253324e043ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167149
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-05  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [eb69348c01adec2cf61841cd548c7f326cbd317b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f7fe2d5bccd61491145bf1067a85e70b9ecdc7a
          - “Content” is an uncountable noun…
            
            One just usually uses it in the plural as a truncation of “table of contents”.
            
            Change-Id: Ie5c4f4953e4da9441daac068a6e8e411c70aa98a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167148
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-05-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [21e0a2658a565b5359703670ad9a709b232a4a27]

        crashtesting: assert with stroke width of 4.86057e+93
        
        on import attempt of moz1322643-3.svg
        
        Change-Id: I5f18601767212c1eb7453aacbad076099a2a5b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e55074b33b1e3a2f630b74ae5de03a748b1624cd]

        replace createFromAscii with OUString literals in ucbhelper
        
        Change-Id: Ia8b0afb56e715798d4d43d662126cc3cedb66387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167127
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19e1e6185bafc665b3f1ebe0775153a4c71ae84c]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I95bc5dae73f6e9a0ae54b1570df51d6d37062695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a401e72370133403f81492c31bdc45bddaba6d49]

        ofz#68504 Integer-overflow
        
        Change-Id: I38a5f6550e57875cea3d667a650e165b9d606fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167131
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [84811847cf104a236ad505b2ce262e0b30bbaca3]

        ofz#68612 Integer-overflow
        
        Change-Id: Ie68a11300f7d2c3667a1d5702cad8e78e6a6c35a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167130
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noelgrandin@collabora.co.uk>  [02ce80ca2d69296dcbf799dc49302bf071887a25]

        fix Windows build
        
        probably since
            commit 51f3916a102c3a3c16dd84310aadfa3c935e516b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 2 14:39:14 2024 +0200
            replace createFromAscii with OUString literals in SwFormat
        
        Change-Id: I0d1c7498cd646931db511b197cfc4f694107d521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [293ef452f2f0f398bea5f422a4dcff777d768e0b]

        replace createFromAscii with OUString literals in GlobalEventConfig_Impl
        
        Change-Id: Ib74e96b93683f3bfe613ae09f49a6d4158810df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f221ccd6dc5340038daa024bb4384b0a3f8e7259]

        replace createFromAscii with OUString literals in toolkit
        
        Change-Id: I039ee0068cdd8640678524079dd60540abbf876c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167126
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9cc4575c6b3f25c971fc2d8c82f8254e744eea0]

        replace createFromAscii with OUString literals in OAccessibleControlContext
        
        Change-Id: I48c3dcff57beef905f1d72cef871e284de2da22a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Jim Raykowski  <raykowj@gmail.com>  [3a394f3f8a15623e2ffb9fbcad81bbb3b9856abe]

        tdf#160657 Improve Writer Navigator Headings display
        
        when alphabetically sorted
        
        Make the Headings content display flat (no parent-child hierarchy, no
        outline-level indentation) when set to alphabetical sort order.
        
        Change-Id: I0d215c76462fdc2ff1fafcfd8b8d5b15be17b405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166068
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-05-04  Jim Raykowski  <raykowj@gmail.com>  [7938500ad3b384f1f30858cea64e12c84610996d]

        SwNavigator: improve when outline move controls/menu-items are
        
        active/visible
        
        Makes the outline content context menu not show the up/down/promote/
        demote menu items when outline content is set to display by
        alphabetical sort.
        
        With intent to improve code readablility, reworks the
        SwContentTree::Select function used to set the sensitive state of the
        up/down/promote/demote buttons. The buttons are disabled for any of the
        following conditions; the Navigator is in "Zoom" mode, the document is
        in read-only mode, the selected entry is not an outline content entry,
        or the outline content is displayed by alphabetical sort.
        
        The patch also makes the alphabetical sort setting
        independent among the floating and sidebar versions.
        
        Change-Id: I6ff8fab2ce2fb6f68163ed3860b0440fba875fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166067
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6efe3a7a83bf5e110cbe84c225ca4f0a6364a906]

        turn gb_HelpTranslatePartTarget_get_workdir into error
        
        separate commit since that macro is used in helpcontent submodule
        
        Change-Id: I2525b03eadf75b108499701f7f576634619cbf1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167123
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-04  Christian Lohmaier  <cloph@documentfoundation.org>  [a3d55b67b0c44aa135aad6447ba8a03c5aa7936a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5873436e54097facb9c435dc00cef6fc7194b108
          - makefile simplification: replace $(call gb_HelpTranslatePartTarget_get_workdir,foo)
            
            helpcontent2 portion
            
            Change-Id: I2e10bf8bf4cb39fa3a8f9a2c3eb8f22d8632560c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167124
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Tested-by: Jenkins
            
2024-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [52fc9164940a7e778cf4b03a984f7259bd92f9fa]

        makefile simplification: replace $(call gb_HelpTranslatePartTarget_get_workdir,foo)
        
        …by a simple/static $(gb_HelpTranslatePartTarget_workdir)/foo
        see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f
        
        Change-Id: I2525b03eadf75b108499701f7f576634619ccf1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167122
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c8a145afbff81d4c19c2346870eb005c775862b1]

        makefile simplification: replace $(call gb_HelpTarget_get_workdir,foo)
        
        …by a simple/static $(gb_HelpTarget_workdir)/foo
        see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f
        
        Change-Id: Ibe4ce564b021158f3b1800fad96bdeee88792a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167121
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ee5eb3dac8c90a49de88475cf2d0de9d8a93e912]

        makefile simplification: replace $(call gb_Galley_get_workdir,foo)
        
        …by a simple/static $(gb_Gallery_workdir)/foo
        see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f
        
        Change-Id: Iaa2ab218b329a15c7bf2ea528e2612a3a6b44f6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167120
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cdf1f0471233a23fe34d2b9875802559d8157712]

        makefile simplification: replace $(call gb_Extension_get_workdir,foo)
        
        …by a simple/static $(gb_Extension_workdir)/foo
        see also 0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f
        
        Change-Id: Id0184717f2cc30af792266b233eec957b99e7e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167119
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [95dcfa737d6ec4786e1afd33ced064e07976196e]

        replace createFromAscii with OUString literals in RTFSdrImport
        
        Change-Id: I3f49ee652817c778d3888d53f6151e998f689dd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167116
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d13bd5313a2a102f1be2eff439e602e57265febb]

        replace createFromAscii with OUString literals in GridColumn
        
        Change-Id: Icfb1a4f1a4848e95687f8d1e18a77c55343478a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3752d82833f3596208f30429ca9858b9ec22f2ca]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I68acd56b28b0f989a4010cd939f2452970d158ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167103
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [faf1c7ee2acac2d092acd899b68adf1da96f61f2]

        replace createFromAscii with OUString literals in SwToolbarConfigItem
        
        Change-Id: Id1a6f3babc1ca63375361c88b8af40d9915d1d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167112
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ae8de6aeb548d1cb5bbe0071cb2d7e1a279f127]

        replace createFromAscii with OUString literals in SwPrintOptions
        
        Change-Id: I9c40c4e4f58d45e5c3195cab6dbb40c47b0326d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [061d55f8b099adf7ed154df043ffd412bca8f0ed]

        Fix typo
        
        Change-Id: I0db9bdf1d16baf52ad12591634a236e1aeab4e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167115
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [05e3d24602b8df6a476233d0a4e3bef23abc1c72]

        replace createFromAscii with OUString literals in sw
        
        and adjust the loplugin:stringstatic to cope with OUString that
        is also declared in a header as extern, in which case we cannot
        mark it as constexpr.
        
        Change-Id: I108aa3ff8cb06a9a6d345cd951883b52dd0318f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167106
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c053f115512b44838a0a4f21541e7ba54590950]

        replace createFromAscii with OUString literals in SwWW8ImplReader
        
        Change-Id: I505fe025dfbfd64f950d975d0f81527c7efa3d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167107
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0f176b77b47f10fa5e348e471ac6a3980fb8691]

        replace createFromAscii with OUString literals in SwCondCollItem
        
        Change-Id: Iecdaac487a708d268cfa8710db100c3c53386e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167109
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0a33ce1d230757fc8bb10141a1a6d6e33c5a33d]

        replace createFromAscii with OUString literals in SwDocShell
        
        Change-Id: I26b1703f99812d573b7aa1aff9eea3dc9b4361dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noelgrandin@collabora.co.uk>  [b7d3e9ce25643bfb5af3e9e8ab3b80bb021b10ea]

        speedup configmgr::Access on Windows
        
        std::multiset seems to be pretty slow to construct and
        destruct, even if we ~never put anything into these listener
        lists, so rather use o3tl::sorted_vector, which has more
        predictable performance.
        Shaves 10% off startup time for me.
        
        Change-Id: I13afcbe3cb63522e4efe61c64f773e1ffbec9683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167101
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Julien Nabet  <serval2412@yahoo.fr>  [6aa2e8fe2b0b59e2fe20191decb9bd6202dabcc9]

        tdf#160924: SDK: typo SDK_HOME instead of OO_SDK_HOME for linux
        
        Change-Id: I8ec2bc31b19cc6b724a6f7ea3238dda8cf60d4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167111
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8a348300094dcf9d59f94caa75d32453c45c8ee0]

        cid#1596522 Inequality comparison against NULL
        
        Change-Id: Ib489137e8fa2a5745a41703a6d25f9c950223ab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d070fa5e4b055501cc59d3ea1b4e049db4bd4ae]

        replace createFromAscii with OUString literals in SwCalc
        
        Change-Id: I9da38ff8897eeeebdb7d5ff2766414d3d406d53f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5398610203cfb4491de680273cb900eda1a5437]

        replace createFromAscii with OUString literals in SwHTMLWriter
        
        Change-Id: I5dbcab60a9891fe1b42867d7a15f85fd50fe963a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167095
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [da5cad1018e860b2aab773021339483e3df8ed2e]

        replace createFromAscii with OUString literals in SwFilterOptions
        
        Change-Id: Ide9c91584aaee5493697c010eeb76afbd7818a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167094
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dc6cb3b53f0847ee8ce6fea5e671fc580af8cb2]

        replace createFromAscii with OUString literals in SwTOXPara
        
        Change-Id: Ib72bcb5713f3598ff689ef1e767f72f8325828db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167093
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [980fb234ca9c380e1560b07a43f16abbcbeb7a8f]

        replace createFromAscii with OUString literals in svx
        
        Change-Id: Ifefa5d3c26e49e29e476a4faba704ba9b2c7e7e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [51f3916a102c3a3c16dd84310aadfa3c935e516b]

        replace createFromAscii with OUString literals in SwFormat
        
        Change-Id: I53ec6e3914ef995a4fd708ea0f1c2976673d97d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b8d8e4476fd5d640126cad39e70c68763c48f37]

        replace createFromAscii with OUString literals in SwAuthorityField
        
        Change-Id: Ifcbdd1bbab68e177e11a7e48cb1ed2eb2f2b53a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167069
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [85c116f590f1455a6204ee9fbbf7da9fd855f001]

        replace createFromAscii with OUString literals in svx
        
        Change-Id: I9bb7884048f3cc7ef795f7a79dc566fc8fe77e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167063
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [544bc99ba834263a6800c05bbd08df3cca3a6e1a]

        replace createFromAscii with OUString literals in svx
        
        Change-Id: I9d3b6b99ea5ca9f6d17729ae55cd4c3bad75ada1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [4d0987564c33bbccc9b58e041d106c6caf7686a3]

        tdf#152906: use correct Y offset
        
        GetEditCursor now returns the position relative to the line, not
        to the whole text. In ImpEditEngine::CreateLines, its use wasn't
        fixed, and so the Y position of all lines in the calculation was
        the same, thus adjusting to the same contour's horizontal stripe.
        
        Change-Id: I16362bab47f3064281eefb45a12834d836a8ada3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167042
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [740353bc31583d9e8ad77a2b2289a204466ccf9e]

        loplugin:ostr in basctl
        
        Change-Id: I59c25d52d8f59ff1b7ab498041c2888b8e718f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [86d2d8e03763e97a067b1dca8cb8d9829064abdc]

        try to work around clang compiler crash on macos
        
        clang::CodeGen::CodeGenFunction::EmitAggregateStore(llvm::Value*,
        clang::CodeGen::Address, bool)
        (anonymous
        namespace)::AggExprEmitter::VisitConstantExpr(clang::ConstantExpr*)
        (anonymous namespace)::AggExprEmitter::VisitCastExpr(clang::CastExpr*)
        clang::CodeGen::CodeGenFunction::EmitAggExpr(clang::Expr const*,
        clang::CodeGen::AggValueSlot)
        clang::CodeGen::CodeGenFunction::EmitIgnoredExpr(clang::Expr const*)
        clang::CodeGen::CodeGenFunction::EmitStmt(clang::Stmt const*,
        llvm::ArrayRef<clang::Attr const*>)
        clang::CodeGen::CodeGenFunction::EmitCompoundStmtWithoutScope(clang::CompoundStmt
        const&, bool, clang::CodeGen::AggValueSlot)
        clang::CodeGen::CodeGenFunction::GenerateCode(clang::GlobalDecl,
        llvm::Function*, clang::CodeGen::CGFunctionInfo const&)
        clang::CodeGen::CodeGenModule::EmitGlobalFunctionDefinition(clang::GlobalDecl,
        llvm::GlobalValue*)
        
        Change-Id: I96ef1d95a46542d2dfa85f5c6dbfa2ec05b41302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e475901ac053215f031cec8a0ef1ceeac30d7551]

        replace createFromAscii with OUString literals in svx
        
        Change-Id: I7977276b14b44c6ee0ce71d9573bd33d4cc5cbae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167047
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc6e54736f489ec44840276e2a88b343f76352a4]

        replace createFromAscii with OUString literals in svtools
        
        Change-Id: I51eb85b7beb850044d9e092989b7d34994588551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167046
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-03  Justin Luth  <justin.luth@collabora.com>  [da86bfd89e529e787da0bbb3e3150c1f5d4e0dfd]

        tdf#160349: add .uno:ChangeTheme to notebookbar to toggle dark mode
        
        A temporary (ugly, but appropriate) icon has been assigned.
        
        The toggle can be customize-assigned to keyboard, menu, and toolbar,
        and can be found by searching for "Dark Mode".
        
        In the menu, it is checked when in Dark mode,
        and in the toolbar it is "depressed" or highlighted as active.
        
        Dark mode has been added to the view tab of notebookbar.ui.
        I added it as NOT VISIBLE, for several reasons.
        - dark mode is rather new and not so stable, so don't over-promote it.
        - notebookbars cannot be infinitely customized by the end user,
          so developers have to add all items. Users only enable or disable.
        - toggling dark mode really ought to be done at the OS level,
          and typically should be a one-time setting,
          therefore not appropriate to waste precious toolbar space.
        
        The primary benefit of making it available in the menu
        is for QA testers who want to easily switch back and forth.
        WARNING: by customizing the notebookbar, you prevent seeing
        any future NBB changes made to the program
        (until you reset to defaults or blow away the user profile).
        
        Dark Mode can easily be added to a menu, toolbar or keyboard shortcut
        by the end user, so I didn't bother adding it anywhere else.
        
        To avoid completely cluttering up this commit,
        I only added Dark mode to the main notebookbar.
        Once this commit has been finalized,
        the other writer-apps and notebookbars can
        also gain this command.
        
        Change-Id: Ia7594ad81e305ead922abd0ad7b41d6fc0413053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166781
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-05-03  Miklos Vajna  <vmiklos@collabora.com>  [9d95eb980ef12678f6fb978badcbe1cacbe0c4dc]

        Related: tdf#160833 teach DOC export about DoNotMirrorRtlDrawObjs
        
        See
        <https://gerrit.libreoffice.org/c/core/+/167033/1#message-e1df9bf60b7b8b2acdf0c062484ddc572939a3d9>,
        no need to undo the import-time mapping in case we know that the
        mirroring is avoided at a layout level.
        
        Change-Id: Idbdc10ad327540dc5045e9b19dd42160b5139470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167049
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [83c2ef7c78d1453cc0419fd27a8c1418f90c12a3]

        turn gb_CustomTarget_get_workdir into error and remove old _repo_targets
        
        separate commit since help submodule also uses the macro.
        
        actually turn it into make error to prevent reintroducing it
        
        the repo_target ones are from way back when the whole repo was
        split up in many different ones and not used for many years,
        no point in having those as errors
        
        Change-Id: I9fd42529d08ea7859b33f8570936f06039cfa184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167006
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-03  Christian Lohmaier  <cloph@documentfoundation.org>  [9c4e0578eead433de2b38f2a464b402c09432ecd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e8b21ab244345cea0a1d0b9190a8729ff3ea47b1
          - makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)
            
            helpcontent2 portion
            
            Change-Id: I2e10bf8bf4cb39fa3a8f9a2c3eb8f22d8636560c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167007
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-05-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0c4c84a14b01c71c76a9c45a7f26aec4d64f3e4f]

        makefile simplification: replace $(call gb_CustomTarget_get_workdir,foo)
        
        …by a simple/static $(gb_CustomTarget_workdir)/foo
        
        The build system has a lot of overly complicated leftovers from when it
        was introduced and had not only deal with split repositories but also
        had to coexist with another buildsystem. Along with lots of copy'n'paste
        along the years the makefiles became hard to grasp for newcomers with
        all our calls and evals.
        As a first step to streamline that, the macros from TargetLocations that
        simply prefix a static path to the argument (and similar of the same
        kind) are a natural pick before simplifying the rules themselves/getting
        rid of a bunch of eval statements.
        
        Change-Id: Ia06dbbcd5d1994755a2ff05b84f72ccbc4e3cab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167005
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d19b79e4b4998eddd1baa1ab6a42c4f557889a60]

        replace createFromAscii with OUString literals in sfx2
        
        Change-Id: Ifc60fc260149106f257bf10551f081ce7d8fd6ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167039
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Moritz Duge  <moritz.duge@allotropia.de>  [3bb9b0565abef14575d1075e7d33ffcc19d51bfd]

        fix crash in CertificateChooser for GPG
        
        mvUserData is still needed to keep it's content from being deleted.
        
        Revert "Drop unused instance variable."
        
        This reverts commit 687ae6ca01177a04f9ea715a1f1cd70f385a0840.
        
        Change-Id: I689cfdaf8d4d62a3b53ff7fb318dc8c70b9e1c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167020
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2024-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [510e6224951ef492d8d957a8894044276dd8b9c9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5d56e1d29b65749978ae5e9801531200477761b
          - tdf#150760 Missing link for Column Width in Base.
            
            + refactor
            
            Change-Id: I30052dc59c9ec6de6f398b9052739b64396be3a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166878
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-05-03  Pierre  <prrvchr@gmail.com>  [548fc442f56d9b456e48246caaffe13d996c841f]

        tdf#160375 Base displays and gives the full name of the table
        
        Change-Id: Icc8c6d85cc5a88461b7bd02487513e0e864bacef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166057
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1425cbc50a9183477a12e413a0519867c0a589fa]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I8a15be14850b9fe48f80820f4308c35748497727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [23d5c8ed000adc4d66f24ddd67b73a8e5c8a0511]

        replace createFromAscii with OUString literals in framework
        
        Change-Id: I925d79877d477e6273e0ca8d8de7af391d72bb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167038
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Miklos Vajna  <vmiklos@collabora.com>  [0f410680461d7ba5f70dd65b2a8263dec15ac357]

        tdf#160833 sw DoNotMirrorRtlDrawObjs: add UI in cui/
        
        The UI code at lcl_ChangeResIdToVerticalOrRTL() was aware that
        SwAnchoredObjectPosition::CalcRelPosX() mirrors the position when the
        anchor paragraph is RTL, so swapped the "from left" label to a "from
        right" label.
        
        Don't do this when the compat option is enabled, so not only we render
        correctly but the UI now correctly explains why we came up with the
        correct position.
        
        Change-Id: I479ed1f085b249d10be47b66d7a656dc1bd4f936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167031
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-03  Julien Nabet  <serval2412@yahoo.fr>  [62b08851dd7866c830124b30d5722b9541cb2d93]

        Related tdf#150082: remove duplicate gssapi_client/gssapi_errmsg
        
        Change-Id: I38be66163320c1408f5bbb846727994c92e3c246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167036
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-03  Pierre  <prrvchr@gmail.com>  [334585be92eac832e56944b773436bdbefd58adf]

        tdf#160423 Base handle zoned time type correctly
        
        Change-Id: Ib1b8f82295e861edb09e2f87deccc5b0edf8b296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165560
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-05-03  Jonathan Clark  <jonathan@libreoffice.org>  [14c6cde779d64596eab0f4d3f32f181ce2243929]

        tdf#49885 Updated CJK BreakIterator to use ICU
        
        Previously, the CJK BreakIterator used custom dictionaries for Chinese
        and Japanese. This change removes these custom dictionaries in favor of
        the upstream ICU implementation, which uses an externally-maintained
        frequency dictionary for these languages.
        
        This change also removes support code for dictionary-based break
        iterators, as it is no longer used.
        
        Change-Id: I55c4ce9c842d1751997309fd7446e0a6917915dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166136
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d75a37a5829dfcb915f7190d4453c4d4fa25e579]

        tdf#155651: Add support for "context-stroke"
        
        Change-Id: Ib4f4a7b644d0d6c6b36e31b80fd7adc18999110d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167024
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [2aa310cfe0bc10e7bf079147d379f6eb7d061b74]

        tdf#160915: make own OLE objects obey AddReplacementImages setting
        
        Change-Id: I25ce3c920dc8ba25d0ac14310ff9cba8a4c23c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167026
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [9490972c04b79065f247b3076a7c53c9ec4fad67]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0ca7301c3c00d6e7936fd912ba775d0008f7fee4
          - upgrade Ukrainian dictionaries to 6.4.4
            
            Change-Id: Idf246940bdf58844212420975ab52c19b08327ec
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872
            Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            Reviewed-by: Andriy Rysin <arysin@gmail.com>
            
2024-05-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9d84957863d274501fe130319d972a3fc2572503]

        Simplify condition
        
        ...after this got wrapped in an outer
        
        > ifeq ($(OS),EMSCRIPTEN)
        
        in cf0b0f0dd04fae98b686cd5768673c217a58fab6 "Emscripten: Only add the --pre-js
        code to the soffice executable"
        
        Change-Id: Ic2b9ae7709a06146a206ebaa2ee8881387dae6b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166998
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-03  Julien Nabet  <serval2412@yahoo.fr>  [68008d9f0176c43ecc768af8e3539227640d1519]

        tdf#160916: typo "Checbox"
        
        Change-Id: Ia06bc947cd1788850251b1386977ef0229dddd8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167030
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-05-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8662a96c90b56f61bf24380094f217e7170f54be]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I9b2b86c26e08221c57735c6eda88727aa8a46b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167021
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3cc6384e41819eb8a5182a9ab7fd8f74d3cea9e5]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ibca9433761e7a7f97383991429cf0d575b4ba3d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167018
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-03  Noel Grandin  <noelgrandin@collabora.co.uk>  [5edaca5c892dbe07c0edb1ea0de4a115300e8ef0]

        use boost::small_vector in cppuhelper
        
        shaves 5% off startup time
        
        Change-Id: I901e1112727eb7a50f70d1853386e0696fee7e5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167000
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-03  Michael Weghorn  <m.weghorn@posteo.de>  [b7ba358d48c1419142f88b8121b848113969eaaf]

        sd, svx: Return new annotation instead of using out param
        
        Let `SdrPage::createAnnotation` et al. return the newly
        created annotation rather than using an out parameter,
        which makes this more straightforward.
        
        Change-Id: Iee0561859756522ef33680c2cc9b492541a31d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167019
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c98269868a63b308d238d14e0c324a5e5d26dde]

        replace createFromAscii with OUString literals in framework
        
        Change-Id: I4fccbfd57d942f64ce812c8a7e8e373296918af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [cea484870ccab8dd536ed140a8271bc220d407da]

        replace createFromAscii with OUString literals in framework
        
        Change-Id: Id6682230a08a21048879e739a2b1445210181c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167012
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0b159c1bcae78016123379db57b404b202ce692]

        replace createFromAscii with OUString literals in filter
        
        Change-Id: Ia3c4151a80be630d88b15dcb3de10ec4ddcca9d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167008
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-03  Michael Weghorn  <m.weghorn@posteo.de>  [192bda84402bda175d7620319c019747b24de460]

        gtk4 a11y: Align role mapping with upstream GTK
        
        Align the gtk4 a11y role mapping with what upstream
        GTK 4 does with current git main (as of commit
        0064500146fc080dae1ef2b30bebf7bb8b35a52f), see this
        upstream GTK commit [0] and the one it refers to for
        more details:
        
            commit ad8613876c753cea8695dc8b03dcd37eb8e723a5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 30 14:44:11 2024 +0200
        
                a11y atspi: Improve mapping for container roles
        
                GTK_ACCESSIBLE_ROLE_GENERIC is for
                "a nameless container that has no semantic meaning of its own",
                for which AT-SPI role ATSPI_ROLE_PANEL [1]
                ("A generic container that is often used to group
                objects.") fits better than ATSPI_ROLE_FILLER
                ("A object that fills up space in a user interface."),
                so map to this one.
        
                With this in place, widgets like GtkBox are again
                reported with the panel role on AT-SPI level after
                commit a86923de943b6a42ba431be2a336972dca9c587d
                ("a11y: Change the role for many containers"),
                whose commit message suggests that the change
                on the AT-SPI level was unintended.
        
                For GTK_ACCESSIBLE_ROLE_GROUP, use the corresponding
                ATSPI_ROLE_GROUPING ("A group of related widgets.
                This group typically has a label.").
        
                [1] https://docs.gtk.org/atspi2/enum.Role.html
        
        This causes the LO a11y roles `PANEL`, `SPLIT_PANE` and
        `ROOT_PANE` to be mapped to the AT-SPI panel role again.
        
        With the above-mentioned GTK upstream change, the native
        GTK widgets now also use the panel role without having
        to explicitly set anything on LO side rather than being
        fillers, which removes the need to set them explicitly,
        see the full commit message of
        
            commit f6ca163d3f6383d3a48dbdacc5410e630d678ea1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 26 12:43:24 2024 +0200
        
                gtk4 a11y: Don't create second AT context for OOoFixed
        
        for more details.
        
        Also, map the LO `FILLER` role to `GTK_ACCESSIBLE_ROLE_WIDGET`
        which GTK maps to the AT-SPI filler role.
        (The previously used `GTK_ACCESSIBLE_ROLE_GENERIC`
        is now mapped to the AT-SPI panel role,  which
        is for widget containers rather than fillers.)
        
        [0] https://gitlab.gnome.org/GNOME/gtk/-/commit/ad8613876c753cea8695dc8b03dcd37eb8e723a5
        
        Change-Id: I1d1a8f626911455481d2d722790e8915daa921c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166995
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-05-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6f7acc14866136f22d26cae1e8656d8719b58300]

        jsdialog: support for LinkButton as an independent widget
        
        This adds support for the (weld)LinkButton (FixedHyperlink) as an
        independent widget and not part of FixedText to jsdialog. In addition
        add "click" event that triggers activate_link method.
        
        Change-Id: Id110b4a0fd60fc24592e00235243783d46ae4575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166898
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [3f2d56d486da2006e24444cfa6f2f63700a14fae]

        tdf#160901: partially revert 8557ea84c9336ba8061246f1f46ddb6e02f413a1
        
        It turns out, that the horizontal scale is needed in the applied transform.
        
        Change-Id: Ic07e015f0ddeee3d66653b683d83435d04b9ab81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167004
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f4726c45e69a1582a91ea359434625db86868b2]

        replace createFromAscii with OUString literals in forms
        
        Change-Id: I688fbf8777736a3f55ab5c0d9c8acaf55f83d8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167009
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-05-02  Julien Nabet  <serval2412@yahoo.fr>  [e783a1c09093f3dbaf778661b77a2d5872a2029d]

        Extend silence strange -Wclobbered with GCC <= 14
        
        See 2bcd9fe0fa10339294e6ab820498fa18334e02f3
        Silence strange -Wclobbered with recent GCC 14
        
        Change-Id: Id51659cb8cd49b65c55b22ed0ac515a8ab609602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166994
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [01f19161e9a8e957028d5378e48929e82fed159c]

        CppunitTest_sw_uiwriter4: remove unneded Scheduler::ProcessEventsToIdle()
        
        Added with 17b2f3d96fb21dcfc2fb8e54ca9670a8c58840f1
        "tdf#143320, tdf#143387: sw_uiwriter4: Add unittest"
        
        Change-Id: I13dc9a540a37edf9e089df5af14342bc9032ee02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166999
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [091c67183248ecef9e23e2f8726e816d81dfb4ff]

        replace createFromAscii with OUString literals in framework
        
        Change-Id: I5209ab1b869492234946f8471a30c70121824198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167010
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [694f63d27fdd915239ec5f1d4cccd9b85bfff787]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 92ee035a864bdd5691a589704a0b8cb609f2b0bb
          - tdf#159872 Help page for SEQUENCE Calc function.
            
            Change-Id: I76444cccc90320b2c774298f058c263fa30af51e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166987
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [d4c0e39d93f3038a18cba975c25bb42aa125166c]

        make the slot data constinit
        
        because it takes a surprising amount of time to initialise it
        at runtime during startup
        
        (*) have to convert the std::function in SfxType to a
        function pointer, because the std::function constructor
        is not constinit compatible.
        
        (*) the SfxType0..SfxTypeN types need some reinterpret_cast
        to work around the lack of zero-sized trailing arrays in c++
        
        (*) Sadly MSVC does not support taking the address of symbols
        in constinit structures, so we cannot make the SfxSlot
        array constinit.
        
        Change-Id: I300ee770cc115d30bc25c819f2ad34b29633876c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166963
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b26ff81a6f8f5ad99bba153cf57bef68fd03930d]

        use [[noreturn]] instead of asserts that badUsage exits
        
        Change-Id: I927434290b02b6cc0386b1e0038cd8385a762249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166996
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [62172db2d71fdc49a3ad9c177b8635353b90a7eb]

        tdf#99528 Use vertical tabs in character style dialog
        
        Change-Id: If6ae98f7d1ca1e92e38b1a277b528fa436791174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166860
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-02  Miklos Vajna  <vmiklos@collabora.com>  [01dcc9a652ecfc65fb674b492afa6f58b0a846db]

        tdf#160833 DOCX import: use the DoNotMirrorRtlDrawObjs compat flag
        
        The bugdoc has a shape which should be on the right page margin, but it
        was on the left page margin.
        
        Use the new compat flag to have a layout that matches Word.
        
        This way we don't need to unmap the tweaked position at export time (a
        limitation that the DOC filter has).
        
        Change-Id: I38dfae370f275d9f0897198e7b0569f2d91dd352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166993
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-05-02  Miklos Vajna  <vmiklos@collabora.com>  [ceaba8bf5903b454ff717d788d2298edbf92bac2]

        CppunitTest_sw_rtfexport5: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I33d84275106ee3ff8a2f3356ae0c1c84d387cfd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166992
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-05-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [951562bc555a6011b39f3c5c02a784d541f01224]

        Save with newer Glade version
        
        Change-Id: Id4d172ebb5265e418b9b3c8bea0a4dacf2ae27cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166745
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-02  Arnaud VERSINI  <arnaud.versini@pm.me>  [7b8ef7cf923c5dfbc54871e88b780ddaeb9436c5]

        i18npoool : use rtl::isAsciiDigit instead of local isnumber
        
        Change-Id: I1e9df1b048169767e649fc825f7a49dac16c040f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [fc7f8714956cb37f9243df21e57a079d057e46c6]

        elide temporary OString in uui
        
        Change-Id: I6510d930b13ee019d1a67810b02a5157834c7c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Printf Debugging  <printfdebugging@gmail.com>  [09e135ab80fffc10950a16716111d66d9ed99f5f]

        tdf#160780 Overlays should not cover EditView.
        
        ScGridWindow::DrawContent(...) draws the spreadsheet elements.
        ScTabView::SetNewVisArea() is called after DrawContent(...)
        which calls UpdateAllOverlays(), and the overlays hide the EditView.
        Redrawing EditView in SetNewVisArea() fixes the issue.
        
        Change-Id: I768c8b7a1c9306fb94e82bca74ce0dcb2ced2782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166784
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [41590e7d1f8ee67c7d5c29c89a9b246c8c8f0f05]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I8edb1fefe1b2b8a3db3ee8f3a0eed59c7f08a36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166863
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [caf719c59c6dc8db2b6a0eab8d47760277f112a3]

        always check return of SfxViewFrame::Current()
        
        Change-Id: If35fe03c775aec12ec534d02d58596aebcec764f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166985
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [50419ba81149c064ac41c74afdb72d9c39e8be72]

        cid#1596704 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I52867ef0a094e546a307b98089c259f9e8bbdabf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166984
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-02  Mike Kaganski  <mike.kaganski@collabora.com>  [0d82ddb39e0cdbfde428eb4da7268cac4176f1bd]

        tdf#160898: check for nullptr
        
        Regression after commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda
        (tdf#154877 sw: generalise ExtendedSelectAll(), 2023-05-09)
        
        Change-Id: I9289171647fca8bd1b696399ff7c43a2ac7b8b30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166990
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-02  Moritz Duge  <moritz.duge@allotropia.de>  [687ae6ca01177a04f9ea715a1f1cd70f385a0840]

        Drop unused instance variable.
        
        Change-Id: Iee32e4348526e54e0cc45a54e55eddb6479248e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166968
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7e553a56c6a5aa7f4b1f01df52ed9607d3397cfc]

        Save with newer Glade version
        
        Change-Id: Ib1380e4771bbeeaebece1bb5bae0617e588ec378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166747
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [412f1e769988a1bb5dbe5355dc9d3b8a7d28cdd7]

        Save with newer Glade version
        
        Change-Id: I1bd6864230b26e9e32c7c509a91666e8f679cd76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166759
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-05-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9ec6bfb598f39ebdb3e6698b5411ace951a53a8d]

        Save with newer Glade version
        
        Change-Id: I0b3c4d263cef98ae9b28b863e25def3819ca9186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166772
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [764f944d55cd21cb9ace6b51e8e173b7a4acd21d]

        use more OUString in XPropertyList
        
        Change-Id: I775f75c2e56bff36d6de8ddb298d30ffd93a7da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166976
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [df22951b34010e47074bab24ba9ac27c2773d204]

        use more OUString compile time literals in xmloff
        
        Change-Id: Iddf9d40ca63f2f3ce7d48aaf881a3abb10f88bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166975
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [656f66b4bdefdcbeee05cba6f1fffb4fadc9319d]

        use more OUString in StarSymbolToMSMultiFontImpl
        
        Change-Id: I995e74653196d0715559127341fdf91a0d68c253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166977
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [6c4760f89cf28688497414946457c04253a845be]

        use more OUString literal in getBasicTypeName
        
        Change-Id: I6e307e4387cbecac6391000b9ca7e632b2152b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166979
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [7b7f1c3880c05eb9c2ee941b70025bac0a6decda]

        workaround compiler crash on macos
        
        affects x86 and clang-13, crash looks like
        
        1   llvm::APInt::APInt(unsigned int, llvm::ArrayRef<unsigned long long>) + 112
        2   (anonymous namespace)::StmtPrinter::VisitUserDefinedLiteral(clang::UserDefinedLiteral*) + 1019
        3   (anonymous namespace)::StmtPrinter::VisitInitListExpr(clang::InitListExpr*) + 189
        4   clang::Stmt::printPretty(llvm::raw_ostream&, clang::PrinterHelper*, clang::PrintingPolicy const&, unsigned int, llvm::StringRef, clang::ASTContext const*) const + 165
        5   clang::APValue::printPretty(llvm::raw_ostream&, clang::PrintingPolicy const&, clang::QualType, clang::ASTContext const*) const + 3357
        6   (anonymous namespace)::CallStackFrame::describe(llvm::raw_ostream&) + 569
        7   clang::interp::State::addCallStack(unsigned int) + 388
        8   clang::interp::State::diag(clang::SourceLocation, unsigned int, unsigned int, bool) + 277
        9   CheckConstexprFunction((anonymous namespace)::EvalInfo&, clang::SourceLocation, clang::FunctionDe
            cl const*, clang::FunctionDecl const*, clang::Stmt const*) + 282
        
        Change-Id: I24a111f064fc17e289a4a6c8e7a40c776fa71e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166986
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [df8dd90f143e650cff12e775f46a32eb3cf8806c]

        elide some OUString creation in GetContentPart
        
        Change-Id: I2a9a8e7713cb4efbc7bf3401cbbe31640098cb1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166980
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a3d758d528d3408fcccd7d3673439b5d68347e30]

        Prepare to run (select) tests during Emscripten build
        
        ...by e.g. executing generated Wasm code with node.  This requires check targets
        to not be skipped unconditionally, unlike for other CROSS_COMPILING builds, so
        introduce gb_CAN_EXECUTE_HOST_CODE to distinguish these cases.
        
        Which revealed that some CppunitTest targets unconditionally used artefacts that
        are covered by some ENABLE_WASM_STRIP_*, so made those uses conditional
        accordingly (even though the resulting binaries might actually be dysfunctional,
        lacking relevant parts; we'll fix that if and when we actually build and run
        them).
        
        Change-Id: I7144eeb908ede25358a3c8186198ac532de4d9f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166931
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-05-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [79b1a61303af8dc8716c03151b28bfce13162eb0]

        jsdialog: fix updating on container "reorder_child" or "move"
        
        The accessibility checker sidebar did not update properly when
        new issues were added or were removed. The accessiblity checker
        is adding and removing new widget parts (one for each new issues)
        to the grids, which is using "reorder_child" and "move" methods.
        If we call "reorder_child" with update, it fails in online as it
        doesn't find the parent "box" ("box_document" for example) because
        the id is not set properly. Doing a full update on "reorder_child"
        fixes the updating problem.
        
        Change-Id: Ia3032516a7cee0271f8b05b22e13dde2b7430e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166962
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-05-02  Aron Budea  <aron.budea@collabora.com>  [2a5fc2a414517bfcef164f527ef7ab1658fcef5d]

        tdf#148616 Speed up finding custom shape guide value
        
        Use a lookup hash map instead of linear search
        
        Change-Id: I54c9509740d90ca3f7479dfc16a6aeffd82a405d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-05-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9b41d33a00763bebd5fc70787052222d35a98a52]

        sw: simplify widgets in A11yCheckIssuesPanel
        
        Change-Id: Iee8db2953c5836f7dee667dadab9441f73706d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166961
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [e8fdc8a4ff60a392f51326e90212fc73d515e270]

        elide some OUString temporaries
        
        Change-Id: I8364489639c8c02e9670ee597f48d61007244f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166973
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Noel Grandin  <noelgrandin@gmail.com>  [e8d1eec3e5cf08ca7de692f7d212b831db66ab96]

        use more OUString literals in XMLEvent
        
        Change-Id: I77f9b7fc731be3c3f7cd0c642f9b210e28fdf545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [792a4768e1765b6d1f78d8bd5ca9b2a5abfd0a13]

        cid#1596705 Unused value
        
        Change-Id: Ie5bfe55fd964c05f80d3400a66aa79886f3c144b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166983
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bea8576e8218cc8fee7966877d7412377e70e204]

        cid#1596706 Dereference after null check
        
        Change-Id: If7156d9b0aaa392ff0c1e98dfdd4d05c6dcaabce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166982
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ff79a22fd04f9bbb5f4f67f21862db3a531de833]

        cid#1596707 Unchecked dynamic_cast
        
        Change-Id: I2067f335dfacf2dfb4b5b18b54c738f3fba4c375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166981
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Balazs Varga  <balazs.varga.extern@allotropia.de>  [85f733a9242339d8e92f992ff1ad6d1b99d3f383]

        Related: tdf#160725 - Add horizontal binary search mode for SortedCache
        
        and ScSortedRangeCache classes to support binary search mode in case of
        different columns. Which is used by the new XLOOKUP function from now on
        in case of binary search mode.
        
        Change-Id: Ibb2ae33670cbe9b47110de57afb6376cd829b465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166758
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-05-01  Noel Grandin  <noelgrandin@gmail.com>  [b265b547b9e09893187aab0aa1085ba51c43563b]

        use more OUString in sfx slots
        
        Change-Id: I900d9f1d35bc1e620822eedd5722a502704d6de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166959
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-01  Noel Grandin  <noelgrandin@gmail.com>  [82bf36179ba8369ca026ef3cf400e216255941f1]

        simplify and reduce OUString allocation in UnoControl
        
        Change-Id: I276d0b8b1d3fde8aab6be15cb2477ce0c6d175c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166957
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-01  Julien Nabet  <serval2412@yahoo.fr>  [a835b40e05462e9be58cb501aa6b938f3dc998b8]

        Silence some bogus -Werror=array-bounds etc. also with GCC 13 and -std=c++20
        
        See 1c3c27bc2e42f70e588ef5dbc769a8a346042e04
        Silence some bogus -Werror=array-bounds etc. with GCC 12 and -std=c++20
        
        Change-Id: I65675d1f18415ae82afb98c7d388dac3cdc18ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166966
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59fb18bf279446ba8d26faf7bfb03e375e0aac62]

        next is never passed a null pointer, use a reference
        
        Change-Id: I6d57e6a7f746a05017c6f93ef434a234716259c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166965
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Gökay Şatır  <gokaysatir@collabora.com>  [1ac07d2c9d45cc5db3f689d287ad9be939ef1124]

        Use a for loop for setting view properties.
        
        Since there may be no view with the given id, checking the list first is safer.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I4c305e0a0f6ce7cccdfea9889c414a6054ed3a88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166531
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 4d8c4a60105488be84ea80775dc04a24582752fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166720
        Tested-by: Jenkins

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7790878e315f795f5d9965dd9997ba3a5004c60]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I9870360076260e71c0e02375558606cbdb68fc08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166960
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ead19f4c62c8d74292a7ba589df2ca118cea3240]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ic2231df89b900c17beac4627e3573b45aef0bc26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1d95bd8e5fcdcc241f4c945a4f01486df8e61f88]

        call SfxViewShell::Current() just once
        
        Change-Id: I8a4770d5018b3f3c4a4eb43763a211cfb636d7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166953
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [867eee280bd968b9d6ca7d6a7b0d88ab1dc0d73a]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I5a4d2982b5d980704dfc19fd92d01fd8aeefe144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166952
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Szymon Kłos  <szymon.klos@collabora.com>  [ced78dc7abf534edd2eacee4af01c35c4360b9f0]

        Remove commented code
        
        Added it by mistake in commit c1c32bbbe24ebd4be00c9c3bb38de1dc748bd2b6
        lok: test number formats with different locale
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I0f7b456d5f41c1faf1f5051aaf0756c90553cf3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166947
        Tested-by: Jenkins

2024-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [96eabc69e9c3c6e9c944a4e83adddea44d48c621]

        tdf#160867: only output first element of the map in ReqIF case
        
        It should be investigated, how the whole image map can be output in
        that case - something to be done separately.
        
        Change-Id: I6543c0d238205fabdb0a688e32a2d08423d7a5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166948
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [e8e5ffe638ad36ca0bb444006c86479b190d6de3]

        Update git submodules
        
        * Update translations from branch 'master'
          to b824b552da5c054dd35568e86266afd1cf539441
          - tdf#151830: Fix RID_SVXSTR_TEXTENCODING_TABLE nb translations
            
            Change-Id: I54cf1c7b471724ece13b2789d31b187b5e080446
            Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/164882
            Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a377a7c5aa7f1ad9aae7d7bc8da4cbf5ba6b6478]

        annot: make TextApi use SdrModel instead of SdDrawDocument
        
        Also it uses SdrOutliner instead of SdOutliner. This change is
        important for moving the implementation to svx, where we don't
        have sd specifics available and it seems in this case they are
        not even needed.
        
        Change-Id: I6c63ba4953bb5281aa951a0048a08fdd2813c530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166495
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d59980dfdad0e1425f6a49507b5f97995481930]

        rearrange PivotTableFormatsImportExport to avoid clang crash
        
        apparently related to lambdas
        
        Change-Id: Iff0f2a411b4651e4902c348ae0dedc573c8512f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166950
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Pranam Lashkari  <lpranam@collabora.com>  [312740f1ef96ef6fe7e83d5fb1f5d2d4b2d2471c]

        LOK: hide cancel button in csv import dialog
        
        it did not make any sense to have cancel button in this dialog
        because it would not load file at all.
        user can still use close button in title bar to close dialog
        
        Change-Id: Id3ba3e4030553db18bdbd068d92b3395f4fb8c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166764
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 290d70a476bab7d100baa3568ec547633109033e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166835
        (cherry picked from commit 7171c9e8f6fecedac29e89deaeb2afa4d67a2a17)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166844
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6981b99ac5447f917287f5102a0a18b4972871e]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ic2c2e227a50994298377485e9e807cd9142cc386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Heiko Tietze  <tietze.heiko@gmail.com>  [358b281a39c6599aa2054a9cf60aa6712e832150]

        Resolves tdf#141778 - Size issues on view options UI
        
        Change-Id: I08ab47d8f88a0bda16e15377921909f64219c4a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166885
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ed3ce7bfeb2a22c17071fd02f61fa2c819a35c89]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I6eb8e490e878349f2063910e0cbc901aa7a6d524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166942
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fdbc8d1374e2a9fde6c99acbe6923a277695a0a3]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: Ie1aff54bbc2d9dad0298636bf680ac7790f70a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe72e20f865baca9387e5d14327c56b2773d760f]

        CopyTo is never passed a null argument
        
        Change-Id: Ie25e61d6795819a9c432d71fdf478b1a4430c06f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166940
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4742808bf277cd33ef95029b987aac904149afd9]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I665bb37e1d45ec87489b039b1d1d41529f027328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166939
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-05-01  Regina Henschel  <rb.henschel@t-online.de>  [f0a2969d15e3101d7f96a7fe77bca06a5d70f57a]

        tdf#160329 update objects after row sort is finished
        
        The problem was that when the object position was updated to the anchor
        values by recalcPos() method, the document did not yet have the new
        state of the hidden rows. As a result, incorrect positions were
        calculated. Therefore, the update of the position is moved to a place
        after the update of the visibility of the rows.
        
        Sorting rows must not change the visibility of objects. However, updating
        the visibility of rows sets all objects to visible. Now the visibility
        state of an object is saved and restored later so that the recalcPos()
        method receives the correct state for the object.
        
        Change-Id: Ia32698c1d45cd81702e6d00c5dfc100f6f6f399c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166799
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed015246b9b27e1ea1f87bc125262850d7128c0f]

        use more concrete UNO classes in writerfilter (SwXStyle)
        
        Change-Id: Ic1eb574efa2e4ce57185670d6570f24d1d8c9bb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [c85c534befc1a68f405fc2ad508ae9363d7ebb91]

        Make pNoteURL thread-local, just in case
        
        Change-Id: I27247a85f0d7497f70c5d97a8955b68a29be1176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166946
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [42876f0a99e2ae7cb7529dd7fb4d94c5e9298b21]

        tdf#160867: export as-char frames' hyperlinks to image map
        
        Change-Id: Idc8d41a27c8ee9cdd12fb5e17a328ec6aa104a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166935
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ce454f382d0d005dd3de021c7820be3ffa0bb582]

        jsdialog: enable a11y checker sidebar
        
        Change-Id: I46f276f16ded08a55b6672d92c39924ec3c4a628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166881
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-05-01  Justin Luth  <jluth@mail.com>  [bc7501d30ab9a3a5edec66d2f0022177f85d6127]

        NFC GraphicImport.cxx: address nit x2
        
        less emphasis on minimizing "if logic"
        and more emphasis on readability
        (especially since the comment comes after the logic).
        
        In the most common cases, this version
        should actually finish sooner too.
        
        I didn't remember doing a copy/paste,
        so the first time I only fixed the one instance...
        
        Change-Id: I71deded7da16fd4aef2d7f5ab9f777b616312eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166379
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-04-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e2c9d38d95a1a0b5cf754fb04f2fd73c6ddb8004]

        tdf#160725 - Fix XLOOKUP has different result for approximate
        
        search than Excel.
        
        Some rework for xlookup binary search in rows to get the correct results
        when we are searching with binary mode in rows.
        
        Change-Id: I7ef710c4ae638e2cf5d4bee45810cec7057f5d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166451
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-30  László Németh  <nemeth@numbertext.org>  [38b6e89c9483fdfe3d26bef3b25f890528aef84e]

        tdf#160836 sw: fix narrow selection area of cell border
        
        Remove ShouldObjectBeSelected() condition to fix the
        selection area around the horizontal border. (Its purpose
        was to avoid of selection of the border, when covered by
        an image: but that would be !ShouldObjectBeSelected(), with
        the same problem: halved selection area.)
        
        Clean-up commit commit 30de13743f144aced83bc43d310592f82788c910
        "tdf#160836 sw: resize rows at images cropped by row height".
        
        Change-Id: I6c812a150b67431c7ea3131f29489bda919c1724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166877
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a2623abe07c5fe369c6b7315ae53de3884750839]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: I498c10e8bc134b41e3606d8a05cf3103a9274735
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [17b2f3d96fb21dcfc2fb8e54ca9670a8c58840f1]

        tdf#143320, tdf#143387: sw_uiwriter4: Add unittest
        
        Change-Id: I45aaa88c8ed70f3eebd30dfcd29edc4e1e4a5694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118908
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [acad40220d21e73b5fb699404ae1a2dc29218faa]

        Fix UBSan failure (part 2)
        
        Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e
        "sw: check GetUserCall"
        
        https: //gerrit.libreoffice.org/c/core/+/166824/comments/8db24a41_2f4e7e4e
        Change-Id: Ib6f981aa3055f0d37d0b83e3284842d310fe6ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166913
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [be543e321552d4331e7dddca954a2b57f4c7f379]

        tdf#159369 tdf#160806 gtk3 a11y: Drop fallback dummy a11y obj
        
        No longer return a dummy AtkObject in
        `wrapper_factory_create_accessible`, but drop the
        implementation of that dummy object completely.
        
        As far as I understand, the code path previously
        creating those dummy objects should never be triggered,
        so add asserts to detect any cases where it does.
        However, gracefully return nullptr for release builds
        for now at least.
        
        This dummy implementation was originally added
        as part of:
        
            commit 62f451cb03d5202e2f15bf440c53a61b2efd99f8
            Date:   Fri May 5 09:54:24 2006 +0000
        
                INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED
                2006/03/31 12:19:39 obr 1.1.2.12: #i63583# eliminated warnings
                2006/03/28 10:49:45 obr 1.1.2.11: #i47890# redid the last patch to make it more clear
                2006/03/23 14:45:26 obr 1.1.2.10: fixed endless loop problem with tooltips
                2006/02/15 10:59:22 obr 1.1.2.9: #i47890# replaced tabs with spaces
                2006/01/05 14:06:31 obr 1.1.2.8: #i47890# override toolkit name and version and reworked bridge initialization
                2005/11/16 12:29:16 obr 1.1.2.7: no longer return NULL in factory_create_accessible
                2005/11/16 09:09:20 obr 1.1.2.6: gail rev. 1.8.6 fixes the things we needed gsignalhook for
                2005/10/20 07:09:09 obr 1.1.2.5: #i47890# made cxx files standalone, avoid queryInterface on each API call and demacrofied try/catch to include appropriate warnings
                2005/09/28 07:24:12 obr 1.1.2.4: #i47890# changed ref-counting/life cycle once again, adjust tree and role of dialogs and filter sub-menu windows
                2005/09/26 11:01:00 obr 1.1.2.3: #i47890# reworked lifecycle of atk wrapper objects
                2005/06/14 13:57:23 obr 1.1.2.2: #i47890# global focus event listening stuff
                2005/04/21 14:59:24 mmeeks 1.1.2.1: Issue number: i#47890#
                Submitted by: mmeeks
        
                Hacked up prototype of atk bridge
        
        Change-Id: Ibdc525412ba6cc4b449c775a74dcd919c4045b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166934
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [252b1591d5e4e3adbf7063b56c2b578fe046ad3d]

        tdf#159369 tdf#160806 tdf#160837 gtk3 a11y: Don't skip parents one way
        
        The gtk3 VCL plugin partly uses native GTK widgets (see
        `GtkSalFrame::InitCommon`), like an OOoFixed, a GtkEventBox
        and a GtkGrid.
        
        Therefore, when descending the a11y hierarchy from top to bottom,
        GTK's a11y implementation for GtkWidget etc. come into play
        for those.
        
        For the OOoFixed, LO provides its own factory to create an
        accessible. That one was skipping some of the widgets to
        determine a parent and create an AtkObject (wrapper) for
        the OOoFixed.
        
        This made the a11y hierarchy inconsistent, as walking the
        tree up from an object should result in the same path
        as descending down from the root node to that child.
        
        Demo in Accerciser, with the root pane selected for
        Writer:
        
        Printing the a11y info for the object with role root pane
        and the object it reports as its parent:
        
            In [24]: acc.name
            Out[24]: 'Untitled 1 — LibreOfficeDev Calc 24.8 [621cfc0e4120ab2b381b54268fe39bd19257df9b]'
            In [25]: acc.role
            Out[25]: <enum ATSPI_ROLE_ROOT_PANE of type Atspi.Role>
            In [26]: acc.parent
            Out[26]: <Atspi.Accessible object at 0x7f4c4e908fc0 (AtspiAccessible at 0x359a3e0)>
            In [27]: acc.parent.name
            Out[27]: 'Untitled 1 — LibreOfficeDev Calc 24.8 [621cfc0e4120ab2b381b54268fe39bd19257df9b]'
            In [28]: acc.parent.role
            Out[28]: <enum ATSPI_ROLE_FRAME of type Atspi.Role>
        
        Then, after selecting the object that is shown as the
        parent in Accerciser's treeview of LO's a11y hierarchy
        shows that this is a different object:
        
            In [29]: acc.name
            Out[29]: ''
            In [30]: acc.role
            Out[30]: <enum ATSPI_ROLE_PANEL of type Atspi.Role>
        
        And it can also be seen directly that that panel's first
        child doesn't report the panel itself as its parent:
        
            In [31]: acc.get_child_at_index(0).parent == acc
            Out[31]: False
        
        No longer skip the widgets but set the widget's direct
        parent as accessible parent as well.
        
        With this in place, the above check worked reliably
        for me when starting Accerciser before starting LO
        and clicking through the LO hierarchy on Wayland no
        longer showed the issue described in tdf#159369 comment 4.
        (When starting LO first and Accerciser afterwards, there
        are still more issues presumably related to events,
        which needs further investigation).
        
        In that scenario, highlighting for the toolbar
        icons in Accerciser (tdf#160838) was also correct.
        
        Calc was behaving similarly in a quick test.
        
        Change-Id: I4c782dc8dcb543e6a0db01c9f887a2716711ea64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166933
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e8f12c44bfe3483f69127f7d5429536249f6c2b]

        loplugin:ostr in accessibility
        
        Change-Id: Iff3e6af9627aa5d31b00ad48bc6c6ea8d3913fe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f19decc2cdf57bd4197f179cfd2f8b2e8805865]

        use more concrete UNO classes in writerfilter (SwXTextDocument)
        
        Change-Id: If07817eb5cc687ce8472d2a08c08acf00d3c76e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166812
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [29a19f25f001ae63c60864c6a650220ecb3d0ca1]

        use more concrete UNO classes in writerfilter (SvXMLEmbeddedObjectHelper)
        
        Change-Id: Ic813596204070a17d66d0f469bcdf30e16b16b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166811
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd343716f505bb955ddfb9fa20002468df3fb19c]

        use more concrete UNO classes in writerfilter rtf
        
        Change-Id: I54dded3ffce1fbe6fee1b93370eb5b44bb719339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166810
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [acbb6c98ae1335da5aca4f1a55de5f3ae35a5d02]

        tdf#160867: restore HTML map export for text hyperlinks in frames
        
        The most exciting was to discover that this functionality was actually
        already implemented prior to 2001, and then accidentally dropped, and
        nobody noticed, until Noel did his great cleanups, and made an amazing
        investigation in commit ed2ae3c3bb0a708cafc3de6a01adc9ddc43fb859 (remove
        dead SwNoteURL, 2018-03-14). The detailed commit message made my task
        so much easier: I knew where and what to restore.
        
        So this change restores relevant pieces removed over the time in commits
        * 1b666235f6b0b0f0b13f473bf3b639f4f5f0b12f (loplugin:singlevalfields
          improve copy constructor check, 2018-01-03),
        * be8c414567f49242164b1fdfb12764b16be355c1 (loplugin:unusedmethods also
          check for functions returning bool, 2018-01-19),
        * 73139fe600fc1399ae828077981a2498cb0a0b0c (loplugin:unusedmethods,
          2018-01-20)
        * bb7ade140df807b6a0f12766a1365b8f8d0fd342 (loplugin:unusedmethods,
          2018-03-08),
        * ed2ae3c3bb0a708cafc3de6a01adc9ddc43fb859 (remove dead SwNoteURL,
          2018-03-14),
        * fd1cfd25b48cb4bd5c87e9cb317b37699ca3a1d6 (PortionType::Url is unused,
          2019-01-18).
        
        It re-implements the functionality accidentally removed in commit
        da7671e4f7482110ecd0cfbfd7dbd9e0b873c81c (Opt.(FME): The new attribute
        handler makes a lot of code superfluous, 2001-03-15), moving it into
        SwAttrHandler, which replaced the ChgFnt in SwTxtAttr.
        
        It also fixes the code writing the HTML image map, to output valid HTML.
        
        And finally, it adds a unit test, to avoid repeating the story :-)
        
        Change-Id: I72ae3cf30f0e9689f50a2c877e1622e4ae46de49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166924
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6104316fd50076d41039c33a5338b016e93259fe]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        Change-Id: If4f035fef1e13780b6ce14477ccb2bd7b0eab133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166829
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8dbf87595ece3db6c98d34b97e10276bf588fd73]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        convert OSL_ASSERT to assert, etc.
        
        Change-Id: Idb920aab41e5d63ee07d0a8ef4c4cba1a220fc14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166850
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cf0b0f0dd04fae98b686cd5768673c217a58fab6]

        Emscripten: Only add the --pre-js code to the soffice executable
        
        ...so that e.g. executing `echo test | node instdir/program/uri-encode.js`
        doesn't fail with
        
        > instdir/program/uri-encode.js:460
        >       throw ex;
        >       ^
        >
        > ReferenceError: XMLHttpRequest is not defined
        >     at runMetaWithFS (instdir/program/uri-encode.js:312:15)
        >     at callRuntimeCallbacks (instdir/program/uri-encode.js:1882:26)
        >     at preRun (instdir/program/uri-encode.js:913:3)
        >     at run (instdir/program/uri-encode.js:6854:3)
        >     at runCaller (instdir/program/uri-encode.js:6802:19)
        >     at removeRunDependency (instdir/program/uri-encode.js:1060:7)
        >     at receiveInstance (instdir/program/uri-encode.js:1265:5)
        >     at receiveInstantiationResult (instdir/program/uri-encode.js:1281:5)
        
        (There's nothing special about uri-encode here, it just happens to be the only
        other executable that is built into instdir/program/ by the Emscripten build,
        even if it is probably not even useful there.  It expects to read something from
        stdin, hence the echo part.)
        
        (The generic solenv/gbuild/Executable.mk no longer depends on
        soffice.data.js.link, but it still depends on soffice.data and
        soffice.data.js.metadata for some cp instructions in
        solenv/gbuild/platform/unxgcc.mk, so make those dependencies explicit.  That can
        probably be cleaned up further in a next step.)
        
        Change-Id: I993878a5f6d19d13728d17e803ae7d773946a1d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166930
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [4cec279cf2bf55d33e0eb6c92348aa883d7593ff]

        gtk4 a11y: Handle accessible relations
        
        When creating a new LoAccessible, also consider
        accessible relations.
        These can be retrieved via the XAccessibleRelationSet
        UNO interface.
        
        Bridge those that have an equivalent in the GTK 4 a11y API.
        
        As the parent GtkAccessible of a target XAccessible
        is not known, extend `GtkAccessibleRegistry::getLOAccessible`
        with the functionality to find a parent via the XAccessible
        hierarchy (i.e. by walking up the XAccessible hierarchy
        until a parent is reached that has an entry in registry
        already).
        This could potentially be problematic as an a11y hierarchy
        solely based on the XAccessible hierarchy doesn't necessarily
        match the one with the GtkAccessibles from the native GtkWidget
        hierarchy. In my current understanding, this should presumably
        be OK as long as that mechanism finds one existing
        entry before getting to the root, so assert that this is the case.
        
        With this in place, having a Writer doc with multiple paragraphs,
        there is a flows_to relation shown for the first paragraph to the
        second in Accerciser, etc., and jumping to the target selects
        the next paragraph as expected.
        
        Change-Id: I2ec1fe8c48dd4250d407ae4fb3c8d9c0f6671646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166926
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [63a62abae01e7beb15d1e7cb12c469b42253bf1b]

        tdf#160838 qt: Update IM cursor position also on modifier change
        
        In `QtWidget::handleKeyEvent`, move the call to
        
            QGuiApplication::inputMethod()->update(Qt::ImCursorRectangle);
        
        further up, so the cursor update also happens for the code path
        of calling the `SalEvent::KeyModChange` callback and then returning
        early.
        
        This makes fcitx5's keyboard layout indicator show up at the right
        position again when switching layout right after starting Writer
        (s. tdf#160838 comment comment 2), which was no longer the case
        after the new code path had been introduced in
        
            commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747
            Date:   Mon Jul 19 15:17:53 2021 +0200
        
                tdf#143298 Qt5 send SalEvent::KeyModChange events
        
        (Not sure whether it wouldn't even make more sense
        to update *after* processing the key event for the
        case that actual text is typed, as that presumably
        modifies the cursor position, but leave the logic
        otherwise unchanged for now.)
        
        Change-Id: I6e21ae51568eefc8e2ae64109d5596f5e20cc28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166923
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [691c61146d3d627d24fec336550a0d4933549cda]

        tdf#160838 editeng: Report IME cursor pos more reliably
        
        `mpIMEInfos` is set when handling the
        `CommandEventId::StartExtTextInput` command. However,
        the cursor position can also be queried without it
        being set, as seen e.g. at least for the fcitx5 use case
        from tdf#160838 when using the Qt-based VCL plugins.
        
        If no IME Input has happened yet, just use the current
        selection PaM index as the end index.
        
        This makes the fcitx5 language indicator show up at the
        current cursor position when positioned in a comment in
        Writer, the Calc input bar or a Math formula and
        switching the fcitx5 language/keyboard layout using the shortcut
        with the Qt-based VCL plugins.
        
        The correct position had no longer been used after welding,
        i.e. since
        
            commit 69c546e1e7a697217f273baa7c1729ff823efd76
            Date:   Fri Dec 4 16:30:31 2020 +0000
        
                weld annotation window
        
        for Writer comments and since
        
            commit e087e25f05e689091cbf1c4f91b6e93878ac17ec
            Date:   Mon Oct 5 14:19:05 2020 +0100
        
                weld InputBar
        
        for the Calc input bar.
        
        The fact that the indicator shows up at the wrong position
        before typing any character (e.g. opening Writer, then switching the
        keyboard layout right away, as mentioend in tdf#160838
        comment 2) is a different issue and will be addressed
        separately.
        
        Change-Id: Ibe7698e113cbbea7f273cc929d72ca47fb407a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166888
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-30  Noel Grandin  <noelgrandin@collabora.co.uk>  [62ee743d3c39e45d7fc6e0bdfa51a80e51af0c03]

        fix non-PCH windows build
        
        after
            commit a7f8882e4975e4194732506e4ffb9f7af6eb9c72
            Author: Noel Grandin <noelgrandin@collabora.co.uk>
            Date:   Mon Apr 29 14:31:15 2024 +0200
            convert HeapAlloc to make_unique
        
        Change-Id: Idb2e67285018eeb3373ba11c464df5a00b54a87b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166925
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Szymon Kłos  <szymon.klos@collabora.com>  [c1c32bbbe24ebd4be00c9c3bb38de1dc748bd2b6]

        lok: test number formats with different locale
        
        This is followup for the fix in commit 7836cb7e90d0214cac08228f5e527322ed6f955c
        lok: save correct number format in multi-lang session
        
        Change-Id: I6016425d37b1ee1707ed8920811e8741c9267ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166921
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [55eb79f8f52ef20198aeba04578a1be4d100b126]

        Drop uses of css::uno::Sequence::getConstArray in deployment
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I3b2cb267010e7b654291fa866b28c7cc272f0ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166911
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b19c1cf7fa65386de7eb0eeea8068899cdcfb877]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7e1ef25c4f7bb14013f6e68e04c1205785967dad
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I2067aadd5d6dad3a13b142a80b099c86aa4f2211
            
2024-04-30  RMZeroFour  <ritobroto04@gmail.com>  [c299e54ce2edf2b8b3b21754ed9fd16cdf6167b3]

        tdf#143122 Port Java TerminationTest example to C++
        
        This patch ports odk/examples/DevelopersGuide/OfficeDev/TerminationTest
        example to C++.
        
        The original Java example code was moved to a java/ subdirectory, and
        the new C++ code was added to the cxx/ subdirectory. Necessary changes
        were made in the corresponding Makefiles.
        
        Along with the code in TerminationTest.java, the TerminateListener
        class was also ported and used in the same C++ file.
        
        Change-Id: I889b8893740bc8f80cdd9aa9925e83cadcea9592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165916
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b671bb2ea72b225985eb02b275915c32ec03291c]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        convert OSL_ASSERT to assert
        
        Change-Id: I047b5987734c14e05c9be89db297749c36a0a26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166922
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  kubak  <kuba@openoffice.com.pl>  [2db558b5a1c01b3a08f60962c0115a34aa09bf90]

        tdf#145305 Improve Windows version string.
        
        Version:
        6.1 -> Windows 7 SP1,
        6.2 -> Windows 8,
        6.3 -> Windows 8.1,
        10.0 build number < 22000 -> Windows 10,
        10.0 build number >= 22000 -> Windows 11.
        
        Change string format in AboutBox from "Windows 10.0 build 22631"
        to "Windows 11 (10.0 build 22631)".
        
        Co-authored-by: Achintya Sharma <sharmaachintya08@gmail.com>
        Joel Dowdy <joeldowdy12@gmail.com>
        
        Change-Id: Icdd559a08f5d67d39c4a088585c2113bf4c3695b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166779
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82ba7e2f78fa1c867c7df40a5b0120ced4446702]

        we dereference pProfile->m_Lines on the next line anyway
        
        Change-Id: I8ab203baa6276cb950e5a6168af32cb4a9fa24d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166915
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d25b88ca2b6f59ce9b43b5d2e37ac7b95f2489f1]

        WaE: C6011 Dereferencing NULL pointer warnings from unchecked malloc
        
        upgrade OSL_ASSERT to assert and add a few more
        
        Change-Id: Ib52ca573d9e0878fef94dec40410f71bc94dea04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166914
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [51407b6f8ddd0930bf338e04b2e823b93166f2f6]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        add some asserts for msvc
        
        Change-Id: I3b024b9c1a3160a963ba77ad7313767f2c0a29ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166920
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9fe1b7c53df5cb3a612ab30866437ced0a406fd0]

        WaE: C6011 Dereferencing NULL pointer warnings
        
        upgrade to asserts
        
        Change-Id: Iaf4ad07b87496e2e2039e01a4e5ceb6128cdd012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166919
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a6f52af75780ae28e4dc12f564ce3eb6d9c14b91]

        try to workaround clang crash
        
         Stack dump:
         0.	Program arguments: clang++ -stdlib=libc++ -fsanitize-blacklist=/src/libreoffice/bin/sanitize-excludelist.txt -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=gcc3 -DLINUX -DNDEBUG -DOSL_DEBUG_LEVEL=0 -DUNIX -DUNX -DX86_64 -D_PTHREADS -D_REENTRANT -DCPPU_DLLIMPLEMENTATION -fvisibility=hidden -Wall -Wno-missing-braces -Wendif-labels -Wextra -Wundef -Wunreachable-code -Wshadow -Wunused-macros -Wembedded-directive -finput-charset=UTF-8 -fmessage-length=0 -fno-common -pipe -fstack-protector-strong -Wdeprecated-copy-dtor -Wimplicit-fallthrough -Wunused-exception-parameter -Wrange-loop-analysis -fvisibility-inlines-hidden -fPIC -Wshadow -Woverloaded-virtual -std=c++20 -pthread -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp -stdlib=libc++ -fexceptions -DLIBO_INTERNAL_ONLY -c /src/libreoffice/cppu/source/threadpool/current.cxx -o /work/workdir_for_build/CxxObject/cppu/source/threadpool/current.o -MMD -MT /work/workdir_for_build/CxxObject/cppu/source/threadpool/current.o -MP -MF /work/workdir_for_build/Dep/CxxObject/cppu/source/threadpool/current.d_ -I/src/libreoffice/include -I/work/config_build -I/work/workdir_for_build/UnoApiHeadersTarget/udkapi/normal
         1.	/src/libreoffice/cppu/source/threadpool/current.cxx:77:8: current parser token ';'
         2.	/src/libreoffice/cppu/source/threadpool/current.cxx:37:1: parsing namespace 'cppu'
         3.	/src/libreoffice/cppu/source/threadpool/current.cxx:41:1: parsing function body 'cppu::get_type_XCurrentContext'
         4.	/src/libreoffice/cppu/source/threadpool/current.cxx:41:1: in compound statement ('{}')
          #0 0x000000000190f863 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/usr/local/bin/clang-15+0x190f863)
          #1 0x000000000190d7ae llvm::sys::RunSignalHandlers() (/usr/local/bin/clang-15+0x190d7ae)
          #2 0x000000000190ed0d llvm::sys::CleanupOnSignal(unsigned long) (/usr/local/bin/clang-15+0x190ed0d)
          #3 0x0000000001893000 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
          #4 0x00007f628aef1420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
          #5 0x00007f628aafc963 (/lib/x86_64-linux-gnu/libc.so.6+0x18b963)
          #6 0x000000000186b31b llvm::APInt::APInt(unsigned int, llvm::ArrayRef<unsigned long>) (/usr/local/bin/clang-15+0x186b31b)
          #7 0x0000000003d5031a (anonymous namespace)::StmtPrinter::VisitUserDefinedLiteral(clang::UserDefinedLiteral*) StmtPrinter.cpp:0:0
          #8 0x0000000003d44e40 clang::Stmt::printPretty(llvm::raw_ostream&, clang::PrinterHelper*, clang::PrintingPolicy const&, unsigned int, llvm::StringRef, clang::ASTContext const*) const (/usr/local/bin/clang-15+0x3d44e40)
        
        Change-Id: I963a7ee431748b21ab587a90208f9cdbb2df2bf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166918
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [da3913a70cd133478add296b63d0e7e28c2374bf]

        use more concrete UNO classes in writerfilter (SwXTextEmbeddedObject)
        
        Change-Id: I410bdf51539b2752e95e3dafe8a1513b7bb19626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166809
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ff27aa2ca0ff9b6520d65bf1bb6f7fc2c6efd79d]

        cid#1596694 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1596695 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id90f4da2edf45f7de324fdc9d910cfc3931fa60f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [87132f2ceae0b8e41cf028bb3c82b497fbb3d982]

        cid#1596696 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6e8473a569b14591d2b83284d37a672c1ade35cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166887
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54404c2c20399a7349ad1abb9f37df3048c7aad1]

        cid#1596697 Dereference after null check
        
        Change-Id: I93c9401144fbe5a83ee461ff3fe4334326f6f05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166886
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b2ab2c862c289d1ab6aabd3de21f4ea45f7a4aed]

        SwModify::Add/Remove always derefs arg
        
        an effort to remove C6011 Dereferencing NULL pointer 'pDepend'
        
        Change-Id: If9e7b7be25ece3df60ada09e5c83d03aebe9c535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166865
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Noel Grandin  <noelgrandin@collabora.co.uk>  [a7f8882e4975e4194732506e4ffb9f7af6eb9c72]

        convert HeapAlloc to make_unique
        
        which means we don't have to explicitly handle OOM, and the resulting
        code is much cleaner
        
        Change-Id: I958d6678bb2d6878dda9de6bf82c5314f168db17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166855
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1a471e674f46699a2787e3ab74353fbe1de5c456]

        WaE: C6011 Dereferencing NULL pointer warnings from unchecked malloc
        
        Change-Id: I14892e3d0badb4a46b82624b86d78eb9bcb8eed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166700
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [26166ad838aa4f8fac933a4d14ef5025911cbecb]

        loplugin:ostr in package
        
        Change-Id: I0acc6261ab2ab2b6de52907feeaa0944f708e410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [10d2f2ebf13801feca8d14ecce96f7f5239409c2]

        loplugin:ostr in comphelper
        
        Change-Id: Ide07689bf1a68973cb176554e44e9a809d633def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [41e5b9d32f8914e3f0159f064e46c362d55b6ccd]

        Remove some syntactic noise
        
        Use of auto num(0) together with decltype<num>(1) is overkill,
        when the language explicitly specifies these literals to be int.
        
        Also, change static_casts on literals into function-style cast.
        
        And make some comparisong use CPPUNIT_ASSERT_GREATEREQUAL.
        
        Change-Id: I3af7231a997a4611b564b38facd15a3a6bb76cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166893
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-30  Miklos Vajna  <vmiklos@collabora.com>  [06aeb9c61d50bba7edafe17f9d3513af26b0782f]

        tdf#159683 sw content controls, plain text: fix crash with the clipboard doc
        
        Regression from commit c804c5354855188b5a37219cfe11dc079dc235f4 (sw
        content control: fix lost properties on copy&paste, 2023-03-10), select
        a plain text content control, copy it to the clipboard, quit: assertion
        fails during shutdown because the doc's "placeholder text" char style is
        still referenced by a client.
        
        What happens here is that the SwContentControl copy ctor copies the
        plain text flag, and that flag is only read in SwTextNode::InsertHint(),
        so that causes the problem. Note how that code is inconsistent: we avoid
        the creation of dummy characters in the copy case, but we still try to
        adjust the start/end of the content control attribute in the copy case,
        which makes not much sense.
        
        Fix the problem by not adjusting the content control attribute
        boundaries in the copy case, since the original intention was to do
        thees corrections only at a UI level, during interactive edit.
        
        It's not clear why this inconsistency had an influence on the clients of
        the char style, though.
        
        Change-Id: I86b0516464f24fc453dcd97588dafb8afd010a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166882
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8b145fc3f83b5b38ff36c4986aec1f3e09863a55]

        line break "Preloading breakiterator: Preload icons"
        
        so "Preloading breakiterator" is on its own line
        
        Change-Id: If2dfb6e9c636346b8b425187c4faab311cf32131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166589
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit e2cbe31915c3ee98ae433894c8e08c3afe5f3bb8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-30  Miklos Vajna  <vmiklos@collabora.com>  [016b2f2f9194a4a1997d0e7bb51bbd1b10bc27ec]

        tdf#160833 sw DoNotMirrorRtlDrawObjs: add layout
        
        In case this flag is active (intended for DOCX files), then don't
        automatically mirror the position of drawing objects, just because they
        are anchored in an RTL text node.
        
        Change-Id: Ie743d94ecb511d7de89e8e1e8303896370ce58c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166883
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb55430412a9a0e211482ee853f78ea35989e92a]

        tdf#160827: sw_ooxmlexport20: Add unittest
        
        Change-Id: I6fb58ef5e2336a1dcf9c8bc805a494fd4dd8e4bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166871
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [efc8ce2c4e840cc68dbfc73da014434a3ddd0cda]

        use more concrete UNO classes in writerfilter (SwXFootnote)
        
        Change-Id: I9d212348edfa1897ad139fbb9f633fbd5a09566d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-30  Heiko Tietze  <tietze.heiko@gmail.com>  [9e7d70230212ab95cda957a0fe51e37f7ca95021]

        Related tdf#143733 - Cell focus must not cover content
        
        This patch moves the cell focus rectangle outside the active cell,
        relative to the zoom factor
        
        Change-Id: I9df98125d5c0e571af841442d4db8f02d3c05487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166870
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-30  Justin Luth  <justin.luth@collabora.com>  [a50b2d11ed6066a655278305f1fc880d3a5fe911]

        xlsx import: parse short-hand version of address
        
        Since I did this for the range, I might as well
        try to entirely remove parseOoxAddress2d.
        
        This allows me to remove parseOoxAddress2d.
        No point in having duplicate functions to turn a string
        into an ScAddress.
        [I assume this was a left-over from when this code
        was in /oox and didn't have access to sc methods.]
        
        Earlier patchsets checked that the new method and the old method
        returned the same values for all existing unit tests.
        
        Change-Id: Ic45eaf53417b0d8afad7b49959014162549653ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166606
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-30  Nima Mahanloo  <nima.mahanloo@yahoo.com>  [d04b6c775d8b304aa09e62f766bd74a83f8e3794]

        tdf#145614 Convert #define to enum
        
        Change-Id: I0a360a93775d2c46b7e02009879d7a18315497b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166168
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-04-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [735ea444f2c15771736260fc78704f6b9132ceac]

        Embind: Fix out-param handling
        
        ...by using UnoInOutParam in all cases.  Some types whose Embind mappings don't
        employ any smart pointers (like any and sequence) would have worked directly
        with pointers, but others (like string and type) would have caused Embind errors
        at runtime.  So consistently use UnoInOutParam in all cases (and generate
        bindings for all the used cases in embindmaker).
        
        Change-Id: If26551bf4e99d10748aec1597d6e99f994dfd86e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166854
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [621cfc0e4120ab2b381b54268fe39bd19257df9b]

        qt: Guard clipboard mime data with SolarMutex
        
        Most of the access to the QtClipboardTransferable
        mime data happens exclusively on the main thread,
        with the solar mutex held.
        
        However, `mimeData()`, called from `QtClipboard::getContents`
        didn't ensure that yet, so as Michael Stahl pointed out in [1],
        
            commit 1db5b87fe69c2375f1d66974dafcd563303c76db
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 13 13:23:17 2024 +0100
        
                tdf#156562 qt: Sync with system clipboard content if necessary
        
        introduced a data race by allowing to set new mime data.
        
        Introduce a new
        `QtClipboardTransferable::hasMimeData(const QMimeData* pMimeData)`
        that guards access to the mime data with the solar mutext as well
        and use that instead, so all access to the `QtClipboardTransferable`
        mime data is now guarded by the solar mutex.
        
        Also add an explicit note for the mime data getter/setter in the
        `QtTransferable` base class that subclasses allowing to update
        mime data are responsible for preventing data races.
        
        [1] https://gerrit.libreoffice.org/c/core/+/166141/comment/fe75f418_40c1b622
        
        Change-Id: I01dbbb0b37a4c6ad06b4d3001ecce8b0260eb32e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166750
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [8939999deef4f77f19d7b2d31df09260a34affe1]

        qt: Avoid race on QtTransferable member
        
        As Michael Stahl pointed out in [1], there is a data
        race on `QtTransferable::m_bProvideUTF16FromOtherEncoding`.
        
        Adjust the code a bit to no longer make use of the
        member and drop it.
        
        The QtClipboard case was fine because both methods making
        use of the member always run in the main thread with the
        SolarMutex held.
        
        For anything else, the `m_pMimeData` doesn't change
        don't change, so access to that member doesn't need
        to be guarded by a mutex and thus dropping
        `QtTransferable::m_bProvideUTF16FromOtherEncoding`
        should be sufficient to address that race at least.
        (Another one will be addressed separately.)
        
        [1] https://gerrit.libreoffice.org/c/core/+/166140/comment/bc1c9f11_6ad630b7
        
        Change-Id: Iaf2fb460b129493f5627c95b6968aa57da368b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166749
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [ea9367037232054a576f1e6aabffeb3a62ffa44b]

        Drop some uses of css::uno::Sequence::getConstArray ...
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I4ccc647bb794515c8c11f8dfd9a26563f4aa094b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166819
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e82c9633e4f9bc4590bd6cd8d2a82a974ddaf00f]

        svx: use o3tl::convert instead of 847 (mm100) when we want 24pt
        
        Change-Id: I1d1c4a0e12c0443e7021c8aedcd386814a1647be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166823
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-30  Patrick Luby  <guibmacdev@gmail.com>  [f4ef5435df5560e6b6b061ce4053c71e2819bf51]

        tdf#130678 draw SVG icons at Retina resolution on macOS
        
        Also, change the default icon theme on macOS to SVG now that SVG icons
        support Retina display resolution and the existing PNG icon themes do not.
        
        Change-Id: I8c86c316b0db005661759c132ecf7e8667cf30bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166867
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [af5a1b5925dbc816dced8813282d953fd5adbaaa]

        Drop uses of css::uno::Sequence::getConstArray in dbaccess
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I4f8dc4f430dc49fa29012b8f064094daceb5e1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166818
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [00e2762c664614a1b33f54dfc990ba29f0f81a07]

        Drop uses of css::uno::Sequence::getConstArray in cppuhelper .. cui
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: Ia2b60af973183bbe79656e67b5e37d7efa39a308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166817
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [8755c80018bec656e1b102da25edc450da4eee52]

        Drop uses of css::uno::Sequence::getConstArray in canvas .. connectivity
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I9467028fd1a7eeafad7f0dd776a91a9a40770b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166816
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [20070d12c85ae6db8d5b1374a49f92b34137c8b1]

        Drop uses of css::uno::Sequence::getConstArray in accessibility .. basegfx
        
        where it was obsoleted by commits 2484de6728bd11bb7949003d112f1ece2223c7a1
        (Remove non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const Sequence::operator[]
        in internal code 2021-11-05).
        
        Change-Id: I14e3634d8e8dd294b673dcda4dde13f01c3e5112
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166813
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bad2224090eb2802111760ec83db230aeca0616]

        futile to null check here if we deref afterwards anyway
        
        Change-Id: I994b276ad39b09547cb1dbd3710daf519c5f5c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9bc04a380016c7537850b3f929afab21448eac03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d4e0c0452346d797ae5eda7e3c1c61d73f6eb3c
          - Fix indexer="include" in  Help files.
            
            + refactor
            
            Change-Id: Ia0dfdc0f88f40776042ca0b745e26dc9e0cd479f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166874
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-04-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6818bf2638fe5d51623908a15a4bf423d21977bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3fa70de3d05c43e190a2d2718a43667bda3ff5f1
          - Fix indexer="include" in database Help files.
            
            + refactor
            
            Change-Id: Iacaffc96aac85e7b06348372da16449c1206e2de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166873
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e729fec8a9e73e9d013cb634d4bcbd8c43be4200]

        update credits
        
        Change-Id: I92481956d041c4a5077aa7a56af2df3ab72fd9bf

2024-04-29  Miklos Vajna  <vmiklos@collabora.com>  [c675eaf923cf579670b8ba2f7794b47be7fad39e]

        tdf#160833 sw: add a DoNotMirrorRtlDrawObjs compat flag
        
        The DOCX bugdoc has a circle shape anchored inside an RTL paragraph:
        this shows up on the right hand side in Word, but on the left hand side
        in Writer.
        
        What happens is that Writer implicitly mirrors draw objects anchored in
        RTL paragraphs, while Word doesn't do this.
        
        Start fixing the problem by adding a new layout compatibility flag that
        can be used by the DOCX import in the future, to leave the behavior
        unchanged for new & existing ODT documents.
        
        An alternative would be to do something similar to the DOC import's
        SwWW8ImplReader::MiserableRTLGraphicsHack(), but 1) we don't have the
        page margins by the time we import the shape and 2) as its name says, it
        doesn't feel like a clean solution, it's better to handle this
        difference at a layout level.
        
        Change-Id: I2ec067d86c7fbdbe57e4cd9547015fe25a9a56b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166820
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-29  Noel Grandin  <noelgrandin@gmail.com>  [c60d246e7af0a6c58bfdc5a4042fc81b41fad4ff]

        fix macos build
        
        after
            commit cfb913db1b2024f8ff6a55f45742b303107a1924
            Author: Justin Luth <justin.luth@collabora.com>
            Date:   Tue Apr 23 20:15:27 2024 -0400
            xlsx import: parse short-hand version of range address
        
        Change-Id: Ia75b2bd90ac02b682f1c86865a07ac5e2557b555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166875
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [34b66eac036fcb9b154721e063751311813efb2e]

        fix Windows build
        
        after
            commit a7094c815628c70ac0430cd2ddc21f13b0b316d2
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 26 15:36:48 2024 +0200
            make more symbols private in calc
        
        Seems different jenkins boxes compile slightly differently
        
        Change-Id: I7a439e236e8c3c753ce358b8d5f6e06ccf181768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166869
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-29  Arnaud VERSINI  <arnaud.versini@pm.me>  [190156976dd4f1c023279eddd1eed61bfd037e7a]

        tdf#147021 : use std::size instead of SAL_N_ELEMENTS in generated code too
        
        Change-Id: Ib11a703c0250b1f80b7e79fe24e3bda915e7198b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166385
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [716706d6ba38e6dc28067af84cfe8b7e64920914]

        WaE: C6054: String 'baseDrive' might not be zero-terminated
        
        Change-Id: I0d3192dbac5ca73cd93051bcdf812bbe34a77c8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Justin Luth  <justin.luth@collabora.com>  [cfb913db1b2024f8ff6a55f45742b303107a1924]

        xlsx import: parse short-hand version of range address
        
        In order to indicate the entire row or column
        (for the benefit of a spreadsheet program that may eventually
        increase the supported number of rows or columns it supports)
        a short-handed form of the range can be used
        like "B:B" for the entire column,
        or "1:10" for the first 10 rows of all columns.
        
        Shorthand is nicer for humans
        and allows for future expansion of row/column space
        
        This reverts 24.8 commit a29d91ac403f1ed431ca95b8b9c290bd354c3ae7
            xlsx export: never export short-hand version of range address
        which reduced the likelihood that we will ever see
        such a range, because Excel seems to always
        write out the full address.
        However, the shorthand version is definitely valid for Excel.
        
        Earlier patchsets checked that the new method and the old method
        returned the same values for all existing unit tests.
        
        Change-Id: I7677dfc207771a32222095416f728f7cd34a4f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166570
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7e30434655754277bfa7ce7d8ec37b07181d2c92]

        tdf#160765 - Paste Special Dialog: Remember comments checkbox
        
        After the change of tdf#139858 the comments checkbox was not remembered anymore after closing the dialog. In order to fix this issue, additionally check not only the NOTE flag but also for the ADDNOTES one.
        
        Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [0627386e924279e1de75210cf6b144303fccbe7f]

        Fix UBSan failure
        
        Introduced by 495b5db74f0db59395ff68bacc8d8ca67595b66e
        "sw: check GetUserCall"
        
        https://ci.libreoffice.org/job/lo_ubsan/3154/consoleFull#-1571115798d893063f-7f3d-4b7e-b56f-4e0f225817cd
        Change-Id: Ifc80312890f2e6b82dcc9419b5b7e8bfcd5340a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166824
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-29  Todor Balabanov  <todor.balabanov@gmail.com>  [763149e2f48766427e0962058ad812b07caf1e07]

        Double values comparison changed to compare method.
        
        Using the Double.compare() method is often preferred over the == comparison
        operator for comparing double values due to several reasons:
        
        Handling NaN (Not-a-Number) values: The Double.compare() method correctly
        handles NaN values, while the == operator does not. If either of the operands
        is NaN, the == operator will always return false, regardless of the other
        operand. In contrast, Double.compare() will correctly evaluate NaN values
        according to the IEEE 754 floating-point standard.
        
        Handling positive and negative zero: The == operator treats positive zero and
        negative zero as equal, whereas they are distinct values in IEEE 754
        floating-point representation. Double.compare() correctly distinguishes
        between positive and negative zero.
        
        Robustness against rounding errors: Floating-point arithmetic can introduce
        rounding errors, causing two double values that should be equal to differ
        slightly. Directly comparing them with the == operator might yield unexpected
        results due to these small differences. Double.compare() allows you to define
        a tolerance level if necessary, providing more control over how equality is
        determined.
        
        Consistent behavior: The behavior of Double.compare() is consistent and
        predictable across different platforms and JVM implementations, as it follows
        the IEEE 754 standard. On the other hand, the behavior of the == operator
        might vary depending on the platform and compiler optimizations.
        
        Suitability for sorting: Double.compare() returns an integer value that can
        be directly used for sorting double values in ascending or descending order.
        This makes it convenient for sorting arrays or collections of double values.
        
        Overall, while the == operator might work in some cases, using
        Double.compare() provides more robust and predictable behavior, especially
        when dealing with floating-point numbers in Java.
        
        Change-Id: I5756936a0d2b4fe11b9113ddd33b6ae691f5103f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [27ed452ae685c396d4507253b35099f106471d9d]

        use more concrete UNO classes in writerfilter (SwXContentControl)
        
        Change-Id: I84a4c82176681eb55e90240a2db7001123605c1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166807
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-29  Arnaud VERSINI  <arnaud.versini@pm.me>  [b6c2ff2f05f94637feb537cb4cea5d7f040f9031]

        i18npool : remove useless stdio include generation
        
        Change-Id: Ib37f2c7553de2045496a090cda7006257fcf5e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166386
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
        Tested-by: Jenkins

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9fb7afe13aa24464eecfee82c3e81e53017d74d]

        ofz#68265 fix oss-fuzz build failure
        
        Change-Id: I73087235d87253f4c8375fa0c0492c6258701571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166827
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a6d41c61daaf6f0822fc86d790eca19972e4a7c8]

        UBSan needs SwXBookmark RTTI now
        
        ...presumably since 6a11bf9f7bd209a082254c861d5a04c7f5729d68 "use more concrete
        UNO classes in writerfilter (SwXBookmark)", failing sw_writerfilter_misc with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_writerfilter_misc.so
        > instdir/program/libsw_writerfilterlo.so: undefined symbol: _ZTI11SwXBookmark"
        
        Change-Id: I9f839ca0f6986723cd2c4add5eaef3ac8ab8d841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-29  Noel Grandin  <noelgrandin@gmail.com>  [51cfdfd7d4e50c33d040f830cd0133dff7cb6893]

        reduce symbol visibility
        
        Change-Id: Ibc850eb12c38f2985015f06e330585b02d6bf15f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166822
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [084882a66c4e612f207024be301631102be31ca6]

        sw: fixed crash on GetCreateView() returning nullptr
        
        Change-Id: Id0cb44ac7d805a1736fa8170aaffb97b54211707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166617
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2024-04-29  Miklos Vajna  <vmiklos@collabora.com>  [5a61b590ae51ccf28e501bb943f1cf4a3e9835a1]

        svx: prefix members of SdrLayerAdmin
        
        See tdf#94879 for motivation.
        
        Change-Id: I8ea80a3f2121c5c29168aa185e6278d924874c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166815
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-29  Hubert Figuière  <hub@collabora.com>  [9648f81f98d07cd4aef8611a50a77f11fb7ba86e]

        cool#8066: calc: enable .uno:ToggleSheetGrid
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: Ibe5bca4d0622c4015030a21d4ecccd41d5e9f483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166529
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5c988821db31f285cdd207e2a2ac849c0f1c099]

        WaE: C6011 Derefencing NULL pointer 'pMF'
        
        Change-Id: I76e85e8671623f7cdf994dce779c3944b8761acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a70a8f55973ec3e71f65335be75699f1d2a73d62]

        Unchecked HeapAlloc
        
        Change-Id: Icd49d0b5f996d57d8e9518cb08fd3c3fc54fa779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166732
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5354d8fb170418c130c08b070029f09337573ef6]

        WaE: C6326: Potential comparison of a constant with another constant
        
        if msvc -analyze is used
        
        Change-Id: I5905447a79e8e50d70281e0c230d1ce3b13fc475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bd4964c57def05936dae00de3e4615eaf9f51cfd]

        WaE: C6387 'pEncodingName' could be 0
        
        Change-Id: I3ff5050a88d8e5ae6c6581189597231d49e0f96a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166733
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9dbae9762c38ac69d71b2a763b812e3711c28921]

        rearrange to clarify that ThumbnailViewItem* was never null
        
        Change-Id: Ie10ed0193fbaeae2fb711caa9059906513c42e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166730
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [064b335cf721db96fe556c78b15d0abe0edec70d]

        call SfxViewShell::Current() just once
        
        Change-Id: Iea3777cfb86c64c01cf1029ff3ba6a834d8c3619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166706
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95d3e0d478686c7fa84f0bb8c466a1082333a47b]

        SfxViewFrame::Current() dereferenced without null check
        
        found with msvc -analyze and _Ret_maybenull_
        
        Change-Id: Ia377822e93448dc61acd1482d34167c35a46836b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166705
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-29  Alex Henrie  <alexhenrie24@gmail.com>  [5d7d94d5239c4ad7d8dc997ccbb0060ba2391280]

        Add missing file types to desktop files and alphabetize the lists
        
        The missing MIME types were:
        
        * application/docbook+xml
        * application/x-gnumeric
        * application/x-pocket-word
        * application/x-starchart
        * application/x-starimpress
        * application/x-starmath
        * application/x-starwriter-global
        * application/vnd.apache.parquet
        * application/vnd.quark.quarkxpress
        * application/vnd.stardivision.calc
        * application/vnd.stardivision.chart
        * application/vnd.stardivision.draw
        * application/vnd.stardivision.impress
        * application/vnd.stardivision.math
        * application/vnd.stardivision.writer-global
        
        Having the lists in alphabetical order will make it much easier to spot
        missing types in the future.
        
        Change-Id: Iae25bb074e8d22c6c6efeaf1101a1a07429accda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166545
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-29  Szymon Kłos  <szymon.klos@collabora.com>  [0a5026b3675154ee216dd87ba46dfe533744eb05]

        lok: save correct number format in multi-lang session
        
        Number formats can have different keywords in different
        languages: D - Day(EN), T - Tag(DE).
        This can cause problem when we use format which will not
        be recognized by current number formatter, then we put
        unknown keyword as string in quotes. As the result we get
        for example: formatCode="&quot;TT.&quot;mm&quot;.JJJJ&quot;"
        
        The problem exists especially in multi-language setup in LOK
        when we use non-English languages:
        1. open xlsx using FR
        2. join with DE
        3. modify number formats in both
        4. leave spreadsheet with both so it will be saved
        Result: after we open it again we have some keywords as
        strings, user has to apply new number format to see the
        real value
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ice04d890b38cd2d08d06f41fc7b3cc55f64fadbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166711
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2024-04-29  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b64751ba28fd69fb2a93a21b10a92b68f4dd2097]

        tdf#99528 Properly layout vertical tabs without icons
        
        Implement a proper list mode for VerticalTabControl.
        
        Before this was only used in the Hyperlink dialog with large icons.
        
        Change-Id: I227643392ef4840a705555b379734e2993db0f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166702
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-29  László Németh  <nemeth@numbertext.org>  [30de13743f144aced83bc43d310592f82788c910]

        tdf#160836 sw: resize rows at images cropped by row height
        
        Fixed row height can crop cell content, including images
        anchored as character. Resizing the row height with mouse
        was not possible there, because selection of the cropped
        image avoided to drag & drop the horizontal cell border.
        
        Change-Id: I6dde79e77563468059794548b6c058cad61586a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166795
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-04-29  László Németh  <nemeth@numbertext.org>  [f3b899655018397e71300dbb32cdf4f82940a68b]

        tdf#160842 sw: select cell content instead of cropped part of image
        
        It was not possible to select and edit the content of the bottom
        cell, if an image cropped by the fixed row height "covered" it,
        i.e. the image was in the previous row, anchored as character.
        
        Note: table cells with fixed row height are usable to crop images
        easily, with a single drag & drop, according to the requirement of
        the text layout, while the cell above or bottom of the cell with
        image is for the caption of the image. This is very useful to
        adjust a book layout with sections with multiple columns and
        illustrations.
        
        Change-Id: I8683b4066db6ce43549ec3aa69b0e639a59e3681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166794
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-04-29  László Németh  <nemeth@numbertext.org>  [6c00a73348511b688be214439941e128fc430a34]

        tdf#44773 sw: allow resizing table rows, if cursor outside the table
        
        If the cursor wasn't in the table, only column width of text
        tables was resizeable by dragging the horizontal cell borders:
        It was possible to drag the horizontal border, showing its
        preview, but the drop cancelled the operation instead of
        resizing the table row according to the selected position.
        
        Now it's possible to resize the height of the table rows
        without moving the text cursor inside the table.
        
        Note: This is important for floating tables containing images:
        here it's not possible to put the cursor inside the table, if
        the image is cropped only by the cell borders: so it was not
        possible to resize the row height.
        
        Change-Id: I181d79a28cdeefabb796b7b978ee1368a9378888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166793
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-04-28  Patrick Luby  <guibmacdev@gmail.com>  [5425103fb5a09c7e5e56d077260523438c593e21]

        tdf#160831 only set outside color to black for alpha masks
        
        The outside color still needs to be white for the content
        so only apply the fix for tdf#157795 to the alpha mask.
        
        Change-Id: I7486b2c9062ca96bf127f2bce6b1bd5e65d00ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166806
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-04-28  Noel Grandin  <noelgrandin@gmail.com>  [5058a54d8d251837ad92478b91495c41497b670b]

        reduce symbol visibility
        
        Change-Id: Iad2d114d257244f456d5579636e5c25ce070a08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0cfaf93bf5c6e4e505b45f5e4fbac54edd77ddd6]

        use more concrete UNO classes in writerfilter (SwXStyle)
        
        Change-Id: I12b41369ee65f46e08494acda0435f767e28f290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ccf6f2a203a5a215f7a1e4d097cc08a73d22f2c]

        use more explicit UNO types in writerfilter
        
        Change-Id: Icf26a78679398746a6c51453ae2de64615de088e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ee095d7e075ebc12183378c65fe64e5c0fc1ba4]

        use more concrete UNO classes in writerfilter (SwXTextGraphicObject)
        
        Change-Id: I27c96bd3c18d24398f773319fa41bed8a8da9eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [24ac1b2eea24c6aab04ecde88e692f352fda2b62]

        use more concrete UNO classes in writerfilter (SwXTextFrame)
        
        Change-Id: Ic00730c49c0feb7ab7e649c7d6e5d3ff1cb79b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [94122cb7513a277b21f21611bba36505176f53b6]

        use more concrete UNO classes in writerfilter (field annotation)
        
        Change-Id: I39e2c1d7d3c49017795d1365895ef8bd8d1e0e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Julien Nabet  <serval2412@yahoo.fr>  [45d2d90d2354a6a32297cde52c0041915499b19b]

        tdf#160827: fix crash when retrieving _MarkAsFinal value (docx) (take 2)
        
        Change-Id: I3f2ad56a205877be54b0dbfe361b76db3436f5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166798
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [14ed2224269426ab68b6591c178c8a0d636e51a8]

        use more concrete UNO classes in writerfilter (SwXTextSection)
        
        Change-Id: I407d165ccdfcb23e2b922701dc9753c72c439cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166788
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [192f76cbb2718b9d83f4b674a71ddf8d1c467184]

        use more concrete UNO classes in writerfilter (SwXFieldmark)
        
        Change-Id: Ifa90331eadc08e0949c28d09be92d5aed4c8a70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166787
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a83b7cd01cb804d6138b4ca7de0e1d7a8abfe31d]

        Use less ConfigurationAccess in favor of officecfg
        
        Change-Id: I9bb0165aabb0d5ff2caac33ec948a04d96eb3316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166756
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [924d7b64f07a3bd1d9d3195eb3ce923b616bfb45]

        Drop CacheConfiguration in favor of officecfg
        
        Also the key path was wrong in SlsCacheConfiguration.cxx:
        MultiPaneGUI/SlideSorter/PreviewCache
        but in Impress.xcs we have
        MultiPaneGUI/SlideSorterBar/PreviewCache
        hierarchy so this may actually now start to work :)
        
        Change-Id: I4b552be713e6e157edb45692ba78101429aa1c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166755
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a11bf9f7bd209a082254c861d5a04c7f5729d68]

        use more concrete UNO classes in writerfilter (SwXBookmark)
        
        Change-Id: I8a0e9a83ef2bad7920067d108443b7b682f0660e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Julien Nabet  <serval2412@yahoo.fr>  [83236587bfca52513515b0b7a7dbfa18eed11503]

        tdf#159625: fix "allow to split paragraph"
        
        2 pbs here:
        1) bug described in the bugtracker, the uncheck isn't kept
        => just remove all the buggy GetOldItem stuff
        2) after unchecked the option then saving the file and reloading the file, the option is still checked
        => change the buggy
        rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_FALSE, _nWhich ) );
        to
        rOutSet->Put( SvxFormatSplitItem( eState == TRISTATE_TRUE, _nWhich ) );
        
        In fact, I just mimicked the code used for "keep paragraphs" which works well.
        
        Also change the QA test since "allow to split paragraph" is checked by default
        so if the QA simulates a click on it, we expect the value to be false when dialog is opened again
        
        Change-Id: I947feb02e0c282304621a252ad5e4c168c1d295a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166774
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-28  Julien Nabet  <serval2412@yahoo.fr>  [5158104b9294ab85ab7a675b5b627469e303c345]

        Revert "tdf#160827: fix crash when retrieving _MarkAsFinal value (docx)"
        
        As Noel advised in https://gerrit.libreoffice.org/c/core/+/166724, it's better to test type this way:
        getValueType() == cppu::UnoType<bool>::get()
        
        This reverts commit f49d74edf76097d014ed891d0025cb2e9b197c5a.
        
        Change-Id: Ic148b27761141d1020b63eeba8044fd545bab2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166797
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-28  Julien Nabet  <serval2412@yahoo.fr>  [f49d74edf76097d014ed891d0025cb2e9b197c5a]

        tdf#160827: fix crash when retrieving _MarkAsFinal value (docx)
        
        xPropertySet->getPropertyValue("_MarkAsFinal") can retrieve an Any
        containing a boolean or a string
        
        Change-Id: I1c8bafc12cdaf7fb98d3500507ba83b3e90f69cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166763
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-28  Stephan Bergmann  <sbergman@redhat.com>  [d98e014cf6d4cea7ebd7898cbc9124f6fba07684]

        Extended loplugin:ostr manual changes
        
        I had done these a while ago, when I looked into extending loplugin:ostr to do
        more automatic rewriting, and these were places where I needed to do something
        manually, for one reason or another, because the automatic rewriting would not
        pick it up correctly.
        
        However, I got distracted, and a wholesale automatic rewrite would still run
        into cases where an _ostr/_ustr instance from a library's .rodata would still be
        referenced after the library has already been dlcose'd.  So I never came around
        to finishing all that.
        
        But there appears to be renewed interest in (automatic) rewritings here now, so
        it probably makes sense if I share this part of my work anyway.
        
        Change-Id: I3da9d38398e4bca373cb0000a9d34b49a36ad58a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166792
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [817d35eb829db00329ea5437d50e5c682139f505]

        -Werror,-Wunused-variable
        
        ...after 87e0feafd3690a9b58890cc28f8ba0c521bfb557 "use more concrete UNO classes
        in writerfilter (SwXDocumentSettings)"
        
        Change-Id: I4f57ef975dbee32b6f9ff6654b66483c8f1083a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166791
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [32d7935b3d506504e25737fe8ad8f0f5a2a75845]

        improve the mergedlib script
        
        by copying the improvements from the normal find-can-be-private
        script.
        
        Change-Id: I3cb23022ca33d3008af962fa99b5b0907fe753b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166783
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-28  Mike Kaganski  <mike.kaganski@collabora.com>  [826e7e79f36de0248782213e0196baebc1653e85]

        Simplify a bit
        
        Change-Id: I1db779648b273d0c732683042c74bd29666f1b10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166785
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-27  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2f5ab5b8e7bd7dd06e00153abb77a69e5d192dd2]

        Drop now unused option-stream identifiers
        
        Change-Id: Id08e41e11b8027339e58ab182739087030e66eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166754
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [faeb8adf4b12a62919fbf961f65181964cce5325]

        Simplify a bit
        
        Change-Id: Ic6d0dd0f66a258fffd0be7f458316801516aaefc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166778
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-27  Noel Grandin  <noelgrandin@gmail.com>  [47bebbdcf1bdca0ad6da48514a3befa473dd7d7b]

        fix mergelibs build
        
        since
            commit 828c1999e08c5bfad0a1d0e6e5ab07ee8bbc427e
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Wed Apr 10 16:50:51 2024 +0100
            move writerfilter inside sw
        
        Change-Id: I1c8b37510ccdd640937669f36c8086f5f65183f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166782
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-27  Noel Grandin  <noelgrandin@gmail.com>  [6c9f7050f60725b64c288179e9aacc5b5327c240]

        reduce symbol visibility in vbahelper
        
        Change-Id: I68995b10956afe4b2a2cf69fe1393d4deaaff02a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166780
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-27  Noel Grandin  <noelgrandin@gmail.com>  [0eeb12b4243b7af92b99daddbce4eee0b828b6be]

        reduce symbol visibility in sc
        
        Change-Id: I7a1c7dbe61e302584b977fdf202d041d987d0833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166777
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-27  Miklos Vajna  <vmiklos@collabora.com>  [adaea5d10d157bacf858a31f611bf3f72ec881a2]

        solenv, gdb fix error while loading the sw_writerfilter pretty printer
        
        Fixes:
        
        Traceback (most recent call last):
          File "/home/vmiklos/git/libreoffice/core-clang/instdir/program/libsw_writerfilterlo.so-gdb.py", line 23, in <module>
            module = importlib.import_module('libreoffice.' + mod)
          File "/usr/lib64/python3.6/importlib/__init__.py", line 126, in import_module
            return _bootstrap._gcd_import(name[level:], package, level)
          File "<frozen importlib._bootstrap>", line 994, in _gcd_import
          File "<frozen importlib._bootstrap>", line 971, in _find_and_load
          File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
        ModuleNotFoundError: No module named 'libreoffice.sw_writerfilter'
        
        When loading a DOCX file while gdb is attached to the soffice process.
        
        Change-Id: I383cadfe6afcd3673adecf46388376a6341dbc93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-27  Patrick Luby  <guibmacdev@gmail.com>  [05d3a99aa687ee4e1706f9403651379b7ebdad89]

        tdf#153306 prevent subpixel shifting of X coordinate
        
        HACK: for some unknown reason, if the X coordinate of the
        path's bounds is more than 1024, SkBlendMode::kExclusion will
        shift by about a half a pixel to the right with Skia/Metal on
        a Retina display. Weirdly, if the same polygon is repeatedly
        drawn, the total shift is cumulative so if the drawn polygon
        is more than a few pixels wide, the blinking cursor in Writer
        will exhibit this bug but only for one thin vertical slice at
        a time. Apparently, shifting drawing a very tiny amount to
        the left seems to be enough to quell this runaway cumulative
        X coordinate shift.
        
        Change-Id: Ic1ac8a390df51c4aa1cc3183590dce72059af6b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166766
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins

2024-04-27  Noel Grandin  <noelgrandin@gmail.com>  [6f61cb4b6333b88282978f7472d91c3c86bc628f]

        reduce symbol visibility in sd
        
        Change-Id: I3d4de2b8854278b8713992660268e764815fe738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166761
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a77caf28bac50fe8e3592416d5dedf894a02cbbb]

        use more concrete UNO classes in writerfilter (SwXTextDefaults)
        
        Change-Id: I44eb8d4561798980ff7008d843bf076fc29582c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1528564ffd6832e19ba3065d20ba7969e6697486]

        update can-be-private results file
        
        Change-Id: I2ed375d0c47391b5afaa88935294313175f7b142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166776
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [60728712f0f8bf72662da0b0e446ab416e9bf347]

        loplugin:ostr in cppu,cppuhelper
        
        Change-Id: I15c00d7a87396d07be2d10a0311f308a93e8eec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166751
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [87e0feafd3690a9b58890cc28f8ba0c521bfb557]

        use more concrete UNO classes in writerfilter (SwXDocumentSettings)
        
        Change-Id: Id668946233d55d641199634d7ceda2607107e76b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9d7548dafb44c1f0af82771a597db1404659af66]

        fix some hardcoded use of wsl.exe and fix some typos
        
        Change-Id: I6152ee61913638f828eeb201ecb26312de5f8572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166737
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [535391b31abafb02e5a4451e30a14a5605d05ff4]

        Save with newer Glade version
        
        Change-Id: If36d812ba976bc3331086b5beb5493f20c0556ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166701
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-04-27  Moritz Duge  <moritz.duge@allotropia.de>  [906e5d44f26e97830c0d005c12521a22002c01b5]

        Lazy load additional GPG key data.
        
        Change-Id: I7f52b318b083535422202dacbee928333cb3ac78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166639
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-27  Moritz Duge  <moritz.duge@allotropia.de>  [7c0a776f3a26adc3e83d304990b05133d77d05a8]

        Locally simplify getCertificatesImpl.
        
        Change-Id: I13117b36bb063b0afc498ef237b9255c0a900131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166638
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [60f65e63b4b52891c7725a151f3aeedc3a9de4ac]

        Fix dc:date export for midnight time
        
        Change-Id: I2fc40055e8949348925159a7e10f231a2573950c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166757
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f5c3ec505b83a20d272a66305bca565e9ff38b04]

        add --with-keep-awake switch to prevent going into sleep/suspend
        
        if used defaults to Awake for Windows and caffeinate for macOS
        
        Change-Id: I35f41bf1fb63af05ce2ec1a7f4d7b50b310536a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166743
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9add00445618057e16e0b7cf48c10bae255d49d2]

        Make odfvalidator and officeotron work in WSL_ONLY_AS_HELPER mode
        
        ...where e.g. CppunitTest_oox_testscene3d
        CPPUNIT_TEST_NAME=test_material_wireframe::TestBody had failed with
        
        > forced failure
        > - Error: Unable to access jarfile /mnt/d/lo/tar/odfvalidator-0.9.0-RC2-SNAPSHOT-jar-with-dependencies-2726ab578664434a545f8379a01a9faffac0ae73.jar
        
        and e.g. CppunitTest_oox_mcgr
        CPPUNIT_TEST_NAME=testAxialColorLinearTrans::TestBody had failed with
        
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 1
        > - failed to execute: sh D:/lo-wsl/core/bin/officeotron.sh C:\Users\steph\AppData\Local\Temp\test_oox_mcgr.dll2epgul.tmp > C:\Users\steph\AppData\Local\Temp\test_oox_mcgr.dll2epgup.tmp 2>&1
        > Error: Unable to access jarfile /mnt/d/lo/tar/8249374c274932a21846fa7629c2aa9b-officeotron-0.7.4-master.jar
        
        Change-Id: I094b76daff6eef2cb6a9874a4776bab9c4424f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166703
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a1e5496e4daf469840d5bcc31fede4d4d66aebfe]

        gbuild trace: disable flock for wsl-as-helper case
        
        Change-Id: Ie5db3fcc6fccedb214aec472852d8d82813fb984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166744
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [752ea376b0a1ee50c97ecc061d8bc507416838d0]

        loplugin:ostr in sal
        
        Change-Id: I7732a77fc5ac8d1f5c53052e0f4b6c7e7d70f054
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166739
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [105ce47a695cb7ea7e6abf879e1c632b7d81f054]

        Make sure that collecting redline autostyles succeeds
        
        This step was called separately in SwXMLExport::ExportAutoStyles_,
        after collectAutoStyles. collectTextAutoStylesAndNodeExportOrder
        (which is called from collectAutoStyles) sets mbCollected to true,
        and then all the code checking mbCollected/isAutoStylesCollected
        stops collecting autostyles.
        
        This moves exportTrackedChanges call to the place where all auto-
        styles are collected.
        
        Change-Id: I3f4bd0e0ff906a35b69c052e34adb6d66ef80d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166735
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [f6ca163d3f6383d3a48dbdacc5410e630d678ea1]

        gtk4 a11y: Don't create second AT context for OOoFixed
        
        Similar to how the previous
        
            Change-Id: I35196ca686e9d56f97bbf884da8b6492358e41fc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 26 09:45:39 2024 +0200
        
                gtk4 a11y: Don't create multiple AT contexts for same accessible
        
        avoids creating multiple AT contexts for the same
        accessible when the role changes, this commit addresses
        another case in which 2 GtkATContexts could be created
        for the OOoFixed which could result in segfault crashes:
        
        The OOoFixed is a GtkWidget, and GTK's `gtk_widget_init`
        already creates an AT context for widgets.
        Then, a second AT context would be created because
        `ooo_fixed_accessible_init` set an own implementation
        for GtkAccessibleInterface::get_at_context that would
        create a second AT context when it got called, resulting
        in breaking the apparent assumption that there's a 1:1 mapping
        between GtkAccessible and GtkATConetxt.
        
        No longer override `GtkAccessibleInterface::get_at_context`
        but live with the GtkATContext created for the GtkWidget,
        even if that means an a11y role cannot explicitly be set
        for these for now.
        From a first quick look at the tree in Accerciser,
        I only see one item changed its a11y role from panel to filler.
        
        The main class used. e.g. for the document content is
        LOAccessible, not OOoFixed, and setting the proper role
        for instances of that class is unaffected, see
        `lo_accessible_get_at_context`.
        
        If setting the a11y role is relevant, this could be
        done when initializing the OOoFixed instead by setting
        the "accessible-role" property [1], tested with this demo
        local change to set a dummy table-cell a11y role and
        verifying in Accerciser that it was actually set:
        
            --- a/vcl/unx/gtk3/gtkframe.cxx
            +++ b/vcl/unx/gtk3/gtkframe.cxx
            @@ -993,7 +993,10 @@ void GtkSalFrame::InitCommon()
             #else
                 m_pOverlay = GTK_OVERLAY(gtk_overlay_new());
             #if GTK_CHECK_VERSION(4,9,0)
            -    m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), nullptr ));
            +    GValue aValue = G_VALUE_INIT;
            +    g_value_init (&aValue, GTK_TYPE_ACCESSIBLE_ROLE);
            +    g_value_set_enum(&aValue, GTK_ACCESSIBLE_ROLE_CELL);
            +    m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), "accessible-role", aValue,  nullptr ));
             #else
                 m_pFixedContainer = GTK_FIXED(gtk_fixed_new());
             #endif
        
        Similar to how the dropped code did, this could use the
        a11y role from the corresponding `vcl::Window`, which is
        currently not passed, but that could be adjusted, e.g.
        by either passing the window or its accessible info
        to `SalInstance::CreateFrame`/`SalInstance::CreateChildFrame`.
        See `Window::ImplInit`, where the `vcl::Window` is currently
        only set via `SalFrame::SetCallback` after the call to
        `SalInstance::CreateFrame`/`SalInstance::CreateChildFrame`.
        
        Without this commit, for me, this crash happened about 10-30 %
        of the time when starting LO Writer with the gtk4 VCL plugin in rr,
        when Accerciser was running already.
        
        Backtrace for first AT context creation (from `gtk_widget_init`):
        
            1 gtk_at_context_create gtkatcontext.c 671 0x7f677daf129e
            2 create_at_context gtkwidget.c 8574 0x7f677dd6bcd9
            3 gtk_widget_init gtkwidget.c 2392 0x7f677dd5edbc
            4 g_type_create_instance 0x7f678ed8f2a3
            5 ?? 0x7f678ed72500
            6 g_object_new_with_properties 0x7f678ed73b96
            7 g_object_new 0x7f678ed74a41
            8 GtkSalFrame::InitCommon gtkframe.cxx 996 0x7f677edb9243
            9 GtkSalFrame::Init gtkframe.cxx 1785 0x7f677edb7bca
            10 GtkSalFrame::GtkSalFrame gtkframe.cxx 510 0x7f677edb726d
            11 GtkInstance::CreateFrame gtkinst.cxx 273 0x7f677ec7cebc
            12 vcl::Window::ImplInit window.cxx 1057 0x7f6788cf7f49
            13 ImplBorderWindow::ImplInit brdwin.cxx 1555 0x7f6788a6d45b
            14 ImplBorderWindow::ImplBorderWindow brdwin.cxx 1584 0x7f6788a6da21
            15 VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window *&, SystemParentData *&, long&, BorderWindowStyle&> vclptr.hxx 280 0x7f6788d31049
            16 WorkWindow::ImplInit wrkwin.cxx 51 0x7f6788d2f809
            17 IntroWindow::IntroWindow introwin.cxx 35 0x7f6788bb7ee0
            18 (anonymous namespace)::SplashScreenWindow::SplashScreenWindow splash.cxx 122 0x7f677c1cee61
            19 VclPtr<(anonymous namespace)::SplashScreenWindow>::Create<(anonymous namespace)::SplashScreen *> vclptr.hxx 129 0x7f677c1cc86b
            20 (anonymous namespace)::SplashScreen::SplashScreen splash.cxx 145 0x7f677c1cc5f8
            21 desktop_SplashScreen_get_implementation splash.cxx 616 0x7f677c1cc4f9
            22 std::__invoke_impl<com::sun::star::uno::XInterface *, com::sun::star::uno::XInterface * ( *&)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&> invoke.h 61 0x7f67907ef7a8
            23 std::__invoke_r<com::sun::star::uno::XInterface *, com::sun::star::uno::XInterface * ( *&)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&> invoke.h 114 0x7f67907ef745
            24 std::_Function_handler<com::sun::star::uno::XInterface * (com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface * ( *)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext *&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) std_function.h 290 0x7f67907ef63d
            25 std::function<com::sun::star::uno::XInterface * (com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const std_function.h 591 0x7f67907b6848
            26 cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments servicemanager.cxx 725 0x7f679079f26f
            27 cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments servicemanager.cxx 696 0x7f679079f143
            28 cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext servicemanager.cxx 1021 0x7f67907a56c5
            29 non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) servicemanager.cxx 1022 0x7f67907a577c
            30 desktop::Desktop::OpenSplashScreen app.cxx 2449 0x7f6792723b2c
            31 desktop::Desktop::Main app.cxx 1299 0x7f6792721362
            32 ImplSVMain svmain.cxx 229 0x7f67895bcfbe
            33 SVMain svmain.cxx 261 0x7f67895bf009
            34 soffice_main sofficemain.cxx 93 0x7f67927a5a73
            35 sal_main main.c 51 0x55fa1fbf7a5d
            36 main main.c 49 0x55fa1fbf7a37
        
        Backtrace for second AT context creation:
        
            1 gtk_at_context_create gtkatcontext.c 671 0x7f677daf129e
            2 get_at_context a11y.cxx 806 0x7f677ec389b6
            3 gtk_accessible_get_at_context gtkaccessible.c 105 0x7f677dae2d4b
            4 gtk_accessible_platform_changed gtkaccessible.c 1081 0x7f677dae427d
            5 gtk_widget_set_focusable gtkwidget.c 5255 0x7f677dd65086
            6 GtkSalFrame::InitCommon gtkframe.cxx 1157 0x7f677edb9d15
            7 GtkSalFrame::Init gtkframe.cxx 1785 0x7f677edb7bca
            8 GtkSalFrame::GtkSalFrame gtkframe.cxx 510 0x7f677edb726d
            9 GtkInstance::CreateFrame gtkinst.cxx 273 0x7f677ec7cebc
            10 vcl::Window::ImplInit window.cxx 1057 0x7f6788cf7f49
            11 ImplBorderWindow::ImplInit brdwin.cxx 1555 0x7f6788a6d45b
            12 ImplBorderWindow::ImplBorderWindow brdwin.cxx 1584 0x7f6788a6da21
            13 VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window *&, SystemParentData *&, long&, BorderWindowStyle&> vclptr.hxx 280 0x7f6788d31049
            14 WorkWindow::ImplInit wrkwin.cxx 51 0x7f6788d2f809
            15 IntroWindow::IntroWindow introwin.cxx 35 0x7f6788bb7ee0
            16 (anonymous namespace)::SplashScreenWindow::SplashScreenWindow splash.cxx 122 0x7f677c1cee61
            17 VclPtr<(anonymous namespace)::SplashScreenWindow>::Create<(anonymous namespace)::SplashScreen *> vclptr.hxx 129 0x7f677c1cc86b
            18 (anonymous namespace)::SplashScreen::SplashScreen splash.cxx 145 0x7f677c1cc5f8
            19 desktop_SplashScreen_get_implementation splash.cxx 616 0x7f677c1cc4f9
            20 std::__invoke_impl<com::sun::star::uno::XInterface *, com::sun::star::uno::XInterface * ( *&)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&> invoke.h 61 0x7f67907ef7a8
            21 std::__invoke_r<com::sun::star::uno::XInterface *, com::sun::star::uno::XInterface * ( *&)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&> invoke.h 114 0x7f67907ef745
            22 std::_Function_handler<com::sun::star::uno::XInterface * (com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface * ( *)(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext *&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) std_function.h 290 0x7f67907ef63d
            23 std::function<com::sun::star::uno::XInterface * (com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext *, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const std_function.h 591 0x7f67907b6848
            24 cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments servicemanager.cxx 725 0x7f679079f26f
            25 cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments servicemanager.cxx 696 0x7f679079f143
            26 cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext servicemanager.cxx 1021 0x7f67907a56c5
            27 non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) servicemanager.cxx 1022 0x7f67907a577c
            28 desktop::Desktop::OpenSplashScreen app.cxx 2449 0x7f6792723b2c
            29 desktop::Desktop::Main app.cxx 1299 0x7f6792721362
            30 ImplSVMain svmain.cxx 229 0x7f67895bcfbe
            31 SVMain svmain.cxx 261 0x7f67895bf009
            32 soffice_main sofficemain.cxx 93 0x7f67927a5a73
            33 sal_main main.c 51 0x55fa1fbf7a5d
            34 main main.c 49 0x55fa1fbf7a37
        
        Backtrace of the segfault:
        
            Thread 1 received signal SIGSEGV, Segmentation fault.
            0x00007f677deaec8e in GTK_IS_ACCESSIBLE_TEXT (ptr=0x55fa21196bb0) at ../gtk/gtkaccessibletext.h:35
            35      G_DECLARE_INTERFACE (GtkAccessibleText, gtk_accessible_text, GTK, ACCESSIBLE_TEXT, GtkAccessible)
            (rr) bt
            #0  0x00007f677deaec8e in GTK_IS_ACCESSIBLE_TEXT (ptr=0x55fa21196bb0) at ../gtk/gtkaccessibletext.h:35
            #1  0x00007f677deb1d88 in gtk_atspi_connect_text_signals (accessible=0x55fa21196bb0, text_changed=0x7f677dea1365 <emit_text_changed>, selection_changed=0x7f677dea140b <emit_text_selection_changed>, data=0x55fa2119d860)
                at ../gtk/a11y/gtkatspitext.c:1037
            #2  0x00007f677dea2fea in register_object (root=0x55fa2119e210, context=0x55fa2119d860) at ../gtk/a11y/gtkatspicontext.c:1442
            #3  0x00007f677dea8138 in on_registration_reply (gobject=0x55fa21179030, result=0x55fa39240d80, user_data=0x55fa2117a4a0) at ../gtk/a11y/gtkatspiroot.c:531
            #4  0x00007f6783cc8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #5  0x00007f6783cc9b83 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #6  0x00007f6783d269da in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #7  0x00007f6783cc8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #8  0x00007f6783cc8f1d in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #9  0x00007f6785b110d9 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #10 0x00007f6785b14317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #11 0x00007f6785b14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12 0x00007f677ec77d0f in GtkSalData::Yield(bool, bool) (this=0x55fa1fe8e000, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
            #13 0x00007f677ec7dbd3 in GtkInstance::DoYield(bool, bool) (this=0x55fa1fe8deb0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:435
            #14 0x00007f678959a64c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:394
            #15 0x00007f6789599f5b in Application::Yield() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:482
            #16 0x00007f6789599cf2 in Application::Execute() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:369
            #17 0x00007f679272304c in desktop::Desktop::Main() (this=0x7ffdf3dcc768) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1615
            #18 0x00007f67895bcfbe in ImplSVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:229
            #19 0x00007f67895bf009 in SVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:261
            #20 0x00007f67927a5a73 in soffice_main() () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:93
            #21 0x000055fa1fbf7a5d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #22 0x000055fa1fbf7a37 in main (argc=2, argv=0x7ffdf3dcc978) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        [1] https://docs.gtk.org/gtk4/property.Accessible.accessible-role.html
        
        Change-Id: If4fdcd249aaada846934c3e967d654e3266ad73d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166709
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [707e4f12f11efa3ef575adf549cafb8ecdbfa045]

        gtk4 a11y: Don't create multiple AT contexts for same accessible
        
        In the `GtkAccessibleInterface::get_at_context` implementations,
        do not create a new `GtkATContext` if the accessible role has
        changed.
        
        This broke the apparent assumption that there's a 1:1 mapping
        between `GtkAccessible` and `GtkATContext` and resulted in
        segfaults seen quite often when starting LO Writer
        with the gtk4 VCL plugin while Accerciser was also running.
        
        For me, this was even more reproducible when running in rr
        (crashed reliably on start).
        
        LO has the `AccessibleEventId::ROLE_CHANGED` event type
        to indicate role changes, but GTK 4 doesn't support
        changing the initial role any more.
        
        Quoting the
        GtkAccessible doc [1]:
        
        > The role cannot be changed after instantiating a
        > GtkAccessible implementation.
        
        And the accessibility section in the GTK 4 doc [2] says:
        
        > Each role is part of the widget’s instance, and cannot be changed over
        > time or as the result of a user action. Roles allows assistive
        > technology applications to identify a UI control and decide how to
        > present it to a user; if a part of the application’s UI changes role,
        > the control needs to be removed and replaced with another one
        > with the appropriate role.
        
        Sample backtrace:
        
            Thread 1 received signal SIGSEGV, Segmentation fault.
            0x00007f0399aa0636 in get_parent_context_ref (accessible=0x55a141b5a9b0) at ../gtk/a11y/gtkatspicontext.c:462
            462           res = gtk_at_spi_root_to_ref (self->root);
            (rr) bt
            #0  0x00007f0399aa0636 in get_parent_context_ref (accessible=0x55a141b5a9b0) at ../gtk/a11y/gtkatspicontext.c:462
            #1  0x00007f0399aa43ba in gtk_at_spi_context_get_parent_ref (self=0x55a141b615c0) at ../gtk/a11y/gtkatspicontext.c:1956
            #2  0x00007f0399a9dc75 in collect_object (self=0x55a1469113a0, builder=0x7fff90e1a220, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:131
            #3  0x00007f0399a9e2f2 in emit_add_accessible (self=0x55a1469113a0, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:235
            #4  0x00007f0399a9eac1 in gtk_at_spi_cache_add_context (self=0x55a1469113a0, context=0x55a141b615c0) at ../gtk/a11y/gtkatspicache.c:436
            #5  0x00007f0399aa8152 in on_registration_reply (gobject=0x55a141b62060, result=0x55a14e28a890, user_data=0x55a141b64770) at ../gtk/a11y/gtkatspiroot.c:533
            #6  0x00007f039fac8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #7  0x00007f039fac9b83 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #8  0x00007f039fb269da in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #9  0x00007f039fac8ee3 in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #10 0x00007f039fac8f1d in  () at /lib/x86_64-linux-gnu/libgio-2.0.so.0
            #11 0x00007f03a0b110d9 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #12 0x00007f03a0b14317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #13 0x00007f03a0b14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #14 0x00007f039a877d9f in GtkSalData::Yield(bool, bool) (this=0x55a140869000, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkdata.cxx:405
            #15 0x00007f039a87dc63 in GtkInstance::DoYield(bool, bool) (this=0x55a140868eb0, bWait=true, bHandleAllCurrentEvents=false) at vcl/unx/gtk4/../gtk3/gtkinst.cxx:435
            #16 0x00007f03a539a64c in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:394
            #17 0x00007f03a5399f5b in Application::Yield() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:482
            #18 0x00007f03a5399cf2 in Application::Execute() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:369
            #19 0x00007f03ae52304c in desktop::Desktop::Main() (this=0x7fff90e1c288) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1615
            #20 0x00007f03a53bcfbe in ImplSVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:229
            #21 0x00007f03a53bf009 in SVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:261
            #22 0x00007f03ae5a5a73 in soffice_main() () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:93
            #23 0x000055a13fefca5d in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #24 0x000055a13fefca37 in main (argc=2, argv=0x7fff90e1c498) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        From valgrind output:
        
            (soffice:972353): Gtk-CRITICAL **: 09:28:48.066: gtk_accessible_get_accessible_parent: assertion 'GTK_IS_ACCESSIBLE (self)' failed
        
            (soffice:972353): Gtk-CRITICAL **: 09:28:48.067: gtk_accessible_get_at_context: assertion 'GTK_IS_ACCESSIBLE (self)' failed
            ==972353== Thread 1:
            ==972353== Invalid read of size 8
            ==972353==    at 0x19077636: get_parent_context_ref (gtkatspicontext.c:462)
            ==972353==    by 0x1907B3B9: gtk_at_spi_context_get_parent_ref (gtkatspicontext.c:1956)
            ==972353==    by 0x19074C74: collect_object (gtkatspicache.c:131)
            ==972353==    by 0x190752F1: emit_add_accessible (gtkatspicache.c:235)
            ==972353==    by 0x19075AC0: gtk_at_spi_cache_add_context (gtkatspicache.c:436)
            ==972353==    by 0x1907F151: on_registration_reply (gtkatspiroot.c:533)
            ==972353==    by 0x12E72EE2: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
            ==972353==    by 0x12E73B82: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
            ==972353==    by 0x12ED09D9: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
            ==972353==    by 0x12E72EE2: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
            ==972353==    by 0x12E72F1C: ??? (in /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0.7800.4)
            ==972353==    by 0x130620D8: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7800.4)
            ==972353==  Address 0x70 is not stack'd, malloc'd or (recently) free'd
            ==972353==
        
        [1] https://docs.gtk.org/gtk4/iface.Accessible.html
        [2] https://docs.gtk.org/gtk4/section-accessibility.html
        
        Change-Id: I35196ca686e9d56f97bbf884da8b6492358e41fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166708
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [59ad8d6d15c893e8873f4afb55a24ab3e58fa2c1]

        loplugin:ostr in codemaker,unoidl
        
        Change-Id: I75f5531023f31da029491ce4a078005eebbfe59e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166738
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fe0d8555150949bb8729c656af62917ffc48bbf8]

        Use less SdOptionsLayout->IsDragStripes/SetDragStripes in favor of officecfg
        
        Change-Id: I0c0e2dd57d1f1408f85bca4b6ee3bfcebae1cf22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166596
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c724b81b033a9ff968a1a63d66005d48a6b97e57]

        Use less SdOptionsLayout->IsMoveOutline in favor of officecfg
        
        Change-Id: I848e11a64a42b670254c88b791d0b2a2534d112f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166595
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [48e07052be600a5abf8ef4cbec20e1122e703b7e]

        Drop now unused GetOptionStream class
        
        Change-Id: Iddb1fbb437f0f66c551e9231d79511caf1edafb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166635
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [aabf18d56194405b28afcd814c41bbba73f5e9b9]

        Configuration_filter.mk: create RESPONSEFILEs using gb_var2file
        
        using echo ... | sed won't help with command-line limits and doing the
        simple substitution by make saves spawning a few sed processes
        
        Change-Id: I4ee81d26b3df18ebf82140f00c823cb7543cac1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166411
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b68d717360d7141de62bf9391d8af5b073333f9d]

        Support --with-junit/hamcrest in WSL_ONLY_AS_HELPER mode
        
        ...where it failed with
        
        > checking for JUnit 4... ./configure: line 47354: cygpath: command not found
        
        Change-Id: I56c930b6c8b738b39f26766f90476c32efb383e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166508
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9bd93466e47c3a472b273f3846169afbdf063885]

        Honor TMPDIR configure option in WSL_ONLY_AS_HELPER mode
        
        (It needs to be passed-in as a TMPDIR=/mnt/c/... style path, because configure
        uses it early on and otherwise fails with some
        
        > checking build system type... config.guess: cannot create a temporary directory in C:/...
        
        error.)
        
        Change-Id: I798ed7dd363eb5fd7614c5984861f77cf9d38266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166506
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [649314399483331244538128149ebd0556166540]

        Don't hardcode build as x86_64 for WSL_ONLY_AS_HELPER
        
        ...to also make it work builds on aarch64
        
        Change-Id: Ibc502b11eedceddb84481c2ad5d351bf8404c8cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166501
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [683d9496bd993c638d7f44af8d03b86b9ed8faaa]

        use strawberry perl for installation packaging in wsl-as-helper case
        
        changing it to git-bash perl can probably be done, but would require
        more changes to the path handling in the packaging code
        
        Change-Id: I9a31ee6e9f122a2c167e11f5b4f73b18c5c0fa81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166343
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [84c80da9751c2d89655b0cfdda2f7ad581d1b15e]

        use strawberry perl in wsl-as-helper case for openssl
        
        it needs modules that are not available in git-bash perl, and strawberry
        perl is already used as a way to get windres and similar utilities
        Might want to revisit that to streamline the dependencies
        
        Change-Id: Ieb1c83831292677e9930d376d9d71283c6a1140e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166342
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b77bcf2838e2ab233c61cff8237f2847bd910dcb]

        run autoconf/autoreconf via wsl in wsl-as-helper case
        
        Change-Id: I9bcdfe352fd378e1bf09e15b8d8f7dcea82c0b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166341
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5897420b0df5222ef87dce60668df902a5e279a]

        run bison, flex and nasm via wsl in wsl-as-helper case
        
        Change-Id: Ic3e82b72605cd0b5458bd31ab5ff5285adb3db75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166340
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f7fe6a0bed2c2aee19535a26181a2edfb103e587]

        run doxygen via wsl in wsl-as-helper case
        
        Change-Id: I534bcc8b07aea1637a3aea01cd1c5da998833a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166339
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1b9482e1d21aec6c40e724efb9109fe9f9ed3e49]

        Drop unused RETURN_KIND_HFA_FLOAT/DOUBLE from msvc_win32_arm64 UNO bridge
        
        Change-Id: I8c6fbed8c587affda69285c203a3a93fa2e2e603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166699
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b87da3e9402c8b56ce2a16213802224f9288de4d]

        run gperf via wsl in wsl-as-helper case
        
        also split up the gperf commands when generating sw/generated/tokens.cxx
        
        wsl has trouble appending using shell redirects, so use separate targets
        and use cat in the final processing step for tokens.cxx
        see also https://github.com/microsoft/WSL/issues/4400
        
        Change-Id: Id7a24d060e9be71113ec2827a389d347456f6522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166338
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f7c5dd5f95bf16862668d3c16718cff0ab5561da]

        run zip via wsl in wsl-as-helper case
        
        Change-Id: I0c5b75c39c211aba08ae6d56f02bcc93ca11e2bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166337
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9c6eece2c427473fafb41d9b5ee66e93363ecc8f]

        extracting tarballs that call helpers to uncompress require unix-style paths
        
        Change-Id: I528e343fb5b22194b4639649fbfc04c0583f77c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166336
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4c86718e78c6b18c84774e48ca025694364c251a]

        initial support for running autogen.sh inside wsl from git-bash
        
        Change-Id: I4272ea817a48880fd4206d6c73add7ccb8c4f6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166335
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f618f08cc310f20e2888cf4e5e99cfeb8fbd15b7]

        simplify some sed rules/statements and use proper quoting
        
        make removes partially built targets in case the rule exits with
        non-zero status, so creating a temp file and moving it is not necessary
        also use single quotes for cases where characters might be interpreted
        by the shell
        Also combine multiple sed calls into a single call of sed with multiple
        expressions and replace additional "grep -v foo" with corresponding sed
        delete command
        
        Change-Id: Iff7e3b962175e347e5ed100a87c96fbaeef39985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166410
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1a774927f1bd3e9e171732e3636d61ba46ecdc6d]

        look for java, javac and javadoc with the .exe suffix on windows
        
        while it doesn't make a difference from within cygwin or from within
        git-bash, it does affect checks from wsl into windows since the version
        without .exe isn't found/only the .exe does actually exist as a file<.
        Cygwin portion already explicitly checked for the .exe to determine
        whether the JDK home is valid, so just use it like that.
        
        Change-Id: Ifc0238f54ed4326de27840136589e64fcdb6f3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166334
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d9d976cd0ab0b52647e562d5c9cc3e492f71ee5d]

        use unix paths for dir tests and prefer PathFormat…
        
        over manual cygpath calls. Since PathFormat checks whether the path is
        8.3 compatible/in case of spaces or other incompatible characters remove
        some superfluous checks
        also drop a workaround for VS2017 (minimum requried version is 2019)
        
        Change-Id: I2d098cf323c96862c06acf7605abacbefe8a35ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166333
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8cb68694c8ac58c1ae85f3bc36f7bf81707e4783]

        configure.ac: split registry path from registry key
        
        in preparation for an upcoming change to read values using reg.exe
        
        Also fixes a bug in determining UCRTVERSION from the Windows SDK's
        ProductVersion registry value (misses trailing .0)
        
        Change-Id: I66236ba6bf38393e6f7c7ab83706657a6e96769c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166332
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a97d983b501b28a2b5a9387efb6206b50097ffa1]

        don't throw away command output when packaging installsets
        
        and adjust installer to work with MSWin-style perl (like strawberry
        perl)
        
        Change-Id: I9305c7cb6ef72560bbf77626f113f3ee439b3ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166331
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3c54cb2a9d731d8315f32ad8a4ced2a8d6b508de]

        add MSYS_NO_PATHCONV=1 to prevent MSYS auto-magic
        
        git-bash/MSYS tries to resolve anything that looks like a path (i.e.
        anything starting with a /) - if the "target" doesn't exists, it just
        prepends the MSYS installation dir and breaks all kind of stuff.
        You could escape those with double-slash at the beginning, but that
        would mean lots of noise/unnecessary changes in pretty much every
        makefile, so just getting rid of that behavior is much better.
        
        ant and some externals however rely on MSYS path-conversion, so unset
        MSYS_NO_PATHCONV for those. Ant does its own checks whether it
        runs under cygwin or msys, and easier to please externals using the
        autoconversion than to add patches to force them into compliance…
        
        Change-Id: Ie80964e40c53ace80adb4707aae0db63ebc4ee4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166330
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0d822662ed178a6f45e25e5c1dde9b486796b404]

        drop some unused suppressions
        
        Change-Id: Ifc15ca8a9e9d25df1a0da12b8139d063f5d2e91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166698
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [556af85ae78d1d11f8b3c59953342b770e25620c]

        use more concrete UNO in writerfilter
        
        elimate the TextFactory stuff, since it is the same object as the
        TextDocument
        
        Change-Id: I10577f2ac9ffa4d079b96052f7879a83e38f1cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-26  kubak  <kuba@openoffice.com.pl>  [e7f96e960cd0e0fe0c25662920bd34b096aad398]

        MSI: Fix use of illegal character "@"
        
        ICE03 ERROR Invalid identifier;
        
        Example:
        
        flt14.mo gid_file_res_flt_lang__libreoffice_program_resource_ca@valen_dcb80460e flt.mo 55482 2051 16384 13967
        
        We use the illegal "@" sign. Changing to underscore "_".
        
        https: //learn.microsoft.com/en-us/windows/win32/msi/identifier
        Change-Id: I50c40a3cde3f4b57b71ddda9876f27db08aa0970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166580
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-26  kubak  <kuba@openoffice.com.pl>  [8a24efd16d1515ff806406d37d234e4ac7940c45]

        MSI: Fix use of illegal character in table Binary
        
        ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows61-KB2999226-x64msu
        ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows81-KB2999226-x64msu
        ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows8-RT-KB2999226-x64msu
        
        We use the illegal "-" character.
        
        https: //learn.microsoft.com/en-us/windows/win32/msi/binary-table
        https: //learn.microsoft.com/en-us/windows/win32/msi/identifier
        Change-Id: I44aea358964c085599ab42f134535fa97840dd26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166567
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [546741148863ae0b2a25cc994a7323c8113cb573]

        tdf#114287 tdf#159366 xmloff: ODF import: revert text:list override
        
        This reverts commit ade0a153f453500f15343380ac937252992733e0 "tdf#114287
        xmloff: ODF import: fix text:list override of list style" and subsequent
        commits 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d and
        1b2a6b98291cf8b7022951be19b915fe2a9e18e6.
        
        It turns out that there is actually a paragraph in ODF 1.2 and later
        that gives paragraph's indent priority over the list style's, which i
        unfortunately missed when investigating the above issues:
        
          17.20  <style:list-level-label-alignment>
          ...
        
          The fo:text-indent and fo:margin-left attributes are evaluated only
          for paragraphs inside list items whose paragraph styles do not specify
          them. If one of the two properties, or both, are specified by the
          paragraph style, the text indent and/or left margin are taken from the
          paragraph style. In this case the paragraph style's properties are
          used to determine the indent and margin for the text lines and thus
          also the alignment position.
        
        This is usually interpreted as "on the same level", so applying a
        list-style at a paragraph style overrides the indents inherited from a
        parent paragraph style, but if the style then specifies its own indents
        that overrides the list style's indents.
        
        Furthermore it turns out that Google Docs now imports this bugdoc the
        same way as LO 7.5 does; unclear if that changed recently (it shows
        it like Word does in the preview, but like LO 7.5 does after opening it).
        
        This means the way MS Word imports the bugdoc, which remains unchanged,
        now looks like a bug and we should not change LO to be compatible with
        it (when the same structure is created in Word, storing to ODF and
        loading again, it looks different too).
        
        Change-Id: I0c65bde38de9e6fcbccec55899c60c3245adb5ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166309
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [ac05822b8957d80018d3ce1cbf97cd9faa0dfe99]

        tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuse
        
        This is obviously wrong, as ALG just pointed out: the aIter is at the
        end after the 1st loop, so the 2nd loop does nothing.
        Thx Gabor for checking all the reported bugs.
        
        (regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
        
        Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5d75f487592d17c02fccbf21a0edef437067f30]

        libgpg-error: Upgrade to 1.49
        
        Change-Id: I1bd83294e58952ebdbaaf0362bd8675c1911b9be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166697
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8d775b92594b70a3f626006148365582c06f813f]

        Use Windows dllmgr-x64 also for aarch64
        
        At least, CppunitTest_basic_macros CPPUNIT_TEST_NAME=Coverage::Coverage_Iterator
        (which exercises it in basic/qa/basic_coverage/test_declare_from_dll.bas)
        succeeds.
        
        Change-Id: Ife90d5b84d5fb7bb4948cfeaf48180a6929a1dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166695
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7437b842c420a43b85156f34146f27fc6b34c729]

        Drop now unused sdiocmpt.cxx
        
        Change-Id: Ibba331a536bbd6f228df005c3488a722a3631d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166634
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-26  Noel Grandin  <noelgrandin@gmail.com>  [54fced70718828bb73f5485b54445501ebf4fcdc]

        mStyleIdMap can be static const
        
        Change-Id: I4df2b1152605c175d7959b6739ba0068539bed6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d84c900bb78168dd9bd0fd1ea02c0769a5ba5f14]

        tdf#156955 Properly align text when tabstop is outside of textbox
        
        Co-authored-by: Tibor Nagy <tibor.nagy.extern@allotropia.de>
        
        Change-Id: I9f7ead01d93e0701f8df30ad1dcfe24ef0af7067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162113
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2b35405bce75d75e14fa376c80f26e1332b70fe9]

        Fail early when external tarball can't be fetched
        
        ...so that the error output is
        
        > fetching libabw-noexist-test.tar.xz
        >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
        >                                  Dload  Upload   Total   Spent    Left  Speed
        >   0   153    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
        > curl: (22) The requested URL returned error: 404
        
        rather than a somewhat misleading
        
        > fetching libabw-noexist-test.tar.xz
        >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
        >                                  Dload  Upload   Total   Spent    Left  Speed
        > 100   153  100   153    0     0   2463      0 --:--:-- --:--:-- --:--:--  2467
        > ERROR: expected checksum for libabw-noexist-test.tar.xz is e763a9dc21c3d2667402d66e202e3f8ef4db51b34b79ef41f56cacb86dcd6eed
        
        (see the mailing list sub-thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2024-April/091882.html> "Re:
        Uploading external tarballs to <https://dev-www.libreoffice.org/src>?")
        
        Change-Id: I91b7f37601eb69b950024ed3e1b6924ddd039379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a0a581ead18f030f59d203539706de0230746cae]

        annot: moved more of Annotation and dependencies into svx
        
        Moved the holder of annotations from SdPage to SvxPage, so that
        the vector holding the annotations and accessors are on SvxPage
        and adapted the code.
        
        This also changes the type od most parameters on most methods
        from sd::Annotation to sdr::annotation::Annotation and adapted
        the code.
        
        Moved AnnotationEnumeration into svx, as it was needed in svx
        already.
        
        Change-Id: Iab17aa881443f58adfb9158959db00ed24076279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166494
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d126f57fd4bbba7ac0e4218ed30524cb9bbb5859]

        annot: move UndoAnnotation and deps. to svx, adapt svx Annotation
        
        This moves UndoAnnotation and dependent classes to svx, refactor
        the code to in sdr::annotaion::Annotation so annotations in sd
        module still work as they have before.
        
        Change-Id: I3769069a636c30c55bc1fcf2406d990f1b44baa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166493
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d119f504bf279a1bbe2e5840cfd5cbfa295fca8f]

        tdf#158305 Store Convert to Polygon dialog settings correctly
        
        Change-Id: I4d732adb8365cd4ecddf372b5646c14c7ffe828c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166631
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7bd190858f5f044225eaad03ef41f736bfbbd8da]

        tdf#158304 Store Cross-Fading dialog settings correctly
        
        Change-Id: I3b8de3590a83def6fd6c77a504c69085dc2f0361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166633
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [febb429d5e02c2d6082194320ea689e8a01a3180]

        Drop stale pubdlg.cxx file
        
        Seems to be unused since
        commit 28b6480c6bdd179f3943f768926b7f196226c768
        tdf#105303: Drop html export wizard
        
        Change-Id: I9d7aa80d64df6f68af51cd026ef49d6a61cf9cfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166632
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [3029019cd930fd672ceda413376a26a33fdbad38]

        Use less SdOptionsLayout->IsRulerVisible/SetRulerVisible in favor of officecfg
        
        Change-Id: I0f6b38d364fb880e8dcd3cae08f2c5298cb7a5bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166594
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [cb80115f79e59720406ea245d7d914487ab343d8]

        Use less SdOptionsLayoutItem in Options - Impress - View
        
        in favor of officecfg
        
        Change-Id: I3aea51bf0c1a2184163c07bf42b26164311843de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166593
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins

2024-04-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [35772a003bb30be61f8ba8abe805455e41db0e1e]

        tdf#126573 Add Excel2021 array function SEQUENCE to Calc
        
        Add new function called SEQUENCE to the function list.
        
        (TODO: dynamic array in separate patch, oasis proposal)
        
        Change-Id: I9fa6f2c83536536987542cc00a9eec5c196ada8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166245
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2177acbc8a3befb5367895709b3447717b98ea33]

        add debuginfo generation flags to internal nss
        
        Change-Id: I34c9df0f94121013dada738ecd2b6bf91d138024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166528
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [495b5db74f0db59395ff68bacc8d8ca67595b66e]

        sw: check GetUserCall
        
        It might return nullptr
        See https://crashreport.libreoffice.org/stats/signature/SwFEShell::ShouldObjectBeSelected(Point%20const%20&)
        
        Change-Id: Ia0ed355a7eb9084b9f57163ffbfe6b549c8bdb3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166642
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-26  Julien Nabet  <serval2412@yahoo.fr>  [73229b441f0f0aa6ab4e3ae051f9d09f683361fc]

        Typo gb_Trace_ liblangtrag instead of liblangtag
        
        Change-Id: Ib4b66549725c6010b1c9b9baf11674f86ac5f1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166652
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-04-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7bbeba7fe8b094e218bd57f613eaefdf47ff88de]

        Save with newer Glade version
        
        Change-Id: I37188d82d87724c70b8e33bc65e56f091d5587e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166623
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4c8dce819a9816456a996ceea1890cc2835df590]

        Save with newer Glade version
        
        Change-Id: I0c546633d4d5db4de59ba7a3819c4631fa50e192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166624
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a00294a6d56ff7f4da8c6ae426eca95d39e38981]

        Simplify a bit
        
        Change-Id: Ia724b8dcfbd3e1b3744bbc26e005831d30b5ce38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166691
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-26  Julien Nabet  <serval2412@yahoo.fr>  [fe3b209596c065395c6589deb886fa1449c04540]

        gb_Trace_EndRange MOC instead of CXX (CustomTarget_wasm-qt5-mandelbrot_moc)
        
        Change-Id: Idb1457933a784b5ee4364e435d439f544ae28013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [edd6243b1f607f5e60d1bbe869e2e236bc021177]

        Upgrade external/boost to latest Boost 1.85.0
        
        <https://dev-www.libreoffice.org/src/boost_1_85_0.tar.xz> has been generated (on
        Fedora 40) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.85.0/source/boost_1_85_0.tar.bz2
        > $ printf '7009fe1faa1697476bdc7027703a2badb84e849b7b0baad5086b087b971f8617 boost_1_85_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_85_0.html>
        > boost_1_85_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_85_0.tar.bz2
        > Unpacking boost_1_85_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_85_0.tar.xz ...
        > Cleaning up ...
        > 4e23218ff5036d57afd20f7cdab2e94cdbf6ba9c509d656ace643a81c40a985a  boost_1_85_0.tar.xz
        > Done.
        
        Three patches failed to apply:
        
        * external/boost/boost_1_59_0.property_tree.wreturn-type.patch ("aka MSVC
          warning C4715: not all control paths return a value") should no longer be
          necessary after
          <https://github.com/boostorg/property_tree/commit/e7c4005098749d878375be9ea8778b420ee89b86>
          "Use BOOST_UNREACHABLE_RETURN at the end of function" (the referenced
          <https://svn.boost.org/trac/boost/ticket/11501> appears to no longer be
          reachable, though).
        
        * The boost/math parts of external/boost/Wundef.patch.0 are obsoleted by
          <https://github.com/boostorg/math/commit/30cb6fc1fe871046c2880c8c39b0cea5b91a7f2c>
          "Fix -Wundef warnings".
        
        * external/boost/boost-emscripten-noshm.patch.0 is obsoleeted by
          <https://github.com/boostorg/interprocess/commit/94ead3e59d197e0d8d908b7e8918673bed51fa34>
          "emscripten doesn't support shm".
        
        Change-Id: Id2d86d25a60097f3f0852063b5ac2a8220f6b479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166656
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [1112a2bea0cb260fd64360b679c3f0f5c495e16e]

        tdf#157240: also set font color together with font
        
        Commit b008831a5545e5a777d77547ef96b9798d795f30 (tdf#152990 set the font
        after the MapMode is (potentially) set, 2023-01-14) had moved setting of
        font forward, but left setting the font color behind. This fixed that.
        
        Change-Id: I73fadc7c139da3b6f84b7fc875c585d02fc1c719
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166654
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [e73e117c1309b586f59a4c901aa30117f457727c]

        This block seems obsolete now, try to drop it
        
        ... and see if something breaks. Unit tests pass.
        Likely obsoleted by commit 69ed893087f89d176a5ec4b263ce8d75774be72b
        (tdf#160253: fix list identifier export decision code, 2024-04-24).
        
        Change-Id: I4fde19e1047104686df22053c9b140819ea72963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166651
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [0568384c5d160000748aa58b544dbbd2a18a85a1]

        Make sure to export autostyles from inside frames anchored to page
        
        These frames need to export content when collecting autostyles, too.
        Regression after commit 69ed893087f89d176a5ec4b263ce8d75774be72b
        (tdf#160253: fix list identifier export decision code, 2024-04-24).
        
        Change-Id: If036cab9327e33d32f494fc765bae8e2d685907c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166650
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dac6cbd2155ca47d9152fbcc523f52aee6386832]

        fix mismatching gb_Trace_StartRange and gb_Trace_EndRage
        
        Change-Id: Ie4da22b05bf9219da811778bfb892e3d6c9de6c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166636
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a9ad50c2de829a21ba79baa061597487e30877dc]

        Fix typo
        
        Change-Id: I8ab3728b0b5cf414582849e9efe36a3c9df43f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166646
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1583d11fe8f6c7d3b7956c5a94e8183d0a92d333]

        Fix typo
        
        Change-Id: I0ac2c408124e620b96736088c3955c99ce484d49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166645
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1eb1763ff45253560d7b64ff19a542e73e68822d]

        Remove exec bits on docx
        
        Change-Id: I9920aef83472dfc4f70e0f707a83eb0f4eef2dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166644
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [90548039f09d4bc773bf6879a62d544adfa175db]

        svx: Avoid divide by 0
        
        See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs()
        
        Change-Id: Ie08c54d1a1b40bcc42da9f81c893f496fff433a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166626
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [15d19cb69db25f99f7225c2708cda4a17cc7a053]

        Move ObjectInspectorWidgets code into cxx file
        
        having this much code in a header file is not a good idea
        
        Change-Id: Ic21eca651335bb282ebbf9434811ae591b7e0b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-25  Noel Grandin  <noelgrandin@gmail.com>  [d8d2a68271b5263777d3be8afd0bd39bd076bb87]

        use more concrete UNO classes in writerfilter
        
        starting with SwXTextDocument.
        
        Replace some UNO_QUERY_THROW with
           if (!foo)
               throw uno::RuntimeException()
        because rtl::Reference does not have UNO_QUERY_THROW
        constructors
        
        Change-Id: I98e34f2faa6e94d0afbdfbd4e9e92a43b0a921f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166565
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7414fc841803201991d7e8e7b2959a89cca5a222]

        Adapt queryInterface in fixed msvc_win32_arm64 UNO bridge
        
        ...where the function's argument is in x2, not x1 (see commit message of
        ae6ee262d7649222a137f8722886a10db274ddf5 "Some fixing of msvc_win32_arm64 UNO
        bridge" for details)
        
        Change-Id: I00ef5df1ebad4609918c0c6845ebdcfe810f6152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166622
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [dee3e2d7c8d412951099e4425e6ece24431cd98d]

        Related tdf#87676 Enable text formatting toolbar when in a text box
        
        Use the second row (hiding the shapes toolbar) to show the text formatting
        toolbar when the user is inside a text box.
        
        This helps users to do basic text formatting at the place where they
        expect the controls from Writer, Calc, etc.
        
        Otherwise, when the Sidebar is switched to another Deck, finding the text formatting
        functions can be hard in the classic toolbar layout.
        
        Change-Id: I8d6f54e6f3f44917b0c89ae699c2798e4f6b86a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166621
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2024-04-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bdc90ee923fc68f57fc7234192be2ba512797775]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to db688bf5d40a94939f8e6ab35744c267d35b39ab
          - tdf#132253 Hyperlink tab in Characters is gone.
            
            Change-Id: Ic146695c24e488fc5c0d0cebce2e43769ac37a7a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166640
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-25  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [f7bcb8a9ee79008c8cd598626b8939085eb8074a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 686da2a7ece1ce03db28cfba2747870c88a9ca2e
          - tdf#156273 tdf#155882 update Navigate By documentation
            
            - update since changes in:
               - 7.0: from icon that opens a toolbar, to listbox
               - 7.1: commands hidden by default in Find toolbar
               - 7.2: Recency added to Navigate By
            - hyperlink relevant pages and embed sections
            - correct command labels
            - add bookmarks
            - related tdf#156332: remove space breaking HID linking
            - paragraphs for categories that need explanations
            - remove obsolete <ahelp> and bookmarks
            
            Remaining doubts:
            - how "Wrong table formula" works (broken?)
            
            Change-Id: I1de013be320d31396076f4ccec991a52a14e1db5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166096
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2024-04-25  Michael Weghorn  <m.weghorn@posteo.de>  [0c3fb583b9fdbbc634a5cabe578d3e717c36bff6]

        gtk4: Ignore "input-purpose" for GtkSpinButton
        
        "input-purpose" is a property of GtkEntry, for both,
        GTK 3 [1] and GTK 4 [2].
        
        However, while the GTK 3 GtkSpinButton derives from GtkEntry [3],
        the GTK 4 one doesn't any more but it derives directly from
        GtkWidget [4].
        
        Therefore, after
        
            commit 139199ee9c09d25624191132adbe4fd29365eb7a
            Date:   Thu Feb 22 00:03:01 2024 -0900
        
                tdf#141728 Revamp sw navigator go to page spin control
        
        , opening the navigator by pressing F5 in Writer when
        using the gtk4 VCL plugin triggered the following assert:
        
            warn:vcl.gtk:233860:233860:vcl/unx/gtk4/convert3to4.cxx:1595: GtkInstanceBuilder: error when calling gtk_builder_add_from_string: .:197:65 Invalid property: GtkSpinButton.input-purpose
            soffice.bin: /home/michi/development/git/libreoffice/vcl/unx/gtk4/convert3to4.cxx:1598: void builder_add_from_gtk3_file(GtkBuilder *, const OUString &): Assertion `rc && "could not load UI file"' failed.
        
        Just ignore that property for gtk4.
        
        [1] https://docs.gtk.org/gtk3/property.Entry.input-purpose.html
        [2] https://docs.gtk.org/gtk4/property.Entry.input-purpose.html
        [3] https://docs.gtk.org/gtk3/class.SpinButton.html
        [4] https://docs.gtk.org/gtk4/class.SpinButton.html
        
        Change-Id: Ia3ece9fdf0269dc5178786fc64644ab3f0433871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166618
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6fd06e0215602c61ce6cefb07a3d401fc85d30c2]

        Add back the callVirtualFunction_fake boilerplate
        
        ...that ae6ee262d7649222a137f8722886a10db274ddf5 "Some fixing of
        msvc_win32_arm64 UNO bridge" had removed, assuming it wasn't actually necessary.
        But looks like Windows exception handling stack unwinding somehow needs it after
        all.  Getting past the CustomTarget_testtools/uno_test getRaiseAttr1() call now
        (but still failing at some later place).
        
        Change-Id: I1e84345f2f355ab1e480c779da6b221b744132b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166616
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-25  Attila Szűcs  <attila.szucs@collabora.com>  [89998a744f9ee8efa40c0e1cb7bdbc783d3414fa]

        tdf#153162 Animation load optimization
        
        Loading a big GIF animation can freeze LO for a long time, so:
        
        changed getAnimationFromGraphic, it can load parts of a big animation.
        It can be called several times to load the whole animation.
        Now it can load animation while it is playing.
        
        It may still load smaller animations at once before it is rendered.
        At first it load frames that sum maximum 5 million pixels.
        (But minimum 10 frame.)
        
        Changed the Graphic parameter to shared_ptr, so it won’t be deleted
        until the whole animation is loaded.
        
        Change-Id: I5ac16d7ee4883dbaefb604cd07757d19e5aa2939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166608
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a600cb4865f2b4bce872a000c2614cf6478b1ee0]

        Remove unused fields
        
        Unused since f944648e0f5d52605a267ed50bba4bfc035aecc6
        
        Change-Id: Id5f5a77df8afdf15d99989b86bb04179d86ae92b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166614
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-25  Mike Kaganski  <mike.kaganski@collabora.com>  [e7df78e1d4ac17ae5a17c4a151eefe2a6f2b0e4a]

        Fix UBSan failure: omission from 69ed893087f89d176a5ec4b263ce8d75774be72b
        
        This failure was seen:
        
        /xmloff/source/text/txtparai.cxx:1816:37: runtime error: downcast of address 0x604000d86710 which does not point to an object of type 'XMLStyleHint_Impl'
        0x604000d86710: note: object is of type 'XMLTextFrameHint_Impl'
         00 00 00 00  00 4b 83 40 b3 7f 00 00  70 bf 22 00 b0 60 00 00  70 bf 22 00 b0 60 00 00  06 00 00 00
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'XMLTextFrameHint_Impl'
            #0 0x7fb33f2d224d in XMLParaContext::endFastElement(int) /xmloff/source/text/txtparai.cxx:1816:37
            #1 0x7fb33dc76333 in SvXMLImport::endFastElement(int) /xmloff/source/core/xmlimp.cxx:885:15
            #2 0x7fb36ee0bfca in (anonymous namespace)::Entity::endElement() /sax/source/fastparser/fastparser.cxx:514:27
            #3 0x7fb36ee0b998 in sax_fastparser::FastSaxParserImpl::callbackEndElement() /sax/source/fastparser/fastparser.cxx:1331:17
            #4 0x7fb36edfb444 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) /sax/source/fastparser/fastparser.cxx:338:18
            #5 0x7fb3bacb8eaa in xmlParseEndTag2 /workdir/UnpackedTarball/libxml2/parser.c:10089:2
            #6 0x7fb3bac5fa45 in xmlParseTryOrFinish /workdir/UnpackedTarball/libxml2/parser.c:11867:14
            #7 0x7fb3bac533c4 in xmlParseChunk /workdir/UnpackedTarball/libxml2/parser.c:12150:5
            #8 0x7fb36edf6231 in sax_fastparser::FastSaxParserImpl::parse() /sax/source/fastparser/fastparser.cxx:1085:21
            #9 0x7fb36edefd18 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:890:9
            #10 0x7fb36ee11950 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1470:13
            #11 0x7fb33dc60551 in SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&) /xmloff/source/core/xmlimp.cxx:528:15
            #12 0x7fb31916b4f1 in (anonymous namespace)::ReadThroughComponent(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, char const*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, rtl::OUString const&, bool, bool) /sw/source/filter/xml/swxml.cxx:181:26
            #13 0x7fb3191609f1 in (anonymous namespace)::ReadThroughComponent(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, char const*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, char const*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, rtl::OUString const&, bool) /sw/source/filter/xml/swxml.cxx:323:16
            #14 0x7fb319159e4c in XMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) /sw/source/filter/xml/swxml.cxx:833:16
            #15 0x7fb3187eda73 in SwReader::Read(Reader const&) /sw/source/filter/basflt/shellio.cxx:203:22
            #16 0x7fb3195ecd45 in SwDocShell::Load(SfxMedium&) /sw/source/uibase/app/docshini.cxx:533:37
            #17 0x7fb382833c33 in SfxObjectShell::LoadOwnFormat(SfxMedium&) /sfx2/source/doc/objstor.cxx:3619:20
            #18 0x7fb38283a353 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:705:40
            #19 0x7fb382aca503 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1980:36
            #20 0x7fb38333d8c9 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:720:28
            #21 0x7fb371713419 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1176:37
            #22 0x7fb37170a43b in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:412:20
            #23 0x7fb371702a79 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:308:5
            #24 0x7fb3716fe207 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:168:14
            #25 0x7fb3717d23fd in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:591:16
            #26 0x7fb3717d2626 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
            #27 0x7fb3869f5afa in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:71:62
            #28 0x7fb38762dc56 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /test/source/unoapi_test.cxx:126:19
            #29 0x7fb38762cef8 in UnoApiTest::load(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:108:5
            #30 0x7fb38762e254 in UnoApiTest::loadFromFile(std::basic_string_view<char16_t, std::char_traits<char16_t> >, char const*) /test/source/unoapi_test.cxx:132:5
            #31 0x7fb38858966e in testPreserveJpg::TestBody() /filter/qa/unit/svg.cxx:52:5
            ...
        
        See https://ci.libreoffice.org/job/lo_ubsan/3150/consoleFull#1179512796d893063f-7f3d-4b7e-b56f-4e0f225817cd
        
        Change-Id: I1984ae555fada39fb6db6cadd326e5c8b9421b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166613
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-25  Miklos Vajna  <vmiklos@collabora.com>  [e3ce4aad47c052dcd67107f7c91336f4ecc949be]

        sc: fix crash in ScColumn::SetEditText()
        
        Crashreport:
        
        > SIG   Fatal signal received: SIGSEGV code: 128 for address: 0x0
        > program/libsclo.so
        >       ScColumn::SetEditText(int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
        >               sc/source/core/data/column3.cxx:2362
        > program/libsclo.so
        >       ScTable::SetEditText(short, int, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
        > program/libsclo.so
        >       ScDocument::SetEditText(ScAddress const&, std::unique_ptr<EditTextObject, std::default_delete<EditTextObject> >)
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
        > program/libsclo.so
        >       ScDocFunc::SetEditCell(ScAddress const&, EditTextObject const&, bool)
        >               /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/unique_ptr.h:395
        > program/libsclo.so
        >       (anonymous namespace)::finalizeFormulaProcessing(std::shared_ptr<(anonymous namespace)::FormulaProcessingContext>)
        >               sc/source/ui/view/viewfunc.cxx:565
        
        Change-Id: I331ca8784702fdcb0ebad6a0a73390dbe2615ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166612
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [e1c59fd539222973410dc6adcb8eac4abeeb9e6a]

        Improve documentation on reserved shortcuts
        
        Ctrl+F1 can be dropped from the reserved ones. It used to point to Context
        help, but at some point the shortcuts were switched around.
        
        Ctrl+Shift+F6 used to have references "activate splitter" and
        SV_SHORTCUT_SPLITTER, but it is not clear what this means. Related to
        vcl/source/window/split.cxx perhaps? One guess is that this is related to
        StarOffice's Window - Tile feature:
        https://www.oreilly.com/library/view/starofficetm-52-calc/013029389X/013029389X_ch02lev1sec8.html
        
        The Ctrl+Shift+F6 shortcut doesn't seem to do anything, so let's drop it
        from the reserved ones.
        
        Remove Unix-specific shortcuts Ctrl+Shift+1 through 0, Ctrl+Shift+Plus added in
        2003 without explanation in commit 2f382d6c2579a25c68dbd121af7f1f5dc7ec9852
        
        Ctrl+Shift+E is no longer used by IBus:
        https://github.com/ibus/ibus/commit/b952d30a1b7c741052c168fe1081ecb4d4b1c034
        https://github.com/ibus/ibus/commit/1520c39d0d6036da725fcecd932883be3f3d3575
        
        Change-Id: I19766c85871a56c4ba3cebc56e29c99e1f9a8f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166530
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2024-04-25  varshneydevansh  <varshney.devansh614@gmail.com>  [5e8813b22a9b73d1639f63fce3a8bed8baf6d0bb]

        tdf#97448 Add helper script to generate Addons.xcu
        
        This patch adds a new Python helper script to generate Addons.xcu for
        LibreOffice extensions. The script works like a wizard, and asks user
        about the needed details. It provides these options for the application
        module context:
        
            1. Writer
            2. Spreadsheet
            3. Presentation
            4. Draw
            5. Formula
            6. Chart
            7. Bibliography
        
        After selection of the module, appropriate Addons.xcu is generated, and
        user is asked to choose between 'desktop' or a custom folder to save the
        resulting file.
        
        Change-Id: I22a878f0bde19a870674a357d7085ad3c12fc50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163382
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-25  Kira Tubo  <kira.tubo@gmail.com>  [0f7f0ba5104f1c330dac66f593044304f68245b1]

        tdf#141525: sw unit test: line w/ arrow/circle endpoints
        
        Unit test checks that the "Line with Arrow/Circle" shape is inserted with "Arrow" at the start of the line and "Circle" at the end of the line.
        
        Without the fix from tdf#141525, the "Circle" is missing at the end of the line.
        
        Change-Id: I2c952deffea908b3daf855dabd9d19f1f6133268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166576
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-25  Miklos Vajna  <vmiklos@collabora.com>  [7ea2bf1c78bc139141c4d8726b1a2345d29fb361]

        CppunitTest_sw_writerfilter_rtftok: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), got rid of a case where the font name was not explicit.
        
        Change-Id: I06963f97d90e5a6c9efa0490890b30770b31dba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166611
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-25  Kira Tubo  <kira.tubo@gmail.com>  [c37acfce0aab520f30714961d333b1cd52eba4e7]

        tdf#154369: sw unit test: numbered list color in docx
        
        Unit test checks that the color of the ordered list number is the same color as paragraph color in the docx file.
        
        Change-Id: I5e620ace079d6cba6d0aa0ba11c97e05a9db55c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166423
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-04-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5823f417248663d78072e2a0be162175def2235]

        ofz#68269 more fixes to sc html parser
        
        Change-Id: I2fd889c438d4707a4e174a5a4300e742cd895d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166607
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [0669ab8167fdbe759061d5f8a230560392b53811]

        NotoSansHebrew: upgrade to v2.004
        
        Change-Id: I5f58bc02b35c5995ba8af3f24f448f45dbb378bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166603
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [99757f5e3a0a56370e035c14f38f5ccde3902e2c]

        CppunitTest_svgio: fix mid-air collision
        
        it was caused by 98935eef13c7d755221d79fe7d3c5869a40a7c37
        "tdf#159661, tdf#160773: svgio: Add unittest"
        and 7f64148507a360825e9c28ddb7077996df9fa092
        "Fix a thinko in 8a97f1ba8d9ccb65b2c89106de20666311d90c30"
        
        This partially reverts d984836834e67b5bcd618ebd5d1633138985a881
        "Fix unit test after commit 98935eef13c7d755221d79fe7d3c5869a40a7c37"
        
        Kudos to Mike for keeping Jenkins happy
        
        Change-Id: I034759b2cd95cbaaeb84ec1b528bf5b61487a1e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166591
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-25  Mohit Marathe  <mohitmarathe@proton.me>  [b51271b85387a57b4cdd20ee6277c1a955706fc1]

        tdf#76005 add TabsRelativeToIndent, TabOverMargin compat option to dialog
        
        Change-Id: I17703c2fe388f485462bd82982664f0b4a14d537
        Signed-off-by: Mohit Marathe <mohitmarathe@proton.me>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166040
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a938ed2be520426ce7949c4fd30a6e7e31d7c279]

        annot: added Annotation impl. to svx, moved some thing from sd
        
        This is an attempt to move the sd::Annotation to the common code
        in the svx module. This will need to be done in multiple steps so
        the first one is to introduce sdr::annotation::Annotation class in
        svx module, which is derived by sd::Annotation. Non-problematic
        functionality and members are also moved to the svx Annotation.
        
        Change-Id: Id20466b3780514ab63a9df8923b879098870ebb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166492
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-25  Jim Raykowski  <raykowj@gmail.com>  [b2b84dfa1d4f5da32f3335c59d618d385173a170]

        tdf#160598 SwNavigator enhancement to delete footnotes/endnotes
        
        m_bDocHasChanged is checked first in the tooltip and mouse move handlers
        to prevent crashes/asserts that happen when SfxPoolItemHolder m_aAttr
        references a delete poolitem or poolitem data. Without this check the
        following types of crashes/asserts can happen:
        
        ----
        
        Unspecified Application Error
        
        Fatal exception: Signal 6
        Stack:
        0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/
        unx/backtraceapi.cxx:42 (discriminator 3)
        1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/
        osl/unx/signal.cxx:289
        2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /
        home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330
        3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*)
        at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427
        4 __restore_rt at libc_sigaction.c:?
        5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44
        6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27
        7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21)
        8 SalAbort(rtl::OUString const&, bool) at /home/lo/Dev/LO1/core/vcl/
        source/app/salplug.cxx:412
        9 Application::Abort(rtl::OUString const&) at /home/lo/Dev/LO1/core/
        vcl/source/app/svapp.cxx:316
        10 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/
        core/desktop/source/app/app.cxx:1203 (discriminator 2)
        11 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/
        core/vcl/source/app/svmain.cxx:176
        12 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/
        all/signalshared.cxx:47
        13 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*)
        at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423
        14 __restore_rt at libc_sigaction.c:?
        15 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/
        poolitem.hxx:225
        16 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/
        svl/itemset.hxx:74 (discriminator 1)
        17 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/
        txatbase.hxx:223 (discriminator 1)
        18 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/
        Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974
        19 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&)
        at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895
        20 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter
        const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111
        21 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at /
        home/lo/Dev/LO1/core/include/vcl/weld.hxx:977
        22 SalInstanceTreeView::TooltipHdl(SvTreeListEntry*) at /home/lo/Dev/
        LO1/core/vcl/source/app/salvtables.cxx:5154
        23 SalInstanceTreeView::LinkStubTooltipHdl(void*, SvTreeListEntry*) at
        /home/lo/Dev/LO1/core/vcl/source/app/salvtables.cxx:5151
        24 Link<SvTreeListEntry*, rtl::OUString>::Call(SvTreeListEntry*) const
        at /home/lo/Dev/LO1/core/include/tools/link.hxx:111
        25 SvTreeListBox::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/
        core/vcl/source/treelist/treelistbox.cxx:3284
        26 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/
        Dev/LO1/core/vcl/source/window/winproc.cxx:186
        27 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType,
        bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at
        /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740
        28 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/
        lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332
        29 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/
        lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1)
        30 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/
        LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1)
        31 QtFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/
        LO1/core/vcl/inc/qt5/QtFrame.hxx:228
        32 QtWidget::mouseMoveEvent(QMouseEvent*) at /home/lo/Dev/LO1/core/vcl/
        qt5/QtWidget.cxx:202
        33 QWidget::event(QEvent*) in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
        34 QtWidget::event(QEvent*) at /home/lo/Dev/LO1/core/vcl/qt5/
        QtWidget.cxx:738 (discriminator 2)
        35 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/
        x86_64-linux-gnu/libQt5Widgets.so.5
        36 QApplication::notify(QObject*, QEvent*) in /lib/x86_64-linux-gnu/
        libQt5Widgets.so.5
        37 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64-
        linux-gnu/libQt5Core.so.5
        38 QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*,
        QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) in /lib/
        x86_64-linux-gnu/libQt5Widgets.so.5
        39 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/
        x86_64-linux-gnu/libQt5Widgets.so.5
        40 QDesktopWidget::qt_metacall(QMetaObject::Call, int, void**) in /lib/
        x86_64-linux-gnu/libQt5Widgets.so.5
        41 QApplicationPrivate::notify_helper(QObject*, QEvent*) in /lib/
        x86_64-linux-gnu/libQt5Widgets.so.5
        42 QCoreApplication::notifyInternal2(QObject*, QEvent*) in /lib/x86_64-
        linux-gnu/libQt5Core.so.5
        43
        QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
        in /lib/x86_64-linux-gnu/libQt5Gui.so.5
        44
        QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>)
        in /lib/x86_64-linux-gnu/libQt5Gui.so.5
        45 QXcbNativeInterface::dumpNativeWindows(unsigned long long) const in
        /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
        46 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        48 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        49
        QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>)
        in /lib/x86_64-linux-gnu/libQt5Core.so.5
        50 QtInstance::ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/
        QtInstance.cxx:453
        51 QtInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/qt5/
        QtInstance.cxx:464
        52 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:395
        53 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:483
        54 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:370
        55 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/
        app/app.cxx:1617
        56 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229
        57 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262
        58 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/
        sofficemain.cxx:93
        59 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51
        60 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49
        61 __libc_start_call_main at ./csu/../sysdeps/nptl/
        libc_start_call_main.h:58
        62 call_init at ./csu/../csu/libc-start.c:128
        63 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin
        
        ----
        
        soffice.bin: /home/lo/Dev/LO1/core/sw/inc/txatbase.hxx:223: const
        SwFormatFootnote& SwTextAttr::GetFootnote() const: Assertion `m_aAttr
        && m_aAttr.Which() == RES_TXTATR_FTN' failed.
        
        Fatal exception: Signal 6
        Stack:
        0 sal::backtrace_get(unsigned int) at /home/lo/Dev/LO1/core/sal/osl/
        unx/backtraceapi.cxx:42 (discriminator 3)
        1 (anonymous namespace)::printStack(int) at /home/lo/Dev/LO1/core/sal/
        osl/unx/signal.cxx:289
        2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at /
        home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:330
        3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*)
        at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:427
        4 __restore_rt at libc_sigaction.c:?
        5 __pthread_kill_implementation at ./nptl/pthread_kill.c:44
        6 __GI_raise at ./signal/../sysdeps/posix/raise.c:27
        7 __GI_abort at ./stdlib/abort.c:81 (discriminator 21)
        8 _nl_load_domain at ./intl/loadmsgcat.c:1177
        9 __GI___assert_fail at :?
        10 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/
        txatbase.hxx:224
        11 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/
        Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974
        12 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&)
        at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895
        13 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter
        const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111
        14 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at /
        home/lo/Dev/LO1/core/include/vcl/weld.hxx:977
        15 (anonymous
        namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int,
        int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/
        gtkinst.cxx:14701 (discriminator 2)
        16 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0
        17 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        18 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/
        libgobject-2.0.so.0
        19 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        20 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        21 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/
        libgtk-3.so.0
        22 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/
        libgtk-3.so.0
        23 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0
        24 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0
        25 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0
        26 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        27 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        28 g_main_loop_run in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        29 main_loop_run(_GMainLoop*) at /home/lo/Dev/LO1/core/vcl/inc/unx/gtk/
        gtkdata.hxx:63
        30 (anonymous namespace)::DialogRunner::run() at /home/lo/Dev/LO1/core/
        vcl/unx/gtk3/gtkinst.cxx:6747 (discriminator 13)
        31 (anonymous namespace)::GtkInstanceDialog::run() at /home/lo/Dev/LO1/
        core/vcl/unx/gtk3/gtkinst.cxx:10046
        32 weld::DialogController::run() at /home/lo/Dev/LO1/core/include/vcl/
        weld.hxx:2669
        33 (anonymous namespace)::RecoveryUI::impl_doEmergencySave() at /home/
        lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:258 (discriminator 1)
        34 (anonymous
        namespace)::RecoveryUI::dispatchWithReturnValue(com::sun::star::util::URL
        const&,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) at /home/lo/Dev/LO1/core/svx/source/unodraw/recoveryui.cxx:148
        35 desktop::(anonymous namespace)::impl_callRecoveryUI(bool, bool) at /
        home/lo/Dev/LO1/core/desktop/source/app/app.cxx:1022 (discriminator 5)
        36 desktop::Desktop::Exception(ExceptionCategory) at /home/lo/Dev/LO1/
        core/desktop/source/app/app.cxx:1177
        37 VCLExceptionSignal_impl(void*, oslSignalInfo*) at /home/lo/Dev/LO1/
        core/vcl/source/app/svmain.cxx:176
        38 callSignalHandler(oslSignalInfo*) at /home/lo/Dev/LO1/core/sal/osl/
        all/signalshared.cxx:47
        39 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*)
        at /home/lo/Dev/LO1/core/sal/osl/unx/signal.cxx:423
        40 __restore_rt at libc_sigaction.c:?
        41 SfxPoolItem::Which() const at /home/lo/Dev/LO1/core/include/svl/
        poolitem.hxx:225
        42 SfxPoolItemHolder::Which() const at /home/lo/Dev/LO1/core/include/
        svl/itemset.hxx:74 (discriminator 1)
        43 SwTextAttr::GetFootnote() const at /home/lo/Dev/LO1/core/sw/inc/
        txatbase.hxx:223 (discriminator 1)
        44 SwContentTree::QueryTooltipHdl(weld::TreeIter const&) at /home/lo/
        Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4974
        45 SwContentTree::LinkStubQueryTooltipHdl(void*, weld::TreeIter const&)
        at /home/lo/Dev/LO1/core/sw/source/uibase/utlui/content.cxx:4895
        46 Link<weld::TreeIter const&, rtl::OUString>::Call(weld::TreeIter
        const&) const at /home/lo/Dev/LO1/core/include/tools/link.hxx:111
        47 weld::TreeView::signal_query_tooltip(weld::TreeIter const&) at /
        home/lo/Dev/LO1/core/include/vcl/weld.hxx:977
        48 (anonymous
        namespace)::GtkInstanceTreeView::signalQueryTooltip(_GtkWidget*, int,
        int, int, _GtkTooltip*, void*) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/
        gtkinst.cxx:14701 (discriminator 2)
        49 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0
        50 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        51 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/
        libgobject-2.0.so.0
        52 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        53 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        54 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/
        libgtk-3.so.0
        55 gtk_tooltip_set_icon_from_gicon in /lib/x86_64-linux-gnu/
        libgtk-3.so.0
        56 gtk_tooltip_trigger_tooltip_query in /lib/x86_64-linux-gnu/
        libgtk-3.so.0
        57 GtkSalFrame::ShowTooltip(rtl::OUString const&, tools::Rectangle
        const&) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3154
        58 ImplShowHelpWindow(vcl::Window*, unsigned short, QuickHelpFlags,
        rtl::OUString const&, Point const&, tools::Rectangle const&) at /home/
        lo/Dev/LO1/core/vcl/source/app/help.cxx:492
        59 Help::ShowQuickHelp(vcl::Window*, tools::Rectangle const&,
        rtl::OUString const&, QuickHelpFlags) at /home/lo/Dev/LO1/core/vcl/
        source/app/help.cxx:191 (discriminator 5)
        60 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        61 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/
        core/vcl/source/window/brdwin.cxx:1673
        62 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        63 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        64 ImplBorderWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/
        core/vcl/source/window/brdwin.cxx:1673
        65 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        66 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        67 SplitWindow::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/splitwin.cxx:2117
        68 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        69 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        70 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        71 vcl::Window::RequestHelp(HelpEvent const&) at /home/lo/Dev/LO1/core/
        vcl/source/window/window.cxx:1928
        72 ImplHandleMouseHelpRequest(vcl::Window*, Point const&) at /home/lo/
        Dev/LO1/core/vcl/source/window/winproc.cxx:186
        73 ImplHandleMouseEvent(VclPtr<vcl::Window> const&, NotifyEventType,
        bool, long, long, unsigned long, unsigned short, MouseEventModifiers) at
        /home/lo/Dev/LO1/core/vcl/source/window/winproc.cxx:740
        74 ImplHandleSalMouseMove(vcl::Window*, SalMouseEvent const*) at /home/
        lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2332
        75 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at /home/
        lo/Dev/LO1/core/vcl/source/window/winproc.cxx:2665 (discriminator 1)
        76 SalFrame::CallCallback(SalEvent, void const*) const at /home/lo/Dev/
        LO1/core/vcl/inc/salframe.hxx:312 (discriminator 1)
        77 GtkSalFrame::CallCallbackExc(SalEvent, void const*) const at /home/
        lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:6388
        78 GtkSalFrame::DrawingAreaMotion(int, int, unsigned int, unsigned int)
        at /home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3719
        79 GtkSalFrame::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) at /
        home/lo/Dev/LO1/core/vcl/unx/gtk3/gtkframe.cxx:3756
        80 gtk_socket_add_id in /lib/x86_64-linux-gnu/libgtk-3.so.0
        81 g_closure_invoke in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        82 g_signal_handlers_destroy in /lib/x86_64-linux-gnu/
        libgobject-2.0.so.0
        83 g_signal_emit_valist in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        84 g_signal_emit in /lib/x86_64-linux-gnu/libgobject-2.0.so.0
        85 gtk_widget_init_template in /lib/x86_64-linux-gnu/libgtk-3.so.0
        86 gtk_grab_remove in /lib/x86_64-linux-gnu/libgtk-3.so.0
        87 gtk_main_do_event in /lib/x86_64-linux-gnu/libgtk-3.so.0
        88 gdk_drawing_context_get_clip in /lib/x86_64-linux-gnu/libgdk-3.so.0
        89 gdk_x11_drag_context_get_type in /lib/x86_64-linux-gnu/libgdk-3.so.0
        90 g_main_context_dispatch in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        91 g_io_channel_new_file in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        92 g_main_context_iteration in /lib/x86_64-linux-gnu/libglib-2.0.so.0
        93 GtkSalData::Yield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/gtk3/
        gtkdata.cxx:405 (discriminator 6)
        94 GtkInstance::DoYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/unx/
        gtk3/gtkinst.cxx:436
        95 ImplYield(bool, bool) at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:395
        96 Application::Yield() at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:483
        97 Application::Execute() at /home/lo/Dev/LO1/core/vcl/source/app/
        svapp.cxx:370
        98 desktop::Desktop::Main() at /home/lo/Dev/LO1/core/desktop/source/
        app/app.cxx:1617
        99 ImplSVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:229
        100 SVMain() at /home/lo/Dev/LO1/core/vcl/source/app/svmain.cxx:262
        101 soffice_main at /home/lo/Dev/LO1/core/desktop/source/app/
        sofficemain.cxx:93
        102 sal_main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:51
        103 main at /home/lo/Dev/LO1/core/desktop/source/app/main.c:49
        104 __libc_start_call_main at ./csu/../sysdeps/nptl/
        libc_start_call_main.h:58
        105 call_init at ./csu/../csu/libc-start.c:128
        106 _start in /home/lo/Dev/LO1/core/instdir/program/soffice.bin
        
        Change-Id: Id2bad55221a8603a1e12f870bdc1479e7709ee58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166414
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [d4f6534e8870e8f271984c37ce54a6878f372ae1]

        [API CHANGE] a11y: Use XAccessible for relation targets
        
        Use a Sequence of XAccessible rather than its base
        interface XInterface for AccessibleRelation's TargetSet.
        
        As the targets are accessible objects as well,
        anything other than XAccessible doesn't make much sense.
        Using XAccessible right away makes that clearer and avoids
        the need to query the XAccessible interface.
        
        (The winaccessibility bridge was already using
        `static_cast`, relying on the fact that the objects
        are XAccessibles.)
        
        The a11y UNO API is not published, so an API change
        should be unproblematic.
        
        Change-Id: I7f08e98d1ec303d5343d9a7954187cdd71495ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166586
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-24  Michael Weghorn  <m.weghorn@posteo.de>  [b6a8fec62cb7576ac8a94a76ca88256eb4f97695]

        a11y: Drop note about API being "not yet published"
        
        The note about `XAccessibleMultiLineText` being
        "not yet published" can be misleading, as there's
        no plan to publish it.
        
        All a11y API was unpublished in
        
            commit 70626249cd247d9acdad417b8eaf252bae22c059
            Date:   Thu Nov 29 00:27:03 2012 +0100
        
                API CHANGE a11y unpublishing and add/removeListener rename.
        
                The a11y API has never really been picked up by tools vendors, let's
                not tie ourselves up here for no good reason.
        
                This unpublishes all css::accessibility, and dependend API.
        
                With that, we can change the rather unfortunately-named add/
                removeEventListener to be add/removeAccessibleEventListener, thus
                not conflicting with the XComponent methods of the same name.
        
                Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
        
        There's currently no plan to change that, so drop that
        note.
        
        (Public a11y API is the corresponding platform a11y API
        and it's LO's responsibility to bridge to that.)
        
        Change-Id: I72a3d3be71f68663497364747f143e856d0b80ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166587
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-24  Eike Rathke  <erack@redhat.com>  [92ea59703da91771ca78ade82ca796077c066da8]

        Resolves: tdf#159829 DecimalSeparator '.' period, ThousandSeparator ',' comma
        
        Follows
        https://unicode-org.atlassian.net/browse/CLDR-16247
        https://unicode-org.atlassian.net/browse/CLDR-14707?focusedCommentId=161272
        
        Change-Id: I7ad049dd06102b36ac8d7ff13f7604e5cbb10f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166602
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-04-24  Jim Raykowski  <raykowj@gmail.com>  [802bc63be79f5622d794345dbbc577b6c603b61b]

        SwContentTree: Don't show 'Delete' menu item when read-only
        
        Change-Id: Ib3a1ec5635937b2dcb26144f621ee0bf4a0101d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166413
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Jenkins

2024-04-24  Jim Raykowski  <raykowj@gmail.com>  [74bd60c433cdc135d8a465eb5cea8ee6ce84b436]

        Rework SwContentTree context menu item 'Rename' inclusion
        
        Change-Id: Ice211a3026d07a21b1b6e47ee1c16086401714d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166412
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-24  kubak  <kuba@openoffice.com.pl>  [f91e8fe61f15f0365cc65183d3fb3573d5215d3f]

        MSI: Fix use of undefined TextStyle
        
        ICE31 ERROR Control AdminNetworkLocation.DlgTitle uses undefined TextStyle MSSansBold8.
        
        In the Control table in the Text column there is:
        
        {&MSSansBold8}Network Location
        
        and the Text Style from the TextStyle table should be used and look like this:
        
        {&DialogDefaultBold}Network Location
        
        https: //learn.microsoft.com/en-us/windows/win32/msi/ice31
        Change-Id: I4fa1048cc28d042fc8a78b4dba1495ad75fc017a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166568
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-24  Patrick Luby  <guibmacdev@gmail.com>  [4b31f87e918c38a7eb30ceb85563a5c98b426da5]

        tdf#160714 use crop box for bounds of embedded PDF object
        
        If there is no crop box, fallback to the media box just to be safe.
        
        Change-Id: I29f99a43e550cf09a1534c0aa01ffd6a55536fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166544
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-04-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e835642a93b6e63f168333dea1b4bc8c26275218]

        NotoSerifHebrew: upgrade to v2.004
        
        Change-Id: I857889598ad68902635e2dd349118c503a4fa70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166590
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ae6ee262d7649222a137f8722886a10db274ddf5]

        Some fixing of msvc_win32_arm64 UNO bridge
        
        For one, the Windows ABI deviates from the generic aarch64 ABI regarding
        returning class instances by value from non-static member functions, see
        <https://learn.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=msvc-170#return-values>:
        "The caller shall reserve a block of memory of sufficient size and alignment to
        hold the result.  The address of the memory block shall be passed as an
        additional argument to the function in x0, or x1 if $this is passed in x0.  The
        callee may modify the result memory block at any point during the execution of
        the subroutine.  The callee returns the address of the memory block in x0."
        That means RETURN_KIND_HFA_FLOAT and RETURN_KIND_HFA_DOUBLE are not needed, and
        can be cleaned up in a follow-up commit.
        
        And for another, setting up a call stack frame in call() in uno2cpp.cxx for
        callVirtualFunction() didn't actually work, so go with a slightly less ambitious
        aproach (as also used by the gcc_linux_aarch64 bridge) and explicitly copy the
        arguments that end up on the stack around in callVirtualFunction().
        
        This allows CustomTarget_testtools/uno_test to proceed at least as far as the
        call of getRaiseAttr1(), which still leads to an uncaught
        css::uno::RuntimeException.
        
        Change-Id: I4a8ec09c270864ac4de246d7e8d1f923198236b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166585
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-24  Heiko Tietze  <tietze.heiko@gmail.com>  [63315d601296f7c188e920f73b12260d018807d0]

        Resolves tdf#132253 - Remove hyperlink tab from character dialog
        
        Change-Id: Idb7fa74dbe196262cea64946452043f7de6fa20c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166553
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [497fc304d49577df43842d56eb3ccbe6875fcafd]

        windows: set CONFIG_SHELL for external configure runs
        
        Change-Id: I9cb03692524eced35935ad1979027f7b196e5ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166329
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c1256034ffb585cd818eedb49c88c86d414224b9]

        use --binary flag when applying patches with patch from git-bash
        
        Change-Id: Idbd4ad7ad89dc727e2f0cf851c4c62f05d5b2a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166328
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6e18734c5c3b026669da89b2b535383eccd4c083]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f32f607fcfb59c462919261f26f8ae07e1e4707f
          - Revert "win doesn't like (foo || bar) | … construct, suspends xsltproc"
            
            This reverts commit b066c7f1008ce7d433683324dc9ef441478c832c.
            
            Reason for revert: not all xargs versions know -a option (mac)
            
            Change-Id: Ia2a54e1dffe459b058f1e11a35372bb38774044f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166519
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            Tested-by: Jenkins
            
2024-04-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c079eec689c9df295d8eb1770e90cca2060b98b]

        vcl: Factor out common code and simplify
        
        Change-Id: I836c8f85474dc564efa3ca781f47a25e1d8c55fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166582
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-04-24  Miklos Vajna  <vmiklos@collabora.com>  [9f7c961e1c6e7b6aec783ba55a6b8cb6ebcf811d]

        cool#8789 sc lok: classify multi-selection with 2 cells as simple
        
        The trouble was that even if commit
        b13c7b31f9ce3c3a25cffd0c35e7ee6b8c2a1895 (cool#8789 sc lok: fix copy for
        multi-selections, 2024-04-19) made multi-selection copy work, just 2
        cells in a multi-selection was classified as a complex selection at a
        LOK level, while 2 cells next to each other is a simple selection, which
        is inconsistent. (A LOK client can provide a simpler UI for simple
        selections.)
        
        What happens is that the multi-selection clipboard document had no
        selection ranges defined, so ScDocument::GetClipArea() returned early,
        so the numbers in the ScTransferObj ctor were left initialized, which at
        the end lead to a >1000 cells in ScTransferObj::isComplex(), because we
        were calculating uninitialized data.
        
        Fix the problem by passing a range (that covers all ranges of the
        multi-selection) to ScViewFunc::CopyToTransferable(), which avoids the
        wrong col/row start/length, so the selection is classified as simple.
        
        Also adapt testRowColumnSelections, which was just meant to check we
        don't crash, but now the cell under the cell cursor is returned, so the
        assert about the empty selection would fail.
        
        Change-Id: If98212c623fa75adb2ddf628a6e90f3eef450e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166581
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-24  Heiko Tietze  <tietze.heiko@gmail.com>  [9d29a2a6aad679129218ab4c5020c92bb3ce9cb3]

        Resolves tdf#159569 - Conditional Formatting dialog jumps with message string
        
        Some defined width solves the issue
        
        Change-Id: I1f92815e690828e283c275a58a71dd07613642fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166579
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-24  Miklos Vajna  <vmiklos@collabora.com>  [88ef23726498b65b33d80a2e4cf71b00205f80bd]

        CppunitTest_sw_rtfexport4: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I680ce101de71dab06616658d7abcb4997c4c9bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166575
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-24  Heiko Tietze  <tietze.heiko@gmail.com>  [e60ded9773673c356a88fa02867cb3692ee74c87]

        Bump Glade version
        
        Change-Id: I53c7c6cab10663b50391a45c18e09dc3e81c87cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166546
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [69ed893087f89d176a5ec4b263ce8d75774be72b]

        tdf#160253: fix list identifier export decision code
        
        Commits 8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit
        unreferenced <text:list xml:id="...">, 2022-03-10) and
        82bbf63582bdf28e7918e58ebf6657a9144bc9f3  (tdf#155823: Improve the
        check if the list id is not required, 2023-06-14) tried to improve
        deterministic ODF output, by omitting the list identifiers in case
        when those identifiers were unreferenced. The latter of these used
        document model node numbers to check if other lists appeared after
        the last occurrence of the list  that is continuing in the current
        node. But it turned out, that this isn't robust. Consider this ODF:
        
          <text:list xml:id="list1" text:style-name="L1">
           <text:list-item>
            <text:p>a</text:p>
           </text:list-item>
          </text:list>
          <text:p>b<text:note text:id="ftn1" text:note-class="endnote"><text:note-citation>i</text:note-citation><text:note-body>
             <text:list text:style-name="L2">
              <text:list-item>
               <text:p>x</text:p>
              </text:list-item>
             </text:list></text:note-body></text:note></text:p>
          <text:list text:continue-list="list1" text:style-name="L1">
           <text:list-item>
            <text:p>c</text:p>
           </text:list-item>
          </text:list>
        
        The paragraphs a, b, and c are all in the main document body,  and
        have sequential document model node numbers  (say, 15, 16, 17). If
        these numbers are checked,  there is no node between node 15 ("a")
        and node 17 ("c") with a different list  (both 15 and 17 belong to
        a list with style "L1" and identifier "list1", and node 16 doesn't
        belong to any lists). That suggests that the list identifier isn't
        needed in this case. Bug when the actual output of node 16 is done,
        it includes a node from an endnote  ("x"),  which is located  in a
        different place in the document model,  and has a node number like
        7 (so not between 15 and 17). The paragraph "x" belongs to another
        list with style  "L2", and is output to ODF between paragraphs "a"
        and "c". Here, we must refer from paragraph "c" to the list of the
        paragraph "a" using the list id, but this is not obvious when only
        considering node numbers,  and requires the prior knowledge of the
        actual order of appearance of lists in the ODF.
        
        Unless we build a DOM,  this is only possible, if we do a two-pass
        output, and collect the nodes order in the first pass.  The output
        already does that in a "collect autostyles" pass. The problem here
        is that the  "collect autostyles"  pass used an optimized function,
        XMLTextParagraphExport::collectTextAutoStylesOptimized, introduced
        in commit  8195d7061ed52ebb98f46d35fe5929762c71e4b3  (INTEGRATION:
        CWS swautomatic01 (1.126.4); FILE MERGED, 2006-12-01) for #i65476#
        and which used style::XAutoStylesSupplier for optimization  to get
        the autostyles.
        
        This drops  XMLTextParagraphExport::collectTextAutoStylesOptimized,
        and reverts to use of  collectTextAutoStyles,  which handles nodes
        in the same order as when writing to ODF. There, we build a vector
        of the node numbers sequence, used later to sort DocumentListNodes.
        
        This uncovered an omission from the work on paragraph mark (commit
        1a88efa8e02a6d765dab13c7110443bb9e6acecf  tdf#155238:  Reimplement
        how ListAutoFormat is stored to ODF, 2023-05-11).  Turns out, that
        the code in SwTextFormatter::NewNumberPortion introduced in commit
        cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f  (sw,  numbering  portion
        format: consider full-para char formats as well,  2022-10-20)  was
        left behind when re-implementing paragraph marks  to use dedicated
        property;  empty trailing spans still affected  how the lists were
        rendered,  and that allowed to overlook import defects,  where the
        paragraph mark properties weren't properly set.
        
        In ODF import (XMLParaContext::endFastElement),  for compatibility,
        this treats empty trailing spans as defining paragraph mark  (when
        the paragraph mark wasn't set explicitly).  This way, the trailing
        spans get converted to the paragraph mark.
        
        In WW8 import,  last cell paragraphs didn't call the code handling
        the paragraph marks. This is also fixed now.
        
        The changes result  in slightly different numbering  of autostyles
        in the ODF.  It seems, that the new numbering more closely follows
        the order of appearance of the autostyles in the output;  and some
        cases of autostyles that were written,  but unreferenced,  are now
        eliminated. The unit tests were updated accordingly.
        
        I hope that the performance impact on the export time would not be
        too large.
        
        It is unclear why outline numbering  exports a list element at all.
        Fixing that to not emit the list element is a separate task / TODO.
        
        Change-Id: I5c99f8d48be77c4454ffac6ffa9f5babfe0d4909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166572
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-24  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [dfb412699b96e12b2758be0e422c3e775f183d17]

        tdf#38164: sd: allow panning across pages when zoomed in
        
        Change-Id: I513b2b8cbdc91733e551da71a1e6782fecc981a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166542
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper@libreoffice.org>

2024-04-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a1694b194c2b3e89250c5b79a69e7dd184b69976]

        tdf#160765 - Save content for undo when pasting notes
        
        even if no content was changed after pasting special. Otherwise, the undo functionality crashes due to undoing a cell with no content where the annotation indicator will remain (unod/redo of note captions are handled via drawing undo).
        
        Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [d7b15f03e0b956d23854806f35636ab4acfb1296]

        Add some entries into cpp.hint
        
        Improves VS integration: allows to find CPP unit tests defined using
        DECLARE_SW_ROUNDTRIP_TEST and friends.
        
        The macros are stripped down to the minimum to allow IntelliSense
        do its job.
        
        Change-Id: I5325cb5ac424e3b08cd64b265d5d4924fbadcfcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166571
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [d984836834e67b5bcd618ebd5d1633138985a881]

        Fix unit test after commit 98935eef13c7d755221d79fe7d3c5869a40a7c37
        
        Similar to commit cfa9990d470b10548c7fed64eb1182fea11d41e0 (Enable
        this test on all platforms. 2024-04-20), it seems that 'mask' gets
        exported inconsistently. This patch workarouns the problem; a proper
        fix would be finding the real cause.
        
        Change-Id: I94c89442aa0385262fba67ec58c9d8d12ffbea27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166573
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-23  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9ad0eb9a62b572b15ae0bfd31674aedd77eb4761]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67dd141b0f05a334a51a36d14cbe666559949715
          - Remove a tautology and fix a grammar error
            
            Change-Id: I6d8e582f2023c488ebd74a29aeac3360d621ed02
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166566
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2024-04-23  Justin Luth  <justin.luth@collabora.com>  [4ed26399e2c9a0d35a1f7e6f19f68a5bb0303109]

        NFC ScRawToken::CreateToken: ocPush uses the same function
        
        Ever since commit 87307aba9e8dbca16672e6df701d9f905b9e1786
        Author: Jens-Heiner Rechtien on Thu Jan 8 10:47:13 2009 +0000
            CWS-TOOLING: integrate CWS frmdlg
                 case svSingleRef :
                     if (eOp == ocPush)
                         return new ScSingleRefToken( aRef.Ref1 );
                     else
        -                return new ScSingleRefOpToken( eOp, aRef.Ref1 );
        +                return new ScSingleRefToken( aRef.Ref1, eOp );
                 case svDoubleRef :
                     if (eOp == ocPush)
                         return new ScDoubleRefToken( aRef );
                     else
        -                return new ScDoubleRefOpToken( eOp, aRef );
        +                return new ScDoubleRefToken( aRef, eOp );
        
        Instead of using different functions, they now use the same function
        where optional eOp = ocPush [sc/inc/token.hxx].
        
        Change-Id: I3ee0f308bd983c3edd54fdd064b957b63ca4c0d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166564
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [31a4062bc0f3a751d3758a2d9b3ebb4fe9010590]

        wina11y: Use AccessibleRelationType::MEMBER_OF constant
        
        ... instead of hard-coded 7.
        
        Change-Id: I2ac44719043c827ce2a65687be021d7f823898d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166505
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [b97ff95cc2ef4c1da83c5889690b7a703f5c0699]

        wina11y: Use AccessibleRelationType constants
        
        Use `AccessibleRelationType::LABELED_BY` and
        `AccessibleRelationType::LABEL_FOR` instead of
        hard-coded numbers 6 and 5.
        
        While at it, also rename the misspelt
        "pRLebelContext" to "xLabelContext".
        
        Change-Id: Id4e5cec0f04b9257eb141fd9bac64e7f01fa32ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166504
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-23  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7d13e62c3d468bd249db62cfdde14f28f74b3f59]

        tdf#39468 Translate German comments in vcl
        
        Change-Id: I783d924bffddb637eac1a3d89f4ee956955e0044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166558
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2024-04-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f86fdd4b5428a8c7b253051cca93429dc71f894]

        tdf#160787 Calc active cell cursor has small transparent corners
        
        clearly I don't understand something about B2DPolyPolygon, revert part
        of
        
            commit 7b1405689d4246e0e37e8759f03e1962af964cec
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 19 22:56:04 2024 +0200
        reduce the number of drawing primitives we create in
        OverlaySelection
        
        Change-Id: If8f07d021543e2686a3acfc6a0d38b2ebc962de4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166543
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [979164938007e4774b7718abcb20fded9a00839f]

        tdf#160768 Changing value in a text box control with a link cell set up, Crash
        
        regression from
            commit 7510cca63690ea97eb02a43f698fc183c3d0434a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Mar 26 15:56:02 2024 +0200
            convert OCellValueBinding to comphelper::WeakComponentImplHelper
        
        Change-Id: I36ec4cca7a48992b29d6c2ff5c87fb0fed1c8c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166540
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-23  Heiko Tietze  <tietze.heiko@gmail.com>  [8f3a19ce3a2dea548f644a8925bfe0718424ac21]

        Resolves tdf#160050 - Overlapping controls in 'add themes' dialog
        
        Change-Id: I196ef4b445dcae5d6fc9891c8f9c0d0b2976d583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166541
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [98935eef13c7d755221d79fe7d3c5869a40a7c37]

        tdf#159661, tdf#160773: svgio: Add unittest
        
        Change-Id: I2d0b96f13e02ac81b97ea347889c76770c22a989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166509
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [248c21867cc33f0c135304007c3b113947a39683]

        ofz#68234 emf XForm isnan members
        
        Change-Id: If3d199e764785e1923d40a1b36c388607a5e4326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166507
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e9e09e60355f454e51ea7a8af9f12dca29f9e407]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d50121f44bc54b22ccc603093cf5fd0b75f26155
          - tdf#102265 More work on Impress format menu (5)
            
            Change-Id: Ia1eb00e126f8609091464599a364f0da4e8dd38a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166471
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5d8e29c94edeed564df4b68aed01f695d5ece070]

        external/icu: Drop hidden dependency on Python
        
        ...which was always satisfied directly from the system, regardless of our
        --enable-python=... setting.  (And which was a problem for my Git Bash and WSL
        based Windows build attempt, where it happened to find a dysfunctional Python
        wrapper at C:/Users/steph/AppData/Local/Microsoft/WindowsApps/python3 which
        caused a
        
        [...]
        > Not rebuilding data/rules.mk, assuming prebuilt data in data/in
        > Spawning Python to generate test/testdata/rules.mk...
        > Python was not found; run without arguments to install from the Microsoft Store, or disable this shortcut from Settings > Manage App Execution Aliases.
        > configure: error: Python failed to run; see above error.
        
        error when building ExternalProject_icu.)
        
        There are three uses of that PYTHON setting across workdir/UnpackedTarget/icu:
        
        1  In source/configure.ac to generate source/data/rules.mk if
        source/data/locales/root.txt would exist---but which doesn't, so we don't
        actually need PYTHON there.
        
        2  In source/configure.ac to generate source/test/testdata/rules.mk, but which
        our (non-check) build apparently doesn't need anyway.
        
        3  In source/data/Makefile.in for target check-local, which is a sub-target of
        check (which we don't build).
        
        Change-Id: I7455cc91fc67f36582bf54851c07030830cd3b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166500
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-04-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [246ef0b8eaa86b62fb0f980d0736d97c05283266]

        loplugin:singlevalfields
        
        Change-Id: I4d7b38c90d73a00f4dbc8ad7318fe4573328ed46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [bced98442d5e9c4b55ec6d4e5da3d549f8141359]

        tdf#160469 Ctrl+Alt+F4 is marked reserved, but doesn't do anything
        
        this used to be SV_SHORTCUT_DOCKUNDOCK, which was introduced in
        
            commit b342b183aaea042ef0e6e1c75304072cb4e1375a
            Author: Rüdiger Timm <rt@openoffice.org>
            Date:   Tue Jul 24 09:03:18 2007 +0000
            INTEGRATION: CWS mergesvp (1.1.2); FILE ADDED
        
        I assume this was a solaris or something similar system hotkey, so
        remove it as no longer being relevant.
        
        Certainly nothing inside the vcl code is handling it specially.
        
        Change-Id: I80b9d293e7db42e1ff523319862d44b93d3231c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166502
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-04-23  Miklos Vajna  <vmiklos@collabora.com>  [f9f2b7590bb7b3334d499b6884cc7f3e80843b8c]

        tdf#159379 sw: fix crash on dropping multiple as-char images
        
        Have an empty Writer document, set preferences so images created via
        drag&drop are anchored as-char, drop 2 images from a file manager,
        crash.
        
        The root of the problem is that the first image gets dropped fine, but
        the second one would be anchored to the currently selected graphic node,
        since commit 651527b4efe9700c8c8dff58ce5aa86ad5681f16 (sw: fix
        double-click opening frame dialog, not graphic dialog on images,
        2022-04-26).
        
        The new SwTextCursor::GetModelPositionForViewPoint() returning a graphic
        node for a point inside the image looks correct, so fix the problem by
        extending SwFEShell::Insert() to take the anchor position as the anchor
        for the new image, in case a graphic node is selected.
        
        The original use-case would use SwEditWin::ExecuteDrop(), but keep the
        test simple and invoke the underlying SwFEShell::Insert() instead, that
        also triggers the problem.
        
        Change-Id: Ibba57aa28d0616ded16b4abb314f04974f1b8f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166499
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [fd2aaac24712550e4bbd349575192edb56bc94c9]

        ITEM: Add measurements for SfxItemSet usages (debug only)
        
        I was wondering how much of that arrays of pointers
        to SfxPoolItems is actually used in the SfxItemSets in
        real office runtime, so I added code now to measure that.
        
        It does use the state of the ItemSet at destruction,
        so it is possible that items were added/removed which
        are not covered, but most cases of internal usages do
        not do that.
        
        I then check/sort the collected data at office shutdown,
        it will be printed as SAL_INFO when svl.items/vcl.items
        is set, so use this to see the data.
        
        This gives info about the average space utilization in
        different ItemSets with different sizes, also gives an
        insight about used ItemSet sizes and amount of their
        usages.
        
        Of course results differ from app to app and dependent
        of what is done with the office, but interestingly when
        using quite some files opening from all apps it
        toggles/normalizes to something around 20-25%...
        
        Change-Id: I3eb2f0401c39a5bdb5d1d8176e95df07be4c111a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166455
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2024-04-23  Justin Luth  <justin.luth@collabora.com>  [a29d91ac403f1ed431ca95b8b9c290bd354c3ae7]

        xlsx export: never export short-hand version of range address
        
        If all the columns are in focus, LO was exporting
        A10:XFD11 as 10:11.
        
        Amazingly, we can't read that. Seriously?
        Doesn't Microsoft ever export in shorthand?
        
        I thought it would be helpful to find any instances
        where LO is exporting shorthand, to verify that
        we really do break import of round-tripped files.
        
        I made a brief attempt at fixing the import,
        but it will require lots of changes
        and break lots of assumptions.
        Obviously it can't be a hugely common problem
        because I didn't find any bug reports about it...
        I abandoned my attempt because it is too prone to disaster.
        
        Change-Id: If59c316d0af466e5cf71ecc459bdf57bb2cd5144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166269
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [c356b68656e57248123d333abd87803e4e89e8eb]

        Fix XAccessibleSelection::getSelectedAccessibleChild doc
        
        The valid indices to pass as params to
        `XAccessibleSelection::getSelectedAccessibleChild`
        depend on the the number of selected children, i.e. the
        return value of
        `XAccessibleSelection::getSelectedAccessibleChildCount`.
        
        The previously mentioned
        `XAccessibleRelationSet::getAccessibleChildCount`
        doesn't even exist.
        
        Change-Id: Iaabbc9e3972c7a8274495e19978db9eae36077fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166466
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [f063aac5143f14226f3e909c3d0a87e040d03538]

        editeng a11y: Switch DBG_ASSERT to real assert
        
        All current callers check the index before calling
        `AccessibleParaManager::IsReferencable`.
        
        Change-Id: If585e11eba3c48037b65439e8b95cb8d27bd4ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166465
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-04-23  Mike Kaganski  <mike.kaganski@collabora.com>  [7f64148507a360825e9c28ddb7077996df9fa092]

        Fix a thinko in 8a97f1ba8d9ccb65b2c89106de20666311d90c30
        
        Change-Id: I07bb67e9384470269d1fd3df087acee377cce729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166490
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-22  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [ea43cbbb7371a743f470d949762a0e92f196e652]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 75545d298523dc4a83e98703b9666d35b0f2cb56
          - Update widget names
            
            Thanks to Elisabetta Manuele.
            
            Change-Id: Id544a765c9fb04fb945b51efc18351e2f5c56736
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166474
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-04-22  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [132ed1b713f7379589bd6906036b157301f27209]

        tdf#94535 Update a Tip of the Day with new command name
        
        Change-Id: Idba9a4d050617e14db62cdf9bc4c62f0916cc032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166472
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-22  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [741d5ce6abe5158e6a822a171ab738037fd9422a]

        fix broken link to OSI image in README.md
        
        and use SVG instead of PNG.
        Link had been broken for more than a year.
        
        Change-Id: I003c177f69630cd049a8d7df17bc4b02f45aa458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166473
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0b552f0302a328d8a7078069670ff39dcc9ee8ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8e52ea49a05ac9af1f848cdf346e7db3cd98cf3
          - Fix typo
            
            Change-Id: I461574a961a46ba9283324654643eef40dfbf6bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166470
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-04-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [278828dce69d3fc143a81d7d40f9e9368f8e2c89]

        thesauri list can be empty at preload
        
        if none of the dictionaries are installed, seen in a bare bones docker
        image, giving a backtrace of:
        
        /usr/bin/coolforkit(_ZN7SigUtil13dumpBacktraceEv+0x73)[0x632d83]
        /usr/bin/coolforkit[0x6331a5]
        /lib/x86_64-linux-gnu/libpthread.so.0(+0x12980)[0x7f48788b4980]
        /opt/collaboraoffice/program/libuno_sal.so.3(rtl_uString_assign+0xc)[0x7f487070582c]
        /opt/collaboraoffice/program/libmergedlo.so(+0x20f9478)[0x7f4873cbc478]
        /opt/collaboraoffice/program/libmergedlo.so(+0x20fa3c4)[0x7f4873cbd3c4]
        /opt/collaboraoffice/program/libmergedlo.so(+0x27e6d82)[0x7f48743a9d82]
        /opt/collaboraoffice/program/libmergedlo.so(+0x27e8eac)[0x7f48743abeac]
        /opt/collaboraoffice/program/libmergedlo.so(lok_preinit_2+0x1c)[0x7f48743ad31c]
        /usr/bin/coolforkit(_Z13globalPreinitRKSs+0x1e8)[0x5dfdd8]
        /usr/bin/coolforkit(_Z11forkit_mainiPPc+0x1582)[0x5aa482]
        /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7)[0x7f48784d2c87]
        /usr/bin/coolforkit[0x56c392]
        
        Change-Id: Ib3a8ada7c22611e04e9db8dfa7cb0e227ece0f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c503b6eef32055f75dc9cf761bd20eda4f161dd4]

        tdf#160431 Inverts webp file image when inserted
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I3b2959c99a2e18c3972920f8ca86072566d54225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166450
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Jim Raykowski  <raykowj@gmail.com>  [5740d3fa83e9725a2771e5f00ba4aaf9965f0be2]

        Resolves tdf#160731 Navigate by recency does not work under gtk3 +
        
        wayland
        
        I think the lines of code removed by this patch were meant to allow
        recency to remember the cursor position before being moved to a start/
        end/previous/next word or sentence position by an UNO dispatch command. These are already taken care of in the slot execute function void
        SwTextShell::ExecMoveLingu.
        
        Change-Id: I8bf231ea4cbb03125f54332a41c5544f9094b768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166350
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0cf755adbb39591e9f6d273bfe5dce2469a86dbf]

        add undefining FORTIFY_SOURCE to the gcc no-opt flags
        
        We build non-optimized files by adding the no-opt flags to the compiler
        options that include the optimized flags, so add undefining
        FORTIFY_SOURCE to the -O0 line
        
        motivation here to have --enable-hardening-flags not add unhelpful
        extra warnings to the build for the parts built with -O0
        
        Change-Id: Ib5416ad7f9f5ef907d7c767a5ebff6343b035cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166458
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-22  Julien Nabet  <serval2412@yahoo.fr>  [53ab6269215d4e37af3f9dfaae2a306e040c5b88]

        tdf#150082: LO Base MariaDB/MySQL connector don't accept auth via gssapi
        
        Exclude Windows since we're not sure gssapi.h is available (at least Jenkins Windows machine doesn't have it)
        
        Change-Id: Iba396f77b07dce4291de5eb0e6ad7c0c25e6c3c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159954
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [851f60697d32849454528e5f14ed80446b330e0c]

        tdf#159660: also add normal blend filter
        
        Change-Id: I3edc7495975618357f002536857a11dcc72cc0b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166460
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  AhmedHamed  <ahmedhamed3699@gmail.com>  [fcc5770dd1e33dcb4f4f0c28683569af5d1d8368]

        tdf#61313 Replace the static ">=" with a dropdown of different operators
        
        The problem is with conditional formatting using icon set, as the icons order is fixed.
        It is solved by using comboBoxes for condition mode in ScIconSetFrmtDataEntry for every icon, and adjusting the UI file.
        A function that compares according to the currnt mode is added.
        Related CppunitTest files are updated.
        For every cell, last valid condition is applied.
        
        Change-Id: I489206d349a46092b307203c180705f42883183d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165701
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1097686ebddd48b78816d87524caadd17b788c23]

        tdf#160782: convert to bitmapEx from 0,0 to width,height
        
        This is the way it's done everywhere.
        Partially revert 4b6e0f2c88debaedb514c868e061c21e15215b6e
        "tdf#160726, tdf#48062: Simplify how BitmapExs are created"
        
        Change-Id: I15fea0b6855a65da7cb48b24fc00ba303e33dcf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166456
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [af9ae41d6766d9103199f7c41380789ee7740224]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 341704f9e4ce2dc4aa82a8d92f3b6d2e8db648e7
          - tdf#102265 More work on Impress format menu (4)
            
            Change-Id: Ib88aa1b88c6e3220aa0fb87510b3e736cf61b1c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166464
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [08141d993f489e041e631e8bce4d200134c2e326]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 54b758c1d7357d3a63fc9991c8888911d40c11d0
          - tdf#102265 More work on Impress format menu (3)
            
            Change-Id: Ie14e0364d2a8ddb9d9d50288fb7a7e28f7cc6a80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166463
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7346373d8e4b8c4465ee22b77ec78334f384b92c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f674b960e776a70c916e508073cfa3f2e2269a1
          - tdf#102265 More work on Impress format menu (2)
            
            Change-Id: I165dccf3662a98a0d4d945c3541f5d6d24ae8c86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166462
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [226544bfed764441a4545f3ff41f977fa5d71c72]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b3bc84641ec3c0b543682c9394789e86345e8e5
          - tdf#102265 More work on Impress format menu
            
            Change-Id: I7edb4893d9f65eb05694f777a0ef730454851101
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166461
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-22  Miklos Vajna  <vmiklos@collabora.com>  [116ac059a3c30146d7a30bd917e048256f7b3cd8]

        Update pdfium to 6425
        
        Drop parts of build.patch.1 and the entire include.patch, which are
        probably obsolete and don't apply anymore.
        
        Change-Id: I18c8d5e2ee97c7793e75ac0e47b5705b99585d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166415
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [8a97f1ba8d9ccb65b2c89106de20666311d90c30]

        tdf#160773: handle 0-size font height
        
        Regression from commit cc3663bbaed4f65d64154e5f9abb51a5f622f710
        (tdf#160702: improve text positioning, 2024-04-20), where I didn't
        know yet that this was possible :-)
        
        Change-Id: I1316db48b8acbacd077eeb4a8989c3dbf7e4a7b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166425
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-22  Luv Sharma  <luvsharma.del@gmail.com>  [a400c865a6c9f0185a1986db617ee6fc9dd1861d]

        tdf#93727 Syntax Error on # in basic
        
        Change-Id: I400a4061de580a5c91b0e4763cad40ae88a9f738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162639
        Tested-by: Jenkins
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-04-22  Armin Le Grand  <Armin.Le.Grand@me.com>  [ba431d2bcb70b64bf0eaec29a09916ea37755235]

        Revert "IASS: Correct Buffering of last Slide"
        
        This reverts commit 77eb3f1a76892b6070e77324e260204408383ef4.
        
        Reason for revert:
        Better solution in https://gerrit.libreoffice.org/c/core/+/166177
        which is 052c668da38b70943d24770895abc8119aace2a6
        
        Change-Id: I42248771c993bcd04c2fe368795db4e1fe7a2586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166212
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [41368edc6e2b16d4e0ea89b822064bb75dfadc01]

        tdf#159660: Add support for lighten mode in feBlend
        
        Change-Id: I17471a9c70a38d05de5ad476f817285fb2438e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166429
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a9f1b705275ef9abbcf17366d8f3713235dd4675]

        tdf#159660: Add support for darken mode in feBlend
        
        Change-Id: I56862163b7bf1177120081c95ab7851a5fc4019b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166428
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [fdf3027a0eb8270d527b3e64c6157917a6718787]

        tdf#159660: Add support for multiply mode in feBlend
        
        Change-Id: I03230e122a10dd6ada6af357c674c278b6b99d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166427
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [07137ccd7fbbf3afb1cabfc6ca71375293910a3a]

        configure: cygwin issue with date fixed
        
        previous variant was causing: "bash: /dev/null: ambiguous redirect"
        and value was written
        
        Change-Id: Ic8762a98f11ef2fee669478b5694ae1c5fb0b8ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166294
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9f98223f22843058568552cce98417799c096ed9]

        Update git submodules
        
        * Update translations from branch 'master'
          to b2b2c286fed6e5116acc819a44c69214af3f993b
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I58b4c71142984e8e7cb21b2e269c0aa658b8c73f
            
2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b00e3093af7771765c1507c7c22436174411be53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b066c7f1008ce7d433683324dc9ef441478c832c
          - win doesn't like (foo || bar) | … construct, suspends xsltproc
            
            not always/reproducible but often enough when using git-bash to get
            annoying when building with all langs/when that is run in parallel
            Splitting this up makes it more reliable (or I just have been lucky)
            
            btw: why is this split-per-app when the final bookmarks.js is a simple
            concatenation of all of them?
            
            Change-Id: I629a302237b32da8ba77460e0415f32d50105ae5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166320
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [df62514556b4220a4c099c00a34f28dd7fe88626]

        add generic %/.dir target that can be used in order-only prerequisites
        
        Change-Id: I7a919004100ff6319806bbdf016fda6a3a39661a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166327
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5511a7b77bcceb812737533de1184c5d009f0a78]

        avoid exceeding command-line length limits when using zip
        
        to package an Extension. With all languages enabled one can reach the
        limit with longish buildpaths
        
        Change-Id: I8943d6570ded57761350311fb34a0cf469d3ce83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166326
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [357e390be47f774aab8ffb09015aaf312abff06b]

        tdf#159660: premultiply colors for screen blend
        
        This is needed after 4b6e0f2c88debaedb514c868e061c21e15215b6e
        "tdf#160726, tdf#48062: Simplify how BitmapExs are created"
        Otherwise, only the common area is displayed
        
        Change-Id: I40c798380049e62df8729c4acdb5db50d988d8e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166426
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [80a6564e071033fd64536cb6c538cd422a82c86a]

        com_MSC_class: set MAKE=nmake in gb_NMAKE_VARS
        
        Change-Id: I485a486efba39c12c52d7461f4b235163f009042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166325
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a89dbe925d24968f5d4391ff02be2bee83f42867]

        REAL_CC[_CFLAGS] are already set by gb_ExternalProject_run
        
        (and that also takes care of proper quoting)
        
        Change-Id: Ic8c29300a2e6d5381c0d8873572f7c076362c93d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166324
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Sahil Gautam  <sahil@libreoffice.org>  [1cfc2e2c92e1259341ee18cf87be63c4dcebd33d]

        tdf#63374 Change cell background color when in edit mode
        
        Set the edit cell background (EditView) color to CALCCELLFOCUS
        and allow enabling/disabling via a checkbox
        tools > options > Calc > View > Edit cell background highlighting
        
        Change-Id: I1216dfa0880e1080d23059512e3801d6af3b3c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165075
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [44f48621a600b4b013115e2671c657725b77883c]

        help: don't use clean targets as .PHONY targets
        
        Change-Id: Ic86270980823efb8dafd9d00ce33f986203cd975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166323
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a7a4984b58cf7cb84b0157ca68ee9191043ca65b]

        configure already sets TMPDIR to mixed path
        
        Change-Id: I72070b054fb505c25f03ff46e7e663d1c1733ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166322
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [55c8095703e6e4521ba58181c561ec62a70d727b]

        loplugin:constantparam filter out workdir/ stuff earlier
        
        Change-Id: I5b90bd855a74b03d534ce64689361b7417293a6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166422
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a50045cd9b2a6587f71c1c104c59b1309eeffbb7]

        loplugin:constantparam
        
        Change-Id: Ic34679736973ed1f10ced8c9f0846514fa556445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166421
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc94047616aaa22c3cd982ee978c320b897f9629]

        loplugin:constantparam
        
        Change-Id: I42e35e3474a222d57cb0b911060710c0c49d0b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5b511b8470299caa99bf34ffac0fe272dfe9ec9]

        loplugin:constantparam
        
        Change-Id: I0e91da1e48326495f841b53f999a0d31ecd1a36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [257954b740e7eecfc74a8d9833f131747b7ee974]

        loplugin:constantparam
        
        Change-Id: I8ae27f060e46548aa364db8c6b82d77e6c8f3d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Noel Grandin  <noelgrandin@gmail.com>  [6adef53aa9870c8f3c8cc1bb6c475e253d41077b]

        use more OUString literal
        
        convert some functions which merely create an OUString on the fly
        from a char literal to 'constexpr OUString' literals
        
        Change-Id: I617490baf2d976291b324cc991b59cd18f4b242c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b6e0f2c88debaedb514c868e061c21e15215b6e]

        tdf#160726, tdf#48062: Simplify how BitmapExs are created
        
        In my initial approach, I tranformed the primitive2DContainers
        before converting them to BitmapEx. This caused circles like
        https://bugs.documentfoundation.org/attachment.cgi?id=193790
        not to be displayed.
        Simplify how BitmapExs are created by just using the range both
        primitive2DContainers have in common. This way, DrawBitmapInRect
        can be dropped now
        
        Change-Id: I2401dc87b98e04b9cf9f5ebade2b5622d884fc3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166391
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [196c22e88138796fb1204610bd5d4ad8b8cd8a85]

        generic is x86_64-specific
        
        Change-Id: Ic9912cdebfc75816c54495db4fef68ebeed32c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166417
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [e902fe1b8bf03f9c3747685314f4d443bcea9333]

        Use designated initializers for clarity
        
        Change-Id: Ie10e657e07981e6fd0f0804371fd30f2b3f143b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166430
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c0f44787c0bcbd28ac61dab66483f025578f095c]

        pivot: handle whole row/column selections, added many tests
        
        This adds support for selecting whole rows/columns, where the field
        reference is set but no indices are present. This means that all
        the data cells apply (selecting the whole thing), which are not
        subtotals. For this the support for multiple matching and maybe
        matching results was added (previously max 1 would apply), which
        would apply the pattern to multiple cells in the pivot table.
        
        In addition handle labels of columns with multiple data fields
        correctly.
        
        This also adds many more test scenarios, which all cover the
        changes mentioned above.
        
        Change-Id: Ibcdaa933c69991eaa55a2ad18b9f9a838308d478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166384
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [37b1799fa163455c5120429ae1537ba5c6ec8d23]

        pivot: add reference image to the test files
        
        Change-Id: I2532bae611bc815b270187dc6b9a07b47837962d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166383
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-22  Weblate  <noreply@documentfoundation.org>  [7de034b1e4467dd39bd08c7bab53b5a00c5269fd]

        Update translation files for android-viewer
        
        Updated by "Remove blank strings" hook in Weblate.
        
        Change-Id: I860c8e56454c26123414f842517461507b8a0f3f
        
        android-viewer translated using Weblate
        
        Interlingua currently translated at 63.5% (75 of 118 strings)
        
        Change-Id: I9159b9b5b3c37adabb078af9b394214217564538
        
        Added translation for android-viewer using Weblate (Interlingua)
        
        Change-Id: I1e6a22c54275747ac05825459574e522e1b0ea40
        Co-authored-by: SoftInterlingua <softinterlingua@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166116
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-21  Sahil Gautam  <sahil@libreoffice.org>  [695e8742da850bbb15c2e6d2b5d4c99a0daf4925]

        tdf#80390 Use local copy in anonymous function.
        
        The nCount object might go out of scope, as it's used by
        an async function.
        
        https://gerrit.libreoffice.org/c/core/+/164316/comments/507b830b_001a71eb
        
        Change-Id: I4218f6e35b61704115047481cb97a193c593a072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154750
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae5e743f90fbb4e7016d6d9f4c22bce971a5f5cb]

        svgio: feImage and feFlood don't support the in attribute
        
        Added by mistake in b22039cff8380b158307e75762bd3e4ca045d77b
        "related: tdf#159947: only parse in/result if the element supports them"
        
        See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/in
        
        Change-Id: Ie8b5591349eff710d1edc7f413790ac9d31df99d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166389
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b93a481d8a7ba396d29224403ca05ebe354aa0b3]

        -Werror,-Wunused-variable
        
        ...ever since the code was introduced in
        0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de "tdf#156146 tdf#159903 sw: add unit
        tests"
        
        Change-Id: Ib53b98f6f1ce460bda6b06a7b082a28a49f05a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166388
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [79daf83584c6faab641b3d73999871b5c235d222]

        Related: tdf#160056 add number format info to ScPatternAttr cache
        
        2411.71ms -> 2395.36ms
        
        Change-Id: Ie6a3f281b56e827b77dddd1eb8ae6db9d2691c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-21  Julien Nabet  <serval2412@yahoo.fr>  [0cb63cd392a9ee7b355028722121ac1ccead7336]

        tdf#144256: Missing destruction of FirebirdDriver, OSDBCDriverManager
        
        ... , OPoolCollection
        
        However destruction is called when closing LO, not when just closing the file.
        
        Change-Id: Iacb09b73de49b9635240d3b43e721b8b02d35afd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166370
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-21  Arnaud VERSINI  <arnaud.versini@pm.me>  [91d67c32f67f1fccf30cbb7980aeab83a9af1008]

        i18npool : limit string comparison using an enum class
        
        Change-Id: Iec5327b6f0125b22a2a4ee8ccb789b5403a7fdb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c81fe7f7e4b416f818d7dfd8e141bccebce37a16]

        crashtesting: crash seen on import of forum-mso-en4-602306.xlsx
        
        Change-Id: Ib8bd453483c72382330b4c960cdbe735bdb97eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [84e56a1ccfb190ce28352f946fa38999491b3086]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 183a14d99cbf6b18fa7d3d059a2ff0639520a205
          - tdf#152499 Help page for Select UI dialog
            
            Help part
            
            Change-Id: I3fa18868abed3b738b699a7abcc216aaa90df12d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166196
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [92e567570c1ea49bc7b63fca2b0f5ad101c63471]

        tdf#152499 Help button for Select UI dialog
        
        Core part
        
        Change-Id: I6344c93b187ac0835faf13a06f02cd2a9fe0fcd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166195
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-04-21  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [b79e0dd7fc8bc620420ed65edbc105eec3648b34]

        Resolves tdf#58434 - Show formatting marks independently from fields
        
        Field Shading / .uno:Marks toggles now only fields, footnotes, tox etc.
        and Tab, SoftHyphen, Blank, as well as ControlChar depends now on
        Formatting Marks / .uno:ControlCodes. Field Shading also does not
        toggle HardBlank and SoftHyphen, and what control character is shown
        respect the options under Formatting Aids
        
        Change-Id: I63c826e7fdc09ec95f17aee9735d4f5de9a1b897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166033
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-20  Sahil Gautam  <sahil@libreoffice.org>  [05a1217921b7be283c6750a35b90e4feda6e993e]

        tdf#80390 Extend InsertCells Dialog to allow adding a set of Rows/Columns
        
        Change-Id: I103574d720fef685b806943672a2aeb1fbf87097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164316
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-20  Jonathan Clark  <jonathan@libreoffice.org>  [64743ee6bc9567015f164333ed9b508542017337]

        tdf#49885 Removed custom Thai BreakIterator
        
        Previously, a custom BreakIterator was used for Thai grapheme clusters.
        This change deletes the custom BreakIterator, in favor of the ICU
        implementation.
        
        Change-Id: Icec94c73a5734c2059786dfbba085f487c488d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166156
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7137a52a8d04f0507b536b74ee00a69b66649788]

        ofz#68172 Integer-overflow
        
        Change-Id: Ie80487e20217d7a54cb401b0423dfec01df1292e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-20  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [3bfd7ae3d414cae3bb4e582c2a2562d7b08887cb]

        Fix Unicode block name
        
        See https://unicode.org/charts/PDF/U0080.pdf
        
        Change-Id: I6bc3117abb486cc2cc38870ed91185c62eaa9361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166243
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-04-20  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [b4be47efb848bd5209cb1f2d915c22814b516d32]

        fix linker error for PCH build
        
        Error was:
        
           ld.lld: error: undefined symbol: LanguageTag::~LanguageTag()
           >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
           >>>               core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&))
           >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
           >>>               core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<LocaleDataWrapper, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&>(LocaleDataWrapper*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>&, LanguageTag const&))
           >>> referenced by stl_construct.h:119 (/usr/lib64/gcc/x86_64-suse-linux/13/../../../../include/c++/13/bits/stl_construct.h:119)
           >>>               core/workdir/CxxObject/sc/inc/pch/precompiled_vbaobj.o:(void std::_Construct<CharClass, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&>(CharClass*, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, LanguageTag const&))
           >>> referenced 5 more times
        
        Change-Id: Ie84d062d1815aa8e8118171862e0f8f64331d769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166346
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-20  Justin Luth  <jluth@mail.com>  [00ef339bfc747897b8e4410fa0aa4397c4e45717]

        tdf#81956 vml import: put groupshape in foreground if positive z-index
        
        no interesting unit tests found, but this one at least lets you
        add text to the body and visibly see the effect of foreground/background.
        
        make CppunitTest_sw_ooxmlimport CPPUNIT_TEST_NAME=testN751077
        
        Change-Id: Ib03e6b429ad4ec6a38d1119f3720bc56a70b98eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166345
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1d419280f70ecfe0cb4b3c0968492f4e2c7d93a3]

        bump odt2pdffuzzer max_len
        
        Change-Id: I602b24eb624420549b0fde23e662db7700e23da0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166372
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-20  Jim Raykowski  <raykowj@gmail.com>  [ca66965507494d0c5e07bfe81334749bc08af409]

        tdf#146190 Fix move to next drawing object using the tab key
        
        after double click on a drawing obect in the Navigator doesn't move to
        the next/previous drawing object when there is a number rule at the
        current current cursor position and the current cursor position is at
        the start of a paragraph.
        
        This patch reworks the SwWrtShell::GotoDrawingObject function so the
        document cursor position gets moved to the position of the drawing
        object when the object is selected.
        
        Another way to get expected results is to leave the GotoDrawingObject
        function as is and move:
        
          else if (rSh.GetSelectionType() &
                   (SelectionType::Graphic |
                    SelectionType::Frame |
                    SelectionType::Ole |
                    SelectionType::DrawObject |
                    SelectionType::DbForm))
        
        above the:
        
          else if( rSh.GetNumRuleAtCurrCursorPos()
                   && rSh.IsSttOfPara()
                   && !rSh.HasReadonlySel() )
        
        in the SwEditWin::KeyInput function case KEY_TAB: block.
        
        SwWrtShell::GotoDrawingObject is made SW_DLLPUBIC by this patch to able
        to be used by the included unit test.
        
        Change-Id: I047b416ae94a9284d304798924e0c5f2be526f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166089
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [57f4581e326453ebed8fe688ade924804aae46dd]

        ofz#68081 Use-of-uninitialized-value
        
        Change-Id: If632bd8d503f5e8c9acdab912ac0bc8a00dfd534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166308
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [992c821416817534c53338665e254c0dc554ea51]

        Simplify a bit
        
        Change-Id: I824b8670f7f2d6409ae98fe1a107c6c430fc1bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166371
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [94c97ecdbfa606401fb53685048731128186672b]

        gtk3 a11y: Set a11y relations for custom combobox impl
        
        As described in more detail in the previous commit
        
            Change-Id: If5faf77c5f82836c376c04bb6e4e42ce5a3023a2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 18 14:02:25 2024 +0200
        
                tdf#159910 gtk3 a11y: Keep a11y props for combobox
        
        , the gtk3 VCL plugin uses a custom combobox implementation
        rather than the stock GtkComboBox.
        
        Similar to how the above commit makes sure that accessible
        role, name and description set for the stock GtkComboBox
        are also set in the custom implementation, do the same
        for the accessible relations as well, by taking over
        the relations from the GtkComboBox to the toggle
        button of the custom implementation as well.
        
        One particularly relevant relation in practice is
        `ATK_RELATION_LABELLED_BY`, because the target set
        via that relation is what screen readers tend to
        announce when a combobox receives focus and doesn't
        have an accessible name set for itself.
        
        With this change in place, the Orca screen reader
        announces the corresponding label e.g. in the
        "Format" -> "Character" dialog in Writer, tab
        "Font Effects", so e.g. "Overlining:, combobox"
        is announced by Orca when the combobox for setting
        the value for the overlining receives focus,
        rather than just saying "combobox", which
        wouldn't make clear to the user what this
        combobox is for.
        
        (This also matches what Orca already does for
        the qt6 VCL plugin.)
        
        This change only takes over the relations
        set for the combobox itself. Usually, relations
        are set both ways (e.g. the target of the
        `ATK_RELATION_LABELLED_BY` relation would
        itself have an `ATK_RELATION_LABEL_FOR`
        relation with the combobox as a target).
        If necessary, this solution could be
        extended to also iterate over all the
        target objects and check whether they
        have relations with the combobox as a target
        and set corresponding relations to the toggle
        button as well (or instead).
        
        Change-Id: I05e39ef5606ffa49ca7673039de3e1aa74fc8649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [1e851093f0148d2c55fc3fd377d274f6703c71c9]

        tdf#159910 gtk3 a11y: Keep a11y props for combobox
        
        Due to various issues with GtkComboBox, the gtk3 VCL
        plugin does not use the original GtkComboBox, but a
        custom implementation, originally
        introduced in
        
            commit bc0e0f633b05c4f91b6695488fc9e5c127507ba5
            Date:   Thu Apr 9 11:41:00 2020 +0100
        
                tdf#131120 use a replacement for GtkComboBox
        
        (See full commit message for more details and reasons.)
        
        This means that the accessible role, name and description
        from the .ui file are not set automatically for the
        GtkToggleButton widget that acts as the combobox
        instead and receives keyboard focus.
        
        In order to make these available for AT, explicitly
        take these over from the original GtkComboBox.
        
        With this in place, the Orca screen reader now
        e.g. properly announces the comboboxes in Writer's
        Navigator as "Navigate By, combobox" and
        "Active window, combobox" (similar to how it already
        does for the qt6 VCL plugin), rather than just saying
        "toggle button, not pressed", which didn't give any hint
        to the user what the currently focused UI element
        is about and how to interact with it.
        
        Also set a default a11y role of combo-box in
        the replacement's .ui file. (The role from
        the GtkComboBox's AtkObject should always override
        that in practice, though.)
        
        Change-Id: If5faf77c5f82836c376c04bb6e4e42ce5a3023a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166248
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [9bb46a8e9819fa74dee53b305a4255bb72a89e22]

        tdf#159910 gtk3: Resave vcl/uiconfig/ui/combobox.ui with glade 3.40
        
        ... before doing more changes to the file in an upcoming
        commit, to keep the diff clearer.
        
        Change-Id: I3da5d9d708681888418251139e1d5aad4c152ad6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166247
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [b9f51395bd763d01c8ac2b957ac047ff07fbcdfc]

        tdf#159910 sw a11y: Set a11y name for Navigator combobox
        
        Set a11y name for this combobox in the Navigator to
        "Navigate By".
        This is in line with the tooltip shown when hovering over
        the combobox, which is set for the combobox's parent,
        the panel.
        
        This makes Orca with the qt6 VCL plugin now announce
        the a11y name of the combobox with the corresponding
        role, rather than the panel
        ("Navigator, panel, Navigate By, combobox" instead of
        "Navigator, panel, Navigate by, panel, combobox").
        
        For gtk3, Orca still doesn't announce the combobox or
        it's a11y name set in the .ui file, but still just says
        "Toggle button, not pressed", which will have to be
        addressed separately.
        
        This is because while there is a combobox with accessible
        name "Navigate By" in the AT-SPI tree now, the object
        that gets focus is a toggle button that doesn't have
        a name set for the gtk3 VCL plugin, which will be
        addressed in a separate commit.
        
        Change-Id: Id6b615f033c78d318611b520d49332714fa40eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166246
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5bc241d197ed946fc4a2ba4901e25c7f82cab85]

        cool#8571 use better algorithm for generating selection overlay
        
        when we know that the selection overlay consists purely of rectanges, we
        can use a faster algorithm to generate the combined polygon
        
        Change-Id: I15129facc6e682261fb59e79cf93b0e9d9e114b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [20e2b922da0d4d49a5e1a88fddea77ade92cbdf3]

        related tdf#33603: sd: do not assume there's always a viewshell
        
        Change-Id: I171639150a84372e7e25b5246d4882c467edd58b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166271
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [6e6081b3401de3a4799953edb5cccbeadcce6a2c]

        tdf#157103: fix SVG whitespace handling
        
        Previous code tried to hack some tricks to restore whitespaces after
        trimming them according to the xml:space attribute value. But it was
        wrong in multiple ways.
        
        1. The collapsed space must stay in the block where its start was.
           When a block ended with a space, then trimming the space from it,
           and adding to a next block, can change the size of the space.
        2. The shift of a line (e.g., specifying x and y values) doesn't end
           the logical line. A space before such a shift must be kept by the
           same rules, as if there weren't a shift.
        3. A block with xml:space="preserve" is treated as if it consists of
           all non-whitespace characters, even if its leading or trailing
           characters are spaces. I.e., a trailing space in a block before,
           or a leading space in a block after, should be collapsed into a
           single space, not removed - even when the space-preserving block
           itself is made invisible.
        
        Change-Id: Ic778d1e9d6b9d0c342ea74ad78d44bb47bc8d708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166239
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e0ddf83cefe78b688fcca805ecfe55899432c56]

        loplugin:constantparam
        
        Change-Id: I4963987a63d82dfe086932307675f92deebb8883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e6ddfdf040f88d19e5ec9b4d10b8cccd79155ad1]

        Embind: Test and Fix out-param handling
        
        (the types that are meant to be passed directly by pointer will need more
        thought, to make them actually work)
        
        Change-Id: Ia0f2e6f5335fad1140629477e89fc96121c2927e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166318
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1bf2d3fa8ed016eaf71d8b3acc3fc779ee32e223]

        Embind: Drop $equals, add sameUnoObject
        
        $equals was the last remaining special $... method that we added to the UNO
        interfaces, and it looks better anyway to turn it into a symmetric free function
        (that can be called with null for either argument) that is actually independent
        of specific interface types
        
        Change-Id: I22a1d08b8b15a0ed2dd37fa9fbc95f568641dec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166317
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1c8893876015b667fba5dabbc9d4422896021898]

        Embind: Don't use new when getting UNO singletons
        
        Change-Id: I23265f46b25cb88796267abe28aac1100523e71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166298
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [faac1cda391865c304d853a553aad3dabd05e263]

        cid#1596242 Side effect in assertion
        
        Change-Id: Id9ffa49ae61824ee155cd4b5373d882381b40db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ba388ee8c7eb8db66b45c541e1e8421756e8b52]

        cid#1596521 Resource leak
        
        Change-Id: I3064195408e508f1f77d22b82ad464a651064193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [cc3663bbaed4f65d64154e5f9abb51a5f622f710]

        tdf#160702: improve text positioning
        
        Opening an SVG with text in different elements (e.g., tspans) in the
        same text element performs calculations to position the parts properly
        (i.e., the next part will start where the previous part ended, unless
        the position in overridden explicitly). These calculations require to
        know the text widths. The first problem leas here: the text width was
        calculated for a typically small text size (numerically equal to the
        pixel size defined in the SVG), but these calculations aren't truly
        linear, because font rendering may change depending on font height.
        Additionally, the rounding gives much higher error in smaller sizes
        than in larger. There was already a workaround for a similar problem
        in ViewRedirector::createRedirectedPrimitive2DSequence, where a large
        font (with 100 times greater height) was used to increase correctness.
        This was also used here, with the same large height (50000) used as a
        reference.
        
        Then, at the time of wrawing the text at different zoom levels, the
        code in VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D
        creates a font of a calculated size, and uses it to output the text.
        But the font is always created with an integral height, which means,
        that for a wanted height of 2.5 (in a zoomed out view), the really
        used height will be 3, which is 20% larger; or for wanted height of
        2.4, the actual height will be 2 (20% smaller). This resulted in odd
        jumps of the text widths, when the text may overlap the following
        part, or conversely, create a big gap before the next gap. To try to
        mitigate that, the function now takes the difference between the
        wanted and the actual font size into account, and adjusts the MapMode
        accordingly. This doesn't fix the jumping completely (e.g., because
        of the mentioned special handling of small font sizes in the fonts
        thenselves, like hinting), but still makes the calculations much more
        stable, decreasing the amount of jumping. Similar changes are made in
        TextLayouterDevice.
        
        Use of the functions that return text size as a double, not rounded
        value, should additionally help improving stability.
        
        Change-Id: I455845d8ca43ee9c06a0fc980947f35d8a25797a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [cfa9990d470b10548c7fed64eb1182fea11d41e0]

        Enable this test on all platforms
        
        The original issue that prevented the test on Linux is reproducible.
        I didn't debug the cause, so this is just a workaround.
        
        Change-Id: Ifa8fa2a7884adabf797ea2d711f62b6be382dfec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166351
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c934fca37c747b5c77fa1ce21c7fef9c3df8689]

        loplugin:constantparam in sd
        
        Change-Id: I4943244d8c08d1d86e4c1ff9177b00cfa451e453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166315
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7933203b79adc0b5f8a72a9dc51633df9ded283]

        loplugin:constantparam in sw
        
        Change-Id: Ibb4d4d1cca59ece6bcd28e887f84d657dedee756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b38e1e82439d6338b08f2695712c038f32d2b52]

        loplugin:constantparam in sw
        
        Change-Id: Ia1379762ba957097a1a2134c5d206f254e22683b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4aea0b8423ab8f4d7942d66e61d64de448357c73]

        loplugin:constantparam in sw
        
        Change-Id: Idf7d3abd464b7be87d109d14adf94357a5d49dd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e68a5cfa9807ee5e4a83fd5c763d0e2fee3428e]

        loplugin:constantparam in sw
        
        Change-Id: Ia3e1b50954354973ffef701821f661cf782687db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [c9bf1e18bd80098d5498c831ee4586d04f003053]

        loplugin:constantparam in ucb,unotools
        
        Change-Id: I4161adac7544e7b1a8a7d8e18a3ae6c72ca77062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [7e0b8e74dd6de7a337ab08a8be2921aeef765117]

        svgio: remove duplicated assertXPathDouble
        
        Change-Id: I82c4abc6883d292114b4239efee60aee082357fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166307
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [089398e51409458c5438c49fb347e4f09d9c09dc]

        Return double from OutputDevice::GetTextArray
        
        And introduce GetTextWidth / GetTextHeight variants returning double.
        It allows to avoid premature rounding.
        
        At least in one case - testTdf145111_anchor_in_Fontwork - it allowed
        to make the test DPI-independent (at least in my testing on Windows,
        using 125, 150, and 175% UI scaling).
        
        Change-Id: I973d2c729ec6bb7114b4f99b9027f1ead7c1d061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166237
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-20  Noel Grandin  <noelgrandin@gmail.com>  [7b1405689d4246e0e37e8759f03e1962af964cec]

        reduce the number of drawing primitives we create in OverlaySelection
        
        and flatten it a little
        
        Change-Id: I3377f832658c504a2541c6994f7386adad06b0e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-20  Cor Nouws  <cor.nouws@documentfoundation.org>  [7c2ed9919d6d9d286d9062b91577d6bb2b7de8aa]

        tdf#160601 add expert option for default slides per row in slide sorter
        
        Change-Id: Ib122ad0fce8159c1ceb092bcc65a59ba1ad23bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166174
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-04-20  Justin Luth  <justin.luth@collabora.com>  [3b7ffa204c6d04640b5e2f4d4c6b6b4a03fd26c8]

        tdf#140616 ApplyParagraphMarkFormatToNumbering: including highlight
        
        I was concerned that I might override highlights
        set in numbering.xml but in that case
            pFormat && pFormat->hasItem(RES_CHRATR_HIGHLIGHT)
        so pCleanSet no longer hasItem.
        (see num3n.docx and TestDoc_highlight2.docx)
        Note: must use Word 2010+ to see numbering.xml highlights!!
        
        This is strictly a visual thing. Unit testing has traditionally
        used magic tile rendering x,y positions to check the color,
        which seems completely untrustworthy.
        
        Change-Id: I026252f127107e4782d08f72bfd5e2a412142111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166303
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-04-19  zeph  <zeph.chai@ymail.com>  [55b0ddf119714ce1221ceb098a8329de2716c448]

        tdf#143123 Port ChartInDraw / ChartInWriter examples to Python
        
        Ported two more SDK examples ChartInDraw and ChartInWriter from Java to
        Python.
        ChartInCalc and helper classes which contain additional helper methods
        were ported in a previous patch.
        
        Change-Id: Idffa0c07282dfc2c0f09ec5a9959f1db34a1d9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165088
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b1bba2f9633b27cd822270d79f01be19db9c640]

        tdf#160706 speed up loading conditional formatting rule in XLS (4)
        
        speed up the matching of duplicates in CellAttributeHelper by using
        std::set and partial sorting by name
        
        Takes my time from 33s to 6s
        
        Change-Id: I06376c1e253981cb5a3020142d24fa5776513d4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166262
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [038c1983122ada4cfe0c85b527940a410643ace1]

        Embind: Clarify need for emscripten::internal::raw_destructor specializations
        
        ...which are needed at compile time (the emscripten::class_<T> ctor always
        records the address of emscripten::internal::raw_destructor<T>, even in cases
        where it never calls it; and raw_destructor internally calls delete, but the
        dtor of the UNO interface types is protected) but not at runtime (as those UNO
        interface types are only accessed through css::uno::Reference smart pointers)
        
        Change-Id: I09e4f258f8dfc0fc53c0fe7210c7f709d86be176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166304
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [b209d17236778b5bd2ca8f519166e75447ed9117]

        mpReqFontName is potentially pointing to freed memory
        
        since we assign it from a temporary OString.
        
        No idea why this hasn't caused a problem already.
        
        Change-Id: I5480fb2ab5d1e07212ad804f99223946abf5a6c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166297
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [598ff4e2433a419a432fd54ed5dac560663ec107]

        loplugin:constantparam in vcl
        
        Change-Id: Ifab93e642773bcbf3801cee36bf3db66446febec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166295
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [c04c38f4841aff5eac78c92a7145b661a3a99c2a]

        loplugin:constantparam
        
        Change-Id: I58e31ffdfc87a15e82bce54afd47ff3906159707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [99c857afdaab9450f31b60723afd8c455947a712]

        loplugin:unusedfields
        
        Change-Id: I43b7a553177bbbdeebe37f7d7e63dfcb2ae70778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [78c613d7df5138f7da9132a6e4aabb1e78321e90]

        Emscripten: Drop unused, deprecated EXPORTED_RUNTIME_METHODS
        
        Linking Executable/soffice.html kept warning about
        
        > warning: JS library symbol '$allocateUTF8' is deprecated. Please open a bug if you have a continuing need for this symbol [-Wdeprecated]
        > warning: deprecated item in EXPORTED_RUNTIME_METHODS: printErr use err instead.
        > em++: warning: warnings in JS library compilation [-Wjs-compiler]
        
        printErr had been introduced in f090004c5f236275ca5142fc578f0375872c0336 "WASM
        adapt link and debug flags" and allocateUTF8 had been introduced in
        ce60a3dd4dbff0dcb5b82c9053ae5d90f8ac929d "Add LOKit functions and whitelist
        export for it to WASM", but in both cases no code seems to ever have made use of
        either of those two methods, before or after.
        
        Change-Id: I1e81ca6ddad748d91653f709c272328cc8f2b679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166296
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1c81f63e91d39187748ea070d064e996481dbd3d]

        Embind: Consistently represent empty interface references as JS null
        
        The existing code had two issues:  For one, e.g. calling a function that
        returned a null interface reference mapped that to JS null, while querying an
        object for a non-supported interface via `new css.uno.X...(y)` mapped that to
        an "empty" JS object instead.  (So checking for a non-null reference needed to
        be done as either `x !=== null` or as `x.is()`, depending on context.)  And for
        another, while calling $is() on a non-"empty" object worked fine, it failed on
        such an "empty" object (as the Embind internals of that object lacked the $$
        property).
        
        So change the querying mechanism from the `new css.uno.X...(y)` constructor to a
        `css.uno.X....query(y)` function call syntax, which now returns JS null when
        querying for a non-supported interface.  (And drop the broken $is method.)
        
        Change-Id: I8fa488ab2892423f2a461d9b72db47e1d4df3b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166255
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [41706fcd962a38627d20f62488c6110967396ee7]

        Embind: Don't expose special XInterface methods to JS client code
        
        Change-Id: I8592466b96406a1658d0a5a1b961142f862a9e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166290
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2e50b3850ba2074dba41e6ea07c9e7d236af0d6c]

        add --enable-hardening-flags to enable compiler hardening flags
        
        distros typically have their own set via C[XX]FLAGS, so make
        this an optional argument
        
        some notes on the options:
        
        -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=2
        https://www.redhat.com/en/blog/enhance-application-security-fortifysource
        (I see Fedora has recently bumped to to 3 since Jan 2024
        https://fedoraproject.org/wiki/Changes/Add_FORTIFY_SOURCE%3D3_to_distribution_build_flags
        but here use 2 for now instead)
        
        -Wp,-D_GLIBCXX_ASSERTIONS
        https://fedoraproject.org/wiki/Changes/HardeningFlags28
        
        -fstack-protector-strong
        (We already apply this by default)
        
        -fstack-clash-protection
        https://fedoraproject.org/wiki/Changes/HardeningFlags28
        
        -fcf-protection
        https://fedoraproject.org/wiki/Changes/HardeningFlags28
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=af55dc3891f7950d392175004b2090cb0e54828e
        
        and record the compiler flags in debuginfo
        -grecord-gcc-switches
        
        Change-Id: Ib05387bad8324b188bd4ed0ee327d6a7cf83973b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163312
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 33483058f6e27f39633114721f7329c90571101d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166289
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c6cdc5d5a1bf14155523b2817a96609068ae6ac]

        loplugin:unusedfields update for new clang AST nodes
        
        Change-Id: Icc47093ab13123e9cb2866434796c7d6e8eb38d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [0c7ae3bd96130eaa400d55a3ba9bf1e2fe6600de]

        tdf#156146 tdf#159903 sw: add unit tests
        
        Unfortunately the actual computed margins are not stored in text
        formatting data structures so are only available directly from
        SwTextMargin.
        
        Change-Id: Ia7ce5e148194a55b5d9874ed112aaa977ed16c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166258
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-19  Miklos Vajna  <vmiklos@collabora.com>  [4ffe06a81866a2c9f8598d194e04c114cc083119]

        cool#8789 sc lok: fix copy for multi-selections
        
        Select A1+A3 in Calc, copy, try to paste in B1, nothing happens.
        
        This is because lok::Document::getSelectionTypeAndText() for a Calc
        document ends up in ScViewFunc::CopyToTransferable(), which only handles
        the SC_MARK_SIMPLE* cases.
        
        Fix the problem by implementing support for SC_MARK_MULTI, similar to
        what ScCellShell::ExecuteEdit() does in the SID_COPY case, which also
        calls CopyToClip().
        
        Keep the test highlevel as the Calc shell doesn't seem to have an easy
        function to do the same as the Ctrl-click on a cell without duplicating
        lots of code in the testcase.
        
        Change-Id: I641d9db95ca391a4f39d96aeeb33422129262288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166279
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-19  Justin Luth  <justin.luth@collabora.com>  [78bd5e2523d077a67468b752d4788a2c3b43fb5f]

        xlsx export: fix corrupt file for Excel: protectedRange must have sqref
        
        Excel refuses to open a file if there is no sqref specified
        <protectedRanges>
          <protectedRange name="corruptFile"/>
        </protectedRanges>
        
        In this case, import failed to import sqref="10:131".
        A follow-up commit avoids exporting these shorthand ranges.
        
        I don't see much point in trying to create a unit test for this.
        (I assume protectedRange is simply round-tripped
        because I doubt LO has working support for protectedRanges.)
        
        commit 9cee6a45632623d3d7e5a574128940f96d8c926b
        Author: Eike Rathke on Thu Mar 20 10:16:50 2014 +0100
            added ScEnhancedProtection to ScTableProtection
        
        Change-Id: I97ef1ee801898bdcace067d62890c4ce0e7cf1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166265
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Justin Luth <jluth@mail.com>

2024-04-19  Justin Luth  <justin.luth@collabora.com>  [4a120f4f557b99bb8371474a4e7fdaf52b148143]

        tdf#140616 writerfilter: recognize style rPr under pPr
        
        Although it is completely NOT normal to put any rPr's
        in the style's pPr (since they normally just go
        into a stand-alone rPr), MSO is able to read and apply
        those - while LO just ignored them (as misplaced properties).
        
        It seems harmless to me to import it this way as well.
        
        make CppunitTest_sw_ooxmlexport14 \
            CPPUNIT_TEST_NAME=testHighlightEdit_numbering
        
        Change-Id: Ie4a6c4c91a8214f40e34dc58c47b0bb9381bac1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166189
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [91bdf6c3ad57a0cc74aad64aa9828ba6b95468b7]

        Fix typo
        
        Change-Id: Ia0262b3424eb6f05020e48dd0a497e27cfd10ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166282
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [558990c0f0fb749f1907ffbc3859001aa3e48e63]

        Fix typo
        
        Change-Id: Icff58bb1e1c0f409003cb3a97a10182fa4ded41a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166283
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7f95972026ec78b925fd7d67be6756625b73002a]

        Fix typo
        
        Change-Id: I0f745fa74b0de96df7d2b887fca460d32faf77e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166281
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6fe1b4af873cf903afb7be49993213e445f67a35]

        Fix typo
        
        Change-Id: I00f6c7696b9b2cdb6f1ac0ae71774795f48daf91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166285
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c526c04873ae8e591056a234ea892eaaec145d1f]

        Remove exec bits on docx file
        
        Change-Id: I69a9fb310e640b68ca4a9987b8b4a8b7cbd744c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166286
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e99a2fc119f9e9b97b18f64f679d889c373693cc]

        Fix typo
        
        Change-Id: I8b7aa192fbdc5269b0da527dc2aeb2d535f1f0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166284
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [1b2a6b98291cf8b7022951be19b915fe2a9e18e6]

        tdf#159903 xmloff: ODF import: fix bug in margin compatibility override
        
        The check for the property being set was wrong: the state in a parent
        style may be DIRECT_VALUE but a derived style may have a list style set,
        which effectively overrides the ParaLeftMargin and ParaFirstLineIndent.
        
        Fix this so that the compatibility override only happens when required.
        
        (regression from commit 7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d)
        
        Change-Id: I6c8ca493df946afcb48a63c01c132620bcd7b390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166257
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f3b47ec80235318c4d9f843b2ef52e01611fa5c]

        rename rStyleIdx -> gnStyleIdx
        
        to make it obvious we are dealing with nasty global state here
        
        Change-Id: I7f2193600a6459c3a5cd51fece8151ac46aebe7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166242
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8df17c340193c89549d8c563b04d015156afa3fb]

        tdf#160711 - sc fix XLOOKUP function search for empty cell
        
        Make XLOOKUP function able to search for empty cells.
        
        Change-Id: Iefa71b938fe658a59d52e0bf605dbef7a62742c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166263
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [01479c742f2680d004ea8e133e56133870023b43]

        tdf#160721: nothing is displayed in case of wrong 'in' reference
        
        Change-Id: I746ec8a12dba7832241693dac7f20788a2fa85bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166267
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-19  Kira Tubo  <kira.tubo@gmail.com>  [e75899a25921aa8fc7857c154326a9aca4648c27]

        tdf#158451 - sw unit test - FILEOPEN DOCX crash
        
        Unit text checks if DOCX file crashes when opened. Document contains grouped
        shapes that is anchored "As character".
        
        Change-Id: I7df17de0e1f1bf252593548883ba7959f2002023
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165776
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-19  Mike Kaganski  <mike.kaganski@collabora.com>  [2c2c155b37750618784cae410f50b75d503e506d]

        Add a unit test for commit 3f0220f18a66630e06e3c128980f21a5722f49ca
        
        (Handle empty range properly, 2024-04-18)
        
        Change-Id: Ifea60ace8ff864ef092e6a62177d5926ceb60de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166278
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [495dddd2f57feaa94447a632b8af317932d70f9d]

        Adapt to Clang 19 trunk isUnnamedBitfield -> isUnnamedBitField rename
        
        <github.com/llvm/llvm-project/commit/3d56ea05b6c746a7144f643bef2ebd599f605b8b>
        "[clang][NFC] Fix FieldDecl::isUnnamedBitfield() capitalization"
        
        Change-Id: I198e19c00774ba111a441be2afe0b2a992cd6f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166268
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-19  Mike Kaganski  <mike.kaganski@collabora.com>  [2642643ec07cd7f3d28fe558769297578c36de19]

        tdf#160622: Let SalLayout::GetBoundRect return basegfx::B2DRectangle
        
        This avoids premature rounding in TextLayouterDevice::getTextBoundRect.
        The box in D2DWriteTextOutRenderer::performRender needs to be expanded
        to allow room for the line width (which now will be guaranteed on all
        sides; previously, the rounding could happen to give no room on some
        side, even prior to commit 8962141a12c966b2d891829925e6203bf8d51852).
        Fixes some lines partially cut off in smaller text (or zoomed out).
        
        Change-Id: I07335136021f894cf045363b4d736bfab06c64d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-19  Mike Kaganski  <mike.kaganski@collabora.com>  [58e79c4394783033f61e1309214d9060e2f0adf2]

        tdf#160700: Avoid both bookmark-start and bookmark-end at the same index
        
        There is a special handling of CrossRefBookmark, which has no end position
        in the document model, but must span the whole paragraph, and end position
        is generated explicitly.
        
        Since commit 1d7ce421480d9170316533de03feb8d04eb5c767 (tdf#159438: when
        there's no frame, close previous bookmark first, 2024-01-30), end marks
        of an index are sorted before start marks of the same index, with the
        expectation that start / end marks represent non-empty span. Dun in case
        of empty paragraphs with a CrossRefBookmark, both start and end mark were
        emitted into the same index, and the new sorting resulted in the wrong
        order of the elements.
        
        Fix this by checking if the start index is less than node end, and don't
        handle CrossRefBookmark specially, if the check is negative. This writes
        a single text:bookmark, instead of a text:bookmark-start, followed by a
        text:bookmark-end.
        
        Change-Id: I533c4f7814edddc3cf24b1213490f251d60b2273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166266
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-19  Mike Kaganski  <mike.kaganski@collabora.com>  [edef46e82e7e54a27004f9ee6e99108390736d12]

        tdf#160717: fix ex handling
        
        Same as in commit e27572686130df43d1d65c574b0c34f39fc0d1a9
        (tdf#160593: make sure to use current element's font size for em unit,
        2024-04-18) for em.
        
        Change-Id: Id9003c0426a6b373456da1aa1550f7ff07f766a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166235
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [75fe059974dcb80c3f78110c73ab799afc6f4ca3]

        Embind: throwUnoException from JS
        
        (If throwUnoException directly took a css::uno::Any argument, JS client code
        would need to create one with `new Module.uno_Any(...)` and call .delete() on
        it, but there is no place where it could call .delete(), so make
        throwUnoException take two arguments instead and assemble the css::uno::Any on
        the C++ side.)
        
        Change-Id: Iae4ae6af804354d5cf752115e272b79d61427440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166253
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-18  Miklos Vajna  <vmiklos@collabora.com>  [4322ec8f8f89549410d108551d21f5058b1c8261]

        CppunitTest_sw_uibase_docvw: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything.
        
        Change-Id: I775e984410c1e25fb1ae09a9ddfa09793a4f9bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166231
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [3f0220f18a66630e06e3c128980f21a5722f49ca]

        Handle empty range properly
        
        Since commit 690526f95e3ee4fd25bb2c987e093543e4bc435b
        (Generalize basegfx::fround for templated return type, 2024-04-14),
        an assertion could fail for certain case, like
        
        include/o3tl/unit_conversion.hxx:75: sal_Int64 o3tl::detail::MulDiv(I,
        sal_Int64, sal_Int64) [I = long]: Assertion `isBetween(n,
        (SAL_MIN_INT64 + d / 2) / m, (SAL_MAX_INT64 - d / 2) / m)'
        
        The problem was unchecked case of empty B2DRange.
        
        Change-Id: Ice9125ea557b73a7fabf64bc1ad9368f503ad525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [edfe8adcec43241ad052c7c82b44e14bd443323b]

        Embind: call decrementExceptionRefcount upon catching
        
        The note at
        <https://emscripten.org/docs/porting/exceptions.html#handling-c-exceptions-from-javascript>
        is a bit vague whether decrementExceptionRefcount would only be needed for
        Wasm-based (-fwasm-exceptions) exceptions, or also for the JS-based
        (-fexceptions) ones that we currently use.  (But it does state clearly that for
        the latter we need to manually call incrementExceptionRefcount first.)
        
        Change-Id: I7714935607c990385f68730d02e367e70fa0ea03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fbaeeee7ac09846099932c14fe78fb01a1b762b7]

        crashtesting: crash on export of forum-mso-en4-470772.xlsx to xlsx
        
        similar fix as:
        
        commit 1d5630c5deeec5dca724c29ec8c886bfa71a2099
        Date:   Tue Apr 16 15:21:49 2024 +0900
        
            pivot: add checks that prevent reading out of vector bounds
        
        Change-Id: I190da7586cff9c7e8dd4011ad61e68abba6ecd53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166240
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [86a8a3a43b642fc13bae6a89720496285f8f73d7]

        tdf#160594: Use the recommended fallback of 0.5em for ex in font-size
        
        This fixes the error of identical treatment of em and ex in font-size,
        which violated https://drafts.csswg.org/css-values-4/#font-relative-length.
        The fix uses the fallback of 0.5em for ex, similar to the code used in
        SvgNumber::solveNonPercentage. A follow-up should implement the correct
        use of "x-height of the first available font".
        
        Change-Id: Id9d581994e158d629d9752299ad93ac7e9fe4cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166234
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [e27572686130df43d1d65c574b0c34f39fc0d1a9]

        tdf#160593: make sure to use current element's font size for em unit
        
        According to https://drafts.csswg.org/css-values-4/#font-relative-length
        em is "equal to the computed value of the font-size property of the element
        on which it is used". This means, that for an element that defines its own
        font-size, attributes like 'dy' using em refer to the new font-size, not to
        inherited font-size.
        
        Change-Id: Ie5a013df99a68edddf466e4c0ee5311f6219fcb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166233
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d7214aba95bbdcbd40e87ef50fc66f2e2ec4f5ff]

        tdf#160517 - chart odf: import/export formatted chart titles
        
        (main, sub, axis titles) texts properly to/from odf format.
        
        Fix odf export of formatted chart titles. The exported data structure
        will look like:
        
        <chart:title svg:x="3.304cm" svg:y="0.285cm" chart:style-name="ch2">
            <text:p>
                <text:span text:style-name="T1">This</text:span>
                <text:span text:style-name="T2"> is</text:span>
                .
                .
                .
                <text:span text:style-name="T3">3</text:span>
                <text:span text:style-name="T2"> a </text:span>
            </text:p>
        </chart:title>
        
        Fix import of formatted chart titles. Put the properties and related texts
        into the chart2::XFormattedString2 uno objects.
        
        Follow-up commit of:
        55e9a27afd2d6a13cf76b39641bf121c3ec4b45c
        Related: tdf#39052 - chart ooxml: export formatted chart titles
        
        4f994cec388377cc5c2bddb804bd92eb4cd7dc8d
        tdf#39052 - Chart: make characters formatable in editable chart textshapes
        
        --
        TODO: chart data point / dataseries labels are handled differently
        since those are not editable objects, but that is a completily different
        issue.
        --
        
        Change-Id: I1842f2c69c132bdf578bb2d354f451cc9d49c63c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166122
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [176406a07edc29f59a67464c7812358f46421f4d]

        svgio: factor out common code
        
        Change-Id: Ib86f04364593546f53419b37d35469c561561aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166188
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [830ec75f2f172847d350a0801823cf87e004b33c]

        Embind: We no longer need interface FromAny ctor
        
        ...now that we have uno_Any get() since 8428368d79118f1d0e09615c5d2b92065b8838d4
        "Improve Embing'ing of UNO Any somewhat"
        
        Change-Id: I06572e1ca152117c5c93a1552e50b1399af84780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166244
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [191d7d251dd350196f76f47195ff8cd998312f61]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7e29cad08d812997ae5053444c86edf1c8c971d4
          - Use svg icons in Help page
            
            Change-Id: I1418d54df7393321e79706d4885af50e6fdea59b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166249
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c8f2cca985e7c5328361aaa051340d6234273fc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e32990654d9b4ad397f6e0d21973483b1bf47f9
          - tdf#86427 automatic label detection explanation
            
            + refactor a warning and cross-link between option pages and guide.
            
            Change-Id: I0f337c4999d41a96355422540da4d173f02b5a21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166252
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-18  jucasaca  <jucasaca@gmail.com>  [7edca7dc740f6877fa85c2a996ca869c6b971a48]

        tdf#158056 Connect to MS Access .mdb files by mean of ACE.OLEDB.12.0 provider
        
        * Modify the code so that all connections to MS Access files, both .mdb
        and .accdb are made with the provider "Microsoft.ACE.OLEDB.12.0".
        * Remove all references to the "Microsoft.Jet.OLEDB.4.0" provider to clean
        up the code.
        * Leave only one entry "Microsoft Access" in the Connection Wizard, which
        would work for .mdb and .accdb files.
        * Remove the entry "Microsoft Access 2007" from the Connection Wizard,
        since it is no longer needed.
        
        Change-Id: If523712d071199d61e0c994b35291d3a69246ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165756
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1268721d4266ed1254da99581a7c2c3dfb72ba6]

        tdf#160706 speed up loading conditional formatting rule in XLS (3)
        
        the comment when calling MakeCellStyleSheet does not match the
        implementation, so make the implementation match the comment.
        i.e. if there is an existing stylesheet with that name, just return it.
        
        Reduces load time for me from 47s to 33s
        
        Change-Id: If1bd08baf8515933b87c075d9eef04bc0a125357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166241
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-18  RMZeroFour  <ritobroto04@gmail.com>  [68c04836ab5af32c06650c0f1f7fe39e3a0753bb]

        tdf#160084 Simplify comparing with zero when using fTools
        
        As part of the efforts in #160084 to simplify parts of the codebase
        by replacing basegfx::fTools::more/less calls with direct comparisions
        against zero, this commit performs the changes in a few files in the
        drawinglayer/ module.
        
        PS-2: Fix wrong identifier, courtesy of an accidental backspace press...
        
        Change-Id: I52a183dda5ae11989f8ffc8b26ff16ac77d6ebb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165600
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [42c235fe8a616afea4c838901f73c52a262b1337]

        Related: tdf#160056 use simple ref count for temp double tokens
        
        Change-Id: I268a20fb4f87c62f2344f1b518a3a79ac3e8b55e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166232
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [92edab3d95ff5ee8a81a453b3224157839dfd32c]

        tdf#160016 tdf#160704 Set the direction from src in StretchAndConvert
        
        The direction of the BitmapBuffer was never set, so it defaulted
        to BottomUp. The best is to set the direction to be the same as
        source - It's unlikely they would be different.
        
        Regression from 6588c30ed4477627b2623560ca867682b189bc80
        "vcl: separate scanline direction from ScanlineFormat"
        
        Change-Id: I0e02106309141d09160defee0a0d72d34642a6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166182
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-18  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [efef507cfd480cc6f1efc964ac2f9e033e18ad87]

        tdf#33603: make the notes pane handle placeholder text on focus
        
        Change-Id: Id2bca2b8a8bafa9da44a5f97a8e763b512078ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166152
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [91f41cd463d8c5801f3da84c25d1cd058a1adb2a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23abe69086280eabf5e160fa0e847bbe28d3ff2a
          - tdf#130185 Clarify font embedding properties.
            
            Change-Id: Ic612b41019edafe266bc324cf137b40e0f0b62bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166190
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-18  colton Garrett  <coltongarrett93@gmail.com>  [3908011762cfdcfb01ac15c60f12849dc727763d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79b57de908932267b64efeec42002431417eb965
          - tdf#137292 (Part) Paragraph Signature Help page.
            
            Change-Id: I2786dd736903426d62a6ee88d4c79265ce4bfed4
            Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166187
            Tested-by: Jenkins
            
2024-04-18  Kira Tubo  <kira.tubo@gmail.com>  [abab2d24b31f0857502d2fa527b433bd4ff0a0f5]

        tdf#156546: sw unit test: freeze redo insert table
        
        Unit test checks if writer freezes when the user performs redo on
        table inserted into a new document.
        
        Change-Id: I9d48f32a1ef27deb01c8042a68c21b0be20f2d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165919
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [560989ff89eb1a3e91cfcae1cb524ece20463b86]

        external/argon2: Adapt vcxproj to Debug|ARM64
        
        Change-Id: I3a881c56859d5db36ee13a63aec6926d0e3f2638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166230
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-18  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [18a7f0aaadb440bdbf0e1507642d16de783dcc14]

        xmlsecurity: Change spelling from "Certification" to "Certificate"
        
        Unify the terms used in the View Certificate dialog.
        
        Change-Id: I820e4f246d2efc235794745bbd889540a39231eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166175
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [052c668da38b70943d24770895abc8119aace2a6]

        tdf#160669 IASS: flush Prefetch for SLideShow as needed
        
        Change-Id: I3c0e2be658358ab5b412ab18cce197eb28e5c0db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166177
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [f1c880463666149bcb82a2f76a1f27db71b2ae52]

        libwebp: Upgrade to 1.4.0
        
        Change-Id: I196316b0c7efbe27c06b8dfed90db5248db6dce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166185
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-18  Noel Grandin  <noelgrandin@gmail.com>  [828c1999e08c5bfad0a1d0e6e5ab07ee8bbc427e]

        move writerfilter inside sw
        
        writerfilter wants to convert incoming RTF and OOXML files into
        writer's document model. But it currently has to do so by
        manipulating the limited subset that we expose through the UNO
        API.
        
        This is both slower and less accurate than having access
        to the full document model.
        
        So move it inside, and then we can strip out various hacks, and
        optimise imports.
        
        Change-Id: Ie1114d28130ef5f9a786531bc552cb8ee7768015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165953
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-18  Oliver Specht  <oliver.specht@cib.de>  [8e86df886f84fe69f13cfc367a5dd843e6ea917c]

        tdf#160621 Redesign name and value fields in variabe fields dialog page
        
        The space available in the bottom of the dialog page
        is now used to make the input fields longer
        
        Change-Id: If936decbcc44ff356095fc291ff8306084c248ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165952
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-18  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [d129495bb19dededacb27fee18c9ed7273dddb82]

        tdf#160698: fix crash after opening print dialog
        
        Regression from I5a0ab3d781b21eff575afaebb233237eff1827d5
        "tdf#155218 sc: fix regression page orientation in print dialog"
        
        Change-Id: Iccdd8a6eefcadea963a1ffec61c0bcf798931fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166197
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [3e38fdacba022a9d8001a0f856ef33b4d14857cb]

        Optimize a bit, to avoid a copy of the vector
        
        Change-Id: I747662e346151e2e055cb803278c2a6c7709f273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166166
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-18  Noel Grandin  <noelgrandin@gmail.com>  [00c13dfcdbf34cdddb19005dba207147071f5e47]

        Simplify DxfContext
        
        (*) we don't need two fields, they are both serving the same purpose
        (*) we don't need to check for null, the field is never null
        
        Change-Id: I98c69de399ac463c9bfd32cde450941e04ac92cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166186
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [5060893f0b69c094beae73ab1a0926e3feb249b2]

        tdf#160706 speed up loading conditional formatting rule in XLS (II)
        
        Reduce the work we do in IndexedStyleSheets::Reindex
        
        takes my test document from 117s to 48s
        
        Change-Id: I2e23b05684d0f2e3a9dc05c0a0fc4e9bbea7008d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166180
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-18  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [eeeff49f40c08cb3b53dba837590de3065990917]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 8c5b63124f5cedf97ed4799560fdd1202f039511
          - tdf#157716 rename 'Language Settings' to 'Languages and Locales'
            
            ... for bundled dictionary dialogs. The string still exists in
            various README files but prefer not to touch because some refer
            to OpenOffice dialogs, others could be fixed upstream (e.g.
            lv_LV), and some are explicitly legacy (it_IT).
            
            Also remove pt_BR hardcoded translations.
            
            Change-Id: I9dce059fc5e6fa6553c2acc16d2b6285bced72e3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166137
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3b50c9f54907c656d2ee23fddadc696ffdab1c94]

        pivot: test for issue when pivot table format not matching data
        
        Fix was added with [1][2] and this adds the tests to make sure
        this keeps working in the future.
        
        [1] 1d5630c5deeec5dca724c29ec8c886bfa71a2099
        [2] https://gerrit.libreoffice.org/c/core/+/166138
        
        Change-Id: I0a7e62ee6139cc5334c03e7022ce49306d578e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166149
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [589fb36b663cbd68afc26419629a4a95bd593a89]

        add Spell state to impress RenderState like we do for calc/writer
        
        Change-Id: I1adfef0fa7220d93b096fbe4b86d0c04b2e5547e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [58de3a5f1cd80cfff0c7e8db326a66d34501e09b]

        wina11y: Drop unnecessary null check and make static
        
        `AccObject::GetMAccessibleValueFromAny` converts an
        Any to a string representation, which is unrelated
        to any class members, so drop the null check for the
        `m_pIMAcc` member and make the method static.
        
        Change-Id: I07216f87c0fadbe239d1e16a048e2799cebac7bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166184
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [89610c2176e1370a8075187e7637e5844fe5f3e3]

        Embind: Clean up JS UNO obj implementation in embindtest.js
        
        We don't need a dedicated implXInterface, any other interface derived from it
        works as well.  But we should arguably implement css.lang.XTypeProvider.  Which
        in turn requires two sequences, which need to be eventually .delete()'ed, so add
        impl* for them.  And while at it, rename refcount to implRefcount for
        consistency.
        
        Change-Id: I8cfd0df74058383bd432e2a6a86f7f2039a87ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166181
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [dac30c44c606232ce23d52a423d0bf8010f25d4f]

        tdf#160706 speed up loading conditional formatting rule in XLS
        
        we only need to finalizeImport on the last ExtDxf we loaded, otherwise
        we end up with an O(n^2) performance problem
        
        Change-Id: I566ef43189a1bb7ac7c55e1bccf9445c9cea19b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166179
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-17  Omkar Santosh Nikam  <omkar.nikam.2026@gmail.com>  [681e113fae0b1baca6501326dfd249d26b5f68a4]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I2beda26661abb57ffa7b7d6e404eb5f5a26ca5b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166162
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-17  Omkar Santosh Nikam  <omkar.nikam.2026@gmail.com>  [123fdb0c7ac53f01406208f3c219e2716599effd]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I84080f2b647ccdd91fa44401b4edae4bf31a92a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166167
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-17  Pranam Lashkari  <lpranam@collabora.com>  [11ae1cf4e4415237ed4fce7fa8d77502ab058ab1]

        sw lok: .uno:SetDocumentProperties: add file size parameter
        
        problem:
        in LOK/online to support async save, files in jails may have
        different extensions (ie: .upload, .uploading)
        this caused problem to detect files as original file name may not exist.
        As result property like file size were always set to 0
        
        Change-Id: I552aef203297470d01032659a266210970129e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165769
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit aa4e10efc6e9ac92b0c652f238526aacbe2096c6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166171
        Tested-by: Jenkins

2024-04-17  Jonathan Clark  <jonathan@libreoffice.org>  [fb94cc0d1348140d03c2826771c57255ff74a94a]

        tdf#49885 Reviewed BreakIterator customizations
        
        This change completes the review of BreakIterator rule customizations,
        and adds unit tests for relevant customizations.
        
        Change-Id: I06678fcccfc48d020aac64dd9f58ff36a763af30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166017
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-04-17  Laurent Balland  <laurent.balland@mailo.fr>  [47187acee758680cda8086b6e295ef7beea3491b]

        tdf#129701 Follow-up of previous change
        
        According to comments in https://gerrit.libreoffice.org/c/core/+/163536
        Follow-up of previous change
        
        Change-Id: Icd7b6798d6ef35ca9574125cd3d4c4d89044569c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166133
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2024-04-17  Miklos Vajna  <vmiklos@collabora.com>  [c53b3f08776cfc64f40b4508c44bbd8424769822]

        CppunitTest_sw_rtfexport3: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I5cc93ca6ee7bfc2f14d90edfe837a14c182bc73c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166169
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [c61aeb5b87d1a69745617b1368a86b70d798ba30]

        svgio: map all 'in' keywords to target for now
        
        Change-Id: I18d6c839c4005e4052397c4f6682d78c664d25ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166145
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e16730a87c17d1a3e6219159d1d012caad4ebf13]

        ofz#68081 keep within bounds
        
        Change-Id: Ib7f11f2447d5a2cc6b9b559727f2a0127c15913e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166154
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1bfdf89dcf2ca4acfb63d9cdec7a620c08b750d0]

        Fix typo
        
        Change-Id: I64398416dcad6b573cb2eeb2089a43bf42f5bed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166163
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-17  Ashwani5009  <ashwani1235kumar@gmail.com>  [c72cfece6a514cde1ccc79b855bc175bda4d0edf]

        Simplify nested for loops
        
        Nested for loops are replaced with direct distance checking between
        triangle vertices. The goal is to improve the code readability and
        efficiency in AddTriangleVectorToBody() function.
        
        Change-Id: I753253031738d49e7910f20110da7da07a10cb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165863
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2024-04-17  Michael Weghorn  <m.weghorn@posteo.de>  [0425b6eb47830b1fe630dc0128d5049f4b3e5582]

        tdf#160695 wina11y: Send status change events for toolbar buttons
        
        When the checked or indeterminate state of a toolbar button
        changes, forward the corresponding UNO a11y event as
        a corresponding MSAA event.
        
        For roles `AccessibleRole::PUSH_BUTTON` and
        `AccessibleRole::TOGGLE_BUTTON`, `AccObject::GetMSAAStateFromUNO`
        uses `STATE_SYSTEM_PRESSED` instead of
        `STATE_SYSTEM_CHECKED`, so also use
        `UnoMSAAEvent::STATE_PRESSED` for the event.
        
        It's unclear why sending of such events would generally
        be omitted for "special toolbar items" previously.
        
        The events can be used to implement announcement of
        toggled font attributes in NVDA, e.g. when the "Bold"
        button in the formatting toolbar is toggled via a keyboard
        shortcut, similar to how Orca does it (s. tdf#123864).
        
        Related NVDA issue for which I plan to submit a PR: [1]
        
        [1] https://github.com/nvaccess/nvda/issues/4248
        
        Change-Id: Ic2846e338802c3cb7656de5b77e4df23bd5b0703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166155
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d304fdb3369235ff4916463687b5e625c7fa3650]

        Embind: css::uno::Type should probably use sharing_policy::NONE
        
        Given the reasoning in 0957ee9f5d379c80fca4027c187b471118d0490d "Embind: No need
        for $query", those sharing_policies appear to be (solely) about upcasting of
        those smart pointers, and css::uno::Type doesn't involve any class hierarchies,
        so NONE ("no upcasting", in genericPointerToWireType in Emscripten's
        src/embind/embind.js) appears to be the best match here.
        
        Change-Id: I74b74d3c31cc17a7fd0a6d072160316e60884557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166160
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [96f62b48b4425f0bc2b6d8497782694078d968fc]

        Simplify a bit
        
        Change-Id: Iadfa442f762aa3caf3a8de7f3633be4e73bfd91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166091
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0340a52ef0b9da9861f912c56550e685621a59f1]

        Fix typo
        
        Change-Id: Idee34a2b522f69a0fcea9595c62b68f74628c299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166164
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-17  Leonid Ryzhov  <leoryzhov@gmail.com>  [155a6af93a8ac90cab15968f5dd499ab77ad9f72]

        tdf#159395-LanguageTool use correct default URL when username/APIkey set
        
        Change-Id: I31e1c2f1dfd96d87f60b6be1e5abce4837827a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165079
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [ea9904c89608d561f6bde3379408208bbb24fe35]

        Drop FRound, and use generalized basegfx::fround
        
        Change-Id: I7447e649dc3ef4e51242f69c7486a3e84e103d2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166159
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0957ee9f5d379c80fca4027c187b471118d0490d]

        Embind: No need for $query
        
        ...to "upcast" from css::uno::Reference<T> to base
        css::uno::Reference<css::uno::XInterface>.  My understanding now is that due to
        the sharing_policy::INTRUSIVE we specify for
        emscripten::smart_ptr_trait<css::uno::Reference<T>>
        (include/static/unoembindhelpers/PrimaryBindings.hxx), Embind can internally
        "upcast" from a css::uno::Reference<T> to a base
        css::uno::Reference<css::uno::XInterface> by just treating the encapsulated raw
        pointer of type T* as a raw pointer of type css::uno::XInterface* (see the use
        of that sharingPolicy in genericPointerToWireType in Emscripten's
        src/embind/embind.js; though documentation of that Embind sharing_policy is
        rather poor).
        
        Change-Id: I6ed60a9c94af6aba6fc6119bf644da7f507a997f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-16  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7897f1d9835f686dd042348c51f7d2326de71971]

        Fix typo in dockingfontwork.ui
        
        Change-Id: I995cdd0332552787cafced472c2f61ed6573658e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166143
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [14ae46251d44282feba222e3c24815f6d24e78ca]

        preload BreakIterator for LOK
        
        Change-Id: I22bea46d224f4020bb18d2826f23985fc2d8e492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166129
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fa363faaba5dc9c57cf7fd1d4aa0dd300310682]

        tdf#160632 TABLE: Crash when using column width dialog
        
        regression from
            commit a08110be32a6958f27ce9ddb1e2cb2227265dfe1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jan 30 12:24:47 2024 +0200
            convert table width dialog to async
        
        we were referencing an object that had already been destroyed by the
        time the dialog completed
        
        Change-Id: I2a06dd99129b53c558d6f5f3f96fc16dcc04f754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166147
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-16  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [1e1a3825d76ed8071424e8e21bbda23464c10fff]

        tdf#160589: compare the correct OutDev with PageWindows
        
        Change-Id: I29d9c60cac04536bb2d5ad2ed1c086c8e67a9f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166151
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1d5630c5deeec5dca724c29ec8c886bfa71a2099]

        pivot: add checks that prevent reading out of vector bounds
        
        MSO likes to keep formats in the document even when the pivot
        table has been changed, so there might be references that contain
        indices values that are pointing out of bounds for the current
        pivot table result data. To prevent crashing the checks are added
        to prevent using an index that is out of vector bounds.
        
        Change-Id: I3824c787659d4e3817a5eb64fe2c8761ef00b610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166138
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-16  Miklos Vajna  <vmiklos@collabora.com>  [875d99c6e5286b9d56bba32a3abbc37068df61c1]

        sfx2 lok: simplify error handling in InterceptLOKStateChangeEvent()
        
        The whole function is pointless without a viewshell, move the check &
        short-circuit to the top of the function, and drop all the duplicate
        checks.
        
        Also drop two calls to SfxViewShell::Current(): getting it from the view
        frame is better than getting some global state.
        
        Change-Id: I4aa7aeb7c89841bbced760ce2e43d2312bc97f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166139
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb4698626f17e005c820a7138c63a03c21120ecd]

        tdf#48062: Add support for arithmetic in feComposite
        
        Took https://github.com/w3c/csswg-drafts/issues/3831
        as a reference
        
        Change-Id: I42039c481ec114c3faeae51526a5f29b86960146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165828
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ded4d570fde21e55091c9c8c364114e67aa0cdcf]

        pivot: suppprt multiple cell format reference indices
        
        This adds support for multiple cell format reference indices, so
        the same cell format is applied to multiple cells (defined by
        indices) so that each doesn't need to be defined by its own
        reference (as they are all the same anyway and only differ by
        single index).
        
        The solution is to create multiple format outputs for one format
        entry - each for a selection index, but have other data still the
        same. This is a bit tricky as previously it was one format output
        for one format entry, which is not the case anymore.
        
        Change-Id: I074ac03e7d81e26562a6a6cc395b11cfed16766d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166131
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-16  Juan José González  <juanjosegzl@libreoffice.org>  [bdf3b5ce49b0e4ee1b4525d344cfb037ef473059]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b438594148c4ee94cb632e7a3d3b64b547706d5
          - Move z-index rule to CSS stylesheet we control
            
            Previously a fix was pushed to prism css file, which can
            be changed by the upstream project. Instead overwrite the
            rule in our files.
            
            Change-Id: I549b05d4a359343ae0fe09831644a2eed8fb0474
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166076
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5d111672ae58e35b7856bc2578352ebdc3ab6ecd]

        null-deref in SfxViewShell::isBlockedCommand
        
        Change-Id: I43db7fabcc32971f951cc72dc9b1d22eba8df357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166094
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [faadf7c15593521c0ebceb043f82f916ee5ccf9d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 5bdfc7986299178af1b2f20fa2e9b2bb5dd82a6b
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ib61c7bd3d884aadbf089a18ca3b7e5bafc980c3c
            
2024-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2243d4ced63c5a9764e5d83812285e08e0ea918]

        cid#1596278 Dereference after null check
        
        Change-Id: I4fb7b4b113e60dc3cc4aabd49e4dd23dbeeb74f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166112
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [312b9a67f08de17f68ca971f4d640bc2df8de12e]

        android: Update Android Gradle Plugin to 8.3.2
        
        ... as suggested by Android Studio.
        
        Also update the Lint baseline file, as the build would
        otherwise fail due to this new warning:
        
            > Task :lintReportStrippedUIEditingDebug
            Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html
        
            > Task :lintStrippedUIEditingDebug FAILED
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 213 errors and 1 warning were filtered out because they are listed in the baseline file, lint-baseline.xml
             [LintBaseline]
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 6 errors/warnings were listed in the baseline file (lint-baseline.xml) but not found in the project; perhaps they have been fixed? Another possible explanation is that lint recently stopped analyzing (and including results from) dependent projects by default. You can turn this back on with android.lintOptions.checkDependencies=true. Unmatched issue types: PrivateResource, RedundantNamespace, TypographyEllipsis (3), UnusedNamespace [LintBaseline]
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/AndroidManifest.xml:109: Error: Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed. [DiscouragedApi]
                        android:screenOrientation="landscape" >
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
               Explanation for issues of type "DiscouragedApi":
               Discouraged APIs are allowed and are not deprecated, but they may be unfit
               for common use (e.g. due to slow performance or subtle behavior).
        
            1 errors, 0 warnings (213 errors, 1 warning filtered by baseline lint-baseline.xml)
        
            FAILURE: Build failed with an exception.
        
        Change-Id: I621b2334fef954bcd341cdde9034187f455339e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166114
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-15  Oliver Specht  <oliver.specht@cib.de>  [b1170251fbca5b6b243902cf10695ab4c4c5642b]

        Improve case rotation in sentence case
        
        Rotating case (Shift+F3) applies sentence case only
        if multiple words are already selected or selects
        sentence if SENTENCE_CASE is going to be applied.
        
        Change-Id: I9e8536d7744a344d7ad54150783e91e843e0e81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165986
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-15  Oliver Specht  <oliver.specht@cib.de>  [6f99187ec29e8716e1fb9ffa18b1830048608fbc]

        Case rotation in Impress: skip sentence case
        
        Sentence case does not make sense if a selection contains less than two words.
        Rotation then skkips to the next case mode.
        
        Change-Id: I79d6560c494b716a53bfed654027f6f37dc6c362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166115
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [12eba0d6115b05792b302d4a5ad141d9eb528db4]

        pivot: improve format matching, add empty cell checking to tests
        
        The patch improves the pivot table cell format matching with the
        output data, so we check if there is a complete match or a partial
        match. A partial match is when we found one match for a field, but
        other fields are not set, and if this partial match is found in
        exactly 1 line of output data, then we treat it as a complete match.
        
        This also refactors the code so there is code no duplication for
        column and row matching code - they work in the same way, just
        in a different orientation.
        
        This also adds checking of empty cells to the tests, so we can
        make sure there is no other cell in the pivot table that got the
        pivot table cell format applied to. A new test case was also added
        to the test class.
        
        Change-Id: I102ec8e33bc7a3f26bc898568ee0e33abe08bd27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166086
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-15  Michael Meeks  <michael.meeks@collabora.com>  [b99082e4f3d4e4d13433ca062ba98da7cd14aa9a]

        lok: provide global random symbol to find random device.
        
        This is vital for lok when used in a jail with no random device,
        but with an inherited file-handle to /dev/urandom.
        
        Use 'dup' to avoid changing code that wants to 'close' the handle
        after use.
        
        Change-Id: I15f40fb251f180a2394af030f56e47f2bf9651d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166113
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-15  colton Garrett  <coltongarrett93@gmail.com>  [10fa63a77389c257981310b8920880c812cf0c7c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 38b6934ddac36ab4294213d1ff4387dacee49d63
          - tdf#86637 - OpenCL Help page enchancements
            
            Change-Id: I01b8718b2fdda3003ca32a15e6d443a546f83259
            Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166127
            Tested-by: Jenkins
            
2024-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fff6e491f830daf18088f025fad6ce8118ec6108]

        cid#1596323 Dereference null return value
        
        Change-Id: I63eeb8662ee28f1a0e990160b1ff9992d9d9337f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166111
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d29649e07a3b2c5c2b3dda1dc15c0ca1ed51ae3]

        Related: tdf#160056 FormulaResult may ref an initial interpreter FormulaToken
        
        If a token from the original tokens, supplied to a parallel group calculation
        while RefCounting was disabled for those tokens, ends up as a FormulaResult
        token, then fix up the ref count when parallel calculation ends
        
        Change-Id: I2587c25d216ab170725017b67b97d203a578160b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b25b8a41ab93890a71859feeba458523c0ec7015]

        cid#1596322 Resource leak
        
        Change-Id: Ied68c2c6d69437ea0236724279b2353015cd1e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166110
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-15  Noel Grandin  <noelgrandin@gmail.com>  [a4d6700423aeb3f7cbcb3f23352dd05033353fe3]

        convert OCellValueBinding to comphelper::WeakComponentImplHelper (II)
        
        second attempt at landing this
        
        Change-Id: I1dd3597b0047131c99b3ec81a3cb5eabf9bf8a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e212d987a76f5df1091a1f70ff9557568402d4ba]

        tdf#33603 Typo: 'Notes Panel' -> 'Notes Pane'
        
        Similiar to 'Slide Pane'
        
        Change-Id: If96afc4c054bbbff7c9bf8c5f4309e8eeb419d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166005
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [39803b859ac935aaec1ad4d66038d3c92d907ae3]

        tdf#33603 Allow adding Notes Panel to toolbar/menubar/keyboard shortcuts
        
        Change-Id: Ic3e8f6b5a0cc8697c62e8f10f69ff53859f33d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166004
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [933d9d8b4b9e90f3c3f3842af27588a251a699df]

        tdf#33603 Make notes panel available in readonly mode
        
        Change-Id: I2dd10802f3798b2e87833d3cd8ebd21366e0f546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166003
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ede2f1e6eefbc6471f0163c21430c2f747bb0e67]

        tdf#33603 Fix Close button not working in Notes Pane
        
        Remove duplicate command and now unused NotesChildWindow
        
        Change-Id: Idef94086ca91dd1474070c426c37ef921ad4fa03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166002
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-04-15  Miklos Vajna  <vmiklos@collabora.com>  [1651ced348fa47de3f24650dcad8922121602da4]

        Update libxmlsec to 1.3.4
        
        Allows dropping
        xmlsec-nss-Ensure-NSS-algorithms-are-initialized-754.patch.1, which was
        a backport.
        
        Change-Id: Ifdd0b5285daa79116a91ab2d122a9809f8effb5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166019
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-04-15  Mike Kaganski  <mike.kaganski@collabora.com>  [690526f95e3ee4fd25bb2c987e093543e4bc435b]

        Generalize basegfx::fround for templated return type
        
        And use it when assigning to tools::Long
        
        Change-Id: I0814d7bac9cdd48191ba69c64e3b12a4973b3417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166071
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1dc92b9e9951ef118d2d823d54f9a022c2e41a27]

        ofz#68019 Null-dereference READ
        
        Change-Id: Ie0c9c5a74e6ae87a0bd4c35320a687458d1d9902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166074
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-14  Eike Rathke  <erack@redhat.com>  [2e29c97ec2ba64e5e26ee571e227db9dd2d752e1]

        Correct {bg-BG} formats with group separator
        
        The leading # digit before the separator was omitted. This never
        worked as intended.
        
        Change-Id: Idf8a6cf246b8db4e6d5361bc1c5f66c1c0c057c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166072
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [1f1f4232001fa23ec1a1bf67d605fda9df542eec]

        Round in XmlWriter::attribute when passing a double
        
        Before, it truncated. Rounding provides a closer value.
        
        Change-Id: I213e6ae34ada2f5081cb2c8b2ef431448c712b37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f2283c2986ff94766cc1d2c076fb34a2c88a31a]

        Related: tdf#160056 1 entry is more common than no entries
        
        Change-Id: I78fe8969120f894cf5c0a71fb61611af2d203d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30f9afa18d0b3726a5a38d9c2e35315f51f082a9]

        Remove duplicate include
        
        Change-Id: Ifc9b71acc50e2a53cee194801245c287079b62ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166069
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [707f59019a5edafb4278a5591f8f6578041f1a3c]

        Use more o3tl::convert
        
        Change-Id: I2a4f109b8c1031d0330f249b7666ae65f9fae7ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166062
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [84580785ba7081939296a0ae2da076e067612d4f]

        Use more o3tl::convert
        
        Change-Id: I922502c80d79b8432a46e97178bc87f43847f996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166061
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [fce1fb034d282dc6e0434bf16c49d5f602d813bd]

        Use more o3tl::convert in lotuswordpro
        
        Change-Id: I7ec74dc105f846307f5bf3d3c8cedcc4aebb64a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166058
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [ec40e3edd31319fb6cb919a38f44c861880efc5f]

        Use more o3tl::convert
        
        Change-Id: I281ff1be4663d752a4e1a7e4d38556cefb641bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166060
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a8931211b623cb38b7f703cf9a994ac66162f03a]

        Use more o3tl::convert
        
        Change-Id: I8a3c5d0e1a29219ab27bde75809ca9d8dce7e093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166059
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [0a687d1eeffcb21b947b181ceb2424680d1cce46]

        Use more o3tl::convert
        
        Change-Id: I5a6a1c05083fbaef71e94799a61c6f918a5134f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166064
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [b21978ba644f85ca259b7d58193c6caf03291105]

        Use more o3tl::convert
        
        Change-Id: I56d6909dc3b1a7d45e4e3f45583321b1338838cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166063
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-14  Jim Raykowski  <raykowj@gmail.com>  [857fe51bc8f2d3f3535807a69399c7e2fee971ae]

        SwContentTree: remove repeated pointer assignment
        
        The selected entry does not change within the CommandHdl function
        therefore assignment of the pointer to the selected entry SwContentType
        does not need to be repeated elsewhere in the function.
        
        Change-Id: I025ecb9259e2ee46a64d55c75d0c3f3c8cc625ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166018
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [8b599d60fef80039cdfe636a771c3fc8eb1028c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f63165a8f02d96fbdb0b9b8bea287389edb1121
          - Change the strings in the help pages
            
            ...to follow changes in the UI strings.[1][2][3]
            
            [1] "Fix extended tip in mmselectpage.ui"
            <https://git.libreoffice.org/core/commit/1aeec70c2a635a69e90d2643f2e524bb342378ae>
            [2] "Fix extended tips"
            <https://git.libreoffice.org/core/commit/b5c40d4864b07861e889244834635c8cfc957d6e>
            [3] "Add the strings "dialog" after "Macro Selector" in extended tips"
            <https://git.libreoffice.org/core/commit/a8fda337a88ca4d47218efa9ee44e7bfd590d30c>
            
            Change-Id: I8b99344960d284e149b52534dfcd075e5c687816
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165123
            Tested-by: Jenkins
            Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
            
2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63b237e1e8147f54e6d4db4671f612a656200e2f]

        Related: tdf#160056 don't set nVal twice
        
        Change-Id: I0da3e0c7f18271f6104d52b50d65e96564650b8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166054
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1d63489ae7f99545bcd8a6f41496e78ccad3273f]

        Related: tdf#160056 rename/rework GetDoubleAsReference to SetDouble
        
        Change-Id: I7e79e8d422fe7f426bb7c7360b11f836a5484574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166053
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [91ad46fc2a50b1084bf8c28093ad8286674cbd28]

        ofz#68019 Null-dereference READ
        
        Change-Id: I9ad5d907c4739877d51b74ef0f2e275d94119f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166052
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  HakimOttey  <hakimotteybusiness@gmail.com>  [7d38bdbf96c42d367dfa2cc7e2916c814aa08de2]

        tdf#143148 replace includes guards in vcl textlineinfo with pragma
        
        Change-Id: I733263074a5c4911499a6b5becfbbc87cbda968d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166044
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-13  Aaron Bourdeaux  <abourdeaux@csumb.edu>  [734a84f33d3f08e31086c2dbd629715608a178d5]

        tdf#158067 Replace OUStringLiteral with _ustr
        
        Change-Id: I3a58469c52055121e8726cee2d3e42ecd23cdf96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165826
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [4695d84b78d04af6682961732ae92655e03f49eb]

        Use more o3tl::convert
        
        Change-Id: Ia525e051b53dd6082f2f11ff884677c8b8c6a20c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166051
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [64b5180534b6e87fe89467410bb33459d7179469]

        Simplify and use more o3tl::convert
        
        Change-Id: Ic7babea4eec3633d40d306488fea252d6f2636be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166050
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [72a1ab78c2f4a1bd0d8a60dbdecd8923f076d858]

        Use more o3tl::convert
        
        Change-Id: Id31185592ccbb3507c939b241d5aab82c09c96f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166049
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [adbbe732e7ed7f3a749e04f1d9023989c972ec22]

        Related: tdf#160056 all maTokens are FormulaTypedDoubleToken*
        
        Change-Id: I6eacaf58c25ef9c5cb930a79177471c79a6a26c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166047
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Miklos Vajna  <vmiklos@collabora.com>  [1e605412df2ca9aab895b34f256ccd5a8dfdc83d]

        sfx2: fix crash in InterceptLOKStateChangeEvent()
        
        Notice how e.g. the TransformPosX case already performed the same null
        pointer check.
        
        Crashreport backtrace:
        
        > program/libmergedlo.so
        >       InterceptLOKStateChangeEvent
        >               sfx2/source/control/unoctitm.cxx:1143
        > program/libmergedlo.so
        >       SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool)
        >               sfx2/source/control/statcach.cxx:432
        > program/libmergedlo.so
        >       SfxBindings::Update_Impl(SfxStateCache&)
        >               /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:919 (discriminator 2)
        > program/libmergedlo.so
        >       SfxBindings::NextJob_Impl(Timer const*)
        >               /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
        
        Change-Id: I141d4f9ec50d0ce7a0eeaba69752c31390a1f9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166027
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166046
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [fd19637cfd4099a96661a071939576bc7db4946a]

        Simplify a bit, and use more o3tl::convert
        
        Change-Id: I30f619b81d831db9c1e212a1588d5696b9ad3dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166048
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Laurent Balland  <laurent.balland@mailo.fr>  [2b6eb4eb9360f3004e2b3ce89879af5d1fb51aa8]

        tdf#160567 Replace duplicate style A4 with A0
        
        Style A4 was defined twice and A0 was missing. Rename second A4 with A0
        and change size to 48pt
        
        Change-Id: I529b4fab5223269908867531873d36d3e878e7e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166045
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [791a2489eecc3e59d7a31a4bb9e513a576db08ee]

        Related: tdf#160056 elide ref counting for initial tokens
        
        The initial tokens provided to interpreting will be restored
        to their original ref count when interpreting is complete. So we
        could elide expensive ref counting for them for the duration
        of the the threaded group calculation.
        
        Possibly "temp" tokens that are created just during interpreting could
        additionally use thread-unsafe ref counts presuming they only appear in
        a thread specific context.
        
        Change-Id: I1f5b0198e83027781be15812680079f28b6a4e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165259
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [88ccd5e71143e3a3676fb1eaeb9e16f522a90784]

        Mark obsolete Impress/Draw config keys as deprecated
        
        Practically unused since 2007 commit
        56ca5814a1843a31d23b249f1960a31532c6b5bd
        
        Change-Id: Idd7cf4f239efed16a151fc4c755c249947d927f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165859
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [912aa66a0623787eb2e29d01780140be6cccf27e]

        Drop unused SdOptionsContents class
        
        seems to be practically out of use since 2007 commit
        56ca5814a1843a31d23b249f1960a31532c6b5bd
        part of patch series '#i80528# Removal of draft paint modes'
        
        Change-Id: I770bab8b1973bec099ffdaa3243f1c0d2995ee52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165858
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ce03b3f0879d1b8b564f00224b659ff59e77e932]

        Remove duplicated include
        
        Change-Id: Ie70543c67549498d51eeb53d262b52f8ef1ec700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166043
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d76f1877f699c91f5e4a020641c6d65064bfb997]

        Fix typo
        
        Change-Id: If0fbaae23b98d3bdd178473db8fdb8ab2263ef67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166042
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fc8dfe5c880ff4f64bf769df3088587d3358b027]

        pivot: Export Pivot Table "formats" element(s)
        
        This change adds the "formats" element tree export for a pivot
        table. The source are the formats (sc::PivotTableFormats) added to
        the pivot table - in the ScDPSaveData class. This are currently set
        on import but in the future hopefully those are also set through
        the UI.
        
        Change-Id: I5ed8f7e8d7ac248b0222a884fb97555ef6bb8427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166035
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [01cabd3f998197f277300bcc71fc80e80642caed]

        Don't use lround when assigning to a double
        
        Change-Id: Ifdfd351cf1f2848b754ec7a4c6f6cb9a56f478d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165939
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [4108a59dec851cae19012f790776c7d65b8ceef3]

        Add VclPtr operators to natstepfilter
        
        And fix a vector-related filter
        
        Change-Id: Icd3f5bd5a04a1385dff3f3413792a7aad544a506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166029
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [6e3ed71f906c3571a6b6efb5335c26807b566a42]

        Use o3tl::convert in oox
        
        Change-Id: I1cbc299e7e64eae48f0f6c896a8160bbe6e19c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165938
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d490efe410a54f1860578728027d1ec0439f0ba9]

        Related: tdf#160056 call FormulaCompiler::IsOpCodeJumpCommand just once
        
        rearrange to reuse previous calculation
        
        Change-Id: Ibda0388e020dac995e5667af09767b0314720935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [030b655963c182693c7b657dc6aa4d2fe85c17c6]

        Related: tdf#160056 don't call GetParamCount twice
        
        GetParamCount: 290ms -> 175ms
        Change-Id: Ic3a26b1e8035744dcab2da69a8ebd3b29dd2160a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6a4031ec8338b005682493f65744ebcbc30a5f81]

        At least capture (English-only) cURL error when something goes wrong
        
        ...so that svx/source/dialog/crashreportdlg.cxx can at least present that,
        instead of confusingly being silent about the error
        
        Change-Id: I5e8af5f8df4cbcad84f8b60c2de4c55621b28890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166037
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54d577ed22fd4bae093639be3056a722f5a40bb2]

        ofz#68004 Unknown Read
        
        Change-Id: Id3e50e3a8522523d2b665e394d8f4a65b7f4df5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3454a73a11722c45016c9b5aa0d95402fc1196f0]

        Embind: support .implement()-based JS UNO objects
        
        Change-Id: I3a8bf5986b91b886547cfe57e49275f7c79ddc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166020
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-12  Ashwani5009  <ashwani1235kumar@gmail.com>  [ea462462db187d87d978cb659df8ca81309fd2e7]

        tdf#147021 Replace SAL_N_ELEMENTS with std::size
        
        As part of the efforts in #145538 to replace the SAL_N_ELEMENTS()
        macro with std::size() and std::ssize(), this commit performs the
        necessary changes for a few files in the i18npool module.
        
        Change-Id: Ic64be31b74cd74faf17497a47d6a15158b85184c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166013
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-12  Miklos Vajna  <vmiklos@collabora.com>  [f017fe99f7e7a1beb2c7809b04e069831e706afb]

        sc: fix -Werror,-Wunused-but-set-variable
        
        Pointed out by clang-15:
        
        sc/source/core/data/PivotTableFormatOutput.cxx:256:12: error: variable 'nEntryIndex' set but not used [-Werror,-Wunused-but-set-variable]
            size_t nEntryIndex = 0;
                   ^
        
        Change-Id: I3abf7fe6d4ed330cd713472ce4102eeef6aea4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166022
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  RMZeroFour  <ritobroto04@gmail.com>  [804caab067acaedca85abb9e83170e1a3f01b185]

        tdf#146266 Move WeakBag test to gbuild system
        
        As part of the efforts in tdf#146266 to move parts of the codebase from
        the older makefile.mk build system to the newer gbuild system, this
        commit migrates the WeakBag test, and cleans it up a little.
        
        The test can now be invoked using this command:
        
        $ make CppunitTest_comphelper_weakbag
        
        Change-Id: I4ac3771fa23e28abd38a2dab84cacd1ae57fb70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165591
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-12  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a8fda337a88ca4d47218efa9ee44e7bfd590d30c]

        Add the strings "dialog" after "Macro Selector" in extended tips
        
        because the Macro Selector is the dialog name.
        
        Change-Id: I3e766016279f85c47eca8a6abf8b5dde4cc6a538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165487
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec91e33eaa21d3771406a55a159a2963bcb994b3]

        fold OnDemandNativeNumberWrapper ctor and init together
        
        Change-Id: I79e2cb4c81a2bbac4da16ece778e4ad3acc59eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4a9dae1eb6bbafa1c08939fc50eb3dd85cd7803]

        crashtesting: assert seen on importing forum-mso-en4-62805.xlsx
        
        Change-Id: I1d1ab4539775c8c2fce591ca32fc15c3c0dd6060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166024
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73ba7a4738ecaa730d4d41439b3a4a6d7693efa3]

        crashtesting: assert on exporting fdo48097-1.doc to docx
        
        noticeable since:
        
        commit ad4b72a0eacf6bb6887236ea3a3807b1264de822
        Date:   Thu Mar 21 12:10:40 2024 +0100
        
            tdf#160301 import DOCVARIABLE fields as user fields
        
        but not really caused by it
        
        Change-Id: I44910756df3938829589f230716363beaf0f4f91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166023
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-12  Sujatro Bhadra  <sujatrobhadra@gmail.com>  [1dd7cc9446233f047ace02f4275ef6405587b9c9]

        tdf#116091: Replaced 'AutoFormat' Button in Convert Text to Table dialog
        
        Change-Id: If8eee099e79e65d5a6ca1b06d1cfb2a71bbe52f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165099
        Tested-by: Jenkins
        Reviewed-by: Sujatro Bhadra <sujatrobhadra@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [34c698fe1bf26fd6b01a62df2f847ab05536c215]

        Remove duplicated include
        
        Change-Id: I423fed50156a225d14c0afeebd7b72936c052b97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166008
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-12  Eike Rathke  <erack@redhat.com>  [d4375cf6e6086c3b9cb169cbb40781e8b1124b4d]

        Resolves: tdf#160256 Add "[Multiple]" and "[Undetermined]" to language list
        
        Such that they are added to the top of the list after "[None]" and
        only if "[None]" was requested.
        
        {mul} and {und} ISO codes.
        
        Change-Id: I024311fe7d638124932a1d38759305e8efec5962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166012
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-04-12  Michael Stahl  <michael.stahl@allotropia.de>  [44ff9907eb1f2851b3b9087e7ec5e5dfae5a00c6]

        sw: workaround crash in IsAllHiddenRow()
        
        Not sure why but somehow still crashes in the code added in commit
        ab7893544dc6be6dc192dffefd57cd5ddd421c35
        
        https://crashreport.libreoffice.org/stats/crash_details/912e7417-5e04-4279-bbaf-380234f4cd33
        
        Change-Id: I23b7ecdd83009cfe6584866ed72102d8f2179f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166010
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [732ca4879b7e49b171c5930166e4dba7be451841]

        tdf#159660: Add support for screen mode in feBlend
        
        Change-Id: Iefe655a370cca930319290baa2a25d791371f55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165958
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [51abf44808c6793a184e986b62c0786753e11ded]

        Related: tdf#127293 Fix regex search mode in XLOOKUP wildcards mode
        
        If relevant Option in Calc was set for regex, xlookup still used the
        wildcard search mode.
        
        Change-Id: I318c3f368b6f59644c43ec518542910be72a5e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166015
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [83d04e5a59b762d7edce0fcfaabbba1e26129a27]

        Fix typo
        
        Change-Id: I6e5c31a0d3577c40acd62b4c9dd6d4c084865c0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166016
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c379168711858664baabe7fa482a4c7dd3bc7891]

        pivot: PivotTableFormatOutput to resolve and set PT cell format
        
        This adds the PivotTableFormatOutput, which main responsibility
        is to resolve the reference for which the pivot table format is
        set to. It first prepares the format data into such a structure
        that it is easier to match with the pivot table fields and data.
        Then the pivot table data is filled during the output, where we
        remember the cell positions of the pivot table output. The last
        step is to resolve the pivot table format references with the
        filled data, where the cell formats are applied to the output.
        
        PivotTableFormatsImportExport was added to test the correctnes of
        the functionality.
        
        Change-Id: Ie67ea15b3aa74739f15937800d03d256b8f68277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165992
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-12  Jim Raykowski  <raykowj@gmail.com>  [1dbe90cb078bddaf8bbd333823762744158c92bb]

        Resolves tdf#157403 sidebar SdNavigator does not show new slide/page
        
        after file reload
        
        Change-Id: I8ba7ffac3c098cf388a67e3454c5986b5a8b1f3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165767
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [e20cbd4bd7b1def2926ad48ecb3564597225d3b9]

        lok: calc: not possible to select the cell adjacent to the edited one
        
        In the LOK case using the paper size for the printer case (wysiwyg)
        can make the cell background and visible area larger than needed which
        makes selecting the adjacent right cell impossible in some cases.
        
        Change-Id: I20edd62645692f30e432b1064bb9c85b3396dc32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164702
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit a6bc0272607590d1692db385be7f6fbfeb1a8fb4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164999
        Tested-by: Jenkins

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a9504d55782fb6ce1e64d154b4a3197062277425]

        pivot: remove duplication in ScDPSaveDimension::GetMemberByName
        
        Change-Id: I036e83307615a8c1f875ffc66a54027e1ec31a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165991
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f61ffdfa1a56b1b1fa1aa4f269477e1d1d475955]

        pivot: ScDPSource prefix members
        
        Change-Id: I7551078b798e910c0255a9211c7b22aca624b62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165990
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a1a497ce11ea8932ad6d8e1a7320fb069c4e4e78]

        pivot: use ScPatternAttr not styles for pivot table cell format
        
        Get the ItemSet from the Dxf instead of creating a style from it,
        then create a new ScPatterAttr, which is then transported to the
        pivot table and used there.
        
        Change-Id: I2ed886d0dd986b587e37330a39d6cd465b3bcf12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165686
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6d95493690def02b15c28f2ab1c9b5831675b326]

        pivot: also set format on a data field within row/column output
        
        Change-Id: I83cd4edd8fd64698170e1e8ac83f5017af80042f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165685
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [81a24b62c72d722fd4a80878300e7ab257ecdcc7]

        pivot: split ScDPOutput::Output to multiple methods
        
        Change-Id: Idad1c4652a9d506d0584570e55855b0a9406959a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165684
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [6347c89711903834cc9188abda5d5a253053b789]

        tdf#160176 svx: Reset help text when form control has none
        
        In `FmFormPage::RequestHelp`, also call
        `Help::ShowQuickHelp`/`Help::ShowBalloon` when
        the help text is empty, as that is the way to
        unset the help text/remove the tooltip again,
        see `ImplShowHelpWindow` in `vcl/source/app/help.cxx`:
        
        For the case of non-native tooltips (e.g. the
        gen VCL plugin on Linux), the `bRemoveHelp = true`
        code path is relevant.
        For qt5/qt6/kf5/kf6 which use native tooltips,
        the call to
        
            pParent->ImplGetFrame()->ShowTooltip(rHelpText, rHelpArea)
        
        further up sets the `QtFrame`'s `m_aTooltipText` member
        to an empty string, which prevents showing the outdated
        help text for the `QEvent::ToolTip` event in
        `QtWidget::handleEvent`.
        
        Change-Id: Iceb2424d9c72ae46333a718c677629122e517f11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166006
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [bf4ec3b2beb8121614b8a4098061f49f851b30f8]

        related tdf#160176 qt: Create dummy Qt widget in main thread
        
        Always run `QtGraphics_Controls::getNativeControlRegion`
        in the main thread, as it may create a dummy `QLineEdit`
        (see the `ControlType::MultilineEditbox` and
        `ControlType::Editbox` cases) and creating Qt widgets
        is only allowed in the main thread.
        
        Without the following scenario runs into an assert
        with a current Qt 6 dev debug build when using the
        qt6 VCL plugin:
        
        1) open sample document attachment 193089
           from tdf#160176
        2) enable Form Design Toolbar
        3) switch to Design mode
        4) select label next to "Labelfield2" label
        5) right-click, "Control Properties"
        6) type anything for the help text and tab
           to the next UI element
        
        Backtrace:
        
            ASSERT failure in QWidget: "Widgets must be created in the GUI thread.", file /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp, line 956
        
            Thread 45 "browserlistbox" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fff8d08d6c0 (LWP 203558)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a81cf in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff785a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78444b2 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe32f8540 in qAbort() () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:49
            #5  0x00007fffe330c393 in qt_message_fatal<QString&>(QtMsgType, QMessageLogContext const&, QString&) (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2056
            #6  0x00007fffe3305344 in qt_message(QtMsgType, const QMessageLogContext &, const char *, typedef __va_list_tag __va_list_tag *)
                (msgType=QtFatalMsg, context=..., msg=0x7fffe3981990 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fff8d086178) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:374
            #7  0x00007fffe330740f in QMessageLogger::fatal(char const*, ...) const (this=0x7fff8d0863c0, msg=0x7fffe3981990 "ASSERT failure in %s: \"%s\", file %s, line %d")
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:874
            #8  0x00007fffe32f8613 in qt_assert_x(char const*, char const*, char const*, int)
                (where=0x7fffe1becdf3 "QWidget", what=0x7fffe1becdc8 "Widgets must be created in the GUI thread.", file=0x7fffe1becca0 "/home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp", line=956)
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:114
            #9  0x00007fffe144118c in QWidgetPrivate::init(QWidget*, QFlags<Qt::WindowType>) (this=0x7fff780054d0, parentWidget=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:956
            #10 0x00007fffe1440ca1 in QWidget::QWidget(QWidgetPrivate&, QWidget*, QFlags<Qt::WindowType>) (this=0x7fff8d086d00, dd=..., parent=0x0, f=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:872
            #11 0x00007fffe16a7d22 in QLineEdit::QLineEdit(QString const&, QWidget*) (this=0x7fff8d086d00, contents=..., parent=0x0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qlineedit.cpp:253
            #12 0x00007fffe16a7c98 in QLineEdit::QLineEdit(QWidget*) (this=0x7fff8d086d00, parent=0x0) at /home/michi/development/git/qt5/qtbase/src/widgets/widgets/qlineedit.cpp:239
            #13 0x00007fffe404aebc in QtGraphics_Controls::getNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, rtl::OUString const&, tools::Rectangle&, tools::Rectangle&)
                (this=0x55555cbb13e0, type=ControlType::Editbox, part=ControlPart::Entire, controlRegion=..., controlState=(ControlState::ENABLED | ControlState::ROLLOVER), val=..., nativeBoundingRegion=..., nativeContentRegion=...)
                at vcl/qt6/../qt5/QtGraphics_Controls.cxx:784
            #14 0x00007fffee72945e in SalGraphics::GetNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, tools::Rectangle&, tools::Rectangle&, OutputDevice const&)
                (this=0x55555eb28920, nType=ControlType::Editbox, nPart=ControlPart::Entire, rControlRegion=..., nState=(ControlState::ENABLED | ControlState::ROLLOVER), aValue=..., rNativeBoundingRegion=..., rNativeContentRegion=..., rOutDev=...)
                at /home/michi/development/git/libreoffice/vcl/source/gdi/salgdilayout.cxx:834
            #15 0x00007fffee3a7195 in OutputDevice::GetNativeControlRegion(ControlType, ControlPart, tools::Rectangle const&, ControlState, ImplControlValue const&, tools::Rectangle&, tools::Rectangle&) const
                (this=0x5555607cd870, nType=ControlType::Editbox, nPart=ControlPart::Entire, rControlRegion=..., nState=(ControlState::ENABLED | ControlState::ROLLOVER), aValue=..., rNativeBoundingRegion=..., rNativeContentRegion=...)
                at /home/michi/development/git/libreoffice/vcl/source/outdev/nativecontrols.cxx:313
            #16 0x00007fffede63b9d in ImplSmallBorderWindowView::DrawWindow(OutputDevice&, Point const*) (this=0x5555607c7c10, rRenderContext=...) at /home/michi/development/git/libreoffice/vcl/source/window/brdwin.cxx:699
            #17 0x00007fffede69900 in ImplBorderWindow::Paint(OutputDevice&, tools::Rectangle const&) (this=0x5555607c7ca0, rRenderContext=...) at /home/michi/development/git/libreoffice/vcl/source/window/brdwin.cxx:1628
            #18 0x00007fffede3e241 in PaintHelper::DoPaint(vcl::Region const*) (this=0x7fff8d088188, pRegion=0x7fff78006480) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:313
            #19 0x00007fffede3feff in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x5555607c7ca0, pRegion=0x7fff78006480, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:617
            #20 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d0883c8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #21 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55556002ead0, pRegion=0x7fff78005ec0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #22 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088608) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #23 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555edac0e0, pRegion=0x7fff78005dc0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #24 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088848) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #25 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555edab480, pRegion=0x7fff78005d80, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #26 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088a88) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #27 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555edaa900, pRegion=0x7fff78004c40, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #28 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088cc8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #29 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555ed29400, pRegion=0x7fff78004c00, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #30 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d088f08) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #31 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555eccc910, pRegion=0x7fff78005d40, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #32 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089148) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #33 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555eda7a70, pRegion=0x7fff78004ac0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            --Type <RET> for more, q to quit, c to continue without paging--
            #34 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089388) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #35 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555eda2210, pRegion=0x7fff78001230, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #36 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d0895c8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #37 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555ecd5d20, pRegion=0x7fff78002510, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #38 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089808) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #39 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555ecdae90, pRegion=0x7fff78001ae0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #40 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089a48) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #41 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555bb5ddb0, pRegion=0x55555eb4e340, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #42 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089c88) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #43 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags)
                (this=0x55555ed5c6e0, pRegion=0x7fff78001310, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #44 0x00007fffede3f791 in PaintHelper::~PaintHelper() (this=0x7fff8d089ec8) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:552
            #45 0x00007fffede3ff86 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x55555eb3aa10, pRegion=0x0, nPaintFlags=(ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase))
                at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:623
            #46 0x00007fffede41a32 in vcl::Window::PaintImmediately() (this=0x5555607c7ca0) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:1340
            #47 0x00007fffede415a0 in vcl::Window::PaintImmediately() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/window/paint.cxx:1280
            #48 0x00007fffee17f7ac in Edit::ImplInvalidateOrRepaint() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:451
            #49 0x00007fffee182a52 in Edit::ImplAlignAndPaint() (this=0x5555607c49b0) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:1170
            #50 0x00007fffee183ef0 in Edit::ImplInsertText(rtl::OUString const&, Selection const*, bool) (this=0x5555607c49b0, rStr="ee", pNewSel=0x7fff8d08a6b8, bIsUserInput=false)
                at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:885
            #51 0x00007fffee1841ca in Edit::ImplSetText(rtl::OUString const&, Selection const*) (this=0x5555607c49b0, rText="ee", pNewSelection=0x7fff8d08a6b8) at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:918
            #52 0x00007fffee18cfd4 in Edit::SetText(rtl::OUString const&) (this=0x5555607c49b0, rStr="ee") at /home/michi/development/git/libreoffice/vcl/source/control/edit.cxx:2560
            #53 0x00007fffee8d974a in SalInstanceEntry::set_text(rtl::OUString const&) (this=0x5555607c4200, rText="ee") at /home/michi/development/git/libreoffice/vcl/source/app/salvtables.cxx:3383
            #54 0x00007fff7ef6054a in pcr::OEditControl::setValue(com::sun::star::uno::Any const&) (this=0x5555607c7660, _rValue=uno::Any("string": "ee"))
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/standardcontrol.cxx:200
            #55 0x00007fff7ed96819 in pcr::OBrowserListBox::impl_setControlAsPropertyValue(pcr::ListBoxLine const&, com::sun::star::uno::Any const&) (_rLine=..., _rPropertyValue=uno::Any("string": "ee"))
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:551
            #56 0x00007fff7ed96485 in pcr::OBrowserListBox::SetPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&, bool) (this=0x55555eda22b0, _rEntryName="HelpText", _rValue=uno::Any("string": "ee"), _bUnknownValue=false)
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:403
            #57 0x00007fff7ef432e8 in pcr::OPropertyEditor::SetPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&, bool) (this=0x55555ecdb3e0, rEntryName="HelpText", _rValue=uno::Any("string": "ee"), _bUnknownValue=false)
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/propertyeditor.cxx:277
            #58 0x00007fff7ef01d4f in pcr::OPropertyBrowserController::Commit(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x55555c5f1b40, rName="HelpText", _rValue=uno::Any("string": "ee"))
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/propcontroller.cxx:1337
            #59 0x00007fff7ed954ae in pcr::OBrowserListBox::valueChanged(com::sun::star::uno::Reference<com::sun::star::inspection::XPropertyControl> const&) (this=0x55555eda22b0, _rxControl=uno::Reference to (pcr::OEditControl *) 0x5555607c76b0)
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:637
            #60 0x00007fff7ed95268 in pcr::PropertyControlContext_Impl::impl_processEvent_throw(comphelper::AnyEvent const&) (this=0x55555ed29270, _rEvent=...)
                at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:291
            #61 0x00007fff7ed950b9 in pcr::PropertyControlContext_Impl::processEvent(comphelper::AnyEvent const&) (this=0x55555ed29270, _rEvent=...) at /home/michi/development/git/libreoffice/extensions/source/propctrlr/browserlistbox.cxx:272
            #62 0x00007ffff6118a2e in comphelper::AsyncEventNotifierBase::execute() (this=0x5555568d6620) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:139
            #63 0x00007ffff6119165 in comphelper::AsyncEventNotifier::execute() (this=0x5555568d6620) at /home/michi/development/git/libreoffice/comphelper/source/misc/asyncnotification.cxx:156
            #64 0x00007ffff7d0f6ec in salhelper::Thread::run() (this=0x5555568d6630) at /home/michi/development/git/libreoffice/salhelper/source/thread.cxx:39
            #65 0x00007ffff7d0ff2e in threadFunc(void*) (param=0x5555568d6640) at include/osl/thread.hxx:189
            #66 0x00007ffff7fa4b2d in osl_thread_start_Impl(void*) (pData=0x55555ecc3e40) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:237
            #67 0x00007ffff78a645c in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444
            #68 0x00007ffff7926bbc in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
        
        Change-Id: I9e0b0d973997e3f4f50a9a31e9692325664fd262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165995
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [520722210d9ffcf57b08e4bd7dd8803c5190937c]

        a11y: Assign a11y role for WindowType::PROGRESSBAR
        
        `WindowType::PROGRESSBAR` was recently added in
        
            commit 460a7103664ac8dc60e260c56e5113d689b8072f
            Author: Hubert Figuière <hub@collabora.com>
            Date:   Fri Mar 22 09:59:54 2024 -0400
        
                vcl: Implement JSLevelBar
        
                This fixes the JSDialog layout of the sheet protection dialog.
                This was introduced for 24.02 to provide password strength indication
                of the sheet password.
        
                Defined a new WindowType of PROGRESSBAR.
                The type property in JSDialog JSON will be "progressbar".
        
        Map it to the corresponding a11y role,
        `accessibility::AccessibleRole::PROGRESS_BAR`, so
        it's reported as such on the a11y level.
        
        The role can e.g. be seen in Accerciser for the password strength
        indicator (progress bar) in the dialog to set a document password
        (shown when checking the "Save with password" checkbox in the Save
        dialog in Writer).
        
        Before:
        
            In [2]: acc.role
            Out[2]: <enum ATSPI_ROLE_PANEL of type Atspi.Role>
        
        With this commit in place:
        
            In [8]: acc.role
            Out[8]: <enum ATSPI_ROLE_PROGRESS_BAR of type Atspi.Role>
        
        Change-Id: Idfd7798641e30632a9ffd2ea07a79d42d159a51f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165989
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [0de33d779747d4117348daf92b08b105102968b3]

        vcl a11y: Reformat switch-case in Window::getDefaultAccessibleRole
        
        Use more standard formatting for this switch-case in
        `Window::getDefaultAccessibleRole` (mostly done by clang-format).
        It helps at least myself see more easily what a11y role
        a window type is mapped to as the assignment and break are
        on separate, further indented lines now.
        
        Change-Id: Ic6c7588f2212055812cd32d34eccbaf27fa41eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [77eb3f1a76892b6070e77324e260204408383ef4]

        IASS: Correct Buffering of last Slide
        
        There is a mechanism to pre-fetch the next slide, but
        at the last slide that just gets not reset/refreshed.
        Thus the last slide *is* the buffered slide.
        When making changes and refreshing the SlideShow display
        for the last slide this pe-fetched one is just used, so
        the slide content gets not re-created and thus not
        updated.
        I added needed code to do that now when reacing the last
        slide to make that work.
        
        Change-Id: Ie57e6917e0996d5fce46021aeb933064c47dd90f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166011
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-11  László Németh  <nemeth@numbertext.org>  [11ed593acc339d848806cd263e1de9503965a53a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58350a811a8001f72b13f6ca3def5f32ea904e72
          - tdf#132599 add "Hyphenation across" options
            
            Document new options of LO 24.8 to control hyphenation
            in last line of a column, page or spread.
            
            Follow-up to core commit 6e8819f29b6051a0e551d77512830539913ec277
            "tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type",
            core commit 9574a62add8e4901405e12117e75c86c2d2c2f21
            "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep" and
            core commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463
            "tdf160518 DOCX: import hyphenation-keep to fix layout".
            
            Change-Id: I1d7d6ef1b154f7c6dd55e99584d1d27ce46899ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/166009
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3146d6759869fca4753edefddc503a5a89a42b91]

        pivot: un-abbreviate vars. in ScDPOutput::Output
        
        Change-Id: If480afbdcb2a350907a1cac734ebf76424825371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165683
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [af5bb01b9430b76ae8042b5ce6ebda65798bbb18]

        pivot: forward pivot table format data into the pivot table model
        
        The purpuse of this is to lay out the foundation for the support
        of pivot table formatting. This adds the code to forward the
        formatting information from the OOXML import into the pivot table
        model and uses it in a use case to set the row and column labels
        in the pivot table output (DPOutput). In the follow up commits the
        support will be extended to support more use cases with tests.
        
        Change-Id: Idf23884b32167bdbad69bc67358ccf7f14566db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164710
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a180bf0c0f805462c2ba84abcdcc89c59d1e50fa]

        pivot: Import Pivot Table "formats" element(s)
        
        This reads the "formats" element that is a subelement of OOXML
        "pivotTableDefinition" element and is used to define the custom
        cell format of a pivot table output.
        
        Change-Id: Ice0d489d78860ef04388c59810d9f97c5cdb983e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164708
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [2cb757db3409cef9e0568ffa6409da7522fd702e]

        Move variables into their usage scope
        
        Change-Id: I9b04a3b62fed65139a4b48629e9b442ba163a3d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165931
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [969ddf72824942be9755a8d14482d6549a2231ce]

        tdf#160616 - Fix SUMPRODUCT calculation is broken in some cases
        
        Double refs with operators only trimmable in case of one root paramater.
        
        Follow up of: ba0ec4a5d2b025b675410cd18890d1cca3bc5a2f
        
        Change-Id: If61fb39696d9539ffc9d32a6ecad79bfa1bf92e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165957
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [febd03e31b2e45f2c4ad3277939a1316fcf1cc79]

        Move org.libreoffice.embindtest from udkapi to offapi
        
        ...so it will be able to use e.g. css.task.XJob in its tests
        
        Change-Id: I15e50c07ee4b1b315d2687dc7e7ea0c00ccc638c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165998
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b6c10f89e25f43cac4eab8d596dbdba3c5e11ef2]

        When no branch is specified, fallback to the tracked branch first
        
        This allows to work in a branch foo, which tracks e.g. master, and
        using plain ./logerrit submit, have it submit to master properly.
        
        Change-Id: I7aaff759392250a5380853cbaea0f892461c1d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9bbecbaea359350c2e0d78ebe4dcd10d16dccbee]

        Use COMReference in D2DWriteTextOutRenderer
        
        ... and simplify the related code.
        
        Change-Id: Idaef7c9d725273e202948158e45ded7e7a2f85a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165985
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-11  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [fd7afc0a660992cb99650e3ea26cafd226899093]

        related tdf#33603: sd: fix notespanel crash on drag and drop
        
        Change-Id: I067fd3f3eccd8e0fa0d13795f660fe43410b0aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165809
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-11  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [7a495eb899585c8443b2141534f166b77916b68e]

        related tdf#33603: sd: force invalidate notespanel
        
        This is likely not the correct thing to do here, but is a working
        solution that fixes the view lagging behind the resize for now.
        
        Change-Id: I662e59cfd0f1259eeb10a49b6e9c5fd616afa7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165808
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-11  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [c3bc5c09e093967ad77cb1ee3330b80d16bfae95]

        related tdf#33603: fix notespanel missing outliner on mode change
        
        When MainViewShell changed editing mode, two EventMultipexerEvents
        arrive in succession - if while processing the first one links are
        reset, second one was ignored.
        
        Do not remove EventMultiplexer listener on FillOutliner()
        
        Change-Id: I9c41c823ca74574238d1199ed38f92d9c75a113e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165807
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-11  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [291919476294f62d7af9b8b7060d138728897ee7]

        tdf#33603: sd: rework notes panel
        
        To be able to support various dispatch commands, sidebar, proper
        user configuration, and more - reworked the previous notes panel
        implementation as a sd::View/sd::ViewShell pair that plays nice
        with Impress framework.
        
        To be able to support TextObjectBar(Shell) functionality, without
        having TextObjectBar as a SubShell (In the current sd::framework
        implementation AFAICS, SubShells are only possible for the
        MainViewShell - this doesn't work for notes panel which is never
        used as the MainViewShell.).
        
        A workaround is implemented where NotesPanel inherits dispatching
        slots from TextObjectBar, and for these inherited slots forwards
        the calls to TextObjectBar's implementation.
        
        This workaround could be removed if/when, SubShell support
        outside of MainViewShell is implemented.
        
        Known issues/TODO:
        - Drag & Drop crashes / doesn't work.
        
        - Some notes placeholder syncing problems on page change, edit mode
          change.
        
        - A rendering issue related to resizing when ArrangeGUIElements
          isn't called on resize.
        
        Change-Id: I588a4854fbedf6556e001fee1693b32410cbc23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165770
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [8d85da5616bab28c1df226bcbf4fe777b14b363e]

        Only call ID2D1RenderTarget::Get/SetTransform when needed
        
        Change-Id: Ifde2c24c222e3c316f5a4f47e86c2c08f676639a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165983
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-11  László Németh  <nemeth@numbertext.org>  [6e8819f29b6051a0e551d77512830539913ec277]

        tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type
        
        Support XSL attribute "column" and CSS 4 attribute "spread",
        stored in loext:hyphenation-keep-type, to give better control
        over hyphenation-keep. E.g. spread: both parts of a hyphenated
        word shall lie within a single spread, i.e. when the next page
        is not visible at the same time (e.g. the next page is not a
        right page of a book).
        
        – css::style::ParaHyphenationKeep is a boolean property now,
          importing hyphenation-keep = "page" as true.
        
        – type of ParaHyphenationKeep, including the new non-ODF types
          is stored in the new ParagraphProperties::ParaHyphenationKeepType.
        
        – default value of ParaHyphenationKeepType is COLUMN for
          interoperability.
        
        – Add checkboxes to Text Flow -> Hyphenation Across in
          paragraph dialog:
        
          * Column (previously: Hyphenate across column and page)
          * Page
          * Spread
        
          – enabling/disabling them follows XSL/CSS 4/loext, i.e.
            possible combinations:
        
          * No Hyphenation across
            (hyphenation-keep = "page" and loext:hyphenation-keep-type = "column")
        
          * Hyphenation across [x] Column
            (hyphenation-keep = "page" and loext:hyphenation-keep-type = "page")
        
          * Hyphenation across [x] Column [x] Page
            (hyphenation-keep = "page" and loext:hyphenation-keep-type = "spread")
        
          * Hyphenation across [x] Column [x] Page [x] Spread
            (hyphenation-keep = "auto")
        
        – Add ODF import/export
        
        – Update DOCX import
        
        – Add ODF unit tests
        
        Note: recent implementation depends on widow settings: disabling widow
        handling allows hyphenation across columns and pages not only in table
        cells.
        
        Note: RTF import-only, but not used bPageEnd has been renamed to bKeep.
        Depending on the RTF test results, likely it will need to disable
        the layout change, e.g. GetKeepType()=ParagraphHyphenationKeepType::AUTO,
        if PageEnd uses obsolete hyphenation rule, i.e. shifting only the
        hyphenated word to the next page, not the full line.
        
        More information:
        
        – COLUMN (standard XSL value, defined in
          https://www.w3.org/TR/2001/REC-xsl-20011015/slice7.html#hyphenation-keep)
        
        – SPREAD and ALWAYS (CSS 4 values of hyphenate-limit-last,
          equivalent of hyphenation-keep, defined in
          https://www.w3.org/TR/css-text-4/#hyphenate-line-limits).
        
        Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21
        "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep" and
        commit c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463
        "tdf160518 DOCX: import hyphenation-keep to fix layout".
        
        Change-Id: I3ac6d9e86d0ed1646f105de8607c0e8ebc534eaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165954
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-04-11  Miklos Vajna  <vmiklos@collabora.com>  [d890c27b670aa2fcd06a40021ddf6a5b44714a49]

        CppunitTest_sw_uibase_shells: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), got rid of 'ＭＳ 明朝' as suggested by the failing assert.
        
        Change-Id: I24dcf0bffa8c213f776c0483d53fdee64ff7a413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165982
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1dc1729183ac2e8ba9abf067dac38f39a3a5454a]

        Drop old Windows 95/98/ME problem workaround
        
        KB305290 (broken link https://support.microsoft.com/en-us/help/305290)
        was for these long-unsupported systems.
        
        Change-Id: Ie2e3814d24ceb5d014c0bff1a39b3d6675e3603c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165981
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3f5811a4649b9e43e610afd3ff57c14bd57589d0]

        Silence strange -Warray-bounds with recent GCC 14
        
        ...seen at least with some (--enable-dbgutil --enable-optimized etc.)
        configuration and a recent GCC 14 trunk,
        
        > In file included from ~/gcc/inst/include/c++/14.0.1/vector:62,
        >                  from connectivity/source/drivers/postgresql/pq_connection.cxx:38:
        > In static member function ‘static constexpr _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = long unsigned int; _Up = long unsigned int; bool _IsMove = false]’,
        >     inlined from ‘constexpr _OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:521:30,
        >     inlined from ‘constexpr _OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:548:42,
        >     inlined from ‘constexpr _OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:555:31,
        >     inlined from ‘constexpr _OI std::copy(_II, _II, _OI) [with _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:651:7,
        >     inlined from ‘constexpr std::__cxx1998::vector<bool, _Alloc>::iterator std::__cxx1998::vector<bool, _Alloc>::_M_copy_aligned(const_iterator, const_iterator, iterator) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:1342:28,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::_M_reallocate(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/vector.tcc:1054:40,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::reserve(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:1130:17,
        >     inlined from ‘constexpr void std::__debug::vector<_Tp, _Allocator>::reserve(size_type) [with _Tp = bool; _Allocator = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/debug/vector:495:16,
        >     inlined from ‘pq_sdbc_driver::{anonymous}::cstr_vector::cstr_vector()’ at connectivity/source/drivers/postgresql/pq_connection.cxx:338:58:
        > ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:452:30: error: ‘void* __builtin_memmove(void*, const void*, long unsigned int)’ forming offset 8 is out of the bounds [0, 8] [-Werror=array-bounds=]
        >   452 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
        >       |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        and
        
        > In file included from ~/gcc/inst/include/c++/14.0.1/vector:62,
        >                  from connectivity/source/drivers/postgresql/pq_connection.cxx:38:
        > In static member function ‘static constexpr _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = long unsigned int; _Up = long unsigned int; bool _IsMove = false]’,
        >     inlined from ‘constexpr _OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:521:30,
        >     inlined from ‘constexpr _OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:548:42,
        >     inlined from ‘constexpr _OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:555:31,
        >     inlined from ‘constexpr _OI std::copy(_II, _II, _OI) [with _II = long unsigned int*; _OI = long unsigned int*]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:651:7,
        >     inlined from ‘constexpr std::__cxx1998::vector<bool, _Alloc>::iterator std::__cxx1998::vector<bool, _Alloc>::_M_copy_aligned(const_iterator, const_iterator, iterator) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:1342:28,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::_M_reallocate(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/vector.tcc:1054:40,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::reserve(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:1130:17,
        >     inlined from ‘constexpr void std::__debug::vector<_Tp, _Allocator>::reserve(size_type) [with _Tp = bool; _Allocator = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/debug/vector:495:16,
        >     inlined from ‘pq_sdbc_driver::{anonymous}::cstr_vector::cstr_vector()’ at connectivity/source/drivers/postgresql/pq_connection.cxx:338:58:
        > ~/gcc/inst/include/c++/14.0.1/bits/stl_algobase.h:452:30: error: ‘void* __builtin_memmove(void*, const void*, long unsigned int)’ writing between 9 and 9223372036854775807 bytes into a region of size 8 overflows the destination [-Werror=stringop-overflow=]
        >   452 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
        >       |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > In file included from ~/gcc/inst/include/c++/14.0.1/x86_64-pc-linux-gnu/bits/c++allocator.h:33,
        >                  from ~/gcc/inst/include/c++/14.0.1/bits/allocator.h:46,
        >                  from ~/gcc/inst/include/c++/14.0.1/vector:63:
        > In member function ‘_Tp* std::__new_allocator<_Tp>::allocate(size_type, const void*) [with _Tp = long unsigned int]’,
        >     inlined from ‘constexpr _Tp* std::allocator< <template-parameter-1-1> >::allocate(std::size_t) [with _Tp = long unsigned int]’ at ~/gcc/inst/include/c++/14.0.1/bits/allocator.h:196:40,
        >     inlined from ‘static constexpr _Tp* std::allocator_traits<std::allocator<_Up> >::allocate(allocator_type&, size_type) [with _Tp = long unsigned int]’ at ~/gcc/inst/include/c++/14.0.1/bits/alloc_traits.h:478:28,
        >     inlined from ‘constexpr std::__cxx1998::_Bvector_base<_Alloc>::_Bit_pointer std::__cxx1998::_Bvector_base<_Alloc>::_M_allocate(std::size_t) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:679:48,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::_M_reallocate(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/vector.tcc:1052:43,
        >     inlined from ‘constexpr void std::__cxx1998::vector<bool, _Alloc>::reserve(size_type) [with _Alloc = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_bvector.h:1130:17,
        >     inlined from ‘constexpr void std::__debug::vector<_Tp, _Allocator>::reserve(size_type) [with _Tp = bool; _Allocator = std::allocator<bool>]’ at ~/gcc/inst/include/c++/14.0.1/debug/vector:495:16,
        >     inlined from ‘pq_sdbc_driver::{anonymous}::cstr_vector::cstr_vector()’ at connectivity/source/drivers/postgresql/pq_connection.cxx:338:58:
        > ~/gcc/inst/include/c++/14.0.1/bits/new_allocator.h:151:55: note: destination object of size 8 allocated by ‘operator new’
        >   151 |         return static_cast<_Tp*>(_GLIBCXX_OPERATOR_NEW(__n * sizeof(_Tp)));
        >       |                                                       ^
        
        Change-Id: I6ef1be6428363ff37d591207df379cc18ebea933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165959
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d5dcc9de8ebce5d14be89ddeb6606ef0aeebf7a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c2b91a5c78e053498f5ff6a411c314e36eb4a859
          - Stick to translatable content and simplify.
            
            * The example was locale dependent and was removed.
            
            Change-Id: I1df47fb5ba18ca4874b8b681ffff88a6fa7514aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165910
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-10  Justin Luth  <jluth@mail.com>  [7b515b473cfb706c9fa0b474f27d61351aeec3a3]

        tdf#160293 sc NBB: tabbed groupbar_compact keep tabs in Pivot context
        
        The VBox was hidding each child item since none had
        Pivot or any as context types.
        
        This didn't affect any other NBB variants
        because they hadn't wrapped the tabs in a ContextVBox.
        
        Using context-any would be bad for PrintPreview for example.
        
        Change-Id: I47c4c9c813c17dde5440ae6dbadb8d1ab066d293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165956
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-04-10  Omkar Santosh Nikam  <omkar.nikam.2026@gmail.com>  [7d1dc5707edb992f62d0a4b5bf1e8395f71f6e7b]

        tdf#143148 Use pragma once instead of include guards
        
        Use pragma once
        
        Change-Id: Iedf25f6034f285e9bdcab515ec6d9e20b230d969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165955
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-10  Jim Raykowski  <raykowj@gmail.com>  [64f1fbc4a66715aa616ffeff1eb612393fa9fba3]

        tdf#160190 Fix selection stops working in sidebar SdNavigator
        
        after formula or OLE insert
        
        Change-Id: I945a07fef137aa30afff91ac7c50f180e5f4c3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164797
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-10  Jim Raykowski  <raykowj@gmail.com>  [833e2ecf43708332b248689304a53b5c50af155d]

        tdf#139944 follow up
        
        Also refresh the document info list so the objects tree will fill on
        switching to normal view mode after the Navigator is opened in master
        view mode.
        
        Change-Id: I3749060206408ca2b9b58de541a9c9bf1731ec4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165917
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-10  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [614bcc594285c3badb26710d9b78e80bdeca0b81]

        IASS: Support Mouse-Wheel Actions
        
        The support for MouseWheel was missing. That showed
        when using it in IASS the scroll commands were always
        feeded to the SlideShow. Thus it was not possible
        to e.g. scroll using MouseWheel in EditView when
        IASS was active and SlideShow running.
        
        This happens in ViewShell::HandleScrollCommand. It
        needs to be made focus-dependent when IASS is active.
        
        This is the same as already done for keyboard input,
        so I consolidated this now to a method called
        ViewShell::useInputForSlideShow() that does all the
        necessary stuff and answers as needed. Using that
        in various places: keyboard and MouseWheel, but also
        adapted other places where the same has to happen,
        mainly some gesture stuff.
        
        Change-Id: I1a697e4b35b195695f1a5ea2305a3cee8851fa8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165929
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-10  Patrick Luby  <guibmacdev@gmail.com>  [fe3a4bdf48f7b2d4f6da31b4392ac5979653cf9c]

        tdf#160590 Disable Metal with Intel HD Graphics 6000
        
        Releasing a Metal buffer resource hangs when fetching pixels from a
        Skia surface on this Intel MacBook Air built-in GPU.
        
        Change-Id: Ic3028bf8eb45ebb9f6d71879bf5d96f0401a95c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165927
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-04-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1f3120ce83c113d7dc91b60f50344f63f1c41f0]

        vcl: return earlier if size is empty
        
        Change-Id: I96bcd47d93e0e4d05e33d3ad3eca86c6edcf87ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165950
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fe66cf8c8048bfd8a4386c0c711bd6912af9ec63]

        New Expert Configuration setting to not offer Safe Mode in the UI
        
        /org.openoffice.Office/Common/Misc/OfferSafeMode (default: true), controlling:
        * "Help - Restart in Safe Mode..." menu entry
        * "Restart LibreOffice to enter safe mode" checkbox in the "Crash Report" dialog
        * "To start temporarily with a fresh user profile,..." tip of the day
        
        (It does not control the --safe-mode command line argument, though.)
        
        Change-Id: I66084448a1ba9427aaafef630187b4bf25219a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-10  Noel Grandin  <noelgrandin@gmail.com>  [7f9a35e6efc4118ecc46fa6f76fc5a812259eea1]

        use unordered_map for ScTokenMatrixMap
        
        which is considerably faster
        
        Change-Id: Ic44d88d8ef222edd91de8ae0e79d77a99c5c2e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-10  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [97af15c86ccd4f780d7cf8e79cd49cd2e9aef5f6]

        tdf#114441 Convert sal_uLong to better integer types
        
        This patch changes the usage of type sal_uLong in sc module to sal_Int32.
        Looking into ScRefreshTimer constructor in sc/inc/refreshtimer.hxx, it
        becomes clear that sal_Int32 is a good choice. The usage is for
        communicating the refresh delay, measured in seconds. The reason to use
        signed variables is to follow the convention in ScRefreshTimer class.
        
        Change-Id: Ib565fd50ec4e6a46e95e9db06b7798a0b4a38d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164957
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fa42bdabcab05bd6c671b9e255f4ffe6293bc0e9]

        Drop unused define CALC_TEST_PERF
        
        Seems to be not used since 2016 commit
        52871b360c73efd59bfbc811b8b89a02b6375b29
        
        Change-Id: Ie1f95ece6d9b6efe93dd16adcdacd644deb21fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165914
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-10  Zainab Abbasi  <101zabbasi@gmail.com>  [547f3215fc60819998ca80110ad56e02c41e4b3f]

        tdf#143148 Use pragma once instead of include guards
        
        use pragma once
        
        Change-Id: I96babd680b494600b0e159ab757208fcecf2049e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165922
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8559e6b5a5ac7f7400ae44adddbff5e3185414c6]

        Adapt flatpak build to upstream changes
        
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/29463ebd29eb10ba7891c87bd699047e5e13deb7>
        "Merge pull request #288 from
        EliasTheGrandMasterOfMistakes/EliasTheGrandMasterOfMistakes-patch-2: Update JDK,
        GVFS and ANT"
        
        Change-Id: I021ddb9ca6b1fbec6cfe22784a9d023db2fa737c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165920
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-10  Noel Grandin  <noelgrandin@gmail.com>  [78833978264581f1e7f485526c8ef0e0e34afe56]

        simplify OGenericUnoController init
        
        Change-Id: I9053e8f320b140bbb6907daac61939258245ff7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165913
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-10  Noel Grandin  <noelgrandin@gmail.com>  [1dd0d2ce717c2805b52fd59804cf0ea3f7d872c3]

        OGenericUnoController remove some typedefs
        
        Change-Id: I9e582c19cd6a169d839aea9d2192e31ab06366b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165912
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [834cbc4ccf09853b2830d7ebf6c5ce5c45a357cc]

        kit: Update formulas when switching tabs
        
        we moved to not forcing a redraw on switching tabs
        at:
        
        commit 9f3ee2b27ceeab175fb865a55cfeabd66fbb128d
        Date:   Sun Jan 14 16:29:56 2024 +0000
        
            don't invalidate when switching tabs
        
        but in a scenario (to which two_sheets.ods is updated to capture) where
        there is no view/user active on a sheet B that depends on cells in sheet
        A, then when A is updated, B does not update automatically to reflect
        the changes in A.
        
        So, on switching to a tab, do the check for out of date formulas on
        the switched to tab.
        
        Change-Id: Ibbba83119adbd323b42314dbd9bcba6f797e5934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165911
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [164bde27bab3c4a4166230d60d591b54efe703c0]

        cid#1596245 Explicit null dereferenced
        
        Change-Id: I3912517648f76cd7a0fd651cf592bce427dc69f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165900
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-10  Miklos Vajna  <vmiklos@collabora.com>  [4dc788ea10e0b0d89ed1edf3cde39af4c304fa9f]

        CppunitTest_sw_rtfexport2: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I50de20f3199878db2b9fe7e66f09b2620e43cc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165918
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1a91641fd6fd84eb0bfae75db54f35c7771a2a1c]

        tdf#146619 Drop unused 'using namespace' in: sw/
        
        Change-Id: I56463130ab617b0e11e237718cb8456913373818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165696
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d70f461d83e72bfea63526706a07c1e0c4dea66d]

        tdf#146619 Drop unused 'using namespace' in: sc/
        
        Change-Id: I03478dd4c8e3c2ac88c0fe5e51efd53b09888475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165695
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [42f6e89d5e6458966de452af2978f206115394af]

        Avoid -O2 in AC_PROG_CC/CXX, work around occasional Clang 12.0.1 SEGVs
        
        At least with one ASan/UBSan setup of mine using LODE's Clang 12.0.1,
        ./autogen.sh would occasionally detect -std=gnu11 as the required CC "option to
        enable C11 features" (which would in turn cause building external/firebird to
        fail oddly; an issue worth investigations of its own), because Clang would
        occasionally crash with a SEGV on the corresponding configure test program's
        first invocation (without -std=gnu11) when invoked with -O2 (and happen to
        succeed on second invocation with -std=gnu11, so configure thinks that's
        needed), see below for a relevant config.log excerpt.
        
        When CC/CXX are already set (as is the case in this scenario), we could arguably
        skip the AC_PROG_CC/CXX checks entirely (and thus avoid configure potentially
        adding -std=gnu11 to CC), but at least AC_PROG_CC also internally sets the GCC
        shell var, which we use in configure.ac.  So better be conservative and just
        avoid -O2 during AC_PROG_CC/CXX (whatever the autoconf motivation to include it
        in the first place).
        
        > configure:8165: checking for /home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/sberg/lo0/core/sanitize-ubsan-excludelist option to enable C11 features
        > configure:8180: /home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/sberg/lo0/core/sanitize-ubsan-excludelist  -c -g -O2  conftest.c >&5
        > PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
        > Stack dump:
        > 0.	Program arguments: /home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/sberg/lo0/core/sanitize-ubsan-excludelist -c -g -O2 conftest.c
        > 1.	<eof> parser at end of file
        > 2.	Code generation
        >  #0 0x000055f3a890caf2 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1c3eaf2)
        >  #1 0x000055f3a890a734 llvm::sys::RunSignalHandlers() (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1c3c734)
        >  #2 0x000055f3a887b998 CrashRecoverySignalHandler(int) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1bad998)
        >  #3 0x00007f750d24e520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
        >  #4 0x000055f3a93f9cd4 llvm::DIE::getUnitDie() const (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x272bcd4)
        >  #5 0x000055f3a9404574 llvm::DwarfDebug::finishEntityDefinitions() (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2736574)
        >  #6 0x000055f3a941df99 llvm::DwarfDebug::finalizeModuleInfo() (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x274ff99)
        >  #7 0x000055f3a9421128 llvm::DwarfDebug::endModule() (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2753128)
        >  #8 0x000055f3a93f1219 llvm::AsmPrinter::doFinalization(llvm::Module&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2723219)
        >  #9 0x000055f3a82478f5 llvm::FPPassManager::doFinalization(llvm::Module&) (.localalias) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x15798f5)
        > #10 0x000055f3a8253900 llvm::legacy::PassManagerImpl::run(llvm::Module&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1585900)
        > #11 0x000055f3a8bb57d3 (anonymous namespace)::EmitAssemblyHelper::EmitAssembly(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >) (.constprop.0) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1ee77d3)
        > #12 0x000055f3a8bb76ea clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::DataLayout const&, llvm::Module*, clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1ee96ea)
        > #13 0x000055f3a9825876 clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2b57876)
        > #14 0x000055f3aa35c549 clang::ParseAST(clang::Sema&, bool, bool) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x368e549)
        > #15 0x000055f3a91ef2d9 clang::FrontendAction::Execute() (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x25212d9)
        > #16 0x000055f3a91903a3 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x24c23a3)
        > #17 0x000055f3a92a2fd8 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x25d4fd8)
        > #18 0x000055f3a7798815 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0xaca815)
        > #19 0x000055f3a77961a7 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0xac81a7)
        > #20 0x000055f3a9039689 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, bool*) const::'lambda'()>(long) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x236b689)
        > #21 0x000055f3a887baa7 llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x1badaa7)
        > #22 0x000055f3a903a802 clang::driver::CC1Command::Execute(llvm::ArrayRef<llvm::Optional<llvm::StringRef> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, bool*) const (.part.0) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x236c802)
        > #23 0x000055f3a900fbec clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&) const (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2341bec)
        > #24 0x000055f3a9010679 clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*> >&) const (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x2342679)
        > #25 0x000055f3a901e8f1 clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*> >&) (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0x23508f1)
        > #26 0x000055f3a7717e6f main (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0xa49e6f)
        > #27 0x00007f750d235d90 (/lib/x86_64-linux-gnu/libc.so.6+0x29d90)
        > #28 0x00007f750d235e40 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e40)
        > #29 0x000055f3a7795b55 _start (/home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang+0xac7b55)
        > clang-12: error: clang frontend command failed with exit code 139 (use -v to see invocation)
        > clang version 12.0.1 (https://github.com/llvm/llvm-project.git fed41342a82f5a3a9201819a82bf7a48313e296b)
        > Target: x86_64-unknown-linux-gnu
        > Thread model: posix
        > InstalledDir: /home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin
        > clang-12: note: diagnostic msg:
        > ********************
        >
        > PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
        > Preprocessed source(s) and associated run script(s) are located at:
        > clang-12: note: diagnostic msg: /tmp/conftest-968380.c
        > clang-12: note: diagnostic msg: /tmp/conftest-968380.sh
        > clang-12: note: diagnostic msg:
        >
        > ********************
        > configure:8180: $? = 139
        > configure: failed program was:
        > | /* confdefs.h */
        > | #define PACKAGE_NAME "LibreOffice"
        > | #define PACKAGE_TARNAME "libreoffice"
        > | #define PACKAGE_VERSION "24.8.0.0.alpha0+"
        > | #define PACKAGE_STRING "LibreOffice 24.8.0.0.alpha0+"
        > | #define PACKAGE_BUGREPORT ""
        > | #define PACKAGE_URL "http://documentfoundation.org/"
        > | #define LIBO_VERSION_MAJOR 24
        > | #define LIBO_VERSION_MINOR 8
        > | #define LIBO_VERSION_MICRO 0
        > | #define LIBO_VERSION_PATCH 0
        > | #define LIBO_THIS_YEAR 2024
        > | #define SRCDIR "/home/sberg/lo0/core"
        > | #define SRC_ROOT "/home/sberg/lo0/core"
        > | #define BUILDDIR "/home/sberg/lo0/core"
        > | #define USE_HEADLESS_CODE 1
        > | #define ENABLE_HEADLESS 1
        > | /* end confdefs.h.  */
        > |
        > | /* Does the compiler advertise C89 conformance?
        > |    Do not test the value of __STDC__, because some compilers set it to 0
        > |    while being otherwise adequately conformant. */
        > | #if !defined __STDC__
        > | # error "Compiler does not advertise C89 conformance"
        > | #endif
        > |
        > | #include <stddef.h>
        > | #include <stdarg.h>
        > | struct stat;
        > | /* Most of the following tests are stolen from RCS 5.7 src/conf.sh.  */
        > | struct buf { int x; };
        > | struct buf * (*rcsopen) (struct buf *, struct stat *, int);
        > | static char *e (p, i)
        > |      char **p;
        > |      int i;
        > | {
        > |   return p[i];
        > | }
        > | static char *f (char * (*g) (char **, int), char **p, ...)
        > | {
        > |   char *s;
        > |   va_list v;
        > |   va_start (v,p);
        > |   s = g (p, va_arg (v,int));
        > |   va_end (v);
        > |   return s;
        > | }
        > |
        > | /* OSF 4.0 Compaq cc is some sort of almost-ANSI by default.  It has
        > |    function prototypes and stuff, but not \xHH hex character constants.
        > |    These do not provoke an error unfortunately, instead are silently treated
        > |    as an "x".  The following induces an error, until -std is added to get
        > |    proper ANSI mode.  Curiously \x00 != x always comes out true, for an
        > |    array size at least.  It is necessary to write \x00 == 0 to get something
        > |    that is true only with -std.  */
        > | int osf4_cc_array ['\x00' == 0 ? 1 : -1];
        > |
        > | /* IBM C 6 for AIX is almost-ANSI by default, but it replaces macro parameters
        > |    inside strings and character constants.  */
        > | #define FOO(x) 'x'
        > | int xlc6_cc_array[FOO(a) == 'x' ? 1 : -1];
        > |
        > | int test (int i, double x);
        > | struct s1 {int (*f) (int a);};
        > | struct s2 {int (*f) (double a);};
        > | int pairnames (int, char **, int *(*)(struct buf *, struct stat *, int),
        > |                int, int);
        > |
        > | // Does the compiler advertise C99 conformance?
        > | #if !defined __STDC_VERSION__ || __STDC_VERSION__ < 199901L
        > | # error "Compiler does not advertise C99 conformance"
        > | #endif
        > |
        > | #include <stdbool.h>
        > | extern int puts (const char *);
        > | extern int printf (const char *, ...);
        > | extern int dprintf (int, const char *, ...);
        > | extern void *malloc (size_t);
        > |
        > | // Check varargs macros.  These examples are taken from C99 6.10.3.5.
        > | // dprintf is used instead of fprintf to avoid needing to declare
        > | // FILE and stderr.
        > | #define debug(...) dprintf (2, __VA_ARGS__)
        > | #define showlist(...) puts (#__VA_ARGS__)
        > | #define report(test,...) ((test) ? puts (#test) : printf (__VA_ARGS__))
        > | static void
        > | test_varargs_macros (void)
        > | {
        > |   int x = 1234;
        > |   int y = 5678;
        > |   debug ("Flag");
        > |   debug ("X = %d\n", x);
        > |   showlist (The first, second, and third items.);
        > |   report (x>y, "x is %d but y is %d", x, y);
        > | }
        > |
        > | // Check long long types.
        > | #define BIG64 18446744073709551615ull
        > | #define BIG32 4294967295ul
        > | #define BIG_OK (BIG64 / BIG32 == 4294967297ull && BIG64 % BIG32 == 0)
        > | #if !BIG_OK
        > |   #error "your preprocessor is broken"
        > | #endif
        > | #if BIG_OK
        > | #else
        > |   #error "your preprocessor is broken"
        > | #endif
        > | static long long int bignum = -9223372036854775807LL;
        > | static unsigned long long int ubignum = BIG64;
        > |
        > | struct incomplete_array
        > | {
        > |   int datasize;
        > |   double data[];
        > | };
        > |
        > | struct named_init {
        > |   int number;
        > |   const wchar_t *name;
        > |   double average;
        > | };
        > |
        > | typedef const char *ccp;
        > |
        > | static inline int
        > | test_restrict (ccp restrict text)
        > | {
        > |   // See if C++-style comments work.
        > |   // Iterate through items via the restricted pointer.
        > |   // Also check for declarations in for loops.
        > |   for (unsigned int i = 0; *(text+i) != '\0'; ++i)
        > |     continue;
        > |   return 0;
        > | }
        > |
        > | // Check varargs and va_copy.
        > | static bool
        > | test_varargs (const char *format, ...)
        > | {
        > |   va_list args;
        > |   va_start (args, format);
        > |   va_list args_copy;
        > |   va_copy (args_copy, args);
        > |
        > |   const char *str = "";
        > |   int number = 0;
        > |   float fnumber = 0;
        > |
        > |   while (*format)
        > |     {
        > |       switch (*format++)
        > | 	{
        > | 	case 's': // string
        > | 	  str = va_arg (args_copy, const char *);
        > | 	  break;
        > | 	case 'd': // int
        > | 	  number = va_arg (args_copy, int);
        > | 	  break;
        > | 	case 'f': // float
        > | 	  fnumber = va_arg (args_copy, double);
        > | 	  break;
        > | 	default:
        > | 	  break;
        > | 	}
        > |     }
        > |   va_end (args_copy);
        > |   va_end (args);
        > |
        > |   return *str && number && fnumber;
        > | }
        > |
        > |
        > | // Does the compiler advertise C11 conformance?
        > | #if !defined __STDC_VERSION__ || __STDC_VERSION__ < 201112L
        > | # error "Compiler does not advertise C11 conformance"
        > | #endif
        > |
        > | // Check _Alignas.
        > | char _Alignas (double) aligned_as_double;
        > | char _Alignas (0) no_special_alignment;
        > | extern char aligned_as_int;
        > | char _Alignas (0) _Alignas (int) aligned_as_int;
        > |
        > | // Check _Alignof.
        > | enum
        > | {
        > |   int_alignment = _Alignof (int),
        > |   int_array_alignment = _Alignof (int[100]),
        > |   char_alignment = _Alignof (char)
        > | };
        > | _Static_assert (0 < -_Alignof (int), "_Alignof is signed");
        > |
        > | // Check _Noreturn.
        > | int _Noreturn does_not_return (void) { for (;;) continue; }
        > |
        > | // Check _Static_assert.
        > | struct test_static_assert
        > | {
        > |   int x;
        > |   _Static_assert (sizeof (int) <= sizeof (long int),
        > |                   "_Static_assert does not work in struct");
        > |   long int y;
        > | };
        > |
        > | // Check UTF-8 literals.
        > | #define u8 syntax error!
        > | char const utf8_literal[] = u8"happens to be ASCII" "another string";
        > |
        > | // Check duplicate typedefs.
        > | typedef long *long_ptr;
        > | typedef long int *long_ptr;
        > | typedef long_ptr long_ptr;
        > |
        > | // Anonymous structures and unions -- taken from C11 6.7.2.1 Example 1.
        > | struct anonymous
        > | {
        > |   union {
        > |     struct { int i; int j; };
        > |     struct { int k; long int l; } w;
        > |   };
        > |   int m;
        > | } v1;
        > |
        > |
        > | int
        > | main (int argc, char **argv)
        > | {
        > |   int ok = 0;
        > |
        > | ok |= (argc == 0 || f (e, argv, 0) != argv[0] || f (e, argv, 1) != argv[1]);
        > |
        > |
        > |   // Check bool.
        > |   _Bool success = false;
        > |   success |= (argc != 0);
        > |
        > |   // Check restrict.
        > |   if (test_restrict ("String literal") == 0)
        > |     success = true;
        > |   char *restrict newvar = "Another string";
        > |
        > |   // Check varargs.
        > |   success &= test_varargs ("s, d' f .", "string", 65, 34.234);
        > |   test_varargs_macros ();
        > |
        > |   // Check flexible array members.
        > |   struct incomplete_array *ia =
        > |     malloc (sizeof (struct incomplete_array) + (sizeof (double) * 10));
        > |   ia->datasize = 10;
        > |   for (int i = 0; i < ia->datasize; ++i)
        > |     ia->data[i] = i * 1.234;
        > |
        > |   // Check named initializers.
        > |   struct named_init ni = {
        > |     .number = 34,
        > |     .name = L"Test wide string",
        > |     .average = 543.34343,
        > |   };
        > |
        > |   ni.number = 58;
        > |
        > |   int dynamic_array[ni.number];
        > |   dynamic_array[0] = argv[0][0];
        > |   dynamic_array[ni.number - 1] = 543;
        > |
        > |   // work around unused variable warnings
        > |   ok |= (!success || bignum == 0LL || ubignum == 0uLL || newvar[0] == 'x'
        > | 	 || dynamic_array[ni.number - 1] != 543);
        > |
        > |
        > |   _Static_assert ((offsetof (struct anonymous, i)
        > | 		   == offsetof (struct anonymous, w.k)),
        > | 		  "Anonymous union alignment botch");
        > |   v1.i = 2;
        > |   v1.w.k = 5;
        > |   ok |= v1.i != 5;
        > |
        > |   return ok;
        > | }
        > |
        > configure:8180: /home/builder/lode/opt_private/clang-llvmorg-12.0.1/bin/clang -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/sberg/lo0/core/sanitize-ubsan-excludelist -std=gnu11 -c -g -O2  conftest.c >&5
        > configure:8180: $? = 0
        > configure:8201: result: -std=gnu11
        
        Change-Id: I9122d0d853d0010155d57cb1d1d56f7c453d5208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165904
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-09  RMZeroFour  <ritobroto04@gmail.com>  [e64a1dfc36a18de40af6563f9720a9fb1e42cb1b]

        Fix typo in HelloTextTableShape makefile
        
        The HelloTextTableShape example, which was recently ported to C++,
        has a small typo in line #64 of the Makefile. It gives the user the
        command to run the example, but it was missing an 'e' at the end.
        
        Change-Id: I29af45f21ff78dbda42e5bd9e25e44f06536f7c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165915
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-09  Mike Kaganski  <mike.kaganski@collabora.com>  [2dbd0acb88be751c05648167518dbc60ba75bceb]

        Simplify a bit
        
        Change-Id: I92def0e5731d231583b9b03e351bc46949045b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165846
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [098f366895d2b224ddcd791d10a2e61fbc5fae94]

        tdf#146619 Drop unused 'using namespace' in: scripting/
        
        Change-Id: I84194df451ea990c515ae914741078c80e53e45b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165694
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ff9373bd7271f37fd4cc8c35987a2477c5913b22]

        tdf#146619 Drop unused 'using namespace' in: starmath/
        
        Change-Id: I382ca117484b0928580f4bed765799e915e7b8a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165693
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6f10dc11015ed1640b847e7f0c0be5498b777c5b]

        find-unneeded-includes: improve grepping for namespaces
        
        for example this was not found:
        
        extensions/source/update/check/updatecheck.cxx:58:namespace frame = com::sun::star::frame ;
        
        due to the missing using and the space before the semicolon
        but IWYU correctly detected it as unused
        
        Change-Id: I404c93d41aec1a571c9ac49db7b7c7e8da824bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165698
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a919a0aa4c434c906aa0301d842b1234bf287a9d]

        tdf#146619 Drop unused 'using namespace' in: reportdesign/
        
        Change-Id: Iaf246112014d5b5da751570ca55a179232a1e9d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165692
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [32d3826a36099cbdb8675fe957348d80760f8cba]

        IASS: Missing updates in OutlinerView mode
        
        It looked like in OutlinerMode in IASS when doing
        changes updating the other views were missing. After
        debugging and finding no error I found out that the
        text as COL_AUTO is painted white on white - all
        updates happen but are invisible - argh.
        
        After some more debugging I found that in
        ViewShellBase::GetColorConfigColor only the
        DrawViewShell case was handled, so I added the
        OutlineViewShell now. Since that ViewShell has
        no SdViewOptions I hard-coded the DOCCOLOR
        to COL_WHITE.
        
        That method returns {} aka COL_BLACK as default
        which is a bad default for an office package
        with paper as target, so I also changed that
        to COL_WHITE - which is the default for unknown
        ViewShells now that way. Also adapted the warning
        to mention an 'unknown ViewShell' now.
        
        Change-Id: I580a151b4c0a9eb46d190ba84b0c6d0798dc21d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165907
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6cd0ef58cddf40a0eb2d8cbb017136552f47704e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af2fc2b7c1d2226ce628f60415fd384ffc75a342
          - Fixes in Gallery help page
            
            Change-Id: I319b4a6c3b028bf36c86752a73855e947826b271
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165845
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-09  Michael Stahl  <michael.stahl@allotropia.de>  [2b47fae7e3e23ee7c733708500cb0482ad7f8af1]

        tdf#88214 sw: text formatting: adapt empty line at end of para to Word
        
        For an empty line at the end of an empty paragraph, Writer already uses
        any existing text attribute in the paragraph, see for example
        testEmptyTrailingSpans.
        
        For an empty line at the end of a non-empty paragraph, Writer text
        formatting uses only paragraph attributes, ignoring any text attributes,
        whereas the UI will display the attributes from the text attributes
        (such as font height) if you move the cursor there.
        
        Word uses text attributes also in this case, so adapt the inconsistent
        Writer behaviour: text formatting now uses text attributes too.
        
        Apparently this can be achieved by calling SeekAndChgBefore() instead of
        SeekAndChg().
        
        Add another compat flag "ApplyTextAttrToEmptyLineAtEndOfParagraph" to
        preserve the formatting of existing ODF documents.
        
        Adapt test document fdo74110.docx, it has a line break with "Angsana
        New" font.
        
        Change-Id: I0863d3077e419404194b47110e4ad2bdda3d11c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165887
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b523a72fd0469e47456c9b571ba6ff9da2666fc8]

        Update git submodules
        
        * Update translations from branch 'master'
          to 162f2568c09f9391b8ceb5a123757a9ed75e7898
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I90a33a0294035c5efd3e6b130d340924d4bc9d4f
            
2024-04-09  Tuukka Orava  <tuukka.orava@outlook.com>  [f3d0a184c4da57907a1fcf1ed784340be7d974d6]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: I077e042c82cbefd1d46db5ca8d5983a0870a296c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [83f1a6f8172ab5688bb3e3883e33ed8295d3f5b7]

        find-unneeded-includes: improve list of namespaces
        
        Add 'star' for com::sun::star instances
        
        Add some vcl-specific ones
        
        'PackageKit' gave always a false warning due to the similarity in
        org/freedesktop/PackageKit/*hpp
        and
        officecfg::Office::Common::PackageKit::*
        
        Change-Id: I109e7a2e8d7588d62b2a6bec2e55ec32e993e49e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165697
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4aa43e62e45d418540e352370215c199d97cdfe7]

        tdf#146619 Drop unused 'using namespace' in: xmlsecurity/
        
        Change-Id: I95b84eff5d8bb288aa704620db328d89062efdf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165689
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6e1647699fb7de69b7b14498dbc9b133c24508d4]

        tdf#146619 Drop unused 'using namespace' in: chart2/
        
        Change-Id: I632d0dda0e62e5b1bf0956e731ab5ed6417db1ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165688
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Miklos Vajna  <vmiklos@collabora.com>  [e2b968e6821fe9617a795d95b7e4f53029a33018]

        sw: document SwTextFormatColls
        
        Text is never clear, it means paragraph in this case, since we have
        SwCharFormats for character styles.
        
        Change-Id: Iba21df71053f0b4fbcc0616c024e5cd2972ad44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165902
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-09  Mohit Marathe  <mohitmarathe@proton.me>  [e211607dffe2986601359dcb1ef757fda3805fb3]

        tdf#42982: Improve UNO API error reporting
        
        Change-Id: If075965f2b020767b35692ea110ca768daf342c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165228
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4c1d626d7265b0bfce709e41e62d7c789022ef6d]

        Fix typo: compytibility
        
        Change-Id: I989d0a9510e6a3691a4c1ba89dd3f04e62906292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165691
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9a4eead9958d887d37a5c9bab9465cc6ddd0b213]

        tdf#146619 Drop unused 'using namespace' in: oox/
        
        Change-Id: I4e8aa7443e71a7cb629f762b08d86dd1fa5b7f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165690
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [11e98a5087f39eb8ff6a0b8ce260169f213e7c67]

        ofz#67906 Integer-overflow
        
        Change-Id: I459bdeef6bb7577c5388202374c981c7b01fa137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8527dc74eb1adc9fe4c25134ec853a83d46f1089]

        ofz#67904 Integer-overflow
        
        Change-Id: I27f4126fe0109611f6fdb486ed7f9ee3067ebcb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [3b50600e8f817409f5a21249871d9f82728e4987]

        Use some nicer assert string
        
        Change-Id: I49b5950a63b7c1decb07f3093e8962fc3eada0bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165569
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-09  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [432c866072aa62cf90168d569dc56cbc7269bcda]

        Revert "Fix typo"
        
        This reverts commit 659051b7aa7eb9a142d044693409631cfa319b40.
        
        Reason for revert: "fo" is the "formatting objects" namespace in ODF, not a typo for "for".
        
        Change-Id: If2bef82b9aacb32a125728f548db4d85bee3ed56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165838
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-08  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [8dacc3e636ff85f7f2edb971ff6e269ed031aaaf]

        i18npool : use OUString literal
        
        Change-Id: I202f09303fd385cfcaa468411d0fae8b1707cf88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-08  Noel Grandin  <noelgrandin@gmail.com>  [e7bb3a52067c426eedffddf86e7d5f0903562da2]

        cid#1596254 Null pointer dereferences in GetSotStorageStream
        
        Re-arrange the calling convention to make it obvious that
        a valid stream is the same as a good (true) result.
        
        Change-Id: I974b023a8e7231e70ab649628fdbe43c33001e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165874
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c16f7ca43bb338f23895733ee499505ee6a6e72e]

        Fix indentation
        
        Change-Id: I985562995714c04c569e3a794cf748443ed02865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165886
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  AmandaQuaresmaCoutinho  <quaresmaamanda4@gmail.com>  [ccebd10bc4bea1e65b606a054db3f98ab07850cf]

        tdf#148251 Use std::swap instead of using temporary values
        
        Change-Id: I7629d86b8f85a493bd3ad6b9c465a81c746b1dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165802
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-08  AmandaQuaresmaCoutinho  <quaresmaamanda4@gmail.com>  [bb89fe7ab67c1476b6cf250f236bd5b643a77c6e]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: Ife7a94cdfa8b31ba2a2bcbdf28c9620bbc5348ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165641
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ef802f7dbeee84262b56ab72079cd1c3a40784e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8db831e3f0dce474924168d18e4f8d23fc29f731
          - tdf#160179 Recalculate row height at load times
            
            + refactor
            
            Change-Id: I0a81e254a8c40487d6ca559860c02ec1f4f44912
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165890
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [b4626d809b50f1d5c1aa8a9644dd3913f5b15503]

        tdf#159719 reset SfxPoolItemHolder when Pool changes
        
        Change-Id: Ic2724c6e03acaa8cfc74dc2aadfac6b13d8561c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165883
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [2533960315607bf3e86ad014d2daa4bfa7e3fa59]

        tdf#160064 Hide named ranges/expressions of solver models
        
        Prior to this patch, all named ranges/expressions associated with solver models were visible by default, which clutters the UI with various names in the Manage Names dialog.
        
        Now all such named ranges/expressions are hidden by default, thus mimicking what MSO does.
        
        Change-Id: I79727b375c48527632c4967d174c61f99ff41050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165621
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-08  Regina Henschel  <rb.henschel@t-online.de>  [1e1b1d46155163380252093d9d2868351236ce0e]

        tdf#160369 Do not broadcast temporarily group change
        
        The position and size of a group needs to be temporarily changed when
        saving because ODF does not treat hidden rows/cols as zero, but LO does.
        After saving, these changes have to be undone. The error was that the
        restore was performed with GetGeoDate/SetGeoData. But SetGeoData
        includes a broadcast that triggeres recalculations that should not be
        performed here. Now the change and restore are both done with NbcMove
        and NbcResize.
        
        The import had set a 'logical rectangle', but that is nonsense for a
        group, because a group does not have a 'logical rectangle'.
        For a group, none of the special corrections in
        ScDrawLayer::InitializeCellAnchoredObj are needed.
        
        Change-Id: I00adf39e83011112492822d2900e41242d188e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165872
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-04-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c7362f365b7d4699740729e6bf263e1217577797]

        tdf#146619 Drop unused 'using namespace' in: filter/
        
        Change-Id: Id7801c4690b9f095f7f246e8b3a2072c24e6e58c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165544
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6b4552e325b38748cb75d3df269082fb8a38751a]

        tdf#146619 Drop unused 'using namespace' in: editeng/
        
        Change-Id: Ifbad3b15b462a0586eda219f16698d0b42109832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165535
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7f2af61f1a4771f6f823c378f355ee4989a719e4]

        tdf#146619 Drop unused 'using namespace' in: extensions/
        
        Change-Id: I3581cc8eb2414161ecb81a4ebcedd7b3b391c642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165571
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db609a58df7be082de7d5a20a2a924789d6a64a1]

        Resolves: tdf#154715 don't use last-used field setting when editing field
        
        If we are inserting a field it makes sense to use the last-used
        settings, but if we are editing an existing field we naturally want to
        populate with the current field.
        
        Here we have IsRefresh used twice as a condition, one inside the other.
        But if was true in the outer use, it will also be true in the inner
        (this duplication exists all the way back to the initial commit) because
        GetUserData() has no side effect.
        
        IsRefresh is only true during EditNewField (which is the case of using
        the "next/back" button to go to edit another field). So even before this
        change if you click next and then back (assuming there is another field
        to move to) then you then get the right results
        
        Skip restoring the last-used settings in the EditField case, replace
        the outer !IsRefresh() with !IsFieldEdit()
        
        Change-Id: I4224302171d2e8d02a0f1e0efc9fdada5ada9d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165876
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ba8f4c55a65d0f525f3e65402cdca961efbe1ba]

        Failed to set property GtkEntry.valign to top: Could not parse enum: 'top'
        
        Change-Id: I2d73204bda451bb87b64652b4dd934fc16e3b65d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165875
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [74b48a8f6e6c861ee791107c9cacd7a9f6b84904]

        Embind: Clarify poor UNO exception support
        
        As UNO exceptions are not derived from std::exception in C++, the corresponding
        JS object's name property is present but has undefined value.  And the UNO
        Message property is not present at all.
        
        Change-Id: Ibe152377e5970faa8a518c77b5171d9f3c160f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fd7caefaacd91a16fce10b4e4fbfe6ef4f5ffce9]

        -Werror,-Wunused-but-set-variable
        
        Change-Id: I4e4d3c810e9d37fd4b87d3307c2ba906923aa63b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Rene Engelhard  <rene@rene-engelhard.de>  [479a39cbf0f4564abe93066d7a3f6b2e82de0e76]

        clean up after removal of patched rhino
        
        Change-Id: I193fd0c10d297555faa7a832718dbd6cd929a406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165762
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [95fab3f7dc1d7b802dce94d934b8ec95def92bf2]

        tdf#146619 Drop unused 'using namespace' in: basctl/
        
        Change-Id: I7df9fa0e7de3cf7ee39ce96bf9ff32c54db14763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165687
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-08  RMZeroFour  <ritobroto04@gmail.com>  [afb18ac0628c54fdffc1ee5b55db6110c20872cd]

        tdf#50998 tdf#87892 Add sinusoid shape
        
        In response to #50998 (as well as #87892 indirectly),
        regarding adding sinusoidal and coil-like shapes to the
        shape gallery in LibreOffice, this commit adds a sinusoid
        shape to the gallery.
        
        The shape is still incomplete for release, at least lacking
        icons for the sidebar. Further details posted on the Bugzilla
        thread for issue #50998.
        
        PS-2: Removed the previously added flag shape.
        PS-4: Moved sinusoid to the end in a new subgroup.
        
        Change-Id: Ie0f6e3948b6dce98dc2b4f87289cfd37f2d16911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165353
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f1697d2b1e6b3ac63946070cc720234dc68efbe9]

        -Werror,-Wunused-but-set-variable
        
        ...ever since the code got introduced in
        4f5b3e4bd53d6d61df1f65f496f7bc8dc525c8a1 "In O[U]StringBuffer, make string_view
        params replacements for OUString ones"
        
        Change-Id: If2032db027f45c60f7c92b796a0a10d23f26b6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165881
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a57ade9be3aa03634933e767eab5e8fb640760ca]

        -Werror,-Wunused-but-set-variable
        
        ...ever since the code got introduced in
        9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749 "sw: fix expansion of SetGetExpField in
        headers with split table rows"
        
        Change-Id: I44e8d375a47286b625ce9a7808484a32dc1f0aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165879
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6202211a09175e914298f93be8ee17260d8a5bf3]

        -Werror,-Wunused-but-set-variable
        
        ...ever since the code got introduced in
        77d083f2cbe496274cdab38a3a34497d1b742d86 "New loplugin:getstr"
        
        Change-Id: I3e0c7793c6e19e44d7450156aeb3cead3511faf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165880
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-08  Miklos Vajna  <vmiklos@collabora.com>  [607fcac441c7f3a7d3c169c19039e581d707f2bb]

        tdf#160067 sw floattable: fix missing move bwd of paras in split section frame
        
        The last (5th) paragraph in the index was on page 2, even if page 1
        still had space for it.
        
        This is a regression from commit
        397d72e582c725d162c7e0b819dc6c0bb62e42b0 (Related: tdf#158986 sw
        floattable: fix unexpected page break with sections, 2024-02-23), in
        case SwLayAction::FormatLayout() doesn't calc its lower content frames
        then this bugdoc is good, but the old bugdoc moves its floating table to
        the next page, which would be bad.
        
        Fix the problem by making the condition for this "calc lower in
        FormatLayout()" action more strict: only do this for content frames
        which are in sections, followed by sections.
        
        Note that probably a cleaner way would be to completely stop calculating
        content frames in SwLayAction::FormatLayout() and only do that in
        FormatContent(), but then it's not clear how to re-fix tdf#158986, and
        at least this resolves the regression.
        
        Change-Id: Id671b3b68d8af8ad1cca3399a9aa028de58df3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165878
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8557ea84c9336ba8061246f1f46ddb6e02f413a1]

        Exclude getHScale from DirectWrite font rendering
        
        ... and drop it, since it's unused now.
        Unkike with Skia, where the ratio produces a visible effect, in
        DirectWrite the effect seems cancelled by transformations. Yet,
        it produced computational instability, noticable in small vertical
        text.
        
        Change-Id: I2f3b20913075d1338dc75c5a04c9cc0ef29c75ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165877
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-07  Jim Raykowski  <raykowj@gmail.com>  [748561425774fa40ab685fed80d113f7e8301158]

        SdNavigator: speed up notifications to update the Navigator state
        
        Change-Id: I191cd83ffce3f1ded9c67abcdf319034972a0b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165151
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ae9e8f3f6d10b0be2fe5b9b238a531b17e0d67da]

        tdf#160526, tdf#160549: fix split conditions at page start
        
        A single large object in a paragraph must be moved down, when the page
        has other content before this. On the other hand, there must not be
        moving down, when an unsuccessful attempt to move was already done (so
        the master frame is empty), or even the first time, when the frame is
        at the page body start.
        
        Change-Id: Ib8e2fe7b77c622d9cfac22722ca6b55dba7ad8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165869
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ea3b972f0b590ec069dc56d4d6ac9a6e47cb89a4]

        Improve test for tdf#135581
        
        I broke it during a work on a related problem, and that wasn't caught
        by existing tests - I only accidentally noticed that.
        
        Change-Id: I311da4f5bb1d26bf732d90e7fe79f337a56805a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165868
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-07  Mike Kaganski  <mike.kaganski@collabora.com>  [65b3808a24db4d8b549eb1643d009330f63abf65]

        i#84870: Add a unit test
        
        I broke it during a work on a related problem, and that wasn't caught
        by existing tests - I only accidentally noticed that.
        
        Change-Id: I2e60970b09f8aaa52d2db8123996e349e53a46b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165867
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f65d7265c63778ebf630b9d909617d064dce529e]

        Upgrade external/boost to latest Boost 1.84.0
        
        <https://dev-www.libreoffice.org/src/boost_1_84_0.tar.xz> has been generated (on
        Fedora 39) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.84.0/source/boost_1_84_0.tar.bz2
        > $ printf 'cc4b893acf645c9d4b698e9a0f08ca8846aa5d6c68275c14c3e7949c24109454 boost_1_84_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_84_0.html>
        > boost_1_84_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_84_0.tar.bz2
        > Unpacking boost_1_84_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_84_0.tar.xz ...
        > Cleaning up ...
        > fd4a2ee785ea0e4efc5221a4284e0cf51096e8409871fb70fdaced002eeffc0b  boost_1_84_0.tar.xz
        > Done.
        
        * external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
          was obsoleted by
          <https://github.com/boostorg/phoenix/commit/665047aac26ad4d96b266d87504b3a88ad21b37e>
          "avoid ODR by making this const".
        
        * The modified external/boost/windows-no-utf8-locales.patch.0, whose original
          version no longer applied as-is, should hopefully still mitigate the issue
          described in 072a25e1ef4815bbef4f18f59f025862a0d8e876 "tdf#157135 workaround:
          restore and update windows-no-utf8-locales.patch.0".
        
        * external/boost/Wundef.patch.0 is needed to silence
        
        > In file included from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/throw_exception.hpp:24,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/serialize_tracked_address.hpp:16,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/fca.hpp:117,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/implementation.hpp:17,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/map.hpp:7,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/unordered_map.hpp:17,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered_map.hpp:17,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/external/boost/include/boost/unordered_map.hpp:30,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/configmgr/source/modifications.hxx:28,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/configmgr/source/data.hxx:34,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/configmgr/source/groupnode.cxx:26:
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/type_traits.hpp:51:22: error: "BOOST_LIBSTDCXX_VERSION_WORKAROUND_GUARD" is not defined, evaluates to 0 [-Werror=undef]
        >    51 | #if BOOST_WORKAROUND(BOOST_LIBSTDCXX_VERSION, < 50000)
        >       |                      ^~~~~~~~~~~~~~~~~~~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/config/workaround.hpp:272:10: note: in definition of macro ‘BOOST_WORKAROUND’
        >   272 |        ((symbol ## _WORKAROUND_GUARD + 0 == 0) &&     \
        >       |          ^~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/type_traits.hpp:64:22: error: "BOOST_LIBSTDCXX_VERSION_WORKAROUND_GUARD" is not defined, evaluates to 0 [-Werror=undef]
        >    64 | #if BOOST_WORKAROUND(BOOST_LIBSTDCXX_VERSION, < 50000)
        >       |                      ^~~~~~~~~~~~~~~~~~~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/config/workaround.hpp:272:10: note: in definition of macro ‘BOOST_WORKAROUND’
        >   272 |        ((symbol ## _WORKAROUND_GUARD + 0 == 0) &&     \
        >       |          ^~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/unordered/detail/type_traits.hpp:77:22: error: "BOOST_LIBSTDCXX_VERSION_WORKAROUND_GUARD" is not defined, evaluates to 0 [-Werror=undef]
        >    77 | #if BOOST_WORKAROUND(BOOST_LIBSTDCXX_VERSION, < 50000)
        >       |                      ^~~~~~~~~~~~~~~~~~~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/boost/boost/config/workaround.hpp:272:10: note: in definition of macro ‘BOOST_WORKAROUND’
        >   272 |        ((symbol ## _WORKAROUND_GUARD + 0 == 0) &&     \
        >       |          ^~~~~~
        
          etc. (<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/155922/>) as
          seen with some versions of GCC which apparently fail to honor in that
          situation the
        
        > #pragma GCC diagnostic ignored "-Wundef"
        
          in the external/boost/include wrappers.  (Using
        
        > #pragma GCC system_header
        
          in those external/boost/include wrappers had been dismissed with
          29661a886e4157e0cb6141b49fb5602fa621cc9a "boost: stop using #pragma GCC
          system_header".)
        
        Change-Id: Idf1d5a17bc198b8ea7a54751e8e2fa6ca2169167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161138
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6d8778bfaa7f0914641d1dc53b2883fff10af1a]

        cid#1596251 Dereference null return value
        
        and
        
        cid#1596249 Dereference null return value
        
        Change-Id: I2d50e8be5ec20001527c20ccd46a9a0336792d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b5f5bc90d0eb736c413070a7622d7bde4a161c89]

        cid#1596238 clarify Explicit null dereferenced
        
        hopefully make coverity see this warning is bogus
        
        Change-Id: I1bf5fb9183058b18f10c5ebe34c6a887a957f578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-07  Mike Kaganski  <mike.kaganski@collabora.com>  [fead9c3ea98eb5e6bc01b1dde2a8ab2fa755209d]

        Drop a redundant check
        
        Change-Id: Ie88dbf29bd03b890a75fb4a1059083bbd939f56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165837
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73daaa27770ff23ec9dbe574891ebc70af7a27bb]

        ofz#67491 avoid direct nss use to support --enable-tls-openssh
        
        Change-Id: I337fa47faecbd5059fa02a7d24b70dd9c2da0fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-07  Aron Budea  <aron.budea@collabora.com>  [1a856fcede54b37701089849a838b6d52bb04b8c]

        tdf#160342 Unwanted space before end of line when printing
        
        Also adjust some numeric literals to reflect they're
        floating point values in the expressions.
        
        Regression from 172b500ccbc8dac0496cc2936a9bcca793c0b594.
        
        Change-Id: I8281ba7c7d480135471ba94b11d447d76fd33063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165860
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ebdcc60701ca5f2d267f92fa69ac06202309c52]

        Resolves: tdf#160562 change white background of icon to transparent
        
        so when gtk makes it insensitive it doesn't look overly gray in
        comparison to its neighbour icons.
        
        Change-Id: I08f8e4cca561c3336a4b9d61373694b37cd7f9a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165857
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d634da0adca1191da5c4c54ae17be7185b6bba36]

        flatten for readability
        
        no logic change intended
        
        Change-Id: I27b17634c86bb99d018e2c5991bbc909319e3b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165856
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [acc7f7d895f37e573963c3dd6c488346f8da6fbf]

        ofz#67867 Null-dereference READ
        
        Change-Id: Ia4d9097d05c250fffe938b283a3ca623f60b4b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165855
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a7e883f6fc8665f9d0fb522e1c2be41734ff8542]

        use "ok" id like the other 446 dialogs instead of "okay"
        
        and similar standardizations of stock labels and allow
        mnemonics
        
        Change-Id: I75c06f5a8ab961cf3b5427c33c801ae0f5ea5a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Gökay Şatır  <gokaysatir@gmail.com>  [1a6457e4b4d6fbea92fae1fe1b5c27a566dc54c0]

        Enable allowing comment editing in readOnly view mode.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I536448da395568cd43af6f4d1d36ef09f3c6a6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165349
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 226e2263468da403d1f9db504115830f5a030229)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165834
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Gökay Şatır  <gokaysatir@gmail.com>  [3d83f91b9ba249fcfa93fc24a1b427840b7b2c61]

        Disable dragging in readonly view mode.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I962d68b85897c156bba6d1898cf78b5fcd85540a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164866
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 0cdafeb746196f9f1e9ad271a77f5911694ff07d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Gabriel Masei  <gabriel.masei@1and1.ro>  [2feda8ba21acdcf33a9b4ba94742f574c17839bd]

        tdf#152336 Detect charset and separators for csv files
        
        Change-Id: Ie8451b3d30e390d363d8f9e5ec8bdf47350ca3a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164936
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-04-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [2564374efebb5218fbc3c81540fe95557f6119ac]

        Add dialog name to dataproviderdlg.ui
        
        ...and change "Okay" to "OK" in the dialog.
        
        Change-Id: I7d64758b83f28edc3dadedaed883c8109eb3a9bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165786
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [659051b7aa7eb9a142d044693409631cfa319b40]

        Fix typo
        
        Change-Id: I92c1b5f2ff3ba1e39b204a5b23f9bbc71e2b05f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165742
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-06  Mike Kaganski  <mike.kaganski@collabora.com>  [07f287c58ca4bae4bdc641cc9139f9aaaff24374]

        Simplify a bit
        
        Change-Id: I4bfe875d0484bf77472301f9dea3fc4c6dacdbf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165852
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [38ed8100872913c64941927bba665e4bd1a44c12]

        Fix typo
        
        Change-Id: I0f6a4ac0910c83d572e2b2e39e8dcea0470517cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165818
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-06  Jim Raykowski  <raykowj@gmail.com>  [f41ef630f7fc706d18cce76c3abe76a53f03b2d5]

        SdNavigator: Make the objects tree update after rename
        
        Change-Id: Ibec7df5dcf5cf817b1c3574e3f3acd8206c72e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165668
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-06  Heikki Ilvesmäki  <heikki.ilvesmaki@gmail.com>  [2c724d88fef38a390744bbe1a4add031c6c62843]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I87f971d5c5e61127025e66947f181d6012e20ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165825
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [86842d70e983913002ca0faf35c7288983007a12]

        Silence strange -Wmaybe-uninitialized with recent GCC 14
        
        ...seen at least with some (--enable-dbgutil --enable-otpimized etc.)
        configuration and a recent GCC 14 trunk,
        
        > In file included from ~/gcc/inst/include/c++/14.0.1/map:62,
        >                  from xmloff/inc/txtflde.hxx:32,
        >                  from xmloff/source/text/txtflde.cxx:26:
        > In member function ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_mbegin() const [with _Key = com::sun::star::uno::Reference<com::sun::star::text::XText>; _Val = std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >; _KeyOfValue = std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >; _Compare = std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >; _Alloc = std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >]’,
        >     inlined from ‘std::_Rb_tree_node<_Val>* std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::_M_begin() [with _Key = com::sun::star::uno::Reference<com::sun::star::text::XText>; _Val = std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >; _KeyOfValue = std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >; _Compare = std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >; _Alloc = std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_tree.h:737:25,
        >     inlined from ‘std::_Rb_tree<_Key, _Val, _KeyOfValue, _Compare, _Alloc>::~_Rb_tree() [with _Key = com::sun::star::uno::Reference<com::sun::star::text::XText>; _Val = std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >; _KeyOfValue = std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >; _Compare = std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >; _Alloc = std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_tree.h:982:17,
        >     inlined from ‘std::__cxx1998::map<_Key, _Tp, _Compare, _Alloc>::~map() [with _Key = com::sun::star::uno::Reference<com::sun::star::text::XText>; _Tp = std::__debug::set<rtl::OUString>; _Compare = std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >; _Alloc = std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >]’ at ~/gcc/inst/include/c++/14.0.1/bits/stl_map.h:314:7,
        >     inlined from ‘std::__debug::map<_Key, _Tp, _Cmp, _Allocator>::~map() [with _Key = com::sun::star::uno::Reference<com::sun::star::text::XText>; _Tp = std::__debug::set<rtl::OUString>; _Compare = std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >; _Allocator = std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >]’ at ~/gcc/inst/include/c++/14.0.1/debug/map.h:136:7,
        >     inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_destroy() [with _Tp = std::__debug::map<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >]’ at ~/gcc/inst/include/c++/14.0.1/optional:283:35,
        >     inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_reset() [with _Tp = std::__debug::map<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >]’ at ~/gcc/inst/include/c++/14.0.1/optional:314:14,
        >     inlined from ‘constexpr void std::_Optional_base_impl<_Tp, _Dp>::_M_reset() [with _Tp = std::__debug::map<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >; _Dp = std::_Optional_base<std::__debug::map<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >, false, false>]’ at ~/gcc/inst/include/c++/14.0.1/optional:466:53,
        >     inlined from ‘constexpr std::enable_if_t<((bool)is_constructible_v<_Tp, _Args ...>), _Tp&> std::optional<_Tp>::emplace(_Args&& ...) [with _Args = {}; _Tp = std::__debug::map<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >]’ at ~/gcc/inst/include/c++/14.0.1/optional:915:18,
        >     inlined from ‘void XMLTextFieldExport::SetExportOnlyUsedFieldDeclarations(bool)’ at xmloff/source/text/txtflde.cxx:2250:30:
        > ~/gcc/inst/include/c++/14.0.1/bits/stl_tree.h:733:73: error: ‘*(const std::_Rb_tree<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString, std::less<rtl::OUString>, std::allocator<rtl::OUString> > >, std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString, std::less<rtl::OUString>, std::allocator<rtl::OUString> > > >, std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >, std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString, std::less<rtl::OUString>, std::allocator<rtl::OUString> > > > >*)((char*)this + 32).std::_Rb_tree<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >, std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >, std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >, std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > > >::_M_impl.std::_Rb_tree<com::sun::star::uno::Reference<com::sun::star::text::XText>, std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> >, std::_Select1st<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > >, std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >, std::allocator<std::pair<const com::sun::star::uno::Reference<com::sun::star::text::XText>, std::__debug::set<rtl::OUString> > > >::_Rb_tree_impl<std::less<com::sun::star::uno::Reference<com::sun::star::text::XText> >, true>::std::_Rb_tree_header.std::_Rb_tree_header::_M_header.std::_Rb_tree_node_base::_M_parent’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   733 |       { return static_cast<_Link_type>(this->_M_impl._M_header._M_parent); }
        >       |                                                                         ^
        
        Change-Id: I827e5a1de31006fbedd7857fd21fc5a9cb652172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165822
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-05  Jim Raykowski  <raykowj@gmail.com>  [a076bbc5261885d49c592acd46b238bd659ccb41]

        SdNavigator: Make the sidebar panel not visible in outline and
        
        slide sorter view modes
        
        Inspired by the floating version behavior of not showing when in
        the outline or slide sorter view mode.
        
        Change-Id: I19ecb5751af7798527cf6b08ca766c367f177336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165150
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [745ba22017fde53b50f38a1db5c3eaa388003871]

        Silence strange -Wmaybe-uninitialized with recent GCC 14
        
        ...seen at least with some (--enable-dbgutil --enable-otpimized etc.)
        configuration and a recent GCC 14 trunk,
        
        > In file included from ~/gcc/inst/include/c++/14.0.1/vector:66,
        >                  from include/unotools/options.hxx:26,
        >                  from include/unotools/lingucfg.hxx:27,
        >                  from linguistic/source/lngsvcmgr.cxx:35:
        > In destructor ‘constexpr std::__cxx1998::vector< <template-parameter-1-1>, <template-parameter-1-2> >::~vector() [with _Tp = SvcInfo; _Alloc = std::allocator<SvcInfo>]’,
        >     inlined from ‘constexpr std::__debug::vector<_Tp, _Allocator>::~vector() [with _Tp = SvcInfo; _Allocator = std::allocator<SvcInfo>]’ at ~/gcc/inst/include/c++/14.0.1/debug/vector:245:7,
        >     inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_destroy() [with _Tp = std::__debug::vector<SvcInfo>]’ at ~/gcc/inst/include/c++/14.0.1/optional:283:35,
        >     inlined from ‘constexpr void std::_Optional_payload_base<_Tp>::_M_reset() [with _Tp = std::__debug::vector<SvcInfo>]’ at ~/gcc/inst/include/c++/14.0.1/optional:314:14,
        >     inlined from ‘constexpr std::_Optional_payload<_Tp, false, _Copy, _Move>::~_Optional_payload() [with _Tp = std::__debug::vector<SvcInfo>; bool _Copy = false; bool _Move = false]’ at ~/gcc/inst/include/c++/14.0.1/optional:437:65,
        >     inlined from ‘constexpr std::_Optional_base<std::__debug::vector<SvcInfo>, false, false>::~_Optional_base()’ at ~/gcc/inst/include/c++/14.0.1/optional:508:12,
        >     inlined from ‘constexpr std::optional<std::__debug::vector<SvcInfo> >::~optional()’ at ~/gcc/inst/include/c++/14.0.1/optional:703:11,
        >     inlined from ‘LngSvcMgr::~LngSvcMgr()’ at linguistic/source/lngsvcmgr.cxx:519:1:
        > ~/gcc/inst/include/c++/14.0.1/bits/stl_vector.h:735:22: error: ‘((std::__cxx1998::vector<SvcInfo, std::allocator<SvcInfo> >*)((char*)this + 16))[22].std::__cxx1998::vector<SvcInfo, std::allocator<SvcInfo> >::std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_M_impl.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl::std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl_data.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl_data::_M_finish’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   735 |         std::_Destroy(this->_M_impl._M_start, this->_M_impl._M_finish,
        >       |         ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   736 |                       _M_get_Tp_allocator());
        >       |                       ~~~~~~~~~~~~~~~~~~~~~~
        > ~/gcc/inst/include/c++/14.0.1/bits/stl_vector.h:735:22: error: ‘((std::__cxx1998::vector<SvcInfo, std::allocator<SvcInfo> >*)((char*)this + 16))[22].std::__cxx1998::vector<SvcInfo, std::allocator<SvcInfo> >::std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_M_impl.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl::std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl_data.std::__cxx1998::_Vector_base<SvcInfo, std::allocator<SvcInfo> >::_Vector_impl_data::_M_start’ may be used uninitialized [-Werror=maybe-uninitialized]
        
        Change-Id: I02815c39ee6026b4637a4bb6ad2804af7a446a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2bcd9fe0fa10339294e6ab820498fa18334e02f3]

        Silence strange -Wclobbered with recent GCC 14
        
        ...seen at least with some (--enable-dbgutil --enable-otpimized etc.)
        configuration and a recent GCC 14 trunk,
        
        > vcl/source/filter/png/PngImageReader.cxx: In function ‘bool {anonymous}::reader(SvStream&, Graphic&, GraphicFilterImportFlags, BitmapScopedWriteAccess*, BitmapScopedWriteAccess*)’:
        > vcl/source/filter/png/PngImageReader.cxx:361:16: error: variable ‘bSupportsBitmap32’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
        >   361 |     const bool bSupportsBitmap32 = bFuzzing || ImplGetSVData()->mpDefInst->supportsBitmap32();
        >       |                ^~~~~~~~~~~~~~~~~
        
        Change-Id: Icc1932347a213877ecc9f561f98de779f8041c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165823
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-05  Printf Debugging  <printfdebugging@gmail.com>  [3ca12a07335e1e9ae6b64491faaab6a46e9c4db5]

        tdf#143148 use pragma once instead of include guards in sc
        
        Change-Id: I10af777dca97e4ba39e0a0d0decdc9a3de12bb19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165819
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-05  Jim Raykowski  <raykowj@gmail.com>  [186c4cd328830c9b3a1769ea7c6a0738e019dae7]

        SdNavigator: fix lcl_select_marked_object page selection
        
        ...which makes invalidation of SID_NAVIGATOR_PAGENAME in InitTreeLB
        unnecessary.
        
        Also rename lcl_select_marked_object lcl_select_marked_objects.
        
        Change-Id: I6afe0cc59808a476dcb1496e23dbb1b54ec570e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165780
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [be938f2fb1c0a18658b4170396a22c64b77bf646]

        Related tdf#126573 Add Excel2021 array function SORT to Calc
        
        In case of cell formulas which have a string result, we need to
        get the value from the formula result, for sorting/comparing.
        
        folow up of commit: 45435a680be065e44eba385bb2523b27b77fb451
        
        Change-Id: I30502dfb013ef78de0e5f2f9d5151cfc60e46942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165816
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8379aaee531e469687aaceba27f5afd697a0d86d]

        ofz#67765 Integer-overflow
        
        Change-Id: I49b1a5024352575a3867500c15f542863c273e93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165814
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [79d1c80892b36d2c155aa6112de8b1a7b1e07ae8]

        ofz#67854 UNKNOWN READ
        
        Change-Id: I37d2bc6153a8bf616d19105645f91b8519890e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165813
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e74a8371f0ed92d11b652452d7ae85675d722279]

        ofz#67782 Integer-overflow
        
        Change-Id: I039478c339e297f9fcb48a98099bc587b6b4aa32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165815
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-05  RMZeroFour  <ritobroto04@gmail.com>  [45d951492a34d8d4134a518662377fa4c1e08395]

        tdf#147906 Use std::hypot for Pythagorean distance
        
        As part of the efforts in tdf#147906 to replace expressions like
        sqrt(a^2 + b^2) with std::hypot(a, b), to eliminate overflow
        errors, this commit performs the changes in certain files.
        
        This also changes the B3DVector::normalize and B2DVector::normalize
        methods to have similar behaviour.
        
        Change-Id: I142585cfa594849f06cd06517ad9d40430df2ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165555
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-04-05  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [aa11db227da2830accac7c523c534b2b86a86bb2]

        tdf#146619 Drop unused 'using namespace' in: cui/
        
        Change-Id: I311423b045a504b268cffdf740db1fe82aea2810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165568
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-05  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ad640dedd269dc1e03cf362e11975bbd6d963120]

        tdf#146619 Drop unused 'using namespace' in: forms
        
        Change-Id: I5d81e8c359100da2a7dd98e75a1f79bbb73d9521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165570
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-05  Aaron Bourdeaux  <abourdeaux@csumb.edu>  [ee9a21da6aa0872855f78a4464d6952e11a9aa54]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I61bcc0054c71273945d3004839be92a25a26d261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165563
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-04-05  Antony  <antonydas.nadar@collabora.com>  [2f15866d8502c74513e19f7a6e3074c97f162725]

        a11y: Enable accessibility for comboboxes in sidebar
        
        * Updated window.cxx:Window::DumpAsPropertyTree to include accessibility data in the output
        * Added accessibility info to comboboxes inside sidebarstylespanel.ui & sidebartextpanel.ui
        
        * Reverted unwanted ui version change introduced due to glade
        
        Change-Id: If6833c9f42dbab90fb6277ed932062d86cf53416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165782
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit ca31493ad56647cf5d11dccaf70fa225327fab51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165725
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae587c8f2892314da6c97a2e85b97845ede9b0e6]

        cid#1596116 Uninitialized scalar field
        
        Change-Id: I6a4803ae079786880b5a8ff040f1215657604476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165810
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [daa6df4633d67af025ea1000aaac20763da1a683]

        Revert "convert OCellValueBinding to comphelper::WeakComponentImplHelper"
        
        This reverts commit 7510cca63690ea97eb02a43f698fc183c3d0434a.
        
        Reason for revert: deadlocking
        
        Change-Id: Id50926e401871be259fa955b68b1767fd7f6b9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-05  Michael Stahl  <michael.stahl@allotropia.de>  [759d822dac5edc6104ce61b70c578425d9f2470d]

        sw: layout: remove superfluous pages again in InternalAction()
        
        The bugdoc has a very large header containing hidden text changes height
        when toggling Formatting Marks.  When toggling on, it crashes, because
        UnHide() iterates the text frames in all headers, but after the first
        one empty pages at the end of the document are removed, so UAF.
        
        Remove the pages without content earlier; SwLayAction::InternalAction()
        already does it after the "normal" page loop, but the 2nd page loop
        following that may also move content off pages, so do it again.
        
        Change-Id: Iaae6a16842b3494f25cba8fc036d15049b71961f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165801
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-04-05  Miklos Vajna  <vmiklos@collabora.com>  [2b55a58a2b6918018eca11f8f8cd0452992f239a]

        sw doc model xml dump: show SwTableLine::m_aBoxes
        
        Which means we get boxes (cells) grouped by lines (rows), instead of a
        flat list of all cells in a table.
        
        Change-Id: Ibb14c6fb26b2f4b502b18544d9a08d964c45a97e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165806
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [438f0742320a5999e5ca785d152fd14a279799e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c741dd9f01c329e58fe6c5ae6cfcf7570c5a8c7
          - Mute l10n in page title
            
            Change-Id: Id715ea5bd4b17ac866e8c5638e0f725b9aaa6b96
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165803
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-04-04  Moritz Duge  <moritz.duge@allotropia.de>  [30c6e51fc9cb0fa864e1755271343d847fcced25]

        Remove duplicate code.
        
        Change-Id: Ia32b0525ecdf5944c2ebd3045dc3d536941ed394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165763
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Moritz Duge  <moritz.duge@allotropia.de>  [430704311a1380b569f89c7b9e3cde35ac55b672]

        Improved documentation (Emscripten, Qt5 usage, WASM examples)
        
        Sentence about Emscripten was probably obsolete since around commit 12a6b57c
        
        Change-Id: Ide59154439f8a069c2dbd58420c1c93844790a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165754
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f7866596d1c44f092f6c8f896b770e2882b0fe81]

        Remove duplicated include
        
        Change-Id: I802dc451e12ad42f89dff553128f1324e161af28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165757
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-04-04  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [2f093d16be4c87d0535d0c6338c308ad9f6a3c84]

        IASS: make live slideshow non-experimental
        
        Change-Id: I36fb6eae8f77f02fa1a9bcf96a7c074d78ba86c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165804
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  László Németh  <nemeth@numbertext.org>  [c8ee0e8f581b8a6e41b1a6b8aa4d40b442c1d463]

        tdf160518 DOCX: import hyphenation-keep to fix layout
        
        To fix layout interoperability, import DOCX compatSettings
        allowHyphenationAtTrackBottom and useWord2013TrackBottomHyphenation
        as hyphenation-keep setting "COLUMN", shifting last hyphenated
        lines of pages and columns, like MSO does.
        
        Follow-up to commit 9574a62add8e4901405e12117e75c86c2d2c2f21
        "tdf#132599 cui offapi sw xmloff: implement hyphenate-keep".
        
        Change-Id: Ib2a06efc22a4f30d8f8be8a752460b09d09e97a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165798
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-04-04  khushishikhu  <dpskhu13108@gmail.com>  [9338f87a6644e9b2309c3a009af096e38fbb107e]

        tdf#95405 Sidebar: Quick Find for writer
        
        Implemented the quick find deck on the sidebar of Writer with a corresponding panel in it.
        
        Change-Id: Ic4ce6823e11b27b3386e820a657bc5d973e47007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160500
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e31403bc8d63f938bebef663fc90bf86b3321ad]

        loplugin:unusedenumconstants
        
        Change-Id: I889b4f63e098fecf22ffd4fb98937d62dbdd70b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f97b1f75bbd7f8a20163716b57c84fc1140e48fa]

        RESTART_REASON_MSCOMPATIBLE_FORMS_MENU is dead
        
        removed with
            commit 1d4cd39262fb71f72311e33ac2bdb7d925be5d98
            Author: Heiko Tietze <tietze.heiko@gmail.com>
            Date:   Thu Sep 14 10:48:46 2023 +0200
            Related tdf#157006 - Remove global compatibility options
        
        Change-Id: If24282d2ec7c8d8c6631982b9fe866e3a7df3d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165790
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d8056d884ee3ab7b4454c378618dceb6f5a7ae8]

        loplugin:unusedmethods
        
        Change-Id: I19f466a272c821185bea4b45efd34392e525c0d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165785
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Oliver Specht  <oliver.specht@cib.de>  [ad4b72a0eacf6bb6887236ea3a3807b1264de822]

        tdf#160301 import DOCVARIABLE fields as user fields
        
        DOCVARIBLE fields in *.doc files are imported as user fields.
        
        Change-Id: Ib723d8a586ca644e0b158f839caef33b2b6225a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165096
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [64909a84a354a8bee24fc4439a4b3fdeff67cad6]

        Missing include, again
        
        At least the Emscripten build was hit again by what had been fixed with
        bddb0d87e809c96ee810de0e553f02bbe158907d "Missing include", after
        a0c53ab43840d1c84d7d246b2cbc73c3a8862155 "tdf#146619 Remove unused #includes
        from C/C++ files".
        
        Change-Id: I632ab297bc51aa07019e4bb0cb4ef8f6372a1374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165795
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [164cb6ac273d34567f19b4e8a0df94efa053703c]

        Drop spurious .delete() calls from example code
        
        ...that had been added there accidentally in
        27ceca1996809c0f9390d1e9fb95dc7436ef1acf "Rework the Embind mapping of UNO
        interfaces"
        
        Change-Id: I390e4b694e95d665f7bc3d62b0f7ba2c887041bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165796
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-04  Oliver Specht  <oliver.specht@cib.de>  [ec5898cb245c68cf116a22b3714408e4a96ee15d]

        tdf#63259 cycle case on sentences
        
        Cycle case will be applied to the sentence if the cursor is at
        a sentence end. Writer now also keeps the word/sentence selection
        after case change.
        
        Change-Id: I9dd561775ac612689526bcb118533ba81b5722be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165018
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Oliver Specht  <oliver.specht@cib.de>  [29750e249530eec0b3e00ceb75e668ad22b21cae]

        improve usability of variable fields
        
        The value field of the Variables page of the field dialog is changed
        into a scrollable field to enhance usability in combination with longer
        values of variable or user fields
        
        Change-Id: Ib268cf22ff54604214fb090c3c93b7d145a9c9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165750
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [23f13bc8c1aba9e53789180ef09ed06594ea4649]

        gtk4 a11y: Implement new GtkAccessibleTextInterface::get_offset
        
        Implement the new `get_offset` method for
        `GtkAccessibleTextInterface` newly introduced
        in GTK 4 in GTK commits
        
            commit f802be88e98f817c3d6fa048bf79d82de60173d3
            Author: Matthias Clasen <mclasen@redhat.com>
            Date:   Sun Mar 10 10:27:56 2024 -0400
        
                a11y: Use gtk_accessible_text_get_offset
        
                Implement GetOffsetAtPoint using gtk_accessible_text_get_offset.
        
            commit b9d2049991427e8dee443e9f3b683e52c96d6b83
            Author: Matthias Clasen <mclasen@redhat.com>
            Date:   Sun Mar 10 10:27:32 2024 -0400
        
                a11y: Add gtk_accessible_text_get_offset
        
                This is not implemented yet.
        
            commit cfe35586107d7c42eb3af7aa38ee23df22f718d0
            Author: Matthias Clasen <mclasen@redhat.com>
            Date:   Sun Mar 10 10:02:24 2024 -0400
        
                a11y: Add GetOffsetAtPoint
        
                We don't handle it yet.
        
        In order for this to actually work on the AT-SPI level,
        this also needs fixes on the GTK side. Pending MR: [1]
        
        With this, the previous
        
            Change-Id: I7d171b6696037a696f0d767d3134c7a7184f93a3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Apr 4 11:08:10 2024 +0200
        
                gtk4 a11y: Implement new GtkAccessibleTextInterface::get_extents
        
        and the mentioned GTK MR in place, a quick test with a Writer
        paragraph using Accerciser's IPython console now looks OK:
        
            In [1]: acc.queryText().getCharacterExtents(5, pyatspi.XY_WINDOW)
            Out[1]: (483, 219, 4, 18)
            In [2]: acc.queryText().getOffsetAtPoint(484, 220, pyatspi.XY_WINDOW)
            Out[2]: 5
        
        [1] https://docs.gtk.org/atk/vfunc.Text.get_range_extents.html
        
        Change-Id: Ieb45e3d0d6f37350898ffee081491bf94b6dbea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165794
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [89f272c8bbcdb5e46ed051564735b46cc0023b8b]

        gtk4 a11y: Implement new GtkAccessibleTextInterface::get_extents
        
        Implement the new `get_extents` method for
        `GtkAccessibleTextInterface` newly introduced
        in GTK 4 in GTK commits
        
              commit 7955efef6c31d23c8553dc3464e72273886a4417
              Author: Matthias Clasen <mclasen@redhat.com>
              Date:   Sun Mar 10 14:28:07 2024 -0400
        
                  atspi: Use gtk_accessible_text_get_extents
        
                  Implement the GetCharacterExtents and GetRangeExtents methods of
                  the atspi Text interface using the new GtkAccessibleText api.
        
              commit 3134003376fc37c6d5e7e6eb7c6f36307039a92c
              Author: Matthias Clasen <mclasen@redhat.com>
              Date:   Sun Mar 10 14:27:42 2024 -0400
        
                  a11y: Add gtk_accessible_text_get_extents
        
                  This will be used to implement GetRangeExtents in atspi.
        
        The `XAccessibleText` UNO interface currently
        only has a way to retrieve the extents of a
        single character, so just return `false`
        if the extents for a larger text range is
        requested.
        (LO's gtk3/ATK implemenation currently also doesn't
        implement AtkText.get_range_extents` [1])
        
        To actually work, this also needs changes on
        GTK side to support non-GtkWidget GtkAccessible
        implementations. Pending MR: [2]
        
        [1] https://docs.gtk.org/atk/vfunc.Text.get_range_extents.html
        [2] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7104
        
        Change-Id: I7d171b6696037a696f0d767d3134c7a7184f93a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165793
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-04  Michael Weghorn  <m.weghorn@posteo.de>  [164f344312768771a2e120236648e224322b4a2a]

        a11y: Fix XAccessible{Editable,Multiline}Text doc
        
        Fix typos and slightly improve wording.
        
        Change-Id: Ib58dcb4d6039a55ade76d12d5fed33f4eac84776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165792
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2330c59de48a40cd5614297afb7fd5e26c8a7b23]

        ofz#67825 build failure clang frontend command failed with exit code 139
        
        unotools/source/ucbhelper/tempfile.cxx:298:8: current parser token ';'
        unotools/source/ucbhelper/tempfile.cxx:46:1: parsing namespace '(anonymous)'
        unotools/source/ucbhelper/tempfile.cxx:278:1: parsing function body '(anonymous namespace)::getEyeCatcher'
        unotools/source/ucbhelper/tempfile.cxx:278:1: in compound statement ('{}')
        
        the very similiar unotools/source/config/docinfohelper.cxx
        compiles fine according to the log, so tweak to match that
        
        Change-Id: I8f1286c88d7c1a70fb3294c84bf1c55109d97ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165781
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-04  Heiko Tietze  <tietze.heiko@gmail.com>  [ebfa0d061fdbca6a25d3efcff72ab5ed184a51dc]

        Resolves tdf#154209 - Fixes resize issue in Index Entry dialog
        
        Change-Id: I83400b56d40f145c0e066c0c8b1783a1bae4cf28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165788
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-04-04  Moritz Duge  <moritz.duge@allotropia.de>  [80f823c84e9b70d1840f4aae2b523690a5051157]

        Fix indentation
        
        Change-Id: Iabbdd5507493e2d8e7c635ff53d2e6762944df0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165755
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [746b21760b911860c7ac497f10ab07d60111e867]

        tdf#81012: avoid content frames in footnotes / endnotes
        
        This makes the behavior of the endnotes in the end of sections consistent
        with the behavior of dedicated endnote pages, where heading fields ignore
        headings in endnote content.
        
        Change-Id: Iad0218b75a678808b1266024fe4c81f040a631c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165789
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [219dd67d6ad96e1c05e92e36583391946143dba6]

        -Werror=maybe-uninitialized
        
        ...as reported at least with some recent GCC 14 trunk.  Lets assume that those
        calls to GetWindowPos are never meant to fail.  (If it turns out that they can
        fail after all, the code would presumably need some modifications to mitigate
        the uninitialized reads from nL/nP.)
        
        Change-Id: I7695d3e54de2bf5d1e91b32cfdc84e994ccdd57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165783
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [41581fe7d782f261c19594c89875666f99c91af1]

        fix 'tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify'
        
        I messed up in
        
            commit 9c5fda14fff397d5d503f749ad019791d7e4ef83
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Mar 6 16:20:41 2024 +0200
            tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify
        
        and forgot to actually use the new SfxHintId::StyleSheetModifiedExtended
        I created in the constructor of the SfxStyleSheetHint class
        
        Change-Id: Ica661a156d72c8a4b8ad415b6f45fe5d3458ba26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165787
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [76fbdc6638824d2509d29a4993e5e5805bac65b0]

        improve font name in SwPageFrame::GetEmptyPageFont()
        
        Fix the problem similar to what commit
        1d9221ebc86f2696a65c12287ea19eea44d680cf (tdf#124601 sw: fix misplaced
        images in table cells, 2022-11-30) did: use a font that we ship to avoid
        font fallback.
        
        Change-Id: I59be457e018c96f7edda80fb5d3787593d75b010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [466156f14d8dee7e3e629dd72dc9c40ddc7262e8]

        Use osl::ResettableMutexGuardScopedReleaser instead of ad-hoc guards
        
        Change-Id: I2aa09655c207d3647650b5e38011a600bd221699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [6eefe3a29df4b0862a455a2d057e4a7d88457c71]

        Introduce ResettableMutexGuardScopedReleaser
        
        And use it to guarantee reretting a guard, without having to do that
        explicitly in exception handlers.
        
        Change-Id: I4727cb5b7f37b25e203396957797d24a093e0797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165775
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [d33a43a76c3ad6d38f7c2dca0ff5386ee5264bce]

        Drop one redundant check
        
        Change-Id: I0ae90e10fad2d6e41d855ead69b8cdcf8d53f525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165719
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Miklos Vajna  <vmiklos@collabora.com>  [57f02bb1015e7fc811b57ed618eefd54b9465426]

        svtools: improve font name in EmbeddedObjectRef::DrawPaintReplacement()
        
        Once CppunitTest_sw_uibase_shells sets non_application_font_use to
        abort, it would fail here with:
        
        warn:vcl.fonts:29463:29463:vcl/unx/generic/fontmanager/fontconfig.cxx:1192: PrintFontManager::Substitute: missing font: 'Helvetica' try: Liberation Sans instead
        
        Fix the problem similar to what commit
        1d9221ebc86f2696a65c12287ea19eea44d680cf (tdf#124601 sw: fix misplaced
        images in table cells, 2022-11-30) did: use a font that we ship to avoid
        font fallback.
        
        Change-Id: I1301c546d7cce90f0e687bc0db9dc69262eed4a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165779
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-04  Juan José González  <juanjosegzl@libreoffice.org>  [ea12d5abfdf029acb8b2f86ea3686b968b50e143]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c89178e82abacbb240e571fcbd9bd0f76b40642d
          - tdf#160467 Remove z-index in prism code block
            
            Right now code renders on top of header section.
            Remove z-index to fix it.
            
            Change-Id: Ic0cf226275eae1656107de27907a94af256d5555
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165768
            Tested-by: Jenkins
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [4be23d7701d43af34f218545a863f5c96b4298eb]

        remove leftovers
        
        from
            commit e1e48bba55ff68397d514ab3771850678312f348
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Apr 1 18:40:26 2024 +0200
            tdf#160399 speed up print preview
        
        Change-Id: I399752d473a4f6f782cdfcc53b4625dcdf7cb460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Jim Raykowski  <raykowj@gmail.com>  [3be164e0c7dc2cc73e32e643e30357e126238588]

        SdNavigator: Show context menu only for active document navigation
        
        Change-Id: I3d622f92d411b30e5beea5432e10ae0a907eeb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165667
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [65a57e5c7c3770d788e076303a7182de43a17cbf]

        A small refactor
        
        Change-Id: I299cc7c2850a71ee563824c6361707d894f5ddcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165773
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [9e47e217126d421e51e167da0d94a5d7c2f078ed]

        Drop a bit of redundancy
        
        POPPLER_CHECK_VERSION(0, 23, 0) implies POPPLER_CHECK_VERSION(0, 24, 0)
        
        Change-Id: I48f3763ef115719a3e3615623bfb40f7c79b8df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165772
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [cc895651302dc42dfb91ef06c41872d9dae8dd44]

        Related: tdf#160260 Drop xpdfimport.err.pdf, let PDF import return false
        
        The problem was, that upon any error in opening a PDF, out Poppler
        wrapper used another bundled document, with a single page with a static
        text "This PDF file is encrypted and can't be opened.". That happened
        regardless of the nature of the problem (it could be an IO problem, as
        in tdf#160260, or other things from Poppler's poppler/ErrorCodes.h).
        For automated import (command line or API), it meant that it was not
        possible to detect the failure.
        
        This replaces this strange mechanism with a normal error reporting. For
        now, a simple "general input/output error" will be reported; but it is
        possible to use interaction handler to show details (see comment in
        xpdf_ImportFromFile).
        
        Change-Id: I30493118fc5dd0b1c62cae7718acfe95bb4b13b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165771
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-04  Patrick Luby  <guibmacdev@gmail.com>  [cab028121bd9b620529b6492b3247ac48ac2082b]

        tdf#159790 temporarily release mutex for child packages
        
        This code is normally run on a separate thread so if a
        child package tries to acquire the solar mutex, a deadlock
        can occur if the main thread calls isRegistered() on this
        package or any of its parents. So, temporarily release
        this package's mutex while registering the child package.
        
        Change-Id: I45b534c44d5946637a5441927ed01a68aad4c448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165766
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6b7245f51274424a6c634424161e8766f8827033]

        A number of bogus GCC 13 warnings still hit with recent GCC 14 trunk
        
        Change-Id: I0ec7743cd79429591fcfc3eb9715ff36d06fc00b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165765
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b23019c566f2cbf50dfbec71d258b3e1a9ead312]

        Revert "osl::Mutex->std::mutex in GrammarCheckingIterator"
        
        This reverts commit 829fa53fe877d0f0fc33d634fa7fbfbed23b7676, which started all
        sorts of `make check` tests to hang for me due to a recursive locking attempt in
        
        > #5  std::mutex::lock (this=0x7f6af81e62c0) at ~/gcc/inst/include/c++/14.0.1/bits/std_mutex.h:113
        > #6  std::unique_lock<std::mutex>::lock (this=<synthetic pointer>) at ~/gcc/inst/include/c++/14.0.1/bits/unique_lock.h:147
        > #7  std::unique_lock<std::mutex>::unique_lock (this=<synthetic pointer>, __m=...) at ~/gcc/inst/include/c++/14.0.1/bits/unique_lock.h:73
        > #8  GrammarCheckingIterator::NextDocId (this=0x7f6af81e6260) at linguistic/source/gciterator.cxx:317
        > #9  GrammarCheckingIterator::GetOrCreateDocId (this=this@entry=0x7f6af81e6260, xComponent=uno::Reference to (SwXTextDocument *) 0x7f6af8430ec8) at linguistic/source/gciterator.cxx:339
        > #10 0x00007f6b3b9e9da9 in GrammarCheckingIterator::startProofreading (this=0x7f6af81e6260, xDoc=<optimized out>, xIteratorProvider=<optimized out>) at linguistic/source/gciterator.cxx:773
        > #11 0x00007f6b16441ec3 in SwDoc::StartGrammarChecking (this=<optimized out>, bSkipStart=bSkipStart@entry=false) at sw/source/core/doc/docnew.cxx:180
        > #12 0x00007f6b164c4eae in sw::DocumentTimerManager::DoIdleJobs (this=0x7f6afad005a0) at sw/source/core/doc/DocumentTimerManager.cxx:169
        > #13 0x00007f6b3e83a68b in Scheduler::CallbackTaskScheduling () at vcl/source/app/scheduler.cxx:509
        > #14 0x00007f6b3eb1725f in SalTimer::CallCallback (this=<optimized out>) at vcl/inc/saltimer.hxx:54
        > #15 SvpSalInstance::CheckTimeout (this=this@entry=0xffebe0, bExecuteTimers=bExecuteTimers@entry=true) at vcl/headless/svpinst.cxx:157
        > #16 0x00007f6b3eb1761d in SvpSalInstance::ImplYield (this=this@entry=0xffebe0, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at vcl/headless/svpinst.cxx:395
        > #17 0x00007f6b3eb17cd5 in SvpSalInstance::DoYield (this=0xffebe0, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/headless/svpinst.cxx:467
        > #18 0x00007f6b3e86aa44 in ImplYield (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:394
        > #19 0x00007f6b3e86b13b in Application::Execute () at vcl/source/app/svapp.cxx:369
        > #20 0x00007f6b3c8e715f in desktop::Desktop::Main (this=0x7ffe5e22fcb0) at desktop/source/app/app.cxx:1615
        > #21 0x00007f6b3e87e6fb in ImplSVMain () at vcl/source/app/svmain.cxx:229
        > #22 0x00007f6b3e87e9c5 in SVMain () at vcl/source/app/svmain.cxx:261
        > #23 0x00007f6b3c91de37 in soffice_main () at desktop/source/app/sofficemain.cxx:93
        > #24 0x000000000040078b in sal_main () at desktop/source/app/main.c:51
        > #25 main (argc=argc@entry=8, argv=argv@entry=0x7ffe5e22feb8) at desktop/source/app/main.c:49
        
        Change-Id: I60b8b0ba00cae691d6089325e4379a86221dc95b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165764
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5ebe81f068dba0c141ebe92f64731d0c95179dae]

        editeng: make it ContentNode::FindFeature clearer
        
        Change-Id: Ia3498df3cb11b06ac71e3c75839cc98cc0f3d88c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165337
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f4d31f2d6f37d280ae3e65c86077a7423dff0cc]

        editeng: prefix EditLine members, clean-up
        
        Change-Id: Ie8c8ee86f139854137ba95875f51ddaf64cc5848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165336
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [7b9905df455b47977968a185a7c43f35541e018b]

        tdf#160260: make poppler wrapper executable Unicode-aware on Windows
        
        Change-Id: I76dc31ee14d1794fa73f990e641540ff941c7201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165735
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f09b9b2785732319fd3199337b3528de3a561393]

        external/lxml: Silence -Wincompatible-pointer-types
        
        ...as seen with recent GCC 14 trunk,
        
        > gcc -Wno-unused-result -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -g -O0 -Wall -I/home/sberg/lo/core/workdir/UnpackedTarball/zlib -I/home/sberg/lo/core/workdir/UnpackedTarball/python3 -I/home/sberg/lo/core/workdir/UnpackedTarball/python3/Include -fPIC -DCYTHON_CLINE_IN_TRACEBACK=0 -I/home/sberg/lo/core/workdir/UnpackedTarball/libxml2/include -I/home/sberg/lo/core/workdir/UnpackedTarball/libxslt -Isrc -Isrc/lxml/includes -I/home/sberg/lo/core/workdir/UnpackedTarball/python3/Include -I/home/sberg/lo/core/workdir/UnpackedTarball/python3 -c src/lxml/etree.c -o build/temp.linux-x86_64-3.8-pydebug/src/lxml/etree.o -w
        > src/lxml/etree.c: In function ‘__pyx_pf_4lxml_5etree_11TreeBuilder_4data’:
        > src/lxml/etree.c:137698:66: error: passing argument 1 of ‘__pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData’ from incompatible pointer type [-Wincompatible-pointer-types]
        > 137698 |   __pyx_t_1 = __pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData(((struct __pyx_obj_4lxml_5etree__SaxParserTarget *)__pyx_v_self), __pyx_v_data); if (unlikely(__pyx_t_1 == ((int)-1))) __PYX_ERR(3, 832, __pyx_L1_error)
        >        |                                                                 ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >        |                                                                  |
        >        |                                                                  struct __pyx_obj_4lxml_5etree__SaxParserTarget *
        > src/lxml/etree.c:137074:105: note: expected ‘struct __pyx_obj_4lxml_5etree_TreeBuilder *’ but argument is of type ‘struct __pyx_obj_4lxml_5etree__SaxParserTarget *’
        > 137074 | static int __pyx_f_4lxml_5etree_11TreeBuilder__handleSaxData(struct __pyx_obj_4lxml_5etree_TreeBuilder *__pyx_v_self, PyObject *__pyx_v_data) {
        >        |                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
        
        etc.
        
        Change-Id: I19f6768bf031c04730972c1fa4a006e2a7d50e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165758
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b0edb1909b9deb1a170497f935a528f8118c8308]

        tdf#146619 Drop unused 'using namespace' in: toolkit/
        
        Change-Id: Idab290ebc1394587c17dbec0c110bfa759cbdb8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165540
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6dc092045c0e8bb46c0f5e90f529a9285727f93f]

        tdf#146619 Drop unused 'using namespace' in: sd/
        
        Change-Id: I7e48be1962d1e643c49c8cc0d6ca01ffbbb97429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165567
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1c9c748c71f7adff6b6ba1a893950c4ad3a4d1ff]

        tdf#146619 Drop unused 'using namespace' in: test/
        
        Change-Id: I2b10b005a1f8ac9d4aa6af7516bca98e6dcd41c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165566
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [374ac88c2cab8065eca3b9479c0039f6893fedf0]

        desktop: fix build with enable-online-update
        
        Regression from 75706c003c3e224047e2f5b079aebde4e3d40d74
        "tdf#146619 Remove unused #includes from C/C++ files"
        
        See https://ci.libreoffice.org/job/lo_daily_tb_win/1718/console
        
        Change-Id: I32f406aa44dfe37c472cf4de7805141daf37ab66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165738
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c10a1a4ce65496877d8fc78359f9b7e59d2703c]

        reduce cost of displaying sheets with conditional formatting
        
        shaves off 1-2% of the cost by stack-allocating some iterator objects
        
        Change-Id: I509d4de6c59db086f112d83768a24c11dd5d0872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-03  Alain Romedenne  <alain.romedenne@libreoffice.org>  [61337efb8c6a434a88a82dd2819edf600e867aa4]

        minor fixes to officehelper.py
        
        - erroneous code sample in code comment -retry delays
        - fix when raising OSError exception - undefined variable
        
        Change-Id: I2cae4e8b6bbb3153e79f290ae1d316aa22a86b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165714
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c4f2a85bc5fa319a84474191275a2434dda1830b]

        ofz#67815 overflowed short
        
        Change-Id: Iee9a5caee53b522ed16d234c2bc06987264e23db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [a3daf52dd21ae03a8b04e1f9132a6713c9cc414f]

        Base scale on 1.0, not on 100.0
        
        Simplifies things by avoiding many repeated multiplications / divisions
        by 100 during calculations.
        
        Change-Id: Ib063d343549139c8d83e5b06570dc61f39ea0df6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165666
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-03  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [387a9c445793e8377f85e508d935dc070fd8ab74]

        tdf#160252 ITEM remove unnecessary cleanups of shared_ptr
        
        Change-Id: I5654d65097bf88b70cb85937de3ce111fa7e4345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165552
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-04-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [f8e927e6cdbc99240d8967a5e920ce33d45838d2]

        tdf#160376 Add uno:Reload to the Notebookbar UI
        
        The command uno:Reload is missing from some of the Notebookbar UI variants (f.i. in Calc notebookbar_compact.ui has it, but the others do not).
        
        This patch adds the uno:Reload command to all variants of the Tabbed UI in all LO apps.
        
        Change-Id: Ic56a05a15bc52a51bc45435ca938a6879452189f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165675
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2e6c853b8ecf42f829ec039336bdd7b8574ace2c]

        Fix typo
        
        Change-Id: Ic6416560bf3d404a57acc66cd4f375fe9bfc9c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165743
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-03  Pranam Lashkari  <lpranam@collabora.com>  [dd7e03fe7f1d913b8fad2ade6d3c04d02c0cf92c]

        LOK: set creation date when online creates file from template
        
        problem:
        when online created file using WOPI clients, creation dates were never set.
        in online files are created using templates, even empty files are created using
        an empty template
        
        Change-Id: I3f022427745de7204faac9418620e2a87f9cf684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165711
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [33ca999cb238246709494285bb27d85745e7d112]

        Fix typo
        
        Change-Id: Iaa7a84f5568b13f223e9a45c50c5a7de66e08f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165740
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7357f3ff7a9bb1c292c2c413a5cb232e465414ab]

        Fix typo
        
        Change-Id: I2271e31d2a57206954e166e71b16af092c11aab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165741
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-04-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [829fa53fe877d0f0fc33d634fa7fbfbed23b7676]

        osl::Mutex->std::mutex in GrammarCheckingIterator
        
        Change-Id: Icda197a9c1a20b245079c91a7a7b2301a5955b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-03  Gökay Şatır  <gokaysatir@gmail.com>  [fb471194d04607eb7706f8650f0c92c6ebbbb5b8]

        Use sdi properties for checking uno commands'a availability.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: Ie70851756d1a4272876b07fefb876d7e6f8d4d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165287
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 68422af88576a799b22e472c303ed924c360784b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-03  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [6182f236a27d6f12527daa7fba82ddc56f95f0d3]

        i18npool : use OUString literal for XInterface implementation
        
        Change-Id: I7843e1e873c9272c8ad3eb4cad0b2ea48cafeb7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165638
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-04-03  Gökay Şatır  <gokaysatir@gmail.com>  [5266c1b215263029fe9b35e5365df65d116edf64]

        Allow more uno commands in readonly view mode.
        
        So user can use keyboard for selection.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: Ic7812c88110da9fbefe86d145f921e48360b4f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165157
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c9c4c1f21fd13f047497f4d66952f98bdabe442f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c6fec27df9ba67681d6d1bea474557123c395d13
          - Fix several "D'oh! you found a bug"
            
            + some refactor
            
            Change-Id: I496d90ea26a41bd2ddb98af1e4e80b51322720e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165708
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [68e2b820489f01c38106a606740ef746c0cf4c9f]

        Allow custom "eye catcher" from LO_TESTNAME in tempfiles on Windows
        
        Change-Id: Id8d94af9e03d0c8553d0a7949e4a9259159481cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165732
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-03  Miklos Vajna  <vmiklos@collabora.com>  [c0a8725da1108604510b7d6a330fa673cba31a5d]

        CppunitTest_sw_rtfexport: avoid DECLARE_RTFEXPORT_TEST
        
        No need to go via Writer-specific macros here.
        
        Change-Id: Iee66114a4cb8db712d932cc78f799809ad5e4341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165730
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2c2c1d274fe6336f4f88dd2fb9f716c1d1b092d2]

        tdf#146619 Drop unused 'using namespace' in: svtools/
        
        Change-Id: Ia74e293ba140d7e204a2706b8e2827669bfdfb1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165541
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [28d6c626fd0039413daa31ab37c006c64a63e05e]

        tdf#146619 Drop unused 'using namespace' in: svgio/
        
        Change-Id: I4db608823faf4588e65e53fd099c9bc76bf39f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165539
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [69303d5d09cb8ec49d90e19eaf16eabb24f77725]

        tdf#146619 Drop unused 'using namespace' in: dbaccess/
        
        Change-Id: If006c5f0002b9d5981220efa22873bf0adb169bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165543
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [704e71b9d13054a7e21a037663de4feacae2ef25]

        tdf#146619 Drop unused 'using namespace' in: svx/
        
        Change-Id: Ic8b925a3ec55166a9d5da05827d2cb335943b665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165542
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [f2482fd96eff00b806fae385096531f63f5f2bf5]

        Simplify VBALikeToRegexp a bit
        
        This cleans up some unnecessary escaping both
        inside and outside [] groups.
        
        Change-Id: I5abcf0fce634f0d8809bf4d318f61b8c8f69a318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165703
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f61ea135430d7b4a1fac7de1e57a1314fbb1b49e]

        editeng: use text scaling that better mimics MSO text scaling
        
        Implement text scaling algorithm that is similar to MSO text
        scaling for text boxes for the compatibility purpuse, so that the
        Impress slides better match how the PP slides are layed out.
        
        This also moves the implementation into EditEng, where it is
        possible to better control how searching for the best scaling
        factor is performed without doing additional irrelevant work or
        trigger invalidations that should not be triggered.
        
        An additional change is that the paragraph with no content at the
        end are ignored, and are not taken into account when determining
        the height of the content. This is done for compatibility reasons.
        
        Fix horizontal spacing of tabs - the spacing shouldn't be scaled
        and the tab shouldn't include the space at the beginning of the
        line.
        
        Change-Id: Ie37fa67f1cf300e915a4ebaef2a7f968bf6c5744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165441
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [db64748f1ee771da9da857f95601b9e08b577166]

        svx: read font and spacing scaling from oox, add bot as UNO prop.
        
        - Read spacing in oox.
        - Add spacing scaling as a property.
        - Rename property "TextFitToSizeScale" to "TextFitToSizeFontScale"
        - Add property "TextFitToSizeSpacingScale"
        
        Change-Id: Icde575e55a3146169d86bb538a57adcf1fa228a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165633
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-03  Dione Maddern  <dionemaddern@gmail.com>  [6fd33d50603c2d12c0a1d88edb04c0890b6a1ef1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 336461782a58266eb90a0c96c6c48a5454fe6b7f
          - Fix broken help link for File > Save > Encrypt with GPG key
            
            Added a HID bookmark to text/shared/01/01070000.xhp so that pressing F1 when hovering over "Encrypt with GPG key" opens the correct help page. Added a link to the help page for "Encrypting Documents with OpenPGP".
            
            Change-Id: I8ae984be20a1c60be03f3a535855fa6cab8194cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165628
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [74e1b694b853b3467ad5c819906a031edf207a10]

        Remove duplicated include
        
        Change-Id: I3255d4a4b4435c092def3c5d17eea27c6f59c491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165706
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-03  Dione Maddern  <dionemaddern@gmail.com>  [e160bc46b1f51acef3715d3d43ae29842cff54a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d4d158dee9ef0d47e25b756df24150c7de42773
          - tdf#107081 Update instructions for inserting objects from the Gallery
            
            Updated text/shared/guide/gallery_insert.xhp to remove references to obsolete features and update instructions that no longer work. Expanded "Related Topics" section.
            
            Deleted:
              text/shared/guide/dragdrop_fromgallery.xhp
              text/swriter/guide/insert_graphic_gallery.xhp
            - because they cover the same subject matter as text/shared/guide/gallery_insert.xhp.
            
            Updated AllLangHelp_shared.mk to remove reference to text/shared/guide/dragdrop_fromgallery.xhp.
            
            Updated AllLangHelp_swriter.mk to remove reference to text/swriter/guide/insert_graphic_gallery.xhp.
            
            Updated auxilliary/shared.tree to redirect any references to text/shared/guide/dragdrop_fromgallery.xhp to text/shared/guide/gallery_insert.xhp.
            
            Updated auxilliary/writer.tree to redirect any references to text/swriter/guide/insert_graphic_gallery.xhp text/shared/guide/gallery_insert.xhp.
            
            Changed any links to text/shared/guide/dragdrop_fromgallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp:
              text/sdraw/guide/graphic_insert.xhp
              text/sdraw/guide/main.xhp
              text/shared/01/gallery.xhp
              text/shared/guide/dragdrop.xhp
              text/shared/guide/dragdrop_beamer.xhp
              text/shared/guide/dragdrop_gallery.xhp
              text/shared/guide/dragdrop_graphic.xhp
              text/shared/guide/dragdrop_table.xhp
              text/shared/guide/main.xhp
              text/swriter/guide/dragdroptext.xhp
            
            Changed any links to text/swriter/guide/insert_graphic_gallery.xhp in the following files to links to to text/shared/guide/gallery_insert.xhp:
              text/sdraw/guide/graphic_insert.xhp
              text/shared/guide/insert_bitmap.xhp
              text/shared/guide/insert_graphic_drawit.xhp
              text/swriter/guide/insert_graphic.xhp
              text/swriter/guide/insert_graphic_dialog.xhp
              text/swriter/guide/insert_graphic_fromchart.xhp
              text/swriter/guide/insert_graphic_fromdraw.xhp
              text/swriter/guide/insert_graphic_scan.xhp
              text/swriter/guide/main.xhp
              
            Updated text/shared/01/gallery.xhp to update obsolete instructions. 
              Added "How to Get" instructions for accessing the Gallery with a keyboard shortcut. 
              Added additional keywords to make the page easier to find. 
              Added additional HID bookmarks so that pressing F1 will now open the relevant help page for context menu items in the Gallery.
              Reorganinzed the article to improve clarity including adding additional headings.
              Added embed links for additional menu options to provide a more thorough explanation of the Gallery feature.
              Added an explanation of the "Title" option in the context menu.
              Removed the "hidden" tag from the description of the "Detailed view" and "Icon view" options.
            
            Updated the description of the Insert function in text/shared/00/00000010.xhp to reflect how inserting an object from the Gallery currently works. Changed "Background" to "Insert as Background" to better reflect current menu options.
            
            Change-Id: Ib510289436a449a1581b2f9b6deacea3f5cfe37c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165620
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [55e9a27afd2d6a13cf76b39641bf121c3ec4b45c]

        Related: tdf#39052 - chart ooxml: export formatted chart titles
        
        texts properly to ooxml.
        
        Also adding "FormattedStrings" property for title objects
        to simplify the working of character formattings in editable
        chart shapes.
        
        TODO: odf import/export
        
        Change-Id: Ie27b4dee72c24fa6a2a4e2a7db8da7fa50eb8937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165583
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [4f994cec388377cc5c2bddb804bd92eb4cd7dc8d]

        tdf#39052 - Chart: make characters formatable in editable chart textshapes
        
        Editable textshapes include main chart title, sub chart title, axis titles.
        
        In chart2 the chart2::XFormattedString and chart2::XFormattedString2 store
        the formatted characters from textshapes, so we need to set all the character
        properties from the EditTextObject and need to add them to to the XFormattedString
        array with all the related texts which are formatted individually.
        
        For formatting of the characters the .uno:FontDialog command can be used,
        which can be called from the chart menubar, toolbar and with right click
        on the text when we are in edit mode in the textshape.
        
        (Note: in the next patch the OOXML export will be fixed.)
        
        Change-Id: I5750a5fe694b384dc6b28e2ef03ac1f2b03957db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165501
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f31a8ff9ea15ad81aeac265fce6eafe6342a68b7]

        tdf#78027 - Fix Chart OOXML Import with non-uniform formatted titles
        
        Character formats are disappeared from Chart Title textobjects if they were
        formatted non-uniform. In this patch only the OOXML import and the chartview
        part will be fixed which make it visible after the import.
        
        (Note: next patch will contain the chart controller part where the characters
        can be formatted during title editing).
        
        Change-Id: I4fb5c3d80b7889935d198e70fb49e2c68108b235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165500
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-04-02  Jim Raykowski  <raykowj@gmail.com>  [878ab17b0fad66fb7accd9573ef7f66403d593b9]

        tdf#139944 SdNavigator: disable in master mode
        
        Improve where the disable is done and in addition to making disabled
        also clear the objects tree.
        
        Also fixes a drag and drop ordering scrolling bug introduced by commit
        60e32969a98cad348cf8e55e8f93abc3d6e9c70c
        
        Change-Id: I702c85bc1ba16837fb7f8c2246bdb29d96e6cc6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165606
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-04-02  RMZeroFour  <ritobroto04@gmail.com>  [03c9875b873d24d72587ab7d9f3190c7c0cf0e5e]

        tdf#145538 Use range based for loops
        
        As part of the efforts in tdf#145538 to replace regular for
        loops with range-based for loops in the codebase where suitable,
        this commit does so in SvxNumOptionsTabPage::PageCreated.
        
        PS-2: Renamed a variable.
        
        Change-Id: I7ec813a3c6fead3246137a2841c9f3e80f5adc63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165594
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-04-02  Patrick Luby  <guibmacdev@gmail.com>  [89e23bb599104d3bde30878148e15cf4deb1593f]

        tdf#159790 eliminate deadlock on main thread
        
        A separate thread may have already acquired m_aMutex and that
        thread will then try to acquire the solar mutex. However, when
        the main thread calls this method, the main thread has already
        acquired the solar mutex.
        
        So, drop the desktop mutex before calling out.
        
        Change-Id: Ic87063266ac5101b866df9f24067a403e1417745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165682
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db040630d664fa20bc4f8995d2168fcce51a8bfd]

        crashtesting: SvNFEngine::DefaultCurrencyRO assert
        
        seen with forum-mso-en4-207468.xls
        
        so we will have to ensure that nDefaultSystemCurrencyFormat
        is set before using the RO mode
        
        Change-Id: Ib1e755203917ddd751a1493c817cc8383bbbc043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-02  Mike Kaganski  <mike.kaganski@collabora.com>  [38f731ff67142a423aa6f46dc3e92d094f86ffb1]

        tdf#160478: fix Basic LIKE operator
        
        1. The regex must match the whole input. Thus, the ^ and $ metacharacters
           must be replaced with \A and \z, which only match beginning and end of
           input, not any line start / end.
        2. The * and ? metacharacters of LIKE must match newline character; thus,
           search flags must include UREGEX_DOTALL. To avoid changing TextSearch
           implementation, I use icu::RegexMatcher directly.
        
        The direct use of icu::RegexMatcher also allowed to simplify the code by
        calling icu::RegexMatcher::matches method.  This may perform better than
        general-purpose utl::TextSearch::SearchForward.
        
        Change-Id: I75776498b36f236da294462362ed5b36ed8cdf68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165700
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-02  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [0fb98963c46013209d39c03c3d61ef52ccc504e2]

        tdf#146619 Remove unused #includes from C/C++ files
        
        'sc' module was cleaned.
        
        Change-Id: Ia491d741a4c1c5314f35ebb4baa82dd516948ae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165699
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c59a2c22e930d323b95f42089928baa1cad4224a]

        convert TableModel to comphelper::WeakComponentImplHelper
        
        Change-Id: I548a33e93c14c40c6cd500e3306a8e4279e73f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b89c2909d48c9e4838d589085882e356439dcbbb]

        convert SvtRulerAccessible to comphelper::WeakComponentImplHelper
        
        Change-Id: Ibd37a38bf1fe6c2669af11b0c4eca957954f64bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165676
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [58c4457a902c846229dc3383cc31bbc8f4b3aed9]

        Update to latest Rhino 1.7.14
        
        ...at the expense of losing, at least for now, the script editor for it (which
        had been hacked into the old upstream sources in a hard-to-maintain way).
        
        rhino-1.7.14.zip is taken from
        <https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.zip>.
        Building it would now use Gradle, but instead just hack together an invocation
        of javac and jar in external/rhino/ExternalProject_rhino.mk that effectively
        generates the same jar as the upstream-built jar available at
        <https://github.com/mozilla/rhino/releases/download/Rhino1_7_14_Release/rhino-1.7.14.jar>.
        
        All the various patches are no longer necessary:
        * external/rhino/rhino1_5R5.patch and external/rhino/OfficeScriptInfo.java were
          mostly for the hacked-in script editor, which has been abandoned at least for
          now (see above).
        * external/rhino/rhino1_5R5-find_swing.patch (originally from
          0a7f9346503a557f583bced269655fa1996550af "ause109: #i106296# make build.xml
          aware of TARFILE_LOCATION") appears to be obsolete.
        * external/rhino/rhino1_5R5-updateToolTip.patch is covered by
          <https://github.com/mozilla/rhino/commit/ab20a73b16f68daf715c7ac4808c119bb15d698c>
          "Fix bug 414869: Rhino debugger fails to launch due to updates in mac os x
          leopard".
        * external/rhino/rhino-classpath.patch.1 from
          bb58293296f843654045d7b0eba6899d11533a4a "rhino: unbreak build on Fedora 34"
          was only relevant when building with Ant.
        
        Change-Id: I5fca5915d785716f7aaf313ff2469a20f55f707a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165190
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-02  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [a0c53ab43840d1c84d7d246b2cbc73c3a8862155]

        tdf#146619 Remove unused #includes from C/C++ files
        
        the 'xmlsecurity' module was cleaned
        
        Change-Id: If8fae797ed5586888022ecb09bab690d68ae7bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165593
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [aacdc24be7a256ea66d45f9ab3d275721c8bafbf]

        tdf#146619 Drop unused 'using namespace' in: i18npool/
        
        Change-Id: I3c4ca1083f8ef4053d1b4202bf9617b9373312bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165537
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [75706c003c3e224047e2f5b079aebde4e3d40d74]

        tdf#146619 Remove unused #includes from C/C++ files
        
        the 'desktop' module was cleaned
        
        Change-Id: Ia7dcb77a42ca7f9be67e30d10cd54697bf93b6d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165663
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [3976c94feecb00ee80a48009086d0850e32891f1]

        fix assert in loading forum-de3-11775.ods
        
        regression from
            commit a95bff116e1da140b9abe9742ceeb9a3caed43d5
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Mar 26 15:42:52 2024 +0200
            convert OCellListSource to comphelper::WeakComponentImplHelper
        
        Change-Id: Ib8af6627c641c73d9e4e6aaa43d694084a2854ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Sakura286  <sakura286@outlook.com>  [de0a269a6ed54716e03e1ff3cc52857b745853e2]

        riscv64 bridge: replace some preprocessor directives to macros for debugging
        
        Change-Id: Ic53d4a462e12e8448b14e750c4ef2824385b8f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165502
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [db8b19a77ba0c115c1e0b0ad067ef433a3aa3a79]

        use more concrete UNO types in sd
        
        Change-Id: Iea48c8750c940441c5687068317107a5932799e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [354c9e03790f837cc2fa0d6b8474425612e182e6]

        convert sd::Annotation to comphelper::WeakComponentImplHelper
        
        Change-Id: Icafd8d0e3cf1923fd287792cb03a5431907599e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25a5b9b136c80c93593097e4463184035218fd56]

        Related: tdf#157480 use SSL_CERT_FILE on macOS too
        
        for SSL use by pyuno emailmerge
        
        another alternative mechanism that could work is to generate one
        with something like: "security find-certificate -a -p > cert.pem"
        ref: https: //hynek.me/articles/apple-openssl-verification-surprises/
        
        Change-Id: I8bff2ca5bbbb4f2c2333a67e0281dd4fa0b06405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0f19f2bbf4c5a0ebafd9a43588783b9e70dcd936]

        Update git submodules
        
        * Update translations from branch 'master'
          to e36ba06ea7b75b61d93b7b9b9f50d90301010738
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I65d403dd9ce3233ba067c1e76faa0b9f782fe816
            
2024-04-02  Gökay Şatır  <gokaysatir@gmail.com>  [3eb61ea78d73c4b1311bf3ec4e5b4e0332e9f0ba]

        Disable chart modification in readony view mode.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I271caa12eed69099d6f0acd9bdcff53efcc26972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164970
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit dd232051d7ac43f1f15731916708a95403b78b62)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165627
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-02  codewithvk  <vivek.javiya@collabora.com>  [a82073a8d280f4500230cca6cc4cb1741b9732af]

        Conditional Formatting: Adding More Specified Dialogues
        
        We have added additional single conditional dialogues to enhance the conditional formatting options for conditions such as duplicates, N elements, etc.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: I46d069f259d47739ad1bc859b19513f19d414eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165290
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit abcb07e2baf2d59904b50e9c20f8a108ab9f17de)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165626
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-02  RMZeroFour  <ritobroto04@gmail.com>  [6817c668cd3a61e4129a414e35f4044c306d290e]

        tdf#147021 Replace SAL_N_ELEMENTS with std::size
        
        As part of the efforts in #145538 to replace the SAL_N_ELEMENTS()
        macro with std::size() and std::ssize(), this commit performs the
        necessary changes for a few files in the filter/ module.
        
        PS-2: Replace an std::size call with sizeof, and one with std::ssize
        
        Change-Id: Icac6470cdff762f828651153d0abc5f40b8e5d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165592
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-02  Miklos Vajna  <vmiklos@collabora.com>  [a44e066c9e587dc87fd2563f3e9454e9e92dcde7]

        svx: prefix members of XLineEndEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: I901e231f8112dea28bdccfb79b17470f1436c0db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165665
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-04-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [49a6a819651caf493038a7d333764ff5cb370a23]

        tdf#146619 Drop unused 'using namespace' in: basic/
        
        Change-Id: I55bd0c89880dd97307dde5a5b670e63f3ea66355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165536
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b77ad21d445783d77697470796be5c43f9fc5cd3]

        tdf#146619 Drop unused 'using namespace' in: sfx2/
        
        Change-Id: I3748612644c9c4eb88d7fb6e2d512954de9c1002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165538
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-02  Noel Grandin  <noelgrandin@gmail.com>  [25b642fdd87da4d5ed556600d0eb69d72865f666]

        simplify SotTempStream and lifetime
        
        It is really just an SvStream instance, and the lifetime does
        not need reference counting
        
        Change-Id: Idb5ffd96f852aae0dc1a94cddc0a83fbcdf974ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ad14abcf790002ac6fe09afbc5a2cae46f62085]

        tdf#160399 speed up print preview
        
        shave about 2-5% off the cycles here
        
        Change-Id: I23adffa4715d3dd28a92d48603a236115fb7d680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1e48bba55ff68397d514ab3771850678312f348]

        tdf#160399 speed up print preview
        
        takes time from 2.5s to 1s for me
        
        Store all of the PrintPageRanges in the ScPrintState
        save/restore data structure, means we don't recompute the data
        in that structure, so of which is quite expensive.
        
        Change-Id: If65c8ca1cce25ff228c483f173b19b456056dc57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-04-02  Mike Kaganski  <mike.kaganski@collabora.com>  [51244ebe62bb25f7d87ab1332e863720d980db66]

        Fix UB after 8962141a12c966b2d891829925e6203bf8d51852
        
        (tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle, 2024-04-01).
        As reported by Stephan in https://gerrit.libreoffice.org/c/core/+/165553/6#message-fec1e45288c0e87d43c58f777ebe51b03c534d82:
        
         `CppunitTest_sw_rtfexport CPPUNIT_TEST_NAME=testMathEqarray::TestBody` now fails with
        
          vcl/source/gdi/sallayout.cxx:245:30: runtime error: inf is outside the range of representable values of type 'long'
           #0 in SalLayout::GetBoundRect(tools::Rectangle&) const at vcl/source/gdi/sallayout.cxx:245:30
           #1 in OutputDevice::GetTextBoundRect(tools::Rectangle&, rtl::OUString const&, int, int, int, unsigned long, KernArraySpan, std::span<unsigned char const, 18446744073709551615ul>, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1932:28
           #2 in (anonymous namespace)::SmGetGlyphBoundRect(OutputDevice const&, rtl::OUString const&, tools::Rectangle&) at starmath/source/rect.cxx:80:32
           #3 in SmRect::SmRect(OutputDevice const&, SmFormat const*, rtl::OUString const&, unsigned short) at starmath/source/rect.cxx:224:21
           #4 in SmMathSymbolNode::AdaptToY(OutputDevice&, unsigned long) at starmath/source/node.cxx:2122:18
           #5 in SmBraceNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:1340:17
           #6 in SmBinHorNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:816:13
           #7 in SmLineNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:610:20
           #8 in SmTableNode::Arrange(OutputDevice&, SmFormat const&) at starmath/source/node.cxx:534:20
           #9 in SmDocShell::ArrangeFormula() at starmath/source/document.cxx:280:13
           #10 in SmDocShell::GetSize() at starmath/source/document.cxx:405:9
           #11 in SmDocShell::Repaint() at starmath/source/document.cxx:566:21
           #12 in SmDocShell::OnDocumentPrinterChanged(Printer*) at starmath/source/document.cxx:552:5
           #13 in SmDocShell::SetText(rtl::OUString const&) at starmath/source/document.cxx:188:9
           #14 in SmDocShell::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/document.cxx:848:5
           #15 in SmModel::readFormulaOoxml(oox::formulaimport::XmlStream&) at starmath/source/unomodel.cxx:1105:22
           #16 in writerfilter::rtftok::RTFDocumentImpl::beforePopState(writerfilter::rtftok::RTFParserState&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3010:30
           #17 in writerfilter::rtftok::RTFDocumentImpl::popState() at writerfilter/source/rtftok/rtfdocumentimpl.cxx:3666:23
           #18 in writerfilter::rtftok::RTFTokenizer::resolveParse() at writerfilter/source/rtftok/rtftokenizer.cxx:114:37
           #19 in writerfilter::rtftok::RTFDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/rtftok/rtfdocumentimpl.cxx:856:27
           #20 in (anonymous namespace)::RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/RtfFilter.cxx:163:20
           #21 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2392:34
           #22 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:760:23
           #23 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1980:36
           #24 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:720:28
           #25 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1176:37
           #26 in framework::LoadEnv::start() at framework/source/loadenv/loadenv.cxx:412:20
           #27 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) at framework/source/loadenv/loadenv.cxx:308:5
           #28 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:168:14
           #29 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:591:16
           #30 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx
           #31 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:71:62
           #32 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:126:19
           #33 in UnoApiTest::load(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:108:5
           #34 in SwModelTestBase::loadURL(rtl::OUString const&, char const*) at sw/qa/unit/swmodeltestbase.cxx:441:20
           #35 in SwModelTestBase::loadAndReload(char const*) at sw/qa/unit/swmodeltestbase.cxx:466:5
           #36 in (anonymous namespace)::testMathEqarray::TestBody() at sw/qa/extras/rtfexport/rtfexport.cxx:198:5
        
        Change-Id: I857861f5bc51a1e43bfbf5e0c9dbce542d673ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165664
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0ef2073ac560fcfab102d5363c1cc017694d6abc]

        Fix UBSan RTTI needs
        
        ...vcl_graphic_test now failed with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_vcl_graphic_test.so
        > workdir/LinkTarget/CppunitTest/libtest_vcl_graphic_test.so: undefined symbol: _ZTI10ImpGraphic"
        
        Change-Id: I1d11a50ef9dbb0003f7bc66540829b43c1412a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-04-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4bdbf0f898e8642b0a34195537d1516cc8eee819]

        editeng: combine scaling parameters into ScalingParameters struct
        
        This makes dealing with scaling parameters much clearer and it
        improves readability.
        
        Change-Id: I327b6530ef5587972cc0075390704754a33563a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165632
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [6027c219444ade7274841a5ba45e62bdc1ea3238]

        harfbuzz: upgrade to 8.4.0
        
        Change-Id: Ie9b5e2fc85c3be588217a166f4230c87c3cb122e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165652
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-01  Michael Meeks  <michael.meeks@collabora.com>  [c0dcd388b83d73f704cb42ab121fb31a7cb867da]

        lok preinit: don't re-synchronize extensions on each child start.
        
        We should sort out our extensions, if at all, at pre-init time.
        This should save ~4% of CPU in a week-long profile of a COOL server.
        From Desktop::Main's SynchronizeExtensionRepositories.
        
        Change-Id: I2760de26635723492dfa5a52005ee90623337bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165622
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9f3d3cec7cd3b8c6e79f52028c89e0abd9b5eec0]

        tdf#146619 Drop unused 'using namespace' in: desktop/
        
        Change-Id: I120471364834dfd0702b6ce15f79a8327cac26b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165534
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5a408044f924b1d7d221994ba901dbfe52b00c22]

        tdf#146619 Drop unused 'using namespace' in: lingucomponent/
        
        Change-Id: I98f6edf1da4915ff43312c187e92891371833fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165533
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5bf63cdc6ad7b8549610ddb31fde482ff2160161]

        tdf#146619 Drop unused 'using namespace' in: linguistic/
        
        Change-Id: Ib4df4e592e6b485dc087eddb49f59fc24c710380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165532
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [3227466e7dc8bb247618a1d27126b4ab02f45672]

        libtommath: upgrade to 1.3.0
        
        Change-Id: Ica9e2520c7c70a21721f7f389fd3cd8138bf550c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165609
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-04-01  Patrick Luby  <guibmacdev@gmail.com>  [053f7f9ff5a475446da2855e2e71f3ea0ef18791]

        tdf#160444 check device's owner window is a nullptr
        
        Since commit 563f7077f1dbce31ff95ee8d2e8d17b629693db1, the
        device's owner window gets deleted before this object is
        deleted.
        
        Change-Id: I15dc8db60e5520c2f0e73a9a117f25af15845caf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165637
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-04-01  Mike Kaganski  <mike.kaganski@collabora.com>  [db1de445ea67e7f888664531e0bd2d82cde7b46d]

        tdf#151413: add UTF-8 data to the Link clipboard format
        
        And introduce methods in TransferableDataHelper to handle that.
        
        Change-Id: I1d91f0f6b7e8523125f9cc1507dbd6737968f7d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165607
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-01  László Németh  <nemeth@numbertext.org>  [c7582ceae710c1a81f75c63541f332052ca7aab0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c2349a58a8e43f44a796f8e21053f4ca6de6fb4c
          - tdf#106733 tdf#158885 add "Exclude from hyphenation, Compound characters...
            
            Document new and updated hyphenation options of LO 24.8:
            
            New options:
            
            – "Exclude from hyphenation" (Character->Position);
            
            – "Compound constituent characters at line end" (Paragraph->Text Flow).
            
            Updated (moved and negated) options (Paragraph->Text Flow):
            
            – "Hyphenate words in CAPS" and
            
            – "Hyphenate last word".
            
            Follow-up to core commit 3a332d9f1cacb3c6f81fcf6c08afa51d091ddff4
            "tdf#158885 cui offapi sw xmloff: fix hyphenation at stem boundary",
            core commit 03c5a31a0f374a90fbc821718c14dc5f8a385adf
            "tdf#106733 sw cui: add CharNoHyphenation checkbox",
            core commit b5e275f47a54bd7fee39dad516a433fde5be872d
            "tdf#106733 sw: implement CharNoHyphenation"
            and core commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372
            "tdf#106733 xmloff: keep fo:hyphenate in character formatting".
            
            Change-Id: Ief37df057bec1ea286c7334a200fe6abcc8995d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165565
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-04-01  Mike Kaganski  <mike.kaganski@collabora.com>  [dff57d2b4f5abd1b51ebfb0015339471f61e72f9]

        tdf#160436: fix glyph bounds calculation for vertical glyphs
        
        It is unclear if LogicalFontInstance::GetGlyphBoundRect can be called
        for both normal and rotated variants of the same glyph in the same font.
        If yes, then the normal and vertical variants must be cached separately,
        or possibly vertical variant can be not cached, but always calculated.
        This problem already existed before, so this change doesn't introduce
        a new issue.
        
        Change-Id: I9b50ef340c9e38db7bef890165519aadc96d3ffa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-01  Mike Kaganski  <mike.kaganski@collabora.com>  [8962141a12c966b2d891829925e6203bf8d51852]

        tdf#160430: Fix glyph bounds calculation, and use basegfx::B2DRectangle
        
        ... instead of tools::Rectangle.
        
        Several problems were there:
        1. First, a horizontal bounding rectangle was calculated, with due
        rounding; and then the result was rotated, and after that, rounded
        again. That made the resulting rotated rectangle coordinates very
        imprecise.
        2. Also, ceil/floor was applied without normalization; and in case
        of rotated font, that meant, that sometimes the range could be not
        expanded to cover partially covered pixels, but instead collapsed.
        3. The rotation to angles other than 90 degree multiples was done
        incorrectly, resulting in cut off parts of characters.
        4. For 90 degrees, the imprecise result of sin/cos converted 0.0
        into values like 3e-16, which then could be ceil'ed up to 1.
        
        Using B2DRectangle and its transform allows to simplify and fix
        the calculations easily, and avoids premature rounding. Render of
        rotated text of small size is more stable with this change.
        
        Change-Id: Idffd74b9937feb2418ab76a8d325fdaf4ff841b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165553
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7c18a0bb37fc2cd50bd3fa4386b02d88fbedb773]

        tdf#146619 Drop unused 'using namespace' in: framework/
        
        Change-Id: I03d2d3d07d0d71800df624510b5e20bd5e0588e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165531
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [df58dfef115fe4589dfbfd6e6d348f24ce7ef2e9]

        tdf#146619 Drop unused 'using namespace' in: drawinglayer/
        
        Change-Id: I6d034b6c191885b25ad34f0d75ed870970b5fd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165527
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Julien Nabet  <serval2412@yahoo.fr>  [d75979503b738ca3233b12f9442394f2fc2ff528]

        gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed (docking3deffects)
        
        Change-Id: I9c9cb39716ff99808db66404853252295fda6336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165601
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b4a83e5b3ba1db9ce615a7c1fa1145ab64bd727e]

        tdf#146619 Drop unused 'using namespace' in: accessibility/
        
        Change-Id: I92662f0577c0f90ec0dc5eba1b685fbb7ac3da39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165530
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [33e0874d43a5e77a22f577e8613a01022e35d5fe]

        tdf#146619 Drop unused 'using namespace' in: connectivity/
        
        Change-Id: Ie185575d699751b79e98c4fae0bc5405a165df9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165529
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d7acb0fc227732d4537111eb88308bca922b1bc2]

        tdf#146619 Drop unused 'using namespace' in: xmlscript/
        
        Change-Id: Ic9874b77bdbb1d30fb587c5c8bbd62e4811c71e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165528
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-04-01  Julien Nabet  <serval2412@yahoo.fr>  [4317a448cf4b5bb0d64acddd178c89f6a8effd5d]

        remove unused suppression
        
        since fe4cd0cebdbf9412e26f8182e79f97bb844d94af
        Date:   Thu Feb 22 14:09:12 2024 +0100
        Set button label directly in ui file
        
        Change-Id: I53a39dffe79c5c5c4c4c8a0d95a333ba3af833bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165603
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-04-01  Julien Nabet  <serval2412@yahoo.fr>  [1731c3fb2084c02cb0882a5c8d72fc040644c278]

        NewDoc/AutoPilot is for Impress only
        
        Fix this log:
        warn:unotools.config:582397:582397:unotools/source/config/configitem.cxx:423:
        ignoring XHierarchicalNameAccess NewDoc/AutoPilot com.sun.star.container.NoSuchElementException
        message: "NewDoc/AutoPilot at /home/julien/lo/libreoffice/configmgr/source/access.cxx:442"
        context: configmgr::RootAccess
        
        Since 0e14912af0c449396f10c2ae4be3c7f2a3a98bc2
        tdf#157788 Saving the "Show navigation panel" setting for a device
        
        Change-Id: I82bfdbbfcb40219b3182e07b4099067fddb09a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165604
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cf01073667147f35758a2bde06aec666fc14898e]

        vcl: get rid of NO_PENDING define
        
        Change-Id: I90c3a29da63222bba2d497a27d7deec0865a6104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165211
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d8ece6a5f56f012ecf1766cc3f68c85706e3b6cb]

        vcl: remove partial XPM image loading
        
        This removes the code that handles the IO_PENDING and the graphic
        "context" handling from XPM image format.
        
        Partial loading of images complicates the image filter life cycle
        a lot (many exceptions) and is not really needed so much today as
        this was needed in the past. In most cases we load the whole image
        in one pass anyway. Even loading from the network should be fast
        enough to not cause issues for the user.
        
        Most image filters don't even implement this like PNG and nobody
        noticed for many years that this is not supported.
        
        To handle IO_PENDING case it is probably better to load the
        bitstream into memory and then load the whole image after that
        in one pass. This can also be implemented all inside (Imp)Graphic
        in a very straight forward way.
        
        Change-Id: Icdc4f042b38936e3d9f11d7026fd8525a6f46943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165210
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [350c590620226c4d5b94aa01d3853e15af3cebb0]

        tdf#160356 Add support for hidden named expressions in Calc
        
        Since bug 154449 was fixed, Calc now supports hidden named ranges. However, named expressions were not considered in the original patch and it would be useful to support hidden named expressions as well.
        
        This patch adds suppport for hidden named expressions (import and export).
        
        Change-Id: I2580416dcd5db0fcb2aa9061085cdc9975fb03c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165239
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-04-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [069bf61cea5e3aea07ffd5a1bb9f55324651cb35]

        Fix abbr.
        
        Change-Id: Ia1f8f1527e76f2a721d42f6de11122f8c167bc96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165589
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-04-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c2db961ee69c4fe6a7f7162f2adf712651b6ffcc]

        lcms2: upgrade to 2.16
        
        * backport 0001-Added-missing-export.patch to fix the Windows build.
        * drop c++17.patch.1, which fixed uptream.
        
        Change-Id: Ib658ba3067c35ca5cd1ccb7b3f0f2f3bc9f82a43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165350
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b7d6f7e2ef4e89607d7886e821be977c50f11843]

        Fix typo
        
        Change-Id: I606c3eb804cba508638ac401b35a8bea4e961807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165588
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bee080ab7ca21d05de0519361a19724ef609a86b]

        Resolves: tdf#154072 no effect when clicking some dropdown buttons
        
        when toolbar overflows.
        
        A problem since:
        
        commit b534ee2e972711af2dbaadf2190813054adda902
        Date:   Tue Nov 22 11:33:23 2022 +0000
        
            Resolves: tdf#152155 use gtk's knowledge of relative widget positions
        
            rather than effectively emulate it poorly
        
        Change-Id: I18c08e43e9c0b642f2a30b5114d6f0a53f18a331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [3b85fd8a27edb7b9a0d92bad7969ef551d11450f]

        tdf#146619 Drop unused 'using namespace' in: sdext/
        
        Change-Id: I8c5012958f6e59ec11c8a7bd52592e30cce4117a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165525
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [193bb41859a8b29904685bc6c544809fcb4b8f50]

        tdf#146619 Drop unused 'using namespace' in: fpicker/
        
        Change-Id: Ie090afbe19bffc493918ca19318ed16ac569bb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165526
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f558872f9184d35c6ef21823645e0297165b2ca5]

        crashtesting: crash seen with multiple threads calling GetTheCurrencyTable
        
        seen with soffice --convert-to xlsx forum-mso-en4-207468.xls
        
        Change-Id: I89d16938b3f8780776f38b0e94ce3885d93ac252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0544fb193b949dbcff97e8c475063dd72583ad1d]

        Resolves: tdf#157587 IconView scoll range not updated
        
        IconView::SetUpdateMode(true) doesn't update the scroll
        range for any changes that might have taken place while
        updates were suspended.
        
        The similar SvImpLBox::UpdateAll() for "normal" lists
        does this update, so do the equivalent update here too.
        
        Noticeable since:
        
        commit 666925f2ab06e690c41c470713dc83f2d752bfb7
        Date:   Sat Jun 3 15:23:15 2023 +0100
        
            perf: use freeze/thaw around block insert of multiple icons
        
        Change-Id: I318fc4509c6906161eabf3b312f311cb97ac063a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165584
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [601dc3ef9bd74b1948274c104c6c2ec877bc812c]

        Resolves: tdf#152438 constrain popups from MenuButtons with toplevel parent
        
        if the toplevel parent is the application window, then under wayland
        constrain the popup within the toplevel window, but allow it to escape
        if the parent isn't the application, e.g. a dialog
        
        Change-Id: I8d5c423a2c8e034464f110e51df04dee587f40dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165590
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [2b427f319a7a95c48beda13913a067d24bd82cf8]

        Simplify a bit
        
        And make font size calculations consistent between SkiaTextRender (x11)
        and WinSkiaSalGraphicsImpl (win). They already did ~the same, the win
        case just used an intermediate 'getHScale' coefficient.
        
        Change-Id: I90ad4d9c49427465ef3263843b34bd9bc0d762eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165488
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [e2717b81ff55f43a3953761b55b714ad0bf558ac]

        Optimize trigonometry a bit
        
        Change-Id: I2b06c29f6090233325c7ca24fac6d76190d502ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165486
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4bcb8b4fb23a62e3b75a686263006c47ad8c04b]

        convert SortableGridDataModel to comphelper::WeakComponentImplHelper
        
        Change-Id: If399c0fb6b82672edccbefa2b980737ccca98c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fa0669e1790d4358fdac7d160c4bf57a5254425]

        convert VCLXToolkit to comphelper::WeakComponentImplHelper
        
        drop the use of a mutex in methods that do not actually touch
        object-local state
        
        Change-Id: Idca1d1f8b25773f622189871da335012497cbf5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165578
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f7a7cf0eca793a9efb8456f96ccfece07f6f9d9]

        Resolves: tdf#157258 "Always autocorrect to" deletes the word
        
        instead of replacing it, affecting extensions like Grammalecte,
        LanguageTool, Antidote
        
        this began in:
        
        commit afa35742a4633db31b6d6c72cf45741506e9edfb
        Date:   Sat Dec 11 21:09:39 2021 +0000
        
            prefer more css::awt::XPopupMenu api
        
        but the underlying trap was introduced in:
        
        commit 6c84dc18062ec6aad71fd65a409373c274402991
        Date:   Wed Oct 6 10:16:39 2010 +0100
        
            initial commit for vba blob ( not including container_control stuff )
        
        which added creating a VCLXPopupMenu in VCLXMenu::getPopupMenu if there
        was a vcl PopupMenu in the vcl Menu which hadn't been created by calling
        VCLXMenu::setPopupMenu. That didn't take into account that VCLXPopupMenu
        (like VCLXMenu) takes ownership of the PopupMenu and will destroy it in
        its own dtor, so the sub menu Popup get destroyed if the VCLXPopupMenu
        is shorter lived than the VCLXMenu wrapping the parent Menu.
        
        Change-Id: Ic28c27670d846ee9d2ff77d834e43fc157924eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [da4f91bd4042f2c0ddd65c76d4ad5c35dbf3e1aa]

        tdf#146619 Drop unused 'using namespace' in: vcl/
        
        Change-Id: Id25d5e3dbf84dea1f9aca5a6ec921d30cbe84bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165524
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [35fbbbe12d101a626fcb1679cc6c0d79922a4cc3]

        tdf#146619 Drop unused 'using namespace' in: svl/
        
        Change-Id: I5629f6d5940ebc76be72970606111459d21ee1fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165523
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9a5b67ea271afc4449638207eecc52e88a7a891e]

        tdf#146619 Drop unused 'using namespace' in: package/
        
        Change-Id: I635a5c4bc988bff5a99f7d8487eb7c0f67c15d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165522
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [828ad91196826cda970f3894de516f91a82fd7de]

        tdf#146619 Drop unused 'using namespace' in: sax/
        
        Change-Id: I1959402cb06f051ffe5f4a7e2e9f591b4908ea21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165521
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2f068b2182955362526641da3b1e9f3207aab4b3]

        tdf#146619 Drop unused 'using namespace' in: unoxml/
        
        Change-Id: I66da7093f1ccb144e2831c6e20220cbd27e58c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165518
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [35fbe29161871b107f0aabf810a2537df378374d]

        Convert SfxDocumentMetaData to comphelper::WeakComponentImplHelper
        
        Change-Id: Ib633595008224ff11486e9ff72b6801d2dbfb887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c9d4f99b2bb54ac7735b3e0d0cadbafbd0279518]

        Fix typo in code
        
        Change-Id: I6babc5ec476a27fcecb582466183f999cf56757b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165577
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-30  Regina Henschel  <rb.henschel@t-online.de>  [9761d4239de6398d4f6ecf08356f2ce18e502a04]

        tdf#160421 flip lights too for flipped extruded shapes
        
        If an extruded custom shape is mirrored, the lights in the scene are
        also mirrored. This should not happen. MS Office keeps the light
        direction in relation to the camera direction for binary files and pptx
        files with legacy camera. We should do the same, especially since the UI
        does not allow the user to set the light directions at arbitrary angles.
        Otherwise the shape receives only ambient light.
        
        Change-Id: I091d78c581b3d247f8b0680cd57654e3df330cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165562
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f7ccf46b13ddf4501d5952ec38b1c680398f2101]

        tdf#146619 Drop unused 'using namespace' in: shell/
        
        Change-Id: I4194a1e3b92ec5bd25a8f313f7ff441566079bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165517
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a98fd3a9ae8740ba66b5b98dd18c27a83b475efc]

        tdf#146619 Drop unused 'using namespace' in: UnoControls/
        
        Change-Id: I6739c80a76289b042607a5b50ac04482f65b5a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165520
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8c84193d101dba72c74b92e8afa05c085b063713]

        tdf#146619 Drop unused 'using namespace' in: unotools/
        
        Change-Id: I7af4b514dac89b3dbacdc21705a90a91458b4487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165519
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e4ba9b13d81a9d2f7476bf4fbf21a9eb8dc2371]

        convert TitleHelper to comphelper::WeakImplHelper
        
        Change-Id: I81571a0786a4d13e049dba82ba6e4f3509887fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [62d5b1ae8db0292d03ee2747aab42bac8c0d3379]

        convert CanvasFont to comphelper::WeakComponentImplHelper
        
        Change-Id: I91aab0365aa57670d484228797f97a2675894cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [4673e96d3a292b8990450b4b13230f1e3cd158ae]

        Simplify and avoid const_cast
        
        Change-Id: I963bccd565750b41f16e3585f9a358678aa28500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165576
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [defca5551c404469028c51654b5d461a13f6614e]

        This should copy from source
        
        Was this way since initial commit
        
        Change-Id: I4159d8969853a9f1e226326bcd5180aedeed50dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165575
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-30  Glen Campbell  <campbellglene@gmail.com>  [9d28e7964bf0730dc03d40adfbab95dd9b5d087c]

        tdf#145081 Line spacing style type "Fixed" is not on the style sheet dialog
        
        Change-Id: I0dd668a2bedb16fe39793c5350c1d5a251949a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165400
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c9edd5e543c5c791171a4c40a226bf0f13a24d80]

        vcl: cleanup XPMReader class - rename members with clearer names
        
        Change-Id: I185a72a972d35c29d774a53476a345664497be6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165209
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d2cb896711a92ff5513a85efdc1fc656cf6976ed]

        vcl: remove partial XBM image loading
        
        This removes the code that handles the IO_PENDING and the graphic
        "context" handling from XBM image format.
        
        Partial loading of images complicates the image filter life cycle
        a lot (many exceptions) and is not really needed so much today as
        this was needed in the past. In most cases we load the whole image
        in one pass anyway. Even loading from the network should be fast
        enough to not cause issues for the user.
        
        Most image filters don't even implement this like PNG and nobody
        noticed for many years that this is not supported.
        
        To handle IO_PENDING case it is probably better to load the
        bitstream into memory and then load the whole image after that
        in one pass. This can also be implemented all inside (Imp)Graphic
        in a very straight forward way.
        
        Change-Id: Idb11f4ffa821467374b19f22b5841cfe940b9457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165208
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [95d7b543059be9cbf97fe28b1705be05b54a3b4f]

        vcl: add resetLastUsed to ImpGraph
        
        We reset the last used member variable in many places in the same
        way, so instead of duplicating the implementation, add that to a
        method.
        
        Change-Id: I747559ecf1a6736f976b4d560ab5052c19431898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165207
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [023ae9a825218686d444e2cbe770e743f70c73b9]

        vcl: cleanup and prefixmembers of XBMReader
        
        Change-Id: Ib424c3818a7441f9a1c3a7fb2be2d0a7b9682ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165206
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [324f2e135427f2f24cf7eb9a4fab4aa903329ae5]

        vcl: change (graphic) Manager into a general memory manager
        
        Graphic memory manager was changes so that it can work with any
        object that implements a specific interface (MemoryManaged). With
        this it will be possible to use other objects (that take a lot of
        memory) to be managed by the manager. It is also a first step to
        move memory managin responsibilities away from Graphic and move
        it into the specific objects instead (BitmapEx, Animation and
        VectorGraphic).
        
        Change-Id: I7638bd89a1c9ece5c4bc95b506d2192492894ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164958
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [174430d7a831eede078b6718d991b506d39180f1]

        Related: tdf#160159 use a stock icon for the character map
        
        https://specifications.freedesktop.org/icon-naming-spec/0.8/ar01s04.html
        
        Where "accessories-character-map"
        
        is
        
        "The icon used for the ... character accessory program"
        
        Change-Id: I48c72aaa3827037eb6921571bcce061fe60ac135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08d394857cf238bf62402b75eedd2609a3455a41]

        ofz#67708 ignore oversized colspans
        
        that can't fit in SCCOL
        
        ignore negative colspan and rowspans too
        
        Change-Id: I79a010bcd7d9d84de70f6dac2e09614d6d448227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c465642781485cda41bf4bd4fd3e0c0b1c7e53da]

        Resolves: tdf#159498 Items in Template Manager dropdown should be left-aligned
        
        Change-Id: I72d32793814b28b7452be701f0732dbd9dbbcb37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165559
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [1b00c292754c529ca6615d6b39a8545f340c7f50]

        tdf#160378 Remove NewGlobalDoc from the Tabbed UI in sd and sc
        
        The command NewGlobalDoc is not supported by Calc, Impress and Draw, so they should not exist in the Tabbed UI. Otherwise, a gap appears, since there's no info about this command.
        
        Change-Id: I0dd2b4639cfb44437d6726d6f138c4767c5a3175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165351
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-30  RMZeroFour  <ritobroto04@gmail.com>  [599b113b732190749385293a9fbc8ffc3e618556]

        tdf#42982 Add error messages to thrown exceptions
        
        As part of the efforts in #42982 to improve the UNO API
        error reporting, this commit adds error messages in several
        files to help improve debugging experience.
        
        Change-Id: I7a51d4fd1e3a57798d70bc3464b034649948a287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165253
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [13250e1aa589453534d113442da1ac8a2cbb71b9]

        tdf#146619 Drop unused 'using namespace' in: comphelper/
        
        Change-Id: I96982faf40e7654b0f8f26b666a17cbd057886a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165516
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a79f896728c5783c43d3ae337f982243b7679079]

        tdf#146619 Drop unused 'using namespace' in: eventattacher/
        
        Change-Id: I3231636dcf6367565a88b58bd9bba9a89f8ec749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165515
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f3be365d71d8613165abf751d295b4d83a0caddc]

        tdf#146619 Drop unused 'using namespace' in: stoc/
        
        Change-Id: I86e2dd229e377995e52d323b1b5be5a9a280b68f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165514
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [b5c40d4864b07861e889244834635c8cfc957d6e]

        Fix extended tips
        
        Fix wrong dialog names in extended tips.
        
        Change-Id: I60a91c6a06afdf0b993bd65dae8a2e3c6413528a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165122
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [0c5f0e5dbb482bfc62059a0f586efce6e7b292fe]

        resave latest glade
        
        Change-Id: I9d0bebea5382c297c9e04caa9d9677720d373069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165198
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-29  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [40d3d510fca99b555381deb74b9915c91c924de5]

        tdf#157285 PPTX import: fix placeholder height
        
        The "TextAutoGrowHeight" property doesn't shrink the shape automatically
        when its content is smaller than the current size.
        
        Change-Id: Ia7f94d7452d1a1c3f004aebd73b6ed5cbfd9b43b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165551
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-03-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4f13c6c5cbd958cbd3cb79385335abe512bb6de2]

        tdf#146619 Drop unused 'using namespace' in: ucbhelper/
        
        Change-Id: I9083ff77bc80fb1eb35305cbd3fb55bb25817b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165513
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6d3f6e77e1a21e53343339545502feecc69e6c78]

        tdf#146619 Drop unused 'using namespace' in: io/
        
        Change-Id: I5cfd37be41e1d364f8d50b3a547453d418abb86d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165512
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b6f5472ea147230b07a04f5677e1de8ea149cea5]

        tdf#146619 Drop unused 'using namespace' in: cppu/ cppuhelper/
        
        Change-Id: I4658c2a5c780fa5e8dd83381eb9978510973e0a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165511
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e2e9eeb822928255b3f2a31dfe98344f6d8e81cd]

        tdf#146619 Recheck xmloff/*cxx with IWYU
        
        after cleaning up unused 'using namespace' clauses
        
        Change-Id: I9e4cd3790408ae6b0379819a8275feaf67e860cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164941
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [18d0b7ac865f8d905a8b9afbe56677c89b1f406c]

        Resolves: tdf#160368 crash on save after deleting sheet
        
        to reproduce the underlying problem: data, calc, recalculate hard:
        
        which asserts that cell I367 is dirty during parallel calc
        
        checking the dependencies for a parallel calc is supposed to find what
        cells it depends on and either: ensure they are not dirty or detect its
        not possible to do the parallel calc
        
        checking starts in J9 where::
        
        J9:  =SUM(H$8:H9)-SUM(I9:I$9)
        J10  =SUM(H$8:H10)-SUM(I10:I$9)
        
        for the first sum it detects that the input range is H9:H367 and checks
        that for dirty results, but for the second sum it detects a range of
        just I9 and the dirty I367 is not detected and the problem arises on
        calculation
        
        The code to detect the range is:
        
        // The first row that will be referenced through the doubleref.
        SCROW nFirstRefRow = bIsRef1RowRel ? aAbs.aStart.Row() + mnStartOffset : aAbs.aStart.Row();
        // The last row that will be referenced through the doubleref.
        SCROW nLastRefRow =  bIsRef2RowRel ? aAbs.aEnd.Row() + mnEndOffset : aAbs.aEnd.Row();
        
        where for the I9 case has nFirstRefRow true and nLastRefRow false so we
        just get a range of I9:I9 instead of I9:I367.
        
        Trying to create a doc from scratch to reproduce this case proves
        tricky, so trim down the original document to the sheet and subset
        of columns that can trigger it.
        
        Change-Id: I44bfd1f6d3a3ee13db9024c5b2efa2588cc30521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165510
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e94c6761260ae30f1e4b91d65f8a5493dc8a3140]

        Resolves: tdf#160028 Type to select currency in dropdown does not work for gtk
        
        LibreOffice embeds RTL/LTR direction markers in currency strings, which
        defeats the default gtk search mechanism, so switch in our one instead.
        
        Change-Id: Ia118f8c8e27103c21955683f8a2fd3c17c2b2098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8303ffcb807abeeb168e8071778dab5601f1d839]

        resave with latest glade
        
        Change-Id: If56e9d6c09b9622670ef37e235dde8be2c3ca88e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165556
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [26f6145b9af5738d5d3b8fe641b99b3908d81e55]

        Resolves: tdf#160159 update spellchecking area colors when style changes
        
        so for the case of using "automatic" for the document background the
        spelling checking textbox background area updates to match
        
        Change-Id: I8723afb946176596b0a5fa43aa3bb3c036dee12c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165554
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cc99a2550eac39b9241dec307e66bfdcc005388]

        convert PlayerListener to comphelper::WeakComponentImplHelper
        
        Change-Id: I167354cbf998dd08ef8b5ffba744758539cabec5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165547
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [661ed018fabf3c382867b91828fb8e69d359d9cb]

        convert SvxDrawPage to comphelper::WeakImplHelper
        
        Change-Id: I72ea1f08c3c531cee3ac9301aaf87c76f95de3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165549
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [117f4c05614a5c3f5d0495dab553f76a173dbeea]

        speed up ScPatternAttr
        
        we know that ScPatternAttr uses a single, contiguous range of
        item ids, so we can compute the item offset at compile time.
        
        Shaves 1-2% off some workloads.
        
        Change-Id: I623b8cb3e0d5d070118117196d2b48575f505725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165550
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6fdbbc1622a929e2699a67496a38431652eebdf]

        use std::mutex in StatusbarController
        
        remove some locking in reportdesign::OStatusbarController -
        those places are already locking using the solar mutex
        
        Change-Id: I76d8e3a7ad60e4a2be1f0aac42967553356e9202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165548
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [454da7750db671c1f82fec4706de9a44c29b3e2e]

        cid#67704 Integer-overflow
        
        Change-Id: I42aa4b3e43636bf6f0c0f77c5028501229badee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Aaron Bourdeaux  <abourdeaux@csumb.edu>  [6c358c28c5cc2d1d8d8bb9d1238e3546a9bf3ce8]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I529096d97991a89bdc68ec7f5d490ec21744fc6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165499
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [69a8adcc76de2d827d109d2c66e1d0c64a1e6a52]

        Use default HIDs in Gallery, simplify code
        
        and copy relevant help texts from helpcontent to .ui file
        
        Change-Id: I3791f7843d6d8a0285d0d3369c867e6b165a582f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165021
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-29  wilmhit  <wilmhit@disroot.org>  [b4134d3554711bfb1c05e8f36f9f4b5bc52aec3f]

        tdf#143148: Use pragma once in dbui addresslistdialog
        
        Change-Id: Id0ebec238de937482111760f0a9732b621d082af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164952
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-29  U-Aarons_Laptop\Aaron  <abourdeaux@csumb.edu>  [cd72cefbc7b8abbdc5a66366e59ec81681d74aba]

        tdf#143148 replace include guards with pragma once
        
        Change-Id: Idd8ecf3ef95ce2296b31a1c7fb1ddadefdd573f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165293
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64fa566e659112b46d063dc0e0a89fe8f8065235]

        ofz#67699 Integer-overflow
        
        Change-Id: Ifb949cb4816c21587f337827fe50f993a64a3f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165509
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a39399f263c1e791c883c7cf866f9ee377b1a474]

        pre-thread -> per-thread
        
        Change-Id: I1b5fa94370fc9432d76b25fe9cf663c926c32a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165508
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e8e0a3b1d7e706330ca343cf9dd5ba062e9ff0c4]

        crashtesting: fix SvNFEngine::CacheFormatRO assert
        
        since:
        
        commit c6c6126aa3e8de256091b829b98b5943db6a8be6
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Thu Mar 21 17:25:35 2024 +0000
        
            Related: tdf#160056 refactor SvNumberFormatter
        
            to split it into two constituent parts
        
        Change-Id: I4add9f383789ab03ceab751b07973448a41911ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [40176bd39c94c32ac0269d9994e8e50518d84467]

        Simplify a bit
        
        Change-Id: Idb10d594829eeffd9b37e5ae971283b2a9730168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165475
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [20b0ea97b047fb57ceb8afb39bdcf5a428f8f691]

        Avoid bitwise assignment operators on bool
        
        Change-Id: I77509caf437c02792c34385cdf115f2c2a673754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165474
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b7e49aa5d39aefe20933ce1a6851dbe7675e5f1]

        convert SolverComponent to comphelper::WeakImplHelper
        
        Change-Id: Ia5accd94c3a3b498aa31829832110ec07b780112
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [973d1d888738ca574f2b288f1d5a25814713c760]

        convert SwarmSolver to comphelper::WeakImplHelper
        
        Change-Id: I20a97cd2355648d02c1bb9a4d999c5a6ed4470a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165492
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e048c3c572dc02f1161744278d875c9f842574e]

        convert BasicScriptImplodNodeImpl to comphelper::WeakImplHelper
        
        and remove OBroadcastHelperHolder, since nothing uses it anymore
        
        Change-Id: Id07b4589e0893950974c6bf41e0d4f2d8dc7ee81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165491
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [97c791d42f049763b0d3b01b4d2dc75cede9e858]

        convert VCLSession to comphelper::WeakComponentImplHelper
        
        Change-Id: I74bc44f84dd6dccde602c31a0f87a1780e3e7231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165495
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d547ad77555fc0dce5ecf3c55b44f5ce7eade7cd]

        convert NameContainer to comphelper::WeakImplHelper
        
        Change-Id: If89ee5bf200affc04704b7f075f25cbf599c1e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165494
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [c40a1201f90cec8d5490b3330fd990fc5546cfad]

        Drop a const_cast
        
        Change-Id: I3eb4547c71768d81bc351f9cb8d0ed1e07c9ebc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165504
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [291c90811ada39ed079d458887a59fc8977494f6]

        Simplify a bit
        
        Change-Id: I2a5b870516d8b597ebf476c7c1da7549a27571ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165503
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ff7a6711277bda28711cc92540fbd62ebaaf8db7]

        Simplify and drop unused method
        
        Change-Id: Ie987bce2bb25232d54a4a83631c609ad6dba7213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165467
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [aef28c23adc87b8e26eacb56c7dbcf652e907fb9]

        IASS: Update NextSlide in PresenterConsole
        
        Change-Id: I6060e95aabfdb5956bf2f4a71d047bdf5c97a723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165458
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3027850e18eb2983e26d2535c33ff79eaa756af9]

        IASS: SlidePane/Sorter updates were missing
        
        Change-Id: I75ce5311a74f15397dd5a1762e17ddff3203fc7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165468
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ca268b484c51f1ef839e6d39001ac18f17b48730]

        Fix typo
        
        Change-Id: I082d3bd5f60d9f1c9b99f0505256e3c8ef2d124d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165496
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12e28267884e8225a7401037048196766573fb58]

        Fix typo
        
        Change-Id: I3e20fda4b841458e979258dd5dc83c7f89f48083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165497
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-28  Dione Maddern  <dionemaddern@gmail.com>  [8533d3f05a4339e945131fd50bd01408ddf4b4f6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cff8d0c49290f86a40af8e258e37ace0d067afeb
          - tdf#147898 Remove obsolete instructions from Font Effects help page
            
            Removed 3 bullet points from the "Font Color" section of text/shared/01/05020200.xhp because the features described no longer exist.
            
            Added additional How to Get instructions to explain how to access the feature from the Tabbed UI and Context Menu.
            
            Change-Id: Ibe299f91c46dbb090391b127accfa02dd97c1809
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165429
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-28  Sahil Gautam  <sahil@libreoffice.org>  [14396a5361ef72afc99033d4cac29aaeb1ffa2d8]

        tdf#123159 Make Hyperlinks keyboard accessible
        
        Extend .uno:OpenHyperlinkOnCursor to open all hyperlinks
        in a cell, when not in edit mode.
        
        The UNO command can be assigned to a keyboard shortcut from
        `Tools > Customize > Keyboard`. If the active cell is not in
        edit mode, then pressing the shortcut opens all the hyperlinks
        in the cell. If in edit mode, pressing the shortcut opens the
        hyperlink under the caret "|".
        
        Change-Id: I7ffdab54fa31b9f7f614e04cc3158d8be217825e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157666
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-03-28  sahil  <gautamsahil1947@gmail.com>  [dbb0892ad1f576de4b4910c4b1683f3c88a7c0e7]

        Refactor ScGridWindow::GetEditUrl()
        
        To avoid code copy/pasting, common code is refactored to
        `lcl_SetEngineTextKeepingDefaults` to be used later in
        tdf#123159
        
        Change-Id: I1889c8eee931ef8950e95af8aec73a1884b07302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158516
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-03-28  Sakura286  <sakura286@outlook.com>  [4becdfe1ef8df45c4e1385d51f82fcae7f835e78]

        riscv64 bridge: replace tab to space in call.s
        
        Change-Id: I357f400050444336e26e73e1099b4b8ab9e8bdd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165454
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-03-28  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [68c7d719cdfcdd2136b27d0cbfcc54190e95649e]

        update PCHs in xmlsecurity
        
        Change-Id: I198af12fd6dbe3b218239e3532862cb70b571853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165040
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-28  Sakura286  <sakura286@outlook.com>  [18d989fe1edd33d74e60184fbad82562ec703d74]

        riscv64 bridge: switch CRLF to LF in abi.cxx/hxx
        
        Change-Id: I810f2681f61336eb823ab1eed89389d18b95dc75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165452
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bddb0d87e809c96ee810de0e553f02bbe158907d]

        Missing include
        
        ...presumably since 50897e3fe001aeae5a6091ede155088461c798f3 "Drop transitional
        header xmlsecurity/xmlsec-wrapper.h",
        
        > xmlsecurity/source/xmlsec/xmlsec_init.cxx:29:9: error: use of undeclared identifier 'xmlSecInit'
        >    29 |     if( xmlSecInit() < 0 ) {
        >       |         ^
        > xmlsecurity/source/xmlsec/xmlsec_init.cxx:55:9: error: use of undeclared identifier 'xmlSecShutdown'
        >    55 |         xmlSecShutdown() ;
        >       |         ^
        
        etc.
        
        Change-Id: I1aab4bb3601102c4ac0025833b03fa35adc9434e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165465
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0ce23697cf9ab8e590b41bf5eced515d5f0eb9d9]

        -Werror,-Wunused-parameter
        
        Change-Id: Ic7d32200332554b0a615120f69e4c86e612450c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165466
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [128274d59847288d4c3463fea42b6f57ec089ec0]

        svgio: simplify code
        
        Change-Id: Ieead2322e74829f187abf84dacbe8b107ea5130e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165450
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [403abdc86af5f7ec145d14e2315493c510b1b869]

        disable part of tdf150443 UITest for now
        
        Very unreliable.
        
        Running
           make UITest_writer_tests8
        by itself will fail 50% of the time for me.
        
        Change-Id: I841429d69249f3dd302013b781e7664d25e1387c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165453
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [35d9d669f26663d8fc71f9a67bbaf94bc90d4b25]

        convert OXSDDataType to comphelper::WeakImplHelperBase
        
        Change-Id: Idb299ea698480d0b98ac0deff9d1f9b87e749782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e8fb02d75eea17d41bbf76d40de723162968f27]

        convert BasicMethodNodeImpl to comphelper::WeakImplHelper
        
        Change-Id: I568800deabc82185afafc4415efd55bbe762901c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165444
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Patrick Luby  <guibmacdev@gmail.com>  [27b68ea28aecfce3007ed304399ee84190f4f747]

        Correct typo in comment
        
        Typo was added in commit 6a049e417b029f3733fcee05f99a3e8875aefdb8.
        
        Change-Id: Icfe61fde3b199505ae2107f1b790cf94ac98c456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165462
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6931a596350086d52ba32bf8a84cb36fbfdb34d6]

        tdf#160399 speed up print preview
        
        takes time from 11s to 5s for me
        
        Change-Id: Ic874b9168f9caaf697007e586df8499a849ccfd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [02b5bf515dfc29dc72075d355a07e6497a88b57c]

        convert EventListener to comphelper::WeakComponentImplHelper
        
        Change-Id: I3c83fabae8e2fc6a32fe92a596ed93ebc00140fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165443
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [989b4f318339922080e8fa6ead14076b5d6402db]

        Add comphelper::WeakImplHelperBase
        
        in the same way I added WeakComponentImplHelperBase
        
        Change-Id: I26d93004c3ddf716063cfb2ded1bbda1b76c2a98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165449
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3819e4f6f70ee60fc5c805f0d33c0062a396918c]

        tdf#160399 speed up print preview
        
        takes time from 5s to 2.5s for me
        
        Change-Id: I7e62e4a47d5b2aae982273cc3ea38c5c9b04256d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ec7c4eecf955090cc3bdd7a283aa5a291d12385]

        fix comparison of UIObject's inside UITests
        
        using == to compare them doesnt work, because we return
        a new one with every call to getTopFocusWindow and similar.
        So add a equals() method to the UNO interface to do the comparison.
        
        Change-Id: Ie909fe9b4e84fe07f4ca87bbebf65b56d3da8f78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Michael Meeks  <michael.meeks@collabora.com>  [ccc2e526d107a353469b5aad99e94544c07a10ee]

        lok: add isForkedChild method.
        
        This can be used to tag short-lived transient 'save' processes
        to encourage them not to mutate eg. filesystem state that is
        shared with the parent process.
        
        Change-Id: I027d18cbe4ce519b31c4fc1d3ac46b916d1efc87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165407
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 9dab5edb90d14ad6f71cc2ac96cc504c1e8c290b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165427
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86837b3d67cfe48a9983a13c5794147e192491a0]

        ofz: negative column offset
        
        Change-Id: Ieeb06e5c5d28f1c457db369a732bc37a7d5f2be8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [65bee6317eafd4d0e449c779c160e9b3017b57ce]

        libgpg-error: upgrade to release 1.48
        
        Change-Id: I3920d10657a91b56f484a5a61017d2e2ba3291b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165457
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-28  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [5fa3abd3b28b7c30d015dc058f7719112003f51e]

        tdf#158803 Remove unused imports from uitest
        
        Change-Id: I9808d74b5499660f80242c09f1ccfe4975e2b39e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165328
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4d923f9db926d8b0b6eb3bb7b62f5a7a520c00d]

        null deref of mpSidebarController
        
        follow the pattern used in the rest of this and skip the branch
        that depends on mpSidebarController existing
        
        git show -w
        
        Change-Id: I739754b2af7ad09fa80c36693d8adbf173ece2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165426
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  Mike Kaganski  <mike.kaganski@collabora.com>  [696e405a8d734e1440e3178a04cbb10190bbc4d7]

        Simplify a comparison
        
        Similar to commit 860548e23e2ae737d7bd5840f71f776b1239f997 (Simplify
        a comparison, 2024-03-07).
        
        Change-Id: Ia2ae4a9d23558842626b6e52a13bc1582bc35741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165422
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0343d7153e77ba79a59bc5f6c51159af9010813e]

        libassuan: upgrade to 2.5.7
        
        Change-Id: I6114c7a77395f14e83d2315ac6f9b6829ddb1c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165456
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c1a7cb13629177f824ed35138907aef10714e89]

        curl: upgrade to release 8.7.1
        
        Change-Id: I0064b4cf6baf1ccd951c95945539961fe72c2a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165455
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [50897e3fe001aeae5a6091ede155088461c798f3]

        Drop transitional header xmlsecurity/xmlsec-wrapper.h
        
        It was introduced with
        commit ec52e5e5a204862905b555cdc1f7393aede1f7d8
        and the reason of that was the XMLSEC_NO_SIZE_T behavior consolidation.
        
        But this was removed later with
        commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b
        
        Change-Id: Ib5350d9ab5554d1412821b762cd3ee7906b65b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165440
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-28  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [03b00e03c2cecdc6358e663be7b564c4ccec76f9]

        tdf#146619 Remove unused #includes from C/C++ files
        
        'xmlsecurity' module was cleaned.
        
        Add some headers from xmlsec-wrapper.h in preparation
        for its removal
        
        Change-Id: Id66e6d40d4d5d980626832c0e2f6255fc31b4bcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164639
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2d4406206bfad59c238a0d55eab32d6763226e6]

        add check to close_dialog_through_button
        
        to verify that the dialog did indeed close
        
        Change-Id: If591c9144b392a69bea0b380b4b6e4001a8382fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  László Németh  <nemeth@numbertext.org>  [28d1744552fc7d2144b77a07993918ef33905f1f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c5b2a36bde02841590b8ccc490ca88bfdb69f153
          - Hungarian dictionary v1.8.1
            
            Added new words, fixes, and decomposition data of ~6500 compound words
            for better hyphenation. See tdf#158885 for COMPOUNDLEFTHYPHENMIN
            implementation in LibreOffice, where Hunspell filters out compound word
            boundaries from libhyphen-based hyphenation breaks, restricting hyphenation
            near the compound boundary according to spelling and typography rules.
            
            Change-Id: I22a7b70513d0a59d7a31462fcb46efd53cfe8ad7
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/165439
            Tested-by: László Németh <nemeth@numbertext.org>
            Reviewed-by: László Németh <nemeth@numbertext.org>
            
2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b71e5ef440d3fa8ceac9dd3591171ad1a076bd4]

        prevent crash in SwModelessRedlineAcceptDlg destruction
        
        Seems to be timing dependent, does not always happen.
        
        Stack:
         #0 sal::backtrace_get(unsigned int) at sal/osl/unx/backtraceapi.cxx:42 (discriminator 1)
         #1 (anonymous namespace)::printStack(int) at sal/osl/unx/signal.cxx:289
         #2 (anonymous namespace)::callSystemHandler(int, siginfo_t*, void*) at sal/osl/unx/signal.cxx:330
         #3 (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) at sal/osl/unx/signal.cxx:427
         #4 __restore_rt at libc_sigaction.c:?
         #5 std::__uniq_ptr_impl<weld::ComboBox, std::default_delete<weld::ComboBox> >::_M_ptr() const at /usr/include/c++/13/bits/unique_ptr.h:199 (discriminator 1)
         #6 std::unique_ptr<weld::ComboBox, std::default_delete<weld::ComboBox> >::get() const at /usr/include/c++/13/bits/unique_ptr.h:470
         #7 std::unique_ptr<weld::ComboBox, std::default_delete<weld::ComboBox> >::operator->() const at /usr/include/c++/13/bits/unique_ptr.h:464
         #8 SvxTPFilter::GetSelectedAuthor() const at svx/source/dialog/ctredlin.cxx:636 (discriminator 1)
         #9 SwRedlineAcceptDlg::InitAuthors() at sw/source/uibase/misc/redlndlg.cxx:256
         #10 SwRedlineAcceptDlg::Activate() at sw/source/uibase/misc/redlndlg.cxx:492
         #11 SwModelessRedlineAcceptDlg::Activate() at sw/source/uibase/misc/redlndlg.cxx:123
         #12 SfxDialogController::FocusChangeHdl(weld::Container&) at sfx2/source/dialog/basedlgs.cxx:117
         #13 SfxDialogController::LinkStubFocusChangeHdl(void*, weld::Container&) at sfx2/source/dialog/basedlgs.cxx:111
         #14 Link<weld::Container&, void>::Call(weld::Container&) const at include/tools/link.hxx:111
         #15 weld::Container::signal_container_focus_changed() at include/vcl/weld.hxx:368
         #16 SalInstanceContainer::HandleEventListener(VclWindowEvent&) at vcl/source/app/salvtables.cxx:1328
         #17 SalInstanceWidget::EventListener(VclWindowEvent&) at vcl/source/app/salvtables.cxx:824
         #18 SalInstanceWidget::LinkStubEventListener(void*, VclWindowEvent&) at vcl/source/app/salvtables.cxx:821
         #19 Link<VclWindowEvent&, void>::Call(VclWindowEvent&) const at include/tools/link.hxx:111
         #20 vcl::Window::CallEventListeners(VclEventId, void*) at vcl/source/window/event.cxx:257 (discriminator 2)
         #21 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3438
         #22 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #23 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #24 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #25 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #26 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #27 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #28 vcl::Window::ImplCallActivateListeners(vcl::Window*) at vcl/source/window/window.cxx:3442 (discriminator 1)
         #29 vcl::Window::ImplGrabFocus(GetFocusFlags) at vcl/source/window/mouse.cxx:386 (discriminator 15)
         #30 vcl::Window::GrabFocus() at vcl/source/window/window.cxx:2989
         #31 vcl::Window::dispose() at vcl/source/window/window.cxx:433
         #32 Control::dispose() at vcl/source/control/ctrl.cxx:66
         #33 SvTreeListBox::dispose() at vcl/source/treelist/treelistbox.cxx:1341
         #34 SvTabListBox::dispose() at vcl/source/treelist/svtabbx.cxx:244
         #35 SvHeaderTabListBox::dispose() at vcl/source/treelist/svtabbx.cxx:529
         #36 VclReferenceBase::disposeOnce() at vcl/source/outdev/vclreferencebase.cxx:38
         #37 VclPtr<vcl::Window>::disposeAndClear() at include/vcl/vclptr.hxx:209
         #38 VclBuilder::disposeBuilder() at vcl/source/window/builder.cxx:810 (discriminator 2)
         #39 VclBuilder::~VclBuilder() at vcl/source/window/builder.cxx:805
         #40 std::default_delete<VclBuilder>::operator()(VclBuilder*) const at /usr/include/c++/13/bits/unique_ptr.h:99 (discriminator 1)
         #41 std::__uniq_ptr_impl<VclBuilder, std::default_delete<VclBuilder> >::reset(VclBuilder*) at /usr/include/c++/13/bits/unique_ptr.h:212
         #42 std::unique_ptr<VclBuilder, std::default_delete<VclBuilder> >::reset(VclBuilder*) at /usr/include/c++/13/bits/unique_ptr.h:510
         #43 SalInstanceBuilder::~SalInstanceBuilder() at vcl/source/app/salvtables.cxx:7456
         #44 SalInstanceBuilder::~SalInstanceBuilder() at vcl/source/app/salvtables.cxx:7457 (discriminator 1)
         #45 std::default_delete<weld::Builder>::operator()(weld::Builder*) const at /usr/include/c++/13/bits/unique_ptr.h:100
         #46 std::unique_ptr<weld::Builder, std::default_delete<weld::Builder> >::~unique_ptr() at /usr/include/c++/13/bits/unique_ptr.h:405
         #47 SvxTPage::~SvxTPage() at svx/source/dialog/ctredlin.cxx:289
         #48 SvxTPView::~SvxTPView() at svx/source/dialog/ctredlin.cxx:341
         #49 SvxTPView::~SvxTPView() at svx/source/dialog/ctredlin.cxx:341 (discriminator 1)
         #50 std::default_delete<SvxTPView>::operator()(SvxTPView*) const at /usr/include/c++/13/bits/unique_ptr.h:100
         #51 std::__uniq_ptr_impl<SvxTPView, std::default_delete<SvxTPView> >::reset(SvxTPView*) at /usr/include/c++/13/bits/unique_ptr.h:212
         #52 std::unique_ptr<SvxTPView, std::default_delete<SvxTPView> >::reset(SvxTPView*) at /usr/include/c++/13/bits/unique_ptr.h:510
         #53 SvxAcceptChgCtr::~SvxAcceptChgCtr() at svx/source/dialog/ctredlin.cxx:972
         #54 std::default_delete<SvxAcceptChgCtr>::operator()(SvxAcceptChgCtr*) const at /usr/include/c++/13/bits/unique_ptr.h:99 (discriminator 1)
         #55 std::unique_ptr<SvxAcceptChgCtr, std::default_delete<SvxAcceptChgCtr> >::~unique_ptr() at /usr/include/c++/13/bits/unique_ptr.h:405
         #56 SwRedlineAcceptDlg::~SwRedlineAcceptDlg() at sw/source/uibase/misc/redlndlg.cxx:210 (discriminator 3)
         #57 std::default_delete<SwRedlineAcceptDlg>::operator()(SwRedlineAcceptDlg*) const at /usr/include/c++/13/bits/unique_ptr.h:99 (discriminator 1)
         #58 std::unique_ptr<SwRedlineAcceptDlg, std::default_delete<SwRedlineAcceptDlg> >::~unique_ptr() at /usr/include/c++/13/bits/unique_ptr.h:405
         #59 SwModelessRedlineAcceptDlg::~SwModelessRedlineAcceptDlg() at sw/source/uibase/misc/redlndlg.cxx:141 (discriminator 1)
         #60 void std::destroy_at<SwModelessRedlineAcceptDlg>(SwModelessRedlineAcceptDlg*) at /usr/include/c++/13/bits/stl_construct.h:89
         #61 void std::_Destroy<SwModelessRedlineAcceptDlg>(SwModelessRedlineAcceptDlg*) at /usr/include/c++/13/bits/stl_construct.h:153
         #62 std::_Sp_counted_ptr_inplace<SwModelessRedlineAcceptDlg, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at /usr/include/c++/13/bits/alloc_traits.h:674
         #63 std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use() at /usr/include/c++/13/bits/shared_ptr_base.h:187
         #64 std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release_last_use_cold() at /usr/include/c++/13/bits/shared_ptr_base.h:199
         #65 std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at /usr/include/c++/13/bits/shared_ptr_base.h:354
         #66 std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at /usr/include/c++/13/bits/shared_ptr_base.h:1072
         #67 std::__shared_ptr<SfxDialogController, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at /usr/include/c++/13/bits/shared_ptr_base.h:1524
         #68 std::__shared_ptr<SfxDialogController, (__gnu_cxx::_Lock_policy)2>::reset() at /usr/include/c++/13/bits/shared_ptr_base.h:1642
         #69 SfxChildWindow::~SfxChildWindow() at sfx2/source/appl/childwin.cxx:197
         #70 SwChildWinWrapper::~SwChildWinWrapper() at sw/source/uibase/inc/chldwrap.hxx:27
         #71 SwRedlineAcceptChild::~SwRedlineAcceptChild() at sw/source/uibase/inc/redlndlg.hxx:144
         #72 SwRedlineAcceptChild::~SwRedlineAcceptChild() at sw/source/uibase/inc/redlndlg.hxx:144 (discriminator 1)
         #73 SfxChildWindow::Destroy() at sfx2/source/appl/childwin.cxx:177
         #74 SfxWorkWindow::DeleteControllers_Impl() at sfx2/source/appl/workwin.cxx:608
         #75 SfxFrame::DoClose_Impl() at sfx2/source/view/frame.cxx:137
         #76 SfxBaseController::dispose() at sfx2/source/view/sfxbasecontroller.cxx:930
         #77 (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1500
         #78 framework::CloseDispatcher::implts_establishBackingMode() at framework/source/dispatch/closedispatcher.cxx:536
         #79 framework::CloseDispatcher::impl_asyncCallback(LinkParamNone*) at framework/source/dispatch/closedispatcher.cxx:403 (discriminator 1)
         #80 framework::CloseDispatcher::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at framework/source/dispatch/closedispatcher.cxx:222
         #81 framework::CloseDispatcher::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/dispatch/closedispatcher.cxx:91 (discriminator 2)
         #82 comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at comphelper/source/misc/dispatchcommand.cxx:63
         #83 comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at comphelper/source/misc/dispatchcommand.cxx:76
         #84 UITest::executeCommand(rtl::OUString const&) at vcl/source/uitest/uitest.cxx:24 (discriminator 2)
         #85 (anonymous namespace)::UITestUnoObj::executeCommand(rtl::OUString const&) at vcl/source/uitest/uno/uitest_uno.cxx:63 (discriminator 1)
         #86 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:87
         #87 cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:229
         #88 unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:409
         #89 binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:239
         #90 binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79 (discriminator 1)
         #91 request at binaryurp/source/reader.cxx:84
         #92 cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:101
         #93 cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:169
         #94 threadFunc at include/osl/thread.hxx:190
         #95 osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:245
         #96 start_thread at ./nptl/./nptl/pthread_create.c:444
         #97 clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:80
        
        Change-Id: I5f1db80acaf4e9a5ad642baa7061d50af071ad5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c6075e716200e9c6bae1b10be2cf10013958e83a]

        tdf#159918 a11y check: Don't warn about tabs in ToC
        
        Change-Id: Ifde41deb66c8dcb72842e18e539609ff351be832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164972
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-03-28  Attila Szűcs  <attila.szucs@collabora.com>  [110eb4f6f8ed43faf7d2a4e74bfdcb93934f6439]

        tdf#153162 Gif load transparency optimization
        
        Converting a bitmap from transparency to alpha can be very slow.
        fortunately it can be avoided.
        Inverted the transparency colors (cTransIndex1, cNonTransIndex1)
        that are used to create aBmp1 in GIFReader::FillImages.
        It create the transparency bitmap inverted, so no need to invert it.
        
        Change-Id: I14714fe4b8bbcd7849db57b2824a7077dda40f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165261
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [147063f58c6b7898e659321f581ea9551305a574]

        Revert "tdf#158803 remove some unused imports, unnecessary semicolons and related styling"
        
        This reverts commit 9d4844374395ecce6b2ff4f9a71b3c8dae23050a.
        
        Reason for revert: fails in unit tests
        
        Change-Id: Icfaf6ab331ecce691b9a9462432e07c68d0fb40c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165417
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64a5509d9aef88c04dbaad7f553c2b83b23c045a]

        show this infobar regardless of the exact reason for presenting it
        
        Change-Id: I8af248efe8f9dda868e2f126beead875e391b563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165402
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [303ed9a9646256eb6841a21bab4a7fdfd3a0dc53]

        python exits on initialization if fd 0 is a dir
        
        which can happen if stdin was closed and the next
        open was of a dir.
        
        Later python checks for is_valid_fd, but an invalid fd
        is not fatal for stdin, etc and it just return an empty
        stdin wrapper, so move this check lower and do the same
        for a dir.
        
        Change-Id: Iaf8a48927b49408577ae7a781dfc6e0255a940cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  Hubert Figuière  <hub@collabora.com>  [460a7103664ac8dc60e260c56e5113d689b8072f]

        vcl: Implement JSLevelBar
        
        This fixes the JSDialog layout of the sheet protection dialog.
        This was introduced for 24.02 to provide password strength indication
        of the sheet password.
        
        Defined a new WindowType of PROGRESSBAR.
        The type property in JSDialog JSON will be "progressbar".
        
        Change-Id: I202528a81706943e1838f3c37fb555f4a1bf889e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165236
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [e347cff87bec2e8d802fb2dfb8abd3d7d94f8103]

        tdf#158803 remove unused imports
        
        Change-Id: Ie58bde91e1c96a32f02f64bc0eb8d864d3680e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165388
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [7397de2ec5f9f3c2b42861bbfb344c425ffba9ea]

        tdf#158803 unnecessary semicolons
        
        Change-Id: I19cd8fed788297bdc4b6b332b2f1768bc40fd00b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165377
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [12efa6c63c2bee0d74e378289dd43bbc58c01781]

        tdf#158803 remove unused path.convert_to_unix import
        
        Change-Id: I01b8626c95bc234db38c76ee2fc6a17c91aad477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165374
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [07efbe8f0bb46bba81396d081c456a09c93f842a]

        tdf#158803 colons missing for print statement, replacing basestring with str
        
        Change-Id: I06281836f7e373d039fd667235a8ed8ec0489807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165383
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [d4aef7fd04a1ee999b03194c01f4a792aa1846d8]

        tdf#158803 unncessary semicolons
        
        Change-Id: I47850382ee9c24762298b2e0927cf2b73469503c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165382
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [5e80aa818cae690c67361e85bd37124cec16c05e]

        tdf#158803 test for membership should be 'not in', unnecessary semicolons
        
        Change-Id: If468514ce934eb5a583630b2fbe8634a77a5ff94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165379
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [84188d15656a8b309216d4eba2fc47787ebcdf3d]

        tdf#158803 fix fstring
        
        Change-Id: I5443341ce308ea0f9906b54c02c51785aa624e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165375
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [9e424d98e5af9f6219398e02cb05c454471c237d]

        tdf#158803 test for membership should be 'not in', unnecessary semicolons
        
        Change-Id: Ib82e40a0ec0e6d6c7a363150d033b07a8d045a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165378
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [b470044cbf116b825ca86c1b054aaaaea7647646]

        tdf#158803 test for membership should be 'not in'
        
        Change-Id: I9ed1a2cb83cfd0be8298e7a90c7b4fb931c33528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165369
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [21fc89c651a8adece2571bf2e9b25a3bf0cd4f61]

        tdf#158803 unncessary semicolons
        
        Change-Id: I64cd7ed8d5f315e25a951cf74f1c425407d99aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165381
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [9d4844374395ecce6b2ff4f9a71b3c8dae23050a]

        tdf#158803 remove some unused imports, unnecessary semicolons and related styling
        
        Change-Id: Ie413ffd72b3d2f583d697ba89035d2a5d35bafe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165406
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [845dbe38844d90d4313652a7b390f3715fce6d7e]

        tdf#158803 remove unused imports
        
        Change-Id: If5b9a627d807f8bd6310ca1cc9753f331f012345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165385
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [9f4e04b2582971759d2eabb142d4fb1293bf00cc]

        tdf#158803 remove unused imports
        
        Change-Id: Id3e4434294386e0ca2a0971cf7e30aeface7b665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165384
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [d305470db4fef3b497675c3f5067f74e8333c652]

        tdf#158803 unncessary semicolons
        
        Change-Id: I1f4fc8661e31d7e17f4fd59988e15635f3318dc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165380
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [2db078c582fb254bc02322af41bda2a43dd91313]

        tdf#158803 statement ends with an unnessary semicolon
        
        Change-Id: Id67e1a7f944f0aa1aaa5d598305727c913d823cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165376
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [623ae0a44f55ca4bf6f99a0ea0e0dbe55a95ec67]

        tdf#158803 remove unused maths import
        
        Change-Id: I1d3d687a470ff5d197d8b9d174d37163319f121b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165373
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [8a92d296bee8ce3b010fab47c48d23f68c4b25a0]

        tdf#158803 filename is undefined, should be self.root
        
        Change-Id: Ib533900433586abb0eca01703452aa593d8f2016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165372
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  LeSasse  <l.sasse@fz-juelich.de>  [3f7923ebac4c87aa2966e6f19b506dfeda8fbdb8]

        tdf#158803 fix typo NotImplementedErrors -> NotImplementedError
        
        Change-Id: I2d75dc6a40c0f2ab294d3e279cc0ca7a0c8f619f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165371
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Leonard Sasse  <l.sasse@fz-juelich.de>  [6b62c11142ec24c34f6f607c3b0c467fb9bca439]

        sys undefined on line 138, sys added to imports
        
        Change-Id: I8b949fca7a8771745ee94fe6e7f72e0c4b496881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165370
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noelgrandin@gmail.com>  [e6bef01e23fb88d968c2a3568d1076dda77c2aff]

        reduce symbol visibility in svx
        
        Change-Id: I7a6795d04f9b21e5b46463dfe5d3dfb3a3cb6c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8093bd7017f2745d5048cdedcb9d61976bd3e69d]

        improve logging in UITests
        
        (1) log useful stuff that is happening instead of logging events that
        are __not__ interesting
        
        (2) add the UIObject title to the event so we know who the event belongs
        to
        
        Change-Id: Iea4b70c03482b10731f186d730afa12dac760fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b98856c59707037cc25ec7f2dae975bc269901d]

        prevent SEGV in ToolBoxUIObject::get_state
        
        if we call it while it has no current item id
        
        Change-Id: I0e62d35b24f18104f6fd55c129fd7f91f2449e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6658a384245f04b433fb540c757b9bd9be43e1c3]

        convert VCLXAccessibleListItem to comphelper::WeakComponentImplHelper
        
        Change-Id: I82b7dd9b0cdf379c710870a295c8f33ed9fff681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [7510cca63690ea97eb02a43f698fc183c3d0434a]

        convert OCellValueBinding to comphelper::WeakComponentImplHelper
        
        Change-Id: I007d0c44bed1ab9e00cadcdbd126bc6bf3d99ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-28  Patrick Luby  <guibmacdev@gmail.com>  [c4023d3ec604abfff38be2053e2989c7ec2ba8c1]

        Related: tdf#160184 clearly describe security risk
        
        Encrypting with untrusted public keys increases the risk of
        "man-in-the-middle" attacks so emphasize this risk.
        
        Change-Id: I48cbb7b002c5f17bdac3372bf94c1bc18ea68566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165396
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a2535ceb06bb9233bc2eeee9158d4c9d2513abd]

        tdf#160386: Add support for switch element
        
        For now, only use language tag, meaning if
        there is a file like in the unittest with
        
        <text systemLanguage="en-us">Howdy!</text>
        <text systemLanguage="en-gb">Wotcha!</text>
        <text systemLanguage="en-au">G'day!</text>
        <text systemLanguage="en">Hello!</text>
        
        "Hello!" with be displayed in a en_AU system locale
        
        This patch partially reverts 13a41e7a12598c7896d6dc8d34aba6af5b80b83c
        "tdf#150124: do nothing when parent is of unkown type"
        making 0dfd8288a87b58e503bb3a41be6137485fbf3f68
        "ofz#60384 Direct-leak" no longer necessary
        
        Change-Id: Ifc73bc69aa997088dc0a2b11d7d30446303fa3b3
        
        Change-Id: I885ef0f2c44b86196881fe55a963db2e5c7eb1be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165394
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b15374d1850de13e977cf4bb2106d38e74a030a]

        tdf#156579: svgio: Add unittest
        
        Change-Id: I77ab0c72209fa02c6e463351e8cda09213d47ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165399
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f89e03f3903474bc51ef8396eb366326cfc254c]

        Resolves: tdf#160392 preview's measurement are black on dark bg in dark mode
        
        Change-Id: I538750ef7d20ecc17a60ce47989eeaf0390a0103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3f1272c0e2e3aa30e6c781a2bcd83e98d62408b7]

        add notify for script use
        
        Change-Id: I84af197cec7755f6803a578e1e21c03966ad5f3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165403
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [7fa2a81f2f00fdad570a98f33acc45cd95af5ae6]

        CppunitTest_svgio: factor out common code
        
        Change-Id: I5171a07d9015706a89f25b0c2805ebed8444260d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165401
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [09920926b7ee038daec5c96361c70f66ed5f7265]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e8b0e4366701e46f775cca486ee65a1291c56456
          - tdf#159872 Help page for SORTBY function (final).
            
            Change-Id: If3f9746d20aa60bab06c2607e5d8fce557e91f75
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165431
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e27b9026e41cd3274f96bfc82c9555dbd9a204d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9736fda4e1a2994e1ea7377c37f61bad058f69b8
          - tdf#159872 Help page for SORT function (final).
            
            Change-Id: Ib3385327c2fab41a0a9d76bf8913e76c46864059
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165430
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7a15fcf9ca348f2cc6ffb57b8bc967ea899f755a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f4e1983f6edae8f5ce8ee2e319410d4e1e39084
          - Refactor help pages for some Calc functions
            
            Change-Id: I06a4b2da852cac91b41ac551c4f08ad78b7e3e47
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165409
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [9462674c6501f1d04bc7bdea08b6035bf88ae0df]

        convert ScChartObj to comphelper::WeakComponentImplHelper
        
        Change-Id: I94974713ce5acff13aa0c12a782f9f3fdf004f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165363
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a95bff116e1da140b9abe9742ceeb9a3caed43d5]

        convert OCellListSource to comphelper::WeakComponentImplHelper
        
        Change-Id: Iec9a3d20868c96dfe23141930b660e08773b5833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165362
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-27  Justin Luth  <justin.luth@collabora.com>  [c51f9f15b8c308e62b4839cc13d623fdab0486c2]

        tdf#131253 sw: draw frame text boundary if fly has textframe
        
        While the text boundary on a wrap-through frame
        will not need text boundary markers for the external text,
        it does have relevance for the internal text.
        
        Change-Id: Ica91dc42333a69cfecd10a72a1188d77d1dd4ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165395
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-27  Miklos Vajna  <vmiklos@collabora.com>  [261999bc552516a7dae0f96895259485e9ac77a2]

        tdf#109272 sw: add form filling testcase
        
        Open the document, press tab to switch to a field, start typing, nothing
        shows up.
        
        Looking at the doc model dump, it turns out we inserted characters
        between the field start and the field separator dummy characters,
        instead of the field separator and the field end ones, which is quite
        bad.
        
        Turns out that in the meantime commit
        c80606bb23fd42e41710d70a96b7ffaf948384a6 (tdf#109272: make sure that
        Delete / Backspace move cursor correctly, 2024-01-18) fixed this, kind
        of by accident: the comment says the motivation there was change
        tracking.
        
        Add a testcase to to make sure this now continues to work.
        
        Change-Id: I1a300d8064f7c2a30aafeefc6cb5612bfcd9a06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165368
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ddc398095bcbb288b1ef1ec3f01a52a615672f8]

        drop const_cast and be more honest that internal state changes
        
        Change-Id: I20dd009b2bd14cdf958572dabc7a7e565a2f98ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165393
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [381e257a814036df6baab4ddbb96371fba856acf]

        don't need to const cast here anymore
        
        Change-Id: I9d3502e9e16625135d2f065e39aec7ac6c6232ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165392
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Mike Kaganski  <mike.kaganski@collabora.com>  [d9c778391796e91ea3da361bf3901000350c26dd]

        tdf#160390: make sure to forward the iterator
        
        Change-Id: I302cc4303f083a1024175ce4ba00ce8021c6d4c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165390
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-27  Gökay Şatır  <gokaysatir@gmail.com>  [d5dccc8780c737c0f23164fd98669303e61ba737]

        Allow export commands in readonly view mode.
        
        (cherry picked from commit 5c8c5db55e082eed3422e3fb9455943b2f285253)
        
        Change-Id: I88e9a45fd9e5c7b6bf1984a424e36b010aaaff4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165389
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-27  Regina Henschel  <rb.henschel@t-online.de>  [207876cdcd7a4c19940d769a52d118751059dfe0]

        Restore shape rotation on roundtrip of pptx 3D shape
        
        As long as our support for extruded custom shapes from MS Office is
        rudimentary, we should restore the original values in case of saving
        to pptx.
        
        The patch uses the angle out of the interopGrabBag even if the user
        has changed the shape rotation. Considering a different angle would
        require to calculate camera, light rig and shape rotations. The effort
        for that is too large.
        
        Change-Id: Ib0549acc4ae13badd44fe9ae221a56ad21d28e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165359
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-27  Michael Weghorn  <m.weghorn@posteo.de>  [88f051257ebec4341864027f3af02e0f44df2367]

        clang-format CPDManager sources
        
        These will likely be significantly changed in the process
        of updating the code to support current CPDB
        (Common Print Dialog Backends) versions, see [1].
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2024-March/091748.html
        
        Change-Id: I2d8fe1cfedb703e4843ade261e5c09e24dfe30b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165366
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-27  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [d396aa36b0a91117345ef749396e6f20a5edb20a]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: I853cab70d24e4813d979f507dc5b66049cbca53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-27  Darshan11  <darshan.upadhyay@collabora.com>  [a69e32a0ca800642a3fb542c0a49a13ba04faecc]

        Send ParaRightToLeft state messageto client side
        
         - Before this patch in online text in paragraph was changing according to uno command but client was not getting and info about is RTL true or TRL true
         - this will send message [:unoParaRightToLeft=true || :unoParaLeftToRight=true] at client side
         - added more properties like disabled and state information to handle both case at same time in online
         - which will be helpful to our existing locgic where to add or from where to remove selected class on element according to response
        Change-Id: Ia443215342d6a81f4e60fa9237149f6b18420e16
        
        Change-Id: I08fb7e474e099822b26c732fe1e5dac8e773c58f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164767
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164817
        (cherry picked from commit fa93750070793cd548d028feb39e4d0e0e61ae5a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165324
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Pierre F  <fpy@bger.ch>  [a111a5c7f62611474d390aacb1ce5964df2a34f9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 093252967828e122a391226a7e1f0afa415f682a
          - misc link #FontColor.
            
            Change-Id: I947f35268ca756951e423cc86bde82c76c23120b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165002
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-27  Antony  <antonydas.nadar@collabora.com>  [896d6303040cb86813f1c5bc06bb830f512f3f22]

        cool#8456 : Convert bookmark rename dialog to async
        
        * Changed bookmark rename dialog from synchronous to asynchronous execution.
        * Removed the reference operator from variables m_xNamed and m_xNameAccess declared in swrenamexnameddlg.hxx to prevent use-after-free
        
        Change-Id: I2e4e777c5c56137504b646bdbe82e265ef73b2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164803
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 1222d98eaad463e35286f215b3bdeb909ea155bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165323
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  U-Aarons_Laptop\Aaron  <abourdeaux@csumb.edu>  [26c30fd77bf31ad8c14da1413aaa61fa8aa45206]

        tdf#147132: Flatten Basic function implementations
        
        Change-Id: I9fcbc87b7ce01d96ffb45ddd3a525831c7cdcdaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165357
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [afd6bd25ec748063825c74156bc9006366481f7f]

        convert UncachedDataSequence to comphelper::WeakComponentImplHelper
        
        Change-Id: Ib7facb9050bc71d15e23cb54c3ef22199c446da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [8caddb0d579030167791cb1c6d07bc28a3b35b49]

        IASS: Fix crash with PresenterConsole
        
        When being in IASS mode and adding e.g. an effect to
        a Shape (or anything else that triggers a preview)
        and the PresenterConsole being active, we got a
        crash. That happend due to the PresenterConsole
        being initialized *twice* due to interpreting that
        preview as SlideShow start. It also closed due to
        interpreting the preview end as SlideShow end. The
        next SlideShow end then bites the dust in an already
        messed up situation.
        To solve this, SlideshowImpl::startShowImpl now only
        uses NotifyDocumentEvent "OnStartPresentation" when
        this is not a SlideShow startup.
        I also secured PresenterScreen using a local bool
        to remember if it is initialized to avoid when that
        would be done twice (also used for shutdown).
        
        Change-Id: Ice588e0783fd39ec46d90a40affcaf2f789df8ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165356
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebe0f745e88a4d96bb29e52f4a56ec788c7c06ae]

        convert CachedDataSequence to comphelper::WeakComponentImplHelper
        
        Change-Id: Ia95efee23b7cf76636d5d85c722cf5ce5989bb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8872f7121b4ae4dd0b51820366d3510a88f7aac2]

        crashtesting: crash on exporting kde274105-6.docx to .rtf
        
        since:
        
        commit 9ae8e74fb32254c81d36b1c95411605459e06372
        Date:   Tue Mar 5 11:01:42 2024 -0700
        
            tdf#50934: Add a pie-with-remainder-as-another-pie chart type
        
        but this sort of problem has arisen before at:
        
        commit 3a2c2ad839860dcb36e30ae1a2867e4d5e1036fc
        Date:   Wed Jan 30 10:12:44 2019 +0000
        
            crashtesting: crash exporting ooo58458-1.odt to doc
        
            since...
        
            commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4
            Date:   Tue Oct 30 12:23:36 2018 +0100
        
                svtools: fix lost replacement grpahic when updating it via OLE fails
        
        and back in:
        
        commit ca9dd36bb0f2f8a5bcb0e5621ec181cc6f29ad73
        Date:   Tue May 22 18:34:28 2007 +0000
        
            INTEGRATION: CWS chart2mst3 (1.16.4); FILE MERGED
            2006/08/04 09:32:02 iha 1.16.4.1: don't crash while resizing some charts when replacement graphic happens to be empty
        
        the same issue of charts triggering UpdateReplacementOnDemand on
        modifications which happen during generating the Replacement Graphic.
        
        Presumably no modifications should happen during this process and those
        are the underlying bugs.
        
        Change-Id: I27172a7bd62d836f8e47f826de3ea941881459bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165358
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-27  Heiko Tietze  <tietze.heiko@gmail.com>  [dd889b290304b73f96a9a8e6e0f144d3aa2ba7e1]

        Resolves tdf#159573 and tdf#137931 - WhatsNew or Welcome dialog
        
        To test the new dialog, change org.openoffice.Setup > Product > ooSetupLastVersion to some lesser value for the WhatsNew dialog or clear the entry for the Welcome version.
        
        Change-Id: Iec6de50edba0e5430e82f1db85e61d1e4501771d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163739
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-27  Miklos Vajna  <vmiklos@collabora.com>  [b67991ecdb12bfa385496731f192ac081947c779]

        CppunitTest_sw_htmlexport: use more CPPUNIT_TEST_FIXTURE()
        
        No need to go via Writer-specific macros here.
        
        Change-Id: Ic7f0ed5ff16741d14488a19f1e73486690dd685b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165365
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-27  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [102622a07d48a0bac3573d6af00cdccc0b05df3e]

        tdf#146619 Remove unused #includes from C/C++ files
        
        'chart2' module was cleaned.
        
        Change-Id: Ib4cdb3c8a21d0ed47f4970894d416327df5e68a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164864
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-26  Alain Romedenne  <alain.romedenne@libreoffice.org>  [2146e66d8df2b7b6a2dd868e886cae76aaf7f48b]

        officehelper.py memory cleanup
        
        - main program must stop subprocesses it initiates before it throws exceptions
        
        
        Change-Id: I6e87d79e2f21cd41f7cd8e470cc166f8d5282954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164819
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Mike Kaganski  <mike.kaganski@collabora.com>  [e89c4d157a66e273898a8851d25fd0504cb28fc6]

        Set the condition, even when main thread message queue is empty
        
        Post an empty user event for that.
        
        Change-Id: I9ab4b4374a25eddce8c58d36f58e08bec4a1855c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [703dab1603af044e9b519e33aa1aa13b74d12c9a]

        cool#8570 speed up ScDocument::GetColDefault
        
        we can used an unordered_map here, we are sorting by pointer value. Also
        reduce the number of erase/insert
        
        Change-Id: Idb68f76e04248a0c808399bf9881afb5a8e01451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165346
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc5d84681d5d898b56171a9622294ecb23623bfd]

        tdf#159805 Printing line style dotted lines (horizontal) turns into dashes.
        
        I could not find a good place to distinguish between the dragging
        visualisation (where we could safely use approximation), and the
        non-dragging case, so just revert.
        
        Revert
            commit 9f4ccc63346b26d8d774b22124da0842ef18e0bc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Sep 13 14:27:02 2023 +0200
            tdf#156995 speed up dragging complex group objects
        
        Change-Id: I2ba52f07ea7299643c0f145459038e368a17dea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [feb4e0890b883940ec6964375293727ac6229f1c]

        tdf#160373: Iterate over all parents to check whether it's a clipPath content
        
        Change-Id: I383ec264e4c88ebcee2ae6a839b762bba8abfc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165347
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73957dd866b6d5b7144a37ce1477b0c781d5fef6]

        lok: The GridWindow can get reset to a smaller than wanted size
        
        This is the same problem as described in:
        
        commit 22a185a977f90d706c3e9d182adeaac310b6f348
        Date:   Thu Jan 11 15:08:21 2024 +0900
        
            sc lok: set the GridWindow size to the client area size + test
        
        except that the size of the GridWindow gets reset by UpdateFormulas
        via UpdateHeaderWidth to the width of the "frame" which is remains
        at the nominal 800x600 initial size throughout.
        
        That only happens if there are enough rows in the document to trigger
        a check against this, so add some extra content into the test document
        to trigger the problem, and then guard against this reset for the kit
        case.
        
        Change-Id: Ibf80849929a4c987fd0fe977518336e5115ebdce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165240
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ab9a4babe08b0c16ce4d199f2007bffb38d3f653]

        ofz#67600 manage removal of number formatter
        
        Change-Id: I460877adf29dcde69713d9d1671680e3172d138f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165221
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23b72488140e7e2031e0071718d55d2b9e1c2bef]

        crash on deref null parent on attempting to find label
        
        ImplFindDlgCtrlWindow always calls ImplGetChildWindow with first arg
        
        which does
        
        pParent = ImplGetTopParentOfTabHierarchy( pParent );
        vcl::Window* pWindow = ImplGetSubChildWindow( pParent, n, nIndex );
        
        ImplGetSubChildWindow always derefs its first arg and
        ImplGetTopParentOfTabHierarchy only returns null if its input was null
        so ImplFindDlgCtrlWindow shouldn't be called with null
        
        program/libmergedlo.so(_ZNK3vcl6Window13ImplGetWindowEv+0x4)[0x7513e2a40e54]
        program/libmergedlo.so(+0x33ba57c)[0x7513e29ba57c]
        program/libmergedlo.so(+0x33ba97c)[0x7513e29ba97c]
        program/libmergedlo.so(+0x33baf64)[0x7513e29baf64]
        program/libmergedlo.so(+0x3378d47)[0x7513e2978d47]
        program/libmergedlo.so(_ZNK3vcl6Window30GetAccessibleRelationLabeledByEv+0x19c)[0x7513e297866c]
        program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x241)[0x7513e2a4b301]
        program/libmergedlo.so(_ZN6Dialog18DumpAsPropertyTreeERN5tools10JsonWriterE+0x2e)[0x7513e29b217e]
        program/libmergedlo.so(_ZN3vcl6Window18DumpAsPropertyTreeERN5tools10JsonWriterE+0x182)[0x7513e2a4b242]
        program/libmergedlo.so(_ZN3vcl3lok9dumpStateERN3rtl13OStringBufferE+0xc0)[0x7513e2d6ee80]
        
        Change-Id: I732550bd67c3af38627849a7d96d8ee6140008b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [b0f26f460c8f9afceaaf0aa26de3ebfa1bf2cefa]

        tdf#160084 Simplify comparison for basegfx::fTools
        
        Change-Id: If1a2d000e7059856280bd1acb959b35c412777df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [0321606599065a24c9cfa5c86d1cfcfbe58d11ae]

        convert ODatabaseMetaDataResultSet to comphelper::WeakComponentImplHelper
        
        Which means making a copy of comphelper::PropertyContainer
        
        Change-Id: I14a61fa40e2c1dfc66833e00817025397584b3ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b2cd79aded5081ca8a4bc20fb851573ce890092]

        loplugin:finalmethods
        
        create a plugin that finds methods we can mark as final because they are
        not override in subclasses.
        
        Which is useful both as documentation (telling you that you don't need
        to worry about subclasses changing the implementation under you),
        and for performance, letting the compiler elide virtual calls in many
        cases.
        
        Apply the results to a subset of stuff in /include
        
        Change-Id: I7b5cc893ec2f343bc356bfc338e4cf531ffba1e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc1b2a0ab2ecddaeead680aee80a49109082a47b]

        tdf#160338 Calc freeze on Text Attribute dialog
        
        This reverts
            commit 76e9023c8abc823447b1128056e55238f90da8d6
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jan 22 08:36:28 2024 +0200
            convert more calc dialogs to async
        
        I fixed some lifetime issues, but even once that was happy,
        the Text Attributes dialog was not receiving mouse events
        properly, something else is unhappy when we mix async
        and modal dialogs.
        
        Change-Id: I4a35d886895c65af2085b606ff5c7a7c02fb5671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165305
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Mike Kaganski  <mike.kaganski@collabora.com>  [328416e015174778d11e982fd56f2cb59b0a5168]

        This assert was wrong
        
        In commit e2bfc34d146806a8f96be0cd2323d716f12cba4e (Reimplement
        OleComponentNative_Impl to use IGlobalInterfaceTable, 2024-03-11),
        I added the assert in a false assumption that RunObject may only
        be called once. Indeed, this is not so. Thus just make sure to not
        try to register it second time.
        
        Change-Id: I36fc4f3939bd0061e462659749bba8e4bd3075ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165299
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-26  Gökay Şatır  <gokaysatir@gmail.com>  [c15b872784c8fc0f5e5e813d38c7722f034034d2]

        Allow enabling saving when comment edit is allowed in readonly.
        
        Change-Id: I88d535a5b23fb6d5de8e72eec61bdf3550bc757d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165334
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f2ac3dff7858c1ef49474c1e703ddc0e4127b0cf]

        Consolidate on @since LibreOffice MAJOR.MINOR tags
        
        ...so even if 6a049e417b029f3733fcee05f99a3e8875aefdb8 "tdf#160184 ask user if
        they want to trust an untrusted certificate" gets backported to
        libreoffice-24-2 towards LO 24.2.3, better keep @since tags consistent and only
        officially announce it for LO 24.8
        
        Change-Id: I32be31893823ef116603b98df7ce9ec305a96e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165306
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-26  Mike Kaganski  <mike.kaganski@collabora.com>  [f0c32a4de8b18cc9f42bd441961ae4ae9fc72ceb]

        Replace some matchAsciiL (and wrong lengths) with match
        
        Change-Id: I6d0b5fa249cb466230183e11fc96a89fad69d45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165310
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d1275974d23c520a706129807443ff909719e23]

        ofz#67635 Integer-overflow
        
        Change-Id: Ia764276d6b35ea84d7415484eaeb9da77e55092a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Noel Grandin  <noelgrandin@gmail.com>  [dd873175affb7926befb1b8a0a881540d00160df]

        try to use more reliable mechanism in AddLinkTarget
        
        The commit that introduces this code says
            commit 89ffe6149a0e14bcde89d7981362aa1556849ab0
            Author: Tünde Tóth <tundeth@gmail.com>
            Date:   Wed Sep 18 10:13:50 2019 +0200
        
            tdf#127605 DOCX export: fix internal hyperlinks to image target
        
            jumping to the paragraph anchored by the image as a workaround.
        
        But using the SwNodeIndex ring to do this only works by accident,
        there is no guarantee that the SwNodeIndex is organised in any
        way at all.
        
        Change-Id: I9f886522ddf83b6799da9dd3d1f27e4b6c44bdc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2984dd49fb9fb2f8d3d56fba0db34a7b95666ce1]

        ITEM: Use SfxPoolItemHolder in SvxSearchDialog
        
        I replaced that SfxPoolItem* in SearchAttrInfo with
        a much safer SfxPoolItemHolder and adapted and
        simplified used code - it does not need to take
        care of Item lifetime/Cloning itself. That works
        well.
        I did not find out why that 'invalid' state is used
        in the SrchAttrInfoList, but seems to be needed.
        Thus I keep this for now as it is (it can be all
        expressed/used using SfxPoolItemHolder, too).
        
        Change-Id: I4b769f43128cb2e25153919f7652b2f032393123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165167
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1590e2c359fd3b506b8721d99a0054a0bd4dd200]

        No need to define ETIME
        
        (which is an obsolescent XSI-STREAMS Posix extension).  It's only use is in the
        big switch in UnixErrnoString in sal/osl/unx/uunxapi.cxx, so if any platform
        should actually lack it, we should rather #ifdef its use there than introduce it
        here.
        
        (This started to cause
        
        > sal/osl/unx/system.hxx:190:12: error: macro 'ETIME' has been marked as deprecated: ETIME is deprecated in ISO C++ [-Werror,-Wdeprecated-pragma]
        >   190 | #   ifndef ETIME
        >       |            ^
        > ~/llvm/inst/bin/../include/c++/v1/cerrno:51:67: note: macro marked 'deprecated' here
        >    51 | #  pragma clang deprecated(ETIME, "ETIME is deprecated in ISO C++")
        >       |                                                                   ^
        
        with recent LLVM 19 trunk on macOS now.)
        
        Change-Id: I01a586f08a4d9e4643c797fce5ce53c5f3ce8b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [66be0576a6202354bd5dce289eb823256cc0a324]

        Silence -Wdeprecated-pragma
        
        ...as seen with recent LLVM 19 trunk on macOS now,
        
        > In file included from sal/osl/unx/uunxapi.mm:1:
        > sal/osl/unx/uunxapi.cxx:612:14: error: macro 'ENOSTR' has been marked as deprecated: ENOSTR is deprecated in ISO C++ [-Werror,-Wdeprecated-pragma]
        >   612 |         case ENOSTR:
        >       |              ^
        > ~/llvm/inst/bin/../include/c++/v1/cerrno:48:69: note: macro marked 'deprecated' here
        >    48 | #  pragma clang deprecated(ENOSTR, "ENOSTR is deprecated in ISO C++")
        >       |                                                                     ^
        
        etc.  (And -Wdeprecated-pragma was only added towards Clang 14 with
        <https://github.com/llvm/llvm-project/commit/26c695b7893071d5e69afbaa70c4850ab2e468be>
        "Support macro deprecation #pragma clang deprecated", so wrap it in
        __has_warning.)
        
        Change-Id: I8db1f00a48bb647573d287c3410137182570f82b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165304
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-26  Noel Grandin  <noelgrandin@collabora.co.uk>  [645a7ae67743dc9c35ee91714beefe60d0165bfe]

        skip more tests on hi-dpi windows
        
        Change-Id: Ic8a88e112f413a9ec0a77e3be5d8a586312cfe0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-26  Miklos Vajna  <vmiklos@collabora.com>  [2c914532277061c86ed0cb681341d1b39d149029]

        sw: document SwFormatFillOrder
        
        Something to be mostly ignored, I guess.
        
        Change-Id: Iab7dc0f79d4cccb6d6b2a25e42d9fd1eb7e2b8dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165300
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [18506db0753b180c6f62c6c634f14bda4c6c5d25]

        Fix typo
        
        Change-Id: Iabc9a271c0c7d2c11da1db629335dcf7c73fff52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165331
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-26  Justin Luth  <justin.luth@collabora.com>  [47af9e64a573684eb42faa097e327e31777a2b58]

        tdf#129905 tdf#160365 sw: don't always draw text boundary on frames
        
        This fixes a 7.6 regression caused by
        commit 79811c27f34d3e752de1bc3959605c5d58ac2365
            tdf#129905 Create toggle for Section boundaries
        
        This fixes the toggle for View - Text boundaries,
        so now images can have their thin gray border removed.
        
        This also fixes the toggle for View - Table boundaries.
        
        Change-Id: Idb75debf173d64b14a6864c61b4524e46898975f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165297
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-26  Justin Luth  <justin.luth@collabora.com>  [5bf7df62645f73ad69772f318ea3058dfd6fce12]

        tdf#131253 sw: draw frame text boundary on when show formatting marks
        
        It is infuriating to see a border around your image
        when there is no border defined. View - Text boundaries
        does NOT sound like something that would apply to images,
        and it is NOT nice to turn that off because then you also
        lose the body text markers as well as the header/footer indicators.
        
        Instead, do the same thing as the page boundaries - only show
        the (full) boundary when show formatting marks is turned on
        (and there are no partial boundaries for frames...)
        
        I tried to write a GDIMetaFile unit test,
        but the dumps were identical - failing to capture this screen artifact.
        
        Change-Id: I7954effc46d977e1761cba71758f7a7af2072807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165294
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c58b2070f1653454e9e6e4821f9688b3d623039e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to db5de3869538e6befd296b3d1595759f241e1e6a
          - Housekeeping on Help files
            
            Change-Id: I239231d51a785a12c35a1c609b83f8390931711a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165333
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-26  Dione Maddern  <dionemaddern@gmail.com>  [40e74569c152a56560071c0b67bd0bee277daf39]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b39d692e34aec084c9ec38f2b22394ebccb54ffe
          - tdf#135360 Update information for Options> Libreoffice Writer > View
            
            Updated text/shared/optionen/01040200.xhp to include information on Resolved comments, Tracked deletions in margin, and Tooltips on tracked changes. Updated the "How to get" section to include instructions for Tabbed UI and Keyboard.
            
            Change-Id: Id45809ee9d3a1e22d4f8d37ad6006021c982569f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165243
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-26  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6f775d750a4d9e838d8d1f522efaa18a86815b69]

        tdf#150696 Consequent term usage for Snap Guide
        
        Change-Id: Id3ae5af203db09019b2ab1e63cc0b8f7bed7a98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Darshan11  <darshan.upadhyay@collabora.com>  [e08b69e25c27adffcde3466b5ff90be4da603347]

        Hide "Add and resize" button from numbering and bullets dialog for ONLINE
        
        - Image tab had "Add and resize" option for numbering and bullets dialog
        - which is not need in online
        - so we will just hide that browseBtn for online
        Change-Id: Ib87f1e7ae7e6df5256ab77122b477695a45cf441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164587
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 08a5c1352f4d65c180995cdfca5c981f88035901)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bfb4c58ae708c75949559290bdfdd9afcef6aa91]

        tdf#126573 Add Excel2021 array function SORTBY to Calc
        
        TODO/WIP: oasis proposal
        More information about how this new function works:
        https://support.microsoft.com/en-au/office/sortby-function-cd2d7a62-1b93-435c-b561-d6a35134f28f
        https://exceljet.net/functions/sortby-function
        
        Change-Id: I4538a32f7f75056d3055369fc5f4483d24fd1089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165069
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-26  Patrick Luby  <guibmacdev@gmail.com>  [6a049e417b029f3733fcee05f99a3e8875aefdb8]

        tdf#160184 ask user if they want to trust an untrusted certificate
        
        gpgme contexts uses the "auto" trust model by default which only
        allows encrypting with keys that have their trust level set to
        "Ultimate". The gpg command, however, gives the user the option
        to encrypt with a certificate that has a lower trust level so
        emulate that bahavior by asking the user if they want to trust
        the certificate for just this operation only.
        
        Also, abort saving if no certificates are selected which is an
        indication that the user cancelled the Select Certificate dialog.
        
        Change-Id: I20951b1e31b2dcf8adb82243742f8c00fbaca8c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165260
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3eefc0fbe7d9a9ed946979c97a41181cd043593]

        poppler: upgrade to release 24.03.0
        
        Change-Id: Icd063dcc9a034e88283ddf16be64091a32f3453f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165292
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-26  RMZeroFour  <ritobroto04@gmail.com>  [74299624ec810f9683326608ad398211cf51787b]

        tdf#158237 Use contains instead of find-end
        
        As part of the efforts in #158237 to replace older parts of
        the codebase using find() and end() methods, with contains(),
        this commit does the needed changes for a few files in the
        sc and sw modulues.
        
        Change-Id: Ibf0a432c537879f5bec8e8912d11150733366689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165223
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [24aed4f9a5f6351d9153c96e3d1d1aa68028c0d0]

        Avoid -Werror,-Wcast-function-type-mismatch, remove unused int return
        
        > vcl/unx/generic/app/i18n_ic.cxx:225:51: error: cast from 'int (*)(XIC, XPointer, XPointer)' (aka 'int (*)(_XIC *, char *, char *)') to 'XIMProc' (aka 'void (*)(_XIM *, char *, char *)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
        >   225 |                 maPreeditStartCallback.callback = reinterpret_cast<XIMProc>(PreeditStartCallback);
        >       |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I94d1d0042516a01f8597bc65895042ddae76c98b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-25  Julien Nabet  <serval2412@yahoo.fr>  [02609da5ee8188cb00fc0b97052d2cc8d2576900]

        Related tdf#160351: the field name can be shorter than two symbols
        
        Change-Id: Ieb6b78b3f9802e66de642a9e708b11c55c0d9a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165285
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0581190bc4e5502d93aa695365e7bf82b23d1ecf]

        cid#1594675 Logically dead code
        
        Change-Id: Icaf621e7a2e163f969ac7b6a1d6d04bf9251ea56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165277
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [a80258e11282c78ab3867c96e4c2575e83c5482b]

        mariadb connector: upgrade to release 3.3.8
        
        Change-Id: I21cf511a2b6c040d4a64ca720606af9312130045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165284
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6d791e3d2577498affec491876a0afa441be002]

        nss: upgrade to release 3.99
        
        Change-Id: I77ccc45854b2d0aecc288f471d94c81ad9089f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165273
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c80ed3ef7ce008d5fb8116e09b00b0a6cb6eb835]

        cid#1594674 Using invalid iterator
        
        Change-Id: I710a6a2f045de095f5f3f09a971162b669eedd4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165275
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [064b9211ffdf82ef29ce02ff288d6a83d2a7d167]

        cid#1454847 Uninitialized pointer field
        
        Change-Id: I81aea5f73b9b28e28366beb74e853518287a9ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32c6a482fc058c4f3d064b08660607d2919d6617]

        add missing mode lines
        
        Change-Id: Iafcda5fb4d639d35ea35bab2b8b015208a8397fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165276
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-25  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [f16d04c95f6952c811b67c3891c27bd01a4824df]

        xmloff : no need to use OUString literal for comparison
        
        Change-Id: I2b8f75ec56d93003d8c9c14b3cad1e3978cc6a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165227
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-03-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d859cee05aca630d013cfa8a4a6332775c95262]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 772dac9c72752c82c015bcd222655b50a6eeb9eb
          - tdf#160035 Remove extra Help page
            
            Page 19040000.xhp was not target of nay other link
            
            Change-Id: I2b3311aaa8f6bd2616096e922b3118856c749bfe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165289
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-25  Oliver Specht  <oliver.specht@cib.de>  [203b6a00cf5b716cb580d2bd4e9a6071cec23574]

        tdf#160264 Fixed crash in gallery
        
        Local gallery themes need an additional listener to prevent deleting
        the global theme.
        
        Change-Id: If6cfcb5a3eeffdc087b089f2151c45b2cff87bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165029
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-25  Mike Kaganski  <mike.kaganski@collabora.com>  [4a14bad7232ecf23d23c1997dc20922d0b4892cb]

        tdf#160351: the field name can be shorter than two symbols
        
        Change-Id: Id834ae2919661752b921510f766c9e9ff7fc16fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165282
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a0b37a5337faee5634cc9fce4955da204b95bf4]

        openldap: upgrade to release 2.6.7
        
        Change-Id: I7716a41114442ba7a57d81192b01cbeaaeca08b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165280
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [45435a680be065e44eba385bb2523b27b77fb451]

        tdf#126573 Add Excel2021 array function SORT to Calc
        
        TODO/WIP: oasis proposal
        More information about how this new function works:
        https://support.microsoft.com/en-au/office/sort-function-22f63bd0-ccc8-492f-953d-c20e8e44b86c
        https://exceljet.net/functions/sort-function
        
        Note: Move ScSortInfoArray class to sortparam.hxx, which is a more
        logical place.
        
        Change-Id: I70e720e93ba0414d54cb3437de0bfa066508fe30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164778
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6f000c64fa986a9539f68fe5fff096b0b4b7c48]

        postgresql: upgrade to release 13.14
        
        Change-Id: Ia9607fd9c8dad9d5936e867ad76b18a476f1057f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165278
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-25  RMZeroFour  <ritobroto04@gmail.com>  [6227fccce44e7c44a7a6da707f361b1d4886c1d0]

        tdf#157665 Use <=> operator for errcode and strong_int
        
        As part of the efforts in #157665 concerning the spaceship operator
        for the C++20 codebase upgrade, this commit implements the spaceship
        operator, replacing redundant operator overloads, in strong_int.hxx
        and errcode.hxx
        
        Change-Id: I23985207c27d6a5147c3f7b4a0d2416f86dec5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165219
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-25  Mohit Marathe  <mohitmarathe@proton.me>  [913437f3cd79c4f64151b98366fcc8a90bb66dac]

        tdf#147021 replace SAL_N_ELEMENTS() with std::size()
        
        Change-Id: I8d704123aaa968352033d1b6680d5da6153eba21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165268
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c4be391530a6a3ea2423020a7a836695b7ee9c90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8ef32e905f028ee451b3664f72c0b508c74c6c5
          - tdf#159725 ExportAsFixedFormat Help page (WIP)
            
            Initial Help page for ExportAsFixedFormat VBA method.
            
            Missing:
            - Error codes related
            - Arguments not implemented
            
            Change-Id: I43ca670047542b29858e4384243d7e9a36a5efc0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165256
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1339c42c4aea269e5265277647361ae91882d8a5]

        Best effort to create directories of SAL_LOG_FILE
        
        Change-Id: Ia86ac0e022579d155e92de3b853d57860b5b97e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165272
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [77224aaec6ba89194a404805d7190f88e92fcc9f]

        tdf#158556 speedup docx load
        
        move the vector outside the loop, avoid repeated allocations
        
        Change-Id: Ic6ef95a966ffd5c4115ea56e63af1494e7937928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab29c857c669bcca3d8eea8a5a9e6ad5eae622d7]

        tdf#158556 speedup docx load
        
        If we want to know if an XText is a header/footer object, no need to
        loop over the draw objects, we can just query its service name.
        
        Reduces load time from 167s to 97s
        
        Change-Id: I10158c11dd24c4945b3ea6cfed4916717bd4f2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165269
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-25  Miklos Vajna  <vmiklos@collabora.com>  [4a7bd4798f3f79c813e940504463c0af7bf9e985]

        svx: prefix members of XHatchEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: I1edd4bf9c3b7369898f500f9eb5c483be133ed67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165267
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f3bbb442e2a9482e9a8e951d956baed08a06b944]

        editeng: fix unintended duplication of the line
        
        Change-Id: I90f787cc504d46d32581caa1f0b1c7b9e86968a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165265
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4aeb21ab684aa2de44cb294f7d73491a405ee166]

        drop unused method
        
        Change-Id: I39cd0016226deb2f19079a11e63c41a58176e032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165258
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-25  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [6acc37e936c2023af612b812524fa5b4a56d6895]

        tdf#154331 Improve tip of the day
        
        Change-Id: Ibebbc9b254d1bc8c45e20efc634d77ec0b708569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165235
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [85a2bb9f52a0d834b02681344ce56e0b091e1abd]

        Avoid -Werror,-Wcast-function-type-mismatch
        
        Change-Id: I93a69c57856169aeff613e34d5c0bf7fa08a0de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165251
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-25  Mike Kaganski  <mike.kaganski@collabora.com>  [fb94c8f64a15ff4bf45f1d2adfab9cb50a696d71]

        Relax SolarMutexReleaser precondition to not require SolarMutex lock
        
        As discussed on https://gerrit.libreoffice.org/c/core/+/164843/2#message-8873d3d119de7206b33bc824f5809b8b1d3d97da,
        it is impossible at times to know in advance, if a specific code, that
        must not be guarded by SolarMutex (e.g., calling to other threads, which
        might need to grab the mutex), will itself be guarded by SolarMutex.
        Before this change, a required pre-requisite for SolarMutexReleaser use
        was existing lock of SolarMutex; otherwise, an attempt to release it
        would call abort(). Thus, in some places we had to grab the mutex prior
        to releasing it, and that itself introduced more potential for deadlock.
        
        Now the SolarMutexReleaser is safe to use without the lock, in which
        case, it will do nothing.
        
        Change-Id: I8759c2f6ed448598b3be4d6c5109804b5e7523ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165262
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1344e6261a1d856c71eca1e0cc29215a586bf335]

        Avoid -Werror,-Wcast-function-type-mismatch
        
        Change-Id: I0bd094b2f08f60df33b32cad7ae389141b41a209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165229
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0c29c417ef3f0b749042e5a461abae9c36cf655b]

        Avoid -Werror,-Wcast-function-type-mismatch
        
        Change-Id: I12014c46bf4a22232c8739166effc42756e97dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165252
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dae7304df68493afcf6e9c9e490d65ea20d8211f]

        Silence Clang 19 trunk -Werror,-Wcast-function-type-mismatch
        
        Change-Id: Icd0af828e47c770ca8964656188d0d722a7f1ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2be64297ad73b2e8d83e3ef17641dc8445f37372]

        fix CppunitTest_sc_subsequent_filters_test4 intermittent failure
        
        Change-Id: Ieb532183fd07915f8e0f2ec0cc3983a390024522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165257
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [035f87f7ed8775c30c6f84d7d02bc72a66182c63]

        ofz#67577 Integer-overflow
        
        Change-Id: I3828bb76ab7808ac0717b33c231927730216b42b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-24  Tomoyuki Kubota  <himajin100000@gmail.com>  [6802878057e91a7d32b143d4e177de9b30e09a25]

        for compilaton with OSL_DEBUG_LEVEL > 1, adapt to the commit f9395a12, which replaced std::vector with KernArray
        
        Change-Id: I12e918814a29fff114c5eae320498a8fc0229dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165233
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b866019e6ee82ce19dacd653861f8d2b701d2a8e]

        ofz#67563 infinite loop
        
        Change-Id: I1654d23fd8768a77d32fc3150a9d8554afa2e91f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165220
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [53680642cc5ea3df512b7e35a199b6ed6e9d9c39]

        ofz#67540 negative offset
        
        Change-Id: I498985962feb7d77c1a71af7002a85aa02aa3e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165217
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-24  Jean-Pierre Ledure  <jp@ledure.be>  [e110974bc1c2a0b253d27cf3ad2643aa5208e2cd]

        ScriptForge (session).RunApplication() redesign
        
        The RunApplication() method uses
        - either the Shell() Basic built-in function
          (only in asynchronous mode)
        - or the com.sun.star.system.SystemShellExecute()
          service
        in this order.
        The second is tried in case of failure of the first one.
        
        Benefits:
        - the method can start batch files or scripts
        - broader than Shell(): giving a user file as argument
          opens its application first based on the file suffix
        - more robust error handling
        
        Read discussion in tdf#160222.
        
        This change could require a light revisit of the
        sf_session help page.
        
        Change-Id: I1fb4717db4b971bd62885ad0e38b7c08a8e6f434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165218
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-24  Tomoyuki Kubota  <himajin100000@gmail.com>  [ee2afff68ed5b22b2bf635d536584e8cba4ae2a4]

        for OSL_DEBUG_LEVEL >= 2, adapt to b55bf0cbdfdc6820
        
        Change-Id: Ie3b9746ca150fba8f9849649b6e6bbd0439e1a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-24  Noel Grandin  <noelgrandin@gmail.com>  [32e10ebb2a1d44b40517a4024f8e984ca071d11a]

        reduce symbol visibility in svx
        
        Change-Id: I19b7518f0ec1207ba95158f70d286ab115456466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [04bad6534b74af0ec9d0a516e0bf0a9c5ec5568c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7786ebca61858926ce0cd3894922dac725c1997b
          - Housekeeping files on SUM/SUMIF/SUMIFS
            
            Change-Id: I07ac3a115a9b3f86ee05f75f0f3bcdd4cdf1ef69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165205
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [1aeec70c2a635a69e90d2643f2e524bb342378ae]

        Fix extended tip in mmselectpage.ui
        
        Fix wrong dialog name in extended tip.
        
        Change-Id: I639982cb36ed7b7f6fed4c89302b11003a75af6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165097
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-23  RMZeroFour  <ritobroto04@gmail.com>  [e7eae3aa6e3af0b05c6aa471d2c4892918757e7a]

        tdf#158067 Replace OUStringLiteral with _ustr
        
        As part of the efforts in #158067 to replace static constexpr
        OUStringLiteral variables with string literals of the form
        u""_ustr, this commit performs the replacements in some files
        of the xmloff module.
        
        Change-Id: Icce2ed7f9a69ef023aaff498975d6afabf161d4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-23  Beeram_12  <pranithreddy16.beeram@gmail.com>  [7174403b03a7effe8bedf78368c09840b4fdf7a9]

        tdf#158237 use c++20 contains() instead of find() and end()
        
        Change-Id: I9bfea186f8bac4619f8b0e3e8a8158cefcbc482e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164792
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-23  Gabor Kelemen  <kelemeng@gnome.hu>  [f0a9ead35c0da606d7ccab2f0c96e103a3b6be06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e3c2cb1ffa55b44e2b77d14ac5f5ce217630b8a
          - Use default HIDs in Gallery sidebar help page
            
            Change-Id: I7ab1d18d25c290320f3c0ebfdf3da1837cdf007a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165023
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-23  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [726007573dca7508c367d369b8abd5e1d01091e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b010f7c91670f60ab8c637b321507b67d1bc4a63
          - tdf#159985: need to reload file for macro security change
            
            Change-Id: If708fa18648c23a811951675167581b1013343ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165042
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30af052c8ac3d72c3f012767363239e40e4a4fef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to afe978c5d51f0252fe21cb0adb77fb68471d0708
          - Fix typo
            
            Change-Id: Iedd52d9aaf2b2eb709a13e4d4107f67068245c18
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165201
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [19d50d65b1a11b74e4dc829e05bfed3429430bd9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a0bb412c1d7205f19da2df1e61bd9fd6f9a5b3d0
          - Fix typo
            
            Change-Id: If50cde89f8c3c2247d5009e513c785a7e49f6244
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165202
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-23  RMZeroFour  <ritobroto04@gmail.com>  [64a55911eae1cf5f913f07b45a7c8379b325e471]

        tdf#157664 Drop redundant operator != in basegfx module
        
        As part of the efforts in #157664 to remove redundant definitions of
        operator!=, to upgrade the codebase to C++20, this commit removes the
        remaining definitions in the basegfx module.
        
        Change-Id: I19f2b9ddf42185435313445c8395a851030e2149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165199
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-03-23  Dione Maddern  <dionemaddern@gmail.com>  [87d00a83643413a154fd3d2eb2910322abcaba02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e531b6ff5c696b0424cc63f348111a0897dedad8
          - #tdf120179 Rewrite SUMIF Help Page
            
            Created a new file named text/scalc/01/func_sumif.xhp. This file includes updated help information for the SUMIF function, including a more precise definitiion of and more detailed examples.
            
            Added the new file text/scalc/01/func_sumif.xhp to AllLangHelp_scalc.mk so that it will be included in the Help application.
            
            Replaced the content in text/scalc/01/04060106#Section15 ("SUMIF") with an embed link to the new text/scalc/01/func_sumif.xhp, so that only the definition and a link to the main SUMIF Function page appears in the list of Mathematical Functions.
            
            Updated the "Related Topics" sections of text/scalc/01/func_sum.xhp and text/scalc/01/func_sumifs.xhp so that they link to the new SUMIF Function page.
            
            Change-Id: I224dffb0c3c6411ea416bba308559f9fe3896dd2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165186
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-23  Regina Henschel  <rb.henschel@t-online.de>  [15e43d9679773efcf869ff8272c7932b59fe1c68]

        tdf#70039 partly enable 3D-image from pptx
        
        This enables 3D for those images, that have been cropped to a shape.
        Those images are imported as custom shapes anyway and thus can use the
        now possible rendering as 3D-scene.
        
        The patch does not change the import of pure images with 3D properties.
        (Such is possible in OOXML.) Using a custom shape here too, would
        restrict the user. Exchange of the image or using color corrections
        and filters on the image, for example, would be no longer possible.
        
        It also fixes the error, that a z-rotation of a pure image was no
        longer considered.
        
        Change-Id: I626b1687c5aed1cac6f35388a3b25941673b5513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165194
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-23  RMZeroFour  <ritobroto04@gmail.com>  [c845b7db9504d3e4fbc728839d8d73d454415071]

        tdf#143148 Replace include guards with pragma once in sc module
        
        As part of the efforts in #143148 to replace include guards in
        the codebase with #pragma once, this performs the changes for
        the remaining files in the sc module.
        
        Change-Id: Ia5633919e4159da94b6e663fa484ef0524cf7bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165196
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-23  Heiko Tietze  <tietze.heiko@gmail.com>  [d7fd378b533c42f51d1d363f5da30b1fa1281f67]

        Harmonization of warning and error colors
        
        * hard-coded colors from infobar moved to settings
        * weld::LabelType::Warning and ::Error uses these colors
        * gtk3 native configuration removed
        
        Change-Id: Ia80584e9267b8385f7f6b25322f5a85a2570af68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165161
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e83f7b7c84d5345879c5543b78ce6ad2b32dc2bc]

        vcl: set "default" type only thorugh a ImpGraphic constructor
        
        and do some more clean-up.
        
        Change-Id: I28c33887226444046d21076118fd066eb3a231d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164947
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b38974391e8d4bf0d450abfaa86bbccbe1022995]

        Related: tdf#160056 do calc NumberFormatting via ScInterpreterContext
        
        and for the duration of Threaded calculation where there will be
        no new formats required we can drive number formatting with the
        unlocked RO policy.
        
        Change-Id: Ic0e449acdcf834bc569d13b4a984f13c55316801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165160
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [4bdf2829a31e29949bf4d9a008e1f9d2b50bf4c1]

        Add missing dialog name in findentrydialog.ui
        
        Change-Id: I5ad3f80064ce15f9ff3d72f85237bde426d935a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165156
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6c6126aa3e8de256091b829b98b5943db6a8be6]

        Related: tdf#160056 refactor SvNumberFormatter
        
        to split it into two constituent parts
        
        SvNFFormatData which is the data store for number formats it generally
        operates on.
        
        SvNFLanguageData for data around the current language in use.
        
        and then a SvNFEngine which implements the interaction between those
        parts
        
        SvNFEngine has two policies, the typical RW mode and a new RO mode where
        the SvNFFormatData doesn't change, all formats needed in this mode must
        already exist.
        
        Change-Id: I56b070ccd2e556a0cb1fe609a2fae28e18277c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165146
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-22  Miklos Vajna  <vmiklos@collabora.com>  [c900850742efd4e1fb7c79c13c1b9a17fcd4981d]

        Relatted: tdf#160139 RTF paste: don't turn off headers/footers
        
        Regression from commit d918beda2ab42668014b0dd42996b6ccc97e8c3a
        (tdf#158814 DOCX import: fix unwanted header with type="first" & no
        titlePg, 2024-02-05), pasting shape text into the body text of Writer
        turned off the header, which was not intentional.
        
        The original use-case was DOCX/RTF import, and the paste case was just
        not considered.
        
        Fix the problem by leaving the paste alone: we already omit a number of
        actions in this case (e.g. not overwrite styles), don't turn off
        headers, either.
        
        Note that the original problem is wider: we would probably need to track
        what page styles are created and only touch those, or something similar.
        
        Change-Id: If08fa7956e98766d5807332c5c0baa25b46afe38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165191
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-22  Noel Grandin  <noelgrandin@collabora.co.uk>  [c469e786be9345fc76e5cc62fd23dd317db53c02]

        skip more tests on hi-dpi windows
        
        Change-Id: I41368325959e69f016289d8e43775e05087f1be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Patrick Luby  <guibmacdev@gmail.com>  [b499f32c44babe8f60a6eef51bda6adb9b1cf54d]

        Clean up path in diff header line
        
        Change-Id: I181c8c0f41bd4367c622352797f4c493e16c02c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165165
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [df6fdb0041f8bfd251a4b03030b8bc47f0614c36]

        tdf#157241 sw: assert when importing ToX in table in rhbz589883-2.docx
        
        ndtbl.cxx:1417: SwNodes::TextToTable(): Assertion `!rNode.IsSectionNode()' failed.
        
        (regression from commit 62cb3b8b8d6106c6aeb073b12d84973a107182ef)
        
        Change-Id: Iec12282573cb914d1924f4da4a28e26e01b866df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165164
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-22  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [370ca73a45b291e172918b4c8fcbc37ccaa434cf]

        Expat: upgrade to release 2.6.2
        
        Fixes CVE-2024-28757
        
        Change-Id: Id85044fa9d8eda922425e580e9d6979f6563e98a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165129
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-22  László Németh  <nemeth@numbertext.org>  [cfd84d8a2add8b5c121d027458ac7692d90b5c7a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 491736b0e775f7d4a0bfd9ed9ce94ec296e3e988
          - Updated Hungarian hyphenation dictionary to version v20240321
            
            source: https://sourceforge.net/projects/magyarispell/files/OOo%20Huhyphn/v20240321-0.1/
            Change-Id: If470f5854511cac6f0a355e4d006abf9e3976f90
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/165166
            Tested-by: László Németh <nemeth@numbertext.org>
            Reviewed-by: László Németh <nemeth@numbertext.org>
            
2024-03-22  Miklos Vajna  <vmiklos@collabora.com>  [14bc758fa1d275ef54499085bfdc72d372128ede]

        CppunitTest_sd_tiledrendering2: extract one test from the old, large suite
        
        Not a split, to avoid too many conflicts while cherry-picking, but at
        least create a new suite where next tests can be added without too much
        build time after source code edits.
        
        Change-Id: Idb421db0a63dccee205a4092d368f6d48a093a10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165163
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-22  Attila Szűcs  <attila.szucs@collabora.com>  [d323976fd6d560a9b91da3e7833dfbe9f6b78f39]

        tdf#159258 SD: SS: disable placeholdertext in image
        
        Changed the text creation to use ExclusiveEditViewPrimitive2D
        in case we are in a placeholder image.
        Had to make a flag to send the information if we are in a
        placeholderimage.. because this function also called on other
        primitives.
        
        Unfortunatelly we cannot do it in
        CreateObjectSpecificViewObjectContact
        as in case of the icon... because the Primitive2DContainer
        that will (later) contain the text will also contain the rectangle
        as well, and we want to display the rectange.
        
        Follow-up to commit I307f4b0fe7f8faf98789787f216cac7be86a0515
        "Provide tooling for EditView exclusive Primitives".
        
        Change-Id: If24aaa330c7b0b6dbaa72c9900774959ef24da4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165087
        Tested-by: Jenkins
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>

2024-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [8f2de92b3da99346f7282e623d47912f40f92b7b]

        sw: GetSelectableFromAny() broken for SwXTextRange
        
        The function unnecessarily uses an intermediate XUnoTunnel variable to
        handle SwXTextRange, but the implementation of XUnoTunnel was removed.
        
        (regression from commit 635448a996714a81cb15b41ac4bb0c73cabfb74f)
        
        Change-Id: I90dd7acbd259e8ca562a534ad0bc9a5b85356553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165162
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-22  Heiko Tietze  <tietze.heiko@gmail.com>  [9c8b240e7cad6ef74e16ad83d45957737389aa90]

        Resolves tdf#160282 - Ranges references text colors for dark backgrounds
        
        Change-Id: I3d3bb22302ad5016c962d606e80c2e9942301fbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165095
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [64aa51cb2fcfb6cfb325ffdc2567b0a2f0661007]

        remove unnecessary code
        
        SwTextFootnote has a start node member, no need to search for it again
        
        Add an assert in case I'm wrong.
        
        Looks like it has been this way since
            commit 6bff13645223e2a2701acc1b6f7d579671c97e06
            Author: Oliver Specht <os@openoffice.org>
            Date:   Fri Jan 12 15:15:41 2001 +0000
            new: Redline container
        
        Change-Id: Ic9e48d051c9da14be860907cceaf38aee5a0c794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Pranam Lashkari  <lpranam@collabora.com>  [437161094d6e19f7cc222b1029801a481ad15618]

        LOK: enter editing directly after textbox insertion
        
        Change-Id: I3e77a1eb72a12c0e4ffc289ca854e0edb4ae9e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165007
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2024-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ef4dc07cd4413253b5747dd714fadd548d6bcf6]

        improve loplugin:staticmethods
        
        Some of the exclusions were too aggressive. Restrict them to only the
        important classes, which exposes some more places this plugin applies.
        
        Change-Id: I1b2d1fb24391adc71ed0984f94168f61a149479f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e136900e7a971385be9367a3dcaedea54d1e7207]

        tdf#159258 sd: fix to show objects in slideshow if they have
        
        fillstyle or linestyle.
        
        Also the shape will be appeared in print and pdf view.
        (Powerpoint doing the same.)
        
        TODO: the placeholder bitmap and the default text
        was not removed from the slideshow/print/pdf view.
        
        Change-Id: Ifadc9a692d77b60a7e3514afe8e6ea5cab0018c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164163
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-22  anish.deshpande  <anishmdeshpande@gmail.com>  [7d384d63105af039cd0246395d005f337073eac6]

        tdf#114441 change use of sal_uLong to better integer types in toolkit
        
        nPageID is referenced as sal_uInt16 in TabControl::SelectTabPage.
        
        Change-Id: I11e518a0c9be5eecb9e8b2472f4df356da5a93e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164330
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-22  Regina Henschel  <rb.henschel@t-online.de>  [9556504b213519e2900e72c81aa26a470dc6353c]

        Revert "extruded shape import: tweak threePt light rig too"
        
        This reverts commit aa341e79ee241fec0b5afe159b0c674cf85a52c0.
        
        Reason for revert: The front faces become too light. A similar front face is more important than lighter extrusion faces.
        
        Change-Id: I7e58d19b7e6264358d46f172f23bbfea74936250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165121
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6518dc58f76ad9b59a61dd3736abd62acc5fc57]

        tdf#160117: vcl_pdfexport2: Add unittest
        
        Change-Id: I5b10d92d1ba4d62a8a0b4e2d8b0f023b58225fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165098
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [be2f27b011d43cb3a5cb1aa352cc445083948103]

        Make msvc_raiseException explicitly [[noreturn]]
        
        The comments at
        <https://gerrit.libreoffice.org/c/core/+/165113/1#message-a76a16ede60a817426763c1c2c2090f23ae141e0>
        "framework: MenuBarManager: fix WNT crash if queryDispatch() throws" suggest
        that it was observed returning normally, and running into the
        
        >         // is here for dummy
        >         return typelib_TypeClass_VOID;
        
        in cpp2uno_call.
        
        Change-Id: I792a9eb82ef9e737aa69dc651b9a072871c0756b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165152
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Jean-Pierre Ledure  <jp@ledure.be>  [065fa9d77e5bd550600e8985d7e7aac8e10745c4]

        ScriptForge (session).RunApplication() crash fix tdf#160222
        
        Use
         com.sun.star.system.SystemShellExecuteFlags.DEFAULTS
        i.o.
         com.sun.star.system.SystemShellExecuteFlags.URIS_ONLY
        
        as argument of
         com.sun.star.system.SystemShellExecute.execute()
        
        Change-Id: I3919777cf9442387aec6ed694a2883519e4a7910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165105
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ba0ec4a5d2b025b675410cd18890d1cca3bc5a2f]

        tdf#159687 sc formula SUMPRODUCT performance fix: add more binary
        
        operators which need to be checked if they are next to a trimmable
        DoubleRef arguments or not.
        Example:
        =SUMPRODUCT(($D:$D>M47:M47)*($D:$D<M48:M48)*($I:$I=N$41)) -->
        $D:$D and $I:$I columns are trimmable.
        
        Recalculation of formulas with a lot of SUMPRODUCT where we comparing
        full columns could take minutes during editing a sheet. With reducing
        the size of the compared ranges to the actual data could significantly
        speed up the recalculation.
        
        This takes the recalculation time from ~50 sec to <1 sec on my machine.
        
        Note: probabaly the same could be applied to the SUM function.
        
        Change-Id: I758660d0b638ef7255bd5a41a96755289b5a2b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [8350404ec1c02df8b4f6b4f48947ddbff53d91e5]

        configmgr: fix parse error if subelements of <info> used
        
        The unused but valid child elements of <info> such as <author> may be
        used by exentions. This fails with:
        
          warn:configmgr:15104:10916:configmgr/source/components.cxx:660: error reading "file:///instdir/program/../share/uno_packages/cache/uno_packages/....xcs" com.sun.star.uno.RuntimeException message: "bad member <component> in ....xcs at configmgr/source/xcsparser.cxx:289"
        
        Because ending the first such element sets bIsParsingInfo_ to false.
        
        This fix just concatenates all the characters in all the children,
        should work well enough for extensions.
        
        (regression from commit db3078bd8c8e3ce3a99fc3987bb6e93b609990c1)
        
        Change-Id: I17a3fb7014cd34c1d546701036550085365432a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165143
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b42429f68cb83fcfc5de102b0922b05ecd6c528e]

        Determine OSL_DEBUG_LEVEL directly from dbglevel
        
        ...and reorder the code a bit, so that the dbglevel-releated code is separated
        from the gb_ENABLE_SYMBOLS_FOR-related code
        
        Change-Id: I80649b32fd6cceb8df1e4e2e29e98508e28f338b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165136
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8e10fd30cf7ef5774c54dc2dce0f8e00b279b106]

        $(ENABLE_DBGUTIL) implies $(debug) (aka $(ENABLE_DEBUG))
        
        ...so no need to check the former in addition to the latter (which is done a few
        lines up)
        
        Change-Id: Iefe1ccbd3d22ca4e97425d20d1ff21f68d641b2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165135
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [21d51ae1a41dca6198a3d8563873cbeccb960a26]

        Drop upper-case ENABLE_SYMBOLS, consolidate on lower-case enable_symbols
        
        Change-Id: I6bb6046968a74c49cc8441a1529f9934c90ed50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165134
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [42a76c7bf5a6c5cc60487f4bdc7bf0a7bab3c47a]

        Drop upper-case DEBUG, consolidate on lower-case debug
        
        Change-Id: I352a7c7659e11a4c0800d1a9d73468123b8a5654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165133
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [77b09314b45c178bb8b93e887efb99162c070ab3]

        Drop redundant gb_ENABLE_DBGUTIL
        
        Change-Id: I284e3601ad3d8fe7489e21182a98df40e8d9dbb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165132
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [284d80825ec7cf3c39af91959e4bf3d539b066f4]

        tdf#158556 speed up SwNodes::RemoveNode
        
        Change-Id: I49daf93793c67da6261081fce92e1fed1a71248b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [80570de114d31f4ae5114b6fd6fd3ea365b14d63]

        Related: tdf#160056 these methods can be const
        
        Change-Id: Icf52f1665561eef0aa10febc9ca2f946e89b689b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [472713123b898470a9ce54ee9f19d900dd993d2d]

        Related: tdf#160056 ImpSubstituteEntry can be private and not exported
        
        Change-Id: I895db1f02338b6c2a1fec8bdfc15c2857fbee38f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [64aeb5ad0fa2497007c9ee9808f0881bfec99b24]

        avoid O(n^2) loop in writer
        
        Change-Id: If82328f1cf9cbd6812f9cad8646c9cf5100314e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165047
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bbfe52997225a2fb387c94462c867d670954b9b4]

        vcl: remove 4-bit scanline transformer
        
        We don't use 4-bit bitmap anymore and haven't for a long time.
        
        Change-Id: I00b55a82df4609fbddd50b35f67e338e06f02c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164754
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4dd52211794adc7da2c19cb3defcdef16985c278]

        vcl: simplify constructors of ImpGraphic
        
        Change-Id: I6df0da16d777549e6187327271868774498d073b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164694
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-22  Mike Kaganski  <mike.kaganski@collabora.com>  [805dd6bee49164d9a77de4ea9e0d53b416daca7a]

        tdf#160306: make sure that SvNumberFormatter agrees with ROUND output
        
        After commit 9eb9083ff2fdaeb96399a0830a4394de4e29ef64 (Use Dragonbox
        to implement doubleTo*String*, 2022-02-18), the rounding that is used
        in SvNumberFormatter became strictly more correct; however, it now
        differed from what ROUND spreadsheet function returned, because the
        latter uses rtl_math_round, which calls rtl::math::approxFloor.
        
        To make the visual number representation consistent, this change uses
        rtl_math_round in SvNumberformat::ImpGetNumberOutput.
        
        Change-Id: I05b0bed7d3a6c73584a77adbae2835c95be249fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165142
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [71efd6046488b952f679936ea1c4a415f4989b18]

        vcl: remove SetSizePixel from BitmapEx
        
        Makes no sense (and would case serious problems) to set the size
        (pixel) from the outside of the BitmapEx.
        
        Change-Id: Iab597f755d45be2380884ec6685d119fcc8b1e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164946
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [397d87b9786bebd1ab76f18b472c731bd9ed7884]

        svx: graphichelper - organize UNO types
        
        Change-Id: I08ac95f8065518efb9f46f86a384ed73ab45db23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164945
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e0ef204fdb790343248943426928200b5fca06fa]

        svx: use frozen::unordered_map in graphichelper
        
        Use frozen::unordered_map to map from a GfxLinkType to extension
        or string description and VectorGraphicType to extension.
        
        Change-Id: Ib638c6c8d07b9d2950a145fa66d312f3f6c572de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164944
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [97b0090938b7031cf88622c9e4aeb9cc55030953]

        Related: tdf#160056 can be private and not exported
        
        Change-Id: I3da15340809603b991d3a41beb2af7a0ba375acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165137
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [70c3e8d89983320e4815d92dd232a2840432f620]

        Fix text layout in gbuild.help.txt
        
        ...left inconsistent by recent 76a986da868c52e9bd1cc6d219ed8f9441afd32b "Drop
        upper-case DBGLEVEL, consolidate on lower-case dbglevel"
        
        Change-Id: Ie10c011f2942a013e90c75e0fadd123695d97374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165131
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c7cec6525378aacf873f183b1e03eb959fc998d]

        remove unnecessary statement
        
        we already have the SwTextFootnote, no need to retrieve
        it again.
        Add an assert in case I'm wrong.
        
        Change-Id: I30d79de243dbd4aff587c0653c495150e21a755a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165063
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [d053413402956fecbcf65c9319ebbe2cd6c08dfa]

        ITEM: Remove InvalidateAllItems()
        
        I checked if this is used, but it can be replaced
        using Clear() -> all. This prevents that the whole
        array of Items in an ItemSet gets set to
        INVALID_POOL_ITEM.
        
        I also checked if INVALID_POOL_ITEM/IsInvalidItem
        is needed at all representing SfxItemState::DONTCARE
        but it is and still will need to be set for individual
        Items.
        
        At last checked if SfxItemState::UNKNOWN and
        ::DISABLED really need to be separate states, but
        indeed there are some rare cases that need that.
        
        To make things more consistent I also renamed
        SfxItemState::DONTCARE to SfxItemState::INVALID
        to better match Set/IsInvalid calls at ItemSet.
        
        The build showed a missing UT and led to a problem
        due to the hand-made ItemSet-like SearchAttrItemList.
        The state 'invalid' seems to be used as 'unused'
        marker. It should be changed to use SfxPoolItemHolder
        and not need that. For now, set by using an own loop
        to set to that state.
        
        Change-Id: Ifc51aad60570569a1e37d3084a5e307eed47d06c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165035
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [1f912bdbf7848f8d4073be62ccb589927d60a95f]

        ITEM: Enable MultiThreaded 3D rendering
        
        Change-Id: I3155b075b150f04d0dc93833ab9b6f57eefe71db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165130
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [0cc4333e6fce741c1316c7591e7a4a3e579cec49]

        Disable EditViewActive when Metafile output
        
        This was missing in the mechanism to suppress
        EditView exclusive content, so it is now also
        suppressed in PDF export.
        Also changed TextHierarchyEditPrimitive2D to
        also decide inside it's local get2DDecomposition
        implementation, so it does not need to be#
        supported in PrimitiveProcessors (and cannot be
        forgotten in future implementations).
        Also added support for EditView exclusive
        Primitive's name in idToString (missed that).
        
        Change-Id: I61efc9dddb7d6f0190c7b1fb4b0acf98ab5767f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165109
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-21  Miklos Vajna  <vmiklos@collabora.com>  [d8061151acf4e287b60a055a67b84c56989a37af]

        cool#8278 sfx2 lok: fix lost hide notification on sidebar switch
        
        Similar to commit 55feb670ca28e0a48ac82a65b5559598704d993e (cool#8278
        sfx2 lok: fix unexpected non-json sidebar status update, 2024-03-21),
        the trouble here was not around hiding the sidebar but around switching
        between decks.
        
        This went wrong in commit aaf6ce108e91b1504befe19afcee471e3316ae7a
        (cool#7492 sfx2 lok: set language/locale on async sidebar update,
        2024-01-11), where I didn't notice that
        SidebarController::SwitchToDeck() may emit two callbacks, so the effort
        to avoid code duplication went a bit too far: the hide+show case only
        emitted a show callback.
        
        Fix this by building a list of state changes to emit, so once se switch
        decks, not only the new one is "on", but also the old one is "off".
        
        Change-Id: I1678ee61e004697a6a5c6ecaf40a18b2d1d47e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165108
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-21  Miklos Vajna  <vmiklos@collabora.com>  [a91bb0fe19a24c0473937af82a352901a08e2933]

        CppunitTest_sw_uibase_uiview: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), replaced fonts as suggested by the failing assert.
        
        Change-Id: I528ba0bc7e463c09fb86b424918f7e645cdb552f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165091
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [2326d6a2273e1a5d7c012e0c496fc5275a8e5d94]

        fix some typos in sw::Ring
        
        introduced by
            commit d150ace12b6d8fbb30664d1de1001622720bd53b
            Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
            Date:   Fri Dec 5 03:54:55 2014 +0100
            stick to code conventions for new code
        
        Change-Id: I97b257b85fba5734c6f5dedb141c448e6d30ee46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-21  Patrick Luby  <guibmacdev@gmail.com>  [3c6c5ef5d1c4f555b465bf56cf9d99e4d67224cc]

        tdf#152524 fix crash by skipping second fork()
        
        Instead of calling a second fork() in the child process, replace
        execv() with posix_spawn(). posix_spawn() does not call any atfork
        handlers so the atfork handler that crashes will be skipped.
        
        Change-Id: Iffb70fe4f51b6b324f13e4ac24b740da0a25da99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165103
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de148aa512e02457e43c6db966472a37059fbb14]

        Related: tdf#160056 replace with wrapper GetFormatTable()
        
        GetFormatTable calls mxPoolHelper->GetFormTable()
        
        but asserts if this happens during threaded calculation
        
        so replace the first with the latter
        
        Change-Id: I7027f66a929159525842bfabbf8cf4ab0e55ed23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165107
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e8d01d2447b3350f1bd24e07580402c4c699756c]

        Related: tdf#160056 this can be be a local function
        
        Change-Id: I0ffebd5a1f871b86507d0c1b3946b32993d76365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165106
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49189bb8823adc6a76d3f33b34c02d6a640df96a]

        Related: tdf#160056 this can be static
        
        Change-Id: I1172854a1bf00e74adbe350c54e4e98ea38b0b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-21  Christopher Loi  <loichris97@gmail.com>  [7c76332b52d9b3b967beecc1fe163eea783c471e]

        tdf#143148: Replace include guards with pragma once
        
        Change-Id: I00cee3dc61231a0cc344d404eed4cedda41f4d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165100
        Reviewed-by: Christopher Loi <loichris97@gmail.com>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [1c52e94b2d926875d1a108c54988dbcb2dc9d017]

        tdf#160278: restore cursor bounds properly
        
        The passed string length is not a correct measure of how many steps
        should the selection expand in the resulting text: the cursor goes
        over glyphs, not over UTF-16 code units. Thus, it's easier to store
        the position prior to insertion, and restore it from the indexes.
        
        Change-Id: I1d592ff30199007ba3a99d7e1a6d2db2da35f1cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165056
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [f4ade8244bf984712e65c2eb82cf3319d2679eeb]

        Downgrade sfx::SfxBindings aAutoTimer to an idle
        
        This is a follow-up to commit f45402ae3f5241b460d9f1dcb04183893e1f91f7
        (Fix a spurious JunitTest_sw_unoapi_3 failure, 2024-03-15). As noted
        by Stephan, the failure persisted; it was because the update of slots
        also accessed the changing document model, and it wasn't prevented by
        IdlesLockGuard, because aAutoTimer had a default priority.
        
        Change-Id: Iad8dfadcd35d9611e61e4c011511d6155a343f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165090
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [7132e2975c354dbd29775c7167c324b53032bca6]

        Only hold clipboard mutexes to obtain the values, to avoid deadlocks
        
        Change-Id: I36a2f6e444b8a5397b96d3cba475a8d06ea86459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165089
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1be5fffeb2f845ad40d7f7ceff03f563ebcf8d4]

        avoid O(n^2) loop in writer
        
        Change-Id: Iea5f98e5eb39fb6527be59f2f3dec89a41288a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [14bf98b9bb3765b935316bd3a972f8ef7bb4d21e]

        Update the Android "enough memory for linking" check
        
        ...which had been introduced with 149792414e767c7526123f0e2abb7c4dc9491fa0
        "android: add a check for the installed memory in the machine", presumably at a
        time when there were ENABLE_SYMBOLS and ENABLE_DEBUGINFO_FOR variables, both of
        which appear to no longer exist.  So use the existing ENABLE_SYMBOLS_FOR
        instead.
        
        Change-Id: I1757f49e26e703e4a5831bf2c1f39f9337077d4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165083
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Mohit Marathe  <mohitmarathe23@gmail.com>  [370755c72d0b0a5215d2edd45e30782b1e9d0286]

        tdf#143148 Use #pragma once instead of include guards
        
        Change-Id: Ia55d226aa308413365659b5537eca7a136ec308a
        Signed-off-by: Mohit Marathe <mohitmarathe@proton.me>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165064
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-21  Gökay Şatır  <gokaysatir@gmail.com>  [1de1c47471278db2344c986e9d597d6a05e559e9]

        Moving parts of readonly checks from model to view.
        
        Summary for what's done with this commit:
        init.cxx
            * Add guards for modify commands.
        
        viewsh:
            * Add "IsCurrentLokViewReadOnly" for ease of use.
        
        unocitm:
            * Add guard for modify comamnds
        
        dispatch.cxx
            * Implement readonlyview.
        
        objmisc:
            * Modify IsReadOnlyUI check for LokReadOnly view.
        
        svx.sdi:
            * Disable TableChangeCurrentBorderPosition command for readOnly views.
        
        sw-editwin:
            * Treat mouse moves as readonly when the view is LokReadOnly.
        
        gridwin:
            * For autofilter.
        
        impedit2, inputhdl:
            * For text input.
        
        svdedtc:
            * For sdr object dragging.
        
        Change-Id: I71fc353976256bce22042bbb6042ee464b65cc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165093
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9adcf67c9b164d019eebe45279bcaa91b0ce471a]

        Drop C/C++ DEBUG macro
        
        ...(that was defined iff OSL_DEBUG_LEVEL >= 2) and replace its uses with
        OSL_DEBUG_LEVEL directly
        
        Change-Id: I807c15a02cc8ced9852287df0afb4808761d19d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165067
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [03ab46c8a189b751ed1acffd0b575fae584c1d00]

        Use ENABLE_DEBUG as a better indicator for "debug build"
        
        ...than gb_DEBUGLEVEL as had been chosen by
        448008d64c643d5a1aa2dc5cccc479efcd709a50 "only enable windows incremental
        linking for debug builds"
        
        Change-Id: Iabd2904596b3ac2a9d1c55d074cc929572615265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165077
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [736c00ece12b679d00835b2beba2023468e2c3fa]

        Provide tooling for EditView exclusive Primitives
        
        We have the case that e.g. a placeholder Graphic/Text
        shall only be processed/shown in the EditView of the
        application, but not in any other Primitive-based
        usages, including exports, SlideSHow, etc.
        
        I already thought about that when initially converting
        Draw/Impress to Primitives, but always found other
        solutions, mainly because full XShapes/SdrObjects
        had to be taken into account, that can be handled in
        VC/VOC/OC implementation. But here we have varying
        visualisations of one shape.
        
        Thus I implemented a helper Primitive called
        ExclusiveEditViewPrimitive2D. Anything you embed
        there will only be processed when the switch to
        do so is active in the ViewInformation2D. And
        that switch is only set in the EditView paint.
        
        Change-Id: I307f4b0fe7f8faf98789787f216cac7be86a0515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165066
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ed0c9511dbda2b2bc457030171bec2f655f34c4c]

        Fix typo
        
        Change-Id: I229126f1fc52e85026dd75fb6ce3851653a8e250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165102
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-21  Oliver Specht  <oliver.specht@cib.de>  [44e4ada23dfc8655ec7ddccfd027f02d22684d60]

        Revert "tdf#159730 add compatibility option in RTF import"
        
        This reverts commit 3b04e74503ec6d07dc4befdb756e6abdc3de4e58.
        
        Reason for revert: The compatibility option is the wrong approach. This results in wrong line calculation as seen in tdf#159730#c6.
        The problem that really needs to be fixed is the 9pt attribute of the hidden line breaks in the first paragraph that are used to calculate the height of the first paragraph. 
        Only the 1pt font attribute of the remaining visible space should define the line height.
        
        Change-Id: I6e0a1a499adaf2df9f68afbcfd6afcd6677e8f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165006
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [17ae8327033ee10bc997247fd1b8e75a2be50ff1]

        Related: tdf#160056 this SvNumberFormatter is the one from the ScDocument
        
        and ScCompiler ctor will take that one already. So drop this for
        clarity.
        
        Change-Id: I7fc16b4cd40f08556704bfa2e3ee28d56ed6e947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164869
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [832b98cedda2cd1631651f9397a871fb50d9cb1f]

        libxml2: upgrade to release 2.12.6
        
        Change-Id: I7372b276f74bc760c99580ffc509fde1031cb3a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165049
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4f13189da07673d5c52276297afdd815db6feb98]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bed48919e5708e6c131c6b9b49c9411da0abe177
          - Fix link to Styles menu
            
            Thanks to J. Nabet.
            
            Change-Id: Ic3c3fa8d3b357b15e9fdab041230e142958f51fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165086
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5f2bc59ee9acfb24fc8e5bcc05012f130a360a82]

        Drop remaining boost/shared_pointer debug functionality
        
        ...most of which had already been removed with
        4e354737908b89713297ebf5216eb44f3d9ae990 "remove boost/shared_ptr foo".
        4c657f5a1a340ec9afe795d911625991f6a9cf7a "Properly #if these debug hooks" had
        noted that slideshow/source/engine/smilfunctionparser.cxx "still indirectly
        includes boost/scoped_ptr.hpp via. boost/spirit", but lets assume that nobody
        actually relied on this functionality (and however it would actually work in
        practice).
        
        Change-Id: Ib8ccfcd8019d7b03b138aee1ac026a2f7bd5d402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165082
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Patrick Luby  <guibmacdev@gmail.com>  [fbe350cb9f35039f8b10f8ac9aba6737cb5d84be]

        tdf#93352 Fix horizontal swiping and scrolling when using an RTL UI
        
        Starting with commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2,
        horizontal swiping in Calc moved in the wrong direction scrollbars
        were drawn mirrored.
        
        So, revert parts of commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2
        so that we are using Calc's previous "negative scrollbar range"
        implementation for RTL UIs, but only for horizontal scrollbars since
        vertical scrollbars are the same in LTR and RTL UIs.
        
        Also, always disable RTL for scrollbars. Enabling RTL causes the
        following bugs when clicking or dragging the mouse in scrollbars in
        Calc's RTL UI:
        - Click or drag events get mirrored so you must click or drag in
          unexpected locations to move the scrollbar thumb in the desired
          direction
        - Repeatedly dragging the scrollbar thumb leftward can only move
          no highter than the R, S, or T columns
        
        Note: even though RTL is always disabled for Calc scrollbars, the arrows
        must still be swapped in vcl's ScrollBar class.
        
        Change-Id: I85aac94ffaf7df2eeb251a3ff150cc0363b5d770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164959
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f9da95ca43dc10cda99d985a6365aec2ede3be4f]

        Assume this hack is actually needed for --enable-optimized
        
        ...and not for whatever dbglevel is set.  (The latest claim that this hack is
        still needed at all is in the 2020-12-14 commit message
        e0a90aa3239621958bddbb30f98163e8c1ef857f "The workaround for MSVC C4702 is still
        needed".)
        
        Change-Id: Ia73be9417f2d738b0356e36b978beff019388ae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165073
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Justin Luth  <justin.luth@collabora.com>  [e830394c068c229bb840018f2f0e8810da6a1487]

        related tdf#147583 sw find: fix backwards search for string at end of para
        
        Prior to this fix, it was finding every single character in the document
        when searching for ".$".
        
        Interestingly, the unit test worked even before the patch.
        Not sure how that could be possible...
        
        make CppunitTest_sw_uiwriter7 \
            CPPUNIT_TEST_NAME=testTdf147583_backwardSearch
        
        Change-Id: I20779898c01736eb39ecd7db7d66c2c24e4358b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165037
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-21  Michael Stahl  <michael.stahl@allotropia.de>  [447a15f4772bcbc9366cfa43b92c55ae644e9b03]

        framework: MenuBarManager: fix WNT crash if queryDispatch() throws
        
        a Java extension throws RuntimeException from queryDispatch(), which is
        translated to a C++ exception and thrown by the mscx_uno bridge, and this
        is apparently not handled anywhere (Visual Studio says "Unhandled
        Exception"), and what happens then apparently is the exception goes poof
        and vanishes, and normal return from the mscx_uno bridge code happens,
        but the out parameter used for the return value is never initialised, and
        then the uno::Reference move assignment operator crashes.
        
        Change-Id: I21535fcf0ab4ec30a712d01b5039b7e2fb7b09d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165081
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [71ee4d75d34a25c56d1faf2f89ab57bf79a26e0f]

        Tie javac -g option to --enable-symbols instead of gb_DEBUGLEVEL
        
        ...which appears to be a better fit.  Now, gb_JavaClassSet_JAVACDEBUG is
        unconditionally defined as -g, but conditionally only used if
        gb_target_symbols_enabled is true for the given target (where the target is
        spelled "Jar/..." resp. "CustomTarget_jvmfwk/jreproperties" for the
        --enable-sybmols=... mini-language in configure.ac).  Also, the odd special case
        to "force debug information for OOoRunner" has just been dropped.
        
        Change-Id: Ief10efc689d65e2f50888d3e96cb40f43cbb1b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165071
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Rene Engelhard  <rene@rene-engelhard.de>  [10831c8b7b39f058452e640ba804f5a928441ed9]

        fix 32bit build with clang
        
        seen in a build-with-clang experiment:
        
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:39: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
            maGeometry.setPosSize({ x, y }, { w, h });
                                              ^
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:39: note: insert an explicit cast to silence this issue
            maGeometry.setPosSize({ x, y }, { w, h });
                                              ^
                                              static_cast<Long>( )
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:42: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
            maGeometry.setPosSize({ x, y }, { w, h });
                                                 ^
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:575:42: note: insert an explicit cast to silence this issue
            maGeometry.setPosSize({ x, y }, { w, h });
                                                 ^
                                                 static_cast<Long>( )
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:34: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
                    maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() });
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:34: note: insert an explicit cast to silence this issue
                    maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() });
                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                                         static_cast<Long>(         )
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:63: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
                    maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() });
                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:1473:63: note: insert an explicit cast to silence this issue
                    maGeometry.setSize({ pState->GetMaximizedWidth(), pState->GetMaximizedHeight() });
                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                                                      static_cast<Long>(          )
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:60: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
                maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h });
                                                                   ^
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:60: note: insert an explicit cast to silence this issue
                maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h });
                                                                   ^
                                                                   static_cast<Long>( )
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:63: error: non-constant-expression cannot be narrowed from type 'unsigned int' to 'tools::Long' (aka 'long') in initializer list [-Wc++11-narrowing]
                maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h });
                                                                      ^
        /home/rene/LibreOffice/git/master/vcl/unx/generic/window/salframe.cxx:3481:63: note: insert an explicit cast to silence this issue
                maGeometry.setPosSize({ xp + nLeft, yp + nTop }, { w, h });
                                                                      ^
                                                                      static_cast<Long>( )
        6 errors generated.
        make[2]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:340: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/unx/generic/window/salframe.o] Error 1
        
        Fails with clang 16, builds with gcc 12
        
        Change-Id: I668e3178aaaf528947c96db090f7b458e7f76754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165039
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-03-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [b54dbc842491349ea1fd144988feb7e25ea5f106]

        tdf#159418: sw: Add UItest
        
        Change-Id: Ic41eac4909e85544f5c195cebb59e32745c09f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165070
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [241e2d68664e0e53cf02fe9986462c4a9ecd8d42]

        tdf#158556 speedup docx load
        
        Avoid O(n^2) loop in SwXFrame::setPropertyValue, we even have an index
        to search for this stuff
        
        Reduces load time from 325s to 172s
        
        Change-Id: I6c6c03206ef81be1d7d7702a4313acd23d75442d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4656674fa7daaf6eca13613e31d32382e755fe4d]

        Fix typo
        
        Change-Id: I4b017b9886713423a2b8f445ced297ddc10f6434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165084
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a85aeb1b8354ad6c4da23fe5947147991a573aa5]

        Fix typo
        
        Change-Id: I5e1f9104405329452431ccf663f6916a6cd2036b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165085
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7ef7bdca3c1c82cf0338542c107e8f9e0b838b66]

        Fix typo
        
        Change-Id: Ib12a2b2f76f3819a3c0355f45ef56d3e861530a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164545
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [05252f87e0d5f999be17c020d16217785fa2419f]

        Use consistent conditions in code and makefile
        
        24b06b9c6bdb777dff385b0fbfc81d55d3d013a1 "log access violation on windows
        tinderboxen" introduced C++ code into sal/cppunittester/cppunittester.cxx that
        is conditional on "#if defined(_DEBUG)" (which is defined iff
        $(MSVC_USE_DEBUG_RUNTIME) is TRUE, see the setting of -D_DEBUG in
        solenv/gbuild/gbuild.mk), and it introduced this corresponding makefile code
        which should thus use the same condition.
        
        Change-Id: I62fca71e31ed9215984572dc6a2e05be41651b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165080
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a803d6862c0fe0fdda8e0f615de5f76cb3adbb75]

        $(gb_ENABLE_DBGUTIL) is never empty
        
        ...as it is always either $(true) or $(false).  This had been introduced with
        503ed2f8e3fdbb4d7583b67b0bafcaccc896a5ae "extract calc data dump method into own
        file", but better directly use ENABLE_DBGUTIL.
        
        Change-Id: I75f98915876ca6cb44b8426a8e450464df7f908a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165078
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [76a986da868c52e9bd1cc6d219ed8f9441afd32b]

        Drop upper-case DBGLEVEL, consolidate on lower-case dbglevel
        
        Change-Id: I89e0121ba3d63852e39bf4d6141b0dc15b2408f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2d16901bd49fbb3a6c89bd06f6142aaad87be981]

        ITEM: Added correct NDEBUG define
        
        Method validRanges2() was encapsulated by DBG_UTIL
        but used inside assert, so adapted the define
        
        Change-Id: I695a0c85f389d0c37b24e6e1986037ce6fb0c805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165052
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-21  Miklos Vajna  <vmiklos@collabora.com>  [55feb670ca28e0a48ac82a65b5559598704d993e]

        cool#8278 sfx2 lok: fix unexpected non-json sidebar status update
        
        Open an Impress document via LOK, open the slide layout sidebar, click
        the toggle icon so it gets closed: the toggle icon will signal that the
        sidebar is open, when it's closed already.
        
        This is a regression from commit
        aaf6ce108e91b1504befe19afcee471e3316ae7a (cool#7492 sfx2 lok: set
        language/locale on async sidebar update, 2024-01-11), previously we
        always emitted LOK_CALLBACK_STATE_CHANGED callbacks with plain text
        payloads for the sidebar, where the locale with implicit (with all its
        issues), but the above scenario worked fine.
        
        Fix the problem by making SidebarController::disposeDecks() consistent
        with SwitchToDeck(), so now we always emit JSON payloads for the sidebar
        deck changes.
        
        An alternative would be to improve the code around extractUnoCommand()
        in online.git to handle a mix of plain text and JSON payloads, but the
        plain text payload is tricky to extend, so using more JSON payloads
        sounds like a better fix.
        
        Change-Id: I5b75c2987c230c6720181a1e95ae579727943235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165055
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [31b18d5a5f652dc1bb82ec2828e5f3a951590301]

        Allow extra options in JAVACOMPILER env var
        
        ...similar to how we support this for other vars like CC and CXX.  (I currently
        need this to add -J-Xint to JAVACOMPILER in an attempt to work around the issue
        described in <https://blogs.oracle.com/java/post/java-on-macos-14-4> where macOS
        now sends uncatchable SIGKILL instead of SIGSEGV to the JVM process in response
        to a Java null pointer deref.)
        
        Change-Id: Ie677f97aeca983af7d8ef23e3794103ae30ae0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165065
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-20  Michael Stahl  <michael.stahl@allotropia.de>  [0633e4b4205334dd65ec64d7f3e306ee125e31be]

        python3: upgrade to release 3.8.19
        
        Fixes CVE-2023-6597 and also CVE-2024-0450
        
        Change-Id: Iebca2608e16a966356736201c63f1be5185430d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [c87f46492a41ebb2f9ac61ee8e1f0dd6d3dc90c7]

        harfbuzz: upgrade to 8.3.1
        
        Change-Id: I3dee68e397dc1c6dafa604e84bfcb619f2a33590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165051
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c38b5d7ceaf4c19812e63f6a81ed19ed30ac2f94]

        add a sc-html fuzzer
        
        Change-Id: I0d74859e276bfa98d8abf7b2e66600f849971468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164956
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-20  Regina Henschel  <rb.henschel@t-online.de>  [2eabd56ff5f65733c6fa1bcef14d4a39c21dddc7]

        tdf#70039 import material of extruded shapes
        
        This patch continues the tdf#70039 related commits 98b06ed3 and 6e5529d7.
        It adds further property-value pairs to the property map which is later
        used in CustomShapeProperties.pushToPropSet() for property Extrusion.
        
        OOXML defines a set of 15 material presets in section 20.1.10.50
        ST_PresetMaterialType. The specification lists some values and it has
        example pictures. The example shape uses Bevel. That is not implemented,
        thus the examples are not really usable. Microsoft specifies the values
        it uses in section 2.1.1331 in MS-OI29500] - v20231113. The values used
        in the patch are based on these resources.
        
        MS Office defines the material by the properties 'Specular-',
        'Diffuse-', 'Ambient-' and 'Emissive-Color, 'Specular Power', 'Blinn
        Hightlight', 'Diffuse-' and 'Alpha-Fresnel', and 'Metal'. But ODF, API
        and current implementation have for material only the properties
        'Diffusion', 'Specularity', 'Shininess', 'Metal' and 'MetalType'. The
        patch tries to map the values as well as possible.
        
        The mapping works well for the legacy-foo materials which reflect the
        material in binary MS Office and is base of ODF and our implementation.
        But the preset has also material where transparency is added to the
        reflected light or the reflected light is blended or brightened with
        White. That is not possible currently and such shapes look different
        than in MS Office. These are especially the materials in the
        'Translucent' section in the UI of MS Office. The material type 'flat'
        uses 'Emissive Color'. Such is not available at all. So material 'flat'
        looks noticable different too.
        
        More details about the used values is contained in the attachment in
        the bug report.
        
        Change-Id: I16a242446cbe98efcbdf5452058e1a3bd88dcf56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164853
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [f29222eaf385891620d4868827b27e734752018e]

        libpng: upgrade to 1.6.43
        
        Change-Id: Ia1ddc21dc521cf97b75a64d806417cbfe5dec623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165050
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-20  Justin Luth  <justin.luth@collabora.com>  [91e5d1ef52964dc43875ed62acd766524fa7cc5c]

        tdf#159054 sw: fix .uno:DefaultNumber toggle on Heading numbering
        
        This fixes a 7.2 regression from
        commit c456f839a597f537f1c59becd7d0bb6c86248ef8
        Author: Anshu on Wed Jan 6 15:04:16 2021 +0530
            tdf#115965 tdf#92622 NoList default in menu,tool,sidebar
        
        The current implementation would set the number format
        to SVX_NUM_NUMBER_NONE, but it still looks like a number to the toolbar,
        so toggling didn't work since 7.4's bcede3c0ed94d4
        It also never cleared out the prefix/suffix when toggled off,
        and it affected ALL paragraphs using that outline numbering style.
        
        Remove numbering was doing the same kind of thing.
        
        I think the toggle was trying to follow the drop-down behaviour
        of modifying the outline numbering style itself.
        While I think the drop-down handling could be considered appropriate,
        using the toggle to pseudo-disable the entire style just seems wrong.
        
        This patch kills that, and in addition
        automatically gains all the nice undo/redo functionality.
        
        This is one tiny step in making outline numbering go away.
        
        make CppunitTest_sw_uiwriter9 \
            CPPUNIT_TEST_NAME=testTdf159054_disableOutlineNumbering
        
        Change-Id: Id6a24ac25479cb8f35bf1c2c58344390ed7512fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164985
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-20  Justin Luth  <justin.luth@collabora.com>  [f78c0dfa7a63303533eed17636e7abf8332eea48]

        tdf#159054 unit test: noting the current state before making changes
        
        The historical implementation is rather bizarre,
        so I submit it beforehand so that my patch
        shows the changes in behaviour in a clearer way.
        
        I checked LO 5.1, and while things were slightly different
        (still inexplicable, but not in the same way)
        it still did leave behind the suffix,
        and toggled back on as 1.
        
        So this has never been good.
        Throwing out the old behaviour seems appropriate in this case.
        
        make CppunitTest_sw_uiwriter9 \
            CPPUNIT_TEST_NAME=testTdf159054_disableOutlineNumbering
        
        Change-Id: Id794e629d00480bc5a031aaf0595084cb3eb3559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164984
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-20  Jaume Pujantell  <jaume.pujantell@collabora.com>  [d94288a6f26a6f0d58901732c562dfad861ec4c5]

        jsdialog: send update on spin button range change
        
        On Online, on the Table Properties dialog, when changing mesures from
        absolute to relative, the browser whould complain about values being
        out range since it still expected absolute values.
        
        Change-Id: I2a3ae844b4f4f874ea2140dec313794a87d9f2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164973
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit c3227d33ef18f090d858e93e9dc516db25995ebe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164998
        Tested-by: Jenkins

2024-03-20  Justin Luth  <justin.luth@collabora.com>  [f056f4d45080febc6c912bd623b5df8fa06f87a1]

        related tdf#150197: ensure HasListFormat
        
        Steps to reproduce
        1.) tools - Heading numbering - set "Number" to non-NONE (e.g. 1, 2, 3)
        2.) set a paragraph to "Heading 1" style (to ensure we export style)
        3.) export to assert.docx
        
        hits commit 727c5ed30f68abc28bb04531b25a1df30810760f
        assert(false && "deprecated format still exists and is unhandled.
                         Inform Vasily or Justin");
        
        Not reproduced with "Bullets and numbering"
        
        Change-Id: I99395f8905075dc0ec6ae04a0fd7a28b64da06af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165036
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-20  László Németh  <nemeth@numbertext.org>  [3a332d9f1cacb3c6f81fcf6c08afa51d091ddff4]

        tdf#158885 cui offapi sw xmloff: fix hyphenation at stem boundary
        
        Add new hyphenation option "Compound characters at line end",
        equivalent of libhyphen's COMPOUNDLEFTHYPHENMIN, to limit bad
        pattern based hyphenation of compound words using morphological
        analysis of Hunspell.
        
        * Add checkbox to Text Flow in paragraph formatting dialog window
        * Store property in paragraph model:
          css::style::ParagraphProperties::ParaHyphenationCompoundMinLeadingChars
        * Add ODF import/export (loext:hyphenation-compound-remain-char-count)
        * Add ODF unit tests
        
        Note: slower Hunspell based hyphenation is used only if
        ParaHyphenationCompoundMinLeadingChars >= 3 (we assume that
        libhyphen hyphenation patterns cover the smaller distances
        correctly). Hunpell based hyphenation doesn't introduce
        new hyphenation breaks, only detects the stem boundaries
        from the libhyphen based hyphenation breaks.
        
        Follow-up to commit c899d3608d30f3ab4c2bc193c1fcd765221614a4
        "tdf#158885 sw: don't hyphenate right after a stem boundary",
        replacing hyphenation zone dependence with the new "Compound
        characters at line end".
        
        Note: preset COMPOUNDLEFTHYPHENMIN values aren't loaded yet
        from hyphenation dictionaries.
        
        Note: the suffix of the last stem of the compound is always
        hyphenated, i.e. the distance limits only hyphenation
        inside the stem, not inside its suffix or at the end of the
        stem before the suffix.
        
        Change-Id: I46a0288929a66f7453e3ff97fbc5a0c6a01f038f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164983
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-03-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e68a15941926965575cedcacbe0d301111388bef]

        Fix `cd static && make` for emscripten build
        
        ...which failed with
        
        > error: instdir/program/types/offapi.rdb does not exist
        
        Change-Id: Ie9932960f6e0f6d76070dcdaef792764ac55f51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165048
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3ad680135c8852c896ec7ed7b8ff63fd63ed0621]

        vcl: move Vectorize out of Bitmap - add Vectorizer class
        
        Change-Id: I991b6e908d4139723c2d408d4ba3586676fded18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164693
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [99bd13feb386587262c40d6c474d4fa817da31bd]

        lok calc: show cell cursor on in place editing
        
        On in place editing cell cursor overlay matches the output area.
        In this way the user has a better guess about the edited area.
        
        Change-Id: Iba3370d942a9deaedeed23298a7cb7a6c6c0f5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164701
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit cc88ad715f80b13efb29744673d044df9c16550c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164992
        Tested-by: Jenkins

2024-03-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [6c97cd3691ea0f7d9e580b1c4ea0fca81d47758a]

        tdf#160104 Do not mark file as modified if nothing changed in the Solver dialog
        
        Change-Id: I1bef38a21179bb725c7fb7a08fe90309d26239ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164616
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-20  Gabor Kelemen  <kelemeng@gnome.hu>  [ce7af0dc500efce2975576b1cd401ffc7121c529]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 41a513b0355e7af1c2cde0ae95cc6fc7c23d0526
          - Fix an ahelp in the New Gallery dialogs help
            
            Change-Id: I7f454ff043683c26337ea63468bd0f0b26944633
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/165022
            Tested-by: Jenkins
            Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
            
2024-03-20  Miklos Vajna  <vmiklos@collabora.com>  [d7fb923d1252da2b84438b504db98b6be74554eb]

        CppunitTest_sw_ooxmlexport13: use more CPPUNIT_TEST_FIXTURE()
        
        No need to go via Writer-specific macros here.
        
        Change-Id: I097bf16a3c45024184c20f65e811d9acb1f3e8cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165041
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5e87504307c078a027ad12c66a340579d15c6fb8]

        leaks in initial corpus for sc html import fuzzing
        
        Change-Id: If5bfc9fb557fd449de8173790712f622a1c925ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [85c40af4e9d4c679f66e7f7e004c018dd28994ee]

        null deref in initial sc html fuzzing
        
        Change-Id: I368db8fec4cfd9409197d17f2892153aca2ba502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [62619de850773f55de646dea7e63a52a7e2ef819]

        remove dead code in SwFEShell::GetConnectableFrameFormats
        
        ever since
        
            commit 22fdd136fd549d69030ae375f56539540a291950
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Thu Sep 27 07:51:18 2007 +0000
            INTEGRATION: CWS swwarnings (1.35.128); FILE MERGED
            2007/08/20 15:32:01 tl 1.35.128.5: RESYNC: (1.38-1.40); FILE MERGED
        
        Change-Id: I141257483abf25c4af4a457bb4c181c38ebc788d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0020fc1167b3760d0631001689a44427b72b816e]

        Fix PythonTest_solenv_python for Linux --enable-mergelibs=more
        
        ...where it recently started to fail for me with
        
        > ======================================================================
        > ERROR: test_gbuildtojson (gbuildtojson.CheckGbuildToJsonModules)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "solenv/qa/python/gbuildtojson.py", line 147, in test_gbuildtojson
        >     jsonfiles = os.listdir(os.path.join(self.tempwork, 'GbuildToJson', 'Library'))
        > FileNotFoundError: [Errno 2] No such file or directory: '/tmp/gbuildffqxqxbf/GbuildToJson/Library'
        
        presumably because none of the modules iterated over there happen to put any
        files into the GbuildToJson/Library directory (and, by doing so, would create
        that directory)
        
        Change-Id: I2622f300d6d9c45d28a98fb6bb82aa684d1d5507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165033
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c07548447a564b2d142cc439a124b76e6a71dfbd]

        Related: tdf#108057 Use autoincrement for automatically added primary key
        
        This partially undoes commit 24940e2c3717ad7b07d43db4f08cf7e09cfcc22f
        (#100599# #95927# check if row is readonly and disable autoincrement
        column for auto primarykey, 2002-06-27), enabling autoincrement again.
        
        Make sure to use the largest type that supports autoincrement.
        
        Change-Id: I4dfdbfb0c3d9b94c7634082b029c6e66aa01c782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165027
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1e66905c840dbee0a67e444fca80bdacfcb6e6b2]

        tdf#103068: make sure to update and use current MySQL connection type
        
        1. Don't set selection in OGeneralPageWizard::getEmbeddedDBName. The
        method should only provide a name of an embedded database - either in
        the passed set, or the default one; the activation of controls and
        related actions will be done in the calling implInitControls. This
        makes sure, that ODbTypeWizDialogSetup::m_sURL doesn't get rewritten
        unnecessarily, keeping the current preference intact.
        
        2. In ODbTypeWizDialogSetup::activateDatabasePath, do not use the
        hardcoded MySQL URL from the control, if the current value of m_sURL
        is already a MySQL one. This allows to keep the selected kind intact.
        
        3. In OMySQLIntroPageSetup::implInitControls, do not assume that the
        existing selection means that there's nothing to do. The page keeps
        the selection, even when the wizard's active path was changed; and
        so, the wizard's idea which page to show next may differ from the
        selection. Just make sure to update the setup mode.
        
        Change-Id: Iad98d54a615dccc58b2852a1c0d8aefad6b0b898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164987
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [ec0e9bee23b5950c02abcbe27564b8188f9f789e]

        Pass m_pOleComponent to lambda by copy
        
        Both m_pOleComponent and the copy are rtl::Reference, so the copy
        will ensure the lifetime of the object.
        See https://gerrit.libreoffice.org/c/core/+/164986/2#message-5dd187741df3242f47d1037a1f9c9b0fd9bb1f8e
        
        Change-Id: I092281ce41786682b269ba048f102877117391f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165013
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [53c5d570cab036b23f4969b858a648c8f0c24f93]

        fods2xls fuzzer
        
        Change-Id: I095178b1b3c61829abf5c08b8b81cd7415e3e795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162747
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3bec2d6a8a96102d5a6e93c339601347effa97d7]

        ofz#67495 Out-of-memory
        
        Change-Id: I9c0264b5f474e5448ecaea55e608001438654302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165016
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6dd848baf87cbe48e2b8198104532d5eaf8b8ef2]

        -Werror,-Wunused-variable
        
        (presumably a copy/paste leftover in test code newly introduced in
        8b58007fc5a619012b58a1f8d8731a753bc1c40d "tdf#147583 sw find: fix backwards
        search for emptyPara/endOfPara")
        
        Change-Id: I50074a8c633a38818027156f915731eda05c49e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165030
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5d283f4224d73c89242099d1d4ccbfd6df9c2a82]

        Exclude Library_postgresql-sdbc-impl from --enable-mergelibs=more again
        
        ...which had been added there with ae17922b7d0f797129dd5fbd5514d691ac9ebeaa "add
        more libs into --enable-mergelibs=more build".  But:  For one, I'm not quite
        sure why the postgresql-sdbc functionality is split into two libraries
        Library_postgresql-sdbc and Library_postgresql-sdbc-impl, but there's supposedly
        a reason why the latter should stay in a dynamic library of its own?  And for
        another, at least my --enable-ldap --enable-mergelibs=more
        --without-system-openldap etc. Linux build now started to crash during exit of
        CppunitTest_sd_export_tests-ooxml2 with
        
        > Invalid free() / delete / delete[] / realloc()
        >    at 0x4845B2C: free (vg_replace_malloc.c:985)
        >    by 0x1C5C11E3: ber_memfree_x (memory.c:152)
        >    by 0x62895DC6: ldap_int_destroy_global_options (init.c:543)
        >    by 0x40010F1: _dl_call_fini (dl-call_fini.c:43)
        >    by 0x400506D: _dl_fini (dl-fini.c:114)
        >    by 0x4EE7FD5: __run_exit_handlers (exit.c:111)
        >    by 0x4EE811D: exit (exit.c:141)
        >    by 0x4ECF150: (below main) (libc_start_call_main.h:74)
        >  Address 0x103070f1f7f00 is not stack'd, malloc'd or (recently) free'd
        
        apparently because there are two competing at-exit calls to
        ldap_int_destroy_global_options in both LO's
        workdir/UnpackedTarball/openldap/libraries/libldap/init.c in
        instdir/program/libmergedlo.so (where that code ends up now, instead of in a
        library of its own that would apparently not happen to be loaded for this test)
        and in
        /usr/src/debug/openldap-2.6.6-1.fc39.x86_64/openldap-2.6.6/libraries/libldap/init.c
        in my (Fedora 39) system's /usr/lib64/libldap.so.2 (which apparently happens to
        get loaded into the process due to whatever other dependency).
        
        Change-Id: I5f4b944dfe2e09df2c6d33fc31d4dded4a453c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165025
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-19  Gökay Şatır  <gokaysatir@gmail.com>  [d50d40b12cf3077dd83e7d3da33e6f3a15e44e14]

        Allow enabling comment editing in readonly view mode.
        
        Online side can set this property to allow comment editing. This is the infra.
        Implementation will be in another commit.
        
        Change-Id: I3a6f1ad6818c2c6587d98896c3d6d913d51a2295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164988
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [02c67183f14fffb3578fa8713b865a568dc6b648]

        remove leftover PresenterScreen PCH files
        
        Change-Id: I5766d6ec6f6b72800e9350818617881bb61ef042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3f7a2437931c03722b3758da564a9f47c89707c1]

        Add some missing test dependencies
        
        ...that I stumbled upon with a from-scratch build of this test
        
        Change-Id: I17d5a87b6af47276877bffdcccb923fd037570b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165026
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [6178387f7bcc35df9272978ec936f8b53c6da80d]

        tdf#159985 Warn about the need to reload file after changing macro security level
        
        Change-Id: I191fd5d676d6d54fb0ef15652420afdceab2fc78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164810
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a1fbfbabbf65bbddd99e1e660ea5435abc8d9ca9]

        update credits
        
        Change-Id: I72d86d1a7dcadf3e015b5f9a3eb98d56fb9a49c5

2024-03-19  Regina Henschel  <rb.henschel@t-online.de>  [aa341e79ee241fec0b5afe159b0c674cf85a52c0]

        extruded shape import: tweak threePt light rig too
        
        This is an addition to commit 98b06ed3. The light rig 'threePt' has the
        same problem that with only two lights the shapes are too dark.
        I simply overlooked this rig.
        
        Change-Id: Ib71088f24245da912cf0886e75841ffd6cec786f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164975
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-19  codewithvk  <vivek.javiya@collabora.com>  [9b6fcd41a7b8f6f844a26e77bb6439caa9bc8e98]

        Remove static font color for headings in Calc
        
        Previously, Calc utilized a static font color (dark) for headings, which resulted in visibility issues for Heading 1 and Heading 2 in dark mode. This commit resolves the problem by removing the static font color, allowing for automatic color adjustment.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: Idf516077a8cda951c593052c63e53b4d1301d138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164990
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [73567d60a1c4d2dded06f49df1fae95467e558c3]

        ITEM: Move TotalCount to WhichRangesContainer
        
        Change-Id: I2ab1cd2d0be81b15b4701581093b696aaac2846c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164979
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-03-19  Miklos Vajna  <vmiklos@collabora.com>  [9905a510fe62c1f64dc7786ac818fef9d5a8e25a]

        sw: document SwCursor
        
        Not to be confused with SwShellCursor, which is only the UI cursor,
        while this is more general.
        
        Change-Id: I2b83dbaa48c9e94db45e997b2b8fef23e3840800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164989
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4645391b56c32d59f241e66798f72183ad29ad13]

        AddressSanitizer: container-overflow in initial sc html fuzzing
        
        Change-Id: I20d7baa6fd6fcb9c7d0019d7891a237dd721ef31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [79ccc9866aff73e953642ec2610438855ab0f088]

        leaks in initial corpus for sc html import fuzzing
        
        Change-Id: Ia7a9d6b283dcf127dccf734fb45cf8ac3dde5478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4496544f5d7ea9eaf83478a8846e14455d5dda3c]

        Remove unused namespaces from xmloff
        
        Change-Id: Id46c9512b8024c9dc50edfb200599b1901fbf3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164940
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-19  Mike Kaganski  <mike.kaganski@collabora.com>  [0c9f650136277b708912a86a6867ec91c8b384a5]

        Release the mutex when calling the OLE method
        
        ... which may need to be executed on a different thread.
        
        Change-Id: Id9e4b86fd3eafa49139b21e3817aa1ee8aff3dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164986
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aa76c9e27d5ab2bed4b056ab41d7c1dfc628486a]

        Fix typo
        
        Change-Id: I40e237a2acfe67cb9b40f1018e1a236616b2fe29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164971
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1dc579ae9cd7fcf504016ef510a9484173c9392d]

        calc html filter ScDocShell* deref for document properties
        
        ScDocShell is optional in other parts of this filter
        
        Change-Id: If219cfa6ef737a9695b85bf6db5d45e9750a7ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-18  Regina Henschel  <rb.henschel@t-online.de>  [21d39b5a8c36203d18c5d67c9d2f2bb8d89a53de]

        Clamp extrusion light level to allowed range for ODF
        
        With import of shapes in 3D-mode from pptx files, the internal values
        for light level might be outside the range 0..100 and thus not allowed in
        ODF. These high levels are needed to get a similar rendering to
        MS Office.
        
        The export to ODF clamps them now to the allowed range.
        
        I do not intend to change the export to loext namespace, because the
        extrusion mode of custom shapes needs a totally new handling. But that
        will not be possible timely for version 24.8.
        
        Change-Id: I839903cbaf1b304c1e0c4374080963bc70352e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164948
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cda5ecdefe5a52184930aba56c2af20a8c30622d]

        cid#1594402 Unchecked dynamic_cast
        
        Change-Id: I01218f7c457b23539ca911ab1bf4a910198285b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3228b3966522c27ebe009a0abfdcabea37053865]

        cid#1594401 Explicit null dereferenced
        
        Change-Id: I0ab5cedcf5c573fa00aca4c51f021251974337ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [74f4f7a9c7a836c7b2a49bf3d61e7e6303071ee9]

        use our internal backtrace API for signal faults
        
        so we get nice stacktraces with function names and line numbers on
        jenkins
        
        Change-Id: Id1bfee014d713ead501e5164e5206d9189ec72a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-18  Justin Luth  <justin.luth@collabora.com>  [8b58007fc5a619012b58a1f8d8731a753bc1c40d]

        tdf#147583 sw find: fix backwards search for emptyPara/endOfPara
        
        A comment added 10 years ago thought that it had never worked.
        
        The very last paragraph end cannot be selected manually,
        and so of course it can't work in find either.
        It didn't work earlier either.
        
        Everything goes ballistic if searching inside comments,
        but that would be handled elsewhere anyway I guess.
        It didn't work earlier either.
        
        Keeping the search "inside the selection" didn't work earlier either.
        That should be fixed now.
        
        make CppunitTest_sw_uiwriter7 \
            CPPUNIT_TEST_NAME=testTdf147583_backwardSearch
        
        Change-Id: I48a72084d277b8c270255de9296a2743162937cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164892
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-18  Justin Luth  <jluth@mail.com>  [5441ed518d36ac12a6bd0c517e2cfc24aff94d50]

        tdf#40244 tdf#160192: create tempFile elsewhere if LogicBase is RO
        
        This avoids a crash/infinite loop in specific read-only folder
        situation (where the lock file already exists).
        
        It also fixes ODF files giving three misleading/unclear
        notices when attempting to save into a read-only folder.
        
        When LO saves a file, it saves to a temporary file
        and then moves that file overtop of the previous one, IIUC.
        
        Prior to 6.1 5259ab8104cfba60c40748ed0cd59d93df038c5b
        that temporary file was stored in the /tmp directory (IIUC),
        but was changed to be in the same folder for easier renaming,
        same filesystem etc.
        
        Note that typically this situation would fail
        since a locking file also could not be created.
        However in the case where the lock file already exists,
        then all the pieces are in place to actually modify the document.
        
        By falling back to the /tmp folder if the document's folder
        is read-only, we can still modify a writeable document.
        
        Change-Id: Ie027fc05934f2c071f7a91007255801c179bff49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164841
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-18  Mike Kaganski  <mike.kaganski@collabora.com>  [26fcbe463c2f91353463bd826f570ca7945c8987]

        Add a notice about "published" to the IDL API documentation main page
        
        Users don't realize that they may see not only published interfaces
        there. Seen e.g. on https://ask.libreoffice.org/t/103621
        
        Change-Id: Id93bb12c1871fcfe85b71be01be0995ee2a83ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164962
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-18  Noel Grandin  <noelgrandin@gmail.com>  [c454dfe6affa295156bfa8dd272a770433649d9f]

        reduce symbol visibility in svx
        
        Change-Id: I6d98aab59799365c9a0052f259cd5c8208d995bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164961
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [26f7313f724921a9c6086e6c2a93fbe1c48635fa]

        Update git submodules
        
        * Update translations from branch 'master'
          to fac4254ccc98b1780ff434343fbd75f843774fbf
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I762879bd0d2055119909ad181146f7ab0a63713d
            
2024-03-18  Miklos Vajna  <vmiklos@collabora.com>  [0f1194bff86f2b34df624c0a67b211ab98bcf729]

        svx: prefix members of SdrLayer
        
        See tdf#94879 for motivation.
        
        Change-Id: I35c1b90b472a27b34a3ca31cd81cd1fa65b24843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164963
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-18  RMZeroFour  <ritobroto04@gmail.com>  [db3b31c433320d15bc5f1961d026ef056cd8842c]

        tdf#145614 Convert GCM_PROPERTY_ID #defines to enum
        
        As part of the efforts in #145614 to replace older parts of the
        codebase using #defined constants with enums, this turns the
        GCM_PROPERTY_ID_* values into an unscoped enum.
        
        Change-Id: Iafb9960b87fcd12f6596578866856fabed8ecd04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164942
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-18  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a741dd2cd5059e3d6a06307fb7c6c016b4099c81]

        find-unneeded-includes: add option to detect unneeded namespaces
        
        Sometimes there are unneeded namespaces included, these can be detected
        from the IWYU output.
        This mode makes a suggestion to remove these, then in a subsequent normal
        run some more headers can be detected as unnecessary, whose presence was
        justified by the "using namespace" statement.
        
        Change-Id: I45616537925ec0d09039edf3d9237ffbd13e2410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164939
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-18  Kurt Nordback  <kurt.nordback@protonmail.com>  [9ae8e74fb32254c81d36b1c95411605459e06372]

        tdf#50934: Add a pie-with-remainder-as-another-pie chart type
        
        Implement ODF import/export for bar-of-pie and pie-of-pie types,
        and add simple tests for this capability. The associated ODF tags
        are implemented in the loext namespace. This also required changing
        the schema.
        
        Change-Id: Ib55ae1c5818ad810f7b962d807a9163a3d02ba17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0306ff34c8ab81e1d530b71974790819ed95bf98]

        update output of script
        
        and trim the classes.results file, we are not interested in the low
        numbers
        
        Change-Id: If9ed3178b94cb65b3d8cfdcd7836196cb1a335ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164925
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3bec19bfbcc90ec475dc57cf458ce3cb5974780]

        reduce symbol visibility in svx
        
        Change-Id: I8d103f3607f273677f075ae800f2f8477c751e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [479b5bbe8ca2177ba7574e7aa2308b5d0de1895c]

        bump odt2pdffuzzer max_len again
        
        Change-Id: I124f97e1f3c024d05f29079bc699cf0ea12d06d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164955
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81fa9b03ca8175d2be8ff261916d22c54a4d73a3]

        ofz#66825 Out-of-memory
        
        Change-Id: Ic3ce086dc6ba3f85824ec1e68d7501f278f758ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [8cce20756857cc3c42a2f9393afe6886c4abc1ea]

        Move undo info creation logic into ScUndoConditionalFormat
        
        So it is near the code that applies the undo data. This makes it easier
        to synchronize the logic.
        
        Change-Id: If3d41ae6b0afafc81e149756cb327f1fca6f2bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164943
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [144dd13818581e8753c2b0a8707ffe047837f273]

        loplugin:unusedmethods
        
        Change-Id: Ib0a72355972662c6b902bca9a527be91fb3e1d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [e501580dec3ddf3ca55c97a04a3f1a2b1f802eaa]

        reduce symbol visibility in vcl
        
        Change-Id: Ibe6154dc5de6251fb39952caa190d53a6fd1fd89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164926
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [c492de66a077f3a2a960209b0b8b278b3901f361]

        tdf#160149: save and restore the whole set of tab's conditional formats
        
        ... instead of restoring it only for a range, and then have troubles
        deciding how to join the range's formatting with the rest of tab's
        formatting.
        
        Change-Id: Ie422893c7847b1473a86c0cd8fc3916144eb24ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164937
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-17  Julien Nabet  <serval2412@yahoo.fr>  [9661b094e10602148c3cf68bcce01f4a6714bedd]

        tdf#160225, related tdf#92768: hide axis title not taken into account when...
        
        duplicating sheet or when saving a file and reopen it.
        
        When creating a title for an axis, "createTitle" is called.
        Before tdf#92768 "support hiding title objects", when unchecking "axis title" in sidebar,
        the title was removed (via "removeTitle")
        But since tdf#92768, "hideTitle" is called instead.
        
        The pb is "Visible" attribute wasn't registered in StaticTitleWrapperPropertyArray.
        So when duplicating sheet after having created a title and hidden it,
        when duplicating sheet, the new sheet had the title visible.
        In the same way if, after having created a title and hidden it,
        you save the file and reopen it, the title is displayed.
        
        Change-Id: I980505ec02906e673dd60a60e4d9837928bf8876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164938
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Patrick Luby  <guibmacdev@gmail.com>  [39663a323c3330c18b610fcdc9e9c75ddac770f1]

        tdf#160036 Enable SKSL when using Skia/Raster
        
        Starting with the upgrade of Skia from m111 to m116, SKSL is disabled
        by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to
        enable it.
        
        Also, reenable XOR drawing unit tests that were previously failing.
        
        Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [f58b9659067de7fd8fcd8391b4bf1a2513cedaf7]

        tdf#160122 Increase height of the Solver Options dialog
        
        Currently the Solver Options dialog (Tools - Solver and then click the Options button) has a height of 6 rows, which is good for the Linear and Swarm non-linear solvers, since they have 4-5 options.
        
        However, the SCO and DEPS engines have 12 and 19 options, respectively, so it is very unconfortable to view and scroll through these options with such a small dialog.
        
        This patch raises the height of the dialog to 12, so that scrolling is minimized, making it more confortable to navigate through the solver options.
        
        Change-Id: I51c1c6880613818dd91c6bb8494775c863e8b406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164749
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f43f00d55bc32fd62c2f72cb0343f9419eb8491]

        ofz#67445 Timeout
        
        Change-Id: I968f57c9c71e764ade189deca1534983e33cc401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164932
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [65e3e9b448bb547167ef7ec6d2dfe537ecf8a565]

        fix gdb pretty-printer for basegfx::B2DPolygon
        
        probably broken since around:
        
        commit 347112fbd89ebd2a244052f14e085c9d3c90838d
        Date:   Sun Oct 8 13:14:39 2023 +0300
        
            Drop temporary aliases from Tuple2D and Tuple3D
        
        Change-Id: I117e719dd654fb063811750fdf20d353a82b6996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164934
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0aaf804de48076bd8bed6459b7c40d87eea4535e]

        ofz#67408 Build failure
        
        use of undeclared identifier 'SVP_CAIRO_ALPHA
        
        Change-Id: I546d2d203929702e46bd6de6242d70c21b636885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164931
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [24cf7ffcb06c47e1084f08c7bcdcf15fb29f75ea]

        Resave securitylevelpage.ui with newer Glade
        
        Change-Id: I9a2c3b5d93453730baccec37fa0a3ac91808bad9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-16  dmc_dev  <davidcarter.codes@gmail.com>  [d969251911a3499c78a3e09e0a6eb0285e8ab05c]

        tdf#143148 update all headers in idl/inc to use #pragma once
        
        Change-Id: I65a5d21bed1753f3dbb5ad1b87fb76ea16066413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164928
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [471bbaf15fb392a194b9392d982cf2e33495f4b3]

        loplugin:unusedfields
        
        Change-Id: I91ec189ea1f389a978ef56339bbf6b43cbec6798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [55bf8a21d06c47760976f4d0051248797be47a61]

        Fix typo
        
        Change-Id: I67c1591af46b530c3cbf46b0871d863a5c0aec24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164907
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [08750535c5c88dced2e46710506efc06d8312c0f]

        Fix typo
        
        Change-Id: Ie04b3b3a96b2d4651b6dc477215f29a48c1be4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164901
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a0d5d8d16595dd9e9b2adcdd1817650b25569554]

        Fix typo
        
        Change-Id: I1264c4594bbedf7398816552795e33c489ef2863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164902
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3764ae10f86f4b40f98b0e69e61268604c331c27]

        Fix typo
        
        Change-Id: I8c5c281897c53afb456b63c5f3838059bd1887d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164912
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [42a01a525b325bf381cb5e08bc74416d1d4d64a5]

        Fix typo
        
        Change-Id: Iac27e35e92ec8f481d0d6ba71c87f72e10a99ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164910
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5569de72d7e8c4db34df5ffa10e0f46234cff1e7]

        Fix typo
        
        Change-Id: I07c180c9b659950fa0ecc4bf8ca26f2d133a393c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164913
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d845d151fd17428082aef4033353a60d7540ec3d]

        Fix typo
        
        Change-Id: I5bece7e286f8ebced0f5f45fff7377037b546a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164918
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da7c50f6f74e79201e23cdc032b2288b6679e2c9]

        Fix typo
        
        Change-Id: I0db6ac0b9edfd6953d668dd0949c692630665a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164915
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [66567a0bcd9374fcc99813315c02b64b2c5a2066]

        Fix typo
        
        Change-Id: I3620d218898a91293d57611d4dcf062f75045892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164897
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1215a2e085395a38fb83ad1a854d698c0e9cf31]

        Fix typo
        
        Change-Id: I0a68811af1f5b9d32f453592ec357fa694747d35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164909
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b360a2b64f4c6937f92fc01614d21faeeca42bf2]

        Fix typo
        
        Change-Id: Ibb07cca05ef733932326ceb29aa3fd1cd1e969d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164896
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f9a557813633f95ff7191241955fa343093be21]

        Fix typo
        
        Change-Id: Id099d4e9471415d572f7eac56e70d20cbae8e577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164906
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7abfe574e2c5ef026ea31d5ae2e76315fa842569]

        Fix typo
        
        Change-Id: I42521b965da582e00e4fa9186bb5de3ea3defd4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164905
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d7d37ac32c5c7828d376fd71e4a3f5fbc359a22f]

        Fix typo
        
        Change-Id: I2e38b46435d927fe4fe8d656c92e7a75a5771ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164911
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e0a186d18b1fabe85816d9656925dce9b552dd0]

        Fix typo
        
        Change-Id: I3f6f98e2781dd6ca37483ca4224b76f7b474a909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164908
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36f6aea73fcac19d14d5362476e9de6887d92612]

        Fix typo
        
        Change-Id: I5b5182b56259808e7c4c351f24510806bf79c9fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164916
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5640b1b0d340301e0b90506952eef2d67e0b8ad1]

        Fix typo
        
        Change-Id: I58ae1ae35bef53a79dfb60ac17b485e7e22a8d87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164900
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c68303fb07ad061fc55e978064fe8bb959a3a6fe]

        Fix typo
        
        Change-Id: I6e332fc1366cf6cc20f7d4bbb546996bcfcfc6f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164919
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c42fca202ae6aeecbb85b18e9166bab050a48f9]

        Fix typo
        
        Change-Id: I5c2075d5c3e87fe5e4f56d884bf7bcfb7371498b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164917
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [26785eed7615fb9467892d59f6b9a525e388980f]

        Fix typo
        
        Change-Id: Ib1f5fdc8c44c62619325f6d21d834459905fab44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164921
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5b7e83ddb004c1e97ccaba3ef6967f152c44e7f5]

        Fix typo
        
        Change-Id: I54dff81d7dffda684f3e39a5ebf1dda06959b9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164920
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [85eb0d1394f1c867e932671192fecc815c5915eb]

        Fix typo
        
        Change-Id: I965793a29a92eedb5555b541a22b5be0350c6b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164923
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da56c68f5a3ff0c7f310224e83b7a60cb8b38632]

        Fix typo
        
        Change-Id: I493fece1547f15d1e428146928e34807a96636a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164914
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d097dbc8688b32e7865eca3baab1dd406c306441]

        Revert "make skia into static library"
        
        This reverts commit 806b6014db796a3970332f9cefaaabf9355d0d8f.
        
        Reverting for now, this does not work with --enable-mergelib
        
        Change-Id: Ib44f819d0da9ed3769f76fc40b5c15ce097390a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164872
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2024-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ccaed03f7680bad28a6ecf03f10d8c77221c83c]

        slightly speed up XLS import
        
        we can use an unordered_map here
        
        Change-Id: I445521d9dec2d49d9df7d2a733a43330d0996ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5208cc2995a0dfb0377b9d14df469e67939de012]

        Fix typo
        
        Change-Id: Ic25c4b9fe4fe898de328f1ea98ef69983c66a7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164904
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4640cec9206f890bd79fee2310f6ee144aa12752]

        Fix typo
        
        Change-Id: I794f03ec9fe6cc7f1adfe790432a3e252da54b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164903
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ff7ed8ccca4165ecc4b23a9670ceb63fe8e8a313]

        Fix typo
        
        Change-Id: I8c2e3dcfddd27aa7d32feb7a3c7923b411cdafa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164899
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [effb43e5ac8ebb478e6d277a66c844d14769415e]

        Fix typo
        
        Change-Id: I26ad4b2cc6738087bb9cbae6eb5e852d7d520c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164898
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0a4f0ae2cfba246cb6a2708b9db5dab8fc71e6a9]

        Building with Clang needs at least libstdc++ 10
        
        Not sure how 02f48a32400f81413329d81203c417521882cab6 "Adjust for new linux
        baseline" had decided to declare "Clang 12 with libstdc++ 8.5" sufficient for
        building on Linux.  But I just experienced that building recent master on Ubuntu
        20.04 with its libstdc++ 9.4.0, against a (lode-built) Clang 12.0.1, failed with
        
        > codemaker/source/commonjava/commonjava.cxx:45:21: error: no matching literal operator for call to 'operator""_ostr' with arguments of types 'const char *' and 'unsigned long', and no matching literal operator template
        >             { "void"_ostr, "java/lang/Void"_ostr },
        >                     ^
        
        etc., apparently because the use of std::copy_n in constexpr O[U]StringLiteral
        ctors is not yet constexpr there.  And
        <https://en.cppreference.com/w/cpp/compiler_support#C.2B.2B20_library_features>
        indeed lists "P0202R3" (i.e.,
        <https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0202r3.html> "Add
        Constexpr Modifiers to Functions in <algorithm> and <utility> Headers") as only
        available since "GCC libstdc++": "10".
        
        Change-Id: I9d8ee2833f3b0c6c24059ec6e5d4dc8994058a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164895
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-16  Noel Grandin  <noelgrandin@gmail.com>  [806b6014db796a3970332f9cefaaabf9355d0d8f]

        make skia into static library
        
        We only need it inside one library,
        and this reduces the symbols we export from libmerged by over 1000.
        
        Change-Id: I8bf1b2479ba61e931dab0a5cfa81484d534c5658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164846
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc60e2eacdf2d55e0f52754d1e0801479b199615]

        reduce symbol visibility in vcl
        
        Change-Id: Ia56bb092a4634e301ff8922ae63e6f7ede874d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-16  Justin Luth  <justin.luth@collabora.com>  [0b7494dfd361f7f2f7d8257b0a8a233a11f00679]

        NFC flatten sw FindTextImpl
        
        and /opt/lo/clang-format the changed lines
        
        There hasn't been much change in this function
        in the last two years, so now is a good time to flatten it.
        It will be easy to backport this commit
        if any fixes to this area of code warrant backporting.
        
        Change-Id: If2503ae1ea6e29426f256284efa730edbb157b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164891
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-15  Justin Luth  <jluth@mail.com>  [f56b2dcb5f8b264366a7f7945f3d5ad83aaa7ea8]

        tdf#160192: avoid crash when trying to overwrite doc/lockfile in RO dir
        
        Bug exposed with 6.1 5259ab8104cfba60c40748ed0cd59d93df038c5b
        sfx2 store: create temp files next to local files
        
        Change-Id: I769096f5ee1b2568e198c1e53b71c10af58f5c9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164850
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-15  Justin Luth  <jluth@mail.com>  [c615fba780da5ac3073fe5a00848824f59ee376a]

        tdf#160192: avoid hang when trying to overwrite doc/lockfile in RO dir
        
        Bug exposed with 6.1 5259ab8104cfba60c40748ed0cd59d93df038c5b
        sfx2 store: create temp files next to local files
        
        tested on .doc format, code-read suggests it affects xls/ppt too,
        but they throw exceptions, apparently before hitting this section.
        
        I was seeing an infinite loop on SfxOleSection::SaveProperty's
            while((rStrm.Tell() & 3))
                rStrm.WriteUChar( 0 );
        
        because nothing checks to confirm that the tempfile
        is actually created/useable.
        
        Now, instead of an infinite loop, we get a crash...
        
        Change-Id: I9e093432361a8ad6f928ec9b47290274b3d4ef06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164840
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-15  Justin Luth  <justin.luth@collabora.com>  [397cacaa13dd8c102fb467a0c769597a60a2cfbf]

        DoSearch's pPam was not optional - made it an SwPam& rPam
        
        oPam also is not a real optional - it is always populated
        by MakeRegion, and known to be non-null since it was used
        in the containing while loop clause earlier
        
        Change-Id: I33133c8f9f9188e57fe100f3c455dc92453d05f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164868
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-15  anish.deshpande  <anishmdeshpande@gmail.com>  [bbafffa0ebd837a2951b0730a9a95c116c8e8fe8]

        tdf#114441 change use of sal_uLong to better integer types in dbaccess
        
        Reason for changing m_nThreadEvent:
        
        This variable denotes the number of events happening on one thread of the
        processor and is calculated from a sal_Int32 value.
        
        Change-Id: I1c76368b3dc1f649e6d800cde8c2a841ff5b82f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164170
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-15  Skyler Grey  <skyler.grey@collabora.com>  [c3327640208fb5117ca88878afd7e716981372c7]

        exported SVGs: Stop bullets skipping animation
        
        Previously, we used the incorrect format for bullet point IDs, leading
        to them not being noticed by animation code, leading to them being
        skipped during animation.
        
        This meant that if you exported an SVG of an impress presentation, and
        you had a bullet list animating to appear later, you would see the
        bullets without the text from the start.
        
        Change-Id: Ibce764c0843778dd09b108fb251ce606255afb90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164661
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 5ee89034692eb21f9a71c9a36cc205b09f24e856)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164871
        Tested-by: Jenkins

2024-03-15  Jean-Pierre Ledure  <jp@ledure.be>  [c5e0c65bd26664349fb7c80a792e2fe949fee0fe]

        ScriptForge - Python typing hints
        
        Python typing hints may be stored either
        - inside the original .py source file
        - in a separate .pyi source file (aka. STUB).
        Choice is made to create a new scriptforge.pyi file
        - to allow hiding the private functions
        - to specialize each module: technical doc
          vs. user doc
        - to allow potential later translation
        - to minimize the impact at run-time:
          stubs are active only during code edition.
        
        The new scriptforge.pyi module
        - provides the static type checking of all the public
          interfaces (methods/properties) of the ScriptForge API.
        - when the user uses an IDE like PyCharm or VSCode,
          (s)he might benefit from the typing hints provided
          by the signatures and docstrings stored
          in the module.
        
        Visually, while editing a user script:
        - hovering an object instance, a method or a property
          displays its detailed description
        - a "." after an object instance displays a drop-down
          box listing all available interfaces
        - brackets after a method-name start code-completion
          by displaying its arguments.
        
        Limitations: SF supports ProperCase, lowercase and
        camelCase naming for methods and properties.
        Only ProperCase is described in scriptforge.pyi.
        Extending to the other 2 notations would be easy
        but would also overload needlessly the drop-down lists.
        
        The effective code (scriptforge.py) is completed
        with a series of importable variable types,
        corresponding roughly with the available service
        instance names in uppercase. Example
               from scriptforge import CALC, RANGE
               def userfct(c: CALC, r: RANGE) -> RANGE:
                   r1: RANGE = "A1:K10"
        Objective: enrich the signatures in user scripts
        and benefit from the same hints when the variable
        types cannot be derived from the context.
        
        The help documentation should be complemented
        with the actual additional feature.
        
        Change-Id: I6c39939a3cdbed94828e9449cd691fe15c24c923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164867
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [a6bb2e837264451ed896dd6783249e335e145605]

        sw a11y: Disable unreliable CheckIndeterminateState test for now
        
        Running the test was enabled in
        
            commit 97337f5395ca1f4597690c97a19da9fd55ee1c66
            Date:   Thu Jan 18 18:30:09 2024 +0000
        
                Fix sw_complex JUnitTest not running
        
        , but it turns out both the current Java test as well as the
        pending C++ port are unreliable, see discussions in [1] and [2].
        
        Therefore, disable it for now. If the underlying issue
        gets fixed, it can be reenabled again.
        
        [1] https://gerrit.libreoffice.org/c/core/+/162263
        [2] https://gerrit.libreoffice.org/c/core/+/164231
        
        Change-Id: I490d012b73154203884bdd966bfcafa889ac820c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164861
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-15  Heiko Tietze  <tietze.heiko@gmail.com>  [aacce8abe239ad679f5e9f9ce9bf2d27fb046d5d]

        Resolves tdf#160167 - Remove pointless frames in bullet & numbering dialog
        
        Solves the issue that the "Selection" label is inappropriate
        
        Change-Id: I1bdaa6922796fcdceec0aac6902011aa21cd9aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164758
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ee5b9597605176af0c80f9ea28caac9ba7980254]

        Related: tdf#160056 IniLnge is immutable
        
        no lock needed here
        
        Change-Id: I00461d44f78e9776568492fccb7dee0e9869944e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [485ae0bc7e1a1d615dd1d4133d3e42d655dec029]

        tdf#48062: use mergeToSinglePolyPolygon instead of createPolygonFromRect
        
        Otherwise, in files like
        https://bug-attachments.documentfoundation.org/attachment.cgi?id=193126
        where no rectangles are used the mask is displayed
        as a rectangle
        
        Change-Id: I8cafb22bd6055db729d0d56b4756119d7989abb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164863
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [8a0543f9fec90b0b7538fa5f219c9dc38b07ea34]

        gtk4 a11y: Report default text attributes
        
        Implement handling of default text attributes
        by implementing the GtkAccessibleTextInterface
        method `get_default_attributes` recently added to
        the GTK 4 API in GTK commit [1]
        
            commit fe64c998f82c218e46211984485a7a824a781426
            Author: Emmanuele Bassi <ebassi@gnome.org>
            Date:   Sun Mar 3 14:23:37 2024 +0000
        
                a11y: Add GtkAccessibleText.get_default_attributes
        
        With this in place, the default font family for a Writer
        paragraph is now reported as expected.
        
        With the paragraph selected in Accerciser's treeview of
        the LO a11y hierarchy, this can be seen as follows using
        Accerciser's IPython console:
        
            In [4]: acc.queryText().getDefaultAttributes()
            Out[4]: 'family-name:Liberation Serif'
        
        This API is available from GTK 4.14.0 on, so bump
        the version check for the GtkAccessibleText
        implementation to that minimum version.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/fe64c998f82c218e46211984485a7a824a781426
        
        Change-Id: Id22bee4b7db542ddde241a4d94a7eb916090ba92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164860
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [5a4c3575945876f90dc2f6d67211107ed3b1de4f]

        gtk4 a11y: Extract helper function for text attr conversion
        
        Extract conversion of LO's text attr representation to the
        one that the GTK implementation in
        `lo_accessible_text_get_attributes` needs to return to
        a new helper function `convertUnoTextAttributesToGtk` that
        will be reused in an upcoming commit to implement handling
        of default text attributes for which API has recently been
        added to GTK.
        
        Change-Id: I01a703012c668149a29c3ce759437a1b716988dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164859
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [ae00b39c43b7c767d7f0eea78eb104b983799265]

        gtk4 a11y: Add initial text attribute handling
        
        Implement initial handling for reporting text
        attributes in `lo_accessible_text_get_attributes`.
        
        Initially, only the font family attribute is
        handled, but more can be added in the future
        (s.a. the gtk3/atk and Qt implementations).
        
        With this in place, formatting some text in a
        Writer paragraph with font "Linux Libertine G"
        now shows the "family-name" text attribute with
        a value of "Linux Libertine G" as expected in
        Accerciser when selecting the paragraph object
        in Accerciser's treeview of the LO a11y tree and
        choosing an appropriate offset when using the gtk4 VCL
        plugin, just as with the gtk3 or qt6 VCL plugins.
        
        (Implementation inspired by GTK's internal
        `gtk_text_view_accessible_text_get_attributes` [1])
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/blob/fe4cd7cf0f497ace134a39243b0a44ef09e181be/gtk/gtktextview.c#L10459
        
        Change-Id: Iba565753b3143548492ccc817a159ebfb92a8c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164858
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e9b39aefb5bdf02b965f75fcf08bfe92ece27d0]

        tdf#48062: Add support for atop operator in feComposite
        
        Change-Id: Ifb83b4361d37566d189a7c5b11835f2a5e0eecc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164862
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ca321f9e52a43acf36a8f8184f81240bd946653]

        crashreportScraper: fix version comparison
        
        And remove version column, it's not very relevant anyway
        
        Change-Id: I9101d5f63aec237cdcbfc6eb3759714cca7c5328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164849
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-15  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e5361d0ef04bc63e7809323750aabe6efafcaef9]

        Related: tdf#126573 Add Excel2021 array function FILTER to Calc
        
        Add ocFilter to matrix (array) functions.
        Some follow-up cosmetic clean.
        
        Follow up commit of b0791dd9216224bdb266fd0d8c87df253b6d0583
        
        Change-Id: I4c3c786fe14ab870be8c43211ca6a76c5ff6ac6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164847
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-15  Gülşah Köse  <gulsah.kose@collabora.com>  [f3f3ea4cc9c3bec761d095fbfefd6ba8724fcdef]

        tdf#160213 Don't let insert empty line with numbering, end numbering
        
        We applied the writer's empty bullet line policy to impres. Now We don't let
        insert empty bullet lines in impress too. Instead we end numbering and start
        to write normal paragraph at the same line.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I28042d9db59b5622434da0826f8b760f01ad64f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164799
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [f097720636fe88c6d36e3a8cac98aa51622dbb6c]

        tdf#160020: don't hide mnemonics, when auto-accel feature is off
        
        Change-Id: I08ee0ba87c5c54403a329100b69e96aac3aded28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164857
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [7454d3adf09cbc841e3681f9e32be57bdfb518c7]

        Make vcl::bitmap::get_unpremultiply_table VCL_DLLPUBLIC again
        
        This fixes my GCC 13.2.0 --enable-gtk4 build on Debian
        testing, which started failing after
        
            commit acd40306b3737d50cf24462b2d3e451092543e64
            Date:   Thu Mar 14 12:22:13 2024 +0200
        
                reduce symbol visibility in vcl
        
        like this:
        
            /home/michi/development/git/libreoffice-WORKTREE/vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:2195: error: undefined reference to 'vcl::bitmap::get_unpremultiply_table()'
            collect2: error: ld returned 1 exit status
            make[1]: *** [/home/michi/development/git/libreoffice-WORKTREE/vcl/Library_vclplug_gtk4.mk:20: /home/michi/development/git/libreoffice-WORKTREE/instdir/program/libvclplug_gtk4lo.so] Error 1
            make[1]: *** Waiting for unfinished jobs....
            make: *** [Makefile:290: build] Error 2
        
        Change-Id: I0921801f6ad0f20f5250ca15a2749d7da044fcd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164856
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [9326fbcb581cf7152ebcf047e2b1bceca76f5426]

        Fix build
        
          [LNK] Library/libupdatecheckuilo.so
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:96: error: undefined reference to 'MenuBarUpdateIconManager::MenuBarUpdateIconManager()'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:105: error: undefined reference to 'MenuBarUpdateIconManager::SetBubbleImage(Image const&)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:107: error: undefined reference to 'MenuBarUpdateIconManager::~MenuBarUpdateIconManager()'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:166: error: undefined reference to 'MenuBarUpdateIconManager::RemoveBubbleWindow()'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:187: error: undefined reference to 'MenuBarUpdateIconManager::SetBubbleTitle(rtl::OUString const&)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:191: error: undefined reference to 'MenuBarUpdateIconManager::SetBubbleText(rtl::OUString const&)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:197: error: undefined reference to 'MenuBarUpdateIconManager::SetBubbleImage(Image const&)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:203: error: undefined reference to 'MenuBarUpdateIconManager::SetShowBubble(bool)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:215: error: undefined reference to 'MenuBarUpdateIconManager::SetShowMenuIcon(bool)'
          /home/mk/core/extensions/source/update/ui/updatecheckui.cxx:55: error: undefined reference to 'MenuBarUpdateIconManager::~MenuBarUpdateIconManager()'
          collect2: error: ld returned 1 exit status
        
        Change-Id: I7175126d82731c3dd2cdba64646006f4be664450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [f45402ae3f5241b460d9f1dcb04183893e1f91f7]

        Fix a spurious JunitTest_sw_unoapi_3 failure
        
        As seen e.g. in https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/146433/consoleFull#-456117562b3c3940-aa94-44b1-926f-2d1e7de0f995
        which starts with:
        
          o3tl::iterateCodePoints(std::u16string_view, sal_Int32 *, sal_Int32): Assertion `n <= string.length()' failed.
        
        The problem is the race between the request thread performing changes
        of the document model, and main thread doing idle tasks accessing the
        document model concurrently, as seen in the following call stacks:
        
        cppu_threadpool::ORequestThread
        
          sal3.dll!osl_waitCondition(void * Condition, const TimeValue * pTimeout) Line 82
          vcllo.dll!osl::Condition::wait(const TimeValue * pTimeout) Line 124
          vcllo.dll!Scheduler::IdlesLockGuard::IdlesLockGuard() Line 290
          swlo.dll!sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat * pFormat) Line 197
          swlo.dll!SwTextNode::DestroyAttr(SwTextAttr * pAttr) Line 1204
          swlo.dll!SwTextNode::EraseText(const SwContentIndex & rIdx, const long nCount, const SwInsertFlags nMode) Line 2836
          swlo.dll!SwTextNode::DeleteAttributes(const unsigned short nWhich, const long nStart, const long nEnd) Line 1861
          swlo.dll!SwXFrame::dispose() Line 2703
          swlo.dll!SwXTextFrame::dispose() Line 3383
          mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214
          mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430
          binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239
          binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79
          binaryurplo.dll!request(void * pThreadSpecificData) Line 84
          cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101
          cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169
          cppu3.dll!threadFunc(void * param) Line 190
          sal3.dll!oslWorkerWrapperFunction(void * pData) Line 69
          ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        VCL Main
        
          ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444
          sal3.dll!o3tl::iterateCodePoints<long>(std::basic_string_view<char16_t,std::char_traits<char16_t>> string, long * indexUtf16, long incrementCodePoints) Line 522
          sal3.dll!rtl_uString_iterateCodePoints(const _rtl_uString * string, long * indexUtf16, long incrementCodePoints) Line 754
          i18npoollo.dll!rtl::OUString::iterateCodePoints(long * indexUtf16, long incrementCodePoints) Line 3015
          i18npoollo.dll!i18npool::BreakIterator_Unicode::previousCharacters(const rtl::OUString & Text, long nStartPos, const com::sun::star::lang::Locale & rLocale, short nCharacterIteratorMode, long nCount, long & nDone) Line 344
          i18npoollo.dll!i18npool::BreakIteratorImpl::previousCharacters(const rtl::OUString & Text, long nStartPos, const com::sun::star::lang::Locale & rLocale, short nCharacterIteratorMode, long nCount, long & nDone) Line 72
          swlo.dll!SwContentNode::GoPrevious(SwContentIndex * pIdx, SwCursorSkipMode nMode) Line 1345
          swlo.dll!SwEditShell::GetScriptType() Line 686
          swlo.dll!SwTextShell::GetState(SfxItemSet & rSet) Line 2246
          swlo.dll!SfxStubSwTextShellGetState(SfxShell * pShell, SfxItemSet & rSet) Line 3180
          sfxlo.dll!SfxDispatcher::FillState_(const SfxSlotServer & rSvr, SfxItemSet & rState, const SfxSlot * pRealSlot) Line 1694
          sfxlo.dll!SfxBindings::Update_Impl(SfxStateCache & rCache) Line 262
          sfxlo.dll!SfxBindings::NextJob_Impl(const Timer * pTimer) Line 1275
          sfxlo.dll!SfxBindings::NextJob(Timer * pTimer) Line 1219
          sfxlo.dll!SfxBindings::LinkStubNextJob(void * instance, Timer * data) Line 1214
          vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111
          vcllo.dll!Timer::Invoke() Line 76
          vcllo.dll!Scheduler::CallbackTaskScheduling() Line 508
          vcllo.dll!SalTimer::CallCallback() Line 55
          vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 168
          vclplug_winlo.dll!WinSalTimer::ImplHandleTimerEvent(unsigned __int64 aWPARAM) Line 178
          vclplug_winlo.dll!SalComWndProc(HWND__ * __formal, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 720
          vclplug_winlo.dll!SalComWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 749
          user32.dll!UserCallWinProcCheckWow()
          user32.dll!DispatchMessageWorker()
          vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 475
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 552
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 394
          vcllo.dll!Application::Yield() Line 483
          vcllo.dll!Application::Execute() Line 370
          sofficeapp.dll!desktop::Desktop::Main() Line 1614
          vcllo.dll!ImplSVMain() Line 229
          vcllo.dll!SVMain() Line 262
          sofficeapp.dll!soffice_main() Line 94
          soffice.bin!sal_main() Line 51
          soffice.bin!main(int argc, char * * argv) Line 49
          soffice.bin!invoke_main() Line 79
          soffice.bin!__scrt_common_main_seh() Line 288
          soffice.bin!__scrt_common_main() Line 331
          soffice.bin!mainCRTStartup(void * __formal) Line 17
          kernel32.dll!BaseThreadInitThunk()
          ntdll.dll!RtlUserThreadStart()
        
        The infrastructure introduced in commit 3e0a2239e977a2d6f5252b2412378e02dde3a8b8
        (Introduce a guard to delay processing of idles, 2024-03-13) happens
        to fit this problem nicely.
        
        I am sure that some other Java unit test failures (crashes) seen in
        CI are also caused by similar problems, and need a similar solution,
        to address an actual bug.
        
        Change-Id: I3a765cf0a6273af568e353e22b68107b78578762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164854
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-15  AungKhantOo  <wildgugu2020@gmail.com>  [a67398d1947a075c6e84ea8321ed47feb70521a9]

        tdf#151159 Rename All Applications to All Documents in Start Center
        
        Change-Id: If0c864bfbc250e707dded54820d0c2414ea6e87f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164845
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b240f6198fae7221b7cd3e4678403ad99827b53d]

        tdf#48062: Add support for xor, in and out operators in feComposite
        
        atop and arithmetic are still missing
        
        Change-Id: I9b5bfeaa87b48071708ca4cb082916ea5f260adb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164852
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-14  Mike Kaganski  <mike.kaganski@collabora.com>  [ad161bf882099553949469f99759493c38169c8a]

        Make sure we hold the solar mutex before trying to release it
        
        Might be not guarded by the solar mutex (and need not to!) e.g. when
        an external script calls XDispatchHelper::executeDispatch, with stack
        like this:
        
          vcllo.dll!vcl::SolarThreadExecutor::execute() Line 55	C++
          fwklo.dll!vcl::solarthread::detail::GenericSolarThreadExecutor<`framework::DispatchHelper::executeDispatch'::`8'::<lambda_1>,com::sun::star::uno::Any>::exec(const framework::DispatchHelper::executeDispatch::__l8::<lambda_1> & func) Line 63	C++
          fwklo.dll!vcl::solarthread::syncExecute<`framework::DispatchHelper::executeDispatch'::`8'::<lambda_1>>(const framework::DispatchHelper::executeDispatch::__l8::<lambda_1> & func) Line 166	C++
          fwklo.dll!framework::DispatchHelper::executeDispatch(const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> & xDispatchProvider, const rtl::OUString & sURL, const rtl::OUString & sTargetFrameName, long nSearchFlags, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & lArguments) Line 116	C++
          mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214	C++
          mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430	C++
          binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239	C++
          binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79	C++
          binaryurplo.dll!request(void * pThreadSpecificData) Line 84	C++
          cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101	C++
          cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169	C++
          cppu3.dll!threadFunc(void * param) Line 190	C++
          sal3.dll!oslWorkerWrapperFunction(void * pData) Line 69	C++
          ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97	C++
          kernel32.dll!BaseThreadInitThunk()	Unknown
          ntdll.dll!RtlUserThreadStart()	Unknown
        
        Change-Id: Ic8ffa802f8d9f9165bf5274ddbc06fd70d3a5f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164843
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-14  Mike Kaganski  <mike.kaganski@collabora.com>  [3d8951fa1c7fe30632d4e8151a4a54af2e3befc0]

        Convert an assert into a warning
        
        Seen in an external script calling XSystemChildFactory::createSystemChild.
        
        Change-Id: Ib0fd8ef395700a22e96551ca39aa0ef6dfb21242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164842
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-14  Pierre F  <fpy@bger.ch>  [e9fc56673d4ed37dfd2eb40cf3de36d62b5c0bb5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e48c06ba931d5da0371c2e9b64158aebfbbd9f49
          - tdf#146902. add DatePart results
            
            Change-Id: I718c788a596a11f40dbdaf60860daa8951ae709d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164746
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-14  Miklos Vajna  <vmiklos@collabora.com>  [27a41c7e4ec0e82e2ed0ca2577574f5295a16057]

        sw: fix fieldmark crash in MSWordExportBase::OutputTextNode()
        
        Crashreport signature:
        
        program/libmswordlo.so
              MSWordExportBase::OutputTextNode(SwTextNode&)
                      sw/source/filter/ww8/wrtw8nds.cxx:2547
        program/libmswordlo.so
              MSWordExportBase::WriteText()
                      sw/source/filter/ww8/wrtww8.cxx:2936
        program/libmswordlo.so
              DocxExport::WriteMainText()
                      /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_tree.h:1261
        program/libmswordlo.so
              DocxExport::ExportDocument_Impl()
                      sw/source/filter/ww8/docxexport.cxx:541
        
        Keep the assert, because ideally it should not happen that we have no
        fieldmark at CH_TXT_ATR_FIELDEND, but crashing in non-debug builds goes
        a bit too far.
        
        Change-Id: I428f46821771802a0ea2beaaf86463487e561aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164844
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-14  Pierre F  <fpy@bger.ch>  [36e23a63891e6e24121f1711bf70f81d9c61ae83]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3d706d380c68fde45c71ca87213c0f1c1148455
          - add *MS insert ascii character* (tdf#158112)
            
            for ref: https://support.microsoft.com/en-gb/office/insert-ascii-or-unicode-latin-based-symbols-and-characters-d13f58d3-7bcb-44a7-a4d5-972ee12e50e0
            
            Change-Id: I7eebf8eece9473d339a959320e3a90749f6ab3cd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164626
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [acd40306b3737d50cf24462b2d3e451092543e64]

        reduce symbol visibility in vcl
        
        Change-Id: Ifaa37246e79678aa0c548b9ca8a9faf8036b9195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [c8400f5acc36d2cf0c007260bdc94534a53bba90]

        ucb: webdav-curl: always set CURLOPT_NOBODY for HEAD
        
        Otherwise there will be timeout that depends on when the server will
        close the connection, which varies by server but can be several minutes;
        getting a potential error document from the server for this one request
        when logging is enabled is less important.
        
        Change-Id: I505b014b148ba009c400d37d826c9edb8c3a6da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164838
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [3d56fb36c47f5cfdf646e26d241b2bd7f1d68884]

        ucb: webdav-curl: improve fallback authentication
        
        The bundled curl on Linux doesn't support Negotiate, and a system curl
        may not support NTLM either.
        
        If setting the auth method fails with CURLE_NOT_BUILT_IN, abort.
        
        Change-Id: I7b7f7afd1ebedd665d9475fd40cac0e0641062a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164837
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-14  Julien Nabet  <serval2412@yahoo.fr>  [2887ffbf240aa70330cb50bf810170cf9c896405]

        tdf#160192: fix crash when trying to overwrite file in RO dir+lock file
        
        Bug exposed with:
        5259ab8104cfba60c40748ed0cd59d93df038c5b
        sfx2 store: create temp files next to local files
        
        bt:
        6  0x00007faac67ad9b5 in sax_fastparser::FastSaxSerializer::FastSaxSerializer(com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const&) (this=0x559f316f0e70, xOutputStream=empty uno::Reference)
            at sax/source/tools/fastserializer.cxx:68
        7  0x00007faac67c46e0 in sax_fastparser::FastSerializerHelper::FastSerializerHelper(com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const&, bool)
            (this=0x559f31721400, xOutputStream=empty uno::Reference, bWriteHeader=true) at sax/source/tools/fshelper.cxx:30
        8  0x00007fa9bfa1b4cc in std::_Construct<sax_fastparser::FastSerializerHelper, com::sun::star::uno::Reference<com::sun::star::io::XOutputStream>, bool const&>(sax_fastparser::FastSerializerHelper*, com::sun::star::uno::Reference<com::sun::star::io::XOutputStream>&&, bool const&) (__p=0x559f31721400, __args=..., __args=@0x7ffecd609207: true)
            at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:119
        ...
        15 0x00007fa9bfa04087 in oox::core::XmlFilterBase::openFragmentStreamWithSerializer(rtl::OUString const&, rtl::OUString const&)
            (this=0x559f318ed5f0, rStreamName="docProps/core.xml", rMediaType="application/vnd.openxmlformats-package.core-properties+xml") at oox/source/core/xmlfilterbase.cxx:511
        16 0x00007fa9bfa04999 in oox::core::writeCoreProperties(oox::core::XmlFilterBase&, com::sun::star::uno::Reference<com::sun::star::document::XDocumentProperties> const&)
            (rSelf=..., xProperties=uno::Reference to ((anonymous namespace)::SfxDocumentMetaData *) 0x559f2d673e28) at oox/source/core/xmlfilterbase.cxx:645
        17 0x00007fa9bfa047c2 in oox::core::XmlFilterBase::exportDocumentProperties(com::sun::star::uno::Reference<com::sun::star::document::XDocumentProperties> const&, bool)
            (this=0x559f318ed5f0, xProperties=uno::Reference to ((anonymous namespace)::SfxDocumentMetaData *) 0x559f2d673e28, bSecurityOptOpenReadOnly=false) at oox/source/core/xmlfilterbase.cxx:981
        18 0x00007fa9bee21bd4 in DocxExport::WriteProperties() (this=0x7ffecd609d78) at sw/source/filter/ww8/docxexport.cxx:952
        19 0x00007fa9bee24b0b in DocxExport::DocxExport(DocxExportFilter&, SwDoc&, std::shared_ptr<SwUnoCursor>&, SwPaM&, bool, bool)
            (this=0x7ffecd609d78, rFilter=..., rDocument=..., pCurrentPam=std::shared_ptr<SwUnoCursor> (use count 1, weak count 1) = {...}, rOriginalPam=SwPaM = {...}, bDocm=false, bTemplate=false)
            at sw/source/filter/ww8/docxexport.cxx:2149
        20 0x00007fa9bee4438e in DocxExportFilter::exportDocument() (this=0x559f318ed5f0) at sw/source/filter/ww8/docxexportfilter.cxx:112
        21 0x00007fa9bf9d6b8b in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x559f318ed5f0, rMediaDescSeq=uno::Sequence of length 12 = {...})
            at oox/source/core/filterbase.cxx:494
        
        full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=193113
        
        Patch prevents LO from crashing + make LO displays error message:
        Error saving the document <filename>:
        Write Error.
        The file could not be written
        
        Change-Id: I41a94eeb17bb6568b586d89755bce330154d1dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164808
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbb3b083d43a2e2bad19f144bca44b2f82a8938d]

        replace VCL_DLLPRIVATE with SAL_DLLPRIVATE
        
        it is always SAL_DLLPRIVATE, and we are already using SAL_DLLPRIVATE
        mostly, so just be consistent
        
        Change-Id: I7df969506a9b7a078921400cf245cede3c60c5f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [873af30a36504751c6923d4235abd4de040e0001]

        sw: fix ~SwIndexReg assert in testTdf149498
        
        The problem is that a SwNavigationMgr thingy has a cursor in one of the
        table cells, and the text node is moved to the undo nodes array in
        SwUndoTableCpyTable::AddBoxBefore() and deleted in
        SwUndoTableCpyTable::UndoImpl().
        
        SwUndoTableCpyTable needs to move the cursors out of the way because
        SwUndoDelete doesn't do it.
        
        Change-Id: I75e271c84a6624ffb0df151b171acb1e1f743928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164807
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4176b89523efd0052b2a8c817f816d316797d3a0]

        Fix typos
        
        Change-Id: I94df85715874013a28167d417107b09609f0293e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164831
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [be29cfe3663d81b579895acade39adb089b942d1]

        Fix typo
        
        Change-Id: Ia9e04aeda25f5a1b91950377c3eca335b443790b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164830
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0de11772fa62424910dc4f0155f559de66c0c97c]

        Fix typo
        
        Change-Id: I554f8b88e0f479c4fd27fcc6231e79d77371209e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164809
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ec99dac5c4e0d7e93b54a4a3043ac16a6054c2d5]

        Fix typo
        
        Change-Id: Ifcd144b89f1d5648a3c72471b691529251d26892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164832
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-14  Mike Kaganski  <mike.kaganski@collabora.com>  [b049ee456f375c0ffb276e5be43cc90d8cd30baf]

        cool#8443 let Insert Chart dialog to undo out of order on Cancel
        
        Change-Id: I66d749362c9fb5f2c228f0f5d2c927cc0cf3f89f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164179
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [479893fa6fd82a7f96df63a6b89ed24c5e0a2866]

        Related: tdf#160056 pass 'StarFormat' flag in instead of changing state
        
        towards making these immutable
        
        Change-Id: I9f9ac17828018525194c34eadda66bbf863fd2f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-14  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [4ec72f3935125d3994effd6fa863bbd357e0c246]

        tdf#146619 Remove unused #includes from C/C++ files
        
        'sc' module was cleaned.
        
        Change-Id: I072dcc0bfb8395b88cba18f212aa23f8edf0d32a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164793
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8bf5e319d80d5ba3670557599080893bd209ded1]

        reduce symbol visibility in editeng
        
        Change-Id: I5069beecedca7b346c9f17f46570513a40606e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-14  Pranam Lashkari  <lpranam@collabora.com>  [05022d33be70a76ff14ba2cda84b5fd8a15a47a1]

        sd:annotation: added missing comment reply undo
        
        Change-Id: I63e005aa35faad1ebdaad228a22477cb1dd6de67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164811
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [62cb3b8b8d6106c6aeb073b12d84973a107182ef]

        tdf#157241 sw: fix crash on RTF paste or insert of nested tables
        
        The problem is that there are tables with only empty cell frames in the
        layout, which causes a crash in IsAllHiddenCell() added in commit
        ab7893544dc6be6dc192dffefd57cd5ddd421c35.
        
        This happens because first inner tables are created, with layout frames
        because the layout already exists.
        
        Then when SwNodes::TextToTable() is called for the outer table, it
        deletes the SwTextFrames, but not the SwTabFrames/SwCellFrames, so they
        remain uselessly in the layout.
        
        Delete these too, they will be recreated when the frame for the outer
        table is created.
        
        Also the transfer of any existing break to the outer table was missing.
        
        Change-Id: Idc2bc1d4c6572702510ae4355e4015c42770eb3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164788
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-14  seturaj  <seturajmatroja@gmail.com>  [ee5d1ac729f0e8521792a04d6bb35538cb0cd0b7]

        tdf#48140: Remove unused headers from xlsx import
        
        Change-Id: I14fad4ccd06fe9c3340646efcf80e9209cbb1dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163962
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-14  Miklos Vajna  <vmiklos@collabora.com>  [bb9faad7e9ee135b82daf57699d3118e7c0219ae]

        CppunitTest_sw_odfimport: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), replaced fonts as suggested by the failing assert.
        
        Change-Id: Ia0225a15b295efd86b6dbfeb2c80e9c161cbe566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164800
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-14  Matt K  <mattkse@gmail.com>  [1b5010bfb745a3a7f0e596b237ab70694484fc33]

        tdf#154863 Add unit test to cover crash on image move
        
        This reverts commit 332faa63407305852f5044e4bbc41302ccfe46cd.
        
        This change adds a CppUnit test that changes the position
        of an image in an example document which causes a crash
        if the bug exists.
        
        This also adds a delete guard for a SwFrame used to
        prevent a use-after-free condition.
        
        Change-Id: I5cfec75681a5877c007df33c23d9a5e61e4292c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162940
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-14  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [c8b8a2c2cb34a1ae0b0aeee0564b39260258f184]

        tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors
        
        Conversion of hex/dec colour notation
        (example entry Color( 255, 255, 255), Color(0xFFFFFF) - COL_WHITE)
        For the other available colour definitions.
        
        Change-Id: I9eed0cd64adcbc8d25e1c22143a000906a457586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163729
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-14  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [d5f25d9c0026ec06a0b46e1560e26adba2725290]

        tdf#156655 sc: fix disappear text in merged cell
        
        The text does not appear if the first row or column of the merged cell
        is hidden.
        
        Change-Id: I398f0d572226e44ffaa4e33c066b51480ad124cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164757
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-03-14  Jim Raykowski  <raykowj@gmail.com>  [2d88ea62d4b6663cf8839e5484e2ae8042112f81]

        tdf#160093 Fix SdNavigator empty after inserting formula OLE object
        
        or OLE Object...
        
        Also fixes empty tree occurance when multiple Draw/Impress documents
        are opened at once.
        
        Change-Id: I03d714bf96700d3a7df661fca91cceda703149f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164607
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f654ad1de73bb958c6c60467b20d3db8995a000d]

        Fix typo
        
        Change-Id: Ia37330ee05b69be26de7818206a68c27f317e819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164780
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-13  Julien Nabet  <serval2412@yahoo.fr>  [94da114cd86e3bcd8b6235566ca5f926f09d4b18]

        tdf#160180: bump copyright year to 2024
        
        Change-Id: I466b8f86e8a53a238ed2ce2d2b053dc519ff8eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164794
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-13  Justin Luth  <justin.luth@collabora.com>  [80219819e068dcf53059e2026be2a6f4151d6fc6]

        address nit: use xmlDocUniquePtr, not const auto&
        
        Miklos "nitted" me that I should NOT use const auto&
        in this context. Obviously anything I do
        is simply copy/paste, so lets make sure that
        this "bad example" is removed from all unit tests.
        
        Change-Id: I9b76aeafc5848637e8ebd523a7a550789bd991c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160993
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-03-13  Oliver Specht  <oliver.specht@cib.de>  [aba13d6b4b2d586b356e7b98a23a7796e30c37ec]

        tdf#152878 switch off replacment image in picture frame
        
        RTF documents may contain shapes of the type "Picture frame"
        ({\sn shapeType}{\sv 75}) that are imported as SdrGraphObj
        This change prevents the display of a replacement picture
        if there is no picture set.
        
        Change-Id: Ia3a576ddcb2a3bbffae859102d274d4ecd214f6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164755
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-13  Regina Henschel  <rb.henschel@t-online.de>  [98b06ed3583fcc1f720ceb919cdd57ede7952a71]

        tdf#70039 import lighting of extruded shapes
        
        The patch it a continuation of commit 6e5529d7, that handles import of
        the 3D-scene camera. This patch handles lighting of the 3D-scene. But
        lighting in MS Office has features which we cannot yet render, address
        in API or store in ODF. More than two lights, softing with Scale and
        and Offset, or Specular/Diffuse for all lights are not implemented for
        extruded shapes, for example. Thus the rendering results cannot be
        equal to MS Office.
        
        This patch contains a lot of workarounds and compromises to get a
        rendering which looks somewhat similar. Unit tests are not really
        meaningful in this situation. The included tests focus on the principle
        aspects modern/legacy lightRigs and lightRig rotation.
        
        The light rig values are taken from sections 2.1.1274 and 2.1.1321 in
        [MS-OI29500] - v20231113.
        https://learn.microsoft.com/en-us/openspecs/office_standards/ms-oi29500
        
        That version does not specify the used coordinate system for the
        light directions. Find the discussion about that in
        https://learn.microsoft.com/en-us/answers/questions/1551836
        topic: LightDirection on shape with 3D effect is rendered different
        than specified.
        
        That version does not specify the values 'Specular' and 'Diffuse'
        for legacy* light rigs. Find the discussion about that in
        https://learn.microsoft.com/en-us/answers/questions/1608333
        topic: What is 'Specular' and 'Diffuse' in the lightRig table in
        section 2.1.1274 in [MS-OI29500]?
        
        Change-Id: I91750dc231d0ea09115424d896d3a1260ba766ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164510
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [07872404ccfc99324b81b17bb90f1dc624b234fb]

        These methods can be const too
        
        Change-Id: Iaef46216dac6584f57b7933d658384f54d0a4544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [848ed64cd5b63f07d11bf3754c522a731fa7ae88]

        SvNumberFormatter::GetUserDefColor can be const
        
        Change-Id: If499e28e5ac69018b35b475a73ecb2dc4b78dad6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164786
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Justin Luth  <justin.luth@collabora.com>  [21bd1facb207e5d558854eab3a45a0fb2bb222f7]

        related tdf#123026 xmlimprt: cleanup #includes after removing code block
        
        Change-Id: I1e00e669428491a118ddf0d8e6c2eea87b854846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164783
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-13  Weblate  <noreply@documentfoundation.org>  [f4a497cbae8e35594f8d019bf8cef22639616da7]

        android-viewer translated using Weblate
        
        Czech currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I280354b2c931a3d16dd67979e8e47e85f5618955
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164790
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [16d7e0ba71688523f40293625ae2a1dbd9798c63]

        SvNumberformat::ImpGetLogicalOutput can be const
        
        Change-Id: I847e5de84f0636b5a169f383e319a6b8707cc31f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164773
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8e3d3ed2681c8454fd5a7d7a7c144d90615d09e0]

        SvNumberformat::ImpGetFractionOfSecondString can be const
        
        Change-Id: If7a31f8b3667d9a6b8719553567211071bd2d631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164774
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [7389be1996159b557f2e4022459ed8408302d72a]

        sw: convert OSL_ENSURE to assert
        
        To avoid spurious -Warray-bounds from GCC 13.2.1
        
        Change-Id: I26aba84a6ceda79ffc111c925c8be96df8b186dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164782
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [626047bababf3a84b05103fbed9ecabed33a359f]

        tdf#48062: Add support for feComposite filter
        
        At the moment, only 'over' operator is supported
        
        Change-Id: If21c9ba39b3cd0b772ea27165cda7ae40fb42d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164765
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [af8a899840f61f784e08d1b2d209cc161fbdf7e4]

        tdf#159660: Add support for feBlend filter
        
        At the moment, only the 'normal' mode is supported
        
        Change-Id: I31d1536e03e938ce0f7304a37eb6c1071ecfcf4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164763
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [77447b24f3035441a8a2a38a94d36cc21c36116f]

        Fix typo pointer name
        
        Change-Id: Ieb18b3f4ea7734abfe9e814f39a7c15de7794900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164779
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [3204c50563ed2aa1f667e1e7a8484ee899d7d62f]

        Assert in ProcessEventsToIdle, that idles are not delayed
        
        As noted in https://gerrit.libreoffice.org/c/core/+/164753/9#message-88182774825ae8722961d099d643a6df6f4001a7:
        
        > I think this needs an assert inside ProcessEventsToIdle if the guard count > 0.
        > Otherwise we are going to get very hard to debug lock ups.
        
        Change-Id: I2b8753da7a6ae1672ce5d8634771174d87fe376c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164781
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-13  Justin Luth  <jluth@mail.com>  [daa04d405a0081c5212cfbad0d36a049a4ea83c2]

        allow build with python 3.12.0: initialize new tp_watched
        
        This fixes the build failure after I updated Ubuntu 24.04 (alpha),
        which upgraded python 3.11.7 to python 3.12.0, causing the error:
        
        libreoffice/pyuno/source/module/pyuno_callable.cxx:249:1:
        error: missing initializer for member ‘_typeobject::tp_watched’
        [-Werror=missing-field-initializers]
        ...
        
        I gleaned this information from a July 2023 commit for
        https://github.com/xbmc/xbmc/issues/23503
        
        tp_watched was added in upstream commit python/cpython@82ccbf6
        https://github.com/python/cpython/commit/82ccbf69a842db25d8117f1c41b47aa5b4ed96ab
        
        This change first appeared in Python v3.12.0a1
        
        Change-Id: If82ff1eb47d66d2669d90d6e00e0feff3c55b5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164775
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-13  Arnaud VERSINI  <arnaud.versini@pm.me>  [2ced3022d2c3a534a1e3ac6f5cd12cdf870c2151]

        svx : use string view to avoid OUString creation
        
        Change-Id: I3e3488ed15cf314ff6a666c7ec4bd5b41f96100e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161331
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6cb747bab83c363d9683e19a71b2f18e37a5838]

        no need to use strlen here
        
        we know the size of the buffer
        
        Change-Id: I20c99cd55e8af842dd8e70d8ec39550fd8e7c7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164770
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a2f9d488326fcbaa2cda4ebe66e060a3c3e3350]

        EDITENG_DLLPRIVATE is unnecessary
        
        just use SAL_DLLPRIVATE
        
        Change-Id: I6040c505bcd9382432fa6de2a184b26a6ccc22c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164771
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7850badb2e7adcfc712a92f4b0b0096426f169c1]

        ImpIsEntry can be const
        
        Change-Id: Id229344a68925a1bde84f2b4aad46cfc5f01b797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164769
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fdd4a6d33a074a4cd5c1ca6bed7fff2663b69d2]

        this formatter can be const
        
        Change-Id: I2cd83140585e0b7027bb1c165a8d59e51cbbaad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164728
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-13  Miklos Vajna  <vmiklos@collabora.com>  [219436aa8c81e17b9a5b16cbd9ab7a2ec474817c]

        CppunitTest_sw_txtencexport: rework to avoid DECLARE_DOCBOOKEXPORT_TEST()
        
        No need go via Writer-specific macros.
        
        And in case the naming would be confusing, testBulletsNotHidden means
        that the hidden paragraph near the end of the document is hidden or not,
        it doesn't mean if the bullets are hidden or not.
        
        Change-Id: I8948b1c3fc9fe32e6d41405caab70bc349fa7c29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164756
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-13  Michael Weghorn  <m.weghorn@posteo.de>  [86abb6fd8a8f680f9fc5ff1db775845c9f4e254b]

        tdf#159915 qt: Force Qt::HighDpiScaleFactorRoundingPolicy::Round
        
        For now, force `Qt::HighDpiScaleFactorRoundingPolicy::Round`
        for the HighDPI-scale factor rounding policy [1], which is the default
        for Qt 5, while Qt 6 defaults to `Qt::HighDpiScaleFactorRoundingPolicy::PassThrough`
        (see [2]), which resulted in broken rendering (e.g. "Help" -> "About"
        dialog not showing the whole content) when fractional display scaling like 150 %
        is configured in the KDE Plasma display settings (in contrast to manually setting the
        `QT_SCALE_FACTOR=1.5` env variable to apply scaling, which was working
        fine).
        
        Quoting from [3]:
        
        > The two principal options are whether fractional scale factors should be
        > rounded to an integer or not. Keeping the scale factor as-is will make
        > the user interface size match the OS setting exactly, but may cause
        > painting errors, for example with the Windows style.
        
        Manually setting the env variable `QT_SCALE_FACTOR_ROUNDING_POLICY="Round"`
        has the same effect (and can be used with LO versions not yet
        containing this fix).
        
        (There might be a way to adjust the way that scaling happens
        to make other policies work, but for now, just hard-code to
        the policy that is known to work.)
        
        [1] https://doc.qt.io/qt-6/qt.html#HighDpiScaleFactorRoundingPolicy-enum
        [2] https://doc.qt.io/qt-6/highdpi.html#environment-variable-reference
        [3] https://doc.qt.io/qt-6/qguiapplication.html#setHighDpiScaleFactorRoundingPolicy
        
        Change-Id: I8eb6911d4dd5faf00912b8f15a58e0bdace1995a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164768
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-03-13  Justin Luth  <jluth@mail.com>  [09d20ef6bd90d33a71b581d22d1312c5d26eb32b]

        tdf#123026: also use global config "RecalcOptimalRowHeightMode" for xlsx
        
        24.8 commit 2d2974f22ab59ea7dab1aee778308c4f50ff5464 for tdf#124098
        added a setting that prompts before recalculating optimal row height
        on file open.  I can't think of any reason why that shouldn't apply
        to all formats. It defaults to "always - without asking".
        
        XLSX started optimal row height on file open for tdf#123026
        with 24.2 commit d15c4caabaa21e0efe3a08ffbe145390e802bab9.
        
        So this patch just moves the code to a more accessible location,
        and then uses it for the XLSX case too.
        
        Change-Id: Ia0c672c3aec788857dea09ac88e4395dcf6c2242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164721
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ef28f693351411c0d1651196b99e501acba7e7d5]

        Support environment variable expansion in logging.ini
        
        The syntax is a stripped-down subset of what is available for variable
        expansion in bootstrap ini-files:  It only supports "${name}", to be replaced
        with the contents of an environment variable of that name (which itself is not
        expanded further).  If no such environment variable exists, it is replaced with
        the empty string.  If the name contains a NUL character, or if there is a syntax
        error (i.e., missing opening or closing curly brace), the corresponding text is
        left unchanged.
        
        Also, backslash quoting is supported to allow for verbatim, uninterpreted
        "${name}" content.  But logging.ini is typically used to specify Windows-style
        
          LogFilePath=C:\log.txt
        
        pathnames containing backslashes, so restrict backslash quoting to just "\$"
        (replaced with "$") and "\\" (replaced with "\"), and leave all other
        backslashes alone.
        
        (It is not possible to reuse the bootstrap macro expansion code here, as that
        would cause recursive dependencies.  Therefore, this only implements this
        stripped-down subset.)
        
        Change-Id: I8c949a1637a7f14e0672a9cc1c79014edfa336bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164759
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [3e0a2239e977a2d6f5252b2412378e02dde3a8b8]

        Introduce a guard to delay processing of idles
        
        In a following scenario, there could be a crash:
        
        1. Platform: a Windows system with MS Word installed.
        2. LibreOffice is run in a listener mode;
        3. A Java program opens a Writer document in a visible mode, with an
           embedded Word OLE object;
        4. It adds some text; then resizes the OLE object; then removes the
           OLE object.
        
        Word OLE objects have OLEMISC_RECOMPOSEONRESIZE flag [1]; this means,
        that every re-layout of the document with this object must ask the
        OLE server to re-layout the object content. So, the request thread
        changes the document text, which triggers idle re-layout or redraw;
        the idles start executing immediately in the idle main thread, with
        solar mutex locked; then the request thread starts the OLE object
        removal operation. The ongoing relayout in main thread would at some
        stage need to execute a call to the OLE object, which temporarily
        releases the solar mutex (this makes impossible using solar mutex to
        synchronize the order of operations in this scenario). Other mutexes
        guarding OLE object (in OleEmbeddedObject, and in OleComponent) are
        also released for the duration of the call. Thus, the removal that
        happens in the request thread proceeds, and the node containing the
        OLE object is destroyed, while the main thread (processing exactly
        this node) is waiting for the OLE server response, then for mutexes,
        to proceed. After that, the main thread would attempt to access the
        destroyed node object.
        
        This change introduces a scheduler guard (a RAII object), that sets
        a flag to not process idle events during the lifetime of the guard.
        In its constructor, it also makes sure, that current pending idle
        events are finished. This would make sure that guarded code started
        from other threads would not race with idles potentially accessing
        the model that is currently in transient state.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/oleidl/ne-oleidl-olemisc
        
        Change-Id: I2ef0601ccd8b5872588a88493d1f43e39022dbed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164753
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-13  Pierre F  <fpy@bger.ch>  [f4d121f23815f0c16874be700ed3a33467e61fa4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bc4f9b5f7afc2fb7addf2844a8ee664564f5d3a3
          - tdf#129292  clarify working directory / last-used directory / folder
            
            Change-Id: Ifc0a50a5359239728d0d24f83c582065187ea094
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164688
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [7335babda93974104a39202c434e9499b8086f3a]

        sw: layout: use page style set on hidden paragraph
        
        SwPageFrame::FindPageDesc() now ignores paragraphs hidden for any
        reason, but to maintain layout compatibility it should only ignore
        paragraphs in a hidden section, not paragraphs hidden by fields.
        
        (regression from commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1)
        
        Change-Id: Iad5e76f5cc437d35b4ae9bde6bc9b73dbe32bf3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164761
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a6711276f0c8abeb0028a47cc345a7453374a38]

        reduce symbol visibility in sw
        
        Change-Id: Ib3edefc365d3c605c3024e160572fa4030100ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [7eebe680068f68d2e4081c2f4d9b290a4524d40a]

        tdf#146619 Remove unused #includes from C/C++ files
        
        the 'vcl' module was cleaned.
        
        Change-Id: I3bc7470d08bd5eae46344975293a1f6ae30b30f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164637
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2d472fae8f1223dc969172951d08ff6e4b4f98ba]

        tdf#148170 - Convert print range to an excel cell range
        
        During export from Calc to XLS, ensure that the print range
        is converted to a valid XLS print range. If the print range
        exceeds XLS format limitations, it will be appropriately cropped
        to fit within the constraints.
        
        Change-Id: I2b233e4d57dfbe30f491448d2ee2972b8b717ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164469
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [7d3b439de357c8e97c0a73f6f63e67ec980e432d]

        tdf#157241 sw: layout: inconsistent conditions in lcl_RecalcSplitLine()
        
        A mistake, when checking before the condition is "if (pTab == &rTab)"
        but when checking after it is "if (pTab)" - the latter is correct as the
        former is checked *inside* the block, after resolving to top-level table.
        
        This caused erroneously setting rIsFootnoteGrowth = true in
        SwTabFrame::MakeAll() of tab 939 in the bugdoc, when in fact the footnote
        container shrunk from 5 to 2 footnotes.
        
        (regression from commit c303981cfd95ce1c3881366023d5495ae2edce97)
        
        Change-Id: Ib4cad9fef0e500ebe7a3636c2371a4108b32fb5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164717
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [e1bcdbc6ee0899f3cb915c7a64a1c3b0d42ba977]

        Process pending events before ImplDeleteOnDeInit
        
        The statics derived from DeleteOnDeinitBase are destroyed in the call
        to ImplDeleteOnDeInit; and then they may be accessed, when a few lines
        later, Scheduler::ImplDeInitScheduler is called, which itself calls
        ProcessEventsToIdle. This change makes sure that the events, that may
        potentially want to access these objects, are executed at a safe time.
        
        Change-Id: Idc04100453ed12def815b721e3efe76cb3ca1100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164752
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-13  Noel Grandin  <noelgrandin@gmail.com>  [8d76c5bc29b8ed4cb616bed845acc30b96a38c77]

        remove DBG_ASSERT
        
        this is testing the wrong thing anyway. I briefly converted it
        to a real assert, but surprise surprise, real code appears to
        now rely on being able to set this more than once, so just remove
        it.
        
        Change-Id: Ib272b002e3038eb8537df4768d980b3c3cf938fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164726
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Noel Grandin  <noelgrandin@gmail.com>  [6c5a27efb2522ae3838bbe28ed4770970fa367f8]

        SAL_WARN -> SAL_INFO
        
        Change-Id: I1a958ca6e9a084b2237f6467b17476ffeb5a987a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd35a509ef6d0e1c09e19879fc6dc6a0ecc25bb4]

        reduce symbol visibility in --enable-mergelibs=more mode
        
        Change-Id: If811c9ec336543227db73c990248b9113846cf2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [61580fcbd10bad2e0aab663d4c8fe43c1e01f92c]

        tdf#160117: check bAnyCondition
        
        Commit edbc3a09edcf58a4738b4648811a065f3f55bc7c (sc: Don't end
        handleConditionalFormat early, 2023-11-02) intended to allow to apply
        several different categories of conditions to the same cell: e.g.,
        color scale or databar, in addition to the normal style application
        depending on a condition.
        
        This change fixes a regression, when the found matching condition did
        not stop search for the matching conditions to apply a style.
        
        Change-Id: Ia4cf1dd35a964c6ca523050dc727184ca22a8dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164687
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-13  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [72f1800ad2f3717192287ae2678e8209e66e35d1]

        tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors
        
        Conversion of only one colour, Color(0, 0, 0), Color(0x000000) - COL_BLACK
        
        Change-Id: I4ba2412929522532d32304734b0269c70d75e5ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163460
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-13  Hossein  <hossein@libreoffice.org>  [a2265e8faa099d9652efd12392c2877c2df1d1eb]

        Use UNO_QUERY_THROW instead of UNO_QUERY
        
        Previously, in SDK examples, de-referencing was done unconditionally
        after obtaining a reference using UNO_QUERY. Now, we use UNO_QUERY_THROW
        instead, to make sure cases where exceptions may occure can be handled
        correctly.
        
        Change-Id: Ic73ba3cfcad914dabb7ae3736ad1ae2bd6cc15bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164682
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1f93803aa1fdca7ac83f4801b8a6e866908a3bd8]

        sc: prefix members of ScDPSaveData
        
        Change-Id: I8daa1a002867f03beded99003d302f3a84b234e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164709
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6745e8171ade7cc3428e01735afd742a4588682b]

        sc: prefix members of ScDPObject
        
        Change-Id: I07f65e8cfa50947d21a713ddd0095bb1bca1d2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164707
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-13  Hossein  <hossein@libreoffice.org>  [c1f097854f89f35cfc0f097a10384014042b95d6]

        tdf#160162 Fix hyperlink update in Draw
        
        Changing the links to keep them up-to-date was previously done only when
        the name "Slide" was used for the pages, just like Impress, as Draw and
        Impress share code. Now, the term "Page" is used instead of "Slide"
        since 942d1d2ea59bf4605f2c464a6b29c967fa9f8de8 in Draw. This change,
        fixes the above issue by also using the correct string consntant.
        
        The patch is tested for Draw and Impress to make sure both are working
        correctly now.
        
        Change-Id: I55b4f56bd499d05f87f475d4c6cb3423247bf8d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164716
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [73e5b6667cad47d462ac1bce4f96c53b31315d18]

        tdf#159660: Add support for feMerge and feMergeNode
        
        Change-Id: I52e35f6eb5efc7b064145486aa4e6fb2366b143c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164722
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [b22039cff8380b158307e75762bd3e4ca045d77b]

        related: tdf#159947: only parse in/result if the element supports them
        
        There are some filters ( e.g. feMerge ) that do not support
        in or result attributes
        
        Change-Id: I4072dc481557557733e55cc5fcbd80cb11a7ddb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164718
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b9a3894ee5e249f8e86b84520ee5020ff209fea]

        improve script to find classes where making the class hidden
        
        will provide the biggest benefit
        
        Change-Id: I78ae044612ae1fea7496db1b420848f43e552504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [44a819a466fb553ff5dec97b258144fa75bbe7fd]

        Revert "add sm to --enable-mergelibs=more"
        
        This reverts commit 87d3f768f3ecded1e1392442181edb287aed9e2e.
        
        The unit test at
        starmath/CppunitTest_starmath_qa_cppunit.mk
        is doing
            $(eval $(call gb_CppunitTest_use_library_objects,starmath_qa_cppunit,\
                sm \
            ))
        which it is using to access to all the internal functions of starmath.
        
        Unfortunately that linking trick is just not compatible with the mergelib linking.
        
        Change-Id: Ie3c81a0eeea5bed192de18981463497f251531a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-12  Aron Budea  <aron.budea@collabora.com>  [d3ae37902ee2ded2926b1a41816b33404f1cda1d]

        lok: Send Accept / RejectTrackedChangedToNext state change
        
        Change-Id: I194c0c3260fe90273f5b5f50c18a63e48ae85449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164699
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit 9358d70f57ffd2ea40a3ae71db14b26307fce92e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164685
        Tested-by: Jenkins

2024-03-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f35ff76607041798823ac985b50ee40d5c670260]

        Remove SaveODFItem class
        
        This is effectively unused since:
        commit d22ab7b444a4e16dc2bd1f7d15fa36a848eaaaed
        
        Change-Id: I6f646b7daf845035196fc9dde4ff270b8143d37a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164645
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e5548dceb9086a6f0c8fa70bce8de6da0be72e40]

        tdf#160056 don't need to create a boost::intrusive_ptr to do search
        
        with more recent c++ versions we can elide that construction for the
        purposes of this comparison
        
        Change-Id: I6a88219ef4451d2775b3b7ab1d9cf8adfb53e04d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-12  Andras Timar  <andras.timar@collabora.com>  [72d9d1ccbe54ff3cee6f11a81e05d2e358d359fc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5dfde9a9192cb30ec373585ff1bfe2121cd6bccf
          - Too big environment on Windows can cause failure with xargs
            
            Change-Id: I5d796dbf6ad4d93dd133583a1dac95a210674ef9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163117
            Tested-by: Jenkins
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2024-03-12  Fridrich Strba  <fridrich_strba@opensuse.org>  [06dd867d05b807b346b24d9b1e7535d376d4c14d]

        Fix build with autoconf 2.72
        
        This commit http://git.savannah.gnu.org/gitweb/
        ?p=autoconf.git;a=commitdiff;
        h=cf09f48841b66fe76f606dd6018bb3a93242a7c9
        changed the internal cache variable name and its content
        
        The effects show later in message like
        /tmp/ccyB6wS6.ltrans9.ltrans.o: in function `comphelper::DocPasswordHelper::decryptGpgSession(com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> > const&)':
        /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:705:(.text+0x4fb7): undefined reference to `GpgME::Data::seek(long, int)'
        /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/docpasswordhelper.cxx:716:(.text+0x5402): undefined reference to `GpgME::Data::seek(long, int)'
        /usr/bin/ld.bfd: /tmp/ccyB6wS6.ltrans13.ltrans.o: in function `comphelper::OStorageHelper::CreateGpgPackageEncryptionData()':
        /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:507:(.text+0x64e3): undefined reference to `GpgME::Data::seek(long, int)'
        /usr/bin/ld.bfd: /home/abuild/rpmbuild/BUILD/libreoffice-24.2.1.2/comphelper/source/misc/storagehelper.cxx:520:(.text+0x6583): undefined reference to `GpgME::Data::seek(long, int)'
        collect2: error: ld returned 1 exit status
        
        Where the type 'off_t' at the time of inclusion of the header and
        at the time of compilation of the library differ.
        
        Change-Id: Ie0486dbc869e84f5fb2688473334cfe464abd570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164704
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [d3049ab4786005c6bd17c66f8edcb98210bf511c]

        tdf#156814 Remove sheet name if range belongs to the same sheet (Solver)
        
        When solver models are imported from XLSX, ranges come with sheet names even when they belong to the same sheet, which clutter the solver dialog.
        
        This patch checks when this happens and remove sheet names when the solver model is imported.
        
        Change-Id: I3994f1312667946aab330c734ff820e94673d018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164610
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33e0296468630d4ec34e6c90ea3bf204a1285db6]

        Draw indicators for header/footer when cursor is inside one
        
        for real, typo the last time :-(
        
        Change-Id: Iab781851d1e852511e64737b678463620e5d6786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [35c07241c6f2d17f57b589e336aec8e708e68df3]

        GetNonEndOfPathToken can be private
        
        Change-Id: Iebf8b84c205eee083ecf8b436520911ba132fe5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec448cc69f8a5e3a34b11808d11544aca1a10aae]

        Draw indicators for header/footer when cursor is inside one
        
        continue to not draw it for the main body text as per:
        https://github.com/CollaboraOnline/online/issues/3491
        
        but give an indication when the cursor is inside the header/footer:
        https://github.com/CollaboraOnline/online/issues/5298
        
        Change-Id: I500806fe44c131585ea4292536908261660ae20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164653
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit cf234d0e546046cf481ed080bc5f6984a8aba36a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7da8fce0cd13a83a34b732615e95f477f4c4857e]

        tdf#146619 Recheck xmloff/*cxx with IWYU
        
        Change-Id: I6e39a223fd567d70254998e55de5110db87ab4fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164486
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-12  Oliver Specht  <oliver.specht@cib.de>  [51964bb719848277094afe22d144d2814e1cce46]

        tdf#63259 Cycle case should work on end of words
        
        Now words are selected if the cursor is positioned at the end of
        the word. SENTENCE_CASE does not force sentence selection anymore.
        
        Change-Id: I672352b2c18bb695004fd4eb0f20ae5fd7a0ac53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164546
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-12  Miklos Vajna  <vmiklos@collabora.com>  [9a7b26a994362a71944f675c9c9ccffffe8fa517]

        sw: extend the SwFormatChg documentation a little
        
        It's not directly SwFormatChg that describes the change of a format,
        it's sw::LegacyModifyHint that has pointers to the old and new pool
        items, which can be SwFormatChg / RES_FMT_CHG.
        
        Change-Id: I997d63ea380fbd8cc6434982d348edad2e4bb44b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164698
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-12  Jaume Pujantell  <jaume.pujantell@collabora.com>  [e2708fecb34fb4084f8db5f2c5ffb4d8923002ca]

        lok: use locale units in dialogs and sidebar
        
        When oepning tha same doucment with different locales, the dailogs and
        sidebar show units (cm/inch) of the first locale (or the locale used in
        preloading, en-US) for all the views.
        
        This patch changes the units used according to the LOK locale.
        
        Change-Id: I3d515873bde661f2d9048bbc405843e83134cca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164589
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3ca938a25439d6f23bbd6830a96e5180ff94f757)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164619
        Tested-by: Jenkins

2024-03-12  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [d9e0d89114193226d3ef9c148fdc81141bdee840]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04dcd1b951689689f9449408fd6f512a9c87aa0d
          - related tdf#160057: replace last ref to defunct Footer Header page
            
            Change-Id: Ie6df598c42149ecc527a1a2eef35a7aba469c216
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164387
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-11  Pierre F  <fpy@bger.ch>  [173bf8bf8b8e485691f8f0b4b33da0a139babc34]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a86b2f1aaaa7b0cceb46e7b6b6c1c58a343b5cb2
          - fix rounding and use Format()  tdf#155654
            
            Change-Id: I8a9643fb9713177eba3bb56e93d26a989ac9f099
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164677
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-11  Pierre F  <fpy@bger.ch>  [a11c8dc43762706d53234685db48ce971377c2ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3a192b621db3644d50544a64f56ac34909711f92
          - clarify match/replace. tdf#153212
            
            Change-Id: I019014574dc1fda4850363aecb70d083a89c0fec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164678
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-11  Baole Fang  <baole.fang@gmail.com>  [1999e2b35c8106fa959f04bbd381ddb49d257a1d]

        tdf#158152: Make presenter console to "Console: file"
        
        Add a new parameter pDrawDocShell to FullScreenPane to extract filename.
        A new string STR_FULLSCREEN_CONSOLE is added for presenter console.
        Now, the presenter console's title becomes "Console: file".
        
        Change-Id: Ic18d00044dde602dd92210600e3c5311b46500b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164515
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-11  Pranam Lashkari  <lpranam@collabora.com>  [f8bb64a3cffb80793a6b3b9c41f78c5feccb168e]

        LOK: send LOK_CALLBACK_SHAPE_INNER_TEXT info on empty textbox initialization
        
        Change-Id: I8bc003f89147c145ec4b1f9a91b6fe82da9f14be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5ce3af3b14f7086416be778a2b4efd094852db3]

        move rng out of ScInterpreter and into the ScInterpreterContext
        
        the former is created a lot, while the latter lives in a reusable
        pool
        
        Change-Id: I9a4802aa7db0b591e1835768851aa9093331e918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164690
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d759c8b39ce04ee9c1a515c01f7ed104ccb81cc1]

        Remove duplicated include
        
        Change-Id: Iba8d8295252670c0f0ab590934bcb654f2bd2625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164665
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-11  Pranam Lashkari  <lpranam@collabora.com>  [caddd0199ea1f07e1fdef6d4231da5d3f8e9c367]

        LOK: don't send empty callback for LOK LOK_CALLBACK_SHAPE_INNER_TEXT
        
        Change-Id: Id0a3a84fcadc1ab216b856760fd168b23bed2827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8b83bd661b8d212e66df541ff91c976b1564ab4e]

        Fix typo
        
        Change-Id: I26617232049c6218b99d00e1f69adad42e8249ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164668
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [83c2a63223f8f08319d359b4a9a10f37539c021b]

        Fix typo
        
        Change-Id: I9d09cb02d5fed17d48f0bc42ac41cf8bad3b66b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164667
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ea1d09b039d295f0818a283e03bdaf3d5f21d5f0]

        Fix typo
        
        Change-Id: Idc184c5155fa69888561fed5709da36c330d1c2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164666
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [17dc98b0f0d96362db03e48c0589013c349da156]

        Document Colors do not show any color in the Palette
        
        same is true for "Theme Colors", a problem since:
        
        commit 4ccc2f0e3f45c9d78f74b1848851bedf71f7382d
        Date:   Fri Mar 1 22:11:14 2024 +0200
        
            cool#8327 use tools::JsonWriter for theme colors
        
        Change-Id: Ibaab5df197bd8005037e066181e8a50bdda5ceda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164658
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164669
        Tested-by: Jenkins

2024-03-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ed8a6bf198547b11af7a312ac14faace9d61512d]

        Update git submodules
        
        * Update translations from branch 'master'
          to c662aec6f873e0684d70389be4ec93c76132f79b
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ib7a4e5bd9fa3729e52c7c263db9769eb18b9a023
            
2024-03-11  Pierre F  <fpy@bger.ch>  [851aa4e9338337de79e73fd0784219a855526e94]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2694856dafe3e7850b966583e093e62b05dc099d
          - add paragraph about "AM/PM" tdf#157603 05020301.xhp
            
            Change-Id: I11e6260ef89db28e56ce53dc091479c11e2fc20f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164675
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2024-03-11  Jim Raykowski  <raykowj@gmail.com>  [1447900fc5f0d32d8379a95439f524fda9a664c1]

        tdf#122587 Add uno command to set layer of object(s)
        
        Change-Id: Iabdd0f7059953760a69d82a3810eb8ed20c2fd9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159982
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-03-11  Pierre F  <fpy@bger.ch>  [4e27934fc1ea47e4f3986c7675d94348a9f23a21]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e1458853a317d6efbc222e7719e06be10d98817
          - fix String limit  text/sbasic/shared/03102100 tdf#157822
            
            Change-Id: I62fb1b238cf03c29ef7ba6d01594d351754cf60b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164674
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-11  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [f3bfe66fb54190fee6ac579835c03c2b4a2735d0]

        tdf#159094 sc: fix failure when exporting media files to PDF
        
        Change-Id: I948190b31f45cf05ba24d1fbc4a84dfe91eb3876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164557
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-03-11  Justin Luth  <justin.luth@collabora.com>  [ccf988d206a47701c81126f23e2bef71fc3db333]

        GraphicImport.cxx: address nit
        
        less emphasis on minimizing "if logic"
        and more emphasis on readability
        (especially since the comment comes after the logic).
        
        In the most common cases, this version
        should actually finish sooner to.
        
        Change-Id: I18cf760e806c53f6d32afadca8d127df2df89653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164655
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7206092764496cdd28e20749004667a659a0e4aa]

        add rpt libs to enable-mergelibs=more
        
        Change-Id: I2b9acf1a897c962a60ec0c955ae6e9c6bea8ff8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-11  Keldin Maldonado (KNM)  <kemaldonado@csumb.edu>  [2205be28b420b76fa580d5979c051bcdb54bf422]

        tdf#114441 use sal_uInt32 instead of sal_uLong
        
        sal_uLong to sal_uInt32 for the clipboard format.
        Clipboard enum class uses sal_uInt32, so staying consistent with that.
        Clipboard format doesn't exceed unsigned 32-bit int.
        
        Change-Id: I1938f9ba877fc89c51415d9715a82e9b0c09d4e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164604
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-03-11  Kurt Nordback  <kurt.nordback@protonmail.com>  [46e96625e9dc3c452a7323c8bf231fea3acab606]

        tdf#96944: Stacked column chart does not show connection lines
        
        Change-Id: I14727e8a55231b6695c5a59dd495cd03b15d69f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161626
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-11  Oliver Specht  <oliver.specht@cib.de>  [09c6204b6309321aa25c542f918fde9f5f3f7fe2]

        tdf#81880 Search the Gallery
        
        Adds a search field to the gallery to search for icons titles.
        Wildcards '*' and '?' are supported
        
        Change-Id: I7a8ed2addef3031b77eeeec21889cf72b964ca26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164167
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-11  Miklos Vajna  <vmiklos@collabora.com>  [da6a23840d44c40da3989e7c2372b2b6d9ae95b5]

        svx: prefix members of XHatch
        
        See tdf#94879 for motivation.
        
        Change-Id: I65f69d6fb334b0d376a304cd1bc1437fd116c9a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164643
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2995a0e0785911322c9d57e98b925073ff6cb6bd]

        Embind construction of UNO Any sequence/struct/exception/interface
        
        Change-Id: I43d924126f4d34e0efbcea61dd5f4bd9be235426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164650
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c35985a4b42d6a7d654b4fd1f99a966b75ee28a6]

        Embind construction of UNO Any enum
        
        Change-Id: I1b2167e261f1020b228f8ca2618c7f0009ca1d3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164646
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [36a169c10f0457c30a0d327fda585c4decb33532]

        tdf#159373: sc_uicalc: Add unittest
        
        Change-Id: I30e452534e09aa349a85f0862ed09291506203dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9f428717f97d2d129a4e3e9e9428245b6621c3f7]

        Fix a UITest on Windows
        
        No idea why the difference. No idea even if it's specific to OS, or
        maybe on other factors as well...
        
        Change-Id: Ib1816e7fe3b7350504d3de1a78570b3f789a20db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164652
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c382515069d1ccf9ffc3f647ab3acc26c2aba6f]

        tdf#160095: sw_uiwriter8: Add unittest
        
        Change-Id: Id7d35511fbbc6a0d11f521bff9ad7469ae068ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164649
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-11  Pierre F  <fpy@bger.ch>  [755297eceaf9c471bd53c4f413b3cf7bd5a8296a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfdacad1658ed67ef45738653a64750e49244020
          - link to *Entering Unicode Characters*
            
            Change-Id: I7007bcbfb18f46cb043eb3a8923240460d09cbb7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164617
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-03-11  Pierre F  <fpy@bger.ch>  [ac921aa54ced3f37016b55ea254f759a45ac6359]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 969dc658744688aa9e1dc64611a327399d078462
          - less tautological and more reader friendly wording (tdf#91336)
            
            Change-Id: I98516428b87c22c035897965b5f66caeb6c29fb6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164618
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-11  Arnaud VERSINI  <arnaud.versini@pm.me>  [68b73e7a290a340be48c8b9ed4d9f970d9a56204]

        basic : use OUstring literal for XServiceInfo implementation
        
        Change-Id: Ic4501ec887bb3f1249ab4a8da1eae07f6b2a22ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164305
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-03-11  Noel Grandin  <noelgrandin@gmail.com>  [ae351d9d5fc4fc3c0e02853e0a974791e41786fe]

        tdf#158773 reduce cost of importing binary data
        
        no need to pass it via the internal buffer of SequenceOutputStream when
        we can read it directly
        
        Change-Id: I832737d73309449a1f3a26a4b451977a2a580de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164634
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-11  tbalaj  <teodorabalaj@gmail.com>  [5c99838c1ab0ca34648256f47c8719eef00f088b]

        tdf#143148 Update Include Guard usage
        
        Updates vbabutton.hxx to use pragma once
        
        Change-Id: I55874083ad0cdbc08bedaa71fa7553acfefa3195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164324
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Tuukka Orava  <tuukka.orava@outlook.com>  [c5bb6b0972f8f03b6c9d397d2d0f16c154c58e1c]

        tdf#157664 Drop operator != where respective operator == is defined
        
        Change-Id: Id0313cbaf399af94df7ced18a8ad55deec53be33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164638
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a00f608e6ae847b64a1824261029d770ccba841e]

        Drop old "SvGlobalName order" compatibility hack
        
        It was added in commit 7afe74c37ed737f9d7a7c9c77877a0bde6997771
        (INTEGRATION: CWS os54 (1.21.10); FILE MERGED, 2005-03-11) for
        issue #i30510# related to "StampIt". Hopefully now, after almost
        20 years, the hack is not needed anymore.
        
        Change-Id: Id39765b9d2c51fd487c48ce06382c068bab08959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164459
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [99c1bd1a4ef5365d8c26a41c8e858c67e673beb4]

        Disallow closing document during generation of preview
        
        Using an external (Java) script that opens a document, and then quickly
        closes it, it may happen that the idle that generates a preview is still
        active, when the control thread calls XCloseable::close, which destroys
        still used document. This leads to use-after-free.
        
        This uses the close listener in SfxObjectShell, to veto closing document
        that is still in use by the preview generation code. After completion,
        when the caller of close() transferred ownership, then the call to close
        is repeated.
        
        Change-Id: I39691f61ad5141d7e8ee54723d5aef87f0bc01dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164632
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1ac5353bbb25bd9ff0ab0e157b3dbd0da325480a]

        Use weak reference to SfxObjectShell in SfxEventHint to avoid use-after-free
        
        The events may be processed after the shell has been destroyed. This is
        happening reliably after commit e2bfc34d146806a8f96be0cd2323d716f12cba4e
        (Reimplement OleComponentNative_Impl to use IGlobalInterfaceTable,
        2024-03-11) when controlling LibreOffice from external Java scripts; but
        obviously, it could happen before as well.
        
        Now SotObject inherits from cppu::OWeakObject, instead of SvRefBase.
        
        Change-Id: I73a3531499a3068c801c98f40de39bdf8ad90b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164458
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [e2bfc34d146806a8f96be0cd2323d716f12cba4e]

        Reimplement OleComponentNative_Impl to use IGlobalInterfaceTable
        
        ... to make sure that object methods are called in correct apartment
        
        The user-visible problem was, that running a Java code that connects
        to LibreOffice, and opening a document with an embedded OLE object
        (it was Word object in a specific case, which needs activation at
        opening stage, because these objects have OLEMISC_RECOMPOSEONRESIZE
        flag), using loadComponentFromURL with "OnMainThread" set to true,
        then closing the document, resulted in a hang after several hundreds
        iterations. This was caused by Word process, that was started in
        background to serve the COM calls, wasn't closed properly, and kept
        all the objects in memory, until OOM.
        
        The reason why it wasn't closed was failed call to IOleObject::Close
        in OleComponent::CloseObject, which returned RPC_E_WRONG_THREAD,
        because the activation of the OLE object happened in the main thread
        (because of "OnMainThread"), which is STA, but closing happened in
        the handler thread (belonging to MTA).
        
        Similar problems previously were addressed in commits
        2dc3a6c273cb82506842864481d78df7294debbf (framework: allow loading a
        component on the main thread, 2018-12-20),
        6002014ce0a5c9cea22c14b2437b7a508b2c72cb (framework: allow loading a
        component on the main thread, using XDesktop, 2021-04-28),
        d5cd62164d32273a25913c93aa04be9f7f3a4073 (embeddedobj: handle getting
        the visible area on a thread, 2021-05-07).
        These changes tried different workarounds for the same problem, when
        a COM object instantiated in one apartment is later manipulated from
        another, which fails. First two handled the case when the document
        is loaded from a non-UI thread, and then manipulated with the UI; to
        handle that, they introduced flags that delegated opening the file
        to the main (UI) thread. The last change tried to handle the reverse
        problem of the OLE object instantiated in the main thread was saved
        in a handler thread, which again failed; the workaround was, again,
        to try to delegate the second attempt to the main thread.
        
        But basically all methods can fail in such circumstations, as shown
        in this problem's case. The "OnMainThread" flag must be passed to
        fileopen functions explicitly. Also, the workarounds only work by
        passing everything to STA, and don't target a case when the calls
        must be passed from STA to MTA.
        
        Since Windows 2000, there is IGlobalInterfaceTable, which goal is
        to solve this problem. It allows to use an intermediate object,
        which can transparently delegate all calls to the correct thread.
        
        This change re-implements how OLE objects are referenced from
        OleComponentNative_Impl, using the said IGlobalInterfaceTable.
        This should hopefully obsolete the previous workarounds, which
        nevertheless are kept for now.
        
        Change-Id: Ia1c590e547ed24a2c7389283aed6cc3d8ea024b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164457
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-11  Pierre F  <fpy@bger.ch>  [f42363c51672a5b3685b0b9b11e932680530dce3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a09dfabece27637223b8deadd448c24e2fbb35b0
          - href *sort options*  + related *sort lists*
            
            Change-Id: I67d9718ddeebde28f895a8faa2cda5d2590f88a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164491
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-11  Hossein  <hossein@libreoffice.org>  [d30891d6ad5473708aaba7b31aa87de29ae57fe6]

        tdf#143122 Port HelloTextTableShape example to C++
        
        Port DevelopersGuide/FirstSteps/HelloTextTableShape Java SDK example to
        C++ and add a GNU Makefile for the build.
        
        Change-Id: I8798406c24ec6c566fb6494f7202f6a2a984a25c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164635
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-11  Hossein  <hossein@libreoffice.org>  [93c5a2513c7cb2f737a0e1f8de0b101bdc6337d4]

        Enable commented part in HelloTextTableShape.java
        
        Commented code in the HelloTextTableShape.java example demonstrates the
        use of bookmarks. This part is now enabled.
        
        Change-Id: Iace525be0d53b01bed8b5a6a123384a678d1d761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164636
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-11  Hassan Sajjad  <hassan.sajjad069@gmail.com>  [0783eeba65ec51051d072b6d4c6d32b3b45bee61]

        Remove redundant function indirection in SfxHintPoster
        
        SfxHintPoster::mLink always pointed to SfxDispatcher::PostMsgHandler and
        except in ~SfxDispatcher, it was reinitialized to empty i.e. cleared.
        This extra indirection is now removed.
        SfxHintPoster was using SvRefBase to persist even after SfxDispatcher
        was deleted and then deleted itself after SfxHintPoster::Post call was
        completed. This extra indirection was adding 4-5 frames while debugging.
        
        Change-Id: Ibfd6d3aea10ddf45732adc1a9d63a25717a771fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162700
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-10  varshneydevansh  <varshney.devansh614@gmail.com>  [cc695e180b39ffe21f0ae12cfeefb89a50a50b64]

        tdf#42982: Improve UNO API error reporting
        
        Change-Id: I2eead2d6907cf49d9a8525065d33c3ef43207660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161779
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-10  Andras Timar  <andras.timar@collabora.com>  [9561465c43da93bee0f259fe57748785ac1cb8b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 99537726eca951a450182d7672458afeb2b65e66
          - fix Helpex warnings: 'No string specified!'
            
            Change-Id: I70ad73b6859cd989e6046c3bd5a76c54c27f416d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164631
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-10  Arnaud VERSINI  <arnaud.versini@pm.me>  [be6243144eb39838294258a80b1f153bcd3e7029]

        basegfx : use OUstring literal for XServiceInfo implementation
        
        Change-Id: I18a17e38897c1feda7fbba330c14a79c9b6d6f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164306
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-03-10  Arnaud VERSINI  <arnaud.versini@pm.me>  [b7b029cd71cf008117e7035fe7f883cc09e58247]

        basctl : use OUstring literal for XServiceInfo implementation
        
        Change-Id: Iee7585585b5e01fad4609f37a06d2aeeff492123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164304
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-03-10  Arnaud VERSINI  <arnaud.versini@pm.me>  [140a3719f870381a81f5bc2e3531568123f439eb]

        avmedia : no need to use constexpr here
        
        Change-Id: I1b9975841a702d7ad3e05adef3d849c63ddf264a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163009
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2024-03-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7a46de0d7761a52986ba092c34ea7e76c3871e6b]

        Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-mergelibs=more
        
        ...which, after recent changes, failed now with
        
        > [CHK] CustomTarget/postprocess/check_dynamic_objects/check.done
        > instdir/program/libmergedlo.so has suspicious NEEDED: libgssapi_krb5.so.2
        > instdir/program/libmergedlo.so has suspicious NEEDED: libcom_err.so.2
        > instdir/program/libmergedlo.so has suspicious NEEDED: libkrb5.so.3
        
        Change-Id: I80de1dd85f06d0e27b73355def68da9df2f6c2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164606
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f62629af6d12d505b029db85c276daedf5017b1]

        tdf#158773 avoid Reindex() until we are done renaming
        
        shaves 10% off load time
        
        Change-Id: I93dfb4422a3e470013b6ddc5a9ae9e9868e3ddf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164609
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [36db6678a2c131658d17c9e80fcd7c31c427023c]

        inline aSep variable
        
        Change-Id: Ic547a6f13e7a1a3cade70547d029721ce8054567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164608
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-10  Jim Raykowski  <raykowj@gmail.com>  [1fd359790ed4a27902248d92ee343a4aeaf63c8e]

        tdf#90242 Navigator: Improve custom shape naming
        
        This patch makes the Draw/Impress Navigator display the name retrieved
        by SdrCustomShapeGeometryItem::GetPropertyValueByName("Type") for
        custom shape objects when the custom shape is unnamed and the Navigator
        is set to show all objects. For Writer and Calc, this patch makes
        inserted fontwork custom shape objects be automatically named 'Fontwork
        N'.
        
        Change-Id: Ice34461fe7a4b26d01b2d93e871a956dc55392f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152568
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-03-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3ba85b7786663da4f2de1a3c2fe7ee9a27657293]

        Support o3tl::iterateCodePoints with both sal_Int32 and std::size_t
        
        ...and clean up the most gross casting offenses
        
        Change-Id: If0d646fb3e73e71a9a2735569395034973563a1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164602
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [959b30841ae9c5cc1f43928f5e7780abaab4a087]

        tdf#158773 avoid some OUString construction
        
        Change-Id: I42c6b7a8c7b0c0af17a2806c908f5a336ef206d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fbecf2d6b72ee2b5631bee4c0d6d0c5556aa9698]

        Enable (and fix) some TODO test code
        
        ...now that all the relevant Any getter functionality is available
        
        Change-Id: I5824dd50d177506b0450506146df109ded7e20d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164588
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [4c65ab909598766e5859a5f0ce4bf55b23c9551b]

        Enable CVE tests on Windows by default
        
        Since commit c16969b9bc73fdd77e763299d6aea7b614e203e2
        (tdf#84553 Detect and warn of Windows Antivirus., 2020-02-08),
        it is checked that antivirus is disabled in $SRC_ROOT and $BUILDDIR.
        
        This reverts commit a6b2c618cb02168bba950652367f494a1021cf53
        (disable cve tests by default on windows, 2014-10-01).
        
        Change-Id: I3816e97cfb4559f7647167ed291b75468b03dc4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164612
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-09  Sujatro Bhadra  <sujatrobhadra@gmail.com>  [ddd5017410f4ec2f4860a27f4946e05458686afd]

        tdf#158237 Use C++20 contains() instead of find() and end()
        
        Change-Id: I93e873bd2396c1b95f120ee11478c0cd3a309c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164580
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [d48e4d3e911422f54f2071362af103b93a14bebb]

        Simplify a bit
        
        Change-Id: I36b5557a5413e76306ed4a83eaa238422bf59fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164613
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-09  Sujatro Bhadra  <sujatrobhadra@gmail.com>  [47e778211b83936d067acad6df01412560f8edac]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: Ibb805a67240b554cb56c5758ba20c081524e990a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164454
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c210f0869b2ee827a2a881491de323755b3a9947]

        Fix typo
        
        Change-Id: Iebc31f3dc1d99406e23ee4b89f12cd78b424826d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164600
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5875a82bba8074b0b7bf941f2462df241dd42cd7]

        Fix typo
        
        Change-Id: I1018717588188c71ec634ed7a71d8000bd4e257e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164601
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-09  Julien Nabet  <serval2412@yahoo.fr>  [82e6236cd6ba6f45aa913a3be606e6b00f81fe07]

        tdf#160095: fix crash when using ALT+RETURN twice
        
        Change-Id: Idc4c84039115c8d88418246a17e281c26fb49b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164592
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [632fc28fda03e312b2eb2d5843459b3ceee43534]

        tdf#158773 add a set to sd::ShapeList
        
        because the std::list is atrociously bad at checking if the element
        already exists when the number of shapes gets large.
        
        Shaves 5% off the load time
        
        Change-Id: I6b8f972f8ff9559c363c084d91adea88b1267d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-09  Justin Luth  <jluth@mail.com>  [4904e608fd7ac3d61c924a17fe3494f5e4a43ae6]

        replace unit test font with Liberation Sans
        
        since I was getting a build failure on Ubuntu 24.04
        
        warn:vcl.fonts:1268905:1268905:
        vcl/unx/generic/fontmanager/fontconfig.cxx:1192:
        PrintFontManager::Substitute: missing font: 'Rockwell'
        try: Noto Sans instead
        
        replaced theme1.xml Rockwell and Franklin fonts
        with Liberation Sans
        
        Change-Id: I365f64c927fcb2211990321e906f757c2d03e893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164603
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [01067e964a876e38e99a099f62fe514a211a5fca]

        external/skia: Fix a std::sort comparison function's assertion assumptions
        
        At least with a LLVM 19 libc++ in hardening debug mode (where it uses additional
        invocations of the comparison function passed to std::sort, to verify that the
        function actually implements a strict weak ordering), chart2_dialogs_test failed
        with
        
        > LO_TEST_LOCALE=en-US
        > [_RUN_____] Chart2DialogsTest::openAnyDialog
        > workdir/UnpackedTarball/skia/src/sksl/transform/SkSLFindAndDeclareBuiltinVariables.cpp:112: fatal error: "assert(InterfaceBlockName(*a) != InterfaceBlockName(*b))"
        
        apparently because the implementation of std::sort made additional
        same-arguments calls of operator ()(x, x) that the Skia implementation of the
        comparison function was not expecting to happen.  But the only relevant
        guarantee that C++20 appears to make for std::sort is that its complexity is
        O(N log N) comparisons, so any implementation could legitimately do such a
        "useless" additional same-arguments call of operator ()(x, x) for each of the N
        elements of the to-be-sorted range.
        
        Change-Id: I3a14eb05b5ae9101f37f92e10ecc91a90585de87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164577
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [20f1f529a29fdbc6a531a8c82f4aeff8ff3908bd]

        Embind construction of UNO Any Type
        
        Change-Id: Iac5ac8de7bfb19b90d54edc6f4b791d8c0e98977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164594
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80bb8c666f09264b0df7181d03ebad3b883de797]

        Redesign Embind UNO Any construction
        
        ...taking a full UNO Type instead of just a UNO Type class (so that it will be
        able to construct Any containing sequence, enum, struct, exception, and
        interface, in later steps); moving the Type argument first (as that looks more
        natural), and renaming from Any to uno_Any (in line with the other uno_Type,
        uno_Sequence_..., etc.)
        
        Change-Id: I154681c4b9187f5f5d037d503652fe7bcd41adcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164593
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ad7963f939c629657c1aca03765169ace14a5bbd]

        Directly go via std::u16string
        
        Change-Id: I99d3322afc7876c37a7ace016c1c6af691f28406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164591
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [747cfc7a021d8a4664462ddd6b0fad6c178da602]

        Improve Embind'ing of UNO Type
        
        Change-Id: Id93d7f48dedb362206828b5e3bd946525f95ea77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164590
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Luv Sharma  <luvsharma.del@gmail.com>  [26d0ce6fd07bfdabc35d01dbc385974f570a59c6]

        tdf#45904 Remove old SwXFootnoteText Java test
        
        Change-Id: I04ade7be60083d4bc57b400b7aa82850424e1e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164407
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a3b20b14d32922c99df4ad65271499d0a8d663e]

        tdf#158773 do the cheap checks first
        
        the HasText() call inside TextProperties::Notify is surprisingly
        expensive, so only do it when we know we are interested.
        
        Shaves 25% off the load time here
        
        Change-Id: Iab257add7fd56bf405678944ca8a3482c8f7b142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164596
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  AhmedHamed  <ahmedhamed3699@gmail.com>  [8e5a5b7af90ebe4ad35b89ec30f4f19191d9b1ec]

        tdf#145614 Convert #define to enum
        
        Change-Id: I949fb5327032228b7aecfea762e23fdea692ca78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163887
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [b56678ae967bb1e09b52930a0b1d59a5e68bb7be]

        tdf#142133: partially revert 576611895e5
        
        if 'Internet Link' character style doens't exist then
        apply the hyperlink style
        This also reverts 023285158bde72dcd73b965ce205cf8550e7a5e2
        "tdf#128504 save DOCX as ODT: don't color not highlighted hyperlinks"
        which is no longer necessary
        
        Change-Id: Id100af5fddb10745af9d56c0ba75cb2366ecbe55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164576
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-08  Justin Luth  <justin.luth@collabora.com>  [61b1d3a17ff784b7c79a92cbe069a90ce4932535]

        tdf#160077 unit test: this file was helpful identifying a "bad fix"
        
        ...since I'm walking away from doing any fix at all
        as it involves layout code for layoutInCell.
        
        Following the createGraphicObject route could also benefit from
        a similar fix as d210667c72ff821b8cb50b386a83ed55d65ae9bf,
        but placing that code outside of the try/catch
        will be important because this example exceptions out.
        However, my first instinct was to put the code in the "obvious spot"
        and it didn't work, so adding this as a separate unit test.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCellB
        
        Change-Id: Ifa6a62d9708d9248e48766b913d54a79cfcb230a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164578
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-08  Noel Grandin  <noelgrandin@gmail.com>  [6441778b61d1c6737947551e55d2c27e79260142]

        tdf#158773 reduce size of IndexedStyleSheets
        
        we don't need to store SfxStyleFamily::All in the mStyleSheetsByFamily
        array, the call sites just iterate over the main vector for that
        case.
        
        Change-Id: I17fca2aa59e786d6dee13c884dedb9fde847b979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  Noel Grandin  <noelgrandin@gmail.com>  [02f88f45e681beacf611f7c20f7903916b7e7374]

        tdf#158773 reduce cost of stylesheet lookup
        
        we can store pointers styleSheetsByFamily and avoid having
        to access the vector
        
        Change-Id: I36b5df981b6e53d9aa4193de419fc6a44f0ed2da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  Noel Grandin  <noelgrandin@gmail.com>  [5cd557a512551ae5033957e22ea5c5f285518be3]

        tdf#158773 GetNumberOfStyleSheets can be an inline method
        
        Change-Id: I24a013d74bf8f9336496232d585ac1f0b069696c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164572
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  Adlair Cerecedo-Mendez  <adlair@linuxmail.org>  [fae655c430e7e61a867721d2aab0cb3d561e45a4]

        tdf#156717 Add minor version / architecture to PDF metadata
        
        Added minor version to PDF producer metadata.
        - For stable versions, the producer field looks like:
                LibreOffice 7.5.3.2 (X86_64) / LibreOffice Community
        - For development versions, the producer field looks like:
                LibreOfficeDev 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
        
        Change-Id: I378bb9325d3cda47db9444094eb32965d4e90351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162734
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [434065478d35fe8e144aec916ac06438c0150270]

        Avoid mentioning Glibc-internal type __fsword_t
        
        ...and clean up the use of macros here
        
        Change-Id: Iede9ff705992d5e229b44b48cd88f5b495f6cee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164571
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [e0259d4c0951c4dd77c74d08b9d905728d4c8dfd]

        ucb: webdav-curl: only set CURLOPT_NOBODY for HEAD
        
        Some testing with Apache httpd+mod_dav reveals that it usually sends a
        body with a 401 status, which causes the CURLE_WEIRD_SERVER_REPLY error
        code from curl.
        
        So we should either ignore this error in case there's a HTTP status too,
        or stop using CURLOPT_NOBODY.
        
        The latter seems to have no downside, except for HEAD requests, where
        strangely the server keeps the connection open and curl waits for 5
        seconds for no body to arrive, blocking the UI, so continue to use
        CURLOPT_NOBODY for HEAD.
        
        The other methods don't seem to block.
        
        It turns out that the SAL_LOG-dependent setting of g_NoBody turned HEAD
        into GET anyway if logging is enabled, so explicitly set the method.
        
        Change-Id: Ibe2eef8e7a827d4e356ba37c4b56bee0be3b9c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164569
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [21c1f50373d1937fecd8e4e8c4dfba0f3066652e]

        ucb: webdav-curl: try to share DNS and TLS data as well
        
        Not necessary but probably faster.
        
        Documentation says that CURL_LOCK_DATA_CONNECT isn't safe in a multi
        threaded program.
        
        Change-Id: Iae79c01330b48f443b94abf6101a50559cb46189
        (cherry picked from commit fa5feda2f891651933703e029dcc757e47a6801f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164553
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [27fb4efea57881d49e9598e84b4a1df6a6e8719a]

        ucb: webdav-curl: add a shared cookie store
        
        Change-Id: I8796aa7de6335c57818aa570a55fdc64d85bd9f9
        (cherry picked from commit 7e8b26560020ae2819cfd621b5790e51083b7e92)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164552
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1d00bd9b570b2b58a6742469f7671978a845cd68]

        Remove duplicated include
        
        Change-Id: Iaba173fc0bb56c9eb2f61ddb092eefba6d59cf68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164566
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [d7492813058bff81c17068feee0e4ba7627c17de]

        ucb: webdav-curl: try fallback authentication on 403 error
        
        Sharepoint reports lack of authentication with 403 status and additional
        X-MSDAVEXT_ERROR header value 0x000E0098.
        
        Try to add the magic header "X-FORMS_BASED_AUTH_ACCEPTED: f" and
        fallback to Negotiate auth in this case; this requires cookies to be
        enabled.
        
        Note that the build config of libcurl on Linux is such that adding
        CURLAUTH_NEGOTIATE has no effect, but on WNT having both NEGOTIATE
        and NTLM causes the AuthMask to be ambiguous and prevents curl from
        trying.
        
        Change-Id: I47dada2ef08b21a43cdfa3db9eb2fcdb4043a04f
        Change-Id: Ia3e31c994bde0f8db84a60931702323c94c02e0e
        (cherry picked from commit c6df10ce7f91b3084255bfbbac95e865bbb3ce7b)
        Change-Id: I93e0c8f95beafc30b94296430352f2ae54e65b11
        (cherry picked from commit 37abfd767874441568d9f5ac499b2d93d34e10fe)
        Change-Id: I0018a9904857d7521895936dc27607a54523f300
        (cherry picked from commit 388a702af2fe45b2c436e64eb8639f16c1e24b76)
        Change-Id: Iafa8bdd183ef8a514b656ec41a9b7a6fa1e3acb9
        (cherry picked from commit e84c21aca4b72d9e86c856f717b3bf1b75f190af)
        
        Change-Id: I6dfcb3ba6e44bbb76bc403e30b4a7b6ee95296f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164551
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [218e4641c4e2e0f894afab40b0e789636e73ad4c]

        cid#1592990 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1592991 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia1de5f671947ad79614a727aa70408431843b90e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164564
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [718e5188f4d3f15e64dd2796aa96d8c127627306]

        cid#1592989 Dereference after null check
        
        Change-Id: I34276f9324e994fa1ea174719b60d492b1e595f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10b70bf512f9c6d48a34f3cfa44233db63875aea]

        cid#1592988 Uninitialized scalar field
        
        Change-Id: Iabdca9248c22e6e296086dd0892c9d395269f588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164562
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [4206cdaa3621cd95b81496ade829112db9e6a935]

        tdf#146356: sw: move UItest to CppUnittest
        
        Change-Id: Ic1cd24dabf58e2aea2ed7c6e4a6c62f4fbc4f094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164565
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-08  Noel Grandin  <noelgrandin@gmail.com>  [1406e7b2f01a88377649c763cd65d20803c3c3a6]

        tdf#158773 flatten data of IndexedStyleSheets
        
        we can store the mStyleSheetPositionsByFamily inline, since it
        is fixed size, and save some allocation overhead, and some pointer
        chasing.
        
        Change-Id: Id6ff02491e967b9fb145ba9752f4a52173692645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164558
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4036ac57530e44462455e6544d4fc0d598140346]

        Blind fix for Linux 32-bit builds
        
        ...which, according to
        <https://lists.freedesktop.org/archives/libreoffice/2024-March/091666.html> "32
        bit build failure (smb, narrowing)", started to fail with
        
        > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx: In function ‘void osl_file_adjustLockFlags(const rtl::OString&, int*, sal_uInt32*)’:
        > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx:71:26: error: narrowing conversion of ‘4283649346’ from ‘unsigned int’ to ‘int’ [-Wnarrowing]
        >     71 | #define CIFS_SUPER_MAGIC 0xFF534D42
        >        |                          ^~~~~~~~~~
        > /<<PKGBUILDDIR>>/sal/osl/unx/file.cxx:795:14: note: in expansion of macro ‘CIFS_SUPER_MAGIC’
        >    795 |         case CIFS_SUPER_MAGIC:
        >        |              ^~~~~~~~~~~~~~~~
        
        etc.  My Fedora 39 "Linux man-pages 6.05" statfs(2) man page explains about the
        struct statfs f_type field of __fsword_t type:  "The __fsword_t type used for
        various fields in the statfs structure definition is a glibc internal type, not
        intended for public use.  This leaves the programmer in a bit of a conundrum
        when trying to copy or compare these fields to local variables in a program.
        Using unsigned int for such variables suffices on most systems."  But the
        underlying __FSWORD_T_TYPE looks like it is actually defined as a signed type in
        /usr/include/bits/typesizes.h.
        
        Change-Id: Ida3ae84031c4e48b0d6e69d76b66b4e4facfa1ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164561
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-08  Miklos Vajna  <vmiklos@collabora.com>  [8aa0d442dee5864cd6a851569068a7657a69ee79]

        sw doc model xml dump: avoid SwNode::GetTableBox()
        
        The purpose of the doc model dump is to give an idea of the doc model as
        it's in the memory. SwNode::GetTableBox() is far from trivial and can be
        problematic when invoked from e.g. an already crashed process.
        
        Rather show SwTable::m_TabSortContentBoxes, which knows the (cell) start
        node, and then this can be avoided in SwStartNode::dumpAsXml().
        
        Change-Id: Ie81181cfd41de4d4df38a8b7a430ecd5f67bc8a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164560
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a6fe043e789c77cc9a429253b754843540838983]

        Remove exec bits on odt file
        
        Change-Id: I8df422f16b5cb428c0d4c2ac0eb025e9c61a9cde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164568
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d9621aa0334204c1c1b06e44da3ebef63c124c0]

        Fix typo
        
        Change-Id: Ib13d78cc78f1e5cee0542ea2cc81135723240b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164567
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-08  Justin Luth  <justin.luth@collabora.com>  [d210667c72ff821b8cb50b386a83ed55d65ae9bf]

        tdf#160077 writerfilter: shape vertRelation is FRAME for layoutinCell
        
        When layoutInCell is active, then the offset must be applied
        against the paragraph instead of the page or page margins.
        
        There were only two unit tests that matched this,
        and both were off-sheet positioned.
        -tdf151704_thinColumnHeight.docx
        -tdf92157.docx
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160077_layoutInCell
        
        Change-Id: I28241136c0c0be12d3f2dd876550ecdf91b0009c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164514
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-08  Pranam Lashkari  <lpranam@collabora.com>  [34daf30c7a02208408b83a8ff872736b98a732e0]

        LOK: send inner text boundry information of shapes/textbox on change
        
        instroduced new callback for LOK LOK_CALLBACK_SHAPE_INNER_TEXT
        
        now if innert text is changed LOK is instantly updated about new textarea
        
        Change-Id: I0a88e1dd77556e47f14359ce0a98701a327aceda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [980ca3953084560806cd980d2ec16951d9e30c2b]

        ucb: webdav-curl: don't set CURLOPT_NOBODY for OPTIONS
        
        The problem is that if the server does send a body, then curl returns
        CURLE_WEIRD_SERVER_REPLY error code, which is translated to
        DAVException; this looks unnecessary now because write_callback
        will just return if there's no stream to write to anyway.
        
        Change-Id: Iddaee9778ac7bbd538b64584f822f65ab0e395c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164550
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [40a19e61efff859d83e0689c0ed7d40c8e9ae8fe]

        tdf#159456 - chart view: fix wrongly shifted value Y axis
        
        We only have to shift the category axis only, and not the
        value axis, if we have a chart data table.
        
        Change-Id: Ie77ea829e8f8987702dce7d17cb3e20054f3d8cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164539
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f4ba83e82aafc206d17d2fa66a27573ebc5a3624]

        tdf#159422 - chart view: fix symbols position of data table legend
        
        Calculate the correct/optimal row height after calculating and set
        correct width of a table cell. Then we will have the correct row height
        for the symbol positions.
        
        Change-Id: I65bc0f0579ea100906b0b32449c2200a54c2a353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164512
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f856733ed18353b8ac7d7e19348cf9b1107cc14b]

        tdf#159443 - chart view: fix Data table is not rendered below chart
        
        If we have 1 dataseries we will have no tickmarks, in that case the
        distance between two tickmarks is the width of the chart.
        
        Change-Id: Ifea11329f1dcb80e8e390c1408306d1df7d49ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164471
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-08  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4f680db872ae42912a417ca8d68f68e6acc8d3dd]

        tdf#146619 Recheck animations/ with IWYU
        
        Change-Id: I72a2f335ba2a786ddd0b59ecad76bfa039e5cdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164487
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [7840effb1d5efd1fd7f6798c7c504b05292a7793]

        use more string_view
        
        found by tweaking the stringview loplugin
        
        Change-Id: I92203ba99642bef7951ffa146184c5562cb31d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-08  Steven Casey (SMCode)  <steve@caseycontact.com>  [bf35f2b36fc00f9b37397422b2ee425c6a697540]

        tdf#114441 change use of sal_uLong to better integer types in filter
        
        Reason for changing nAdv:
        I chose sal_uInt32 since the value of nAdv is passed to the variable
        nAdvFlags which is of type sal_uInt32, keeping types consistent.
        
        Change-Id: I116d41af58d3d2d024ba63d4186a931a742b1003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164518
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9476f5ae4bff9817b9e699f7abea5690ec7ffd87]

        tdf#160071 Don't clone formatting to whole boxes
        
        when clicking into an empty area of that box
        
        Change-Id: I383f1584f446e29454eda2177c8bae0f6587e42d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164555
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-08  Patrick Luby  <guibmacdev@gmail.com>  [ff113b34dd6f54765995440cbedd27483fadb844]

        tdf#159996 use transparent alpha mask for output device
        
        Since commit 81994cb2b8b32453a92bcb011830fcb884f22ff3, fixed text
        needs to be drawn to an output device with a transparent alpha
        mask.
        
        Change-Id: I2036e8c6c9133b1caceb24aeca40f04524c16b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164556
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [da49e5edb2fba9e99ed7d58952dc761b0804e7fc]

        Add Embind'ing of UNO Any getter for interfaces
        
        Change-Id: Ia56439e0e99c193c7cc56676677df2c671278e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164554
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Oliver Specht  <oliver.specht@cib.de>  [dbb05dc818afb08b3e05ac62bd92389a5cf90fa7]

        tdf#159726 Improve Clone formatting
        
        Paragraph attributes and lists are copied if there is no source
        selection or the source selection includes at least a full paragraph.
        They are only applied to an empty or a paragraph selection.
        As in tdf#160069 requested the clone formatting function is only enabled
        in text edit mode.
        
        Change-Id: I789402a7928837bb85ec941fd6f958d12585ac40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164533
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-07  Oliver Specht  <oliver.specht@cib.de>  [bfb6904d8c0b054409faf8469752b033d7c2955a]

        test of tdf#146356
        
        Inserts a paragraph in front of a protected table of contents
        and inserts text into the new paragraph
        
        Change-Id: I951fa2bea63dc2b5721876268aa27a8df579b210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164480
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2364e6d62d4a95e437981f80ad26ce1c46b8b29e]

        Add $equals to Embind'ing of UNO interfaces
        
        ...so one can write foo.$equals(bar.$query) to check for UNO object equality
        
        Change-Id: I727386e833507c86573cf033a1364ff145ed31ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164544
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [8f75226dd99cb02e349abf476eeaeb7b9f6022ae]

        CppunitTest_sw_ooxmlexport5: turn on set_non_application_font_use
        
        From bin/replace_missing_fonts.sh:
        Replacing 'Tahoma' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77887.docx
        Replacing 'Thorndale' with 'Liberation Serif' in sw/qa/extras/ooxmlexport/data//ooo96040-2.odt
        Replacing 'Tahoma' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//ooo96040-2.odt
        Replacing 'Albany' with 'Liberation Sans' in sw/qa/extras/ooxmlexport/data//ooo96040-2.odt
        Replacing 'Trebuchet MS' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Times' with 'Liberation Serif' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Tahoma' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Century Gothic' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Lucida Sans Unicode' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Candara' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo77727.docx
        Replacing 'Tahoma' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo78420.docx
        Replacing 'Verdana' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo78420.docx
        Replacing 'Gill Sans MT' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo79822.docx
        Replacing 'Tahoma' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//fdo79822.docx
        
        Change-Id: I298d9007ae6bd59a8a804902524b59ac524618c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164548
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [e97c77dd12f4fd6babaf29057c59f5ddc38e38fd]

        CppunitTest_sw_ooxmlexport6: turn on set_non_application_font_use
        
        From bin/replace_missing_fonts.sh:
        Replacing 'Kings Caslon Text' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/TestVMLData.docx
        Replacing 'Impact' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/fdo74110.docx
        Replacing 'Century Gothic' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/gradient-fill-preservation.docx
        Replacing 'Kings Caslon Text' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/image_data.docx
        Replacing 'Segoe UI' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf119054.docx
        Replacing 'DINPro-Medium' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf128752.docx
        Replacing 'Open Sans Light' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf153891.docx
        Replacing 'Lora - regular' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf153891.docx
        Replacing 'Century Gothic' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf153891.docx
        Replacing 'Segoe UI' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf153891.docx
        Replacing 'Times' with 'Liberation Serif' in sw/qa/extras/ooxmlexport/data/tdf93676-1.odt
        Replacing 'FreeSans' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf93676-1.odt
        Replacing 'Times' with 'Liberation Serif' in sw/qa/extras/ooxmlexport/data/testOuterShdw.docx
        Replacing 'Jokerman' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/testOuterShdw.docx
        Replacing 'Century Gothic' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/testOuterShdw.docx
        Replacing 'Calibri Light' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//tdf119054.docx
        Replacing 'Calibri Light' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data//tdf132514.docx
        
        Also remove some replacements in replace_missing_fonts.sh
        which are not needed
        
        Change-Id: Ife0e4a6852907e658b2f2ed42c91b26b5eb06572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164536
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [87d3f768f3ecded1e1392442181edb287aed9e2e]

        add sm to --enable-mergelibs=more
        
        Which means
        
        (1) We need to extend the weak linkage magic for the sfx2 SFX_TYPEMAP
        stuff. Just make it unconditional, since it makes no difference for the
        individual items.
        
        (2) The initialisation of global const Sequence data in starmath stops
        working, because it runs too early. Use function-local static to
        initialise it on-demand
        
        Change-Id: Idc397515cd1d9621a06d237606c19acee600081a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Jonah Janzen  <jonah.janzen@gmail.com>  [b117f7d42c7c8bce12d61c01b92b8af4e9aa70b1]

        tdf#143148 Use #pragma once instead of include guards
        
        Uses #pragma once in several files under sw/source/core/inc.
        
        Change-Id: I3052462232665a4efa301afd51e9f64fa3567c44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164517
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ba70a8756361a0659a63a75a7c534d4442d69b23]

        Fix Embind'ing of UNO Any getter for sequences
        
        Change-Id: I5c53cb1d244731dac8f9e3f4797a7a155b9a9afa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164541
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [d98f71fb6b8b2b559bffc8d10584fe1dd7cf5843]

        Simplify some rtl::math::approxEqual calls
        
        Comparing with zero is simple - the implementation special-zases zero.
        
        Change-Id: Ia2fe8a1100941f72023a74955ebfbb4f5f25b90d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164540
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [e35e76924d6e08e5eb5a0742ab6a6c567dce71b8]

        CppunitTest_sw_ooxmlexport21:  turn on set_non_application_font_use
        
        Using bin/replace_missing_fonts.sh
        Replacing 'Garamond' with 'Noto Serif' in sw/qa/extras/ooxmlexport/data/tdf159207_footerFramePrBorder.docx
        Replacing 'Segoe UI' with 'Noto Sans' in sw/qa/extras/ooxmlexport/data/tdf159207_footerFramePrBorder.docx
        
        Change-Id: I222a6f2683d616b1f3e6bf1beca83df5dd03e8f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164524
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a30c919373940025024442d9607da06258bb552]

        tdf#158773 reduce dynamic_cast in AttributeProperties::Notify
        
        Change-Id: I29143d4908454be819acec16732533ff5caa1055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [34017b14d866e99aff466ff200b60b3e2d509a30]

        tdf#158773 reduce time spent in IndexedStyleSheets::Reindex
        
        no need to de-allocate and then re-allocate the vectors inside
        mStyleSheetPositionsByFamily
        
        Change-Id: I3ad10173d9f3ba252619667afe13250045c943c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [06d444e9a102569aa6cf429079036fc95482cc7f]

        tdf#158773 reduce dynamic_cast'ing in TextProperties::Notify
        
        Change-Id: If4a68433c57fdf3da56891fa0b4be6f8a991d929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [241d855f79d4e4b560a127ccdbcaa6b32297f52d]

        ResetDefaultSystemCurrency can be private
        
        only called by a friend from the same .so
        
        Change-Id: I5f63e83325b291b95b0132089dc331f3b7e79362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dbc00dd52c36a4fa6346ab4cf497cb02d6eedec8]

        IsSpecialStandardFormat can be private, only used internally
        
        and rename to ImpIsSpecialStandardFormat
        
        Change-Id: Ie20c83906559f94e545f384807396ec8acf970f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164537
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-07  Gökay Şatır  <gokaysatir@gmail.com>  [97d32edf39e9d64866d8cee6ab8b5c947c6e18db]

        Collaborative editing with readonly and edit views.
        
        We can have both readOnly and editor views at the same time while collaboratively editing a document.
        Our current solution is to disable any command if the user's view is readonly.
        We want to have a closer behaviour to desktop app with readonly views.
        For this purpose, we are allowing more interactions from online server to core side.
        We also need to filter out the events like the core side readonly view do (next commit).
        This commit initiates the readonly view infrastructure.
        
        The patches previous commit reverts were an example of how we disable things in readonly mode. We needed to open a window for getting hyperlink information.
        With this patch, we try to separate the edit and readonly view modes on core side.
        
        More notes:
        
        We need "&& !comphelper::LibreOfficeKit::isActive()" or it falls into an endless loop with this patch.
        When we disable editing on a browser, almost all user actions are disabled.
        
        (cherry picked from commit 81dae2ca5187bd24aea0befb099a5b53535b5d03)
        
        Change-Id: Ia25368dd8065206ec6b4b83eb2f685531110cc78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164527
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c3ac53ec31d2b33ad7197c2d20c38c5035b3ba6]

        replace_missing_fonts: Only replace string if between quotes
        
        Change-Id: Id7d1b4326cf37250c3ae6d163223e1a492fbfde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164535
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [59fab21d4ef6a9a6e151aab2e4ab637386dc7b7c]

        bin: rename script to replace_missing_fonts
        
        Change-Id: Ib88141919484f363825e0d242b42e9a0e8ab18a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164534
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [6c25216e461b624f556a1b2830ab0911d5df7daf]

        tdf#159931: pptx export: export each used slide layout for a master
        
        attempts to fix the slideLayout reference related regression
        from Idb6b88ebe87a83818d8eb27a1fa087652a002c0c.
        
        To correctly export the all used slideLayout instances for a
        given master, iterate through sdr::PageUsers of that master
        and figure out all used layouts.
        
        Change-Id: I0f58befac1ba4d5ec01aeedbb5f611c83683dcf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164468
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-03-07  Noel Grandin  <noelgrandin@collabora.co.uk>  [7979508e4328ceb9d6a2dff6a2a080ea64247c7e]

        Simplify some basegfx::fTools::*orEqual calls
        
        Comparing with zero is simple - the implementation of basegfx::fTools::moreOrEqual
        calls rtl_math_approxEqual eventually, which special-zases zero.
        
        Change-Id: I62f10f63f103d91a201dfeb20e5b3f9010f377c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [10e12d0e6316ac20388f589f062e784e8d9aa630]

        tdf#157518: add uitest for password policy
        
        Change-Id: If246779c944fe250c0070094450545d688712ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164390
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-03-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [2873a4c12d083698de293750f582bf8181a79f6e]

        tdf#158375: add tests for DisableActiveContent
        
        add two tests, one for EmbeddedObjects and one for DDE links.
        
        Change-Id: Ia5bfd06361eb3850df538829abcd1a7cbea2b3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164369
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-03-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [a321084efea4d3ecb8dc2f5a120266ec53647a63]

        do not assume there are no extra seperators at the end for dde links
        
        Change-Id: Idee81b9a8a38aed2375092d2394010063c131fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164368
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-03-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [cb685f603e15d73fc518b8d4e896f96f21bab4ea]

        tdf#158375: make it possible to hot disable embedded objects
        
        Do not require a reload of the current document for the
        embedded objects to be disabled.
        
        Also make sure the existing active embedded objects are
        disabled when DisableActiveContent is enabled via options
        dialog.
        
        Change-Id: I5a8f302af0cac64575c3e5ec6dbe71ec50a15442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164367
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5980ce30fada189f3ce51bea9d4e25f05c69634]

        CppunitTest_sw_ooxmlw14export: turn on set_non_application_font_use
        
        Using bin/replace_string_in_zip.sh:
        Replacing 'Calibri Light' with 'Noto Sans' in /home/xisco/libreoffice//sw/qa/extras/ooxmlexport/data//TextEffects_StylisticSets_CntxtAlts.docx
        Replacing 'Segoe Script' with 'Noto Sans' in /home/xisco/libreoffice//sw/qa/extras/ooxmlexport/data//TextEffects_StylisticSets_CntxtAlts.docx
        
        Change-Id: I482bfad110e546d0d9a9a0d0bbcca2c9ad63033e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164525
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-07  Mike Kaganski  <mike.kaganski@collabora.com>  [860548e23e2ae737d7bd5840f71f776b1239f997]

        Simplify a comparison
        
        Comparing with zero is simple - the implementation of basegfx::fTools::moreOrEqual
        calls rtl_math_approxEqual eventually, which special-zases zero.
        
        Change-Id: I47c6059b56426c93e0c244036edeb5632037e093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164492
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [825dde03999a55d02e4d5bc88a4d5beacb65e67f]

        vcl,accessibility: try to fix a crash while disposing SvxFontNameBox_Impl
        
        This happened in a 6.3 based branch, no idea how to reproduce it.
        Clearly the SvxFontNameBox_Impl is being disposed and in its base class
        Window::dispose() when a call to SvxFontNameBox_Impl::CreateAccessible()
        happens, which seems very suspicious; try to prevent that.
        
        mergedlo.dll!ImplListBox::InsertEntry(long nPos, const rtl::OUString & rStr) Zeile 2225
        	unter d:\lo\core\vcl\source\control\imp_listbox.cxx (2225)
        mergedlo.dll!ComboBox::InsertEntry(const rtl::OUString & rStr, long nPos) Zeile 886
        	unter d:\lo\core\vcl\source\control\combobox.cxx (886)
        mergedlo.dll!FontNameBox::Fill(const FontList * pList) Zeile 447
        	unter d:\lo\core\svtools\source\control\ctrlbox.cxx (447)
        [Inlineframe] mergedlo.dll!SvxFontNameBox_Impl::Fill(const FontList * pList) Zeile 236
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (236)
        mergedlo.dll!lcl_GetDocFontList(const FontList * * ppFontList, SvxFontNameBox_Impl * pBox) Zeile 1290
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1290)
        mergedlo.dll!SvxFontNameBox_Impl::FillList() Zeile 1331
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1331)
        mergedlo.dll!SvxFontNameBox_Impl::CreateAccessible() Zeile 3739
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (3739)
        mergedlo.dll!vcl::Window::GetAccessible(bool bCreate) Zeile 129
        	unter d:\lo\core\vcl\source\window\accessibility.cxx (129)
        acclo.dll!VCLXAccessibleToolBox::getAccessibleChild(long i) Zeile 733
        	unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (733)
        acclo.dll!VCLXAccessibleToolBox::GetItemWindowAccessible(const VclWindowEvent & rVclWindowEvent) Zeile 784
        	unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (784)
        acclo.dll!VCLXAccessibleToolBox::GetChildAccessible(const VclWindowEvent & rVclWindowEvent) Zeile 795
        	unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (795)
        mergedlo.dll!VCLXAccessibleComponent::ProcessWindowChildEvent(const VclWindowEvent & rVclWindowEvent) Zeile 165
        	unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (165)
        acclo.dll!VCLXAccessibleToolBox::ProcessWindowChildEvent(const VclWindowEvent & rVclWindowEvent) Zeile 657
        	unter d:\lo\core\accessibility\source\standard\vclxaccessibletoolbox.cxx (657)
        mergedlo.dll!VCLXAccessibleComponent::WindowChildEventListener(VclWindowEvent & rEvent) Zeile 129
        	unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (129)
        mergedlo.dll!VCLXAccessibleComponent::LinkStubWindowChildEventListener(void * instance, VclWindowEvent & data) Zeile 118
        	unter d:\lo\core\toolkit\source\awt\vclxaccessiblecomponent.cxx (118)
        [Inlineframe] mergedlo.dll!Link<VclWindowEvent &,void>::Call(VclWindowEvent &) Zeile 84
        	unter d:\lo\core\include\tools\link.hxx (84)
        mergedlo.dll!vcl::Window::CallEventListeners(VclEventId nEvent, void * pData) Zeile 280
        	unter d:\lo\core\vcl\source\window\event.cxx (280)
        mergedlo.dll!vcl::Window::ImplResetReallyVisible() Zeile 735
        	unter d:\lo\core\vcl\source\window\stacking.cxx (735)
        mergedlo.dll!vcl::Window::ImplResetReallyVisible() Zeile 747
        	unter d:\lo\core\vcl\source\window\stacking.cxx (747)
        mergedlo.dll!vcl::Window::Show(bool bVisible, ShowFlags nFlags) Zeile 2198
        	unter d:\lo\core\vcl\source\window\window.cxx (2198)
        mergedlo.dll!vcl::Window::Show(bool bVisible, ShowFlags nFlags) Zeile 2176
        	unter d:\lo\core\vcl\source\window\window.cxx (2176)
        [Inlineframe] mergedlo.dll!vcl::Window::Hide() Zeile 925
        	unter d:\lo\core\include\vcl\window.hxx (925)
        mergedlo.dll!vcl::Window::dispose() Zeile 402
        	unter d:\lo\core\vcl\source\window\window.cxx (402)
        mergedlo.dll!Edit::dispose() Zeile 258
        	unter d:\lo\core\vcl\source\control\edit.cxx (258)
        mergedlo.dll!ComboBox::dispose() Zeile 132
        	unter d:\lo\core\vcl\source\control\combobox.cxx (132)
        mergedlo.dll!SvxFontNameBox_Impl::dispose() Zeile 1322
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (1322)
        [Inlineframe] mergedlo.dll!VclPtr<SvxFontNameBox_Impl>::disposeAndClear() Zeile 206
        	unter d:\lo\core\include\vcl\vclptr.hxx (206)
        mergedlo.dll!SvxFontNameToolBoxControl::dispose() Zeile 3309
        	unter d:\lo\core\svx\source\tbxctrls\tbcontrl.cxx (3309)
        mergedlo.dll!framework::ToolBarManager::RemoveControllers() Zeile 651
        	unter d:\lo\core\framework\source\uielement\toolbarmanager.cxx (651)
        mergedlo.dll!framework::ToolBarManager::dispose() Zeile 468
        	unter d:\lo\core\framework\source\uielement\toolbarmanager.cxx (468)
        mergedlo.dll!framework::ToolBarWrapper::dispose() Zeile 105
        	unter d:\lo\core\framework\source\uielement\toolbarwrapper.cxx (105)
        mergedlo.dll!framework::ToolbarLayoutManager::destroyToolbars() Zeile 666
        	unter d:\lo\core\framework\source\layoutmanager\toolbarlayoutmanager.cxx (666)
        mergedlo.dll!framework::ToolbarLayoutManager::reset() Zeile 364
        	unter d:\lo\core\framework\source\layoutmanager\toolbarlayoutmanager.cxx (364)
        mergedlo.dll!framework::LayoutManager::implts_reset(bool bAttached) Zeile 458
        	unter d:\lo\core\framework\source\layoutmanager\layoutmanager.cxx (458)
        mergedlo.dll!framework::LayoutManager::frameAction(const com::sun::star::frame::FrameActionEvent & aEvent) Zeile 2757
        	unter d:\lo\core\framework\source\layoutmanager\layoutmanager.cxx (2757)
        mergedlo.dll!`anonymous namespace'::XFrameImpl::implts_sendFrameActionEvent(const com::sun::star::frame::FrameAction & aAction) Zeile 2952
        	unter d:\lo\core\framework\source\services\frame.cxx (2952)
        mergedlo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun::star::uno::Reference<com::sun::star::awt::XWindow> & xComponentWindow, const com::sun::star::uno::Reference<com::sun::star::frame::XController> & xController) Zeile 1470
        	unter d:\lo\core\framework\source\services\frame.cxx (1470)
        mergedlo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Zeile 1701
        	unter d:\lo\core\framework\source\services\frame.cxx (1701)
        mergedlo.dll!framework::pattern::frame::closeIt(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface> & xResource) Zeile 62
        	unter d:\lo\core\framework\source\inc\pattern\frame.hxx (62)
        [Inlineframe] mergedlo.dll!framework::CloseDispatcher::implts_closeFrame() Zeile 492
        	unter d:\lo\core\framework\source\dispatch\closedispatcher.cxx (492)
        
        Change-Id: Ie05cd05158df58021d0fb4a19e9e38cd35af2426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164451
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f3c9adfbe50f3b74d5f6bbcf2f76132da1916751]

        Fix UBSan build's RTTI needs
        
        ...after 0ed1cb5457a2106316f9d7fda10685360db4bc30 "make more symbols private in
        writer" had caused CppunitTest_sw_core_text to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI12SwLineLayout"
        
        Change-Id: I3f1fb7d6bca2ec726851c39919dddeeabb618542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164520
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Miklos Vajna  <vmiklos@collabora.com>  [2221ca74ecec97f3266dcddd2f257cb7fbc132d0]

        CppunitTest_sw_uibase_dochdl: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything.
        
        Change-Id: I5e189764dd8a72d4eff021a2430b480db24f3341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164519
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [68fb3fe5aa439bae04aed63bbb7433810dc6f479]

        fix indent
        
        Change-Id: Ia96cd097829765d8e00c1ffa5962cd458d3820c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [429eb73aa8587a331f9303b674654c30ed513bc5]

        add truncate-multiline for consistency
        
        Change-Id: Ib9c2e28b583dd3cc8d877d69a39dce73fd54fdba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-07  Noel Grandin  <noelgrandin@gmail.com>  [07ead0555088dff6fbea4159ee26d1aeda2df19a]

        unlock mutex around lok_preload_hook
        
        because it now instantiates some services
        
        Change-Id: Ia4f7c2df9f8dca3334906f0b482853002666ddd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164484
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d8d5b385aaca907f3c68ead16c7d133e43c92973]

        Fix UBSan build's RTTI needs
        
        ...after 0ed1cb5457a2106316f9d7fda10685360db4bc30 "make more symbols private in
        writer" had caused CppunitTest_sw_layoutwriter3 to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_layoutwriter3.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_layoutwriter3.so: undefined symbol: _ZTI9SwEditWin"
        
        Change-Id: I97660648a78fe23bb9374ca28c7809490b715476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164513
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d3151a1a19f7deca76886a09442ed33b8750b0f7]

        Fix UBSan build's RTTI needs
        
        ...after 0ed1cb5457a2106316f9d7fda10685360db4bc30 "make more symbols private in
        writer" had caused CppunitTest_sw_odfimport to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_odfimport.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_odfimport.so: undefined symbol: _ZTI14SwTransferable"
        
        Change-Id: Ia6be10efb380b298488af351e85c5655254c3f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164511
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-07  Gökay Şatır  <gokaysatir@gmail.com>  [693b7fcf7aef50ef6a55c170880f2854afd8fb12]

        Revert hyperlinkInfoAtPositon changes.
        
        Revert "Implement hyperlinkInfoAtPosition for Impress."
        
        This reverts commit 876543305c78cb596720da087454a5c54e5feb06.
        
        Revert "Readonly Hyperlink Info - normalize the clicked coordinates."
        
        This reverts commit 322669725b771f5fa2b3c10c5fb73238ca3713f6.
        
        Revert "Implement hyperlinkInfoAtPosition function for Calc."
        
        This reverts commit be01dd78c47b51b19603a6259504e29b11979b0b.
        
        Revert "Implement hyperlinkInfoAtPosition for Writer."
        
        This reverts commit 6773c8929690f557d29bc282dd8f5c4381da3484.
        
        Revert "In readonly mode, we restrict many events like click."
        
        This reverts commit a4f3b97e506f38e0c43d6fbf1192cc523750a9fd.
        
        (cherry picked from commit c3f1d63178d6aaa0888085c7b641eb6d49a18276)
        
        Conflicts:
        	sc/source/ui/unoobj/docuno.cxx
        	sd/source/ui/unoidl/unomodel.cxx
        	sw/source/uibase/uno/unotxdoc.cxx
        
        Change-Id: Ie821a4bca6e6b4649cea17748c44af105cd45d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164481
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-07  Dr. David Alan Gilbert  <dave@treblig.org>  [1a7f06f01315992b9dfb05e1f9c46307cd72dac8]

        sdext.pdfimport: Use std::unique_ptr
        
        as per Noel's suggestion - this also ends up fixing some leaks as well.
        
        Change-Id: Ia6099afc1955c341256ec0de5a0f839c005d9b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7094c815628c70ac0430cd2ddc21f13b0b316d2]

        make more symbols private in calc
        
        Change-Id: Id36a104e9d016dfc72477000c3899cf8682ad102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c5fda14fff397d5d503f749ad019791d7e4ef83]

        tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify
        
        shaves 2% off the load time
        
        Change-Id: I579825bd6101b57a44b0f3118ede17ec2393d9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Noel Grandin  <noelgrandin@gmail.com>  [aad40b222cc646749cf7bb67e8d45a2d77018eb8]

        fix use-after-free in PDFWriterImpl::appendUnicodeTextStringEncrypt
        
        where if the resize triggers a copy, the pCopy pointer is now
        pointing to a block of memory that has been freed.
        
        Change-Id: I2ecfe6ad30f85b4c9e8c85f6296ac03ed4f04c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164485
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-07  Justin Luth  <justin.luth@collabora.com>  [b0f8b695ef25dfd24416afe36b26d7d4f41c40a9]

        tdf#160049 full unit test: use margins with left/right HoriOrientRel
        
        The other unit tests focused on the concept in general,
        but always used the same situation.
        
        This is a comprehensive test,
        indicating the things that should NOT use the margins (center, left by)
        and both things that do use the margin (right, as well as left).
        
        So there are a few "do not break what is already working" situations
        now tested for...
        
        Change-Id: I77a5d3e6244710def76b35dac1c6f0fe9ec9e480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164474
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-07  Justin Luth  <justin.luth@collabora.com>  [77980d4375b270f328afe1dd90e96e2e31fd498d]

        tdf#160049 dml shape import: use margins with left/right HoriOrientRel
        
        make CppunitTest_sw_ooxmlexport21 \
        CPPUNIT_TEST_NAME=testTdf160049_anchorMargin
        
        Change-Id: I3e2df2037cabfedbb6df6b8c8257e90baeaab96e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164445
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ab95ed2c4b1eddc2188bd455653a77140aa3816c]

        Use less boost_headers in low level libraries
        
        Most of these don't use boost themselves, nor do they need
        it transitively since the use of boost::optional was removed
        
        Change-Id: Ic9dee1c4e160b313ec5b91677b02ffdea6c5779d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164440
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-06  Oliver Specht  <oliver.specht@cib.de>  [bea5341c22b40f690059933550e721cdcfb466aa]

        Improve clone formatting
        
        Follow-up to 178d8a38e133aebd4cff1af2d2c49aec60468c92
        Makes sure that without selection at target position only
        character attributes are copied
        
        Change-Id: I677b1ef29855fb2cf4c42a7b821678ecdd37c7f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164430
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-03-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [98c42f7e961e77d7f1c02d53862e4e78ecd07653]

        Adapt to emsdk 3.1.46
        
        ...where it failed with
        
        > In file included from static/source/unoembindhelpers/PrimaryBindings.cxx:13:
        > In file included from ~/emsdk/upstream/emscripten/cache/sysroot/include/emscripten/bind.h:23:
        > ~/emsdk/upstream/emscripten/cache/sysroot/include/emscripten/val.h:226:20: error: assigning to 'void *' from 'const void *' discards qualifiers
        >   226 |   cursor->w[0].p = wt;
        >       |                    ^~
        > ~/emsdk/upstream/emscripten/cache/sysroot/include/emscripten/val.h:248:3: note: in instantiation of function template specialization 'emscripten::internal::writeGenericWireType<const void>' requested here
        >   248 |   writeGenericWireType(cursor, BindingType<First>::toWireType(std::forward<First>(first)));
        >       |   ^
        > ~/emsdk/upstream/emscripten/cache/sysroot/include/emscripten/val.h:256:5: note: in instantiation of function template specialization 'emscripten::internal::writeGenericWireTypes<const void *>' requested here
        >   256 |     writeGenericWireTypes(cursor, std::forward<Args>(args)...);
        >       |     ^
        > static/source/unoembindhelpers/PrimaryBindings.cxx:309:56: note: in instantiation of member function 'emscripten::internal::WireTypePack<const void *>::WireTypePack' requested here
        >   309 |                     emscripten::internal::WireTypePack argv(self.getValue());
        >       |                                                        ^
        
        see the comment at
        <https://github.com/emscripten-core/emscripten/commit/0f83fd40533248cce42464e1b9b586281202f247#r139443236>
        "[Wasm64] Fix embind with addresses over 4gb (#20071)"
        
        Change-Id: I1f472e9dc57b3abfbe1ba8a0f3a3bd70c1c484f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164463
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [119696c73eb7a2f4187efea503ebb88a19105819]

        Adapt Exception test to emcc/Clang versions that support std::source_location
        
        ...so that the Exception's Message is something like "error at
        unotest/source/embindtest/embindtest.cxx:271" instead of just plain "error"
        
        Change-Id: I3b236dc91cc75f859000a2283f04413fcbbd6b39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164470
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [31729454450b0de4f3f3b96c9123de9736df9d6a]

        Update documented emsdk version
        
        ...to what is known-working at allotropia.  (Also, emsdk --embedded option is
        redundant since
        <https://github.com/emscripten-core/emsdk/commit/3e9f04d467ba300b43fc40dab657c56f39751c96>
        "Remove support for non-embedded mode".)
        
        Change-Id: I7d3f3b72f131301ddc92fcf22503b575f30e7086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164464
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b784236d7c3bf386deeeadcf79d9e9b289bf991]

        tdf#158773 reduce cost of TextProperties::Notify
        
        Shaves 30% off the load time here, by re-arranging the logic so we do th
        expensive dynamic_cast less often
        
        Change-Id: If7a1605994e620dbdb61010506c624cc738359a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1552be34859d92865067c296b328770c83580e7]

        tdf#158773 reduce dynamic_cast'ing in CustomShapeProperties::Notify
        
        shaves 2% off the load time
        
        Change-Id: Ia7e4747711948ccfeb274cf32028d03486cc14a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [284d779a4e639705ed2732dbd3ab6b1e6431909d]

        Breeze scrollbars clipped, allocated space not wide/tall enough
        
        https: //github.com/flathub/org.libreoffice.LibreOffice/issues/247
        Change-Id: If04d4dd8b9608fc7c3a10bf36bad287cf183c2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164461
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [890a2f9a08afd6b2d9c1c9a93ff1383203b6b646]

        Fix typo
        
        Change-Id: I1bfc868d2b00871887ea105cf968a676000bf67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164472
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7fa24bcf126db1d24c81d76fc6afa26b0aa4b0b9]

        Remove exec bits from docx
        
        Change-Id: I2926cbb2a1909b314594707bd41e89860d338264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164473
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2a3dfd61e32287722d6e3d36b1133aadef3645a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d2beb0a61359f458b5b909fba1dd3452a1d2920d
          - Fix error in string for TOOLS BASIC library
            
            Change-Id: Iaedecb8ab3b65df5be98aea9004f003549ede0fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164490
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [22e97c90cb6334fd58bc856ab025291cb32b48d1]

        related: tdf#159879: test chart dialogs
        
        Change-Id: I91d5f4572edff99deb21dd2507c3216ef0d9e4c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164465
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [97497ff3b2b578f987af087b60df143ed0a4fb87]

        uitest: rename testfile
        
        To be used in a follow-up commit
        
        Change-Id: Ie6c74ebb0f91ec24e6ed3ec973bc47685cd9e91f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164452
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-06  Miklos Vajna  <vmiklos@collabora.com>  [1bca99617ad54d966625caadd71e52134c70ae44]

        cool#8465 sw lok: classify anchored images as complex selection
        
        Regression from commit 7a8dc25defee31edbb75a2f8c35f92ee2d3f3a83 (sw lok:
        simplify SwTransferable::isComplex(), 2021-02-23), in case as-char
        imagse were part of a selection, we considered that complex, but at-char
        was considered as simple, which is inconsistent.
        
        This was not intentional, simply the rework to avoid copying the
        selection to a temporary document lost this functionality.
        
        Fix the problem by using CollectFrameAtNode() to find at-char images,
        which tries to use the layout, so is not meant to be too slow.
        
        An alternative would be sw::GetFlysAnchoredAt(), but that doesn't try to
        use the layout, so avoid that.
        
        Change-Id: I647d0f3934f9553de69afbf2de059631e2b5619c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164453
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-06  Mike Kaganski  <mike.kaganski@collabora.com>  [957552bee41c282f0016cadd296f036556d7d14a]

        Drop some reinterpret_casts
        
        Change-Id: I5bcfe37adbf1f142950a1a2679f22333c711735e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-06  Mike Kaganski  <mike.kaganski@collabora.com>  [fcfffd2d938d21be76553d6dad38d85a7db80361]

        Check the correct member
        
        It's m_pViewObject2 that will be dereferenced below.
        
        Change-Id: Ic3696953f013099ee2595a08428ba793c81b6b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164455
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4fa240bc5f235b3f4030d0d89e9482f02ca68b31]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3eac551bbc02c2b4418b7a86eaa4f265d6854ee9
          - Corrections/precisions in ScriptForge help pages
            
            - removing outdated comments
            - deprecation and omissions in sf_form, sf_formcontrol, sf_formdocument
            
            Change-Id: Id5b1abdb812edc13a1489f0b01fff7f34a17416c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163548
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f8073caf0d6b331232f6edb5f18d14ddefdb465]

        tdf#158773 reduce cost of ContentInfo::GetText
        
        The specific path that is showing up on the perf profile is
        
        SdrTextObj::HasText -> EditTextObjectImpl::GetText ->
        ContentInfo::GetText
        
        Reduce the cost by 10% there by adding a method to check if we have text, and
        avoid the cost of constructing an OUString from an svl::SharedString.
        
        Also make use of the new method in places.
        
        Change-Id: Ibc2e0f61c4a2a6c33eea7f2cce09d692d82fd2b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164449
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-06  Mike Kaganski  <mike.kaganski@collabora.com>  [94113c523865c3162ffd9a5a76bebeb61d652399]

        Fix build
        
        ... after commit fcd4222d36e1864452163e5c94976eea353bbaf0
        (sw: SelectAll of section with RES_PAGEDESC corner-case, 2024-03-06).
        
        uiwriter.o : error LNK2019: unresolved external symbol "public: class SwFrameFormat const * __cdecl SwFEShell::SelFlyGrabCursor(void)" (?SelFlyGrabCursor@SwFEShell@@QEAAPEBVSwFrameFormat@@XZ) referenced in function "public: void __cdecl testPasteTableAtFlyAnchor::TestBody(void)" (?TestBody@testPasteTableAtFlyAnchor@@QEAAXXZ)
        C:\lo\build\workdir\LinkTarget\CppunitTest\test_sw_uiwriter.dll : fatal error LNK1120: 1 unresolved externals
        
        Change-Id: Ic82d2543bbe1349c6f20f9c64d083f47428e31a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164386
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [cba736567a713fffe030d0eb76c36d0cbb83eaa0]

        Create an UNO service to do the symbol lookup in sw
        
        which means I can remove one usage of gb_Library_set_plugin_for, which
        is blocking linking the sw module into --enable-mergelibs=more
        
        Change-Id: I8c199421c66de2dcf339ccc2d5cb9340d3bea914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164429
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-06  Heiko Tietze  <tietze.heiko@gmail.com>  [06d8c1e9d8ba1d04914d1c48c94732cdb5c68846]

        Resolves tdf#159486 - Larger hitbox for close button on infobar
        
        Change-Id: I83582c0c1ec7dd5e8f82bdf327e68ce88122ad03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164450
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-06  Justin Luth  <justin.luth@collabora.com>  [3aeaee800f675a5f733e06bb4ea73909570f9004]

        tdf#160049 doc import: use margins with left/right HoriOrientRelation
        
        No interesting existing unit tests.
        
        make CppunitTest_sw_ww8export4 \
            CPPUNIT_TEST_NAME=testTdf160049_anchorMargin
        
        Change-Id: Ib855d9f35db9e0f47aff18400b69a990cd1ad5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164444
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-06  Justin Luth  <justin.luth@collabora.com>  [eacf8dc7ab850f2d00bd4b327f830c55cf2a0d92]

        tdf#160049 dml import: use margins with left/right HoriOrientRelation
        
        I'm really surprised this wasn't found much earlier.
        Even DOC format isn't handling this.
        
        compat15 gets rid of this inconsistency.
        
        Surprisingly, there were no interesting unit tests matching this.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160049_anchorMarginVML
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160049_anchorMargin15
        
        Change-Id: Ic5c316569ad3640ba0e786d39a6e5c006c74d665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164443
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-06  Justin Luth  <justin.luth@collabora.com>  [e0ef7d54b4e4ccbaaada5d2c4a42ba41d961ea69]

        tdf#160049 oox import: use margins with left/right HoriOrientRelation
        
        I'm really surprised this wasn't found much earlier.
        Even DOC format isn't handling this.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf160049_anchorMarginVML
        
        Change-Id: I92ee8eceb6c6bab5f027663bae94d7acdf01be3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164442
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-06  AhmedHamed  <ahmedhamed3699@gmail.com>  [0d94f6c90788b1d9e90afb3314ffe165c2eafb96]

        tdf#126464 Remove "Numbering on/off" UNO command
        
        Removed code where uno:NumberOrNoNumber or FN_NUM_OR_NONUM is mentioned
        Didn't remove NumOrNoNum function as it is used in other places
        
        Change-Id: I7809974796580e4d43ad203817d4225301c30536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164175
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [1063e875c89789ee6bc1a4c77507e0f133832530]

        sw: remove dead code in CopyImplImpl()
        
        This looks dead already in CVS import?
        
        Change-Id: I865058d0e38b45917e82266925911addd10ec634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164435
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-06  Michael Stahl  <michael.stahl@allotropia.de>  [fcd4222d36e1864452163e5c94976eea353bbaf0]

        sw: SelectAll of section with RES_PAGEDESC corner-case
        
        The main problem here is that if a document has a RES_PAGEDESC on its
        first body text node, and you paste a section whose first text node also
        has a RES_PAGEDESC, the result inevitably has a page break that wasn't
        there before, and which is unwanted.
        
        SwEditShell::CopySelToDoc() needs a change to include the end node of a
        section at the start, so it is copied.
        
        Change CopyImplImpl() to insert a non-textnode *before* a text node at
        the insert position, instead of after it.  This simplifies the
        implementation: only SwFEShell::Paste() needs to care about removing an
        empty trailing paragraph, but SwEditShell::CopySelToDoc() needs no
        changes; both functions would need to delete the empty paragraph when
        inserting after.
        
        Several tests such as CppunitTest_sw_ooxmlexport3 testCrashWhileSave
        fail because of this, which can be solved by removing the DelFullPara()
        call in SwXText::copyText() that is now unnecessary.
        
        Generalise and simplify the "bAfterTable" code in CopyImplImpl(): it
        doesn't really matter what is before the insert position, what matters
        is if the pasted text starts with a table or section.
        
        Also, the fly-anchor-correction code (both here and in
        SwUndoInserts::RedoImpl()) needs to move to the first text node also in
        case a section was inserted (but the equal-looking code *before*
        inserting remains as is!), in the situation where the last node will be
        deleted.
        
        Now there are some test failures:
        
          unowriter.cxx:430:Assertion
          Test name: (anonymous namespace)::testSectionAnchorCopyTableAtStart::TestBody
          equality assertion failed
          - Expected: quux
          foo
          bar
          - Actual  : quux
          foo
        
        This is because the end position was created from SwNodeIndex aInsPos
        only, it needs to take also the aDestIdx from the "if (pEndTextNd)"
        branch.
        
          testTdf134250::TestBody finished in: 867ms
          uiwriter2.cxx:462:Assertion
          Test name: testTdf134250::TestBody
          equality assertion failed
          - Expected: 1
          - Actual  : 2
        
        The section is pasted now, so there are 2.
        
          uiwriter3.cxx:1519:Assertion
          Test name: testTdf135733::TestBody
          equality assertion failed
          - Expected: 1
          - Actual  : 2
        
        Table is now inserted before the first paragraph, which has a
        RES_PAGEDESC.
        
        (presumably regression from commit 9667e5ffd18d6167344e102b89a393bc981644ec)
        
        Change-Id: I820e381113fee90a81249afbc2280bfc3ddb7647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164401
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-06  Miklos Vajna  <vmiklos@collabora.com>  [a8b2efcd2124f08e6f3ba3613ce6993af9760e0a]

        CppunitTest_sw_txtexport: rework to avoid DECLARE_DOCBOOKEXPORT_TEST()
        
        No need go via Writer-specific macros.
        
        Change-Id: Icb5c3d699e03e299f9c93cd92120bc4db800828a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164447
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-06  Julien Nabet  <serval2412@yahoo.fr>  [6c92e46875988bad3850e7e3a917f42eb8c7b322]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd7186fc1b3f63bc941f61fe95116da060bdb5da
          - Revert "Related tdf#155723: "Cube" is in fact "Cuboid""
            
            This reverts commit d13c501f790c5130fa5b23da99be6b92770a08d4.
            
            Reason for revert: "Cuboid" is one of the Basic shapes, "3D Objects" still uses "Cube" (and it's right).
            My fault here, sorry for this.
            
            Thanks to Stanislav Horacek for having spotted this.
            
            Change-Id: I0ff1ed73cb6e6915034adf7949f8a4799fc0d3b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164381
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7150ce717fb24893d5b527a0587cc166f7c6ec68]

        remove deprecated IsGermanPreReform property
        
        deprecated in 2008 (and seemingly never even implemented)
        
        Replace the use of this property in sample code and
        in Java unit tests with another property (I arbitrarily
        selected "IsIgnoreControlCharacters")
        
        Change-Id: I2cb474f895ac221952b59e98bfdbc01012095519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164355
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-06  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7cdcf1bea77190744d381fde8d62582c21d712ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2db4af6e13fc373fecc4c04fb362a1ff26da738a
          - adjust section name of Text along path dialog
            
            Change-Id: Iadb098b5bd8463d7a700bfb4c51253e777051966
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164441
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-06  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [39894a65e6871582a743ae7297d34fad8d5497c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fcf19e4c9105e8e1a4d4523fc108ff2f957f2023
          - related tdf#160057: fix dead link to Edit Footer/Header
            
            Change-Id: Ib2b1f2c59802017504d0ebc06e195df591b029f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164383
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [04d884cc99eb66679fb254129b54488bd40e5abf]

        tdf#158735 Save solver settings for DEPS and SCO as well
        
        When bug tdf#38948 was originally fixed, the solvers DEPS and SCO were not considered. This caused a regression, because setting engine options for these solvers made them never be saved, even in its own sheet.
        
        This patch fixes that by incorporating the engine options for DEPS and SCO.
        
        Change-Id: I93af712f91da2f7b1ac57ed74f6c2c2d7d411bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164376
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [567a10caef0f2ebc9390babda545b410b5aa36c6]

        Add Embind'ing of UNO Any getter for exceptions
        
        Change-Id: Ief3cdebc1ee7c7b9f012741c9db8637dba9bbd07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164433
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [792a2847c8d9b6618fa920aaee1a6289248fca87]

        Keep recently introduced UNOIDL entity unpublished for now
        
        Change-Id: I635e08898bc2627dada89fed5a834a6145915ac9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164431
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2024-03-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9357b8ea752431b854eff6471f3192659324c2cb]

        Fix typos in commented-out TODO code
        
        Change-Id: I10bb684cce75c5ccb00bae7793f9bb58420241ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164432
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8fd18bd4616ab06049aa0c760b9248c04373863f]

        tdf#160056 comphelper::rng takes a mutex for every random number
        
        Change-Id: Ic4b50a9ea9e9eda62ca0877337462354b3fe3675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164403
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-05  Sujatro Bhadra  <sujatrobhadra@gmail.com>  [58d2abd2ed85beed48a7677f2b186914c6f2a6c9]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I6174cf1b689136e1302cffb2b26735dc33678e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164394
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [48ff49b9ff1f4a38a5f28dbde7aa5c743348f9ed]

        add sdbt to --enable-mergelibs=more
        
        Change-Id: Ib916270a32aa6f3c0f2d6a8ec43f99241f74b972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164426
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc5108a206d3234faf494653d99f6611affedaf3]

        add sd to --enable-mergelibs=more
        
        Change-Id: I48bb6db4ed53d076c576cca665099f67a780d114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164425
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Patrick Luby  <guibmacdev@gmail.com>  [ce8d6b6836744045264eda41bcfdc4571c8b1b26]

        Related: tdf#152524 eliminate UserData struct name collision
        
        The cui module has its own UserData struct and when building with
        --enable-mergelibs=more, this data collision will cause a crash
        when deleting a UserData instance in the xmlsecurity module because
        the cui module already has its own, unrelated UserData struct.
        
        Change-Id: I6418b049c72a2e902c9b5076b72fd240f65a593d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ed1cb5457a2106316f9d7fda10685360db4bc30]

        make more symbols private in writer
        
        Change-Id: I2c4745910fc3654f2021e77f9fa590d3da3464ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ee9b98a1eeb2f433e88cf3a630ab9d2e9aae5ef]

        add dbase,dbaxml to --enable-mergelibs=more
        
        Change-Id: Ia0898c820cfcddf981f414b33a2854c3917edca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164424
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ed1536c6eed2a7919a80c7f92617aa0a4058263]

        Create an UNO service to do the symbol lookup in sd
        
        which means I can remove one usage of gb_Library_set_plugin_for, which
        is blocking linking the sd module into
        --enable-mergelibs=more
        
        Change-Id: I90dae749f777446f67342d121e4dc29b974cb9b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [bacb92275c0c474d09146c0409cb547aef6551cf]

        add dbu to --enable-mergelibs=more
        
        Change-Id: I04e6516c0bd8d4e0c08c93c59f7c5b0aea88b0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [74a31f1b262f9770409ee68e04433adb7e3ab10c]

        Missing include (for free)
        
        Change-Id: I2dbf6d8894368d93bbed8c2bdf09f978196c6aa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164427
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [a082762fb3f41237df6385ab27f7a75d6ff92690]

        add dbahsql,dba to --enable-mergelibs=more
        
        Change-Id: Iaabb3356ced33186eeb2bd545bebb20918010638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8b9bcf021c1733c0def6043e4032d4f07bb889b]

        map SAL_DLLPUBLIC_RTTI to visibility:default for gcc
        
        Because I want to make more symbols private, but that runs into a
        problem with the special symbol "typeinfo for Foo" which is required for
        dynamic_cast.
        
        For clang, we can use SAL_DLLPUBLIC_RTTI to make just that magic
        "typeinfo for Foo" symbol visible.
        
        But for gcc, we are left with no option but to make the whole class
        visible via <MODULE>_DLLPUBLIC.
        (I have a feature request logged against gcc to support something like
        that at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113958)
        
        But I also don't want to use <MODULE>_DLLPUBLIC, since that blocks
        progress of reducing symbol visibility for platforms other than gcc.
        
        So map SAL_DLLPUBLIC_RTTI to visiblity:default for gcc, which means that
        only gcc suffers the negative affects of not having that annotation.
        
        However, that runs into the problem that gcc does not like
        visibility:default in a couple of places, so I have to introduce some
        extra preprocessor stuff.
        
        Change-Id: Ib4fc5c1d2a1f8cf87d5159a4b5684137ec061605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [f03cb8214a2b1b3de8d93c1a19319ecc82e4b21d]

        tdf#99969: chart2_uichart: Add unittest
        
        Change-Id: Iddf64e07b4f6ee6913965b294d8a41904d2fc558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164418
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [ace72e8c606aa5f32a425b4afa965a68a854bc85]

        liberation-fonts-ttf: upgrade to 2.1.5
        
        Change-Id: Ib9cb2b735bac16f8d2385914b660a83e55060e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164411
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e311a4b87bad35a50812574dd9a96d6f4cd8dfd8]

        Create an UNO service to do the symbol lookup in sc
        
        which means I can remove one usage of gb_Library_set_plugin_for, which
        is blocking linking the accessibility module into
        --enable-mergelibs=more
        
        Change-Id: I389fcafd80f1a450befbffdc252be497ba20f6d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Noel Grandin  <noelgrandin@collabora.co.uk>  [66fefd9a7d646d993ba8a2106c712865fe4e0ae1]

        Fix Windows --enable-mergelibs=more build
        
        after
        
            commit 68f55fc9a1aa8c0f403761e39e7531ae298ea79e
            Author: Vasily Melenchuk <vasily.melenchuk@cib.de>
            Date:   Wed Oct 25 22:26:14 2023 +0300
            vcl:  interface for WinAPI FlashWindow() function
        
        and
        
            commit 621e16205363c1eea0be57017997396dee63df4b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Mar 1 15:58:23 2024 +0200
            add UNLESS_MERGELIBS_MORE and use to reduce symbol visibility
        
        Change-Id: I32660173d255b4b49a346c56fadf998968580a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Miklos Vajna  <vmiklos@collabora.com>  [c5ac0ffae47dd2da74aaddd26e100aeb3b814c0b]

        tdf#159706 sw hide whitespace: fix lost follow on enabling this
        
        Regression from commit 6d8da2b2deb4be2182ca1852cec7eb38a4c654eb
        (tdf#96943 sw Hide Whitespace: don't create pages for widow / orphan
        ..., 2016-01-07), the reduced bugdoc has 3 paragraphs, 1.5 paragraphs
        are on page 1, 1.5 paragraphs are on page 2. Hiding whitespace moves the
        entire paragraph 2 to page 1, which is unexpected.
        
        Checking the original use-case, the
        CheckPageHeightValidForHideWhitespace() call in
        SwTextFrameBreak::IsInside() can be removed, and still the original
        "type character at the end of the document results in a new, unwanted
        page" problem is not back. Likely at some point in the meantime we gave
        up on these reduced page heights for the last page, so the original
        tweak for widow/orphan lines is not needed anymore.
        
        Fix the problem reverting the original, no longer needed fix, but
        keeping its testTdf96943 test in the CppunitTest_sw_uiwriter4 suite.
        
        Such reducing of last page doesn't happen with Word 2021, so probably
        this change in behavior is wanted.
        
        Change-Id: I5d46d0cd84d0071ffb9ef3f8e4ca7335e61bb226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164408
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b50db5e7c822943599f9914f60b95328f2a1389]

        ReemKufi: upgrade to 1.7
        
        Change-Id: I3ca9e6f973e642a6fade0ad0f9d4c902f8e8e2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164412
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-05  Pierre F  <fpy@bger.ch>  [020828abee9b96993434a1c85f8637e2bc00d88e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93e6f5c9420345fb5bb763596fbadccfa35eb78a
          - add link to *Navigator* page to make it unambiguous.
            
            per user feedback, see https://ask.libreoffice.org/t/documentation-of-keywords-and-hyperlinked-concordance/102978
            
            Change-Id: I6ce3bece7175757c507182204a34883374b6fa35
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164377
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-03-05  Noel Grandin  <noelgrandin@gmail.com>  [1842ad9fd51f5384f78df60c3c1f61ba631896f4]

        tdf#159933 crash when applying Solarize filter to raster image
        
        regression from
            commit 07b26af18d45ad7ecacc30c2c4cb2c23033e9f2d
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 22 16:01:03 2024 +0200
            make the graphic filter dialogs async
        
        Change-Id: I6463ef4d20bc5a994c6f1a5f937bb7e982c1c5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Laurent Balland  <laurent.balland@mailo.fr>  [c87cb8bca3804bfe853572dd0e7c47b64ccab9a5]

        Update Grey Elegant template
        
        - title page: use placeholders
           - remove LO logo
           - rename title page to follow resolution of tdf#150925
           - enlarge space around vertical bar
        - remove dummy texts and use outline placeholders (slides 3 to 8)
        - set same order for slides and master slides (slides 4/5)
        - remove unused styles
        - remove objects outside slides (Jigsaw and Bullet 3)
        - Jigsaw: move up quote to not overlap bullet
        - update preview (larger title, smaller file size thanks to Jérôme Bouat)
        
        Change-Id: I318fa2bf4a16f2bd7d3242f5246bdb5fc88d5098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161289
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-03-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a3412a34a15e5f5653329da8f073f013ca0c9dc]

        bin: Add initial script to replace missing fonts
        
        It already contains some replacements I found along the way
        For now it works with docx, xlsx and pptx files.
        I have to test it with odf formats.
        
        Change-Id: Ia68bc7561f0e41580ad1834a1a345b618f3e688c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164393
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fbefbfc357aaf4e36a10085b6645e8ba97187543]

        save and return the set value in the case that 'SpellOnline' is used
        
        in XFunctionAccess
        
        Change-Id: I9b917c84732dfd205e46e9bc00656c09341c7077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164329
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-05  Noel Grandin  <noelgrandin@gmail.com>  [81d4f14e5968453b72ba754a7b3e6c13a30abbf4]

        reduce heap allocation in JSDialogNotifyIdle
        
        makes the code simpler too
        
        Change-Id: Ic452895a20fb2908f7383082069a84ef3fa6a4d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164395
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-05  Jim Raykowski  <raykowj@gmail.com>  [cf6c6db51eada17408c412173331db0820a23e5d]

        tdf#49994 Fix text selection over pages for multi column tables
        
        with repeated headings
        
        Change-Id: I6cddeb132ff4f8ff27ea03701067d7a3d4c4cf82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79113
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-03-05  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [357b43e7d7c1bd91e908f4fb92ba8c7472fe39dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e69e855e524c31af3592fd9925489ad76f4c842
          - tdf#159808: update menu entries with fixed vs variable
            
            Change-Id: Ifb1ec0faa41c22ed61ea6fb78adbf5e1de21754b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164378
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-03-04  László Németh  <nemeth@numbertext.org>  [9574a62add8e4901405e12117e75c86c2d2c2f21]

        tdf#132599 cui offapi sw xmloff: implement hyphenate-keep
        
        Both parts of a hyphenated word shall lie within a single
        page with ODF paragraph setting fo:hyphenation-keep="page".
        The implementation follows the default page layout of
        MSO 2016 and newer by shifting the bottom hyphenated line
        to the next page (and to the next column, see last note).
        
        Note: this is a MSO DOCX interoperability feature, used
        also in DTP software, XSL and CSS.
        
        * Add checkbox/combobox to Text Flow in paragraph dialog
        * Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationKeep)
        * Add ODF import/export
        * Add ODF unit tests
        
        New constants of com::sun::star::text::ParagraphHyphenationKeepType,
        containing ODF AUTO and PAGE (borrowed from XSL), and for the
        planned extension ParaHyphenationKeepType of ParagraphProperties:
        
        – COLUMN (standard XSL value, defined in
          https://www.w3.org/TR/2001/REC-xsl-20011015/slice7.html#hyphenation-keep)
        
        – SPREAD and ALWAYS (CSS 4 values of hyphenate-limit-last,
          equivalent of hyphenation-keep, defined in
          https://www.w3.org/TR/css-text-4/#hyphenate-line-limits).
        
        Note: the implementation truncates only a single hyphenated
        line, like MSO does: the pages can end in hyphenated
        lines (i.e. in the case of consecutive hyphenated lines),
        but less often, than before.
        
        Clean-up hyphenation dialog by collecting "Don't hyphenate"
        options at the end of the hyphenation settings, and negating them
        (similar to MSO and DTP), adding also the new option
        "Hyphenate across column and page":
        
        [x] Hyphenate words in CAPS
        [x] Hyphenate last word
        [x] Hyphenate across column and page
        
        Note: ODF fo:hyphenation-keep has got only "auto" and
        "page" attributes, while XSL defines also "column".
        Because of the interoperability with MSO and DTP,
        fo:hyphenation-keep="page" is interpreted as
        XSL "column", avoiding hyphenation at the end
        of column, not only at the end of page.
        
        Change-Id: I5c6b7adc0671a5a790568e7bf1d33256e607f85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164158
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-03-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [2eba8bb8d43d39eb229a81947907e70f50859a76]

        tdf#150443: replace missing fonts in testfile
        
        This commit reverts 0b21e2a404c114529376dc50764dc0286dafc745
        "sw: UITest_writer_tests8 test_tdf150443 more tolerant"
        
        Change-Id: If83a7b0a8dc2289aba3201edfdf19d0ca839459a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164392
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-03-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [893af92ae990909d477434d48d97dae0814e7e58]

        Add Embind'ing of UNO Any getter for sequences
        
        Change-Id: I5b81ad3d5f1351062aef43105ea7ec4678045a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164360
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0bab5cda2123ecc7f3775d05ca5103bdef23bfe8]

        Add Embing'ing of UNO Any getter for enums
        
        ...which taps into the internals of emscripten::val, which is based on
        std::type_info identifiers, so we need an additional statically-built mapping
        between UNO (enum, for now) types and std::type_info
        
        Change-Id: I9fc1ff33fe31a1e1052504905de446ed2193e014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164359
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8428368d79118f1d0e09615c5d2b92065b8838d4]

        Improve Embing'ing of UNO Any somewhat
        
        Change-Id: I82e38ac815765b62601076cf61745fe9889451b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164358
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82bfc24c9ceb00a730580ad9338ead2f64437d05]

        GLib-GObject-CRITICAL **: gsignal.c:2778: instance X has no handler with id Y
        
        Change-Id: I4fbbd4af0ed1605874e2ef2694ecda0a9e107a07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b12ca7776533ab33b87943a7966ace1d3230def]

        add wpftcalc to --enable-mergelibs=more
        
        Change-Id: I3f3bba92202e833066b1ef2e9f76ae34698a6b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [a08cc309529c7bded0e4898ef638ca7bdc8c140f]

        tdf#158802: sc_uicalc: Add unittest
        
        Change-Id: Ic9460d36ef1df18a05126bc06a5214c1d87317db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164331
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-04  Miklos Vajna  <vmiklos@collabora.com>  [3372d5c37e07a9862fadc0041587e30759ad0379]

        svx: prefix members of XGradientEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib00e0ea61ad421eb1d02d973ab8dc8c79b006a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164326
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5d529e6290a26dcf44a683b252921b2015fb5719]

        Fix typo
        
        Change-Id: I4242a774d29bd700a5459485938d593a49abfaa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164391
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-04  Noel Grandin  <noelgrandin@gmail.com>  [d36b7b2628367c6ed29ed47e4345bd4fae8cf2ee]

        move Windows amd macOS builds to mergelibs=more
        
        Linux is stuck with normal mergelibs because Debian wants it like
        that, but we can use mergelibs=more on Windows and macOS to
        further reduce startup time there
        
        Change-Id: I3a2716f877bb54b51486da127bf5ed4ee59075b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164171
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-04  Julien Nabet  <serval2412@yahoo.fr>  [e19340d13ca40ede3fe671b7d2b710e0a53a0d31]

        tdf#159373: band-aid for crash in: ScTable::HasAttrib
        
        band-aid because as Eike indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=159373#c8
        "Question remains why this PostPaint() is called at all for an invalid range.."
        
        Change-Id: Ie44378119202addd8ddb46f0be4b0124be9fd48b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164354
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-04  Miklos Vajna  <vmiklos@collabora.com>  [2efe362c99a9fa6e9a71b9b675b025c64b6c7f9d]

        tdf#159483 sc HTML copy: handle data-sheets-formula attribute
        
        When a formula cell gets copied from Calc to google docs, only the
        formula result was copied, not the formula.
        
        There is a data-sheets-formula attribute on <td> that can describe the
        formula we have.
        
        Fix the problem by extending ScHTMLExport::WriteCell() to emit that.
        
        This is more or less the export equivalent of commit
        7812adb2ed11a3e08be24d3f2f94d14bfd740c55 (tdf#159483 sc HTML paste:
        handle data-sheets-formula attribute, 2024-02-12).
        
        Change-Id: Iab373ce8a028deb6a2874a8c690e928edf5d79f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164363
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-03-04  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [68f55fc9a1aa8c0f403761e39e7531ae298ea79e]

        vcl:  interface for WinAPI FlashWindow() function
        
        To improve LibreOffice UX it will be great to have possibility to
        signal user on some event did happen, but without capuring focus
        and bringing LO to foreground, like it is happenings sometimes. It
        can be annoying.
        
        For example, if dialog window is opening slowly and user did switch
        to another application, this is used to inform user that there
        are some updates in LO window: dialog finally alive.
        
        There are somewhat confusing implementation of this feature: VCL dialog
        window became visible and actual Windows window should use
        ::FlashWindow() are very different in hierarchies, so it is somewhat
        challenging to find window to flash or even decide shoud we flash window
        or not.
        
        Change-Id: I6ca6706d2dda8902aea273ebe6e318ec9bf4beda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158472
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-03-04  Michael Stahl  <michael.stahl@allotropia.de>  [0b21e2a404c114529376dc50764dc0286dafc745]

        sw: UITest_writer_tests8 test_tdf150443 more tolerant
        
        This fails on Fedora 39, also in the libreoffice-24-2 branch, with:
            self.assertEqual(get_state_as_dict(xWriterEdit)["CurrentPage"], "4")
        AssertionError: '5' != '4'
        
        Presumably a font substitution changing metrics problem, as "NexusSansOT"
        is not found.
        
        It looks like the exact page doesn't matter for the test.
        
        Change-Id: I62eadb8321352ea47a0f8f83ab91fd50ff01f7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164353
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [59c5e17449ade91e6e2a2a2ea43fdd88010a6144]

        Update git submodules
        
        * Update translations from branch 'master'
          to fd5c3f2ec0852b712b34e7e99b4853a016eac72e
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I92a4c8e684156e8f1a0bcd46fff4a940c37348ce
            
2024-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f43f6c4292bd20b18d29abbd7763e098b100e95c]

        Remove break after return
        
        Change-Id: Id8e933ba8b7b0836613b3b722f3eda081b77f1f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161463
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2024-03-04  Regina Henschel  <rb.henschel@t-online.de>  [199523b553957936dc31b8c3556ef2e47c6bc3a1]

        tdf#160003 use correct sheet in clipboard for test
        
        ..whether a page anchored object is contained in the to be copied area.
        
        Change-Id: I816e342770332e6d751b57a38e5ebabe33feb16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164307
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6f80ddb3f05a3b55239866e6e4d470f6903aaae]

        tdf#159808: fix -> fixed
        
        Change-Id: Ib4a1460b6d92a6e140748294d752967dd8cfa89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164351
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-04  Patrick Luby  <guibmacdev@gmail.com>  [86c3105fdb6b67fcc65e76077785b745871151b6]

        tdf#159515 rename impGetTransparence() to impGetAlpha()
        
        Commit 81994cb2b8b32453a92bcb011830fcb884f22ff3 makes
        impGetTransparence() return alpha instead of transparence. So,
        rename the function and skip reverting the result to obtain the
        alpha value.
        
        Change-Id: Ied3bf8ae4a0de2ae36074dba9f78ccc93480b15a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164322
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Tested-by: Patrick Luby <guibomacdev@gmail.com>

2024-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [6d797c83d9fb891b783de39646b42d34a895c81e]

        tdf160017: make sure to emit the closing tags in correct order
        
        This reimplements how the starts and ends of attributes are stored in
        HTMLEndPosLst. Instead of a plain list, now it is a sorted map, with
        positions as keys, and a vector of HTMLStartEndPos* as values.
        
        In commit b94b1fe936ddc4a9b86fbeb9c9c6ab0fca52f0bc (CharBrd 9.1: HTML
        filters, 2013-09-08), the character borders attributes started to be
        set in a special order, in front of the position's other attributes,
        to allow merging them. But that created a problem of knowing in which
        order to close respective tags.
        
        The change here sorts the closing tags for the current node only when
        writing them. At this point, it is possible to consider the opening
        positions correctly.
        
        Change-Id: I466ffa1c0eb28874ded003035e0cf772e31585b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164325
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e9e2b79e6ba9c275cf451861184de4e53f9b6776]

        cid#1545317 this didn't help in the end to silence Use after free
        
        so just ditch it, crashtesting didn't find anything anyhow.
        
        Change-Id: I117bbbb5b78b93e06174357bd11b10f0a8859a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164302
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-04  Noel Grandin  <noelgrandin@gmail.com>  [04c73e27491feaf21e0a2c9288aee5a9f9850386]

        cool#8327 use tools::JsonWriter for theme colors
        
        Change-Id: Iebca3781910f9e28100258da8266d51f673f31d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164232
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-04  Michael Stahl  <michael.stahl@allotropia.de>  [cf4df3e51b609613134e3146f526d8e6b07946c3]

        sw: for Undo, add FLY_AT_PAGE in GetFlysAnchoredAt()
        
        SwUndoInserts::IsCreateUndoForNewFly() now returns true for these, so
        they get Undo objects on Paste, which is of course wrong.
        
        (regression from commit 359e5af31c330a137fed6ba3140b77cd759c28bb)
        
        Change-Id: Id5abb38c662a9c55826cde6d8b151613c852de72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164221
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b044878a411e50775e2fbdb5f2715b6f62ec038]

        Fix typo
        
        Change-Id: I27c2ecec6355fd81f06c66c016050f1b168179b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164044
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0c3c894ddc7bd728bc9ecb6cf470be168041acba]

        Fix typo
        
        Change-Id: Id70b30aa0b9c204a8f74a7977a03822691d4cb45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164321
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-03-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c398fead74ee63c51d54fdb06f04438b2c3233e0]

        Resolves: tdf#159854 Trigger text is black on dark grey in Animation sidebar
        
        in dark mode
        
        Change-Id: I2cbf9b7d14a501c309a02dd3080511f527f9e1d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-04  Noel Grandin  <noelgrandin@gmail.com>  [b03f1dfb15a67641bc516a1c6b5632857451a18d]

        tdf#159817 tdf#159802 Form controls coordinates wrong when export to pdf
        
        This reverts the following commits:
        d408fe5cd45c9594feecec727ab2f73c66e361d0 "unnecessary LogicToPixel in CheckBox::Draw"
        7441aaa4c5b2215e369c62e22af098184e8ce807 "unnecessary LogicToPixel in RadioButton::Draw"
        a2dacae0c8acfad8a5e5a16c766ee740ec202c5e "unnecessary LogicToPixel in ComboBox::Draw"
        f73e8c895e24fda10931ecf344a1a0dd8bcdf92c "unnecessary LogicToPixel in TabPage::Draw"
        
        I am fairly sure this code that I am restoring is dodgy,
        and I am just papering over some other bug somewhere, but
        I can't seem to see where that is.
        
        Change-Id: I0f9088e43b0e3af74fd5ff9d297008ee23a3facb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-04  Miklos Vajna  <vmiklos@collabora.com>  [17581e684ca701bfd96ed2bf16aa14c3903b74d4]

        tdf#159483 sc HTML copy: handle data-sheets-value attribute for the num case
        
        Type 1000 and 2000 into cells in Calc, format them as e.g. a HUF
        currency, the resulting formatted strings can be copied to google
        sheets, but the SUM() on them will be 0 (and not 3000).
        
        Our own import knows how to read metadata to get the original float
        value, but our exporter didn't emit these.
        
        Fix the problem by adding support for non-boolean float values + number
        formats in the HTML export.
        
        This is more or less export equivalent of commit
        789964785a61daab5f8065f006dd7aaf843c7236 (tdf#159483 sc HTML import:
        handle data-sheets-value attribute for the num case, 2024-02-09).
        
        Change-Id: I5acb3724367ce38bd96056dbe4f846cd7bbc5fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164213
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea4dfeb83889d5dc955646999e4b2b06693e631b]

        finish removing IsSpellCapitalisation property
        
        which was partially removed in
            commit 9bb9ba6ae02692e65498bae4598e3b63bb65c02e
            Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Date:   Mon Oct 2 12:33:34 2023 +0200
            [API CHANGE] Remove deprecated IsSpellCapitalization
        
        Change-Id: I861c8c484b77a041d91cb25ddeecb7027a2fd96c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164183
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [88c6e127b3b9d2c80bb3cf04e74c4152ddfe9674]

        Fix --enable-mergelibs=more --enable-sal-log build
        
        ...after 621e16205363c1eea0be57017997396dee63df4b "add UNLESS_MERGELIBS_MORE and
        use to reduce symbol visibility" caused
        
        > vcl/source/opengl/x11/context.cxx:118: error: undefined reference to 'OpenGLHelper::debugMsgStream(std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > const&)'
        > vcl/source/opengl/x11/context.cxx:270: error: undefined reference to 'OpenGLHelper::debugMsgStream(std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > const&)'
        > vcl/source/opengl/x11/context.cxx:370: error: undefined reference to 'OpenGLHelper::debugMsgStream(std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > const&)'
        > vcl/source/opengl/x11/context.cxx:251: error: undefined reference to 'OpenGLHelper::debugMsgStream(std::__cxx11::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > const&)'
        > collect2: error: ld returned 1 exit status
        > make[1]: *** [vcl/Library_vclplug_gen.mk:20: instdir/program/libvclplug_genlo.so] Error 1
        
        Change-Id: If27b1ffaad7b40dd3baffa8b3a33b1cc3a8e7153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164314
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e939685f9c6918830bd3097062790bfccbce937e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0fb58194a0658fe83ca170a9cb8adf72371c8c3e
          - tdf#159872 Help page for FILTER function.
            
            Change-Id: Ie0cb1513500a1660688687fe8ac3e4b569b345a9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164320
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dc33fe966f10a8e12af0b862ca15f8a96a5c82a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef6f345505552524570d22387543bf45ffa4f8f4
          - Add sample file for Calc Data Statistics
            
            Change-Id: Ie417559a6c1c5f65381428a58a84d41dc7a47d1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164319
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a3a3a477a49c57da4de56a1593266a113ae741b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c608b996929e60592570bf750ea826e11bc3b4a
          - Wrong value in example for covariance
            
            Change-Id: I8302054d8bc700fcc608e63c48dd13a19e03832d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164318
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8fd4605585653f54845f7488910df18a4cc89df6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to efdfc42180b536865804f5006780061fdf268301
          - Housekeeping - no content change
            
            Change-Id: Ib5fc96e82870b94315f72de2ecacd85810698d89
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164317
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e6210a214a98ee6403628ffd8992886e2d7c28f2]

        Fix typo
        
        Change-Id: I67e8c8ecacc0a3903735854cd076e4483583a27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164310
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [66b5883f962c8134138ac768221afe9605b9391e]

        Fix typo
        
        Change-Id: I581146b8a4cc5813048082a9d9c13f38db2cc714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164309
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bc806620bb68385652211f307945d8a72696bd96]

        Fix typo
        
        Change-Id: I256d2edd2ac557a4533f8978f0fdf144297ce2a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164308
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd34277a264d11a804688a100c016e09aa8f3181]

        cid#1592910 Dereference null return value
        
        Change-Id: I7524c3e91447f4421083dfda10d3dd1c3a6e482d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164300
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fc4fcf1dff53f6c04481b31071af0e4918b563a]

        cid#1592908 Dereference null return value
        
        Change-Id: Ic729d455047f31983425b3483deeb8d7448f5cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5dab4eb854609d5d84bb0bfa918f0a5bf0459b53]

        Resolves: tdf#159696 Small capitals with 'Individual words' underlining
        
        Change-Id: I79af3f74ef384f734273b00bddbcfed8952a3ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [0c3580828811496052f41b09ad68fcc00a525f6f]

        tdf#153706: do not add categories, when source data doesn't have them
        
        lcl_AllOperator is used in XChartDocument::attachData implementation.
        When a data without existing categories is passed there, like an XY
        scatter, lcl_AllOperator used to force creation of the categories in
        the target, by returning 'true' unconditionally from setsCategories.
        This meant, that a new sequence of numbers starting from 1 was used
        as X values, and the old X data was interpreted as an extra Y series.
        
        This changes lcl_AllOperator::setsCategories to try to check if its
        data actually contains categories. Thus, XChartDocument::attachData
        will use categories either when the chart already uses categories,
        and ChartDataWrapper::applyData detects that using a call to
        DataSourceHelper::detectRangeSegmentation; or when the new data has
        it; but not when neither had it. When it's not possible to detect if
        there were categories in the new data (e.g., with user data), old
        behavior is used, setting categories.
        
        It could be an alternative to detect the chart type using
        xOldDoc->getDiagram()->getDiagramType() == "com.sun.star.chart.XYDiagram"
        in XChartDocument::attachData; and then decide to force the creation
        or not. But it seems hackish, and not really universal: other chart
        types must be tested (bubble?), no idea how to handle hypothetical
        cases when applied data contains categories in case of XY chart, etc.
        
        Change-Id: I86b34f6799c30b103f7fc6b2faf6ec255a9d137b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164298
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [f8a57b52fb2c6810d75f9c48868f56ca71912a89]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5da9e11ea767529d55630a96fb11d58a3e2b0694
          - use general label for Turkish dictionary
            
            to be consistent with labels for other dictionaries
            
            Change-Id: If01f9a9292fc15f3ff06f608b87273bc4e300e2f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/162946
            Reviewed-by: Kevin Suo <suokunlong@126.com>
            Tested-by: Kevin Suo <suokunlong@126.com>
            
2024-03-03  codewithvk  <vivek.javiya@collabora.com>  [8c3fa629f489fdd5ec73c9ec18010eeaf39955a4]

        Make Chart Object Properties Dialogs Async
        
        How to reproduce it:
        When double-clicking on a chart, it will now open the Chart Object Properties dialog box.
        
        Previously synchronous, this commit updates it to be asynchronous.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: I54c24e0cd30d6ec8b2bfa93567e830405d2fd30c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162576
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 748a5a01165d40e9bcaa7bfc75b0e6f74fc5a07d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-03  Marco Cecchetti  <marco.cecchetti@collabora.com>  [ab08825ec0588df2a7686da35ab7a98c58f6b28b]

        lok: calc: sheet position not restored on undo a tab insert/delete/move
        
        Change-Id: I34158b267727048e703cf895cbc8e20b81da4944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164166
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 46211c06f51f37eeaa61407c1e7681aeb7a9514f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164193
        (cherry picked from commit a0c9071c8f2e7d8aa255da21b5f6d85dbf5d34b5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164272
        Tested-by: Jenkins

2024-03-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [217d918491398f68b826d7fa031d4cb84c1da8db]

        Resolves: tdf#159879 Crash when closing "3D View" dialog
        
        Change-Id: I9c116007afe9cea97b597933ad8483dce25c3707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9db2778c16916fcb1348a494e12d72672eb5e085]

        Fix typo in code
        
        Change-Id: I3cb218403469ff17dfd2f955ecd0aaa14e7bccbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164296
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6524ec07b0ff311b1beac7a5b58df763052f2b91]

        Fix typo
        
        Change-Id: Ic279c6f88b99caa252872170b3c8bbd2047497ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164297
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [709866a3b8e073fab4937dcf91dcd33ff1d2bc13]

        tdf#99969: make sure to copy the chart source ranges to clipboard
        
        ... even when they are outside of the copied cell range. Otherwise,
        it is  impossible to transfer the missing data when switching to
        own data on paste.
        
        The copy of the missing ranges avoids copying cell attributes, for
        performance reasons, but also to avoid overwriting the attributes
        of already copied cells. Otherwise, ScDrawLayer::CopyToClip would
        need the bKeepScenarioFlags, or the CopyToClipContext used in the
        caller ScDocument::CopyToClip, for consistent copy; or a method to
        avoid overwriting already copied cells (this change simply copies
        all chart ranges, withiut checking if they were copied already).
        
        Change-Id: Id02e0c20517e7e8a17bb0a31d1b230196cda1a58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164294
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b0d9f3c417315eb704dc9ab906e9c24f59571942]

        Some minor embindtest clean up
        
        Change-Id: I4dd65567900658c23637a6a10823b67e93bad768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164182
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f70b99b4dd162df7a6a124ccd53f3814ff10b00]

        if the formatter was to change, then the cache should be dropped
        
        Change-Id: I98edea680f5300c4375168391627ac654ea3779c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2c3605405225de4b850064cf25b15cd64be1409b]

        avoid SvNumberFormatter lock in formula-group-threading
        
        keep a per-interpret-thread cache of the SvNumberFormatter
        mapping while formula-group-threading, this is similar to:
        
        commit c2d8341ee392949274b901abfd44d9645d2e4e36
        Date:   Tue Oct 15 08:32:22 2019 +0530
        
            Cache last used number-format-type in interpreter-context
        
        Change-Id: Ie99807eaf2f3260cec357f9d66307df0a69826e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [4f2704920c697e8a6f053de52439dbcd49a16ce3]

        Add a natvis for SvGUID / SvGlobalName
        
        Change-Id: Ided4d536d39de64b0c86d26fb11468a1dc7b0fb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164292
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Noel Grandin  <noelgrandin@gmail.com>  [06daf1719ef6dfb5b01d7ff09ce6df4c5c332cd5]

        avoid a memcpy when constructing output of tools::JsonWriter
        
        we can store the data in an rtl::OString object and then return
        that directly
        
        Change-Id: I65af6820bfd3135b38d437cf9736fffff8924e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f4fc510a28d11d63f6c91af6727292a53ca0517c]

        Simplify a bit
        
        Change-Id: Ie9cdeb533dbdf037390d08910494a4c1e5dcd1dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164208
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d8978a8c4ffabd6b36a691fd3e2df68563808234]

        tdf#116156 tdf#157162 tdf#159528 Fix glitches in officehelper.py
        
        - MacOs & GNU/Linux distributions are supported, next to Windows
        - Connection attempts are customisable
        - Reporting to console can be configured
        - Python source doc. added
        - service memory cleanup suggestion examples intended for QA as well as inclusion in wiki pages
        
        officehelper documentation:
        https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps#First_Contact
        
        Change-Id: I6a7c19429e78a1736e4a1479c4bbc1950228d93f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f7d3b846ccdc979ebb3dfbff21eabc9d17eb204a]

        Simplify a bit
        
        Change-Id: I13f12235e7f0646faf7a5cfe3c9b757491947365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164204
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da7867bbb98de03768f2212d9219023b6b854805]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53a1f8fb85cd85d38fbc3878bcdeb5452306c379
          - Typo
            
            Change-Id: Id8bdc2bf463a8ac736387f6ce2ac387c77d25e1f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164270
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [70874f70e40f1b86fcff587ab20f69e21e9c437e]

        Simplify a bit
        
        Change-Id: Id9895a3b6e8c09df12c9f9c3c83e1432aa5fff71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164203
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Regina Henschel  <rb.henschel@t-online.de>  [d8079e980e3e5947df9430089444a5f31e0c5de6]

        tdf#159912 extruded shapes already rotate background
        
        ... so do not rotate the background image again. But because of
        tdf#159515 the patch blocks extrusion for images that are imported as
        background fill of a custom shape. To test that the fix works, you need
        to change the code in shape.cxx. Remove the parameter bBlockExtrusion in
        call of setExtrusionProperties() method and comment out the definition
        of bBlockExtrusion variable.
        
        Because of the blocked extrusion a unit test for tdf#159912 is currently
        not possible.
        
        Find more details about the patch in comment 4 in the bug report.
        
        Change-Id: Ifa13988b18fbd5d63604ab0d0f3006e7ff480c02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164107
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [621e16205363c1eea0be57017997396dee63df4b]

        add UNLESS_MERGELIBS_MORE and use to reduce symbol visibility
        
        Change-Id: I2e6c2dcd06c76e0f5f68a1debde3a20665104b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164219
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Julien Nabet  <serval2412@yahoo.fr>  [09f19a4c06dc389fde11fc79cf3f912a5199ed48]

        Related tdf#158945: Calc: crash when entering text in a cell
        
        Fixed from driver version 0.405.1237
        
        Change-Id: Ib09bb7a3cb39f5774282b48512bfc6d7954dd4e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164186
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [68c6b970e45ac1971dd95c28a07063f38dc152e0]

        Simplify a bit
        
        Change-Id: I5022d82e556f7cfb09f0dee397d93dd7514a22e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164202
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a9bcd8a0c0afc4baa53570f7072e64b5ba72f89b]

        Simplify a bit
        
        Change-Id: I5909dfc0f19b13d53d370f78a5e2853b95f0c1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164201
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [9fb7fb6e47335913abbe26161a7f421d7c6224d7]

        Simplify a bit
        
        Change-Id: I8831eccc4e643c2f9618e6cf7e77f308e6abb540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Fridrich Štrba  <fridrich.strba@bluewin.ch>  [4267c7124876b9213b3169a55731d260c8c63f7c]

        Allow building with Java 8
        
        Change-Id: Ib1af1a98993aabb8a03f4ef19d8da4d9a71fdbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164226
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [1cd0d13e9bb0c30d0a472acd95da727c571d843b]

        add wpft* to --enable-mergedlibs=more
        
        Change-Id: I1168eb43638c3b18e3b9de96d89646420f80b52e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [065b1d030ea5e21dc91699cdaf8bcd03ed2ec807]

        add OGLTrans to --enable-mergedlibs=more
        
        Change-Id: I6df8cd8a11681cac971d53ec52b6dd97c18fd459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [19b7f833dd7aa4cb7eddb4ee9ccda202c8133bb8]

        add solver to --enable-mergedlibs=more
        
        Change-Id: Ib3de04a85332430895bb6096a2cfaf1463f33b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164216
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2083679b61623cfe1dbd71f486ff4f63f837db2d]

        add ado to --enable-mergedlibs=more
        
        Change-Id: I0d04eb2ab9b6384576194dc2c6421310da227b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [cde2bf606960b7bf0945b394a70e0e5c1a947ec0]

        Simplify removeMnemonicFromString
        
        Change-Id: I38ed29cb9c6296c364330c667fccf573d3d5cd5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164181
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f85d6a0edd509100af0c5f6b9249bcd0507be301]

        Drop unused variable
        
        Change-Id: I913c25e0ab4fb593e6d85805ed677dbe4db94c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-02  Marco Cecchetti  <marco.cecchetti@collabora.com>  [fc9c15ec702d8a06e8747ee5b858751e5a90e30a]

        lok: calc: sheet geometry not updated on undo a tab insert/delete/move
        
        Change-Id: I1e12ca71771e746155afe48215ba2df4b35634d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164165
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 86e6d67220d6d3d93c5decf04195b7f5025984ae)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164192
        (cherry picked from commit fe0b935313b28003117a2d219fd2fe359947a11e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164199
        Tested-by: Jenkins

2024-03-02  Dione Maddern  <dionemaddern@gmail.com>  [e137d43a1a42dd63d784b45929a6ccb1b5b48c6e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0b58cd7c6b04583935d6a25f28ec514c1e6424ba
          - tdf#148859 Fix link to Outline Bar help page
            
            Add HID bookmark so that pressing F1 opens the correct help page for View > Toolbars > Outline
            
            Change-Id: Ia9a7af6e01e7a71ceff0f35adcee4285228edf28
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164196
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [14ca02e58ede263e3cfafd172e164b7fc27dda45]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 714426188f79633f1f6e4f180c13aafda4fa4a4b
          - tdf#94535 Corresponding Help page
            
            Change-Id: Ic73d515a570fb0a8ae9e03f9d732c733715d71e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164230
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [88ce6625a03d33d714a2e26d9c41a7fa15b363a5]

        Fix nIndex / nLen passed to mpAlphaVDev->DrawCtrlText
        
        The corrected values along with original text make no sense
        
        Change-Id: Id84728e7d23d8780c4e7b7a76091470a82206efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164184
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [4d39b88283d02eb44fe4cb8f3e4ec153ebf96a13]

        tdf#159976: make sure to always strip mnemonics in DrawCtrlText
        
        Note how GetCtrlTextWidth does that unconditionally.
        
        Also unify the code paths for disabled vs. enabled controls; this
        makes DrawText also use pGlyphs for disabled controls, similar to
        what was implemented for enabled controls in commit
        d70bf1c4caf37f38166b5f1facc08264cd203f92 (vcl: less text layout
        calls in Menu, 2018-09-05).
        
        Change-Id: I8fb6686012fb218dd4ae5536ad1cfeb69471e741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164180
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-03-01  Marco Cecchetti  <marco.cecchetti@collabora.com>  [49aead6a7ff3933c127efe0f230a2630caa8f342]

        lok: calc: tiles not invalidated on tab move
        
        This patch fixes a regression started from
        9f3ee2b2 "don't invalidate when switching tabs"
        
        Change-Id: Icd560c73cff836b026b1ba69432bb712e36c035a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164164
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit cf4630887adcf3e9d8b7a2452f097bb2f564fc5c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164190
        Tested-by: Jenkins

2024-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [a661f9a2e0a05de1705a8e9d930c148a1416be29]

        tdf#159968: Support overflow:visible in marker element
        
        Change-Id: I4ea648cf94a4bb321a78843a9898769a69c5630d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164224
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-01  Pranam Lashkari  <lpranam@collabora.com>  [948cd8b9f62e28883b691084a9bb83177422defd]

        LOK: send inner text boundry information of shapes/textbox
        
        Sends inner rectangle boundry info as part of LOK_CALLBACK_GRAPHIC_SELECTION message
        
        Change-Id: Idc51e807bec01711c8a4326e3193127f0b2cd765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-01  Justin Luth  <jluth@mail.com>  [de5816806589c6e6d1da11f50f9ceeb6f50dc3ef]

        fix build: UITest_impress_tests (re-enable date-time test)
        
        accidental debugging change got mixed into a patch...
        
        This reverts part of commit 99e33129346afeb0a386ffad859a9178290211a6
        which shows I clearly failed to follow my normal practise of
        properly reviewing the change in gerrit before submitting.
        
        Change-Id: Iaa1d9a0eaa4f12c8a5786a29887a82b193baac38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164223
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-03-01  Julien Nabet  <serval2412@yahoo.fr>  [4e060f854cd175ff7ef8f3c2dd3f0dbf5cc48ad2]

        tdf#159955: fix custom page number
        
        Change-Id: I1a56a4ba266dfb3c21e3b77263ecaa44b4e6dad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164210
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-03-01  Miklos Vajna  <vmiklos@collabora.com>  [b570bba64d688a906c51455e5bbda854f9eb8b7c]

        sc lok: make the formula separator warning dialog async
        
        I'm not sure what exactly changed here, but recently online.git
        unit-wopi-languages started to fail for me. First it was an assertion
        failure:
        
        /home/vmiklos/git/libreoffice/core/vcl/source/window/window.cxx:3186: void vcl::Window::SetLOKNotifier(const vcl::ILibreOfficeKitNotifier*, bool): Assertion `pNotifier' failed.
        
        Once ScDocShell::CheckConfigOptions() is changed to pass in the view
        shell explicitly, the next error is:
        
        kit-26201-26149 2024-02-28 10:41:31.659255 +0100 [ kitbroker_002 ] ERR  non-async dialog triggered
        
        So convert it to async, similar to the chart2/ hunk of commit
        4b33e878a446b0bcdb1d5f882a05a256967eea54 (Make format condition, chart
        delete and pivot table error async, 2024-01-10).
        
        Change-Id: I159278b24db0acd5fddb6f4d29dae9a35321e614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164178
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-03-01  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b0791dd9216224bdb266fd0d8c87df253b6d0583]

        tdf#126573 Add Excel2021 array function FILTER to Calc
        
        https://issues.oasis-open.org/browse/OFFICE-4156
        
        TODO: add dynamic arrays would be useful: Older array formulas,
        known as legacy array formulas, always return a fixed-size result
        - they always spill into the same number of cells. The spilling behavior
        described in this topic does not apply to legacy array formulas.
        
        More info about it:
        https://support.microsoft.com/en-gb/office/dynamic-array-formulas-and-spilled-array-behavior-205c6b06-03ba-4151-89a1-87a7eb36e531
        
        Related Bug: https://bugs.documentfoundation.org/show_bug.cgi?id=127808
        
        Change-Id: I1c3769ef33fa0207f55e1c96083717c2d90402e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163955
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3d4328e6a0c7b9792883c3b3d49ea5468e9898f]

        Revert "Unit test to tdf159797"
        
        This reverts commit 173a79365b110cf70f628a602a22049562a477f5.
        
        Reason for revert: This is already covered in 66b30842e86fb6041bd6a453c6e3a877a3c177c1 with a CppUnittest, which is
        preferable to UItests
        
        Change-Id: I80ddb4f3d1da047e0c994fd3137a78ab70081edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164191
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [f0225de07ecac797cd7ceaf9edb7e1c36d1afc70]

        svgio: simplify a bit
        
        By default, preserveAspectRatio is already xMidYMid meet
        
        Change-Id: I37d85979728e9382c9b21b3219f3ad79eeec536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164188
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [16d08e49a304fdc1bc046c51c860dd63b6e7fe0d]

        disable failing tdf159927_dateTime.py uitest
        
        Change-Id: Ib1a1209b6bad188f9b045b499906d385ade66787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164220
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [15df1df235cbe199d770d67a03fe923c94aa2dcc]

        add accessibility to --enable-mergedlibs=more
        
        Also
        (*) fix the definition of ENABLE_MERGELIBS_MORE in configure.ac
        (*) Remove the dummy accessible factory in vcl, it creates
        more problems than it solves, because code will break when
        trying to use it, and then I get crashes far removed from the
        source of the problem (failure to find the acc factory).
        
        Change-Id: I969481d5ad2cfd7104d8240fdd0dce9d285fdb61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164176
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [37bc6ca4bbdfa355440183f54e9fe35e8d23cae2]

        fix ODR violation
        
        which causes a segfault in CppunitTest_hwpfilter_test_hwpfilter when
        building with --enable-mergelibs=more
        
        Change-Id: I4310060e28ee092bf7831d5dfd71e98ad3724bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164177
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4ed91fc7214b08112bc73844db3bdaab69f73564]

        tdf#94535 Improvements in Text along Path dialog
        
        Added labels to indicate the purpose of the toolbars.
        The dialog needs Close and Help buttons and will be considered later.
        
        Change-Id: I1926c05ebc386877007163bdea0809efe0442103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162056
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2024-03-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [716c1c3c973f2b171efb8eca31498a29364b4548]

        tdf#94535 Change "Fontwork" to "Text along Path"
        
        + Applied to Draw and Impress format menu
        + Applied to Curve context menu
        + Connected to tdf#118336 Help page.
        
        Change-Id: Ibb5d2edf7f5baccf49852b62008aed1c89409f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162047
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-03-01  Oliver Specht  <oliver.specht@cib.de>  [aebdc79dbc5bf059ee0921a00d2795e526a52c42]

        tdf#146356 insert new paragraph before table of contents
        
        Alt+Enter inserts the new paragraph before the content section
        of a table of contents.
        At the same time protected indexes now also have the header
        protected.
        
        Change-Id: Iff267691d96796158c1593c4269b76226840c952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164050
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-01  Oliver Specht  <oliver.specht@cib.de>  [173a79365b110cf70f628a602a22049562a477f5]

        Unit test to tdf159797
        
        checks replacement of dash to endash after sentence
        
        Change-Id: I61843825faaf212eb5560797f1b6a2fdad5efce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164086
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4edcd840aef4d1b594beecb44a0edbc0cdf5e5aa]

        set default if no ViewShell yet
        
        Change-Id: Ib6381ec963a9dc641d880eef1f9a3e556100a98e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bc08b1fbbd00c6e4b086f6d95249e684ace6ae25]

        scope of MutexGuard can be reduced
        
        These are just locals, except for IniLnge which is set once in the
        ctor and is then immutable
        
        Change-Id: I0d8ac0c3ca729003a3575dea39b2746dfc53b4bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-03-01  Michael Stahl  <michael.stahl@allotropia.de>  [25c2b4c4505060bbf207ed82036a63fee97a3689]

        sw: deliver promised punishment via assert()
        
        Change-Id: I57c3ead622c3f64c5b2f007309987e60249b079b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164157
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-01  Michael Stahl  <michael.stahl@allotropia.de>  [d0cd421833d85e8137688533dfc921e0add89dff]

        remove accidentally committed debug comment
        
        Change-Id: If0e445ff6b8ea2308aa14e2b60f32914ca1b795f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164156
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-03-01  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [806362b915ee89a4f907905a8ac8c1527ea99223]

        Update the reference rdbs to libreoffice-24.2.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-24.2.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-24.2.0.3/instdir/program/types.rdb \
         .../libreoffice-24.2.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I276ea47ae755a2ce641eef3f508ce1dc5f6af4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164162
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-03-01  Noel Grandin  <noelgrandin@gmail.com>  [38ec9348eeea29611c1c7ebc626f88474b850ebc]

        remove mergelibs warning from configure
        
        It is now known working on Linux/macOS/Windows
        
        Change-Id: Ib529a002a88cc94798a6707af7319ce9e25aca48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164169
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-03-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [78065e3798439dd790d1be5ac5c219477285c888]

        tdf#83720 Pivot Table: Data field should always at last place
        
        In the pivot table dialog we should always put the "Data" field to
        the last place or the cell formats won't be shown correct in the
        pivot table.
        
        Change-Id: If4befe4fff1e6f04d9b709615a1955e3b5f4b4cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164161
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-03-01  Justin Luth  <justin.luth@collabora.com>  [99e33129346afeb0a386ffad859a9178290211a6]

        NFC writerfilter GraphicImport: streamline if statement
        
        The function is a const static, so it doesn't require being run.
        
        Change-Id: I31fb35e9daf54103071197e669c54818d4062264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164172
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-01  Justin Luth  <justin.luth@collabora.com>  [c4c5937a98572630915de497b3138164b12079e3]

        tdf#159158 writerfilter: headers always behind text (!opaque)
        
        If the body-anchored thing is in the background,
        then if any header stuff was NOT in the background,
        then it would show up above the body thing,
        and that should not happen in a DOCX world.
        
        This test was not easy to produce.
        ODT kind of knows that headers are special,
        and so it tries really hard to put stuff in the background
        without any wrap - at least after a round-trip.
        
        So I had to hand-craft from my example DOCX
        that exhibited a behindDoc which actually
        had some wrapping component to it.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_headerBehind2
        
        Change-Id: I31617cd7bf2d38add2233a7a06ffe9a8ec00ec0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164130
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-01  Justin Luth  <justin.luth@collabora.com>  [9aa7dc185af99a540926cc699193449177050386]

        tdf#159158 writerfilter: headers always under other z-orders
        
        I guessed that a negative z-order will be below
        a positive relativeHeight when it is in the header.
        It seems like a reasonable assumption.
        No unit tests hit this situation AFAIK.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_headerBehind
        
        Change-Id: I06e31f3df413ad9c32791c8f4b940831630131dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164105
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-01  Justin Luth  <justin.luth@collabora.com>  [027632ec97ad556606997254244c76c7474d9122]

        NFC prepwork for tdf#159158: flatten writerfilter applyZOrder
        
        limit code shuffle in the fix itself
        
        Change-Id: Ic506ac700403fa434dd6410e9ea566c6d0e19676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164154
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-03-01  Jim Raykowski  <raykowj@gmail.com>  [0daeee1a7d0e530f1cce40f86a26ed01f07ee7da]

        tdf#159837 Drop unneeded TabBar EventNotify KEYINPUT handling code
        
        to make qt and windows VCL backends respond to shortcuts when the
        keyboard focus is on a TabBar tab.
        
        commit 51f8e04eaaea50b779e3882e87628a6e625e0fd8 done to make the
        Shift+Ctrl+F10 short cut, used to dock/undock the sidebar, work from
        the sidebar tabbar appears no longer necessary. Simply passing the
        KEYINPUT event on to InterimItemWindow::EventNotify seems to be
        enough.
        
        Change-Id: Idfa8be4260d31e686acf1b49e89549deb9463a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164051
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [e3fdafaabc198054255fa7c5c34b6beed6915b3b]

        IASS: Update edited Text in other Views
        
        This was not working for multiple Windows for
        a document, and also not supported for SlideShow
        until now.
        
        If you edit a Text on a Slide (Object, PresObj,
        ...) that text is not yet set at the Model until
        the TextEdit ends. In that situation those changes
        are now propagated to other views visualizing that
        object. This is done with slight slowdown to not
        do it all the time while typing, (currently 350ms,
        grepped from other places in the office).
        
        It will be shown in a running open SlideShow (and
        evtl. trigger an effect at the Object as Preview).
        This will allow to get a good preview for how it
        looks in the SlideShow.
        
        This is also done for further EditViews opened
        for that Document. This was not done before. It
        is fine-tuned to do this only for the Views besides
        the EditView with the running TextEdit to not
        cause slowdowns in that active view - the TextEdit
        is already running on the Overlay to have no
        problems with speed, this needs to be preserved.
        
        I had to fix a multi-view error in the a11y stack
        that implied that only one view exists and thus
        has to have an Outliner - that is wrong for
        multiple views, only one will have one.
        
        Change-Id: I781d32a8fcb8732ee8fcfbae72c02d1f99b6cd06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164160
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-29  Henry Castro  <hcastro@collabora.com>  [c6d9cc16dbb5fe0d05ce8ca9c4c18b989596e928]

        svx: fix default locale language string
        
        1) Open a spreadsheet
        2) Format a cell with a currency. Example USD $ English (USA)
        3) Open the sidebar if it's not opened already
        4) Click in the currency dropdown
        5) Observe: there is $ (Default)
        
        Expected result: USD $ English (USA) Default
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Idf7f4174557e59cb6f5ffd65c25572322a5794ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164123
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f06b252e187c08ed8a5afe138aecdf5d9ab1729]

        add writerfilter to --enable-mergedlibs=more
        
        Change-Id: I5b04b5e4a1023fc4da61bdcf148829f899e501d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164152
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f810031131b761975a6fdefb8be06cc3ff6ea94]

        add cui to --enable-mergedlibs=more
        
        Change-Id: I124b60d91491b4fecc8c564728f4d36c23845a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164151
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [c73f3491bedafef884196c761d8f3d89f4dcff75]

        tdf#159947: Add support for in and result filter attributes
        
        Change-Id: I8bc7e319a64c528893de8454c64545146ad4e9d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164108
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1245614991654b9d3ddb15f644a689585fd4c9de]

        IniLnge is set during ctor and never changes subsequently
        
        Change-Id: Ie052e32976d9810555c8f1892dab47a7472cdc71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164149
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [91c37cdc9d779c6f1c956ffc78a688f08e6735d7]

        tdf#159938: sc_uicalc2: Add unittest
        
        Change-Id: Ib5bd28cf2d449924425e06bb22437af522443ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164145
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f7cb2b7474d877af61ab00f6635aec5cefa3d78]

        use member init list
        
        Change-Id: I09dea90e3e3f3fd0a4047b989329a027f788f695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9fcee419dd368823d842b9c9a032b2213ee24d34]

        if we rearrange, we don't need to create maLanguageTag twice
        
        Change-Id: I2c8ad9999adc406dc850c59b48e49681099dc054
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164147
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [023e59d0283614a568362b794bb94a9254401d7e]

        there is only the one ctor, so drop misleading "preferred" comment
        
        that suggests there are alternatives to choose from
        
        Change-Id: Ica3367fae93f57f339bdc39b1cd91d47a2c9618e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164146
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [41feb036b44ffefca898f44ed95a2129d779da59]

        Some minimal Embind support for UNO type
        
        ...which should be rare enough in practical use that it should be sufficient to
        only have toString-functionality for instances mapped from C++ to JS, but no
        constructor for new instances on the JS side.  (The natural choice for the
        latter would be a mapping of the C++
        
        >     inline Type( TypeClass eTypeClass, const ::rtl::OUString & rTypeName );
        
        constructor, but which requires a mapping for the css::uno::TypeClass UNOIDL
        enum, which is only provided "later" through CustomTarget_static/unoembind, so
        would at least conceptually be a bit dirty.)
        
        This Embind mapping treats css::uno::Type as a smart pointer for the underlying
        typelib_TypeDescriptionReference, to benefit from the fallback garbage
        collection (in more recent Emscripten versions, at least) for smart pointers,
        obviating the need to call .delete() on each instance mapped to JS.
        
        Change-Id: Ic113967c264c28641dfd1fe159012c85519f4a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164140
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6588c30ed4477627b2623560ca867682b189bc80]

        vcl: separate scanline direction from ScanlineFormat
        
        ScanlineFormat enum is used to indicate 2 things - scanline format
        type and scanline direction (TopDown or BottomUp). This makes it
        complex to manipulate with (using bit arithmetics) and hard to use
        in general for no benefit, so this commit separates direction out
        from the ScanlineFormat into ScanlineDirection enum. ScanlineFormat
        is now just a simple enum class (not a bit field).
        
        Change-Id: Iad55d0a4c8c07b71221c2facf7cf6a2d518fec0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163943
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [657631791421eae2c88a89da27bd2c0dc1822175]

        SvNumberFormatter::ImpConstruct is only used once by the single ctor
        
        so fold it into the ctor
        
        Change-Id: If063143ef47a8ab293edf3896fb51079d0e0284f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164144
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0956dda717473eb7ac0d0936ce457e66301ab400]

        cid#1169880 Uninitialized scalar field
        
        Change-Id: I0ac1cc740f8d559cf8fa7b69947b6f152eae807a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164138
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [1af510e95147374e5289ae1c12f1f280931919f4]

        Create an UNO service to do the symbol lookup in toolkit::AccessibilityClient
        
        which means I can remove one usage of gb_Library_set_plugin_for, which is blocking linking the accessibility module into --enable-mergelibs=more
        
        Change-Id: I8664ae1d2da4526cc7eab79b36e1589eb391d7c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163680
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Gülşah Köse  <gulsah.kose@collabora.com>  [b1f84f5479a8ed06d07d4eef6b83578789fd67f0]

        Online: Make tooltip message specific to function usage tooltip
        
        Using same callback caused a regression about showing tooltip while
        reviewing a change in writer. So we need a type to understand which
        tooltip comes.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Iae26ff48f9c5c711af071fd66b5314e7bc96ff8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164093
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [676f4e67493f4fec0004a925da675c0912b0637b]

        cid#1592640 Dereference after null check
        
        also possibly could be
        if (mpDocSh && !maPresSettings.mbInteractive)
        
        Change-Id: If68df161f4f7e72d6598469e398c3a8b44e1eba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f1a47d476a6d993121a4b1c8ee405c20cd808820]

        Improve sample code, missing delete()
        
        Change-Id: I26ddbfb8b6742d816290d122d22c3c6c3ceabcc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164143
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [e66f5cb353bc0ea1020061bab4981380f98499b9]

        tdf#159420: Show empty option even if empty is filtered out
        
        in other columns
        
        Regression from 89e032e9c4c51f52680c7d8bacf59ab2a34f2180
        "tdf#158314: show Empty and Error entries as non-selected and inactive...
        ...when hidden by autofilter."
        
        The mbHasEmpties variable was added in
        9c1826d98065c30411cbf2e731560165ca2b7668
        "sc-perf: do not add a million empty filter entries just to sort and
        discard"
        
        Change-Id: Ie0d81fd57f68038fac62cb6a3442e93ed547167a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162752
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2024-02-29  Mike Kaganski  <mike.kaganski@collabora.com>  [18a5df49938132ac6605b3fdd1f023b85f7ac31b]

        Restore a comment
        
        Mistakenly removed in commit c2dca161c0ed455a962d23f8e2fcb64143c5e674
        (Use <bit> instead of platform-specific intrinsics, 2024-02-29)
        
        Change-Id: I6091a767aebcbb2543656cee2c27330fb6f9d16b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164141
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Michael Weghorn  <m.weghorn@posteo.de>  [1b6963cda0a209548249dd43c5c1fa705ef32bcd]

        tdf#158030 qt a11y: Implement new QAccessibleAttributesInterface
        
        Implement the new `QAccessibleAttributesInterface`
        just added upstream to Qt in qtbase commit [1]
        
            commit fb5ffe862688a87cfc136113e067bcba0c49a7ae
            Author:     Michael Weghorn <m.weghorn@posteo.de>
            AuthorDate: Fri Nov 10 18:25:02 2023 +0100
            Commit:     Volker Hilsheimer <volker.hilsheimer@qt.io>
            CommitDate: Thu Feb 29 04:44:22 2024 +0000
        
                a11y: Add new QAccessibleAttributesInterface
        
        , see also QTBUG-119057. [2]
        This API is available with Qt >= 6.8.
        
        That interface makes it possible to report
        object attributes that are bridged to the platform a11y
        layers.
        Use it to bridge the attributes retrieved from
        the `XAccessibleExtendedAttributes` UNO interface.
        
        Together with the pending upstream qtbase change that
        implements the AT-SPI bridge for Linux [3], the "level"
        AT-SPI object attribute for headings in Writer
        is correctly reported to AT-SPI, making the
        Orca screen reader announce "Heading level N" as expected.
        
        For now, map not explicitly handled attributes
        as key-value pairs to Qt via the special
        `QAccessible::Attribute::Custom` attribute,
        which causes them to be mapped to AT-SPI unchanged, and
        can e.g. be used for testing the tdf#158030 scenario.
        
        For common attributes - like those specified in the
        Core Accessibility API Mappings specification [4] -
        suggesting to add new enum values to the
        `QAccessible::Attribute` enum to upstream Qt
        and using those instead should be considered for the future.
        
        Related commit for gtk4:
        
            commit 3aca2d9776a871f15009a1aa70628ba3a03ee147
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Nov 9 15:31:57 2023 +0100
        
                gtk4 a11y: Handle the "level" object attribute
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=fb5ffe862688a87cfc136113e067bcba0c49a7ae
        [2] https://bugreports.qt.io/browse/QTBUG-119057
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/517526
        [4] https://www.w3.org/TR/core-aam-1.2/
        
        Change-Id: Ibe357bfd72bb2dc6e44ad941e62737d5cac21e1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159309
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [3432dec53cfa6409dffebfdd67ce663362c71115]

        tdf#159847 Fix "Duplicate Sheet" when two files have the same name
        
        Prior to this fix, if two files were opened and had the same file name (but in a different directory), Calc might not create the duplicate sheet in the correct file.
        
        Change-Id: I7cdbdd2f3dae6752a3b78bbdcb74fbecb5b24b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163763
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Miklos Vajna  <vmiklos@collabora.com>  [186de7178c6065e1de13fd216b46ac9b716e44c5]

        tdf#158801 sw floattable: fix crash with headers and interactive editing
        
        Regression from commit ce2fc5eb29b4e252993b549dee002fa8948c8386
        (tdf#158341 sw floattable: fix layout loop when fly is below the body
        frame, 2023-11-29), open the bugdoc, add an empty paragraph at the
        start, Writer layout crashes. The immediate problem is that
        SwTabFrame::MakeAll() assumes that in case HasFollowFlowLine() is true,
        then GetFollow()->GetFirstNonHeadlineRow() is always non-nullptr,
        similar to the situation in commit
        223d2fac61e061478721a7a4a89b1362f5037d8f (sw floattable: fix crash by
        trying harder to split tables, 2023-11-22).
        
        The deeper problem is that the bugdoc has a repeated table header row,
        the fly frame temporarily gets shifted down, so nominally the header
        doesn't fit anymore, and this leads to a modification of the doc model,
        which creates inconsistency: the model now says we have no header rows
        but the layout still contains table row frames where the header bit is
        true. This is problematic in theory, but in practice caused no problem
        so far.
        
        Fix the problem by disabling this mechanism for floating tables: trying
        to have a table header that doesn't fit the table is asking for trouble
        anyway, and this way at least we have a layout that is consistent with
        the model, which also avoids the crash, now that nobody violates the
        "HasFollowFlowLine -> follow's FirstNonHeadlineRow != nullptr"
        invariant.
        
        Also extend the layout dump, so it's easier to see when the master's
        flag and the follow's row list gets out of sync.
        
        Change-Id: I52b51f6d86ab4e0bab560f892e9cceb183aecd5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164136
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-29  Miklos Vajna  <vmiklos@collabora.com>  [62f71496c9faf071ba838df1e5d0d7b1465ab839]

        CppunitTest_sw_tiledrendering2: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything.
        
        Change-Id: Ia3a58220b772c4a68ca86dff01fae7e693b48fca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164137
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [acce5d17ac7f5d8c92e5f75a5757ac449692e2fa]

        Read of uninitialized Printer::mbResetPrintArea
        
        ...introduced in 364f0bb1cac0e12f5f926857f61c2f329a353ec7 "tdf#155218 sc: fix
        regression page orientation in print dialog", causing UITest_calc_dialogs to
        fail with
        
        > /include/vcl/print.hxx:227:61: runtime error: load of value 190, which is not a valid value for type 'bool'
        >     #0 0x7f1337c5ec9e in Printer::IsPrintAreaReset() /include/vcl/print.hxx:227:61
        >     #1 0x7f1337bd64be in ScModelObj::getRendererCount(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sc/source/ui/unoobj/docuno.cxx:1856:41
        >     #2 0x7f13ca466d5f in SfxPrinterController::getPageCount() const /sfx2/source/view/viewprn.cxx:228:36
        >     #3 0x7f13a130580e in Printer::PreparePrintJob(std::shared_ptr<vcl::PrinterController>, JobSetup const&) /vcl/source/gdi/print3.cxx:420:53
        >     #4 0x7f13a13027e3 in Printer::ImplPrintJob(std::shared_ptr<vcl::PrinterController> const&, JobSetup const&) /vcl/source/gdi/print3.cxx:575:9
        >     #5 0x7f13a134cdc8 in (anonymous namespace)::PrintJobAsync::ExecJob(void*) /vcl/source/gdi/print3.cxx:318:5
        >     #6 0x7f13a1302b28 in (anonymous namespace)::PrintJobAsync::LinkStubExecJob(void*, void*) /vcl/source/gdi/print3.cxx:316:1
        >     #7 0x7f139f592d0d in Link<void*, void>::Call(void*) const /include/tools/link.hxx:111:45
        >     #8 0x7f139f579a00 in ImplHandleUserEvent(ImplSVEvent*) /vcl/source/window/winproc.cxx:2287:30
        >     #9 0x7f139f5646c0 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) /vcl/source/window/winproc.cxx:2851:13
        >     #10 0x7f13a3273a82 in SalFrame::CallCallback(SalEvent, void const*) const /vcl/inc/salframe.hxx:310:29
        >     #11 0x7f13a3320ea1 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) /vcl/headless/svpinst.cxx:266:22
        >     #12 0x7f13a3321632 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) /vcl/headless/svpinst.cxx
        >     #13 0x7f13a1b7e593 in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const /vcl/source/app/salusereventlist.cxx:119:58
        >     #14 0x7f13a1b7dd25 in SalUserEventList::DispatchUserEvents(bool) /vcl/source/app/salusereventlist.cxx:120:13
        >     #15 0x7f13a3325345 in SvpSalInstance::ImplYield(bool, bool) /vcl/headless/svpinst.cxx:395:22
        >     #16 0x7f13a3327b4e in SvpSalInstance::DoYield(bool, bool) /vcl/headless/svpinst.cxx:471:21
        >     #17 0x7f13a2012c4a in ImplYield(bool, bool) /vcl/source/app/svapp.cxx:390:48
        >     #18 0x7f13a20112b8 in Application::Yield() /vcl/source/app/svapp.cxx:474:5
        >     #19 0x7f13a2010b57 in Application::Execute() /vcl/source/app/svapp.cxx:368:13
        >     #20 0x7f13e355d421 in desktop::Desktop::Main() /desktop/source/app/app.cxx:1614:13
        >     #21 0x7f13a20b6ae2 in ImplSVMain() /vcl/source/app/svmain.cxx:229:35
        >     #22 0x7f13a20bfd20 in SVMain() /vcl/source/app/svmain.cxx:261:12
        >     #23 0x7f13e376dc40 in soffice_main /desktop/source/app/sofficemain.cxx:94:12
        >     #24 0x4fda3c in sal_main /desktop/source/app/main.c:51:15
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3090/>)
        
        Change-Id: Ibf9ed98b133337457e983155b960dfc40f84c819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164135
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [792b4b676b28d1108114cd311e20f62633998673]

        Try to appease Flathub linter
        
        ...which caused a recent
        <https://buildbot.flathub.org/#/builders/33/builds/12708> test build to fail
        with
        
        > {
        >     "errors": [
        >         "appstream-failed-validation"
        >     ],
        >     "warnings": [
        >         "appstream-screenshot-missing-caption"
        >     ],
        >     "appstream": [
        >         "E: org.libreoffice.LibreOffice.desktop:~: desktop-app-launchable-omitted"
        >     ],
        >     "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
        > }
        
        Change-Id: I3655d3985c70780e5980bec2d4753120fb302f1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164134
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ecf1c5aceec1cf93e00f4caf94d06e78f678278]

        move inline spelling setting out of document and into viewshell
        
        like what writer does, so one view of a document can have spelling
        enabled and another disabled
        
        Change-Id: I9eae02fd1a2def56bfa9399860e416180fc178c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163874
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a8a2c49d1984447297085824b593039908498fe5]

        sc: use emplace_back instead of a temporary object and push_back
        
        Change-Id: I5913d760fcfa45eb5162fecf25efa68bc17dcbcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164037
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [cf776a6fa697924deb7df5c0561e12bbd7cda16a]

        tdf#113050 sdext.pdfimport: Enable tilingPatternFill
        
        Now we've got everything wired up, turn it on.
        
        Change-Id: I2333e5163493ef0312619f54d2f90ae266fc655b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [81fbaf4bb9ddc385d4452257d731e4097dfed079]

        tdf#113050 sdext.pdfimport: Set and write TileWidth/Height
        
        Set the tile width/height from the step size and write it into the
        draw:fill-image-width/height properties.
        
        Change-Id: I70d69a6d5e77929bd14282731dd68d3bcafa9c1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [784696e47c7f28dac111b95e61f06a9a1f7cdc97]

        tdf#113050 sdext.pdfimport: Add TileWidth and TileHeight fields
        
        We need to scale the tiled image that fills our polygon, so add
        width and height fields, we'll fill in and process them in subsequent
        patches.
        
        Change-Id: Ib0000066170ccbc0f4a4c971e1d6df72c3f7df14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [4b295b1b77b33c9a5b5fcfab58132ca0dcb7f90b]

        tdf#113050 sdext.pdfimport: Create the fill-image style and use it
        
        In a poly which is being image filled, we need to create a style
        with the actual image definition in the 'Contents'
        and then set the (automatically created) name of this in
        the prop on the main style.
        Also we need to set draw:fill to "bitmap" rather than "solid"
        
        Change-Id: I253704519011e98fd106331ccfb139ad93ef6dee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [9f21f816a16914e06ff141a800a63f0966e387b2]

        tdf#113050 sdext.pdfimport: Expose the ImageContainer const
        
        I need the finalisers to be able to read an image, they have
        a ref to the processor but not the emitter; so allow the container
        to be read via the processor reference.
        
        Change-Id: Ifd3b2af1d456561ad42ae3e7c664f03b2e0c971c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [2bf5664823e7ef71d917fe95a2c3d92e46d77c32]

        tdf#113050 sdext.pdfimport: Add FillImage field to PolyPolyElement
        
        Use -1 to mean the existing solid fill, otherwise it's the ID
        of the image to use as the fill.
        
        Change-Id: I596c26145f5285f75af631a3bb7ddf09600982a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [d7e5eae44e18ab89e85a0e6ed633853ede70ec71]

        tdf#113050 sdext.pdfimport: Add ImageContainer::asBase64EncodedString'
        
        For fill-images we need the image as a string.
        
        Change-Id: I4a8429563b0e19ad977b4e933a0ffee378dab244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [ff160e93d32c62e09b28393979b3535e01057cdc]

        tdf#113050 sdext.pdfimport: In styles wrap 'Contents'
        
        For draw:fill-image we need output like:
        
        <draw:fill-image draw:name="foo">
          <office:binary-data>Base64stuff
          </office:binary-data>
        </draw:fill-image
        
        Style's 'Contents' entry, almost does that and is currently
        unused; but it doesn't put the tags in.   Adding the tags
        manually in the Contents string doesn't work (because it bypasses
        something in the Emitter?).
        
        Since it's not currently used, add the office:binary-data
        tags for our use.
        
        Change-Id: Idaf11b49bd075bb82116a0578bb4c38790dd0fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [bc5bd022a9ea8128bd5e9ba02bda48332dccbbe4]

        tdf#113050 sdext.pdfimport: In styles Specialise draw:fill-image
        
        Like stroke-dash, draw:fill-image needs the name setting in
        the draw:name attribute.
        
        Change-Id: Ib9c888765af8bfb0849f0f1ef15f9774808a1661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [2350357d5cc2ac1787816ce887af6e9f36b8d252]

        tdf#113050 sdext.pdfimport: Create poly for tiling pattern
        
        Create a poly for the tiling pattern fill.
        
        Change-Id: Iaeadfe51bed6d4de87f36b3a78145829ea8443e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [4a13e1890e8a0ed81e8fb17009185fa2b15ebff7]

        tdf#113050 sdext.pdfimport: Plumb tiling pattern fill to pdfiprocessor
        
        Change-Id: I68459834fd903d31c9b2e57d637265dd67da4f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [ec0b9062dc8dba82509183eb865da55827bde4d5]

        tdf#113050 sdext.pdfimport Tiling pattern fill parser
        
        Add a parser for the TilingPatternFill entry from the poppler wrapper.
        
        This doesn't get triggered yet until the wrapper enables the
        tilingPatternFill.
        
        Change-Id: I34ab84ba1ab9d6773f33d667b324bef5d6c6e409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [b7a63d26466bac7eb7b25233a5a53788bed88c81]

        tdf#113050 sdext.pdfimport: Flip bitmap
        
        We need to flip the bitmap between the wrapper and LO, but there's no
        easy way to do this in a Poly image fill in LO, so do it as a simple
        bitmap flip in the wrapper.
        
        Change-Id: Ifd84d37926c21edf30654d3884be975849a6dca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163563
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [8ac5f40b330c6cd248073b8686c05f566ecd7195]

        tdf#113050 sdext.pdfimport: Write the tiling pattern image
        
        Render the tile down to a common format using Splash
        and write it to the stream.
        
        Change-Id: Iccc451d1a02ed2ad77538883ab3fe5542fc633e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163562
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [8e4a351f12d777ad9102086298741d0a97e5eeb9]

        tdf#113050 sdext.pdfimport: Write the tiling pattern header
        
        Add the 'tilingPatternFill' hook to our output device, but don't enable
        it yet; we can do that at the end of the series.
        
        Change-Id: Id52b023c3025f5addce1ab09663da9b8bd8a75e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Dr. David Alan Gilbert  <dave@treblig.org>  [18a1c3d6c98348d4e3da6e6c9740d6923ab2fba1]

        tdf#113050 poppler: Enable splash
        
        Enable the splash module, to be used in the xpdf conversion
        for tiled patterns.
        
        I've jumped through a couple of hoops to avoid splash
        bringing in freetype, extending the existing hack.
        This might cause us problems if someone tries to use
        text as a tile, but otherwise isOK.
        
        Change-Id: I76ad1268f44137ae5e3205d56170c3a7c55a2dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Keldin Maldonado (KNM)  <kemaldonado@csumb.edu>  [c78679b349573d718f8641071928d5f2edb47efa]

        tdf#147021 replace SAL_N_ELEMENTS() with std::size()
        
        Change-Id: I2a415e7c20d134d400e48745278597b475076d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163927
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c39b832e85ae9e172f51c77c40d74949afcc0ac3]

        Avoid -Werror,-Wunused-but-set-variable for ENABLE_WASM_STRIP_PINGUSER
        
        ...after 607740654f2264e13469e4da1d020448217d7222 "Resolves tdf#131550 -
        Suppress Donate/Involve infobar if another is visible"
        
        Change-Id: I1d788a0f71a5baa8ce427631485643f0fd6e626d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164102
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6cc09586f583e6509cf7bda052f365ddc3bca16e]

        Test Embind'ing of UNO enums
        
        Change-Id: I87d55236ee09b80aadcc95e2c0f06f15b9e24a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164100
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6064939d40119877eb65d5f0ce80f65d9fac53da]

        Embind support for constant groups
        
        The constants are only reflected directly as JS values in the generated *.js
        file.  Reflecting them via emscripten::constant in the generated *.cxx did not
        work well:  Most importantly, emscripten::constant (and its underlying
        _embind_register_constant) coerce all values to double, so UNO (unsigned) hyper
        would not survive as JS BigInt, which would then cause e.g.
        
        >     console.assert(test.isHyper(uno.org.libreoffice.embindtest.Constants.Hyper));
        
        passing such a (JS number, not BigInt) value into the
        org.libreoffice.embindtest.XTest::isHyper method (which expects a UNO hyper) to
        fail.  (Also, constants of UNO boolean type would be represented as numbers 0/1
        rather than as false/true.)
        
        Change-Id: I056db0ccce0bf40eb53728fd439cc74964eb6951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164097
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [08d265144421deed247c23af36b0a6d41c35bf1f]

        assert on failure to load .ui file
        
        otherwise I get hard to diagnose SIGSEGV further on in other code
        
        Change-Id: Ic0397c7dd532f639482dfc2ee9ec36b32023fb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-29  Mike Kaganski  <mike.kaganski@collabora.com>  [40336ee0b4acf4e359fef696c6c2a6b3fa9718e7]

        Simplify a bit
        
        Change-Id: I9fbc43916fe0d7af87001e48854a87636115a1f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164133
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3e2147537f84bf6ca2f81e3e9a267b5db4bc1788]

        sc: prefix ScDPOutput members
        
        Change-Id: I628854772a2a13d113e2b488a78f0f72d2fa66c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164036
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0ccf447843b3a94e1a6b09e5f123f9636e24d78a]

        Simplify a bit
        
        Change-Id: I90e26030cb7a002bfd76cbc7aa73a5d3ea7a7f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164132
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Mike Kaganski  <mike.kaganski@collabora.com>  [c2dca161c0ed455a962d23f8e2fcb64143c5e674]

        Use <bit> instead of platform-specific intrinsics
        
        Change-Id: I79636ff9c3b2fe601b0b3c94a111b36af0011775
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164131
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Mike Kaganski  <mike.kaganski@collabora.com>  [e2473fe3a547e5a11d3b91ab8ded833bf5b74356]

        Drop redundant code: this is handled below
        
        And use standard functions in the rtl_math_RoundingMode_HalfEven
        handler.
        
        Change-Id: If9f29aa63423db9457a02ed003cfc27cf3df5585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164104
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-29  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [364f0bb1cac0e12f5f926857f61c2f329a353ec7]

        tdf#155218 sc: fix regression page orientation in print dialog
        
        The print page orientation set in the Print Dialog displays incorrect
        print area borders on the sheet after closing the Print Dialog or
        interrupting the printing process.
        
        The print dialog increase in size if the "Pages" and "All pages" radio
        buttons are toggled many times.(problem is not reproduced on Windows)
        
        regression was made by: I5e494a0714e398221bee00744d7e25c419a41df7
        
        Change-Id: I5a0ab3d781b21eff575afaebb233237eff1827d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164085
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-02-28  Matt K  <mattkse@gmail.com>  [6a064b1967e06e40be40817deff99d00c1a8554f]

        tdf#139004 Prevent crash when deleting footnote styles
        
        The problem was that a pointer was assumed valid, but
        was not, so now we check the value of the pointer
        before using it.  Works now to delete footnote style.
        
        Also, change assert to variable check to ensure the
        proper method is only called when it is supposed to
        be, and to prevent a failing assert.  We add a new
        Destr method on SwFormat so that it can be called
        from the SwTextFormatColl context and thus avoid
        the assert.
        
        Change-Id: Ia4b8029fb89e627cd685b3317606e2b9d60cf248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162965
        Tested-by: Jenkins
        Reviewed-by: Matt K <mattkse@gmail.com>

2024-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8237d35d9f90d1dfdd35f24af8729d668029e2c]

        ofz#67092 Integer-overflow
        
        Change-Id: I74a5218b44de06b06e8c16493e76992e496527d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164098
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fd0247ad59782523fd81f8a84b7a67258f853461]

        Update git submodules
        
        * Update translations from branch 'master'
          to 746e6ecef2d71de19c9f77b53eca64d62aa42df3
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I7aae0544505f037b2eac91c268744de617dc4386
            
2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [741f88c9ec38becafba48477abbcfd500fcdc8e1]

        Some improvements to the UNOIDL SourceTreeProvider
        
        Trying to do
        
        $ instdir/sdk/bin/unoidl-read udkapi
        
        (i.e., parsing the udkapi/com/sun/star/**.idl tree and printing it out): first
        failed with
        
        > Bad input <file:///.../udkapi/com/sun/star/beans/theIntrospection.idl>: source file defines more than one entity
        
        because of its
        
        > published interface XIntrospection;
        
        forward declaration, so ignore such interface forward declarations; then failed
        with
        
        > Bad input <file:///.../udkapi/com/sun/star/modules.idl>: source file defines no entity
        
        because "this file contains documentation of the modules", so ignore such
        effectively empty files; then failed with
        
        > Bad input <file:///.../udkapi/type_reference/udkapi.idl>: source file defines more than one entity
        
        so instead do
        
        $ mkdir TMP
        $ cp -r udkapi/com TMP/
        $ instdir/sdk/bin/unoidl-read TMP
        $ rm -r TMP
        
        which succeeded.
        
        Change-Id: I465052539b474733e7945b312c996af27a034335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164094
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1037edf4ec9bd2d17b2b39aab47a162b17335b96]

        Fix copy/paste error
        
        ...that had caused unoidl-write to generate garbage values when writing
        constants of type double to binary type libraries.  (But which had apparently
        gone largely unnoticed until now, as the only actual use so far of such a
        constant of type double that I could find is
        
        >     const double            aConstDouble    = 3.14e-10;
        
        in the unused stoc/test/testcorefl.idl test file.)
        
        Change-Id: I9a6fdb7a4aaff1008b8264cbbc64a84e60bd3813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164096
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c7664873f8aff4e1fa4f857e87821a49f858a73b]

        tdf#159467 XLOOKUP propagate error only for active paths
        
        because XLOOKUP have [if_not_found] optional attribute where
        a valid match is not found, return the [if_not_found] value
        you supply. Which can also return an error as a result from
        another function.
        
        If a valid match is not found, and [if_not_found] is missing, #N/A is returned.
        
        follow-up for tdf#127293: d9635e9bb42cf2b744b8d2f74633e2a209a8e3fd
        
        Change-Id: Ic8727c6b51e947ef767397c29095b93286bc7bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164042
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [f0d8f72eb3447b705d1dcdc35a6f3c66a880ab7e]

        tdf#159938: only apply wrap when the content was modified
        
        Change-Id: I2f18739239401085a06bbdce6623a484c13d680b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164091
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b8a8eee4dcbaffa1d0770439d8ae7a2be0b2909f]

        assertion fails on last rows selection / modification
        
        Open Calc hello world spreadsheet
        Click on cell in column H
        Press ctrl + shift + down arrow to select and go to the end of sheet (cell H1048576)
        Click on the H1048576 and type something, Save
        Refresh browser / reload spreadsheet
        try to select modified cell, remove content
        
        Result: Crash
        
        assert(nEndRow >= nStartRow);
        nEndRow   = 1048575
        nStartRow = 1048576
        
        likely an assert since:
        
        commit a86c00414a43c5d87981ffae1018cb242c5e5e1d
        Date:   Fri Jan 19 14:27:10 2024 +0200
        
            cool#6893 reduce allocation in ScGridWindow::PaintTile
        
        but seems harmless for this specific example
        
        Change-Id: I1d492c357a7a0a23b9f9cc974c4b9f684aba8648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163986
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [9c64ae31a7e7b6dc369b820d087527a1db29e2c7]

        tdf#159735 a11y: Dispose win accessible with VCLXWindow
        
        `Window::dispose` takes care of disposing its
        accessible as well.
        
        However, `VCLXWindow::dispose` was explicitly unsetting
        the accessible before disposing its `vcl::Window`, resulting
        in it not getting disposed, in turn resulting in a crash on exit
        for the tdf#159735 case.
        
        Potentially related:
        
            commit 5aa60be574ece81b27c8f63e6e809871c694dba0
            Date:   Wed May 12 11:33:06 2021 +0200
        
                fix leak in VCLXWindow
        
                which is a little tricky because dispose() can be called from either
                side (vcl::Window or VCLXWindow)
        
        Before that commit, setting a nullptr accessible happened
        in the `VCLXWindow` dtor, which is meant to get called after
        the `vcl::Window` got disposed in `VCLXWindow::dispose`.
        (In the Linux bibisect repo, the commit before that one is fine
        and at that commit, the tdf#159735 comment 5 scenario even
        crashes in step 3 already.)
        
        Don't unset the `vcl::Window`'s accessible any more in
        `VCLXWindow::dispose`, but do that after disposing it in
        `vcl::Window::dispose` instead, which seems to be the
        natural place to do that anyway.
        
        Backtrace of crash:
        
            Thread 1 received signal SIGSEGV, Segmentation fault.
            0x00007fd754ae6fe9 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear (this=0x7ffccdc2b5b8, rGuard=..., rEvt=...) at include/comphelper/interfacecontainer4.hxx:397
            397                     aIt.next()->disposing(rEvt);
            (gdb) bt
            #0  0x00007fd754ae6fe9 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear(std::unique_lock<std::mutex>&, com::sun::star::lang::EventObject const&)
                (this=0x7ffccdc2b5b8, rGuard=..., rEvt=...) at include/comphelper/interfacecontainer4.hxx:397
            #1  0x00007fd754ae6014 in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
                (_nClient=28, _rxEventSource=uno::Reference to (accessibility::AccessibleListBox *) 0x55bf49c0ad00) at .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:204
            #2  0x00007fd754ae1424 in comphelper::OCommonAccessibleComponent::disposing() (this=0x55bf49c0ad00) at .../libreoffice/comphelper/source/misc/accessiblecomponenthelper.cxx:61
            #3  0x00007fd74e884512 in VCLXAccessibleComponent::disposing() (this=0x55bf49c0ad00) at .../libreoffice/toolkit/source/awt/vclxaccessiblecomponent.cxx:376
            #4  0x00007fd6a3d506b7 in accessibility::AccessibleListBox::disposing() (this=0x55bf49c0ad00) at .../libreoffice/accessibility/source/extended/accessiblelistbox.cxx:246
            #5  0x00007fd75453f544 in cppu::WeakComponentImplHelperBase::dispose() (this=0x55bf49c0ad00) at .../libreoffice/cppuhelper/source/implbase.cxx:104
            #6  0x00007fd6a3d45fd5 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose() (this=0x55bf49c0ad00)
                at include/cppuhelper/compbase.hxx:90
            #7  0x00007fd75453f1fe in cppu::WeakComponentImplHelperBase::release() (this=0x55bf49c0ad00) at .../libreoffice/cppuhelper/source/implbase.cxx:79
            #8  0x00007fd6a3d47d85 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::release() (this=0x55bf49c0ad00)
                at include/cppuhelper/compbase.hxx:86
            #9  0x00007fd6a3d47ca5 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleExtendedComponent>::release() (this=0x55bf49c0ad00) at include/cppuhelper/implbase.hxx:171
            #10 0x00007fd6a3d47c85 in cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper, com::sun::star::lang::XServiceInfo>::release() (this=0x55bf49c0ad00) at include/cppuhelper/implbase.hxx:171
            #11 0x00007fd6a3d45f55 in cppu::ImplInheritanceHelper<VCLXAccessibleComponent, com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleSelection>::release() (this=0x55bf49c0ad00)
                at include/cppuhelper/implbase.hxx:171
            #12 0x00007fd74282e13e in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() (this=0x55bf49c0e860) at include/com/sun/star/uno/Reference.hxx:114
            #13 0x00007fd7428524c5 in std::destroy_at<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__location=0x55bf49c0e860)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88
            #14 0x00007fd7428524a5 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__pointer=0x55bf49c0e860)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149
            #15 0x00007fd742852477 in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*>(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__first=0x55bf49c0e860, __last=0x55bf49c0e868) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163
            #16 0x00007fd74285243d in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*>(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__first=0x55bf49c0e860, __last=0x55bf49c0e868) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:195
            #17 0x00007fd742852379 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >&) (__first=0x55bf49c0e860, __last=0x55bf49c0e868)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948
            #18 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~vector() (this=0x55bf4d1120f8)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:732
            #19 0x00007fd74285231d in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~vector() (this=0x55bf4d1120e0)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/vector:230
            #20 0x00007fd7428522f5 in o3tl::sorted_vector<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::less<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, o3tl::find_unique>::~sorted_vector()
                (this=0x55bf4d1120e0) at include/o3tl/sorted_vector.hxx:47
            #21 0x00007fd74284f83d in DocumentFocusListener::~DocumentFocusListener() (this=0x55bf4d1120b0) at vcl/inc/unx/gtk/gtkdata.hxx:221
            #22 0x00007fd74284f869 in DocumentFocusListener::~DocumentFocusListener() (this=0x55bf4d1120b0) at vcl/inc/unx/gtk/gtkdata.hxx:221
            #23 0x00007fd7546453a0 in cppu::OWeakObject::release() (this=0x55bf4d1120b0) at .../libreoffice/cppuhelper/source/weak.cxx:230
            #24 0x00007fd742834415 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x55bf4d1120b0) at include/cppuhelper/implbase.hxx:115
            #25 0x00007fd754aec91e in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference() (this=0x55bf4896c088) at include/com/sun/star/uno/Reference.hxx:114
            #26 0x00007fd754aec8e5 in std::destroy_at<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*)
                (__location=0x55bf4896c088) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88
            #27 0x00007fd754aec8c5 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*)
                (__pointer=0x55bf4896c088) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:149
            #28 0x00007fd754aec897 in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55bf4896c088, __last=0x55bf4896c090)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:163
            #29 0x00007fd754aec85d in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55bf4896c080, __last=0x55bf4896c090) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:195
            #30 0x00007fd754aec799 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >&) (__first=0x55bf4896c080, __last=0x55bf4896c090) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:948
            --Type <RET> for more, q to quit, c to continue without paging--
            #31 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector()
                (this=0x55bf49866bc8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_vector.h:732
            #32 0x00007fd754aec73d in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() (this=0x55bf49866bb0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/vector:230
            #33 0x00007fd754aec715 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::impl_t::~impl_t() (this=0x55bf49866bb0) at include/o3tl/cow_wrapper.hxx:176
            #34 0x00007fd754aec6e4 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::release() (this=0x55bf49b28380) at include/o3tl/cow_wrapper.hxx:207
            #35 0x00007fd754aec675 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::~cow_wrapper() (this=0x55bf49b28380) at include/o3tl/cow_wrapper.hxx:271
            #36 0x00007fd754ae6ae5 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::~OInterfaceContainerHelper4() (this=0x55bf49b28380) at include/comphelper/interfacecontainer4.hxx:126
            #37 0x00007fd754ae7c49 in std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::~pair() (this=0x55bf49b28378)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_pair.h:187
            #38 0x00007fd754ae7c25 in std::destroy_at<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__location=0x55bf49b28378) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/stl_construct.h:88
            #39 0x00007fd754ae7b4b in std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::destroy<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >&, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*)
                (__a=..., __p=0x55bf49b28378) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/alloc_traits.h:560
            #40 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*)
                (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>, __n=0x55bf49b28370) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable_policy.h:2011
            #41 0x00007fd754ae7ab5 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*)
                (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>, __n=0x0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable_policy.h:2033
            #42 0x00007fd754ae79df in std::_Hashtable<unsigned int, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::clear() (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/hashtable.h:2524
            #43 0x00007fd754af6415 in std::__cxx1998::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7fd754d2aaa8 <(anonymous namespace)::gaClients+40>)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/unordered_map.h:798
            #44 0x00007fd754ae778d in std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7fd754d2aa80 <(anonymous namespace)::gaClients>)
                at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/unordered_map:234
            #45 0x00007fd754ae6640 in comphelper::AccessibleEventNotifier::shutdown() () at .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:268
            #46 0x00007fd74d3c5e41 in DeInitVCL() () at .../libreoffice/vcl/source/app/svmain.cxx:619
            #47 0x00007fd74d3c4031 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:254
            #48 0x00007fd74d3c5f79 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261
            #49 0x00007fd7565a4ba3 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94
            #50 0x000055bf472e7a5d in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #51 0x000055bf472e7a37 in main (argc=3, argv=0x7ffccdc2c9a8) at .../libreoffice/desktop/source/app/main.c:49
        
        Change-Id: I251b2f97184e0492f02eb772e5906847f9249506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164090
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b60048cbd7ac033294155f23d27bd446124b64fd]

        drop EEControlBits::FORMAT100
        
        FORMAT100 is only used by calc (since #i51508#) and looks to me as a
        workaround for the same fundamental issue addressed by contemporary
        resolution independent text layout and rendering.
        
        Change-Id: Ifd0a0adaff717da97bb94d9f81e14c65f3213d34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164084
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6328c4600466f35c2527172465c5c818717efee]

        use more string view in linguistic
        
        Change-Id: Ib5c776f95b424128871a1676d996ae95b7048c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-28  Heiko Tietze  <tietze.heiko@gmail.com>  [607740654f2264e13469e4da1d020448217d7222]

        Resolves tdf#131550 - Suppress Donate/Involve infobar if another is visible
        
        Change-Id: I013f0a1f0aa020f10d6beb21940959508eba4547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164082
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac4916037790fe33b83f4e2dae412c8cf2835af4]

        uitest: drop commented-out code
        
        Added in 0c643e8afdf8b0b929b603340979e771eeb9fc0b
        "tdf#159927 unit test for impress date/time language detection"
        
        Change-Id: I4711034f9a16eccc234298529e5d7b5c949c23af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164080
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-28  Miklos Vajna  <vmiklos@collabora.com>  [c98ff922831f56253af2a050b8e07cfc89b7a387]

        Related: tdf#158986 sw floattable, RTF import: use more setNeedPar()
        
        See
        <https://gerrit.libreoffice.org/c/core/+/163844/1#message-ea0bfde78fa24ad83e5c153ecaddbf897a89f547>,
        this keeps the bug fixed but is a better version, as pointed out by
        Michael S:
        
        > there was a bug where dispatching PAR here caused a deferred page
        > break to be lost, which was fixed by calling setNeedPar(true) instead.
        
        Change-Id: Ibe6e4c14286d40d3066ce9cb7fac9f6847fb81dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164081
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-28  Julien Nabet  <serval2412@yahoo.fr>  [458f4c9b489d92947c4122e7c450f65f90aa4efe]

        tdf#159874: Inspection of 3D object in Dev Tools crashes LO (take 2)
        
        To not trigger tdf#159911 (FILEOPEN: 3D object is displayed as black/white)
        Let's initialize Svx3DTextureKindItem to 2 which corresponds to COLOR in TextureKind2.idl
        (see https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/drawing/TextureKind2.idl?r=5687eba4)
        
        but now to avoid the crash, we must replace all uses of TextureKind by TextureKind2
        Anyway, TextureKind has been deprecated since 2000
        (see https://cgit.freedesktop.org/libreoffice/core/commit/?id=4f9e6d84feb36ab3072dafbab0ba4ae46d264f9b
        "#80594# added a new TextureKind2 enum because of missing value in TextureKind")
        
        + use css::drawing::TextureKind2_LUMINANCE + css::drawing::TextureKind2_COLOR instead of wrong numbers
        
        Change-Id: I969bd9ba1c6752111a6e6f5cd2c6c608568e43e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163998
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-28  Yiğit Akçay  <yigit.akcay@icloud.com>  [a7dd2e5a4712083cc5934e1d677e7dff86ceb7e6]

        tdf#151710 Enable enclosing of selected text with characters
        
        This patch implements a new setting in Tools -> Options -> Writer ->
        Formatting Aids -> Autocomplete -> Enclose with characters.
        
        When this option is enabled (default), selected text is enclosed
        with parentheses, square brackets, curly braces or quotation marks,
        depending on which character is pressed.
        
        For example, if the selected text is "abcd", the option is enabled and
        the button for the character '(' is hit, the text is replaced with
        "(abcd)".
        
        Change-Id: Ibc5b7be3cc96f00217dd068971e7c07e68439700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162583
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2024-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d3366f5b392418dc83bc0adbe3d215cff4b3605]

        don't use EEControlBits::FORMAT100 in inline editengine for kit mode
        
        With multiple users the EditEngine for the first user is created during
        load of the document, before ScModelObj::initializeForTiledRendering is
        called, and that sets SetTextWysiwyg(true)
        
        ScInputHandler::UpdateRefDevice has...
        if ( bTextWysiwyg ... ) mpEditEngine->SetControlWord( ... | EEControlBits::FORMAT100 );
        
        That FORMAT100 means that layout for such edit engines is done at a X/Y
        Scaling of 1
        
        The first users editengine doesn't get any of that set, because
        TextWysiwyg is not true yet when it's created, and so matches the normal
        document rendering, but later joiners have TextWysiwyg set, so trigger
        this alternative path and so the mapmode doesn't match the other case
        and the two users have different results for the width of text in an
        active editengine.
        
        As it turns out, the results without FORMAT100 are the preferred ones,
        so make that explicit for kit.
        
        Change-Id: I76a78be1fca4af84c493d32bdd43f968ba072452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164059
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fa4a68dc3e62bb76bc29309e15741375f2663cb6]

        sync InputHandler zoom on setClientZoom
        
        analogous to what SetZoom and ScTabViewShell::Activate do.
        
        Otherwise the InputHandler editengine ref device used for cell editing
        stays at the MapMode stored in the document and doesn't update to stay
        in sync with the desired rendering so there is a visible mismatch
        between normal rendering and cell editing rendering.
        
        Change-Id: Ifd9b21ab15cc123e0747fcebfdd55f2ddc44bd31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-28  Miklos Vajna  <vmiklos@collabora.com>  [34ca24d35a65de3ba9cdac25de390473ef369376]

        CppunitTest_sw_docbookexport: rework to avoid DECLARE_DOCBOOKEXPORT_TEST()
        
        No need go via Writer-specific macros.
        
        Change-Id: I68619a8cc610d7aa2d14657adaf8a7806060ced5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164079
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-28  Miklos Vajna  <vmiklos@collabora.com>  [e8487bedb20a429565b4a0e4bd2d6806cc603b7f]

        Related: tdf#150408 RTF filter: handle legal numbering
        
        The bugdoc's 2nd para started with 'Sect I.01', while Word rendered this
        as 'Sect 1.01'.
        
        The reason for this difference is that there is an "is legal" boolean
        property on the numbering that we ignored from RTF during import/export.
        
        Fix the problem by extending RTFDocumentImpl::dispatchTableSprmValue()
        for the numbering table import + RtfAttributeOutput::NumberingLevel()
        for the export.
        
        The import default for this value was also wrong, given that the default
        is to enable it when the control word is present.
        
        Change-Id: I4dcd23768000ba29d4df314b475b412bb371545e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164078
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [8f88aff98c6089140c73437e567e6d78da5f563e]

        tdf#159910 a11y: Dispose VCLXAccessibleList children
        
        In `VCLXAccessibleList::HandleChangedItemList`,
        don't just clear the vector of list items, but
        dispose them first.
        
        To avoid code duplication, extract a helper method
        from `VCLXAccessibleList::disposing` which already
        disposes the children since
        
            commit 51de048ae97cbd371457dbc07120e30db9ee4187
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Sep 4 17:19:03 2023 +0200
        
                tdf#157088 a11y: Dispose list items with list
        
        This fixes a similar crash/assert on exit, seen after using the
        Navigator in Writer (in particular the combo/listboxes in
        there) with the qt6 VCL plugin and the Orca screen reader
        running.
        
        stderr showed this:
        
            soffice.bin: .../libreoffice/comphelper/source/misc/accessibleeventnotifier.cxx:142: bool (anonymous namespace)::implLookupClient(const AccessibleEventNotifier::TClientId, ClientMap::iterator &): Assertion `rClients.end() != rPos && "AccessibleEventNotifier::implLookupClient: invalid client id " "(did you register your client?)!"' failed.
            Aborted
        
        Backtrace:
        
            1 __pthread_kill_implementation pthread_kill.c 44 0x7f0e1a4a816c
            2 __pthread_kill_internal pthread_kill.c 78 0x7f0e1a4a81cf
            3 __GI_raise raise.c 26 0x7f0e1a45a472
            4 __GI_abort abort.c 79 0x7f0e1a4444b2
            5 __assert_fail_base assert.c 92 0x7f0e1a4443d5
            6 __assert_fail assert.c 101 0x7f0e1a4533a2
            7 (anonymous namespace)::implLookupClient accessibleeventnotifier.cxx 140 0x7f0e18ce59ac
            8 comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing accessibleeventnotifier.cxx 185 0x7f0e18ce5e68
            9 VCLXAccessibleListItem::disposing vclxaccessiblelistitem.cxx 164 0x7f0ddf7d237f
            10 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7f0e1873f544
            11 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::dispose compbase.hxx 90 0x7f0ddf7cb7c5
            12 cppu::WeakComponentImplHelperBase::release implbase.cxx 79 0x7f0e1873f1fe
            13 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::release compbase.hxx 86 0x7f0ddf7cd0c5
            14 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference Reference.hxx 114 0x7f0e06bbccbe
            15 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7f0e06bd618d
            16 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7f0e06bd6219
            17 QAccessibleCache::deleteInterface qaccessiblecache.cpp 173 0x7f0e05545319
            18 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 31 0x7f0e0554492a
            19 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 32 0x7f0e055449b0
            20 cleanupAccessibleCache qaccessiblecache.cpp 24 0x7f0e05544896
            21 qt_call_post_routines qcoreapplication.cpp 332 0x7f0e05faf826
            22 QApplication::~QApplication qapplication.cpp 665 0x7f0e0419e24a
            23 QApplication::~QApplication qapplication.cpp 722 0x7f0e0419e55c
            24 std::default_delete<QApplication>::operator() unique_ptr.h 99 0x7f0e06c5d63c
            25 std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 211 0x7f0e06c5df7c
            26 std::unique_ptr<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 509 0x7f0e06c58bfd
            27 QtInstance::~QtInstance QtInstance.cxx 305 0x7f0e06c51184
            28 QtInstance::~QtInstance QtInstance.cxx 302 0x7f0e06c51279
            29 DestroySalInstance salplug.cxx 368 0x7f0e114c0a18
            30 DeInitVCL svmain.cxx 625 0x7f0e115c5e7d
            31 ImplSVMain svmain.cxx 254 0x7f0e115c4031
            32 SVMain svmain.cxx 261 0x7f0e115c5f79
            33 soffice_main sofficemain.cxx 94 0x7f0e1a7a4ba3
            34 sal_main main.c 51 0x559ce9c67a5d
            35 main main.c 49 0x559ce9c67a37
        
        Change-Id: Ic5121645a6920a8ac35154dda1dcfa1974ab9d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164062
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [0845e782eb271c6e13ad376cff7ec72724d2a89c]

        a11y: Drop extra local variable
        
        Just assign to `VCLXAccessibleBox::m_xList` right away.
        
        Change-Id: Id6cd871ccb54cd709ddf3ed6e59b8f3feb8314ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164061
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [dd514841e6d9b1b2f9d1ac13bca593fcfcb781f6]

        a11y: Just use reference instead of extra pointer to content
        
        Just use the `VCLXAccessibleBox::m_xList` member directly
        instead of extra local pointer variables referring to the
        reference's body.
        
        Change-Id: Ic760d766221df773e8285c927e58ea7419cc7da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164060
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ef6798919a514fc0043f4cd050ffb244696bbda3]

        Avoid calling back into an SdrMarkView that is being destroyed
        
        The recently added CppunitTest_sc_tiledrendering
        CPPUNIT_TEST_NAME=testEditShapeText::TestBody had started to cause
        
        > svx/source/svdraw/sdrpagewindow.cxx:471:56: runtime error: member call on address 0x51d0000c4480 which does not point to an object of type 'SdrMarkView'
        > 0x51d0000c4480: note: object is of type 'SdrPaintView'
        >  00 00 00 00  30 1f 13 bc ca 7f 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  03 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SdrPaintView'
        >  #0 in SdrPageWindow::InvalidatePageWindow(basegfx::B2DRange const&) at svx/source/svdraw/sdrpagewindow.cxx:471:56
        >  #1 in sdr::contact::ObjectContactOfPageView::InvalidatePartOfView(basegfx::B2DRange const&) const at svx/source/sdr/contact/objectcontactofpageview.cxx:357:29
        >  #2 in sdr::contact::ViewObjectContact::triggerLazyInvalidate() at svx/source/sdr/contact/viewobjectcontact.cxx:267:28
        >  #3 in sdr::contact::ObjectContactOfPageView::Invoke() at svx/source/sdr/contact/objectcontactofpageview.cxx:105:29
        >  #4 in sdr::contact::ObjectContactOfPageView::~ObjectContactOfPageView() at svx/source/sdr/contact/objectcontactofpageview.cxx:74:13
        >  #5 in sdr::contact::ObjectContactOfPageView::~ObjectContactOfPageView() at svx/source/sdr/contact/objectcontactofpageview.cxx:72:9
        >  #6 in SdrPageWindow::ResetObjectContact() at svx/source/svdraw/sdrpagewindow.cxx:520:9
        >  #7 in SdrPageWindow::~SdrPageWindow() at svx/source/svdraw/sdrpagewindow.cxx:130:5
        >  #8 in std::default_delete<SdrPageWindow>::operator()(SdrPageWindow*) const at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:93:2
        >  #9 in std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>::~unique_ptr() at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:398:4
        >  #10 in void std::destroy_at<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>(std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/stl_construct.h:88:15
        >  #11 in void std::_Destroy<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>(std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/stl_construct.h:149:7
        >  #12 in void std::_Destroy_aux<false>::__destroy<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*>(std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*, std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/stl_construct.h:163:6
        >  #13 in void std::_Destroy<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*>(std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*, std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/stl_construct.h:195:7
        >  #14 in void std::_Destroy<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*, std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>(std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*, std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>*, std::allocator<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>&) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/alloc_traits.h:941:7
        >  #15 in std::__cxx1998::vector<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>, std::allocator<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>>::~vector() at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/stl_vector.h:732:2
        >  #16 in std::__debug::vector<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>, std::allocator<std::unique_ptr<SdrPageWindow, std::default_delete<SdrPageWindow>>>>::~vector() at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/debug/vector:245:25
        >  #17 in SdrPageView::~SdrPageView() at svx/source/svdraw/svdpagv.cxx:122:1
        >  #18 in std::default_delete<SdrPageView>::operator()(SdrPageView*) const at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:93:2
        >  #19 in std::__uniq_ptr_impl<SdrPageView, std::default_delete<SdrPageView>>::reset(SdrPageView*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:205:4
        >  #20 in std::unique_ptr<SdrPageView, std::default_delete<SdrPageView>>::reset(SdrPageView*) at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:503:7
        >  #21 in SdrPaintView::ClearPageView() at svx/source/svdraw/svdpntv.cxx:356:20
        >  #22 in SdrPaintView::~SdrPaintView() at svx/source/svdraw/svdpntv.cxx:189:5
        >  #23 in SdrSnapView::~SdrSnapView() at svx/source/svdraw/svdsnpv.cxx:199:1
        >  #24 in SdrMarkView::~SdrMarkView() at svx/source/svdraw/svdmrkv.cxx:197:1
        >  #25 in SdrEditView::~SdrEditView() at svx/source/svdraw/svdedtv.cxx:126:1
        >  #26 in SdrPolyEditView::~SdrPolyEditView() at svx/source/svdraw/svdpoev.cxx:58:1
        >  #27 in SdrGlueEditView::~SdrGlueEditView() at svx/source/svdraw/svdglev.cxx:40:1
        >  #28 in SdrObjEditView::~SdrObjEditView() at svx/source/svdraw/svdedxv.cxx:101:1
        >  #29 in SdrExchangeView::~SdrExchangeView() at include/svx/svdxcgv.hxx:27:25
        >  #30 in SdrDragView::~SdrDragView() at svx/source/svdraw/svddrgv.cxx:69:1
        >  #31 in SdrCreateView::~SdrCreateView() at svx/source/svdraw/svdcrtv.cxx:199:1
        >  #32 in SdrView::~SdrView() at svx/source/svdraw/svdview.cxx:154:1
        >  #33 in E3dView::~E3dView() at svx/source/engine3d/view3d.cxx:1457:1
        >  #34 in FmFormView::~FmFormView() at svx/source/form/fmview.cxx:124:1
        >  #35 in FmFormView::~FmFormView() at svx/source/form/fmview.cxx:119:1
        >  #36 in std::default_delete<FmFormView>::operator()(FmFormView*) const at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:93:2
        >  #37 in std::unique_ptr<FmFormView, std::default_delete<FmFormView>>::~unique_ptr() at ~/gcc/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/bits/unique_ptr.h:398:4
        >  #38 in ScGridWindow::~ScGridWindow() at sc/source/ui/view/gridwin.cxx:450:1
        >  #39 in ScGridWindow::~ScGridWindow() at sc/source/ui/view/gridwin.cxx:448:1
        >  #40 in ScGridWindow::~ScGridWindow() at sc/source/ui/view/gridwin.cxx:448:1
        >  #41 in VclReferenceBase::release() const at include/vcl/vclreferencebase.hxx:43:13
        >  #42 in rtl::Reference<vcl::Window>::~Reference() at include/rtl/ref.hxx:131:22
        >  #43 in VclPtr<vcl::Window>::~VclPtr() at include/vcl/vclptr.hxx:112:5
        >  #44 in ImplSVWinData::~ImplSVWinData() at vcl/source/app/svdata.cxx:531:34
        >  #45 in DestroySVWinData(ImplSVWinData*) at vcl/source/app/svdata.cxx:388:5
        >  #46 in SfxViewFrame::~SfxViewFrame() at sfx2/source/view/viewfrm.cxx:2012:5
        >  #47 in SfxViewFrame::Close() at sfx2/source/view/viewfrm.cxx:1190:5
        >  #48 in SfxFrame::DoClose_Impl() at sfx2/source/view/frame.cxx:138:37
        >  #49 in SfxBaseController::dispose() at sfx2/source/view/sfxbasecontroller.cxx:928:27
        >  #50 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1495:33
        >  #51 in (anonymous namespace)::XFrameImpl::close(unsigned char) at framework/source/services/frame.cxx:1706:12
        >  #52 in SfxFrame::DoClose() at sfx2/source/view/frame.cxx:104:29
        >  #53 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) at sfx2/source/view/viewfrm.cxx:1778:28
        >  #54 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:40:24
        >  #55 in (anonymous namespace)::SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) at sfx2/source/doc/objxtor.cxx:147:12
        >  #56 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1516:40
        >  #57 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:750:13
        >  #58 in ScTiledRenderingTest::tearDown() at sc/qa/unit/tiledrendering/tiledrendering.cxx:140:22
        
        The fix appears to be to just not call back into the in-destruction FmFormView -
        ... - SdrMarkView - ... - SdrPaintView - ... deep-inheritance object, by not
        initiating any further triggerLazyInvalidate from within
        ~ObjectContactOfPageView.
        
        Change-Id: If5e49e4ebdbbf18d38e89c6b28ff3577224080a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164024
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  AhmedHamed  <ahmedhamed3699@gmail.com>  [e6ecd5a32c457a1049b601b84b93899cb6ddaefa]

        tdf#114441 Convert sal_uLong to sal_uInt32 in TreeControlPeer
        
        We are talking about a tree list in a gui which logically will not exceed sal_uInt32
        They also must be unsigned integers because they represent counts & positions
        
        changes are done to these variables:
        - nPos (node position)
        In all base classes you will found that all functions deal with and return sal_int32 concerning it
        - nChild (node child)
        It is assigned to TREELIST_APPEND which is MAX for sal_uInt32 and it is considered like that in all other functions
        - nSelectionCount
        all functions that deal with it (like GetSelectionCount()) returns sal_uInt32
        
        Change-Id: I1771b9aa52c351063d007d7014484861d4b3e02a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164067
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [621322b6ac0bebab2f904b7fe8d040193a1f45ba]

        Generate slightly more flexible JS init_unoembind_* functions
        
        ...that return the "hierarchical object", rather than setting it as a member of
        the passed-in instance
        
        Change-Id: I17ad7dd426114c7979f1ba6edaebe83b43eedfed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164064
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c7664f12a99b6e08eb334d63646c3d2a6aa75e18]

        Init Embind-ings manually, once UNO is set up
        
        Upcoming code that changes the Embind'ing of UNO sequences will require
        availability of the UNO type manager during that Embind init code, so only call
        that after UNO has been bootstrapped (rather than as part of the initialization
        of global static data, which is what EMSCRIPTEN_BINDINGS does).
        
        Change-Id: Iba19851ffb82c055dcab10a28a8c1fafa9d2a414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164065
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4c20fb09d7fe6c2f4cdb672a6238c8ddb67aa437]

        Revert "gbuild: WASM: try to fix "Missing generated source file *_embind.cxx""
        
        This reverts commit e4717342e5bea23f590a42d565a09ace600e2ca5.  cppumaker no
        longer generates *_embind.cxx files since
        b2ade3e63e34556cad8157e25f8c75d29e79537d "Extract embindmaker from cppumaker
        into its own tool ...that directly generates one large .cxx."
        
        Change-Id: Ic4f60a502f3e592489cf0cee86878c327bbb4894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164055
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Heiko Tietze  <tietze.heiko@gmail.com>  [6158928209bd0f6bd532df9092f3a81ff615cdcc]

        Resolves tdf#159863 - Default shortcut to access foot-/endnote area
        
        Change-Id: Ie95e94602a0dfd0c899f70d30d2c78e7063a4818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164001
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80e2c4e5b9ef1d299c6caa271c9f177a4d011937]

        Fold InternalUnoApi_embindtest into UnoApi_udkapi
        
        80d3f33876a2ad4ce32d3c6183131984e8c6b5da "Library_embindtest should use
        comprehensive InternalUnoApi_embindtest" was an attempt at making type
        information about that library available at runtime.  Which worked for cases
        where code directly called one of the types' cppu_detail_getUnoType function.
        But it would still fail for cases where code indirectly wants to obtain one of
        the types' information by type name---which is what upcoming code will do that
        changes the Embind'ing of UNO sequences.
        
        So InternalUnoApi_embindtest would need to become a UnoApi_embindtest whose
        instdir/program/types/embindtest.rdb would be available at runtime.  But I'm too
        dumb to convince gbuild to create that new UnoApi_embindtest.  So instead just
        tack the embindtest UNOIDL entities onto the existing UnoApi_udkapi for the
        EMSCRIPTEN-ENABLE_DBGUTIL case.  (Which requires that the single embindtest.idl
        is split into individual per-entity files, sigh.)
        
        Change-Id: Ie189b17213ac5b2de7a61ac5f97a143fa097337f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-28  Adam Seskunas  <adamseskunas@gmail.com>  [9071cd6e59fb98ad8a2ddfb1019eaf950c716722]

        tdf#149714 BitsPerPixel property of Graphic has Boolean UNO type
        
        - vcl change UNO type of UnoGraphicProperty::BitsPerPixel to sal_Int8 instead of sal_uInt8 which maps to BOOLEAN causing Basic to convert
        non-0 values to True
        
        - basic add CppUnitTest since thats where the problem was occuring
        
        Change-Id: I0111199151fb5e001b6362e1359ad90bb039f064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163899
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [072a25e1ef4815bbef4f18f59f025862a0d8e876]

        tdf#157135 workaround: restore and update windows-no-utf8-locales.patch.0
        
        This partially reverts commit ed259e5efe432386b54c553cbc644b3b64976852
        (Upgrade external/boost to latest Boost 1.81.0, 2023-01-05), which had
        dropped the patch previously introduced with commit
        f046fed2782f0d4244aff719ba70a56399a2583a (Don't ever attempt to initialise
        a std::locale with a UTF-8 locale on Windows, 2018-05-17).
        
        It seems that there is a nightmare going on in MSVCRT, and tdf#157135
        is caused by dome MS bug. The problem happens in a deeply nested call
        to mbstowcs_s (several levels deep from std::locale constructor with
        name of "en_US.UTF-8"), which gets a non-null wcstr and sizeInWords
        equal to zero, which generates an invalid argument handler, resulting
        in a failed assertion "(pwcs == nullptr && sizeInWords == 0) || (pwcs
        != nullptr && sizeInWords > 0)" in _mbstowcs_internal from
        minkernel\crts\ucrt\src\appcrt\convert\mbstowcs.cpp:245, and a crash.
        The crashreporter initiates, but since it tries to use CRT itself,
        which is in fastfail mode, it hangs.
        
        The patch that is restored here was intended for something different;
        but it happily workarounds the nightmare. Until the proper fix found,
        let it be.
        
        Change-Id: Ic978f87e2e7b81fc2e1cd182a4247084ad016a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164068
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-28  Justin Luth  <jluth@mail.com>  [0c643e8afdf8b0b929b603340979e771eeb9fc0b]

        tdf#159927 unit test for impress date/time language detection
        
        make -srj1 UITest_impress_tests \
            UITEST_TEST_NAME="tdf159927_dateTime.tdf159927.test_tdf159927" \
            SAL_USE_VCLPLUGIN=gen
        
        Change-Id: Ic0f13fd7f7f427cc85f8f7c4d144ecfb5b722291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164070
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-28  Kohei Yoshida  <kohei@libreoffice.org>  [5234ef71c7459506236d4d0dfe7beb5f00d8cc41]

        Make the code tidier & stop event handling during destruction
        
        This is a follow-up to 25ffb54c6d8a5b52dca6b782282962766e7791de.
        
        Change-Id: Ifc87323dd5085cdac08efac5fd9d22ae8b94d641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163997
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2024-02-28  Justin Luth  <justin.luth@collabora.com>  [62323124f54885c6de4ac4fa38052d380309a5a1]

        tdf#159927 sd headerfooterdlg: detect existing date/time language
        
        Sometimes it was hard to change an existing foreign language
        to your own language for Impress' header/footer fields.
        
        The function was only checking the first master slide for the
        date/time language. If it didn't have one, then the default locale
        was selected.
        
        However, although all pages share the same date/time language,
        it is not necessary for all (or even the first) master slide
        to have a date/time field. So check through all the master slides
        until one with a date/time is found.
        
        Obviously if none have one defined things still work OK,
        because that is effectively how it was working beforehand.
        
        I don't have much hope for a successful unit test.
        I'll try to develop it as a follow-up to this patch.
        
        Change-Id: Ida44957013978720ad12fadc9b4ebc88bc10ea40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164045
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-27  zeph  <zeph.chai@ymail.com>  [7c78d2b29e04228481c0e4bfa9e3eaf6ccbd575b]

        Add python code for ChartInCalc
        
        Change-Id: Ia7f4cbd539919e88f735c13bdd1dae3533b1163a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163037
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-27  AhmedHamed  <ahmedhamed3699@gmail.com>  [487ce28057656e752dc9bb7eddea5befb446ad0a]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: Ia27365b3e5539cdf0f96f01a96bbe58653eb46c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163788
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2024-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [971e32c280f2891445d8ec2b57a130962a9c7627]

        Fix typo
        
        Change-Id: I53e801cd4688c8495deecfb7a67a4ce39bdda978
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164054
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [01707d3b3a27bc0d6c482f05a669f8ef11be74b1]

        ofz#67046 fix build failure
        
        Change-Id: I8f48bf930f20d19a8b20e7e3ae825923bc014c31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164052
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fd948fd27356e703fffc7e46df0f0e3a22f57967]

        save a few bytes per column
        
        Change-Id: Ia0f6dfdf671703476b9b068d1dbe9076689d0690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164032
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Justin Luth  <justin.luth@collabora.com>  [5920bc2d1a624021a6f3eb42a56ce9b96b53a39f]

        address shortcoming: document why I avoided axials for transparency
        
        Hmm, I like to complain when other people
        don't comment on why certain situations are excluded,
        and yet I did the same thing here.
        
        Thanks vmiklos for pointing that out.
        
        Change-Id: I4c5ddeaeee078f036fc31149fc29bc6acb277ab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164040
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [d31c0fd5ed9fe563386cf317b366a0e739302dd2]

        tdf#159910 sw a11y: Set a11y names for Navigator items
        
        Set accessible names for the items (mostly toolbar items)
        in the Navigator.
        
        This makes the Orca screen reader with the gtk3 VCL plugin
        announce these as expected when they receive focus.
        
        For now, take over the existing tooltip text for the
        accessible name. This can be further tweaked if necessary.
        
        With the previous commit
        
            Change-Id: I45b87839dda90083ceba1c43fdb4d4ec460fce3d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 27 13:12:43 2024 +0100
        
                tdf#159910 a11y VclBuilder: Apply tool item's a11y name to itself
        
        , these a11y names are now also used for the VCL implementation
        (s. `VCLXAccessibleToolBoxItem::implGetAccessibleName`).
        The accessible name there remains the same for now, as the
        previous fallback was the tooltip name, which at least
        currently still has the same text.
        
        It seems reasonable to align the gtk3 and VCL implementation
        more with each other and support the default mechanism
        of explicitly setting an accessible name on the corresponding
        widget in the .ui file.
        
        Change-Id: I852503e849651bb7be4daa419ec2379568623f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164035
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [ad1167b92b8b8fdabf6b21e945682c0bafc80946]

        tdf#159910 a11y VclBuilder: Apply tool item's a11y name to itself
        
        For the VCL `ToolBox` implementation of a toolbar, the items
        are not represented by own widgets (`vcl::Window`s), but handled
        by the `ToolBox`.
        
        As a consequence, the `vcl::Window` passed to
        `VclBuilder::applyAtkProperties` cannot be the tool item
        itself (e.g. a `GtkToolButton` in the .ui file), but is the
        `ToolBox`, i.e. the (VCL builder implementation of the
        `GtkToolbar` parent widget in the .ui file).
        
        So far, the ATK properties set for the tool item were
        just applied to the parent instead.
        
        For example, with the upcoming
        
            Change-Id: I852503e849651bb7be4daa419ec2379568623f0f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 27 11:51:55 2024 +0100
        
                tdf#159910 sw a11y: Set a11y names for Navigator items
        
        , this would result in the toolbars getting the name of their
        last item (one of the toolbars in the Navigator would
        get the a11y name "Show Up to Outline Level") and the
        toolbar items would only have an a11y name set because
        they still fall back to the tooltip text for the a11y name.
        
        Adjust that to set the accessible name for the
        actual toolbar item when a toolbar item is
        processed. (Add a bool param to indicate that).
        
        See also `VclBuilder::applyPackingProperty` which
        already had a similar way to determine and handle that
        case.
        
        With this in place, the accessible name set in the .ui
        file is now applied to the toolbar item as expected.
        
        (The accessible description could be handled similarly,
        but I'm a bit more hesitant to add that right away because
        the accessible description is currently also used for the
        extended tooltip text and the NVDA screen reader on Windows
        announces the description in addition to the name by default.)
        
        Change-Id: I45b87839dda90083ceba1c43fdb4d4ec460fce3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164034
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-27  Michael Weghorn  <m.weghorn@posteo.de>  [8e456d51a48b4d2461634a41a40a5a3b58bfdef3]

        tdf#159910 vcl a11y: Allow explicitly setting toolbar item a11y name
        
        Add `ToolBox::SetAccessibleName` (and corresponding getter)
        to allow explicitly setting an accessible name for a toolbox/toolbar
        item with the VCL toolbar implementation.
        
        In the a11y class for a toolbar item, use any
        explicitly set name if it's non-empty, otherwise
        fall back to the previous logic.
        
        This will be used in an upcoming commit to
        take into account the accessible name set in .ui files
        and align the VCL ToolBox more with the gtk implementation
        using native GtkToolbar and native widgets for the toolbar
        items.
        
        Change-Id: Ib0255e2741a7ab2489a857ac120fb87f680fa775
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164033
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a403fcd3a0f9e6e57f57b9961f7732d9fd95ab17]

        Fix typo
        
        Change-Id: I30bd7ed93eedf241fde23b35ac674d010c9e6575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164043
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c1b5607264e3bafeb35df80c16664f2bddf33c2b]

        Fix UBSan build's RTTI needs
        
        ...after 3ba92b5f1eaf7d4447a0943ea260db515ca799dc "hide more symbols" had caused
        CppunitTest_sw_uiwriter to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter.so: undefined symbol: _ZTIN2sw11UndoManagerE"
        
        Change-Id: Ia17fd3c9d8f4e227cdd9ca3a5aa6f94f51c46168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164028
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-27  Gülşah Köse  <gulsah.kose@collabora.com>  [d208c1910b54f5dc711e490e68899ca13121e586]

        Online: Prevent hiding tooltips due to other users action.
        
        Other user's actions like reloading reopening or refreshing
        document causes hiding other user function tooltips.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I0aeb0aeb98182398e4740c71cfd65c4df2c51ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164027
        Tested-by: Jenkins

2024-02-27  Szymon Kłos  <szymon.klos@collabora.com>  [d0873e6c0faff565fabd50767a03e709653c039d]

        lok: don't hide tooltim on every action
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I62f69071a4857f7413a995da1ff9fc6ba2f942d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163977
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2024-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [d7974d46c8e3d6dc55b3ad11bb6e71e25552cf99]

        Simplify a bit
        
        Change-Id: Ib13dab2b57a5ca0d477783887c637d4cabbebcf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164029
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-27  Jim Raykowski  <raykowj@gmail.com>  [f34292a105fd1660fbef5f6811ea37ffdfff6c50]

        tdf#141728 follow up: don't expand spin control when sidebar is resized
        
        Change-Id: I9b231fd67f089e6fcd02329e255e22152e3ed3f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164003
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [045e551875cbd68ead6371b56ff13b3842648c1a]

        remove hsqldb from mergedlibs
        
        regression from
            commit ae17922b7d0f797129dd5fbd5514d691ac9ebeaa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Feb 14 09:33:05 2024 +0200
            add more libs into --enable-mergelibs=more build
        
        sberg is seeing
            This breaks e.g.  dbaccess_hsqldb_test  with
            java.lang.UnsatisfiedLinkError: java.lang.UnsatisfiedLinkError:
        
        likely because the jar file is trying to load libhsqldb.so instead of
        libmerged.so
        
        Change-Id: I9f42aea6471dbe35b27a584465b333a1d30caf5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-27  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c9d3e68481e4db0e732b9186b75b582a5b41271b]

        GPGME: upgrade to release 1.23.2
        
        Change-Id: I56c419fbbe615ef57b7d8117ccdc32f0daddf95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163840
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86b75e441cf14846c4e22b6271e9b9225f9e77c6]

        cid#1592377 Uncaught exception
        
        Change-Id: I61320896ddeeabed9f21798919bac0e0fecf32e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164015
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [75da0c3c576253c61092e762ead974c3600b15b4]

        related tdf#33603: do not register NotesChildWindow for Draw
        
        Draw doesn't need the notes panel introduced in
        c4c1ca58bb587a56a30c7f4817c346054ce37f2a, so don't register
        that for it's shell (GraphicViewShell).
        
        Change-Id: I062a54e806058f352721b89d7cffff10cece8612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163775
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [137247a4ef563547a591bf3af845cbaf21a1800d]

        cid#1592378 Logically dead code
        
        Change-Id: I4cab1e22f61113dd84b9ce77c639be5572ff9c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164014
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fbc6d6f9fc4e37d87e626e250ba317517a5f6b51]

        cid#1592379 Logically dead code
        
        Change-Id: I99de3457d0775da860ca8b1727a3ed120a2b28ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164013
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [edc45294fda1bb37cceb9bcf6355b4760e7ff712]

        cid#1592375 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9d110911504832d7a8a6725ca3f9040a4fd0c4c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Weblate  <noreply@documentfoundation.org>  [aa7f68514fa8a4c075b31d615379bf27df5e87bc]

        android-viewer translated using Weblate
        
        Czech currently translated at 54.2% (64 of 118 strings)
        
        Change-Id: Ie43869edb7fffb61603b1a00cf3d2d01397c634e
        Co-authored-by: raal <raal@post.cz>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163900
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5dc2fad7186ea5e03ae2aa453b14a3276b4a17d9]

        cid#1592381 silence Out-of-bounds read
        
        Change-Id: I437af59b956753eaadea61db12500e5e7b45d9b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164008
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dba077327bbb9bf31cf1b8d16807baa3bf64402e]

        cid#1592376 Uninitialized scalar field
        
        Change-Id: I8f62faac5a1170b9932afe08f03145e4ca7b1be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [60dd46ee18f98e4fc8ca0faa478911bfedf9ae13]

        Simplify a bit
        
        Change-Id: Id9640825e117531ed1b67db9e83349c556f291c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164004
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-27  Julien Nabet  <serval2412@yahoo.fr>  [dd8fc8e24bae35ad392482d797e7db994ca03ac8]

        Typo: alredy->already
        
        Change-Id: I67fa846c71cf91563c3457cec98195b1886e3fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164025
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-27  Julien Nabet  <serval2412@yahoo.fr>  [d5e012b85a20d467fd8c0e86689039eb8c79457e]

        cid#1592380 COPY_PASTE_ERROR
        
        Change-Id: Ib5c57ba2118531449908600b22fd49f52277159b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164005
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-27  Po-Yen Huang  <jeff.huang@ossii.com.tw>  [9adffb1c7453aee77f9d52b1ed0aa99191a9c317]

        tdf#158190 Fix Calc ROUND in floating-point calculate result very close to X.5
        
        Location:
             if (nDecPlaces == 0)
             {
                 switch (eMode)
                 {
                     case rtl_math_RoundingMode_Corrected:
                         return std::round(fValue);
        
        Because the functions are the same as the following
        related codes, they are respectively:
        
        if (nDecPlaces >= 0
                     && (fValue >= 0x1p52
                         || isRepresentableInteger(fValue)))
                 return fOrigValue;
        
        as well as:
        if (fValue < 0x1p52)
             {
                 switch(eMode)
                 {
                     case rtl_math_RoundingMode_Corrected:
                         fValue = rtl::math::approxFloor(fValue + 0.5);
                     break;
        :
        :
        :
        
        Because some double-precision floating point
        numbers cause std::round(fValue) and rtl::math::approxFloor(fValue + 0.5)
        to produce different results.
        
        For example, enter 10614.4999999999876 in Calc's
        A1 cell (or any operation that will produce a long
        decimal number such as .499999999999xyz after the
        decimal point).
        
        We expected it to be 10614.4999999999876, but it
        was automatically rounded to 10614.5 (note: this
        result is also the result of ubiquitous handheld
        computers, OpenOffice.org and Excel)
        
        Then, entering =ROUND(A1,0) in B1, we will see 10614,
        A1 and B1 clearly don't meet expectations. (My boss
        or tax collector might be unhappy :-p)
        
        Although A1's 10614.4999999999876 is still faithfully
        recorded, the rendering of 10614.5 is confusing.
        
        Now, there are two views:
        1. According to the established convention, B2
        displays the expected answer 10615.
        or
        2. True to the laws of mathematics, A1 displays
        10614.4999999999876 or at least 10614.49
        
        Although the second point of view is correct (and I
        completely agree with it), when opening
        spreadsheets generated by other software (such as
        OpenOffice.org or Excel), the results will be different,
        which people do not like to see.
        
        So when nDecPlaces == 0 is removed, use
        std::round(fValue) and let the existing code below it do the rounding:
        if (fValue < 0x1p52)
             {
                 switch(eMode)
                 {
                     case rtl_math_RoundingMode_Corrected:
                         fValue = rtl::math::approxFloor(fValue + 0.5);
        
        This is consistent with the first point.
        
        By the way, in nDecPlaces == 0
        case rtl_math_RoundingMode_HalfEven:
        This piece of code can be checked to see if it is really
        necessary, because rtl_math_round() also has the same purpose code.
        If it is not needed, the entire nDecPlaces == 0 can be removed.
        
        Co-authored-by: Firefly <firefly@ossii.com.tw>
        Co-authored-by: Franklin Weng <franklin@goodhorse.idv.tw>
        
        Change-Id: If32cdb18c70ec0025c83ba25a99e5d135d66aec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159193
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-27  Hossein  <hossein@libreoffice.org>  [8f7d4f1da306fc7e104050c96ae1538c3f04c52f]

        Check Windows SDK version
        
        Because of a regression in Windows SDK version 10.0.19xxxx which
        is now fixed in 10.0.20348, it is good to check that the
        required SDK version is installed:
        
        More information
        https://developercommunity.visualstudio.com/t/std:c17-generates-warning-compiling-Win/1249671
        
        It is important to know that both Windows 10 and Windows 11 SDK should
        work.
        
        Change-Id: Ia42843cac4f94c4db9ef429714f1b9d46ba3fd09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163770
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [8bbfbe92c01bff38ed2241da56560b84f7954beb]

        tdf#159908: return early to avoid nullptr dereference
        
        When aLvalue is not a variable, its GetRealVar() returns nullptr.
        That was dereferenced unconditionally later in the check of the
        variable after NEXT.
        
        Change-Id: Ia46f23a7e720431bf62ace998848b684aa8449e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164002
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-27  Attila Szűcs  <attila.szucs@collabora.com>  [0079f0e77e74a355d57b24d3a6b6d1a29f45eb79]

        tdf#67347 pptx import: stacked + horz/vert aligment
        
        In case of Stacked, PP calculates in the vertical direction
        with the horizontal alignment.
        
        We simulate it by setting TextVerticalAdjust at import time
        (from PPTX) based on the ParagraphAdjust of the 1. paragraph
        
        It is not perfect, because we have 1 TextVerticalAdjust / 1 shape,
        and it does not support justified,
        while we can have many ParagraphAdjust / 1 shape
        (if the shape have more paragraphs)
        
        For a better solution we should re-implement the entire stacked
        thing, but that is a much bigger task.
        
        Change-Id: I4011be0f118b870ab7f9e2ddc15c6dc5a21f8a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163934
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>

2024-02-27  Miklos Vajna  <vmiklos@collabora.com>  [a73b3994fb6a2cc10b2d65cbaad201762610cecc]

        Related: tdf#150408 DOC filter: handle legal numbering
        
        The bugdoc's 2nd para started with 'Sect I.01', while Word rendered this
        as 'Sect 1.01'.
        
        The reason for this difference is that there is an "is legal" boolean
        property on the numbering that we ignored from [MS-DOC] during
        import/export.
        
        Fix the problem by WW8ListManager::ReadLVL() and
        WW8AttributeOutput::NumberingLevel() to handle this, building on top of
        the existing DOCX work.
        
        RTF still needs doing.
        
        Change-Id: I57ec402c1dd829251afa639ddfa7fc6620da1125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164000
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5fbbc750ca96f0541e7bd81dd0657fac53803db]

        use getCommandValues instead of adding a getViewRenderState
        
        Change-Id: Ib6db5dd8ef1db2745cb3c616bb81b1ac2baf6504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163812
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a9386139613735c45765a540ce8fac98f5639d49]

        Fix typo
        
        Change-Id: I48f1487f11ba35b61327b148d51f8ecb4f36b78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163992
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a507daadb1e033eaccc24f0d0115f5010c58873b]

        Fix typo
        
        Change-Id: Id1e21804fb2bc93887892192e38b655c8654ed7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163991
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-27  Miklos Vajna  <vmiklos@collabora.com>  [3fb07fbd8edb7c048ca9e2ec5fa0a5206e05b8d0]

        sw: document SwFormatEditInReadonly
        
        What it is, which item set can contain it, where is the UI.
        
        Change-Id: I470b057418c551da78b174dd02a22206a18dd03f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163999
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-27  Justin Luth  <justin.luth@collabora.com>  [6931d41640e31db4f1ad07afb48ec4df7086f6bb]

        address nit: use boolean flag instead of minor copy/paste
        
        Change-Id: I380ca73047fecefd9b7ff508eb6f8bf8202b1b62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163969
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-27  Justin Luth  <justin.luth@collabora.com>  [9348677e040927a736e70797d07bb1de32d729ca]

        address nit: use oox::drawingml::PER_DEGREE instead of 60,000
        
        Change-Id: Ie3ca5a76376a3c26f0d3079b6e819ec29afd2c17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163968
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-27  Justin Luth  <justin.luth@collabora.com>  [2e073dc313cb2beaa7e4d2aef8584e7f76e9edee]

        address nit: create separate WriteDocumentBackgroundFill function
        
        Change-Id: I4e204dfee51987112f1a4a4a052a11349ae3f373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163966
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-27  Justin Luth  <jluth@mail.com>  [38083e4c0b5638d69162593c3fbf599da6cd499f]

        related tdf#126533 dml/vml import: import radials as radials
        
        ... and not as symmetrical linear gradients.
        
        The benefit is that our export code
        will be able to intelligently export it.
        
        Apparently RTF export code does not intelligently export axials,
        (now fixed - tdf#159824)
        but VML and DML (and doc) do it well.
        
        Unfortunately charts can be badly affected,
        (avoided by ignoring when transparent)
        and unit tests are implementation-tested...
        
        This affects existing unit tests:
        -tdf128345_Legend_CS_TG_axial.pptx: label imports fine:
            lost on export (no change)
        -tdf128345_ChartWall_CS_TG.pptx: wall gradient now looks axial:
            lost on export (no change)
        -textframe-gradient.docx: still round-trips OK: no change
        -textframe-gradient.rtf: round-trips as linear: lost axial-ness
         (now fixed: tdf#159824)
        -fdo78663.docx: textbox font fill: still exports as solid: no change
        
        I ran the assert check against chart2, oox, and sw
        
        Change-Id: Ib16e9488a76b006bf335ff01a38acf7cde69cccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163675
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-27  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c29d1d968acd53bd957eedc0d93bfaa620fc862b]

        Remove unused gb_CppunitTest_localized_run
        
        ...that appears to be unused ever since it got introduced in
        d8a8ed04b14390d4469ea19b079778fa6f074bb2 "gbuild allow unitest to run once per
        lang in WITH_LANG_LIST"
        
        Change-Id: Id43b8498ca68c274902dfb3dfd4b035e199cb9b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163993
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-27  AhmedHamed  <ahmedhamed3699@gmail.com>  [9786fb8b94889072c2f5b3a7d4724d9bab6c3261]

        tdf#145538 Use range based for loops
        
        Change-Id: I62ed915f3ac398ffdffb0a47e40ce23f0a893b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163885
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-27  Kohei Yoshida  <kohei@libreoffice.org>  [25ffb54c6d8a5b52dca6b782282962766e7791de]

        Make ScColumn::HasCellNotes() less expensive
        
        It's essentially the same idea as checking if the column has formula cells; by keeping track of the block creation and deletion events to
        count the number of cell notes block instances at any given moment, and
        use that information to see if the column has any cell notes.
        
        Change-Id: I95c5186bf1f21f23f85fa10ff3c2135388949c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163996
        Tested-by: Kohei Yoshida <kohei@libreoffice.org>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2024-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [a1a1d8edb9d4a62b747aa7069b3026e2ba75704d]

        Another attempt to ensure strict weak ordering when sorting
        
        The failure that Stephan noticed turns out to show a problem in the
        data - the use of the special LANGUAGE_USER_SYSTEM_CONFIG language
        type value. It should not appear in the sorted part of the list; if
        needed, it should be added explicitly, like the "default" entry is
        handled in SvxLanguageBox::SetLanguageList.
        
        So simplify the shortcut in GenericFirst::operator() again, and
        drop the special entries before sorting.
        
        Change-Id: If08e0ddbc5b597795e129fa4a2315c54205dab90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163964
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c279cad9484cce44cf11473478c6059d69013fd2]

        Remove duplicated include
        
        Change-Id: Id0e2c58678499fdda5d7bc61800d9586f06bb411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163990
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [4b3d6fadf0b984e7e1c438c682e15a99124b9642]

        a11y: Drop some AccessibleTextHelper_BASE typedefs
        
        Just use `comphelper::OAccessibleTextHelper` directly
        where `AccessibleTextHelper_BASE` is a typedef for that.
        
        There are other `AccessibleTextHelper_BASE` typedefs with
        a different meaning elsewhere in the codebase, which are left unchanged.
        
        Change-Id: I323a2b103eccfcfc4f726caffa73e586decf6d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163960
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [c455fcd88f950c87c1588859100c1310122980fa]

        tdf#159910 a11y: Distinguish a11y name and text of toolbar item
        
        So far, the accessible name and the text of the item
        were considered to be the same, and fallbacks to still
        get something else for the accessible name in case
        of no item text (to use the quick help text or the item
        window's accessible name instead) were implemented directly in
        `VCLXAccessibleToolBoxItem::implGetText`.
        
        However, `VCLXAccessibleToolBoxItem::implGetText` is also
        used by the implementations for the methods from the
        `XAccessibleText` interface and that one is clearly about
        text displayed on screen, so using e.g. the quick help/tooltip
        text doesn't make sense then.
        
        Let `VCLXAccessibleToolBoxItem::implGetText` only handle the
        actual item text and move the fallbacks to a new helper
        method `VCLXAccessibleToolBoxItem::implGetAccessibleName`
        instead that is only used when the actual accessible name
        is wanted.
        
        Change-Id: Icc394022d036ca619622cee1390e28ab15014be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163959
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [86dff3ca4e994f69bf9ba6656ac3e1164a29ca11]

        tdf#159910 a11y: Merge VCLXAccessibleToolBoxItem::{,impl}GetText
        
        `VCLXAccessibleToolBoxItem::implGetText` was just calling
        `VCLXAccessibleToolBoxItem::GetText`, and both of them
        were used from different places.
        
        Just move the implementation to `VCLXAccessibleToolBoxItem::implGetText`
        right away, drop `VCLXAccessibleToolBoxItem::implGetText` and adjust
        callers to unify this.
        
        Change-Id: I0f4a4652f9e1259826a566d42b4b6998fc8ac7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163958
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [625d22600d41a70f5c4a65bc75ef02b17c6cfae2]

        tdf#159910 VclBuilder: Add helper to identify toolbar item class
        
        Extract a new helper method `BuilderBase::isToolbarItemClass`
        to identify whether a widget class is one of those used for
        toolbar items.
        
        Related: Gtk's GtkToolItem doc [1].
        (But this commit just moves the existing logic without
        looking into that Gtk doc further.)
        
        [1] https://docs.gtk.org/gtk3/class.ToolItem.html
        
        Change-Id: I1e39e4afb13db374ae77a3cdb6a4dd9eca7ee3ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163957
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-26  Michael Weghorn  <m.weghorn@posteo.de>  [492a683c70d98d005bcb472770be33d3277499d7]

        tdf#159910 a11y: Slightly simplify VCLXAccessibleToolBoxItem::GetText
        
        * Avoid deep nesting by returning non-empty value right away.
        * Drop the `if (!sWinText.isEmpty())` before the last assignment.
          At this point, `sRet` is already empty, so reassigning an empty
          string makes no difference.
        
        Change-Id: Ib17e363f761e3ce09b359cebb1599042a8f6b8bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163956
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bd3dc6fc18a6360929e3427abccc572950d0aa8e]

        Fix --enable-coredumpctl in CppunitTest
        
        ...which 533e993f2d11814252c40d60bdab469de03b14db "Don't reuse --unit values
        across (sequential, even) systemd-run invocations" had broken by moving the
        setting of the LIBO_TEST_UNIT var to a place where the use of that env var would
        no longer see it.
        
        Fix it by making the individual LO_TEST_LOCALE=* tests of
        gb_CppunitTest_localized more autonomous.  Each one now has an individual log
        file and gets an individual gb_CppunitTest_postprocess treatment.
        
        Change-Id: Ie6875dda874e357426370d4d5166c05e36881210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163967
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-26  Julien Nabet  <serval2412@yahoo.fr>  [87109270ce08a1f50bb1b791ff6c5a0abc8db891]

        Revert "tdf#159874: Inspection of 3D object in Development Tools crashes LibreOffice"
        
        This reverts commit ff197bf1a9a8a6cd73fe0e1cc03c4424d9e1dc2e.
        
        Reason for revert: generates regression, see tdf#159911 (FILEOPEN: 3D object is displayed as black/white)
        
        Change-Id: I17d3d30efaf63d0f1598a1a94a2e5f0fac78119f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163849
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-26  Khaled Hosny  <khaled@libreoffice.org>  [1c7886d5d80389a876330a1d4a3a350a57126480]

        tdf#159251: Revert "vcl: Allow pushing/popping OutputDevice’s RTLEnabled
        
        ...state"
        
        This reverts commit 611694b707eb43e4c0f20b781f6869016a3ba099.
        
        Change-Id: I044e6a1fb08f482c6b494e87f9c23e2303b97fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163951
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2024-02-26  Justin Luth  <jluth@mail.com>  [7c3cdc88337959ddbb9799c4cee57901e94719f3]

        tdf#159865 Revert "tdf#136905 NBB: let ValueSetWithTextControl set optimal"
        
        ...height
        
        This reverts my 24.2 commit 1876feb8a8805b2f80537e2828c152ccbdf67fe2
        (as well as my initial attempt to fix it in 24.8).
        
        Change-Id: I70c3668393a13992f9ce489e86b07860218445b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163954
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-26  Khaled Hosny  <khaled@libreoffice.org>  [17d147952564e5cdfff035ead943b3816e998b96]

        tdf#159251: Don’t use vcl::PushFlags::RTLENABLED
        
        I’m going to remove it.
        
        Change-Id: I23af5c67633069b7bb6b15c88bdea757815816ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163950
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2024-02-26  Alain Romedenne  <alain.romedenne@libreoffice.org>  [b0dc696c7de09a629107799207118282b912b8dd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to acb79818f17b823827ff39871ea53ae3be0a9f1d
          - sf_calc documentation update
            
            Change-Id: I7646524df9ab75dd74d5e5ece0e3291f6f553ec9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163971
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [16e66bb1030557552e2d1ad69cbd50af03c81ab1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 51f773f0ed635d026283ec010bbbd973813dbf4b
          - tdf#156397 (part) Fix bad Help page for Writer-only UNO
            
            Commands .uno:ListStyle and .uno:ParaStyle are Writer exclusive and
            cannot be set as entry for Impress or Calc.
            
            Bookmarks removed from wrong pages.
            
            Change-Id: I672ec313e42119a9eadc1946e64c127900ad4d01
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163949
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b6adc921fe62cc49312ed679069d5b1d2fb9b83b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8bab0aaea4744d600a33a8c8a1941b114f4d6881
          - tdf#154069 Fix HID for New user index
            
            Change-Id: I578e2dca1a024dd10fafc88239fed97de5cd1f00
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163946
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Justin Luth  <justin.luth@collabora.com>  [589ac948c0650a16c734db7337c6c31b950be151]

        related tdf#126533 doc export: don't lose "tiled" aspect of image fill.
        
        This affects patterns as well as textures/images.
        
        make CppunitTest_sw_ww8export3 CPPUNIT_TEST_NAME=testTdf101826_xattrTextBoxFill
        
        Change-Id: I2742a6f333fc6688b3570772a1dbc8371741f210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163948
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-26  Noel Grandin  <noelgrandin@collabora.co.uk>  [e986447db7d6991c5551933b605101a86f3537d2]

        fix Windows release build
        
        no idea why this only started warning now
        
        Change-Id: I61c1de875c825a55d2ec41a358503354688183bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163933
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a031dd6f4b70d6675e47be52e0fbc9b7150b4bf]

        Fix typo
        
        Change-Id: Iff521a8cbd52b1d7c37d20c5ba5f93838a549e1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163935
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [633e37e07e234b16c58b32c8beb88534e5fd658b]

        CppunitTest_test_a11y: Missing test dependency
        
        Similar to 0249f00aacc008969eb9bca5905dc2fea99e27fe
        "Missing test dependency"
        
        Change-Id: I37813dab57abd589d1cd28f44c0e0940f871c14b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163932
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4ac24a6b7ea3af2fa5fe82f779cfaa294bbc6b6d]

        return early without error if no shape it selected on generating preview
        
        of current selection. Which can arise in calc on repeatedly
        double-clicking on a shape and pressing esc. Eventually there will
        be a case where the shape isn't selected by the time the preview
        generation is attempted.
        
        Change-Id: Ic92149b5e12f35fe69265b6c8df289819313a899
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dde9f306a2930922fa04eb294995f8f36c5a5592]

        Fix copy/paste error
        
        Change-Id: I267d5a7fa9150b16e9625b36c032fa48199758e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163937
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f944648e0f5d52605a267ed50bba4bfc035aecc6]

        tdf#108697 Allow modifying default bullet selection
        
        Allow to change bullets in configuration.
        
        Change-Id: Iab26118dd597417997d6f0a7355f516a4da97ee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163735
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0839be6c1d6d5439716596687aec9596d025808]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 62e7c7b640fb3bd3dd11207f3951f6512bea839f
          - tdf#156080 Fix broken link to Extension Update page
            
            Change-Id: I88988daea2f8c641a080029f96e8577952ae002b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163923
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a67958f9e0b223d482c7f4c86eb849d69f25e51b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cb24d887c855c8e8a1a9c2c31789b25091045e2d
          - tdf#159872 Prepare Help page for RANDARRAY function
            
            Contents will be added upon tdf#126573
            
            Change-Id: I54fed6b04b87f1dd5d9d7f344c022dd31a57b680
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163894
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3d91a8824529c765cf8cd3fb2527b291ce235ac2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9d95b32fab3fbf3c1e44d71d531185de4fb55e3
          - tdf#159872 Prepare Help page for SEQUENCE function
            
            Contents will be added upon tdf#126573
            
            Change-Id: Ifa8a0e984d4118aaa7b14e6e4a9cfe8c71023ef2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163893
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [45e8608b07a11c87947a6a1cbc7e225f58f2fc48]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ed3ec9e2c705950c3d161916ecec8b8d4bca7f0
          - tdf#159872 Prepare Help page for SORTBY, UNIQUE functions
            
            Contents will be added upon tdf#126573
            
            Change-Id: I93fd31c6bf3764a09921642cc245e8e51c1b6959
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163892
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d2230d26c5a3344f6916a173285d32e99fb1679f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e6a74b1f45911814ab8abcc4194fb71165332e8
          - tdf#159872 Prepare Help page for SORT function
            
            Contents will be added upon tdf#126573
            
            Change-Id: Ifcc953b22d44139b9dcb003971fc9fd3d43aa8f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163891
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [059e99f2dd0585ff654994f37af7d973f9f66c8c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60b83838ded8bba13a7d7f761383228640fdf42e
          - tdf#159872 Prepare Help page for FILTER function
            
            Contents will be added upon tdf#126573
            
            Change-Id: Ia488f8f855f19cef2f15f1004ff5719309576d8b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163890
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [245da1c8a4158ca193c472e014fa5a92cc90200a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a0b6f31df93d28945631938fd5dfb5c5687af1f1
          - tdf#156918 Help page for Shrink text on overflow.
            
            Change-Id: Ie895296f4d08d7df74adb96a4be23da0605e754b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163889
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ab897d8fa045878b5a58e64a2b6e0de90e38f73e]

        add getViewRenderState to LibreOfficeKitDocument
        
        so we can get the initial render state as it is when created
        
        Change-Id: I1202cbbf478bc4f62f4d587e1f2766c61f172cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163666
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit effe8f6e5cc5389b234a6e57540f935de4a6f201)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163843
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-26  Miklos Vajna  <vmiklos@collabora.com>  [d3b548fdd01d73778c8ae2512e9db024e47c52d2]

        svx: prefix members of XFillHatchItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I4e2251aa5488c76a270e01f48ed4ccc12fc56332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163930
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-26  Miklos Vajna  <vmiklos@collabora.com>  [b7c4c4d45f44a26283678f3dc32982b3a728c614]

        tdf#158986 sw floattable: fix RTF import of table followed by \sect
        
        The bugdoc had a floating table, immediately followed by a section
        break. The floating table went to the second page, should be on the
        first page.
        
        The trouble is that RTF's section break is just a special symbol, so we
        can have a section break right after a floating table. This is in
        constrast with DOCX where a non-last section break is a paragraph
        property, so it's guaranteed to have at least a paragraph start after a
        floating table and before a section break, which can nicely serve as an
        anchor point for the floating table.
        
        Fix the problem similar to what the OOXML tokenizer did in a similar
        case in commit 01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable:
        fix lost tables around a floating table from DOCX, 2023-06-05), by
        injecting a paragraph before the section break.
        
        Handling this at a tokenizer level seems to be the right place, since
        the DOCX version of the same document was already imported OK.
        
        Change-Id: Ic945c472c08ba872a5c46e2b8f75e919678aa0a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163929
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d751741571daa2954bd1ebe389fafd7a647e2ffe]

        Simplify a bit
        
        Change-Id: I660631d43230d9fcc58c405be5138e7d0b7605fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163928
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9a8f4fb40867889bb08e4c5e1a89f2dbbf27681a]

        external/freetype: nullptr-with-offset
        
        ...as seen during CppunitTest_xmloff_style,
        
        > workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1048:31: runtime error: applying zero offset to null pointer
        >  #0 in tt_var_get_item_delta at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1048:31
        >  #1 in tt_hvadvance_adjust at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1242:13
        >  #2 in tt_vadvance_adjust at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1278:12
        >  #3 in tt_face_get_metrics at workdir/UnpackedTarball/freetype/src/sfnt/ttmtx.c:319:11
        >  #4 in cff_slot_load at workdir/UnpackedTarball/freetype/src/cff/cffgload.c:660:11
        >  #5 in cff_glyph_load at workdir/UnpackedTarball/freetype/src/cff/cffdrivr.c:192:13
        >  #6 in FT_Load_Glyph at workdir/UnpackedTarball/freetype/src/base/ftobjs.c:1066:15
        >  #7 in _cairo_ft_scaled_glyph_load_glyph at workdir/UnpackedTarball/cairo/src/cairo-ft-font.c:2455:13
        >  #8 in _cairo_ft_scaled_glyph_init at workdir/UnpackedTarball/cairo/src/cairo-ft-font.c:2640:11
        >  #9 in _cairo_scaled_glyph_lookup at workdir/UnpackedTarball/cairo/src/cairo-scaled-font.c:3035:6
        >  #10 in _cairo_scaled_font_glyph_device_extents at workdir/UnpackedTarball/cairo/src/cairo-scaled-font.c:2250:15
        >  #11 in _cairo_composite_rectangles_init_for_glyphs at workdir/UnpackedTarball/cairo/src/cairo-composite-rectangles.c:476:14
        >  #12 in _cairo_compositor_glyphs at workdir/UnpackedTarball/cairo/src/cairo-compositor.c:280:14
        >  #13 in _cairo_image_surface_glyphs at workdir/UnpackedTarball/cairo/src/cairo-image-surface.c:1030:12
        >  #14 in _cairo_surface_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-surface.c:2920:15
        >  #15 in _cairo_gstate_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-gstate.c:2077:15
        >  #16 in _cairo_default_context_glyphs at workdir/UnpackedTarball/cairo/src/cairo-default-context.c:1334:12
        >  #17 in cairo_show_glyphs at workdir/UnpackedTarball/cairo/src/cairo.c:3670:14
        >  #18 in CairoTextRender::DrawTextLayout(GenericSalLayout const&, SalGraphics const&) at vcl/unx/generic/gdi/cairotextrender.cxx:477:9
        >  #19 in SvpSalGraphics::DrawTextLayout(GenericSalLayout const&) at vcl/headless/svptext.cxx:72:23
        >  #20 in GenericSalLayout::DrawText(SalGraphics&) const at vcl/source/gdi/CommonSalLayout.cxx:171:18
        >  #21 in OutputDevice::ImplDrawTextDirect(SalLayout&, bool) at vcl/source/outdev/text.cxx:312:16
        >  #22 in OutputDevice::ImplDrawText(SalLayout&) at vcl/source/outdev/text.cxx:463:9
        >  #23 in OutputDevice::DrawTextArray(Point const&, rtl::OUString const&, KernArraySpan, std::span<unsigned char const, 18446744073709551615ul>, int, int, SalLayoutFlags, SalLayoutGlyphs const*) at vcl/source/outdev/text.cxx:701:9
        >  #24 in SwFntObj::DrawText(SwDrawTextInfo&) at sw/source/core/txtnode/fntcache.cxx:1490:31
        >  #25 in SwSubFont::DrawText_(SwDrawTextInfo&, bool) at sw/source/core/txtnode/swfont.cxx:1144:24
        >  #26 in SwFont::DrawText_(SwDrawTextInfo&) at sw/source/core/inc/swfont.hxx:324:29
        >  #27 in SwTextPaintInfo::DrawText_(rtl::OUString const&, SwLinePortion const&, o3tl::strong_int<int, Tag_TextFrameIndex>, o3tl::strong_int<int, Tag_TextFrameIndex>, bool, bool, bool, bool) at sw/source/core/text/inftxt.cxx:730:21
        >  #28 in SwTextPaintInfo::DrawText(SwLinePortion const&, o3tl::strong_int<int, Tag_TextFrameIndex>, bool) const at sw/source/core/text/inftxt.hxx:783:41
        >  #29 in SwTextPortion::Paint(SwTextPaintInfo const&) const at sw/source/core/text/portxt.cxx:603:18
        >  #30 in SwTextPainter::DrawTextLine(SwRect const&, SwSaveClip&, bool, std::optional<SwTaggedPDFHelper>&, std::optional<SwTaggedPDFHelper>&, bool) at sw/source/core/text/itrpaint.cxx:433:23
        >  #31 in SwTextFrame::PaintSwFrame(OutputDevice&, SwRect const&) const at sw/source/core/text/frmpaint.cxx:787:23
        >  #32 in SwLayoutFrame::PaintSwFrame(OutputDevice&, SwRect const&) const at sw/source/core/layout/paintfrm.cxx:3804:21
        >  #33 in SwFlyFrame::PaintSwFrame(OutputDevice&, SwRect const&) const at sw/source/core/layout/paintfrm.cxx:4507:20
        >  #34 in SwVirtFlyDrawObj::wrap_DoPaintObject(drawinglayer::geometry::ViewInformation2D const&) const at sw/source/core/draw/dflyobj.cxx:541:18
        >  #35 in drawinglayer::primitive2d::(anonymous namespace)::SwVirtFlyDrawObjPrimitive::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at sw/source/core/draw/dflyobj.cxx:244:35
        >  #36 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #37 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:397:13
        >  #38 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:21
        >  #39 in sdr::contact::ObjectContactOfPageView::DoProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:284:31
        >  #40 in sdr::contact::ObjectContactOfPageView::ProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:120:21
        >  #41 in SdrPageWindow::RedrawLayer(o3tl::strong_int<short, SdrLayerIDTag> const*, sdr::contact::ViewObjectContactRedirector*, basegfx::B2IRange const*) at svx/source/svdraw/sdrpagewindow.cxx:421:28
        >  #42 in SdrPageView::DrawLayer(o3tl::strong_int<short, SdrLayerIDTag>, OutputDevice*, sdr::contact::ViewObjectContactRedirector*, tools::Rectangle const&, basegfx::B2IRange const*) at svx/source/svdraw/svdpagv.cxx:265:27
        >  #43 in SwViewShellImp::PaintLayer(o3tl::strong_int<short, SdrLayerIDTag>, SwPageFrame const&, SwRect const&, Color const*, bool, sdr::contact::ViewObjectContactRedirector*) at sw/source/core/view/vdraw.cxx:139:20
        >  #44 in SwRootFrame::PaintSwFrame(OutputDevice&, SwRect const&) const at sw/source/core/layout/paintfrm.cxx:3527:33
        >  #45 in SwViewShell::PrtOle2(SwDoc*, SwViewOption const*, SwPrintData const&, OutputDevice&, tools::Rectangle const&, bool) at sw/source/core/view/vprint.cxx:592:27
        >  #46 in SwDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short, bool) at sw/source/uibase/app/docsh.cxx:881:5
        >  #47 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:204:5
        >  #48 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:151:9
        >  #49 in SfxObjectShell::CreatePreview_Impl(bool, VirtualDevice*, GDIMetaFile*) const at sfx2/source/doc/objcont.cxx:198:40
        >  #50 in SfxObjectShell::GetPreviewBitmap() const at sfx2/source/doc/objcont.cxx:110:9
        >  #51 in SfxObjectShell::WriteThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::io::XStream> const&) at sfx2/source/doc/objstor.cxx:3850:31
        >  #52 in SfxObjectShell::GenerateAndStoreThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) at sfx2/source/doc/objstor.cxx:3808:33
        >  #53 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1531:19
        >  #54 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:3117:39
        >  #55 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:2907:9
        >  #56 in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t>>, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objserv.cxx:320:19
        >  #57 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3233:42
        >  #58 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1815:13
        >  #59 in UnoApiTest::saveWithParams(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:213:16
        >  #60 in UnoApiTest::save(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:178:5
        >  #61 in testWritingModeBTLR::TestBody() at xmloff/qa/unit/style.cxx:193:9
        
        Change-Id: I54d4d90e203127e018b99c34785602ac3d96e425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163925
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [db54b44c15ed234b54ed81998ec824f0770b1b3c]

        Fix indentation
        
        Change-Id: If70ef4b92e6998be5d18b8b557fab27c17bb11bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163747
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [fe4cd0cebdbf9412e26f8182e79f97bb844d94af]

        Set button label directly in ui file
        
        Change-Id: If9e22982f4f7c276d19167ff365e1b4e290e3de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163748
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-26  anish.deshpande  <anishmdeshpande@gmail.com>  [3d8e32a195203e4b540274b9024ced2bc364afb0]

        tdf#143148 Use pragma once instead of include guards in vcl and xmloff
        
        Change-Id: I317da0a6f626e8ddb3f090099347b130e99ff2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163856
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [8f6b4125819644ba91b1386170df1baa9a9c197d]

        Define a name for the extended path buffer size, instead of a literal
        
        Change-Id: If6d40c818e021b3241d6b6b33aceca07c6393511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163926
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [74185b8edf7f046a3372319da86a1d8ca0024c87]

        Link to oledlg, and use OleUIInsertObjectW directly
        
        ... instead of manually loading and using OleUIInsertObjectA.
        
        Change-Id: I597dd44e13edf8c94d83f434b57142c88e5aca6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163922
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a9e1fb692167d838a207abfd72ae04f2821b9dc6]

        Use filesystem::path to avoid MAX_PATH limitation
        
        And use a buffer of 32767 characters, which is the approximate maximum
        of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I7ee3283a98ebc72e7d79aacc65b01fdb7eeccd83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163919
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [119588ad23fc2a1e44e073b5f9de972c49f7ba60]

        Use filesystem::path to avoid MAX_PATH limitation
        
        And use a buffer of 32767 characters, which is the approximate maximum
        of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I7b5329d48c936ce0090f0c7908a9d08b56b5a734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163918
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [6cbb60688a90ee473563f5ee3f0950ed58eb41dc]

        Replace an instance of MAX_PATH (plus some) with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: Id166f425238e50d4131f72bcfd22b5268dea0c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163915
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [db10d71c1a456abe2cd3feafdea7951fac99b3bd]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I3e663088c07454d2488445c02c79f87c8f26be76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163920
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [ad4d3a960206e409a6bf3891e49147fc3ce822f7]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I2bfc2f2fa8a405ed36d6bb0c52f961028dd2fe6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163911
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d2b181f23f0ba1483066a8fc88d825b4f6b9db29]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I08b7a14ac2933f6bee57fe1f2df34d2efbe7f3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163921
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [08e2c56ced4e69a50b8235af3e34a52874c2a728]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I8b10e41d3a8bf85e266f071bdc2eb88eb9403917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163914
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [7411caca669a178f3b8b0eb99a65f24e3e601215]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I22aecd9b9e1423b74b61985cad11bb3c194f2bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163913
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [fa86d95014242225e4c61bf644d3c3197f13d10b]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I152b0b499374167720d73a475f2502e52fc5a5dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163910
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [3fef8ba99222f5c82d56b4acfb3a07afbaa8364b]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I78524891d89e34fb1569bf1d32161a96079f0f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163909
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [cb12053fc519ddeac07cabd76d178a2729ec14d1]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I5cd3c5e384005341aa2c39b18b3302521e71a805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163908
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [7dd7cdc7afc57fbcf6f0a23ea2b7a45d7d114a09]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I7029d18eaa721a0db1b1869cfe6425715e80eda1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163907
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [66590cba87d7a2b14207ed2cec2531f1d1addf40]

        Replace an instance of MAX_PATH with 32767
        
        ... which is the approximate maximum of Windows API, as documented in
        https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation
        
        Change-Id: I625ef246aa890f389d5f3a6b0b31456e8ae8b2b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163904
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d2fa44db6f8a1badece63856ee0f12db4cba9b28]

        Drop unused define
        
        Change-Id: I6e9c1075b37725686b79d9d1cdbecc4f9ee346ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163917
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [276f8ef88083e4ed9ab21989b2eb5de6222dbf5d]

        Use SHGetKnownFolderPath to avoid MAX_PATH limitation
        
        Change-Id: Icba230fedc9e6071d3817454f55d4533727e3aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163916
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [5e134896f35d5c3a194090f2af1b84fbaec8b432]

        Use SHGetKnownFolderPath, to avoid MAX_PATH limitation
        
        Change-Id: If7e70453bd67ec874fc06af7cd53a8c410a24e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163912
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [2468fe5d91880719e0addfc6c5ae2bfd1b141bb1]

        Remove an instance of MAX_PATH
        
        ... and avoid manual memory management.
        
        Change-Id: I6f056fd5bcc299c2c31aede227b29444ec3c5988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163906
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [c6e2626f7dab0097971d0dceea4326f185fdf1ac]

        Remove an instance of MAX_PATH limitation
        
        ... and avoid manual memory management.
        
        Change-Id: I901cfc1dbede3241d387003c04fa11c1371fa8d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163905
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [4114b916102d7df76f7a59b4d82435d9ab0ffec6]

        Revert "tdf#159752: Add missing NotoSans/NotoSerif fonts back"
        
        This reverts commit aa49b95cd1bb2baa357c9aac7e5d046630ffac85.
        
        Reason for revert: https://bugs.documentfoundation.org/show_bug.cgi?id=159752#c8
        
        Change-Id: I3f62e179240419d6cc19d9db2bf6d07673d48e05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163838
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-02-25  Jim Raykowski  <raykowj@gmail.com>  [a75ad49a45e7b632820de2f046534b7ff2687424]

        tdf#159875 SwNavigator: improve toggle master view visibility handling
        
        This patch sets the visibility of the toolbar container that contains
        the 'Toggle Master View' toolbutton in the first row of the Navigator's
        toolbox tools as opposed to the current method of setting the
        toolbutton item visibility. In this way extra space is not given to the
        toolbar when it is not visible.
        
        Change-Id: I6f2ff97728698b3de4812bb9524b2489beac24ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163898
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fe47872aa8380567af7f453b9d3466cf7acd0d12]

        update credits
        
        Change-Id: Ie2fc3de7861b870d5a4b2aa9943af7401f21a1b7

2024-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [47bfbbdb73380335196887b36c4d14530c0461ec]

        Create an UNO service to do the cui symbol lookup in vcl
        
        which means I can remove one usage of gb_Library_set_plugin_for, which
        is blocking linking the cui module into --enable-mergelibs=more
        
        Change-Id: Ic6cd48377627f94747037c7247a1cd398738b390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-25  Julien Nabet  <serval2412@yahoo.fr>  [ff197bf1a9a8a6cd73fe0e1cc03c4424d9e1dc2e]

        tdf#159874: Inspection of 3D object in Development Tools crashes LibreOffice
        
        See bt:
        https://bugs.documentfoundation.org/attachment.cgi?id=192752
        
        2 remarks here:
        - there are TextureKind.idl and TextureKind2.idl but first one is indicated as deprecated since 2000!
        (see 4f9e6d84feb36ab3072dafbab0ba4ae46d264f9b #80594# added a new TextureKind2 enum because of missing value in TextureKind)
        => should we only use TextureKind2.idl now?
        
        - in svx/source/sdr/primitive3d/sdrattributecreator3d.cxx, we can read this comment:
        // TextureKind: 1 == Base3DTextureLuminance, 2 == Base3DTextureIntensity, 3 == Base3DTextureColor
        See https://opengrok.libreoffice.org/xref/core/svx/source/sdr/primitive3d/sdrattributecreator3d.cxx?r=05416682#88
        but TextureKind2.idl defines LUMINANCE, INTENSITY and COLOR with no number,
        so I expect they take by default values 0, 1 and 2
        See https://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/drawing/TextureKind2.idl?r=5687eba4
        
        BTW, same pb with this line:
        // TextureMode: 1 == Base3DTextureReplace, 2 == Base3DTextureModulate, 3 == Base3DTextureBlend
        TextureMode.idl just indicates: REPLACE, MODULATE and BLEND
        
        => should we change comments and related code?
        
        Change-Id: Ia514890c131ab9f6fb239c7451335503c9b0e3cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163903
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-25  Khaled Hosny  <khaled@libreoffice.org>  [a7e2f44d64e729027fac0cfeaa896d5d76385a6a]

        tdf#124591: upgrade NotoKufiArabic to v2.109
        
        https://github.com/notofonts/arabic/releases/tag/NotoKufiArabic-v2.109
        
        Change-Id: Ifc6d9b6ec3e41dac27406b7582734c2cfd173a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163878
        Tested-by: خالد حسني <khaled@libreoffice.org>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2024-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [cdb1d686ec01e305822bbbf386f6bed7ae0a0ea4]

        Unescape double quotes escaped by another double quote in defines
        
        Otherwise, e.g. SRCDIR is defined as ""C:/lo/core"", which is not a
        proper string literal.
        
        Change-Id: Id7b503ea21735892b504dbc861f66c250db01e94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163902
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ffedea2e6cb8f66ab83feb4a12108e18c6d80b85]

        Fix typo
        
        Change-Id: Iea7feb1dc196932b888b7b57c0ae297b5c1dd52f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163888
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [3234c4e35fe97cffb87f785614b3b593e2237310]

        Avoid MAX_PATH limitation in launcher
        
        ... and drop some manual memory management.
        
        Change-Id: I4c60ce559ff185d4685a6b9799a97651438115b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162502
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [f894670c2cb654a1e21fb34f440977af74e8a560]

        Avoid UTF-16->UTF-8->UTF-16 conversion
        
        Change-Id: I82e45643b3543d924fda025aa47ef2fabb7f914e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163897
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [1cdf33d7485ec45c9ddcfcf7d1445f5b0a69dfec]

        Simplify boost includes, and drop unneeded warning suppression
        
        Likely obsoleted by commit 046e9545956d8ad1d69345d6b4a4c0a33714d179
        (Try to revert to use of file_iterator from boost on Windows, 2023-11-01).
        
        Change-Id: Icddb21203755845f6d3c46ba168fb51443f04251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163896
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [3502484d53d0fdb8868f9bdfd35da99616451614]

        Use SAL_WNODEPRECATED_DECLARATIONS_(PUSH|POP)
        
        Change-Id: I2810d22e8f5e1c81647b9e9b15519de65939630a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163895
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-25  Luv Sharma  <luvsharma.del@gmail.com>  [907c5d684daeb055183abb9175405c6d68fb1f49]

        tdf#45904 Remove old SwXFootnote Java test
        
        Change-Id: Ie7083f8fbefd731f3d7f2f1c246e39c37cd684fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163881
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-24  Jim Raykowski  <raykowj@gmail.com>  [61f34fde10e6f5cad7d23826b4dad716fef43e6c]

        tdf#141728 follow up: provide a bit of space between controls
        
        Provides space between the 'Navigate By' and go to page spin control
        without there is none for non gtk VCL backends.
        
        Change-Id: Ia9a07f0699c9dc174179a9789b4ae7ae6c1300af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163799
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-24  Justin Luth  <justin.luth@collabora.com>  [72986a5e505f8b62b30aa890c136e07cef3f9a2b]

        tdf#159865 tdf#136905 NBB: font looked too small in page size choices
        
        This fixes my 24.2 regression
        from commit 1876feb8a8805b2f80537e2828c152ccbdf67fe2
        
        I considered reverting it, but decided to tweak the font size instead.
        If I reverted, the size of the choices was displayed in 16pt font.
        
        I wanted to keep the sizing as "scientific" as possible,
        but fixing the rounding issues didn't really make the font
        stand out as much as desired.
        In this case, my system font of 11 became 10 for the page size dialog,
        due to rounding, which is still a significant 10%.
        
        Although that still looks too small, it seems fairly close
        to the other button on the notebook bar, at least to my eyes.
        But it is definitely smaller/less clear than the "more option" button.
        
        Perhaps it has to do with the visible size of a font
        compared to the full size (with leading)? Fonts are often
        sized as 11/13 or 12/14 for example.
        Adding 20% to the font size makes it look about right.
        In my case, it ends up chosing a font height of 13.
        
        Change-Id: Ic0a7296aa74be542e2a38ce52cf5fd23e5d8c7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163886
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4287eb60ca1073a7a04bb552ad31e2ed1c3979d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 62cfd5d6512a99cfa88a558d74b3bb335315e1ee
          - tdf#134377 Fix bookmark in native file explorer dialog
            
            Change-Id: I47e06c8534d444a828d50c4dfc8e8b4c49d7fdab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163880
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-24  Patrick Luby  <guibmacdev@gmail.com>  [3e2dde97bc15f156837d10bf4456deb81f7f554a]

        Related: tdf#159529 eliminate possible memory leak
        
        Despite confirming that the release function passed to
        SkBitmap.bitmap.installPixels() does get called for every
        data array that has been allocated, Apple's Instruments
        indicates that the data is leaking. While it is likely a
        false positive, it makes leak analysis difficult so leave
        the bitmap mutable. That causes SkBitmap.asImage() to make
        a copy of the data and the data can be safely deleted here.
        
        Change-Id: Ib28d70bd5f51e6d3be7a7d7c0d5923d71a6e5390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163774
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-24  Noel Grandin  <noelgrandin@gmail.com>  [0249f00aacc008969eb9bca5905dc2fea99e27fe]

        Missing test dependency
        
        Change-Id: I65d41949fb031f41591b1daab6ecad7fab3405a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-24  Khaled Hosny  <khaled@libreoffice.org>  [6cad38dece31eb035a9685ed8d123a74a0b69637]

        tdf#159251: Blind fix
        
        Hopefully fixes regression introduced in:
        
        commit 611694b707eb43e4c0f20b781f6869016a3ba099
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Aug 17 17:39:29 2023 +0300
        
            vcl: Allow pushing/popping OutputDevice’s RTLEnabled state
        
        Change-Id: I9236bd6951d83a512390934127031204d94d14bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163877
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2024-02-24  Justin Luth  <justin.luth@collabora.com>  [fe84ced08668ef0030fbd37bea52424fd86c8e7a]

        tdf#126533 rtf import: page background fill
        
        I worked on this mainly to see what the impact of the
        docx changes would be on RTF.
        It seemed to be OK. This patch shows that RTF
        can now import gradient page backgrounds.
        
        It does NOT import image backgrounds
        (at least no the ones I tested)
        because they were specified as
            XML_sn: fillBlip
            XML_sv: <shape_as_text_string>
        which is an unknown property in RTFSdrImport::resolve.
        
        The only fill type that RTFSdrImport::resolve knows about
        is XML_gradient.
        
        The only existing unit test I noted was
        page-background.rtf
        
        Change-Id: Ie40b91468d21b29a102472c859cd1eecfcb2a5f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163199
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-24  Julien Nabet  <serval2412@yahoo.fr>  [dd5710a8dd4e05059ac248243d950e28d830905d]

        tdf#159862: set SearchWildcard to false changes SearchRegularExpression value
        
        Like this since 2016 with 3a0abd3019ec3ca29b8f1378cdb32ebf741e6306
        add SvxSearchItem::GetWildcard() SetWildcard()
        
        Change-Id: Id988a6e58488af6b1f274a318e9d1f52c7a8b169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163876
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2cacf0456f79540ced611be84504d11b94ebe6f]

        move this header inside the module
        
        it is not used anywhere else
        
        Change-Id: I46cc42397cf56237818e6e58268a856e826a9985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [abf23c8f9551a86246529e105fa38e7cb5894819]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93aacd69104e0b1ad7d9e6279c8f0681456cc199
          - tdf#155883 "Navigate By" in Find Toolbar
            
            Change-Id: Ib0330a2b13345f860557b2406f0694b79ace7fb0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163858
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-24  Michael Stahl  <michael.stahl@allotropia.de>  [5c4ae1b19c51dcd62dad8e1d3e8beb87a0311352]

        tdf#147731 sw: fix memory leak in SwDoc::CopyPageDesc()
        
        Commit 963de9feb37105560fde14b44d992e47f341bb5b "sw: fix issue with
        copying stashed frame format" fixed the actual bug here, but introduced
        a new memory leak.
        
        This causes an assert in CppunitTest_uiwriter3:
        cppunittester: svl/source/items/itempool.cxx:779: void SfxItemPool::Remove(const SfxPoolItem&): Assertion `rItem.GetRefCount() && "RefCount == 0, Remove impossible"' failed.
        
        The assert happens only when this is backported to the libreoffice-7-6
        branch, because commit ab7c81f55621d7b0d1468c63305163016dd78837 "ITEM:
        Get away from classic 'poolable' Item flag" removed the assert.
        
        The problem is that a SwFormatFrameSize inside a footer SwFrameFormat is
        leaked 4 times, because 4 SwFrameFormats are leaked; the leak is that
        SwDoc::CopyPageDesc() creates a new pNewFormat, passed it to
        StashFrameFormat(), which copies it but doesn't free it.
        
        There is also a usage of std::shared_ptr here that is very questionable;
        SwFrameFormat should never be shared between different SwPageDesc.
        
        (regression from commit b802ab694a8a7357d4657f3e11b571144fa7c7bf)
        
        Change-Id: I44133bc5e6789a51ce064f1aa5ea8b325224365b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163854
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-24  Noel Grandin  <noelgrandin@gmail.com>  [ce6f91863fb7ad1c1f129a23202aefeba3378dbc]

        remove dummy accessibility factory
        
        because when the dynamic symbol lookup fails, the dummy factory
        returns nullptrs to code expecting valid pointers, and end up with
        a much harder bug to diagnose, instead of failing at the actual
        problem site.
        
        Change-Id: I8e4885dc192b7089e1b1716567b41420309e8984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [66e34e795689c92283644d379bdbbbc587cd8b34]

        Fix typo
        
        Change-Id: I4d15f9f31c782ffd2b6f4c5decc3ba3e4891f41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163873
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d7d93e846c89f96dfcb4bda9dc52bc11d21d5237]

        Fix typo
        
        Change-Id: Ibf6edff9b32cb28f5410991493a95d0cc916209d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163872
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-24  Patrick Luby  <guibmacdev@gmail.com>  [ef57aeb9ed190e18ebc034b9a45e190aea3f8f1d]

        tdf#158124 KEY_DELETE events do not need an ExtTextInput event
        
        When using various Japanese input methods, the last event will be a
        repeating key down event with a single delete character while the
        Backspace key, Delete key, or Fn-Delete keys are pressed. These key
        events are now ignored since setting mbTextInputWantsNonRepeatKeyDown
        to YES for these events will trigger an assert or crash when saving a
        .docx document.
        
        Change-Id: If3762fcf41aa82bf4aa5dc7d1f15c1d282c86f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163875
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-24  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c68712d3689a0322e59934cd8151d003e869f30d]

        IASS: make live slideshow experimental and configurable
        
        * adding an option button to slideshow settings dlg
        * switch from env var to officecfg
        
        Change-Id: I9713fde374b04264947daaab73759eb585c4a3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163851
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [922b0ecd52652e9f1bc558f846f4696f0c49b823]

        NotoSansGeorgian: upgrade to v2.005
        
        Change-Id: I1af4057b070b482eb889597d5a3084afb6dc27ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163823
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [eb35b4293ebcd322cb13ffe19913841a8c99b3dd]

        Add a favicon to the Wasm build
        
        ...to avoid "GET http://localhost:6931/favicon.ico 404 (File not found:
        instdir/program/favicon.ico)" errors in the browser console.  The checked-in
        static/emscripten/favicon.ico is a copy of
        <https://www.libreoffice.org/themes/libreofficenew/favicon.ico>.
        
        Change-Id: Ib40b3f159879cc39244bd81d7fc8a36cc8c7184a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163827
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0d8d71ba986d6c3d4a460d980e2709b9051ba989]

        Emscripten: Filter out some configuration
        
        ...that was present in instdir/share/registry/res/registry_en-US.xcd but for
        which the underlying instdir/share/registry/*.xcd files are not included in
        static/CustomTarget_emscripten_fs_image.mk, so causing
        
        > warn:configmgr:42:1:configmgr/source/xcuparser.cxx:292: unknown component "org.openoffice.Office.PresentationMinimizer" in "file:///instdir/program/../share/registry/res/registry_en-US.xcd"
        
        etc. in the browser console.  (This commit just hides those .xcu behind
        ENABLE_WASM_STRIP_* for which localizations ended up in
        instdir/share/registry/res/registry_en-US.xcd and caused the above warnings.  It
        does not clean up the mess further.  Also note that the list of files to include
        in static/CustomTarget_emscripten_fs_image.mk is largely hard-coded, so somewhat
        guessing at the right ENABLE_WASM_STRIP_* to use here.)
        
        Change-Id: I1781f5cb530fe251e63bcad456c2ab1735cf1b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163852
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [07deeedadda3d5d6b37b281c8d93060c1229ac7e]

        Emscripten: Filter out some filter configuration
        
        ...for which the underlying .xcd files are not included in
        static/CustomTarget_emscripten_fs_image.mk, so causing
        
        > warn:configmgr:42:1:configmgr/source/xcuparser.cxx:904: ignoring modify of unknown set member node "StarOffice XML (Base)" in "file:///instdir/program/../share/registry/res/fcfg_langpack_en-US.xcd"
        
        etc. in the browser console.  (Though note that the list of files to include in
        static/CustomTarget_emscripten_fs_image.mk is largely hard-coded, so somewhat
        guessing at the right ENABLE_WASM_STRIP_* to use here.)
        
        Change-Id: If3d506514ccdbacb7e64cf62b08093831640c572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163829
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [36de604067b5b76de90a09ab8a1760623c9a4afe]

        NotoNaskhArabic: upgrade to v2.018
        
        Change-Id: I213d743bd01d1e85044fe88e5061f53a79672776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163824
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-23  Justin Luth  <jluth@mail.com>  [6dd6891a3deed8718bf2b0fcf564f229f676f8ba]

        related tdf#126533 tdf#159824 VML: don't export: negative angles
        
        and stop an automatic 180 reversal on import.
        
        Some documents had gradient reversals on every round trip,
        typically when the angle was 0-179
        (mainly seen in ODT examples,
        since DOCX/RTF imports defaulted to be angle 180).
        
        The negative sign has special meaning,
        indicating that the start and end colors
        should be swapped.
        
        Well, swapping colors was not intentional in the export logic.
        Previously there was a mistaken idea
        that any angles > 180 needed to be swapped on import,
        and likely that is what prompted this overly complicated formula
        to try to avoid any angle > 180 during export
        by allowing negative angles.
        
        This tdf#126533 patchset has already eliminated import checks
        for angles > 180, so now a sane formula can be applied on export.
        
        In order to do that, we have to avoid emulating color swaps
        with 180 degree rotations at import time.
        So ONLY do color swapping with start/end,
        and leave the angle alone.
        That GREATLY helps unit tests (which otherwise would flip-flop
        the angle and the color start/stop).
        
        Very unhelpful was an undocumented, indecipherable
        inversion when converting to DML angle.
        
        Boy, I hope I got this right...
        
        make CppunitTest_sw_rtfexport8 \
           CPPUNIT_TEST_NAME=testTdf159824_gradientAngle3
        make CppunitTest_sw_rtfexport8 \
           CPPUNIT_TEST_NAME=testTdf159824_gradientAngle4
        make CppunitTest_sw_ooxmlexport7 \
           CPPUNIT_TEST_NAME=testTdf126533_axialAngle2
        
        Eliminating the inversion for ooxml7 test is fine
        since inversion does nothing to an axial.
        
        Otherwise, eliminating inversions corresponds to a color swap.
        
        Change-Id: I2aae0a7595807569ffc740689ff3840692d6159d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163798
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-23  Justin Luth  <jluth@mail.com>  [695f8fb19d839efe03a402d2a7e7ef73b6d8f436]

        related tdf#159824 RTF import/export gradient angle
        
        The fillAngle is important for obvious visual reasons,
        but also significantly because a negative angle
        means that the start/end colors should be swapped
        (which is the normal case since
        LO's 0 degree angle == -180 VML/RTF angle).
        
        There were no existing unit tests with a "fillAngle" specified,
        or with a non-180 angle (0 VML/RTF angle) in LO.
        
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf159824_gradientAngle1
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf159824_gradientAngle2
        make CppunitTest_sw_rtfexport8 \
            CPPUNIT_TEST_NAME=testTdf159824_axialGradient
        
        Change-Id: I4bb2c47bd2a79833d11bedac72ba2152b65b7c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163714
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-23  Alain Romedenne  <alain.romedenne@libreoffice.org>  [97bd13cb5ee3889f1bbd7c2241adffa6b0192233]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccaaa4f92689eb5d0de49bf4f47808fac6b63513
          - ScriptForge help typos
            
            - ScriptForge.Document.FileSystem property applies to Base docs too
            - ScriptForge.Base.FormDocuments() method requires a precision
            
            
            Change-Id: Ifad3a6008e9fba37b9ca49ce144ac7b4421b5124
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163835
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-02-23  Jim Raykowski  <raykowj@gmail.com>  [45e3abcb79fb1ccf7d813a7b080a8ad70bdcb5b1]

        tdf#159837 Make keyboard shortcuts work when focus is in toolbar
        
        for SalInstanceBuilder based VCL backends
        
        Change-Id: I36764e7199a0f7292b331da3d187fbe939b4becc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163800
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fda653f6e1e7a7e3c0db037cb2d0046a1790e641]

        loplugin:fakebool
        
        Change-Id: I7c33373dab95431b2b9df4565314d64a414375aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163850
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f4aee67494aa4defbc4d23aebc41bf9571e29d3b]

        Undo "move selection of UNO header variant to platform"
        
        ...from 86f4727920ae515987005e3c414f1d6056079be1, as all the platforms define
        gb_UnoApiHeadersTarget_select_variant in effectively the same way, anyway.  (And
        whether or not any of this actually makes any sense the way it is currently
        done.)
        
        Change-Id: I3b53ed3ee58b1115da31839aba5b2852dfe40920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163826
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [eea7dfeabe47e645334e625bc2620cc987ded516]

        Fix build
        
        ... after commit 8b191a6566065438417665af32fa30f8346ad4df and commit
        ff23937c34d8d6a0870bb326a52192535f7b4810 collided.
        
        Change-Id: If7001d7a3231041f77856fc6c1914c33c430197b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163828
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Dr. David Alan Gilbert  <dave@treblig.org>  [56f45bf76f6cd6683e81b9d30131a7a4c5696340]

        CppunitTest_sw_pdf_test: Add dependency on xpdfimport
        
        The missing dependency would trigger the failure in:
        
        ::HybridPdfTest::testNoHybridDataInPDF
           warn:sal.osl:3173303:3173368:sal/osl/unx/process.cxx:349: Failed to launch child process, child reports ENOENT
              ? Couldn't exec xpdfimport?
        
        Change-Id: I5e887129d2119c71b993d9a3e26b9b17bb912452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163771
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [80d3f33876a2ad4ce32d3c6183131984e8c6b5da]

        Library_embindtest should use comprehensive InternalUnoApi_embindtest
        
        ...as the workdir/UnoApiTarget/embindtest.rdb type library would not be
        available at runtime
        
        Change-Id: Ie674ff212b1303c8925136235446cc97447b0897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163815
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4603aa28888ed7e3ed4fe0163b9296065067b03e]

        use more string_view in tools::JsonWriter
        
        Change-Id: Ia3ac54a1164b99a806298a47115ea3bc570f3b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163810
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [822b221b3d32b3526e6cc61021ad250902342bbf]

        Abort if type information is missing when creating sequences
        
        When the typelib_TypeDescription is null, the following code would dereference a
        null pointer anyway (but which doesn't necessarily cause an immediate crash on
        some platforms like Wasm, so better be explicit).  (Also, leave those checks out
        of functions like uno_type_sequence_realloc, which would have been preceded by a
        call to one of the functions creating a sequence of the given type, and which
        would thus already have detected failure to obtain the relevant type
        information.)
        
        Change-Id: I36193ea837edeca451fd09a866623cf40d3cdb4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163813
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa49b95cd1bb2baa357c9aac7e5d046630ffac85]

        tdf#159752: Add missing NotoSans/NotoSerif fonts back
        
        They were dropped in 69943f33bf219558d6b219f0eaeda1e25e487b05
        "tdf#124591: Update Noto Sans to v2.012" and
        96aba2de78ffa641f6c0c898b99158715b2f2703
        "tdf#124591: Update Noto Serif to v2.012"
        for no apparent reason.
        Re-add them since they are still available upstream
        
        Change-Id: Ifd5eb72bd95be96f2ff965b17846cf76aacb0c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163825
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [dbe36ccb6ef1c23eafcadc070fab26c2b859e295]

        freetype: upgrade to 2.13.2
        
        Change-Id: I06fe1d1bdd1d7924213b219e25a9b3b9d8562a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163817
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-23  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [992b01c2c20c159299b4815e32efe0ac9b57a896]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a7bbc45948d6e0e6f5ba22aa38d2587e1f4053fe
          - tdf#159476 Basic IDE options are out of experimental
            
            Change-Id: Icf6b9ff6f4cf09a185b461ba93123f0ef0dc1d61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163765
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b9615995847b40d0fc166aa3eb32bc319e8a605]

        NotoSerif: upgrade to v2.013
        
        Change-Id: I31643604b5e749bae0074b5fedd27d70aa3d5a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163821
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f284d66e8b2ecee5a8333423c1288067803c80f6]

        NotoSans: upgrade to v2.013
        
        Change-Id: I89ba2a1e10117b74a136cba2f278dce79b480f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163819
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [24cd81bc29c440a537e12cbd163aea1b5d68e891]

        unoembind sequence tests
        
        Change-Id: I151969acde242bc9c7ee88e2b2da44c8c2101456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163816
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7d0f92545373941637879cbfb1f907f3f35604d6]

        Propagate by-ref Sequence::operator[] return type through lambda
        
        Change-Id: I029ae2ff5ab6f73681afc5920dc9aba90cd32539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163814
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  Weblate  <noreply@documentfoundation.org>  [4a90f9044a6226088ab42744c226b6fa57b7cc3f]

        android-viewer translated using Weblate
        
        Czech currently translated at 52.5% (62 of 118 strings)
        
        Change-Id: I867b990871692eb3947b48ca51e65716023bf6cc
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163795
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [203e21735ffc031d4689208ec39d9b24572d447d]

        Fix dead links
        
        Change-Id: I5c42fa227401e271bf8d4ce84f42a0667b37a6c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163803
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Oliver Specht  <oliver.specht@cib.de>  [8b191a6566065438417665af32fa30f8346ad4df]

        tdf#159793 Save printer paper tray in RTF and DOCX
        
        Saves the paper tray id as w:paperSrc w:first and w:other in docx
        and \binfsxn and \binsxn in RTF
        Change-Id: I79004f54aba3b6609d7921afacf815726f7f2678
        
        Change-Id: Ie3c11fffa6a133250b7db69b4e845bccaa8e2280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163654
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-23  Szymon Kłos  <szymon.klos@collabora.com>  [0feb1b2c4a11317159195e451bf7a1a0dd755dd8]

        jsdialog: don't duplicate MessageDialog messages
        
        Remove hardcoded out-of-queue message for MessageDialog.
        Now we send the messages in JSMessageDialog::run().
        This prevents us from overwriting correct jsdialog window
        in Online when we see messages before document was loaded
        (from interaction handlers, like: macro warning, corrupted
        file, etc.)
        
        Change-Id: I364ac8460507dd6613b978230c9cf61cc5dfe91d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163679
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 5ee46b44d207a0416623a5c506bb2052052500a7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163767
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-23  Gülşah Köse  <gulsah.kose@collabora.com>  [7e406cf5df7d5110a2cbf85463efa042ef18640f]

        ONLINE: Add calc formula tooltip support.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I1f3c438f5152e2b372212d003c1ec4e74e4d3ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163651
        Tested-by: Jenkins

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [39d18384121768460775b5ec320e444b022f5646]

        Suppress linker warnings for CLR objects
        
         climaker_app.o : /DEBUG:FASTLINK is not supported when managed code is present; restarting link with /DEBUG:FULL
        
        Change-Id: Ia4c8ef862999650b317629273996166908232494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163804
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [b889b33d928e49ba568ee1277c70d653083a2453]

        Do not suppress newer compiler warnings on Windows
        
        This partially reverts commit 133610669b8707a278d9b3b0af025779044fd8c5
        (windows: silence new warning for now, 2016-02-21). That commit had
        disabled warnings introduced after VS 2013 (compiler major version 18).
        
        For now, it was impossible to remove the -Wv:18 from CLR flags. Also,
        some warnings in Boost were suppressed in vcl/source/window/layout.cxx:
        
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(615): error C2220: the following warning is treated as an error
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(615): warning C4459: declaration of 'extents' hides global declaration
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/base.hpp(69): note: see declaration of 'boost::`anonymous-namespace'::extents'
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array/multi_array_ref.hpp(612): note: while compiling class template member function 'boost::multi_array_ref<T,2>::multi_array_ref(T *,const boost::general_storage_order<2> &,const __int64 *,const unsigned __int64 *)'
         with
         [
         T=`anonymous-namespace'::GridEntry
         ]
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array.hpp(153): note: see reference to function template instantiation 'boost::multi_array_ref<T,2>::multi_array_ref(T *,const boost::general_storage_order<2> &,const __int64 *,const unsigned __int64 *)' being compiled
         with
         [
         T=`anonymous-namespace'::GridEntry
         ]
         C:\lo\build\workdir\UnpackedTarball\boost\boost/multi_array.hpp(122): note: see reference to class template instantiation 'boost::multi_array_ref<T,2>' being compiled
         with
         [
         T=`anonymous-namespace'::GridEntry
         ]
         C:/lo/core/vcl/source/window/layout.cxx(905): note: see reference to class template instantiation 'boost::multi_array<`anonymous-namespace'::GridEntry,2,std::allocator<T>>' being compiled
         with
         [
         T=`anonymous-namespace'::GridEntry
         ]
        
        Change-Id: Ibf89e3d3e5a2f6a747bb7fbd214a9b27d8068901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163717
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Justin Luth  <jluth@mail.com>  [9ba68c769d41d1075152a22bf37e78fb9320317b]

        tdf#159824 MCGR rtf export: don't lose gradient's axial-ness
        
        This fixes alg's 7.6 regression from
        commit bb198176684c3d9377e26c04a29ec66deb811949
        
        Found when trying to import these strung-out-linears
        as real axials.
        
        make CppunitTest_sw_rtfexport \
            CPPUNIT_TEST_NAME=testTdf159824_axialGradient
        
        Change-Id: I220f1bf689b4b219bc0ae187e95aedb1a29a7233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163705
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-23  Justin Luth  <jluth@mail.com>  [b8071eef3b40c9fb2b161901aba9d9105317441f]

        related tdf#126533 vml export: fix axial colors
        
        This is a follow-up from the earlier tdf#65295 clone
        which removed swapping colors on IMport for axials.
        Well, tdf#65295 had also removed EXport swap for the linear case,
        so, now that import doesn't swap, remove the axial export swap too.
        
        Additionally, some linear gradients are actually axials,
        so identify those symmetrical gradients that have
        identical start/end colors to avoid exporting as a "solid" color.
        
        [I tried changing the import to detect it was an axial,
         but got RTF export failures, chart2 false positives,
         and unit-test-the-implementation failures.]
        
        make CppunitTest_sw_ooxmlexport7 \
            CPPUNIT_TEST_NAME=testTdf126533_negativeAxialAngle
        
        The only other unit test that hit this code was
        textframe-gradient.docx - which is dominated by DML import/export.
        I can see with Word 2003 that this patch fixes the VML export
        for this unit test file also.
        
        Change-Id: I75e993c7c127a861617b14072a98778ddde03a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163676
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-23  Justin Luth  <justin.luth@collabora.com>  [1a4639dd8024484971859bcce31470584bc6b973]

        related tdf#126533 DOCX: vml export gradientRadial instead of gradient
        
        ... for everything except the linear gradients (linear/axial)
        
        Interestingly, there was nothing in make sw.check that hit this.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_pageGradient
        
        Change-Id: Id58ed8b312ec29a10ce461ff0e032838b745b11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163470
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-23  Justin Luth  <justin.luth@collabora.com>  [f3efd1dc397e2801a30e705120a21a4e384596ec]

        tdf#126533 DOCX: export page vml fill gradient
        
        Simplistic export of gradient fill.
        
        I just used the existing docxattribute stuff that textboxes
        use to export their background as VML fallback.
        
        Note that docxattribute only knows how to export gradient,
        not gradientRadial. (Done in follow-up patch.)
        
        Lots of stuff is missing in terms properly supporting gradients.
        But likely fixing page background will fix
        the same problem in textboxes etc.
        
        Given how incredibly different LO and MSO are in terms of gradients,
        it makes sense to commit this change and at least get the basics
        wired in.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_pageGradient
        
        Change-Id: I2ac14fdef2fe29609bc8d5a5d8f65b3f0da71889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163469
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-23  Justin Luth  <justin.luth@collabora.com>  [396ece804b3a31e4eddf56de4e557f3755331d8c]

        related tdf#126533 vml import: fix gradient color swapping
        
        tdf#65295 already fixed one case
        by removing the test for degrees > 180
        for the linear-equivalent gradients.
        Unfortunately the comment wasn't also removed,
        so that was confusing: removed comment.
        
        The test for degrees > 180 is not needed
        for the axial-equivalent case either: removed.
        
        The reason for that degrees > 180 case is likely due to
        negative degrees, which is a documented reason
        for swapping the colors: added swap if negative degrees.
        
        All the affected, existing unit tests are improved now:
        -tdf81345.docx: famous MS example: improved header gradient
        -fdo78300.docx: fontworks: hard to tell without MCGR...
        
        make CppunitTest_sw_ooxmlexport7 \
            CPPUNIT_TEST_NAME=testTdf126533_negativeAxialAngle
        
        make CppunitTest_sw_ooxmlexport7 \
            CPPUNIT_TEST_NAME=testTdf77219_backgroundShape
        
        Change-Id: I9f4d56375bb2cec28ffbd93df419d586da465b78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163417
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-23  Miklos Vajna  <vmiklos@collabora.com>  [397d72e582c725d162c7e0b819dc6c0bb62e42b0]

        Related: tdf#158986 sw floattable: fix unexpected page break with sections
        
        Regression from commit c303981cfd95ce1c3881366023d5495ae2edce97
        (tdf#156724 sw: layout: fix tables not splitting due to footnotes
        differently, 2023-08-24), the floating table in the DOCX version of the
        bugdoc went from page 1 to page 2.
        
        It seems what happens is that the first page has 2 section frames, and
        we used to directly recalc the last lower of the first section frame,
        which triggered a recalc of the second section frame, so the table moved
        from page 2 to page 1 once the top of the second section frame was
        reduced (so the table could fit on page 1). But this direct recalc was
        removed because it caused problems for split tables and footnotes in
        tdf#156724.
        
        Fix the problem by conditionally restoring the OptCalc() call in
        SwLayAction::FormatLayout(): only do it for the last lower of section
        frames, which is enough for the DOCX version of tdf#158986, but it keeps
        the old tdf#156724 use-case working (the layout of that bugdoc doesn't
        modify with this change).
        
        The RTF version of the bugdoc (which was the originally reported
        problem) still needs more work, but that's hopefully not a layout
        problem but an RTF import one.
        
        Change-Id: I1134ec3a27aec8ee871b535d81dedf9d27bd6bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163805
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [4931a5c287b23d695ee8b4dfe4a90dedf5eb3d83]

        gtk4 a11y: Fix '--enable-werror' GCC build
        
        `offset` is unsigned int, so can't be negative,
        causing an `--enable-werror --enable-gtk4` GCC 13.2
        build on Debian testing to fail like this:
        
            .../libreoffice-WORKTREE/vcl/unx/gtk4/gtkaccessibletext.cxx: In function ‘GBytes* lo_accessible_text_get_contents_at(GtkAccessibleText*, unsigned int, GtkAccessibleTextGranularity, unsigned int*, unsigned int*)’:
            .../libreoffice-WORKTREE/vcl/unx/gtk4/gtkaccessibletext.cxx:79:16: error: comparison of unsigned expression in ‘< 0’ is always false [-Werror=type-limits]
               79 |     if (offset < 0 || offset > o3tl::make_unsigned(xText->getCharacterCount()))
                  |         ~~~~~~~^~~
            cc1plus: all warnings being treated as errors
        
        Change-Id: Ib5a67c9d5948802fe269275c79f624df09712011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163802
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c7616ef5a473c50df360d3b69bad74c577ab78c7]

        IASS: Added SdrObject Insert/Remove suppport
        
        Change-Id: I7f6aad0ec12de3c3b2677f1ca07e8efd5a881982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163797
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4052ce767a020383781c7351632e58d6ceea74d0]

        crashtesting: isNaN as fUnitCircleWidthAngleDegree
        
        presumably since recent tdf#50934 work
        
        affect files are:
        
        forums/xlsx/forum-mso-en4-295952.xlsx
        forums/xlsx/forum-mso-en4-523214.xlsx
        forums/xlsx/forum-mso-en4-656086.xlsx
        forums/xlsx/forum-mso-en4-702681.xlsx
        
        Change-Id: Ifc436d382f9cda13d2ae4459d436a72c5e40d8aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c30a0b9289e48598baafbd6c264d0ba58c0d40e]

        optimize the text drawing, that's what we do most of
        
        maybe the alternative branch should be dropped, turned into a debugging
        option because it is obscure and presumably doesn't result in better
        results that using the platform text rendering
        
        Change-Id: Ief6882f7acf8737ca64b10e74e5d94aade60d71a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-23  Miklos Vajna  <vmiklos@collabora.com>  [ca22f880159d7845167f72f42c6a540191030613]

        sw doc model xml dump: extract SwTableBox::dumpAsXml() from SwStartNode
        
        Ideally each class should just dump itself.
        
        Change-Id: I8b7251553d12673258ae885436c56e342b3ddf8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163801
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7be51eca1e509723e66973ed644f4c49cb27b608]

        Update IwyuFilter in bridges
        
        after commit 4b0c46dc61df243cda94f4a0af8946e076d1af54
        
        Change-Id: If7c1d2a2b0d459271c0835f8fcdf084aa3482990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163719
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [48701ac2da7e03274571565d1e24a120e380bbdd]

        SAL_CALL is not necessary here
        
        these are internal methods
        
        Change-Id: I023bd2434d72913cfc1818636cd8a7345c05d1fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163745
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-23  Luv Sharma  <luvsharma.del@gmail.com>  [a6cdc75f98a9449fd796420170d2097e96b6e873]

        tdf#158067: an example of OUStringLiteral -> operator u""_ustr replacement
        
        Change-Id: I0b7f8dda1d266f6d71b5781bea65242ff235bc47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161593
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-23  AhmedHamed  <ahmedhamed3699@gmail.com>  [23056ce647654d57b63cb48a30488d35fcd26c7f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I5ea12f17e35e4eb3dd36781fd31664caaef17e50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163785
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [3b73071f7a7fcf80547da81e5effe4ed6018bbb4]

        Fix warning C4477 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/comphelper/source/windows/windows_process.cxx(254): warning C4477: 'wprintf' : format string '%s' requires an argument of type 'wchar_t *', but variadic argument 1 has type 'const void *'
        
        Change-Id: Ia804bad18366d4f9422d72f3061c83cb07e92073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163783
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f093cad87e830fecae4322b06e75d5da2ff27bb3]

        Fix warning C4312 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/oox/qa/unit/testscene3d.cxx(1): warning C4828: The file contains a character starting at offset 0x21ac that is illegal in the current source character set (codepage 65001).
        
        Change-Id: Id1f69b2644ecb5302e15603dd5353a34757e76dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163782
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [d37df8fd1a681db758de6f4acfe6479e8e78b2dd]

        Fix warning C4312 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/sw/source/ui/dbui/addresslistdialog.cxx(426): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size
        
        Change-Id: Idbfbe8add89c8e219bdabcf28b741e2e31a5e345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163781
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [d7831d30e46a46e253cd6e855dd87eee3cb004a4]

        Fix warning C4838 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/svx/source/form/fmshimp.cxx(138): warning C4838: conversion from 'TypedWhichId<SfxBoolItem>' to 'const sal_Int16' requires a narrowing conversion
        
        Change-Id: If5ab7dc19ae936ca39f151a9fc775c83589981f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163780
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [ff23937c34d8d6a0870bb326a52192535f7b4810]

        Fix warning C4459 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/oox/source/export/shapes.cxx(2411): warning C4459: declaration of 'XML_line' hides global declaration
        
        Change-Id: I74738753254ad1c468025d25bfb0bfe21787180f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163779
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [33553540eb0109caac74bd8c401b5fa9f2528943]

        Fix warning C4456 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:/lo/core/cli_ure/source/climaker/climaker_emit.cxx(972): warning C4456: declaration of 'attrBuilder' hides previous local declaration
         C:/lo/core/cli_ure/source/climaker/climaker_emit.cxx(962): note: see declaration of 'attrBuilder'
        
        Change-Id: I95cba76cfcbfd9da31e7294ed421cfc38d279740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163778
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [b3e6bec35090a88e6ae3c06fc7bb9734bf996e4a]

        Fix warning C4589 when building with MSVC without -Wv:18
        
        Discovered by https://gerrit.libreoffice.org/c/core/+/163717
        
        Like these:
        
         C:\libcmis\inc\libcmis/document.hxx(51): warning C4589: Constructor of abstract class 'libcmis::Document' ignores initializer for virtual base class 'libcmis::Object'
         C:\libcmis\inc\libcmis/document.hxx(51): note: virtual base classes are only initialized by the most-derived type
         C:\libcmis\inc\libcmis/folder.hxx(58): warning C4589: Constructor of abstract class 'libcmis::Folder' ignores initializer for virtual base class 'libcmis::Object'
         C:\libcmis\inc\libcmis/folder.hxx(58): note: virtual base classes are only initialized by the most-derived type
        
        Change-Id: Icc7f94cc02796a86b47b025df69ec3db971ad11e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-23  Patrick Luby  <guibomacdev@gmail.com>  [3b4a8977652b7e69469d0e56e12de50e07ceae2f]

        Revert "tdf#152524 use dispatch_async() instead of dispatch_sync()"
        
        This reverts commit b0656e6ca668a0719fbcb71b6d46c68093dda470.
        
        Reason for revert: This patch has not made any positive difference for tdf#152524.
        
        Change-Id: I5ea0f80263188049f06623ac930b4dc7856dc53e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163758
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3a6bc34f076b27a366d7352e7e7b62730ff17b6f]

        IASS: Re-define Text suppression for TextEdit
        
        The current version suppressed text for Objects
        in edit mode for the paint in the view since that
        text is painted/visualized by the EditEngine/Overlay
        while it is being edited, so that would be displayed
        twice - and in different states.
        That is correct, but e.g. also suppressed display
        for e.g. an opened second Window for the Document or
        in a running SlideShow.
        The mechanism uses embedding the Text in case it gets
        edited to a simple Primitive that then can be
        suppressed by the view rendering it. It decomposed
        to empty, thus to visualize it a renderer had to
        actively identify and process it.
        I now turnedd this around - it is a normal
        GroupPrimitive2D and decomposes to the text content,
        so will be visualized by all renderers that do not
        actively suppress it. To actively suppress it I added
        a get/setTextEditActive marker to ViewInformation2D
        that will be used by the ObjectContactOfPageView
        to signal exactly that and to suppress in the pixel
        based VCLRenderer in that case.
        This is important e.g. for 2nd view window, but also
        for PDF export with active TextEdit (yes, happens)
        and SlideShow.
        There was also support missing for an up-to-now
        empty/new object (no text yet) so that text from the
        active TextEdit was not provided, corrected that.
        
        Change-Id: I0d8befdb023028d78ce341091331e9a83a0173bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163773
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d9635e9bb42cf2b744b8d2f74633e2a209a8e3fd]

        Related: tdf#127293 Fix typo for function XLOOKUP
        
        Wrong isStringSearch value for VectorSearchArguments
        at svExternalSingleRef argument.
        Also more clean-up.
        
        Change-Id: Idc5a953638b90704586754d07f5096d7b5615e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163736
        Tested-by: Jenkins
        Reviewed-by: Sahil Gautam <me.sahilgautam@gmail.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2c7ddd344c36670b536a15ff037e987e2ca0b4e5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5cdfb26bedf7869482d69da193658aab874ca66e
          - Update from UI commands name changes.
            
            Change-Id: I07d7e92a8d231b14ae3d2ec5046b05da4e90cf20
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163796
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9616d413c412b0cbcb89e6fcb5b75fa293285b47]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 61bc025c40797e5ba133551a682d1746bf34857e
          - Fix bookmark for Spelling options dialog
            
            Change-Id: Ie7fb9434b5023f50adb9dd2f2c88ec6897e9dca8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163696
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-22  Julien Nabet  <serval2412@yahoo.fr>  [b42fdd100afb3ab1243150aec1b63eb580f32baf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d13c501f790c5130fa5b23da99be6b92770a08d4
          - Related tdf#155723: "Cube" is in fact "Cuboid"
            
            Change-Id: I7a188a9053920c6fbd010a41ba005cbbd16a9392
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163760
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-02-22  Jim Raykowski  <raykowj@gmail.com>  [139199ee9c09d25624191132adbe4fd29365eb7a]

        tdf#141728 Revamp sw navigator go to page spin control
        
        - makes the go to page spin control visible only when Navigate By is
        set to Page and hides Previous/Next navigation buttons during this time
        
        - makes the go to page control track the page number in the document
        view
        
        - reduces the preferred width of the Navigate By control to help reduce
        the width of sidebar Navigator
        
        Change-Id: I8d876a919ac18e69cf62381310389c00671d8596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163723
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee118a5e6977343a03064a0a1a54aee919296a36]

        fix dodgy unit test
        
        Testing a field which is being modified inside a synchronized block,
        outside of such a block, is going to lead to weird ordering issues when
        running a highly parallel test like this, so test the flag inside a
        synchronized block.
        
        Failure manifested as:
        
        JUnit version 4.13.2
        ........E...........
        Time: 17,27
        There was 1 failure:
        1)
        testStaticThreadExecutesAsyncs(com.sun.star.lib.uno.environments.remote.JobQueue_Test)
        java.lang.AssertionError: expected:<35> but was:<34>
        	at org.junit.Assert.fail(Assert.java:89)
        	at org.junit.Assert.failNotEquals(Assert.java:835)
        	at org.junit.Assert.assertEquals(Assert.java:647)
        	at org.junit.Assert.assertEquals(Assert.java:633)
        	at
        com.sun.star.lib.uno.environments.remote.TestWorkAt.passedAsyncTest(TestWorkAt.java:75)
        	at
        com.sun.star.lib.uno.environments.remote.JobQueue_Test.testAsyncJobQueue(JobQueue_Test.java:180)
        	at
        com.sun.star.lib.uno.environments.remote.JobQueue_Test.testStaticThreadExecutesAsyncs(JobQueue_Test.java:121)
        
        FAILURES!!!
        Tests run: 19,  Failures: 1
        
        Change-Id: Iad980aea1245bfd8ee89887b175eb9dc17643778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac1bb5eda15dd3033c549a3df9c2c7b4862a6bbc]

        tdf#159743: Revert all Shortcut modifications in German UI
        
        These changes have to be done exponentially and with the german
        speaking community involved in the discussion
        
        This commit reverts:
        
        - 2d37ac2ca3a93cd7f05867ba7256c9e232192983 "Added & modified some
          shortcuts for general compatibility."
        - f5ae03b235766070b1c1e5bf46d0cb86a8196b10 "Writer German shortcuts
          compatibility improvements."
        - e651d9e657f9b61fb45777d6e7edeb5cb95f8d27 "German shortcut improvements
          for Calc:"
        - 691604d9037e72a94207d643cba29c64260b1cb9 "German shortcut changes for
          Impress:"
        - c0c8cffd3541e3cd616c96791b04e7ebf2b2ed03 "Writer: German language
          shortcuts."
        - 3bd3c41bc930406ec3d995a45a7f7060d572bbd0 "German keybindings:"
        - 4b81692f8f3236082f9ac989e4e21c8119ff6e64 "Writer: Update German
          language shortcuts"
        
        Change-Id: I233aa4cdd292cc21bfc28b628b822e9179eab415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163484
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2c3121adb9a53142a003ba668821e77e9555c629]

        Embind: Add UNO char support
        
        Change-Id: I4ced49774baafdf620ae167c53794932766aca86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163741
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b3bca02d58f71d2413b673ff113a346e237ef92f]

        Fix UBSan build's RTTI needs
        
        ...after 3ba92b5f1eaf7d4447a0943ea260db515ca799dc "hide more symbols" had caused
        CppunitTest_desktop_lib to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so
        > workdir/LinkTarget/CppunitTest/libtest_desktop_lib.so: undefined symbol: _ZTIN7desktop20CallbackFlushHandlerE"
        
        Change-Id: I051e1a233757a6ccb7cf9ea564ab6b510d6df571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163742
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [48d400ef4970582fb4c401c63e7afec1b198d6ff]

        tdf#157158: always paint the arrow black
        
        The background doesn't change so do not change the arrow color either
        
        Change-Id: I7a5f80e639570e94975b7e033619783d24c95a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163737
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [22d95e9746b4cbeeaae56526e9ab083066ad1a52]

        Remove duplicated include
        
        Change-Id: Ica5e5e95f99f30a59b91cd1243ac3ec401e6e94d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163728
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [255853c7979657c38339c42f42e245f712cb9e65]

        gtk4 a11y: Forward text change events
        
        Bridge text-related a11y change events for the gtk4 VCL plugin
        by using the new functions to notify about text, text caret
        and text selection changes recently introduced in Gtk
        in commit [1]
        
                commit 0ca8d74842837b1ad5dc42c1fcff8b1270e5750b
                Author: Matthias Clasen <mclasen@redhat.com>
                Date:   Tue Feb 20 12:18:27 2024 -0500
        
                    a11y: Add GtkAccessibleText interface
        
        With this in place, having a Writer paragraph selected in
        Accerciser's treeview, the text in the "Text" section of the
        "Interface Viewer" tab in Accerciser now updates when typing
        in LibreOffice (i.e. text changes are propagated there right
        away as expected).
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/0ca8d74842837b1ad5dc42c1fcff8b1270e5750b
        
        Change-Id: I33c93613ddde3650d81ce11d605dc70b0569080a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163746
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [e268efd612d12ae9a459d6b9d0cb23220f025163]

        gtk4 a11y: Implement new GtkAccessibleTextInterface
        
        Implement most of the methods of the
        `GtkAccessibleInterface` newly added to Gtk 4 in
        Gtk commit [1]
        
            commit 0ca8d74842837b1ad5dc42c1fcff8b1270e5750b
            Author: Matthias Clasen <mclasen@redhat.com>
            Date:   Tue Feb 20 12:18:27 2024 -0500
        
                a11y: Add GtkAccessibleText interface
        
                The AccessibleText interface is meant to be implemented by widgets and
                other accessible objects that expose selectable, navigatable, or rich
                text to assistive technologies.
        
                This kind of text is not covered by the plain accessible name and
                description, as it contains things like a caret, or text attributes.
        
                This commit adds a stub GtkAccessibleText with its basic virtual
                functions; the interface will be implemented by widgets like GtkLabel,
                GtkInscription, GtkText, and GtkTextView. A further commit will ensure
                that the AT-SPI implementation will convert from GTK to AT-SPI through a
                generic (internal API); and, finally, we'll remove the widget type
                checks in the AT-SPI implementation of GtkATContext, and only check for
                GtkAccessibleText.
        
                Fixes: #5912
        
        and follow-up commits. The `css::accessibility::XAccessibleText`
        interface provides the required functionality.
        
        With a Writer paragraph consisting of the text
        "Hello world. And another sentence."
        and the word "world" selected, using some of the AT-SPI Text
        interface methods via Accerciser's IPython console behaves as expected
        now when the paragraph's a11y object is selected in Accerciser's
        treeview:
        
            In [9]: text = acc.queryText()
            In [10]: text.get_caretOffset()
            Out[10]: 11
            In [11]: text.getText(0, -1)
            Out[11]: 'Hello world. And another sentence.'
            In [12]: text.getText(2,5)
            Out[12]: 'llo'
            In [13]: text.getStringAtOffset(10, pyatspi.TEXT_GRANULARITY_CHAR)
            Out[13]: ('d', 10, 11)
            In [14]: text.getStringAtOffset(10, pyatspi.TEXT_GRANULARITY_WORD)
            Out[14]: ('world', 6, 11)
            In [15]: text.getStringAtOffset(10, pyatspi.TEXT_GRANULARITY_SENTENCE)
            Out[15]: ('Hello world. ', 0, 13)
            In [16]: text.getStringAtOffset(10, pyatspi.TEXT_GRANULARITY_PARAGRAPH)
            Out[16]: ('Hello world. And another sentence.', 0, 34)
            In [17]: text.getNSelections()
            Out[17]: 1
            In [18]: text.getSelection(0)
            Out[18]: (6, 11)
        
        Actual handling of text attributes is left for later (s. TODO comment
        in the newly added `lo_accessible_text_get_attributes`).
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/0ca8d74842837b1ad5dc42c1fcff8b1270e5750b
        
        Change-Id: Icad236cd87285d9a336883e67b191f633e9e4413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163733
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [56e5c2c35d8febb17decaae1d526d3c98ae08f09]

        gtk4 a11y: Move LO_ACCESSIBLE define to header
        
        ... and the LO_TYPE_ACCESSIBLE one as well,
        for use elsewhere in an upcoming commit.
        
        Change-Id: Ib7294ce0aa0c275a405c2ff87c8de8493c36a61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163732
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-22  Michael Stahl  <michael.stahl@allotropia.de>  [4c3ee61e3eda0cbfd812443f80af89aa3a24ac73]

        libxml2: upgrade to release 2.12.5
        
        Fixes CVE-2024-25062
        
        Change-Id: I0e98fd919328e9633a602c4872de0b06eb972cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163734
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [006a8e3186c26c43560b2d616dde453437a49b47]

        split TextAsPolygonExtractor2D for more general reuse
        
        Change-Id: I102ccab2a423c38b0414c9565fec349aa6ffb5af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163725
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [29b109dfc0f836e34b61b2fbbe69d2b0728dc7b8]

        A first cut at embindtest
        
        (UNO boolean should arguably map to JS Boolean, not Number)
        
        Change-Id: I21847c558b14ead053aa5c5ea94a508a73aaf36b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163722
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-22  Michael Stahl  <michael.stahl@allotropia.de>  [0690f3b7b981417a7b1f2fffd87c593a2a2a15d5]

        tdf#159519 libxmlsec: avoid linking function not existent in Windows 7
        
        xsec_xmlsec.dll is linked to libxmlsec-mscng.dll, which is
        linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on
        Windows 7.
        
        Use GetProcAddress() to retrieve BCryptKeyDerivation at runtime; the
        function is not used by LibreOffice.
        
        (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b
         and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b)
        
        Change-Id: I0c0c94ee0cdfd48ae7506d9dfb51fcaf8289d460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163709
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-22  Michael Stahl  <michael.stahl@allotropia.de>  [58c31ded0264103769595a1b25739b0e8df571cd]

        tdf#159519 comphelper,package: do not store document without SHA256
        
        The problem is that on Windows 7 the password-encrypted documents are
        stored unencrypted, without any error message.
        
        This is due to defensive programming in
        OStorageHelper::CreatePackageEncryptionData(), which happily continues
        if creating the SHA256 hash fails, which is the one required for storing
        anything newer than ODF 1.1.
        
        Also, the poorly named ZipPackage::GetEncryptionKey() should check for
        consistency, the expectation is that either there's no encryption key
        (empty sequence), or the expected one is in the sequence.
        
        Creating the SHA256 uses the crypto::NSSInitializer component, which is
        in xsec_xmlsec.dll, which is linked to libxmlsec-mscng.dll, which is
        linked to Win32 bcrypt.dll, which doesn't have BCryptKeyDerivation on
        Windows 7; to reproduce elsewhere, rm instdir/program/libxsec_xmlsec.so
        
        (regression from commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b
         and (due to revert) commit bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b)
        
        Change-Id: I0b22e20f6d4d0b1a12ed7d99fac7b5243910f9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163708
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9c64630d2f176844b29fd4f860aac3ef4e1dce0]

        UBSan RTTI fixes
        
        after I missed a bunch of stuff when testing UBSan with
            commit 3ba92b5f1eaf7d4447a0943ea260db515ca799dc
            hide more symbols
        
        Change-Id: I0743a0c0c6abcb2904face8386e26153ae3229a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-22  Michael Stahl  <michael.stahl@allotropia.de>  [17ad20bd10de34f4660567e2505eb95ab22f61a5]

        gbuild: remove unused gb_Executable_get_linktargetfile
        
        Was added in commit dc9ccf3d8f294cd7ae9d5bece7b6c16c3b22f6a5 but
        apparently never used.
        
        Change-Id: I9eec766caeacaa2762917be739f01227168c7353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163707
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-22  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [c4c1ca58bb587a56a30c7f4817c346054ce37f2a]

        tdf#33603: sd: add notes panel for normal view
        
        Change-Id: Ibc6e8a3f126c443453c5ecab52ba988a4f4f56e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159288
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-22  Miklos Vajna  <vmiklos@collabora.com>  [3aa7b8e722f1a5dd35247bba3497468b256fe22b]

        CppunitTest_sw_ooxmllinks: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything.
        
        Change-Id: Ib9af88c31355cfa9848038b64cf36f0f29496b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163715
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-22  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9fdf0913b6b7ac38e5ea9eff19945e127be89339]

        SDK - 1st Steps example code enhancement
        
        Python example extended in order to be equally callable from LibO client
        
        Change-Id: Ib2d733809e960971b98c30cbd6368ebc755dd7ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159767
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-22  Noel Grandin  <noelgrandin@gmail.com>  [b863b599c751b28dde2d15188a9ed7cbce4c158a]

        SAL_WARN->INFO in CellMarginHandler::lcl_attribute
        
        this has been here since
            commit 6a9e4e77e83875ecce3b387736f6dd1ea221ced8
            Author: Rüdiger Timm <rt@openoffice.org>
            Date:   Fri Apr 18 11:11:49 2008 +0000
            INTEGRATION: CWS xmlfilter04 (1.1.2); FILE ADDED
        and is very noisy, but does not seem to indicate a problem,
        given the lack of changes here.
        
        I added an assert here, and I saw all of:
                case NS_ooxml::LN_CT_TcMar_top:
                case NS_ooxml::LN_CT_TcMar_left:
                case NS_ooxml::LN_CT_TcMar_bottom:
                case NS_ooxml::LN_CT_TcMar_right:
        
        Change-Id: Id698f2344844c1335edac981023228be7e27da7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163711
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d0cb804f7a25274d725475418a97c293f55f30cf]

        Framework for some UNOIDL to test the Embind UNO binding with
        
        It is only built for --enable-dbgutil builds.  Load
        instdir/program/qt_soffice.html in a browser and see "Running embindtest" in its
        console.  For now, it only contains a Test singleton with an empty XTest
        interface, which is meant to grow additional methods over time.
        
        (The code needs to reside in the unotest rather than in the static module, or
        else the wasm build would run into cyclic dependencies.)
        
        Change-Id: I6f65f0c904648a4fd96fc6215c8d59a1544f48a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5ccdbbc457fb7aadca2d6a046ab891dedca5bb1]

        UBSan RTTI fixes
        
        after I missed a bunch of stuff when testing UBSan with
          commit 3ba92b5f1eaf7d4447a0943ea260db515ca799dc
          hide more symbols
        Change-Id: Id3cb0b70b9fa24c7e3fba7fd565eb658dafa00f8
        
        Change-Id: I369587ed3e14e50ca272037b9d950b62841695d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163703
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [349af3ca598833b64db93bc1d32117431be992f2]

        fix ubsan use-after-free
        
        caused by
            commit 8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7
            Author: AkshayWarrier <aksmen121@gmail.com>
            Date:   Mon Jan 22 20:31:16 2024 +0530
        tdf#157882 svx: Remove cap/corner styles and move arrowhead control
        to new row
        
        The ToolbarUnoDispatcher needs to destruct before the associated
        Toolbar.
        
        Shows up as
        vcl/source/app/salvtables.cxx:1278:1:runtime error: member call on
        address 0x51700010dc00 which does not point to an object of type
        'SalInstanceToolbar'0x51700010dc00: note: object has invalid vptr
        00 00 00 00  8c 03 03 00 00 00 00 00  80 43 4e 00 90 51 00 00  00 00 00
        00 00 00 00 00  30 7e 9a 00
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      invalid vptr
        SalInstanceToolbar::LinkStubMenuToggleListener(void*, VclWindowEvent&)
        vcl/source/app/salvtables.cxx:1278:1
        void>::Call(VclWindowEvent&) const include/tools/link.hxx:111:45
        void*) vcl/source/window/event.cxx:262:23
        vcl/source/window/window.cxx:158:5
        vcl/source/window/dockwin.cxx:407:13
        vcl/source/outdev/vclreferencebase.cxx:38:5
        include/vcl/vclptr.hxx:207:19
        vcl/source/window/builder.cxx:811:23
        vcl/source/window/builder.cxx:803:5
        
        Change-Id: Id890fe431ab724db4bdf7ad6622b933044bd6ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [8eee7eab8087590aa19bb9989c294e9be767f356]

        IASS: Allow exit Impress when SlideShow is running
        
        Change-Id: Iffccf2c7fe37845f9da44fd911cf974db026af89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163697
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-21  Noel Grandin  <noelgrandin@gmail.com>  [018f58b5f2d891b71c4824ff4dd324172b63ad42]

        remove some log noise
        
        this warning was added in
           commit 5630cca2031eeeaa20c916ea9542ccef2327349f
           Merge: 0562ba185b5c f6c764706cd4
           Author: Jan Holesovsky <kendy@suse.cz>
           Date:   Wed Mar 23 17:00:12 2011 +0100
           Merge commit 'ooo/DEV300_m103'
        
        but does not seem to indicate an actual issue, and is rather noisy
        
        Change-Id: Ib494d81566fc55b17f1c55d9be2372edad88855a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163710
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-21  Mike Kaganski  <mike.kaganski@collabora.com>  [6329a56f601748f5a8dd6da9f0a90d3e57efcaf2]

        Implement SAL_WNODEPRECATED_DECLARATIONS_[PUSH/POP] on MSVC
        
        Required for --disable-nss build on Windows, which needs the same fix as in
        commit 71d4abc51b556e147ab53a9a52b15be36fc710a3 (-Werror,-Wdeprecated-declarations
        (Emscripten), 2024-01-18).
        
        Change-Id: I4206cbc0cb80be7ddee1c3f21de50d853828300e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163704
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [66b30842e86fb6041bd6a453c6e3a877a3c177c1]

        tdf#159797: sw_uiwriter6: Add unittest
        
        Change-Id: I69b8ea673f676f1106e257cef507937cbd5ebd2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163695
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7cf3d5e3073dc5cffc64b6d9b32513e90087a3d4]

        tdf#158360 - sw, ooxml import - fix insertTextPortion crash
        
        Before this patch da8dead8e9282010893cbd12519e107baf03cd1a
        SvxUnoTextBase::insertTextPortion returned an empty XTextRange
        in case of texts in comment. (SwTextAPIObject) Lets use
        finishParagraphInsert which also give back an empty XTextRange.
        
        regression from commit: da8dead8e9282010893cbd12519e107baf03cd1a
        (tdf#73537 - sc: show author and creation date in calc comments)
        
        Change-Id: I0b33e5b3cae32718a62a7be04b9a88562f85652c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163670
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-21  Heiko Tietze  <tietze.heiko@gmail.com>  [215a7afd6042c35a45509cea3eae69254d676429]

        Resolves tdf#159535 - Less obtrusive shadow for comments
        
        Change-Id: Ic4b55ebb52aaf03738184dcc0d3b8d57c9ee57a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163699
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b214f90bf6c66a7d2ed9cfb45ae8174e508fc45]

        use after free on clicking cancel in a calc spelling message dialog
        
        e.g. the calc subdialog "Should the spellcheck be continued from the
        beginning of the current sheet" seen from the "spelling" dialog when
        starting spelling from some cell beyond used sheet bounds.
        
        With a local asan build, and hello-world.ods, load, put cursor in A2,
        review, spelling to get the spelling dialog. There should then be a sub
        dialog with "Should the spellcheck be continued ..." with "No" and "Yes"
        options, hammer the "no" button a few times in rapid succession.
        
         2715237==ERROR: AddressSanitizer: heap-use-after-free on address 0x6140007a8118 at pc 0x7fdf28e73ce1 bp 0x7ffd012c88d0 sp 0x7ffd012c88c8
         READ of size 8 at 0x6140007a8118 thread T0 (kitbroker_003)
         #0 0x7fdf28e73ce0  (instdir/program/libvcllo.so+0x2473ce0)
        
        JSMessageDialog::~JSMessageDialog has:
        
        JSMessageDialog::~JSMessageDialog()
        {
            if (m_pOK || m_pCancel)
                JSInstanceBuilder::RemoveWindowWidget(m_sWindowId);
        }
        
        but has
        
        int JSMessageDialog::run()
        {
            if (GetLOKNotifier())
            {
                RememberMessageDialog();
                sendFullUpdate();
            }
        ...
        }
        
        where RememberMessageDialog has JSInstanceBuilder::InsertWindowToMap(sWindowId);
        
        this dialog doesn't have ok or cancel, so while it is inserted in that
        map when the dialog is run, it doesn't get removed from the map when the
        dtor is called, which goes on to cause use-after-free.
        
        Given that we only set m_pCancel and/or m_pOK if there is no "builder"
        it looks a more straight forward approach to simply call
        JSInstanceBuilder::RemoveWindowWidget based on if there was no builder.
        
        Change-Id: Icf04f0e9f3c3c864955e9d4ee41589f4d2aa4cb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163624
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a62436ff028c611542e86e8e87e92a844f5f4741]

        Remove stray code from example
        
        ...that had erroneously been added with 27ceca1996809c0f9390d1e9fb95dc7436ef1acf
        "Rework the Embind mapping of UNO interfaces"
        
        Change-Id: I421bf2aa7e9f96ce48b227f6f47058581b64d7b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7459d4eef300dd46bcac6ce52767541e475a5e93]

        external/fontconfig: Adapt library name
        
        ...to recent bbb0663813d0476b9a654207b7006315cb417c2e "Fontconfig: upgrade to
        release 2.15.0"
        
        Change-Id: I6abdb1889d55edc6b50beec60b5e71707695f0ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163684
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1c387bbf2fdf265c33c8eefbb769fae82b412769]

        Fix UBSan build's RTTI needs
        
        ...after 3ba92b5f1eaf7d4447a0943ea260db515ca799dc "hide more symbols" had caused
        CppunitTest_ucb_webdav_core to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_ucb_webdav_core.so
        > workdir/LinkTarget/CppunitTest/libtest_ucb_webdav_core.so: undefined symbol: _ZTIN9ucbhelper16PropertyValueSetE"
        
        etc.
        
        Change-Id: I54832b1c7a9850e536bfcab076f15465b170a065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163690
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-21  Attila Szűcs  <attila.szucs@collabora.com>  [57ac7b73e898cf8889819d7f3beb3608e61b179b]

        tdf#67347 fix regression stacked text in calc
        
        Added a new element (STACKED) to EEControlBits.
        It would be better to use only ONECHARPERLINE, but calc and impress
        used it from different places, and couldn't recognise each other,
        so they may overwrite each other.
        
        With this fix they both set a separate flag, and editeng check if
        any of the flags are set.
        
        regression was made by: I535da45e3a2f2d1550bad2a40e9909e0d561d0ef
        
        Change-Id: I60496059f3ce2773b232970bf2c3b7264ce64c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163682
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Oliver Specht  <oliver.specht@cib.de>  [95017739a05c4f515fc42caebfd1e01e8a9ba160]

        tdf#159797 replace dash also between sentences
        
        Autocorrection replaces " - " with " <enDash/emDash> " also after
        dot, question mark and exclamation mark.
        
        Change-Id: Iad4b6c6073ab90b0c86514b8683dd2a07197f59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163659
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-21  Mike Kaganski  <mike.kaganski@collabora.com>  [bf269ed81fe2ec7c89a0f7d2d22e8e1982f558f4]

        tdf#159813, tdf#159816: Use correct copied PaM
        
        This fixes both the assertion in CopyFlyInFlyImpl (tdf#159813) and
        crash in BigPtrArray::operator[] (tdf#159816).
        
        Change-Id: Ia3424e3a58c7d8fb3e1257dcdbf062fb893da8db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163683
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cfc4a2cfd15760b1fc536c95c3570d916727c31b]

        Fix UBSan build's RTTI needs
        
        ...after 3ba92b5f1eaf7d4447a0943ea260db515ca799dc "hide more symbols" had caused
        CppunitTest_vcl_text to fail with
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_vcl_text.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_vcl_text.so: undefined symbol: _ZTIN3vcl8unotools15VclCanvasBitmapE"
        > Path (length: 252) is '/home/tdf/lode/opt/bin:/etc/alternatives/java_sdk_11/bin:/opt/rh/gcc-toolset-12/root/usr/bin:/home/tdf/.local/bin:/home/tdf/bin:/usr/share/Modules/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/etc/alternatives/java_sdk_17/bin'
        
        (<https://ci.libreoffice.org/job/lo_ubsan/3080/>)
        
        Change-Id: Ib0a82e185a8600955704f8026238b511d46acc56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163685
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f64d8d879e78fd3fdf593d3f29c16e5bf270a8cd]

        support possibility to set Theme early during initializeForTiledRendering
        
        so we are already in the desired theme from the start
        
        Change-Id: Ibaaf647612a0a61ce74fa4e4272d7084868a6ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163650
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Miklos Vajna  <vmiklos@collabora.com>  [833abb4a197561c34ec59cceb9d7d8a46f6b17ce]

        tdf#159815 DOCX import: fix redlined to-char image followed by inline SDT
        
        The 2nd para of the bugdoc has a leading word, then a redlined anchored
        shape, finally a redlined checkbox content control. The Writer import
        result's content control starts at para start, while it should only
        start after the anchored shape.
        
        What happens is that writerfilter::dmapper::DomainMapper_Impl::PushSdt()
        gets called to remember the SDT start, then
        DomainMapper_Impl::applyToggleAttributes() deletes some content since
        commit 8726cf692299ea262a7455adcf6ec25451c7869d (tdf#142700 DOCX: fix
        lost track changes of images, 2021-07-08), which invalidates the SDT
        start position, finally PopSdt gets called, but that fails because our
        start position is no longer valid. This used to abort the import
        process. Since commit 1b0f67018fa1d514ebca59e081efdd24c1d7811b (docx
        import: correct redline content-controls, 2024-02-20), the import
        finishes the but start of the SDT is incorrect: it's at the para start,
        while it should start in the middle of the paragraph. The direct reason
        for the invalidation is a call to SwXTextRange::Impl::Notify(), which is
        from a content deletion from applyToggleAttributes().
        
        Fix the problem by not deleting content when we're past PushSdt() and we
        haven't called PopSdt(): extract the redlined anchored shape code into a
        new DomainMapper_Impl::MergeAtContentImageRedlineWithNext() and call
        that also in DomainMapper_Impl::PushSdt() early, so it won't be called
        when we're in the middle of an SDT.
        
        This way createTextCursorByRange() should not fail, so warn in case it
        still fails in DomainMapper_Impl::PopSdt().
        
        Change-Id: Ic4198804a92088ec268203d44c0da2d6997754b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163678
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b0c46dc61df243cda94f4a0af8946e076d1af54]

        ofz#66731 Crash in com::sun::star::uno::BaseReference::iquery
        
        since
        
        commit f93ae0455c4d515be1ca663725a6e58d64a7e393
        Date:   Sat Feb 3 18:03:45 2024 +0100
        
            Check bridges with IWYU
        
        presumably not using the _LIBCPPABI_VERSION branch
        
        move the _GLIBCXX_CDTOR_CALLABI fallback define to where
        its used while I'm at it, that too seems to be from cxxabi.h
        
        Change-Id: I2ead7207e3bcf24d3b120d22ae7f80e8f0a3216a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163672
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Méven Car  <meven.car@collabora.com>  [f1a780cb6b7b860856de7ce2d8735432523c9e73]

        Allow Document properties tab custom properties for LOK
        
        Change-Id: I4860f9bad69b3db0eef7b0e98159ca2b336b4f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163611
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit f8f89de7a49db563b870dbaada6f010f2f75254f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Patrick Luby  <guibmacdev@gmail.com>  [af47a78e11d4819bb4b1ae1a1277babd10d815b7]

        tdf#159529 clear hb_ot_face_t data after fetching 'sbix' and 'glyf' tables
        
        The 'sbix' and 'glyf' tables can be very large for color emoji fonts
        so clear any cached data in hb_ot_face_t after fetching that table's
        extents.
        
        Change-Id: Id5deda9114b7199a4194ff16879e5791acd1cd82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [69bac9b78ce7dcbe91da3d3552aa3dd7edaf2b4a]

        IASS: Avoid more SlideShow shutdowns
        
        There are many ways the SlideShow may be stopped,
        but with IASS mode less are needed. Identified
        quite some and added needed code.
        Also added that for setting transitions or adding
        an effect to an Object when the SlideShow is up
        (the FullScreen one, makes no sense in-place)
        the Preview for that is show in the running
        SlideShow by switching to it, showing, and back.
        So this is used in this mode as a permanent
        preview for those changes.
        
        Change-Id: I5cc34e230358aecad30fec8aee05acfa937f9270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163669
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-21  OmkarAcharekar  <omkaracharekar12@gmail.com>  [01e0931ba455a5ad9e1aa4b8ddd6951b6aa56902]

        tdf#130857 - Drop unused `getUIFile` method from VclBuilder class.
        
        Noticed during refactoring builer patch [1], the getUIFile method is not been used anywhere. So it make sense to drop it.
        
        [1] https://gerrit.libreoffice.org/c/core/+/163103/4..5/include/vcl/builder.hxx#b76
        
        Change-Id: I8bf1eec7aaccac528959029cddff0cdc8209ba00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163662
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-21  Miklos Vajna  <vmiklos@collabora.com>  [707344eaecbff672d7c837709d5c70d3eb04b6fd]

        sw model test base: remove no longer needed postLoad()
        
        The only impl was a stub, it was only called at one place.
        
        Change-Id: I7b6b6824e871381b1a96b5cecd4a94beb3197310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163677
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-21  Julien Nabet  <serval2412@yahoo.fr>  [ff516105c2df13cc71629b5a7156e16ec16b6988]

        Fix potentially uninitialized local variable 'fY' used in Windows TB
        
        Change-Id: I3849d2263de113f09fc3f4839c156c2d0458d718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163667
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-02-21  Justin Luth  <justin.luth@collabora.com>  [07521972bcd1cfbbd15b2f60ada84ffc69f8f997]

        tdf#159626 vml pattern import: add color, fix back/foreground
        
        This depends on tdf#126533 which imports page style v:fill,
        BUT ONLY IN ORDER TO support the unit tests.
        The patch itself can stand alone
        and fixes vml import into textboxes/shapes etc.
        i.e. backporting could be possible by dropping the unit tests.
        
        The pattern that VML uses to indicate foreground
        and background is very different from what LO needs.
        [Fortunately LO does not use the _guess_ from
        vcl::bitmap::isHistorical8x8 to determine which
        color is the background. Instead it always uses the first pixel.]
        
        Documentation says that unspecified XML_fillcolor
        and XML_color should be white, but observation
        says it should be 25% gray (Word 2003).
        25% gray == C0C0C0 == fillcolor="silver" == COL_LIGHTGRAY
        
        Currently, we simply export as a colored, tiled image,
        and not as a B&W type="pattern"
        so no corresponding export changes need to be made to export.
        
        Existing unit test documents that are affected:
        -chart2export's PieChartDataLabels.docx (page background)
        -ooxmlexport5's fdo77725.docx (minimized PieChartDataLabels.docx)
         * both foreground and background are set to white => solid white
        -sw/qa/core/data/ooxml/pass/fdo79131.docx (shape "inline")
        
        make CppunitTest_sw_tiledrendering \
            CPPUNIT_TEST_NAME=testTdf159626_yellowPatternFill
        make CppunitTest_sw_tiledrendering \
            CPPUNIT_TEST_NAME=testTdf159626_yellowPatternFillB
        make CppunitTest_sw_tiledrendering \
            CPPUNIT_TEST_NAME=testTdf159626_blackPatternFill
        
        Change-Id: I9533ac4a7489081ffc62a10e900f5526abb906db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163106
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-21  Justin Luth  <justin.luth@collabora.com>  [d7cd7dff0e8f71b3d83b4c91b574f39248a25e2f]

        tdf#126533 docx export: page background vml fill: tiles/patterns
        
        This patch only benefits LO. MSO ignores "frame" and always
        treats page background as it if were tiled,
        but that is a trait we do NOT want to mimic.
        
        Textures are the primary fill type that needs to be tiled
        (instead of scaled/stretched).
        
        LO export also treats patterns as tiled bitmaps,
        and the end result of exporting as a tile looks the same
        as the original pattern.
        It just loses HOW the page background (i.e. as a pattern)
        but that is very low value. It is rather difficult
        to export as a true pattern and just not worth the effort
        of identifying the correct fore/background colors,
        converting to b&w image, and inverting the B&W image
        if the first pixel is white instead of black.
        
        [Hatching seems similar to patterns,
        but rarely (and only coincidentally) would it tile well.
        I think hatching is a new DML-only thing.
        Hatching is not in the page background UI of MS Word.
        LO just exports any hatching as a solid color.]
        
        Change-Id: I5cd3f1c6e380edb5e5b21900bad289fa298574e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163206
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-21  Justin Luth  <justin.luth@collabora.com>  [ed91971c9312e4b8a33c03c28d339bff6c5accc7]

        tdf#126533 docx export: page background vml fill: basic image
        
        This is the absolute minimal possible combination
        to export an image to page background.
        
        However, none of the other properties
        that I see strike me as particularly important
        or connected to our image properties.
        
        Plus MSO ignores things like "frame" and tiles anyway.
        
        Import is also pretty basic, so any improvement to imports
        can also add the corresponding export component.
        
        For example: it seems like MSO tiles all images
        based on somewhat magical sizing (they do always export
        o:targetscreensize="999<w>,999<h>" which we ignore).
        But note that MSO does pixel display and not logical display
        for page background - something we do NOT want to emulate,
        so any importing of properties needs to be done intelligently.
        
        But MSO's UI only allows for basic image insertion,
        so very few files will have complex settings.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_pageBitmap
        
        Change-Id: Ib410594d1e3377aefb8ee94f209a1a1155154b17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163203
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [bbb0663813d0476b9a654207b7006315cb417c2e]

        Fontconfig: upgrade to release 2.15.0
        
        Change-Id: Id50d82b4dc7c3e8000b7658a9f62efa0d6b39495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163646
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [340f8ea4ae7f11b4d3a95499188a29fe801867cf]

        tdf#153196 writerfilter: fix page style for even/odd section break
        
        This is a bit of a special case, where the first section starts with an
        evenPage break (\sbkeven), which causes a Left-only page style to be
        created.
        
        In completeCopyHeaderFooter(), the HeaderTextFirst and FooterTextFirst
        are copied from the source style to the Left-only page style, but then
        they also need to be deleted from the source style, because the
        Left-only page style is the one that is used for the first page of the
        section, and the source style is used for the subsequent pages.
        
        Additionally, when there is *only* a "first" header/footer, and no
        previous section has one to inherit, Word will not display a
        header/footer at all on subsequent pages; a PageStyle will always have a
        header/footer if it has a HeaderTextFirst/FooterTextFirst.
        
        In this case, delete the header/footer from the source style.
        
        Unfortunately exporting this doesn't work ideally, a spurious evenPage
        footer will be created, both due to the FooterShare being automatically
        reset for no obvious reason in ItemSetToPageDesc(), and
        setProperty("FooterIsShared", true) "stashing" the left footer since
        commit b802ab694a8a7357d4657f3e11b571144fa7c7bf.
        
        (presumably regression from commit b32881b6723072c8d1a652ea147d12e75766d504)
        
        Change-Id: Ie4f9c49605df690e9705e14777c0e4bcb0dfad8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163668
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [27894455857eab436a7676de370a5bb897509f29]

        none of these defaults can be hit
        
        and so pEngine is always set to something here
        
        Change-Id: I8a0ac4a47a3d70e7ede52c2626af871dd360038a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-20  AkshayWarrier  <aksmen121@gmail.com>  [8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7]

        tdf#157882 svx: Remove cap/corner styles and move arrowhead control to new row
        
        Change-Id: Ifa38ec7ba9969627ff26abe22c58d06ec373ecb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162403
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-20  Noel Grandin  <noelgrandin@gmail.com>  [d04f64c0681c756386067f96b1cd9b89966d0e7c]

        fix linking error
        
        seen by David Gilbert:
        /usr/bin/ld: /discs/fast/core/workdir/CxxObject/sc/source/ui/vba/vbaeventshelper.o: in function `com::sun::star::uno::Reference<com::sun::star::sheet::XSheetCellRangeContainer>::Reference(com::sun::star::sheet::XSheetCellRangeContainer*)':
        /discs/fast/core/include/com/sun/star/uno/Reference.hxx:161: undefined reference to `non-virtual thunk to ScCellRangesObj::acquire()'
        
        after
            commit 3ba92b5f1eaf7d4447a0943ea260db515ca799dc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Feb 15 10:04:51 2024 +0200
            hide more symbols
        
        Change-Id: Id5e21aec323c2779ded464b6a0f8428705dfd0ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163663
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d0e501021dac1a16d93e0e17235b399072d0058c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6dfa12485814931cf7161b53561940cb976116df
          - typo in sf_Document help
            
            Change-Id: I27eedb23bb03a38510df9338245725d323c168b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163616
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-02-20  Julien Nabet  <serval2412@yahoo.fr>  [a5ad209d33b35958b40a7e2444ba0d9f061055ec]

        tdf#155723: Wrong Tooltips for some of the Basic Shapes (cuboid)
        
        Change-Id: Icf50428eb0a88b876929f2272a2cbe63208c6ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163607
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Julien Nabet  <serval2412@yahoo.fr>  [a67286aa0cf9c3bc5919343c428bb5485091104c]

        tdf#155723: Wrong Tooltips for some of the Basic Shapes (pentagon)
        
        Change-Id: Ie6fd95177d4b62f00011cb382f97090963b2cf3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163606
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Attila Szűcs  <attila.szucs@collabora.com>  [684d63e133fddeca68055a83d85f75bd73319d39]

        tdf#67347 fix stacked text kern problems
        
        Disabled some kerning calculations in case of stacked text.
        
        Without this:
        -x position of characters was strange, and the last characters
        was different.
        -thin characters, like 'j', 'i', ' ', ... could result issues
        at editing the text. (if width of character + kern was < 0)
        
        Change-Id: I40a23ef445fc9683a1cfd619ea23f1536c525d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163608
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d10fd2fd532d14500f67cebcc57a1b0f06786baa]

        Fix typo
        
        Change-Id: I6a4cb5143d964408955749822c71d8dcb88f7d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163664
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [1b0f67018fa1d514ebca59e081efdd24c1d7811b]

        docx import: correct redline content-controls
        
        When inserting and deleting content-controls
        with change-tracking enabled, we hit a few
        corner-cases that we need to handle more
        smartly.
        
        First, we shouldn't redline the controls
        themselves, just the placeholder text.
        Second, we have to take special care
        to create valid XML structure with
        the redline tags.
        
        Includes unit-test that reproduces the
        issues and verifies that both saving
        and loading work as expected.
        
        Change-Id: I6af4d0d2c3f0661e7990d5414cc93effc96f0469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163647
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [2567f58f20cdc38b6ed92c639c0fcb19af84295f]

        Simplify a bit
        
        Change-Id: Icc7589bdf5d2e3d061dfa3d34761316d9e9323be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163653
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-20  Justin Luth  <justin.luth@collabora.com>  [c14574e7ad2d3ec2ada40808be3332fac71e9767]

        tdf#126533 docx import: page background vml fill
        
        This patch imports bitmaps/tiled textures (primarily),
        but also somewhat for gradients
        (because of a gradient2 -> gradient mismatch somewhere)
        and somewhat for patterns
        (because patterns are not well imported in general).
        
        Note that the imported fill likely will NOT match MSO,
        because their background CHANGES BASED ON THE ZOOM LEVEL.
        For example, my primary testing file (A6 landscape)
        has a logo which is only 25% visible in Word 2003 at 100%,
        but shows 90% of the logo at 200%, and many tiles of logos
        when exported as PDF.
        The same is true for gradients etc.
        
        Changing background on zoom is an absolutely bizarre implementation,
        and naturally LO could only accidentally look identical
        (and should never try to do so).
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_noPageBitmap
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf126533_pageGradient
        
        This is slightly ugly, but I don't know how to make a COPY
        of the XPropertySet UNO junk. All I have is references,
        and dispose deletes everything, even the references.
        
        I took some inspiration from RTF
        which just disposes the shape after grabbing the background color.
        
        Thus, just change the page style known to exist and be used,
        and then simply remove the fill if it isn't needed in the end.
        Any new page styles can just copy the default page style fill.
        
        Change-Id: Id3ea002c685642ff4c289982d0108247a6e9bb8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162958
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-20  Oliver Specht  <oliver.specht@cib.de>  [178d8a38e133aebd4cff1af2d2c49aec60468c92]

        Make Clone Formatting in Impress similar to PP
        
        In Powerpoint paragraph attributes are only applied from and to
        fully/multiple selected paragraphs.
        
        Change-Id: I7c1f3afb6c0d6fd9b3f8acf34cb5f5b3dcaf22d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163583
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-20  Noel Grandin  <noelgrandin@collabora.co.uk>  [c9fc7f25a35a518360e6009edb2e03382122c836]

        SAL_CALL is not necessary here
        
        these symbols are only used internally
        
        Change-Id: Ib4dff4c8724649608a3d328e47127cd2e1f1cc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Noel Grandin  <noelgrandin@collabora.co.uk>  [0426cb5bcc0b6d5132fc941514c59723ed327887]

        fix Windows build
        
        after
            commit 191e3f8d891c6d2b5e0f63823a1f9afb7d54418f
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Feb 19 15:48:38 2024 +0200
            merge textconv_dict into i18npool
        
        The first build would work, but subsequent builds would fail.
        
        I'm not sure why this patch fixes it, but it does. Somehow the sed
        command was affecting other generated files?
        
        Change-Id: I1550709b6555c838c0371e31b5eb2c90f5065e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [01c7eefbb8722e2e5ef835777c2161b8e3d5aad8]

        Fix typo
        
        Change-Id: I51796820bc4fdf3c792933b67a71b22c56fc36c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163642
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b9946c42977fce2273e53e9dffe369dcab534856]

        Remove exec bits from source file
        
        Change-Id: I8ab5fc146f5787196db51fa45efd2639d8108107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163641
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1cf1de6e844c1f46ebd4e5cfb552e7ce324dcbc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 636cd8ca2952a6a1a386549b38cecf2380a35241
          - Fix typo
            
            Change-Id: Ic6ed414c95a6a1c08884ea8ee55323a10bc36fe0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163636
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [097978b98f457e91643e5d8c65f48e21855851fd]

        Fix typo
        
        Change-Id: I22372726ef167714076278eff9727ee79b951c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163643
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [320b3603e4a82d072fc69df1f08127f8894b7bb6]

        Fix typo
        
        Change-Id: I48d719c6e911f84f1609767df4f40f6f8684a0c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163640
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6361a9398584defe9ab8db1e3383e02912e3f24c]

        merge desktop_detector library into vcl library
        
        Noting that the main feature of using a separate library - avoiding
        linking against SM and ICE -  is no longer a thing, since we have not
        used those in some time.
        
        Change-Id: I9ecd6758e97f0fa19b224346aa577a04b46793b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163638
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [864e752d9e876d29c54aba3b8fd57e4f71a02955]

        simplify this python script
        
        I dont need to exclude the .so files that have been merged, they exist,
        but they contain only a dummy string
        
        Change-Id: I3b008859f4c3d4831025c082dd589e55c46ef078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163639
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Miklos Vajna  <vmiklos@collabora.com>  [d505b8d2730b93cea8d2dcf2656af37c6c8cc580]

        sw: fix crash in SwSpellDialogChildWindow::LockFocusNotification()
        
        Crashreport signature:
        
        	Fatal signal received: SIGSEGV code: 128 for address: 0x0
        	program/libswlo.so
        		SwSpellDialogChildWindow::GetNextWrongSentence(bool)
        			sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx:824
        	program/libcuilo.so
        		svx::SpellDialog::GetNextSentence_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool)
        			/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:919
        	program/libcuilo.so
        		svx::SpellDialog::SpellContinue_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool)
        			cui/source/dialogs/SpellDialog.cxx:370
        	/opt/collaboraoffice/program/libcuilo.so
        		svx::SpellDialog::InitHdl(void*)
        			/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
        
        Change-Id: I0ecae218beb30e5136f7a6f468e3eb9f6e6e5009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163637
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [cca4d8bdcd2ad54a0f353ebbcb26d5eb7b1087d8]

        add icg to --enable-mergelibs
        
        Change-Id: I358cd271421762b4c4b54ca7ae6f2ae30aeb74c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [43f49c3b50b406f0334085dcf302180718f3ecb3]

        Move some stuff from path_helper to file_dirvol, and simplify
        
        Change-Id: Ic9dcff74c16e5f9c107ca060a3d22866f552c398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163632
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-20  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [7751ad7288138b3a62116544422df5a413ce6535]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1830eaea4298edea802bb6bae04ff4a22b3fc2a3
          - use correct "Show Formula" command name
            
            Change-Id: I89381bf8d5e468e2615446dae0265cc30d248a39
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163610
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-20  Noel Grandin  <noelgrandin@gmail.com>  [cfc0f4fae10859890c6e76d5a4ea11044b814da3]

        icg is no longer dlopen-ed from sd
        
        ever since
            5cc45f148dac2080d5cdc2d69db539d55b1ff816
            no need to dynamically ImportCGM symbol
        
        Change-Id: I0d55a57b46fffbeb650ca0b88170372160e1ecf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163631
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-20  Miklos Vajna  <vmiklos@collabora.com>  [2da4acdbf8c5a8ba3ef51e5f5dc3439716e71a91]

        tdf#159285 sw floattable: fix loop with inner table wrapped by inner table
        
        Regression from 868140fcc1311259b9d5f666637b33d226511a53 (tdf#60558 sw
        floattable: allow wrap of table on the right of a floattable,
        2023-12-05), the bugdoc layout looped on load.
        
        Somehow the big while() loop in SwTabFrame::MakeAll() never finishes: it
        always tries again but can't reach a state where all of frame area
        position, frame area size and frame print area is valid.
        
        Fix the problem by going back to the old behavior (floating table is
        wrapped by text frames, not by table frames) for the nested table case:
        that keeps the old tdf#60558 use-case working and fixes the new
        tdf#159285 use-case.
        
        At some point it would be useful to support the combination of nested
        floating tables and the "floating table wrapped by table" combination,
        but that will be a new layout feature.
        
        Change-Id: Ia3fdbd08de87e13ddef086ae1339e79a8833674d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163630
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-20  Mike Kaganski  <mike.kaganski@collabora.com>  [3da833827bd3efae2b5e0911cd6e2dd961c3ad89]

        Simplify by replacing ensuredir with osl::Directory::createPath
        
        Change-Id: I3c60814de88ce126f192fd176142dd003af33d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163588
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ef9e1116d1100af50d7b74dcee5155c81b7b50fb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7d1418f79a28f5e38f65054b27f7062f77952e94
          - tdf#159771 Add XMATCH help page
            
            Change-Id: Ieb8d83a73c6a598614ed5ac76004915fc6cf6de7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163603
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2d2974f22ab59ea7dab1aee778308c4f50ff5464]

        tdf#124098 sc add global config setting "RecalcOptimalRowHeightMode"
        
        to optimal row height recalculation for optimal document loading.
        
        If the "RecalcOptimalRowHeightMode" is set to "Recalc always" we always
        recalculate the optimal row heights at load time, without any warning dialog.
        If the "RecalcOptimalRowHeightMode" is set to "Recalc" we never recalculate
        the optimal row heights at load time, without any warning dialog.
        If the "RecalcOptimalRowHeightMode" is set to "Ask before Recalc" we ask the user
        if want to recalculate the optimal row heights at load time or not.
        
        The default value is the same what we are doing now: "Recalc always"
        
        This option was necessary, since optimal row height calculation depending on also
        the result of the conditional formatted formulas and it takes a lot of time to calculate
        the optimal row heights and load the document. Because we allow a lot of text/cell format
        attribute which are effect on the cell size, therefor it is necessary to evaluate all
        the formulas. Also if we have 20 condition for a cell range we need to evaluate all
        the 20 formulas for all the cells and it is very expensive at load time.
        
        Change-Id: I9288d11dd2f061f85fa36292a909402a6bb89ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163421
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-19  Patrick Luby  <guibmacdev@gmail.com>  [64ca3756416f0355b2008f39120e68ac42269784]

        tdf#126638 dispatch key shortcut events to modal windows
        
        While commit 4f907fbe52749265ba4eb7c40ed187b453bb1de9 fixed
        tdf#126638, it caused the "disallowed action" beep.
        
        Some modal windows, such as the native Open and Save dialogs,
        return NO from -[NSWindow performKeyEquivalent:]. Fortunately,
        the main menu's -[NSMenu performKeyEquivalent:] is then called
        so we can catch and redirect any modal window's key shortcut
        events without triggering the modal window's "disallowed
        action" beep.
        
        Change-Id: Ib1fff68ab159361ceb847881e3a4da4736a33f51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163605
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3297e7345d959b9f486f96167b200a2e13ffb059]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 33a703440353008f3cb62855329e427ac41deedc
          - tdf#159596 Help page for XLOOKUP function
            
            + Added new entries for release numbers
            + refactoring of some other files
            
            Change-Id: I125fc35f1a38599e68857ad0959a5d3777a0a63e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163602
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [96e9c3a7fd2ce877d6d4d87c5333334790f7d85a]

        tdf#50934: Fix compiler complaints and activate OOXML I/O tests
        
        Add tests for input and output of very basic pie-of-pie and bar-of-pie
        charts in OOXML.
        
        Change-Id: I6441d99941ea2aca9bf58ede40dbe8f3d38a3291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Noel Grandin  <noelgrandin@gmail.com>  [191e3f8d891c6d2b5e0f63823a1f9afb7d54418f]

        merge textconv_dict into i18npool
        
        (*) it is a small library
        (*) this avoids more dynamic symbol lookup
        (*) this unblocks more --enable-mergedlibs optimisation
        
        Change-Id: Icb708828e9d711981ec4273351cd73343aa206d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163596
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [9bd2012df77da01b9ee30b25698237fb45673f49]

        ITEM: Speedup SlotIDToWhichID translations
        
        With ItemInfoPackages we now can have a buffered, static
        global translation table from SlotIDs to WhichIDs since
        the ItemInfoStatic used already contains all the needed
        information.
        Register that in registerItemInfoPackage at the Pool and
        use it for lookup. That speeds up the lookup from O(n)
        to O(1). Since that lookup is used in UI and UNO API
        implementations this has positive effect on load/safe,
        but also all interactive stuff in the whole office.
        
        NOTE: I tried to use a merged version of that translation
        table in the parent pool, but this shows double SlotIDs,
        what is no wonder since that's what those are used for:
        To get different WhichIDs for a SlotID in Item handling.
        This *might* prevent getting rid of the chanined Pools
        at all - sadly. The returned WhichID directly depends
        on which Pool the function(s) GetWhichIDFromSlotID and
        GetTrueWhichIDFromSlotID are called.
        
        NOTE: Very strange is that the parameter 'bDeep' in that
        functions is *not* passed down to the call to the
        secondary Pool - probably an error, but risky to fix,
        that may change already the behaviour :-(
        
        Change-Id: Iea77ffad0f6a5401ab74fea0bbfc2589c66680ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163597
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-19  Noel Grandin  <noelgrandin@gmail.com>  [ca935d5a016f5527422058f23c1bf3cb2917fb0f]

        these symbols no longer need to be public
        
        after
            commit de43ed10886ae041b3814f80ef0510f6ac18d515
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Feb 14 10:14:13 2024 +0200
            merge index_data into i18npool
        
        Change-Id: Idae78d824861e382c590b625f9deae48d782ea88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Oliver Specht  <oliver.specht@cib.de>  [c7ef4b2757a5219e12a9b6a5c68b3512026d1ade]

        Fix for test related to tdf#157992
        
        KEYCODE is 'RIGHT' not 'KEY_RIGHT'
        
        Change-Id: I908f11db40737d9c188a9f4464f71ac0c67b40dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163595
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-19  Alain Romedenne  <alain.romedenne@libreoffice.org>  [57000eb225476bcd456853230386cbf6e2ed5520]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d4aff35aba0b2db8179b57b523a94762f55b993a
          - Python Shell script update for macOS
            
            - Eases the identification of embedded Python with Basic
            - Launching Python console with Python remains to be improved
            
            Change-Id: I4b581770166701cccca664d0b5209ccbe8362282
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163172
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-02-19  Oliver Specht  <oliver.specht@cib.de>  [feb08063c47e303bcf399ac90354fbcca1262997]

        tdf#159254 fix import of printer tray in docx
        
        Change-Id: I9f3835800c921dbc90ef09a8dfa3001bed74d2d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163589
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-19  Mike Kaganski  <mike.kaganski@collabora.com>  [ab85fa0f162c40c3c5f00b189d43c554e5a7861d]

        Drop obsolete comments
        
        They seem to have never been useful, ever since commits
        4e093f7f3404d09ee302b119190a968f4f109427 (INTEGRATION: CWS sal05 (1.1.2);
        FILE ADDED, 2004-02-03) and 0318a882ecfa17030bcccbc05d6c34e3293b0ef2
        (INTEGRATION: CWS sal05 (1.1.2); FILE ADDED, 2004-02-03).
        
        Change-Id: Ia68ee2f6facd9b64a098c630c3fed0d227e92e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163587
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [23ff149f36e65f762ed13ce19521427342604c7e]

        OSL_ENSURE->assert, these are unconditional null-derefs otherwise
        
        so might as well make it an assert
        
        Change-Id: Ic0a91bf92c84e50e6c476524b5c3320cd67d1c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [72808cb6383b266e3e3e7844305216b9d6c0a058]

        tdf#50934: Add one of-pie test
        
        Change-Id: I9af705ed671718486d2e46e481b5416e683cdbb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160741
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b2ddc88019852b7731b888e7b8eb669e760a8d7]

        libpng: upgrade to 1.6.42
        
        Change-Id: I03fccf59bb1c2fa51478e812e629ff2ffac0e893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163593
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [d0ced35e7a3e2921febe6dacc42fa5d1390b2846]

        tdf#101313: sw: Add UItest
        
        Change-Id: I629b5e3fabd60c7fc2654eea47393c51be957e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163585
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-19  Regina Henschel  <rb.henschel@t-online.de>  [6e5529d7382558a38e547074e2f674e85e11e66e]

        tdf#70039 convert 3D effects to extrusion
        
        ODF allows a 3D mode for custom shapes. That can be used to render
        some of the 3D effects possible in MS Office.
        
        MS Office has not published, how they calculate the 3D-scenes. Thus
        most principles and values are found by experiments. My assumptions
        are contained as comments.
        
        This current solution does not work well for perspectiveFront camera
        with rotation on only y-axis or on only x-axis. If someone has an idea,
        what is wrong in my solution or what MS Office might specially do,
        please tell me.
        
        The tests do not cover whether the rendering in LO is the same as in
        MS Office. I have no idea how to write such tests. To test manually:
        In Powerpoint: Copy the shape and set the copy to wireframe. Cut the
        copy and insert it as svg image. Move the image so that the lines cover
        the original shape. Save it. In LibreOffice: Open the file and set the
        shape to wireframe. Now you can easily compare the rendering of
        PowerPoint and LibreOffice.
        
        Extrusion can be used for images, that have a 3D-scene applied like in
        tdf#45495. That would work with this patch, but the related places are
        commented out because of tdf#159515.
        
        This patch does not cover lighting and material and it does not
        contain export.
        
        3D-text is not contained in the patch. There are principle problems
        with 3D-text. Thus a solution requieres a lot, including additions to
        the ODF standard.
        
        The comments in tdf#70039 contain more about aspects, where MS Office
        and ODF are in principle incompatible in regard to 3D-effects.
        
        Change-Id: I8a5da536ade2a4b67630af221ea47e0288450188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162594
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81adba0eeed883b939477259ac53c04459d25a4c]

        tdf#155961 put some spacing to the right of the "more options" toolbar
        
        the gtk overlay scrolling is all very pretty, but you can't click things
        underneath, and there is no discoverable way to dismiss the scrollbar
        to get "under" it, move this widget to the left a little to try and get
        it outside the hotzone for the overlay scrolling.
        
        Change-Id: Ic9d48be4a29754e9aff0f29dbe32bea762b6cc09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163586
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e81f4656225cd474086340481a4505e3e932f8e6]

        crashtesting: bump refcount during setBuffered2DDecomposition
        
        otherwise if another thread drops the refcounf to 0 while
        setBuffered2DDecomposition is in flight the object goes away underneath
        us.
        
        Change-Id: I65d458306bee0c4f2e80fd2925d22cf121920fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-19  Jaume Pujantell  <jaume.pujantell@collabora.com>  [043e090069b3bd4c660743f6f639d002f403a7b8]

        libvisio: read and use simple solid fill styles
        
        Implemented the reading of simple solid fills from the fill styles list
        in a vsdx theme. And it's use with the quick style fill matrix value.
        
        This patch includes an alternative fix to tdf#77915 so the previous patch
        is no longer needed.
        
        Change-Id: Iccfe915c90bcb1280cfcbfa4920d2989d18518ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163581
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit fb9ca6bba9bc3ce9feb9a066636dcd986dca096b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163544
        Tested-by: Jenkins

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [2b4e95b8f0e04a3c60df1887276068a9674d3d16]

        tdf#50934: Rudimentary UI images for pie-of-pie and bar-of-pie
        
        Change-Id: If2ddf1ea12804717583ab6df18dc7fbfffc37d31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [cf2715782d9ccb2acf46dc316e9a8c6990bdf368]

        tdf#50934: Fix color of composite wedge for imported of-pie charts
        
        Change-Id: I5236ed53e418e31a470a66bdbe21eceaa5f6fc04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Miklos Vajna  <vmiklos@collabora.com>  [7d1e5fdf4b0a9ab41e496dd2c4ff4f0653cf982f]

        CppunitTest_sw_tiledrendering2: extract one test from the old, large suite
        
        Not a split, to avoid too many conflicts while cherry-picking, but at
        least create a new suite where next tests can be added without too much
        build time after source code edits.
        
        Change-Id: I0fb95e91ca9289aad25f72b0faa5f8eca3c6c06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163582
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-19  Mike Kaganski  <mike.kaganski@collabora.com>  [3c01b243a5c939e7cac32e7d2ec6095ace091df7]

        Unfriend SetTempNameBaseDirectory
        
        TempFileNamed: :GetURL is enough in this case.
        Change-Id: Id5eb66103328b063cb7dc64472fc5ba556a51109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163578
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [67e58d16f25332d2c96e2c9702bd78e9d76501c0]

        tdf#50934: Fix left of-pie ordering for imported charts
        
        Change-Id: I490d6719f5190b0e889bd274ffa9c1b196e656d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Miklos Vajna  <vmiklos@collabora.com>  [e3c0aeec8385cba90b4fb21d2c9032efa61a8e82]

        svx: prefix members of XFillGradientItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I3d951d553d524cedc876330a70e6fe94edba0173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163579
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ba92b5f1eaf7d4447a0943ea260db515ca799dc]

        hide more symbols
        
        using the bin/find-can-be-private-symbols.py script
        to find classes with large numbers of exported symbols
        that can hidden.
        
        before
        exported       = 58104
        imported       = 30810
        unused_exports = 35433
        
        after
        exported       = 55094
        imported       = 31073
        unused_exports = 32423
        
        Change-Id: Idd0a70ee3740afd5ca1a86771e0e2ff8090d102d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Mike Kaganski  <mike.kaganski@collabora.com>  [5f0021cdd0b84fccaecf23a014622f0aca86430c]

        Drop 'using namespace osl' for consistency
        
        Change-Id: I9fb1cf011bc982f2e9722c6b69ce2420b21b4083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163577
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-19  Mike Kaganski  <mike.kaganski@collabora.com>  [0b58f1a41bf8d58426f16e47f86d313172ad4585]

        tdf#159769: always make sure that default temporary directory exists
        
        This basically undoes commit 4743a32b4f991c57e4b8a66adf035b1808ca793a
        (only need to create the folder for temp files once, 2022-05-18). To
        avoid the overhead in TempFileFast, it now uses a new function to get
        the path, which doesn't check that path exists.
        
        Change-Id: I9c910a55dc4992058a7168690561b02d682b5e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163576
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [132abb81ce48e43a23266345e4c4494c5e200a4f]

        Adapt tooltip to recent changes
        
        This option is not the equivalent of resetting the user properties in File->Properties,
        so remove that information from the tooltip.
        
        Change-Id: I0718443452b9285c8e7ba0d742aed790ed6a2403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163433
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [dfacc5a522a7458646f4ec42b9fc58c1f3fdb0a8]

        tdf#50934: Try to fix wedge ordering for imported of-pie charts
        
        Change-Id: I6e9a0d5426fb213c99ee99092596f68d688b928c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9d74fdd4650abc8e7d94abd58539fc7cec112549]

        Fix typo
        
        Change-Id: I1dfd26367974b614660fcb50724b9b2d419ac55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163559
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ca37768d69d7603e6b8e6a8765309a1b9f1bf8f]

        Fix typo
        
        Change-Id: Ib8bb065c5567bbe8d6f0746fc04484566a616596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163558
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-19  Kurt Nordback  <kurt.nordback@protonmail.com>  [1cda27cf69054b006aa1b16cab8f56339274588b]

        tdf#50934: OfPie inport from OOXML, plus initial work for export
        
        Change-Id: Ie17b583af28d274b3e7817c646dd4f5873e03fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bbc9ac1f08a5ee4b9f65eaf10110df328d95de95]

        Fix typo
        
        Change-Id: I36a60afb2aced43342b120466bffcb7c2c93ad3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163557
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b36ecef07a4933c0943b27ea937f31e1df2e77cd]

        tdf#128425 Add Excel2021 function XMATCH to Calc
        
        https://issues.oasis-open.org/browse/OFFICE-4155
        
        Change-Id: I7791ab873cf62ce882feba75dc0d722bc5990f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163260
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-18  Patrick Luby  <guibomacdev@gmail.com>  [3e0f6665e3c9b7432404eb49efd74bff91f62935]

        Revert "tdf#152524 Add a __objc_fork_ok data section for Mac Intel executable"
        
        This reverts commit c6652e280b0690497abf27380dd064898f91db32.
        
        Reason for revert: patch may no longer be needed after commit b0656e6ca668a0719fbcb71b6d46c68093dda470.
        
        Change-Id: I20da2d0ff576f82272efbb193148e77c44a73d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163540
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [cebbd5795d6256fb346ac8d70c15daceca48c554]

        ITEM: Rename for more control over SlotID usages
        
        Change-Id: I51585f1c15984a066262023184f668662853d20f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163556
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-18  Noel Grandin  <noelgrandin@gmail.com>  [d367142731f09c7be03ce1707e3aeab3c55b4f21]

        restore comment I removed in
        
        bb3157e38bfffd23505abc35f790043392f43d2c
        
        Change-Id: Ib0b81a5e39657bdd73dd3a8659bb0c346b5532e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-18  Mike Kaganski  <mike.kaganski@collabora.com>  [731c731190239780dbace32372daf2477101970a]

        Simplify a bit
        
        Change-Id: Ic48cb53f441b1505103d9bbdec67953528fd2525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163552
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-18  Kevin Ottens  <kevin.ottens@enioka.com>  [63efbc8ad8aae12b54e649c1495d1233c1a9b33f]

        tdf#55004 Fix backup copy creation for files on mounted samba shares
        
        There is an unfortunate interaction between file locking and backup
        creation at save time.
        
        openFilePath has logic to lock a file when opening. This goes through
        fcntl to set a write lock on the file. Later on, when the user wants to
        save changes, a backup copy might be created (very likely now since this
        is the defaults in the settings). To create this backup, the file is
        opened again for reading. Unfortunately this open call fails due to the
        lock (even though it is a write lock).
        
        This commit changes the behavior. osl_file_adjustLockFlags now checks if
        the file is on a mounted samba share. If that's the case we force the
        osl_File_OpenFlag_NoLock flag. No issue is then exhibited at backup
        creation, allowing the save to proceed properly.
        
        Change-Id: Ieab252f9f68598834e13339fc5fcea440f0a4c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162935
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-18  Mike Kaganski  <mike.kaganski@collabora.com>  [2d0a365bff91d56790bcb17212e9d819835f0258]

        Drop twipFactor, and use Point::scale
        
        Change-Id: I044865882f71e18d1b5f0d87993d865a128ac585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163550
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-18  Patrick Luby  <guibmacdev@gmail.com>  [4f907fbe52749265ba4eb7c40ed187b453bb1de9]

        tdf#126638 dispatch key shortcut events to modal windows
        
        Some modal windows, such as the native Open and Save dialogs,
        ignore any key shortcut events so use the same existing special
        dispatching code that -[VCL_NSApplication sendEvent:] uses to
        dispatch key shortcuts to non-modal, non-LibreOffice windows.
        
        Also, disable all menu items when displaying modal windows. For
        some unknown reason, key shortcuts are dispatched to the main
        menu instead of the modal window so enable the "autoenabledItems"
        property instances so that -[SalNSMenuItem validateMenuItem:]
        will be called before handling a key shortcut and the menu item
        can be temporarily disabled if a modal window is displayed.
        
        Change-Id: I6c06024dd6ed05a4ee83f2b37e29c555b52ef555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163527
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [9a41cafae06fc01d7ee0764898cba526b7944b52]

        IASS: Preparations for InterActiveSlideShow
        
        The idea is a long wanted feature, to allow the
        EditView to stay active during a running Presentation
        so that you can do changes which then directly show
        up in the running presentation. This will need quite
        some steps. To be on the safe side all of the changes
        are isolated by a variable to cause no harm. For
        now this uses ENVVAR ENABLE_INTERACTIVE_SLIDESHOW,
        but that may change e.g. as config entry or option.
        
        Change-Id: Id0ab9a473603225456206fbd933e932248681509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163514
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-18  Mike Kaganski  <mike.kaganski@collabora.com>  [95e6f942b3fa5c6f3e5473ac474a4702ab815502]

        Clarify unit conversions in calculation
        
        Commit f840a0d54d873d3003f8b624a50557f8c9872477 looks confusing with
        the different units mixed in the same expression. It seems to do this:
        
        1. Multiply a side of aOrigOutputAreaTw by other zoom (so it looks to
           be using scaled twips!);
        2. subtract a side of aOtherEditRectPx multiplied by twipFactor, i.e.
           some size in mm/100s (!);
        3. The result is divided by other zoom, and multiplied by this zoom;
        4. The result is divided by twipFactor, i.e., converted from mm/100s
           to pixels;
        5. The result is added to a side of aEditRectPx.
        
        But if #1 is in (scaled) twips, #2 is wrong when adds mm/100s to it.
        
        This change refactors the calculation, breaking it into steps, using
        correct unit (taken from the respective OutputDevice), zooming using
        o3tl::convert (to avoid integer truncation), and minimizing resulting
        rounding error.
        
        Change-Id: Ic85eea12063720b2962828ab96408c4140a09202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163529
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [6a4b9bf503204b5770ad314eae0bfed18c5d84c7]

        tdf#130857 VclBuilder: Use VclPtr instead of raw vcl::Window*
        
        `VclBuilder::handleObject` returns a `VclPtr<vcl::Window>`.
        Use the same for the local variable `pCurrentChild` that the
        return value of the former is assigned to.
        
        There's no reason to use a raw pointer here and explicitly calling
        `VclPtr<vcl::Window>::get()` also makes it harder to reuse/share
        the existing code for an upcoming `QtBuilder`, s. Omkar's comment
        in his pending Gerrit change [1].
        
        While at it, also move the declaration of `pCurrentChild` closer
        to its first use.
        
        [1] https://gerrit.libreoffice.org/c/core/+/163103/comments/f37a6add_b0f00eb1
        
        Change-Id: I30520d5d18453c78150b2b0c9af044e043a1c74f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163528
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-18  Kurt Nordback  <kurt.nordback@protonmail.com>  [1036994301de43f5a41134084ca866ed9ec7bf35]

        tdf#50934: Add a comment
        
        Change-Id: I3986242fa584310acccba4830d8872043381cef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-18  Kurt Nordback  <kurt.nordback@protonmail.com>  [e1573deaf1b2ecd946d23a4ce623546c08036ec7]

        tdf#50934: Implement connector lines for pie-of-pie
        
        Change-Id: Ifca083aa07b28d5c604382decaefedfe653ff8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [670de4eadcbb84394fd49c1c0c949dd35bd2303b]

        Latest VS 2022 Preview is 17.10.0 now
        
        ...while latest proper VS 2022 is 17.9.0
        
        Change-Id: Idbd104d54dde1822957894d4f74b16e651a4c8b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163485
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-18  Luv Sharma  <luvsharma.del@gmail.com>  [35d859d1ae23ed1fe3ea92a1d75be5f31a4241b7]

        tdf#45904 Remove old SwXFootnoteProperties Java test
        
        Change-Id: I20f160d557364ffc5240403d6e2c53b5b135ba46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163524
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-17  Pranam Lashkari  <lpranam@collabora.com>  [a0bd028a00165996224c93a4eba4b6affe6743e0]

        writer: LOK: make sure redline comment undo/redo is notified
        
        problem:
        when actions were performed on comments and changes were tracked,
        LOK was not notified and actions were not reflected
        
        Change-Id: Iad4d9338a6205278b586106e8f39769b731f18dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163357
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 0b7a9c231f66b5c2659ab3aa6a0f3c7991b9e721)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-17  Pranam Lashkari  <lpranam@collabora.com>  [974d6b443208050b0aa3ae8df32e121ab7a474ec]

        avoid using subView on empty OUString
        
        it causes assertion failure
        rtl::OUString SwPaM::GetText() const: Assertion `(nEnd-nStart) == (aTmpStr.getLength() - nStart)' failed
        
        Change-Id: Ie479f224e8a1516735f96c3a09181d4c46dba10d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163461
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 0b0b70772f2d9836010e523bff0132b626713862)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163501
        Tested-by: Jenkins

2024-02-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [021c93bbf36a9d25ad43da0aefd39d5e7bfdad19]

        kit: editing text in shapes outside the topleft tile has misplaced text
        
        keep into account the zoom factor as we do elsewhere
        
        Change-Id: I024ba16c2ef47c01f05ffb8630ec0ae3b2d2e5a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163515
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163526
        Tested-by: Jenkins

2024-02-17  Kurt Nordback  <kurt.nordback@protonmail.com>  [5d0093e8c3a862172ca96081d68e7757dfdf6067]

        tdf#50934: Improvements to fill color for of-pie composite wedge
        
        Change-Id: Ib9f7e3b135bb86e1817edf97b963e3620af7fdf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [b065496b23f249d9c08a6267d2aaa2fd1c81e56a]

        Remove more unneeded const_cast
        
        Change-Id: If62cf2011ae63501cdf5e87a6ee7402aa74b2b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163525
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8baacea92374319e6f796dca4d1aec7663647105]

        clarify that "twipFactor" converts from pixels to 100mm
        
        Change-Id: I7ce9a797b2a2132f0858dafc98bc3a105b8d0098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163479
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [923b1ad7b7bc249838aa619361974f0e3134ab6a]

        sc: Show warning for a XLS document with unknown encrypted part
        
        If a document contains a "DRMContent" section that we don't know
        how to decrypt, show a warning before showing the un-encrypted
        content.
        
        Change-Id: Id7f48b68e1d65ce46434906b2fb3c7912dcc5f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163513
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [347890c05e689cecc9361b4c2ebd25cb3b87f8e7]

        editeng: remove getHeight as a similar GetHeight already exits
        
        Change-Id: I947b736b2c1eb8a6f0155460b4dc61d504623ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163510
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [1f5efbf8b9ba3fd5887c58574dfed3bf31cd020e]

        Generalize search algorithms in sorted_vector
        
        This allows to simplify the code somewhat, and also to relax requirements
        to the arguments, e.g. allowing to pass const objects to search in vector
        containing non-const objects.
        
        Change-Id: Id34911a8694bbdec275d22b51ca4a0845c9fa4c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163519
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-17  Laurent Balland  <laurent.balland@mailo.fr>  [39048e0c0e9af455197ff57cc2947f8fb23e8542]

        tdf#158623 Remove thumbnail.png of Wizard template
        
        The preview pictures of the templates used by the wizards cannot be seen
        by user.
        
        Change-Id: Idfa0a5b5593f2815582ff34e48330ad9d563992b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161513
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-02-17  Laurent Balland  <laurent.balland@mailo.fr>  [5378ce372ae29fcb06c5134c18f935c1c7ea3c51]

        tdf#158890 Replace '?' with figure blank
        
        ...instead of regular blank
        Do not modify other blanks (thousand separator, fraction separator)
        
        Change-Id: I82f8023a4e55d8091545191dee55a88aba25dbdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161737
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-02-17  Laurent Balland  <laurent.balland@mailo.fr>  [e66ffda7c7f1e78dbca082ff7549ded121dc7356]

        tdf#129701 Skip empty cell: treat last column
        
        When pasting data as text, with "Skip empty cells" not checked, empty
        cells in the last column of the source do not empty cells in
        destination, because there is nothing anymore to paste and while loop
        stops.
        This commit adds a flag to check if the last cell of each line is empty,
        and treat it if "Skip empty cells" is not checked.
        
        Add UITest to Copy data with empty cells;
        Paste Unformatted text, without "Skip empty cells";
        Check data with empty cells in last column.
        
        Change-Id: Idec823fb1c27b803f49c6d13d6c757ef0f41e437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160951
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2024-02-17  Kurt Nordback  <kurt.nordback@protonmail.com>  [4df39957bd985af591f452439c8aa5fc5c7a0d62]

        tdf#50934: Ensure of-pie connector lines are black
        
        Change-Id: I0548b395455eb17ec06f85ffce63affa15075391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-17  Kurt Nordback  <kurt.nordback@protonmail.com>  [756f8c850a38679e5b1b8c68c4c2ea5fe4883fbd]

        tdf#50934: Initial implementation of connector lines for bar-of-pie
        
        Change-Id: I586dd5ae784f5e86ad1e0d863765b058873eac68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-17  Kurt Nordback  <kurt.nordback@protonmail.com>  [853736f0d523c4f5459e15e7e109e81340f8c25e]

        tdf#50934: Fix of-pie subchart colors
        
        Change-Id: I43e0118786853b0258741e5181f7e622c6f747ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-17  Justin Luth  <justin.luth@collabora.com>  [5132255021aa61f8a1fa7d8de820cb3528699812]

        tdf#153761 vml export: avoid corrupt docx: don't write empty r:id
        
        For the benefit of MSO, do not write r:id="",
        since MSO refuses to open such a document.
        
        Change-Id: I21887021c747fc9a9764befc7081e21d99e47545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163523
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1e1072afa3726266f83d7ef8895ed406580a3450]

        sc: Handle xls documents with unknown DRM encryption better
        
        If we can't decrypt the document, don't set the SotStorage to
        an empty SvRef. It is possible the document contains a "fallback"
        un-encrypted document, which we can show. This is typical for some
        Excel add-ons, which encrypt the document, but also add a part
        that is un-encrypted to write the instructions on how to get the
        add-on.
        
        Change-Id: I6079786b1d0dce3a819a70e057699d0a461a5be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163511
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5a4ab8cb3a3fbf15de11afc5d8876aaa8a7784c9]

        for caching if a font has glyphs, strikethrough and underline don't matter
        
        Those aren't part of the font. Likewise it's safe to assume these days
        that if the glyph appears at one size it will exist at any size.
        
        The same isn't through for Bold/Italic. A font like Freesans has,
        or had at least, glyphs in one variant not in another. So don't treat
        those properties the same.
        
        Change-Id: Iccc291642dfe7e9d2cb06a241a575fd1e4a4bb9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163509
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-02-16  Noel Grandin  <noelgrandin@gmail.com>  [4df426e429e1aed92f074d8acd3ba3a5ec335ba9]

        tdf#101313 Copy-paste table from writer to calc
        
        With Merged Cells from Writer to Calc,
        Cells Placed in Wrong Position (Wrong cell offsets).
        
        regression from
            commit ed24564ce11683731b820c29d5a46e073ab7a2a7
            Author: Noel Grandin <noel@peralex.com>
            Date:   Thu Jul 19 15:22:31 2012 +0200
            SV_DECL_VARARR_SORT(ScRTFColTwips) o3tl::sorted_vector
        
        Change-Id: I8c90c19f6a27a368fd5807b3eaab84ce820e26e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163518
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-16  Attila Szűcs  <attila.szucs@collabora.com>  [9ed6d80622174826f8b7413529320ccd94782296]

        tdf#154248 sd: change multiline field wrapping
        
        Modified ImpEditEngine::CreateLines and ImpEditEngine::Paint
        to wrap multiline fields (hyperlinks) to wrap better:
        
        Multiline hyperlinks can start/end in the middle of a line.
        like this:
        text hyperlink-start
        hyperlink-line2.....
        hyperlink-end text
        
        Start of the lines of the multiline hyperlinks now follow the line
        start (for example if the 1. line has a bullet/indent, and the
        2. line does not then the multiline hyperlink 2. line will start
        where normal 2. line would start)
        
        Changed the way how fields wrapped while editing.. (we didn't split
        fields into lines, when its textbox is edited, but now we do)
        This way it is more a WYSIWYG editor. (when we edit, we see what
        we will get)
        
        Changed the constant reference rLine to non-constant pointer
        pLine, because this hack change the actual line to the next line
        at the end of a muliline hyperlink, so the algotithm will
        continue calculating with the next line, as if it would be still
        the previous line.
        
        Change-Id: I2c67f4ae1b86ee9c73f01ae0c045f02e56a09c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162503
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-16  Miklos Vajna  <vmiklos@collabora.com>  [f5ecfd0754cef194e670d4db0fea8bbe4c6fe2c9]

        sc: add a debug env var to control the target of the HTML export
        
        Similar to 9f6b7af1a6f4f5b18dc9f8c8371ba579105665a3 (sc: add a debug env
        var to control the source of the HTML import, 2024-01-18).
        
        Change-Id: Ibe9b2f7316ee634f98a16508e5574c1406b4204a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163488
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2dff7ca92cb785eb3b60556219aead77b066a780]

        Drop some unneeded const_cast
        
        Change-Id: I33fb2d74a0cacbf1781e670a23bd451e6ba02027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163476
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-16  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3c3270c3527ce5bb7653727bc7749e4d58ba64cc]

        ITEM: Better test for DynamicDefaultItems
        
        Change-Id: Ie18f18655e4ee9ca70580b540678003a12b0465d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163458
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-16  Hubert Figuière  <hub@collabora.com>  [e86c6423d6ec9641dcc2ea3748d74759cd8e67fe]

        calc: sheet protection dialog is async
        
        Change-Id: I33930ae212a8b35a4430df3180f4ffcca86ff870
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163496
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [c5e7af92ebcde59cb72fda2a88d08dc6656dc2e2]

        nss: upgrade to release 3.98
        
        Fixes CVE-2023-5388
        
        Also update README, and remove obsolete documentation of Debian's
        mangled SONAME; relevant Debian changelog:
        
          nss (2:3.13.4-2) unstable; urgency=low
        
          * debian/control, debian/libnss3*, debian/rules,
            mozilla/security/coreconf/*, mozilla/security/nss/lib/*/manifest.mn:
            Move to unversioned library. ABI compatibility is ensured upstream, and
            the SO version, if it needed a change at any time, would be a change in
            the library name. There is no reason to keep making compatibility more
            difficult with other distros and upstream binary releases. While previous
            versions were one-way compatible (binaries built against other distros or
            upstream nspr could work on Debian), this approach works both ways.
        
          -- Mike Hommey <glandium@debian.org>  Thu, 17 May 2012 09:45:36 +0200
        
        Change-Id: Ifc1eae68827fa88ae001a3903c8555af67b488ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163482
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-16  Miklos Vajna  <vmiklos@collabora.com>  [ce350b840ce806c4060f9fdbd67fa4c95c82edf5]

        cool#8270 sw lok: fix bad statusbar pagenum string on async binding update
        
        This is similar to commit 51d8a2ef54751403fa707816e27ddb4e7faa8231
        (cool#7492 sfx2 lok: fix bad view id / statusbar string on async binding
        update, 2024-01-08), but here the problem was that the async job tried
        to get the current view from the model, which is not correct.
        
        Fix the buggy page number string in the status bar by requesting callers
        of SwViewShell::GetFirstLastVisPageNumbers() to provide the view, given
        that SwViewShell itself doesn't have access to SwView, only the
        SwWrtShell subclass would have that.
        
        Change-Id: I7e10c05d2429ea2771d6c3e46ac9ce77c0eb2bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163474
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-16  Oliver Specht  <oliver.specht@cib.de>  [3b04e74503ec6d07dc4befdb756e6abdc3de4e58]

        tdf#159730 add compatibility option in RTF import
        
        Set IgnoreTabsAndBlanksForLineCalculation in RTF import to improve formatting.
        
        Change-Id: If0129f748c48400f1dd882672b5779f62e685ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163429
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2024-02-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fdd524cc9b5d92df95b02d30c2a92c2b4ee8035a]

        Remove exec bits on odt file
        
        Change-Id: Iecf57f457c21fb544becc1ec88300be3ef675815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163483
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-16  Attila Szűcs  <attila.szucs@collabora.com>  [f846efa507252b0584d2753a251f2dd99c34541a]

        tdf#67347 pptx import: stacked text, minimal impl.
        
        Display Stacked text, and
        Import/Export Stacked property from/to pptx.
        
        It is a minimal implementation, it does not import/export to .odp,
        there is no user interface to set this property.
        
        Multiline Stacked text is rendered as 1 line text.
        XML_wordArtVertRtl is mapped to XML_wordArtVert.
        
        Editing of text containing space character seems to
        not work correctly.
        
        Change-Id: I535da45e3a2f2d1550bad2a40e9909e0d561d0ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163121
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4897792975453024db8369c3d8c5f2e65c956d73]

        OpenSSL: upgrade to 3.0.13
        
        Change-Id: Ib03c99a2dbf0f7c932b8a6b953ac9eb9c43f978f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163475
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-16  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d6f2f7aca93796370575875a291e15436922b2e9]

        Resave with newer Glade version
        
        Change-Id: Id3a9d60a82cfee0ccbb1275a32274697b54ebff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163445
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-16  codewithvk  <vivek.javiya@collabora.com>  [4965b055b5998dc345ecaeb80fc8c3874b19e2a5]

        Chart: Make Data Range Dialog Async
        
        To reproduce the step, double-click on the chart and right-click to open the context menu, where you can see the option for data ranges.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: I0697d5918d35d132aa7c17f86204742017f7ff17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163358
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit afbb4e44478e520b866032df8f0a0a344568233e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163402
        Tested-by: Jenkins

2024-02-16  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [88ba9fab08514b96f458bb8c0ace175b2790638e]

        Prepare search code for other functions than MATCH and XLOOKUP.
        
        Purpose is to use one set of code for all similar lookup functions, as
        they now each have their own code, which is largely identical.
        Next steps will be to make the code used by XLOOKUP and MATCH work with
        each similar lookup function.
        This patch just changes the interface to accomodate other functions.
        
        Change-Id: I6950aa69404f3eb8acbf2d55e247058f3e798814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163230
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-16  seturaj  <seturajmatroja@gmail.com>  [b508e4f0813b62c3e5d10a2fbacec1fb8839ece4]

        tdf#42982: Improve UNO error reporting. Make exceptions more descriptive
        
        Change-Id: Idb292c508029efeb23ed969c9fad566154cb424c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162354
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-16  seturaj  <seturajmatroja@gmail.com>  [c67f138ed80e1e50638901a6b6e16946b4bcd92d]

        tdf#114441 : sal_uLong to better integer types
        
        Change-Id: I7c9df411775812cfea4a41e84d34782cc5a9578e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162424
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [eebdda4e221327cae5a9177893394819ca510d5f]

        tdf#159502 libxml2: apply Solaris ld patch only on Solaris
        
        Diverging from upstream by inventing a LIBXML2_GLOBAL_VARIABLES version
        should only be done if actually required.
        
        Change-Id: I1520ca5078dc24ffd83e927f9c857d625e71749b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163455
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [6f6364e572a0570fb097fec098314bffadc5b474]

        tdf#159502 remove --without-system-libxml from LibreOfficeLinux.conf
        
        configure.ac explicitly excludes libxml from --without-system-libs but
        this distro-config "helpfully" adds it explicitly, when the system
        already contains a usable libxml/libxslt anyway.
        
        Change-Id: I79d65d9ed9185277ffde8624efc152b290a6ffb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163438
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-16  Kevin Suo  <suokunlong@126.com>  [90d22daf99e3d07ba19b7d16f240ab53b0873d49]

        tdf#142467: restore "final" in CandleStickChartType class
        
        The "final" was removed in commit
        e06f2bb00137655dbf6f0a8c8c2fc555720f4d3f (tdf#142467 crash on calling
        'getInfoHelper' in final class, 2021-05-26)
        and commit
        6cb1745c24c7651050e30216860c539fa13cc0e2 (tdf#142467: Update comments
        with GCC bug ID, 2021-05-31)
        due to a bug in gcc <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100797>.
        
        Now it has been amost 3 years past and that gcc bug has long been fixed,
        so it is time to restore the "final".
        
        Change-Id: I7db9fe59209cfbae4c04bb3a91cd764db9a38d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-16  Andras Timar  <andras.timar@collabora.com>  [f25b7efba56757b085f7a836f57d9c2fc8fd14b8]

        nss: upgrade to release 3.97
        
        Change-Id: If0eaf6a93f57239d81491c635922745bf3f38fd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163410
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-16  Miklos Vajna  <vmiklos@collabora.com>  [1599fd7398c17276bec06e51ba144d1e694e6657]

        sw doc model xml dump: show the frame format of the table boxes
        
        Ideal would be to show the entire table box, we used to show
        pBox->GetFrameFormat()->GetAttrSet(). Improve this to at least show
        pBox->GetFrameFormat(), which exposes the name of the table box format,
        which should help debugging.
        
        Change-Id: Ifd024e6c0720ab20d0f89b50f0d1472cd5762a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163473
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-16  Kurt Nordback  <kurt.nordback@protonmail.com>  [e9658eaa17591e9d1e380054da27ab6c5734f9af]

        tdf#50934: Implementation of bar-of-pie, plus minor of-pie fixes
        
        Change-Id: Ib343953ee30124524884859c8fe9e88d2dc7d822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160726
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [e808e4643002aa6d2e749afca75fe923c8b2bf8e]

        harfbuzz: upgrade to 8.3.0
        
        Change-Id: I498658405b3b9fe416295f8a97bc2df7f38e5d3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [88192717f9e311dc810e472aec5fcdd50c922c35]

        Simplify a bit
        
        Change-Id: I31b31b112433ef7b5b75ff300d7ecf92f3fbcc03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163472
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [512b09ec51cfbe9bb0ce1a7f229b443dc427f6f3]

        tdf#92389 sw a11y: Use SolarMutex in SidebarWinAccessibleContext
        
        Hold the SolarMutex instead of of using a custom mutex,
        since `SwAccessibleMap` methods that get called require
        the SolarMutex to be held.
        
        Fixes a crash/assert when interacting with Writer comments
        using the mouse while the Orca screen reader is running
        when using the qt6 VCL plugin.
        
        Backtrace:
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007f0a462a81cf in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007f0a4625a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007f0a462444b2 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007f0a462443d5 in __assert_fail_base
                (fmt=0x7f0a463b8dc8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7f0a3d775838 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=file@entry=0x7f0a3d7757f0 ".../libreoffice/vcl/source/app/dbggui.cxx", line=line@entry=35, function=function@entry=0x7f0a3d7757cc "void ImplDbgTestSolarMutex()") at ./assert/assert.c:92
            #5  0x00007f0a462533a2 in __assert_fail
                (assertion=0x7f0a3d775838 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7f0a3d7757f0 ".../libreoffice/vcl/source/app/dbggui.cxx", line=35, function=0x7f0a3d7757cc "void ImplDbgTestSolarMutex()") at ./assert/assert.c:101
            #6  0x00007f0a3ca733b4 in ImplDbgTestSolarMutex() () at .../libreoffice/vcl/source/app/dbggui.cxx:35
            #7  0x00007f0a452ccfbb in DbgTestSolarMutex() () at .../libreoffice/tools/source/debug/debug.cxx:54
            #8  0x00007f09f8fd3903 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x55fa8fd89930, pFrame=0x55fa8ecddb00, bCreate=false) at .../libreoffice/sw/source/core/access/accmap.cxx:1777
            #9  0x00007f09f906f684 in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() (this=0x55fa8f83e600) at .../libreoffice/sw/source/uibase/docvw/SidebarWinAcc.cxx:65
            #10 0x00007f0a31e6244c in QtAccessibleWidget::parent() const (this=0x7f0a280b6150) at .../libreoffice/vcl/qt6/../qt5/QtAccessibleWidget.cxx:322
            #11 0x00007f0a3095b51a in AtSpiAdaptor::accessibleInterface(QAccessibleInterface*, QString const&, QDBusMessage const&, QDBusConnection const&) (this=0x55fa884876c0, interface=0x7f0a280b6150, function=..., message=..., connection=...)
                at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1592
            #12 0x00007f0a30959934 in AtSpiAdaptor::handleMessage(QDBusMessage const&, QDBusConnection const&) (this=0x55fa884876c0, message=..., connection=...)
                at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1460
            #13 0x00007f0a2ee88ad3 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, QDBusMessage const&, int) (this=0x7f0a28010b60, node=..., msg=..., pathStartPos=27)
                at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1448
            #14 0x00007f0a2ee897b8 in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x7f0a280b8400) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1604
            #15 0x00007f0a31445095 in QObject::event(QEvent*) (this=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:1447
            #16 0x00007f0a2f5a696c in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=0x55fa872f63e0, receiver=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3298
            #17 0x00007f0a2f5a677d in QApplication::notify(QObject*, QEvent*) (this=0x55fa873956b0, receiver=0x55fa884876c0, e=0x7f0a280b8400) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3249
            #18 0x00007f0a313b1162 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55fa884876c0, event=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1138
            #19 0x00007f0a313b1d0b in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55fa884876c0, event=0x7f0a280b8400) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1581
            #20 0x00007f0a313b33c4 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=0x0, event_type=0, data=0x55fa87311df0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1936
            #21 0x00007f0a313b255e in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=0x0, event_type=0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1770
            #22 0x00007f0a318384ac in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x55fa873b8c20) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:244
            #23 0x00007f0a38d111f4 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #24 0x00007f0a38d14317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #25 0x00007f0a38d14930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #26 0x00007f0a31838d41 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55fa873987a0, flags=...) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:394
            #27 0x00007f0a30b5c418 in QPAEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55fa873987a0, flags=...) at .../qt5/qtbase/src/gui/platform/unix/qeventdispatcher_glib.cpp:87
            #28 0x00007f0a31ed9a40 in QtInstance::ImplYield(bool, bool) (this=0x55fa873d30f0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:453
            #29 0x00007f0a31ed9b69 in QtInstance::DoYield(bool, bool) (this=0x55fa873d30f0, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:464
            #30 0x00007f0a3cb39434 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:390
            #31 0x00007f0a3cb3a1d2 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:474
            #32 0x00007f0a3cb39127 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:368
            #33 0x00007f0a46437216 in desktop::Desktop::Main() (this=0x7ffd0478dce0) at .../libreoffice/desktop/source/app/app.cxx:1614
            #34 0x00007f0a3cb585f6 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229
            #35 0x00007f0a3cb5890b in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261
            #36 0x00007f0a464a4367 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94
            #37 0x000055fa860a09d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #38 0x000055fa860a09ba in main (argc=3, argv=0x7ffd0478df08) at .../libreoffice/desktop/source/app/main.c:49
        
        Change-Id: If6df884fe94b2aac74be1b9fb13356bf765119d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163379
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [0b3158e64e70a53528155eee38c2ea0ba1d3bf93]

        svx a11y: Drop AccessibleTextHelper_Impl::GotPropertyEvent
        
        Use `AccessibleTextHelper_Impl::FireEvent` directly instead,
        which is in my opinion more readable, in particular since
        2 of the 3 uses were sending an `AccessibleEventId::CHILD`
        event, which is not really about any property.
        
        Change-Id: I446d2d7a841397b215bf099528920bcc6ee9f227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163428
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [694670e13143f41e211dd0e183516d08008dd12b]

        tdf#159213 a11y: Only send child event if there's a child
        
        When reviewing all the places sending an `AccessibleEventId::CHILD`
        event as described in tdf#159213 comment 8, this here looks
        like one where the child might not be set.
        Add a corresponding check to avoid sending an invalid event.
        
        Change-Id: I6fea72e8a0619eeec7ac7c9d38dec996ab34752f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163427
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [9572354fedf3d521c8fe123c402ccab20b824815]

        a11y: Drop extra nesting level
        
        These checks can all be done in a single if condition
        rather than having two nested ones.
        
        (Use `git show -w` to ignore whitespace change.)
        
        Change-Id: Icbaaf45914f4dead9fc27d6e5e69d4cd03ee7393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163426
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [9b3b747e164c4eab056f65bb29baa04ab1770bb2]

        a11y: Drop 'using namespace com::sun::star::accessibility::AccessibleEventId"
        
        This e.g. makes it easier to grep where a certain
        kind of event is sent.
        
        Change-Id: I50bbdf4413e720188c9e4bbce9c02187183f3858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163425
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [8d98f231fa2d3f4386a842d0f45a9ceeea4ab8e1]

        tdf#156562 qt: Don't crash on null clipboard content
        
        Since
        
            commit 1db5b87fe69c2375f1d66974dafcd563303c76db
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Feb 13 13:23:17 2024 +0100
        
                tdf#156562 qt: Sync with system clipboard content if necessary
        
        , mime data are updated from the system clipboard when there's
        a mismatch.
        
        Quoting Stephan Bergmann's [1]:
        
        > PS2, Line 174:         setMimeData(pCurrentClipboardData);
        > At least for my Qt6-based Emscripten build, `pCurrentClipboardData`
        > can be null here, so setting `QtTransferable::m_pMimeData` to null here,
        > and a later call to `QtTransferable::getTransferDataFlavors` will
        > call `m_pMimeData->formats()` and crash.
        
        Add a corresponding null check.
        
        From what I can see, other methods shouldn't need an explicit check,
        as they use the result of `QtTransferable::getTransferData`
        (e.g. `QtTransferable::getTransferData` returns early if
        `QtTransferable::isDataFlavorSupported` returns false, which in
        turn calls `QtTransferable::getTransferData` that now has this
        null check).
        
        [1] https://gerrit.libreoffice.org/c/core/+/163304/comment/8872708d_1abdef81
        
        Change-Id: Ibec756c2b073b1e19a3b4761e57c35576b44adc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163423
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [9bb7d239258133020dea5fb8cd8c3b18f706d4e2]

        Deduplicate and unify SwNodes::Go(Next|Prev)(Section)
        
        The "Next" methods are made static, just as "Prev" ones. Overloads
        taking SwNodeIndex and SwPosition are implemented using a common
        implementation function, to avoid code duplication.
        
        Change-Id: I4035188b5c29d19824cd6d031e05d668d5cf1e86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163443
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-16  Kurt Nordback  <kurt.nordback@protonmail.com>  [63562694beb42b86d0f00dd3c18ac47bb094c9fe]

        tdf#50934: Implement PieDataSrc and related structure
        
        Change-Id: I6affb326600d77ddf756d9bc223e7dcc29f87d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-16  Baole Fang  <baole.fang@gmail.com>  [694b9b6422ee27da13ad455174cde50b1a673ac7]

        tdf#159678: Fix heading dropdown list
        
        Change-Id: I65b6e6e5484f26b27e7851a6615550f527fcfb06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163416
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-16  Justin Luth  <justin.luth@collabora.com>  [0222b0a414bdbdc41af42cf033a753d82e8463c5]

        docxattributeoutput.cxx: unnecessary check for GetGraphic
        
        If GetGraphicObject is not null, then bMustWrite.
        
        const Graphic* SvxBrushItem::GetGraphic() const
            const GraphicObject* pGrafObj = GetGraphicObject();
            return( pGrafObj ? &( pGrafObj->GetGraphic() ) : nullptr );
        
        Therefore there is no need to check GetGraphic(),
        since a GraphicObject is guaranteed to have a Graphic.
        
        Change-Id: Ie4bbcdc9642afcef85934fa2d4f213099ab23bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163105
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-02-16  Patrick Luby  <guibmacdev@gmail.com>  [c2ebc77e636e9cdefad6cef446a2f8acec1580f1]

        Related: tdf#159529 fix increasing failures when setting entitlements
        
        Starting in one of the Xcode versions 15.2 or earlier, setting the
        entitlements without a certificate started failing on Mac Silicon.
        The hacky solution is to make a copy of the application's executable,
        set the entitlements on that binary only, and then move the copied
        binary back.
        
        Change-Id: I25c32cbe6f9aa87e2d6c2c554a8a9cf48d79e75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163468
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-15  Oliver Specht  <oliver.specht@cib.de>  [fb72dc2474e644b66f8de6557210a2f6dedcfcc3]

        tdf#157992: add test to make sure footnotes don't get deleted
        
        This tests calls the SpellDialog with a paragraph containing a
        footnote. Prior to the fix of tdf#157992 the footnote had been deleted
        when the spelling error has been manually fixed.
        
        Change-Id: Ib57d49d8fad153c96daa1b1f6554abebd272a7f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163351
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [63236e47b8d8b128a5696c1f667addd6584926ad]

        Fix file name to rm
        
        Change-Id: Ic700b18004e4fb84aa1153331f02cad33e01341d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163457
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-02-15  Damjan Jovanovic  <damjan@apache.org>  [6c04b8356c0764ba8ac51448eee5ff577b08d9e2]

        i#112829: offer svg as clipboard format as well
        
        When copying charts, shapes, etc. out of LibreOffice, export them to
        the clipboard in the (lossless) SVG graphics format as well.
        
        This can be pasted into GIMP, Inkscape, and other apps, unlike our
        current WMF/EMF clipboard formats which use private MIME types that
        nothing supports.
        
        (cherry picked from commit 61aee323790d0a1ed0745ee5a84b8885bcd0a559)
        
        Change-Id: Ia32be448a096154bb092d49f372148c6b2263f35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163412
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [70b287d599a2bbddd8c67f51809a0513c2bdb2e6]

        Improve wording for security warning infobar
        
        Change-Id: I385ec268f4848f02d8fe49d24e32b0b9729acded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163444
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-15  Weblate  <noreply@documentfoundation.org>  [42d147c9377705a917f69914e5fd79aa1e125762]

        android-viewer translated using Weblate
        
        Galician currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ibb3a34103ad2eee7e5f8ad4aa9f031fb28f9ca51
        Co-authored-by: Xosé <xosecalvo@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163451
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-02-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a21fb5bd8896ee8b82adf21f3e00cecaa521052f]

        update credits
        
        Change-Id: I8c189f3708898087560255fbf353ac88e1dad432

2024-02-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [91b5b7198acd0a0eac8e0634a18f102c297b31da]

        kit: cell in editing mode shown with dark view bg in light view
        
        open a calc doc in light mode (view 1) and again in another view (view
        2) and toggle the second view to dark mode.
        
        Now edit a cell in the dark mode view and in the light move view the
        edited cell background is drawn as dark.
        
        bisected this to:
        
        commit f0adebce7a64b6c7dd57e10811cbe45767c6a540
        Date:   Wed Dec 13 17:50:44 2023 +0100
        
            lok: calc: fix for rendering issues on in place editing
        
        Change-Id: I5bdd0c1afaf5fa942c1b1f8bc1009b9057656840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163401
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-15  Noel Grandin  <noelgrandin@gmail.com>  [79eb7a29ab5d37e2a96ec2b4066edb66b5d5feda]

        disable CppunitTest_test_a11y on Windows
        
        keeps crashing on the Windows jenkins boxes
        
        Change-Id: I80415432dab9a2967c9a85fcf89f3840eecc91e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163454
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Jim Raykowski  <raykowj@gmail.com>  [60e37a4b85226f7a4430cd98347724a4ef0bde66]

        tdf#128787 sd: Make StyleNewByExample and StyleUpdateByExample work
        
        when no arguments are supplied
        
        Change-Id: I245aa0f6b212e049dce6bdf9e079495119aeadbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163208
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-15  Kurt Nordback  <kurt.nordback@protonmail.com>  [8da681e5ef48606716219b2a4919ee90bf7a0d6b]

        tdf#50934: Some rejiggering of of-pie code, plus implementing subpie chart
        
        Change-Id: I91fca31db0eb0bfb673e77f1369abe110fe405b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b8d10e54946eefea769f9874470599244ed70a96]

        tdf#159709: Assign Ctrl+F to seach function in German
        
        Instead of Shift-Alt-F
        
        Since 3bd3c41bc930406ec3d995a45a7f7060d572bbd0 "German keybindings:"
        
        Change-Id: I2e163cff9fd6d69574612332b1f662e54f108fbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163441
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [78b907e70359c11f5aba5568447056a130213ebd]

        Move #include <queryiter.hxx> to where it is actually used
        
        f7039822c7ad3987326e1c20ea4a745c158f9682 "tdf#127293 Add Excel2021 function
        XLOOKUP to Calc" had moved this #include around, with no documented rationale
        and for no obvious reason.  Lets move it back.
        
        Change-Id: I87c96526a6006837c9303d6af7bcf4e79e0bd581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163442
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [33505523731b930c9a1282bab293e59c9922317f]

        Explicitly instantiate templates
        
        ...that are used in inline functions in sc/inc/queryiter.hxx, but where the
        template definition is only available in sc/source/core/data/queryiter.cxx, and
        which had caused at least Clang PCH builds to now fail with
        
        > ld.lld: error: undefined symbol: bool ScQueryCellIteratorAccessSpecific<(ScQueryCellIteratorAccess)1>::IncPosImpl<false>()
        > >>> referenced by queryiter.hxx:111 (sc/inc/queryiter.hxx:111)
        > >>>               workdir/CxxObject/sc/inc/pch/precompiled_sc.o:(ScQueryCellIteratorAccessSpecific<(ScQueryCellIteratorAccess)1>::IncPos())
        >
        > ld.lld: error: undefined symbol: bool ScQueryCellIteratorAccessSpecific<(ScQueryCellIteratorAccess)1>::IncPosImpl<true>()
        > >>> referenced by queryiter.hxx:112 (sc/inc/queryiter.hxx:112)
        > >>>               workdir/CxxObject/sc/inc/pch/precompiled_sc.o:(ScQueryCellIteratorAccessSpecific<(ScQueryCellIteratorAccess)1>::IncPosFast())
        > clang++: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[1]: *** [sc/Library_sc.mk:10: instdir/program/libsclo.so] Error 1
        
        Change-Id: If87b268a69e7acd411164ce53c549be32ded41cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163434
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [be52d92c2cdb40d2e89f1546a79269c7e373736b]

        workaround for OpenDyslexic font disrupting glyph fallback during tests
        
        Change-Id: Iee6bc4e9dc5ed39d8e9b2897e3c31ef4cb62f550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [546a8d72cf64d6eb8a2bfe5adb3c31ea07afad8f]

        GetExtendedTextEncoding for RTL_TEXTENCODING_MS_1252 just returns same
        
        i.e. GetExtendedTextEncoding calls GetExtendedCompatibilityTextEncoding
        if the arg is RTL_TEXTENCODING_MS_1252 and that just return its input
        for this case.
        
        Change-Id: If60a8c73a38c060bbc8d11b1ebeaf41bed89a13c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163414
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7dfac691e4575851b73c226a8b7ce74eb024195]

        regenerate boost headers
        
        to reduce noise when building in debug mode with
        
           gcc (Ubuntu 13.2.0-4ubuntu3) 13.2.0
        
        e.g.
        In file included from
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/property_tree/json_parser.hpp:15,
        from
        /home/noel/libo2/external/boost/include/boost/property_tree/json_parser.hpp:30,
                         from /home/noel/libo2/sw/inc/pch/precompiled_sw.hxx:61:
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/property_tree/json_parser/error.hpp:
        In instantiation of ‘boost::wrapexcept<E>::wrapexcept(const E&, const
        boost::source_location&) [with E =
        boost::property_tree::json_parser::json_parser_error]’:
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/throw_exception.hpp:171:11:
        required from ‘void boost::throw_exception(const E&, const
        source_location&) [with E =
        property_tree::json_parser::json_parser_error]’
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/property_tree/json_parser/detail/write.hpp:159:13:
        required from ‘void
        boost::property_tree::json_parser::write_json_internal(std::basic_ostream<typename
        Ptree::key_type::value_type>&, const Ptree&, const std::string&, bool)
        [with Ptree =
        boost::property_tree::basic_ptree<std::__cxx11::basic_string<char>,
        std::__cxx11::basic_string<char> >; typename Ptree::key_type::value_type
        = char; typename Ptree::key_type = std::__cxx11::basic_string<char>;
        typename Ptree::key_type::value_type = char; typename Ptree::key_type =
        std::__cxx11::basic_string<char>; std::string =
        std::__cxx11::basic_string<char>]’
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/property_tree/json_parser.hpp:99:28:
        required from ‘void
        boost::property_tree::json_parser::write_json(std::basic_ostream<typename
        Ptree::key_type::value_type>&, const Ptree&, bool) [with Ptree =
        boost::property_tree::basic_ptree<std::__cxx11::basic_string<char>,
        std::__cxx11::basic_string<char> >; typename Ptree::key_type::value_type
        = char; typename Ptree::key_type = std::__cxx11::basic_string<char>;
        typename Ptree::key_type::value_type = char; typename Ptree::key_type =
        std::__cxx11::basic_string<char>]’
        /home/noel/libo2/sw/source/core/crsr/viscrs.cxx:129:37:   required from
        here
        /home/noel/libo2/workdir/UnpackedTarball/boost/boost/property_tree/json_parser/error.hpp:20:11:
        warning: implicitly-declared
        ‘boost::property_tree::file_parser_error::file_parser_error(const
        boost::property_tree::file_parser_error&)’ is deprecated
        [-Wdeprecated-copy-dtor]
           20 |     class json_parser_error: public file_parser_error
        
        Change-Id: I1dd49af4d8c573a07b34d3216a36f283aaafa106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163372
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Miklos Vajna  <vmiklos@collabora.com>  [f9193529556f8db8dcb4095f685ac32cbff13fd0]

        CppunitTest_sw_ww8export4: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23).
        
        - sw/qa/extras/ww8export/data/tdf77964.doc:
          微软雅黑 -> Liberation Sans
        
        - sw/qa/extras/ww8export/data/tdf90408B.doc:
          Times New Roman -> Liberation Serif
        
        Change-Id: I08ebe00c4cedf4e755f8d634ce089ac3b9bb5f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163420
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-15  Michael Stahl  <michael.stahl@allotropia.de>  [ff9be3fd30ead41359734f9281b034a988d71196]

        tdf#158597 writerfilter,sw: fix toggle properties in ListAutoFormat
        
        ... for DOCX import.
        
        These can be set both via paragraph style and via character style in the
        w:pPr/w:rPr, so use the applyToggleAttributes().
        
        Adding a test for this requires adding the "CharStyleName" property to
        GetAutoCharStylePropertyMap().
        
        Change-Id: I9701d5ac82ec3e7757650c08861791dc398a1a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163386
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-15  Michael Stahl  <michael.stahl@allotropia.de>  [179991383e26e093b307deb9983c67e8e0833d72]

        offapi: fix misleading comment
        
        Change-Id: Ibc585600c0aa21f18911972f4604be65d16d713c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163437
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-15  Miklos Vajna  <vmiklos@collabora.com>  [ce8e14ce2222b1aa2cbbb2465adc003fce2cf269]

        uui: show what is the unhandled result before asserting
        
        online.git unit-bad-doc-load fails here, at least show what is the
        unhandled return code (-1) before failing.
        
        The actual problem is not yet solved.
        
        Change-Id: I530058590f176f5c7eee3b6cd9d9a270110613ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163436
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [59479de20242c7acf0e162e7c954899cb55419f3]

        zlib: upgrade to 1.3.1
        
        Change-Id: I339b4e9c94ea50b3ddb41dfdac0e48d27939bc74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163432
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [691cfd22c6351416d8c758e040c7534383494f90]

        tdf#159565: make sure to handle leading hidden section correctly
        
        Change-Id: I41c7d2b6e765f03c72a968fd05e8de7047f1ce41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163371
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ffc1ab15ae358315516aab319778a254688afbd3]

        Work around some Clang PCH consteval issue by disabling HAVE_CPP_CONSTEVAL
        
        (see the links in the configure.ac check for details)
        
        Change-Id: I9a98f784f68931cb4482bc02be313d18c5464105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163422
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3f3bdf708e5867369ae0a5b7362a429ba70e8ba]

        ofz: don't need "cui" for fuzzing
        
        Change-Id: I3d8778d23a21bdd4a6babf495552112c67938111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163413
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [dcc9626eac53fef42b1a85c3235d1e4e48331bee]

        SAL_WARN->SAL_INFO
        
        reduce log noise
        
        Change-Id: I16a45c8c41292b245a507ee51924b2f465719c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Dione Maddern  <dionemaddern@gmail.com>  [ad152fe7296359841f75f0e13fe7a47e03b71073]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e658568356d855b70e021116dac60fb26f7d06f
          - Make "Related Topics" links live for Basic help pages
            
            Remove comment tags and self-referential link from the "Related Topics" section in text/sbasic/shared/03100050.xhp so that the additional links will display. Now that the correct tags have been added to other pages, they will display correctly.
            
            Add a variable tag "CDec_h1" to text/sbasic/shared/03100060.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Remove comment tags from the "Related Topics" section in text/sbasic/shared/03100100.xhp so that additional links are visible.
            
            Add a variable tag "CDate_h1" to text/sbasic/shared/03100300.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Add a variable tag "CDbl_h1" to text/sbasic/shared/03100400.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Add a variable tag "CInt_h1" to text/sbasic/shared/03100500.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Add a variable tag "CLng_h1" to text/sbasic/shared/03100600.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Add a variable tag "CSng_h1" to text/sbasic/shared/03100900.xhp so that links from other help pages will work. Add a "Related Topics" section.
            
            Add a variable tag "CByte_h1" to text/sbasic/shared/03120105.xhp so that links from other help pages will work. Remove comment tags from the "Related Topics" section so that the additional links are visible.
            
            
            
            Change-Id: I463c4100368b8ed7f033bf11d68695eac1ce8e33
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163390
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e5d06a8032b1eec029f408411f432d76addbdf76]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c1725e2c3209e09c04c22bdfbe4e933d6aec67dc
          - Adapt help to recent changes
            
            This option is not the equivalent of resetting the user properties in File->Properties,
            so remove that information from the tooltip.
            
            Change-Id: I1f02667cc8aff9f74b84a0ee2f4e06ba8ded4be2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163435
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-02-15  Aron Budea  <aron.budea@collabora.com>  [6efe49e729ff6b1f427283e24300e4d6bd2395af]

        pyuno: Use expected return value (-1) on failure
        
        Both PyObject_SetAttr and PyObject_SetItem are expected to:
        
        Raise an exception and return -1 on failure; return 0 on success.
        https://docs.python.org/3/c-api/object.html
        
        Change-Id: Id1f6129e91e9da2f5d3bc1858422eeee4c3393d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163418
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-02-15  Miklos Vajna  <vmiklos@collabora.com>  [411158832462b1077a8f5dc6379f2056f2338249]

        tdf#159483 sc HTML copy: handle data-sheets-value attribute for the bool case
        
        Similar to commit f8c95cf93ce9ab8b9b78f3af03411d0cc2e195ba (tdf#159483
        sc HTML import: handle data-sheets-value attribute for the bool case,
        2024-02-08).
        
        Change-Id: I25ce8c81bd906ac0fb912e125e061516a604e786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163419
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [52a22b6863c08b071361fa9c212b886e1e48500b]

        Fold registeroustring.js into PrimaryBindings.cxx
        
        Change-Id: I2e1aa828f194a104d354741518e8cb20015ac276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163385
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-15  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [b7e4078033b064bfc3847db0916a4df389117817]

        Expat: upgrade to release 2.6.0
        
        Fixes CVE-2023-52425 and CVE-2023-52426.
        
        Change-Id: Id135bbaea893a83129bdbee44948c09322a64c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163146
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [21fd278a455555b190cc35deb55a2913cbae8b70]

        Fix typo
        
        Change-Id: I0e9dd35f8dd03e9bfd71b1ae84a2715dff948a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163415
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [de43ed10886ae041b3814f80ef0510f6ac18d515]

        merge index_data into i18npool
        
        (*) it is a small library
        (*) this avoids another dynamic symbol lookup
        (*) this unblocks more --enable-mergedlibs optimisation
        
        Change-Id: I9230230c3d72f4e9ce19408f4b5716452ccd4fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [028affcf44b2e465a0a178e8ebe5682edfa68531]

        Revert "merge sdui library into sd"
        
        This reverts commit 2cf7c26293462406d91ee050c6677930065e660b.
        
        Reason for revert: 
        
        <_rene_> noelgrandin: sdui->sd... and what about people not needing that ui?
        <_rene_> (e.g. --disable-gui and libreoffice-draw-nogui and impress-nogui)
        <_rene_> i.e. the use case of --convert-to for ppt(x) etc
        
        Change-Id: I6755c209e63f34b3fc9f9fdc4af7001b18579e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163348
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b658083c1935e1d74306e361c3d69f53eff4fef]

        sw: move some UItests from writer_tests7 to writer_tests8
        
        writer_tests7 had 47 tests while writer_tests8 6
        Now they have 31 and 22 respectively
        
        Change-Id: Iac839c7328d346bc8342ce2f8a20359aeca1206a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163384
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [582dbb28efb39d93b6f9197590a5c64b69dec393]

        tdf#1575639: sw: Add UItest
        
        I tried to implement this test as a CppUnittest but it fails with
        
        - Expression: false
        - Unexpected dialog: Error activating object Error: General OLE error.
        
        See https://gerrit.libreoffice.org/c/core/+/160917
        
        Change-Id: I36714146cc67119070b9799c4eb251a69f80b0cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163381
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc1e5bf5c1c75acd6bb8f62b9363aa1a30b9acd6]

        tdf#159707: sc: Add UItest
        
        I tried to create this test as a Cppunittest but it fails with
        
        Run: 1   Failure total: 2   Failures: 1   Errors: 1
        warn:vcl:428912:428912:vcl/source/app/svmain.cxx:494: DeInitVCL: some top Windows are still alive
        text = "" type = "14FloatingWindow", ptr = 0x5608715e49e0
        text = "tdf159707.xls (read-only) — LibreOfficeDev Calc" type = "10WorkWindow", ptr = 0x5608709ab420
        
        Change-Id: I1b9e16d57050fe07f74c632d441e3a06f49e9438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163363
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-15  Michael Weghorn  <m.weghorn@posteo.de>  [9e40fc8c9458b937200ea56c96b89113c74b67f5]

        tdf#130857 qt weld: Set msg dialog parent
        
        If a parent is passed to `QtInstance::CreateMessageDialog`,
        also set a parent for the `QMessageBox` that gets created
        there:
        
        If the passed parent is a native Qt one, use that one.
        Otherwise, fall back to using the current active top-level
        window, which is what usually makes most sense and is better
        than having no parent at all.
        
        With this change in place, the message dialog shown
        when doing
        
        1) start Writer
        2) "File" -> "Properties" -> "Security" -> "Protect"
        3) type 2 different passwords and confirm
        
        is now modal and centered on top of the "Enter Password"
        dialog on KDE Plasma Wayland when using the qt6 VCL plugin,
        while it used to open at the top left of the screen and was
        non-modal before.
        
        The new behavior is in line with how it behaves for the
        SAL_VCL_QT_NO_WELDED_WIDGETS=1 case.
        
        Change-Id: Ibe95c2f0407edeba0fd9f76744bc087be7df6437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163362
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-15  Michael Weghorn  <m.weghorn@posteo.de>  [6712963e231e7ab50a3d11b8a8c75e54e0c79b32]

        tdf#130857 qt weld: Implement QtInstanceDialog::{g,s}et_modal
        
        Change-Id: I975d10ccc73c79b34da733411097a7970c8bf916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163361
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-15  Michael Weghorn  <m.weghorn@posteo.de>  [092bcd7133c30c0614056928a16baea44704735e]

        tdf#130857 qt weld: Move QWidget* member to QtInstanceWidget
        
        Move the `m_pWidget` member from `QtInstanceWindow`
        to the base class `QtInstanceWidget` and add a getter
        for it.
        
        This allows to get the `QWidget` directly from the
        base class, which will be used in an upcoming commit.
        
        Change-Id: I9c41b48936e5a6051afb9721dae2fac5add22e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163360
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [43d962c27b6efb04d22b05ad8dec08f6056078a0]

        ofz: don't need "bib" for fuzzing
        
        Change-Id: Ie471593779bd44382ebc83355aef0c1fae87ae92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163380
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-14  Mike Kaganski  <mike.kaganski@collabora.com>  [0c96119895b347f8eb5bb89f393351bd3c02b9f1]

        tdf#159565 prerequisite: make hidden sections have zero-height frames
        
        As mentioned in commit bb733957dd39e6f0b9d80bb59eb0177188794797 (tdf#114973
        sw: enable SelectAll with hidden para at start/end, 2023-01-27), the hidden
        sections didn't have frames. That prevented correct handling of the case
        when such a frame was in the beginning of the document.
        
        This change re-implements the hidden section to use 0-height frames, like
        hidden paragraphs, as a pre-requisite for a follow-up change.
        
        Some layout breakages noticed while working on this are unit-tested now.
        
        This change needed to handle the case when the first section is hidden, and
        then goes a page break with page style. In this case, the page style must
        apply to the very first page of the document. Implementing this now, when
        the frame that defines the page style is not the first in the document, I
        accidentally fixed also the previously broken case when the first paragraph
        was hidden. Now the page style defined in the second paragraph's page break
        will apply correctly.
        
        This change makes hidden sections break outer section's frames. This means
        that when text borders are shown, there will be an artifact in the place of
        the hidden sections (a horizontal line breaking outer frame). I suppose
        it's not a problem, actually helping to see the layout better, so in line
        with the "show text borders" helper functionality. If this proves to be
        problematic, this can be handled specially in a follow-up.
        
        Change-Id: I14ebf0559b463186aba28902cd10c5cc978ba456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163151
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a0807b08f0254e89d361322bce1ef13df3427f2]

        update find-mergedlib-can-be-private results file
        
        so that in future I know that these are false positives
        
        Change-Id: Ic52b591f51f28e8f656465417da1d0714450094c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163367
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  René Engelhard  <rene@debian.org>  [5111a0b9bf3c36cd01beefbc6e47fd45836877d3]

        Revert "configure: clean up not needed abseil libs for the system-abseil case"
        
        This reverts commit 89a0933968e4b9160613707301d1f5dd36d97282.
        
        Reason for revert: we still need absl_inlined_vector, Linking test doesn't work, this is header-only but we should check for it being there to be sure
        
        Change-Id: I55b4d645876d7080ee41917413e02cba930c9060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163349
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2024-02-14  Miklos Vajna  <vmiklos@collabora.com>  [89a0933968e4b9160613707301d1f5dd36d97282]

        configure: clean up not needed abseil libs for the system-abseil case
        
        Noticed by Rene, found by emptying the list and then adding items back
        till the linker succeeded again.
        
        Change-Id: I0b68ad8c50659af2d3a9ff3abfad60990f25bd79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163378
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2024-02-14  Michael Meeks  <michael.meeks@collabora.com>  [52f2720af102c9a4800db085bbe09e60e5d6a3c7]

        lok: implement a joinThreads function - to wind down thread pools.
        
        Necessary to do this before forking on Unix systems; use a
        dynamic_cast interface since this is all for internal use.
        
        Change-Id: I8a911322acd4ec5654eb0d14804c09d513a0bd4b
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163335
        Tested-by: Jenkins

2024-02-14  Dione Maddern  <dionemaddern@gmail.com>  [d87206370b840adef6dfd03ed280a1de5635fac6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac406bcc94724248ab5d2327a65dd0bf821e18c3
          - Remove text/scalc/01/02120000.xhp because it has been superseded by text/shared/01/05040300.xhp.
            
            Change-Id: I1e38debd8a4a3148bf2f7184544d6208e8eb189b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163346
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [ede1d73364adbadc7c630c53bd77ec376b239b66]

        CppunitTest_sw_uiwriter3: replace 'AdvPS88D1' with 'Noto Sans' in file
        
        Executing the test with gb_CppunitTest_set_non_application_font_use
        passes now
        See https://gerrit.libreoffice.org/c/core/+/95901/comment/48f05796_186dd858
        
        Change-Id: I3e13ae06f4361ef9731e3a64c790283c99201526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163366
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2981648653d1cb67f9986b44a93a8cce245ac216]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c2af651f93318a13bb9246c3f8c7480f58a67a9
          - Fix typo
            
            Change-Id: I7b035d45b111a01602aa5849d966800b2da1236f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163375
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-02-14  Miklos Vajna  <vmiklos@collabora.com>  [192db287045bf9c6de4272845b36b0cda625a316]

        Update pdfium to 6296
        
        - external/pdfium/build.patch.1: drop most hunks which no longer apply,
          assuming they were only relevant for the RHEL 7 / C++17 baseline.
        
        Change-Id: Ida533485d81845a82d890f8c0b70fa61e201f880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163329
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-14  Jaume Pujantell  <jaume.pujantell@collabora.com>  [6565e46f3e49173c4c37f8b51450f5352ac08341]

        tdf#159704 svx: preserve text when getting grpahic from sdrobject
        
        When getting a Graphic object from an SdrGrafObj with text the text was lost.
        
        Change-Id: I3a8316511e502b832b65dc72faebaf8c00923c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163293
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit d0241915eba35c9dc0cc42f322df798a270db00f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163342
        Tested-by: Jenkins

2024-02-14  Julien Nabet  <serval2412@yahoo.fr>  [7c0c8a3ae258808012c3514dadeb02fc0c6fc43b]

        tdf#159707: fix crash when changing to edit mode (calc)
        
        bt:
        0x00007f9eb4b902f2 in com::sun::star::uno::Reference<com::sun::star::frame::XModel>::operator->() const (this=0x55b8c2b54888) at include/com/sun/star/uno/Reference.h:387
        0x00007f9eb4c03584 in ScVbaEventsHelper::notifyEvent(com::sun::star::document::EventObject const&) (this=0x55b8c2b54840, rEvent=...) at /home/julien/lo/libreoffice/sc/source/ui/vba/vbaeventshelper.cxx:605
        0x00007f9ef464bd3c in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XEventListener> const&) const (this=0x7ffc5044dfc0, listener=uno::Reference to (ScVbaEventsHelper *) 0x55b8c2b54870) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3293
        0x00007f9ef463b8aa in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XEventListener>::forEach<(anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> >((anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XEventListener, com::sun::star::document::EventObject> const&)
        (this=0x55b8c2735c18, func=...) at include/comphelper/interfacecontainer3.hxx:279
        0x00007f9ef463b010 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Any const&)
        (this=0x55b8c2308ae0, aName="OnUnload", xController=empty uno::Reference, supplement=uno::Any(void)) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3338
        0x00007f9ef463a089 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55b8c2308ae0, rBC=..., rHint=...) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2960
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=192546
        
        Regression from:
        https://git.libreoffice.org/core/+/d2fccf0117a37f8aab8bb50ece419987f06af6b9%5E%21
        "cool#6893 improve listeners in SfxBaseModel"
        
        Change-Id: I372808dade20c47275ab599054d8e9572dc3da4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163356
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2024-02-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0f3e2dc248f46619a7d2c082da381dd9534bf2ee]

        Update git submodules
        
        * Update translations from branch 'master'
          to 55632263e22f8b68db3e9b2cfdf4e9f2a8aaa6af
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I1e042648f81e0c59b842f5e6a26cdb981db525fc
            
2024-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [164cab17d4125d2a4b6b5cc607c9b316ef46c115]

        rename some of the collator function symbols
        
        to prevent conflicts when I merge some of these libraries
        
        Change-Id: Iaa09924dc5b88ecd6d381e9529a8862a5b539a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163359
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cf7c26293462406d91ee050c6677930065e660b]

        merge sdui library into sd
        
        which eliminates another dynamic-symbol lookup and another complication
        which was making it harder to do better with --enable-mergedlibs
        
        sd is relatively small, so even the combined library is not as big as
        one of the sw and sc libraries
        
        Change-Id: Ibef8077d70a5abc7361c95f5dbb8c43447610188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Miklos Vajna  <vmiklos@collabora.com>  [4e2a4fbeb7c44cc47b3cf803cbcc6cba63b3d481]

        tdf#159483 sc HTML export: handle data-sheets-value attribute for the text case
        
        HTML pasting "'01" from google sheets to Calc worked already, but
        HTML copying from Calc still converted 01 to 1.
        
        What's required is to emit a general marker in the HTML output and then
        the correct data-sheets-value attribute on the relevant <td> element.
        
        Add a way to inject a marker in ScHTMLExport::WriteBody() (so
        data-sheets-* is considered at all) and extend
        ScHTMLExport::WriteCell() to write the data-sheets-value attribute for
        the text case as a start.
        
        Other types like booleans are not yet handled at export time.
        
        Change-Id: Ib66e92c84235797cb4731e73d0a5b6286b6f3ab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163328
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae17922b7d0f797129dd5fbd5514d691ac9ebeaa]

        add more libs into --enable-mergelibs=more build
        
        Change-Id: Idec36cb54e998c9e4830d5e51a6d2df7d94170fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163350
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Hubert Figuière  <hub@collabora.com>  [f34025d36dda12ca99bb82f80e711fbd93fe4967]

        calc: getPartInfo() returns the sheet protected state
        
        Change-Id: I67e2a26680895b5c76977109f4c3f9e1638a9f9e
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163337
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2024-02-14  varshneydevansh  <varshney.devansh614@gmail.com>  [0859e497be07acceb0a950183d5997374783266f]

        tdf#145539 convert const char[] in files to constexpr OUStringLiteral
        
        OStringLiteral represent read-only memory for string literal while
        OUString is a dynamic string class with reference counting
        hence use OUString when you need reference counting, string
        manipulation along with _ustr suffix.
        
        Change-Id: Ib566df156d81c7527f5650bcc6bd5db6509128cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162911
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-14  Michael Weghorn  <m.weghorn@posteo.de>  [ec69b448f4b6296edb6b28ced5ecb710be82438b]

        scp2: Take ENABLE_{KF,QT}6 into account
        
        The qt6 and kf6 VCL plugins are also part
        of the kde install set, so take
        `ENABLE_QT6` and `ENABLE_KF6` into
        account when deciding whether to install
        it.
        
        This makes packaging these VCL plugins work
        when building with `--enable-qt6` and/or
        `--enable-kf6`, but without `--enable-qt5`
        and `--enable-kf5`.
        
        Command that can be used for testing:
        
            make DESTDIR=/tmp/dummy distro-pack-install -o build -o check
        
        (Then, check whether the "installation" in /tmp/dummy
        contains the VCL plugins as expected.)
        
        Thanks to Andreas Sturmlechner for reporting
        the issue on IRC #libreoffice-dev on 2024-02-12.
        
        Change-Id: Ieea67468e3388f8b7b66f53221574c6225516b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163313
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-14  Patrick Luby  <guibmacdev@gmail.com>  [6525b488c5eb85a790265b3b394323491ecd70a7]

        Fix build breakage with --enable-mergelibs on macOS
        
        With Xcode 15.2, --enable-mergelibs started failing so export a couple
        constructors.
        
        Change-Id: If41b167bb349976f38c5da9385824d5f51dc5398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163326
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fb35c64d5b7bb3c6763d09af613d9c79c657f7a9]

        Fix typo
        
        Change-Id: I95fb4b60d5afa9b309c477896a6234c12d20ba92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163318
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12d91b562d3932c3b13a2954f63acab655dc02aa]

        Fix typo
        
        Change-Id: I67e2769f3b60ef48a785d5eefc3dbad64b04b2eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163322
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da3a624cfa19d0beaf83c64ddf16ef23f15808d9]

        Fix typo
        
        Change-Id: Id0763e1bef326155afca27cea62258120323a44e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163323
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [37559bb3a19a3dd55eab6b7d5cbf346f4e683932]

        Fix typo
        
        Change-Id: I8e02264f0edb300b7dec6db4b772fba13ae71c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163321
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd294936fd50abea99540e69091c120ba0e2ef64]

        Fix typo
        
        Change-Id: Iacd32b9b7556e706b8bfdcce1738ec3925366020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163319
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [9798f383f82897b0021665f50f3a9f8153febbe8]

        tdf#141908 replace usage of sal_Int32 with colors in xmloff
        
        Change-Id: Ia2661fa0f6864d6553e5cca7469e1d351bb06d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163305
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-14  Kurt Nordback  <kurt.nordback@protonmail.com>  [d81c98623b2abb991ca696b3b09011f6bb3de673]

        tdf#50934: Restructuring for of-pie charts
        
        Change-Id: I9682c314efb888d57e94f82f084cc6d0825a4408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Attila Szűcs  <attila.szucs@collabora.com>  [0f4002378d7cbf20ed5f33cbdc4e3c8e01e0338d]

        fix windows UNLESS_MERGELIBS
        
        it was needed to fix a linker error in my system
        
        Change-Id: I5eeebf0db569289aace32f61535ae2ba7148de48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163327
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Noel Grandin  <noelgrandin@gmail.com>  [5e70dd023525e69e49851ff8d44287ccf5e56f95]

        fix --enable-mergelibs=more on macos
        
        fix duplicate symbols
        
        Change-Id: I6ec0b07026db6df6b76228a6bedb95c610e7ea07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-14  Mike Kaganski  <mike.kaganski@collabora.com>  [b6ef30d1b049977beb23d28a07d77012fa1daf47]

        tdf#159302: Another UNO property "BaseLine" needs to use mm/100s
        
        Change-Id: I6688577a41590624f1e1f08112f1308e810a7e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163333
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-14  Oliver Specht  <oliver.specht@cib.de>  [125fc2ce861c82592b261f2992c893b414396e56]

        tdf#63259 rotate case also at start/end of a word
        
        Rotate either rotates the selection or the word the cursor is directly before,
        inside or directly after
        
        Change-Id: Ia21e3120d2b00978b9f4ce06738b42e90d2ada62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162256
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ae5728350e7b7b0392df2b3e27f55c6611f842e]

        Fix typo
        
        Change-Id: I4d968280a5231bbd90496acc3ceabd065fc22fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163320
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-13  Luv Sharma  <luvsharma.del@gmail.com>  [9241b739c78c5becad434ac8d381104d8dc243aa]

        tdf#45904 Remove old SwXTextTable Java test
        
        Change-Id: I3670d01229a8f44691ac971196a6b0b929649896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163248
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [947e472a41f5ff43f16288b3881a29119b0f269c]

        Remove duplicated include
        
        Change-Id: If2b13ef3100203d461b96b3bae7541d4593ace09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163317
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-13  Hubert Figuière  <hub@collabora.com>  [eeadb4d703659987c7f54ca296755f6e7e5ffd1e]

        sc: add back protect cell tab from cell format dialog
        
        Also enable the tab in jsdialogs
        
        Signed-off-by: Hubert Figuière <hub@collabora.com>
        Change-Id: I2c4eac029568cc0de4be5ebb6b0f4ae47f2da1a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163263
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit eb6674aa7899e7b9542bcc9e1ca5cb5c4dfee843)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163332
        Tested-by: Jenkins

2024-02-13  AkshayWarrier  <aksmen121@gmail.com>  [488cd78f3b30f8b43007a3250d0c11fd0416dde9]

        tdf#158237 comphelper: Use C++20 contains() instead of find() and end()
        
        Change-Id: I99c27c2269051c6c145dbfd2ec12790d4bb1d5e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162338
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [34a09df2d112a9d6828a9a65d9965aacae6c7c41]

        fix windows --enable-mergelibs build
        
        after
            commit b663d94cf67a5af4fd89c1ac8bdffd6059f6bf85
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 5 08:50:24 2024 +0200
            create --enable-mergelibs=more
        
        Change-Id: Ib9f0b3b28df70a9bab10d9bb0aa77a2b2decc616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [29c9587df7f0e7ce27e616c6fc9640a1df0d20a7]

        fix --enable-mergelibs=more build on Windows
        
        I was over-enthusiastic adding these to the merged list, they
        are DLLs with their own DllMain functions
        
        Change-Id: I78a4e026e746f9688bc982ea7c899b05cf8f441d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca1c8b447110321664a7a385dda5af6e303a91c8]

        we don't need the reg or store libraries for fuzzing
        
        possibly other configations too, but just for fuzzing for the moment
        
        from looking at:
        https://oss-fuzz.com/coverage-report/job/libfuzzer_asan_libreoffice/latest
        and see what is built but is 0% coverage and uninteresting to be non-0
        
        Change-Id: Ia7afdfc033dd8a705d85c76b246dc5dfb259b063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [1db5b87fe69c2375f1d66974dafcd563303c76db]

        tdf#156562 qt: Sync with system clipboard content if necessary
        
        If the `QtClipboardTransferable`'s mime data gets out of sync
        with the system clipboard's one, no longer cease operation
        and stop reporting any transfer data, but sync with  the
        clipboard data, i.e. update the mime data with those
        currently in the system clipboard.
        
        For the "Paste Special" dialog with qt6 on Wayland
        (see tdf#156562), an external clipboard update gets
        triggered between the point in time when the
        
            std::shared_ptr<const TransferableDataHelper> aDataHelper
        
        in the `SID_PASTE_SPECIAL` case in `SwBaseShell::ExecClpbrd`
        gets assigned and when the callback set via
        `pDlg->StartExecuteAsync` gets called, even if there
        was no user interaction with the system clipboard at all.
        
        This however meant that the `aDataHelper` used in the
        callback would no longer return any transfer/mime data,
        so pasting wouldn't work.
        
        Handle that case by updating the `QtClipboardTransferable`
        mime data with the current system clipboard's data, but
        keep emitting a warning at least.
        
        As a consequence, opening the "Paste Special" dialog, then
        copying something else to the clipboard, then confirming
        the dialog will copy the newly copied data rather than
        what was in the clipboard when the dialog was initially
        started. That's the same for gtk3 already, but on Windows,
        the original clipboard content would still be pasted.
        
        (Retrieving the clipboard content anew in the callback using
        `TransferableDataHelper::CreateFromSystemClipboard` instead
        of passing the original `aDataHelper` into the callback
        would have a similar effect. However, on other platforms,
        reusing the previously copied data from the clipboard when
        the actual system clipboard was changed in between may
        be what's desired.)
        
        The observed extra/unexpected clipboard change event may be
        related/similar to what the following commit was addressing for
        the case of LO itself being the clipboard owner:
        
            commit 71471a36b125f6bdc915d5dbcae92ebcaa7ff5a4
            Date:   Tue Apr 6 01:41:08 2021 +0200
        
                tdf#140404 Qt ignore "unchanged" clipboard events
        
                LO gets a Qt signal on all clipboard changes. For X11 you get one
                signal when you set the clipboard. Anything else normally signals
                lost of clipboard ownership.
        
                But on Wayland LO somehow gets a second notification without any
                actual change. AFAIK it's not triggered by any LO actions and
                isOwner still indicates, that LO has the ownership. This breaks
                the single notification assumption, the code was relying on.
        
                (...)
        
        Backtrace showing how the clipboard update gets triggered
        (with mode `QClipboardMode::Clipboard`, not just
        `QClipboardMode::Selection`; qtbase dev as of
        0d0810e2dcc8a9ee28935af5daadc2ef36ed25a2):
        
            1 QtClipboard::handleChanged QtClipboard.cxx 156 0x7f6284c7a7a8
            2 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 153 0x7f6284c8450f
            3 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call(void (QtClipboard:: *)(QClipboard::Mode), QtClipboard *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 72 0x7f6284c8500b
            4 QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard:: *)(QClipboard::Mode)>::call qobjectdefs_impl.h 152 0x7f6284c8457f
            5 QtPrivate::FunctionPointer<void (QtClipboard:: *)(QClipboard::Mode)>::call<QtPrivate::List<QClipboard::Mode>, void> qobjectdefs_impl.h 200 0x7f6284c833ee
            6 QtPrivate::QCallableObject<void (QtClipboard:: *)(QClipboard::Mode), QtPrivate::List<QClipboard::Mode>, void>::impl qobjectdefs_impl.h 571 0x7f6284c81f81
            7 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 487 0x7f62841b863f
            8 doActivate<false> qobject.cpp 4116 0x7f628425772e
            9 QMetaObject::activate qobject.cpp 4176 0x7f628424cdef
            10 QClipboard::changed moc_qclipboard.cpp 182 0x7f62831e9fcc
            11 QClipboard::emitChanged qclipboard.cpp 558 0x7f62831e9bc1
            12 QPlatformClipboard::emitChanged qplatformclipboard.cpp 89 0x7f628324ed69
            13 QtWaylandClient::QWaylandDataDevice::data_device_selection qwaylanddatadevice.cpp 295 0x7f6281b8eaf1
            14 QtWayland::wl_data_device::handle_selection qwayland-wayland.cpp 985 0x7f6281b7389a
            15 ?? 0x7f629681a40e
            16 ?? 0x7f629681971d
            17 ffi_call 0x7f6296819ef3
            18 ?? 0x7f629955c921
            19 ?? 0x7f6299558c09
            20 wl_display_dispatch_queue_pending 0x7f629955a5ac
            21 QtWaylandClient::EventThread::dispatchQueuePending qwaylanddisplay.cpp 227 0x7f6281afd5f4
            22 QtWaylandClient::EventThread::readAndDispatchEvents qwaylanddisplay.cpp 109 0x7f6281afd124
            23 QtWaylandClient::QWaylandDisplay::flushRequests qwaylanddisplay.cpp 508 0x7f6281af5b98
            24 QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 153 0x7f6281b13ebb
            25 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 72 0x7f6281b151f0
            26 QtPrivate::FunctorCall<QtPrivate::IndexesList<>, QtPrivate::List<>, void, void (QtWaylandClient::QWaylandDisplay:: *)()>::call(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 152 0x7f6281b13f1c
            27 QtPrivate::FunctionPointer<void (QtWaylandClient::QWaylandDisplay:: *)()>::call<QtPrivate::List<>, void>(void (QtWaylandClient::QWaylandDisplay:: *)(), QtWaylandClient::QWaylandDisplay *, void * *) qobjectdefs_impl.h 200 0x7f6281b11250
            28 QtPrivate::QCallableObject<void (QtWaylandClient::QWaylandDisplay:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 571 0x7f6281b0d5e3
            29 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 487 0x7f62841b863f
            30 QMetaCallEvent::placeMetaCall qobject.cpp 650 0x7f6284243bf9
            31 QObject::event qobject.cpp 1447 0x7f6284245095
            32 QApplicationPrivate::notify_helper qapplication.cpp 3298 0x7f62823a696c
            33 QApplication::notify qapplication.cpp 3249 0x7f62823a677d
            34 QCoreApplication::notifyInternal2 qcoreapplication.cpp 1138 0x7f62841b1162
            35 QCoreApplication::sendEvent qcoreapplication.cpp 1581 0x7f62841b1d0b
            36 QCoreApplicationPrivate::sendPostedEvents qcoreapplication.cpp 1936 0x7f62841b33c4
            37 QCoreApplication::sendPostedEvents qcoreapplication.cpp 1770 0x7f62841b255e
            38 postEventSourceDispatch qeventdispatcher_glib.cpp 244 0x7f62846384ac
            39 ?? 0x7f628b9111f4
            40 ?? 0x7f628b914317
            41 g_main_context_iteration 0x7f628b914930
            42 QEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 394 0x7f6284638d41
            43 QPAEventDispatcherGlib::processEvents qeventdispatcher_glib.cpp 87 0x7f628395c418
            44 QtInstance::ImplYield QtInstance.cxx 453 0x7f6284cd9a40
            45 QtInstance::DoYield QtInstance.cxx 464 0x7f6284cd9b69
            46 ImplYield svapp.cxx 390 0x7f628f739c32
            47 Application::Yield svapp.cxx 474 0x7f628f73a9d0
            48 Application::Execute svapp.cxx 368 0x7f628f739925
            49 desktop::Desktop::Main app.cxx 1614 0x7f6299037216
            50 ImplSVMain svmain.cxx 229 0x7f628f758df4
            51 SVMain svmain.cxx 261 0x7f628f759109
            52 soffice_main sofficemain.cxx 94 0x7f62990a4367
            53 sal_main main.c 51 0x56508cf899d4
            54 main main.c 49 0x56508cf899ba
        
        Change-Id: I1720d8acd72dca4ef6bc32935b920b2c1ff4d8f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163304
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [ee03b3a7e85c7bb293e161cc6ea7fe7bb3bc9240]

        tdf#156562 qt: Don't cache supported mime types/data flavors
        
        Drop the optimization to remember the supported
        data flavors in `QtTransferable::m_aMimeTypeSeq`
        and evaluate them each time instead.
        
        This is in preparation of allowing to change
        the mime data in an upcoming commit.
        
        Another alternative would be to (re-)calculate
        `QtTransferable::m_aMimeTypeSeq` only at the point
        in time that the mime data are set. Keep that
        in mind for further consideration in case this should
        ever become relevant from a performance perspective.
        
        Change-Id: Ic1792f6c2a19bf4c8f642a6288e9f3413fe7c893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163303
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-13  Michael Stahl  <michael.stahl@allotropia.de>  [47f50af3f057bac1739b7d17d781c0b1d05faa95]

        tdf#155663 writerfilter: RTF import: don't lose \piccrop*
        
        For DOCX the a:srcRect is imported in oox module in BlipFillContext and
        set on the XShape; obviously that doesn't work for RTF.
        
        The crop was already taken into account in
        RTFDocumentImpl::resolvePict(), but only to set the size of the picture;
        to actually set a crop effect, set shape's "GraphicsCrop" property
        in dmapper::GraphicImport::lcl_attribute().
        
        Change-Id: Ib12853724744542a09b0073fefc42ad32bb2ff19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163310
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-13  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [625fa07d3399eb85d8f4bf4bf9ae1d11532b477c]

        ITEM: corrected error for SfxSetItem
        
        Secured usage of FontList in SvxFontListItem
        usage (a test)
        
        Change-Id: I412a7681b3ece4e5d3751165d4b566ccdf5b2da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163257
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac2949ddaf78a95ab53d5d5f862b791d2c2d4312]

        UnoApiXmlTest: factor out common code
        
        Change-Id: I5c7f76b61a0dab8b4ebd1ac4680a7c25f982680c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163307
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-13  Dione Maddern  <dionemaddern@gmail.com>  [5b3c89570eb2d5a5f5069d30f1d9fee352db974e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e7e7e2431f1e3a5369a40d1b7b24191f92ed45e
          - tdf#155877 Fix broken embed links in Help pages
            
            Created a section called "methods_toc" in source/text/sbasic/shared/03/sf_writer.xhp so that the Methods section is embedded correctly in other files.
            
            Replaced link in text/scalc/guide/table_cellmerge.xhp to "text/shared/01/05100200.xhp#unmergecells"  with a link to "text/shared/01/05100200.xhp#h1" so that it links to the correct content for Unmerge Cells
            
            Replaced link in /text/scalc/main0218.xhp to "text/scalc/00/00000405.xhp#syautoformat" with a link to "text/shared/00/00040503.xhp#syautoformat" so that the help article displays the correct howtoget information for Autoformat Styles.
            
            Replaced link in /text/scalc/main0218.xhp to "text/scalc/00/00000405.xhp#syautoformat" with a link to "text/shared/00/00040503.xhp#syautoformat" so that the help article displays the correct howtoget information for Autoformat Styles.
            
            Replaced link in /text/scalc/main0218.xhp to "text/scalc/02/06080000.xhp#sythemes" with a link to "text/scalc/00/00000405.xhp#sythemes" so that the help article displays the correct howtoget information for Choose Themes.
            
            Replaced link in /text/shared/main0201.xhp to "text/shared/01/03010000.xhp#zoom" with a link to "text/shared/01/03010000.xhp#zoomlayout" so that it displays the correct help page information for "Zoom & View Layout".
            
            Corrected typo in text/shared/main0204.xhp so that the embedded link to source/text/swriter/00/00000405.xhp displays the correct information for Delete Column.
            
            Removed link in /text/swriter/main0204.xhp to "source/text/shared/01/AutoFormat.xhp#autoformattabelle" and replaced it with links to "text/shared/01/AutoFormat.xhp#par_id3145367" and "text/shared/00/00040503.xhp#syautoformat", so that it displays the correct description and icon for Autoformat.
            
            Change-Id: I261d19e0c819ac8bf2f7f83e6e540f76e5eabacd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163018
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ebf27c92e5743053fdfecb7709f017ffdced1b5a]

        PicDefOle and PicDefEmbed have the same layout now
        
        so just use PicDefEmbed
        
        Change-Id: I1b797b69e5c2137553ac24a73c229359ca3d935b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163301
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88931161db5ce8c70415590702981fcfe31d92ed]

        drop unused hwpole member
        
        Change-Id: I86fbe74c7d7faf66fcab63c2dcd24e13149c1671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163300
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6e4e2ff4dcef937652f0ce502f60bd11073525d7]

        drop unused PicDefFile union member
        
        Change-Id: Ib9b62595012c7220a849a54d0d61200ac0b132c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9bc2872d5ff9e18c0d5d2b60dbd6670809f2faa5]

        pass width hint around as twips and convert to pixel at the end
        
        reuse the device setup and twip calculation that GetOptimalColWidth uses
        and convert to pixel at the end with ViewData::toPixel
        
        Change-Id: Ie24a66dda2e642c23ae63ff915829dd910ee44dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163259
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 85db2b8338392525bb138f41a3175203c703bf73)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163284
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f9d8733aef959641e1b2b081c13e97fd8be09bf]

        ofz: scaling by 0 is an error for cairo rendering
        
        which leads to leaks as cairo doesn't do anything one entering
        an error state
        
        Change-Id: I8d0f7bcb9c705bb1c2c63b2bbbccdba788113df8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Steven Casey (SMCode)  <steve@caseycontact.com>  [6e0b4b9b9f5aeadf0deb4879b706fec50eb6135f]

        tdf#143148 Use pragma instead of include guards
        
        Change-Id: I0541d79dc8ddb79d433109d18aa658ff31dc7e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163268
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-13  Steven Casey (SMCode)  <steve@caseycontact.com>  [a3df4852b8cc1a1445fdc1fe0057b94a5405376d]

        tdf#158237 comphelper: Use C++20 contains() instead of find() and end()
        
        Change-Id: Iadb1203b1bd3f560c09ee38944c50190eed5735f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163269
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7bea643b8b09e27852dbd68459289873e2989feb]

        Fix mis-merge from 8b53fa726e0d496f18228b0ca9ce2f61196f6a57
        
        "Introduce a fundamental.override.ini for bootstrap variables"
        
        Change-Id: I88f11e422d98100bafd6fd9a7ab5e892dcc3fb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163292
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-13  Miklos Vajna  <vmiklos@collabora.com>  [c0da56cb3e9f9678cae7142dee03fb706a2aebd9]

        tdf#159483 sc HTML paste: handle data-sheets- attributes on a span
        
        Copy multiple cells, including a formula from google sheets to Calc, the
        formula is handled as a formula by the HTML paste. Do the same for a
        single cell, then only the result is pasted.
        
        The trouble is that the data-sheets-* attributes appear on <td> elements
        for multiple cells, but they appear on a <span> for a single cell.
        
        Fix the problem by extending ScHTMLLayoutParser::ProcToken() to handle
        the HtmlTokenId::SPAN_ON token and share the code between the <td> and
        <span> handler, so this markup works in both cases.
        
        Note that this is the paste handler, the no changes to the normal HTML
        import are made for now.
        
        Change-Id: Id749df9062d8fcb9a2f0acd928585a304efaae28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163291
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0cb78e2f6f76d5bb32487c6cf76a78bafedbbd45]

        ofz#66592 avoid double-init document properties throw issue
        
        Change-Id: Ia63f11c52de8c951c9bd1b03150a2982ba63ccb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163262
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3e94090120aa594f0a1d2a96adc3e602632ceb80]

        lok: remove unneeded mutex guard
        
        Change-Id: I9e9ef3fd4ad43c2523c286f534e14e839aada453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163114
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 21c215a0345feb347c7adeea5aca766ede23f54a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163283
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2004d0f616540d134845178cfe9f9e074131b3af]

        don't invalidate when switching tabs
        
        Change-Id: If013bb2a2d4de32da21ef6a86cc2237c6e75c0e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162049
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 9f3ee2b27ceeab175fb865a55cfeabd66fbb128d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [901dffd9ab559d2c246b4e2179f66e9cafd70170]

        try reenabling CppunitTest_dbaccess_hsqldb_test on macOS
        
        Change-Id: Ic2d2bdf2e472b04ddaba8585082256b560115d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163247
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [40bab7e27f13becb45055c9cfcd52aebf6128536]

        crashreportScraper: no need to go to the last page anymore
        
        JJ changed the way the reports are sorted to show
        the most recent ones on page 1
        
        Change-Id: I59d566ff45fd8a75263b70a1e436e4263422e93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163239
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-13  Miklos Vajna  <vmiklos@collabora.com>  [f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce]

        tdf#159453 sw floattable: fix unexpected overlap of in-header fly and body text
        
        Regression from commit e2076cf7a92694bc94bdc9f3173c2bddbe881a89
        (tdf#155682 sw floattable: fix DOCX with big pictures causes endless
        loop, 2023-10-25), the bugdoc's body text was wrapping around the
        floating table from the header, while the expectation was that the top
        of the body frame is below the bottom of the header frame.
        
        It seems IsFollowingTextFlow is only needed when the relation of the
        floating table is not "page", and this bugdoc has has an examplicit
        vertical relation of page.
        
        Solve the problem by limiting the IsFollowingTextFlow=true request for
        the floating table to the VertOrientRelation=page case, which fixes the
        bugdoc and keeps the old use-case working.
        
        The doc model for the new bugdoc now matches the WW8 import result.
        
        Change-Id: Ia3da65cd52d70b357e448a26a50ffb92a39795e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163290
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-13  Szymon Kłos  <szymon.klos@collabora.com>  [199b8ef1dffd3ef46b2319d9992c83ab47ccea05]

        jsdialog: use action for set_sensitive
        
        This will reduce protocol volume as we will send short
        message instead of JSON for the complete widget.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I5e7541915f7e2da4bf822b99a05cc3066073334e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163279
        Tested-by: Jenkins

2024-02-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ebd3f0971b843527ed493a35b2303c8c15b94109]

        Fall back to old bootstrap.ini [Win32] section, for backwards compatibility
        
        Change-Id: I629b2a16bc889f16595cd1718d2ee4535f31aed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162602
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit fe459b9595c851d00a861d595c8dd50b35c90be3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163255
        Tested-by: Jenkins

2024-02-13  Adam Seskunas  <adamseskunas@gmail.com>  [95dace2eb1ae7ce2fc000cc67e134b7bfadf2c35]

        tdf#154285 Check upper bound of arguments in SbRtl_CurDir
        
        The LibreOffice Basic specification says CurDir should accept one
        argument and in the case of a non-Windows system, ignore that argument
        and simply return the current directory. So check that SbRtl_CurDir
        accepts a maximum of two arguments.
        
        Change-Id: Ia60114fac31aa4261c8251e26ef172a0370e6abc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163150
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2024-02-13  Mike Kaganski  <mike.kaganski@collabora.com>  [5121c1f8a3dc1e326a4195393f463f5c0383859b]

        tdf#159689: trailing newline before "endstream" must not count in Length
        
        Change-Id: Ic1e636c9d4e5a531113f26e147427fb75ce3591c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163185
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-13  Kris van der Merwe  <kris@vandermerwe.co.nz>  [ffccbf4762a9ae810bcdd21c41fccdd436e7bfc9]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 892f0f402cf8347aa3273f774365c094c310cf1b
          - Updated Afrikaans dictionary
            
            Change-Id: Ief9cb53fdcbf794d1c54f4f5008f80b9975453d8
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/163265
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2024-02-12  Szymon Kłos  <szymon.klos@collabora.com>  [b34c69dd09069c4bb34fe4fe3225d304317999f1]

        jsdialog: enable animation properties in impress
        
        to test:
        1. click on any shape in Impress
        2. go to Animation tab in sidebar
        3. "add" animation
        4. double-click on added animation on the list
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I009cbdd295fac4f4533101c89d5c0268fbbe633a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162725
        Tested-by: Jenkins

2024-02-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ac4f5130e823bb64c0519838ebe3aab1da97aaf]

        tdf#159666: sd_uiimpress: Add unittest
        
        Change-Id: Id5e35e1514695bffeced718d48dcfeffc4a4d4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163250
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c84e8a14e476a70989e66df142e7b2426df02617]

        Search for load-time variables in fundamental.override.ini
        
        ...instead of arbitrarily cramming them into bootstrap.ini.  (And don't force
        those ini-files to have an additional [Win32] section, when
        include/rtl/bootstrap.h demands that "An ini-file is only allowed to have one
        section, which must be named `[Bootstrap]` with the square brackets.")
        
        Change-Id: I732bf9d771ea309eccd35b6db0f565a0c56a3c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162188
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 50b14f26de63d22b9ad05ca51d9edc53e024e75e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163252
        Tested-by: Jenkins

2024-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6047341fd5933ba96a07a0fc7c4b8ae1fb0e73d5]

        EnableAttachThreadInputHack can be a normal bootstrap variable
        
        (For simplicity, only treat a value of exactly "true" as enabling it, not
        whatever else the original Boost property_tree code might have considered as
        equivalent to "true".)
        
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162189
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit b5ed6906bd215f1338ae49e33d484350a26cb25f)
        Conflicts:
        	vcl/win/window/salframe.cxx
        
        Change-Id: I616c5d838d2b9046b3a92e01ebb68fc6deb37024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163253
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [033aaeec9ee6d7ab78690054ebf1ad8af5e3eff3]

        use more UNLESS_MERGELIBS
        
        Change-Id: I351a9127fb26369d8f598b6d6519d7e490fa476b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a993b2823a106d15a50005567266acfe2f65e28f]

        Log uses of fundamental.override.ini
        
        Change-Id: I36fa44b063a439edf5411a89f76ec342b1388351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162601
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit 6d553405101090ef7a7ff5270e5ef32aa41bd9b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163254
        Tested-by: Jenkins

2024-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8b53fa726e0d496f18228b0ca9ce2f61196f6a57]

        Introduce a fundamental.override.ini for bootstrap variables
        
        ...that is looked for next to the application and, when present, overrides all
        the other ways of setting bootstrap variables.  LibreOffice itself does not
        bring along such a fundamental.override.ini, but it can be convenient for an
        administrator to place one in the installation (which can then not be modified
        or overridden by end users).
        
        (For convenience, the naming of this ini-file starts to deviate from the old and
        rather pointless tradition of naming our ini-files *rc vs. *.ini on different
        platforms.)
        
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162187
        Tested-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        (cherry picked from commit f4d376e9a10a8c66f7f6ecfe6a1f4763c1927b52)
        Conflicts:
        	sal/rtl/bootstrap.cxx
        
        Change-Id: I057cc67b1af1d806587c3a4dc0bc31c28e79d22b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163251
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b663d94cf67a5af4fd89c1ac8bdffd6059f6bf85]

        create --enable-mergelibs=more
        
        The existing --enable-mergelibs is in use by Linux distro people,
        who do not want any further mergeing because they want to be
        able to split libreoffice up into things like nogui, calc, writer,
        dbaccess, etc.
        
        So this work is to enable combining even more into libmerged
        for platforms like Windows and macOS and COOL, where we really
        want everything in one big lump of code.
        
        Change-Id: I4b268864955747d9859e16ebb569debbfc32fa78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [cea0371ac77145ad1f3db7e558c279aeed6f4d00]

        tdf#125934 qt: Support module-specific window icons on Wayland
        
        As discussed in QTBUG-77182 [1], Qt currently doesn't provide
        API to directly set the app_id for a single window/toplevel on Wayland,
        but the one set for the application is used when the window gets shown.
        
        Make use of that by temporarily setting the app's desktop file
        name and doing a hide/show cycle in `QtFrame::SetIcon` on
        Wayland.
        
        A big thanks for David Redondo for mentioning that possibility
        in QTBUG-77182!
        
        An alternative would be to use private Qt API and low-level wayland API to
        set the app_id directly, s. discussion in QTBUG-77182.
        
        [1] https://bugreports.qt.io/browse/QTBUG-77182
        
        Change-Id: I2a93cd39756e2ebf55b91486927d73d3896245b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163249
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9d994e7ba64588d144f028d8873bedae42f3d021]

        Fix IwyuFilter in bridges
        
        after commit b3fa6e6e65031f92d7f13b44f8422fe4aa07e2f9
        
        Change-Id: I79e99d13d982f2190473904db4d63886c479b4f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163167
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-12  Oliver Specht  <oliver.specht@cib.de>  [828d2637fd3120bfd342b41548caf9c55fc0f603]

        tdf#159662 Add table alignment and left/right spacing to sidebar in Writer
        
        Change-Id: I12d898f21ca8c7d581aaa1c587c5b6434a35f516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162769
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-12  Michael Weghorn  <m.weghorn@posteo.de>  [e42b2827b5d392479791632877fc00b6add0307d]

        kf6: Add missing include path to fix build
        
        Many thanks to Andreas Sturmlechner for pointing
        this out on #libreoffice-dev on 2024-02-12:
        
        > [10:27] <asturm> michaelweghorn: I also had to apply a trivial
        >                  openmandriva patch to get it to build in the first place,
        >                  https://github.com/gentoo/gentoo/blob/master/app-office/libreoffice/files/libreoffice-24.2-kf6-buildfix.patch
        
        Change-Id: If86220e258336d84ffc30fd5da0f5d99dda59aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163237
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-12  Alain Romedenne  <alain.romedenne@libreoffice.org>  [f6f325d58d74e95c5c173a88a0a7a0de10bb0f8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e7c3f2c9147f60b6b9ba0a328951c094e133097
          - DataSheet help correction
            
            Change-Id: I3570ad7818df85f2dda3bbe81ecea59c9f16527f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163182
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-02-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8a52cc8972efc428e67f323cd3d5646d9970ce22]

        external/pdfium: Missing include (std::abs)
        
        Change-Id: Ia265f425cae86c671824ad355d6b91001c49adca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163236
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [bac09f76fd903c109b591a7bc15883e5653715ee]

        tdf#159666 Crash when table and line object are selected at the same time
        
        before
            commit e3077168072452fb8f1c0a8afb2992877cb96d1c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 17 09:49:37 2021 +0200
            loplugin:finalclasses
        the cast in
           const SdrEdgeObj* pEdge = static_cast<SdrEdgeObj*>(m_pObj);
        would incorrectly cast a SdrTableObj, but it happened to do nothing
        problematic.
        
        After the above commit, the vtable layout changed and it started
        crashing.
        
        Work around it by use dynamic_cast and ignoring objects that are not
        SdrEdgeObj.
        
        Change-Id: Ibe03d4935b8eeb182e037b1648d841e26fa23ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163242
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [cca29491a338cb7d43c373107bb73822e1d4e4a4]

        tdf#158440: sc: Add UItest
        
        Based on https://gerrit.libreoffice.org/c/core/+/163021/comments/ff5eb7d3_2426919e
        
        Change-Id: I579dce86775599dc215395b93b15bc9a2f510cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163243
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-12  Keldin Maldonado (KNM)  <kemaldonado@csumb.edu>  [5dadcd1ea9e63bcbc0a5d4c4cd95d7d8b37edef9]

        tdf#145538 use range based for loops
        
        using range based for loops instead of index based
        to increase readability in codebase
        
        Change-Id: Ib8c3ec3796fce9228cee1d90beb924128b0dea3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162950
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-02-12  varshneydevansh  <varshney.devansh614@gmail.com>  [2220b3718fd831e78485cba2a272e9af08907ddd]

        tdf#158337 use std::erase instead of std::remove followed by erase
        
        Change-Id: I36043cd3aa234f98bd0b7cc2868e9094976472b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163123
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2024-02-12  Heiko Tietze  <tietze.heiko@gmail.com>  [fe4e750d32cb88a9ce7a7539af6c6883d4194220]

        Resolves tdf#158531 - Connector lines for Keep Ratio setting
        
        Icons taken from https://thenounproject.com/icon/lock-89649/ and
        https://thenounproject.com/icon/unlock-89647/ (licensed PD)
        
        Change-Id: I7efd25e83726ced7dee4f876cf4bb4c8f54408df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160460
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-12  Sahil  <me.sahilgautam@gmail.com>  [d4c34206bcf64b94eac4f0761aeacc285e08af55]

        tdf#133836 Autofilter allow adding up members to the current selection
        
        Added a new checkbox [x] Lock, which if checked locks the current
        selection, and further items then can be added to that locked
        selection
        
        Change-Id: If8a5da308443458abfed59b303ee25feffa0aa6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159737
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-12  Noel Grandin  <noelgrandin@gmail.com>  [3b83c6ac804cf7adcea036d1fb7dda113a72f457]

        make BufferedDecompositionPrimitive2D store a Primitive2DReference..
        
        .. instead of a Primitive2DContainer.
        
        The container very frequently contains only a single item, since
        the decomposition method often sticks only a single top-level node
        in there, so it turns out to be a net loss overall, memory
        consumption-wise.
        
        Also, if we return a single Primitive2DReference from
        a BufferedDecomposition, that maximises the sharing of
        data between the BufferedDecomposition objects at the
        bottom of the decomposed tree, and objects higher up.
        
        Change-Id: Iaf272e60e2997299cc35a1bd209c51b6b79e9a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-12  Michael Stahl  <michael.stahl@allotropia.de>  [582ef812702413dbe7fb0f132bca3e3e4c2e1d40]

        tdf#158983 writerfilter: RTF import: fix page breaks and shape anchors
        
        Somehow, not sure why, the added import of \wrapdefault in commit
        86c0f58b6f9f392865196606173d1b98a6897f32 caused the page break in
        fdo55504-1.rtf to get lost.
        
        The first problem is that there is a \sbknone before the first \sect -
        this should not have any effect before \sect because \sbk* affect the
        *previous* section break, but it's not an option to simply ignore it
        (even if it works for this bugdoc) because it may be that there is no
        \sectd after \sect and then it will have an effect for the later
        section.
        
        The problem was in handling \page: here the premature \sbknone caused a
        sectBreak() which ate the page break; ignore it here by checking
        m_bHadSect.
        
        The second problem then was that now all but the first shape were
        anchored on page 2.
        
        This was because RTFDocumentImpl::beforePopState() for \shape of the 1st
        shape called parBreak() and that set the bIsFirstParaInSection flag.
        
        This flag prevented DomainMapper::lcl_utext() in the
        "if (m_pImpl->isBreakDeferred(PAGE_BREAK)) if (GetSplitPgBreakAndParaMark())"
        branch from inserting another paragraph break that is necessary to
        preserve the already inserted shapes anchored to the 2nd paragraph on
        page 1.
        
        (This is how it works for the equivalent DOCX document, with settings.xml
        edited to add w:splitPgBreakAndParaMark and remove "compatibilityMode"
        etc. because Word 2013 doesn't set these correctly.)
        
        The consequence is that when the second SwTextNode is converted to a
        text frame, all the shape anchors move to the next paragraph, the one
        with the RES_BREAK on it.
        
        Fix this by limiting the parBreak() handling in
        RTFDocumentImpl::beforePopState() to when the shape is a SwGrfNode,
        which is the scenario in the commit 0d9132c5046e15540abc20e45d64080708626441
        "fdo#47036 fix RTF import of shapes inside text frames at the start of the doc"
        - the testFdo47036 fails if the block is removed completely.
        
        This caused 2 test failures, but both cases look the same as in Word
        2013 now:
        
          Test name: (anonymous namespace)::testTdf158826_extraCR::Load_Verify_Reload_Verify
          An uncaught exception of type com.sun.star.uno.RuntimeException
          - unsatisfied query for interface of type com.sun.star.text.XTextTable!
        
          rtfexport2.cxx:537:Assertion
          Test name: (anonymous namespace)::testFdo47495::Load_Verify_Reload_Verify
          equality assertion failed
          - Expected: 2
          - Actual  : 1
        
        Change-Id: I43fa9431721650a6d748d1f4bda9aeaa7a9c6b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163200
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ca3c6d468f68af1506bf4e56b47655e5d56306a8]

        ITEM: ItemPool Rework (I)
        
        Driving forward the Item reworks I now take the
        ItemPool in focus: It now does not hold any items
        anymore and should be renamed to something like
        ItemInfoProvider/ItemHelper, since it's main purpose
        is to provide the Defaults for the Item functionality.
        
        There is that SfxItemInfo, only a struct and bundling
        SlotID and ItemFlags. There are also the DefaultItems,
        just handled as ptrs in an array. It is/was always
        error-prone to keep these in sync. Remember that it's
        also necessary for the order to not only being sorted
        but being increments of one with no gaps allowed in
        the WhichIDs to which the Items are bound.
        
        I now bundled that to a new class ItemInfo that joins
        WhichID, SlotID, ItemFlags and the default Item. This
        is a pure virtual base class, it comes in three
        derivations:
        
        (1) ItemInfoStatic:
        This is supposed to be global static and hosts the
        Item in a std::unique_ptr to ensure cleanup. It is
        designed to be constructed once during runtime and
        being shared globally. It allows the ItemPtr to be
        nullptr to mark as non-static (if initial static is
        not possible for some reason) but still offers the
        needed data. Most cases (95%+) are of that case.
        The contained Item is owned by that instance. The
        flag isStaticDefault() is set at the Item.
        
        (2) ItemInfoDynamic:
        This is supposed to be used for cases where the Item
        cannot be static: Mainly for SfxSetItem (that needs
        a Pool itself in the contained SfxItemSet, so lifetime
        is bound to that Pool), but other cases showed up in
        the transition. These instances live while the Pool
        lives and get destructed when the Pool goes down.
        Also uses std::unique_ptr for the Item instance for
        as much automated cleanup as possible, the contained
        Item is owned by that instance, the instance by the
        Pool. The flag isDynamicDefault() is set at the Item.
        
        (3) ItemInfoUser:
        This is used for UserDefaults that can be set for
        every ItemInfo entry to 'overshadow' the default
        from the 'outside'. It uses a regular Item and
        the central access methods implCreateItemEntry/
        implCleanupItemEntry to manage the Item instance,
        thus works like a SfxPoolItemHolder. The Item
        instance can be globally shared and re-used even
        when the Pool goes down. Instances belong to the
        Pool and are cleaned up when the Pool goes down.
        This Item does not need any further flag to be
        set.
        
        The ItemInfos are organized using a class
        called ItemInfoPackage:
        
        This bundles groups of ItemInfoStatic to
        functional instances. There are derivations/
        implementations of this e.g. for Writer ItemPool
        bundling all the needed defaults for Writer,
        similar for draw/impress, Calc and other usages.
        
        These ItemInfoPackage can be 'registered' at an
        ItemPool using it's method registerItemInfoPackage.
        This does all the needed stuff to setup that
        group of ItemInfos at the Pool (It even sets
        internal vars First/LastWhich, that info can just
        be derived from the buildup ItemInfo Ptrs).
        
        The ItemInfoPackage has methods 'size()' and
        'getItemInfo(index) to allow looping over it
        and deliver the infos the Pool needs. The
        (forced, pure virtual) overloads of getItemInfo
        in the specific implementations check for the
        ItemPtr being nullptr and create a exclusive
        incarnation of ItemInfoDynamic for the Pool if
        needed, returning that. The Pool owns the
        ItemInfoDynamic incarnations and uses the
        ItemInfoStatic directly. On shutdown it cleans
        up the ItemInfoDynamic as needed.
        
        The ItemInfoUser is used by the Pool when a
        UserDefault is set/used: for SetUserDefaultItem,
        GetUserDefaultItem, ResetUserDefaultItem. It
        is not held in a 2nd list, but directly in the
        list of ItemInfo'ptrs: To keep track of this
        an unordered_map is used that helds the original
        ItemInfo associated with the WhichID. That way
        no two lookups (as before) are needed to get the
        current Pool's default for any WhichID.
        
        The derivations of ItemInfoPackage are
        encapsulated and just allow access to an
        ItemInfoPackage& with a single method as
        return value. All use a static local instance
        of a std::array<ItemInfoStatic, FIXED_SIZE>
        which constructs all ItemInfoStatic and the
        static Item instances - if already possible.
        Sometimes it is necessary to overload the
        constructor to set some static instances
        for Items later than the lib init. These are
        also just marked with nullptr as Item instance.
        Some need to overload getItemInfo to complete
        instances of ItemInfoStatic, if needed, or
        create and deliver instances of ItemInfoDynamic.
        
        The registerItemInfoPackage also offers a
        optional lambda callback: there were two cases
        where local data from the Pool was needed to
        incarnate the item - just add that to the
        call to registerItemInfoPackage if needed,
        see examples in the adapted code.
        
        For the re-use of Items this means that now
        in SfxItemSet/SfxPoolItemHolder *true* static
        Items can and will be used without RefCount
        directly and globally. This is also the case
        for dynamic Items, with the exception of
        differing Pools for SfxSetItems which cannot
        be done.
        
        Future:
        That design is already prepared to allow
        solving that Pool-chaining problem: currently
        there are master/sub-pools and all accesses
        have to traverse that structure before even
        doing anything.
        For the future the idea is more to 'compose'
        a Pool by registering ItemInfoPackages, e.g.
        for Writer pool you may start with SfxItemPool,
        register the writer-specific ItemInfoPackage,
        then the one for DrawingLayer (if needed) and
        the one for EditEngine.
        It should also be possible to get to smaller
        granularities of that packages. Ideas for
        new ones will emerge. We might also think
        about composing Pools which can e.g. run Writer
        and Chart, so allowing to use Chart *without*
        OLE stuff in Writer - just ideas...
        
        More changes:
        - Adapted all stuff, cleaned up old stuff/
          definitions
        - Removed FreezeIdRanges, that can be done
          once per Pool on-demand (and cannot be
          forgotten to be called)
        - Merged XOutdevItemPool with SdrItemPool
          and offered a ItemInfoPackage which joins
          both needed sets of Items
        - All the cleanup hassle with Pools and
          defaults cleaned up
        - Adapted all access methods of the pool
          to use that new stuff. Pool chaining
          currently stays, but I use a central
          method 'getTargetPool' instead of
          recursive calling to get the correct
          Pool for the action
        
        Change-Id: I2b8d3d4c3cc80b1d0d0b3c0f4bd90d7656b4bab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163157
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-02-12  Miklos Vajna  <vmiklos@collabora.com>  [207501b8385818a5d413b9f4001e0d24aaa4f2a9]

        svx: prefix members of SdrHelpLineList
        
        See tdf#94879 for motivation.
        
        Change-Id: I172aad9fe63589a6a6bbbce77173a6fe24291ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163235
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [70cc059b7b9fbb38cbbdd04832dd6c87553c8672]

        merge collator_data library into i18npool
        
        they are both small libraries and this is one less library to
        dynamically link in at startup time
        
        Change-Id: I1b36ba1b11b9d69deea3fe0d91b512328d0a42a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163165
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-12  Miklos Vajna  <vmiklos@collabora.com>  [7812adb2ed11a3e08be24d3f2f94d14bfd740c55]

        tdf#159483 sc HTML paste: handle data-sheets-formula attribute
        
        When a formula cell gets copied from google docs, the value of the <td>
        element only contains the formula result. This means once value cells
        and formula cells gets copied together, the pasted formula cell won't
        updated anymore when the input values change.
        
        Turns out there is a data-sheets-formula attribute on <td> that contains
        the formula, it seems it uses the R1C1 format.
        
        Fix the problem by extending ScHTMLLayoutParser::TableDataOn() to parse
        this attribute and set a formula on the target cell (rather than a
        value) if the formula is available.
        
        This required also extending ScEEImport a bit, since the HTML paste
        builds on top of the RTF one in Calc.
        
        Change-Id: I720df96ce74a5e865b7329d06f3b719551f31b96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163234
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a476aa8d222a949a67676d95ec07914bbf00e23b]

        editeng: make TextPortionList iterable with ranged for
        
        Change-Id: Ifbddd99b5877c71ebbec064672b75877fe06ccd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163226
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d0d83b8b4a8ee5a889e1ffdf1293b858bf69caaf]

        editeng: move isEmpty impl. from ParaPortion to TextPortionList
        
        Change-Id: Ib305963b1f5ffcef9122dd4353826cc9033810f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163225
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3fa841c864bb17cfd405814188efa99e4d334ffc]

        editeng: prefix members of ParaPortion & add some access methods
        
        Change-Id: I6be67530690d1d5ee1236d654dd65cc8545e95d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163224
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d3242ef3a6f111d6220c60d5c1b968c7f46fc5f]

        ofz#66222 Timeout, raise glyph cache size for fuzzing
        
        Change-Id: I78517eaf366e855f6a10676e90662560b27a27fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163233
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [03fdb8319f2c156ff39deee819810934aae237c3]

        cid#1559961 silence Free of address-of expression
        
        Change-Id: I853b16d84a865a915e6489f38db3737d0efe59e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163232
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2b93f4de13e67e91fb86376dc2633051444e85f0]

        Adapt to modified clang::PPCallbacks::InclusionDirective
        
        ...in LLVM 19 trunk
        <https://github.com/llvm/llvm-project/commit/da95d926f6fce4ed9707c77908ad96624268f134>
        "[clang][lex] Always pass suggested module to `InclusionDirective()` callback
        (#81061)"
        
        Change-Id: I85a4f60fb3e514d3372118da454402dff6ad45e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163229
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6e22bee153e36989069124e8d1a55d6d6ba433a]

        use --enable-mergelibs for the macos build
        
        Change-Id: I4c3ce5247e42155d7c53c288ee68bacfa4db8103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162876
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-11  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [5ccee13baa29c9899c88519ad71ed18c3fe944c1]

        tdf#155218 sc: fix incorrect print area
        
        In the print dialog, changes to the page orientation should not alter
        the print area that is defined by the page style.
        
        issue caused by commit I5e494a0714e398221bee00744d7e25c419a41df7
        (tdf#155218 sc: fix different page orientation in print dialog)
        
        Change-Id: I44eb3b30df0e8a227743df334da35316f86a0679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163231
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-02-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4179056285395319d5fd5af77090359fc8b874a8]

        Fix quoting of [ ]
        
        Change-Id: I57c96fe9f72794abb4f49f63735c075a4647bd23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163228
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-11  Patrick Luby  <guibmacdev@gmail.com>  [fa1b6aa517966991ce1a1d0135bd5dfae331ab9a]

        tdf#155710 handle conversion failures due to non-UTF8 strings
        
        Windows and Linux paths can be passed as parameters to this function
        and those paths may not always be UTF8 encoded like macOS paths.
        
        Change-Id: I83f5ab491d3c0ddd938e512fbab3213af9ea16fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163223
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d248a7131ff495fb817cc4963298363b9e1b2008]

        osl_get_system_random_data should return bool
        
        Change-Id: I29535d3562fe1b8d05b8df1d6c9ab83e4ead0f74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163227
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-11  Mike Kaganski  <mike.kaganski@collabora.com>  [7d594687216f183a681ecfe7e1d424d8a55422c2]

        tdf#54169: do not hide mnemonics in menu, when navigating using mouse
        
        Pressing Alt (or F10) by itself would activate/highlight the menu, and
        show mnemonics. But clicking such activated menu used to disable the
        mnemonics. This change fixes it, making sure that they keep displaying
        until closing the menu.
        
        Change-Id: I60f04e1474a8eb1322e5ac75f74b02d67dce9b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163217
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [17fc445938dedb05125a6d6a5b4ce7f34ea95f59]

        perf: limit to max 1024 rows in cases where we originally allocated 1024 rows
        
        so everywhere before:
        
        commit a86c00414a43c5d87981ffae1018cb242c5e5e1d
        Date:   Fri Jan 19 14:27:10 2024 +0200
        
            cool#6893 reduce allocation in ScGridWindow::PaintTile
        
        where ScTableInfo was used with no args, pass true to indicate this is
        just a hint, and where it was originally passed an explicit number, pass
        false for "hint"
        
        When hint is true limit to max of 1024 rows, and the issue
        is visible in ScGridWindow::UpdateFormulaRange at
        https://github.com/CollaboraOnline/online/issues/6893#issuecomment-1921141048
        
        CppunitTest_sc_uicalc contains some examples of these where hidden rows
        triggers the over allocs
        
        Change-Id: Iebe890c3ac967800b60150aaa71f7e845a021f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162875
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e4410bd37fc018c851b5ebf9cf011d59af6a2ad9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163060
        Tested-by: Jenkins

2024-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9599edeeea12cb62df53308f820316ee8682575c]

        cid#1559951 silence Use after free
        
        Change-Id: I3b64a77bfc8b305d73166eaa14d96301fa1aad05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163219
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [428ab490cb39c43c88bfc0e06450bfc91ffdcff6]

        cid#1591764 silence Double free
        
        Change-Id: I21af2580f35d716ed32d565f07f84b4bbfdd2507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163218
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [edab3a9fd243c238f840db84af31c39c3617eb8c]

        cid#1591787 silence Arguments in wrong order
        
        Change-Id: Iee6dba0a127a126bc47dcb5c98efa86274d79340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [a2dd71feb75d93adf0f0daac899e7476f961ec34]

        tdf#54169: implement auto-accelerator feature on Windows
        
        Change-Id: I219dfc0c8377628c10e5a19232d19260923bf614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163215
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [f2dfb95258215f90562617823b950c3ed151c1bf]

        tdf#54169: revert "gtk is the only case auto-accel is true, and the
        
        ... menubar is native gtk there" (commit 3fbae5dc7e7b200776bbc8a7c2a43e1e04f15a2b
        from 2021-08-05).
        This will be needed for auto-accel on Windows.
        
        Change-Id: Ie37de17e35658a0f7c748d3c9dd923dba954298c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163214
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [25bd3e444e4f8bbe1ca83b21a76daef1695a51dc]

        Drop obsolete handling of wheel mouse
        
        Change-Id: I9958e69c953563285577f5cdea220371af4848d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163213
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [2790acbb29f8d5f180cd86d924c1e991e7d854df]

        Simplify a bit
        
        Use existing rtl_ustr_ascii_compareIgnoreAsciiCase, instead of inventing
        an own local comparison function.
        And standardize on WM_SETTINGCHANGE, which is the same as WM_WININICHANGE.
        
        Change-Id: Ifaf1f73066edf7d553174b529be5aa55179ae92e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163212
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-10  Regina Henschel  <rb.henschel@t-online.de>  [56517d8a38459f5a9e67327c1ac0dc8bcd07bcb8]

        tdf#156993 use correct count for ViewContactOfSdrPage
        
        The count is used as upper limit in a for-loop in
        ViewObjectContact::getPrimitive2DSequenceSubHierarchy().
        That calls ViewContactOfSdrPage::GetViewContact().
        With the wrong count the case 10 was not reached and thus the helplines
        were not drawn.
        
        Change-Id: If606bbb718b1f78a874862217d1e03b02287e848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163192
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-02-10  Julien Nabet  <serval2412@yahoo.fr>  [c4556bc19ca6da0032b9a43cc64f6a76966121d2]

        Fix WASM TB following ace21b4b2537a3cf2301fca2ac6f78d0612e911f
        
        Change-Id: If881428bf69587ad9067378cde01caa87d56c1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163211
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d0317669ac673d52d6fbe8da4c1dcc9fa17cc290]

        editeng: simplify and clean-up struct in for ImpEditEng
        
        Change-Id: I8ca190f957e6bf15f6c0aa8b8e22a26e896a9374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163198
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [890229e3673ff1fde4ef5eedbb394c936190fc0e]

        Fix typo
        
        Change-Id: I5c378f1df6ec8b09c09631b1a6848d68ce1cf95b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163209
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-10  Hubert Figuière  <hub@collabora.com>  [46ea6ae814e83b380b5f6bd044119af8247583a8]

        vcl: Enable sheet protection dialog
        
        Change-Id: Ib8e8209225d027472c1f2eef57839df5784acf30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163205
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 5c1c842863ee2a63ce69a75ef0820864864905f0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163174
        Tested-by: Jenkins

2024-02-10  Julien Nabet  <serval2412@yahoo.fr>  [9530664d07f400f4d8dcbe54d0e82d69168844de]

        tdf#159588: Query-GUI: LOWER isnt supported in Query-GUI if condition is LIKE
        
        Let's consider "SQL_TOKEN_LOWER" and "SQL_TOKEN_UPPER" as "string_function_1Argument"
        like "SQL_TOKEN_LCASE" and "SQL_TOKEN_UCASE"
        
        Change-Id: I288fd5f3d9e3d104345c73a060ba11d9701500a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163099
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-10  varshneydevansh  <varshney.devansh614@gmail.com>  [b370357b40b55cece8407eea2dc0014a5aec0d17]

        tdf#141908: replace usage of sal_Int32 with colors
        
        Change-Id: I71d94239c155f41d4535c023ea3aa8f974fcf2da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163082
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [49111fe70fec5a5f074e6c1b1dd60f6b57139a25]

        qt: Set desktop file name without ".desktop" suffix
        
        This fixes this warning when starting LO with the qt6
        VCL plugin on Wayland (using a local qtbase dev build):
        
            > QGuiApplication::setDesktopFileName: the specified desktop file name ends with .desktop.
            > For compatibility reasons, the .desktop suffix will be removed. Please specify a desktop file name without .desktop suffix
        
        The icon is also still shown fine with qt5/kf5
        (qtbase at 5.15.10+dfsg-6 from Debian testing).
        
        Change-Id: I0eca1b3767ff65653d5f6b3104550fb0d8aea293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163204
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [cb9513c74502144a480494e0c6a32ac6173ae0a3]

        tdf#158947 sw: Don't unrelatedly overwrite system clipboard on paste
        
        In `SwTransferable::RemoveDDELinkFormat`, only update the
        clipboard content with this `SwTransferable` after removing
        the `SotClipboardFormatId::LINK` from the supported formats
        if the `SwTransferable` was the clipboard content before
        already.
        
        Doing so always would unrelatedly overwrite what was previously
        copied from another application to the clipboard for the
        tdf#158947 scenario of pasting clipboard content of another
        application over a selection when using the Qt-based VCL plugins
        on Wayland (s. backtrace below that shows how the clipboard content
        was overwritten, frame #17 is the method changed in this
        commit).
        
        My assumption why the clipboard content is explicitly overwritten
        at all is to make sure that the system clipboard on some platforms
        gets notified about the change in supported formats/mime
        types after removing one. But that isn't necessary when the
        transfer data modified here aren't the current clipboard content
        in the first place.
        
        Backtrace for how clipboard content was previously overwritten
        for the tdf#158947 scenario with the qt6 VCL plugin on Wayland:
        
            ~"#0  QtClipboard::handleChanged(QClipboard::Mode) (this=0x557f90457770, aMode=QClipboard::Clipboard) at .../libreoffice/vcl/qt6/../qt5/QtClipboard.cxx:156\n"
            ~"#1  0x00007f26f08844ff in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}::operator()() const (__closure=0x7ffe889a2c20) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:153\n"
            ~"#2  0x00007f26f0884ffb in QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}>(void**, QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**)::{lambda()#1}&&) (args=0x7ffe889a2ed0, fn=...) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:72\n"
            ~"#3  0x00007f26f088456f in QtPrivate::FunctorCall<QtPrivate::IndexesList<0>, QtPrivate::List<QClipboard::Mode>, void, void (QtClipboard::*)(QClipboard::Mode)>::call(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**) (f=(void (QtClipboard::*)(QtClipboard * const, QClipboard::Mode)) 0x7f26f087a76e <QtClipboard::handleChanged(QClipboard::Mode)>, o=0x557f90457770, arg=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:152\n"
            ~"#4  0x00007f26f08833de in QtPrivate::FunctionPointer<void (QtClipboard::*)(QClipboard::Mode)>::call<QtPrivate::List<QClipboard::Mode>, void>(void (QtClipboard::*)(QClipboard::Mode), QtClipboard*, void**) (f=(void (QtClipboard::*)(QtClipboard * const, QClipboard::Mode)) 0x7f26f087a76e <QtClipboard::handleChanged(QClipboard::Mode)>, o=0x557f90457770, arg=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:200\n"
            ~"#5  0x00007f26f0881f71 in QtPrivate::QCallableObject<void (QtClipboard::*)(QClipboard::Mode), QtPrivate::List<QClipboard::Mode>, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x557f904555f0, r=0x557f90457770, a=0x7ffe889a2ed0, ret=0x0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:571\n"
            ~"#6  0x00007f26efdb863f in QtPrivate::QSlotObjectBase::call(QObject*, void**) (this=0x557f904555f0, r=0x557f90457770, a=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:487\n"
            ~"#7  0x00007f26efe5772e in doActivate<false>(QObject*, int, void**) (sender=0x557f8d510fd0, signal_index=3, argv=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:4116\n"
            ~"#8  0x00007f26efe4cdef in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=0x557f8d510fd0, m=0x7f26efa47cc0 <QClipboard::staticMetaObject>, local_signal_index=0, argv=0x7ffe889a2ed0) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:4176\n"
            ~"#9  0x00007f26eede9fcc in QClipboard::changed(QClipboard::Mode) (this=0x557f8d510fd0, _t1=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/Gui_autogen/include/moc_qclipboard.cpp:182\n"
            ~"#10 0x00007f26eede9bc1 in QClipboard::emitChanged(QClipboard::Mode) (this=0x557f8d510fd0, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qclipboard.cpp:558\n"
            ~"#11 0x00007f26eee4ed69 in QPlatformClipboard::emitChanged(QClipboard::Mode) (this=0x557f88019c20, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qplatformclipboard.cpp:89\n"
            ~"#12 0x00007f26ed78809e in QtWaylandClient::QWaylandClipboard::setMimeData(QMimeData*, QClipboard::Mode) (this=0x557f88019c20, data=0x557f8fb87930, mode=QClipboard::Clipboard) at .../qt5/qtwayland/src/client/qwaylandclipboard.cpp:89\n"
            ~"#13 0x00007f26eede99de in QClipboard::setMimeData(QMimeData*, QClipboard::Mode) (this=0x557f8d510fd0, src=0x557f8fb87930, mode=QClipboard::Clipboard) at .../qt5/qtbase/src/gui/kernel/qclipboard.cpp:447\n"
            ~"#14 0x00007f26f087a5b5 in QtClipboard::setContents(com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> const&, com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardOwner> const&) (this=0x557f8d50cbb0, xTrans=uno::Reference to (SwTransferable *) 0x557f90440118, xClipboardOwner=uno::Reference to (SwTransferable *) 0x557f90440120) at .../libreoffice/vcl/qt6/../qt5/QtClipboard.cxx:137\n"
            ~"#15 0x00007f26fb05bacc in TransferableHelper::CopyToClipboard(com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard> const&) const (this=0x557f904400f0, rClipboard=uno::Reference to (QtClipboard *) 0x557f8d50cc10) at .../libreoffice/vcl/source/treelist/transfer.cxx:942\n"
            ~"#16 0x00007f26fb05bc77 in TransferableHelper::CopyToClipboard(vcl::Window*) const (this=0x557f904400f0, pWindow=0x557f8932d1f0) at .../libreoffice/vcl/source/treelist/transfer.cxx:957\n"
            ~"#17 0x00007f26b5130940 in SwTransferable::RemoveDDELinkFormat(vcl::Window&) (this=0x557f904400f0, rWin=...) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:385\n"
            ~"#18 0x00007f26b51440ab in SwTransferDdeLink::DataChanged(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x557f8fb864e0) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:4447\n"
            ~"#19 0x00007f270120fa0e in sfx2::SvLinkSource::NotifyDataChanged() (this=0x557f8fb8bbe0) at .../libreoffice/sfx2/source/appl/linksrc.cxx:291\n"
            ~"#20 0x00007f26b43210ba in SwServerObject::SendDataChanged(SwPaM const&) (this=0x557f8fb8bbe0, rRange=SwPaM = {...}) at .../libreoffice/sw/source/core/doc/swserv.cxx:177\n"
            ~"#21 0x00007f26b43217c2 in SwDataChanged::~SwDataChanged() (this=0x7ffe889a3520, __in_chrg=<optimized out>) at .../libreoffice/sw/source/core/doc/swserv.cxx:308\n"
            ~"#22 0x00007f26b4233c8b in sw::DocumentContentOperationsManager::DeleteRangeImplImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4474\n"
            ~"#23 0x00007f26b4233826 in sw::DocumentContentOperationsManager::DeleteRangeImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4419\n"
            ~"#24 0x00007f26b4233681 in sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:4391\n"
            ~"#25 0x00007f26b421edb7 in (anonymous namespace)::lcl_DoWithBreaks(sw::DocumentContentOperationsManager&, SwPaM&, SwDeleteFlags, bool (sw::DocumentContentOperationsManager::*)(sw::DocumentContentOperationsManager* const, SwPaM&, SwDeleteFlags)) (rDocumentContentOperations=..., rPam=SwPaM = {...}, flags=SwDeleteFlags::Default, pFunc=(bool (sw::DocumentContentOperationsManager::*)(sw::DocumentContentOperationsManager * const, SwPaM &, SwDeleteFlags)) 0x7f26b4233632 <sw::DocumentContentOperationsManager::DeleteAndJoinImpl(SwPaM&, SwDeleteFlags)>) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:681\n"
            ~"#26 0x00007f26b42279df in sw::DocumentContentOperationsManager::DeleteAndJoin(SwPaM&, SwDeleteFlags) (this=0x557f8d2b8000, rPam=SwPaM = {...}, flags=SwDeleteFlags::Default) at .../libreoffice/sw/source/core/doc/DocumentContentOperationsManager.cxx:2367\n"
            ~"#27 0x00007f26b44a71f6 in SwEditShell::DeleteSel(SwPaM&, bool, bool, bool*) (this=0x557f8d51b300, rPam=SwPaM = {...}, isArtificialSelection=false, goLeft=false, pUndo=0x7ffe889a3be6) at .../libreoffice/sw/source/core/edit/eddel.cxx:122\n"
            ~"#28 0x00007f26b44a7671 in SwEditShell::Delete(bool, bool) (this=0x557f8d51b300, isArtificialSelection=false, goLeft=false) at .../libreoffice/sw/source/core/edit/eddel.cxx:164\n"
            ~"#29 0x00007f26b5604933 in SwWrtShell::DelRight(bool) (this=0x557f8d51b300, isReplaceHeuristic=false) at .../libreoffice/sw/source/uibase/wrtsh/delete.cxx:312\n"
            ~"#30 0x00007f26b512fe14 in (anonymous namespace)::SwTrnsfrActionAndUndo::SwTrnsfrActionAndUndo(SwWrtShell*, bool, SwPasteContext*) (this=0x557f9045b020, pS=0x557f8d51b300, bDelSel=true, pContext=0x7ffe889a4220) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:236\n"
            ~"#31 0x00007f26b51377c1 in SwTransferable::PasteData(TransferableDataHelper const&, SwWrtShell&, unsigned char, SotExchangeActionFlags, SotClipboardFormatId, SotExchangeDest, bool, bool, Point const*, signed char, bool, RndStdIds, bool, SwPasteContext*, PasteTableType) (rData=..., rSh=..., nAction=36 '$', nActionFlags=(SotExchangeActionFlags::InsertImageMap | SotExchangeActionFlags::InsertTargetUrl), nFormat=SotClipboardFormatId::HTML, nDestination=SotExchangeDest::SWDOC_FREE_AREA, bIsPasteFormat=false, bIsDefault=false, pPt=0x0, nDropAction=0 '\\000', bPasteSelection=false, nAnchorType=RndStdIds::FLY_AT_PARA, bIgnoreComments=false, pContext=0x7ffe889a4220, ePasteTable=PasteTableType::PASTE_DEFAULT) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:1768\n"
            ~"#32 0x00007f26b5137333 in SwTransferable::Paste(SwWrtShell&, TransferableDataHelper&, RndStdIds, bool, PasteTableType) (rSh=..., rData=..., nAnchorType=RndStdIds::FLY_AT_PARA, bIgnoreComments=false, ePasteTable=PasteTableType::PASTE_DEFAULT) at .../libreoffice/sw/source/uibase/dochdl/swdtflvr.cxx:1687\n"
            ~"#33 0x00007f26b52d29e9 in SwBaseShell::ExecClpbrd(SfxRequest&) (this=0x557f8db64330, rReq=...) at .../libreoffice/sw/source/uibase/shells/basesh.cxx:365\n"
            ~"#34 0x00007f26b52d1681 in SfxStubSwBaseShellExecClpbrd(SfxShell*, SfxRequest&) (pShell=0x557f8db64330, rReq=...) at .../libreoffice/workdir/SdiTarget/sw/sdi/swslots.hxx:2219\n"
            ~"#35 0x00007f27012d14dc in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=0x557f8d4f46b0, rShell=..., rSlot=..., rReq=..., bRecord=true) at .../libreoffice/sfx2/source/control/dispatch.cxx:254\n"
            ~"#36 0x00007f27012d4b34 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) (this=0x557f8d4f46b0, rShell=..., rSlot=..., rReq=..., eCallMode=SfxCallMode::RECORD) at .../libreoffice/sfx2/source/control/dispatch.cxx:753\n"
            ~"#37 0x00007f27012c05d4 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) (this=0x557f8d503240, aReq=..., pSlot=0x7f26b6cf5360 <aSwBaseShellSlots_Impl+1440>, pShell=0x557f8db64330) at .../libreoffice/sfx2/source/control/bindings.cxx:1057\n"
            ~"#38 0x00007f270139813d in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (this=0x557f8db682a0, aURL=..., aArgs=empty uno::Sequence, rListener=empty uno::Reference) at .../libreoffice/sfx2/source/control/unoctitm.cxx:688\n"
            ~"#39 0x00007f2701395dbf in SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x557f8db68200, aURL=..., aArgs=empty uno::Sequence) at .../libreoffice/sfx2/source/control/unoctitm.cxx:250\n"
            ~"#40 0x00007f26fe03d948 in svt::(anonymous namespace)::AsyncAccelExec::impl_ts_asyncCallback(LinkParamNone*) (this=0x557f8fb8e070) at .../libreoffice/svtools/source/misc/acceleratorexecute.cxx:508\n"
            ~"#41 0x00007f26fe03d869 in svt::(anonymous namespace)::AsyncAccelExec::LinkStubimpl_ts_asyncCallback(void*, LinkParamNone*) (instance=0x557f8fb8e070, data=0x0) at .../libreoffice/svtools/source/misc/acceleratorexecute.cxx:500\n"
            ~"#42 0x00007f26fab0db3b in Link<LinkParamNone*, void>::Call(LinkParamNone*) const (this=0x557f8fb8e110, data=0x0) at .../libreoffice/include/tools/link.hxx:111\n"
            ~"#43 0x00007f26fb469f3d in vcl::EventPoster::DoEvent_Impl(void*) (this=0x557f8fb8e108) at .../libreoffice/vcl/source/helper/evntpost.cxx:52\n"
            ~"#44 0x00007f26fb469f05 in vcl::EventPoster::LinkStubDoEvent_Impl(void*, void*) (instance=0x557f8fb8e108, data=0x0) at .../libreoffice/vcl/source/helper/evntpost.cxx:48\n"
            ~"#45 0x00007f26fadc2373 in Link<void*, void>::Call(void*) const (this=0x7f26e80153b8, data=0x0) at .../libreoffice/include/tools/link.hxx:111\n"
            ~"#46 0x00007f26fadbf458 in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x7f26e80153b0) at .../libreoffice/vcl/source/window/winproc.cxx:2287\n"
            ~"#47 0x00007f26fadc1385 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x557f897d0e90, nEvent=SalEvent::UserEvent, pEvent=0x7f26e80153b0) at .../libreoffice/vcl/source/window/winproc.cxx:2851\n"
            ~"#48 0x00007f26f08b6bae in SalFrame::CallCallback(SalEvent, void const*) const (this=0x557f8800cf80, nEvent=SalEvent::UserEvent, pEvent=0x7f26e80153b0) at .../libreoffice/vcl/inc/salframe.hxx:310\n"
            ~"#49 0x00007f26f08d9dbf in QtInstance::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x557f88020780, aEvent=...) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:516\n"
            ~"#50 0x00007f26fb47b97f in operator()() const (__closure=0x7ffe889a50e0) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119\n"
            ~"#51 0x00007f26fb47bc53 in SalUserEventList::DispatchUserEvents(bool) (this=0x557f880207b8, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120\n"
            ~"#52 0x00007f26f08d98a4 in QtInstance::ImplYield(bool, bool) (this=0x557f88020780, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:442\n"
            ~"#53 0x00007f26f08d9a4f in QtInstance::DoYield(bool, bool) (this=0x557f88020780, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:464\n"
            ~"#54 0x00007f26fb5390d0 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:390\n"
            ~"#55 0x00007f26fb539e6e in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:474\n"
            ~"#56 0x00007f26fb538dc3 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:368\n"
            ~"#57 0x00007f2704e371b6 in desktop::Desktop::Main() (this=0x7ffe889a5c10) at .../libreoffice/desktop/source/app/app.cxx:1614\n"
            ~"#58 0x00007f26fb558292 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229\n"
            ~"#59 0x00007f26fb5585a7 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261\n"
            ~"#60 0x00007f2704ea4307 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94\n"
            ~"#61 0x0000557f862d19d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51\n"
            ~"#62 0x0000557f862d19ba in main (argc=3, argv=0x7ffe889a5e38) at .../libreoffice/desktop/source/app/main.c:49\n"
            2906^done
            (gdb)
        
        Change-Id: I1f517d441eeb3e77e969062b884d9a425038b22a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163202
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-10  AkshayWarrier  <aksmen121@gmail.com>  [ace21b4b2537a3cf2301fca2ac6f78d0612e911f]

        tdf#159372 svx: Add goto dialog
        
        Adds a goto page/slide dialog for Impress and Draw similar to Writer.
        To avoid duplicating code and ui, the dialog is created in svx/ and used in other modules.
        The old goto dialog in Writer has now been replaced with this dialog.
        
        Change-Id: I28f819f0d0734fb2bb08a7b99a628217ef66dba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162913
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9af4b5254cbe6a6770ebe78ba14074266b05471e]

        sc: pivot table not correct when data and PT cache is not in sync
        
        It can happen that the pivot table is not updated and the sheet
        data is changed so much that it doesn't match the pivot table
        cached definitions. This is a perfectly valid scenario and
        nothing should be wrong (the pivot table can just be updated
        once loaded).
        
        At XLSX import we should always check the cached definitions,
        because the pivot table description is made using the cached data,
        not the actual data.
        
        The issue can occur when looking up the name of a PT field we
        however didn't check the cached definition but checked the
        sheet data, so because the indices changed so much (many columns
        were removed in the sheet data) we can not find the actual field
        name. The solution is simple - get the field name from the cached
        pivot table definition.
        
        Change-Id: I3b5b33f33f3c484f0b66b97ac97200d9913edcfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163197
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-10  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f4a726ddac042497b9553c7eb64372ed60fccaea]

        Resave with newer Glade
        
        Change-Id: I2f0704d924f37e61330240065a63faedb6645025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163201
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1e1508b31923a1a47abf4ae6749656a2d429cbfe]

        cid#1591762 Uncaught exception
        
        Change-Id: I84af562e2900acfdfc1cef16d2745d9596cc7a56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163194
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-09  Miklos Vajna  <vmiklos@collabora.com>  [02fa0d84262e35fc5c0ef763eedd3d5eb0ab107f]

        sw doc model xml dump: SwFieldType doesn't own its format fields
        
        The field type doesn't own its format fields, is just aware of them. So
        just show the pointer there, the matching text attribuet will do a full
        dump, as it's the owner.
        
        This fixes dumping e.g. post-it fields twice for no reason.
        
        Change-Id: I3ff40da059d25eddc87a2ce329c29af5f01d049c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163153
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-09  Miklos Vajna  <vmiklos@collabora.com>  [789964785a61daab5f8065f006dd7aaf843c7236]

        tdf#159483 sc HTML import: handle data-sheets-value attribute for the num case
        
        E.g. have "1,000.00" and "2,000.00" in two cells, paste that into calc,
        and try to do a SUM() on them, which will fail because the cell content
        is text.
        
        Just data-sheets-value itself would not be good solution, because then
        we would lose the number format, so the paste result would be like 1000,
        which is bad for readability if you don't want further operations on the
        value.
        
        Fix the problem by also parsing the data-sheets-numberformat attribute,
        so far what's clear is that the "2" JSON key there provides a number
        format string which matches the syntax of Excel/Calc.
        
        This gives the best of the two worlds: the output looks like the
        original, but SUM() works on the cells as well.
        
        Change-Id: Ic7c09ba55a51852f285ad0c05ed42c6771b0f500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163152
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e95ce2620267e04bc89eb701a3df8ded7c3b729f]

        cid#1591767 Uninitialized scalar field (unused bSortedBinarySearch)
        
        since:
        
        commit 68738bd0ac262819b13ea7e11af67ee493b9b3e1
        Date:   Thu Feb 1 14:36:24 2024 +0100
        
            Related: tdf#127293 Fix function XLOOKUP binary search corner cases
        
        Change-Id: Idc6ce795779d264a67fff93da74ce5c45381940f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [00ac644f0b7a8a5d987301582752c455621a62e4]

        cid#1591766 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1591765 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id0a983dde94985025f84d081136d0f743f190855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163163
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [108edd58e854a0121c5c73a384614c1d216633cf]

        cid#1591760 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1591761 COPY_INSTEAD_OF_MOVE
        cid#1591763 COPY_INSTEAD_OF_MOVE
        cid#1591768 COPY_INSTEAD_OF_MOVE
        cid#1591769 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia1c829f96148dc79cea02a69b3442c18d51e1288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163162
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [112dd7edb69a0262d829fb071df1bc5d402aab50]

        ofz#66573 directly invert the colors in the palette
        
        instead of looping over each pixel.
        
        Change-Id: I00d23d0c7d16dcf6e71c81bbad0a7b4cd3d241a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163159
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [30b27bd038a9362b2a13c6ea7d9cdad0ae012cac]

        use more SAL_MODULENAME macro
        
        which simplifies the call sites
        
        Change-Id: Ic884ee8568c9f1346ff49fd3e0dc951ed5cc4cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cbed7b6a8a3ded92020e0dce3c562d867299fe1]

        add chartcore&chartcontroller to mergedlibs
        
        Change-Id: I16b930072d71947acd606a2103e12dea27be3b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-09  Luv Sharma  <luvsharma.del@gmail.com>  [5fef3ebe9efd4d4e8569e620e82771f5560c5524]

        tdf#148645 getDec2Hex now takes  integer 'places' value (updated)
        
        Change-Id: Ibc793f7654c9ec9b1a96b3caf2c16f2fde14c030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163005
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [41192a36796155f8cd6ac733f5ef84767edf300f]

        Related: tdf#127293 Fix function XLOOKUP with nested XLOOKUP functions
        
        to return reference of cells what other functions can use (e.g.:SUM):
        =SUM(XLOOKUP(B3,B6:B10,E6:E10):XLOOKUP(C3,B6:B10,E6:E10))
        
        XLOOKUP function returns a reference to a range of cell(s).
        
        Change-Id: I06007aba7017315fc02a92b120f842244b7cc3c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163129
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-09  Michael Meeks  <michael.meeks@collabora.com>  [ba0773e50b7058f12981c4d29fb05c34d7486290]

        preload: open and close empty documents of main types in preinit.
        
        Some quick testing suggest this saves ~800k for writer, ~3Mb for
        impress each loading an ~empty hello-world document.
        
        Change-Id: I9a7bc25d38d82b5556dfb04a99d5c145dd71ffec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162939
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit d85cb3832286ae1fdcf4a8494abb8212f21e4e9a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163148
        Tested-by: Jenkins

2024-02-09  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [a67cd7b3cf03163f87811f7080cabc49750c4fd5]

        tdf#155218 sc: fix different page orientation in print dialog
        
        The page orientation is correct if you set it in the page style first.
        However, if you change it in the Print dialog the page layout and size
        refresh but the content orientation remains the same.
        
        Change-Id: I5e494a0714e398221bee00744d7e25c419a41df7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162845
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-02-09  Pranam Lashkari  <lpranam@collabora.com>  [7327752ef5d1fa2239cdd8355fb78da41c282717]

        writer:LOK: make sure deleted comment is not notified incorrectly
        
        problem:
        on saving the existing docummunet with tracked deleted comment,
        LOK gets comment added msg for those comments
        
        Change-Id: I5c63a5bbbb7215bf7416412604530af4a6c69358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163040
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163156
        Tested-by: Jenkins

2024-02-09  Gökay Şatır  <gokay.satir@collabora.com>  [48d2d456d8bcb296b4b2f6cc2d1184f9d799f070]

        Writer: Improve redline communication with libreofficeKit.
        
        When changes are tracked and user adds / removes a comment, we need a better communication.
        This PR improves the communication and sends the layout status of comments.
        Still there are things to do, like (while tracking is on):
        * We need to communicate when a change in comment is approved / rejected.
        * When user performs an undo on the removed comment.
        
        Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
        Change-Id: Ia3ea4b44c116cc571337e57960aa4f12f934701c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162756
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163155

2024-02-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [30fb8cde7579fb5da15c1d8da9611198f2f5ce78]

        tdf#159641 TreeView repaint problem with PgUp in kf5/gen
        
        regression from
            commit be53f32655973c7a18824d5145eed992be788d2f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Mar 12 13:55:55 2020 +0200
            rename vcl::Window::Update to PaintImmediately
        
        Change-Id: I74fc87e984e1f085d2351cbae033e51920608e3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163154
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-02-09  Kurt Nordback  <kurt.nordback@protonmail.com>  [800b767f13d4fe9c7e7fc3271427a7193e17dbb6]

        tdf#50934: Ensure BarOfPie has ScaleData::ShiftedCategoryPosition == false
        
        Change-Id: I86c7ba4df89a1350f544345938a29c210903c06d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [c170d1364be56d91fd16f255ffdc406b8e822732]

        Fix no-PCH build
        
        ... after commit f840a0d54d873d3003f8b624a50557f8c9872477 (lok: calc:
        fix for rendering issues on in place editing, 2024-02-08)
        
        Change-Id: I3c5d2bf72d2f5cfc750cfa6f4d7fc2dae7fb9642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163147
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-09  Rafał Dobrakowski  <dobrakowskirafal@gmail.com>  [3d2134c0116bc563d366f8cf23aae51de1e53938]

        tdf#157664 Drop operator !=, where respective operator == is defined
        
        Found when working on 'tdf#141908'
        
        Change-Id: I33aae153b448c4c6bf0a17810a16c34f8e400774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163104
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b3fa6e6e65031f92d7f13b44f8422fe4aa07e2f9]

        Fix missing includes
        
        ...after f93ae0455c4d515be1ca663725a6e58d64a7e393 "Check bridges with IWYU"
        
        Change-Id: I01ca7b015cb9f4fc1dbff099c52e8240e1517270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163126
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-09  Aron Budea  <aron.budea@collabora.com>  [8318337c3e30075acc72fa8c9d5051c33319fdf5]

        tdf#147132 tdf#154285 basic: Flatten and check param count of Is* fns
        
        Change-Id: I6d27dd49613a5cc26f4244dadc9bdd65361a0475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162657
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-02-09  Oliver Specht  <oliver.specht@cib.de>  [bbe1f37645cf864c7c974d36cf2fe3a73d0c085f]

        Clone Formatting in Impress: Include list attribute
        
        Copies list type and list level from source to target paragraph(s).
        Also switches off lists, if source is not in a list.
        
        Change-Id: I260f1d7d9936476f16c355a3a09204b3fb4592d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163054
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [ad4a06692b05c4312c1c7c8a8ff38cf12422e692]

        tdf#130857 VclBuilder: Move VCL MenuBar specifics to handleMenu()
        
        Move this handling specific to the VCL-implementation
        for the "GtkMenuBar" from `VclBuilder::handleObject`
        to `VclBuilder::handleMenu` which is already very
        specific for those VCL classes.
        
        The idea is to prepare the current `VclBuilder::handleObject`
        for reuse with other welded menu bar implementations
        in the future.
        
        Change-Id: Idfc9974494fb7855f35f098a7bfa4204e7d017c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162920
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [4353b73fb343115ab25d242d11896e153a91a9d3]

        tdf#130857 VclBuilder: Extract helper method for tweaking new child
        
        Extract the post-processing to apply specific tweaks
        to a newly inserted/created `vcl::Window` child from
        `VclBuilder::handleChild` into a new helper method
        `VclBuilder::tweakInsertedChild`.
        
        Change-Id: I6ef813fe899f3dd6e4357c37b8da990ddf7c5155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162919
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-08  Michael Weghorn  <m.weghorn@posteo.de>  [9d928231e71806d4cfe76af2159630bff242c5da]

        tdf#130857 VclBuilder: Extract static methods to new base class
        
        Extract static methods from VclBuilder to a new base class
        BuilderBase that can be reused by other builder implementations
        (like the upcoming one for the Qt-based VCL plugins) in the future.
        
        Change-Id: I719ab5fe1b8a6b36050815204550aae3e3dd25e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162917
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c1991a5fb229161b5f2ad3240afc5b2417abe5c9]

        A better approximation of std::strong_order
        
        (Unfortunately, the environments that don't have std::strong_order typically
        also don't have std::bit_cast, so we need to approximate that, too.)
        
        Change-Id: I0b6344c83bc8227af090cfe68902acd385f682ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163111
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1fd89488d282cad8386af12064876f8ba0ac2956]

        calc null-deref
        
        probably seen after a sheet was deleted
        
        /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f259a642520]
        /opt/collaboraoffice/program/../program/libsclo.so(+0x5b3db8)[0x7f25873b3db8]
        /opt/collaboraoffice/program/../program/libsclo.so(+0x4964a1)[0x7f25872964a1]
        
        this looks most likely:
        
        00000000005b3db0  ScTable::ContainsNotesInRange(ScRange const&) const
        0000000000496440  ScDocument::ContainsNotesInRange(ScRangeList const&) const
        
        Change-Id: Ib019fe8abc18538eee7096e1fe5589e83e4849da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfcd6b25575087366924e39cf352bf3bb3853d6a]

        tdf#157042: Revert "re-apply "optimize ConfigurationProperty::get()""
        
        This reverts commit 3a4a00a51acca8f9b5e775547abff0c4dc9144d7.
        
        <x1sc0> noelgrandin, regarding tdf#157042, the commit was reverted in 24-2 and 7-6 branches but not in master so I was wondering what to do next. There are clear steps on how to reproduce it in comment 27 but it seems the crash is not reproducible with a debug build ( according to comment 37 )
        <noelgrandin> x1sc0, let me try to reproduce that
        <noelgrandin> x1sc0, I cant reproduce, please just revert that on master
        
        Change-Id: I45dcf8f4b422e1a19eaa41ec7614db569b5aac7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163125
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [c2c651ee229a1d153cf515777d018ca6eda55d98]

        lok: calc: missing invalidation of position on undo a drag and drop
        
        When undo/redo a drag and drop of a block of cells cached position was
        not invalidated.
        
        Change-Id: I538815bba46f6759db3b09a583eca9481148cdbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162915
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [25ebd193de97880ecca23afb473f0439dc3fb0ac]

        lok: calc: missing update of sheet geometry data on undo a drag and drop
        
        When undo/redo a drag and drop of a block of cells sheet geometry data
        was not invalidated.
        
        Change-Id: I0579de814ed61357c70a64d0e4ebf862525d3c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162776
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [5361fde2edb6886c85ab359166433bc077b9cafa]

        lok: calc: missing invalidation of cached positions
        
        When executing an external paste position cached by ScPositionHelper
        where not invalidated causing misplaced tile rendering
        
        Change-Id: Ia707e8de5a870f42a6dd303d87694f7ec8f0a105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162775
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163033
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [3c2a849c7fccaff7a9451056f82cbe18f0c146d8]

        lok: calc: rtl - misplaced caret
        
        This is a workaround since text cursor is horizontally a few pixels
        misplaced wrt text in the RTL case.
        This issue is a regression from
        https://gerrit.libreoffice.org/c/core/+/162196
        
        Change-Id: Ia06ee223d01a7df8841bfaca3cad32af896871d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162563
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163032
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Patrick Luby  <plubius@libreoffice.org>  [b0656e6ca668a0719fbcb71b6d46c68093dda470]

        tdf#152524 use dispatch_async() instead of dispatch_sync()
        
        Commit 839cf255e2670fdf8e974af38432aacf63be4e90 used dispatch_sync()
        but, unfortunately, libdispatch will not create a new thread for the
        queue. dispatch_async_and_wait() also doesn't necessary run the queue
        in a separate thread so use dispatch_async() and block and wait for
        the libdispatch task to complete.
        
        Change-Id: I8babad30caa8a188483ddf4f62bae35f5b888dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163122
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-08  Oliver Specht  <oliver.specht@cib.de>  [cbcf22eb8748d59857b29a8792377a10fc6c42b2]

        tdf#159572 select font according to recent settings
        
        selection of a recently inserted special character applies the
        stored font to make sure the character is not inserted wit a
        font that doesn't contain the symbol
        
        Change-Id: Id61bfac3a2ff22dbdae8a5b83f000d3f0c3e992b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163004
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad8b2e46a337028961c3b7635f6c866b51403faf]

        missing dependency in CppunitTest_sw_a11y
        
        Similar to 41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07
        "missing dependency in CppunitTest_test_a11y"
        
        Change-Id: I4dc9d0a5c59dc95e68fd489b3e672ef6ed14355a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59a86aff49ebc838c91355e98df66769b8054adc]

        kit mode is similar to !HAVE_FEATURE_DESKTOP mode wrt menubar
        
        in that it is not used.
        
        SfxDispatcher: :SetMenu_Impl is 3.1% of long-profiling use
        Change-Id: I07bf0f130791795a49835e91ac8b8c5bec749f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [bdd0579b58f7a3b8c1886ea8513618c647c0ad30]

        lok: calc: GridWindow size not updated for some view
        
        The grid window size was updated for the view used for painting and
        not for other views with the same zoom level. In fact the grid window
        size was updated in ScModelObj::paintTile only. Now the required
        updating is performed in lcl_ExtendTiledDimension and
        ScTabView::SetCursor, too.
        In order to get this working it has been neede to revert changes in
        `ScModelObj::setClientVisibleArea` introduced by
        https://gerrit.libreoffice.org/c/core/+/161907
        
        Change-Id: Ie8f585b861b0c916624d8e2f9d828cf23b799672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162406
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Marco Cecchetti  <marco.cecchetti@collabora.com>  [f840a0d54d873d3003f8b624a50557f8c9872477]

        lok: calc: fix for rendering issues on in place editing
        
        Our main problem is how to compute the correct output area for the
        requested tile zoom level. The old solution was using a fine-tuned
        edit rectangle as output area. An edit rectangle is the rectangle
        computed according to the range of rows and columns involved in the
        text editing. Unfortunately in some cases the edit rectangle can be
        enough larger than the output area. For instance that occurs with
        centered text.
        The new proposed solution is able to scale the output area to the
        requested tile zoom level by a few pixels (0 up to 3) offset/size
        error. The hope is to reduce the error in some follow-up patch.
        
        The new solution is also able to perform painting of text edited by
        different views in the correct order. The last painted text is the one
        belonging to the last view where editing occurred.
        SfxViewShell::maEditViewHistory keeps track of the last 10 editing
        events per document.
        
        Change-Id: I8f1035a730cb2b94b0990f3c8eb6445511b94223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162196
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Oliver Specht  <oliver.specht@cib.de>  [8affaf465a2b4c092518406a495796b06a642b1d]

        tdf#43848 fix selection in table with split/merged cells
        
        extends the selection of table cells to reach a more
        rectangular selection area
        Additionally tdf#155670 is taken care of by not showing the
        row selection cursor if row selection is not supported
        
        Change-Id: If31aa1030c91d81bc889d8aaa668e96c5328f03f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162508
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-08  Oliver Specht  <oliver.specht@cib.de>  [6eda6afc90eda8f0a424a5e91a2b00f06bbbb3c5]

        tdf#159478 read field comment in default encoding
        
        If a symbol font is applied inside a field the command string
        was wrongly converted as symbol text. This is fixed by using a
        default RTL_TEXTENCODING_MS_1252 encoding.
        
        Change-Id: I11326ef3c79d6d74c720a2b4ac4987ee6716d912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162844
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-08  Gabor Kelemen  <kelemeng@ubuntu.com>  [f93ae0455c4d515be1ca663725a6e58d64a7e393]

        Check bridges with IWYU
        
        Only the parts tha build on x64 arch
        
        See tdf#42949 for motivation
        
        Change-Id: Ifa3c5107887f5ab7837beee83d9603e8c883a7a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162961
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-02-08  Oliver Specht  <oliver.specht@cib.de>  [d1320c634817e4edb0d76da26178f323c6c675f2]

        tdf#159560 paragraph break should be shown as pilcrow sign
        
        When non-printing characters are switched on at the end of the paragraph
        a pilcrow sign is shown. This is displayed using the font at the end of
        the character. If a symbol font is used that would result in a random symbol
        instead of the pilcrow sign (0x00b6). This is fixed here.
        
        Change-Id: I0d4ae9f439d2e34ca774d4e2cb188e94290808a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162983
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>

2024-02-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec6bf674349fe6bd33b7b01ff83b68c51d68f9c8]

        cid#1559954 rearrange to silence Use after free
        
        try and reassure coverity
        
        Change-Id: I1be16526beaaf2a5c2d08965da6e2811b0e4043d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163086
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Miklos Vajna  <vmiklos@collabora.com>  [f8c95cf93ce9ab8b9b78f3af03411d0cc2e195ba]

        tdf#159483 sc HTML import: handle data-sheets-value attribute for the bool case
        
        Copy a cell with boolean TRUE and FALSE from google docs to Calc, the
        paste result is a TRUE and a FALSE string.
        
        The problem is that boolean is meant to be a float 0 or 1 with custom
        cell format, but we don't build this doc model.
        
        Fix the problem by ParseDataSheetsValue() to write the properties of the
        cell similar to what the normal HTML import would extract from our own
        markup, like:
        
        	<td height="17" align="right" sdval="1" sdnum="1033;0;BOOLEAN">TRUE</td>
        
        This requires passing around both the value and the numbering
        properties, since the cell format just decides it's a boolean, but the
        cell value will decide if it's TRUE or FALSE.
        
        Change-Id: Id558ced56e02bbe24330d82c3998b047dc8febdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163108
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [a381e87d16496d9fee98d9ff49fa2a38cc5c8fb2]

        tdf#159637: fix position of 'Windows Share' entry
        
        Started to happen after
        
        commit b91daea3c1a38883c06cdd63c6eababe1df9e61d
        Author: Michael Stahl <michael.stahl@allotropia.de>
        Date:   Tue Nov 7 13:20:21 2023 +0100
        
            tdf#146386 fpicker,svtools: remove FTP from Remote Files dialog
        
        Change-Id: I6ae78f96c1a1271de8cb2f0f114b92c3c213a068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163115
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-08  Miklos Vajna  <vmiklos@collabora.com>  [5bf2372a7be31e905e28fd81796ccaf5e35f6366]

        CppunitTest_sw_ooxml_theme_export: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this one didn't find any problems.
        
        Change-Id: I50a385fc16ab494d41cb1cf447f33c3bc7980c96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163109
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-08  Michael Stahl  <michael.stahl@allotropia.de>  [6446d3e12440be39e6b55f8749038061a1b240da]

        tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtf
        
          warn:legacy.osl:::writerfilter/source/dmapper/DomainMapper_Impl.cxx:1278: section stack already empty
          DomainMapper_Impl.cxx:9817: void writerfilter::dmapper::DomainMapper_Impl::substream(): Assertion `m_aContextStack.size() == contextSize' failed.
        
        Before substream(), there is one CONTEXT_SECTION, after there is an
        additional CONTEXT_PARAGRPAH.
        
        The first OSL_ENSURE is because RTFDocumentImpl::tableBreak() calls
        endParagraphGroup() but in the substream, startParagraphGroup() hadn't
        been called; fixing this also makes the assert failure go away.
        
        This worked previously because sectBreak() called endParagraphGroup()
        after reading the header substreams, but it seems dubious that a
        paragraph group started in the body should be used in the substream.
        
        (regression from commit 57abad5cf990111fd7de011809d4421dc0550193)
        
        Change-Id: I98864bca03b59099c17080c0a7582de2b77d41e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163096
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-08  Mike Kaganski  <mike.kaganski@collabora.com>  [181f4c5ac9834c15fe0acc4b6e92f064e95ab32c]

        Try harder to use strict weak ordering when sorting
        
        Special LanguageType referring to a system locale can resolve to some
        language tag equal to another one, but they still compared inequal in
        the check at the top of GenericFirst comparator, because only values
        of LanguageType were compared. This could lead to a failed assertion
        later, because both could then be ISO locales, and have no country.
        
        Change-Id: I62dda8ed6f8b1b4c7ab4957b3eecfdef602b91a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163107
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [72056edca078dd010368de15d03321a60c6d5cdd]

        Embind: Allow UNO sequences to be constructed from JS arrays
        
        ...though
        
        > let seq = new Module.uno_Sequence_string(["foo", "bar", "baz"]);
        > // ...
        > delete seq;
        
        is still ugly.
        
        And Embind only allows for overload resolution by number of parameters, not by
        their type, so using the original sequence constructor had to be changed to
        
        > let seq = new Module.uno_Sequence_string(3, Module.uno_Sequence.FromSize);
        > seq.set(0, "foo");
        > seq.set(1, "bar");
        > seq.set(2, "baz");
        > // ...
        > delete seq;
        
        Change-Id: If26ff4a485ba16b65cf24b6fe729d379c733c473
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163097
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [578d9be50413a4bdc809f8b5f58cc177458f8325]

        Embind: Map UNO structs to emscripten::value_object
        
        ...so that it has a nicer integration into JS, at the expense of copying data
        between C++ and JS
        
        Change-Id: I19af55e8db0c374dd7b0f58f74d1af19214175b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163098
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cf616121ed48c8df96104bc35abf3b55b8862043]

        tdf#158975 Add option to not write temp file next to local file
        
        This causes permission issues in some setups.
        See bug report for details.
        
        Change-Id: If97030f95185ab96e21cec968b734fba8a811f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163003
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [68738bd0ac262819b13ea7e11af67ee493b9b3e1]

        Related: tdf#127293 Fix function XLOOKUP binary search corner cases
        
        Fix some binary search (vertical) corner cases in case of XLOOKUP
        where we looking for the first matches.
        
        Change-Id: I6cdc778350989e0802ffc54284fdab9b8a2bece4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162877
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-02-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba3d3c308e944978a6b84b81cdcc1fd18f0c713e]

        add oox to --enable-mergelibs
        
        Change-Id: Ic5158faa07538a688fe609cfd1359ec9ce3b6807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-08  Arnaud VERSINI  <arnaud.versini@pm.me>  [6a831189367528d8d9eea0eb6826af401f756cc6]

        canvas : use more OUString literals
        
        Change-Id: I539e1e6d04299154bfe1ad2cf0362bdf3d96537b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163051
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa6d11771d085803cdb811579f47debc30c4d94b]

        cid#1559945 rearrange to silence Use after free
        
        try and reassure coverity
        
        Change-Id: I91c08b89d3345b9dcc32696a988906e2db81bb53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163087
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [648878703d26cf73d66d9ac9132b0aa7f551ba28]

        double operator < is not a strict weak ordering due to NaN
        
        ...so recent LLVM 19 trunk libc++ in debug mode complained during
        CppunitTest_chart2_export3 about
        
        > ~/llvm/inst/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:59: assertion __comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering
        
        at
        
        > 5   libsystem_c.dylib                   0x0000000183279a40 abort + 180
        > 6   libc++.1.0.dylib                    0x0000000101045d98 _ZNSt3__123__cxx_atomic_notify_oneEPVKv + 0
        > 7   libchartcorelo.dylib                0x00000002f9e05990 _ZNSt3__135__check_strict_weak_ordering_sortedB8de190000IPdNS_6__lessIvvEEEEvT_S4_RT0_ + 732
        > 8   libchartcorelo.dylib                0x00000002f9e055ac _ZNSt3__111__sort_implB8de190000INS_17_ClassicAlgPolicyENS_11__wrap_iterIPdEENS_6__lessIvvEEEEvT0_S7_RT1_ + 172
        > 9   libchartcorelo.dylib                0x00000002f9e054d4 _ZNSt3__14sortB8de190000INS_11__wrap_iterIPdEENS_6__lessIvvEEEEvT_S6_T0_ + 68
        > 10  libchartcorelo.dylib                0x00000002f9e04f94 _ZNSt3__14sortB8de190000INS_11__wrap_iterIPdEEEEvT_S4_ + 64
        > 11  libchartcorelo.dylib                0x00000002f9dfea10 _ZN5chartL22lcl_fillDateCategoriesERKN3com3sun4star3uno9ReferenceINS2_6chart24data13XDataSequenceEEERNSt3__16vectorIdNSB_9allocatorIdEEEEbRNS_10ChartModelE + 1404
        > 12  libchartcorelo.dylib                0x00000002f9dfe28c _ZN5chart26ExplicitCategoriesProvider4initEv + 280
        > 13  libchartcorelo.dylib                0x00000002f9dff0b8 _ZN5chart26ExplicitCategoriesProvider10isDateAxisEv + 28
        > 14  libchartcorelo.dylib                0x00000002f9bcb738 _ZN5chart14VSeriesPlotter9addSeriesENSt3__110unique_ptrINS_11VDataSeriesENS1_14default_deleteIS3_EEEEiii + 200
        > 15  libchartcorelo.dylib                0x00000002f9b951e4 _ZN5chart8BarChart9addSeriesENSt3__110unique_ptrINS_11VDataSeriesENS1_14default_deleteIS3_EEEEiii + 280
        
        Change-Id: Ie0711ca60130759f3daaf8332ab326fa29cb5cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163074
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [56e6d683dba66d4f2f80145064d2bda2ea4b27b1]

        double operator < is not a strict weak ordering due to NaN
        
        ...so recent LLVM 19 trunk libc++ in debug mode complained during
        CppunitTest_chart2_export2 about
        
        > ~/llvm/inst/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:59: assertion __comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering
        
        at
        
        > 5   libsystem_c.dylib                   0x0000000183279a40 abort + 180
        > 6   libc++.1.0.dylib                    0x00000001030f9d98 _ZNSt3__123__cxx_atomic_notify_oneEPVKv + 0
        > 7   libchartcorelo.dylib                0x00000002f817f0ec _ZNSt3__135__check_strict_weak_ordering_sortedB8de190000INS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT_SB_RT0_ + 960
        > 8   libchartcorelo.dylib                0x00000002f817e6cc _ZNSt3__118__stable_sort_implB8de190000INS_17_ClassicAlgPolicyENS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT0_SC_RT1_ + 268
        > 9   libchartcorelo.dylib                0x00000002f8172a90 _ZNSt3__111stable_sortB8de190000INS_11__wrap_iterIPNS_6vectorIdNS_9allocatorIdEEEEEEN5chart12_GLOBAL__N_116lcl_LessXOfPointEEEvT_SB_T0_ + 68
        > 10  libchartcorelo.dylib                0x00000002f8172820 _ZN5chart11VDataSeries15doSortByXValuesEv + 508
        > 11  libchartcorelo.dylib                0x00000002f8064c44 _ZN5chart9AreaChart12createShapesEv + 1528
        > 12  libchartcorelo.dylib                0x00000002f80f2ae0 _ZN5chart9ChartView28impl_createDiagramAndContentERKNS_18CreateShapeParam2DERKN3com3sun4star3awt4SizeE + 4440
        > 13  libchartcorelo.dylib                0x00000002f80f77ac _ZN5chart9ChartView14createShapes2DERKN3com3sun4star3awt4SizeE + 2728
        > 14  libchartcorelo.dylib                0x00000002f80f58ec _ZN5chart9ChartView12createShapesEv + 692
        > 15  libchartcorelo.dylib                0x00000002f80f4598 _ZN5chart9ChartView15impl_updateViewEb + 288
        
        But the introduced use of `std::strong_order(first[0], second[0]) < 0` then
        triggered a false
        
        > lo/core/chart2/source/view/main/VDataSeries.cxx:105:61: error: NullToMemberPointer ValueDependentIsNotNull ZeroLiteral -> nullptr [loplugin:nullptr]
        >   105 |             return std::strong_order(first[0], second[0]) < 0;
        >       |                                                             ^
        
        so needed some hack in loplugin:nullptr.
        
        And old versions of libc++, still used at least on Android, do not have any
        implementations of std::strong_order.  So detect those cases in configure.ac
        (checking for std::strong_order for double, which is what is actually being used
        in the code) and fall back to operator <=> for now, even if that will not
        provide a strict weak ordering and will thus continue to violate the
        requirements of std::sort.
        
        And then our venerable clang-format 5.0.0 would have broken the token `<=>` into
        `<= >`, so exclude include/o3tl/compare.hxx from its mis-treatment.
        
        Change-Id: I7a64a630eb5f560dce59f3ff9d51ca3d1adc70be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163075
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-07  Henry Castro  <hcastro@collabora.com>  [43451b31969db882cd6c36054f43915ffbd8f252]

        tdf#158440: do not extend transparent color
        
        Avoid to extend the area of transparent colors.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ie492e6fea2c3d8b785cfbb96fe7cfc31d87b9996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163021
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [25799a95a02ea9a14adf9c9cb30faa636f09e351]

        tdf#159601: svgio: do not use std::move here
        
        Thanks to Caolán for spotting it in
        https://gerrit.libreoffice.org/c/core/+/163015/comments/0fda53b2_f6d5a0cd
        
        Change-Id: Ifad349a2731009b520d4992a12d4702e3be6ba6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Miklos Vajna  <vmiklos@collabora.com>  [543e52481e764b8e0eea6cf0123a77cf492bdf8e]

        tdf#159483 sc HTML paste: handle data-sheets-value here, too
        
        HTML import into Calc could already create text cells, but HTML paste
        with the same content remained auto-converted to numbers
        unconditionally.
        
        Turns out HTML paste goes via ScHTMLLayoutParser instead of the HTML
        import's ScHTMLQueryParser, so the data-sheets-value was ignored for
        paste.
        
        Fix the problem by extracting the old data-sheets-value handler from
        ScHTMLQueryParser to a separate ParseDataSheetsValue(), and use it also
        in ScHTMLLayoutParser.
        
        For the actual handling, still only text is handled, no other formats
        yet.
        
        Change-Id: I0b2bf4665af331d07624ed42e30a24e31bfca331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163068
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a32def8b519461b35b1e249d71ae9961b04400a]

        tdf#158279 TOC links lost when converting .doc to HTML
        
        regression from
            commit 8ce36e943f0e50970925b2dd77729ef6036b4a49
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sun May 26 15:15:41 2019 +0200
            move some searching inside IDocumentMarkAccess
        
        where I called the wrong method from inside Writer::FindPos_Bkmk
        
        The code was then removed in
            commit 7bad1516c5f2a85b5bae3f49261ac2494cbb7162
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jul 17 05:41:08 2019 +0200
            loplugin:unusedmethods
        
        Change-Id: I3f1e14a1e3ae2dd134738363e6b2679d2a2f418a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163095
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2439016c562044c59b80fb564eb39fe2509a49b3]

        cid#1559963 silence Use after free
        
        by putting aOptions and aOldPattern at same scope
        
        Change-Id: I9c6fecf991b30a0756a3c9d49c13c2ebe64309e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Justin Luth  <justin.luth@collabora.com>  [648c7c0f17125fd77d29be3c0611e1ab92f36b7f]

        tdf#159581 sc: fix multi-sheet ScDocRowHeightUpdater
        
        Apparently it was caching the first sheet's
        row height, and applying it to every other sheet.
        
        AFAICS, the only time this ever ran against multiple sheets
        was during import time, so that is why it wasn't easily noticed
        before 24.2 when XLSX started using it on import.
        
        make CppunitTest_sc_subsequent_filters_test2 \
            CPPUNIT_TEST_NAME=testTdf159581_optimalRowHeight
        
        Change-Id: Ic4e4dd335fa48d02acbc85cfad35feb8eca7597b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163066
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07]

        missing dependency in CppunitTest_test_a11y
        
        found while doing other builds - if the build ordering is very unlucky,
        acc is not built when this runs, the dynamic load fails in the
        accessibility factory fails, and we fall back to using the
        DummyAccessibilityFactory instead of the real one and the test will
        crash.
        
        Change-Id: Ic16fdbe17d50c6be26b5627a4f515c91e1f7f609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [33b7d62281f1f9aaeaa2f68615e90190fe7b5aaf]

        these casts are no longer necessary
        
        Change-Id: Ife51f47d95e286e0fec165882377c31b1a664241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cf11a0dfca5470baea8429c41021527187a5c32d]

        MSVC 2022 Preview: One HAVE_CPP_CONSTEVAL blocker down, one up
        
        While the previously known issue appears to be fixed in VS 2022 Preview 17.9.0
        Preview 5.0, a new one showed up that now caused
        
        > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'rtl::OUStringLiteral<2>'
        > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): note: Invalid aggregate initialization
        > sal/qa/rtl/oustringbuffer/test_oustringbuffer_assign.cxx(63): note: too many initializers
        
        etc.
        
        Change-Id: Ia74a8d6454bb5f15c0af4d3cf29989342f2eef7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163072
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [58db061502241585b12e37618eddc508d41ecf5f]

        cid#1401342 silence Uncaught exception
        
        Change-Id: I63d9cb5dee8900427c86448f2e19c0aa91e753dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163085
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81be82cce8774f6b29af627b738112ae068c2b76]

        cid#1591747 Unsigned compared against 0
        
        and
        
        cid#1591746 Operands don't affect result
        
        Change-Id: I4fbaec75c535ec7db94fc8928020bb93b8ea9a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163084
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Patrick Luby  <plubius@libreoffice.org>  [efe414c4a88fde0e2ee1d4016010f21fbd6d01d7]

        Don't reuse CertificateChooser instances
        
        Reusing the same instance will, in the following case, lead to a
        crash. It appears that the CertificateChooser is getting disposed
        somewhere as mpDialogImpl in its base class ends up being null:
        
        1. Create an empty Writer document and add a digital signature
           in the Digital Signatures dialog
        2. File > Save As the document, check the "Encrypt with GPG key"
           checkbox, press Encrypt, and crash in Dialog::ImplStartExecute()
        
        Change-Id: I9aaa1bd449622e018b502d68c53d397255a1b61a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>

2024-02-07  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [1dc0c8c8304ebbce0a2e05e89a3b5458d88f3630]

        Resolves tdf#159531 - Indentation and spacing for comments
        
        Change-Id: I3ce9dd5d399ce9ff1427de0c97a1227dab996d9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163059
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-02-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d91ab7de467abea6c01c9dd8473f81ac1f29513c]

        external/zxcvbn-c: There is no std::basic_string<int>
        
        ...and at least LLVM 19 trunk libc++ complains about it now since
        <c3668779c13596e223c26fbd49670d18cd638c40> "[libc++] Remove deprecated
        char_traits base template (#72694)" with
        
        > In file included from dict-generate.cpp:25:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/iostream:43:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ios:223:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__locale:24:
        > ~/llvm/inst/bin/../include/c++/v1/string:746:43: error: implicit instantiation of undefined template 'std::char_traits<int>'
        >   746 |   static_assert((is_same<_CharT, typename traits_type::char_type>::value),
        >       |                                           ^
        > dict-generate.cpp:861:18: note: in instantiation of template class 'std::basic_string<int>' requested here
        >   861 |     StringOfInts Chld;
        >       |                  ^
        > ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:23:29: note: template is declared here
        >    23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        >       |                             ^
        
        etc., so use a std::vector<int> instead
        
        Change-Id: I51e8296edf7b16925ff01679e671525256055552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163048
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9772bee2bc95a5b1880286dfb255e026cbd8a1e]

        simplify some Primitive2DContainer construction
        
        Change-Id: Iced31da6891a5d218d63e9b59d48fb2645f39203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163071
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [10cc0f3d2ddaa5d7f6ee18042dacfc67c1be96af]

        simplify some Primitive2DContainer accesses
        
        Change-Id: I217489db2f66049dfb0908f2f2a07a2f585302ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Mike Kaganski  <mike.kaganski@collabora.com>  [093d174f959f8f9524d288c2a593f3a764a8a73c]

        Simplify a bit, and avoid vector copy
        
        Change-Id: I551a29f8451831e2908de8f4abba0f28bad9ef23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163073
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-07  Michael Stahl  <michael.stahl@allotropia.de>  [e9531b792ddf0cfc2db11713b574c5fc7ae09e2c]

        sal: rtlRandomPool: require OS random device, abort if not present
        
        Both rtl_random_createPool() and rtl_random_getBytes() first try to get
        random data from the OS, via /dev/urandom or rand_s() (documented to
        call RtlGenRandom(), see [1]).
        
        In case this does not succeed, there is a fallback to a custom
        implementation of a PRNG of unknown design that has never been
        substantially changed since initial CVS import, and is presumably not
        what would be considered state of the art today, particularly if there's
        no actual entropy available to seed it.
        
        Except for a few miscellaneous usages in URE (presumably to avoid
        dependencies on non-URE libs), rtlRandomPool is almost always used to
        generate material for encryption of documents, which is demanding and
        probably beyond what a pure user-space PRNG implementation without
        entropy from the OS can provide.
        
        So remove the custom PRNG and instead abort() if reading from the OS
        random device fails for whatever reason.
        
        rtl_random_addBytes() becomes a no-op and is therefore deprecated.
        
        Presumably the only kind of environment where random device would be
        unavailable in practice is running in some sort of chroot or container
        that is missing the device or has incorrect permissions on it; better to
        fail hard than to produce encrypted documents of questionable security.
        
        [1] https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/rand-s?view=msvc-170
        
        Change-Id: I3f020c2d11570f8351381d70188ce59bfec9f720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163056
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ae68d59dcb27532d1b0643a37e65f679f0af0f8]

        can std::move these Primitive2DContainer values
        
        Change-Id: Id40fdc3915107575eec734de704a52c5fb3715f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163069
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Patrick Luby  <plubius@libreoffice.org>  [839cf255e2670fdf8e974af38432aacf63be4e90]

        tdf#152524 fork() and exec() in a separate libdispatch queue
        
        This is another attempt to stop the crashing in libdispatch by
        running fork() and exec() within a libdispatch task that will
        run in a sequential queue in a non-main thread.
        
        Change-Id: I3249510c14cc32f7f769b59289fe8380dd22ab68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163036
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-07  Arnaud VERSINI  <arnaud.versini@pm.me>  [fe012b3571e214a37fc0b952295a2235f1296591]

        starmath : move static data to usage location
        
        Change-Id: Id6e500f84ee6d121bdd67e78a8eccfbc10b6ef27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162884
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-07  Miklos Vajna  <vmiklos@collabora.com>  [398996d877112f88dcfb175af9edc15c38d3a020]

        CppunitTest_sw_ooxmllinks: avoid DECLARE_LINKS_EXPORT_TEST completely
        
        No need go via Writer-specific macros.
        
        Change-Id: Ic738ff318f94181b093fd948dcf38057b6c7e189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163067
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-07  Julien Nabet  <serval2412@yahoo.fr>  [c869fb5ea2fa1dbbfa7c17754aeac48ed7f77cc4]

        tdf#159595: Data validation without error check allows to enter wrong data
        
        Change-Id: If5660f462a07ca571e05a44abcb0e378b6de613e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163064
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [467eeda66ee444c846fcd89da1fe064dd06daa9d]

        Fix placement of comments
        
        ...which each pertain to all the preceding code that extracts numbers from
        strings, and where 0a5d4dc25c5521de221f63dbc47c6ba79a51f8fb "elide some OString
        temporaries" had changed that preceding code from stretching over a single to
        stretching over multiple statements each
        
        Change-Id: I315187465d64f620b1ddea8a0cc74ed5f8dc113b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163063
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f5368185661eefcd5e6e6696ac429022e0a983c]

        return string_view from some XmlWalker methods
        
        elides some OString temporaries
        
        Change-Id: Ic07f18eb3c71637593e64128605c1ebfa8e68474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a5d4dc25c5521de221f63dbc47c6ba79a51f8fb]

        elide some OString temporaries
        
        Change-Id: I2ecb6af11c95605c84e935b850fe94a1831a1497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-06  codewithvk  <vivek.javiya@collabora.com>  [b9a46c1ec295fe3227a5adb864c849e55838e89e]

        Async Dialogs for Few Chart Properties
        
        Updated the chart properties dialogs to work asynchronously. The changes affect the following dialogs:
        
        Chart Type: Accessible by double-clicking on a chart to select it, then right-clicking to open the context menu. Selecting 'Chart type...' opens the dialog for modifying chart types.
        
        Insert Axes: Triggered by double-clicking on a chart to select it, then right-clicking and choosing 'Insert/Delete Axes' from the context menu. This dialog allows users to add or remove chart axes.
        
        Insert Titles: Opens when you double-click on a chart, right-click, and select 'Insert Titles...' from the context menu. It's used for adding titles to the chart and its axes.
        
        Insert Trendline: For column charts, you can double-click on a column, right-click, and choose 'Insert trendline..' to open this dialog.
        
        Insert Error Bars: In a column chart, after selecting a column, right-clicking and choosing 'Insert X Error Bars..' or 'Insert Y Error Bars..' opens the dialog for adding error bars to the chart.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: Id7bb8682150f2e3115420d9259c6afd41682641e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162655
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 71a3cfb71dddba8098d74d7bb1dd414e4696914b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162824
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-06  Michael Stahl  <michael.stahl@allotropia.de>  [94f0744648539f1dc4efd42ea55a1e533364ff07]

        writerfilter: move these members to FieldContext
        
        Change-Id: I7449c7e7bb2a54ca0fdfe2bcb67009f76fbb1d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163055
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-06  Michael Stahl  <michael.stahl@allotropia.de>  [e6783f42ae706da76fd347790c15ac3397ce4530]

        writerfilter: move even more members to SubstreamContext
        
        Change-Id: I5d080353075b17d8752ad6509240f77563c4306f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-06  Michael Stahl  <michael.stahl@allotropia.de>  [115569f6895f48b28e8e9e649ffbc72968a3bdeb]

        writerfilter: move yet more members to SubstreamContext
        
        Change-Id: I708375204226fbad502155f4d2efc81ecc206a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163052
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-06  Kurt Nordback  <kurt.nordback@protonmail.com>  [15633d637e6296df218d56130d041660bf0e8317]

        tdf#50934: Add a version comment, and more structure for of-pie
        
        Change-Id: I9d7c25e47a3f4a78360f9b2deffe8650e378866d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156305
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [23293fc6a7c811d624d6d4589195b3d971448890]

        tdf#159594: reuse target for symbols' children
        
        Regression from e7186b49a9a0b24ddc3b1c5384b5d9facb03518c
        "tdf#158445: support viewBox in symbol elements"
        
        Change-Id: Ie2198c47149def17fa3cb612046b61bf32e873bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163046
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-06  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [1b0b11db497f76faf576d28e11860c3502f8deb2]

        tdf#158409: RTF import: use current run props for fields
        
        Fields import was not using current run properties causing
        fallback to used style or default style what is wrong for RTF.
        
        Change-Id: I0189c6122b703a23ff910ee38da78aa05ac4d9f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160387
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2024-02-06  Michael Stahl  <michael.stahl@allotropia.de>  [4b2e61cb8b5429e08f43c5a70eaa1dd27c40ddab]

        writerfilter: move more members to SubstreamContext
        
        m_bIgnoreNextTab can be removed altogether, it is only set to true in
        one place and immediately checked and reset in the next 2 statements.
        
        Don't move m_bHasFtnSep, somehow breaks lots of tests.
        
        Change-Id: I24bcb3ced839d2c87a367e8a1bcd7664361f9975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163042
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [23abe10fb2d058dc25acd31ea089123c3cbe515c]

        flatten some drawinglayer code
        
        Change-Id: I2d7fd0da565e4cddb37ae2053c686d8e6befcf83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163039
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-06  Gabor Kelemen  <kelemeng@gnome.hu>  [bca870566c65e22d9665b9f7dcb2144ca0f59a8a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 84b2341aeb073ecc7d29228d9ddedc1ee0677a32
          - tdf#159568 Fix link to extensions page -> Dictionaries category
            
            Change-Id: I729264913b54c797193bb6b9c238c8d72a94608c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163045
            Tested-by: Jenkins
            Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
            
2024-02-06  Miklos Vajna  <vmiklos@collabora.com>  [8593e78e99ab9cf7e3e30db31a14a7fb016afea8]

        sw: document connection between SwTextBlocks and autotext
        
        See e.g. commit 87670fa998a26ab059e40bbe8f5e0acf0ad6ea04 (DOCX autotext
        import: speed up handling of large amount of blocks, 2019-03-14).
        
        Change-Id: I3798f55c19de6c35fcf515b3a5c785da55f0d884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163038
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f289fe3dca487c45417f7b40d51a4830f3369fb1]

        Prevent JS from creating css::uno::Sequence of negative size
        
        Change-Id: I2449723162744e9ce3cb3e3172ce8acae0adf4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162998
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-05  Jim Raykowski  <raykowj@gmail.com>  [6b6849107562b258aa8858e94ff3c07160f07062]

        tdf#157117 sd: fix page switched to after last page is deleted
        
        Makes the new last page in the document be the page switched to after a
        page delete of the last page in the document. Before the patch, when
        the draw view has focus (not the slide sorter), deleting the last page
        in the document results in a switch to the first page.
        
        Change-Id: I8d3904e85254228e01d423f15312981d11fc9755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159963
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-02-05  Rafael Lima  <rafael.palma.lima@gmail.com>  [263e431f76447c6933343a4a07c9ed6d193af867]

        tdf#159476 Remove experimental status from Basic IDE entry in Options dialog
        
        Change-Id: Icbc9d131d90e639490f6dfd896565c994a17b172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162829
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a9802e255a8d56b1ef9f5c071ac8cf9598db5409]

        Fix typos
        
        Change-Id: Ia2a3100f07b45dba214a7f534d6adb54b2ceaa89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163000
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-05  Tuukka Orava  <tuukka.orava@outlook.com>  [ef6212158d8308d60d3edb6c87117958758436e2]

        tdf#143148 Use pragma once in vcl/inc/graphic
        
        Change-Id: Id88d0c64f02d9a0ca111de3d08e3d542dfba2a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162997
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [f0d6b3e727448abb4428587bdf9b9c839b28e6f4]

        tdf#159566: match 'central' dominant-baseline to 'middle'
        
        Inkscape also does it the same way
        
        Change-Id: I3e1cea091e7314886bbc9135c55698892239bec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163006
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-05  Michael Stahl  <michael.stahl@allotropia.de>  [99055ae98ef1fe67b8db4a8c3167a8acaeaac02f]

        tdf#123968 sw: fix assert on importing ooo62823-1.sxw
        
        svl/source/items/itemset.cxx:662: const SfxPoolItem* implCreateItemEntry(SfxItemPool&, const SfxPoolItem*, bool): Assertion `pSource->Which() == nWhich && "ITEM: Clone of Item did NOT copy/set WhichID (!)"' failed.
        
        XMLVariableInputFieldImportContext::PrepareField() first sets "Input"
        and then "SubType" property.
        
        Apparently i missed that *both* of these are mutable in the API, and
        both together determine whether the field is a RES_TXTATR_INPUTFIELD or
        RES_TXTATR_FIELD.
        
        So call SwXTextField::TransmuteLeadToInputField() also when the
        "SubType" is set, and adapt it to toggling 2 different things.
        
        Hmm... actually this will change these fields to be inline editable
        after ODF import, which was the intention all along.
        
        It turns out that there is even a unit test testTdf123968 for this; it
        works in the usual case, but in this case the input field is in a
        header, so in styles.xml, and the styles.xml is imported before
        content.xml and does not contain the variable-decls element, so the
        variable field type has the GSE_EXPR subtype (default?), and setting the
        "Input" property doesn't transmute it.
        
        (regression from commit 742baabbe4d077e1ba913a7989300908f4637ac7)
        
        Change-Id: Ib5757cda32287e51651f05f5b19e82d7be0431e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162941
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ffb6133176d5bc1824b15893b2cf1a80aea6aa02]

        tdf#108037 speed up exporting large pdf (2)
        
        reduce the number of allocations we need to do for OStringBuffer
        
        Shaves 2% off the convert time.
        
        Change-Id: I0852c870b3c9e1941213f80f359d00cb8ee391df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bacabc61f0b9b21523d7e77371cf29228a9a394]

        add a test to detect incorrect text color in dark mode chart rendering
        
        Change-Id: I89e238dab58ffe36021520ad0fdce38e31a616e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162868
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit a9044a4b1de467519bec798500f3bf3d0d154f85)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162979
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ee4ea5c098d4e97bd5b3aa5998f6885da0d74fe]

        reduce unnecessary OString temporaries
        
        spotted while profiling tdf#108037
        
        Change-Id: I66afa79d7da94c1d3c7d1695ce9c5cf902e1429e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c58f42c1bd2ec1b24f02a27c952e88d43ee07beb]

        Tabs to spaces
        
        Change-Id: I794548f4a5c18c3cbf100940adf3ec5095293ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162996
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5f9ce732300d3301b574b569fe331e8a93057e73]

        Fix typo in comment
        
        Also relayout the text
        
        Change-Id: Id774c5a5089e1c031ae705e6b23281e882b6739f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162995
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c37b0a694a32537ed4c216106b5c98a79222f3c9]

        Allow to build against a non-EMSDK Emscripten installation built from source
        
        The EMSDK variable was only used to find the Emscripten version.h file, but for
        a build from source there would be no value it could be set to in order to find
        the installation's cache/sysroot/include/emscripten/version.h at the
        $EMSDK/upstream/emscripten/cache/sysroot/include/emscripten/version.h location
        where configure.ac wants to look for it.  (And using the configure.ac code that
        does not use version.h at all wouldn't work either, as the only
        EMSCRIPTEN_DEFINES found with at least a contemporary emcc would be just an
        unhelpful __EMSCRIPTEN__=1, but no version information.)  So allow to explicitly
        set EMSCRIPTEN_VERSION_H in autogen.input to use that for the version check.
        
        Change-Id: Ic64ecfaefb3b5830f82e577b100a6e7becc73953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162994
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [566d05ead1659e2e28f69273fd4969556b805ab3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a4f8a947b7b84ee6b957e1f20b80adae2bf1026d
          - fix some command paths and names
            
            Change-Id: Idb0b5c7db4f948257f50f48f28ebc0d67199fb35
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162977
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf4514d4e7400480174f28dcf502f5b59fe7b085]

        Resolves: tdf#156352 disable sorting while adding rows
        
        looks like the new row gets sorted immediately when added as an empty
        row into the first row, so accessing it by index later to set it text/id
        get an unexpected result.
        
        pause sorting while inserting the entries and enable it again when
        finished for the easiest fix.
        
        Change-Id: Ib028b193afbf2b9026841b19419e012b70448e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162993
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-05  Miklos Vajna  <vmiklos@collabora.com>  [d918beda2ab42668014b0dd42996b6ccc97e8c3a]

        tdf#158814 DOCX import: fix unwanted header with type="first" & no titlePg
        
        The bugdoc had no header in Word, but had one in Writer, since commit
        17e51f427b3f0cec74ac8e0a1b3f51189006ae6f (DOCX import: first page header
        should always set default headers as well, 2014-11-21).
        
        The code has changed a log in the meantime, today we import first page
        headers and left/right page headers as a single page style, but still
        code was missing to detect the case when <w:headerReference
        w:type="first"> was not followed by <w:titlePg>, which is an indicator
        that the first page header/footer should be used.
        
        Fix the problem by new flags to SectionPropertyMap to track if we ever
        seen a first/left/right header. This allows making an informed decision
        in SectionPropertyMap::setHeaderFooterProperties(): if the header is on,
        but we effectively don't have none of a first, left or right header,
        then it's time to turn it off, similar to what the DOC import does.
        
        Note that this only changes behavior for headers, but if there is a
        practical need, then the same could be also done for footers as well.
        Instead of adding a new test, notice that testTdf112694 in
        CppunitTest_sw_core_header_footer explicitly tests this case: a first
        header which is not a title page. So change that testcase to assert the
        behavior now matches Word and drop the FIXME.
        
        Change-Id: Ib604e786d7a5a197d4b562533326206697de882a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162992
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-05  Noel Grandin  <noelgrandin@gmail.com>  [1ae7a81e542c9b072e519d0ea0d4773ed26ca251]

        tdf#108037 Reduce time and memory consumed exporting to PDF
        
        by avoiding making multiple copies of the Primitive2D container
        that we pass to TransformPrimitive2D.
        Instead, make TransformPrimitive2D store its children using a
        GroupPrimitive2D, which means we can share the GroupPrimitive2D
        among all the TransformPrimitive2D instances we create.
        
        Change-Id: I8a4398f9db6a6ab013ee24ad53836975fba6f3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-05  Miklos Vajna  <vmiklos@collabora.com>  [4259b451c26eec782eb15c7603f6fbb06fc3787e]

        svx: prefix members of XDashEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: I9506823a9d9f3b11496ff6211943b72a81a77165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162981
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e49f4e17b162c72875a73e5ec85babb1fd5a1ef7]

        Allow qmake, moc to be explicitly set in autogen.input
        
        (I need that for a wasm cross-build with Qt6, where MOC6 needs to explicitly be
        set to the build-time moc tool, not a non-existing anyway host moc tool.)
        
        Change-Id: I4a779ccc1b12b80a2e67bbaa5cd7ec04861a5d43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162984
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-05  Mike Kaganski  <mike.kaganski@collabora.com>  [bc5e5cb08a91a5daf0e9a5e78cf304b52e1ad369]

        tdf#148645: add unit test
        
        This introduces CppunitTest_scaddins_analysis.
        
        Change-Id: I4e6d4215f05bc68852ecac12082e8398cca5be5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162982
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-05  Patrick Luby  <plubius@libreoffice.org>  [538f7b45c0c2c08124e9ea51a0947504f142a4f1]

        tdf#147291 add more default certificate manager application for macOS
        
        Add the following applications to the macOS GUI servers list:
        
        - Trusted Key Manager - CertEurope
        - SCInterface Manager and SmartCard tools
        
        Change-Id: Iec78171c6e82f0a072f5f06b79606560a8cc03cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162942
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-05  Heiko Becker  <mail@heiko-becker.de>  [4bc05eb49c064dcc019c70e564d0d5edbef67124]

        sal: Re-add missing includes
        
        They were removed as unused in [1], but it turn out that's not entirely
        accurate, at least if LIBO_CIPHER_OPENSSL_BACKEND is defined. assert(),
        o3tl::..., std::numeric_limits<T> and std::memcpy are all used inside
        that block.
        
        [1] 2e71c439057c8d31b6af191ef38607600cb996f0
        
        Change-Id: I2805dc4edf1d05bec5ec203772af73dd93da12bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162967
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ef1e14db395b7850957534246b2960356b1b2bb7]

        ofz#66471 Direct-leak
        
        when a cairo surface gets into an error state typically none of the
        functions do anything any more, so this leak is because of an invalid
        uninvertable matrix which comes from a 0 x denom in the svm MapMode,
        so detect the problem there at the outer boundary.
        
        Change-Id: Idedc29b48f2be3853064b4369727bc91082c5a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162980
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-05  Luv Sharma  <luvsharma.del@gmail.com>  [5986ab58db89ee73dc1bc30a7f3800ccb598a3b6]

        tdf#148645  getDec2Hex now takes  integer 'places' value
        
        Change-Id: I1491980d5ba693e3a0d899a13aa9615d84468e7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162860
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [070b4ddda4983773e8a989a116924bee0f651f25]

        tdf#159428 Prefer heading over bookmarks in Navigator
        
        When a bookmark is in a heading, highlighting the heading
        is more important than highlighting the bookmark.
        
        Change-Id: I6348e42b14ece226a25961bd3145193645972e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162694
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-05  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [ab320f4e11c70b50e5beddf12ad925f192941d9a]

        tdf#158924 Handle multi-clicks for navigation bar
        
        Added handling for navigation bar buttons when many quick
        clicks have been made. To do this, after processing the first click,
        the number of clicks in the series is stored in a new variable.
        Until the entire series of clicks has been processed, the slide
        switch will not occur.
        
        Change-Id: I8f4416a0c7928bb78609be8ff52252782c37f5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161625
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d381b54d1c598c181b4a21a8bf0db86eb4668d1]

        cid#1591491 Big parameter passed by value
        
        Change-Id: Ia08747a92018355809970b0dc85b1dc258f38eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [409746b90af5ad9b07f1a7df1005279f8dede1ba]

        cid#1591484 Dereference after null check
        
        Change-Id: Id3ea18587cf3bccd808de48af6cd4a502d67cef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162973
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c50e73334444194c1024f834ca0e0f5ff666d40]

        cid#1591494 Dereference null return value
        
        Change-Id: I578093091f70431bd46de55b56b7c1ebab0cd75b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162972
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f9dcaeb021bbcad0d152e6be1f4d2719700545ce]

        cid#1591496 Dereference null return value
        
        Change-Id: Ic26b910cc9243607641a19ceb2988ed3011939ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162971
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c674f8d9fe5d6cda417bfdd71609ca6743595124]

        just call pSFly->Lower() once
        
        Change-Id: I35c11a41503ee6f23c8692fa75d0fe4a7e7a323a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [371bcc491767b68cc4a2cd4b1633e1b9b9c58c91]

        cid#1591487 Dereference after null check
        
        Change-Id: I18ec37320fe635af8559718a0f16c25a837197ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162966
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Mike Kaganski  <mike.kaganski@collabora.com>  [b0f9cb252d9dbb932a368a81871d0ba7c396dab8]

        Use constexpr instead of const
        
        See commit bf2ae3c25a5da3a323c06fd5f949660ee64f0fa6 for rationale.
        
        Change-Id: I456bc7c7124a277b34b6334d16090607e14075e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162969
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-04  Noel Grandin  <noelgrandin@gmail.com>  [14f6b169b5d04f4bfcb28bf7e10fad21dc6f191c]

        Move mnTransparenceForShadow down to SdrCellPrimitive2D
        
        where it belongs. It appears it was only put into
        BufferedDecompositionPrimitive2D so that it can be accessed
        by Primitive2DXmlDump, so fix that by creating an extended version
        of the dumper for use in svx.
        
        Change-Id: Idb0b849c4fa538bbede882e48c2d090669c2325a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32b814355b50e2f271ce46058990049bc7098266]

        use ViewShell DOCCOLOR when available for charts
        
        Change-Id: I200538bd94d60867d84b7dc37811094b65dd9aa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c711535b98da9c47adf9444d7133b63dadc6384f]

        cid#1591492 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1591489 COPY_INSTEAD_OF_MOVE
        cid#1591488 COPY_INSTEAD_OF_MOVE
        cid#1591485 COPY_INSTEAD_OF_MOVE
        cid#1591483 COPY_INSTEAD_OF_MOVE
        cid#1591482 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I944ddb05042fbfe53f73eac2c16f3263cf3a4594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162955
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5271fc94e706ba64d0c9c40a963d043e0cfa0468]

        cid#1591481 Dereference after null check
        
        Change-Id: I3c2c94968073e557863f0e1fddf1dea5649a94f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162960
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [378ebc64958e3172033b1dd417361a5673cf82bf]

        SwLayoutFrame::IsAnLower returns false if passed nullptr
        
        so this is equivalent to what was already here
        
        and make this block and the previous block more uniform
        
        {
            const SwFrame *pUp = pAssumed;
            while ( pUp )
            {
                if (!pUp->IsInDtor())
                {
                    if (pUp == this)
                        return true;
                    if (pUp->IsFlyFrame())
                        pUp = static_cast<const
        SwFlyFrame*>(pUp)->GetAnchorFrame();
                    else
                        pUp = pUp->GetUpper();
                }
                else
                    break;
            }
            return false;
        }
        
        Change-Id: I763722f7b33a3d8148d46c9d30386c6c3f8663ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162959
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3c033146b1ef61676de8379c56ea538b1cbdf826]

        cid#1455212 Uncaught exception
        
        and
        
        cid#1401342 Uncaught exception
        
        Change-Id: I77c2303ceb25301d85bfc9f8f6dc9eb8f4c4494a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162945
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [990b9d7acce2893d355a213b9a7855b2fb6f7b90]

        cid#1591493 Unchecked return value
        
        Change-Id: I0d39e142d3fd4100f68f1fff3f9d305aa1b59728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162954
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d842ba65ec0c4e17a951570b0464afbfeac24dce]

        cid#1591495 Resource leak
        
        since:
        
        commit 1d7ce421480d9170316533de03feb8d04eb5c767
        Date:   Tue Jan 30 17:15:07 2024 +0600
        
            tdf#159438: when there's no frame, close previous bookmark first
        
        Change-Id: I81a28429041047afbe6f4cea327e6f19e3805cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1478c593b505255c859faa893279483decb5a5bb]

        cid#1591486 Logically dead code
        
        since:
        
        commit 93c4bfc96acf7f387120ff05883068d358a608c1
        Date:   Thu Jan 25 10:29:47 2024 +0200
        
            make writer databases dialog async
        
        Change-Id: Ic67a7b5313e1dfad9c34fc3bf05ca808af29ceba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-04  Venetia  <venetiarosita@gmail.com>  [a6db6af4822d6aea4b0629c9fe660a758b7fcba1]

        tdf#119931 Fix accessibility warnings in sw/uiconfig
        
        In files linenumbering.ui and optfonttabpage.ui the labels 'intervallines',
        'lines' and 'font_label' respectively are there for visual coherence but do
        not provide any meaning. Therefore, moved them from suppression to false file
        
        Change-Id: Ied1001a8b445574e4ceca92c4fdf45a4e5a8ca97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161807
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-02-04  Michael Weghorn  <m.weghorn@posteo.de>  [a54abf77c40c59e5a4d8a70e1b129b1e420265a3]

        tdf#130857 qt weld: Support asnyc running of msg dialogs
        
        Implement methods required to run a welded Qt message dialog
        asynchronously: `QtInstanceMessageDialog::runAsync` and
        `QtInstanceMessageDialog::response`.
        
        Run the dialog asynchronously using `QDialog::open` and
        connect to the `QDialog::finished` signal to be notified
        when the dialog gets closed.
        
        Similar to how the gtk-based implementation, use local
        variables for the `std::shared_ptr`s and reset the members
        right away, not only at the end of the slot, since resetting
        the relevant one set in the corresponding `runAsync` overload
        will result in the object getting deallocated, thus the members
        can no longer be accessed safely.
        
        Take the solar mutex before calling the callback function
        as that seems to be expected (e.g. otherwise triggers an assert
        for the below example where the callback functions
        modifies VCL widgets).
        
        With this in place, running welded Qt message dialogs
        asynchronously works instead of not showing up at all, e.g.
        
        1) start Writer with qt6 VCL plugin and without
           `SAL_VCL_QT_NO_WELDED_WIDGETS` set
        2) open "File" -> "Properties" -> "Security"
        3) click the "Protect..." button
        4) enter 2 different passwords and press "OK" button
        
        Change-Id: Ic1b1bfc7d89c1be8a9f9dee59bc86cf3da37a280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162948
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-04  Luv Sharma  <luvsharma.del@gmail.com>  [0a83e6dfaff35bf8ee74d6d7f49bb1b2df0958c8]

        tdf#45904 Remove old SwXBodyText Java test
        
        Change-Id: I3dcef5782e81340e8a3ee2433246ddd23560dd5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162943
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-02-04  Mike Kaganski  <mike.kaganski@collabora.com>  [bf2ae3c25a5da3a323c06fd5f949660ee64f0fa6]

        Use constexpr instead of const
        
        A local const static still needs a constructor the first time, and
        the short atomic checks if it is initialized every time the control
        flow crosses it.
        
        A constexpr static does not need all of that.
        
        Change-Id: I9c4cc082c7dfafcf6197dbe5a697ab27fdef2711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162952
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-04  Mike Kaganski  <mike.kaganski@collabora.com>  [6e540ab56e397d645b300d6cfbadc5c11a1e8151]

        Make sure to use strict weak ordering when sorting
        
        See https://gerrit.libreoffice.org/c/core/+/152676/2#message-ea10fe33b46fee581d47c04d04291a59049d4ac3
        
        The complexity of intended sort requires to split the languages by
        language groups first, and use the "generic first" comparison only
        inside groups.
        
        As the result, e.g. Aranese and Occitan are grouped together.
        
        Change-Id: Ibf11e72c4dfb7876eecea7f3f302c313d153bcbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [453049b93e82bed84ac08eea35930b8881a26672]

        First-class Embind JS support for OUString
        
        Change-Id: Ic178737da802e17f87d0b5b09004a847b0fe91be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162956
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [de1d9d8302e600e6cc3964f55790d954fd493df9]

        natstepfilter: skip std::vector::operator[]
        
        Change-Id: I6605b4bc74ba186e06693ef5346e7b7fd0c0b9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162938
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d5c0a94539d2196c7d0dd9f52660ba9e58d31b8]

        loplugin:unnecessarygetstr fix false +
        
        spotted in https://gerrit.libreoffice.org/c/core/+/162869
        
        Change-Id: I87d9fdcfed5282f0e94fc8aa95a46054883fdd79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b23aec2266da4cc2b3f4a34037d3a073a36d3d83]

        tdf#159461 deadlock in Dialog "XML Filter Settings"
        
        revert
            commit 15405dc68b2e88b53585578567da13e3e99962db
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 20 15:43:41 2023 +0200
            osl::Mutex->std::mutex in FilterCache
        
        There is much recursive behaviour going on here,
        via the configmgr and the listeners that FilterCache
        has.
        
        Change-Id: Ice003404dffad9e5e63bcff30c2ceede4f52cab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-02  Michael Stahl  <michael.stahl@allotropia.de>  [86ad08f9d25110e91e92a0badf6de75e785b3644]

        writerfilter: fix missing paragraph break on tdf136445-1.rtf
        
        This causes an assert:
        crossrefbookmark.cxx:44: sw::mark::CrossRefBookmark::CrossRefBookmark(): Assertion `IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark(rPaM) && "<CrossRefBookmark::CrossRefBookmark(..)>" "- creation of cross-reference bookmark with an illegal PaM that does not expand over exactly one whole paragraph."' failed.
        
        The problem is that there is an annotation at the end of a paragraph,
        and reading the annotation changes various members of DomainMapper_Impl,
        in particular m_bParaSectpr and m_bParaChanged, causing "bRemove" in
        DomainMapper::lcl_utext() to be erroneously true, removing the just
        inserted paragraph break again.
        
        Move all flags that are evaluated for bRemove to SubstreamContext.
        
        This causes one test failure, but it turns out that the new result is
        the same as in Word 2013.
        
          Test name: (anonymous namespace)::testTdf108947::TestBody
          equality assertion failed
          - Expected: Header Page 2 ?
          - Actual  :
          Header Page 2 ?
        
        (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b)
        
        Change-Id: I44a7a8928ab04c600d4d3c43bc4e4deeafe57d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162932
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-02  Matt K  <mattkse@gmail.com>  [05889c7fd814187aec3d88c056ece0cc33736868]

        tdf#149499 Prevent crash upon inserting page break and undoing
        
        The problem is the code uses objects that have been destructed or
        don't exist likely because of destruction, thus causing crashes.
        The fix is to check for the existence of these objects or whether
        they have been destructed prior to using them.
        
        Also removed some asserts that were firing that don't appear to be
        valid.
        
        A crash happens when executing an assert in an undo scenario because the SwFlowFrame on the SwFlowFrame::GetFollow call stack frame is an "Exception thrown: read access violation. this was 0xFFFFFFFFFFFFFFEF."
        
        >	swlo.dll!SwFlowFrame::GetFollow() Line 169	C++
         	swlo.dll!SwFlowFrame::IsAnFollow(const SwFlowFrame * pAssumed) Line 757	C++
         	swlo.dll!SwFootnoteFrame::GetRef() Line 2947	C++
         	swlo.dll!SwFootnoteBossFrame::FindFirstFootnote() Line 1114	C++
         	swlo.dll!SwFootnoteBossFrame::InsertFootnote(SwFootnoteFrame * pNew) Line 1271	C++
         	swlo.dll!SwFootnoteBossFrame::AppendFootnote(SwContentFrame * pRef, SwTextFootnote * pAttr) Line 1665	C++
         	swlo.dll!SwTextFrame::ConnectFootnote(SwTextFootnote * pFootnote, const __int64 nDeadLine) Line 692	C++
         	swlo.dll!SwTextFormatter::NewFootnotePortion(SwTextFormatInfo & rInf, SwTextAttr * pHint) Line 840	C++
         	swlo.dll!SwTextFormatter::NewExtraPortion(SwTextFormatInfo & rInf) Line 283	C++
         	swlo.dll!SwTextFormatter::NewPortion(SwTextFormatInfo & rInf, std::optional<o3tl::strong_int<long,Tag_TextFrameIndex>> oMovedFlyIndex) Line 1738	C++
         	swlo.dll!SwTextFormatter::BuildPortions(SwTextFormatInfo & rInf) Line 773	C++
         	swlo.dll!SwTextFormatter::FormatLine(o3tl::strong_int<long,Tag_TextFrameIndex> nStartPos) Line 1955	C++
        
        Another callstack observed for an assert (other version of SwFootnoteFrame::GetRef) in a undo/redo scenario was:
        
         	ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28	C++
         	ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154	C++
         	ucrtbased.dll!abort() Line 61	C++
         	ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187	C++
         	ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420	C++
         	ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444	C++
        >	swlo.dll!SwFootnoteFrame::GetRef() Line 2938	C++
         	swlo.dll!SwTextFrameBreak::IsInside(const SwTextMargin & rLine) Line 172	C++
         	swlo.dll!SwTextFrameBreak::IsBreakNow(SwTextMargin & rLine) Line 230	C++
         	swlo.dll!SwTextFrame::FormatAdjust(SwTextFormatter & rLine, WidowsAndOrphans & rFrameBreak, o3tl::strong_int<long,Tag_TextFrameIndex> nStrLen, const bool bDummy) Line 1101	C++
         	swlo.dll!SwTextFrame::Format_(SwTextFormatter & rLine, SwTextFormatInfo & rInf, const bool bAdjust) Line 1757	C++
         	swlo.dll!SwTextFrame::FormatImpl(OutputDevice * pRenderContext, SwParaPortion * pPara, std::vector<SwAnchoredObject *,std::allocator<SwAnchoredObject *>> & rIntersectingObjs) Line 1865	C++
         	swlo.dll!SwTextFrame::Format(OutputDevice * pRenderContext, const SwBorderAttrs * __formal) Line 2068	C++
         	swlo.dll!SwContentFrame::MakeAll(OutputDevice * __formal) Line 1532	C++
         	swlo.dll!SwFrame::PrepareMake(OutputDevice * pRenderContext) Line 388	C++
         	swlo.dll!SwFrame::Calc(OutputDevice * pRenderContext) Line 1814	C++
         	swlo.dll!SwFootnoteBossFrame::AppendFootnote(SwContentFrame * pRef, SwTextFootnote * pAttr) Line 1687	C++
         	swlo.dll!SwTextFrame::ConnectFootnote(SwTextFootnote * pFootnote, const __int64 nDeadLine) Line 692	C++
         	swlo.dll!SwTextFormatter::NewFootnotePortion(SwTextFormatInfo & rInf, SwTextAttr * pHint) Line 840	C++
         	swlo.dll!SwTextFormatter::NewExtraPortion(SwTextFormatInfo & rInf) Line 283	C++
         	swlo.dll!SwTextFormatter::NewPortion(SwTextFormatInfo & rInf, std::optional<o3tl::strong_int<long,Tag_TextFrameIndex>> oMovedFlyIndex) Line 1738	C++
         	swlo.dll!SwTextFormatter::BuildPortions(SwTextFormatInfo & rInf) Line 773	C++
         	swlo.dll!SwTextFormatter::FormatLine(o3tl::strong_int<long,Tag_TextFrameIndex> nStartPos) Line 1955	C++
        
        The assert in sw\source\core\inc\drawfont.hxx happened when adding some text in the footnotes and then undoing.  Here is the callstack:
        
         	ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28	C++
         	ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154	C++
         	ucrtbased.dll!abort() Line 61	C++
         	ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187	C++
         	ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420	C++
         	ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444	C++
        >	swlo.dll!SwDrawTextInfo::SwDrawTextInfo(const SwViewShell * pSh, OutputDevice & rOut, const SwScriptInfo * pSI, const rtl::OUString & rText, const o3tl::strong_int<long,Tag_TextFrameIndex> nIdx, const o3tl::strong_int<long,Tag_TextFrameIndex> nLen, unsigned short nWidth, bool bBullet, const vcl::text::TextLayoutCache * const pCachedVclData) Line 123	C++
         	swlo.dll!SwTextSizeInfo::GetTextSize() Line 422	C++
         	swlo.dll!SwTextPortion::GetTextSize(const SwTextSizeInfo & rInf) Line 544	C++
         	swlo.dll!SwTextCursor::GetCharRect_(SwRect * pOrig, o3tl::strong_int<long,Tag_TextFrameIndex> nOfst, SwCursorMoveState * pCMS) Line 943	C++
         	swlo.dll!SwTextCursor::GetCharRect(SwRect * pOrig, o3tl::strong_int<long,Tag_TextFrameIndex> nOfst, SwCursorMoveState * pCMS, const __int64 nMax) Line 1270	C++
         	swlo.dll!SwTextFrame::GetCharRect(SwRect & rOrig, const SwPosition & rPos, SwCursorMoveState * pCMS, bool bAllowFarAway) Line 285	C++
         	swlo.dll!SwCursorShell::UpdateCursor(unsigned short eFlags, bool bIdleEnd) Line 2271	C++
         	swlo.dll!SwCursorShell::EndAction(const bool bIdleEnd) Line 283	C++
         	swlo.dll!SwEditShell::EndAllAction() Line 102	C++
         	swlo.dll!SwWrtShell::Do(SwWrtShell::DoType eDoType, unsigned short nCnt, unsigned short nOffset) Line 60	C++
         	swlo.dll!SwBaseShell::ExecUndo(SfxRequest & rReq) Line 657	C++
        
        Another assert in sw\source\core\inc\drawfont.hxx happened when adding text to footnotes and undoing twice.  Callstack:
        
         	ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28	C++
         	ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154	C++
         	ucrtbased.dll!abort() Line 61	C++
         	ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187	C++
         	ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420	C++
         	ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444	C++
        >	swlo.dll!SwDrawTextInfo::SetLen(const o3tl::strong_int<long,Tag_TextFrameIndex> nNew) Line 493	C++
         	swlo.dll!SwSubFont::GetTextSize_(SwDrawTextInfo & rInf) Line 1006	C++
         	swlo.dll!SwFont::GetTextSize_(SwDrawTextInfo & rInf) Line 314	C++
         	swlo.dll!SwTextSizeInfo::GetTextSize() Line 428	C++
         	swlo.dll!SwTextPortion::GetTextSize(const SwTextSizeInfo & rInf) Line 544	C++
         	swlo.dll!SwTextCursor::GetCharRect_(SwRect * pOrig, o3tl::strong_int<long,Tag_TextFrameIndex> nOfst, SwCursorMoveState * pCMS) Line 943	C++
         	swlo.dll!SwTextCursor::GetCharRect(SwRect * pOrig, o3tl::strong_int<long,Tag_TextFrameIndex> nOfst, SwCursorMoveState * pCMS, const __int64 nMax) Line 1270	C++
         	swlo.dll!SwTextFrame::GetCharRect(SwRect & rOrig, const SwPosition & rPos, SwCursorMoveState * pCMS, bool bAllowFarAway) Line 285	C++
         	swlo.dll!SwCursorShell::UpdateCursor(unsigned short eFlags, bool bIdleEnd) Line 2271	C++
         	swlo.dll!SwCursorShell::EndAction(const bool bIdleEnd) Line 283	C++
         	swlo.dll!SwEditShell::EndAllAction() Line 102	C++
         	swlo.dll!SwWrtShell::Do(SwWrtShell::DoType eDoType, unsigned short nCnt, unsigned short nOffset) Line 60	C++
         	swlo.dll!SwBaseShell::ExecUndo(SfxRequest & rReq) Line 657	C++
        
        I wasn't able to consistently repro the assert in sw\source\core\text\txtfrm.cxx, but it did happen at least once in my testing.
        
        Change-Id: I66fdedcd1f88fc2eb4e60ef6bd9f6baa46fe4684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162317
        Tested-by: Jenkins
        Reviewed-by: Matt K <mattkse@gmail.com>

2024-02-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3c39de6bdd46edd3e8ce1aeca7f15ed93cf34659]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a9733f825b5a4d316227d1a275c59e1ab5327375
          - SF_Toc correction
            
            Change-Id: I1abd145c121a623ed9c8f62bdfac07eb03a559ff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162892
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-02-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [1ffe39721049d55f9b63e942d27878b4ae7b49e0]

        tdf#154587: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I05cc51df1bef109bba48f340fdfe21ed1a12dc18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162914
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-02  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [7a3e9c66baff8554d1267bc98c9c69e763bc8bdc]

        sw: do not redline ContentControl items
        
        When we redline the ContentControl item
        itself, we break docx XML. Instead, we
        only need to redline the placeholder,
        which we already do.
        
        This simply disables redlining when
        inserting the ContentControl item
        while leaving it otherwise enabled
        while inserting the placeholder.
        
        Before:
        
        <w:body>
            <w:p>
                <w:pPr>
                    <w:pStyle w:val="Normal"/>
                    <w:rPr></w:rPr>
                </w:pPr>
        ==>     <w:ins w:id="-1" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z">
                <w:sdt>
                    <w:sdtPr>
                        <w12:checkbox>
                            <w12:checked w14:val="0"/>
                            <w12:checkedState w14:val="2612"/>
                            <w12:uncheckedState w14:val="2610"/>
                        </w12:checkbox>
                    </w:sdtPr>
                    <w:sdtContent>
                        <w:r>
                            <w:rPr></w:rPr>
                        </w:r>
        ==>         </w:ins>
        ==>         <w:ins w:id="0" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z">
                        <w:r>
                            <w:rPr></w:rPr>
                            <w:t>☐</w:t>
                        </w:r>
        ==>         </w:ins>
                        <w:r>
                            <w:rPr></w:rPr>
                        </w:r>
                    </w:sdtContent>
                </w:sdt>
            </w:p>
        </w:body>
        
        The first <w:ins> and its closing tag
        is not seen in the reference docx
        file, and we can see that it's invalid
        XML here.
        
        After:
        <w:body>
            <w:p>
                <w:pPr>
                    <w:pStyle w:val="Normal"/>
                    <w:rPr></w:rPr>
                </w:pPr>
                <w:sdt>
                    <w:sdtPr>
                        <w12:checkbox>
                            <w12:checked w14:val="0"/>
                            <w12:checkedState w14:val="2612"/>
                            <w12:uncheckedState w14:val="2610"/>
                        </w12:checkbox>
                    </w:sdtPr>
                    <w:sdtContent>
                        <w:r>
                            <w:rPr></w:rPr>
                        </w:r>
        ==>         <w:ins w:id="0" w:author="Unknown Author" w:date="2024-01-24T19:43:08Z">
                        <w:r>
                            <w:rPr></w:rPr>
                            <w:t>☐</w:t>
                        </w:r>
        ==>         </w:ins>
                        <w:r>
                            <w:rPr></w:rPr>
                        </w:r>
                    </w:sdtContent>
                </w:sdt>
            </w:p>
        </w:body>
        
        Only the valid <w:ins> around the
        placeholder exists.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I1404e41aec3b5efdc2e4115236102ffa2733b15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162802
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [332faa63407305852f5044e4bbc41302ccfe46cd]

        Revert "tdf#154863 Add unit test to cover crash on image move"
        
        This reverts commit 16d46e25e03cd506576ac3dcb6be56270b47b4a6.
        
        Reason for revert: macOs jenkins fails in CppunitTest_sw_core_objectpositioning now
        
        Change-Id: I45ed894c9773e0dc23d0f9fdd9066eb5ca7110f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162901
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-02  Miklos Vajna  <vmiklos@collabora.com>  [1647493e5cbb9cf4f06b7d0387d6763a2f30fdae]

        sw doc model xml dump: show details of comments
        
        And fix a creative XML attribute name. 'm_aAttr.getItem()' is not really
        well-formed, try 'attr-item' instead.
        
        Change-Id: I108cba8c6cff8d19c388710bbf693e3e8214f3f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162926
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f104a9d8c806ccb352c680af6a29422d796114df]

        editeng: GetCursorFlags flags to CursorFlags struct of bools
        
        Convert bitflags to struct of bools, which is much easier to read
        and you don't need to mess with bitwise operations.
        
        Change-Id: I475eb2743b105f8a5bfcab1159dff2b298594740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162925
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2441344bf1e8586a1ce181e73504fde0f9d2282e]

        tdf#91914 - Open available options through status bar using single click
        
        Enable one-click access to available options in Calc through the status
        bar, ensuring consistency with Writer and other applications.
        
        Change-Id: Ia6c52ed9ae6e316a69f9aad9e80384cfa18feb47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162916
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-02-02  Miklos Vajna  <vmiklos@collabora.com>  [0503f6718f7686f3e2c93fc13af23e9fbfdace42]

        tdf#159507 editeng: support pasting HTML fragments
        
        Commit ce53519f025158f8f64a4e8603c8c6e0dc35473a (cool#8023 editeng:
        support HTML paste, 2024-01-24) added support for pasting HTML files
        into Calc cells while editing, but this doesn't work when only a HTML
        fragment is provided, without headers and footers.
        
        The HTML code in ImpEditEngine::PasteText() was modeled after the
        HTML_SIMPLE case, which is some custom format from MSIE and that
        rejected the data in case the header didn't match, so the HTML case also
        required a HTML header in the above commit, but this doesn't work for
        HTML fragments.
        
        Fix the problem by just dropping the header check in
        ImpEditEngine::PasteText(), because that data already comes from the
        text/html slot of the clipboard, so there is already indication about
        the file format, even without the header. And without headers, it's
        almost impossible to recognize if the HTML fragment is a HTML one or
        not.
        
        Note that this is the HTML paste when a cell edit is active, the normal
        Calc HTML paste is a different codepath, in sc/.
        
        Change-Id: I4d37d80f947880fe22051c5fe84dc6bbc257e108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162927
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [4981c0e7d5bbe8e1fadc1b5cc7923e32f160d635]

        Add SfxMedium::IsRepairPackage
        
        Change-Id: Id100e5a85a0504ab4fb80f75a168a4fd31a54119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162924
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-02  Patrick Luby  <plubius@libreoffice.org>  [29bf86f7cb367705b13049e5f0b3faa8bb93638a]

        tdf#159307 add default macOS certificate manager applications
        
        Most, if not all, of the Linux certificate manager applications are
        not available on macOS so create a separate list for macOS.
        
        Also, fix uncloseable windows due to uncaught exceptions thrown by
        XSystemShellExecute::execute(). Failure to catch such exceptions
        would cause the document window to be uncloseable and the application
        to be unquittable.
        
        Change-Id: I9bc6dc9c6c9d054252b634874045cb066023214a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162887
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-02  Michael Weghorn  <m.weghorn@posteo.de>  [ffe0f40bd70f96f9b57a8bde1625dd56534a149e]

        sw: Use a const TransferableDataHelper (ref) here
        
        All these methods don't modify the object, so
        can use a const reference.
        
        Change-Id: Ic30f84931358c61999ba27e0da303fdf4bb6f50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162923
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-02  Michael Weghorn  <m.weghorn@posteo.de>  [59317e7b1b822cf06effcd5b3ce004019d95e0ef]

        sw: Increase indentation for StartExecuteAsync params
        
        This way it's easier to spot that the (now further indented)
        code is the lambda expression passed as
        param to `StartExecuteAsync`.
        
        Change-Id: Iaa56b0838be4d1607bfde9e740f1397021604b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162922
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a53f0dc811a115cd68a5c297a68eeb5a9d3bb5ef]

        Extract Local file header and Data descriptor handling into own functions
        
        Change-Id: I16405f13298934945cc1d5d4a50d403b37c3234e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162912
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-02  Kurt Nordback  <kurt.nordback@protonmail.com>  [6c45285e860a6b2dd7dd1aa6c8b7b9bb02134dd0]

        tdf#50934: Initial plumbing and infrastructure
        
        Change-Id: I355bdc8e6d67e7cdd47e4d6eccecedc4b53ac11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3fc0eb2bc8b439bda286e0c87a9814d90cc9d9d5]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7eb44b4e6e21e49027b3caca5f5c85d0aa1f7859
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ief082cee65d31c24f50f8c500bbc5fb14c55ac27
            
2024-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [747463809e50c132557a95dcee6709a1fa82d760]

        tdf#154587: allow directory entries in ZIP packages
        
        The problem in the bugdoc was the directory entries. These entries
        are valid in ZIP packages (even if not common); they may be useful
        to e.g. define per-directory permissions (ACLs).
        
        In normal mode, ZipFile reads central directory; there we can read
        if the entry has FAT file attributes; and then, if the entry is a
        directory. Then it is OK to skip it.
        
        In repair mode, central directory is not used, local file headers
        don't contain a "directory" flag. A workaround is used, checking
        if there are entries that represent directories of other entries.
        
        Also this change fixes some places that didn't pass the recovery
        flag correctly.
        
        Change-Id: I324671841a2c4d0f279b03801d95c8f2eeb99b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162888
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c3d00f4ca0ec5a53d694ab9924fd79d0e536aec4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 10c11a706ac08e4324a9439e42c748417c0e7f47
          - Fix link to graphic_size_check page
            
            Fix a bug that the "Help Page Not Found" page is displayed
            when the Help button in the "Graphic Size Check" dialog is clicked.
            
            Change-Id: I6bf7c568b5f0dafc5d21de49d950b074cc09f442
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162645
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-01  Dione Maddern  <dionemaddern@gmail.com>  [c725db3a1a3b3c796984467b87ac8d2940984edf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f4e836fd8b70243326cb8cb5f71213055f08195
          - tdf#155877 Fix broken links in Tools menu help pages in Draw
            
            Added HID bookmarks to /text/shared/guide/redaction.xhp so that pressing F1 opens the correct help page for:
            Tools > Redact > Rectangle
            Tools > Redact > Freeform
            Tools > Redact > Export Redacted PDF (White)
            Tools > REdact > Export Redacted PDF (Black)
            
            Change-Id: I6ae3dcb39f794c9acff004d66b5fecd821fe93c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162819
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-02-01  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [5d37affe5f5bb9b5122d08529ec8608529948b99]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 208a9fd80b2a182fe20f224cd615119c6323ae2e
          - tdf#159164 Update the English dictionaries: GB+ZA+AU+CA+US
            
            Change-Id: I1ad3cb7a283f85cd8260d2d12f3abd78dfcf6206
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/162881
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [13865c4da30a3a2a5ab8efbd568c47952d3ffcee]

        tdf#159015 sw: layout: fix infinite loop in ::CalcContent()
        
        SwObjectFormatter::FormatObj() will just return if IsAgain() is set, so
        the while loop here won't make any progress.
        
        (regression from commit 191babee4f0ec643b80e96b0cd98c2d04ff96e4e)
        
        Change-Id: I1c194b148760ae05cf4dee1d5729be28e87d6ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162880
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Miklos Vajna  <vmiklos@collabora.com>  [e6e5660b726ecf3b0c39b277568568973b43c9f0]

        tdf#159483 sc HTML import: handle data-sheets-value attribute for the text case
        
        The A2 cell in the bugdoc has 01 in it, which was auto-converted to 1
        (float) value on import, even if it was text originally.
        
        This is hard to solve for HTML in general, which is not typed, but this
        input is coming from google sheets, which has an additional
        data-sheets-value attribute on <td> that does tell us about the type of
        the cell.
        
        Fix the problem by handling that attribute, and in case it explicitly
        says it's text, then apply the matching number format.
        
        Other types are not yet handled.
        
        Change-Id: I2986ef864e97d9c46d191aba25ca5740a1151a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162869
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-01  Juan c. Sanz  <jucasaca@gmail.com>  [829374381d9c9191746d528b52411ad757e39a08]

        tdf#117118 - Saves data automatically in Firebird embedded database
        
        Saves data when disposing connection regardless of
        whether or not the save button is pressed. Solve Linux problems reported
        after previous patch (commit 9227fbabe0a33134f56aefdd8ec16024f006a659) was reverted.
        
        
        Change-Id: Idc02930c894560dfdb40265c253ee7c5557fe18b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159019
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [b85c2459ced6a41915dbaf567613fb5e244a0ada]

        check that rtl_random_getBytes() was successful
        
        ... everywhere it is used to generate material for encryption.
        
        Change-Id: Id3390376bb2f3a5fa1bbfd735850fce886ef7db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162873
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6083293f4de9ac9037066d51f0ad1ab6a420eda]

        tdf#131575: sc_subsequent_filters: Add unittest
        
        Change-Id: I6f4bcc3da028dc9b2cd86ed06e309bed8d808ca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162872
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [c9cbcd21edbde84d793a45295f9df7196d1893d8]

        tdf#76115: sc_subsequent_filters: Add unittest
        
        Change-Id: I355eef6b0f145da8aacdd3b395ce3dcbecfb3e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162870
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-02-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [22b5007e2740e1f461968f3c8e919326eb4d4785]

        tdf#140004 Toggle comment in the Basic IDE
        
        This patch adds the "toggle comment" functionality to the Basic IDE.
        The shortcut Ctrl + Alt + C is used to execute it.
        
        It works similarly to other code editors such as Kate and VSCode.
        
        Change-Id: Ifdae42b3729cc909baf87c729fe8c3cdf6428184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162005
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-02-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [7bcce4180d11f6f49a71f681eeefc556fc2302ba]

        tdf#131641 Enter selected text in the search bar (Basic IDE)
        
        This patch makes the selected text in the code editor be
        automatically inserted in the search bar.
        
        Change-Id: Ibbe64aa3375a5a47dedb762001ed4b99f4b22e46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162548
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-02-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6d0fddb697fd619d11da3469f4dd72782334f3bb]

        tdf#158326 - Auto Filter: separate sorting and removing of duplicates
        
        Change-Id: Ide74895508af280f4b0c129689d852635e62dbff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160052
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [6bddbe51cee5c4aea023cc68771800f46a4aad2f]

        tdf#159496: clear mxObjectContainer in PrepareSecondTryLoad_Impl
        
        The problem here is that the object container has own reference to the
        storage object. In SfxBaseModel::load, when preparing for a second try,
        the storage gets disposed, and a cleanup is performed; but previously,
        the reference to the disposed storage was used in the object container,
        and thus generated a failure when it was used to import the OLE.
        
        Clearing it allows to re-create it properly, with the updated storage.
        
        Change-Id: I08b7503d79240ccc51b253fe1f4e99a0232995b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162866
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [747c4c50f3d5a283dc61837675bbd3d42c661f78]

        Fix typo
        
        Change-Id: I38aaf46f65749bb0aff88e2fbeb2fd65bc8b7030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162874
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [575a713aae2beb4402ea9c41802311966329b8ea]

        tdf#159493: hold solar mutex in TimerUpdate
        
        Several functions called from here check that the mutex is
        held, specifically:
        
        === call stack 1 ===
        
          tllo.dll!DbgTestSolarMutex()
          	at C:\lo\core\tools\source\debug\debug.cxx(55)
          swlo.dll!SwTextBoxHelper::isTextBox(const SwFrameFormat * pFormat, unsigned short nType, const SdrObject * pObject)
          	at C:\lo\core\sw\source\core\doc\textboxhelper.cxx(300)
          swlo.dll!SwDoc::GetFlyCount(FlyCntType eType, bool bIgnoreTextBoxes)
          	at C:\lo\core\sw\source\core\doc\docfly.cxx(76)
          swlo.dll!SwFEShell::GetFlyCount(FlyCntType eType, bool bIgnoreTextBoxes)
          	at C:\lo\core\sw\source\core\frmedt\feshview.cxx(2557)
          swlo.dll!SwContentType::FillMemberList(bool * pbContentChanged)
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(585)
          swlo.dll!SwContentTree::HasContentChanged()
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(3431)
          swlo.dll!SwContentTree::TimerUpdate(Timer * __formal)
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(4174)
          ...
        
        === call stack 2 ===
        
          tllo.dll!DbgTestSolarMutex()
          	at C:\lo\core\tools\source\debug\debug.cxx(55)
          vcllo.dll!OutputDevice::SetDeviceClipRegion(const vcl::Region * pRegion)
          	at C:\lo\core\vcl\source\outdev\clipping.cxx(205)
          vcllo.dll!OutputDevice::SetClipRegion(const vcl::Region & rRegion)
          	at C:\lo\core\vcl\source\outdev\clipping.cxx(66)
          vcllo.dll!SvImpLBox::ShowCursor(bool bShow)
          	at C:\lo\core\vcl\source\treelist\svimpbox.cxx(654)
          vcllo.dll!SvImpLBox::UpdateAll()
          	at C:\lo\core\vcl\source\treelist\svimpbox.cxx(680)
          vcllo.dll!SvImpLBox::SetUpdateMode(bool bMode)
          	at C:\lo\core\vcl\source\treelist\svimpbox.cxx(2996)
          vcllo.dll!SvTreeListBox::SetUpdateMode(bool bUpdate)
          	at C:\lo\core\vcl\source\treelist\treelistbox.cxx(2306)
          vcllo.dll!SalInstanceTreeView::thaw()
          	at C:\lo\core\vcl\source\app\salvtables.cxx(3938)
          swlo.dll!SwContentTree::clear()
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(3018)
          swlo.dll!SwContentTree::Display(bool bActive)
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(2853)
          swlo.dll!SwContentTree::TimerUpdate(Timer * __formal)
          	at C:\lo\core\sw\source\uibase\utlui\content.cxx(4181)
          ...
        
        Change-Id: I643f5984d4678f8062f20bf341bfad6e8462526b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162865
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-01  Miklos Vajna  <vmiklos@collabora.com>  [7eade23bc642ef7270a24cfbc25761fc413170c8]

        CppunitTest_sw_uibase_fldui: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this one didn't find any problems.
        
        Change-Id: Idcd186358d20321753dac9cb899aa887aa4a3430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162863
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [6c62129e64eb5ef00dfa5f2137c8689d55190163]

        tdf#159474: fix handling of pre-set RepairPackage property
        
        StorageFilterDetect::detect had a wrong logic here, only honoring
        repair request in case it haappened interactively inside it. The
        pre-existing RepairPackage set to true was treated as "do not try
        to repair".
        
        Change-Id: I3fb63a5d72097a79977e8ed734f8e69dd2ea999a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162858
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [992f7114ab8645fb5b7a22b5f974a95fe7be7712]

        writerfilter: replace members w/ SubstreamContext::eSubstreamType
        
        This should not change any behaviour.
        
        Change-Id: Ic970f0e1b6401119d875c9e811589b9c210e0c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162842
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [30323c813977eb0127251848fecd2532dce75749]

        writerfilter: move m_bFirstParagraphInCell to SubstreamContext
        
        This is a change to set it for all substreams.
        
        Change-Id: I44ed9a5485000f40f8ccfe3ec885ef8f05f5aab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162841
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [95b01848b18283fd2f903c982108ccdb8efee022]

        writerfilter: use SubstreamContext for all substreams
        
        <vmiklos> possibly just nobody needed that so far. could be some more
        general SubstreamContext, i don't see an obvious problem reusing that at
        more places.
        
        Change-Id: If0749155452f65f8dfc4ac2b10f91bb8e48a6b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162840
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [4913812baeabd44b46302e54b73a227e760c688a]

        writerfilter: move m_bParaHadField to SubstreamContext
        
        Change-Id: Ie15e35d304a423bfa3d7b7ead71015d5ec1228d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162839
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-02-01  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8869994d5e62c422465f52b25dc3792be9add92d]

        embindmaker: Add support for sequence types
        
        Ideally, JS code would have a way to create instances of arbitrary UNO sequence
        types (to e.g. put them into Anys), but that goes against the static nature of
        Embind.  So at least register JS support for all those UNO sequence types that
        are actually used in the UNO API.  (This would cause duplicate failures, though,
        if we generated multiple separate .cxx files from embindmaker invocations, with
        registration code for the same UNO sequence types.)
        
        (Even more ideally, UNO sequence types could map to JS arrays, and/oror be
        garbage-collected on the JS side rather than needing explicit delete().  The
        resize/size/get/set interface in unoembindhelpers::registerSequence is modelled
        after Embind's emscripten::register_vector.)
        
        Change-Id: Icd38b2e03db442dd613b9222b9bd092f947f7bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162849
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-02-01  Noel Grandin  <noelgrandin@gmail.com>  [40045883b04e1c0694f802d98d417c9b48e0f4fd]

        fix --enable-mergelibs build on macOS
        
        by including the spellchecker library into the merged library
        
        Change-Id: I427458005af3b30bfdcd2134ef102852e4c92ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-01  Matt K  <mattkse@gmail.com>  [16d46e25e03cd506576ac3dcb6be56270b47b4a6]

        tdf#154863 Add unit test to cover crash on image move
        
        This change adds a CppUnit test that changes the position
        of an image in an example document which causes a crash
        if the bug exists.
        
        Change-Id: I0f507ccf63c2c7f49f6ed71cd8df174b2b3136f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162857
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-02-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4df1c7ba91032ca0de0073d37ebc90c71c48eb7]

        make table-tab dialog async
        
        Change-Id: I3d5e4a691e494ec27eead8882b6155545361d48d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2101ec9402d067ec6fce1017c9ff6adbaf2808c]

        make insert-new-doc dialog async
        
        Change-Id: I4977fc6ef2c6da356051ac5573ed088707d3b311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162834
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [137df7cd67e5bb34cb75f716700d3c765a3efad2]

        make insert-db-col-auto-pilot dialog async
        
        Change-Id: I954c9a4c55c9c641955484626aa744dd9fa74995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1276daee3d0d4f30ee8844b6df55d72e0b54093f]

        Currency pop-up: move getDocumentCurrencies to cxx, extend test
        
        Test now checks that multiple cells with the same currency still
        result in only one entry returned by getDocumentCurrencies.
        
        Change-Id: I34b0fd3b117ce01b3fd462f684d0927dd53f796d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162788
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2cac2ee38445c19c9281f54c2b961bbc9149cc00]

        sc: put used currencies on top of the currency pop-up list
        
        The list of currencies is fairly long and there is no easy way
        to search the list, so to make it easier to concurrently fint the
        desired currency, put the currencies that are used in the document
        on top of the list.
        
        This adds a DocumentModelAccessor class, which is used to access
        parts of the document model from other modules throught the
        SfxObjectShell.
        
        Change-Id: I81a180b674ae69b373b0422f363678e8bab37194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162638
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 79da840fac78f11c156801c43d8b79d6d4f32869)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162755
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cc2e1e29489994fd28660cff384820e6676cce06]

        editeng: access ImpEditEngine with getImpl() not direct
        
        In EditEngine use getImpl() when accessing ImpEditEngine and not
        directly via the mpImpEditEngine member variable.
        
        Change-Id: I11f9ee21aec4f5e99fbe78bacab57ddc21580af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162662
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [df0c602aa6579604bc734bbfb5956261eb026b23]

        Related tdf#158750 Fix line highlight for all modules when color scheme changes
        
        Prior to this patch, if a library had multiple modules and the color scheme was changed (via View - Color Scheme), the line hightlight color would only update for the current module and remain unchanged for the other modules in the same library.
        
        Change-Id: Idda78c07d02534dfedcd927c37116a2617500ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162818
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-31  Michael Weghorn  <m.weghorn@posteo.de>  [d7586471cdccaac742a69d53bc299875f02309cd]

        qtcreator: Fix generating .pro files for externals
        
        Since
        
            commit 3460799175e6c5795aa07c784e16d10ba9081d49
            Date:   Thu Jan 25 23:41:52 2024 +0600
        
                Clear gb_GbuildToJson_DENYLISTEDMODULES, allow these modules
        
        , externals are taken into account in the generation of IDE integrations,
        causing errors like this when running `make qtcreator-ide-integration`
        to generate the *.pro files for the QtCreator IDE integration:
        
            cd /home/michi/development/git/libreoffice &&  bin/gbuild-to-ide --ide qtcreator --make make
            ERROR : creating pro file=/home/michi/development/git/libreoffice/clucene/clucene.pro
            [Errno 2] No such file or directory: '/home/michi/development/git/libreoffice/clucene/clucene.pro'
            Traceback (most recent call last):
              File "/home/michi/development/git/libreoffice/bin/gbuild-to-ide", line 1787, in emit
                with open(qt_pro_file, mode) as fpro:
                     ^^^^^^^^^^^^^^^^^^^^^^^
            FileNotFoundError: [Errno 2] No such file or directory: '/home/michi/development/git/libreoffice/clucene/clucene.pro'
        
        Fix this by creating the .pro files in a directory that has the same
        relative path to the $(BUILDDIR) as the corresponding .mk files have
        in the $(SRCDIR) rather than in $(BUILDDIR)/$(LIBNAME)/.
        
        While both are the same for LO's internal modules,
        the latter directory does not exist for externals, since
        they're located underneath a top-level directory called "external".
        
        For the simple case of an in-tree build, this now e.g.
        creates a file `external/clucene/clucene.pro` instead
        of failing to create a `clucene/clucene.pro` because there's
        no top-level "clucene" directory.
        
        An alternative approach might to just ignore the externals,
        as this commit implemented it for the codelite integration:
        
            commit 41c8e0957369b7b53a3b9cf4b4cf1e49a982a414
            Date:   Sat Jan 27 21:54:10 2024 +0200
        
                fix codelite-ide-integration
        
                externals seems to be part of the list of modules now, but I
                don't know how to deal with that, so just ignore them.
        
        (In that case, they wouldn't be part of the project, speeding
        up update of the clang code model after changes, but then not providing
        features like code navigation and autocompletion etc.)
        
        Change-Id: Idb04af5f7445955e5dbf9ec3fd8626bbcb09ab11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162837
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [efaf6218a2548de051fc770bd5d4996e97e771d2]

        embindmaker: Consistently spell out "::com::sun::star::"
        
        Change-Id: I253236c908b1827479c1824cf01c707e48ef58c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52ba1fea038a93c77e62d3a173a070b6a249518c]

        move CharMap out of cui
        
        remove CUI_DLLPUBLIC from stuff which is not exported
        then drop the cui/include dir which is then empty and
        the places we link to cui where we now don't need to
        
        and restore cui back to a lib containing stuff that
        doesn't need to be explictly linked to in keeping
        with original #i106421# idea
        
        Change-Id: I21894e6f8529dd3306df345fb52dbf5009015f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162798
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5a521daa685dfe7922d057007530ed0711ba9e42]

        embindmaker: Handle (plain) structs
        
        Change-Id: I16ac3a6a2f42cf3054104a5ba90f4b75238e2ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162843
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [da733de7e2721c6e5982a90953f09a2769af0a30]

        make char properties dialog async
        
        Change-Id: I5bba9b50cc1a34944afea28458f57bd51047433e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162344
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d9fba2ece350f82f307493b184447dbb44a971d]

        tdf#159350 Hiding Options dialog tabpages stopped working
        
        regression from
            commit 3ed7511eca99819012fc1baa490ef85963a9472e
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jul 26 15:21:35 2021 +0200
            simplify SvtOptionsDialogOptions
        
        Change-Id: If300aefd3b249e64c15bc664ed16c00e743c2b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4c288ac1f2b9ad17fff0241cb64ddd3b61a85e89]

        Rename UnoInOutParamXxx -> uno_InOutParam_xxx
        
        ...to harmonize with the other existing uno_Type_... etc. names, and with
        upcoming uno_Sequence_... names.  (And template'ize the registration code.)
        
        Change-Id: I5dace5bc643ab636977fde84fa51825efc5cafa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162838
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [17e2c7226a73675d69febf0915aaeae61ad8e9f1]

        tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ header
        
        The problem was not fixed yet for the less-minimized bugzilla attachment
        where the sections contain headers and footers.
        
        What happened there is that first \page caused a deferred page break,
        then \sect and sectBreak() delayed-read the header substream and the
        \par in the header resets all the deferred break flags.
        
        Add the deferred break to an already existing Context class, and remove
        the direct members in DomainMapper_Impl in favor of always using the
        m_StreamStateStack.
        
        Probably this problem cannot occur for DOCX import, because it imports
        header/footer eagerly where the reference element is, and sectPr is
        before any runs that contain breaks in the same paragraph element.
        
        Change-Id: Iba971955e9cf0c398d416518e72d99307d3e1cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162833
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [dbe78489e98d565b72a703524308523135ffdd67]

        tdf#158586 writerfilter: RTF import: handle \sect in frame as \par
        
        This fixes the test testTdf158586_0 and testTdf158586_0B to look like in
        Word; the case appears a bit esoteric, hopefully Word won't actually
        create such documents? But Word will round-trip such bugdoc to a DOCX
        where the first w:p contains all of w:framePr and w:sectPr and w:br...
        
        Change-Id: I6ec09478a774e1e9c785e9482618c1afc388df0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162778
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [57abad5cf990111fd7de011809d4421dc0550193]

        tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone
        
        The problem is that \page is actually completely ignored in the bugdoc
        testTdf158586_1.
        
        If you delete the \sbknone then there is a page break but it's caused by
        \sect; the \page is still ignored.
        
        It is ignored because, first, the \page results in a deferred break in
        DomainMapper, then for \sect, the synthetic \par is dispatched and that
        moves the break from deferred to the top paragraph properties context,
        then sectBreak() calls endParagraphGroup() which just removes the top
        paragraph properties context.
        
        Remove the dispatchSymbol(RTFKeyword::PAR) for \sect, instead set a flag
        so that RTFDocumentImpl::sectBreak() does it.
        
        Add a new flag m_bParAtEndOfSection so that RTFDocumentImpl::parBreak()
        can suppress the startParagraphGroup(), so the deferred break remains
        present.
        
        This also fixes testTdf158586_lostFrame.
        
        (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b)
        
        Change-Id: I82a00899a9448069832a0b2f98a96df00da75518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162770
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1195df679859b2ebfafb60bd456dcba90ff6bfae]

        make date-form-field dialog async
        
        Change-Id: Ia43217c3218344bacde823aa52dc0776de822d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162807
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1ac38a3d269ce862c17da00885c8b0b0bee5e6c]

        make change-db dialog async
        
        Change-Id: I3310592cb2e7922f86ead8a6e19792e5852a4ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162806
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [09c29b56fe8af1f3428a96017fec4d921e023906]

        make field-edit dialog async
        
        Change-Id: Ib24166fe0370a27357adf1611deafda2686a14aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dcbcc12b9f9db99ba18811c7249917916748e2a7]

        lo_dumpState doesn't take the SolarMutex, so dbgutil state dumping can assert
        
        so disable the SolarMutex checks during dumpState and restore afterwards
        
        	#8  0x00007fa179e287f3 in abort () at /lib/x86_64-linux-gnu/libc.so.6
        	#9  0x00007fa179e2871b in  () at /lib/x86_64-linux-gnu/libc.so.6
        	#10 0x00007fa179e39e96 in  () at /lib/x86_64-linux-gnu/libc.so.6
        	#11 0x00007fa1706904de in ImplDbgTestSolarMutex() () at libreoffice/vcl/source/app/dbggui.cxx:35
        		__PRETTY_FUNCTION__ = "void ImplDbgTestSolarMutex()"
        	#12 0x00007fa1782cb713 in DbgTestSolarMutex() () at libreoffice/tools/source/debug/debug.cxx:54
        	#13 0x00007fa170559ebb in VirtualDevice::AcquireGraphics() const (this=0x5589006636b0) at libreoffice/vcl/source/gdi/virdev.cxx:49
        		pSVData = 0x7fff8a2386d0
        	#14 0x00007fa17020d849 in OutputDevice::DrawRect(tools::Rectangle const&) (this=0x5589006636b0, rRect=...) at libreoffice/vcl/source/outdev/rect.cxx:67
        		__PRETTY_FUNCTION__ = "void OutputDevice::DrawRect(const tools::Rectangle&)"
        		aRect = {static RECT_EMPTY = -32767, mnLeft = 0, mnTop = 0, mnRight = 10244, mnBottom = 269}
        	#15 0x00007fa17021d997 in OutputDevice::DrawColorWallpaper(long, long, long, long, Wallpaper const&) (this=0x5589006636b0, nX=0, nY=0, nWidth=10245, nHeight=270, rWallpaper=...) at libreoffice/vcl/source/outdev/wallpaper.cxx:90
        		__PRETTY_FUNCTION__ = "void OutputDevice::DrawColorWallpaper(tools::Long, tools::Long, tools::Long, tools::Long, const Wallpaper&)"
        		aOldLineColor = {{mValue = 0, {B = 0 '\000', G = 0 '\000', R = 0 '\000', T = 0 '\000'}}}
        		aOldFillColor = {{mValue = 16777215, {B = 255 '\377', G = 255 '\377', R = 255 '\377', T = 0 '\000'}}}
        		bMap = false
        	#16 0x00007fa17021d851 in OutputDevice::DrawWallpaper(long, long, long, long, Wallpaper const&) (this=0x5589006636b0, nX=0, nY=0, nWidth=10245, nHeight=270, rWallpaper=...) at libreoffice/vcl/source/outdev/wallpaper.cxx:73
        		__PRETTY_FUNCTION__ = "void OutputDevice::DrawWallpaper(tools::Long, tools::Long, tools::Long, tools::Long, const Wallpaper&)"
        	#17 0x00007fa17021daa8 in OutputDevice::Erase() (this=0x5589006636b0) at libreoffice/vcl/source/outdev/wallpaper.cxx:106
        		eRasterOp = RasterOp::OverPaint
        	#18 0x00007fa17055c716 in VirtualDevice::InnerImplSetOutputSizePixel(Size const&, bool, unsigned char*) (this=0x5589006636b0, rNewSize=..., bErase=true, pBuffer=0x0) at libreoffice/vcl/source/gdi/virdev.cxx:292
        		bRet = true
        		nNewWidth = 10245
        		nNewHeight = 270
        		__PRETTY_FUNCTION__ = "bool VirtualDevice::InnerImplSetOutputSizePixel(const Size&, bool, sal_uInt8*)"
        	#19 0x00007fa17055cbf5 in VirtualDevice::ImplSetOutputSizePixel(Size const&, bool, unsigned char*) (this=0x5589006636b0, rNewSize=..., bErase=true, pBuffer=0x0) at libreoffice/vcl/source/gdi/virdev.cxx:360
        	#20 0x00007fa17055ceba in VirtualDevice::SetOutputSizePixel(Size const&, bool) (this=0x5589006636b0, rNewSize=..., bErase=true) at libreoffice/vcl/source/gdi/virdev.cxx:408
        	#21 0x00007fa16fea3ca4 in VirtualDevice::SetOutputSize(Size const&) (this=0x5589006636b0, rNewSize=...) at libreoffice/include/vcl/virdev.hxx:163
        	#22 0x00007fa16fe96388 in VclDrawingArea::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fe9ba320, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:3092
        		pDevice = {<ScopedVclPtr<VirtualDevice>> = {<VclPtr<VirtualDevice>> = {m_rInnerRef = {m_pBody = 0x5589006636b0}}, <No data fields>}, <No data fields>}
        		pRefDevice = 0x5588ff474fd0
        		aRenderSize = {<Pair> = {mnA = 10245, mnB = 270}, <No data fields>}
        		aOutputSize = {<Pair> = {mnA = 683, mnB = 18}, <No data fields>}
        		aRect = {static RECT_EMPTY = -32767, mnLeft = 140735510973440, mnTop = 140331342376707, mnRight = 140735510973456, mnBottom = 94046886702440}
        		aImage = {maBitmap = {_vptr.Bitmap = 0x7fff8a238c20, mxSalBmp = std::shared_ptr<class SalBitmap> (empty) = {get() = 0x7fa16fd029cc <std::__uniq_ptr_impl<WindowImpl, std::default_delete<WindowImpl> >::_M_ptr() const+28>}, maPrefMapMode = {mpImplMapMode = {m_pimpl = 0x7fff8a238d60}}, maPrefSize = {<Pair> = {mnA = 94046793857224, mnB = 140331516265348}, <No data fields>}}, maAlphaMask = {_vptr.Bitmap = 0x0, mxSalBmp = std::shared_ptr<class SalBitmap> (use count 1875914999, weak count 32672) = {get() = 0x5588ff46fa98}, maPrefMapMode = {mpImplMapMode = {m_pimpl = 0x7fa16fd030f7 <std::_Tuple_impl<0ul, WindowImpl*, std::default_delete<WindowImpl> >::_M_head(std::_Tuple_impl<0ul, WindowImpl*, std::default_delete<WindowImpl> > const&)+28>}}, maPrefSize = {<Pair> = {mnA = 94046793857224, mnB = 94046886754968}, <No data fields>}}, maBitmapSize = {<Pair> = {mnA = 140735510973568, mnB = 140331342377207}, <No data fields>}}
        		aOStm = {<SvStream> = {_vptr.SvStream = 0x2ab, m_xLockBytes = {pObj = 0x12}, m_nActPos = 140735510973600, m_pRWBuf = std::unique_ptr<unsigned char []> = {get() = 0x7fa16fd03026 <std::__get_helper<0ul, WindowImpl*, std::default_delete<WindowImpl> >(std::_Tuple_impl<0ul, WindowImpl*, std::default_delete<WindowImpl> > const&)+28> "\311\303\363\017\036\372UH\211\345H\203\354\020H\211}\370H\213E\370H\211\307", <incomplete sequence \350\265>}, m_pBufPos = 0x7fff8a238cb0 "\340\214#\212\024", m_nBufSize = 64152, m_nBufActualLen = 65350, m_nBufActualPos = 21896, m_nBufFree = 0, m_isIoRead = 192, m_isIoWrite = 140, m_isDirty = 35, m_isSwap = 138, m_isEof = 255, m_nError = {m_value = 1875914499}, m_nCompressMode = (SvStreamCompressFlags::ZBITMAP | unknown: 0x7fa0), m_eLineDelimiter = (unknown: 0x8a238ce0), m_eStreamCharSet = 20, m_aCryptMaskKey = {pData = 0x5588ff46fa98}, m_nCryptMask = 224 '\340', m_nVersion = 16, m_nBufFilePos = 140735510975776, m_eStreamMode = 2317587744, m_isWritable = 255}, nSize = 140735510973776, nResize = 28087389472, nPos = 140735510975776, nEndOfData = 140735510975776, pBuf = 0x7fff8a238d58 " \225#\212\377\177", bOwnsData = 32}
        	#23 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff46fa90, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 20
        		nTop = -12124904
        		nWidth = 21896
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588fe9ba320
        		pAccLabelFor = 0x7fff8a238de0
        		pAccLabelledBy = 0x68a238db0
        	#24 0x00007fa16fe86709 in VclBox::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff46fa90, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:398
        	#25 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff46fd10, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 32767
        		nTop = -12221224
        		nWidth = 21896
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff46fa90
        		pAccLabelFor = 0x7fff8a238e58
        		pAccLabelledBy = 0x7fff8a238e20
        	#26 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff462d60, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = -1
        		nTop = -1
        		nWidth = 1
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff46fd10
        		pAccLabelFor = 0x5588ff458838
        		pAccLabelledBy = 0x7fff8a238e90
        	#27 0x00007fa16fe8fecd in VclScrolledWindow::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff462d60, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:2184
        	#28 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff458830, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 20
        		nTop = -12220472
        		nWidth = 21896
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff462d60
        		pAccLabelFor = 0x7fff8a238fb0
        		pAccLabelledBy = 0x68a238f80
        	#29 0x00007fa16fe86709 in VclBox::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff458830, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:398
        	#30 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff4587c0, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 20
        		nTop = -18974136
        		nWidth = 21896
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff458830
        		pAccLabelFor = 0x7fff8a239040
        		pAccLabelledBy = 0x68a239010
        	#31 0x00007fa16fe8becd in VclGrid::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff4587c0, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:1406
        	#32 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fede7a40, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 20
        		nTop = -22893640
        		nWidth = 21896
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff4587c0
        		pAccLabelFor = 0x7fff8a2390d0
        		pAccLabelledBy = 0x68a2390a0
        	#33 0x00007fa16fe86709 in VclBox::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fede7a40, rJsonWriter=...) at libreoffice/vcl/source/window/layout.cxx:398
        	#34 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fea2abb0, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 32767
        		nTop = -1977380544
        		nWidth = 32767
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588fede7a40
        		pAccLabelFor = 0x7fff8a239148
        		pAccLabelledBy = 0x7fff8a239110
        	#35 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588feddd8a0, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 0
        		nTop = 2049803913
        		nWidth = 32673
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588fea2abb0
        		pAccLabelFor = 0x7fa16fcdc774 <__gnu_debug::_Safe_sequence_base::~_Safe_sequence_base()+28>
        		pAccLabelledBy = 0x0
        	#36 0x00007fa16ff6e15e in ToolBox::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588feddd8a0, rJsonWriter=...) at libreoffice/vcl/source/window/toolbox2.cxx:1713
        		childrenNode = {mrWriter = @0x7fa16fd6409c}
        	#37 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fee04430, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = -1
        		nTop = -1
        		nWidth = 1
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588feddd8a0
        		pAccLabelFor = 0x7fff8a2393c8
        		pAccLabelledBy = 0x7fff8a239390
        	#38 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588ff2738a0, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 32767
        		nTop = -1977379792
        		nWidth = 32767
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588fee04430
        		pAccLabelFor = 0x7fff8a239438
        		pAccLabelledBy = 0x7fff8a239400
        	#39 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fedbafd0, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 32767
        		nTop = -1977379680
        		nWidth = 32767
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588ff2738a0
        		pAccLabelFor = 0x7fff8a2394a8
        		pAccLabelledBy = 0x7fff8a239470
        	#40 0x00007fa16ffbcaba in vcl::Window::DumpAsPropertyTree(tools::JsonWriter&) (this=0x5588fedc2d50, rJsonWriter=...) at libreoffice/vcl/source/window/window.cxx:3388
        		childNode = {mrWriter = @0x7fff8a239520}
        		nLeft = 21896
        		nTop = 2045399353
        		nWidth = 32673
        		childrenNode = {mrWriter = @0x7fff8a239520}
        		pChild = 0x5588fedbafd0
        		pAccLabelFor = 0x7fff8a239520
        		pAccLabelledBy = 0x7fff8a2394e0
        	#41 0x00007fa170764efa in vcl::lok::dumpState(rtl::OStringBuffer&) (rState=...) at libreoffice/vcl/source/app/svapp.cxx:1868
        		props = {mpBuffer = 0x5588ff911780 "{ \"id\": \"\", \"type\": \"borderwindow\", \"text\": \"hello-world.ods - Collabora OfficeDev Calc 23.05 [ebacfb1a63566077eb10cbe53dfac8fac9da898f]\", \"enabled\": true, \"children\": [ { \"id\": \"\", \"type\": \"workwindo"..., mPos = 0x5588ff912c3c "", mSpaceAllocated = 8244, mStartNodeCount = 24, mbFirstFieldInNode = false, static JSON_WRITER_DEBUG_MARKER = 222 '\336'}
        		pSVData = 0x7fa171f3aea0 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance>
        		pWin = 0x5588fedc2d50
        	#42 0x00007fa179b08219 in desktop::LibLibreOffice_Impl::dumpState(rtl::OStringBuffer&) (this=0x5588fa5a7710, rState=...) at libreoffice/desktop/source/lib/init.cxx:5105
        	#43 0x00007fa179b08002 in lo_dumpState(LibreOfficeKit*, char const*, char**) (pThis=0x5588fa5a7710, pState=0x7fff8a239630) at libreoffice/desktop/source/lib/init.cxx:5086
        		aState = {pData = 0x5588ffa27670, nCapacity = 1048576}
        		pLib = 0x5588fa5a7710
        		aStr = {pData = 0x5588ff9bfd30}
        	#44 0x00005588f9b2e947 in lok::Office::dumpState(char const*, char**) (pState=0x7fff8a239630, pOption=0x5588f9bd5e4d "", this=<optimized out>) at libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:1149
        		pState = 0x0
        
        Change-Id: Icc5910238656566479ea0796c25779866ff8ec7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162794
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit f4fa41cefe2ede6edfa89fb098294cee598cf394)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [702f420ab39b89f568cb4a173286b307e5b9cabf]

        embindmaker: Handle enums
        
        Change-Id: I07e068e52df2a838e76f32e691d23a47d7fcfdda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162809
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Heiko Tietze  <tietze.heiko@gmail.com>  [788ebd183b095ffb7369c4d518acd14bad72ae82]

        Resolves tdf#159328 - Fix field shading regression
        
        Introduced by 4d7a98b582dc70bbffc78e6622969e218f108433
        
        Change-Id: Ibcc057e47c62d53dfa9e6410230c4b231df8551c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162799
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-31  Justin Luth  <justin.luth@collabora.com>  [19eeee25e13993806545552cc49da79a7bd6b990]

        related tdf#146756 chart2: code-readers documentation
        
        Sorely needed to avoid misconceptions.
        
        Change-Id: I9980bd2344f5f6db3fd1719476836b91803d7b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162609
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7938c1e88d02aa2b26e84cfeb5c99ebc77e50215]

        embindmaker: Handle new-style singletons
        
        Change-Id: Icb3b179c95e1af8b12772401f58d4f4cf181e585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162795
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [9884fa5bf4ce5413179d6a054a2d533fa829c13e]

        make drop-down-form-field dialog async
        
        Change-Id: Ic3c6111878271f31a07fab835501cd92cbca7950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8291b91f84930a8034093c94bf68b94babf9c391]

        make footnote-option dialog async
        
        Change-Id: I1f04b98ac8a804aa74b4b6be335c088649ef8547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162790
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [9667ea7e274c4e29cf7c35d9e124a8fbcb2af3da]

        curl: upgrade to release 8.6.0
        
        Fixes CVE-2024-0853
        
        Change-Id: Iabba0748f7c48ee03a8223aef9ca81bf379738e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162793
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [093ef8bf93adf93835ad2e2e43055d90d76a8376]

        Fix typo
        
        Change-Id: I7ab87d07d26dc6eb8c54f274955c4434e60c40c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162767
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [658d4d013a0f454cca3bc20a23f8f3133ea19151]

        Fix typo
        
        Change-Id: I7c61c8540ab9a9b5b2dafd901578fb7fd7fa85a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162796
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [077fa0a0d1d6389b03399e5aaafcd8ed2c4590bb]

        At least in its current form, embinding Any shouldn't need allow_raw_pointers
        
        Change-Id: Ib66df92c17768a05a402135729a75992b4b83d64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162789
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Justin Luth  <justin.luth@collabora.com>  [9833ac64c43b140233eca4ebb98e445a462425fc]

        tdf#146756 pie chart2 import: use consistent outside-label max text len
        
        This is a followup to commit 85f4395b6f40c0295a190cca09ecd51858fc3b31.
        
        Although there is no pressing need for this patch in my opinion,
        it DOES fix a 7.1 regression in importing MSO charts with long labels.
        MSO wraps text at 1/5 the width of the chart.
        
        7.1 Regression commit 75a8b367f2a06e0d485fc2b9f4472e8bb29d71e3
        Author: Balazs Varga on Tue Aug 25 12:32:02 2020 +0200
            tdf#136105 tdf#134883 pie chart: improve data label position
        
        Before Balazs' commit, the text width for everything was simply
        fTextMaximumFrameWidth = 0.8 * fPieRadius.
        
        I personally think Balazs' no wrapping looks better
        (for outside labels, when there is enough space)
        but in order to be consistent with how we handle
        wrapping for bestFit-that-didn't-fit labels,
        and to have our charts be as interoperable with OOXML as possible,
        it makes good sense to use the same logic as the previous patch here.
        
        Interestingly, Balazs broke some unit tests that specifically
        were testing to make sure that text wrapping existed.
        
        Fixed: // text wrap: wrap all text labels except Yellow one
        make CppunitTest_chart2_xshape CPPUNIT_TEST_NAME=testPieChartLabels2
        
        Fixed: // text wrap: wrap no text label except Yellow one
        make CppunitTest_chart2_xshape CPPUNIT_TEST_NAME=testPieChartLabels3
        
        Interestingly, I couldn't just copy/paste Ctrl-F12 dump to fix
        make CppunitTest_chart2_xshape CPPUNIT_TEST_NAME=testPieChartLabels4
        so I instead did a copy/paste of SAL_WARN("DUH",getXShapeDumpString());
        
        Change-Id: I19f2ce2ce9c7653ae92dd596f0aaca1ed83f41bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162764
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-31  codewithvk  <vivek.javiya@collabora.com>  [b39c6082aa975ed8e5696c3dc24c3025ed07bbb6]

        Implement Async AutoCorrectQuery Dialogs for Formula Check in calc
        
        Key changes include:
        
        1. Decomposition into Four Methods: The core logic of formula processing `ScViewFunc::EnterData` has been divided into four distinct methods: `parseAndCorrectFormula`, `runAutoCorrectQueryAsync`, `finalizeFormulaProcessing`, and `performAutoFormatAndUpdate`. This modular approach improves code readability and maintainability.
        
        2. Introduction of `FormulaProcessingContext` Struct: To manage the complexities of asynchronous behavior and parameter passing, a new struct `FormulaProcessingContext` has been introduced. It acts as a central state holder, ensuring parameter persistence throughout the asynchronous operations and avoiding scope-related errors.
        
        3. Recursive Dependency and Loop Replacement: The methods `parseAndCorrectFormula` and `runAutoCorrectQueryAsync` are interdependent and recursively call each other. This recursive strategy effectively replaces the previous `do while` loop in the code, streamlining the process of formula correction.
        
        4. Asynchronous Dialog Invocation: The `runAutoCorrectQueryAsync` method now handles the asynchronous triggering of AutoCorrectQuery dialogs. This change significantly improves the user experience by preventing UI freezes during formula processing.
        
        Overall, this commit achieves the goal of making AutoCorrectQuery dialogs asynchronous while refactoring `ScViewFunc::EnterData` for better code structure and performance.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: If159b98d54c0eaed41789eca7913a929b1e19c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a830a34d6d21656d00996c002b0dedf37b7545c0]

        move SvxNumberingPreview out of cui
        
        the point of cui was to have no headers, so move this
        SvxNumberingPreview out of cui and into svx
        
        Change-Id: I83edbcdc8d8b95dbea734bdef4a93f6ec8ee50e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3a48ad467b7fbf9cbdfff1222e08c02b0ff5d544]

        use ViewShell DOCCOLOR when available
        
        for fallback, continue to warn if the terminal fallback gets used,
        but fill stub it to return the application DOCCOLOR
        
        Change-Id: I2bf3a1c6c6adb58811fd36c70f93932de246f10a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162782
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2b1f5fa987f02ec8014dbf6837c6b090faf11f2d]

        tdf#159307 Let non-URIS_ONLY execute() handle .app directories on macOS
        
        Change-Id: I873daed9347b5e5bee4a630474438fce2cc73fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162768
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e4cf6c324cd7491444576ee57d60475d0c4f239c]

        Embind in-out/out params of primitive type apparently need a wrapper
        
        > let translit = css.i18n.Transliteration.create(Module.getUnoComponentContext());
        > let match1;
        > let match2;
        > let eq = translit.equals(new Module.OUString("test1"), 0, 5, match1, new Module.OUString("test2"), 0, 5, match2);
        > console.log('match ' + eq + ', ' + match1 + ', ' + match2);
        
        caused an uncaught UnboundTypeError with message "Cannot call
        uno_Type_com$sun$star$i18n$XTransliteration.equals due to unbound types: Pl", so
        use
        
        > let translit = css.i18n.Transliteration.create(Module.getUnoComponentContext());
        > let match1 = new Module.UnoInOutParamLong;
        > let match2 = new Module.UnoInOutParamLong;
        > let eq = translit.equals(new Module.OUString("test1"), 0, 5, match1, new Module.OUString("test2"), 0, 5, match2);
        > console.log('match ' + eq + ', ' + match1.val + ', ' + match2.val);
        > delete match1;
        > delete match2;
        
        instead
        
        Change-Id: Ic5a0a9e37e884817158069702510eab0d29adefa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162784
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [f7039822c7ad3987326e1c20ea4a745c158f9682]

        tdf#127293 Add Excel2021 function XLOOKUP to Calc
        
        https://issues.oasis-open.org/browse/OFFICE-4154
        
        What is working already: xlookup with normal forward,
        backward search in columns/rows. Binary search in rows with
        real binary search algorithm, in columns only works with linear search yet.
        Linear forward backward wildcard/regex search in columns/rows.
        Looking for the first smaller or greater value with linear and binary search
        ALso all the combination of all these options. Except XLOOKUP
        not supperted wildcard/regex search with binary search.
        
        TODO in next patches:
        - add the binary search option for searching in columns.
        - Evaluate Formula calculation not working in general.
        
        Co-authored-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        
        Change-Id: I15fd4479b63ec13b093d269760d1bbb5957553e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131905
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-01-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8cccfc82a3038bc28864ae9e94418a141b4aa545]

        Revert "store last five MRU currencies in the currency drop-down"
        
        This reverts commit dc6b93011cc5435f367666e43e354c6ab97bbc90.
        
        Change-Id: Ia56cb2e906303d6d59061df3e21954306bee2298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162754
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-31  Miklos Vajna  <vmiklos@collabora.com>  [4253acd5300c526b062fc5b5f109e93e6e9d08df]

        CppunitTest_sw_ooxmllinks: avoid DECLARE_LINKS_EXPORT_TEST at one place
        
        Reduce the amount of code that's inside the macro body, and then no need
        go via Writer-specific macros.
        
        Change-Id: I6a09754f04e3103195b0ca585c820ddc98efd4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162787
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-31  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9c416f6704a2b80b31b73104174f13c5294fbd61]

        Embind clean up, only pass in-out/out params by raw pointer
        
        Change-Id: I141d3aace7b76182fe464626bbb8a336c8ec6a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162783
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [942e9a79f066a26276e299660ba56874874841c6]

        Related: tdf#159458 Move variable URL re-creation to a central place
        
        Change-Id: Ib73ae476f308b2579a15c9b2474a55e3558c134c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162786
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [907d4107896234b2e7ebfd42f40cee3bd5b1d01e]

        tdf#159458: make sure to update unexpanded URL when renaming library
        
        1. If passed new source URL is expanded (i.e., trying to expand it in
        SfxLibraryContainer::checkStorageURL didn't change it), previously
        aUnexpandedStorageURL was unchanged. It should be cleared - then it
        will be set automatically to the URL to lib info file.
        
        2. Try to create the "variable" path (starting with "$(USER)/basic/")
        because this avoids absolute paths to the libraries, which make it
        harder to move the profile.
        
        Change-Id: Ie83ea9a32cfddf37727d238547663aeb72487ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dfcdef6d94993131b5f150d00d08cc81a987eebb]

        Fix typo
        
        Change-Id: I384f3c97286a5b336d44df42e911870100542198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162766
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9f236a078cd179835b8c651990e3afecee6170ca]

        Pass the_self by const ref in Embind wrapper functions
        
        Change-Id: Ie8bfec2a9fdd5f126fd2879d2ba06f1fa5c1019e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162781
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9a982f8cb62da5a82ae1426aa40900dd360c93b5]

        Embinding OUString shouldn't need allow_raw_pointers
        
        Change-Id: I92608ebe4edf65c7de96587aa39e990fb09c3e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162779
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1b371a4e1fac86fb483a7e62225e130d3684bb59]

        embindmaker: Handle new-style services
        
        Change-Id: I41309a20666c17f0c8c8d456943b3c78d0273905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162772
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4a806d6b02fcfa795dd4c47932e98f9fbc1b8ca8]

        Expose comphelper::getProcessComponentContext through Embind
        
        Change-Id: I8b2cec04a1ffb99c33d39d8a63aa67778e960ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162773
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ed16c7fbdce8bf22d32d2a2b3d250e382ea404d9]

        Resolves: tdf#159386 deref of null result of Clone
        
        Change-Id: I8e903a20bd28c778a39418bc89e42ae1c6932dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7e0a4322147892021f3d93fb8de23ed293d575a7]

        embindmaker: Handle interface inheritance
        
        Change-Id: I81e66666f8a60bd34a9a3807adfb15c341303b9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162771
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Rene Engelhard  <rene@rene-engelhard.de>  [82e90e1b2a8873334f1fcd00dde769e45af37b5b]

        add hy to bin/lo-xlate-lang
        
        Change-Id: I1205da81fc179affa58478860928e74a501d4c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162644
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b01a9f8c9da419969575d0dc20e7346306ae96d3]

        tdf#151352 keep a reference to the parent
        
        and use that in the dtor instead of a pointer.
        
        FWIW the XWindow isn't actually a vcl::Window in the Gtk case, so
        VCLUnoHelper::GetWindow doesn't do anything there. But using an
        XWindow gives a safe view wrt life cycle.
        
        Change-Id: I4d0fd707ea931a76d6f87f434f7ece8df066785c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162744
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [84572ef8c27fc4d4a7720303972f877ed2db8f79]

        make redline-accept dialog async
        
        Change-Id: Ib0cd3145b1f2d12926c1c17335551f0ba576bd7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162763
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f5dd47de9c0dc9e95980fa08b4358aa9228c5c0]

        make outline-tab dialog async
        
        Change-Id: Ie4fd5e9893af6687230bc2a02d4459a1140d0e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [95dc399434ea08b7c762f918d0c6360ef3e0e179]

        make set-row-height dialog async
        
        Change-Id: I03e27c09da4f8b58468d4e551413946f03b25f1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162761
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7bd438c42c8c7f80bfdb99d53aac9674b5ae0a3e]

        convert insert-footnote dialog to async
        
        Change-Id: Iea3cb8fe1486c229b5441574b1de9b81758bc251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b70d96db53085bdd4e66c22857590d5b2cd391f9]

        make sorting dialog async
        
        Change-Id: I9773ec07e13144662a06307452b17f9e96527e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c91faacfb7dd26fe7b7c93c7af5d4c330779a59f]

        make auto-format dialog async
        
        Change-Id: Ibef42bed3448e466877608c165131a806068f5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162758
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4e5aa7bffc32aa15359808085cc69638467f5d5]

        make glossary dialog async
        
        Change-Id: I7ed5da9e06656bc658728b8e61b02f767ddd6bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noelgrandin@collabora.co.uk>  [21dd07f95d7dcb95f243753306108c18d9ba115a]

        tdf#159131 Calc is laggy when moving a line (row)
        
        revert 	69910b540ae5140123fd2d4d67a9d338f980db53 and
        add a couple of pre-emptive reserve calls, to prevent repeated
        resizing.
        
        I'm not sure why the above commit causes trouble on Windows, but
        not Linux, something in the std::vector::reserve implementation
        no doubt.
        
        Change-Id: I858303a0a1e12d204fd3bbccc6c6c7ce57564e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Miklos Vajna  <vmiklos@collabora.com>  [256e2c679bcbb3ea446884d0ff4e3f8687b82ede]

        tdf#159452 sw content control, PDF export: fix checked checkboxes
        
        Regression from commit 9bad5be0ffdcdee92d40162b598ed2ab2815e5d5 (sw
        content controls, checkbox: add PDF export, 2022-09-13), we used to
        export checkbox content controls as plain text, but once checkbox
        content controls are exported as forms, the state of the checkboxes are
        lost.
        
        Writer content control checkboxes support custom values for the checked
        and unchecked states, but the PDF export does not. On one hand,
        PDFWriterImpl::createDefaultCheckBoxAppearance() assumes that the
        checked state should be a checkmark, not the Writer default 'BALLOT BOX
        WITH X' (U+2612). On the other hand, the PDF spec section 12.7.4.2.3
        "Check Boxes" says that the checked state should be "Yes", which
        explains why our checked state is not recognized by PDF readers.
        
        Fix the problem by making the export of checked/unchecked states
        conditional in SwContentControlPortion::DescribePDFControl(): the
        checked state then shows up as expected.
        
        Leave the unchecked case unchanged, the current markup there doesn't
        cause problems.
        
        Change-Id: I9063d8607c8cccfa080921af38b3cbfe40905115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162765
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-30  Mike Kaganski  <mike.kaganski@collabora.com>  [1d7ce421480d9170316533de03feb8d04eb5c767]

        tdf#159438: when there's no frame, close previous bookmark first
        
        Commit 260d6cc6471444b4ef20ed6673831b0b12f96333 (INTEGRATION: CWS mtg2
        (1.30.120); FILE MERGED, 2005-12-21) for #i58438# made sure to process
        previously opened bookmarks that close at this node, before opening
        the bookmarks that start here.
        
        Commit 76a4305d1e90b6617054dd33036e64f005dbcf04 (sw: fix inconsistent
        bookmark behavior around at-char/as-char anchored frames, 2017-12-21)
        re-introduced the problem accidentally: it only intended to handle
        case when there is an anchored frame here.
        
        This change re-instates the correct order (close bookmarks first; then
        process collapsed ones; then open new bookmarks) in case there's no
        anchored frames here.
        
        To avoid a problem when a non-collapsed bookmark starts and ends at
        the same point (e.g., its text was deleted), it gets converted to
        collapsed in lcl_FillBookmark. Thus, testRemoveBookmarkText was fixed
        in sw/qa/extras/uiwriter/uiwriter4.cxx. There is no reason to keep
        the separate -begin/-end elements, especially since on the following
        open/save round-trip, it will become collapsed anyway.
        
        Change-Id: Ib555a76f6f776001e12908a1299c24eebf591f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162743
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0cba60a3eaa5b6474614e892e63ff5b3fbbbf0d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce038f5272404277555b8faa9f366e9e484e6105
          - Update link to teasing video for master
            
            Change-Id: Iaa1d4a1729945d9a6cbf658bfac8071db6f02bfb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162723
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d26ca7f9ac37b5ada0a2c463b37181bcc8301a8]

        tdf#158695 convert-to bogusly needs libcui (--disable-gui build)
        
        Change-Id: I8e13902c4ee9b4b17e921b68b0626f7728cb0c18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [a08110be32a6958f27ce9ddb1e2cb2227265dfe1]

        convert table width dialog to async
        
        Change-Id: Id8fe4f8f0e3138b714aeb938f887483dab1214a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [93c4bfc96acf7f387120ff05883068d358a608c1]

        make writer databases dialog async
        
        Change-Id: I9f3c3bc3c555ef8a115258ff6d186ceeead3cc99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162556
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cd3286cdc79765229d3e58ed35b3866baca9da18]

        cid#1588084 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1591435 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iad16a56259b01a67baf1f9ed879c27d3a648b879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [43dcd82624a26d7c3a4185469bef60f531999190]

        reuse xCurrentFrame instead of fetching it again
        
        and use the exception safe vcl::CommandInfoProvider::GetModuleIdentifier
        wrapper.
        
        might as well skip the TOTD for the database report as we as the form.
        
        Change-Id: If91f571d64878a7bab85b97800d3c60c1397dc2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Szymon Kłos  <szymon.klos@collabora.com>  [650d65326627a5cfd5dd59f0876a22583bc52d3f]

        jsdialog: enable paste special in calc
        
        to test:
        - copy few cells in calc
        - ctrl + shift + alt + v
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Iac3a98c50355e2390a36195ba92ef25a30d73e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162673
        (cherry picked from commit af171cd8ca13cfc6d530abc89c7c3b85d0204628)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162712
        Tested-by: Jenkins

2024-01-30  Julien Nabet  <serval2412@yahoo.fr>  [dd5e179f0fd7c9bf37872acf53301be28bb71cfc]

        tdf#159288: Assertion on insert trend line
        
        5  0x00007fd6780533a2 in __assert_fail
           (assertion=0x7fd66de41177 "ImplGetSVData()->mpDefInst->GetYieldMutex()->IsCurrentThread() && \"SolarMutex not owned!\"", file=0x7fd66df2c58b "/home/julien/lo/libreoffice/vcl/source/app/dbggui.cxx", line=35, function=0x7fd66de5d0c6 "void ImplDbgTestSolarMutex()") at ./assert/assert.c:101
        6  0x00007fd66f0dd6a2 in ImplDbgTestSolarMutex() () at /home/julien/lo/libreoffice/vcl/source/app/dbggui.cxx:35
        7  0x00007fd677522f10 in DbgTestSolarMutex() () at /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:54
        8  0x00007fd66f3aea88 in ImplFontCache::GetFontInstance(vcl::font::PhysicalFontCollection const*, vcl::font::FontSelectPattern&) (this=0x564a8f77e0c0, pFontList=0x564a8f7783d0, aFontSelData=...)
           at /home/julien/lo/libreoffice/vcl/source/font/fontcache.cxx:117
        9  0x00007fd66f3ae987 in ImplFontCache::GetFontInstance(vcl::font::PhysicalFontCollection const*, vcl::Font const&, Size const&, float, bool)
           (this=0x564a8f77e0c0, pFontList=0x564a8f7783d0, rFont=..., rSize=Size = {...}, fExactHeight=12, bNonAntialias=false) at /home/julien/lo/libreoffice/vcl/source/font/fontcache.cxx:111
        10 0x00007fd66eb905f6 in OutputDevice::GetDefaultFont(DefaultFontType, o3tl::strong_int<unsigned short, LanguageTypeTag>, GetDefaultFontFlags, OutputDevice const*)
           (nType=DefaultFontType::CJK_SPREADSHEET, eLang=..., nFlags=GetDefaultFontFlags::OnlyOne, pOutDev=0x564a8f6bfca0) at /home/julien/lo/libreoffice/vcl/source/outdev/font.cxx:573
        11 0x00007fd62e86669d in chart::CharacterProperties::AddDefaultsToMap(std::__debug::unordered_map<int, com::sun::star::uno::Any, std::hash<int>, std::equal_to<int>, std::allocator<std::pair<int const, com::sun::star::uno::Any> > >&) (rOutMap=std::__debug::unordered_map with 19 elements = {...}) at /home/julien/lo/libreoffice/chart2/source/tools/CharacterProperties.cxx:358
        12 0x00007fd62e951686 in (anonymous namespace)::GetStaticRegressionEquationDefaults()::$_0::operator()() const (this=0x7ffe3f9b6b80)
           at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:121
        13 0x00007fd62e9500e7 in (anonymous namespace)::GetStaticRegressionEquationDefaults() () at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:117
        14 0x00007fd62e94ff98 in chart::RegressionEquation::GetDefaultValue(int, com::sun::star::uno::Any&) const (this=0x564a90aa2870, nHandle=4, rAny=uno::Any(void))
           at /home/julien/lo/libreoffice/chart2/source/tools/RegressionEquation.cxx:196
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=192072
        
        Change-Id: I8048b9a69761dba618ef556335c2cadab6647627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162737
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Matt K  <mattkse@gmail.com>  [a2c09afebef70d2419823445ff92379fe3df9485]

        tdf#151352 Don't display tip-of-the-day in base form editor
        
        The problem is that there is some crash with tip-of-the-day
        on Linux with GTK3 when opening a base form for editing.
        The fix is to avoid showing the tip-of-the-day for base
        form editor, as suggested in the bug comments.
        
        Change-Id: Ic155e137c4314b7e014f09d83589519197bd0039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Dione Maddern  <dionemaddern@gmail.com>  [d78ffdcbd8b5831334bdb9f6905f78216c1a08ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to db52077958de6c790e772b7503b790d47db614f8
          - tdf#155877 Fix broken links in Page menu help pages
            
            Added HID Bookmarks to:
            "text/simpress/01/04110100.xhp"
            "text/shared/01/05040200.xhp"
            so that pressing F1 opens the correct help page
            
            Change-Id: Ibcd7d983ce9fa31a488cba5261a45a9b1e437e51
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162530
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4791c04c06711320a83b02b99a7fb7635fabd48e]

        Missing include (incomplete type 'AquaSalGraphics')
        
        (no idea why that only started to hit me now)
        
        Change-Id: I4438af3279f71335bd4644dbd17f4fbeb7296e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162735
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Dione Maddern  <dionemaddern@gmail.com>  [e2ac593f06d7fc4f0b8f65524a058cd37a044d88]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c890c7f7ee6957bdda92dc84b7c6ca3a2ae37d6
          - Update "howtoget" information for "Minimal Row Height"
            
            Edit /text/shared/00/00040500.xhp so that the menu path to access for "Minimal Row Height" from menubar reflects the current menu options in Writer.
            
            Change-Id: Icc6bcb0eaf4afd2b72886fa47930e478791f4cf6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162627
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [24a3f8269e427875fbe8013f88e83fc41b90b33a]

        tdf#159384 - A11y: fix simulated numbering warning in TOC
        
        Do not complane about simulated numbering warning in TOC
        if its contains a list with numbering.
        
        Change-Id: Ib6a10d18d19cc9cb44ffd5b79e2106af457985d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162707
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-30  Méven Car  <meven.car@collabora.com>  [e785ee257a44bd406909ef012bddde29a1fe3f0d]

        LOK: exposed time formatted field as time fields
        
        Change-Id: Idf7613b9141c55372e19199b5641719ba42e43ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162598
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2de4572fdff7364c98fd7c9440c4cf132206031d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Justin Luth  <justin.luth@collabora.com>  [85f4395b6f40c0295a190cca09ecd51858fc3b31]

        tdf#146756 pie chart2 import: improve response to bestFit failure
        
        Fixes a 7.2 regression from
        commit b0068342398786ca50304260434a18880dddf74d
        author Tünde Tóth on Wed Dec 16 18:26:26 2020 +0100
        tdf#138777 pie chart: improve long data label width
        
        When a label fails to bestFit inside the pie slice,
        it will be placed outside of the pie of course.
        However, we can't assume that there is any chart space
        available to place a label outside.
        
        Tünde got that part right. He limited the space available
        based on the chart edge. But there are some optimizations
        that can improve that.
        
        1.) Every little bit can help. As we go away from the
        X-axis, we gain a little bit of space, so use that...
        2.) Don't assume that the pie chart is in the middle of the page.
        3.) Use a consistent algorithm for all degrees - much simpler.
        
        make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testTdf146756
        
        Change-Id: I0d8528bc227768f91237cda6b74bf9365820bfa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162704
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-30  Justin Luth  <justin.luth@collabora.com>  [a77403d11a60ebe6aeb33d9b6ae611412d9ab1cc]

        tdf#146756 pie chart2 import: use manualLayout Width for pie chart labels
        
        ... and use a compatible 1/5 width if not specified.
        
        This patch depends on the previous oox patch
        (commit 301e27cbebf7d6e4c9b82290d7cd555c43f0c999)
        which actually reads the width into the model.
        
        Fixes a 7.2 regression from
        commit b0068342398786ca50304260434a18880dddf74d
        author Tünde Tóth on Wed Dec 16 18:26:26 2020 +0100
            tdf#138777 pie chart: improve long data label width
        
        and is basically a re-write of 7.1's
        commit 20da1a5dd37c7edac620566c992d5a53b23a5f12
        author Tünde Tóth <toth.tunde@nisz.hu>	on Fri Oct 09 09:24:18 2020 +0200
            tdf#134978 Chart OOXML Import: fix pie chart label custom position
        
        This is very risky, but then ANYTHING changing chart2 is risky.
        There were a lot of changes made in 7.1,
        and they all invited regressions.
        However, our chart implementation is not in a good state,
        and certainly is not very interoperable,
        so it is worth taking the risk.
        
        Anything dealing with manualLayout at this point
        should have originated as a pptx,
        so forcing a compatible max width should be fairly safe.
        
        It probably isn't actually all that risky after all.
        
        largely copied code from
        commit 4223ff2be69f03e571464b0b09ad0d278918631b
        Author: Balazs Varga on Wed Jan 15 16:31:35 2020 +0100
            tdf#48436 Chart: add CustomLabelPosition UNO API property
        
        Fortunately this all goes away after a round-trip
        since custom label placement is lost on export to OOXML,
        and that really helps to reduce the risk.
        
        make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testTdf146487
        
        Change-Id: I9722fc6c759c15ac3924780e6fc124f02fba07e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162590
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-30  Michael Stahl  <michael.stahl@allotropia.de>  [2048db4dc8ee6edb231a9109257846975a6f7834]

        tdf#105844 unotest,xmlsecurity: fix tests on MacOSX
        
        The new tests fail with:
        
        > core/xmlsecurity/qa/unit/signing/signing2.cxx:
        > 252: Assertion
        > Test name: testPasswordPreserveMacroSignatureODFWholesomeLO242::TestBody
        > equality assertion failed
        > - Expected: 1
        > - Actual  : 4
        
        This is because only the first test that runs sees the testing CA
        certificates that are copied in MacrosTest::setUpNssGpg(); when the
        second test runs, they have somehow vanished.
        
        This is because apparently SQLite on MacOSX, unlike on Linux, monitors
        the file descriptors of its database files, and then invalidates itself
        when setUpNssGpg() via osl::File::copy() renames and unlinks the
        existing database files:
        
        > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode renamed while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp
        > cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x20)
        > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode unlinked while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp
        > cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x11)
        > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode renamed while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp
        > cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x20)
        > cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by API violation: vnode unlinked while in use: core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp
        > cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x11)
        
        Split MacrosTest::setUpNssGpg()/tearDownNssGpg() into functions
        setUpX509() which only does something on the 1st invocation, and
        setUpGpg()/tearDownGpg() which may be invoked per-test (they could also
        be run once for the whole test suite, but not obvious how to do that);
        PDF related tests don't need GPG.
        
        Presumably this is (along with the WNT-specific problem fixed in commit
        3e9a700091872480dd085f0928d1d30b7d74cfd7) the reason why most of the
        tests not only accept the expected result of SignatureState::OK but also
        SignatureState::NOTVALIDATED.
        
        Change-Id: I59b85ca651cecaccfdea729ed1e645c53079c8bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162693
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-30  Miklos Vajna  <vmiklos@collabora.com>  [af15f8b7f346898677f1eee6521a6be1ff63eb56]

        tdf#159107 sw floattable: prefer inline table in footnote with change tracking
        
        Writer doesn't really support tables in footnotes, see the warning at
        the top of SwFlowFrame::MoveFwd(). Still, there is some initial support
        for them, since commit 11c51eefe8c3210cef2b5850f401ba67a401d01
        (tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes,
        2021-03-28).  Similarly, redlines really just track insertion and
        deletion, but some initial support for table operations were added in
        commit eebe4747d2d13545004937bb0267ccfc8ab9d63f (tdf#144270 sw: manage
        tracked table (row) deletion/insertion, 2022-01-12).
        
        The combination of these is a bit fragile, but the bugdoc happened to be
        imported as an inline table (in a footnote, with recording changes)
        before commit d477fa8ac1b0d3ee81427217bbb5950278ab16db (sw floattable:
        unconditionally map <w:tblpPr> to SwFormatFlySplit, 2023-03-17).
        
        Fix the problem by explicitly importing floating tables as inline in the
        footnote + redline case to restore the working use-case.
        
        DOCX import of this combination can be enabled again once Writer layout
        works for the produced model.
        
        Change-Id: I9cd0a1fabb9807f5117cb5a36ec8597d6646eece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162733
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b1af5dc4f342e4d5fcae8d4c021b6369d6544ea7]

        Revert "sc lok: don't set the GridWindow size to document size"
        
        This reverts commit 7bc36867e84f7b9ad091d320b5520d5bb6c287e4.
        
        Change-Id: Ibc784cb691cd38ea8d18f27acac55f8e04a065f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162731
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [74ee046a04d6893db5b772f8f4219f7db413fbb8]

        lok: introduce NotebookBarViewManager and NotebookBarViewData
        
        NotebookBarViewManager is a singleton which is responsible to hold
        NotebookBar view specific data, which is kept in NotebookBarViewData
        class. The idea is to have one NotebookBarViewData class instance
        per one view (SfxViewShell instance).
        
        This also refactors the existing code and now moves the
        m_pWeldedWrapper, m_pNotebookBar and the m_pToolbarUnoDispatcher
        into NotebookBarViewData class.
        
        Change-Id: I32f5954fa9f1628acd9f5f9bd5760ac23ca687ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162706
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1729753193f4f2c69f45b4377a557cceeb72070]

        just get SfxViewShell::Current once
        
        Change-Id: Ie4d86076af63b68c7ae61570ce8e2b9ce8509e50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162690
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-30  Mike Kaganski  <mike.kaganski@collabora.com>  [e9e1411e4e5948e98d80cc25b2834b7c9d60a8c4]

        Make sure to only dynamic_cast once
        
        Commit 3078020b07e41a6533ba71755d8cc8095bc3c3a7 (sw34bf04: #i109272#:
        SwXTextPortionEnumeration: fix CrossRefBookmark handling 2011-03-01)
        moved the dynamic_cast to the general case in lcl_FillBookmark. Later,
        commit 9b01059f6e2143c5b5b481f3d321309648fc7dd4 (SwXTextPortionEnumeration
        ctor: avoid dynamic_cast in the common case, 2014-10-28) split it into
        two: for bookmark start, and for bookmark end. Both will happen, when
        the bookmark is fully inside the node.
        
        This makes sure to only dynamic_cast once, and only when necessary.
        
        Change-Id: I3b88504b0cd21a644cf9933143312a4fb570b27a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162732
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [589f3c68baa2db69e0795020fdd60926526b2f4a]

        improve docs of XSystemShellExecute
        
        copied from a comment by sberg
        
        Change-Id: Ia363bac0a115564265ca9169174fdfc0d8610a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162685
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-30  Szymon Kłos  <szymon.klos@collabora.com>  [37e81fcc16127c43b3cd7e89d82a362cfc15d227]

        lok: notebookbar: fix number format field
        
        - number format filed is inside different container in online
        - make it working again by putting into standalone
          sfxlo-NotebookbarToolBox
        
        Change-Id: Iecf85aad598cc5a68b5128e32f27818f2b372d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162683
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162705
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-30  Szymon Kłos  <szymon.klos@collabora.com>  [16890dc78a69146d16e672e718148f462d63f587]

        lok: notebookbar: enable currency dropdown
        
        Add .uno:NumberFormatCurrency item to .ui
        Use weld:: way of widgets creation so we can inject
        jsdialog code and popup will be correctly registered.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ib57e1cad617ca5c7198d67e107441ba062580f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162710
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [27ceca1996809c0f9390d1e9fb95dc7436ef1acf]

        Rework the Embind mapping of UNO interfaces
        
        ...to make use of the automatic finalization clean-up of smart pointers
        available with recent versions of Embind (so that explicitly calling delete() on
        them should largely be optional now).  See the changes to static/README.wasm.md
        for how code should look like now.  (The Module.uno_Reference.FromAny dummy
        argument for the interface constructor converting from an Any is only necessary
        to distinguish it from the other constructor, as otherwise Embind complains
        because:  "Overload resolution is currently only performed using the parameter
        count, not actual type info!")
        
        Change-Id: Ia8a8c12e38af1093948bf8a20ecd31aa6591e912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2df1dcc324c67d2205f0ff86378f07e2eeddc1b2]

        Some renaming of generated identifiers
        
        uno_Type_com$sun$star$... and uno_Reference_com$sun$star$...
        
        Change-Id: Ibc19f423a60c521c376172807b4d5a34cf0179a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [32ef7cea779ccea9b24ab4776f3069d3a80dd7ed]

        tdf#159307 Fix GetCertificateManager
        
        ...which had always cut off an existing path ever since
        92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f "Allow selecting a custom certificate
        manager", for reasons that are unclear to me.
        
        So if an existing setting contains at least one slash (or backslash, on
        Windows), try to use it as-is; otherwise, keep searching for it in aPath.  (And,
        in any case, make sure to report back the given value in sExecutable.)
        
        Change-Id: I8b2b6ac7a449d7afd02e029ff46d4c79e6b824e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162703
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-30  Mike Kaganski  <mike.kaganski@collabora.com>  [6159b8d223a395b01c090daa071cc13ca6013dc4]

        Add SAL_LOPLUGIN_ANNOTATE to cpp.hint
        
        Allows Visual Studio to recognize names with this decoration
        
        Change-Id: I787e20322ef346d49f94e23e7ac889d669c1245c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162709
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4f09826f731d5ecfc1ed094e2f9e720071b1e58d]

        Fix typo
        
        Change-Id: I9f090d5b38e039b8c3fbb8e5a66190d686a8dccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162702
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c06355ad4a0ee177984974e9c7578127538f01a8]

        Fix typo
        
        Change-Id: I8b7a0eb27678d96ed8ee0bdd268621a49ab72db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162701
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [985cce64903f7e01b15e0748194683b8e4531c62]

        resave with latest glade
        
        Change-Id: Ia2de2ad1ccc16e0212e4c1be2df2f6958c490da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162686
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [313836d19f46d0e046d1c2b8c593727b0b0192ea]

        LanguageTag ctor can canonicalize against various known tags
        
        so can optimize skipping the _lt_tag_canonicalize path which ends up
        using a fairly expensive xmlXPathEval
        
        Change-Id: Ie96f16482d247f3731c1c8eac6d613736b8b289a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162596
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b476dccd11a1f9d7f39876ad23dd3e14c6671909]

        Experimental support for latest Emscripten (and Qt6)
        
        What I'm after in the context of our Embind-related code is the claim at
        <https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#memory-management>:
        "JavaScript only gained support for finalizers in ECMAScript 2021, or ECMA-262
        Edition 12.  The new API is called FinalizationRegistry and it still does not
        offer any guarantees that the provided finalization callback will be called.
        Embind uses this for cleanup if available, but only for smart pointers, and only
        as a last resort."  However, with the recommended emsdk 2.0.31 my tests did not
        show any use of that finalization support.  So I wanted to try with the latest
        emsdk 3.1.51 instead.  But then, linking vcldemo failed with
        
        > wasm-ld: error: ~/allotropia-qt5/lib/libQt5Core.a(qlogging.o): undefined symbol: std::__2::__vector_base_common<true>::__throw_length_error() const
        
        etc., so I gave it a try to rather build against latest Qt6.7, with
        
        > --with-distro=LibreOfficeWASM32
        > --disable-qt5
        > --enable-qt6
        > QT6DIR=...
        
        TODO: The result is highly experimental, and it uses ENABLE_QT5 (i.e., the
        recommended setup with emsdk 2.0.31 and the
        <https://github.com/allotropia/qt5.git> v5.15.2+wasm branch) vs. ENABLE_QT6
        (i.e., my experimental setup with emsdk 3.1.51 and the
        <https://github.com/qt/qt5.git> 6.7 branch) not only to distinguish between Qt5-
        vs. Qt6-specific behavior, but also to distinguish between old- vs.
        new-Emscripten-specific behavior.  Of note:
        
        * The startup code appears to have changed substantially (and required setting
          -s MODULARIZE=1 and -s EXPORT_NAME=soffice_entry now, and telling emcc to
          build just soffice.js and not the wrapper soffice.html.  TODO: This also
          required hacking into qt_soffice.html:  (1) The command-line arguments
          (--norestore, --nologo, --writer, and the exammple.odt; all of which we should
          eventually get rid of, anyway).  (2) Saving the generated instance as
          window.Module (and adapting the embindmaker-generated code, cf. the changes to
          static/README.wasm.md).
        
        * There were some symbol clashes between external/argon2 and
          libQt6Core.a(qcryptographichash.cpp.o, so renamed the problematic symbols in
          external/argon2.
        
        Change-Id: I5420ab566d560b11954ac6613249bfc53d8acb31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [289afffaecf18b2cc5b032fed169a9131dc4c1ac]

        make chart-source dialog async
        
        Change-Id: If33d2bc57d5c79d3204079b9858a488e7d92e968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162689
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [92ba909fe8d9d1d1237571686e165c0a26def51d]

        extract SID_CHART_ADDSOURCE code into another method
        
        Change-Id: Ia1d4023e636dc26187cebcdfca12c337339f1cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [93939460ee79586a6c6d3f9c32f6c893146f7abd]

        make calc style dialog async
        
        Change-Id: I2e4bd1e88f5b6dc155d02db234d846e3f1dfd8c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162513
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12d1c9a7000ac9bc816852d658562bb2c0de6bb1]

        use existing timer to refresh notes later
        
        Change-Id: Ic91b8930216b4099ed8af0265497120f9aad0917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4d44e38de2b4a592a03f1985e25483189cc7542]

        reserve a TaskPriority for testtool IdleTask
        
        Change-Id: I1fbd77cdeb643123afbb8bbdbd1ca38949e1b547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162671
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-29  Matt K  <mattkse@gmail.com>  [4eaa50802d724b8744218c8993364fe7b6f03eaa]

        tdf#154863 Fix crashes when moving images in a large document
        
        The problem is that when moving images around the code tries
        to do things with anchored text frames that have already gone
        through destruction.  The fix is to check if those frames have
        the destruction bit set before using them, thus avoiding the
        crashes.
        
        Also, there is an assert that was firing and removing it
        seems to have no negative effect in interacting with the file.
        
        Change-Id: I899171ef3b5113f479725b0421f469c36e40e26c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162151
        Reviewed-by: Matt K <mattkse@gmail.com>
        Tested-by: Matt K <mattkse@gmail.com>

2024-01-29  Justin Luth  <justin.luth@collabora.com>  [301e27cbebf7d6e4c9b82290d7cd555c43f0c999]

        tdf#146756 pie chart2: import extLst manualLayout W and H
        
        The width of text labels in pie charts is currently determined
        completely arbitrarily.
        
        If the file specifies X and Y coordinates along with W and H sizing,
        then perhaps it is appropriate to use this?
        We currently import but ignore X/Y,
        so lets also make W/H available
        so we at least have a chance to ignore those too.
        
        Change-Id: I5caa48cf899e4e290eb2e8e78f731b6c5bcdd017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162589
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-29  Justin Luth  <justin.luth@collabora.com>  [6955e89903b5ec4328cab15f8a17663ad8ba3e9a]

        NFC chart2: trivial avoidance of unnecessary calculations
        
        Change-Id: Ia3bfce9ba6c7b8cab55e46e4d1e8c2afe54a65b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162588
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>

2024-01-29  Justin Luth  <justin.luth@collabora.com>  [4b2e44f81cdac757a62e431505075fc8a3d98471]

        NFC chart2: remove unnecessary variables
        
        Change-Id: I089972f0fd60fbaaff27a304c248a7eb882b972b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162587
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [5eb0a569e31771277263262bfeafb2c6fcf57dba]

        loplugin:unnecessarymethods
        
        Change-Id: I3bc2bde431dc71d4a01f7e314c67be31271be9e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162681
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a383de63e8854f3ccc906685196bda460406dead]

        ofz: Use-of-uninitialized-value
        
        keep a high water mark of the highest initialized level
        
        Change-Id: Ib799331c523209c4f165dc4c40317e25b6b0cc7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162684
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-29  Hossein  <hossein@libreoffice.org>  [07203b8ed8cc7a392c196b695c9a5c60955b732b]

        tdf#158426 Limit field columns for data form to 32
        
        Previously, maximum number of field columns for data form was 256, which
        was too much. But, even with that value, nothing was happening when
        exceeding that threshold. With this patch, the limit is decreased to 32,
        and if the user goes beyond this limit by selecting more columns, an
        error message is displayed. This change is done to prevent LibreOffice
        hang when excessive number of filed columns are selected and using data
        form is requested.
        
        Change-Id: Ib6189b5b3beffb26a3fd8ba8cd06e4ae213f77da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162488
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-29  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1e49f469afcbf3d1abec25451117f5f10d3ba825]

        Don't export personal metadata to OOXML in privacy mode
        
        Change-Id: Iac0985783a0c7334bd6ee3cfcaf37c135ac452ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162682
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5e95c95b05ab79298b7e9f0de82536a1bd04c9b]

        make append/rename table dialog async
        
        Change-Id: I3713271d121c525daa9800dcc1ac39bbd25e9c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162512
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Oliver Specht  <oliver.specht@cib.de>  [a5e2f4a8419a09d3a7d4118328824a5ea7ed2d6b]

        tdf#159342 switch off lists in clone formatting
        
        When paragraph attributes are cloned
        then lists are not only switched on but also switched off
        depending on the list state at the source paragraph
        
        Change-Id: I4299f4d75d61dd0def0fe6212f58bcce68f13dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162470
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [208757f4d359260afe27633d589a0c25444bbb67]

        make set-tab-bg-col dialog async
        
        and adjust the logic in Dialog::EndDialog to cope with
        dialogs that can loop.
        
        Change-Id: I71c88d8fb0512e92e7890566143c762ec9650e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162511
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-29  Keldin Maldonado (KNM)  <kemaldonado@csumb.edu>  [405e3f8815d9117d3f6d93ac4d0031e308a284f0]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I42c39d991d243191f410ebb8f91940d5922a6fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162678
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [593124f6ef384ce1a1cbc27dd7a43ffa42a50587]

        distro-configs: use internal python in bisect repos
        
        Change-Id: Ie5f980f93cb05501b1036c5c81dc67425b64ea14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-29  Szymon Kłos  <szymon.klos@collabora.com>  [4eb62f0e9ca42d8e6302c04e74ee6f1e08c1419c]

        lok: always toggle sidebar deck
        
        This fixes regression from:
        commit 53fc5fa0fed077b7d11e39b710280f0a84b631ff
        tdf#142978 Show a11y sidebar when finding issues on PDF export
        
        LOK was unable to close sidebar
        
        Change-Id: Icd96394523020c30e63858bc372ba136c2be8158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162608
        (cherry picked from commit 031f11bd9096fb192ced1328f9bbcd1b1903e3e7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162621
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-29  Miklos Vajna  <vmiklos@collabora.com>  [f3dfd7c0c980d7538830c9f8c65b36a12a25d93a]

        svx: prefix members of E3dView
        
        See tdf#94879 for motivation.
        
        Change-Id: I6da24e603eef63420fcf9d64f1d7322116878965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162679
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c249e910992d5da840989a1f2bea9da1c6d0fcbb]

        Fix typo
        
        Change-Id: Iabeea87e6ebeb6102c06caf00bb2d8abbaea1906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162677
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30ad8677de0bc1a56ac054114e9be149dd66f77d]

        Fix typo
        
        Change-Id: I3bd71a7b0c5d55905308c78d9d857661210cc276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162676
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c71b2227bc485dc38c3870ccc216767b3a756ac5]

        Fix typo
        
        Change-Id: I196da07f73fcdfc9e8ee3ca6f2db54ee53e2d26c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162675
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-29  AungKhantOo  <wildgugu2020@gmail.com>  [404312cbf5c2b3cec55c19879d1d7207596b8ddb]

        tdf#143148 Use pragma once instead of include guards in idl/inc/lex.hxx
        
        Change-Id: I149c597d9d571e78ef09a95d91c8550aab9ac471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162656
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-29  Mike Kaganski  <mike.kaganski@collabora.com>  [4541614e5f88604b4b1e17b0223d11c2e330d451]

        tdf#159412: make sure to keep the value while changing the type
        
        SbxValue::SetType clears the original value. We need to use the Get/Put
        cycle, asking for a specific type in Get, and then making sure that the
        variable is not fixed on Put.
        
        Change-Id: I0a6c106d511e8491c89a5a2153f47a708f83ee1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162664
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3be785e088cc0aa726509cf6b52b1d3b03817172]

        tdf#158939 icon-themes/karasa_jaga_svg: simplify some db icons
        
        Remove subtle image mask with very small details.
        Saves 1,722,744 bytes.
        
        Change-Id: Iee00918a7baf1f13594636490e7602cc2d505e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162658
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4fc1f3c83adbdbacc9f89e9b87d9cccb6603ef47]

        cid#1559947 silence Double free
        
        Change-Id: I85534fb07620e9b8958689c2ccd30b1fa730066d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [83214471da19abfdd75d254b95c4687c926f478c]

        cid#1545317 try silencing Use after free harder
        
        Change-Id: Ib7a062d7b405e8b888a7826d9b25fdf786efdc0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162668
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d0eb98a4b3acf510e2e6aa6bb39e866d0977fc40]

        cid#1588086 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1588075 COPY_INSTEAD_OF_MOVE
        cid#1588074 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia621e7aafd5e0b009b8c97deeace8708897dad4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162667
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Jim Raykowski  <raykowj@gmail.com>  [95d1e7f0873a2bbb9ab4b0aa171fec29d36c3f55]

        tdf#36310 Insert cross reference from Navigator by DnD
        
        This enhancement provides the ability to insert cross-references by
        drag and drop from the Navigator. It replaces the 'drag mode' way of
        inserting a hyperlink, section link, and section copy with a popup
        menu on drop that shows insert-as kinds available for the dragged
        content type.
        
        There is an oddity with X11 that on drop the mouse pointer does not
        change from a drag pointer to a menu item select pointer for
        approximately 5 seconds and during that time the popup menu items
        can't be selected.
        
        Change-Id: Id72cbdbd81106fc0e70784fcba7f1dd3a43ad81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161575
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8dc4a2e40b1afe26b6ae4649628eb8aa064e8823]

        Hack to speed up compilation of generated UNO Embind source
        
        ...workdir/CustomTarget/static/unoembind/bindings_uno.cxx, reducing an otherwise
        no-op build for me (against emcc 3.1.51) from multiple hours to "just" 3 min
        wall-clock time.
        
        Change-Id: Ic6477134b72f9d28cc3193fb514ceaa32b84209c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162666
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0f60a8138d9abc66d3135d56cf3735abe1c7a5d]

        cid#1588088 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1588087 COPY_INSTEAD_OF_MOVE
        cid#1588085 COPY_INSTEAD_OF_MOVE
        cid#1588084 COPY_INSTEAD_OF_MOVE
        cid#1588083 COPY_INSTEAD_OF_MOVE
        cid#1588082 COPY_INSTEAD_OF_MOVE
        cid#1588081 COPY_INSTEAD_OF_MOVE
        cid#1588080 COPY_INSTEAD_OF_MOVE
        cid#1588079 COPY_INSTEAD_OF_MOVE
        cid#1588078 COPY_INSTEAD_OF_MOVE
        cid#1588077 COPY_INSTEAD_OF_MOVE
        cid#1588076 COPY_INSTEAD_OF_MOVE
        cid#1588073 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibd0fc37ed1f93e0c092e0ce2ef04b28b4df4bccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f7ca5ce78f98505cd301f6bddde143e3ecb846e7]

        Resolves: tdf#149409 enable impress 'Small Capitals' Toolbar Button
        
        Change-Id: Ifc8721f50f359669af501c91bc86d6a983785f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162663
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9126cde8cb13098800d3406d006dbc4c687b2078]

        When chart is active pass uno:ChangeTheme through to its parent frame
        
        so theme changes can happen when chart has control of the UI
        
        Change-Id: Id7fd17d697d5ff8c03f1f46d80894e4f69cb9b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Rene Engelhard  <rene@debian.org>  [979ec95a0af2457e71b82d50e3fd9c34a3cf7701]

        add sparc64, riscv64 and loongarch64 test extensions
        
        forgotten in 3cb45765f2accfa749cc56a087059600ec467f28 and
        bc9487f745befde6534fd46058e119256952323d and d3625d968901eb93a9680db8d1165f70de3fd64e
        
        Probably academic since none of  those archs will have something in LO
        doing online-update anyway, but...
        
        Change-Id: I10bcc909df42ee7f51f2135b60fbb33c135f2554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-28  Luv Sharma  <luvsharma.del@gmail.com>  [971f9be4cdf84e3e04574ae5af86b732b2e5c161]

        tdf#148161 - Remove redundant attributes from configuration schema XML files
        
        Change-Id: I76cc172bbcd07a483494052e4704394fe15d0406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162489
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-28  Michael Weghorn  <m.weghorn@posteo.de>  [053b88c371461cda49e99ab2fc060eb1f1ded580]

        tdf#159323 qt weld: Remember VCL response code, don't try to map
        
        Set the VCL return code of a button as a property
        "response-code" for the `QPushButton` and use that instead of
        trying to map the VCL response code for a
        button to a `QMessageBox::ButtonRole` and then
        mapping that back to the original VCL return code.
        
        While the previous approach worked fine for return codes
        from the `VclResponseType` enum, it turns out that
        any arbitrary int can be used, and supporting that
        needs a different approach.
        
        One example (s. tdf#159323 comment 7) is `SbRtl_MsgBox`
        (in basic/source/runtime/methods.cxx) which uses
        values from the `BasicResponse` enum defined in there
        that has a `BasicResponse::Yes = 6`, but the
        `VclResponseType` enum has nothing for the value 6.
        
        Just use `QMessageBox::ButtonRole::ActionRole` for
        all buttons, since there's no clear way to map from
        the VCL response code to the `QMessageBox::ButtonRole::ActionRole`
        in general.
        
        Change-Id: I1782512d4eb47b2dcf71214d16e64d56127e9e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162560
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-28  Michael Weghorn  <m.weghorn@posteo.de>  [c038b4fd162abb780ab0f9bcafb1421c5ec5786e]

        tdf#159323 qt weld: Set standard buttons via weld API
        
        Instead of mapping the `VclButtonsType` to the corresponding
        `QMessageBox::StandardButtons` and using that to set the
        standard buttons for the `QMessageBox` using
        `QMessageBox::setStandardButtons`, use
        `weld::MessageDialog::add_button` to add all of the
        buttons manually, using their standard button texts.
        
        While the former is somewhat nicer, it depends on the
        ability to map between the VCL response code and a
        `QMessageBox::ButtonRole`.
        While there is currently a mapping in place
        (s. `lcl_vclResponseTypeToQtMessageBoxButtonRole` and
        `lcl_qtMessageBoxButtonRoleToVclResponseType`), this
        turned out to not be sufficient, since the VCL
        return code cannot only be one of the enum values
        in `VclResponseType` (which are currently handled)
        but any int.
        
        This commit is in preparation of an upcoming one
        that will replace the current mapping to support
        arbitrary int response codes.
        
        Change-Id: Icca68f2ccec182f8ff6ae3c64680a4d28bd687d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162559
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f921a66d31ec25afe618900f41001472a1a9dc46]

        ofz: MemorySanitizer: extend use-of-uninitialized-value bridge workaround
        
        Change-Id: I84f458b540e2e43cb3b4a06f4353e37ee2b7da2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dee3cff90d5d5948e1f8dcba084f192af2e5eb07]

        Set chart outliner background to the page bg to resolve 'auto' color
        
        when writer does this direct primitive rendering of the chart
        
        Change-Id: If3b31b3077dc6d7449e8a0102f3475884b3d754a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8fa1493facfe1f088fc99c762b5a8a0773fc1b9c]

        Set chart outliner background to the page bg to resolve 'auto' color
        
        Change-Id: I2498a7d49dbbd7bde017489722c3b655b6d75136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [be2ea4ebe3f969ee9ac4c8da40cdbe6d8f011e58]

        restore original Outliner background after getting transferrable
        
        Inserting a chart into a dark mode writer will initially incorrectly
        show auto color text as dark while is is in edit mode, then once you
        leave edit mode the auto text is correctly white.
        
        But it looks like that apparently correct white color is itself a bug
        from the copy clipboard transferrable setting a good background and then
        not restoring it afterwards.
        
        Change-Id: Ib019eb494b623bdda22019d587210db2c39987f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162566
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-28  Mike Kaganski  <mike.kaganski@collabora.com>  [a93dbb720c981cf48284ccbabda6db67d4be930b]

        Related: tdf#159382 Naming is hard: make initial monster shorter
        
        Rename "NoSpaceAfterHangingFootnoteNumbering" and friends to
        "NoGapAfterNoteNumber". This is cleaner, no less descriprive.
        
        Change-Id: I87d3103e4ddfc05e5604eaa4fe707b1fd5711aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162654
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-28  Noel Grandin  <noelgrandin@gmail.com>  [d9261ef1345dcf4ff9096c66339a79a34979b8d8]

        cool#8016 open files using O_CLOEXEC
        
        which is useful to speed up exec'ing/spawning subprograms, and
        avoids various leakage issues.
        
        Change-Id: Ie06ceb6b377e9d5cca8c017c5666564f6bed482f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162647
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2024-01-28  Noel Grandin  <noelgrandin@gmail.com>  [41c8e0957369b7b53a3b9cf4b4cf1e49a982a414]

        fix codelite-ide-integration
        
        externals seems to be part of the list of modules now, but I
        don't know how to deal with that, so just ignore them.
        
        Change-Id: Ic42d0b27562247b12cf9393659298cda56d1572c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-28  Justin Luth  <justin.luth@collabora.com>  [dc8c295605d190d0fc9d4a9a8b369c319be9d44b]

        chart2: use std::clamp
        
        Change-Id: I9fab21a889587e1eaf709e6bd31d0a0d6078c8f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162586
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-28  Justin Luth  <justin.luth@collabora.com>  [5e81ce5aec86ef5a93cc9cb4445fc4983e8a59ea]

        chart2: use NormAngle360
        
        In various places, the degrees refer to an area/width,
        and in those cases 360 means everything, so mk correctly
        removed NormAngle for those situations.
        
        But now copy/paste has added that to areas where a simple
        angle is being described, and in those cases
        using NormAngle360 is better.
        
        Change-Id: I4aa722c4a635f862dae5405f2ee929215a42faf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162585
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-28  Mike Kaganski  <mike.kaganski@collabora.com>  [d3f0e7867555dbf55a3e6be48e6c7bf957ef8907]

        tdf#159382: make edits of compat option in dialog apply immediately
        
        Change-Id: I1e0e3f259bfc0700d1bd8b1cace905ff5848f6a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162652
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c4a3b1503199037e83526244bffc6adc0c310216]

        Simplify massively over-engineered compatibility options
        
        They seem to be designed with multi-dimensional flexibility in mind;
        it is stored as an array of lists, each having a name and a module.
        The name may mean a filter. It may have a special name "_user" with
        unclear meaning.
        
        But it only ever used a single item in the array, named "_default",
        in a single module (swriter). Everything else was only read into a
        hidden listbox in Compatibility dialog, and never shown nor used.
        
        Make ir much simpler. Just use the "_default" item. It is possible
        to expand it later, if needed; but the previous complexity was bad
        for maintenance and adding new options.
        
        Translatable descriptions of the options were moved from UI file
        to sw/inc/strings.hrc, and used in a structure that clearly maps
        them to respective identifiers, to avoid fragile hidden dependency
        on order of different lists.
        
        Change-Id: I78ac5add8a872613e1fb388e4b8cc4fbf4362adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162651
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [ace5f5cbee7ea2c21ff9a3fe9b859b83a006edd6]

        tdf#158939 icon-themes: remove leftover reference images from SVGs
        
        Change-Id: Iccb7eaa0999f351cc365b52b5ce543f177ab00aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162631
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [4790ef5cb574650c418591566eeb0babc69db59e]

        ITEM: Cleanup some Pool stuff with Defaults
        
        Sorted out some methods at ItemPool which process
        Defaults to make more clear what is going on and
        what which method is doing.
        
        Change-Id: I2568d3e03d0a56a14b6fe4e04521e1a8e22c000b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162643
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2d8f8bf82558d9aa548fb9f13bed410e0baf79b]

        tdf#159381 TimeStamp(RFC3161) create problem by asn1 format error.
        
        DER rules say that BOOLEAN values are either FALSE (0x00)
        or TRUE (0xff)
        
        Change-Id: I59f57557fbc4d6447e0d8e994b04adda1ee8c1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162597
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0fa827dbb2147d1d3850b2181eb6ab6a02a04500]

        Drop std::as_const from css::uno::Sequence iterations
        
        Obsoleted by commit 2484de6728bd11bb7949003d112f1ece2223c7a1 (Remove
        non-const Sequence::begin()/end() in internal code, 2021-10-15) and
        commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 (Drop non-const
        Sequence::operator[] in internal code, 2021-11-05).
        
        Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [db227dc7d032d642983c313ab74c34a301464c2a]

        Avoid incorrect overwrite the value
        
        It would ignore the "enabled" state, if it its read-only is false
        
        Change-Id: I155a0621d967b1026c7f83316db8b595e9d507c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162613
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [830a3894ac98179fb78d6f1fdb409a51faab0c95]

        tdf#159382: add NoSpaceAfterHangingFootnoteNumbering compat option to dialog
        
        Change-Id: Ie1e7d5fb86474bf9145cc7dc3747a28bbf27472f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162635
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [2e41b639fc4056e4f944bb2272735d9daddfb521]

        tdf#159382: introduce a Word compat flag for hanging footnote number spacing
        
        The new 'NoSpaceAfterHangingFootnoteNumbering' compatibility option is false
        for ODF documents by default. Word file format filters set it to true. Its
        purpose is to avoid extra spacing between the footnote number and its text,
        when the paragraph has hanging first line, as in MS Word.
        
        Change-Id: I42d9353865498137ab99e1d2c031f5b207cbc220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162603
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-26  Michael Weghorn  <m.weghorn@posteo.de>  [2cedb1a19ad605df4e148589e9027512e4dd9265]

        sw a11y: Return MapMode instead of using out param
        
        Change-Id: I116e006e3fcdb3c6993adf7c99860bdd952af6e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162633
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-26  Patrick Luby  <plubius@libreoffice.org>  [c6652e280b0690497abf27380dd064898f91db32]

        tdf#152524 Add a __objc_fork_ok data section for Mac Intel executable
        
        This attempts to fix a particularly difficult to debug crash due to
        memory corruption when gpgme tries to fork and exec a gpg command.
        For more background, see the following bug comment:
        
          https://bugs.documentfoundation.org/show_bug.cgi?id=152524#c39
        
        This data section is only added in Mac Intel builds as it is a
        controversial approach and I have not seen any reports of this bug
        on Mac Silicon yet. So limit the fix only to Mac Intel in the hope
        that this controversial approach will automatically phase itself
        out when Apple eventually stops releasing new versions of macOS
        for Mac Intel.
        
        Note: the Objective C runtime doesn't appear to check the value of
        this data section, but set it to 1 in case that changes in the future.
        
        Change-Id: Ifac7893589a9183e092724297aff93eb3d58ab70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162634
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2024-01-26  Justin Luth  <justin.luth@collabora.com>  [87facad88d565e8e9fe21d04897058cca0ea55cd]

        tdf#134121 pie chart2: fix missing leaderLines at top/bottom of 3D ovals
        
        Yeah, it took me a while to clue in that this is no longer
        a circle, so we can't apply circle logic to it any more.
        
        Change-Id: I00f8b95cc75311342b9abd8c522ed06ca343a566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162630
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-26  Henry Castro  <hcastro@collabora.com>  [64e1a5916367644ad3883a24ab1630d1340603b3]

        tdf#127856: fix setting "None" in cell format language
        
        Change-Id: I94dc0b1e7f0a52e8fb6da1f9b80456cec696a727
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-26  Henry Castro  <hcastro@collabora.com>  [966f075a332b38a2689dad317d5d3c3fa61a1efb]

        tdf#34142: update status language after the cell format language change
        
        Change-Id: Ieb97515cee469a54c5b28ac4477c9d0d78e2974c
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-26  Henry Castro  <hcastro@collabora.com>  [b8bc9518d523cff59e238f1eefc4ce7e7c844196]

        tdf#34142: fix cell language status
        
        Now the status bar will show the current cell
        language instead of the document language.
        
        Change-Id: I8b6d17b37e7c7bd69abd949a901499613f100649
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162123
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-01-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [e7186b49a9a0b24ddc3b1c5384b5d9facb03518c]

        tdf#158445: support viewBox in symbol elements
        
        Change-Id: Ie45b1e1dd4a4dcfc3cf3ce3d30f8dd9e040e37fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162605
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [80480fb5ecc18a0a9b6c4cccc5cc35eba721f636]

        tdf#153853 Line numbering and breakpoint should be on the left (RTL)
        
        As requested by the user in the ticket, the Line Numering and Breakpoint windows should be on the left side, even on RTL locales.
        
        Change-Id: Iad2ba8efa0a23a13cf88c2fa277c4eed45002aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162540
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e465cf6fcb67a9ada161ef8988aeab46064b7d4d]

        invalid cast from 'GtkImage' to 'GtkLabel'
        
        since:
        
        commit fe946f86ad6586fa810cae5c0f246389a285e172
        Date:   Wed Nov 29 15:25:06 2023 +0100
        
            Bump Glade version
        
        Change-Id: Ide86220f260dac40395389530e7221ea8de8f092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162606
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2822b41dfcd26c6eb9f9ffa89672053663bb26f2]

        just fetch SfxViewShell::Current() once, and as const
        
        Change-Id: I3c95622b6de8ff35e53d9879f3de8cf9041887c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162604
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [45763a761bdbe8ef0b3a4f81225d262b64b9c4b0]

        Fix typo
        
        Change-Id: Ic038388a812e510fdb963f8f271d6377a71759c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162599
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2024-01-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [b0f678ca59a65a3c302c3c3a499230fbc52ed5bd]

        tdf#159329 Fix AutoFilter arrow color in dark mode
        
        When using dark mode, the arrow is black over a dark background. This patch makes it use the dialog text color for better contrast.
        
        Change-Id: Icf07d50599191417dee294e1f4c925fe1a8a7655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162460
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d4b9765e7fa9c234483b1b8706405377ccace593]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6984afbbc2f1dbdbe687f3fbc4cf8aa0ea10b07f
          - tdf#155875 UI cmds Format Text (cont)
            
            + Spacing submenu
            + refactoring
            
            Change-Id: I84680060fbae12afb16c160b592984c5f1c578f8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162600
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1fd08af6220a4e921814b8cd049665ac85d57dcb]

        Update git submodules
        
        * Update translations from branch 'master'
          to c53381e37074987d7baa37c72ede218c619bdb4f
          - update translations for 24.2.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: I93e387c681acb9d7d3ae6b69cd57cafd4556e552
            
2024-01-26  Heiko Tietze  <tietze.heiko@gmail.com>  [381ab9a1a38e4ea9238599e62acd430782a80547]

        Resolves tdf#159096 - Change color of comment indicators in Calc
        
        COL_LIGHTMAGENT was preceived as too glossy and "Light Purple 3"
        should also be closer to the Excel prototype
        
        Change-Id: I451c0ba0628dbd3b1794e46de3ff1fef763a6f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162593
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ee52e5385497a04b23bcc907ec43cafd8bfadf28]

        revert: 'LOKit: always display hidden chars when showing formatting...'
        
        and add a counter-reason test.
        
        When we have multiple views of a document, whether in LOKit or in
        desktop via "Window, New Window" then we have just one layout and render
        that layout in each view. So with default settings: View, Formatting
        Marks, we can correctly render the Pilcows in one view but not in the
        another even though we share a single layout.
        
        If "Show Hidden Characters" is enabled, then when "view formatting" is
        also enabled then hidden characters are shown when view formatting is
        enabled, and not when it is disabled.
        
        But if "show hidden characters" are enabled, then if formatting marks
        are enabled in one view and and not another then the hidden characters
        will be either shown in both views or hidden in both views, depending on
        whether the shared layout is done with "show/hide hidden characters". So
        we currently can't show/hide the hidden characters per-view.
        
        revert:
        commit 7a6b80995f69304149e0ab7a8e1fa92a15b20d07
        Date:   Wed Oct 4 10:04:42 2023 -0400
        
            LOKit: always display hidden chars when showing formatting marks
        
        This arises from noting that in kit then on turning on formatting marks
        in one view, then the other view rendering options changed, which isn't
        wanted. But on attempting to keep the other ViewShell settings
        unaffected it turns out to be futile given the shared layout.
        
        Change-Id: I210b86fae84bc8137af415cb9c93dacdeab7d448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162579
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 5234435a552d3d4cc421ba5c8600d8215f9f8f4b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d10fb7eb23174786e3704d288c1bb56e6e08cca1]

        Use && rather than ; between commands, to not hide errors
        
        Change-Id: I4f8dc3d338b64452dc92c850c7dc174bb59611bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162592
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-26  Miklos Vajna  <vmiklos@collabora.com>  [8fc478308f680227d7253b4becfc698e289f2be1]

        sw layout xml dump: show if formatting marks are on
        
        Because that influences the layout, and sometimes it's far from trivial
        that it gets disabled, e.g. during printing/PDF export.
        
        Change-Id: Icb6accf3cb8bacd02f7267d55fbf56a4b10550bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162591
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-26  Sakura286  <sakura286@outlook.com>  [e49653f440d8fced0414df93a85bb8adc6f9ffb4]

        (riscv64) Fix Java bridgetest failure
        
        * Refactor the code related to struct processing. Fix Java bridge-
          test failure. Fixed test list:
          * bridgetest-javaserver
          * [CUT] smoketest
          * [JUT] forms_unoapi_1
          * [JUT] forms_unoapi_2
          * [JUT] forms_unoapi_3
          * [JUT] forms_unoapi_4
        * Clean higher bit to prevent compiler generate wrong code when
          pyuno calls functions through UNO environment. This fixes some
          weired uitest failure.
        * Reorder the datatype list. Optimize the inserting args section in
          uno2cpp.cxx.
        * Remove some unused code.
        
        Change-Id: I74330126d31d847485b1d81fc34376b1d020f886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160970
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ba8911931c18e6a4cc737ffc9f0f415f1ba794d7]

        Don't export printer name & config in privacy mode
        
        Don't export printer name & printer config when
        RemovePersonalInfoOnSaving is enabled, as it might contain
        sensitive data such as printer location.
        
        Add an option to export printer settings even when
        RemovePersonalInfoOnSaving is enabled.
        
        Change-Id: I3d2ca91ad2032050c919d382c11c9ceabf331770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162577
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-26  Mike Kaganski  <mike.kaganski@collabora.com>  [3460799175e6c5795aa07c784e16d10ba9081d49]

        Clear gb_GbuildToJson_DENYLISTEDMODULES, allow these modules
        
        Filter "empty" targets in Visual Studio solutions: it makes little sense
        to add generated files to projects (they aren't intended for editing in
        IDE); so most external libraries, which only have "generated" sources,
        and aren't part of core anyway, would have zero source files in their
        projects - thus excluded.
        
        Handle C++/CLI files; use their specific CXXCLRFLAGS (set them to the
        source files explicitly, overriding CXXFLAGS set on the project level).
        While here, do the same with CFLAGS and C files.
        
        Do not add H(XX) files (with names identical to C(XX) files) to the VS
        projects. This adds a tiny subset of all headers, which is inconsistent.
        
        Change-Id: I6bd932277287d3444bb547b93f2867d226072d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162582
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-26  Dione Maddern  <dionemaddern@gmail.com>  [8abcdf66bab029a0668aacd4a608e04e490be996]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e2e86e560d0fea20accc64f8de6fa2011f4b6488
          - tdf#155877 Fix broken links in Shapes and Page Menu help pages
            
            Correct typo in /text/simpress/02/10080000.xhp so that pressing F1 opens the correct help page for Shapes > Insert > Curves and Polygons > Polygon (45 degree).
            
            Add HID bookmark in /text/shared/02/blockarrows.xhp so that pressing f1 opens the correct help page for Shapes > Insert > Block Arrows > Up and Down Arrow Callout.
            
            Add correct HID bookmark in /text/shared/menu/save_image.xhp so that pressing F1 opens the correct help page for Page > Save Background Image.
            
            Add HID bookmark to /text/simpress/01/13050000.xhp so that pressing F1 opens the correct help page for Shapes > Convert.
            
            Change-Id: I0647ae81941541923cda19e4f49538ff1159c4fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162531
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [630494adc98a245feadd573aa8463f46b15c7787]

        make wrap dialog async
        
        Change-Id: I7179209396b2c10d1f8b58d4ec5bbffe4856c53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bae0c8eb3ee3f7d36e8eb0deb662ab029a162f08]

        Fix typo
        
        Change-Id: Iea9aa138ae2e38635d4a717e8518f83d3775ee9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162411
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [038476af694ef28f01aedb168273c3ba8709c209]

        update credits
        
        Change-Id: Ifb0ea3df4b544706527081f0ff21694c4dd2cad6

2024-01-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cbae6e581ad62771122d35742bd304be44fb982c]

        Let embindmaker also generate a .js file with more natural names
        
        (i.e., Module.unoembind_uno.com.sun.star... vs. Module.com$sun$star$..., and see
        the updated examples in static/README.wasm.md for further shortening that to
        just css...)
        
        Change-Id: I6dc079caa8c93a4042a6a8aa2d8fcc8f76bf80f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162580
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c479944eb4f9f5a22c7b248185f22c86ea85d12a]

        Don't export personal metadata when user wishes not to
        
        Currently the metadata is only reset to default when the option
        to remove personal metadata is active.
        
        And some metadata was still exported which might contain personal data.
        
        Now the following elements won't be exported anymore when the RemovePersonalInfoOnSaving
        option is set to true:
        * meta:initial-creator
        * meta:creation-date
        * dc:date
        * dc:creator
        * meta:printed-by
        * meta:print-date
        * meta:editing-duration
        * meta:editing-cycles
        * meta:template
        
        Change-Id: Ibad57fdbff04bf285881826820ec3ddb01ffbb36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162553
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-25  Gabor Kelemen  <kelemeng@gnome.hu>  [6fa4af11e045f2c365923df90dceafd4e954146a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c762a3dc812420858edbab9bf841ca69c133b985
          - tdf#146386 (related) FTP protocol is no longer supported
            
            so remove references to it from helpcontent
            
            Change-Id: If0dc888fbb8106d23a250047772224043a313c60
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162527
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cc634d32906d30ef7f3b14193996e42b788bd569]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7b42317e75937684f4e45303945c8ce490d7fc5c
          - update translations for 24.2.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: I016d4038f8ba31d6ad0427eefc057d6d90bb4560
            
2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1c6d885b7503dd489e6f37132a42db3fbee9c3b8]

        Fix typo
        
        Change-Id: Ibdfbb8c6492d18989d587230db674a7ff2546150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162574
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9fd57de12001cc7b96022c1ec79881d2fcd9b241]

        Fix typo
        
        Change-Id: I99f9730e573f06e53516d0d775df1b276ff83a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162573
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [20f72a37309baab11c08f6504f4129ddf6cb8c56]

        Fix typo
        
        Change-Id: I49afb3957c5633f82431408402bead2a9b0328a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162572
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5a2bdf822ddaf5133678c5ab912c3dba8212c61b]

        Fix typo
        
        Change-Id: I7822db68e7389eca4ee9e21fba57735656a94d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162571
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6181be0fca677d1c83e0eccd8be31a0e8cc36ad5]

        Fix typo
        
        Change-Id: I12f0cbbc1523a7451281ef501b51b56010105dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162570
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e40a864d34a9ed7b80fffb4f11837f9e8f2211e6]

        Fix typo
        
        Change-Id: Idb09d903b97ca9697ac473b46ae85b2205be128a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162569
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3db7d3ad5360ac5af903ab0c14e130b95440739f]

        Fix typo
        
        Change-Id: Ia769e28fa1180c40f0e25763485a7b468d1f8f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162568
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b83ebf42c535528b73baac2407b347f19070d07]

        disabling UITest tdf159102
        
        because it still fails on my machine reliably
        
        Change-Id: I482b8235cd910ff16b1b15bb0427c5d6a8140751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [cd01f035c4c3e20f890dd48b7a734bf0513ab667]

        tdf#159349 Dialog "Go to Page" in Writer should not be resizable
        
        Change-Id: Ica252b9e8c1ba4f7e5218d2264dd31c18eda06d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162462
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9e917a7ce95d1564814e90188bc915a38ac69468]

        extract this to a explanatory SyncLayoutRelatedViewOptions function
        
        no change intended here
        
        Change-Id: I67e7279d27e9cea31c9c26d1775f8dd28bd74e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [846d7797e91245f5ee457fc447f541bcbd233699]

        janitor: remove unnecessary conditional (macOS vs iOS)
        
        The "no Application" comment referred to an older version of the code
        that tired to get a localized name for the current LibreOffice UI
        language only, but that has since been removed…
        
        Change-Id: Iac8f4aa816aee4d7a03f5fbefedee621781f33b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162505
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-01-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b6f04ea7033c5ca529363a4027cf2cb7d2c7ee3]

        Resolves: tdf#159368 crash on tools, macros, edit
        
        when launched from startcenter
        
        Change-Id: I362bfe27914445c3027b6e8a125a75cc31679678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [611feba951c9d6904540472f91f34395de341dc6]

        preload sal_textenc
        
        use RTL_TEXTENCODING_MS_1250 to trigger Impl_getTextEncodingData to
        dlopen sal_textenclo early
        
        Change-Id: Ie96b81615cbd4b479d731916518835b2f72adf6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162477
        Reviewed-by: Neil Guertin <neil.guertin@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 4f404f2b18692276d157c4de9bfbb1f6370ad58d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162541
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9485d88da541c8614582b9f927ae40b1c8991c56]

        crashtesting: crash seen on import of forum-mso-en4-278652.xlsx
        
        probably an issue since:
        
        commit 135ce256ce9e879663d828ec6e699de521fad867
        Date:   Mon Aug 14 15:59:18 2023 +0200
        
            tdf#146487 Don't show generic diagram title when there is an empty title given
        
        Change-Id: I12d8d6e78a8435b998084221402b6bdfc4a1a433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-25  Michael Stahl  <michael.stahl@allotropia.de>  [5314947eea119a1ed4960e23c61530669b97468e]

        tdf#142806 sw: slowness if Style Inspector visible during PDF export
        
        There are loads of bookmarks in this bugdoc, WriterInspectorTextPanel
        update functions somehow iterate them all, and it's entirely pointless
        because the view doesn't repaint during store anyway.
        
        PDF export does a lot of cursor moves at the shell to get selection
        rectangles, and each one triggers the slow update in AttrChangedNotify.
        
        Also simplify, the m_pShell is already there.
        
        Change-Id: I2177db1a2ab712e8984772843bd5f995e6989a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162525
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-25  Michael Stahl  <michael.stahl@allotropia.de>  [9ba8d68c2b2fd06340bbdcb61dc3d57f6e3eb974]

        tdf#142806 sw: PDF export: fix multi-frame links/fields
        
        * SwRootFrame::CalcFrameRects() assumption that there is only 1 frame is
          wrong, add a loop; also remove dead eMode check in else branch
        * GetCursorRectsContainingText() cannot call GetCurrFrame() because that
          returns always the same frame, but it can be split across several
        * fix GetFrameOfModify() to return the correct frame in case of a field
          (where it returned always the frame containing the start of the field,
          but pViewPosAndCalcFrame could be in a follow frame)
        
        (regression from commit 5726be1314517d47dd733aabe64a3d85cce094c5)
        
        Change-Id: I63a94080ee120f178580e0339db4541691165780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162523
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-25  Michael Stahl  <michael.stahl@allotropia.de>  [42a315b4a777dc371297752b6233e437d36c456b]

        sw: fix crash in SwTextCursor::GetModelPositionForViewPoint()
        
        With a field that spans 3 SwTextFrames, it happens that
            rText[sal_Int32(nCurrStart + nLength) - 1]
        results in rText[-1]; it looks like both nCurrStart and nLength are
        correct (nCurrStart was decremented in line 1531 after "if (bFieldInfo)")
        so there is a missing check here.
        
        Change-Id: I0d5be617e8e54c20dc8633efd3a7d82510f4acd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162522
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-25  Weblate  <noreply@documentfoundation.org>  [d527c6dca4513bf2f4267bd9e6f739532d7908d0]

        android-viewer translated using Weblate
        
        Slovak currently translated at 16.1% (19 of 118 strings)
        
        Change-Id: I43a99ef5228367157936337424f0b88893bba112
        
        android-viewer translated using Weblate
        
        Czech currently translated at 50.0% (59 of 118 strings)
        
        Change-Id: I5335d1b9a25312708822ddf890fdb92c02891b25
        
        Added translation for android-viewer using Weblate (Slovak)
        
        Change-Id: Icd19b09d4df30882fba4b26a7745419fe73233ba
        Co-authored-by: Miloš Šrámek <msramek22@gmail.com>
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Weblate <noreply@weblate.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sk/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162472
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [da1df4cc483f10667c3d42369581d53a5b34f421]

        editeng: prefix members of ImpEditView
        
        Change-Id: Icc64978d53a3fbbf4f1d71058ffc83b8483cc0fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162529
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [290ad80ad225ba8570fa792fd1c8dbe7a7d107f0]

        editeng: in EditView, access ImpEditView as a reference
        
        EditView access to ImpEditView can be done as a reference as the
        ImpEditView instance is created on EditView construction and is
        always valid as long as EditView is alive.
        
        Also change all access to ImpEditView instance to use the
        getImpl() method insteady of direct access.
        
        Change-Id: If64f8f8494c3a4f52f860ea8dee798edd51b6c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162528
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5d6133283bacb6bced8cdbedaeae6b3bd2f179e]

        make insert row dialog async
        
        Change-Id: Icb6c2fafe2b47989ff2692956890c87780b117e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-25  Miklos Vajna  <vmiklos@collabora.com>  [2aa773c9bdb8fc89225d251ca2662a328a0d5e6f]

        CppunitTest_sw_uibase_frmdlg: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23).
        
        - sw/qa/uibase/frmdlg/data/wrapped-math-object.docx:
          word/media/image1.wmf: old WMF used the System font, replaced this
          with a different WMF, as the preview gets updated before the first
          document render anyway. (Binary patching 'System' -> 'DejaVu Sans' is
          not easy.)
        
        Change-Id: I5282ec1708d3a52d1fd2795a283b5e96884409d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162551
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [18e930165086fa08a91e1ba890ac3f52badbbf53]

        sw a11y: Send SELECTION_CHANGED_{ADD,REMOVE} event for doc
        
        `AccessibleEventId::SELECTION_CHANGED_ADD` and
        `AccessibleEventId::SELECTION_CHANGED_REMOVE` events
        need to be sent for the selection container whose
        selection changed, not the child that was (un)selected.
        The latter should be set as the `NewValue` of the event,
        see the doc in
        offapi/com/sun/star/accessibility/AccessibleEventId.idl .
        
        Therefore, adjust the handling for (un)selected shapes
        in Writer: Set the doc view's a11y object as the source,
        just as it is already done for the
        `AccessibleEventId::SELECTION_CHANGED_WITHIN` case,
        and set the (un)selected shape as the `NewValue`.
        
        With a Writer doc having two shapes and the first
        one selected, clicking on the other one to switch
        selection to that one would previously result in
        this warning when using the qt6 VCL plugin with
        Orca running:
        
            warn:vcl.qt:114611:114611:vcl/qt6/../qt5/QtAccessibleEventListener.cxx:363: Selection add/remove event without the (un)selected accessible set
            warn:vcl.qt:114611:114611:vcl/qt6/../qt5/QtAccessibleEventListener.cxx:363: Selection add/remove event without the (un)selected accessible set
        
        Using gtk3 and this pyatspi script:
        
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if e.host_application.name != 'soffice':
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, 'object:state-changed:selected')
            pyatspi.Registry.registerEventListener(listener, 'object:selection-changed')
            pyatspi.Registry.start()
        
        would previously give this output for that case:
        
            object:state-changed:selected(0, 0, 0)
                    source: [panel | Shape 1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [panel | Shape 1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:state-changed:selected(1, 0, 0)
                    source: [panel | Shape 2]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [panel | Shape 2]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        (i.e. both, the "state-changed:selected" as well as the "selection-changed"
        AT-SPI events were previously sent for the shapes.)
        
        With this change in place, this gives the expected output:
        
            object:state-changed:selected(0, 0, 0)
                    source: [panel | Shape 1]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [document text | Untitled 1 - LibreOfficeDev Document]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:state-changed:selected(1, 0, 0)
                    source: [panel | Shape 2]
                    host_application: [application | soffice]
                    sender: [application | soffice]
            object:selection-changed(0, 0, 0)
                    source: [document text | Untitled 1 - LibreOfficeDev Document]
                    host_application: [application | soffice]
                    sender: [application | soffice]
        
        Change-Id: Id2017f70a8e53043b4c303f69464ddd39f280097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162519
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [c965b4f6fb1e59d05b26930d5fa24df2e7c0e0b5]

        sw a11y: Drop special event handling for single selected shape
        
        If shape selecion changed, just send the same
        `AccessibleEventId::SELECTION_CHANGED_ADD` event(s)
        regardless of whether only a single or multiple shapes
        are selected.
        
        This unifies the handling and also prepares for sending the
        event with the correct source and `NewValue` set.
        
        The `AccessibleEventId::SELECTION_CHANGED` doc doesn't
        expclicitly mention whether the source should be the
        selection container (i.e. the parent, which is the doc view
        in the case here) or the selected object, and this is
        currently handled inconsistently across the codebase.
        I tend to think that this event should have the
        container as the source (just as for the
        `AccessibleEventId::SELECTION_CHANGED_ADD` case,
        that will be fixed in an upcoming commit), and this
        is at least what the handling e.g. in the gtk3 a11y
        bridge assumes (s. `AtkListener::notifyEvent`), but
        there seems to be no added value in handling the
        case of a single selected shape specially here in the
        first place.
        
        This may have been inspired by the MSAA/IAccessible
        equivalent, `EVENT_OBJECT_SELECTION` [1]:
        
        > The selection within a container object has changed. (...) This event
        > signals a single selection: either a child is selected in a container
        > that previously did not contain any selected children, or the selection
        > has changed from one child to another.
        
        But then, the selection taking place here might also be from
        multiple objects being selected to just a single one, and
        `SELECTION_CHANGED_REMOVE` is sent for any previously selected
        but now unselected shape anyway, so using
        `AccessibleEventId::SELECTION_CHANGED_ADD` seems more
        consistent to me anyway.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/winauto/event-constants
        
        Change-Id: I1525ed27434bbbb4cf181df2148669c7bc6850b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162518
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [08b7a0eb45c8816c6cf093d9a7405ce9b6d3f990]

        sw a11y: Drop unnecessary cast to SwAccessiblePreview
        
        With
        
            Change-Id: I32d5bd2f81e7a69eacf92af1cf24249eb3a9f2a0
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 24 12:10:32 2024 +0100
        
                sw a11y: Return SwAccessibleContext to avoid casting
        
        in place, `SwAccessibleMap::GetDocumentView_` returns the
        more concrete `rtl::Reference<SwAccessibleContext>`, and
        `SwAccessibleContext::InvalidateFocus` is what gets
        called here, so there's no need to cast to
        `SwAccessiblePreview` here.
        
        (The previous `static_cast` wasn't type-safe, so the
        extra null check after the cast didn't really add much
        value.)
        
        Change-Id: I4788d5e96570ceb0ffe97abfa9c48722cc90dc63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162517
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [8479bbecd2434d65eb6c26100a783ecf96f6da12]

        sw a11y: Return SwAccessibleContext to avoid casting
        
        Let `SwAccessibleMap::GetDocumentView_` return the
        more concrete `rtl::Reference<SwAccessibleContext>`
        instead of `uno::Reference<XAccessible>`, which
        avoids having to cast in one place in
        `SwAccessibleMap::DoInvalidateShapeSelection`
        (and more places in upcoming changes).
        
        Replace the null check by an assert, as
        `SwAccessibleMap::GetDocumentView_` never
        returns an empty reference.
        
        Change-Id: I32d5bd2f81e7a69eacf92af1cf24249eb3a9f2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162516
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [25bda5d887b12015e0f7d32753408b20544b5566]

        sw a11y: Drop VEC_SHAPE typedef
        
        Change-Id: Icd52756c729c5f8f4da1e6096e776a3a0d1a6260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162515
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-25  Jim Raykowski  <raykowj@gmail.com>  [1ac7350a7032a760be22cce845eab7efe435827d]

        tdf#158101 Make non-gtk backends context popup menu item
        
        visibility behavior like gtk
        
        For context popup menus, gtk's native popup menu hides disabled menu
        items. This patch makes this the behavior for non-gtk backends while
        preserving the intent of commit
        a0955317900075371d6adb7f924af24c22f02d09 to make VCL PopupMenu respect
        the officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting.
        
        Change-Id: Ice59f2b5ec20dac9d1b0891ccbd83dbbcd308078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159192
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-25  Miklos Vajna  <vmiklos@collabora.com>  [a2763fe7b6f22e3e65d7e0db62b6ada967ccdd61]

        CppunitTest_sc_tiledrendering2: extract one test from the old, large suite
        
        Not a split, to avoid too many conflicts while cherry-picking, but at
        least create a new suite where next tests can be added without too much
        build time after source code edits.
        
        Change-Id: I494df6e23941845a433aab6ec5ecef040feab30e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162473
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [5d1eafab5233e6eaaf99071554b5b41addf7fa56]

        Deduplicate, refactor and simplify GbuildLinkTarget initialization
        
        Change-Id: I0c2d9823454ff84af2967c20a383b334e4933967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162550
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [c38ebb561211e55d0a7eb5d2e3db6975f0cadbfc]

        split out set-bg-col logic from ScTabViewShell::ExecuteTable
        
        Change-Id: I528d99fbd8e369a0ceaa51184e336d24a4510706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162510
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9aedbd5bfdb5dbad49fb448eaa34ba7db23805cb]

        split out append and rename table logic from ScTabViewShell::ExecuteTable
        
        Change-Id: Iab2ab8d4fcd8ed11d16701bc1319e32931c73ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162509
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [566bb271b8fe5882f24fef230e06c2af4ea12b33]

        add static libraries to gbuildtojson
        
        ... and to vs-ide-integration solution.
        
        Change-Id: I5085e6a61df4bc03cfe595a1e6b99196f6f73643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162524
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-25  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [37f148c58974210707e069f21da2cc2b9ae086dd]

        ITEM: Slight re-design of global Item-Reusage
        
        Unfortunately I had overseen something with derived
        classes, but it came now up on CI ASan/UBsan build
        with a failing UnitTest - thanks to pointing me at
        it.
        
        The ItemInstanceManager at the SfxPoolItems are now
        no longer static but constructed instances returned
        on-demand.
        
        Also added checks to really use an incarnated/
        registered one *only* for that derivation and made
        sure this is now correctly supported.
        
        Had to change again, using createItemInstanceManager
        to always create instances was less effective than
        intended, back to getItemInstanceManager & static
        instances in the Item implementations. Also added
        some stuff to implCreateItemEntry/implCleanupItemEntry
        to be more effective, e.g. direct handling of
        slot stuff in latter one. Also some more asserts
        and comments. Slot stuff is now handled without
        RefCounting, takes some write accesses away...
        
        Change-Id: I6cd69556b416510b5b23549dd042ff3ba155559d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162521
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-24  Miklos Vajna  <vmiklos@collabora.com>  [ce53519f025158f8f64a4e8603c8c6e0dc35473a]

        cool#8023 editeng: support HTML paste
        
        editeng text (e.g. Writer shape text or Calc cell text edit) had working
        plain text and RTF paste, but HTML paste was not working.
        
        This is typically not noticed because desktop paste usually goes via
        RTF, but it can be visible when a LOK client just puts the best format
        on the clipboard, i.e. HTML is provided, but RTF is unavailable in the
        browser and plain text is also not written to the LOK clipboard.
        
        Fix the problem by connecting the existing ImpEditEngine::ReadHTML() to
        the generic ImpEditEngine::PasteText(): this already worked for plain
        text and RTF, but not for HTML.
        
        Note that "SIMPLE_HTML" was already supported, but that's not really
        HTML but some custom format that contains HTML, and it's claimed that MS
        IE 4.0 produced this.
        
        Change-Id: Ib41529c66d9bda30cc4ed5faca4a99274ae594d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162449
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6cad8d3a96c5425fe787765e5664463242958a78]

        fix windows aarch64 cross-build wrt REPORTBUILDER
        
        broken after a2a9850217b3f711440283131fdfc58a9a254919 which added the
        REPORTBUILDER conditional, but didn't also put it into the special
        PERMITTED_BUILD_TARGETS list - so it wasn't set during cross-compilation
        and broke the build
        
        C:/cygwin/home/tdf/jenkins/dly/s_master/solenv/gbuild/Configuration.mk:169: *** There is no target
        C:/cygwin/home/tdf/jenkins/dly/b_master/workdir_for_build/XcuModuleTarget/officecfg/registry/data/org/openoffice/Setup-reportbuilder.xcu.
        Stop.
        
        Change-Id: I9474318eae775bcd974e79db0d8340a2d3839412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162504
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [fee9b337eb25f81191ec4b270860de1a0d7eaf61]

        make move table dialog async
        
        Change-Id: I85ddcd2589b6cb27f2022746607e9eda3818abd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  László Németh  <nemeth@numbertext.org>  [03c5a31a0f374a90fbc821718c14dc5f8a385adf]

        tdf#106733 sw cui: add CharNoHyphenation checkbox
        
        On Position tab of Character formatting dialog window
        as a new checkbox "Exclude from hyphenation" (UX design
        by Heiko Tietze).
        
        With this, it's possible to disable hyphenation
        with direct character formatting (e.g. combined with
        Find All), or using character styles, and setting
        "Exclude from hyphenation" in them. This feature
        is conformant to the OpenDocument standard, and
        unlike the previous locale=None workaround, it keeps
        spell checking and locale dependent text layout.
        
        Note: Clear direct formatting (Ctrl-M) is an
        alternative way to remove the enabled CharNoHyphenation
        (e.g. in version 24.2, where this commit won't
        be back-ported).
        
        Follow-up to commit b5e275f47a54bd7fee39dad516a433fde5be872d
        "tdf#106733 sw: implement CharNoHyphenation".
        
        Change-Id: I26823e6ec2a3ca39dcf0f7c051d96e638921c589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162514
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d993a39c60d9184ddc3dbdaa9854ec1ecc99464]

        make insert table dialog async
        
        Change-Id: I4fd880ed2b1f07439229750e77246cf9cb2df5f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [38f98c60e797753fa54bf3649520995df9861b45]

        svx a11y: Notify listeners when disposing shape
        
        In `AccessibleShape::disposing`, call the same method
        of the base class, i.e. `AccessibleContextBase::disposing`,
        not `AccessibleContextBase::dispose`.
        
        The code was moved from `AccessibleShape::dispose` to
        `AccessibleShape::disposing` in
        
            commit f11b151dc08ccfcb7e78bfd9a24c77670942ea63
            Date:   Tue Apr 30 13:30:10 2002 +0000
        
                #95585# Moved code from dispose to disposing().
        
        and it seems likely that adjusting the base class method to call
        was just forgotten/missed.
        
        This resulted in the accessible getting disposed without listeners
        getting notified (since `AccessibleContextBase::disposing` takes
        care of that).
        
        This resulted in a crash for the following scenario with the qt6
        VCL plugin when the Orca screen reader is running:
        
        1) start LO Writer
        2) click on the "Basic shapes" toolbar button
        3) click + drag to insert a shape into the document
        4) click somewhere else
        
        Backtrace is below.
        `AtSpiAdaptor::handleMessage` (frame #12 in the bt) checks
        whether the accessible is valid and returns early otherwise.
        But since listeners were not notified when the object got disposed,
        `QtAccessibleEventListener::disposing` wasn't called, which would
        have taken care of invalidating the `QtAccessibleWidget`, in which
        case this early return would have happened instead of the crash.
        
        This behaves as expected now with this commit in place.
        
        stderr output of the crash:
        
            terminate called after throwing an instance of 'com::sun::star::lang::DisposedException'
        
        Backtrace:
        
            Thread 1 received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007f5bc1ca815f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007f5bc1c5a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007f5bc1c444b2 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007f5bc18a09eb in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #5  0x00007f5bc18affca in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #6  0x00007f5bc18b0035 in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #7  0x00007f5bc18b0288 in  () at /lib/x86_64-linux-gnu/libstdc++.so.6
            #8  0x00007f5bc02b4550 in accessibility::AccessibleContextBase::ThrowIfDisposed() (this=0x55a6fc7e7da0) at .../libreoffice/editeng/source/accessibility/AccessibleContextBase.cxx:494
            #9  0x00007f5bbcf7d54e in accessibility::AccessibleShape::getAccessibleName() (this=0x55a6fc7e7da0) at .../libreoffice/svx/source/accessibility/AccessibleShape.cxx:280
            #10 0x00007f5bada62107 in QtAccessibleWidget::text(QAccessible::Text) const (this=0x55a6fad4fe20, text=QAccessible::Name) at .../libreoffice/vcl/qt6/../qt5/QtAccessibleWidget.cxx:362
            #11 0x00007f5bac5552d2 in AtSpiAdaptor::accessibleInterface(QAccessibleInterface*, QString const&, QDBusMessage const&, QDBusConnection const&) (this=0x55a6f769bce0, interface=0x55a6fad4fe20, function=..., message=..., connection=...)
                at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1545
            #12 0x00007f5bac553cce in AtSpiAdaptor::handleMessage(QDBusMessage const&, QDBusConnection const&) (this=0x55a6f769bce0, message=..., connection=...)
                at .../qt5/qtbase/src/gui/accessible/linux/atspiadaptor.cpp:1432
            #13 0x00007f5baaa88943 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, QDBusMessage const&, int) (this=0x7f5ba4010f30, node=..., msg=..., pathStartPos=27)
                at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1448
            #14 0x00007f5baaa89628 in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x7f5ba4026980) at .../qt5/qtbase/src/dbus/qdbusintegrator.cpp:1604
            #15 0x00007f5bad044013 in QObject::event(QEvent*) (this=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qobject.cpp:1447
            #16 0x00007f5bab1a6986 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=0x55a6f631c3e0, receiver=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3298
            #17 0x00007f5bab1a6797 in QApplication::notify(QObject*, QEvent*) (this=0x55a6f63bb840, receiver=0x55a6f769bce0, e=0x7f5ba4026980) at .../qt5/qtbase/src/widgets/kernel/qapplication.cpp:3249
            #18 0x00007f5bacfb0212 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55a6f769bce0, event=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1138
            #19 0x00007f5bacfb0dbb in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55a6f769bce0, event=0x7f5ba4026980) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1581
            #20 0x00007f5bacfb2474 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=0x0, event_type=0, data=0x55a6f6337df0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1936
            #21 0x00007f5bacfb160e in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=0x0, event_type=0) at .../qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1770
            #22 0x00007f5bad43441c in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x55a6f642f710) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:244
            #23 0x00007f5bb47111f4 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #24 0x00007f5bb4714317 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #25 0x00007f5bb4714930 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #26 0x00007f5bad434cb1 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55a6f6435dc0, flags=...) at .../qt5/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:394
            #27 0x00007f5baa929e18 in QXcbGlibEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x55a6f6435dc0, flags=...) at .../qt5/qtbase/src/plugins/platforms/xcb/qxcbeventdispatcher.cpp:96
            #28 0x00007f5badad8bea in QtInstance::ImplYield(bool, bool) (this=0x55a6f6442080, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:424
            #29 0x00007f5badad8d13 in QtInstance::DoYield(bool, bool) (this=0x55a6f6442080, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt6/../qt5/QtInstance.cxx:435
            #30 0x00007f5bb8734af6 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:386
            #31 0x00007f5bb8735894 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:470
            #32 0x00007f5bb87347e9 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:364
            #33 0x00007f5bc1e36e66 in desktop::Desktop::Main() (this=0x7ffc62160570) at .../libreoffice/desktop/source/app/app.cxx:1614
            #34 0x00007f5bb8753ca0 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:229
            #35 0x00007f5bb8753fb5 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:261
            #36 0x00007f5bc1ea4101 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94
            #37 0x000055a6f46e19d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #38 0x000055a6f46e19ba in main (argc=2, argv=0x7ffc62160798) at .../libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Iae8a9ff61df99094b4cd73da895d1f6ac850c0c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162493
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [e44a322fd00e017ea6494d836f66e5ddf6cfa9d5]

        tdf#154381 qt weld: Allow setting message box default button
        
        Implement `QtInstanceMessageDialog::set_default_response`
        by identifying the `QPushButton` in the `QMessageBox` that
        has the `QMessageBox::ButtonRole` corresponding to the
        given VCL return type and setting that as the default
        button in the `QMessageBox`.
        
        With this in place, the qt6 welded message dialog that
        shows up when opening a file that's already open in another
        instance of LibreOffice (s. `AlreadyOpenQueryBox::AlreadyOpenQueryBox`)
        has initial focus on the "Open Read-Only" button when it opens,
        just as is the case for the non-welded one
        (whose use can be forced by setting env var
        `SAL_VCL_QT_NO_WELDED_WIDGETS=1`).
        
        Change-Id: I6d543b43cb6adec2dde9646e1452aa03bdcbf331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162441
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [bb0c0e422788b6c461387491c59911ad84c27b83]

        tdf#154381 qt weld: Add button handling for message box
        
        Override the `QtInstanceDialog` methods `add_button`
        and `run` in `QtInstanceMessageDialog`, and implement
        handling for these buttons with the native
        `QMessageBox` that is used internally:
        
        Implement `QtInstanceMessageDialog::add_button` to
        make adding buttons to the welded message dialog
        work.
        Map the VCL response type to a corresponding
        `QMessageBox::ButtonRole`. Some mappings are
        straightforward, others are a bit more arbitrary,
        but the only essential thing is that the mapping
        back to the VCL response code is consistent.
        
        `QMessageBox::exec` [1] overrides `QDialog::exec` [2],
        and while the int returned by the latter corresponds
        to a `QDialog::DialogCode` code, the int returned by
        the former corresponds to a `QMessageBox::StandardButton`
        value. Since the current `QtInstanceDialog::run` implementation
        relies on the `QDialog` behaviour, override it for the
        message dialog case. Since the `QMessageBox::ButtonRole`
        is set in `QtInstanceMessageDialog::add_button`, retrieve
        the corresponding role from the clicked button instead
        of using the return value of the `QMessageBox::exec`
        to be able to get the correct VCL return code again.
        
        With this in place, the qt6 welded message dialog that
        shows up when opening a file that's already open in another
        instance of LibreOffice (s. `AlreadyOpenQueryBox::AlreadyOpenQueryBox`)
        shows buttons and clicking any of them
        behaves as expected, just as is the case for the non-welded one
        (whose use can be forced by setting env var
        `SAL_VCL_QT_NO_WELDED_WIDGETS=1`).
        
        [1] https://doc.qt.io/qt-6/qmessagebox.html#exec`
        [2] https://doc.qt.io/qt-6/qdialog.html#exec
        
        Change-Id: Ie37573951302f13eab758f889d478dc9351e9c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162440
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [ae910722fcd778d71c9e73a860a9ad94eb449608]

        qt: Move VCL -> Qt accelerator text handling to QtTools
        
        Move the functionality to convert a string (potentially)
        containing a VCL-style accelerator ('~') to the Qt equivalent
        from `QtMenu::NativeItemText` to a new helper function
        `vclToQtStringtWithAccelerator` in QtTools.hxx
        
        This will be reused for button text in welded message dialogs
        in an upcoming commit.
        
        Change-Id: Ibedabb7937b97d195244045799c092463810d766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162439
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [528f38807280a12fc4d562857e2281c2e7c86344]

        qt weld: Add assert on unhandled VCLButtonsType
        
        `vclButtonsTypeToQtButton` handles all of the 6 existing
        `vclButtonsTypeToQtButton` enum values, so there's no need
        to add more.
        Therefore, replace the comment with a failing assert for the
        default case that should never get hit.
        
        (If more `VclButtonsType` enum values should get added
        in the future, those should explicitly be handled here.)
        
        Change-Id: Iddb891399798156a266657c88cf6aed77a77f6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162438
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [d76d4df7ea1db0fdd27d350119ff7c0b2024b6e1]

        tdf#154381 qt weld: Implement QtInstanceWindow::{g,s}et_title
        
        Implement methods to set and get the window title.
        
        In order to do that, add a `m_pWidget` member to
        `QtInstanceWindow`. For the `QtInstanceDialog` case, that widget
        is a pointer to the same dialog that `QtInstanceDialog::m_pDialog`
        points to, which is a unique_ptr and thus takes care of the memory
        management.
        
        The non-dialog case is not supported yet, s.a. this commit
        adding support for simple welded message dialogs initially:
        
            commit 1ace888823443b85d4a81b94656844f1b27e2987
            Date:   Wed Dec 20 19:13:50 2023 +0530
        
                tdf#130857 Use native qt widgets - simple message dialog
        
        With this in place, the qt6 welded message dialog that
        shows up when opening a file that's already open in another
        instance of LO has the correct title ("Document in Use"),
        just as is the case for the non-welded one
        (whose use can be forced by setting env var
        `SAL_VCL_QT_NO_WELDED_WIDGETS=1`).
        
        Change-Id: I35f323cdfa70fb953b6bc73aaf726fb1f3098c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162437
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Michael Weghorn  <m.weghorn@posteo.de>  [8efcb80c95ab173a3931da3b35fc1b5bf1e4e0d2]

        qt weld: Make QtInstanceDialog::m_pDialog private
        
        Change-Id: I757849beb06d0ce986be352feb34af463430333b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162436
        Tested-by: Jenkins
        Reviewed-by: Omkar Acharekar  <omkaracharekar12@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-24  Patrick Luby  <plubius@libreoffice.org>  [b873dc28d9a5896cdf8b842742d191218a91ff41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d2a29ee4f4556b0133e73ea429c9c1aaede0581
          - tdf#159307 macOS uses Command+Option+F while other plafforms use Ctrl+H
            
            Change-Id: Iee37805afba1aa712a45c213d1f9eeae4d01d923
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162452
            Tested-by: Jenkins
            Reviewed-by: Patrick Luby <plubius@libreoffice.org>
            
2024-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [863a4cde77a5045d44b1da583f00c0a72762f19a]

        tdf#159336: export EditWidget with multiline enabled
        
        How to reproduce it from scratch:
        1. Open writer
        2. Form - Content Controls - Rich Text/Plain Text
        3. Split the control intro different lines
        4. Export to PDF
        
        -> The content control is displayed in one line
        
        Change-Id: Ia8666c8a6520e94ae06693ea8767c1d79aa5d3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162446
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2024-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fd156c9c2ff1b10e1f3d72c0001f36676e412e5b]

        SfxViewShell::GetFirst lambda is never passed a null pShell
        
        it's null checked before the lambda gets called so make this a
        reference
        
        Change-Id: Ib8804a2003cbdc6b7b62d8a38fa514d0ce08128c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162495
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5950db59fc3f834425c342fff5a0fe9987d72144]

        suppress COPY_INSTEAD_OF_MOVE suggestions for rtl::O[U]String
        
        where we have implemented move assignment to take let the compiler take
        advantage of any little optimization possibilities that it can take but
        where the potential optimization probably doesn't outweigh enforcing
        dusting error-prone std::move all over every case where the compiler
        doesn't/can't use the move assignment but could.
        
        so convert the myriad of micro optimization warnings into a single
        missing move assignment warning which can be then suppressed.
        
        Change-Id: I664193f9a2ac5014cf8d5134105ebd3a36857830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-24  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [64503f9187252c7ebf85832cca65c0642013bc38]

        ITEM: Add some default global sharing
        
        As addition to tdf#158605 I have added a
        global default mechanism to support global
        sharing of Item instances. It's automated
        and complements the existing one, see one
        of the last commits. All in all there are
        now the following possibilities to support
        this for individual Item derivations:
        
        (1) Do nothing: In that case, if the Item
        is shareable, the new mechanism will kick
        in: It will start sharing the Item globally,
        but not immediately: After a defined amount
        of allowed non-shared ocurrences (look for
        NUMBER_OF_UNSHARED_INSTANCES) an instance
        of the default ItemInstanceManager, a
        DefaultItemInstanceManager, will be incarnated
        and used. NOTE: Mixing shared/unshared
        instances is not a problem (we might even
        implement a kind of 're-hash' when this
        kicks in, but is not really needded).
        
        (2) Overload getItemInstanceManager for
        SfxPoolItem in a class derived from
        SfxPoolItem and...
        
        (2a) Return a static incarnation of
        DefaultItemInstanceManager to immediately
        start global sharing of that Item derivation.
        
        (2b) Implement and return your own
        implementation and static incarnation of
        ItemInstanceManager to do something better/
        faster that the default implementation can#
        do. Example: SvxFontItem, uses hashing.
        
        The NUMBER_OF_UNSHARED_INSTANCES is currently
        at (50) which gives a decent relationship
        bewteen no global sharing (speed) and memory
        needs. Not sharing is faster (that access to
        'find' an equal item is spared which might be
        costly), sharing again needs less memory.
        
        There are two supported ENVVARs to use:
        
        (a) SVL_DISABLE_ITEM_INSTANCE_MANAGER:
        This disables the mechanism of global Item
        sharing completely. This can be used to test/
        check speed/memory needs compared with using
        it, but also may come in handy to check if
        evtl. errors/resgrressions have to do with
        it.
        
        (b) SVL_SHARE_ITEMS_GLOBALLY_INSTANTLY:
        This internally forces the
        NUMBER_OF_UNSHARED_INSTANCES to be ignored
        and start sharing ALL Item derivations
        instantly.
        
        Change-Id: I40d9c5f228f0bcbf239f2ce0a02d423054240570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162478
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2863329783e6507af4cbac796b5b3767f277d75d]

        Fix typos
        
        Change-Id: I2eb42da2971c5fad5b7f023b17315f556a3cbb88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162479
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9f98de005cdbb65193907cb8f17c258247bd428]

        split out move and insert table logic from ScTabViewShell::ExecuteTable
        
        Change-Id: Id56b65e94d553a644f32e9cf7a91ff797bda6bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [850b3e9d674bde31b727276b250180798e669462]

        split up large method ScViewFunc::PasteDataFormat
        
        Change-Id: I71c60af424aa317dd1cbc3568e171aba3a96c8fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae591835dc6b2c18169c2685fbc7e9fb958bf369]

        sfx2: check SfxViewShell::Current()
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/52df6de5-7ea8-48e4-8c45-f18b02d9a767
        
        Change-Id: I56c17234a0f82797d37e26b0c39eeba7f78fcee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162492
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ebd97f4b8c598f8982446aac06fbb45341d8c2cf]

        make these inlines non-static
        
        Change-Id: Icf0f79b7673df1e147a57e796faf82dfd0e01b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [52188252bb5d44e15266b84b771599a453438ba6]

        Related tdf#158749 The "Go to Line" dialog should not be resizable
        
        Change-Id: I93c5c1b4a2832b60e194abd7e7d528362885bb24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162461
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9ee88cc47783a809f6c49f5b7326180dc0bbead]

        make text-table dialog async
        
        Change-Id: Ic24b2b935f1d539cf257194d136d901b52e00a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ad8248bcc7ed19285147aeff777771a508453a61]

        sd: remove condition to only show ThemeDialog in master view
        
        Change-Id: I09ce07f7b520688aa54dd30107b5ab2218b12894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156277
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 62804da3c0ab9443cf36f2e02387a2e9c272d5dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-24  Miklos Vajna  <vmiklos@collabora.com>  [7d9e3df6d6c26508c06fff306b443356c6d499ea]

        CppunitTest_sw_ooxmllinks: rework to avoid DECLARE_LINKS_IMPORT_TEST
        
        No need go via Writer-specific macros.
        
        Change-Id: I6918fe2946a24b97bf7d79e0a4f99cf1ae85b5a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162490
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5babeba8d9e5087ea974a3b656543fd8e5a1d93e]

        complete filename isn't meaningful in this mode
        
        Change-Id: Icc5bdac688ca6b328dcf097c9638b4e6df211332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b840110ffc1c30ba9dd242efd6692d5ae16bbda3]

        add #include unordered_map
        
        Change-Id: Ieaba8db5df426ed30aca7366a86ee4fb11e03a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162480
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2c16ea16b305dc546164e28cf6b212ebccc44ec4]

        tdf#159128 UI: Open Security settings option directly
        
        Open Security Option Setting page directly from Security pop up
        warning infobar.
        
        Follow up of 1f440348eb0892fd2c9597806d87b5fe9d60d49a
        (tdf#157482 UI: Turn Security Warnings popup windows into infobars)
        
        Change-Id: Iac116677801bdb13a9680bcfdf532ec3d874ce0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162393
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-01-24  Jim Raykowski  <raykowj@gmail.com>  [0854ec14b04a8b7a7ec9be88e8aa19105eead1a3]

        Resave with newer Glade version
        
        Change-Id: I346e62a90c28012aeb403de263f0aa2f01a4a8fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161778
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-24  Jim Raykowski  <raykowj@gmail.com>  [d034a0da1a298bb129d7a7cecff460794649dea0]

        SwNavigator: status array no more
        
        What REGIONMODE_ARY has to do with the active, inactive, and hidden
        status of documents shown in the document list box is beyond me. This
        patch removes this strangeness and fixes the 'Active Window' entry so
        when selected the content tree shows the content of the document
        entry appended with (active), which is always the document in the
        view afaik. My guess at the idea for the 'Active Window' entry is to
        not have to search for the entry marked 'active'.
        
        Change-Id: I27a8183fb430e9d5ef465dae323319cdb397fc4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161510
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-24  Noel Grandin  <noelgrandin@gmail.com>  [76e9023c8abc823447b1128056e55238f90da8d6]

        convert more calc dialogs to async
        
        Change-Id: I6349942f0a4d6156ef59f43a6e96049128f47524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-24  Hossein  <hossein@libreoffice.org>  [0d37cbb937e4c8a72de07621ae7d4943b4a032e8]

        Normalize include syntax in include/LibreOfficeKit
        
        Changed #include <LibreOfficeKit/...> to #include "..." in the header
        folder include/LibreOfficeKit/.
        
        The reason is described in:
        
        C[++]: Normalizing include syntax ("" vs <>)
        https://lists.freedesktop.org/archives/libreoffice/2017-November/078778.html
        
        Change-Id: I8ccbbde38eb649428f99e39b6f0529dffc3e4206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161809
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-24  Mike Kaganski  <mike.kaganski@collabora.com>  [41356475d08f28b8fba0830b4a89bd0c6b58e2b9]

        Some refactor of Win32 loader
        
        Change-Id: If019677d24a56c46f06b31a15a18a615b62a6806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162445
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-23  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [d0dcd87788910e3c9f67a2b68534019c05b77bad]

        Make wholesome ODF package encryption the default
        
        Change-Id: I825ae7a5e4b80d390804a7bb2cfdfc3b1843bd07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162066
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac1cafad398b13a831de913e11143760fd6b822b]

        produce non-overlapping invalidation rects on extending calc tiled area
        
        the intent is to create two rects, one for the area extended to the
        right and another for the area extended to the bottom, but they overlap
        so they end up merged and a single rect of the entire sheet is created
        which is defeats the original intention.
        
        Change-Id: Ie5b46ee1a36780d9f7a90ed11ebfd1264c17477a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162412
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-23  Martin Srebotnjak  <miles@filmsi.net>  [509a24657a8afa130e0644d6e7d8af581692ce62]

        Update git submodules
        
        * Update translations from branch 'master'
          to d87db1c95a1936c059491b083e508acdd13f2ccd
          - Updated Slovenian translation
            
            Change-Id: I0fbab3525dc988b1294d825d4e09f60f9f1ec874
            
2024-01-23  Miklos Vajna  <vmiklos@collabora.com>  [6e3ad6ca0ae6cf62056610ddae9097973a887d99]

        tdf#159017 sw floattable: only shift to the right when needed
        
        Regression from commit 868140fcc1311259b9d5f666637b33d226511a53
        (tdf#60558 sw floattable: allow wrap of table on the right of a
        floattable, 2023-12-05), the document had an inline table, followed by a
        floating table, and we moved the inline table to the right even if the
        left hand side of the floating table already had enough space.
        
        What happens here is that nominally the inline table's original position
        overlaps, but because the table width is small enough, such an overlap
        doesn't actually happen. In this case, it's not needed to shift the
        inline table to the right.
        
        Fix the problem by making the check that decides whether it's necessary
        to increment the left margin of the table more strict: it's not enough
        to have enough space on the right of the fly, it's also needed to *not*
        have enough space on the left side.
        
        This keeps the original "floating table wrapped by inline table on the
        right" use-case working, but restores the ~no left margin for the inline
        table for the new bugdoc.
        
        Change-Id: Ifb30d90ca6dba7cc4a402d8a4445251120b575ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162447
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [063781f4a94e3960a2cb40d1981c0e0ef9a73153]

        tdf#158605 Add global SfxPoolItem re-use
        
        The task shows that the commit including the Item
        paradigm change has follow-ups: It now does no
        longer try to share Items as much as possible
        (detailed reasons in that commit). Mainly for speed
        reasons since that sharing was done before by
        (mostly) linearly searching in existing instances
        registered at one Pool, using the operator== of the
        SfxPoolItems. That costs runtime.
        
        There is somewhere a sweet-spot between memory and
        runtime: the number of Items allocated and the time
        spent to share them more effectively. This task shows
        - despite being a non-real-world document - that
        for extremes like this putting work in sharing is
        still needed.
        
        But there are possibilities to combine both: If we
        can implement solutions that do not need much time
        to ideintify an aleady existing instance we will get
        the best of both worlds.
        
        As explained already in that change, if we would
        need that again, then on a better base. Thus I drove
        forward ITEM changes to a state where we are now able
        to share Items globally in the office - not per pool
        but for all ItemSets/ItemHolders and thus all Apps/
        Models/opened documents.
        
        NOTE: This currently needs to include the WhichID
        that is included in the Item, so cannot share pure
        Item-data (as the old usage did too). This does not
        need to stay that way: If you think about it, the
        association between WhichID and Pool/Holder is
        defined in Pool/Holder, so theoretically the Item
        does not need to contain the WhichID. This will
        be hard to do due too many places in the code that
        use the WhichID stored at the Item.
        
        To support that I added an ItemInstanceManager with
        a simple interface (find/add/remove) and it's usage
        in the two central Item-existance managing methods
        implCreateItemEntry/implCleanupItemEntry. The
        interface is pure virtual and all methods private,
        only the mentioned managing methods are allowed to
        access these. Also added a virtual method to
        SfxPoolItem called getItemInstanceManager() that
        can be implemented by Items that want to support
        that.
        
        Also added a default implementation of
        ItemInstanceManager called DefaultItemInstanceManager
        that uses linear search using operator== from the
        Item that can be used/added to every Item easily.
        It works for all Items and does in principle what
        the former implementation does. It is intended as
        simple/fast fallback.
        
        I also added a statistic element to measure the most
        used non-RefCounted Items on an Office-run, this
        will be printed at office shutdown using SAL_LOG
        and the 'svl.items' flag.
        
        I then checked all Items that were used in this
        error/bug scenario that used an extensive number
        of incarnations and added an ItemInstanceManager
        for these.
        
        For SvxFontItem I added one that creates a hash and
        thus needs not to search for instances at all, with
        the caveat that the WhichID needs to be included.
        Thus the hash is not at the Item, but only in the
        ItemInstanceManager implementation.
        
        For SfxBoolItem I implemented one that hashes using
        the WhichID and holding both possible states in an
        associated std::pair, true and false, thus the
        SfxBoolItem is identified fast and only two instances
        per WhichID exist (when used in Pool/Holder).
        
        For 11 other Items I just added using the standard
        implementation, DefaultItemInstanceManager. Of
        course the more we optimize the better it will get.
        
        For all Items where I added that mechanism I also
        added ASSERT_CHANGE_REFCOUNTED_ITEM to all write
        calls/methods for that Item. It asserts when the
        RefCounted Item is to be changed. This should be
        done in all write accesses to Items, but we have
        ca. 500 derivations.
        NOTE: There was *one* place I found where that
        was already done -> was alredy seen as problem,
        but not really adressed.
        
        Despite this example file is not representative,
        it is still a start to init this new instance
        re-use of Items.
        
        I am already thinking about doing that globally,
        depending on the usage number (maybe combined with
        sizeof(item)). There is no argument to not even
        change strategy at runtime when a specific number
        of incarnations of one Item derivation is reached,
        but this is not part of this fix.
        
        Change-Id: Ie56cf40e0341f98dcbf29cf5c06368316829415e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162402
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e161e5dcbfb1be0d9aa347de42c72b3578d1e00]

        make the macro assign dialog async
        
        Change-Id: I6a23f648784f61e72e6095b249719d9c8630252f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162444
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [edf4ad7d9f3f09e5f47993c305451c4fc86359d3]

        MAR update, too big to (not) fail
        
        On Windows, when a MAR update generated by create-partial-info contains very
        many patches (as easily happens with LibreOffice), applying it would fail with
        "failed: 7" (aka WRITE_ERROR, see
        workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/common/updatererror.h)
        because in
        workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/updater/updater.cpp
        PatchFile::mPatchStream holds open one FILE instance per patch from
        PatchFile::Prepare to PatchFile::Execute (and which can't easily be reworked
        because of the Lock/UnlockFile done on the underlying HANDLE "so it can't be
        messed with [in] between"), so calling NS_tfopen in PatchFile::Prepare will
        eventually start to fail with EMFILE.
        
        To avoid that, try to raise the limit to its maximum (but don't fail immediately
        if that fails, in case the given MAR update wouldn't run into the issue of too
        many patches, anyway), and keep fingers crossed.  (See
        <https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setmaxstdio?view=msvc-170>
        "_setmaxstdio" for details:  "By default, up to 512 files can be open
        simultaneously at the stream I/O level.  This level includes files opened and
        accessed using the fopen, fgetc, and fputc family of functions.  The limit of
        512 open files at the stream I/O level can be increased to a maximum of 8,192 by
        use of the _setmaxstdio function.")
        
        Change-Id: I6b3499f0f6c2060628418a15f5e36021bfe7dd18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162442
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [8718e362d8bb6fe3ac285ef355fc29d5756e1e92]

        tdf#157628: sw_layoutwriter: Add unittest
        
        Change-Id: I8d1a471d8edab9e789311a8a1d20bd21c0f47cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162435
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-23  Justin Luth  <jluth@mail.com>  [ca29c240dbfe6396115c961d27b1bf13a65793c2]

        tdf#159158 writerfilter: improve m_bBehindDoc/m_bOpaque documentation
        
        Change-Id: I370f7a030da6949df3d51a5e3b5a6c854238d036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162405
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea88508c9f23e1594a77c287d5a6c86e6b92d870]

        make signature line dialog async
        
        Change-Id: I64cb2ae5b3748e8034fb0624b56c3d3dfdc31654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [f690e8218a74a0f7792407a1d46198883d2528ff]

        make event config dialog async
        
        Change-Id: Ibbfbc5024fb2be4906d0c312577310f28dde212d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Michael Weghorn  <m.weghorn@posteo.de>  [6e20e58270c88c8c77f156be75c23c66e1169e44]

        tdf#159333 qt a11y: Process shortcuts only once
        
        As described in
        
            commit 69e708868f6046cada955a16bca966370ce3218a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Feb 20 08:14:36 2020 +0100
        
                tdf#130794 qt5: Actually, ignore non-spontaneous QEvent::ShortcutOverride
        
        and the previous
        
            commit 034f56015c1c7a61faede33fb5306f63b5585632
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Feb 17 10:38:15 2020 +0100
        
                tdf#126785 qt5: Ignore external QEvent::ShortcutOverride
        
        it refers to, duplicate events of type
        `QEvent::ShortcutOverride` are received when a11y is
        active, so those commits introduced ignoring of the
        non-spontaneous one, and leaving processing for the
        spontaneous event only, thus preventing duplication of
        typed text.
        
        However, keyboard shortcuts like Ctrl+V were still
        processed twice: While they're only processed once
        in `QtWidget::handleEvent` (for the spontaneous
        event of type `QEvent::ShortcutOverride`), the keyboard
        shortcut was additionally handled as the shortcut to
        activate the action that's used for the menu entries,
        e.g. the "Edit" -> "Paste" menu entry for Ctrl+V
        (s. class `QtMenu`, where those are set).
        
        Accept the non-spontaneous `QEvent::ShortcutOverride`
        event to prevent that from happening.
        
        Quoting the `QEvent::ShortcutOverride` doc [1]:
        
        > Key press in child, for overriding shortcut key handling (QKeyEvent).
        > When a shortcut is about to trigger, ShortcutOverride is sent to the
        > active window. This allows clients (e.g. widgets) to signal that they
        > will handle the shortcut themselves, by accepting the event. If the
        > shortcut override is accepted, the event is delivered as a normal key
        > press to the focus widget. Otherwise, it triggers the shortcut action,
        > if one exists.
        
        With this commit in place, the shortcut is only
        processed once, as expected.
        
        Potentially, this should ideally be addressed on Qt
        side in the future, see the discussion in tdf#126785.
        
        The duplication happens since this qtbase commit
        (no longer with a local revert of it): [2]
        
            commit 7c532891e0be2cf78c89738e175b3d312d305e4e
                Date:   Tue Apr 17 16:45:09 2018 +0200
        
                Send ShortcutOverride event when receiving a non-spontaneous key press
        
        Since 2020, there a pending Qt change by Alexander Volkov
        suggesting to avoid the duplicate events by filtering them
        out in `QSpiApplicationAdaptor::eventFilter` on qtbase
        side: [3]
        
        With that change not being merged yet, fix this on LO side
        for now.
        
        [1] https://doc.qt.io/qt-6/qevent.html#Type-enum
        [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=7c532891e0be2cf78c89738e175b3d312d305e4e
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/295892
        
        Change-Id: I28cb11914ae81284e050bff0deb39d95e8073ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162430
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-23  Chenxiong Qi  <qcxhome@gmail.com>  [74de0ebb810f3e13c45f01c63067cb8de794ce3c]

        tdf#97361 Make unittests more pythonic: XIndexAccess
        
        Change-Id: I05ef274dd0ad5dc35b5455cfc01feabc6c0820a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161276
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-23  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [3a20c691ab1d6a16ad0fc144926b22c098552be4]

        tdf#138792: PDF export: export metadata dc:date
        
        Dublin Core attribute dc:date wasn't exported so far in the
        current implementation. Looking at the information pointed
        by http://purl.org/dc/elements/1.1/date, dc:date is a
        vaguely defined field.
        
        Now creation date is exported there, as I've came across
        the note of "Typically, Date will be associated with the
        creation or availability of the resource" in the resource
        linked below.
        https://www.dublincore.org/specifications/dublin-core/dcmi-terms/2005-06-13/#:~:text=Typically%2C%20Date%20will%20be%20associated%20with%20the%20creation%20or%20availability%20of%20the%20resource
        
        Change-Id: I0b5f37058f64e3d6d08cb46045a27ccde54ee434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162404
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [07b26af18d45ad7ecacc30c2c4cb2c23033e9f2d]

        make the graphic filter dialogs async
        
        Change-Id: I49a1ff800c6b5fcee69e160158a089659d288bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162422
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cece4bf4147fb1cedd7011b3487fd64ff6dbeba]

        make links dialog async
        
        Change-Id: I067d682ade01671d7aa347a492929ae4f92064b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162421
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [861e83d1e74a718462ba524695cfa6ccb13bf7db]

        we seem to need three extra rows in ScTableInfo
        
        or we get lots of
           OSL_FAIL("FillInfo: Range too big" );
        from initRowInfo()
        
        regression from
            commit a86c00414a43c5d87981ffae1018cb242c5e5e1d
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 19 14:27:10 2024 +0200
            cool#6893 reduce allocation in ScGridWindow::PaintTile
        
        Change-Id: I44a925ffab756e52c49280b864a3d4190e9e9b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162431
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 3e865d91e1bb4396957b5feee3c4475838c70e8b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Bayram Çiçek  <bayram.cicek@collabora.com>  [e0ef57a2d05cacc4e8bf215e8086924b239cc2e1]

        sc: make inactive sheets movable and copyable
        
        - move and copy use the same ScViewFunc::MoveTable
        function
        - added 3 new parameters to "SfxVoidItem Move FID_TAB_MOVE"
          - SfxBoolItem FromContextMenu FN_PARAM_4,
          - SfxUInt16Item ContextMenuIndex FN_PARAM_5,
          - SfxBoolItem MoveOrCopySheetDialog FN_PARAM_6
        - moveLeft and moveRight of inactive tabs are implemented
        - move and copy of inactive tabs from the Move/Copy Sheet
        dialog are implemented
        - made Move/Copy Sheet dialog async
        
        Change-Id: I97461780a6c46f601bce9490315cd5cbea9505d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158078
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 4d5f8b43b04734805f48b921b98a74fd9ab67d0f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [d9d9ec70395ed5ad8ac4b985b8c9215af7436258]

        tdf#158749 Open "Go to Line" dialog from the statusbar in Basic IDE
        
        With this change, if the user clicks the StatusGetPosition item in the status bar, the Go To Line dialog will be shown.
        
        Change-Id: Iba75e2dbf6ba83fce24e1af237bdf9813d4ecb69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162108
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-23  Sahil  <me.sahilgautam@gmail.com>  [4377341dd287b863573bb40ed77e2e2caa92b358]

        tdf#158891 Make cell cursor more accessible for color blind
        
        * Add an option to configure the accent color, which is
          blue by default might not be visible to color blind people.
        
        Change-Id: I72cbb0f57e864407a7c9315b5c46645a891d4764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162055
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2024-01-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [98623ff0cddb15af0086885e5bf3361da8106ff8]

        BOOST_ERROR_CODE_HEADER_ONLY doesn't do anything in boost >= 1.69
        
        which was released on Dec 12th, 2018
        
        https: //lists.boost.org/Archives/boost/2021/10/252209.php
        Change-Id: I8d65d98648a44d7303fc46338bfdeba7801749e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162423
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [38072fd7eb7d53237efbe0d8bacc7db1c4f3131c]

        ITEM: Solve SfxVoidItem(0) situation
        
        An instance of SfxVoidItem(0) was used to signal
        the SfxItemState::DISABLED. This was done not only
        using WhichID == 0, but using isVoidItem() at the
        SfxPoolItem. Unfortunately this mixes up with usages
        of SfxVoidItems, mostly for UI stuff/Slots.
        This also means that all the time an SfxVoidItem
        had to be cloned/delete when when added/removed
        from ItemSet or ItemHolder. Much more action than
        e.g. for INVALID_POOL_ITEM which we already use
        by havong just a simple ptr to a single static
        instance of an Item. Disabled should do the same
        thing.
        Unfortunately also the functionality was mixed
        with non-SfxItemState::DISABLED purposes and these
        were very hard to be separated.
        But the current solution works now after some
        quirks doing that. It even oes no more need the
        isVoidItem() flag at the SfxPoolItem.
        
        Change-Id: I99f03db144f541ae4ea35f3775b3b3d58a375a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162414
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-23  Miklos Vajna  <vmiklos@collabora.com>  [db4cb7cee82615973d1be9fd631c1317f1da5820]

        sw: document SwFrameDlg
        
        Frame in this context means the highlevel TextFrame on the UI, not
        layout frames.
        
        Change-Id: I2b2753e8c940451d52ed642505a889177af6875c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162428
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-23  dholden  <dhiraj.holden@gmail.com>  [91ba7d22b0df33a3ca4102bc77869fe89921c34e]

        tdf#149940 Fix vlookup result with OpenCL
        
        This patch fixes the vlookup result in sorted order using OpenCl.
        The issue was that the loop unrolling would cause the loop to exit early. This has been fixed to only happen in unsorted mode.
        
        Change-Id: I7aba7b301c87061bc33128c8930ef3c55dc3c386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162363
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  AmosAidoo  <aidooamos20@gmail.com>  [e3d03fa00d49c164ec235d77c827109eac522623]

        tdf#114441 convert sal_uLong to appropriate types
        
        svdfmtf.cxx and .hxx
        GetActionSize returns a size_t value
        The parameter 'a' is compared to a size_t value
        
        svdmark.cxx
        GetOrdNum returns a sal_uInt32 value
        
        svdview.cxx
        GetLineCount returns a sal_uInt32 value
        
        Change-Id: I85a0303742607208fdbfb7783e7254847720a2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162416
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb6634fdda76f6bc2909b01770f4ebe28873e7af]

        make sign signatures dialog async
        
        Change-Id: I7c088b1450050720a28fbc7ccf139b8c69f1cf19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b517f9d4fdafbe7a8db8b7ed3c9e0f09f50cfda]

        make additions dialog async
        
        Change-Id: I239d8d344ed3152586567c6e1d9b529ba75925dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cee40936ef39a61c56779e6059e79e7ea6b3961]

        make diagram dialog async
        
        Change-Id: I26ec71ab5b00545a2e173dd4cc3dcd49d79c2fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [13a11632014ccc27199667c6a1e313f8ff616d6d]

        tdf#159259: make sure to set FieldStartRange in sdt helper
        
        ... also for field case.
        Unfortunately, it is not really clear, if the anagement of this could
        be moved to DomainMapper_Impl. There are several insertion contexts;
        they may use different insertion points; there maybe could be cases
        when an inserted content should not go into the current sdt (?). Thus,
        I didn't put the code into DomainMapper_Impl::appendTextContent(),
        where the field character is inserted. Instead, I added code to check
        and set the start range in the same place as for the normal text: we
        know for sure, that if it were a normal text, we would append it to
        GetCurrentTextRange()->getEnd() - so do the same for fields.
        
        My concern that still stays is that the use of hasUnusedText looks
        hackish and fragile. Inserted fields don't set it - so the code that
        depends on empty sdt will not notice it. OTOH, it can't set it: this
        would break inserting field result for an already inserted command.
        Possibly all handling of sdt should be refactored at some point.
        
        Change-Id: I7a783aab2400d9a9c1f9f2e5607c872cb58d346b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162398
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d71c21890c908225945f0fc3566255ed150f660]

        don't always invalidate the entire width of the calc window
        
        If know the max width affected we can avoid redrawing much of
        the row
        
        LTR cell edits, deletes, single line paste
        
        Change-Id: Ib7e3d8bfa3a5ce7df97f28bcf7858b3abcb752a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162408
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca324febda317a725e214b24c0d479d8dbbf1f03]

        cid#1557299 suppress Missing move assignment operator
        
        Change-Id: I1006d4bba5d6d254b37267b6d1a58ef11c8adcc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162407
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-22  Julien Nabet  <serval2412@yahoo.fr>  [20f122eb7b0d301d4e937c346f4c3c824690882d]

        tdf#159326: Command-F assigned to both Find and Find and Replace in Calc
        
        Regression from e651d9e657f9b61fb45777d6e7edeb5cb95f8d27
        German shortcut improvements for Calc
        (2023-09-27)
        
        Change-Id: I4440663025e3eb85c8c73a624769ceec527daa1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162413
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2024-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [587d9c6bdae11ef9b962679e6c81d3301dd20ab7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c4fdb89c9810bd961717a09a4c4cf177fa5b3d5
          - tdf#159111 add .uno:PickList to Help
            
            + File menu command is now .uno:PickList and not .uno:FileMenu anymore
            + .uno:PickList is common to all modules
            + Refactor file menu into one Help page, with module switch
            + Adjust tree
            + remove old file menus help page main0101.xhp
            
            Change-Id: I7fc9d07fdcca1d4a3062e656f81a0bafd6bafa44
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162415
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e1e6e8cea3512782df9eccbf6e1c59cb41b83224]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad8d101fec688539999cab824616f990a2cb0293
          - tdf#155875 UI cmds Format Text (cont)
            
            + Small Capitals
            + Patch in advance of fixing bugs tdf#149409 and tdf#157358
            + refactoring
            
            Change-Id: Ibfc5bc8d0d9a3474914950232362ef94d2804880
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162397
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-22  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [58cfe9ccff7b6aa8ada18234ee73809700c39e02]

        tdf#38231 - Change default example date value to 1999-12-01
        
        Change default example date value from 1999-12-31 to 1999-12-01. Otherwise, certain date formats cannot be distiguished in the preview window, e.g., D MM (1 Dec / 01 Dec 99 vs. 31 Dec / 31 Dec).
        
        Change-Id: Iebd78de8d5ef8615c4f2bf400357745e7acfb857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162308
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0edec422600cce2b042d5414443ad25ab515f351]

        make object name dialog async
        
        Change-Id: Icf81810297dc5767cedd051cf8ccdfbb101f35ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162395
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [dde1868544bf325a359bdf4336623ac65e6ff4e0]

        object-title dialog can be used async
        
        Change-Id: Ia5869788ccefcd17ef561bafb41da6f0d48fd54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a5ef1a2b009f208745a251828bf8e8c51146bfe]

        make charmap dialog async
        
        Change-Id: I222240dc1715604ad1e82e1062b34d116b2840f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162367
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-22  Justin Luth  <justin.luth@collabora.com>  [05e637b36043fac83265bbdfbdba97632a8e939e]

        tdf#154703 writerfilter framePr: avoid unexpected frame borders
        
        This fixes my regressive 7.6 commit
        31ea6305b6a763ee48f639562313d9bd109a2923
        
        The text's first border checked (the left one) returned void
        because the property SetState was DONTCARE.
        Then it SETS the text's left border to be nothing
        (I presume to remove the border from the paragraph since
        it is moving it onto frame).
        Well, apparently that act of setting one border sets all of them
        (which makes sense since it would be one box item,
        and once the box item exists, it has a definition for each border).
        
        Therefore on the the next steps of the for loop,
        the remaining borders will exist (as nothing)
        and be dutifully moved to the frame.
        
        Apparently the default for a frame is a box with DEFINED borders,
        so omitting the moving of a nothing border resulted in a stray edge.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf159207_footerFramePrBorder
        
        Change-Id: I217d02678b368f70643be91c4466927b4ca53988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162409
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-22  László Németh  <nemeth@numbertext.org>  [9193e61d3e7b850b3715c848c09434e24855340b]

        tdf#106733 sw: fix bad downcast in SwTextNode::GetLang()
        
        Fix bad cast of SvxNoHyphenItem to SvxLanguageItem
        reported by <https://ci.libreoffice.org/job/lo_ubsan/3049/>:
        
          /sw/source/core/txtnode/thints.cxx:3560:16: runtime error: downcast of address 0x6030005e44d0 which does not point to an object of type 'const SvxLanguageItem'
          0x6030005e44d0: note: object is of type 'SvxNoHyphenItem'
           1a 00 00 00  90 e3 d5 77 5c 7f 00 00  00 00 00 00 13 00 be be  16 00 00 00 92 01 be be  00 00 00 00
                        ^~~~~~~~~~~~~~~~~~~~~~~
                        vptr for 'SvxNoHyphenItem'
              #0 0x7f5bda7e8c0c in SwTextNode::GetLang(int, int, unsigned short, bool) const /sw/source/core/txtnode/thints.cxx:3560:16
        
        Regression since commit b5e275f47a54bd7fee39dad516a433fde5be872d
        "tdf#106733 sw: implement CharNoHyphenation".
        
        Change-Id: I0c6f60a4074f8fd6da26674cace47f5c5e32afd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162401
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [084c64982ef6187292fd73e6deaa4448e0b6f3de]

        Create MAR updates from msi rather than from archive
        
        ...as the former is more convenient for release engineering (see the discussion
        in the comments at
        <https://gerrit.libreoffice.org/c/core/+/162157/1#message-8d7ebbcc64a87ee8e4a073ae1a05e3b74f5a3d6a>
        "Also enable --with-package-format=archive for LibreOfficeWin64.conf").
        
        Instead of ONLINEUPDATE_MAR_OLDARCHIVE and ONLINEUPDATE_MAR_OLDMETADATA make
        variables, the create-partial-info target now only needs an
        ONLINEUPDATE_MAR_OLDMSI make variable.
        
        TODO:  There are two issues when comparing the content of msi files (extracted
        with msiexec /a), which the old code comparing the content of archives had tried
        to somewhat (but not fully) address with the metadata files that I had invented
        (and now reverted):  For one, msiexec /a also extracts content that would
        normally be installed somewhere else in the system (e.g., it extracts Fonts,
        System, and System64 directories).  Differences in those directories will cause
        a MAR update to create those directories in the installation directory, rather
        than to update the corresponding files in their actual locations.  For another,
        optional components are not recognized as such, but their content must be added
        to the MAR file as add/patch-if, not as plain add/patch.  To work around that,
        for now *all* files are added as add/patch-if, conditional on the files
        themselves.  Thus, addition of files will cause a MAR update to miss them.
        
        (As they now exclusively operate on msi files, the create-update-info and
        create-partial-info targets are no longer meaningful for non-Windows platforms,
        so drop the non-Windows bin/update/create_full_mar_for_languages.py part.)
        
        Change-Id: Ifb55b5e7d1a201b4f50a27cb449a634b96c2e29b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162399
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4e7a0270c6efc371433c3c77772ca062d6747fe8]

        cid#1586676 Big parameter passed by value
        
        Change-Id: I803788650dda6947a62724fd936b4ed733efbd58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f46477e934e0bc1dc2e1da36f28db6d23bfeaa97]

        cid#1586675 Missing move assignment operator
        
        and
        
        cid#1586677 Missing move assignment operator
        
        Change-Id: I1bd2cd0f102d8ce44feb579b85c41b3c1f789f23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162369
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [27f15f1d50b1b67c940bf57e1581240011806159]

        simplify the getters in AbstractSvx*Dialog
        
        to look like getters elsewhere, which compose better
        
        Change-Id: I23277910d3fb3c08fa6e839f0fbec010915e951a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162362
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-22  AkshayWarrier  <aksmen121@gmail.com>  [e531242f62d27000ab5fefd6d63023d4a1060c75]

        tdf#148702 cui: Place dropdown before entry in Arrow Styles tab of Line dialog
        
        Change-Id: I4a0060422b55f681c3f4f0eb9a908d3b30faeb32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162347
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-22  Justin Luth  <justin.luth@collabora.com>  [5120cc702741ee3bdded80336f33362e42bf4276]

        tdf#159158 DOCX import: shape's last duplicate z-index wins
        
        It looks like for DOCX a duplicate always comes out on top,
        which is the exact opposite of what we have been doing so far.
        
        The ability to switch between "old" and "new" style was
        added for RTF's benefit, and cautiously expanded to
        include when RTF and DOCX IMPORT_AS_DETECTED_INLINE.
        
        This does not affect RTF, since AFAIK RTF cannot contain
        VML-Z-ORDER properties.
        
        Change-Id: I110e3db3fa504f1ae3a5bba5979b40f0c00a467e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162261
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-22  Justin Luth  <justin.luth@collabora.com>  [0b03dff37f4cad722819f36d5cf3bd39fb46d8ed]

        tdf#159158 writerfilter: relativeHeight always under z-index
        
        No matter what z-index I chose, it always ends up being above
        a relativeHeight. Since a heaven z-index is 0+,
        that means that all relativeHeight's need to be treated as negative.
        
        IsInHeaderFooter is a complication, because these are ALWAYS treated
        as if they are below the text, and yet behindDoc relativeHeights
        still need to be below their counterparts.
        
        While this algorithm could never cover all the situations
        (it would require transitioning to a sal_Int64 to do that)
        it should be fine for practical purposes.
        
        Plus, there are some unknown complications surrounding this.
        If I increase the behindDoc relativeHeight by 1 in
        tdf159158_zOrder_behindDocB.docx
        the yellow star actually moves on top of the blue star,
        which totally debunks my theory.
        
        RTF doesn't really use relativeHeight,
        but if it did, these changes should apply anyway.
        
        Change-Id: I62e1f9ae8fe6f99534a2a799692120508204c553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162234
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-22  Eli Schwartz  <eschwartz93@gmail.com>  [ceb885232aa09444142ad9a70e9f6947ca1d70e0]

        use portable "command -v" to detect installed programs, part 5
        
        The "which" utility is not guaranteed to be installed either, and if it
        is, its behavior is not portable either. This means that when various
        programs are installed, the `which` check will report a fatal error
        because the which tool did not exist and the shell returned a nonzero
        status when attempting to fork+exec. If it did exist, it might not be an
        implementation of `which` that returns nonzero when commands do not
        exist.
        
        The general scripting suggestion is to use the "command -v" shell
        builtin; this is required to exist in all POSIX 2008 compliant shells,
        and is thus guaranteed to work everywhere.
        
        For some in-depth discussions on the topic, see:
        - https://mywiki.wooledge.org/BashFAQ/081
        - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
        
        Examples of open-source shells likely to be installed as /bin/sh on
        Linux, which implement the 15-year-old standard: ash, bash, busybox,
        dash, ksh, mksh and zsh.
        
        This commit updates documentation to no longer suggest a bad practice
        that will confuse the reader when it doesn't work.
        
        Change-Id: I0ed5ced353124919c7e09912c6d4d5aea146fa33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160666
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-22  Eli Schwartz  <eschwartz93@gmail.com>  [2a5ff80264825e21adb5ff107a3d01237b86f559]

        use portable "command -v" to detect installed programs, part 4
        
        The "which" utility is not guaranteed to be installed either, and if it
        is, its behavior is not portable either. This means that when various
        programs are installed, the `which` check will report a fatal error
        because the which tool did not exist and the shell returned a nonzero
        status when attempting to fork+exec. If it did exist, it might not be an
        implementation of `which` that returns nonzero when commands do not
        exist.
        
        The general scripting suggestion is to use the "command -v" shell
        builtin; this is required to exist in all POSIX 2008 compliant shells,
        and is thus guaranteed to work everywhere.
        
        For some in-depth discussions on the topic, see:
        - https://mywiki.wooledge.org/BashFAQ/081
        - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
        
        Examples of open-source shells likely to be installed as /bin/sh on
        Linux, which implement the 15-year-old standard: ash, bash, busybox,
        dash, ksh, mksh and zsh.
        
        This commit updates a couple build scripts to not rely on fixed paths
        calculated upfront. Checking the location of a tool with cmd=$(which
        foo) just to run it as `$cmd` is pointless. It's exactly equivalent to
        run it as `foo`, but less error-prone and easier to read.
        
        For one of the scripts, it also simplifies checking for their existence.
        Personally, I am skeptical it even makes sense to check at all. POSIX
        mandates they exist, and it's exceedingly unlikely they will not be
        installed. However, unlike the shell interpreter itself, we don't *know*
        they are installed, so leave the existing checks in but simplified.
        
        Change-Id: I4703c1165eb3a5aeb45fbab18df3222e8f5f9551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160665
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-22  Eli Schwartz  <eschwartz93@gmail.com>  [cf02724e5101801d0a316f6b099c14c4fce77d9a]

        use portable "command -v" to detect installed programs, part 3
        
        The "which" utility is not guaranteed to be installed either, and if it
        is, its behavior is not portable either. This means that when various
        programs are installed, the `which` check will report a fatal error
        because the which tool did not exist and the shell returned a nonzero
        status when attempting to fork+exec. If it did exist, it might not be an
        implementation of `which` that returns nonzero when commands do not
        exist.
        
        The general scripting suggestion is to use the "command -v" shell
        builtin; this is required to exist in all POSIX 2008 compliant shells,
        and is thus guaranteed to work everywhere.
        
        For some in-depth discussions on the topic, see:
        - https://mywiki.wooledge.org/BashFAQ/081
        - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
        
        Examples of open-source shells likely to be installed as /bin/sh on
        Linux, which implement the 15-year-old standard: ash, bash, busybox,
        dash, ksh, mksh and zsh.
        
        This commit updates packaging recipes.
        
        Change-Id: I934863f6c8e05728e85278568899f581d749e0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160664
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-22  Justin Luth  <justin.luth@collabora.com>  [12ea98fe637eda5f038b6447a5f0c5ea7104f448]

        tdf#159158 tdf#120760 DOCX shape import: fix Z-order with behindDoc #2
        
        This fixes documents where both a z-index and a relativeHeight are in
        the hell-layer. z-indexes indicate behindDoc with a negative number,
        so prior to this patch relativeHeights were always above z-indexes,
        but in fact the reverse ought to be true.
        
        The reason why this works so well is because relativeHeight
        can be at maximum 1DFF FFFF, and we are subtracting 7FFF FFFF
        which makes it a very low number that z-index is very
        unlikely to ever reach.
        
        I don't see any reason at all why this logic would be limited
        to headers and footers. I assume that was done just to limit
        the potential regression hate, but in that case a comment
        should have been made stating that.
        
        documentation: previous patchsets contain a list of unit tests
        that have behindDoc without being in the HeaderFooter.
        None were interesting...
        
        The unit tests I modified were generally not surprising,
        since I am changing the zOrder and getShapes() is based on zOrder,
        so either refer to the shape by name when the order is not important
        (and might change depending on ODT import, no z-index defined etc),
        or else change the number to match the moved-to location
        if it changed because of initial import.
        
        The interesting one was the compat15 document which is
        specified as behindDoc but that is supposed to be ignored...
        perhaps if() could have just used m_bOpaque, but that is a logic
        step a bit too far to take.
        
        This can (and should) affect RTF as well, since
        {\sn fBehindDocument}{\sv 1}
        is documented as a shape consideration in the RTF spec.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_behindDocA
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_behindDocB
        
        Change-Id: Ic9eaecee28fd412f9aecce61b1e3a607f26d424a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162030
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-22  Eli Schwartz  <eschwartz93@gmail.com>  [71fed56e4a09fbf141fdb8f064df6764e6e6d262]

        use portable "command -v" to detect installed programs, part 2
        
        The "which" utility is not guaranteed to be installed either, and if it
        is, its behavior is not portable either. This means that when various
        programs are installed, the `which` check will report a fatal error
        because the which tool did not exist and the shell returned a nonzero
        status when attempting to fork+exec. If it did exist, it might not be an
        implementation of `which` that returns nonzero when commands do not
        exist.
        
        The general scripting suggestion is to use the "command -v" shell
        builtin; this is required to exist in all POSIX 2008 compliant shells,
        and is thus guaranteed to work everywhere.
        
        For some in-depth discussions on the topic, see:
        - https://mywiki.wooledge.org/BashFAQ/081
        - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
        
        Examples of open-source shells likely to be installed as /bin/sh on
        Linux, which implement the 15-year-old standard: ash, bash, busybox,
        dash, ksh, mksh and zsh.
        
        This commit updates the build system to configure and build correctly on
        systems without `which`.
        
        Change-Id: I23dbde5c7f104dd610fd5f78c82bf9a7d0cc1930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160663
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-22  Eli Schwartz  <eschwartz93@gmail.com>  [a1c854fffe0bf0f177535df320b60a328530ac70]

        use portable "command -v" to detect installed programs, part 1
        
        The "which" utility is not guaranteed to be installed either, and if it
        is, its behavior is not portable either. This means that when various
        programs are installed, the `which` check will report a fatal error
        because the which tool did not exist and the shell returned a nonzero
        status when attempting to fork+exec. If it did exist, it might not be an
        implementation of `which` that returns nonzero when commands do not
        exist.
        
        The general scripting suggestion is to use the "command -v" shell
        builtin; this is required to exist in all POSIX 2008 compliant shells,
        and is thus guaranteed to work everywhere.
        
        For some in-depth discussions on the topic, see:
        - https://mywiki.wooledge.org/BashFAQ/081
        - https://unix.stackexchange.com/questions/85249/why-not-use-which-what-to-use-then/85250#85250
        
        Examples of open-source shells likely to be installed as /bin/sh on
        Linux, which implement the 15-year-old standard: ash, bash, busybox,
        dash, ksh, mksh and zsh.
        
        This commit changes two programs installed to end-user systems.
        
        Change-Id: I6013965bb914f5b0d593a876866b991e210ef5b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160662
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-22  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [27a1eccae1763b8efa17c909820f57f84361d308]

        tdf#156718 PPTX import: fix the different formatting in table style
        
        when the PPTX file only has table style id, but no table style content.
        
        Change-Id: Ia3416478716a50beb6837988e98697fd88e916d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162368
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ad94d52c022a0acb20be21b5a1dfcf445e12f0c]

        fix bug in renaming chart objects
        
        introduced by
            commit c5bb73cae7c172ad0f02f8c67dd57b53337f1d78
            Author: Kohei Yoshida <kohei.yoshida@suse.com>
            Date:   Tue Jan 31 16:03:46 2012 -0500
        Get the whole thing to build after the method sig change in
        SdrObject.
        
        Change-Id: I1ca887d09857f6476980381853a9ae4946fd03e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b9368eab798a766b5a24658c783a6ee73dbf2caa]

        tdf#159145 Allow changing width of comment column on right border
        
        not only on the ruler as implemented in ac2720dcbe4e51e7f6733a385b5f7b571c6431e9
        
        Change-Id: Ib3709e97be312a7e20302ffa703e847f9efa3110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162365
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [76c4baec02ce6427c2350eb25a3ca0e473e5492e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 724ae7f9e32fcd76b317d64657f26f35e75cb0a8
          - tdf#155875 UI cmds Format Text (cont)
            
            + Sentence case
            + Capitalize Every Word
            + toggle case
            + refactoring
            
            Change-Id: I0fca3dd2b2e272fa3efd0a983aa974fa2d730156
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162358
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-22  Justin Luth  <justin.luth@collabora.com>  [bd9178ad31051de316092ec062b9f378c8a19852]

        tdf#159158 writerfilter: relativeHeight max allowed value
        
        relativeHeight treats its content as unSigned values,
        but it needs to share the zOrder with z-index
        which is a signed value (negatives indicating the belowDoc position).
        
        Thus, it is logical that relativeHeight would have a maximum
        value, and based on trial and error it was determined
        to be 1DFF FFFF for DOCX.
        
        Change-Id: If3fc16061730fb034c187ce4f639e1b2e50e044f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162233
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-22  Michael Stahl  <michael.stahl@allotropia.de>  [0b9d6406a40fe890ea003f8e503c4aca6f65c2e6]

        tdf#137839 sw: add drawing shapes anchored in selection to overlay
        
        This is mostly a UI problem: if text is selected, then any objects
        anchored in the selection are implicitly selected as well.
        
        Unfortunately only fly frames are painted with the selection overlay,
        but there doesn't seem to be a reason not to paint the SdrObjects as
        well.
        
        Change-Id: I0d9e35fdd1e1bdcc73a4c71b069993e670b5468d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162262
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [54716495a19d5717ec7fdee47d48773148754efa]

        Revert "tdf#143148: Use pragma once instead of include guards"
        
        This reverts commit eb9e4e7a6c7d11698a64489e22974574daabe823, see the note in
        the original description of
        <https://bugs.documentfoundation.org/show_bug.cgi?id=143148#c0> "Use pragma once
        instead of include guards (Episode 2: Endgame)":  "There are some source files
        containing include guards that are meant to also be processed by compilers other
        than LO's build baseline compilers:  All URE include files [...]  For those
        source files, it is probably better to conservatively stick with include guards
        than to replace them with #pragma once."
        
        Change-Id: I315aa935db8617fadd2fb807b6fa7da05f44359d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162288
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [91ebb47f86d91f71c3e490976ee5560d18bfb3be]

        ofz#66044 Timeout
        
        its not very interesting to find that long paragraphs are slow to
        render
        
        Change-Id: Ib849c937e288af2067243a17e90d828799062ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162352
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [007a0ddeb02188a207b40b9a4438a37aebd81b60]

        Remove (Windows-only) INIFILETABLE entries from setup.ini
        
        (See a31f334d36b5735ba6fc8d0f89e834a73bdcc561 "Windows MAR update issues with
        program/{setup,version}.ini" for why this cleanup is needed.)
        
        It is unclear to me why these entries would be needed in the setup.ini file.
        The *INSTALLLOCATION values are also stored in the Windows registry (see
        scp2/source/ooo/registryitem_ooo.scp).  FINDPRODUCT was once used as a
        GetMsiProperty, in code meanwhile removed in
        030124d836a3f8571e26c8ce6b5d752ca7ab2511 "remove CustomAction
        ExecutePostUninstallScript" (so I also removed the FINDPRODUCT property file
        line from solenv/bin/modules/installer/windows/property.pm, so FINDPRODUCT will
        no longer in the MSI Property table).  ALLUSERS is only used with some
        SetMsiPropertyW/UnsetMsiPropertyW/IsSetMsiPropertyW/GetMsiPropertySetW code in
        setup_native/source/win32/customactions/, but that should be unrelated to the
        setup.ini file.
        
        Removing the ProfileItems from scp2/source/ooo/common_brand.scp removed the only
        uses of the INIFILETABLE style, so also remove the corresponding code from
        solenv/bin/modules/installer.pm and the complete related
        solenv/bin/modules/installer/windows/inifile.pm.  Fingers crossed.
        A#	modified:   scp2/source/ooo/common_brand.scp
        
        Change-Id: If2aa72f0da50bc72f8c873df713340a142eed5e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161981
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8fc46ffb0e7ecdd6975516ecc722d477fb0b29ad]

        Remove (Windows-only) UpgradeCode from setup.ini and version.ini
        
        (See a31f334d36b5735ba6fc8d0f89e834a73bdcc561 "Windows MAR update issues with
        program/{setup,version}.ini" for why this cleanup is needed.)
        
        I couldn't find any traces of any code actually reading that entry from
        ini-files.  (There is some code in
        setup_native/source/win32/customactions/shellextensions/ calling GetMsiPropertyW
        with an L"UpgradeCode" argument, but that's something different.)
        
        Change-Id: I8ed79e7f7911635c52e1c41f54014b1445c561de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161980
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9919d02c1e9be7ab2f2690ca16da65b75ebde666]

        Remove (Windows-only) ProductCode from setup.ini and version.ini
        
        (See a31f334d36b5735ba6fc8d0f89e834a73bdcc561 "Windows MAR update issues with
        program/{setup,version}.ini" for why this cleanup is needed.)
        
        There were traces of actually reading that entry from ini-files in commits like
        3f01a5e9e4ec757eb26cc056a161fb7832ccd5d6 "INTEGRATION: CWS nativefixer12
        (1.2.2); FILE MERGED", d9d86a2d662f38aa0473211fbf3ef2241b1c9c93 "INTEGRATION:
        CWS nativefixer18 (1.3.2); FILE MERGED", and
        2521869690771c7af094520edf92ee8d2c5573a1 "INTEGRATION: CWS native36 (1.7.4);
        FILE MERGED", but all of them have since been removed with commits like
        50c26300e5b5ae9671f18a9e449516604d16105f "Remove lots of dead code",
        26c142ca5f2b405b02ab5701dfaeab7bf281a727 "Kill the ancient StarOffice "patch"
        concept", and e0ea85f61a5914508921b5e73119516219afa158 "we don't build language
        packs on Windows".  (And all of the original code appears to having been related
        to ancient Windows patch mechanisms.)
        
        Change-Id: I552830faf9006bae951fc60e97804abd9de718bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161979
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f9ff0df6f3a3339c891f764e5eecda9aa03612c0]

        Remove (Windows-only) MsiProductVersion from version.ini
        
        (See a31f334d36b5735ba6fc8d0f89e834a73bdcc561 "Windows MAR update issues with
        program/{setup,version}.ini" for why this cleanup is needed.)
        
        The ini-file entry had originally been added with
        d295757e7ec2cf0f7d83cf903ecb7c115a354bb9 "INTEGRATION: CWS nativefixer11
        (1.23.2); FILE MERGED", and setting its value with
        b993422e59287924d7d85afc75eb9cffc66311db "INTEGRATION: CWS nativefixer11
        (1.21.38); FILE MERGED" and 127dd8d32a87cecdc678d4b8288142f65a7a1fc9
        "INTEGRATION: CWS nativefixer11 (1.45.2); FILE MERGED", but it doesn't appear to
        ever have been actually used for anything, other than being recorded in the
        ini-file.  Lets remove it completely for good.
        
        Change-Id: I5f0372360416c2c6949ee2d5f0cc7e6babd8ba79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161978
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-22  Miklos Vajna  <vmiklos@collabora.com>  [1a4e52c0d985138d483af288c547f8cea6c96667]

        svx: prefix members of XDash
        
        See tdf#94879 for motivation.
        
        Change-Id: I78a3b52001cc61728fe568623acf13b86f43c449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162361
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-22  Michael Stahl  <michael.stahl@allotropia.de>  [4b68824d18316762a6afc35d355221e0228aebf8]

        tdf#159023 sw_redlinehide: fix layout frames copying table into footer
        
        Tables in footer aren't supported - if a table is pasted into the
        footer, SwNodes::CopyNodes() inserts for table/cell nodes the
        SwPlaceholderNodes so that the relative distance between any copied
        node is the same in the target, and once the other stuff like bookmarks
        and anchored flys are copied, SwNodes::DelDummyNodes() removes the
        SwPlaceholderNodes.
        
        If SwNodes::CopyNodes() is called with bNewFrames=true, it handles
        creating the frames well, but with bNewFrames=false and a subsequent
        MakeFrames(), the InsertCnt_() simply quits once it sees the first
        SwPlaceholderNode and so no frames are created for the nodes in the
        table cells.
        
        Rearrange DocumentContentOperationsManager::CopyWithFlyInFly() to move
        the MakeFrames() down below DelDummyNodes(), which requires adding a
        parameter to CopyFlyInFlyImpl() to prevent it from creating frames
        (anchored objects will also be created by MakeFrames() later).
        
        (regression from commit 166b5010b402a41b192b1659093a25acf9065fd9)
        
        Change-Id: I0ac30bec6e6423bb7d12c0a29f33848a5b61cd98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162320
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-22  Gabor Kelemen  <kelemeng@ubuntu.com>  [075b4f44b966a8799ee937e4e5a009d498c7aba4]

        tdf#157868 Add accessible descriptions to new Dublin Core metadata boxes
        
        that were still missing them.
        
        See also: https://www.dublincore.org/specifications/dublin-core/dcmi-terms/#section-3
        
        Change-Id: I7f76d2c5598aa53bc6faf6afa5f5e60788ae7ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162357
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f351faa3f71f3a1f6225b3d3c015b4d3a1373e38]

        tdf#146619 Recheck xmloff/*hxx with IWYU
        
        Change-Id: I09676a038370ca76ad4d4ef54dae14fbd3bd287f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162319
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [ca33b8b35a10243dc13e68c93e7c7512eef937ec]

        tdf#159313: pass properties in correct order
        
        Regression after commit c4fc18308074634e9578ad12d94d937f259aa22a
        (Autocorrect: Add option for autoformat bulleted lists after space,
        2023-09-07).
        
        Change-Id: I35fafc1441b4f67886a86d4d67764a91146b8ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162359
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [09f6ad451156cdc5c2d0f398237a72b99598f32f]

        Remove DetectHiddenControls method of locking down UI
        
        It is used only on the Load/Save - General page, and it's
        redundant with using officecfg methods and setting UI elements
        representing locked down keys as insensitive + showing a lock icon
        
        Change-Id: I689e7925198f8aac60b5711bf1c349c45a5ab62a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162267
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-22  Gabor Kelemen  <kelemeng@ubuntu.com>  [2782fa00d3ec8d401a44ae91cd3fda9d1d60188b]

        Fix meaning of warning message
        
        Change-Id: I6421d4f6ec5a79d7f3aea531e9e1361cd12abdc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162355
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-22  Gabor Kelemen  <kelemeng@ubuntu.com>  [2bb79f8feaf54fe2ad43c262c9efe89e7fd54ed9]

        Resave with newer Glade version
        
        Change-Id: I6b5ab915a9a8f823a71d5441fd7181014457f563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162356
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2024-01-22  Matt K  <mattkse@gmail.com>  [6840c242684986483624557a405a00e91ea048e9]

        tdf#132810 Prevent more crashes on gallery objects
        
        This change is a follow-up to https://gerrit.libreoffice.org/c/core/+/161950
        where there is still a crash occurring on application close, and
        a general crash when using gallery objects.  The fix is to check for object
        existence or if the object has the destructor bit set before using the
        objects.
        
        Here is the callstack for the assert that was removed:
        
        >	swlo.dll!SwClient::GetRegisteredIn() Line 166	C++
         	swlo.dll!SwContact::GetFormat() Line 112	C++
         	swlo.dll!SwAnchoredDrawObject::GetFrameFormat() Line 622	C++
         	swlo.dll!SwAnchoredObject::FindAnchorCharFrame() Line 719	C++
         	swlo.dll!SwAnchoredObject::GetAnchorFrameContainingAnchPos() Line 132	C++
         	swlo.dll!SwAnchoredObject::FindPageFrameOfAnchor() Line 697	C++
         	swlo.dll!SwObjectFormatterLayFrame::AdditionalFormatObjsOnPage() Line 144	C++
         	swlo.dll!SwObjectFormatterLayFrame::DoFormatObjs() Line 94	C++
         	swlo.dll!SwObjectFormatter::FormatObjsAtFrame(SwFrame & _rAnchorFrame, const SwPageFrame & _rPageFrame, SwLayAction * _pLayAction) Line 160	C++
         	swlo.dll!SwLayAction::InternalAction(OutputDevice * pRenderContext) Line 565	C++
         	swlo.dll!SwLayAction::Action(OutputDevice * pRenderContext) Line 390	C++
         	swlo.dll!SwViewShell::ImplEndAction(const bool bIdleEnd) Line 308	C++
         	swlo.dll!SwViewShell::EndAction(const bool bIdleEnd) Line 628	C++
         	swlo.dll!SwCursorShell::EndAction(const bool bIdleEnd) Line 266	C++
         	swlo.dll!SwEditShell::EndAllAction() Line 102	C++
         	swlo.dll!SwWrtShell::Do(SwWrtShell::DoType eDoType, unsigned short nCnt, unsigned short nOffset) Line 60	C++
         	swlo.dll!SwBaseShell::ExecUndo(SfxRequest & rReq) Line 655	C++
        
        Change-Id: I90bd40f3ae864ec9655340c342ddc16b59d79aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162349
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d49b0c3654e50ff9b74545140e6f19e008009c33]

        tdf#158139: show autotext / word completion tooltips also for delayed flush
        
        The problem was that commit 843af72bcc9047867588e29c8e10b84a5e58d70e (make
        win32 variant AnyInput() not deliver events (tdf#140293), 2021-02-11) made
        AnyInput ~always return true, when called in SwEditWin::KeyInput. Calling
        AnyInput(KEYBOARD) there is to query if there are more pending characters.
        But in its new form on Windows, it tells if there are any keyboard-related
        window events in the queue, where e.g. WM_KEYUP counts, which is for the
        same keypress (WM_KEYDOWN) that is being handled right now - even though
        those messages will not produce new characters.
        
        When AnyInput() returns true, a delayed flush timer starts. Only immediate
        flush was accompanied by tooltips.
        
        To make sure that the tooltip is shown also for delayed flush, move the
        tooltip code into SwEditWin::FlushInBuffer. Store the 'bNormalChar' flag
        (which controlled if the tooltip was shown) in a new member in SwEditWin.
        
        Change-Id: I51686b25f8d86df48ae9574ab8f3eb1d0e6ca985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162350
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [638f9bd2c6413588d7bcf3aac1b56bff03d20bb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ca8deeebd0d2a5840ded258be060d59c2f2dd39
          - tdf#155875 UI cmds Format Text (cont)
            
            + Cycle case
            + Adjustments in Tabbed UI
            + refactoring
            
            Change-Id: Ib1376d32f633aaafab7a3d7d824b1ebd20bd8365
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162351
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9d8a223b3550326d89f80124287acc071853405c]

        Try harder to clear Use-of-uninitialized-value from LLVMFuzzerCustomMutator
        
        Try the workaround of https://github.com/google/oss-fuzz/issues/4605
        
        Change-Id: If02072f244b05e005c0c180ce689f7a919105ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162353
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-21  Dione Maddern  <dionemaddern@gmail.com>  [c5688a27c22f2b5efe3bc762e4eb3d4ef45e4aa7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 367d8c48fc3d48aa9e08ac384b8f3b0c066bbea7
          - tdf#155877 Fix broken links in Format menu help pages
            
            Pressing F1 on Format > Image > Original Size leads to the wrong page. Removed the bookmark "HID/.uno:OriginalSize" from "source/text/shared/01/02200000" (Save As) and added it to the section of "source/text/shared/01/05030800" which deals with reverting a cropped image to its original size.
            
            Change-Id: I938ef6edd08930fbba168b9cd45582967a7a761e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162284
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [96bf7a9ace990a03b8b87a7a9d7b2882210ded0c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        WARNING: MemorySanitizer: use-of-uninitialized-value
        	    #0 0x2e4597d in TreatDoubleError /src/libreoffice/sc/source/core/inc/interpre.hxx:1146:10
        	    #1 0x2e4597d in ScInterpreter::PushDouble(double) /src/libreoffice/sc/source/core/tool/interpr4.cxx:1806:5
        	    #2 0x2e83755 in ScInterpreter::ScExternal() /src/libreoffice/sc/source/core/tool/interpr4.cxx:3126:17
        	    #3 0x2e94a38 in ScInterpreter::Interpret() /src/libreoffice/sc/source/core/tool/interpr4.cxx:4487:43
        	    #4 0x27296ad in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) /src/libreoffice/sc/source/core/data/formulacell.cxx:1946:23
        	    #5 0x2722f87 in ScFormulaCell::Interpret(int, int) /src/libreoffice/sc/source/core/data/formulacell.cxx:1619:13
        	    #6 0x1e1c80f in operator() /src/libreoffice/sc/source/core/data/column.cxx:2808:16
        	    #7 0x1e1c80f in EachElem<mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell, mdds::mtv::delayed_delete_vector>, std::__1::__wrap_iter<ScFormulaCell **>, mdds::detail::mtv::iterator_value_node<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>, unsigned long>, (anonymous namespace)::CalcAllHandler> /src/libreoffice/sc/inc/mtvfunctions.hxx:130:9
        	    #8 0x1e1c80f in ProcessElements1<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell, mdds::mtv::delayed_delete_vector>, (anonymous namespace)::CalcAllHandler, sc::FuncElseNoOp<unsigned long, bool> > /src/libreoffice/sc/inc/mtvfunctions.hxx:330:9
        
        Uninitialized value was stored to memory at
        	    #0 0x2fdee53 in operator>>=<double> /src/libreoffice/sc/source/core/tool/rangeseq.cxx:0:14
        	    #1 0x2fdee53 in ScApiTypeConversion::ConvertAnyToDouble(double&, com::sun::star::uno::TypeClass&, com::sun::star::uno::Any const&) /src/libreoffice/sc/source/core/tool/rangeseq.cxx:347:18
        	    #2 0x2b1e9d4 in ScUnoAddInCall::SetResult(com::sun::star::uno::Any const&) /src/libreoffice/sc/source/core/tool/addincol.cxx:1583:17
        	    #3 0x2b1d84f in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/sc/source/core/tool/addincol.cxx:1541:9
        	    #4 0x2b1c2ee in ScUnoAddInCall::ExecuteCall() /src/libreoffice/sc/source/core/tool/addincol.cxx:1495:9
        	    #5 0x2e81a4b in ScInterpreter::ScExternal() /src/libreoffice/sc/source/core/tool/interpr4.cxx:3065:19
        	    #6 0x2e94a38 in ScInterpreter::Interpret() /src/libreoffice/sc/source/core/tool/interpr4.cxx:4487:43
        
        Uninitialized value was stored to memory at
        	    #0 0x2b1daec in swap<void *> /usr/local/include/c++/v1/__utility/swap.h:37:7
        	    #1 0x2b1daec in operator= /src/libreoffice/include/com/sun/star/uno/Any.hxx:153:5
        	    #2 0x2b1daec in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/sc/source/core/tool/addincol.cxx:1518:14
        	    #3 0x2b1c2ee in ScUnoAddInCall::ExecuteCall() /src/libreoffice/sc/source/core/tool/addincol.cxx:1495:9
        	    #4 0x2e81a4b in ScInterpreter::ScExternal() /src/libreoffice/sc/source/core/tool/interpr4.cxx:3065:19
        	    #5 0x2e94a38 in ScInterpreter::Interpret() /src/libreoffice/sc/source/core/tool/interpr4.cxx:4487:43
        
        Uninitialized value was stored to memory at
        	    #0 0xc49bb64 in cppu::_copyConstructAnyFromData(_uno_Any*, void*, _typelib_TypeDescriptionReference*, _typelib_TypeDescription*, void (*)(void*), _uno_Mapping*) /src/libreoffice/cppu/source/uno/copy.hxx:178:49
        	    #1 0xc497abd in cppu::_copyConstructAny(_uno_Any*, void*, _typelib_TypeDescriptionReference*, _typelib_TypeDescription*, void (*)(void*), _uno_Mapping*) /src/libreoffice/cppu/source/uno/copy.hxx:288:13
        	    #2 0xc499443 in uno_any_constructAndConvert /src/libreoffice/cppu/source/uno/any.cxx:120:9
        	    #3 0x174d263f in stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/stoc/source/corereflection/criface.cxx:633:13
        	    #4 0x174d5935 in non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/stoc/source/corereflection/criface.cxx:0
        	    #5 0x2b1d5ce in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/sc/source/core/tool/addincol.cxx:1518:27
        	    #6 0x2b1c2ee in ScUnoAddInCall::ExecuteCall() /src/libreoffice/sc/source/core/tool/addincol.cxx:1495:9
        	    #7 0x2e81a4b in ScInterpreter::ScExternal() /src/libreoffice/sc/source/core/tool/interpr4.cxx:3065:19
        	    #8 0x2e94a38 in ScInterpreter::Interpret() /src/libreoffice/sc/source/core/tool/interpr4.cxx:4487:43
        
        Uninitialized value was stored to memory at
        	    #0 0xcd10714 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /src/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:157:51
        	    #1 0xcd0cd78 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) /src/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
        	    #2 0xcd0a9fa in unoInterfaceProxyDispatch /src/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:0
        	    #3 0x174d1f01 in stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/stoc/source/corereflection/criface.cxx:590:9
        	    #4 0x174d5935 in non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/stoc/source/corereflection/criface.cxx:0
        	    #5 0x2b1d5ce in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) /src/libreoffice/sc/source/core/tool/addincol.cxx:1518:27
        	    #6 0x2b1c2ee in ScUnoAddInCall::ExecuteCall() /src/libreoffice/sc/source/core/tool/addincol.cxx:1495:9
        	    #7 0x2e81a4b in ScInterpreter::ScExternal() /src/libreoffice/sc/source/core/tool/interpr4.cxx:3065:19
        	    #8 0x2e94a38 in ScInterpreter::Interpret() /src/libreoffice/sc/source/core/tool/interpr4.cxx:4487:43
        
        Uninitialized value was created by an allocation of 'data' in the stack frame of function '_ZN4gcc317callVirtualMethodEPvjS0_P33_typelib_TypeDescriptionReferencebPmjS3_Pd'
        	    #0 0xcd0f1d0 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /src/libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:50
        
        The double really comes from AnalysisAddIn::getConvert and when adding
        code to switch off it there and msan is happy before it returns that it
        is initialized, the problem arises when extracting that return value in
        the bridge code. Its curious that this only appears now when we've been
        running msan for years and only for double (so far) and not the other
        types.
        
        Change-Id: I8f381a9faf4fe9d4a02b77b241ab33de8eb3bce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0e7fb08f1d2fcc820725b1a73c01dedb69918afd]

        ofz#66042 Integer-overflow
        
        Change-Id: Id59a725e0839b490e8c0912b2a89fc3cc21931d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162346
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [5dd814f13d795b471b2c9b01998ced75b2845a05]

        ITEM: Remove Direct(Put|Remove)Item(In|From)Pool
        
        After some experiments I now can remove
        DirectPutItemInPool and DirectRemoveItemFromPool.
        With the changes done before it is now possible to
        get rid of this 'compromize'. Now there are no
        more Items held at the 'Pool' which now can be
        developed in the direction of ssth like
        'SfxItemSupport' - what it really is.
        
        Some of the last usages of DirectPutItemInPool were
        in SvxAreaTabDialog::SavePalettes(), so I tried to
        trigger those cases with using LO and calling that
        Dialog in all situations I could possibly think
        about, but it was never used.
        
        Then I added asserts and run a UnitTests in the apps,
        also no luck. Thus I would guess these are not used.
        These put changed stuff from the Dialog 'directly' to
        the Pool (what is not really supported and is a hint
        for a 'compromize' that some functionality did not
        find/want to use the right spot in the model to save
        and hold that data). Thus it *would* be accessible
        using the SurrogateMechanism at the Pool (which is
        also a 'compromize', see some of my other commits),
        but I also found no hints at places where that is
        done.
        
        Thus I decided to create this change and let's see
        if that asserts ever get triggered in the builds
        or tests.
        
        Indeed did not trigger. I checked what other places
        do which use SfxObjectShell::Current() when they get
        no DocShell: Most avoid doing something, but none
        puts stuff to the Pool, so I go one step further
        and do what other places do: warn and return. Also
        simplified SvxAreaTabDialog::SavePalettes() as then
        feasible.
        
        Change-Id: I1c351eac4ada26288a56a69d57008a09f2d19121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162340
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bd10851e9e5b4ecc5624f1fee8331e52c96df606]

        Adapt compilerplugins to Clang 18 trunk isPure -> isPureVirtual rename
        
        ...<https://github.com/llvm/llvm-project/commit/e90e43fb9cd1d305f7196cd526aa503374e0f616>
        "[Clang][NFC] Rename CXXMethodDecl::isPure -> is VirtualPure"
        
        Change-Id: I27b7cd40c84c71804bef396d0bff4ee2683cb3af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162345
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [701eb22d9cb0c5ed785df09acf0d14d16d64a768]

        cid#1586650 silence Unchecked return value
        
        Change-Id: I0cda4ed1e56737e6df6dec46d03414664970e3bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b2ade3e63e34556cad8157e25f8c75d29e79537d]

        Extract embindmaker from cppumaker into its own tool
        
        ...that directly generates one large .cxx
        
        Change-Id: I046539b83f8fde5eda7168c93a8b819137399665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162343
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-21  Arnaud VERSINI  <arnaud.versini@pm.me>  [f504b2de4abd204d87be25ee85ac7b31521757ac]

        writerfilter : use constexpr frozen unordered_set instead of std::unordered_set
        
        Change-Id: I37b4b5ec56f846b5c46faeaa5aebb88340ac3c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161385
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-21  Arnaud VERSINI  <arnaud.versini@pm.me>  [c4fb690e6f4aedde124c045bd136f8f7c1e974a4]

        animations : use string OUString literals in a11y for XServiceInfo impl
        
        Change-Id: Ifd23fd38e5fa289e9606ba0a8d5a04449ddcb0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [74a56b7434047b6ffbf865af60dba98a9273b63a]

        ITEM: solve ScCondFormatDlgItem situation
        
        It is used in SC, DirectPut* in Pool, fetched using
        Surrogates, all bad. Only to transport data over the
        Pool, may not even need to be an Item.
        Trying to solve/losen that gordian knot, looks good.
        Is now a normal data holder class, could find a good
        parent for it that the Dialog and the instances
        setting up/using that Dialog can use.
        Forgot to reset that data instance in one place, but
        also checked in-between a version that still used the
        Item to excluse that the Poolis the same, but the
        ScTabViewShell does change. FOund an error with
        SfxPoolItemHolder when reseting, also changed.
        
        Change-Id: I1c99d675d1cc3d21205c3e2df78d4b52a696e7ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162313
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-21  seturaj  <seturajmatroja@gmail.com>  [eb9e4e7a6c7d11698a64489e22974574daabe823]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Ia8a203d1e6a7446f43cc68d883e1ee4cd0a5814f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162341
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-21  AkshayWarrier  <aksmen121@gmail.com>  [dad0ea5c75445dc8ca316c4e5af1a9d6875699c1]

        tdf#157664 Drop operator != where respective == is defined
        
        Change-Id: I9eb0ea94f10126270f6e7c4433227ea60c21db79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162336
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-21  Weblate  <noreply@documentfoundation.org>  [73b4bbc371661df53717de59f84b056a206bc63f]

        android-viewer translated using Weblate
        
        Indonesian currently translated at 74.5% (88 of 118 strings)
        
        Change-Id: I613b96b66373aa9cb505da4de371b5b058e95f68
        
        android-viewer translated using Weblate
        
        Czech currently translated at 13.5% (16 of 118 strings)
        
        Change-Id: Ie298906f2643a9e2df5c4e45183c99206d0aeda5
        
        android-viewer translated using Weblate
        
        Persian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I43d6ac950eb3bba2b6359184b063dd40d7d2f15b
        Co-authored-by: Andika Triwidada <andika@gmail.com>
        Co-authored-by: Hossein <hossein@libreoffice.org>
        Co-authored-by: raal <raal@post.cz>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/id/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162328
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-21  Justin Luth  <jluth@mail.com>  [9aaf0f4b2c74d76d38460725b07c78e4aeabdbf3]

        tdf#153909: docx import: pre-emptive unit test for layoutInCell
        
        In LO, we have a much more strict definition of what "FollowTextFlow"
        means than the various MSO exceptions.
        
        In this case, we had to disable FollowTextFlow to allow the shape
        to be placed outside of the cell.
        However, the value of layoutInCell is actually true,
        so the fly offsets still need to be against the cell's "margin"
        and not against the outside-of-the-table paragraph margins.
        
        This unit test is a good visual example of this.
        The blue rectangle is supposed to start at the paper edge,
        (and end before the next paper edge),
        whereas if layoutInCell is turned off, the rectangle would be
        indented 1.3cm and spill off the end of the paper.
        
        This test prevents the following situation:
          - we export layoutInCell = false (very bad for a compat docx)
          - we have fixed compat import to honor layoutInCell = false
        
        Change-Id: I355837d1ce5cff76c5eb376fc76b057f248a1039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162339
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [049bbd95c190e0844da3a8dd88b1ce7a9ccf83b7]

        editeng: change EditEngine getter to ref in {Imp}EditView
        
        {Imp}EditView always needs to have EditEngine set (or it would
        crash otherwise), so we can change the getter to return a referece
        instead of a pointer. This simplifies things a bit because we get
        rid of all the nullptr checks and makes the interface more clear.
        
        Also change direct access to mpEditEngine in {Imp}EditView to use
        getEditEngine() and getImpEditEngine() (returning a reference)
        instead.
        
        Change-Id: Ib8f9c565b8364144bb9c35c3093c4975af1970c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162333
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [06aea80b0482c03e8f0a5f735d3a31ec816a07fe]

        editeng: in ImpEditEngine::Paint rename confusing variables
        
        Change-Id: I6fbbb049dcd2e8ca221a2830cd9766c5590b6f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162332
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-21  Hossein  <hossein@libreoffice.org>  [97337f5395ca1f4597690c97a19da9fd55ee1c66]

        Fix sw_complex JUnitTest not running
        
        Call to gb_JunitTest_add_classes was missing in the gbuild makefile
        sw/JunitTest_sw_complex.mk, and now it sholud be fixed. Before that
        the sw/qa/complex/indeterminateState/CheckIndeterminateState.java was
        compiled, but it was not run due to the missing class name
        (complex.indeterminateState.CheckIndeterminateState) from the java
        command which was used to invoke the test.
        
        The test can be run with:
        
        $ make JunitTest_sw_complex
        
        Change-Id: I85823336d7f3ad2fde47442b5d1c5d2f3003299b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162263
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [636560669a75e5ae9ddc536d6f0b65efedff3e9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1aaf192bce747f70d1e04701fe5f097eeba0300e
          - tdf#155875 UI cmds Format Text (cont)
            
            + refactoring
            
            Change-Id: I9de9b35f9475dc9a8bf780ccf64442a7f287b431
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162334
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-20  Andras Timar  <andras.timar@collabora.com>  [5dbb4d28b3310109ba47d02ea486299ba56e3c9f]

        LOK: disable popup bubble for hyperlinks
        
        Change-Id: I0ca21a90561affa453bd249c86e58793618f809e
        (cherry picked from commit 88fea772610a4feef018ba03fd19749841772225)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162335
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db44ffd2191b7d34307e0a1c49339c490482c4ac]

        suppress COPY_INSTEAD_OF_MOVE suggestions for uno::Reference
        
        rtl::Reference, uno::Any and rtl::O[U]String
        
        where we have implemented move ctors to take let the compiler take
        advantage of any little optimization possibility that it can take
        but where the potential optimization probably doesn't outweigh
        enforcing dusting error-prone std::move all over every case where
        the compiler doesn't/can't use the move ctor but could.
        
        Change-Id: Icf184d96d3278a1740a76c7eb1150e60392351ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [93e3443f6c1c25533f79ac1f72f382122f00c48d]

        ofz#65979 Null-dereference READ
        
        Change-Id: I1eec7948bef2838a439fe05eedddb7245d3c2e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9ff4fd5ccc0a6b54309bba87769c07389f1bf935]

        this duplicated CPPUNIT_ASSERT_POINT_EQUAL_WITH_TOLERANCE
        
        so use that instead
        
        Change-Id: I0a627fdd2f2657a3f23d47f014ff7019cab544f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162330
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [103ad4fc70848443ba95fcb352569b35ccc38070]

        Fix typo
        
        Change-Id: I26d745efecc29fe28e32dfc6b6a2ebe3c3bfd2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162329
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2024-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d63d416f345242e457eb1adebf572b0fb3000b1b]

        ofz: Abrt from missing form component
        
        tweak to follow the typical default config option here
        
        Change-Id: I09b92458935ca0772c8593c4e50e59adc60a00f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7edfb1b85cef5e5435cd2bf46e1b91b68f1e6427]

        calc doc with saved zoom in settings causes disjoint invalidations...
        
        in multiple views, while the invalidations rectangles should be reported
        at the same place from each view.
        
        on load, ScTabView::SetZoom gets called with the zoom stored in the
        document settings, which both calls sets Zoom on the ViewData, and then
        calls ZoomChanged, which syncs the GridWindows MapMode from the ViewData
        derived GetDrawMapMode().
        
        Later lok sets zoom via setClientArea which leaves the GridWindows
        MapMode untouched and out of sync with the newly changed ViewData
        MapMode.
        
        Typically then, on e.g. on deleting text in one view then
        ScViewFunc::DeleteContents or similar is called which calls
        ScTabView::UpdateCopySourceOverlay which calls
        ScGridWindow::UpdateCopySourceOverlay and that sets the GridWindow
        MapMode to the DrawMapMode but then *for lokit* returns early (among a
        few other unlikely early return cases) while every other similar func
        restores the orig GridWindow mode before returning. So the view which
        is used to make the change ends up with GridWindows synced to the
        ViewData MapMode, which looks like accident. While the other view
        remains with GridWindows with MapModes unsynced with that views
        ViewData MapMode.
        
        So on invalidate, the view that was used to make the change has
        GridWindows with MapModes that report the correct rectangle, while the
        other unsynced view will report an incorrect rectangle, until something
        happens in that view to get it to exec UpdateCopySourceOverlay and get
        synced.
        
        Here add the sync to ScModelObj::setClientZoom so the two MapModes
        remain synced once that is called.
        
        Change-Id: I2da59f50ae2b0e3ea6b7ef8b54debdab1ee98266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162312
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162322
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [38e621f124e5d3c537c15a25cfd099d08094e2b4]

        cool#6893 reduce allocation in ScGridWindow::PaintTile
        
        the code is needlessly allocating way more rows than we need, especially
        when we have page to the bottom of a large document.
        
        Make it so we allocate exactly the number of rows we need, instead
        of allocating a default large number of rows (1024).
        
        Which reveals that we need to allocate two extra rows, not sure why.
        
        Change-Id: I9ca38f2712480ee8c0c3254061c92e457e328416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ccaf39415f695741c4d36e5ac803601354f06570]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aaf279daa4353d112652944082b7cbe3055d3cd7
          - tdf#155875 UI cmds Format Text
            
            + refactoring
            
            Change-Id: I4a261055eec547e89e3eddcdfaf876ae323bbb68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162323
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-20  Justin Luth  <justin.luth@collabora.com>  [ad0266eb84eafa32ccc4e0ddf3c6392860bc9b13]

        tdf#153909 docx import: wrap through shapes shouldn't FollowTextFlow
        
        This resolves a NISZ 6.4.0 regression from
        commit 27d04f6dbf38aa28fb7215590d578c4567db5770
            tdf#119038 DOCX: fix FollowTextFlow handling
        
        MSO is all over the place in how they implement layoutInCell
        (aka FollowTextFlow in LO). There are lots of compat15 differences
        for this, but I don't notice compat coming into play with this bug.
        
        For reference, see commit e993638d5ecd33783f2eebdccfa87a81e5a8a2c5
        Author: Miklos Vajna on Mon Jan 24 12:53:25 2022 +0100
            DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>
        
        I'm sure this is the WRONG code spot for handling FollowTextFlow,
        but anywhere else and we lose the "it came from a vml shape"
        limiting information, so I'm not going to try to relocate this code.
        
        Inline (as-character) shapes ignore layoutInCell,
        so the type of anchor (floating or inline) shouldn't matter
        and therefore doesn't need to be part of the if () clause.
        
        The header can be special (in compat14 it means everything
        is wrap through), but at least in this case it is not limited
        to IsInHeaderHeader. Using a non-header as the unit test.
        
        make CppunitTest_sw_ooxmlexport21 \
            CPPUNIT_TEST_NAME=testTdf153909_followTextFlow
        
        The first patchset contains a list of all of the unit tests
        that were impacted by this patch: nothing interesting.
        
        Change-Id: I0c4c7924833550533ad1b0b7609840a666d4d589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162324
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-19  Oliver Specht  <oliver.specht@cib.de>  [e6f75eb50bc5d1ebccda0c0f80a7b353d991106e]

        tdf#159254 import paper bin/paper source from rtf/docx files
        
        Imports \binfsxn and \binsxn from RTF and
        w:paperSrc from docx files and applies paper tray to the page style
        if the printer supports the imported tray value.
        Works only on Windows.
        
        Change-Id: Ie1170c58f7114f0dbf6bdd2721d4e077886cbe16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162236
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [295d0b98c7c2b8a90e352b3774c9a3a4f7247125]

        Remove unused include
        
        Change-Id: I2cc863e7143dbb0fcfa4800854987e5f6db655ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162309
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-19  Gabriel Masei  <gabriel.masei@1and1.ro>  [8c10c63388502322ac0ac6a7e5b14e657edbe630]

        lok: remove non-filter options from filter options
        
        Filter options should be what remains after extracting any
        other options from the original list of options.
        
        Change-Id: Iad787b34aba58c3910118e94df66a102b44034c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162316
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2024-01-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [26aa2e799a22b2a95cf865ac0fd57df1262d4a0a]

        ITEM: Needed reworks on ItemSurrogate mechanism
        
        ItemSurrogates are a possibility to iterate over
        all SfxPoolItems associated with a WhichID at a
        ItemPool to collect or change data.
        It is in general not a good idea: the correct action
        would be to iterate over the model data and change/
        adapt/collect data on the Items of the type
        in question. This is because the *assumtion* that you
        iteate over all the Items associated with a document
        model is *not* correct:
        The ItemPool of the model is used for various ItemSets,
        e.g. Dialogs/Sidebar and others, so you might get Items
        not only from the DocumentModel but from elsewhere.
        You might even get Items from *other* models, so
        changing these might have unpredictable effects (!)
        It is clear to me that this mechanism is more convenient
        that iterating over the document models, and it might
        have been invented due to this and then used in more
        and maore cases. There should be a lambda/callback-based
        mechanism in every document model to do this. Until then
        we have to live with this 'compromize'. There are over
        100 usages currrently, so no way to easily replace this.
        
        For those reasons I changed this to be more safe: There
        are two methods to do this now:
        
        1: iterateItemSurrogates to allow read/write access. I
           identified six places where that mechanism was used
           to change SfxPoolItems, with the use of const_cast.
           This now offers a lambda/callback mechanism and the
           needed data in a helper (SurrogateData). Internally
           it iterates over ItemSets and ItmHolders registered
           and thus associated with the Pool. Changing an Item
           means to set a changed Item at the Pool/replace the
           holder.
        
        2: GetItemSurrogates/FindItemSurrogate to allow
           read-only iteration (2nd one with filter). This
           collects the Items in a vector that you provide over
           which you can then iterate. Do *not* use const_cast
           and change the Item when using this (!)
        
        Note that mechanism (2) pe-filters the Items so that
        you get each only once: Of couse one Item can be set
        in more than one ItemSet/Holder (but also in more than
        one model). This filtering is not possible for (1), you
        have to evtl. do the same replace action for the same
        item, but this is the only way to not change Items that
        are associated wth another model.
        
        Note that (2) could also be changed to a lambda/callback
        mechanism similar to (1), but there are too many places
        that would beed to be adapted. That would have the
        advantage to not need to pre-collect the candidates in a
        first run.
        
        Also removed/replaced FindItemSurrogate with using
        GetItemSurrogates and locally filtering with that needle.
        That also made me remove/cleanup CollectSurrogates, it's
        only used in one place now.
        
        Change-Id: I0fe2f51f4fca45e1e5aea032cb96bb77b4567f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162254
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-19  László Németh  <nemeth@numbertext.org>  [b5e275f47a54bd7fee39dad516a433fde5be872d]

        tdf#106733 sw: implement CharNoHyphenation
        
        Implement CharNoHyphenation character property to
        disable automatic hyphenation of words in paragraphs
        with enabled hyphenation.
        
        Fix also fo:hyphenate mapping to CharNoHyphenation
        using automatic inversion of their boolean values
        defined by xmloff's XML_TYPE_NBOOL, as suggested by
        Michael Stahl.
        
        Update also the test for tdf#159102 to check the available
        hyphenation dictionary (also custom hyphenation patterns
        work only with supported locales of the hyphenator).
        
        Note: patch of thints.cxx contains also partial revert
        of commit 53b289eabb3d265b47bc7fb6cc430291c97f0c0b
        "use more TypedWhichId".
        
        Follow-up to commit 73bd04a71e741788a2f2f3b26cc46ddb6a361372
        "tdf#106733 xmloff: keep fo:hyphenate in character formatting".
        
        Change-Id: If99b94ddcd44a5c2426e646be149078a3b9773b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162300
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [3288fba8ad31c21e6e8cebf605efda544f031156]

        Rename natstepfilter file, to make it not hidden on Linux
        
        It turns out, that this also works, despite all the documentation
        refers to it as '.natstepfilter'.
        
        Change-Id: I17ab0662a3de0e0f7db72e31f5e7ed0f00823447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162311
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2024-01-19  Dione Maddern  <dionemaddern@gmail.com>  [62877583b5980962ae56668fe2cdd9a23de09cdd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 709109b522cfbeb07c7bac2c6d90c8ebb5f53b33
          - tdf#155877 Fix broken links in Insert Menu help pages
            
            Add howtoget information for help pages
            
            Change-Id: I7e26667c5b2d670698b1a1f8875682560c889edd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162138
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-19  Jim Raykowski  <raykowj@gmail.com>  [a08197e7c376c72685260ae923483ae99f929d35]

        tdf#159147 followup
        
        Avoid unnecessary looping by immediate return from the function after
        bringing content to attention.
        
        Change-Id: I670dc5d0991d96e7ce2872d329e969f9c341d163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162291
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-19  AkshayWarrier  <aksmen121@gmail.com>  [3f0dd3d635507e4505cab4dac6e493f9dc985c23]

        tdf#143148 Use pragma once in svx
        
        Change-Id: I0317c57ec99a36d9f5153dadb556390a5d8858ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162302
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5202a6fe010fd9ce20303c573c8da0f5ab09eea8]

        cid#1545244 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546433 COPY_INSTEAD_OF_MOVE
        cid#1546428 COPY_INSTEAD_OF_MOVE
        cid#1546175 COPY_INSTEAD_OF_MOVE
        cid#1545866 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I1d1e684faa422654fd90513cf459cde58d3d8914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162298
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [559489549f9bc178822ce8cd3f49fd967ef1298b]

        use a ScopeGuard to restore the original map mode
        
        in these cases the original map mode was *not* always restored,
        but the intent seems to be like the others that the mapmode should
        be the same on exit as on enter.
        
        Change-Id: Id7b668a9977c4c84df5234288baca8bd6f4232e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49d502e8017b2f8f0de153f0f3003b5f25d683b1]

        use a ScopeGuard to restore the original map mode
        
        in all these cases the original map mode was always restored so
        there is no change for these examples.
        
        Change-Id: Iec24b2cd269b9408dac6404e054b3bb989ec7744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162306
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [1be5adecafd1ba0aa6bc278ce3221646193030a2]

        Add a natstepfilter file to Visual Studio solution
        
        Allows to avoid stepping into some functions, like smart pointer's
        operator->(), when debugging.
        
        Change-Id: Ia930ad6b0c94c9caefad8ac026252fced1265fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [56ceb5db4eb3243d02c56c8cf21522d0373c28a9]

        cppumaker: Work around problematic constant named "auto"
        
        ...which had been added all the way back in 2002 with
        6cd0bbd8ce6ae2774fc61dacc0f81725ba038d79 "adding new file to HEAD" to constants
        group css.drawing.CaptionEscapeDirection, which has meanwhile been published, so
        no chance of cleaning that up.
        
        But cppumaker already has a mechanism to work around problematic UNOIDL
        identifiers, but which was only used for "new-style" entities when they got
        introduced, mainly to avoid compatibility issues when retroactively changing the
        code generated for existing entities.
        
        But for C++ keywords, the generated code was always broken, so no harm in fixing
        it, so introduce an additional IdentifierTranslateMode::KeywordsOnly and use
        that at least for constants, to address the immediate issue.
        
        (And with that, a hack can be removed from gb_UnoApiEmbindTarget__add_embind.)
        
        Change-Id: I5cf62fd8b3b298dff2ec28452fb97b424a4ba473
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162305
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [c4e5b1b934fc3c59fb35ae6c02a0ddf8501a6d28]

        tdf#159247 Fix crash while adding control with default properties (Dialog Editor)
        
        Controls created using the Ctrl+toolbar (which adds a control with default properties) did not have a parent form, which causes the crash.
        
        Change-Id: Ic2f469e6656a93bbed25d86092384f81b21aaca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162217
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-01-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7ed159d9fc75de09fb581f6f338ba5ec0bb3292e]

        cool#7769 Reduce unnecessary invalidations on calc save
        
        https://github.com/CollaboraOnline/online/issues/7769
        
        Reduce unnecessary invalidations. Don't invalidate windows
        if layer visibility didn't really change.
        
        Change-Id: Ic2abd78d60aea2e8676c8e56608cf51e941f5918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-19  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [01e41414847bcc3670df9537bbcba6a98ebd5190]

        tdf#159067 drawinglayer: fix untagged form control (PDF/UA export)
        
        If the form object is marked as decorative, the form control should be exported as "Artifact"
        
        Change-Id: I615d308ae966bf3d0f156899a0b4fad2d5a7c492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162268
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [18e579761cb622e8ff7e67f319ef80c61b3bd588]

        Make osl_execProc_test_batch run the new process hidden
        
        This prevents a console window flashing briefly on Windows, when
        runnung the test.
        
        Was this way since commit d011896d755252105c740f23f31ed43de64f7c98
        (INTEGRATION: CWS sal04 (1.1.2); FILE ADDED, 2003-09-29).
        
        Change-Id: I7fb7bb067786d3ad33f9ba831e3b454c91a35e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162296
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [8977ade85a2869ce3bc69c62689ff4548303bdb1]

        Pack group bits in PortionType, and make last 5 bits designate an index
        
        Also mark the items that create some doubt - if they need PORGRP_TOXREF
        bit set; or was that just an accident, when adding elements to the enum
        without knowing that bits have significance. These items were added in:
        
        * Meta:           commit b01573861cdcb32619c7745055e14823b865a12d
          CWS-TOOLING: integrate CWS odfmetadata3 (2009-09-11)
        
        * Bookmark:       commit 4ce8120f1e53f7b81e653b01d141643013bc69ab
          tdf#45589 sw: create and paint text portions for bookmarks (2020-01-30)
        
        * ContentControl: commit 8c632d8a837cc722c6e7b3b400f6d97edf9f9800
          sw content controls: add initial layout support (2022-04-05)
        
        Change-Id: Idc976d0d479020b3d4f88d7143a5ded36b6e1365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162295
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [15ecd3b12b912d7e39e6b8054c12fc9f99a2b670]

        Move bit definitions close to PortionType
        
        And make PortionType elements defined using those definitions.
        
        Change-Id: I45c2de4d965b43b84699d97f810661bea01825b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162290
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3fb9859c6aa4a32f2333d86fa438e9f1d6ef7f55]

        PlotAreaConverter::mbSingleSeriesTitle is apparently read uninitialized
        
        ...in code newly introduced in 135ce256ce9e879663d828ec6e699de521fad867
        "tdf#146487 Don't show generic diagram title when there is an empty title
        given", which caused CppunitTest_chart2_export2 to fail with
        
        > /oox/inc/drawingml/chart/plotareaconverter.hxx:78:62: runtime error: load of value 222, which is not a valid value for type 'bool'
        >     #0 0x7f95cd9ed87c in oox::drawingml::chart::PlotAreaConverter::isSingleSeriesTitle() const /oox/inc/drawingml/chart/plotareaconverter.hxx:78:62
        >     #1 0x7f95cd9e506f in oox::drawingml::chart::ChartSpaceConverter::convertFromModel(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Point const&) /oox/source/drawingml/chart/chartspaceconverter.cxx:189:53
        >     #2 0x7f95cd9b6c34 in oox::drawingml::chart::ChartConverter::convertFromModel(oox::core::XmlFilterBase&, oox::drawingml::chart::ChartSpaceModel&, com::sun::star::uno::Reference<com::sun::star::chart2::XChartDocument> const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, com::sun::star::awt::Point const&, com::sun::star::awt::Size const&) /oox/source/drawingml/chart/chartconverter.cxx:93:20
        >     #3 0x7f95ce548f59 in oox::drawingml::Shape::finalizeXShape(oox::core::XmlFilterBase&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&) /oox/source/drawingml/shape.cxx:2245:50
        >     #4 0x7f95438150b2 in oox::xls::Shape::finalizeXShape(oox::core::XmlFilterBase&, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&) /sc/source/filter/oox/drawingfragment.cxx:113:30
        >     #5 0x7f95ce5267bb in oox::drawingml::Shape::createAndInsert(oox::core::XmlFilterBase&, rtl::OUString const&, oox::drawingml::Theme const*, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool, bool, basegfx::B2DHomMatrix&, oox::drawingml::FillProperties const&, std::shared_ptr<oox::drawingml::Shape>) /oox/source/drawingml/shape.cxx:1964:9
        >     #6 0x7f95ce4edb54 in oox::drawingml::Shape::addShape(oox::core::XmlFilterBase&, oox::drawingml::Theme const*, com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, basegfx::B2DHomMatrix const&, oox::drawingml::FillProperties const&, std::__debug::map<rtl::OUString, std::shared_ptr<oox::drawingml::Shape>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<oox::drawingml::Shape> > > >*, std::shared_ptr<oox::drawingml::Shape>) /oox/source/drawingml/shape.cxx:366:41
        >     #7 0x7f954381ef79 in oox::xls::DrawingFragment::onEndElement() /sc/source/filter/oox/drawingfragment.cxx:335:30
        >     #8 0x7f95cdcaee54 in oox::core::ContextHandler2Helper::implEndElement(int) /oox/source/core/contexthandler2.cxx:125:9
        >     #9 0x7f95cdd5c116 in oox::core::FragmentHandler2::endFastElement(int) /oox/source/core/fragmenthandler2.cxx:91:5
        >     #10 0x7f95caf68fca in (anonymous namespace)::Entity::endElement() /sax/source/fastparser/fastparser.cxx:514:27
        >     #11 0x7f95caf68998 in sax_fastparser::FastSaxParserImpl::callbackEndElement() /sax/source/fastparser/fastparser.cxx:1331:17
        >     #12 0x7f95caf58444 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) /sax/source/fastparser/fastparser.cxx:338:18
        >     #13 0x7f960adebeda in xmlParseEndTag2 /workdir/UnpackedTarball/libxml2/parser.c:10090:2
        >     #14 0x7f960ad929b5 in xmlParseTryOrFinish /workdir/UnpackedTarball/libxml2/parser.c:11868:14
        >     #15 0x7f960ad86334 in xmlParseChunk /workdir/UnpackedTarball/libxml2/parser.c:12151:5
        >     #16 0x7f95caf53231 in sax_fastparser::FastSaxParserImpl::parse() /sax/source/fastparser/fastparser.cxx:1085:21
        >     #17 0x7f95caf4cd18 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:890:9
        >     #18 0x7f95caf6e950 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1470:13
        >     #19 0x7f95cdce50d1 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) /oox/source/core/fastparser.cxx:121:15
        >     #20 0x7f95cdce5868 in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
        >     #21 0x7f95cddbb234 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:414:21
        >     #22 0x7f95cddb9b8d in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) /oox/source/core/xmlfilterbase.cxx:344:12
        >     #23 0x7f95441ceaa8 in oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler> const&) /sc/source/filter/oox/workbookhelper.cxx:1046:27
        >     #24 0x7f95442797f1 in oox::xls::WorksheetGlobals::finalizeDrawings() /sc/source/filter/oox/worksheethelper.cxx:1373:9
        >     #25 0x7f95442789e0 in oox::xls::WorksheetGlobals::finalizeDrawingImport() /sc/source/filter/oox/worksheethelper.cxx:996:5
        >     #26 0x7f954428744d in oox::xls::WorksheetHelper::finalizeDrawingImport() /sc/source/filter/oox/worksheethelper.cxx:1637:17
        >     #27 0x7f95441771de in oox::xls::WorkbookFragment::finalizeImport() /sc/source/filter/oox/workbookfragment.cxx:511:18
        >     #28 0x7f95cdd5b3ae in oox::core::FragmentHandler2::endDocument() /oox/source/core/fragmenthandler2.cxx:53:5
        >     #29 0x7f95caf4cfc2 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:896:36
        >     #30 0x7f95caf6e950 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1470:13
        >     #31 0x7f95cdce50d1 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) /oox/source/core/fastparser.cxx:121:15
        >     #32 0x7f95cdce5868 in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
        >     #33 0x7f95cddbb234 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:414:21
        >     #34 0x7f95cddb9b8d in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) /oox/source/core/xmlfilterbase.cxx:344:12
        >     #35 0x7f95435c4daa in oox::xls::ExcelFilter::importDocument() /sc/source/filter/oox/excelfilter.cxx:113:25
        >     #36 0x7f95cdcf953b in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/core/filterbase.cxx:488:49
        >     #37 0x7f95435c7733 in oox::xls::ExcelFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sc/source/filter/oox/excelfilter.cxx:176:25
        >     #38 0x7f95857c5b40 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2393:34
        >     #39 0x7f9585781c6a in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:761:23
        >     #40 0x7f95859a9652 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1980:36
        >     #41 0x7f95862145e9 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:720:28
        >     #42 0x7f95536a9900 in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1176:37
        >     #43 0x7f95536a091b in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:412:20
        >     #44 0x7f9553698f59 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:308:5
        >     #45 0x7f95536946e7 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:168:14
        >     #46 0x7f955376867d in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:591:16
        >     #47 0x7f95537688a6 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
        >     #48 0x7f9569f7cafa in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:71:62
        >     #49 0x7f9580718c56 in UnoApiTest::loadWithParams(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /test/source/unoapi_test.cxx:126:19
        >     #50 0x7f9580717ef8 in UnoApiTest::load(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:108:5
        >     #51 0x7f9580719254 in UnoApiTest::loadFromFile(std::basic_string_view<char16_t, std::char_traits<char16_t> >, char const*) /test/source/unoapi_test.cxx:132:5
        >     #52 0x7f95d8bf1018 in testTdf123647::TestBody() /chart2/qa/extras/chart2export2.cxx:1242:5
        
        (<https://ci.libreoffice.org//job/lo_ubsan/3048/>)
        
        Change-Id: I870d811e78b8c55b84627ae609f98f623465dd9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162294
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-19  Miklos Vajna  <vmiklos@collabora.com>  [f5a8d01d381925bba6a2560aacf5ca159fc0bdea]

        xmlsec: replace revert with an upstream fix
        
        The problem in the new code was that previously xmlSecNssInit() didn't
        require an already initialized NSS, but 1.3.3 did.
        
        Backport upstream fix that restores the old behavior that NSS init is
        not needed, which allows no longer reverting the
        xmlSecNssUpdateAvailableCryptoTransforms() call that upstream added
        recently.
        
        Change-Id: Ie33ccbff0149e3c406d5574e889d90da4fdbbfb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162292
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-19  Justin Luth  <justin.luth@collabora.com>  [3f50503a69bc92e3a0c6c36686d8ff37d77188bf]

        tdf#159158 DOCX import: relativeHeights of 0/1 are highest zOrder #2
        
        I thought I had removed all fallback stuff from the unit tests,
        but I was wrong. So do some general clean-up and simplification.
        
        I also needed to fix the maximum value for relativeHeight.
        Sadly, even my my unit test was wrong - since MS Word 2010 clearly
        showed the yellow star on the top for tdf159158_zOrder_max.docx. FIXED.
        
        I can't put my finger on why sometimes 0F00 0000 is a maximum...
        More testing suggests that generally the max is 01dff ffff.
        Again, this is based on testing
        since documentation makes no reference at all to a maximum.
        I also wonder if the last 10 bits aren't magical somehow...
        
        The previous max didn't sound right because
        there are so many unit tests with relativeHeights above 0F00 0000
        (and the values jump by 0400).
        
        RTF almost never uses GraphicImport, and no unit tests
        access relativeHeight, only behindDoc. It is used for
        IMPORT_AS_DETECTED_INLINE and passing arbitrary
        property-names and values to a shape (via \sp \sv).
        Thus, this change is DOCX only (effectively).
        
        Change-Id: I18c0e129a078abe5987b998b15697f4ae1a50a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162232
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2bc1c113a4b37e97d9faf9c88aec01d5a0af7dae]

        Clean up generated embind code a bit
        
        For one, no need to wrap in #ifdef EMSCRIPTEN code that is only ever fed into
        emcc anyway.  For another, better use fully qualified names throughout generated
        code, to avoid unexpected collisions.
        
        Change-Id: I939728c7e0601e5fb3f3634bbd62f35042d91105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162266
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [229864a103b6ba8714a62609167be2deae16b987]

        tdf#159271: do not try to put fields' spaces to hole portions
        
        Change-Id: Ic1b3f9602089cc773f9c3adc0be09a3be08d690f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162269
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-19  László Németh  <nemeth@numbertext.org>  [73bd04a71e741788a2f2f3b26cc46ddb6a361372]

        tdf#106733 xmloff: keep fo:hyphenate in character formatting
        
        In the case of character formatting, map fo:hyphenate to the
        unused CharNoHyphenation character property to keep it
        during ODF import/export instead of losing it completely.
        
        This is the first step to disable hyphenation for single
        words or text spans in paragraphs with automatic hyphenation.
        
        Note: using fo:hyphenate as character property is part of
        the ODF standard.
        
        Note: the old workaround to disable hyphenation, changing
        the language of the text to None had got some serious fallbacks:
        losing spell checking and losing language-dependent text
        layout (supported by both OpenType and Graphite font engines
        in LibreOffice).
        
        Change-Id: I9565c3efbbb6e6d970fb03710e8c932ad72ab57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162257
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d4076bb145590bb10e5cd7e47628169bb9e6c446]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0336899f94a12eb46105b28b295eab35894bc969
          - Fix typo
            
            Change-Id: Id7a79a556df5eb131fed95e20e8730cfc1422004
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162264
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa356a8bfc45e14f4ae9a7a0c80c269a32b241fe]

        tdf#158277: sw: Add UItest
        
        Change-Id: I1f570e0397cd2c9d7ce754e03442b75b2867fafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162260
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [71d4abc51b556e147ab53a9a52b15be36fc710a3]

        -Werror,-Wdeprecated-declarations (Emscripten)
        
        > oox/source/crypto/CryptTools.cxx:57:40: error: 'HMAC_CTX_free' is deprecated [-Werror,-Wdeprecated-declarations]
        >         void operator()(HMAC_CTX* p) { HMAC_CTX_free(p); }
        >                                        ^
        > workdir/UnpackedTarball/openssl/include/openssl/hmac.h:35:1: note: 'HMAC_CTX_free' has been explicitly marked deprecated here
        > OSSL_DEPRECATEDIN_3_0 void HMAC_CTX_free(HMAC_CTX *ctx);
        > ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
        > #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
        >                                                 ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
        > #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
        >                                                    ^
        > oox/source/crypto/CryptTools.cxx:112:29: error: 'HMAC_CTX_new' is deprecated [-Werror,-Wdeprecated-declarations]
        >         mpHmacContext.reset(HMAC_CTX_new());
        >                             ^
        > workdir/UnpackedTarball/openssl/include/openssl/hmac.h:33:1: note: 'HMAC_CTX_new' has been explicitly marked deprecated here
        > OSSL_DEPRECATEDIN_3_0 HMAC_CTX *HMAC_CTX_new(void);
        > ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
        > #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
        >                                                 ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
        > #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
        >                                                    ^
        > oox/source/crypto/CryptTools.cxx:125:9: error: 'HMAC_Init_ex' is deprecated [-Werror,-Wdeprecated-declarations]
        >         HMAC_Init_ex(mpHmacContext.get(), rKey.data(), rKey.size(), aEvpMd, nullptr);
        >         ^
        > workdir/UnpackedTarball/openssl/include/openssl/hmac.h:43:1: note: 'HMAC_Init_ex' has been explicitly marked deprecated here
        > OSSL_DEPRECATEDIN_3_0 int HMAC_Init_ex(HMAC_CTX *ctx, const void *key, int len,
        > ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
        > #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
        >                                                 ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
        > #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
        >                                                    ^
        > oox/source/crypto/CryptTools.cxx:499:12: error: 'HMAC_Update' is deprecated [-Werror,-Wdeprecated-declarations]
        >     return HMAC_Update(mpImpl->mpHmacContext.get(), rInput.data(), nActualInputLength) != 0;
        >            ^
        > workdir/UnpackedTarball/openssl/include/openssl/hmac.h:45:1: note: 'HMAC_Update' has been explicitly marked deprecated here
        > OSSL_DEPRECATEDIN_3_0 int HMAC_Update(HMAC_CTX *ctx, const unsigned char *data,
        > ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
        > #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
        >                                                 ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
        > #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
        >                                                    ^
        > oox/source/crypto/CryptTools.cxx:512:12: error: 'HMAC_Final' is deprecated [-Werror,-Wdeprecated-declarations]
        >     (void) HMAC_Final(mpImpl->mpHmacContext.get(), aHash.data(), &nSizeWritten);
        >            ^
        > workdir/UnpackedTarball/openssl/include/openssl/hmac.h:47:1: note: 'HMAC_Final' has been explicitly marked deprecated here
        > OSSL_DEPRECATEDIN_3_0 int HMAC_Final(HMAC_CTX *ctx, unsigned char *md,
        > ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
        > #   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
        >                                                 ^
        > workdir/UnpackedTarball/openssl/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
        > #     define OSSL_DEPRECATED(since) __attribute__((deprecated))
        >                                                    ^
        
        Change-Id: Ia9edc299b7cd4728fe32adbca8e1212170c328ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162248
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [95daad8e5bd5da5a669cbdbee5daefe57cb368a6]

        Embind nicely supports std::u16string for OUString
        
        Change-Id: I2477bc67b3c62d302917e63b6286ffb4a78dafd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162259
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dd0b9cf1fb491791102a817af9c5726c7d0c3679]

        -Werror,-Wunused-variable (Emscripten)
        
        Change-Id: I990482890a3b6a8c799e49ba104d997ed74fdbe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c645ea801b4e06ab7be7e4a2912e6b1261015522]

        -Werror,-Wunused-but-set-variable (Emscripten)
        
        Change-Id: I5e0ce1137a09583d5d180ad922fba4ec27f8a6c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162252
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [4d0f2d5ec9f7f988a1493916ae35bac1986c95a8]

        Related: tdf#159259 Drop obsolete exclusion of framePr inside sdt
        
        Commit 73bd937420b9a99e1e35950e3f9dcbcfd874876d (n#780853 fix DOCX
        import of w:sdtContent in table cell, 2012-09-25) had introduced a
        restriction, where a framePr was ignored, when inside an sdt. It
        was required to allow table import, which broke otherwise.
        
        Since then, the situation has obviously changed; the test case for
        the change, added in commit 7ea71eb8a28c4b41949299ff7d4b391486c90eea
        (n#780853 testcase, 2012-09-25) passes after removal of the check.
        
        This check disallows importing sdt in frame. This makes the bugdoc
        of tdf#159259 to import the sdt in frame. The Lorem Ipsum paragraph
        is still enclosed into the sdt - to be fixed in a follow-up.
        
        Change-Id: I60fbb2dd6f753682217d86e4f8d315f1883c6e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162258
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-18  Miklos Vajna  <vmiklos@collabora.com>  [9f6b7af1a6f4f5b18dc9f8c8371ba579105665a3]

        sc: add a debug env var to control the source of the HTML import
        
        Similar to the existing SW_DEBUG_RTF_PASTE_FROM environment variable.
        
        Change-Id: I20713d8701b5eb38554e016ae818f49226638ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162255
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ec10bd238991a8eda71aec7d261eafa7e47ced0d]

        -Werror,-Wunused-parameter (Emscripten)
        
        Change-Id: Ia2e9ab91def1454bd06044b0e38f2d0720b44033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162246
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [ab2b0bd10481e9d0bb5bfea09ab0b034bb246c52]

        tdf#139631 sw_redlinehide: fix IntelligentCut feature with redlines
        
        Unfortunately forgot to adapt SwCursorShell::GetChar() to use the
        SwTextFrame instead of the SwTextNode, so it returns non-visible
        (deleted) characters to SwWrtShell::IntelligentCut(), breaking one of
        our oldest AI features.
        
        (regression from sw_redlinehide)
        
        Change-Id: I0c19944159e7e3af323bfe626c0e496ad745ef35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162253
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [403ba351302a0bf95a6f4dcc0cb0e675f593d3e2]

        -Werror,-Wunused-variable (Emscripten)
        
        Change-Id: Id931281ff716ed0fd26fda1972eb6f5defde7422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162249
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bfc615e5643c347ff1251853129de4cbf825ba81]

        -Werror,-Wdeprecated-enum-float-conversion (Emscripten)
        
        > static/source/qt5-mandelbrot/renderthread.cxx:61:62: error: arithmetic between floating-point type 'double' and enumeration type 'RenderThread::(unnamed enum at workdir/CustomTarget/static/qt5-mandelbrot/../../../../static/source/qt5-mandelbrot/renderthread.h:92:5)' is deprecated [-Werror,-Wdeprecated-enum-float-conversion]
        >         m_colormap[i] = rgbFromWaveLength(380.0 + (i * 400.0 / ColormapSize));
        >                                                    ~~~~~~~~~ ^ ~~~~~~~~~~~~
        
        Change-Id: I97dab1d11177a6e20ddd6703c146e31e316e0071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162251
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fdf7bd6c1cb8756d37813e72fbbec704d1c0f770]

        Don't artificially limit external/firebird to -std=gnu++11 on Linux
        
        0a42105a8d95473646b850eed6d428ebb93fc01f "firebird: fix CXXFLAGS" had added this
        to override Firebird's internal -std=gnu++03, but even back then the CXXFLAGS
        set there already included $(CXXFLAGS_CXX11) (so adding an explicit -std=gnu++11
        should never have been necessary), and CXXFLAGS_CXX11 has by now moved beyond
        -std=gnu++11 to at least -std=c++20.
        
        Which reveals that the code has a C++20 incompatibility that only GCC so far
        complains about (see the mailing list thread starting at
        <https://lists.isocpp.org/std-discussion/2024/01/2482.php> "simple-template-id
        in a constructor declaration"),
        
        > In file included from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/gpre/../gpre/../common/../jrd/../common/classes/fb_string.h:39,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/gpre/../gpre/../common/../jrd/ods.h:38,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/gpre/../gpre/../common/dsc.h:32,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/gpre/../gpre/gpre.h:1514,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/gpre/hsh.cpp:31:
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/include/../common/classes/alloc.h:264:36: error: expected ')' before '*' token
        >   264 |                 SubsystemThreadData* subThreadData,
        >       |                                    ^
        >       |                                    )
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/firebird/src/include/../common/classes/alloc.h:263:9: note: to match this '('
        >   263 |         (
        >       |         ^
        
        (<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/157406/>), etc.
        
        Change-Id: I89839452a0d474467ae62e57b6c990354e10f142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162209
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7baceb937de6a3eef7710cedd11590081ce759f9]

        -Werror,-Wunused-function (Emscripten)
        
        Change-Id: Ia7af2ad01bab012ad55bab86aac648078d4a8928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162247
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [135ce256ce9e879663d828ec6e699de521fad867]

        tdf#146487 Don't show generic diagram title when there is an empty title given
        
        Bugdoc has autoTitleDeleted set to false (so title should be visible), but then an empty title is given.
        In this case no default string should be added to the title, only in case of Pie Charts.
        Any other Chart types show the default title in MS-Office.
        
        Co-authored-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        
        Change-Id: Ib445099a4a3d113cff6b1ffdfd093fe41c34716b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155681
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [1f540c49e68b28a360ee5c32d60ab1bed3837eec]

        tdf#158277 sw_redlinehide: fix find bar string
        
        FindTextFieldControl::SetTextToSelected_Impl() uses the XModel to
        retrieve the currently selected text, which naturally includes deleted
        text.
        
        Instead, use view API XTextViewCursor to get the visible selected text.
        
        (regression from commit ae2232366f00e08c1855667cfaf068269ac9af2f)
        
        Change-Id: I302ea90a7407af6e3ae7b62a2f373dccb33b8275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162245
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [c80606bb23fd42e41710d70a96b7ffaf948384a6]

        tdf#109272: make sure that Delete / Backspace move cursor correctly
        
        ... in change tracking mode. Cursor's end position now doesn't depend
        on the selection direction; it is at the deletion's beginning in case
        of Backspace, and at deletion's end in case of Delete.
        
        Change-Id: I9cb7af235a066bea2c7b21b8ff515dcdd52218c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162240
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6c58b3a034c5bb584783f5a1ec7a69b9bf5699ed]

        Removed executable permission on data files
        
        Change-Id: Ic035dc91c298cc3743a6d4dbcb8b288a0df22905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162231
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [26cfd0d6997ebbad10049a5b6e38b73653553377]

        Revert "tdf#134526 Firebird: upgrade to release 3.0.11"
        
        Win daily builds are failing since then.
        Also Jenkins is failing intermittently so it needs
        more investigation
        
        Revert "New UBSan failure with Firebird 3.0.11"
        
        This reverts commit 345f8cc9de49f573b60f9dc63e7df17ce3c2f93c.
        
        Revert "external/firebird: Reinstate UBSan function-type-mismatch fix"
        
        This reverts commit d5445a8c470a661fac81a3f6fc55f6895a8ed9bc.
        
        Revert "mold: fatal: cannot open loader_path/../Debug/firebird"
        
        This reverts commit f2ba02eee98d04b3e473393d2647201ed2549b30.
        
        Revert "firebird: set -mmacosx-version-min to 10.15"
        
        This reverts commit 6998eacf542e6d6d9ec587aff3a38c3644e83c7f.
        
        Revert "tdf#134526 Firebird: upgrade to release 3.0.11"
        
        This reverts commit 00eae23267bf64e07cf057f828cd85f3c38ac669.
        
        Change-Id: Id4b0600965953051f6947f570c9b9a1f56044502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162200
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [359e5af31c330a137fed6ba3140b77cd759c28bb]

        tdf#155917 sw: fix Repeat of Insert File with Fly
        
        There is a fly frame anchored on the 1st node of the inserted file.
        
        On Repeat, first SwUndoInsLayFormat::RepeatImpl() runs and inserts
        another fly, adding 3 nodes before the body of the document, then
        SwUndoInserts::RepeatImpl() creates SwPaM from its stored positions that
        is off by 3 nodes and invalid (crossing cell boundaries).
        
        The problem is that the way the Undo objects are created in
        SwReader::Read() is wrong, and there is alreay a better way not to
        create the SwUndoInsLayFormat manually from the outside but
        automatically in SwUndoInserts::SetInsertRange(), which is already used
        in Paste - why Insert File never used this has always been a mystery.
        
        The only difference appears to be that SwReader::Read() also handled
        at-page anchored flys which SetInsertRange() didn't, as these probably
        can't be part of a Paste, but that is easy to add.
        
        (regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5)
        
        Change-Id: I19d7a4d668ae8bed0986162da6ec5b5ea3118091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162208
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-18  Patrick Luby  <plubius@libreoffice.org>  [fab9db6c7e85c76320743e1956c5a7c12f4ece0b]

        tdf#159025 skip undo if SwTableNode is a nullptr
        
        I don't know what causes the SwTableNode to be a nullptr in the
        case of tdf#159025, but at least stop the crashing by skipping
        this undo request.
        
        Change-Id: Idad1ed290af215e591018ea58732b77ca504ba01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162031
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2024-01-18  Kevin Suo  <suokunlong@126.com>  [89e032e9c4c51f52680c7d8bacf59ab2a34f2180]

        tdf#158314: show Empty and Error entries as non-selected and inactive...
        
        ...when hidden by autofilter.
        
        The "show hidden filter elements as inactive" feature was added and improved by:
        
        commit 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1
        (tdf#117276 sc: Show hidden filter elements as inactive elements)
        
        commit 2085e90fe8ac129bc4dbac4612d1ea7544335dae
        (FilteredRow is not a property of the column, tdf#117276 follow-up)
        
        commit 7321db3cadc8c0e4437ca04e5dcb652734ea9c26
        (Related tdf#117276 sc: Show hidden filter elements as inactive elements)
        
        commit 19533948370dc1ccd7334dbe1a8b7fc8330b10c0
        (Name FilteredRow what it is, not hidden; tdf#117276 follow-up)
        
        Those changes correctly made normal hidden filter elements as inactive,
        but failed to do so for Empty and Error entries.
        
        This patch shows the hidden Empty and Error entries as inactive and unselected.
        Also, do not show the Empty entry at the top of the list in case it is inactive.
        
        Change-Id: Ibcd758cebc0692b04b162cdfc3e06eceb86b17da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162166
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Kevin Suo <suokunlong@126.com>
        Tested-by: Kevin Suo <suokunlong@126.com>

2024-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [ab7893544dc6be6dc192dffefd57cd5ddd421c35]

        sw: layout: prevent bad page break in table with 0-height rows
        
        The bugdoc contains a table with most rows having a hidden-paragraph
        field in every paragraph, and no cell border or padding.
        
        The SwTabFrame is initially split across 6 pages, which should all be
        joined, as there are only 3 visible rows, but the last follow is never
        joined.
        
        This is because SwTabFrame::Join() of the next-to-last follow doesn't
        invalidate the SwTabFrame, because Grow(0) doesn't invalidate, and
        later formatting anything in the moved SwRowFrame doesn't invalidate
        either as it is all height 0.
        
        Try to fix this by guessing that the row will have height 0 (even if
        it's not formatted yet).
        
        Change-Id: Ic8246ac91c741f5a215f89dc159c44d7c7cf2ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162203
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6e08c83530bc54a47c10408a8472e95d1a4147ec]

        cid#1545625 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ibd32bdb5b1c4fc8220e99d308a21af64e4cad7b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ca704f49ea82dd69e0df059f6a80214fb77f026d]

        tdf#159120 Show only documents from the current module by default
        
        Treat individual LO modules as such.
        Suggesting spreadsheets in Writer's recent document list confuses the user.
        
        Start center shows all recent documents while the lists in Writer, Calc, Impress, etc
        only show the types supported by the current module.
        
        Change-Id: I9f95463424d9cc9bf2b1910aeed6e8e84a52aef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161782
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-18  Gökay Şatır  <gokay.satir@collabora.com>  [98f73277667d9fb440c47ff6f9c5c7bd74343dc5]

        Implement hyperlinkInfoAtPosition for Impress.
        
        It is used in readonly mode.
        
        Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
        Change-Id: I428d4923ab89dbcf6df237c68ae792753c1edf13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162201
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 876543305c78cb596720da087454a5c54e5feb06)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162222
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7c9cf3ccfce1f58991c7537bd44457c6a24ee226]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 572f801969514572d4722d16672ed5739f1e96a4
          - tdf#158992 Revisit Spotlight help pages
            
            Change-Id: I5226e24a88fed18f086279a7564e3c969732dc2c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162207
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [950af5a45723d16cc5e91324f021a2e77470f2ce]

        tdf#159221 Fix color scheme names under Gtk3 (Basic IDE)
        
        Color scheme names were not appearing in the "Color Scheme" dialog in the Basic IDE under gtk3 (View - Color Scheme).
        
        This patch fixes that.
        
        Change-Id: I9b019f3ed867ca6f45b53d67a3dc01139251391e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-18  Miklos Vajna  <vmiklos@collabora.com>  [b3c0163f00eeabf07e0ac5e00abe38b738bc5b08]

        CppunitTest_sw_uibase_dialog: turn on set_non_application_font_use
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23).
        
        Change-Id: I0af13caebda4308e75caad4515d585ea0d86d5a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162235
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b89c84bf3b01a8ed7314803db34adb20b6f909e1]

        external/firebird: Adapt to C++26
        
        ...as seen failing with --with-latest-c++ and recent Clang 18 trunk,
        
        In file included from workdir/UnpackedTarball/firebird/src/jrd/Collation.cpp:105:
        > workdir/UnpackedTarball/firebird/src/jrd/../jrd/SimilarToMatcher.h:1462:11: error: invalid bitwise operation between different enumeration types ('const Op' and 'MatchState')
        >  1462 |                 switch (ENCODE_OP_STATE(node->op, state))
        >       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/firebird/src/jrd/../jrd/SimilarToMatcher.h:1458:42: note: expanded from macro 'ENCODE_OP_STATE'
        >  1458 | #define ENCODE_OP_STATE(op, state) ((op) | (state))
        >       |                                     ~~~~ ^ ~~~~~~~
        > workdir/UnpackedTarball/firebird/src/jrd/../jrd/SimilarToMatcher.h:561:3: note: in instantiation of member function 'Firebird::SimilarToMatcher<unsigned char>::Evaluator::match' requested here
        >   561 |                 match();
        >       |                 ^
        > workdir/UnpackedTarball/firebird/src/jrd/../jrd/SimilarToMatcher.h:462:20: note: in instantiation of member function 'Firebird::SimilarToMatcher<unsigned char>::Evaluator::getResult' requested here
        >   462 |                 return evaluator.getResult();
        >       |                                  ^
        > workdir/UnpackedTarball/firebird/src/jrd/Collation.cpp:787:29: note: in instantiation of member function 'Firebird::SimilarToMatcher<unsigned char>::evaluate' requested here
        >   787 |                 return pSimilarToMatcher::evaluate(pool, this, s, sl, p, pl, escape, escapeLen);
        >       |                                           ^
        > workdir/UnpackedTarball/firebird/src/jrd/Collation.cpp:736:2: note: in instantiation of member function '(anonymous namespace)::CollationImpl<(anonymous namespace)::StartsMatcher<unsigned char, Jrd::NullStrConverter>, (anonymous namespace)::ContainsMatcher<unsigned char, Jrd::UpcaseConverter<>>, (anonymous namespace)::LikeMatcher<unsigned char>, Firebird::SimilarToMatcher<unsigned char>, Firebird::SubstringSimilarMatcher<unsigned char>, (anonymous namespace)::MatchesMatcher<unsigned char>, (anonymous namespace)::SleuthMatcher<unsigned char>>::similarTo' requested here
        >   736 |         CollationImpl(TTYPE_ID a_type, texttype* a_tt, CharSet* a_cs)
        >       |         ^
        > workdir/UnpackedTarball/firebird/src/jrd/Collation.cpp:843:28: note: in instantiation of member function '(anonymous namespace)::CollationImpl<(anonymous namespace)::StartsMatcher<unsigned char, Jrd::NullStrConverter>, (anonymous namespace)::ContainsMatcher<unsigned char, Jrd::UpcaseConverter<>>, (anonymous namespace)::LikeMatcher<unsigned char>, Firebird::SimilarToMatcher<unsigned char>, Firebird::SubstringSimilarMatcher<unsigned char>, (anonymous namespace)::MatchesMatcher<unsigned char>, (anonymous namespace)::SleuthMatcher<unsigned char>>::CollationImpl' requested here
        >   843 |                 return FB_NEW_POOL(pool) DirectImpl(id, tt, cs);
        >       |                                          ^
        > workdir/UnpackedTarball/firebird/src/jrd/Collation.cpp:862:11: note: in instantiation of function template specialization '(anonymous namespace)::newCollation<unsigned char>' requested here
        >   862 |                         return newCollation<UCHAR>(pool, id, tt, cs);
        >       |                                ^
        
        Change-Id: I0af4752b04020e978ea4b339ff21688302c63ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162230
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [67ba6ccd5a75ee6ade0e6aaa8bdc33f651a0d82c]

        tdf#140912, tdf#159219: fix import of graphic placeholder with custom prompt
        
        Importing the text marks the object as not empty. Then, the object would
        behave as an outliner object. This includes showing in slide show; allowing
        text esiting; stretching the placeholder image, which required a workaround
        implemented in commit 7b3be7f6f3d800e2ad86f5a043e6e9b21ed4409f (tdf#140912
        Better handling of the picture placeholders, 2021-12-01).
        
        Instead, drop the custom prompt. More correct solution would be making sure
        to mark the object as empty after setting the text; but this doesn't round-
        trip to ODF; and it crashes export to PPTX. Proper support for the sustom
        placeholder prompt feature should be done separately.
        
        The new workaround (dropping the text) makes previous workaround (special
        handling of the placeholder graphic) unnecessary. The unit test is updated.
        
        Change-Id: Ic7f42493af8d1d725ffa39ffab58f1ff033351cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162202
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-18  László Németh  <nemeth@numbertext.org>  [8b393bba91111bd4f8988457f3a78b0306462bf2]

        tdf#159102 sw smart justify: fix automatic hyphenation
        
        As before with soft hyphens, automatic hyphenation
        could result too much shrinking, because of calculating
        with an extra non-existing space in the line.
        
        Also try to shrink the line only if a space likely
        will be available in it.
        
        During testing, extend user dictionary temporarily
        with custom automatic hyphenation to avoid of false tests
        because of non-available hyphenation patterns. (Note: maybe
        the other tests with non-user dictionary based automatic
        hyphenations are not correct.)
        
        Follow-up to commit d511367c102ef2ada0f73dbe81744d39865d58ba
        "tdf#195085 sw smart justify: fix bad shrinking at soft hyphen".
        
        Change-Id: I58ecb8f1ea9f55ef2457d7ff4aca6aefa59a6dd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162199
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-18  Aron Budea  <aron.budea@collabora.com>  [5d52d7dcdf07e5d117e9854af5956b2e93ad3e46]

        silence use-after-free warning in mdds for gcc12.3 in optimized build
        
        Follow-up to e7c4166f1e150b10bc2ac52e93f8ad7503db09dc as GCC 12.3
        seems to be affected, too.
        
        Change-Id: I8e5ba9be64625ffd21d43e627996a9ea8602ce9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162181
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2024-01-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fcff7f72611d0b389b876d772038f095350ebdfd]

        tdf#159243 fix packaging of Noto fonts/fix Armenian UI on macOS
        
        different packages must not share the same package name
        
        Packages create corresponding packagename.filelist files that are used during
        the installset creation process. When multiple packages share the same name,
        it is random (depending on the order make decides to build the targets) which
        package will actually be included in the installation set. The last package
        will "win" and have its file stored in the filelist and thus will be part of
        the installation set, all others will not be considered.
        
        Change-Id: Ieffd2addf6d59916c0c1fe01c64866472ff23803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162206
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-01-17  Oliver Specht  <oliver.specht@cib.de>  [96323a10d3a55d212c350886e2a1344c0cd2ba95]

        tdf#150037 Writer: text fieldmark behaviour changed
        
        A mouse click selects the fieldmark to be able to overwrite the field
        with the next text input. Additionally the EN SPACE (0x2002) character
        is visualized by the DEGREE symbol when 'View/Formatting Marks' is
        active.
        
        Word's FORMTEXT ist usually filled with EN SPACE.
        
        Change-Id: I82446473d31bc5ea101bd1b94a50a855351d88b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161044
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [208a63779652789371f782b8e856f762baee2af1]

        Add back XComponentContext to officecfg::...::get() calls
        
        4256c764aee0777770466115a97420d9b55c23ac "do not pass XComponentContext to
        officecfg::...::get() calls" had removed it, for performance reasons, but
        8a695046cfcc8f9ec835b208b0d56ca821a3ff84 "tdf#158375 Hack to make sure process
        service factory is set" is a case where it should be passed in.  To hopefully
        avoid performance regressions, don't default to
        comphelper::getProcessComponentContext() for what gets passed in, but default to
        an empty Reference and only call comphelper::getProcessComponentContext() when
        actually needed in the implementation.
        
        Change-Id: I5b75ac2c28f36e21d1c8bc368b0b972c33c61a51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162205
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ef6083200a4f28e43198c7a0878da6f4b880725f]

        Add ConfigurationGroup/Set::isReadOnly
        
        Change-Id: I0c6c00a8a3c5c8bba923af24d136adccd269cef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [c8aef3e46256b667f4c777d6a26684df1d4c57f2]

        tdf#159101: sw_layoutwriter: Add unittest
        
        Change-Id: I1034e3fdf5f5f5cb4537a980bac704429b4fed30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162194
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-17  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8a695046cfcc8f9ec835b208b0d56ca821a3ff84]

        tdf#158375 Hack to make sure process service factory is set
        
        (TODO: A more clean fix would pass XComponentContext into the configuration
        wrapper.)
        
        Change-Id: I1936a4517877f30cc7a825ce1c94923b350f7173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162198
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-17  Attila Szűcs  <attila.szucs@collabora.com>  [ebda38ef860970bea2996f3122660339ef2ddacd]

        SC navigator: fix changing language of contenttree
        
        Save the actual language, when ScContentTree is created, and use
        that language to localise its text.
        
        Note: Saving language in ScContentTree::ScContentTree caused
        problems, so it is better to save the language when this
        tree is filled with text the first time.
        
        In case of LOK, there can be separate views, with different
        languages, that means there can be 2+ ScContentTrees, e.g. one
        has text in English and the other in German.
        
        When a new item is created that is listed in navigator, then every
        ScContentTree is updated at once... but that would use the global
        language, not the one what was used when the actual ScContentTree
        was created.
        
        Change-Id: I2dedf293e0ad9fb8f3cdd1090e1e1707a9f6cfa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159077
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162192
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2024-01-17  Patrick Luby  <plubius@libreoffice.org>  [12b33dce25a22e99c4f86f1ff139efb8dd144117]

        Eliminate hang in iOS app (and maybe the Android app) during export
        
        When exporting a document via this path, such as exporting to PDF
        via the .uno:ExportToPDF command, any exceptions thrown while saving
        the current document will leave the app in a blocked state if a
        "PENDING" message has been sent.
        
        The iOS app (and maybe the Android app) fails to set the URL to
        save to so we need to set it to a temporary file.
        Note: the iOS app is responsible for deleting the temporary file.
        
        Also, enable building iOS with TLS=OPENSSL by default.
        
        Signed-off-by: Patrick Luby <plubius@libreoffice.org>
        Change-Id: Ibc070bed4e792bb0a481d2b900d12d214e3c519f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161692
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162125
        Tested-by: Jenkins

2024-01-17  Jim Raykowski  <raykowj@gmail.com>  [b2500f0e32b33eec2740dc370238f66fb8b50ffb]

        tdf#159147 Fix crash when editing hyperlink while navigator is open
        
        by assuring the SwURLFieldContent::SwTextINetFormat pointer is still
        valid before trying to bring the hyperlink content to attention
        
        Change-Id: I7f672576ab2869c5483284b543e99e46a558acc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162013
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5bc1d4bea295695b193cab61b92ba89bcbe169cd]

        merge float fix from gcc3_linux_x86-64 to gcc3_macosx_x86-64
        
        presumably we need the same fix there as done with:
        
        commit 3bcc14b4e2b226f97e937ca7a152218f8276ee39
        Author: Stephan Bergmann <sbergman@redhat.com>
        Date:   Thu Aug 3 13:21:44 2023 +0200
        
            Fix handling of float vs. double values
        
        Change-Id: I7d6420dc954cdc320c9478172878e2a272ab2745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162193
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [f4647575a1e80169ba6f363fff72087d22165780]

        tdf#158950: sw_rtfexport6: Add unittest
        
        Change-Id: I870c28cf6ac7e1f4150414cc5f78992eb21289e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162190
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-17  Gökay Şatır  <gokay.satir@collabora.com>  [88a7384edcd8f4240a659f2c2c7c1258471341f4]

        Readonly Hyperlink Info - normalize the clicked coordinates.
        
        So the Online side can send the info in twips.
        
        Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
        Change-Id: I6f60f3a459856df72201b1100dce3306e9d0e47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162180
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 322669725b771f5fa2b3c10c5fb73238ca3713f6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-17  Luv Sharma  <luvsharma.del@gmail.com>  [ac20b8a470706d239d8782696c6d5fab0d705a2f]

        tdf#141908: replace hex colors with color keywords
        
        Change-Id: I3d23186045c17006e50d9ef48bc26df3c79d28b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162052
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-17  Adam Seskunas  <adamseskunas@gmail.com>  [07059f3336f0daea15c0574a67bd99986eccedd3]

        tdf#90341 Clean up excessive const_cast'ing
        
        Make SwBorderAttrs::CalcJoinedWithNext and SwBorderAttrs::CalcJoinedWithPrev member
        functions const, and make m_bJoinedWithNext and m_bJoinedWithPrev mutable since they are cached
        values, in order to remove a const_cast in CalcJoinedWithNext and CalcJoinedWithPrev.
        
        Change-Id: I8d75bde49646540cfa0af09c2d6f5461c5ace6d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161459
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-17  AmosAidoo  <aidooamos20@gmail.com>  [4df1ee15e4482d40b90435f054ee6cfd94233a68]

        tdf#114441 convert sal_uLong to appropriate type
        
        getLength function returns sal_Int64 hence the change.
        The function cast is removed to avoid redundant casting.
        
        Change-Id: Ia947c544efca18d0495a691aa4ad3de5e4617d6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162183
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-17  Gökay Şatır  <gokay.satir@collabora.com>  [332d7e878300b5cf627db59ba3065f6ecf63387c]

        Implement hyperlinkInfoAtPosition function for Calc.
        
        Move getEditURL function to public.
        When in readonly mode, we need a way to get the hyperlink info (if any) when user
        clicks on a certain coordinate.
        
        Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
        Change-Id: I2329b3569cfdca91f64cbdb46f43a3a9c34706c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162111
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit be01dd78c47b51b19603a6259504e29b11979b0b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-17  Matthew Kogan  <matthew@epoq.co.uk>  [4cdb542348b20d8a558cd6413c7cccdc50241fa9]

        tdf#159101 sw: Fix space appearing at start of line when field wraps
        
        Adding the ' ' to ScanPortionEnd fails pretty quickly with infinite
        loop.
        
        The important part of fixing the forum-mso-en-13115.docx was that the
        SetHasFollow(true) condition is not affected by a ' '.
        
        (regression from commit 21473f46fda5f1c7f220493667a96fff7c78a7b3)
        
        Change-Id: I6452673c0fe05ca549b63a398a977fc71db64bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162167
        Tested-by: Jenkins
        Reviewed-by: Matthew Kogan <matthew@epoq.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-17  Attila Szűcs  <attila.szucs@collabora.com>  [dc5a761df436f5d9de781d1fa6cf7d010f8be0e8]

        tdf#134401 SD: export to pptx: autoGrow->textWordWrap
        
        PPTX doesn't have autoGrowWidth and autoGrowHeight,
        but it does have TextWordWrap which is similar.
        If autoGrowWidth and autoGrowHeight are set in the document,
        then they are exported to PPTX as TextWordWrap = "none".
        
        Without this patch, PowerPoint may wrap some texts into more
        lines as Impress does. This is because some text may rendered
        at sligtly different sizes in PowerPoint as in Impress.
        (maybe it is just a rounding difference)
        Even 1% (or less) size difference is enought, because when
        autoGrowthWidth and autoGrowthHeight is set, then there is a
        good chance, the textbox rectangle is exactly as big as the text.
        
        Change-Id: I2cdba68c66c43507c5007a9e395b87ddeeea2372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162152
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-17  Miklos Vajna  <vmiklos@collabora.com>  [68826c545434653b083ef5fd4ec955b1e5fb73d3]

        CppunitTest_sw_ooxmllinks: convert one test to use CPPUNIT_TEST_FIXTURE()
        
        No need go via Writer-specific macros.
        
        Change-Id: Ib5e0b4f527cb6ff7ba72fd54037a339274aaf379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162186
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-17  Patrick Luby  <plubius@libreoffice.org>  [9bfd8e69385930d8f558c767f7b29149324d1b70]

        tdf#158740 fix crash by checking the end node's index
        
        I don't know why m_nEndNode is larger than the size of the node
        array, but adjusting m_nEndNode to the last element in the node
        array stops the crashing.
        
        Change-Id: I425589457c6729b6689a7046f063154a2496e811
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162035
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6a559ccacaab875d1aa1da70e3011592158e9d4]

        tdf#158950 Paste as RTF loses char color and paragraph alignment from styles
        
        This logic partially originated in
        
            commit 8e8f9388c323ad3c32cef3f91609ad19386b7d56
            Author: Miklos Vajna <vmiklos@collabora.co.uk>
            Date:   Tue Apr 22 12:53:24 2014 +0200
        Related: fdo#77600 RTF import: RTFValue::equals: compare attribute
        content
        
        But it is rather weird to compare RTFSprms this way, comparing each
        attribute to a parent RTFValue.
        
        Making the comparison more "normal" fixes the reported bug while not
        breaking fdo#77600
        
        Change-Id: Iee224c7bc9542c359f8a71086230e4b53c1c3e16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162164
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-17  Heiko Tietze  <tietze.heiko@gmail.com>  [bddae0d0dc4f64757100e00432ca40a6470d2c31]

        Resolves tdf#158958 and tdf#159124 - Improvements to Comments indicator
        
        * Option to control the indicator size added
        * Border color adopts the grid color
        * Indicator moved to the very edge of the cell
        * Default dynamic size reduced
        
        Change-Id: Ia298edfa30061910344a1afa42b42840b9cdab77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162175
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-17  achintya  <sharmaachintya08@gmail.com>  [eec344c49f13cc0a0a3ae9e4b98a842ec39ee446]

        tdf#145538 use std::equal in place of for loop
        
        Change-Id: Ie262b36a5ad1be9b2c4d5e8acffc58895e795910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161273
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [7e95e3868ff6a4d87b9051fa6219d8818c47c517]

        tdf#135083: make sure to apply pending paragraph properties, even without
        
        ... trailing \par.
        Commit a6ae84cc296d4d28e9a48a57406e955138c87a80 (tdf#70318: Prevent
        extra empty paragraph in clipboard RTF content, 2015-11-10) made sure
        to not emit trailing \par for RTF clipboard content. The problem was,
        that in the absense of the \par, the settings of the last paragraph
        were not applied (this happens in DomainMapper_Impl::finishParagraph).
        
        This change makes sure to call dispatchSymbol(RTFKeyword::PAR)
        (which eventually calls the mentioned method and applies pending para
        properties). Since this also adds a new paragraph (which needs to be
        avoided), a new flag is introduced, set by Stream::markLastParagraph.
        Its purpose is to make sure that all properties are applied to para,
        as opposed to bRemove argument to DomainMapper::finishParagraph, which
        prevents setting some properties (e.g., related to numbering - see
        DomainMapper::lcl_utext).
        
        Change-Id: Ia5e368e540c30f95058c81a280a62205aa85398b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162154
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-17  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [b8e393686c4ab6a69b091240065f440eadfff230]

        ITEM: Remove suspicious extra-Which in ::Put
        
        The ::Put methods at SfxItemSet had an extra WhichID
        parameter that was not really documented, but I would
        guess often asked why it exists: An extra WhichID, just
        called 'nWhich' (which makes things NOT clearer). That
        is 'strange' since the Item given to be put already
        internally has a WhichID, so why a 2nd one?
        
        If you were really interested and read all that code
        (no, no comments on that anywhere) you might know
        that this a kind of 'Target-WhichID' under which
        the Item shall be put to the ItemSet. Since this
        is unclear for most people it is even dangerous and
        explains why so many code places just hand over the
        WhichID requsted from the Item that already gets
        handed over.
        
        To make it short: I removed that. For the 19 places
        where this was really needed I added a new method
        besides ::Put called ::PutAsTargetWhich that takes that
        extra WhichID (now called TargetWhich) and takes the
        needed actions. These are quite some because that may
        be combined with the bPassingOwnership flag, see new
        SfxItemSet::PutImplAsTargetWhich method.
        
        This makes usage of ItemSets/Items less dangerous. It
        also simplifies and thus makes safer the central helpers
        implCreateItemEntry/implCleanupItemEntry which have some
        less cases to handle.
        
        Debugged the failing UnitTests showed that there is
        an incarnate Item != SfxVoidItem that causes problems.
        I checked for errors in the change, but no luck.
        Afterr some time I found out that a ::Clone
        implementation caused the problem: These need to
        also copy the WichID of the original, but the
        SfxFrameItem failed to do so. This did not cause
        problems in the former version because
        implCreateItemEntry was designed to set a missing/
        different WhichID.
        I corrected that in SfxFrameItem, also removed not
        needed costructor that caused that. Also added a
        SAL_WARN and a correction in implCreateItemEntry.
        I could have added an assert (did so for running
        local UnitTests), but should be enough.
        
        NOTE: When hunting for Items except SfxVoidItem
        that get crerated using a WhichID '0' i learned
        that this indeed happens: There are some (5) calls
        to SfxRequest::SetReturnValue that incarnate an
        SfxBoolItem with WhichID '0' (ZERO). This is not
        good and I think about how to change that...
        
        Change-Id: I9854a14cdc42d1cc19c7b9df65ce74147d680825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162124
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-16  Julien Nabet  <serval2412@yahoo.fr>  [1a637a07a0fb23f4d4bfac69378caff7ee965737]

        tdf#159213: fix Base crash when choosing "Help" in relations design (kf5)
        
        There are 2 parts here:
        1) in vcl/qt5:
        - for release versions: avoid to call QtAccessibleRegistry::getQObject on a null object
        - for debug version: add an assertion on object to check it's not null
        
        2) in svtools:
        the specific root cause  was in EditBrowseBox::DeactivateCell,
        we must check m_aImpl->m_xActiveCell in addition to isAccessibleAlive()
        
        Import remark: I had a very naive/bandaid patch at the beginning
        this one is entirely thanks to Michael Weghorn
        
        Change-Id: I90214e9c5b7c0aa45481915d7be6020a7dc8c42e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162182
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0e2ac814cbd165541f902177731093c9d9050453]

        Fix typo
        
        Change-Id: I4a4e461845dabe7d8e869b18028096d094381d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162120
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [52d95240244c9113d7cda76bf4ef0fefd193cfd7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e08228c2675a646daf27dac5def08eca97f3e88
          - Typo
            
            Change-Id: I9bd53d8a62332c1b41f44245880c75ad2086313b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162140
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8d399103c8e9d146fb6b915299d1078057ca3f47]

        Remove executable bits on rtf files
        
        Change-Id: I9990c75acfb40eb7aba742322767b42931aaf2ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162122
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2024-01-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [65c4b6d70a5e7eebb94db52f0389590bbf715827]

        A base B3DTuple can no longer stand in for a derived BColor
        
        ...after 925c05ee1a1259641a28fe43588f425aff06b95e "chart2: Make automatic area
        coloring for charts work for tiled rendering" added a non-static data member
        BColor::bAutomatic.
        
        And e.g. CppunitTest_basegfx started to fail with
        
        > ==2962908==ERROR: AddressSanitizer: global-buffer-overflow on address 0x7f67a04a8378 at pc 0x56434b3e7077 bp 0x7ffdf41d8220 sp 0x7ffdf41d79e0
        > READ of size 32 at 0x7f67a04a8378 thread T0
        >  #0 in __asan_memcpy at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:63:3
        >  #1 in basegfx::BColorModifier_black_and_white::getModifiedColor(basegfx::BColor const&) const at basegfx/source/color/bcolormodifier.cxx:318:20
        > 0x7f67a04a8378 is located 0 bytes after global variable 'basegfx::B3DTuple::getEmptyTuple()::singleton' defined in 'basegfx/source/tuple/b3dtuple.cxx' (0x7f67a04a8360) of size 24
        
        Change-Id: Ib1ec52ae388b213b10ad8a772a36b2158df8b003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162179
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [6fc537cdf496f3a644ec68d6103de51eb7f5c9cb]

        CppunitTest_sc_uicalc: sc_uicalc: extend test a bit
        
        Change-Id: I3c112c1362485868d0da016428fb897e6e3df3dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162171
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [e4755087cad159f8a3f628789256a4faa90a76bf]

        tdf#140330: sc_uicalc: Add unittest
        
        Change-Id: I6cbb3f310f0876119e0d335807991e7a4f753226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162169
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [30eb9b1941a801ccf18d450e307cbb8b91565fb3]

        tdf#104026: sc: move UItest to CppUnittest
        
        I just realized there was already a test for tdf#104026
        added in ad9336f29650dc38be06d771f5c3dbc7f0078ff1
        "add tests for tdf#104026" so I don't know why I added a UItest
        in a7c41f93421ddb2b48e38960b669c4e4f5413efb "tdf#104026: sc: Add UItest"
        Anyway, I plan to extend this test for tdf#140330, so moving
        it to CppUnittest
        
        Change-Id: I6c4de9298877cc1c51377b099a6a4a53cf54c05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162168
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-16  Jim Raykowski  <raykowj@gmail.com>  [4c8c57d542a7c9becef166d3fefdf5320500a012]

        SwNavigator: remove useless code
        
        The comment states:
        
        -> the user data here are no longer valid!
        
        meaning sOldSelEntryId = m_xTreeView->get_id(*xOldSelEntry) isn't
        valid here.
        
        Change-Id: Ie5591a93a96eefb97b7563af69753f4a105696eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162068
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-16  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [848d035d8659f6c98f220f91da641f7c40064765]

        Remove unused `make upload-update-info`
        
        Change-Id: Ifdec48aaf53b0444c2d7ceef554f64795e2f2c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162172
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-16  Michael Stahl  <michael.stahl@allotropia.de>  [3e9a700091872480dd085f0928d1d30b7d74cfd7]

        tdf#105844 xmlsecurity: fix test failure on WNT
        
        Commit 4d6e9d5e155da1dde05233eb87691e2a454162f6 added 2 tests that
        always fail on WNT, unfortunately Jenkins doesn't actually run the
        tests.
        
        There are 3 certificates involved:
        "Xmlsecurity RSA Test Root CA"
        "Xmlsecurity Intermediate Root CA"
        "Xmlsecurity RSA Test example Alice"
        
        In the signature XML, there are 3 elements that contain or reference
        certificates:
        
        1. X509Data - xmlsecurity produces only the signing certificate here
        2. xd:SigningCertificate (XAdES) - again only the signing certificate
        3. xd:EncapsulatedX509Certificate (XAdES) - xmlsecurity produces the
           full certificate chain here
        
        All of these elements *could* contain the full certificate chain, but in
        LO-produced XML signatures only 3. does.
        
        The problem is that the function CheckUnitTestStore() that looks up
        a certificate in a unit-test-specific CA store via
        $LIBO_TEST_CRYPTOAPI_PKCS7 can only handle a root certificate, it does
        not recursively retrieve and check a certificate chain.
        
        The SecurityEnvironment_MSCryptImpl::verifyCertificate() already has a
        parameter "seqCerts" to pass in the full certificate chain, but due to
        the way the data from the XML is processed, it gets passed only the
        content of the X509Data element(s), which, for LO-produced signatures,
        do not contain the full certificate chain.
        
        Instead of improving the unit-test-specific function, let's try to get
        all the certificates out of the XML signature, and then pass them to
        verifyCertificate().
        
        Of course this requires some consistency checks so that the verification
        can't be fooled by different certificates in different XML elements.
        
        Change-Id: I8ca541887ceac2dfb6af5d96a5565cfa58d7f682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162170
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-16  Michael Weghorn  <m.weghorn@posteo.de>  [89e7c04ba48dab824e9f291d7db38dac6ffd6b19]

        android: Update gradle + wrapper to 8.5
        
        Commit the result of running
        
            ./gradlew wrapper --distribution-type all --gradle-version 8.5 --gradle-distribution-sha256-sum=c16d517b50dd28b3f5838f0e844b7520b8f1eb610f2f29de7e4e04a1b7c9c79b
        
        (minus the automatically added `networkTimeout=10000` in
        `android/source/gradle/wrapper/gradle-wrapper.properties`).
        
        This includes the following upstream change for gradle
        to port from the use of `which` to the more portable
        `command -v`: [1]
        
        Thanks to Eli Schwartz for pointing this out in his previous
        Gerrit change [2] that was suggesting to only backport
        that particular change to the wrapper script.
        
        [1] https://github.com/gradle/gradle/pull/23961
        [2] https://gerrit.libreoffice.org/c/core/+/160667
        
        Change-Id: I1c230c75d2d8583852c59ff43ddfdf77daf5d5ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162081
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0dfc03f25d0cc0d5b12498fe8fa49ca87855c32]

        cid#1546333 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545979 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9ccdcf78ee961f9b90e365a246878c9243225ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [6f3a4504f56f32959917ef870c0b5d393942ed69]

        tdf#159216: Do not use layout-style
        
        Change-Id: I50c6f45cf12013ba7fb182928d5b566d88830d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162162
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-16  offtkp  <parisoplop@gmail.com>  [925c05ee1a1259641a28fe43588f425aff06b95e]

        chart2: Make automatic area coloring for charts work for tiled rendering
        
        Charts now get a temporary colored applied to the area property set if
        their color was set to automatic, which is done by default in tiled
        rendering mode.
        
        Change-Id: Ic6bd19b97d2a0ffa2a1ad516cfa202e2f4921db7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160659
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-16  Kira Tubo  <kira.tubo@gmail.com>  [bd570609281d92a48e7b3c0fe2d0c90457e7e3d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 92f7d7e64bd5154e6b1c780cbdefe4c50a316243
          - tdf#138748 Help: Language -> Locale for Sort Options
            
            Update help documentation to match replacement of "Language" to "Locale" in Calc sort options.
            Related to commit 79f3a2655d995421c989b9479e3c63e8ebeabeb2
            
            Change-Id: Id0ef7c9e8ff1e11f4d44e41dfcec9837d86e671d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162129
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f9da6e0ee9d5b15dbe6d9aee162cf849d7a0eb6]

        improve loplugin:cow_wrapper
        
        some stuff was hiding inside templates
        
        Change-Id: I89fd1a926dd6bf96e35a74e5028165acae51c60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [173b40944fa09825398ecd6f976f152ddd123257]

        Fix typo
        
        Change-Id: I352ca1bfee42b3dfe49401a4c75fbbb2140d28da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160204
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7bc36867e84f7b9ad091d320b5520d5bb6c287e4]

        sc lok: don't set the GridWindow size to document size
        
        We now set the GridWindow size to the size of the client area
        so no need to set it to the document size (which can get enormous
        in Calc). There are no ill effects AFAICS, but needs a lot more
        testing.
        
        Change-Id: Ib6d6fd0d72c9e8767bfe1636ba1621ccf9908f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162135
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dcff97abcd4e8d31032c316892cb09b5742ca1ec]

        editeng: add EditLineList test
        
        Change-Id: Iaec97999ae9ea0a01251e4449d3c7b74aa3539d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162072
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f54d9547c0f25b023614d52016c801e6be43e09e]

        loplugin:unusedmethods
        
        Change-Id: I24c429c7cb8283a384b72499d1c3f4c2f1457c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d62abd20dbfcc90cbea7b0b66fd4a3f3660f7ce9]

        ITextLayout is unnecessary
        
        everything inherits through TextLayoutCommon
        
        Change-Id: Ibf91804a62fc8f4a803682c7d4b9eaaba7468512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-16  Szymon Kłos  <szymon.klos@collabora.com>  [b804dc3c61ab595d3971e1b1a0e9a09ea498a7e4]

        Use correct type when getting document colors
        
        After commit 0460be8848b0ce02c07183e41dd7137ac3b94164
        Send document colors with lok callback
        
        There was issue detected by CI:
        /sc/source/core/data/document10.cxx:198:46: runtime error: downcast of address 0x6100000efa40 which does not point to an object of type 'const SvxColorItem'
          0x6100000efa40: note: object is of type 'SvxBrushItem'
           00 00 00 00  b0 79 19 48 ce 7f 00 00  01 00 00 00 94 00 be be  4c 17 00 00 a0 be be be  cc cc ff 00
                        ^~~~~~~~~~~~~~~~~~~~~~~
                        vptr for 'SvxBrushItem'
              #0 0x7fce1fbed369 in ScDocument::GetDocColors() /sc/source/core/data/document10.cxx:198:46
        
        Change-Id: I41f28b6bb54d7720d58c16d75b9d116a53f106cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162077
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5276aa03fa94e4c6b3e42c33647e649bb5d7c64f]

        cid#1586339 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I18109124eb1e78260b7cef8f809012118698e5c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162160
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-16  Attila Szűcs  <attila.szucs@collabora.com>  [acd3f201a93ddac406a1e86f8b055fdbd2a64400]

        tdf#154248 Impress: fix color of hyperlink
        
        Added a new FindAttrib method that searches in the attribs
        a bit different.
        The original FindAttrib searches in attribs as if their position
        intervals are closed from both side [Start,End].
        However, the actual attribs array was created using PaMs as positions,
        and these are right-opened intervals [Start,End)
        
        Change-Id: I9a46b6b27ce447366fc20af1b46fd60b5c745359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161836
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162158
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2188f940b0006e9ab421cae016f81fe366a4d649]

        ofz#65809 Direct-leak
        
        since:
        
        commit c84a1928ea76cf175711942db9ca7bb2f0ec6f0b
        Date:   Tue Oct 3 12:40:25 2023 +0530
        
            sc: condfmt-perf: use a shared cache that...
        
        mbReadyForFinalize gets set to true, but the mpFormat is never
        set into the ScDocument, add a mbOwnsFormat to track successful
        transfer of ownership.
        
        Change-Id: I8f11c68a4253d1ad67ec96825d5036ad468562ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162128
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-16  Marco Cecchetti  <marco.cecchetti@collabora.com>  [78f230713e1e1fd94f9fb1087bdba500fcf9231a]

        calc: on editing invalidation of view with different zoom is wrong
        
        This patch fixes the following invalidation issue:
        
        There are 2 views with different zoom levels.
        In a view text editing for a cell occurs.
        The other view is not invalidated properly: the computed invalidation
        rectangle is misplaced.
        
        Change-Id: I72db61486647640ee68e6cb2db96b2902de5b997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160303
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162161
        Tested-by: Jenkins

2024-01-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd8dad09097225726cbcd878d95d5bd0aacdf042]

        crashtesting: still seeing occasional impl_notifyEvent_nothrow failures
        
        e.g.:
        
         #0  0x00007f5a3a5d45fc in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (this=this@entry=0x7f5a38ffd680, listener=empty uno::Reference) at include/comphelper/interfacecontainer3.hxx:253
         #1  0x00007f5a3a5d9427 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> const&) (this=this@entry=0x7f5a3035ea08, func=...) at include/comphelper/interfacecontainer3.hxx:275
                 xListener = empty uno::Reference
                 iter = {rCont = @0x7f5a3035ea08, maData = {m_pimpl = 0x7f5a30132260}, nRemain = 1}
         #2  0x00007f5a3a5d950e in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::notifyEach<com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035ea08, NotificationMethod=<optimized out>, Event=...) at include/comphelper/interfacecontainer3.hxx:290
         #3  0x00007f5a3a5d39f9 in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:200
                 __func__ = "impl_notifyEvent_nothrow"
         #4  0x00007f5a3a5d3b83 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:233
                 rEventHolder = <optimized out>
         #5  0x00007f5a57cd95ba in comphelper::AsyncEventNotifierBase::execute() (this=this@entry=0x7f5a3010f670) at comphelper/source/misc/asyncnotification.cxx:139
        
        so lets guard the OInterfaceIteratorHelper3 ctor.
        
        might as well use empty() to return early then, and align
        the OInterfaceIteratorHelper4 case with that.
        
        Change-Id: I138841840e032e6524792fb75168ccabc666b34c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [48bbdf24ebe3cf78199bf213ab5585a293dc40ae]

        tdf#53614 - Don't try to lock file after cancelling the import process
        
        After cancelling the import process don't try to lock the file.
        Otherwise, the document in use dialog will be shown which has literally
        no effect.
        
        Change-Id: I0a9c786899a7fc648678c785e316d28fc43c7fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162150
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-16  Hossein  <hossein@libreoffice.org>  [b9a36edc6d435cb1b4bf8e950cd4dc49ecead2bc]

        Add a minimal Python extension
        
        This is a minimal Python extension. It is possible to run main.py from:
        
        1. Inside a LibreOffice extension
        2. Inside LibreOffice, and also via APSO
        3. Outside LibreOffice, as an external process, and also in a Python IDE
        
        The provided Python script is very useful for debugging extensions as an
        example. That is because it is possible to debug it in an IDE before
        packaging it as a LibreOffice extension.
        
        Python file is checked with:
        
        $ flake8 --ignore E501 main.py
        
        Change-Id: I24d9aefdfda29264bf6b5f9403a40fae35e610f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159938
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1bddc6ad3d1f233095ca0b475cb4b646fb9e508b]

        Fix typo
        
        Change-Id: Idfb2308f0f61a494524bb8c4bf74ae0c78b3cf06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162121
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9828f7dff3015fb948d9be95eb503f21558c5d11]

        Fix typo
        
        Change-Id: Icdfb0f41b7e69ea0efe441fdfba8b87aa370f413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162118
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60e07b7ceb7ca6d72b1a22953ca6194ece17b3d8]

        Fix typo
        
        Change-Id: I86b1472e88a6baaaaf562dc69cb98b079e963ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162119
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bddd00f7e40f3891fc48851727e7cce788741088]

        Fix typo
        
        Change-Id: I8da56aa65ff0488097b1f0ca00ed8ad08c212d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162117
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-16  Miklos Vajna  <vmiklos@collabora.com>  [a92924c3340617ea37ed94dbef0cd40723173317]

        sw: document SwUndoCpyDoc
        
        Explain how this differs from SwUndoInsDoc, when both insert content to
        the document.
        
        Change-Id: I426f5a229bffe16d98fa7f7cd0e64d394297becc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162153
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-16  Justin Luth  <justin.luth@collabora.com>  [db819557a351a5626a9ac50cd339dceb81749f58]

        tdf#159158 writerfilter: relativeHeights of 0/1 are highest zOrder
        
        Apparently 0 and 1 are the highest zOrders, 2 is the lowest, then 3...
        At least, this seems to be true for relativeHeight.
        Of course the documentation doesn't say anything about this,
        but documents conclusively prove a maximum zOrder of 251,658,240.
        
        [When MS Word 2019 round-trips a file with a relativeHeight of 0/1,
         it replaces them with the highest relativeHeight in the document,
         but values of 2+ are preserved.]
        
        Notice that there are two things that feed into zOrder,
        the other being z-index where negatives have special meaning
        in this context, but no special meaning for 0 or 1.
        
        Interestingly, relativeHeight is unsigned, but z-index is signed.
        This ends up not being a problem with a maximum of 0F00 0000.
        
        GOOD! LO normally exports starting from 2, but writes 0 if no zOrder.
        // It seems 0 and 1 have special meaning:
        // just start counting from 2 to avoid issues with that.
        
        Proof case that 0 is higher than both 300 and 225,763,766
        make CppunitTest_sw_ooxmlexport8 CPPUNIT_TEST_NAME=testN747461
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0equalA
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0equalB
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_1and0max
        
        Change-Id: I3540252ca5b0be3b2d847f1a3885adb850f39c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162038
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-16  Justin Luth  <justin.luth@collabora.com>  [d26fe92554273f7d8299f799681075d8a44a917a]

        tdf#159158 writerfilter: duplicate relativeHeights? last one wins #2
        
        Revert the previous solution and replace it with this simpler one.
        
        This version of the patch is riskier, but from what I can see
        last one always wins for GraphicImport.
        I assume that Miklos just limited it to a certain situation
        as a sanity check to try to avoid causing regressions
        outside of the scope he was working on.
        
        The fact that all DOCX and RTF unit tests pass is a good sign.
        
        The only way I would expect this to cause problems is
        if z-index somehow can come into play with a GraphicImport
        (since both z-index and relativeHeight feed into zOrder).
        However, an assert didn't turn up any instances where
        applyZOrder was called without a relativeHeight being set.
        assert(m_rDomainMapper.IsRTFImport() || bOldStyle || UsedRelativeHeight);
        
        Change-Id: I28e8acd5997eed0e82d5853c85b672c62b21afe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162036
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-16  Justin Luth  <justin.luth@collabora.com>  [a9c3955c13531045646df7c29a782980121e6960]

        tdf#159158 writerfilter: duplicate relativeHeights? last one wins
        
        [When MS Word 2019 round-trips a file with a duplicate relativeHeight
         it replaces them with unique relativeHeights in the export.]
        
        My THEORY is that bOldStyle should always be true for GraphicImport,
        so a follow-up commit will basically revert all of this,
        but at least if my theory is wrong, I'll still have fixed this problem.
        
        Notice that there are two things that feed into zOrder,
        the other being z-Index. I assume the very explicit code that says
        that (except for bOldStyle) first one wins must be the standard for z-Index.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf159158_zOrder_duplicate
        
        Change-Id: I842d016a7922427ce1290a7134d4e19fed52880f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161989
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-16  Méven Car  <meven.car@collabora.com>  [0ffa0f103f928da3785f8b6a71d2956ba51b6989]

        cool#1770 sw: make Edit Sections dialog async and mark it a jsdialog
        
        We want our dialogs to be async so they don't lock documents when opened
        and to allow concurrent edition.
        
        In SwEditRegionDlg, we need to make sure the reference to the SwWrtShell
        isn't read from 'this' after `response()`, as it is now the dialog is disposed of earlier in the async case.
        
        How to test: Create a new Writer document, insert a section, right-click inside the section, pick the 'edit section' menu item to trigger this dialog.
        
        Change-Id: Ibafca69542f13d16beef5a8fca006428cbcfe5c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161828
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161830
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-16  Méven Car  <meven.car@collabora.com>  [777b549242ab188eb68a8201cd0659d706f627e9]

        sw Edit Sections: hide Link section in LOK case
        
        In the LibreOfficeKit case the section does not make sense as the
        application has only restricted access to files, so hide it.
        
        Test: In Writer new document, insert a section, right click on section,
        Edit section..., Link section is visible.
        
        In LOK case the Link section is not present.
        
        Change-Id: I7aab8b384909d25e52f5fca2bf54f86e5c662b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161878
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit f9546a5e9e204fc058365aaddfb0dfa8f9a26418)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162130
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d91b6b7718704c0037cfbfdaa42ba259a0d791a]

        loplugin:unusedfields
        
        Change-Id: Ic53aacfc76cb73902cf5e304153975fa02509da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-15  Julien Nabet  <serval2412@yahoo.fr>  [877014b0b7050ba3fce1c0126279125640117313]

        Add missing g_free in salnativewidgets-gtk + reorder ones in cpdmgr (vcl)
        
        Change-Id: I2608a2fe238d124f3a158438e8219fbc63f750d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162126
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2024-01-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [e96956e82c5b792ad9c6a2a2f2b0406488be4de0]

        tdf#159148: sc_ucalc: Add unittest
        
        Change-Id: I748529b2a35fdfcac52fe33ecd39006471ed8e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162086
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d4ee5ee34da11d3580f0b778406424556ed0ed6]

        tdf#159174: sc_uicalc: Add unittest
        
        Change-Id: I5df0a4b4e0e9d0af5b9187def68e2971b2c86dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162089
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-15  Julien Nabet  <serval2412@yahoo.fr>  [b2ee028d0f805124d823a32aed70bcaf63377757]

        Replace deprecated "gdk_cursor_unref" by "g_object_unref"
        
        Change-Id: I593f5d8f0775e07e67cce66432bab52723f3afff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162116
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Julien Nabet  <serval2412@yahoo.fr>  [1ca7f0abc04f7b6bfa098c305481cb6ae4cd5443]

        Fix location of an g_object_unref in vcl/glomenu
        
        Change-Id: Icef8e74867758c815e1a55ae0906dead9b70ae6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162115
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Jaume Pujantell  <jaume.pujantell@collabora.com>  [e6be502d833e0380d225218abf4896a635525301]

        sw: search for alternative weights when embeding on docx
        
        Sometimes a docx document might come whith a font with niether normal
        or bold weight embedded as regular, so when embedding a font in docx
        search for alternative weights if neither a normal or bold matching
        font has been found.
        
        Change-Id: I95cf2634c392cec6e97e5dd12a90de6e50228ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161596
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        (cherry picked from commit 96d52b9e6879df3ab9697a7c0322cda5e08eb9af)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161942
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-15  Oliver Specht  <oliver.specht@cib.de>  [70386cd81f8c6e14014cf3cd50ecd6a987c12985]

        tdf#158830 fixes regression introduces with tdf#158044
        
        Removing paragraph attributes equal to style attributes now works also
        for paragraphs within tables.
        This fixes also the regressions documented in tdf#158978 and tdf#158982
        
        Change-Id: I9f430e23fd33cff4d6ec1d1954969666f0080574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161824
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2024-01-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2799b94bf92c0a928b1076e9320ba5c998b6aa99]

        Flatpak: Work around patched libpng in org.freedesktop.Sdk
        
        see
        <https://github.com/flathub/org.libreoffice.LibreOffice/pull/268/commits/7c79189f674c7cc88f0ab2790d8d198f4a855182>
        "Work around patched libpng in org.freedesktop.Sdk":
        
        ...which carries
        <https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/873b28450476c434a3f6fa86cb1874b11968a479>
        "elements/base/libpng.bst: Add support for animated PNGs", thus handles "acTL"
        chunks by itself, thus doesn't call the LibreOffice handle_unknown_chunk
        function (in vcl/source/filter/png/PngImageReader.cxx) for such chunks, thus
        never sets APNGInfo::mbIsApng to true, so causes CppunitTest_vcl_png_test to
        fail with
        
        > PngFilterTest.cxx:382:Assertion
        > Test name: PngFilterTest::testApng
        > assertion failed
        > - Expression: aGraphic.IsAnimated()
        
        (<https://buildbot.flathub.org/#/builders/6/builds/92958>) since
        <https://git.libreoffice.org/core/+/bf944e33569e4a1d6236a54671b7320cdc6ffaf6%5E%21>
        "tdf#104877 Add basic APNG format support".
        
        The patch appears to originate from
        <https://sourceforge.net/projects/libpng-apng/>, and it might be possible to
        adapt the LibreOffice code to also work with such a patched libpng (whose png.h
        defines PNG_APGN_SUPPORTED).  However, for now just use LibreOffice's own
        external/libpng instead of the patched one.
        
        Change-Id: Ib67056d11dfa6456920a18216a3b2bbec45f3662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162112
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-15  Dennis Francis  <dennis.francis@collabora.com>  [c84a1928ea76cf175711942db9ca7bb2f0ec6f0b]

        sc: condfmt-perf: use a shared cache that...
        
        is reset only when the data changes. Resetting is done only on
        invalidation of associated ranges of data via a listener.
        
        Earlier there were three separate caches that resets on every draw.
        
        Change-Id: I1c185ece4b781bf6db7c82697cd5225d98c82651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157508
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1aa1a5340f63b31524117a3cfd6e05bee2aa1aa0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161998
        Tested-by: Jenkins

2024-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [ed62e272ecc5a5642fe6e1c9e8b7575a02f5f521]

        Simplify a bit
        
        Change-Id: Icdaaed6710593d8082239d14e03b71ad82165658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162085
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3467777fa93205b935fbe150a61e03b7b94dffc1]

        tdf#151752: sc_uicalc: Add unittest
        
        Change-Id: I560de65bffbac2aa8cb194a15958249176c9db46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162080
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bf6cf27763b88583b7562c41c791fff45308362d]

        editeng: return ParaPortion from the list as a ref.
        
        Change operator[] for getRef(..) method, so instead of returning
        a pointer, return a reference to ParaPortion instead. This also
        needs changes to the code, because we now need to make sure before
        hand that the ParaPortion is really available in the list and when
        this is not possible or convenient, the change the call to use
        existing "SafeGetObject" instead. Add "exists" to check if the
        object is available in the ParaPortionList.
        
        In addition add "lastIndex" method to return the index of the
        last ParaPortion in the list (shortcut for Count() - 1).
        
        Change-Id: Id52c38f996468af51c75d50185110ec8502169e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162071
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6da480d086a599f6a0159c5244ce8fe0ae4131b8]

        crashtesting: null deref of xValueSeq
        
        since:
        
        commit 0bf4338cfe406a0d527ac78ce76ff7dd3837df03 (HEAD)
        Date:   Mon Jan 8 13:52:03 2024 -0500
        
            tdf#137691 chart2 export: preserve NumberFormat of DataSeries
        
            make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691
        
        Change-Id: Ibd65207b01885961f207da04204e7e2512c20d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162083
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [96493091a80fb01c33ea9153b737fdc554de61f0]

        tdf#140330: do not deduplicate conditional formatting in undo context
        
        Change-Id: If9c64a7af46ca601b3c47a80642d914facafdc62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162084
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [784efd860788b1cdbddd363abafe74b463e080f3]

        Fix typo
        
        Change-Id: Iea3ba026c91fd00285da842273c646dded9d8bda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162053
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-15  Alain Romedenne  <alain.romedenne@libreoffice.org>  [8a48869ec1635a59237c244bea394eee2112daef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4b6dc2bb6c67853f31c6059ca1b8fda32f00d751
          - Update SF_UI help page
            
            ui.Documents() must be defined as a method - instead of a property - in order for Python scripters not to be confused.
            
            Change-Id: Ic43c0bc212f914d2971d2366cb9b6c21e5fd6052
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161946
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2024-01-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [02923a0507f19aafc5f8a57fd540e8267c22481e]

        Fix typo
        
        Change-Id: Ic65f4cff636d67d94cb0cafc4f75f3bb57190c99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161976
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [6583f5d6b2120d1602c8a55c4e8dcc2b83503862]

        loplugin:unnecessaryvirtual
        
        Change-Id: I14ee125874b6f0f1ff5406a3eafea0b19df1a7f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [71296fd27dd9e3e5609b4fd41f3842673231a3ad]

        tdf#159186 Use changed value when editing string-list a second time
        
        Change-Id: I0e26a053b3b5fb04abf87894bcfebccea8bdd26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162074
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [ca931f4762eb7a47802270689b665b472908740d]

        android: Update com.google.android.material:material to 1.11.0
        
        Change-Id: Ic0f84c275e8780bd2c3da42cb5387587a4e26833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161883
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [c0a10888ab966b34cea1bf9a079725f89f133dcd]

        android: Avoid icon name clash with material library
        
        Rename the file for the keyboard icon from
        `ic_keyboard_black_24dp.png` to
        `ic_keyboard_black__24dp.png` (note the extra underscore)
        to avoid a name clash with an icon of the same name
        in the Material components: [1]
        
        Keeping the same name would result in this lint error when
        upgrading to material 1.11.0 (which an upcoming commit will
        do):
        
            > Task :lintStrippedUIEditingDebug FAILED
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 213 errors and 1 warning were filtered out because they are listed in the baseline file, lint-baseline.xml
             [LintBaseline]
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/lint-baseline.xml: Information: 6 errors/warnings were listed in the baseline file (lint-baseline.xml) but not found in the project; perhaps they have been fixed? Another possible explanation is that lint recently stopped analyzing (and including results from) dependent projects by default. You can turn this back on with android.lintOptions.checkDependencies=true. Unmatched issue types: PrivateResource, RedundantNamespace, TypographyEllipsis (3), UnusedNamespace [LintBaseline]
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/res/drawable-hdpi/ic_keyboard.xml:4: Error: The resource @drawable/ic_keyboard_black_24dp is marked as private in com.google.android.material:material:1.11.0 [PrivateResource]
                android:src="@drawable/ic_keyboard_black_24dp"
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
               Explanation for issues of type "PrivateResource":
               Private resources should not be referenced; the may not be present
               everywhere, and even where they are they may disappear without notice.
        
               To fix this, copy the resource into your own project instead.
        
            1 errors, 0 warnings (213 errors, 1 warning filtered by baseline lint-baseline.xml)
        
        (For the currently-used material 1.10.0, this warning was previously
        ignored since it's already listed in the lint-baseline.xml file, but that doesn't
        apply any more after an update.)
        
        [1] https://github.com/material-components/material-components-android/blob/bb351291a360319df31d5cee27e091c3e64f65a4/lib/java/com/google/android/material/timepicker/res/drawable/ic_keyboard_black_24dp.xml
        
        Change-Id: I2babc445c69f1043967118be81905c334a0285d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161889
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-15  Michael Weghorn  <m.weghorn@posteo.de>  [15eda65d04250434c099f953b2fea9a5325c5fb5]

        android: Update Android Gradle Plugin to 8.2.1
        
        This was suggested by Android Studio.
        
        Change-Id: I7278ce5e5b21477459e40a315912c846ec9b6d57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161882
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-15  Michael Stahl  <michael.stahl@allotropia.de>  [e4717342e5bea23f590a42d565a09ace600e2ca5]

        gbuild: WASM: try to fix "Missing generated source file *_embind.cxx"
        
        Need a dependency on UnoApiHeadersTarget.
        
        Change-Id: Ie9ca3a4806d15e2535f1119a00f9214ce9520a5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161973
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-15  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [510e94913b87fd6a3ea6444da492f6428afa47d8]

        tdf#159068 sc: fix detective shapes (PDF/UA export)
        
        The detective shapes(DetectiveArrow,ValidationCircle) don't have the
        option to set alternative text, so it should be marked as decorative.
        
        Change-Id: If83b29eb071b25f9eaa92a23337e416048b6aa8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162059
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-01-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [da9f8f9f93a1146f90c21ceec143a827063e24f5]

        sc: don't stop if we can't cast one view to ScTabViewShell
        
        Probably the intention here was to skip the view if we can't
        cast it to ScTabViewShell and not stop updating all the other
        views when we can't cast.
        
        Change-Id: Idbc2cd2d0c0ac5773fb45badb9098cb776d56691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161958
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a4e429f18cc61b091ee5f0e85e2786b7dd22ccd3]

        sc lok: set the GridWindow size to the client area size + test
        
        This solves the issue when we click on a long first column (size
        800px - default GridWindow size) at a right end position (>800px)
        and the selection jumped to the neighbouring cell. This solution
        reverts the workaround for this issue and properly sets the
        GridWindow to the current reported client visible area size (set
        with the ScModelObj::setClientVisibleArea call).
        
        Also includes a test for this issue.
        
        Change-Id: Ia5449893a90ffa0072aad68d772ad9b00206f113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161907
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161957
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a2cb1d16e71fd2b265c9ad4a497c5b8627ba9145]

        Fix loplugin:singlevalfields handling of DesignatedInitExpr
        
        ...as seen when building CompilerTest_compilerplugins_clang against recent LLVM
        18 trunk libc++,
        
        > [CPT] compilerplugins/clang/test/singlevalfields.cxx
        > DesignatedInitExpr 0x1388bb790 'void' lvalue bitfield
        > `-MemberExpr 0x1388bb760 'const __alignment':'const enum std::__format_spec::__alignment' lvalue bitfield ->__alignment_ 0x1401d5868
        >   `-CXXThisExpr 0x1388bb750 'const __parser<_CharT> *' implicit this
        [...]
        > error: 'expected-error' diagnostics seen but not expected:
        >   File /Users/stephan/llvm/inst/bin/../include/c++/v1/__format/parser_std_format_spec.h Line 499: oh dear, what can the matter be? [loplugin:singlevalfields]
        [...]
        
        Change-Id: I1cce598780bafc9306c9fbc42a1c98ff1f5450a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162075
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb16c98aeff98dd14929d82130508a1516baf6ae]

        cid#1545843 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545976 COPY_INSTEAD_OF_MOVE
        cid#1546073 COPY_INSTEAD_OF_MOVE
        cid#1546499 COPY_INSTEAD_OF_MOVE
        
        just silence these with a hammer
        
        Change-Id: I071bc9814287944928eea0286455bc59f7f6cefb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162062
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88dc47367938fe274871819900bdf87fee5aeacd]

        cid#1546160 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545547 COPY_INSTEAD_OF_MOVE
        cid#1545642 COPY_INSTEAD_OF_MOVE
        cid#1557206 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7a1bd4fcd065d4546917deb5d279691c8450f456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162061
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [369ecea5b9455e755a20e4fc2e62e4071076cec7]

        cid#1545775 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546321 COPY_INSTEAD_OF_MOVE
        cid#1546272 COPY_INSTEAD_OF_MOVE
        cid#1546287 COPY_INSTEAD_OF_MOVE
        cid#1545443 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia16a60665497e2c798fc03a2157587c107192558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162060
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c752aacb3ad12c8887d65af9cce506637759fe4f]

        cid#1546380 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545812 COPY_INSTEAD_OF_MOVE
        cid#1545463 COPY_INSTEAD_OF_MOVE
        cid#1545290 COPY_INSTEAD_OF_MOVE
        cid#1545844 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ie6d997fc6282599631dc9e07e2e59893e499c239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e3b9ba8ad544bc54ecdbded163d356a498ff4155]

        cid#1559946 Missing move assignment operator
        
        Change-Id: I73c8f506ed78238c80df45e087cb6b5bdc496ec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162057
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b34e4f8e90ee129920e079418e258d975614795]

        Fix typo
        
        Change-Id: I1f1741619c26504d44105809bc2deccfe03abaf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162054
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2024-01-15  Miklos Vajna  <vmiklos@collabora.com>  [b6f7ad722ec668e9c9324f82044e768af2cdf766]

        svx: prefix members of E3dDefaultAttributes
        
        See tdf#94879 for motivation.
        
        Change-Id: Icfa7f881de446095067c0f3a4a601cfd5da3228c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162073
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [84055d875ead6d7862cd8ddc5697a280240411fe]

        tdf#156830: fix faulty transformation order in cairo canvas for patterns
        
        Change-Id: Ib58e845c23dd14bbc3b96e5549a722b650d593a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162069
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2024-01-15  Noel Grandin  <noelgrandin@gmail.com>  [de09bd97f01ff9f27eb2d02dea0ced3f1485e252]

        add secmod.db files to .gitignore
        
        sometimes the xml security tests will leave these lying around,
        and we don't want them committed
        
        Change-Id: I703aee4cb5b3e5c41449f744f1628c09be70d077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-15  Andras Timar  <andras.timar@collabora.com>  [a2fb7ac13e6e1cc27559871f0455342bdcccaa40]

        FreeBSD: fix OPENSSL_PLATFORM
        
        Change-Id: I0f48d572edaed7e996be7a75d524c7d540a76ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162064
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-15  Andras Timar  <andras.timar@collabora.com>  [29df00696393c63be1071357e7d404610dc71ba8]

        FreeBSD: evaluate --with-gnu-patch
        
        Change-Id: I41e2cc8dc74022c840dac6355ed29cc0c4c40b17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162063
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-15  Miklos Vajna  <vmiklos@collabora.com>  [8ce222753a43d46e94d351069ce19cc3e2db333c]

        Update libxmlsec to 1.3.3
        
        Extend external/xmlsec/old-nss.patch.1, our bundled NSS in debug builds
        has some assert failure in relatively new xmlsec code, just disable it
        for now till it's clarified with upstream how to sort that out properly.
        
        E.g. CppunitTest_filter_svg fails like this:
        
        	#1  0x00007ffff77503e5 in abort () at /lib64/libc.so.6
        	#2  0x00007ffff679ca90 in PR_Assert (s=0x7ffff44fbfe5 "oidmechhash != NULL", file=0x7ffff44fbfb6 "secoid.c", ln=2140) at ../../../../pr/src/io/prlog.c:571
        	#3  0x00007ffff44eaae0 in SECOID_FindOIDByMechanism (mechanism=307) at secoid.c:2140
        	#4  0x00007ffff6660c65 in PK11_MechanismToAlgtag (type=307) at pk11mech.c:1745
        	#5  0x00007fffe874e4ea in xmlSecNssCryptoCheckMechanism (type=307) at crypto.c:68
        	#6  0x00007fffe874ec44 in xmlSecNssUpdateAvailableCryptoTransforms (functions=0x7fffe87ffbc0 <functions>) at crypto.c:401
        	#7  0x00007fffe874f13d in xmlSecNssInit () at crypto.c:552
        	#8  0x00007fffe86b2c36 in initXmlSec() () at /home/vmiklos/git/libreoffice/core/xmlsecurity/source/xmlsec/xmlsec_init.cxx:42
        	#9  0x00007fffdf3c54f2 in DocumentSignatureManager::init() (this=0x7fffffff3970) at /home/vmiklos/git/libreoffice/core/xmlsecurity/source/helper/documentsignaturemanager.cxx:79
        	#10 0x00007fffdf43e3da in (anonymous namespace)::DocumentDigitalSignatures::ImplVerifySignatures(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, DocumentSignatureMode)
        	     (this=0x1c07ac0, rxStorage=uno::Reference to (OStorage *) 0x1944e18, xSignStream=empty uno::Reference, eMode=DocumentSignatureMode::Macros)
        	    at /home/vmiklos/git/libreoffice/core/xmlsecurity/source/component/documentdigitalsignatures.cxx:486
        	#11 0x00007fffdf43da17 in (anonymous namespace)::DocumentDigitalSignatures::verifyScriptingContentSignatures(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) (this=0x1c07ac0, rxStorage=uno::Reference to (OStorage *) 0x1944e18, xSignInStream=empty uno::Reference)
        	    at /home/vmiklos/git/libreoffice/core/xmlsecurity/source/component/documentdigitalsignatures.cxx:373
        	#12 0x00007fffe6fa06df in SfxObjectShell::GetDocumentSignatureInformation(bool, com::sun::star::uno::Reference<com::sun::star::security::XDocumentDigitalSignatures> const&)
        	     (this=0x188c280, bScriptingContent=true, xSigner=empty uno::Reference) at /home/vmiklos/git/libreoffice/core/sfx2/source/doc/objserv.cxx:1847
        
        Change-Id: I36dee0d2b128a6931875572aa4acc9df940ab623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161951
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-15  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [261f758b650cf1c5c16acdad8f4a2dc86616f9e2]

        Make MAR-based LibreOffice updater non-experimental
        
        Change-Id: I7623e983e14ab7de3948921ca1223488fa2049a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162067
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [83c1df8e524cc74c6d1afcadb3cccba5ef2eb123]

        tdf#159151 Fix double space in Tree Control
        
        Change-Id: I400b0f84d52f365636ab86410abde330f3c05cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [6028845f24b4271cc6578e4d9d59d8fbc08974db]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d33c78198fbb0d56f08eb265d6ce432b1a7f66b1
          - Fix strings in sf_dialogcontrol.xhp
            
            Change-Id: Idf185b763d6a566d39bf7403015fc961d53ab614
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161935
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [bb5ae2ed78bdf94c56c581da21bb139554e0d6b1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 85b7b1975b0b8a9afd1abfc94c69f1152400ce04
          - Fix sentences in sf_document.xhp
            
            Change-Id: Ia3a3090e243c719255e3b7de02d26acc3bd4dc87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161936
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-15  Kira Tubo  <kira.tubo@gmail.com>  [451ed367752ad36d75eddb0cc1c7a971080201ec]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to be416c32550aa2fe0c0cfa94b437848a280261bb
          - tdf#125876 Update online help for Footnote/Endnote
            
            * Update menu navigation for Edit, Insert, Tools
            * Update "Edit Footnote/Endnote" dialog > "Auto" -> “Automatic”
            * Remove extra space
            
            Change-Id: I2e9209b62a1d1a81c8b0e830806047c298850ac0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162043
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-14  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [845d92e1f30eef5745480604fb9f6e4c3e3b7284]

        ITEM: Move Shareable ItemFlag to SfxPolItem
        
        Currently a Pool-Attribute (in SfxItemInfo), but should
        be a SfxPoolItem property. Originally 'moved' from old
        'poolable' used as hint. I identified needs more general
        and moved it to where it belongs.
        
        Also reworked SfxItemInfo to no longer have/support
        single bollean flags, but a FlagVariable and defined
        SFX_ITEMINFOFLAG_* entries to access these, that will
        make future changes easier without having to change
        all palces where these get defined over and over again.
        
        Added CheckItemInfoFlag for gereral access to that flag
        and e.g. NeedsSurrogateSupport to directly check for
        the SFX_ITEMINFOFLAG_SUPPORT_SURROGATE flag as syntactical
        sugar, that makes the intention clear.
        
        Change-Id: I09c238c7c5b7f721b657d7b0a44dbc8d14e02528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161982
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [04777d49b17834a5edf0063e89b968afae457191]

        cid#1585558 Using a moved object
        
        Change-Id: I59575034053cff0a4c534bdab7e80757839bab16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162048
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-14  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [cefe5464e6dd0082ce7e4698b2c8eac468e0ab7c]

        Fix system-libfixmath
        
        Seems distros start to disagree on whether its liblibfixmath or just
        libfixmath.
        
        Change-Id: I54a42b2ba050980ae632ab3c82254131cad7787e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161969
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-14  Aron Budea  <aron.budea@collabora.com>  [1bc6a730ecb7db289e7f72db3c9bce4812e775ed]

        lok: Replace loop with std::find_if(...)
        
        Change-Id: Icfe912f7b79454b9d208c39382ba187d0a0c16c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161810
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162045
        Tested-by: Jenkins

2024-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [1ad8f52476ee49f6a9d542cecd4e35e23146924b]

        Simplify a bit
        
        Change-Id: I68a094d99dee8b2e99b96e6e2ae675fe12174dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162046
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [580b2ecf88f7418374dff2d937c9e18f93d50381]

        Only run solver uitest if either lpsolve or coinbase is in
        
        Change-Id: Ic03a6df33344b92dccc9bc393d718b4011aa1613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162034
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [01092e632994a9b73ebcb29a4173d6eec6f1141c]

        editeng: change the ParaPortion parameter from pointer to ref.
        
        In most cases we expect the ParaPortion pointer to be not-null,
        so it makes more sense to have the ParaPortion parameter as a ref.
        and not a raw pointer.
        
        Change-Id: I1659a1978e2615982e4ce6bdd99c9d9f3719e7bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162040
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ee880f953e8b04c736a44fea63513d041681955f]

        editeng: use EditLine as ref. and use const
        
        We assert the EditLine pointer is valid (not nullptr) in some
        methods or just expect it to be valid without asserting.  If this
        is the case then we might as well change the parameter to be a
        reference.
        
        Also change EditLine to const&, where this makes sense in the code.
        
        Change-Id: Ia28810fea9d4e053f18fbb45968644545f5bf83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162012
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [b5c81b6c36dcd539d3104e7902373d96b3e025f6]

        Let SwAnchoredObject::GetFrameFormat return pointer, and drop HasFrameFormat
        
        In commit 19062c98da5b2e9edc7a99068fa06a83c7578826, it was important to
        check if objects have frame format before using GetFrameFormat.
        
        Thic change makes it simpler amd more obvious. Also, it allows to avoid
        two calls to GetUserCall, by obtaining the pointer once and checking it.
        
        Change-Id: I980fcba9e369e107f3d062e8cab0a34e02384290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162044
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Patrick Luby  <plubius@libreoffice.org>  [563f7077f1dbce31ff95ee8d2e8d17b629693db1]

        tdf#159089 dispose custom accessible here and unset for `m_xDrawingArea`
        
        rather than waiting for `m_xDrawingArea` to get disposed, to prevent
        unsafe use of the now potentially non-functional accessible until it
        gets disposed with the VclDrawingArea
        
        Change-Id: I5b8720ac4d5ed41cb1775b0142b17d198e9f036d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161903
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2024-01-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e22df0adeec10fb7c7e727b9347cb481a334de09]

        ofz#65619 fuzzing needs com.sun.star.i18n.Transliteration.IGNORE_CASE too
        
        Change-Id: Ic084abb703795a8463e85271cb34347323b07863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162028
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [5703d3af04b8fe78fdd4dbef14b08d8446402779]

        Simplify a bit
        
        And avoid a second call of pObj->GetUserCall.
        
        Change-Id: I4487ad33df594a8a96b517c5b4671512dea7116d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162042
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Mike Kaganski  <mike.kaganski@collabora.com>  [0b93cc83993b3cd78aa05556342839a21c96dc5a]

        tdf#159174: there may be no tabs in the clipboard document
        
        Change-Id: I053d91bf44e39e14ade9face14084a107d0df898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162041
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Matt K  <mattkse@gmail.com>  [3b10bbacb8a12a00c35683eeaae4a75046a84aac]

        tdf#159171 Prevent crash after selecting unprotected cells 2 times
        
        The problem is that the code tries to check for a table on a clip-
        board doc, but doesn't find any so it propagates nullptr back to
        the caller, which is then used without being checked thereby
        leading to a crash.  The fix is to check the result of the table
        check of clipboard doc before doing any operations with it, thus
        preventing the crash.
        
        Change-Id: Ieb4a52d0c1cb713d5c14930e5e559e5bf520b330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162033
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Matt K  <mattkse@gmail.com>  [59927dedc31eb5d51b417a02ae927eb578b90bd6]

        tdf#151752 Fix crash when selecting unprotected cells and copy/pasting
        
        The problem is that the code attemps to index into maTabs when looping
        through clipboard ranges, but maTabs.size() can be 0 at that point
        thus resulting in a crash.  The fix is to first check if maTabs.size()
        is greater than 0 before doing the looping.
        
        Change-Id: Ib2fc4c9f847f87f44a68ad6d73c2745d79b5caa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162032
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [67abfa11b611dc4ed98a660ec238fe76475200fa]

        editeng: add simple test for CreateLines method
        
        Change-Id: I4fd13727a1edc20220a95dd4899b91bdef088111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162011
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bf82669bf76428d00cc2c6041daf2c7a4812ceae]

        editeng: use unique_ptr for Append and Insert into a EditLineList
        
        We can better handle the lifecycle of the EditLine this way.
        
        Change-Id: I6fa3834bfdc19576158370a2c82da0771529a7f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162010
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c00f1227d3b9086c94aacea1c25496b73d32dc93]

        editeng: split up some code into own methods for CreateLines
        
        Change-Id: Ic61bdb09f9c6d84ce14c1ef84dc4a959ce62595f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161821
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [1637610478c4493c29a29286b66250ef47507681]

        Fix obscure xpdfimport crash on missing fonts
        
        Invert logic, such that the case WMode == 0 and no font set now run
        the former else branch. Happened here for an obscure pdf I was missing
        some fonts for.
        
        Change-Id: I2825c914a04f6a95d459eeeffb8091ed8f1819dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162029
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0cfb4aa2623b1606bbc66ef16256315778143227]

        cid#1546354 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546319 COPY_INSTEAD_OF_MOVE
        cid#1546286 COPY_INSTEAD_OF_MOVE
        cid#1546283 COPY_INSTEAD_OF_MOVE
        cid#1546191 COPY_INSTEAD_OF_MOVE
        cid#1545953 COPY_INSTEAD_OF_MOVE
        cid#1545874 COPY_INSTEAD_OF_MOVE
        cid#1545857 COPY_INSTEAD_OF_MOVE
        cid#1545781 COPY_INSTEAD_OF_MOVE
        cid#1545765 COPY_INSTEAD_OF_MOVE
        cid#1545546 COPY_INSTEAD_OF_MOVE
        cid#1545338 COPY_INSTEAD_OF_MOVE
        cid#1545190 COPY_INSTEAD_OF_MOVE
        cid#1545272 COPY_INSTEAD_OF_MOVE
        cid#1545242 COPY_INSTEAD_OF_MOVE
        cid#1545229 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I88813d9dbd87ce10375db8198028f8b70e23f0fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162027
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [d3963918544888608da149c3f0206d7a96828361]

        Add missing g_object_unref (vcl/gtksalmenu)
        
        Change-Id: I07db3d7a03da94b53ad49188c229c134dc2f663c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162017
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aff6d3aa461b737130606ed1271568b94f4733a7]

        cid#1545795 silence Using invalid iterator
        
        Change-Id: I5fc75150ce38a960fab092b2e7ac9a0fe642b26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [44d77f760cdac0c4a1c89421f8e02514f57d411c]

        cid#1546059 xRow is always empty
        
        Change-Id: Ic5c6b2463600cd449bf2e0fed829ce199172578c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162025
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d68d45102948ac6d54584f60ba5e493036438d0d]

        cid#1546488 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I80b843351641e38af6b9f9d6001b89206e37991c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162024
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [26c375988a913684320ef32ec85afb829913e687]

        cid#1585307 Out-of-bounds read
        
        sizeof should probably have been std::size, but just replace with
        range iteration anyway
        
        Change-Id: I60d9d7d74a5c039ad49387b114d1142ca27b032a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162023
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2da65b3c04e35a293cd2e630ffd9bc24b3453814]

        cid#1585309 Dereference before null check
        
        Change-Id: I49ab7a48e74055264037d6930692fdae8be6d3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162022
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49cc32842a039ab6b8e180df5b24ae8a5b1bd27b]

        cid#1585306 Uninitialized scalar field
        
        Change-Id: I3fa54356865f7f0cf322745c254eeb0867e6f422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162021
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [0b4510c060dc881fdc7d95379b06a02c413ae051]

        system poppler cannot be used with dbgutil
        
        Change-Id: I88d68e85c25bdaf6f4a06e00e812ac31cd125dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162019
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f7496ddce65f20a09807a394ae986905b999698]

        cid#1585308 Uninitialized scalar field
        
        Change-Id: Ia10f386a0ddb84dd1e3f8dd018cc5744185f0665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [4718a8e7af6df95c143179c7161a19aecade0701]

        Add missing g_bytes_unref in GtkSalMenu::AddMenuBarButton
        
        Change-Id: I00b8a73cfe02abc561ddf67c0e6e4ad612c27422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162018
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [f021d5eb645efaf749d97ad26471ef8ddf607db9]

        Add missing g_object_thaw_notify before an early return (vcl/gtkinst)
        
        Change-Id: I3ba4bfd9a302e03dd25e4635dfbb0a41d265349e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162015
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [dcf778c85c84edea74e71c11faed9a5c22557a80]

        Add missing gdk_event_free (vcl/gtkinst)
        
        Change-Id: I8bef4c3303f8f2fd89c1cf7cec35536c38d9d4d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162014
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [154573770de9658de828ea3b666c0a0a64ed249b]

        Add missing g_list_free in GtkInstanceComboBox ctr
        
        Change-Id: I1cb70afb229036209c635e52c9b22f619025f368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162016
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [f21fb5f530d40b4decdb5b9c153412f195293df2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8c6c19ab2fac10cdade1ae96721422814b19be3
          - Silence strings for translation in sf_dataset.xhp
            
            Change-Id: I62754d87b3feef4b54f7de43ec041c20c9ad07b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161940
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-13  Matt K  <mattkse@gmail.com>  [19062c98da5b2e9edc7a99068fa06a83c7578826]

        tdf#132810 Prevent crashes with gallery objects
        
        The problem is the formats for the gallery objects
        may be non-existent but the code attempts to use
        them anyway, causing crashes.  The fix is to check
        for the existence of the proper format objects
        before using them, so as to prevent the crashes.
        I tested creating/deleting multiple objects with
        multiple rounds of undo/redo and believe this change
        to cover all the crashes that can occur (there were
        several).
        
        Change-Id: I9d5d704eaa381be861ac1758ad58269706437a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161950
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [9fdf51275beb617abd67a82a76efe1d1f6fdf0a6]

        system zxing cannot be used with dbgutil
        
        Change-Id: I0b0c646f64ce103e706d8e4b1cc50f9120c4799a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161975
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-13  Julien Nabet  <serval2412@yahoo.fr>  [5ac343044fc24ff1f680740d541fc57ed3a9c065]

        Add missing gtk_tree_path_free (vcl/gtkinst)
        
        Change-Id: If178d41cd65cce3d07357fadb532059cc4d1c1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161983
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-13  Jean-Pierre Ledure  <jp@ledure.be>  [ca9168b8ad842c86b2168e12bb98087b9f8139bd]

        ScriptForge (SF_Array) fix tdf#158976 Shuffle()
        
        The algorithm used to shuffle a 1D array
        prevented any item of the array to remain
        in the same entry after the shuffle.
        
        This has been fixed. The potential targeted entries
        to receive an item include the actual entry.
        
        This change might impact existing scripts that
        have Randomize()d their sorts to always get the
        same shuffle results. This should impact test
        scripts only.
        
        SF_Array.Shuffle() is available in Basic only.
        No impact on help pages.
        
        Change-Id: If56d901f4af68f8889a7352c306bae6e3443ae97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161987
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2024-01-13  Justin Luth  <justin.luth@collabora.com>  [29cd541dfcff93a50c2e1ae9eab74f1908214c2e]

        tdf#139915 tdf#159157 writerfilter: fix image position with TEXT_LINE
        
        This is an IMAGE followup to vmiklos' shape/textbox fix in
        LO 7.2 commit 2f21e4f357ec60450df84ddd858c3cf0a4711b02
        
        Images follow a different code path, but needed the same treatment.
        
        Change-Id: I974944c7fbb4e0fa6aa52ac239c6a16ec7f927e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161986
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-13  Justin Luth  <justin.luth@collabora.com>  [81f67b474fad0b8967a7edebcb560daa35b87455]

        tdf#139915 DOCX export: fix anchored obj position with TEXT_LINE
        
        The position of objects was waffling back and forth
        between "above" or "below" every round-trip.
        For example, the unit test was alternating between 410 and 3951.
        
        make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf97371
        
        This is an export followup to vmiklos' import fix in
        LO 7.2 commit 2f21e4f357ec60450df84ddd858c3cf0a4711b02
        
        I noticed that import still does not correctly position images:
        make CppunitTest_sw_ooxmlexport8 CPPUNIT_TEST_NAME=testN747461
        so I created tdf#159157 and tdf#159158 as follow-up bugs for that.
        
        Change-Id: I29864d53f3b5e2fc9830793275f17a11eac0516f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161985
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-13  Justin Luth  <justin.luth@collabora.com>  [e86ff39d8c9c6ef8113814ff2bfdce53572812cf]

        simplify docxsdrexport: Get*Orient/GetSurround once
        
        Change-Id: Idb6cfc2b21d9170d01bf5e5d7f84dbb4752fa912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161984
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3808ef2b27a79f55f99543be20c26f0a4ad191b2]

        cid#1545535 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545526 COPY_INSTEAD_OF_MOVE
        cid#1545442 COPY_INSTEAD_OF_MOVE
        cid#1545426 COPY_INSTEAD_OF_MOVE
        cid#1545425 COPY_INSTEAD_OF_MOVE
        cid#1545387 COPY_INSTEAD_OF_MOVE
        cid#1545379 COPY_INSTEAD_OF_MOVE
        cid#1545337 COPY_INSTEAD_OF_MOVE
        cid#1545334 COPY_INSTEAD_OF_MOVE
        cid#1545289 COPY_INSTEAD_OF_MOVE
        cid#1545282 COPY_INSTEAD_OF_MOVE
        cid#1545270 COPY_INSTEAD_OF_MOVE
        cid#1545237 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iae44a7347c85ae2e367bf672214b2013f30466f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Eike Rathke  <erack@redhat.com>  [988db36e0992829b01a1341e92d6d2df715a7be5]

        Resolves: tdf#159148 Accept int32 hours:minutes:seconds input
        
        ... and detect overflow to result in text instead of 00:00 input loss.
        
        Change-Id: Ib2b9f16ab6c3c2963c5a2058c27366219f090096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161977
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2024-01-12  Dione Maddern  <dionemaddern@gmail.com>  [23987653e8f0b6f15f546496b4895cefc0d89a94]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2039fbabf053a19c9eaeee3db95dc8d710dfeb69
          - tdf#155877 Update help page with "how to get" information
            
            Change-Id: I1348ad34fc3e6180df2e0396f176dc6badbc529f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161677
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [3635a2d6d5ba348dfbce05705917fe086e328ada]

        cui: fix typo
        
        Change-Id: I587d60c8da53df937ed8992a846993078710659f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161971
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a31f334d36b5735ba6fc8d0f89e834a73bdcc561]

        Windows MAR update issues with program/{setup,version}.ini
        
        At least on Windows, our MSI install sets differ from our archive install sets
        in that their program/setup.ini and program/version.ini files have differing
        content:  For one, they have ProductCode, UpdateCode, and MsiProductVersion (the
        latter only in version.ini) lines that have empty values in archive install sets
        and non-empty values in MSI install sets.  For another, setup.ini in MSI install
        sets has additional ALLUSERS, BASISINSTALLLOCATION, FINDPRODUCT,
        INSTALLLOCATION, OFFICEINSTALLLOCATION, and UREINSTALLLOCATION lines that are
        completely missing in archive install sets.
        
        This is a problem when building MAR updates with create-partial-info:  Both ini
        files contain the buildid, so will always change between builds, so will always
        be recorded in MAR updates.  But when they are recorded as "patch", actually
        applying the MAR update file (generated from archive install sets) to an
        installation (originating from an MSI install set) will fail, as the size of the
        ini file in the installation doesn't match the expected size recorded in the MAR
        update file.
        
        I naively but strongly assume that those differences in ini file content are
        historic junk by now that have no practical consequences (i.e., I assume that no
        code actually makes use of those ini file entries).  Which would mean that it
        should actually be harmless to replace an installation's (MSI-originating) ini
        files with smaller (archive-originating) ones during an update.
        
        So for now I work around that problem by always forcing these two files to be
        recorded as a full "add" rather than as a "patch" in the generated MAR update
        file.
        
        In parallel, I will look into the history of all those problematic ini file
        entries, and will try to verify that they are indeed unused junk, and will try
        to clean that up.  (So that ultimately there will be no more differences between
        MSI and archive versions.)
        
        Change-Id: I9b22bd83889b569598162c37f9bf1a0857177063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161974
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-12  Miklos Vajna  <vmiklos@collabora.com>  [e5f80cc94fc0d8874e47e4425f2c58f0dde9debe]

        CppunitTest_sc_tiledrendering: ignore invalid json payload for STATE_CHANGED
        
        The interesting case for this testsuite is when the json for
        LOK_CALLBACK_STATE_CHANGED has a commandName key, ignore it callback
        when that's not the case.
        
        See
        <https://gerrit.libreoffice.org/c/core/+/161691/4#message-73673a8cedce0a5f661839553dd463983d22250a>
        for a case where this can happen, the json payload was
        
        "{\n    \"state\": \"0\"\n}\n"
        
        Which can happen when SfxLokHelper::sendUnoStatus() thinks that the
        commandName value would be empty.
        
        Change-Id: I398319f33288742b8f46f0d07b112fd61e9a9731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161962
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c469bffa3be4b2d3ca7f59448dbcc7b9bfdd7bf5]

        Further adapting of create-partial-info
        
        ...along the lines of what had already been done for create-update-info, passing
        files to the mar executable with an -f files.txt instead of on the command line
        (which could grow too long for Windows), and taking the archive metadata into
        account.
        
        For the latter, `make create-partial-info` now expects a second make variable,
        ONLINEUPDATE_MAR_OLDMETADATA, in addition to ONLINEUPDATE_MAR_OLDARCHIVE.  And
        there is a new TODO in update/create_partial_update.py that the old and new
        metadata should be compared for problematic changes.  (For now, any such changes
        would just get lost by an update.)
        
        Change-Id: Ide45adedb72958fc32c5b26aa7ebb01530ccf3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161972
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [d22a86089edfcadbef5231525a2947b954f4784e]

        tdf#158783 Correct compares of SwTOXMark Items
        
        That item was never 'pooled', so operator== was not really
        ever used. It just compared the 'type', so pretty many
        instances were assumed to be equal, what is wrong.
        We discussed to implement it (there is quite some content),
        but we came to the point that it's only safe to say
        instances are equal when same instance -> fallback to ptr
        compare.
        This came into play since I identified/changed many (160?)
        places where SfxPoolItems were ptr-compared when doing that
        paradigm change in Items. This leads to the two methods
        'areSfxPoolItemPtrsEqual' which just makes ptr compare and
        'SfxPoolItem::areSame' which also will use op==. For the
        initial adaption I chose the wrong function adapting
        places where SwTOXMark were involved.
        
        Change-Id: I7df029ad4542719681b1455de17ed5990d248395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161963
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae3a730a4b64fdb9698c753313504bbe174f1519]

        cid#1545669 aArgs is never set
        
        Change-Id: I17ebbb58c44cbc4314fef9bfe78ca0fa6c149539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161967
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2362e414ef1533c52215d16431d58edb59900751]

        cid#1546222 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546154 COPY_INSTEAD_OF_MOVE
        cid#1546120 COPY_INSTEAD_OF_MOVE
        cid#1546115 COPY_INSTEAD_OF_MOVE
        cid#1546111 COPY_INSTEAD_OF_MOVE
        cid#1546096 COPY_INSTEAD_OF_MOVE
        cid#1546016 COPY_INSTEAD_OF_MOVE
        cid#1545980 COPY_INSTEAD_OF_MOVE
        cid#1545942 COPY_INSTEAD_OF_MOVE
        cid#1545902 COPY_INSTEAD_OF_MOVE
        cid#1545869 COPY_INSTEAD_OF_MOVE
        cid#1545853 COPY_INSTEAD_OF_MOVE
        cid#1545769 COPY_INSTEAD_OF_MOVE
        cid#1545742 COPY_INSTEAD_OF_MOVE
        cid#1545735 COPY_INSTEAD_OF_MOVE
        cid#1545689 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If93debe8b00991761cf1876b3fce27b09906749e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161966
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b90638e34218190633e4bff1d989b29df9eb067]

        cid#1546235 aArgs is never set
        
        Change-Id: I5cdf0cc5031e3636bad4d9fdaa16d724f10c2b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161965
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d8133badce2152a2c5bd2872a408bda8fb45fa54]

        Adapt Flatpak build to new external/argon2
        
        Change-Id: I584956151b036e1ba781439205a76f579f32c064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161955
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-12  Michael Stahl  <michael.stahl@allotropia.de>  [3fefff7ce29a234694343105c50c7bc3259a9cb8]

        tdf#158783 sw: SwCursorShell::GotoTOXMark() must actually move cursor
        
        The problem was that the buttons in SwIndexMarkPane got the
        next/previous mark, but SwCursorShell::GotoTOXMark() may return the
        next/previous mark without actually moving the cursor.
        
        It happens that the current mark is outside a table and the next mark is
        inside a table, then UpdateCursor() doesn't accept the invalid cursor
        range and resets the point to its previous position.
        
        Change-Id: I5c0fb4a9bbcbdd479581172834b6eda76a5abbc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161970
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1dc4e0d2a0bb3561c539bbdbdf1678d712d5cb3]

        cid#1546414 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546408 COPY_INSTEAD_OF_MOVE
        cid#1546367 COPY_INSTEAD_OF_MOVE
        cid#1546283 COPY_INSTEAD_OF_MOVE
        cid#1546268 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8b6067f70bc0e8cce7117bb3f366227add279887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161964
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2da068327d18b7e8d63a17001a7abb4d9e350411]

        Resolves: tdf#159138 don't expand dialog to fit excessively long urls
        
        this widget is the one that ends up controlling the insert hyperlink
        dialog width
        
        Change-Id: I09aaa32e96c4ddcc3e608cb24e67a669d376120f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161960
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ca25be7ec49144d636675f389afc9f817e8b5b5f]

        resave with latest glade
        
        Change-Id: I52a7cd6a8e3bb42062d42b99b42875f89dd7b133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-12  Szymon Kłos  <szymon.klos@collabora.com>  [39b5a39bdc6d7fc86db5be6058b9f9251f070739]

        Send document colors with lok callback
        
        First step for publishing any palette for LOK.
        Let's start with Document colors (colors used in the
        document) which can be extracted similar to theme
        colors from SfxViewShell.
        
        Modify generateJSON function so it appends palette into
        existing ptree/JSON.
        
        In the next step we can make it more generic so it will
        be able to send any palette managed by PaletteManager.
        
        Change-Id: Ibb56690af6dfd59ee232e88b28e7a3d312d0e16c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161798
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 0460be8848b0ce02c07183e41dd7137ac3b94164)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161941
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ae7807c889c19145f89cec40afac82eee191837c]

        ITEM: No longer register Items at Pool
        
        The issue is that the flag RegisteredAtPool
        at the SfxPoolItem is Pool-dependent: It marks that
        the Item is registeres at *one* Pool/Model. This
        makes it Pool-dependent. Due to this there is no way
        to share Items that need to be registered globally/
        in multiple Pools/Models what is one of the goals
        for optimal sharing.
        
        We can also not live without having access to all
        Items associated with the Pool, due to mechanisms
        in place like the Surrogate stuff.
        
        This again is used for two purposes:
        
        (1) Access all Items associated with one Pool/Model,
        at least that is the assumption. This is not valid
        since it gets corrupted with a single ItemSet/Holder
        used that does not host model data, e.g. an open
        Dialog or the Sidebar (or...). But works in
        principle.
        
        (2) Access extra-Items that are held nowhere and
        are created using DirectPutItemInPool, e.g. infos
        for a Dialog. These would need a instance/place to
        host them, the Pool is (ab)used for that.
        
        Both are 'compromizes' (to not use a more bad word)
        and should not exist. (1) should iterate over the
        Model and do actions. There are even places that
        use (1) to *change* Items, by casting them to
        non-const, even RefCounted ones, so having no control
        over what all might be changed doing so. Since we
        talk about ca. 100+ places there is no way to get
        away from this - I can imagine how this happened:
        The 'poolable' attr traditionally needed for the old
        binary format was one day 'used' to not need to
        iterate over the Model, an API was added to access
        and this usage was copied. Sigh..
        
        It is even used when ODF is loaded: E.g. the
        FillStyle is imported from XML, interpreted, and
        put into an ItemSet. Then it gets set at the
        XShape using UNO API and a *name* -> that name and
        the Surrogate mechanism is used to find and set the
        FillStyle at the Model Object. The FillStyle could
        probably just be set using UNO API and the data
        directly.
        
        The association between Model/Pool and Item is
        created by the object hosting the Item, these are
        ItemSets and ItemHolders. Thus it is possible to
        register these at the Pool. This allows to iterate
        and collect the Items associated with the Pool
        and keep the Surrogate mechanism alive.
        This is the main change done here. It limits
        the registrations to Items for which (at the Pool)
        the NeedsPoolRegistration is set, also
        Item-independent. Speed is okay, I saw no big
        changes in my tests here. The registration is
        just pointers, no ownership or RefCounting needed
        here.
        
        The advantage is that Items get closer to be
        shared office-wide, they can be referenced by
        multiple ItemSets (RefCnt) associated with
        different Pools/Models.
        NOTE: This is not true for SfxSetItems, these are
        and will stay Pool-dependent due to their need
        to a Pool in the contained ItemSet.
        Note that we have ca. six deivations of SfxSetItem,
        but ca. 500+ Item derivations, so not too bad.
        
        For the usages of Surrogates to change existing,
        RefCounted Items: These can now at least be
        changed - if they show up to be problematic - to
        iterate over the registered ItemSets and change
        Items there the correct way: Set a changed one
        at the ItemSet. That also allows Objects to
        *react* on ItemChanges, there is no way to do
        that with the existing 'compromize'...
        
        UnitTests show that this already works well for
        SC and SD, but SW has still some issues. I will
        put this to gerrit now, but there will be
        additional work.
        
        A involved problem is the current DefaultItem
        handling and the state the Pool implementation
        is in. E.g. StaticDefaults are not really static,
        Pools hard-delete the DefaultItems (forcing the
        RefCnt to zero to not have the destructor
        complain) and other quirks. Looking at that
        right now, hoping to get this change done without
        having to change that too much.
        
        I thought about adapting PoolItemTest to this,
        but it is only related to DirectPutItemInPool
        which is mostly gone and hopefully completely
        soon.
        Nonetheless I adapted that mechanism to use a
        list of SfxPoolItemHolder at the Pool. That makes
        it safe and abandons the need for indirect
        garbage collection removal at the Pool.
        
        Change-Id: Ib47f21dafa989202930919eace5f7e9c5632ce96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161896
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-12  Julien Nabet  <serval2412@yahoo.fr>  [8f215fab5593070556e903121cc195660e16105c]

        Document a bit async methods
        
        Retrieved from Miklos' feedback in
        https://lists.freedesktop.org/archives/libreoffice/2024-January/091377.html
        Thank you to him!
        
        Change-Id: I13f074b12cae0ffbc78a4c580d7f0ce58f0ea1e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161664
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [43a7d21f99a08185ccbb3cc7b4cb9e9851c4d418]

        Update solenv/flatpak-manifest.in
        
        * Incorporate
          <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d9e2f088aafe41c3c9cc4af14e935777dba794c1>
          "Update gvfs-1.52.1.tar.xz to 1.52.2 (#272)"
        
        Change-Id: I95bee83408caab8e27eae978068f8ec4e87a9c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161956
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-12  Weblate  <noreply@documentfoundation.org>  [846a032ebd0859f4f52ca97741a2efa566fa9432]

        Added translation for android-viewer using Weblate (Abkhazian)
        
        Change-Id: I773dd0a06ea44d9978cbb9b169545ef8bd456c6d
        
        android-viewer translated using Weblate
        
        Italian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I98f0567a3b5b2fa853b468dfb1aec21230527b42
        
        android-viewer translated using Weblate
        
        Italian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I87ee3f9f46342bc1a4c3c4062a74a7c7afb9b3f9
        
        android-viewer translated using Weblate
        
        Czech currently translated at 6.7% (8 of 118 strings)
        
        Change-Id: I61735dcce61a859b45619b9b2742220f00ec94bc
        
        android-viewer translated using Weblate
        
        Italian currently translated at 99.1% (117 of 118 strings)
        
        Change-Id: I867af2d187ff54c701d6ec3a2f6b7114acb55aba
        Co-authored-by: Elisabetta Manuele <calembour@hotmail.it>
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Co-authored-by: Valter Mura <valtermura@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Андрей Абухба <aabuchba@mail.ru>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161721
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2024-01-12  Szymon Kłos  <szymon.klos@collabora.com>  [13e055808461f92be68f7691392b23159ac9a1ba]

        sc: announce theme colors with lok callback
        
        As it is done already for Writer. Unfortunately cannot
        move the code from afterCallbackRegistered to base class
        in sfx2 as it is not linked to svx which is needed to
        generate JSON. So at least share generation and sending
        part in ThemeColorChangerCommon.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Icbf681230bd4c49698c47d852a0862620d93bcec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161771
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161927
        Tested-by: Jenkins

2024-01-12  Kurt Nordback  <kurt.nordback@protonmail.com>  [ca3112f38ea67d3cff1c9784adcc30ffcb200a0a]

        tdf#159043: combo chart render order isn't right
        
        Change-Id: If20446c8bd5a67f73c24444126c26ed6bd160aed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161797
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-12  Kira Tubo  <kira.tubo@gmail.com>  [ba8f4bff6015013013df652efbfaf4d9ae10c881]

        tdf#145538 Use range based for loops
        
        Change-Id: I2e31b6ff335b5884a5d02d53bafef4315ad0fe68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161902
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-12  Regina Henschel  <rb.henschel@t-online.de>  [c994f2491dd4e977f726f53de1953feff17c2227]

        tdf#159049 use RTF_LINE for EE_FEATURE_LINEBR for copy
        
        Copy of simple text uses ImpEditEngine::WriteItemAsRTF() method.
        Error was, that in case of a line break ('\n') the string
        OOO_STRING_SVTOOLS_RTF_SL was written, but it needs to be the string
        OOO_STRING_SVTOOLS_RTF_LINE.
        
        Change-Id: I1c2ff2087c563b26e26d8768dfcfd1645be91d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161842
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [fa86997621e490fb490828e6a86f42e209d21283]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04877b3bb878e30f8df562a35bc97163ee6be9ff
          - Silence string for translation in sf_intro.xhp
            
            Change-Id: I12d48417dc979e85138b78f906fae3486f9673b4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161938
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [728be4c831d2c94d11a74445ff0665b2c7a0927c]

        Fix typo
        
        Change-Id: Ia63ef69c17c99de0c7bc3f33e7fc41dc042c2751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161925
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [de98291912f6fddca8ff6cc3212c8e3850977892]

        Fix `make create-partial-info` (for Windows, at least)
        
        I got lost trying to figure out how the original
        bin/update/create_partial_update.py code was meant to obtain old and new
        installation trees to diff, so I simplified that down to the create-partial-info
        make target now expecting an ONLINEUPDATE_MAR_OLDARCHIVE make variable that
        points at the old archive install set.  (And the
        --with-online-update-mar-serverurl configure option is gone for good again.)
        The remaining changes are similar to what was needed in
        28bad382face10be75af3875e44dde89fbc78108 "Fix `make create-update-info` (for
        Windows, at least)".  (And the mbsdiff and mar tools expect Windows-style
        pathnames, but mktemp returns a Unix-style pathname in cygwin shell scripts, so
        this needed an additional Windows-only external/onlineupdate/cygpath.patch.)
        
        Change-Id: I40690210d62e3f26fb2d574914a0dd4323e6cd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161924
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-11  Attila Szűcs  <attila.szucs@collabora.com>  [f97dc9d815ad8fdd75cbcd9c18b2e585ecf39ca5]

        LOK: fix language warning in setView
        
        Made the warning before the new language set.
        This way we log the old (wrong) and new (good) language.
        
        Elseway we could save the old languages to a temporal variable,
        set the language, and do the warning with the saved variable, but
        i think the extra variables would be a waste of memory.
        
        Change-Id: I0b69f49d07e9130bf1538c2c8e1d0b09cf82091f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161841
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit e09b3f5f4cd662a596b5d8d6ad4d5e2778e315f4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161916
        Tested-by: Jenkins

2024-01-11  Michael Stahl  <michael.stahl@allotropia.de>  [36f232e27616f267577851c38a24c2a5c3caad90]

        tdf#158783 sw: add some asserts for calling SelectTextAttr() ...
        
        ... with mismatched point node and SwTextAttr. Unfortunately SwTextAttr
        doesn't have a member that points to the node, just half of its
        subclasses do...
        
        Change-Id: I78193ac47a9287f01b236b71934053299d0ffb23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161928
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [bf410be4502c2d78e38856c455833681c6b8a151]

        tdf#158750 Highlight the line where the cursor is positioned (Basic IDE)
        
        This patch implements support for highlighting the selected line in the code editor, similar to what Kate, VSCode, etc do.
        
        If the cursor is positioned in a single line and nothing is selected, then a highlight color is applied to the line. The line number window also highlights the selected line.
        
        Change-Id: I2047d79500cd783b122b6752bb00996de0a7c702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161861
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [45f3398c9a816f70815cf38620cf5db2ce66431c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 46e73230cf1f0b3c9f21391099c2e15d8a54db3b
          - Improve sentences and fix strings in sf_dialog.xhp
            
            Change-Id: Ic710fe6e92f73b5f247d881046b71a165ec6812f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161933
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [c0075bf84ecb64186f42c861985af43e120101f9]

        tdf#155381 Remember the visibility of UI components in the Basic IDE
        
        This patch remembers the visibility of the Object Catalog, Watched Expressions and Stack Window in the Basic IDE.
        
        Change-Id: I2fea038ffc56af45cd6570feeb14ab84307f8cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161852
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-11  Stanislav Horacek  <stanislav.horacek@gmail.com>  [a207d7ab26fe0324e1074ffb96d6385b3781b391]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 163b2d43d3e746a5c71c77b61e9e5dba4a34c039
          - fix various typos
            
            Change-Id: Iba87ac215420d36ac9260fb3156b5493a3040f70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161900
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1b08dabad1fc217f7d0794c38f8f960c08f05ba8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26a5de6fa9b4134eda61cd21511f589cd1e852ad
          - Fix bookmark HID
            
            Change-Id: Ibe80002fd4d5b71600f6cda234646fb1bd33d6a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161934
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [6c0463e38d138e0e502bc9c8ae9a01f4809ef5df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to abbdd32a5cd87a4f21ba17e4ea9de6fd224b8ed4
          - Fix strings in sf_dataset.xhp
            
            Change-Id: Ifdee53dc4a92d9f889e9dc92943331659d28775b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161931
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-11  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a03a9236b01437b573cb68112959b9403418e11b]

        tdf#156769 - Escape the question mark in the storage name
        
        Otherwise, an auto-text using the question mark for its shortcut
        cannot be inserted.
        
        Change-Id: I369e3d0f2ff82cea2d053896964a5c2c23b8d6f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161921
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [773aa743ccb73a8aee027e1e5c8d2b4a0d066019]

        Update git submodules
        
        * Update translations from branch 'master'
          to 090a7639cc39ef9f36ed2ac8f58fd156ce755a4a
          - update translations for master/24.2.0 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I79b4bd9325c50387951258905a131141620d32e5
            
2024-01-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f69b38c74524c116cd9fe77dc8d3d62568786be]

        CppunitTest_sd_png_export_tests: relax test a bit
        
        See https://lists.freedesktop.org/archives/libreoffice/2024-January/091422.html
        
        Change-Id: I79e94912708a8d0ebd2aca76899e6fbb9fc23f2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161923
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2184890a0eebc55aa24cbe61de5b8918d958c65f]

        tdf#158664 Ignore Notifications when SlideShow is inactive
        
        The impl SlideshowImpl gets notifications for changes from
        the ObjectModel, but needs to ignore them when SlideShow
        is not active/running. For discussion how to do this see
        comments in task.
        
        Change-Id: Ic251af4b82f0f4b48d8d9b0127dd2f6015966935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161922
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-11  Miklos Vajna  <vmiklos@collabora.com>  [1bef59c318827666a2aa279ba4d1f59e53890a2b]

        CppunitTest_sw_unowriter: turn on gb_CppunitTest_set_non_application_font_use
        
        And the same for CppunitTest_sw_uibase_wrtsh, which found two places
        where font fallback happens for the checkmark glyph from the Liberation
        Serif font, so explicitly set the font name in those cases to avoid the
        font fallback at a glyph level.
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23).
        
        Change-Id: If72e94a61ef38f2f52e677ac989f60ccdae27cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161911
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-11  Attila Szűcs  <attila.szucs@collabora.com>  [e78bce3c1dbef3bbc0a18d9c17e458a69c2a8e46]

        LOK: fix setView language problem  
        
        Fix some mis-localization problem by checking for wrong language  
        at setView(...).
        
        setView does not change current localization, if the view we want  
        to set is the current view.
        
        But in some cases the language - view is not in a consistent state.
        Maybe the language changed but the view did not, or the current view  
        changed without language change (I found examples for both).
        
        Changed setView(...) so that it checks, if the current language
        matches to the current view, and if it does not, then we set
        the view, even if we want to set to the current view.        
        
        This won't fix everything, but hopefully it helps a lot.
        I think we should make sure that current view - current Language  
        are always changed at the same time (or at least we make sure
        they always match).
        
        Change-Id: Ie177b9b55f7befcbcf7cd1f62e402700f0e1aa60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160219
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161915
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [89d0ab74e58fdbc0f305a6fec6bd5da677599691]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6168024a68482349db0c02713e79d37a31519ce
          - Silence strings for translation in sf_database.xhp
            
            Change-Id: Ibbccb617adbb97da9f892ead789db8f643f78f83
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161930
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-11  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [37eb62c995a72fcd01d5f79e8b04fa0578cb822b]

        tdf#159066 sc: fix OLE object alternative text (PDF/UA export)
        
        Change-Id: I0af9cf61cafbe7ba93d08ed22fc11bb173612bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161904
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-01-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cf9d8631ee5d4b894425446a9e6a8c939ab0309c]

        Related tdf#73953 Increase default comment width
        
        Now that it can be resized, we can use a bit more space to increase
        readability for longer comments, and to match other software.
        
        Change-Id: Ia994d7288986a5cb206070b5066c42b59a9980e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161788
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-11  Jaume Pujantell  <jaume.pujantell@collabora.com>  [54ef7f9ea9e6d0c62076b4fc296ea1feb506b309]

        cool#7996 enable jsdialog for font page in document properties
        
        The checkboxes of font page on the document properties dialog were
        not saving the changes after pressing ok.
        
        Change-Id: I5e7d16de267dd5d6874a84b518f6ec769db4fcc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161795
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 545d512cccca5f7b866696b3a4dfc0e00748029d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161863
        Tested-by: Jenkins

2024-01-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b31561c3993aba9a49223ede7f1d72482f7b853]

        cid#1583748 Dereference after null check
        
        Change-Id: I147e0454e215b3a26e97c0a6d727db25fd2549a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [416b2ee59fe8209470d5cdcc2332682e22fbc719]

        Make create-update-info handle conditional content
        
        That make target operates on an archive, but generates data to be applied to an
        msi installation, so suffers from any mismatch between archive and msi install
        sets.  Two such mismatches, at least on Windows, are:
        
        1  Files that msi will install outside the LibreOffice installation itself (but
        which for an archive install set are included under LibreOffice/).  This covers
        (at least) .Net assemblies and associated files that are installed in the GAC
        (scp2 styles ASSEMBLY and ASSIGNCOMPONENT) and fonts (scp2 style FONT).
        
        2  Files that msi will only install conditionally.  This covers optional
        components (many of which in scp2 are assigned to gid_Module_Optional_...
        modules) and user interface languages (which in scp2 are assigned to
        gid_Module_Langpack_... modules).
        
        The approach taken here is to create a
        workdir/installation/LibreOffice/archive/install/metadata file while building an
        archive install set, and to record any files matching 1 (as "skip" lines) or 2
        (as "cond" lines).  Then, the create-update-info target uses that metadata file
        to act accordingly on those files:
        
        1  Files from "skip" lines are simply removed for now from the extracted archive
        that is passed to Mozilla's make_full_update.sh script.  (TODO:  That means that
        changes to such files will not be updated with the MAR update mechanism.  This
        would apparently need some extra processing during the MAR update.)
        
        2  Files from "cond" lines shall be recorded as add-if in the mar file manifest.
        Mozilla's make_full_update.sh script already has support for emitting add-if vs.
        plain add, but only for files under distribution/extensions/, which doesn't
        match our needs.  So we generate from the metadata file an ifs file that we pass
        into the make_full_update.sh script, and patch that script to also take that ifs
        file into account.  (Each line in the ifs file is of the form
        
          "testfile" "file"
        
        which works as long as none of the pathnames contains double quote characters.
        The Mozilla script code appears to be confused about the arguments to
        make_add_instruction(), where this ifs file will be needed:  There are calls to
        make_add_instruction() with two or three arguments across make_full_update.sh
        and make_incremental_update.sh, but make_add_instruction() checks $1, $2, and
        $4 (but not $3), so leave that mess alone and pass the ifs file as a global
        IFSFILE variable instead.)
        
        The mar file manifest `add-if "testfile" "file"` adds "file" only if "testfile"
        is already present, and those two can be different files.  TODO:  However, for
        simplicity, for now I always use "file" also as the "testfile" (so that an
        add-if file only gets updated if it was already present).  That avoids having to
        identify a specific "key file" for each optional component and for each user
        interface language, where that key file would be used as the add-if testfile.
        But on the other hand, it means that if an optional component or a user
        interface language will bring along a completely new file in the future, we will
        not install that file during a MAR update.  What obviously remains to be done is
        to properly assign each add-if file to a specific key file.  (And the current
        way of identifying add-if files by gid_Module_... names appears to be too
        simplistic too.  For example, there are some gid_Module_Optional_... that are
        installed unconditionally for msi; but it should be harmless that those files
        are recorded as add-if rather than as plain add.)
        
        Change-Id: I2fdeed92604f3a2d8a0b500b9e3fa421cfb6a9cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161917
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [fb443c6d4d210d73795bdb3b7cb392765726f3a1]

        Use officecfg instead of utl::ConfigItem
        
        Change-Id: If6fa84bcdb56873df288d216b157ad669c45bca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161622
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-11  Kira Tubo  <kira.tubo@gmail.com>  [79f3a2655d995421c989b9479e3c63e8ebeabeb2]

        tdf#138748 Change label to locale in Calc sort dialog
        
        * Under Calc's Sort dialog > Options, update "Language" label to "Locale"
        * Update accessible descriptions to match the new label.
        
        Change-Id: If98d568900f27974b73aa2ead402458385306ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161870
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-11  Szymon Kłos  <szymon.klos@collabora.com>  [40c94cff178bd4bef4dc5ce38cc9eb67fe2eb780]

        lok: send error on access denied in image import 2
        
        followup for commit	64624d225c71229acce4f889d4863d7c29c52658
        lok: send error on access denied in image import
        
        It shows an error in LOK when we try to insert image
        from remote host blocked by HostFilter
        
        Previously it was showing error in paste case,
        now do the same also on image insertion.
        
        For now disable HandleGraphicFilterError in sd, as it
        crashes, is synchronous and cannot be easily fixed
        - dialog sits inside module not linked to sfx2, needs
        some rework.
        
        Change-Id: I3c15ff5621add97ef9d60d4f4c1305dae2909158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161001
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161774
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-11  Miklos Vajna  <vmiklos@collabora.com>  [aaf6ce108e91b1504befe19afcee471e3316ae7a]

        cool#7492 sfx2 lok: set language/locale on async sidebar update
        
        Create two Calc views, set the first view language to English, second
        view language to German. Type in the English view, double-click on a
        chart in the German view. The sidebar in the German view will have
        English strings in it. This doesn't happen if there is no typing right
        after the chart activation in the English view.
        
        What happens is that the sidebar update is async, and
        sfx2::sidebar::SidebarController::notifyContextChangeEvent() gets
        called, which registers an aync event when it calls
        AsynchronousCall::RequestCall(). Then later this job gets scheduled, but
        possibly by that time the active view is the English one, leading to
        English strings when chart::ColumnChartDialogController::getName() calls
        SchResId(), which works from the language of the current view.
        
        Fix the problem similar to what commit
        fb7b0b944741e4efae8d92a6e305036aff906c7a (cool#7492 sfx2 lok: just set
        language/locale on async binding update, 2024-01-09), did: set the
        language/locale from the current view before executing the async job and
        restore the old value once we're done.
        
        Extract the now duplicated code to a new SfxLokLanguageGuard, so in case
        more places have a problem with incorrect l10n, then it's meant to be a
        one-liner to fix further places.
        
        Change-Id: I52724a24d93fb753175a3b9b99bc33178519d981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161920
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6996f399b82fb0482850829349a4bf1647529b2]

        Resolves: tdf#159086 add sensitive model<->treeview mappings for checkboxes
        
        These are basically implicit in vcl. For gtk if they are used they have
        to exist in the .ui, and to keep in sync with vcl there is basically
        just the one pattern that is allowed.
        
        Change-Id: I0f5603239569e9d39379515313a35d82d9266480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-11  Michael Stahl  <michael.stahl@allotropia.de>  [4d6e9d5e155da1dde05233eb87691e2a454162f6]

        tdf#105844 add test for ODF wholesome encryption with macro signature
        
        ... plus manifest schema extension.
        
        Change-Id: I73721db8620e97bd58556f9a71afcb0a33f6c7e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161898
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-11  Michael Stahl  <michael.stahl@allotropia.de>  [f1117fbfcd931d4ea2fccfb56f154aa6186d384b]

        tdf#105844 package: ODF wholesome encryption: use package version
        
        ... to init the Version property.
        
        The problem is that the outer storage loaded from a wholesome ODF
        encrypted document doesn't have a Version, because it doesn't (directly)
        contain a document and has no "/" file-entry.
        
        Extract the root element's package version attribute and use it.
        
        The Storage API doesn't distinguish much between the package version and
        the root document's (i.e. root folder's) version.
        
        Change-Id: I0fd5f999e9adee674d73fc542402512d0e204897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161897
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-11  Mike Kaganski  <mike.kaganski@collabora.com>  [6dbe164d730726b0a91fdef70ba16410f9d81dc4]

        tdf#159050: let fly portion swallow hole portion width
        
        Change-Id: I65492418ca5f5f5b04e5f9bab9ac3e6bf2108aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161910
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-11  Szymon Kłos  <szymon.klos@collabora.com>  [0f8ef44c919a59755a5b8cb2f9bd95b4ad538f82]

        lok: send error on access denied in image import
        
        - when we paste HTML with references to external images
          and host filter is configured then we have empty graphics
        - inform client about that so we can show an error to the user
        
        Change-Id: I7d584c256d8d004955c970056341ab42864d1dd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160319
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161773
        Tested-by: Jenkins

2024-01-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ac2720dcbe4e51e7f6733a385b5f7b571c6431e9]

        tdf#73953 sw: Allow resizing the comment section
        
        Change-Id: If2920b31a82b3f3d42038e75f3637be9802711fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161616
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-11  Matt K  <mattkse@gmail.com>  [e004c9dd2cc0da7f27503d14bfc13975889eea77]

        tdf#158937 Allow cancel of password dialog during recovery
        
        The problem is that when a user cancels the password dialog
        during recovery, the code tries to do something with the
        doc, but there is no doc yet because the file is password
        protected and not opened, so it crashes.  The fix is just
        to check for the absence of errors before using the doc
        (canceling the password dialog is considered an abort/
        general IO error).
        
        Change-Id: Ia76d8e4ff8212427d6b7b0a67ce1971b9ea8a48d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161844
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-11  Mike Kaganski  <mike.kaganski@collabora.com>  [7bd7085bcfce0b32179197a14189604d4c7478e1]

        tdf#159110: store URLs to DOCX correctly
        
        It must not decode URLs, and must store it percent-encoded.
        
        This was wrong since commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b
        (initial import, 2000-09-18).
        
        Commit d68b1b6ae355c92e982ec845216ba459dbdd9e16 (use correct
        INetURL-Decode enum, 2000-10-20) replaced incorrect "with charset"
        decoding with another incorrect "unambiguous" decoding.
        
        Change-Id: I915897dc2e3eb838fc02b4ac338b3d76fe0477fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161893
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-10  Martin Srebotnjak  <miles@filmsi.net>  [3cb1ed4339fc9aec414c0f112a69705a7a4d9cc6]

        Update git submodules
        
        * Update translations from branch 'master'
          to ed9d06780a198a3532adfafadd64557a46f4da3f
          - Updated Slovenian translation
            
            Change-Id: I99b8b0cffd064360ec5b3c36671a63c5598a992f
            
2024-01-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [bd88a9ec95bf2eba157bbdd6ccfd72cc468399bf]

        tdf#159075 Fix drawing comment triangle in Calc
        
        Change-Id: I82779ecd3ca4cf7ad95ab8f927c1a5e371613bf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161768
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-10  Kira Tubo  <kira.tubo@gmail.com>  [9d7d93bab83f7a421da6c2a3c3d68f54de93ab2b]

        tdf#114441 Convert sal_uLong to sal_Int32
        
        Update sal_uLong to sal_Int32 for nKey variable. Signed 32 bit variables
        have been used for similar variables within numfmuno.cxx and
        numfmuno.hxx
        
        Change-Id: Iabb15fe70fec9b28f675d6a63a6a36b1fd91439f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161822
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-10  Sahil  <me.sahilgautam@gmail.com>  [986b5bb3c183b038ecc1ce4e16cff1dca837932a]

        tdf#42030 Add UI label for page preview zoom slider
        
        * Scale before the page preview zoom slider
        * zoom % after the page preview zoom slider
        
        Change-Id: I893852bf48e31b36a028f9ee282d47a627bb0086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159362
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [772da0f1aa6891a0b31d45d99a5978c65ed24e34]

        tdf#156443, tdf#159079, tdf#158112: support Windows Alt codes >=256
        
        This change in fact disables Alt+NumPad accelerators. Alt+Number will
        still work, when Number is from main keyboard.
        
        Since this intercepts Alt+NumPad completely, it also disables movement
        of caret ny NumPad arrows, when NumLock is off.
        
        Change-Id: I82a3b0521f94038a84fa4dae2e3b1cfd4d4e23ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161891
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-10  Jim Raykowski  <raykowj@gmail.com>  [6c0081f3cd37541f8c0fe0fba69cc38c9b0a229b]

        tdf#158992 Only show style spotlight for styles that are used
        
        in order to reduce visual clutter
        
        Change-Id: I23ab3119fcb1dde0079db4cebb9fc4460ccb76bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161847
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [31b53a187dcde4de210555ec03891fd71ae701e4]

        add Armenian (hy) language pack
        
        Change-Id: Iaaa598cacb354140be422f4df256183ac0d91b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161890
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-01-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [55082266f0b097b01a12b2ce6dbee22a0d0b9ecb]

        Update git submodules
        
        * Update translations from branch 'master'
          to 78265f842d856fa49ab84fa2d190323df3773d29
          - update translations for master/24-2
            
            and force-fix errors using pocheck
            
            Change-Id: I25e899f694ffae0a88b186878a7eade41201d143
            
2024-01-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [7afd11f8e476884662c18db85445752cc030b2e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b85bb4516175e71903a9c5db583724231fa60471
          - tdf#156925 Document the Color Scheme dialog
            
            Change-Id: Ida045c1f2884b70b1f9a961eb2c17e8553b8f25b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161850
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4a963d3044694c5e320ec078d8654553c4649e1b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 102ffc2fc0c42e1e8c01c755a619b33ee4d553c1
          - add translations for Armenian (hy)
            
            Change-Id: I792da5a92e47c9434b7010a2701c29df55e51ae4
            
          - update translations for master/24-2
            
            and force-fix errors using pocheck
            
            Change-Id: I3e5ec55e0e0aec9f4e14099a88cd5f9f281f7aaf
            
2024-01-10  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f2517c7117c94a6b02c9b911691f2751520b150c]

        Adapt create-update-info to --with-lang
        
        ...where, depending on --without-lang/--with-lang=fu ba bz/--with-lang=ALL, the
        directory and archive file names appear to vary wildly, so go with a glob
        approach instead of trying to guess the exact matching names here
        
        Change-Id: I07355724f28eea66e619eb8d3d83c3e74217f54f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [961ffd72e2051490b3650348e97f99ef727a573b]

        Related: cool#7951 don't invalidate when creating a new view
        
        In writer the ViewOptions are in the ViewShell and are copied when a new
        ViewShell is created from that ViewShell so the dark/light-mode and doc
        color are the same in a new view as the old view.
        
        But in calc the ViewOptions exist in both the ViewShell and Document and
        a new ViewShell copies from the document not the old ViewShell. Setting
        the ViewOptions of a ViewShell in calc doesn't have an effect of having
        the same setting in a new view in calc.
        
        So if you create a new view from an old view you got the ViewOptions of
        the document, whose light/dark mode remained as "Default" when the old
        view dark/light more was set. So the mismatch triggered an invalidate.
        
        These additions to ViewOptions are relatively new in calc, and the
        desire is to get the same behaviour in calc as in writer, so move the
        new additions to a separate class that belongs to the ViewShell and
        copy them from the current ViewShell when creating a new ViewShell.
        
        Change-Id: Ie4b1dbb0437763ec4c8d067179c1fbef520161e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161791
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161880
        Tested-by: Jenkins

2024-01-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [212bbbe5cafab06b408ddde930bf9c8d37b7c3aa]

        cid#1546141 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546004 COPY_INSTEAD_OF_MOVE
        cid#1545934 COPY_INSTEAD_OF_MOVE
        cid#1545563 COPY_INSTEAD_OF_MOVE
        cid#1545533 COPY_INSTEAD_OF_MOVE
        cid#1545529 COPY_INSTEAD_OF_MOVE
        cid#1545502 COPY_INSTEAD_OF_MOVE
        cid#1545499 COPY_INSTEAD_OF_MOVE
        cid#1545479 COPY_INSTEAD_OF_MOVE
        cid#1545344 COPY_INSTEAD_OF_MOVE
        cid#1545324 COPY_INSTEAD_OF_MOVE
        cid#1545313 COPY_INSTEAD_OF_MOVE
        cid#1545252 COPY_INSTEAD_OF_MOVE
        cid#1545186 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I44a783876699f88c769f239ae84eb5cae44d5f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [ba3627ba899adb896855fddee9a0fdd8968b603a]

        tdf#158704 Add "Delete Comment" command to the Navigator context menu
        
        Change-Id: Ied128145ab0e171e536233dda2d31ec3eace1543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161766
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-01-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [9df028306fa75726eeda491f4d643d2a1073b33f]

        tdf#158763 Focus the document after clicking Edit Comment
        
        This patch is needed to make the gtk3 backend focus the document after the Edit Comment is clicked in the Navigator sidebar.
        
        It already worked in gen and kf5.
        
        Change-Id: Ic46be72e6ee7df71f2031e1c6b5f0bf153a8a8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161765
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b97a4df392ef03c6cbe23f7703fd4f55827ee71d]

        tdf#125030: sc: move UItest to CppUnittest
        
        Change-Id: If5bb88a7c20e094332a687978662b9a93edb18bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161876
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ad74486b63dc4cc4815eaa6008509e69219f3e8f]

        ofz#65655 build failure, github svn now disabled
        
        Change-Id: Id0d0fe466c9081560be9628b72d7002a8e5eadfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161886
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52f920ebf7f27396720b140ad8ee1beab13303c7]

        cid#1583747 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1583746 COPY_INSTEAD_OF_MOVE
        cid#1583745 COPY_INSTEAD_OF_MOVE
        cid#1583744 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib63c469844925723645f01720f8cebc60388ae29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161875
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-10  codewithvk  <vivek.javiya@collabora.com>  [4b33e878a446b0bcdb1d5f882a05a256967eea54]

        Make format condition, chart delete and pivot table error async
        
        todo:
        Make executeDlg_ObjectProperties_withoutUndoGuard dialogs to async.
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: I9927c1008d34370b9394aaf653afb575f69f2d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160557
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161703
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e80842b37ed8b3e76dce68719ac0dfbeaefd567c]

        cid#1583748 Dereference after null check
        
        since:
        
        commit 20502992b862e5a83140b6d2b19722cdc652eeab
        Date:   Mon Dec 4 14:08:09 2023 +0000
        
            calc: Add option to keep edit mode on enter/tab
        
        Change-Id: Ic338602945fb77cebf771fe3d0ad2e4e94fc0318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161874
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-10  Miklos Vajna  <vmiklos@collabora.com>  [84a3401c28135735c7bbe324eb3642b31c7f26f5]

        CppunitTest_sc_tiledrendering: ignore non-json payload for STATE_CHANGED
        
        The payload can be both plain text and json here, but in practice we
        only care about json for now, and I never saw a plain text payload when
        running this suite locally.
        
        <https://gerrit.libreoffice.org/c/core/+/161691/4#message-d4772c1362bc5e059f8ea13b4163926d9b462535>
        reports that sometimes we get an .uno:InsertAnnotation=enabled, so just
        ignore that without feeding that not-well-formed JSON to the JSON
        parser.
        
        Change-Id: Ic679ad20c453254237b906d4d2040824517d56e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161873
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-10  Adam Seskunas  <adamseskunas@gmail.com>  [ab70d0faf602de7d9711d99bd285a25c05335e9a]

        tdf#147666 sw layout: add test case
        
        The test adds a large picture to the test document, and tests if the
        document correctly moves focus to the added picture.
        
        Change-Id: I10c6ac00510250c374391fe9a53d42b3df317bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158761
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-10  Stanislav Horacek  <stanislav.horacek@gmail.com>  [63a14f58c32d9eddb951d3077bc1dcaa54625568]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88e571fc83adaad9c813df8cacc0cdfdef59174f
          - fix description of tooltip for horizontal scrollbar in Calc
            
            Change-Id: I42ceac6db188a5506696a836bcc0668349bdc9a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161839
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-10  Stanislav Horacek  <stanislav.horacek@gmail.com>  [09a850d7b48a4063bfa0ea5a6708b458ff935ec5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3e62e68f1f93b60b8350dc3f862039ce57ffb18
          - comments are on the right side of document
            
            Change-Id: Ic3a5541cd0b07bca15c6a21e884419d9a7f8d9f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161838
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-10  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ff0aaba4f1453c732e98190052c3f42e0e9676b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5b7969eb8d2f53dde6a55367821e6f1646de9d64
          - template manager dialog has "Templates" title
            
            Change-Id: Ie628e91504cc69651ac22fcf66d8adf14f7aae1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161837
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-10  Kira Tubo  <kira.tubo@gmail.com>  [99261442d9e7d2e5bcee2a8987ff8fe89225f3a4]

        tdf#125876 Update uno Footnote/Endnote labels
        
        Update labels according to comment 7:
        * Rename label in context menu > "Footnotes and Endnotes..." -> "Footnote/Endnote Settings..."
        * Rename label in Insert > "Footnote or Endnote" -> "Insert Special
          Footnote/Endnote"
        
        Change-Id: I4bef06cb95a52459331365588591a78c7413d579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161811
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-10  Miklos Vajna  <vmiklos@collabora.com>  [9d149e296525d0ba8e3f4f60bb1beaaa96d7adaa]

        sw: remove deprecated SwModelTestBase::getLength()
        
        Better to check the body text, not just the length.
        
        Change-Id: Ic40f770fff8e27594a6bdb87ce105aeeddf3f14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161872
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-10  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [4202218af61573825edfe5ec5a1bba710d7df1f7]

        tdf#159065 sc: fix PDF/UA link annotation
        
        Change-Id: I1586608780cc82908eaef62158887afee69c148f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161843
        Tested-by: Jenkins
        Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>

2024-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [8aeddf624dca4a34a4f2cf84c32cab0c99ef4db8]

        SwNumRule: SetInvalidRule(bool) -> Invalidate()
        
        It should only be validated using Validate().
        In SwHTMLParser::SetNodeNum, it was setting the "invalid" flag to false,
        while the comment was telling the opposite. It was this way since commit
        7b0b5cdfeed656b279bc32cd929630d5fc25878b (initial import, 2000-09-18).
        It seems that the call could be safely removed (it looks wrong to set it
        valid forcefully; but then, if it worked, why change it?); but first,
        let's change it to what the comment says, and see if something fixes
        magically.
        
        In fact, it also seems wrong to invalidate it explicitly from outer code:
        other setters should do it automatically; TODO/LATER.
        
        Change-Id: I0efb01434f77a53494272745e93482bb21612351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161849
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [a924532c27d6b745ebf4d6959083fb02ad3493b0]

        Simplify a bit
        
        Change-Id: I62ed68b943584b647c9e1ea78720151f26424665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161848
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [89b9302ccf870c4fdbc1071751536b80429a7d27]

        editeng: move for loop to range based
        
        Change-Id: I6d997d6315f8d5043de33fe43b6aaabf5bef7cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161820
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [ef6ff2df2e1286974da2f344aa3b8e3ae9093a79]

        tdf#158254: sc_uicalc2: Add unittest
        
        Change-Id: Ifc2bac24958cc0330d8174079886851ff1c0c990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161834
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-09  Justin Luth  <justin.luth@collabora.com>  [0bf4338cfe406a0d527ac78ce76ff7dd3837df03]

        tdf#137691 chart2 export: preserve NumberFormat of DataSeries
        
        make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691
        
        tdf116163.pptx is a good example if you look at the DataTable.
        Prior to this patch, the DataTable lost the number formatting.
        
        TODO:
        /chart2/qa/extras/data/docx/testSeriesIdxOrder.docx
        is exporting General in this case, which was unexpected.
        It appears to be an import problem though, not an export one.
        
        TODO:
        The fixme in testPPTXPercentageNumberFormats
        is still needed. Page 2's axis should LinkToSource
        and ignore the specified style.
        (It too is an example of this export patch working good.)
        
        Change-Id: I28730ba49ac2929bbc1c3be50f0d4819a5a205dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161806
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-09  Justin Luth  <justin.luth@collabora.com>  [0dd3df9400cebeb7cf24887a8640d07a3f9eb4b2]

        tdf#137691 chart2 import: provide NumberFormat to DataSeries
        
        make CppunitTest_chart2_export3 CPPUNIT_TEST_NAME=tdf137691
        
        This patch provides some very foundational support
        to importing a chart. It will open up a lot of doors
        to improve LinkToSource - since now the Source key is defined.
        
        Likely the source key should default to -1 instead of 0,
        so that LinkToSource can know whether or not the source is defined.
        
        /chart2/qa/extras/data/docx/testSeriesIdxOrder.docx
        is an example of where this patchset SHOULD have worked,
        but somehow it is losing its key during import...
        
        Unfortunately I have run out of time and can not follow
        these rabbit trails. Well, at least not until this change
        is considered a regression for some particular document...
        
        Change-Id: Ieddf2103002616aca2a408bde1f86d45c08dfc85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161702
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bafeb5835d1c11b3e217c0de3f9f430824079de]

        fix swapped CJK/CTL SvxLanguageItem types
        
        Change-Id: I213d6bac9d08734a7bd771f72540d1783a3a0115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-09  László Németh  <nemeth@numbertext.org>  [d511367c102ef2ada0f73dbe81744d39865d58ba]

        tdf#195085 sw smart justify: fix bad shrinking at soft hyphen
        
        Soft hyphen in the word could result too much shrinking,
        calculating with an extra (non-existing) space.
        
        Change-Id: If8b7af40ff50d12c0f2428a6f2475e261fbd0f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161827
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-09  sahil  <gautamsahil1947@gmail.com>  [0decafad011cf84cf9cc7d8bdcad6d7ebfba6073]

        tdf#114441 - Convert sal_uLong to better integer types
        
        Change-Id: I55c758f6391cecb261adca79ae1b93006bcae806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155979
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [345f8cc9de49f573b60f9dc63e7df17ce3c2f93c]

        New UBSan failure with Firebird 3.0.11
        
        While building ExternalProject_firebird:
        
        > workdir/UnpackedTarball/firebird/temp/Debug/jrd/scl.cpp:1171:38: runtime error: member access within null pointer of type 'const SecurityClass'
        
        Change-Id: I7f20495879da9b64a18ba8bd8673c42da8b483af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161833
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6a0dc770f8e288b88c00517e04c10777e2cb1b2f]

        Fix typo
        
        Change-Id: I75bcd6459f0bb8d0dcaf4d5646e31da2b71fb78f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161804
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [833b8bd3d19d0e1fb02bb5cb419d7076567527d9]

        Fix typo
        
        Change-Id: Icf3d2feb84f287e3e75f1eab488ec2804cd22a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161803
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-09  Michael Stahl  <michael.stahl@allotropia.de>  [79e8f18f635dfd094485ed18166fd8b04c37862c]

        sfx2: reorder the checks in SfxBaseModel::postEvent_Impl()
        
        It doesn't make sense to copy m_pData after impl_isDisposed() checks if
        it's null (not sure if this makes a difference in practice).
        
        Change-Id: I5c6db0bd3e09f92acef346115a4fee44ae4c0a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161835
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d5445a8c470a661fac81a3f6fc55f6895a8ed9bc]

        external/firebird: Reinstate UBSan function-type-mismatch fix
        
        ...that had erroneously been removed by 00eae23267bf64e07cf057f828cd85f3c38ac669
        "tdf#134526 Firebird: upgrade to release 3.0.11", causing
        
        > workdir/UnpackedTarball/firebird/src/intl/cs_icu.cpp:66:30: runtime error: call to function ucnv_fromUChars_73 through pointer to incorrect function type 'int (*)(UConverter *, char *, int, const unsigned short *, int, UErrorCode *)'
        > workdir/UnpackedTarball/icu/source/common/ucnv.cpp:1727: note: ucnv_fromUChars_73 defined here
        
        etc. to reappear that had originally been fixed with
        8336c1b579b6dff361e5422ebcdd225056752ed4 "New UBSan failures with Firebird
        3.0.7".
        
        Which then leads to the valid build failure
        
        > workdir/UnpackedTarball/firebird/src/common/unicode_util.cpp:1381:25: error: no matching constructor for initialization of 'const Array<USHORT>' (aka 'const Array<unsigned short>')
        >  1381 |                                 const Array<USHORT> str(strChars, prefixLen);
        >       |                                                     ^   ~~~~~~~~~~~~~~~~~~~
        
        so include a fix for that.
        
        Change-Id: I30436b62d3adca511aa929317ac9cb7f31576382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4a3804743645730dbb6dda21eacd1c3c93f85509]

        avoid null deref of xIgnoreAll
        
        Change-Id: Ib8e3309c046a74ca13f88fd0a668f3e1d6b909b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161802
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161815
        Tested-by: Jenkins

2024-01-09  Miklos Vajna  <vmiklos@collabora.com>  [6935efb902658ff2fdd8b154472816b3f035eca4]

        sw: document SwFormatTablePage
        
        SwFormatFoo is usually a pool item, but this one is not.
        
        Change-Id: Id60578dea4931926f86f5884985f86f346772850
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161814
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-09  Michael Stahl  <michael.stahl@allotropia.de>  [2184692bbe69a093368e959e1096cb7506feceee]

        xmloff: ODF export: if there's no checksum, don't generate chaff
        
        Change-Id: I2e1bb6ed33df327ebd797edeca7ee82b75c524b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161800
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e1abdcef4404c2a1b8d6d87ae295451a457aeae4]

        sc: LOK work-around for mouse click selecting the wrong cell
        
        Don't increase the cell selection if we detect the mouse click
        was out of the screen (grid window) area. Only do this when LOK
        is enabled.
        
        Change-Id: I97922e9d02500d7cedeaa5fa29d4ca344950ff47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161662
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-09  Mike Kaganski  <mike.kaganski@collabora.com>  [76fad8c981b36e3b2c4b0e5905b7957148ce358b]

        Simplify a bit
        
        And make sure to write newline, tab, etc. as short \n, \t, etc.
        
        Change-Id: I6a8ae36ff2856fce2f756c643c6266debe79f1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161813
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2d0bbbc2bd3a2ad1e73acc03d2183e74ca4a410]

        tdf#159046: sc_uicalc: Add unittest
        
        Change-Id: I71a8e73b32a4ec9333109e616a827bb36e3791c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161789
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-09  Michael Stahl  <michael.stahl@allotropia.de>  [bac43054e2997235ce98432bc9cb6c434120e4b2]

        tdf#105844 package: ManifestImport: handle argon2 attributes in ...
        
        ... standard namespace too.
        
        Change-Id: I46804795da2009dfd8bb95b9286933728a132e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161785
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-09  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [55e97eaabf6cce91f424e440af392143f11f3343]

        Decouple SwTextAttr from DirectPutItemInPool
        
        SwTextAttr uses a 'const SfxPoolItem*' and the
        mentioned DirectPutItemInPool/DirectRemoveItemFromPool
        to force creation of a ref-counted SfxPoolItem to
        work with. There is now tooling to do so, so changed
        to using SfxPoolItemHolder. That works like a small
        SfxItemSet - it transforms the Item to ref-count
        form and takes over management. It is safe to
        pass around, cheap to copy and it does not need manual
        cleanup of SfxPoolItems (automatic -as in SfxItemPool).
        
        Change-Id: I41401d5144c9cd59d5b10362ea17d63e35ab1eb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161799
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-09  Mike Kaganski  <mike.kaganski@collabora.com>  [24fc8b14ebe29c086292dc22ec332e114ef4e2f5]

        Fix build
        
        ... after commit b3c93b16d62e809500005edc749af4b8ad10162c (tdf#123870
        sc: fix tagged content for accessible PDF export, 2024-01-08).
        
        Change-Id: I30441da8a96ef56b224df95b5a8f04c19f72d8b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161812
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-09  Gökay Şatır  <gokaysatir@collabora.com>  [7a179efac47776df917b7e8e18f9d91973c485db]

        tdf#150716 - Partially solves the issue.
        
        This PR fixes the IgnoreAll issue. "Ignore" functionality needs another PR.
        
        Grammar checker and spell checker have different implementations. IgnoreAll functionality is implemented for spell checker but not grammar checker.
        This PR implements IgnoreAll for grammar checkers.
        
        Note: Ignore All function is valid per editing session. The ignored words is reset after the session is closed.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I7c2b77b18e0a26a6a1c5fa9e8e66075a34612884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159813
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit c0a619aa945c852652dc353dbe4c42cabbc2b779)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161699
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-09  Szymon Kłos  <szymon.klos@collabora.com>  [cf767af8de12157155eaf525ee845b196826aeb9]

        lok: external data source list
        
        Make possible to filter allowed data sources.
        It is used for WebDAV curl, WEBSERVICE function, cell external
        references.
        
        Change-Id: Ifc82af31ff1123b5656a21e6a27624fb1616db39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160196
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161772
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-09  Miklos Vajna  <vmiklos@collabora.com>  [fb7b0b944741e4efae8d92a6e305036aff906c7a]

        cool#7492 sfx2 lok: just set language/locale on async binding update
        
        Trying to run online.git tests against commit
        51d8a2ef54751403fa707816e27ddb4e7faa8231 (cool#7492 sfx2 lok: fix bad
        view id / statusbar string on async binding update, 2024-01-08),
        unit-tiletest failed.
        
        Manually trying to replace what the
        testSimultaneousTilesRenderedJustOnce test in that suite tries to do, it
        turned out that it can happen that the bindings are updated when a
        Writer view gets its focus, which is a problem, because the above commit
        started to switch views on binding updates, leading to a loop (bindings
        are updated about every second).
        
        Fix the problem by doing less work in SfxBindings::NextJob(): it's
        enough if the timer just switches languages and not views. That still
        keeps the Calc statusbar problem fixed from the above commit, but avoids
        the problematic view switching that broke unit-tiletest.
        
        Change-Id: I22cd9b3276c3f9987a2d90ad93f6026fdf6b8448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161792
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ee3894a25c28e16f3f6b6f11e8a69d9738f1fc9f]

        Revert "Make GetpApp() the pNotifier's default value"
        
        This reverts commit 1c65d5f8d3d4665e20d4feb17037633c63e4f445.
        
        Reason for revert: not the right way to do.
        See https://gerrit.libreoffice.org/c/core/+/161313/1#message-c7716cdedebe48aee3d7b6b766bbf9c519c11c38
        
        Change-Id: I20dc16dcb0ef8535fee450e3bdb57bef857af4ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161751
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-09  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [a2ccc25ccb2e94f5990d6d413541dbcdd3a72338]

        tdf#158375: add UI option to disable active content
        
        Adds a checkbox to disable active contents and OLE Automation at
        Options - LibreOffice - Security - Security Options and Warnings
        
        Change-Id: Idfac86e31c97f186eb6b6b2a7a7236b84aedbe83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161808
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-09  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [8f4ff4c601c7480479c97b274e577cf074a9a2ef]

        tdf#158375: add expert option DisableOLEAutomation
        
        Add a disable option for OLE Automation interface that is used
        only on Windows.
        
        Change-Id: I86f212977bb604fbae6ac2603bee037b32b5036c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161035
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-09  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [5372538648dd865f36f53f2cee4490203385cd50]

        tdf#158375: add expert option DisablePythonRuntime
        
        When DisablePythonRuntime is set, anything that utilizes pyuno
        bindings won't work (e.g. python macros and extensions).
        
        Change-Id: Id42d01647eebee42b120b399470a1f944e4ba00f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160968
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-08  OmkarAcharekar  <omkaracharekar12@gmail.com>  [1ace888823443b85d4a81b94656844f1b27e2987]

        tdf#130857 Use native qt widgets - simple message dialog
        
        - Implements CreateMessageDialog method for QtInstance which would create message dialogs using native qt widgets.
        
          Example - MasterPasswordCreateDialog ( https://git.libreoffice.org/core/+/5e8c0575e877795aaca91346548cd0136fa22048/uui/source/masterpasscrtdlg.cxx#64 ).
          To trigger this :
          a) Go to "Tools" -> "Options".
          b) Select "LibreOfficeDev" -> "Security", then check "Persistently save passwords for web connections".
          c) In the master password dialog, enter two different passwords and click "OK". The message dialog appears now uses native qt widgets.
        
        - adds Env variable SAL_VCL_QT_NO_WELDED_WIDGETS which reverts to previous behavior using VCL widgets.
        
        Note: most of the methods from weld::Widget hierarchy are currently just dummy implementations for Qt case, only what's needed for simple message dialogs has been implemented in this patch.
        
        Change-Id: I522489b8befb92f0092eb248ea2b81ecfbadd737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161073
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2024-01-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3303c177dc6782200d8d239ae02e945c5ce16924]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 957b0a282df5c5d97eecd87c06d68db668ab0dc1
          - tdf#155877 UI cmds Draw Insert menu (01)
            
            + Insert menu for Draw, Snap Guide
            + fixes
            + refactoring
            
            Change-Id: I75991faabb28022a24ac89c2a8aafe964721e4f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161805
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-08  Tibor Nagy  <tibor.nagy.extern@allotropia.de>  [b3c93b16d62e809500005edc749af4b8ad10162c]

        tdf#123870 sc: fix tagged content for accessible PDF export
        
        Change-Id: Iec7ea2d5acb66d7c5f9241285cf98f83e02c2445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161581
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f0e5ccaddc4d38c0372fa5ee28ab0c616e6f0c9]

        cid#1583700 Uninitialized scalar variable
        
        and
        
        cid#1583699 Uninitialized scalar variable
        cid#1583695 Uninitialized scalar variable
        cid#1583694 Uninitialized scalar variable
        cid#1583693 Uninitialized scalar field
        cid#1583692 Uninitialized scalar variable
        cid#1583691 Uninitialized scalar variable
        
        Change-Id: I0d525d6231fe81e1cea63601bc42c3ad72808082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8c822b764b35a0116a0865e991a87c8315e005ab]

        tdf#72991 - Remember last used color depending in cui
        
        Change-Id: I4c2cd970aa5b96a8037ecab5e3ae5e5e7cbe4975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160008
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2024-01-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [076e21f4e3c47f8be5218ab683f972eef1de3e18]

        tdf#156925 Add Color Scheme selector to the Basic IDE
        
        This patch implements a color scheme selector for the Basic IDE. With this new feature the user can either:
        1) Choose to stick with "Application Colors", meaning that the colors defined in "Tools - Options - Application Colors" are applied.
        2) Use one of the available color schemes in the dialog
        
        To access the color scheme dialog, go to View - Color Scheme.
        
        A color schema was defined in the "BasicIDE.xcs" file and six color schemes were defined in "BasicIDE.xcu" to be shipped with LibreOffice.
        
        This way, it is possible to install more color schemes via extensions;
        
        Change-Id: I5d382d19f982d02ba3c0fda5d1596aed2c38f13c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155928
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c5681e8d4c8ab1570c9f67d17842321229fc18c0]

        uninitialized class members
        
        since:
        
        commit 284f2759dedbc2375abdbaab5258efda4a52b8f5
        Date:   Mon Dec 4 14:08:09 2023 +0000
        
            calc: Add option to keep edit mode on enter/tab
        
        Change-Id: I47431f9096e12fe84ad13a139fba60ddd88793d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161697
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Skyler Grey  <skyler.grey@collabora.com>  [20502992b862e5a83140b6d2b19722cdc652eeab]

        calc: Add option to keep edit mode on enter/tab
        
        This change makes it so that, rather than leaving edit mode, enter and
        tab keep editing the new cell when they have moved. This is important on
        devices with an onscreen keyboard (e.g. iPads, Android tablets,
        Convertible Laptops, etc.), particularly in Collabora Online, as exiting
        edit mode hides the onscreen keyboard.
        
        It is not desirable to enable this by default, as arrow keys cannot move
        around the document when we are in edit mode (they move within the
        cell). Therefore, this commit also adds an .uno command so that we can
        activate or deactivate the option.
        
        In LibreOfficeKit we want to make sure not to share this setting among
        different users, so we also add this option in the view shell and switch
        which one we care about based on whether Kit is active.
        
        Change-Id: I5e6c93c64af0d201a8ec045fea5546e189baca74
        Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160313
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161696
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [70c4e1f88d1df5331a1d11c0d82a3e65186a2ac1]

        Related: cool#7951 only invalidate Window if the setting really changed
        
        cut down on some of these invalidations when the setting didn't change
        and we don't need the expensive invalidation
        
        Change-Id: Id84a79636fcd7f21c7a8dbe86218b75d32b26487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Miklos Vajna  <vmiklos@collabora.com>  [b2fe01ef6154aab63c33706be2739ce2540212c2]

        svx: prefix members of SdrHelpLine
        
        See tdf#94879 for motivation.
        
        Change-Id: I340040c28aaf64ad79c0d0433686a40b38e351c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161781
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3ad0f2317492f5a11ed9786e849f18a5fa817480]

        tdf#157649 Allow omitting Alt key in Windows only
        
        Follow-up for ea1421747985bd09ad40565da8536e857b5c2e9a
        
        Change-Id: Ifdfeb8a0a9507f66af26607efc31438169452b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161786
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f2ba02eee98d04b3e473393d2647201ed2549b30]

        mold: fatal: cannot open loader_path/../Debug/firebird
        
        follow the pattern seen in builds/posix/Makefile.in and
        only set the offending LINK_DARWIN_RPATH var if
        PLATFORM is DARWIN
        
        Change-Id: I98861d2c07ab60ba92d092143b5b24de29d6c1da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [101774aa914adbfff9bd3113d6f1c5e1e4cb4320]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2689c1c56a04ab1984068767e2d21f662f59a295
          - tdf#155876 UI cmds Calc-Tools menu (57)
            
            + Tools menu for Calc
            + fixes
            + refactoring
            
            Change-Id: I4f3d309e745995bbe8ec4f3bd6f1236e25314c80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161794
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5dcd57ad3a18abb90d8edeb0e638ae7315ee4085]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80ff954f498082eba69545e47f855a64f1964773
          - tdf#155876 UI cmds Calc-Tools menu (56)
            
            + Tools menu for Calc, Form _ Share Spreadsheet
            + fixes
            + refactoring
            
            Change-Id: I62b37cf492300cd92ca069496c76a3d3b85c69a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161793
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [843395e26bbf5b5b280a9a57837edfde1de2e074]

        Update git submodules
        
        * Update translations from branch 'master'
          to b16d91c535bb0ba41ff8ce63e8f5a2af1a30a110
          - update translations for master/24-2
            
            and force-fix errors using pocheck
            
            Change-Id: I33a02cfcf6e62189a9539be638128bc3960856a7
            
2024-01-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [97b3925354ac4ba9439bcbb5e463e27ddca23507]

        Add some left margin for the comment triangle
        
        Add the same margin to the left as to the right
        
        Change-Id: Iac1865f72c495d911580c06064c4b738607bd15a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161615
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2024-01-08  Julien Nabet  <serval2412@yahoo.fr>  [4f1b9d79c0467dbc0b49eb62bf56f83392a9d33f]

        Related tdf#158945: blacklist Intel Iris XE for Skia hardware rendering
        
        Change-Id: Ia6a919192316e27e64b2bf9f43eab87671ba8936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161503
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5607ce1b12ccdfd0188477e82f5b855975315a0b]

        windows signing: also wait for/depend on extras (gallery)
        
        Otherwise, doing 'make' with --enable-windows-build-signing
        
        fails with
        
        ERROR: SignTool Error: The file is being used by another process.
        SignTool Error: An error occurred while attempting to sign: C:/cygwin64/home/buildslave/r/instdir/program/Argon2OptDll.dll
        
        make[1]: *** [C:/cygwin64/home/buildslave/source/libo-core/postprocess/CustomTarget_signing.mk:31: C:/cygwin64/home/buildslave/r/workdir/CustomTarget/postprocess/signing/signing.done] Error 1
        make: *** [Makefile:289: build] Error 2
        
        Change-Id: I9d0793f3e42577a47b92025d5670caa44fbd912e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161388
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2024-01-08  Stanislav Horacek  <stanislav.horacek@gmail.com>  [f03a885de40a576a96d90663dd27bc93f89585c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 911d18a2aa26aa788bbb3f70e4886cea6f652e3d
          - remove not used SelectColumns.xhp
            
            it was probably created by mistake
            there is EntireColumn.xhp file instead
            
            Change-Id: Ic0c9c74789a96ec7adb2158af431bcf1b03c7c96
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161747
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-08  László Németh  <nemeth@numbertext.org>  [14c0f2cd140da66d38a8282332f2cb734bb74e39]

        tdf#159026 sw: fix Undo crash with tracked floating table deletion
        
        In Hide Changes mode, tracked deletion of a floating table,
        and after that, its frame resulted a crash during Undos.
        
        Regression from commit 0c6221e1545e7b96d9df23cdc24302c28ae935b8
        "tdf#148227 sw: fix Undo of tracked row deletion in Hide Changes mode".
        
        Change-Id: I3fd88a30df2739ce8a3cdc24da07684a3ac5a41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161777
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6342aa6c665012f51a5c11f0293d5d3ff3a573ee]

        cid#1545370 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545364 COPY_INSTEAD_OF_MOVE
        cid#1545363 COPY_INSTEAD_OF_MOVE
        cid#1545344 COPY_INSTEAD_OF_MOVE
        cid#1545299 COPY_INSTEAD_OF_MOVE
        cid#1545287 COPY_INSTEAD_OF_MOVE
        cid#1545267 COPY_INSTEAD_OF_MOVE
        cid#1545256 COPY_INSTEAD_OF_MOVE
        cid#1545226 COPY_INSTEAD_OF_MOVE
        cid#1545500 COPY_INSTEAD_OF_MOVE
        cid#1545538 COPY_INSTEAD_OF_MOVE
        cid#1545618 COPY_INSTEAD_OF_MOVE
        cid#1545681 COPY_INSTEAD_OF_MOVE
        cid#1545750 COPY_INSTEAD_OF_MOVE
        cid#1545778 COPY_INSTEAD_OF_MOVE
        cid#1545785 COPY_INSTEAD_OF_MOVE
        cid#1545799 COPY_INSTEAD_OF_MOVE
        cid#1545847 COPY_INSTEAD_OF_MOVE
        cid#1545958 COPY_INSTEAD_OF_MOVE
        cid#1545963 COPY_INSTEAD_OF_MOVE
        cid#1545990 COPY_INSTEAD_OF_MOVE
        cid#1546013 COPY_INSTEAD_OF_MOVE
        cid#1546029 COPY_INSTEAD_OF_MOVE
        cid#1546079 COPY_INSTEAD_OF_MOVE
        cid#1546104 COPY_INSTEAD_OF_MOVE
        cid#1546127 COPY_INSTEAD_OF_MOVE
        cid#1546133 COPY_INSTEAD_OF_MOVE
        cid#1546155 COPY_INSTEAD_OF_MOVE
        cid#1546190 COPY_INSTEAD_OF_MOVE
        cid#1546216 COPY_INSTEAD_OF_MOVE
        cid#1546273 COPY_INSTEAD_OF_MOVE
        cid#1546315 COPY_INSTEAD_OF_MOVE
        cid#1546326 COPY_INSTEAD_OF_MOVE
        cid#1546387 COPY_INSTEAD_OF_MOVE
        
        accept some reasonable suggestions
        
        Change-Id: I7b004086d490c7618d8fe7a21a53cfa8ac1f8408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [7413b4ad50b38cf9839fc3e3d4d0bec6ada90a6a]

        Simplify JsonWriter a bit
        
        Change-Id: Ifa4278cfd62df4179dd3ae627369c077e31dbd00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161780
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [60150ef4b8fc1d0a30f20c3d9ed6ba0725da16a5]

        cid#1560054 use RVO
        
        Change-Id: I04644c9ca78930d42289368b9a596f44a14b7012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-08  Julien Nabet  <serval2412@yahoo.fr>  [08c4ed96cc94df4a3859aa167e92e6f6da9c2ce7]

        Revert "Related tdf#76007: Make it possible to insert a Table in a Footnote or Endnote"
        
        This reverts commit 75680dd751062b7ca34ff91e03de3add3fc973c6.
        
        I won't be able to debug layout problems indicated by Miklos.
        
        Change-Id: Ie610949a229468ba00d04b3542e14bdb68d7e1dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161752
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-08  Miklos Vajna  <vmiklos@collabora.com>  [51d8a2ef54751403fa707816e27ddb4e7faa8231]

        cool#7492 sfx2 lok: fix bad view id / statusbar string on async binding update
        
        With two Calc views (first is an English one, second is a German one),
        type in the English view and in parallel to that, create a cell
        selection in the German view. Sometimes the status bar update about the
        selected cells arrives in English, in the German view.
        
        The root of the problem is that SfxBindings has a timer that does the
        expensive update of all the UNO commands only after a delay, but by the
        time this timer runs, possibly the current view is no longer the German
        one, which leads to English strings in the German view.
        
        Fix the problem somewhat similar to what commit
        ee7ca8e4ea8ed93655f99e77a9e77032ac830c46 (cool#7865 sfx2 lok: fix bad
        view id on async command dispatch, 2023-12-20) did in
        SfxHintPoster::DoEvent_Impl() by restoring the original view for the
        duration of the timer job execution.
        
        The test works even in case '--with-lang=en-US de' is not used, because
        it asserts the locale, which is not downgraded to English when
        translations are not available. This required turning the payload of the
        .uno:RowColSelCount status update into JSON, which is meant to be mostly
        backwards-compatible, given that we already have a mix of plain text and
        JSON for the various UNO commands. Another trouble is that the
        SfxBindings lazy update is a timer, so processing idles won't help and
        sleeping in test code is not ideal, either. Solve that by exposing the
        timer of SfxBindings, so test code can explicitly invoke the timer
        without waiting.
        
        Change-Id: Iacf17f81c28b95ce41a0ee29ad25eb576db0d62a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161691
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-08  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e83c7ec2f4d801365235bf56d7cc8cf31ef4a00e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8ebc9e3984754dd292a79c028727d6db4501e55
          - fix row/column mistakes
            
            Change-Id: I180183a27e3fb2ea060ed7ea08bfaea5874941ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161725
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-08  László Németh  <nemeth@numbertext.org>  [7a1470fd97d52c5196a0800dd64f4c8899909c4b]

        tdf#159034 sw smart justify: fix position of shading
        
        E.g. shading of soft hyphens didn't follow space shrinking.
        
        Follow-up to commit 20cbe88ce5610fd8ee302e5780a4c0821ddb3db4
        "tdf#119908 tdf#158419 sw smart justify: fix cursor position".
        
        Change-Id: Icdce4736d9c76ff1fbe9dd140b9f1c091e605452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161654
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-07  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d8539889c288bcb6cb392345fff6d4f140c5d8be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ad868517906b24dfbe86df1be2286352778c3d2
          - fix various typos
            
            Change-Id: I5acec9d7e452742efa816a31d578f12fc6f748f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161770
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2024-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6998eacf542e6d6d9ec587aff3a38c3644e83c7f]

        firebird: set -mmacosx-version-min to 10.15
        
        Building on macOS Sonoma fails when this flag is set to 10.9 or
        is unset. But setting this flag to 10.15 which matches the lowest
        -mmacosx-version-min that LibreOffice builds with on Mac Intel
        avoids all of the new deprecation warnings that turn into errors
        that started with Xcode 14.
        
        Also, fix runtime failure, at least on macOS, when the firebird
        build runs the isql command by adding $(firebird_BUILDDIR)/lib to
        LIBO_TUNNEL_LIBRARY_PATH.
        
        Change-Id: Id77d2949f56ecc63dfb085f762acf2c1cc081060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161727
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f8b9b5454d34f87e5402d5799cf1fb02ab31294d]

        restore label placeholders for color selecting GtkMenuButtons
        
        since:
        
        commit 98b1eb2523a1bb5d1fd15fc06be7ec7a16f1eeab
        Date:   Fri Dec 8 18:13:47 2023 +0100
        
            Resave with newer Glade version
        
        Change-Id: I5d4cff32a4d3e34fecf920d9fb35819696dde0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161739
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3d8ab97760049c64b7bbadde1a0b89ef9acde690]

        Resolves: tdf#159046 hang on export of math objects in cells
        
        regression from:
        
        commit a9d6b6ef049dd41c91a30c03df0ba38ba8dcada8
        Date:   Thu Oct 5 14:12:51 2023 +0100
        
            crash copying text + chart to clipboard with InputOptions::TextWysiwyg
        
            of true, the mxPoolHelper is still null when trying to create a
            Printer to use as a reference device
        
        revert that, and use a different simpler workaround for the original
        crash case.
        
        Change-Id: I74cec710aec033e1652e637ed056dae1c261aa98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-07  alisafaya  <alisafaya@gmail.com>  [ad467b9199885f43a27a311e04b557a3d69f9e9a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to a71f3c381379cffaddb0f4fed4ae8a6be3ff0566
          - update hunspell dictionaries for Turkish language
            
            This dictionary is more accurate and efficient than the current dictionary. It was benchmarked and compared to existing hunspell Turkish dictionaries. Please see: https://github.com/tdd-ai/hunspell-tr
            
            Edit: Updated the dictionary to include proper names.
            
            Change-Id: Ie23273274bc60ce6ac53a12ff92ad529bd0339a7
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118649
            Reviewed-by: Muhammet Kara <kara@libreoffice.org>
            Tested-by: Muhammet Kara <kara@libreoffice.org>
            
2024-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [3637c22b8217f2c059c32996bb5549e96eaf66e5]

        Drop SvtFilterOptions and use officecfg instead
        
        Change-Id: I6aa9a21d1422b8b3b6fe5dde9869dffa88be5535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161744
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-07  Andras Timar  <andras.timar@collabora.com>  [b7cba4953a072c88813ecd1886cd0fdaa5790de7]

        LOK: disallow entering multiple hyperlinks in spreadsheet cells
        
        This is for UX consistency. Previously it was allowed to enter
        multiple hyperlinks in spreadsheet cells when the spreadsheet
        was in OpenDocument format. Only in case of XLS/XLSX it was
        not possible. But we got a feedback that it is desirable to have
        a similar user experience for all spreadsheet file formats in
        Online. In LibreOffice nothing changes, it works according to the
        setting in Options - LibreOffice Calc - Compatibility - Hyperlinks.
        
        Change-Id: I7eece4307289711e9c925c05085497afaafe600e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161667
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161729
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2024-01-07  Andras Timar  <andras.timar@collabora.com>  [96131f0e80f23ceeafab39508cafb68f33b8e58d]

        context="stock" is not good for non-stock translatable strings
        
        Change-Id: Ieccef2b6b5604011d6eb72a168a5381ccdd7de99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161658
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161728
        Tested-by: Jenkins

2024-01-07  Shachar Shemesh  <shachar@shemesh.biz>  [ae594f266279cdd937bcf0fac76220e1d026b1b3]

        headerfootercontent.ui: resave with Glade 3.40
        
        Change-Id: Ia017ee8104eab04894daef46a4ec5c21794fc40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161707
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [4eeb6178fb9fb499bc417a42f8d6d0bdde9acb8e]

        tdf#159018: make 64-bit hash algorithm similar to 32-bit one
        
        The magic of choosing a substitution font depends on the order of
        fontfaces returned from PhysicalFontCollection::GetFontFaceCollection
        (called from WinGlyphFallbackSubstititution::FindFontSubstitute).
        Since commit db04b3e154a1fb8f222232ef969bb3617e051329 (return 64-bit
        hash for O[U]String, 2022-08-22), the order has changed, which
        resulted in different fallbacks in some documents (which aren't
        well-formed in respect to their formatting, so when they work,
        it's just luck).
        
        The difference was because the 64-bit hash implementation was
        modelled after Java one. This patch makes the code follow the
        algorithm in rtl::str::hashCode_WithLength, used in 32-bit hash,
        which restores the order (at least for my system). Not reliable,
        just "why not".
        
        Change-Id: I3c482e86bee79d6c9c6981300518c4ff6b7f29d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161706
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a46db49e301e71d78b356c57adfae6e79d3c38b5]

        ofz#65567 unset DiagramFontHeights on exception
        
        git diff -w is your friend
        
        Change-Id: I360ebb70e710a5d435ce8153090593784e2ac603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-07  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [4fe9fab476c5e7d4e56696e237e1b4034989c156]

        tdf#158863 Remove obsolete readme.txt file from Growing Liberty template
        
        Change-Id: If74ac04d0401d7d40e436153bdb3be8dc1f350c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161735
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-07  Julien Nabet  <serval2412@yahoo.fr>  [75680dd751062b7ca34ff91e03de3add3fc973c6]

        Related tdf#76007: Make it possible to insert a Table in a Footnote or Endnote
        
        There's still layout refresh pb.
        
        Change-Id: I613cbf77a32452fdc42501e2eaf8450b7dedf327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161085
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-07  Julien Nabet  <serval2412@yahoo.fr>  [39bad5d9f695972dbccd66d971c1d5df4cfe9a99]

        tdf#150490: ReportBuilder: Wizards starts showing two different data sources
        
        Change-Id: Ic9287228b8f001ccfe8dc7db1bafa4b9e35e6ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161464
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-07  Julien Nabet  <serval2412@yahoo.fr>  [dca19993a4c78ba7f7d61b254763909c0e5831b9]

        tdf#159042: crash after changing cell style (if direct formatting done)
        
        bt part:
        1  0x00007f1fdd439356 in rtl::OUString::operator std::basic_string_view<char16_t, std::char_traits<char16_t> >() const (this=0x0) at include/rtl/ustring.hxx:3333
        2  0x00007f1fddaf1927 in CellAttributeHelper::CellStyleCreated(ScDocument&, std::basic_string_view<char16_t, std::char_traits<char16_t> >) (this=0x55edd85576a0, rDoc=..., rName=u"Default")
           at /home/julien/lo/libreoffice/sc/source/core/data/patattr.cxx:193
        3  0x00007f1fdeed225b in ScTabViewShell::ExecStyle(SfxRequest&) (this=0x55edd8674190, rReq=...) at /home/julien/lo/libreoffice/sc/source/ui/view/tabvwsha.cxx:1601
        
        full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=191786
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=2e1f9da8a6359c8909e087a92239aefd4851b116
        Decouple ScPatternAttr from SfxItemPool
        
        Change-Id: I8c996326abe870c6ce71e9d130e73fb3b025bf71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161710
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [46754ac19f9e24703c9ace73dbf639115016be81]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a7d48c91ea63b5333875f3d3dbf378317b060211
          - tdf#155876 UI cmds Calc-Tools menu (55)
            
            + Tools menu for Calc, Scenarios
            + fixes
            + refactoring
            
            Change-Id: I1fb8b69810de5b9a9fb7e403279ffd4ffce9a3f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161734
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d2f5acb798964ee14a009c0dc7dd6556b8c5944f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 99ae655bc9bddc3d13444213ecf01ac0a2902b32
          - tdf#155876 UI cmds Calc-Tools menu (54)
            
            + Tools menu for Calc, Detective
            + fixes
            + refactoring
            
            Change-Id: I917cebbf6a5747b3b0aa09500045ba6bda7f41fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161733
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [257926de7b617b5070a3723bf198db5ad7345c3c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23ad83d4896c48c351d50ec7daaffff85b801c55
          - Allow help-id-missing to be clipboarded
            
            Change-Id: I32b6e24d9d1d1f281449d49bfc5a707801e4d016
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161732
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a98994c026dcd8ba197beb296ad8ff7d1ce39e75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3f698f85e18a09f6944f1f4083498496a1a8ba5
          - tdf#155876 UI cmds Calc-Tools menu (53)
            
            + Tools menu for Calc, Solver
            + fixes
            + refactoring
            
            Change-Id: I9f3ff23ffed4c688e9fc029147cdaf1fa1bda698
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161731
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [591926ac497a818ab64805ba2350eefb8d1dbb79]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ee835f1bb058f3cf991a5f6c599be71eeeafadf7
          - tdf#155876 UI cmds Calc-Tools menu (52)
            
            + Tools menu for Calc, goal seek
            + fixes
            + refactoring
            
            Change-Id: If76e6382e584866fae0420631f5af0d3b63a0bcf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161715
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8e48ea3eef8d982156061eb4a9fde8ff95fc74f1]

        tdf#159041 Fix dup entry in Statistics bar
        
        + in notebook bar
        + in compact notebook bar
        
        Change-Id: Ifc07df5008c0a6698ca77cf453e569d4f618de47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161700
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2a6ca136a151d23e0b651b308549dfe98188b160]

        cid#1560051 Missing move assignment operator
        
        Change-Id: Ie59d391cd68f9d90fd8ac99a81ba8b997221165a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161716
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  codewithvk  <vivek.javiya@collabora.com>  [23e4c6bbe2a946268b443f434a49a90c5a9f8ff5]

        jsdialog: enable calc formula error dialog
        
        Signed-off-by: codewithvk <vivek.javiya@collabora.com>
        Change-Id: Ib4d1b3d4d869b5be194c90e50c60cc89d8257b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161592
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 56ae4e455d6a8ac2116700c7b8913d64c665f362)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36a1484f72e4da7211349d20f9b3c78e311df9f6]

        cid#1546421 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifab2f2f5ec8c7f41cd705e0fb07d1273a34b879d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8b20ca2fe7054e699cf0ff48889e54cee4dd4fd]

        cid#1545475 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545626 COPY_INSTEAD_OF_MOVE
        cid#1546203 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I98a6c36e77fe633d50fdb1a0f063b2656f852a2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161718
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3871cca6122701135b42dc8687364835ed14fdf5]

        cid#1545576 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I085cc6802ba72c2334398dd34be9eecdab2ea575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f7327527d423f0ceb43520c9daab4d0682d48748]

        cid#1560053 Missing move assignment operator
        
        and
        
        cid#1560054 Missing move assignment operator
        
        Change-Id: I438699b24ca7aa7726dbce3af310d80327b9a717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0b888c78549f99987a31af33321f7618f771fe27]

        fix build
        
        since:
        
        commit df1e72b853d2ec8c565c8cdf35087824e6a98f40
        Date:   Mon Jan 1 02:15:52 2024 +0100
        
            Use officecfg instead of SvtFilterOptions wrapper in sc
        
        Change-Id: I8b90389e60b3bebf6f88bca2784188fea3682e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161711
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-06  Matt K  <mattkse@gmail.com>  [0ba4e0483bacd698a227d0d18422fc6a08055c28]

        tdf#73678 Prevent conditional formatting from being lost in Calc
        
        The problem is that when a Calc tab sheet is moved from one position
        to another, the ScConditionEntry aSrcPos member variable isn't updated,
        and therefore when deleting a blank sheet in front of a data sheet the
        deletion still thinks it's looking at the correct sheet but it is now
        out-of-date and as such the conditional formatting references are
        invalidated such that all math operations are tested against 0.0 instead
        of the actual formula value for the condtional formatting, which has
        the side effect of updating cells colors that should be uncolored as
        per the conditional formats set on them.  The fix is to update this
        aSrcPos member variable of ScConditionEntry via the call to
        ScTokenArray::AdjustReferenceOnMovedTab from
        ScConditionEntry::UpdateMoveTab, which is called on tab sheet move.
        This way, the aSrcPos variable is up to date when
        ScConditionEntry::UpdateDeleteTab is called, which is called on tab
        sheet delete.
        
        Change-Id: I3bbc8111bb1685d6f7f307a15c852c6657f37b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160234
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [06eeb2fb3d4ec3778db5c9c342d2d17aea456577]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9054c070a7f7bb7c849c479bb693e750fe07b659
          - tdf#155876 UI cmds Calc-Tools menu (51)
            
            + Tools menu for Calc, Auto input, redact
            + fixes
            + refactoring
            
            Change-Id: I81a60bbff5996ae044797a8c4dde76265c10de4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161714
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0136fc130d32098724ca6d46aee221434eb480ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 46c9d68331df731a5318622ff1f1e15b54bbc8ca
          - tdf#155876 UI cmds Calc-Tools menu (50)
            
            + Tools menu for Calc, spelling commands
            + fixes
            + refactoring
            
            Change-Id: I7ad27f48ac6e989b5091d3132f7bec911d2b0507
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161713
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [00eae23267bf64e07cf057f828cd85f3c38ac669]

        tdf#134526 Firebird: upgrade to release 3.0.11
        
        - Removed unneeded patches [1][2][3][4].
        - No changes of ODS version.
        - Added patch to revert upstream commits to avoid CppunitTest_dbaccess_firebird_test,
          CppunitTest_dbaccess_hsql_binary_import, CppunitTest_dbaccess_tdf119625
          and CppunitTest_dbaccess_tdf126268 failing when building on Windows.
        
        [1] "extern/cloop: Missing dependencies of compilations on output directories"
        <https://github.com/FirebirdSQL/firebird/pull/6948>
        [2] "Fix checks for null HANDLE in Windows-only code"
        <https://github.com/FirebirdSQL/firebird/pull/301>
        [3] "Fix warning on Win64 build"
        <https://github.com/FirebirdSQL/firebird/pull/231>
        [4] "Mac sandbox" <https://github.com/FirebirdSQL/firebird/pull/308>
        
        Change-Id: I17aa4938e41bfc070317fbb92ccea10f2db4d24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152016
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2024-01-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [25276df12abd9d002f7f899900434617b256f745]

        tdf#158743: sd_png_export: Add unittest
        
        Change-Id: I598960d8cc7d394581def20de3ab64a8ff6c7789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161694
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2024-01-05  Hossein  <hossein@libreoffice.org>  [1ec3ef4db8c4c03d89a3d86c0e633effde04efda]

        Update comment to match function parameters
        
        One parameter of SfxStyleSheetBasePool::Make function was changed in
        0035573ee7798cdf54ef44a54306a0515eeb90a7, but that change was not
        reflected in the comment. It is now updated.
        
        Change-Id: I89f7c1a6e0424d11acddf1f94d3af370af691b36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161611
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e93d25ab979ba824f5ee1d22e1d2f43c74afb99f]

        report what font is missing when terminating test
        
        even in release mode
        
        Change-Id: I3e9673cc498202c64ba00f5cd2cd0e7429d77834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [88e871125cdc1c5b45529eb37a76201748a16a36]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77b44d5655ac785543535fbd05d422316ff68d0a
          - tdf#155876 UI cmds Calc-Sheet menu (49)
            
            + Data menu for Calc, Statistics commands
            + fixes
            + refactoring
            
            Change-Id: I7ef7700412232bc6265c537c94207f42c498e639
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161690
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-05  Gabor Kelemen  <kelemeng@ubuntu.com>  [df1e72b853d2ec8c565c8cdf35087824e6a98f40]

        Use officecfg instead of SvtFilterOptions wrapper in sc
        
        Change-Id: I8f8ff35452147fe83a772d87eb94e86b8877cac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161590
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-05  Gabor Kelemen  <kelemeng@ubuntu.com>  [e6f77135b4cbb88e60c3a8ab40b9e416bef0f835]

        Use officecfg instead of SvtFilterOptions wrapper in sfx2, sd, oox
        
        Change-Id: I1a404fe156c9c7859c1eb19d4dff9892f4598bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161591
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-05  Henry Castro  <hcastro@collabora.com>  [fbbad70b9437aa2e96f004c530f2d552715cf810]

        tdf#127856: fix cell selection language
        
        Clicking the language in the popup Calc's status bar,
        it will change the cell range selection language property.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I1cc218da44eff0a4d3acee7b089e54aaad474379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161371
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [feb110d8e9289256ff8c4882892b4c48343719d3]

        Fix `make create-update-info` also for non-Windows
        
        Change-Id: I83a44d0cb563b1caf9459dddec7c6409af6ac0f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7a63830a47ce8e74b30a2a2d2e776025397ce390]

        external/lxml: Silence -Wincompatible-function-pointer-types
        
        ...with Clang since
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error",
        causing
        
        > src/lxml/etree.c:113121:38: error: incompatible function pointer types assigning to 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') from 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  113121 |   __pyx_v_self->_c_ctxt->sax->serror = __pyx_f_4lxml_5etree__receiveParserError;
        >         |                                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > src/lxml/etree.c:117609:25: error: incompatible function pointer types assigning to 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') from 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  117609 |     __pyx_v_sax->serror = __pyx_f_4lxml_5etree__receiveParserError;
        >         |                         ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > src/lxml/etree.c:181693:28: error: incompatible function pointer types assigning to 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') from 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  181693 |   __pyx_v_xpathCtxt->error = __pyx_f_4lxml_5etree__receiveXPathError;
        >         |                            ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > src/lxml/etree.c:218967:60: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  218967 |   xmlRelaxNGSetParserStructuredErrors(__pyx_v_parser_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_self->__pyx_base._error_log));
        >         |                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/relaxng.h:156:30: note: passing argument to parameter 'serror' here
        >   156 |                                          xmlStructuredErrorFunc serror,
        >       |                                                                 ^
        > src/lxml/etree.c:219385:60: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  219385 |     xmlRelaxNGSetValidStructuredErrors(__pyx_v_valid_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_self->__pyx_base._error_log));
        >         |                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/relaxng.h:185:31: note: passing argument to parameter 'serror' here
        >   185 |                                           xmlStructuredErrorFunc serror, void *ctx);
        >       |                                                                  ^
        > src/lxml/etree.c:220274:59: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  220274 |   xmlSchemaSetParserStructuredErrors(__pyx_v_parser_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_self->__pyx_base._error_log));
        >         |                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/xmlschemas.h:156:30: note: passing argument to parameter 'serror' here
        >   156 |                                          xmlStructuredErrorFunc serror,
        >       |                                                                 ^
        > src/lxml/etree.c:220817:59: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  220817 |     xmlSchemaSetValidStructuredErrors(__pyx_v_valid_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_self->__pyx_base._error_log));
        >         |                                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/xmlschemas.h:185:30: note: passing argument to parameter 'serror' here
        >   185 |                                          xmlStructuredErrorFunc serror,
        >       |                                                                 ^
        > src/lxml/etree.c:221582:66: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  221582 |     xmlSchemaSetValidStructuredErrors(__pyx_v_self->_valid_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_error_log));
        >         |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/xmlschemas.h:185:30: note: passing argument to parameter 'serror' here
        >   185 |                                          xmlStructuredErrorFunc serror,
        >       |                                                                 ^
        > src/lxml/etree.c:222759:63: error: incompatible function pointer types passing 'void (void *, xmlError *)' (aka 'void (void *, struct _xmlError *)') to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)') [-Wincompatible-function-pointer-types]
        >  222759 |     xmlSchematronSetValidStructuredErrors(__pyx_v_valid_ctxt, __pyx_f_4lxml_5etree__receiveError, ((void *)__pyx_v_self->__pyx_base._error_log));
        >         |                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/schematron.h:106:31: note: passing argument to parameter 'serror' here
        >   106 |                                           xmlStructuredErrorFunc serror,
        >       |                                                                  ^
        
        Change-Id: I98d1861acfe364d8f83aaca26100dc2c9729ec33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161669
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1bcb7d4bdaecaf37353e37fe09373189e62d69dd]

        Resolves: tdf#158997 optimal col width too narrow to render text
        
        optimal is measured with kerning on, while text is rendered with
        kerning off
        
        possibly a problem since:
        
        commit 36eed54d3dfed6551fd2ad944feff7e217c56e82
        Date:   Tue Jul 3 15:00:26 2018 +0200
        
            Resolves: tdf#118221 whole cell kerning default is off
        
        Change-Id: I0e6de75a89823f6ed58a74782e47feb0a44014e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161666
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Justin Luth  <jluth@mail.com>  [788eb8e7b37373bd5d2c078a2a833c4357165178]

        fix build: Revert "tdf#111969 sw: acknowledge that last half-char
        
        ..acter for mouse pointer"
        
        This reverts commit a7649b85f1e16dd52378346958216e78b8335b5a.
        I forgot to rebase this after a the Christmas break.
        
        Change-Id: I78781808d15b81496b1572fb3bf304751ae279a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161668
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0c0b4f0ce5028c2b23d83c073bd2999ac608ae40]

        Introduce external/onlineupdate/monitor-sources.sh
        
        ...to: "Monitor any changes in upstream git repo $1 between revisions $2 and $3
        that affect files that we copy with our
        external/onlineupdate/generate-sources.sh"
        
        (and while at it add license boilerplate and a descriptive comment to
        external/onlineupdate/generate-sources.sh)
        
        Change-Id: I2872d04c2db9d3a7226a9e744d84367ae7aa8672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161665
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bd2204b1ea521a62699242d94ca5ad12fbc14bf5]

        Workaround for --disable-windows-build-signing --enable-dbgutil test builds
        
        Change-Id: I8c14cfafd39b8575a5e1e236f965283718777416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Darshan11  <darshan.upadhyay@collabora.com>  [4030a0439142122227ee19487bcdd4389d0e184d]

        Send checkboxtype property to online for webtreeview widget
        
        - webtreeview widget does not have any property that define that element is a checkbox or radio button
        - added `checboxtype` property
        - will help to identify the element type (radio/checbox)
        Change-Id: Ic8aa0c3eeb6373566f3507ebf01cee3427a57704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161043
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Justin Luth  <jluth@mail.com>  [a7649b85f1e16dd52378346958216e78b8335b5a]

        tdf#111969 sw: acknowledge that last half-character for mouse pointer
        
        This fixes WHEN the helpful mouse cursor changes to a finger
        when over top of a smart-tag.
        
        The impact is MUCH LARGER than just smart tags,
        but they were the impetus for the change.
        
        Prior to this patch, it would start half-a-character too soon,
        and end half-a-character too early.
        
        Change-Id: I84b1e91ccfac2aa18ec58ddfdea25cd199fc694a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161041
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4a3c1f0741ce60d218a80348ba95438e26d3423b]

        Also copy updater.ini (so that updater progress UI will actually shown up)
        
        Change-Id: I2805087da196aa7153850345803999af4de313df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161660
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Justin Luth  <jluth@mail.com>  [062b4bee5eb06483cef3dde3f28a5d12599840d3]

        tdf#111969 sw: acknowledge that last half-character for popup/pointer
        
        This fixes WHEN the helpful pop-up notifies about the cursor
        being over top of a smart-tag, and suggesting that the user
        can CTRL-clicking to activate the smart tag.
        
        Prior to this patch, it would start half-a-character too soon,
        and end half-a-character too early.
        
        It similarly fixes WHEN the helpful cursor pointer changes into a finger
        when holding ctrl and moving into the start or end of the smarttag.
        
        Smart tags REQUIRE a plugin, so a unit test is out of the question.
        
        The impact could be MUCH LARGER than just smart tags,
        but they were the impetus for the change,
        because smart tags are not portions while the other
        things (redlines, fields, refs/footnotes, formulas) are.
        
        The net effect on other IsAttrAtPos SHOULD be nothing,
        so that still doesn't leave me with anything unit testable.
        
        If I ONLY removed the --index from itrcrsr,
        then unit tests in  uiwriter9 fail.
        Adding aTmpState.m_bPosMatchesBounds = true
        (which is the fix for smart tags) makes it not fail.
        
        Adding bPosMatchesBounds OUGHT to obsolete an initial-import --index hack?
        While I don't NEED to remove the (what looks to me) hack
        (and it actually is super dangerous to remove it)
        I really think it is obsolete and thus deserves removal.
        Easy to restore if it proves a regression...
        
        So bFieldInfo and bPosMatchesBounds end up doing much of the same thing.
        This is one of only two places which sets m_bFieldInfo = true,
        the other being a EnhancedPDFExportHelper.cxx which tests pEnd inclusively.
            cms.m_bFieldInfo = true;
            auto const [pStart, pEnd] = rShell.GetCursor_()->StartEnd();
            if (rShell.GetLayout()->GetModelPositionForViewPoint(&pos, center, &cms)
                && *pStart <= pos && pos <= *pEnd)
        make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf157816
        is not a good test for this - it passes without --index and !FieldInfo
        
        Change-Id: I77df5e054879eb3bbc82907962b77386811bceac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161034
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [28bad382face10be75af3875e44dde89fbc78108]

        Fix `make create-update-info` (for Windows, at least)
        
        * The shell scripts that had once been copied from Mozilla to bin/update/*.sh
          are now included in
          onlineupdate-c003be8b9727672e7d30972983b375f4c200233f-2.tar.xz (which is still
          generated from the same
          <https://github.com/mozilla/gecko-dev/commit/c003be8b9727672e7d30972983b375f4c200233f>
          that was used for the original tarball in
          3a445cb49795fabe0d8caaf12bfc38eb9e12d5fc "Turn onlineupdate into
          external/onlineupdate").
        
        * The additional modifications in external/onlineupdate/lo.patch are:
        
        ** Allowing to pass the list of files into the mar tool via -f instead of on the
           command line, to avoid "command line too long" errors on Windows, inspired by
           the modifications once made directly in our old downstream sources with
           4165dd4e465a86ba6abe9afb3abfda5ef72493ea "add a way to create mar file from
           file", 8e4d49340bd235a7db8fde1d24dd1d63ddc4d571 "use the new file based
           approach for the mar creation", and fb13ed6955cd66017e5348b915af371a184ea633
           "add the manifest file to the mar file".  (To keep things simple for now, it
           still uses a hard-coded maximum of 10000 lines in the file, marked with a
           TODO.)
        
        ** Not failing when "precomplete file is missing!"  (There is a comment
        
            // Applications aren't required to have a precomplete manifest. The mar
            // generation scripts enforce the presence of a precomplete manifest.
        
            in
            workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/updater/updater.cpp
            and it appears to be OK that we don't have such a  precomplete manifest file
            and just skip that test.)
        
        * In the Makefile.gbuild create-update-info, the create_full_mar.py script needs
          to be called with a Unix pathname on Windows, or else the
        
          #!/usr/bin/env python3
        
          shebang in that script would get confused.
        
        * The related Makefile.gbuild targets upload-update-info and create-partial-info
          have not been addressed yet.
        
        Change-Id: Iab4e083ddbe99e07d846e202f20c6031e2983e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161656
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-05  Weblate  <noreply@documentfoundation.org>  [3a561a29cfae0b6dbdf56eed3a730bdd85fe049b]

        android-viewer translated using Weblate
        
        Spanish currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ic665ce7eb865fc0755c9b295229f5dca8ed83ae3
        
        android-viewer translated using Weblate
        
        Portuguese currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I4112a3377775ac15c56464fd121d081d31bb6865
        
        Added translation for android-viewer using Weblate (Portuguese)
        
        Change-Id: Ifab7260e34b78fcbc9344d79807aa551416b4db2
        
        android-viewer translated using Weblate
        
        Hungarian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ia4cb99b091c1035ccd1952e0bfb164e986381418
        
        android-viewer translated using Weblate
        
        Italian currently translated at 94.0% (111 of 118 strings)
        
        Change-Id: I1c1d672a34b8684b5cb17215d0575a91c2c067a6
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Gábor Kelemen <gabor.kelemen.extern@allotropia.de>
        Co-authored-by: Sérgio Marques <smarquespt@gmail.com>
        Co-authored-by: Valter Mura <valtermura@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Weblate <noreply@weblate.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/es/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hu/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161457
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-05  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [43ec43154c05aa19d7ec5b631634b9a843689c9e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 27088ec11fbefefff49820050a411d5d21e32c6d
          - tdf#158961 Remove a z-index: 100 rule to keep Safari happy
            
            Modules navigation was not showing up in Safari because it had too
            few elements to overflow. For some reason the z-index: 100 rule for
            the containing div triggered this buggy behaviour.
            
            Change-Id: I50776401b567d125d086e826ec7a23694bdf6774
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161651
            Tested-by: Jenkins
            Reviewed-by: Juan José González <juanjosegzl@libreoffice.org>
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2024-01-05  Miklos Vajna  <vmiklos@collabora.com>  [1bde4e6ff4bfcc922c7117d9d0528ce0c7f1adc5]

        sw: simplify RES_TXTATR_INETFMT handling in SwTextAttr::dumpAsXml()
        
        RES_TXTATR_INETFMT will result in a call to GetINetFormat().dumpAsXml()
        later and that contains all the info (symbol name, URL) in a repeated
        form. And if more info is needed, an SwFormatINetFormat::dumpAsXml() can
        be introduced.
        
        Change-Id: I42f941fab79f96927ba6e82fe8bfa6616b67c6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161653
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-05  Justin Luth  <justin_luth@sil.org>  [1f6d845e10737d6ad1fec1c0ff660baae0ce3f3c]

        tdf#139636 thumbnail: don't regenerate on file close
        
        Back in 2001, this might have been the primary time
        when the thumbnail was generated. Now it is also generated
        on file open and file-save. This bug report is at least
        one example why regenerating on exit is not desireable.
        
        But are there examples of why a thumbnail IS needed on file exit?
        
        One way the thumbnail can change is viewing track changes,
        since toggling track changes doesn't "modify" the document.
        
        What other things can affect the document layout
        without be considered a modification?
        
        Change-Id: Ic08fefadb7a2ff594dc2788dfc9cf9e0cc528a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126649
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6875c975f80d8b813b1829a530162869a1e2d92e]

        upgrade libxml2, libxslt & liblangtag
        
        what I'm really after is some vexating not-reproducible oss-fuzz msan
        warnings when using libxml2 in the fodt2pdf fuzzer. So lets upgrade
        libxml2 to the latest, which requires bumping libxslt, and then requires
        a newer liblangtag because of no longer implicit includes that it
        depended on.
        
        xmlKeepBlanksDefaultValue and xmlSubstituteEntitiesDefault are
        deprecated, we should get around to updating those uses
        
        Change-Id: I8fda0dffda0a7ea65407d246a3121875cb8ad4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Michael Stahl  <michael.stahl@allotropia.de>  [4c2243cd597cb323e31e42ed7d51e65edca7e03d]

        argon2: build opt.c again for WNT X86_64
        
        Commit 401e9408d14dc2b9d07183a04c223831a59f71a3 replaced opt.c with
        ref.c also for X86_64, which was probably not intended; apply patch only
        when needed.
        
        Change-Id: Ie7ca7b88751fb2d7de4d1a27e81c7f60a98359f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161629
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c458bfe2cc7f03b3e73be46cec3aba9e14b0f3df]

        nColCount is sal_Int32 so iter i can be as well
        
        Change-Id: I60d59a94329240b4cec0bae8beaeb93cddc5d3b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161623
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30f4044ff45403b7f69df4f49c3d58ccc8b3fdce]

        Resolves: tdf#158965 Find Record: Similarities dialog doesn't appear
        
        and assert in DBG_UTIL mode
        
        regression since:
        
        commit 36343165c251e30c700360cc5c4266f576d4ac00
        Date:   Wed Jan 25 11:07:28 2023 +0000
        
            cui: Make SimilaritySearch dialog async and enable use for jsdialog
        
        Change-Id: Iee2071874836ccf8a1ab10fbc6d6b3c491fd04ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161624
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cbb17a548b5cc6a99b6ed7735479bb4f2bc40f26]

        std::size/SAL_N_ELEMENTS also counts the null terminator
        
        which libxml2 2.12 will fail on with error:
        
        'Extra content at the end of the document'
        
        Change-Id: I9d5da9fdd826cce8462ede8c510eaea7281b760f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161627
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-05  Heiko Tietze  <tietze.heiko@gmail.com>  [79018bac2ed73fbfaacf661ae1272086e3ddd342]

        Resolves tdf#158780 - Disable resolution controls initially
        
        Change-Id: I80e620085868925643d4b7561cd7aeff2d9c930f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161620
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-05  László Németh  <nemeth@numbertext.org>  [96b3ed389fa5d434ed738d7f84dada4b6e2fabec]

        tdf#159032 sw smart justify: fix crash with complex tables
        
        Regression from commit 36bfc86e27fa03ee16f87819549ab126c5a68cac
        "tdf#119908 tdf#158776 sw smart justify: shrink only spaces"
        
        Change-Id: Ia3f39ad6549ea909bfe327ff8c8cbde821b90f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161652
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2024-01-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5056da285da2f130d741add1f8432cd590116a96]

        Don't mess with UserInstallation setting of --with-package-format=archive
        
        Ever since 9043c50f5e284f00a7eadeab5a3add0417c32227 "INTEGRATION: CWS native62
        (1.68.8); FILE MERGED" and its "2006/09/15 14:51:02 is 1.68.8.2: #i67179# new
        user dir for all simple-package installation sets" archive installation sets had
        set the UserInstallation bootstrap variable to $ORIGIN/../... instead of the
        normal $SYSUSERCONFIG/... that is used for other installation set formats.
        
        However, I see no good reason for that, and it interferes with my current work
        of making the --enable-online-update-mar `make create-update-info` work again
        (which builds a mar file from an archive installation set, so contained a
        boostrap ini-file with an unexpected UserInstallation value).
        
        (I don't know about the "installed" installation set format, which also messes
        with the UserInstallation setting, so I left that alone.)
        
        Change-Id: I3bd1e00771a4149922c3ce4e4d187abd3889b4ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161650
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-04  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [780e918a7daa7737c4f5b63deb8b0c25227873bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8244945b9d36822a2a35edca7bb9111f39ef282
          - tdf#156156: add Slide Transition sidebar deck help button's HID
            
            and document how to access it.
            
            Change-Id: I3f5c8e0f65f704389ed27989b29cca2cf0279302
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161107
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c824843612b7f51a8f5b07fa5c52e21aeb615035]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c66cae4936bcf19b5e98aaebcbc94139d4be9734
          - tdf#155876 UI cmds Calc-Sheet menu (48)
            
            + Data menu for Calc, Outline commands
            + refactoring
            
            Change-Id: I329995051e89390ba115120c20b5f88e39513d59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161619
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bc06b47486b39ffb665ffa3294a38e6164a4a159]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f74d61f5ec7aa420c5d2b8053fa0ed8b464c83b1
          - tdf#155876 UI cmds Calc-Sheet menu (47)
            
            + Data menu for Calc, Consolidate commands
            + refactoring
            
            Change-Id: I543ea880db1664496c81693f0a026db84f036da2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161618
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8e0aa45b4a20d80f8c0935b46a1261dd21073dc9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af50ff49da5f2b7288f9a713bb00b89f64988b84
          - tdf#155876 UI cmds Calc-Sheet menu (46)
            
            + Data menu for Calc, text to columns commands
            + refactoring
            
            Change-Id: I81c84de5faab4e6fe61d6d9352fb0efe7f22f12b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161617
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Julien Nabet  <serval2412@yahoo.fr>  [109e5e54a159b07314429dc004256c6ae2e799b1]

        tdf#155649: EDITING Writer some position parameters cannot go beyond 17 mm
        
        Change-Id: I70a80527dcc1c714fbe8783d1c4594bcc26b0624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161528
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-04  Martin Srebotnjak  <miles@filmsi.net>  [fbe86e6c298c13f6c3409ab7427c99b0a9c80a4f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to ef5ed1ca0e43519a2013d50d9ac67529b78f612c
          - Updated Slovenian thesaurus
            
            Change-Id: Ib3c9a0b4a36398b25def93bbbc62a9bcc8e3fa2c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/161614
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2024-01-04  Mike Kaganski  <mike.kaganski@collabora.com>  [06ff6370a4ba8084890274418eec355e8468573f]

        Send tooltip text to LOK
        
        Call vcl::Window::RequestHelp from LOKPostAsyncEvent for
        mouse movement. Introduce LOK_CALLBACK_TOOLTIP callback
        type, and send it from SwEditWin::RequestHelp.
        
        Intention is, that the tooltip is shown by client at the
        current mouse pointer position, which is hopefully not
        far away from the point that generated the mouse event.
        On the next movement, the client starts a timer to hide
        the tooltip. If the next tooltip message arrives, the
        tooltip would be updated in the new place.
        
        Alternatively, the payload could contain the coordinates
        from the HelpEvent.
        
        Change-Id: I8e96eb6e6983ad8d13b4c5d7be4d51ff3fd11893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161302
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-04  Heiko Tietze  <tietze.heiko@gmail.com>  [a5a0bb0c6577c82f5e31f1a81e31381fdf6c0c2e]

        Resolves tdf#158780 - Enable "Reduce Resolution" by default
        
        Change-Id: Ib60f8484ebf6b140c52c7d2b6f190eac9dd3ade1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161612
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d6a8bfe3727c9f7465e1beaa48109112ae85338c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fc99bb699412a3086f23f11ab6383994eb837f72
          - Fix typo
            
            Change-Id: Ic1f5c6a8138ddc63b5d746a5384f5751fd2844a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161600
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2024-01-04  buldi  <dobrakowskirafal@gmail.com>  [f5e5e86144152e5f98cbb985939a883936fe86d7]

        tdf#114441 sal_uLong to better integer type
        
        At first it seemd that sal_uInt16 may be sufficient for storing possible
        values. But as elsewhere unsigned 32 bit variables are used for such
        purpose, sal_uInt32 is used which allows having more space for bigger values.
        
        Change-Id: Ic2834ffc0fcabad91175aba3753e832dc1807fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151006
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [be1480264062eff93d8307ae14be1c4e8b9ea0ed]

        ofz#65442 Abrt in comphelper::SolarMutex::doRelease
        
        Change-Id: I0a256564abfdeb3209eb928f2888064f628eaf00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161610
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c6a1b04932fe1a9867fcef695510d45f4992f1af]

        can reduce fuzzing code spam now
        
        Change-Id: Ia684e3c4f8e3f637f738143e8f45cb5152a2c9ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-04  Heiko Tietze  <tietze.heiko@gmail.com>  [fc03109024041ea00bb62e90975e9a20a3668101]

        Resolves tdf#158810 - Hide recent actions while in template mode
        
        Change-Id: I7291cc7a634a0507bb240bf417d346e7a50f3c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161587
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2024-01-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7212021f6a79c78af8631766234696e557264bda]

        Add wrongly formatted files to excludelist
        
        Change-Id: I9b4374a95598c08c06427ecc9348c68d56352d25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161607
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-04  Darshan11  <darshan.upadhyay@collabora.com>  [01c9240947f21dec283fa0cb4b8b95e313073790]

        jsdialog: enabled objectdialog (Writer -> Chart -> properties jsdialog)
        
        - before this patch we were getting tunneled dialog in chart `properties` options
        - which causes to have multiple dialogs appear on screen
        - objectdialog is not enabled
        Change-Id: I083c3d05ded528412c36d917bc500e55778a01c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161582
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit e03b03128a4cfe853258f649f8ff6f96a2c8b851)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161567
        Tested-by: Jenkins

2024-01-04  Miklos Vajna  <vmiklos@collabora.com>  [836c773fba27c4f6f6f5edb81dfb67df75b5daec]

        CppunitTest_sw_pdf_test: turn on gb_CppunitTest_set_non_application_font_use
        
        And the same for 3 other tests.
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything so far.
        
        Change-Id: Ib7d772d6dd9e662007e4eeef9f6536aecf2dbeea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161605
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-04  Mike Kaganski  <mike.kaganski@collabora.com>  [9a2a1dfef1b085b1b899dfd2775d61c2fc41d2f3]

        Simplify rectangle unit conversion
        
        Change-Id: Idc3a4e983de0dec226ae1830fd70dc222624edd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161565
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [56767830b81fa21382b87cf43d78b1c73ca5dbd8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ada03f41bc98b77aafbb36b45c9302993519eac2
          - tdf#155876 UI cmds Calc-Sheet menu (45)
            
            + Data menu for Calc, Multiple Operations commands
            + refactoring
            
            Change-Id: I3795e10b80956fa85a2a9ec00250be7811dbbc01
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161604
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5bd23d5b2d109c550a08156f1f85970f29b897c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ff59004ff1d7506eebad27eed13c9d55419cacd
          - tdf#155876 UI cmds Calc-Sheet menu (44)
            
            + Data menu for Calc, XML source commands
            + refactoring
            
            Change-Id: I76779f586dc7819fcd7258a8307862fb35201636
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161603
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e54ca9f9a9727ca0e6456cf38dd93f22af686c9a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 73ef8f77eaad5dcd54d4422740b82e50c9e0ccd0
          - tdf#155876 UI cmds Calc-Sheet menu (43)
            
            + Data menu for Calc, Streams commands
            + refactoring
            
            Change-Id: I65c413046e79c3eff38082ad5df27b2a07502ea0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161602
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ff2e80f265d131210d308bd2fc9386b471539df0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f0087d58b480cf603dcb58fe0e83fadb8cc726d
          - tdf#155876 UI cmds Calc-Sheet menu (42)
            
            + Data menu for Calc, Form commands
            + refactoring
            
            Change-Id: I08fee1d9db332318d44cc445abe9e80e6275f530
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161601
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [23fc472a5f87f1f4c10e4a5ad8bf7cde6807cf50]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 461a95979023ee810210b0b69d8497ba8f585dfd
          - tdf#155876 UI cmds Calc-Sheet menu (41)
            
            + Data menu for Calc, subtotals commands
            + refactoring
            
            Change-Id: I83b4c61cad0ba8112c56089c0484fd43aa83cad5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161599
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0c5327423829905ce1d7950fd3f749f8a6300f1a]

        cid#1545822 SSD: Do not use an instance lock to protect shared static data
        
        Change-Id: I269e4cd52673ebe7c3e30670b2dfe29acbd48af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161548
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [660af778e6f61180b4b7f3f727fba23fed606117]

        cid#1550045 silence Free of address-of expression
        
        Change-Id: I132d1c80f30fbe50a35285f9bbe5515592fe49df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08417f7928ad28578615cb896b61f30574d062e8]

        cid#1545317 silence/assert Use after free
        
        reassume coverity this shouldn't happen, and assert to test doc
        corpus
        
        Change-Id: I67182328410aa398d28591d0cc7475e37fd1f9a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-03  gilssonn  <gilsonnyirimana@gmail.com>  [1cca19ad9701f4104ba6764802712387c29f28e3]

        tdf#114441 Convert use of sal_uLong to better integer types
        
        Reasoning:
        + For clipcontent.cxx, column3.cxx, dbdocutl.cxx, documen8.cxx,formulacell.cxx,
          patattr.cxx, stlpool.cxx, table2.cxx, table3.cxx and validat.cxx:
          + sal_uLong variables and functions are being
            initialized with/assigned/returning sal_uInt32 or size_t values
        
        + For column2.cxx:
          + The type of the return values of the `getWeight` function are size_t
        
        + For document.hxx, documen2.cxx, docsh.hxx, docsh5.cxx, viewfun2.cxx and globstr.hrc
          + `ScDocument::TransferTab`'s return variable's value is constrained to be either 0 or 1; which is better represented as a boolean
        
        Change-Id: If556f7fcc29f7e325618721959ea4e3615b2e755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154408
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b79056d2dae30a261e9bcf117d1f31fddf9bd8dd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ecd1826d0874e89fe363193e9e6f71e0055741fe
          - tdf#155876 UI cmds Calc-Sheet menu (40)
            
            + Data menu for Calc, validity commands
            + refactoring
            
            Change-Id: If520f434d2f908cd2adfd64374a1bc4a5da06a07
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161595
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [40efe03aa9e8f05f16761f0a6cfed349c8422921]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d9747fbaf0a8011c106c85fefb7eb9e6f571b505
          - tdf#155876 UI cmds Calc-Sheet menu (39)
            
            + Data menu for Calc, Calculate commands
            + refactoring
            
            Change-Id: I068b4c240b0a3192ddcb6f77fd6a2a52ac374437
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161594
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Miklos Vajna  <vmiklos@collabora.com>  [ae974a9928aa435316f15626642d41c5dddafe99]

        tdf#158999 sw: fix bad zero text frame height with no text and auto superscript
        
        The problem was that the bugdoc had an empty paragraph with superscript
        (as char format) enabled and that was simply lost in the layout. Adding
        text to the paragraph or removing the superscript formatting worked
        around the problem.
        
        What happened is that SwSubFont::GetHeight() has a somewhat surprising
        explicit check for escapement, and there the CalcEscHeight() call might
        be invoked on an SwSubFont whose m_nOrgHeight is 0, while the intent is
        to just return the original height in case of automatic subscript or
        superscript.
        
        Fix the problem by checking the result of GetDefaultAscentAndHeight() in
        SwLineLayout::CalcLine(), and in case it would simply turn the line into
        an invisible one for an empty line with sub/subscript then go back to
        the already correctly calculated line height.
        
        This needed adjusting a test in CppunitTest_sw_ooxmlexport12 because the
        bugdoc there had such a paragraph, effectively testing if we lose
        content during layout, which is not wanted.
        
        Change-Id: I1e836531851ea5c9a983ae69da5be8a042cc6e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161588
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-03  Miklos Vajna  <vmiklos@collabora.com>  [024cd30f38d7f9fcb3d075ee976826049a23a25b]

        libexttextcat: package newer language modules
        
        Fixes warnings like these:
        
        Failed to open fingerprint file '/home/vmiklos/git/libreoffice/core-clang/instdir/program/../share/fingerprint/ilo.lm'
        Failed to open fingerprint file '/home/vmiklos/git/libreoffice/core-clang/instdir/program/../share/fingerprint/skr.lm'
        
        Change-Id: Ic3e5951707a3b6935edc51ee41d726e35d71bab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161586
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-03  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [79e006cfc81728f1da39b9bf63b28074b7ccca50]

        Actually drop --with-online-update-mar-channel
        
        ...which had accidentally been forgotten by
        6910b1e3511701de5f0541fcaa98babf530f55ce "Hard-code
        --with-online-update-mar-channel=LOOnlineUpdater"
        
        Change-Id: I2dc9e500cfd9ffb1962c3fe3aa0bc9d6ba49c3d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161585
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-03  Gabor Kelemen  <kelemeng@ubuntu.com>  [bae684927c46e6105e78863bd9ee8560426a1b95]

        Drop now unused SvtSlideSorterBarOptions class
        
        Change-Id: I9db309b15e490c9bd03e767c192ba364a4ffe214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161452
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-03  Gülşah Köse  <gulsah.kose@collabora.com>  [e0f710ad29d33acda3c1b77d7a0980ca9ae2e3d1]

        ONLINE: Exit cell edit mode before add a new sheet
        
        Prevents to move last edited cell to new sheet.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: If4a4533d81ce244ae50bbdde1fae89da14f6b53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160758
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-03  Miklos Vajna  <vmiklos@collabora.com>  [a586ce188086ff27b08b8a4de4672c07ddf8ed7c]

        tdf#158532 sw: fix toolbar buttons remain disabled after pasting an image
        
        Pasting an image and then quickly switching to text selection resulted
        in e.g. the 'Insert Special Characters' toolbar button to remain
        disabled, which is incorrect.
        
        What happened is that the check in SwView::SelectShell() was poor, the
        intent in commit 31cb5b5538b9fd91dafb067ce961f2540555ad2b (sw: fix
        missing cache invalidation when switching between images, 2022-08-23)
        was to handle the case when we switch between images, but it also
        triggered for the case when we were switching from text to image.
        
        Once the condition is fixed, an additional problem was that while
        switching from text to image, m_nSelectionType is not yet updated, so
        use IsSelFrameMode() instead, this way both the old and the new
        use-cases work.
        
        A testcase that covers this would look something like this:
        
            createSwDoc();
            SwDocShell* pDocShell = getSwDocShell();
            SwView* pView = pDocShell->GetView();
        
            pView->InsertGraphic(createFileURL(u"test.jpg"), OUString(), /*bAsLink=*/false,
                                 &GraphicFilter::GetGraphicFilter());
            dispatchCommand(mxComponent, ".uno:Escape", {});
        
            std::unique_ptr<SfxPoolItem> pItem;
            SfxItemState eState = pView->GetViewFrame().GetBindings().QueryState(SID_INSERT_DIAGRAM, pItem);
            CPPUNIT_ASSERT_EQUAL(SfxItemState::DEFAULT, eState);
        
        but for some reason that also passes without the fix, so probably this
        change is hard to test from cppunit with reasonable amount of effort.
        
        Change-Id: I16749455e093cecf17fa067d7ddf86cd007fd2d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161579
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-03  Justin Luth  <jluth@mail.com>  [41452912e8ec11ecfead11588e7c70ad08903fd9]

        tdf#111969 sw: right-click menu recognizes start of hyperlink
        
        Prior to these fixes, the right-click building a menu
        for a hyperlink started half-a-character to late,
        because it doesn't activate at the start of a hyperlink,
        since a start == end cursor doesn't register character attributes.
        
        So this kind of fix may be needed for any kind of field
        or similar attribute that uses GetContentAtPos
        that interacts with the mouse cursor/menus etc.
        
        make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf158785
        
        Change-Id: I735c0085cb9658d299fe8896dfe1507bbe115667
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161265
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-03  Justin Luth  <jluth@mail.com>  [242f6985556af7aac77b68c6dfea20d4b32c5f52]

        tdf#111969 sw: acknowledge that last half-character for context menu
        
        This patch depends on the previous one.
        
        This fixes the right-click menu building features
        half-a-character too early (redlines, smarttag)
        and ending half-a-character too early.
        
        Note that hyperlinks already started half-a-char too late,
        now they start a whole character too late. See follow-up
        
        Note that fields ended OK, but still started
        too early until this patch.
        
        make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf111969B
        
        Change-Id: I90fbbb776667afc6021f8d0b3771f2cef1c72365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161258
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2024-01-03  Justin Luth  <jluth@mail.com>  [e73dfbf860b977f3b862fb75a87a7ad726d9a4c7]

        tdf#111969 sw: acknowledge field start/end for context menu
        
        This fixes the right-click menu building
        missing out on the edit/update field option about
        half-a-character too soon at the end.
        
        It also fixes itrcrsr adding field actions to the menu
        half-a-char too soon in the edge case of a 1-len portion.
        This edge case is not limited to fields - it fixes it
        for redlines (and hyperlinks if other bugs are fixed).
        
        make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf111969
        
        Change-Id: I469ec75d18d4dce0bb62ebb63b661b60e35f9e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161295
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-03  Mike Kaganski  <mike.kaganski@collabora.com>  [a01a642ebbdb8c16f1b54b4634c277b9f665192f]

        UnoApiTest::loadFromURL -> UnoApiTest::loadFromFile
        
        The old name was misleading (it doesn't take an URL, but a filename);
        also, now it's easier to grep for it - doesn't get mixed with
        vcl::graphic::loadFromURL.
        
        Change-Id: Ib88d2194200a6a54d2326971e0306ba39f0c7025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161578
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-03  Mike Kaganski  <mike.kaganski@collabora.com>  [8ecd20b447ab5e58fa77c19fce09c0f239d1fafc]

        Use loadFromURL to simplify
        
        Change-Id: I0a1acf2b20265a603d4f28a62a9f47d49e201f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161577
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-03  Justin Luth  <jluth@mail.com>  [4963fc47a0381967246e15479bf79bb58dddc465]

        tdf117100: do not attempt to re-install extensions on restart
        
        A common way to install extensions is to simply double-click
        on them in the OS's file browser. But in this case the reload
        still contains the extension in the cmdline and thus it
        "opens" the extension again and asks to re-install.
        So just eliminate OXTs from the commandline if OfficeRestartInProgress.
        
        If multiple OXTs are provided on the commandline, two things happen:
        -LO crashes (with an assert)
        -both extensions are successfully installed before restart is requested.
        
        In both cases removing ALL extensions during restart is appropriate.
        
        Prior to this patch, OfficeRestartInProgress was not actually used AFAICS.
        
        Mike Kaganski laid out lots of good criteria for this patch
        1. After restart, user can still manually install an extension: YES
        2. A restart after a restart should still inhibit extensions: YES
        3. Must no interfere is user choses to "restart later": YES
        4. It works with a clean profile (rm -r instdir/user): YES
        
        This implementation is closest to his suggested
        > Variant 4. Cleanup all fileopen/print arguments from the guards
        > that manage restarts (e.g., soffice.exe on Windows), so that
        > when restarting, they would not repeat using those arguments again.
        > Problem: first launch of soffice.bin that initializes user profile:
        > restart after this should repeat all the command line arguments.
        
        Change-Id: I2460cb31be0c6f3e10cbb5b200cf67839cbd822a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161549
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-03  Mike Kaganski  <mike.kaganski@collabora.com>  [960e37af28807ed1b376e26c4504ab755a81dfd5]

        tdf#158971: Only copy directly-set properties
        
        Commit f09420fa189be5165b0311083ba127073500a121 (tdf#158855: Make sure
        to not add extra paragraph after a table in a section, 2023-12-25) had
        implemented copying all attributes of a paragraph using copyAllProps.
        But the function didn't check the states of properties, so copied also
        default values of properties, making them direct properties of the
        paragraph. Due to tdf#158972, that caused an assertion when saving,
        and the main problem was a set of direct properties in the paragraph.
        
        Fix that by checking the properties states. Also make sure to work with
        paragraphs, rather than with ranges, which treats any properties set on
        paragraph level as default-state on the run level.
        
        Change-Id: I7cd9c7fbb9313d666c46be201913f0223a6b4f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161539
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-03  Justin Luth  <jluth@mail.com>  [9c9f5c9ed7a1d11fd34be6af5b09f836ed442211]

        flatten SwCellFrame::GetModelPositionForViewPoint
        
        With Lower() already checked for earlier,
        this can be flattened by a couple of levels.
        
        Change-Id: I594ebe4611938f79450f8d61a24c2060217eeb59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161391
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2024-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [196a3a16753bfd611e77308a809693340db506f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a4d57610215a15d757b519021bf2c4c1054be923
          - Update convert filter Help page
            
            Change-Id: I536ade27439dc2e7903a648a8c1e882ab50ea4ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161574
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5ad35e44e1dced2f66256b886ba9c480a773f8e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13abf9ab259bdbe770c9618b372549a66355e135
          - Link edit mask description to pattern fields
            
            Change-Id: I48c5064a8e4f978bcfe634818873826baf9557e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161573
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-03  Gabor Kelemen  <kelemeng@ubuntu.com>  [9fc28d7ef5def30a23960cf15334af1aec27460f]

        Use officecfg instead of SvtSlideSorterBarOptions class
        
        Change-Id: Ie2965f343e6df31502596c35e1d17c22bbccb142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161451
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aea27245d8c1d6965a2f853951f5eeea4921b166]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 7fa8d80ec50630f2c63eb1aa568a373bd3eecd3e
          - tdf#156723 False positives in pt-BR lightproof
            
            Salário mínimo
            
            Change-Id: I5d060d90b7915b91d44b8dd2cb9bd4cf79115012
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/161572
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2024-01-02  Justin Luth  <justin.luth@collabora.com>  [0ce7c7a64fbc1b5c15dd6887c31ca7c93b069ff7]

        rtf writerfilter: calculate if frame hasProperties once
        
        Change-Id: I0a5888b73a4eccb84f4eae6613519d877e550a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161390
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2024-01-02  Luv Sharma  <luvsharma.del@gmail.com>  [54f2bd45346c0e4a6331ddce5c23aec0c37b0dba]

        tdf#145538 Use range based for loops
        
        Change-Id: I0f028d48ccad4e1420e043eb0ab8aeab88ed0b88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161533
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2024-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1e5fedf1a34e4609d4cf9f7fb70bc8797692d521]

        Re-enable MOZ_VERIFY_MAR_SIGNATURE feature
        
        ...that 3a445cb49795fabe0d8caaf12bfc38eb9e12d5fc "Turn onlineupdate into
        external/onlineupdate" had accidentally turned off
        
        Change-Id: I345d02a305a33fc641566d122c8cdb55c09599a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161546
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6910b1e3511701de5f0541fcaa98babf530f55ce]

        Hard-code --with-online-update-mar-channel=LOOnlineUpdater
        
        (An upcoming change will add an instset/update-settings.ini file containing that
        value, but using a GeneratedPackage for a single file instead of a directory
        seems unsupported, so it will use the hard-coded value and a plain Package
        instead.)
        
        Change-Id: I12ffef4db71ce36be9096df674588b39c660e4de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161545
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [e1402abc5c6d08ae541ca6ef31b017034232d4cf]

        tdf#158913 secure Primitive 'visit' using mutex
        
        See text in tdf task for detailed description.
        
        Change-Id: I4677c9f2ecfdcb760d05fe916a2aa2dd25ad40b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161543
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [69181dd430543db21fc0e61b70033ef484708c1c]

        ofz#65480: Integer-overflow
        
        Change-Id: Ie771e6e37237907698e4c39eb50cd940500b86ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161540
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d8b5a91a76262d6dd58342b248e542ddea1fdaf]

        cid#1545462 perturb Resource leak report
        
        to see if this makes a difference
        
        Change-Id: I4017a0e8d514c32a3fef46a2c23e33023e907275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd82bf96ac50f9b98619ec97dfbac4cb1d988183]

        ofz#64860 Timeout
        
        Change-Id: Ib475cbba118f0705b9475dbe61ec1b96a68af47c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161544
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a2deec946ebfc8f14792e971a354906d1c723164]

        Fix Windows path separator
        
        ...broken since 84ef6d82546b044990f4efd57e51e29c6c6565c8 "Build external lxml if
        not provided by system"
        
        Change-Id: Ie76c32a1d3094e6d98db7d50195571ae31c0ada6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161536
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9122c6f9b4c6901ea0cedf6e655daa1afbb57ab3]

        ofz#65464 Timeout with text:anchor-page-number="28031970720"
        
        text:anchor-page-number is problematic, possibly more so since
        
        commit 23eadd873de2e56d1e5f866fefae25c648f302f9
        Date:   Wed Jun 28 17:19:02 2023 +0200
        
            tdf#156077 sw: layout: call AssertFlyPages() in Init()
        
        in that missing pages are added to get to the page the object
        claims to be anchored to, to a max of 32767
        
        Limit this to 100 like:
        
        commit e4ee999d6d9c10ee10d6778eca9354d8fbaa720f
        Date:   Sun Jul 23 21:34:23 2023 +0100
        
            ofz#60533 Timeout with fo:font-size="842pt"
        
        when fuzzing to get reasonable performance
        
        Change-Id: Ic7568fe9535bdd07557434c8b51c1532415822a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [aa3bca30248436d051981c6fff03c864d0228874]

        Add flush mechanism to buffered Primitives IV
        
        Now trying not to delete a LocalCallbackTimer if it gets
        used - no limitation since this only happens when a
        time is given (maCallbackSeconds).
        Also added to reset callback ptr (clearCallback()) to
        nullptr and make onShot dependent of that, hope is that
        destruction of LocalCallbackTimer in
        ~BufferedDecompositionPrimitive2D gets safer that way,
        excluding race conditions.
        
        Change-Id: Id474962bdae14631afc42d2d92db635408fb67d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161434
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ddaea28c9f77bc5b9c323604d7eed4d79d5c732e]

        cid#1545989 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545432 COPY_INSTEAD_OF_MOVE
        cid#1545622 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib6858cf284bf5c3e185830fcd51361d1db3fc747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161527
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Laurent Balland  <laurent.balland@mailo.fr>  [4f6143ac17cd36f33828136d2b1e3dbd5833e30c]

        tdf#158863 Move README to meta.xml
        
        Impress templates from Indonesian community contain some README files,
        containing authors name and licences information. They are only
        available in source code.
        This commit removes these README files and move information to meta.xml
        file, dc:decription element. This information is now available to user
        in dialog: File > Properties > Description
        
        It needs to delete also extras/source/templates/presnt/Growing_Liberty/readme.txt
        As this file is using CR/LF as end of line, I cannot remove it through normal git/gerrit process.
        
        Change-Id: Ic815b6da7a8c2e1975518aafd3965ebf2b08fc20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161501
        Tested-by: Laurent Balland <laurent.balland@mailo.fr>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-02  Szymon Kłos  <szymon.klos@collabora.com>  [21e58b94a2390a17571c30e91254f116d1566a2d]

        lok: import Work path from LOK_WORKDIR
        
        Change-Id: If0c9727f53c1c4dfb78d1ccbd6b3ff602268bbf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160156
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161059
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2024-01-02  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [b72aa31d7db38c81f757206e4e51844b839797ea]

        Japanese word for 'reiwa' added to ja.dic
        
        Change-Id: I80743231e22f0507ba5569d325e1f86920658a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159967
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2024-01-02  Miklos Vajna  <vmiklos@collabora.com>  [cdde4687ea0da4d101567a64fa0d60103f353d68]

        svx: prefix members of XColorItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I7e945c6c0d1ff13445255125732c3d3a02cda350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161534
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [548f0b1883e18ff2870a40bccf047864ff35c18b]

        editeng: preserve ContentNode in a unique_ptr when moving paras
        
        When we move the paragraphs, we can just take the unique_ptr of
        ContetNodes out of the EditDoc and move it to new position inside
        EditDoc, like it is done for ParaPortions in ParaPortionList.
        No need to muck with the raw pointers and releasing the ContentNode
        from a unique_ptr and later moving it back again.
        Also just use a std::vector for ParaPortions instead of a new
        instance of ParaPortionList.
        
        Change-Id: I8634ccc83121c1ee683be4c2cfb0cedbd469c05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161531
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Mike Kaganski  <mike.kaganski@collabora.com>  [14e49062012f8699125422cc8a82a22b26f43143]

        tdf#158945: blind fix (try to decrease pending operations limit)
        
        *If* the crash in the bug was caused by OOM in Vulkan, then *maybe*
        it was exactly the case mentioned in the comment above:
        
        > queueing many tiny bitmaps ... may make [Skia] even run out of memory
        
        Let's try to reduce the threshold dynamically, from 1000 down, in the
        hope that this would avoid the OOM in the specific HW. If it doesn't,
        it will eventually still abort().
        
        Change-Id: If6151d4f273a5f938030121d13c268bc9906fa23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161516
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e7e7449729fe2b750506b4b165c4be993834fd16]

        editeng: add begin, end, MarkAllSelectionsInvalid to ParaPortionList
        
        begin, end to make iteration work with range for
        
        Change-Id: Ia64d4f8102485b257e190fc702e4aa734a81d866
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161530
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [de385412949e2ca52c999546677744ed070d189c]

        editeng: prefix members of ImpEditEngine
        
        Change-Id: I05a738be8956ebaa2912c6c8a20a05002d67b789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161529
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [92a9fa82f412daa4e5ccb5889076a1267648e0c1]

        editeng: remove operator[] for EditDoc (use GetObject instead)
        
        Change-Id: Ie41d2baf84d230b9ee280859d390e24b9da70be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161482
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e71934471442a8bbba7e661d3ebe5f708627c5d6]

        editeng: add max paper size constant
        
        Change-Id: Ib51f5c5bbcf68fd156b02e04e8e99408aa97abf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161481
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3461a0027cf5c54ae164462d177ea222ccc76f39]

        editeng: better lifecycle control for ContentNode in EditDoc
        
        Don't use raw pointers, when it is possible to move the unique_ptr
        around into another object that is responsible for the object's
        ownership.
        The ContentNode is either in a vector in the EditDoc class or it
        is moved to the EditUndoDelContent class for the undo/redo action.
        Those 2 classes are responsible for freeing the ContentNode.
        
        Change-Id: I977d8e418947bb48781f23575d62420260025e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161480
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [78027c68397f26aec9051b82388cd7452ec66e3d]

        bump libexttextcat to latest release
        
        Change-Id: I5fdde5668845f5b7c388322135b21adf41bd3d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6bccf8e409a1722ab6920f60478c97241790be87]

        cid#1545235 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545514 COPY_INSTEAD_OF_MOVE
        cid#1546000 COPY_INSTEAD_OF_MOVE
        
        std::move looks useful there
        
        Change-Id: Ic3967f283ac4c4f5b8b4797889099af5f2dbb117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [58d7eabbed200daaf8b6e1fcb82687ce70184412]

        cid#1545836 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idb754296175f786c7850253749e3b7f968aa87fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2024-01-01  Rene Engelhard  <rene@rene-engelhard.de>  [a9008aa942c1f98f8b00b2bd2f73edc576713e92]

        update LIBO_THIS_YEAR
        
        Change-Id: I023baa2238c6cdbbd54a7e6b0fcdb128510bbd4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161522
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [13a40e9c8e1d505565bd77774742cf72bb33b99f]

        Remove OApplicationController::getStrippedDatabaseName which only adds a layer
        
        Change-Id: Ife0435f52b1abe62337623aa5c6010195802760b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161523
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-01  Balazs Varga  <balazs.varga.extern@allotropia.de>  [167659bf16a68c27fa547e6eccd62c1a6f69b057]

        tdf#157742 tdf#157783 - sd: fix copy master slides style
        
        Copy SlideLayout property and themes from the old slide to
        the new one.
        
        Change-Id: I7310200c731839a606981c6d63c8d0d4f9ec0536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161401
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [a28b1dfb2dec7ece83280232941d9d2e2b72b557]

        Replace "size() == 0 with empty()" (sc/part2)
        
        Change-Id: I0c87b39bd89825eba5f3c90477ba41eb7e5178ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161517
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-01  Luv Sharma  <luvsharma.del@gmail.com>  [6c9dda18242bce6a37f7c43277ab4647a70401c8]

        tdf#148251 Use std::swap instead of using temporary values
        
        Change-Id: Iac18ab1e64e58749e300f71f7e61d4a31c66355e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161496
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [a3f21172fdb7fed6eb61be9199980421bad71101]

        Revert "Related tdf#158739: blacklist Nvidia RTX 4050 for Skia hardware"
        
        This reverts commit bc00fb6de3ffd3949a3cdb524f49dac7e32258a9.
        
        Reason: the real pb has been fixed thanks to Mike with:
        https://git.libreoffice.org/core/+/025a49a40a3c0c1be5bf4383e87a1cc60014b7f4%5E%21
        tdf#158942: renderMethodToUseForSize may force raster surface
        
        Change-Id: I66602d607d3ea933b4035d616ebed7fedebfb9a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161515
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [968cb673eb353bd5d19d96498c0d38c00801c8a0]

        Replace "size() != 0 with !empty()" (desktop)
        
        Change-Id: I164e29ed02fc4abf7a5b03ca0c391fb46b60e4f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161483
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [3f6396291a044274fd3238c797f3aff4a458fa37]

        Replace "size() != 0 with !empty()" (sw)
        
        Change-Id: Iaa94c0b057694429b327cbca847fee06ad74256a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161489
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [77585439438d9ccfd77534341178a948a575edee]

        Replace "size() == 0 with empty()" (chart2)
        
        Change-Id: Ia1e082d6cf6db2a3df2b5dd5fc8f13caee529fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161465
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2024-01-01  Luv Sharma  <luvsharma.del@gmail.com>  [a058fa6eb87dcc4a01dac14674e15ff3ba611ced]

        tdf#158237 chart2: use c++20 contains() instead of find() and end()
        
        Change-Id: I065f672de257e8a16a4cb9d41ff6334e5fea1823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161492
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-01  Luv Sharma  <luvsharma.del@gmail.com>  [8eadc80ac0c5e194a99ba57a2bf9d29e1465bdf8]

        tdf#143148 Use pragma once instead of include guards in vcl
        
        Change-Id: Icd42bbdaedd7f9ed7bc63c14ed0f4ec43c9a37c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161508
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2024-01-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [d978e2fe9e7e259bf724178d2d4fe4f9cda18e5f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a7fc08834190211307266e4af41d53cdb54e3cd4
          - Fix broken link to "Text Box"
            
            This issue affects versions 24.2 and later.
            
            Change-Id: Icd61deadf03a83c34935e6c05a3554785f649abe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161461
            Tested-by: Jenkins
            Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
            Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
            
2024-01-01  Mike Kaganski  <mike.kaganski@collabora.com>  [3c8af232a4981150b1c9396ca947fbfcef5a222e]

        Missing includes
        
        Obviously included indirectly, but were confusing VS IDE
        
        Change-Id: I68e0d9ca96a6fcef1bf8c8f12bfecb543690a75a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161514
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-01  Julien Nabet  <serval2412@yahoo.fr>  [ff07799606ff0d2405225d818c4fbbaf30c4a10f]

        cid#1545411 Resource leak
        
        Change-Id: I3ecb388a69c261a74b6d1a7b7d467d1a32956916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161449
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2024-01-01  Jamie Douglass  <jdouglass6@me.com>  [ef5aadffaefe47870f1e9472d7cdb8d37526c104]

        tdf#142494 Word count set to 0 when no words are selected.
        
        The application now correctly recognises selections without words.
        When a selection is made that does not contain a word, the word count is
        set to zero, and the text "Selected: 0 words, x chars" now appears
        
        Change-Id: Icfa0a6fe2bf6315485102d6ad9b3cea5b6d8d139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161509
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [417d1d56b39453b5ae8396a8286d8291061f049b]

        editeng: make it clear EditDoc is responsible for ContentNodes
        
        Change-Id: I38b9b1a5ba48d73438865f5a040f2483f6814c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161479
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [252c0316c3be09079e08afc9fa512ca5a60ea957]

        editeng: prefix members of EditDoc
        
        Change-Id: I403db061b6e3e184e97c5ec3ce5746d2fdff0749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161478
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ee2164d484541e0b45a40aad619d0db31afde634]

        editeng: simplify constr. and destr. of ParaPortion{List}
        
        Change-Id: I8f7e242b66463baa9adcc0dee8eb8f4206630c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161477
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Jim Raykowski  <raykowj@gmail.com>  [7e378516bc596d0308bcb1c974760c224f516ea6]

        tdf#158710 Fix animation list custom rendering for vcl gen plugin
        
        Change-Id: I5d2eb9e74392036a99b90fca1c5a49ac7bee828b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161511
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [275860e607c172825bc47f70eba5562e5a9208f4]

        editeng: move ParaPortionList into its own header file
        
        Change-Id: Ibb1c9feb989a7dc3127e21c5a4dcda41b64fc84b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161476
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [916268c70a5673680c86eaac11c543fd45b90eb3]

        editeng: move ParaPortion into its own header file
        
        Change-Id: I3fefe4a9fc5d391b1c3af335893a084eaeddba4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161475
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0020f05df2e7fc739e5e017e035efbe3c9bc8b35]

        editeng: move impl. of TextPortionList methods to own cxx file
        
        Also move some simple methods to header file and clean-up the
        constructors and destructors.
        
        Change-Id: I5113d785ecc71d36b4c6a480b15427ca68eb2e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161474
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e3267cadcaa8cfc64705e24bd484815469b8814f]

        editeng: move TextPortionList into its own header file
        
        Change-Id: I366706138f88c7865a7f1315af64bb4ab5b07ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161473
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2024-01-01  László Németh  <nemeth@numbertext.org>  [c899d3608d30f3ab4c2bc193c1fcd765221614a4]

        tdf#158885 sw: don't hyphenate right after a stem boundary
        
        in compound words to get better typography or orthography
        with more readable text, if hyphenation zone is enabled.
        
        If there are multiple possible break points in the word
        according to the libhyphen based hyphenation, keep only
        the best ones using Hunspell morphological data
        based on compound word decomposition of non-dictionary
        words (pa: fields), and extra morphological data of dictionary
        words (hy: fields) or their combination.
        
        For readability and tradition, orthography and typography
        prefer or only allow hyphenation between stems in compound
        words in several languages, like Danish, Dutch, German,
        Hungarian, Norwegian and Sweden.
        
        Hyphenation zone is to avoid of too much or bad hyphenation.
        Preferring stem boundaries for hyphenation within the hyphenation
        zone is a natural extension of  it, i.e. skip hyphenation within
        stems, if there is stem boundary within the hyphenation zone.
        
        Now skip break points after skip boundaries, if their
        distance is 3 or less characters (COMPOUNDLEFTHYPHENMIN = 4).
        
        Skip also break points on stem boundaries, if there is a
        weighted stem boundary before them within 3 characters.
        
        Weighted stem boundaries are there between the pa: fields,
        (stems resulted by the compound word decomposition),
        or in hy: field, boundaries marked by double || instead of
        a single |.
        
        More information: man (5) hunspell, and option -m hunspell.
        
        Note: break points skipped only in the last stems for languages
        with fogemorphemes, yet, because of their incomplete Hunspell
        output for morphological analysis.
        
        Change-Id: I739908716d11a9c2db0c9d36fba8657ba6f53bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161498
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20c015f2726904b0d96380a1ec16e7d7406acca1]

        cid#1546464 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546346 COPY_INSTEAD_OF_MOVE
        cid#1546342 COPY_INSTEAD_OF_MOVE
        cid#1546320 COPY_INSTEAD_OF_MOVE
        cid#1546305 COPY_INSTEAD_OF_MOVE
        cid#1546241 COPY_INSTEAD_OF_MOVE
        cid#1546162 COPY_INSTEAD_OF_MOVE
        cid#1546118 COPY_INSTEAD_OF_MOVE
        cid#1546048 COPY_INSTEAD_OF_MOVE
        cid#1545989 COPY_INSTEAD_OF_MOVE
        cid#1545936 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I63bc43378b36f7c49e66231152138ad7038971e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161507
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c77ecfbdbee4b03225e9dad7cbedd5c9c7be0995]

        ofz#65266 Timeout
        
        Change-Id: I15f4acfd60fa7a7d02dd06be02b33383b21a33b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161499
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Mike Kaganski  <mike.kaganski@collabora.com>  [091d0e48b568a427238987146e8fa6b648266ce8]

        Use DBG_TESTSOLARMUTEX instead of SolarMutex::IsCurrentThread in assertion
        
        It is consistent with all other places where this precondition is tested.
        
        Change-Id: I0f99447fea8bb0b5d869f2205a06f954b75b8e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161505
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-31  Mike Kaganski  <mike.kaganski@collabora.com>  [75c89e5603b5fbe4fa2b307f565c071f3b36216b]

        Acquire solar mutex in SkiaZone, instead of asserting
        
        The assertion is there since commit 7c1dc527837a65b77f7624e18a575271cb46afba
        (ensure SolarMutex is held for SkiaZone, 2020-09-29). For unclear reason,
        it now started to fail locally in JunitTest_toolkit_unoapi_3:
        
         vcllo.dll!SkiaZone::SkiaZone() Line 23	C++
         vcllo.dll!SkiaSalBitmap::ResetAllData() Line 1412	C++
         vcllo.dll!SkiaSalBitmap::Create(const Size & rSize, vcl::PixelFormat ePixelFormat, const BitmapPalette & rPal) Line 85	C++
         vcllo.dll!Bitmap::Bitmap(const Size & rSizePixel, vcl::PixelFormat ePixelFormat, const BitmapPalette * pPal) Line 132	C++
         vcllo.dll!`anonymous namespace'::GIFReader::CreateBitmaps(__int64 nWidth, __int64 nHeight, BitmapPalette * pPal, bool bWatchForBackgroundColor) Line 224	C++
         vcllo.dll!`anonymous namespace'::GIFReader::ReadLocalHeader() Line 513	C++
         vcllo.dll!`anonymous namespace'::GIFReader::ProcessGIF() Line 807	C++
         vcllo.dll!`anonymous namespace'::GIFReader::ReadGIF(Graphic & rGraphic) Line 946	C++
         vcllo.dll!ImportGIF(SvStream & rStm, Graphic & rGraphic) Line 1005	C++
         vcllo.dll!GraphicFilter::readGIF(SvStream & rStream, Graphic & rGraphic, GfxLinkType & rLinkType) Line 920	C++
         vcllo.dll!GraphicFilter::ImportGraphic(Graphic & rGraphic, std::basic_string_view<char16_t,std::char_traits<char16_t>> rPath, SvStream & rIStream, unsigned short nFormat, unsigned short * pDeterminedFormat, GraphicFilterImportFlags nImportFlags) Line 1328	C++
         vcllo.dll!GraphicFilter::FilterCallback(ConvertData & rData) Line 1861	C++
         vcllo.dll!GraphicFilter::LinkStubFilterCallback(void * instance, ConvertData & data) Line 1832	C++
         sofficeapp.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 111	C++
         sofficeapp.dll!desktop::Desktop::ImplInitFilterHdl(desktop::Desktop * __formal, ConvertData & rData) Line 1722	C++
         sofficeapp.dll!desktop::Desktop::LinkStubImplInitFilterHdl(void * instance, ConvertData & data) Line 1719	C++
         vcllo.dll!Link<ConvertData &,bool>::Call(ConvertData & data) Line 111	C++
         vcllo.dll!GraphicConverter::Import(SvStream & rIStm, Graphic & rGraphic, ConvertDataFormat nFormat) Line 39	C++
         frmlo.dll!ImageProducer::ImplImportGraphic(Graphic & rGraphic) Line 187	C++
         frmlo.dll!ImageProducer::startProduction() Line 147	C++
         frmlo.dll!frm::OImageControlModel::doSetControlValue(const com::sun::star::uno::Any & _rValue) Line 610	C++
         frmlo.dll!frm::OBoundControlModel::setControlValue(const com::sun::star::uno::Any & _rValue, frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 2127	C++
         frmlo.dll!frm::OImageControlModel::impl_updateStreamForURL_lck(const rtl::OUString & _rURL, frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 423	C++
         frmlo.dll!frm::OImageControlModel::impl_handleNewImageURL_lck(frm::OBoundControlModel::ValueChangeInstigator _eInstigator) Line 437	C++
         frmlo.dll!frm::OImageControlModel::setFastPropertyValue_NoBroadcast(long nHandle, const com::sun::star::uno::Any & rValue) Line 259	C++
         cppuhelper3MSC.dll!cppu::OPropertySetHelper::setFastPropertyValue(long nHandle, const com::sun::star::uno::Any & rValue) Line 523	C++
         comphelper.dll!comphelper::OPropertySetAggregationHelper::setFastPropertyValue(long _nHandle, const com::sun::star::uno::Any & _rValue) Line 534	C++
         cppuhelper3MSC.dll!cppu::OPropertySetHelper::setPropertyValue(const rtl::OUString & rPropertyName, const com::sun::star::uno::Any & rValue) Line 266	C++
         mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214	C++
         mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430	C++
         binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239	C++
         binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79	C++
         binaryurplo.dll!request(void * pThreadSpecificData) Line 84	C++
         cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101	C++
         cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169	C++
         cppu3.dll!threadFunc(void * param) Line 190	C++
         sal3.dll!oslWorkerWrapperFunction(void * pData) Line 69	C++
         ucrtbased.dll!00007ff9dfee3010()	Unknown
         kernel32.dll!00007ffaab01257d()	Unknown
         ntdll.dll!00007ffaac28aa58()	Unknown
        
        No idea what caused the problem only now. But since solar mutex is
        expected to be hold here, let's just do it.
        
        Change-Id: Id848f5f43759ef37faa0d18ed3133a7292b3463f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161504
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c3ac62fb5772838cfa27c7c690a57ddfad082cb3]

        cid#1559949 silence Uncaught exception
        
        and
        
        cid#1559958 silence Uncaught exception
        
        Change-Id: Ic7093b3c9eef55157b7bca481841db0ef4b8c8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161506
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7cf623ae1771f448ab4f82c175156a7e776fa964]

        cid#1559993 Division or modulo by float zero
        
        Change-Id: I071d576fc998022c76364778423e0346f69cb051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b9a538418e434e9a0757e6a7e814fb03ec32954]

        cid#707862 Uninitialized pointer field
        
        returned since
        
        commit 04c3ef3c7224644b7e54ff215343391cef77f7b5
        Date:   Sat Dec 30 15:08:30 2023 +0200
        
            ImgProdLockBytes is unnecessary
        
        Change-Id: Iabd3cf1f64b87b8ffb8c73702ef138cf7b7d64a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Noel Grandin  <noelgrandin@gmail.com>  [d75ebbbf58feb1564e11495f1817a16c4950c6f0]

        add comment to SvLockBytes
        
        Change-Id: I41280ba13a35d2e89e24a574200f3db60dfd293e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161495
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [0d5bd921a5a08607ec0b240463eff143f0b52fd0]

        Replace "size() == 0 with empty()" (sfx2)
        
        Change-Id: I6bdb18319e45fbe8641a2ded31e60c2628bb1b67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161468
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [393171f473870a0790b0ebe7fac3922d7d5ff5d1]

        Replace "size() == 0 with empty()" (dbaccess)
        
        Change-Id: Icd15299fbf9515d35a143995bcf131d267fe2fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161466
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [10ef920e9d2647eb0f6a8565bff21f463ca0cd88]

        Replace "size() != 0 with !empty()" (vcl)
        
        Change-Id: I33fae6ec7d73cf126d49d384a26b19c68cc68b30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161490
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d6b1e5631ef936479cec6a3e5496e447c78279a7]

        Expand some macros inline
        
        Change-Id: I6abad4ab4ea357ab55ea97b8a0d39c453dffc249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161493
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-31  Luv Sharma  <luvsharma.del@gmail.com>  [cfa35c15d422e4b3cc70dda0dea9cad40f01d303]

        tdf#158337 use std::erase instead of std::removed followed by erase
        
        Change-Id: I3fbcf2babc595ce1a08bb2f50824b0dcea34a2c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161494
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [d4cbae02ecdd50ea31556bda967a1a0869530275]

        Replace "size() != 0 with !empty()" (sfx2)
        
        Change-Id: Ic841e85634d292758d2815aab1b3f7546ed2a6f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161486
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [21a6641da521e47d12be91afc55eae5836a24e5c]

        Replace "size() != 0 with !empty()" (svl)
        
        Change-Id: I173c42583c03c41d8cd98424ba672cce10081e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161487
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [df2586cd988c01becbc7cd40cbd44f1f38348755]

        Replace "size() != 0 with !empty()" (xmlsecurity)
        
        Change-Id: Ibc1b8265292f579760c08c2906687118a8cf6df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161491
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [327e9592319ddd192de01d1850e404a0918ad130]

        Replace "size() != 0 with !empty()" (svx)
        
        Change-Id: I42c3d2a41bebc4e403180d8b3f8eb73d0d3a2377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161488
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Mike Kaganski  <mike.kaganski@collabora.com>  [0cc710467d91b8b8a6d87fc0fe1d16956554cf3f]

        Avoid unwanted creation of mSurface
        
        Commit 2d1a0d86d2d0c00fcfee61c39f2221e786e4245b (Related: tdf#152703
        Prevent possible hang when live resizing a window, 2023-01-06) had
        added a call to checkSurface in SkiaSalGraphicsImpl::performFlush,
        to detect resize.
        
        This created a regression, seen e.g. in JunitTest_framework_complex,
        where 'assert(!mSurface)' in SkiaSalGraphicsImpl dtor fails now on
        Windows with Skia/Vulkan:
        
         vcllo.dll!SkiaSalGraphicsImpl::~SkiaSalGraphicsImpl() Line 296	C++
         vclplug_winlo.dll!WinSkiaSalGraphicsImpl::~WinSkiaSalGraphicsImpl()	C++
         vclplug_winlo.dll!WinSkiaSalGraphicsImpl::`scalar deleting destructor'(unsigned int)	C++
         vclplug_winlo.dll!std::default_delete<SalGraphicsImpl>::operator()(SalGraphicsImpl * _Ptr) Line 3170	C++
         vclplug_winlo.dll!std::unique_ptr<SalGraphicsImpl,std::default_delete<SalGraphicsImpl>>::~unique_ptr<SalGraphicsImpl,std::default_delete<SalGraphicsImpl>>() Line 3282	C++
         vclplug_winlo.dll!WinSalGraphics::~WinSalGraphics() Line 668	C++
         vclplug_winlo.dll!WinSalGraphics::`scalar deleting destructor'(unsigned int)	C++
         vclplug_winlo.dll!WinSalFrame::~WinSalFrame() Line 977	C++
         vclplug_winlo.dll!WinSalFrame::`scalar deleting destructor'(unsigned int)	C++
         vclplug_winlo.dll!SalComWndProc(HWND__ * __formal, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 667	C++
         vclplug_winlo.dll!SalComWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 724	C++
         user32.dll!00007ffaab908241()	Unknown
         user32.dll!00007ffaab907efc()	Unknown
         user32.dll!00007ffaab91302d()	Unknown
         ntdll.dll!00007ffaac2d33b4()	Unknown
         win32u.dll!00007ffaa97814d4()	Unknown
         user32.dll!00007ffaab911b4f()	Unknown
         user32.dll!00007ffaab911a1c()	Unknown
         sal3.dll!osl_waitCondition(void * Condition, const TimeValue * pTimeout) Line 93	C++
         vclplug_winlo.dll!osl::Condition::wait(const TimeValue * pTimeout) Line 124	C++
         vclplug_winlo.dll!SalYieldMutex::doAcquire(unsigned long nLockCount) Line 140	C++
         comphelper.dll!comphelper::SolarMutex::acquire(unsigned long nLockCount) Line 87	C++
         vcllo.dll!SalInstance::AcquireYieldMutex(unsigned long nCount) Line 147	C++
         vcllo.dll!Application::AcquireSolarMutex(unsigned long nCount) Line 510	C++
         vclplug_winlo.dll!SolarMutexReleaser::~SolarMutexReleaser() Line 1420	C++
         vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 586	C++
         vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 390	C++
         vcllo.dll!Application::Yield() Line 475	C++
         vcllo.dll!Application::Execute() Line 368	C++
         sofficeapp.dll!desktop::Desktop::Main() Line 1605	C++
         vcllo.dll!ImplSVMain() Line 229	C++
         vcllo.dll!SVMain() Line 262	C++
         sofficeapp.dll!soffice_main() Line 94	C++
         soffice.bin!sal_main() Line 51	C
         soffice.bin!main(int argc, char * * argv) Line 49	C
         soffice.bin!invoke_main() Line 79	C++
         soffice.bin!__scrt_common_main_seh() Line 288	C++
         soffice.bin!__scrt_common_main() Line 331	C++
         soffice.bin!mainCRTStartup(void * __formal) Line 17	C++
         kernel32.dll!00007ffaab01257d()	Unknown
         ntdll.dll!00007ffaac28aa58()	Unknown
        
        This is caused by unwanted creation of mSurface in checkSurface,
        outside of the Init/DeInit pair, called from WinSalGraphics'
        InitGraphics/DeInitGraphics. Thus an invariant is broken, that
        only when WinSalFrame initializes its mhLocalDC, its mpImpl is
        initialized. Deinitialization of mpImpl is thus only called if
        mhLocalDC is not null.
        
        Since flush makes no sense without mSurface, just move the call
        to checkSurface inside the mSurface check. Hope it doesn't break
        the fix made in commit 2d1a0d86d2d0c00fcfee61c39f2221e786e4245b.
        
        Change-Id: I54442e604ef7c28659b908a7fb1404c9da41b006
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161484
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>
        Tested-by: Jenkins

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [7dcc4bf0d8b36553d79c6af10e9b9ced340555a8]

        Replace "size() != 0 with !empty()" (forms)
        
        Change-Id: I855c4868334c8890b00e78caa67bfc9c9c9ebd80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161485
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [553ca63f5cc2bb1d4545bea50783bffa3e69955e]

        Replace "size() != 0 with !empty()" (cui)
        
        Change-Id: I7640be31591bbf4e4f319f35eae0924e7503c282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161472
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [6103a8e1ad31c08cab4b42993152d04f69e4f0ae]

        Replace "size() == 0 with empty()" (sd)
        
        Change-Id: I3421e931dc8d6d58f85b238de9c3ca94a4255911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161467
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [7ae0f286874abba90fc9b4a395d949b4fab14c2e]

        Replace "size() == 0 with empty()" (ucb)
        
        Change-Id: I82a97841d4d02d6d4388be17f5b3c87bbf0c325f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161470
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [ec4ce4362a8d33f5608f62a11e1ed84b8dc448a4]

        Replace "size() == 0 with empty()" (vcl)
        
        Change-Id: If93925fca6c0bb27ea5570d500e13b195b993f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161471
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [43c03ebc221db18b6980fbe592cce11cbb46dd49]

        cid#1545219 COPY_INSTEAD_OF_MOVE
        
        and a bunch more like that
        
        Change-Id: If32196d407a2ae52c41204d9ee7b36e2dc514a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161454
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-31  Julien Nabet  <serval2412@yahoo.fr>  [e683cf0a63a54c8b034e00e888923926c9f9e349]

        Replace "size() == 0 with empty()" (sw)
        
        Change-Id: I4768ee9f99000b6402b45b55cbff7ea9150218b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161469
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2ccb21c26f0627318f0250d4b24973cd41a62f61]

        Remove duplicated include
        
        Change-Id: I64436766ca0274e0877c861db3ffdb9d87f5e12a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161462
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5b4dfce8933b1a2c18b9fc00d2b8a9a8ce37b510]

        editeng: cleanup operators and constructors for EditSelection + test
        
        Move the constructors into class body, cleanup operators so they
        use more standard class based operators and use default for !=
        as it will just be a neagtion of ==.
        
        Change-Id: I1b99db6c9a82468ab76091eb93a5f3641024c65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161365
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-31  Mike Kaganski  <mike.kaganski@collabora.com>  [025a49a40a3c0c1be5bf4383e87a1cc60014b7f4]

        tdf#158942: renderMethodToUseForSize may force raster surface
        
        Maybe there is a way to avoid this path for the situation of creating
        small raster surfaces like tooltips, but I have no clue how to do it.
        
        Change-Id: I5ab6ccad572e0efd682bf3ef850b68b6b1941537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161460
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ac481d5df48c9db1f662903af52a5dd50bbe66df]

        editeng: cleanup operators and constructors for EditPaM + test
        
        Move the constructors into class body, cleanup operators so they
        use more standard class based operators and use default for !=
        as it will just be a neagtion of ==.
        
        Change-Id: I6534db60dcb23cb3daefb91d5f27579a690a9637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161364
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5c1f9ec049a724071bd47bca2d76553c0dfb1718]

        editeng: move EditSelection into its own header file
        
        Change-Id: Ib56a0d308de700097470d26ebed3dc90d583b616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161363
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [291fe245284806538d74b40d45dfa20b3fbab172]

        editeng: move EditPaM into its own header file
        
        Change-Id: I13c5d4f2ea0bd7ef942ac0cacb9dce4b58909b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161362
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-30  Weblate  <noreply@documentfoundation.org>  [6fe0a54f5503cca07b3c0c75e2c4fbc7aece2901]

        android-viewer translated using Weblate
        
        Hungarian currently translated at 50.8% (60 of 118 strings)
        
        Change-Id: I827a786aca47cb057e3c822d04aba13906ebef2d
        
        Added translation for android-viewer using Weblate (Hungarian)
        
        Change-Id: Ic660281a13f5b4a1ad0d0bd35618038d143c1994
        Co-authored-by: Gábor Kelemen <kelemeng@gnome.hu>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hu/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161304
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2aeeb7647f5858a21091d89f201ec71959ef7d31]

        SvtAccessibilityOptions no longer loads settings
        
        Change-Id: Ia7404122029b6b7c6fe7ff879bb1143b3419fc32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161239
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ebae130b0978f48af555a1f19f56685d3b3414e8]

        tdf#146619 Recheck svx/ with IWYU
        
        Change-Id: I99650b50587294c20b1e92270e541140d9ec9cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161240
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [819630ee52ae9e9249bb8e25ca8d97e9b3ce90de]

        cid#1546460 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I562eea9548929f11de2a2b68bba09ae3a777ffe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe25701ae9bdf3b762967f084d5e78166f681e54]

        cid#1545421 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545403 COPY_INSTEAD_OF_MOVE
        cid#1545397 COPY_INSTEAD_OF_MOVE
        cid#1545376 COPY_INSTEAD_OF_MOVE
        cid#1545339 COPY_INSTEAD_OF_MOVE
        cid#1545288 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I0e24a3fc7148d0b7ff8126debe3cddbb4fbdd713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161453
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [a08b519ef1fe4dc3ffd6ab8884068b5db38e1100]

        simplify OutlineToImpressFinalizer, no need to use SvLockBytes
        
        Change-Id: Iaf83db0631ca0041915ccb61335cf2fc2a2142f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161447
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [85aae7580a7cdebc42202c4ee242e076cda7132f]

        no need to use SvLockBytes in SwDocShell
        
        Change-Id: I5edab742faf2acd3bb0af881e1f96f2ffa3b6f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5096d072becf9565b0edec66a872bdb74da1d10a]

        cid#1545965 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545849 COPY_INSTEAD_OF_MOVE
        cid#1545814 COPY_INSTEAD_OF_MOVE
        cid#1545685 COPY_INSTEAD_OF_MOVE
        cid#1545583 COPY_INSTEAD_OF_MOVE
        cid#1545575 COPY_INSTEAD_OF_MOVE
        cid#1545517 COPY_INSTEAD_OF_MOVE
        cid#1545474 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I79a47ee34dace3a4664bfece26c59e719f469cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [d2fd70c655b45f1d4ea570fa0455231d5d059709]

        no need to use SvLockBytes in UriBindingHelper
        
        we already have other, simpler facilities for wrapping streams
        
        Change-Id: Icff4cca2d6327dad9c5964ca61d578506009d047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [ec29db74bf5ffba086f5ced6053814d548616f7d]

        no need to use SvLockBytes in OImageControlModel
        
        we already have other, simpler facilities for wrapping streams
        
        Change-Id: Ic6f88821e089951999395507bc84e68ea339d9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161444
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [04c3ef3c7224644b7e54ff215343391cef77f7b5]

        ImgProdLockBytes is unnecessary
        
        we already have facilities for doing this kind of wrapping
        (removes another instance of SvLockBytes)
        
        Change-Id: Ie3546efe06580f9492d8f6ddbc1a2e904036465a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161443
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [46b06663ae767d3423f2135fa91800cfa304877b]

        tdf#158254: don't shrink to data area when applying to entire sheet
        
        Commit ac859a4c6a7fce4efee9cdd45821a0c9e40e9e9a (tdf#147842 shrink
        selection to data area when applying to entire sheet, 2022-10-18)
        tried to workaround the problem of applying to the massive amount
        of columns. This caused regressions, where it was impossible to pre-
        format entire rows.
        
        This change removes the call to ShrinkToDataArea from
        ScViewFunc::ApplySelectionPattern (it is used elsewhere, so the
        commit is not reverted completely).
        
        Instead, it addresses the bottleneck in the bugdoc in tdf#147842,
        which is ScAttrArray::RemoveCellCharAttribs: since the document
        had hidden rows, selecting all made multi-selection split into
        separate stripes, and the fulction was called repeatedly, and
        itself called ScEditUtil::RemoveCharAttribs for every cell in
        ~ 1000 columns * 1000000 rows, even though most of the cells in
        that range were empty - so no char attribs could exist. Asking
        for the last used row (the same as done in ShrinkToDataArea)
        makes the operation fast again, and keeps assigning the format
        to the entire range.
        
        Change-Id: I9635ea1a392b3a1e048c0888f4786a3628675fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161442
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [427d8f61d7bc4087a9408ba7f0b8a718943f4240]

        cid#1546349 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546236 COPY_INSTEAD_OF_MOVE
        cid#1546126 COPY_INSTEAD_OF_MOVE
        cid#1546042 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I24b60d855f564ba8551501fc1dc614b24d5505c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161440
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Martin Srebotnjak  <miles@filmsi.net>  [9e00b676ee500aa46ce539f4adf8c4de73039b36]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2a46004be910e61d7a2d7c3cbc09e773654d4095
          - Updated Slovenian translation
            
            Change-Id: I0d82b9e27efc285b815382c3adb6f51e18776bcf
            
2023-12-30  Arnaud VERSINI  <arnaud.versini@pm.me>  [5b93f1f7cbbec881d13e573a5901a5d353e0dd54]

        starmath : remove useless delete indirection
        
        Change-Id: Ib308ce7735bdd1dea8611b08a8b73dd2686ca0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161387
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>

2023-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [7e5a345897e633083ce0194a34c4faac54d28371]

        tdf#158254: generalize and use algorithm to apply with allocation
        
        Commit 17bcf1073bf21088b9845e36fe735622d8f88fd7 (introduce ScColumnData
        for ScColumn/ScTable code sharing, 2022-05-05) implemented an algorithm
        to only allocate needed amount of columns, and/or apply to default data
        when needed. It was done for ApplySelectionCache, ChangeSelectionIndent,
        ClearSelectionItems. Yet, many other functions need the same approach.
        
        This change introduces ScTable::ApplyWithAllocation template, which
        allows to use this algorithm uniformly to any operation on a selection,
        which ultimately applies to ScColumnData. The code in the functions
        mentioned above is replaced with its use; and ApplySelectionStyle is
        fixed using it.
        
        Change-Id: Ic8890d9980fcb01b61bb111183b355c623f866a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161441
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [020444ed98d7a31403787238cd753e112a6a56fb]

        editeng: move EditLineList methods definition into header
        
        Class is simple enough and more or less just wraps the vector
        anyway.
        
        Change-Id: I65a2980e8dd3c70b87e617920db623782d43b1b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161361
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4acb0979b10bf35cf929078e53ccccea249e1416]

        editeng: move EditLineList to its own header file
        
        Change-Id: Ic19aa0826050a768e9976d8d3db9eadb108607f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161360
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9a62dcf59af3513a82fb5640314021d064d8b9b7]

        editeng: move impl. of EditLine methods to own cxx sourcefile
        
        Change-Id: I9856302967de59368dc60b3e01f4a36fdb97e00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161359
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [72fde57386eb7b53f4b1a0954a1595e36cf17e5f]

        editeng: EditLine test and refactor constructors, operators
        
        Change-Id: Ia60ce07073725bf66bf299edaf7b3cd24cfe59c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161358
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [7de4661827c5bed7beaf2c286242e48cfe4154e8]

        no need to use SvLockBytes in forms
        
        Change-Id: Ide586997d504e0fbdb72aa1db77c49ba3d6007c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [39d0ab03fd064ff0582d98d5c52a0d3747e73999]

        drop some IsFuzzing spam we don't need
        
        Change-Id: I1da86b0be73713b506044c969930912b58b4d514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0a8b5b81d6be08de6e0d504616a1f09830f7c38]

        move IsFuzzing to comphelper
        
        and try something a bit more generic
        
        Change-Id: I1d8256576cd02f0a589df350ba7b53059dd586a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161250
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [2c8e9ed3cbe3aed5520ce8f5888dd083f8ee50c3]

        Simplify a bit
        
        Change-Id: Ic2fa4c0a1c7424ff2114c494d0c4e06a3f8b1cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161439
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [76094232350d01ab7dabdc8f7c0043fa5c6ff4c8]

        No need to decrement the position for Hole portion case
        
        Otherwise a click to the right of a centered paragraph in DOCX with
        trailing spaces would put cursor before the last space, not after.
        
        Change-Id: Idc0cb1b69f7271e1f9af2e23389aaf11adcbd186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161438
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-30  Andras Timar  <andras.timar@collabora.com>  [07add037d7845cd31e47efca84b869ca9355eff4]

        tdf#77915 fix import of default shape fill color
        
        Change-Id: Ibbb1ec508dcd87512b4f4b6da8729255c7ed9fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161396
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [853e13f9146e83b959bc53152ec103470d55fb4f]

        tdf#57187: make sure to put trailing blanks to hole portion in narrow lines
        
        This needs to avoid special processing of trailing spaces after some tabs
        (tdf#106234). Also it needs to allow cursor movement over the newly added
        Hole portions.
        
        It turns out, that it also simplifies the fixes for tdf#104349 and tdf#104668.
        The special handling of paint of the trailing blanks is not needed, when the
        trailing blanks are SwHolePortion, which doesn't draw any background. Also,
        there's no need in special code in SwTextGuess::Guess for that case.
        
        This required to enable creation of the hole portions also for left-aligned
        lines, which were not adjusting break position correctly, because of a wrong
        condition that could never be true.
        
        Change-Id: I0e391be7b1caee4277a505368c3b13a00b5d9506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161400
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-30  Noel Grandin  <noelgrandin@gmail.com>  [3653efd060a50ea40023ebe024352492f27ab925]

        use more unique_ptr in StgTmpStrm
        
        Change-Id: Ib2d598323f94e76e90fc5fef68094dfefba6d3c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2ffe4a6580a17d178794fabeba6916c1ff4c744c]

        editeng: move EditLine in its own header file
        
        Change-Id: I21cac4a8899f96da420428c4eb110078c740615a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161357
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Bogdan B  <buzea.bogdan@libreoffice.org>  [4871de96cb5e31e5ab06cf97e02e09e0e04a4de8]

        tdf#158803 Remove unused imports from wizards
        
        Used pyflakes to find unused imports from wizards module. Then, removed
        those unused imports.
        
        Change-Id: I27f1c38871eafb57a5f914f4de3f825889b4ac68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142522
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [4bea19cf84c125ab3f66dbb40d2379f2d385a865]

        tdf#158743 use maCurrentTransformation for embedding
        
        Seems to be an error in the preparation to Bitmap conversion
        in VclMetafileProcessor2D::processTransparencePrimitive2D.
        While for calculating the LogicRange maCurrentTransformation
        is used (and that is correct) it is *not* used in the embedding
        for calling convertToBitmapEx.
        It is correct to get back to logic/world coordinates for
        calculating the embedding, but maCurrentTransformation is
        needed to define the correct full embedding.
        I might have overlooked that in the original change because
        maCurrentTransformation is local to the VclMetafileProcessor2D
        in action right at that moment and is usually empty for simple
        cases, but - as can be seen - not always.
        
        Change-Id: Ib2deaa2c8328655ecc80964ba2e23e67964ac3ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161409
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d048de6e9fb9197250e924553d46fd6ec4820cb9]

        ofz#65377 Timeout
        
        reduce further to 120points
        
        Change-Id: Idf9892ae01fb6ff3e6cf9b064c2999da9a3a94d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-29  Noel Grandin  <noelgrandin@gmail.com>  [02f8e04778596e4395c01271540298a044eee17a]

        use more concrete UNO types in sw
        
        Change-Id: Ie8dafd99a95ccbae724e7c37b49da01763a4ed42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-29  Noel Grandin  <noelgrandin@gmail.com>  [c921e11a4c2a282279aef9e9a72199478240f728]

        use more concrete UNO types in sw
        
        Change-Id: I00e5222fa0943543fb5f1993a040d0836a8c9c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [e36d6dfb7674af25624aa873964b98f84e012b29]

        Avoid one more expensive ScPatternAttr compare
        
        Change-Id: I2dc3f81ea3e44a335eea2a85df30390236d53299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161402
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-29  Bogdan B  <buzea.bogdan@libreoffice.org>  [6e67802648356a00cdbe9e2e6770199e227a03cd]

        tdf#158803 Remove unused imports from odk
        
        Used pyflakes to find unused imports from odk module. Then, removed
        those unused imports.
        
        Change-Id: If1a160fa99f0c3581687faecb0c7051625c478c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158821
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-29  Julien Nabet  <serval2412@yahoo.fr>  [db69ae30592c1621d73d6c75718f692ef1ab1154]

        Use emplace_back instead of push_back (xmloff)
        
        Change-Id: I9ef16abe07129d1ef8190cca5a094f0135f2a3de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161405
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-29  Declan Fodor  <declanfodor@gmail.com>  [a8cd20ab56863413c2dc7d8c7f5f8c7f742e279d]

        tdf#157638 Added to git blame ignore list
        
        Ignored commit that removed outdated debug comments in
        writerfilter/source/dmapper/GraphicImport.cxx
        
        Change-Id: Ib965f8d085aee01471ff6ea38ac5ba958e938152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161233
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-29  Julien Nabet  <serval2412@yahoo.fr>  [38291dec4bd8d3f8a05f23d014a69ab3b24b4f29]

        Use emplace_back instead of push_back (connectivity/mysqlc)
        
        Change-Id: I27b77455919efed2bf8fbc7c063a8e9221ea2816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161406
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-29  Julien Nabet  <serval2412@yahoo.fr>  [d727f58d73014a3fb4e7eb7f0a29ec4d4599090f]

        Use emplace_back instead of push_back (writerfilter)
        
        Change-Id: Ic09353c1c99265c789edb745044b0afe7dffbee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161404
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-29  Julien Nabet  <serval2412@yahoo.fr>  [7982d59c98a671ab65e24c1a459d78a967fd1d77]

        Typo: opertator->operator (drawinglayer)
        
        Change-Id: I20128a8e0068e6eb29af9e7114100fb437e9e079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161407
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1d28d0b800543dfcd2347cdd9bfc359ade3194a3]

        Fix typo
        
        Change-Id: Ie63bad4bd2ab19ed1557ffc8648500c1183692e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160203
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e0afa422cb62443e0fca7668df1fdd938fc76e6]

        ofz#65329 Fuzzing build failure
        
        since:
        
        commit 9cc8457abcae57c7f9de6e0fbca1fbc2a0cc9892
        Date:   Fri Dec 15 23:09:19 2023 -0700
        
            tdf#128122 Updated BASIC CCur to reuse SvNumberFormatter
        
        LibreOfficeOssFuzz.conf has --enable-ld=gold and that will just
        crash on an unresolved symbol without any explanation, but building
        without will give something useful, e.g.
        
        sbxcurr.cxx:(.text._Z14ImpGetCurrencyPK9SbxValues[_Z14ImpGetCurrencyPK9SbxValues]+0x89f): undefined reference to `SbiInstance::GetNumberFormatter()'
        /usr/bin/ld: sbxcurr.cxx:(.text._Z14ImpGetCurrencyPK9SbxValues[_Z14ImpGetCurrencyPK9SbxValues]+0xbf7): undefined reference to `SbiInstance::PrepareNumberFormatter(unsigned int&, unsigned int&, unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag> const*, DateOrder const*)'
        
        Change-Id: I4b555760a609ec04fd85f7ba9c198a3d2ac712c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e48dbe4f14da4677db631edffc5275c3c24b3ede]

        Resolves: tdf#158608 put calc spelling suggestions at start of context menu
        
        a problem since:
        
        commit 57544b075b77331b7b1cc7cb18898a52e7bb21a6
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Sat Dec 12 21:21:09 2020 +0000
        
            weld editview menu
        
        Change-Id: Id2ffd7f4f3da15d5c0ebc1c7a17247e8ab1ec5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-29  Declan Fodor  <declanfodor@gmail.com>  [1c235c1343ed7b88a3e6b923b9b0d6e567054f1c]

        tdf#157638 Removed old comments
        
        Certain numerical comments in GraphicImport contained
        debugging information that is no longer relevant to the
        current code. These have been removed.
        
        Change-Id: I931cd8dae6d1e449211d78eedd5422994b8c4423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161232
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-29  Michael Meeks  <michael.meeks@collabora.com>  [d7bbd8363e3a6856fb7039050b45a5ea0a626f29]

        trace events: fix deadlock from non-recursive mutex.
        
        Release lock over s_pBufferFullCallback:
         #4  std::lock_guard<std::mutex>::lock_guard(std::mutex&)
         #5  comphelper::TraceEvent::getEventVectorAndClear()
         #6  0x00007f2367c61836 in comphelper::TraceEvent::getRecordingAndClear()
         #7  0x00007f236877263e in (anonymous namespace)::TraceEventDumper::flushRecordings()
         #8  0x00007f2367c60cb7 in comphelper::TraceEvent::addRecording(rtl::OUString const&)
        
        regression from:
          commit c2424341ed444647d979a69ae55268e96fad3d56
          Date:   Sun Jan 30 10:30:27 2022 +0100
            comphelper : use std::mutex in traceevent
        
        Change-Id: Ic89d63d14f06d710937a4da759976ae308c9df45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [06fe555abb0a482ecf2b2b94e6a8a4dcb26649ce]

        add some more libraries to libmerged
        
        and fix some resulting symbol name clashes
        
        Change-Id: I57b11494742ef74a97e0afb294b4e44813eaa249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5c198a8d1345a5f658a46085de9cdd76d49a959e]

        editeng: simplify and remove unneded const. of ContentNode & co
        
        ContentNode, CharAttribList, ContentAttribs constructors and
        destructors can be simplified and in some cases removed (if they
        are empty).
        
        Change-Id: Id5b1d4c1934a9b0b6e0ed8a7fe2af0d41ce4b4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161356
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [62aee46df1f8e4b863e2927e0b9d3b6bcd270008]

        editeng: move source of ContentNode & co. to own sourcefile
        
        Move ContentNode, CharAttribList, ContentAttribs methods to own
        source class.
        
        Change-Id: Idd1371430ecaf36431de763dc4e3e3978ba60641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161355
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d9fc8e10aa24d5b34f0d86f84286ba13cee8c563]

        WaE: some --disable-scripting warnings
        
        Change-Id: I697293adb151e3f1ed57971ec203698383d2a237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [843bfb382fa9ed4bfab8ef758ebb44a7c5a2de9d]

        Fix typo
        
        Change-Id: I917bf16ef48eb2c513d54e19ff6ba482323ebf2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161399
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-29  Bogdan B  <buzea.bogdan@libreoffice.org>  [605c2888786b02e34ab586aa462cc1e84843dad2]

        tdf#158803 Remove unused imports from bin
        
        Used pyflakes to find unused imports from bin/ folder. Then, removed
        those unused imports.
        
        Change-Id: I439dbc443d6da6d82700ff9caf2f4f2677f46b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158819
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [beb2b1d6b1b23e941d1a6a34dc68a16ec7167c1b]

        editeng: prefix members of ContentNode, CharAttribList, ContentAttribs
        
        Change-Id: I2af96b6525ee0d4410200775ce4daf71bcc80db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161354
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ea526b0af721587b1725ce95e7ce42fb463e4187]

        editeng: move ContentNode & dependents in its own header file
        
        Change-Id: Ia492dacafb88d42ab3dcdae8af9843d3586dffbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161353
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [985b6c4a7fd00d1859ce3a32ab141d94526e989c]

        editeng: ItemList - prefix members, move methods in class
        
        - Move methods into class def. as the class is simple enough.
        - Prefix member variables.
        - Remove unneeded includes.
        
        Change-Id: Ide567c64dad3606f1a9faf837571ae2a5c3d69ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161352
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [27afa3fa1321bc55d6063115c4ad3558d68eb76e]

        editeng: move ItemList in its own header file
        
        Change-Id: I52f3f2a557db7058aa584ca7c1cee08eae58d726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161351
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Mike Kaganski  <mike.kaganski@collabora.com>  [aaff1bfa765539068d837404ca016608490aaf11]

        Simplify a bit
        
        Change-Id: I4b88160f27434588730082fc0b6853ba10df4603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161411
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-29  Mike Kaganski  <mike.kaganski@collabora.com>  [f011086f38775182ed3e05fc7a79ddfd8605af19]

        Avoid static_casts
        
        Change-Id: I57d7aa4cf7dbadc5a40b69da789a16a269c92544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161326
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [629f55de24aca6eed7cb3bb8ad2bd8f4a6593d46]

        editeng: simplify FormatterFontMetric
        
        We don't really need a custom constructor and default values can
        now be set directly.
        
        Change-Id: I7e8aabf2c60d3b63abf1764bbff512685803f71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161349
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1958805f61612a7b23f1c5c2d532be4d5dc24a2a]

        editeng: move TextPortion to own header file
        
        Change-Id: I54d0bbad4ef142705191672319774f26abf3e735
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161348
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-29  Arnaud VERSINI  <arnaud.versini@pm.me>  [0f6f5048d223731aa52b768a77244d0208711391]

        use string OUString literals in a11y for XServiceInfo impl.
        
        Used in getImplementationName and getSupportedServiceNames
        
        Change-Id: I003db960123c66d4d47b99aec678b156bf4c4d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161301
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [029d761b92d7a5754ad7066238b8c20ae420d263]

        simplify this a little
        
        Change-Id: I839a5b2277be4a03432d83177228e647ec7a6b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161393
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-28  Justin Luth  <justin.luth@collabora.com>  [4399bccc5ee5a3fa69a8818e7ae265c144d33d64]

        tdf#158826 rtfimport: ignore page break before document starts
        
        This avoids a 24.2 exposed bug from my
        commit 016f779ee6c7f601be3ae19dc57497e63a5bf817
        
        RTF import simply cannot be relied upon to create paragraphs
        where they need to be. A side effect of fixing frames
        is that spurious paragraphs can be created,
        and if a frame starts the document, then an otherwise
        ignored page break can be attached to the second paragraph
        and thus become exposed.
        
        This seems pretty much like the RTF implementation of
        what was done for DOC and DOCX for tdf#118711.
        At least it is related.
        
        make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158826_extraCR
        
        The following unit tests trigger this code (with no visible change)
        abi10076.odt  tdf121623.rtf  tdf129513.rtf  tdf131963.docx
        
        Change-Id: I21afa826b6f6fbb735591603a0620b8b47de517e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161374
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-28  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [ba2bd49397725fd07ed36aefe2acc4d2be70c72e]

        Fix tooltips
        
        * Correct some path names.
        * Change some context names.
        * Replace "&gt;" with "-".
        * Replace "▸" with "-".
        
        Change-Id: I0d2ff04f45fd1985e7e579e57add2a468d13e731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3314d4f9a6461f569d12ad0fef51eef26c5510c2]

        kit: update formulas in frozen area
        
        when the main pane has scrolled sufficiently that those areas are off
        screen from the main pane perspective.
        
        In kit mode while there can be (up to) 4 panes, each pane is considered
        to be at cell 0, 0 and of the same size as the window.
        
        Unlike desktop mode the information as to what ranges are shown when
        there are frozen rows/cols is instead available via LOKSheetFreezeIndex
        
        commit daaf101ffe683eb691418ec2df4adc260d7e6a15
        Date:   Mon May 7 12:49:22 2018 +0200
        
            lok: sc: formulas were not updated correctly
        
            this patch fixes several issues:
        
        commit 0ef7bc8a1d2f00715d6849f1bbceb26e32382d41
        Date:   Fri Mar 29 09:01:05 2019 -0400
        
            sc lok: avoid save incorrect data, whether the pane has ...
        
            horizontal / vertical splits
        
        commit 7b4802070ac6fb930255536bf3ed2c52428b4181
        Date:   Wed Jul 15 15:55:45 2020 +0530
        
            lok-freezepanes: Generalize FreezePanes* uno-commands...
        
        commit 818b7e508bcabae48cb1c96c987a9f83d83ff6e0
        Date:   Wed Apr 21 18:28:13 2021 +0200
        
            lok: calc: formula breaking to multiple lines partly shown in edit mode
        
        Change-Id: I1e55f7bbc0df5c6fd09a10e261d25c1ce00a243a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160995
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161270
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10e7d8d1dcf0e3a45044643ab7b572af997543e9]

        cid#1545240 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia8cf79801769f3d5026770d1edce0fa6daaad475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161370
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-28  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2e1f9da8a6359c8909e087a92239aefd4851b116]

        Decouple ScPatternAttr from SfxItemPool
        
        ScPatternAttr is traditionally derived from SfxPoolItem
        (or better: SfxSetItem) and held in the ScDocumentPool
        as Item.
        
        This is only because of 'using' the 'poolable'
        functionality of the Item/ItemSet/ItemPool mechanism.
        Lots of hacks were added to sc and Item/ItemSet/
        ItemPool to make that 'work' which shows already that
        this relationship is not optimal.
        
        It uses DirectPutItemInPool/DirectRemoveItemFromPool
        to do so, also with massive overhead to do that (and
        with not much success). The RefCnt in the SfxPoolItem
        that is used for this never worked reliably, so the
        SfxItemPool was (ab)used as garbage collector (all
        Items added and never removed get deleted at last
        for good when the Pool goes down). For this reasons
        and to be able to further get ItemSets modernized
        I changed this. I did two big changes here:
        
        (1) No longer derive ScPatternAttr from SfxItemSet/
            SfxSetItem, no longer hold as SfxPoolItem
        
        (2) Add tooling to reliably control the lifetime of
            ScPatternAttr instances and ther uniqueness/
            reusage for memory reasons
        
        It is now a regular non-derived class. The SfxItemSet
        formally derived from SfxSetItem is now a member. The
        RefCnt is now also a member (so independent from
        size/data type of SfxPoolItem). All in all it's pretty
        much the same size as before.
        
        To support handling it I created a CellAttributeHelper
        that is at/owned by ScDocument and takes over tooling
        to handle the ScPatternAttr. It supports to guarantee
        the uniqueness of incarnated ScPatternAttr instances for
        a ScDocument by providing helpers like registerAndCheck
        and doUnregister. It hosts the default CellAttribute/
        ScPatternAttr. That default handling was anyways not
        using the standard default-handling of Items/Pools.
        
        I adapted whole SC to use that mainly by replacing calls
        to DirectPutItemInPool with registerAndCheck and
        DirectRemoveItemFromPool with doUnregister, BUT: This
        was not sufficient, the RefCnt kept to be broken.
        
        For that reason I decided to also do (2) in this change:
        I added a CellAttributeHolder that owns/regulates the
        lifetime of a single ScPatternAttr. Originally it also
        contained the CellAttributeHolder, but after some
        thoughts I decided that this is not needed - if there
        is no ScPatternAttr set, no CellAttributeHolder is
        needed for safe cleanup at destruction of the helper.
        
        So I moved/added the CellAttributeHolder to ScPatternAttr
        where it belongs more naturally anyways. The big plus is
        that CellAttributeHolder is just one ptr, so not bigger
        than having a simple ScPatternAttr*. That way, e.g.
        ScAttrEntry in ScAttrArray did not 'grow' at all. In
        principle all places where a ScPatternAttr* is used can
        now be replaced by using a CellAttributeHolder, except
        for construction. It is capable to be initialized with
        either ScPatternAttr instances from the heap (it creates
        a copy that then gets RefCounted) or allocated (it
        supports ownership change at construction time).
        
        Note that ScAttrEntry started to get more a C++ class
        in that change, it has a constructor. I did not change
        the SCROW member, but that should also be done.
        
        Also made registerAndCheck/doUnregister private in
        CellAttributeHelper and exclusively used by
        CellAttributeHolder. That way the RefCnt works, and a
        lot of code gets much simpler (check ScItemPoolCache,
        it's now straightforward) and safer and ~ScPatternAttr()
        uses now a hard
            assert(!isRegistered());
        which shows that RefCnt works now (the 1st time?).
        
        There can be done more (see ToDo section below) but I
        myself will concentrate on getting ItemSets forward.
        
        This decoupling makes both involved mechanisms more safe,
        less complex and more stable. It also opens up
        possibilities to further optimize ScPatternAttr in SC
        without further hacking Item/ItemSet/ItemPool stuff.
        
        NOTE: ScPatternAttr *should* be renamed to 'CellAttribute'
        which describes what it is. The experiencd devs may know
        what it does, but it is a hindrance for understanding for
        attacting new devs. I already used now names like
        CellAttributeHelper/CellAttributeHolder etc., but
        abstained from renaming ScPatternAttr, see ToDo list below.
        
        SfxItemSet discussion:
        
        ScPatternAttr still contains a SfxItemSet, or better, a
        SfxSetItem. For that reason it still depends on access to
        an SfxItemPool (so there is acces in CellAttributeHelper).
        
        This is in principle not needed - no Item (in the range
        [ATTR_PATTERN_START .. ATTR_PATTERN_END]) needs that.
        In principle ScPatternAttr could now do it's own handling
        of those needed Items, however this might be done (linear
        array, hash-by-WhichID, ...). The Items get translated
        to and from this to the rest of the office anyways.
        
        Note that *merging* of SfxItemSets is *still* needed what
        means to have WhichID slots in SfxItemState::DONTCARE,
        see note in ScPatternAttr::ScPatternAttr about that. And
        there is also the Surrogates stuff which would have to be
        checked.
        
        The other extreme is to use SfxItemSet *more*, e.g. directly
        derive from SfxItemSet what would make stuff easier, maybe
        even get back to using the 'regular' Items like all office,
        I doubt that that would be much slower, so why...?
        
        Also possible is to remove that range of Items exclusively
        used by ScPatternAttr from ScDocumentPool *completely* and
        create an own Pool for them, owned by CellAttributeHelper.
        That Pool might even be static global, so all SC Docs could
        share all those Items - maybe even the ScPatternAttr
        themselves (except the default per document). That would
        remove the dependency of ScPatternAttr from a Pool
        completely.
        
        ToDo-List:
        - rename ScPatternAttr to CellAttribute or similar
        - use SfxItemSetFixed with range [ATTR_PATTERN_START
          .. ATTR_PATTERN_END] instead of regular SfxItemSet
          (if the copy-construtor works now...?)
        - maybe create own/separate Pool for exclusive Items
        - make ScAttrEntry more a C++ class by moving SCROW
          to the private section, add get/set methods and
          adapt SC
        
        Had to add some more usages of CellAttributeHolder
        to the SC Sort mechanism, there were situations where
        the sorted ScPatternAttr were replaced in the Table,
        but the 'sorted' ones were just ScPatternAttr*, thus
        deleting the valid ones in the Table already. Using
        CellAttributeHolder makes this safe, too.
        
        Added a small, one-entry cache to CellAttributeHelper
        to buffer the last found buffered ScPattrnAttr. It
        has a HitRate of ca. 5-6% and brings the UnitTest
        testSheetCellRangeProperties from 0m48,710s to
        0m37,556s. Not too massive, but erery bit counts :-)
        Also shows that after that change optimizations in
        the now split functionality is possible and easy.
        
        Change-Id: I268a7b2a943ce5ddfe3c75b5e648c0f6b0cedb85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161244
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-28  Julien Nabet  <serval2412@yahoo.fr>  [6af35d077e9b5f5723f90f1589c5d801e79ccd4d]

        Use emplace_back instead of push_back (sw)
        
        Change-Id: I0a7f70ca0e5cc022425bee3661495cf1104f6521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161384
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-28  Julien Nabet  <serval2412@yahoo.fr>  [b33c45422801da708716b1157a7559910b577b5a]

        Use emplace_back instead of push_back (svtools)
        
        Change-Id: Ia70b71062959a58ad51ba4d2a9261ff4e0ce93d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161382
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-28  Julien Nabet  <serval2412@yahoo.fr>  [f012065d14f8dc768b1badceef488336751f4a45]

        Use emplace_back instead of push_back (ucb)
        
        Change-Id: I3cef6ad53d4420d259a038058f989cbdc324fb43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161386
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-28  Gökay Şatır  <gokaysatir@collabora.com>  [df11ff317de859cad000a50999b48e6a25070be9]

        Implement hyperlinkInfoAtPosition for Writer.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ibc71e4ee83625637f726646feb2c0192f3007687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161381
        Tested-by: Jenkins

2023-12-28  Julien Nabet  <serval2412@yahoo.fr>  [b05e660b98d202876806353dff1eb0a5b53e8dec]

        Use emplace_back instead of push_back (svx)
        
        Change-Id: Icf796bba7f4dbfea17e13225b03d7b5b507317da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161383
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-28  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2ddec231d513cf317f9fb2c2a82c7e3a0a2d7ef3]

        Added boolean op's to SfxPoolItemHolder
        
        ...and adapted code to make use of it. This makes checking if
        the SfxPoolItemHolder instance contains an Item or not simpler
        and thus more readable, no need to access the Item* every time
        using getItem() - is okay, but not intuitive.
        
        Change-Id: I8042267cce670aca2641a91cd36285058f17ffbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161380
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [249fb2c6b1b8163bfa4bd6c1fcff000a42d2e967]

        Keep elements of salhelper::TimerManager::m_pHead list refcounted
        
        ...in case client code would release all its references to such an element while
        it is still enqueued in the list
        
        Change-Id: I680aa0af878a0193a388dfe7307007f4c35a1634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161377
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-28  Gökay Şatır  <gokaysatir@collabora.com>  [6fc77c2fa419137abe6e1950eda3d4a0bffe105e]

        In readonly mode, we restrict many events like click.
        
        In readonly mode, Online users need to be able to click on a hyperlink and get the related info.
        
        For this purpose, this PR adds a new function template that sends the hyperlink info if there is any at the clicked position.
        
        I will send the implementation with the next commit.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I886ea22a7097aac73ade0da78a88ddfc95ad819c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160022
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161372
        Tested-by: Jenkins

2023-12-28  Mike Kaganski  <mike.kaganski@collabora.com>  [a22ac6caece8da5add6800bdfba9865bdcfde064]

        tdf#158900: make sure to not break after spaces before \n
        
        Change-Id: I9af98e270090530fc9bd621fbbcdf0ba35d0107c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161378
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [a0e64251d98a8cd8506bafe3a71bff7eb0ac2bc9]

        Drop SvtAccessibilityOptions_Impl class
        
        It is not doing anything useful anymore since 2016
        commit 2c8fe2e737b84ecd3dbac36a4fe6bd061bbd3bae
        when all setter methods were removed as unused
        
        Change-Id: If82c2d0a8007132d9521b43075506db5f8fa4389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161238
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9cf4e435c4131fbfeb241d8f5d73b8b300041b79]

        Fix typo
        
        Change-Id: Ie4af9884dca493646636dc60a1605a748d50ad1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161376
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-28  Mike Kaganski  <mike.kaganski@collabora.com>  [4904da4ba40c0ca1a77ef0e6f0df6ce68a147029]

        Flatten a bit: !pNode was excluded above
        
        Change-Id: If109ff4b5cfbb45ae7844765a4f615b6b77c6c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161324
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-28  Mike Kaganski  <mike.kaganski@collabora.com>  [56fa314c518fa094411f553e1b97dcd9e8860c73]

        Simplify a bit
        
        Change-Id: I4a78ef11e7ed87e231548773669a3e057d09364f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161375
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [feb035b265210379ed81511d1694466b28695ff3]

        editeng: ImpEditView - clean-up UNO types
        
        use com::sun::star namespace as the base for UNO types
        
        Change-Id: I5ce71f21a914f4653d908162f5ec6f773023165e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161347
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8530c6a25a9ce258e58eb657a9cdd200ba1a30d2]

        editeng: prefix ImpEditEngine pVirtDev, pRefDev
        
        Change-Id: I4e215b374178314a836cfddb0107b8cdbe6c1f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161346
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a26ff6a061ca2ec8fb51123b732288d44a536bf5]

        editeng: unneeded forward declaration
        
        Change-Id: Icd97c2d382fd9495c67071e08362de0bd4985bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161350
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [357ab973db8d33290bde1558af52d4f8d5e065c4]

        editeng: move inline methods into ImpEditEngine class
        
        Change-Id: Id9e6e1a4308b7f7d0384a1b28c7279aaa3c716f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161345
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ecc154cd2a4574a8b9754c0ee7c8eeee9afc56e7]

        editeng: move EPosition in its own header file
        
        Change-Id: I6362bfdde31e276c006be3799839e9c1ff4f82f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161344
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [aa2376eb12b02ae88399412495b035f1ddce3b72]

        editeng: simplify and clean-up EPaM
        
        Remove copy/assign operator as they are not needed because they
        are the same as default.
        
        Change-Id: I1a71e5de8024680307a65e8b5540b250178f0a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161343
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ff0a9cb65ae5d862575b091c44e114c117e9f3b5]

        editeng: add EPaM unit tests
        
        Change-Id: Icc15746bf2712bae446f16fd378f94f8be5ec61e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161342
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9c40b820280843450cab4287d7cfbdc0988064e4]

        editeng: move EPaM in its own header file
        
        Change-Id: Ib3682dd5df09162748aad4402108b2b3cec3a853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161341
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5d579ddc04d2862861a9b948ebc12ace74fc122c]

        editeng: simplify and clean-up ESelection
        
        Change-Id: I8c0ee3f6b0f4e20277e006c15fddbda6ba9c05e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161340
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [23bef8567e839a3894deb3fd05f1c237d2dcc14f]

        editeng: add ESelection unit tests
        
        Change-Id: I79cff7b08944fe81c785c224587e4e6f6c8ff9c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161339
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [29097009b1f8c0dcb050367d3f2acfcaf2074a56]

        editeng: move ESelection in its own header file
        
        Change-Id: I46fbaf9fea8308169f2ada19787684c87b0c3c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161338
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [7c1a359663355fac356e1eccf76f3f0247d4e3c6]

        vcl: BreakLines() -> BreakLine() and BreakLinesSimple() -> BreakLineSimple()
        
        Change-Id: I8cb778a09566c1b7d6c2ba4ac5766a5675e62465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158465
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [938d3b35b83093de4e310d32de5137f6bdbcf22b]

        vcl: test BreakLinesWithIterator with hyphens
        
        Change-Id: Ied5e688b9eec19c2f1b3d1289cc4a6605703c3e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157904
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [9157281deb81522bb02af73a08c4d7beed7aab75]

        vcl: add test for an invalid index in OutputDevice::GetTextBreak()
        
        Change-Id: I0b534e42e041972ad2f92e789fc757e949a33d4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158394
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2e8332ea9b0b18347fdf5407925da3bc1305a93]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58b85d5d8886f116064102e38d98e494643fb55d
          - tdf#155876 UI cmds Calc-Sheet menu (38)
            
            + Data menu for Calc, Pivot tables.
            + refactoring
            
            Change-Id: Ie9a39198d84b180558b8d84681cf2f455b3e2e6f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161373
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-27  Bogdan B  <buzea.bogdan@libreoffice.org>  [f727a1bc203369dc33f912cbf9f0fc0e6bc67ec8]

        tdf#158803 Remove unused imports from desktop
        
        Used pyflakes to find unused imports from desktop module. Then, removed
        those unused imports.
        
        Change-Id: Iccc0661ed586a717f4e5c69c238cbf70d6de0b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158820
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3bd2240ca6e5bfbd41631a252eb4244d0f8c9843]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 414d3e7a7b14469df61c49ea030563c2b4093264
          - tdf#155876 UI cmds Calc-Sheet menu (37)
            
            + Data menu for Calc, DD ranges.
            + refactoring
            
            Change-Id: I467b4c0b654874ca8356908a0c6fb75175f579bf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161369
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-27  Patrick Luby  <plubius@libreoffice.org>  [cefd36db5f9389dd6f7e605eca6711762a784966]

        tdf#144124 Detect if ownership has been lost
        
        The shortcut assumes that lost ownership notifications from the
        system clipboard will happen elsewhere. They do under normal
        conditions, but do not when some clipboard managers are running.
        So, explicitly check ownership to catch such cases.
        
        Change-Id: If54ca8c9908650c23c348e08231820ee7c2483e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161337
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-27  Chenxiong Qi  <qcxhome@gmail.com>  [8b6e0dd9e47c20a79fd194f6d530d1c868911bda]

        tdf#158803 Fix issues detected by pyflakes
        
        Change-Id: Iaa329dff61db894e7d5fecd840e785a53a48b26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160889
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-27  Julien Nabet  <serval2412@yahoo.fr>  [7ad6ae594fd92b736b4217268eea47c71c04c34a]

        Use emplace_back instead of push_back (Formula)
        
        Change-Id: I6596e9d002016e5b501900fe9da26b5910cf7653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161307
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [1d1d5522ed3eec4f19887feec6765f3058930e2a]

        Use rtl::Reference to avoid static_casts, and simplify
        
        Change-Id: I6975d34f0fb65f49be8988d1389f0bebe8ad6bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161368
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0146e891efb8c81c6be0817907899aadd5dd3ee6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f51688cec199b0535a7ed7262dd2266499abc66
          - Housekeeping Help page on Calc financial functions
            
            Change-Id: I6e6e6c3088211e0f1ba625949c27ef82fd749008
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161367
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [4df22b4d3d4ae1ec0c4d32f614bd2cd8ec13143e]

        tdf#158862: check if document is initialized
        
        Change-Id: I5b380c0629a756a5d7f0f06fb95fab996360b821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161366
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [67ec38d8afbe4cc2a16d6396a8bbdc2788c23a42]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2a670f53d8c90aca037007b931c7237658d3f3f6
          - tdf#155876 UI cmds Calc-Sheet menu (36)
            
            + Data menu for Calc, Filters.
            + refactoring
            
            Change-Id: I5bb6d7a8b9b5a60c81d680786b6de372d7815807
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161336
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [243e7105285a4b75a7ca1b4fdb263a8e42d68209]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aa9cf7cb03cc8c9cef9ba5d38189f44286c06b7b
          - tdf#155876 UI cmds Calc-Sheet menu (35)
            
            + Data menu for Calc, Sort.
            + refactoring
            
            Change-Id: I1cbaac58f3bb194b7ed206e68e5ff8f10579ae9e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161335
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [40617d867346956588ac023511f31210107217f4]

        Remove executable bits on data file
        
        Change-Id: Id6d8ccc82f892b098d96e28a7222c58e08e22b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161086
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [66805f57f2770ea0e73eef4781ca218dbf60b1a9]

        Fix typo
        
        Change-Id: I325079efc51bbefb7612403e4800ca5320b49cec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161334
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Julien Nabet  <serval2412@yahoo.fr>  [a5fd75485f9ab6bc22f12d4a6ca907dd6a33c278]

        Use emplace_back instead of push_back (extensions part2)
        
        Change-Id: Ib86f85e6162639d229443cb3026c355c6a659932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161306
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Julien Nabet  <serval2412@yahoo.fr>  [a1b7ae437c9e37cb1fe3063906609b60dc7e7f13]

        Use emplace_back instead of push_back (sd)
        
        Change-Id: I5641a98f26a19efabb3a5eee25e48282d44faca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161332
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Julien Nabet  <serval2412@yahoo.fr>  [79a26ca7e5cb8ae3b78915b1389f03293b710000]

        Use emplace_back instead of push_back (scaddins)
        
        Change-Id: I08b22351a3e75d5accbb3e59890f5e04b8fbb6d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161333
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Patrick Luby  <plubius@libreoffice.org>  [7af5df1d9fc472dc3a770fbff736eafa99d46bde]

        tdf#135478 Reduce sensitivity of horizontal scrollwheel
        
        Problem: at least on macOS, swipe events are very
        precise. So, when swiping at a slight angle off of
        vertical, swipe events will include a small amount
        of horizontal movement. Since horizontal swipe units
        are measured in cell widths, these small amounts of
        horizontal movement results in shifting many columns
        to the right or left while swiping almost vertically.
        
        So my hacky fix is to reduce the amount of horizontal
        swipe events to roughly match the "visual distance"
        of vertical swipe events.
        
        The reduction factor is arbitrary but is set to
        roughly the ratio of default cell width divided by
        default cell height. This hacky fix isn't a perfect
        fix, but hopefully it reduces the amount of
        unexpected horizontal shifting while swiping
        vertically to a tolerable amount for most users.
        
        Note: the potential downside of doing this is that
        some users might find horizontal swiping to be
        slower than they are used to. If that becomes an
        issue for enough users, the reduction factor may
        need to be lowered to find a good balance point.
        
        Lastly, fix the unbalanced rounding of delta X and Y
        values due to using floor() for macOS native swipe
        and scroll wheel events.
        
        Change-Id: I8c0c9a3aa688e411c47ebb5e7500f3a50f6f673b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161278
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-26  Julien Nabet  <serval2412@yahoo.fr>  [0b194702002af52d1e0034d41e497052675eb84a]

        Simplify aPropVector construction in framework/statusbarmanager
        
        Change-Id: I14dfe9f156109c9c098e27fcf88ca9a273e7722c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161308
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-26  Patrick Luby  <plubius@libreoffice.org>  [3d9ee9375d28f0131949ee3c1f86f22dcea41d19]

        tdf#151679 Do not push FLAVOR_LINK to macOS general pasteboard
        
        When copying text from a Writer document and the
        FLAVOR_LINK flavor is pasted, Writer will edit the
        copied text in order to create a bookmark for DDE.
        
        The problem is that many macOS clipboard managers
        fetch *all* available flavors that are available in
        the macOS general pasteboard instead of just one
        flavor and this triggers the FLAVOR_LINK flavor's
        unusual editing behavor in Writer every time the
        user copies Writer text.
        
        Users have reported in tdf#1515679 that on macOS,
        Microsoft Writer, Excel, and PowerPoint do not
        recognize this flavor like is done on Windows so,
        in theory, we can just filter out this flavor when
        adding flavors to the macOS general pasteboard.
        
        With this change, the FLAVOR_LINK flavor will still
        be visible when copying and pasting within a single
        LibreOffice instance as well as when dragging from
        LibreOffice to other applications.
        
        Change-Id: Ia391398286fa8795ac65b4702a15caf59fb3ae70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161305
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-26  Mike Kaganski  <mike.kaganski@collabora.com>  [1c65d5f8d3d4665e20d4feb17037633c63e4f445]

        Make GetpApp() the pNotifier's default value
        
        It fixes asserts in various places where a message box wants to show
        in Lok case
        
        Change-Id: If3c18e92c131de640281f3365567d66b4e14e1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161299
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [80b5041ea5fbc0ea37fc59edddb4bb7ae90fdc9c]

        cid#1545970 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifbec5f91dd11a495fcf01ad95fcdcc867e882f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f8163aba61c6c2037deb32c61e52a8c4bd38d07f]

        cid#1559882 Uninitialized scalar field
        
        and
        
        cid#1559872 Uninitialized scalar field
        
        Change-Id: Iaea583d63cd1f0a1b68c60adb57c8c1db9a26a9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161292
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd5fda4fef0526262977d5f9262ce09e27286d01]

        cid#1559938 Dereference null return value
        
        Change-Id: I9e4fd4a3c2cf56bb50e765cf64401ac7aa80847c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161291
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa318cc3160841c2b22479cee7bf8941cf7e0d96]

        cid#1559937 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1559939 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic5e581aff9e12c8c6277355b0a8bc99a155dc63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161290
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-25  Irgaliev Amin  <irgaliev01@mail.ru>  [8148dd6ed3c61eaf5f9fe3a060ecda9d11611f39]

        tdf#158023 Add \ before parentheses if they are in the <t> tag.
        
        MSO allows you to write unpair opening or closing parentheses in the t tag.
        The patch adds a backslash before parentheses, which allows you to correctly
        recognize and correctly save such formulas when exporting.
        
        Also add a test to check whether the parentheses are wrapped correctly.
        
        Change-Id: Ib1a941858f0843742b56b8089f3c14983ba1222c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158794
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2023-12-25  Weblate  <noreply@documentfoundation.org>  [11fcb2814ee44e4f9b932e879bb95206e3dbf875]

        android-viewer translated using Weblate
        
        Dutch currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I59c75900254b4124ff7dc8397a943908404e0a5c
        
        android-viewer translated using Weblate
        
        Italian currently translated at 35.5% (42 of 118 strings)
        
        Change-Id: I73561c67beafbeeee4896d7b2301d1b3970eb030
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I83e753b66c856b4fa39cba5bf1de1e44616b1cba
        
        android-viewer translated using Weblate
        
        Basque currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I6e956873841380aabd1351dbbd07f3466ba28275
        
        android-viewer translated using Weblate
        
        French currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I1af1d53bd1daaab3bd0404d8fe75b92e5923b9e2
        
        android-viewer translated using Weblate
        
        Punjabi currently translated at 95.7% (113 of 118 strings)
        
        Change-Id: I7582795194c21cc6c954884bd4612e9cefc01308
        
        android-viewer translated using Weblate
        
        Galician currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ica6acf55e43ec98648b021b9f38871aedf2581fa
        
        android-viewer translated using Weblate
        
        Turkish currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: If8639fcaf3b5b0447c0b00f5fe85ed55d0bb7cad
        
        android-viewer translated using Weblate
        
        German currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I0c5795094434899569e18ae6d87c4bed2e10ea01
        Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Aitor Salaberria <trslbrr@gmail.com>
        Co-authored-by: Ayhan YALÇINSOY <ayhanyalcinsoy@gmail.com>
        Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com>
        Co-authored-by: Elisabetta Manuele <calembour@hotmail.it>
        Co-authored-by: Xosé <xosecalvo@gmail.com>
        Co-authored-by: kees538 <kees538@gmail.com>
        Co-authored-by: sophie <gautier.sophie@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/nl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161274
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2023-12-25  Jean-Pierre Ledure  <jp@ledure.be>  [5fc9908b956fbc87b8b0933a1c8c6bb956e38bbc]

        ScriptForge - Upgrade to version 24.8
        
        Copyright years are also reviewed to include 2024.
        
        Change-Id: I1f30443922a6dc3b35c6f05616a5c4e56de1e396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161277
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-12-25  Mike Kaganski  <mike.kaganski@collabora.com>  [f09420fa189be5165b0311083ba127073500a121]

        tdf#158855: Make sure to not add extra paragraph after a table in a section
        
        Simplify the condition for last paragraph removal in lcl_utext, and clean up
        the complications piled after commit 2e8aad6d45c53d554ccaf26de998ede708cfc289
        (fdo#39056 fdo#75431 Section Properties if section starts with table,
        2014-04-24). This makes sure that the trailing extra paragraph gets properly
        removed, even when there was a dummy paragraph added for a table in section.
        
        Because of the removed check, import used to avoid the removal of the extra
        paragraph immediately following a table (when the table needed to be the last
        element in the section); hence, in DomainMapper_Impl::appendTextSectionAfter,
        a last section's table was followed by two paragraphs (one that is expected
        to stay after the created section, and one before that, that was not removed
        after the table). xCursor had ininitally both paragraphs in the selection
        after the forward goto* calls; and then, gotoLeft excluded only the last
        paragraph from the selection. After the change, in such a case, there is only
        one paragraph in the end: the one that should stay after the created section.
        But calling gotoLeft then would have to put the end of selection to a text
        node inside the table; since the selection that starts before the table can't
        end inside the table, the call resulted in the whole table excluded from the
        selection. This requires to add a paragraph here, to allow the previous
        behavior of cursor; and then the last paragraph in section is destroyed. The
        code makes sure that the trailing paragraph kept after the creation of the
        section has all the properties applied to the old last paragraph.
        
        testFdo53985 used to check for total 9 paragraphs in the document; while
        3 of those were introduced exactly by the bug fixed here; they are absent
        in Word. The test is fixed; its logic is unchanged, and it still correctly
        tests that a round-trip doesn't increase number of paragraphs.
        
        Change-Id: Ibf6349ba7906dac185c759eb3b58c1849ee5064a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161275
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-25  Yli875  <qq3202390739@gmail.com>  [f989ee32b35ee4f0750ae313d35d225d252d64d4]

        tdf#99116 modify menu highlight text color in high contrast mode on win
        
        In high contrast mode, persona color won't overwrite the menu highlight text color.
        This commit fixes this aspect when using the High Contrast theme on Windows, mentioned in tdf#99116 comment 20:
        
        > expanded top menu hover colour is correct but the white text does not invert to black (although this is not specific to the Start Center)
        
        Change-Id: I1575226d966d60af93b5d64934c965f61b8f2d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160058
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-24  Patrick Luby  <plubius@libreoffice.org>  [04eb7f5a47b77511dd7a6e797b66ef2cfffce235]

        Eliminate warning when changing timer's priority
        
        Task::SetPriority() expects the timer to be stopped while
        changing the timer's priority.
        
        Change-Id: Ib025cc1451bf6fa959284d202d29dbb1489beb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161272
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4b818d79f9ba340e27c568bb1531e77e153c8eca]

        Remove listeners of SvtAccessibilityOptions
        
        This class no longer notifies listeners since 2019
        commit 3135d820d0172ef5695a4b97cec505e6ad03d67a
        so presumably the listeners can be dropped as well.
        
        The sd part tried to execute SID commands which seem
        to be removed since 2004
        commit f77ad7f15f53526714518bb3562ba7de4ba0d45e
        
        Change-Id: I81d234aabe10b53278c89ffd846240507854d0c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161237
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a89a42e55f2b154c8b276fe08fcf02c4b9fc0945]

        tdf#158837 hyphenation crash in: int rtl::str::indexOfStr_WithLength
        
        the code was already dodgy, passing in an invalid nPos, which triggers
        an assert.
        
        However, it appears that previously that dodginess was ignored, until
            commit 5ebccaa07589383653dbd65e58204a82dd3cde09
            author	Noel Grandin 	Sat Apr 10 17:27:08 2021 +0200
            use std lib for O[U]String indexOfStr
        which turned it into a crash.
        
        Add a check to avoid the crash, no idea what the right fix would look
        like.
        
        Change-Id: I826b9af0b2d9c7c297214ce2d54c664fb573edd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8b46faa59ecc988c79890ddd2a166f5317a93958]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18e470796f402ef404a12231c9834acbdaefbd0f
          - Fix grammar
            
            Change-Id: Icffc8d455aca78164ab20c1bf8bf95999433fcaf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161223
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5e3af4aec40531b490950da5ed49342a01c1477b]

        Silence new GCC 14 trunk -Werror=alloc-size
        
        > sal/rtl/byteseq.cxx: In function ‘void rtl_byte_sequence_reference2One(sal_Sequence**)’:
        > sal/rtl/byteseq.cxx:63:20: error: allocation of insufficient size ‘8’ for type ‘sal_Sequence’ {aka ‘_sal_Sequence’} with size ‘12’ [-Werror=alloc-size]
        >    63 |             pNew = static_cast<sal_Sequence *>(malloc( SAL_SEQUENCE_HEADER_SIZE ));
        >       |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I9d4081ed2938fffdf282c852250a3eed5f0d9e25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161269
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-24  Patrick Luby  <plubius@libreoffice.org>  [2d514b422257ccf2b53215ee948dda2c9a476d37]

        tdf#158807 Call UpdatePaletteForNewColor with rReplaceColor parameter
        
        Change-Id: Id9d55600c69e84f7d7ffdd9cfbf4e1b3985b79c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161260
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-24  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4663c56edf788a37545f253e028db99e480feb34]

        -Werror=calloc-transposed-args
        
        Change-Id: I7b8b020bdbcd5b4db4cb478cc5fe1225f19ae0cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161268
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [88987316ed0536de6c2c1e407fea4ecf77b5d5fc]

        cid#1545470 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545468 COPY_INSTEAD_OF_MOVE
        cid#1545446 COPY_INSTEAD_OF_MOVE
        cid#1545435 COPY_INSTEAD_OF_MOVE
        cid#1545419 COPY_INSTEAD_OF_MOVE
        cid#1545415 COPY_INSTEAD_OF_MOVE
        cid#1545410 COPY_INSTEAD_OF_MOVE
        cid#1545390 COPY_INSTEAD_OF_MOVE
        cid#1545384 COPY_INSTEAD_OF_MOVE
        cid#1545374 COPY_INSTEAD_OF_MOVE
        cid#1545371 COPY_INSTEAD_OF_MOVE
        cid#1545368 COPY_INSTEAD_OF_MOVE
        cid#1545366 COPY_INSTEAD_OF_MOVE
        cid#1545335 COPY_INSTEAD_OF_MOVE
        cid#1545331 COPY_INSTEAD_OF_MOVE
        cid#1545327 COPY_INSTEAD_OF_MOVE
        cid#1545308 COPY_INSTEAD_OF_MOVE
        cid#1545280 COPY_INSTEAD_OF_MOVE
        cid#1545199 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If05a13125b05ccd93d34d0eced566e7b3b58aaef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161256
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ba12e22f28150ec00d55e4fb99838710a3973e57]

        Drop some wrapper methods from SvtAccessibilityOptions
        
        just use the wrapped officecfg methods instead of:
        GetIsAllowAnimatedGraphics
        GetIsAllowAnimatedText
        GetIsAutomaticFontColor
        IsSelectionInReadonly
        
        Change-Id: I74de75fc9ff2f9a36ef376255e937bb373055587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161236
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-12-24  Gabor Kelemen  <kelemeng@ubuntu.com>  [0b600862ae38c5405779f660226bee8e9cc6e3b6]

        tdf#146619 Recheck include/ with find-unneeded-includes --noexclude
        
        to see if some exclusions became obsolete
        
        Change-Id: Id88351f5448511b35994c58c6cb749784da3b45e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156993
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-12-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9f2bcf335924039ac1b791a12fac8485bb7ba449]

        Remove unused headers found by bin/find-unusedheaders.sh
        
        Change-Id: I859138dee575ef7fd76db28b619c673782914782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161235
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-12-24  Gabor Kelemen  <kelemeng@ubuntu.com>  [f8cd2837493ebcab1ff485e00bfc9181779b49d8]

        Rewrite bin/find-unusedheaders.py
        
        This script was broken, not only in the implementation
        (it gives too many false positives in a suspiciously short, <1s time)
        but in its approach as well: only considering stuff that is compiled
        under Linux inherently leaves out other platform specific or experimental
        stuff.
        
        Rewrite it using another approach: grep for mentions of each
        header in the modules or global ones in include/ everywhere.
        
        Runtime of this script is about 15 minutes, seems to give only
        a few relevant hits.
        
        Change-Id: Ifb92f41f11ca9a2bf14eec617a469003becb78fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161234
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-12-24  Michael Weghorn  <m.weghorn@posteo.de>  [7606097a734ec1f32bb2e3968b44305649523053]

        vcl/README.vars: SAL_FORCEDPI works for all Linux vcl plugins
        
        Running any of the Linux VCL plugins with
        SAL_FORCEDPI=192 resulted in a scaled UI for all of them
        in a quick test, so update the README accordingly.
        
        Change-Id: I57b2b716c84556be6b66ed51f9c5198bacf10030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161264
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-24  Michael Weghorn  <m.weghorn@posteo.de>  [792b6fec15099242ad93e0b6a341c02035f049fe]

        qt: Rename SAL_VCL_{QT5 -> QT}_NO_NATIVE
        
        Similar to
        
            Change-Id: I01b427648ef14f918cc692b30c80a7427455324f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sun Dec 24 00:13:25 2023 +0100
        
                qt: Rename SAL_VCL_QT5_NO_NATIVE and use for all Qt-based VCLs
        
        , drop the version name in the env var to evaluate to
        decide whether to use fontconfig or not, since there's
        no reason this should only apply for qt5-based VCLs
        and not qt6-based ones.
        (Other than for the above-mentioned commit, the env
        variable would already be evaluated for all Qt-based
        VCL plugins, not just the qt5 one.)
        
        Change-Id: I2e239bf78916c37133f3992f49bb5dfa385c5801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161263
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-24  Michael Weghorn  <m.weghorn@posteo.de>  [0b3e088d4888307c0beb3d4e670560e45459f4b2]

        qt: Rename SAL_VCL_QT5_NO_NATIVE and use for all Qt-based VCLs
        
        Instead of evaluating a `SAL_VCL_QT5_NO_NATIVE` environment
        variable to determine whether to disable drawing of widgets
        using the `QStyle`, evaluate `SAL_VCL_QT_NO_NATIVE` (i.e. without
        a Qt version number in the name), and do this for all Qt-based
        VCL plugins (qt5, qt6, kf5, kf6), not only qt5.
        
        I don't see a reason why this should be qt5-specific.
        
        Change-Id: I01b427648ef14f918cc692b30c80a7427455324f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161262
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [28616cf0989dab2ca2a1710c64f6fb1c1d78c584]

        OInterfaceIteratorHelper3 always copies maData contents in ctor
        
        while I think the idea is that the copy on write should only
        be done by OInterfaceContainerHelper3, i.e. that ownership
        really transfers to OInterfaceIteratorHelper3 and OInterfaceContainerHelper3
        makes a new one if that turns out to be necessary
        
        Change-Id: I6e97e3b303f133edbbb35ac23f39cf5348ad49fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161257
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [cfd333f13f85eaf6eaf564e791b55a2092841376]

        zxcvbn-c: disable warnings
        
        Change-Id: I348dc5f92f41fc3e8c1aee8743d5e1cf86fa3bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161259
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [4a532e651b9fd4c9b24b017d2e1d099ee76ceed8]

        xmlsecurity: fix AES-GCM code differently
        
        With PCH, the earlier workaround with NSS_PKCS11_2_0_COMPAT breaks -
        so lets fix this with conditionals, its only two places.
        
        Follow-up commit to 9276d5338ef04209b007bbc705e4c023cf181456
        
        Change-Id: I7d3292304d83d784ee9dce5cdc62b4a028ff333a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161204
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [dbe05a624ca53db83bedbc049791cc215ee6d46b]

        get-bz-attachments: switch to python3
        
        Nothing left to do, just switch the interpreter.
        
        Change-Id: I6a0ff0a019a66f6baf39794c853655f273676ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161261
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [750f53a73fe6b817edc76329488d4b508d57c19b]

        get-bz-attachments: set speaking thread names for job queue
        
        Change-Id: I38d637b8dd0f19330329565bf2e63c3c8463536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161004
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [17f79d80484c5d5b492efd46e2e52481a17e0095]

        get-bz-attachments: some flake8 cleanup
        
        - fix the most obvious stylistic problems
        - add some brief doc strings
        - remove one instance of dead code, left over from this change:
          commit bd2eee0bd4ae83ff453522b7cf09b69f1b8b5e1b
          Date:   Wed Jun 3 23:41:32 2015 +0200
        
            get-bugzilla-attachments: avoid FDO-TDF duplicates...
        
        Change-Id: I88672ae99bc42e9af09ea6033f87240463b2c038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161003
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3c6942a8c64ab35cae7c14b3f64059da4d6ca19b]

        cid#1545525 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545519 COPY_INSTEAD_OF_MOVE
        cid#1545516 COPY_INSTEAD_OF_MOVE
        cid#1545501 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Icc6efaf8c8fe06c7acd629ef77eac6b228b98f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161255
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [401e9408d14dc2b9d07183a04c223831a59f71a3]

        tdf#105844 argon2: add vcxproj files for WinARM64 builds
        
        Also add argon2 to crossbuild tools side.
        
        Change-Id: I8704b2d8362a051c2d634b9db7416cdc2cf9add4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161206
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-23  Jim Raykowski  <raykowj@gmail.com>  [d6a94c51130f62b17b29060fab6befe576e8c078]

        tdf#157244 Enhancement to identify objects in a layer
        
        Show an invert overlay on objects of a layer after a 1/2 second delay
        when the mouse pointer is on a layer tab.
        
        Change-Id: Ifcb2d82d73b8745ad9aecddd18b22193525ed756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159358
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a6298aedb663513c039efccc516dec3188dd8fa]

        cid#1546006 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545999 COPY_INSTEAD_OF_MOVE
        cid#1545995 COPY_INSTEAD_OF_MOVE
        cid#1545994 COPY_INSTEAD_OF_MOVE
        cid#1545989 COPY_INSTEAD_OF_MOVE
        cid#1545982 COPY_INSTEAD_OF_MOVE
        cid#1545977 COPY_INSTEAD_OF_MOVE
        cid#1545970 COPY_INSTEAD_OF_MOVE
        cid#1545856 COPY_INSTEAD_OF_MOVE
        cid#1545845 COPY_INSTEAD_OF_MOVE
        cid#1545838 COPY_INSTEAD_OF_MOVE
        cid#1545776 COPY_INSTEAD_OF_MOVE
        cid#1545774 COPY_INSTEAD_OF_MOVE
        cid#1545744 COPY_INSTEAD_OF_MOVE
        cid#1545719 COPY_INSTEAD_OF_MOVE
        cid#1545716 COPY_INSTEAD_OF_MOVE
        cid#1545687 COPY_INSTEAD_OF_MOVE
        cid#1545648 COPY_INSTEAD_OF_MOVE
        cid#1545643 COPY_INSTEAD_OF_MOVE
        cid#1545641 COPY_INSTEAD_OF_MOVE
        cid#1545604 COPY_INSTEAD_OF_MOVE
        cid#1545531 COPY_INSTEAD_OF_MOVE
        cid#1545530 COPY_INSTEAD_OF_MOVE
        cid#1545524 COPY_INSTEAD_OF_MOVE
        cid#1545516 COPY_INSTEAD_OF_MOVE
        cid#1545501 COPY_INSTEAD_OF_MOVE
        cid#1545486 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idcf3e27bb9e81b6a77d5ef75c9376eb1d6aff8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161245
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f82b8bf05a76ad9cc3fe950f4180c90bce56d79b]

        ofz#65295 Abrt
        
        Change-Id: I074a43191c4af304a2702012d0b810aad801d0d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161249
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Patrick Luby  <plubius@libreoffice.org>  [3e582d9e3fbed8cb94284ac1ab6105cf74eccfe0]

        Related: tdf#158807 mutex must be locked when disposing a VirtualDevice
        
        If the following .ppt document is opened in a debug build
        and the document is left open for a minute or two without
        changing any content, this destructor will be called on a
        non-main thread with the mutex unlocked:
        
          https://bugs.documentfoundation.org/attachment.cgi?id=46801
        
        This hits an assert in VirtualDevice::ReleaseGraphics() so
        explicitly lock the mutex and explicitly dispose and clear
        the VirtualDevice instances variables.
        
        Change-Id: I5d371a4e99fca4aae2b6edc8b53eca10cb143aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161243
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ea1421747985bd09ad40565da8536e857b5c2e9a]

        tdf#157649 Allow omitting Alt key when focus is in dialog action area
        
        Adapt to usual Windows experience: Allow triggering the Ok, Cancel, etc
        buttons in the dialog action area without pressing the Alt key - when
        the focus is in that area (and the accelerator is unique in that dialog).
        
        Change-Id: I85b544867cf5507a15240b2972a26a1c248c4f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161146
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [25d4fae8d3f69dc4d03c1a04233e6ed670742ed5]

        cid#1546064 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546034 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If533400b570f20d80f1c41431ceba81579e0e25d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b803b3a7a1eda1b9862112f399c0a8b988c1f930]

        cid#1559884 Uninitialized scalar variable
        
        etc, since:
        
        commit e9e3576ada06d53de12efed041fb309fe5388e01
        Date:   Thu Dec 21 22:49:27 2023 +0100
        
            svl: fix build with --enable-debug
        
        Change-Id: I1c3c82f0f1674cb46fa6a36d5f9f5cc4435ebef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [1582bde861ad8e556fcf06657e7228980ff284e9]

        Add flush mechanism to buffered Primitives III
        
        There seem to be problems with re-creation of
        SdrCustomShapePrimitive2D primitive presentation
        due to SdrText not being held as
        uno::Reference<uno::XWeak> everywhere. For now,
        try if excluding SdrCustomShapePrimitive2D from
        being flushed helps - may give hints already...
        
        Change-Id: I58373f7dcd81dd24fbf7a0687bb782326ad290fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161190
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cee019927fe3beaf20653e1a98beb85147d14aad]

        cid#1545209 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Idd82be5f2354787735f4e47e8cfe9e9a7371a973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161203
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8013fcadd975d5e72e86afd96de41feaca42a23a]

        cid#1471704 Assignment of overlapping memory
        
        overlapping_assignment: Assigning (*this).nNum[0] to (*this).nVal,
        which have overlapping memory locations and different types.
        
        Change-Id: I70d7236af27bf5399ad5eb5553befd2eb33e37db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161202
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-23  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [4c91770dde40d248af736436716994dc367a54a2]

        Add Thai AutoCorrect data
        
        As part of tdf#158454
        
        Change-Id: Ia81eeb76e8d1fc09d7d19c3c979e30737e5c69d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160159
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-23  Julien Nabet  <serval2412@yahoo.fr>  [22c3eeafc391f867632b3f88e2298d5747706484]

        Fix b26611017a75867efe97b4cf53df96cbd025cc5e
        
        Following Caolán's comment here:
        https://gerrit.libreoffice.org/c/core/+/161185
        
        Thank you Caolán for the review!
        
        Change-Id: I8ac949fccc8a11cf483f679d4c0d2dc16e8c680c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161193
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-23  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [14c4c077182f0338a21ae7dedf862ffff0e339d2]

        ZXing: no need for deprecated utf-8 conversions anymore
        
        With ZXing 2.0, the library directly supports utf8 std::string
        parameters: https://github.com/zxing-cpp/zxing-cpp/releases/tag/v2.0.0
        
        Fixes the warning:
        
         cui/source/dialogs/QrCodeGenDialog.cxx:161:72: warning: 'FromUtf8' is deprecated [-Wdeprecated-declarations]
          161 |     ZXing::BitMatrix bitmatrix = writer.encode(ZXing::TextUtfEncoding::FromUtf8(QRText), 0, 0);
              |                                                                        ^
         /usr/include/ZXing/TextUtfEncoding.h:17:3: note: 'FromUtf8' has been explicitly marked deprecated here
           17 | [[deprecated]] std::wstring FromUtf8(std::string_view utf8);
              |   ^
        
        Change-Id: Ic0a65d4455dabea1a7a4e23f558e4158a0c3f39f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161182
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [0ecedeea71d926f0aa3b2f121e6e896311e6250e]

        zxing-cpp: upgrade to release 2.2.1
        
        * remove 0001-android-Fix-build-with-NDK-26.patch, which was merged upstream.
        * remove DecodeHints from static lib, which according to upstream is not
          needed:
          https://github.com/zxing-cpp/zxing-cpp/issues/685#issuecomment-1853375179
        * add a version header for client code
          generate/update via:
          * mkdir build && cd build && cmake ..
          * mv core/ZXVersion.h ../core/src/
        
        Release Notes:
        https://github.com/zxing-cpp/zxing-cpp/releases/tag/v2.2.1
        
        Change-Id: Ic4811d4724970c984dd9ed3d59b5204c18aafc6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160528
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-23  U-DESKTOP-CETSUCA\sigma  <jfeal@worcester.edu>  [40a9dd85d10c642eed98cd50fbdd89f93b99ed8e]

        sw: uitest: remove redundant function
        
        Change-Id: I772771b7d455bae8be1dffed29fbc3605ea3e3fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158981
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-23  Jonathan Clark  <jon@nullptr.ca>  [9cc8457abcae57c7f9de6e0fbca1fbc2a0cc9892]

        tdf#128122 Updated BASIC CCur to reuse SvNumberFormatter
        
        Previously, BASIC CCur used a custom, single-purpose currency string
        parser which did not properly accommodate the user's locale setting.
        This change replaces the custom parser with SvNumberFormatter, which
        does correctly respect system locale.
        
        Change-Id: I179915eb080e876e5e550dd350fdb86d7fa2bf4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160848
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-12-23  Justin Luth  <jluth@mail.com>  [90b12c9bad55e8f50b75a6d7b68caa27d82cc2b9]

        tdf#111969 sw: add selected smarttag to context menu
        
        If the smart tag was selected (from start to end),
        then GetPoint() was returning the end position
        which is considered to be outside of the smarttag.
        
        Instead, use Start(), which doesn't care which
        direction the selection happened in.
        
        Smart tags REQUIRE an extension, so no unit test possible.
        
        Change-Id: I3ad2f686a9f5d6accb0d1ac2ffbf272260249223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161194
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-22  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [73102542754189e3140f40f8cf02b60d6268dc0a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35b84bc686dc7e5aed86394e1896432aeeb68865
          - tdf#156156: add Animation sidebar deck help button's HID
            
            document how to access it, and include existing labels in heading.
            
            Change-Id: Ia0500321f9216aff4f249f9088694f6cd1fa1a80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161168
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-22  Oliver Specht  <oliver.specht@cib.de>  [bece5f05a33ac7ac723b46d455d104930a3b0839]

        tdf#98321 Checkbox: size like Word
        
        Display checkboxes imported from docx/rtf in the same size as Word.
        Additionally apply font highlighting if available.
        
        Change-Id: Ifea4aebf8c39b6cdd750f3c90e121da0c4131d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161124
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-22  Patrick Luby  <plubius@libreoffice.org>  [8339bb40b22e9426a05eb1d122cc8ef12ab7a229]

        Related: tdf#155266 Eliminate delayed scrollbar redrawing when swiping
        
        By default, the layout idle timer in the InterimWindowItem
        class is set to TaskPriority::RESIZE. That is too high of
        a priority as it appears that other timers are drawing
        after the scrollbar has been redrawn.
        
        As a result, when swiping, the content moves fluidly but
        the scrollbar thumb does not move until after swiping
        stops or pauses. Then, after a short lag, the scrollbar
        thumb finally "jumps" to the expected position.
        
        So, to fix this scrollbar "stickiness" when swiping,
        setting the priority to TaskPriority::POST_PAINT causes
        the scrollbar to be redrawn after any competing timers.
        
        Change-Id: I8c0772fc40ddc690ee59c6267c1c50971f4ff238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161184
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c5cc7af60d4b93d4247fd88f941a323f4a56dfcd]

        cid#1559857 Illegal address computation
        
        Follow up of commit: bff76421e234df7246a7f49c71a11432f86e09d1
        
        Change-Id: I1abfcea1c7ca8e55f8a4b19b66d80b901f575bcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161179
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0]

        Fix Windows MSI custom action for --enable-online-update-mar
        
        The install/uninstall actions need to be type 3137 to run privileged, which
        means that they must be placed within certain limits (e.g., not at "end") and
        that they cannot access INSTALLLOCATION (so need an additional un-privileged
        prepare action to forward that value).
        
        Plus, the call to CreateProcessW was passing arguments in a completely wrong
        way.
        
        And then some clean-up.
        
        Change-Id: I5b5f338da08931e48653f282cc9fa7b00955fea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161191
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [b26611017a75867efe97b4cf53df96cbd025cc5e]

        Use emplace_back instead of push_back (dbaccess)
        
        Change-Id: I659e211928dce2a5b8a44ceb3ec95745f66fbd1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161185
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [20fdec77eb6862fd78c9b090e42cddf6b40dc9be]

        Use emplace_back instead of push_back (connectivity)
        
        Change-Id: Ie90901832dafbaab56d3ac22bdb1cf91e3564fd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161181
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [761449adb54e965c94d31c36e945112736b232c5]

        tdf#156719: use unique accelerator for Insert > Signature Line
        
        Change-Id: Iebd03e3a526aef8db75a2323ec0faba8a3b24383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156276
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [32e82f3dc3c42488245bdd813ba4f5f53c59791d]

        Use emplace_back instead of push_back (comphelper)
        
        Change-Id: Ie3b033dc159ee3f848afa3e8cbabdbdfd402e644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161178
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [88f9b3f16b3e8c6af230ade1c4d56d09c7579675]

        Use emplace_back instead of push_back (emfio)
        
        Change-Id: I23bd626973c9aa0b4a961b16d5817d58c5f0cf7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161188
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [cde3d1f70f8b795ded329a05fa081f44edb11853]

        Use emplace_back instead of push_back (extensions)
        
        Change-Id: I6cdb020f19797821c6a70bf01013f6a7718bdcac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161189
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [17f1d2fe890159cfa881be2d16239e078e0a5c89]

        Use emplace_back instead of push_back (accessibility)
        
        Change-Id: I1b5aa26e92c6e5eaef43bd1c03281d4068b0487a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161175
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Julien Nabet  <serval2412@yahoo.fr>  [3001179cb72a98c14acc6ef8323eebadf526f71b]

        Simplify initialization by avoiding push_back
        
        Change-Id: I62a2986dd21f37df71653c94223a3dce5d50dff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161180
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [dc323680b9c82527eeef3bc69ac4ebf978cac69f]

        tdf#158451 sw: fix crash in text formatting of as-char group shape
        
        The problem is that during formatting of a SwTextFrame, SwTextFly
        contains a list of all anchored objects that could overlap, and then
        creating a portion for the as-char anchored group shape sets the anchor
        property and thereby unexpectedly deletes the child anchored object,
        while SwTextFly stores a pointer to it:
        
        4  SwFlyLayFrame::~SwFlyLayFrame()
        5  SwFrame::DestroyFrame()
        6  SwFrameFormat::DelFrames()
        7  SwDoc::SetFlyFrameAnchor()
        8  lcl_SetFlyFrameAttr()
        10 SwXFrame::setPropertyValue()
           (this=0x4042de0, rPropertyName="AnchorType", _rValue=uno::Any("com.sun.star.text.TextContentAnchorType": com::sun::star::text::TextContentAnchorType::TextContentAnchorType_AT_CHARACTER)) at sw/source/core/unocore/unoframe.cxx:1941
        11 SwTextBoxHelper::changeAnchor()
        12 SwTextBoxHelper::synchronizeGroupTextBoxProperty()
        13 SwTextBoxHelper::synchronizeGroupTextBoxProperty()
        14 SwFlyCntPortion::SetBase()
        15 sw::DrawFlyCntPortion::Create()
        16 SwTextFormatter::NewFlyCntPortion()
        
        This is because after the import is complete, only the group shape has
        its anchor set, while the child shapes all have a default FLY_AT_PAGE
        anchor.
        
        There is already code in SwXShape::setPropertyValue() to propagate the
        new anchor to children, but it's limited to group shape with more than 1
        text frame; very unclear why this limit exists so just remove it.
        
        Change-Id: Ide0f9def36e3b4eff6140206e3dfa4ee2c65e3eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161137
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-22  Mike Kaganski  <mike.kaganski@collabora.com>  [0de274e62c0b7154222178de234c504dc916ede4]

        Lok: make Ignore All list name independent on UI language
        
        Fixes not working "Ignore All" context menu entry in e.g. German UI
        in Online.
        
        Change-Id: I761c9f65c89fb5c7e929ea20f2db4eff20f7d53d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161170
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1190623696c5664b13e874e047a96a50ce5bba30]

        sw: fix another null deref in a11y check
        
        similar to
        
        author	Caolán McNamara <caolan.mcnamara@collabora.com>	2023-12-21 16:47:18 +0000
        committer	Caolán McNamara <caolan.mcnamara@collabora.com>	2023-12-21 21:15:03 +0100
        commit	ba712e9a35179c480cdc6f9d600d79040a273d53 (patch)
        tree	88e237265eb6ce884d2807b4c178a761d4c73956
        parent	8cd01e5278b2be25a1186139e431591a85a5080f (diff)
        crashreporting: apparent null deref in a11y check
        
        Change-Id: I3fb6a916fcbcce4b599a925dcc7d39a12e60a972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161149
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [78ccae0d42d168f845ddbd7cb694d80dfb04f84d]

        tdf#156820 Fix crash in custom color picker
        
        which requires
        
        (*) keeping ColorPicker alive during the runAsync in
        ColorPicker::startExecuteModal
        
        (*) keeping the PaletteManager alive during the ExecuteAsync in
        PaletteManager::PopupCOlorPicker
        
        Noting that MattK debugged the cause of this.
        
        Change-Id: I07efe8e6514f8882b1347c79c6150578c234bb9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161054
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5302a8888df0f74316db5471a2ba6a8e7a59a5dc]

        ofz#65252 Build failure
        
        Change-Id: Ifcfe7eb7331246c0f994f95b48ad72135949d40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161171
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-22  Mike Kaganski  <mike.kaganski@collabora.com>  [514913074c9c3f503cbbc9b6130d52e055e2ac81]

        InsertDeleteFlags should be synchronized with css::sheet::CellFlags
        
        They get casted to each other in sc/source/ui/unoobj/cellsuno.cxx
        (see ScCellRangesBase::clearContents, which implements respective
        method of css::sheet::XSheetOperation).
        
        Commit 07b0c01857137de7e4bd02375e7c892d622d270e (CWS-TOOLING:
        integrate CWS dr66, 2009-03-02) introduced IDF_NOCAPTIONS with
        value of 0x0200, which conflicted with css::sheet::CellFlags::FORMATTED
        (itself introduced in commit b4100bbf615fd3d1cbae200ae187ccbddf8e44a6
        (INTEGRATION: CWS calcuno01 (1.5.284); FILE MERGED, 2005-03-23)).
        
        Make the underlying type of InsertDeleteFlags consistent with the
        IDL definition; and make sure to avoid the conflicting values.
        
        Change-Id: Ic348f69a1e58db84ef6203391020f45b331e6967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161145
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-22  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fdc1a42db0423e36bd512c7048a0be1fdd09f611]

        Don't use boost in code generated by uno-skeletonmaker
        
        This had originally used a non-standard std::hash_map in
        db4b02eea5b81b7be05fa8b1f18c9f423302a977 "INTEGRATION: CWS jsc3 (1.4.2); FILE
        MERGED", then switched to boost::unordered_map in
        639825975e7657c7b3f4eeef208112780e71e545 "move sdk repo to boost unordered
        containters".  (And Executable_uno-skeletonmaker doesn't need boost during the
        build at all, so clean that up here, too.)
        
        Change-Id: I80661d70a54ec5d69b8f124c12d5cb0d6f369887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161147
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [f557e22a675164a1b9b0286a263a81d634959733]

        gtk4 a11y: Fix build for Gtk < 4.9
        
        The code in `vcl/unx/gtk4/a11y.cxx` is
        
            #if GTK_CHECK_VERSION(4, 9, 0)
        
        , so should the code using that be.
        
        Should fix this issue reported in [1]:
        
        > Hi, building on Linux (Debian 12) breaks with the following error:
        >
        > [LNK] Library/libvclplug_gtk4lo.so
        > ld.lld: error: undefined symbol: lo_accessible_new(_GdkDisplay*, _GtkAccessible*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&)
        > >>> referenced by gtkaccessibleregistry.cxx
        > >>>               /home/etna/Tmpdir/libreoffice/build/workdir/CxxObject/vcl/unx/gtk4/gtkaccessibleregistry.o:(GtkAccessibleRegistry::getLOAccessible(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>, _GdkDisplay*, _GtkAccessible*))
        > clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[1]: *** [/home/etna/Tmpdir/libreoffice/vcl/Library_vclplug_gtk4.mk:20: /home/etna/Tmpdir/libreoffice/build/instdir/program/libvclplug_gtk4lo.so] Error 1
        > make[1]: *** Waiting for unfinished jobs....
        >
        > I was able to get the build to succeed by rolling back commit 70ef230 ( https://github.com/LibreOffice/core/commit/70ef230aae4f961c8197cc11a7ff5feaf1d96c20 )
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2023-December/091330.html
        
        Change-Id: Ifc359bd8b96af8eaa5427a7949259beb607e105d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161144
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [e9e3576ada06d53de12efed041fb309fe5388e01]

        svl: fix build with --enable-debug
        
        After
        
        author	Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>	2023-12-20 19:42:28 +0100
        committer	Armin Le Grand <Armin.Le.Grand@me.com>	2023-12-21 21:13:55 +0100
        commit	789a737ac92c4f2b0eb9820b99c43cc8253c8b29 (patch)
        tree	bc167ec04de29e63168844be973f59980fa36ac2
        parent	3430a2c639a9f714259f9d319515464a653d21ab (diff)
        Remove DeleteItemOnIdlex
        
        it fails with
        
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’ was not declared in this scope
           64 |     SfxItemPool& getPool() const { assert(!isDeleted() && "Destructed instance used (!)"); return *m_pPool; }
              |                                            ^~~~~~~~~
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const SfxPoolItem* SfxPoolItemHolder::getItem() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’ was not declared in this scope
           65 |     const SfxPoolItem* getItem() const { assert(!isDeleted() && "Destructed instance used (!)"); return m_pItem; }
              |                                                  ^~~~~~~~~
        make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:340: /home/xisco/libreoffice/workdir/CxxObject/svl/source/items/itemiter.o] Error 1
        make[1]: *** Se espera a que terminen otras tareas....
        In file included from /usr/include/c++/12/cassert:44,
                         from /home/xisco/libreoffice/include/svl/whichranges.hxx:16,
                         from /home/xisco/libreoffice/include/svl/itemset.hxx:30,
                         from /home/xisco/libreoffice/svl/source/items/sitem.cxx:23:
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’ was not declared in this scope
           64 |     SfxItemPool& getPool() const { assert(!isDeleted() && "Destructed instance used (!)"); return *m_pPool; }
              |                                            ^~~~~~~~~
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const SfxPoolItem* SfxPoolItemHolder::getItem() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’ was not declared in this scope
           65 |     const SfxPoolItem* getItem() const { assert(!isDeleted() && "Destructed instance used (!)"); return m_pItem; }
              |                                                  ^~~~~~~~~
        make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:337: /home/xisco/libreoffice/workdir/CxxObject/svl/source/items/sitem.o] Error 1
        In file included from /usr/include/c++/12/cassert:44,
                         from /home/xisco/libreoffice/include/svl/whichranges.hxx:16,
                         from /home/xisco/libreoffice/include/svl/itemset.hxx:30,
                         from /home/xisco/libreoffice/svl/source/items/itemset.cxx:30:
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’ was not declared in this scope
           64 |     SfxItemPool& getPool() const { assert(!isDeleted() && "Destructed instance used (!)"); return *m_pPool; }
              |                                            ^~~~~~~~~
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const SfxPoolItem* SfxPoolItemHolder::getItem() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’ was not declared in this scope
           65 |     const SfxPoolItem* getItem() const { assert(!isDeleted() && "Destructed instance used (!)"); return m_pItem; }
              |                                                  ^~~~~~~~~
        In file included from /usr/include/c++/12/cassert:44,
                         from /home/xisco/libreoffice/include/o3tl/sorted_vector.hxx:15,
                         from /home/xisco/libreoffice/include/svl/itempool.hxx:30,
                         from /home/xisco/libreoffice/svl/source/items/itemset.cxx:31:
        /home/xisco/libreoffice/svl/source/items/itemset.cxx: In member function ‘const SfxPoolItemHolder& SfxPoolItemHolder::operator=(const SfxPoolItemHolder&)’:
        /home/xisco/libreoffice/svl/source/items/itemset.cxx:120:13: error: ‘isDeleted’ was not declared in this scope
          120 |     assert(!isDeleted() && "Destructed instance used (!)");
              |             ^~~~~~~~~
        /home/xisco/libreoffice/svl/source/items/itemset.cxx:121:21: error: ‘const class SfxPoolItemHolder’ has no member named ‘isDeleted’
          121 |     assert(!rHolder.isDeleted() && "Destructed instance used (!)");
              |                     ^~~~~~~~~
        /home/xisco/libreoffice/svl/source/items/itemset.cxx: In member function ‘bool SfxPoolItemHolder::operator==(const SfxPoolItemHolder&) const’:
        /home/xisco/libreoffice/svl/source/items/itemset.cxx:139:13: error: ‘isDeleted’ was not declared in this scope
          139 |     assert(!isDeleted() && "Destructed instance used (!)");
              |             ^~~~~~~~~
        /home/xisco/libreoffice/svl/source/items/itemset.cxx:140:21: error: ‘const class SfxPoolItemHolder’ has no member named ‘isDeleted’
          140 |     assert(!rHolder.isDeleted() && "Destructed instance used (!)");
              |                     ^~~~~~~~~
        make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:337: /home/xisco/libreoffice/workdir/CxxObject/svl/source/items/itemset.o] Error 1
        In file included from /usr/include/c++/12/cassert:44,
                         from /home/xisco/libreoffice/include/svl/itemset.hxx:23,
                         from /home/xisco/libreoffice/include/svl/setitem.hxx:25,
                         from /home/xisco/libreoffice/svl/source/items/itempool.cxx:21:
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’ was not declared in this scope
           64 |     SfxItemPool& getPool() const { assert(!isDeleted() && "Destructed instance used (!)"); return *m_pPool; }
              |                                            ^~~~~~~~~
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const SfxPoolItem* SfxPoolItemHolder::getItem() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’ was not declared in this scope
           65 |     const SfxPoolItem* getItem() const { assert(!isDeleted() && "Destructed instance used (!)"); return m_pItem; }
              |                                                  ^~~~~~~~~
        make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:337: /home/xisco/libreoffice/workdir/CxxObject/svl/source/items/itempool.o] Error 1
        In file included from /usr/include/c++/12/cassert:44,
                         from /home/xisco/libreoffice/include/svl/whichranges.hxx:16,
                         from /home/xisco/libreoffice/include/svl/itemset.hxx:30,
                         from /home/xisco/libreoffice/include/svl/itemprop.hxx:26,
                         from /home/xisco/libreoffice/svl/source/items/itemprop.cxx:23:
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘SfxItemPool& SfxPoolItemHolder::getPool() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:64:44: error: ‘isDeleted’ was not declared in this scope
           64 |     SfxItemPool& getPool() const { assert(!isDeleted() && "Destructed instance used (!)"); return *m_pPool; }
              |                                            ^~~~~~~~~
        /home/xisco/libreoffice/include/svl/itemset.hxx: In member function ‘const SfxPoolItem* SfxPoolItemHolder::getItem() const’:
        /home/xisco/libreoffice/include/svl/itemset.hxx:65:50: error: ‘isDeleted’ was not declared in this scope
           65 |     const SfxPoolItem* getItem() const { assert(!isDeleted() && "Destructed instance used (!)"); return m_pItem; }
              |                                                  ^~~~~~~~~
        make[1]: *** [/home/xisco/libreoffice/solenv/gbuild/LinkTarget.mk:337: /home/xisco/libreoffice/workdir/CxxObject/svl/source/items/itemprop.o] Error 1
        make: *** [Makefile:290: build] Error 2
        
        Change-Id: I0f61738d4afbdfc06b372d6c5e5fff6f9f9f4e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161142
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-22  Oliver Specht  <oliver.specht@cib.de>  [0097f8595791f4bbf499ebd423f4f80ec8e38dbe]

        tdf#158652 notify navigator on insert/edit/delete comment
        
        links changes of the drawing engine to comments as it was
        done before with pictures, shapes and OLE objects
        ui unit test included
        
        Change-Id: I4fde3a82b80e73758fb3da94ed2553453d09e9ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160624
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-22  Mike Kaganski  <mike.kaganski@collabora.com>  [36b7ae36715cbf47b451e41e47aebe28cf594bd8]

        tdf#154044: Also store default column data, when copying to Undo document
        
        And restore from it un Undo.
        
        Change-Id: I3e14b345cff25068d0555c5bceb4d6e97ce7cf76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-22  Sahil  <me.sahilgautam@gmail.com>  [68d074fb910de7298cbefb6a3c3e192dae201837]

        tdf#136003 Make Delete Rows/Columns labels more descriptive
        
        Delete Rows/Columns is only allowed for unprotected cells.
        
        Change-Id: I0c3b9d79a329a5b540018e350f114a1807ce649e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160834
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [03d7ff28b377d65cf266ff86292e581f48c98eee]

        cid#1546500 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546492 COPY_INSTEAD_OF_MOVE
        cid#1546468 COPY_INSTEAD_OF_MOVE
        cid#1546431 COPY_INSTEAD_OF_MOVE
        cid#1546382 COPY_INSTEAD_OF_MOVE
        cid#1546350 COPY_INSTEAD_OF_MOVE
        cid#1546336 COPY_INSTEAD_OF_MOVE
        cid#1546314 COPY_INSTEAD_OF_MOVE
        cid#1546152 COPY_INSTEAD_OF_MOVE
        cid#1546094 COPY_INSTEAD_OF_MOVE
        cid#1546077 COPY_INSTEAD_OF_MOVE
        cid#1546047 COPY_INSTEAD_OF_MOVE
        cid#1545213 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ia51df9f9cbde755db4d2685e34f22676ed5eceff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [557579ec55fdeb6d1f1c4395080f72c803630567]

        cid#1559856 Dereference after null check
        
        we check for a null pOldSh earlier, so logically we need to check
        here too, or drop the other null check
        
        Change-Id: I8a9110a9d1ee753f523101862fa62e20760bdb1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Justin Luth  <justin.luth@collabora.com>  [a7bd33955fa52380cf9b04da265646bc93d5c217]

        address nit: put unit tests in anonymouse namespace
        
        https://gerrit.libreoffice.org/c/core/+/160655/5/sw/qa/extras/rtfexport/rtfexport8.cxx
        
        Miklos "nitted" me that I didn't wrap this test
        in an anonymous namespace. Obviously anything I do
        is simply copy/paste, so lets make sure that at
        least the latest and greatest versions of each
        series of unit tests are done "correctly".
        
        Change-Id: I699c8d70e4f587373918e27f08304a0fe815bff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160991
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-12-21  t-aswath  <aswatht.cse2022@citchennai.net>  [a2cd681369061574974517b1aabf78613f5601b7]

        tdf#114441 - Convert use of sal_uLong to better integer types
        
        Change-Id: Ia226ea485700a6864c9d5ca154267c5080555a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160450
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [216548a091c270bdc3048369991aebd82463cf34]

        Fix typo
        
        Change-Id: I61077392776c6bc28410c29586fd8de85347b936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161143
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-12-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4ad83c526932e051a6dc41dd15f2acab42766800]

        Fix typo
        
        Change-Id: If3cc7a17e760dc5033a05f75e1411a20319d0158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161139
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-12-21  Jim Raykowski  <raykowj@gmail.com>  [4c2c900970d6484c6a92900213ece5c415e40f2d]

        tdf#158114 SwNavigator: Make images with broken links easier to find
        
        This patch makes an icon display in image entries with broken links to
        make it easier to find images with broken links.
        
        Change-Id: I470c9959e169d4cc53a44e0a64e88af35e671db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161045
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-12-21  Matt K  <mattkse@gmail.com>  [e760dcf43052212952191ccdadbfb677fea3b5b8]

        tdf#153690 Prevent invisible dialogs in Calc Full Screen
        
        This change just adds the flag "SfxChildWindowFlags::NEVERHIDE"
        to the info passed around so that the dialogs are not treated as
        invisible when executing SfxWorkWindow::ShowChildren_Impl.
        
        Change-Id: I35f0be94132cee438b3be9f4b4217208617a1e77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160660
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ba712e9a35179c480cdc6f9d600d79040a273d53]

        crashreporting: apparent null deref in a11y check
        
        svl/source/items/itemset.cxx:801
        svl/source/items/itemset.cxx:796
        sw/source/core/access/AccessibilityCheck.cxx:1193
        sw/source/core/access/AccessibilityCheck.cxx:1184
        sw/source/core/access/AccessibilityCheck.cxx:1562
        sw/source/core/access/AccessibilityCheck.cxx:1552
        sw/source/core/txtnode/OnlineAccessibilityCheck.cxx:134
        cppu/source/uno/copy.hxx:288
        cppu/source/uno/any.cxx:72
        cppu/source/typelib/typelib.cxx:1328
        cppu/source/typelib/typelib.cxx:2169
        
        Change-Id: I91a83ffb9f1912dd9736e3d6a194f63475f63b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8cd01e5278b2be25a1186139e431591a85a5080f]

        allow passing if deep detection is wanted
        
        which naturally requires the data to achieve
        
        Change-Id: If23e7dbd009f3d8e60422ec4d485b459d5721c8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161135
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [33686f67da4bc640014cb51888fbf90f83375e97]

        make use of toplevel docmodel's UserAllowsLinkUpdate property
        
        Change-Id: Ia560c123c2f9dd08acb7eeaafccee332dd16300e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161133
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b45f360fcffe076ccec7be790604665c80f7380e]

        export UserAllowsLinkUpdate via AllowLinkUpdate property
        
        Change-Id: I3dca61490ba9ad2912faf0bb431fb643f248c247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161123
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [789a737ac92c4f2b0eb9820b99c43cc8253c8b29]

        Remove DeleteItemOnIdlex
        
        There are some CrashReports in 7.6 which have
        DeleteItemOnIdle on the stack, but there is nothing
        reproducable. So I took a look...
        
        I first thought it's a MCGR regression, due to classes
        on the stack. But the Item involved is just random, can
        happen with any Item.
        
        Then I thought it may have to do with ITEM refactorings,
        but it happens with DeleteItemOnIdle involved, so also
        not the case. I already saw DeleteItemOnIdle when doing
        these and qualified as 'hack' in the way. already
        
        It is only on Windows and DeleteItemOnIdle is involved.
        This again (took a deeper look now) is an old hack to
        keep an SfxPoolItem 'alive' for some 'time'. For that,
        it triggers an async reschedule which then deletes the
        Item when being called. If the Item will be used after
        that is pure coincidence - seems to work in most cases.
        
        It seems as if for Windows the timing slightly changed
        for some scenarios, so a reschedule is too early. This
        can happen with this hack anytime.
        
        DeleteItemOnIdle is used in scenarios where SfxPoolItem*
        is e.g. returned, but is *not* anchored, so e.g. not
        member of an SfxItemSet. Or in short: Lifetime is not
        safe.
        
        DeleteItemOnIdle exists since 1st import, but was
        changed to AsyncEvent ca. 4 months ago (see
        57145acf9ec47c23e307b7a5c0029d21d937cc35), so that may
        have caused it. It is possible that these errors happen
        on Windows since then. Before something more complicated
        was used to delete it late, but surely also not really
        safe.
        
        Due to ITEM refactor I have the knowledge/tooling to
        solve this. It will not be a 1-5 lines fix, but it is
        a hack and in the way for further ITEM refactor anyways.
        What we have nowadays is a SfxPoolItemHolder -> it's
        like an SfxItemSet for a single Item. It safely holds/
        controls the lifetime of an SfxPoolItem. It is already
        used in quite some places. It helps to solve many hacks,
        also the ones putting Items directly to the Pool - due
        to there never was an alternative for that. In principle
        the ItemPool/ItemSet/Item paradigm was never complete
        without SfxPoolItemHolder.
        
        Thus I started to fix that (and remove that hack for
        good, sooo many changes over the years, sigh), but as
        said is not straightforward. Will have to change
        retvals of involved stuff to SfxPoolItemHolder - it's
        just two pointers and designed to be copied (one is a
        Pool, needed to cleanup when destructing).
        CopyConstruct/destroy just counts the RefCnt up/down,
        so cheap.
        
        1st version compiling, let's check on gerrit...
        Corrected one error in QueryState for securitypage, also
        added some security features/asserts.
        
        Change-Id: Ida49fd35ca88ead84b11d93e18b978cb9e395090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161083
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3430a2c639a9f714259f9d319515464a653d21ab]

        Revert "tdf#100584 - Arrange sheets in the tab bar depending on the RTL settings"
        
        This reverts commit be86c8f2432623fdb8ed4f22ca08c35121fd8bec.
        
        Reason for revert: To many regressions.
        
        Change-Id: Id3fb8dc5d4edb84c0008b7834a80887aaa7d9f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161154
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-12-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [19e856aa1ade6686fa495e57386b81cabae47495]

        Revert "tdf#100584, tdf#157784 - Arrange sheets depending on the RTL settings"
        
        This reverts commit 4f1b3c16f5530a2a190cab07c07c7bf63acf42c7.
        
        Reason for revert: To many regressions.
        
        Change-Id: I7352bb3c192d5e6c72e95c387ee551764007e97b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161152
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-12-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [71c555c5ae31d84dff8d9448fd2be4dab23f20a8]

        Add flush mechanism to buffered Primitives II
        
        As sberg mentioned in previous change this might be responsible
        for heap-use-after-free problems. I took a look and it seems
        to be possible that the timer calls back while deletion of the
        helper is in progress, so I try now to first stop the timer
        and then delete so that it cannot trigger. Will see if that
        works - if not I might have to use another lock...
        
        Change-Id: I1ae27d9ed890f352904cab18c3292b449659a3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161128
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-21  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [90277a87b13074c82e2e9aa08befc08c235087f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05f08bd00aadd36088254d7fe062507fea113de8
          - tdf#156156: add Manage Changes sidebar decks help button's HID
            
            and document how to get to it from the sidebar and the tabbed UI.
            
            Change-Id: Ibeab9e20ea4f8684b8d0a8a535b30c3122e4df70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161101
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [4fcba272103d51a8025d56ac6cf71cc85f736431]

        update credits
        
        Change-Id: I147a1e96e4c2fc855f66168c7633d254fd9d6c19

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b01a0b7cb6e5b090c7e84539cf936306f1b27c8]

        std::list::size() can still be implemented as std::distance()
        
        seen with Red Hat Developer Toolset 10
        
        https: //github.com/CollaboraOnline/online/issues/6893#issuecomment-1866342284
        Change-Id: I4a0e8ad028126dded678e971a6261d6725a6b06c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Aleś Bułojčyk  <alex73mail@gmail.com>  [671acff57691a87eb60ec8ffdf499ddae16daf03]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 6cec1129014f23e9bc2c407ea82d2ae2a6c7fb83
          - Belarusian hunspell dictionary update
            
            Change-Id: I3d2a0f62fe59f46f201a4c7d596a22fd04efe017
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/159516
            Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
            Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2023-12-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e465747594298cafa5205c0323aeaf45e72c8e5a]

        Windows MSI custom action for --enable-online-update-mar
        
        ...which needs to call update_service.exe with "install" (resp. "uninstall") and
        needs to create (resp. delete) a registry entry containing the issuer and name
        of the certificate with which the updater.exe is signed (which is required by
        one of the many sanity and security checks performed by update_service.exe
        before it will actually do an automatic update).  (The issuer and name of the
        certificate are for now hardcoded to the values used by TDF when signing its
        Windows builds.)
        
        (gid_Customaction_uninstall_updateservice needs to run rather early, when
        update_service.exe has not yet been removed, so I rather randomly picked
        "MigrateFeatureStates" as the point where to run it.)
        
        Change-Id: I6e0f62ec3e51d74d4a526a490badc7c14ebe99ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161125
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-21  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1061cf3fcb59dd8c92b7bc21a22e3a24bbd31abd]

        No good reason to not --enable-windows-build-signing with --enable-dbgutil
        
        ...at least for debug purposes?
        
        Change-Id: I02fc410109353ca3d421a6b8e0e1848df05cf479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161126
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8ed865ffc151c6778f122b4e83b46a28f26ebe5e]

        crash when one user deletes a chart another has a property dialog open for
        
        Insert a chart, user #1 select it, user #2 select it. User #1 double click
        it, double click again the legend to get dialog to edit it. User #2 delete
        chart, User #1 'ok'
        
         #0  0x00007f5365797d59 in osl::Mutex::acquire (this=<optimized out>) at include/osl/mutex.hxx:63
         #1  osl::ClearableGuard<osl::Mutex>::ClearableGuard (t=..., this=0x7ffc7ffcccf0) at include/osl/mutex.hxx:182
         #2  apphelper::LifeTimeGuard::LifeTimeGuard (rManager=..., this=0x7ffc7ffcccf0) at chart2/source/inc/LifeTime.hxx:175
         #3  chart::ChartModel::lockControllers (this=0x0) at chart2/source/model/main/ChartModel.cxx:415
         #4  0x00007f53658375ab in chart::ControllerLockGuardUNO::ControllerLockGuardUNO (this=this@entry=0x7ffc7ffcce80, xModel=...)
             at chart2/source/tools/ControllerLockGuard.cxx:34
         #5  0x00007f5364df5f34 in chart::ChartController::executeDlg_ObjectProperties_withoutUndoGuard (this=<optimized out>, rObjectCID=..., bSuccessOnUnchanged=<optimized out>)
             at chart2/source/controller/main/ChartController_Properties.cxx:797
         #6  0x00007f5364df7a5e in chart::ChartController::executeDlg_ObjectProperties (this=0x7f535401f310, rSelectedObjectCID=...)
             at chart2/source/controller/main/ChartController_Properties.cxx:707
         #7  0x00007f5364e0f497 in chart::ChartController::execute_MouseButtonUp (this=<optimized out>, rMEvt=...) at chart2/source/controller/main/ChartController_Window.cxx:924
         #8  0x00007f53760d61dc in (anonymous namespace)::LOKPostAsyncEvent (pEv=0x55e2f1b93db0) at sfx2/source/view/lokhelper.cxx:893
         #9  0x00007f53760d0977 in LokChartHelper::postMouseEvent (this=<optimized out>, nType=1, nX=<optimized out>, nY=<optimized out>, nCount=2, nButtons=1, nModifier=0, fScaleX=0.083333333333333329,
             fScaleY=0.083333333333333329) at sfx2/source/view/lokcharthelper.cxx:294
        
        just hold a reference to the chart the dialog operates on
        
        Change-Id: I3b05d1fc12e4df899c1a996f1029f9d3d62e87ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [54da61d1d9d171adf5911b641e7dd2118f41e55a]

        we are at 24.8 in trunk now, not 24.2
        
        Change-Id: Iac329b0f11a564e90d6eb1e9c4a42f36254021f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [798c2a352d1d96502b3988c9f29e41a211810657]

        CppunitTest_sw_uiwriter9: avoid external fonts
        
        Change-Id: Ieb890a0e2ceebbd81977069cf0813e746e38c835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161121
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [33925cfe33703b6b7b8979727f826c2b735f916c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89b8eaffddb9e3cd462eed1090d00a3dbd3a1652
          - SF_Datasheet table of methods layout correction
            
            Change-Id: I3574860ab19e8171e86b6e4417364ef34d68b54b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161098
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ef0460e92da57b0afab60baddb7ed3b04dec733]

        SVT_DLL_NAME is unused
        
        since
            commit b2cdf8a1eac730f74160d7c7a1ab9ec907dddd23
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Fri Aug 5 14:51:30 2022 +0100
            the "CreateWindow" function in svtools is newly removed
        
        Change-Id: I815d2aff0dc478d782df056c58f91deee248b2c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f66ba1fa48095f62ad41d2682e6de227063fcec1]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4eb96d17e8d53f48a7709ae657534cc451c7e4c8
          - update translations for master/24.2.0 RC1
            
            and force-fix errors using pocheck
            
            Change-Id: I3a90b2320a21d218eeef7bdb8168b4e634304f78
            
          - Updated Slovenian translation
            
            Change-Id: I4abd1636021dabc93c91f1c51d3f8b0aadbb320b
            
2023-12-21  Justin Luth  <jluth@mail.com>  [9b32a016e36fd00c94e17bb5062cf33376d3df3d]

        tdf#158785 partial revert "enable hyperlink to be detected
        
        ... at the end of text"
        
        This reverts lpranam's 7.2.0 regressive
        commit 3233db0913193855285e1f56492d4617368441b6.
        
        The character after a hyperlink should not offer
        to CTRL-click or jump to the hyperlink target.
        
        make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf158785
        
        Change-Id: I3f5398cc3a4f29ddf1c50764c311046713d39439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161042
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-21  Michael Stahl  <michael.stahl@allotropia.de>  [9276d5338ef04209b007bbc705e4c023cf181456]

        xmlsecurity: fix AES-GCM code to build with NSS < 3.52
        
        (regression from commit f0fda7ad2236f478fea396a23d4f982e5fc37e68)
        
        Change-Id: I42fda00eb37fb1939013b21158c931d47e4e8486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161117
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1931610406d7f0431722612f55b3424e9dc4ad7]

        update script to python3
        
        Change-Id: Ia793b2362b65b431d32cf85321b1d5f17177229a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-21  NickWingate  <nick.wingate@collabora.com>  [13bd849f60286c49457c290218e5b7acf9cadba8]

        Add export sheet range option to calc
        
        User can specify which sheets to export e.g. '2-5,7'
        exports sheets 2,3,4,5,7.
        Note: this is different from exporting pages as one
        sheet may contain several pages worth of content.
        
        Also fix a bug where exporting only a selected sheet
        causes the next sheet to be exported. e.g.:
        Sheet 1 is empty, Sheet 2 has content. Exporting Sheet 1
        results in Sheet 2's content being exported
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: Iecd42188ddbbbcd70eb37bec80783e29e3cb5b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156255
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-21  Ricardo Donino  <radonino@gmail.com>  [dac88850909eb337cfaf96963fa4bffa91470381]

        tdf#143123 Port SDraw Java SDK example to Python
        
        Change-Id: I12e19b4a0d76affa178618cfbaf761692f29152a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160360
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [2eb428a8890dda29fbdc8b639fc1377080fab59f]

        CppunitTest_sw_rtfexport8: avoid external fonts
        
        Change-Id: I7fb3f54134e3cf5a2f4fd318f36df35a4b5967dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161068
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [09b13f3f85b3ef6ffe4d46e2ca5170ad81045ff4]

        tdf#158375: adapt UI when DDE is disabled via DisableActiveContent
        
        When DisableActiveContent is set, provide now non-functional areas
        meaningful error messages / popup dialogs.
        
        Change-Id: I34bffee10fb0ba5c0194193f3d3d81b93d7dbd26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160923
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2023-12-21  Andras Timar  <andras.timar@collabora.com>  [a2a9850217b3f711440283131fdfc58a9a254919]

        get rid of warnings when reportbuilder is not configured for build
        
        In the LOK case for example, where there is no reportbuilder, there
        were a lot of bogus warning messages at startup, confimgr complained
        that there were translations for non existing configuration nodes,
        all belonged to reportbuilder.
        
        Change-Id: I7f9cef3206bddd9e333b97ee966fb950fbb352d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160887
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161048
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-12-21  Kira Tubo  <kira.tubo@gmail.com>  [8555c3180c367d684af48b7ecb7ceb333fcd0962]

        tdf#141908: replace hex colors with color keywords
        
        Update hex colors 0x000000, 0xFFFFFF, and 0xFF0000 with COL_BLACK, COL_WHITE,
        and COL_LIGHTRED, respectively. See comment #30 for more details.
        
        Change-Id: I82ff851d8c19f9ef4aeeb01bff313160da615222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160452
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [324a12413f28ca506487f677d68b840529130aef]

        external/lcms2: fix lcms2-2.4-windows.patch
        
        fix typos and macros in code.
        
        Change-Id: I0886f3d95d87be70be1e7e6a220617f728fe6653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161056
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0cd74b5be297f638d455b9b267462192f2e6620c]

        tdf#158759 - UI: Part 56 - Unify lockdown behavior of Options dialog
        
        for General - Application Colors Page.
        
        Change-Id: I2fb6c73cef82c12c3c8f3c49fb0e4b62703a1de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161030
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-20  Patrick Luby  <plubius@libreoffice.org>  [9f92a39234dfae40fe19ab6fa47caf8b21dd8847]

        Related: tdf#155266 stop delaying painting timer while swiping
        
        After fixing several flushing issues in tdf#155266, scrollbars
        still will not redraw until swiping has ended or paused when
        using Skia/Raster or Skia disabled. So, stop the delay by only
        including NSEventMaskScrollWheel if the current event type is
        not NSEventTypeScrollWheel.
        
        Change-Id: I9348e5a38b4d0fedbf424b92a71eed25280fc21f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161075
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-20  Miklos Vajna  <vmiklos@collabora.com>  [ee7ca8e4ea8ed93655f99e77a9e77032ac830c46]

        cool#7865 sfx2 lok: fix bad view id on async command dispatch
        
        If you try hard enough, it's possible to request an "add conditional
        format" dialog in one view and have the dialog pop up in an other view.
        This is related to cool#7853 but it focuses on the wider problem.
        
        What happens is that sometimes we do want to execute an uno command in
        an async way, e.g. one dialog opening an other dialog in its response
        handler: making sure the dialog is not manually / synchronously spinning
        the main loop while it's running is wanted. Also fixing each & every
        async command dispatch manually would be a lot of work.
        
        Fix the problem by remembering the current view in SfxHintPoster::Post()
        as it posts events to the main loop and restoring that view if necessary
        in SfxHintPoster::DoEvent_Impl().
        
        Other comments:
        
        - An alternative would be to just dispatch all these UNO commands
          synchronously, but see above, there are cases where we want to stay
          async, a nested main loop would be worse.
        
        - An even more general fix would be to handle all calls to
          Application::PostUserEvent(), but vcl doesn't know what is the
          current view and would have trouble switching to that view (only sfx2
          and higher up knows that), so do this only at a SfxHintPoster::Post()
          level, this is already meant to fix all async uno commands.
        
        - There was a single case in sd/ where we tried to dispatch an async
          event while switching views, so switch to a sync command dispatch
          there to avoid the problem. CppunitTest_sd_tiledrendering would hang
          without this and would emit a warning in SfxHintPoster::Post().
        
        - Restore the sc/ code to do its async dispatch as it used to, so now
          CppunitTest_sc_tiledrendering's testOpenURL is a test case that covers
          this change.
        
        Change-Id: I765e618f55caad791aa1fe7569a32bcc31622525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161071
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [1a81fd69e10ad1ce7193fe7231ff29b2b94f67c7]

        gtk4 a11y: Take SELECTABLE/EXPANDABLE states into account
        
        The Gtk API has no direct equivalent for the selectable
        and expandable states, but sets them on the AT-SPI layer
        whenever a value for the selected/expanded states is
        explicitly set.
        Therefore, only explicitly set values for these
        if the selectable/expandable state is present,
        to avoid the expandable/selectable state being
        set on AT-SPI layer when it shouldn't.
        
        Change-Id: Ib0cf2095d4834869856bf786e662115f6a328e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161046
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-20  Oliver Specht  <oliver.specht@cib.de>  [fad76223d1cff3746a5d2e4ce56b93ecd1c80f61]

        tdf#158762 RTF writerfilter: fix list import
        
        While importing the properties NumberingRules and NumberingStyleName
        interfere with each other. Avoid overwriting NumberingRules with an
        invalid NumberingStyleName.
        
        Regression from 588ff9a228f4894142264c68392ed1e9800a4d7d
        
        Change-Id: I706ea514da43faae0fdb9a2c0d4f5b1928ef55f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160967
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb5642b1b542e79d98e3f6786beb7de427f44bb5]

        CppunitTest_sw_ooxmlexport20: remove copy&paste leftover
        
        from
        
        author	Xisco Fauli <xiscofauli@libreoffice.org>	2023-10-30 16:22:07 +0100
        committer	Xisco Fauli <xiscofauli@libreoffice.org>	2023-10-31 08:43:11 +0100
        commit	117133575961dbce292a24f8afa1414785f2282c (patch)
        tree	29e6a859c0f48659fc5cc0dfd89da72037cb3db3 /sw/CppunitTest_sw_ooxmlexport20.mk
        parent	a04fc307ba2706bb9e5b8441aaf4380797b5f397 (diff)
        CppunitTest_sw_ooxmlexport5: split into two
        
        Change-Id: I5ef959adb119af22b6c17ef7d64465166a13360b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161069
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f07984471add9cb2e7b4fddcfaa505cc7d508fe]

        Resolves: tdf#158332 'fake' keystroke exits presentation
        
        the fake keystroke is to make tooltips go away before menus which
        used to be a problem versions of gtk3 < 3.24 that resultsed in no
        menus appearing. Our min is still 3.18 so technically we need to retain
        that until bumping past that as baseline.
        
        Change-Id: I94aa309665c50c8ca310285d1e691030f443934a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b05dc79e531633d84a1b6ed60f3d281d02c713e]

        comment re GTK 2.34 should be 3.24
        
        Change-Id: I9acc070e6983f7f5e72120029fa968f0f15306e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161079
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b5ab2d274ab3731eca3e7f9d8cce9de53eb927c4]

        no need to use unique_ptr here
        
        Change-Id: I1e7ef79eefa18c39f647749d6f7c94e2bff20462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ef28599b227042e3b64075143207af2c674719d]

        cid#1545612 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545605 COPY_INSTEAD_OF_MOVE
        cid#1545587 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iafb1d81dbacfefe70fbddd84b29e827dc137ef07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [3a33a97d2358a7ad2e67c01edc1fca29d1b7041c]

        tdf#158794: do not try to insert DDE table into footnotes / endnotes
        
        Until tdf#76007 is fixed, of course.
        
        Change-Id: Iad7fb0de679e024a8cebdd005ac5a66af3ace163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161078
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [a2a02508d5aa6332c71245bb13f4c40f61790a72]

        Fix BigInt::Abs
        
        It would fail to negate SAL_MIN_INT32.
        
        Change-Id: Ia5d34fc31917cabee2a1b130ef69c91b202592fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161063
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [36df3f9ad2f71c122af3cf9fbc58c661f416658e]

        Make BigInt::DivMod public, to allow optimized division
        
        Change-Id: I4f79c30b9ab997d01e59a0dec76986e74abfc11f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161053
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c684aa9cf33fdbae5bf5f05d2c391f27a140b56d]

        Simplify and rename for clarity
        
        Change-Id: Ic97a2b313c6f7d9da540a8867f01362c2fe7b0d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161052
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c905505348d8b44f54f1f51a2f33aca878fe6375]

        capture these explicitly by name
        
        Change-Id: I0908aedada9c59426373080d7d3894b452693939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161076
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [9157d8de8d8a7a2707179f371f4e4771f41777be]

        tdf#158375: disable DDE when DisableActiveContent is set
        
        Change-Id: I167f6ea5d740b5a53cd02a9b865e65ff980a8877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160922
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2023-12-20  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [7bb50fd2398220c3b162e7242c1cc8d6c4c31463]

        tdf#158375: adapt UI when embedded content is disabled via option
        
        When DisableActiveContent is set, embedded active content is
        disabled (e.g. OLE). Therefore the existing ui insertion bits don't
        function either. Disable them with a warning pop-up hinting "Active
        content is disabled."
        
        Change-Id: I14984684f22df6aff81af79d5a15589b5cae75fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161055
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-20  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [75df80e34efcd2d39a49ec91654480e156bcec1f]

        tdf#158375: further disable embedded objects
        
        there was the possibility of constructing an OOoEmbeddedObjectFactory
        or OleEmbeddedObjectFactory directly instead of
        UNOEmbeddedObjectCreator.
        
        So disable all createInstance calls for them too. Securing there won't
        be active embedded objects.
        
        Change-Id: Ib47ad920d4951790c12d1a8587505cab2f1e126d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160921
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [74f25206bc5a1a36b85683555cb27179e5da3275]

        tdf#68364 - Don't assume a database if only two dots are present
        
        Additionally, a database table name (database.table.column) has to
        be retrieved from the database to be valid.
        
        Change-Id: I8949ae61d96043412425d634763d2ea33ce6a0f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160910
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-12-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [345b02e7d445ad69d608a11429e16f6d8eb6959a]

        Update --enable-online-update-mar server URL
        
        ...after consultation with hostmaster@documentfoundation.org about an
        appropriate URL
        
        Change-Id: Ie8214081b68fb14f1a7824ea7cc2301abe8c1642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161070
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [2c0f520c03941f6ec09c8a52bd2b2bd38ba2b9a4]

        package: ODF encryption: fix 2 GPG problems
        
        1. ManifestImport should attach KeyInfo to the first file-entry, not to
           a "/" entry which may not exist or may be preceded by another
           file-entry which requires the KeyInfo to decrypt
           (regression from commit 91f35f22f0447769c08ca89e27a39b40df18fffa)
        
        2. manifest:key-size on manifest:key-derivation is unfortunately
           specified to have a default value of 16, but with AES256 the actual
           size is 32, and for GPG the ManifestExport forgot to export it
        
        Change-Id: I05dd2c9e219ba7f20ba33bf0b35d47a9e3df74cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161072
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [2f512aaa6c39390a5a0eb1d1e37f070127d068a4]

        tdf#105844 offapi,package,sfx2: use Argon2 for wholesome ODF encryption
        
        https://www.rfc-editor.org/rfc/rfc9106.html
        
        * add css::xml::crypto::KDFID constant group
        * add "KeyDerivationFunction" to setEncryptionAlgorithms sequence
        * Argon2 is used by default for wholesome ODF encryption, but
          $LO_ARGON2_DISABLE can be set to use PBKDF2
        * extend various structs in package
        * use 3 new ODF attributes "loext:argon2-iterations" "loext:argon2-memory"
          "loext:argon2-lanes" to store the arguments
        * use this URL for now:
          "urn:org:documentfoundation:names:experimental:office:manifest:argon2id"
        * use default arguments according to second recommendation from "7.4.
          Recommendations" of RFC9106; 64 MiB RAM should hopefully not be too
          much even for 32 bit builds
        
        Change-Id: I683118cc5e0706bd6544db6fb909096768ac9920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161009
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [70ef230aae4f961c8197cc11a7ff5feaf1d96c20]

        gtk4 a11y: Remember LoAccessible for XAccessible
        
        Don't create a new `LoAccessible` for an `XAccessible`
        each time, but add a `GtkAccessibleRegistry` class that
        remembers the corresponding `LoAccessible` for
        an `XAccessible` in a map.
        
        Remove the entry from the map again in
        `GtkAccessibleEventListener::disposing`.
        
        This prevents Libreoffice from becoming unresponsive
        in local WIP branches of both, gtk and LO that add
        handling for changes to the focused state, when used
        with the Orca screen reader.
        
        This commit is very similar to what was added for the Qt-based
        VCL plugins in
        
            commit 812fe185fba48b439fb1229517d62aa67c209016
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Aug 24 11:42:04 2022 +0200
        
                qt a11y: Remember and reuse existing QObject for XAccessible
        
        Change-Id: Ib217b477bf15abf255fcf254bf607ab8fc11a040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161061
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-20  Michael Weghorn  <m.weghorn@posteo.de>  [552a0a0e4daaac6896995b1ce63a44df6582ade2]

        gtk4 a11y: Silence loplugin:unreffun a different way
        
        Including the `a11y.hxx` header in another source file
        would result in an `--enable-werror` gcc 13.2.0-7
        build on Debian testing failing like this
        (real use case is in a following commit, but this is
        also reproducible by including the header in
        `vcl/unx/gtk4/gtkaccessibleeventlistener.cxx`):
        
            In file included from .../vcl/unx/gtk4/gtkaccessibleeventlistener.cxx:15:
            .../vcl/unx/gtk4/a11y.hxx:19:24: error: ‘void* lo_accessible_get_instance_private(LoAccessible*)’ declared ‘static’ but never defined [-Werror=unused-function]
               19 | static inline gpointer lo_accessible_get_instance_private(LoAccessible*);
                  |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            .../vcl/unx/gtk4/a11y.hxx:21:24: error: ‘void* ooo_fixed_get_instance_private(OOoFixed*)’ declared ‘static’ but never defined [-Werror=unused-function]
               21 | static inline gpointer ooo_fixed_get_instance_private(OOoFixed*);
                  |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            cc1plus: all warnings being treated as errors
            make[1]: *** [.../solenv/gbuild/LinkTarget.mk:337: .../workdir/CxxObject/vcl/unx/gtk4/gtkaccessibleeventlistener.o] Error 1
            make: *** [Makefile:290: build] Error 2
        
        However, just removing the declarations would make loplugin:unreffun unhappy:
        
             .../vcl/unx/gtk4/a11y.cxx:568:1: error: Unreferenced externally invisible function definition [loplugin:unreffun]
            G_DEFINE_TYPE_WITH_CODE(LoAccessible, lo_accessible, G_TYPE_OBJECT,
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:1842:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE'
            #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)          _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:2325:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN'
              _G_DEFINE_TYPE_EXTENDED_BEGIN_PRE(TypeName, type_name, TYPE_PARENT) \
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:2280:24: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_PRE'
            static inline gpointer \
            ~~~~~~~~~~~~~~~~~~~~~~~^
            <scratch space>:101:1: note: expanded from here
            lo_accessible_get_instance_private
            ^
            .../vcl/unx/gtk4/a11y.cxx:857:1: error: Unreferenced externally invisible function definition [loplugin:unreffun]
            G_DEFINE_TYPE_WITH_CODE(OOoFixed, ooo_fixed, GTK_TYPE_FIXED,
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:1842:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE'
            #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)          _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:2325:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN'
              _G_DEFINE_TYPE_EXTENDED_BEGIN_PRE(TypeName, type_name, TYPE_PARENT) \
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            /usr/include/glib-2.0/gobject/gtype.h:2280:24: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_PRE'
            static inline gpointer \
            ~~~~~~~~~~~~~~~~~~~~~~~^
            <scratch space>:131:1: note: expanded from here
            ooo_fixed_get_instance_private
            ^
            2 errors generated.
            make[1]: *** [.../solenv/gbuild/LinkTarget.mk:337: .../workdir/CxxObject/vcl/unx/gtk4/a11y.o] Error 1
            make: *** [Makefile:290: build] Error 2
        
        Silence these 2 loplugin:unreffun errors using a different
        approach instead, as suggested by Stephan Bergmann in [1].
        
        [1] https://gerrit.libreoffice.org/c/core/+/161060/comments/3e6ccbd5_87243200
        
        Change-Id: I4c3a1c34bfaa5ac6c306881e3caff2e04d6992dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161060
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [dee13501d67ac544c090d68c95c9a9df75f8bf27]

        lok: Block requests to load external references
        
        - currently in LOK case we don't open multiple files in
          one "environment"
        - currently it opens import dialog which is synchronous - and that
          blocks whole app
        
        Change-Id: I11c2c7f602ecf1e29b3d6fb2930ce873749bc2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159984
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161058
        Tested-by: Jenkins

2023-12-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2e4b6aac3e3d07552710d7394cc7d65f1a8c79c8]

        Fix typo
        
        Change-Id: I27edc69dc2358a52dbbac54aba0729da73165506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161065
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-20  Julien Nabet  <serval2412@yahoo.fr>  [bc00fb6de3ffd3949a3cdb524f49dac7e32258a9]

        Related tdf#158739: blacklist Nvidia RTX 4050 for Skia hardware rendering
        
        Change-Id: I0a6795fafed04e3061cb660736234d6f04eb8872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161032
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ff8dea531a9d7fa7d9dcc61bad73dabda94560d9]

        Remove executable bits on data files
        
        Change-Id: I7f26ee458004e2cafda42c119118d96b7bafd0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161066
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b721e4c5fceb9fe85a91a6e290ac8a27308a7157]

        Fix typo
        
        Change-Id: Ib5f99a525deeaddbc9e85081acbba62bd6a9cb7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161064
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [6ca67850d471478542bec458e1ea94175e5bba14]

        Revert "updater: check every 12 hours for updates for now"
        
        This reverts commit bb5622adc5db348efcc9a6f41d19de9f00a367dd, going back to a
        less aggressive 7 day period for now.
        
        Change-Id: I439a49f3ca6761ef17ca2b92d395b0de5c400197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161050
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-20  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a731395303015107a1d9f2cfd568f6390ee3cd1d]

        Set --with-online-update-mar-channel for distro-configs/LibreOfficeWin64.conf
        
        (Somewhat randomly setting it to the same name that is used, via
        -DMAR_CHANNEL_ID=\"LOOnlineUpdater\" in external/onlineupdate/Executable_mar.mk,
        as the default channel name in the mar executable tool that we build.)
        
        Change-Id: Ia77e3e841139947dad894efa81f011cafd6c7539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161049
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-20  Justin Luth  <jluth@mail.com>  [5032244819e861899bc5f45bd097624ffa1caa40]

        tdf#111969 sw: acknowledge that last half-character for smart tags
        
        This fixes CTRL-clicking on the last half-character of the smarttag
        and having nothing happen, or triggering it
        with the half-character before the smarttag.
        
        This is a suggested follow-up to right-clicking on a selection,
        which had the same problem.
        
        smart tags need an extension to activate,
        so a unit test is impractical in this case.
        
        Change-Id: I151c28090b5a6701df16dab95992eeae2aec3ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161033
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-20  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b763e68a5641933d1ea2fd449b1faf0e4097b7a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ba5e041e6e4e259a69160b90afed882c8c0f664
          - tdf#158105 Change character "background" to "highlighting color"
            
            Change-Id: I9352093a3dfa4af8f763aba6bf2b5914b1f2b071
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161051
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-12-20  Bogdan B  <buzea.bogdan@libreoffice.org>  [6c535425adae84ab5e841e0b04584481e0874edf]

        tdf#158105 Change character "background" to "highlighting color"
        
        Change-Id: I98dcc9cf0d2e3306275a25ed83dc5692211ed442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160037
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f78a9d7d86af7d513ec7020ccfa96f6051d45fdc]

        ofz#65182 putcontig8bitYCbCr22tile issue
        
        Change-Id: I0242059b17d07c0ab4ec83aabd073ee31c4631d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fdb37b71b563c3ffa90b5b0c4643fdad62b9c67c]

        cid#1545835 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545830 COPY_INSTEAD_OF_MOVE
        cid#1545798 COPY_INSTEAD_OF_MOVE
        cid#1545784 COPY_INSTEAD_OF_MOVE
        cid#1545753 COPY_INSTEAD_OF_MOVE
        cid#1545752 COPY_INSTEAD_OF_MOVE
        cid#1545672 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iaf2f77cb27ae0ea1585416a0c500f7c50d04e3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [fc5c81ced846adae2dbaccf78105d47b01d92269]

        argon2: oops, forgot to build static lib with -fPIC
        
        ... and Julien Nabet reports that Debian's default shell dash doesn't
        have "time", oddly enough.
        
        Change-Id: I82734bdf9e943522471c4c9189fac463bca2a3aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161008
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-20  Miklos Vajna  <vmiklos@collabora.com>  [ea1a05e43e002444d224fa47e87fc79f921ae10b]

        CppunitTest_sw_rtfexport: avoid SwModelTestBase::getLength()
        
        Better to check the body text, not just the length.
        
        Change-Id: Id98cc408772c5d2c135bdd184d58a5eb12f1c011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161005
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b64f23b235d6fd7c9f6197da0f5f0432fede4294]

        ofz#65165 Stack-buffer-overflow READ 4 test case
        
        make VALGRIND=memcheck CppunitTest_tools_test
        
         Conditional jump or move depends on uninitialised value(s)
            at 0x13348ADA: BigInt::DivLong(BigInt const&, BigInt&, BigInt*) const (bigint.cxx:306)
            by 0x13349A0A: BigInt::operator/=(BigInt const&) (bigint.cxx:635)
            by 0x12A58F67: tools::BigIntTest::testLenB1() (test_bigint.cxx:103)
            by 0x12A5C6A8: void std::__invoke_impl<void, void (tools::BigIntTest::*&)(), tools::BigIntTest*&>(std::__invoke_memfun_deref, void (tools::BigIntTest::*&)(), tools::BigIntTest*&) (invoke.h:74)
        
        if ( (static_cast<sal_uInt64>(aTmpB.nNum[nLenB1 - 1]) * nQ) >
                                                 ^ nLenB1 is 0
            ((nTmp - static_cast<sal_uInt64>(aTmpB.nNum[nLenB1]) * nQ) << 32) + aTmpA.nNum[j - 2])
        
        Since:
        
        commit bcbc0857bf4bc24b5ea36e445a367cce0a382da4
        Date:   Sun Dec 17 21:11:31 2023 +0300
        
            Simplify BigInt
        
        Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com>
        Change-Id: Id8dbff23f7b4312ba666e1443c41b7869713bfbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160953
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-20  Justin Luth  <jluth@mail.com>  [7e32aec38ed386a01c522bbb5cf0e80dd924a815]

        related tdf#111969 fix smart tags job not being fired, due to typo
        
        This fixes quikee's 7.5 regression
        commit 01396925b76011ffccb6eea40956a22d58de6f17
        
        If this is a help document, we don't want to run smart tags,
        not the other way around.
        
        It was correct originally - assuming this was just
        a typo when the tests were pulled out into a function.
        
        Change-Id: Ie21ed256539ce242a7892c1ddc1556319fc45310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161006
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-19  Weblate  <noreply@documentfoundation.org>  [78e72be805e9b41617d752e0da8c04b7bf5dd269]

        Added translation for android-viewer using Weblate (Indonesian)
        
        Change-Id: I55e7159ff10e7bb0ee32651a8f23f2f3a4e1282c
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ica863fed7663f5f5c17820a4010262101fcc358c
        
        android-viewer translated using Weblate
        
        Nepali currently translated at 16.9% (20 of 118 strings)
        
        Change-Id: Ifc64ae37b7faa5bad89f70178565595630993420
        
        android-viewer translated using Weblate
        
        Greek currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Icb257e6a5cfd38de5a27425f69294e059796e596
        
        android-viewer translated using Weblate
        
        Ukrainian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Iddf1e095b789f2a324fbc614d57b98ab3df8ed0e
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I318be3807e77e190d857f1d9edd25fc9d7a60c0a
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: If8105733d78073254da1ccd16817581d53ab55b8
        
        android-viewer translated using Weblate
        
        Chinese (Traditional) currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I7ef697098031684e32aed137b2ac6bd844ed94fb
        
        Added translation for android-viewer using Weblate (Nepali)
        
        Change-Id: I2d68cb2696827a6cd6e2ad634873857344c8ac9f
        
        android-viewer translated using Weblate
        
        Greek currently translated at 57.6% (68 of 118 strings)
        
        Change-Id: Ic029d631692c1f47a9d7eeda13ce6ac38a59c3b8
        
        android-viewer translated using Weblate
        
        Greek currently translated at 56.7% (67 of 118 strings)
        
        Change-Id: Id3456928ecb1a9aab0c27e77fbe49a02540fd8c4
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 58.4% (69 of 118 strings)
        
        Change-Id: Ibaf90837a1f25d070f9dd8ac183fbca6c26e85c4
        
        android-viewer translated using Weblate
        
        Italian currently translated at 11.8% (14 of 118 strings)
        
        Change-Id: I64eb0e5cbf5a6ab050c6ef18a1adae68317005d8
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 32.2% (38 of 118 strings)
        
        Change-Id: Ie470cf5f249a0e498413571cd0b56a5421f5710a
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 32.2% (38 of 118 strings)
        
        Change-Id: I687ae9fe76f85a03f0876f4eda55d943f51b43fb
        
        android-viewer translated using Weblate
        
        Slovenian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I0c0cc15c6d5f245311c12d05afd4742db649389d
        
        android-viewer translated using Weblate
        
        Chinese (Traditional) currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I2ddc5b6a36a512e6e4d1e52c96e282b0ff05f2ea
        
        android-viewer translated using Weblate
        
        Welsh currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I34dbcafeaf61e7400d07910976ff71fdbe8ae4b0
        
        Added translation for android-viewer using Weblate (Greek)
        
        Change-Id: Idfc6ee0a0988f3c414e6e6beee58a96ab5fb9547
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Andika Triwidada <andika@gmail.com>
        Co-authored-by: Cheng-Chia Tseng <pswo10680@gmail.com>
        Co-authored-by: Dimitris Spingos <dmtrs32@gmail.com>
        Co-authored-by: Elisabetta Manuele <calembour@hotmail.it>
        Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
        Co-authored-by: Po-Yen Huang <jeff.huang@ossii.com.tw>
        Co-authored-by: Rhoslyn Prys <post@meddal.com>
        Co-authored-by: Saroj Dhakal <lotusnagarkot@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Weblate <noreply@weblate.org>
        Co-authored-by: Xandru Martino Ruz <xandrumartino@softastur.org>
        Co-authored-by: Євген Кондратюк <lachend@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/el/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/uk/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/zh_Hant/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160909
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [a30f8ee1121aa2448be047f104a099b3272e6bde]

        tdf#123864 gtk3 a11y: Consider states when mapping BUTTON_DROPDOWN
        
        Take the checkable state into account when mapping the
        `AccessibleRole::BUTTON_DROPDOWN` role.
        
        There is no direct ATK equivalent for
        `AccessibleRole::BUTTON_DROPDOWN`.
        Don't always use ATK_ROLE_PUSH_BUTTON, but
        use ATK_ROLE_TOGGLE_BUTTON when the button is CHECKABLE,
        i.e. it can be toggled.
        
        With this in place, Orca now announces the state of
        the underline button (on/off) when using the gtk3
        VCL plugin.
        
        Related Orca source code that requires the toggle button
        role: [1]
        
        The state is not announced when using the qt6 VCL
        plugin yet, and Qt currently doesn't have a toggle button
        role, so that would have to be added there first to
        do something similar there.
        
        For gtk4, mapping could probably be done similarly,
        but more is missing for Orca to announce things in
        custom widgets (e.g. event handling),
        so leave that for later.
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/blob/b80bb951a651f5f12a5ddfb2a5b1c151568d045b/src/orca/scripts/apps/soffice/speech_generator.py#L177
        
        Change-Id: If69e08d2e4939cc709d44e89cc2fd1d01691a70b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160904
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  László Németh  <nemeth@numbertext.org>  [36bfc86e27fa03ee16f87819549ab126c5a68cac]

        tdf#119908 tdf#158776 sw smart justify: shrink only spaces
        
        For interoperability, only shrink spaces up to 20%,
        not the lines up to 2%.
        
        Follow-up to commit 20cbe88ce5610fd8ee302e5780a4c0821ddb3db4
        "tdf#119908 tdf#158419 sw smart justify: fix cursor position"
        and commit 7d08767b890e723cd502b1c61d250924f695eb98
        "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt."
        
        Change-Id: Idb43161cb5a57c3412abd3f0eb266c6afbe5363c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160988
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-12-19  Oliver Specht  <oliver.specht@cib.de>  [9e127010a86b3521c803ac86c0b5f58dc8e2966b]

        tdf#158044 writerfilter: handle toggle properties in import/export
        
        DOCX has some odd properties (bold, italic, shadowed, hidden ...),
        which switch on/off if they are applied multiple times, e.g. with
        paragraph and character styles. To fix that, a hard attribute has to
        switch off the attribute in that occasion on import and on export a
        hard attribute switches it on in Word.
        
        Includes partial fix for tdf#154370.
        
        Change-Id: Ie4c317cf9b7d02efd89b9d6a9996143585d7e937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160343
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [dc8632a8b5c5dc4f58a4677d90f2f05133aa713d]

        Drop some wrapper methods from SvtOptionsDrawinglayer
        
        just use the wrapped officecfg methods instead of:
        IsSolidDragCreate
        IsRenderDecoratedTextDirect
        IsRenderSimpleTextDirect
        GetQuadratic3DRenderLimit
        GetQuadraticFormControlRenderLimit
        IsTransparentSelection
        
        Change-Id: Ie0f3ec0f8fdbbf08facfff1a372c666c8a0c8979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160654
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cbc8cbeb17753296b7dc45bd146bc80a7275866a]

        Fix typo
        
        Change-Id: Ie9848c31ee4969d61470dfb5b570e45848f0914d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160992
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [323ebf99dad30e334a7806491d8597b9a23d614a]

        split ScGridWindow::UpdateFormulas into two parts
        
        a) figures out what might need to redraw
        b) triggers redraws on that
        
        Change-Id: Ib6e1d8d0785cc629fd2cfb0cfdc4ad43897fd4f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161012
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [958a055be8d58137e1a32c5cd18f67d1aab3012d]

        Improve --enable-online-update-mar Windows MOZ_MAINTENANCE_SERVICE feature
        
        To get the MOZ_MAINTENANCE_SERVICE mode going at all, update.status needs to
        contain a "pending-service" token.  For Mozilla, code in its
        toolkit/mozapps/update/UpdateService.sys.mjs takes care of writing that.  For
        us, lets always write that in update_checker() (even on Linux, where it's
        apparently harmless).
        
        Then, the MOZ_MAINTENANCE_SERVICE code is rather picky with its various sanity
        checks:  Among other things, it expects argv[0] to be a full path to the updater
        executable, and it expects the update.mar (and its status and log files) to be
        in a directory hierarchy named updates/0/ rather than patch/.  So get all that
        fixed in desktop/source/app/updater.cxx.  And patch in
        external/onlineupdate/lo.patch where it expects to find the updater executable
        (just updater.exe vs. our program/updater.exe).
        
        And we shouldn't interfere with the upstream Mozilla maintenance service, so
        also rename that in external/onlineupdate/lo.patch.
        
        And `update_service install` wants to read version resources from the
        update_service.exe, so provide that (via gb_Executable_add_default_nativeres).
        
        Also, `update_service install` wants to read a MozillaMaintenanceDescription
        value from an updater.ini, so provide one (with contents of that value inspired
        by Mozilla's browser/locales/en-US/updater/updater.ini).
        
        As we now have an updater.ini anyway (and which apparently works fine with Unix
        line ends on both Linux and Windows), also use it on Linux and drop the
        onlineupdate/source/update/updater/progressui_gtk.cpp again from
        external/onlineupdate/lo.patch.  And update external/onlineupdate/README.md how
        to manually execute that test against an updater.ini.
        
        Change-Id: I0e3e5e5311be61e1224cda700af2e5d751113a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160996
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-19  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [bbb7c3eeccef61ec0c4c8332296705e96f0e6538]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d2a9b80fbb89596185c5b6863713eb696af7140
          - tdf#156156: add Inspector and Functions sidebar decks help button's HID
            
            Change-Id: I2c149959d2c0bcdc4aa98777b759012fe490637b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/161010
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [2217934a466052747b02ae855609639326f8a81b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1afd64c6b742bcd7a1b0fd7d8bb16c7a54e91aa0
          - tdf#142926 Add HID to new Built-in help page
            
            Now that the change to the dialog has been merged (see [1]), this patch adds the appropriate target HID to the help page.
            
            This does not need to be cherry-picked to 24.2, since the change to the dialog will only be present in 24.8.
            
            [1] c48952eb6b6f65affcda75ee74c292008be9c455
            
            Change-Id: I5097264191af59a1585fec5f03acc82b708c401d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160948
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [3097d40ab6aa6f8fa59e82b22492e24634b7e7aa]

        Drop commented-out code
        
        Change-Id: Ie433daf9f2d0117d798202219423e328631a8cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161002
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-19  Miklos Vajna  <vmiklos@collabora.com>  [e83309d97d0bbad131a7fdfd365fb6122d6f415b]

        cool#7853 sc lok: fix bad view id on hyperlink click
        
        The document had 2 windows. The first window was typing in column A, the
        second window ctrl-clicked on a hyperlink in column B. The LOK callback
        was emitted in window 1, not in window 2, which is unexpected.
        
        What happens is that ScGlobal::OpenURL() dispatched an async command
        when window 2 was active, and we happened to be in window 1 when
        processing that user event from the main loop.
        
        Fix the problem by dispatching the URL open command in a synchronous
        way, so the LOK view can't be different.
        
        An alternative would be to track the current LOK view id for posted user
        events, and set the view back to the one which was current at post-time
        before executing the event. We can consider doing that in a follow-up
        change, but this fixes the problem at hand and is a safe fix.
        
        Change-Id: I9a3c9fc1b90ad538d8b2510c7844549c9881ca56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160976
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-19  Pranam Lashkari  <lpranam@collabora.com>  [9ca22d44e5293f3335a2b475ccef157d31c60b94]

        Keep selection as after copying the text
        
        This also aligns code with 'else' branch behaviour
        
        problem:
        in online when coping a slide with comment,
        comment text was never copied in online,
        it required document to reload to show it correctly
        
        Change-Id: I6d444c10808ef23f282370b4b305c41eb5043b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160812
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit db7faa06762ac902ff56ecbab3fff763951146e1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160943
        Tested-by: Jenkins

2023-12-19  Michael Stahl  <michael.stahl@allotropia.de>  [77c921302b7ef869aed28fcd0187c80095d6a766]

        argon2: add new external library
        
        Change-Id: I81860a94b33eba95918c30b0e92b583cc2d02ff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160969
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [21dd05a2a2909470f4bba76b0b10b3889043a10b]

        cid#1557601 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546498 COPY_INSTEAD_OF_MOVE
        cid#1546384 COPY_INSTEAD_OF_MOVE
        cid#1546376 COPY_INSTEAD_OF_MOVE
        cid#1546374 COPY_INSTEAD_OF_MOVE
        cid#1546373 COPY_INSTEAD_OF_MOVE
        cid#1546368 COPY_INSTEAD_OF_MOVE
        cid#1546365 COPY_INSTEAD_OF_MOVE
        cid#1546356 COPY_INSTEAD_OF_MOVE
        cid#1546340 COPY_INSTEAD_OF_MOVE
        cid#1546266 COPY_INSTEAD_OF_MOVE
        cid#1546236 COPY_INSTEAD_OF_MOVE
        cid#1546188 COPY_INSTEAD_OF_MOVE
        cid#1546178 COPY_INSTEAD_OF_MOVE
        cid#1546166 COPY_INSTEAD_OF_MOVE
        cid#1546156 COPY_INSTEAD_OF_MOVE
        cid#1546144 COPY_INSTEAD_OF_MOVE
        cid#1546143 COPY_INSTEAD_OF_MOVE
        cid#1546100 COPY_INSTEAD_OF_MOVE
        cid#1546078 COPY_INSTEAD_OF_MOVE
        cid#1546041 COPY_INSTEAD_OF_MOVE
        cid#1546036 COPY_INSTEAD_OF_MOVE
        cid#1546033 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib3586d93198992e206baf5c2de5a663d5574aa3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160979
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3dd1948e791e511557bc7be25aa3306439c9e94c]

        cid#1559313 Dereference null return value
        
        we already have the ScPostIt here
        
        Change-Id: I646cbe073be3a63f8aeaa4939406b56a73b6382e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [62afdd6f82c51cee330b278518622eaf1776e2c4]

        tdf#154864 Changing starting number of numbered list does nothing
        
        regression from
            commit cd3c16fbcb4f8e5e4c4448bc7cda96e8476d6aec
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Oct 14 15:14:13 2022 +0200
            tdf#129101 CTRL+A & Cut very slow
            avoid repeated invalidation of number tree, shaves 90% time off
        
        The problem is that, after the above change, InvalidateListTree is not
        called late enough to force invalidation of all necessary stuff.
        
        So simply delay that until we do re-validation in SwNumRule::Validate.
        
        Change-Id: I796cc34fe7d66d4876ee06286a8af7029a759eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [30ab6dd73a15781abce9153105ec43ee887aace1]

        Hide --enable-online-updaet-mar GUI behind ExperimentalMode for now
        
        (and rename SvxOnlineUpdateTabPage's is...OnlineUpdateEnabled predicates to
        is...OnlineUpdaetAvailable, to avoid the overloaded term "enabled" here)
        
        Change-Id: I639ac72a17b98c883ff3082747b8576099299867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160975
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [09ec97405a6097c0db6ff9dc2aaac263dcd0d718]

        tdf#154339: do not cache GetCellArea results for now
        
        Partially revert 0a55aa8ba38aea56a2bce1504fd687e510f66b9d
        "calc: cache GetCellArea results"
        
        Change-Id: I371a56f64afe541d9a194e6435fda3fb27bc43ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160349
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-19  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [b731cdfbd74a61ff389f479ae4cb4dcf261b1ccf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 64d940a42d41a4b77deacbfdb344cecf94975cf4
          - tdf#156156: add Accessibility Check sidebar deck help button's HID
            
            Change-Id: I6a0196a8f2d34dafd224ee5a4780c2ed1b97fbe9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160944
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [05a4badc97e446aa8f00ce96a2e311af71de5026]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5b39fee6d9f21ca6e155480cef1df612a61629e
          - fix link to Styles menu
            
            Change-Id: Ib1c8f2a24384d1282751796cebcee41d4c996f13
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160942
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [bd591ee35fd49abeddaf68dee80ce57989eb979a]

        tdf#158771: Alt+F12 is already defined
        
        Regression from
        
        author	Gökay Şatır <gokaysatir@collabora.com>	2023-09-27 13:01:46 +0300
        committer	Caolán McNamara <caolan.mcnamara@collabora.com>	2023-11-19 22:28:43 +0100
        commit	3bd3c41bc930406ec3d995a45a7f7060d572bbd0 (patch)
        tree	1678975acb61029e330df31390321c8786041e7b
        parent	f53172a1141f7bb3c0950f1fe00800b633846ec4 (diff)
        German keybindings:
        
        Change-Id: I2b7b39ad24c07b390f9cc152f6620548d14683ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160977
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [ff527c41a04c38aa88a665e669f19729cf68fd54]

        gtk4 a11y: Map COMMENT role to new gtk equivalent
        
        Map `AccessibleRole::COMMENT` to the Gtk 4
        equivalent `GTK_ACCESSIBLE_ROLE_COMMENT` newly
        added in upstream gtk commit [1]
        
            commit ab7592ee4f8ded4c3990cff5daf7f28ef26ac41f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Dec 6 14:34:43 2023 +0100
        
                a11y: Add article and comment roles
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/ab7592ee4f8ded4c3990cff5daf7f28ef26ac41f
        
        Change-Id: I2816f2caf04e7c70c5eed63c1ae7aea0c9e48dd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160396
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-12-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [0d512011a695da8dafe9467ec0ff7f564dfe8c88]

        Add flush mechanism to buffered Primitives
        
        There are the classes BufferedDecompositionPrimitive2D
        and BufferedDecompositionGroupPrimitive2D that offer
        a unified mechanism to preserve/buffer the decomposition
        of a Primitive, independent of the complexity. This may
        include e.g. the pixel representation of a 3D Scene,
        for Charts/CustomShapes and others.
        
        Until now these were refreshed when the objects change,
        or when the buffered decomposition decides that it is
        necessary, but there was no general mechanism in place
        to clean these up while the Primitive owning them was
        alive/used. This is not a big thing in Draw/Impress
        since this would only be relevant when zooming deep into
        a SdrPage, so the non-vislible parts would still hold
        data that would not be needed. But for Calc and Writer
        this is more relevant: A 3D Chart on the 1st page of a
        Writer document would be held buffered all the time a
        user would work on pages below that. This is good for
        guaranteeing fast re-visualization when scrolling up
        again, but until then would just block memory.
        
        So I added this general mechanism that allows activating
        flushing timer-based, on Seconds. The default is null
        seconds, thus deactivated. It should only be used for
        Primitives that can get expensive, not for all.
        NOTE: I checked activating for all Primitives to be on
        the safe side, works.
        
        It is now (initially) activated for:
        - GlowPrimitive2D
        - GraphicPrimitive2D
        - MetafilePrimitive2D
        - ScenePrimitive2D
        - ShadowPrimitive2D (softShadow)
        - SoftEdgePrimitive2D
        - SdrCustomShapePrimitive2D
        - SdrGrafPrimitive2D
        
        These are the usual suspects that may use some memory
        to buffer their decomposition (for good reasons, each
        repaint uses it). Other Primitives which may show need
        to be treated this way can easily be added, just by
        calling setCallbackSeconds(s) in their constructor. This
        is true for all Primitives derived from the two classes
        mentioned above.
        
        NOTE: Too short buffering times are *not* useful - e.g.
        for a expensive-to-be-recreated 3D chart representation
        this may not pay out, so I chose times in a way that try
        to respect this.
        
        NOTE: This change needs
        7397fa7cdfc33f5a079df42e4d6cfa59ae9e062d to work
        correctly (thanks to sberg for this). Without this the
        office hangs/does not terminate regularly in trying to
        destroy the 'TimerManager'.
        
        Change-Id: Id4802afcb6d12480bb2935cc1ef67fe443b3b788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160926
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e8248b5e4b19df8ba469d1ca3a762960c1a053b5]

        cid#1545222 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545241 COPY_INSTEAD_OF_MOVE
        cid#1545303 COPY_INSTEAD_OF_MOVE
        cid#1545315 COPY_INSTEAD_OF_MOVE
        cid#1545319 COPY_INSTEAD_OF_MOVE
        cid#1545322 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I284ba6e395f72abd7939667a8367ac99ab64194d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30fa383f27d9eed05d699681afb1ce76fb4248f9]

        emplace_back instead of push_back
        
        Change-Id: I1ea43002aba460fb81f4b2e710a19f0c3fe87c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160954
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [b7ba91311abaf1af4d97822e5c8eccc53b1e11fa]

        tdf#123864 a11y: Evaluate checkable/toggle flag for more toolbar items
        
            commit 4342408a8359e590f57b016baaf7d8dcfdebdbd4
            Author: Carsten Driesner <cd@openoffice.org>
            Date:   Thu May 6 18:15:21 2010 +0200
        
                fwk142: #i104293 Use Commands.xcu files to mark commands which support a toggle state
        
        introduced a `UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON` state
        to mark commands that can be toggled, see `framework/inc/properties.h`.
        
        Despite that one being set for the `.uno:Underline` command in
        `officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu`,
        the underline button in Writer's formatting toolbar would not expose
        the CHECKABLE a11y state even after
        
            commit 78241a40628e5721aa50cb0fa13a63333343f766
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Dec 18 08:48:12 2023 +0100
        
                tdf#123864 a11y: Handle new CHECKABLE state in misc places
        
        because the state set in the .xcu file was only applied
        in `ToolBarManager::CreateControllers` in the code path where
        no controller is set.
        
        There seems to be no particular reason for that, so move this
        out of that block so this gets run for other items, too.
        
        With this in place, the underline button in Writer's formatting
        toolbar now has the checkable AT-SPI state when using the gtk3
        VCL plugin.
        
        (Orca still doesn't announce the button as checked when it is,
        despite the checked state also being set then, but that's another
        aspect that will be addressed in a separate commit.)
        
        Change-Id: Ib9200077a95feea3ce7c0380b9b8f31c96632223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160903
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [eef4d5cbd10a042bd3b5fb555e0bf9b0dd7d1215]

        tdf#123864 a11y: Handle new checkable state for VCLXAccessibleMenuItem
        
        Add reporting for the new CHECKABLE a11y state introduced in
        
            commit d6c6472bbe1c90b733a4d69c4c8528f4de3750d3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Nov 13 15:53:44 2023 +0100
        
                tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
        
        for `VCLXAccessibleMenuItem`.
        
        `MenuItemData::HasCheck` looks like it already provides
        what's needed to say whether an item is checkable, therefore
        add a `Menu::IsItemCheckable` that makes use of this and
        and a `VCLXAccessibleMenuItem::IsCheckable` that
        makes use of that in turn.
        
        Extend `VCLXAccessibleMenuItem::FillAccessibleStateSet` to
        use the latter to report the CHECKABLE state accordingly.
        
        Change-Id: Id23196ef2527a71a338102a5143a8bd6fd41db84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160902
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [8bc6119812223643b50dcd22c504f9f853976352]

        tdf#123864 a11y: Handle new CHECKABLE state in misc places
        
        Add reporting/handling of the CHECKABLE a11y state
        added in
        
            commit d6c6472bbe1c90b733a4d69c4c8528f4de3750d3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Nov 13 15:53:44 2023 +0100
        
                tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
        
        in various places where it seems pretty straightforward.
        `VCLXAccessibleMenuItem` is a bit more complex and will be
        handled separately.
        
        Change-Id: I212b8439609d34410413959973163aa7d809cbf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160901
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [36123d802af0e115628d38fe0e0a30d65885e9fb]

        gtk3 a11y: Drop dead debug code
        
        Change-Id: I84ce9541c5d67416498bc5a36f0125c4110ffce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160900
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Michael Weghorn  <m.weghorn@posteo.de>  [c24ed12d1098bb0a3faf1774fd8bd5f686fb49ab]

        gtk4 a11y: Add initial event handling
        
        Add a `GtkAccessibleEventListener` that is in
        charge of handling a11y events for the gtk4
        VCL plugin.
        
        This is inspired by how the Qt-based VCL plugins
        do it (see `QtAccessibleEventListener`).
        
        Initially, only handle the
        `css::accessibility::AccessibleEventId::STATE_CHANGED`
        for the `AccessibleStateType::CHECKED` state by updating
        the value for the corresponding Gtk state.
        
        With this in place, toggling e.g. the "Bold"
        toggle button in Writer's formatting toolbar
        now properly updates the "checked" state of
        the corresponding a11y object in Accerciser's
        tree view of LO's a11y hierarchy.
        
        Gtk takes care of sending a corresponding
        "state-changed" event on the AT-SPI layer:
        
            10.8 object:state-changed:checked(1, 0, 0)
                source: [toggle button | Bold]
                application: [application | soffice]
        
        Handling state changes to other states that map to a
        `GtkAccessibleState` should be possible in a similar
        way.
        
        However, other states - like the FOCUSED state - map
        to a `GtkAccessiblePlatformState` in Gtk 4, and the
        function `gtk_accessible_platform_changed` to update these
        that is used by Gtk's own widgets is private API for now,
        so cannot be used by LibreOffice, so I currently don't
        see a way to handle these without changes on Gtk side
        (see [1]).
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/issues/6272
        
        Change-Id: I2a5ca4448ad14a61dc96aef7b22af36baeeed5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160929
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-19  Justin Luth  <justin.luth@collabora.com>  [016f779ee6c7f601be3ae19dc57497e63a5bf817]

        tdf#158586 RTF writerfilter: substitute hasProperties for inFrame
        
        A proper inFrame() would be identical to hasProperties,
        so just substitute the existing, complete function for inFrame.
        
        This is based on a code read, not a problem document,
        but finding a document that depended on inFrame
        returning true made it trivial to modify it to fail.
        
        Somewhat surprisingly, it made it all the way through
        the rtfexports without failing.
        
        make CppunitTest_sw_rtfimport CPPUNIT_TEST_NAME=testFdo52052
        
        Change-Id: I96f00c9b542dabd3709a896d778569b7681c8f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160928
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-19  Justin Luth  <justin.luth@collabora.com>  [e915d9f6973c742a1d810c460d895a93522d3308]

        related tdf#158586 RTF writerfilter: HAnchor's default is text, not margin
        
        \phcol: Use the column as the horizontal reference frame.
        This is the default if no horizontal reference frame is given.
        
        Change-Id: I8ef4a35c578768810edc0a68e3fd3b227c069dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160776
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-12-19  Justin Luth  <justin.luth@collabora.com>  [cf58950b281c85c366e0948557151a0fe104ed81]

        partial revert tdf#153178 writerfilter: do not create text frame spuriously2
        
        If HoriAlign/VertAlign are defined, that is enough to create a frame.
        
        This fixes mstahl's 7.6.4 regression originating with
        commit 4e2f2489c4c7436f8b3a21a530bc625cbef4e365
        
        make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_lostFrame
        
        Change-Id: Ibb639673cebcd8d5ec79f5551a5703caf948e0d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160744
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-19  Justin Luth  <justin.luth@collabora.com>  [940b60c903b11340979eaf37b9b1dad5d823a1c4]

        partial revert tdf#153178 writerfilter: do not create text frame spuriously
        
        If HoriAnchor/VertAnchor are assigned, that is enough to create a frame.
        
        make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0B
        
        Note: because of a regression, this was already one page before
        this commit, so need to go back to the time of the reverted patch.
        
        Change-Id: Iddbe1cc4ba6d6e95e2d977a227ae6cab5271007e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160743
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-19  Justin Luth  <justin.luth@collabora.com>  [798649ec30b536614048aa457fb9c8d4dce30b31]

        tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame
        
        This fixes a LO 7.6.4 regression of a lost page break,
        as well as another example where part of the paragraph moves to next page,
        from mstahl's commit 4e2f2489c4c7436f8b3a21a530bc625cbef4e365
        
        It seems likely that the run should only be checked
        when we know that there is a real frame here,
        which essentially becomes a run for most purposes
        (except perhaps for page breaks - as seen for DOCX).
        
        This code block was introduced with
        commit 0d9132c5046e15540abc20e45d64080708626441
        Author: Miklos Vajna on Sat Mar 24 13:04:54 2012 +0100
            fdo#47036 fix RTF import of shapes inside text frames
            at the start of the doc
        and in the other block of touched code, it did test inFrame.
        
        The unit test works when compiling right after the regression,
        but has broken because of tdf#153194.
        
        Since this will get backported way back and all over,
        it is a good time to introduce rtfexport8.
        
        make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0
        make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_1
        
        Change-Id: Ib4b75efb8422d96e693da337cbef97520e975f3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160655
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-19  Miklos Vajna  <vmiklos@collabora.com>  [83cbadeaf6b784fa9ae2ca47d1a10bc942adfe79]

        sw: document SwFormatFieldHint
        
        Describe the typical producer and typical consumer.
        
        Change-Id: Iea2ae67f6a17bc5d84ce0bdc0690d13a22218ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160950
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-19  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f8199c424412f56edb1c64fada27e0c94d34fe79]

        tdf#158593 Make configmgr READONLY Property more useful
        
        ...to reflect whether or not the corresponding item can be modified.  Which
        matches what the READONLY flag is actually used for today.  (And the original,
        somewhat arbitrary semantics had been assigned without much thought, IIRC, and
        it should be OK to change them.)
        
        Change-Id: I8185e47519a5cb4aff6e8f260326845276b0c092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160957
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-19  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [ca046e50ff48b06d3ea12ded48c3420be0fff341]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a08e4de6931f915b708a749d82d841bf0f6a8032
          - tdf#156156: add Gallery sidebar deck help button's HID
            
            Change-Id: I15ff9b62bd14eef98eca54886f933eb4da21a26d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160868
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [34cf1d2e0f53fed3be177dffcf6d7ae42bc2924b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0565c612d43abbbd3ad454843d59770349b82487
          - tdf#155876 UI cmds Calc-Sheet menu (34)
            
            + Sheet menu for Calc, end
            + refactoring
            
            Change-Id: Iddbd6f37722ea6eb020431cecf42966ffee703ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160959
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [02ab65c86b8c5b273709ecf270a7111b4720680c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18
          - tdf#155876 UI cmds Calc-Sheet menu (33)
            
            + Sheet menu for Calc: manage Comments submenu
            + untangle Calc comments from Writer
            + refactoring
            
            Change-Id: I22b8e79b96d72b8918da04bc802cdd29c5d9dba0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160958
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [29b11fa3b5574dc3f42f55b0716f71054030c6c2]

        tdf#158766: handle Escape key in SmGraphicWidget
        
        Same as in SmEditTextWindow
        
        Change-Id: I4088fa2deb8b14d5cc0f48423dba492c45b0f61f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160927
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [62d80667f5b164e7a6377c22b0f37407ccf8eb59]

        Revert "[API CHANGE] Remove unused CrossFading group"
        
        This reverts commit cbc6bb9fdaf4acc815b9f11fba73c33d25a81e8f.
        
        Reason for revert: This config group is supposed to be used, see tdf#158304 for details.
        
        Bug reference now added to the config group.
        
        Change-Id: Id8d15b3f3c6abdec541e8ed7d3965259428b64fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160866
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4bcdbddf9a29d27c5246825826765377ef832800]

        add copy constructor for SfxItemSetFixed
        
        which flushes out the fact that, previously, when
        SfxItemSetFixed was being copied, we were not
        actually taking advantage of the "internal" memory,
        and were actually allocating a separate block of memory,
        like a "normal" SfxItemSet.
        
        Change-Id: I6a8073c58b464d53bfd2a54cf1dd27a3f2cb3df7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160377
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Andras Timar  <andras.timar@collabora.com>  [133959ca7658920928631eee99807aff2b77dc5f]

        Hide text boundaries by default - cool#3491
        
        Change-Id: I13d759e0782d2973957cc1bfbc28853ab5c3bc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160932
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2023-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [1325d66a7f8657aaf9951a0664fbf14cca86905b]

        tdf#158703: return updated position from FnAddNonBrkSpace
        
        The paragraph text may become shorter after the function succeeds,
        because it may remove arbitrary number of preceding spaces; since
        the position may then be used to access data in the string in the
        caller, we need to update it, to avoid use of old position (which
        may point beyond the string, and produce a crash; or it may point
        to a wrong position in it).
        
        Change-Id: Ib1b4b63cbd7150e0f69c97032e3410db7dadd4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160924
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [d05a74234d5ab6b029618281908552066fe04fa4]

        unique_ptr->optional in XMLTextFieldExport
        
        Change-Id: I161fd82784dfbb19ff42f83cacc24bf4b347206c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160911
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Miklos Vajna  <vmiklos@collabora.com>  [164fb25f7b2db7d833d6d0f28e49c5cac68426b3]

        tdf#158686 sw floattable: fix print preview crash
        
        Regression from commit b8521d969ab5be4fc947e467d4afe969f9d3b563
        (tdf#157263 sw floattable: prefer join over split after moving fwd,
        2023-09-25), enabling Options -> Writer -> Formatting Aids -> Hidden
        Characters, then opening the bugdoc, finally Toggle Print Preview on the
        toolbar resulted in a crash.
        
        We have a memory corruption here:
        
        	==11968==ERROR: AddressSanitizer: heap-use-after-free on address 0x60f0000734e0 at pc 0x7f473822d2ee bp 0x7fffdadd3660 sp 0x7fffdadd3658
        	READ of size 8 at 0x60f0000734e0 thread T0
        	    #0 0x7f473822d2ed in rtl::Reference<FmXFormShell>::operator->() const /include/rtl/ref.hxx:216:9
        	    #1 0x7f473821feeb in FmFormShell::IsActiveControl() const /svx/source/form/fmshell.cxx:1227:12
        	    #2 0x7f46dad4d52a in SwView::SelectShell() /sw/source/uibase/uiview/view.cxx:296:40
        	    #3 0x7f46dad496a6 in SwView::AttrChangedNotify(LinkParamNone*) /sw/source/uibase/uiview/view.cxx:572:13
        	...
        	    #32 0x7f4748944cda in SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) /sfx2/source/view/viewfrm.cxx:2552:32
        	    #33 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&) /sfx2/source/view/viewfrm.cxx:2637:29
        	freed by thread T0 here:
        	    #0 0x5568ff2f9a7b in operator delete(void*, unsigned long) /home/abuild/rpmbuild/BUILD/llvm-15.0.7.src/build/../projects/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
        	    #1 0x7f4738214346 in FmFormShell::~FmFormShell() /svx/source/form/fmshell.cxx:181:1
        	    #2 0x7f4746b04b9d in SfxDispatcher::FlushImpl() /sfx2/source/control/dispatch.cxx:1412:13
        	    #3 0x7f4746aff767 in SfxDispatcher::Flush() /sfx2/source/control/dispatch.cxx:157:26
        	    #4 0x7f47489100dc in SfxViewFrame::PopShellAndSubShells_Impl(SfxViewShell&) /sfx2/source/view/viewfrm.cxx:1100:24
        	    #5 0x7f47489441a3 in SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) /sfx2/source/view/viewfrm.cxx:2538:13
        	    #6 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&) /sfx2/source/view/viewfrm.cxx:2637:29
        
        I.e. a new SwPagePreview replaces the old SwView, but the order is that
        SfxViewFrame::SwitchToViewShell_Impl() starts with deleting the
        SfxShells of the old SwView in PopShellAndSubShells_Impl(), then it
        creates the new shell, finally deletes the old shell. Given that the new
        shell hides hidden characters and the old shell did not, this triggers a
        size notification for the half-deleted old shell and we crash.
        
        Seeing that SwView::AttrChangedNotify() already had code to delay the
        selection of an SfxShell in the old SwView, fix the problem by
        introducing a new flag that allows not selecting an SfxShell at all if
        the old view is known to be deleted in the near future anyway.
        
        An alternative would be to make sure that all relevant pointers are
        maintained using an SfxBroadcaster / SfxListener protocol, but after
        fixing some 4 of them and that's still not enough, probably it's better
        to handle this at a higher level. It's also a bit unclear how this
        "worked" in the past; looks like the old view didn't get the size change
        notification by accident.
        
        Change-Id: I423ff946f8235848cc3a870bc52fcf88a721fd2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160925
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-18  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d2c54902102ab9ee40cca16ae21f1bf3ad7c4066]

        -Werror,-Wdeprecated-declarations
        
        > compilerplugins/clang/casttovoid.cxx:452:18: error: 'endswith' is deprecated: Use ends_with instead [-Werror,-Wdeprecated-declarations]
        >                 .endswith(".h"));
        >                  ^~~~~~~~
        >                  ends_with
        > ~/llvm/inst/include/llvm/ADT/StringRef.h:276:19: note: 'endswith' has been explicitly marked deprecated here
        >     [[nodiscard]] LLVM_DEPRECATED(
        >                   ^
        
        etc. after
        <https://github.com/llvm/llvm-project/commit/5ac12951b4e9bbfcc5791282d0961ec2b65575e9>
        "[ADT] Deprecate StringRef::{starts,ends}with (#75491)" on Clang 18 trunk, where
        <https://github.com/llvm/llvm-project/commit/1b97645e56bf321b06d1353024339958b64fd242>
        "[ADT] Introduce StringRef::{starts,ends}_width{,_insensitive}" had been added
        towards Clang 16
        
        Change-Id: Icb3e43b7d6be6f877815285913d846f766eddebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160919
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3174749bb826fd653c923cadc98c7045a70bfd2f]

        tdf#158720 Fix crash when searching expert config with gen vcl plugin
        
        Change-Id: Ida2f17c8dfb638bb6791dba32ae3b190b06254de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160920
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0a431e89b743bc3b29716b4ef2ae863beff90f80]

        tdf#158186 Fix saving ApplyNumberingAfterSpace
        
        Change-Id: I6880f75c140f6e800bbdb6c56dd1ff166a3191d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160916
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [79bf66ee7bab7beac54be62f5dcfe9eeb8ca932d]

        Revert "[API CHANGE] Remove unused ApplyBulletsAfterSpace"
        
        This reverts commit a3a9ae3f564be4dd6549fe5708a593ea09d1e79c.
        
        Reason: This is required for tdf#158186
        Change-Id: I850cb277d1a6de0191f6249e2701454460a43e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160915
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b715d6633e4c6aad7aa3e68e7036b3827852f54c]

        TileExtent: Add bug reference
        
        Change-Id: Ia5994c49bc517230dc35485778d6a2d935fb2091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160918
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [44d0a0ac2ed91228d817a9e4e863eb444c5c3cc8]

        unique_ptr->optional in SdrObjGeoData
        
        and move it to its own header file to make the include dependencies
        easier to handle
        
        Change-Id: I9449ebd70d83be332e47e1786422697f76175e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [a66ffb4409b950c6847ab7ca7f6522f13338c3c4]

        unique_ptr->optional in SwDoc::ExecMacro
        
        Change-Id: I343e6ce50dcc6aac2182c11e5ca093f22c58c418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160914
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Justin Luth  <jluth@mail.com>  [5bc7d0186d1a70990377a2f4c630fe11e2dfd166]

        tdf#111969 sw: acknowledge that last half-character in Get*Correction
        
        This fixes right-clicking on the last half-character
        of a mis-spelled word,
        which previously did not pull up a spelling suggestion list.
        
        This is a suggested follow-up to right-clicking on a selection,
        which had the same problem.
        
        Probably everywhere that calls GetModelPositionForViewPoint
        without eTmpState.m_bPosMatchesBounds should be suspected
        of being wrong.
        
        Patchset 2 contains a unit test that ONLY passes on machines
        that have spell checking dictionaries on them.
        The concept in general is already tested is another patch,
        so I'll just drop this unit test that checks the spell-checking
        code path. It would easily break other people's
        development setups if they don't have en-US dictionaries.
        
        Change-Id: I3faa87d16eb3452f863052ea851a43a871125060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160872
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bff76421e234df7246a7f49c71a11432f86e09d1]

        tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides
        
        - Export correctly the "supported" master slides with the actual slides names.
        - Set SlideLayout property at ODF import as well for MasterSlides layout type.
        - When we copy a slide with the master slide also copy the SlideLayout property
        value as well.
        
        Change-Id: Idb6b88ebe87a83818d8eb27a1fa087652a002c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160290
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5aba83e7c1bc177270b585253ef27e6995f41f23]

        Remove duplicate test for PrintControls property
        
        Change-Id: I9f4a832cab84bd5815e696397fea3b7668386a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160898
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2ebcd853be89255451c269a463619f56987d0ed]

        unique_ptr->optional in OMarkableInputStream
        
        Change-Id: I2d3d761043068017cc5da823ec6c0fcda2432e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca3e55b2e0f316d900e0e4cc29a7e08252cb859c]

        unique_ptr->optional in OPipeImpl
        
        Change-Id: I8051da297e0742d7a823ed2e112a7f2c3748dfde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160907
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c683f38dcc202af9c261b18deaf27d3ee9743966]

        Add bug reference to unused config prop
        
        Change-Id: Icfc1378c4c7ff075af939c46701fe2d1a5e568ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160867
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6dbc5e2bf4bd24c53ae3b906a5f74fb7ceed6ab9]

        [API CHANGE] tdf#158041 Remove unused reverse printing option from sw
        
        Change-Id: I8b4597dbafc78e881fe556de8ce8221e50a673bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160777
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Miklos Vajna  <vmiklos@collabora.com>  [3930366328042b0fe8d63bc8a2eb827fd7e230a6]

        svx: prefix members of XColorEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: I5f666424a2f9cd2206f37b4440d54452e339e3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160891
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-18  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [4ae397a2a63141c54ebfa20c37c15a128c3bc663]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07ac0b21979bf5168f635b8b9f243a856353a4fa
          - Gradual Improvements
            
            Mainly refactoring:
            - remove " xml-lang="en-US""
            - remove empty lines
            - new indentations for better readability
            - inline "listitems" for better readability
            - inline <tablecell> for better readability
            - (hopefully) improved some wording
            - add relatedtopic where applicable
            
            Change-Id: I5459de8cd08cd680f01680d7287b222aff5ad78d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151784
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-18  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [eb1960b56db5086c5b6fd37def4d756a6052bb1c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07eb31ccb7b409e23c1d31506c7bccb8e3f601f1
          - Gradual Improvements
            
            All changes are tested with own builds on different builddirs (Windows)
            
            - split some paragraphs
            - switch to new syntax
            - improve markups
            - remove " xml-lang="en-US""
            - remove empty lines
            - new indentations for better readability
            - inline "listitems" for better readability
            - inline <tablecell> for better readability
            
            Change-Id: I9590fc59f61b494b44b5eafd6558b3f096c846e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151778
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-18  Noel Grandin  <noelgrandin@collabora.co.uk>  [956dc23fb132632f0bc2ab742f02a51699b40ae4]

        no need to allocate these on the heap
        
        Change-Id: Ic8a2bd941fa0f6b66e5ec386de5d15a38e6c75da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160899
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cbc6bb9fdaf4acc815b9f11fba73c33d25a81e8f]

        [API CHANGE] Remove unused CrossFading group
        
        Change-Id: I88869154b025a1eebb7b1bcf03decc4db02a3f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160895
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a13d138b8fd7d341a231b02efb76d8ad96d4b44f]

        [API CHANGE] Remove unused ShowAlienFilterWarning
        
        Change-Id: I36efe1d33cda83b6d063b30d9009aa79a3960ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160896
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4e53ccfba168aa0f234121905b1b988695d55bce]

        [API CHANGE] Remove unused PaintBuffer_Writer
        
        Change-Id: I3047de8576bc85b6852568343d0239738b189552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160892
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [bf817a071fab8c70f601745c5996618d65185df4]

        [API CHANGE] Remove unused EvolutionPreferences
        
        Change-Id: I71ab84f945576753a27b6a3df375c736fd8815d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160897
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6cdf523f179f3e7ed94267502a5fe3d1247398cc]

        [API CHANGE] tdf#158041 Remove unused drawing printing option from sw
        
        Change-Id: I95f81f166ab9d75622c83672101925894b2f2e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160774
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a3a9ae3f564be4dd6549fe5708a593ea09d1e79c]

        [API CHANGE] Remove unused ApplyBulletsAfterSpace
        
        Change-Id: I40e8361f31f834383fdc1762f58137c5326adaa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160890
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a0782355c212b8237a6bfa3ce1c5bb010bd4caba]

        [API CHANGE] tdf#158041 Remove unused table printing option from sw
        
        "for now it was decided that tables should always be printed"
        -> make this decision from 2015 permanent
        
        Change-Id: Ica5958a74ec6766040ab59f2c91224b75df4d807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160766
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-18  Rene Engelhard  <rene@rene-engelhard.de>  [d7577174b541e68158d228aa41192227c10a252f]

        fix system-abseil build even with 2022 version
        
        actually it seems it was a internal abseil header from pdfium vs. system
        header mismatch. Include proper absl/container/inlined_vector.h if using
        system-abseil.
        
        While at it we can also just use pkg-config, no idea why I did it
        without back then. Also gets the advantage that it knows that the libs
        needed for absl_inlined_vector is actually
        -labsl_throw_delegate -labsl_raw_logging_internal -labsl_log_severity
        
        This effectively reverts e89723103313ec4366ee58144c47d7a5c16bf838
        
        Change-Id: Ide4f79860b4e0673c5c6587d503058bdd2930744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160846
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-18  Andras Timar  <andras.timar@collabora.com>  [b548dff45019c631e084dd4990a23b5b87f8818d]

        reportbuilder: remove unused config files
        
        Change-Id: I9133dbae9183f17c82286f32cb5a55241f3ed714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160883
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c9d5bf3fe0e6b59f30107c42eac3d4603bf8f2b6]

        [API CHANGE] tdf#158041 Remove unused SinglePrintJobs config option from sw
        
        This is handled by the print dialog directly
        
        Change-Id: Ieb4221d97444216f332501da9a3aba7dc6b8500a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160762
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-17  Mike Kaganski  <mike.kaganski@collabora.com>  [bcbc0857bf4bc24b5ea36e445a367cce0a382da4]

        Simplify BigInt
        
        Change-Id: I1b88648a84760ea16f32566fe0d88e402c328987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160888
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-17  Weblate  <noreply@documentfoundation.org>  [5e3a3671596ea4f8aaecd8e1b428bcc63a627e2d]

        android-viewer translated using Weblate
        
        Lower Sorbian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ic20ccfbdde8de842548b79e3b5dfde85f300dc90
        
        android-viewer translated using Weblate
        
        Upper Sorbian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Iddaca4eedc9f022377c81929814856c31067f50d
        
        android-viewer translated using Weblate
        
        Italian currently translated at 5.9% (7 of 118 strings)
        
        Change-Id: I9e0f677f79c7496211959a3360eb166af6226aee
        
        Added translation for android-viewer using Weblate (Ukrainian)
        
        Change-Id: I130f051543b758544ac3b2a069899870ac16058d
        
        android-viewer translated using Weblate
        
        Upper Sorbian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I8655aa3d29866b006f839c93d242332e1102fb4a
        
        android-viewer translated using Weblate
        
        Czech currently translated at 1.6% (2 of 118 strings)
        
        Change-Id: Ib3f028432a47679478f17cadcf031f425293e745
        
        Added translation for android-viewer using Weblate (Lower Sorbian)
        
        Change-Id: I1978530538c3808b939729c15fd9a16ed2ab8b3d
        
        android-viewer translated using Weblate
        
        Icelandic currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ib7f514c6082fe1b85f6c40f70024cefab8f4b103
        
        android-viewer translated using Weblate
        
        Asturian currently translated at 19.4% (23 of 118 strings)
        
        Change-Id: I726ac83b54a25b2c12747992f425ac713e33825d
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Ib03330ad83be7cd6bf01f99a51870b5eb5c0a316
        
        android-viewer translated using Weblate
        
        Armenian currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: Idbdaeed85c0cbcfb037de074d34558c10fd978bb
        
        Added translation for android-viewer using Weblate (Upper Sorbian)
        
        Change-Id: I2f5ca2465e7d788f290656f728da1a3ed001ba19
        
        Added translation for android-viewer using Weblate (Dutch)
        
        Change-Id: I9cfed846807c16dd7c9c92d32ada641d89082579
        
        Added translation for android-viewer using Weblate (Icelandic)
        
        Change-Id: I120a3e1603867ae60b25531686dbbac5a8086bf2
        
        Added translation for android-viewer using Weblate (Italian)
        
        Change-Id: I16661f95066ee125409b7e939721b0070c59cf2d
        
        Added translation for android-viewer using Weblate (Asturian)
        
        Change-Id: I561826cd41e1de13f8c683a9ffe005cccb2e1246
        
        android-viewer translated using Weblate
        
        Czech currently translated at 0.8% (1 of 118 strings)
        
        Change-Id: I1fbb418d0c82e587e56dca7b1e751f05fbe256e9
        
        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (118 of 118 strings)
        
        Change-Id: I4d9f8bf30b3a084940356258ae929bf061dba129
        
        android-viewer translated using Weblate
        
        French currently translated at 32.2% (38 of 118 strings)
        
        Change-Id: I327ef925fc254142b4668385a79f502ef0bb888d
        
        Added translation for android-viewer using Weblate (Czech)
        
        Change-Id: I1215d7ba1a3d4fac3ebf00de9d55ef31753a356e
        Co-authored-by: Adam Rak <kitynska@gmail.com>
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Elisabetta Manuele <calembour@hotmail.it>
        Co-authored-by: Michael Wolf <milupo@sorbzilla.de>
        Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com>
        Co-authored-by: Sveinn í Felli <sv1@fellsnet.is>
        Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Weblate <noreply@weblate.org>
        Co-authored-by: raal <raal@post.cz>
        Co-authored-by: sophie <gautier.sophie@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/dsb/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hsb/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/is/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160842
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-17  Rene Engelhard  <rene@rene-engelhard.de>  [e7f298e8e35935de86ea0373fa68eabc343ee091]

        fix 32 bit build
        
        /home/rene/LibreOffice/git/libreoffice-24-2/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx: In static member function 'static void Atspi2TestTree::compareObjects(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, const Atspi::Accessible&, sal_uInt16)':
        /home/rene/LibreOffice/git/libreoffice-24-2/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx:362:9: error: no matching function for call to 'assertEquals(const long int&, int, CppUnit::SourceLine, const char [1])'
          362 |         CPPUNIT_ASSERT_EQUAL(nLOTargetsCount, pAtspiRelation.getNTargets());
              |         ^
        /usr/include/cppunit/TestAssert.h:161:6: note: candidate: 'template<class T> void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&)'
          161 | void assertEquals( const T& expected,
              |      ^~~~~~~~~~~~
        /usr/include/cppunit/TestAssert.h:161:6: note:   template argument deduction/substitution failed:
        /home/rene/LibreOffice/git/libreoffice-24-2/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx:362:9: note:   deduced conflicting types for parameter 'const T' ('long int' and 'int')
          362 |         CPPUNIT_ASSERT_EQUAL(nLOTargetsCount, pAtspiRelation.getNTargets());
              |         ^
        make: *** [/home/rene/LibreOffice/git/libreoffice-24-2/solenv/gbuild/LinkTarget.mk:340: /home/rene/LibreOffice/git/libreoffice-24-2/workdir/CxxObject/vcl/qa/cppunit/a11y/atspi2/atspi2.o] Error 1
        
        Change-Id: I7b7e3e756b135d1066af631e92738e7dfc1ede4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160882
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-17  Stanislav Horacek  <stanislav.horacek@gmail.com>  [55d079aa250a6c64120780d0f9a6117d71887b2b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef45f87dbeeaada230b31b5790fc1542a3c236f4
          - localize bookmarks and code comments in SF Dataset service
            
            Change-Id: I0d2fbcbb88f97930c60f1eafa26efa4997bf965d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160540
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-17  Stanislav Horacek  <stanislav.horacek@gmail.com>  [fcf3b9d426999299fcde8440716e93211d9c558c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 929c069b42a5d9f0ae528ed009e8f2c79b15c857
          - use correct space character on Document service page
            
            Change-Id: Iadd798bbd73c470b165e0812f86ce855524018d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160885
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-17  Stanislav Horacek  <stanislav.horacek@gmail.com>  [4c0a6fe55b495e0652696653868836c3afb65c31]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3840b15dd7fac37566c41f5579d333f3a1f655c2
          - fix menu path to delete cells command
            
            Change-Id: I19cdb8441d9b1dfea4a79ac0bf8a7332494f9ffc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160873
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [faa4e8d5c54a3492e32b17b49660801e019630af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58ac48c0056e70c9e1e44e9ef84355dddb13784a
          - Fix online help xapian build
            
            + refactor of browserhelp.xhp
            
            Change-Id: Iaba2ac4c8951bfb65fb237fa9eab95269826c544
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160886
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-17  Stanislav Horacek  <stanislav.horacek@gmail.com>  [6c42157398a0dc551b77173d2bfeb20f71c177fe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e408bb03f95da32746601a722a7d0bad3d37e9f
          - fix file extension on help installation page
            
            Change-Id: Ia2564f487caea7bfdba2548525661c1ff5963ece
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160884
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-17  Julien Nabet  <serval2412@yahoo.fr>  [250f6d0caf71c13e53076fb8eee4eaf1b0ec4156]

        Static map initialization in lotuswordpro/lwpnumericfmt
        
        Change-Id: I7894e8b7bf9b4d4c25e1c75551cae2b58b26d6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160881
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-17  Julien Nabet  <serval2412@yahoo.fr>  [32b437559abcf7582f113dcb5c87f1a2dd2ba3ac]

        tdf#150695: The string "IgnoreAll" is probably wrong
        
        Change-Id: I93dc97d36dbd1c61ce8a851c4065944cb3fd9fc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160877
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-17  Noel Grandin  <noelgrandin@gmail.com>  [40cec25c21f3ea5d7348d778c1ab5343fa7bb456]

        unique_ptr to optional in chart2
        
        Change-Id: I642f6f1fb7df9f0a7525155b22a99344a02d9cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-17  Adam Seskunas  <adamseskunas@gmail.com>  [e4c8f63c90ad8396f22186045399fabcd65958cd]

        tdf#119931 Fix accessibility warnings
        
        Fix accessibility warnings in:
        dbaccess/uiconfig/ui/specialjdbcconnectionpage.ui
        
        Change-Id: I90eedb80db71d087a1bea5c2565809951d8c6f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160874
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-17  Patrick Luby  <plubius@libreoffice.org>  [e091cd0104cf982b500d57202cf7e1fa8d5815ca]

        Fix Skia unit test failure when using a HiDPI display
        
        When running on macOS with a Retina display, one BackendTest unit
        test will fail if the position is adjusted.
        
        Change-Id: Iaf8678dd6bcb842bae7a9f45ae632114795e7a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160878
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-17  Noel Grandin  <noelgrandin@gmail.com>  [676d24f06303b4576f527b5a933e5cbec284bb8f]

        unique_ptr to optional in chart2
        
        Change-Id: I0cbf2e32030e5db772a9429997b7a078a4bfa2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de4b3a135f0bca61c0e29d5af838fa86330b832a]

        cid#1545970 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545957 COPY_INSTEAD_OF_MOVE
        cid#1545944 COPY_INSTEAD_OF_MOVE
        cid#1545939 COPY_INSTEAD_OF_MOVE
        cid#1545931 COPY_INSTEAD_OF_MOVE
        cid#1545926 COPY_INSTEAD_OF_MOVE
        cid#1545909 COPY_INSTEAD_OF_MOVE
        cid#1545899 COPY_INSTEAD_OF_MOVE
        cid#1545896 COPY_INSTEAD_OF_MOVE
        cid#1545894 COPY_INSTEAD_OF_MOVE
        cid#1545858 COPY_INSTEAD_OF_MOVE
        cid#1545823 COPY_INSTEAD_OF_MOVE
        cid#1545820 COPY_INSTEAD_OF_MOVE
        cid#1545819 COPY_INSTEAD_OF_MOVE
        cid#1545772 COPY_INSTEAD_OF_MOVE
        cid#1545749 COPY_INSTEAD_OF_MOVE
        cid#1545743 COPY_INSTEAD_OF_MOVE
        cid#1545739 COPY_INSTEAD_OF_MOVE
        cid#1545635 COPY_INSTEAD_OF_MOVE
        cid#1545603 COPY_INSTEAD_OF_MOVE
        cid#1545602 COPY_INSTEAD_OF_MOVE
        cid#1545592 COPY_INSTEAD_OF_MOVE
        cid#1545544 COPY_INSTEAD_OF_MOVE
        cid#1545532 COPY_INSTEAD_OF_MOVE
        cid#1545520 COPY_INSTEAD_OF_MOVE
        cid#1545512 COPY_INSTEAD_OF_MOVE
        cid#1545490 COPY_INSTEAD_OF_MOVE
        cid#1545483 COPY_INSTEAD_OF_MOVE
        cid#1545467 COPY_INSTEAD_OF_MOVE
        cid#1545461 COPY_INSTEAD_OF_MOVE
        cid#1545458 COPY_INSTEAD_OF_MOVE
        cid#1545428 COPY_INSTEAD_OF_MOVE
        cid#1545394 COPY_INSTEAD_OF_MOVE
        cid#1545385 COPY_INSTEAD_OF_MOVE
        cid#1545383 COPY_INSTEAD_OF_MOVE
        cid#1545366 COPY_INSTEAD_OF_MOVE
        cid#1545357 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I76224326977b4067b94ca3176cad1ca6de17930a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81c4be45829826ae73ac14e1cb862e38dd73344d]

        cid#1545561 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: I6830f06fe6019ee5688c59260639ed99162eb451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160876
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [264c3a962e64202984814173baedddedc0716c84]

        cid#1545870 Using invalid iterator
        
        Change-Id: I3b09fdee5574e5d3006cc875ce6c0175c0b4e594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160875
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [98ec93183fa1151b16ec4f04970e6031cfda9bc9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 25f39b53fb292ec90368f2afd3678884a1a8bb27
          - Make Help navigation layout less busy
            
            Bookmarks don't have to be visible all the time, so make them a
            dropdown and move the search box to header.
            
            Move Xapian search to the top of the content area.
            
            Make Contents tree appear on the left side in 960px and wider screens.
            
            Simplify/clean up some CSS and JS, for example for module colours.
            
            Change-Id: Ic50a834b758d50098868866e4b8d3e8085755423
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160870
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-16  Mike Kaganski  <mike.kaganski@collabora.com>  [247c64fa02c53bb7a5c6e6d87d13a4eb598b78b2]

        Drop incorrect conditional compilation
        
        Since commit 396196d6143e377f83a81557f4630ac7e7ad9471 (BigInt's
        non-big value type is currently sal_Int32, 2020-11-14), fixed-size
        sal_Int32 is used in the unit test; so it must not depend on size
        of unrelated long type.
        
        Change-Id: Ida276e87b927381d093796f4137774a18acded82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160857
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c3a651a3f939bbc346ced5547326fe110958cdb]

        cid#1546456 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546450 COPY_INSTEAD_OF_MOVE
        cid#1546430 COPY_INSTEAD_OF_MOVE
        cid#1546401 COPY_INSTEAD_OF_MOVE
        cid#1546313 COPY_INSTEAD_OF_MOVE
        cid#1546302 COPY_INSTEAD_OF_MOVE
        cid#1546301 COPY_INSTEAD_OF_MOVE
        cid#1546299 COPY_INSTEAD_OF_MOVE
        cid#1546280 COPY_INSTEAD_OF_MOVE
        cid#1546233 COPY_INSTEAD_OF_MOVE
        cid#1546217 COPY_INSTEAD_OF_MOVE
        cid#1546215 COPY_INSTEAD_OF_MOVE
        cid#1546204 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Iaab419509ad4a0bea9cae3665723af0e99c60ee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160849
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0da294bb8297f309eca9504de1b043571e2c4d31]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b84322961aad1cb506f0b92989e9eea95c646531
          - Uncover important content for digital signatures.
            
            Change-Id: I9883445e2fb95f02569fef3b22e06b38a9b5a1ea
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160855
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-16  Noel Grandin  <noelgrandin@gmail.com>  [73e5161baef01bf4355d3c0bc2831646192907f2]

        no need to allocate these on the heap
        
        Change-Id: I02ec48ba369e91afc67246f9cdf18f88b24af49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160837
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Noel Grandin  <noelgrandin@gmail.com>  [23f8c4786681c120022fb726f03ec248517136f4]

        unique_ptr to optional in chart2
        
        Change-Id: Ia61bbedc8a96ac7525eb24997f99546ed26e377c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Noel Grandin  <noelgrandin@gmail.com>  [bc640ec91106fa55886af84f48eb58b7fa8610b5]

        no need to allocate this on the heap
        
        Change-Id: I9a63c534a12ec2cf11d8820a5bbba8bca9a7c0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Noel Grandin  <noelgrandin@gmail.com>  [dc3849eeb7cc3319659f0bf8d3dc3355e670b9e9]

        no need to allocate this on the heap
        
        Change-Id: I89d4e680e6c8aabcc543605a0e496b3086dd2d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160838
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Noel Grandin  <noelgrandin@gmail.com>  [3ca3fd6eafee8ead7578acfbc7d9a0f319ca7a4a]

        no need to allocate this on the heap
        
        Change-Id: I99a41076db39b76f6dbbd5974039ee271c29eee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c498e2acd64688df9aa32bbcc820d8513a5373ea]

        Drop some wrapper methods from SvtOptionsDrawinglayer
        
        just use the wrapped officecfg methods instead of:
        GetMaximumPaperWidth
        GetMaximumPaperHeight
        GetMaximumPaperLeftMargin
        GetMaximumPaperRightMargin
        GetMaximumPaperTopMargin
        GetMaximumPaperBottomMargin
        
        Change-Id: Id11782a306ca9118cc65607265be516ba9f0abda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160653
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [46c1ce9ac9fa8eff069d5998a6d96a639f277a8e]

        tdf#158514 Add "Edit Comment" entry to the navigator popup
        
        Clicking this option will show the comment and enter edit mode.
        
        Change-Id: Ia9d10e5e03229c48120c27de0a623de5c5cf50d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160582
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-16  Gabor Kelemen  <kelemeng@ubuntu.com>  [7f4841946962ffd0d457574721601dc2e6b372a1]

        get-bugzilla-attachments-by-mimetype: GNOME Bugzilla is dead
        
        Comment it out from the script.
        Gnumeric's new bugtracking is in gitlab:
        https://gitlab.gnome.org/GNOME/gnumeric/-/issues
        
        Change-Id: I53be9c368cf02f7a36991498ac2261e05327131a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160829
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9a71ac689a7d5929f66df23f9fcc707bdb146e3f]

        Drop some wrapper methods from SvtOptionsDrawinglayer
        
        just use the wrapped officecfg methods instead of:
        
        GetStripeLength
        
        Change-Id: Id29c0b1ecbc513b5d778140b6e59139a507035d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160652
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d799ba397e42d7a4ba62135e49b0c216c1d6a915]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 91d39c6ef8fc004c6ed92611333270493199d861
          - tdf#155876 UI cmds Calc-Sheet menu (32)
            
            + Sheet menu for Calc: manage Names
            + untangle manage names and define names
            + refactoring
            
            Change-Id: I27fe448ae251cb98a829e92c307fc31ad3b2c967
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160845
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-15  Noel Grandin  <noelgrandin@gmail.com>  [df9499d520c3afccba969fb16e59a44273e57f59]

        use more getFastProperty in chart2
        
        Change-Id: Ia6511f7de33023e1e1e9e8a31ba262c7b989350c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160832
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-15  Weblate  <noreply@documentfoundation.org>  [f65ef4517a2d8bf8959871501daa06bcea73a570]

        Update translation files for android-viewer
        
        Updated by "Cleanup translation files" hook in Weblate.
        
        Change-Id: Ie0d7d835fba42e9a8cfb73370a8b153168a9cf9e
        
        android-viewer translated using Weblate
        
        Slovenian currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Id07e5c018310b97460f7750c2db2f43127c483c5
        
        Added translation for android-viewer using Weblate (Slovenian)
        
        Change-Id: Ie9008b437173feb5a871e119fd00e5f134dd0da9
        
        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Iacacacd662c48986358e904598d458c44ca8805f
        
        Added translation for android-viewer using Weblate (Japanese)
        
        Change-Id: I3373654075eabc79c42cd2c67daf62f5f7111158
        
        Added translation for android-viewer using Weblate (Chinese (Traditional))
        
        Change-Id: I7af06e08b6567f990641ad532b8b94df2ec7d367
        
        android-viewer translated using Weblate
        
        Basque currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: I9b29af97d0642fa36c09ce38bf14290f60ccb8cd
        
        android-viewer translated using Weblate
        
        Polish currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Ie0b345d1dc63102120cb871f8066ed710917e72f
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 54.5% (72 of 132 strings)
        
        Change-Id: I652b6dde8cd02c9b4baff5ba5453f7471f8eb896
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Ic7b42998072d6bb02937e88af76620564abc51b8
        
        Added translation for android-viewer using Weblate (Finnish)
        
        Change-Id: Iae55f9b007d7d34162d77c8f62d025fa54ff8035
        
        Added translation for android-viewer using Weblate (Basque)
        
        Change-Id: I88291444f52d5f4189c17330f855683268a2bffc
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 62.1% (82 of 132 strings)
        
        Change-Id: I28ec1b2f54d39209f7d802ba9aa899d12b2a3b35
        
        android-viewer translated using Weblate
        
        Persian currently translated at 2.2% (3 of 132 strings)
        
        Change-Id: I7ba58594540aff2ad592771e73efeeccdff027db
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 33.3% (44 of 132 strings)
        
        Change-Id: I092277ffea906ad3da9b73e7831536a482bb104f
        
        android-viewer translated using Weblate
        
        French currently translated at 1.5% (2 of 132 strings)
        
        Change-Id: Ia8553c387bec6c66c6def3de9b4b41016ead2bb1
        
        Added translation for android-viewer using Weblate (Polish)
        
        Change-Id: Ibe83470b27b286030024f654df5cf30b2cb727ed
        
        Added translation for android-viewer using Weblate (Persian)
        
        Change-Id: I67bb9684aaa873ca4129139fb340b84634c9fe7e
        
        android-viewer translated using Weblate
        
        Portuguese (Brazil) currently translated at 20.4% (27 of 132 strings)
        
        Change-Id: I628da41052ac2957601226a5e03796bd67744863
        
        Added translation for android-viewer using Weblate (Portuguese (Brazil))
        
        Change-Id: I8ee44239235aaba0c44f805d93d2cb8db4383fab
        
        android-viewer translated using Weblate
        
        Punjabi currently translated at 87.8% (116 of 132 strings)
        
        Change-Id: Ic9ae2d4d5d007638ecf8d58c9069c103d30af7c1
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 59.0% (78 of 132 strings)
        
        Change-Id: Ib6d7f7e1adf85c57f6de66cf21795c27d6945a03
        
        Added translation for android-viewer using Weblate (French)
        
        Change-Id: I936f355b82bf58baea5f1738227b7b1755b23193
        Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
        Co-authored-by: Adam Rak <kitynska@gmail.com>
        Co-authored-by: Aitor Salaberria <trslbrr@gmail.com>
        Co-authored-by: Hossein <hossein@libreoffice.org>
        Co-authored-by: Joan Montané <joan@montane.cat>
        Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
        Co-authored-by: Naruhiko Ogasawara <naruoga@gmail.com>
        Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Co-authored-by: Tuomas Hietala <tuomas.hietala@iki.fi>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Weblate <noreply@weblate.org>
        Co-authored-by: sophie <gautier.sophie@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160824
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Rene Engelhard  <rene@rene-engelhard.de>  [e89723103313ec4366ee58144c47d7a5c16bf838]

        check abseil version
        
        since 918515d6fc6e2eaa000c4a997d604b7b00b492e3 updated to a pdfium
        version which only builds with >= 20230125.3 (earliest I could get hand
        on).
        
        Ideally we should test for the feature, but this suffices too and we do
        that for other libs, too...
        
        Change-Id: I14719186d415b9df82f607b26233c9be154492c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160833
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>

2023-12-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [c48952eb6b6f65affcda75ee74c292008be9c455]

        tdf#142926 Add button to Download page in Help dialog box
        
        Change-Id: Ie22dda17949d583a388d45e5aad3728b91637bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155298
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-12-15  Mike Kaganski  <mike.kaganski@collabora.com>  [107b35bd425fb79a9ff2e47b9e2054289cf0213e]

        Put some static_casts into a dedicated function
        
        And make it explicit that SmModel ctor takes a SmDocShell*.
        
        Change-Id: Ic16b2bce8e0a57b9f00382fa03041867f5e3a4ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160828
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [d942b4a7d187f106dfb1f5085e7c655bf13974bf]

        android: Set sample texts for design view
        
        As cloph suggested in [1], set sample texts for the
        version and vendor information in the About dialog,
        using the `tools:text` attribute as described at [2].
        
        These are displayed when viewing the layout in
        Android Studio's layout preview. With these placeholder
        texts, this gives a better impression at design time
        what the actual result will look like at runtime.
        
        The actual texts for the view are set at runtime, s.
        `AboutDialogFragment#onCreateDialog`.
        
        [1] https://gerrit.libreoffice.org/c/core/+/160047/comments/52584e2e_50869bef
        [2] https://developer.android.com/studio/write/tool-attributes#design-time_view_attributes
        
        Change-Id: I92b1c3d9f947fd1aa68a3ef4f0eee9e5c742e0c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160826
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [da292a61c48876c742138271becb42e201d48ee5]

        android: Update lint baseline
        
        Update the list of known (tolerated for now) issues by deleting
        lint-baseline.xml and running `make` to regenerate
        the file, so recent translation-related (config) changes are
        reflected.
        
        Change-Id: If8a39d72ba83c2a2e0bab9830c69095445943b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160818
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [a6616674216dfa758484724ea283e2c50be22bc3]

        android lint: Drop unused string resources
        
        This also avoids that these will show up in Weblate,
        causing unnecessary work for translators since they're
        unused anyway.
        
        IIUC, dropping the strings in already existing translations
        should be handled automatically by Weblate.
        (Leave them there to see whether this actually works as
        expected.)
        
        Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160821
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [d5922ae2404e9efa62f3f19a56009c6668c3d574]

        android lint: Ignore extra translations
        
        These should be managed automatically via weblate, s. [1],
        so there shouldn't be any need to manually remove stale
        strings for all translations.
        
        There are 2 lint checks for these, `ExtraTranslations`
        and `UnusedResources`.
        
        Disable `ExtraTranslations` altogether.
        The `UnusedResources` check seems useful in general,
        so only disable that for the translations by adding
        a lint config file `lint.xml` (s.a. [2]) using a
        wildcard for the path that matches the translation's
        string.xml files.
        
        This is in preparation for
        
            Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 15 10:28:21 2023 +0100
        
                android lint: Drop unused string resources
        
                This also avoids that these will show up in Weblate,
                causing unnecessary work for translators since they're
                unused anyway.
        
                IIUC, dropping the strings in already existing translations
                should be handled automatically by Weblate.
                (Leave them there to see whether this actually works as
                expected.)
        
        [1] https://gerrit.libreoffice.org/c/impress_remote/+/155966/comments/769f76c5_c3c499ec
        [2] https://developer.android.com/studio/write/lint
        
        Change-Id: Ic7c7a1c4c5583bf1a42004480435aac70a88dee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160822
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [f43c133c87a2a6e8f0918e5038097d63dbdbe256]

        android lint: Replace "..." with ellipsis character
        
        Address this lint warning listed in the lint-baseline.xml:
        
            <issue
                id="TypographyEllipsis"
                message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?"
                errorLine1="    &lt;string name=&quot;action_save_as&quot;>Save As...&lt;/string>"
                errorLine2="                                  ~~~~~~~~~~">
                <location
                    file="res/values/strings.xml"
                    line="53"
                    column="35"/>
            </issue>
        
        This also helps to avoid introducing more issues of that kind in newly
        added translations, quoting from cloph's Gerrit comment [1]:
        
        > and FYI: if the source-string would end in an Ellipsis, then weblate could
        > enforce the translation ending in an ellipsis [...]
        >
        > ( https://docs.weblate.org/en/latest/user/checks.html#mismatched-ellipsis )
        
        [1] https://gerrit.libreoffice.org/c/core/+/160614/comments/5ef2dc6d_75cde15f
        
        Change-Id: Ic056849dd56d7e6c50615ffd62d470df4ab337bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160817
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [eaa8327c960591bf113f624be2fc81af00d08090]

        android lint: Ignore missing translations
        
        Translations are handled in Weblate now, so missing
        translations are tracked there.
        
        Therefore, ignore them in the lint check, since there's
        no added value in having them listed in the
        `android/source/lint-baseline.xml` file in addition any more.
        
        Change-Id: I82945c0eebe015ca9695813dd19613108884c648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160816
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Michael Weghorn  <m.weghorn@posteo.de>  [92b7f110a9a4b61c01a921bfa65b3951a8386b62]

        Fix placement for --enable-online-update-mar UI
        
        * Resave with glade 3.40, which did all the
          changes to the .ui file
        * to be safe, explicitly hide the UI in the C++
          code when building without `--enable-online-update-mar`
          (UI wasn't shown in a quick test with qt6 even
          without that, but better be safe)
        
        Addresses this issue mentioned in [1]:
        
        > - Online Update".  (For non-GTK VCL backends, there's still a bug that
        > the "Automatic Update" section on that options page is mixed into the
        > traditional --enable-online-update options at the top of the page,
        > instead of down at the bottom; fixing of
        > cui/uiconfig/ui/optonlineupdatepage.ui welcome...)
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2023-December/091309.html
        
        Change-Id: I2fadbb3b93206834b8c2c17cb540fb0b0687742b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160830
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins

2023-12-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [dc08489bc715886c521c39336d81e5ffe0c06cca]

        Avoid "Desktop disposed before terminating it" assert
        
        ...from Desktop::disposing() at framework/source/services/desktop.cxx:1041, on
        Windows, when the HAVE_FEATURE_UPDATE_MAR update() call returns true (and
        soffice.bin is about to exit now), but the css.frame.Desktop service happens to
        already have been created somewhere else (and will thus be disposed as part of
        disposing the service manager) but doesn't receive a terminate() call in
        Desktop::Main().
        
        So reorder the code in Desktop::Main(), moving the HAVE_FEATURE_UPDATE_MAR code
        after the
        
        >     xDesktop = css::frame::Desktop::create( xContext );
        
        so that we have something to call
        
        >                 xDesktop->terminate();
        
        on in this scenario.
        
        Change-Id: Iee5b6eeece33d5a27cadb94a7da0d26aa1492e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160831
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-15  Mike Kaganski  <mike.kaganski@collabora.com>  [80b67e776ae26d60e0935fcc57a8ff6c983bdd15]

        tdf#157569: FormulaImExportBase::getFormulaSize should return mm/100
        
        Similar to commit 798d21e2a1b8bc48b6bb5e1b3cf0cba0e5882a59 (tdf#157965:
        UNO methods are expected to return sizes in mm/100, 2023-10-29); this
        was an omission from commit 9e92a17cb6e03beedeeca40bfc8524c2623d31eb
        (starmath: Improve glyph positioning, 2023-09-19).
        
        The method is called in DomainMapper_Impl::appendStarMath(), and the
        returned value is used to define object size using UNO methods.
        
        Change-Id: I37cc4d5dd18641915495b97f0d99fa10a805e18c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160827
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8a645c192fc7356729ac74006a701c425781847f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 38b799b9f758e455d561b03dda4b67ee43d943fe
          - update translations for master/24-2
            
            and force-fix errors using pocheck
            
            Change-Id: Ib2816d25b6b144e161a8b2eced1702af7a527c93
            
2023-12-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [94233c2e1e86c3617f327e8bfd3cd4a980adf200]

        -Werror,-Wunused-result
        
        ...caused by typo in previous 58bfd8f982950566018f77ce8895963d914058f8 "Fix
        backward vs. forward slashes on Windows"
        
        Change-Id: Ibd1967688c6ab4c962818595d435c7f821ad3d64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160820
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [12fbc9ffde9b331a5bbc4adf6b7971e51da360e9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d4b5e5598f24273a0f5b3a4d73e3e716a5a34aa9
          - helpcontent2: adapt Digital Signatures to removal of AdES checkbox
            
            ... and clarify what files can be signed a bit.
            
            Change-Id: I101646f97ba6b21e7ba33aa2eef723e91af806a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160823
            Tested-by: Jenkins
            Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
            
2023-12-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3a445cb49795fabe0d8caaf12bfc38eb9e12d5fc]

        Turn onlineupdate into external/onlineupdate
        
        ...and update to latest Mozilla sources.
        
        Originally, this was a non-external onlineupdate module (plus correspsonding
        top-level include/onlineupdate/ directory) that apparently contained sources
        originally copied from Mozilla and subsequently modified in-place (plus, mixed
        in, presumably some sources that were not copied from Mozilla but were our own
        inventions).  To clean up this mess, this has been turned into a proper
        external/onlineupdate module with a tarball containing the pristine external
        Mozilla sources.
        
        The sources for the onlineupdate-c003be8b9727672e7d30972983b375f4c200233f.tar.xz
        tarball are taken, somewhat arbitrarily, from a recent
        <https://github.com/mozilla/gecko-dev/commit/c003be8b9727672e7d30972983b375f4c200233f>
        ("Bug 1867784 - Force reflow all kids in the last column balancing reflow.
        r=layout-reviewers,dholbert") trunk state, by running
        `external/onlineupdate/generate-sources.sh ~/github.com/mozilla/gecko-dev` on a
        Fedora 39 machine.
        
        The layout of the tarball still mostly follows the old onlineupdate/ layout,
        even if that deviates heavily from the actual source layout at
        <https://github.com/mozilla/gecko-dev/>.  (And some files, which apparently are
        not needed, anyway, lacked sources, see the "Missing source for" in
        external/onlineupdate/generate-sources.sh.  And win_dirent.h/.cpp has meanwhile
        been superseded by updateutils_win.h/.cpp.)  Merely newly included source files
        are laid out in the tarball according to the actual source layout.
        
        Any LO-specific modifications are made via patch files (rather than modifying
        the sources inline, as was done in the past): external/onlineupdate/lo.patch
        contains whatever modifications are needed to adapt the functionality, while
        external/onlineupdate/gtk3deprecated.patch fixes
        
        > workdir/UnpackedTarball/onlineupdate/onlineupdate/source/update/updater/progressui_gtk.cpp:97:21: error: use of undeclared identifier 'gtk_vbox_new'; did you mean 'gtk_box_new'?
        >    97 |   GtkWidget* vbox = gtk_vbox_new(TRUE, 6);
        >       |                     ^~~~~~~~~~~~
        >       |                     gtk_box_new
        
        to not use the deprecated gtk_vbox_new, which is hidden because we include
        -DGTK_DISABLE_DEPRECATED in our GTK3_CFLAGS as per our configure.ac.
        
        On Windows, the definition of __BYTE_ORDER__ etc. is needed because
        workdir/UnpackedTarball/onlineupdate/include/mozilla/ says "Our supported
        compilers provide architecture-independent macros for this", but MSVC doesn't
        actually, so define here what would implicitly be defined by GCC.  Similarly, on
        Windows -U_WIN32_WINNT is needed to undo -D_WIN32_WINNT=0x0601 in
        solenv/gbuild/platform/windows.mk, which would cause
        
        > workdir\UnpackedTarball\onlineupdate\include\mozilla/WinHeaderOnlyUtils.h(537): error C2065: 'FILE_ID_INFO': undeclared identifier
        
        etc., despite the #include <windws.h> there.
        
        Curiously, the original gb_CustomTarget_CustomTarget,onlineupdate/generated from
        onlineupdate/CustomTarget_generated.mk had to be renamed to
        gb_CustomTarget_CustomTarget,external/onlineupdate/generated when the file was
        moved to external/onlineupdate/CustomTarget_generated.mk, as otherwise a
        top-level `make CustomTarget_onlineupdate/generated` would have failed with "No
        rule to make target..."  Also, as there is no gb_CustomTarget_use_unpacked, its
        effect has been poorly mimicked for now in
        external/onlineupdate/CustomTarget_generated.mk.
        
        Similarly, as there is no gb_WinResTarget_use_unpacked, its effect has been
        poorly mimicked for now in external/onlineupdate/WinResTarget_updater.mk.
        
        The original onlineupdate/workben/test_dialog.cxx, which is actually code
        written by us, has been moved to external/onlineupdate/workben/test_dialog.cxx.
        
        The original onlineupdate/qa/ sources (which were apparently not used during the
        build) have been preserved for now as external/onlineupdate/qa/, for
        documentation purposes.
        
        The original onlineupdate/astyle.options (which was apparently not used during
        the build) has been removed.
        
        Change-Id: I5ea606202e7837269e7b128e45af2f0b8c277f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160492
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-15  Dione Maddern  <dionemaddern@gmail.com>  [b7f7909a2266b0758306fd44d8411ca5b1e94ba5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e756ea3d2c84368ceaf30a6cacbbd46d6148327
          - tdf#155877 Update Help page with Tabbed UI info
            
            + Rephrasing instructions
            
            Change-Id: I04fcc9139d0fb0e3a82f4d81d8b55512df6a7ded
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160810
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [4eebf31e38969335471de884c7fd2db7c0e79454]

        xmlsecurity: remove "AdES-compliant signature" checkbox
        
        This is essentially a footgun because the user can accidentally turn it
        off and get non-AdES signatures which use obsolete SHA1 hashes.
        
        Unfortunately it turns out that the initial setting of the checkbox only
        works for ODF, because OOXML have m_sODFVersion set to "1.0" due to some
        defaulting code somewhere.
        
        So what this checkbox actually did is unintentionally disable XAdES
        signatures for OOXML by default.
        
        Now that i actually test it by setting ODF version 1.1 in
        Tools->Options, it turns out that signing ODF 1.1 documents isn't
        possible at all, a dialog pops up that says "Signing documents
        requires ODF 1.2 (OpenOffice.org 3.x)".
        
        Change-Id: I0eaf590c290b2c0ee0ff890ed73f0dbea4cf0ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160785
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [53c64cce13863861aabc4b1056cc3a1a66bf64a7]

        xmlsecurity: fix assert in CertificateChooser::ImplInitialize()
        
        gtk3/gtkinst.cxx:15371: virtual void (anonymous namespace)::GtkInstanceTreeView::select(int): Assertion `gtk_tree_view_get_model(m_pTreeView) && "don't select when frozen, select after thaw. Note selection doesn't survive a freeze"' failed.
        
        (regression from commit ad6f23d2a3842c40f7c812003af4031150ea8183)
        
        Change-Id: I8c0639e755188731bdd211f9d71a830d7afeeaa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160786
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-15  Mike Kaganski  <mike.kaganski@collabora.com>  [dcae6615ed254cf7884fa6415f64561f85b93588]

        tdf#158556: provide objects anchored to node as a hidden property
        
        This introduces a hidden property of SwXParagraph, named
        OOXMLImport_AnchoredShapes.
        
        Testing on my system, starting the main process first, then launching
        another one like
        
          time soffice path/to/bugdoc.docx
        
        ... so that it only measures time spent in import, gave the following
        figures:
        
        LibreOffice 7.5.0.3 (TDF build):
        real    1m49.016s
        user    0m0.000s
        sys     0m0.000s
        
        LibreOffice 7.6.0.3 (TDF build):
        real    8m37.386s
        user    0m0.000s
        sys     0m0.000s
        
        Current master (my no-debug build):
        real    10m6.776s
        user    0m0.000s
        sys     0m0.000s
        
        Current master with this patch (my no-debug build):
        real    5m41.524s
        user    0m0.000s
        sys     0m0.015s
        
        Indeed, it is not as fast as it used to be; and the fix doesn't really
        remove the quadratic complexity, just uses faster iteration. If there
        is a way to directly list objects anchored to a given paragraph, rather
        than iterating over all objects checking their anchors, that would get
        much faster, but that would be a rather large change.
        
        Change-Id: Ie50515815e85fdce498d065185199c9b31d95794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160813
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-15  Miklos Vajna  <vmiklos@collabora.com>  [4e8895d3d86db3776c56070c395cd727fd4b9101]

        sw floattable: disable UI to enable this when anchored inside TextBox
        
        Similar to headers or footers, shape text is another area where
        multi-page floating tables don't make sense, the Word UI to float a
        table in shape text is even disabled.
        
        Our UI to create a floating table is to select a table and then insert
        frame, and that already refused to make a new frame around a table to
        split. However, one could be creative and enable the split only later,
        and that was allowed.
        
        Fix the problem by extending SwFramePage::Reset(), so in case the
        currently selected frame is edited and it's anchored in a Word-style
        shape+text, then the checkbox to allow the split is hidden.
        
        This is meant to help users to not create document model that would be
        later problematic to export to Word formats.
        
        Change-Id: I63e981bd93fd16195ccdac2d5a5ec785e7c18b97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160814
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [58bfd8f982950566018f77ce8895963d914058f8]

        Fix backward vs. forward slashes on Windows
        
        Change-Id: I24771a526848901ccedb15aa5dd7b373fe854977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160765
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f9e1b1c9f3d5a11a19fb60af564e865dbf2cd5c7]

        Fix typo
        
        Change-Id: Id2236f5587c4dfcd6d7f4fbac15d1e9dbb93cd07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160779
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8a288fdeb6ec0e17d4111beab7701d7b3559062]

        Fix typo in code
        
        Change-Id: I78900dfd2314fc9b716ef40397229f24e962865f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160780
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-15  Miklos Vajna  <vmiklos@collabora.com>  [437062f29360146995ae37ccde79f449d09102c8]

        sw doc model xml dump: add initial ruby support
        
        Fixes this warning when some text portion has ruby on it:
        
        warn:sw.core:19310:19310:sw/source/core/txtnode/txatbase.cxx:180: Unhandled TXTATR
        
        Change-Id: If741f7201c56f7f19ae51108312f2813e92f45d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160787
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-15  Weblate  <noreply@documentfoundation.org>  [50d55703bd55ff807cce286f112875f322cfa098]

        android-viewer translated using Weblate
        
        Catalan currently translated at 57.5% (76 of 132 strings)
        
        Change-Id: I477bd8cf847c12e62d00385460caf91f310fa531
        
        Added translation for android-viewer using Weblate (Punjabi)
        
        Change-Id: Idad2440113f7f4cbdc0077ac101eb14b9f449f76
        Co-authored-by: A S Alam <amanpreet.alam@gmail.com>
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160789
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-15  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7397fa7cdfc33f5a079df42e4d6cfa59ae9e062d]

        Fix salhelper::Timer
        
        Using it was prone to cause deadlocks on shutdown, when the main thread during
        exit destroys the static salhelper::TimerManager instance, which blocks
        destroying its m_notEmpty member because the salhelper::TimerManager::run thread
        is blocking at
        
        >         m_notEmpty.wait(pDelay);
        
        Change-Id: If72700cb622e945f5f314a00ded57538961ab8d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-15  Patrick Luby  <plubius@libreoffice.org>  [250213166762bceedc052d80cf6ed5d64e286000]

        Fix Skia unit test failures when using a Retina display
        
        When running on macOS with a Retina display, several BackendTest unit tests
        also need a lower quality scaling level.
        
        Change-Id: Ied7141af886357a846f5c4633703114c18dfabf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160811
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-14  Julien Nabet  <serval2412@yahoo.fr>  [fdc87dd56548622e13353b4cf9864232ee0110fb]

        tdf#151456: AnimatedImages in Basic Dialog : StepTime is ignored
        
        2 problems here
        1) Regression on test of "pThrobber" since 51e97b2ffd8f0ae0591d1880d621cba4596583b7
        toolkit: first cut at switching to VclPtr.
        
        2) as the author of the bug "Jurassik Pork" indicated,
        "mnStepTime" wasn't used after having been used in ctr of Throbber
        Thank you to him for the suggestion!
        
        Change-Id: I0d1a53738035c3e822ea84d5972363dd9d0b5d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160771
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f3af1998741aeb7897aa5306ff16e7788bda2aa0]

        Related: cool#6893 ScFormulaGroupIterator::next creates columns
        
        that didn't exist before. Lots of time spent in ScColContainer::resize
        on getting document statistics.
        
        ScColContainer: :resize
        ScTable: :CreateColumnIfNotExistsImpl
        ScTable: :FetchColumn
        ScFormulaGroupIterator: :next
        ScDocument: :GetFormulaGroupCount
        ScDocument: :GetDocStat
        Change-Id: I52d4ab052e21215eb650bdccf4abc056ee2dd405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160784
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [c6c51663479fa036f70b182b5892a23235bbde5f]

        tdf#105844 package: increase PBKDF2 iterations for wholesome ODF encryption
        
        The government recommends 600k iterations.
        
        Change-Id: I8d4137ca8a08c2b3ac0e7724de1c87c2117ec7c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160768
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [1d2218690382374f3962de014b151dbac84a1446]

        tdf#105844 sfx2: add another consistency check
        
        SfxMedium::TryEncryptedInnerPackage() checks same mimetype of inner and
        outer package for ODF wholesome encryption.
        
        Change-Id: I8a5ef463c5f604a59573fb0f9e15453f22d867d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160767
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [fb9c58a2f32c352e44ffa30e721ef796dc591d33]

        tdf#105844 package: check for unexpected zip entries on loading ...
        
        ... ODF wholesome encrypted package.
        
        There can only be "mimetype", "encrypted-package", and files in
        "META-INF".
        
        Change-Id: I5eb46ba29a1a62e25af09e189e0a075a871c71c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160718
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [dcd46a0ff9e3e78fc53ce21e7adf314f6e4a033b]

        tdf#158551: sc_uicalc: Add unittest
        
        Change-Id: I66d62651a8f8295265e4bfbfc5395e0f400d726b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160769
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2486eaf671f38ada76c500116ee061e9d8240f4d]

        Save with newer Glade
        
        Change-Id: Id506e00f737b72f40448aacb6c23e64c09a0670d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160763
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Weblate  <noreply@documentfoundation.org>  [a056dee76e1d21526639baa9816a355327e1ce31]

        android-viewer translated using Weblate
        
        Turkish currently translated at 93.9% (124 of 132 strings)
        
        Change-Id: I67905c448a119c99417a465ff90968dbf842c4d5
        
        android-viewer translated using Weblate
        
        German currently translated at 97.7% (129 of 132 strings)
        
        Change-Id: I5b64bae8809d6a0c1366191c00b086ea003dd95a
        
        Added translation for android-viewer using Weblate (Kazakh)
        
        Change-Id: I3f0a39884167fce6e7bcfde22ee582cdc53115cb
        
        android-viewer translated using Weblate
        
        Turkish currently translated at 93.1% (123 of 132 strings)
        
        Change-Id: I4d5a8084d56fa5c3f803b26ccc31d905d477d504
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 56.0% (74 of 132 strings)
        
        Change-Id: I5296250e71d015b65f5704cc2ae088f157a5c888
        
        android-viewer translated using Weblate
        
        Catalan currently translated at 49.2% (65 of 132 strings)
        
        Change-Id: Icfb62bf6f5d1e26efea090726f2379d72238fd6e
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com>
        Co-authored-by: Christian Lohmaier <cloph@documentfoundation.org>
        Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160770
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [a44a6ab7a51f35997a5a4d0b12cd0c8eae421397]

        OFFICE-3708: package: produce correct SHA256 URL
        
        Old versions of LO or other consumers can't read wholesome ODF encrypted
        documents anyway, so start using the correct W3C SHA256 URL (see commit
        1015d35f2362953f415804476037d4f162eb49b5).
        
        Change-Id: Id82ab2c9f605eb2084ff01a26e8186223dd46763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160764
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [91f35f22f0447769c08ca89e27a39b40df18fffa]

        tdf#105844 package: remove root document from manifest ...
        
        ... for ODF wholesome encryption.
        
          4.3  <manifest:file-entry>
          For directories, the manifest file should contain a <manifest:file-entry> element only if a directory contains a document or a sub document.
        
        Because the "encrypted-package" is not a document but a package, we
        should probably omit the file-entry for the root document.
        
        ZipPackage::writeTempFile() always generates the root document becuase
        it's needed for GPG properties, and ManifestExport filters it out.
        
        A bit tricky to implement, because there isn't a clean distinction
        between the package and the root document/storage in the package module,
        in particular there's no other place than the root storage to store the
        MediaType property.
        
        Change-Id: Id7e72a64e2faa074dce80cd5fefb2fa189e2e3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160717
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Julien Nabet  <serval2412@yahoo.fr>  [f618e9b8c1d4748a9ff9ee97405af8e43c6ae294]

        Regression typo closewise->clockwise in sd/CustomAnimationDialog
        
        Regression from a756bd31dd2da1ef134d80b2dc276cb0be228aba
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=a756bd31dd2da1ef134d80b2dc276cb0be228aba
        
        Change-Id: Ia5fc84250eb64016f028f3ffe8b3dc581733904d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160778
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [df6a8667e6dd8b710bfae4944915f6eeb4efb233]

        tdf#131575: in repair mode, match names ASCII case-insensitively
        
        It would work for the bugdoc in tdf#131575; but not if the wrong case
        is the only problem in the package, because then there would be no
        repairment mode active. An alternative could be to use case insensitive
        match always, but that looks wrong.
        
        Change-Id: Ie405d37e1dc639482bd2608e4479de5b707a07d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160761
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [975bbafaae39f4dc5d9120b4347498b07e7e2426]

        Related: tdf#76115 Also pass RepairPackage to FilterDetect
        
        And drop the default argument value from ZipStorage ctor.
        Always pass it explicitly.
        
        Change-Id: I8bcf78dc4db7763567f9d6873841d75c328ede7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160760
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [27632654feda626131196c996e3f815f3602d248]

        tdf#76115: pass RepairPackage property from media descriptor to ZipStorage
        
        See commit 86c682273d907c77404637c89e584047de1c1099.
        
        Change-Id: I51a3beb00f635554ac73cc9ea957e18fb8e84349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160757
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-14  Michael Weghorn  <m.weghorn@posteo.de>  [806ee5b22413ae3cc5d65687adf0a879c8e24ded]

        android lint: Dont' fail on TypographyEllipsis warning
        
        After new translations got added in
        
            commit 40f850279d912786f7943d97ec6db73ee2bb874f
            Author: Weblate <noreply@documentfoundation.org>
            Date:   Wed Dec 13 15:33:50 2023 +0100
        
                android-viewer translated using Weblate (Welsh)
        
        , the android build started failing like this:
        
            > Task :lintReportStrippedUIEditingDebug
            Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html
        
            > Task :lintStrippedUIEditingDebug FAILED
            Lint found 3 errors, 0 warnings (232 errors, 3 warnings filtered by baseline lint-baseline.xml). First failure:
        
            /home/michi/development/git/libreoffice-WORKTREE-android/android/source/res/values-hy/strings.xml:36: Error: Replace "..." with ellipsis character (…, &#8230;) ? [TypographyEllipsis]
                <string name="action_save_as">Պահել որպես...</string>
                                              ~~~~~~~~~~~~~~
        
            The full lint text report is located at:
              /home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/intermediates/lint_intermediate_text_report/strippedUIEditingDebug/lint-results-strippedUIEditingDebug.txt
        
            FAILURE: Build failed with an exception.
        
        Downgrade that type of lint check to severity informational
        to not cause the build to fail.
        (Changes to address these will need to be done in Weblate,
        which is now the source of truth for translations.)
        
        Change-Id: Ibc82f96d29c8ac76f98db0259e1ee3cae4a986f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160772
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-14  Miklos Vajna  <vmiklos@collabora.com>  [6c1ea9d5c897d4fbd6de621c3594be60d60554e4]

        CppunitTest_sw_core_layout: remove duplicated assert
        
        See
        <https://gerrit.libreoffice.org/c/core/+/160756/2#message-9a43d741ca1307aa796eda092bd3857614c63a6f>.
        
        Change-Id: I6db7128240b344a8169214a70fdcaff3cab57286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160759
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [3e88c7c1df8b6f99a5c696b2e60adb2119ac676d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e99617c55d064c67d0caa82adb53925f5589c6bb
          - Related tdf#142926 Create help page about built-in help installation
            
            Change-Id: Ie71d9e5427a0bcdfeb9c20474e76635ca68a3f2a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160696
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-14  Weblate  <noreply@documentfoundation.org>  [40f850279d912786f7943d97ec6db73ee2bb874f]

        android-viewer translated using Weblate (Welsh)
        
        Currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: I84d27bd881bb9d9a28d4770aaff50cae81c217a2
        
        android-viewer translated using Weblate (Catalan)
        
        Currently translated at 48.4% (64 of 132 strings)
        
        Change-Id: Iba9603def2e2ebd3beb993e7188f226a4b3fa260
        
        Added translation for android-viewer using Weblate (Welsh)
        
        Change-Id: I2852724a5f0267a7108aca3b4fb887d15c8421bb
        
        android-viewer translated using Weblate (Catalan)
        
        Currently translated at 46.2% (61 of 132 strings)
        
        Change-Id: I148ee4d2ad33aa43dce5ce44ff5eff18df7239b9
        
        Added translation for android-viewer using Weblate (Catalan)
        
        Change-Id: I808e3a956f5758959cf9e708e6a3047f779cc024
        
        android-viewer translated using Weblate (Spanish)
        
        Currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Id83ee9b9d69499604e7bf3ac15a52e5e4264192e
        
        android-viewer translated using Weblate (Spanish)
        
        Currently translated at 98.4% (130 of 132 strings)
        
        Change-Id: I17e6b0385edb32a6da1871893c646488ec35419f
        
        Added translation for android-viewer using Weblate (Spanish)
        
        Change-Id: I572a602e665f896905d378294d5485b262b4b934
        
        android-viewer translated using Weblate (Galician)
        
        Currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Ic3026fb57a2042e45506d7507223c0b007271fe6
        
        Added translation for android-viewer using Weblate (Galician)
        
        Change-Id: I7af380682508b4a12c902c58002884750f4dc5d3
        
        android-viewer translated using Weblate (Armenian)
        
        Currently translated at 100.0% (132 of 132 strings)
        
        Change-Id: Ia57e0477acc8f14ee597b0b6961e2a3067064a89
        
        Added translation using Weblate (Armenian)
        
        Change-Id: Id0c85ec1236b4a9c8a0f95c0d9510db4639e777a
        Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org>
        Co-authored-by: Rhoslyn Prys <post@meddal.com>
        Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com>
        Co-authored-by: Weblate <noreply@documentfoundation.org>
        Co-authored-by: Xosé <xosecalvo@gmail.com>
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/es/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/
        Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/
        Translation: android-viewer/android-strings
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160614
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7dd028c0e498ba86d96e0e99744fec6ddc21a91d]

        cid#1545211 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545218 COPY_INSTEAD_OF_MOVE
        cid#1545232 COPY_INSTEAD_OF_MOVE
        cid#1545243 COPY_INSTEAD_OF_MOVE
        cid#1545246 COPY_INSTEAD_OF_MOVE
        cid#1545251 COPY_INSTEAD_OF_MOVE
        cid#1545260 COPY_INSTEAD_OF_MOVE
        cid#1545261 COPY_INSTEAD_OF_MOVE
        cid#1545276 COPY_INSTEAD_OF_MOVE
        cid#1545295 COPY_INSTEAD_OF_MOVE
        cid#1545297 COPY_INSTEAD_OF_MOVE
        cid#1545301 COPY_INSTEAD_OF_MOVE
        cid#1545302 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I97ba935a4a2b8715b55ebbf6e853a66260b2eb90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2ee0500b6033e7dbfef221e28042f23da361869e]

        tdf#158576 Explain why OK btn is disabled
        
        User needs to view (verify) the cert first
        
        Change-Id: I52ce64678abc3b9f95a384e4082eaee1abf0549a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160747
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b9846d15bbf956915db7f026822137681f3bfdd8]

        cid#1545734 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545723 COPY_INSTEAD_OF_MOVE
        cid#1545708 COPY_INSTEAD_OF_MOVE
        cid#1545705 COPY_INSTEAD_OF_MOVE
        cid#1545684 COPY_INSTEAD_OF_MOVE
        cid#1545674 COPY_INSTEAD_OF_MOVE
        cid#1545673 COPY_INSTEAD_OF_MOVE
        cid#1545667 COPY_INSTEAD_OF_MOVE
        cid#1545661 COPY_INSTEAD_OF_MOVE
        cid#1545660 COPY_INSTEAD_OF_MOVE
        cid#1545657 COPY_INSTEAD_OF_MOVE
        cid#1545653 COPY_INSTEAD_OF_MOVE
        cid#1545636 COPY_INSTEAD_OF_MOVE
        cid#1545624 COPY_INSTEAD_OF_MOVE
        cid#1546124 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I7d50594e046a022147d9ddf077b8b2d8027f9bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [77ceeb844ac042f6a6089748ab4f1420c5dae5e9]

        package: GPG encryption: prevent manifest:start-key-generation ...
        
        ... completely, as currently it was generated for the first file-entry
        due to too late setting of bStoreStartKeyGeneration.
        
        Change-Id: I0cc80169deeea133bff45545fdf20fab6a6bedaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160716
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-14  Julien Nabet  <serval2412@yahoo.fr>  [3282756b7984457c79044d08127a4def64905979]

        tdf#158551: fix crash Paste Special with Operation (mdds)
        
        Change-Id: I0be1056261c6ef7f90fe9244265aa038c36a7dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160389
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-14  Miklos Vajna  <vmiklos@collabora.com>  [5fec60b4732bdbdb681be08e43a9be47c3bfb320]

        sw floattable: fix outdated text frame portions after split
        
        The document has a floating table of 2 pages, with some anchor text on
        page 2. Split of the anchor text resulted in 2 paragraphs: the first
        still hosts the floating table and now lacks a fly portion (overlap of
        text and floating table) and the second still wraps around the floating
        table but has the correct position.
        
        What happens is that we format the first text frame, then its flys
        (which moves the follow fly from page 1 to page 2) and then we format
        the second text frame. This means that the first text frame should have
        a fly portion to wrap around the floating table, but it does not have,
        because SwTextFrame::Format() is called for the first text frame, then
        SwPageFrame::MoveFly() is called, then SwTextFrame::Format() for the
        second text frame, i.e. no reformat of the first text frame after moving
        the fly.
        
        Fix the problem somewhat similar to what commit
        cf2c070de2bafeec3b476c6bff7bb4ac87ba46db (sw layout: invalidate margins
        of body content when moving a fly from page, 2022-12-09) did, but here
        what's outdated is the portions of the text frame, and only for the
        anchor text frame.
        
        This fixes the problem in practice, but note that in theory this could
        affect non-split flys and also other, non-anchor text frames as well.
        Limit the update of the portion list to the anchor of the split fly, but
        we may want to do the same for all lowers of the body frame if there is
        a practical need for it.
        
        Change-Id: I3067e78d30e16ed3d2f02a80cff4cd84d9bdcf3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160748
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-14  Darshan11  <darshan.upadhyay@collabora.com>  [a5aa5c7fad5ae07d8c4958d9f18bf0c2bd820b9a]

        Disable Select/Unselect-current Filter Checkboxes in Calc
        
        Change-Id: I99a3d78bfbb65e751328452d7405d7844f810dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160082
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 5788f736578dc22bc9bcd46a6e75233237b82af2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160697
        Tested-by: Jenkins

2023-12-14  Darshan11  <darshan.upadhyay@collabora.com>  [1ad7c71892cc0d6ea451ab4026dc82f54ed48f6f]

        Fix posx and posy for Filter by color in autofilter jsDialog
        
        Change-Id: I2d4cd198197250495cc87eb1ee68407baf8e6a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160216
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8b08a9927bc4ee66a9575c658934dd27f06be702)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160698
        Tested-by: Jenkins

2023-12-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [bcffed442b308a01e31fe8c832a12b47ec774290]

        Fix typo: I10N -> L10N
        
        Change-Id: I20a0eb54a85a9dea5c7d4cd91ff3632574b14802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160714
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2023-12-14  Julien Nabet  <serval2412@yahoo.fr>  [4eb875d95622fb4346d3f8b24327a1b84230eca1]

        tdf#158684: CHART XY Scatter Chart: line type "stepped" ignores parameters
        
        Regression from 65752e649872edfd98915035b61aca510ae8f271
        Date:   Fri Mar 24 10:52:13 2023 +0100
        jsdialog: enable and make async chart line prop dialog
        
        Change-Id: I1532c45ae72d2c45ace72bcc099fcc8baa265b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160715
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-14  Miklos Vajna  <vmiklos@collabora.com>  [c5b71a7f6c9673074871ad84df655faeb6a036eb]

        CppunitTest_sw_ww8export: avoid external fonts
        
        - sw/qa/extras/ww8export/data/cell-bg-color.odt:
          - missing font: 'Helvetica' try: Liberation Sans instead
        - sw/qa/extras/ww8export/data/tdf46441-2.odt:
          - missing font: 'Times Regular' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/ooo92948-1.doc:
          - missing font: 'Baskerville MT' try: Noto Sans instead
          - missing font: 'Futura Book' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/i120158.doc:
          - missing font: 'SimSun' try: Noto Serif instead
        - sw/qa/extras/ww8export/data/fdo68967.doc:
          - missing font: 'Arial Rounded MT Bold' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/n760294.doc:
          - missing font: 'Thorndale AMT' try: Liberation Serif instead
        - sw/qa/extras/ww8export/data/new-page-styles.doc:
          - missing font: 'Raytheon Corporate Logo' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/redline-export-1.odt:
          - missing font: 'Helvetica' try: Liberation Sans instead
        - sw/qa/extras/ww8export/data/redline-export-2.odt:
          - missing font: 'Helvetica' try: Liberation Sans instead
        - sw/qa/extras/ww8export/data/redline-export-3.odt:
          - missing font: 'Helvetica' try: Liberation Sans instead
        - sw/qa/extras/ww8export/data/tdf118564.doc:
          - missing font: 'FangSong_GB2312' try: Noto Sans instead
          - missing font: 'SimSun' try: Noto Serif instead
          - missing font: 'FangSong' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/tdf130262.doc:
          - missing font: 'Univers' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/tdf59896.doc (WW6):
          - missing font: 'MS Sans Serif' try: DejaVu Sans instead
        - sw/qa/extras/ww8export/data/tdf95576.doc:
          - missing font: 'Calibri Light' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/cjklist30.doc:
          - missing font: '新細明體' try: Noto Sans instead
          - missing font: 'PMingLiU' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/cjklist31.doc:
          - missing font: '新細明體' try: Noto Sans instead
          - missing font: 'PMingLiU' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/cjklist34.doc:
          - missing font: '新細明體' try: Noto Sans instead
          - missing font: 'PMingLiU' try: Noto Sans instead
        - sw/qa/extras/ww8export/data/cjklist35.doc:
          - missing font: '新細明體' try: Noto Sans instead
          - missing font: 'PMingLiU' try: Noto Sans instead
        
        The .doc files are edited with Word (convert to DOCX, edit there,
        convert back), the single WW6 file is binary patched, using spaces as
        padding for the shorter new font name.
        
        Change-Id: Ic023a0ba6e542ac0f3782dfef5986bdcf69f3056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160713
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a383794fba07cb6a356274febd55968fb25f77e4]

        tdf#158576 This button shows a certificate when only one signature found
        
        "Show signatures" should only be shown when there are multiple signatures,
        otherwise the button label must be "Show certificate"
        
        Change-Id: Iaed2d10b8e94bf6decad937dafef4795b7ed40dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160596
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [37b381e2877c60c84547b22117663a72ab02fadc]

        tdf#158576 Allow trusting certificates only once
        
        Macro mode "high" says that only signed macros from trusted sources can be run.
        
        When opening a document with a signed macro from an untrusted certificate,
        the user can either disable macros, or add the certificate to the list of
        trusted sources permanently and enable macros.
        
        This adds the possibility to trust the certificate only for the current document
        in the given scenario.
        
        Change-Id: Idf272498d930afc8a3f8be7f30889b77bf402d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160598
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4a859b3d2ffa4f427cd24bc4aacdc055d4c7826e]

        This dialog is no longer called when MacroTrustedAuthors is readonly
        
        Change-Id: I73bc43cf57f6a1ed3613f2cf30e469ce6d841248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160591
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [69814fc26fe21a258cf32fca021945f5bc69f59c]

        tdf#158576 Show warning when cert is not yet/no longer valid
        
        Change-Id: I4f517a5e2b33d508d1a501323c4d97dc025edfbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160566
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-14  Julien Nabet  <serval2412@yahoo.fr>  [b2fd2c247f7f62f9ae6826c4f1b9065a50313217]

        tdf#152929: Sparkline ignore "High points" color when all values are negative
        
        See https://en.cppreference.com/w/cpp/types/numeric_limits/min
        "min() returns the minimum positive value"
        
        https://en.cppreference.com/w/cpp/types/numeric_limits/lowest (since C++11)
        "Returns the lowest finite value representable by the numeric type T, that is, a finite value x such that there is no other finite value y where y < x."
        
        Change-Id: I322cd84f8124aa6f3f306c168f33cb633418b3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160719
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-14  Justin Luth  <jluth@mail.com>  [6cd6df7e0d6b0ff8150c9a95a35b17800942026a]

        tdf#158681 Revert "tdf#153613 writerfilter: don't always split para
        
        ... for shape w/ pagebreak"
        
        This reverts 7.6 commit a9bc19c2d4a35606668aa2dcc53355651b71ee78.
        
        The commit in general is probably fine. However, it fails in case
        of an empty paragraph (with only anchors).
        Unfortunately, there is no way of knowing ahead of time,
        so either everything needs to be processed after a delay,
        or else the paragraph needs to be split and then re-joined
        in case it is not an empty paragraph.
        Both options are extremely non-trivial - I don't know how
        to do either of them.
        
        In this case it is also the last paragraph in the document,
        again something not known during import and which has
        special-casing in MSO.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3
        
        Change-Id: I4471e216b6523032b85178d85795434694cc1e22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160720
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [297a6673175308168669870882c016b496652a76]

        Work around strange error seen at least with VS 2022 Preview 17.9.0 Preview 2.0
        
        > vcl/source/pdf/XmpMetadata.cxx(39): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'rtl::OStringLiteral<55>'
        > vcl/source/pdf/XmpMetadata.cxx(39): note: Invalid aggregate initialization
        > vcl/source/pdf/XmpMetadata.cxx(39): note: too many initializers
        
        (Smells like a bug in that compiler's u8"..." handling, where it maybe gets
        tripped by the 3-byte UTF-8 encoding of \uFEFF?)
        
        Change-Id: I1c6a856a67c8328ed5fcc2f2fa6bb26f16319f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160681
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-13  Michael Stahl  <michael.stahl@allotropia.de>  [09f23a3dc5cd571df347cba9b003195de35f3ddd]

        tdf#105844 package,sfx2: remove checksum infoleak when using AEAD
        
        AEAD provides the verification of the password automatically, by reading
        the entire stream the tag at the end will be verified.
        
        The existing attributes manifest:checksum-type/manifest:checksum leak
        information about the plain text.
        
        This was mitigated with the addChaffWhenEncryptedStorage() functions
        (see commit f57baefbd3c4c5d8e5ec28e8702c91d60ffc5de2) but a better
        solution that also works for non-XML streams is to simply omit the
        attributes; authenticated encryption provides better verification
        without any leak.
        
        * "ChecksumAlgorithm" property can be set to void now to remove the
          checksum
        * change a bunch of members in EncryptionData, ZipPackage,
          ZipPackageStream to optional
        * change ZipFile::checkValidPassword() to open the stream and return it
        
        Change-Id: Id95288d0c238c4f9940fc5a185df814e8edcbad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160711
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-13  Michael Stahl  <michael.stahl@allotropia.de>  [df23f570536c939ab4b44125ac8f62a8500e6f7c]

        sfx2: remove wrong asserts
        
        Mike Kaganski points out that "soffice -n anything.docx" triggers the
        one in GetOutStream(), called from SfxMedium::CreateTempFile()
        !bTransferSuccess path, so the assumption of which parts of SfxMedium
        can be in use concurrently was wrong.
        
        Change-Id: I40f321d71297cadcdf4bf9ba6f07c4db3d2ac523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160712
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-13  Patrick Luby  <plubius@libreoffice.org>  [1956bd5f27fa10a336b9cf9e27751eca5ff907b5]

        Fix unit test failure when using Skia in debug builds
        
        Calling aBitmap.HasGreyPalette8Bit() hits an assert when
        using Skia in a debug build so query the palette through
        the bitmap read access object.
        
        Change-Id: I12fad6783ec7d6df6c99db197aaa52fd4b01ed69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160684
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [13b7905ba142d78b6061c52a8cc191125b0d7d5f]

        Remove misleading comment
        
        ...that had been added with 33fa50e1191c75fd2fcbf6f852ec1d76af58a577 "Drop some
        pointless assertions" back in 2011, but is no longer meaningful now that this is
        a proper assert since 6e35794cad555485955c3b43593497dcdbf29840 "terminate
        XDesktop properly in unit tests"
        
        Change-Id: Id8592df03f2a4c070af3cc691a0aa65ba8c2c061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160675
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8dd210c44268850195204cd7b7ca5e7aab0b33e8]

        add a notifier for the "Edit Existing Cond Formats" warning dialog
        
        otherwise in --enable-dbgutil this assert with:
        
        vcl::Window::SetLOKNotifier(vcl::Window * const this, const vcl::ILibreOfficeKitNotifier * pNotifier, bool bParent) (vcl/source/window/window.cxx:3193)
        libmergedlo.so!Dialog::ImplStartExecute(Dialog * const this) (vcl/source/window/dialog.cxx:940)
        libmergedlo.so!Dialog::StartExecuteAsync(Dialog * const this, VclAbstractDialog::AsyncContext & rCtx) (vcl/source/window/dialog.cxx:1111)
        ...
        libsclo.so!ScCellShell::ExecuteEdit(ScCellShell * const this, SfxRequest & rReq) (sc/source/ui/view/cellsh1.cxx:2352)
        
        Change-Id: I8be89a1e5d7fa2498118bad7a94ed6aad743095b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ba9e3323da5ddc588754d00b2468fe3f9708328]

        loplugin:unusedfields
        
        The sPassword field in SvtHistoryOptions became redundant
        after
            commit c0fffdc36df687fe8e4eff49e5a00d3a3c1eb370
            Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Date:   Mon Oct 2 12:35:21 2023 +0200
            [API CHANGE] Remove deprecated Password config item
        
        Change-Id: Ie0c4597da5cd510f405400c215110c1e357cb497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [92691a5b0afa149495615d7b269e74569b798944]

        loplugin:unusedmethods
        
        Change-Id: Id0aed0077ed121fdaef574248427a3425248e7d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-13  Michael Stahl  <michael.stahl@allotropia.de>  [152e10996fe9c788daec940bab6fe897097ba992]

        sfx2: reduce warning spam from IsDocEncrypted()
        
        Change-Id: I76b9d550c297db7c6f8d1d9a2739fbe050727faf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160680
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-13  Michael Stahl  <michael.stahl@allotropia.de>  [e45cfa739128a878d55214216ff14d7807a63bc2]

        uui: remove use of org.openoffice.ucb.InteractionHandler/InteractionHandlers
        
        Since the configuration schema was removed in commit
        c48e810f1a856d392b2ffce6b343082406644ab8 this can now fail with:
        
        com.sun.star.uno.RuntimeException message: "cannot find /org.openoffice.ucb.InteractionHandler/InteractionHandlers at /home/ms/lo/master/configmgr/source/rootaccess.cxx:214"
        
        Just remove the code, there has been a better replacement since commit
        af66a011a47f673a9a0ee2c6a0b27e23b11b6ebf in 2010.
        
        Change-Id: I80582f77dfb1f301fa7fe4ccd2d5931e1c8771ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160678
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-13  Miklos Vajna  <vmiklos@collabora.com>  [d852e27ed205c1a60de0979b80f3861bf93c44ae]

        sw floattable: fix split of anchor text at para start
        
        The document has a floating table with some anchor text. If we hit enter
        at the end of the anchor text, the anchor text remains in the old text
        node and a new text node is inserted after it, still wrapping around the
        floating table. If you do the same at the start of the anchor text, then
        a new paragraph is inserted before the floating table, which is
        unexpected.
        
        The OOXML concept we try to model here is that a floating table is a
        table-in-fly that's followed by a paragraph that hosts the anchor text,
        so the anchor position of the floating table should never change. This
        behavior was even locked down in the testSplitFlyMoveMaster testcase,
        but there the motivation was to make sure the fly chain is consistent.
        
        Fix the problem by removing the special-casing in
        SwTextNode::SplitContentNode() for the "at para start" case that was
        added just to please the testcase. Instead update the test assert the
        bad 1 -> 4 -> 2 chain is not there, so it still covers the old fix but
        allows the new behavior.
        
        With this, the Word and Writer UI behaves the same when inserting a new
        para right after a floating table. The layout position problem of the
        empty text node (should be wrapped, is not) still needs fixing.
        
        Change-Id: Ib9a1f07eeb144ea929183cdc72a22bc23042fee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160669
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-13  Michael Stahl  <michael.stahl@allotropia.de>  [6e3a6ca0500f38f082dd699802fec367cb559200]

        package: move function down
        
        Change-Id: I92742a28cf60a9dfc80001f9ca3c5551fe94472d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160677
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-13  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [c358da05eb2a588b1bdf2fba96cc38f6f1e2221e]

        Fix number of actual arguments
        
        Change-Id: I04bb3462948aeab24d46ee7ee910fdae8da2aa65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160674
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-13  Vojtěch Doležal  <dolezvo1@cvut.cz>  [94d18ea557a03c1f2d450454908787f7d3af8a6e]

        tdf#158505 - Fix PDF export when bibliography is last paragraph
        
        Change-Id: Iadafff97ba19d5c24be768238bddb4d684edde1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160509
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [6b788f8baf4c6ba42dc6c0f580fbf9480d8c60d3]

        android: Make the build fail on new lint warnings
        
        In order to avoid introducing new lint errors,
        also run the `lint<buildVariant>` gradle target when building
        Android Viewer and set the `warningsAsErrors true`
        lint option.
        This makes the build fail on (new) lint errors.
        
        See [1] for more details.
        
        Downgrade missing translations and issues that can "suddenly"
        appear without any code changes to the app itself to informational,
        to prevent (CI) builds from suddenly starting to fail just because
        a new Android Gradle Plugin version or external library becomes
        available etc.
        
        To be able to avoid introducing new issues without having to address
        all existing ones right now, use a baseline file ("lint-baseline.xml")
        as described at [2] which lists all existing issues, so they don't
        result in a failing build.
        Those should still be looked into at some point.
        
        Updating the baseline file can be done by just removing the
        existing one and running the build again. (Build will create the
        new baseline file and fail on first run after deleting the file,
        then find the new file and succeed in subsequent builds.)
        
        [1] https://developer.android.com/studio/write/lint
        [2] https://developer.android.com/studio/write/lint#customize-the-baseline
        
        Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160199
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5757588c44218d720d912410c54338d29e2ce0e5]

        Fix typo
        
        Change-Id: I464395f7aae8574bf81d2da7facd28e48bd04515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160629
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ddedd5a7512ba8a6154605bcbd0f5a3b5fe6add1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 463b64614aed4bb4bce500f782f131d9f88308e9
          - Fix typo
            
            Change-Id: Ic83d89754136ff476eb2f39aeb764cff03188784
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160670
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-12-13  Matt K  <mattkse@gmail.com>  [5b06b879916cd1682afd40201d6704711f909ff9]

        tdf#142695 Update tooltips for tools in Draw/Impress
        
        This change simply updates the tooltips for tool icons
        in Draw/Impress to inform the user that they can
        double-click the icon to continue using that specific
        action.
        
        Change-Id: I516cf9f110bd3c7dcb1545989b86155cc84617f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160555
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [f625928c346109216045d08b4dda30dbada005f5]

        tdf#158636 Wrong border behaviour when cells are merged
        
        regression from
            commit e27d4cc31e04be4c47b5085dfa2363ee45457e8a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jun 19 12:23:55 2023 +0200
            tdf#150534 reduce the memory consumption of cells when calculating
        
        where I accidentally removed a line in lclSetMergedRange that
        set mbMergedOrg to true.
        
        And then the singlevalfields plugin spotted that
        mbMergedOrig had only value, and so it got removed in:
            commit 884a2cd39a7c0433a5bbbf4e83e2a9b16cdad71c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jun 30 15:36:51 2023 +0200
            loplugin:singlevalfields
        
        Change-Id: I9fc057f63e14df36c73d25c421ddbec72f7723e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [91b4bfee9d52a7aa169eec81aa017d03108e4026]

        Enable Skia in unit tests
        
        CreateSalInstance will set aUsePlugin to "svp" in case it is in
        SAL_USE_VCLPLUGIN environment variable (can be controlled using
        gb_CppunitTest_use_vcl_non_headless in makefiles); when true is
        returned from Application::IsBitmapRendering(); or when true is
        returned from IsHeadlessModeRequested() (e.g., when '--headless'
        is used in the command line). The latter is true for most of the
        CppunitTests, including CppunitTest_vcl_skia (it may be controlled
        by gb_CppunitTest_use_vcl_non_headless_with_windows in makefiles).
        
        Then this would ensure that Application::EnableBitmapRendering is
        called.
        
        isVCLSkiaEnabled gave false, when Application::IsBitmapRendering
        was true, which meant that all tests in CppunitTest_vcl_skia
        effectively didn't run at all.
        
        With this change, on platforms where there's no 'svp' plugin,
        Skia will be enabled in unit tests in software mode: Windows and
        macOS.
        
        Fix bug in a couple of places, where the SkAutoCanvasRestore
        needs to be destructed before we call other code, otherwise
        we hit an assert in destroySurface().
        
        Disable the vcl XOR test and CppunitTest_sd_png_export_tests,
        in skia mode, just so we can just this commit
        in, that will need further investigation.
        
        Tweak assert in addPolygonToPath to account for case where
        polygon has zero points.
        
        Change-Id: Idc0a66d27deb3cf09f631a42bbe037714ebcdc0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-13  Miklos Vajna  <vmiklos@collabora.com>  [918515d6fc6e2eaa000c4a997d604b7b00b492e3]

        Update pdfium to 6179
        
        - Remove ubsan.patch, upstream switched to FXSYS_memset() in this
          function, which does a similar length check as our patch did.
        
        Change-Id: Ib418cd8e642d2be9f448c92f25f85bec25e34598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160627
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [ff071078ee5f13f0e9d430d6783444a631d232a0]

        reprobuild: don't write timestamps to clucene index files
        
        Our embedded clucene by default write a random current-time
        millisecond value into version fields, in an attempt to
        randomise. Clearly this is not needed for our static help, and it also
        prevents builds from being reproducible.
        
        Change-Id: I011388b5bc72b5d86bc1900f5439036ede60c020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158845
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-13  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fd527ecbac39c6e15cc27da30bd05cb2ff85fd82]

        Drop some wrapper methods from SvtOptionsDrawinglayer
        
        just use the wrapped officecfg methods instead of:
        
        IsOverlayBuffer
        IsPaintBuffer
        IsOverlayBuffer_Calc
        IsOverlayBuffer_Writer
        IsOverlayBuffer_DrawImpress
        IsPaintBuffer_Calc
        IsPaintBuffer_Writer
        IsPaintBuffer_DrawImpress
        
        Change-Id: I2bd340b8c9c711c33c19fb1d764ce20bade0476e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160651
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-13  Jim Raykowski  <raykowj@gmail.com>  [bb0a2be91930fbae07657f214b53117b9e8cc204]

        tdf#158276 tdf#86395 Make alphabetical sort setting persist
        
        by using a bitwise storage approach inspired by the ActiveBlock
        setting where each content type corresponds to one bit position of
        the stored integer, e.g., bookmarks content type corresponds to bit
        5.
        
        Change-Id: I50de26e44a8d2afb917f3a651eef9a8f704b751f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159916
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-12-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [22727f590cf0e1c5512f60d47824e78a6cce4c32]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ceaee12caa0e8d6caf4fc7fc3adb155898f6a44
          - tdf#155876 UI cmds Calc-Sheet menu (31)
            
            + Sheet menu for Calc: fill cells
            + refactoring
            
            Change-Id: If6aa8c42896f67b58e41b6454785a78dfaa344d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160658
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5d8b4a23e2099baa50c14fcd32a8a48a8f874684]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4953ea62c3603c2c3f66faf67dac67ba987476c9
          - tdf#155876 UI cmds Calc-Sheet menu (30)
            
            + Sheet menu for Calc: clear cells, references, fill
            + refactoring
            
            Change-Id: I0c0c10af4a9983e893907aa5c0a491b5814dae22
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160657
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a71f8d7b487a60fc9d3c820a5661cd4a126b41f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfd902c240c11e611732f1c26345869354a56ba6
          - tdf#155876 UI cmds Calc-Sheet menu (29)
            
            + Sheet menu for Calc, insert sheets, external links
            + refactoring
            
            Change-Id: I79838e7b1f25240a2a0932138c2cd62e70feea6d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160656
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-13  Michael Weghorn  <m.weghorn@posteo.de>  [8d268ed276a421e6c3c697093b69dd5aaf181d63]

        android: Remove generated resources in "clean" make targets
        
        Since these are produced by the build, they should also
        be removed in the "clean" target.
        
        Without this, Jenkins CI builds for the upcoming
        
            Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 8 14:57:14 2023 +0100
        
                android: Make the build fail on new lint warnings
        
        were seen failing, despite the example file no longer being
        part of the generated resources since
        
            commit 1d7b1e2d4099aac15e695696e6a0640d6e01e23f
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 15 13:16:26 2023 +0100
        
                android: Drop "More Info" item in "About" dialog
        
        , but apparently the file was still lingering around
        from previous builds.
        
        Build failure/Lint error from CI build [1]:
        
            > Task :lintReportStrippedUIEditingDebug
            Wrote HTML report to file:///home/tdf/lode/jenkins/workspace/android_arm/android/source/build/reports/lint-results-strippedUIEditingDebug.html
        
            > Task :lintStrippedUIEditingDebug FAILED
            /home/tdf/lode/jenkins/workspace/android_arm/android/source/lint-baseline.xml: Information: 237 errors and 11 warnings were filtered out because they are listed in the baseline file, lint-baseline.xml
             [LintBaseline]
            /home/tdf/lode/jenkins/workspace/android_arm/android/source/res_generated/raw/example.odt: Error: The resource R.raw.example appears to be unused [UnusedResources]
        
               Explanation for issues of type "UnusedResources":
               Unused resources make applications larger and slow down builds.
        
               The unused resource check can ignore tests. If you want to include
               resources that are only referenced from tests, consider packaging them in a
               test source set instead.
        
               You can include test sources in the unused resource check by setting the
               system property lint.unused-resources.include-tests =true, and to exclude
               them (usually for performance reasons), use
               lint.unused-resources.exclude-tests =true.
               ,
        
            1 errors, 0 warnings (237 errors, 11 warnings filtered by baseline lint-baseline.xml)
        
            FAILURE: Build failed with an exception.
        
        This could also be reproduced locally:
        
        After a
        
            $ touch android/source/res_generated/example.odt
        
        , the above error would on build, and neither `make clean`
        nor `make android.clean` would remove the file and thus
        fix the problem for subsequent builds.
        
        Add removing the directory to the top-level and Android-specific
        clean targets, so either of these commands now takes care of this.
        
        [1] https://ci.libreoffice.org/job/gerrit_android_arm/33845/console
        
        Change-Id: I91c83ce4ddb236d87d7c51f4dcce85e99aae0107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160612
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-12  Sahil  <me.sahilgautam@gmail.com>  [d981ee6256a905eb8a45557869288a06eb5ae0fc]

        tdf#33201 Add UNO command for Column/Row Highlighting
        
        * Add uno command
        * Add menubar Entry [x] Column/Row Highlighting under View
        
        Change-Id: I86cb0034d5bd7d64bd6bfd64cf6e20507d14e5fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159364
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2023-12-12  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [189d827b996438ae92ec85ba63a6ccc8da2b54b0]

        Split --with-update-config=... into many --with-online-update-mar-...=...
        
        ...and allow each of them to be left off, for debug purposes, even if that may
        render the resulting --enable-online-update-mar feature non-functional.
        
        This change tracked each item that was potentially read from the
        --with-update-config ini file, and turned each of them into a new
        --with-online-update-mar-... option.  The only exception and remaining TODO is
        bin/update/upload_build_config.py (called from Makefile.gbuild).
        
        distro-configs/Jenkins/LibreOfficeLinuxUpdater.conf (which might well be dead)
        set --with-update-config=~/updater.ini with an ini file of unknown content.  So
        that no items are silently missing if we ever resurrect that distro-config, I
        set all of the new options to =TODO there for now.
        
        Change-Id: I17a13e0d190a868436bac10c1b0a6675d8c704c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160622
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-12  Alain Romedenne  <alain.romedenne@libreoffice.org>  [c1efe3f73c02b6759afdbe71ee815b503e82381b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a47d92625a2921bcf56d72593bf33f5a8b87b768
          - Add Toolbars() method in various SF services + toc
            
            Change-Id: I1109429a42d28f6be2eecabfe727bf146d1cd927
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160368
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-12-12  Gabor Kelemen  <kelemeng@ubuntu.com>  [2c6f28f43167118b5149bc74cb48852d509dfc74]

        tdf#146619 Recheck include/[v-x]* with IWYU
        
        Change-Id: I3cecd622aa04d842a449b4bfd6c55d0b8b96aabf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156992
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4571e1625f7aaa63cde04a2a8a608abba0f45532]

        wasm: include missing custom shape presets
        
        without which docx import of shapes generally doesn't work
        
        Change-Id: Ie7921ad3fa9759d2914abe5b0c694fcf3b443b61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160587
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ae117fe829ad744a98231dc992a7c1692b591c9d]

        cid#1546444 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546389 COPY_INSTEAD_OF_MOVE
        cid#1546388 COPY_INSTEAD_OF_MOVE
        cid#1546360 COPY_INSTEAD_OF_MOVE
        cid#1546158 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3707d55b88674dfb5ae786fc2cc45000862340de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [45df690b078dc9c44fc83f0d431eeeeb53710cfa]

        cid#1559173 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1559172 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I63f2c43d1b78d628443580930c2579428b6ba046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160610
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f544dfeaf4c9cab5c626a4fdf285586f43a06b0c]

        tdf#148035: sw_ooxmlexport20: Add unittest
        
        Change-Id: I33168ef9a1526782471ddda8f1acda94b3c4a626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160613
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f39535715ee2dadf7a2ad32d68df5ddba2e28a71]

        Fix typo
        
        Change-Id: Ifaaa4d1fb93885fa7b7352f1e882c0b6c0d1a782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160616
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30d3a5743961274d360e683eccd2756257ed5e7a]

        tdf#158320 restore Live Preview for font hovering
        
        a) announce Preview when a 'selected' font preview is requested
        b) move EndPreview to when the dropdown popups down, rather than listen
        to ESC
        
        Change-Id: I68916769150c23c0ec18aae084cdf3cafb7352a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160609
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [890effa901a1406161d80acce8c3e7209ea78989]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53a2884e42a11e02e747aba28a57563a68e1c1c5
          - Improve sentence on SF_Dataset help page
            
            This patch improves a sentence following a suggestion in Weblate.
            
            Change-Id: Iff1574d6a960daf6c29cdf67ccee3df1d6a6f29e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160575
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2023-12-12  Dr. David Alan Gilbert  <dave@treblig.org>  [80785bb26a1f96d5f5bced7940473d22af00cb60]

        tdf#147021 Use std::span to avoid SAL_N_ELEMENTS in CustomShape
        
        The final set of these, nailing the 'handles'.
        
        Again, most of the changes are mechanical
        
        Change-Id: Ic65cec21db2366bcfa6ac40bcf9041b081c2ed71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153889
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [755ce3ae9f6c672cc3ac1596fce182cd2c6993db]

        vcl: remove out of sync comment - the code has since changed!
        
        Change-Id: I4354d64671db697be4e4ea7c907bb13fa421e0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158462
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [144ac97827ddf770c5185549d6dba47f698b9807]

        vcl: BreakLinesWithIterator() is actually looking for the length of the string
        
        Change-Id: Id4a6f56dfcbf87418b5be8404c4321a5611b0465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158461
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-12  Lodev  <lodev@ossii.com.tw>  [e91290190e4b2ef3cc07efb2bda42ea37b246354]

        tdf#158388 Allow user to open ODS file with corrupted meta.xml & settings.xml
        
        1. Follow sd/sw module to give corrupted meta.xml and settings.xml only
        warnings instead of blocking user to open.
        
        2. only set rError after all the if's and Removing the unnecessary bRet assignment
        
        Change-Id: I6dd6acd919d1fbec91ef4a0d0e78623f0c65dc40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160605
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [0db0662376dd9e89e1ad1e0a5764c69f94f9a059]

        vcl: move bClipping closer to first use
        
        Change-Id: Iad480c82cce99f14448588154bf96ae4ec5605f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158404
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [37bd1098fa0b2c5094aee0a48feff260b59681f3]

        vcl: extract lcl_GetEndOfLine()
        
        Change-Id: I2bc8750fc9ebfc4bc080020d744e2cf9fac75dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158460
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [5aad3b5d8c4da23e90869b70907c3e5c5883ceea]

        vcl: extract lcl_ShouldBreakWord()
        
        Change-Id: Ib552ee59d23215d2c714c10b3ef1f7fc3e8a890f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158401
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-12  Mike Kaganski  <mike.kaganski@collabora.com>  [fbefacef9e136d434d5dc788d4e918bb6e3815f4]

        Simplify and fix SvGlobalName comparison
        
        Its operator< (required for stl containers) was not comparing Data4.
        The defaulted comparison uses a different order, but that shouldn't
        matter.
        
        Change-Id: Id9b9d782b393866100c3e994a3902e7ce9a2676f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160607
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-12  Adam Seskunas  <adamseskunas@gmail.com>  [380081381ff3b3cae64a40c6cc2a82772cb663c1]

        tdf#113866 Add test.
        
        Test if font color persists when exporting to pdf *and*
        Print Text in Black is true.
        
        Change-Id: I20ccc59cad2e5c7b5d52c69673675fed61a76080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160321
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-12  Miklos Vajna  <vmiklos@collabora.com>  [0746d13365139c356eb9d297a358c486bf47d6fb]

        sw floattable: fix split of anchor text in 2nd half of the paragraph
        
        If you go to the anchor text of the floating table and you press enter
        in the second half of the anchor text, you get a layout loop.
        
        The reason for this: an invariant around split text frames were
        violated, later resulting in a layout loop. The rule is that in case you
        have a split frame, then there can't be a frame for a new text node
        between the two split frames. So no new text frame for an other node
        after the master anchor of the fly; no new text frame for an other node
        before the follow anchor of the fly.
        
        Fix the problem by improving SwTextNode::SplitContentNode() to check if
        this is an anchor for a split fly: if so, always insert the new text
        frame after the follow anchor of the fly, which doesn't break the above
        invariant.
        
        The layout loop is fixed, but the text in the follow anchor of the fly
        still has a bad position, that still needs fixing. Also currently
        testSplitFlyMoveMaster enforces that split at the para start inserts a
        paragraph before the floating table, so leave that case unchanged for
        now.
        
        Change-Id: I77962a354e297d2e9957edcce9bf140f2c72fc6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160608
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-12  Mike Kaganski  <mike.kaganski@collabora.com>  [70153b7350fbd0c12a63e879a93a443672061044]

        Make some SvGlobalName ctors constexpr
        
        Change-Id: Idacca005723b995061dc1df06f98bd584cbfd675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160606
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-12  Miklos Vajna  <vmiklos@collabora.com>  [c4ba535eccf1e264d7c9feea48156a2b48000dd6]

        sw: document SwFrame::Paste()
        
        It was clear we want to insert a frame, but which frame is to be
        inserted and if that will be before or after the non-parent frame was
        far from clear. Document this based on how it's implemented in
        SwContentFrame::Paste() and SwFrame::InsertBefore().
        
        Change-Id: I3eea471f9feecb35e20910e1869f5db1406d7c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160603
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-12  Justin Luth  <jluth@mail.com>  [78fb5e63a4c4832181b92550df567e9b9fd56ba6]

        tdf#111969 sw: acknowledge that last half-character is in selection
        
        Wow, wrong since initial import and no one has touched it yet.
        This is not obscure code - it is called on most right mouse clicks
        and various other places. Kinda scary to make a change here...
        
        This unit test is copied from testCreateTextRangeByPixelPosition.
        Hopefully this pixel code is stable enough for unit tests...
        
        m_bPosMatchesBounds was introduced with
        commit cc63f3f550be4c8fe22cc8c6ff874812eefae20e
        Author: Vladimir Glazounov on Thu Apr 17 09:08:37 2003 +0000
        
        make CppunitTest_sw_uiwriter3 \
            CPPUNIT_TEST_NAME=testTdf111969_lastHalfcharOfSelection
        
        Change-Id: Ia2bcb93e390d14c9b4c1ab8a7059c41ed1b92429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160442
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [22250df05830700b2555348b8ac46ee1007d0e5d]

        tdf#158548 vcl: Require mouse over listbox to mouse-wheel through entries
        
        As described in tdf#158548, it's unexpected that listbox/
        combobox entries change when using the mouse wheel while the
        listbox/combobox has keyboard focus, but the mouse cursor
        is positioned somewhere else
        
        Therefore, only do that for the VCL ListBox when the mouse cursor
        is currently positioned above it, which also matches what
        e.g. native Qt applications do.
        (When using the gtk3 VCL plugin that uses a native GtkComboBox,
        nothing changes on scroll independent of the position.)
        
        Change-Id: I8a69628471c1cd4258194627b95145d6b8fb686a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160459
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [946a7fd8063219b3621fbdc22c28a57ee72a2067]

        android lint: Drop unused image resources
        
        Drop unused image resources that lint warns about, e.g.:
        
            <issue
                id="UnusedResources"
                message="The resource `R.drawable.action_search` appears to be unused">
                <location
                    file="res/drawable-hdpi/action_search.png"/>
            </issue>
        
        Change-Id: I69422d485fc324245fd562fd75b016862b29c2a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160490
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-12  Michael Weghorn  <m.weghorn@posteo.de>  [43689c37648adb934ca902c6ae4acb4f8ec831ef]

        android lint: Drop extra closing XML tag
        
        This was accidently added in
        
            commit a21e7a76d745750dcea14bc6311e4f1766c3fa45
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Nov 9 10:24:13 2023 +0100
        
                android a11y: Add content labels
        
        and now reported by lint:
        
            <issue
                id="ExtraText"
                message="Unexpected text found in layout file: &quot;/>&quot;"
                errorLine1="            />"
                errorLine2="            ~~">
                <location
                    file="res/layout/toolbar_bottom.xml"
                    line="481"
                    column="13"/>
            </issue>
        
        Change-Id: If4a17c4cd10450c2f5e13ead88a7511684ab9956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160469
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-12  Aron Budea  <aron.budea@collabora.com>  [93801094fa7a3d276dc56138fafbf21029aae4d5]

        sc: Unify GetColumnData
        
        This added ColumnData:
        a15c02effa654da06e9695b5e4c0c595f851a878
        This added GetColumnData:
        1c53f5b6647dcffa57012990d342b21eaff19888
        
        Both functions are the same, one is const, other is non-const.
        
        Change-Id: I8ed214290c7ee8d9e22bd466f9ada95b40300e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160601
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-11  Stephan Bergmann  <sbergman@redhat.com>  [76400f66096a5cdc64cbd72ed9a94961b3200216]

        Step 3 of removing cargo-cult pragma pack around rtl_[u]String
        
        see 8ae3ae4bf75fdd0aaa132c956d9da029baa3adc6 "Step 1 of removing cargo-cult
        pragma pack around rtl_[u]String"
        
        Change-Id: If6c2ea0ab2e7e61cdbc880d7b27d2af7f816e66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158568
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c4d420a7fb8afed4bda776b9c808f3959184bca8]

        Only run test dependent on MS Paint OLE class, if Paint is installed
        
        Nowadays, MS Paint is optional component distributed through MS Store
        (https://www.microsoft.com/store/productId/9PCFS5B6T72H); it may be
        absent on some systems, resulting in tests relying on it failing.
        
          [build CUT] embeddedobj_msole
          [_RUN_____] testSaveOnThread::TestBody
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:207: Loaded object has no cached size!
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:232: OleEmbeddedObject::getVisualAreaSize: GetExtent() failed: com.sun.star.embed.UnreachableStateException message: "Class not registered
          Bitmap Image at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:904" context: class OleComponent
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1142:  OleComponent::GetCachedExtent: GetExtent() failed
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:257: OleEmbeddedObject::getVisualAreaSize: GetCachedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1143" ArgumentPosition: 0
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1160:  OleComponent::GetRecommendedExtent: GetExtent() failed
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:271: OleEmbeddedObject::getVisualAreaSize: GetRecommendedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1161" ArgumentPosition: 0
          warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:554: EmbeddedObjectRef::GetSize: no visual area size
          warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:573: EmbeddedObjectRef::GetSize: empty size, defaulting to 5x5cm
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:207: Loaded object has no cached size!
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:232: OleEmbeddedObject::getVisualAreaSize: GetExtent() failed: com.sun.star.embed.UnreachableStateException message: "Class not registered
          Bitmap Image at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:904" context: class OleComponent
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1142:  OleComponent::GetCachedExtent: GetExtent() failed
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:257: OleEmbeddedObject::getVisualAreaSize: GetCachedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1143" ArgumentPosition: 0
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olecomponent.cxx:1160:  OleComponent::GetRecommendedExtent: GetExtent() failed
          warn:embeddedobj.ole:123152:104988:embeddedobj/source/msole/olevisual.cxx:271: OleEmbeddedObject::getVisualAreaSize: GetRecommendedExtent() failed: com.sun.star.lang.IllegalArgumentException message: "at C:/lo/core/embeddedobj/source/msole/olecomponent.cxx:1161" ArgumentPosition: 0
          warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:554: EmbeddedObjectRef::GetSize: no visual area size
          warn:svtools.misc:123152:104988:svtools/source/misc/embedhlp.cxx:573: EmbeddedObjectRef::GetSize: empty size, defaulting to 5x5cm
          C:/lo/core/test/source/xmltesttools.cxx:171:testSaveOnThread::TestBody
          equality assertion failed
          - Expected: 0.1665in
          - Actual  : 1.9685in
          - In <>, attribute 'visible-area-width' of '//style:graphic-properties' incorrect value.
        
        Check the class registration, and exit early if needed.
        
        It is unclear if we should do something specific with MS Paint objects
        on Windows, when MS Paint is absent, as we do on Linux; this is just
        a quick workaround.
        
        Similar checks might be needed in other tests.
        
        Change-Id: I4d99bc3b13d84da53bdb5aa6259083a68ccc8871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160597
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-11  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [638d25d141fdaf2ec54dfcc7d9d42207150761a3]

        Move Android buildfeature config to build.gradle
        
        Old gradle.properties entry was deprecated in 8.0:
        - https://cs.android.com/android-studio/platform/tools/base/+/0bc1c23297760643b03e8cfd8acc52c007a99cd6
        
        Change-Id: Ia34379e8112cc2c316be229e7719c2ce1b695576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160602
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7530ef02827c7e62ce5313c99e84ce8ff15513ab]

        Fail when explicit --enable-ccache cannot be honored
        
        Change-Id: I2b638dad3e3a1f3d7044997061a8597b44067a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160600
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Michael Stahl  <michael.stahl@allotropia.de>  [f0fda7ad2236f478fea396a23d4f982e5fc37e68]

        tdf#105844 offapi,package,sfx2,xmlsecurity: add AEAD w/ AES GCM
        
        ... and use it in the new experimental ODF encryption mode.
        
        https://www.w3.org/TR/xmlenc-core1/#sec-AES-GCM
        
        Unfortunately it turned out that NSS PK11_CipherOp() does not work with
        CKM_AES_GCM because it is initialized with "context->multi = PR_FALSE"
        in sftk_CryptInit(), so the one-step functions PK11_Encrypt() and
        PK11_Decrypt() have to be used.
        
        NSS 3.52 also changed a parameter struct definition - see
        https://fedoraproject.org/wiki/Changes/NssGCMParams - which is not a
        problem for RHEL or SUSE system NSS since those are rebased, but it
        is likely a problem for less well maintained Ubuntu LTS, so use
        the old struct definition which evidently still works with NSS 3.94.
        
        NSS 3.52 also added a new PK11_AEADOp() API but it looks like this
        doesn't support incremental encryption either.
        
        Change-Id: Ibd4a672db74b65b1218926ba35ff8d2f70444c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160505
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-11  Michael Weghorn  <m.weghorn@posteo.de>  [4bba7fbc22f13d579e57b36e8c8e302d987e01f0]

        android lint: Add API level check for EXTRA_INITIAL_URI
        
        `DocumentsContract.EXTRA_INITIAL_URI` was added in API level 26,
        so only set it conditionally when that API level is avaible.
        
        Change-Id: I6783e89f50354c017968b74cc45fb1a3b6faab83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160468
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [885538d308e49a10eb67e0b6f23f3acc0a91d1e2]

        -Wimplicit-function-declaration
        
        > workdir/UnpackedTarball/zlib/gzlib.c:242:9: error: call to undeclared function 'lseek'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >   242 |         LSEEK(state->fd, 0, SEEK_END);  /* so gzoffset() is correct */
        >       |         ^
        
        etc., as causing an error now by default with Clang 18 trunk
        
        Change-Id: Ic19c5710357a1f65046b5a225c6a181c3046938c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160554
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Justin Luth  <justin.luth@collabora.com>  [5f888fa920c99cce91dfd18244a5c3869807b970]

        tdf#108505 rtfexport: avoid mis-inheriting field char settings
        
        The field result fully defines its own character properties,
        so it should not inherit any "parent" properties from the field.
        
        My test file didn't show any problems with DOCX or DOC,
        and reading through the code I didn't notice anything
        that looked wrong. Both are very different from RTF syntax,
        and it didn't look like they did anything "special"
        for this situation, so nothing to copy from...
        
        This whole area of field properties looks very hacky,
        but it seems pretty clear that OutputTextNode
        loops through OutAttr's run properties for each of
        start/sep/end for fields. OutAttr picks up all of the
        direct formatting, so nothing should be "missing",
        and therefore a \plain character reset should be appropriate.
        
        The good news is that MS Word 2010 imported both the bad
        and the good export just like we do.
        
        make CppunitTest_sw_rtfexport6 \
            CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat2
        
        
        Change-Id: I713c071dfcd40117bfff03d152718eb5d847327e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160375
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7d5c403f3759b14fe3be206f4c29494799eac2b4]

        tdf#158473 - UI: Part 55 - Unify lockdown behavior of Options dialog
        
        for Calc - Grid Page.
        
        Change-Id: Ic29e06c2f1a5e71e1b6236c321cfcb4b1afc39f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160564
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3c4b11c46049c772dde35b63585c49a3b3eb1d83]

        Reuse GetContentPart instead of duplicating it
        
        Change-Id: I99790638b2de0df548875c6841c1dd46032894d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160567
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f6798949626e71d94c1c865e5e7d909110e41b0]

        Fix typo
        
        Change-Id: I628574420b9ac84f6f249002236d8970e348f0b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160590
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-11  Michael Stahl  <michael.stahl@allotropia.de>  [0a2df11fb563177951db1e8890d67cee8d44246a]

        curl: upgrade to release 8.5.0
        
        Fixes CVE-2023-46218 (cookies apparently used by libcmis)
        
        Change-Id: I6f903ab63589d3318c0cc7d47f5183f7ae55f52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160592
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [27a24fc1eb486956956a5b5cf64e5152ded82ace]

        cid#1545577 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545679 COPY_INSTEAD_OF_MOVE
        cid#1545691 COPY_INSTEAD_OF_MOVE
        cid#1545697 COPY_INSTEAD_OF_MOVE
        cid#1545711 COPY_INSTEAD_OF_MOVE
        cid#1545730 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic0777a8ba532b00b021ffed81243505fbb7250f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160568
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [53c21bbea05fbd36bf605414350a554753cdfa17]

        macrowarnmedium: Save with newer Glade
        
        Change-Id: Ida8f4be081fb3b695a6c87354b2862ec103bd432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160565
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d2346c3d4d38edf5c89c3600caf23baf41164d63]

        -Werror,-Wdeprecated-declarations
        
        > compilerplugins/clang/pluginhandler.cxx:67:71: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations]
        >    67 |         compiler.getASTContext().getSourceManager().getMainFileID())->getName());
        >       |                                                                       ^
        > ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here
        >   331 |   LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "")
        >       |   ^
        > ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED'
        >   155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
        >       |                                                  ^
        > compilerplugins/clang/pluginhandler.cxx:355:35: error: 'getName' is deprecated: Use FileEntryRef::getName() instead. [-Werror,-Wdeprecated-declarations]
        >   355 |         StringRef const name = e->getName();
        >       |                                   ^
        > ~/llvm/inst/include/clang/Basic/FileEntry.h:331:3: note: 'getName' has been explicitly marked deprecated here
        >   331 |   LLVM_DEPRECATED("Use FileEntryRef::getName() instead.", "")
        >       |   ^
        > ~/llvm/inst/include/llvm/Support/Compiler.h:155:50: note: expanded from macro 'LLVM_DEPRECATED'
        >   155 | #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
        >       |                                                  ^
        
        since
        <https://github.com/llvm/llvm-project/commit/d1f86c3d03b7549eb0153c62550ef0f513ff50e8>
        "[clang] NFC: Deprecate `FileEntry::getName()` (#68157)" on LLVM 18 trunk.
        (clang::SourceManager::getFileEntryRefForID exists since
        <https://github.com/llvm/llvm-project/commit/4dc5573acc0d2e7c59d8bac2543eb25cb4b32984>
        "Introduce FileEntryRef and use it when handling includes to report correct
        dependencies when the FileManager is reused across invocations" towards
        Clang 10, even when it changed its return type from Optional<FileEntryRef> to
        OptionalFileEntryRef along the way.)
        
        Change-Id: Ie37ba20c18f5ec33bab9ca2a96a9bcf722558c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160561
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [423ff918cdd2a470851298b49ae9b61d1b47b11a]

        symbolstore: update to python3
        
        Otherwise, it fails on new AlmaLinux 8 baseline
        
        rm -fr /home/buildslave/build/workdir/symbols/
        mkdir -p /home/buildslave/build/workdir/symbols/
        /home/buildslave/source/libo-core/bin/symbolstore.py /home/buildslave/build/workdir/UnpackedTarball/breakpad/src/tools/linux/dump_syms/dump_syms /home/buildslave/build/workdir/symbols/ /home/buildslave/build/instdir/program/*
        /usr/bin/env: 'python': No such file or directory
        make: *** [Makefile:478: symbols] Error 127
        
        Change-Id: I27a57a24a2f4bc7067041b2d4045ae0844e22d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160113
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-12-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [6c986c718630ab21e6d9b5d353ddf1534e2dda41]

        tdf#158421 use correct awt:Gradient2 in Chart lists
        
        Change-Id: I5fa02c2660d59981f540cde8bd6eaaaaddb30e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160463
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ece6c0eef5a6105541d378c09a10b1f0903882de]

        3D SW-Renderer: Add functionality to balance quality/speed
        
        For this purpose allow reduced 3D quality in some circumstances
        and make a compromize between quality and speed. This is
        balanced between those two targets, fine-tuning/experimenting
        can be done with some static local values if needed.
        
        Change-Id: Ib00b6e9c3c3ff165d82ff12d23bf15196f0a0ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160467
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-11  Miklos Vajna  <vmiklos@collabora.com>  [3db4228c59f8dbcf2143c24553d7c75cd0bf1e7a]

        svx: prefix members of SdrDragStat
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie3870e511a95c8b2862424cf538cebb0f5fce5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160558
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5e8c0575e877795aaca91346548cd0136fa22048]

        tdf#158472 - UI: Part 54 - Unify lockdown behavior of Options dialog
        
        for Calc - Print Page.
        
        Change-Id: Ie5ee611552185662f4a1081415a2c6493cf58301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160502
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9ed541b82ac32c38dad10410cab16b6763704af9]

        Resave with newer Glade version
        
        Change-Id: Ic95805c397b7a6e71d80d0f0c976e9c432238b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160501
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [67fcf1388976c11b1c0a688403e7323326a56e82]

        tdf#158471 - UI: Part 53 - Unify lockdown behavior of Options dialog
        
        for Calc - Compatibility Page.
        
        Change-Id: I43780c8b29de42a765b1d1110dbfe90efb173b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160499
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [befc51e1ada4a2662bf55fb7462e2a1031b42bbf]

        external/clucene: operation between different enumeration types
        
        > workdir/UnpackedTarball/clucene/src/core/CLucene/index/FieldsReader.cpp:233:58: error: invalid bitwise operation between different enumeration types ('lucene::document::Field::Store' and 'lucene::document::Field::Index')
        >   233 |                         f = _CLNEW LazyField(this, fi->name, Field::STORE_YES | getIndexType(fi, tokenize) | getTermVectorType(fi), length, pointer);
        >       |                                                              ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18 trunk
        since
        <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31>
        "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
        Enumerations (#73105)"
        
        Change-Id: I2d48298bc64e05271ee5c33255d7d57fed6221cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160549
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [27d72f286a3d5adfa6e448d050a9d9f06796e74f]

        external/libetonyek: operation between different enumeration types
        
        > IWORKDiscardContext.cpp:85:30: error: invalid bitwise operation between different enumeration types ('libetonyek::IWORKToken::Namespace' and 'libetonyek::IWORKToken::(unnamed enum at ./IWORKToken.h:25:1)')
        >    85 |   case IWORKToken::NS_URI_SF | IWORKToken::bezier :
        >       |        ~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
        
        etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
        trunk since
        <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31>
        "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
        Enumerations (#73105)"
        
        Change-Id: I28bfd1f90df048acea23d9fddd2010bcb537b251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160553
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [053c549fddff84d3f8e1d1a2962091fd5f69c662]

        external/libwps: operation between different enumeration types
        
        > MSWrite.cpp:1424:63: error: invalid arithmetic between different enumeration types ('MSWriteParserInternal::BitmapFileHeaderOffset' and 'MSWriteParserInternal::BitmapInfoHeaderV2Offset')
        >  1424 |         unsigned offset = MSWriteParserInternal::BM_FILE_STRUCT_SIZE + MSWriteParserInternal::BM_INFO_V2_STRUCT_SIZE + colors * unsigned(sizeof(MSWriteParserInternal::BitmapPalette));
        >       |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
        trunk since
        <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31>
        "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
        Enumerations (#73105)"
        
        Change-Id: I6307978bc39e0f965144e0df3ac9a28eb817fe10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160552
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cd13a572560ba22dadd8a5523b3aecd1aa0e050e]

        external/libebook: operation between different enumeration types
        
        > EBOOKDocument.cpp:150:37: error: invalid bitwise operation between different enumeration types ('libebook::EBOOKHTMLToken::(unnamed enum at ./EBOOKHTMLToken.h:21:1)' and 'libebook::EBOOKHTMLToken::Namespace')
        >   150 |           if ((EBOOKHTMLToken::html | EBOOKHTMLToken::NS_html) == getHTMLTokenId(name, uri))
        >       |                ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~
        
        etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
        trunk since
        <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31>
        "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
        Enumerations (#73105)"
        
        Change-Id: I799932d0dffec5e9345f29e14a2ee3f9a2add133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160551
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [fe99cac64957b364c75f09d9a92ccb4db4373604]

        external/graphite: operation between different enumeration types
        
        > workdir/UnpackedTarball/graphite/src/Pass.cpp:197:92: error: invalid arithmetic between different enumeration types ('status_t' and 'graphite2::errors')
        >   197 |                 || e.test(m_cPConstraint.status() != Code::loaded, m_cPConstraint.status() + E_CODEFAILURE))
        >       |                                                                    ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~
        
        etc. as reported now with --with-latest-c++ (i.e., in C++26 mode) by Clang 18
        trunk since
        <https://github.com/llvm/llvm-project/commit/1cbd52f791d3f088246526c0801634edb65cee31>
        "[Clang] Implement P2864R2 Remove Deprecated Arithmetic Conversion on
        Enumerations (#73105)"
        
        Change-Id: I34b2743d46b8f46b1f39b2af812f95876e4b9e38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160550
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [2b4094195eb89d9bfd41908cbb32a8b964efd9fe]

        Clean up SvStream API a bit
        
        Change-Id: Ic9847185e8f551eeb05715902374d7a9a9032f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160546
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-11  Matt K  <mattkse@gmail.com>  [90d732a5311551ae79969ee24d98cf21ffbacac7]

        tdf#117651 Fix AutoCorrect crash for italic, strike, bold, and underline
        
        This change fixes correction of indices when autocorrecting for one
        of the categories of bold, italic, strike, or underline.  Previously,
        the code would hit a debug assert when selecting "Apply" because of
        incorrect indices into the string being autocorrected.
        
        Change-Id: I5484c589ff43cd2fc78332cdc0d63e74cdc8e256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160547
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-11  Matt K  <mattkse@gmail.com>  [dc8b69e3393d4f71900ea871db5598a5f7af567e]

        tdf#117651 Fix AutoCorrect support for italic, strike, bold, and underline
        
        The previous change for italic had a "break" for "/", but it turns out
        that code path is hit when trying to "Apply" with slashes around
        some text, so we just move the "break" inside the check for French
        language handling.  Note that trying "Apply" with this change will
        crash on a debug build -- there is another fix for that problem
        in a subsequent change.
        
        Change-Id: I4bd76505b3fdfc9f5660eb6ae4a5c5c23e9672ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160529
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0024b7e392f72a16fcbcd0b65e3f590761c94fbe]

        Resave with newer Glade version
        
        Change-Id: I080b742ae6dcfa8a67ee90c7b611736121355806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160498
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [95e12eaebc00be5385e0abef2c5e70b7729af6f4]

        cid#1545789 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545791 COPY_INSTEAD_OF_MOVE
        cid#1545800 COPY_INSTEAD_OF_MOVE
        cid#1545806 COPY_INSTEAD_OF_MOVE
        cid#1545817 COPY_INSTEAD_OF_MOVE
        cid#1545832 COPY_INSTEAD_OF_MOVE
        cid#1545834 COPY_INSTEAD_OF_MOVE
        cid#1545841 COPY_INSTEAD_OF_MOVE
        cid#1545848 COPY_INSTEAD_OF_MOVE
        cid#1545852 COPY_INSTEAD_OF_MOVE
        cid#1545854 COPY_INSTEAD_OF_MOVE
        cid#1545864 COPY_INSTEAD_OF_MOVE
        cid#1545875 COPY_INSTEAD_OF_MOVE
        cid#1545882 COPY_INSTEAD_OF_MOVE
        cid#1545900 COPY_INSTEAD_OF_MOVE
        cid#1545901 COPY_INSTEAD_OF_MOVE
        cid#1545908 COPY_INSTEAD_OF_MOVE
        cid#1545921 COPY_INSTEAD_OF_MOVE
        cid#1546054 COPY_INSTEAD_OF_MOVE
        cid#1546145 COPY_INSTEAD_OF_MOVE
        cid#1546146 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8b23d0457cb293aa0e33593131224c1cdd1d8eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Patrick Luby  <plubius@libreoffice.org>  [9531f83cc73e26ce766713e575eb14152d118018]

        tdf#140401 check if attribute is a nullptr
        
        Change-Id: Ie6e33fc1dca525553bb4237204666835d335b13f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160524
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [b5526d4e95a465bee9fc810794570023f2a76ca5]

        Update Portuguese translation of ScriptForge
        
        Change-Id: Ic16b782d63e84581134f2238454aa9599819f146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160359
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [99c7a2a6a0bbc048204e2a2a5c013f79244c72ee]

        tdf#158469 - UI: Part 51 - Unify lockdown behavior of Options dialog
        
        for Calc - Sort Lists Page.
        
        Change-Id: I857b49caf8fa6823ae2582212885b317a34ff1df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160494
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9c923b5c7404c1597cc39ed0c81b13606e99308d]

        Resave with newer Glade version
        
        Change-Id: Ibf9a565587a5af02f6cb8ba9194e25d2f5b66c8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160493
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [60cb604efe742a69b0e701515324833e300043c1]

        tdf#158470 - UI: Part 52 - Unify lockdown behavior of Options dialog
        
        for Calc - Changes Page.
        
        Change-Id: I2d352915b2804411f0bbee62c967de77ad4bbba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160496
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [98b1eb2523a1bb5d1fd15fc06be7ec7a16f1eeab]

        Resave with newer Glade version
        
        Change-Id: I6bb6dbfe977987e592b87abc5e1f0f3dc4b789cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160495
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a6ead255af6efaede730a980c3a4a80ff193c8e5]

        tdf#158467 - UI: Part 50 - Unify lockdown behavior of Options dialog
        
        for Calc - Calculate Page.
        
        Change-Id: Ibe728e2ffc122879ee66abb88927be355d41348a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160462
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [283aa103b9aa40ef96b022420fdea69a6fdfe41c]

        cid#1545177 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545179 COPY_INSTEAD_OF_MOVE
        cid#1545187 COPY_INSTEAD_OF_MOVE
        cid#1545188 COPY_INSTEAD_OF_MOVE
        cid#1545189 COPY_INSTEAD_OF_MOVE
        cid#1545196 COPY_INSTEAD_OF_MOVE
        cid#1545197 COPY_INSTEAD_OF_MOVE
        cid#1545204 COPY_INSTEAD_OF_MOVE
        cid#1545223 COPY_INSTEAD_OF_MOVE
        cid#1545236 COPY_INSTEAD_OF_MOVE
        cid#1545239 COPY_INSTEAD_OF_MOVE
        cid#1545253 COPY_INSTEAD_OF_MOVE
        cid#1545274 COPY_INSTEAD_OF_MOVE
        cid#1545286 COPY_INSTEAD_OF_MOVE
        cid#1545309 COPY_INSTEAD_OF_MOVE
        cid#1545311 COPY_INSTEAD_OF_MOVE
        cid#1545345 COPY_INSTEAD_OF_MOVE
        cid#1545358 COPY_INSTEAD_OF_MOVE
        cid#1545361 COPY_INSTEAD_OF_MOVE
        cid#1545365 COPY_INSTEAD_OF_MOVE
        cid#1545367 COPY_INSTEAD_OF_MOVE
        cid#1545372 COPY_INSTEAD_OF_MOVE
        cid#1545373 COPY_INSTEAD_OF_MOVE
        cid#1545377 COPY_INSTEAD_OF_MOVE
        cid#1545392 COPY_INSTEAD_OF_MOVE
        cid#1545399 COPY_INSTEAD_OF_MOVE
        cid#1545404 COPY_INSTEAD_OF_MOVE
        cid#1545408 COPY_INSTEAD_OF_MOVE
        cid#1545430 COPY_INSTEAD_OF_MOVE
        cid#1545439 COPY_INSTEAD_OF_MOVE
        cid#1545449 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I3afe836a0bbc8bd70937035e60eb020435e413d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Laurent Balland  <laurent.balland@mailo.fr>  [7cfd3da36b54301fd51189282b39c71efd6bb894]

        tdf#158250 Blueprint Plans template: update images
        
        Contribution from Jérôme Bouat
        Replace pictures with grey level and indexed colours
        
        Change-Id: I5e253af65529d45b3c9ed2e30f6e2f018cbe03e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160532
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-10  Laurent Balland  <laurent.balland@mailo.fr>  [9168109f39a587a14c65b5b22103c909d6a6054e]

        tdf#158250 Yellow Idea template: replace pictures
        
        Contribution from Jérôme Bouat
        Replace pictures with grey level
        
        Change-Id: I933b20ad7b06d60e8039caaf8ce777bb52ce4225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160534
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-10  Laurent Balland  <laurent.balland@mailo.fr>  [b91d7649a6c2be19439b9c042ee9520c32e621e4]

        tdf#158250 Grey Elegant template: replace pictures
        
        Contribution from Jérôme Bouat
        Replace pictures with grey level
        
        Change-Id: If56958228085a77a61e867622a7a1a48e127745c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160535
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-10  Laurent Balland  <laurent.balland@mailo.fr>  [6fda99d874d73f93b51e483e29b85b69333acef9]

        tdf#158250 Vivid, Piano templates: replace pictures
        
        Contribution from Jérôme Bouat
        Replace pictures with grey level
        
        Change-Id: Ib8522871404261e81c25b50ac1ee073058e0dce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160533
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [d88d113c7de2681a0e88c276adc363c8f5a4ea8e]

        Simplify SvStream::WriteDouble
        
        Change-Id: I0ece791b5571d3839c936e104016f53cc3b6d5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160537
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [1d21ecc90cc14cc40ebee5de2f45fb6a8cb35c77]

        Use SvStream methods
        
        Change-Id: I11a98b32ab176c1e30480186123b21bc04b9500f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160536
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3f02996475aef76f4e4c7fbe1701534a154d3fe1]

        cid#1558174 Bad bit shift operation
        
        and
        
        cid#1558175 Bad bit shift operation
        
        Change-Id: I44d6f351716cf722abcd19ff866bc247ba9f5cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [b4fda935deaec67ccadf937d6a9604e60e0f51ea]

        Keep original error
        
        Fix several SetError implementations, to make sure that original
        errors are not rewritten, but OTOH warnings could be replaced by
        errors.
        
        Change-Id: Ic5e71b791ff3426ff1144778a610ab77fcbf24d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160530
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [884b294df69be608ef4ff73a7927118098266dfc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c487633e84637e8b71bb92001f16a2ff4051c11c
          - tdf#155876 UI cmds Calc-Sheet menu (28)
            
            + Sheet menu for Calc, delete row/column/breaks
            + refactoring
            
            Change-Id: I0905cfc84ccb9c2e914b4fdd65d4897e6f6f62f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160527
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [51bdf4039051366836b273435689e0fa1f794112]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 56d67dfd7ef0df8768ad2f4975333ad633cde27f
          - tdf#155876 UI cmds Calc-Sheet menu (27)
            
            + Sheet menu for Calc, insert row/column/breaks
            + refactoring
            
            Change-Id: Ie8ecd21877f960206616489e9113144bd37dd96a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160526
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3df8c3dd5aed8fc03b66526f9b42c44dcfb70d25]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4fd56ae1b229043b9fbcaf035cd19b0a4b5950af
          - tdf#155876 UI cmds Calc-Sheet menu (26)
            
            + Sheet menu for Calc
            + refactoring
            
            Change-Id: I227b221aa3093dd352a8801ea83b4558f35755ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160525
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d03dc3dfcede8f9b00cc9be4b0b1f25749a53c61]

        cid#1545912 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib3468b43015821225d0236fca5550392f69e1154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [15ff0c3828406aa00d8fa0d1e7de90916f9c13cc]

        cid#1545975 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545955 COPY_INSTEAD_OF_MOVE
        cid#1545954 COPY_INSTEAD_OF_MOVE
        cid#1545952 COPY_INSTEAD_OF_MOVE
        cid#1545948 COPY_INSTEAD_OF_MOVE
        cid#1545943 COPY_INSTEAD_OF_MOVE
        cid#1545935 COPY_INSTEAD_OF_MOVE
        cid#1545930 COPY_INSTEAD_OF_MOVE
        cid#1545928 COPY_INSTEAD_OF_MOVE
        cid#1545925 COPY_INSTEAD_OF_MOVE
        cid#1545922 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I28d830504337f417829c675b1eb9c763b83b30c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160522
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c2c815d853a626d4329a7e8a2e99671bdb38f44]

        cid#1545987 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: I34413f941aa5eded457ad5a3a5ffb4c9e1104590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160521
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5d3d7cd6568340cb6bd6243c8e0d73f4bc4fd5ed]

        cid#1546281 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546278 COPY_INSTEAD_OF_MOVE
        cid#1546276 COPY_INSTEAD_OF_MOVE
        cid#1546247 COPY_INSTEAD_OF_MOVE
        cid#1546244 COPY_INSTEAD_OF_MOVE
        cid#1546243 COPY_INSTEAD_OF_MOVE
        cid#1546220 COPY_INSTEAD_OF_MOVE
        cid#1546209 COPY_INSTEAD_OF_MOVE
        cid#1546207 COPY_INSTEAD_OF_MOVE
        cid#1546206 COPY_INSTEAD_OF_MOVE
        cid#1546205 COPY_INSTEAD_OF_MOVE
        cid#1546197 COPY_INSTEAD_OF_MOVE
        cid#1546180 COPY_INSTEAD_OF_MOVE
        cid#1546172 COPY_INSTEAD_OF_MOVE
        cid#1546165 COPY_INSTEAD_OF_MOVE
        cid#1546164 COPY_INSTEAD_OF_MOVE
        cid#1546158 COPY_INSTEAD_OF_MOVE
        cid#1546151 COPY_INSTEAD_OF_MOVE
        cid#1546135 COPY_INSTEAD_OF_MOVE
        cid#1546132 COPY_INSTEAD_OF_MOVE
        cid#1546129 COPY_INSTEAD_OF_MOVE
        cid#1546128 COPY_INSTEAD_OF_MOVE
        cid#1546122 COPY_INSTEAD_OF_MOVE
        cid#1546117 COPY_INSTEAD_OF_MOVE
        cid#1546113 COPY_INSTEAD_OF_MOVE
        cid#1546106 COPY_INSTEAD_OF_MOVE
        cid#1546099 COPY_INSTEAD_OF_MOVE
        cid#1546091 COPY_INSTEAD_OF_MOVE
        cid#1546085 COPY_INSTEAD_OF_MOVE
        cid#1546069 COPY_INSTEAD_OF_MOVE
        cid#1546063 COPY_INSTEAD_OF_MOVE
        cid#1546062 COPY_INSTEAD_OF_MOVE
        cid#1546058 COPY_INSTEAD_OF_MOVE
        cid#1546056 COPY_INSTEAD_OF_MOVE
        cid#1546051 COPY_INSTEAD_OF_MOVE
        cid#1546040 COPY_INSTEAD_OF_MOVE
        cid#1546030 COPY_INSTEAD_OF_MOVE
        cid#1546028 COPY_INSTEAD_OF_MOVE
        cid#1546015 COPY_INSTEAD_OF_MOVE
        cid#1546001 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ib954c92a300fc323b29f27880fdf8bc46ed98862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160520
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0afed1a48158cfc088b9cb60e609dac5515166fa]

        cid#1546285 this copy is dead-code
        
        since:
        
        commit 9be3c3724cd0dd2409ac1ebba88d30e04127272c
        Date:   Mon Aug 17 17:34:28 2009 +0000
        
            #i92516# handle pageoffset in vcl instead of application
        
        Change-Id: I9548d15d57284a2d826239de57d0d1650bac4b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [936fa218ddff67643b4daa6b6b746ac3bc897f06]

        cid#1546298 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546297 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8fbb2bb1692cc822a79652312c6268379226a9c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160517
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-10  Sahil  <me.sahilgautam@gmail.com>  [6e712d5bfaf8b14aacddf903d616447ef22e14f7]

        tdf#33210 Directly call the method, as it is inherited
        
        ScTabViewShell inherits ScTabView, therefore HighlightOverlay()
        can directly be called from ScTabViewShell instance.
        
        Change-Id: I3804ee2fd8598a338bbafe01df7756190ade660c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159365
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-10  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [9bc8918cf00b99f6c4a8f1e3f082e5583a4cd02c]

        add explainer for the reasoning of fMaxPassStrengthEntropyBits
        
        also fixes the typo in the fMaxPassStrengthEntropyBits variable name.
        
        Change-Id: I7c9cfcea7253a3e07428c83008b0c072033f33c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160425
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-12-10  Rene Engelhard  <rene@rene-engelhard.de>  [94d0cf4d4e308627922c4afb5e38523ea4f6af37]

        add missing #if MORE_FONTS
        
        since it nededs Source Han Sans since 9b5964cf5931d7c09e4fd624d68595891c2afb58
        
        Change-Id: I35bd30048b298e8cbdaf6de22ae2022d51415aa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160512
        Tested-by: Jenkins
        Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
        Reviewed-by: René Engelhard <rene@debian.org>

2023-12-10  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [6fa6599963fb7d5ba411540b181c581bbbeb1e9d]

        Remove hard limit to c89 for clang
        
        This seems no longer true: "Windows MSVC only supports C90 so force gnu89"
        
        With that said, also do a revert:
         "external/libeot internally uses --std=c99, do not overrule that"
        
         This reverts commit 61a66b612eaeeb38d5d9f9aa83326be6b08c1b6f.
        
        Change-Id: Id628131b4fa6b61e19da6d862d773ab36f201729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160454
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-09  Patrick Luby  <plubius@libreoffice.org>  [f7e81a321bc3e4880fc652e7ba24867bba557007]

        tdf#158461 eliminate flicker during live resizing
        
        When using Skia/Metal, the window content will flicker while
        live resizing a window if we don't send a paint event.
        
        Change-Id: Ib3edc497e26e6abfdfd17a34f9269a3eae090805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160519
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46b4a5a76816ea8646b726126c3935ebea870180]

        cid#1546300 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: I304f0a9b1f90b77b56c6782bea293075ab9effe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160516
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a58c0d4cefe4de132af32d910ec797a2efb3ee3a]

        cid#1556778 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546474 COPY_INSTEAD_OF_MOVE
        cid#1546473 COPY_INSTEAD_OF_MOVE
        cid#1546469 COPY_INSTEAD_OF_MOVE
        cid#1546467 COPY_INSTEAD_OF_MOVE
        cid#1546458 COPY_INSTEAD_OF_MOVE
        cid#1546448 COPY_INSTEAD_OF_MOVE
        cid#1546446 COPY_INSTEAD_OF_MOVE
        cid#1546441 COPY_INSTEAD_OF_MOVE
        cid#1546424 COPY_INSTEAD_OF_MOVE
        cid#1546377 COPY_INSTEAD_OF_MOVE
        cid#1546374 COPY_INSTEAD_OF_MOVE
        cid#1546352 COPY_INSTEAD_OF_MOVE
        cid#1546334 COPY_INSTEAD_OF_MOVE
        cid#1546328 COPY_INSTEAD_OF_MOVE
        cid#1546310 COPY_INSTEAD_OF_MOVE
        cid#1546303 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8a43fdd574857ba1d3ec416f23c8269a9a08e12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf3dda7c1c1da50db75d4c022bef279149d26636]

        cid#1546275 Using invalid iterator
        
        and
        
        cid#1545870 Using invalid iterator
        
        Change-Id: I7a517fd67d1100a2feebfd3903c1804a2dcc2992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160514
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9c22c643ffb6ec0d16b6998cf07d61867042b8b5]

        cid#1558833 Uninitialized scalar field
        
        Change-Id: I8c617c20f725f4277a0c4d637be336c6624c3238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160513
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-09  Eike Rathke  <erack@redhat.com>  [d48ad3187d82aca8d9c35c43698822865cad58a0]

        {bn-IN}{hi-IN} MM-DD-YY DATE_TIME is very likely wrong, all other are DD-MM-YY
        
        Wrong since its initial commit.
        
        Change-Id: I75214226ef5e1e58798ca0eaf396bad590918ee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160511
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [198035a18f28095b868f9e8ecc01c6b139e21896]

        Simplify a bit
        
        Change-Id: Ida8ab7b8e39f3847d58813ca93ae705bc19ac2e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160508
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [6aa07b9e2bca206150de7d5d048833cef31b882a]

        Listen to the needed subnode
        
        We don't need to know when other subnodes might change
        
        Change-Id: I9bd065a700e4d313acae1064af743a32a537c89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160507
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ecee3285eaeb6bf6ae6695a81cd80177439c73df]

        Fix checking for relevant change
        
        The event can contain multiple changes, and the wanted change may be
        not the first one. Additionally, now it's safe even if Changes would
        be empty (is this possible?).
        
        Change-Id: Icde844961a492bc02a6b9dd3d6ca04f57a5f4e94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-09  Eike Rathke  <erack@redhat.com>  [7b2166c8217cb32f2f7951f074e33d9fe890bb9b]

        Fix build --with-system-openssl but --without-system-curl
        
        Change-Id: I60e2e995a159ebbbdc0991204d765b5654d5a4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160510
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-12-09  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7ed0ba0555de892b348b14d4c5900ebcfb4ddd67]

        Fix Linux --enable-online-update-mar build
        
        ...after 13595f6220095d120e13ccb6fbfac1de4c803fe7 "Fix
        --enable-online-update-mar on Windows"
        
        Change-Id: I8e13a3f4234f3b5fb64d606eb3c2c16611dacd33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160491
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-09  Sahil  <me.sahilgautam@gmail.com>  [cad62803ba39c560a3e5bc3a51300cc1136b5afd]

        tdf#33210 Add Listener for ColumnRowHighlighting changes
        
        Listener updates Column/Row highlight if the expert
        configuration is changed
        
        Change-Id: Ibc220c4dd8f0b253029c7a0e54dd08f54f573114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160152
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a7596dd25a9738226bf2637999c61690d7dd659a]

        Resave with newer Glade version
        
        Change-Id: I8f140098d4818d46645fbf69703c80e389c1ac72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160461
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ebb2dff479556b0a8a855443c7bb9ff62b3f89f0]

        fix lcms2 build on Windows AARCH64 - missig output path option
        
        broke with e1473bc935b68147cb019572928e19a03f188f18 - the shipped config
        doesn't set the outdir for arm64 build, so the dll doesn't end up in the
        expected location.
        Note this only patches the 2019 config that is currently also hardcoded
        in the makefile
        
        Change-Id: I21e90cd15922bbe37b534b04362450e1f87662ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160497
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-09  Dr. David Alan Gilbert  <dave@treblig.org>  [abdb93ce28febd7c4b4e5dad164ee8a394b499b9]

        tdf#147021 Use std::span to avoid SAL_N_ELEMENTS in CustomShape
        
        as for previous set, this time for TextRectangles
        
        Again the data is mechanically search/replaced.
        
        Change-Id: I836a0c8384d08da6d8c05cfc6ef9f55c1c90fc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153885
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-09  Patrick Luby  <plubius@libreoffice.org>  [c92d01f82f3cbcb504a839cea5852e6c85a1d420]

        tdf#158379 check if PageDesc's m_pPSName is a nullptr
        
        Change-Id: If9f6d695d40c1d55ee2dfbdf1e3523b33343d7ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160504
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-09  Dr. David Alan Gilbert  <dave@treblig.org>  [4a49d7a3a98ccdca52ea0a4475d05235a111ec0a]

        tdf#147021 Use std::span to avoid SAL_N_ELEMENTS in CustomShape
        
        as for previous set, this time for Calculations.
        
        Again the size is mostly mechanical:
        
        In vim load into a:
        :+4,+4s/const_cast<SvxMSDffCalculationData\*>[(]\([^)]*\)[)],.*/o3tl::span<const SvxMSDffCalculatinoData>(\1),/
        :+4,+4s/nullptr, 0/o3tl::span<const SvxMSDffCalculationData>()
        
        and run
        :%g/^const mso_C.*=/@a
        (But has had some fixups after conversion from o3tl to std)
        
        Change-Id: I11cdfffdfb61678c173d3136a8e948fd0c224af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153884
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-09  Dr. David Alan Gilbert  <dave@treblig.org>  [82f30ac55a90a0f0915d4016c760c5c38db087f1]

        tdf#147021 Use std::span to avoid SAL_N_ELEMENTS in CustomShape
        
        as for previous set, this time the GluePoints.
        
        Again the size is mostly mechanical:
        
        In vim into the A register:
        :+9,+9s/const_cast<SvxMSDffVertPair\*>[(]\([^)]*\)[)],.*/o3tl::span<const SvxMSDffVertPair>(\1),/
        :+9,+9s/nullptr, 0/o3tl::span<const SvxMSDffVertPair>()
        
        and then:
        :%g/^const mso_C.*=/@a
        
        for the tables.
        (But has had some fixups since switching from o3tl to std)
        
        Change-Id: I966275caf38a6af469d334a0161053159e726f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153883
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b3122d56af5eefbb170de105579b59b097f34d58]

        Fix typos
        
        Change-Id: I9f61a7858a98ae6eb25cc49d237172876114c767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160503
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b391cc79ce5fc58988ec495642ca662da3d9f46]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 847d925a437f5a3c089978c7d0b8f175a1a19176
          - tdf#155876 UI cmds Calc-Format menu (25)
            
            + Style menu for Calc
            + refactoring
            
            Change-Id: Iff39af1811013b12f6d46aebc77fbf9f8b652a4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160449
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [5829cf7e96d3b2fcbc91b9c5c15438202629bc03]

        configure: Pass '--auto-servernum' to xvfb-run here, too
        
        Pass that param in configure.ac as well, to avoid multiple
        instances of xvfb-run potentially getting into each other's
        way.
        
        See the commit message of
        
            commit ca01deadcbc480b6e79618b227a2b73a61ecb7ff
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Oct 16 11:03:46 2023 +0200
        
                gtk3 a11y test: Let xvfb-run auto-determine free server num
        
        for more details, which added that param at the place where
        the tests using xvfb-run are run.
        
        Maybe this has a positive effect on occasional test failures like [1]:
        
            checking for xvfb-run... /usr/bin/xvfb-run
            checking whether /usr/bin/xvfb-run works...... no
        
            configure: error: xvfb-run required by --enable-atspi-tests not found
        
            Error running configure at ./autogen.sh line 321.
        
        [1] https://ci.libreoffice.org/job/gerrit_linux_gcc_release/154929/console
        
        Change-Id: Ie7ba6ec58ea44e5cf8a52d18f0359d3c2335a4ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160466
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [5100fb1c0ebadf936bc86b60cb8870095003e8ce]

        wina11y: Hold AccObjectWinManager by ref, not ptr
        
        Inspired by
        
            commit 0a2622760a967e9d64cfdc632548dd42c1836324
            Date:   Wed Nov 8 13:54:14 2023 +0100
        
                Drop presumably redundant null check
        
        Change-Id: Icb2bfb83ebf4146eb3091a6021ecac75aa6626b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160464
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-08  Dr. David Alan Gilbert  <dave@treblig.org>  [9924561a094f1b3b2b78700bd1f1638d9608f881]

        tdf#147021 Use std::span to avoid SAL_N_ELEMENTS in CustomShape
        
        EnhancedCustomShapeGeometry has a set of predefined shapes
        defined with classic arrays and each is used in a structure
        initialisation like:
        
         const mso_CustomShape msoArc =
         {
        -    const_cast<SvxMSDffVertPair*>(mso_sptArcVert), SAL_N_ELEMENTS( mso_sptArcVert ),
        
        by using a span we can turn that into:
        +    std::span<const SvxMSDffVertPair>(mso_sptArcVert),
        
        There's potential to get rid of some numbered loops later as well.
        
        The patch is large mostly because of mechanical replacement
        Loading EnhancedCustomShapeGeometry.cxx into vim then:
        
        into register A put:
        :+2,+2s/const_cast<SvxMSDffVertPair\*>[(]\([^)]*\)[)],.*/o3tl::span<const SvxMSDffVertPair>(\1),/
        
        and do:
        :%g/^const mso_C.*=/@a
        
        (since fixed up to std:: )
        Change-Id: Ia670b6aa7cc9f662650de2af76ee271a4469f1f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153882
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-12-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9fb3970a1a599eae2447f6746597843434ee758b]

        bump product version to 24.8.0.0.alpha0+
        
        Change-Id: If1f03b745fa3855daf18ddc531a0bf7d949d21a7

2023-12-08  Patrick Luby  <plubius@libreoffice.org>  [898d5d470e24a55556f2fb244fec24df33ba8855]

        Revert "Related: tdf#155266 force flush after drawing native scrollbars"
        
        This reverts commit 5ff701226b00963312cb2a78e77966d012b79c82.
        
        Reason for revert: Tester reports no change in behavior after the commit.
        
        Change-Id: Ic6d9f4834c7c6e3fae34d132298b335f433df280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160470
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-08  László Németh  <nemeth@numbertext.org>  [326660093c903427285cfebaef12ecab1236b2db]

        tdf#129357 editeng: show soft hyphen in text boxes and shapes
        
        Shapes and text boxes didn't show the optional hyphen
        at line break.
        
        Change-Id: I5cc842964fc91571e5c55995981de697da966b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160453
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-12-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [08444c707133bac7f5581fe6b6da3cc7eea656fc]

        Update git submodules
        
        * Update translations from branch 'master'
          to a0c2cb43becec95fddd09ed6300525a735b4ba95
          - update translations for master/24.2.0 Beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Ib7130fc4085faf604d249a62ae42e92019f69cf0
            
2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [55124c3dbde79ce35e0c90c0d8271117f59b93ce]

        Related: tdf#156379 better align the doc statistics selectable labels
        
        Change-Id: I4b8270ac38ad4a4a4919be48bed717d68101466d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160457
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [416c6093ac7ac2a15632d5aef44b23525f63c73b]

        resave with latest glade
        
        Change-Id: Ieec096149d581e523cbd54e1ec9e97b8eab92785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4fe46c0c2826a46ba66349c4e2b1653f535943f]

        use same formatting for "Lines" as the other numbers in doc statistics
        
        Change-Id: I16991ceab68a33f154975e47145f50795ddfbcc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160455
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [29df1afa1f439bf44a6be1b04ec0190e8f40abe2]

        tdf#43157 vcl: remove DBG_ASSERT() from DrawDeviceAlphaBitmapSlowPath()
        
        Change-Id: I6c120eb2bb8999276103f50bf3679366b6ee86ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157189
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [5ff64bfcf9bb8c27670c4cb44a778105008407ed]

        fontconfig android: Drop obsolete patch for API level < 21
        
        Now that the minimum SDK version/API level has been bumped
        to 21 in
        
            Change-Id: I875e784dd4e62993f51059ae6a280d425cb49c0a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Dec 5 09:57:22 2023 +0100
        
                android: Bump minSdkVersion to 21 (Android 5.0)
        
        , this patch is no longer needed.
        
        Change-Id: I391657caac76ed5b66f564a5888a35b5afb16ed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160335
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-08  Michael Weghorn  <m.weghorn@posteo.de>  [c2fc2c8c7c63ca4e43bca6e8c9b82c50418422d2]

        android: Bump minSdkVersion to 21 (Android 5.0)
        
        NDK 26 dropped support for API levels < 21 [1] [2].
        Do the same for our Android build, to ease the
        maintenance.
        
        Adapt configure.ac accordingly and drop the
        now obsolete code paths in Android Viewer
        Java code.
        
        This in also means that the same minSdkVersion will
        be used for all architectures now, while API level 21
        was already used for the 64-bit variants (for which
        the minimum supported version was 21 anyway) and
        API level 19 was used for x86 and 32-bit ARM when
        building with NDK 24/25, API level 16 when building
        with NDK 23.
        
        According to [1] and [3], more than 99% of
        Android devices have at least Android version 5,
        i.e. support API level 21.
        
        [1] https://github.com/android/ndk/issues/1751
        [2] https://developer.android.com/ndk/downloads/revision_history
        [3] https://apilevels.com/
        
        Change-Id: I875e784dd4e62993f51059ae6a280d425cb49c0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160334
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [99f91d64c57f4e2bfe47fe4d0870b92c269fa875]

        tdf#156379 Fix Line count width in the Properties dialog
        
        In Writer, the "Lines" property in File - Properties - Statistics does not have enough width to handle numbers with 4 digits or more.
        
        This patch fixes the issue by adjusting the label width when it is updated.
        
        Change-Id: I1a56da106f7c80ffbbaa8bdfb93932a3974b1ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160367
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [13595f6220095d120e13ccb6fbfac1de4c803fe7]

        Fix --enable-online-update-mar on Windows
        
        The code had apparently rotten a bit,
        
        * a wchar_t vs. char16_t confusion in desktop/source/app/updater.cxx
        
        * code broken by 926e4e469d0285ee72f8da80f00370b4b3120417 "Rename online updater
          functions and strcmp relpath" in
          onlineupdate/source/update/updater/updater.cxx
        
        * -DUNICODE missing in some places (so that plain Windows functions resolve to
          the ...W variant), which had been set centrally in the past IIRC
        
        * silencing some warnings like "C4267: 'initializing': conversion from 'size_t'
          to 'int', possible loss of data" (where silencing is the right thing to do for
          effectively extern code); no sure why those apparently didn't hit in the past,
          maybe it is all warnings that compilers only started to emit in recent years,
          or only for recent -std:c++... modes
        
        * silencing some "Conversion from string literal loses const qualifier" errors
          with -Zc:strictStrings-; these hit at least with recent VS 2022 Preview and
          --with-latest-c++, where -Zc:strictStrings is apparently now on by default
        
        Change-Id: I7fe46f5aa2b42fc9c03f24f7f0236512b4d3b936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160451
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0e438eaceb47932e61b9223e048e4eda3ed7636]

        tdf#158577 Allow locking down adding new trusted authors
        
        regression from
            commit 6ed8c5a0f19901ab413c6610649326b2475c3a8c
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Jul 25 21:35:05 2021 +0200
            use officecfg for security options
        
        where I forgot to go back and complete a piece that was initially
        a little tricky.
        
        Change-Id: I2df8529ec7047bdcd9d7f655303fd72eeaa50cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160429
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb18b12953c8ad9d58af82f779be1046fea77834]

        cid#1545617 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1545748 COPY_INSTEAD_OF_MOVE
        cid#1545741 COPY_INSTEAD_OF_MOVE
        cid#1545698 COPY_INSTEAD_OF_MOVE
        cid#1545594 COPY_INSTEAD_OF_MOVE
        cid#1545588 COPY_INSTEAD_OF_MOVE
        cid#1545558 COPY_INSTEAD_OF_MOVE
        cid#1545545 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5dfec77a68959b9384fc71a2fc0908c5d1b42869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59ebafbce2faca19526ddbdd6645e48c2fc653c2]

        cid#1545692 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic0679eccd7cc781fb799b15fbb2660fcbd1445f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160447
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [73038ec8263b7e16e6a4dede4cbc1732d47dd2eb]

        cid#1545764 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I5636f571b6c157b5b23d453d39f2c43eedc2e2a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160446
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d01186dcef85b0515e51478bf7340268e0b147a]

        cid#1546472 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546459 COPY_INSTEAD_OF_MOVE
        cid#1546452 COPY_INSTEAD_OF_MOVE
        cid#1546403 COPY_INSTEAD_OF_MOVE
        cid#1546396 COPY_INSTEAD_OF_MOVE
        cid#1546394 COPY_INSTEAD_OF_MOVE
        cid#1546338 COPY_INSTEAD_OF_MOVE
        cid#1546324 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If61457cfaf1d7ce4a069bcecdc0cc657aeb43c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6c91e703354c545e3885a162b47139ade4caae6c]

        cid#1546475 std::swap COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic5325a85deb370db2091e5ce5209b6408a8652bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [950d8b640aa078a8c8fe615b919be809e5da6ee0]

        cid#1546501 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546486 COPY_INSTEAD_OF_MOVE
        cid#1546485 COPY_INSTEAD_OF_MOVE
        cid#1546484 COPY_INSTEAD_OF_MOVE
        cid#1546482 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I53cc622f16afc0f57ffd72e3e0a6f18e390fbb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160443
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-08  Michael Stahl  <michael.stahl@allotropia.de>  [2f12d5bb9c97f4f7b46c5a511b71cd670c9c7102]

        xmlsecurity: deploy asserts in OCipherContext
        
        Missed a special case in previous commit, in case the input is
        completely empty and PK11_DigestFinal() doesn't see a problem with it,
        aResult could be empty too.
        
        Change-Id: I8ea900774ae390857307ec5bab38876bead6bc86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160441
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [cb099da3923ae2e6cca70a73049f79e55f808d47]

        tdf#158466 - UI: Part 49 - Unify lockdown behavior of Options dialog
        
        for Calc - View Page.
        
        Change-Id: I75fcb41b82c4946812d27dd364ffef8eb3086c0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160439
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-08  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [ad6ba4a3a63a25c5b9043bb5d0b178411b3eb714]

        external/libnumbertext: Silence -Werror,-Wdeprecated-declarations
        
        ...when building against LLVM 18 trunk libc++,
        
        > In file included from Numbertext.cxx:6:
        > ~/llvm/inst/bin/../include/c++/v1/locale:3772:1: error: 'wstring_convert<std::codecvt_utf8<wchar_t>>' is deprecated [-Werror,-Wdeprecated-declarations]
        >  3772 | wstring_convert<_Codecvt, _Elem, _WideAlloc, _ByteAlloc>::
        >       | ^
        > ~/llvm/inst/bin/../include/c++/v1/locale:3649:17: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here
        >  3649 |         {return to_bytes(__wstr.data(), __wstr.data() + __wstr.size());}
        >       |                 ^
        > Numbertext.cxx:164:22: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here
        >   164 |     return converter.to_bytes( s );
        >       |                      ^
        > ~/llvm/inst/bin/../include/c++/v1/locale:3591:28: note: 'wstring_convert<std::codecvt_utf8<wchar_t>>' has been explicitly marked deprecated here
        >  3591 | class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 wstring_convert
        >       |                            ^
        > ~/llvm/inst/bin/../include/c++/v1/__config:942:41: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
        >   942 | #    define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
        >       |                                         ^
        > ~/llvm/inst/bin/../include/c++/v1/__config:915:49: note: expanded from macro '_LIBCPP_DEPRECATED'
        >   915 | #      define _LIBCPP_DEPRECATED __attribute__((__deprecated__))
        >       |                                                 ^
        
        (The warning is apparently only emitted late during compilation when
        instantiating template code, so extending the existing `#pragma GCC diagnostic
        push/pop` area did not work, and the `#pragma GCC diagnostic ignored` rather had
        to be enabled all through to the end of the TU.)
        
        Change-Id: Iffc1c468426407e3252724d18f358b9923f7f733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160437
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a010567c2cdb8ea0fe059b0b64fd5d1f2fd99a03]

        tdf#126084 document OOXML SVG tests and import
        
        Change-Id: Ief29d04f2f0693a4cdfa44c7c100ac6164da38f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160378
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-08  Kira Tubo  <kira.tubo@gmail.com>  [7081b28dd6ed1ab8b8d6528d94e44e5dc3b3121d]

        tdf#143148 Use pragma once instead of include guards
        
        Replace include guards with #pragma once
        
        Change-Id: Id7378d6cf43817a8501a314dd8614467fb10e33a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160417
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [31e6767d433eaec7dd4d72b5568015a8df3feec5]

        Remove duplicated include
        
        Change-Id: I9c0f1e9188c731077f57b6adaf8208bc8c84d829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160438
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-07  Patrick Luby  <plubius@libreoffice.org>  [5ff701226b00963312cb2a78e77966d012b79c82]

        Related: tdf#155266 force flush after drawing native scrollbars
        
        When scrolling on some Intel Macs either via dragging
        the scrollbar thumb or via swiping the trackpad with two
        fingers, final repaint of scrollbars doesn't appear to
        get flushed to the screen. It appears that scrollbars
        aren't updated and repainted until after a batch of
        native scroll events have been dispatched. On slower
        machines, this lag is long enough that any pending
        forced flushes have already been done so when the timer
        that repaints scrollbars finally fires, the repainted
        scrollbars won't get flushed to the native window until
        the next normal flush which may not occur until seconds
        later.
        
        Change-Id: Iadef6812cd2495a28347560caae81f604c908b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160440
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [573f61fdb06e0824d0800dc16005c496f3c2d58f]

        update credits
        
        Change-Id: I6bb7de64be70c68362169ae459cffa37478395b1

2023-12-07  Michael Stahl  <michael.stahl@allotropia.de>  [328b135f0decbab475c16560f4b366559f2d0e66]

        xmlsecurity: check for errors in OCipherContext::Create()
        
        If this function returns null, storing a document will proceed without
        reporting an error to the user, and lose all the data.
        
        Change-Id: I0f9fd53702321e7997b28e12eb5bed3349bbcc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160435
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1c93df52e522f4055fa7b4dd5de3c13fa9dc52d9]

        Update git submodules
        
        * Update translations from branch 'master'
          to 193b35fe99d7112b6a2b9c8077bbca6471326db3
          - update translations for master/24.2.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Ie89030ffdc21fe71f753b07ea11bbf838e91417c
            
2023-12-07  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8a2820193315e8f56a041153ca5578ce7bdcb832]

        tdf#158576 Require viewing the certificate
        
        before adding it to the list of trusted certificates.
        
        This prevents certificates from being thoughtlessly
        added to the list of trusted certificates.
        
        Change-Id: Ifd0273df39f13432ebad72f1289ede0e6e7a8d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160427
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [f47ad18cbac928d3ee2511fe4fb25ed61240feb0]

        tdf#158223: chart2_uichart: Add unittest
        
        Change-Id: I11e20682155c524fcc119701111f5bc91f6beed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160404
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [12b96aca8666bca5bf905c8c9da44a20e0c06ef3]

        cid#1546503 Using invalid iterator
        
        and
        
        cid#1546284 Using invalid iterator
        cid#1546275 Using invalid iterator
        cid#1546049 Using invalid iterator
        cid#1545929 Using invalid iterator
        cid#1545870 Using invalid iterator
        cid#1545668 Using invalid iterator
        cid#1545420 Using invalid iterator
        
        Change-Id: I3ad3000631b4be5917b9c5f49f21b8cc003a309c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159056
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-07  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [caea33a11a212fc1c0426c90715c06376dbb9f06]

        Turn on MAR-based updater for Win64
        
        But make it default-off for the while.
        
        Change-Id: I54e2fb8544ceb5ffe88053504294e2f3d5df50d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160436
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-07  Michael Stahl  <michael.stahl@allotropia.de>  [c218b7eab57625a256023e82e2f77a6c3d18fe46]

        xmlsecurity: W3C padding max size is the block size
        
        Change-Id: I90c48aafd11deb2895d01c90764fc433a9161e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160434
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-07  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e89c2a5ae15247469f67ed2b716b54a0041a2aea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95ebe8994002023b90215765f0d0cbd946a25f89
          - rows are shown by clicking on rows headers
            
            Change-Id: I34ac6fd200964eac8bd83d4b49694a45480095de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160403
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b36a8a532b3ee6521d80277cb32a6936c0b09320]

        busy loop seen on ods export attempt
        
        ScXMLExport::ExportFormatRanges cannot advance because nMaxCols is 0
        so busy loop and no progression
        
        In ScRowFormatRanges::GetMaxRows, aRowFormatRanges is empty which is why
        nMaxCols is 0
        
        In ScFormatRangeStyles::GetFormatRanges aTables appears to be 30 empty
        items.
        
        But why it is empty can't be seen from the bt.
        
        Force this to be an assert to ensure crashtesting can flush out this
        case, rather than letting it get killed off as a timeout.
        
        Set this case as an error and break so failure results in an error
        message of failure to save instead of a hang.
        
        Change-Id: I827e1e638cddd976a48340f86741c21075afe856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-07  Laurent Balland  <laurent.balland@mailo.fr>  [0b504bb12e4d563d1505e9c2039cbbd723cf1162]

        tdf#158500 missing style Object with no fill no line
        
        Style "Object with no fill no line" was not correctly treated during
        automatic translation to UI language
        
        Change-Id: I9364b25e326387110af81494d7fa5e4c05b5f972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160262
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [83cc8ef8f8a459ca7a793acb220f4496b6e6af1a]

        [API CHANGE] Drop unused SnapGrid/[X,Y]Axis config groups
        
        from Impress/Draw
        
        last mention of them was removed in 2006 by:
        commit deef3fdfd9148ce1987b35a224998d63bb6b9d56
        
        removing a commented out caller
        that was already commented out by "initial import" time
        
        Change-Id: I50fefe42a92c752727dfbf3b9d7c645492d034da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160190
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-07  Laurent Balland  <laurent.balland@mailo.fr>  [c805fac1715e4955708299334e95d0dff47e32d7]

        tdf#158250 Candy Impress template: replace picture
        
        Contribution from Jérôme Bouat
        Replace 24 bits color picture by 8 bits color picture
        
        Change-Id: If4f2f3a75f475a9dc0b43be4e0e8afdb98a0eaa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160256
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5d2c5b09c9e7940b2285180b42e6e574063b693e]

        GUI to en-/disable the --enable-online-update-mar feature at runtime
        
        ...sharing the existing option tab page for the traditional
        --enable-online-update feature
        
        Change-Id: Ic7b04bf15bf841a46a96d62cf5a857deaa399428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160430
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-07  Alain Romedenne  <alain.romedenne@libreoffice.org>  [a7af3df52876f7fd463aef744083242cce07c001]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e14d56e82ecb749cbb965dfaca447c72d9a3ca04
          - sf_toc updates
            
            - Old missing properties
            - New properties
            
            Change-Id: I7e95dcf99917bfddc7c478e7ff068f3adad190d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160364
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-12-07  Alain Romedenne  <alain.romedenne@libreoffice.org>  [5935620f27276aa86fbc4886379bb9ca50431da7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77f51afc9223e752950b42306385cbbcbdf24473
          - ScriptForge (SF_Document) new XDocumentSettings property + Styles management + Toolbars
            
            Change-Id: I3c9b979a26a44aadb8dff0ab18122e1fb32ccb2a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158903
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-12-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ea0f4d74143a8109c7c118eb4e5b4bfa611b6a21]

        tdf#158465 - UI: Part 48 - Unify lockdown behavior of Options dialog
        
        for Calc - Defaults Page.
        
        Change-Id: I813469c6e56f0bd148afb17644853116e4ae0398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160419
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-07  Jim Raykowski  <raykowj@gmail.com>  [c58efbfce1ca80942a731881cf82ea0367edc579]

        use std::erase_if instead of std::remove_if + std::erase
        
        Change-Id: Ib505c89d224c9d8418ff3b1138f26d3d6e576120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160406
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b17d051ad56ab706d15a3b696266be1ac1df2e5d]

        Make --enable-online-update and --enable-online-update=mar orthogonal
        
        ...by turning the latter into its own option --enable-online-update-mar.  (The
        intention is to potentially have the experimental --enable-online-update-mar
        configured in alongside any traditional --enable-online-update, and have it
        disabled by default at runtime---for which some configuration is needed and
        which is forthcoming.)
        
        Change-Id: Id53b4f52b310da472b305c8b23c1e2ba1931296d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160424
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [308d822bf6b277bb7844b2f142fac501ac71a1e9]

        Resave with newer Glade version
        
        Change-Id: I252b2a2a51a12463fb2ffc764c2531ac8d5f723c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160418
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [8d3ac3968e31d8d804d72d39a9387f225d30d087]

        tdf#158375: add expert option to disable active content
        
        adds new expert option DisableActiveContent
        
        Right now only disables active embedded content / OLE.
        
        If OLE content is being imported via
        UNOEmbeddedObjectCreator::createInstanceInitFromEntry with the
        expert option DisableActiveContent set, the imported OLE object is
        now forced to be ODummyEmbeddedObject.
        
        ODummyEmbeddedObject doesn't implement any other state then
        embed::EmbedStates::LOADED (i.e. doesn't implement RUNNING,
        ACTIVE etc.) which makes it possible to prevent the imported OLE
        object becoming active.
        
        The functions that now throw lang::NoSuchElementException are
        usually called on new creation of embedded content via UI. But
        since the call sites expect the possibility of embedded content
        failing to initialize, that is handled by showing a popup stating
        some form of `unable to insert`.
        
        A follow-up improvement of disabling insertion of OLE content via
        dialogs could be implemented.
        
        Change-Id: Ib558a2a129b491798f5036a7bb269116545be75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160402
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bfbae5ddd52cf80af94b250b9de349f0340dbe34]

        cid#1558798 Unchecked return value
        
        Change-Id: Iddb702f40ced018c104a8a42847bc396ba258ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49d88e99a20f0c746beddc713c03289d5c64546a]

        cid#1545320 Unused value
        
        Change-Id: I772a5d7608b92634b7cfed1c1e1730eab34bee89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-07  Sahil  <me.sahilgautam@gmail.com>  [0e942c11e074244224a9968046da105dc62656e8]

        tdf#33201 Move Cell position logic inside the function
        
        Previously to Highlight some cell's row/column, one had to
        get the current cell cursor position, and pass it to HighlightOverlay(),
        but now that is not required.
        
        Change-Id: I4d08bf1fa84fcbd4820fd166c1d137bd3d950413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160151
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-07  Noel Grandin  <noelgrandin@gmail.com>  [a214ac677481883d31800bc2b67fd3a9c504319d]

        simplify and modernise ScopedBitmapAccess
        
        (*) Make all of it use a "Scoped" paradigm
        (*) pass by value, no need to allocate on heap
        (*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods.
        (*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places.
        
        Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-07  Michael Stahl  <michael.stahl@allotropia.de>  [7101c620857cb885076b85cd1447e50d30cab528]

        sfx2: simplify SetCommonStorageEncryptionData() calls
        
        Some of these look redundant, as SfxMedium::GetStorage() already does
        this earlier.
        
        Change-Id: Iba178196898adfd4ee260da908c7298f3f2c1734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160408
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-07  Michael Stahl  <michael.stahl@allotropia.de>  [3b347664b26d58d44f685a607a5e6d10dff89cd4]

        tdf#105844 package,sfx2: wholesome ODF package wrapping encryption
        
        Redo the ODF encryption by storing an ODF package and wrapping it as a
        stream "encrypted-package" in another ODF package, such that there is
        only one encrypted stream - this requires only one KDF computation.
        
        * This is only enabled in Experimental mode for now.
        
        * Avoid storing unencrypted data in the pTempFile of SfxMedium, as it
          is usually created in the same directory as the target file, which
          may be on a network share or similar less trusted location.
        
        * SfxMedium::SetEncryptionDataToStorage_Impl() should just set an
          error status if it fails (how can it fail anyway)
        
        * when loading a document, SfxDocPasswordVerifier extracts an encrypted
          inner package (by calling SfxMedium::TryEncryptedInnerPackage())
        
        * SfxMedium::GetStorage() automatically decrypts an encrypted inner
          storage and sets it as the SfxMedium's xStorage
        
        * when storing a document, SfxObjectShell::SaveTo_Impl() creates
          the wrapped storages
        
        * One challenge is to keep the macro/scripting signature working; this
          can only be put in the inner storage, whereas the document signature
          should continue to be on the outer storage; also it must use a Zip
          storage, to see the "META-INF" directory.  This needs a new
          SfxMedium::GetScriptingStorageToSign_Impl() and changes in
          SfxMedium::SignContents_Impl().
        
        Change-Id: Ibfee36ce3a9cd030f2aa2ce1484b6d001cba2389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160401
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-07  Michael Stahl  <michael.stahl@allotropia.de>  [f6536f4db61b73cf7fd4a44bb5ba61eff61f8f91]

        some cosmetic improvements, better warnings
        
        Change-Id: I05a7eeb74088c278aab94519c7f53b0482e38058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160400
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-12-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [0f32809a86630d9e8bbf46fef23e189896c8a497]

        Adapt consteval failure check to recent GCC 14 trunk
        
        ...which happens to accept the original check from
        af34108d90bbbce90cf00c4b23961787599c7fa5 "Use C++20 consteval for the
        Color(sal_uInt32) ctor" now, but would still fail to compile the actual code at
        
        > In file included from xmloff/source/chart/ColorPropertySet.hxx:23,
        >                  from xmloff/source/chart/ColorPropertySet.cxx:20:
        > include/tools/color.hxx: In constructor ‘xmloff::chart::ColorPropertySet::ColorPropertySet(Color)’:
        > xmloff/source/chart/ColorPropertySet.cxx:81:9:   in ‘constexpr’ expansion of ‘((xmloff::chart::ColorPropertySet*)this)->xmloff::chart::ColorPropertySet::m_nDefaultColor.Color::Color(10079487)’
        > include/tools/color.hxx:82:11: error: modification of ‘*(xmloff::chart::ColorPropertySet*)this’ is not a constant expression
        >    82 |         : mValue(nColor)
        >       |           ^~~~~~~~~~~~~~
        
        (see the comment at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98752#c6>
        "wrong "error: ‘this’ is not a constant expression" with consteval constructor")
        
        Change-Id: I3b8b92cd7ba31724cf0c9fe38b6cf8aa2abd7c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160405
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-07  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [d4370db8ceb74950d3ef381d4a0c1aca033f0294]

        mkdir_p still needed by make create-partial-info
        
        157298bb808a943616991927f9370a86c1f2ca48 "android and bin/update: make pythonic"
        had removed it, so that `make create-partial-info` would now fail at least with
        
        > Traceback (most recent call last):
        >   File "bin/update/create_partial_update.py", line 10, in <module>
        >     from path import UpdaterPath, mkdir_p, convert_to_unix, convert_to_native
        > ImportError: cannot import name 'mkdir_p' from 'path' (bin/update/path.py)
        
        (and no idea if that make target would still do anything useful, beyond this
        initial hurdle)
        
        Change-Id: Ib1be3304e2b3468dc187c1b5e24041e68a3677fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160397
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [4022666087f317f9c5f9c966307bcbe85ee5e1b6]

        tdf#158464 - UI: Part 47 - Unify lockdown behavior of Options dialog
        
        for Calc - General Page.
        
        Change-Id: I2ff8edd0fb10a3f388459d842c79b157bc3861f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160407
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-12-07  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [030b72df0af04752157378e07703db0e035ff9c2]

        tdf#157432 Expert config: Allow filtering by changed values
        
        Change-Id: Ib8bbb7fc9e8014a9367278f3fa640f53af46dd2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159986
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-07  Stephan Bergmann  <sbergman@redhat.com>  [7575e8afcadc1b907f803ebfd1e38ef168597eec]

        loplugin:ostr (macOS)
        
        Change-Id: I1b169e0c170c26a49941d22f0982a24ef547f941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160391
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-07  Michael Weghorn  <m.weghorn@posteo.de>  [185cd83bf58d8c834a9690cdd6a25736787abbf7]

        sw a11y: Only report "level", no more "heading-level" obj attr
        
        Stop reporting the custom "heading-level" object attribute in
        addition to the "level" attribute.
        As described in the Core Accessibility API Mappings spec, the
        latter is specified in ARIA and maps to an attribute of
        the same name for all of AT-SPI2, IAccessible2 and UIA [1].
        
        Get rid of the non-documented "heading-level" as part of the
        goal to align more closely to platform APIs/specifications.
        
        NVDA's LibreOffice-specific app module currently relies on the
        custom "heading-level" object attribute [2], but I've reported
        an issue and submitted a pull request for this: [3] [4]
        
        While neither the "level" nor the "heading-level" attribute are
        currently mentioned in the the IAccessible2 object attribute
        specification [5], the IAccessible2 doc for
        `IAccessible2::groupPosition` [6] explicitly mentions
        the "level" attribute for headings:
        
        > This method is meant to describe the nature of an object's containment
        > structure. It's exposed by trees, tree grids, nested lists, nested
        > menus, but not headings, which uses the level object attribute.
        
        [1] https://www.w3.org/TR/core-aam-1.2/#ariaLevelHeading
        [2] https://github.com/nvaccess/nvda/blob/9cf925195e0fc5ffc67dcfcc9e4d4a7d46ffb430/source/appModules/soffice.py#L225
        [3] https://github.com/nvaccess/nvda/issues/15881
        [4] https://github.com/nvaccess/nvda/pull/15882
        [5] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes
        [6] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#a94d4d84e000ef2fa3f2abf1148779941
        
        Change-Id: I8e8994cc7565f9b0f40ca8bedff951512f56b59b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160347
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-07  Michael Weghorn  <m.weghorn@posteo.de>  [90d49b980d7fed1d55ab83f3ed88d27ab2cfbb12]

        sw a11y: Only report heading level attr for heading
        
        Only report the "heading-level" and "level" object
        attributes for a Writer paragraph when this paragraph
        has a heading level that can be reported as the value
        of the object attribute.
        No longer report the attribute without any value set otherwise,
        since the attribute doesn't provide any value then,
        but is rather confusing/misleading.
        
        Change-Id: I282345b00a32a74de229058ff368f3b169bf1c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160346
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-06  Patrick Luby  <plubius@libreoffice.org>  [0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc]

        Related: tdf#155266 skip redisplay of the view when forcing flush
        
        It appears that calling -[NSView display] overwhelms some Intel Macs
        so only flush the graphics and skip immediate redisplay of the view.
        
        Change-Id: I7a94a1ada35526c5eda1b793f872e206b4c833ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160399
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c574def363c96aa38e8db4e8a03fa9ebcc41da7b]

        update tsan suppressions
        
        Change-Id: Ib91f900e93c10225769ba92f4d0819a4084f5847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [de9667d419bae2c03adf9a9c08b20cd519137cba]

        tdf#157915 Error when running a Basic macro with instruction commitChanges
        
        regression from
            commit 1576ef8532cf2cea2da361db9c5707f1994e65e2
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Dec 23 18:40:44 2021 +0200
            osl::Mutex->std::mutex in SvtCommandOptions
        
        Note that this only fixes part of the issue - specifically the part that
        the original reporter described.
        
        There is a further issue, not fixed here, which only happens on
        Linux/GTK, where the messagebox dialog manages to end up behind the
        About dialog, and consequently cannot be closed, which freezes the
        program.
        
        Change-Id: Idbb7f51e494a69886c80eb92efaa7cf7c6911c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-06  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cc3fb303db41492eccf845f34581b462c6ee24ec]

        Fix apparent typo in make create-update-info
        
        157298bb808a943616991927f9370a86c1f2ca48 "android and bin/update: make pythonic"
        had introduced this apparent typo, so that `make create-update-info` would now
        fail (and no idea if that make target would still do anything useful, beyond
        this initial hurdle)
        
        Change-Id: I63c4e87e06370d99e5d036ce5c7f2a5bda3c1554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160398
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-06  Jean-Pierre Ledure  <jp@ledure.be>  [e8ac98c6569f8c462e754a3142aeb9f433588ec8]

        ScriptForge (SF_Root) Fix typos
        
        Suppression of linefeeds in excess
        inside english error messages.
        
        Change-Id: I38189e7dcf9d24055e477a5cb6cfeb42644ded39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160385
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-12-06  Stephan Bergmann  <sbergman@redhat.com>  [8b5bb37cc4116f74c2f533453936eb8cb84d9fc5]

        loplugin:ostr (macOS)
        
        Change-Id: I85ecdf188dc394d6175a2dd7338147a057fa7766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160392
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9e8df5bfe804943a8662b52ff2afed936b79657d]

        tdf#148986 Support XF86Forward / XF86Back key events
        
        Multimedia keys found on certain presentation clicker devices.
        Not added to the Customize dialog, as that was not yet asked for.
        As I have no access to a MAC, did not add support for that in vcl.
        
        Inspiration for code taken from
        commit ca74511985981444dbd72ade7244484c131e36a7
        
        Change-Id: I417e6ba7e79c5f6e774a56ba747803a156d5f50f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160255
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-06  Oliver Specht  <oliver.specht@cib.de>  [5de53775531a358c6775d265a3a19699c96a8139]

        tdf#154369 don't apply default items to numbering symbols
        
        default attributes from the CharFmt should no be applied to the
        numbering symbol
        
        Change-Id: Ifa2d2ace575b888a43fa948f3b71605cfe20f129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159817
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [968166ba4ee96f7c9053c8f4c88ac82381ff7cf4]

        Remove pyuno.xcd from build/packaging
        
        cleanup after commit 80798b426bf7d5fa4616db1af608640cfbcd79fe
        
        Change-Id: I8d1712ac592a69ec0b9a5705d6a689e57062e347
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160300
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-06  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [714e406fc4089f1a4b67c9a1ac55bf4162cc5a01]

        Drop use of Win98-era multimon.h
        
        last mention of it was removed in 2014 by:
        commit cb40b7d2f9902b5fbe89333c4107d72c156b9a15
        
        Change-Id: Ib60d84624b681d103bc654075a759fc92f8f3300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160289
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ef9770158a3f9579429f64409c5897304ea9111]

        cid#1558795 Dereference after null check
        
        Change-Id: Iebdc89ee4512e2583a9e320ba65b3f40c3d5a33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c0b938e279fc36e6da129304b075361de39fa8bd]

        replace bInfo with direct pInfo check
        
        its a little less obscure
        
        Change-Id: I16f48e9cb55ea74a8d0e64ec7bc694890a0fcf88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160344
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa7d1c8f1411fe35465f265259cf1082adf05aea]

        make AlphaMask separate from Bitmap
        
        Having it subclass Bitmap encourages confusion in passing it around, and
        I need the extra type-safety for my work on merged-alpha
        
        Change-Id: I35819f9b8ee609cbdaf865563c78531e397b529b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160235
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-06  Laurent Balland  <laurent.balland@mailo.fr>  [0f82e9d42822e627edd1fb3b3c87e1f8a22136a4]

        tdf#158488 Impress templates: restore style hierarchy
        
        Some templates were defining Title/Header/Text A0 styles with A4 as
        parent. Reset it to A0
        
        Change-Id: Ide7b0e5287d38991ad5149eacb80f600467039f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160261
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1db193c6c744289139b1df2af0b8defcf974b238]

        tdf#126084 import svg image from ooxml document that use svgBlip elem.
        
        In an OOXML document the svg image is defined in an svgBlip, which
        is an OOXML extension. This change checks for the svgBlip element
        and imports that instead the normal "blip" element that is still
        provided as a fallback (PNG image).
        
        Add roundtrip SVG image test for ODF and OOXML, Impress and Writer.
        
        testGraphicBlipXLSX test failed after this change, because some
        component was missing. Changed to enable use_rdb for all chart2
        export tests, so issues like this won't happen anymore.
        
        Change-Id: Idf0e754775254d7dcfd0321dfca2ed6d00c42c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157238
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-06  Miklos Vajna  <vmiklos@collabora.com>  [fa38d98155a857908641380c7a1a5a34fafe934e]

        Remove now unused SwModelTestBase::preTest()
        
        Which was a way to place test setup code far from the test itself, so
        good to get rid of it.
        
        Change-Id: I9f88ded958e7b546f0b1ecd7ce025e72a2a5e245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160373
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb3157e38bfffd23505abc35f790043392f43d2c]

        Remove the special-casing in Bitmap::Invert (and fix)
        
        and rather rely on the backends doing the right thing, which is
        considerably faster.
        
        Which uncovers a bug in the existing code - it is not legal
        to simply invert the value when dealing with palette-based
        images. Fix this by sharing some code with Bitmap::ReplaceMask.
        
        Change-Id: I2ef340a9f251c8c7e27b68ab451ce85df07c1035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-05  Laurent Balland  <laurent.balland@mailo.fr>  [a9ad36ae46ff76c0d59b0d170314fdd3a9ee5d35]

        Impress templates: restore font declarations
        
        Some warnings appear when opening the template due to some missing font
        declarations
        Remove date declaration
        Fix some minor errors detected with ODFValidator
        Focus: remove DejaVu Sans2 font declaration (duplicate)
        
        Change-Id: I48a61d7df651d8113d5f15ba0c5877f6553e5003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160064
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-12-05  Eike Rathke  <erack@redhat.com>  [f35b540279b00575ff79eda1c65fb0f8caad86bf]

        Resolves: tdf#158223 Revert "fix" for tdf#156174 and follow-up
        
        ... introducing a real fix.
        
            commit 94ca402cd1fe2fd9776d08448f7216b7f638e69a
            CommitDate: Tue Jul 25 15:04:01 2023 +0200
        
                tdf#156174 sc DBData: fix regression of database ranges
        
        just cured a symptom by removing a condition that shouldn't had been
        removed, instead of getting to the real cause of an odd reference
        update.
        
        Shrinking the end of a sheet reference range and thus moving it one
        before the previously referenced relative position is only possible if
        the deleted sheet actually touches the referenced range, which here the
        start value points to and thus checking ref>=start+delta is not
        necessary and subtracting 1 even harms. This is different from deleting
        columns or rows where the start value points behind the deleted area of
        moving the following area.
        
        Change-Id: If9ae5dd6f6ae5cd248ad5d999f1aa7577d4ec035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160374
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-12-05  Jim Raykowski  <raykowj@gmail.com>  [8286c9ebe47aaf24b055f51136a8cb06f1e6429c]

        tdf#157729 SwNavigator: enhancement to group comments by threads
        
        Change-Id: I64bc02e64d540a2bf602d2124deda1990dfb9f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160011
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-12-05  Miklos Vajna  <vmiklos@collabora.com>  [24135dc15a797ca91dd32c70cbc4d26a05dfd127]

        writerfilter: fix crash in DomainMapper_Impl::PushSdt()
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 1 for address: 0x0
        
        program/libwriterfilterlo.so
                writerfilter::dmapper::DomainMapper_Impl::PushSdt()
                        writerfilter/source/dmapper/DomainMapper_Impl.cxx:987
        program/libwriterfilterlo.so
                writerfilter::dmapper::DomainMapper::lcl_attribute(unsigned int, writerfilter::Value&)
                        include/tools/ref.hxx:56
        program/libwriterfilterlo.so
                writerfilter::ooxml::OOXMLProperty::resolve(writerfilter::Properties&)
                        include/tools/ref.hxx:56
        program/libwriterfilterlo.so
                writerfilter::ooxml::OOXMLPropertySet::resolve(writerfilter::Properties&)
                        include/tools/ref.hxx:157
        
        Change-Id: I76416ca707a4ac40495e5c22f62fcd017bcb5e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160336
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 728f6ec104b1a91c8c8ea0790bc7f56471c67737)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160351
        Tested-by: Jenkins

2023-12-05  Mike Kaganski  <mike.kaganski@collabora.com>  [faefc434efdc38587ddad0a65618efde81431e38]

        Deduplicate execute_dialog_through_*
        
        Use Python 3.3's 'yield from', which should be OK, because the
        baseline rhel8 has Python 3.6. If needed, older Python could
        use replacement like this:
        
            for dialog in self.wait_and_yield_dialog(event, xDialogParent, close_button):
                yield dialog
        
        Change-Id: Ic70bdf19fed730e41b7ce2868990ec88423eab33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8686b480ba1d79463f33fe931a454d9d92c3d739]

        Fix apparent copy/paste typo
        
        ...present ever since the code got introduced in
        569269078576fa832143ec4f0bf03283ff358f48 "improve the update checker"
        
        Change-Id: I38d0efee3cb3f6954dd30690ba9afddf0b66c959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160348
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-05  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [7f49fa220225d2afbefac756a03586212d8ce1c6]

        Make --enable-online-update=mar at least compile again, on Linux
        
        Seen it build (but no idea yet whether it actually would work) with
        autogen.input including
        
        > --enable-online-update=mar
        > --with-update-config=/home/sberg/lo/update.ini
        
        and ~/lo/update.ini containing
        
        > [Updater]
        > ServerURL=TODO
        > base-url=TODO
        > certificate-der=/home/sberg/lo/certificate.der
        > certificate-name=TODO
        > certificate-path=TODO
        > channel=TODO
        > upload-url=TODO
        
        and ~/lo/certificate.der containing
        
        > TODO
        
        Change-Id: Ib40417c09c6454fe9cf678c029a06716415e5cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160339
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e507fd525404d5ac078a47650df11e5e18a88a81]

        Related: tdf#158534 set fallback help page for optional print content
        
        Change-Id: I79d843cbf2591ab5a8625087e2ec5897b26a8056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160371
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a28a721ef9f2daced3e08f30578e603abd119773]

        cid#1546503 Using invalid iterator
        
        and
        
        cid#1546284 Using invalid iterator
        
        Change-Id: I9ff3498b65ce392dbe859566b49e60a31e0779f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160370
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-05  Laurent Balland  <laurent.balland@mailo.fr>  [23c300a06dbfb5399cf479d603e6f7fe1433d134]

        Vintage Impress template: remove unused styles
        
        These old styles are used in the template and is no more in use in LO.
        So they remain untranslated when changing UI language.
        
        Change-Id: I130eb25df9b76783d498d6ab1e5191551b9a4d0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160269
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a639b7432e7d35b271fbfea9021f5df56d681006]

        Resolves: tdf#158534 two help pages from print help button
        
        its either use the default "help" response, or have an explicit
        handler for the help button.
        
        Its more consistent to just use the default "help" response for
        the print dialog as done everywhere else.
        
        Change-Id: I0bb173e67a3bea1c10cc315cfcf212376f2710c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160340
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6aba19406767a54bb61eaffb2903c1b2902da9a8]

        Resolves: tdf#158441 we don't want to return early for all handled keys
        
        a problem since:
        
        commit c39bd1f6690ade936d62a66265b9b277061024d8
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Wed Feb 19 10:13:15 2020 +0000
        
            weld CodeCompleteWindow
        
        Change-Id: I520a591bad89515c973098f4200f01ae0ddbdc34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160337
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [9b5964cf5931d7c09e4fd624d68595891c2afb58]

        vcl: add unit test for cached glyphs based on tdf#103492
        
        Change-Id: Id66be996053435c92b667eb142ae1e271ff33b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159386
        Tested-by: Jenkins
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9291c24a21ef02240df7b0bd06f86cac1c6f659]

        Fix typo
        
        Change-Id: Id5c6ac6c1358334dba4b96fcc6dee9e40859ec32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160341
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [192c581395e2db07829ff9ba1ed79d5492dcbbce]

        Fix typo
        
        Change-Id: I5f000f53f4dfec62a6d5a332361c380dc142d2bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160342
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-05  Henry Castro  <hcastro@collabora.com>  [fd11b63244f784b336690d9096cd3f820cdbb9ee]

        sc: show a message dialog if insert cells fail
        
        Use case, go to the max row and insert a row.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I930d7724b9c94e10e9207ec749b7249d2fee0e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160314
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit eccbe3bb4ed6f0bed4e7fbacfaf50762c93f9464)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160183
        Tested-by: Jenkins

2023-12-05  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [464d5f1265bd3ed2eff0c809152b8ccb53b785df]

        [API CHANGE] Drop unused XAxis/YAxis config groups
        
        from Calc grid options. Spotted while researching for tdf#158473
        
        last mention of ther getters was commented out in 2001 by:
        commit a4e5d2cb47275e91834e41a9d51f1bf11ec409b1
        
        Change-Id: Iffc7b5c4fb50352ad7063fc911039707a20dca4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160169
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-12-05  Laurent Balland  <laurent.balland@mailo.fr>  [146663cc75d3954ae4a4e2f6f1f64d831618b56f]

        tdf#158022 Grey Elegant template: restore placeholders
        
        - Restore preview of slide in notes (master notes and notes, same size
          and position than other templates)
        - Enable header/date-time/footer/page number in master notes
        - Uniformisation of font Noto Sans
        - Bring to front header and outlines
        - Add date/time, footer and slide number on all master pages (except
          Title)
        - Improve Header and Outline positions
        - Use placeholders for example texts
        - Move credits on master slide "Table of content" and slide 9 to
          meta.xml
        - Change name of Title master page due to tdf#158496
        
        Change-Id: I29eec8ad61fdf35a53be15678fd09aefc2b11a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158956
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-05  Miklos Vajna  <vmiklos@collabora.com>  [868140fcc1311259b9d5f666637b33d226511a53]

        tdf#60558 sw floattable: allow wrap of table on the right of a floattable
        
        The bugdoc shows that Word wraps inline tables around floating tables if
        they have enough space, but Writer didn't do this.
        
        Table frames may wrap fly frames by adding some top, left or right
        margin to the table at a layout level, this is calculated in
        SwTabFrame::CalcFlyOffsets(). There we currently decide the give a top
        margin to such tables, which fixes the overlap problem, but the bugdoc
        is now of 2 pages instead of 1 page, since we don't wrap.
        
        Fix the problem by improving the "shift down" case by checking if
        shifting to the right would also work (has enough space). If so, do that
        in case the fly frame is a split fly.
        
        Note that this could be done for all flys as well, but that would have
        to be conditional on some Word compat flag and that's not needed to fix
        the bugdoc, so leave that for later.
        
        Change-Id: Idb45413257758fd0334b17ef348ba28010a52316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160331
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b78bb218cc48207bc3943bd1eb0a34a9f7b60c3]

        upload_symbols: give some feedback
        
        Change-Id: I2a1faa91ec502cfe8b62324f8fa80264bdb9d31f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160197
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b41d3f6778b91838c98d1648eb652de48b0511d]

        uitest: remove crash report handler
        
        Unneded since a4a1f2ecee2e7b1d50e0065e25090e262863e1c4
        "Disallow crash reporting in UITests"
        
        Change-Id: I661b6111bd5142e67ee73a82c0777771e7651300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160324
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-05  Justin Luth  <justin.luth@collabora.com>  [b63a12d481cd26f960f97f74e5a4d764966db338]

        tdf#148540 Revert "tdf#109790 RTF import: keep remembering...
        
        ... paragraph style between \cell and \row"
        This reverts 5.4.1 commit aaa6a5202a447fb4e86d5f016d8e79fbc34a3ed7,
        and rtfexport7's tdf109790.rtf unit test still passes.
        I also did a visual test, which looks good.
        
        After \cell, we normally get more \cells, so an impending
        \row is completely unexpected most of the time.
        I'm not really sure why that patch was ever thought to be good.
        
        The problem was that \pard was not removing the paragraph style
        that was assigned to an earlier column. The end result seemed
        innocent (no bad formatting noticed),
        but that is probably based on other work
        done in the meantime which allows the unit test to still pass
        even after all of "its code" has been reverted.
        
        [If this causes a regression, perhaps m_pLastCharacterContext
        could be of value?]
        
        Change-Id: Ide9b65f5e5fa39c21bac6d8ed354bb88e0bbefe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160233
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-12-05  Justin Luth  <justin.luth@collabora.com>  [caecfff1adbe9715260ef9e2009333e523d61123]

        tdf#108505 writerfilter: fix field direct char settings
        
        Instead of adding characters properties one at a time,
        lets take care of everything all at once.
        
        The results seem to be good so far.
        There is even some similarity between
        how MS Word has these properties on the
        "in-between" pseudo end character, where
        placing the cursor after the field gets these properties.
        I don't see it happening in MS Word
        at the pseudo start character, but it does in LO now...
        
        Hopefully that doesn't end up doing bad things.
        
        In the unit test, replacing the content ends up
        in red, italic. However, I see the same thing in MSO
        when testing with my second FORMTEXT example,
        so I think everything is "working as expected".
        
        I tried to see if I could limit doing this
        for only certain types of fields or conditions.
        However, pContext->GetResult() doesn't have a \fldrslt
        yet at the time this is happening. Also, TextField.is()
        happens less than I expected. I'm sure I could limit it
        to just certain pContext->GetFieldId(),
        but so far no problems are noticed for all field types.
        
        make CppunitTest_sw_rtfexport6 \
            CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat
        
        make CppunitTest_sw_rtfexport6 \
            CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat2
        
        Change-Id: I3223437fd0d694f5e5733a9f7323f10f03d7802f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160232
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-05  Miklos Vajna  <vmiklos@collabora.com>  [9c02160fc55bccc43d92c68ec5166a79d50e1528]

        sw: document SwFormatRefMark
        
        Explain where this can appear, who owns it and where it can be found on
        the UI.
        
        Change-Id: I4096bc51ef03e50c65261e7356a4e593d1ba4c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160323
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-05  Justin Luth  <justin.luth@collabora.com>  [59a0be15b097dc4f2529837d128f52cc3fb497d9]

        tdf#108505 writerfilter: fix legacy dropdown fields direct bold setting
        
        Any character property should be passed on,
        but do that in a follow-up commit, so that
        at least the bold case will remain intact
        if the broader fix gets reverted for any reason.
        
        make CppunitTest_sw_rtfexport6 \
            CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat
        
        Change-Id: Id77980b704db2ff118e89c29eb9d4db82e117cdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160221
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-05  Mike Kaganski  <mike.kaganski@collabora.com>  [2bde39767ff2aead9d4cfddc37f32103bfc52f63]

        Drop own mutex to prevent lock order problem
        
        When running UITests on Windows with parallelism, I often see deadlocks
        in clipboard threads, where one thread holds own mutex and tries to lock
        solar mutex, and the other holds it and waits for own mutex. The problem
        is in TransferableDataHelper::GetAny, where solar mutex is released
        temporarily.
        
        Avoid it by dropping own mutex, and only using solar mutex.
        
        Change-Id: Idbfa2e1399fe94d092b4090e7aa4956be4103744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160296
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [042dc4a9186f526b625817dde50bb2f5a91fd2c6]

        vcl: add unit tests for a mixture of CJK and latin characters
        
        To influence the fallback fonts chosen, I have introduced a new
        OutputDevice function ForceFallbackFont() which injects ("forces") a
        font as the first one in the font fallback chain.
        
        Change-Id: I05856cbe829fde0eb140bb48a37795a84d780900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159221
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-04  Justin Luth  <justin.luth@collabora.com>  [1a74a87b442857567d20da5dc97bbbc278745afd]

        related tdf#56258 sw sidebar SetOutline: do something without dropdown
        
        The sidebar gained SetOutline in 7.6
        with commit 3fd0b4053763aa91b0004c523e96e7d390c7b58e.
        
        In the TOOLBAR, there is special code that tells the main button
        to show the locale list outline choices - just like the dropdown does.
        However, none of that code comes into play in the sidebar,
        so add a special case to handle that situation.
        
        It is easy to launch the dialog, focused on the outlinenum page.
        Better yet would be to figure out how to launch the popup window
        that the dropdown opens - so they do the same thing...
        
        Change-Id: I3d6eeafaa8bdb45cfacc42e221820d664419e0e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159934
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit f384dc0476e4730d3ccb7a7f56eae8452bce133a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160180
        Tested-by: Jenkins

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [67c2a4786154a5c246998f119c3349e4d725e43b]

        cid#1545597 Using invalid iterator
        
        and :
        
        cid#1545537 Using invalid iterator
        cid#1545508 Using invalid iterator
        cid#1545494 Using invalid iterator
        cid#1545478 Using invalid iterator
        cid#1545427 Using invalid iterator
        cid#1545420 Using invalid iterator
        cid#1545400 Using invalid iterator
        cid#1545300 Using invalid iterator
        cid#1545258 Using invalid iterator
        cid#1545257 Using invalid iterator
        cid#1545200 Using invalid iterator
        cid#1545183 Using invalid iterator
        
        Change-Id: Ibf3a41902f34286967195c5c3b22e337a4b06809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160322
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [8472365774b7471e96a025f424a6c7eb7b02db26]

        Avoid clipboard messages after Scheduler::ImplDeInitScheduler
        
        When running UITests on Windows with parallelism, often there are
        clipboard "content changed" messages that fail the assertion in
        Scheduler::ImplDeInitScheduler. This is because the clipboard is
        only uninitialized after the scheduler de-init; and even then,
        the respective threads are not stopped yet.
        
        Make sure that clipboard listeners are stopped before calling the
        Scheduler::ImplDeInitScheduler in DeInitVCL.
        
        Change-Id: I37918cdc565c7f1b3bd4f46e71c55bb5a807db6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160308
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-04  László Németh  <nemeth@numbertext.org>  [7059a1858ddb044c5f3f0c8e0386d3e1d9dd2b5f]

        tdf#119908 tdf#158439 sw smart justify: fix freezing with NBSP
        
        Stop shrinking during underflow, because it resulted
        endless layout loop, e.g. when a very short word followed
        by a no-break space.
        
        Regression from commit 7d08767b890e723cd502b1c61d250924f695eb98
        "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt."
        
        Change-Id: Id832b7fdbc01453a30067995e14e5430b0a15232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160316
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-12-04  Aron Budea  <aron.budea@collabora.com>  [5b4a705f7477da2b546d0658e46e96f4e69017e4]

        sc SetLayoutRTL: Only call PostPaint for current tab
        
        ...instead of the usual 0-9999, a layout change of the current
        sheet should have no effect on others.
        
        Change-Id: I5a9a2da78daf1fab06da939574c0e8a027533fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160254
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 67cdcf1ab2d2977fa79f9ecd7935ad8f3a8b4377)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160181
        Tested-by: Jenkins

2023-12-04  Aron Budea  <aron.budea@collabora.com>  [c822a05625da33479527e11a80fe44d3d7b504c8]

        lok: Notify all tabs in the range
        
        34d5abf464dfbf4bdc36f6b87e606c84a1f4d99d restricted this to the
        first tab, but PostPaint(...) is sometimes called with a
        0..9999 tab range, even if the change only affected somewhere
        in between.
        
        In addition, restrict range end to the last actual tab in the
        spreadsheet.
        
        Change-Id: I44a7bb351e17bf85b13fedfe2a9f3d76543c4372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160253
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 4d30910523bccb3b965f254401e6341af2ee8704)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160182
        Tested-by: Jenkins

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [708e379994591c6e73f07bd2aba136841c9cf036]

        cid#1545810 Using invalid iterator
        
        and :
        
        cid#1545802 Using invalid iterator
        cid#1545745 Using invalid iterator
        cid#1545717 Using invalid iterator
        cid#1545675 Using invalid iterator
        cid#1545668 Using invalid iterator
        cid#1545639 Using invalid iterator
        cid#1545634 Using invalid iterator
        cid#1545629 Using invalid iterator
        cid#1545620 Using invalid iterator
        cid#1545608 Using invalid iterator
        cid#1545607 Using invalid iterator
        cid#1545601 Using invalid iterator
        
        Change-Id: I403842175f64a570d7e52fba7c3e03bf21b7d05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160320
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [6bc0020108e8b45954727276ba11b462feb9a4bf]

        Put back the message in assert after b50da6f3a9109fc1d4468c15aa7d5c68773ec199
        
        Change-Id: Ie469e94ff51f1ca6dbbd65020f02fe43e0c1608c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160318
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5584980493fd599054cc5bbdb9911ae2c70cd60f]

        tdf#158404 Start Center: remove ability to do multiselections
        
        in Recent Documents and Templates views using Shift+arrow keys as
        no actions can be executed for multiple selected files.
        
        Multiselection still works as normal in Manage Templates dialog.
        
        Change-Id: I03b9e54abb7772881139763a0c97f36637d01f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160003
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [bc95ece0618b9886890d9c758b9d0ebc0fc41c69]

        cid#1546021 Using invalid iterator
        
        and :
        
        cid#1545983 Using invalid iterator
        cid#1545969 Using invalid iterator
        cid#1545949 Using invalid iterator
        cid#1545929 Using invalid iterator
        cid#1545911 Using invalid iterator
        cid#1545910 Using invalid iterator
        cid#1545886 Using invalid iterator
        cid#1545870 Using invalid iterator
        cid#1545813 Using invalid iterator
        
        Change-Id: I2ad10c2a9affd348050a4abe0917a90927a52547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160317
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Andras Timar  <andras.timar@collabora.com>  [22e1cdd3a2fc142fc5313e1dba942810c7e91f95]

        Make OK/Cancel buttons translatable on Language Selection dialog
        
        Change-Id: Ida5f6e2195bb388377e89f12d00431ba2d68cca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160283
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-12-04  Laurent Balland  <laurent.balland@mailo.fr>  [a56003dc89903f2b03d041807d48bb1e004a3853]

        tdf#158017 Freshes Impress template: color font
        
        Color font was forced to black with 70% of transparency to render a grey
        color. This trick fails with dark mode.
        A standard grey color is restored with this commit (and 0% transparency)
        
        Change-Id: I71a176ef3f6f020aba9fbeaca4e4e0549398dab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160238
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-12-04  Laurent Balland  <laurent.balland@mailo.fr>  [f1f8fd8455aee3cb07108696856c6026d453f372]

        Nature Illustration template: remove unused styles
        
        These old styles are used in the template and is no more in use in LO.
        So they remain untranslated when changing UI language.
        
        Change-Id: I5a4b0c6914eb97eb2448a24909ded294c9c0ddf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160264
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-12-04  Laurent Balland  <laurent.balland@mailo.fr>  [d103f4afddd6360c3e09fde3cbe7c3f720ac7f65]

        Metropolis Impress template: remove unused styles
        
        These old styles are used in the template and is no more in use in LO.
        So they remain untranslated when changing UI language.
        
        Change-Id: If86e6573c03af481fcb43ffc2521bcdd3bd9e584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160263
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a4a1f2ecee2e7b1d50e0065e25090e262863e1c4]

        Disallow crash reporting in UITests
        
        Otherwise, after one crash, the next UITest starts with the crash report
        dialog, and hangs, creating the noise in results. Seen when running
        UITests on Windows with parallelism.
        
        Crash reporting is unaffected by '--norestore', and handled separately
        in Desktop::OpenClients (desktop/source/app/app.cxx).
        
        Change-Id: I00b9bca3aa34c603bfdb54389437ce3ec4de6274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160312
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [b50da6f3a9109fc1d4468c15aa7d5c68773ec199]

        cid#1546275 Using invalid iterator
        
        and :
        
        cid#1546219 Using invalid iterator
        cid#1546088 Using invalid iterator
        cid#1546070 Using invalid iterator
        cid#1546061 Using invalid iterator
        cid#1546055 Using invalid iterator
        cid#1546049 Using invalid iterator
        
        Change-Id: I6f3a786852b5c262d60c3195e446a37967ed9b59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160311
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1597968f5cd2534fb6e0be40fafecc305a004f4e]

        tdf#155676 Properly support editing string lists
        
        Change-Id: I721e30aca03ddadd3a08e092e75accbd279bbec5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160315
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [274e078a6e94e477b594839355cc709829d921dd]

        Relax assertion a bit
        
        When running UITests on Windows with parallelism, I often see this
        assertion failing. I don't know why; but every time I attach the
        debugger to the failed process, I see mpSchedulerStack's mpTask
        and mpNext are both nullptr. The only place where this can happen
        is Task::~Task, which seems to suggest that this situation is
        basically the same as no mpSchedulerStack.
        
        Change-Id: I2485333944b6d56a365820bc4ca781098e508f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [a6dc2a42263816461600307b5f8271a5c5d8d031]

        tdf#157402: translate personas
        
        Change-Id: I6b2bc6f8fa76ddb669a71d0858a43c62bf51d58d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160240
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4b9823343777ca94bd1fa730e83f2729e55e80b6]

        Update git submodules
        
        * Update translations from branch 'master'
          to 5c0f8a2035b7a98ba0bce9e86e660db1e40e81c4
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I77488fda05cc237c8148a5307a2dd85937a42638
            
2023-12-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [78356d0db4a957a356a7e49e575b2fa8d3b9f902]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9ad74762e8f15a51057ea53d95818c92f0adf341
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: If3a600f16773aad9242bc3231788d8bfaf8227d1
            
2023-12-04  Sahil Gautam  <gautamsahil1947@gmail.com>  [a4d11d07fbace142cba82c30ecb09ff99b9bbb6f]

        tdf#33201 Checkbox Implementation for Col/row Highlight
        
        Change-Id: I32aca7128a3f01be9fd5a7150243f8fd4e82f626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159001
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a5b6255ee4c4b4df8141235cd4ee392d86e7fb5c]

        ofz#64582 Out-of-memory
        
        Change-Id: I862d558ffcf7d0347bf6b9e960b6f00c08c9e8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160310
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d30870831f990287d8b371d947865ff575aa8f18]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d20e738f1a2ace6618ad217ad42b17aac69e5762
          - adjust operators priority part
            
            remove note which is not directly related to "&" operator
            fix link to ODF standard page
            remove extra non-printing characters
            
            Change-Id: Iccb4d6ac288e41eef07d6f2d12809bc5aa7c48cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160260
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f19399c486e55ac630dc762edba626bbf2b6db3e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 645689dde4f47e1c9a765867d30b6ff2862b32dd
          - tdf#155876 UI cmds Calc-Format menu (25)
            
            + End of format menu for Calc
            + refactoring
            
            Change-Id: I5f220c507844fb64a27ed62b4220c358dc2fd2c3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160267
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [312efd56ea810063848841df951aa13aa5859bbb]

        At least VS 2022 Preview 17.9.0 Preview 1.1 needs the fix too
        
        ...from 3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022
        17.7.5"
        
        Change-Id: I765db22aba2823e6d9a38282ac53e9ba5bcff092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160309
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [14fd379f54c0a325d33e1c33c699de4d0f3ffe7f]

        UITest_writer_tests8: do not use custom configuration
        
        Added with b6e273aaaf597b60f78c1dd3db8676eea958a9f5
        "tdf#156243 Fix off-by-one bug for autocorrect"
        
        Change-Id: Ib9ce030cbc83514db174c39f5688d7382698d874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160297
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [20831559b8ca8c0b171db2a74889c90a1414b7ab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2517ad1832fb57f03f04741df091d5e885780057
          - Fix typo
            
            Change-Id: Iede79766f569d4384308a353c5f11062c96fd3ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160305
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-12-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a5418fbe09860f770e8aa2f478023c0843bb05d8]

        tdf#158457 Use proper parent
        
        Change-Id: Ic7bd3a2ae4dd0e21186df30bf221cf14c3511ac4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160161
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8bf16dc47e518e3cd2a6611b1c768ae589ea206e]

        ofz#64680 Integer-overflow
        
        Change-Id: Ic125ef6faf136a9821efc717214dd49ae24d6059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [c14dd7d8ddbdb348aaefce575976c1e52b9967f8]

        uitest: sw: refactor test to reset config change at the end
        
        Change-Id: I6447f6e97da7fc5d8946c0658f4bc11fbbfbbba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160299
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7976f67600670f789f36232e390f838cf3e00830]

        Expert config: Allow editing settings without default value
        
        Fix fallout from 700ac29771ccec2d66934f66b45a33a48a5ac3f1
        
        Change-Id: I194912d59e65c3b1245e5f9d107e4d2e8324e731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160294
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-12-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [f1f75b1f80e7ba45ccf970985fb9c82e1a6add82]

        tdf#158483: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I1635e5b9ad7a365e97dedaf92cdf436ae1ed814a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160295
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1f31cfc305224d3494da1b4eeadbe56b7227bb38]

        cid#1545582 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9d88d11889cef3f761b86c967ba1f3da7a8de891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [90403600aaa997aaee3a9f1004786502f426ec5d]

        cid#1545566 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ifd6c15630991c922f9392940142bb16c5e83685c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160286
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d51640061809034006db6d7ba1205c1f1f8b5fad]

        cid#1546422 COPY_INSTEAD_OF_MOVE
        
        and
        
        cid#1546416 COPY_INSTEAD_OF_MOVE
        cid#1546415 COPY_INSTEAD_OF_MOVE
        cid#1546391 COPY_INSTEAD_OF_MOVE
        cid#1546390 COPY_INSTEAD_OF_MOVE
        cid#1546317 COPY_INSTEAD_OF_MOVE
        cid#1546252 COPY_INSTEAD_OF_MOVE
        cid#1546251 COPY_INSTEAD_OF_MOVE
        cid#1546249 COPY_INSTEAD_OF_MOVE
        cid#1546243 COPY_INSTEAD_OF_MOVE
        cid#1546195 COPY_INSTEAD_OF_MOVE
        cid#1546193 COPY_INSTEAD_OF_MOVE
        cid#1546137 COPY_INSTEAD_OF_MOVE
        cid#1545738 COPY_INSTEAD_OF_MOVE
        cid#1545782 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I10d5091aa72b682371764b8a18cc5062e272c031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160285
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9ddca3616fc8b91973b9f261fd53797f9c84570f]

        cid#1546455 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9ea3cad738f5cbef0036fde9112b391893aff615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160277
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [325ec1c1060ba29b24eb1acbc5451bc972b484fc]

        cid#1546476 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Ic8133ebfb40c02eb95bdf95809aeca719f636acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160276
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de788d603dd763ed3c69a4e0fea98a571301c0ca]

        cid#1546483 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I41c2d42e64d25c7333f66b21bf294862bb04483a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160275
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f713779949a2d971da3f1c327429cdd3cbe2a95]

        cid#1546485 COPY_INSTEAD_OF_MOVE
        
        Change-Id: Id8ef4ab026e00a34f4ac2280becef35faa98a0e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3bf1c0d23afccaa84c3d4ecd701c20e60f9e2994]

        cid#1546495 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I8bc5ec6b9586a27e94164580ca7c1f785a08b04d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c0ed1d92c128fa73b0441581a958bab317f6fa7]

        cid#1546497 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I9bcbbdef1521dc77ccaca2734c662c12ac188b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160272
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [cdb180e767ebf2011414f4a5ba7213752474ee36]

        cid#1546332 Using invalid iterator
        
        and :
        
        cid#1546327 Using invalid iterator
        cid#1546289 Using invalid iterator
        cid#1546284 Using invalid iterator
        
        Change-Id: Ia0c8c69433a51fd356930f40f17f50774f244239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160279
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-04  Miklos Vajna  <vmiklos@collabora.com>  [beb0b57a638a2577d89ab5bdee6351008c5127ca]

        svx: prefix members of SdrPageGridFrameList
        
        See tdf#94879 for motivation.
        
        Change-Id: Ieb5630a9aaa1d5ae51915e0fe6892e43e9c2e629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160292
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bfbbf06bcea4d58117c14fd3f3b8743a3714f97e]

        tdf#126084 support writing SVG images into OOXML using the MS OOXML extension
        
        SVG files aren't supported in OOXML, but we can write it using the
        MS OOXML extension, which is supported in the latest MSO versions.
        
        For now this only implements the support in the exporter.
        
        Change-Id: I688180fb5772f3999c2ee3020bc234f90d57cc2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157237
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-04  Julien Nabet  <serval2412@yahoo.fr>  [09200875ce643e66f293d39bb27630a3fdbb984d]

        cid#1546325, cid#1546212: invalid iterator (xmloff/namespacemap.cxx)
        
        Change-Id: I7a3377326daa5a0d933a68b9d4f5a64983ba2ab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160278
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4852c601be832c4b70a08a05a8abb921e13ab6a6]

        Fix typo
        
        Change-Id: I55e1b250f35adb11169267d5f8f1dbaca9ad802d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160282
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-04  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [5d38c698337db2711837c5c703bbec4192d11192]

        -Werror,-Wunused-private-field
        
        Change-Id: I45e52154cede5a4ea3cc1007fa8f1bbf74c4dd3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-12-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [43967453e15e1d054972a7586cfef8f8e0866270]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 167b6b1ec40f44ab450a3c9a1fdaed8edac3742e
          - Fix typo
            
            Change-Id: I684dadb65f9f41b89d74532cf6bb2b76d01de5f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160281
            Tested-by: Jenkins
            Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
            
2023-12-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [e1473bc935b68147cb019572928e19a03f188f18]

        Upgrade lcms2 to 2.15
        
        Added Windows-ARM64 support in release 2.13, so external/lcms2/lcms2-win-arm64.patch.1
        and external/lcms2/lcms2_sln are not neccesary now.
        
        Fix external/lcms2/lcms2-2.4-windows.patch.
        
        Change-Id: I3b1ca0e715a5f500966d58971188f95a1f232883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157100
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [59d26784582041232968b7d52fa40389965e90fd]

        cid#1557920 COPY_INSTEAD_OF_MOVE
        
        a better example conversion
        
        Change-Id: I120fb8e4b505bc5d761f6e7c69766cd610c8a662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160271
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [44739ff1ee17eb8baf39fd8e40e686fbf31bcf4a]

        cid#1546503 Using invalid iterator
        
        and:
        
        cid#1546480 Using invalid iterator
        cid#1546479 Using invalid iterator
        cid#1546454 Using invalid iterator
        cid#1546419 Using invalid iterator
        cid#1546410 Using invalid iterator
        cid#1546150 Using invalid iterator
        cid#1546039 Using invalid iterator
        cid#1545831 Using invalid iterator
        cid#1545736 Using invalid iterator
        cid#1545701 Using invalid iterator
        cid#1545630 Using invalid iterator
        cid#1545381 Using invalid iterator
        
        Change-Id: I9e151b623f751ee1e982b5da0011ff08ab0ad5e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160270
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [5f17c6385fbff08ec72eab3fde6121c488bc1149]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7829aba61ee098e59768600c532c8a31cf25ee34
          - Document SF Database transaction handling methods
            
            Change-Id: Id5eadea4d55cfba1b240967f76096142af04d00e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160174
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-12-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [abd967ed31dbb1916003a1417bf337ed0fd3a5da]

        cid#1546453 COPY_INSTEAD_OF_MOVE
        
        a sample commit
        
        Change-Id: I226569c5d3b066a5c328b67a36c17df57b5a668d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-03  Noel Grandin  <noelgrandin@gmail.com>  [29fc0ec9930fc1c09c0e79d41c56f93ae853c054]

        Split the *Bitmap::CopyPixel functions
        
        into the two entire separate cases they want to handle, there is
        no reason to mix the two different cases like this.
        
        Change-Id: I38e99e7ad6168a84e7a744f61407887825158902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-03  Julien Nabet  <serval2412@yahoo.fr>  [033f973e22f4d76a8e55a5591ac46249c149901d]

        Mysql/Mariadb: implement Users::appendObject to allow users creation
        
        Change-Id: I49d4b08470a741bfb15d5d473ba6ccf19c55c964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160266
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-03  Noel Grandin  <noelgrandin@gmail.com>  [f8610622068edc0d69854fb44546fae7245a9568]

        ProcessAndBlurAlphaMask should take an AlphaMask as param
        
        Change-Id: I9235e74499d95750ca93da050014657b418c27d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-03  Julien Nabet  <serval2412@yahoo.fr>  [38fe084882f48153c956bc07079d5d64c41c546c]

        Mysql/Mariadb: implement Users::dropObject (so you can remove a user from UI)
        
        Change-Id: Ic8fee60e1182303469b5c74598d0ff6ec24667a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160259
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-03  Julien Nabet  <serval2412@yahoo.fr>  [dd011c3c1d3bfbc583c8e65a6021defe21fa5472]

        Mysql/Mariadb: implement changePassword
        
        Change-Id: I565bd96324044bb30b1e096c56e845766663ded1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160258
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1be8b2752d30d3c024e46526e9d31c1e7066799c]

        oox: Refactor and simplify writing to storage with GraphicExport
        
        Change-Id: I743dc99e0228b59050fb4926c8ef56bed8e82060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160252
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1229f093698abec0eca875bffdde3af6b7538aa4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c099ceeaf1cb4651bbca712ba19d16ee4206ab0f
          - tdf#155876 UI cmds Calc-Format menu (24)
            
            + Sparklines and more
            + refactoring
            
            Change-Id: Ie320018d7c3cf13d25bed7f6d7b6af4b2c9f9b26
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160251
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-03  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3b354c2ee5944917c0603615b7738ef234059414]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b321caecd0c27ae01afb12924f4f2cb12593dd8
          - Python example shared macros documentation
            
            Change-Id: If312091c487fd062ec7af24bc4c368bae7b0d748
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160172
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-12-02  Julien Nabet  <serval2412@yahoo.fr>  [7265820661325578011ffd336316ddfa38c511c2]

        Mysql/Mariadb: implement User and ODatabaseMetaData privileges methods
        
        User::getPrivileges
        User::getGrantablePrivileges
        + create ancillary User::findPrivilegesAndGrantPrivileges
        
        ODatabaseMetaData::getTablePrivileges
        
        Change-Id: Ib189aa121a3096aab412be68c76a3edaa11af1ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160247
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-02  Mike Kaganski  <mike.kaganski@collabora.com>  [18ff318c759aa228e317cf916f39bd6bf2d8dfb4]

        Revert "Drop allownonascii check from pre-commit checks"
        
        This reverts commit 8a0015c35f3f137e4f3a80e40616bc078e265a1c.
        
        See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html
        for details.
        
        Change-Id: I9bfa893af935587c7a4681e71b13a734d5f50b5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160177
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-02  Mike Kaganski  <mike.kaganski@collabora.com>  [fbf025b4903bfcb93c3d4bbf1ebbf860cf11618d]

        Make testHybridPDFFile Windows-only, and filenames in repo ASCII-only.
        
        See https://lists.freedesktop.org/archives/libreoffice/2023-December/091265.html
        for details.
        
        Change-Id: I73f4a48c9b71adc42354f099dcc98aff56e3fc43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160246
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-02  Noel Grandin  <noelgrandin@gmail.com>  [52512614d27d0dfe6ff94a738ed3b0cd477ef251]

        Simplify some AlphaMask code
        
        AlphaMask has an operator=, no need for extra complication
        
        Change-Id: Ib0f4aba4e1c9a4a594cc1cbc92f3a335dc9295a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160243
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-02  Noel Grandin  <noelgrandin@gmail.com>  [1c1806724dd9010d365fa64cc741a1e94dc9b065]

        AlphaMask::ReleaseAccess is unnecessary
        
        There is no way the format can change via the Bitmap*Access
        mechanisms, and we already perform these asserts in
        the constructor and operator=.
        
        The code has been there since
            commit 8ab086b6cc054501bfbf7ef6fa509c393691e860
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon Sep 18 16:07:07 2000 +0000
           initial import
        
        Change-Id: I75195f6fd4e29d7133e787131b6c8479a9188d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160242
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-02  Julien Nabet  <serval2412@yahoo.fr>  [4f928a5823b0bc7cd8af1d588e2084ae1ff1543f]

        Mysql/Mariadb: implement refreshUsers so get access to users admin page
        
        There's still work to do:
        - retrieve privileges of each table since it's empty for the moment
        - make the checkboxes editable (it seems read only)
        - make the user management work (creating one doesn't work for example)
        
        Change-Id: Ia1d9c4db7faae16ec1903c5d7aa5e679ce5e944a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160244
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-02  Julien Nabet  <serval2412@yahoo.fr>  [20661c37480c0cadc64d8e99da0463313e02d47c]

        Extended loplugin:ostr: sw/qa/extras/layout/layout3.cxx
        
        Change-Id: I1b86da0ef1ccdd2ccb83f489563f634605c25b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160245
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [91b39a9dad0563726ea2100557e3c88c24be2e61]

        remove printf
        
        Change-Id: Ib83b5c3b0f80310cd11f7cd8cd83e82d11e12eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160241
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-02  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [98db315322b0a4afd1b6fb2319f13f32f4689bed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c1e282a842285a55a3f42c62dc1d74c60a8fb3e6
          - tdf#135089 update location of Presenter Console settings
            
            ...and update various headings and section order.
            
            Change-Id: Ib1e19581def728ea35ac8ab837665ffcf482bfb9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159893
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [573f538424879b7f634b95a7cfa5d361d22a42d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a1840f2baee7b129990d6c0b218aae1b8d0304d7
          - mark untranslatable code and control name in SF Dialog and DialogControl
            
            also fixed typos caused by split paragraph
            
            Change-Id: I6c4d3badb30629c4bf58011089b4beeb1438204a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160051
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-12-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [6991f62ef84bc925c14b4a4a65f30fb7db54e978]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a0058e57883886e2249e4fc2d03e15454f267f4b
          - mark bookmarks and paragraph in SF FormDocument as translatable
            
            Change-Id: I5867af5313ca86b11b79d59b6a042b16ce9dfee0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160053
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [81a9dacb34604e3be536552510e8574af1b227a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 34d58970fae2b79958754584c3892512e5648bde
          - fix label of Select Table icon
            
            Change-Id: I33fc0fee719c45447cfbbf3baad52770c0329b02
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159951
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [3377903c2f23f33610586f2cfd192210d95a6185]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef8dd17a74f17232e65cc64132d4918024952345
          - fix description of ResizeWindowToInitialPage PDF export option
            
            Change-Id: I0611e69f0fd7a7c7a05f737264442c07bc629c28
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159800
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-02  EMartinGube  <martin.gube@web.de>  [c05bed53174ebc6f4e82838db9c2a7fcb587d3bd]

        tdf#152307 sw: layout: invalidate more frames when footer grows
        
        Unit test added.
        
        Change-Id: Ibcdb504c57c020cde9b76994cb54e744d1a12888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157905
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-12-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f5cf0c10eb7050feff19190b06b4597aab2d400a]

        tdf#123396 actually use the mimetype set in the from document
        
        In the document we set the mime type for the images stored, but
        at import we never actually used the mime types. We always did
        mime type detection from the filename extension. The problem with
        this is that files stored as base64 streams don't have a filename
        so it is also not possible to determine the mime type from the
        file name.
        
        The consequence of this is that we can't know which image to take
        if we have multiple images (fallback images) so we always take the
        last one, which could be the wrong one. This happend in the test
        document.
        
        This changes the behavior so that we always first use the document
        set mime type as there is no reason to not trust that. Only if the
        mime type isn't provided by the document we use other mime type
        detection methods.
        
        Change-Id: I175c509ce5f11eab2c0454d4d9901ca1fe975272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160237
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e320518eaf4c402bbbb37ed564e645659165f4f7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7f1aa0417dc645fe1a70022dbd58ef5063f5aac
          - Fix typos
            
            Change-Id: I9dd8a05048631cf0f1b8ec1f2ccef4d800e42e7d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160239
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-12-02  Laurent Balland  <laurent.balland@mailo.fr>  [2a0b9ebf39cf53735f0e27d084a6c0cb4eb0891c]

        tdf#158205 Blueprint Impress template background
        
        On first master page, move picture from page background to an object at
        the background
        
        Change-Id: I0e01ee9cad4a282c98e3678a7a45cfe13698e0e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159807
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-02  Laurent Balland  <laurent.balland@mailo.fr>  [29a86b786644d985bdb4d7ccc847ec81daf8d38f]

        Beehive Impress template: restore indentation
        
        Indentation was broken in content.xml
        
        Change-Id: Ia9f05d5af286aa1e3b8ddd9bb205769550d25e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160088
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-12-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4228a798ef63ea6d3a2e822cd8d1cccf46837af]

        pass BitmapBuffer around by std::optional
        
        instead of allocating on the heap, it is small
        
        Change-Id: I79eec6605a04c09d9a984cd1a719affb5b06dff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dfe551c816fcaf6f3d3ad9da6da5472900cf17d0]

        Related: tdf#158450 use SfxTabPage::GetFrameWeld
        
        to get the parent window.
        
        SfxTabPage::GetDialogController
        
        returns mpImpl->mpSfxDialogController
        
        and that is set in SfxTabPage::SfxTabPage ctor with
        
        mpImpl->mpSfxDialogController = dynamic_cast<SfxOkDialogController*>(m_pDialogController);
        
        and GetDialogController returns that mpImpl->mpSfxDialogController
        
        while nearly everything is derived from OKDialogController, not
        everything, like this column dialog case is, so
        mpImpl->mpSfxDialogController is null and it all fails.
        
        This same page is inside format, page styles as "columns" but that's the
        usual multi-page dialog derived from SfxOkDialogController, its just
        this single page dialog that is different.
        
        The original idea was to wait until this parent dialog is needed to
        figure out what to use. We have this SfxTabPage::SetDialogController so
        the dialog controller and page can theoretically change after the ctor,
        though maybe that doesn't happen in this case.
        
        Looking at SfxTabPage::GetFrameWeld that one always returns the current
        parent (of m_pDialogController, not the dynamically casted
        mpImpl->mpSfxDialogController) so in the best choice to use in general.
        
        Change-Id: I4617212fb27fdeeb0afc41123f7bc1b73f495c32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [35c536023aad834a6fdd7e87b2af7ef20dc651b9]

        we need these label placeholders for gtk
        
        Change-Id: If86e0d1ff4259613bfc20b3ede873dc56ca59206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160222
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [e8f3caea8c0e97b6bfd0a269568d621b2cfb3b72]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3d13c05329657af7015c298220855c4fddabd73d
          - Document new SF IncludeSubfolders argument
            
            Change-Id: I360b504446185870e8ea89843e834006f56e2af8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160041
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-12-01  Michael Weghorn  <m.weghorn@posteo.de>  [08ba31da63b58e92de05e96563146d3e909352e9]

        android: Update Android Gradle Plugin to 8.2.0
        
        ... and gradle to 8.2, as suggested by Android Studio.
        
        Change-Id: I1a1df5f43b7a95d24308873b708d3d21b76aa7f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160200
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0905043ad2490939e3e77df437355dd68f375e51]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00f8970a292d6876c29f2d2d4ca7958d832743e9
          - CSS: "literal" must wrap normally.
            
            Change-Id: Ib0ee56bd4a93d14467bec0ae607477dbbd86cbd8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160226
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-12-01  Julien Nabet  <serval2412@yahoo.fr>  [4f8bb267489b14aa1dab360786d8f99c763f03b4]

        tdf#158450: fix crash when picking custom colour for column separator line
        
        bt:
        0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396
        396	                [this]{ return GetDialogController()->getDialog(); }))
        0  0x00007ffeed9c4a2b in SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0::operator()() const (this=0x5555574a8e38) at /home/julien/lo/libreoffice/sw/source/ui/frmdlg/column.cxx:396
        1  0x00007ffeed9c4a05 in std::__invoke_impl<weld::Dialog*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(std::__invoke_other, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__f=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:61
        2  0x00007ffeed9c4985 in std::__invoke_r<weld::Window*, SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&>(SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0&) (__fn=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/invoke.h:114
        3  0x00007ffeed9c489d in std::_Function_handler<weld::Window* (), SwColumnPage::SwColumnPage(weld::Container*, weld::DialogController*, SfxItemSet const&)::$_0>::_M_invoke(std::_Any_data const&) (__functor=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:290
        4  0x00007ffff1cb89e5 in std::function<weld::Window* ()>::operator()() const (this=0x5555574a8e38) at /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591
        5  0x00007ffff1c94604 in ColorWindow::OpenPickerClickHdl(weld::Button&) (this=0x5555574a8db0) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2283
        6  0x00007ffff1c9356d in ColorWindow::LinkStubOpenPickerClickHdl(void*, weld::Button&) (instance=0x5555574a8db0, data=...) at /home/julien/lo/libreoffice/svx/source/tbxctrls/tbcontrl.cxx:2279
        
        See complete bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=191146
        
        Regression from:
        862fd2fa19b64972247bde9b171ec828a30e1676
        defer getting toplevel for color picker until we need it
        
        Change-Id: I2932281cb3b1cb510013a19f6bcf3d9f9c6cdb7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160164
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [97d3389f32a24f06113aad37058d24f2cbbc3026]

        cid#1557920 COPY_INSTEAD_OF_MOVE
        
        a sample commit to test this
        
        Change-Id: Ibc1a1f75b908e245395a05e81c26158c67e36257
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [004807caaa5f5e4516ba5cc9fac085fe8cd30dee]

        cid#1546413 silence Using invalid iterator
        
        sample to test silencing this
        
        Change-Id: I73a8e22a5266367d7b2c76aa00d38d40431b4841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160213
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fc288036a51f3d6a529ef4f145468f3ee3c8fc32]

        cid#1555476 silence Unchecked return value
        
        Change-Id: I55db6a470a2aca5ebcbace7859236b08bb67e25b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160212
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0014555f562feb1096dc80b1350e2b881ca2a9e]

        cid#1558172 Division or modulo by zero
        
        Change-Id: I4060b003fc03c8fe3e0396f9618e64a69715131c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160211
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-12-01  Julien Nabet  <serval2412@yahoo.fr>  [735b6b3861ed898dafa5c9d08400c37d1996283e]

        tdf#158452: FB: impossible to change field to "entry required" in GUI
        
        ... after table has been saved.
        
        There was an hack due to the fact that before FB 3.0, it wasn't possible to use ALTER TABLE to change nullable.
        See https://bugs.documentfoundation.org/show_bug.cgi?id=158452#c1
        Since the hack doesn't work and since FB 3.0 since several years, let's remove the hack and use ALTER TABLE command.
        
        Change-Id: I145077bb4c4874f5fe31e375cfb64176a1293575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160220
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [67444341273377f25f688b3e67acd8b2a1346431]

        Fix typo
        
        Change-Id: Iae999cd64ca73f178e4e1148af71b47fe03c8e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160206
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [18a505f97370359d627abfcacec18dbdfe3eea22]

        Fix typo
        
        Change-Id: Ie5cb165cce88c44004ff37692bfb3c0438c26ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160209
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [469342aed05c21568476128d9f60248db5ff8dd3]

        Fix typo
        
        Change-Id: I1998241849f0f9fa99d1b111f218cdab7e6074fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160208
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [86dc86ac25b24aab25ad9947014bed898b0d591c]

        Fix typo
        
        Change-Id: I9fae0349d8ecf4a4e11b23b46e5b593c07b05290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160210
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [39c4fa298a7c90353a1714b48d1a79df830ed1ef]

        Fix typo
        
        Change-Id: I19abea6905b36e9817de9531dafd389502034910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160205
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [05f80d673a27bba2520fac07888db5082dd7f9bd]

        Fix typo
        
        Change-Id: Ia40016ad2696c8555163074c415ea0e8f9216f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160207
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a5a49657dc17609a05dca59a8521fd71d14fe76e]

        tdf#158442: fix opening hybrid PDFs on Windows
        
        Commit 046e9545956d8ad1d69345d6b4a4c0a33714d179 (Try to revert to use
        of file_iterator from boost on Windows, 2023-10-31) had introduced a
        problem that pdfparse::PDFReader::read couldn't create file_iterator
        for files already opened with write access: mmap_file_iterator ctor
        on Windows used single FILE_SHARE_READ as dwSharedMode parameter for
        CreateFileA WinAPI; and that failed, when the file was already opened
        using GENERIC_WRITE in dwDesiredAccess - which happens when opening
        stream in TypeDetection::impl_detectTypeFlatAndDeep.
        
        Fix this by patching boosts' mmap_file_iterator constructor to use
        FILE_SHARE_READ | FILE_SHARE_WRITE, like we do in osl_openFile.
        
        But there was a pre-existing problem of using char-based CreateFileA
        API, which disallows opening any files with names not representable
        in current Windows codepage. Such hybrid PDF files would still fail
        creation of the file_iterator, and open as PDF.
        
        Fix that by further patching boost to have wstring-based constructors
        for file_iterator and mmap_file_iterator on Windows, which would call
        CreateFileW.
        
        Change-Id: Ib190bc090636159ade390b3dd120957d06d7b89b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160218
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [8a0015c35f3f137e4f3a80e40616bc078e265a1c]

        Drop allownonascii check from pre-commit checks
        
        Supposedly, at this day and age, it is OK to use non-ascii file names.
        Specifically, this is intended to allow such names for bugdocs, which
        allows simpler testing of problems with handling those.
        
        An alternative would be to rename bugdocs at runtime; but that still
        requires that the target filesystem supports such names, so...
        
        Change-Id: I25da2402f311d59c5777c4cd302147d6965dea5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160217
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [f93d70698220c9c1a16f470127d058f16e02440b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd2824ba5ee24accdeffea3518bd89cc194ed189
          - Document new SF Dataset service
            
            Change-Id: I4e6a792f2cbcbf826f51f5d62e6dad855d4a0bf0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160035
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-12-01  Jean-Pierre Ledure  <jp@ledure.be>  [07036eea5089feae511145412d7105cb76c1955a]

        ScriptForge (SF_Dataset) fix GetRows() in chunks
        
        Two bugs are fixed with this commit:
        
        1. when rows in a dataset are read in chunks,
           one record is skipped errorneously between
           every two successive chunks.
        
        2. In updatable datasets, the updatable fields
           need to be identified. This is done at
           dataset creation.
           Before: the IsDefinitelyWritable criterion was
                   used, valid for Firebird, not for HSQL
           After:  the IsWritable criterion is used,
                   valid for both.
        
        The correction in Basic is valid as well for Python.
        Documentation is unchanged.
        
        Change-Id: I990c02aaa8a93123a7e669b1294605fa19780167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160163
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-12-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c89c4ebe4924b0bc5b038bf2f114e1306caf1133]

        Prefer checked ptr to SdrPageView over unchecked
        
        Change-Id: I1610cb82681e415ba6e4a741ad46e5aa90148989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160201
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-12-01  Michael Weghorn  <m.weghorn@posteo.de>  [55097433ed766a2ced6b87021a71c8a31cde9d99]

        android: Shown warnings about deprecated API usage
        
        Configure the gradle build to show detailed warnings
        about the use of deprecated API, instead of just
        
            > Task :compileStrippedUIEditingDebugJavaWithJavac
            Note: Some input files use or override a deprecated API.
            Note: Recompile with -Xlint:deprecation for details.
        
        With this in place, 78 specific warnings about the use
        of deprecated API are now shown in the build output,
        which can be addressed at some point.
        
        Change-Id: I9f3b484b6dfad1fc57895efa7d3426b625030ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160198
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-12-01  Miklos Vajna  <vmiklos@collabora.com>  [f461853b11439c4e485a79174d34735395e5bf52]

        sw floattable: fix finding the nearest text in split flys on mouse click
        
        Clicking on the right of the floating table on the page 1 resulted
        in a cursor position on page 2 instead of a position inside the floating
        table on page 1.
        
        What happens is that the anchor text frame on page 1 is wide enough to
        contain the mouse click position, but then "before the first character
        of the paragraph" is on page 2, so a page 1 click results in a page 2
        cursor position, which is unexpected.
        
        Fix the problem by first ignoring which dummy anchor frames (all
        non-last ones) in SwLayoutFrame, so
        SwLayoutFrame::GetModelPositionForViewPoint() in
        SwPageFrame::GetModelPositionForViewPoint() fails for the perfect match
        case, and then later looking for split flys explicitly, so the corrected
        case finds the split fly on the page.
        
        I imagine this is not only useful for mouse clicks, but it's also good
        for everything else that uses GetModelPositionForViewPoint(), e.g.
        keyboard page-down.
        
        Change-Id: I761b211c1b5468d9d8996c59a32ac9be5b83a777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160194
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-12-01  Regina Henschel  <rb.henschel@t-online.de>  [44ee19c99bfb3bf0f550d9656e87bca3e20e5ca0]

        [API CHANGE] Add OOXML way of curved connector routing
        
        The paths generated for curved connectors are basically incompatible
        between LibreOffice and OOXML. Thus it was not possible to render curved
        connectors the same way as MS Office. The patch adds an OOXML compatible
        method for calculating the path. The new method results in a different
        svg:d attribute when saved in ODF, but needs no change to ODF.
        
        The patch introduces the boolean connector property 'EdgeOOXMLCurve' to
        switch between the two methods. The property value is determined from
        the svg:d attribute in case of import from ODF. In case of missing
        svg:d attribute the property value is set to 'true', because Word
        currently does not write a svg:d attribute when it exports to ODF.
        The property value is set to 'true' for import of connectors on a
        drawing canvas in docx. Default value for new connectors is 'false'.
        
        The new property has no UI, but can be used via macro.
        
        Currently the new method is used for import of curved connectors on
        drawing canvas in docx documents.
        
        Change-Id: I53d99f44febe4d74c2b611f5fdb9de86628c4519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159708
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-01  Miklos Vajna  <vmiklos@collabora.com>  [a83088b05f177fb938c2e4ffb06cd19362a5a1ca]

        sw: extract SwFootnoteFrame::dumpAsXmlAttributes() from SwFrame
        
        Allows getting rid of a static cast.
        
        Change-Id: I4784cf0335ab435a987963177b4812746f7c3b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160166
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-12-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4b0fa253a4540f5461397815d290586f9ddabe61]

        tdf#136472 adjust ooxml import to handle first header/footer
        
        Previously the ooxml import added a new page style when the first
        header or footer was detected. Since then we gained support to add
        first page header/footer in an existing page style so we don't need
        to import it like that anymore.
        This changes the import code so that the old complication to add
        "First Page" page style is removed and it always just uses the
        "Standard" page style for all 3 cases: first, left and right headers
        and footers.
        
        This also adjusts the existing tests to align with this change.
        
        Change-Id: Ibf69597e6990499ac520ea9e323a5f73f429800b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157860
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [93357349ff1998b41ea1ebedf09dc1cc5da316f7]

        Related: tdf#96401 Check ZIP magic number, to avoid false detections
        
        Change-Id: Ice077f35293a3d0f37c74911d5a6db7ccab5fb31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-12-01  Noel Grandin  <noelgrandin@gmail.com>  [facd5e4ef617f1adc1322dc17ce1ca15b7807d4f]

        move the SfxItemPoolCache to sc/
        
        and rename it to ScItemPoolCache,
        since its only use is to handle ScPatternAttr objects
        
        Change-Id: I68a2dd5f47fcf902f9df552e1a1767d5061d85d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-12-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [963de9feb37105560fde14b44d992e47f341bb5b]

        sw: fix issue with copying stashed frame format
        
        When the PageDesc is copied from one document to another, we
        don't make sure the stashed FrameFormat(s) are also properly
        copied to the new document (which can happen at copy/paste). This
        can cause a crash if the stashed FrameFormats are accessed or
        destructed after the original document is destroyed.
        
        This fixes the issue so that when we detect the PageDesc belong
        to different documents, the stashed FrameFormats are copied just
        like the non-stashed FrameFormats (used for headers and footers).
        
        Change-Id: I948068dba4d39bb47c3725dfa8491c53c5833c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160065
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-30  Laurent Balland  <laurent.balland@mailo.fr>  [619500d6919c227e734b119481a4b334972e0b7b]

        Impress templates notes: correct preview size
        
        In Notes mode, these templates have a preview of 4/3 ratio. Change them
        in 16/9 like the slides
        Unification of preview and notes position and size
        
        Change-Id: Ie088b2226e438476cf421f6351c3bd617e7e6bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159876
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-30  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [596c53b06cbb33d312d58572b61e966e913109f3]

        Make ScOutputData::DrawSelectiveObjects compatible
        
        The implementation was not aware of the used functionality
        in the used call to SdrPageView::DrawLayer: The given
        OutputDevice is *not* intended to hand over a new render
        target, it's used to allow the mechanism(s) to *identify*
        one of multiple possibe registered render targets (which are
        usually OutputDevice/SystemWindow). It is even the default
        to call these method(s) with a nullptr which means to repaint
        all registered OutputDevices/SystemWindows. This is no
        tooling intended to repaint parts of a View to 'any'
        OutputDevice.
        
        This is not very obvious and there are already other places
        in the office that do that wrong and never got cleaned-up,
        therefore also being fallbacks to not just let those cases
        fail, but at least paint something (and give you a warning).
        
        The caveat is that these fallbacks (e.g. in
        SdrPageView::DrawLayer) have to use temporary SdrPaintWindow/
        SdrPageWindow instances to make the paint work. Especially
        when a temporary SdrPageWindow is used an evtl. existing
        VC/VOC/OC structure will not be used and with it also not
        the existing primitive decompositions.
        
        I thought about bigger changes in PageView/PaintView/
        PageWindow/PaintWindow area to sort that out, but this is
        - despite being utterly necessary - too expensive for now,
        keep a note about this needed change for the future.
        
        For now I will just use an already (also for this purpose
        already existing) 'compromize' that will do it for now.
        
        Change-Id: I8c7ccee1deb0d69aad1d2145a7ac2039aca685b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160155
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-30  Julien Nabet  <serval2412@yahoo.fr>  [96b15a13e9654b399e63661c66df3df6069a6f8f]

        resave with latest glade (columnpage.ui)
        
        Change-Id: I248c742f5ff0395de0a15c95c1a439eeecee0b6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160165
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-30  Laurent Balland  <laurent.balland@mailo.fr>  [95779d24f012b9f21d1890f433bd12a4f3d903c8]

        tdf#158230 Growing Liberty template: restore preview
        
        Move Title-Slide master page at first place to get it from Master page
        Side panel
        Move picture from background of master page to image at the back
        Other updates:
        - remove unused fonts
        - remove English text "number"
        
        Change-Id: I8e6567ec3661ebce8ccd08f97d3661b1994c3ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159691
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-30  Laurent Balland  <laurent.balland@mailo.fr>  [58a3ca303c95ccf54c107cfe3f751ad147b52511]

        tdf158206 Nature Illustration template background
        
        On first master page, move picture from page background to an object at
        the background
        
        Change-Id: I0f288396f63230fc0fe524b3e30f6d1fc4d7ef11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159808
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [9c22a72a2fc92146d24c6b673d9c07b1e6ff83f2]

        tdf#158459: call DeleteAndJoin in strict reverse order
        
        The crash was caused by removal of a paragraph break (pointed to by a
        PaM returned by pDelPam->GetNext()), that resulted in merge of the node
        pDelPam pointed to, with the previous node. The destructin of the node
        made pDelPam dangle. In debug builds, an assertion failed in destructor
        of SwContentIndexReg. I.e., since the code always called DeleteAndJoin
        on pDelPam->GetNext(), the processing went from second-to-last deletion
        towards the begin of the document, and the last deletion (represented
        by pDelPam) was handled last, when GetNext call wrapped.
        
        This change makes sure that the order is strict, from last to first.
        
        Change-Id: I5cb7fe2f06d4138d3c445eeca8220f0a87a82626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160158
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [865033f18e5759bc8f45d72088ace753ae69ffb2]

        android: Add make dep to update build ID more reliably
        
        So far, the build ID in liboSettings.gradle, and
        therefore in the about dialog in Android Viewer
        was not reliably updated in incremental builds.
        
        For example, after a full build, then
        
            git commit --allow-empty -m "Dummy"
            make
        
        , the build ID would still refer to the commit
        from the full build, not the new dummy commit.
        
        Since `instdir/program/versionrc` on Linux
        and `instdir/program/version.ini` on Windows
        gets updated properly, add an optional make
        dependency on these files, using a wildcard.
        
        Change-Id: If3b1d4d811a5e4316a26bb17f246b66858dcf80f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160157
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Julien Nabet  <serval2412@yahoo.fr>  [13366298ed648478cd421c61c44b701221db8d08]

        Gtk-WARNING Could not read property GtkBox:pack_type
        
        ...with value begin of type GtkPackType: Could not parse enum: 'begin'
        
        To reproduce this:
        - launch Writer
        - menu Format
        - choose Columns...
        
        Change-Id: I591d925f1375ffbc5583ea8f6a4470a6721174c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160141
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [35b7aa3a865eda90bec945ac2e11b20a75a37bd6]

        android: Separate build ID and vendor from versionName
        
        So far, the versionName for the LibreOffice APK/app bundle
        included the build ID and vendor, was e.g.
        "24.2.0.0.alpha1+/2972af9045a5/The Document Foundation".
        
        That versionName would be split again to extract the build ID
        and vendor to display them in the about dialog.
        
        No longer include build ID and vendor in the `versionName`,
        but use separate build config variables, similar to what
        is done for the privacy policy.
        
        This slightly simplifies the code for the about dialog.
        
        But more importantly, the previous `versionName` scheme
        would make it impossible to automate the F-Droid update
        of the app, because the scheme is not compatible with
        the expectations of F-Droid's update mechanism, see the
        F-Droid merge request to update LibreOffice Viewer to 7.6.3 [1]
        for more details, in particular the (eventually not merged)
        commit [2] mentioning what manual steps would still be needed
        when trying to semi-automate the update at least.
        
        [1] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14080
        [2] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14080/diffs?commit_id=bfc062a358dc574326a29f08e01c0e80cadd80cb
        
        Change-Id: Ibede06d13095d8e83dcc88ee09a8a610d6a9de0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160150
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [da82f0b5de5b5ad467a981599e4aa0680fadcdee]

        android: Drop trailing whitespace in Makefile
        
        Change-Id: Ic68471bbbc18e5fa0a66dbf57e3e7156ef824e50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160149
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [3ee963afc7dfae473d5368e88a2caa847f7450f8]

        android: Simplify vendor info handling for about dialog
        
        Similar to
        
            Change-Id: Iaa78f5a6020bea4ed80a1b41d3b23cc8d313813c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Nov 30 12:00:52 2023 +0100
        
            android: Simplify version info handling for about dialog
        
        , also simplify the handling of the vendor info text by
        retrieving the text from the string resource right away.
        
        Change-Id: I7d56b1814454be2bc8d13e01265f0a0db6d865be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160147
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [4958e21332c19a8bc1704ff71489c2c991efb05c]

        android: Simplify version info handling for about dialog
        
        * Don't set and retrieve the placeholder text in/from
          the TexView in the about dialog, but use the string
          resource directly.
        * Add the HTML code directly in the string resource,
          rather than having to fiddle with that in the Java
          code.
        
        With this in place, only the version name and the
        commit hash need to be replaced.
        
        Since there is no placeholder text in the text view,
        it's also no longer necessary to explicitly set an
        empty string in case of an exception.
        
        Change-Id: Iaa78f5a6020bea4ed80a1b41d3b23cc8d313813c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160146
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f824c4f23c01510b12b53f33778bfa72f7a2ea57]

        Extended loplugin:ostr
        
        Change-Id: I987d6d60ca2d1e8ed8b8cde1e0c7996c0fff71b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160006
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [266a0e72e8382f0b72fa7b1127ce8712103aa562]

        android: Remove 'build' dir in 'clean' make target
        
        Add the build dir (`android/source/build`) to the
        directories to be removed when cleaning.
        
        Previously, this was't cleaned, which could be seen
        e.g. by the fact that a fresh build would result in
        this warning being shown
        
            > Task :compileStrippedUIEditingDebugJavaWithJavac
            Note: Some input files use or override a deprecated API.
            Note: Recompile with -Xlint:deprecation for details.
        
        while a
        
            make android.clean
            make android
        
        after a full build wouldn't.
        
        Change-Id: I00a4f8b1fda9fbefb3b8f806b1997eceded117fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160145
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Julien Nabet  <serval2412@yahoo.fr>  [b4ff86cf73d6e488e96387cc726934ac892901be]

        Use "set logging enabled on/off" instead of deprecated "set logging on/off"
        
        With GNU gdb (Debian 13.2-1) 13.2, I noticed this trace on console when using --backtrace
        
        Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated.
        Use 'set logging enabled on'.
        
        Change-Id: Ic03911ea94aff57dee8f594744147302ef01a1ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160143
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-30  Khaled Hosny  <khaled@libreoffice.org>  [fdbf404073bd4a59dc0378418cad297a547d5dd4]

        vcl: Fix comment
        
        The comment is saying the opposite of what the code is doing.
        
        Change-Id: I16cc44b56f90f622cedb87b9107d17b940665896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160144
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [68ccc26f64632e0af66ff18d164aa39468ad3a2d]

        android: Update com.google.android.material:material to 1.10.0
        
        Depends on the previous commit
        
            Change-Id: I2778d8c181daa92530c769a168a9e186b6ea079c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 29 13:33:33 2023 +0100
        
                android: Update compileSdk/targetSdkVersion to 34
        
        Change-Id: Ibdb7e002d599d42256290febc422cf86b2694d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160087
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [97166cb9e0b4687f7e4998d36457f74b76edb6d7]

        android: Update compileSdk/targetSdkVersion to 34
        
        API version 33 refers to Android 14.
        
        I didn't notice anything requiring changes
        when going over the release notes for all apps running on
        Android 14 [1] and apps targeting Android 14 [2].
        
        (Taking a look whether making use of the new possibility to
        request/grant partial access to photos and videos [3]
        for the "Insert" -> "Select Photo" feature
        and testing the app with the newly available 200% text
        scaling [4] might make sense at some point, but is unrelated
        to bumping the versions as done in this commit.)
        
        [1] https://developer.android.com/about/versions/14/behavior-changes-all
        [2] https://developer.android.com/about/versions/14/behavior-changes-14
        [3] https://developer.android.com/about/versions/14/behavior-changes-all#partial-photo-video-access
        [4] https://developer.android.com/about/versions/14/behavior-changes-all#non-linear-font-scaling
        
        Change-Id: I2778d8c181daa92530c769a168a9e186b6ea079c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160086
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [8fea1b20383574dd1be86c3dbad20361604c9828]

        android: Update Android Gradle Plugin to 8.1.4
        
        This is a prerequisite for updating the compile and target
        SDK versions to API level 34, which requires and AGP minimum
        version of 8.1.1.
        
        Change-Id: I27d12ec3c9bc3dac8a5df18459a57f1a1e990197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160085
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [cebf1b118788ee080e3888115abbeb2e42a7fd15]

        android: Use 'compileSdk' instead of deprecated 'compileSdkVersion'
        
        See [1] and [2]. From what I can see, they are equivalent
        for our use.
        
        This addresses a "'compileSdkVersion' is deprectaed." warning shown
        in Android Studio.
        
        [1] https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/CommonExtension#compilesdk
        [2] https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/CommonExtension#compilesdkversion
        
        Change-Id: I9a7416d8b3750a5f8f8281c6e226fc7bbe665776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160084
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [c33c375b90ac6ec4d0d339486ac779d6d7b441e5]

        android: No longer extract native libs
        
        As described in more detail in
        
            commit 45fbfbfeae1de12e87d0a3748e22553b69adbc4a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Mar 27 17:04:37 2020 +0100
        
                tdf#131622 android: Extract native libs again
        
        , extracting native libraries was necessary for the NSS
        library to be able to load modules like `libnssckbi.so`
        at runtime. Without this, opening password-protected
        files would fail.
        
        However, this has in the meanwhile been addressed
        differently in the following commit (probably in the
        context of the online-based/Collabora Online app), so
        extracting libs is no longer needed:
        
            commit 16a7f98f99d334ea865b800e0b32d6fed1483942
            Author: Mert Tumer <mert.tumer@collabora.com>
            Date:   Wed Sep 30 17:14:59 2020 +0300
        
                Fix libnssckbi not found error on Android
        
                This error causes Android App to be unable to
                open Password-protected documents.
        
                Change-Id: Iacbacb1c780025752e2447db325b075c58947818
                Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
                Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103658
                Tested-by: Jenkins
                Reviewed-by: Andras Timar <andras.timar@collabora.com>
        
        Therefore, no longer extract the libraries, which also addresses
        addresses this warning shown during the build:
        
            > Task :processStrippedUIEditingDebugMainManifest
            .../android/source/AndroidManifest.xml:16:9-41 Warning:
                    android:extractNativeLibs should not be specified in this source AndroidManifest.xml file. See https://d.android.com/guide/topics/manifest/application-element#extractNativeLibs for more information.
            The AGP Upgrade Assistant can remove the attribute from the AndroidManifest.xml file and update the build file accordingly. See https://d.android.com/studio/build/agp-upgrade-assistant for more information.
        
        Change-Id: I867beea0bce8398806375048e87a152e1348d016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160079
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [fa1f867caca9e5c6c0dbd4bcaf096f27077f363d]

        tdf#124480 android: Set bg color for calc formula bar
        
        For the layout containing the Calc address/formula bar,
        explicitly set a background color that matches the theme.
        
        Otherwise, those text views would be using white font on
        white background when using dark theme, making the text
        unreadable.
        
        Change-Id: I5fdf9e04f8bb331ca6a57bf3046a7ebb9ccb0d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160078
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [c82a594da3189fe82052f8081fda16e9e3cb0c0f]

        tdf#124480 android: Avoid using color attr requiring API 23
        
        Using "colorBackgroundFloating" requires API level 23 [1],
        but our current minimum API level is 16 (when building with
        NDK 23).
        
        Therefore, define an own color `background_floating` instead
        and use the correspodning color values from the material theme
        (`background_floating_material_{dark,light}` depending on whether
        dark/night mode is enabled or not.
        
        This makes the app work again in a quick test with an x86 AVD
        with API level 16 instead of crashing on startup.
        
        Change-Id: I7b8378b42e9fc7430ec4ed263d4cb8b42027a930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160077
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [322f8e8cb7d103a6666ceb212d43929aab2f111e]

        tdf#124480 android: Use an actual button for "Select file to open"
        
        Instead of using a TextView and setting `?attr/colorButtonNormal`
        for the background color, just use a button right away, which also
        makes sure that the proper button color is used and avoids
        using `colorButtonNormal` only available from API level 21 on. [1]
        
        Also drop the extra `LinearLayout` parent that was only containing
        this one TextView.
        
        While at it, drop an unused import.
        
        [1] https://developer.android.com/reference/android/R.attr#colorButtonNormal
        
        Change-Id: Ie2f7e2646d20f4051fb2513fb8fd72572ce19217
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160076
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [31a689b83112bfa057c2f7f8306b875b9a2ac7c7]

        tdf#124480 android: Use themed color for icon on start activity
        
        Similar to how
        
                Change-Id I2061878067d21dcd743ad6ca8d1018db323755d6
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Tue Nov 28 14:22:54 2023 +0100
        
                    tdf#124480 android: Use themed color for more icons
        
        did for the icons in the toolbars, use the themed color for
        the directory icon in the start activity as well.
        While at it, switch to using the same shade of gray that
        the toolbar icons also use.
        And rename the icon to drop the "_grey" suffix, since this
        is now themed and no longer using a hard-coded color.
        
        Change-Id: I9fcf51b712a01aab3b9754bcfbd817c89171a64f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160075
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [59093ecb1cdf0ba8c946dfdbe0ec7ee0e89cd6f6]

        tdf#124480 android: Rename icons no longer using hard-coded color
        
        As already mentioned in
        
            Change-Id I2061878067d21dcd743ad6ca8d1018db323755d6
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Nov 28 14:22:54 2023 +0100
        
                tdf#124480 android: Use themed color for more icons
        
        , do this:
        
        > Given the icons are no longer hard-coded to be black,
        > the files with a "_black" suffix will be renamed in
        > a follow-up commit. (Separate commit to keep the
        > diff clearer.)
        
        Change-Id: Ie2d3433934569dc97530a35d88bda01802af96b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160074
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [f37dcb43c0373e75e92fabd82b4f2a17b1fe6055]

        tdf#124480 android: Use themed color for more icons
        
        These icons used in the toolbars were previously using a
        hard-coded fill color.
        Most of them were using black, but `ic_line` and `ic_rect`
        used in the "Insert" tab of the bottom toolbar, were
        previously using a lighter gray than the other items in there
        for no apparent reason.
        
        Switch all of them to use the themed `toolbar_foreground`
        color that other icons are also using.
        
        Together with
        
            Change-Id Ic699fd1cecc607bd5e748648113336fe045e72b1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Nov 28 13:13:12 2023 +0100
        
                tdf#124480 android: Override icon color for dark theme
        
        , this makes these icons use a light color when using
        the dark system theme.
        
        Given the icons are no longer hard-coded to be black,
        the files with a "_black" suffix will be renamed in
        a follow-up commit. (Separate commit to keep the
        diff clearer.)
        
        Change-Id: I2061878067d21dcd743ad6ca8d1018db323755d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160073
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [fbca561b97e9669d6a2eaaf7db8c629036a393a0]

        tdf#124480 android: Drop unused icons
        
        Change-Id: I811d9190c0c163db93ec981855f735d47e071cbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160071
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [26d06d6c881a0decb25b82eae1cee42fc6bc6a31]

        tdf#124480 android: Override icon color for dark theme
        
        Add a `values-night/colors.xml` that can be used to
        override the colors specified in `values/colors.xml`
        specifically for the dark theme.
        
        Specify a light color for `toolbar_foreground`,
        which is the color used for (most) toolbar icons,
        both for the top-level as well as the bottom
        toolbar.
        
        This makes most icons show up in proper contrast
        when using dark mode. Others are not making use of
        the color defined here and will have to be looked
        into separately.
        
        Change-Id: Ic699fd1cecc607bd5e748648113336fe045e72b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160070
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [84996f452f86cb6e83ae0d86c1612e3f3c616a17]

        tdf#124480 android: Use theme bg color for bottom toolbars
        
        Instead of hard-coding the background color
        for the 2 toolbars shown at the bottom
        (`toolbar_bottom` and the color picker), use
        "colorPrimary" from the theme.
        
        Stop overriding "colorPrimary" in
        `LibreOfficeTheme.Toolbar`, which would otherwise
        result in a hard-coded white color being used again.
        
        This makes those toolbars show up in a darker color
        when dark theme is enabled.
        
        Stop hard-coding the font color of the items in
        the "Style" tab in the bottom toolbar to black, but
        use the primary font color instead, so a light color
        is automatically used when using the dark theme.
        
        Change-Id: Ib09ca47e8695903cdfa9f4eb100dc88ecae652a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [d82a9cb8d6a1e11663f19a85cfb98ce9a94692be]

        tdf#124480 android: Support dark theme
        
        Support dark theme by inheriting from the
        corresponding "AppCompat.DayNight" themes rather than
        forcing the use of a light theme by using the
        "AppCompat.Light" variants, s.a. [1].
        
        With this in place, the app will automatically use a
        dark theme for the Android UI controls when that's
        enabled in the Android system settings.
        
        Toolbars and menus mostly look as expected.
        The bottom toolbar will be handled separately.
        Icons will also have to be adapted in a follow-up
        step to provide for better contrast, since they're
        currently designed for light mode/white background.
        
        [1] https://developer.android.com/develop/ui/views/theming/darktheme#themes-styles
        
        Change-Id: Ia08edcc9d22b93caa67b146dcf90ee5fd02ee550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160068
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [9e7df5bdf2c0e9585f01c16bbb5a377fe64299ca]

        tdf#124480 android: Replace hard-coded bg color with themeable one
        
        or drop explicitly setting background color where the
        one from the parent widget should be used.
        
        See also
        https://developer.android.com/develop/ui/views/theming/darktheme#themes-styles
        
        Change-Id: I21dc4b7c45e2cc5add96d603abe5e781d4e09992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160067
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Michael Weghorn  <m.weghorn@posteo.de>  [10cdb834281c0c37e6966173e67150e39917ccd7]

        tdf#124480 android: Use MaterialToolbar and drop manual bg color
        
        This ensures these 2 toolbars will also use the correct color
        in dark mode once support for that is added in a subsequent
        commit.
        
        Change-Id: Idcea5096c4e4bdf8ddc6b28df0fc6df05074980b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160066
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [3f22de75b333c5073bc715b7f8c62048f3791c51]

        Update git submodules
        
        * Update translations from branch 'master'
          to 994b9356742bd38a188a376d41fca1bd9d0fa396
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I0f72d1c24f7afc10c6e48b7c6eb8cac811c7a325
            
2023-11-30  Heiko Tietze  <tietze.heiko@gmail.com>  [48ba98a51f029cd14b5d982dab36eb581d40fef3]

        Resolves tdf#158412 - Don't show chevron in quick find bar
        
        Change-Id: I50f0bb7d8a406b77baccc626ca99b656d170ecf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160093
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-30  Heiko Tietze  <tietze.heiko@gmail.com>  [fe946f86ad6586fa810cae5c0f246389a285e172]

        Bump Glade version
        
        Change-Id: If440010790e170fa1c88b8cbdef5f7eaa3efd686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160108
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aa0604e81d2cafe500c3f0649c9d14d8d786ec46]

        cppunit test for notification of note position changes on row/col changes
        
        Change-Id: I32ed5cd249400f71903e7aa848ba63d03abbd9b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d9e9caf2ea2a42c09623d69c858921462aeac00e]

        No kit notification of note position changes on insert/delete row
        
        while there is for insert/delete col.
        
        Inserting/Deleting a column will explicitly update comments as part of a
        bulk operation and block the drawing layer from updating any existing
        captions before that. A side-effect of this is that the note captions
        are generated for all comments in the moved cols when this happens.
        
        While with a row the drawing layer is allowed update existing caption
        positions and doesn't generate any new captions.
        
        Presumably there's a missed optimization for insert/delete cols to
        not generate extra captions that didn't exist before the change, but
        leave that aside for now and add a UpdateNoteCaptions that just
        notifies of note position changes when rows are inserted/deleted and
        continue to piggy back on the note caption update for insert/delete
        cols.
        
        Change-Id: I4d76d15aee1de9ea5553e90b2051354bce02b1db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160138
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [baf36dc7caa10365f3dda87bc2dd6e85e0333e98]

        Extended loplugin:ostr: hwpfilter
        
        Change-Id: I1cd5359c192897d3d497eec977de10cedcc8f7b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160120
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f20425e6de89411ec1d63d04d8d51e1710a6f375]

        Extended loplugin:ostr: oox
        
        Change-Id: Ie6db1edbad5305e4935a9fdc03dab36861bf2c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160112
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [a492775fe2a7f408eb2ca96f632860d0f9c4a70f]

        Extended loplugin:ostr: i18nlangtag
        
        Change-Id: I9e5b989f0508d1479572523ab6929828f0f1b85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160119
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [52a8d560d814f3c3c9594e072cfa3b98373740a8]

        Extended loplugin:ostr: l10ntools
        
        Change-Id: I259867d548c3a6b5322d38584270a325b93f1776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160117
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [bc012f13d581bcc7cb413e0daf76f2d37b1dfb1d]

        Extended loplugin:ostr: codemaker
        
        Change-Id: I7addfbde8ee8603eb8ca692debb2ac369347c6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160127
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-30  László Németh  <nemeth@numbertext.org>  [93ab1bc6be7b46226874810ec4fc3c61d5d0fc7c]

        tdf#158419 sw: revert lost unit test testOfz64109
        
        which was removed accidentally by commit 20cbe88ce5610fd8ee302e5780a4c0821ddb3db4
        "tdf#119908 tdf#158419 sw smart justify: fix cursor position".
        
        Change-Id: Ia96d9d8d8980dbf05aaa58d454e2d9b568555d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160129
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-30  Miklos Vajna  <vmiklos@collabora.com>  [eb077be775237d5f2584d422f9abc5c86120a183]

        CppunitTest_sw_ww8import: avoid external fonts
        
        - sw/qa/extras/ww8import/data/tdf124601.doc:
          - replace 'Open Sans Light' with 'Noto Sans'
          - replace 'Open Sans' with 'Noto Sans'
        
        Change-Id: I3f3018d9d2a216b8ddb1d26cab845b27f0f7e9f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160128
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-30  Noel Grandin  <noelgrandin@gmail.com>  [1932a549b239be7a7555453516190d3e2846593b]

        use more SwTwips in CalcSpacing
        
        Change-Id: Ic7409c2993014f97531f3d77533cf7a82712707a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-30  DaeHyun Sung  <sungdh86+git@gmail.com>  [f86f7f6e156ce0befccebff5c6a4eff8bd80d2a5]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to fa49c03d49f52ea0efc9adf589ff707433878d53
          - Update the Korean Dictionaries: ko-KR
            
            Update Korean dictionary file (ko_KR.dic) by DaeHyun Sung (2023.05.14)
            Also, update readme description
            
            Change-Id: Iebaad8c33d8a94bfa4e7427c0a3d218ea4d7c109
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/151732
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-30  Kevin Suo  <suokunlong@126.com>  [34fe1610cb98a7e57c6719a5d4f88d90a6c8752a]

        Sync LC_OutLineNumberingLevel of zh-CN with en-US locale
        
        The previous order makes the UI tooltip does not match with the
        numbering style shown, per tdf#148023.
        
        Also add a commonly used Chinese-specific outline numbering style.
        The other old styles with the Chapters and Sections etc are removed
        because they are useless.
        
        Change-Id: I585cd0e704af35125c7c38561f500e83f1a465dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160081
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2023-11-30  Kevin Suo  <suokunlong@126.com>  [6fffa9fdf2ad2c93c319ab662d3993b89c0a24ba]

        tdf#152583 follow-up: Sync LC_NumberingLevel of zh-CN with en-US locale
        
        The previous order makes the UI tooltip does not match with the
        numbering style shown, per tdf#148023.
        
        Also re-arrange the remaining Chinese-specific styles to make the most
        commonly used ones come first.
        
        Change-Id: I913180b1ca385e8a604b16b63ebfa130aca059c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160080
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2023-11-30  Patrick Luby  <plubius@libreoffice.org>  [3b942f6efa8ffd11374031e4af8dbcb48a8962d1]

        Related: tdf#155092 translate Y coordinate for height differences
        
        When in live resize, the NSView's height may have changed before
        the CGLayer has been resized. This causes the CGLayer's content
        to be drawn just above or below the top left corner of the view
        so translate the Y coordinate by any difference between the
        NSView's height and the CGLayer's height.
        
        Change-Id: Iac13fa8374977e098f8311c55e182ef5a5ebec30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160131
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-11-29  Eike Rathke  <erack@redhat.com>  [0c3f57487c9cc29d172121b178938cdb2a8adc7b]

        Resolves: tdf#158265 Store more than 100th seconds precision in date+time
        
        e.g. office:date-value
        
        Change-Id: I9bb4b589cdb8c6f04fa39ba7ec4254207eaa3663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160124
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [79e8833305b9cedce4ebbcabc573866e22040b72]

        Extended loplugin:ostr: comphelper
        
        Change-Id: I43baf9248f607b13720da4295eb2827b3f58b3f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160126
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [02fd70fb1c9578351919d82100047c03be97934c]

        Extended loplugin:ostr: connectivity
        
        Change-Id: Ibbfb8945754713721c4e9ab9d8015c111c1307be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160125
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [83a5eedb7010c236267fcca5cfac4978b9900801]

        Extended loplugin:ostr: desktop
        
        Change-Id: I4d61b086c2152fec137fd979677729647bb6fd16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160123
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Gülşah Köse  <gulsah.kose@collabora.com>  [c9bae2d26ed065bad1e490815a7606435cf63556]

        Online: Put the image width height info into json.
        
        When online's image render is delayed we don't have any image size info
        so getting 0x0. To show better result we need that info into message.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: I28f345cdd64de5fa47b3b1054330e606e7b32f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160106
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [966bf32c4f160b25506a14c772125e5ff50314c0]

        Extended loplugin:ostr: filter
        
        Change-Id: I900c7e070f9830b3da1dbcce75d418a75652d1ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [44ddd6e586a17c90be2ecda7a99770a438996597]

        Extended loplugin:ostr: sdext
        
        Change-Id: I0f3e683c4cf3ebb22c003c481169468722ab9e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160101
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5cfca5914605e89ce8d883e820a782d8311ed27b]

        backport skia "Avoid combining extremely large meshes" fix
        
        Change-Id: Iaedd03ba4014b133bc28a4b0a6a7b6aaaaa39a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160114
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [19ea4aaddca56b1642d5db21edfe5503c93c93b7]

        Extended loplugin:ostr: i18nutil
        
        Change-Id: I9d7ab34967229087e4fa52b6714b6b75d6c4d196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160118
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Henry Castro  <hcastro@collabora.com>  [3275f57221904426e5c136f5596a83050f8585a4]

        sc: qa: add unit test "testBackColorFilter"
        
        Change-Id: Icdccd6778d1157bb31f38b510a58562a640bdeae
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159929
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160089
        Tested-by: Jenkins

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [24cc5f55a04eeb6a9f286066c1389191b153a910]

        Extended loplugin:ostr: ucb
        
        Change-Id: If6f818506ef7a596a6ea3af4185859b09c6d4d75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160096
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [f4ce98bd1a1b183bb21c60b85e17dc6575f9ce98]

        Extended loplugin:ostr: sc
        
        Change-Id: I2b69249d6e0e35945e37e04ea885bb8ab3e781f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160103
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [9bccf92aba991366952261e51183455efa67da13]

        Extended loplugin:ostr: sal
        
        Change-Id: Ieca8096e2af9615fa4c34557a47bc13ee5c23936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160105
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [692a116c27ea24d3245d38fe5063d8f84c07f7f2]

        Extended loplugin:ostr: xmlhelp
        
        Change-Id: Ic8247396b1cd2152cdac6e3728d1828bea6f452c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160094
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [2c1e01b22514ec86ec120cb1ea3dd458a544fbdb]

        Extended loplugin:ostr: sw
        
        Change-Id: Ie3ceb8d4b939a652d09cc9cf02b78e65093c8fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160099
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [cb7dc5a0cf0f9199873d8eea012b4fd69f3a9af7]

        Extended loplugin:ostr: svx
        
        Change-Id: Ia3ff6c27bdb4c59fa20c976c4ca4cdee12f1c91c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160100
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [e35d67b4901b6c1a74d0fb5d452a6bea8dc58e66]

        Extended loplugin:ostr: vcl
        
        Change-Id: Ia9e958deec9716e38381a027451d5ee821efe23d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160095
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [93a2d90ee04a11f85b30f157b7d7d6bc128e99f1]

        Extended loplugin:ostr: test
        
        Change-Id: I75974611446486415c8b19b3723761ab1bb46c74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160098
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [b5ef7455a6f1cf608501e4360be7ea54ff13feb2]

        Extended loplugin:ostr: sd
        
        Change-Id: If78b217698bd63895c6466744495ee22be8debc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160102
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [1e6cb9302d6ab3341d8102fc84f37e1149b27985]

        Extended loplugin:ostr: sax
        
        Change-Id: I7ee95e170b09a5a6765042ede50218332a822c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160104
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15ea67e549507f71b4367b7709339e61ba780c92]

        Remove duplicated include
        
        Change-Id: Ieea181852d18be586d50b049c46f2bdc4324183f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160092
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-11-29  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3bc5f0a38ac1708817d3e61a74fa40a22c099664]

        Extended loplugin:ostr: tools
        
        Change-Id: I7a585370b7d2a8021b733984e605cae8cc92c774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160097
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [828f3b9a2432ab9d1d2c11a7aaabebe112d20f13]

        Fix typo
        
        Change-Id: Ib7a9d442c90f628b9d82e7e714c1c59dc576b891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160091
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8bf1fbd2023945cfe7e86b85470669fd378fd4a3]

        Fix typo
        
        Change-Id: I1ca85b9f1424df5432c76d08280b9dba3e01d2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160090
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-29  Stanislav Horacek  <stanislav.horacek@gmail.com>  [de267598a65d4ca1386c422b70e7798e7d68403e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c2b0a0e7c74c629ee248244fbf083314e076bd8
          - mark method syntax as untranslatable
            
            Change-Id: I0740ba3e65dc5c4d6050d2a56521cbd994700eca
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160062
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-11-29  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [17b03ab7da52cd528e7209bb6c2343b2f1cdcf64]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f2ed56c7a3e1b11a2498b62fa14fa596438b3c8
          - Code Completion requires Use Extended Types
            
            even though it is mentioned in the last section.
            Also, fix two typos.
            
            Change-Id: I2ccc2b6f1cd5bab7975ae151a29b7477af8e3c83
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160033
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-29  Henry Castro  <hcastro@collabora.com>  [8b2369236dea7d6863c2df3d4ce5e356c9c8010c]

        sc: fix back color filter entries
        
        The function "GetFilterEntries" iterates only that contains cell
        data value entries, the background color filter feature requires
        to iterate background color attribute which is not stored in multi
        type vector cells.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I372db48d2399f62712f642eefdbfea8885b09f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159864
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 826eae46095b2184554565bab1792e96964a720f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159905
        Tested-by: Jenkins

2023-11-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [05f60be48a51a64ce99a7a7b62ae030002b16a14]

        tdf#158245 - UI: Part 46 - Unify lockdown behavior of Options dialog
        
        for Draw - Print Page.
        
        Change-Id: I9c5004253b0b871a14fe92475339cdad598491a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160027
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6096a4913d6510929e007c6ef96e1cdbaeadae22]

        cid#1554876 Use of auto that causes a copy
        
        Change-Id: I8218a4371f0b002d8ef4d544bf9227db6684915f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160012
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-29  László Németh  <nemeth@numbertext.org>  [78872cc81bf4b1377c9cae8f9040a2443d0690c0]

        tdf#157768 sw: fix lost character background of NBSP
        
        Regression from commit 28675af84ae8e2342bd78be3696dc09de6ce5cc5
        "tdf#41652: Variable width NBSP".
        
        Change-Id: I066ecadac8961b182f8580147b197f13dd0daae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160054
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-29  Miklos Vajna  <vmiklos@collabora.com>  [ce2fc5eb29b4e252993b549dee002fa8948c8386]

        tdf#158341 sw floattable: fix layout loop when fly is below the body frame
        
        Regression from commit 25b8fdd3b939a221ba00ca37fbf89adaf893aab7 (sw
        floattable: maintain the invariant that fly height is at least MINFLY,
        2023-09-28), the document started to layout-loop on load.
        
        What happens is we have a fly frame where the bottom of the body frame
        is above both the top and bottom of the fly. We used to make sure these
        flys don't "flip" (with a negative height) and ensure that their height
        is still MINFLY. But that causes a new problem, because the layout will
        try to make sure they fit, but they can't have enough space.
        
        Fix the problem by improving the correction of the fly height, so in
        case even the top is below the deadline, then we set the height to 0 and
        explicitly mark the frame as clipped. That keeps the unwanted warnings
        about violated invariants fixed and fixes the layout loop.
        
        The test just ensures that all pages but the last one has a single
        multi-page floating table, chained over several pages.
        
        Change-Id: Ibac0a465839a59abe5ae49809c0d76c955aa39b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160061
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2bf8231ab5709f0d7577d6da53f50bc7f0b65079]

        tdf#158244 - UI: Part 45 - Unify lockdown behavior of Options dialog
        
        for Draw - Grid Page.
        
        Use the right grid settings associated with the application.
        follow-up of fbecf8009af8abdd218fbb3bd26087e8b805d06b
        
        Change-Id: I30b3c7ad80348a9cc89b6ea206a8ad9387276593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160020
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [34d3f383b62ebd87f842e48e6627dbf5ed369667]

        tdf#158243 - UI: Part 44 - Unify lockdown behavior of Options dialog
        
        for Draw - View Page.
        
        Change-Id: If06945482e5a441903d6eb44b66242bd8806bcd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159995
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b62b4021fb91e4f18a0b8eceace52046948a74e]

        cid#1555536 Use of auto that causes a copy
        
        Change-Id: Iae373b1aa5c25732b0e459778e4e85a3e96f138c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160013
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [66452607f5cbd81570442e646f76eff343cf0986]

        cid#1554867 silence Out-of-bounds access
        
        Change-Id: I11acf38f1243e1eea180b478055f12839c58f551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160015
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bbbb509c3e3d2afa12392c521c382fb70c43d0a5]

        cid#1557589 Use of auto that causes a copy
        
        Change-Id: Ie2c790420ce5fe2e2804f33ff552c2252dc0cc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160014
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [da6547ff87d384d016619967359fe8bf340d1daf]

        remove fallback code
        
        we have had this assert for long enough now to flush out any problems.
        
        Change-Id: Ib732ca8d9156feb3c5d071cdbd44ea97875f6d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-29  Kevin Suo  <suokunlong@126.com>  [22d8f339197b23348e401bb3e9dd7430110dfba6]

        tdf#152583: Add [1],[2],[3] numbering style for zh-CN locale
        
        This adds the [1],[2],[3] style of numbering to the Simplified
        Chinese locale data. This will show up when one clicks the
        numbering toolbar icon.
        
        Change-Id: I8b54746b431384e682f4161a3e99211b4147bad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160059
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2023-11-29  Miklos Vajna  <vmiklos@collabora.com>  [7f85266b390aaf784af6a8d4afa139cd1b6988e4]

        CppunitTest_sw_ooxmlexport16: rework to avoid preTest()
        
        This keeps all code of a test in a single place, if we don't trigger the
        preTest() magic.
        
        Change-Id: Ib97bf07cde6e235d9f9705cbff2f163fbc6d72b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160055
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-29  Jim Raykowski  <raykowj@gmail.com>  [7a555725dad87b977154961beeb5c0da2a856709]

        SwNavigator: Rework the SwContentTree Expand function
        
        in effort to improve readability and operation.
        
        Change-Id: I7bfe485e24ee4cda3a3d99c522177950ad9ad399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159887
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-29  Jim Raykowski  <raykowj@gmail.com>  [8f2c10f051c4d3e587b859210e9430ada7876a7a]

        SwNavigator: Allow Sections, Indexes, and Headings tracking
        
        when in a table and Table tracking is off
        
        Change-Id: I0f5d069b80948aada9fee1338c29fc7809ffbe45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160056
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-29  Mike Kaganski  <mike.kaganski@collabora.com>  [1f2d30093c12de22a04bc16969e027446ded5205]

        Don't emit 'br clear=...' for graphics wrap in ReqIF export
        
        Change-Id: I7684c78c9b98fe63c2281bf3b2a2186d125e0ba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159994
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-29  Mike Kaganski  <mike.kaganski@collabora.com>  [92e7f28f9aff78907bad030be80a9ea9452a3ddc]

        Related: tdf#104718 Use package repair request and behavior
        
        Same as in other places handling that:
        * SfxBaseModel::load (sfx2/source/doc/sfxbasemodel.cxx);
        * StorageFilterDetect::detect (filter/source/storagefilterdetect/filterdetect.cxx);
        * TypeDetection::impl_detectTypeFlatAndDeep (filter/source/config/cache/typedetection.cxx)
        
        In these cases, the same handler is used (RequestPackageReparation);
        when the user approves an attempt to repair the package, the media
        descriptor gets "RepairPackage" property set to true (this produces
        a "(repaired document)" appended to the document title); also, the
        document is opened in template mode (so saving it doesn't simply
        overwrite the original broken document, but asks for a new name).
        
        Re-using this logic, and checking if the "RepairPackage" is already
        set, allows to unify the behavior, and to avoid duplicate warnings
        when the user already approved repair of a broken package.
        
        The request won't contain the details of the XML problem; but it
        will be shown if rejected anyway, so OK for the diagnostics.
        
        Change-Id: Ic997f89272212227479d14236f5e7788298a904a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160001
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-29  Jim Raykowski  <raykowj@gmail.com>  [01a02ee7f1dbe7501a89b41e62599fba6a8b33f3]

        tdf#157681 SwNavigator: Add Protect and Hide menu items to Sections
        
        context menu
        
        Change-Id: I6a79c06abe2cf4dd44d491046d8ee73d35dfe6ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159718
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-29  László Németh  <nemeth@numbertext.org>  [20cbe88ce5610fd8ee302e5780a4c0821ddb3db4]

        tdf#119908 tdf#158419 sw smart justify: fix cursor position
        
        Text cursor didn't follow the new word positions yet, because
        of unsigned casting of the negative shrinking value.
        
        Revert the temporary change of GetLLSpaceAdd() added by
        commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Follow-up to commit 53de98b29548ded88e0a44c80256fc5e340d551e
        "tdf#158333 sw smart justify: fix multiple text portions".
        
        Change-Id: I82cb395fc5af800d8da67d27c16c5ed6837df695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160050
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [be77cae912042c8c5fef8a41ccb4c6b2e10f5047]

        cid#1555974 silence Unchecked return value
        
        Change-Id: Id4d208013d9e25b6c14387963144f38fdcd992f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160016
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c36cba38cc33f22e3388968814f426e88b7f1cd8]

        Prevent attempts to create UCB content from .component URIs
        
        After commit 86c682273d907c77404637c89e584047de1c1099 (tdf#96401:
        allow to detect a broken ZIP package, 2023-11-26) impl_openStream
        is called from TypeDetection::impl_detectTypeFlatAndDeep for URIs
        like ".component:Bibliography/View1". For some reasons, sometimes
        GIO UCP tries to handle these URIs; failing that, it shows an
        error message.
        
        This started to fail UITest_writer_tests4 (specifically, test for
        tdf92611), like this:
        
          Thread 1 (Thread 0x7f51cd99b1c0 (LWP 1424555) "soffice.bin"):
          #10 std::condition_variable::wait_for<long int, std::ratio<1, 1000>, SvpSalInstance::ImplYield(bool, bool)::<lambda()> > (__rtime=<optimized out>, __p=..., __lock=..., this=0x13d78e0) at ~/gcc/inst/include/c++/14.0.0/condition_variable:177
          #11 SvpSalInstance::ImplYield(bool, bool) (this=this@entry=0x13d7690, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at vcl/headless/svpinst.cxx:451
          #12 0x00007f51d9d85695 in SvpSalInstance::DoYield(bool, bool) (this=0x13d7690, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/headless/svpinst.cxx:471
          #13 0x00007f51d9add654 in ImplYield(bool, bool) (i_bWait=i_bWait@entry=true, i_bAllEvents=i_bAllEvents@entry=false) at vcl/source/app/svapp.cxx:390
          #14 0x00007f51d9addc73 in Application::Yield() () at vcl/source/app/svapp.cxx:474
          #15 0x00007f51d946de4f in Dialog::Execute() (this=0x14554e40) at vcl/source/window/dialog.cxx:1078
          #16 0x00007f51d9a5ccec in virtual thunk to SalInstanceDialog::run() () at vcl/inc/salvtables.hxx:543
          #17 0x00007f51d92b45b2 in (anonymous namespace)::executeErrorDialog (nButtonMask=(anonymous namespace)::MessageBoxStyle::Ok, rMessage=Python Exception <class 'gdb.error'>: value has been optimized out
          , rContext=Python Exception <class 'gdb.error'>: value has been optimized out
          , eClassification=com::sun::star::task::InteractionClassification::InteractionClassification_ERROR, pParent=<optimized out>) at uui/source/iahndl-errorhandler.cxx:123
          #18 UUIInteractionHelper::handleErrorHandlerRequest(com::sun::star::task::InteractionClassification, ErrCode, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::task::XInteractionContinuation> > const&, bool, bool&, rtl::OUString&) (this=this@entry=0x1408c9a8, eClassification=com::sun::star::task::InteractionClassification::InteractionClassification_ERROR, nErrorCode=..., nErrorCode@entry=..., rArguments=std::__debug::vector of length 0, capacity 0, rContinuations=uno::Sequence of length 1 = {...}, bObtainErrorStringOnly=bObtainErrorStringOnly@entry=false, bHasErrorString=@0x7ffd36859b90: false, rErrorString="") at uui/source/iahndl-errorhandler.cxx:250
          #19 0x00007f51d92bbcd5 in UUIInteractionHelper::handleInteractiveIOException(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&, bool, bool&, rtl::OUString&) (this=this@entry=0x1408c9a8, rRequest=uno::Reference to (ucbhelper::InteractionRequest *) 0x136bdcc8, bObtainErrorStringOnly=bObtainErrorStringOnly@entry=false, bHasErrorString=@0x7ffd36859b90: false, rErrorString="") at uui/source/iahndl-ioexceptions.cxx:265
          #20 0x00007f51d92a9e33 in UUIInteractionHelper::handleRequest_impl(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&, bool, bool&, rtl::OUString&) (this=this@entry=0x1408c9a8, rRequest=uno::Reference to (ucbhelper::InteractionRequest *) 0x136bdcc8, bObtainErrorStringOnly=bObtainErrorStringOnly@entry=false, bHasErrorString=@0x7ffd36859b90: false, rErrorString="") at uui/source/iahndl.cxx:474
          #21 0x00007f51d92aca90 in UUIInteractionHelper::handleRequest(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&) (this=this@entry=0x1408c9a8, rRequest=uno::Reference to (ucbhelper::InteractionRequest *) 0x136bdcc8) at uui/source/iahndl.cxx:177
          #22 0x00007f51d92c2d36 in (anonymous namespace)::UUIInteractionHandler::handle(com::sun::star::uno::Reference<com::sun::star::task::XInteractionRequest> const&) (this=0x1408c960, rRequest=<optimized out>) at uui/source/interactionhandler.cxx:194
          #23 0x00007f51d8ff8607 in ucbhelper::cancelCommandExecution(com::sun::star::uno::Any const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (rException=uno::Any("com.sun.star.ucb.InteractiveAugmentedIOException": ...), xEnv=uno::Reference to (ucbhelper::CommandEnvironment *) 0x1494c7e8) at ucbhelper/source/provider/cancelcommandexecution.cxx:52
          #24 0x00007f5197fd8ddd in gio::Content::getFileInfo(com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&, _GFileInfo**, bool) (this=0x13658da0, env=uno::Reference to (ucbhelper::CommandEnvironment *) 0x1494c7e8, info=<optimized out>, fail=<optimized out>) at ucb/source/ucp/gio/gio_content.cxx:652
          #25 0x00007f5197fdf515 in gio::Content::getPropertyValues(com::sun::star::uno::Sequence<com::sun::star::beans::Property> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=this@entry=0x13658da0, rProperties=uno::Sequence of length 1 = {...}, xEnv=uno::Reference to (ucbhelper::CommandEnvironment *) 0x1494c7e8) at ucb/source/ucp/gio/gio_content.cxx:448
          #26 0x00007f5197fe031e in gio::Content::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x13658da0, aCommand=<optimized out>, xEnv=uno::Reference to (ucbhelper::CommandEnvironment *) 0x1494c7e8) at ucb/source/ucp/gio/gio_content.cxx:951
          #27 0x00007f51d8fe73ad in ucbhelper::Content_Impl::executeCommand(com::sun::star::ucb::Command const&) (this=0x142235a0, rCommand=...) at ucbhelper/source/client/content.cxx:1264
          #28 0x00007f51d8fe8607 in ucbhelper::Content::getPropertyValuesInterface(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=this@entry=0x7ffd3685a6d0, rPropertyNames=uno::Sequence of length 1 = {...}) at ucbhelper/source/client/content.cxx:500
          #29 0x00007f51d8fe88ba in ucbhelper::Content::getPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=this@entry=0x7ffd3685a6d0, rPropertyNames=uno::Sequence of length 1 = {...}) at ucbhelper/source/client/content.cxx:458
          #30 0x00007f51d8fe8b37 in ucbhelper::Content::getPropertyValue(rtl::OUString const&) (this=this@entry=0x7ffd3685a6d0, rPropertyName="IsDocument") at ucbhelper/source/client/content.cxx:437
          #31 0x00007f51d8fe9282 in ucbhelper::Content::isDocument() (this=this@entry=0x7ffd3685a6d0) at ucbhelper/source/client/content.cxx:1028
          #32 0x00007f51d8feac5d in ucbhelper::Content::openStream() (this=this@entry=0x7ffd3685a6d0) at ucbhelper/source/client/content.cxx:693
          #33 0x00007f51d9274d77 in utl::MediaDescriptor::impl_openStreamWithURL(rtl::OUString const&, bool) (this=this@entry=0x7ffd3685b400, sURL=".component:Bibliography/View1", bLockFile=bLockFile@entry=true) at unotools/source/misc/mediadescriptor.cxx:468
          #34 0x00007f51d9275951 in utl::MediaDescriptor::impl_addInputStream(bool) (this=0x7ffd3685b400, bLockFile=bLockFile@entry=true) at unotools/source/misc/mediadescriptor.cxx:259
          #35 0x00007f51d927685a in utl::MediaDescriptor::addInputStream() (this=<optimized out>) at unotools/source/misc/mediadescriptor.cxx:220
          #36 0x00007f51d69a7745 in filter::config::TypeDetection::impl_openStream(utl::MediaDescriptor&) (this=this@entry=0x143f7da0, rDescriptor=...) at filter/source/config/cache/typedetection.cxx:1202
          #37 0x00007f51d69a9238 in filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::vector<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, rtl::OUString&) (this=this@entry=0x143f7da0, rDescriptor=..., lFlatTypes=std::__debug::vector of length 180, capacity 256 = {...}, bAllowDeep=bAllowDeep@entry=true, rLastChance="") at filter/source/config/cache/typedetection.cxx:902
          #38 0x00007f51d69b971f in filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (this=0x143f7da0, lDescriptor=uno::Sequence of length 6 = {...}, bAllowDeep=1 '\001') at filter/source/config/cache/typedetection.cxx:434
          #39 0x00007f51d6ec41ee in framework::LoadEnv::impl_detectTypeAndFilter() (this=this@entry=0x14501c08) at framework/source/loadenv/loadenv.cxx:774
          #40 0x00007f51d6ec5446 in framework::LoadEnv::start() (this=this@entry=0x14501c08) at framework/source/loadenv/loadenv.cxx:395
          #41 0x00007f51d6ec5b67 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) (this=this@entry=0x14501c08, sURL=".component:Bibliography/View1", lMediaDescriptor=uno::Sequence of length 5 = {...}, xBaseFrame=uno::Reference to (framework::Desktop *) 0x16a8908, sTarget="_blank", nSearchFlags=0, eFeature=(LoadEnvFeatures::WorkWithUI | LoadEnvFeatures::AllowContentHandler)) at framework/source/loadenv/loadenv.cxx:308
          #42 0x00007f51d6d88634 in framework::LoadDispatcher::impl_dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) (this=0x14501bb0, rURL=..., lArguments=uno::Sequence of length 5 = {...}, xListener=empty uno::Reference) at framework/source/dispatch/loaddispatcher.cxx:107
          #43 0x00007f51d6d8987b in non-virtual thunk to framework::LoadDispatcher::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at framework/source/inc/dispatch/loaddispatcher.hxx:99
          #44 0x00007f51d761f4d3 in SfxApplication::OpenDocExec_Impl(SfxRequest&) (this=<optimized out>, rReq=<optimized out>) at sfx2/source/appl/appopen.cxx:1097
          #45 0x00007f51d77065c2 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) (this=this@entry=0x2cf43b0, rShell=..., rSlot=..., rReq=..., bRecord=false) at sfx2/source/control/dispatch.cxx:254
          #46 0x00007f51d7711618 in SfxDispatcher::PostMsgHandler(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) (this=0x2cf43b0, pReq=std::unique_ptr<SfxRequest> = {...}) at ~/gcc/inst/include/c++/14.0.0/bits/unique_ptr.h:193
          #47 0x00007f51d7713d74 in std::__invoke_impl<void, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(std::__invoke_memfun_deref, void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (__f=<optimized out>, __t=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/bits/unique_ptr.h:191
          #48 std::__invoke<void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(void (SfxDispatcher::*&)(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), SfxDispatcher*&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (__fn=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/bits/invoke.h:96
          #49 std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::__call<void, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&, 0ul, 1ul>(std::tuple<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&>&&, std::_Index_tuple<0ul, 1ul>) (__args=<optimized out>, this=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/functional:511
          #50 std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()<std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >, void>(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (this=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/functional:596
          #51 std::__invoke_impl<void, std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(std::__invoke_other, std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (__f=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/bits/invoke.h:61
          #52 std::__invoke_r<void, std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> > >(std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (__fn=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/bits/invoke.h:111
          #53 std::_Function_handler<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >), std::_Bind<void (SfxDispatcher::*(SfxDispatcher*, std::_Placeholder<1>))(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)> >::_M_invoke(std::_Any_data const&, std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >&&) (__functor=<optimized out>, __args#0=<optimized out>) at ~/gcc/inst/include/c++/14.0.0/bits/std_function.h:290
          #54 0x00007f51d7a6aa83 in std::function<void (std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >)>::operator()(std::unique_ptr<SfxRequest, std::default_delete<SfxRequest> >) const (__args#0=std::unique_ptr<SfxRequest> = {...}, this=0x134550c0) at ~/gcc/inst/include/c++/14.0.0/bits/std_function.h:591
          #55 SfxHintPoster::DoEvent_Impl(void*) (this=0x134550b0, pPostedHint=0x7f5174a248b0) at sfx2/source/notify/hintpost.cxx:43
          #56 0x00007f51d9590f30 in Link<void*, void>::Call(void*) const (data=<optimized out>, this=0x7f51748c59b8) at include/tools/link.hxx:111
          #57 ImplHandleUserEvent (pSVEvent=0x7f51748c59b0) at vcl/source/window/winproc.cxx:2287
          #58 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x284cc10, nEvent=SalEvent::UserEvent, pEvent=0x7f51748c59b0) at vcl/source/window/winproc.cxx:2851
          #59 0x00007f51d9d8488f in SalFrame::CallCallback(SalEvent, void const*) const (pEvent=0x7f51748c59b0, nEvent=SalEvent::UserEvent, this=0x284f1c0) at include/rtl/ref.hxx:206
          #60 SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x13d7690, aEvent=...) at vcl/headless/svpinst.cxx:266
          #61 0x00007f51d9a4b216 in operator() (__closure=<synthetic pointer>) at vcl/source/app/salusereventlist.cxx:119
          #62 SalUserEventList::DispatchUserEvents(bool) (this=this@entry=0x13d76b8, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at vcl/source/app/salusereventlist.cxx:120
          #63 0x00007f51d9d84fc3 in SvpSalInstance::ImplYield(bool, bool) (this=this@entry=0x13d7690, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false) at vcl/headless/svpinst.cxx:395
          #64 0x00007f51d9d85695 in SvpSalInstance::DoYield(bool, bool) (this=0x13d7690, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>) at vcl/headless/svpinst.cxx:471
          #65 0x00007f51d9add654 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at vcl/source/app/svapp.cxx:390
          #66 0x00007f51d9addd8d in Application::Execute() () at vcl/source/app/svapp.cxx:368
          #67 0x00007f51d7bce212 in desktop::Desktop::Main() (this=0x7ffd3685d0c0) at desktop/source/app/app.cxx:1601
          #68 0x00007f51d9af112b in ImplSVMain() () at vcl/source/app/svmain.cxx:229
          #69 0x00007f51d9af13b5 in SVMain() () at vcl/source/app/svmain.cxx:261
          #70 0x00007f51d7c03c37 in soffice_main() () at desktop/source/app/sofficemain.cxx:94
          #71 0x000000000040078b in sal_main () at desktop/source/app/main.c:51
          #72 main (argc=argc@entry=7, argv=argv@entry=0x7ffd3685d2c8) at desktop/source/app/main.c:49
        
        Strangely, this is inconsistent on Linux systems (shows on some
        systems, but not on others).
        
        Prevent this exiting from MediaDescriptor::impl_openStreamWithURL
        early for these URIs.
        
        Thank Stephan Bergmann for the help understanding it and deciding
        how to fix it.
        
        Change-Id: I84c551916e6643eeb219f23ff778d4418eea9124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160057
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4edd6258dff38c45e4a6b709e4e1d72a55a446c]

        simplify some BitmapEx constructions
        
        using the color bitmap __and__ the alpha from another BitmapEx
        is equivalent to just doing a straight copy/assign
        
        Change-Id: I134ab8a1197ed538823afc4a8cd28b3d5986c6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1ca6f51567ec35f88652d0adcc0d26478bb0aad9]

        Fix typo
        
        Change-Id: I834d1e296e19af269853bb1d8e73f754eebe2fb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160028
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [ee161b9e484efd6e25c8b4d65071a93eeab4b1c2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 751a65e5be60a35ae970b3a66b2038d90ea580e4
          - Document SF Toolbar and ToolbarButton services
            
            Change-Id: I57df3b88660198d2432ff73ef1b37025e1b893a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159902
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2023-11-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3f47a05f248ad00bdcc80c59baaab06b1b92cc96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to df97eb056605af65df8f2b3935285b27b27c21ad
          - Fix example for YEAR() in Calc
            
            Change-Id: I77e05169e6786210683785217c3611f40d7ebb56
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159901
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-28  Heiko Tietze  <tietze.heiko@gmail.com>  [5a622f1a29d249a512cc24f99d189f748623c678]

        Related tdf#156227 - Find/quickfind design
        
        Themed icons look bad when drawn white on light blue;
        using the same icon as on the infobar makes more sense
        
        Change-Id: I6b4fd2bac7dce41b8196c702e0f0dc87712e2b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160017
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-28  Gökay Şatır  <gokaysatir@collabora.com>  [7697ef9d8fbbed7afba10c00ff9f5362d0540cdd]

        Proof reading suggestions:
        
        * When user right clicks an underlined part of the sentence, we are checking if there is a suggestion list.
        * Then we show the suggestions.
        
        Sometimes spell checker algorithms send 2 lists for the same part of the sentence.
        And we saw that one of these lists can be empty (no suggestions).
        But since we check if there is a list, the empty list is shown to the user.
        
        I updated the checks here and added a new condition:
        Now we take the list if the list is not empty.
        This way, we can find the not-empty list which may come after an empty list (for the same part of the sentence).
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ib3b498b98a8d44f8a7ead99593a71adcefa87a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158832
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 4c6c60d44b0056cbe08b6e75baacbc0df0cd1742)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159908
        Tested-by: Jenkins

2023-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [708e52a551daa27932dfae072a16e3512c72cf92]

        tdf#153693: improve SwXFlatParagraph::isModified check
        
        The response from LanguageTool server may take some seconds, during which
        the user may type more characters of an unfinished word. A result of the
        check started using an incomplete text should be discarded in this case.
        
        The code in GrammarCheckingIterator::ProcessResult that applies the check
        results first calls isModified to decide if it should apply the result,
        or to discard it. Before the change, SwXFlatParagraph::isModified only
        checked that its underlying node is still referenced; but it could only
        get nullified in SwXTextMarkup::Impl::Notify (only when the node dies),
        or in SwXTextMarkup::ClearTextNode, called in SwXFlatParagraph::changeText
        and SwXFlatParagraph::changeAttributes. Any external changes of the node
        didn't mark SwXFlatParagraph "modified".
        
        This change stores the initial text of the paragraph, from the moment of
        creation of SwXFlatParagraph; and then compares it to the current text of
        the node in isModified.
        
        Change-Id: Ia9a2e74b256152fe311db874c66f7e5347183f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160021
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-28  Regina Henschel  <rb.henschel@t-online.de>  [bf6350ef7f9856abc4d6a085bd2d2f95d6b0c84e]

        tdf#158348 Treat wordprocessing canvas like group shape
        
        getFullWPGSupport() is always false for mrShapeContext in case of a
        shape on wordprocessing canvas in table cell. On the other hand we do
        not need the test, because a wordprocessing canvas only occurs in docx
        and thus the replacement group always has FullWPGSupport.
        
        Change-Id: I0e7a9cf1c1c91a893ad7411fda7607947f053e05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159979
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b96db51608e237155a37c7b5d31ef408a19019b]

        update credits
        
        Change-Id: I086375044292658c7bfb7b7d4a99d4d1e1313ac3

2023-11-28  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [143f223e5e58cf218b23697600c7a49ba4a45bc8]

        -Werror,-Wunused-private-field
        
        Change-Id: Ide7172c567f595fb7e44f19c8d96ab8d6b751491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160007
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-28  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [878b4ffc3e2c80c7f65b75c35fea26b978b71daf]

        Update SlideShow on DrawModel changes II
        
        Change-Id: Idfbbb7744cc7b2182647b45f509399535a2d4df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159930
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-28  Michael Weghorn  <m.weghorn@posteo.de>  [8b04bc1d6bf39bf569975617bfbbc8ef7eb31973]

        external/zxing: Backport my upstream fix for android build w/ NDK 26
        
        Upstream issue/PR/commit:
        https://github.com/zxing-cpp/zxing-cpp/issues/673
        https://github.com/zxing-cpp/zxing-cpp/pull/674
        https://github.com/zxing-cpp/zxing-cpp/commit/295b193b0105e68bb24747aefbff2653df892b4c
        
        Change-Id: I47586e0e54b3661e4ca1b5c071f6595fd000cc70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159999
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-28  Miklos Vajna  <vmiklos@collabora.com>  [7f58b57b47e6642cb9a7aeac48915b30148042d2]

        sw floattable, per-frame wrap-on-all-pages mode: add ODT filter
        
        See <https://issues.oasis-open.org/browse/OFFICE-4150>, map
        SwFormatWrapTextAtFlyStart to
        
        	<style:graphic-properties loext:wrap-text-at-frame-start="...">
        
        on export, and the opposite on import.
        
        Change-Id: I43ee4c014fbcef8e883ff08ea061cfd395399a98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160010
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8c727d1a9a8cfdc309896ed02c546e192e006575]

        Always send theme-change in kit-mode even if the global theme is the same
        
        Kit explicitly ignores changes to the global color scheme, except for the current ViewShell,
        so an attempted change to the same global color scheme when the now current ViewShell ignored
        the last change requires re-sending the change. In which case individual shells will have to
        decide if this color-scheme change is a change from their perspective to avoid unnecessary
        invalidations.
        
        Add ConfigurationHints::OnlyCurrentDocumentColorScheme as the hint that
        only the document color scheme has changed, so individual shells can see
        if their document color scheme is different to this new color scheme and
        not invalidate if unnecessary. So dark/light mode changes work properly
        without reintroducing unwanted invalidations.
        
        Change-Id: I5ebb4878694ceb6b9afe26286a30da06ea6ff3ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160002
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cd2ba8cd78c1cd66d5c74e5d35acdcda1bf5abbc]

        ScViewOptions::operator== doesn't compare sColorSchemeName
        
        Change-Id: I21e6630deb9a5329092c88651e4ba0a3715ce616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159997
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [e2aa7041b9a831bbd235f698a6485e2282b6f5ca]

        lok: don't use template flag in more places
        
        Similar to commit e2ee3dd61ab8ea5d970d8da5df3233e7bba5909e (lok: add
        broken package interaction handler, 2023-10-02), all places of broken
        package handling should allow replacing the original document.
        
        Change-Id: I8450dfc0ab60444fa08014cc952ac857998d35ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160009
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-28  Miklos Vajna  <vmiklos@collabora.com>  [5beec1db91b590ebb8e043dfabeaba553c586fad]

        sw: document SwFormatRuby
        
        Who owns it, where is the UI, which contain can have this.
        
        Change-Id: I78bf968f2f887131fe49e5ca56b9a86a2539adc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160004
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-28  Matt K  <mattkse@gmail.com>  [61308112435628177b7884ab833ece843d37cd28]

        tdf#156648 Prevent LO from adding an empty event listener
        
        The problem is that an empty interface listener can be
        added in Basic, which then crashes when trying to fire
        an event on that listener.  The fix is to check for
        the existence of the listener before adding to the list
        of listeners.
        
        Change-Id: I3205ec1e6cdad431f6297f2b7833295b9eb64b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9e876c164a1d9e552c08be3112ada09712a20eb3]

        sw: move header/footer tests to own class in core tests
        
        In addition add some more basic header/footer tests.
        
        This makes refactoring of header and footer OOXML import
        much easier.
        
        Change-Id: I5b3b3714656ba2f7b1dda8d8f067c3bfe68857a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159946
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-28  Kevin Suo  <suokunlong@126.com>  [5589659829f8a1cef8ca1c8a468732105bbe231b]

        tdf#157589 tdf#153969: Revert "sdext.pdfimport Writer: Do not visit...
        
        ... DrawElement twice in WriterXmlEmitter"
        
        This reverts commit 9ea9d3ccc0f8e4833e745d9655b61d42d6d8fe83.
        
        The reason for the revert:
        It causes regressions as indicated in tdf#157589 and tdf#153969.
        That commit may be my misunderstanding of the code.
        
        Change-Id: Idd188bf83721d309623a7f8484d064327a3a23af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159811
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2023-11-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [38ef707aaf324bacba29401afb8bc113b19ad0ab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d8a15e36d381a5d839b878f2058bfba15b3442c
          - tdf#155876 UI cmds Calc-Format menu (22)
            
            + Conditional formatting
            + refactoring
            
            Change-Id: I4fcca025ec2d4091f5a7afacf1adcc41e10826b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160005
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-27  Julien Nabet  <serval2412@yahoo.fr>  [8c3e4dba01fa3bac6ddf16ebe75f3e169e458068]

        Move a cui header inside the module
        
        + fix building issues about "cuidllapi.h"
        + remove #include <cui/dlgname.hxx> in some cxx since their corresponding hxx already contains the include
        
        Change-Id: I2396104fbcbca2e1aca29cdb2324ae0f4daf63cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159996
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-27  Jim Raykowski  <raykowj@gmail.com>  [468c5110226c7f5b3079852a27adde45dc32dc76]

        tdf#158103 Enhancement to display Sections as an expandable/
        
        collapsible hierarchy in the Writer Navigator
        
        Change-Id: I86bc17d11b4c5bf0ca0496e4ab62a0d77ddb625f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159812
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-27  Miklos Vajna  <vmiklos@collabora.com>  [c8f7408db73d2f2ccacb25a2b4fef8dfebdfc6cb]

        tdf#158302 fix build against system-libxml-2.12
        
        Seen in a fedora:40 container, using --with-system-libcmis,
        --with-system-liblangtag and --with-system-xmlsec.
        
        Change-Id: I9d748d3dc0b70dbfdfcb6b99c9ce8440bda6f326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159980
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-27  László Németh  <nemeth@numbertext.org>  [53de98b29548ded88e0a44c80256fc5e340d551e]

        tdf#158333 sw smart justify: fix multiple text portions
        
        Multiple text portions, e.g. if some part of a line
        contains direct character formatting breaks DOCX
        interoperability of justified paragraphs.
        
        Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: Ia53e763fdba89bb733bde088874e641b25d733f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159862
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-27  Julien Nabet  <serval2412@yahoo.fr>  [c56d0355b742aa0afb17c0370997610d24d9554f]

        Remove unused #include <cui/dlgname.hxx>
        
        Change-Id: If8df9416ef0f63bd3e294635038c871b8ce58049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159993
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-27  Patrick Luby  <plubius@libreoffice.org>  [8a5da079592377cf69735973d922fc19e8ac763d]

        tdf#155092 don't dispatch left mouse up events during live resizing
        
        Round 2 of trying to fix macOS live resizing.
        
        If this is a left mouse up event, dispatching this event
        will trigger tdf#155092 to occur in the next mouse down
        event. So do not dispatch this event and push it back onto
        the front of the event queue so no more events will be
        dispatched until live resizing ends. Surprisingly, live
        resizing appears to end in the next mouse down event.
        
        Also, reverted parts of commit 54da842381ccb554d3cadc876f23cf183d21bf1a
        and cleaned up the setting of ImplGetSVData()->mpWinData->mbIsLiveResize.
        
        Change-Id: Ie93ed496e1f0e2a1711284ab205c6b245f71647c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159960
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@libreoffice.org>

2023-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [d134615570bd7afb045f983cdd008c5662265504]

        tdf#158398 android: Draw light gray background for Calc headers
        
        Similar to the desktop version, use a light gray background
        color for the Calc header cells.
        
        There was already code in place to draw darker gray background
        to highlight the header cell when a cell in that row/column is
        selected.
        (The actually highlighted header cell didn't wasn't always the
        correct one in a quick test, but that's independent of this change.)
        
        Adapt that to always fill the rectangle, but use a lighter gray
        (lower alpha value) when not selected.
        Use a separate `Paint` object for the frame (stroke).
        Set the frame color and text color to black instead of gray, for
        better contrast to the light gray fill/background.
        
        Change-Id: I0490811e928ebd1b3840242fc1aa4682b2786b00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159989
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [7c7e044f3cd6adc8ce639d01dc083827cdd87266]

        tdf#158398 android: Center Calc header text
        
        Center the header text in the Calc header cell, to
        make better use of the space. This is in line with
        what the desktop version also does.
        
        Setting the text alignment to `Paint.Align.CENTER`
        is sufficient for centering horizontally.
        There's no equivalent for centering vertically, so
        calculate the position based on the text bounds.
        
        Change-Id: Ia8d5d8434b703cb7daecd34ae70405883f22f0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-27  Michael Weghorn  <m.weghorn@posteo.de>  [808a94d85928545d8c8128f52116509c1ff8c121]

        android: Make CalcHeaderCell fields final
        
        Change-Id: I7e14145569428a2803f9376cf719e524aa8963a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-27  Sahil  <me.sahilgautam@gmail.com>  [b6f274f3d0a415e84cda45f5929d89130974ee2d]

        tdf#33201 Change default HighlightOverlay color
        
        Change-Id: I734b780808da35cdc58c55ede914f87e96fbdd99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159778
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [6ea42a11669e2b3d3a10dd5eb199f45d6050c86b]

        tdf#158396: show DocumentTitle when set in MediaDescriptor
        
        Change-Id: Ic89de9e7d83c7c96eb1b2cc51798d354b38f86d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159904
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [657f98d9272dd97e4f4c6e03cce4a0fa9f526819]

        Related: tdf#96401 Set PROP_ASTEMPLATE for broken ZIP package
        
        Same as in StorageFilterDetect::detect. It would prompt user on save
        to provide a new file name, instead of silently rewriting (possibly
        recovered with errors) document.
        
        Change-Id: I8ede6d01e2d482f409e8b3f7452deb1e4bd02a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159985
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [9ada569e6e9f892924e285b04f569d37a97d8014]

        Simplify a bit
        
        Change-Id: I1609b9dfc047ad55bbaeee369b643d654903866e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [45217ca5ba0d4e78b462a10072a4334342cc402c]

        tdf#157438 Make int/double lists editable in expert config
        
        Change-Id: I4334917e8ac6ae4deb5b15de326b083a4a1c1a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159863
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-27  Miklos Vajna  <vmiklos@collabora.com>  [272c3548c4d2362eb737947c8cbb017e2d55aae1]

        sw floattable, per-frame wrap-on-all-pages mode: add layout
        
        The anchor text of a floating table is normally wrapped around the table
        only on the last page of the table. This property requests to wrap on
        all pages instead for this frame.
        
        Commit 7d7ca347fafa7a06094b00e8fb0d0452c4c81366 (sw floattable, wrap on
        all pages: add layout, 2023-10-13) already arranged the layout code to
        go via the per-frame SwFlyAtContentFrame::IsWrapOnAllPages(), so only
        that needs updating.
        
        Instead of always deciding this at a per-doc level, first check if the
        frame itself requests the on-all-pages behavior. Otherwise keep deciding
        this on a per-doc level. This is meant to please what the OASIS/ODT
        proposal wants and also keeps the Word-style per-doc setting.
        
        The ODT filter still needs doing.
        
        Change-Id: Ibf10b5f016d70e6fe948d5273cc1fb1d98495586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159981
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-27  Michael Stahl  <michael.stahl@allotropia.de>  [58594eaa9f4df52f919cf5b9c43959bcb9c2c452]

        sd: remote: release Transmitter mutex when sending
        
        The Bluetooth communication appears to be astonishingly slow on my
        system; the socket is deliberately cleared of O_NONBLOCK and what's even
        worse is that the Mutex that is held while sending prevents the main
        thread from adding new messages to the queues.
        
        It looks like there should be no issue with releasing the Mutex while
        sending, and if a separate Transmitter thread is used in the first place
        it makes no sense to hold the Mutex while doing so.
        
        Change-Id: Ic993e6c7a7799832c86fd4dd8c6ddad9dab1780b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159924
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [60969b81dd710f26e50f3428f5544ae368010d79]

        tdf#158241 - UI: Part 43 - Unify lockdown behavior of Options dialog
        
        for Draw - General Page.
        
        Change-Id: Ib17d638580011362cde5c2adea7e7e2d6e7d0eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159936
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [86c682273d907c77404637c89e584047de1c1099]

        tdf#96401: allow to detect a broken ZIP package
        
        In deep detection, first check if it's a broken ZIP package. If it is,
        set the RepairPackage media descriptor property to true.
        
        Pass the RepairPackage value to the OOXML filter detection.
        
        Change-Id: Ic958283f3cce92ac29ce93ac330cc9e409e3eb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159976
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [ef79b9c55828d39de3d86cedd125f2f32e6b259a]

        *DocumentLockFile ctor may throw
        
        ... e.g., when passed URL is invalid, as seen after opening
        https://bugs.documentfoundation.org/attachment.cgi?id=121217
        using "Office Open XML Text" filter, which sets "RepairPackage"
        in the media descriptor, which makes the opened file unnamed.
        
        Since the code is called from SfxMedium dtor, this crashed on
        closing this file.
        
        Change-Id: I95f6b16f1421abd55e6739ed431878bb72cf3a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159964
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-26  Michael Weghorn  <m.weghorn@posteo.de>  [872d26d4a859ff72e1e13068b798854185960de0]

        android: Suggest file name for PDF export
        
        When using the PDF export feature in Android Viewer,
        suggest a file name for the PDF file that matches
        the current display name (which is usually the
        file name, or "untitled" for a newly created doc
        that hasn't been saved yet).
        
        This can be achieved by setting `Intent.EXTRA_TITLE`
        for the `ACTION_CREATE_DOCUMENT`. [1]
        
        The `DocumentsContract.EXTRA_INITIAL_URI` already
        set previously already results in the same
        directory as the doc being preselected in the
        file chooser:
        
        > Callers can set a document URI through
        > DocumentsContract#EXTRA_INITIAL_URI to indicate the initial location of
        > documents navigator. System will do its best to launch the navigator in
        > the specified document if it's a folder, or the folder that contains the
        > specified document if not.
        
        Filling in the current file name was suggested
        in a Google Play review comment for the app.
        
        [1] https://developer.android.com/reference/android/content/Intent#ACTION_CREATE_DOCUMENT
        
        Change-Id: Idbd4a89416089f927e0232ce65161b43059ca46d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159959
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-26  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [3ff66d4361c3394d8669f3a367f41d4bad9914e7]

        Simplify implementation of getTypeByHierarchicalName
        
        (Localized)PropertyType::getStaticType already provides the relevant information
        
        Change-Id: I5aceb596ac4a2d111ebcb5ddef7ef74c80762047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159969
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [743e1188cc843e74b1b110675254a7d2329d1a2f]

        Remove exec bits on xcu file
        
        Change-Id: I39128c923c3b4e69c57f1144ec25cb34c80d1472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159957
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2977ec6fc6b361b9edd4b9c0b32588bb0a7d8b28]

        Fix typo
        
        Change-Id: Ie6778eed60a068c15e57799b7c4e766c2890bf35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159958
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [572c33ac7b48b52f81b0d1aee3d0b4feac1335c7]

        Fix typo
        
        Change-Id: I07a4d9fc05a49e17503d9fecd642bfe84466a408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159956
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-26  Julien Nabet  <serval2412@yahoo.fr>  [1aa8d3d2776aa8eab35939179c232e64eab58b4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fc5ab8916f741bfea022ccfe770ce65efb90494
          - Related tdf#158364: improve help for ExportToPOTFile
            
            There's no directory used by default so LO requires the complete (with fthe path) file name.
            
            Change-Id: Ib28f2593f0e4385fbc8a0e7770c3575f05a15c6f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159899
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-11-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [8ac9ef88ce9cf8a78748d420639eec0f23735e47]

        Simplify description/type parsing a bit
        
        ...it only pertains to property nodes
        
        Change-Id: I706e14118e3f8c33190821f9bcce81bd60d665e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159953
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [564c34b01269ff4b574f1cc2a5de52ceebdd8b25]

        -Werror=maybe-uninitialized
        
        Change-Id: I7b3dca8c698d3be304817ad3fa863bd3dfe54a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159952
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-25  Stephan Bergmann  <stephan.bergmann@allotropia.de>  [4333186f8ccfb7309e1212a2c46624b4d56cf0f9]

        Update solenv/flatpak-manifest.in
        
        * Incorporate
          <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e8d48d8a15c9069dd420eac9f651f81fb377567b>
          "Update runtime to 23.08"
        
        * Adapt to recent FONT_NOTO_* change
        
        * Adapt to 3d5cafbe1727a95a54eb4a65d98d6d79ec46f0c8 "tdf#157518: external:
          bundle zxcvbn-c"
        
        Change-Id: Ia956a35c99f487b56a0f58bb591bea366faddbce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>

2023-11-25  Noel Grandin  <noelgrandin@gmail.com>  [77a47ead5d126cca8d5529a92ce20c40f0f6ca06]

        loplugin:fieldcast in DomainMapper_Impl
        
        Change-Id: I1d734e1d30b91b84d42067b9cc621581ad744a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-25  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [52b692d16bc9b373067f3748fabf31aeace6e201]

        tdf#158317 fix cleanup of SfxPoolItems in editeng
        
        It is not possible to use implCreateItemEntry/implCleanupItemEntry,
        that is tooling limited *by purpose* to svl/Item/ItemSet stuff.
        But what I can do is to do that SfxPoolItemHolder I already
        talked/thought about. It is a helper that can safely hold a
        SfxPoolItem in cases where an SfxItemSet is too expensive.
        Think about it as a SfxItemSet for a single item. That solves
        the problem why DirectPutItemInPool/DirectRemoveItemFromPool
        is used in general (each usage is a 'compromize').
        Did that now, works well. Editengine is now free of
        DirectPutItemInPool/DirectRemoveItemFromPool.
        
        Replaced ::CursorMoved with checkAndDeleteEmptyAttribs since all
        these got static with no longer need to DirectRemoveItemFromPool.
        Corrected create/delete counters.
        
        Change-Id: Ia6e53f48ac2e479b461546515e68697039b5b628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159931
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-25  Justin Luth  <justin.luth@collabora.com>  [2bb923d236cbd53ea2b10634537cb23fa545b0a2]

        tdf#115965 tdf#148790 sw sidebar: no need for RemoveBullet
        
        "No List" was already removed from sw toolbar in 7.6.
        Having it "lit up" when in a normal paragraph is distracting.
        
        In LOKit it was desired to just remove it. Since the sidebar's
        existing buttons for bullet and number lists are already toggles,
        having a separate button to remove lists is almost completely pointless,
        so let's remove it completely for all versions of LibreOffice.
        
        This only affects SW. Only WriterVariants show mxTBxNumBullet
        in svx/source/sidebar/paragraph/ParaPropertyPanel.cxx.
        
        DrawImpress uses svx/source/sidebar/lists/ListsPropertyPanel.cxx
        which didn't contain "No List".
        
        Change-Id: Ie54b2647e2ec1729ebe3ab155e77b7fed3fff057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159886
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159940
        Tested-by: Jenkins

2023-11-25  Noel Grandin  <noelgrandin@gmail.com>  [d54ae809aa29fa7a9894c0a1236374fa96e01a43]

        loplugin:fieldcast in SwOneExampleFrame
        
        Change-Id: Ic00ad388b2c18d90075db8e8d0d6b114ed13841a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [b5743ae5f576e45576426593da58fa74bb88c01b]

        Simplify UITest's custom configuration handling
        
        Change-Id: I20d7d3a17b3a0ca817ee5acdab77f51983852078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159898
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [5446000df8fa88e137c2189616962f72dfded29f]

        Simplify HtmlWriter
        
        And add some asserts, to make sure we don't add attributes outside of
        opening tags. Make sure that HtmlWriter closes its opened elements.
        Replace one occurrence where this was deliberately not done, with a
        use of HTMLOutFuncs::Out_AsciiTag.
        
        Change-Id: I3a3f4b963432bf95b36afa62cac2144503837378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159935
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-25  Stanislav Horacek  <stanislav.horacek@gmail.com>  [c34e5b5b4fee431ba2fa950b9bbf72d3008bb332]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02faeab6e7b014ca97a8c452e829af4522dadfc8
          - Formatting Marks command is on View tab
            
            Change-Id: I0a8beb84a0f9b67fed1e479aa1fc7beb36ea31e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159950
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-25  Matt K  <mattkse@gmail.com>  [b6e273aaaf597b60f78c1dd3db8676eea958a9f5]

        tdf#156243 Fix off-by-one bug for autocorrect
        
        This change removes the "-1" from the code
        that applies the autocorrection so that the entire
        string to be autocorrected is replaced, instead
        of leaving off the last character.  Also,
        the starting character of the string is
        preserved (i.e. non-bold if changing to bold)
        by adding 1 to the start position; this is
        for the case when the user cancels the
        autocorrect dialog.
        
        Change-Id: Ibe500a1ba0ca5b12ec9c918b51353074b8dd12ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154685
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-25  Julien Nabet  <serval2412@yahoo.fr>  [8b50a615cbf6c09ed9cf6af6336e388cd32db28e]

        tdf#158357: UI simplify Hyperlink dialog by removing Hyperlink type radiobutton
        
        + rename "Hyperlink Type" into "Hyperlink Settings"
        + remove "Protocol" since ther's only 1 now
        
        Change-Id: I9435606c6ac6eca87afc4c259fb1121f65638c0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159947
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-25  Noel Grandin  <noelgrandin@gmail.com>  [947b23c20780ede6b4d588fb9b944f572e9f8bc8]

        Convert SwHashTable to std::unordered_map
        
        Change-Id: I88b082dc61c05761fd162ea4cf1d30940c2dfccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159941
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6ef1728944b3e0ad0679a11cb17044b8d4401491]

        sw: prevent crash with assert in test base class
        
        Change-Id: I4450d38bfc8146828f0ea447d713ff746c33f101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159945
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-24  Julien Nabet  <serval2412@yahoo.fr>  [516f800f84b533db0082b1f39c19d1af40ab29c8]

        tdf#158345: Opening Hyperlink dialog leads to crash
        
        terminate called after throwing an instance of 'com::sun::star::datatransfer::UnsupportedFlavorException'
        
        relevant part of bt from this exception:
        0  0x00007f34fd6b0231 in __cxa_throw () at /lib/x86_64-linux-gnu/libstdc++.so.6
        1  0x00007f34e9d8207d in x11::X11Transferable::getTransferData(com::sun::star::datatransfer::DataFlavor const&) (this=0x562594fc9af0, rFlavor=...)
            at /home/julien/lo/libreoffice/vcl/unx/generic/dtrans/X11_transferable.cxx:58
        2  0x00007f34e9d825ec in non-virtual thunk to x11::X11Transferable::getTransferData(com::sun::star::datatransfer::DataFlavor const&) () at /home/julien/lo/libreoffice/instdir/program/libvclplug_genlo.so
        3  0x00007f34e15589f2 in SvxHyperlinkTabPageBase::Reset(SfxItemSet const&) (this=0x5625958378f0, rItemSet=SfxItemSet of pool 0x562591482920 with parent 0x0 and Which ranges: [(10361, 10362)] = {...})
            at /home/julien/lo/libreoffice/cui/source/dialogs/hltpbase.cxx:468
        
        See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=191029
        
        Regression from:
        89d3735e05b98223a49a387421386fd736fc3de6^!
        tdf#146576 - Propose clipboard content when inserting a hyperlink
        
        Change-Id: Ic111b8348f2288c4e9e6760fe6f7f48faadec582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159939
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-24  Miklos Vajna  <vmiklos@collabora.com>  [de4e5ab60ceebd285b98adacc886a15e8f83ecb8]

        sw: fix --without-fonts build
        
        See
        <https://lists.freedesktop.org/archives/libreoffice/2023-November/091236.html>,
        those builds were using system fonts intentionally, leave that setup
        unchanged.
        
        Change-Id: Ie5b754743c2f4a97e85dbd9e24e4b6a1047cc5aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159933
        Reviewed-by: Dan Horák <dan@danny.cz>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [b5bc39f84984fd1063865225209d905bea19833d]

        tdf#157551 Calc-Validity-CellRange, dropdown tiny
        
        regression from
            commit b6b26421a1029b18b48b69dbdac4bb70fb622604
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jul 20 08:19:52 2023 +0200
            split Point/Size/Rectangle into AbsoluteScreenPixel* types
        
        Change-Id: I92c25041520ec5a8f03b5318c00f49bda398b051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159915
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [b09cf69f7afa6946a9a4dde6bfa130d382ab1f81]

        Fix HtmlWriter::characters
        
        This method may be called after an end(), and then it shouldn't try
        to close a tag again. Also in this case the characters shouldn't be
        considered in the next start()/characters()/end() run.
        
        Clarify the meaning of the previous mbElementOpen, by renaming it
        to mbOpeningTagOpen. The old mbCharactersWritten flag was redundant.
        
        Change-Id: Ie0ac6ddd88be774853a1fc152742b51793af798b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159932
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-24  Heiko Tietze  <tietze.heiko@gmail.com>  [cb70626ccb63e09f3a4130fd115a29ac79d823f2]

        Bump Glade version
        
        Change-Id: Icea5b88e0e8281803a5deb09619476cccff3b39c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159866
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8566b767a24bc2c382391b6eb154f410c9f865b8]

        find-unused-configkeys: check groups that are not used as templates
        
        listing these was lost in the previous commit
        
        Change-Id: I5b53c3fcf91db930570ac55e182041b5d54cc196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159632
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [14d97973b29c837583bc464b32c8e8b80eaa3642]

        [API CHANGE] Drop unused SelectedFileName config key
        
        does not seem to be in use ever since 2008:
        commit 57f7f259df5c81e6d6425d12cdcdbabeeedc74a2
        
        Change-Id: I749039650568b55be3554846914fe23586661562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159631
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [88487227f96112f9f0f75111ed58b74a739cb272]

        [API CHANGE] Drop unused Compatibility config group from Writer
        
        These don't seem to be used ever since 2002
        commit 72cbd26315bf935a0d6e2c9ffcdbea7d2ada07fb
             #99152# transition to new cfg format
        
        Compatibility configuration keys are in their own Compatibility.xcs
        
        Change-Id: I5da34a82dc4713f97e8d91a9c2a861be13a1a07b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159635
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8765bd9f23bfff5736c6fa48b4e7217449ce17ec]

        [API CHANGE] Drop unused Impress config keys
        
        TimeBetweenHighPriorityRequests
        TimeBetweenLowPriorityRequests
        TimeBetweenRequestsDuringShow
        
        last mention of them was removed in 2017 by:
        commit 98c4cd372bf0e9d4b5b129405f5af4562d8a0f64
        
        Change-Id: I3eab5c82a8313f1f88bb0f6c0c759d4f26a23e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159634
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [80798b426bf7d5fa4616db1af608640cfbcd79fe]

        [API CHANGE] Drop unused ScriptRuntimes config set
        
        last mention of it was removed in 2014 by:
        commit a1552a0ec3fcddd968db274ef41bc2452c50bed9
        
        Change-Id: I8457220be43e2fdf42edcfef587b4346cdf9f2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159633
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [41b3bd1412a463ada1fd8168d0d7822d4f477029]

        [API CHANGE] Drop unused Writer config groups
        
        AgendaType
        AlignmentType
        FileType
        IntElementType
        PositionType
        PositionXYType
        SizeType
        StyleType
        TextElementType
        
        last mention of them was removed in 2004 by:
        commit ab57c5bf40fc2b84ba3d0fd37c6e71907f8b8619
        
        Change-Id: I506b255c887677465b829a36f94a51cb8ea9b4b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159806
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2a14f1c5c1486e436c7851f6909faa4a7afb8f2d]

        [API CHANGE] Drop unused VerticalCallOut config key
        
        last mention of it was removed in 2021 by:
        commit d8fec570c21c5e45ba593ee96cc1ba5d45d77fc8
        
        Change-Id: I8951b23d057badc7e1c6eb8472c4e9d7a63a3579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159804
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Oliver Specht  <oliver.specht@cib.de>  [c47100e478301085ffb1e71bed41b9e5c39377fd]

        tdf#158294 HTML simple format also added to paste special toolbox
        
        adds the format HTML simple to the paste special toolbox controller
        in impress and with draw text selection in calc and writer
        
        Change-Id: Ibdca5d3cd5ab4640320cff3b03b30f6575e8fec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159791
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Oliver Specht  <oliver.specht@cib.de>  [418af212a7f506784d88f5a7a7800140f4f9dd30]

        tdf#157363 remove HTML prefix always
        
        when pasting simple HTML the prefix has to removed also if content is pasted
        without an active drawing object
        
        Change-Id: I038771c3d0338f16b74bd45275f4637eab00cfdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159738
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e3e2bb65fa064d583c24ec5f20b748240acc99ca]

        [API CHANGE] Drop unused UserFactories config group
        
        does not seem to have been mentioned since it was added in 2004 by:
        commit 98c6382021c275b5248ad2c05d7639fc353f4a42
        
        Change-Id: I908049ea107fad9a39af95f0810d0202494257fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159805
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [147c00bae8df6ab6fe096f750e528d17a11ae93c]

        [API CHANGE] Deprecate recently unused AddFeatureURL config key
        
        last mention of it was replaced in 2023 by:
        commit 4af07053517ba3526d4050ffc29993a65b54352b
        
        Change-Id: I9d6f9bcf1a36784d304c3ce528587080686e2299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159803
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [10b1babef046c686de279fefbb70aafcc2dd3d83]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b1830be3caa3fae67973f8370aaf1a5e820e3caa
          - tdf#157716 Rename "Language settings" to "Languages and Locales"
            
            Change-Id: I73a7d291d997ac14074b88433b14fa755e888a68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159928
            Tested-by: Jenkins
            Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6f32acbbf8e2f42dd926b42d7718056db5bbee94]

        tdf#158240 - UI: Part 42 - Unify lockdown behavior of Options dialog
        
        for Impress - Print Page.
        
        Change-Id: I96e90ab09ee4bc80b097799970a5b1c56fc47048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159927
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [fbecf8009af8abdd218fbb3bd26087e8b805d06b]

        tdf#158239 - UI: Part 41 - Unify lockdown behavior of Options dialog
        
        for Impress - Grid Page.
        
        Change-Id: I0864a0a47a890c34154e775a1f960fdff09de81c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159868
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-24  Regina Henschel  <rb.henschel@t-online.de>  [63ecd577f5fe95feda0d1d8577a7d3b493999d78]

        tdf#158339 setFullWPGSupport to group shape in wpc
        
        otherwise the group will create no wps shapes but draw shapes and those
        cannot be connected to text frames. The text frames were then located
        separate outside the drawing canvas instead of being bound to the shape.
        
        Change-Id: I525fac157c08c60d43ff9420775e2cbb9d891d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159885
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-11-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b1a866caccb322ec6e88eac67710310160e72b58]

        tdf#158238 - UI: Part 40 - Unify lockdown behavior of Options dialog
        
        for Impress - View Page.
        
        Change-Id: Icc3c4fc9dd3800ef454cbddb06e569e03c08967a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159856
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [afd3517301d28145861aa7725fd5879a6666a881]

        Resave with newer Glade version
        
        Change-Id: I238bb0d6f54a6df0bdab6cd93a73f75746cfdb6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159855
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [256ec735299e95f03f87a1356a30147c67388d24]

        tdf#158222 - UI: Part 39 - Unify lockdown behavior of Options dialog
        
        for Impress - General Page.
        
        Change-Id: Idd7240b6c0ccfec8929e2f224a63ec5c0a8ad331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159854
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-24  Noel Grandin  <noelgrandin@gmail.com>  [da0ca6a060e7df6fec65af502484ae0fda0d3033]

        use more concrete UNO in sc
        
        Change-Id: Id486b94464bfa49ed471bcb825acee7bddeacb8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-24  Noel Grandin  <noelgrandin@gmail.com>  [6f0f7fa17aebe888cb8264bd48d741f469ba56b9]

        loplugin:fieldcast in ScXMLImport
        
        Change-Id: I0820427504d0cb9e14b54bb92a2e383bf0137121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-24  Noel Grandin  <noelgrandin@gmail.com>  [ca0609368edf80c4e56abf36fefc2bfabfd82deb]

        use more concrete UNO in sc
        
        Change-Id: I20f0200a4ed74b32b67b740e0084dae9620c2912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159871
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [57974af130e7421da6b07589d4a63a754b757ad6]

        tdf#148389 sw: fix Delete Undo/Redo of bookmark positions
        
        The main problem is that in SwUndoSaveContent::DelContentIndex() if the
        selection start/end is equal to the bookmark start/end, the bookmark is
        not deleted and no SwHistoryBookmark is created, hence on Undo the
        bookmark positions are not restored.
        
        Since deleting bookmarks in more situations might cause user complaints,
        let's just extend the creation of SwHistoryBookmark to these cases,
        which means we need to take care both here and in
        SwHistoryBookmark::SetInDoc() that there is now a situation where all
        bookmark positions are saved and restored but the bookmark still exists
        in the document because it wasn't deleted.
        
        The next problem is that using Backspace/Delete keys sets the
        ArtificialSelection flag which is stored in SwUndoDelete, but when used
        multiple times the SwUndoDelete::CanGrouping() extends an existing
        SwUndoDelete, and if it previously would not delete a bookmark, the
        extended range might fully contain the bookmark and thus delete it on
        Redo, so check if there are saved bookmark positions and prevent
        grouping in that case.
        
        Another problem is then that SwUndoDelete::RedoImpl() deletes the
        bookmark anyway, as already indicated with a FIXME comment.
        
        This can be prevented by passing the now-existing m_DeleteFlags into
        DelBookmarks() from DeleteRangeImplImpl().
        
        Change-Id: Id5eb1a58927aaa6e7e8b75be82d7f854d8057cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159875
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [5eb6293a895c18ac91a3ba552de71f0571e24da6]

        sw: rename the rest of the SwHistory Add() member functions
        
        Change-Id: I990fe383341757087d468b3eeae38fca4d8d0175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159874
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [aee059ffabf46b57c7eeea337d0ba5e337737a55]

        officecfg,sd: add Office::Security::Net::AllowInsecureImpressRemoteWiFi
        
        The IPRemoteServer listens on all interfaces and accepts connections
        with a "PIN", which is transmitted in the clear (without encryption),
        so it is not as secure as a naive user might assume and should probably
        not be used in public/untrusted networks.
        
        Make it possible to use the Impress remote with Bluetooth only, which
        appears to be more secure, by adding a new setting which defaults to
        disabled.
        
        The DiscoveryService which does mDNS/ZeroConf/Bonjour/Renezvous/whatever
        -it's-called-today should not be needed for Bluetooth.
        
        Adapt the RemoteServer code to the new situation that there can be a
        BluetoothServer but not a IPRemoteServer.
        
        Also add a checkbox to the "Slide Show Settings" dialog.
        
        Change-Id: I0cd3f23b616e23351f166bc9681b45786df8a26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [7d7d84c07b1ed01a5cd51b43c5712eab19d3f729]

        sd: remote: disentangle class RemoteServer
        
        RemoteServer was both an object and a thread instantiated for the IP
        server, and a bunch of static methods and data used by all servers.
        
        Split out a class IPRemoteServer.
        
        Move Bluetooth setup to SdDLL::RegisterRemotes().
        
        Also the BluetoothServer was accessing RemoteServer::sCommunicators but
        never locked the corresponding RemoteServer::sDataMutex.
        
        Change-Id: I3ff39e68e619af1e91697124a1352b5f20350a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159785
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-24  Miklos Vajna  <vmiklos@collabora.com>  [a596070f8ac11ed0cd22baf55704037a6b8d9c4d]

        sw floattable, per-frame wrap-on-all-pages mode: add UNO API
        
        This exposes the internal property SwFormatWrapTextAtFlyStart on the UNO
        API.
        
        We need this, because otherwise the ODT filter can't read/write it.
        
        Change-Id: I67d3c28e3531b19183f8361a6df87b7a4ca84294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159888
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-24  Jean-Pierre Ledure  <jp@ledure.be>  [9b5b313a2f2980f9a10295aabdd696f58af03302]

        ScriptForge (SF_Database) manage transactions
        
        Transactions are managed by next UNO properties:
           XConnection.AutoCommit
           XConnection.TransactionIsolation
        (They seem very easy to use but, in practice,
        are not easy at all)
        
        Usually all transactions are in auto-commit mode,
        that means, a commit takes place after each
        single SQL command.
        
        Switching auto-commit off  means however that
        the connection needs to be of type "ISOLATED"
        and not of the default type "SHARED".
        
        => The usual shared connection must be closed.
           As a consequence, all rowsets/resultsets linked
           to the shared connection need to be closed as well.
        => Additionally the buffers must be emptied (flushed)
           to make committed data visible in the Base user
           interface.
        
        All above aspects and constraints are managed in the
           database.SetTransactionMode(transactionmode)
           database.Commit()
           database.Rollback()
        methods transparently for the user scripts.
        
        The [transactionmode] argument has as value one of
        the TransactionIsolation constants.
        Without argument, database.SetTransactionMode()
        restores the automatic mode.
        
        The manual transaction mode is available for both
        Basic and Python scripts.
        Its implementation will require an update of the
        documentation about the Database service.
        
        Change-Id: I214bd91a1744d6d24609bc5efc987152c6e946c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159867
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-11-24  Frank Steiner  <fsteiner-board@bio.ifi.lmu.de>  [9137bd2dd3ab66ffa783fc15a1add1e9cf541460]

        enable using medium/full font hinting even with subpixel positioning
        
        Change-Id: I1be0670d59163070dccf035ec9c7b0cd4f818c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159766
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-24  Laurent Balland  <laurent.balland@mailo.fr>  [c8b21dd6a310ff4fb1dd53c6930768fda34dda4b]

        tdf#158202 Candy Impress template background
        
        On first master page, move picture from page background to an object at
        the background
        Other updates:
        - remove unused font declarations
        - remove page number value
        
        Change-Id: Ieded7b794e00213b7c47e0059bb7120ed133b125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159794
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-24  Laurent Balland  <laurent.balland@mailo.fr>  [288075bf40b3de11b8f45fc67c52ff0d1d1169b5]

        tdf#158203 Freshes Impress template background
        
        On first master page, move picture from page background to an object at
        the background
        Other updates:
        - remove unused font declarations
        - remove english text in number page
        
        Change-Id: I19e2b1f3a6f137ef86e5b43862d4e91ca278f0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159797
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [3e83fd3507b79b371443dee9c581a1058acaf995]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d85fa4e10f1156978c2f21aeab4e7d6ad7f80ab0
          - Clarify the default --outdir path
            
            Change-Id: I696164fe7c08179e6968f8b1ad694d4dab508af0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159891
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2023-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [8d8877f3badd536a5e1ebecd79191d69b1848fd4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 330b000f3da52d482a62ae5b726f91eecccaf4f2
          - Add info about required write access to profile directory
            
            Change-Id: Ife9416d25b7768682652525eec9f66f693785d27
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159890
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2023-11-24  Miklos Vajna  <vmiklos@collabora.com>  [40309da824a6d370aaeae4169c44f237387ec427]

        sw: extract SwSectionFrame::dumpAsXmlAttributes() from SwFrame
        
        Allows getting rid of a static cast.
        
        Change-Id: Iaba2a328399dacad3e16efa15df4f23abec6f883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159869
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e51005a2413457a9030c565d627e39670785b56]

        tdf#158338 Opening file with image when JAWS is running causes endless loop
        
        Revert "tdf#112865 assigning to mpDrawObj here is unnecessary"
        
        This reverts commit 1c1647e6ee252fe68d7406d01043e88f1721590f.
        
        Change-Id: I056123a90850989436dadf2d4504230550b9ae2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159768
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-24  Noel Grandin  <noelgrandin@gmail.com>  [b9312a055ab7759fba68a9353ae64d37b460a2d3]

        loplugin:fieldcast in oox::xls::PivotTable
        
        Change-Id: Ie50626b2e24bba2ee67827afcdf42c1c0ed2c9d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159870
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [05d5181e2c19aca7e6098217ddb7065e02819a53]

        tdf#158117: encode the username sent to LanguageTool
        
        Change-Id: I762ebb7487b3bcb80cd88b265b4e75c0d8b7c639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159764
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [d94bdda68ea07d5b1c1c3312559e36f2da7c88f3]

        Update vcl README wrt VCL plugins
        
        Change-Id: I0b778b3d33367239e4cb12e5f1eba2224a0ed55e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159861
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [32ce5fe4ed19a79b6f15a5d4d1892e6cc8d778d9]

        tdf#158336: Only Change current table
        
        For that, use the same logic as TryBoxNmToPtr
        
        Regression from 0c008ab081aa5bbf53f8562e95e547deae5afc2e
        "tdf#157132: restore behaviour for TBL_RELBOXNAME"
        
        Change-Id: I8f93ad3a9686001fd6bd7226400925e43b81ec23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159865
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-11-23  offtkp  <parisoplop@gmail.com>  [17e362e56f9e15d0214c441e632c91d22e58519d]

        tdf#158252 sc: Enable text wrapping when inputting line breaks in cell
        
        In Excel, when typing new lines in a cell or pasting text with new lines
        and then clicking out of the cell, wrap text is enabled, which actually
        shows the contents on the new line instead of on the same line
        
        Change-Id: I113aceab33380a5deb536f57969c3fc90825146b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159758
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-11-23  Patrick Luby  <plubius@libreoffice.org>  [54da842381ccb554d3cadc876f23cf183d21bf1a]

        tdf#155092 use tracking areas instead of tracking rectangles
        
        Apparently, the older, tracking rectangles selectors cause
        unexpected window resizing upon the first mouse down after the
        window has been manually resized so switch to the newer,
        tracking areas selectors. Also, the NSTrackingInVisibleRect
        option allows us to create one single tracking area that
        resizes itself automatically over the lifetime of the view.
        
        Note: for some unknown reason, both NSTrackingMouseMoved and
        NSTrackingAssumeInside are necessary options for this fix
        to work.
        
        Change-Id: I1f771628d872166ff63a52990f671df053d144ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159845
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-11-23  Achintya Sharma  <sharmaachintya08@gmail.com>  [ee65218d9e74fc787520830f29f74e1ac61383ea]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: Icc27e0ebb8fe68d1171e7075e93e7ca74569c0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159860
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-23  Julien Nabet  <serval2412@yahoo.fr>  [cb753911e3df1531e8b77027fa34e952566052eb]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (svl 2)
        
        Change-Id: I55c85a02e9dfc7d7cd2aaaec726fc5877a847264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159849
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [2da3c1f0bf180e44e82d6ef9bbcd33129026a3dc]

        Limit PreserveSpaces HTML/ReqIF export option to proper space characters
        
        We only need to care about SPACE, TAB, LF, and CR. We don't need to care
        about LF in some cases, because it gets converted to a <br/> element, and
        handled specially. And we don't need to care about other "whitespace"
        characters, like control characters and Unicode space.
        
        Our own object placeholder characters were treated as "space", which was
        wrong.
        
        One peculiarity needs to be noted. In ReqIF case, a SPACE before LF needs
        no 'xml:space="preserve"', but an LF before SPACE needs one, because it
        needs to disambiguate between a <br> followed by a significant space vs.
        a <br> followed by a pretty-printed newline.
        
        Change-Id: I74273592df05bb94d8e4ecaea2c069c0e086b7d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159853
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-23  Michael Weghorn  <m.weghorn@posteo.de>  [934a4937e32b4ccf4690b642ccf4787331f37b68]

        tdf#158331 android: Fix "Save As" for non-experimental mode
        
        While "Save" (i.e. saving back to the original location)
        doesn't make sense when editing is disabled (because the
        doc cannot be changed) and the menu entry is therefore
        not available when the experimental editing mode is
        disabled, "Save As" does make sense, e.g. in order to
        save a copy of a file opened from another app.
        
        The menu entry was there, but not working as expected,
        a 0-byte file was created.
        
        This is because `LibreOfficeMainActivity#saveFileToOriginalSource`
        would return early if experimental mode is disabled.
        No longer do that, but save the file as requested.
        
        Change-Id: I5785b6060c4ba9cdf3e9c3591b9f941ab987bf4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159857
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f83730fb54ba68129048d0989bf6c957e0b933b]

        bump product version to 24.2.0.0.alpha1+
        
        Change-Id: Iabc985c1329d4c1ac31ddf93e8b8f4b6f3c48900

2023-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [2de6ca621d47c410bb6082f03cd2b1a960ae1179]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0ddbebfba051ff3e347d1074f28c9d43b45ab4c3
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I5c3b49c1a54cc4ad00e54e37ceddbd834e2f4579
            
2023-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [59280a9ce5a15136a6fdd383aedf02c6cf7d6e96]

        tdf#158321 No error message when file doesn't exist
        
        Revert "reduce allocations in InterceptedInteraction"
        
        This reverts commit e3c961e6a3917d95534652e0f982918cc1079015.
        
        Change-Id: I26ba0acaa088dff1800ccd69513056f821bd4d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [f23ee916466bd6e0d328a4e541e104445c8ecb0a]

        tdf#158072 Fails to apply AutoFilter in Mail Merge dialog
        
        regression from
            commit 66b0bc55854ba13b92b6c39b95f3f2d4ef76bf20
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Mar 10 10:35:33 2023 +0200
            simplify initialisation in *DatabaseMetaData
        where I failed to notice that the supposedly static data was being
        std::move'd
        
        Change-Id: I6238fa8e20ee6ca9fe31c29a7e05262dc1e3bede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d7b33b1be8fee684e906f170f4001735c095056e]

        use SID_DOCFRAME for dialog parents if there is no SID_FILLFRAME
        
        if there is no other hint
        
        which avoids: sfx2/source/appl/appserv.cxx:314: no parent for dialogs
        without the need to add extra SID_FILLFRAME just to smuggle a default
        parent in.
        
        Change-Id: I99980c951a0046afa3cc22e02b4f79850e3b2736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-23  Martin Srebotnjak  <miles@filmsi.net>  [93aa534cee0ab74b9ad4b72b739e9a26c6dfc129]

        Update git submodules
        
        * Update translations from branch 'master'
          to 94a68df82da0b9bd94e8bc324caac9bf49d4121a
          - Updated Slovenian translation
            
            Change-Id: I97fbc2c814dd61ddd17032540ca4ee24b8c61324
            
2023-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac424db10e963864bc5744897561e0bf127a615c]

        re-apply "Work with what we have in ArrayImpl: pointers"
        
        re-apply commit f7df46c917533d3ce3528d52f49629fe9f51e67b "Work with what
        we have in ArrayImpl: pointers", which I somehow managed to revert while
        preparing commit d9c726beb64968e84d2150824c81dcf0a8b66ec2 "optimise
        framelinkarray lookup"
        
        Change-Id: I05c3da965ef334597f17fea9deded28218b15a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159846
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [277dc083a500e08e7501d8cdb160aabacbefdc49]

        set a parent for this warning dialog
        
        Change-Id: I6d71874c3957e9ee4cebb622f702903775ec9aed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159844
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0942eed2eb328b04856f20613f5226d66b66a20]

        reuse AllowedLinkProtocolFromDocument in impress/draw
        
        Change-Id: I73ca4f087946a45dbf92d69a0dc1e769de9b5690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-23  Miklos Vajna  <vmiklos@collabora.com>  [b1b0cc1b0bb473155b5b089199ca99bb1dc40e42]

        sw floattable: add per-frame wrap-on-all-pages mode
        
        Currently the wrap-on-all pages mode is off by default and a
        document-level setting can enable it for all split flys.
        
        Allowing this at a per-frame level (and not only per-doc level) is
        suggested in <https://issues.oasis-open.org/browse/OFFICE-4150>. Given
        that this floating table proposal is coming from us, it makes sense to
        also support this additional attribute from the proposal, even if it's
        not supported by Word.
        
        Fix this by adding a new SwFormatWrapTextAtFlyStart property on fly
        frames: this is meant to be enabled when wrap-on-all-pages is wanted for
        this fly, but it's disabled at a per-doc level.
        
        Unlike SwFormatFlySplit, this is meant to be easy at a layout level,
        since SwFlyAtContentFrame::IsWrapOnAllPages() is already a per-frame
        function, it is just backed with a per-doc setting.
        
        Change-Id: I8f562102c2bc366a36c08895b681c4a2ab256bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159847
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-23  Noel Grandin  <noelgrandin@gmail.com>  [2b403a8ddce089689ed3baefa75e0ea5c77724e1]

        loplugin:fieldcast in DbGridControl
        
        Change-Id: I87b1aa0326cbd4270ca54831b3388a5da9c9416d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Julien Nabet  <serval2412@yahoo.fr>  [693735e4d39b92d7a16e855cfd9d99d9d150ea75]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (svl)
        
        Change-Id: I572a7c81130f15929536c3c334875e8401be9e60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159700
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-23  Jaume Pujantell  <jaume.pujantell@collabora.com>  [7c4dba1deffd81f647a4a3be7a79f68f3bf9f1ba]

        fix a regression crash from commit 5082d50
        
        The commit generated crashes in the crashtest documents
        7711 bugtrackers/docx/fdo78333-1.docx and
        695 forums/docx/forum-mso-en-4096.docx.
        This was due to "m_xFieldStartRange", the start of the text
        portion of the block SDT, being recorded too early. This led to
        including characters that shouldn't be there in the generated
        content control.
        This patch moves the calls to setFieldStartRange to just before
        the first appendTextPortion call.
        
        Change-Id: I7230346fee9a37ebac70beb9bcafd9d7b612eb00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159816
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-23  Miklos Vajna  <vmiklos@collabora.com>  [85852ad0d96bfd71413aef94edc1b6e2e6052e1a]

        CppunitTest_sw_txtexport: turn on gb_CppunitTest_set_non_application_font_use
        
        And the same for 3 other tests.
        
        Similar to commit dc4d7500c9d283e26d1553ce11366a217cf1f69d (Fix
        CppunitTest_sd_import_tests-smartart non_application_font_use,
        2023-10-23), though this didn't find anything so far.
        
        Change-Id: Iceed164c7c171daad2dd20d4e5d809ed05d9ead9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159837
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-23  Noel Grandin  <noelgrandin@gmail.com>  [baafd5aca2fd8cbc9d1d5ae8d0b4b8c8a6b68812]

        loplugin:fieldcast in LayoutManager
        
        Change-Id: I3fc7a2c690344ee6934111cdffc0b23ff2537b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Noel Grandin  <noelgrandin@gmail.com>  [89945d719282ba83d6a06be899a1320c40daee12]

        loplugin:fieldcast in LayoutManager
        
        Change-Id: Ib0b56703cd6782d850ab5960a7fa53d15eb443a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-23  Noel Grandin  <noelgrandin@gmail.com>  [0cea768b529a26c58fb736f762aeb0b99884debb]

        loplugin:fieldcast in Binding
        
        Change-Id: Ia4bb341dba0c853b53c42a36fcb472e5948f1708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9602f8a9318dd4d3409856e2ae06abe96e72b51b]

        tdf#125580: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: Ia7be1c4dd1f4d748bb70fdc43c52825b4dade1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159836
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-11-22  AmosAidoo  <aidooamos20@gmail.com>  [94d2d9a59450fa4bccd0a3a450d8b273271d2ff2]

        tdf#154088 Merge code snippets for character retrieval and string construction
        
        The DrawChars_Impl method has been unified since the duplicates were identical
        and only differed in how they retrieved characters from a separate source. Each
        class now has its own implentation of GetCharFromIndex as a solution.
        
        Change-Id: Ic2d10a46a91ea8dee2c94b620e6745bf77ae9eab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159773
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-22  Irgaliev Amin  <irgaliev01@mail.ru>  [847001ffbbcaf6d2657a5cce18f6c58151efbd2c]

        tdf#158126 UI: Scalable buttons for Impress navigation bar
        
        On some panels, small icons of navigation bar are not
        convenient to use. Currently there are 4 sizes available
        for other icons: automatic, small, large and extra large.
        It is useful to implement support for scalable buttons in
        the Impress navigation bar. This setting can be located in
        Slide show -> Slide Show Settings (Display section)
        
        Change-Id: Ief8cc0cbf4eac98ee90bf3e993e4fc44cea0165e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159294
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3709a8e5f03a6498a6f3ac7c6671d4b08fc46ea3]

        Fix typo in code
        
        Change-Id: I2e9ba39aeb838b019464363612505edb5a7c6353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159832
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f17b89b9e4d1e5c1cf608a2ce1ed218917e3447b]

        Fix typo
        
        Change-Id: I66cb84da082a7498b1c6a79e989dd94d9f7b1b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159828
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [be262b04ff0e7b85c508975914d77086878155ef]

        Fix typo
        
        Change-Id: I786d7873f1aa4921bae81cbbecca01959db3866b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159824
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8403d2b83f30a977f1a0eaabeddeeb2d7ac7059]

        Fix typo
        
        Change-Id: Ic297e251d58cc29c00c6dcc1add85b52bafa190c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159831
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8b6e497a3a9c0d3ce054d3516a2646576a5c8247]

        Fix typo
        
        Change-Id: I6e6955b18078685ebbe215e496a0b459afb33f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159833
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d2cfc1cbcb70954951a7bd95a95da26233552733]

        Fix typo
        
        Change-Id: I034c3b76a8f35700d528b06d7816c0062fe16b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159822
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c6dfe5abe3f4a4361cb8169cf20a9d1cf00ae52a]

        Fix typo
        
        Change-Id: Id95dc2bc578d98894ab73b1a9b9f7b0e69de3d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159830
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac2839458c5f497b907506da07dcd1b451b62372]

        Fix typo
        
        Change-Id: I3201adc92bec156014b8044371a79a8255c58aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159827
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [99ef89ba4cd2497f3a46448692a71d98c721ae9e]

        Fix typo
        
        Change-Id: Id19012a207b6df24188e424414e103c7c3dc3d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159825
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [34636bb5f6c6d2b31515451d42aac841a14bd7aa]

        Fix typo
        
        Change-Id: Id83a613432117cbf7f20eb9dd0cfa8eaf60b103d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159834
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e763acfa9b643595794a9afd2ac196fe0497990e]

        Fix typo
        
        Change-Id: Id451921ddcefb71f9c46a11e5150fa1b864d4281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159829
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c49d688d212fd89daee5563b67b55f687f6d901a]

        Fix typo
        
        Change-Id: I15170c332c7b9943433fc7113c3b3e8c44c765cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159826
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84d8a1caf124a25fb081562e4db32acf19e0f301]

        Fix typo
        
        Change-Id: I76ea5af4ec21ca55a2b88f48e6d476feec065349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159823
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [278c5d22928a05cbfe887e38bc93a5051d0f59d4]

        tdf#158147 - UI: Part 38 - Unify lockdown behavior of Options dialog
        
        for Math - Settings Page.
        
        Change-Id: I05170a6c7edb6160e0e7804fa04325d329499854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159819
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [68a2e50726e2f16354ff45d6768790e076989cb6]

        loplugin:fieldcast in SwTransferable
        
        Change-Id: I8e9f157a399f1b305d2e6b6e63da837f0090fd8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9c726beb64968e84d2150824c81dcf0a8b66ec2]

        optimise framelinkarray lookup
        
        We can use hashing to do an O(1) lookup instead of O(n)
        linear scanning, this class is sometimes a bottleneck
        in laying out large spreadsheets.
        
        Change-Id: I4d27e8f339a8732535d832442a9d4a649da19e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b2d6b36815cbfee8b44b87b7c0b3cb4bab61850]

        tdf#127498: sc_datetime_functions: Add unittest
        
        it fails with
        Sheet2.A9 '=TIMEVALUE(K9)' result: 0.354166666664241, expected: 0.354166666666667
        without the fix in place
        
        Change-Id: I4e6faff1b7eb1913ca668ef11b489076e793adc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159820
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-11-22  Szymon Kłos  <szymon.klos@collabora.com>  [5dcc658d7fc6bd6f8002666e40e1f1bff3dd4c69]

        lok: disconnect clipboard leftovers in Writer to avoid crash
        
        When we closed one view which previously copied some larger selection
        in the Writer and other session after that modified content of that selection
        we got a crash. It was caused by old clipboard data still beeing used.
        On copy there is created SwTransferDdeLink which creates "Server" - SvLinkSource
        which is notified in SwTransferDdeLink::DataChanged when someone is
        editing
        previously copied selection. Let's disconnect that server on view close
        as it is no longer needed.
        
        some characteristic trace pieces for crash:
        
        libsofficeapp.so!LOKClipboard::setContents(LOKClipboard * this, const com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> & xTrans, const com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardOwner> & xClipboardOwner)
        ...
        libswlo.so!SwTransferable::RemoveDDELinkFormat(SwTransferable * this, vcl::Window & rWin)
        ...
        libsfxlo.so!sfx2::SvLinkSource::NotifyDataChanged(sfx2::SvLinkSource * this)
        ...
        libswlo.so!SwDataChanged::~SwDataChanged(SwDataChanged * this)
        
        Change-Id: I2ebab3db8bc42e20781874802563352ef263fdaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159755
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [55936f6ad8fb73d8b78a843de378758cc31009ad]

        android: Set autofill hints in Calc toolbar
        
        Set autofill hints for the address and formula
        text edits in the Android Viewer Calc toolbar as
        described at [1] to address warnings that Android
        Studio shows about these not being specified.
        
        [1] https://developer.android.com/reference/androidx/autofill/HintConstants
        
        Change-Id: I1ac7a5babddf3c328145b9f2194d10bb701aa4f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159810
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-22  Michael Weghorn  <m.weghorn@posteo.de>  [abed55b1ea7f04a0a522d54e369d170a71045cd5]

        tdf#158307 android a11y: Auto-detect toolbar height
        
        Instead of hard-coding a toolbar height for the
        cell address and formula bar in Calc, use
        `android:layout_height="wrap_content"`, so the height
        is determined based on the font size.
        This avoids the text getting cut off when a large
        font size has been selected in Android's accessibility
        settings.
        
        Change-Id: I9bfbe2b7a1db39ac11d9ed0ab15290f974782489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159809
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-22  Gülşah Köse  <gulsah.kose@collabora.com>  [a6fffac0336fa7d5843f73139ec88a5eef8269d5]

        Online: Fix Wizard Help button
        
        Wizard dialog help button's response is not initialized if we don't run
        any other dialogs. It should be initialized in RoadmapWizard itself.
        
        response_help function can not detect wizard dialog's Help button. So we
        should handle this case in function too.
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: If80a2e54dcbf5eaa3d0e07347d12296ace5c9569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159282
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2023-11-22  Attila Szűcs  <attila.szucs@collabora.com>  [3a5cc107efb843b01193230c56dc8d9c0072348a]

        tdf#148000 impress: improve fontwork text placement.
        
        Improved the calculation of positions of text characters for multi-line texts.
        
        The previous version only fitted the text to the basic outline (curve), and then scale them to the appropriate text line.
        This means that the text will be wider or shorter, depending on the shape of the curve, and which line it is on
        
        Now it calculates a curve for each paragraph and fits text on it.
        Text will be approximately the same width on each line.
        Except if the text is wider as the curve. Because then it shrinks the text to fit on the curve. (this can only happens on inner curves)
        
        Reused the same compat flag that was used in bug148000, now it serves
        as a Powerpoint compatible mode for FontWork, so no need to create new
        compat flag every time FontWork has improve.
        
        That means that the Fontwork in old documents has remains the same
        
        Refactored horizontal/vertical alignment, but had to keep the old hacks
        as well.
        
        Note: if there are too many lines of text, and the vertical alignment causes internal curves, then curves can shrink to 0 length (center point of a circle) or even to negative length,
        These cases are impossible to display normally, so it will be glitchy
        similar to how it was before this patch.
        MS PowerPoint avoid these cases by not allowing vertical alignments that
        would result internal (smaller) curves.
        
        Added unittest to check legacy-odb / new-odp / pptx file.
        
        It change the display of fontwork, so in some cases it may feel like
        a regression.
        
        Change-Id: Iac2d9bc751bbc2b6f747c33958f969cb3543fae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159776
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-22  Miklos Vajna  <vmiklos@collabora.com>  [223d2fac61e061478721a7a4a89b1362f5037d8f]

        sw floattable: fix crash by trying harder to split tables
        
        Regression from commit 60e2fdf1d7e8346e5a3835369c47e582c737ce20 (sw
        floattable: maintain the invariant that fly height is at least MINFLY,
        2023-09-28), the bugdoc crashed on load in SwTabFrame::MakeAll(),
        because the tab frame's HasFollowFlowLine() was true, but
        GetFollow()->GetFirstNonHeadlineRow() was nullptr and the invarint is
        that these are always in sync.
        
        Digging deeper, what happens is that the master table has a split row at
        the end, so the follow table has a "follow flow line". We remove that
        when we try to split the master table (split either moves rows to the
        follow or creates a new follow), so the follow table only has a
        "headline row" remaining. Then Split() is called with bTryToSplit set to
        true, this fails (because only a single line would fit the master, but
        orphan/widow control rejects that) and then we join the follow table
        (because it only has headline rows), so a split with bTryToSplit set to
        false (don't split the row itself) never happens. This at the end leads
        to a strange table frame with only headline rows and gets deleted, which
        is odd to happen during the initial layout.
        
        Fix the problem by remembering if we just removed the follow flow line,
        and in case we tried to split the rows itself and table split failed,
        then don't join the follow table, so a next split can be invoked with
        bTryToSplit set to false, which leads to the correct layout. This means
        not only the crash is fixed, but also no layout loop happens and result
        matches Word.
        
        Limit this to tables in split flys, at least for this bugdoc the inline
        table case would not have this problem as widow/orphan control is
        disabled inside inline tables.
        
        Change-Id: I172e38be11baf6f73df722a4c6c035a6a283d727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159802
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [1bdf64cb4fa0a7bdc50c39c12be0d6897d6eea2f]

        Drop a redundant CR cleanup
        
        Commit 77779166569da389de44075b3d03413b353046a4 (Remove stray
        CR from input, 2017-03-09) had introducing the removal of CR
        from CRLF generated by MSVC's cl.exe -showIncludes.
        
        Then, commit e9b9a456221b4b0660f90efa1ee092ea00c2c728 (gbuild:
        strip away unexpected CR char at the end of Windows filenames,
        2017-07-26) added a replacement doing the same, but using a
        literal CR instead of "\r". It had in its commit message:
        
        > seen with 2013 on libreoffice-5-2, but there is no
        > indication that 2015 on master would be different
        
        libreoffice-5-3-branch-point was tagged on 2016-11-23 (commit
        4136757b4e51c4e6f7cb4132c95538a7f831ef2c), so the 5-2 branch
        did not contain the former change, and so the premise that
        "master would be no different" was likely incorrect.
        
        Change-Id: If992eb826c5d6c2868c9bd706ae51847fe69eda7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159754
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-22  Miklos Vajna  <vmiklos@collabora.com>  [f732cedc77959489a9bee4d3e6d56901bd5625ed]

        CppunitTest_sw_mailmerge2: remove not needed preTest() call
        
        1) preTest() retuns a unique_ptr which has to be hold till the test
           runs, which didn't happen here.
        
        2) This was just copy&paste probably, since preTest() is not overwritten
           in this suite.
        
        Change-Id: Idd8688a82db01d41ac9d0535a907dccc6064c6cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159796
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [f7df46c917533d3ce3528d52f49629fe9f51e67b]

        Work with what we have in ArrayImpl: pointers
        
        That allows to not create a local copy on the heap before
        being able to check if a change is really necessary
        
        Also added mfOrientation to Cell::operator==, it was missing. Maybe
        with C++20 we should more use the default generated op== (or op<=>)
        that may turn out to be more safe. For class Cell at least all members
        (and sub-members of Style) are simple and simple comparable.
        
        Change-Id: Idea2ef2abe68c4bb14aa776a8393ba5da92abd5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159798
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-22  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7d357628d6e8ce3f9e3c3a567ada21f02bce8d42]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 65a60febbc9f5a4e293977d357228f5504847b7f
          - remove note about PDF Import extension
            
            this extension has been merged into LibreOffice and it is
            not available anymore
            
            Change-Id: I37b7bd44628623fe98cf00a839845a8fea1da613
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159799
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e797f291530fb7f4f6d86646b2fb805a1a78aa3f]

        tdf#158145 - UI: Part 37 - Unify lockdown behavior of Options dialog
        
        for Writer/Web - Table Page.
        
        Change-Id: I3a8333684d1c4bfeea869581b33354385838111f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159795
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1f94a89429c665104bdf21b5ac48171850fa5afb]

        tdf#158144 - UI: Part 36 - Unify lockdown behavior of Options dialog
        
        for Writer/Web - Print Page.
        
        Change-Id: I1fb2f52966843297fcb415c02946d7ce38097332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159788
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b4350fd9c3f1873ead892c6baeb7f7c0fc1c7d80]

        tdf#158143 - UI: Part 35 - Unify lockdown behavior of Options dialog
        
        for Writer/Web - Grid Page.
        
        Change-Id: I8b3cc4f75e613691840edc6456fb8ea2c4314282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159784
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [edf05194527e596e8b32956f7f3f34357f6e4a27]

        tdf#158141 - UI: Part 34 - Unify lockdown behavior of Options dialog
        
        for Writer/Web - Formatting Aids Page.
        
        Change-Id: I8e67ac65add2aab50fe1db2d071ce731be80f946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159783
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [49c200cf9f3e8f61716a15bf67dee9f54d2931fa]

        tdf#158140 - UI: Part 33 - Unify lockdown behavior of Options dialog
        
        for Writer/Web - View Page.
        
        Change-Id: Idcd271493461bbd7a945e0ad5484715279a19c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159780
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f90e9e57ea647f6ab047216b662d40aca7759580]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60315fa219686298a01ff1f829245320c914f090
          - Fix typo
            
            Change-Id: Ida5d2330088746867b45dc008697716d97207848
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159782
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-11-21  Laurent Balland  <laurent.balland@mailo.fr>  [b77c15fd6a12803073a0077a946b1e38d8a9107b]

        tdf#158204 Midnightblue template correct color
        
        Color of the upper and lower strip of the first master slide was
        declared in "Accent 1" style. This style is overwritten when applying
        the master page from the side panel.
        Color is now defined as overloading of standard style
        All inheritances from Accent 1 and Accent 2 were removed for master page
        Midnightblue
        Other updates:
        - page number position, size and font was corrected
        - Liberation font declaration was missing
        - remove German name of a style
        - replace html code &apos; by '
        
        Change-Id: I2e0ef69d7117719a9829535db24c94048603d9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159519
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>

2023-11-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [06654099e9a208f23a98bcf4d2a4c3b6d8798ec4]

        asan: fix read of uninitialised value
        
        ever since
            commit a91892ec4942fc875820ea02dfbe74e986548142
            Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Date:   Thu Nov 16 13:56:06 2023 +0100
            Use existing types, instead of strings
        
        Change-Id: Ifb7af17d21a32fdf411854b6820b32d1767660e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c95f406fcde65e383cff90842ff66e55bfabfc79]

        tdf#115871 - Reset outline and list options to parent settings
        
        Added the various items of the controls in the outline and list options
        tab to the range container. Otherwise, the main dialog does not have any
        knowledge about the options to reset to the parent settings.
        
        Change-Id: Icc9f862e741eb0457cfb1c74e64324809c143ab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159787
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-11-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2b4cb63a4450aff4582994ca6ac701287da61ddd]

        Cleanup some ScPatternAttr specific stuff
        
        Removed some special stuff in the ItemSet/Item tooling regarding
        ScPatternAttr. There are still quite a view (grep for
        isExceptionalSCItem), but all these are identified and isolated.
        
        Only for that Item (of over 500) are these exceptions, so that raelly
        does not fit into the Item schemata in any way. Not even the pool
        default of ScPatternAttr is without trouble. It is the only and last
        Item that needs to be 'pooled' in the sense to avoid copies on any
        price. That is OK, but should not be done in the ItemSet schemata.
        
        In short: It should not be an Item at all. It should be changed
        and renamed to something describing it's role (CellAttributes..?)
        and get helped/assisted by something called CellAttributeHelper at
        SC's model or Pool. It should not even be derived from SetItem, it
        could just contain an shared_ptr of SfxItemSet (allows more and better
        optimizations - think about Clone() and op==).
        
        In parallel, all these hacks in the ItemSet/Item stuff could be
        removed, making that faster and easier. Also quite some usages of
        DirectPutItemInPool could be cleaned-up, this only exists since
        there *is* no defined place to hold that data (coud be
        CellAttributeHelper in the future). Putting Items directly to the
        pool (and in most cases never remove them again) is just nonsense
        and another hint that all this does not fit to the Item/ItemSet
        schema at all.
        
        This is now - after hard isolation of problems and have all working -
        doable. It may be one of the next things to do, but there are
        other candidates, too. Doing this would mostly only help SC...
        
        Found another hack that uses DirectPutItemInPool and *never* removes
        any Item again, see comments framelinkarray.cxx
        
        And another one: PoolItemTest::testPool() explicitely tests
        DirectPutItemInPool stuff - which makes no sense long-term,
        but for now keep it and make it work by marking the slots used
        as _bNeedsPoolRegistration == true
        
        Have now overhauled the framelinkarray stuff to work without
        DirectPutItemInPool and Cell not being a SfxPoolItem. That will
        be much less complex and use much less calls/checks. Since this
        is the data structure created for every calc repaint that should
        get faster, too.
        
        Also for now and memory loss security I added code to
        DirectPutItemInPool to behave the same as with the unchanged
        implCreateItemEntry: register Items so that the garbage collection
        still is used. This will/can be removed when all usages of
        DirectPutItemInPool is cleaned up.
        
        Directly registering in DirectPutItemInPoolImpl is more tricky
        than thought, but a good thing to do. Looking at that I saw that
        tryRegisterSfxPoolItem is not used anymore, so rearranged some stuff.
        
        Change-Id: If07762b0a25e2739027f81872441772dc82a25d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159685
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-21  offtkp  <parisoplop@gmail.com>  [b5a35f09b3c3ccac26b403e881c799e0d09bf42a]

        chart2: Match chart background color with DOCCOLOR in Calc
        
        Chart background color would be hardcoded to white which meant newly inserted charts would have a different background color in Calc (in other components, the background color is later set to transparent)
        
        Change-Id: I6ea55389f195155a96c4c8dcc94a902b2a862178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159751
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-11-21  Hossein  <hossein@libreoffice.org>  [42edec63fba4a3ddc0dcd83a5affb7913625b42a]

        Cleanup make files for Java/C++ SDK examples
        
        This fixes some minor issues with the make files for Java/C++ SDK
        examples in DevelopersGuide/FirstSteps.
        
        For Java examples, an exatra "-f Example_Java.mk" was a leftover from a
        previous change.
        
        For C++ examples, 'make clean' was not working correctly, because of a
        leftover from a previous change.
        
        Both should be fixed now.
        
        Change-Id: Id936824675a9bfd43674ca526bc97a998ed9daf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159777
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ac5484dc495c664b5ea309c0fcbee1b4bd8c131]

        Update git submodules
        
        * Update translations from branch 'master'
          to d0fb14adc60976ff54a9561254d070717a76004c
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I38c7510b87b7a3c20132436d66132832d214b4b2
            
2023-11-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ddf9f30869a9808097135f77384e2679c3f73e36]

        tdf#158137 - UI: Part 32 - Unify lockdown behavior of Options dialog
        
        for Writer - Mail Merge, Email Page.
        
        Change-Id: Ibd484a4ae815ad94dd6c418fbe66901a9b84c7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159741
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-21  Miklos Vajna  <vmiklos@collabora.com>  [cbd16c4dc4cfb9155fd7f3899866e4f8156140a0]

        sw: document SwFormatFrameSize
        
        Where this can appear, size type, percent relations.
        
        Change-Id: I7afddd033e8a8842c99dcb3d9604a2cb75ad6d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159743
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-21  Patrick Luby  <plubius@libreoffice.org>  [9a0dad2a649066a10ace53a06d563596330199a0]

        tdf#157558 invert and remove blended white color
        
        Before commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
        RemoveBlendedStartColor(COL_BLACK, aAlpha) would darken
        the bitmap when running a slideshow, printing, or exporting
        to PDF. To get the same effect, the alpha mask must be
        inverted, RemoveBlendedStartColor(COL_WHITE, aAlpha)
        called, and the alpha mask uninverted.
        
        Change-Id: I8e81b11aab05954c821f833f4a2fc77eec7b7701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-21  Matt K  <mattkse@gmail.com>  [2fa88bfbfa4c9befe1be8a1953c018437a621254]

        tdf#117651 Add AutoCorrect support for italic and strikethrough
        
        The AutoCorrect "Apply" command calls SwAutoFormat::AutoCorrect
        in sw/source/core/edit/autofmt.cxx, as mentioned in the bug
        comments.  This change just adds new cases for "/" (italic)
        and "-" (strikethrough), so that when "Tools" -> "AutoCorrect"
        ->  "Apply" is invoked it changes any text between 2 "/"s or
        2 "-"s (assuming your AutoCorrect options enable the setting
        for this).  The new code is just mostly copied from the case
        statement above it (for bold and underline), and the only
        additional changes that were needed were to add the comment
        strings for the 2 new cases.
        
        Change-Id: I02238690a40fd0113e3e9acbecf93ef5c34e0785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154207
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cfa70002e5ef3333fcae9fdd6225d037d09c2589]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed8997d667fff2ab03bd2e7f1cc3d1f92f526e97
          - tdf#155876 UI cmds Calc-Format menu (21)
            
            + merge cells, print ranges menus
            + refactoring
            
            Change-Id: Idcdd2fb8b986700f624941662a8250bbe6aac753
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159746
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6ced25a269d2ee72949a9f64806bba2c9f52ea68]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5b140914661fa472e089daeade8ec269f16e314
          - tdf#155876 UI cmds Calc-Format menu (20)
            
            + Row/columns menus
            + refactoring
            
            Change-Id: I434ee9975dd3029809a0ae01b15511e77fb70698
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159745
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-21  Hossein  <hossein@libreoffice.org>  [ae61f6aa2b5f6156f61c4fd2cceb5b1206450c48]

        tdf#143122 Port FirstLoadComponent example to C++
        
        Port DevelopersGuide/FirstSteps/FirstLoadComponent Java SDK example to
        C++ and add a GNU Makefile for the build.
        
        Change-Id: I24da0422014e42f844cae21863d54301dd902f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159740
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-20  Hossein  <hossein@libreoffice.org>  [bc5c767e9aebadf12aa6a181a6ce066cbfff71ad]

        Separate folders for DevelopersGuide/FirstSteps
        
        This patch creates separate folders for 3 different SDK examples in
        DevelopersGuide/FirstSteps:
        
        1. FirstUnoContact
        2. FirstLoadComponent
        3. HelloTextTableShape
        
        Each one of these are ported to 4 languages: Java, C++, BASIC, Python.
        The Java Makefile in the top folder is now separated into 3 different
        Makefiles for Java programs.
        
        Change-Id: Ifb2003be2aafb4caec4810eb21fbb4708b9a0628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159591
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-20  Michael Meeks  <michael.meeks@collabora.com>  [13eb599d8b0f81e4024f4aa2a6dd8b074f80a9df]

        lok: async calc merge-cells popup dialog.
        
        Change-Id: I6f7d1e8de4ac36f546706f7702157cc7e49c80b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159581
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a57f2ec591e6081ae32d6e4efb75768321494912]

        Fix typo
        
        Change-Id: I411a422fbfaf9a798bcec5bccce4138ff8431497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159739
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Gökay Şatır  <gokaysatir@collabora.com>  [4b81692f8f3236082f9ac989e4e21c8119ff6e64]

        Writer: Update German language shortcuts
        
        Replacements (if any) are shown with indentation:
        
        * CTRL + SHIFT + C: Copy format.
        * CTRL + SPACE: Reset attributes.
           * ALT + SHIFT + F: Focus to find bar.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: If1067a3aac7c4f2f246153a7ea6cf251c39cffb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157578
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit eeb685b0f12911c696abbf847a22bd3bcc00fc2c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-20  Balazs Varga  <balazs.varga.extern@allotropia.de>  [3e81415f7f71b7fe99342c82b3c54011fbcb2dbb]

        tdf#158136 - UI: Part 31 - Unify lockdown behavior of Options dialog
        
        for Writer - AutoCaption Page.
        
        Change-Id: Ia3c37510477542556c3302d2013fe10a4ae00545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159594
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72928fa459f8e67c30a2e2357424ab75d3105a26]

        ofz#64109 crash in CharClass::isLetterNumeric
        
        there appears to be an extra portion created, because HookChar is
        set, but there doesn't seem to be a reason for the HookChar so we
        get an unwanted trailing portion.
        
        It seems that the HookChar is set when processing the field, presumably
        when we restore the SwTextFormatInfo text, idx and len we should also
        restore its original HookChar state.
        
        At least for this ruby text case there the field contents are drawn over
        the body text, unlike others where the contents are drawn inline with
        the body text, where we appear to need to keep the hook char.
        
        Change-Id: Id48a3ef09cd10dcc91048f8c08207d2d105839d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-20  Jaume Pujantell  <jaume.pujantell@collabora.com>  [43868de0ddabba952b923f6189d1fefeddb70bcf]

        fix a regression crash
        
        Fixes a crash introduced by commit 5082d50.
        
        Change-Id: Id33c49165c4d345d652a546db14df98ee0ff754a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159736
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d35202a9809af8cee159dfb9bf4f91be64600c0b]

        Fix too wide impress options page
        
        Fallout from 28245ae37723223c93fb0f915a599bb547c391f0
        
        Change-Id: Ibd7c133d18e15b3130da1dc91aae17a942554877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159734
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [950bee9154c9854364c72a3b48ddbcffff137803]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (sw)
        
        Change-Id: I67c231441b56f05da001beab5b893bc6a6a6a392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159704
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7de97bc7b83790907bd6fdfb7a319e2467aba1d]

        pass by ref, not pointer, in ScViewFunc::ApplyAttributes
        
        since we always de-ref the input params
        
        Change-Id: I222e58547b37186841c6b435adcea73f4d43b55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7da04200f9f7ac6ed3e573107282da8428ef65e6]

        Update SlideShow on DrawModel changes
        
        It may happen that DrawModel changes while a SlideShow is running,
        e.g. from EditView/Scripts/UNO API. We can try to suppress these
        as we already try with EditView in that mode. As an alternative
        it is also possible to react to these changes in the SLideShow
        in a useful manner.
        This is the 2nd try, main change is to do all of this directly
        in SlideShow, so no chechs/tests in common code are needed.
        
        Change-Id: Iaa393d78af1fc40003c83d896508abe31cd790d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159447
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a91892ec4942fc875820ea02dfbe74e986548142]

        Use existing types, instead of strings
        
        as suggested in https://gerrit.libreoffice.org/c/core/+/158028/comments/b7a803f4_7e5899ca
        
        Change-Id: I7d4c46b24307922b51e463bacdfacfca85956b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159524
        Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a09092f20455ea68a22f815a8b086fc4c4c5100d]

        presentationframe is no more
        
        Since 7ca9c5bd2e2e3cda5686b7b8f5b657161eb52cdd
        
        This fixes a crash when navigating to the Draw Options page
        
        Change-Id: Id0d39b7c0b1effe22eae407903b1becfd4ad0da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159732
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-20  Miklos Vajna  <vmiklos@collabora.com>  [d00087882dd3a68173e315069c3f0f7f7078cce5]

        svx: prefix members of SdrPageGridFrame
        
        See tdf#94879 for motivation.
        
        Change-Id: I0542a137fa8598e97f84defbc284993c665c1fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159729
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-20  Miklos Vajna  <vmiklos@collabora.com>  [45a4ed02281a7a8ca52fccf626c792e417c8ef1c]

        sw floattable, delete UI: fix undo/redo
        
        Pressing the unfloat context menu item for a frame resulted in 2 undo
        actions and trying to undo both even crashed.
        
        One problem was that no SwNode was left in the TextFrame and then it was
        deleted; but undo created a TextFrame with an empty SwNode in it.
        
        Fix this by inserting an empty text node at the end of the TextFrame and
        only then moving content from it.
        
        The other trouble was that in case the new text node has no matching
        frame during MoveNodeRange(), then the fly frame will be deleted twice:
        once during MoveNodeRange() (because it has become empty) and once more
        during DelLayoutFormat(). This can be avoided by moving AppendTextNode()
        to its own layout action. Finally also group the (now) 3 undo actions
        together, because it was a single action on the UI.
        
        Change-Id: I95ce0abbab79a293ecb209579c105f96d284a1c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159730
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [babee57de8d511ca82842ad098cddb8c335bcdc5]

        Extended loplugin:ostr: cui
        
        Change-Id: I2cdd90f8eafab4900c42c706da2abc38077f6103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159720
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [46617d95f409c743ef9d60d2f6309200c44cd79f]

        Extended loplugin:ostr: canvas
        
        Change-Id: I7c5ee1eb15a4464c9dfc2e292df3e6adf71d3956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159726
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [730a704f7fa78ef340925eea163525a7ae5be224]

        Extended loplugin:ostr: bridges
        
        Change-Id: I8eefb64e75933ea9a4fbadb501182fc61bbf11b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159727
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [5c374284b751131e695c04f0d77a0958f153a501]

        Extended loplugin:ostr: connectivity
        
        Change-Id: I284c896777c4f62499eb6b7c0a9883d9abf8d1f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159721
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [1cb523eee4e61ab7eaff114aae45f38d4d234d10]

        Extended loplugin:ostr: basic
        
        Change-Id: I041913b1fe2722145d770e5cdcf90cdf22957873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159728
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [727b2720d7ee77014407a2d4db12dd1b229d224a]

        Extended loplugin:ostr: dbaccess
        
        Change-Id: Ib6a310f78d8f168e5524d4115cf6f00d679b7cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159719
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [99b9bc76591cf6a479ee20b15c41f20357fc228f]

        Extended loplugin:ostr: codemaker
        
        Change-Id: I7a8eddee0ecf7ab38cc356c157e9832b715da4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159724
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [3caea32ae4af3a1e4885266cf5e26333ee98fb28]

        Extended loplugin:ostr: chart2
        
        Change-Id: I544f7286ff28cd105fa9dc7bff2712aebb3d5a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [8ef2b4b4c6624247305a22dbcc54098910584b66]

        Extended loplugin:ostr: configmgr
        
        Change-Id: If9cc1f0c18a5fa344a433b338f81d191340e70f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159722
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [5ac4adaf026bab096febc2587f49edb603e98689]

        Extended loplugin:ostr: comphelper
        
        Change-Id: I338c3c263e940bbe6071827b2e19763b7dadc2e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159723
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [e66ccbecfb414800271e066c630cf7e90d5f3b74]

        Extended loplugin:ostr: emfio
        
        Change-Id: Ida43018a83c68f5d20dbee30325b8f32099e5b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159713
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [847db3fa1244c2707e1966d3e6579258bb6d8924]

        tdf#157438 Make string lists editable in expert config
        
        Change-Id: Ia8b8553d547e760c18624c5c599951523b74ac82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159523
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [c860e7cc974c306961c421be1eb034c78c6c244f]

        Extended loplugin:ostr: editeng
        
        Change-Id: I5dbd4047d2b66c12475020abfdd2b8f16d65a8f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159714
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [7068754492563710d3a5db06abeb0520effdf8a2]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (ucb)
        
        Change-Id: I9ce4ae0246f78acd7bfed89f52103c2f5e571c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159706
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [a761272a688d91eacc461e69cdcce55a27eb54b7]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (xmlsecurity)
        
        Change-Id: Ia7d9b806667a7c11743f7e9e4bb5525a1202e7fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159712
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [63d676e7557f2b63d8f2df6573e3b4af5bb46cb0]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (vcl)
        
        Change-Id: Ie9bb9ce20f27162bcb7d7d25dcad99107675e2be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159709
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [75f6a86ad924661f19c504380d96659e6b7d8afe]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (writerfilter)
        
        Change-Id: Id506689954f20c3b66d417798f25807bd0e84ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159710
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [2ea548e394a504a2277a17f333f862540d48b817]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (unotools)
        
        Change-Id: Iebc949486322b55f60e83b27739acc1c16d2a25e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159707
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [042fb18fbcb98ee7e9b3982d987421e43b99cbff]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (toolkit)
        
        Change-Id: Ied5fc25f959e938fdd80532375486c167c370e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159705
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [39aff36a842ae4df59c283dbba7f2ebfcf5d66fd]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (xmloff)
        
        Change-Id: Idb65092e79a9afc6195bce0dbd5b3861d83a01be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159711
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [15ef2909b88ef97b84615837e8bdb448481d61c1]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (svx)
        
        Change-Id: If0cca803cd182f5def098ab06a0c5a4a479758bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159702
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Julien Nabet  <serval2412@yahoo.fr>  [31795be8ee5bcc113f2d18d315f842a89e95b316]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (svtools)
        
        Change-Id: I53a244ac751dbe9d40e8f541fcb6d7ff89ff83f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159701
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [2718e9c1d5779a23bd6587a7e0e55a0281b88745]

        Extended loplugin:ostr: l10ntools
        
        Change-Id: I6c46535568ac6c29784e9336198b51c79c9e3859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [fa7dd627c9d74f5bf584caddbdc32c7a0f3543a1]

        Extended loplugin:ostr: o3tl
        
        Change-Id: Iac716011fd421c6dd0d40cf81dc6cbebb1ae4e71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [f8087b516ac1b000ca0454682d865340e790915a]

        Extended loplugin:ostr: idl
        
        Change-Id: I22adb7f3750f1e1b9910f37046c5da98ac7ab5be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [1b19c6b7d03b0f7098f43131358227df28e59d84]

        Extended loplugin:ostr: filter
        
        Change-Id: I1c45cecb97789a3fc229084de1b7b4968d6069c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159699
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [f94351f54bfaa6e6da42da2a33b3fa468b878a1f]

        Extended loplugin:ostr: i18npool
        
        Change-Id: Ia0a844bc6e3f27758c869f5e229097085288e8bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159698
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [cdb5f9595f2eb6a4d5f28c19380bcacc6d2b550b]

        Extended loplugin:ostr: jvmfwk
        
        Change-Id: Ibb17d89a5ed618b4d5e6be9ac9ee89e2751c3ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [042a87dbd1172ea81b7d2df1f890684687e25f56]

        Extended loplugin:ostr: linguistic
        
        Change-Id: I74b95a853a142da3e2df5b974a13d991f13d28eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159694
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [f94987039b0b08db878b1c444c28b302d6723fac]

        Extended loplugin:ostr: extensions
        
        Change-Id: I0c70fc1d42031a5a6ebd900cd20b1e7e40d9352d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159703
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [b5da85150d0b4ab693616b0f6af613842b7acde3]

        Extended loplugin:ostr: desktop
        
        Change-Id: I0c86c1207f906e19c770b71ae1c5daec1c912845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159717
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5f5eb28d0dcb66d5d947db7087f501ec73e00d7]

        use the cheaper variant of SfxItemPool::areSame where possible
        
        Change-Id: I10a357293ef176fb8aba7a683cac9a73ac3ea897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159684
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-20  Stephan Bergmann  <sbergman@redhat.com>  [3e5edde173d8af47bc386a850874186bc406b6fb]

        Extended loplugin:ostr: drawinglayer
        
        Change-Id: If37d6fac8e1cabd7c1609c26259366fb0d3d81ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159716
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-20  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [2bbacaf8170a119099fb1a6d89ab608051194625]

        vcl gtk3 : no need to use ClearableMutexGuard instead of Guard
        
        Change-Id: I3dc75125fa89f6b584d4caa1a950e0ec9a461fc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159347
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-20  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [76898eaf8fc665802c4fcdd129ec221d9019d4b9]

        tdf#143148: Use pragma once instead of include guards in vcl/inc/unx
        
        Change-Id: I91ba6c5e49ed7e9ae8e946859ce5ed2169ae590a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159648
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [baecfd21797310bb15ab98ca3962445d99e397db]

        Extended loplugin:ostr: sfx2
        
        Change-Id: I7b2988ed246a0b1b0af0721521ba738ba3de2f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159677
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [235ae98ae614315cfe3bb2baf52ca442bcc2f592]

        Extended loplugin:ostr: opencl
        
        Change-Id: I126ed9e9fca6d1ab8d4e42ec0fe1ffb33a5f8ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159689
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Gökay Şatır  <gokaysatir@collabora.com>  [3bd3c41bc930406ec3d995a45a7f7060d572bbd0]

        German keybindings:
        
        Changes (2 indentations for the replacements of currents):
        
        * CTRL + 1 / 2 / 5 for paragraph spacing 1, 2 and 1.5.
        * CTRL + + for superscript.
           * CTRL + SHIFT + + for CalculateSel.
        * CTRL + D for font dialog.
           * CTRL + SHIFT + D for double underline.
        * F12 for save-as.
           * ALT + F12 for default numbering.
        * F5 for GoToPage.
           * CTRL + F for navigator.
              * CTRL + SPACE for search.
        * Removed CTRL + H for superscript.
           * Defaults to find and replace now.
        * CTRL + SHIFT + K for italic.
           * CTRL + K for hyperlink dialog.
        * CTRL + SHIFT + L for default bullet.
        * CTRL + * for control codes.
           * CTRL + ALT + * for execute macro field.
        * CTRL + SHIFT + Q for small caps.
        * CTRL + T for subscript.
        
        for general compatibility.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I181e2d7828bc3f53092db4f880ee1715ae262d02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157308
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 4137596ca58e927977ffe354f60c296f5771d28b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159687
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [f53172a1141f7bb3c0950f1fe00800b633846ec4]

        Extended loplugin:ostr: oox
        
        Change-Id: Ic3ee80433571767dba9de1ecfb00d2d96beae4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159690
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [1f43e2071f5aba897946028dbc8c86c6b00825df]

        Extended loplugin:ostr: sax
        
        Change-Id: Icf6ffbc746dbbc790a5a248002ecd161413f120c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159681
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [95ffa27c593a7fa31309b5e72a55d966862db9a0]

        Extended loplugin:ostr: sal
        
        Change-Id: Ic8a02784acb9f8981249689541bb6cba1b7fbfb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159682
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [115e7a00c3ab2927b10e569e41d60230cba93dec]

        Extended loplugin:ostr: pyuno
        
        Change-Id: Ie8ec1e8b3debd1501b16d40567a063390749a19b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159683
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [c7526e303ff8113b6d4fdcc5b439b2ea2734cd51]

        Extended loplugin:ostr: sd
        
        Change-Id: Iadfe05a173bacd236086728ac23de1e610f0bf27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159679
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [099be392bfc5ddba21370726fa887a2fd6c99cd5]

        Extended loplugin:ostr: sc
        
        Change-Id: I44536a13f4c31558671c1166d06b7f6216456641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159680
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [09622587088ee8a3d35abc17aab24b165d2eabfd]

        Extended loplugin:ostr: xmlsecurity
        
        Change-Id: I639bf4af888e5af615379515d92ad70025d8ac15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159660
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [9407c1f96aaea4bd2751301a6d7ee262bef89b74]

        Extended loplugin:ostr: sdext
        
        Change-Id: If4e8ccf288846fc768b3e035706a8bd0b2207f4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159678
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [142beb47ac285126aa5e2cbe9035394ecce952bf]

        Extended loplugin:ostr: svgio
        
        Change-Id: I5a93e5f0a3cfc0fd85ac53ba2f58131561508386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159675
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [75d256929387eb8258439808e830b73abcdf2d8b]

        Extended loplugin:ostr: starmath
        
        Change-Id: I24ab27d0f92d2d5d10ca2694138d7964ae947b62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159676
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [97516a3153efcc4996512139b8c80f20b9d246b4]

        Fix typo
        
        Change-Id: I4a1f624793c0bf2e97ee862b4599aa9c8fb9f9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159692
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [6ccd536aae8b5fb5ec01796a1d48d8c5e0b21582]

        Extended loplugin:ostr: svtools
        
        Change-Id: I4aa6ab1c132a5666b0ee4a4e9f68aaca58a38ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159672
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [23641bffb78fed4db99a0a906b6d80335340c9a3]

        Extended loplugin:ostr: svl
        
        Change-Id: Ia74b15213a05da36f48932811d70d231ec7ee164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159673
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [85c25ec9f198e9c335cb6f622acdab67a9c41f71]

        Extended loplugin:ostr: xmlhelp
        
        Change-Id: I8be963a7a2befe95ce30027c3298e1a41b217d0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [79e8a54893c4a95d732388326eecd1ad151017d9]

        Extended loplugin:ostr: svx
        
        Change-Id: I290b1c60c8030b5345a1c2fa3816e83e21967cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159671
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [7724e504be75fdf2a90b0ffc19dce3df76ed14a6]

        Extended loplugin:ostr: sw
        
        Change-Id: I210f61f6d90776b086b7058fb1a831d235699fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159670
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [35972b1fbe3dd26c2e384d6e65ef77ef90d5d2a3]

        Extended loplugin:ostr: test
        
        Change-Id: Ia4dfbd1afcf01028d8292ca656979d7017196244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159669
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [a0d65383417dfe36c09bc4758efb8d5896674ec0]

        Extended loplugin:ostr: unodevtools
        
        Change-Id: If72d80bd748186b974b37d58aa1469af1ffdb34d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159667
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [db9104a366a57cc66f87467af8a329772d3f3b52]

        Extended loplugin:ostr: tools
        
        Change-Id: I70df74d005c7fca14b1bcb70f4870023bd3af4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159668
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [156e7eafd76c819225a8bd77d0cf48fe19560c5f]

        Extended loplugin:ostr: xmlscript
        
        Change-Id: I1b476b6fb89ee04b4427ba1210eee9811a722f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159661
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [56c89190a2c717d6c24f2826f3b82ffe41b0ab6e]

        Extended loplugin:ostr: vcl
        
        Change-Id: I2a9d5383d1831d8bf61e5280d66556d71fccae52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159666
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [e4d8f186d07aa1999e16abff3381e37b8764e964]

        Extended loplugin:ostr: writerperfect
        
        Change-Id: Ib942f7725e224b7c4beaca4cd4d86b83f60cd3f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159664
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [694763542e32b1e6354f919526751677945f1cd9]

        Extended loplugin:ostr: writerfilter
        
        Change-Id: I83bdd43357d07bce18a2cf286e639c816846e7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159665
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Stephan Bergmann  <sbergman@redhat.com>  [0ea539f0eacfc22f8c1745ff261cbce45f5418e8]

        Extended loplugin:ostr: xmloff
        
        Change-Id: I87e53216693f2d6489a1dd80e62141ca5621a87f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159662
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-19  Sahil Gautam  <gautamsahil1947@gmail.com>  [b05905dc2da404fd307b4589ca2df424b1bb4d65]

        tdf#33201 Make Row/column highlight usable
        
        Row/column highlight shouldn't be updated using ScGridWindow::DrawContent
        because it would call for highlight refresh even when typing in a cell,
        leading to the text being hidden under the highlight.
        
        Change-Id: Ic7cc71bc94629c71e6efdf677b7f34d6c4d0cc93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159636
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-19  Julien Nabet  <serval2412@yahoo.fr>  [8158f016ea094ad48cdf11cd8ae46cd282af25d2]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 11)
        
        Change-Id: I2197c65248a96caa8ae621d5b1d16aa1086fc525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159643
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-19  Julien Nabet  <serval2412@yahoo.fr>  [7ad4641e79169e297a88ee9e62e9be3d74f7124e]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 8)
        
        Change-Id: Ia726fbbfd3f08eb4bb5c7ccaf10d65fe01ca6585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159639
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [f566a73adcf170d103b0561c7ea2871596af7142]

        Fix performance regression with ScPatternAttr/SC
        
        Due to the paradigm item change the test
          make CppunitTest_sc_tablesheetobj
        with CPPUNIT_TEST_NAME
          sc_apitest::ScTableSheetObj::testSheetCellRangeProperties
        got much slower. Unfortunately it did not break, so got unnoted.
        
        I took a look now. First I intended to add some hashing in an
        std::unordered_set using that hash values at ScPatternAttr, but
        that is not even possible due to other data in that item that needs
        to be compared. I had the impression that it was 'somehow' hashed
        before, but after debugging the version before that change I
        noted that also the list of existing items was linearly compared
        to the new entry, using the operator==.
        Thus the problem was not due to not hashing, but due to the
        ScPatternAttr::operator==. That uses the hash (not changed),
        but no longer finds equal entries.
        This is because the hash code is made up from the SfxPoolItemPtrs
        in the SfxItemSet, so when all are equal we can be sure the SfxItemSet
        content is equal.
        To use this the other way around is *not* correct: Even with
        not all ptrs equal the SfxItemSets can still be equal, simply
        by one SfxItemSet using another, but identical incarnation of
        an item. Thuis means that ScPatternAttr::operator== does not
        detect all cases of equality.
        This worked in most cases before since most items were
        'pooled' and thus much effort was used to ensure their uniqueness,
        but even before the paradigm item change an item type could be
        flagged as non-poolable. In that case, this already could fail
        but with no too bad consequences (just one more copy of
        an ScPatternAttr would stay).
        So I fixed that mainly in adapting and optimizing
        ScPatternAttr::operator==. The results are (same machine, same
        compiler, dbg version, metioned test):
        
        Version before item paradigm change:
        user    0m50,778s
        
        Version after item paradigm change:
        user    20m13,944s
        
        Version with memcmp:
        user    0m48,845s
        
        Version with hash:
        user    0m48,710s
        
        Since that hash does nothing else than to buffer the comparison of
        those item pointers I just tried to use memcmp instead, as is already
        used in other places (same file, ScPatternAttr::FastEqualPatternSets,
        also SfxItemSet::operator==). As can be seen above it makes practically
        no difference (memcomp even slightly faster).
        Since that hash is only used in ScPatternAttr::operator== and is same
        speed (memcomp linearly compares 56 SfxPoolItem ptrs) I decided to
        remove it. It needs quite some spaces to be reset and re-calculated
        which are not needed anymore. The calculation is based on dividing
        the number of items by 4, so we are good with 56, but if someone has/
        will adapt the items used by ScPatternAttr it is easy to forget to
        adapt this, and not easy to change the alghorithm  when it's not a
        multiple of 4.
        
        I also optimized/overhauled SfxItemSet::operator== (or better: the
        SfxItemSet::Equals used by it). It is now better readable, too.
        
        I also adapted ScAttrArray::AddCondFormat to not always incarnate/
        delete ScPatternAttr instances, only when needed. This also helps
        a bit and could be done in more places.
        
        All in all it is really necessary to cleanup SC's usage of
        ScPatternAttr - there are quite some possibilities to make that
        cleaner and faster. In principle it's a huge 'compromize' to use
        item functionailty to have a possibly 'cheap' maximum shared
        SfxItemSet at a Cell.
        
        Decided to make SfxItemSet::operator== even faster for the case
        of unequal ranges by iterating over ranges of local SfxItemSet
        and incremented offset. Still accesses to 2nd SfxItemSet will be
        the expensive ones using the iterated WhichID.
        
        Added two more things to SfxItemSet::operator==: We can return
        early when both have no items set. For the unequal-ranges compare
        I added an early-exit when Count() items were compared.
        
        Looked at the errors that indeed do trigger the assert in
        ScPatternAttr::operator== and hint to incarnations of ScPatternAttr
        that do not use the needed range ATTR_PATTERN_START, ATTR_PATTERN_END.
        Hunted down to come from ScViewFunc::ApplyAttributes and there from
        some Dialogs, so seems some SC dialogs do not work with the correct
        range schema for that item.
        I tried code in ScViewFunc::ApplyAttributes to fix it, that works. I
        also tried to hunt that down to the Dialogs that use the wrong schema
        (TotalCount @SfxItemSet is 61 BTW). While it would be possible to do
        so, it's no guarentee to have this fixed.
        Thus I looked at ScPatternAttr::ScPatternAttr and added correciton
        code when one with the wrong range schema gets created, this is
        luckily not often needed and transfers the existing items with low
        costs.
        Maybe we should add a warning there if used, so at least new
        implementations of stuff or old ones (the Dialogs) can be corrected?
        
        Change-Id: I31da73ae30786bd6c5a08a5e3b7df8fe279af261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159592
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-19  Julien Nabet  <serval2412@yahoo.fr>  [0c13d8b8d97666a4e23fc93601a0ced141434d78]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 10)
        
        Change-Id: I7681a3ed5af058cf4356509d54a2195e6d4833e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159641
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-19  Julien Nabet  <serval2412@yahoo.fr>  [0d84174d8c205a58fa1a64d44ae5629c40a9cf85]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 9)
        
        Change-Id: I61e53faf68e7e0fab2052122993197c7994441ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159640
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-19  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7618c791a39e74b0f8291ff28f65df78cfa20301]

        tdf#143148: Use pragma once instead of include guards in vcl/inc/win
        
        Change-Id: I57db27a6cbd45ec9f1ae666a3b8da23bbf5c20de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159649
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-19  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a688f401980646577d353e96d271499b9b720667]

        tdf#143148: Use pragma once instead of include guards in vcl/osx
        
        Change-Id: I0f6edb1f4ed5310bf0bb7d051852a4c86205431f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159647
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-19  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [9beb65b258f5e3e95ad4b86f2682c15ea1dac1af]

        tdf#143148: Use pragma once instead of include guards in vcl/source
        
        Change-Id: Ie19a3e16861946434342c7e07482ae649a4afb4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159646
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [4a1fac7c703068a49df897bb635ff98bf22c0468]

        vcl: add unit tests for simple text 'AV' with kerning and no-kerning enabled
        
        Change-Id: I72812c9fd83730daf62aeb4a300c548f153ee8a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159091
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [2195d87e62dae3465554be5a20a45b0a377845d2]

        vcl: simplify warning message
        
        Change-Id: Ie8ccf8bc5ba493987bebf38d8b1227c30bcd6e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158077
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [72eaff7b6af01f3b6d9754660ce231e74d501466]

        vcl: ImplIsCharIn() -> lcl_IsCharIn()
        
        Change-Id: I61b24783e39e9f904c48c0726024cd5fa122b724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158076
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [c0aacb30b73405f6d0213fcb85b53b6d0f0854d7]

        tdf#124176 vcl: Use pragma once instead of include guards in inc/textlayout.hxx
        
        Change-Id: Ie51fbc687002a6139dc98309cb7e1c39bb4de4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158075
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [696644462e1f3e43608319068db2bbc167e7b8f8]

        vcl: remove unnecessary includes from textlayout.cxx
        
        Change-Id: I4cef4b61c15cde5682b65590bebdc9981d38908c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158074
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-19  Cristina Mustatea  <cristina.mustatea@protonmail.com>  [5682e1d4145c26fc8021879df0543d5aeacf9c83]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I5da0bf7d780f5336ecfd17882e5bfd1ac7fb4a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157156
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-18  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d940c06078c6db581daa411a38ce264578b6aad1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 579bf8dd91ebc66108f8710452ea2280c81c1223
          - use "export" instead of "print" at PDF export options page
            
            Change-Id: I1c1bfcfab57b74129c5bb60fad89376c88e64dfd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159638
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [d0b0908e62fd6e4901061b43deeb8ae4cf2ed799]

        c++20: use std::erase instead of std::removed followed by erase (part 2)
        
        Change-Id: I0222f0f53f387dd57bd674b1e137b53487f4e1d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159611
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [e08efe99cdb8d2159b2714d0f23e62678348eaed]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 7)
        
        Change-Id: I2a72422a6c8185d17876daac41a86137048b034c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159627
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [4aa5e93a802af2228e4418aceec29d2aafa9b5de]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (include part)
        
        Change-Id: I32ac73e1ada08bfaa29e654f26fc89257733cd79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159614
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [06e469623307821e8a1c4b0a3a2aa6f3dd202da6]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 6)
        
        Change-Id: Ic073d7444e968e90068aa60847bc9211167f6278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159626
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [597ba50a18ad9101cb5fa506b200fea12b580aa6]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 5)
        
        Change-Id: I373e5185e53ce88fba36d69d0fc20c29bb89d184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159625
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [4bbd9853afde9456c1c5bc16eca3b775e53a01fe]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 4)
        
        Change-Id: I6af5501e3fde07024dcc74f00c8fd69bd369d8d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159613
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [6e587b15efb824c97e103d86d360c590918263c4]

        c++20: use std::erase(_if) instead of std::remove(_if)+erase (part 3)
        
        Change-Id: I1ea95e0bfeaed88b9484403e6796574f1d06f133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159612
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [c05595d2420b92a428b45cfaf65a3adf88fd8bed]

        c++20: use std::erase instead of std::removed followed by erase (part 1)
        
        Change-Id: I8d038fc37a4de25bdeff2e2cc55775e3981240b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159610
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-18  Julien Nabet  <serval2412@yahoo.fr>  [79d9195b954f7a815ddae9562c59fce4dd7c4351]

        Remove useless using + once use of replace pair by std::pair
        
        Change-Id: Id283ac7909f19dabb98886caa1f2960d9098ddbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159628
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-11-18  t-aswath  <aswatht.cse2022@citchennai.net>  [0264999bb3746a9c68938edd1a6fc05a8e40b406]

        tdf#157716 - Rename "Language settings" to "Languages and Locales"
        
        Change-Id: Idd31b18c87998b03d884e7aa17197c459241abf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159315
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-11-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bdf99cc80da2bef5a1dceaec742bca69363dbea0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7137f1de0c227bb33997436ec5e64bea05d1b6b5
          - Fix HTML page title
            
            Change-Id: I8241c7a36fb419c687bc950b23d7bc6b736522b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159580
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b1c30c23cf53629a3a2d0a49d8bc33f96e805598]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to efd47e8d208604d311f39ebddb5f51a1dc46d6e0
          - Remove dup bookmark
            
            Change-Id: Iebd95831283404b2673b0c4ee15b53bdab9b716f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159579
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-18  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a1ed8fe97c8ebf8de97659dc89ff6ac245254889]

        Latest VS 2022 Preview is 17.9.0 now
        
        ...while latest proper VS 2022 is 17.8.0
        
        Change-Id: I40905f3d79c3723796c4c9964f72d0fed73795c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159607
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-18  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [2c71560cf64499365e803f710c788d033da0e5e9]

        Related tdf#49895: Mark strings as translatable
        
        ...and add context strings
        
        Change-Id: I2531fc9e24db7e99b440b8042b8a502a2faaa2b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159567
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8369765ec5be151082a6e31c16e2ab2b0df13f5c]

        cool#6893 pre-init dictionary list
        
        so the forked processes don't need to
        
        Change-Id: Id37688ac88c14679e216cca744563ee75c7c4736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-17  Michael Stahl  <michael.stahl@allotropia.de>  [8d87164becccc230e1e0ad5ac51bf645744165a2]

        sd: remote: check that received commands have expected arguments
        
        Change-Id: If4b5fe0362a40d14d68829bffb79f91ae9745835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159590
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [35f59457ff434b7b97cad6ce1dbef6ff07f7bc96]

        tdf#158135 - UI: Part 30 - Unify lockdown behavior of Options dialog
        
        for Writer - Compatibility Page.
        
        Change-Id: Id9ad445b451b332314f72f54e183730097584a74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159513
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-17  Sahil Gautam  <gautamsahil1947@gmail.com>  [487e30bec174342fff07f1f8cc76c9beed4c4843]

        tdf#33201 Highlight current row and column in spreadsheet
        
        Highlighting functions added
        
        Change-Id: I65335538e394d048731c13ac87535502ea97dfa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158680
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-17  Julien Nabet  <serval2412@yahoo.fr>  [39f83d3dc2fbcadab759b49f0f36b39b8dc266d8]

        createmsi: retrieve file handle explicitely so we can close it at the end
        
        Seen on https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_win_wix/3/console
        [build PRL] CustomTarget/instsetoo_native/install/install.phony
        Exception ignored in: <_io.FileIO name='lo.json' mode='rb' closefd=True>
        Traceback (most recent call last):
          File "C:\cygwin64\home\tdf\jenkins\daily_workspace\tb\src_master\msicreator\createmsi.py", line 42, in __init__
            jsondata = json.load(open(jsonfile, 'rb'))
        ResourceWarning: unclosed file <_io.BufferedReader name='lo.json'>
        
        Change-Id: I98b7436e4e870f4cbcd31a41a4e9d0e84249f5f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159566
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-17  Stephan Bergmann  <sbergman@redhat.com>  [533e993f2d11814252c40d60bdab469de03b14db]

        Don't reuse --unit values across (sequential, even) systemd-run invocations
        
        At least some old versions of systemd-run apparently have occasional issues when
        sequential invocations reuse the same --unit value, as
        <https://ci.libreoffice.org/job/lo_ubsan/2982/> now (i.e., after the machine was
        updated to auto-detect --with-coredumpctl) failed with
        
        > [build CUT] basctl_dialogs_test
        > LO_TEST_LOCALE=de
        > Running scope as unit: -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope
        [...]
        > LO_TEST_LOCALE=en-US
        > Running scope as unit: -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope
        [...]
        > LO_TEST_LOCALE=fi
        > Failed to start transient scope unit: Unit -home-tdf-lode-jenkins-workspace-lo_ubsan-workdir-CppunitTest-basctl_dialogs_test.test:20231117013657:704127.scope already exists.
        
        Change-Id: If009e26231228bec739637e4140be90c0b86d6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159569
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-17  Michael Weghorn  <m.weghorn@posteo.de>  [1750078e3ace30d3ad9798feb81239688b1ea869]

        android: Update app-specific/MIME type icons
        
        Just as
        
            commit 2105f638fa178f49210116bd914889599930b62a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Nov 17 09:11:42 2023 +0100
        
                android: Update app icon to new startcenter icon
        
        updated the main icon for the Android app, also update the
        MIME type icons that are shown in the "Recent files" section
        in LibreOfficeUIActivity to the new ones meant to be used
        for Calc/Draw/Impress/Writer since 7.5.
        
        Change-Id: I1d969a290caa3c23589e78151cd5bf70144c3099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159568
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-17  Regina Henschel  <rb.henschel@t-online.de>  [270b7efe92751a46c3d85e856b932a365c5f5b73]

        Add getUnicodeTokenName() to StaticTokenMap and use...
        
        it in several places. Currently these places get a Sequence<sal_Int8>
        by call of StaticTokenMap().getUtf8TokenName() and immediately after
        that generate an OUString from it using reinterpret_cast<const char*>
        and the OUString ctor with 8-Bit character buffer array. The patch
        moves this conversion to StaticTokenMap.
        
        Change-Id: Ia2af110e2a0f1708e0685115d325c1c12cab3857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159514
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-11-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [5af2041c551e97903d2ba7994c5e893836891832]

        tdf#154543 - Paragraph dialog: reset snap to grid to parent setting
        
        Added the SID_ATTR_PARA_SNAPTOGRID to the alignment ranges in order to
        reset the snap to grid option to the corresponding parent setting.
        Without this parameter, the main dialog does not have any knowledge
        about this option.
        
        Change-Id: Ib090fae0919be54dd41674d129f5355c3566a90c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159565
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-11-17  Mike Kaganski  <mike.kaganski@collabora.com>  [fb789aff45773c2b161376d13dd660b80af0d157]

        Simplify a bit
        
        Change-Id: I41ed6256a5933aaadd385bdf9b9aa8469aa71187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159575
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-17  Michael Weghorn  <m.weghorn@posteo.de>  [2105f638fa178f49210116bd914889599930b62a]

        android: Update app icon to new startcenter icon
        
        Update the icon used for LibreOffice Viewer
        with the new icon used since LibreOffice 7.5 [1].
        Use the startcenter icon from `sysui/desktop/icons/hicolor/`
        and export for the required resolutions where it doesn't exist
        yet.
        
        [1] https://wiki.documentfoundation.org/ReleaseNotes/7.5#Design
        
        Change-Id: Ie9f59d42bbc9375e7ca433c6452223b7ba3033a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159554
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-17  Michael Weghorn  <m.weghorn@posteo.de>  [129c493adc3d572e2417e62bc96d7b2cfbe0d983]

        android: Reuse launcher icon in activities
        
        Instead of duplicating the icon as drawable,
        just use the one from the mipmap folder that's
        used for the app launcher.
        
        Change-Id: Idd6691c4639fb570357280cec63636d07fe06b20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159553
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [521ca9cf6acbae96cf95d9740859c9682212013d]

        we can have just one LoadURL for writer
        
        Change-Id: Ia0162ee1c275292fcf200bad4662e4c2c6b7b972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-17  Miklos Vajna  <vmiklos@collabora.com>  [871ca5dd73b34086fad1e57d4697f43a6739a11d]

        sw floattable, delete UI: add an uno command to unfloat frame from context menu
        
        Word has an easy UI to turn floating tables into inline ones. Writer had
        a similar button, but that had a few shortcomings:
        
        1) It was only visible if a non-split frame was too large to fit the
           page.
        
        2) It was a separate VCL widget, so invisible to LOK clients.
        
        3) It only worked for frames which had a single table in them.
        
        Researching the problem, it's interesting how deleting a frame always
        deletes its content as well, but e.g. deleting a section just removes
        the container but leaves the content in the body text.
        
        Fix the problem by adding a new menu item in the context menu that
        always allows converting the frame to inline content at the anchor
        point. This can share a bit of code with the old unfloat button.
        
        The undo/redo still needs fixing, in a follow-up change.
        
        Change-Id: I8ce05c9f958b08cb599fd5d2a27e770182f28cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159550
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-17  Stephan Bergmann  <sbergman@redhat.com>  [63a5687e84c5f75990a6052658fb5676f7cc2767]

        Missing parenthesis
        
        ...from e514f1a462f5fe2d1ef2d58fa3a0ef94892c41fb "fix --enable-wix switch - that
        didn't do anything"
        
        Change-Id: I4d8124152d5dcb97a11d6fced071ac428ac09bb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159551
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-17  László Németh  <nemeth@numbertext.org>  [c1803de8a093739d189be54b2d9bd5634e9e79ee]

        tdf#119908 sw smart justify: add unit test
        
        Follow-up to commit 17eaebee279772b6062ae3448012133897fc71bb
        "tdf#119908 sw smart justify: fix justification by shrinking".
        
        Change-Id: I88cc7876c06729f81b9d61fed7456be801dc6373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159525
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-17  Michael Stahl  <michael.stahl@allotropia.de>  [191babee4f0ec643b80e96b0cd98c2d04ff96e4e]

        sw: fix layout crash in SwObjectFormatterTextFrame::DoFormatObj()
        
        Since commit 15b886f460919ea3dce425a621dc017c2992a96b this is happening
        in testForcepoint93, but only on WNT.
        
        The crash is in SwObjectFormatterTextFrame::DoFormatObj() calling
        SwObjectFormatterTextFrame::InvalidateFollowObjs() and the mrPageFrame
        has been deleted; there is also the m_bAgain flag set in the SwLayAction
        up the stack, but the SwObjectFormatter::mpLayAction is null so
        DoFormatObj() cannot check this condition.
        
        In the caller CalcContent(), get the SwLayAction from the SwViewShell
        and pass it to the SwObjectFormatter, which appears to fix the problem.
        
        Change-Id: Ib3dc34ce39b4aad723251271c24bdd7a6598ab1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159518
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-17  Miklos Vajna  <vmiklos@collabora.com>  [3526faf09bd86a4f18fe606a3818e816c41d8c85]

        sw: extract SwTextFrame::dumpAsXmlAttributes() from SwFrame
        
        Allows getting rid of a static cast.
        
        Change-Id: Ic74bb3e33f591387cc5939c0ffbc8793630978bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159517
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-17  Julien Nabet  <serval2412@yahoo.fr>  [be1093cce53a3c34a67233391922674c7c62f4e3]

        c++20: use std::erase instead of std::removed followed by erase
        
        See https://en.cppreference.com/w/cpp/container/vector/erase2
        
        Change-Id: I26744e74b34d1efa1524a1f88aa3af9e153bc9ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159515
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-17  Stephan Bergmann  <sbergman@redhat.com>  [363b4078be25b41f3226485abd3818964d7d9cd3]

        Manual extended loplugin:ostr change
        
        Change-Id: I003851390566dfe2b98cecc88afc8153f061ad68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159522
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-17  Stephan Bergmann  <sbergman@redhat.com>  [a93dd64747f21ff35ff0fde287f691ab23de6ccc]

        Manual extended loplugin:ostr change
        
        Change-Id: Ic0418ba78851183deba2555943cf26934b982378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159521
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-17  Michael Weghorn  <m.weghorn@posteo.de>  [8383c3b1126d5e22b343bb9ef7b43cf6a19c56f2]

        gtk4 a11y: Map BLOCK_QUOTE role to new gtk equivalent
        
        Map the role to the `GTK_ACCESSIBLE_ROLE_BLOCK_QUOTE`
        equivalent newly added to Gtk 4 in commit [1]:
        
            commit bbb0150383e6aabdbead635f1751322530392b3a
            Author:     Michael Weghorn <m.weghorn@posteo.de>
        
                a11y: Add block quote role
        
        With this and the gtk commit in place, Accerciser shows
        the block quote role for Writer paragraphs using the
        "Block Quotation" paragraph style as expected.
        
        Also needs a bump of the gtk version to >= 4.13.4
        on the gtk "main" branch after the 4.13.3 release for
        the `GTK_CHECK_VERSION` check to pass and actually make
        use of the new role, see MR [2].
        Omit the fallback to `GTK_ACCESSIBLE_ROLE_PARAGRAPH`
        for Gtk versions >= 4.13.1 but < 4.13.4,
        since they are all development versions for the
        same stable release 4.14.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/bbb0150383e6aabdbead635f1751322530392b3a
        [2] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6574
        
        Change-Id: I2c17da13867a61f0e6819913583392962cfd44a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158685
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-11-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [53f91fb880a5360ace7d0de5fce785088c8d19d6]

        update credits
        
        Change-Id: I1c4a240ba3af7805865b96fbee4911c022cac897

2023-11-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e514f1a462f5fe2d1ef2d58fa3a0ef94892c41fb]

        fix --enable-wix switch - that didn't do anything
        
        it used the wrong variable name in AC_SUBST and also had no place where
        it would be set for the rest of the build to use.
        Also the script hardcodes the location of the WiX Toolkit, so check for
        the same path in configure.
        Also it was needlessly tied to LIBO_TEST_INSTALL - since it has its own
        conditional, "double-guarding" it is not necessary.
        
        Change-Id: I6dd4a41e63d2a43a3e2f1aac5b6799a6601eb656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159510
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [d343a2b6393aec2eba0d25d7f4f390f12d1515f6]

        tdf#146386 deprecate, remove usage of Inet::Settings::ooInetFTPProxyName
        
        * officecfg: deprecate Inet::Settings::ooInetFTPProxyName/Port
        * ucbhelper: stop handling these settings
        * sfx2: remove SID_INET_FTP_PROXY_NAME and SID_INET_FTP_PROXY_PORT
          and usage from SfxApplication::GetOptions()
        * shell: remove proxy config code from backends
        * stoc: the JavaVM would have its "ftp.proxyHost" properties set based
          on officecfg values; remove that
        * sysui,vcl: remove protocol from KDE desktop files and file picker
        
        Change-Id: Iba02676cf6e519e2fa60ba925209436d38e75f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159500
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [4c40fe59893709f87e72f0dd36e859591d253189]

        tdf#146386 cui,sc,sw: Office::Common::Filter::HTML::Export::LocalGraphic
        
        Adapt its usage to removal of FTP UCP; the target protocol check in sc
        and sw was particularly silly.
        
        Change-Id: Ib94501ebcc589e257e9b882a340e18ef1a791584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159499
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [764e2a5a3e6cfba8cf463796aca1451859a52b6e]

        tdf#146386 remove references to FTP UCP code
        
        Change-Id: I85f83c3d83f3de59a929ed053e0e92bb10bdcc5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159498
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [a6627b526a362d0aed9a5ea5856dca3b9e3655af]

        writerfilter: fix utext()'s dumb sal_uInt8* parameter
        
        This removes all but 4 reinterpret_cast in the module!
        
        TableManager::utext() even assumed that the bytes are little-endian.
        
        Change-Id: I12031336cabedfd6c0fb614ee0e3400810f98e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159486
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [15f54c82d136e6fee3a65494f3b5271857b5d6b8]

        writerfilter: remove DomainMapper::text() handling of paragraph break
        
        Convert all remaining callers to utext().
        
        Change-Id: Ie1fdf22e9e474289df2c72eadc236ec6b270df4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159485
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  László Németh  <nemeth@numbertext.org>  [17eaebee279772b6062ae3448012133897fc71bb]

        tdf#119908 sw smart justify: fix justification by shrinking
        
        Shrink the exceeding lines by shrinking the spaces
        between the words.
        
        Because the negative spacing values are used
        for the extra space between the characters in the main
        data structure of the justified line layout, and not for
        the space between the words, like the positive values,
        the negative space values for shrinking are stored over
        LONG_MAX/2 as absolute values to avoid of bigger changes
        of the data structure before designing a better
        justification algorithm, where it's possible to mix
        different methods for the more visible text layout.
        
        Note: the text cursor doesn't follow the new word
        positions yet.
        
        Follow-up to commit 7d08767b890e723cd502b1c61d250924f695eb98
        "tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt."
        
        Change-Id: I9a63b5a93d6bce230e963ebc88ea2d0f9aa8fffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159511
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [454e5010aec9953f586fe8af671765358f6cafc4]

        tdf#153194 writerfilter: RTF import: testContSectionPageBreak last para
        
        For testContSectionPageBreak, Word inserts an additional empty paragraph
        at the end of the document that was missing in Writer.
        
        Ensure markLastSectionGroup() is always called at the end of the
        document so that the \par that is dispatched in m_bNeedPar case will be
        inserted and not automatically removed immediately.
        
        Also add a test for the same document without \sbknone, which has 4
        pages instead of 2.
        
        Change-Id: Ib3e4fbdb66df55941e4a487d4b249cd98fe42008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159472
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [7b3f68257b7b6781dd22830bc118cb0ef92fb113]

        writerfilter: DomainMapper: fix undetected merge conflict
        
        ... between commit fce18155052821756466ea043c638f4ed72f41d6 and
        commit 15b886f460919ea3dce425a621dc017c2992a96b - move the code from
        lcl_text() to lcl_utext().
        
        Change-Id: Iaa515d2ebd9861e24b442b0d7b41f83662ed58df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159501
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Michael Weghorn  <m.weghorn@posteo.de>  [5d4ecaa33cb5700893f0df9ae2335f65349706b1]

        android: Add missing make dependency
        
        After
        
            commit f9b9e702465b4de29153b49e077c70a0ad78c89d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 15 13:26:38 2023 +0100
        
                android: Add button to open privacy URL
        
        , Android Jenkins builds started to fail intermittently
        (e.g. [1]) like this:
        
            > Task :stripStrippedUIEditingDebugDebugSymbols
        
            > Task :compileStrippedUIEditingDebugJavaWithJavac FAILED
            /home/tdf/lode/jenkins/workspace/android_x86/android/source/src/java/org/libreoffice/AboutDialogFragment.java:93: error: cannot find symbol
                    final String privacyUrl = BuildConfig.PRIVACY_POLICY_URL;
                                                         ^
              symbol:   variable PRIVACY_POLICY_URL
              location: class BuildConfig
            Note: Some input files use or override a deprecated API.
            Note: Recompile with -Xlint:deprecation for details.
            1 error
        
            FAILURE: Build failed with an exception.
        
        This seems due to the pre-existing issue of a missing
        dependency of the `liboSettings.gradle` target on
        `android/Bootstrap/Makefile.shared`, so a change
        to the latter would not have caused the former
        to be regenerated and any old one still around
        that didn't set the new build config variable
        would get used, resulting in the above error.
        
        Issue reproducible locally:
        
        * do a local Android master build
        * `git revert f9b9e702465b4de29153b49e077c70a0ad78c89d`
        * `rm android/source/liboSettings.gradle`
        * `make`
        * `git cherry-pick f9b9e702465b4de29153b49e077c70a0ad78c89d`
        * `make`
        
        [1] https://ci.libreoffice.org/job/gerrit_android_x86/33773/console
        
        Change-Id: I87275fc71d93f460dfad4d75fc197b8ed8cd9922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159497
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [502f7958d99e3aa27f4c1c1f33f4827055459da8]

        pass a frame to use as parent for any dialog that may need to appear
        
        which avoids: sfx2/source/appl/appserv.cxx:314: no parent for dialogs
        
        Change-Id: I71734b42f3206fc724e5a3d5538072dc775f0b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0df175ccc6ea542bc5801f631ff72bed187042eb]

        combine these hyperlink dispatchers into one call
        
        Change-Id: Icb7822e811013de648ccf2fbb23a5f0be9e29bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159489
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [32535dfa82200b54296838b52285c054fbe5e51d]

        reuse AllowedLinkProtocolFromDocument in writer
        
        Change-Id: Iacf5e313fc6ca5f7d69ca6986a036f0e1ab1f2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159488
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e6a7537762e19fde446441edd10d301f9b37ce75]

        reorg calc hyperlink check to reuse elsewhere
        
        Change-Id: I20ae3c5df15502c3a0a366fb4a2924c06ffac3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [60f001962122a77863231e9cf5dc445c136aac43]

        tdf#157789 Comment size wrong behavior when zooming document
        
        Revert
            commit 8d18b5af883bb6b56e758801ee730a08bb88a8f5
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 13 10:11:08 2023 +0200
            speed up rendering annotatins, cache meta height
        
        Change-Id: Ib0bae3fd9020200d09c5b37baf5ae882c8532e58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0c68499ab36d2a1bdf6f1bc7d4cd259b99700e7]

        tdf#158224 Cannot convert bitmap to polygons
        
        regression from
            commit a76a135c9e9bdecd38970e293e72eeeeca000d27
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Jan 3 20:14:21 2023 +0200
            flatten some vcl code
        
        Change-Id: Ibb2a059b283dc2e3bf3fecbf24ff71332a204d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159495
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [15b886f460919ea3dce425a621dc017c2992a96b]

        tdf#153194 writerfilter: RTF import: \spltpgpar
        
         1. Some experimenting with the bugdoc (saving it to DOCX in Word
            changes the layout in Word to exactly what Writer imports from RTF!)
            leads to DOCX w:splitPgBreakAndParaMark setting.
        
         2. the RTF implementation of \spltpgpar was missing; apparently if the
            flag is present the "new" behavior is in effect, which is the
            opposite of how it's specified in RTF Spec 1.9.1.
        
         3. the DomainMapper code that uses this attribute is not in the text()
            function to which RTFDocumentImpl sends paragraph breaks, but in the
            utext() function, so send the break there instead, rather than
            creating even more copypasta.
        
         4. now some filters-text crashes with nullptr pContext in
            DomainMapper::lcl_utext(), avoid that.
        
         5. dispatchSymbol(m_nResetBreakOnSectBreak) doesn't do anything because
            these are handled by dispatchFlag().
        
         6. Test name: testFdo81892::Load_Verify_Reload_Verify
            equality assertion failed
            - Expected: Performance
            - Actual  :
        
            Fails because additional paragraph break inserted after \page; in
            dispatchSymbol() for \sect, remove the parBreak() as already hinted at
            in commit 3c610336a58f644525d5e4d2566c35eee6f7a618
        
         7. rtfimport.cxx:868:Assertion
            Test name: testContSectionPageBreak::TestBody
            equality assertion failed
            - Expected:
            - Actual  : THIRD
        
            It has no paragraph between SECOND and THIRD, whereas Word
            definitely shows a paragraph there.  In dispatchSymbol() for \sect,
            sectBreak() is not called (which may create a paragraph break); in
            m_bIgnoreNextContSectBreak case this needs to be done manually for
            cont-section-pagebreak.rtf to get the empty paragraph between SECOND
            and THIRD.
        
         8. testFdo52052 fails; in dispatchSymbol() for \sect, if the document
            ends with \sect (e.g. fdo52052.rtf) a paragraph break must be
            inserted after this (because DomainMapper unconditionally removes
            the last paragraph break), but not via m_bNeedCr as that creates
            unwanted page break in testNestedTable (m_bNeedCr =>
            dispatchSymbol(\par) => m_bNeedSect => sectBreak()); handle it in
            RTFDocumentImpl::popState() for the end of the document by
            dispatching \par.
        
         9. rtfimport.cxx:1519:Assertion
        
            testTdf108947 now has 1 empty paragraph in the header instead of 2;
            Word also shows only 1 so it's an improvement.
        
        10. Test name: testFdo49893_2::Load_Verify_Reload_Verify
            equality assertion failed
            - Expected: 1
            - Actual  : 0
            - xpath should match exactly 1 node
        
            This was reduced to only 2 pages, while Word shows 5; in
            dispatchSymbol() for \page, for the consecutive \page send an empty
            string to DomainMapper's utext() which causes a paragraph break to
            be created if \spltpgpar isn't set (this was not at all obvious!).
        
        11. testTdf133437 fails with some numbers of flys changing, but it had
            those values before commit 3c610336a58f644525d5e4d2566c35eee6f7a618
            which says "the exact number isn't that interesting".
        
        12. testTdf153613_anchoredAfterPgBreak4 fails, but it now looks as in
            Word, so this is a bugfix.
        
        13. Jenkins build on WNT (only) crashes in testForcepoint93 in sw
            layout code - disable test for now, debug asap.
        
        Change-Id: Ia1063693d96adff900ece943020a5bf69bdeb7a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159471
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-16  Miklos Vajna  <vmiklos@collabora.com>  [2f42d8acd2d06f848c9e680c42a0f7834a9a641f]

        sw floattable, delete UI: fix unfloat button for cant-split frames
        
        Open sw/qa/extras/uiwriter/data/unfloatable_floating_table.odt, select
        the TextFrame, click on the "unfloat" button that appears, then nothing
        happens.
        
        This is a problem since commit 51379fb3d46e5891bdaea0122bd62b0753663da3
        (weld writer's FrameControl MenuButtons, 2020-12-03), the old
        MouseButtonDown() callback is never invoked.
        
        Fix the problem similar to what SwHeaderFooterWin does, which works:
        instead of overriding the dead MouseButtonDown(), explicitly connect the
        click handler to the weld::Button widget.
        
        Also adjust SwFlyFrame::ActiveUnfloatButton() to use the welded
        callback, this way CppunitTest_sw_uiwriter2's testUnfloating covers the
        fix.
        
        Change-Id: I1180fc6a0ae2df7c01c273a5ef92dd8915ca70a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159493
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-16  Miklos Vajna  <vmiklos@collabora.com>  [06e3877dc2cf22e00d04b48453e9ab0b948c3ca2]

        comphelper: use c++20 contains() instead of find() and end()
        
        Whether an element is contained inside a container is better to be
        checked with contains() instead of find() because contains() conveys the
        intent more clearly.
        
        Change-Id: I267d915c95fcf9c98b2e11daa89c8fe801e59a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159484
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c0fffdc36df687fe8e4eff49e5a00d3a3c1eb370]

        [API CHANGE] Remove deprecated Password config item
        
        Deprecated since c51ef466f736c9e0e192d2c7feeda0a39bca2011
        
        Change-Id: I9509a17de09e618c5d4b914b7ac1202cb76f506e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157485
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f271ec5cd98ae32fd643df33174136d0a91a1941]

        Format optaboutconfig with clang-format
        
        Change-Id: Ia696e096f972fe722920238c3710d20a3f03b221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159374
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1f874d384228867ee450d3e1d53c821519b51722]

        expert config: Proper editing support for numbers
        
        Change-Id: Ib97e027cedfdf2c5bb3c956aeee75af25198e498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159355
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-16  Jim Raykowski  <raykowj@gmail.com>  [7f79b0caf194ff9d7dfa2f85379a5c752c905476]

        tdf#158179 Fix layer tab menu layer visibility check menu item
        
        Renames/reworks the layer tab context menu visibility check menu item
        from 'Show Layer' to 'Hide layer' and fixes a bug that causes the
        check menu item to be set as the layer visibility setting of the
        previously selected layer tab.
        
        Change-Id: I81f1910f95df50255e61115b5d8de8ed3ef8bd89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159427
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5fe2bf914c251009ec4709fa8fdc45c3b53f676b]

        Fix typo
        
        Change-Id: Iab90ee3e42390d9f68a5b2ac0e4d0e2e3eb37a80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159439
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6527c4f75f574105f61561d629f2c8d051483d65]

        Fix typo
        
        Change-Id: Ifc1b536a003194de5271b348c363bf4bd9b9a9e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159437
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5f72ab66b16d39db124eed5834fc715f8807da21]

        Fix typo
        
        Change-Id: I6bbf45f4aaf7412864bdb6697184616f7ef14138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159438
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e562fc75dcf1582ea2201ae91e9c5ac3c99848a7]

        Fix typo
        
        Change-Id: I912f5e5a035d00e7640d489b1ff1c7a3c0315b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159442
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6e4ea6d73b2a4f3ae56169933d82596f92e88f0d]

        Fix typo
        
        Change-Id: I24bda03e65353510810a08a6df6061e21e11915a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159441
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [201e288e9886987eae467035b42863ac032f7e8f]

        Fix typo
        
        Change-Id: Ia0082b62e8dd6e93267995140fc61b91b6080cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159440
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [ed72c6fbfa02cf98cb0d0f761ef5a7b9ffb894bc]

        tdf#157518: enforce password policy on sfx2/ui/password.ui
        
        Change-Id: I115b5b05ed82f2f900bcd70ec4f52c7f749544e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159443
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-15  Regina Henschel  <rb.henschel@t-online.de>  [6550c248521b65a367b33ba8db95d17a9a350800]

        Add comments to import of Wordprocessing Canvas
        
        Change-Id: I09af78b08fed886e36beca1770db6fc54a72b707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159473
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-11-15  Oliver Specht  <oliver.specht@cib.de>  [7a4a5de2d932b6edfc53b6742029e266c52fa127]

        tdf#157992 update error position after modifying input
        
        a manual fix in the text changes the start/end position of the error
        that needs to be updateed to find the correct error text when applying the change
        
        Change-Id: I91b0801d5a08ee9e2508493cce03b8112c48a542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159449
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [fed7b3068dcea2ebf65314c4f212350720631706]

        tdf#157518: enforce password policy on setmasterpassworddlg
        
        Change-Id: I7e7adde8f0d55808d16dc9247954a7645a1d3601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159384
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-15  Justin Luth  <jluth@mail.com>  [32d0efa9d934ec45f2863a285d250dfc0ab137e8]

        tdf#158031 editeng: rename GetFieldAtCursor
        
        because it doesn't really get the field at the cursor,
        and certainly is not similar to SelectFieldAtCursor.
        
        It first gets the field under the mouse.
        Then, if there is a selection, it gets the selected field,
        else it looks for the field on either side.
        
        There were LOTS of places where it
        probably had not been used properly.
        
        Most of those are gone now, so it is easier
        to rename the function.
        
        Change-Id: I1a64af24092582cf865509d2a474080258edd76c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159022
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-11-15  Justin Luth  <jluth@mail.com>  [33ec38c5333e0c71aa995292fbddc1a237979e32]

        tdf#158031 editeng SID_HYPERLINK_GETLINK: use GetFieldAtSelection
        
        This is just a clean-up commit to eliminate the pointless
        check of a field under the mouse pointer.
        It is up to the caller to make sure that the field is selected
        before calling the GETLINK function.
        
        GETLINK is primarily used to get the link from a field
        for the insert/edit hyperlink dialog.
        
        This function SHOULD NOT check before the cursor for the link,
        or else it will mess up the insert hyperlink if the user
        is inserting one field directly after another one.
        So, my changes here are just following what already existed in sw.
        
        Change-Id: Iaa7699d2e5f2fdf26996aede8b35bd4e18b21b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159021
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-11-15  Justin Luth  <jluth@mail.com>  [ac0b3ff84522a388e0d44b09bf681af13a8288b2]

        tdf#158031 editeng SID_REMOVE_HYPERLINK: use AlsoCheckBeforeCursor
        
        This patch depends on prior patches for this bug report.
        
        This is mostly just a clean-up patch to make it function like the others.
        It was a lot like EDIT_HYPERLINK - because it selects the hyperlink first,
        so it didn't need any fixing up.
        
        However, there was one instance where KEYBOARD selection of
        Remove Hyperlink in Draw could have been cancelled/slot-invalidated
        if the mouse had been moved away from the field.
        
        Change-Id: Id1b911f2548b8e2751ae34a2158ee4984dfc9a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159018
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-11-15  Justin Luth  <jluth@mail.com>  [0fc96d9b54e5a64c528bbf7fcdf9b71d74be8920]

        tdf#158031 editeng SID_OPEN_HYPERLINK: use AlsoCheckBeforeCursor
        
        This patch depends on prior patches for this bug report.
        
        This fixes nothing being opened if the mouse was right-clicked
        over that second half of the hyperlink (since a "smart" positioning
        set the cursor after the field instead of before it).
        
        Note that for some reason, OPEN always seemed to work with the mouse,
        even though other hyperlink menu options using the same code
        failed to find the field! So this code change is mainly for consistency.
        
        However, I WAS able to make it always fail,
        by moving the mouse away once the popup menu arrived,
        and then using the KEYBOARD to "Open Hyperlink".
        In that case, it always failed (because the field
        was not selected, and not under the mouse).
        
        Change-Id: I8fcd0386de6cea8c6a937afb6f63061ed62d4cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159016
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-15  Justin Luth  <jluth@mail.com>  [aaca48eb12357fa5cf23054fe77554bcfff74e95]

        tdf#158031 editeng SID_COPY_HYPERLINK: use AlsoCheckBeforeCursor
        
        This patch depends on prior patches for this bug report.
        
        This fixes nothing being copied if the mouse was right-clicked
        over that second half of the hyperlink (since a "smart" positioning
        set the cursor after the field instead of before it).
        
        Change-Id: I6c933224cd8d36f48f4e1f0aafaa1f45555e46d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159015
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-11-15  Justin Luth  <jluth@mail.com>  [023a2de2a8ef4bdcd9877e60f8739366de3a763c]

        tdf#158031 Revert "Resolves: tdf#137445 use the DisableEditHyperlink state
        
        ... as of menu launch time"
        
        This code is now obsolete from generic changes for bug 158031,
        so revert 7.1 commit eb395e21a7b1f15de664c4b207dc9e130aa635cf.
        
        It was a fine idea, but overly complex, dependent on invalidations,
        and hard to re-implement everywhere it would be needed.
        
        Instead, just also check before cursor for a field.
        
        Change-Id: I08354e32fefb66ff051458097d3bd07946198a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159014
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-15  Justin Luth  <jluth@mail.com>  [61d2d34b882b2b89c6702b04764058931ba70d60]

        tdf#158031 Revert "tdf#140361 use the DisableEditHyperlink state
        
        ... as of menu launch time"
        
        This code is now obsolete,
        so revert 7.3 commit d9a5302ca8bef90914539c12adb6c81496c28504.
        (This cleanly reverted with the relevant portions of
         the following code-refactor commits also reverted.
            commit 29489b33b435683021b72cb2bce27aba8cb7a430
            commit 68e797402692c5c8abf1b2c4374e12a8d2707d07
        )
        
        It was a fine idea, but overly complex, dependent on invalidations,
        and hard to re-implement everywhere it would be needed.
        
        Instead, just also check before cursor for a field.
        
        Change-Id: Id570fc4e33611b217eae8b2a2a85aa58e23d9d1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159013
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-15  Justin Luth  <jluth@mail.com>  [f2a5d091ba9f01a26139e6fc2f3c2bcfd0a6cf3b]

        tdf#158031 editeng SID_*_HYPERLINK: use AlsoCheckBeforeCursor
        
        This fixes the GTK3 problem where only the first half of the link
        successfully ran SID_EDIT_HYPERLINK against an editeng hyperlink.
        
        Fixed for Writer and Calc editeng hyperlinks (i.e. in textboxes).
        
        TODO: fix SID_COPY_HYPERLINK (which doesn't SelectFieldAtCursor)
        
        The problem showed up when the menu option was added
        because the mouse was over an unselected field,
        but when the mouse moved to select the menu option,
        the slot was not considered valid anymore
        if the cursor had moved behind the field.
        
        (The right-click to open the context menu puts the cursor
        before or after the field.)
        
        Now, by checking for a field-before-the-cursor during validation,
        the field is found and the command is not prevented from running.
        
        Once this is all in place, some older commits from Caolan
        should be able to be reverted.
        
        (Strangely, SID_OPEN_HYPERLINK and SID_REMOVE_HYPERLINK
        seem to run before the slot is invalidated.
        No idea why they are different.
        For GEN, the popup usually either kept the pre-menu mouse position,
        or else it always runs the command before the slot invalidates.)
        
        Change-Id: If992b3fdc94d89162b60447458cabced2d5e3f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158856
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-11-15  Justin Luth  <jluth@mail.com>  [213c6a9999e84f084978391c16276017078bf9ed]

        related tdf#158031 editeng: GetFieldAtSel...(+look before cursor)
        
        Nearly a No-Functional-Change, but not quite.
        For practical and intentional purposes, it can be considered NFC.
        
        Although I didn't find an actual case where it happened,
        a code read says SelectFieldAtCursor COULD select a non-field.
        It assumed that previous code had already identified that there
        must be a field here.
        
        Well, I want to extend GetFieldAtSelection to check backwards
        to solve bug 158031 anyway, so I might as well "fix"
        this assumption to only select a valid field.
        
        This function REALLY depends on
        GetFieldAtSelection working properly.
        So, I put some asserts in to ensure that stays true.
        
        Change-Id: Ie22945a418497511501b04df5e17071d977cbd5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158855
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [861ebce9ca52cbe87121879f159d8ec0cb572755]

        tdf#157518: add password strength bar to protectsheetdlg.ui
        
        Change-Id: Iedd6793446c2c339cc17d32a28c6b195dfb250e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159372
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [e8fc5d7fcab6b283ec0655b1d7cab5bf28fde240]

        tdf#157518: add password strength bar to sfx2/ui/password.ui
        
        Change-Id: I181b71c6072a61651b33835f76e8deebb5f8d58a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159371
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-15  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [cdcff8c34144e883eca9dc6e1a85968ed34909c2]

        tdf#157518: add password strength meter to setmasterpassworddlg
        
        Moves PasswordStrength bits that provide utility functions from cui to svl,
        merging them with PasswordHelper there.
        
        Adds password strength bar for the set master password dialog.
        (accessible via Tools -> Options -> LibreOffice -> Security -> Passwords for Web
        Connections)
        
        Change-Id: I8dc1090a041f8388c2e139beb1d0d9a0beb8acb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159370
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-15  Stephan Bergmann  <sbergman@redhat.com>  [51d9c9899f54200a2bf9bf49df16c03cca403498]

        Extend a loplugin:ostr check from OUString to OString
        
        Change-Id: I0776ab0ab376d6181461d2c144a4107b06233829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159470
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [f9b9e702465b4de29153b49e077c70a0ad78c89d]

        android: Add button to open privacy URL
        
        In the About dialog, add a "Privacy Policy"
        button when a privacy URL is set, i.e.
        the `--with-privacy-policy-url=<URL>` autogen
        option is used.
        Clicking the button will fire an Intent
        to open that URL.
        
        Use a custom build config field as described at [1]
        to make the privacy policy URL available to
        the Java code.
        
        [1] https://developer.android.com/build/gradle-tips#share-custom-fields-and-resource-values-with-your-app-code
        
        Change-Id: I6e1a9aff885e4ce132284f49e722b3343fc51b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159445
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [1d7b1e2d4099aac15e695696e6a0640d6e01e23f]

        android: Drop "More Info" item in "About" dialog
        
        Drop the "More Info" button from the dialog, which
        opened a sample document with more information
        about LibreOffice.
        
        There's already a link to the website, and the
        "neutral" button in that dialog will be reintroduced
        to show the privacy policy instead, if set.
        (An `AlertDialog` has at most 3 buttons.)
        
        Change-Id: Ib760daba1ed6f8cfc26eefc7412553bf97c77d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159444
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-15  Stephan Bergmann  <sbergman@redhat.com>  [2a242032f9496308eed36d7dd2abb4eed762fa9f]

        Add back test for struct initialization
        
        ...that had been removed as part of f99bee8103ad82dac2e53e114527399c4af5485c
        "Delete OUString UTF-16 string literal ctor/assignment op"
        
        Change-Id: I22423306ab35dcb580ecc90daea3219b6c1578b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159446
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b9394c6d00bd2d041457c03c93066ed8eb5cb15]

        cid#1550112 Uninitialized scalar field
        
        since:
        
        commit 8bf614179f5664d7cdd49db41ef462073cc8608d
        Date:   Thu Nov 9 16:00:10 2023 +0100
        
            tdf#135266 - Remember last used entry level depending on the index type
        
        Change-Id: I298e7afa59874c0718b42de622b817d201d986e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159436
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0e848dab096160b16c4778ba25a40d1e5ff82af]

        avoid double map lookup
        
        Change-Id: I02018eaaf220c7835756eba6215425bac9cbc6f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-15  Noel Grandin  <noelgrandin@collabora.co.uk>  [def8f7699661f3ca9d763b6bd5e81759cf5b4e12]

        tdf#158094 Can't remove trusted certificate in Macro Security
        
        regression from
           commit 6ed8c5a0f19901ab413c6610649326b2475c3a8c
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Jul 25 21:35:05 2021 +0200
            use officecfg for security options
        
        where I accidentally dropped the chunk of code that removes
        existing entries.
        
        Change-Id: I0b183d3c4dc55d5671b4f172e02afd2e4422a37e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-15  Regina Henschel  <rb.henschel@t-online.de>  [0430adb42bc38f037b907984e71c144d863796cb]

        Import Wordprocessing Canvas, wpc:wpc element
        
        Currently LibreOffice uses the VML fallback, when a docx document has a
        wpc:wpc element. This patch implements to use the choice part with the
        wpc:wpc element. That is often called 'drawing canvas'.
        
        The patch uses a similar approach as for SmartArt. The drawing canvas is
        imported as group shape and for the background an additional rectangular
        shape is inserted as first in the children vector.
        
        Not using VML has the advantage, that the custom shape import is used
        for preset shapes. VML import produces problems because some properties
        are not available in VML or the current VML import has deficits. The
        test suite shows examples, what is better without using the VML
        fallback. Affected bug reports are e.g. tdf#104671 or tdf#154828.
        
        A drawing canvas must be used in Word for connector shapes. A connector
        in Word on the drawing canvas is not written as cxnSp element, but as
        ordinary wsp element with additional wps:cNvCnPr child element. The patch
        generates a connector in such case.
        
        Unsolved problems:
        
        The path of a curved connector in OOXML is basically incompatible to
        the path which LibreOffice generates. This patch uses the default
        path for a curved connector. Same is done in import in Impress. Using
        the VML fallback had generated a custom shape with the current path
        and handles, but the connections to the target shapes were lost.
        
        Export to docx is missing. The drawing canvas is not recreated,
        instead a group with the additional background shape is exported. That
        is no regression, using VML has produced a group too on export.
        
        I don't know whether XML_graphicFrame can occur in
        WordprocessingCanvasContext. At least charts and math equations are
        not possible on the drawing canvas in Word.
        
        Import of WordArt shapes does not work. That is not regression. It
        works neither in the VML import.
        
        Change-Id: I04bf8407efd1939cdf3137775f8afad420b74014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156629
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c0df28f957b43f0ecbffdc994ee0702dbe5bc33f]

        merge duplicate formula bar updates in close time proximity
        
        We get three updates per keystroke, StartExtTextInput, ExtTextInput and
        PostExtTextInput.  Skip duplicate updates. Be conservative and don't
        skip duplicates that are 5+ seconds apart.
        
        Change-Id: I501bff4193528fa9263d296700d64e2f60b52222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-15  Miklos Vajna  <vmiklos@collabora.com>  [47d824dd167eb34b08e5aec7141d2d9e6e996b34]

        tdf#157911 sw floattable: fix inconsistent inferred bottom border on split
        
        The bugdoc has a split table between page 1 and page 2. The last row of
        page 1 has a half bottom border: it starts on the left of the table,
        but finishes earlier than the right of the table. This is since commit
        08aea5526c75ff4c5385e960bd940f10ffa19cd5 (tdf#156351 sw floattable: fix
        missing bottom border in master table, 2023-08-21).
        
        The trouble is that Writer table borders are really at a cell-level (and
        not at row or table level), the current partial border happens because
        the first row has merged cells and the last row on page 1 doesn't have
        merged cells, so the layout can't do a 1:1 mapping between the first row
        and last row cells. It's also far from clear if the fixed result should
        be no bottom border or a table-width bottom border:
        
        - Word documents can have cell-level borders (where no inferred border
          is wanted) and table-level borders (where inferred borders are
          wanted), see the tdf#156351 bugdoc for a case where such inferring is
          wanted
        
        - In case only cell-level borders are defined, then Word doesn't do such
          inferring
        
        Fix the problem by always inferring such borders, because:
        
        - Writer already did this in some cases for a long time, see commit
          a4da71fb824f2d4ecc7c01f4deb2865ba52f5f4c (INTEGRATION: CWS fmebugs04
          (1.115.46); FILE MERGED 2008/05/13 13:56:19 fme 1.115.46.2: #i9860# Top
          border for tables - correction 2008/05/13 13:49:23 fme 1.115.46.1:
          #i9860# Top border for tables, 2008-06-06)
        
        - The Word UI creates table borders by default, so the majority of the
          DOCX documents also want this inferring
        
        An alternative could be to only do such inferring for Word documents
        with a compat flag, but that looks poor, given that Word doesn't always
        do such inferring itself, either.
        
        Change-Id: I052e4591e99d066c3109e8ab8b590e97c8aebd36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159429
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [df9e08cd765731451bf58b2d23590db7263d49fe]

        tdf#158030 gtk4 a11y Map {col,row}indextext obj attributes
        
        Map the "colindextext" and "rowindextext" object attributes
        introduced for Calc cells in
        
            Change-Id Ib675abafa2028d986b31d64ea7f5a38b1d54fc11
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Nov 14 10:18:37 2023 +0100
        
                tdf158030 sc a11y: Report cell coords via {row,col}indextext obj attr
        
        to the corresponding gtk a11y relations.
        
        Together with a suggested MR for gtk [1] to add the
        corresponding mapping to AT-SPI2 there, following
        the Core Accessibility API Mappings specification [2],
        this makes these available on the AT-SPI2 layer.
        
        Interacting with Calc cells e.g. in Accerciser currently
        doesn't really work though, because LibreOffice freezes
        due to the Gtk implemenation of "GetChildCount" currently
        trying to iterate over all children, s. Gtk issue [3].
        (Tested by hard-coding dummy values for a Writer paragraph
        in `SwAccessibleParagraph::getExtendedAttributes` instead.)
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6563
        [2] https://www.w3.org/TR/core-aam-1.2/
        [3] https://gitlab.gnome.org/GNOME/gtk/-/issues/6204
        
        Change-Id: Ie53cb3cba51f5020c5a90d33dc27f2b6cd581b92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159412
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [c2165ec33c5549dcc494ad9197727e096678fc3c]

        tdf#158030 sc a11y: Report cell coords via {row,col}indextext obj attr
        
        Expose the end-user consumable coordinates of a Calc
        cell via "rowindextext" and "colindextext" object
        attributes. These are specified in the ARIA specification
        and the Accessibility Core API Mappings spec suggests to
        map them to attributes of the same name for all of AT-SPI2,
        IAccessible2 and UIA [1] [2], so no extra mapping is needed
        in the platform-specific a11y bridges for now.
        
        Orca git master already contains a commit to
        make use of these attributes [3]:
        
            commit 3c056cd7b58aa2cb1b3342c87d052704ef32fa24
            Author: Joanmarie Diggs <jdiggs@igalia.com>
            Date:   Mon Nov 13 18:19:12 2023 +0100
        
                Look for the rowindextext and colindextext attributes in soffice
        
                We were looking for these attributes only in the web script because
                they are ARIA properties. Ultimately we will do this check globally.
                In the meantime, if LO Calc exposes these attributes, we can remove
                a hack or two. Therefore add support now so that they can prototype.
        
        The attributes are exposed to IAccessible2 and AT-SPI when using
        the gtk3 VCL plugin right away.
        
        For qt6, this works with pending Qt changes suggesting to
        add support for object attributes [4] [5] and the
        corresponding LO change to implement the new interface [6]
        (currently via the `CustomAttributes` attribute, might make
        sense to introduce separate ones, but that's something to
        look into once the pending Qt changes to add a mechanism
        have been reviewed).
        
        [1] https://www.w3.org/TR/core-aam-1.2/#ariaRowIndexText
        [2] https://www.w3.org/TR/core-aam-1.2/#ariaColIndexText
        [3] https://gitlab.gnome.org/GNOME/orca/-/commit/3c056cd7b58aa2cb1b3342c87d052704ef32fa24
        [4] https://codereview.qt-project.org/c/qt/qtbase/+/517525
        [5] https://codereview.qt-project.org/c/qt/qtbase/+/517526
        [6] https://gerrit.libreoffice.org/c/core/+/159309
        
        Change-Id: Ib675abafa2028d986b31d64ea7f5a38b1d54fc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159411
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-15  Miklos Vajna  <vmiklos@collabora.com>  [015e7d51b671a9dbf110599855d99a57fda2ae59]

        writerfilter: avoid double map lookup in RTFDocumentImpl
        
        It's not much more code and is faster.
        
        Change-Id: I7ed6b80890dce5cb18555e6c66f7b02c49abcde2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159425
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [48e4a871d926b534eb6131d16d04d68b151b2847]

        loplugin:unusedmethods
        
        Change-Id: I1e125bbd388953491b3f869641484fea737d39ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-15  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [92e5898fa9ffa4dd8742f5f26e790563feef286e]

        Fix wrong context strings
        
        Change-Id: I24476a2a0e7580b784524487679ddee1811b4c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159415
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-11-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c09de4e11cfd58e676d6fb99453e97f70da5b266]

        Fix typo
        
        Change-Id: Idcfcd6aca1c74cb3e10dac09cd347b69a9bdb949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159406
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-14  Miklos Vajna  <vmiklos@collabora.com>  [bda066a77f4167bf83c0167afb6998c2890e60e0]

        sw floattable: link ODF proposal
        
        Change-Id: Ie0b94b8830f9d2f196effc4a9f7d9fa5839f0d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159421
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bfee998e71e2b7e8bcf4a366a00219a9b0f59035]

        tdf#158134 - UI: Part 29 - Unify lockdown behavior of Options dialog
        
        for Writer - Comparison Page.
        
        Change-Id: I33cfb499bf9026db1e2b8a359ad619c760e09abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159420
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1264cff53a3d4510f0e82706aeeaf1c63b4f04a6]

        resave with newer glade version
        
        Change-Id: If2a527679d171ff8f11b3fdeaf595c6bdd1b5f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159419
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [23228e6fc60a10c41595302c9bf4ed9d753660da]

        tdf#158133 - UI: Part 28 - Unify lockdown behavior of Options dialog
        
        for Writer - Changes Page.
        
        Change-Id: I1cb26c6387c9483b6c99fa800a7d7c0529456cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159414
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [164596c00b4361b5b378609f026a1b11ac653970]

        resave with newer glade version
        
        Change-Id: I2679c9f59b351d9e3db9121d42d9e8c2948ac641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159413
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c265b9b4bb419dcb7e4c2d8a2529b469373cce91]

        tdf#158131 - UI: Part 27 - Unify lockdown behavior of Options dialog
        
        for Writer - Table Page.
        
        Change-Id: Ic2fbec7dd5520a48bb1b6bf85a2277268cf36611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159405
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Stephan Bergmann  <sbergman@redhat.com>  [f9ac0d2bbbb5d6587e2b38d763e49e65e0529f3d]

        Dispose some test components
        
        Otherwise, JunitTest_forms_unoapi_2 left behind two instances of
        frm::OGridControlModel.
        
        Change-Id: Idaf7bae26b18e20821968ebf52e7864043963e03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159422
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [5e8bc7bda667e994cfbdf9bf4d981175dff71bae]

        loplugin:unusedfields
        
        Change-Id: I5869e9974c37b1b525d316367f1dc5051d8aa197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0481649c526e2ad934482487c2dc7fae49c8031]

        cid#1550044 make it more clear that null is returned here
        
        Change-Id: Ie61d6e5f77d3473e4e867bda7be9805ca1e355ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159410
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [13898cc9fefe7227c2119d3996f13d67877b8a6d]

        cid#708565 Uninitialized scalar field
        
        left overs since:
        
        commit 9bb9ba6ae02692e65498bae4598e3b63bb65c02e
        Date:   Mon Oct 2 12:33:34 2023 +0200
        
            [API CHANGE] Remove deprecated IsSpellCapitalization
        
        Change-Id: I36728eca51fc264e54de42ec2ee6fce06813e9c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159409
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-14  Heiko Tietze  <tietze.heiko@gmail.com>  [adfb0a34af196befc46527418f6e870d1f8f1889]

        Resolves tdf#158084 - Start Center hover color
        
        Selected colors removed since hovering leads to selection
        (or execution) and does not need a special color
        
        Transparency for reccent documents and templates in start center
        increased to make the difference to selected more clear
        
        Change-Id: Iab52150cd5a93e2f6ff716921b2aa7d093018b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159407
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [550e8b278082c39d61ec5a4efbf0fbca145614ab]

        cid#1550047 Uninitialized scalar field
        
        left overs since:
        
        commit 7ca9c5bd2e2e3cda5686b7b8f5b657161eb52cdd
        Date:   Thu Nov 2 15:49:49 2023 +0100
        
            Move "Enable Impress Remote" setting to presentation settings
        
        commit e0334e1a77ec080b38952ea64b394c8652af851c
        Date:   Thu Nov 2 13:43:38 2023 +0100
        
            tdf#157788 Move "Show navigation panel" back to Presentation settings
        
        Change-Id: I8e33930a8c44b9de6ccf7424a169628008556acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159408
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5767cb0eaf9ac69ccc0bfb8944cbf931a1f80728]

        Fix typo
        
        Change-Id: Id3be5eb786bfa245155fef17e819a72dee322e18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159397
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [80e908b0ce68c13385c1eb5c0285665fa89d5e3d]

        tdf#155138 Change context strings
        
        "stock" -> "openlockedquerybox|[id]"
        
        Change-Id: I2325bf9257ba168d52dc37579f10a9b7685b0751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159343
        Tested-by: Jenkins
        Reviewed-by: sabri unal <libreajans@gmail.com>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [738e342f3e68020bb84b45db1e68b3efd0057a12]

        Resolves: tdf#158121 Math - Print settings not read after changing
        
        Change-Id: I4effa4905f05a8a6105d4283c0a3b5ba8dd4d31d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159402
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-14  Stephan Bergmann  <sbergman@redhat.com>  [b6583a9283e1b57c43dd5a4d8eff54d16c112020]

        Adapt compilerplugins/clang/test/fieldcast.cxx to clang-cl
        
        ...where loplugin:locking2 is disabled
        
        Change-Id: Id58cbedab191c59b901ef1a0e0dd82b8f8438c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159400
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-14  Miklos Vajna  <vmiklos@collabora.com>  [c1a535ee2db757b2e40683dc918cbad8b7429cfa]

        sw floattable, insert UI: fix unexpected border and spacing
        
        Select an inline table (make sure the whole table is selected), insert a
        frame, then the frame width is already calculated from the table width,
        but an unexpected second frame border / spacing is also added. Given
        that the table already has its own border, adding a second border by
        default makes no sense.
        
        It's possible to disable default borders in SetFrameSizeFromTable(), but
        in case the borders are unchanged, the dialog's output item set will
        still contain no border info, so we will still get the default borders.
        
        Fix the problem by making this explicit: if the dialog's input item set
        had border info and the output item set had none, then still copy over
        the border info from the input to the output in
        SwTextShell::ExecInsert().
        
        This automatically fixes the unwanted border spacing as well, so the
        default frame properties are on par with the ones created by Word import
        filters.
        
        Change-Id: I4c9f165dad7a8bb70cfcfadaea4466a8d174b46e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159399
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d93d11529e7922fe391edcc839af8a3b4044b809]

        tdf#158130 - UI: Part 26 - Unify lockdown behavior of Options dialog
        
        for Writer - Print Page.
        
        Change-Id: Id6bc4da75cba3daf83a9709233eaafea372bb600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159392
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [4cf54aa70a73b000c6dbf604a2d69f287644756e]

        tdf#158010 - UI: Part 25 - Unify lockdown behavior of Options dialog
        
        for Writer - Basic Fonts Page.
        
        Change-Id: I73276c0bf3dc190098781e427cf32c753aae23ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159377
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-14  Miklos Vajna  <vmiklos@collabora.com>  [eb4ac533ae358bb596ed60d5a65682799bf375a0]

        sw: document SwFormatCharFormat
        
        What it does, it refers to what, who is the owner.
        
        Change-Id: Ieb8a41ba6c47e5f24d43465f323b660cbf4afdeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159394
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [d5a21cca3851488d904ef7d4d86ae8fa8cd3ec12]

        tdf#123864 gtk4 a11y: Handle CHECKABLE/CHECKED state independent of role
        
        The GtkAccessibleState doc [1] says for `GTK_ACCESSIBLE_STATE_CHECKED`:
        
        > A “checked” state; indicates the current state of a GtkCheckButton.
        > Value type: GtkAccessibleTristate
        
        The CHECKED state is actually used for more than just for checkboxes,
        (e.g. for toggle buttons in the toolbar), so don't restrict its
        use to the CHECK_BOX role in LibreOffice.
        
        Explicitly setting `GTK_ACCESSIBLE_STATE_CHECKED` makes
        Gtk report `ATSPI_STATE_CHECKABLE` on the AT-SPI layer [2],
        so this should only be set for objects that actually
        have `AccessibleStateType::CHECKABLE` set on LO side.
        
        This also implies that the gtk4 a11y bridge now depends
        on the recently introduced CHECKABLE state being set properly.
        (Reporting of that state in the different a11y classes will
        be added in follow-up commits.)
        
        For more background, see the commit adding the new role:
        
            Change-Id I6aa7fec3b3bd728a5cfedcdc8d6b66f06337f7ce
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Nov 13 15:53:44 2023 +0100
        
                tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
        
        [1] https://docs.gtk.org/gtk4/enum.AccessibleState.html
        [2] https://gitlab.gnome.org/GNOME/gtk/-/blob/a9e4993184605bc70e930b5c1e69d8f49c689c76/gtk/a11y/gtkatspicontext.c#L204-220
        
        Change-Id: I898898f6117fb2ff62310c65e4baa140486deb16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159390
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [42f839a5371ffc25e7181606b53d339ba0c8c9ee]

        gtk4 a11y: Set accessible name and description
        
        Set the accessible name and accessible description
        via the corresponding properties in the gtk4 a11y API,
        `GTK_ACCESSIBLE_PROPERTY_LABEL` (accessible name) and
        `GTK_ACCESSIBLE_PROPERTY_DESCRIPTION` (accessible description).
        
        Drop the initial proof of concept that was setting the
        text returned by the Text interface as accessible name instead.
        
        This also makes it much easier to find a specific item in
        the LO a11y tree in Accerciser.
        
        Change-Id: I9dac4c33185b589a63dda03fa7dd342a6ed460ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159385
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [4ae31181cdd857b896c9fb6ab1fa57a41d76025f]

        wina11y: Drop "using namespace css:accessibility::AccessibleRole"
        
        And while at it, also replace the local variable that holds
        the role with 2 `sal_Int16` ones adhering to our naming scheme
        instead of calling it "Role".
        
        Change-Id: Ia49cfd23f919098eaea929601c4c432be3fcfe63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159383
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [d6c6472bbe1c90b733a4d69c4c8528f4de3750d3]

        tdf#123864 a11y: Add new AccessibleStateType::CHECKABLE
        
        Both, AT-SPI and IAccessible2 have a CHECKABLE state
        that describes whether an item is checkable, i.e.
        whether it can be checked, i.e. whether it is possible
        that this object can have the CHECKED state.
        
        So far, LibreOffice didn't have any equivalent, and
        e.g. a checkbox that is ticked would report state
        CHECKED but not CHECKABLE, which is inconsistent.
        ("How can an object that is not checkable be checked?")
        
        For an unchecked object, the fact that it can be checked
        is unclear since that one will just have the CHECKED state
        not being present.
        
        Introduce a new a11y state, `AccessibleStateType::CHECKABLE`
        with the same semantics as in AT-SPI and IAccessible2 to
        bridge the gap.
        
        Map the state in winaccessibility (to IAccessible2),
        gtk3 and an the Qt-based VCL plugins, which are
        responsible for mapping to AT-SPI.
        
        While Qt has an equivalent state flag, it currently
        doesn't map that to AT-SPI yet.
        Pending upstream Gerrit change to implement that: [1]
        
        The gtk4 a11y API doesn't have a direct equivalent and will
        be handled separately in a following commit.
        
        Reporting the new state where applicable will be
        implemented in following commits.
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/517844
        
        Change-Id: I6aa7fec3b3bd728a5cfedcdc8d6b66f06337f7ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159382
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [74c1e23c80eef5e246acfbfdf2287b49303ecc6f]

        wina11y: Make UNO to IA2 state mapping more explicit
        
        Rather than having one array with UNO states and one with IAccessible2
        states, map the states explicitly using a new helper function.
        
        The third array that the
        
            // maintenance the consistency, change one array, change the three all
        
        comment was referring to is potentially one of the two
        removed in
        
            commit 3d4da2347ee6ef787902e0af57e7f9635e3bd6c0
            Date:   Fri Nov 27 16:48:38 2015 +0100
        
                Remove unused data
        
        Change-Id: I5553b28c58fedab24f2adc789ad91c9889a4ef61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159381
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [552eb49c60562b67d2e8bc4b3813464b5d13be87]

        wina11y: Drop extra local var for role
        
        Just use the `m_accRole` member directly.
        
        Change-Id: I6a4eae9bc00422683e600fa1be300264d45fec46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159380
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-14  Michael Weghorn  <m.weghorn@posteo.de>  [9356c479a62e83f1e89be0dd455c60601c35ef86]

        wina11y: Drop unnecessary local var 'Role'
        
        Just use `m_accRole` directly, as already
        happens elsewhere in this method.
        
        Change-Id: Ibd3358e9f85621ba7d9c99d5ed0812b6c692d473
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159379
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [c60a9db1f2a8e2a088c6b89bcdff4901b28f2864]

        tdf#158185: fix Excel's Range.Find and Range.Replace wildcard recognition
        
        VBAToRegexp is wrong, using Basic wildcards. The functionality introduced
        in tdf#72196 matches the required wildcard repertoire.
        
        This introduces a new WildcardEscapeCharacter property to SearchDescriptor
        service. Interestingly, the default value there was backslash.
        
        TODO: also fix Range.AutoFilter, and drop VBAToRegexp. To do that, a new
        property is needed in service SheetFilterDescriptor, to use wildcards,
        in addition to "UseRegularExpressions" property.
        
        Change-Id: Idebcf00d4b7376e5d7feaf8ae800fb19d05689d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159391
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [9520c38b0b1197a49499afb3276f999a530cf778]

        Fix a typo
        
        Change-Id: I95404a278b53d7021adacd99ee7482592c0eb8e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159245
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-13  Eike Rathke  <erack@redhat.com>  [d646341e5ddc625d9cf69777b4be174aebb43700]

        Related: tdf#125580 Use tools::Duration constexpr accuracy epsilon values
        
        Change-Id: I8f83c23206686ce23fb3f8be7d7098bbe252dc41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159388
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-11-13  Eike Rathke  <erack@redhat.com>  [007e9e46d936ad7631792188168dffec7051b27f]

        Resolves: tdf#125580 Limit operator +|- date+time resolution to microseconds
        
        With tools::Duration that is now finally easily possible.
        
        Change-Id: Ib22e6f94d321be78578997bef5094284f2bd549b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159378
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Eike Rathke <erack@redhat.com>

2023-11-13  Eike Rathke  <erack@redhat.com>  [61d5f971496cb0091f9b37aaafcb87694f3810ea]

        Resolves: tdf#127498 Force corrected TIMEVALUE() result
        
        Change-Id: I750a3251c3cf5e8cad4a37c7c4b646c0457f2dbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159389
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-11-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8bf614179f5664d7cdd49db41ef462073cc8608d]

        tdf#135266 - Remember last used entry level depending on the index type
        
        Change-Id: I4fe9342c28fc9135b73286e67464b16a1d910a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159217
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-11-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2585cd1f52585c9a2abfc34ea56171375ebdab6a]

        resave with newer glade version
        
        Change-Id: I63c03d2c23394f0ba3441be9cb858a11011ee7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159376
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3cee7edeb31ac64e078159c7a63ebf4f54793da7]

        [API CHANGE] Remove deprecated Storage config item
        
        Change-Id: I737882a9b6738c39fe71dd4a46ff5dab23231d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157486
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bb8ed67114b2312acd6a101b39fa029a6589d1b9]

        fix build with older curl
        
        Change-Id: I167a92c116fba8c92347d09e3078b70f4f4aef4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159360
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-11-13  Stephan Bergmann  <sbergman@redhat.com>  [c8dfb25a77f53668e407a60a6f4ae9a826aa015c]

        Drop DEBUGSPRMREADER code
        
        Change-Id: Id204eae97850ef9c99229c1316090010013b06e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159367
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-13  Julien Nabet  <serval2412@yahoo.fr>  [288001be6802cc41c445067a2d690371606202c3]

        Fix warning for emscripten build
        
        TB lo_daily_tb_linux_wasm shows:
        /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/chart2/source/controller/main/ChartController.cxx:1557:71: warning: unused parameter 'rAccChartView' [-Wunused-parameter]
        void ChartController::impl_initializeAccessible( AccessibleChartView& rAccChartView )
                                                                              ^
        1 warning generated.
        
        Change-Id: If584e6944c1d9105a7a8b7170dc1022911b57bf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159373
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-11-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0d30e2a8cd312dfcf5fc2ac0c67e09a1c74d2f46]

        Related: tdf#157837 - UI: Part 3 - Unify lockdown behavior of Options
        
        dialog for View Page.
        
        Change-Id: I78239ce7ad7b133eaaa3d42a0f424ed0250cb47e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159359
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [07dfeffae8cba808dbad85dfed9b6a693a1f9543]

        tdf#127547 Freeze in Microsoft Print to PDF dialog
        
        Change-Id: I7a6ef85fae637c8359a96df1bd31d7e8f0b36512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159369
        Tested-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9bb9ba6ae02692e65498bae4598e3b63bb65c02e]

        [API CHANGE] Remove deprecated IsSpellCapitalization
        
        Deprecated since d567671196fcc
        
        Change-Id: I89203ee2e05591ad85ac893b3e488d1431d6775f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157484
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-13  Oliver Specht  <oliver.specht@cib.de>  [5ed0646dffab1563337ef4c1ae34a4ebfa69bdbe]

        tdf#157363 remove pre text when pasting simple HTML
        
        appends to https://gerrit.libreoffice.org/c/core/+/158659
        handling of pre text didn't make it into sd code
        
        Change-Id: Ie396b487f451e163b9e59b585c988f9b1b5b669e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159361
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3368447e826d4204086e4d8bfe59af4412c16233]

        upgrade libcmis
        
        Change-Id: Ie2d5f3f8208f9952db5be10905b5905cd03b91de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159366
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef2ca2a87d3071be18a82c96d87a3f8dc17cb872]

        fix makefile
        
        Change-Id: Iddec94c5c3212e81437a466bd265b6a77851320e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-13  Yli875  <qq3202390739@gmail.com>  [2ee71dff5cdc7ddd59f249e97d3c4154fa28d8fd]

        tdf#130924 replace debugging printf with SAL_INFO
        
        DEBUGSPRMREADER was added in 616adc49d6fde24e809bd438d8e31de74bcf73ef,
        5f653490a40850886f94c9fd6b381b4bed1de58a and also in
        c80a0fcdd9a4389616e92cfeafa9d932a784ee71
        
        Change-Id: I80ae8a75ac0f40bb633f4c0aee9bdcee0c26adfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159090
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9fc42afd17e9115b488401f64804479e7a76a300]

        ofz#64106 Null-dereference READ
        
        Change-Id: Ie279f9f54fa6cc7fcc6add9b737d2c5dc248a236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [333070dd1ca45e1966f312ba78dbc5985ab814d7]

        don't need this in the end
        
        Change-Id: Iebb5131209c289bd797682c8f79d925449b551e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [93b4928dddf9cdd55450450995fefe324d771221]

        Re-introduce build config to version info reported by LOK
        
        ... as an opt-in --with-buildconfig-recorded configure option.
        This allows to have the data in the admin console, as implemented in
        commit cbfac11330882c7d0a817b6c37a08b2ace2b66f4 (Send build config
        (configure options) in LOKit version info JSON, 2022-11-07), when
        reprobuilds are not required. The default is no build config, which
        is compatible with reprobuilds.
        
        This reverts commit 389def871853c885289627452f40b3ae0a8dabc8.
        
        Change-Id: I7f0be489a1c82268d0ca38cb761843c9d432a14b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159344
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-13  Heiko Tietze  <tietze.heiko@gmail.com>  [285a3e8d8b77b44da3dcc767877f878fe0e0493e]

        Resolves tdf#158084 - Use system colors in start center
        
        StartCenterThumbnailsHighlightColor and StartCenterThumbnailsHighlightTextColor
        removed in favor of StyleSettings.GetHighlightColor and .GetActiveColor
        
        Change-Id: I7005b17f6c48525c791f23ea99b7b68e7a67531b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159286
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-11-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b047c9b21b75f58429c5f55d2838f154c0ea6293]

        Fix old TODO: Remove the parameter bCheckImmediately from SvxNameDialog
        
        Change-Id: I47a6e82bab3306e8fddb8002740339dbb1965a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159213
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ee4eb828fbf7ead62fca85239d78c48003bbc41e]

        Use SvxNameDialog for editing config values
        
        Instead of having a separate dialog which does the same.
        
        Change-Id: I3b20920fa1c68593b6787a01592621c7b02fa715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159209
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-13  Miklos Vajna  <vmiklos@collabora.com>  [6c761fa3b40d296444681d8d2f991e5a6b7e5b71]

        sw floattable, insert UI: fix missing undo/redo
        
        There were 3 problems here:
        
        1) SwDoc::MakeFlyAndMove() declared that inserting fly frames is broken
           anyway, so just deleted the whole undo stack. Remove the
           DelAllUndoObj() call, so the underlying problem is visible.
        
        2) MoveNodeRange() had a flag to create undo objects, but this flag
           wasn't used.
        
        3) The empty text node after the table in the just created fly was
           removed using a call to SwNodes::Delete(), which is not undo-aware,
           so the table was inserted after the anchor (and not before the anchor)
           on undo. Fix this by going via sw::DocumentContentOperationsManager that
           knows how to delete while working with the undo.
        
        Do this unconditionally, because the 2 callers of this function is just
        SwFEShell::NewFlyFrame() (UI) and SwXFrame::attachToRange() (UNO API,
        mostly the DOCX import), probably both want proper undo support.
        
        Change-Id: I50011bf969ff5636c76a8a0b280193ac6d2b90dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159354
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a598de5b6ed6f161844e01f7be7164a65927caee]

        tdf#158009 - UI: Part 24 - Unify lockdown behavior of Options dialog
        
        for Writer - Format Aids Page.
        
        Change-Id: Ia51094f86c47d154ec6e8b4d961a9db6a5005a03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159305
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6c031c31de72a0eda0a24af52aa041049ef16584]

        resave with newer glade version
        
        Change-Id: Iba7a427b98552cb297f0b764473e3750063369b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159304
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d6f174291003f058f7cd0bec6b838e1c94267b32]

        tdf#158008 - UI: Part 23 - Unify lockdown behavior of Options dialog
        
        for Writer - Grid Page.
        
        Change-Id: Ia492d0d742050d1ceec3c9ab68bf3378355977e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159290
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-13  Miklos Vajna  <vmiklos@collabora.com>  [9f09ce383eef0750240a61d90341d56bffbce824]

        svx: prefix members of SdrPage
        
        See tdf#94879 for motivation.
        
        Change-Id: I9b3b1116bca80a5c587931e4c8da9ac31e1faa5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159353
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [150cd96bc9c68416a5654a9fcef12e3e9b68ba10]

        Fix typos
        
        Change-Id: I5f6ddc80fb13f7c0b1841cab034539e500353511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159346
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-13  Stephan Bergmann  <sbergman@redhat.com>  [42de667705ed90eb6bb3b9e3308d666e507eddd8]

        -Werror,-Wunused-private-field
        
        Change-Id: I6bc93f212c687c908e68b2fbbced03f19f40844e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159351
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [e3581bb072b6b9723c374a782e030edb6abf5edd]

        --disable-curl builds: split WebDAV-related JunitTests to fix checks
        
        Change-Id: I0a46dc226e141eb585817fff4871f8d1681a3f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-12  Julien Nabet  <serval2412@yahoo.fr>  [79f92d09ec52f0777fc03ff1d057a11b45e73f6d]

        tdf#158171: fix crash when double-clicking DeepL translation dialog OK button
        
        Change-Id: I4954357c59c7134d882fb19e9949ecbd5d60345a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159322
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Jean-Pierre Ledure  <jp@ledure.be>  [5dac0fe157a5c35824cab2c27e391ff7a0d1d421]

        ScriptForge (SFDatabases) fix dates processing in GetRows
        
        The
           database.GetRows()
           dataset.GetRows()
        methods return an array of data collected
        in a database table or query.
        
        When a column has the type DATE, the transmission
        of their values through the Basic-Python bridge
        require them to be converted upfront to UNO
        DateTime structures.
        
        The later conversion from UNO DateTime to the python
        datetime.datetime structure has been added with
        this patch.
        
        No impact on Basic scripts.
        
        The documentation does not need to be changed.
        
        Change-Id: I7a6533aff70d2d1402bfc3f057b65a4940148cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159348
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-11-12  Alain Romedenne  <alain.romedenne@libreoffice.org>  [544d8947965b682e24fe109654eee181e6c3b0fd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5cb2f51e2711b1ec587694021376f3169246631b
          - Typo
            
            Change-Id: I4c44f68af3e8c15b715fd103a42f1f77fdcd1dcd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158815
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [09cebda51b9ea3b72c10e4470ac8840db70154b7]

        Fix some leading space inconsistencies
        
        Change-Id: I548ec63d96a4d5e39fd29511c079b667915abb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159345
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [77bc971910771232c8e6e28f4590181ced954997]

        Gtk-WARNING gtktreestore.c:1047: Invalid column number 6 added to iter
        
        since:
        
        commit 985b404f208559b4a91f31eb31dafa9d0384fdaf
        Date:   Wed Nov 8 21:34:41 2023 +0100
        
            tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog
        
            for Language - Writing Aids Page.
        
        Change-Id: Iff9ab545a5d212d004b55f5ceab11d4c9f6dee5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159341
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d200d88d972ce05951696c6920efd90fc357d31]

        resave with latest glade
        
        Change-Id: If01a98195581399e92b31cfe7caa4782a0b246a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159340
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bc4b78233e33e290e05f2da620d9032cd70ced24]

        resave with latest glade
        
        Change-Id: I18c9a7c7fc5e86ef7faebc7273ca3b33d54a340c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dcf9d589f195ead367a4bd2726ab68efa893aec2]

        Gtk-WARNING Could not read property GtkBox:pack_type...
        
        with value begin of type GtkPackType: Could not parse enum: 'begin'
        
        Change-Id: I27d74c4422eb4515c99a2ca834c62ef092ecf641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159338
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Gökay Şatır  <gokaysatir@collabora.com>  [a355522bc282f1c55be36e6949b97ef0ad93175b]

        Get the current view with SfxViewFrame::Current().
        
        It was getting a null ptr for some reason.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Ib3e285dc86cd3918b631b6993e9afb221994bfab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158727
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 6c7fd1dc50cbc3f8e61c741367223a4b4aefc98b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [807c3aafef4d23cef13aafc2280c399db0864971]

        lok: a11y: corelog: removing LOK_INFO in attachRecursive (3)
        
        Change-Id: Ic2967d9fa24674ed61ab7a251bd2a584a74e4cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158959
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit 4e6848628cbff418896b7653eadac80c57ceaf25)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159336
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [56b13bd6f251f66132e2131e4ba825c3e661293d]

        lok: a11y: corelog: re-introducing LOK_INFO in attachRecursive
        
        Change-Id: I5866e9990a4758fad4b1c2a5e26072c31658db89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158955
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit fd08e16e96cfd2d84b9eb4200f35fa6b4b4e3bd5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159335
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [1b0107429da1895c992789a2f610d70dbd05000e]

        lok: a11y: corelog: re-introducing LOK_WARN in viewsh
        
        Change-Id: Ia76e079da1f532b0a4ce9ba24de1b058deef5a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158953
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit 6a9c4306c9c8173ff99184199b18f24f05b35b51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159334
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [39662b4f99224b7b1079b2e8f00f3689a527030e]

        lok: a11y: corelog: enable log in afterCallbackRegistered
        
        Change-Id: I4706fc04ee651e46fb12fe0fa18dbf2762cf95aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158949
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit 0e2df8c3f229e8807c7a6713ca3ea519411537bd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159333
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-12  Marco Cecchetti  <marco.cecchetti@collabora.com>  [edddd58940aef6dcdf06a1a3a3109a50ee9bfa94]

        lok: a11y: corelog: removing log from LOKDocumentFocusListener
        
        Change-Id: I0194cd4548dbb44f9efce4c53c790c3eec938524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158940
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit e6caece707a7d6f3a3e397e6213be9af6054f148)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159332
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-11  Stanislav Horacek  <stanislav.horacek@gmail.com>  [64ccc089c1e6bf82ef10a0dd4768fdff83af55b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 72a81b01ebfa8e040433b6028b2177395d356a09
          - Color Bar menu item is not in toolbars
            
            Change-Id: Iddf366cb873ae1c64f01bce5cc00ad525836dc99
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159342
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [96ed41755b82cd47c27f40d4231e6ed9f915a976]

        lok: a11y: implemented support for notifying core log to client
        
        In this way core log can be printed to the browser console.
        This may help in understanding if some core event occurs earlier or
        later wrt a client event.
        
        Change-Id: I720ef9b149e98ddbc252aa069649019e79ef6cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158780
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        (cherry picked from commit d8dc138be7e69750d1a346b3b49cecc1201e8d46)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e0f5719095e43e5c185d334b3ac3754e3aa4e276]

        [API CHANGE] Drop unused UserDefinedDriverSettings set
        
        last mention of it was removed in 2009 by:
        commit b88a62cc97613e5dc00c806f59982cb57f9d1dc8
        
        Change-Id: I9ab52b53bbbb77444f26e74c0cc76a78ec4c3c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159298
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Henry Castro  <hcastro@collabora.com>  [4abe6c83e76f825319e8b2a0c0b8b8e92177da65]

        sc: extend backcolor area
        
        If the filter background color is selected,
        the automatic selection area should include,
        the attribute of background cell color too.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I341c602247e7f71e3c9665e1b594177d8f5553b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158991
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 768433f07873eb608837630f85e7e1b375239fca)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159238
        Tested-by: Jenkins

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [76de80f512967379f809d3744c71cf5e7e095e87]

        [API CHANGE] Drop unused SpellAndGrammarDialogImage config key
        
        last mention of it was removed in 2011 by:
        commit da0bd7a50139b06e14c1917af044b37d10ebaf4f
        
        Change-Id: Iac4272025b0c995640a1da0f959cb7447d3c9b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158971
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [34a362ee24cfd4642fdc75ecf0e1a88c56c344c4]

        [API CHANGE] Drop unused WriterCompatibilityVersion config group
        
        last mention of it was removed in 2013 by:
        commit f67d166b30dcba9e854716b29e1035693ef7481b
        
        Change-Id: I2207ce7a87805bb33bc3e81fd8da792ba033d844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158976
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c19e39cc0bfe32944bd807d5642a1a9d0537d636]

        [API CHANGE] Drop unused kab.Driver config group
        
        last mention of it was removed in 2015 by:
        commit 72699595aaa3ecb8975050b6dfc6fde437770493
        
        Change-Id: Iffdce3dfbabb20e92a61a0de83dfb4046ebb7ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158977
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b8d04d32c1727189b54b0d7520668d578e9383dc]

        [API CHANGE] Drop unused MozabDriver config group
        
        last mentions of it were removed in 2021 by:
        commit ee9ed2192b56c98e5b8ee9890ddb4c533117332a
        and in 2015 by:
        commit 4e3086da3e9873f53b5b9e1d5e511f9f77aaf62f
        
        Change-Id: Ic8c048f296c2c199fb43836a63a0c084196794cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158975
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [dca1eeb19d837b3355410ef37d681d2df836e144]

        [API CHANGE] Drop unused IncludedExtensions config key
        
        last mention of it was removed in 2018 by:
        commit e98bcfcc3cdad46620e3d59119b0ac262db88054
        
        Change-Id: Ia36b86efcd47132dabc7206fd53a8661e013ac09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158970
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e03dbcc6b7097ebbef2d6cae27ff213be83a3d8a]

        [API CHANGE] Drop unused ThesaurusDialogImage config key
        
        last mention of it was removed in 2011 by:
        commit b243afd8755c2a470c6aa0607f5773bedd026937
        
        Change-Id: Ie48aecd0f2c30d7322dde774c84ce913a835a7a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158972
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fc77f34ebc721e2562666a63def7c5accc0fb61c]

        [API CHANGE] Drop unused PreventTips config key
        
        last mention of it was removed in 2012 by:
        commit 74970948bbd410278964bd02cb5741c6c87eb30d
        
        Change-Id: I1a576f94eca9ecb7fe0d580f50d20b1def79668e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158973
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [96d4bc4bb07d9ffa903f9c37b50e7c98a7491690]

        [API CHANGE] Drop unused SimpleControlPoint LargeControlPoint config keys
        
        last mentions of them were removed in 2011-2012 by:
        commit bbd638350fb83af2cadd85cdac2900de80bf7401
        commit 6ea8ea456cf5df267284278ecda42aa9b089a682
        commit ec4f69493b50c15861b0cdcc290ecedd00efb51d
        
        Change-Id: Iba3820806a761c12dead77ce6207c62f60f7055c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158974
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [23e106034e86b13a00a5039486c3d6bb57f98382]

        find-unused-configkeys: check whether sets...
        
        are used at all, if they have an otherwise unused group as template
        
        TODO: Still gives some false positives if a group is only used
        as template of a set which is only used as template of another
        set which is actually used (MergeToolBarInstruction MergeStatusBarInstruction)
        
        Change-Id: Ia2f83c12a4e0bdcc88b1530bac4daaf456531f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159297
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [1ec76f7a38124b28521fd5959419cf189e65d9f1]

        [API CHANGE] Drop unused ShowAlienFilterWarning config key
        
        last mention of it was removed in 2011 by:
        commit ebb3da4a2b47d719bce673ece53cd8ab09b361d0
        
        Change-Id: I07a5e60f59781b9720543d436efede7b257cc872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159296
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-11  Jean-Pierre Ledure  <jp@ledure.be>  [7b2a6f04443c5d80ce681e5f1c89bf140fdb5c3a]

        ScriptForge (SFDatabases) new Dataset service
        
        A dataset represents a set of tabular data
        stored/produced by a database.
        To use datasets, the database instance must exist
        but the Base document may not be open.
        
        A Dataset instance is create either with
        - the (new) database.CreateDataset() method
        - from an existing dataset with the (new)
          dataset.CreateDataset() method.
        
        The proposed API supports next main purposes:
        - browse for- and backward thru the dataset to get its content
        - update any record with new values
        - create new records or delete some.
        In summary, the AKA "CRUD" operations
        (create, read, update, delete).
        
        The originality of the proposed API is the use
        of a dense syntax to make insertions and updates
        easy and readable:
        Example:
        (BASIC)
          Dim newID As Long
          newID = dataset.Insert("LastName", "Doe", "FirstName", "John")
          '     ... is equivalent to:
          Dim dict As Object, newID As Long
          Set dict = CreateScriptService("ScriptForge.Dictionary")
          dict.Add("LastName", "Doe")
          dict.Add("FirstName", "John")
          newID = dataset.Insert(dict)
        (PYTHON) - next statements are equivalent
          newid = dataset.Insert('LastName', 'Doe', 'FirstName', 'John')
          newid = dataset.Insert({'LastName': 'Doe', 'FirstName': 'John'})
          newid = dataset.Insert(dict(LastName = 'Doe', FirstName = 'John'))
          newid = dataset.Insert(LastName = 'Doe', FirstName = 'John')
        
        You will notice that the returned value is the AutoValue primery
        key (when it exists) which makes it reuse as a foreign key
        immediate.
        
        The API is fully available both in Basic and Python user scripts.
        
        The new service will require its inclusion in the user documentation.
        
        Change-Id: I4f834c4234e5b96ec8fddfffbad791ecf31899df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159325
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-11-11  Andras Timar  <andras.timar@collabora.com>  [c45779ce3d1b95abd037d3d4d706aca511dfdc24]

        On Linux dictionaries are packaged separately
        
        Change-Id: Iadbd5a1411c3b2c72deb59ba91f86d889a34fdc3
        (cherry picked from commit 135a474477d143ffbe877d95ba37c008c509e45f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [454d70247fee7e0fc255f2605836b52804eba41f]

        ofz#63845 Integer-overflow
        
        Change-Id: Ic2396c92b53012642976e75fcfa42cf2737f3092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [8d6209d92dedf46d6d7c084b54dd1ebcbe55f1c4]

        Finally remove superfluous --with-theme=default option
        
        ... as suggested in commit 7524f45e0a2b86dc418f0eb76df89dbdbecfafd3
        (remove superfluous --with-theme=default option, 2014-08-22).
        
        Change-Id: Iddd1e000039846023c3a4e2ebd73b0010d70c706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159320
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3b74fa43f537f471b1b87741d703f2696ed24510]

        Simplify input theme filtering
        
        Change-Id: Iaa96feee79902f780409a19f97fed201793a66ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159319
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [db029c5a02880beb262165822a2e833c47569984]

        When MPL subset needs to disable icon themes, suggest filtered input
        
        A suggestion like "you wanted to have a, b, c, d; you need to exclude
        b; use e" makes little sense :-)
        
        Change-Id: I0212f0197b89c3e9d281fa5b24708672b82561b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159318
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [619b0fcef2e645347ba959852748614ba8283d88]

        Remove exec bits on rtf file
        
        Change-Id: I00f56edefeba01ab75fa504a074a5c99269bcef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159321
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0d0068f7231e2839c24370c69c9176d353b1945a]

        Make the unit test linear and more explicit
        
        In the pevious state, the test would not even fail in case when import
        started to drop last paragraphs.
        
        Change-Id: Ic28d059ed41f88c9264743034a5ce5397fff0b2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159317
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [42f6e7e5d638bbc3b597b22dbf5689bcbe86292a]

        Fix Windows 64-bit build using VS 2022
        
        ... after commit fce18155052821756466ea043c638f4ed72f41d6, failing like
        
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
          C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)'
          C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or       'bool operator ==(ErrCode,const ErrCodeMsg &)'
          C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or       'bool operator ==(const ErrCodeMsg &,ErrCode)'
          C:\lo\src\core\include\tools/gen.hxx(536): note: or       'bool operator ==(const Selection &,const Selection &)'
          C:\lo\src\core\include\tools/gen.hxx(473): note: or       'bool operator ==(const Range &,const Range &)'
          C:\lo\src\core\include\tools/gen.hxx(365): note: or       'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)'
          C:\lo\src\core\include\tools/gen.hxx(361): note: or       'bool operator ==(const Size &,const Size &)'
          C:\lo\src\core\include\tools/gen.hxx(231): note: or       'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)'
          C:\lo\src\core\include\tools/gen.hxx(227): note: or       'bool operator ==(const Point &,const Point &)'
          C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
          C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x']
          C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or       'built-in C++ operator==(int, sal_uInt32)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: or       'built-in C++ operator==(int, sal_Int32)'
          C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or       'bool operator ==(const TypedWhichId<T> &,sal_uInt16)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
          C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or       'bool operator ==(sal_uInt16,const TypedWhichId<T> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
          C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or       'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or       'bool operator ==(T *,const VclPtr<reference_type> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or       'bool operator ==(const T *,const VclPtr<reference_type> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or       'bool operator ==(const VclPtr<reference_type> &,T *)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or       'bool operator ==(const VclPtr<reference_type> &,const T *)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or       'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(220): note: or 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const VclPtr<T2> &)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
          C:\lo\src\core\include\vcl/vclptr.hxx(224): note: or 'bool operator ==(const VclPtr<reference_type> &,const T *)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,const T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
          C:\lo\src\core\include\vcl/vclptr.hxx(229): note: or 'bool operator ==(const VclPtr<reference_type> &,T *)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const VclPtr<reference_type> &,T *)': could not deduce template argument for 'const VclPtr<reference_type> &' from 'Color'
          C:\lo\src\core\include\vcl/vclptr.hxx(233): note: or 'bool operator ==(const T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const T *,const VclPtr<reference_type> &)': could not deduce template argument for 'const T *' from 'Color'
          C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or 'bool operator ==(T *,const VclPtr<reference_type> &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'Color'
          C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
          C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
          C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1739): note: while trying to match the argument list '(int, Color)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): error C7692: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
          C:\lo\src\core\include\vcl/vclenum.hxx(174): note: could be 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)'
          C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or       'bool operator ==(ErrCode,const ErrCodeMsg &)'
          C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or       'bool operator ==(const ErrCodeMsg &,ErrCode)'
          C:\lo\src\core\include\tools/gen.hxx(536): note: or       'bool operator ==(const Selection &,const Selection &)'
          C:\lo\src\core\include\tools/gen.hxx(473): note: or       'bool operator ==(const Range &,const Range &)'
          C:\lo\src\core\include\tools/gen.hxx(365): note: or       'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)'
          C:\lo\src\core\include\tools/gen.hxx(361): note: or       'bool operator ==(const Size &,const Size &)'
          C:\lo\src\core\include\tools/gen.hxx(231): note: or       'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)'
          C:\lo\src\core\include\tools/gen.hxx(227): note: or       'bool operator ==(const Point &,const Point &)'
          C:\lo\src\core\include\tools/color.hxx(256): note: or 'bool Color::operator ==(const Color &) const' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool Color::operator ==(const Color &) const': rewritten candidate function was excluded from overload resolution because a corresponding operator!= declared in the same scope
          C:\lo\src\core\include\tools/gen.hxx(227): note: or 'bool operator ==(const Point &,const Point &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(231): note: or 'bool operator ==(const AbsoluteScreenPixelPoint &,const AbsoluteScreenPixelPoint &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(361): note: or 'bool operator ==(const Size &,const Size &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(365): note: or 'bool operator ==(const AbsoluteScreenPixelSize &,const AbsoluteScreenPixelSize &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(473): note: or 'bool operator ==(const Range &,const Range &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\tools/gen.hxx(536): note: or 'bool operator ==(const Selection &,const Selection &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\comphelper/errcode.hxx(247): note: or 'bool operator ==(const ErrCodeMsg &,ErrCode)' [synthesized expression 'y == x']
          C:\lo\src\core\include\comphelper/errcode.hxx(249): note: or 'bool operator ==(ErrCode,const ErrCodeMsg &)' [synthesized expression 'y == x']
          C:\lo\src\core\include\vcl/vclenum.hxx(174): note: or 'bool operator ==(const ItalicMatrix &,const ItalicMatrix &)' [synthesized expression 'y == x']
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or       'built-in C++ operator==(int, sal_uInt32)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: or       'built-in C++ operator==(int, sal_Int32)'
          C:\lo\src\core\include\svl/typedwhich.hxx(59): note: or       'bool operator ==(const TypedWhichId<T> &,sal_uInt16)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,sal_uInt16)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
          C:\lo\src\core\include\svl/typedwhich.hxx(51): note: or       'bool operator ==(sal_uInt16,const TypedWhichId<T> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(sal_uInt16,const TypedWhichId<T> &)': could not deduce template argument for 'const TypedWhichId<T> &' from 'Color'
          C:\lo\src\core\include\svl/typedwhich.hxx(43): note: or       'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(const TypedWhichId<T> &,TypedWhichId<T>)': could not deduce template argument for 'const TypedWhichId<T> &' from 'int'
          C:\lo\src\core\include\vcl/vclptr.hxx(238): note: or       'bool operator ==(T *,const VclPtr<reference_type> &)'
          C:/lo/src/core/sw/qa/extras/rtfimport/rtfimport.cxx(1750): note: 'bool operator ==(T *,const VclPtr<reference_type> &)': could not deduce template argument for 'T *' from 'int'
          ...
        
        Change-Id: Id976fe515287a4aa12d7ff8ca0ca09c31c65309f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159316
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9bba3a604d12566bfb5e8ab8d2788fe8d3690a96]

        use more concrete type in ImpEditEngine::SetUndoManager
        
        instead of dynamic_cast'ing to the type we want, and __ignoring__ the
        parameter if it is not, just adjust the type that we want, which
        luckily everything is already sending
        
        Change-Id: If083e11c9818cdcae199afc1261efbdb652e1c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159295
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f5926c8cfbd5af1fb7214428b4b03453b826f9a5]

        Move user agent initialization to InitCurl_easy
        
        Places that didn't initialize it previously, would benefit automatically
        
        Change-Id: I2f1ff25fc58d9378462072bc92d7b37be2370fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159299
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [50add2043752c7b07beccef9a509bea6c09619f8]

        loplugin:fieldcast improvements
        
        reduce false positives, and also check reinterpret_cast
        
        Change-Id: Ia6f214393f28451d18c16b764a3c2b149d29ba8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Oliver Specht  <oliver.specht@cib.de>  [fce18155052821756466ea043c638f4ed72f41d6]

        tdf#158044 handling of paragraph attributes in RTF import
        
        style attributes need to be repeated at the paragraph
        if not repeated then defaults have to be applied
        
        Change-Id: I4ee567e8006c240c046b7e7bb75eae92e5563776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158839
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [e021d5dee19f1e06c59aa2aa6d064d2b5f7e313b]

        Add missing license headers
        
        Change-Id: I4c94fb9d92b02b42b185d205887fa7bce1c45be6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159235
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [fac623a8b844ffd42bd6318dba91e9253268198d]

        Fix packaging with --enable-mpl-subset
        
        Change-Id: I1cae9e9a9837df968663b6f46bd1e0d369377126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159308
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [cf53900ae8f25529a001602d56fd2f08b6bdde3a]

        Fix packaging with --disable-curl
        
        Change-Id: I9c3c1f1953c4d59c5a2d4c6017e73768d93a7bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159307
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [500def307635fc4359c542df60a963da23225b54]

        Improve error logging in remove_Files_Without_Sourcedirectory
        
        Change-Id: I7ed7c08bd57bb5d1b11bc7c029decd571a6758f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [9aa2eee9d88df6f68befd4758bc5af847d07c805]

        Fix the fix
        
        Commit 87f0da8023081398d72372367db11d4a97d91833 put the check
        into a wrong position
        
        Change-Id: I459c11e00babfc604c5d35aac4f7cd0ce3701c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159237
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [630ea24fa493be653686689b63692c104f2b0ae5]

        ofz#64065 Abrt on config
        
        Change-Id: Idb76d58ab6036c9f38b0b76a3a240dcfb07d52a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159310
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-10  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [23e9a4cf1eec75cdd40a695ecae2af9b952178d3]

        tdf#158169 take no actions in disposed incarnation
        
        Using the described steps in the bug report it is possible
        to have an already disposed incarnation of ChildrenManagerImpl
        that gets called with notifyEvent. If exposed it is necessary
        not to execute actions, but to inform the caller by triggering
        a lang::DisposedException(). The SfxBaseModel::notifyEvent
        that executes this will then remove the instance from it's list.
        
        Change-Id: Ie39e37d6e55ea66f441e732b612774b18d7c3ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159306
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [867c4b75dd4a2cf9470c2859d51432f207eb4166]

        loplugin:fieldcast in SvxNewTableDialogWrapper
        
        Change-Id: Ia3efee04b725162e4812f1e419cc9d8e11b6d8f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Julien Nabet  <serval2412@yahoo.fr>  [fe12f1d83ba80dff9f36f06decf125650eac9097]

        Fix errors gtk4
        
        [AWK] CustomTarget/postprocess/registry/fcfg_langpack_qtz.list
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:249:85: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                                css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:329:83: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                              css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
        [XCD] registry_qtz
        [CUS] filter/source/svg
        [CUS] sw/generated
        [PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_generated.cxx
        [PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_generated.hxx
        [PY ] CustomTarget/writerfilter/source/ooxml/OOXMLFactory_values.hxx
        [PY ] CustomTarget/writerfilter/source/ooxml/qnametostr.cxx
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:311:81: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
        static void applyObjectAttribute(GtkAccessible* pGtkAccessible, const OUString& rName,
                                                                        ~~~~~~~~~~~~~~~~^~~~~
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:312:50: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
                                         const OUString& rValue)
                                         ~~~~~~~~~~~~~~~~^~~~~~
        4 errors generated.
        
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:329:83: error: passing 'css::uno::Reference<css::accessibility::XAccessibleContext>' by value, rather pass by const lvalue reference [loplugin:passparamsbyref]
                              css::uno::Reference<css::accessibility::XAccessibleContext> xContext)
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
        
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:312:50: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
                                         const OUString& rValue)
                                         ~~~~~~~~~~~~~~~~^~~~~~
        
        /home/julien/lo/libreoffice/vcl/unx/gtk4/a11y.cxx:318:52: error: no member named 'toInt32' in 'std::basic_string_view<char16_t>'
                const int nLevel = static_cast<int>(rValue.toInt32());
                                                    ~~~~~~ ^
        1 error generated.
        
        Change-Id: I01942a3f65e87e33a093f8994e4bf44e74bafc65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159291
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-10  Matt K  <mattkse@gmail.com>  [0c3b89da7cde9866bf3174a6276736c76efb8356]

        tdf#62603 Fix find/replace to not extend font attributes
        
        This change modifies the logic of the core replace code
        to now not replace the 1st character and extend its
        attributes, but instead to actually replace characters
        to keep respective formatting.  Additional checks
        are made for whether the replacement was shorter or
        longer than the found text, and to handle trimming
        or appending the final portions as needed.
        
        Change-Id: I03a5645898e55ad386bacc2766af9b244a97bd21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155274
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [87f0da8023081398d72372367db11d4a97d91833]

        Fix --disable-curl checks: --disable-online-update is needed
        
        Change-Id: I63598815a2ed3c7300102180a8a8439e2ef1605d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159234
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [7fc847a99c25590cdc8c0629448e4d3979af94b6]

        Improve MPL subset directions text a bit
        
        Change-Id: Ibf91009a2dea5a728bf27388168199e87a1d05d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159233
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [6976c0ad33d44213417e88dc1aada88c6a5b2d8f]

        loplugin:fieldcast in mailmerge unit tests
        
        Change-Id: I3c5f31848ea572678a6ba85463ebda04b882eeaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4216ba557577e8fef4dfc1dc5aa35ea1e1ef082]

        loplugin:fieldcast in OTableStyleContext
        
        Change-Id: I8c5c1d569d022ac679e4939d97fdd293000c23ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159300
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bb79936ec808712f53bc48663a485875571ba643]

        tdf#96854 - De-static-ize last used option for copy/move sheet
        
        Change-Id: Iafb12b51f166f9485f1658c406a98e5db5b246ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159292
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-11-10  Kohei Yoshida  <kohei@libreoffice.org>  [e890b0f0a90316b69f49e0e9d3cb2b1b4528084a]

        Upgrade orcus to 0.19.2
        
        Change-Id: I2cbf5f93c3b8b2235828affdef7309c3611b19b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159258
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d5894cc9b2374db9b5d2335db2d3566513fe062]

        avoid unnecessary intermediate buffer
        
        and make it more obvious that we are doing recursive stuff here
        
        Change-Id: I00209e0123eaacb015484949700ea0c983278fbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159285
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [1041dc7d41e848e1690c67009a5add2eeeaf698b]

        reduce noise in exceptionToStringImpl
        
        otherwise we end up with log messages like
        
        wrapped: void message: "at
        C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/comphelper/source/misc/diagnose_ex.cxx:66"
        
        when we call ourself to print out sub-exceptions
        
        Change-Id: I9e598a6b68469e9baa3232811f310b7e24f1b77e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Miklos Vajna  <vmiklos@collabora.com>  [8d973c5b9405bfa6964d3dfebd0017fd60ec3eca]

        sw floattable, insert UI: default to at-char for non-split flys
        
        Inserting new images defaulted to the at-char anchor type, but inserting
        a new frame defaulted to at-para, which is inconsistent. This is now more
        visible, since LOK exposes the insert frame dialog.
        
        An additional problem is that the LOK case hides anything other than
        at-char and as-char in the frame properties dialog since commit
        4154d281fbecaadf6cd118c00cc6cff929e339a4 (sw lok: hide UI to set
        Word-incompatible anchor types, 2019-07-05), which was intended for
        images, but also affects text frames as well. But floating tables want
        to-para anchored frames to be able to split.
        
        Fix the problem by defaulting to at-char anchoring, unless we deal with
        floating tables.
        
        And show the to-para anchor widget in the LOK case again, given that all
        of to-para, to-char and as-char have their use-cases, even when editing
        Word documents.
        
        Change-Id: I89b0973183a750d86f56e0cccd7b0fbcb3dc070d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159261
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-10  Stephan Bergmann  <sbergman@redhat.com>  [c1bd25e4674571e04b6445af36e4520a70ac166b]

        Disable flakey navigator UITest again
        
        f2ba17fecb60d936599efb975d96a3ea06c2a43f "disable more flakey navigator UITest",
        then 0a0c5a5b0521bea6cb695731d448e62c41ed4c57 "UITest_sw_navigator: avoid
        oneprocess" enabled it again, apparently in the false hopes that non-oneprocess
        would magically fix this issue.  But this still causes frequent failures, e.g.,
        <https://ci.libreoffice.org//job/lo_ubsan/2974/> failed with
        
        > ======================================================================
        > FAIL: test_tdf134390 (navigator.navigator)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
        >     self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
        > AssertionError: '1' != '2'
        > - 1
        > + 2
        
        and <https://ci.libreoffice.org//job/lo_ubsan/2975/> failed with
        
        > ======================================================================
        > FAIL: test_tdf134390 (navigator.navigator)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sc/qa/uitest/calc_tests8/navigator.py", line 145, in test_tdf134390
        >     self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
        > AssertionError: '53' != '2'
        > - 53
        > + 2
        
        Change-Id: I39e878c20085cca3233f7c8859b9a1d28fcc56c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159262
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [28756e84e48330b12087f6fc7d043c2fc5d67f28]

        loplugin:fieldcast in framework::AddonsToolBarWrapper
        
        Change-Id: I1fc692581acc805d6c84156d6df57093cf9dff93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159281
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e88c98f81c7ff515c3cf44db43c4961a1050a03b]

        loplugin:fieldcast in framework::MenuBarManager::MenuItemHandler
        
        Change-Id: I5a98f1bc5783bbd78ba6596ced9bb77cd3037f95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b048814f5eb2ed58c302a880a2eabf69473955e0]

        loplugin:fieldcast in accessibility::AccessibleContextBase
        
        Change-Id: Ibd71c2e809731114d4415754c8fd94110bd5736b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159225
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [860d18034f47e2b34b60137b0f7a1fa149988cd7]

        loplugin:fieldcast in oox::drawingml::Shape
        
        Change-Id: I0e5642f4f7dbb3f95d92fbb4dcf5b17f4becf503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [651b8080d1dc921e6ffbb8e176935bcc9d1b0b0f]

        loplugin:fieldcast in SvxClipBoardControl
        
        Change-Id: I5877e1dd8c17c36a5233457030d54349f11ab04f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [d294d1a32d88174559bd4490a8ee44bc5bb604ea]

        loplugin:fieldcast in XMLPageExport
        
        Change-Id: I07c5f2a6af46a3952d4fbc617d86174b1e23d518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159222
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [86441791e2ace0517025649ae4bbc33c371e5947]

        loplugin:fieldcast in framework::MenuBarWrapper
        
        Change-Id: I7e44ad4db77db5fe4de543f47ffc4b8127e0ebea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159255
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [53a48cce9f02232d595539e016f2bf3ad66ce7e3]

        Fix typo
        
        Change-Id: I6e0bd6560f3dbc289da3e3e7ae65514600a4ac58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159202
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-11-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [985b404f208559b4a91f31eb31dafa9d0384fdaf]

        tdf#158003 - UI: Part 22 - Unify lockdown behavior of Options dialog
        
        for Language - Writing Aids Page.
        
        Change-Id: I25723fb616544cd6ee7d894c3ca1aa6742748a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159186
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-10  Stephan Bergmann  <sbergman@redhat.com>  [2368e09cd13aa58d597470f73fb0f2e181e1929c]

        Disable flakey navigator UITest again
        
        f2ba17fecb60d936599efb975d96a3ea06c2a43f "disable more flakey navigator UITest",
        then 0a0c5a5b0521bea6cb695731d448e62c41ed4c57 "UITest_sw_navigator: avoid
        oneprocess" enabled it again, apparently in the false hopes that non-oneprocess
        would magically fix this issue.  But this still hangs frequently, e.g.
        <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/45650/> hung here (and
        got killed by kill-wrapper) with the python.bin process at
        
        > Thread 1 (Thread 0x7f85438bbb80 (LWP 217701) "python3"):
        > Traceback (most recent call first):
        >   <built-in method sleep of module object at remote 0x7f854143b728>
        >   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/uitest/uitest/test.py", line 72, in wait_until_property_is_updated
        >     time.sleep(DEFAULT_SLEEP)
        >   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sw/qa/uitest/navigator/tdf154521.py", line 158, in test_query_selected_bookmark
        >     self.ui_test.wait_until_property_is_updated(xContentTree, "SelectEntryText", "Bookmark 2")
        >   File "/usr/lib64/python3.6/unittest/case.py", line 622, in run
        >     testMethod()
        >   File "/usr/lib64/python3.6/unittest/case.py", line 670, in __call__
        >     return self.run(*args, **kwds)
        >   File "/usr/lib64/python3.6/unittest/suite.py", line 122, in run
        >     test(result)
        >   File "/usr/lib64/python3.6/unittest/suite.py", line 84, in __call__
        >     return self.run(*args, **kwds)
        >   File "/usr/lib64/python3.6/unittest/runner.py", line 176, in run
        >     test(result)
        >   File "/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/uitest/test_main.py", line 138, in <module>
        >     result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(test_suite)
        
        and the soffice.bin process just idling with nothing going on.
        
        Change-Id: I44a38b12050cfe2cf4831631406df9018018e2ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159260
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-10  Michael Stahl  <michael.stahl@allotropia.de>  [4e2f2489c4c7436f8b3a21a530bc625cbef4e365]

        tdf#153178 writerfilter: do not create text frame spuriously
        
        There are different RTF keywords that end up in RTFFrame, and some of
        them cause Word to create a frame, while others don't.
        
        Getting this right requires implementing support for all the missing
        wrapping keywords, as most of them create a frame in Word but
        \wrapdefault does not.
        
        Change-Id: I1e55d15180564f3d66a5ee7d98274ae18f032872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159228
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-10  Michael Stahl  <michael.stahl@allotropia.de>  [d45bd161a4750ca30639ce1c6ca6d6d070e6d2cb]

        vcl: don't override user's SSL_CERT_FILE for bundled OpenSSL
        
        Change-Id: I5d61fe62c2e6814ea757a0b543f7dbf45e0db456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159219
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba1c844fe8735702af31f79843221c5b94af8fe1]

        loplugin:fieldcast in framework::StatusBarWrapper
        
        Change-Id: I10198364323ed1886f6f356c964fc68bab8627e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159254
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [11a97db6c8552b3b4a6e312268ddc5f8ade0ee4e]

        loplugin:fieldcast in framework::ToolBarWrapper
        
        Change-Id: I4158b4c0b5ce57cca5a2a0978ac951274202c159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159253
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [8faf693cd11579e5c4d1ff2d017b1bb875d91ec1]

        loplugin:fieldcast in ModuleSizeExceeded
        
        Change-Id: I1903967d94fcd738b9e2ed8de9a19d42614a749e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b875ceabf0bd5572e15afccc2cbedaa783badca0]

        loplugin:fieldcast in SbModule
        
        Change-Id: I92084a1cf31832404aca43f0c8e2137a33978976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159251
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-10  Oliver Specht  <oliver.specht@cib.de>  [87be89ac27023f48f68a873b37df31aa0453d6fa]

        tdf#157363 add HTML format when pasting into draw text
        
        adds HTML to paste(special) in draw text in impress/draw/calc/writer
        
        Change-Id: Iaede82e1b3d48be362b70bd631e7f912b02b9822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158659
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-10  Skyler Grey  <skyler.grey@collabora.com>  [7924d8fc274bb611c829443e0eb1a53d883cc9a3]

        Fix STYLEREF crashes and forwards-compatibility
        
        This commit fixes a crash in STYLEREF caused by a dereferenced nullptr
        when serializing chapter fields for .doc export. Along with the STYLEREF
        changes, I also changed the chapter export logic to allow exporting
        chapter fields when they were in document text, and to use the style of
        the thing they pointed to. Unfortunately, in some cases that would be
        null. This commit makes us fall back to previous behavior in those
        cases.
        
        This commit also adds import logic for styleref on the TEXT namespace in
        addition to LO_EXT. This is important as if/when the STYLEREF field is
        no longer LO_EXT we want to be able to open new documents in old
        versions of libreoffice. This was erroneously missed when we changed
        TEXT references to LO_EXT in our export logic.
        
        Change-Id: I383828c9409afc8545af379307f528cee2e1a960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159226
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0012f23ca0b59edbb38da055d3388b465146f7eb]

        tdf#158007 - UI: Part 23 - Unify lockdown behavior of Options dialog
        
        for Writer - General Page.
        
        Change-Id: I2c679ee7f8e2d282a9f9ff19fc1743cb9bb6dbe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159250
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1b060fae845b1b1dfe0407fb576742b52b71942e]

        resave with newer glade version
        
        Change-Id: Ie0796286fd5648e5df4397861ba1f9afcce881c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159229
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-10  Miklos Vajna  <vmiklos@collabora.com>  [052c917d97aa88f21008cc3d978c6ca2ad83c88e]

        sw layout xml dump: avoid a static_cast in SwFrame::dumpAsXmlAttributes()
        
        Move the code to SwLayoutFrame from SwFrame, then no cast is needed.
        
        Change-Id: Ieb402efb19710adf94bce022fca484178fce719f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159227
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [3aca2d9776a871f15009a1aa70628ba3a03ee147]

        gtk4 a11y: Handle the "level" object attribute
        
        Add initial handling/mapping for object attributes.
        
        In LibreOffice and Gtk 3/ATK/AT-SPI, object attributes
        are currently key-value pairs, so arbitrary attribute
        names and values can be set.
        
        For Gtk 4, there's currently a discussion on how
        AT-SPI object attributes should be handled, s. [1].
        
        One potential option is for them to be handled as
        `GtkAccessibleProperty`s.
        
        In any case, there's already a `GTK_ACCESSIBLE_PROPERTY_LEVEL`
        property that matches the "level" object attribute that
        Writer sets for headings to specify what heading level
        this is (s. `SwAccessibleParagraph::getExtendedAttributes`)
        and that the gtk3 VCL plugin reports as an ATK/AT-SPI
        object attribute with the same name and semantics for AT-SPI,
        which is in line with the specification in the Core
        Accessibility API Mappings 1.2 [2].
        
        Map that LO object attribute to the above-mentioned
        `GTK_ACCESSIBLE_PROPERTY_LEVEL`.
        
        The property is currently not yet mapped to an AT-SPI
        attribute in Gtk 4, but together with a corresponding
        merge request [3], the object attribute can be seen
        in Accerciser as expected.
        
        While object properties in LO are currently generally
        only generated/updated when they're queried
        (via `XAccessibleExtendedAttributes::getExtendedAttributes`),
        the `GtkAccessibleProperty` handling in Gtk 4
        would require to explicitly call
        `gtk_accessible_update_property` with the new value.
        
        This may require further adjustments on LO side to
        keep the properties up-to-date (e.g. adding something
        like a new `AccessibleEventId::OBJECT_PROPERTY_CHANGED`
        event and then implementing corresponding handling in
        all places that provide object properties).
        But that's something to look into later, also depending
        on the outcome of the discussion in [1].
        (As of now, the gtk4 VCL plugin doesn't handle any
        a11y events, not even the existing ones.)
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/issues/6196
        [2] https://www.w3.org/TR/core-aam-1.2/#ariaLevelHeading
        [3] https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6549
        
        Change-Id: I024afd7b527a20922e69156e1562dda783be2b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159216
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [9cb506a37a3228cf820eaeec681e49c08607cf59]

        gtk4 a11y: Extract state handling to helper function
        
        Change-Id: I1f6dba461b328fc41de6d944bd8657daa9b05370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159215
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [51f4cadfdd50e757e593c3166d4e54c6b2634af9]

        tdf#158006 - UI: Part 21 - Unify lockdown behavior of Options dialog
        
        for Writer - View Page.
        
        Change-Id: Icbca23d3ec1dd95bbf703227b9479291a978a426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159126
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [38a4672bdb55314edc9ce2cd5224b879d8df007f]

        loplugin:fieldcast in ScXMLContentValidationContext
        
        Change-Id: I2a9138096c9e79381020eaddb75ddc1134201a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6370725d8a68645e82f16d61518fd2d400f148d]

        loplugin:fieldcast in XMLTableStyleContext
        
        Change-Id: I92b6bc3e765b19c9f250da43463aad253ba9347a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159196
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3afdf59d7a13101de6b943efb3395e6fc406ab94]

        give the Language Selection dialog the usual spacings
        
        Change-Id: I82dd94e0a0205bee2b6b2d0ef005f734d9d80f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159220
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [fcfb7f65bfc507a6bffebea98a9e9bd281ad9dbb]

        loplugin:fieldcast in rptxml::OControlStyleContext
        
        Change-Id: I2609090c26a2d405aedcca57a67ec9c5c329e122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [7a73eedf00541b5ba56b81e7d78faef4247f046f]

        Fix USE_CONFIG_APPROVE_CONFIRMATION and USE_CONFIG_REJECT_CONFIRMATION
        
        They still showed UI in case of signed macros.
        Two decisions were made, to improve security of USE_CONFIG_APPROVE_CONFIRMATION:
        1. In case of High macro security mode, valid but untrusted certificate will be
           automatically rejected (because it is not safe to automatically add trusted
           certificates) - so in this mode, USE_CONFIG_APPROVE_CONFIRMATION is the same
           as USE_CONFIG_REJECT_CONFIRMATION;
        2. In case of Medium macro security mode, valid but untrusted certificate will
           not automatically allow macros execution, but will proceed to the following
           checks - which on Windows will try to check the source's Security Zone, and
           may disallow macros based on that. Only after Security Zone check the macros
           will be automatically allowed.
        
        Change-Id: I1a9c92c6b940b689599c5d106798ecfc691dad46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159214
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d263b48a1353804816a55433f2ee90e96be1e32]

        loplugin:fieldcast in ScCompiler::TableRefEntry
        
        Change-Id: I5d02daa209b735fbc0dcd10fd45056d586837d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159211
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Andras Timar  <andras.timar@collabora.com>  [d9ccfb162f211565ea8e98ae58ab4199eac22452]

        replace license in package header to MPL-2.0 in case of MPL subset
        
        Change-Id: I0ba75ff7da69a3a45afde3252de272aa18f69932
        (cherry picked from commit fb228423017d2fce4491232f66299be6aa78b3d9)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [ec3ffe62685f9c5e944ae0924a9963fbe016a706]

        officecfg,desktop: add Office::Security::Net::AllowInsecureUNORemoteProtocol
        
        This disables the "com.sun.star.office.Acceptor" UNO service that
        handles the soffice "--accept" argument; now it can be disabled and
        locked in configuration by system administrator.
        
        Change-Id: I6747a128c3afa6a0cb351766365c8affc0b2614e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159151
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [8e46dd9599bc84f60abf2d2d5625fa15076dfc80]

        scripting: PyMailServiceProvider: implement AllowInsecureProtocols
        
        The "ehlo" calls look redundant, smtplib will do these implicitly if
        required (checked in Python 3.5.9); it will also check that the STARTTLS
        is successful which very old versions of Python didn't do.
        
        Change-Id: Ice8b24bc2c9773c1171e856f1aefb191b1e2e947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159078
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [1472e2d68b9cff43b99069d3ba9439fff0a5684c]

        vcl,openssl: set SSL_CERT_FILE for bundled OpenSSL
        
        OpenSSL may read a CA certificate file from $SSL_CERT_FILE, if the
        client library calls SSL_CTX_set_default_verify_paths(); python's ssl
        module does it but apparently libcurl does not.
        
        So split the code from commit 3fc632c0261c75fb4079a5305e814698e791f75c
        and set the environment variable in ImplSVMain(), hopefully before
        any threads are spawned; seems to work for PyMailSMTPService.
        
        This needs to have SYSTEM_OPENSSL available in a config header.
        
        Change-Id: I63b747cb61bb236cf4f605bb9858e5b0083388fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159149
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [a2fabc78a4ba12ad8df6b040783be0fa22aefa54]

        python3: name gdb pretty-printer after .so, not .bin
        
        So it works not only with instdir/program/python but also with
        soffice in-process python.
        
        Change-Id: I5c3643ef4a7ca0f25df3c6f51d11ff98c27f4bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159148
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [8b0b453ecbf41a33a33e45756fddc7ec3fbddfc3]

        swext: MediaWiki: implement AllowInsecureProtocols
        
        Change-Id: I0406431f2f923db5ae0c2c6bb889e7058096ca5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159080
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [b91daea3c1a38883c06cdd63c6eababe1df9e61d]

        tdf#146386 fpicker,svtools: remove FTP from Remote Files dialog
        
        Change-Id: I76ba8e275033c4d0a3c04964828dc640827cb7cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159073
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [7e5630b7b09f605aaba6ea8f54ff4c3761fe63db]

        tdf#146386 cui: remove FTP UI, SvxProxyTabPage
        
        Change-Id: I0831b1d99052c1fa8f0be38bee08eb712a168445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159072
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [46673b5c3215d05877043a81470b2a059c2eef75]

        tdf#146386 cui: remove FTP UI, SvxHyperlinkInternetTp
        
        Change-Id: Ib55d6609e0bea4033533e3211c04888e52b86bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159071
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [4a26dcac8e4f3ff3cbc3c356ad0a34968ef9d8fe]

        tdf#146386 curl,ucb: remove FTP UCP
        
        FTP support has been deprecated since LO 7.4.
        
        The UCP currently doesn't even support TLS connections.
        
        Also disable FTP protocol in libcurl.
        
        Also remove JunitTest_ucb_complex: turns out the only test in it,
        checkWrongFtpConnection, fails on Linux because now GIO UCP handles
        ftp:// URLs and it throws InteractiveAugmentedIOException instead of
        expected ones, and on other platforms it would fail differently because
        there is no GIO.
        
        Change-Id: I4631d124371fef390f105fb16bf09aaa59e739e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159065
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [5365daf67f8b81f69a47e3692a71fd3962505e46]

        officecfg,*: add Office::Security::Net::AllowInsecureProtocols
        
        By default, unencrypted network connections are allowed.
        
        But now it can be disabled, for everything that uses libcurl.
        
        Change-Id: I8e103f5a968ace2a19fdb9d6934c9a51b2aeabe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159011
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c32bf48b7446808ffc47472021ec32cb7c70eea7]

        loplugin:fieldcast in XclObjOle
        
        Change-Id: I255e94dfa1e0f336f78f6b8d470ae6aa2130196e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [700ac29771ccec2d66934f66b45a33a48a5ac3f1]

        Use proper type in expert config dialog
        
        In preparation for proper editing support for the different types.
        
        Change-Id: I7044ff100c9bfcca5fa8894ff4525a1aac692796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158028
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [c5c2d3195189a329516c918faa251cff4baaed5a]

        android: Drop unused LayerView#mFullScreen
        
        ... and the getters and setters.
        
        Change-Id: I14e69e2543d92dc63954bc3faf5a7456d2343fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159200
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [eee1ff965143910eb52895af471b260564938db6]

        enable unchecked lint for our java code
        
        and annotate where necessary, mostly just suppressing the warnings
        
        Change-Id: I8e39d797cde6c7c3f4e3e1bd93a128965ecec81d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b4cbd33588c194c21926bf6ab70aa76088a9bb09]

        Use hub link
        
        Change-Id: I1a54912ef87d5ea88e0122c7f2f8d4864092e5fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159208
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-09  Yli875  <qq3202390739@gmail.com>  [38f9bc92401899489c94276f8647a747f17598e1]

        tdf#114441 Convert sal_uLong to better integer types
        
        The maximum value of the width in BrowserColumn is LONG_MAX. tools::Long
        value range is the closest among other integer types. It is widely used
        in these files. Also, other parameter types and return types have been
        changed to match the width type.
        
        Change-Id: Ia8b941a8ea02075a0d9b4d44675d5809005738bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157477
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8ccd386b0793b14859ba2031b34853715606828c]

        default to ignoring libreoffice special-purpose protocols in calc hyperlink
        
        Change-Id: Ib9f62be3acc05f24ca234dec0fec21e24579e9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158911
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [f324220e8772799ecf2b21cb6084757c0e56953f]

        android: Drop Robocop comment
        
        Robocop is a tool for UI-testing fore Firefox on Android [1],
        but not used for LibreOffice Viewer, so drop the misleading
        comment.
        
        [1] https://wiki.mozilla.org/Auto-tools/Projects/Robocop
        
        Change-Id: I270735b2258f18691f60865c683856d58a94bb04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159199
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [aef1b023d5ccd3cf532f98f921734b22e4a027ed]

        android: Drop never-assigned to LayerRenderer#mPixelBuffer
        
        That member was never assigned a value but only read
        from by code claiming to be "used by robocop for testing purposes".
        
        [1] describes Robocop as a UI-level testing framework for Firefox
        for Android, which we don't use, so drop the class member and
        related test code.
        
        [1] https://wiki.mozilla.org/Auto-tools/Projects/Robocop
        
        Change-Id: I467296874d4295060cc9670d1f1c8b0dfeb77523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159198
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c621e6a2614dd8277def293b55d0444ea28c3d4e]

        loplugin:fieldcast in ExoticFileLoadException
        
        Change-Id: Ia4fac9b3313adc22e0f371cbff6828add474d097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159174
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [444548b4c7ac47028cdfe0a6c45b1cc32514848a]

        loplugin:fieldcast in ParaRstFormat
        
        Change-Id: I684e53a2c06ed1a6b2e85eb07162cd4ef43d0dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [d9a43fa5f94839d79cbd8524ba5c0b1865e6ad52]

        tdf#158125 android: Don't insist on RGB 565 EGL config
        
        As the `eglChooseConfig` doc [1] says:
        
        > eglChooseConfig returns in configs a list of all EGL frame buffer
        > configurations that match the attributes specified
        > [...]
        > Attributes are matched in an attribute-specific manner. Some of the
        > attributes, such as EGL_LEVEL, must match the specified value exactly.
        > Others, such as, EGL_RED_SIZE must meet or exceed the specified minimum
        > values.
        
        The config/attribute list used for Android Viewer specifies
        EGL_RED_SIZE=5, EGL_GREEN_SIZE=6, and EGL_BLUE_SIZE=5 and so
        far, only configs using exactly those bit sizes were accepted,
        causing 1 of the 11 devices used in automated tests in Google Play CI
        crashing with this stack trace:
        
            Exception org.mozilla.gecko.gfx.GLController$GLControllerException: No suitable EGL configuration found
              at org.mozilla.gecko.gfx.GLController.chooseConfig (GLController.java:219)
              at org.mozilla.gecko.gfx.GLController.initEGL (GLController.java:172)
              at org.mozilla.gecko.gfx.GLController.initEGLContext (GLController.java:176)
              at org.mozilla.gecko.gfx.GLController.initGLContext (GLController.java:57)
              at org.mozilla.gecko.gfx.RenderControllerThread.doSurfaceCreated (RenderControllerThread.java:132)
              at org.mozilla.gecko.gfx.RenderControllerThread.execute (RenderControllerThread.java:52)
              at org.mozilla.gecko.gfx.RenderControllerThread.run (RenderControllerThread.java:30)
        
        Since only configs fulfilling the minimium specification
        have been returned, I don't see a reason to insist on
        having one that uses exactly the specified amount of bits
        for the individual color components.
        
        I also didn't see any rendering issues in a quick test (also using
        the colorful Calc sheet attachment 188343 from tdf#156182) forcing the
        use of a configuration using EGL_RED_SIZE=8, EGL_GREEN_SIZE=8, and
        EGL_BLUE_SIZE=8 with an x86_64 AVD and on a Fairphone 3+ (arm64)
        using this temporary local change:
        
            diff --git a/android/source/src/java/org/mozilla/gecko/gfx/GLController.java b/android/source/src/java/org/mozilla/gecko/gfx/GLController.java
            index 45600e9f1e7c..9e7f348e9e72 100644
            --- a/android/source/src/java/org/mozilla/gecko/gfx/GLController.java
            +++ b/android/source/src/java/org/mozilla/gecko/gfx/GLController.java
            @@ -171,7 +171,7 @@ public class GLController {
                         mEGL.eglGetConfigAttrib(mEGLDisplay, config, EGL10.EGL_RED_SIZE, red);
                         mEGL.eglGetConfigAttrib(mEGLDisplay, config, EGL10.EGL_GREEN_SIZE, green);
                         mEGL.eglGetConfigAttrib(mEGLDisplay, config, EGL10.EGL_BLUE_SIZE, blue);
            -            if (red[0] == 5 && green[0] == 6 && blue[0] == 5) {
            +            if (red[0] == 8 && green[0] == 8 && blue[0] == 8) {
                             return config;
                         }
                     }
        
        Therefore, fall back to using another config that fulfils the
        specification.
        (Leave the previously required config as preferred one for now,
        maybe it still has advantages, e.g. might be more efficient due
        to not wasting extra bits for the color components that are
        not needed for the rendering in LibreOffice Viewer. (?))
        
        [1] https://registry.khronos.org/EGL/sdk/docs/man/html/eglChooseConfig.xhtml
        
        Change-Id: I953d292248004bc6f7e9384ceef78c8a88c21e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159204
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [a21e7a76d745750dcea14bc6311e4f1766c3fa45]

        android a11y: Add content labels
        
        Add a few content labels, so screen readers can
        present these UI elements in a more meaningful way.
        
        Reported by Google Play CI:
        
        > This item may not have a label readable by screen readers.
        > Learn more [1]
        
        [1] https://support.google.com/accessibility/android/answer/7158690
        
        Change-Id: Ic8e8885ed132367426207fad652e324ea4eb0790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159206
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [7938b495947e4311924bea7724a24c10e363de42]

        Downgrade expected failures in CoInitializeEx to SAL_INFO
        
        Change-Id: Ia4c72f9651b46314241543cd27767e6f1a23a321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159207
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Miklos Vajna  <vmiklos@collabora.com>  [e306352b9ddd8bddfc37f0cfaac078d9260650d6]

        sw floattable, insert UI: allow direct creation of floating tables
        
        The frame insert UI could move a table into a new fly, and then the
        frame properties allowed marking this fly as a split fly, but not in one
        step.
        
        This happened because the "split fly" checkbox is only visible when we
        have a fly that has exactly 1 table, but the "new frame" dialog has no
        fly as it still has to be created.
        
        Fix the problem by showing the "split fly" checkbox if we don't have a
        fly, but a single table is selected, because we know
        SwDoc::MakeFlyAndMove() will create a fly that has exactly one table in
        it.
        
        Extract the common code to a new
        SwFlyFrameAttrMgr::SingleTableSelected() to avoid copy&paste.
        
        Change-Id: I24129e3fb4cb6231fb10b0adda53c205dfd90d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159201
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [ef5828fb45e2b46a36b73260232dede3d98e22a4]

        lok: fix crash on DDE Link modify
        
        1. Open document with editable DDE Link section in 2 views
        2. View A selects content containing section and copies that
        3. View A is closed
        4. View B tries to modify section
        Result: crash
        
        Avoid destroying SwTransferDdeLink in SwTransferable::~SwTransferable()
        what happens while calling RemoveDDELinkFormat in SwTransferDdeLink::DataChanged
        by keeping reference to it while iterating in SvLinkSource::NotifyDataChanged()
        
        Change-Id: Iba53a4c139f9d508d2f64bcc94b479761b84bf2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159040
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f505ba25335b1b279ab8164825c3d051cd74757]

        loplugin:fieldcast in AxisIndexWrapper
        
        Change-Id: I8cfd954d71349fb42f306020f17240755fd70c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [a85c7cf02603408b09c15344803e293bb4b5bb81]

        loplugin:fieldcast in ScVbaAxis
        
        Change-Id: Ie8ad7f6ff7e0fa52e7c7075520e5bf51ab8af7a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [33729810b5f8ff5232195a5390c58e6e50900253]

        loplugin:fieldcast in ScVbaFormatConditions
        
        Change-Id: I585387219765dddf48fcbad1cd73e900afc43ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Stephan Bergmann  <sbergman@redhat.com>  [4897083c120fbe7ea2fbe14f0f7d2cb293b79fa8]

        Move "Acceptor already exists" warning to where it belongs
        
        036ed05fe35044e49a91e12b6a8e5f36a5b9c4c2 "MWS_SRX644: migrate branch mws_srx644
        -> HEAD" had added this with misleading indentation, so it (apparently
        accidentally) did not pertain to the "aAcceptString was found in the map of
        already existing acceptors" case.  Then 4acffc240b4845beedfe66eaa571b814d65e2e57
        "catch by const reference" fixed the indentation, but left the warning at the
        apparently wrong place.
        
        Change-Id: Ie73368bc1294e9b716e3fca75e12363cb6240fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159157
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [a6f26b87a0c6b0bb7a92ed0878e7aaa57ec64260]

        lok: notebookbar: fix unit-copy-paste in online
        
        we can't remove hack in SfxDispatcher::Update_Impl yet
        because this made unit-copy-paste test in online broken
        
        reverts part of:
        commit 1a6d16cb14342f9a66f99960e96027af6e5369ef
        lok: notebookbar: query SID_NOTEBOOKBAR only when requested to switch UI
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I8cd801bbc912f2ab3f710f5c7133445f07c4e5de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159039
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-09  Miklos Vajna  <vmiklos@collabora.com>  [eef9ed1fa7c6b1fcd9dbe2942243e7957f9cdee1]

        gbuild: remove not needed gb_UITest_use_oneprocess
        
        It's the default. If one wants to opt out, gb_UITest_avoid_oneprocess
        should be used.
        
        Change-Id: I52433b20f63c06abf8cb15b8bd26da845ecee00c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159185
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f15a5638fb08c331efeaa3237eff16504cb61ac8]

        Fix typo
        
        Change-Id: I7051d0df2f21bbd5ad22404bd7b72c15aba5b861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159188
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [641f91100a30a9faf2d24de1c449b95b62fc37d5]

        Fix typo
        
        Change-Id: I3933be04cacda3dd271c20b2248561da85a069b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159190
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a2171ef07fbfa97a23f82adb1e4aca459b827cb4]

        Fix typo
        
        Change-Id: Ic714f23749c8f5c6c22e3e547e66324128726fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159191
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0ca6c807e4eca8586352e2e22c4c51b219076141]

        Fix typo
        
        Change-Id: I224a6615c7d380b38e9408e29f41d954813d6353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159187
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [40f71a944e3094d6670c2103e576ac369257606a]

        Fix typo
        
        Change-Id: I9423e9a6e796b8b0754d2f1c3d17ca99d325726c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159189
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [28245ae37723223c93fb0f915a599bb547c391f0]

        Reorganize Impress Options page
        
        Use Boxes instead of tables to avoid blank space when rows have
        different heights.
        
        Change-Id: I2befac16fda006ad2694f33a4ab8dcaadb8c9093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158835
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7ca9c5bd2e2e3cda5686b7b8f5b657161eb52cdd]

        Move "Enable Impress Remote" setting to presentation settings
        
        Instead of hiding it in the generic options dialog.
        
        This moves the last presentation related option to the presentation settings.
        
        Change-Id: I7056b43378c982f9ba496b59490ed762c1f4d21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158834
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [db3078bd8c8e3ce3a99fc3987bb6e93b609990c1]

        tdf#157431 Show description for expert config items
        
        Change-Id: I7d0257c2e06ed384f90ca3b51a6d2549044f2cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157148
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [560cb9c53e7c6d6b8164cdd92e897d3c99b850d2]

        android: Drop obsolete TODO comment
        
        This comment was originally for the code
        underneath, that has already been separated
        into a separate method in gecko-dev commit [1]
        
            commit 60ed20fee4095523ee498579c71fc17032d1004b
            Author: Patrick Walton <pwalton@mozilla.com>
            Date:   Mon Feb 13 12:27:09 2012 -0800
        
                Split out Java compositor shader program activation and deactivation into separate functions
        
        , but the comment was left behind.
        
        [1] https://github.com/mozilla/gecko-dev/commit/60ed20fee4095523ee498579c71fc17032d1004b
        
        Change-Id: Ied0a4aaec4d8228665748b834026b54c8e9615bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159184
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [f4358578251e35f92115ece0998c132ca3b402de]

        android: Drop unused GLController#checkForLostContext
        
        Change-Id: Ia9f313a1937d4d491b76e9e5d6e4689eeb20431b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159183
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [46c0c489904b2037a3ce381be95998fd7f6cdefb]

        android: Cast to GL10 in getter, not callers
        
        Better have a clear method signature than callers
        relying on implementation details.
        
        Change-Id: I4532f67aee8f8eac723401e43d3b6856ba37b346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159182
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [b6e5a8d60b8c63983000b41711941dc1c5b38102]

        android: Use local var instead of 'mGL' member
        
        It's never used except where it's also previously
        assigned, so use a local variable instead.
        
        Even the getter `GLController#getGL` gets
        it from the EGLContext instead of using the
        member.
        
        Change-Id: Icec909f6e3e508a16fb455e81474bb336dc09362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159181
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [e4a56c1996aeba2b7a8b022833198f2a6086eb17]

        android: Use local var instead of class member
        
        It's only used in this one place.
        
        Change-Id: Ia11ebc2ea60c4015698ac00bbec6711a20c0a22e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159168
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [3cedd0780e5777790cdfab9f2b7657187bea1627]

        android: Drop unused LayerRenderer#Frame#getMaskForLayer
        
        Unused since
        
            commit 96a498b44c0a0ca48ac9938d9414191850d47d18
            Date:   Fri Dec 19 16:24:02 2014 +0900
        
                android: remove screenshot layer
        
        Change-Id: I3b83596bb854cb4bdfc6281ca487c8be15bc61d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159167
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [61bfc27f0495ab0427453e6d6078c3abe4777f56]

        android: Drop LayerRenderer#Frame#mFrameStartTime
        
        The member is assigned a value that is never used, so just drop it.
        
        Might have been more useful before
        
            commit 8734422b0b85b54c3fccc2b678171ed174c2b8bd
            Date:   Mon Feb 23 20:53:35 2015 +0900
        
                android: remove DrawTimingQueue and PanningPerfAPI
        
        Change-Id: Ieec958c0d5a75fc47af467c73b218d6150ceaab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159166
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [120e76b45b3ded439f8be0e6dc4d1e306b231e30]

        android: Inline LayerRenderer#createFrame
        
        No need for an extra method just to call the ctor,
        and which is only used once.
        
        Change-Id: Ide909ad81c78dc822a721771ee068e0240750089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159165
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [8b3f0a66b4bf40eedc8c8a601b625c050388a29b]

        android: Add "@Override"
        
        ... to make clear that these are overriden methods from
        the `GLSurfaceView.Renderer` interface.
        
        Change-Id: I7ffc47ee8a7ca4b481f7d28c0a5084c89d9c7ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159164
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [ae61af836428c3ccb5606e2697ce8eab19ac9860]

        android: Drop misleading comments wrt methods invoked via JNI
        
        These methods are not invoked via JNI for LibreOffice Viewer.
        It might have been true for Fennec/Gecko, but isn't here, so
        drop the misleading comments.
        
        Change-Id: Ib3187b129f076f42706b3097f9535a7cca7ad55f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159163
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [30a981cc2061b374361bbf8862ec3889b06acf88]

        android: Drop unused LayerView#registerCxxCompositor
        
        The comment saying it's called via JNI is not true
        for LibreOffice Viewer, is probably from Gecko/Fennec
        days like the ones for previously dropped methods.
        
        Now that the method is gone, `mContext` no longer
        needs to be static, so make it non-static and drop
        the corresponding TODO comment.
        
        Change-Id: I32db3728234715bc29af1ad757c715003c70ca4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159162
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [d088e3cfc582beeabb26257f689c7e4e83e7e731]

        android: Drop unused LayerView#{g,s}etPaintState
        
        ... and the now also unused `mPaintState` member and
        related constants.
        
        Change-Id: Iefd40ca4a72d32807b136830833e88e250f8f38b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159161
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [0a5bf928d936443bf1ff84118a9790a9b334801c]

        android: Drop unused GLController#waitForValidSurface
        
        The method is unused, so drop it, and also the now never
        read `mSurfaceValid` member.
        
        Likely, the comment that the method is invoked via JNI
        was never valid for LibreOffice Viewer, but is from Gecko/Fennec
        days, similar to the case in the previous commit,
        
            Change-Id I54dd33a2ce30ebdc375a7c1fefacca6e99d2f571
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Nov 8 15:10:19 2023 +0100
        
                android: Drop unused GLController#resumeCompositorIfValid etc.
        
        Change-Id: I165d2c7ebf5b9ce940b608d738d9a10d5bef69ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159160
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [32423989263e17b8fdd1b8952180e025c50ed1bd]

        android: Drop unused GLController#resumeCompositorIfValid etc.
        
        The comment claiming that this function is invoked
        by JNI was true when the method was added upstream
        in Fennec/Gecko in commit [1]
        
            commit ae9420729da323d02a3f2f02d5a4b3043a619007
            Author: Kartikaya Gupta <kgupta@mozilla.com>
            Date:   Fri Jul 13 10:19:46 2012 -0400
        
                Bug 769269 - Update the graphics code to be able to deal with blowing away the layer controller, client, and view and creating them afresh. r=ajuma
        
        , but it's not true for the copy here in
        Android Viewer, so drop the unused method
        and `RenderControllerThread#compositionResumeRequested`
        that would only have been called from there and wouldn't
        have done anything anyway.
        
        [1] https://github.com/mozilla/gecko-dev/commit/ae9420729da323d02a3f2f02d5a4b3043a619007
        
        Change-Id: I54dd33a2ce30ebdc375a7c1fefacca6e99d2f571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159159
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Michael Weghorn  <m.weghorn@posteo.de>  [9032551306bfac623984bed0031cbd6b8bfe54fb]

        android: Drop unused GLController#provideEGLSurface
        
        It was already unused when added in
        
            commit a6ecd8b2a9f0f3eaa66388861a6dcc6260ec72b9
            Date:   Thu Jun 26 11:22:21 2014 +0200
        
                LOAndroid3: ant/make for building, Bootstrap project
        
        The method looks similar to the first half of
        `GLController#provideEGLSurface` and is unused,
        so drop  it.
        
        Change-Id: I0cabfddefcdcca97048cb6f494590afdde5c1dc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159158
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-09  Stephan Bergmann  <sbergman@redhat.com>  [c254acddbc5e45a7e70be3e7b688ed5dddca3c2d]

        loplugin:unnecessarygetstr (clang-cl)
        
        Change-Id: I79a1902fb1241f95fd4fa963918207154ae2347b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159134
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-09  Stephan Bergmann  <sbergman@redhat.com>  [a116e4f1a7b9df4d9f67cdb146508abcfa5a25d5]

        loplugin:unnecessarygetstr (clang-cl)
        
        (Thanks to Mike Kaganski for noticing the gotcha here that a naive replacement
        with
        
        > std::wstring(const wstring& str, size_type pos)
        
        would do something rather different than
        
        > std::wstring(const wchar_t* s, size_type n)
        
        does.)
        
        Change-Id: I78837c014cdc154f276db1a11a87aaf74319a9fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159114
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [3a21ea3548abc8ba18bc50ba3d9f646e92ae7d5e]

        Simplify a bit
        
        Additionally, get rid of a variable that was for system path,
        but used "URL" in its name :-)
        
        Change-Id: I77db0ae42677e2fef1431d45b1736d2e54ff26d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159156
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [c7f43e0f3d03ec6583fbf7eb553eec53f3ec43b8]

        Do not throw on IZoneIdentifier COM error
        
        Not being able to obtain Security Zone info from OS is not a fatal
        error here; just handle it accordingly.
        
        Change-Id: Ifb19c88f2c08e99c313aecc54044252bac50f88e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159155
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [8fc4b8697b5ce487089069b76110c00660709290]

        Only create xSigner when necessary
        
        Change-Id: I4136c2ced3be445b6e763aa20856fec3792cdcb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159154
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ad6a8cf99b627d13f998ffcd7452a45386c649f5]

        tdf#158090: Do not auto-reject SignatureState::BROKEN in ALWAYS_EXECUTE case
        
        It doesn't make sense to silently reject it here, but e.g., allow the
        confirmation dialog for SignatureState::INVALID case; also, it was only
        possible to get a silent execution of BROKEN-signature macros (in Low
        security mode) vs. silent reject (in all higher modes) - which was not
        good security-wise. Now it will result in the usual confirmation dialog
        in Medium security mode.
        
        Both BROKEN and INVALID signature states are made sure to not allow
        automatically depending on the Windows Security Zone.
        
        Change-Id: I41b0fc96b6bd00e960ae612e79fa1f0f1e06a069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159153
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [fd53dd42151d0de566963829d1aace237a635bb8]

        Simplify a bit
        
        Change-Id: Ibf5a0800d7b9410a6191e3be7deef1edd4725640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159152
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [47c564280e69e52c2a69cd553c654f9e04f3ae89]

        Early shortcut for cases requiring both macro and document signatures
        
        This avoids a possible problem in High security mode, introduced in
        commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb (Improve macro checks,
        2021-01-28), where a valid but untrusted macro certificate initiates
        a UI asking to always allow this certificate; but no matter what user
        chose, macros will be disallowed when the document itself is unsigned.
        Now it will check the document signature state early.
        
        Change-Id: If2255be5da19f3de0090154f0b891ed9496e7bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159105
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd2988a5911758cc6c56942c235857fd9a327fd4]

        use more concrete sd::Annotation in AnnotationManagerImpl
        
        instead of casting to and from the UNO type
        
        Change-Id: Ia69865e1c4fb809e325335d33118287bcc692a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159177
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [9edefc2d441d6879cc64d6b18fabd5682d9e464c]

        use less UNO in AnnotationManagerImpl
        
        use the "real" underlying objects instead of the UNO wrapper objects
        
        Change-Id: I70b7c5b90da5ca07a2c73af2121f5399ae411bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159176
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [dae818cf81763dedad573c86b352f1cfedcfeb64]

        loplugin:fieldcast in SwDocShell
        
        Change-Id: I81739c24ae1174ff9f889490b8152dda7b61f328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159171
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [43c9c359471ed6a91bf4eff3f75dddba3ca2214c]

        loplugin:fieldcast in Num_Info
        
        Change-Id: I9d839c22579e5bc5fe6250a8aab0285ca9e0a4c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [1564e33b861f22c0f6eac546deca5300d5d7b56f]

        loplugin:fieldcast in SwGrfNode
        
        Change-Id: I95411fa20c38238d1ee74e8d73dd0a9553b9ad45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159169
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [358d31b4c862782a3717b8ad00cd8d5ddd6ea1e3]

        loplugin:fieldcast in SfxObjectShell_Impl
        
        Change-Id: Iae953c39abd66bf1a484590d322974382f25d278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159173
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4f52e3bb7f034035ba90ac95611253098959dfd]

        loplugin:fieldcast in FmXUndoEnvironment
        
        which means we can also use unique_ptr to manage this field.
        
        Change-Id: Icf31fa718af455148601efafbcc69067c5c27a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [f843c4b57f82b282cadc8eca2d80ed15d15993eb]

        loplugin:fieldcast in sd::OutlineView
        
        Change-Id: I7fd3058f84d2bf2d9e02a50cefe5691038ecb7da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [a984289075a46b600052269d7aa5682e8906ce10]

        loplugin:fieldcast in SelectedSheetsEnumAccess
        
        Change-Id: Ie7b61eee10259358a86b46f2cb5e90fad9a2100e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159178
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce98f8d033ab9dfd505448860981472153970e96]

        loplugin:fieldcast in SwSelPaintRects
        
        Change-Id: I62471db74c30baf8bd42a3679624c767c68c66f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [aea53c0ed1527ed1f8233972a27128e14d645e8f]

        loplugin:unreffun (clang-cl)
        
        ...and make things private/protected, while at it
        
        Change-Id: I5854f55dfe073e30b853c0d3bbafc4b7293c7f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159132
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [79ac262c926ea2845a5ed50d7abe5e9572fbdfc6]

        Avoid initialization-order-fiasco in DBG_UTIL code
        
        ...as reported by <https://ci.libreoffice.org/job/lo_ubsan/2973/> during e.g.
        Gallery_backgrounds, when initializing the global variable
        
        > const Cell OBJ_CELL_NONE;
        
        at svx/source/dialog/framelinkarray.cxx:281,
        
        > ==519895==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x7fb3dc3e5570 at pc 0x7fb3daee1c56 bp 0x7ffe54584480 sp 0x7ffe54584478
        > READ of size 8 at 0x7fb3dc3e5570 thread T0
        >     #0 0x7fb3daee1c55 in std::_Hashtable<SfxPoolItem const*, SfxPoolItem const*, std::allocator<SfxPoolItem const*>, std::__detail::_Identity, std::equal_to<SfxPoolItem const*>, std::hash<SfxPoolItem const*>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, true, true> >::bucket_count() const /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/hashtable.h:673:16
        >     #1 0x7fb3daee1648 in std::__cxx1998::unordered_set<SfxPoolItem const*, std::hash<SfxPoolItem const*>, std::equal_to<SfxPoolItem const*>, std::allocator<SfxPoolItem const*> >::bucket_count() const /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_set.h:755:21
        >     #2 0x7fb3daeb1088 in std::__debug::unordered_set<SfxPoolItem const*, std::hash<SfxPoolItem const*>, std::equal_to<SfxPoolItem const*>, std::allocator<SfxPoolItem const*> >::insert(SfxPoolItem const*&&) /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/debug/unordered_set:369:35
        >     #3 0x7fb3db01987c in SfxPoolItem::SfxPoolItem(unsigned short) /svl/source/items/poolitem.cxx:506:28
        >     #4 0x7fb3cb2fddb4 in svx::frame::(anonymous namespace)::Cell::Cell() /svx/source/dialog/framelinkarray.cxx:204:5
        >     #5 0x7fb3cafa3b6f in __cxx_global_var_init.1 /svx/source/dialog/framelinkarray.cxx:281:12
        >     #6 0x7fb3cafa3ba9 in _GLOBAL__sub_I_framelinkarray.cxx /svx/source/dialog/framelinkarray.cxx
        >     #7 0x7fb3e6821f19 in call_init.part.0 /usr/src/debug/glibc-2.28-225.el8_8.6.x86_64/elf/dl-init.c:72:3
        >     #8 0x7fb3e6822019 in call_init /usr/src/debug/glibc-2.28-225.el8_8.6.x86_64/elf/dl-init.c:118:11
        >     #9 0x7fb3e6822019 in _dl_init /usr/src/debug/glibc-2.28-225.el8_8.6.x86_64/elf/dl-init.c:119:5
        >     #10 0x7fb3e6836cb9  (/lib64/ld-linux-x86-64.so.2+0x1dcb9)
        >
        > 0x7fb3dc3e5570 is located 48 bytes inside of global variable 'incarnatedSfxPoolItems' defined in '/home/tdf/lode/jenkins/workspace/lo_ubsan/svl/source/items/poolitem.cxx:473:47' (0x7fb3dc3e5540) of size 96
        >   registered at:
        >     #0 0x43c078 in __asan_register_globals.part.0 /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360:3
        >     #1 0x7fb3db01e7cb in asan.module_ctor (/instdir/program/libsvllo.so+0xb3c7cb)
        
        Change-Id: I490fb232e0944f18c49b734c621e1bf0c318baff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159120
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [4726801b3f4fb26373a0cbcb3c0e437449fa3baa]

        loplugin:external -> loplugin:conststringvar -> loplugin:redundantstatic
        
        Change-Id: If5705fdf626ea9096e1d80b614d1907ec6b66bb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159110
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  László Németh  <nemeth@numbertext.org>  [0156cba6e34026f8fa0f2912e503378a5ec2208d]

        tdf#43784 tdf#158114 sw accessibility: check missing linked graphic
        
        Show missing linked graphics and their abbreviated paths,
        (and as tooltips, full paths) in the accessibility checker.
        
        Change-Id: Ia378f4ea3260251d1b2530fadc48aea6e0323a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159150
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [e87937d1fab87fa3225f5bcc0d2f5182d5fcef39]

        loplugin:fieldcast in VCLXWindowImpl
        
        Change-Id: I9a0181e87653e1bf62245e8ddf381518a59f841b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [c0e516609b9836f05543591398aeb7e99fe23234]

        loplugin:stringstatic, lopluign:ostr (clang-cl)
        
        Change-Id: I7a928a2385286f6d1ab3887c8d315af3f47c052d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159135
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [c3c56b85605555e32fa09f6437c755d841152cf3]

        Adapt expected diagnostic output to clang-cl and the MSVC standard library
        
        Change-Id: Ie416e4170280b9f05ecac359655e71f65a525592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159131
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [0a2622760a967e9d64cfdc632548dd42c1836324]

        Drop presumably redundant null check
        
        In a18bdb3bc05e761704cc345a66a9d642bc4f4a0a "Integrate branch of IAccessible2",
        this had originally been
        
        >     if (pAgent && pAgent->IsStateManageDescendant(pXAccessible))
        >     {
        >         return;
        >     }
        
        so lets assume the `pAgent` check was only there to avoid a null deref
        
        Change-Id: I320c181ff7d86d7c328bf9e5139dce2df1facb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159130
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [94dbf63dcd1843b4d7d0515d63998adb8032ac3c]

        -Werror,-Wmissing-field-initializers (clang-cl)
        
        Change-Id: I14c0d223b5f92456c9f160933e3f1eb99bfc6cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159133
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1d15b223ad741acc90690918ee43096b494b942]

        loplugin:fieldcast in SwHTMLParser
        
        Change-Id: Ie610358d3f9b1a1950edf617720ad13d4cfc57d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159129
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [0b8fd4aa900ac1e6102f4b2581cabbb1b81a7b13]

        loplugin:fieldcast in SwXMLTableContext
        
        Change-Id: I510a37b4caeb93719083eb09efd908672006428a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [39d6c115f2cc7597031caa88e0d044d5dca04fae]

        loplugin:fieldcast in XMLRedlineImportHelper
        
        Change-Id: I8338e6bf675b9508a5e085f353b23223da48067f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cc3533a11837ee6e6a0f774eee61a9561aa7432]

        loplugin:fieldcast in SwWW8ImplReader
        
        Change-Id: If27ac0047d5f63164ea6b142b857077abf7b5a51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [08640728b2c3793816ec4366924e60ac291cfd8c]

        loplugin:fieldcast in SwXMLItemSetContext
        
        Change-Id: I9a3789d1ea28ddb0e21de73f1dafcaa9dcf68d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159127
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [b1afd3413dabf33d500796d037e85fdb38c4ec5b]

        Adapt compilerplugins/clang/test/locking2.cxx to clang-cl
        
        ...where loplugin:locking2 is disabled
        
        Change-Id: Ie6a241ac49670e47001cba67c7af9996623a23ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159109
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [bfba46d90fc4146ab2a48d155d90dafc8c0a067e]

        Simplify a bit
        
        Change-Id: I05ef5346f5aab25b208aa058658353cf71e68e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159103
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f0df7c7c7fd4109937f21c2278f9a57e59c73761]

        FROM_LIST_NO_WARN was handled above
        
        Change-Id: I88da25f5f2819edd78fb95573c619cd8e3187469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159102
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [85a8c29e26f0bf48906312103e57246685d32c7e]

        tdf#158090: Limit signed document requirement to High security level
        
        Commit 1dc71daf7fa7204a98c75dac680af664ab9c8edb (Improve macro checks,
        2021-01-28) introduced a new requirement, that trusted macro signature
        must be accompanied by valid document signature when the document has
        events calling macros, otherwise macros are not allowed. But this breaks
        multiple workflows, where security level is set to limit users' ability
        to run unsigned macros, where documents aren't signed.
        
        As the first step, limit the security hardening introduced in the said
        commit to High security level; in Medium security level, restore the
        previous behavior.
        
        The plan is to fix more inconsistencies later, and then introduce a
        new separate configuration to require document signature to allow
        trusted macros (enabled by default), so that the combination of its
        default value and the High default security level keep the hardened
        default security implemented currently, while allowing users to opt
        to the previous documented behavior.
        
        Change-Id: I71ff0e531f3a42fbee7828982e4fd39f0e9d6ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159101
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [078e102b9fde39b4e5a1d32ace89a21e3ecc24bb]

        msi packaging job-limiter: use CXX_FOR_BUILD
        
        since it is a build-tool it needs to match the arch of the platform the
        build is performed, already had used ILIB_FOR_BUILD, but CXX was missed
        and broke the build for the aarch64 daily tinderbox
        
        Change-Id: I79edf7d3f7813b43bb447d580d071914a5053b95

2023-11-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [08b13064feb9c247333a973ba1033af3d7eca9cf]

        Update git submodules
        
        * Update translations from branch 'master'
          to 836a089516280362935a222d00518985605ff30f
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ie4efe4398551e1d099bd6d1280bddb491c75b8bd
            
2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [8987ca1b4a77b74382a594ccf340da88e58e577c]

        loplugin:fieldcast in SwXTextView
        
        Change-Id: Ifa5fc5fc537ec58ae9380e5af65a98dd016e2e9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e321557505b69fe804551528eb658bfcfdcae9e]

        loplugin:fieldcast in SdrUndoAttrObj
        
        Change-Id: I1d74c2d085908d3a91ab74e53f54110de9fbfd99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159096
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [e624979ce4e06f34ce8c8e8c2ee5c2b5a9a10f57]

        loplugin:unnecessarygetstr (clang-cl)
        
        Change-Id: Ic0ec1614d48382bb5735a67bf9588657b9ebd521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159106
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [3cd08e3b3c06336b0fb71c9f162796ce0f00f6fd]

        loplugin:staticaccess (clang-cl)
        
        Change-Id: Ifa06de5d3798bc426678aa7e3bec339282061bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159112
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Stephan Bergmann  <sbergman@redhat.com>  [71d9e8d3e403329428edbda747c7d6bbc705c95f]

        Adapt loplugin:stringconcatliterals to clang-cl
        
        ...whose handling of PredefinedExpr (representing `__func__`) deliberately
        differs in IgnoreParens and IgnoreParenImpCasts, see the comment in
        StringConcatLiterals::isStringLiteral
        
        Change-Id: I8b001d65369adc3d2a2c47e0cf32578a72ef4eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159111
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9d2b9b7c0c0c9f45f8893ba75f0fff31ef2b4af]

        fix spelling, selektion->selection
        
        Change-Id: I1924f3aaaf703e8fcdd5c56c4c22523124ff0746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d09226ebb217a1b616be5a0e6ea436fd2d2d52ee]

        fix spelling, Attribut -> Attribute
        
        Change-Id: Iac208ec7d7bf0b03dd957bbe547e42822c5e4c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159107
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [cc948bae82e63928a70451c6e71beb67e07f06e4]

        Add comments for the magic constants
        
        Change-Id: Ic35758357c18c9d172532819a3e8968fd66b26ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159100
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [89210b46b718edb6fffcbff610a789a5fea522e7]

        Set document's current macro exec mode consistently in adjustMacroMode
        
        Change-Id: Id69d4d043d824b1a9e558bfc9395c4ff64da7c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159099
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [ce625d02aa384694bad9bbec4df14eebee0666c8]

        Clarify FROM_LIST_AND_SIGNED_WARN description a bit
        
        Change-Id: Icab6b5b2e0c290bf67f1b330ad82553e9e37328e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159098
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e0dd56acca39524b63b708590f03a3cd6dcbe3ca]

        Related: tdf#158004 - UI: Part 20 - Unify lockdown behavior of
        
        Options dialog for Databases Page.
        
        Change-Id: I573479df8048a9ff4d4aedc9780cbe0395900526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159074
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-08  Miklos Vajna  <vmiklos@collabora.com>  [0ecb69d53864b582eb59533729ada01d85d383e6]

        sw floattable, insert UI: inherit fly width from selected table width
        
        Inline table width defaults to the body frame width, so a hardcoded 2cm
        default for the fly width is a bit poor.
        
        Leave the normal fly insert case unchanged, but if an entire table is
        selected, then change the default to the table width.
        
        Check for the table selection like SwFEShell::NewFlyFrame() does it, and
        determine if the entire table is selected like SwDoc::MakeFlyAndMove()
        does it.
        
        With this, a default table with a default frame keeps its width on frame
        insert.
        
        Change-Id: Iaf954395a4799222074acd83b5eae52ca75ae0ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159104
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4261f337b647bd504c9500f23fbb0cdd90a2d50e]

        ofz#63962 build failure
        
        Change-Id: Ib137db96e4880020e6120d391c291647bbf150f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159115
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1914124c6a343f58edbc52dab5238d03a7110ced]

        loplugin:fieldcast in MutableTreeDataModel
        
        Change-Id: I713db74dac43a61fe98ab18834e0dd6e24117caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [491d62a90a951fcba483c14900eb21213de73e22]

        loplugin:fieldcast in DataChangedEvent
        
        Change-Id: Ida928723e02643abfd01a42e22e12d60d78c72e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159095
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [33897a3dce5d31d0b869bc1507eed2ddcd3b1664]

        loplugin:fieldcast in SvTreeListBox
        
        Change-Id: I9a0053ff196e45a2d13ca2406ff67c8d95180b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159094
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc772833a1166151bac2911037659582df655bcf]

        loplugin:fieldcast in VbShapeRangeEnumHelper
        
        Change-Id: I18e24a4c0b86a6f9a456c0e962f87d74a4edf709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159093
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d31bb122bc5d7ca75a02d659bcf9dee3d429a165]

        loplugin:fieldcast in VbShapeEnumHelper
        
        Change-Id: Iece221df3b650078a1796d407459bbd96ad058e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159092
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Miklos Vajna  <vmiklos@collabora.com>  [ea7233bc1174b781c809db55d2c55af0011ce0e0]

        CppunitTest_sw_mailmerge: clean up not needed preTest()
        
        1) preTest() retuns a unique_ptr which has to be hold till the test
           runs, which didn't happen here.
        
        2) This was just copy&paste probably, since preTest() is not overwritten
           in this suite.
        
        Change-Id: Ib391f68d5dccb02ba6c42a298d1c86fe29c8606c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159081
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c71edc1f2e8226d4ac0f06a87f4f7f7107158f82]

        loplugin:fieldcast in AnimationData
        
        Change-Id: I2697d9201dfde8978224597d4c91f92f52585a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b8e58b3bea6fd67cb7c5dc25115a32ca6975117]

        loplugin:fieldcast in vcl
        
        Change-Id: Ib6300ae7d8081a71f6dd5238b14f4114479862b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [74f884d48ed27e1ce861620a57802ad156a86d15]

        new loplugin:fieldcast
        
        new plugin to look for class fields that are always cast to some
        subtype, which indicates that they should probably just be declared to
        be that subtype.
        
        Perform one of the suggested improvements in xmlsecurity/
        
        Change-Id: Ia68df422c37f05cbcf9c02ba5d0853f8eca4f120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c049ac6503c0f0f6bb7170b68c19ccb400c525f7]

        loplugin:fieldcast in CUPSManager
        
        Change-Id: I97cf8b9dc0553b9771209bde3fd9ae0301012186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f27c361531af17a13510deb86f0b8917d4d4276]

        loplugin:fieldcast in MenuBarWindow
        
        Change-Id: I2b8d8ce3bd20166637d1051fd0d4407a9b2a76b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1356892777b89b09ad7695e53d9e5ef1fca4f934]

        loplugin:fieldcast in xmlscript
        
        Change-Id: Iecf8519ae43015a3ad850251a7027e22ce5bf836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d1156b70d74033adecdb616c8276288785b84ac]

        loplugin:fieldcast in WindowImpl
        
        Change-Id: I6790f6272b606c2fe8f1bde63ec9d072975701df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [ff3fb42b48c70ba5788507a6177bf0a9f3b50fdb]

        android: Don't add "-editing" suffix to version/vendor
        
        Don't append "-editing" to the version string, which
        would then end up to be something like
        "24.2.0.0.alpha0+/7763190f7ec2/The Document Foundation-editing"
        when the build was configured with
        `--with-vendor="The Document Foundation"` and would result
        in the "About" dialog/widget saying
        "This release was supplied by The Document Foundation-editing."
        (s. `AboutDialogFragment#onCreateDialog`).
        
        While it's useful to have the different build flavors
        (with or without the experimental editing support), I see no need
        to have the build config reflected in the version string.
        (Whether experimental editing support was enabled during the
        build can easily be seen by checking whether the "Experimental
        Mode" option is available in the settings.)
        
        Change-Id: I48ddb3a842b9db4fc1f435683ed9d8e8e85898ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159079
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ebb51d094d9d58568ad6adf5730b04b5f24c7f25]

        tdf#158004 - UI: Part 20 - Unify lockdown behavior of Options dialog
        
        for Connections Page.
        
        Change-Id: I76510a893bb35e03e6401aeeb03971969cc42ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158989
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e990eaa9e12cfba0114cd6cea5510985d3b51f3]

        loplugin:fieldcast in xmloff
        
        Change-Id: Ic975c6344edb03e8bb8283a627fb70e05ca76239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [b22fe22139a42d51c0bbe542a6f7a782e771feb5]

        loplugin:fieldcast in vcl
        
        Change-Id: I699783305355c49854307cc83ec1e2e9a94cc326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159076
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Michael Stahl  <michael.stahl@allotropia.de>  [5f370409caa401b17b829caf2d48fbf7481c74bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 798773a4ad50b9311758a4ed2275f2f4ff53a3e0
          - tdf#146386 helpcontent2: FTP UI is removed
            
            Change-Id: Ie2d38acdf570644dbd087fd14e9485f263bdbb7b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/159067
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-11-07  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ab7c81f55621d7b0d1468c63305163016dd78837]

        ITEM: Get away from classic 'poolable' Item flag
        
        To understand this, some look back in history will be needed to see
        why it is as it is today. In some (reworked) comments 'poolable' is
        described as flag to hold Items in the ItemPool, also always having
        only one incarnation of each possible Item.
        This is not the original intention, but a side-effect. The reason is
        what the binary format in the office did: To save a document, the
        Objects & the Pool were saved, *not* individual Items *together*
        with the objects. The Pool was completely (binary) saved (and loaded)
        in one run.
        Temporary IDs were used to represent at the objects in file which
        Items were referenced. This *required* to have only one incarnation
        per item to have a minimal binary file size, thus this high effort
        was put into this. At doc load, the pool was loaded, all Items were
        set to RefCount 5000, the references from the objects were restored
        and then for each Item the RefCount was lowered by 5000 again
        and - if being zero - deleted. Items for UI were marked 'non-poolable'
        to *not* safe them with the document, so poolable was a flag to decide
        if that Info/Item was to be saved with the document - or more direct:
        if it is Model Data.
        Items are small, so if we prefer runtime it is okay to no longer being
        strict with this, anyways does not happen often and has only marginal
        memory effects - compared to runtime effects/savings.
        Other problems which this caused: One example is that objects in the
        UNDO stack were still in the pool, so e.g. deleted pictures were saved
        with the document despite no longer being used (!). That is the reason
        we have an UndoItemPool and a method MigrateItemPool to move stuff to
        that Pool when objects go to the UNDO stack - all of this is also no
        longer needed.
        Cleaning this up means to ideally have all items in the SfxItemSet,
        no longer at the Pool. The Pool should be reduced to a 'Default-Item-
        Holder' and a 'Slot-to-whichId-mapper'.
        
        This needs thorough cleanups/removals, but will be worth it because
        that massive simplification(s) will increase safety an runtime and make
        migrating to the goal of completely type-based ItemSet stuff easier for
        the future. Hopefully only view code in the office working with items
        will have to be changed for this.
        
        In this 1st step I already found that some 'compromizes' will be
        needed:
        - There are still Items that have to be at the pool to make the
        Surrogate-stuff working. This gives back all Items in a Pool of a type
        and is used in ca. 80 cases. Each one looks at these Items *without*
        context (e.g. a SfxItemSet at an Object would be a context), so if e.g.
        a dialog is open that temporarily uses Items of that type you would
        also get these - without knowing about it...
        To make that work there is still a mechanism to have Items at the Pool,
        but now just *registering* (and un-reg) them without any sort/search/
        remove needs. Also only for Items that need that, so I evaluated the
        GetItemSurrogates calls and added some asserts when GetItemSurrogates
        tries to access an unregistered item type which needs to be added.
        
        - Another caveat is that there are about 250 places that directly put
        Items to the Pool (not all remove these, that is done at pool deletion,
        so some kind of silent 'garbage-collection' is in place). To have an
        overview I renamed the accessing methods to separate them from the same
        functionality at the SfxItemSet, which had the same names. An
        implementation does still add these directly to the pool, there is no
        way to cleanup those usages for now. In principle all these should be
        changed to hold the data at an SfxItemSet.
        
        I am still hunting problems. But you can build the office, all apps
        work (including chart) and you can do speed comparisons already.
        
        There are test throwing errors, so I hunt these now. It is hard to
        give an estimation about how much more changes/corrections will be
        needed.
        
        Completed adaptions to new registered Items at Pool, that reduces the
        failing tests. Still many that I need to hunt.
        
        Added stuff to work around that 'compromize' in ScDocumentPool: It
        overloads ::PutImpl of the pool to implement special handling for
        a single Item in SC, the ScPatternAttr. In former code that method
        was used from SfxItemSet and ::PutImpl at the pool directly, so it
        was only used in one place. I am not sure if it was used from
        the SfxItemSet functionality, but better offer it for now. To not
        waste too much runtime the callbacks depend on the boolean
        'NewItemCallback' at the SfxPoolItem, it gets set for that single
        Item in SC and only then the callbacks trigger. I hope to get rid
        of those again, e.g. newItem_UseDirect is only needed since we have
        no 'real' StaticPoolDefaults currently - another thing that needs to
        be cleaned up in a next step.
        
        Since usages of impl(Create|Cleanup)ItemEntry and
        Direct(Put|Remove)ItemInPoolImpl got more and more similar I decided to
        unify that: move impl(Create|Cleanup)ItemEntry to tooling, make it
        globally available in svl and use it also directly for
        Direct(Put|Remove)ItemInPoolImpl. This slightly increases the failing
        tests again, but only since in Direct(Put|Remove)ItemInPoolImpl that
        fallback (e.g. tryToGetEqualItem) was used before, thus this is the
        same class of errors (SfxPoolItem ptr-compare) as the others which I
        will need to find anyways. Also fixed some missing stuff.
        
        Have now idenified and redirected all SfxPoolItem ptr-compares
        to be able to debug these - one cause for the remaining errors is
        probably that before with bPoolable those often were sufficient, but
        are no longer. Used the [loplugin:itemcompare] and a local clang
        build to do so, see https://gerrit.libreoffice.org/c/core/+/157172
        
        Stabilized Direct(Put|Remove)ItemInPoolImpl forwards, added parameter
        to implCreateItemEntry to signal that it gets called from DirectPool
        stuff - currently needed. Hopefully when getting rid of that DirectPool
        stuff we can remove that again
        
        Added two more debug functionalities:
        - Added a SerialNumber to allow targeted debugging for deterministic
          cases
        - Added registering & listing of still-allocated SfxPoolItems at
          office shutdown
        
        Found PtrComp error in thints.cxx - POC, thanks to
        areSfxPoolItemPtrsEqual. Will hopefully help more with other tests
        
        Found some wrong asserts/warnings where I was too careful and not
        finding something/succeeding is OK, fixes some UnitTests for SC
        
        For SC I now just tried to replace all areSfxPoolItemPtrsEqual with
        the full-ptr-content compare SfxPoolItem::areSame. I also needed to
        experiment/adapt the newItem_Callback solution but got it working.
        
        Did that replacement now for SW too, found some places where the
        direct ptr compare is OK.
        
        Continued for the rest of occurrences, now all 160 places evaluated.
        Also done some cleanups.
        
        Massive cleanups of stuff no longer needed with this paradigm change.
        Also decided to keep tryToGetEqualItem/ITEM_CLASSIC_MODE for now.
        It is used for *one* Item (ScPatternAttr/ATTR_PATTERN) in SC that
        already needs many exceptions. Also useful for testing if errors
        come up on this change to test if it is related to this.
        
        Added forwarding of target Pool for ::Clone in SvxSetItem and
        SvxSetItem, simplified SfxStateCache::SetState_Impl and returned
        to simple ptr compares in SfxPoolItem::areSame to not do the test
        in areSfxPoolItemPtrsEqual.
        
        Debugged through UITest_calc_tests9 and found that in tdf133629
        where BoxStyle is applied to fully selected empty calc the Item-
        reuse fallback has to be used not only for ATTR_PATTERN, see
        comment @implCreateItemEntry. Maybe more...
        
        Problem with test_tdf156611_insert_hyperlink_like_excel. Found that
        in ScEditShell::GetFirstURLFieldFromCell the correct SvxURLField
        is found and returned as ptr, but it's usage crashes. That is due to
        the SfxItemSet aEditSet used there gets destroyed at function return
        what again deletes the SvxFieldItem that is holding the SvxURLField
        that gets returned.
        This shows a more general problem: There is no 'SfxPoolItemHolder'
        that safely holds a single SfxPoolItem - like a SfxItemSet for a
        single Item (if Items would be shared_ptrs, that would be a safe
        return value).
        That will be needed in the future, but for now use another solution:
        Since I see no reason why EE_FEATURE_FIELD should not be shareable
        I wil change this for ow in the SfxItemInfo for EditCharAttribField.
        That way the Item returned will be shared (RefCnt > 1) and thus not
        be deleted.
        
        I changed the return value for GetURLField() and
        GetFirstURLFieldFromCell() in ScEditShell: At least for
        GetFirstURLFieldFromCell the return type/value was not safe: The
        SvxFieldItem accessed there and held in the local temporary
        SfxItemSet may be deleted with it, so return value can be
        corrupted/deleted. To avoid that, return a Clone of SvxFieldData
        as a unique_ptr.
        
        With all that UnitTest debugging and hunting and to get the paradigm
        change working to no longer rely on shared/pooled items I lost a
        little bit focus on speed, so I made an optimization round for the
        two central methods implCreateItemEntry/implCleanupItemEntry to
        get back to the speed improvements that I detected when starting this
        change. It was mainly lost due to that 'strange' chained pool stuff
        we have, so I added to detect the target pool (the one at which the
        WhichID is registered) directly and only once. Next thing to cleanup
        will/should be the pool and it's concept, all this is not needed
        and really costs runtime.
        Since implCreateItemEntry/implCleanupItemEntry are executed millions
        of times, each cycle counts here.
        
        Had an error in the last changes: pool::*_Impl methods use index
        instead of WhichID - most of them. Another bad trap, I really need
        to cleanup pool stuff next.
        
        Change-Id: I6295f332325b33268ec396ed46f8d0a1026e2d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157559
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [89780c208837973e21ddbf098d77f4369018ee9e]

        Pass XInteractionHandler to hasTrustedScriptingSignature instead of a bool
        
        This allows to use the same interaction handler there, as used in
        DocumentMacroMode::adjustMacroMode. hasTrustedScriptingSignature
        used to find its own interaction handler; and that would conflict
        with e.g. ODatabaseModelImpl::adjustMacroMode_AutoReject, which
        passes nullptr to adjustMacroMode, with intention to not show any
        UI; but with signed macros (see tdf#97694), the UI would still
        appear.
        
        Change-Id: Ia209f96bef67dccfe1da23c4d172ac47497f8eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [505f97b5b23954d689d55640977da6ec1af523b9]

        Add a description comment
        
        Basically describing commit 71c6f438cecc3ce5e8060efe1df840652885701c
        (tdf#129311 don't allow temporary trusted certs, 2019-12-17).
        
        Change-Id: I4d947014b09412638560e9249f242cf6ff222cc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159069
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [0054f303b030c2f552d9977a24b8e860b0ca15e0]

        use more TypedWhichId
        
        Change-Id: Ic52321ba38589a396a52d95454524ab8985cbafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae0956085971eaffc84af396b4ba0b57be78e851]

        use more TypedWhichId
        
        Change-Id: I37683d59e4994546ad4591d213b825ab080940eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b6a7d8201bdb6c28e18472326b2328507a6b1e4e]

        tdf#158083: RTF: drop export for \pgdsctbl
        
        This table is not standard extension to RTF format. It is not
        described in RTF specification and even is not used by Writer
        on import these days.
        
        Change-Id: I52f27dfd30877d461ad535b7847f40dd4c6f4ea5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158986
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [518df6a3bd6aa251dc4ad30ab3d04545513ae5c6]

        make this a more straight forward yes/no question
        
        instead of an ok/cancel, and default to no
        
        Change-Id: If86ca1b29d0dd91018fdc8edd6482a6d9ef5c0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [45daaf225ac626f06e876c0a0a6672a1653425b3]

        resave with newer glade version
        
        Change-Id: Id2c8977d6ab9d0632ac0350a78e52edba2280f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158988
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-07  Michael Stahl  <michael.stahl@allotropia.de>  [11f439b861922b9286b2e47ed326f3508a48d44e]

        curl: mitigate migration to OpenSSL on Linux
        
        The problem is that curl 8.3.0 removed the NSS backend, so we now
        have no other choice than to use the bundled OpenSSL on Linux.
        
        Currently any curl https connection fails with:
        
          CurlSession.cxx:963: curl_easy_perform failed: (60) SSL certificate problem: unable to get local issuer certificate
        
        Apparently this requires manually telling curl which CA certificates to
        trust; there is a configure flag --with-ca-bundle but that is useless as
        it tries to load the file relative to whatever is the current working
        directory, and also did i mention that there are at least 3 different
        locations where a Linux system may store its system trusted CA
        certificates because ALL ABOUT CHOICE.
        
        So add a new header with an init function to try out various file
        locations listed in this nice blog article and call it from way too many
        places that independently use curl.
        
        https://www.happyassassin.net/posts/2015/01/12/a-note-about-ssltls-trusted-certificate-stores-and-platforms/
        
        TODO: perhaps bundle a cacert.pem as a fallback in case the system chose
        to innovate by putting its certificates in yet another unexpected place
        
        (regression from commit c2930ebff82c4f7ffe8377ab82627131f8544226)
        
        Change-Id: Ibf1cc0069bc2ae011ecead9a4c2b455e94b01241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158915
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [6313e83a6f03540c1256e1e433cdf81b0913ff82]

        Rename variable: The UI is not only to "add" author (i.e., modify config)
        
        It is mainly to allow macro execution for this unknown certificate once.
        The UI will even disable the option to add, when the config is read-only.
        
        Change-Id: Iebc526c23572dc7c0e94fac79fafc8b402d451c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159051
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [deeb9a9ea982501761e4d1b9118eea76f386f86e]

        getCurrentMacroExecMode returns sal_Int16
        
        And that conforms the IDL definition of css::document::MacroExecMode
        
        Change-Id: I78ebfa94eb50552e7f4ecf3d64a0ac0556c56867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159029
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [59c7713e3a4fed3c67aa8df73203908c7816931a]

        Fix a typo
        
        Change-Id: I01dae264822c5394cabbb5cc4f7d4cb63190d23e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159030
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [53b289eabb3d265b47bc7fb6cc430291c97f0c0b]

        use more TypedWhichId
        
        Change-Id: If76b02a20b01624c2cc0aa5e3c310aa1dd930c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a9a99a8eee7be3d98ca705425a6778ee8efbfc8]

        use more concrete *PoolItem types in SwLanguageIterator
        
        rather than casting
        
        Change-Id: Ic134c30490fea7ae42bbf3194532ae0aad4c61c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1305f70cff8a81a58a5a6d9c96c5bb032005389e]

        warn about exotic protocols as well
        
        Change-Id: I50dcf4f36cd20d75f5ad3876353143268740a50f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151834
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-07  Stephan Bergmann  <sbergman@redhat.com>  [7763190f7ec27b733bfb83c3f1a5a5fdb3e43763]

        loplugin:unnecessaryparen
        
        Change-Id: Ic236de610c956c81f7eb8b0c27cee0b0ed6910ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159055
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-07  Michael Stahl  <michael.stahl@allotropia.de>  [584c01394ff06072b11ef4bd4bffb9e7f2d31e81]

        libcmis: fix regression setting wrong type of CURLOPT_SEEKFUNCTION
        
        Change-Id: I45421bbe13626aa843380e77f589e793328f99d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159010
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-07  Miklos Vajna  <vmiklos@collabora.com>  [4f1121255ebac035a439d242b47c2f81124418c3]

        sw floattable, insert UI: fix default frame width when inserting a new one
        
        Insert -> Frame -> Frame presented a dialog which stated the width of
        the new frame will be 2cm, but the width was ~zero.
        
        This is a regression from commit
        9da7b1592e010928c26c43ee93b91cdd66403985 (sw: remove all uses of MM50
        with (added) o3tl::toTwip, 2021-07-23). Previously the code worked
        because the 2cm was speficified as MM50*4 (283*4=1132 twips), and we
        compared this to the 2cm from the UI, which had no rounding errors
        (283.46456692913387*4=1134 twips), and this 1132 vs 1134 meant the
        dialog put the unchanged size to the output item set.  Now we don't have
        rounding errors anymore, so we have 1134 everywhere, which means the
        dialog doesn't specify a default size, but no other code would do it,
        resulting in a frame with minimal width, which is clearly not wanted.
        
        Fix the problem by checking if this will be a new frame, and if so, the
        dialog should send the default size to the caller, even if the user
        didn't customize the size.  This restores the lost 2cm default width
        while keeping the rounding improvements.
        
        This requires running the test in its own process, because the
        measurement unit is only loaded once from the config and the rounding
        error is not hit with the default inches.
        
        Change-Id: I9a5945fdd0e5cd64ff8bd84f95f11be5277b8d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159050
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-07  Miklos Vajna  <vmiklos@collabora.com>  [ca650cad8fccc7eb27c300ffb7aa7d961c83dc56]

        Update libxmlsec to 1.3.2
        
        Keep external/xmlsec/old-nss.patch.1 for now, though the baseline has
        been updated to RHEL 8 in the meantime, so probably it's not needed in
        practice.
        
        Change-Id: I4730f71f45937770ac3f78182f3f65eed64b5a6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159012
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-07  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [dab20fa2f6cc608a3497ff8d7e756806f8a59932]

        specify the reason for listing zxcvbn-c among build tools
        
        Change-Id: I814cebc6e8ca4815c055ed6f524bfebf08611ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159017
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [285c309ad7d92f6b92b5bdf1dd8f490fbdf59d56]

        gtk4 a11y: Map states to corresponding GtkAccessibleState
        
        Set those states that Gtk handles as `GtkAccessibleState`,
        see documentation at [1].
        
        For the LO a11y states, the Gtk 4 a11y API differentiates
        between three different enums/ways of handling those:
        
        * `AccessibleProperty`, for which handling was added in the
          previous commit, Change-Id Ic033e66dd89021defca449bbe2251102bbd61015,
          "gtk4 a11y: Map states to corresponding gtk a11y properties"
        * `GtkAccessibleState`, for which this commit implements
           the handling
        * `GtkAccessiblePlatformState`, for which handling
           was implemented in `lo_accessible_get_platform_state` in
        
            commit 341ff232aec77c2b46325389da933315613b6f2d
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Mon Mar 20 20:37:15 2023 +0000
        
                gtk4: get a11y to say hello world
        
          already.
        
        [1] https://docs.gtk.org/gtk4/enum.AccessibleState.html
        
        Change-Id: If22725dc2ccab5f73518e4171209a80a9c4df6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159006
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [a5c84405caf6f3dc51919fd937dfe21c3d6d53d1]

        gtk4 a11y: Map states to corresponding gtk a11y properties
        
        For those states in
        `com::sun::star::accessibility::AccessibleStateType::EDITABLE`
        that have a corresponding `GTK_ACCESSIBLE_PROPERTY_*`, set
        that property when creating a new `LoAccessible`.
        
        This e.g. makes Accerciser show the "multiline" and "multi selectable"
        AT-SPI states for a Writer paragraph when using the gtk4 VCL plugin.
        
        State updates are not handled yet, since a11y event handling is
        currently not implemented in the gtk4 VCL plugin yet.
        
        Change-Id: Ic033e66dd89021defca449bbe2251102bbd61015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159005
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [a182f283dabf5753e857a66386ef32226be47f49]

        qt a11y: Map AccessibleStateType::INDETERMINATE to Qt equivalent
        
        `QAccessible::State` has a `checkStateMixed` state flag [1]
        that matches what `AccessibleStateType::INDETERMINATE` is for,
        and Qt's AT-SPI adapter maps that to the AT-SPI equivalent,
        `ATSPI_STATE_INDETERMINATE`, so add the corresponding
        mapping.
        
        [1] https://doc.qt.io/qt-6/qaccessible-state.html
        [2] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/qspi_constant_mappings.cpp?id=c5d9e4a7a78b82ed31e5225c169de4718dfe4f05#n41
        
        Change-Id: Ic16f50344040f3d4ff7ad4ef0002abf5a7ae3dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159004
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [66fa5aeec5dbeba978f70fe464fbc87c3aba8ed2]

        qt a11y: Set passwordEdit state for PASSWORD_TEXT
        
        The Qt API doesn't have a separate role to distinguish password edits
        from other text edits, but has a `passwordEdit` state.
        
        Set that state for objects that have role
        `AccessibleRole::PASSWORD_TEXT`.
        
        With this in place, password entries,
        e.g. the one in the "Tools" -> "Options" -> "Security"
        -> "Password for Web Connections" -> "Master Password" dialog,
        are exposed via the `ATSPI_ROLE_PASSWORD_TEXT` role with the
        qt6 VCL plugin on Linux, because Qt's AT-SPI adapter takes
        the `passwordEdit` state into account when mapping the
        Qt a11y roles to AT-SPI ones. [1]
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=c5d9e4a7a78b82ed31e5225c169de4718dfe4f05#n1637
        
        Change-Id: Icb3f0935e703e2786c5704007cad7eea9070f8a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [e510da3b0379c63e6ecfefeb7358251591226701]

        gtk4 a11y: Map PASSWORD_TEXT role to gtk text box role
        
        This is in line with what the `GtkPasswordEntry` doc [1]
        says:
        
        > `GtkPasswordEntry` uses the `GTK_ACCESSIBLE_ROLE_TEXT_BOX` role.
        
        Note however, that gtk's AT-SPI bridge has specific code to map
        that to AT-SPI's `ATSPI_ROLE_PASSWORD_TEXT` for `GtkPasswordEntry` [2],
        which won't apply for any custom LO widgets.
        
        Currently, LO uses `GtkEntry` for password entries for gtk4
        as well, e.g. the one in the "Tools" -> "Options" -> "Security"
        -> "Password for Web Connections" -> "Master Password" dialog,
        so those currently have an AT-SPI role of
        `ATSPI_ROLE_TEXT` for gtk4, while it is
        `ATSPI_ROLE_PASSWORD_TEXT` for gtk3.
        (That's independent of this change, since a native `GtkEntry` is
        used there. Changing this to use `GtkPasswordEntry` instead of
        `GtkEntry` for the gtk4 case should cause that to use
        `ATSPI_ROLE_PASSWORD_TEXT` as well.)
        
        [1] https://docs.gtk.org/gtk4/class.PasswordEntry.html#accessibility
        [2] https://gitlab.gnome.org/GNOME/gtk/-/blob/fe4b7a5159e8cc3e4918ad1829d71ff39edd5ba7/gtk/a11y/gtkatspiutils.c#L308-310
        
        Change-Id: Iec6c8685f017b565553fbc63b4403484be20ed1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158984
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [dff76b069e26a6d3487f74c5784d6f6cf273a19e]

        tdf#135236 a11y: Notify a11y layer of WeldEditView sel change
        
        Extend `WeldEditView::EditViewSelectionChange` to not only
        invalidate the view, but also notify the `AccessibleTextHelper`
        of the selection update, so the corresponding events are sent
        on the a11y layer.
        
        This e.g. causes the `CARET_CHANGED` events to be sent as
        needed when moving the cursor/caret using the arrow keys in the
        "Not in dictionary" text edit in Writer's spelling dialog
        ("Tools" -> "Spelling"), so the Orca screen reader on Linux
        with the gtk3 or qt6 VCL plugin announces the new caret position,
        which was no longer the case since the spelling dialog was welded
        in
        
            commit 243b5b392906042ab03800e0b5765e6f3513372c
            Date:   Fri Jun 14 21:56:44 2019 +0100
        
                weld SpellDialog
        
        The newly added `AccessibleTextHelper::UpdateSelection` is a
        simplified version of `AccessibleTextHelper::UpdateChildren`.
        
        Change-Id: I5f0898c3ccb9fd527a6ff672be49157cb6e518b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158992
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  Michael Weghorn  <m.weghorn@posteo.de>  [0769e5e698a9cff77a815118dad82bc763520679]

        tdf#135236 gtk3 a11y: Restore AtkObject's focus_event
        
        After
        
            commit 14e6a810e14e28ab82fe65d66e604ce562016845
            Date:   Mon Aug 15 13:14:08 2022 +0100
        
                fix "invalid class cast from 'OOoAtkObj' to 'GtkWidgetAccessible'"
        
        , Orca with the gtk3 VCL plugin was no longer announcing focus
        (and content) for the "Not in dictionary" text edit in Writer's
        spelling dialog ("Tools" -> "Spelling") when moving the focus
        there e.g. using the Tab key.
        
        Make it work again by restoring the `focus_event` function
        from `AtkObject`, similar to how
        
            commit f0827c392641b45647241b3a22e24a95e2b595e3
            Date:   Fri Aug 19 16:13:04 2022 +0100
        
                Resolves: tdf#150496 we want the AtkObject get_parent function
        
                GtkAccessible overrode it, but we expect the AtkObject implementation
        
        did for the `get_parent` function to fix the announcement
        of Writer paragraphs after the above-mentioned commit.
        
        The other functions that `gtk_widget_accessible_class_init`
        overrides [1] are already explicitly set to the wrapper
        ones (s. the lines above the ones added in this commit), so
        don't need additional changes.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/blob/c47425c62efb99be8cd2f0eea651dda76a99ba04/gtk/a11y/gtkwidgetaccessible.c#L542-557
        
        Change-Id: Iae3b47f7fa7fe5ca90acb045a077cf0af52dd7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158990
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-07  László Németh  <nemeth@numbertext.org>  [698935c220131bc761eb9cf25e01fa91087a788e]

        tdf#152155 vcl: fix gtk popup listbox positions on sidebar
        
        It was fixed only on Wayland previously.
        
        Follow-up to commit 15cdee0d846854b50dd04626b73499bef9305e00
        "Resolves: tdf#152155 use gtk's knowledge of relative widget positions".
        
        Change-Id: I7a8b17189b319146142a2193ec4b5ec41e2c2d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159020
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-07  Stephan Bergmann  <sbergman@redhat.com>  [c662c66829187e5e1ccf6cba752928b7056a4cab]

        Fix SwLanguageIterator::Next for RES_TXTATR_AUTOFMT
        
        ...following advice by mstahl, as discussed in the comments starting at
        <https://gerrit.libreoffice.org/c/core/+/158732/2#message-053bc195667ee3ba396ed12a85f3af8d4b7e5efc>
        "tdf#157667 sw track changes: fix cycle case on multiple words", which had
        started to cause
        
        > /sw/inc/txatritr.hxx:69:18: runtime error: downcast of address 0x603001b45d90 which does not point to an object of type 'const SvxLanguageItem'
        > 0x603001b45d90: note: object is of type 'SwFormatAutoFormat'
        >  00 00 00 00  f0 0f 53 4e 3b 7f 00 00  02 00 00 00 32 00 90 be  20 31 36 00 80 60 00 00  c0 5d b4 01
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwFormatAutoFormat'
        >     #0 0x7f3b45ef75d2 in SwLanguageIterator::GetLanguage() const /sw/inc/txatritr.hxx:69:18
        >     #1 0x7f3b45ee2765 in SwTextNode::TransliterateText(utl::TransliterationWrapper&, int, int, SwUndoTransliterate*, bool) /sw/source/core/txtnode/txtedt.cxx:1980:32
        >     #2 0x7f3b429f1d40 in sw::DocumentContentOperationsManager::TransliterateText(SwPaM const&, utl::TransliterationWrapper&) /sw/source/core/doc/DocumentContentOperationsManager.cxx:3186:15
        >     #3 0x7f3b43a52777 in SwEditShell::TransliterateText(TransliterationFlags) /sw/source/core/edit/editsh.cxx:1076:51
        >     #4 0x7f3b49118c97 in SwTextShell::ExecRotateTransliteration(SfxRequest const&) /sw/source/uibase/shells/textsh.cxx:866:20
        >     #5 0x7f3b49118984 in SfxStubSwTextShellExecRotateTransliteration(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:3194:1
        >     #6 0x7f3b6529ff75 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9
        >     #7 0x7f3b652b5e85 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
        >     #8 0x7f3b65240e3b in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1061:22
        >     #9 0x7f3b656c2760 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:688:53
        >     #10 0x7f3b656c4ec1 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:266:16
        >     #11 0x7f3b193705a6 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:163:30
        >     #12 0x7f3b1936f482 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:120:16
        >     #13 0x7f3b19370e54 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
        >     #14 0x7f3b3810b5e9 in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:94:33
        >     #15 0x7f3b7245e5fd in testTdf157667::TestBody() /sw/qa/extras/uiwriter/uiwriter6.cxx:793:5
        
        Change-Id: I0e0545a134d86a333b971da83a66f58c5e70f601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159002
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-07  Noel Grandin  <noelgrandin@gmail.com>  [ee38eea6dd2ef487a4a6014ed2a36f46946648c7]

        simplify OutputDevice::ClipAndDrawGradientMetafile
        
        using a poly clip is better than using XOR, so make this the
        default.
        
        Change-Id: I48bb6b5d617b8b6dc82760277d72a50a2123ae0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158957
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [7842c935e056c243e87856b93714b0f38eddab2c]

        Simplify a bit
        
        XDocumentDigitalSignatures::isLocationTrusted would remove segments
        itself, as needed; this change not only simplifies this code, but
        also potentially allows to define not only trusted directories, but
        also individuals trusted files (if the UI would be adjusted).
        
        Change-Id: I0b0d60946d84a52479fcce5ce49d368cf53283fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159009
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-07  Miklos Vajna  <vmiklos@collabora.com>  [0bf60e32c0ac2bf79fad6c29c39c6f6a3f9ce8e8]

        tdf#99822 sw floattable: testcase for objects from different cells
        
        Fails with commit 435f1aadf7dd8087a8997924bedfccff0f496ba2 (tdf#99822 sw
        floattable: allow nomimal overlap of objects from different cells,
        2023-10-27) reverted.
        
        Change-Id: Ic90a2aa254a47804dc50eba8fc1daf0131e65a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159007
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bf927cb4513f8ef2a5205e98fbcf1ff02c344b4a]

        tdf#149935 - Hyperlink Target Dialog: remember last used position and size
        
        Change-Id: I87fdf78b6ec4963eb4450d937dd86209e03865a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158879
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-11-06  Stephan Bergmann  <sbergman@redhat.com>  [b21cab3f1784154cfaf7e5be71329ad6ff4f162a]

        Make CustomTarget_odk/build-examples_java more robust against localized envs
        
        At least on Linux, with a --with-lang=ALL build, `LANGUAGE=de make
        CustomTarget_odk/build-examples_java' would fail, as it would ask for license
        agreement in German rather than English (presumably because the code in
        getUILangFromEnvironment, i18nlangtag/source/isolang/inunx.cxx, inspects the
        LANGUAGE env var fist thing), so would expect a "ja" rather than the "yes" we
        feed into stdin.
        
        Change-Id: If285e4458e0706102a62f4e0094e5144575ccf7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158998
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-06  Stephan Bergmann  <sbergman@redhat.com>  [c9cedde7c0ba396dadfabbf644c6329e65afebf9]

        Adapt to various Clang 18 trunk enum rework
        
        <https://github.com/llvm/llvm-project/commit/a9070f22a29e28f7d6f83c24a8dd88f3a94969ae>
        "[clang][NFC] Refactor `CXXConstructExpr::ConstructionKind`",
        <https://github.com/llvm/llvm-project/commit/c23aaa410358b9f9c364ddaaeb6b2069b185a99b>
        "[clang][NFC] Refactor `CharacterLiteral::CharacterKind`",
        <https://github.com/llvm/llvm-project/commit/3e6ce58701a3a8463b53fb3fd2023c02b4e90554>
        "[clang][NFC] Refactor `StringLiteral::StringKind`",
        <https://github.com/llvm/llvm-project/commit/edd690b02e16e991393bf7f67631196942369aed>
        "[clang][NFC] Refactor `TagTypeKind` (#71160)"
        
        Change-Id: Ice802f6d662494781ad22fcf11ea5006de918254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158983
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-06  Patrick Luby  <plubius@neooffice.org>  [0c54c09aeb7e170512195c8f619ab2ded98c1ec5]

        tdf#155266 force flush after scrolling
        
        This is the second attempt to force a flush after scrolling.
        Commit 9c0803edd1f42b2d29115674795c7c674fea1a35 worked on
        Mac Silicon but not Mac Intel.
        
        So, instead of calling [NSApp currentEvent] to determine if
        scrolling has occurred, mark the AquaSalFrame whenever a
        scrollwheel or mouse drag event is dispatched so the frame
        will be flushed in the next AquaSalFrame::Flush() call.
        
        Change-Id: I2d0b99d2cd1167e92c7fd89bf53b2f30ab85a165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159003
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-11-06  Rene Engelhard  <rene@rene-engelhard.de>  [82a955498bf1e0d4ca7a582425bd30866ca7eb75]

        add --with-system-zxcvbn
        
        Change-Id: I9a90585d8eb498861a6ef4752ab85dcff8eeaab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158674
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2023-11-06  Michael Stahl  <michael.stahl@allotropia.de>  [061e48e607291c2992c81d3073a8c41387c56996]

        libcmis: HttpSession: add a callback that can be used to configure libcurl
        
        Change-Id: I6c2a3d1976f2256b21a3a306db7fbf04ca444c32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159000
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-06  Michael Stahl  <michael.stahl@allotropia.de>  [385aae6595fa467c73b6fdede5153d785c3ce138]

        libcmis: fix regression in HttpSession::initProtocols()
        
        Change-Id: I1d884945cc1f88a3abbf87c78227b56abf865c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158999
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-06  Miklos Vajna  <vmiklos@collabora.com>  [35925357f86e01612df28a092d71b6e216195636]

        sw floattable: make Insert Frame dialog async and mark it as a jsdialog
        
        - with this, once a LOK client dispatches .uno:InsertFrame, we don't
          open two dialogs (one tunelled, one jsdialog)
        
        - all the tabpages were already allowed as jsdialogs, the tabpages don't
          open any unwanted file picker (hyperlink browse button, area -> image
          -> import button)
        
        - switching to async means we can't work with the original SfxRequest
          (which is no longer there by the time the callback is invoked), but
          057eca05f23d9d15465e591bd0da671735d62d50 (sc: convert optimal
          width/height and normal width/height dialog to async, 2022-04-12) shows
          we can re-create the SfxRequest after the fact, do the same here
        
        - similar problem with SwFlyFrameAttrMgr, but looks like the
          SwFlyFrameAttrMgr before launching the dialog doesn't share state with
          the SwFlyFrameAttrMgr after the dialog is gone, so work with two
          instances here
        
        Change-Id: I97aad336b613d105f380012f8c79e92d89c583ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158978
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-06  Patrick Luby  <plubius@neooffice.org>  [55a0fba06086436260aca1f7367da376683afdaa]

        tdf#155266 revert commit 9c0803edd1f42b2d29115674795c7c674fea1a35
        
        While commit 9c0803edd1f42b2d29115674795c7c674fea1a35 fixed tdf#155266
        on Mac Silicon, it didn't fix that bug on Mac Intel.
        
        Change-Id: I4dc9eb3a5da319a0c8f58bcdea5abfc3e4ec4a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158997
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-11-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b4e7ebebd583a2a3856231aead66d72d3bc1cb46]

        vscode-ide-integration: add license-header template (snippet)
        
        Change-Id: Iea7837c87fd5803b225d9e18733a67c40fa915d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158887
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-11-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d6eb8b5637bd31d69e8e5cdd82bdd6682a68c1c0]

        Improve presentation options layout
        
        * Sort presentations options, put similiar options next to each other.
        * Move non-document option (Navigation bar) to "Display" area.
        
        Also improve wording a little bit for more clarity
        
        Change-Id: I18de6b95ea26033ef78709845db40e428a1d6c84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158831
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-06  Miklos Vajna  <vmiklos@collabora.com>  [da99d57e03765e275a9640c82fe502ff244d547f]

        svx: prefix members of SdrObjCustomShape
        
        See tdf#94879 for motivation.
        
        Change-Id: I589bba671fc7ad4282d18c35666ace80fff9ed77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158969
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-11-06  Julien Nabet  <serval2412@yahoo.fr>  [c37022ff57b6efe11869e9901e874cff80eca0c6]

        "SyntaxVersion" has been declared as "sal_Int16" in unomodel
        
        not "sal_uInt16"
        See "aModelPropertyInfoMap" var in starmath/source/unomodel.cxx
        
        It fixes this message when loading https://bugs.documentfoundation.org/attachment.cgi?id=55799
        warn:legacy.osl:19853:19853:xmloff/source/core/SettingsExportHelper.cxx:176: this type is not implemented now
        
        Change-Id: I18779b122555681f7544e64745c8074775e27277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158952
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [16737129e072a766ba58afddae4a992ad61cec6f]

        tdf#158002 - UI: Part 19 - Unify lockdown behavior of Options dialog
        
        for LanguageTool Page.
        
        Change-Id: Ib1255dd7a67eae7e9c1f2cf6da984ba614f3453a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158931
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-06  Szymon Kłos  <szymon.klos@collabora.com>  [019917b1451bc3f39ea9259df48e68cb098a0402]

        lok: notebookbar: reduce calls to SfxNotebookBar::IsActive
        
        - in LOK case toolbars in core doesn't make any difference
        - SfxNotebookBar::IsActive which reads config
          makes doc_setView slower, avoid it in LOK case then
        - it was used for hiding contextual toolbars
        - introduced in commit 9bc1ffa2153d2474b023e0860d3c9c68ee18727b
          tdf#125040 Make single mode toolbar context aware
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I63de48faf2f7e7f30f8b509455061ac20a788f8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158939
        Tested-by: Jenkins

2023-11-06  Szymon Kłos  <szymon.klos@collabora.com>  [b9159cf17ba61cb78c45f7223027f3e47126643b]

        lok: notebookbar: query SID_NOTEBOOKBAR only when requested to switch UI
        
        commit 5bd2931b57a6cb4ac1f39d7ddae874ac693cfab0
        tdf#102063 Notebookbar wont appear on launch
        
        introduced some Query hack to SfxDispatcher::Update_Impl what
        causes many updates on lots of different actions.
        It breaks multi-view state of notebookbar in LOK case,
        so don't do that. It should be reviewed for regular case too.
        
        Change-Id: I8f26bddc6cff991c56a1172893d83b90fb225acd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158937
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-11-06  Szymon Kłos  <szymon.klos@collabora.com>  [6bf428d354349995f7a20e6ce38a47c238911abe]

        lok: notebookbar: handle multiple sessions
        
        This fixes regression from commit db5a78c8ab1eae30e442151f07b0dc4dcd017550
        lok: notebookbar: don't recreate toolbars too often
        
        When we had 2 sessions with notebookbar and one of them switched
        to compact mode - other session's notebookbar didn't work.
        
        Before previous change we recreated notebookbar and its welded wrapper
        on every StateMethod call for LOK case. So when it become destroyed
        we made it working again. But now we need to introduce better management
        and not rely on single instence we get from SystemWindow.
        
        Also it's bad idea to rely 100% on SfxNotebookBar::IsActive in LOK
        case as when other view will turn notebookbar off, but QueryState
        will be trigerred in our session - we will think that it should be
        destroyed (it reads config state which is shared between views).
        So trust only "true" value (it happens after calling SID_TOOLBAR_MODE),
        but destroy notebookbar only after explicit call of
        SfxNotebookBar::CloseMethod. It seems to have good result when tested
        with multiple views in Online. Maybe we can track Notebookbar state
        per view later to make things simpler in LOK case.
        
        Change-Id: Ie739c6441ca05884b0ef20bff23751467706b562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158936
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-11-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e0334e1a77ec080b38952ea64b394c8652af851c]

        tdf#157788 Move "Show navigation panel" back to Presentation settings
        
        Instead of hiding it in the general options dialog.
        
        As written in https://bugs.documentfoundation.org/show_bug.cgi?id=157788#c4
        "The options in Slide Show Settings should all apply to the workstation";
        the options which are saved per user/workstation and not per document, should not be moved
        away from that dialog.
        Instead the other options should also be saved per user/workstation.
        
        Change-Id: I720c949f08877abb8ef8f94dbcfa6c85f349631d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158808
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [496f324b8f038d81fe7a14eb424680e9acab1a3c]

        tdf#135089 Move Presenter console settings to Slide Show settings
        
        Change-Id: I0aeb180ee132bff359d46d963985196f5a24610f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158798
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [c45b45acef6f6657b1d95056830fee7c5f7d29c4]

        bin: remove no longer needed script
        
        After 8c39af455c4dee53c6f3c918b0497f80a4fb0f21
        "uitest oneprocess mode: default to this and clean up one test"
        
        Change-Id: I3da187055cc8ac239d6a4592f3050440630e051c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158654
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [07b602edbcffe50dc8a81a8a1d79a2a99bbc3e7d]

        uitest: Clean up redundant usage of gb_UITest_use_oneprocess
        
        After 8c39af455c4dee53c6f3c918b0497f80a4fb0f21
        "uitest oneprocess mode: default to this and clean up one test"
        
        Change-Id: Ib6e0fc3de2997beebc650253ae3ea19a3314ae09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158844
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-11-06  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [806656ce4b20aa5b096fe3f072060f6302117afc]

        tdf#157518: vcl: add native macOS rendering support for LevelBar control
        
        Uses NSLevelIndicator to render LevelBar control on macOS.
        Closely follows the existing implementation for ControlType::Progress
        
        Change-Id: Ibd38e172b8b6297e6322cfe9d5a1b0a6ef0f0656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158504
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-06  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [b1e24664de424a626f78b9fe002bf4d47c8907d5]

        tdf#157518: add password policy and strength meter to save with password dialog
        
        Introduces new configuration options PasswordPolicy and
        PasswordPolicyErrorMessage.
        
        PasswordPolicy takes a regular expression. When set, it only
        accepts passwords that match that regular expression.
        
        PasswordPolicyErrorMessage is the label displayed when the
        password does not meet the PasswordPolicy.
        In the ideal case, it should contain an explainer of the
        PasswordPolicy, so the user is aware of the requirements.
        
        Save with password dialog had maximum password length enforcing
        bits depending on the requirements of the saved file format.
        These are still applicable in combination with the password
        policy.
        
        Also introduces a visual password meter under the password
        entries. If the password policy isn't satisfied the password
        strength meter is capped at 70%.
        
        The entropy bits to password quality is taken as a linear range.
        Where the range of [0, 112] entropy bits is mapped to percentage
        [0, 100]. Entropy bits ≥ 112 are mapped to 100% since, according
        to KeePass' info page, ≥ 112 entropy bits correspond to a strong
        password: <https://keepass.info/help/kb/pw_quality_est.html>
        
        Change-Id: I2e70adacf271916661219f702dfc217292a1b59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158453
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-11-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [383f666bcad27b2fbea6ac13a42cafd6f035fc5c]

        tdf#43157 vcl: remove DBG_ASSERT() from BreakLinesWithIterator()
        
        Change-Id: I2ab54966c8a8b5e5a15f78481330365725b6ef30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158073
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [183973ece62c0eefbd841dcf99f7fb8716f0fca1]

        vcl: flatten TextLayoutHelper::GetNewsEllipsisString()
        
        Change-Id: Ie94ce7c75ab96b8f7186f9f0c455dfa3a9f1683f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158072
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [5886a6faad298cb42fdb4ceb52120bfc569c6e14]

        vcl: split out functions from TextLayoutCommon::GetEllipsisString()
        
        Change-Id: Ifced331b65e27a02d9a3b3e220e22c279c6fc496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158071
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-11-06  Gabor Kelemen  <kelemeng@ubuntu.com>  [026be6f62f183f14b9c0bf2e50cde9ac69856f53]

        tdf#146619 Recheck include/t* with IWYU
        
        Change-Id: I005257e458351285b1b35ffe49c8b42834a6db68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156990
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-05  Stephan Bergmann  <sbergman@redhat.com>  [5fb20ede2fb47ef91d70b49288129adf8015f34b]

        loplugin:ostr: Warn about literals that could be string_view
        
        ...inspired by d4f4a401861e7c908b6ab7f72563d5ab911edcf0 "This function takes a
        string view - no need in OUString literal", but this found no further cases
        
        Change-Id: I1429950afdb6fff8ed1d28f5fbb4c445fb6bfb12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158954
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-05  Bogdan B  <buzea.bogdan@libreoffice.org>  [1ad81f7e69b545340e340b54f9c9dd387b17cce0]

        tdf#158067 Replace OUStringLiteral in accdoc
        
        Change-Id: I88bfdf41137adf34ca5af4e73cf6ca487d8fe5ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158899
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [389def871853c885289627452f40b3ae0a8dabc8]

        reprobuild: don't include build machine setup in binaries
        
        The configure line can leak data from the building machine (path
        names, level of parallelism etc), which leads to non-reproducible
        build results.
        
        Change-Id: I042afc3d7bad19e8e274147be2a9eb0abcf5436e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158871
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [d2b0c48ca0f0ba8ef3049ebcd5f93ae420c22c46]

        reprobuild: don't use any build-time dependent values
        
        Even taking the current year from the build system makes a build
        non-reproducible (if you run it again the next year).
        
        Change-Id: I4a2ef0fe997c20d1c8ec954378f46adb5aad04df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158870
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [1d939b782235a62c965a4c8309869796b5838acf]

        reprobuild: don't write nondeterministic textencoding
        
        No need to write this legacy int16, that we ignore on read anyway.
        
        Change-Id: I5ee071aa0562b8e2718a1a83dffc543c9a104360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158942
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [b65f295698d3c09a1d18336cb17ac29487266400]

        tdf#158068: an example of "abc" -> u"abc"_ustr conversion
        
        Change-Id: I1225548ebc313cac98c4b924a8fb53f53bada76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158946
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [eae5559af6bbf7727431fcb44e79492adbd59c41]

        tdf#158067: an example of OUStringLiteral -> operator u""_ustr replacement
        
        Change-Id: I0a15d1d30ee59d8f574a5a9c79ab11e316dbe76c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158945
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [24e1d6dbd27fa6c37723b55bbab5f5b5cce279f2]

        Fix typo
        
        Change-Id: Ie41ca6c56bf44b04bd2d65b6cb64594d66295f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158951
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0053dfbabd8b6711ea7e9354e5792048931daf7c]

        Fix typo
        
        Change-Id: I84186bee245a95a74e92c974ca94bb81c31ee1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158950
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-05  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [d0d94ec8b82baaba185e3629bcc7ba44bc559c35]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d154315b75b46b8bf26d4d2b3465064da273b18a
          - Updated the English dictionaries: GB
            
            Change-Id: I9950273688ccb0d9743d168b1a928e91942c38a3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/158833
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2023-11-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [edf6c155b0b22cbff2d255796c0541b644a5f245]

        limit parallelism during msi packaging stage to avoid cscript failures
        
        with high parallelism there's a high risk of running into random
        failures when calling WiLangId.vbs via cscript.
        
        The limiter doesn't use make's jobserver since it is too easy to
        deadlock the build since all jobs are started at once, consuming all
        slots, but in addition all wait for an additional slot that never is
        made available because all jobs are blocked waiting....
        All jobs being started at once and all jobs getting started from that
        point on getting put under the limiter's control makes this simple
        approach with separate grab/release calls possible. If they were spread
        out the semaphore wouldn't be available (gets closed/removed as soon as
        nothing waits for it anymore)
        
        Change-Id: I345f2904a1d7e8989720722415fb51282ab3b05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158886
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-11-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2486803ee26c10751ff92e46c53cc03ad0a1218d]

        move macOS specific entitlements file templates to sysui/desktop/macosx
        
        generated location is kept to not have further changes in existing
        scripts using those files.
        
        Change-Id: Ia14864bd6f9c69e2c77d39806e733f50155d12b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158791
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [cfd7cffb00f9f4ee934006a706184fefc8cb8d9d]

        tdf#158014 Skia adds filled white areas in .svg when exporting to PDF
        
        So my strategy here is to assume that ProcessAndBlurAlphaMask
        was doing the right thing before
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        but the subsequent naiving changing of its logic undermines it
        because of some subtle interaction.
        
        So take the brute force approach of reverting most of the code
        to its prior state (i.e. working in the transparency domain),
        and doing an Invert() before and after the original code.
        
        This seems to fix all of the test files I have on hand
        for this situation for both Skia and non-Skia cases.
        
        Change-Id: If4c4d4c5351a4ec55897bed96b57d28eda88f5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158793
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [2b84c860b591457da4c995435f9ca7ce5c7b3d23]

        shared.hxx is unused
        
        Change-Id: I35ca5471a0f2279a32a5150d6a09d1cd9a3d4278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158941
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [2bf894e91adf8783baaabc2203f7e97c4b8f3ca7]

        External data must be checked when parsed
        
        Change-Id: I8bc5afb29fe22a4b06462a7c61b689c88c41003f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158938
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e14a55c9aa834c160e9a5c70f0de3b0635cde66f]

        LOK: Simplify a bit, and use more compile-time knowledge
        
        Bring some C++20 goodness to LOK code: avoid lots of small memory
        allocations when constructing OUString from ASCII char arrays;
        use string lengths known at compile and run time; use safer and
        cleaner syntax.
        
        Change-Id: Ia59ed3c8d8ce521880bb8d70b69a64b2d3e73c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158927
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [07590ff83e03077cf0d755f698b5b6bb36bb54d2]

        tdf#158001 - UI: Part 18 - Unify lockdown behavior of Options dialog
        
        for Languages Page.
        
        Change-Id: I3f4cf27980dd6d06da13f554feaca192ebd0b671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158882
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [918f2663e8668ef4f15157e50d6de402a2b30eda]

        resave with newer glade version
        
        Change-Id: I8c11067d813c2331e5f9ceae1cb780c73b45e0f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158881
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-04  Stephan Bergmann  <sbergman@redhat.com>  [5323c18753504ae99e271f98052b13271343de6f]

        Adapt to Clang 18 trunk Linkage rework
        
        <https://github.com/llvm/llvm-project/commit/8775947633bf189e1847707932b1015f04640ea0>
        "[clang][NFC] Refactor clang::Linkage"
        
        Change-Id: I35e3a3c7e3de29e4f3b9ee8dfc34e39ba2aa1c70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158919
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bfbf0b0991c69a66b5a511acdd2f56aaf834ec91]

        Fix typo
        
        Change-Id: I2fa6ef12d5035aaa21ab464a105085f38ce43423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158914
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eded77b8e0439d6bd74935ae97748653d5863974]

        Fix typo
        
        Change-Id: I064aa3c54650904671a312eadbe8e77b26ae141a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158913
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [4acd25cced4c22dd4dd4f718eb5a12f870fb93a9]

        tdf#157588 fix extended_tip
        
        "untrusted locations" -> "untrusted file locations"
        
        Change-Id: I31810c8dc572086aa1378800cc2551bce2933a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158719
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-04  EMartinGube  <martin.gube@web.de>  [d7a5e7643f3540b1490c1e2f1a91ff86c721d7b6]

        tdf#114441 Convert use of sal_uLong to better integer types
        
        Return type of GetColumnFormat() is changed to sal_uInt32. All the
        values from the function calls inside GetCloumnFormat() which were
        involved in the return value seem to be positive right now.
        
        Change-Id: Id19b2982d8372e10fee5fc0fd4233576076ec3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155680
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-03  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [e963da8716a9e418ff220f0c0b5299dcaa82f53a]

        tdf#114441 Convert sal_uLong to better data types
        
        The function getLength() returns a value as sal_Int32, which is then
        assigned to the variable nLinks.
        
        Change-Id: I44d626e2a26e3d9eb15b0884500f0dfddff12e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157755
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-11-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [11ebdfef16501c6d35c3e3d0d62507f706557c71]

        add some protocols that don't make sense as floating frame targets
        
        Change-Id: Id900a5eef248731d1184c1df501a2cf7a2de7eb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158910
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-03  Patrick Luby  <plubius@neooffice.org>  [9c0803edd1f42b2d29115674795c7c674fea1a35]

        tdf#155266 flush when scrolling or dragging
        
        Delaying flushing until the dispatch level returns to zero causes
        scrolling via the scrollwheel or mouse drag to appear laggy and
        jerky.
        
        Change-Id: Ib70e7766435baa765dd0d1d704ba2fac87f7fccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158853
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-11-03  Patrick Luby  <plubius@neooffice.org>  [e4821ce3e0eb814f8942b9451183b4589e901ec3]

        tdf#158014 make image immutable after using Skia to invert
        
        I can't explain why inverting using Skia causes this bug on
        macOS but not other platforms. My guess is that Skia on macOS
        is sharing some data when different SkiaSalBitmap instances
        are created from the same OutputDevice. So, mark this
        SkiaSalBitmap instance's image as immutable so that successive
        inversions are done with buffered bitmap data instead of Skia.
        
        Change-Id: I8acf90561c48edba14a5f43d16f375f15f25820c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158880
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2023-11-03  Patrick Luby  <plubius@neooffice.org>  [2a5dac6d75b346a77652dec05cafa6562177d40f]

        tdf#158047 allow the tdf#157635 fix for palettes with 64 entries
        
        Change-Id: Ib4e4deb5f7e332a7ef3a9231e993231068c21c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-11-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [af9b546cf5eef3df417e225c8ad87283ab51e1bb]

        avoid the neeed to escape url passed to gstreamer
        
        Change-Id: I13d0cee911a3c9af99b494dde16b8d51f78d954a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-03  Stephan Bergmann  <sbergman@redhat.com>  [cef555e9a43b2cf1f46763b768973f89c5c1b053]

        Make ExternalReferenceUriTranslator more robust against broken UTF-8
        
        <https://lists.freedesktop.org/archives/libreoffice/2023-November/091151.html>
        "CppunitTest_stoc_uriproc failed on Windows" reports that
        translateToExternal("file:///abc/%feef") produces an empty string (indicating
        failure) instead of "file:///abc/%FEef" (as expected in
        stoc/test/uriproc/test_uriproc.cxx) when osl_getThreadTextEncoding() is Shift
        JIS.
        
        This was due to how the call to rtl::Uri::encode in
        Translator::translateToExternal (in
        stoc/source/uriproc/ExternalUriReferenceTranslator.cxx) behaved:  It internally
        interpreted its input "%FE" as the single-byte Shift JIS character 0xFE.  Which
        gets mapped to U+2122 as an extension (see "APPLE additions over SJIS, we
        convert this like Apple, because I think, this gives better result, then [sic]
        we take a replacement char" in sal/textenc/tcvtjp6.tab) in readUcs4, but which
        in turn doesn't get mapped back to any Shift JIS character in writeEscapeChar.
        
        Translator::translateToExternal is the only user of
        rtl_UriEncodeStrictKeepEscapes, as introduced by
        6ff5d3341dbc5df3f0cb5368ccb0e1089338916c "INTEGRATION: CWS c07v013_SRC680
        (1.4.40); FILE MERGED: 2007/06/21 13:00:56 sb 1.4.40.1: #b6550116# Made
        XExternalUriReferenceTranslator.translateToExternal more robust when the input
        URL contains spurious non--UTF-8 octets like %FE (which are now copied verbatim,
        instead of signalling error)."
        
        To make the claim true that such "spurious non--UTF-8 octets like %FE" are
        always "copied verbatim", regardless of text encoding being used, repurpose
        rtl_UriEncodeStrictKeepEscapes to always treat any escape sequences that are
        present as (potentially broken) UTF-8.
        
        Change-Id: I0fa0b14d3e3d44e4b5514e1b73c84c407a947ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158888
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1e95b89f8f9910c9f4b3b918aa83cf2185d9c11b]

        escape url passed to gstreamer
        
        Change-Id: I3c93ee34800cc8563370f75ef3ef6f8a9220e6ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158884
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b73cde1acb09d21cc6c74f88992f7ee0f871eba4]

        Fix typo
        
        Change-Id: Ida31b30c64c8ba2be61e6f4a408e1346df48d1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158875
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [afd635082e4d06832877f70b7da9b187a6b21fbc]

        speed up hunspell inner loop
        
        which calls into the kernel to get elapsed time, instead of using the
        VDSO-based CLOCK_MONOTONIC (or at least, the C++ equivalent of that)
        , which is much faster
        
        Change-Id: I99d958b0ab64b75360db4e0c8a951c37af2505bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158809
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [233495f76c45d2425052fb3685c04f448e85466b]

        reduce jsdialog formulabar updates from 6 to 3 per keystroke
        
        SetTextString will emit one, so skip doing that if we are going to be
        followed by another emission that will override the earlier one.
        
        Change-Id: I82d804d57cd9647631bd338a3a0c4dd11989b9fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-03  Michael Stahl  <michael.stahl@allotropia.de>  [822a0c4fcd4607d5247b828c69728a510684a442]

        tdf#157028 vcl: PDF export: inline OBJR dictionaries
        
        There seems to be no reason why SE child OBJR dictionaries are separate
        objects, they could just be inline.
        
        Change-Id: I9e4fcdf56d9b7454325f9d3ef7ba55bdc090f948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158838
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-11-03  Szymon Kłos  <szymon.klos@collabora.com>  [3d15de525534197960e9a9c64eba3ad2153aa113]

        lok: notebookbar: don't recreate toolbars too often
        
        commit 	004512d87ab70587d95a708116a5c2f4b870565c
        notebookbar: allow to create multiple instances for online
        
        Changed SfxNotebookBar::StateMethod so in LOK case it always
        enter to the code block which is meant to be used for
        creating or reloading notebookbar. Change that so we check
        if notebookbar was initialized for given view already.
        
        Change-Id: Icfa1e572769043509479b7b98d055120ac3d1f74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-11-03  Venetia Furtado  <venetiarosita@gmail.com>  [4af07053517ba3526d4050ffc29993a65b54352b]

        tdf#140314:Use hub.libreoffice.org URL with params in Extensions
        
        Change-Id: Iccf76581de8dc44fe80aa818e9fb81c2cdf0967b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155571
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-11-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f813d7138dea193b31988cc3097ed560b4f2ce98]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bbdd4dfc5daee45a4b3d38a7acf698a73768173a
          - tdf#155876 UI cmds Calc-Format menu (19)
            
            + refactoring of Number formats
            
            Change-Id: Iaeb8114f6080652cd9f78ec8b2a1425056b5560d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158874
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [08ac4318176074f046ed3422d9dd7ace4591023e]

        tdf#158000 - UI: Part 17 - Unify lockdown behavior of Options dialog
        
        for Chart Page.
        
        Change-Id: I374a0dc8ff43be490e64a7173963e04005aec7e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158852
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7eb0e13c6547f00bc139d817ef53350c99e3eb2e]

        resave with newer glade version
        
        Change-Id: Ib6c6b3d5619a5f1e30b7d4f59184ec232224a7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158851
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d7d89a47e9e50254469d957b86f0e16bec22fe62]

        tdf#157862 - UI: Part 16 - Unify lockdown behavior of Options dialog
        
        for Load/Save - HTML Page.
        
        Change-Id: I8e9599c25eba62f7b82d8e3f56de031a1c6366fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158849
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [349fa2b19de296bdc19206f6d4b9bc78a194a7f6]

        resave with newer glade version
        
        Change-Id: I08920f6d2f19a689d71cd1045f9262bd165d4677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158848
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6f12739b6201948b8ccf8f162c999e42714539ba]

        tdf#157861 - UI: Part 15 - Unify lockdown behavior of Options dialog
        
        for Load/Save - MS Office Page.
        
        Change-Id: Ifd576e5030e49bef3c73f55f4d3f23eea34a45f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158837
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [61351fcc5f111da87a3def813bb0cf769a83e07f]

        resave with latest glade
        
        Change-Id: I1a890cfbbd04262c1baf9d0dfc4b09a9498744d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158836
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-03  Stephan Bergmann  <sbergman@redhat.com>  [d614b08b7ff399bb9275691f811b01483ae03c5b]

        Suppress loplugin:redundantfcast also around C++20 CXXParenListInitExpr
        
        ...which is used by
        <https://github.com/llvm/llvm-project/commit/95a4c0c83554c025ef709a6805e67233d0dedba0>
        "[clang] Reland parenthesized aggregate init patches" for the
        __cpp_aggregate_paren_init feature implemented since Clang 16, and which had
        caused bogus warnings in patch set 1 of
        <https://gerrit.libreoffice.org/c/core/+/158838/1> "tdf#157028 vcl: PDF export:
        inline OBJR dictionaries"
        
        Change-Id: Id4118ce8d53902388ca3a80ad03f12b59e3a35e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158842
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-03  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [47e06b18ede70f3496bc7da97e1761fe1dbf629c]

        tdf#157664 Drop operator !=, where respective operator == is defined
        
        Change-Id: I88b25dd676fc57303978e3d5e875af129240b676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157762
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-11-03  Michael Weghorn  <m.weghorn@posteo.de>  [a2e0b39b62129d9dbae438ec6b12fca210bbcbb5]

        sw a11y: No longer report underline for misspelling
        
        No longer report a red wavy underline for misspelled
        words in Writer.
        
        The underline isn't really a character/text attribute, since
        it's not part of the actual formatting of the text, but is
        just shown visually.
        
        Each platform a11y API has a better way to explicitly
        report misspelling.
        
            commit ec2e02cfa41510c3d30b118cbf7595c84a046d03
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Oct 17 14:36:58 2023 +0200
        
                tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attr
        
        and
        
            commit 2bf88c172c9c9d159344b95fb96073f4891a6c30
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 18 13:44:42 2023 +0200
        
                tdf#157696 wina11y: Switch from custom to IA2 text attributes
        
        added the implementation for Windows and
        the Qt-based VCL plugins on Linux.
        
        On macOS (`NSAccessibilityMarkedMisspelledTextAttribute`/
        `NSAccessibilityMisspelledTextAttribute`) and for gtk3/ATK,
        the corresponding attributes were already used before.
        
        Therefore, reporting an underline as a workaround is no
        longer needed.
        
        Orca on Linux, NVDA on Windows (with [1] in place)
        and CrossOver on macOS all make use of the specific
        character attribute to announce spelling errors, not
        the underline. If any assistive technology should stop
        reporting spelling errors due to this change, it should
        be fixed to handle the proper text attribute as well.
        
        After switching to text attributes according to the
        IAccessible2 specification on Windows (i.e. with,
        the above-mentioned commits and the NVDA commit
        to switch to IAccessible2 text attributes for LO [1]),
        NVDA was starting to announce not only that a word is
        misspelled, but an underline in addition, which is
        no more the case now that the underlining is no more
        reported.
        
        [1] https://github.com/nvaccess/nvda/commit/de4e8814f39ab6ae9fbc5330b007494ef6888cd3
        
        Change-Id: Ifa29e0080a4a039c5a119dd0debe5e924fa546ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-03  Michael Weghorn  <m.weghorn@posteo.de>  [e6d34f00a5c408d64168d84c718ae5071feea4fd]

        macOS a11y: Drop obsolete TODO to implement spelling error attr
        
        Handling for `NSAccessibilityMisspelledTextAttribute` and the newer
        `NSAccessibilityMarkedMisspelledTextAttribute` [1] has been added in
        
            commit db0fa92637a1b2edf26da9917c9dce050ebc8a78
            Author: Boris Dušek <me@dusek.me>
            Date:   Sun Aug 11 16:37:48 2013 +0200
        
                fdo#67980 - VoiceOver does not inform about misspelled text
        
        and VoiceOver announces misspelled Writer text as such, so drop the
        obsolete TODO.
        
        [1] https://developer.apple.com/documentation/appkit/nsaccessibilitymarkedmisspelledtextattribute
        
        Change-Id: Id8ae1ee660e87c06ac7f559b5cdf1b31e22aef90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158840
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-03  Tobias Kokolakis  <kokolakis@mail.de>  [fa7ae4638431bf4f4d40d16ab0017ec59e233039]

        tdf#156478 Remove unused default values for MediaBox and UserUnit
        
        Change-Id: Ica75be2fa238fdf2a40e274f1175710923b281e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156468
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [8aec57f54b3c6686868a44855c0a0bff339f4835]

        gbuildtojson: announce every target
        
        vs-ide-integration takes tens of minutes on my system; and most
        of the time, it didn't output anything to the terminal. Every
        target handled by gbuildtojson takes ~2 s; with more than 870
        targets, it makes sense to show the progress to avoid making an
        impression of a hang.
        
        The "GBJ" abbreviation (for "gbuildtojson") was not used in the
        output before.
        
        Change-Id: I71ab3ae59d1034f47140aad0dab6ed170140acb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158846
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-03  Justin Luth  <jluth@mail.com>  [a09b59cdbde2ab92bbbb6737337b74a7a62b17f1]

        NFC related tdf#158031 editeng: flatten and simplify the code
        
        No Functional Change intended.
        Just some slight optimizing that leads to some nice flattening.
        
        Change-Id: I46d20a56821f218973c728f51575b104e6020500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158854
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-03  Jim Raykowski  <raykowj@gmail.com>  [167fb166e4097c4a855c08a70cdf70c19d4d87ac]

        tdf#157801 Fix direct formatting is applied after pressing OK in the
        
        Character properties dialog when the Highlighting tab Color page is
        open and the color has not been changed
        
        This is noticeable when character highlighting direct formatting is
        already at paragraph level.
        
        The expected result of opening the properties dialog, and immediately
        pressing OK without changing anything (or alternatively, after
        changing something there and then pressing Reset then OK), is no
        changes in applied properties at all.
        
        Inspiration for rework of the background tab page. With this patch
        XATTR_FILL items need not be included in the InAttrs set, for
        example, as part of this patch, the XATTR_FILLSTYLE, XATTR_FILLCOLOR
        range is removed from the sw_CharDialog core set.
        
        Change-Id: Ic2de53a29579c33820fc381d354a4afebe048a5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158100
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-03  László Németh  <nemeth@numbertext.org>  [3e266d5902439f34bc5559d6871f8c9fd6e579bb]

        tdf#158039 sw track changes: fix cycle case of selected sentences
        
        Previous tracked changes of cycle case weren't removed, if
        the selection doesn't end in a tracked change, i.e. sentences
        with punctuation, or selections end in a capitalized word etc.
        
        Fix also lost selection of multiple selected nodes.
        
        Follow up to commit 4cf8de89bad9143a5b2dd3d6351080bf62b76029
        "tdf#157667 sw track changes: fix cycle case on multiple words",
        commit dc748d7dbd114fbf663752258dbaf003af2926c3
        "tdf#141198 sw: fix cycle case with change tracking" and
        commit 79435eb55ef226fb0e3507aabdc2f8af062680f6
        "tdf#157988 sw track changes: fix cycle case on a selected word".
        
        Change-Id: I24476c359200a25ca9bcd467c33b0ebeb1afb037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158804
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-11-03  Jim Raykowski  <raykowj@gmail.com>  [d2676b3e4b43aa4e17007bacdd0d98573ebd1ad2]

        SwNavigator: Improve field content sorting
        
        Shave some time off sorting field content entries for documents with
        large number of fields by eliminating a second sort and the loop used
        to determine if a second sort is done because a field is found in a
        frame. Also corrects ordering of fields in nested frames which prior
        to this patch are placed at the beginning of the field content
        entries.
        
        Change-Id: I5fbd67b6fb0ac1ef49a5df7721bb209d4cba4013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158606
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2f2803a77af3bfdab979bd44ce61866e6985d172]

        Related: tdf#157939 put CppunitTest_svgio under non_application_font_use:abort
        
        Change-Id: Ib48e8045ad739b6f6fe98ab00cd609b54d4c3113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6fbd5a72c83a6d50a650fe9ae5f5ed0e54dbdd59]

        tdf#157939 drop duplicates from the FontConfig Set
        
        when we drop them from our own font list, that way we don't get
        suggestions for glyph fallback which we can't satisfy
        
        Also prefer our application fonts to system fonts when they
        share the same version number where they should be the same, but
        more than once we have a system-side font with oddities.
        
        Change-Id: I90bd3311e0f37bacd60d20e1c1a6769b551b8b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158841
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [142e7d985f2f6cdb1e37dc0540d77e1fbd6f1bfd]

        this should never be null, so we can use a reference
        
        Change-Id: I682e30cfb4fd63a4f906bfb875cafdf77ae9cfe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158805
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b50681f8da6fbc57db07d488c6e76e33fcd59147]

        crash seen in EditView::GetTransferable in calc
        
        if (pColor->getComplexColor().getType() == model::ColorType::Unused)
        
        (gdb) print pColor
        $10 = <optimized out>
        
        but:
        
        (gdb) print *pSet
        $12 = {_vptr.SfxItemSet = 0x7f7cd56f3198 <vtable for SfxItemSet+16>, m_pPool = 0x31e7d880, m_pParent = 0x0, m_ppItems = 0x33ecece0, m_pWhichRanges = {
            m_pairs = 0x7f7cd47b2480 <svl::Items_t<(unsigned short)4008, (unsigned short)4064>::value>, m_size = 1, m_bOwnRanges = false}, m_nCount = 1, m_bItemsFixed = false}
        
        (gdb) print *(pSet->m_ppItems)
        $11 = (const SfxPoolItem *) 0x0
        
        so, apparent null deref of pColor
        
         #0  SvxUnoTextRangeBase::_getOnePropertyStates (pSet=0x7ffe47b3ded0, pMap=0x7f7cd5a50600 <ImplGetSvxTextPortionPropertyMap()::aSvxTextPortionPropertyMap+384>,
             rState=@0x38ae2d4c: com::sun::star::beans::PropertyState::PropertyState_DIRECT_VALUE)
             at editeng/source/uno/unotext.cxx:1179
         #1  0x00007f7cd1e6f5be in SvxUnoTextRangeBase::_getPropertyStates (this=0x3543bc00, PropertyName=..., nPara=nPara@entry=-1)
             at editeng/source/uno/unotext.cxx:1057
         #2  0x00007f7cd1e6fa12 in SvxUnoTextRangeBase::getPropertyStates (this=<optimized out>, aPropertyName=...)
             at editeng/source/uno/unotext.cxx:1031
         #3  0x00007f7cd41e723b in (anonymous namespace)::FilterPropertiesInfo_Impl::FillPropertyStateArray (this=this@entry=0x32e94820,
             rPropStates=std::vector of length 0, capacity 0, rPropSet=..., rPropMapper=..., bDefault=bDefault@entry=false, pOnlyTheseProps=pOnlyTheseProps@entry=0x0)
             at xmloff/source/style/xmlexppr.cxx:327
         #4  0x00007f7cd41e9230 in SvXMLExportPropertyMapper::Filter_ (this=this@entry=0x34dc72a0, rExport=..., xPropSet=..., bDefault=bDefault@entry=false,
             bEnableFoFontFamily=bEnableFoFontFamily@entry=false, pOnlyTheseProps=0x0)
             at xmloff/source/style/xmlexppr.cxx:651
         #5  0x00007f7cd41ea026 in SvXMLExportPropertyMapper::Filter (this=this@entry=0x34dc72a0, rExport=..., rPropSet=..., bEnableFoFontFamily=bEnableFoFontFamily@entry=false,
             pOnlyTheseProps=pOnlyTheseProps@entry=0x0) at xmloff/source/style/xmlexppr.cxx:526
         #6  0x00007f7cd42dbbcd in XMLTextParagraphExport::Add (this=this@entry=0x37110830, nFamily=nFamily@entry=XmlStyleFamily::TEXT_TEXT, rPropSet=..., aAddStates=...,
             bDontSeek=bDontSeek@entry=false) at xmloff/source/text/txtparae.cxx:685
         #7  0x00007f7cd42dd09f in XMLTextParagraphExport::exportTextRange (this=this@entry=0x37110830, rTextRange=..., bAutoStyles=bAutoStyles@entry=true,
             rPrevCharIsSpace=@0x7ffe47b3eef0: true, openFieldMark=@0x7ffe47b3ec34: XMLTextParagraphExport::NONE)
             at xmloff/source/text/txtparae.cxx:3731
         #8  0x00007f7cd42e57df in XMLTextParagraphExport::exportTextRangeEnumeration (this=this@entry=0x37110830, rTextEnum=..., bAutoStyles=bAutoStyles@entry=true,
             bIsProgress=bIsProgress@entry=false, rPrevCharIsSpace=@0x7ffe47b3eef0: true)
             at xmloff/source/text/txtparae.cxx:2438
         #9  0x00007f7cd42ea746 in XMLTextParagraphExport::exportParagraph (this=this@entry=0x37110830, rTextContent=..., bAutoStyles=bAutoStyles@entry=true,
             bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, rPropSetHelper=..., eExtensionNS=<optimized out>)
             at xmloff/source/text/txtparae.cxx:2378
         #10 0x00007f7cd42e0634 in XMLTextParagraphExport::exportTextContentEnumeration (this=this@entry=0x37110830, rContEnum=..., bAutoStyles=bAutoStyles@entry=true,
             rBaseSection=..., bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, pRangePropSet=<optimized out>, eExtensionNS=<optimized out>)
             at xmloff/source/text/txtparae.cxx:2008
         #11 0x00007f7cd42e113a in XMLTextParagraphExport::exportText (this=this@entry=0x37110830, rText=..., bAutoStyles=bAutoStyles@entry=true,
             bIsProgress=bIsProgress@entry=false, bExportParagraph=bExportParagraph@entry=true, eExtensionNS=eExtensionNS@entry=TextPNS::ODF)
             at xmloff/source/text/txtparae.cxx:1762
         #12 0x00007f7cd1e78669 in XMLTextParagraphExport::collectTextAutoStyles (bExportParagraph=true, bIsProgress=false, rText=..., this=<optimized out>)
             at include/xmloff/txtparae.hxx:459
         #13 (anonymous namespace)::SvxXMLTextExportComponent::ExportAutoStyles_ (this=0x7f7cb4522930)
             at editeng/source/xml/xmltxtexp.cxx:341
         #14 0x00007f7cd406121c in SvXMLExport::ImplExportAutoStyles (this=this@entry=0x7f7cb4522930)
             at xmloff/source/core/xmlexp.cxx:1127
         #15 0x00007f7cd40645f5 in SvXMLExport::exportDoc (this=0x7f7cb4522930, eClass=<optimized out>)
             at xmloff/source/core/xmlexp.cxx:1380
         #16 0x00007f7cd1e78d64 in SvxWriteXML (rEditEngine=..., rStream=..., rSel=...)
             at editeng/source/xml/xmltxtexp.cxx:321
         #17 0x00007f7cd1da1d0c in ImpEditEngine::WriteXML (this=this@entry=0x34f87990, rOutput=..., rSel=...)
             at editeng/source/editeng/impedit4.cxx:270
         #18 0x00007f7cd1d88881 in ImpEditEngine::CreateTransferable (this=0x34f87990, rSelection=...)
             at editeng/source/editeng/impedit2.cxx:3843
         #19 0x00007f7cd1d4c091 in EditEngine::CreateTransferable (this=<optimized out>, rSelection=...)
             at editeng/source/editeng/editeng.cxx:816
         #20 0x00007f7cd1d5c91a in EditView::GetTransferable (this=0x33eb8190)
             at editeng/source/editeng/editview.cxx:662
         #21 0x00007f7cc2c03eac in ScModelObj::getSelection (this=<optimized out>)
            at sc/source/ui/unoobj/docuno.cxx:904
        
        Change-Id: Idb8cbbebe02188678f9c1b17e80cf89feffa9de8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158803
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d392b24623a46058d0fa35e445a4ceae519c738f]

        add a fast path for the 1999-12-31 date in calendar conversion
        
        seen in:
        
        https: //user-images.githubusercontent.com/833656/279971758-ef3d86b1-23ea-4e57-ad15-1f9b12df6bdd.svg
        Change-Id: I76f5e83860ea49e52099ece670e7c259fd89e666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158830
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [86ab194c621aa48b9718815e426fe4d5560ddbb0]

        Clarify when the logo will be shown
        
        Change-Id: Ie6ac8530b3351a2c9899c33932ba6ab70b246cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158797
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [15bac35f442312d7f6d12f84c7051b8678236ee2]

        Save with latest glade
        
        Change-Id: Ibaa2851fede2ecd78b86388e151b4484e1ff60db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158796
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-02  Michael Weghorn  <m.weghorn@posteo.de>  [97c9b0ccedeecf37c565adffb9f3823558013848]

        tdf#112661 tdf#112662 a11y: Fix toggling button via a11y action
        
        `PushButton::Click does not` toggle a `PushButton`
        that is a toggle button. Therefore, call
        `PushButton::Check` and `PushButton::Toggle` instead
        when the acessible "press" action is performed on
        a toggle button, which makes this work as expected.
        
        The same is already done in the UITest code, see
        `ButtonUIObject::execute`.
        
        The originally rerported issue in tdf#112661 and
        tdf#112662 was that there was no action available
        for the "Templates" and "Recent Documents" toggle
        buttons in the start center via the NSAccessibility
        API on macOS at all. By now, the "press" action was
        available, but performing the action (e.g. using
        the Ctrl+CapsLock+Space keyboard shortcut for
        VoiceOver) didn't have any effect.
        The same was true when performing the action via
        Accerciser using the AT-SPI Action interface when
        using the qt6 VCL plugin on Linux.
        
        With this change in place, toggling between
        showing the templates and the recently used
        documents in the start center works using that
        action, just as it does when clicking on one
        of the toggle buttons in the UI using the mouse.
        
        For gtk3, which is using native GtkToggleButtons,
        this was already working without this change in place.
        
        Change-Id: Ie3f02ec914239e0718ca1bfb4ba701f0831bb16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158807
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [96ed0b0c15cf9bacd28a0dcfdb6d109e86e5c998]

        Update git submodules
        
        * Update translations from branch 'master'
          to 846a915406627d0663080fd22b26aa6a2f12c48e
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I1ac45a9287f6a2b5f00788a065fd85e3da4548f4
            
2023-11-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6b708e3c569f87e7a89ec032afacc5a7389f86f0]

        Related: ofz#63786 make it clearer what m_aShortSprm is used for
        
        its not used as a SVBT32, only as a little buffer
        
        Change-Id: I7a6d364c68ae31520cbb7432da832d108a9daeff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158787
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [00e1ac51e6d6185cba0b677587b03e1a94b26a87]

        'new Character' is deprecated in Java
        
        replace with Character.valueOf
        
        Change-Id: I9938db0fce6490eba6f4900efc3c139a1b71d120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [30877bdc01d3a9cda1878f66ca7a84760f5f8c67]

        tdf#157860 - UI: Part 14 - Unify lockdown behavior of Options dialog
        
        for Load/Save VBA Properties Page.
        
        Change-Id: I9526c2a5aa25fbdea1edbc0051d9b6a29c643d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158781
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [71ebaf56d8611ec45e914d5e619c9eb18ba28959]

        resave with latest glade
        
        Change-Id: Id4482f53a84e93f44c1a0cda2d20bf3ece48d44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158762
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [54b5040e0842c85138bb9d800224016054f02778]

        VS IDE integration: enable Python pretty printers when debugging a WSL build
        
        See https://learn.microsoft.com/en-us/cpp/linux/deploy-run-and-debug-your-linux-project#debug-with-attach-to-process
        
        Change-Id: I16d50ebe5f087518de1953ea1f9aad4180714cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158789
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [41d9584179ef7b4e18eda47c2c0a955df8c087a5]

        'new Double' is deprecated in Java
        
        replace with Double.valueOf
        
        Change-Id: If5be8e500e31ebf9d5fb20ea7dd474677d7c74ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158785
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb982f14796aa4dc4362bc6fde74161afa11777b]

        'new Float' is deprecated in Java
        
        replace with Float.valueOf
        
        Change-Id: Ib6408b24dac2953789d0ec67e73b8be8aefca252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [a71da3b7a80ca32b595a8ca0ea3da650b0af376c]

        tdf#156565 sw: PDF/UA export: split Link SE at line break
        
        There must be one Link SE per Link Annotation, so ensure that a new one
        is created for a new line.
        
        (regression from commit 4c5283a3a11008a06a995c49ed777734dc1f6066)
        
        Change-Id: I2585d9e22a435d7716f48fec89a78149c129f71d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158775
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Joan Montané  <joan@montane.cat>  [44ca7832dea2c4e6243ed9fdbc828c25c2466bbd]

        Localize <FollowPage> to Catalan
        
        Change-Id: I088047a94f2bd7a7405cf42e9c0eca73cdb11c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155776
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [755210c38dcb72a56aa7aacb9b52246a63dae687]

        sw: PDF/UA export: produce Link SEs for RTL text
        
        This is a SwBidiPortion containing a nested SwLineLayout containing
        SwLinePortions for the link or text, and only the SwBidiPortion had a
        tag helper, so add one for the inner portion too. (Apparently this
        never worked before.)
        
        Change-Id: I803191dafe101a42e4dbe1c0167411c2f1f76a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158773
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [a1b0fc647d14dc36e9fe238d5bfc81ebcfa1d5dc]

        sw: SwLinePortion::Move() should be const
        
        Change-Id: I79938773034fbe708ba867960c9effecb2e24a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158766
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [5726be1314517d47dd733aabe64a3d85cce094c5]

        tdf#157816 sw: PDF export: filter out links on empty space, INetAttrs
        
        Several problems here:
        * As with fields, there may be selection rectangles with no text
        * SwRootFrame::CalcFrameRects() adds flys that are anchored in the
          selection to the selection
        * A fly text portion causes Link annotations to split, but not Link SE
        * If a fly only partially overlaps a line vertically, then
          CalcFrameRects() produces a full-width half-height rectangle and
          another 2 half-width half-height rectangles on both sides.
          This is useless, the rectangles must be full line height.
          Add some code in CalcFrameRects() to use the fly portions in the
          SwParaPortion instead of the fly frame areas.
        
        Change-Id: I93f0c12a5e5a3d5f51fcc4b33052a112e9174863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158576
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [6593d680e21c24501a58bac216de4a7c71541959]

        tdf#157816 sw: PDF export: filter out links on empty space, fields
        
        If there is a fly overlapping a paragraph, it may happen (depending on
        wrap settings and position) that there's an empty space on one side of
        the fly; the cursor selection region has the flys removed, and this
        region is used here for the PDF export.
        
        So there is a rectangle on the text on one side of the fly, turned into
        the desired Link annotation, and another rectangle on the other side of
        the fly, turned into another undesired Link annotation that isn't
        connected to any SE because without text there is no SE.
        
        This is a tricky problem, and the only idea to fix it is to try to see
        if there is text in the rectangle by first GetModelPositionForViewPoint()
        resulting in a SwPosition and a SwSpecialPos with an index inside the
        field; then see if GetCharRect() for this position returns a cursor
        rectangle that intersects the original selection rectangle.
        
        Change-Id: I6918eac16690e7194208a828108bfa968d28d12a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158571
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Michael Stahl  <michael.stahl@allotropia.de>  [468e5b8e0a7fefe1ca53faeb15f5f6527c37a268]

        tdf#157816 sw: fix getting position in field portion follow
        
        SwSpecialPos can be used to get index inside a field, but
        SwTextCursor::GetModelPositionForViewPoint() has several problems:
        * the field portion follow has length 0 so an early return is taken
        * the nCharOfst is set to the index in the portion, but it needs to
          also count preceding portions of the same field in the line,
          and nLineOfst needs to be set as well, because the SwPosition
          corresponds to the start of the field
        * m_bFieldInfo must be set to guarantee SwPosition before the field
          in the nLenght==0 branch, but then there are 2 branches that first
          set nLength=0 and then decrement it, resulting in a SwPosition 1
          char before the field.
        
        Change-Id: Ib7d30981e41b40f4c068fa6d84211c000ecde753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158570
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-11-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a2f298adf5b6aae54bd9c20a7fbfd007dd356617]

        tdf#158038 fix opening pdf files in appstore ver (sandbox issue w/ helper tool)
        
        https://developer.apple.com/documentation/xcode/embedding-a-helper-tool-in-a-sandboxed-app
        
        "Adding other entitlements to the tool can cause problems. If the tool
        immediately crashes with a code signing error when your app runs the
        tool, check that the tool is signed with just these two entitlements:
        com.apple.security.app-sandbox and com.apple.security.inherit."
        
        This is indeed what happened..
        
        Change-Id: Id03948c03b7d453aae4ca58719f582576e30a16f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158790
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c96680125fc377e6a21e98ce14ce2359d89b02c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb5efb80b63d29c6d4ec84c0c35b9b4a0298a5f7
          - Fix typo
            
            Change-Id: I7821feb7aff0b9c4833d53c71e0b58799deab916
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158788
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-11-02  Skyler Grey  <skyler.grey@collabora.com>  [fd5c75750f5c5448eec840033bce16375774a707]

        Improve and extend STYLEREF tests
        
        - I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19,
          Ib664fec059aa1f7f130acc76c253d5d298fa59f7 and
          Iad8e8001807f5ceeaedc9665838672695174a936 added STYLEREF flags. This
          commit adds tests for them
        - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 were partly
          broken due to the fields occasionally being inserted in the wrong
          place (i.e. at the end of the document), this commit makes sure to
          move the cursor before inserting a field
        - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 were not
          separated into sections which made it difficult to tell what was being
          tested. All STYLEREF tests that create documents are now clearly split
          into arrange/act/assert steps with comments denoting the sections
        - The tests in I35dc36197b62fa53def4745da1d4755ece79ed22 had a lot of
          repetition, particularly in creating the document, adding headings,
          etc. This has been refactored into some helper functions
        - I35dc36197b62fa53def4745da1d4755ece79ed22 was missing an ODF import
          test. This commit adds one
        
        Follow-Up-To: I25dd7a6940abee5651a784b9059fe23b32547d6c
        Follow-Up-To: I35dc36197b62fa53def4745da1d4755ece79ed22
        Follow-Up-To: I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19
        Follow-Up-To: Ib664fec059aa1f7f130acc76c253d5d298fa59f7
        Follow-Up-To: Iad8e8001807f5ceeaedc9665838672695174a936
        Follow-Up-To: Iecd3e83a6bd3f8c2c6adba5c7eba9ee55b773510
        Follow-Up-To: Ifaa67fbc2d53b0d4fb85e7305b2dbdf78cf0a1ad
        Follow-Up-To: Id991c92b9aeaa054b136f7a3d9c7c8ea0026e514
        Change-Id: I941b477c8e860270a400869cb9ea15e5561e402a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158352
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [419866e851c7ad4a39bd508d607baba3590f3d45]

        MSI: Fix Signature table's FileName column type
        
        It was "Filename" [1] since commit 68d28e25348ced2619733d8b177423d3aefab900
        (#i28464# ooo native installer, 2004-05-24). But according to the spec [2],
        it should be "Text" [3].
        
        Found accidentally, because of an MSM bug in VS 2022 [4]. The unnecessary
        entries there for Signature table conflicted with ours, preventing merge.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/msi/filename
        [2] https://learn.microsoft.com/en-us/windows/win32/msi/signature-table
        [3] https://learn.microsoft.com/en-us/windows/win32/msi/text
        [4] https://developercommunity.visualstudio.com/t/Microsoft_VC143_CRT_x64msm-v14363253/10505819
        
        Change-Id: I9911b8c02df57f202d197c634b565ce74b35d7e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158783
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-02  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [3d83bdb94a43b7d77c5a2362cb8204caf47a6b54]

        vcl: removed redundant check
        
        Change-Id: Iec2c344df9eb1fa61bb04355c3eee38499edcdac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158422
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2023-11-02  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [24ee09ab41924fd339835cbc7a54a5ba27f5c67e]

        tdf#104288: rtf export: drop \nonshppict on export
        
        - these days hard to find a reader not able to read shapes
        
        - RTF file will became compact without pictures duplication
        
        - WordPad nowadays is able to display shape pict, no reason
        for fallback
        
        - Fixing possible rtf file bloat on exporting some WMFs
        
        Change-Id: Icc8b60da6541acef939f42021d8d5e81bbcd1ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158507
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2023-11-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [08d74d8980d19c7f524c8f60de5c033d026d1c94]

        Drop SvxHtmlOptions::IsPrintLayoutExtension
        
        as it is just now a simple wrapper over officecfg
        
        Change-Id: If41c7c9db191af7ebede9072fd995d015056bf1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  Stephan Bergmann  <sbergman@redhat.com>  [c1f95f01e0239a16a3b904864a2b5310016b93a7]

        Fix typo
        
        ...spotted by Ilmari
        
        Change-Id: I7414d77d91a4d11d16de1417e60cddf72a0746c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158782
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-02  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6831dffe05fad2bcf7a1db1974bd0be11e6dbff9]

        tdf#156670 Add 'Alt text' command to shapes popup menu
        
        Change-Id: Ib55491cb4d209088cfed344452700eab41da67d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158763
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-11-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d4dcc5228ce0f1c5eee34101be10ff2fcd5f49c]

        Revert "WW8PLCFx_PCDAttrs::m_aShortSprm can be local"
        
        This reverts commit 2779984709d24ad263547407069a5da0fda36ceb.
        
        Reason for revert: we are storing a pointer to this field
        
        Change-Id: Idce917f676f2f1f845f4f4a3ea6dd911818c3eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  khushishikhu  <dpskhu13108@gmail.com>  [48dffbd86ea2893c589e816bce2e974edb2cf344]

        tdf#157956 convert ellipses to quarter rounded circle
        
        The change is about corner rounding of a 'Flowchart Alternate Process' shape. The quarter circles remain circles even after stretching the shape.
        
        Change-Id: I4ecaba9a9f39cfb797e248eb4728ed7dea844f5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158580
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-11-02  Stephan Bergmann  <sbergman@redhat.com>  [5f0e243159cae738dee65303f61b5a5f1b3bdf28]

        Adapt to Clang 18 trunk ElaboratedTypeKeyword rework
        
        <https://github.com/llvm/llvm-project/commit/4ad2ada5216ee2bb3c334a3233a9ab51f2521b82>
        "[clang][NFC] Refactor ElaboratedTypeKeyword"
        
        Change-Id: I1ee6592fe76bb484441ca859986e7217eaba58f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158764
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-11-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [9071fa5f5f103808234102dc7552266ccda7bb22]

        uitest: check that dialog really did open
        
        to make it easier to debug cases where the event.executed flag is not
        sufficient to indicate that the dialog has finished opening
        
        Change-Id: Ibcbd089372e47908e3692d452f4064edbc7f788d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-02  Eike Rathke  <erack@redhat.com>  [f3811e06b27afcbac7f63c2d184db4b1f8b01a1f]

        Update pointers to yet again moved ICU site / CLDR pages
        
        Change-Id: Icf33b45a013393ac114e5a8866921bc8ce368189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158778
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-11-01  Gökay Şatır  <gokaysatir@collabora.com>  [c0c8cffd3541e3cd616c96791b04e7ebf2b2ed03]

        Writer: German language shortcuts.
        
        * CTRL + M for incrementing the tab indent.
        * CTRL + SHIFT + M for decrementing the tab indent.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I1dcf87808cdf1a0e4c91666557531e7550878236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157583
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit b90c1c15fbbe01e5343cfc384c2cb427e76908a0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158777
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-01  Gökay Şatır  <gokaysatir@collabora.com>  [4068a5da3dc3e3e6629a5f9f68684cbb50894896]

        Writer:
        
        Added ALT + SHIFT + UP and ALT + SHIFT + DOWN combinations for:
        * Moving paragraphs up and down in the document.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I5aef03456bce1cfd66349f41cae0ef37889ef0bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157520
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 6b68b8c4819139c54072d2f28186b1fb6d937d56)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-01  offtkp  <parisoplop@gmail.com>  [ceef5a9c39be2b2b16c800f1d92a6b7bf968d8ed]

        sc: Fix conditional formatting icon set order for smilies
        
        The order of these icon sets was not consistent with other icon sets
        (traffic lights, flags, circles) and Excel
        
        Change-Id: I5cbc2ff96118530420341f6994310f946717e0d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158703
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        Tested-by: Jenkins

2023-11-01  Michael Weghorn  <m.weghorn@posteo.de>  [64d7bb1917c38ad8e256a482778df647904f5502]

        macOS a11y: Don't report (non-)expanded state when not expandable
        
        When the a11y object is not expandable, also don't
        report a true/false value for the expanded state on
        macOS.
        
        Otherwise, the CrossOver screen reader on macOS
        will explicitly announce "collapsed" for these
        objects, e.g. when moving focus between paragraphs
        in Writer (as reported on the a11y mailing list [1])
        or between toolbar butons, since
        `isAccessibilityExpanded` gets called and
        returns false, so it is assumed that this
        is an expandable item that is currently
        not expanded, i.e. it is collapsed.
        
        Quoting from the NSAccessibilityProtocol doc [2]:
        
        > You can control which accessor methods the assistive app can
        > use by overriding isAccessibilitySelectorAllowed(_:).
        > Return true if the assistive app can call the selector;
        > otherwise, return false."
        
        [1] https://listarchives.libreoffice.org/global/accessibility/msg01068.html
        [2] https://developer.apple.com/documentation/appkit/nsaccessibilityprotocol:
        
        Change-Id: Iac9027a598e5793d6bd0da79212d7b07448a4c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158733
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-11-01  Gökay Şatır  <gokaysatir@collabora.com>  [691604d9037e72a94207d643cba29c64260b1cb9]

        German shortcut changes for Impress:
        
        * CTRL + D for duplicate objects.
        * F12 for save as.
        * SHIFT + F3 for rotate lower / upper cases.
        * SHIFT + F9 for show / hide grid.
        * CTRL + F9 for show / hide ruler.
        * CTRL +SHIFT + H for ungrouping objects.
        * CTRL + SPACE for removing direct character formats.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: Iedfd5f9bbc088b76edbb897141d9e612f8b55057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157410
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 541bcc2be61c10f85cafe0e62bb3afc60a152c01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c79e5da169a98e78d1410a6a7c04215bd5e24349]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2dea31ccc46cfbc44fed1c3348ed57f9b3344a7a
          - tdf#155876 UI cmds Calc-Insert menu (18)
            
            + refactoring of Insert Headers and Footers
            
            Change-Id: I6eaab609ecae9fbd34bb3e0670dd8c9540904b23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158774
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cf39328f75aeafbe73cacc51c7866a38cc6570b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ca63be69ab23e8f420825d381bfb8e6a058ac58
          - tdf#155876 UI cmds Calc-Insert menu (17)
            
            + refactoring of Insert Field menu
            
            Change-Id: I72dcab2a45ddfe78025ceba699aa8b1428d4bdb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158772
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7b0c350defc5245644568391412114282e26cd8e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b28faac2c5fe5600c97b40ba65e773b7f75c299c
          - tdf#155876 UI cmds Calc-Insert menu (16)
            
            + refactoring of Insert Date and time
            
            Change-Id: I95db763eb928d683b501cc35b06150cf5f061306
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158770
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [03d741f92e2917a4b187bf87b00754b3c6739a73]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5218a19ee667dd6486e75178ab029587978fa11b
          - tdf#155876 UI cmds Calc-Insert menu (15)
            
            + refactoring of Insert Formatting marks
            
            Change-Id: Id776090db4b97d51d8457624fc7468d503ddb1ec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158769
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [89c865f4020f2afbf050dc36affe0da2b6497fd4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66de4e5a3f8015f2742e7a4c64701769c2d9f33d
          - tdf#155876 UI cmds Calc-Insert menu (14)
            
            + refactoring of Insert named expressions, Insert Text Box
            
            Change-Id: I3a6c83240dd2d5abf740f891d300fd6a7647fbcf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158768
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  offtkp  <parisoplop@gmail.com>  [edbc3a09edcf58a4738b4648811a065f3f55bc7c]

        sc: Don't end handleConditionalFormat early
        
        handleConditionalFormat would exit the conditional format searching loop
        which meant that cells with overlapping conditional formatting rules
        would not get properly rendered
        
        Change-Id: I98664c758cc2c8f844994e6dcecdc57df2213a01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158702
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-11-01  Justin Luth  <jluth@mail.com>  [c1c1fb5e1d6055459a8b393114ecfbc31f822d45]

        tdf#112131 sd: check if SdrObjKind::UNO accepts hyperlink props
        
        This fixes a form control's hyperlink being set by Insert - Hyperlink.
        
        Calc and Writer do something similar - checking for ButtonType.
        
        Change-Id: Ia36b216c8f749bc2a5dfba448a4771d9d7d50256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158765
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [43464d9f31c4aaea07cc84c03d5ce67ce2cdc142]

        new loplugin:fieldcanbelocal
        
        Change-Id: I33fe8afcbba1d461bee98c92507c878e4e5d41d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158756
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [883b50c06ea00a5437a757c1a4a49dc27a92e30a]

        DataStream::mnSettings is unused
        
        found by a new loplugin
        
        Change-Id: I9628e1a5b160f0daf43030a4a61146f1d5a626e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158755
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [2779984709d24ad263547407069a5da0fda36ceb]

        WW8PLCFx_PCDAttrs::m_aShortSprm can be local
        
        found by a new loplugin
        
        Change-Id: Ie31d3fe32b9a8267d941d17d4a0a8749a7341165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbd558d0d13f3fac3267aff7c22baff27c5de43f]

        SwFieldMgr::m_nCurFormat is unused
        
        found by a new loplugin of mine
        
        Change-Id: I2947d7c9f57b385053e50df4970f113a39432b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Gökay Şatır  <gokaysatir@collabora.com>  [e651d9e657f9b61fb45777d6e7edeb5cb95f8d27]

        German shortcut improvements for Calc:
        
        * Insert date is assigned to CTRL + POINT.
        * Insert time is assigned to CTRL + SHIFT + POINT.
        * Save as is assigned to F12
           * Group and Ungroup are assigned to CTRL + F12 and CTRL + SHIFT + F12.
        * Insert function dialog is assigned to SHIFT + F3
           * Rotate case function is assigned to CTRL + SHIFT + F3.
        * Insert comment is assigned to SHIFT + F2
        * Format cells dialog is assigned to ALT + 0
        * CTRL + 5 is for Strikeout.
        * F5 is assigned to FocusCellAddress.
           * CTRL + F is assigned to navigator.
              * ALT + F is assigned to "focus find bar".
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I0213fecb6fe02b2d621d8409225251dbfa6631ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157360
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 828c6bd73dcce738edc7d6a46432ddc5288235b7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158723
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-01  Andras Timar  <andras.timar@collabora.com>  [6abe70d181e764c962a9c5e85e826247650bab3a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to bdd5aa2d5e7d0bdbf68d01705e7eb63cdaaf1737
          - Update Danish dictionaries (v2.8.001)
            
            Change-Id: I5345295565467b204a22a6b9d7b91d60dd00b149
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/157448
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [90c84aa5916c496de357dbf3956c51e0eb202dc4]

        WW8TabBandDesc::bCantSplit90 is unused
        
        found by a new loplugin
        
        Change-Id: I988e43760b203a57342d606caadc1f2517a657a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d33912707a621b04467eb56823e26b4b0db01ae]

        AttributeProperties is effectively abstract
        
        so remove the unused code and assert there, just to make sure
        
        Change-Id: I31771e5c210b087775d59804874456cece9509cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5ebdf4dc68b6c3736c4144dde2d8fa4191fec9b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba53126a2a008a50119d82c9f904eee70df3dbd4
          - tdf#155876 UI cmds Calc-Insert menu (13)
            
            + refactoring of Insert Functions
            
            Change-Id: I8f09d6f9f4a44d7c41ba86046b94c27612b81f12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158760
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [97a7a13c5650c6e2c957780a678ee119d47304af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d050546d948767191446369a451e4e0267fa4272
          - tdf#155876 UI cmds Calc-Insert menu (12)
            
            + refactoring of Insert Pivot Table
            
            Change-Id: Idbdebf2b77a5fdd77fd6ca617bf1a488362a5fbe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158759
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cd95edc134161725141ffaa153f2b64097ef1da9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d8bcb189aeeff79f51d23c88c13ff9970a2700a
          - tdf#155876 UI cmds Calc-Insert menu (11)
            
            + refactoring of Insert Chart
            
            Change-Id: I8c43233a31525fd58156d9e8bce8942724b34fc8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158758
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [30c9ba634b89660909a081853a0098af94f1bc1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6cb61568afd30c4effc53b209716faec001412a
          - tdf#155876 UI cmds Calc Insert menu (10-a)
            
            + refactoring
            
            Change-Id: Ia344ee8beb056dd42f1c53e4ba84b48107b730e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158757
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-11-01  Henry Castro  <hcastro@collabora.com>  [32e6ef3834a0f96d7830719950de52c99aae0263]

        tdf#155512: sd: qa: unit: add unit test "testMasterSlides"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I6117b384fdad215e6c04b6e74df22fe9daa6a526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157705
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158739
        Tested-by: Jenkins

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [35975f9ea30e9ec8ac9276f90874ffe272001038]

        pass SfxItemSet by const & to CreateNoteFromObjectData
        
        Because in an upcoming patch the CloneAsValue() call in
        XclImpNoteObj::DoPreProcessSdrObj will stop working, because the
        underlying SfxItemSet will no longer be an SfxAllItemSet
        
        Change-Id: I8361a1b1c1c64cff49c736812fbfb2597ab41140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2f9a6802793467823ce47a255591ff9e023a6dec]

        Fix typo
        
        Change-Id: I25685976a4cd4549ab6448bcba179d5c4e7185bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158745
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ee058521541da49e6d1d8a0e84cc42e9e801b518]

        VS IDE integration: Use LocalDebuggerCommand for startup executable
        
        Before that, NMakeOutput was abused for that. Now it will point to
        the correct link target.
        
        Change-Id: I9c3fd57948cc24a99f54a1c23ca5e0351d25a0dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158748
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-01  Laurent Balland  <laurent.balland@mailo.fr>  [443027cd71aef3eb45bbf3631869ea63457f2c81]

        tdf#156449 Preserve '0' or '?' in exponent
        
        Exponent in scientific number may use '?' as blank like in format "0.00E+?0"
        This change:
        - adds interpreatation of '0' and '?' in exponent
        - adds "blank-exponent-digits" attribute to scientific number for import
          and export to ODF
        - prevents using exponent with only '?'. There must be at least one '0'
          in exponent
        - adds QA test of such format and test import/export/import to ODF and OOXML
        - corrects one basic test
        
        Change-Id: If52edc632a161f842270bb2fd77af535e2b978d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154986
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d7d7eb55a3833ff12c61b1a03a296bb0bf4e640]

        reduce log noise
        
        Change-Id: Iff3c2b8fb5ae0939157aaec67f5830c80cf46ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [9f1289f1e3c9b4a5f2be7a7187877db6b5015973]

        tdf#157820: handle \\?\ prefixes in INetURLObject
        
        They are already handled in osl file URL functions.
        
        Change-Id: Id0c224bdb79963e7ce52abde57bf05b0a6a81ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158741
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-11-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [d8326f1f54b2f4644b52fbfa7106eeeae6e5bb7b]

        Upgrade Harfbuzz to 8.2.2
        
        Fix regression from 8.2.0 in parsing CSS-style feature strings.
        (https://lists.freedesktop.org/archives/libreoffice/2023-September/091026.html)
        (https://github.com/harfbuzz/harfbuzz/issues/4414)
        
        Change-Id: Ifdaeb7b2a9a5da2866810e4d5298f57a0fd9bd9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157434
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-11-01  Laurent Balland  <laurent.balland@mailo.fr>  [cc721291cc4a53503398b82dd86baa521b2b13cc]

        tdf#153993 Extend ODF: lowercase for exponent char
        
        In scientific format, user may want to have clearer format such as:
        0.000" "000" "e+" "0
        
        This change
        - adds "exponent-lowercase" boolean attribute to scientific-number format to preserve "e" or "E" char
        - includes all positions up to exponent for embedded text of scientific number
        
        Add QA test
        
        Change-Id: Ie263f4ecf30a1a8dcd8046e1e048767020e54dc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153824
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-11-01  Justin Luth  <jluth@mail.com>  [e8228e0994610fed8af090ff30ffc08bfecb7261]

        tdf#108318 rtfexport: no hyperlink target for clipboard
        
        This fixes copying hyperlinks from Writer to the other apps
        like Calc or even to editeng components within Writer.
        
        External apps never seem to call for RTF clipboard.
        Certainly firefox doesn't - and everything I tested
        seems to just request plain text URL strings.
        
        I don't see anywhere in the RTF specification that a
        \fldinst can take formatting parameters along with the URL.
        That is likely only a DOCX thing.
        But since RTF shares import code with DOCX, it gets the parsing
        for free, so we explicitly use it to round-trip targets in RTF.
        See commit 31de0ac30d6c521ad663db78feb936688be5bccb
        Author: Miklos Vajna on Tue Feb 14 09:32:25 2017 +0100
            RTF import: handle target of hyperlink
        
        Alternatively I could have had editeng parse the flags
        on clipboard RTF import, but handling it at export
        seemed cleaner to me.
        
        Change-Id: Ic34bcf99edf7bd3fb404ed312c07acae0ef814e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158744
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-31  László Németh  <nemeth@numbertext.org>  [4cf8de89bad9143a5b2dd3d6351080bf62b76029]

        tdf#157667 sw track changes: fix cycle case on multiple words
        
        Fix tracked cycle case on multiple selected words.
        
        Follow up to commit dc748d7dbd114fbf663752258dbaf003af2926c3
        "tdf#141198 sw: fix cycle case with change tracking" and
        commit 79435eb55ef226fb0e3507aabdc2f8af062680f6
        "tdf#157988 sw track changes: fix cycle case on a selected word".
        
        Change-Id: I81566f8be0cf6f4af6ed4af031116bd19e3884d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158732
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-31  Gökay Şatır  <gokaysatir@gmail.com>  [f5ae03b235766070b1c1e5bf46d0cb86a8196b10]

        Writer German shortcuts compatibility improvements.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: Icfcdf3f629442da339c846f9eaa577ff7b779290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152261
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 7b168fbe4e4a5feecdd946fef9c5c3e5107dc050)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158722
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Gökay Şatır  <gokaysatir@gmail.com>  [2d37ac2ca3a93cd7f05867ba7256c9e232192983]

        Added & modified some shortcuts for general compatibility.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: Ibfcfbc3a75aca392acc4626e6169f2f3abcc4970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152196
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2d4f8900150ae109700b873d781461ef96ab091]

        cid#1548365 Logically dead code
        
        since:
        
        commit c75cac85230d3899fe9f5f5086c117e4e1e5d330
        Date:   Sat Jun 17 02:57:42 2023 +0200
        
            tdf#155887 WMF Fix displaying images with size of EOF other that 3
        
        Change-Id: I326593cc556319d947bd9f3aef32b4ff6264c68f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [ba26d5f5e0529d7accf6f268559b8d659ba7c6c2]

        tdf#106057: Don't fail PDFReader::read, when several entries in stack
        
        It may happen in case of several trailers, which is OK. The calling code
        will check the type of the returned object anyway.
        
        Change-Id: I17b2f4b7cf0e0640f949565291ee5a905ef2411e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-31  Henry Castro  <hcastro@collabora.com>  [f2ae8b934aaac7c444e8493ed5e8189c6ce63328]

        tdf#155512: oox: ppt: fix import master slides, follow up
        
        Import all master slides.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ieac68bacf15c75e4c23ec692aadcb16033cdd092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157701
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158716
        Tested-by: Jenkins

2023-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [046e9545956d8ad1d69345d6b4a4c0a33714d179]

        Try to revert to use of file_iterator from boost on Windows
        
        It was disabled in commit ef8d59c5b909d5a9b956934ab1120f90b90a4e10
        (vcl108: #i106853# work around broken file_iterator on Windows,
        2009-12-01), referencing boost 1.39. It seems to work fine now,
        so let's revert it, and hope it doesn't break something.
        
        Change-Id: I208aa87eca146a29ffc2f36a48810ecda5df0f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158736
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b1acf7d1a0a2515a5f781b702c22c6233caecc8]

        no need to call GetObjectItemSet inside ForceDefaultAttributes
        
        ForceDefaultAttributes is only called after an itemset has been created
        
        Change-Id: I0ef8df039ed7a238b673c3770ee884a58dd62772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158735
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba85e9f54809dd2c7eb817ead90f9fac0add6e06]

        add comment to CellProperties::ForceDefaultAttributes
        
        Change-Id: Iea65e06b886d47ea18fa1dc81a6df0cd8b995776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e08992f99bfd4aaa57a6b30b9e8a32ee5dc4a98]

        reduce ref-counting traffic in configmgr
        
        we can return by const& from getNode
        
        Change-Id: If93c43fd2e910e2fb69d9bd0a9e3dc587133dfa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [300763ddf666b8f2e428231ffa892ecd4efb2eae]

        reduce reference counting traffic in configmgr
        
        no need to construct a vector when iterating over children
        
        Change-Id: I717e92be3c576a6e5d877f4333264a5bed9daadf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [525a4732c74baf0c8638353d32bf4220bbb77623]

        rename mxItemSet->moItemSet in DefaultProperties
        
        because it reduces the noise in an upcoming patch
        
        Change-Id: I67d7b719609271f626e38596416eb511fbd40b07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158714
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d0748b0c44649c422980a2b2f5554846c47ac9c]

        SdrAttrObj and SdrObject are abstract
        
        so push the CreateObjectSpecificProperties implementation down to the
        concrete subclasses.
        
        Change-Id: If2c9545aada3e9f2c2f2a0140b6d880bdfef111d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [d0f521132c43fea1ca18e18d3e31c6d868e4ebd6]

        tdf#157679: vcl_pdfexport: Add unittest
        
        Change-Id: I31aa7f683e8d9f9a227ba88c58e7fdba94c83bb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158725
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c15c1d87fceb782d76b5984f576d03a63c609ae5]

        tell client when the cell for the comment changed
        
        when a row/column is inserted/deleted, etc the cell the comments are
        associated with changes, so broadcast that change to the clients.
        
        https://github.com/CollaboraOnline/online/issues/7334
        
        Change-Id: I8a3e5fc151b6ba99e68b32c3fe8804de9ba2baf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Attila Szűcs  <attila.szucs@collabora.com>  [bfeb6375a96d75ed7117f1581b0a0d7cb0d236ca]

        tdf#157662 SW: fix connected area calculation
        
        Reset pRedline to its origin value between the 2 loops,
        because the 1. loop may change it.
        
        without this fix, if it discover neightbours in the 1. direction,
        it will not discover them in the other direction.
        
        Change-Id: Ia1ab357ada17cb7574907a3aa1bf0dd4d7a90255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158517
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158721
        Tested-by: Jenkins

2023-10-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4f1b3c16f5530a2a190cab07c07c7bf63acf42c7]

        tdf#100584, tdf#157784 - Arrange sheets depending on the RTL settings
        
        The tab bar's position should be determined globally based on the RTL
        settings, rather than being individually set for each sheet.
        
        Change-Id: I0690b01c842d2da6d49b57d1adad0a8e0844087f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158730
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-31  Marco Cecchetti  <marco.cecchetti@collabora.com>  [a269f52d2016ef72f51e8b73574b6cbd0f448e33]

        lok a11y: calc: make possible to enable accessibility for spreadsheets
        
        Change-Id: I462b2d386b58a895bd4c45d4bd61a049404d3848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158512
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit e5481fdaf33a3921ef0624e8a62e28e2f68086da)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158691
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3be361d00eb1d61543e2c8c6953e63c149fb1eb0]

        Revert "tdf#100584, tdff#157784 - Arrange sheets depending on the RTL settings"
        
        This reverts commit a90d89d5b2dae2b4c3fd6a411de2160a3bf20779.
        
        Reason for revert: Typo in the commit message
        
        Change-Id: I58f184e2733d91aa827396868fb4f7b8e9d47a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158693
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a90d89d5b2dae2b4c3fd6a411de2160a3bf20779]

        tdf#100584, tdff#157784 - Arrange sheets depending on the RTL settings
        
        The tab bar's position should be determined globally based on the RTL settings, rather than being individually set for each sheet.
        
        Change-Id: I0906f85058a5b4250540dda07740eec61f46d299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158675
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1d2442662a1c593c0ed47391156719ffdf9385f]

        we always have a ScDocument so pass by reference
        
        Change-Id: Ic82c71ea6d0490d17fcca07afe4f7da9441a5794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158715
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  offtkp  <parisoplop@gmail.com>  [c8da023efe26efcb166c3525ca73fe62f26e154c]

        tdf#157930 Add Contains Text rule to easy conditional format dialog
        
        Contains Text is another commonly used conditional formatting rule
        that could be of use here
        
        Change-Id: I67a3f711c57f9917be26fa21badd2f5a0d133747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158657
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-31  Henry Castro  <hcastro@collabora.com>  [d590f094ccd28ca449eff91692c2178058d5c621]

        tdf#155512: sd: filter: eppt: add "SlideLayout" property to Slide Master
        
        If it is importing all Slide Master from pptx file, unfortunately
        it breaks the exporting to pptx due to save and reload unit test failures
        
        According to the documentation
        http://officeopenxml.com/prSlideLayout.php, so the file pptx has a
        relationship Slide -> Slide Layout -> Slide Master
        
        The Slide Layout is a template an unique to be reused
        with Slide Master, so exporting requires to compare
        the templates due to LibreOffice relation Slide -> Slide Master
        
        Adjust unit test values:
        
        SdOOXMLExportTest2::testTdf106867
        revert adcde78935fb8ca2b93322aa3a558d0b3ccdbfad
        
        SdOOXMLExportTest2::testTdf112280
        revert adcde78935fb8ca2b93322aa3a558d0b3ccdbfad
        
        SdOOXMLExportTest2::testThemeColors and
        SdOOXMLExportTest3::testTdf114848
        The file tdf84205.pptx does not contain theme2.xml,
        and save and reload it does not caintain theme2.xml too
        fix "An uncaught exception of type com.sun.star.container.NoSuchElementException"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I622e9d5d68c406ff520387f3903808613d1cd3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158084
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158676
        Tested-by: Jenkins

2023-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [b3c12778aa908a147224cc05f3384b3f57d3b394]

        Update an URL
        
        Change-Id: Ie1b01d3d17f453ae1aa3d53c17e52cd4106e222e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158687
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0f4be839196bfc97a4df71cbaff16df33e7138a8]

        ofz: lots of msan spam in LLVMFuzzerCustomMutator
        
        maybe this is that problem
        
        Change-Id: I646a93cf815455f3eb1176df0aac5dd6641de649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158677
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d4f4a401861e7c908b6ab7f72563d5ab911edcf0]

        This function takes a string view - no need in OUString literal
        
        Change-Id: I194471b1bb20a41929026c6195b8f2fd669906c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158682
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [33ca16e94dcd9b74f39937bafaa76c8ca9189877]

        related: tdf#156905: sw_odfexport2: Add unittest
        
        The sample file started to crash at import time with
        d8de2dc3c55a9013a71167c8058a333e7221a6a0
        "xmloff: import of theme structure + import/export/round-trip tests"
        Later, it was fixed with 4f347ebabad6355014889f0a81b107dc774590fe
        "use shared_ptr for model::Theme instead of unique_ptr" but it was
        still crashing at export time. Finally, the export crash was fixed with
        9747d9a6ea954dfca4152d36fdb28a8b77fec84b
        "xmloff: rename theme color names and color-table to theme-colors"
        
        Adding it as a unittest since the crashtesting didn't find it over
        a range of 3423 commits
        
        Change-Id: I466e3db9bc917f299afe2399b15e4d13db11e1ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158670
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [8d6f1a644895e1a3a1a4ea1fd336125a0ccee964]

        CppunitTest_sd_export_tests-ooxml3: split in two
        
        it already has 93 tests
        
        Change-Id: Ic0459705255d8728f31c9c07760b2e2f07fac77e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158669
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [117133575961dbce292a24f8afa1414785f2282c]

        CppunitTest_sw_ooxmlexport5: split into two
        
        It already has 105 tests
        
        Change-Id: I06bd3740f5b3f368017fefd06fda099891834114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158668
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [a04fc307ba2706bb9e5b8441aaf4380797b5f397]

        CppunitTest_vcl_pdfexport: split into two
        
        It already has 109 tests
        
        Change-Id: Ic16c5ee68f020c2ee1662354786fb82aada62e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158667
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-31  Michael Weghorn  <m.weghorn@posteo.de>  [bd159d4f4f827821782926cc13f8b5c4c8a63a3d]

        qtcreator: Add Obj-C++ files to project
        
        Extend gbuild-to-ide to also take into account
        Objective-C++ files that are set with the
        `OBJCXXOBJECTS` key in the json files.
        
        Extend the Qt Creator IDE integration target
        (`make qtcreator-ide-integration`) to make use
        of that information to find the corresponding
        headers as well, and set sources and headers
        in the `OBJECTIVE_SOURCES` [1] and
        `OBJECTIVE_HEADERS` [2] qmake veriables.
        
        This way, those files are part of the project
        and the Clang Code Model works as expected,
        which makes features like code completion and
        showing issues work correctly for such files
        (like e.g. vcl/osx/a11ywrapper.mm) as well.
        
        [1] https://doc.qt.io/qt-6/qmake-variable-reference.html#objective-sources
        [2] https://doc.qt.io/qt-6/qmake-variable-reference.html#objective-headers
        
        Change-Id: I2c1cf5bdfdc64300ec3eb77e42de1ae2cd4223f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158665
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-31  Michael Weghorn  <m.weghorn@posteo.de>  [0779066f4788ec01daee6b452cde02b9139019aa]

        bin/gbuild-to-ide: Drop trailing whitespace
        
        Change-Id: I3142080721db11f75631accd3a5e403027a63110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158664
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-31  Michael Weghorn  <m.weghorn@posteo.de>  [303899b811f8cf3dd72caacb0d9a4f59d245b02d]

        qtcreator: Set correct soffice path on macOS
        
        The soffice path is different on macOS than it is on
        Linux or Windows. Let gbuild-to-ide take that into
        account when generating the QtCreator IDE integration
        (`make qtcreator-ide-integration`), so the autogenerated
        run/debug target works.
        
        Change-Id: Ibdd4cf32bddadfe67608b06b7b3ce58c2a9dd518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158653
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0bd5b0f92c10db2da04ad8ee7de8e11534df046e]

        ofz#63741 Unknown Read
        
        this went wrong in
        
        commit d97e0458914991214e3d396273862855aff66234
        Date:   Mon Oct 1 03:09:35 2018 +0200
        
            vcl: no raw pointers
        
        where
        
        rJobData.SetDriverDataLen()
        
        was dropped
        
        in favour of using using nDriverDataLen, but missed replacing an interleaved
        GetDriverDataLen() with nDriverDataLen
        
        Change-Id: Iebc9145865fa4ec985bc2feed754c775d77011b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [2ecd5da533f8fc4229bb8a38167eb147c1213fa8]

        ReqIF: introduce ExportFormulasAsPDF HTML export filter option
        
        Change-Id: Id400bd5571d0a192d854620abe83d862e0512434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158663
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [63a44ac83f0dbc792f71881e862c57e8037c84ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e0f314893a2ecd17db341f922daffe0d165131b
          - tdf#155878 UI cmds Impress-View Zoom menu
            
            + refactoring
            
            Change-Id: Ib56640c6548b54825971bfb1fe9311a72463eff9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158678
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-30  László Németh  <nemeth@numbertext.org>  [79435eb55ef226fb0e3507aabdc2f8af062680f6]

        tdf#157988 sw track changes: fix cycle case on a selected word
        
        Cycle case didn't work on a selected word, only on the
        word under the cursor without selection.
        
        Add unit test also for tdf#141198.
        
        Follow up to commit dc748d7dbd114fbf663752258dbaf003af2926c3
        "tdf#141198 sw: fix cycle case with change tracking".
        
        Change-Id: I0c1361c78d09e9b8743192a47dcdfa6f6da52e38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158666
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [a18174e807e8704c385637b8a53c45b9608bfa42]

        tdf#144444 Use title case Toggle Point Edit Mode
        
        Change-Id: I5ee2bd22e73262e61e49b98773bc18e1ca1b1783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158661
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [095e9be9d1be7fbc7dc611aa875202a4e5837cad]

        tdf#157588 More clarify meaning of High macro security level
        
        Change-Id: I7a56ed976ddac9917721da1247c55a735ae77d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158557
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-30  Skyler Grey  <skyler.grey@collabora.com>  [3e6d4a563f390638b285254d2128466b56ce03ba]

        Improve STYLE_FROM_BOTTOM compatability with Word
        
        From my testing in Word, it doesn't honor the "search from bottom" flag
        when it is in the body, only in marginals. Additionally, it doesn't
        continue searching in the opposite order if the referenced content is
        not found on the current page, instead it searches in the same order as
        it would normally (i.e. pages above then pages below). This commit
        changes the behavior and UI of our from bottom flag to match.
        
        Change-Id: Id991c92b9aeaa054b136f7a3d9c7c8ea0026e514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158452
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Skyler Grey  <skyler.grey@collabora.com>  [2ddd1378fc232fbc1d5162f2c44ecf71c6725732]

        Improve HIDE_NON_NUMERICAL compatibility with Word
        
        The previous implementation of REFFLDFLAG_STYLE_HIDE_NON_NUMERICAL had
        some major incompatibilites with Word. In particular, it stripped
        letters even if they were included in the "numbering" system.
        
        This commit fixes a lot of the flaws in the previous implementation, so
        it's now a lot closer to Word.
        
        Change-Id: Ifaa67fbc2d53b0d4fb85e7305b2dbdf78cf0a1ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Skyler Grey  <skyler.grey@collabora.com>  [15972993ff6e106a02954125269612179e1f33aa]

        Fix incorrect marginal STYLEREF content in docx
        
        STYLEREF fields were previously not importing with the correct content
        when loading a docx document. This is because they were not updating
        when the document had finished loading- only partway through, and where
        a STYLEREF field is in relation to everything else in the document can
        change its content.
        
        This commit fixes that issue by adding STYLEREF fields to be refreshed
        whenever other fields that can change based on pages (e.g. page number)
        fields are updated. I suspect this could lead to double updates in some
        cases where both reference and page fields are being updated. I consider
        this a relatively minor issue in comparison to incorrect field content
        when specific documents are loaded, but a followup could be made
        improving this.
        
        This commit also fixes a minor typo in reffld.cxx where m_sText is
        always the filtered text when updating fields, even if we are updating
        m_sTextRLHidden instead.
        
        Change-Id: Iecd3e83a6bd3f8c2c6adba5c7eba9ee55b773510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158450
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Skyler Grey  <skyler.grey@collabora.com>  [6412a74b35a3e6089b65b4ad04549262e4bf93c8]

        Enable STYLEREF flag export/import with ODF
        
        This commit enables exporting the following STYLEREF flags with ODF
        - Search from bottom to top
        - Hide non numerical
        
        After this commit, the following steps have been implemented
        - The document model (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - The layout (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - The UI (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - UNO (Ib664fec059aa1f7f130acc76c253d5d298fa59f7)
        - DOCX/ODF filters (here and Ib664fec059aa1f7f130acc76c253d5d298fa59f7)
        
        Change-Id: Iad8e8001807f5ceeaedc9665838672695174a936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Skyler Grey  <skyler.grey@collabora.com>  [e195c22533de44cd4f6afab7836c7eb6a613d202]

        Enable STYLEREF flag export/import with OOXML
        
        This commit enables exporting the following STYLEREF flags with OOXML
        - Search from bottom to top
        - Hide non numerical
        
        After this commit, the following steps have been implemented
        - The document model (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - The layout (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - The UI (I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19)
        - UNO
        - DOCX filter
        
        Change-Id: Ib664fec059aa1f7f130acc76c253d5d298fa59f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [186398e2661c8be9c4d8447d2c8fada443b26ad4]

        update tsan-suppress
        
        with some more glib-related noise
        
        Change-Id: Ie91f8036613d955f5a4a62d7df10b62ba0bec227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [cee0a8b26340097807afc1939d296cbf9e0be428]

        tsan:data race in LanguageTag::registerImpl
        
        not important, just reduces noise when running tsan
        
        Change-Id: I96de4f9e70c8165f0c1135e24ae7522266aa0c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [86f0d88025262b0cfb519545ae7956f6ecea16f9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to acb9fd45cdf33a7ad567dad95dfea0ad33a6b915
          - tdf#144444 Use title case Toggle Point Edit Mode
            
            Change-Id: Ia40726ec51351fdaf159aa843413583ea183047e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158662
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [24d4540088f7b45716e87db3fcf0817518d61fe1]

        Allow passing Math-specific options to PDF export
        
        The options present in the Math' Print dialog:
        * Contents:
          - Title;
          - Formula text;
          - Borders;
        * Size:
          - Original size;
          - Fit to page;
          - Scaling N%
        
        were previously not handled in math_pdf_Export. This change makes
        them handled, similar to handling of other modules' options.
        
        The final handling of them happens in SmDocShell::Impl_Print.
        
          TitleRow (boolean; default = true)
          FormulaText (boolean; default = true)
          Border (boolean; default = true)
          PrintFormat (long: 0 - original size; 1 - fit to page; 2 - scaling to PrintScale; default = 0)
          PrintScale (unsigned short; default = 100)
        
        They are also available in command line, as implemented in commit
        0c3b8792b712e939d2ad524d554f96616b4844be (PDF export: allow setting
        filter data keys from the cmdline, 2022-01-24), using JSON syntax.
        
        TODO: make these options available in Math' PDF export dialog.
        Change-Id: I4fcc609e943823a5325a4840988a96c9d5ab3223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158637
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5675d7e03de5962af8828663529a780ca31dd5b]

        rename mxItemSet->moItemSet in SvxShapeImpl
        
        because the improved naming is useful for a bigger patch that I want to
        land
        
        Change-Id: I3acea11288a2e70d6ea91c99b52d3a05916da4d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e2c70024c2370b2fc3514ee52ec433be998ec57]

        tdf#157679: Revert "pptx: import shape text from master page"
        
        This reverts commit ae3b97a69688553e6c40ef4b64655db09d5a0f5e.
        
        Change-Id: I39fd84b5efbff0a2cafe090f4f866c801cef19b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158357
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6270996c66a05722c5d7c8fe1fcdb3992761650d]

        Fix typo
        
        Change-Id: I63c8d4f30a1558e3f1cee72cc5d4ba1426409912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158635
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c26cbb68c1f0d22c67899821c955ee2df78c7ca7]

        tdf#157859 - UI: Part 13 - Unify lockdown behavior of Options dialog
        
        for Load/Save General Page.
        
        Change-Id: I8e02b1b1188f42903ee164ee9f7ddd9113c602bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158565
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [03417b4ee572f84850ea7406929410510f10d793]

        Fix typo
        
        Change-Id: I1906435815ddfe831a3f833f9e47af2636f4367f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158632
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d09a7ca9be52b850c3df82c49d74abd11476c886]

        Fix typo
        
        Change-Id: I46eacec6000182b24a8f4b14aedf0f6b97dc45b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158629
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [82dc215580a6ef7ca284f1acb03e731f220b7497]

        Fix typo
        
        Change-Id: I461707c6a61887f75078743c087b3f9d44f9e7a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158628
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [702c4775fc4e011220bf2356d4ee2ca561ff5487]

        Fix typo
        
        Change-Id: I0ea74d87f66554cedf1b1bff86e58bb3e78a3010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158634
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [64e34917e79c4690e923f28a6a316cc41e3bab4d]

        Fix typo
        
        Change-Id: I47eef85285e512b4dfaf2a4e2a048ac857347ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158633
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [06c97416819fb4a681e45bd7660709bc500d5467]

        Fix typos
        
        Change-Id: I1549c90313823f9ade2a72d858dd01354e1f4f6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158630
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-30  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [df79eedf6989ab4c2913a23a7e72079bd719168b]

        tdf#157518: vcl: Introduce vcl control LevelBar
        
        Introduces LevelBar that shares implementation with
        Progress(Bar).
        
        LevelBar is to be as a level indicator, e.g. password strength
        level. Currently with native backends for gtk and Windows.
        
        Currently, except on gtk - the colors of the bar at different
        levels are hardcoded and not dependent on any kind of themeing.
        
        On Windows it follows the styling of progress bar of type "Meter"
        according to the uxguide:
        https://learn.microsoft.com/en-us/windows/win32/uxguide/progress-bars#meters
        
        Change-Id: Id772cda23615e9582463bf589e4674fd4588c864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157826
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-10-30  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [3d5cafbe1727a95a54eb4a65d98d6d79ec46f0c8]

        tdf#157518: external: bundle zxcvbn-c
        
        Integrates zxcvbn-c as a static library.
        
        zxcvbn-c is C/C++ implementation of
        https://dropbox.tech/security/zxcvbn-realistic-password-strength-estimation.
        
        This is the first step for introducing a password strength
        meter. Some example projects that utilize zxcvbn-c are
        KeepassXC, monero-gui.
        
        ExternalProject_zxcvbn-c takes care of the dictionary node
        generation bits resulting in the dict-src.h
        
        Then StaticLibrary_zxcvbn-c depends on
        ExternalProject_zxcvbn-c and uses the generated bits and the
        zxcvbn-c source to compile the library.
        
        It should be possible to get rid of dictionary node
        generation bit with a patch that includes a constant
        dict-src.h that's what monero-gui does for example. But this
        might also obfuscate what dict-src.h is.
        
        Right now the dictionary that is included with zxcvbn-c only
        targets English, so that might be something to improve upon.
        
        Change-Id: Ic2b0a558cff341114d69fbdc257979a28bf5c865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157565
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [9a4e4db710137b1a7cb8e62ffa16128c7cc72177]

        These members can be local variables
        
        They are only used in one method.
        
        Change-Id: Ic6fafb1518b7bc57cd1500fdbabbeb26739db291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158624
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-30  Rico Tzschichholz  <ricotz@ubuntu.com>  [31fb3045dabdb27d913712f3abcade315e3ea9bd]

        sw: Drop superfluous template class definitions to avoid linker failure on arm
        
        workdir/CxxObject/sw/source/core/access/accdoc.o:(.data.rel.ro+0x41c): multiple
        definition of `typeinfo for sw::FrameFormats<sw::SpzFrameFormat*>';
        workdir/CxxObject/sw/source/core/access/acccontext.o:(.data.rel.ro+0x1d8): first
        defined here
        
        Change-Id: I1ba9db69a73bd205a9a90cc11259abcadf62a082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156737
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-10-30  Attila Szűcs  <attila.szucs@collabora.com>  [b40e469887d973e1eea242749a90c3c2370da3a5]

        tdf#157663 SW: fix redline continueing a move
        
        Subsequent moves generated new MoveID's, like if they were separete moves.
        That cause moves to forgot their other parts.
        
        Now, if we move a redline that was moved by us it will re-use its moveID
        as if it was just the continue of the previous movement.
        It does not work if we move more then 1 of our own movement redlines
        
        Note: There are complex cases what it cannot handle.. in those case it
        just use the new ID, so the newly moved part, will forgot its relation
        with the old move oroginal parts.
        Complex case is like.. if we move 2 of our own move redlines,
        that means there will be 2 MoveId we would want to continue, but only 1
        insert redline to write that MoveID.
        But as long as we moved only 1 of our redlines it will work, even if
        there are more text redlines, even move redlines of other author.
        Other move redlines will be separate move anyway.
        
        Note2: In complex cases, we may could connect movements.
        Or we could split the new inserted move part.
        but those are design questions, they may be not good idea..
        and the split one is probably more work to implement.
        
        Change-Id: Icb2adf43272181c6a63a4a84750352f4b163383a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158473
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158615
        Tested-by: Jenkins

2023-10-30  Attila Szűcs  <attila.szucs@collabora.com>  [5e726afaf08c8cc59124d9551bb083220a38821e]

        SW: fixed redline SwPosition update problem
        
        When nodes are removed, SwPosition nNode is updated,
        but its nContent is not.
        If nNode change from a non-ContentNodo to a ContentNode, then it is
        a problem, as nContent 's m_pContentNode remains nullptr, so the
        Position seems to be inconsistent.
        
        Now when redline remove nodes, it check what redlines may effected it,
        and update them after the node deletion happened.
        
        Probably this bug should be handled deeper, as this problem probably
        effect every SwPosition.. not sure if it can be a problem elsewhere.
        
        A special case when it happens, if there is a Table between 2 text.
        And there are 2 redlines..
        1: any redline positioned 'text start'-'table start'
        2: delete redline: 'table begin'-'table end'
        now if we accept the 2. redline .. that remove the table
        the 1. redline position will change to: 'text start'-'next text start'
        but its end's nContent.m_pContentNode remain nullptr
        so lcl_CheckPosition(...) will assert
        
        Change-Id: I2981fd0218a375994d3f55cb5d3463b17ca35849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158456
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158614
        Tested-by: Jenkins

2023-10-30  Attila Szűcs  <attila.szucs@collabora.com>  [a1c3ac4205226f192b94a36a912e915b959043d7]

        SW: small fix for manage changes dialog.
        
        Fixed a continue, as it was planned to effect the outer loop.
        (probably when it was replaced to an inner loop it was forgot to handle)
        
        fixed a nullptr check also.
        
        These problems may not result real problem right now,
        but when interdependedt redlines will be improved,
        they will result in problems.
        
        Change-Id: Ie139f9a657abbacea9450176d2fe138392beddfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158457
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158613
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-30  Attila Szűcs  <attila.szucs@collabora.com>  [2c3f731992a294d4f35b41193af034fe9a6dd65c]

        tdf#157663 SW: reenable move recognition improvements
        
        Re-enabled the improvement of move recognition in redlines, that
        is able to recognize movements split into more redlines.
        
        Probably it does not effect performance too much, but if in some cases
        it would become a problem then this small patch can be reverted easily.
        
        Change-Id: I6598d4d4f98f472f3972aec41b82ec26d90db860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158455
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158612

2023-10-29  Paris Oplopoios  <paris.oplopoios@collabora.com>  [e123c772db8a12a37dfa14370b9db7c220f33ef1]

        sc: Test numeric conditional format text rule exports correctly
        
        Change-Id: Ib57ea44912b4cb0be7cbdb127dd7ea6f08ec8392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158498
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-29  Paris Oplopoios  <paris.oplopoios@collabora.com>  [ac0a4b7c22b65325b3502cde3e05e106136c4f5b]

        sc: Export conditional formatting expression correctly for text rules
        
        Text rules like BeginsWith would discard the expression if it was a
        number when exporting, which is not what is supposed to happen - as
        something like a conditional formatting rule BeginsWith "1" should be
        valid.
        
        Change-Id: I2d53754c462403f20b1991fa201184fcab3616a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158494
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-29  offtkp  <parisoplop@gmail.com>  [6d423ed9bb89da15bfd9ac3555cb01696458fa71]

        CppunitTest_vcl_animate: use CPPUNIT_TEST_FIXTURE
        
        CPPUNIT_TEST_FIXTURE is easier to write tests for and separate if needed
        
        Change-Id: I2c478205847e4d15c0f8d65d498dd8d82079fa5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158616
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b39360edc104f4ecfed1228b08812388f5126a1]

        crashtesting: dependency tracking doesn't parse ocRange
        
        so only the args passed to ocRange are seen, not what range is
        created from those args, so the dependency detected is just the args
        and not the result
        
        seen with forum-mso-en4-457928.xlsx
        
        =SUMPRODUCT(--(LEFT(TRIM(Summary.Sections.Type),2)=F24)*Summary.Sections.QCount)
        
        Summary.Sections.Type is
        Summary.SectionType.Start:INDEX(Summary,,COLUMN(Summary.SectionType.EndCol))
        
        Summary.SectionType.Start is
        $Summary.$BD$7
        
        Summary.SectionType.EndCol is
        $Summary.$BG$7
        
        So $BD$7 and $BG$7 are detected as dependencies, but we are really dependent
        on the $BD$7:$BG$7 range, so $BE$7:$BF$7 is not seen
        
        Change-Id: Ia06fe4cb0845994d0221f020cf26ba20866624ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158625
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [798d21e2a1b8bc48b6bb5e1b3cf0cba0e5882a59]

        tdf#157965: UNO methods are expected to return sizes in mm/100
        
        Commit 9e92a17cb6e03beedeeca40bfc8524c2623d31eb made sm to always
        use twips; before, it used mm/100 except in LOK. That change broke
        the size values returned from XRenderable::getRenderer: instead of
        mm/100, the resulting values were in twips, but handled as mm/100.
        
        Set the printer's map mode to use mm/100s explicitly. Also use
        mm/100s in the call to SvxPaperInfo::GetDefaultPaperSize.
        
        Change-Id: Id7cf40d4bc19c92dc54ca03d81f25ba1f6bf25b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158622
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ee7d7fa79eae4979ed45f757430664b333faad1f]

        Drop pointless print format limitation of PDF export
        
        PRINT_SIZE_NORMAL is the default, so will be used anyway, when export
        doesn't provide an explicit value. Preventing an explicitly provided
        value is wrong.
        
        Change-Id: I4781f429741f3882cc9c716839763ccddfc07652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158619
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [66937039f5b627f0486b116266c80612238e80b3]

        Only decrase zoom on fit-to-page printout when printing frame
        
        Change-Id: I51466924823bc574acfed6cff9fbd1bc4c77931b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158618
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [9278577e8f3a3d8a65a3a02c2d4c59b5fa4c26ec]

        Drop some intermediate conversions to pixel
        
        Should improve independence of results from resolution. Some output
        devices are not even pixel-based (e.g., PDF output).
        
        Change-Id: Id4359bfa0d7ba76ac4e4694c3ae4f042a780cd53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158620
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [7605de7303f57c1320d96d5ff833f492d002cfb7]

        Subtraction could wrap
        
        Change-Id: Ifc248835a70ee593e47d50bb0e1bf9165eb06391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158623
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Attila Szűcs  <attila.szucs@collabora.com>  [e4fb4937b3f75ce3544f8de354ed92f7dd314511]

        tdf#157663 SW: Tracked change improve move
        
        Made accept/reject handle move redlines other pair, (moveto-movefrom)
        and handle the whole move redline, even if it is split into small pieces
        that separated from each other.
        
        Added unique ID to every move redline to help find their other parts.
        This move ID is generated in case of:
        move recognition
        moveing a paragraph. (directly create move redline with unique id without
        calling the recognition it is faster and more stable)
        
        (there are other cases that could be improved to not use recognition,
        but generate ID directly, like moveing selected partial text with mouse)
        
        Implemented the odt export/import of this move ID.
        it is a tag like this: "<loext:move-id>4</loext:move-id>"
        next to creator/date
        
        Improved the docx import to generate this move ID, so move redlines can
        find their other parts
        (Not changed Docx export... it works a bit, but far from perfect)
        
        Improved move reckognition:
        It can find them even if they are split into multiple parts differently.
        (like "ab"+"cd" == "a"+"bcd")
        Disabled this because of probably performance issue.
        
        made a complex unit test for it.
        
        Note: Left the move recognition on every place, to avoid as much
        regressions as possible.. but in the future, we may can disable it
        in some cases.
        Note2: We will have to keep move recognitnion, because there are documents
        from past, saved without any move informations in the file, and users
        expect to see move redlines there. (generated by the recognition.)
        
        Change-Id: If968d4235b676c5e538cfaf4187a4482a86eae9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157740
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158611
        Tested-by: Jenkins

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [81f36caea6acd3042d42625940a9396305f5569c]

        tdf#157966: fix "Fit to page" printing option
        
        Regression after commit bf4bbc3c2174b21577b8878bc3197923ba44a029
        (replace std::max(std::min()) with std::clamp, 2020-11-16).
        
        Change-Id: Iada43ba352cbfb5ea597c72c871b47beb2d766c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158617
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5e24b43355d0730ced1b119eb2a99e165ea58815]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8d3fdc2402fbb7a2e0ebff6921e310d9a7b74af
          - tdf#155876 UI cmds Calc-View Zoom menu (10)
            
            + refactoring
            + WIP wrt Zoom
            
            Change-Id: Iaecb1a48fb32312f98376b32763b9dbe72e53814
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158621
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bfeeb4c8a04fecc0041056b1dae66cc978c44043]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a7af8662da76f6e65249a263dfa1c85501cad2f
          - tdf#155876 UI cmds Calc-View menu (09)
            
            + refactoring
            
            Change-Id: Ib102085446d6e50ec1bef2f87f08c4088eda93d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158596
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf784dac04e693d41b10fada38451ace99803b48]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a8338a2bf045393580e0db745e04b47624e4fea
          - tdf#155876 UI cmds Calc-View menu (08)
            
            + refactoring
            
            Change-Id: I0f8fa1f36ff535fd21dd0aaab468b122c359c5fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158595
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-29  Thorsten Behrens  <Thorsten.Behrens@CIB.de>  [d97e0458914991214e3d396273862855aff66234]

        vcl: no raw pointers
        
        For ImplJobSetup. Also, check memcmp mem size more properly
        
        Change-Id: Idcf20bf1b51bc2508f3d37e018efd18e591a6099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/26648
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-10-29  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [c75cac85230d3899fe9f5f5086c117e4e1e5d330]

        tdf#155887 WMF Fix displaying images with size of EOF other that 3
        
        The size of W_META_EOF (record indicates the end of the WMF metafile)
        could be different than 3 (e.g. 6).
        The MS Office is allowing different sizes of EOF,
        and just properly finalizine parsing WMF file, and display its content.
        
        Original bug report:
        https://bz.apache.org/ooo/show_bug.cgi?id=42090
        
        Change-Id: I21b72615c7f45fdca145e6240c6451d7d264d238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153204
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-10-29  Noel Grandin  <noelgrandin@gmail.com>  [c4699cef5c26d726273cf2305bed235edcf49ad7]

        simplify calculation in AlphaMask::BlendWith
        
        spotted by mkaganski
        
        Change-Id: If009be48a10ee5c7066a19b969212d10b9f6a83c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-29  Szymon Kłos  <szymon.klos@collabora.com>  [ecdb3d6e8dd24d2e75a16f181c0ba565a101408f]

        Use better approach to translate simple conditional formatting dialog
        
        it will allow to reorder words in case of languages with
        different order
        
        Change-Id: I942d77d996d7cf1a3186357a5a899c3c347e516e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158609
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [ac296a9b21193ac492da17b7510dff9bdd855aad]

        Simplify a bit
        
        Change-Id: Ib9e3cb046ac5b3b6af8308cda02f20c3575d15d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158608
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [63ae3bd49834b9961f43b5a082ec809878acb891]

        ofz#63518 don't allow short read with PHOTOMETRIC_YCBCR format
        
        which the old parser didn't support
        
        Change-Id: I63e426f57e893b13dd800f4af1ed4b50751dbb2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-29  Szymon Kłos  <szymon.klos@collabora.com>  [42811537c8536330e21fd6cee7561294a177836a]

        Allow to enter text in simple conditional formatting dialog
        
        We have rules for test values like: "contains text".
        Better to use formatter which will be used only when needed.
        But it is possible to use Less or Greater even for text
        using the lexicographic order.
        
        Strings in quotes are interpreted as text.
        Strings without quotes are interpreted as refs to columns/rows/ranges.
        
        Change-Id: I1f63b3f4b2a878e55d405a030dd3ddf47305e220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158538
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-29  Noel Grandin  <noelgrandin@gmail.com>  [f02cd897a4605192dd4034e4893ae9aedb9dad4f]

        use more TempFileFast in TestPDFExportFODT
        
        Change-Id: I27bf3b3c15fccec80af322b3d4653c4b41ec80e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-29  Paris Oplopoios  <paris.oplopoios@collabora.com>  [f8f8d5ec4568a10dc77144369f52b2dd165e66c5]

        tdf#157930 Add button to switch to range view in condformateasydlg
        
        Add a button that minimizes the dialog to make it easier to choose the
        conditional formatting range in the condformateasydlg. Also added more
        spacing.
        
        Change-Id: Ibf90e1d44c5555af2ab7a5c7bdb0bb2fa6c11d58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158555
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-28  Noel Grandin  <noelgrandin@gmail.com>  [d63bcfe3dde8cf873c897dbbe73fe8db38aaa70f]

        use more TempFileFast in BinaryDataContainer::Impl
        
        Change-Id: Iea16260cd152e1c495e7713ada812265dbb5b702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-28  Patrick Luby  <plubius@neooffice.org>  [7a1250b17cb671d3f57f13842ee3df8c49f8af19]

        Fix testDelayedScaleAlphaImage unit test
        
        Do not return the alpha mask if it is awaiting pending scaling.
        Pending scaling has not yet been done at this point since the
        scaling is done in the code following this block.
        
        Change-Id: I995d7f7eca4190f0a8b2094928bd92f718f1d5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158599
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4273ebd28b9d3f50797f9e2dede0d9e8ce26e6f0]

        upgrade libtiff to 4.6.0
        
        Change-Id: I839f78e5431caac378ce936aa5e34357144ae6b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158593
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [e7aa16be823877f2273e75a4e8fe646c28b73731]

        Move Impl_Print from SmViewShell to SmDocShell
        
        All functionality is in the latter, anyway. This move allows
        to exclude dependency on existing views from SmModel::render.
        
        Change-Id: I3dff855b7f25089439c8afc57904a25a48fd127b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158594
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [8dda6270f8b9af6fcfba2a3a935612ab5a81c247]

        pPrinter may be nullptr
        
        E.g., calling storeToURL, generating a PDF, on an embedded formula.
        
        Change-Id: If74af90f9c3dfd54a328782ddecd0adf52b51a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158591
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-28  Szymon Kłos  <szymon.klos@collabora.com>  [50abd90d739410ed34de5e7cd9c4308dc75f9ab6]

        Introduce easy to apply cond format styles
        
        UNO commands for Data bars and Color scale conditional
        formatting now can be called with parameter to apply
        few predefined themes.
        
        In the future it could be moved somewhere so it could
        be configured from the UI maybe...
        
        Change-Id: I080709709fcc0886dcaf6050a6c1ae621b6728c9
        (cherry picked from commit c8d4a99082269c7008df5765232a93d19e7a3d84)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158539
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7269df74824bdea31b9d42d1e2d77b77e702b3ab]

        ofz#63646 avoid Timeout when document fails to load
        
        Change-Id: I84db71486c42b74bd2bf7ff2c5469938802ee113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [2a302e143d4c6b1fc26aee6fdb53e876166d0340]

        CppunitTest_sd_png_export_tests: relax test a bit
        
        See https://gerrit.libreoffice.org/c/core/+/158341
        
        Change-Id: I8a5b326063bef0cbd2d2c71a0f0650c8298c6514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [dd278812a456148e6d4326f6013b738b48140bb0]

        Simplify a bit
        
        Change-Id: I50b7ec4a38a9489f2712bbe99fd3377c78f579b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158590
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3a23b1fcdb6ee05880d9a30cea2f35b11b885f4f]

        Fix typo
        
        Change-Id: I662b35eeba752f84a950be8653622c05d8538d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158589
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e415a1117dd10621b7db5cdf9165a9f1f707596]

        Fix typo
        
        Change-Id: Id34e34b8f2bbd903f60d293783031a728a6da8ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158587
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [341e15b7ba159527460f93922091bb575a525d79]

        Remove executable bit on ods files
        
        Change-Id: Icd14fa8490f4e80451cb016a9d111b887c3d65ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158588
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f96c2615d551b956b9a5b5148b1779206c6ca7fe]

        Remove exec bits on odt file
        
        Change-Id: Ib3d0214f3aa89005bdbda6770a983fba1bd1ffe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158426
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9922cb718adf5c12f0fbc60770e071f7e922c32a]

        Fix typo
        
        Change-Id: Ic34324139bb02ff72d68f59ff761b4491f17322e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158586
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-28  Noel Grandin  <noelgrandin@gmail.com>  [4d85dfd54942e1fc442f3d1a424207ab61b65806]

        use more XModel3::getArgs2
        
        to avoid needing to query other, rather expensive properties
        
        Change-Id: I34ebc7a03e468f0a7fa9964954e5690ad336016a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [4a4e8a7aa2c9631f199014c125a1a926d327a005]

        Fix variable names according to documentation
        
        Change-Id: I8a5b675a124b3f229ec71fc56aae27038aeedeb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158558
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-10-28  Julien Nabet  <serval2412@yahoo.fr>  [72256e0962e74b4062c63569f5bda4fc80559bef]

        Fix WASM TB following 217f23f6437b1cac10fb4ea09b72fa896d46bd6b
        
        /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/solenv/gbuild/Package.mk:35:
        *** gb_Deliver_deliver: file does not exist in instdir, and cannot be delivered:
        /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/instdir/share/config/soffice.cfg/modules/scalc/ui/conditionalformateasy.ui.  Stop.
        
        Change-Id: I5e83a1aff45bb1d818940daae2675ea50ab2e488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158585
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-28  Heiko Tietze  <tietze.heiko@gmail.com>  [97d3d4f371f82704dba907975e6cfdaac456fe4d]

        Resolves tdf#156227 - More appealing feedback for find/quickfind
        
        ErrorMessageType removed in favor of an infobar-like label
        Accessibility notification added for the quickfind bar
        
        Change-Id: Iec2498d04152392b3e181146005bdb0c9db8ec50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156943
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [00e02dd832988ec3e7f37569c932ed66e1eb6efd]

        tdf#155887 Add individual WMF records validation
        
        In previous implementation, there was no proper validation
        of the records, by it's size.
        This commit adds validation of the WMF records.
        
        It would allow to interrupt reading, if wrong record found
        and play only records until it it correct.
        
        It will allow to mimic the behaviour of MS Office:
        If the wrong record is detected, the image is displayed till the wrong record.
        
        Currently in LibreOffice, if wrong record is found whole read is interrupted.
        
        Change-Id: I0c82deabcec7a416ca44540e693822f1986437eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153351
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [d33f5a5783e025fe7a66bc09e1a55b4fa71d629d]

        Simplify calculation
        
        ... after commit 9b5a00d2281bebaac5fccfde17de6ca5134fc229.
        
        It passes a sanity check:
        
            for (sal_uInt16 nGrey1 = 0; nGrey1 < 256; ++nGrey1)
            {
                for (sal_uInt16 nGrey2 = 0; nGrey2 < 256; ++nGrey2)
                {
                    const sal_uInt8 n1 = static_cast<sal_uInt8>(
                        255 - ((255 - nGrey1) + (255 - nGrey2) - (255 - nGrey1) * (255 - nGrey2) / 255));
                    const sal_uInt8 n2 = static_cast<sal_uInt8>(nGrey1 * nGrey2 / 255);
                    CPPUNIT_ASSERT_EQUAL(n1, n2);
                }
            }
        
        
        Change-Id: Ib4b4e700a50027fb502767d72843b271f993f9c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158582
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [df5bb1387b5c7a30e15aad7811a3c0f0d3fe44c8]

        Simplify a bit
        
        Change-Id: I3926cb84f3c82adf43dcd641f41cdfa3217a8efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158567
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [b7d2a9c824aca1a4dfd1b857a3620e73ade6bc0d]

        tdf#135586 sw a11y: Use BLOCK_QUOTE role for "Block Quotation" para
        
        If a paragraph is using the "Block Quotation" paragraph style,
        report the newly introduced BLOCK_QUOTE a11y role for it instead
        of the PARAGRAPH role.
        
        This is similar to how the HEADING role is reported when
        one of the paragraph styles for headings is used
        (s. `SwAccessibleParagraph::GetRealHeadingLevel`).
        
        This is also in line with what is documented for mapping
        LO elements to tagged PDF elements in
        sw/inc/EnhancedPDFExportHelper.hxx:
        
        > * Mapping of OOo elements to tagged pdf elements:
        > *
        > * OOo element                              tagged pdf element
        > * -----------                              ------------------
        > * [...]
        > * SwFormat Quotations                       BlockQuote
        
        This makes the Orca screen reader with the gtk3 VCL plugin on Linux
        and the NVDA screen reader on Windows explicitly announce a paragraph
        as block quote when moving there with the cursor.
        
        Adapt some places that have specific handling for the
        PARAGRAPH role to take into account the BLOCK_QUOTE
        role as well.
        
        Change-Id: I4a89625c2a3f07d37df09e68cb7045a59cfff633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [f44eae4912e8f2ba34d93a71a609473df976a2cb]

        tdf#135586 a11y: Add a new BLOCK_QUOTE a11y role
        
        A block quote role exists in all of WAI-ARIA 1.3
        (role "blockquote", [1]), IAccessible2
        (`IA2_ROLE_BLOCK_QUOTE`,  [2]) and AT-SPI
        (`ROLE_BLOCK_QUOTE`, [3]).
        
        Take over the definition that is the same in WAI-ARIA
        and IAccessible2:
        
        > A section of content that is quoted from another source.
        
        The intended use for now is for a Writer paragraph using
        the "Block Quotation" paragraph style, similar to how the
        HEADING role is used for paragraphs using a corresponding
        paragraph style.
        
        For gtk3 (ATK) and winaccessibility (IAccessible2),
        map the new role to the equivalant roles.
        
        For macOS and the gtk4 as well as the Qt-based VCL plugins
        on Linux which currently don't have an equivalent role,
        fall back to the same role that the PARAGRAPH role is
        mapped to.
        This way, the behavior there will remain unchanged
        once the BLOCK_QUOTE role is used for Writer paragraphs
        with the corresponding style.
        
        In general, treat BLOCK_QUOTE like PARAGRAPH
        in code applying special handling for the PARAGRAPH
        role.
        
        [1] https://w3c.github.io/aria/#blockquote
        [2] https://github.com/LinuxA11y/IAccessible2/blob/3d8c7f0b833453f761ded6b12d8be431507bfe0b/api/AccessibleRole.idl#L318
        [3] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/7cc4cee53ddbd22631fd110f0e5ce045dec2e411/xml/Accessible.xml#L615-616
        
        Change-Id: I248c183a2e7ec5d6f0a89bf3cb4829bbd8588c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158573
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [33061be5a7538409839dcca3116b9fa72629013f]

        tdf#135586 wina11y: Make role mapping more explicit
        
        The previous `ROLE_TABLE` looked like it might
        explicitly map the UNO role on the left-hand side
        to the IAccessible2 role on the right-hand side,
        and the comment also said so.
        
        In reality, the UNO role on the left hand side was
        not really accessed, but the assumption was that
        the index of each entry would correspond to the
        sal_Int16 value of the UNO role
        (`css::accessibility::AccessibleRole`).
        
        Make that mapping more explicit by replacing
        it with a helper function
        `lcl_mapToIAccessible2Role` and slightly
        simplify `AccObject::UpdateRole`.
        
        Change-Id: Id02553c4df042982f92fce3338077e95db687a83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158572
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [0775ae4dec529505e1d108b2806f90040721e054]

        gtk4 a11y: Map more a11y roles to gtk equivalents
        
        Most of these have a direct match in Gtk, the others
        are fairly similar.
        
        Helpful:
        https: //w3c.github.io/core-aam/#mapping_role
        
        Change-Id: I1575943dc44b6c41a54d35eaef0e8afdf64d1bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158566
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7fff4e2ca6739928f72e5f0d2eb5820823916769]

        update credits
        
        Change-Id: I9ca75498e8f0df14fab318c54f0b29805ccfe3a3

2023-10-27  Szymon Kłos  <szymon.klos@collabora.com>  [47ee01c28701e22e55a9ef7d66e0836c5a0a5899]

        Make simple conditional formatting dialog translated
        
        Followup for commit a9f6f63d21e368fe6bcc9080fd1ba23bcccc0e52
        sc: Add easy to use conditional formatting menu
        
        - make strings translated
        - add more conditions
        - TODO: add other missing conditions
        
        Change-Id: I0d25b3352067e7006b88f42f3401d4670b3a5061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158536
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9775af227eded1ccdfa5750689533b429558cf3a]

        Resolves: tdf#157891 arrange so 'ok' in paste special is default action
        
        for return.
        
        Set the "all" checkbox explicitly as the widget to have the initial
        focus, all platforms then agree on where focus starts, and return will
        activate the default "ok" button.
        
        Otherwise, vcl picks the "value" button and gtk picks the "link"
        checkbox and there is an inconsistency as to what "return" activates by
        default:
        
        Change-Id: I894199069a32f4e09e2661f2c90338caacb8c65d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-27  Stephan Bergmann  <sbergman@redhat.com>  [f029f8dfb05fbbe2d698fe3411cd37f8ae7a02a2]

        Various -Werror,-Wvla-cxx-extension
        
        ...as enabled by default now in recent Clang 18 trunk
        
        Change-Id: I59f9bbdf2ce064f170df01e6d7ec2341884ab5e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158563
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d86a0b632813efb2259b795b272f8aa40a7c768]

        tdf#152571 speedup slow draw file save
        
        with lots of images, we seem to spend lots of time calculating
        CRC. Replace the vcl checksum/CRC with rtl_crc32 in sal/, which
        forwards to the zlib implementation, which has all kinds of
        nice SIMD code for performance.
        
        Change-Id: I295e2ee91b3450fa558b06e67aac0fbb20b85f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-27  Noel Grandin  <noelgrandin@collabora.co.uk>  [9b5a00d2281bebaac5fccfde17de6ca5134fc229]

        fix erase logic in SkiaSalBmp::BlendWith
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I5cefa51c96d412f43f73277b590fd861397eb1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [67803125b17f1231b5a436883ebc77baa52a5d4f]

        merge these checks together to avoid duplication
        
        Change-Id: I2821a48696a1661fa6e7cf94fc1649c51f2b4e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158564
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-27  Marco Cecchetti  <marco.cecchetti@collabora.com>  [f3b20f31d55f304ed9d4a3eb257bf9d468fffe5f]

        lok: a11y: impress: help screen reader to report shape selection
        
        Refactored LOKDocumentFocusListener::notifyEvent.
        
        Implemented 2 new callbacks:
        - LOK_CALLBACK_A11Y_EDITING_IN_SELECTION_STATE: it says the client if
        editing in a shape or cell is active or it isn't.
        - LOK_CALLBACK_A11Y_SELECTION_CHANGED: it says if a shape has been
        selected/unselected, the name of the shape and text content are sent
        too for being reported by a screen reader.
        
        (cherry picked from commit 76899152ec3d1924cc72d2b869e197a1e34a0a1a)
        
        Conflicts:
        	sfx2/source/view/viewsh.cxx
        
        Change-Id: I644bcc7daeb8772805688a9bccdabd0631ce0a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158562
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-27  Paris Oplopoios  <paris.oplopoios@collabora.com>  [217f23f6437b1cac10fb4ea09b72fa896d46bd6b]

        tdf#157930 sc: Add easy to use conditional formatting menu
        
        Add menu options that open a dialog that can add conditional formatting
        in a cell range with common options.
        
        Change-Id: Ia54baba08e4b78c4c6e37fa7bff744af8cf06037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156831
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [334d3aff8d411ee5f2d612c8899a171716b8a3d1]

        calc comment boost::property_tree::ptree use quotes comment id numbers
        
        which does not conform to JSON standard and means that added/deleted
        comment ids are strings and not numbers as created by the related
        getPostIts
        
        found during: https://github.com/CollaboraOnline/online/issues/7334
        where if the regular updating of comments via getPostIts doesn't happen
        then deleting/adding comments doesn't appear to work
        
        boost bug report found as:
        https://svn.boost.org/trac/boost/ticket/9721
        https://marc.info/?l=boost-bugs&m=139351272302586&w=2
        
        Change-Id: I0c43588ce1f92b83fb82c582f0c2c18a6672dc54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-27  Michael Weghorn  <m.weghorn@posteo.de>  [2186fd52d1ef909d4398e84408f76c8357718e1e]

        gtk4 a11y: Implement GtkAccessibleRange iface
        
        Implement the `GtkAccessibleRange` range interface [1]
        added in gtk 4.10, which is bridged to the AT-SPI Value
        interface on Linux inside gtk.
        
        Also set the related properties to their values retrieved
        from the `XAccessibleValue` interface. (Those already
        existed before gtk 4.10.)
        
        The GType handling for implementing the interface only
        if the `XAccessibleContext` of the underlying LO a11y
        object implements `XAccessibleValue` is mostly copied
        over from the gtk3 a11y implementation
        (in vcl/unx/gtk3/a11y/atkwrapper.cxx) and adapted
        a bit.
        
        Let `lo_accessible_range_set_current_value` always return
        true independent of whether the given value was actually
        set, since LibreOffice (together with Accerciser)  otherwise
        crashes due to no proper DBus reply being sent, when
        trying to set a new value via AT-SPI API, s.a. [2] and [3].
        
        When setting a new value, take the type of the current
        value into account, as done for gtk3 in
        
            commit a0b7b47e3ec843d8012a7526c1e8e72d67cc41b1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Oct 24 12:29:54 2023 +0200
        
                gtk3 a11y: Take current type into account when setting new value
        
        With this change in place, the AT-SPI Value interface
        is now shown as available for a checkbox form control
        in a Writer doc when selecting the corresponding a11y
        object in Accerciser's tree view of the LO a11y hierarchy.
        When changing the value via Accerciser, the checkbox in
        LibreOffice gets (un)checked as expected. (Setting the
        value to 1.0 causes the checkbox to be checked, 0.0 to
        become unchecked.).
        
        The initial values (current value, min and max value)
        are set properly. However, when querying the current
        value after changing it, the initial value is still
        returned. This likely needs to be addressed by
        bridging the corresponding `AccessibleEventId::VALUE_CHANGED`
        event to Gtk/AT-SPI by calling
        `gtk_accessible_update_property` with the new value.
        However, there's currently no implementation for
        handling a11y events in the gtk4 VCL plugin yet, so
        leave that for later.
        
        More interfaces to expose more functionality
        to the a11y layer will likely be implemented in
        upcoming gtk versions (like an interface for Text [4])
        and bridging those should presumably be possible in a
        similar way.
        
        [1] https://docs.gtk.org/gtk4/iface.AccessibleRange.html
        [2] https://gitlab.gnome.org/GNOME/gtk/-/issues/6150
        [3] https://gitlab.gnome.org/GNOME/gtk/-/commit/0dbd2bd09eff8c9233e45338a05daf2a835529ab
        [4] https://gitlab.gnome.org/GNOME/gtk/-/issues/5912
        
        Change-Id: I84136fd80361d21cf4f79ab17118bb14079ab785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158556
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-27  Stephan Bergmann  <sbergman@redhat.com>  [30027d95f96e8732292391721da8d126c8896fec]

        Step 2 of removing cargo-cult pragma pack around rtl_[u]String
        
        see 8ae3ae4bf75fdd0aaa132c956d9da029baa3adc6 "Step 1 of removing cargo-cult
        pragma pack around rtl_[u]String"
        
        Change-Id: Ie9140b92da8895c4991a7f449359bb1747fdb23d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158553
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a30ea52e5e98d2c455e69194fa401a8275bd111]

        remove unused vcl_get_crc64_table
        
        Change-Id: I8ebc2473884ad991a704c7e0955f262bccbf6dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-27  László Németh  <nemeth@numbertext.org>  [e079bb35429603988d2fd4ddf18b0f501a847a2c]

        tdf#157937 sw: fix freezing of cycle case on tracked changes
        
        Add loop control to avoid never-ending iteration on selected
        text with tracked changes, where transliteration can result
        empty strings.
        
        Regression since commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9
        "tdf#109266 sw change tracking: track transliteration".
        
        Change-Id: Ia5f92adfdda33562b4d1abe72c51134be8304639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158525
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-27  Szymon Kłos  <szymon.klos@collabora.com>  [514b182086d493efd3785e2f3092216c74f43dec]

        jsdialog: send smaller messages for combobox
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ib514607ad56b965c33439ad548ec90d516acfcf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158345
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 9e2da48ec3dbe541ff52f6d69f98afb57afaac3e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [255ff09246008f7286d1a723cfdee47f847f5540]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53e7511706a73d0336ce183f614d53469836ef64
          - tdf#155876 UI cmds Calc-View menu (07)
            
            + refactoring
            
            Change-Id: I766345780bb12a3ba9d9c8c3135f77d4d04bc78d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158519
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f31ab9bd7dfb9c99372df1d30406811982489a38]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b41eeeaaa91ed78e387cfed551400984836164af
          - tdf#155876 UI cmds Calc-View menu (06)
            
            + refactoring
            
            Change-Id: Ic6a1cf590f8952ef82e540459603a0a499732ecf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158518
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-27  Stephan Bergmann  <sbergman@redhat.com>  [0b663a28b47ef3bfff569034e5afcd9b0b1d0f00]

        At least use the oldest available -std:c++14 for MSVC gb_CXX03FLAGS
        
        ...if we don't have a proper -std:c++03 available
        
        Change-Id: Iffef738be486b402a2b6af1a2761eb905ac4ddf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158550
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-27  OmkarAcharekar  <omkaracharekar12@gmail.com>  [ae9c207675f1144fdea8f628f370375768f1eb00]

        tdf#157096: sw_layout: Add test for CRASH removing everything in document
        
        Change-Id: I07fde27e71f112019532c57d90f46568af45fad9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158458
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c3ce373227433f40d686847a22e78651bedbab24]

        tdf#156593 FILEOPEN OOXML: image shown in full instead of cropped
        
        Revert "Revert "tdf#118133 DOCX import: disable lazy-loading of tiff images""
        
        This reverts commit c6bf16909db054ec5467ebdc0ea0c9dc07307048.
        
        Lazy-loading doesn't work with cropped TIFF images, because in case of Lazy-load TIFF images
        we are using MapUnit::MapPixel, but in case of cropped images we are using MapUnit::Map100thMM
        and the crop values are relative to original bitmap size.
        
        Change-Id: I2dbf6caf08d7899ec2eae683996d997809d62b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158509
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-27  Stephan Bergmann  <sbergman@redhat.com>  [819f87faee0e8d629f5176a107e4b07422abea73]

        Explicitly build the ODK examples against C++03
        
        ...similarly to how CppunitTest_odk_checkapi already builds with C++03 to detect
        inadvertent uses of newer features in code that is meant to be still compatible
        with C++03.  And fix any uses of newer features that had already crept in.
        
        Change-Id: I9fb4013099c1dff2c1ad5fba8fc93d9aa4efbde8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158523
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-27  Stephan Bergmann  <sbergman@redhat.com>  [550eb0d45117836cdea2112ee37a3fd7219a90b5]

        Clarify that o3tl::cmp_* is still needed for LLVM 12 libc++ for now
        
        ...which is apparently used by Android builds, so
        <https://gerrit.libreoffice.org/c/core/+/158513> "Directly use std::cmp_*, drop
        o3tl::cmp_*" cannot go in, yet
        
        Change-Id: If8b3ef1e647b6e33c43d0fe5737daf63eda0b761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158524
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-27  Miklos Vajna  <vmiklos@collabora.com>  [435f1aadf7dd8087a8997924bedfccff0f496ba2]

        tdf#99822 sw floattable: allow nomimal overlap of objects from different cells
        
        The bugdoc had a table with a single row and 2 columns, both cells had
        too wide content. The first column had a too wide chart and the second
        column had a too wide (multi-page) floating table.
        
        What happened is that SwTabFrame::Split() wanted to recalc the split
        row, and there the overlap detection code pushed down the 2nd shape to
        the next page, but that next page only contained the 2nd shape, so the
        shifted down shape wanted to go up to its original position and this way
        the "format all content lowers" iteration in
        SwContentFrame::CalcLowers() never returned.
        
        Fix the problem by limiting the overlap detection to the same uppers,
        i.e. in case two floating tables are anchored in the same cell (the
        anchors have the same upper) to avoid the overlap, but in case the
        anchors have different uppers, then don't worry about this. This seems
        to match what Word does.
        
        Regression from commit 5127b1961b762643d47a26704556fd9b8664c6fc (sw
        floattable, nesting: add DOCX import, 2023-09-13), the original problem
        was already solved by 63007619da7e6c4a6d0c466a8fe54324252be14b
        (tdf#144798 DOCX import: handle ZOrder of chart objects, 2021-10-18), it
        seems.
        
        Change-Id: I21b9f0ae53bbc69d54a9a9f6870580e3a748ba7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158520
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5946ffe7139189eff2c1e90ddb3edb146eb60e17]

        tdf#157854 - UI: Part 12 - Unify lockdown behavior of Options dialog
        
        for Internet Proxy Page.
        
        Change-Id: I2332d272905e12a235d7729c0565922ad98960f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158499
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [860b98657ccc54210575db6b6f81de1db05512c8]

        tdf#157853 - UI: Part 11 - Unify lockdown behavior of Options dialog
        
        for Advanced Page.
        
        Change-Id: I3ef33e98cd5a39313f51eb90682f20cdc172f042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158496
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-27  Balazs Varga  <balazs.varga.extern@allotropia.de>  [89a5e1a41ca042cb29467ae953fe26cbafa9b75a]

        tdf#157850 - UI: Part 10 - Unify lockdown behavior of Options dialog
        
        for Online Update Page.
        
        Change-Id: I48f66f786c165d3958d34cca17ee2837aa7a6c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158490
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-27  Szymon Kłos  <szymon.klos@collabora.com>  [6b3b85d3f7093bc591a710394d0e81262573d72b]

        jsdialog: don't send  update in toolbox when not modified
        
        Change-Id: I74087b54f9844ea5d22de03caf8724d38d525646
        (cherry picked from commit 9d44086770d9a1c625d42676033f47a698dfa572)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158446
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-27  Szymon Kłos  <szymon.klos@collabora.com>  [70fef783162f6bb9ddf14bd863b9a284f23e9d40]

        jsdialog: enable simple conditional formatting dialog
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Id9dad789bb772f7454f4bb35c42f4fde4d9a89c4
        (cherry picked from commit fc2e0b49a6fa69a116e7a43c3c6ecb428a88f4c7)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158447
        Tested-by: Jenkins

2023-10-27  Skyler Grey  <skyler.grey@collabora.com>  [4bb1a7836abb49a9b0513958239f3998305201fd]

        Add flags to STYLEREF
        
        This commit is part of an implementation for the following STYLEREF flags
        - Search from bottom to top, which sets the STYLEREF field to search
          downwards first, or from the bottom of the page in marginals
        - Hide non numerical, which hides all characters that are not either
          numbers or punctuation commonly used as delimiters. For example, if
          your STYLEREF said "Chapter 2.1", this setting would make it say "2.1"
        
        This commit implements:
        - The document model
        - The layout
        - The UI
        
        Change-Id: I7d8f455ffe90cface4f3b1acf6b9bef6a045ed19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158349
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-27  Miklos Vajna  <vmiklos@collabora.com>  [8ad82fc115a337604c064d37adfffcc81440248e]

        sw floattable: fix nullptr deref in TableManager::endLevel()
        
        This is never an empty reference in the interesting use-case, so just
        make sure we don't crash.
        
        Reported to be a regression from
        2d43c34333076fad092f0cdc0f60f81580acdbee (Related: tdf#55160 sw
        floattable, nested DOCX imp: fix inner tbl at cell start, 2023-09-15).
        
        See
        <https://crashreport.libreoffice.org/stats/signature/writerfilter::dmapper::TableManager::endLevel()>,
        e.g.
        <https://crashreport.libreoffice.org/stats/crash_details/84c2a273-49a3-4e62-9cfe-5cd620767749>.
        
        Change-Id: I4cd9c35ae3813a67d13d9b9e60f0dd6058f510c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158508
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-27  Miklos Vajna  <vmiklos@collabora.com>  [39fcc32376bcafde8b1e582cbb5e8f23fed868ce]

        sw layout xml dump: move SwFrame::dumpChildrenAsXml()
        
        Next to the rest of the SwFrame code.
        
        So it's more likely that it gets updated as SwAnchoredObject changes.
        
        Change-Id: I83343abf495832265ac7634bb7b31de89b63f039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158511
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [48ff87e100b7aa3a519937a73076f5c38cb919da]

        Drop rTokenName argument from SvgNode::parseAttribute
        
        It was never used.
        
        Change-Id: I8bc7d625977a6cdc8fe6863037e72577dbfc46c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158493
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [009ea6f786e5a7fd1e08d768e33b5b7af30e5765]

        Commit 04c78e1a46a423071d7ea68724525ec7ef92e0e8 follow-up
        
        Drops duplicating map, and uses std::find_if with case-insensitive
        comparison. Likely to have some performance impact, but avoids the
        maintenance penalty of two maps.
        
        Change-Id: I7144556488aa134d9b9214b00ba9d7c4e0fb68a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154159
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [4a6492e155d44ef51fc9a89271f857a6f987182e]

        vcl: flatten OutputDevice::BlendBitmap()
        
        Change-Id: Idb0c21dd37af81fae0fd4152f0556edb20e63b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157190
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [d35236adb3fc561f49134a88c7468411527ee3d5]

        vcl: flatten OutputDevice::GetBitmapEx()
        
        Change-Id: I85e7767cd2665febd289cc1fd023d30ab80cfe5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157191
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [60abfe9e514d71a14b388f0156b31a4be5896686]

        vcl: move textlayout.cxx from gdi to text directory
        
        Change-Id: Ia8efd1d984c94b4fa6d77759fa8c8ec8834ac140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157415
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [adba3022f14d28090a668da10fc3311633535ae8]

        vcl: flatten TextLayoutCommon::GetEllipsisString()
        
        Change-Id: I04a5eed7a6fbd2d4c7f31006c73729cf79a2ed02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157367
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-27  Justin Luth  <jluth@mail.com>  [7ac066438f6d029fd0be2f0c72207805b0ca8153]

        tdf#156988 chardlg: default to AUTO escapement
        
        As of 24.2, the default value for a superscript or subscript
        is automatic placement since d384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8.
        
        Therefore, it makes sense for the character properties
        dialog to also default to automatic.
        
        Normally this happens - since normally there is some kind of context,
        and in that case m_xNormalPosBtn was set with AUTO (m_xHighLowRB).
        However, in the case of finding a formating, there is no context
        for the very first run. That is what this patch intended to fix,
        since in that case too we want m_xHighLowRB to be set to true.
        
        For any other similar situation where there is no context,
        assuming DFLT_ESC_AUTO_SUPER or DFLT_ESC_AUTO_SUB
        should be appropriate.
        
        Change-Id: I1ee78c72bbb1c3d23fa39da29322436632f12b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158514
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b5b50c1fe3bec22a0061d118be1ba3757ce765b0]

        cool#6893 cache the process component context
        
        which we look up rather a lot
        
        Change-Id: Ie8bcf161a1d7a299a404f749cf08a13f33f7f1cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158506
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-26  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [5a59e6bf5a2590e93ec520b5d736b15d981804fe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bcef222378f8d2225596ea624f9c82e9cb48a01d
          - add link to langpack downloads
            
            Change-Id: I237e89e0263cdf27105cf4395d2272f9d96e2235
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158444
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-26  Stephan Bergmann  <sbergman@redhat.com>  [fa91d0a3e82899290104b06ad1c8f2519d67fa1c]

        Replace use of "Calibri" and "Calibri Light" with "Noto Sans"
        
        ...in CppunitTest_chart2_xshape, which had caused
        <https://buildbot.flathub.org/#/builders/6/builds/75165> to fail with
        
        > diff.cxx:324:Assertion
        > Test name: Chart2XShapeTest::testTdf149204
        > assertion failed
        > - Expression: valInTolerance
        > - 3511; Found Value: 3485; Tolerance: 1; Relative: 0
        >
        > diff.cxx:265:Assertion
        > Test name: Chart2XShapeTest::testPieChartLabels1
        > double equality assertion failed
        > - Expected: 8383
        > - Actual  : 8399
        > - Delta   : 1e-08
        > - Reference: /run/build/libreoffice/chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[2]
        > - Attr: positionX
        >
        > diff.cxx:324:Assertion
        > Test name: Chart2XShapeTest::testPieChartLabels2
        > assertion failed
        > - Expression: valInTolerance
        > - 3124; Found Value: 2966; Tolerance: 1; Relative: 0
        >
        > diff.cxx:324:Assertion
        > Test name: Chart2XShapeTest::testPieChartLabels3
        > assertion failed
        > - Expression: valInTolerance
        > - 3124; Found Value: 2966; Tolerance: 1; Relative: 0
        >
        > diff.cxx:324:Assertion
        > Test name: Chart2XShapeTest::testPieChartLabels4
        > assertion failed
        > - Expression: valInTolerance
        > - 2768; Found Value: 2531; Tolerance: 1; Relative: 0
        
        Change-Id: I518d37bedf7d8738396e05011223bd970786a45a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158377
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-26  Stephan Bergmann  <sbergman@redhat.com>  [b36b24ecfbb7e9fc6c5d5d0a789fabd2a0cb18b3]

        Use std::from_chars
        
        (which also makes readInt32 report failure, instead of running into UB, when the
        read value is out of range)
        
        Change-Id: I8449e4fe696c9b0ab5b868127ef517dc080c31ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158489
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2fccf0117a37f8aab8bb50ece419987f06af6b9]

        cool#6893 improve listeners in SfxBaseModel
        
        reduces CPU spent in UNO query'ing, and adds type-safety, which exposed
        a bug in SfxBaseModel::disposing
        
        Change-Id: I4b973f7dc38f491ce7a6281ad378e439b5450add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [96b91357fb93028d35d70bdb52b4bac3ecbfbf57]

        tdf#157897 - Clear print ranges before adding additional ones
        
        Otherwise, additional print ranges will be added for linked files after
        the external link will be updated.
        
        Change-Id: I0556fda6609d3e18f1ca992dc6a0399be01bc841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158365
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-26  Michael Weghorn  <m.weghorn@posteo.de>  [69b50eee1cf103229d4d774fd54b46d0ff767472]

        gtk4 a11y: Map checkbox role to gtk equivalent
        
        This makes a checkbox form control in a Writer document
        show up with the proper role in Accerciser, no longer
        as a filler.
        
        Change-Id: I5566d27ecfbe9ec54dcfbf20693899b72d3af738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158505
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ce8920448c05594f37f09c7a42ae3f3c7ccb7a1e]

        null-deref seen in ScTabView::UpdateEditView
        
         #0  0x00007f2bcc41df63 in ScViewData::GetCurYForTab (this=this@entry=0x3502d0b8, nTabIndex=nTabIndex@entry=6)
             at libreoffice/sc/source/ui/view/viewdata.cxx:1443
         #1  0x00007f2bcc3ebf02 in ScTabView::UpdateEditView (this=this@entry=0x3502d0b0) at libreoffice/sc/source/ui/view/tabview3.cxx:2185
         #2  0x00007f2bcc3ec636 in ScTabView::UpdateFormulas (this=this@entry=0x3502d0b0, nStartCol=nStartCol@entry=-1, nStartRow=nStartRow@entry=-1, nEndCol=nEndCol@entry=-1,
             nEndRow=nEndRow@entry=-1) at libreoffice/sc/source/ui/view/tabview3.cxx:2327
         #3  0x00007f2bcc40735c in ScTabViewShell::Notify (this=0x3502cf20, rBC=..., rHint=...) at libreoffice/sc/source/ui/view/tabvwsh5.cxx:216
         #4  0x00007f2bdc1885a9 in SfxBroadcaster::Broadcast (this=this@entry=0x31e31430, rHint=...)
             at libreoffice/svl/source/notify/SfxBroadcaster.cxx:40
         #5  0x00007f2bcc022e6d in ScDocShell::PostDataChanged (this=this@entry=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh3.cxx:95
         #6  0x00007f2bcc0101aa in ScDocShell::SetDocumentModified (this=0x31e31430) at libreoffice/sc/source/ui/docshell/docsh.cxx:3015
         #7  0x00007f2bcc010df3 in ScDocShellModificator::SetDocumentModified (this=this@entry=0x7fff2d168da0)
             at libreoffice/sc/source/ui/docshell/docsh.cxx:3330
         #8  0x00007f2bcc040c1a in ScDocShell::MoveTable (this=this@entry=0x31e31430, nSrcTab=<optimized out>, nDestTab=<optimized out>, bCopy=bCopy@entry=false, bRecord=bRecord@entry=false)
             at libreoffice/sc/source/ui/docshell/docsh5.cxx:1010
         #9  0x00007f2bcc441a41 in ScViewFunc::MoveTable (this=this@entry=0x333d0fe0, nDestDocNo=nDestDocNo@entry=0, nDestTab=nDestTab@entry=7, bCopy=bCopy@entry=false,
             pNewTabName=pNewTabName@entry=0x7fff2d169068) at libreoffice/sc/source/ui/view/viewfun2.cxx:3117
         #10 0x00007f2bcc418459 in ScTabViewShell::ExecuteTable (this=0x333d0e50, rReq=...) at libreoffice/sc/source/ui/view/tabvwshf.cxx:593
         #11 0x00007f2bdbd3d96f in SfxDispatcher::Call_Impl (this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., bRecord=<optimized out>)
             at libreoffice/sfx2/source/control/dispatch.cxx:254
         #12 0x00007f2bdbd427ee in SfxDispatcher::Execute_ (this=this@entry=0x33379ed0, rShell=..., rSlot=..., rReq=..., eCallMode=eCallMode@entry=SfxCallMode::RECORD)
             at libreoffice/sfx2/source/control/dispatch.cxx:753
         #13 0x00007f2bdbd45a33 in SfxDispatcher::Execute (this=0x33379ed0, nSlot=<optimized out>, nCall=nCall@entry=SfxCallMode::RECORD, pArgs=pArgs@entry=0x7fff2d1694a0,
             pInternalArgs=pInternalArgs@entry=0x7fff2d169460, nModi=nModi@entry=0) at libreoffice/sfx2/source/control/dispatch.cxx:813
         #14 0x00007f2bdbd83c0f in SfxDispatchController_Impl::dispatch (this=<optimized out>, aURL=..., aArgs=..., rListener=...)
        
        we have nulls in here for hidden sheets
        
        Change-Id: I8f1295e67552f3ec9306a031aaecd0838e18d98d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-26  Stephan Bergmann  <sbergman@redhat.com>  [0f132270b4596eb4dae669be48fc34117a687efa]

        No --without-fonts gb_CppunitTest_set_non_application_font_use,*,abort
        
        ...which had caused an (explicit --without-fonts) Fedora build to hit the
        std::abort in PrintFontManager::Substitute
        (vcl/unx/generic/fontmanager/fontconfig.cxx) during
        CppunitTest_sd_import_tests-smartart's testTdf134221::TestBody, apparently for
        some aTargetName = "DejaVu Sans"
        
        Change-Id: I3b050eb3225595e6ce22a8df22dbb11f920cac4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158492
        Reviewed-by: Dan Horák <dan@danny.cz>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [0446f73d27a0c43de1a2d5e07c9510a287be6af2]

        tdf#153519 use new IdleTask::waitUntilIdleDispatched
        
        to wait until the Idle inside sw/ has done populating the navigator
        tree.
        
        Which required
        (*) moving the code down from test/ to vcl/ to avoid circular dependency
        issues.
        (*) adding a call SolarMutexGuard before Application::Yield inside
        IdleTask::waitUntilIdleDispatched
        (*) exposing the function to python by adding a method to the
        XToolkitExperimental UNO API
        
        Change-Id: Iee418f7a0beb1f5b53addb7fe25823d61720eb3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158495
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [455a1775ccef305cfb96cc5f67c8ee47b7f3a2ae]

        crash seen in Window::ImplTrackTimerHdl
        
         #0  vcl::Window::ImplTrackTimerHdl (this=0x3403b0a0, pTimer=<optimized out>) at libreoffice/vcl/source/window/window2.cxx:231
         #1  0x00007f2bdd31f5e7 in Scheduler::CallbackTaskScheduling () at libreoffice/vcl/source/app/scheduler.cxx:485
         #2  0x00007f2bdd4e5176 in SalTimer::CallCallback (this=<optimized out>) at libreoffice/vcl/inc/saltimer.hxx:54
         #3  SvpSalInstance::CheckTimeout (this=this@entry=0x261ef40, bExecuteTimers=bExecuteTimers@entry=true)
             at libreoffice/vcl/headless/svpinst.cxx:212
         #4  0x00007f2bdd4e713d in SvpSalInstance::ImplYield (this=this@entry=0x261ef40, bWait=bWait@entry=true, bHandleAllCurrentEvents=bHandleAllCurrentEvents@entry=false)
             at libreoffice/vcl/headless/svpinst.cxx:453
         #5  0x00007f2bdd4e74a0 in SvpSalInstance::DoYield (this=0x261ef40, bWait=<optimized out>, bHandleAllCurrentEvents=<optimized out>)
            at libreoffice/vcl/headless/svpinst.cxx:525
        
        Change-Id: I66ec56603aeb8a7fe855253b961dafb0bc7b875e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158441
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6f3334a204193f9e47f60f45b17dd102148ed586]

        add warning for suspicious potential double-tracking
        
        Change-Id: I0fa7b2a108350a394b5d774aaed899215bdb20de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [6eb4cce433e5c4e905910d6dfdf6fc15065a9d3e]

        tdf#157083 Artifacts in logos (gen)
        
        regression from commit
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I1c269bcfa9b565258bc99c2810e960ae965f9b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158491
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-26  Michael Stahl  <michael.stahl@allotropia.de>  [6787d2ae5eb99ea05dae586bbe50a8aa4dab8a3e]

        sw: fix comments in SwRootFrame::CalcFrameRects()
        
        Change-Id: I1af7fd09bb2d3636b97825724a988e7912a3653b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158428
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [916ea4b0aadc61c2fdb89ac18e3e8327406bcd37]

        tdf#157846 - UI: Part 9 - Unify lockdown behavior of Options dialog
        
        for Accessibility Page.
        
        Change-Id: I4705904200715c1e41849a47a3dd684ddfa219c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158425
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [ee368cc3f97886b9574e22fdf8a15c8225e785d5]

        tdf#157843 - UI: Part 8 - Unify lockdown behavior of Options dialog
        
        for OpenCL Page.
        
        Change-Id: I94c4a1afc7703de378ae65c0173d178954f647a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158424
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [54aa9a9cb7f283d2ed2853e064573564f16e353b]

        tdf#157842 - UI: Part 7 - Unify lockdown behavior of Options dialog
        
        for Personalization Page.
        
        Change-Id: I5f2b674b9548610be8f918e6713e6ea91be7442e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158418
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6a8cae6995d22666c0a6fd2b42c171ef27ae30ac]

        tdf#157840 - UI: Part 6 - Unify lockdown behavior of Options dialog
        
        for Security Page.
        
        Change-Id: I9b5282326ea8edeb00d45d9d034a18041f89a281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158393
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9e8c90d92a6658ecc732554cb220d14eaee4692b]

        tdf#157839 - UI: Part 5 - Unify lockdown behavior of Options dialog
        
        for Font Page.
        
        Change-Id: Idd7bdf5d79269dcb5b6e3276b91f17221c3b02e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158384
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c008ab081aa5bbf53f8562e95e547deae5afc2e]

        tdf#157132: restore behaviour for TBL_RELBOXNAME
        
        Regression from 8a3dc12a13a3b9e99dbd5000ca6a1d541cf472f7
        "8a3dc12a13a3b9e99dbd5000ca6a1d541cf472f7"
        TBL_RELBOXNAME was no longer calling ToRelBoxNm
        
        Change-Id: I296d84ab955b4415bf9173ccf72b4d51e55152f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158454
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-26  Miklos Vajna  <vmiklos@collabora.com>  [d6527f127622f23ac529ce667fac5ff69ea33ea4]

        Related: tdf#157590 sw floattable: avoid a bit of not needed work
        
        See
        <https://gerrit.libreoffice.org/c/core/+/158379/2#message-b9a1e9b65b5fe7bfec6a88af19032dcef73ff920>,
        we only need to work out if this row has spans in case the row would
        split, can skip this otherwise.
        
        Change-Id: Ic61dade7f42e7e43322e902a1f91d6a62bdc0ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158414
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-26  Miklos Vajna  <vmiklos@collabora.com>  [8c39af455c4dee53c6f3c918b0497f80a4fb0f21]

        uitest oneprocess mode: default to this and clean up one test
        
        Now that all UITests either use gb_UITest_use_oneprocess or
        gb_UITest_avoid_oneprocess, it's possible to change the default to use
        oneprocess mode out of the box.
        
        Also clean up one test depend on this default. A later commit can clean
        up all other uses of gb_UITest_use_oneprocess, which is now redundant.
        
        Finally fix a typo in sw/UITest_sw_sidebar.mk.
        
        Change-Id: I6ae2ac5deb9c8ced9007c5b7da32743f9a2599ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158471
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-25  Michael Weghorn  <m.weghorn@posteo.de>  [809409ca845ff1269d3d8f516678048404d8fea8]

        tdf#135586 a11y: Make IAccessible2 an external and update it
        
        So far, there was an internal copy of the IAccessible2
        IDL file added in 2013, and never updated since then
        (except for cosmetic changes like formatting and typo
        fixes), and therefore it e.g. doesn't have the
        `IA2_ROLE_BLOCK_QUOTE` role needed for tdf#135586.
        
        Drop the outdated internal copy and integrate an up to
        date upstream version (current git master) instead.
        
        Instead of duplicating things in an internal copy,
        switch to using the usual mechanism for externals.
        
        The IAccessible2 source contains separate .idl files
        for the different interfaces, while the previous
        interal copy was already the merged IDL file.
        
        Call the IAccessible2 `./concatidl.sh` script to generate
        the merged `ia2_api_all.idl`
        (s. external/IAccessible2/ExternalProject_IAccessible2.mk)
        and adapt the winaccessibility make files to use that
        version instead of the internal copy.
        (Add a dependency to the target that generates
        `ia2_api_all.idl`.)
        
        The tarball was generated from the master branch of the
        IAccessible2 git repo [1] as of
        
            commit 3d8c7f0b833453f761ded6b12d8be431507bfe0b (HEAD -> master, origin/master, origin/HEAD, mygithub/master)
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Oct 13 04:16:03 2023 +0300
        
                Update no longer working links (#26)
        
                * Update link to Linux Foundation Trademark Policy
                * Update link to Object Attributes specification
        
                Signed-off-by: Michael Weghorn <m.weghorn@posteo.de>
        
        using this command:
        
            $ git archive -o ../IAccessible2-1.3+git20231013.3d8c7f0.tar.gz --prefix=IAccessible2-1.3+git20231013.3d8c7f0/ master
        
        Andrea Gelmini's typo fixes have been upstreamed in [2].
        
        [1] https://github.com/LinuxA11y/IAccessible2
        [2] https://github.com/LinuxA11y/IAccessible2/pull/21
        
        Change-Id: I9f19ff55694da5d3a9a8750be8de387cbf6da785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158427
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9f3e8b2546563cdabbe01838a72ed542c7f58875]

        tdf#157908   "Evaluate" -> "Include" in outline level option
        
        Change-Id: Ida8f753175eeb818378160d481a4d71e09054e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158432
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-10-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7eb1b3f3e9644a4e7ab96dded9f134cfa1df7228]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ae6c825415ce74ed8f0487acc043fd3a41c46e4
          - tdf#157908 update label change to "Include up to level"
            
              * correction to explanation of "Include up to level"
              * simplify explanation of Additional Styles, and add
                mention of "Include up to level"
              + add link to "Apply Styles" help page
              
            Change-Id: If72b7b1df5e3e5a3f18cfda86a875345866fa471
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158435
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-10-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [725c543c3b1c91d6656e6ed58006d886f83456dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69f85cbf17c5acb8fb9b38772139c34eea96a772
          - Improve accessibility of dropdown menus
            
            Now the opened menus can be closed with Esc key, so we conform
            to the dismissible success criterion in WCAG 2.1:
            https://www.w3.org/WAI/WCAG21/Understanding/content-on-hover-or-focus.html
            
            To simplify things, now the navigation lists are populated upon
            page load in all cases.
            
            Change-Id: I0a7daaea122d3e03de36c322ccb012c546b271e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158429
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [9299afbbd6bd264ba90e5e0ac21a700e88f56c0f]

        Export text placeholder fields as PDF form fields
        
        Inspired by commit 82d90529dc2b3cb8359dec78852cbd910a66d275
        (sw content controls, rich text: add initial PDF export, 2022-09-12).
        
        Change-Id: I16cc45b6f2e070ab9dc83ba15e3c66ca0caa5e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158407
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [ec54e7330ad3bbada1bfabd58a3fe66cef69a0ce]

        Simplify SwTextFormatter::NewFieldPortion
        
        Change-Id: I7e5cbce45bba4550f572606f44300b914ff5a41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158433
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [3a87f9b67f3274fe4a02b003c49f893c87291c3d]

        Drop unused SwFieldPortion::m_nAttrFieldType
        
        Change-Id: Id5858018607c6b0cab0d55a5d247fb39db0978bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158431
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-25  Michael Stahl  <michael.stahl@allotropia.de>  [5dfae9e00f245da78613224ed8e0dbd8b6633192]

        tdf#157703 sw: PDF/UA export: export heading labels as text
        
        Been advised that a Lbl element is not much use in practice.
        
        Change-Id: I4ea339d7b48a7ee8ae40f94a9fc71f3e409c07ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158421
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [04a208bf5eb112b0f018f1d9f7e07784c14f584b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c0331071035ec78359ec8a4e5919164a31ec879
          - remove xml-lang
            
            Change-Id: Ib512a2d5d587da2bb8e459ab90eb5a42d2424be8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158434
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [09e04efc7c33407271819c1fe7d4d500ca8fff2a]

        Simplify a bit
        
        Change-Id: I6b98dd9b383b82c5bcba9235d81b0a9a63a918b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158430
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-25  Noel Grandin  <noelgrandin@collabora.co.uk>  [505c5821d6d4849cb793584a7775ded24c791590]

        small steps to getting ASAN on Windows working
        
        Change-Id: Ie8941a7cc87cb5c5dba62e9356e960e45f5560d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [33f158d96c5782a862345736bc6561afe3d583b5]

        tdf#157795: sd_png_export: Add unittest
        
        Change-Id: Iedf8c33833ce08d42fd52a7080fa6b60e9555c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158417
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [6c073a180b6af61963fcce0da63ba66b97357ccb]

        tdf#139141: Add UNO commands for variable date/time fields
        
        Impress already has both options in the menu
        Also re-enable test disable with fa569930a0968cdeba4441e19a68e7d78aa25cb4
        "Revert "Resolves tdf#139141 - Make variable date/time field the
        default""
        
        Change-Id: I1cec89b5901073555ffa31d2be24e1e62fbbdcb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158391
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a8011372f4c8e849fa1e56246d793dcadffe3af]

        list-dispatch-commands: do not ignore aliases
        
        For instance, .uno:ViewTrackChanges should also be listed
        
        Change-Id: Ifdaaa91b053a28d5ba9a6926d81194d92c6ca65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158386
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [6448c83a8740711172b3c59175a2abd15c00114b]

        DBG_UTIL implementation differs only by never-wrong assert
        
        Change-Id: Ifb879d6536c80f00da61707fb0aa0700dcd19bcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158288
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-25  Michael Stahl  <michael.stahl@allotropia.de>  [949f0d9cf2fe7953691160103139a16473dd3171]

        vcl,sw: PDF/UA export: produce Ruby and Warichu SEs
        
        These need to generate multiple elements in
        SwTextPainter::PaintMultiPortion() and it's not altogether obvious.
        
        Change-Id: Ib5fd36c3ea8e15dff93a87bb231c3cc4f78b0089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158398
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-25  sahil  <gautamsahil1947@gmail.com>  [e558cbed9b350f2e6cbe948d648471499e0deffc]

        tdf#114441 - Convert use of sal_uLong to better integer types
        
        nUpdateInterval (sal_uLong --> sal_uInt64) because it is passed as
        argument to Timer::SetTimeout function that takes a sal_uInt64
        
        func CalcUpdateInterval (sal_uLong --> sal_uInt64 return type) because
        this function is only being called once, and in that call, the
        return value is passed to a function which takes sal_uInt64 type
        int. line 412
        (https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/select.cxx?r=b6b26421#412)
        two lines after which it is passed to a function ...
        
        and the function changed in vcl/source/window/seleng.cxx is the one to
        which the value of nUpdateInterval is being passed as explained in
        the lines above.
        
        Change-Id: I73441c2d3520a222ddb39b8c0c205b4dd61d4751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156015
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-25  Yli875  <qq3202390739@gmail.com>  [0c50fe53acbd0ee98e93d52e9967f94543301473]

        tdf#156550 sw: Add a unit test
        
        Change-Id: If0ecfc8f7ebfce330ef0e25b17f48d2a34957299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158395
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-25  Stephan Bergmann  <sbergman@redhat.com>  [dcaa2c4870e0b2662c597f53c46b1df347183e7c]

        Use std::signed_integral concept
        
        ...which, unlike std::is_signed, also requires that T is an integer type, not
        just any arithmetic type, but which appears to fit well here anyway.
        
        But LLVM 12 libc++, which is apparently used by Android builds, only provides a
        bare-bones <concepts> that lacks std::signed_integral (among others), so for now
        introduce o3tl/concepts.hxx providing what's missing (incl. std::integral and
        std::unsigned_integral, for some kind of consistency).
        
        Change-Id: I1c37d37fa1b57b5e3bf24c9e44f3973003905cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158406
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-25  Miklos Vajna  <vmiklos@collabora.com>  [9704f61982360ce35983a61cca3fd00bbdf51ab6]

        tdf#155682 sw floattable: fix DOCX with big pictures causes endless loop
        
        The bugdoc had a floating table in the header that overlapped with
        full-page, as-char anchored images in the body text, leading to a layout
        loop.
        
        The trouble is that the body text was broken into 2 lines: the first
        line just had fly portions for the area where the in-header floating
        table was rendered and then the second line hosted the actual image. But
        then this image didn't fit the remaining space, so it moves to the next
        page. And this happened again and again.
        
        Fix the problem by keeping in-header anchored floating tables inside the
        boundary of the header, this way the body text still doesn't overlap
        with the floating table, but the space available to the body text
        doesn't have to contain fly portions. Which means we don't try to move
        the image to a next page, so there is no loop.
        
        Note that the IsFollowingTextFlow flag is already ignored in some cases
        (e.g. sw/qa/extras/ww8export/data/tdf128700_relativeTableWidth.doc), so
        this doesn't break the use-case when a footer provides an anchor
        position for some text on the left/right margin. In that case the footer
        height is still unchanged as it should be.
        
        Change-Id: Id9e80140af3123d52b0fea2f96fc19c150c8e736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158413
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-25  Miklos Vajna  <vmiklos@collabora.com>  [aa6882da4b43f52ef1f92fa0bc500aec9878ed54]

        CppunitTest_sw_ooxmlexport10: avoid preTest()
        
        This keeps all code of a test in a single place, if we don't trigger the
        preTest() magic.
        
        Change-Id: I13254fd11be344f84e0a8bb8eab4b93d7c1a8825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158400
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-25  Patrick Luby  <plubius@neooffice.org>  [4cf636fab338ad759e1a23bb8570cc9351ded0d0]

        tdf#157790 invert alpha mask
        
        Due to commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
        the alpha mask needs to be inverted.
        
        Change-Id: I4771c5f6f3a08fb210b62a0533df895a4a476058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-25  Kohei Yoshida  <kohei@libreoffice.org>  [b14583ba37a6d7ce398ccd3cf339f954785b03d8]

        Support conditional loading of Apache Parquet files into Calc
        
        Also, use orcus::create_filter() and simplify the logic a bit.  This
        requires orcus 0.19.1 or newer.
        
        Note that this change makes it possible to load Apache Parquet files
        if and only if orcus has been built with the parquet import filter
        enabled.  Using orcus without the parquet import filter enabled will
        not break the build or run-time behavior; you just can't load parquet
        files.
        
        Change-Id: I9f8820998b7b0667d1e7cd532c32b1c7e55ca999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158411
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-10-25  Kohei Yoshida  <kohei@libreoffice.org>  [b5d194d1d37131f921853b78d659c63178de2bc6]

        Upgrade liborcus to 0.19.1
        
        Change-Id: I2190419e88323bbf000602a7762e850a33b5dfdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158409
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-10-24  Stephan Bergmann  <sbergman@redhat.com>  [3d58f3c0c22a972097956f781c51c2822e6d524f]

        Use requires-clauses
        
        Change-Id: I27c990f27023aba5e77c6b406d7dbdcc898054ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158405
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4ec29bf35eceddbc015b0b2631cf80453f49c2de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2250a507ab35df482392e9f1fe297bb57f300af9
          - tdf#153986 Drop "Numbering" from the label in bullet list Format/Tools
            
            Change-Id: Id7b604a6c1532b4799c7ec658b1a1f9e25b4c972
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158408
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5a4837c6a291f2bb7d601ba21b796eedd82b49bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e423f2a7995db5bd4da002309afdd5efaf06af21
          - tdf#144444 tdf#155877 Toggle edit points
            
            + toggle edit points
            
            Change-Id: Ieee6b0030ee4b001700443aa35ac87018ec1a7f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158399
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-24  Michael Stahl  <michael.stahl@allotropia.de>  [049f458143cbd02ab915271418625cda1299f4b1]

        tdf#157028 vcl: PDF export: inline attribute dictionaries
        
        There seems to be no reason why SE attribute dictionaries are separate
        objects, they could just be inline, which saves a little space (1%)
        and more importantly the PDF file is easier to read with less clutter.
        
        Change-Id: Iaaea2432313c0b710edabecae32545205f4f495e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158392
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4edff633dd36ea47d17a993e0afb30fcfc4f9a61]

        tdf#153519 make TreeListEntryUIObject safer
        
        Do not store a raw pointer to an object that go away.
        Consequently we can remove the various sleep() hacks
        
        Change-Id: I3200c26b3a2a4eb7592cb2e5c6af64d6b739d1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [cee0425bf7377520845d7a32e8ccb4bc92f5d43d]

        suppress more IndexHint accessibility warning
        
        Change-Id: I45bc0bf74f4ebeeb4155006e67309cd476ebc3c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158388
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-24  sahil  <gautamsahil1947@gmail.com>  [20ce362ee29642251a92d086debaac06746d9d08]

        Remove unused entry from log-areas.dox
        
        Change-Id: I1d7bb4183c45f752cddf118411259695a294b2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158371
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-10-24  Michael Stahl  <michael.stahl@allotropia.de>  [4c5283a3a11008a06a995c49ed777734dc1f6066]

        tdf#156565 sw: PDF/UA export: only one Link ILSE per link
        
        The problem is that for a hyperlink, multiple Link SEs are created, but
        only one Link annotation; the Link SEs all point to the annotation but
        the annotation can only point to one Link SE.
        
        So try to create only one Link SE for a hyperlink, similar to commit
        ee3c3fcf5c48964f7bc1d64484409f072c614866.  This could be
        further subdivided by Spans when formatting properties change but it
        looks complicated and rarely needed.
        
        Change-Id: I7d158b599ec744b03e78eeca88d717183f2ba1dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158387
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [a0b7b47e3ec843d8012a7526c1e8e72d67cc41b1]

        gtk3 a11y: Take current type into account when setting new value
        
        This is the gtk3 variant of
        
            Change-Id I8674fc37798491fd0b57543acb491edbd4a5a056
            qt a11y: Take current type into account when setting new value
        
        See that change's commit message for more details.
        
        Change-Id: I597220253fa0ca61252706915ad009b8846bbd42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158383
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [d2daaedf2e3b30ff28f4a9a33b6b70738273f9e3]

        qt a11y: Take current type into account when setting new value
        
        As the `XAccessibleValue` documentation [1] describes,
        the underlying implementations can used different types
        of numerical values.
        
        Qt's `QAccessibleValueInterface` uses `QVariant`, so could
        in theory also support different numerical types.
        
        The AT-SPI Value interface however always uses double. [2]
        
        So far, `QtAccessibleWidget::setCurrentValue` was also always
        extracting a double value from the `QVariant` param and
        creating an `Any` from that.
        
        This however would result in any `XAccessibleValue::setCurrentValue`
        implementations assuming to be passed an integer would fail to
        extract a proper new value from the Any.
        
        As an example, selecting a currently checked checkbox
        (e.g. the "Automatic" checkbox in Writer's "Paragraph"
        formatting dialog, "Indents & Spacing" tab) in Accerciser's
        treeview of LO's a11y hierarchy woul result in the checkbox
        to be unchecked, because Accerciser reads the current and then
        sets the same value again when selecting an item with its
        "Interface View" tab active.
        
        Prevent that from happening by passing a `sal_Int32`/`sal_Int64`
        value again if the current value is also using that type.
        
        [1] offapi/com/sun/star/accessibility/XAccessibleValue.idl
        [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/blob/7cc4cee53ddbd22631fd110f0e5ce045dec2e411/xml/Value.xml
        
        Change-Id: I8674fc37798491fd0b57543acb491edbd4a5a056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158380
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-24  Michael Stahl  <michael.stahl@allotropia.de>  [a5851d0a6fdc3e08e93daf8cf0ae7f6fc2d73ef6]

        tdf#157817 sw: PDF/UA export: fix ToX header sections
        
        The problem was that a P or equivalent element is not allowed as child
        of a TOC; previously the P was outside/before the TOC because the ToX
        header was completely ignored but now it starts a SE for the ToC content
        section before being ignored.
        
        Tagged PDF Best Practice Guide suggests putting the header inside a
        Caption element.
        
        Another problem is that if the ToX header is on one page but the first
        entry in the ToX content section is on the next page, BeginTag() created
        a new SE for the ToX content section.
        
        (regression from commit 033e37b49b5712df19dbfd2c307a102bce620de1)
        
        Change-Id: I3c1f8fdda81c1f10198f5eaefc10bcd14f277a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158298
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-24  Miklos Vajna  <vmiklos@collabora.com>  [c361f3987bc57bf345cb6da4806d2278b6221113]

        xmloff: document the GutterAtTop Writer setting
        
        Change-Id: Ic56d7b3333e50bd6cf0d32d19995b09bf612384c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158381
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [eafef8fd195654f0e7dbd007bcc7fa0f6d29b599]

        tdf#135921 a11y Send event when toggling listbox checkbox
        
        When toggling the state of the checkbox in a listbox/
        treelist entry using the mouse or the keyboard, emit
        a `VclEventId::CheckboxToggle` event and process
        that in the a11y class that's used for the case
        where there's just a single checkbox (like in the
        spelling options dialog), `AccessibleListBoxEntry`
        by sending a corresponding STATE_CHANGED event
        on the a11y layer.
        
        This makes Orca with the qt6 VCL plugin and NVDA on Windows
        announce the new value when toggling a checkbox in the
        Spelling options dialog using either the mouse or the
        keyboard.
        
        As mentioned in the previous commit,
        
           Change-Id Ic78f9052d166be0da17a76261a09da02b8a11cd7
           tdf#135921 a11y: Toggle listbox item checkbox on space
        
        , the case where a listbox entry has multiple checkboxes
        (like the autocorrect options dialog in Writer)
        uses different a11y classes and toggling a checkbox there
        still doesn't result in the new value being announced.
        
        Change-Id: I36a2b0a3fa3154279fb06af023fdb96f699fac2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158375
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-24  Michael Weghorn  <m.weghorn@posteo.de>  [6974c10901cc052bce23295ddff25530137e94c8]

        tdf#135921 a11y: Toggle listbox item checkbox on space
        
        Allow toggling the state of the checkbox in a listbox/
        treelist entry using the space key if the entry is currently
        selected.
        
        This aligns it with the behavior for "plain" checkboxes.
        
        On the a11y layer, these listbox entries are
        even exposed just as a checkbox when there's only
        a single checkbox for the entry
        (s. `AccessibleListBoxEntry::getAccessibleRole`),
        like in the Spelling options dialog ("Tools" -> "Spelling",
        then press the "Options..." button).
        
        For the case where there are multiple checkboxes
        (like in the Writer autocorrect options dialog),
        the first checkbox will be toggled.
        Making it possible to toggle any of the checkboxes
        for that case would need further work, s.a. the
        the related tdf#135585.
        (For gtk3, it's possible to use the arrow keys
        to switch the column, then use the space key
        to toggle the checkbox.)
        That scenario also uses a different approach
        for the a11y layer, not a single
        `AccessibleListBoxEntry` object as is the case
        for the tdf#135921 scenario.
        
        This change makes it possible to toggle the checkbox,
        but so far, the new state is not yet announced
        when a screen reader is running, neither when
        using the keyboard nor when using the mouse
        (which was possible without this change already).
        The event handling that's required for this will
        be added in a separate commit.
        
        Change-Id: Ic78f9052d166be0da17a76261a09da02b8a11cd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158374
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [06425229d89d7283b4070b0885992cd7ad3bf73e]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Id7ae178e687edf9550ea1ccef475e326cbe4de2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [22d52cf9f14d9e40bfef06ad73c1b01299275c9d]

        vscode-ide-integration: bump C_Cpp.default.cppStandard to c++20
        
        Change-Id: I58b1eb86594c03ab7b6d0426b335bb3132effb8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158360
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [729513c985bea9da3616d583d3eb25fe04ce16aa]

        vscode-ide-integration: editor.renderFinalNewline is not boolean
        
        …but tri-state (on/off/dimmed). Also fix missing comma in the debugger
        config.
        
        Change-Id: Iee4de01ccb5c0bb714b78a4fbbcb865b5e8d5b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158358
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-24  Stephan Bergmann  <sbergman@redhat.com>  [9d5e8d5f5bc422178d6fca928e749ba3bb3d159e]

        tdf#153519 Another TreeListEntryUIObject heap-use-after-free
        
        ...similar to the one addressed with the commits leading up to
        9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep"
        
        Change-Id: I8114c6647e06ceb202cd790af691ecc18e9d4e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158373
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-24  Stephan Bergmann  <sbergman@redhat.com>  [adc4836d8b004832dfdd7d44f9d6187549fee868]

        Extend SAL_NON_APPLICATION_FONT_USE documentation
        
        Change-Id: Ib3b65436d0703b0e4e691a00ef16b99c561658b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158370
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-24  Miklos Vajna  <vmiklos@collabora.com>  [612629f4a81acd7b851b7eccc97aba9a5915d13c]

        tdf#155040 sw floattable, RTF: fix table is overlapped by subsequent inline one
        
        The document had overlapping text on load since commit
        05425f73bfa41d3f7591461e2ad0beb4fafc39b4 (sw floatable: teach the RTF
        import about SwFormatFlySplit, 2023-04-21).
        
        Interestingly the DOCX equivalent was fine, there the inline table is
        shifted down, below the floating table, so the overlap doesn't happen.
        
        Fix the problem by moving the AddVerticalFrameOffsets=true code from the
        DOCX filter to the shared dmapper, because RTF needs the same.
        
        See commit 50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add
        AddVerticalFrameOffsets compat mode, 2016-03-31) for more details about
        this compat flag. It was already enabled for DOC, too.
        
        Change-Id: I948b179c9ec5fa24377014b0e86826568c417b6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158372
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-24  Stephan Bergmann  <sbergman@redhat.com>  [b7c857fab92ec26ed0a32e30243ff688f83a40be]

        loplugin:ostr (macOS)
        
        Change-Id: Id40ce74db71f685cc1c459ea2a5b174f3f8862f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158369
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [28d2ac7c10cc6ef7199781a786d8a3514a14b6be]

        Fix typo
        
        Change-Id: Ib2e612960f27d103bd25d14b86fa9eb0c0422669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158367
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-24  Miklos Vajna  <vmiklos@collabora.com>  [ed7d1c49c0a898772e7f81416b3414da8cc35f2e]

        svx: prefix members of SdrLayerIDSet
        
        See tdf#94879 for motivation.
        
        Change-Id: Ibac67e7f8535b231f63a01b7e572595f5b91a996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158368
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-24  sahil  <gautamsahil1947@gmail.com>  [e2c9b9056182dfb1fc1145ab627bc5db4e73d62b]

        changed sal_uInt8 to BenError (enum)
        
        Change-Id: Ia7cb2f879b7be833d1a5ccf845a8dc8bfb94befd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156900
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [11b12589c2b944f3f32d23de2794c4afddfb23b7]

        Fix typo
        
        Change-Id: Iac1d0f9a00fe5ccab84da1f1fb033354920341fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158366
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-24  Cosmin Humeniuc  <cosmin.humeniuc@1and1.ro>  [59ce453ea5ed5227633f44bb86545d122d48de01]

        tdf#144444 Use same strings for same command
        
        Done during the conference hackfest
        Change-Id: I04f1dd77ca8866eff44e49d9f90805995cec9840
        
        Change-Id: I53467e4e80f2d82fa126eb9a40ee28f67d7c321f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157187
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-24  Powerinno  <alexandruwolfy@gmail.com>  [4dd3e1fb72ce59d8f7266023f1f1810fb7bd9678]

        tdf#153986 Drop "Numbering" from the label in bullet list Format/Tools
        
        Changed "Numbering alignment" to "Alignment" also changed
        "Numbering followed by" to "Followed by".
        
        Change-Id: I6230aa8d5abcd6311e527c96d6c3856d96194c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157195
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-24  Baole Fang  <baole.fang@gmail.com>  [27fde46937ecb71e7ce738cba430119a79cea77f]

        tdf#154052: Change "Level" spinbox to combobox
        
        Change-Id: I58a50963f95a2c364557a7aa0992f9858ec5d9cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158301
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [60952eb3234006e9fba189e4189e15f902cafb4b]

        tdf#157838 - UI: Part 4 - Unify lockdown behavior of Options dialog
        
        for Print Page.
        
        Change-Id: I724dcbaf8e3ed479aaf053965d2d0e64381e53fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158269
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bf7b0febbf3081a3693bf09bc4e779f7c6c30dc0]

        tdf#157837 - UI: Part 3 - Unify lockdown behavior of Options dialog
        
        for View Page.
        
        Change-Id: Iac27aa516e4e4a4c1469b0ff465477c44c3a5660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158250
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d8b96939806bbeacc91bb2c42d44bb6de21010d0]

        tdf#157702 - UI: Part 2 - Unify lockdown behavior of Options dialog
        
        for General Page.
        
        Change-Id: Ide7c387d1b9f8ebba7f7801cdd69b1e1a93f90e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158196
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-24  Balazs Varga  <balazs.varga.extern@allotropia.de>  [89fb894825b894080049abc500315f8b985c32c2]

        tdf#157700 - UI: Part 1 - Unify lockdown behavior of Options dialog
        
        for page User Data.
        
        Change-Id: I912fe2786ad5e7fc110137dfbcff73ee25fb0fbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158126
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-24  Stephan Bergmann  <sbergman@redhat.com>  [dc4d7500c9d283e26d1553ce11366a217cf1f69d]

        Fix CppunitTest_sd_import_tests-smartart non_application_font_use
        
        sd/qa/unit/data/pptx/smartart-composite-infer-right.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/smartart-interopgrabbag.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/smartart-pyramid-1child.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/smartart-snake-rows.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf132302_SmartArt_rightArrow.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/smartart-tdf134221.pptx
        replaced some "微软雅黑" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf135953_SmartArt_textposition.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf145528_SmartArt_Matrix.pptx
        replaced some "Calibri Light" with "Noto Sans"
        replaced some "Calibri" with "DejaVu Sans"
        
        sd/qa/unit/data/pptx/tdf148665.pptx
        replaced some "Poppins Medium" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf148921.pptx
        replaced some "Tahoma" with "Noto Sans"
        
        sd/qa/unit/data/pptx/pptx/tdf149551_SmartArt_Gear.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf149551_SmartArt_Pie.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf149551_SmartArt_Pyramid.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        sd/qa/unit/data/pptx/tdf149551_SmartArt_Venn.pptx
        replaced some "Calibri Light" with "Noto Sans"
        
        Change-Id: Ie224100d024dc4f3321650e33f13ed5a61b444e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158364
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [926826e40955175a8c115472e0d2f6c7f2f1a453]

        Implement PreserveSpaces boolean HTML/ReqIF export filter option
        
        This option changes how HTML/ReqIF export handles paragraphs with
        leading/trailing spaces, or multiple sequential spaces. Normally
        export may insert newlines every ~256 characters, in place of
        normal space characters; this relies on default processing of
        spaces, where leading/trailing spaces are trimmed, and runs of
        spaces are reduced to a single space.
        
        When PreserveSpaces is true, HTML/ReqIF export takes care to not
        alter spaces inside paragraphs. For that, it checks if paragraphs
        contain sequences of spaces that normally would be reduced; and
        for those paragraphs, it adds "white-space: pre-wrap" to style
        (in HTML), or 'xml::space="preserve"' attribute (in ReqIF).
        
        Import of 'xml::space' attribute and "white-space: pre-wrap" style
        is implemented; when paragraph has these, it keeps the spaces read
        from HTML/ReqIF intact.
        
        Import does not currently support this attribute/style in elements
        other than 'p'.
        
        Change-Id: I62dba5eaf313b965bf37d8fa5e3f5bbb8f5e8357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158362
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [bae0736bf0ec54828766c3d903e2a27458643395]

        tdf#157287: sw_core_txtnode: Add unittest
        
        Change-Id: I4c14cbe8610dc6426b910f4ef5d96ccc6e7a4604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158359
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-23  Michael Weghorn  <m.weghorn@posteo.de>  [a8cfd280fbb5aff27ef90cee45daa185e24ea5c7]

        a11y: Make XAccessibleValue doc more consistent
        
        * Align the method names in the documentation
          to what the acual methods are called
          (e.g. `getMaximumValue`, not `getMaximumAccessibleValue`).
        
        * Use "minimum" and "maximum" consistently, not "minimal"
          and "maximal" in some places.
        
        Change-Id: Idf4f36dca118a614b04a4b958e97d225f70dde0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158347
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-23  Michael Weghorn  <m.weghorn@posteo.de>  [f1dbbfe278c8673d98e2eb3d8ad460b9f7364642]

        a11y: Don't throw exception on valid list box entry action index
        
        `checkActionIndex_Impl` was previously throwing
        an IndexOutOfBoundsException for any index other than 0.
        
        The
        
            // only three actions
        
        comment in there was only adding to the confusion...
        
        Convert that helper function to a method of the class
        and take the actual count of actions into account.
        
        Also drop the misleading `ACCESSIBLE_ACTION_COUNT`
        define altogether, and just return 1 at the only
        remaining place using it.
        
        This fixes a crash seen with the qt6 VCL plugin
        and Orca running when opening the spelling options
        dialog ("Tools" -> "Spelling", then press the
        "Options..." button).
        
            1  __pthread_kill_implementation                                         pthread_kill.c             44   0x7f29908a80fc
            2  __pthread_kill_internal                                               pthread_kill.c             78   0x7f29908a815f
            3  __GI_raise                                                            raise.c                    26   0x7f299085a472
            4  __GI_abort                                                            abort.c                    79   0x7f29908444b2
            5  ??                                                                                                    0x7f29904a09db
            6  ??                                                                                                    0x7f29904affaa
            7  std::terminate()                                                                                      0x7f29904b0015
            8  __cxa_throw                                                                                           0x7f29904b0268
            9  (anonymous namespace)::checkActionIndex_Impl                          accessiblelistboxentry.cxx 49   0x7f29562aeb82
            10 accessibility::AccessibleListBoxEntry::getAccessibleActionDescription accessiblelistboxentry.cxx 770  0x7f29562b2b9b
            11 QtAccessibleWidget::actionNames                                       QtAccessibleWidget.cxx     805  0x7f297c84a8d7
            12 QAccessibleBridgeUtils::effectiveActionNames                          qaccessiblebridgeutils.cpp 25   0x7f297b6c90a5
            13 AtSpiAdaptor::actionInterface                                         atspiadaptor.cpp           1862 0x7f297b6e2cc0
            14 AtSpiAdaptor::handleMessage                                           atspiadaptor.cpp           1438 0x7f297b6de432
            15 QDBusConnectionPrivate::activateObject                                qdbusintegrator.cpp        1438 0x7f2979ec0ecb
            16 QDBusActivateObjectEvent::placeMetaCall                               qdbusintegrator.cpp        1594 0x7f2979ec1bb0
            17 QObject::event                                                        qobject.cpp                1446 0x7f297c02116e
            18 QApplicationPrivate::notify_helper                                    qapplication.cpp           3295 0x7f297a59d714
            19 QApplication::notify                                                  qapplication.cpp           3246 0x7f297a59d524
            20 QCoreApplication::notifyInternal2                                     qcoreapplication.cpp       1131 0x7f297bfa23ba
            21 QCoreApplication::sendEvent                                           qcoreapplication.cpp       1572 0x7f297bfa2ead
            22 QCoreApplicationPrivate::sendPostedEvents                             qcoreapplication.cpp       1937 0x7f297bfa3ea6
            23 QCoreApplication::sendPostedEvents                                    qcoreapplication.cpp       1794 0x7f297bfa37ae
            24 postEventSourceDispatch                                               qeventdispatcher_glib.cpp  244  0x7f297c3b9108
            25 ??                                                                                                    0x7f29835111b4
            26 ??                                                                                                    0x7f29835142d7
            27 g_main_context_iteration                                                                              0x7f29835148f0
            28 QEventDispatcherGlib::processEvents                                   qeventdispatcher_glib.cpp  394  0x7f297c3b999d
            29 QXcbGlibEventDispatcher::processEvents                                qxcbeventdispatcher.cpp    96   0x7f2979c67036
            30 QtInstance::ImplYield                                                 QtInstance.cxx             421  0x7f297c8c27c6
            31 QtInstance::DoYield                                                   QtInstance.cxx             432  0x7f297c8c28ef
            32 ImplYield                                                             svapp.cxx                  377  0x7f298732dcc8
            33 Application::Yield                                                    svapp.cxx                  461  0x7f298732ea66
            34 Application::Execute                                                  svapp.cxx                  355  0x7f298732d9bb
            35 desktop::Desktop::Main                                                app.cxx                    1601 0x7f2990a35716
            36 ImplSVMain                                                            svmain.cxx                 204  0x7f298734d600
            37 SVMain                                                                svmain.cxx                 236  0x7f298734d735
            38 soffice_main                                                          sofficemain.cxx            94   0x7f2990aa058f
            39 sal_main                                                              main.c                     51   0x5629220af9d4
            40 main                                                                  main.c                     49   0x5629220af9ba
        
        Change-Id: Ib3ed8616fb539942d9ba0cd60d5607859deb5a7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158344
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [af2457dd1f421d657f8d2ad3e2d8493ab9288d4d]

        liborcus(-parser) also needs boost_iostreams - fixes wasm build
        
        not handling that automatically from the info from the regular build is
        kinda ugly, probably can be done via RepositoryExternal.mk, but since it
        was done that way initially after much tinkering, I don't want to invest
        much time into rewriting the static build stuff just to get rid of the
        few lines for icu and liborcus ....
        
        Change-Id: I2a620426854eb16e2388159bb3bbf1a514872ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158267
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0d293754a9d87afeff399af3559a1e95239d1ac5]

        fix wasm build (int vs sal_Int32 mismatch)
        
        error: non-const lvalue reference to type 'sal_Int32' (aka 'long')
        cannot bind to a value of unrelated type 'int' in file
        /home/tdf/jenkins/workspace/lo_gerrit/tb/src_wasm/vcl/qt5/QtAccessibleWidget.cxx
        
        (since refactoring in 15a6e23c4fc160c50a316da3d18980a02fc10ce8 )
        
        Change-Id: I2689701839ba18b5cffae13afcaa5b1a32b5e4b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158305
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-10-23  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ea574f7929d4c226d56273178779ef38ca2ce5c9]

        tdf#111737 - Add new (master) page depending on the edit mode
        
        Change-Id: I5e0d0f604714cbc395cd6b0c7a9b5665f0d5f93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157631
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-23  Patrick Luby  <plubius@neooffice.org>  [d8ec731e613d840dc7550a3468110a69fd5280e4]

        tdf#157795 set color to black outside of of bitmap bounds
        
        Due to commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
        transparent areas are now black instead of white.
        
        Change-Id: I9456bb2603d4968a5d5df0a7bdbff48ce9a8e2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158355
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-23  sahil  <gautamsahil1947@gmail.com>  [c0e687edf47f9bd2735a4e71116a9c1e50900de6]

        tdf#130924 replace '*printf' with 'SAL_*' logging macros in pyuno
        
        Change-Id: I2c491629f52fe0b90517c563f221d7d0345b6ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156452
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-23  sahil  <gautamsahil1947@gmail.com>  [d56b61975330329c5dc1e99cc7750a690d3206ed]

        tdf#130924 replace '*printf' with 'SAL_*' logging macros in tools
        
        Change-Id: I9721bfd3783fd6c5d41b2d9a0e8468c583ede0c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156864
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-23  Stephan Bergmann  <sbergman@redhat.com>  [fcae1c4fdf75d6a62cdbfbca5deb07e78de591f5]

        tdf#153519 Another TreeListEntryUIObject heap-use-after-free
        
        ...similar to the one addressed with the commits leading up to
        9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep"
        
        Change-Id: Ia6db1440b3d9623b440edb3866b750ff5a14bdb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158348
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-23  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [fa569930a0968cdeba4441e19a68e7d78aa25cb4]

        Revert "Resolves tdf#139141 - Make variable date/time field the default"
        
        This reverts commit e37f06f534ac864f9fe8cd20b07a85c36e697d41.
        and ui test from Ia1a2387e137f8a672a24056b13234d4275a77ca4
        
        Reason for revert: tdf#157337; macros rely on fix field values
        
        Change-Id: I7a638330aac9b71432556454c0104479fcd05b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158041
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [4d0e2203d1ccceb4a742b02c267e613b50ca9370]

        tdf#157793: sd_png_export: Add unittest
        
        Change-Id: I9a602a5da35146c103b7c21a00067f80f4922ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158341
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [4648764378f42df7dee4a4cf7d1614ee64e1d1a3]

        tdf#105362: sd_png_export: Add unittest
        
        Change-Id: I1d6cc72738e3120c10e6d978dad18ec2fb36edd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158346
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ea8023f6bb9b623014a6db867fb9d46be7b7266f]

        Remove executable bits on docx
        
        Change-Id: I8f07861794a487ea4f0fe26fb90893304942df2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158354
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d4004e9ede37ccca9e041a349e0bc2770e0640f2]

        Remove executable bits on docx
        
        Change-Id: I4ebb73e00ee8cca5614c5e651e31dc29f080f738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158353
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-23  OmkarAcharekar  <omkaracharekar12@gmail.com>  [97b6b6b16c4b623f8a34393a906272439a7f0314]

        tdf#149555: sw_unocore: Add test for convert RANGE_IS_SECTION SwXTextRange
        
        Change-Id: I5e9fe7c59ac81004ce44ac04d5c50f65b754d847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157947
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-23  OmkarAcharekar  <omkaracharekar12@gmail.com>  [242bf93ae380d470e9fe34f8badf261ad203728b]

        tdf#156267: sw_docnode: Add test for remove DdeBookmarks in SwDoc::DelTable()
        
        Change-Id: I564fc701bf459e5591f65fad3c147d726b6881ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157850
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-23  Michael Stahl  <michael.stahl@allotropia.de>  [e9ca8fb1af1e3d41160c13e8002f05a610a0bd0b]

        tdf#157145 sw: PDF/UA export: tag borders as Artifacts
        
        (probably regression from commit 804d0a896731629397c5328c13c04a45bc55f459
         moving the ProcessPrimitives to SwRootFrame::PaintSwFrame())
        
        Change-Id: I4015ffe6566c94e9f3b3694d39e0c24797cb9039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158266
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-23  Stephan Bergmann  <sbergman@redhat.com>  [bd6fb0cd3eee3c7d414e55a7678c0097aadc7646]

        Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]String
        
        ...in include files.  This is a mix of automatic rewriting in include files and
        manual fixups (mostly addressing loplugin:redundantfcast) in source files that
        include those.
        
        Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-23  Stephan Bergmann  <sbergman@redhat.com>  [3501c52176d1122d9de08462435f633cd21de370]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/4bad0762b8931a30055520dda45a2f5044b248eb>
        "Update gvfs-1.52.0.tar.xz to 1.52.1"
        
        Change-Id: I9b346fc9e3632c4075837f08c0e493f07f6a18fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158339
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-23  Chris Sherlock  <chris.sherlock79@gmail.com>  [41e00b105f004b75451e24043dc85af703c91dd3]

        vcl: migrate text layout functions out of OutputDevice
        
        OutputDevice is not where text layout should be done. There are a number
        of text layout functions that are used across the text layout classes,
        so I have moved them into TextLayoutHelper and made the text layout
        classes rely on this. I have made TextLayoutHelper implement the
        ITextLayout interface because this is still useful to new classes that
        need to implement new text layout functionality.
        
        Change-Id: Ic137a938576e7a6a64db0e5780bbbdd8342ef421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157362
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [8db72aab30ec81c26452a363b8ef9d6a98a07632]

        cool#7332 calc perf: GetEmptyLinesInBlock
        
        reuse existing method to find area of sheet which contains data - this method already caches the necessary data.
        
        Also add a shortcut for the common case in ScColumn::IsEmptyData to avoid performing more expensive lookup operation.
        
        
        Change-Id: I24c7466d804ffc53cb2568923717f60ff4bc5186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158338
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-22  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [fd69b546ad36452560cb11ccb28e78632d65f045]

        Link Library_localedata_others against sal
        
        <https://ci.libreoffice.org/job/lo_daily_tb_win/1557/> etc. recently
        started to fail with
        
        > localedata_af_NA.o : error LNK2001: unresolved external symbol __imp_rtl_uString_release
        > C:\cygwin\home\tdf\jenkins\daily_workspace\tb\build_master\instdir\program\localedata_others.dll : fatal error LNK1120: 1 unresolved externals
        > touch: failed to get attributes of 'C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_others.dll': No such file or directory
        > make[1]: *** [C:/cygwin/home/tdf/jenkins/daily_workspace/tb/src_master/i18npool/Library_localedata_others.mk:10: C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_others.dll] Error 96
        
        Change-Id: Ie3765b76691d66ea7f0bbcace5e9eba3168b813b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158309
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-22  Gökay Şatır  <gokaysatir@collabora.com>  [768da8bf8fa20848d5da9dfc56b1b8ce42b1404f]

        Don't encode the text when sending it to Duden corrector.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I9e1a2adede04858e5c43b878786bbcc28922aa5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158023
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 8989cba47fce3763229005b1ed2fec74da7cfb72)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158333
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [42b0bab8d90c29e7806e681d1b009d3554195d91]

        Remove duplicated includes
        
        Change-Id: Ifdf7776c7c1abab5dadee8a9bb3301d9d7f4e596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158320
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-22  Szymon Kłos  <szymon.klos@collabora.com>  [ef5afb766553dfa9bf1c577e5f6bcb5bf5412782]

        lok: remove old hack for LanguageTool locales
        
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146779
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153962
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154162
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 9a5329a266bd74abc4794f1fcbae3db07582dbde)
        Change-Id: I44cc4a5b1a0d92e2b0857cdc1d68c931ab95c0d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158332
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Szymon Kłos  <szymon.klos@collabora.com>  [b9a081654b709e8572673c5ac728b76d6e968f98]

        lok: LanguageTool provides list of languages
        
        - it sends supported list to the LOK client
        - disables Spell Checker for locales supported by LanguageTool
        - duden protocol supports only german
        - initialize language tool config before usage to fetch correct
          list of supported languages
        
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146665
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153960
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154161
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 21d0489a5efa970e975ce1a70dfda2fd9e2c186d)
        Change-Id: Id0f909fbd2cca47e93ed8632217a45b5087c1ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158331
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Mert Tumer  <mert.tumer@collabora.com>  [7fbea38b7aa5335abef55b445df88ee571d18360]

        Load the locales from config file for languagetool
        
        Locales needs to be read again
        in the Preferences/Writing Aids section and since
        this is a network operation it can cause a problem.
        Better to list all the supported locales in the xcu
        and load it right away.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135598
        Tested-by: Jenkins
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153959
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 84bdf9e81a63a8bd308709c86b51bf3900a23c50)
        Change-Id: Iad9201101aa167ad33f479c67f72649786e1f2cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158330
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  nirnay  <nirnaykorde@gmail.com>  [2c0669846fe26dae2bb64308517db685037e2cf9]

        tdf#119931 Fix accessibility warnings in dbaccess
        
        Added accessibilty to some UI files
        
        Change-Id: Id9d1eae93151e232040fdcf22810ba67ead05609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151138
        Tested-by: Jenkins
        Reviewed-by: Samuel Thibault <sthibault@hypra.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [c34f465a21dab492afec12011f4a16584a663d9f]

        lok: a11y: impress: screen reader support for text shape editing
        
        Now accessibility support can be enabled in Impress.
        Fixed an issue that prevented to receive accessibility event when a
        shape text content was edited.
        Some rectangles overlapping check is performed for excluding not
        visible shapes from the a11y tree
        Anyway client and core visible area can differ some shape was wrongly
        pruned from the a11y tree.
        The problem has been fixed by not performing the overlapping test in
        the LOK case: we already do the same for shape area invalidation.
        In order to avoid the screen reader to report no more focused
        paragraph we send an empty paragraph to clear the editable area when
        shape selection state changes. When shape ediding becomes active the
        text content of the shape is sent to the client.
        
        Change-Id: Ia9ee08d060162891725d26efd2aa36e47b38ed50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157525
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158329
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [10a4fc18c48bbcf3dbfe802f7c13405cfe737084]

        SvpGraphicsBackend::getBitmap overwrites the buffer
        
        so in this case we don't need to memset it to 0 before
        
        seen in VclDrawingArea::DumpAsPropertyTree
        
        Change-Id: I339677f091e9e6585e5d6e72f467d439efb43cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Samuel Thibault  <samuel.thibault@ens-lyon.org>  [34fd462ac5e64ebd79826465c41671c1a6627afd]

        gla11y: Add link to a white paper describing the rationales of the tool
        
        Change-Id: I0d60cb6b3ee2105d58ea56f3efc5bb5ee856a44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151147
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [70cddea8cb780f2fe0acdd15b72d13ce2d1ad649]

        lok: a11y: send list item prefix length to client
        
        Implemented getListPrefixSize function which relies on
        UNO_NAME_NUMBERING_LEVEL, UNO_NAME_NUMBERING character attributes.
        The former provides the list item level, the latter is a boolean that
        says if a prefix (bullet/number) is present or not for the list item.
        It has been needed to modify
        SwAccessibleParagraph::_getSupplementalAttributesImpl so that it
        returns such properties for list item only and not for simple
        paragraph too. In fact for a simple paragraph the default value for
        the level property was returned which is 0 exactly the same value for
        top list item.
        
        Change-Id: Ia651af4d4b2372eed42c90b0752e16fd47a4fdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156816
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 038903d2e066de9525a3baffdd232484ef44ff51)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157780
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [f1cb3bb7739b2917a2ba2bce45885bd20f6f7fba]

        Replace a tab with spaces
        
        Change-Id: I06805f3c07b5baedfd492d701cb6f46da5ea913f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158322
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a45cd084f5ea1d7aba2f5569e17ee386489cd3ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1077c8e56376354dc108496b6d8f45f03ead021d
          - Fix icon size
            
            Change-Id: Ib80cf472083f43ac3375669a7deae0632b5898ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158271
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [69c7722b6c70db7a39657026689103f541543d4a]

        Use getXWeak in sw
        
        Change-Id: I49d2d1a00928c4cea68164e8c91fd9a6bb4b3b94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150875
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1eda97c39237f0244faccb220b3bdd692340e013]

        cid#1548028 silence Explicit null dereferenced
        
        Change-Id: I9f20b9b6febd94e85095dc018908cfa5011741d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [42eaab2c8e6cc2fb9cb6f608db6ba4a07cc55409]

        Fix typo
        
        Change-Id: Ia58df805c7c59bdef07046431241b40d2aa404de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158318
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8ee5b9ae2100671601c7152a201e51bfb3efa028]

        Fix typo
        
        Change-Id: Iae66bf4a14fd3cdcc8c735832cd6cdc8f73b21ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158317
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c0ed629732571f438a1f2e7afd37bff82ce62740]

        Fix typo
        
        Change-Id: I4266832365533330e2a1e2f3a8fdd8abf1a99443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158321
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1963543084d95645d8f3356532d8053c6fb1b772]

        Fix typo
        
        Change-Id: Ic413f2dac416a9a03b4cd9629b476f7665e8aabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158319
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [676e0527d2f31556eccae314fbb12ce204f02ec7]

        use Liberation Sans instead of Calibri in the test for tdf#144092
        
        based on Stephan Bergmann's point on:
        <https://gerrit.libreoffice.org/c/core/+/138652/comment/bb5fc1a4_75e060c9/>
        
        the font used in the test file was Calibri, which likely was
        being replaced with the best approximation on a given system.
        Changed that to Liberation Sans which is a font that is bundled
        with LibreOffice to improve the test's robustness.
        
        Change-Id: I7ff75baeb9259dea244913ca9d5025948291f1e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158234
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [5555562856a8bca0869a04147fbc05a1eece9193]

        Related: tdf#89178 Add an option to avoid converting some fields into text
        
        ... during mail merge.
        
        In some modes (generating individual documents; creating PDF) the mail merge
        process converts all fields into text. But sometimes it is undesirable for
        fields not involved into mail merge itself:
        
        * It is inconsistent with how MS Word behaves;
        * The generated editable documents could benefit from having other fields
          kept as fields;
        * Some fields, when exported to PDF, produce different results: e.g.,
          placeholder fields are output as empty spaces, not as placeholder text.
        
        An expert boolean configuration option is added:
        Office/Writer/FormLetter/ConvertToTextOnlyMMFields; it is false by default,
        in which case, the behavior is unchanged. When true, all fields in the mail
        merge document, except for database fields and hidden text fields, are not
        converted to text during mail merge process.
        
        Change-Id: Ibdb505ed3f2762db063bb0a91b674d27ecbc2e7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158306
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dffe85aaf3443ab2286eb9990c1c7faa692ec96f]

        ofz#63406 Timeouts with huge fonts
        
        reduce limit further when fuzzing
        
        Change-Id: I66345f78a5375a6415f0b25ba736c41fd27ce8d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158308
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a8c30238bc91f7bb7a5462c608eb27dd74c73db0]

        Resolves: tdf#157849 gtk_spin_button_update callback can delete widget
        
        so later GtkInstanceEditable::signal_activate is on deleted widget
        
        Change-Id: I9bb9848b4554792db11fc7b0e2d3491a94975b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158262
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [d861fff5e3419e28edcfdf17c4863ec8c9618502]

        Make ConvertFieldsToText private
        
        Change-Id: Ie3d22b63260d2b2b05a46c5b2a6ca915cf9d4bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [701563366c717c21ffa0588de6be1005df92a779]

        tdf#135922 wina11y: Report text-related IA2 obj attrs
        
        Extend `CMAccessible::get_attributes` so that
        it also reports the text-related IAccessible2
        object attributes, since what is meant to be
        reported as a text attribute and what is meant
        to be reported as an object attribute differs
        between the IAccessible2 specificiation and what
        LibreOffice does on the UNO level, s. the commit message
        in this previous change for more details:
        
            Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d
            tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs
        
        Just use a character offset of 0 when querying via the
        `XAccessibleText` interface here. The exct offset used
        used shouldn't make any difference for paragraph-specific
        attributes.
        
        With this and the NVDA pull request [1] to evaluate attributes
        according to the IAccessible2 text attributes and
        IAccessible2 object attributes specifications, NVDA
        now reports the alignment of paragraphs in Writer, e.g.
        says "align center" since the corresponding attribute is
        now reported for the paragraph object, as can also
        be seen by querying the IAccessible2 interface manually
        in NVDA's Python console:
        
            >>> focus.IAccessibleObject.attributes
            'heading-level:;level:;text-align:center;'
        
        ("text-align:center;" was not yet reported without
        this change in place.)
        
        [1] https://github.com/nvaccess/nvda/pull/15649
        
        Change-Id: I5723797232f89db6a2b74d4a601344f2078ee630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158260
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [cfaa52ed74278aab0e44f7cc9a66afe1c4166715]

        a11y: Improve XAccessibleExtendedAttributes doc
        
        The existing
        
            // MT: I guess it's not formula only?
        
        comment was justified.
        
        `XAccessibleExtendedAttributes::getExtendedAttributes`,
        is not only used to report formulae, but e.g. used to
        report a heading level by Writer paragraphs
        (s. `SwAccessibleParagraph::getExtendedAttributes`),
        so adjust the documentation and align it with
        the `IAcccessible2::attributes` one [1] that also
        uses the cell formula as an example.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#a0d51b0c189a000ee3b6ddf7f68da2009
        
        Change-Id: I2d6f38911c3802edb55f9426a35b8986dd6e399a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [a8e75a8ac93c18a7e955e448bfd120d0ed9ef0b0]

        wina11y: Just return empty attr string when none present
        
        If the `XAccessibleExtendedAttributes` interface
        isn't implemented, just return an empty string
        for the attributes instead of an error code.
        
        (This seems like a totally valid case to me,
        no need to report an error.)
        
        Change-Id: I986f030bc7a01da0fdd92a5aa2b4cf3c0d6a9200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158258
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [eff3e9b8a576863c01f4244a5628cda64f48a363]

        wina11y: Indent try block
        
        Change-Id: I89a4ed514e1c24e683b081d04f72cd62ede80065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158257
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [b0bf4043d320f69d1cf9dfcbcd6a8eac4df94015]

        tdf#135922 a11y: Report IA2 "text-align" attr
        
        Map the "ParaAlign" UNO text attribute to the
        IAccessibl2 *object* attribute "text-align",
        as specified in the IAccessible2 object
        attributes specification. [1]
        
        This causes the corresponding "justification" AT-SPI text
        attribute to be reported when using the qt6 VCL
        plugin on Linux.
        
        For Windows, bridging this to the platform a11y
        will be implemented in an upcoming change.
        
        See the commmit message of the previous change
        
            Change-Id Ief7c840d3c5274714a914ca0e56df0c5eaffb06d
            tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs
        
        for more details.
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes
        
        Change-Id: I6a0478a4ac37f69393e995602ed698b5a78488e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158256
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Michael Weghorn  <m.weghorn@posteo.de>  [9362766b94a4627db0d8adfac4285388970d1fba]

        tdf#135922 a11y: Prepare reporting text attrs as IA2 obj attrs
        
        According to the IAccessible2 specification, some
        of the attributes that LibreOffice handles as text
        attributes are mapped to IAccessible2 text attributes
        as well [1], but others should be reported as object
        attributes [2], e.g. text alignment
        is reported via the "text-align" object attribute on
        the paragraph object.
        
        So far, `AccessibleTextAttributeHelper` was only handling
        attributes that are mapped to IAccessible2 text attributes.
        
        Prepare for reporting object attributes as well, which
        will be required to report text alignment on Windows
        in a compliant way (s. tdf#135922).
        
        On the other hand, Qt also expects
        `QAccessibleTextInterface::attributes` to return
        text formatting using the attributes specified in the
        IAccessible2 attribute specifications and maps that to the
        platform-specific attributes (AT-SPI text attributes
        on Linux), but currently does not provide any way
        to report object attributes in addition to text
        attributes. It however supports e.g. the
        "text-align" attribute mentioned in the
        IAccessible2 object attribute specification
        when it's reported as a text attribute [3].
        
        Therefore, add a new `IA2AttributeType` enum
        that can be used to specify what kind of
        IAccessible2 attributes (text attributes,
        object attributes) to report.
        
        Only request IA2 text attributes on Windows
        when text attributes are requested, but
        both types for Qt.
        
        So far, support for none of the object attributes
        has been implemented, but an upcoming change
        will do that.
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        [2] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes
        [3] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=546208f0ff23819d216cbb5bf0b5daded79b454e#n2193
        
        Change-Id: Ief7c840d3c5274714a914ca0e56df0c5eaffb06d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [8b327dd75caf3fd3374ad92f84a70c276678a046]

        clang-format sal/rtl/math.cxx
        
        Change-Id: I0e807118e6a2196d2f2858ed195782a90572a2e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158303
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-21  Stephan Bergmann  <sbergman@redhat.com>  [00286e56d17090ffdf0abd76ba3c236126f8c116]

        tdf#153519 Another TreeListEntryUIObject heap-use-after-free
        
        ...similar to the one addressed with the commits leading up to
        9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep"
        
        Change-Id: Iecf0146c4c079ae95f980128531ac8f51b4b8535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158302
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-21  Stephan Bergmann  <sbergman@redhat.com>  [769899853557831ae53d020497e81c8fe572874b]

        Extended loplugin:ostr: Automatic rewrite some O[U]StringLiteral -> O[U]String
        
        Change-Id: I8c08bf41b96d4a6085e7d72cb39e629efa556d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158300
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [5a0498ded11d514c21e3124333a3560da1373202]

        mariadb connector: upgrade to release 3.3.7 (fixes tdf#157826)
        
        Change-Id: I053b827b7bc14535760236fcb057c154c359f4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158252
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-21  Stephan Bergmann  <sbergman@redhat.com>  [d5fa192f54eeb4294748d262034f64556fabd4fb]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: fpicker
        
        Change-Id: Id2e70665c78f5e5fd3dc7ab0f5889f83880804ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158299
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc1ba4d17fd71656205697a6cf19432037e4a9d6]

        tdf#156182, tdf#156685: vcl_pdfexport: Add unittest
        
        Change-Id: I6756f1f19b9cc178191a47ea81857981f44aced0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158264
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-21  Stephan Bergmann  <sbergman@redhat.com>  [de087da9242a5d24fcc97b42e216e5375bca3f1b]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerfilter
        
        Change-Id: I6d566f7d7d2ef3d7d5efdd3cc94f129c6b4dbbb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158292
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [c184f93863c27c5a59614ad0c47bea699abb1e7b]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sd
        
        Change-Id: I4dc708ee57a7e305f4e377bde0e486299df56f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158297
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [9108c6e2755b8d6de3b20ad9a868dd393d5b80a8]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: writerperfect
        
        Change-Id: Ibaf69c1d922be6fade028ce6602f215cd9cd35cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158293
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [d49abee2132d6c572afa86898929fc2ad5b982b1]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vcl
        
        Change-Id: Iaeacacbbb0eec907d884219aa2bcfe7a86f00a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [0c07a65377d3c2ba50128322fb036f990e17af82]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlsecurity
        
        Change-Id: I6cdabef12d60f9fa554b95c99e702e8c700329e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158296
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [d834361303bd3e2a2e1f42f89e1169544517d11d]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmlscript
        
        Change-Id: I8cde43bd9999c93b45376e9684f98f654d050864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158295
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [fe7f4eab95c0f8262c8e08ef6cfaf54b2cb24f18]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: xmloff
        
        Change-Id: I2d58bbea770c4dd188cae13e11218a29f4cd5d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158294
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [335e73a7f37f5efc08a6691d8e4b271c68e0a2ac]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: vbahelper
        
        Change-Id: Idb944974318a94763532639c9e74040adadf06f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158290
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [5f69ffb27a09e094c5ba9da214c769b5ec2ce406]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: tools
        
        Change-Id: I930c794c6f93531ef8d2b91c5e6ad62b486966dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158245
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Justin Luth  <justin.luth@collabora.com>  [4e871d99ccace244de42c0d5c4bd11611af6ccb2]

        tdf#157026 sd notebookbar: add ObjectAlign to MenuTable as popupmenu
        
        The vast majority of this is just eliminating copy/paste,
        since I have now created a popupmenu.xml list for the popup menu.
        
        The "fix" is adding this to the Table menus.
        
        .uno:ObjectAlign is basically just a "label".
        Now it is a label for two different "views":
        * a toolbar widget dropdown
        * a menu subcategory
        
        Perhaps it is confusing to have one UNO entry
        serve these two similar purposes?
        
        I suppose someone might also complain that a simple
            <menu:menu menu:id=".uno:ObjectAlign"/>
        isn't clear that this is a submenu.
        
        I considered making mine a new ObjectAlignMenu,
        but the annoyance of having to create a duplicate string translation in
        officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
        made me just reuse the existing label.
        
        Change-Id: I17e037e0c9c5d1f57ac9f174a76cd041983bcea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157894
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-20  Miklos Vajna  <vmiklos@collabora.com>  [e64f3ab974e2f8c528fef8d75162b82ec0453293]

        CppunitTest_sd_import_tests-smartart: make testAutofitSync more robust
        
        - replace 'Calibri Light' with 'Noto Sans' (we bundle the later)
        - replace 'Calibri' with 'Arial'
        
        With this:
        
        	diff --git a/sd/CppunitTest_sd_import_tests-smartart.mk b/sd/CppunitTest_sd_import_tests-smartart.mk
        	index 9b7362b08152..72e0dead7731 100644
        	--- a/sd/CppunitTest_sd_import_tests-smartart.mk
        	+++ b/sd/CppunitTest_sd_import_tests-smartart.mk
        	@@ -11,4 +11,6 @@
        
        	 $(eval $(call sd_import_test,-smartart))
        
        	+$(eval $(call gb_CppunitTest_set_non_application_font_use,sd_import_tests-smartart,abort))
        	+
        	 # vim: set noet sw=4 ts=4:
        
        doesn't abort anymore. In fact the second replacement is just for
        completeness, the first was enough alredy.
        
        Change-Id: I455b473233e351b7a2ee6a1b1b66049e63a8a6ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158263
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [711e01c7878ef0c319fd40c95484cb9be5105e00]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: toolkit
        
        Change-Id: I67ba7b0f4d99f080b343a9b26a242cf4008b820c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158244
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [113c4566933b798e3de4daf9e276ce24cdb8e773]

        Avoid double notifications for deletion case
        
        Follow-up to commit 34ac12dca3f5af50fddfb7c77e2943897980b815
        When old redline is own Insert, and the new one is Delete, it means
        that it was already handled in DocumentRedlineManager::DeleteRedline.
        
        This also reverts the unit test change done in the mentioned commit.
        
        Change-Id: I77e59dceb1c880fc6ec10ad98867be3bf5282f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158253
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [b60b3b5bbcc8db61bb24d3866b48cb4c63eb4f30]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svx
        
        Change-Id: Ib5028b826a3f62303b9e0502af70ad62c578fbb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158240
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [7c59c59a0b6abee5d2c147139a79051a190939aa]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: scripting
        
        Change-Id: I74516d08ed48f2c9f4a0d4e105c96f95c127485b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158218
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [9ef3adb3b83824e5b5a539c5886ba59df744bfaa]

        loplugin:indentation (macOS)
        
        Change-Id: I176ac2153d4f2daa48ed4bf85d123904c234f8f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158251
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Julien Nabet  <serval2412@yahoo.fr>  [0aa651ad226842fbf8095d36d7cf9cc31c2c5bdc]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 3978d026b57097ede0be8ac6e4ffd1164ada7474
          - Fix path of logo for Spanish dictionary
            
            Regression from c1ddcf602ba97f8e99383f34e8027074d8193f61
            "Updating RLA-ES Spanish spellcheker to v2.8."
            
            There's no "images" subdir in "dictionaries/es"
            
            Change-Id: Ia18110dbe04feec6553fb80501450546a0ac79a2
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/158169
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [449c9a9322a55113342e5a8de041a5ad7d646a9e]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: unodevtools
        
        Change-Id: I21dd038249b506ecc58a7002fd3dcd4366176b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158248
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Michael Meeks  <michael.meeks@collabora.com>  [2cbf54efab073d9147e2d6c627c8ff3726de8578]

        sc: perf: avoid construction of collector for empty note columns.
        
        It is extremely common to have empty note columns; so shorten this
        path profile in: cool#7334
        
        Change-Id: Ibfd550be1a5e8e98df8b4ede0d018c4f85300648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158158
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [dab91084b576410f0d76b4da5f5479bb1578ec0c]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucb
        
        Change-Id: Ic3123585203ebcdf2fe791709d38551e7a326d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158246
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [5bd143316162f29227b2f8ec4d165a3260806bde]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbhelper
        
        Change-Id: Ib4b300e8b21f772c97dcb49d666f93d2821f0859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158247
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [a9a7ab4955bc9e18883331c78de407dd111776ea]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: unotools
        
        Change-Id: Ia3722b27955e444b67a97c478739db696fa3dcaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158249
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [e7cf25437e590dd74a1f119b2942b2122cdff1aa]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: testtools
        
        Change-Id: Idc0de002b7ca4e370add311f91576adaaf354764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158243
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [99ac24b38743d323a52cf9c9c884c3b468635a55]

        fix GBUILD_TRACE on cygwin, needs to have unix-style path for the log
        
        make's abspath function turns the path into windows-style, but that
        fails for appending to the log/the rule needs a unix-style path
        
        Change-Id: Ibb4a32bee10f7c69e8f57c1a771efc85ace283e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158238
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e106b8658068bd8c5d1ef2da1bf2dc1dc352a4ab]

        fix make GBUILD_TRACE=/path/to/log.json for non-mac
        
        my previous patch to make it work on mac (
        4b67515418ee4f10071b3f0f2275ba37f32b0ae5 ) actually broke the
        timestamping for other platforms, as the date command no longer was
        treated as a shell-subcommand due to the lack of the additional $ to
        quote the statement.. Oups.
        But at least fixed within a year, people need to use it more! :-))
        
        Change-Id: Id4e20fb11540824555ce4c04d3abed55be9185c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158236
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [bcbc1051c72dc16dd16dbb86b21ca4d731be34b8]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: test
        
        Change-Id: I883d34c9562b48d987a16a0254272f3aeeb4bf5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158242
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [a841ac096f2794405408ef64189de2c77971c3e6]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sw
        
        Change-Id: I85fff7ed6932c5fc196e18f24fa01074ba4837e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158241
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Patrick Luby  <plubius@neooffice.org>  [a98000c028a3c68329fdb2047f51f8d271b2290c]

        tdf#157793 limit tdf#157635 fix to only larger palettes
        
        I don't know why, but the fix for tdf#157635 causes
        images with a palette of 16 entries to be inverted.
        Is this the only condition for masking out black
        pixels in non-transparent animation frames?
        
        Change-Id: I9550baab4dc4d9b75a21c8af2f6c0b5eb8e46c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-20  Miklos Vajna  <vmiklos@collabora.com>  [5e7f7917fd589f661982d481a45bf84337e4c03c]

        sw floattable: remove now unused FloattableNomargins compat flag
        
        This was noop since commit 626fe9ab5ebebc4ef36e35f4aa597c03a3564d22
        (tdf#157573 sw floattable: fix incorrect lack of left margin after
        table, 2023-10-18).
        
        Change-Id: I89a197313ac4ffbcff9bbff534e5411085282ac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158237
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-20  Julien Nabet  <serval2412@yahoo.fr>  [d33f5234ac79cfa6eaaedc2890b9e71337268b2c]

        Typo in comment "af"->"of" in XReference.idl
        
        Change-Id: I99c52dcf7fe5db7226090c3685d27b2f333a16eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158235
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f0f1d74bdeafa09655813091b5259581f17b358d]

        ofz#63374 avoid Abrt
        
        Change-Id: I63e609e40a9453000a8f296f4b02f167902fd790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158211
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [123a0ef011f5627b213aef0a20215970ada30fe6]

        remove SAL_WARN in _setPropertyValue
        
        since so much code higher level code is now just asking for random
        properties and just catching the UnknownPropertyException for the cases
        where the object does not support that property
        
        Change-Id: I9198ec0c540252783015cffa088be30451f92c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158231
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-20  Michael Weghorn  <m.weghorn@posteo.de>  [c920605dd4c4520ab8ee80f9fb4746287835918c]

        external/lxml: Fix --enable-python=fully-internal build
        
        After
        
            commit a4b4a90557f9fc1839fc0eb297f4c6a4e94c761a
            Date:   Sun Jul 2 14:54:23 2023 +0900
        
                lxml: upgrade to release 4.9.2
        
        , my `--enable-python=fully-internal` build started
        to fail with
        
            Building lxml version 4.9.2.
            Building without Cython.
            Building against libxml2 2.9.14 and libxslt 1.1.35
            Traceback (most recent call last):
              File "setup.py", line 207, in <module>
                setup(
              File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/core.py", line 108, in setup
                _setup_distribution = dist = klass(attrs)
              File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/dist.py", line 274, in __init__
                warnings.warn(msg)
            UserWarning: Unknown distribution option: 'project_urls'
            make[1]: *** [.../libreoffice/external/lxml/ExternalProject_lxml.mk:26: .../libreoffice/workdir/ExternalProject/lxml/build] Error 1
            make[1]: *** Waiting for unfinished jobs....
            make: *** [Makefile:289: build] Error 2
        
        and Julien reports the same in [1].
        
        The above commit includes a patch to switch from
        setuptools to distutils.
        Possibly the distutils variant of the `setup` function
        doesn't know about the "project_urls" keyword argument
        (at least in our bundled Python version),
        so extend the patch to drop that from the
        `setup.py`.
        
        [1] https://gerrit.libreoffice.org/c/core/+/153863
        
        Change-Id: Icfac9fb0a3c62d3b30c12bc23ddbc0f9b088d788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158230
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [ea4d4d0979ae295f1045362c621bdcb6583fbc15]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: stoc
        
        Change-Id: Ic8c251b97f5e5bdf81599534384d86ac9904da53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158222
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [25286bc04142741b7731dae50891c1dde47b78c4]

        set accessible IndexHint in sd
        
        to avoid some more spurious SAL_WARN
        
        Change-Id: Iff1dfea4857e780d0b3739c7b1688eb7df243907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158232
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b34132256c1e9ebbf0cc82a14f4da7335574a887]

        CppunitTest_sd_png_export_tests: relax test even more
        
        I misread https://gerrit.libreoffice.org/c/core/+/158181/3#message-f54ed5a8dcf1d68fea73ace5ff9851d3d5fe5a2f
        
        Change-Id: I31523af088f8fa83f43a8a49e449d27b0f230149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158229
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [367891c40ec683767d91ddeaf566c396f22b9035]

        Use getXWeak in toolkit
        
        Change-Id: I44a0ddd386ea6d262d6102b40f3e9837655068ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150877
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-20  Miklos Vajna  <vmiklos@collabora.com>  [8e03dfd6a4bff4eabf779ace9b758b49cf80f8ba]

        tdf#157590 sw floattable: avoid hang in the nested + row span case
        
        Regression from commit 905962db870e9d1cf1dcf3bd1be44c347cddafe1 (sw
        floattable: handle AllowOverlap==false in the layout, 2023-08-10), the
        document load resulted in a hang due to a layout loop.
        
        What happens is that SwTabFrame::MakeAll() first does a Split(), but the
        problematic row has cells with rowspans, and once this is combined with
        multi-page nested floating tables, we move all the content to the next
        page (we only leave a stub table frame on the old page), so the next
        time SwTabFrame::MakeAll() is called, we do a Join(), and this leads to
        a loop.
        
        The traditional Writer way here would be to add a loop control, but we
        can do a little bit better: nobody really asked for row span handling
        with nested floating tables, so just don't split rows with row span in
        this case, move the entire row forward instead. This is enough to avoid
        the layout loop, and a next iteration can still use
        SwFlowFrame::MoveBwd() / SwFlowFrame::MoveFwd() to split the complex
        row.
        
        The bug is fairly hard to hit, any naive simplification to the original
        bugdoc leads to a working layout. Carefully keeping the size of the
        document, it's possible to at least simplify the content of the table
        cells (while keeping their size unchanged), so we avoid half of the
        tables and half of the shapes for a faster test case.
        
        Change-Id: Ib14154200c45ecb7f59e85f9f4f1fe0124c4256e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158228
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [2f1a650b68161cbaed95b8e38392663abd5f1d80]

        Link Library_localedata_euro against sal
        
        <https://ci.libreoffice.org//job/lo_daily_tb_win/1555/> etc. recently started to
        fail with
        
        > localedata_an_ES.o : error LNK2001: unresolved external symbol __imp_rtl_uString_release
        > C:\cygwin\home\tdf\jenkins\daily_workspace\tb\build_master\instdir\program\localedata_euro.dll : fatal error LNK1120: 1 unresolved externals
        > touch: failed to get attributes of 'C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_euro.dll': No such file or directory
        > make[1]: *** [C:/cygwin/home/tdf/jenkins/daily_workspace/tb/src_master/i18npool/Library_localedata_euro.mk:10: C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_euro.dll] Error 96
        
        Change-Id: I1440365f30bd876466de964f6bb313210e7a3928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158227
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [812a5785ba5ff13ad07496dda9d2ed2cc7db42d7]

        Link Library_localedata_es against sal
        
        <https://ci.libreoffice.org//job/lo_win_daily_symbols/1147/> etc. recently
        started to fail with
        
        > localedata_es_AR.o : error LNK2001: unresolved external symbol __imp__rtl_uString_release
        > C:\cygwin64\home\tdf\lode\jenkins\workspace\lo_win_daily_symbols\instdir\program\localedata_es.dll : fatal error LNK1120: 1 unresolved externals
        > touch: failed to get attributes of 'C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/instdir/program/localedata_es.dll': No such file or directory
        > make[1]: *** [C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/i18npool/Library_localedata_es.mk:10: C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/instdir/program/localedata_es.dll] Error 96
        
        Change-Id: I8a6ef646df1fd8d26f3a8b2f84b098f9971ace2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158226
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Venetia  <venetiarosita@gmail.com>  [d1ba7d0ae6d10c72a1503f88e9b9b32f54cade3b]

        tdf#148952 sw: Add unit test
        
        Change-Id: I151f3d59f924280311653de025560e6fd2a826c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157037
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [734db70ec85944aefb55a41b198fe1a60b91b2ea]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: starmath
        
        Change-Id: I964db94e75e19cb507508b15755e3595247b5524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158221
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [6ece645435f823aae5d6532fd3e3d43eec46b5fe]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sfx2
        
        Change-Id: Ied8f0aff05ffd2f9e187fcb690789baf5fcf0c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158220
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Matti Tyrväinen  <matty@uef.fi>  [58e5e3208a4257a8d9f2e28d8e2d304677aa6980]

        Revert change to Reference Mark behavior to avoid regression
        
        Hotfix for tdf#157287, unfixes tdf#81720.
        
        Setting the DontExpand flag would solve tdf#81720, but
        causes regression due to other code that depends on the
        old behavior. This patch restores the old behavior
        without reverting the UpdateFieldContent refactor included
        in 146941; testDontExpandRefmark is commented out for now.
        
        Change-Id: Ibaeacabec304473db63df9334e2fef46c6d9acc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158059
        Reviewed-by: Matti <matty@uef.fi>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [96cbf1a4c3093a4cc339da68907f67f9a30f3916]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svtools
        
        Change-Id: Ib4d0e05b802776c682676a7bdaebb5123f6c5013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158224
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [74a6ce486b13f33380959ae58a40300bb84082f2]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svl
        
        Change-Id: I31d46c2b75888474136ecd630fd3f817db189fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158223
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [498515b01aa026c2b39836f69d10b7016c89a66f]

        CppunitTest_sd_png_export_tests: relax test a bit
        
        See https://gerrit.libreoffice.org/c/core/+/157763
        
        Change-Id: I397adc22e29c595c3bfaf0331a1774f192f0fc85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158181
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-20  Julien Nabet  <serval2412@yahoo.fr>  [46ed432cf4b1111f31f61d7a2c7974288710fb1f]

        dbaccess/source/core/inc/object.hxx unused since initial import
        
        Change-Id: Iad9c4f234833ce4c605040b9d0f9b86150791c99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158210
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [da3a91e89f803d1c42b764c90071b30b547e686b]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sc
        
        Change-Id: Ieed908bfa2cb6370ead922dfc00dbdb4f905f3cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158216
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [02411752218670d89726a06f746c2b622ed4efc6]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: scaddins
        
        Change-Id: I964223021109dbafedc875ab5c016e0fdef411b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158217
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [bc9fc85452a4da18df592be190347e9781dbba0a]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sdext
        
        Change-Id: I13d1279050de77e8ea054c6ee3a3bce97cec584b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [68486cc18e3b7fcfa97b472184ede43a76c2be15]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sax
        
        Change-Id: I16c763164567293b096e132650c509cfc32fd407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158215
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [774a939f3be9bff97a43f8b5573ff6215b749842]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: reportdesign
        
        Change-Id: I5e45fd5d464db3cf038a844b955144649f980ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158208
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Skyler Grey  <skyler.grey@collabora.com>  [32c588dd1164aa2fc4c8120ddb74bd510cc082f9]

        tdf#86790: Add support for a word-style styleref
        
        STYLEREF is a field type in Word which changes its content based on
        nearby paragraphs. For example, upon creating a styleref referencing
        "Heading 1" you will see the text of the nearest "Heading 1"-styled
        paragraph that is above the field.
        
        This patch implements STYLEREF in Writer as a cross-reference. By using
        "insert>cross-reference>styles" you'll be presented with a list of
        styles. Selecting one and clicking "insert" will create a field which
        has text from the "most relevant" instance of the style. To find the
        most relevant instance we first search up for paragraphs with the style,
        and if there are any we take the closest. If there weren't any, we
        search down for paragraphs with the style.
        
        This patch also updates our use of STYLEREF for chapters exported to
        docx by using it for all chapters not only those in headers and footers.
        This allows us to approximate more chapter field functionality even when
        moving between Writer and Word.
        
        Finally, this patch adds some tests for STYLEREF:
        - testTdf86790 tests that the "sample file with STYLEREF" document from
          tdf#86790 has the correct fields
        - testStyleRefSearchUp tests that the STYLEREF searches up when there
          are bits of text both above and below it
        - testStyleRefSearchDown tests that the STYLEREF searches down when
          there are bits of text below it only
        - testMarginalStyleRef tests that the STYLEREF searches from the page
          top when it is placed in a footer
        - testFootnotetyleRef tests that the STYLEREF searches from the
          reference mark when it is placed in a footnote
        
        Still TODO:
        - [  ] Update documentation
        - [  ] Implement reverse-searching (\l) and nondelimiter
               suppression (\t)
               - Probably these 2 will be in a followup patch
        
        Change-Id: I25dd7a6940abee5651a784b9059fe23b32547d6c
        Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157456
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-20  Miklos Vajna  <vmiklos@collabora.com>  [d52982f4b3ba3f54adf21a9f185c726fb1a3db9a]

        sw layout xml dump: move SwAnchoredObject dumper
        
        Next to the rest of the anchored object code.
        
        So it's more likely that it gets updated as SwAnchoredObject changes.
        
        Change-Id: Iff07da7a2679f4ea7b63ce18251140f4e46a0956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158199
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [dd6f6147d431577ce7e1c5596481366a9faa7afb]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: linguistic
        
        Change-Id: I0866cdaffa7059c30a65373efcd37a91b1b6e63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158205
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [44bd87fd784e64205030067bf91e67ac3cecfa2d]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: oox
        
        Change-Id: Ic5bcb44fbe56804e23bcdfd039a77c010858ca02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158206
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [cbe3899ed9b0fb226bf84c19e6f312e587ce2c03]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: jvmfwk
        
        Change-Id: I23ce970ad67047b0b22a9dda3dff047e5f59dff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158203
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [6e4d3c3476fb60116fc7100a30a30ae15f60ce62]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: package
        
        Change-Id: I5d70d9291a64139bc2dc60c63173fef862a00f2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158207
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [3bbed358b617eb407184edac9a11aed62e36a2d7]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: i18npool
        
        Change-Id: If3eb4d8fb3068e26ce42c8cc751c2de38b5d04cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158202
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [35948cad8d41c0e70debb442b8f6182b28f0a65a]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sal
        
        Change-Id: If4a7951fd3f9f7f2e081e6b8ba482566260c3235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158209
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Stephan Bergmann  <sbergman@redhat.com>  [64c47c92d09c276408405e2520328155dd665427]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: framework
        
        Change-Id: I0f17c569eddcdc30bfca4cdcd25cb05cf783ec23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158200
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-20  Michael Weghorn  <m.weghorn@posteo.de>  [fc06de1b23df9c80445c99def36beab6efa755cb]

        wina11y: Drop now unused CMAccessible::get_String4Numbering etc.
        
        `CMAccessible::get_String4Numbering` is unused since
        
            commit 2bf88c172c9c9d159344b95fb96073f4891a6c30
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 18 13:44:42 2023 +0200
        
                tdf#157696 wina11y: Switch from custom to IA2 text attributes
        
        , so drop it.
        This means that `CMAccessible::get_StringFromAny` is then
        also unused, so drop it as well.
        
        Change-Id: I35abc94b2fc2ecec1789918fbf4ed6707a96c974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158195
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-20  Adam Seskunas  <adamseskunas@gmail.com>  [1e6c1b672b1b93376f3c816e870d956b84e089e7]

        tdf#114441 Convert use of sal_uLong to better integer types
        
        In ctrlbox.cxx, nCount and i were changed to sal_uInt32 because
        aFontSizeNames.Count() returns sal_uInt32.
        
        In valueset.cxx, nFirstItem and nLastItem are only used in a comparison
        with a value of size_t. They were both changed to size_t because
        nLastItem contains the product of tools::Long mnVisLines and
        sal_uInt16 mnCols where tools::Long can be 64 bit in some cases.
        
        Change-Id: Ib3f10cdf6ae81e96f28f13a0bb32699f26c8a0cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157109
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [26a08eb18eb18963652b063ce8bfb3e36b7529f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7585dc09a544ff865dcf39f55cb81d77e9d73ba
          - tdf#155876 UI cmds Calc (05)
            
            + refactoring
            + Edit menu - Final
            
            Change-Id: I4ff166ba0d6d4d009eb97a8cdb3c361abf776612
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158213
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-20  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a4b4a90557f9fc1839fc0eb297f4c6a4e94c761a]

        lxml: upgrade to release 4.9.2
        
        * external/lxml/Wincompatible-function-pointer-types.patch: fixed upstream.
        * backport external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
          from <https://github.com/lxml/lxml/pull/371>.
        
        Changelog: https://lxml.de/4.9/changes-4.9.2.html
        
        Change-Id: I8ea947b3b1fb30b9427d066bd41a5d4693ceedbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153863
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-20  Patrick Luby  <plubius@neooffice.org>  [fb68f0761c3cfadf73f261d2d44de7b4e277e0af]

        tdf#157565 show tooltip if any parent window is the key window
        
        Commit b69db38a38b09e158e8d46d8b717db85860ca874 caused tooltips
        to fail to appear if their immediate parent window was not the
        key window. So, look through the parent window's parent windows
        and, if any of those windows are the kwy window, show the tooltip.
        
        Change-Id: Icf1aed1144fdeac03b4b208de8ed8ee2db8ad4a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158212
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-20  Mike Kaganski  <mike.kaganski@collabora.com>  [34ac12dca3f5af50fddfb7c77e2943897980b815]

        Do not forget to notify in cases when modified redline's start/end don't move
        
        SwRangeRedline::SetStart/SetEnd call MaybeNotifyRedlineModification,
        which means that e.g. continuing typing at the end of the current
        redline would continue sending notifications. But as soon as cursor
        is moved (e.g. using arrow left, inside the current redline), the
        next modification is completely inside the current one, and would
        be simply deleted. In this case (and other similar), notifications
        weren't sent.
        
        This change tries to make sure that every such case is handled. In
        case of delete-inside-insert, when positions are equal, the current
        redline is deleted; MaybeNotifyRedlineModification is not called,
        to not crash. I don't know if this needs additional notification.
        
        Change-Id: I2a97354623a5a784928ce4e1f2c93606954bd11c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158198
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [f6f00918854bae7f03e79192e5d79f78929cb418]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: l10ntools
        
        Change-Id: I4878e2209b8499e02b7a6c13867b1a3aa4dad7e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [f290768698b24e0d4e7cbf29d6255dc083f02001]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: hwpfilter
        
        Change-Id: I49a08f7102ad6669a5f307c412d07a8040249b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158201
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [c9a522a383bb5dea92f46b462302eb7ab521f34b]

        Presumed loplugin:cppunitassertequals
        
        Change-Id: Ib8de8835d7ceb214bbf87d7cebfbb56723e8fb28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158135
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [30c4d857612ec3ba6c252d6da70b0195e0e1d902]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: editeng
        
        Change-Id: I9ea2bdf3b939f260184bf793e2b91cd37e9d80c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158190
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [24655ccaeb7d36cf024b31ad5925244ac7016351]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: filter
        
        Change-Id: I1dd21c1dc2a7aed54fa1c03036ad75d2e0eade87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158193
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [93c0780392758f783592f030aa2d4e824d57bb2f]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: embeddedobj
        
        Change-Id: I2761e0a093aff75c5660b2b78012277c67eb8e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158191
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [6581f028f85d72f3b85c873eaecd77a37c98ac31]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: forms
        
        Change-Id: Ifab0f06a776a9c505508781018300c7ce5d46436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [26b63f4f2f71a48dc0a9be3356da88f8b5f143dc]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: drawinglayer
        
        Change-Id: I668041773862b380772d0425ac4eab1d37d310e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158189
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [fa869ef61c790b6407ef6eae3eefc094d13c1361]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: cui
        
        Change-Id: I4c06aabb88e15975ae6e1e6b783aa0a9237c1617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158186
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [3afe381c840f3c3687800410066d6738191c7480]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: cpputools
        
        Change-Id: I285ed755d35394dfb4f970dd7442ae156e3baa43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158185
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [566de3328e60b2608b8f611698b6d26fc33b05f1]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: extensions
        
        Change-Id: I30f81bdcd7ba877e65c8f134352669e22d78b033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158192
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [7eda35a36c8837c620722e5c26c90324ae9b48e9]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: dbaccess
        
        Change-Id: I5f92e390ef57ae8f2aba43782c11ca5ee31dba93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158187
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [326a8d5dd2d01a2037f17a6fd921494937c134d4]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: desktop
        
        Change-Id: I896fb07e753bfd7be5df892b1608954ad6a9cece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158188
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Miklos Vajna  <vmiklos@collabora.com>  [65f508b44ecbc20c8bd5172d1656639f686730ff]

        tdf#157573 sw floattable: add missing testcase
        
        Fails with commit 626fe9ab5ebebc4ef36e35f4aa597c03a3564d22 (tdf#157573
        sw floattable: fix incorrect lack of left margin after table,
        2023-10-18) reverted.
        
        Change-Id: I6a3bd69dc109e6df195d00c33118218eeaa00ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158179
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a0c5a5b0521bea6cb695731d448e62c41ed4c57]

        UITest_sw_navigator: avoid oneprocess
        
        This is just a test to see whether this is reason why
        UITest_sw_navigator is failing some much recently.
        if it's not the case, I'll revert this patch later on
        
        This patch reverts
        - 1775b0c25ab13dab94c5ce930d45347a25198af4 "disable unreliable navigator UITest"
        - f2ba17fecb60d936599efb975d96a3ea06c2a43f "disable more flakey
          navigator UITest"
        - 2e49ec0eaa59b5b513ea756861ecac5482b930b2 "disable more flakey
          navigator UITest"
        - d09785691373009a72cef14fd67610404c8d6022 "disable more flakey
          navigator test"
        - 6347dcbd3ab2e0a7cb2f7de3bcb5d007e8befc09 "disable more unreliable navigator UITest"
        
        Change-Id: I6e3dde9ad412b0769edee551f7e0ee026586bf8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158184
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-19  Patrick Luby  <plubius@neooffice.org>  [5d347c3d72a1d05f998f93f1e1ffea0b55457217]

        tdf#157680 scale down size and adjust size and scale factor for /BBox
        
        The size of an embedded PDF files is multiplied by
        PDF_INSERT_MAGIC_SCALE_FACTOR for platforms like macOS so undo that
        by adjusting the size and scale factor.
        
        For some unknown reason, when exporting the following PDF, the
        estimated size of embedded PDF charts are 20x larger than expected.
        This only occurs on macOS so possibly there is some special conversion
        from MapUnit::MapPoint to MapUnit::MapTwip elsewhere in the code:
        
          https://bugs.documentfoundation.org/attachment.cgi?id=190109
        
        Change-Id: Id0563466fea3d7a3a0419787ec9da45f0c1d2e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157852
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-19  Julien Nabet  <serval2412@yahoo.fr>  [7f3ab74eb62ec83d6fc4432979654944f27de7b4]

        Related tdf#144256: missing removePropertyChangeListener calls in AppController
        
        Compare and use same order as in dbaccess/source/core/dataaccess/datasource.cxx
        
        Change-Id: Id025e6e801387c2c377af88d2816c68ed9183e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158171
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [e6ca379bcbe7d9fb426cf8944f24e345e8856d3f]

        Clean up some C++20 TODOs
        
        Change-Id: I8baece4349683c7a83a283b85e24f33874b47ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158177
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Michael Stahl  <michael.stahl@allotropia.de>  [7cb283cf0e92cba4bd53b1cd69816ac7037937e4]

        tdf#157703 sw: PDF/UA export: fix headings with labels
        
        The problem is that the new Lbl/LBody elements are produced even for
        outline nodes, but those aren't represented as lists at all, but as
        headings H1..H10.
        
        Plausible representation of the heading label could be in a Lbl element
        inside H1, or simply as plain text; i can't find any recommendation
        either way.
        
        Let's try Lbl inside H1, neither veraPDF nor PAC3 complain about it.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I691957d0c4a80d1339cb2b87c72c9aa652abfb9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158127
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a1cf7a24cfbf65adbbe692ac6f8c1b55c7807fe]

        use png_set_keep_unknown_chunks
        
        so we don't see unnecessary warnings about the exIf chunks we use
        
        Change-Id: Iac02591be8a239b6077fa05826fdd8e76bcc2236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158174
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8b7558d8a462649fa3b2df2748e92377917e3fd]

        SAL_WARN->SAL_INFO in XMLShapeImportHelper::CreateGroupChildContext
        
        Change-Id: Ia4bdbfdf6d85999e4cf8fa78131aec2dc776f41a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [8c230395bc374a2be4e9bb341a10f9e8f8cf467e]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: basctl
        
        Change-Id: I771d90376e3497cd28abeda2c8c794c049a80d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158143
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [9d850743c2d046c92757fde3079a1d29794bf3ce]

        Link Library_localedata_en against sal
        
        <https://ci.libreoffice.org/job/lo_daily_tb_win_arm64/1037/> recently started to
        fail with
        
        > localedata_en_AU.o : error LNK2001: unresolved external symbol __imp_rtl_uString_release
        > C:\cygwin\home\tdf\jenkins\dly\b_master\instdir\program\localedata_en.dll : fatal error LNK1120: 1 unresolved externals
        > touch: failed to get attributes of 'C:/cygwin/home/tdf/jenkins/dly/b_master/instdir/program/localedata_en.dll': No such file or directory
        > make[1]: *** [C:/cygwin/home/tdf/jenkins/dly/s_master/i18npool/Library_localedata_en.mk:10: C:/cygwin/home/tdf/jenkins/dly/b_master/instdir/program/localedata_en.dll] Error 96
        
        Change-Id: I62f2580dfbd91c2c74873c70ce2781bd49ed28b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158173
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5c4635c8bbd27b06a81bfa8d75f986994065310]

        tdf#155410 small optimisation
        
        Change-Id: I736b5959d52c57ee5e05e349d0c421896229e554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [625705f10e765b6fa246c016acc9546cb0247301]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: basic
        
        Change-Id: Ic82e02ff43db09174a74f4e584e2ce50e8983556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158145
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [15b86648f031bb2b44b23a1826ad4ac2a00884b3]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: cppuhelper
        
        Change-Id: I4c221461c60c5e96b738bb902253984a9b0b312b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158170
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [4f66ce572be5bbec9fe8feef8f0937d0ca06e964]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: connectivity
        
        Change-Id: I8220cf4e83a59aa55394d01f29a6af108dcc0619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158149
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Willian Pessoa  <wpessoa@outlook.com>  [fec4d0fb9992811d1217624d8eda95eac6da4220]

        tdf#147021 Use std::size() in editeng
        
        Change-Id: Id6496b34a3601fb021af2894fbf7f876b444145f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157895
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [87e1a77a9aadb883386816dc4ebc3dad64c81892]

        tdf#156336 - sc ods: fix can't remove Calc comment metadata
        
        Remove Calc comment metadata (author, date) during ods export
        if the Remove personal information option is enable.
        
        Change-Id: I814aabb734cff4160dccf1913a33aa270c2edbf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158116
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-10-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9f9e195dbabe07244622924bf609ab4676f16993]

        tdf#157484 UI: Add UI controls for personal information to be kept
        
        or removed upon save.
        
        With the new options button we can keep the security infos upon save
        such as (even if we set the remove personal infos):
        
        - RedLine Info
        - Document User Info
        - Author and date of notes
        - Document version infos
        
        Also on the infobar, if we have a warning, clicking on the infobar button
        the security option dialog will open where we can set/modify these options.
        
        follow-up of: 1f440348eb0892fd2c9597806d87b5fe9d60d49a
        (tdf#157482 UI: Turn Security Warnings popup windows into infobars)
        
        Change-Id: I8d5d944d76dbdd31653401246113de097ca6d57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158112
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [27aea4de846810fcca5afe3788b0d0615d85bb30]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: chart2
        
        Change-Id: Ifcb57548a594cbbaf70df8d9da17cf94a96667db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158146
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [fee44aa4d5080af29ff0e663118ea1e629d53605]

        sc: return earlier if there is no pActiveViewSh
        
        See https://gerrit.libreoffice.org/c/core/+/158123
        
        Change-Id: Id9a27ca657377ba0a81009cdd2d27ce6aa4e2aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158140
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [826d673ac8870001a53a50a6142d66d510a67e4a]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: configmgr
        
        Change-Id: Id95245a309b3baa80d7cca63d980aa0657fb9eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158148
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [f680e7998cf963edf8e788723af004cee794d7ae]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: basegfx
        
        Change-Id: If228639806c49d77d1c1a36a8d536992e1402896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [7cd27b446193e5973ef73d207d0c6dfe5f0ddea9]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: comphelper
        
        Change-Id: I2a422f921739adf81131082d57ab7601dfb46d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158147
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  khushishikhu  <dpskhu13108@gmail.com>  [baf677e2f1130205df6e4a5cf0a94f4d9dc228a5]

        tdf#42982: Improve UNO API error reporting
        
        Change-Id: I16bd4bb935d02ff03422cb48d21a63e3d994d0b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157993
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [c12df614adde52cc558cf3503469efffea02dd5c]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: avmedia
        
        Change-Id: Ib56a05e171f485ad01cb54ed87e01c3536ea733d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [ce3569746922ec0888e436683846631e69bfb19e]

        Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: UnoControls
        
        Change-Id: Ib8b380be99ae23f314f226be6c81bc62a08c13b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158141
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Mike Kaganski  <mike.kaganski@collabora.com>  [29691361002154a34c3a617e75682af4cbc19048]

        Use std::span instead of sentinel elements
        
        Change-Id: Idcde4728f4db5b878c126c29c1953dff7c47f05a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158139
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-19  Michael Weghorn  <m.weghorn@posteo.de>  [2bf88c172c9c9d159344b95fb96073f4891a6c30]

        tdf#157696 wina11y: Switch from custom to IA2 text attributes
        
        So far, reporting text attributes on the a11y layer on
        Windows did not follow any standard/specification, but
        LibreOffice's custom attribute values were mostly reported
        as is (i.e. using the LibreOffice-internal attribute names
        and values), and assistive tooling had to interpret those in order
        to support reporting them to the user in a useful way.
        
        For example, NVDA has custom code in the LibreOffice-specific
        app module to do so. [1]
        
        Stop using our custom attributes and switch to the
        use of attributes according to the IAccessible2 text
        attributes specification [2] instead, which is the applicable
        specification for `IAccessibleText::get_attributes` that
        is implemented here.
        
        This implies that by reporting more IAccessible2 text attributes,
        those should "automatically" work if assistive tooling handles
        those, as is e.g. the case for NVDA and the the "invalid:spelling;"
        attribute for spelling errors, for which bridging to IA2 has
        been iplemented in
        
            Change-Id I54e5bcbb4bef4c73068243f91a3ee69c10326460
            tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attr
        
        (See also the other tdf#135922 commits preparing for this
        change.)
        
        A change in NVDA is still needed in addition to switch from only
        handling the custom values for LO to use the existing code
        path for handling IA2 text attrs instead.
        Pending pull request that implents this: [3]
        
        [1] https://github.com/nvaccess/nvda/blob/9878248c217156de4defe244d2df797d6b3bd0ca/source/appModules/soffice.py#L35-L137
        [2] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        [3] https://github.com/nvaccess/nvda/pull/15649
        
        Change-Id: I11492bb5d09d64fd153db1b73d97a331a98ee535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158090
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [d1d5900ca4d15caf3def78e3af8bb0d3fda98cf7]

        Use OUString instead of OUStringLiteral
        
        Change-Id: I0d49fa6c70c41b39b85f860ad648889be3613295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158136
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [6359969e230af2569bb68e75ecfd85d43f95e20b]

        Presumed loplugin:cppunitassertequals
        
        Change-Id: I8acd32ff2cf3bd1b72136fd40e93ce047909f677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158138
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [7a349aa4f338982f99675ad4eed9d7474cab1ff0]

        Suppress some upcoming loplugin:ostr OUStringLiteral -> OUString rewrites
        
        ...which would not work, as calling constexpr SbxVariable::MakeHashCode on those
        vars would no longer be constant expressions
        
        Change-Id: Ib848a6405dc270a1a5b9a92084fa2d063ea37892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158134
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [358b480be5e3146ee8edead9aed5998f011925e2]

        use more SdrObjList::begin/end in various
        
        Change-Id: If054626a10d3cbd3b168dd4e66ec7f08344d2c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158131
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1311dff66b83c6bb119cbb75231aa97f82fe994]

        use more SdrObjList::begin/end in sc
        
        Change-Id: I6b8614e4e8917f71308cda4caaeb714ae18885f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158130
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Stephan Bergmann  <sbergman@redhat.com>  [37298c29e775c0715c779e7d2be3902290556d17]

        Use std::u16string_view instead of OUStringLiteral
        
        Change-Id: I0a0a7badb25eea99632f734aa52231a9f3df67e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158137
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-19  Miklos Vajna  <vmiklos@collabora.com>  [322044e128d86b1fd4a09c42f4950bf0f1cf4535]

        uitest oneprocess mode: explicitly avoid this in the remaining tests
        
        These 11 suites depended on the UITest default to not use oneprocess
        mode. Explicitly avoid that mode in these suites, because they currently
        fail that way. This allows changing the default in the future, so new
        suites automatically benefit from the oneprocess mode (it runs faster,
        somewhat similar to cppunit).
        
        Change-Id: I8c493ca63310815c1364bb6182c3285a9c7fbd63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158128
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3e010829ab9d6b0b0ef48b67661774dd19f6de0]

        use more SdrObjList::begin/end in sd
        
        Change-Id: If39b6c561525bbf66d34edfbff0f1a3ef4531f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158129
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-19  Julien Nabet  <serval2412@yahoo.fr>  [1c15934170341bbcfb4671fdbb01c2259265b3e1]

        Related tdf#144256: remove m_pSharedConnectionManager
        
        to only use "m_xSharedConnectionManager".
        For this, it required some refactoring but except the removing, logic hasn't been changed.
        
        Change-Id: Iccfe5c45381f31019a0751a61cea6661c88188f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158107
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-19  Aml-Hassan-Abd-El-hamid  <aml.hassan.esmil@gmail.com>  [e0fd924cb3446f2c707ea173adc5b1aa81ac81c5]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I6f6f69cc97fada3ca3bbdead24c10f9099ff28b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158068
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-18  Pranam Lashkari  <lpranam@collabora.com>  [b83f069101f1e6d8aaac09a805f02bbc4c619e7a]

        LOK: send state of protected cells
        
        Change-Id: I432a3af50b6089faa80a28804d95d816af6cd278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154936
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 5f13751cefd725cb2a38e66c9484046e6141c6c2)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158150
        Tested-by: Jenkins

2023-10-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e7e5b43c4906d9f0e199f689addc29aa98916e6e]

        crashreporting: svx::SentenceEditWindow_Impl::CreateSpellPortions()
        
        cui/source/dialogs/SpellDialog.cxx:2005
        aRet[ aRet.size() - 1 ].sText += aLeftOverText;
        
        presumably aRet is empty() here
        
        a) don't bother appending if aLeftOverText is empty()
        b) don't crah if aRet is empty() and aLeftOverText is not
        
        Change-Id: Ie9a9585f572d8afb17183b479fb6f2cce5952aa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fdad35d096dc642c80998ae8f832ebca183f545e]

        Fix typo
        
        Change-Id: Ie54bc5f012d2de46363da9d19278736a732a1a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158125
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-18  Michael Stahl  <michael.stahl@allotropia.de>  [adef72f8411a49920a75d3ceee7c1dc61ca0a470]

        sw: fix stack overflow on kde45196-1.html
        
        Previously, the shell cursor was put onto a SwGrfNode in the top left
        corner, which is invalid, but didn't crash immediately.
        
        With commit b20ca8d951e8205c8b963c6b7407f984053b4094 the cursor is
        instead put onto the first SwTextNode in the body, which happens to be
        in a table, and the entire table is hidden; this causes an infinite
        recursion in SwCursorShell::UpdateCursorPos() because
        GetModelPositionForViewPoint() no longer moves it to SwGrfNode.
        
        So try to move the cursor out of a hidden node, which requires an
        additional change in SwCursor::IsSelOvr() to allow moving from a node
        without a frame to another node without a frame.
        
        Change-Id: Ia33c7b558755f7e8b65ea3ff2c46aea20be577dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158119
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [51678d9cf57085bac3c7eba998e0a6d364d36cb2]

        fix crash in ScInputHandler::ImplCreateEditEngine()
        
        See https://crashreport.libreoffice.org/stats/crash_details/1b2c45b0-6053-4628-94cc-f639899ceb39
        
        Regression from 5484657d2b1677b7e385ab6ef87ad64dcb9934e4
        "tdf#156209 Font size increases when copying from cell in edit mode"
        
        Change-Id: I84cac26087b0c8908c22bbb45056e309cd66a016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [6dc53be7d2eabc23e3d96bae94d38e56d37b2bb5]

        use more SdrObjList::begin/end in sw
        
        Change-Id: If882c1c7863618a313b2e06abacdbfa756dfff3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [baa67b2d7037bc5e289a144a81014f1fb42e68ed]

        use more SdrObjList::begin/end in svx
        
        Change-Id: I362a2e12492391338b63708e4b329fc77ac363c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Stephan Bergmann  <sbergman@redhat.com>  [ca58f649196ed6b4ce15d0db3935f7de4cb0f2ea]

        Extend /clr /std:c++20 char8_t workaround to old versions of VS 2022
        
        On IRC, pppregin now reported that she ran into the issue addressed by
        3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022 17.7.5" when
        using (a presumably old version of) VS 2022.  And
        <https://en.wikipedia.org/wiki/Microsoft_Visual_C%2B%2B#Internal_version_numbering>
        suggests that older versions of VS 2022 used _MSV_VER values 1930...1936, so
        cover those too here.
        
        Change-Id: Ifee80114c5cd39aeabc31907adafb03eb2f388e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158122
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-18  Stephan Bergmann  <sbergman@redhat.com>  [f8ad36a2ec1d60b96653cb5538ef6f6c34084583]

        loplugin:stringstatic
        
        Change-Id: I008c48a315841a2fb642410f210d770bd14bfef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [c546b33dde8760cdc8d9990e672cc8cb344e470e]

        cool#6893 cache the EditEngine for rendering
        
        to avoid re-allocating one constantly
        
        Change-Id: I7d6c97a7f68126979bd8a5c12cfd6e680a789d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Stephan Bergmann  <sbergman@redhat.com>  [871c37f782a53cec13bed724b90495197348aa29]

        loplugin:indentation
        
        Change-Id: If81844107209c3fb04d39c9f2b826b623068fc30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158120
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-18  Hossein  <hossein@libreoffice.org>  [e94cbd7dbf4a8c82f17522806a9011c89bf20865]

        Remove obsolete comments in basctl
        
        First comment was last updated with USHORT -> sal_uInt16 in
        a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
        68ec95b3f80408ae50897b043eed69a07d084df9 there is no remaining sal_uInt16
        left, and thus the comment is no longer relevant.
        
        Second comment was added in 1fac87f84723a3d6e7e13c091e39b09e0dea1aa5,
        but with changes in 444c242c51e6b049598359ea6cf98e34f611838b it is no
        longer relevant.
        
        Third comment was also last updated with USHORT -> sal_uInt16 in
        a2242be9c3551310027b341db53164ebd78bc6c8 but with the newer commit
        444c242c51e6b049598359ea6cf98e34f611838b it is no longer relevant.
        
        Change-Id: I9ed383f15a5b403740c0b8bcdd153d04bb1a2b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158111
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-18  Laurent Balland  <laurent.balland@mailo.fr>  [9a0018a356c89baf600a72eed8ee4ac927815b9b]

        Replace $baz by %foo for sanity checks
        
        Tools for sanity-checks like
        https://docs.weblate.org/en/latest/user/checks.html#percent-placeholders
        looks for percent instead of dollar
        Try to align with %1 as suggested by Chistian Lohmaier
        
        Change-Id: I97d353f452316b939f2eaf7d30e68b9aab9f83e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147493
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-10-18  Michael Stahl  <michael.stahl@allotropia.de>  [a4971aab4d57bf9177c55c3fb0e163e0db7c48fd]

        tdf#157517 vcl: PDF/UA export: add PDF/A extension schema to XMP
        
        ... if PDF/A is also enabled.  Thanks to Peter Wyatt for the example
        document.
        
        Change-Id: I2a5951e102ae28a4c998adafe8ab51caa2788e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158118
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-18  Regina Henschel  <rb.henschel@t-online.de>  [6c32d052011132e891dab3254bf2a2ea6f31e888]

        tdf#132605 Negative skew values in connector dialog
        
        The skew values of a standard connector can have negative values.
        Those are possible in ODF, rendered in LO and produced by dragging the
        handles. Only the dialog restricts the metric field to non negative
        values. The patch allows negative values now.
        
        Change-Id: I5174dccc1ed0ed8644e0f62a5d599eea4d5cdbaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157700
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-18  Miklos Vajna  <vmiklos@collabora.com>  [626fe9ab5ebebc4ef36e35f4aa597c03a3564d22]

        tdf#157573 sw floattable: fix incorrect lack of left margin after table
        
        Regression from d477fa8ac1b0d3ee81427217bbb5950278ab16db (sw floattable:
        unconditionally map <w:tblpPr> to SwFormatFlySplit, 2023-03-17), the
        paragraph after the anchor of the floating table in the document lost
        its left paragraph margin at a layout level.
        
        Turns out the problem was there earlier, but it was hidden for this
        specific document, because we used to map DOCX floating tables to Writer
        inline tables in some cases before. The real problem was introduced
        earlier, in my 50a1df360c907d8419ce49f098b6bc87a37a9956 (n#775899 sw:
        add FloattableNomargins compat flag, 2012-08-23), even a TODO was added
        to point out this will be problematic. The old bugdoc wants to get rid
        of margins, because the floating table is already shifting text towards
        the right, the new bugdoc wants to keep the original margin as the
        paragraph after the anchor is not wrapping.
        
        Fix the problem by reverting the older fix and re-fix the old document
        differently. Don't do changes to the paragraph margin: that's not a good
        idea. If there is enough anchor text, it'll lead to a visibly bad
        paragraph margin anyway. Instead of reducing the paragraph margin,
        reduce the width of the fly portion in the paragraphs that intersect
        with the floating table. That's reasonly straightforward to do, because
        SwTextFormatter::CalcFlyWidth() already has a case when we know we're
        intersecting with a floating table and we also know that the floating
        table is aligned to the left. In this case we can simply reduce the fly
        portion width with the paragraph margin. This keeps the old bugdoc fixed
        and fixes the new bugdoc.
        
        It also means that DocumentSettingId::FLOATTABLE_NOMARGINS is now
        effectively unused, but that's not yet removed in this change.
        
        Change-Id: Ibaccc4807fd8c11bd45955b76e96cd4a5e55976f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158103
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ae17d08c116e5865ba5448edfb415ea2d3f87c19]

        Drop duplicated forward declarations
        
        Change-Id: I0804518ce97e3f5f8098c4a4416675409746aaea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158044
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [680ae3e989c3b665b29f536c2e30dd86bbc3edac]

        tdf#156033 sw: Don't capture mouse when executing file dlg
        
        When the mouse is captured in
        `SwView::InsertGraphicDlg`, temporarily
        release it while executing the file dialog,
        so the user can use the mouse to interact with
        the file dialog.
        
        At least with qt5/qt6/kf5, this would otherwise
        not work in the file dialog shown after clicking
        on a previously inserted Picture Content Control,
        because `QWidget::grabMouse()`'s "other widgets
        get no mouse events at all" [1] apparently applies
        for the file dialog and other running applications
        as well.
        
        [1] https://doc.qt.io/qt-6/qwidget.html#grabMouse
        
        Change-Id: I80a81c57c80debc716a1b111a9c07eef0c005c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158109
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [25f4ef5aa5488869b3bad045ba203c6b22b2e2f0]

        tdf#157792 followup
        
        avoid doing some extra Invert() operations by creating an AlphaMask
        instead of a Bitmap to pass to the BitmapEx constructor.
        
        Change-Id: I1af3a5e65010b346fa0d0c56836d567e51c9b58b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158106
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [ec2e02cfa41510c3d30b118cbf7595c84a046d03]

        tdf#157696 a11y: Report spelling error via IA2 "invalid:spelling" attr
        
        Let `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes`
        also report spelling errors as a text attribute, since the
        "invalid:" text attribute with a value of "spelling" is specified
        for that in the IAccessible2 tex attributes specification [1].
        
        In order to adapt the start/end index for the attribute run,
        iterate over all of the text markups that can be retrieved from
        the `XAccessibleTextMarkup` interface instead of just deterining
        whether the offset itself lies within a range of misspelled text
        via `XAccessibleTextMarkup::getTextMarkupAtIndex`.
        (This is strongly inspired by how the gtk3 a11y implementation
        does it, s. `handle_text_markup_as_run_attribute` in
        vcl/unx/gtk3/a11y/atktext.cxx.)
        
        When using the qt6 VCL plugin on Linux, the attribute shows up as
        expected in Accerciser and the Orca screen reader announces
        "misspelled" when moving the cursor in front of a misspelled
        word using the Arrow_Right key.
        
        Announcement by NVDA works once winaccessibility and NVDA
        have been switched over to use IAccessible2 text attributes
        instead of custom LibreOffice ones.
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        
        Change-Id: I54e5bcbb4bef4c73068243f91a3ee69c10326460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158089
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [15a6e23c4fc160c50a316da3d18980a02fc10ce8]

        tdf#157696 qt a11y: Move handling for text attr offsets to helper
        
        Add a new method
        `AccessibleTextAttributeHelper::GetIAccessible2TextAttributes`
        and move some more of the logic from
        `QtAccessibleWidget::attributes` there to prepare adding handling
        for spelling errors via the "invalid:spelling" IAccessible2 text attribute
        and for reuse in winaccessibility.
        
        Change-Id: I3b4a89ee680437fa2c35c429639b372a55f5a4b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158088
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0280a9ef0d93bb2c8ec713b6dc36b77962b57e99]

        tdf#155410 shave 1% cost off SdrGroup::GetLayer
        
        by avoiding repeated indexed lookup into the std::deque inside
        SdrObjList
        
        Change-Id: Ifcf736d0ecef1239b8a236fe1937f347a3d49e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-18  Julien Nabet  <serval2412@yahoo.fr>  [4f48baedb56589d46ec978ce897d8104b8c216d8]

        Replace useless typedef OSharedConnection_BASE2 and replace it by its value
        
        Change-Id: I660813058077a36bcf80a3128b53767c851c2672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158105
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-18  Stephan Bergmann  <sbergman@redhat.com>  [b946842a744c2b869e5c01adf90335edf07f09ad]

        Clean up the remaining uses of OUStringConstExpr, and drop it
        
        Change-Id: I30b2ac77b58e2ae1d1e997a0c830c513542b973d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158101
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [35ea75e9c2be75a70298a3f4e7d703c1d0f9497e]

        qt: Drop now obsolete workaround for Qt < 5.12
        
        This workaround was only applied for Qt < 5.12 and
        is no longer needed now that support for Qt < 5.15 has
        been dropped in
        
            commit afb4c96d271958ced3175dfc2cf8bb9e8b0a9d3b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Aug 3 21:30:22 2023 +0200
        
                qt: Drop code for Qt < 5.15
        
        Commit originally adding the workaround:
        
            commit fe2baf9e84e0ca9aeaa683e37076f57fa3f38dca
            Author: Jan-Marek Glogowski <jan-marek.glogowski@extern.cib.de>
            Date:   Tue Dec 3 08:32:58 2019 +0100
        
                Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUP
        
                This is the application level equivalent of the Qt5 fix for bug
                QTBUG-46626 / commit 0de4b32 ("xcb: fix issue with dialogs hidden
                by other windows"), which was broken since Qt 5.4 and is just
                fixed since Qt 5.12.
        
                It is needed for some window managers, which don't know about the
                WM_CLIENT_LEADER property. Both settings are the same, but just
                the latter is set by older Qt5 releases. This probably isn't a
                real problem, as GNOME or XFCE would use the gtk VCL plugin, but
                since I already wrote the code when debugging tdf#129071, there
                is also no reason to drop it (except: more code, more bugs...).
        
                This fix is optional and needs development headers for xcb-icccm,
                which can actually be compiled into Qt5. If missing configure will
                just print a warning, since it's a runtime requirement and we
                explicitly drop the linked Qt version symbol, so the potential
                build Qt version won't matter.
        
                Change-Id: Ifc5a8f8a40ee13779a911efb53e8b8b868614d0b
                Reviewed-on: https://gerrit.libreoffice.org/84299
                Tested-by: Jenkins
                Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
                Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        
        Change-Id: I56b708449cf686f787f55256c76673be604d31e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158102
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-18  Julien Nabet  <serval2412@yahoo.fr>  [502fbd79f9d71d01a177c3cd77256ed6a5a544d8]

        Related tdf#144256: fix order of disposing in OSharedConnection
        
        In dbaccess/source/core/dataaccess/SharedConnection.hxx, we got:
        35      typedef ::cppu::WeakComponentImplHelper< css::sdbc::XConnection
        36                                             > OSharedConnection_BASE;
        37      typedef ::connectivity::OConnectionWrapper  OSharedConnection_BASE2;
        38
        39      class OSharedConnection :   public ::cppu::BaseMutex
        40                                , public OSharedConnection_BASE
        41                                , public OSharedConnection_BASE2
        
        so first OSharedConnection_BASE ctr is called before OConnectionWrapper ctr
        therefore OConnectionWrapper dtr should be called before OSharedConnection_BASE dtr
        
        It doesn't fix the bug but investigating in all this mess, I'd like to fix these things since it may help.
        
        Change-Id: I47255357b4ca02261f31ebf500f3f1ff55642e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158096
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-18  Mike Kaganski  <mike.kaganski@collabora.com>  [4fc2c23a42b7225f482ffc68d9e2cffed4cc1602]

        Simplify a bit
        
        Change-Id: I594b3317f8298966d59f8674b71bddd89998b9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158092
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-18  Miklos Vajna  <vmiklos@collabora.com>  [ca81a82cabe650af47cb73cfceb2800932104ae8]

        CppunitTest_sw_ooxmlexport8: clean up not needed preTest()
        
        This would set (and unset) custom configuration based on filenames, but
        the suite has no such files anymore, so this can be removed.
        
        Change-Id: I8f1dd40b62adcd71a0e4ae303c5d317943ef438b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158094
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-18  Michael Weghorn  <m.weghorn@posteo.de>  [afb4c96d271958ced3175dfc2cf8bb9e8b0a9d3b]

        qt: Drop code for Qt < 5.15
        
        Our new AlmaLinux 8 baseline provides Qt 5.15.3,
        so require 5.15 and drop the code for older, now
        unsupported Qt versions.
        
        Change-Id: I512ade1ba503fc7a86527a45142f37f043db6784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155325
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-18  Stephan Bergmann  <sbergman@redhat.com>  [c7cef7500105c6122df90900b3ba919e80c3bbb9]

        O[U]String move ctors should be constexpr, too
        
        ...similar to 5f2206e3ccf1cf64d2b11b0e5d419973269920a8 "O{U]String copy ctor
        should be constexpr", which will again be useful for some upcoming replacements
        of OUStringConstExpr with OUString, and making data actually constexpr.  (For
        example, the
        
          static o3tl::enumarray<INetProtocol, SchemeInfo> const map
        
        in INetURLObject::getSchemeInfo (tools/source/fsys/urlobj.cxx) can actually be
        constexpr, but the o3tl::enumarray ctor forwards its SchemeInfo arguments by
        forwarding references, so uses an implicitly generated constexpr SchemeInfo move
        ctor, which in turn requires constexpr member move ctors.  So when the m_sScheme
        member will be changed from rtl::OUStringConstExpr to OUString, the OUString
        move ctor better be constexpr.)
        
        Change-Id: Icfc5edbb8422919186517667f876ea90bec1be90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158099
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-18  Jim Raykowski  <raykowj@gmail.com>  [6320a4c21cf54d32c778417ee077d67fd0bad050]

        tdf#156114 UNO commands / menu entries to enable PS/CS spotlight
        
        Change-Id: I2796b595ef961c477dea85c337ad343599aea7cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158055
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-18  Justin Luth  <justin.luth@collabora.com>  [efafe9b1771b1c20bf27345cafbeb9e1b9e635eb]

        tdf#127038 sw notebookbar: remove redundant "more fields"
        
        .uno:InsertFieldCtrl includes all the fields plus "more fields".
        While it can be nice to include 1-click access
        to the most common fields, there is no need
        for 1-click access to the rather large "more fields",
        so it has been removed from the tabbed notebookbar ribbons.
        
        Change-Id: I5ebd394106a8d44832adb6dcd598f92e696f48a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158097
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7acd895d8a6ed16611a20873f3b2216fccef0634]

        tdf#45949, tdf#152492: move UITest to CppUnittest
        
        Disable the test on mac because it fails with
        
        Test name: testTdf45949::TestBody
        equality assertion failed
        - Expected: 2
        - Actual  : 1
        
        Change-Id: I366eba2db939b25f70a859c6622901c1e0f55718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158082
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [45c166c002e1204600039c6711113ade94996351]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7d08444f187ddea8a983565fc2c7fb8b2a38176c
          - tdf#155876 UI cmds Calc (04)
            
            + refactoring
            + Edit - cell edit mode
            
            Change-Id: I43bcbd6f0467f0e923450a3b74b197b7166db15c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158095
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85ed491ac9bd0ced02b61003da49d89b6b41f5ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3fa34a71832b722a496534970be68e63ff1c0b8
          - fix bad index entry
            
            Change-Id: I5cb5f87e727101700446e8b94ab854ece8a9c269
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157956
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [4be9bd0595cec36b6a22ca12b48661e080a5a1d8]

        tdf#157442: sw_uiwriter6: Add unittest
        
        gerrit_mac fails with
        
        [_RUN_____] testTdf157442::TestBody
        
        Error: a unit test failed, please do one of:
        make CppunitTest_sw_uiwriter6 CPPUNITTRACE="lldb --"       # for interactive debugging on macOS
        make CppunitTest_sw_uiwriter6 VALGRIND=memcheck            # for memory checking
        
        You can limit the execution to just one particular test by:
        
        make CppunitTest_sw_uiwriter6 CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...
        
        so disable it for now on mac
        
        Change-Id: Iaf51987010a976a3a38f264d6b45c8cc6eb7f283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158079
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-17  Noel Grandin  <noelgrandin@gmail.com>  [6347dcbd3ab2e0a7cb2f7de3bcb5d007e8befc09]

        disable more unreliable navigator UITest
        
        Change-Id: I5df1edd842f4b1ed0936f6b903c6d2b2ac3aad39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2de1554af354655be72e17bab50c132dd703c03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 020c1cb426fa951da23f51c1d93b59259ec87608
          - tdf#155876 UI cmds Calc (03)
            
            + refactoring
            + Edit - Select menu and commands
            
            Change-Id: I2c1e7c37cf40184391f04c29b0b6f49f43bef0e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158087
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [dcaa66e4663111f563eab54aae7e1d73e1ae8e44]

        tdf#157792 FILEOPEN: PPT: logo not displayed
        
        regression from
            commit 3622404f09448b82c095256140afe6240b522ece
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Oct 11 12:54:43 2023 +0200
            tdf#157636 FILEOPEN: PPT: Images have no background
        
        But actually from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ffe
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        where BitmapEx::CombineMaskOr was not properly updated.
        
        To make this stuff more obvious, add a version of CombineOr
        called AlphaCombineOr that only operates on AlphaMask objects.
        
        Change-Id: I8222bcdd7babefb748d21a71d02775c6a74bf068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-17  Julien Nabet  <serval2412@yahoo.fr>  [0875594b381e2765f2b6413074c470f9eec33201]

        Related tdf#157726: make iterators local to loops
        
        to avoid crash in debug mode, see bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=190245)
        
        + use != for iterator comparisons
        
        Change-Id: I5b1e502097d723e6acc17687171195d81c60dcbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158086
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-17  Matthew Kogan  <matthew@epoq.co.uk>  [d67d47bf0e9c9b24fb9aeed8807c31ed28d7fec2]

        tdf#154454 sw: make comparison of changed paragraph numbering optional
        
        by the new config option "DisplayChangedParagraphNumbering", as a
        temporary fix to hide incorrect changes in corner cases.
        
        Regression from commit 2413f213625253a9c2b1787b3b9fe859d724a9bd
        "tdf#115523 sw_redlinenum: show correct, also original numbering".
        
        Change-Id: I6d85033cc3f60ac1075501fedfcd4c9862e00a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157940
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-17  Michael Weghorn  <m.weghorn@posteo.de>  [d6d4cae126cf8e8fc73b54b852d75c8b0a0db65e]

        Bump Java build baseline from JDK 9 to 17
        
        As discussed in the ESC call on 2023-08-10 [1],
        bump the Java build baseline to 17.
        This should not affect the Java runtime requirement,
        since the target version is explicitly specified
        already.
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2023-August/090759.html
        
        Change-Id: I18251151392ca5edec8ca3d5cffd192d5f9f38b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155827
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-17  Justin Luth  <justin.luth@collabora.com>  [ce81efb31c311dc835d2e1572751964dbe8e6aa6]

        related tdf#141457 sc notebookbar: make statistics a submenu
        
        With so many different statistics commands,
        the super-popular insert menu was dreadfully long.
        
        And since it is a now single entry, might as well add it
        to all MenuDatas to keep them all pretty much identical.
        
        Change-Id: I89247a1806f884e92a52b66015c766180d89149e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158065
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-17  László Németh  <nemeth@numbertext.org>  [7d08767b890e723cd502b1c61d250924f695eb98]

        tdf#130088 tdf#119908 smart justify: fix DOCX line count + compat opt.
        
        Writer typeset DOCX files with more lines/pages, because of
        new default paragraph justification algorithm of MSO 2013 and
        newer, which resulted in losing text layout interoperability
        for new DOCX documents.
        
        Add new compatibility option "JustifyLinesWithShrinking" to
        store also the new type of justification in OpenDocument files.
        
        First analysis of the unknown justification algorithm shows
        up to 2% shrinking of plain justified line. Apply this value
        to break the lines in the same (or very similar) positions
        during importing a DOCX file with compatibilityMode >= 15
        (created in MSO 2013 or newer), to avoid typesetting more lines
        and pages.
        
        Note: shrinking will be added by the next commits, fixing
        the temporary exceeding lines.
        
        Change-Id: I9a00db888e9af3f6723e4c502158e8e56a00ef02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158063
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7273de2730022deb37a8c7f2fedbe7fc4551f9b5]

        check earlier on loading ole objects if parent doc is untrusted referer
        
        Change-Id: Ib1169d5c40ca87f789c71b48124754e073895fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158054
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-17  Miklos Vajna  <vmiklos@collabora.com>  [40b8b9ee5fb6de66ee455f8ffd64750e59f0587a]

        n#775899 sw: add testcase for the FloattableNomargins compat flag
        
        This was added in commit 50a1df360c907d8419ce49f098b6bc87a37a9956
        (n#775899 sw: add FloattableNomargins compat flag, 2012-08-23), without
        a testcase, so it was hard to make later changes without breaking the
        old behavior.
        
        Later commit 0898871b7b9492ada947ebc7b8429c5cb56db23c (n#775899
        testcase, 2012-08-27) did add a testcase for the bug, it was a different
        sub-task there, so the test document had no margins, while this compat
        flag is about some special handling around non-zero paragraph margins
        and floating tables.
        
        So add a new test that fails without the
        DocumentSettingId::FLOATTABLE_NOMARGINS block in
        SwBorderAttrs::CalcLeft() to make sure that this keeps working after I
        fix tdf#157573, which is a related problem.
        
        Change-Id: I09661be726e3db6be51d0cbb44cb5c504510e5ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158069
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-17  Irgaliev Amin  <irgaliev01@mail.ru>  [0e14912af0c449396f10c2ae4be3c7f2a3a98bc2]

        tdf#157788 Saving the "Show navigation panel" setting for a device
        
        Currently, the value of the "Show navigation panel" parameter for
        presentations is not saved. The section in which this setting is
        now located, apparently, is saved in files. It might make sense
        to move this setting to Tools -> Options -> LibreOffice Impress -> General,
        because it relates to the device rather than the slideshow.
        
        Change-Id: I2286a4a6d432b11fce2b9c3e65fa6b82e004275f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158057
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [07a80b8940a16ba1b7fd047865179809bd74a563]

        tdf#157786: sc_datetime_functions: Add unittest
        
        Change-Id: I94f2d40ced8e59aea5875831289368722a58c42a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158056
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-17  Miklos Vajna  <vmiklos@collabora.com>  [a55e2ad714ff941a2aa2c725ffbc1057fbd9baf5]

        svx: prefix members of SdrHdlList
        
        See tdf#94879 for motivation.
        
        Change-Id: I9e529ef12c05e333e2eeb535d2ae72e5d4c84a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158062
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-17  Michael Weghorn  <m.weghorn@posteo.de>  [ca01deadcbc480b6e79618b227a2b73a61ecb7ff]

        gtk3 a11y test: Let xvfb-run auto-determine free server num
        
        As the xvfb-run manpage says, it uses a default server number of 99:
        
        >      -n servernumber, --server-num=servernumber
        >             Use servernumber as the server number (but see the -a, --auto-servernum option above).  The default is 99.
        
        The gtk3 a11y tests use xvfb-run. Running the test multiple
        times in parallel (e.g. when doing two separate builds with
        tests, as happens on CI) would fall like this on Debian testing:
        
            $ make CppunitTest_vcl_gtk3_a11y
            make -j 12 -rs -f /home/michi/development/git/libreoffice/Makefile.gbuild CppunitTest_vcl_gtk3_a11y
            [CUT] vcl_gtk3_a11y
            xvfb-run: error: Xvfb failed to start
            Hint: You are currently not seeing messages from other users and the system.
                  Users in groups 'adm', 'systemd-journal' can see all messages.
                  Pass -q to turn off this notice.
            No coredumps found.
        
            Error: a unit test failed, please do one of:
        
            make CppunitTest_vcl_gtk3_a11y CPPUNITTRACE="gdb --args"
                # for interactive debugging on Linux
            make CppunitTest_vcl_gtk3_a11y VALGRIND=memcheck
                # for memory checking
            make CppunitTest_vcl_gtk3_a11y DEBUGCPPUNIT=TRUE
                # for exception catching
        
            You can limit the execution to just one particular test by:
        
            make CPPUNIT_TEST_NAME="testXYZ" ...above mentioned params...
        
        However, it behaves differently on Alma Linux 8, where it
        looks like xvfb-run seems then to reuse the existing
        Xfvb session, causing the tests to potentially find
        the LibreOffice instance from another test run, and
        then inspecting the wrong one, leading to failures
        like the one in [1]:
        
            equality assertion failed
            - Expected: ecclectic.fodt — LibreOfficeDev Writer
            - Actual  : ecclectic.fodt — LibreOfficeDev Writer 24.2 [9bc2aede99017ed0338e97b21b4735919b705b47]
        
        The fact that the second instance of xvfb-run
        reuses the session of the firs one and finds the
        LibreOffice there can also be reproduced on Alma Linux 8
        by just running these 2 commands in parallel:
        
        1) start LO in xfvb-run session:
        
            $ xvfb-run dbus-launch libreoffice
        
        2) run below Python script that lists the
           running applications:
        
            $ xvfb-run dbus-launch python3 /home/vagrant/atspi-list-apps.py
            --------start--------
            [application | soffice]
            --------end--------
            /usr/bin/xvfb-run: line 186: kill: (27078) - No such process
        
        This *should not* list the applications from
        the other xfvb-run.
        
        It works as expected when passing `--auto-servernum`:
        
            $ xvfb-run --auto-servernum dbus-launch python3 /home/vagrant/atspi-list-apps.py
            --------start--------
            --------end--------
        
        Therefore, pass the `--auto-servernum` arg to xvfb-run, so that it
        automatically determines a free server number instead.
        
        >      -a, --auto-servernum
        >             Try to get a free server number, starting at 99, or the argument to --server-num.
        
        Python script mentioned above used for testing:
        
            $ cat atspi-list-apps.py
            #!/usr/bin/python3
        
            import pyatspi
        
            registry = pyatspi.registry.Registry()
            apps = list(registry.getDesktop(0))
        
            print('--------start--------')
        
            for app in apps:
                print(f'{app}')
        
            print('--------end--------')
        
        [1] https://ci.libreoffice.org/job/gerrit_linux_gcc_release/151750/consoleFull#-1985341263d893063f-7f3d-4b7e-b56f-4e0f225817cd
        
        Change-Id: I0673212fb8fed5c9698c9f797b7bf49ba51033b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158021
        Tested-by: Jenkins
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-17  Mike Kaganski  <mike.kaganski@collabora.com>  [d4efce34e0bd1e99d115ece4442ead39b90b89bb]

        tdf#148725: Reset must clear respective items from m_pOutSet
        
        After Reset, the tabbed dialog's output set should restore to the same
        state (concerning the current tab page) as immediately after creation.
        This state means that pressing OK immediately afer Reset would not try
        to set or remove any items in the target. SfxTabDialogController::Ok
        has this code:
        
            if (m_pOutSet && m_pOutSet->Count() > 0)
                bModified = true;
        
        meaning that m_pOutSet is expected to be empty in case of completely
        unmodified dialog; and Reset must make sure this for a given page.
        
        Instead, commit 28fc0962b10519ab84654d189d2ad0cca8f84f95 (weld SwLabDlg,
        2018-04-27) made Reset handler to populate the output item set with all
        the items from the input set, that belong to the page's which ranges.
        This made all the settings set in parents (which therefore appeared in
        the input set) to be set directly in the target upon application.
        
        Change-Id: Iacfffb5670cc3ade950ac412b818acb482845255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158067
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-17  Mike Kaganski  <mike.kaganski@collabora.com>  [e134bcf0272929ebba8edc35ae0bdd8f934e624a]

        Related: tdf#148725 Fix SvxExtParagraphTabPage::ChangesApplied
        
        It was setting values, instead of saving them, ever since commit
        a212ef2b6ebadb22a9abf6d042aa2b5fd9ac1cf0 (tdf#93901: apply handling in
        style/edit dialog improved, 2015-09-11).
        
        The same thing in SvxStdParagraphTabPage::ChangesApplied was fixed in
        commit 8b0dae14a5af0ad2892bac0e606467af6148c8d1 (weld
        SvxStdParagraphTabPage, 2018-06-14); but a similar commit
        eb1d6b16e787a87c3d918135ca98c5694d352557 (weld SvxExtParagraphTabPage,
        2018-06-14) kept this in SvxExtParagraphTabPage.
        
        Change-Id: I5fb61a9416dab4ccf9fa690eca87a16f7b9378bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158066
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-17  Jim Raykowski  <raykowj@gmail.com>  [2a05fd0fd2b6c4ad8fd900565f3640f1ef47a165]

        tdf#144349 related: Make master document navigator track Text content
        
        Done, with a related patch to make the master document navigator track TOX content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item
        
        Change-Id: I1a9d2a12a01ca2c5f3f162e8da932c04ced9a461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157741
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-17  Jim Raykowski  <raykowj@gmail.com>  [b97aa4eada3164b20f663a9817e92af78495109f]

        tdf#144349 related: Make master document navigator track TOX content
        
        Done, with a related patch to make the master document navigator track 'Text' content, to make the Navigator less likely not to have an item selected, which may be enough to resolve tdf#155741 - Allow insertion of items into master without a selected item
        
        Change-Id: I6df1b668c502cadbe057229e031ede9aa4f4089a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157695
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-16  Eike Rathke  <erack@redhat.com>  [3161a6c351a2f5f70c0420ee8cccf2eb23de1ecf]

        Resolves: tdf#157797 Let GetCellValue() propagate previous error, if any
        
        Change-Id: I27ee8d19e4f45bef81e133c82ac17b825790208f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158064
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-10-16  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1f440348eb0892fd2c9597806d87b5fe9d60d49a]

        tdf#157482 UI: Turn Security Warnings popup windows into infobars
        
        In case of all the 4 security warnings we will have a new infobar warning
        dialog message with an infobar button which can open the security windows
        option settings and we can set which security issues should warn us, and also
        which security infos we want to remove. (etc after saving)
        
        TODO: If the directly the file dialog window pop up the Infobar message will only
        update after closing the file dialog window. That should be fixed later.
        
        Change-Id: Idf0f728fd40089d3691f8f044d3718a4e0d99cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157797
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2247b00230e479e63ab996d4e1694b1d74aeba81]

        Simplify a bit
        
        Non-negative nCommentPos implies non-empty selection.
        
        Change-Id: Id3e5701fbddca3159d81513d8c7d54816e45e4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158060
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2b8b6ced7c67e6a56f06b02e92f0555a796f3b16]

        Simplify a bit
        
        Change-Id: Ic621da194d92e3a4202c47ec4828272e8102a146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158061
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [e99936639379acfe7949b6b77d3b401990f50dde]

        Execute notifyViewRenderState on view constructor
        
        notifyViewRenderState should be executed as soon as a view is created in
        order to give a view id to the client
        
        Change-Id: I31b7e61599f546bd5ec134775e6235633a6526f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154681
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        (cherry picked from commit 6c6bb1d434d5c0be2f71470483f3ce56f5210e01)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154709
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [00904f994a2f03638ec7f284396aeb730746e68d]

        ofz#63295 Null-dereference READ
        
        Change-Id: Ib8bfa814099c1c1f3d65b18026ea812c80b6e9c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Michael Weghorn  <m.weghorn@posteo.de>  [f8be1b73847514bb8e2054dc6d8a62e00682ab78]

        qtcreator: Specify C++ std version using CONFIG qmake var
        
        Extract the C++ standard version to use that is specified
        by a `-std=<version>` or `-std:<version>` compiler flag,
        and set that via "CONFIG += <version>" in the .pro files
        used by Qt Creator.
        
        This makes the Clang Code Model use the correct mode
        and no longer complain about `char8_t` after the
        switch to C++20 in my Windows development setup
        in Qt Creator:
        
        > accessibletabbarpagelist.hxx:22:10: In included file: use of undeclared identifier 'char8_t'
        > stringutils.hxx:252:31: error occurred here
        
        The previous way of specifying this via
        `QMAKE_CXXFLAGS` as introduced in
        
            commit 92c03d9bf644b0f10de52ce0da09f97056e46247
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jun 7 21:44:03 2019 +0200
        
                qtcreator: Take over '-std=...' from CXXFLAGS
        
        appears to not (no longer?) work at least with Qt Creator 11.0.3
        on Windows.
        
        On the contrary however, setting only `CONFIG` and
        not `QMAKE_CXXFLAGS` causes the exact same problem
        in my Linux setup.
        
        Therefore, set both qmake variables.
        
        Note that there is a specific set of accepted values
        for the the `CONFIG` variable in .pro files [1],
        but at least "c++20" and "c++latest" are accepted
        and have the expected meaning, so that should be
        fine for now.
        
        [1] https://doc.qt.io/qt-6/qmake-variable-reference.html#config
        
        Change-Id: Idc75b74300c7bdd0f6193fcfc1758b536728b887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158053
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [f26bf09a0e93449ea85269a09a8a073a20903349]

        tdf#141892: Set chart view to dirty state after loading
        
        Previously, ChartViewHelper::setViewToDirtyState was only called in
        ChartModel::impl_notifyModifiedListeners during the load process of
        inline charts; after commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc,
        the chart doesn't set its modified state when loading, and thus the
        view did not get notified about the necessary updates.
        
        This change introduces a hidden property in ChartDocumentWrapper,
        named 'ODFImport_UpdateView', which is set in SchXMLImport dtor
        to force the notification after the loading.
        
        Change-Id: Id9d82f16d233d2172cd6808a8498822e13b21b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158051
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [6506279e3bed2284ce0ec9a0957a0201eb0d72ae]

        tdf#157776: Do not set chart and its parent modified when painting
        
        When the chart is painted for the first time, its update may create
        the initial set of objects, which used to set modified state after
        loading documents.
        
        Change-Id: Ie50ef34875440058020486192fe649b492e4baf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158015
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [be71e660fd29a714466bf041a6b9b394b9fdbf08]

        Fix UITests on Windows
        
        ... after commit 0d21e1075f0288a007cb427ce508d6fbbf8503dd (uitest:
        add signal_handler function, 2023-10-04), which added handlers
        unconditionally, for signals unavailable on Windows.
        
        Change-Id: I8b177c4110f869781b2501ee6f15ae7ff4862a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158050
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [267be127f2899f2e1b1f15b5a06707a9b83fcab4]

        retain Referer information available in OCommonEmbeddedObject ctor
        
        Change-Id: I2cb901e81de3b7db73cd2088348ddad46ae603dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158052
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Szymon Kłos  <szymon.klos@collabora.com>  [245c76630f86695234840601e76067388b740de2]

        jsdialog: enable Hyperlink Dialog
        
        - removed old "tunneled window" test for hyperlink dialog
          which cannot work when using jsdialogs
        
        Change-Id: I62b6c568149d4ea4656b23c47f4c79efe61abfb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156668
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157022
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [97841488696a58a930f334b495a57c244d63c0f7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfa69e84f71bced00eb552b0da554907f32794f5
          - clarify which files are saved in steps of Firebird wizard
            
            Change-Id: If8cb4036ce5582d272079cdf29ddb856ce0b5b85
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157977
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [878c2da6d2d5576d6c3266b38eae4ac80bcbe2c1]

        Related: tdf#157726 restore try/catch block
        
        before
        
        commit de42529ca9107b24b6367b40801300416d4a51a1
        Date:   Wed Sep 6 14:49:19 2023 +0200
        
            replace svx::PropertyValueProvider with simpler implementation
        
        PropertyChangeNotifier::notifyPropertyChange had a try/catch, but
        afterwards SvxShape::notifyPropertyChange doesn't
        
        Change-Id: If78732bea08d0f760b3b616ad55d28d40fa50fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158026
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1bdd38f6a86cebfa9d40e0a0136c1a9066c90661]

        Resolves: tdf#157726 missing chart from Base report
        
        since:
        
        commit c9b5c627ccb5b70c103c559b1df38c1175efc2d1
        Author: Caolán McNamara <caolan.mcnamara@collabora.com>
        Date:   Wed Sep 6 10:05:23 2023 +0100
        
            add referer to ole objects
        
        Change-Id: I9ef18bf0d734dd900bdbcac475ca15af7b15456e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Eike Rathke  <erack@redhat.com>  [2fa1cdcaeff7d1583aedfcee5b7c802e951b3a86]

        Resolves: tdf#157786 Use GetFloor32() for date days instead of GetInt32()
        
        Change-Id: I1d6242b516f4b23473151bb99cbdf1a057a15746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158029
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-10-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2b1aaa84e28d0def9f845deb4c105ea4c7b252c6]

        check return of get_iter_abs_pos
        
        Change-Id: Ifdabd65dc9fa5bc6d0c5c6eee1318f99bf918cd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [8ff7d75c1929876743b01d9651ea30928673433f]

        Revert "Resolves tdf#156685 - "Object without fill" style for tables"
        
        This reverts commit 86eb7ad2b4488dcd29c21ae3fc525056b681e199.
        
        Reason for revert: More generic solution in I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
        
        Change-Id: Ie2769a90f776602e38fc2795e08d591f9ae8d618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158035
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-16  Heiko Tietze  <tietze.heiko@gmail.com>  [f07d47fff571c4446988715f3c21362b9eed4265]

        Related tdf#156182 - Keep legacy contrast for default background
        
        Band aid for follow-up issues, eg. tdf#157706, tdf#157706...
        
        Change-Id: I1ca8cfe539a662100f6c581fd633ab1ebd5c6bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158024
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-16  Justin Luth  <justin.luth@collabora.com>  [f5a2192effbf52b2e64e4a40f325b1b42285833c]

        tdf#148539 sc notebookbar: add Sparklines to MenuData
        
        Sparklines do not have an icon yet,
        so I didn't attempt to add any (visible) entries
        to the notebookbar itself.
        
        Change-Id: I144ff76306aef0ec184794878a449e0cefd09280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157978
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-16  Justin Luth  <justin.luth@collabora.com>  [956b07c825d55f6c7556d55046c5f75e376f22f1]

        tdf#115485 sc notebookbar: add MenuInsert-RandomNumber...
        
        Change-Id: I916fd3cb1b39d2d53c77907381dd7d42d3327d63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157986
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-16  Stephan Bergmann  <sbergman@redhat.com>  [f7371ed8c19be57a9dac02d143151556eaab523a]

        Silence UBSan misaligned-pointer-use
        
        ...as seen during CppunitTest_sd_import_tests2,
        
        > pixman-sse2.c:522:16: runtime error: load of misaligned address 0x5170000a4f83 for type 'const uint32_t *' (aka 'const unsigned int *'), which requires 4 byte alignment
        > 0x5170000a4f83: note: pointer points here
        >  00  b8 ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff c0 00  b8 ff ff ff ff ff ff
        >               ^
        >  #0 in combine1 at workdir/UnpackedTarball/pixman/pixman/pixman-sse2.c:522:5
        >  #1 in sse2_combine_add_u at workdir/UnpackedTarball/pixman/pixman/pixman-sse2.c:1366:6
        >  #2 in sse2_composite_add_8_8 at workdir/UnpackedTarball/pixman/pixman/pixman-sse2.c:4490:2
        >  #3 in add_glyphs at workdir/UnpackedTarball/pixman/pixman/pixman-glyph.c:615:6
        >  #4 in pixman_composite_glyphs at workdir/UnpackedTarball/pixman/pixman/pixman-glyph.c:673:5
        >  #5 in composite_glyphs at workdir/UnpackedTarball/cairo/src/cairo-image-compositor.c:941:2
        >  #6 in composite_glyphs at workdir/UnpackedTarball/cairo/src/cairo-traps-compositor.c:2295:12
        >  #7 in clip_and_composite at workdir/UnpackedTarball/cairo/src/cairo-traps-compositor.c:1049:15
        >  #8 in _cairo_traps_compositor_glyphs at workdir/UnpackedTarball/cairo/src/cairo-traps-compositor.c:2331:11
        >  #9 in _cairo_compositor_glyphs at workdir/UnpackedTarball/cairo/src/cairo-compositor.c:292:11
        >  #10 in _cairo_image_surface_glyphs at workdir/UnpackedTarball/cairo/src/cairo-image-surface.c:1030:12
        >  #11 in _cairo_surface_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-surface.c:2920:15
        >  #12 in _cairo_gstate_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-gstate.c:2077:15
        >  #13 in _cairo_default_context_glyphs at workdir/UnpackedTarball/cairo/src/cairo-default-context.c:1334:12
        >  #14 in cairo_show_glyphs at workdir/UnpackedTarball/cairo/src/cairo.c:3670:14
        >  #15 in CairoTextRender::DrawTextLayout(GenericSalLayout const&, SalGraphics const&) at vcl/unx/generic/gdi/cairotextrender.cxx:476:9
        >  #16 in SvpSalGraphics::DrawTextLayout(GenericSalLayout const&) at vcl/headless/svptext.cxx:72:23
        >  #17 in GenericSalLayout::DrawText(SalGraphics&) const at vcl/source/gdi/CommonSalLayout.cxx:171:18
        >  #18 in OutputDevice::ImplDrawTextDirect(SalLayout&, bool) at vcl/source/outdev/text.cxx:331:16
        >  #19 in OutputDevice::ImplDrawText(SalLayout&) at vcl/source/outdev/text.cxx:482:9
        >  #20 in OutputDevice::DrawTextArray(Point const&, rtl::OUString const&, KernArraySpan, std::span<unsigned char const, 18446744073709551615ul>, int, int, SalLayoutFlags, SalLayoutGlyphs const*) at vcl/source/outdev/text.cxx:951:9
        >  #21 in drawinglayer::processor2d::VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D(drawinglayer::primitive2d::TextSimplePortionPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:422:33
        >  #22 in drawinglayer::processor2d::VclPixelProcessor2D::processTextSimplePortionPrimitive2D(drawinglayer::primitive2d::TextSimplePortionPrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:404:9
        >  #23 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:200:13
        >  #24 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #25 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #26 in drawinglayer::primitive2d::GroupPrimitive2D::getChildren(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&) const at include/drawinglayer/primitive2d/groupprimitive2d.hxx:76:90
        >  #27 in drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/groupprimitive2d.cxx:53:13
        >  #28 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #29 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #30 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #31 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #32 in drawinglayer::primitive2d::GroupPrimitive2D::getChildren(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&) const at include/drawinglayer/primitive2d/groupprimitive2d.hxx:76:90
        >  #33 in drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/groupprimitive2d.cxx:53:13
        >  #34 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #35 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #36 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #37 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #38 in drawinglayer::primitive2d::GroupPrimitive2D::getChildren(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&) const at include/drawinglayer/primitive2d/groupprimitive2d.hxx:76:90
        >  #39 in drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/groupprimitive2d.cxx:53:13
        >  #40 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #41 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #42 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #43 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #44 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >  #45 in drawinglayer::primitive2d::SdrTextPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at svx/source/sdr/primitive2d/sdrtextprimitive2d.cxx:235:47
        >  #46 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #47 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #48 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #49 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #50 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >  #51 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #52 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #53 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #54 in sdr::contact::ObjectContactOfPageView::DoProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:279:31
        >  #55 in sdr::contact::ObjectContactOfPageView::ProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:117:21
        >  #56 in SdrPageWindow::RedrawAll(sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/sdrpagewindow.cxx:354:28
        >  #57 in SdrPageView::CompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpagv.cxx:239:18
        >  #58 in SdrPaintView::DoCompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:610:21
        >  #59 in SdrPaintView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:523:5
        >  #60 in sd::View::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/sdview.cxx:498:17
        >  #61 in sd::DrawView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/drawview.cxx:517:17
        >  #62 in sd::DrawDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short, bool) at sd/source/ui/docshell/docshel2.cxx:112:12
        >  #63 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:204:5
        >  #64 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:151:9
        >  #65 in SfxObjectShell::CreatePreview_Impl(bool, VirtualDevice*, GDIMetaFile*) const at sfx2/source/doc/objcont.cxx:197:40
        >  #66 in SfxObjectShell::GetPreviewBitmap() const at sfx2/source/doc/objcont.cxx:109:9
        >  #67 in SfxObjectShell::WriteThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::io::XStream> const&) at sfx2/source/doc/objstor.cxx:3738:31
        >  #68 in SfxObjectShell::GenerateAndStoreThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) at sfx2/source/doc/objstor.cxx:3696:33
        >  #69 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) at sfx2/source/doc/objstor.cxx:1469:19
        >  #70 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:2992:39
        >  #71 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objstor.cxx:2782:9
        >  #72 in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t>>, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/objserv.cxx:319:19
        >  #73 in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) at sfx2/source/doc/sfxbasemodel.cxx:3191:42
        >  #74 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1801:13
        >  #75 in UnoApiTest::saveWithParams(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at test/source/unoapi_test.cxx:213:16
        >  #76 in UnoApiTest::save(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:178:5
        >  #77 in UnoApiTest::saveAndReload(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:218:5
        >  #78 in testOverflowBehaviorClip::TestBody() at sd/qa/unit/import-tests2.cxx:1899:5
        
        Change-Id: Iea3e107608137c4dec9103ee0b04e801284b5fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158018
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-16  Attila Szűcs  <attila.szucs@collabora.com>  [3649dc202bedf72e37c77993a1f7027bfdfc6d9e]

        LOK: Navigator: fix expand problems
        
        Save/load content types' expanded status to view, and make sure it
        is synchronized with client.
        Treeviews now receive/send collapse event/status from/to client.
        I've rewritten the way how headings are opened by default
        (because synch of collapsed status broke that, as sub-headings
        were not expanded at core side).
        
        Change-Id: I80f5b4d99fe5224391a92c4609f94ddbcf37b8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153771
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit b95750af717e0693a13c3ef35277779e1394e0ae)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158016
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Attila Szűcs  <attila.szucs@collabora.com>  [94426f366beff15784bcd2cd852c980e8d5a4467]

        LOK: fix for navigator: hide empty contentTypes
        
        fixed that opening heading by default, first check if headings
        are not hidden, because it blindly opened the 1. type, but
        from now, that can be an other type, or nothing
        
        Change-Id: I86cac472d8cba9a46befc5a84ef073c01fa7243d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152779
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 61e2022110d3088bc1653713dc270beaacae4c74)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157966
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [7215ac4ded82da0c0efc6a5d9465f632e8e8a4b6]

        tdf#157776: Do not send delayed update notifications for setModified(false)
        
        Change-Id: I4948cc217079d2ed535b95e3892e619736237cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158014
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-16  Eike Rathke  <erack@redhat.com>  [c25eaf109a64ae90473b09134540832dafa936c3]

        Factor out an occurrence of sumNeumaierNormal()
        
        Change-Id: I693f78be36005cd1fc387a2878112de60bd24905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158012
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-10-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [cfba837abe3137b2bb20ddb414bb91078c4a1c9f]

        Revert "Make sure views get new themes on .uno:ChangeTheme"
        
        Seems to cause more issues than it solves, reverting for now
        
        This reverts commit 884fd220d0025a92510d3ff4710c8c517c8f271e.
        
        Change-Id: If32a9d3bd922afe5611e5258987eec9ec685bc8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157951
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-10-16  Miklos Vajna  <vmiklos@collabora.com>  [33ade4171a1a443fd24e6463a9eaa279f7d778bb]

        sw floattable, wrap on all pages: add DOCX filter
        
        - map DocumentSettingId::ALLOW_TEXT_AFTER_FLOATING_TABLE_BREAK to
          <w:compatSetting w:name="allowTextAfterFloatingTableBreak"> on export
        
        - do the opposite on import
        
          - this requires a bit of rework, to avoid routing <w:compatSetting>
            via a grab-bag when we want to actually read it during import
        
          - also expose GetBooleanValue() from the OOXML tokenizer, so dmapper
            can know when the value of the compat flag is a true-like string.
        
        Note that it seems DOC and RTF don't have a matching compat flag for
        this.
        
        Change-Id: I0cb1230ee40994f59b816c42f8e7d2ac658b3212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158013
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-16  Pranam Lashkari  <lpranam@collabora.com>  [5af582071da444af338c8cd0a9657f73f9a5f52f]

        LOK: update navigator instantly on heading level change
        
        problem:
        i.e: when you change the header level,
        it was not reflected instantly in navigator and required reopening it.
        That was due to header level change was not registed as change in LOK case
        
        Change-Id: I503eb6a3fe9d2801ea5b45b0a1096e8174360ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156239
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        (cherry picked from commit 1fca94be7fafc305cf02c0134fbc2d7e5cfb2a03)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157967
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-16  Miklos Vajna  <vmiklos@collabora.com>  [d254ec0e8e7be6cd42e70998df7b8d0f3233a0fb]

        xmloff: document the ContinuousEndnotes Writer setting
        
        Change-Id: I37d223092cc2ff5ccfdaf39424ba9dca2b9b1ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157941
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [fab52afe822d08fdb9aa06668e02967bc85ae2c1]

        -Wimplicit-function-declaration
        
        Change-Id: Id78f5378566b35da6212bd2ff71d988956e682f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157994
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [d3a0815b12c0d040e99e22e53f6574726b868ec7]

        Drop OStringConstExpr, use constexpr OString instead
        
        Change-Id: Ibb41a27fe7d5456d8db0c98821d5b2acf8586b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157949
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [b4844c310bd9897fef59e8a4da0513100ea86096]

        Repurpose loplugin:stringstatic for O[U]String vars that can be constexpr
        
        ...now that warning about O[U]String vars that could be O[U]StringLiteral is no
        longer useful
        
        Change-Id: I389e72038171f28482049b41f6224257dd11f452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157992
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Julien Nabet  <serval2412@yahoo.fr>  [8797ba5e5d63151837ba443e1aea9d0997b6b7ab]

        Typo: Unfortuantely->Unfortunately (python3/ExternalProject_python3.mk)
        
        Change-Id: I80d316c76196d8cdda4b2ad509d2d1b53b5c414a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157991
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-15  Marco Cecchetti  <marco.cecchetti@collabora.com>  [48b6965c1cbbd8087d476c74fc2c20faa3e5e2a8]

        fixup for: 7523efa svg export filter: not export hidden slides
        
        It seems that the Visible property does not always exist
        
        That was causing a failure in Online Impress:
        - swicth to master view
        - select any object in the master slide
        - result: the object is not selected or getting focus and the server
        report an error
        
        Change-Id: I77b0211c6e13da1804457ba48098bbee821b7d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153049
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-15  Marco Cecchetti  <marco.cecchetti@collabora.com>  [ca62ba974cc9ff737b82a450aabe7b8ef778207c]

        svg export filter: not export hidden slides
        
        Change-Id: I6010f27812a783fd27a423a0f34e30a1b0c584f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152798
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 7523efa63a1334b36ad0a602054423b7f3c629b8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157727
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [37cc752dda0bfe8656baafe299734e63c431b630]

        pStringIds can be constexpr
        
        This array lacked being const[expr], presumably accidentally, ever since it got
        introduced in 2d1f08d63942666c0094904f50ba8c512ab69b9d "CWS-TOOLING: integrate
        CWS otf01".
        
        Change-Id: Ia8f8207ed5b0668356cafd284d4de595b5890cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157948
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Eike Rathke  <erack@redhat.com>  [361c4f008e48b08df635839d2e5dcad7389df44a]

        Follow-up: tdf#156985 Use SC_USE_SSE2 to determine which KahanSum::add() to use
        
        Also, the CPU identifier for MSVC WIN32 is not X86 but INTEL, so
        actually use SSE2 there as well, which was the cause of things
        failing on that platform.
        
        For other platforms than Intel x86/x86_64 SSE2 is not defined, so
        exclude the new unit test based on that and live on with the old
        slightly off value. Experiments did not yield any solution that
        works, even using plain sumNeumaierNormal() (similar to SSE2) in
        the executeUnrolled() case instead of KahanSum with its m_fMem did
        not help, nor trying to add the internal values in different
        orders or with long double, au contraire the error was slightly
        larger.
        
        Change-Id: Ica0b2963f76c01f248799e9a809ef06eb099e722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156899
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [59480a5e4ebb849c06d7f16579208d0847c5557e]

        Drop leftover aPageHelpIds
        
        ...from 28b6480c6bdd179f3943f768926b7f196226c768 "tdf#105303: Drop html export
        wizard"
        
        Change-Id: I996324e06a2f5eb04d722c45be9ce54715490b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157970
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Stephan Bergmann  <sbergman@redhat.com>  [aae50af8076ae2b4592598c25acb2709687dec08]

        Improve snew_slide_value_info
        
        Change-Id: Iabb67f465ef76c8c2fef822fb3844120a54ee243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157971
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-15  Patrick Luby  <plubius@neooffice.org>  [fc69d6b227310b170a9690e0b2658d36a8e2ca6c]

        tdf#101376 don't detach thread if it is the main thread on macOS
        
        On macOS, many AWT classes do their work on the main thread
        deep in native methods in the java.awt.* classes. The problem
        is that Oracle's and OpenJDK's JVMs don't bracket their
        "perform on main thread" native calls with "attach/detach
        current thread" calls to the JVM.
        
        Change-Id: I0859dc9e20f34bd0b43bb321898507764fd530fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157985
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-15  khushishikhu  <dpskhu13108@gmail.com>  [db0681effb0f04dc0f7ad39fa9410dfb7c647d95]

        tdf#143148 use pragma once and removed include guards
        
        Change-Id: I02ebab47905eaaab0d7f34fa0416b5bbbe8e1b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157973
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-15  Attila Szűcs  <attila.szucs@collabora.com>  [52500239e8a5a8c897a1af25b40e6b4d004eb21b]

        LOK: navigator: hide empty contentTypes
        
        In case of LOK, do not insert empty contenttype to tree,
        and implement new way to find changes in contents, in hidden
        contentTypes, because the original checked only on the tree.
        
        Change-Id: Ib1e4da5e05b2ad4161c6a66a9c54111d558f66f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152735
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit ed3bb61461e4e394bd476b4ec57ff3025eca153f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157983
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-15  Jim Raykowski  <raykowj@gmail.com>  [148394645cf753e8548b7cff6effe4ae69ca0fbd]

        tdf#154701 Fix move paragraph not working properly with outline folding
        
        Change-Id: Ibb4706fae198fada0f143b1b25149fcbcc5c41d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157899
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-15  EMartinGube  <martin.gube@web.de>  [6da9d629f7f17ec569e7fb6d0f1931dd410b1d28]

        tdf#156250: sw: Keep comments when spell correction replaces a word
        
        New method SwEditShell:ReplaceKeepComments for comment preserving
        spell correction.
        
        Change-Id: Ifdb9d5664ab8d457a16ad8f7ec62dd968c89d580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154761
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-15  Justin Luth  <justin.luth@collabora.com>  [489da34e9bffb234fa27155cef1931bd6f21dc1d]

        tdf#150466 notebookbar: hide PrintDefault on compact and standardize
        
        As in the classic toolbars, do not promote direct printing
        since it easily leads to mistakes and wasted paper.
        Additionally, the printer settings is really never needed,
        so it should not have a prominent place, especially on COMPACT.
        
        At the same time, I standardized the File menu:
        - always include print (especially useful for accessibility)
        - always use the same order
        - consistently provide access to print/web preview
        
        Change-Id: I9ffbba179206274b5ed1788e496b7c5aa0503726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157984
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-15  Michael Weghorn  <m.weghorn@posteo.de>  [2a3023bc91d6f16133b5c869a1159342f9223228]

        a11y: Add include to fix clang-cl build
        
        Without this, my clang-cl build on windows would fail
        like this:
        
            In file included from C:/tools/cygwin/home/user/development/git/libreoffice/accessibility/source/extended/accessibletabbarbase.cxx:20:
            In file included from C:/tools/cygwin/home/user/development/git/libreoffice/accessibility/inc\extended/accessibletabbarbase.hxx:24:
            In file included from C:/tools/cygwin/home/user/development/git/libreoffice/include\vcl/vclptr.hxx:25:
            C:/tools/cygwin/home/user/development/git/libreoffice/include\rtl/ref.hxx(129,20): error: member access into incomplete type 'accessibility::AccessibleTabBarPage'
              129 |             m_pBody->release();
                  |                    ^
            C:/PROGRA~1/MICROS~2/2022/COMMUN~1/VC/Tools/MSVC/1437~1.328/Include\xmemory(321,21): note: in instantiation of member function 'rtl::Reference<accessibility::AccessibleTabBarPage>::~Reference' requested here
              321 |         _Location->~_Ty();
                  |                     ^
            C:/tools/cygwin/home/user/development/git/libreoffice/accessibility/inc\extended/accessibletabbarpagelist.hxx(32,11): note: forward declaration of 'accessibility::AccessibleTabBarPage'
               32 |     class AccessibleTabBarPage;
                  |           ^
            1 error generated.
            make[1]: *** [C:/tools/cygwin/home/user/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:340: C:/tools/cygwin/home/user/development/git/libreoffice/workdir/CxxObject/accessibility/source/extended/accessibletabbarbase.o] Error 1
            make: *** [Makefile:121: accessibility] Error 2
        
        Change-Id: I3961fb95602b96667f33ea0b087e1df5375faf19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157982
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-14  Gökay Şatır  <gokaysatir@collabora.com>  [ca74511985981444dbd72ade7244484c131e36a7]

        Add NUMBERSIGN key handler.
        
        German keyboard layout has number sign key.
        Users can print number sign without using modification keys.
        So this key can be assigned a shortcut.
        Subscript is assigned to CTRL + NUMBERSIGN.
        
        Below PR is used as reference when adding the new key handler:
        https://gerrit.libreoffice.org/c/core/+/86713
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I340dc47764e9200d2477f8db740a629f62f48004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157554
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 1db8f6d484b884301a7d3673f4d05478e28cd853)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [025372363e5310ffe0e729648f97faef2fe784eb]

        get_iter_abs_pos doesn't neeed to be virtual
        
        Change-Id: If69768ffac37aa7b39a806b3c67ad8cbdafc5d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157981
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Attila Szűcs  <attila.szucs@collabora.com>  [5bdcd30a64ef814e63d1548ab798cc8a81944b49]

        LOK: Navigator: headings expanded by default
        
        Called an expand_row for the first element of the contetnTree
        in the navigator constructor.
        Right now contructor is called every time when navigator is
        opened, it may change later. (desktop app do it only if navigator
        opens in a new window, not on sidebar)
        
        Change-Id: Ibe4b71e6a6ddb573269178f83c295b0c2cbd53b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151939
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 09c40d669cac5f167fa68cb5c6ad94a6a9e2a844)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157960
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Jim Raykowski  <raykowj@gmail.com>  [18f35dffae44e741ea492ed5304f2d2d9d000f2d]

        tdf#152029 related: Remove attention overlay on document view change
        
        Fixes stale overlay that can happen when Navigator use causes a
        document view change. For example, when the Navigator is used to
        change a heading level or to delete a heading by key input.
        
        Change-Id: If4c0aa2e31f088a8fa12d7ed02012033c4d13509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157892
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [2c213582376216eacb613e576314e0b9cba0aa04]

        Keep some information when switching between exceptions and ErrCodeMsg
        
        This simplifies debugging.
        
        Change-Id: I21ba175a039bed9a1f13d510b2c80eb6356417ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157908
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-14  Noel Grandin  <noelgrandin@gmail.com>  [871a90df575915ce977d33d60bde23b2257b85d8]

        use a single queue of data for PDFExtOutDevDataSync
        
        instead of spreading the data out across multiple queues, which
        is just asking for trouble.
        This is slighly less efficient, but these are pretty small objects,
        so I think the benefit outweighs the cost.
        
        Change-Id: I89f8bdffc548cc287f7298081d80132878faf15e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-14  Gökay Şatır  <gokaysatir@collabora.com>  [d521062dd38a0c7faf26da55574648ae0c475771]

        Impress presentation engine (svg):
        
           * Add handlers for w and b chars.
              * These hide the content and set the color of the view to either black or white.
           * Add handler for p char:
              * This changes the cursor to pointer and back to default with key presses.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I566f485aa676f0707a31f25a0b71f64970de2a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157511
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 427e8c0a8d9a534c54e07414cfe66648c9a90d26)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157958
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ef4f9dca33bf38de3c2175cc4304e42281d729c2]

        don't bother checking existing mode before seting new mode
        
        Change-Id: I2ff08283d7a3defdc7a7df5c2f86fca4cf3508ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0379bdc8c5cd8cdca64e3e0d567b32699308dcac]

        Remove duplicated include
        
        Change-Id: I0a5bbd375e1841e3a441ab241b18933858ecd45c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157864
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [974a1c84ea354fe712ec09db68266d5a82023c5e]

        Fix typo
        
        Change-Id: I6e1c0f7ef3a99d68c078b1d0c524bad54d240bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157974
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9f9335ed67fcbb1192140e2761df7404620156c9]

        Fix typo
        
        Change-Id: I1554a3fbdf563a6fb9710ade03eccd162ae86643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157976
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f979ca1061a1b6fff123e150aec14756b8a5780d]

        Fix typo
        
        Change-Id: I1da83cf853a0d04442b69229ef7caab955f91a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157975
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7359700d5dc847accd360e70f7dcc45d119577be]

        Upgrade libffi to 3.4.4
        
        Change-Id: I417abc5d76db235c23195abff22d3d27f9c0fa77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157972
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [176e8cf09a527438ec9b2b20ba2df23fa45226bc]

        Use exception ctors, instead of setting members later
        
        Avoids overwriting source location in message
        
        Change-Id: Ia0290c7dd1ab3ea1357712a27ecab75c7b583dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157893
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-14  Skyler Grey  <skyler.grey@collabora.com>  [328d6aae9e2b7a73f6672800629230f5b46d15b1]

        Re-enable Bullets and Numbering → Customize
        
        - Revert change If0f7b953a40ca1d5f469087cb8f362a949c39b37
        - Enable jsdialog for the customize page
        - Fix numbering not being selected when switching level
        - Fix start at field not having a default when changing level type to one that can use it
        - Disable types that rely on supporting graphics in LOK as we cannot
          provide them
        
        Change-Id: I2517289b553b8a3e9ed62c64b6514c6aab3702b6
        Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153806
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 6b9415005fee130e9d9b4b005a56975794a47934)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157957
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Attila Szűcs  <attila.szucs@collabora.com>  [52fa7aed48632166e064e6a227e034f0981c4205]

        tdf#157662 SW: redline: accept/reject done for all parts
        
        Tracked changes divided into smaller parts when they are
        overlapping. But if the Author, and Change time, and some more
        is equal, then they can be combined into 1 change later..
        
        Modified AcceptRedline / RejectRedline, to seek for all these parts
        that are neightbour to each other, and can be combined, and
        reject/accept them all at once. Even those that are deepen in the tree.
        i.e.: insert that have a delete redline too.
        
        when rejecting an insert redline, that have a delete redline too,
        the delete redline is accepted instead. (have the same result.)
        
        when accepting an insert redline, that have a delete redline too,
        The delete redline remains, while the insert is deleted. (=accepted)
        
        made some limitations to lessen the probability of regression:
        No anonym, No table, No seqNo, and dont use it in RejectAll/AcceptAll
        
        Added unittest to check that accept/reject handle more redlines
        at once, but not too many..
        
        Change-Id: Ibd0a39f7847b22b279a797babb30ba162e70a513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c72d5d787f7a3024f2108d6d6e192b158fb144ed]

        tdf#116412 include bz2 module in internal python
        
        This commit includes the changes in 5e3510dbb62229cfb01da371d39ecc27b0d44880
        and 219bef04b7084eef49e1001312e186f390f4f735, as well as the following changes:
        
        * add bzip2 as permissable build target when cross compiling for Windows ARM64.
        * add external/bzip2/disable-test.patch.0 for cross-compiling.
        * revert the changes to configure.ac in 5e3510dbb62229cfb01da371d39ecc27b0d44880.
        * change the argument of gb_UnpackedTarball_fix_end_of_line.
        
        Change-Id: Iad8b1ed48d6c56e1302d9ac11620dc8084e79276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157101
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-14  khushishikhu  <dpskhu13108@gmail.com>  [3d0a8020f932c0e39a69e555ca4cc4ba7084d2cd]

        tdf#141908 change sal_Int32 to Color
        
        Change-Id: I0f9b0bd18fd90c05de67525222be41ef6cd8723c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157935
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-14  Joel Puronaho  <jpuronah@gmail.com>  [4bb809f4d1d4316d9723fe6d3c8064c3d974392c]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: I2835feb65d65dbfd7f0c23ac1e99b66d803c05ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153646
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-13  Stephan Bergmann  <sbergman@redhat.com>  [5f2206e3ccf1cf64d2b11b0e5d419973269920a8]

        O{U]String copy ctor should be constexpr
        
        ...similar to the dtors, which will be useful for some upcoming replacements of
        O[U]StringLiteral and O[U]StringConstExpr
        
        Change-Id: Iad905d8466ee76eba1891fbc340073c482d568d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157944
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-13  Eike Rathke  <erack@redhat.com>  [1f43a341885412b89dc3d6e9bc2bbc5f9f086a84]

        Update language-subtag-registry to 2023-08-02
        
        Change-Id: I61e7e6c0a7010ff6f8db61a72b57a57de3e61c74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157943
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-10-13  Justin Luth  <justin.luth@collabora.com>  [8b942ed3c3b893093edf89782e3235091579cb75]

        tdf#141457 sc notebookbar_compact: fix empty Statistics menu
        
        Change-Id: If873da6e5d877a07bc4260fa5832cc29d73f4af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157946
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-13  Jim Raykowski  <raykowj@gmail.com>  [79df80b642179fdd621538e8a7894a2f055ba16a]

        SwNavigator: Fix Indexes tracking
        
        Restores Indexes tracking when the document cursor is in TOX
        content which was lost in commit
        ca34204a39716ec9aa621e60ea50fb3c058c55f6.
        
        Change-Id: Ib0fed4b7a20b5d08b5c52eef28d13cf0044d87d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157693
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-13  Michael Weghorn  <m.weghorn@posteo.de>  [c0a284541fad2c4609d418a5002550f6f9581d51]

        tdf#157696 a11y Translate "CharStrikeout" to IA2 equivalents
        
        The IAccessible2 text attributes specification [1]
        has several different "text-line-through-*"
        attributes for indicating strikethrough.
        
        With this change in place, NVDA on Windows (with the WIP branches
        to switch both LO's winaccessibility and NVDA to the
        IAccessible2 text attributes) announces the striked out
        text in the tdf#157696 sample document as expected.
        
        For the qt6 VCL plugin on Linux, this is not the
        case yet, because Qt's AT-SPI adaptor does not support
        the attributes yet; s.a. QTBUG-118106 [2].
        
        Pending qtbase change implementing that: [3]
        
        While the gtk3 VCL plugin reports 2 attributes, e.g.
        "strikethrough: single" and "text-decoration: line-through",
        the ATK text attribute specification [4] only mentions a
        `ATK_TEXT_ATTR_STRIKETHROUGH` that can be either
        "true" or "false", and that is also what e.g.
        the gtk4-demo "Text View" -> "Markup" example does,
        so the suggested Qt change also does this, which means
        that just "strikethrough: true" will be reported when
        any kind of strikethrough is in place with the qt6 VCL
        plugin and both, this LibreOffice change and the
        pending Qt Gerrit change applied.
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        [2] https://bugreports.qt.io/browse/QTBUG-118106
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/511758
        [4] https://gnome.pages.gitlab.gnome.org/atk/AtkText.html#AtkTextAttribute
        
        Change-Id: Ib4ebba183be233aacfcf33a4fff29b27711d2e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157939
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-13  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [a97ceaf14e294373b864c61c930f8723e13747c7]

        tdf#42982 Improved UNO API error reporting
        
        Change-Id: I62862c8dd83b587e56177afd2ec05af1f567f6ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157201
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9bc2aede99017ed0338e97b21b4735919b705b47]

        Related: tdf#101970 Add missing bits for --without-template flag
        
        Package creation have failed with "--without-template".
        
        Change-Id: I0f6fb4abef8d9500b2901ee58f2c52699f7b4ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157936
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2023-10-13  Aron Budea  <aron.budea@collabora.com>  [c4c017d1b8fe30d1ef452782eef71371282deb37]

        tdf#147132  tdf#154285 Flatten and check param count of IsMissing fn
        
        Change-Id: I17d79dcedf2b2e1cd45ef2eb82ff5e89a9bb2b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155028
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-13  Stephan Bergmann  <sbergman@redhat.com>  [27e7a6199231b8b9942724c86d0a22126e71862e]

        Follow-up on "Make sure __cpp_lib_source_location is consistently defined"
        
        (113e064117b2632974a696b950634229d70c5b96).  Mike pointed out that I forgot to
        fix the generated code and that
        "https://en.cppreference.com/w/cpp/compiler_support/20 lists <version> as
        supported since gcc libstdc++ 9, and README.md requires libstdc++ 8.5."
        
        Change-Id: Ic7477e39e334735c4a563195fee335a599a0ef79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157933
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-13  Stephan Bergmann  <sbergman@redhat.com>  [282f9206b77a03e1864f2f9d4f9c17086495d447]

        At least VS 2022 Preview 17.8.0 Preview 3.0 needs the fix too
        
        ...from 3c6de7e20e35e37cbddd2d35e065525616deac00 "Fix build against VS 2022
        17.7.5"
        
        Change-Id: I36a7d02959c5ad04781c3d484966727c3283cbbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157932
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-13  Matt K  <mattkse@gmail.com>  [b0496a314b1acee28e22c1029b696cbbc1983853]

        tdf#150262 Split Autosum button: refactor to deduplicate
        
        This change refactors the recent checkin that split the
        autosum button into a default clickable button.  We just
        use the existing function "AutoSum" in place of the copied
        code.
        
        Change-Id: I9a0e6fce047165c927746f0f87df4de905d2f8ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155058
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-13  Michael Stahl  <michael.stahl@allotropia.de>  [83c21ed1493d54d64863a62ff9473aba364a6660]

        add LibreOffice_settings.xml_config-items.fods to document settings.xml
        
        Change-Id: Idede15529ed60e49e08e6e9f986cd198ca4a68a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157930
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-13  Stephan Bergmann  <sbergman@redhat.com>  [113e064117b2632974a696b950634229d70c5b96]

        Make sure __cpp_lib_source_location is consistently defined
        
        ...following up on 9c5f597fc80a8a910c1f898556ef2a3226dfe40c "use
        std::source_location instead of std::experimental::source_location".
        __cpp_lib_source_location is defined in both <source_location> (but which we can
        apparently not rely on here, trying to figure out whether to #include it in the
        first place) and <version>, so lets hope that all our toolchains support C++20
        <version> by now and #include that.
        
        Change-Id: I7ba41cae60dbbf6b3ec275edb06af66f184daf93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157910
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-13  Henry Castro  <hcastro@collabora.com>  [f96819f1358fb55b6e19ddc864f0376693e9feba]

        sc: ui: fix cell bidi layout strings
        
        The default constructor OutputDevice can set the
        layout text to "vcl::text::ComplexTextLayoutFlags::BiDiRtl"
        for all strings if the UI locale is a RTL locale, however
        each cell string can be mixed LTR and RTL.
        
        Set the defaults to auto detect the correct text layout mode.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I0c451e8014fd13490db4213adca3d83ea4572819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157880
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4381b39b40929cd6a30c15161faf79a346f1ed9]

        cool#6893 disable undo for editengine when rendering cell text
        
        We don't need undo functionality when performing pure cell text
        rendering, shaves some CPU time off
        
        Change-Id: Icfc688122af7e77c874dd984555b2b0951e9e134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157900
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-13  Federico Gallo Herosa  <federico.gallo.herosa@gmail.com>  [287339e08d01a11e2d70e12f728ee2bf3e89eee3]

        tdf#143148: Use pragma once instead of include guards
        
        Replace include guards in favor of #pragma once. First task for beginners
        
        Change-Id: I0ead6e955c953ec0e9113174797ffb8b9938999f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157901
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-13  Miklos Vajna  <vmiklos@collabora.com>  [7d7ca347fafa7a06094b00e8fb0d0452c4c81366]

        sw floattable, wrap on all pages: add layout
        
        The anchor text of a floating table is normally wrapped around the table
        only on the last page of the table. This compat flag requests to wrap on
        all pages instead.
        
        First, disable the SwTextFrame::FormatEmpty() optimization in this case,
        so not only the last page has portions inside the text frame.
        
        Second, improve SwTextFrame::FormatAdjust(), so that anchor content from
        the last page can flow to previous pages.
        
        Note that having a dedicated SwFlyAtContentFrame::IsWrapOnAllPages()
        means that later it'll be possible to do per-frame decision on this if
        there is demand for that (this came up on the mailing list, but it's not
        something Word would support).
        
        Change-Id: I75df539df859aaa6c7eaaeddb33f004639b1c004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157902
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-13  Julien Nabet  <serval2412@yahoo.fr>  [ad5659d10f20ff39f455e5f19f32b4f9f3078245]

        tdf#157465: getBytes may trigger an exception with hsql
        
        So test the SQL type of the column and:
        - if it's css::sdbc::DataType::BIT treat it specifically
        - otherwise, use plain getString method
        
        Thank you Noel for the idea!
        
        Change-Id: Ib5003d96c1b5ce541fb17e6e31592858f8cd61d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157849
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-13  Miklos Vajna  <vmiklos@collabora.com>  [7f17f309ff14a1e630ee5befc425dfdbfaf3759f]

        CppunitTest_sw_core_text: fix --disable-pdfium failure
        
        Change-Id: I6e0727a60491aa108c949836ebc6fd52a77984c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157868
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [e9374f74385d7dfe77d1902d3d82af20143bc775]

        tdf#157636: sd_png_export: Add unittest
        
        Change-Id: I76ec68fb6482d7c348a08021413c640cf640d7f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157836
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [807b0507563b1c54822dd302b210931297acde23]

        tdf#157696 a11y: Map "CharEscapement" text attr to IA2 "text-position"
        
        While the gtk3 implementation (see `Escapement2VerticalAlign`
        in `vcl/unx/gtk3/a11y/atktextattributes.cxx`) bridges numeric
        values to ATK/AT-SPI, the IAccessible2 text attribute specification [1]
        only allows the 3 values "baseline", "super" and "sub".
        
        With this in place, Orca with the qt6 VCL plugin on Linux
        and NVDA on Windows (with the WIP branches to switch both
        LO's winaccessibility and NVDA to the IAccessible2 text
        attributes) announce the subscript and superscript text
        in the tdf#157696 sample document as expected.
        (For Orca, announcement of the "vertical-align" text
        attribute is off by default, so that first needs to be enabled
        in the "Text Attributes" section of the Orca configuration
        dialog.)
        
        [1] http://www.w3.org/TR/REC-CSS2/visudet.html#propdef-vertical-align
        
        Change-Id: I1e4ea014cf818fefd009089be183615abf67aada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157867
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [3d1cd490ac0366245c4b55d711611c21149a76e9]

        tdf#141828 svx: Use pointing hand for custom shape handles
        
        Use the *pointing* hand cursor (`PointerStyle::RefHand`)
        instead of the hand symbol cursor (`PointerStyle::Hand`)
        for handles for custom shape interaction.
        (S. how `SdrHdlKind::CustomShape1` is only specified in
        `SdrObjCustomShape::AddToHdlList`, except for read-only
        switch/cases elsewhere).
        
        As mentioned in tdf#141828, this has the advantage that
        the user can see where the handle is being moved.
        
        For gtk3, this doesn't make any difference in practice,
        because it's using the same cursor type for both,
        `PointerStyle::RefHand` and `PointerStyle::Hand`
        (s. `GtkSalDisplay::getCursor`, but the Qt-based VCL
        plugins (`QtData::getCursor`) and macOS
        (s. `AquaSalFrame::getCurrentCursor`) make a
        distinction between them.
        
        Change-Id: I5d35481e5c5edc1895a7c4a973315ee6b187b983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157891
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c5f597fc80a8a910c1f898556ef2a3226dfe40c]

        use std::source_location instead of std::experimental::source_location
        
        https://en.cppreference.com/w/cpp/compiler_support says that this is
        supported in
        
          GCC >= 11
          CLANG >= 16
          Visual Studio >= VS 2019 16.10
        
        And our Visual Studio baseline is now 2019.
        
        We still need to make the ifdef conditional check clang, because
        __has_include will happily return true even if the current clang
        does not support the necessary builtins.
        
        Change-Id: I5f2743e204b8ed22d4651053f3ae579a4a192a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157515
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-12  Jim Raykowski  <raykowj@gmail.com>  [6afffcee5fcf7c9719abe7176468d20602e750bf]

        tdf#42787 SwNavigator: Add ability to delete Sections
        
        Change-Id: If259772d6b84cdae48b75083c569fcf862416baf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157802
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-12  Deepika Goyal  <deepika.goyal07@gmail.com>  [0cd703c699334ed96a5743aae977207ba9a2a74b]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I4c655d7700373636cc00c42d6214976b8aa9aee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157790
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-12  Stephan Bergmann  <sbergman@redhat.com>  [3c6de7e20e35e37cbddd2d35e065525616deac00]

        Fix build against VS 2022 17.7.5
        
        After af9c3ed6f748781f2a77e676ffe740992788969b "__cpp_char8_t is generally
        available now" (which Jenkins built successfully against some VS 2019 version),
        various people using at least exactly VS 2022 17.7.5 (--with-visual-studio=2022)
        started to experience issues like
        
        > include\rtl/stringutils.hxx(251): error C2065: 'char8_t': undeclared identifier
        
        when compiling e.g. cli_ure/source/climaker/climaker_app.cxx (i.e., in /clr
        mode).
        
        This is similar to the VS 2019 16.11.30 /clr issue discussed in the commit
        message of 5a40abc86b94c0be5b4a252c6ab5b0b0df6e520d "Drop some newly obsolete
        __cplusplus version checks", just that it apparently hits with a different set
        of VS versions.  The fix here is similar to the fix there, just conditionally
        disable char8_t functionality for certain VS versions in /clr mode, and keep
        fingers crossed.
        
        Change-Id: I8c4ed2e3d290dc1c94f329d314407a56170564f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157866
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-12  Miklos Vajna  <vmiklos@collabora.com>  [5b9249e950165015ba57cc2c0503381df9751bf6]

        sw floattable: add an AllowTextAfterFloatingTableBreak compat flag
        
        Word and Writer normally only wrap the anchor text around the split fly
        frame on the last page, but as
        <https://bugs.documentfoundation.org/show_bug.cgi?id=61594#c33> points
        out, Word has an allowTextAfterFloatingTableBreak compat flag that
        allows wrapping on all pages.
        
        Map this to a Writer compat flag for now, which affects all floating
        tables in the document. The mailing list thread at
        <https://lists.freedesktop.org/archives/libreoffice/2023-July/thread.html#90670>
        suggests that possibly there will be demand to control this on a
        per-frame level: that's not something Word supports, but we could do an
        OR of the two settings in the future if wanted.
        
        This is just the compat flag itself, layout still has to actually handle
        it.
        
        This compat flag is probably quite rare, so only write it to documents
        if it's true (the default is false).
        
        Change-Id: Ibc431f7dc11710926c115d8e03f760b7f0784304
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157855
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-12  Stephan Bergmann  <sbergman@redhat.com>  [dcea29c283680c8e75e4890f46b1624d0a55846f]

        Make NC_ constexpr-friendly
        
        ...by moving the char8_t -> char reinterpret_cast out of any potential constexpr
        paths into a new TranslateId::getId.  And demonstrate constexpr'ability by
        making the aCategories var in OApplicationIconControl::Fill
        (dbaccess/source/ui/app/AppIconControl.cxx) constexpr.  (And there might be more
        such cases that could now be made constexpr.)
        
        Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [6056a0e320f0aabbde7adb28c42e00ed72ef2e5b]

        loplugin:unusedmethods
        
        Change-Id: I27782fb4b912d8b0d5f19cbe296c2a3b98b2bfd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff5863d46c1730c65f27f3f6234d71b727af5ca9]

        split up the backtrace implementations into separate files
        
        Because I cannot keep what is inside what #ifdef straight in my head
        
        Change-Id: Ie986a6928df179fc0e30ca12c6d2a6866ed82078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-12  Mike Kaganski  <mike.kaganski@collabora.com>  [a0b003257aa87d34a4403531798d0074e19a18ac]

        Fix Windows x64 build
        
        ...after 6f45c0cf86b21772740bb0cafb3d462b058523f3 "cool#7318 Calc rendering
        acceleration" caused
        
        > sw/source/core/txtnode/fntcache.cxx(540): error C2672: 'std::min': no matching overloaded function found
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(108): note: could be '_Ty std::min(std::initializer_list<_Elem>)'
        > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>)': expects 1 arguments - 2 provided
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(105): note: or       '_Ty std::min(std::initializer_list<_Elem>,_Pr)'
        > sw/source/core/txtnode/fntcache.cxx(540): note: '_Ty std::min(std::initializer_list<_Elem>,_Pr)': could not deduce template argument for 'std::initializer_list<_Elem>' from 'sal_Int32'
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(98): note: or       'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)'
        > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': template parameter '_Ty' is ambiguous
        > sw/source/core/txtnode/fntcache.cxx(540): note: could be 'tools::Long'
        > sw/source/core/txtnode/fntcache.cxx(540): note: or       'sal_Int32'
        > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &) noexcept(<expr>)': could not deduce template argument for 'const _Ty &' from 'tools::Long'
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1438~1.331\Include\utility(88): note: or       'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)'
        > sw/source/core/txtnode/fntcache.cxx(540): note: 'const _Ty &std::min(const _Ty &,const _Ty &,_Pr) noexcept(<expr>)': expects 3 arguments - 2 provided
        
        Change-Id: I9af33041a81190998303aec2795fe03da7e2f119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157858
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [3d97d220c912c2e45e97489e55c8d2a2b0b3516d]

        tdf#145832 Typo when missing object
        
        Change-Id: Ifc26d17aaf3d280f4eaefb94c4ef8009c11c3bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157773
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [c2a90307d507817a4cc7741a1a7ade062fdb390b]

        tdf#157696 a11y: Escape commas in IAccessible2 color text attribute
        
        The IAccessible2 text attribute specification [1] says:
        
        > These characters need to be escaped with a backslash:
        > backslash, colon, comma, equals, and semicolon.
        
        So adhere to this. Otherwise, the NVDA screen reader
        is unable to announce the text foreground or background
        color properly in local WIP branches of both LO and NVDA
        to use IAccessible2 text attributes on Windows as well.
        
        With this change in place, the backslashes are also
        contained in the corresponding AT-SPI attributes when using
        the qt6 VCL plugin on Linux.
        That seems undesirable there (s. e.g. the ATK text
        attribute spec [2] and how the Gtk variant of LO
        and also the gtk4-demo "Hypertext" example" expose it),
        but I think this should rather be handled in Qt's
        AT-SPI adaptor's mapping of the IAccessible2 attributes
        to the AT-SPI ones.
        Pending Qt Gerrit change implementing this: [3]
        
        (At least Orca still announces the colors just fine
        with the additional backslash in place, so having
        an extra platform-specific handling here doesn't
        seem to be urgent for now.)
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes#formatting
        [2] https://gnome.pages.gitlab.gnome.org/atk/AtkText.html#AtkTextAttribute
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/511132
        
        Change-Id: I51780f44930089249a769522d7130e97ac5446b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157845
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-12  Michael Weghorn  <m.weghorn@posteo.de>  [b9b3d49dfe2de62612cdebbc465c8322acf410b1]

        tdf#157696 vcl a11y: Move qt's translation to IA2 text attrs for reuse
        
        Qt expects the text attributes to be reported as IAccessible2
        attributes. Therefore, there is a translation/conversion
        from the LO-internal text attributes to IAccessible2 text
        attributes in `QtAccessibleWidget::attributes`.
        
        Move the logic from the qt-VCL-specific code into a new
        VCL helper class `AccessibleTextAttributeHelper`, so
        it can be reused in winaccessibility in following commits.
        
        Change-Id: I434481faa53c74bae95cae5b2c9f0907b87fb1bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157804
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-12  Michael Stahl  <michael.stahl@allotropia.de>  [d5c19ef9d30cde052e8cd2486ac9395e62d9c9a9]

        drawinglayer,svx: PDF/UA export: put Form SE into anchor paragraph SE
        
        This is like commit d467f1aa3d028f399826c97e2eecedcd79efcf65
        and commit 6e5d59c2ca6969e9491f97cd7a00d094fc62cfb3 but for the
        form controls, which have their own special ControlPrimitive2D.
        
        Change-Id: I4b4ac45e81f490a7b625acd9e8753300d10bf119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157847
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-12  Michael Stahl  <michael.stahl@allotropia.de>  [2e32aa1e9fc240c9cd9854655106d0decbd3694a]

        tdf#157397 vcl: PDF export: fix CreateControl replay
        
        The problem is that the CreateLink and CreateControl actions are
        replayed in a different order than they are recorded, because CreateLink
        is a global action, and CreateControl a page action.
        
        This means that the mCurId at the time when
        PDFExtOutDevData::CreateControl() is called does not correspond to a
        position in mParaIds when CreateControl is replayed; it will be inserted
        too early and bump all the CreateLink ones to later indexes.
        
        Avoid this by adding another global action CreateControlLink that is
        added when CreateControl is being replayed, which appears to work.
        
        (Another subtle problem is that, in case of PDF/A-1, the page actions
        could be discarded completely; this should work in that case too.)
        
        (regression from commit d4d471fc88fe4fd14f44dfccdfe360dec327d4f0)
        
        Change-Id: I92d89ac08db6548e9f0d1480d984aeacb4d22262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157767
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [08de15d3e5700b780266a1e0d7327d15412e48ce]

        SwTextFly::GetAnchoredObjList never returns null
        
        Change-Id: Icd8a2aa356de24d977a72dc64825a03ed2f5b16d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6317dbc5a80acdbf727e538e0da58bf130aea14f]

        COWASM-02 - Fix wasm build for co-23.05
        
        "Undeclared identifier mpParent in GetParent()"
        
        Change-Id: Ib613b2cf303b0ac50c6e899deda25d99c7e22343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157245
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 21554305046e7faeb6d64c4eea622b968db1f474)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157778
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-12  Stephan Bergmann  <sbergman@redhat.com>  [92f3d912f703e3c84cbd9e0b43a34d12d130e3dd]

        Fix typos in C++ feature test macros
        
        ...that were accidentally made in e6fe048ded34a322007547d4d31e32c598aa4993 "Some
        more string_view use, add o3tl::starts/ends_with"
        
        Change-Id: I06470f705d1f51f98daffabe544c0194dfc34ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7bd401fa4e458c4ca16f7eb88289d50059e1d32e]

        writerfilter: clean-up PushPageHeaderFooter method impl.
        
        in addition change m_aHeaderFooterTextAppendStack to use enum
        PagePartType for the "second" value in pair, instead of a bool to
        denote if it is an entry for header or footer.
        
        No change in functionality.
        
        Change-Id: I2aa75494c9b3337dd51bf79e282291cdca9d8547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157839
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9b57133125179a88f7f68e14ef6cde888885ed1]

        no need for these enums in BroadcasterState
        
        the std::variant already knows which alternative it stores
        
        Change-Id: I3838d83959cf6a97876aba3543179338ba088ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157819
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-12  Miklos Vajna  <vmiklos@collabora.com>  [faa590cf41a08169306ec369948b31d0401518a3]

        Update to pdfium 6060
        
        - external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git
          diff'
        
        Change-Id: I9258d6d0130620523d64fcd0854c4d96fc98a4bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157846
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [286bbda9cd991c0a31c1cb88916507e586469434]

        cool#7318 Calc rendering acceleration (part2)
        
        we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs,
        and most of that is inserting into the GlyphsCache, which has a very
        very large key.
        
        Shrink that key a little bit
        
        Change-Id: I6f27c147652521502dba4517afd9a2ae2a6daebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [3622404f09448b82c095256140afe6240b522ece]

        tdf#157636 FILEOPEN: PPT: Images have no background
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: Ia0ed01e7c0d41bd909fe48666bc9aca5ff31d2bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157824
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-12  Mike Kaganski  <mike.kaganski@collabora.com>  [44fed6aec98320bf7ec793f08447bb8d455abc4f]

        Do not compare SwContentIndex instances from different nodes
        
        It fires an assert in dbgutil builds; and it doesn't make sense
        anyway: we must use the index from the beginning, not a strange
        minimal value between indices in start node and end node.
        
        Change-Id: I4a2b6062f5524703737ca6029f428f30555d25b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157842
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [955ca0eba5c9ec22fbae0fc3e6220914ec3d69be]

        sw: prepare tests cases for first, left, right headers and variants
        
        This prepares the test case for first, left, right headers, only
        first and non-first headers, only left and right (no first) headers
        and make them run for ODF, where they should work as expected.
        In a follow up commit, the OOXML implementation should be fixed so
        that the same tests pass for OOXML documents.
        
        Change-Id: I1e7f610324c14dd9eb285ff9d46829610de5b1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157838
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4fd6b125751897923428523336a768310a58b36e]

        editeng: move the methods into Test class definition
        
        This makes makes all the Test class methods contined in the
        class definition body, so more readable and less noise for the
        actual test definitions.
        
        Change-Id: I3ea177f27aa868a396e537b1682ce91d93c1208e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157837
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e3d09d2e525ef6d5b93c6646e3cadc3f01297ea0]

        change PageType (first, left, right) enum to enum class
        
        Change-Id: I45bb7947266de1e18028c7ed460149c609e430b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157834
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-12  Justin Luth  <jluth@mail.com>  [c108089ef4b58da819fb0acd372cd66e9684f3b8]

        tdf#138440 sc notebookbar: add right-to-left to home tab
        
        The UI is pretty packed here, so for non-RTL languages
        having it on the toolbar would be distracting.
        So I decided to make it hidden - meaning a RTL user would need
        to customize the notebookbar to reveal it.
        
        However, adding it unconditionally to the dropdown menu is fine,
        so at least it is readily available there.
        
        It already existed in the paragraph menu of groupedcompact.
        
        Change-Id: Id4dc2de9c0922428fc44501c4eb2d7e3e51dea82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157851
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b63f768941ca870f0930ff400e3bc6ff829bea4a]

        prefix some members of ImpEditEngine
        
        Change-Id: I9975bed2af853374a10b87c468840ff22b230157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157833
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-11  Patrick Luby  <plubius@neooffice.org>  [82ed49b81eb0a45c25f3808a7d12efffffd5161a]

        tdf#157613 make sure surface is not a null pointer
        
        Change-Id: I8e3c1be3f05f7ccc1f3ba00093cd71a564e5ae9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157848
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Patrick Luby <plubius@neooffice.org>

2023-10-11  Stephan Bergmann  <sbergman@redhat.com>  [6d1b241ab7b2edf3f3eef26f4cc514c22849caf5]

        Drop o3tl::span, can use C++20 std::span directly now
        
        Change-Id: Ic21ff7bf48f07f7277979d52e99d2c5c268de83f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [432e34fd1e0309038d0765f2497b7925c16a8ed2]

        drop empty accessibility description
        
        Change-Id: Ib2e4524ba668ce59ba1c5fad3e3180df396254a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [27a813ce1f88780dd7ddf64be98e23889b693e2e]

        InitAnchoredObjList never returns null
        
        Change-Id: I01b6accc5974caaa0533c95e50aa27c78af3ae0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157821
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Stephan Bergmann  <sbergman@redhat.com>  [8ef60830e4d3eec70fe98244b2eaa18db091385a]

        __cpp_lib_char8_t is generally available now
        
        ...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20"
        
        Change-Id: I45aa7538174a0c62ad5a4871e2914b30580546c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157827
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-11  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [66cf022ec61e1afe49acb4d5248e640fb075e649]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e7ec227d83792bdaf88cb53be5a5a8849f7f576a
          - tdf#155044 Help: Description -> Alt Text and Text Alternative -> Text
            
            Change-Id: I3c8317f4b747b05c7fbbf7119f9210627aaacd48
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157643
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-10-11  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [20f11111da9c698023cdf76d35bb4a34b2fee094]

        tdf#155044 Missed one Description to Alt Text spot
        
        Change-Id: I4e454b1e3966007b04d6f50acf4249b9b80f5526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157840
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [03013f35a6d931df4b59bd6578f012a9271b186c]

        FocusManager::IsPanelTitleVisible is dead
        
        ever since
            commit df2c41859287282501c8ebd7b3c67465455a457c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Sep 23 21:01:50 2023 +0200
            MoveFocusInsideDeckTitle is dead
        
        Change-Id: I641622453b35526c7654c84d25d9d7c873249b43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157817
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [56d01e3f9de146f4fc279b8c58f8c1450323f408]

        both branches set mpAnchoredObjList the same
        
        Change-Id: I0a41bc4cee141b2a375be3d84f67367ef8d7a2c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157820
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Stephan Bergmann  <sbergman@redhat.com>  [019d969d73efcb4ad876b294c968761ee8ed9733]

        The other OStringLiteral ctor should be non-explicit too
        
        It had been missed by 31cd6fd0f3c856a81a03d0229de1c4d10442844f "Make
        OStringLiteral ctor non-explicit", and now prevented u8"..."_ostr from
        compiling.
        
        Change-Id: Ifb214fba0957b0d26b11daae6190ffa9d21713f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157823
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d09785691373009a72cef14fd67610404c8d6022]

        disable more flakey navigator test
        
        Change-Id: Ic8de4333a33723c94cd86e5467f856170b0ae5b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157810
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a004e53527f541a36e7d1934dd99ea01f455faa4]

        tdf#157686 UI freezes after setting new master password
        
        regression from
            commit 49dd32a88d90097a1c50dc64dc42dc35645780b8
            author Noel Grandin <noel.grandin@collabora.co.uk>
            osl::Mutex->std::mutex in PasswordContainer
        
        Change-Id: Ie6270f6ed47ee892181f7b9e51ed8ef75533f4e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157809
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-11  Eike Rathke  <erack@redhat.com>  [8f42a36aecaf78b1fb004ed95c52b2f541dadc95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 379510d74d95dd4e7878e8e86401a3b60a6ef107
          - Follow-up: tdf#152412 Re-add the note to the STYLE() function
            
            ... to not use it without reason..
            
            This got lost with
            
                commit 20d4c17ca1fb161bf5fccf3d94db93b0a4d322f2
                CommitDate: Wed Jan 11 00:09:58 2023 +0000
            
                    tdf#152412 Improve the STYLE function help page
            
            Change-Id: I48b11d8360a0a95ae1a76e4d0a339b5fe6488d2d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157835
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-10-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [363ec6fdfe82950d604a1c6873a02da17e83ad5a]

        Update git submodules
        
        * Update translations from branch 'master'
          to 73620e7f6b800b0fb0c8d66859bcbfffb3b7dfac
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I38f3b37fa63d5b6becd7bceea107198034d41593
            
2023-10-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ba970cb1e267531affc90735ae2b66456a9eb8ed]

        disable add-ons for NotebookBar in LOKit - perf. issues
        
        Searching for add-ons to use in NotebookBar causes perf. issues,
        so disable them for now. This was discovered during a editing
        session and the flame-graph showed up the NotebookbarAddonValues
        method. See COOL GitHub ticket [1] for more details.
        
        [1] https://github.com/CollaboraOnline/online/issues/6896
        
        Change-Id: I4b2ced2be966de1cd1282f801a4410bc1625f0f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154513
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 0cda4c31c6c7881ea7b5089b04ad5147b28117af)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157815
        Tested-by: Jenkins

2023-10-11  Skyler Grey  <skyler.grey@collabora.com>  [ff568f6ec8292ad7e5b7001ce0d27430c23c2258]

        Make the format > sections > options dialog a jsdialog
        
        - This dialog was not properly tunneled so did not show on collabora
          online
        - Running asynchronously as a jsdialog both fixes this issue and is a
          general improvement (in that jsdialog conversion improves
          accessability, looks more consistent with the rest of COOL, etc.)
        
        Note- This commit was previously given the Change-Id
              Ie9a70da70bbb30de039ded82f738285b1b734421 however I have replaced
              it due to accidentally creating it against the wrong base branch.
              To see the old change go to
              https://gerrit.libreoffice.org/c/core/+/147295
        
        Change-Id: I2715eb1d8e3e301e1519e2ef6b69c823e571d08c
        Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151188
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 6aff11f36ecd02613c0613c9e89883c81656d9f6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157814
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [bf9897bc11a5ee06197ce566214456f796f68a34]

        Removing unused variable in preLoadShortCutAccelerators
        
        When all warnings are treated as errors the following error was
        reported:
        
        desktop/source/lib/init.cxx:
        OUString language =
        LanguageTag(installedLocales[i]).getLocale().Language;
        
        The problem started after commit
        1cd46ba9140b7f5f077d8e9da405b180857f008d.
        Remove the allowed language check from UI languages.
        
        Change-Id: Id1f4269fe262b61b4fb05d61bf9c64a747275c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152561
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit b0fa2ea7decadae61ad10e340698a8dd4af45e6e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157813
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Gökay Şatır  <gokaysatir@gmail.com>  [7c36e6ec7b00fa6be8ef5adbc7fd38b90a2c64e3]

        Remove the allowed language check from UI languages.
        
        Allowed langauges list is for spell checking algorithms. No need to use it for UI shortcuts.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I996861b79247269e9b788b008fe6fc26e5ef44c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152416
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 1cd46ba9140b7f5f077d8e9da405b180857f008d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157812
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30c582a7202b1403e260af933258d456e7280a19]

        make CppunitTest_framework_dispatch reliable
        
        the appearance of 2 interceptions is reproducible for me on linux with
        
        make CppunitTest_framework_dispatch VALGRIND=memcheck
        
        1st time
         #1 (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:139
         #2 non-virtual thunk to (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:0
         #3 framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:87
         #4 non-virtual thunk to framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:0
         #5 (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:2329
         #6 non-virtual thunk to (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:0
         #7 framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/framework/source/services/dispatchhelper.cxx:110
         #8 non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/framework/source/services/dispatchhelper.cxx:0
         #9 unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/unotest/source/cpp/macros_test.cxx:94
         #10 (anonymous namespace)::testInterception::TestBody() at core/framework/qa/cppunit/dispatchtest.cxx:172
        
        2nd time
         #1 (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:139
         #2 non-virtual thunk to (anonymous namespace)::MyInterceptor::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/qa/cppunit/dispatchtest.cxx:0
         #3 framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:87
         #4 non-virtual thunk to framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/dispatch/interceptionhelper.cxx:0
         #5 (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:2329
         #6 non-virtual thunk to (anonymous namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&, rtl::OUString const&, int) at core/framework/source/services/frame.cxx:0
         #7 SfxStateCache::GetSlotServer(SfxDispatcher&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&) at core/sfx2/source/control/statcach.cxx:263
         #8 SfxBindings::UpdateSlotServer_Impl() at core/sfx2/source/control/bindings.cxx:1083
         #9 SfxBindings::NextJob_Impl(Timer const*) at core/sfx2/source/control/bindings.cxx:1254
         #10 SfxBindings::NextJob(Timer*) at core/sfx2/source/control/bindings.cxx:1222
         #11 SfxBindings::LinkStubNextJob(void*, Timer*) at core/sfx2/source/control/bindings.cxx:1219
         #12 Link<Timer*, void>::Call(Timer*) const at core/include/tools/link.hxx:111
         #13 Timer::Invoke() at core/vcl/source/app/timer.cxx:76
         #14 Scheduler::CallbackTaskScheduling() at core/vcl/source/app/scheduler.cxx:480
         #15 SalTimer::CallCallback() at core/vcl/inc/saltimer.hxx:55
         #16 SvpSalInstance::CheckTimeout(bool) at core/vcl/headless/svpinst.cxx:161
         #17 SvpSalInstance::ImplYield(bool, bool) at core/vcl/headless/svpinst.cxx:399
         #18 SvpSalInstance::DoYield(bool, bool) at core/vcl/headless/svpinst.cxx:471
         #19 ImplYield(bool, bool) at core/vcl/source/app/svapp.cxx:377
         #20 Scheduler::ProcessEventsToIdle() at core/vcl/source/app/svapp.cxx:407
         #21 unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at core/unotest/source/cpp/macros_test.cxx:95
         #22 (anonymous namespace)::testInterception::TestBody() at core/framework/qa/cppunit/dispatchtest.cxx:172
        
        setting bold/italic will invalidate the slot for the property and timer
        starts to update the normal listeners to those properties which might
        kick in on a slower run.
        
        Change-Id: Ib37e61c0fbed463f8974d476158e54a0160a2c92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157798
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Jaume Pujantell  <jaume.pujantell@collabora.com>  [5082d50d24c3fec4487c724a15eb0d54a82ecd0d]

        writerfilter: use content controls for text in block SDTs
        
        Text inside block SDTs was shown as Text Fields wich ignored properties such as
        alias and formatting. Now those texts are imported as content controls like in
        the case of run SDTs.
        
        Added the ability for content controls to remember and export the "multiline"
        property of block SDT text.
        
        Some existing tests have been changed due to some different export results.
        
        Change-Id: Ice1eb4ca6dd53c99d5abb239371f8ac896c3b6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156867
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-11  Stephan Bergmann  <sbergman@redhat.com>  [af9c3ed6f748781f2a77e676ffe740992788969b]

        __cpp_char8_t is generally available now
        
        ...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20"
        
        Change-Id: I75509f3731357e0e3ae73c3774abd6e4070f605b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157806
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [65f8aac94c6b8388409a20b5a294cba550c88724]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3dda8f8e1aa70b6a89482e223c021cc0188beef2
          - tdf#155876 UI cmds Calc (02)
            
            + refactoring
            + Digital Signature menu
            
            Change-Id: I9547d47c6f4f99800b17fec2fb2199c13b38bc40
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157801
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7c07cb5a68ac93e4ac2383f48a369ceb3ed420fe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 22bb0cabc27b077214c08cf71e91b13098c305ba
          - tdf#155876 UI cmds Calc (01)
            
            + refactoring
            + Open/Save remote
            
            Change-Id: I9df9a7751f15fcbfbcfdbe346a1d513d41239abe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157800
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [12be11621950b3ed6ed523eded601411ec5ea091]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d13c170d0f21d8ab4d80110af95fe12bec8be5f1
          - Fix grammar +
            
            Change-Id: I6b765e52c4868ee7c665d5db6794f2410671713d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157774
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-11  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [8252568859e8296c36c6e4dbb291f208e5f8766c]

        curl: upgrade to release 8.4.0
        
        Fixes CVE-2023-38546 and CVE-2023-38545
        
        Minor amount of bugfixes, nothing that immediately affects us. New
        feature: IPFS protocols via HTTP gateway now supported, with the right
        URL.
        
        Change-Id: I24af4d17b570685081aa031c50a87bb8dcf1833d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157807
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [01e89930f8a0d50758ed23b0cf2bfd7b9ee47b9b]

        lok: flush the VOC primitives when trimming memory
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I0a7748a1fb1b58b3bcfc6b8fdfa1410a345849a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154812
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 5fba074e7f22ff0e5d5b9591a912193f7be8c08c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [40641b868b20c73e694770c2c7ea71e232514fa1]

        tdf#156808: sd_png_export: Add unittest
        
        Change-Id: I64b1f1f179e263962394afbbebd0be5486720e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157763
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f45c0cf86b21772740bb0cafb3d462b058523f3]

        cool#7318 Calc rendering acceleration
        
        we are spending a lot of time in SalLayoutGlyphsCache::GetLayoutGlyphs,
        and most of that is inserting into the GlyphsCache, which has a very
        very large key.
        Shrink that key a little bit on 64-bit machines, where tools::Long is
        64-bit, which is quite unnecessary for FontMetric fields.
        
        Change-Id: I64983d191ba9aeb76671671443ea90f90fd2c401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-11  Miklos Vajna  <vmiklos@collabora.com>  [5dff1f3a995a8e78a156214fd9c32b1005337183]

        tdf#157593 sw content control, PDF export: fix headers/footers
        
        Regression from commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw
        content controls, plain text: enable DOCX filter with data binding,
        2022-09-19), the PDF export of the bugdoc was broken, content was
        missing on page 2.
        
        Looking at the problem at a higher level, PDF form control in a header
        or footer makes no sense, since then you would get multiple answers for
        the same question.
        
        Fix the problem by disabling the mapping of Writer content controls to
        PDF widgets in headers and footers.
        
        Note that the original motivation is probably around providing a way to
        set the document header via scripting, without touching document.xml or
        headerN.xml. This valid use-case still works after this fix, we still
        update the value of the content control from data binding.
        
        Change-Id: I969682bf90026236276992dd6b6099e50dffe949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157769
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-11  Michael Stahl  <michael.stahl@allotropia.de>  [d7c0af9f5f3c384789bcc86d2874bf85545251bb]

        flat-odf-cleanup.py: remove various drawing elements
        
        Change-Id: I1666e7522314714760cb88ed0ad3ebf222311699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157757
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-11  Henry Castro  <hcastro@collabora.com>  [55c7c0667b00a2841819ce961284e3e47ea96fce]

        sfx2: fix typo
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I73e4890c024a2ab74ea3d4141c63304c167ba4c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Miklos Vajna  <vmiklos@collabora.com>  [6b9378154f9b504b9e924fe4565df444786e7d73]

        sw floattable, crashtesting: fix PDF export of ooo91654-1.doc
        
        Regression from 89a75cd194371002247d0138e759835bc673f7b0 (tdf#126449 sw
        floattable: DOC import: handle inner floating table, 2023-10-04), the
        document crashed Writer layout when exporting to PDF, which triggers a
        layout calculation.
        
        The trouble seems to be that in case the split fly is anchored in a
        table which is in a section, then we assume that we can create a section
        on the next page and move the follow fly frame there, which will mean
        the follow anchor won't be in a table anymore.
        
        Fix this by not moving the follow anchor explicitly, similar to what the
        nested floating table (inline or floating outer table) code does. The
        layout will later figure out that the available space is not enough,
        split the outer table for us, which will lead to a correct result.
        
        Note that the original bugdoc is DOC, but just saving it as-is in Word
        hides the problem, so it's not easy to minimize the reproducer. Instead
        create a similar DOCX reproducer from scratch.
        
        Change-Id: I769615af467ccaa88057ab322da2865f11d3d2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157803
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-11  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [1f9cd62b67d679da078c50b4b48295918657a70a]

        tdf#132293 remove unused imports from uitest
        
        Change-Id: I3c76c6f1e3561aaf0b4bb719a89feebecc65027a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157482
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [4c7e8b3593c6311375603616c8d5bbd8ce5022f5]

        fixup for: fe79008f70e7 sd: send correct slide visibility status
        
        Check pointer to be vaild
        
        Change-Id: Id7be4756496f034c4a6a4407cb625e68a66573c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153051
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 93a28b3bc8a50226a111464b08ac51d1feb05988)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [60a51b8397154e9685e63cff0a60c1a3da034423]

        tdf#51510 Blurry QR code after save/reload (docx)
        
        - without GfxLinkType::NativeSvg CASE in writeToStorage method by default QR svg changes to low resolution image type and that is the why QR got blurry in doc or docx format
        - added svg option when we change from odt to doc or docx format
        
        
        Change-Id: I74aec0619992c1f455cc9cbf3c19e352c3037e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157264
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 1d7dc53f19d188ae12603ca3cd526eb0a5016cf4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64f62133967e29fb91dc8a7dc2673f568fb03364]

        don't use %PRODUCTNAME in accessible-description
        
        similar reason as
        
        commit 3cca2c605313576187878a195fb612eb25bd6150
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Sat Jun 4 21:10:16 2022 +0100
        
            restore %PRODUCTNAME to accessible descriptions that need them
        
        reading all a11y desc at load time in order to possibly substitute
        %PRODUCTNAME and re-write a11y desc at runtime explodes gtk's a11y, so
        we limit it to where we have to do it.
        
        Change-Id: I283934bc81c41ebba2f6f189c1209209f8331c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a72ce599f9ccc8ae847f8a3017858516dd9e2537]

        drop can-focus of False in GtkToolButtons
        
        Change-Id: I12add968fdb5cb4d29087c24aa885cde23488fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157794
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [55b375b54925579296c0873705fb8606af85df7b]

        add truncate-multiline for consistency with everything else
        
        Change-Id: I4b1e61aeb17f2b3bd8e298bb1613623d4ba1a0f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157793
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4e1a5d693e408db170ccf4c84b49017056f289fa]

        upgrade to libcmis 0.6.0
        
        Change-Id: Ia22d2efca14b1f55f45a4ecb9c487591c3117e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157704
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-11  Henry Castro  <hcastro@collabora.com>  [2709d6bcf248a072abdc6e219466727f52dc159b]

        lok: sc: fire "hyperlink clicked" event
        
        The client side has changed the behaviour when
        the HYPERLINK formula is clicked, usually in desktop
        is fired with Ctrl + Mouse Click, now it is fired
        with Mouse Click.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I08d41170714588d9ee84475991757d8be9b01f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155270
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155352
        (cherry picked from commit 5279aff5588941e1e131a703059e8148713d24ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157726
        Tested-by: Jenkins

2023-10-11  Stephan Bergmann  <sbergman@redhat.com>  [f99bee8103ad82dac2e53e114527399c4af5485c]

        Delete OUString UTF-16 string literal ctor/assignment op
        
        ...that have been made unused by 7ef3d937415185ef66e32dd3043783eddcd03db5
        "loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr
        literals".  (And which means we can remove the relevant code from that plugin
        again.)
        
        (This also found a handful of remaining uses that had been hard for the plugin
        to discover, along the lines of
        
        > std::map<OUString, int> m = {{u"foo", 0}};
        
        being represented by a
        
        > DeclStmt 0xdaca578 <line:103:5, col:50>
        > `-VarDecl 0xdac9150 <col:5, col:49> col:29 s11 'std::map<OUString, int>':'std::map<rtl::OUString, int>' cinit destroyed
        >   `-ExprWithCleanups 0xdaca548 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>'
        >     `-CXXConstructExpr 0xdaca508 <col:35, col:49> 'std::map<OUString, int>':'std::map<rtl::OUString, int>' 'void (initializer_list<value_type>, const std::less<rtl::OUString> &, const allocator_type &)' list std::initializer_list
        >       |-CXXStdInitializerListExpr 0xdaca480 <col:35, col:49> 'initializer_list<value_type>':'std::initializer_list<std::pair<const rtl::OUString, int>>'
        >       | `-MaterializeTemporaryExpr 0xdaca468 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' xvalue
        >       |   `-CXXBindTemporaryExpr 0xdaca448 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]' (CXXTemporary 0xdaca448)
        >       |     `-InitListExpr 0xdac9df0 <col:35, col:49> 'const std::pair<const rtl::OUString, int>[1]'
        >       |       `-CXXConstructExpr 0xdaca408 <col:36, col:48> 'const std::pair<const rtl::OUString, int>' 'void (const char16_t (&)[4], int &&) noexcept(_S_nothrow_constructible<const char16_t (&)[4], int>())' list
        >       |         |-StringLiteral 0xdac91b8 <col:38> 'const char16_t[4]' lvalue u"foo"
        >       |         `-MaterializeTemporaryExpr 0xdaca3f0 <col:46> 'int' xvalue
        >       |           `-IntegerLiteral 0xdac91d8 <col:46> 'int' 0
        >       |-CXXDefaultArgExpr 0xdaca498 <<invalid sloc>> 'const std::less<rtl::OUString>':'const std::less<rtl::OUString>' lvalue
        >       `-CXXDefaultArgExpr 0xdaca4b8 <<invalid sloc>> 'const allocator_type':'const std::allocator<std::pair<const rtl::OUString, int>>' lvalue
        
        Clang AST.)
        
        Change-Id: I496fe9d4d5e1a033cb7b27b4e04b303f8ddbed4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157756
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-11  László Németh  <nemeth@numbertext.org>  [a822df6379606ab9f62d6ebb2318d0294d9c959c]

        tdf#157442 sw: fix spell checking of words next to digits
        
        If the preceding or subsequent word was a number or a word with
        numbers, misspelled words were accepted as correct.
        
        Note: it occurred with disabled "Check words with numbers"
        (default setting in Options – Language Settings – Writing Aids).
        
        Regression from commit 5619fc438273cd15e78539e78b8af751bca24b1a
        "tdf#154499 sw spell checking: add 2-word phrase checking".
        
        Change-Id: I4478c89d04ebf971925d4bdd56aaebc7ce8fb77e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157799
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [d8b9f57c0fb984ce3c5771d832157fcad9af9082]

        Use std::span
        
        Change-Id: Id40dd540d715ed79f7fe09e686fd0a9909d82d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157792
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f47e4b152f5d436fbbe31588601dcf4285716a31]

        Simplify a bit
        
        Change-Id: If87cf8d71ce49af191cf991e2dc5479b275cd918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157745
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-11  Julien Nabet  <serval2412@yahoo.fr>  [cef5f921839496f40d133d43c2ee8c76af9e6222]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69bd1d2c11c91b8968b5811855a3fd3acad6f979
          - Following fix grammar
            
            Change-Id: I838288c594ce5aed9c573f8e7f05074a6672232e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157725
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c247c2c867281181d3d35157bca5e72a3c0bca8]

        cool#7330 calc perf: PaintTile's FillInfo
        
        try to spend a little less time here, when searching twice, we can use
        the index result of the first search as a hint
        
        Change-Id: I7fc0c2fb4e5e338d2c3f8a3d642043a1b301e7b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-11  Michael Weghorn  <m.weghorn@posteo.de>  [3b6366773389c55c127f097d5d82d27d5efaa69a]

        wina11y: Drop CAccTextBase::GetXInterface
        
        Just use the private `pRXText` member directly. The separate
        getter doesn't really help regarding readability,
        in particular since the typical usage pattern
        involved first checking the member directly, then
        using the getter, making it less obvious that this
        was about the same object/reference e.g.
        
            if(!pRXText.is())
            {
                return E_FAIL;
            }
        
            if( offset < 0 || offset > GetXInterface()->getCharacterCount() )
                return E_FAIL;
        
        Change-Id: Iaf786220b94a37e79a46985f58e0586252846f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157766
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-11  Michael Weghorn  <m.weghorn@posteo.de>  [7b2ed8ef83220cad2982e53948fe227770006a61]

        wina11y: Drop unnecessary check for empty Reference
        
        Using operator= with either an empty Reference
        or nullptr has the same effect.
        
        Change-Id: Ifa33127f3718ba4bbf3d364484b412b4108719a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157765
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3191b322b59cab22ec4c67c0d83520ff577f7ae8]

        tdf#133870: read OBJECTDESCRIPTOR from clipboard
        
        This extends commit 8ad0c29f56e5069a3679560d404b603332dcf38a
        (sw: prefer ODF over RTF when pasting from Writer, 2020-04-22).
        To see that the clipboard contains a matching EMBED_SOURCE from
        another instance of the program, the content of OBJECTDESCRIPTOR
        needs to be read into mxObjDesc of TransferableDataHelper.
        
        Change-Id: Ic4bf4ba8b077550336be231451cf2e86c42f112b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157791
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [cb46ad4c4602fbb6aeab482e9370e31495e12cfe]

        tdf#156815 Reset solver settings when a sheet is renamed
        
        When a sheet is renamed, the SolverSettings object needs to be reset so that the updated references of the named ranges are reloaded the next time the Solver dialog is opened.
        
        Change-Id: I8d501bb5b52f6a69bc899a62863893744d80dc69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156872
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6cfd36a392ec3710304ff3df3cb0f42e0d8b53d9]

        tdf#154142 null-deref in SfxUndoManager::SetMaxUndoActionCount
        
        Change-Id: I09cfbccb5f2ffa009a3e40157c9373b7e10864dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157764
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [0cd5b97acbb3419eb7f550e39a291691373bd878]

        tdf#157502, tdf#157652: sd_png_export: Add unittest
        
        Change-Id: I19bf2738496e0289e9fe07ac5241781b4c0bc416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157758
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-10  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [27b05720c99b933a6cbb7a881433a70766962195]

        vcl: swap out the BinaryDataContainer too
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I2e6ac88ff95903acf2df2070a7c23f4fc135c253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154606
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 896fc921cd72b5f0198772f2d4c569b59f51222c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154615
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Andras Timar  <andras.timar@collabora.com>  [d4f1db07753396efee9b59cffed79adde141293c]

        fix internal python build on aarch64-unknown-linux-gnu
        
        Change-Id: I74189af9edd8384cbb1d65a805a29cea91646eeb
        (cherry picked from commit 77ebb08e5f93ea9b9e82ddc3de0698babe0630a8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157752
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [39f9c0020505719517972bbf262306c2e0defd9c]

        Enable QR and barcode dialog for online
        
         - enable QR and barcode genration dialog for online
         - Change Qr code genration dialog to async
        
        Change-Id: Ia46b8e27a3002adcc893e5ef4c2545d7edcc3e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156642
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 6ed38adb5578d0b52d11d8f2077e345f9a8c7ade)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Andras Timar  <andras.timar@collabora.com>  [a6c68549d0132d76a04d21c146a48345742c451f]

        lok: set help root URL
        
        Change-Id: Id4089027f095daebb69942eb3315d516cfb14779
        (cherry picked from commit 2239e4c1b2dcf06650316a106e5bd883ceefb6c1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157750
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Pedro Pinto Silva  <pedro.silva@collabora.com>  [564af6b066b71aa48cca9bb843668a2fb47d999c]

        jsdialog: hide help and close buttons for searchreplace dialog
        
        Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
        Change-Id: I0f3bc2cd6839c74dff40431f8659d7f90b285d12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149293
        (cherry picked from commit c65142fd9fd9a43e1f27cb11f5b4048600b5a4c4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-10  Michael Weghorn  <m.weghorn@posteo.de>  [9fc43f19615161d5db39db7ee4d1e214c1da8e57]

        gtk3 a11y: Drop unnecessary check before looping
        
        If `nTextMarkupCount` is <= 0 here, the loop condition
        isn't met, so the body is never entered anyway, so no
        need to check this explicitly.
        
        Drop the extra nesting level.
        (Use `git show -w` to ignore whitespace change.)
        
        Change-Id: Ib472da039d7b0a02ae3206b350c3feb6d42b914b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157759
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-10  Michael Stahl  <michael.stahl@allotropia.de>  [c50bca0fc298973bbeda697072528e3dfc887ac5]

        tdf#157182 vcl,filter: PDF/A export: fix crash due to SE ID mismatch
        
        The SE IDs in PDFExtOutDevData and PDFWriterImpl are supposed to match.
        If PDF/A-1 is exported then RemoveTransparenciesFromMetaFile() is
        called and that does unspeakable things to the Metafile and then we just
        throw away the PDF related data for the page in
        PDFExtOutDevData::ResetSyncData().
        
        This means that then EnsureStructureElement are called on
        PDFExtOutDevData but not on PDFWriterImpl, so on the next page the IDs
        will no longer match, which is noticed if there is no transparency to be
        removed on that page.
        
        pdfextoutdevdata.cxx:347: bool vcl::PageSyncData::PlaySyncPageAct(): Assertion `id == -1 || id == mParaInts.front()' failed.
        
        Guess the easiest way to deal with this is to have the premature
        ResetSyncData() replay only the EnsureStructureElement actions, which is
        only possible because they don't really require any extra data stored in
        the ridiculous vectors in PageSyncData; PDFWriterImpl will eventually
        remove the elements as they are never initialised.
        
        (regression from commit 07d790ca473cd6e71f0343419b819fa6b485dc01)
        
        Change-Id: I8eb295504067edff00608e28fd86b0c86d547083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157748
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b9fee0f1bb22555f321c8c071e6171ad2664b297]

        Remove exec bits on .doc file
        
        Change-Id: Ia5cf772cab86869a46c5a8f610fe43d170545516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157760
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 415f52ad94adf6df48604304e4e038c1e58bcb79
          - Fix grammar
            
            Change-Id: I07a30b1b3df454fce1144587176b3612d9bde474
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157724
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-10  OmkarAcharekar  <omkaracharekar12@gmail.com>  [1278ffc6e9d999bdfba7dbc582dfe8e7b5d6170a]

        tdf#107786: sw_ww8: Add test for null pointer dereference
        
        Change-Id: I54bd01ce3b0007abe9adb58c0b17195e38e8ceaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157742
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-10  Mike Kaganski  <mike.kaganski@collabora.com>  [2a9e22157b61a67591057b3926e290236250efd0]

        Make some methods const, and avoid some const_casts
        
        Change-Id: I4964abd34836438e3d24ee7c3c3b324f356477b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157746
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-10  Mike Kaganski  <mike.kaganski@collabora.com>  [01ad024d39efaa0cb77eafa80235ff9021fafbfd]

        Drop repeated code
        
        Change-Id: I0bbbaaf7c24851beca78d4ed024ffc44609e0093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157719
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-10  Michael Stahl  <michael.stahl@allotropia.de>  [07e46bb789915b8046b192b2bd6389e9ef5cb5ce]

        sw: SwTbxAutoTextCtrl should sort groups by title
        
        Change-Id: I2134492fd681393da6f4fc29aec95117145e8e97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157735
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-10  Henry Castro  <hcastro@collabora.com>  [fa834e64e927efca00c9c47edfee58f0714c4fd4]

        lok: fix getting SID_DOC_READONLY slot property
        
        Unfortunately, the property is not always set when
        import XLSX documents.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If501734704174b92b3589b61a019ba973592c331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157259
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157736
        Tested-by: Jenkins

2023-10-10  Miklos Vajna  <vmiklos@collabora.com>  [4a5fb05d5e2448453477ce14862a8cf9846ecb49]

        tdf#157571 sw floattable: fix incorrect blank space after table-in-shape
        
        Regression from a4af5432753408c4eea8a8d56c2f48202160c5fe (tdf#120262 sw
        floattable, legacy: fix text wrap around fly when no content fits,
        2023-07-17), the bugdoc has a shape which contains a table, and lots of
        empty paragraphs next to it wrap around the shape. Writer didn't wrap
        these empty paragraphs, so some of the page 1 content was shifted to
        page 2.
        
        What happened here is that in case there is a really small space for the
        wrapping text around a floating object, then Word has some minimal
        limit. If the available horizontal space is smaller than the limit, we
        don't even try to wrap, even if the content (an empty paragraph) would
        fit. It was assumed that this limit is the shape for normal anchored
        objects and floating tables, but the two bugdocs show that there are two
        different limits here.
        
        Fix the problem by going back to MINLAY as the default limit where we
        start wrapping, and only increase that to TEXT_MIN_SMALL when wrapping
        around floating tables. That fixes the bugdoc and keeps the older
        floating table use-case working as well.
        
        This also allows reverting changes to testParaUpperMarginFlyIntersect,
        to assert the non-floating-table case again.
        
        Change-Id: I8f8a776c6ad5bdfa0ee4f197b600463fef6431f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157743
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-10  Stephan Bergmann  <sbergman@redhat.com>  [556b095dfb99c5db92328a63ffa30f07d8840db2]

        Silence a new -Werror,-Wdeprecated-declarations for now
        
        Change-Id: I5b457a4e1b9804b53a72d53a49ca9695424fc0c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157708
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-10  Miklos Vajna  <vmiklos@collabora.com>  [b36026381d46bf07fc891cdb1c06789ad3bc40f3]

        CppunitTest_sw_ooxmlexport4: rework to avoid preTest()
        
        ImportComboBoxAsDropDown is on by default, so all we need is to turn it
        off at a single place + restore it at the test case end.
        
        Change-Id: I399aa60e5bf89817baa226de090625fd89fbbac9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157734
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-10  Jim Raykowski  <raykowj@gmail.com>  [ceceb574251d6ed3ce4da2fdcae398cb72488dfa]

        tdf#156980 SwNavigator: Make headings delete even if they have
        
        folded outline content
        
        Change-Id: If952d8d845c2eeec86231014b924f1632d2f5efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157667
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ff9c8b62c1015972e9e89799832fa3690dcd46b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 97c4b5ce17d662c498faa38c23074a645e21649b
          - tdf#155875 UI cmds Writer/Help in Help(52)
            
            + refactoring
            + Grid menu - final
            
            Change-Id: I0a237e1e8a6019a9b1cc65db2eebcb8f33ff1072
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157739
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0bbd4ecaea2dd6225e3e495a85ef97cdb5bbe419]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3644717d42d7fa24a61af95a6b51643665d879d1
          - tdf#155875 UI cmds Writer/Help in Help(51)
            
            + refactoring
            + Edit menu - final
            
            Change-Id: Ibf65e70f1edfa2733800eaa9e69ca9789abb0b2c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157738
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-09  Stephan Bergmann  <sbergman@redhat.com>  [646981459df7ba075069320bcaba4dd983777f4f]

        Add -rpath when building analyzer executable on macOS
        
        ...as at least with LLVM 18 trunk, the generated executable references
        @rpath/libclang-cpp.dylib but didn't actually contain an LC_RPATH
        
        Change-Id: Ida643903aa4566853ea9541553f0dfc9c3243d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157706
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-09  Stephan Bergmann  <sbergman@redhat.com>  [969990becc001d5fe5a34ff976cb022786c10c76]

        Avoid a false loplugin:casttovoid on macOS
        
        ...involving conditional preprocessed code at
        
        > vcl/skia/SkiaHelper.cxx:265:13: error: unnecessary cast to void [loplugin:casttovoid]
        >   265 |             (void)blockDisable;
        >       |             ^~~~~~~~~~~~~~~~~~
        > vcl/skia/SkiaHelper.cxx:286:22: note: first consumption is here [loplugin:casttovoid]
        >   286 |                 if (!blockDisable && !DefaultMTLDeviceIsSupported())
        >       |                      ^~~~~~~~~~~~
        
        Change-Id: I222d72d240852be2d64fe08d345f00d137cd5a63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157707
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-09  Stephan Bergmann  <sbergman@redhat.com>  [ba124320327beea8a4068ffa93a9050fa3dd5c38]

        loplugin:casttovoid
        
        Change-Id: Ifa6c18651b2e3faa4500f19217bf11dba10f02fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157709
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ba4e3aa94eb7425729a3ec1647a4c7cbe6b64cf8]

        bump odt2pdffuzzer max_len again
        
        Change-Id: I2fcd448d4efef924d088bfc9470ae800dbd78504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157737
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd009cffc38a280d3b072ae4dc9ee9cda2e1f13f]

        tdf#157650 Unhelpful error when XML in content.xml is malformed
        
        regression from
            commit d9e322d60f65ff20631dab87baa5a2c7c71daaa2
            replace ErrorInfo with simpler mechanism
        we need to tunnel the necessary information through the uui stuff, so
        add a new Exception class to do that.
        
        Change-Id: Ie1fde486e8637b802340795348a5e5aad6a54e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-09  Henry Castro  <hcastro@collabora.com>  [4dade552c67a36f83cb419f90369722dc913d9fe]

        lok: add getter function to read "ReadOnly" flag
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Id9d2bc638d0f48cb33764b07fb8976b97117a621
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156621
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157733
        Tested-by: Jenkins

2023-10-09  Patrick Luby  <plubius@neooffice.org>  [c3073c81223e9bf0f499d9fd3cfa8a7e8cb497a5]

        tdf#157502 and tdf#157652 invert alpha mask
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, invert the alpha
        mask.
        
        Change-Id: Ib6df3523be36ba5d5aaf3887557d4a6a8fa6098c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-09  Henry Castro  <hcastro@collabora.com>  [0855520cced8662ba0a8cfdaccbe55a812b13c60]

        sfx2: invoke handler "LoadReadOnlyRequest"
        
        It will ask the user if open the Excel documents "read only"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I909fb39709198e02496f8c522f477c077fb875e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156624
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157730
        Tested-by: Jenkins

2023-10-09  Pranam Lashkari  <lpranam@collabora.com>  [cf17d5384cc8e254684bc1423176ad8562d49bee]

        vcl: render scaled fonts for LOK
        
        problem:
        In  online calc when fonts are not scaled, text box disappears when not active
        
        Change-Id: I9c8fdb3c0d14a3e7ed502ddb2b46c0769a855280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153624
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 6460c685c3bc3f4929263c7681080056b59948fe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153654
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-10-09  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [72d6287c586a2481c62bf21d88bb363ce584b8dd]

        tdf#142524 Search Commands: use ▸ to indicate sequence
        
        Change-Id: I2a3a7c4db03dbfe53f2b71de7ee9b3df42a22866
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157689
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-09  Henry Castro  <hcastro@collabora.com>  [447d6af45b3c454bb858bc904f50e500aaaefc60]

        lok: implement "handleLoadReadOnlyRequest"
        
        Is used for interaction handle to query user decision
        regarding to open the document read only.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ia945eae7b1627d57d6211ae92a784d50313c2627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156623
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157703
        Tested-by: Jenkins

2023-10-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f6ef76cce3b05b1b3304d409882c339c116a7c08]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a99fef353cedd72e5b96e2115d4d621d3d513d09
          - Fix error in index
            
            Change-Id: I703300156a250cb1c7f940c0ad0101d305e74d9d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157628
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [2705c53c9d444eb5a8126d97b3e1fc4ff010b9c0]

        tdf#100034 tdf#157318 XLSX export: fix lost named ranges associated to sheets
        
        The original fix for tdf#100034 (see commit [1]) consisted of explicitly not exporting to XLSX named ranges that are not built-in. This has a side-effect that user-defined named ranges associated with sheets are also not exported to XLSX. Hence, if the user creates a named range linked to a sheet and saves the file to XLSX, the named range is not exported (which is the issue reported in tdf#157318).
        
        This patch implements a new fix for tdf#100034, reverting the previous
        fix. When the Print Ranges are cleared by the user, the associated named
        ranges are also cleared, thus fixing the original problem.
        
        This new fix has the advantage that user-defined named ranges linked to sheets are again exported to XLSX files.
        
        Regression from commit 639519dc2bad058197b6ff73c9e3df622f979f97
        "tdf#100034: Fix to persistently remove print-range".
        
        References:
        [1] 639519dc2bad058197b6ff73c9e3df622f979f97
        
        Change-Id: Ic3b84365a6086e96f60b222cd6337991ac90f483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157455
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-09  Szymon Kłos  <szymon.klos@collabora.com>  [0918d476c0bbe526cabb159523f35e4ab0bea2f2]

        Hyperlink dialog: hide some buttons in LOK
        
        Change-Id: I55a4ca5921b44a7c091a3742a85f2c9da5a188a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156760
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157672
        Tested-by: Jenkins

2023-10-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e1aec7937c0ccd9aa3c5c34091e94786f16e145]

        tdf#49253, tdf#157635, tdf#157576: sd_png_export: Add unittest
        
        Change-Id: I59b869c84381e2904edbc399b3d1598896e1dd29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157699
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-09  Henry Castro  <hcastro@collabora.com>  [7fee80fdf4625af4bb8c4273e2cab7bf8b9b46df]

        uui: implement "handleLoadReadOnlyRequest"
        
        Is used for interaction handle to query user decision
        regarding to open the document read only.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ia6792ca540b5c62f4c9de8a5793ef45de3740484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156622
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157660
        Tested-by: Jenkins

2023-10-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20eed0f37d6d4f444387ab30f6d583fbb6dfad7f]

        cid#1545413 drop PerMessageDeflateExtension
        
        Change-Id: Iac5133ebddf026037af22e0f22fead658348b108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157696
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c5c0633b4477d03569bbefc7c9f61e499055d41]

        cid#1547102 Uninitialized pointer field
        
        Change-Id: Id713220c13df8b557b637d305da158abc5d5421f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-09  Gabor Kelemen  <kelemeng@ubuntu.com>  [9f44f9fad759dea644356b67b9cd0fab030e8b77]

        tdf#157575 Clarify labels content in Security Options dialog
        
        Change-Id: Iba2fdf3a74bc50ddd9e7a6727a446acfb40a4bea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157564
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-09  Gabor Kelemen  <kelemeng@ubuntu.com>  [2fe996067fcd2086d679a4b1de441cfec7b06579]

        tdf#157588 Clarify meaning of High macro security level
        
        Change-Id: I4647ebdba45e2598b993d7aeb06111f069a0eba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157556
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-09  Miklos Vajna  <vmiklos@collabora.com>  [d530651e4e70febb1046727e85a8edcda610d722]

        crashtesting: fix PDF export of fdo45193-1.docx
        
        This started with commit 1d3d2a995239c3c71432006cb795324c56a0412a
        (tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxes,
        2022-06-20), the trouble is that once anchored objects are inserted to
        the anchored object list of a layout frame, the list has to be re-sorted
        if something that influences the sort key changes.
        
        Normally the way to do this is similar to commit
        0a6a151c4b7c78a363fb64598fbda39db4f42d07 (Related: tdf#70062 keep
        drawing anchor objects sorted, 2015-02-11), but here the problematic
        call is SetFormatAttr(SwFormatAnchor(...)) in
        SwTextBoxHelper::changeAnchor(), and we don't have a layout by the time
        that happens, so using UpdateObjInSortedList() is not something we can
        do.
        
        In any case looks like no proper fix is coming for this soon, so at
        least fix it up so we don't try to do binary search on a vector that's
        not yet sorted.
        
        This also seems to help 3 other documents from crashtesting, and also
        the tdf#157571 bugdoc (related to sw floattable), which is why I started
        looking at this in the first place.
        
        Change-Id: I9b532a39f6c28604304fa9bbecf9faf9842739a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157691
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-09  Miklos Vajna  <vmiklos@collabora.com>  [3e3dd080fe32811b4a74088d3e819f593cbebd3e]

        svx: prefix members of SdrHdlLine
        
        See tdf#94879 for motivation.
        
        Change-Id: I08a0368a6e262982419b3866defd6a181675af0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157690
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-09  Michael Weghorn  <m.weghorn@posteo.de>  [0ac6dc3568a40799200fe368bbad781f284f40e1]

        tdf#157633 a11y: Drop a11y description in Word Count dialog
        
        Drop the accessible description for the Word Count
        dialog since, as pointed out on the a11 mailing list [1],
        having that whole text read out each time by the
        screen reader isn't really the desired behavior.
        
        For dialogs, NVDA on Windows only reads the a11y description
        and not the dialog content if the a11y description
        is set (s. [2]).
        In case of this dialog, there's also no way to have
        the text read out by moving focus (there are only
        2 buttons at the bottom of the dialog), but only
        by having the whole dialog read out by pressing
        a screenreader-specific keyboard shortcut, in which
        case NVDA would announce the description of the
        dialog again first of all, before announcing the
        actual content.
        
        There's a help button right in the dialog that can be
        used to get the same information easily, so drop
        the a11y description.
        
        This also implies that this text is no longer shown
        as tooltip on mouse hover when extended tips are enabled
        in the settings, since that feature makes use of the
        a11y description.
        
        [1] https://listarchives.libreoffice.org/global/accessibility/msg01055.html
        [2] https://github.com/nvaccess/nvda/blob/a380b6a76a0a29df32e57c1bd974b11a895ac0c8/source/NVDAObjects/behaviors.py#L151-L156
        
        Change-Id: I9d4ceb20534fd87a8c1a3fa3ad5848bf0f4a0f29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157638
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9a02f4ed071f15908624fb1cafcf6dbb72b00a1b]

        make testCondFormatFormulaListenerXLSX reliable
        
        Change-Id: Ibd8c9b7831af73967229c578b9dcf7217d800610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157686
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [52f50ffd67de9d2e2253226b2d7f590fe45c7313]

        ofz#62236 avoid Timeout
        
        Change-Id: Ic7207ece03a30d8ffefadbf072d4da5fa66dfc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [347112fbd89ebd2a244052f14e085c9d3c90838d]

        Drop temporary aliases from Tuple2D and Tuple3D
        
        Change-Id: I091b68bbeee74452a3d6a03711cfc482b7a78e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157685
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [e64d85c9eb18642ed3a0526f3dd8db9a4b88e629]

        Fix build
        
        See e.g. https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/148996/consoleFull#699387013baec2b5c-2b20-4190-a3fa-ceac4be9cf93
        
        > error: use a _ustr user-defined string literal instead of constructing an instance
        > of 'rtl::OUString' from a UTF-16 string literal [loplugin:ostr]
        
        Change-Id: Ia813425bc75e4351add73b8665355d02222ccf78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157629
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c78861094f57198f4cd7117a85a5915358742209]

        Simplify a bit
        
        Change-Id: Icfa6d5bdc3c1a9e13f7e29d36a4a873a5c6bb05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157684
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [70c46e0e03a758fda4e94b561fdcae722414719f]

        tdf#156040 pick a better "LightColor" for windows dark theme
        
        in the absence of a better idea, do like StyleSettings::Set3DColors does
        
        Change-Id: I9868d4eb94fb221fcbf5e3a4e4761fb2bd8888fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e0f85bc22df4119101d854efaf53c7dd568f944c]

        SfxRequest doesn't need to inherit from SfxHint
        
        or anything
        
        Change-Id: Ibfedb7dce6503b5593111380c53fc0ef6c7e93af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157680
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [889848163e8dcb32d58f85ddaf2748517a37b9b9]

        cid#1547086 Logically dead code
        
        since:
        
        commit 757a73379dba01fde853443a09583d862c404531
        Date:   Fri Oct 6 09:31:28 2023 +0100
        
            Related: cool#7373 add an SfxHintId::ThisIsAnSfxEventHint
        
        luckily this is the only use of SfxHintId::NONE so easy to audit
        
        Change-Id: Id593eb3b2c2d26c9552aa7bf6033afd4f3112120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157678
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-07  Stephan Bergmann  <sbergman@redhat.com>  [7ef3d937415185ef66e32dd3043783eddcd03db5]

        loplugin:ostr: Rewrite some uses of O[U]String to use ""_ostr/u""_ustr literals
        
        This is a first cut at rewriting uses of OUString constructed from u"..." as
        u"..."_ustr.  It covers the same changes as
        <https://gerrit.libreoffice.org/c/core/+/155412/6/> "WIP: Delete OUString UTF-16
        string literal ctor/assignment op", but does so with automatic rewriting (see
        e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 "loplugin:ostr: automatic rewrite",
        plus a handful of 002b0a9d5793e07609f953b9961b04bcab7a7e3f "loplugin:ostr:
        manual modifications" where automatic rewriting wasn't set up to handle macro
        bodies).
        
        The compilation-time impact of all those changes appears to be negligible:  For
        some Windows build of mine, just touching the files that would be affected by
        002b0a9d5793e07609f953b9961b04bcab7a7e3f and
        e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3 (but without actually applying those
        changes yet) and doing `time /opt/lo/bin/make -O check screenshot PKGFORMAT=
        gb_SUPPRESS_TESTS=x`, three times in a row reported sample real times of
        
          21m15.438s  23m17.840s  23m41.529s
        
        and repeating all that with the two changes actually applied reported sample
        real times of
        
          22m43.547s  21m42.687s  23m1.813s
        
        The plugin itself is already prepared to do further rewrites (see the TODOs),
        which will be done in follow-up commits.
        
        Change-Id: I408ecf056dce1b9da683d7c377b8d9058df1558d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157676
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-07  Stephan Bergmann  <sbergman@redhat.com>  [2a92fe4c529f438421fad14cfbb1a76a45902fd9]

        loplugin:ostr
        
        Change-Id: I6c5aefbf36d032751bc2b5a84995182adb2c83e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157682
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-07  Regina Henschel  <rb.henschel@t-online.de>  [e84ae94270f0f0037fa2662a5f2765b37a50c33e]

        tdf#156902 Do not set glow on group shape in import
        
        Currently a group is not able to use glow. But in MS Office it is
        possible. When we try to set glow at the group, we produce an
        exception and no children are imported. So for now the patch prevents
        setting glow.
        
        Change-Id: Ifa7245ebf3c38f8685239c2b62eefccd35aab870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157679
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-10-07  OmkarAcharekar  <omkaracharekar12@gmail.com>  [95df8cda94007e7e5b316a02176bed76259c21c4]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: I91ab40003011a7c537faa40daf3db85a13946c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157669
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [280985ba383b56e3d64fa64f20cd4cc584fb8622]

        Add some entries into cpp.hint
        
        Improves VS integration: allows to find DECL_LINK implementations,
        as well as CPP unit tests defined using CPPUNIT_TEST_FIXTURE.
        
        The macros are stripped down to the minimum to allow IntelliSence
        do its job efficiently.
        
        Change-Id: I2de02196d44d72f79d8cd9e06e8093a7620bd9e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-07  Szymon Kłos  <szymon.klos@collabora.com>  [d1da6fbf805e5b4c3f22f18941ac240cbd3d8277]

        jsdialog: cache only best quality font previews
        
        to keep single cache for all the views, we downscale
        result if needed when we draw on a target
        
        Change-Id: I3b57ec08b2260029ff469a13da725feff04555d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156190
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157671
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-10-07  Szymon Kłos  <szymon.klos@collabora.com>  [664a8658f720a7d784d717416170ca3d4b2498ad]

        jsdialog: enable font name & size combobox
        
        This enables font selector with font rendering in Online
        
        Change-Id: I2b57c0831e84a957374c2b1733f6526ca80ac7bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156242
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157503
        Tested-by: Jenkins

2023-10-07  Noel Grandin  <noelgrandin@gmail.com>  [8e886993f32b7db11a99bdecf06451e6de6c3842]

        tdf#157568 After deleting the content of a cell by pressing the delete..
        
        .. key, Orca still speaks the content.
        
        this reverts
            commit f22cb3dfab413a2917cd810b8e1b8f644a016327
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jun 12 20:02:19 2023 +0200
            tdf#155376 weakly cache ScAccessibleCell
        
        which was a nice idea, but means that we would need to have
        some way of updating the ScAccessibleCell when the associated
        cell data changes. Which is likely to be complicated.
        
        So return to creating new ScAccessibleCell objects all the time,
        but fix them to not leak.
        
        Change-Id: Ie17ee5c950c9809d4c7281f93761584f75256121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [7b6fd0f92f4acccce4bbdd79e6d0f2a65eaddbf1]

        Make fields private
        
        Change-Id: I048485669a1f6df5a9811f37babc2fe929af8eaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157675
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [8328f8c2620f8512c6056d54ea4d08ae3de97170]

        Drop newly unused m_nTopBorder and m_nBottomBorder from SwWriteTableRow
        
        Change-Id: If2bb07cd858c0b0be82bbe4754eb80c4d0ba2459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157674
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b6a5e84cd3f22a223d67fe88595006a33c291c48]

        tdf#157643: Drop extra cellless rows, a "substitute" for bold borders
        
        Change-Id: Ic98bec72ed14623c880fad3b881d72ee13395a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157670
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-07  Ioan-Teodor Teugea  <teodor.teugea@gmail.com>  [c476335c4d3e1b9c90485e4e13fa3e2e85535143]

        tdf#156918: make autofit text less confusing
        
        Change from 'Autofit text' to 'Shrink text on overflow'
        
        Change-Id: I4b3f8425b11768048cdd7ea023167f7c4b190e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157186
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-10-07  Julien Nabet  <serval2412@yahoo.fr>  [cc81d424a29dd4b421bc1775faaa51c58195fadc]

        Related tdf#157532: deal "ShadeMode" for extruded custom shapes via BASIC macro
        
        Change-Id: I9ff65f58d48c2b61819533f62c42e2ab07ad4fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157655
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d7a34635cd4d7e5d9c3ae123d5adfa071e85da0]

        fix ScTabViewShell::HasAccessibilityObjects
        
        been this way since it was introduced in
            commit 5cd1b592821d6870376f44aedfb527db07fd07d0
            Author: Sascha Ballach <sab@openoffice.org>
            Date:   Thu Feb 14 15:54:20 2002 +0000
            #95584#; call Broadcaster for Accessibility objects
        
        Change-Id: I1a79807cbb529c72a46e0e77e2999ae3f5a143ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f1f2a3faeaddf9e9a59f44bf9de38a1f0aa97104]

        Revert "tdf#149598 - Remember window state of the format cell dialog"
        
        This reverts commit c1893df42567c260ca5fb069038d1a55616e7b7f.
        
        Reason for revert: causes a regression under Linux (Bug 156710)
        https://bugs.documentfoundation.org/show_bug.cgi?id=156710
        
        Change-Id: I72a570ecba4cf7fe594a0bb50a121ab2e99cc613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157624
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-07  Jim Raykowski  <raykowj@gmail.com>  [cd746546df895338b13992cb064a4b85d1cfaeac]

        Master Document Navigator: Improve sensitivity of tool box items
        
        Change-Id: I45f16267d7a46aacb5fb5ad4d138a63acfb687c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157579
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [37b47bca10da480da591c4a5f5369bce59cccab6]

        consistently restore the original endianness here
        
        Change-Id: Ia17ef469a3469cca5a2b7eb39b349df78eed6fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ec6ddf177af4871b143a5135677af9920f16d567]

        ofz#63036 Timeout in new png code
        
        Change-Id: I06955f420bfe2faea8b9865c375d4ae364163494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b4ff0e5fd8e94155cfcb0ab9f9d0ee590f9bee7c]

        ofz#63032 urp stack too deep
        
        Change-Id: I13496c629e48128e3d916f3033394392bca3524c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-07  Stephan Bergmann  <sbergman@redhat.com>  [e0c33ec15f53a01fa3ee07489871bbe09bb5c9c3]

        loplugin:ostr: automatic rewrite
        
        Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [9e3da252c361b3e2b04a2df7a3ae2a5177b37713]

        tdf#157633 a11y: Don't duplicate dialog description for its buttons
        
        This accessible description does not describe what the
        buttons are for, but what the dialog does, and it was
        previously set for the dialog and each of the two buttons
        in the word count dialog in Writer ("Tools" -> "Word Count").
        As a consequence, NVDA would read the description, both,
        when the dialog opens (as the a11y description of the dialog)
        and whenever moving focus between the buttons, e.g. using the
        Tab key.
        
        In addition, it would be read three times when reading out the
        whole dialog (NVDA+B), once at the beginning (for the dialog),
        and then when each button is announced.
        
        Drop the accessible descriptions from the buttons.
        
        Change-Id: I878f1ec14439f78e60a8b95024e9966bc821042e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157637
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [f8e16f26a037a71349dc1a197b5ace204acb123b]

        tdf#157639 a11y: Set proper role for status bar
        
        Set `css::accessibility::AccessibleRole::STATUS_BAR`
        as role for the `VclHBox`/`VclVBox` instances created
        for `GtkStatusBar` nodes in .ui files, so that they
        are properly exposed to the accessibility layer.
        
        This is e.g. required to make NVDA's feature to announce
        the status bar content (when pressing NVDA+End) work.
        
        An additional change on NVDA side is needed to make the
        announcement work. Pending PR:
        https://github.com/nvaccess/nvda/pull/15592
        
        Change-Id: Iac587be96ec941afd7625ee363949f5da0cbc873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157659
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-07  Michael Weghorn  <m.weghorn@posteo.de>  [dd0a0ecb839df1289693d4b2f862e3942a80345d]

        wina11y: Map FRAME a11y role to IAccessible2 equivalent
        
        The description of the UNO API role (s.
        `offapi/com/sun/star/accessibility/AccessibleRole.idl`)
        and the IAccessible2 role  `IA2_ROLE_FRAME`
        (s. `winaccessibility/source/UAccCOMIDL/ia2_api_all.idl`)
        match. (The first sentence is even identical.). Therefore, map
        them accordingly instead of mapping to `ROLE_SYSTEM_DIALOG`,
        which is not really the same.
        
        It's not clear why this "perfect match" was commented
        ever since
        
            commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
            Author: Steve Yin
            Date:   Thu Nov 14 08:18:05 2013 +0000
        
                Integrate branch of IAccessible2
        
        I noticed this because announcement of the status bar in
        Writer by NVDA as implemented in NVDA commit [1]
        didn't work any more after
        
          commit 2cd1408dd7d6688357257f4a58a8b467628b1884
          Author: Michael Weghorn
          Date:   Thu Aug 17 13:15:46 2023 +0100
        
              tdf#156561 a11y: Create VCLXTopWindow peer for border win frame
        
        as the DIALOG role was used instead of the WINDOW role
        after this, and NVDA doesn't consider that yet when
        looking for the status bar.
        
        It also doesn't take `IA2_ROLE_FRAME` into account yet,
        but this NVDA PR makes NVDA to consider both,
        `ROLE_SYSTEM_DIALOG` and `IA2_ROLE_FRAME` as well: [2]
        
        Just mapping to `ROLE_SYSTEM_WINDOW` instead would
        still be a better match than the previous
        `ROLE_SYSTEM_DIALOG` and would make that
        NVDA scenario work again without further
        changes to NVDA, but would rather be a workaround
        than the proper solution.
        
        [1] https://github.com/nvaccess/nvda/commit/62536a97cd29019c7055c927746da72435d12b95
        [2] https://github.com/nvaccess/nvda/pull/15592
        
        Change-Id: Ide39222d2525cb64106c878e8b0a11174bcb16ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157658
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-10-06  Patrick Luby  <plubius@neooffice.org>  [b2ca39bc5e424e67e8fc7e8a044214feb09e39f7]

        tdf#157576 and tdf#157635 mask out black pixels
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, mask out black
        pixels in bitmap.
        
        Change-Id: I7cc8c39c20d8ec4fed026c3e27fce24396815d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157665
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c76fb134281a3d1fd56f8a6d07ad7111c85e17b9]

        bHiddenDoc is always false and aHiddenName is always empty
        
        Change-Id: I05259fb648f9e1e96ac5b0f0a4d68ba9a68b89b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157652
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9748e84e17f05f4345f3e2f1d20478389666e469]

        aStrHidden and SCSTR_HIDDEN are unused
        
        Change-Id: Ieac2d95be89da53a2dc0971df4700b222191b419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157651
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d34c975c849db6c99d3b1f0155cce34234468fc1]

        aHiddenTitle is always an empty string
        
        Change-Id: I881c8d017da0792420ba6929c0dccbfa0df78e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157650
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Hannah Meeks  <hmeeks4135@gmail.com>  [245b92490971d0cf0af0db71837617035b9c2e4b]

        Rename ojects to objects!
        
        Change-Id: Ia39f59d68a00efea18409a23e243007a9e6a96b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157574
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-06  Julien Nabet  <serval2412@yahoo.fr>  [f1aa554cd0b471e0c9424ece7ab3d9b3d7723a1d]

        tdf#157532: deal "ProjectionMode" for extruded custom shapes via BASIC macro
        
        I took example on SdrTextAniDirectionItem::PutValue from svx/source/svdraw/svdattr.cxx
        
        Change-Id: I9165b9a310ff6bee287e7fb817502c0c99f0747b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157654
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Mike Kaganski  <mike.kaganski@collabora.com>  [835dc57c205b84f16484184434a903291f4b6eee]

        Simplify a bit
        
        Change-Id: Idb278ea6731793631fe1282820c7e7d3fccf33d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157653
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-06  Jim Raykowski  <raykowj@gmail.com>  [a3c7d25122f615c1e3232e535afef2f8ad33d186]

        tdf#157584 Fix accessibility check doesn't move footnote into view
        
        when a frame object is currently selected
        
        This patch introduces the function SwWrtShell::AssureStdMode to fix
        this bug and to replace duplicated code.
        
        Change-Id: I4106db983f79c92eea96a67b510393b2ac09a6d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157575
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8fa0ca2a3befeb961f8555321af6f6cbf14c03d]

        ScContentTree::LoadFile can't be called
        
        ScContentTree::LoadFile is only called if !aHiddenTitle.isEmpty()
        but the only thing that set aHiddenTitle is ScContentTree::LoadFile
        
        Change-Id: I91943a5d4762b5725995479bb1f0dc8e3fa0d7b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Stephan Bergmann  <sbergman@redhat.com>  [002b0a9d5793e07609f953b9961b04bcab7a7e3f]

        loplugin:ostr: manual modifications
        
        Change-Id: I06a76e82e330b0250ce8f2d3d00cbb257703ba4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157646
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-06  Henry Castro  <hcastro@collabora.com>  [8e3f6b9fd6915a20c8c9f5195e5ac5a7e085920a]

        uitest: add "Silent" property parameter
        
        add option to not popup the read-only dialog when
        load and excel file.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I5e0ac06e3e872f156f6150f4b8bead61e7986c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157036
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157641
        Tested-by: Jenkins

2023-10-06  Mike Kaganski  <mike.kaganski@collabora.com>  [7be07738da1f0710b33973a30459a2038f75078d]

        Simplify a bit
        
        Change-Id: I4687a498f3658de76cddf2b14096024b11c9e64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157635
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7ef17e87bd2a9960bfbf6045cbe41ffb8beafd6e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e6eb23afa043ab16e61cd6dda010f631d5380e3b
          - tdf#154996 Update tools - remaining help pages
            
            Change-Id: Ide4d3dd44b0c7d4ab09bd7560cc0a3f7fb6b59c1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157648
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [67c0bf2f73132406ff7dc63505c9869a2af697e0]

        cool#7373 the document doesn't change in online
        
        the navigator always looks at the same document
        
        calc should do like writer and have the navigator listen to just
        the initial document until that dies. This is the safest option
        to take for the scenario in question though.
        
        Change-Id: Ic75cad4bb52f4d58ec58341fb8bed4c87ca9d90a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157639
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [aafde177d68b97ebd90587603eaad014ba89d337]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a79a6e02003a1dd220e2c03add548758f928795b
          - tdf#146609 Rename line width to thickness in Help
            
            The ones that were easy to find. Probably missed something.
            
            Change-Id: I6dbb72b42c07fc8859be733dc6419dfb7a5d0d65
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157642
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-10-06  Henry Castro  <hcastro@collabora.com>  [df9f94a1b37d26b74d981dc4514255c46477c8ac]

        sc: qa: add loadWithParams and SaveWithParams
        
        Add option to load and save with optional parameters.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2d735443da11634d072742f1bf6f38f90bced2c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157569
        Tested-by: Jenkins

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d852e411b52cda24f2d79070798a2fa662bb71f1]

        cid#1547076 Uninitialized scalar field
        
        Change-Id: Iddccb0a468fd5341115851da1720a8fee97a92f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [516f7dafd009988f3fc58041bc265b836f4b7322]

        SdrModel::getUnoModel can use XModel instead of XInterface
        
        Change-Id: Ica10c62066881ba86099d2057ff6fe20e0084a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b693d19884a09b5f841b30f2e8b586778584ed16]

        xmltesttools: add assertXPathDoubleValue that takes a double with delta
        
        and use it to make WmfTest::testSetTextAlignWmf independent of DPI
        
        Change-Id: I2048239088a8dcc3e3ab1db96413894b5bcc56d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157377
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [757a73379dba01fde853443a09583d862c404531]

        Related: cool#7373 add an SfxHintId::ThisIsAnSfxEventHint
        
        to avoid cost of dynamic_cast of SdrHint to SfxEventHint
        
        Change-Id: Ie0366b7d7ba828d8ffabeed4d65d7c7b275a3ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb5285d544a355026a38c69ccf5473956d60e4ee]

        Related: cool#7373 set name of object before broadcasting ScDrawChanged
        
        which adding it to undo does. That way the object already has a name
        when the navigator looks for the new object's name, and so a drawing
        shape appears in the navigator when it appears in the document.
        
        Change-Id: I47fed30753bc186e462cc5be8f86d51325192da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157607
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Mihai Vasiliu  <mihai.vasiliu.93@gmail.com>  [6e6db2a3360d7ee89cae14cbcfe386e7425daf98]

        tdf#150639 Fix sidebar width too narrow
        
        The mnWidthOnSplitterButtonDown is initialized to 0 at program start.
        This makes every call to take the else case until the user manually changes the
        width, but some decks such as Master Slides have the mnMinimalWidth too low which
        makes them too narrow for the content they should display to the user.
        
        Change-Id: I8fc4924f777770dedbdc8d162ceceb620ff80e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157596
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e1f630cd762eb99be23045107d3751e1ab91f410]

        Fix typos
        
        Change-Id: I70b570b74c793418ec6e045d454d20107675b9a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157601
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a86e015c469142f6cd9089e310699814dd0bd14a]

        Fix typo
        
        Change-Id: I0ece1c462f3b493273cf70e32a78b718f0255ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157602
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [65ff27c32a747ba20837f8453c18456423f4b474]

        Fix typo
        
        Change-Id: I0b4c80e1e2b625e60d80ae4ae10a43477250176f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157606
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d86f1ec88a59b38b8f6533154551e708380b2ce7]

        Fix typo
        
        Change-Id: Ib459277f1c535304a863d1061acf7b261e37aa7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157605
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7bdc10dbb6621848d62e29601bd379e4895818e6]

        Fix typo in code
        
        Change-Id: I7bfff7c50e9b97fec7d2100a542849360bb48e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157603
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9a9836714e80fbb75bfc99e43fa54f66dff0e5f8]

        Fix typo
        
        Change-Id: I0b557b4bc7e6b5ba569b2fce7bf8aee5e407e4ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157604
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [66123b319da98c6ecabcd9635eb2ed9c3de99f35]

        use more ErrCodeMsg
        
        instead of a sideband mechanism to convey extra error message around
        
        Change-Id: Ibd1fc8629c5b10bc6f9e6cbd30e8a20156ac13b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157630
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [48c0ada1745be2cd817d5bd8a912530028fa8419]

        crash copying text + chart to clipboard with InputOptions::TextWysiwyg
        
        of true, the mxPoolHelper is still null when trying to create a
        Printer to use as a reference device
        
         #3  0x00007f6d5e81ee6e in ScDocShell::GetRefDevice (this=this@entry=0x4697e6e0) at libreoffice/sc/source/ui/docshell/docsh3.cxx:471
         #4  0x00007f6d5e823439 in ScDocShell::UpdateFontList (this=this@entry=0x4697e6e0) at libreoffice/sc/source/ui/docshell/docsh3.cxx:462
         #5  0x00007f6d5e81dd6c in ScDocShell::InitItems (this=this@entry=0x4697e6e0) at libreoffice/sc/source/ui/docshell/docsh2.cxx:98
         #6  0x00007f6d5e81e80b in ScDocShell::InitNew (this=0x4697e6e0, xStor=...) at libreoffice/sc/source/ui/docshell/docsh2.cxx:83
         #7  0x00007f6d6e2ce99d in SfxObjectShell::DoInitNew (this=this@entry=0x4697e6e0) at libreoffice/sfx2/source/doc/objstor.cxx:470
         #8  0x00007f6d5e768daf in ScTransferObj::SetDrawClipDoc (bAnyOle=<optimized out>, pDoc=std::shared_ptr<ScDocument> (use count 2, weak count 0) = {...})
             at libreoffice/sc/source/ui/app/transobj.cxx:821
         #9  0x00007f6d5ec4735a in ScViewFunc::CopyToClipSingleRange (this=0x37a257a0, pClipDoc=<optimized out>, rRanges=..., bCut=<optimized out>, bIncludeObjects=<optimized out>)
             at libreoffice/sc/source/ui/view/viewfun3.cxx:248
         #10 0x00007f6d5ec48ab0 in ScViewFunc::CopyToClip (this=this@entry=0x37a257a0, pClipDoc=pClipDoc@entry=0x0, rRanges=..., bCut=bCut@entry=false, bApi=bApi@entry=false,
             bIncludeObjects=bIncludeObjects@entry=true, bStopEdit=true) at libreoffice/sc/source/ui/view/viewfun3.cxx:212
         #11 0x00007f6d5ec48dc3 in ScViewFunc::CopyToClip (this=this@entry=0x37a257a0, pClipDoc=pClipDoc@entry=0x0, bCut=bCut@entry=false, bApi=bApi@entry=false,
             bIncludeObjects=bIncludeObjects@entry=true, bStopEdit=bStopEdit@entry=true) at libreoffice/sc/source/ui/view/viewfun3.cxx:178
         #12 0x00007f6d5eb0eada in ScCellShell::ExecuteEdit (this=0x35c3d240, rReq=...) at libreoffice/sc/source/ui/view/cellsh1.cxx:1369
        
        Change-Id: I1eb90a0190719a0ffe52dcdc5b0d87f5198cd5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157594
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [06b7a31cbe971470b5551044efc6c977b44bc312]

        Drop some patches for old Clang
        
        There are no longer needed after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441
        "Adapt Clang and GCC minimum version checks"
        
        Change-Id: Id428e2d50a120fe65738e7ba019c4f2c22095f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157491
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [240b37e04a5c797b2be79cf9f592b2d19802161a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e09f381a645a2731e38bfff4a573ee25ccd488b7
          - tdf#154996 Update tools - macro UI help pages
            
            Change-Id: Ic3dd6f3b000bc7ef743c1fc2d055a4dbf5ad90cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157609
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f3a0550b1dd0914e8cbc026a90e10ee3ae2dc8e3]

        tdf#101970 Introduce config option for building with or
        
        without the not necessary template files.
        
        The default is building with all templates, otherwise we can use:
        --with-templates=no/yes
        --with-templates -->yes
        --without-templates -->no
        
        Change-Id: I13f5b411057254771ad4021aa9521c153702af16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157600
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-10-05  Julien Nabet  <serval2412@yahoo.fr>  [74410e57bda7ec355e92ced5c21c956f83a0f6b7]

        Replace useless lcl_throwIllegalArgumentException function (forms)
        
        Change-Id: Icad8c36ef91edd12da8cc533e3ce24c0000a8a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157590
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-05  Justin Luth  <justin.luth@collabora.com>  [27d0c8cbba2a9c2b6aa43e97d56f62d15b3b5bca]

        LOKit: always display hidden chars when showing formatting marks
        
        This is related to the request in tdf#107658 to do the same for core.
        However, this is something fairly easily doable with an extension
        in core, so I'm not in favour of forcing one user's opinion over top
        of status quo.
        
        Doing this only for Online.
        
        make CppunitTest_sw_tiledrendering \
            CPPUNIT_TEST_NAME=testShowHiddenCharsWhenShowFormatting
        
        Change-Id: I34bbe50dd4bbff92577b18f8a05d2f8dd67ea771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157562
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [71dd1f40482cafda40756dd6de4ecaf66b542909]

        ubsan error seen export to ods
        
        sc/source/filter/xml/XMLExportIterator.cxx:722:30: runtime error: load of value 5, which is not a valid value for type 'bool'
        
        Change-Id: I3cf4b6f0a4036a764e976cac6e1b91e298948e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Gökay Şatır  <gokaysatir@gmail.com>  [c0187d9f5e6ab5129b6fc4682555f2f8775d6f67]

        SW comments: Provide parent / child relations without position.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I7acba74ef0717bc07a675be17fc1909680138f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157019
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-05  Justin Luth  <justin.luth@collabora.com>  [32102e559eed6eadf2ea146e212a330a3bc897ca]

        tdf#157574 Revert "tdf#153613 tdf#146984 split para after anchors"
        
        This reverts 7.6 commit 828fde37632a5bb0542b6925454690a5287d6490.
        
        and also reverts the dependent parts of the follow-up test from
        commit 828fde37632a5bb0542b6925454690a5287d6490
        (although the patch itself is fine to remain in place)
        
        and also reverts followup "cid#1522030 Uninitialized scalar field"
        commit 9a123a6e63600ba3998d22bbc300ac4b65b3da2c.
        
        The commit in general is fine. However, it fails in case
        of an empty paragraph (with only anchors).
        Unfortunately, there is no way of knowing ahead of time,
        so either everything needs to be processed after a delay,
        or else the paragraph needs to be split and then re-joined
        in case it is not an empty paragraph.
        Both options are extremely non-trivial - I don't know how
        to do either of them.
        
        Change-Id: I9e98d825ad0008e822172b6797116ad16e90b871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157593
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d7e70203e0246830ed30b1b765c1fc3fab716b9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f8471655a2bcd1616579672c3fd5a2ab26861d9
          - tdf#155875 UI cmds Writer/Help in Help(50)
            
            + refactoring
            + Help part, final.
            
            Change-Id: I217111eaf49acd33af9e6bf3433d5cc218852095
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157597
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-05  Julien Nabet  <serval2412@yahoo.fr>  [7b0e834f33d0360abfe984dec64a3ad0f79b36ad]

        Replace useless lcl_throwIllegalArgumentException function
        
        Change-Id: I0ee09c6882ea36a62a837fc3938f33e4c43f28d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157589
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-05  Julien Nabet  <serval2412@yahoo.fr>  [b20d44d301258ea99d7c20366d35f8fab8682e3b]

        Replace getTabIndexPropertyName and getStepPropertyName (toolkit)
        
        by constrexp or by using the string directly since used once.
        Change-Id: I0d232d5856551bd5dde22ed5075807d20f6f6624
        
        Change-Id: I07d50845ec21998813f3fecb7fb183eaf234f7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157591
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6947cbca81b57adf78c0a3cf3108e664220d0cec]

        cool#7254 crash on double click of value set item in bullets and numbering
        
         #0  0x00007f6d6f39e7a8 in vcl::Window::MouseButtonUp (this=this@entry=0x34177ef0, rMEvt=...) at libreoffice/vcl/source/window/mouse.cxx:430
         #1  0x00007f6d6f6e6a32 in VclDrawingArea::MouseButtonUp (rMEvt=..., this=0x34177ef0) at libreoffice/include/vcl/layout.hxx:707
         #2  SalInstanceDrawingArea::dblclick (this=0x31351fd0, rPos=...) at libreoffice/vcl/source/app/salvtables.cxx:6288
         #3  0x00007f6d6f8c989c in LOKTrigger::trigger_dblclick (rPos=..., rDrawingArea=warning: can't find linker symbol for virtual table for `weld::DrawingArea' value
         warning:   found `construction vtable for SalInstanceDrawingArea-in-JSDrawingArea' instead
         ...) at libreoffice/include/vcl/jsdialog/executor.hxx:66
         #4  jsdialog::ExecuteAction (nWindowId=..., rWidget=..., rData=...) at libreoffice/vcl/jsdialog/executor.cxx:239
         #5  0x00007f6d6e46cebe in lcl_sendDialogEvent (nWindowId=<optimized out>, pArguments=<optimized out>)
             at libreoffice/desktop/source/lib/init.cxx:4961
         #6  0x000000000051eeee in lok::Document::sendDialogEvent (pArguments=<optimized out>, nWindowId=<optimized out>, this=0x30a67ca0)
             at libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:323
         #7  ChildSession::dialogEvent (this=this@entry=0x32d5e410, tokens=...) at kit/ChildSession.cpp:1640
         #8  0x0000000000540465 in ChildSession::_handleInput (this=<optimized out>, buffer=<optimized out>, length=<optimized out>) at kit/ChildSession.cpp:257
        
        Change-Id: I655beb2a33cdb5d266db3bb50d8dc857192e5a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Gabor Kelemen  <kelemeng@ubuntu.com>  [b3ebcb83c3915e99a9572850dc2db4998a438b45]

        Add script to find unused config groups/keys in officecfg
        
        Change-Id: Ic5f71ae8fd2ceab3c2480e083788d904804da213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157523
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-05  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [f9ac0ced960112af69caeacfffd7ebd200f07221]

        [API CHANGE] tdf#154077 Drop InternalMSExport config group
        
        In the code base it was essentially a no-op key
        
        Change-Id: I2cb3bd1bd75cbeda0497bd46136280b4792ee9a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157497
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [d205274a014acabbed88b18d5058682a0ca46f9c]

        Drop MinMax in favor of std::clamp
        
        Change-Id: I021f524b232ddbe091981444d859d35dd9cd05ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157582
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-05  Julien Nabet  <serval2412@yahoo.fr>  [3c162a7a312022716e0648f95662b33577b5993d]

        Replace 2 other lcl_throw* by throwing the right exception directly (toolkit)
        
        Change-Id: Ib0347db6ad5690e0cba9326d7ec3fd85c2f93984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157588
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-05  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [07a06e40400f3713619cb456d62d4bb952e85436]

        Resolves tdf#156337 - Keep warning label enabled on PDF security tab
        
        Change-Id: Ifea77294825b987e4277e146cc34af120e38c8c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154712
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [390e8ad3e96d1ab4494976d7ba6f0d0c728090ee]

        Simplify Bitmap::Dither
        
        ... and drop some macros used there.
        
        Change-Id: I3ee8f3f4f2658904d32e6b63c0be6483783b22b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [b34fceb3caea3de53abfc1fc2cb4a5a15af5fd6f]

        Add BitmapReadAccess::GetColorFromData
        
        Change-Id: Ie7eb0770dc6c5feaa7b4835bdaebfe688a3a381f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157580
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [98771c4a6da0e760b10983e66885fafcfe918d16]

        tdf#157598: sw_ooxmlexport18: Add unittest
        
        Change-Id: If17054cfc56c57dfe9eab5461973fb4c3035f218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157584
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-05  Julien Nabet  <serval2412@yahoo.fr>  [c47038d1248340a4e0347a06707ab317da787b3b]

        Replace 3 lcl_throw* by throwing the right exception directly (toolkit)
        
        Change-Id: Ia351741e46faa6463fac2124262da0153ebe19dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157585
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5c52884611a0e8586ecfa8ccaf24c9e22ad5a872]

        crashtesting: crash seen on exit of chart
        
        with soffice --headless --convert-to ods forum-mso-en4-569016.xlsx
        
        and other similar
        
        Change-Id: I908fa834c1072a9854055cad1ee6261800d76aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dd1e392dfd1934c1819ef32ee01a6c3091c5c7b2]

        cid#1546344 Dm: Dubious method used
        
        Change-Id: If9aaf45784d766651a74de16804c727ac9d066ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f2019dd0e5493d7a33c8a0cea17bc110dcb4271c]

        cid#1545249 Bad bit shift operation
        
        Change-Id: I90a6e1751891e57543a2b2f4312b424df6080f95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157571
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Hossein  <hossein@libreoffice.org>  [e0bedd3f7311bf47392a46d097304e3c7afcb246]

        Revert "tdf#155470 DOCX export: fix RTL numbers changed to LTR"
        
        This reverts commit 40ed8dd3a5a16f21f2e98440c62efa0fa6ec60ff.
        
        Reason for revert: tdf#157598 problem with LTR documents
        
        Change-Id: I6f25913df4e308be660070e1eeca81f08c0547ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157547
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [ae533151bcc16de22fb90b42be1cf7432b0fddc3]

        related tdf#123983: don't open test file read/write from src tree
        
        Change-Id: I7f09a78076fa67447ead82ac7dc8556d840d5697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157576
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-10-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e555ea5937d28bed78e5abeb490451d8148efe9b]

        cid#1546341 Resource leak on an exceptional path
        
        Change-Id: Ia4d91ecb2bbd1d325a801b0b40ab478dc5dd3102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157560
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-05  Heiko Tietze  <tietze.heiko@gmail.com>  [86eb7ad2b4488dcd29c21ae3fc525056b681e199]

        Resolves tdf#156685 - "Object without fill" style for tables
        
        The "Default Drawing Style" uses Tango Sky Blue for the background,
        which is treated as dark since commit
        Ia5e405fc05613726b5011174c8d00ca204eb31b2. This ends up in unreadable
        white font color on white backgrounds for tables. The new style
        "Object without fill" has a clear background.
        
        Change-Id: I6b2f701e4a8cce6200fd2a5e86037e9a36b32833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157568
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-10-05  Miklos Vajna  <vmiklos@collabora.com>  [2d6f48d53674ee85179ec8cee8648830207200a2]

        sw floattable, crashtesting: fix PDF export of fdo56210-3.docx
        
        The bugdoc crashed on PDF export:
        
        	heap-use-after-free on address 0x614000205148 at pc 0x7fb757347d7a bp 0x7fffeff17170 sp 0x7fffeff17168
        	READ of size 8 at 0x614000205148 thread T0
        	    #2 0x7fb75785959b in SwFrame::GetDrawObjs() sw/source/core/inc/frame.hxx:569:66
        	    #3 0x7fb75a802a60 in SwObjectFormatterTextFrame::InvalidatePrevObjs(SwAnchoredObject&) sw/source/core/layout/objectformattertxtfrm.cxx:494:50
        	    #4 0x7fb75a7fe371 in SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool) sw/source/core/layout/objectformattertxtfrm.cxx:155:13
        	    #5 0x7fb75a7ee2c3 in SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame*) sw/source/core/layout/objectformatter.cxx:413:19
        	    #6 0x7fb75a807bff in SwObjectFormatterTextFrame::DoFormatObjs() sw/source/core/layout/objectformattertxtfrm.cxx:337:20
        	freed by thread T0 here:
        	    #1 0x7fb75b7a0b06 in SwTextFrame::~SwTextFrame() sw/source/core/text/txtfrm.cxx:988:1
        	    #2 0x7fb75ab070e3 in SwFrame::DestroyFrame(SwFrame*) sw/source/core/layout/ssfrm.cxx:397:9
        	    #3 0x7fb75b1925be in SwTextFrame::JoinFrame() sw/source/core/text/frmform.cxx:763:5
        	    #4 0x7fb75a4dcd9e in SwFlyAtContentFrame::DelEmpty() sw/source/core/layout/flycnt.cxx:1748:26
        	    #5 0x7fb75a3e3764 in SwFlowFrame::MoveSubTree(SwLayoutFrame*, SwFrame*) sw/source/core/layout/flowfrm.cxx:713:28
        	    #6 0x7fb75a418138 in SwFlowFrame::MoveFwd(bool, bool, bool) sw/source/core/layout/flowfrm.cxx:2149:13
        	    #7 0x7fb75ab63f19 in SwTabFrame::MakeAll(OutputDevice*) sw/source/core/layout/tabfrm.cxx:2886:23
        	    #8 0x7fb75a2fc227 in SwFrame::PrepareMake(OutputDevice*) sw/source/core/layout/calcmove.cxx:388:5
        	    #9 0x7fb75abf7383 in SwFrame::Calc(OutputDevice*) const sw/source/core/layout/trvlfrm.cxx:1803:37
        	    #10 0x7fb75a7e9bd0 in SwObjectFormatter::FormatLayout_(SwLayoutFrame&) sw/source/core/layout/objectformatter.cxx:207:19
        	    #11 0x7fb75a7e9f7d in SwObjectFormatter::FormatLayout_(SwLayoutFrame&) sw/source/core/layout/objectformatter.cxx:214:13
        	    #12 0x7fb75a7eb550 in SwObjectFormatter::FormatObj_(SwAnchoredObject&) sw/source/core/layout/objectformatter.cxx:296:17
        	    #13 0x7fb75a7fd88d in SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool) sw/source/core/layout/objectformattertxtfrm.cxx:133:9
        	    #14 0x7fb75a7ee2c3 in SwObjectFormatter::FormatObjsAtFrame_(SwTextFrame*) sw/source/core/layout/objectformatter.cxx:413:19
        	    #15 0x7fb75a807bff in SwObjectFormatterTextFrame::DoFormatObjs() sw/source/core/layout/objectformattertxtfrm.cxx:337:20
        
        I.e. the trouble is that SwObjectFormatter::FormatObjsAtFrame_() calls
        first calls DoFormatObj(), which joins a follow text frame, but then the
        same SwObjectFormatter::FormatObjsAtFrame_() calls DoFormatObj() again,
        and that still refers to the now deleted text frame.
        SwFlyAtContentFrame::DelEmpty() calling SwTextFrame::JoinFrame() was
        added recently, in commit cfe9c68a7a19dd77d1fcbde3a7dd75730634becc
        (tdf#157119 sw floattable: fix moving master of split fly to next page,
        2023-09-21).
        
        Fix the problem by dropping the 2nd fix from the above commit (and leave
        the other 3 unchanged): that is no longer necessary for the old
        use-case, probably because in the meantime commit
        695390b08799af34b393c81c834d615bea330d89 (tdf#126449 sw floattable: fix
        too small height of non-last anchors, 2023-10-03) started to add some
        real height for some of the split fly anchor frames, so less manual
        joins are needed.
        
        Note that the crash only happens with this bugdoc in case
        MALLOC_PERTURB_ is set to something non-empty or when using sanitizers.
        
        Change-Id: I4b810bd77a01a251dd1225426c50a7d7f100ece2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157577
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-05  Miklos Vajna  <vmiklos@collabora.com>  [9baf674be882bff2736b586d546c55a84fc2b989]

        uitest oneprocess mode: add a way to explicitly avoid this
        
        The intention is to use this for known-problematic existing test suites,
        so later the default can be changed for new tests.
        
        Change-Id: I5a0c590a5d0fcc7ac86fba64affb10a301b36341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157570
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a217a80bf383ddab0a5e0959ab2fd907dfd3406]

        Fix typo
        
        Change-Id: I9363004f30c6b49da7911ddf1e4bad468d7aa8b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157555
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-10-04  Henry Castro  <hcastro@collabora.com>  [adcde78935fb8ca2b93322aa3a558d0b3ccdbfad]

        tdf#155512: oox: ppt: fix import master slides
        
        Import all master slides according to
        the relationship with slide layouts.
        
        Adjust unit test values:
        
        SdOOXMLExportTest2::testTdf106867
        I do not know why those values change since
        importing embedded video source code was not touched
        
        SdOOXMLExportTest2::testAccentColor
        The accent6 is a constant value.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ic7c70d2c4ce30a7f2d2d1cf22604f1119a66f5f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157387
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 08ed103d734ebf65202dc097c7bb0990573f8fd1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157532
        Tested-by: Jenkins

2023-10-04  Justin Luth  <justin.luth@collabora.com>  [b75d4156a3b2550db2cff1360a598e508ee51c8f]

        related tdf#157572 docx export framePr: no w:x if zero or xAlign
        
        xAlign has none of the complexities of yAlign.
        if xAlign is defined, it takes priority over w:x.
        So simply don't write out an unnecessary w:x
        if it is the default value (0) or if there is a xAlign.
        
        This change is just made to keep the code somewhat consistent
        between w:x and w:y.
        
        Change-Id: I5ef1da309e35e25660247675ba9ab6e336becd41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157566
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-04  Justin Luth  <justin.luth@collabora.com>  [5760d7876dae55d351e80b990dc064440fa46a73]

        related tdf#157572 writerfilter framePr: no vAlign if vAnchor=text
        
        See bug 157572 for the documentation.
        
        This can be seen in MS Word's UI.
        Have the vertical position be centered, and then change to "para":
        -> the vertical position changes to a numbered distance.
        
        make CppunitTest_sw_ooxmlexport5 \
            CPPUNIT_TEST_NAME=testTdf157572_noVAlignAsText
        
        make CppunitTest_sw_ooxmlexport5 \
            CPPUNIT_TEST_NAME=testTdf157572_insidiousCombination
        
        Change-Id: I6c00a34f14633e16178c1504a37e644a30cf4cd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157529
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-04  Henry Castro  <hcastro@collabora.com>  [3d665f4ee60d994257a29d5fc607d6c88593aed7]

        uitest: add load properties parameters
        
        Add the option to include the load properties
        when invoked load_file function.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I27cb31e2470bc76bcc5b760661e50f00fc334d64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157567
        Tested-by: Jenkins

2023-10-04  Jean-Pierre Ledure  <jp@ledure.be>  [a29841ccbdf1e71b9a7c943c5c430d1a1b96234b]

        ScriptForge (SFDocuments) Styles management
        
        Introduction of new properties and methods:
        
        - StyleFamilies
            List of available style families
            All document types except Base
        - XStyle(family, stylename)
            UNO representation of given style
            All document types except Base
        - Styles(family, [namepattern, used, userdefined,
                 parentstyle, category)
            A list of styles matching the given criteria
            All document types except Base
        - DeleteStyles(family, styleslist)
            Suppress the user-defined styles in the list
            All document types except Base and FormDocument
        - ImportStylesFromFile(filename, families, overwrite)
            Load styles from a closed file
            Calc and Writer only
        
        Example: to delete unused styles:
            a = doc.Styles("ParagraphStyles", used := False)
            doc.DeleteStyles("ParagraphStyles", a)
        
        All functionalities are available from Basic and
        Python scripts.
        
        Documentation has to be completed.
        
        Change-Id: I2533c14912257b58feb42bb11ff9d151c7b9531a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157563
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-10-04  Bogdan B  <buzea.bogdan@libreoffice.org>  [7b4bf155b622e985cdc5f90d620d0a797bc48204]

        tdf#145834 Consistency for "Fontwork"
        
        Change-Id: I5f660fac8576d96bf2d2363106be56a4d4fb4f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157545
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-04  Justin Luth  <justin.luth@collabora.com>  [44401e14ff0aab5bc9505c2ec3b78ce91eaf8f4f]

        related tdf#157572 writerfilter framePr: no vAlign if w:y defined
        
        Documentation suggests that vAlign overrides w:y
        (as long as vAnchor is not equal to text).
        However, testing proves the opposite.
        Only when w:y is not defined does vAlign take effect.
        
        make CppunitTest_sw_ooxmlexport5 \
            CPPUNIT_TEST_NAME=testTdf157572_defaultVAnchor
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf154703_framePr2
        
        Change-Id: I8a5366d9b6bde0ad838f9584836a85fe79ce8b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157528
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-10-04  Henry Castro  <hcastro@collabora.com>  [1058d5edc0b6bbaddea2af520d8b5c3e54ec7498]

        uitest: flush print messages
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I87098a438d476529aa25b6608408d07bbc98ce0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157557
        Tested-by: Jenkins

2023-10-04  Justin Luth  <justin.luth@collabora.com>  [4dd491bc50801d10bb2f1004fff6ebcdb5da9f59]

        tdf#157572 tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor default
        
        Fixes LO 7.6 regression commit 630732bfd8ed531e9d412a36a083f33763def054
        
        See bug 157572 for the documentation.
        
        To test this, I used ooxmlexport5's tdf112287B.docx with Word 2010:
        -changed vertical relative to Paragraph - exported w:vAnchor="text"
        -changed vertical relative to Page - exported w:vAnchor="page"
        -changed vertical relative to Margin - did not export w:vAnchor
        
        So, obviously the default is "margin"
        
        Note that it always exports w:y=1
        
        For importing, the default vAnchor changed depending on whether
        w:y=0 (text) or w:y=1 (margin)
        * an exception is when w:y=0 and vAlign is defined - then 'margin'
        
        make CppunitTest_sw_ooxmlexport5 \
            CPPUNIT_TEST_NAME=testTdf157572_defaultVAnchor
        
        Change-Id: I126094eafc43a83e3a4efdd1ebc8d9cab9d49759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157527
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-10-04  Henry Castro  <hcastro@collabora.com>  [0d21e1075f0288a007cb427ce508d6fbbf8503dd]

        uitest: add signal_handler function
        
        install signal handler to analyze if the
        soffice bootstrap has some issues.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8b05b9c24bf531f4162554433180d80526cb2983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157518
        Tested-by: Jenkins

2023-10-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a3935f1a09405a56f13f661797f64ecd31e095f7]

        remove obsolete -single_module linker flag (is the default)
        
        has already been unnecessary since over 15 years/was the default since
        OS X 10.4 (2005) along with ignoring the corresponding altenative
        (-multi_module) switch, from man ld:
        -single_module
            This is now the default so does not need to be specified.
        
        -multi_module
            Multi-modules in dynamic libraries have been ignored at runtime
            since Mac OS X 10.4.0.  This option is obsolete.
        
        Xcode 15 now warns about it being obsolete, so remove it.
        
        Change-Id: I4d4aab452a330c3c4ec97da4232c3af6350c0ff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157407
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [809733714b7501490c5a6fa690d254ec7f9bc8f9]

        macOS /w Xcode 15: force the old linker when targeting macOS 11 or lower
        
        the new linker has problems with weak symbols and causes runtime crashes when
        trying to run those builds on older versions of macOS
        
        https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking
        
        they write the classic linker will be removed in a future release, so have it
        error out for Xcode 16 for now just in case. The brave soul who tries it out
        first will have to disable that AC_MSG_ERROR… (or expliticly set macOS 12 as
        min target)
        
        Change-Id: I653e5bce70b3eae0f512be11dc7e07ffc98e9812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157336
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-10-04  Bogdan B  <buzea.bogdan@libreoffice.org>  [c049d88296feaac44494edee91088b275e315fb7]

        tdf#143280 Improve label for Area - Gradient
        
        In order to have the meaning: number of increments.
        
        Change-Id: I74b46dfb2ba43a243d0fdd6c56cae53f65fd9526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157538
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-04  Julien Nabet  <serval2412@yahoo.fr>  [1d11f80148a3aef22bef2f4a15ddaa75b57a8673]

        Replace useless throwNoSuchElementException function
        
        by its straightforward and short content.
        
        Change-Id: Ic847f12923e71addf00b7b16546c8168cf3952f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157552
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-10-04  Miklos Vajna  <vmiklos@collabora.com>  [89a75cd194371002247d0138e759835bc673f7b0]

        tdf#126449 sw floattable: DOC import: handle inner floating table
        
        One problem with the bugdoc is that the inner floating tables in the DOC
        file stay in a single page.
        
        Seems the usual to-para anchoring + allow-to-split logic is not used
        here, because the toplevel table is handled at
        SwWW8ImplReader::StartApo(), but the inner table is handled in
        SwWW8ImplReader::StartTable(). Additionally, the toplevel table is
        anchored to-para (which seems to be the closest to Word's "position this
        table based on the next paragraph" concept), but the inner table was
        anchored to-char, and such fly frames can't split.
        
        Fix the problem by switching to to-para anchoring even for inner
        floating tables. This improves consistency with toplevel floatint tables
        from DOC and all floating tables from DOCX. It seems to the to-char
        anchor type was added in commit 10f352d2faf6a4d72337b2c098a65377eee5138b
        (INTEGRATION: CWS swqbugfixes18 (1.111.60); FILE MERGED, 2005-03-30),
        but there the motivation was to make sure these are not inline; so that
        use-case keeps working.
        
        This does fix the overlapping text with the original bugdoc, but
        otherwise the DOCX version is still slightly closer to the Word render
        result.
        
        Change-Id: I379a26194da4d3a06241aa3c6f5ae78606f8fc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157550
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-04  Michael Stahl  <michael.stahl@allotropia.de>  [1ea27b7e35faf6619112bf3f1d69e4ec41c0bf23]

        vcl: remove defensive programming from SetCurrentStructureElement()
        
        Change-Id: I47b0f29a564cdbdd1a55fe4a332fa9efd63af557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157505
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-04  Michael Stahl  <michael.stahl@allotropia.de>  [a8f522f4257729ea11178ebf165fdd3a2b7be240]

        vcl,drawinglayer,sw: PDF/UA export: footnote-container-in-list problem
        
        The problem is that if there is a footnote in a list, the footnote
        container becomes a child of the LI element that contains the footnote
        anchor, which is of course nonsense.
        
        This is because SwTaggedPDFHelper::CheckReopenTag() stopped using
        SetCurrentStructureElement(), but unfortunately it's required so that
        once the list ends, the correct parent element is restored for whatever
        follows the list.
        
        There is a similar problem in VclMetafileProcessor2D.
        
        (regression from commit d467f1aa3d028f399826c97e2eecedcd79efcf65)
        
        Change-Id: I03dee5dc2e11accb97279e5f325808c5b85507a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157501
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-04  Michael Stahl  <michael.stahl@allotropia.de>  [5cdb4e495e23be77466d8f8bbe6ae643b60d3aa6]

        sw: PDF/UA export: merge footnote frame follows
        
        Change-Id: Icb1c585c4d321e38a6ac3d841846d505c4816db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157504
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [12157c9e42ffd89b3e0de205a1ecf500cd78d992]

        Drop some patches for old GCC
        
        There are no longer needed after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441
        "Adapt Clang and GCC minimum version checks"
        
        Change-Id: I2978571ff4a175f876f590dadd4931f53fd0f26b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157490
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-10-04  Regina Henschel  <rb.henschel@t-online.de>  [10c7bc0c824697b92c22bddacd739de9127dc80e]

        tdf#157289 normalize ellipse bounding box in oox export
        
        The predefined geometry of a circular arrow shape has bottom-right
        vertex first and then top-left vertex of the bounding box of the
        ellipse. We now use the normalized rectangle to calculate the radii of
        the ellipse. Before this patch the calculation had resulted in negative
        radii.
        
        Because the ODF standard only states, '(x1, y1) and (x2, y2) define the
        bounding box of an ellipse.', but not which vertices to use, the fix is
        not made in changing the geometry of the circular arrow. Instead the
        export is changed to use the normalized rectangle. That is more general
        and will cover other shape types too. Especially non-primivite shapes
        might use other vertices than top-left and bottom-right to determine
        the ellipse.
        
        Change-Id: Ica859c9adc508a6517e30f111cd54518ec9929a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157526
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-10-04  Miklos Vajna  <vmiklos@collabora.com>  [4c5f51a7ac4c0f7043ead2b3b48e71c33e16f992]

        tdf#157394 sw: fix inserting reference mark with existing selection
        
        Type "myword" in Writer, select it, Insert -> Cross-reference, set Name
        to "myname", click Insert. The body text now had "myword" twice, instead
        of creating a reference mark on the existing "myword" word.
        
        This went wrong in commit 16075474819696f920979969474aa8300f4af530 (sw,
        field insert: handle the Content param for refmarks and accept HTML
        there, 2022-12-21), because it assumed that in case the uno comand is
        dispatched with some reference text, then that has to be inserted at the
        cursor position and only then the refmark can be created on that range.
        It was not expected that the current Writer selection would show up as
        refmark text.
        
        Fix the problem by taking the refmark text from the uno command
        parameter only in case we don't have selection, which restores the old
        behavior on manual insert of a refmark and keeps the new uno command
        parameter working.
        
        Note that contrary to the bug title, inserting cross-references did
        work, but the trouble was the insert of the duplicated word.
        
        Change-Id: I1a8b002c2a6f196975a18e01f0e8c457cfb416bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157524
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f95c3994f0b6a82a3bc2ddfb68822b74479ae185]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 330186afbf28123351e97dc7f67583952e0b6ff7
          - tdf#155875 UI cmds Writer/Help in Help(49)
            
            + refactoring
            + Help part, search commands.
            
            Change-Id: I9f22318164f53107fc1d84bedc1c0ae67e6d6448
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157522
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [206130e95b6b6c228467f91d3deccf5970947616]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4ef220076879c2e0061af81c62611068d2182b8
          - tdf#155875 UI cmds Writer/Help in Help(48)
            
            + refactoring
            + Help part.
            
            Change-Id: I7ce7c293a283c62040f351816843a2f8f84ca9e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157521
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-03  Yli875  <qq3202390739@gmail.com>  [67594344631c362d43b9d6a0cfadefbcfa5046d8]

        tdf#145538 Use range based for loops in idl:object
        
        Change-Id: I7c9935254be5bea050a09859cebbc4112894999b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156858
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-03  Henry Castro  <hcastro@collabora.com>  [9fabd7c11989c2a89c5bb238e6cb52b0a6678851]

        tdf#155512: oox: ppt: abstraction "importMasterSlide"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Icfe8e3abbada7f728b2ad1f8e300a688f51d8f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157386
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 84ac58c37fffa0c8b6d55c70009515d013ad65b4)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157468
        Tested-by: Jenkins

2023-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e47c1737d6f1365aa640f1960fb0c9892fde6d77]

        tdf#155756 sidebar properties not displaying height over 100
        
        Change-Id: I5ea2441319e0d7c34ffdcd179d8a82738da4733f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-03  Hannah Meeks  <hmeeks4135@gmail.com>  [3288065782544e7a2571c808f3ff17487018f762]

        Simplify long if statements
        
        Change-Id: I379fb5809e5e00788445bcf9cebdcaba563b1af4
        
        Use structured binding, fixup
        
        Change-Id: Ibd52ff1313336aa8a082477dee3ea7fce0f1d3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157492
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-03  Miklos Vajna  <vmiklos@collabora.com>  [695390b08799af34b393c81c834d615bea330d89]

        tdf#126449 sw floattable: fix too small height of non-last anchors
        
        The bugdoc had an outer inline table, a middle inline table and an inner
        floating table. The floating table is expected to be on pages 2, 3 and
        4; actually it was only on page 2 and 3.
        
        This happened because the fly frame that should be on page 4 was on page
        3, leading to overlapping text. And that bad fly position seems to
        happen because the anchor frames just have a 1 line height (~269 twips
        instead of the fly height).
        
        Fix this similar to how "first paragraph only" wrapping works: increase
        the (anchor) text frame height, even if the contained lines would not
        require that amount of height.
        
        With this, finally the DOCX version of the bugdoc lays out reasonable
        (all 5 pages).
        
        Change-Id: Ib08bf34be61eb2b4d8656887f83ac7fd17e3b252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157507
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-03  Mike Kaganski  <mike.kaganski@collabora.com>  [140dc375adfffa59dff2652eb8b9625c23d81c8b]

        Use Degree100
        
        Change-Id: I133dbe40d57eda77b64f3e38631da30f296489f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157517
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-03  Arnaud Versini  <arnaud.versini@libreoffice.org>  [9b462abdb36ce73ad627a0b603b24d3f35ffc1ee]

        accessibility: avoid OUString creation by using unicode OUString literals
        
        Change-Id: I0f1f8c4e7601c68af607d6c540527e2979520586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157136
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-03  Miklos Vajna  <vmiklos@collabora.com>  [2ecd4c009293f127ac09e5f4184330c4337cee49]

        sfx2: fix gcc dbgutil -Werror=unused-variable
        
        /home/vmiklos/git/libreoffice/master/sfx2/source/appl/workwin.cxx: In member function ‘void SfxWorkWindow::ToggleChildWindow_Impl(sal_uInt16, bool)’:
        /home/vmiklos/git/libreoffice/master/sfx2/source/appl/workwin.cxx:1861:27: error: unused variable ‘pCW’ [-Werror=unused-variable]
         1861 |     if (SfxChildWin_Impl* pCW = Get_BySaveId(aChildWins, nId))
              |                           ^~~
        /home/vmiklos/git/libreoffice/master/sfx2/source/appl/workwin.cxx: In member function ‘void SfxWorkWindow::ShowChildWindow_Impl(sal_uInt16, bool, bool)’:
        /home/vmiklos/git/libreoffice/master/sfx2/source/appl/workwin.cxx:1990:27: error: unused variable ‘pCW’ [-Werror=unused-variable]
         1990 |     if (SfxChildWin_Impl* pCW = Get_BySaveId(aChildWins, nId))
              |                           ^~~
        
        Change-Id: Iecc60032459ca8a6543f3836f17b76b25939cda9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157516
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-03  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [63a5c6350f8930774c651a9cf41521606ecb6a94]

        tdf#157170: clarify angle quotes autocorrect rule
        
        Change-Id: Idb514e0e0487a65e3057328a13d34659d706ab90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157300
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-10-03  sahil  <gautamsahil1947@gmail.com>  [11b06806e7b674ee3992e684d8f9dfd6cfc6999a]

        tdf#151384 Character Style internet link.. Test
        
        Change-Id: Ia402648b9b3feea64b7a8ba16c72dc439dbd6679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157281
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [58d755bfef8a932577b550751cd5cc4bafb1700c]

        ofz: Timeout, reduce limit
        
        Change-Id: Id14418dc382c0d11554817fc37990e3f3cba3a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157514
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-03  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [d059aebd99f717d846e7746d5ff5b99d507a3160]

        openssl: upgrade to release 3.0.11
        
        Change-Id: I80c6fde3b6ae526f46b6bc346f09b287cc88b032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157433
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a235da83013bb9fccba29d87154aa93235a1c048]

        ofz#62935 avoid negative numbers in olHanglJaso
        
        Change-Id: I3898b95e9d2fe60690889ba259859ed9f66636d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157512
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-03  Mike Kaganski  <mike.kaganski@collabora.com>  [6dd514f633211b3cd6a6096b687c4e51a331ee4b]

        Try to use doubles in a saner way
        
        This avoids convertion to integers too early, so makes the calculations
        more consistent (no more "use a truncated double later in a calculation
        involving doubles").
        Also it moves variables into proper scopes.
        
        Change-Id: Idc11c30c2c6892db092a04a127eb31266b4b70e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157510
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d95f58a1ebf2ff7fb163cd423df16b4a6167a8fa]

        tdf#156756 Icon sizes for the toolbar wrong (part2)
        
        my previous fix
            commit 715a6ea8cb3aa6c80edbb22909aac3f18b7daec6
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Oct 2 11:31:09 2023 +0200
            tdf#156756 Icon sizes for the toolbar wrong
        had a bug which broke changing themes
        
        Change-Id: Icf19fee5034ec2795354641c62979b6284e1a5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157506
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-03  Noel Grandin  <noelgrandin@gmail.com>  [d9e322d60f65ff20631dab87baa5a2c7c71daaa2]

        replace ErrorInfo with simpler mechanism
        
        Instead of returning ErrCode class everywhere, return a new
        class ErrrCodeMsg, which combines an ErrCode with the other
        parameters that are used to control the error reporting.
        
        I do not change everything that uses ErrCode here, I started
        from SfxBaseController/SfxMedium and worked outwards.
        
        This change serves two purposes
        
        (1) Replace the extremely whacky ErrorInfo mechanism we were
        using to smuggle information into the error handler reporting
        mechanism with a very straightforward approach of just combining it
        into the error class.
        (2) Allow us to capture the source location that produced the error,
        which makes debugging the source of a problem soooo much easier.
        
        Change-Id: I978b8f00c9851b41a216c7ebdef2ef94251d5519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-03  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [64fc701388d1dcf8ae36ba2cc73eb5416a7c3374]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: I6c7d8d92fe6860cd213a3cbded2451e8788ae2f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157196
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fc5cd82fa5bb85495e34a762fdf1db91b5e93d12]

        optimize DrawRect if we fill but no line color
        
        because that's the same as if we had line color the same as fill color
        
        Change-Id: I540b31c0dcd07dfddbbd9f8cf396f7df3a4edb4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157498
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-03  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [89367021a4c960b6873370ea9472b36457c51ef3]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I155cf98404dea83121f95ad3e784bc0e862f46d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157416
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-10-03  Miklos Vajna  <vmiklos@collabora.com>  [1ab4e9eb63bfd07a30c0febe8df4bc34d90d33be]

        sw: improve documentation for SwFormatSurround
        
        Mention which item set is expected to contain this and where is the UI.
        
        Change-Id: I63ee57218eb7c4bc9be4430eb90d98bd43739b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157502
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-03  Jim Raykowski  <raykowj@gmail.com>  [c603d37223d4f7c3594515fb2bbac22015bc146b]

        tdf#157370 Bring A11y issue to attention in the document view
        
        when issue is clicked on in the A11y sidebar
        
        Change-Id: I9122e608e88568fa2deeee91b6cf4616b0f61db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157200
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-03  Jim Raykowski  <raykowj@gmail.com>  [9389102ee5e6adbb0f8b10f8aee60d1899d91d27]

        tdf#157315 Don't set mark after inserting a file in a Master document
        
        Removes setting a mark after inserting a file. Setting a mark here
        causes a selection to be made on mouse click in the document after
        inserting a file which probably isn't what is expected.
        
        Change-Id: I3e7597dfecb04c9b3cfba8081fa74dffcf0d78dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157032
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-10-02  Mike Kaganski  <mike.kaganski@collabora.com>  [c5574385303a86b6f65002d6bc4ff074f9e84d49]

        Deduplicate and simplify some SfxWorkWindow methods
        
        Change-Id: Ibd7153454f1efd1d311ac99b9c2529958f4ca3e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157500
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-10-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4bce8705cb40f8c75c0a943b1572d3347d7b4fd3]

        Remove unused/deprecated TypeDetection.xcu
        
        Change-Id: I75b8e7b2ab14d46dc4ca966c9995c6f8e69eead1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157487
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-10-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [3e753f484910fb65065dd7eb81d2131b51990fe9]

        tdf#146619 Recheck include/s* with IWYU
        
        Change-Id: Ia0a6330278b044f448c9928362308aadc8fc9a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156989
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-10-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b56fbafcc34a1b3d857d47f3f9695804edf7009]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e0a3eafc3fabcdceab8324073548a0117908ef51
          - tdf#128150 (related) Illustrate "use background"
            
            + Add illustration for "Use Background" for area fill in Impress
            + Refactor
            
            Change-Id: Ia70861904d9e4c3b1d126aa50b468cd226995792
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157431
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-02  Jean-Pierre Ledure  <jp@ledure.be>  [d97b5849f3cfcecbdd929dca7bd7ac2c4fa31f8b]

        ScriptForge (SF_Session) validate Recipient arg of SendMail
        
        When the Recipient argument is absent when calling
           session.SendMail(...)
        or is not a string, an error message is raised,
        as should, but its content is wrong.
        
        The error message is now corrected.
        
        Change-Id: I248b6ce55c85a4b956f834c8e1ea7d0df40ab233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157488
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-10-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [11943b9ab229c0d2faee6c9ca89792d70a3cfb6f]

        tdf#157131: sw_uiwriter3: Add unittest
        
        Change-Id: I4a74712e5472002295c2febc7c12bcdb7f932e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157489
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-10-02  Szymon Kłos  <szymon.klos@collabora.com>  [e2ee3dd61ab8ea5d970d8da5df3233e7bba5909e]

        lok: add broken package interaction handler
        
        in case of repair don't use template flag to not make
        file readonly so we can overwrite it and upload to storage
        updated version
        
        Conflicts:
        	desktop/source/lib/lokinteractionhandler.cxx
        	desktop/source/lib/lokinteractionhandler.hxx
        	sfx2/source/doc/sfxbasemodel.cxx
        
        Change-Id: Ia460009fc3b77582dde06dd6f94a85aef3aee11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157493
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6ce4d0091f1e55080f5e9e9c54f27747d1ef700f]

        drop use of urp: followed by newline of space
        
        and just use space
        
        Change-Id: Ib2765855971691aa72643d3e3d5c06cdcbd634ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9e6454142cbdf0df9a70060363157b06c5115a96]

        cid#1545284 fix UR: Uninitialized read of field in constructor
        
        Change-Id: I6d2449f86c4d5745c6068b5df4bf362198cabd18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157479
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Regina Henschel  <rb.henschel@t-online.de>  [dd7fc07f83416a3d8a444947b7d28f7347520d6a]

        tdf#157543 Add glue points to binary 5-point star
        
        The patch adds the glue points defined in 'Microsoft Office Drawing
        97-2007 Binary Format Specification' to our corresponding preset
        'msoStar'.
        
        This star shape is contained on page 1 in odp/shapes-test.odp. It had
        previously no glue points, but now it has five glue points. Thus I have
        updated the xml dump.
        
        Import from pptx is still broken, tracked in tdf#157216.
        
        Change-Id: Ifc9f28118fe23a3d37af0357b72bb23eeef6b894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157446
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b2ae79edde95f485e381741f816d45248798778]

        tdf#157164 Vertical Position preview does not show red line for baseline
        
        regression from
            commit f510ea2d7962a4325055c6380a0032331b4e87cf
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jan 12 11:49:35 2022 +0200
            don't bother trying to draw stuff which is effectively invisible
        
        Change-Id: Idc947163521ebfb65b27204fb5c65b1f59fe6de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157481
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [715a6ea8cb3aa6c80edbb22909aac3f18b7daec6]

        tdf#156756 Icon sizes for the toolbar wrong
        
        So my change in
            commit 0558926c2f9201a12b4c46efc36b8a4080af4d46
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 6 10:42:10 2023 +0200
            use more officecfg for SvtMiscOptions
        
        Made an existing bug much worse.
        
        The underlying bug started in
            commit fd92b09db497a7dfd594a5418f87856dc3886bf9
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Tue Feb 14 13:12:38 2023 +0000
            tdf#153541 notify listeners when any of the icon sizes change
        
        which resulted in changes to icon sizes not being saved to the registry,
        because the registry layer would throw an exception when called from
        SvtMiscOptions_Impl::ImplCommit, because it does not like being passed
        null values for SidebarIconSize and NotebookbarIconSize properties.
        
        So I have done two things
        (1) finish removing handling of SymbolSet from the SvtMiscOptions_Impl
        code, and just use the officecfg:: layer.
        (2) Change the ImplCommit code to only pass down properties for which it
        actually has valid values.
        
        Change-Id: Ib7c09cac373060f5437b81c63e9b12411fdc1c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3c961e6a3917d95534652e0f982918cc1079015]

        reduce allocations in InterceptedInteraction
        
        the list of intercepted interactions is static per sub-class, so just
        pass up a o3tl::span at constructor time.
        
        Change-Id: Ib45c5a3338e0eb3848486dfc707052f07492eb61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157480
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-10-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fa229eb1ecbcbb7b861679158ad706e37d454526]

        Update git submodules
        
        * Update translations from branch 'master'
          to a005336559523e33025cc23b144a4b6a0f89f5c6
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I93d4f5b65843f98eda63af0f8e45468a0f9a073f
            
2023-10-02  Miklos Vajna  <vmiklos@collabora.com>  [819fabd11f9b78bf7ecef1d2afeae1a9d8382afa]

        svx: prefix members of SdrHdlGradient
        
        See tdf#94879 for motivation.
        
        Change-Id: I1da02ee14cb3cbc0cd51ccc4f612947b789ca46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157478
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-10-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [25d09bdb9f48313c000cc8ec8df60b1bb8efe2e6]

        tdf#87638 - Modify slide pane title in Impress/Draw based on edit mode
        
        Change-Id: I0dd668324c32172144f29cf40c52e2b66e7895b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157444
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0083083c8cd269446d0f2955ffe2f17bbc3bf22b]

        these can be final
        
        like ScDrawDefaultsObj is
        
        related to
        
        cid#1545815 API usage error
        and
        cid#1546386 API usage error
        
        Change-Id: Ib015a6c6c2e4b6425f218b603a41a8a0027e4a92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5046b36374c164d8f0dd2a70b5a250d8536b1ed6]

        cid#1546494 Dm: Dubious method used
        
        Change-Id: I19a4a9321d544eb6d9d37ffb82bbbbfc4f08661c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157473
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d4f7f7b22be5dd4d0d924ca0099f9375835149c9]

        cid#1545515 Dm: Dubious method used
        
        Change-Id: Ife18effd9e477e977e555aea03a78b312e99c6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157472
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d96f8e87617ad653fcd104818036162b9eeed3b2]

        cid#1546292 DLS: Dead local store
        
        Change-Id: Id3afb3c3541f55da5e1bff6f139c7320d6760b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157471
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [109eab34a6af708da551d220162eac0578e42449]

        Mention correct config key
        
        Change-Id: Icb7c3d8b0350aa3b086c54793f9107e873eba401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157368
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-10-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9eb419b0b0f019f5fbc48ff1a11977e8b041edee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67d1ef52211182f7e3dc3e15583b3732c32124d1
          - Improve wording on title page Help
            
            Change-Id: I203e01aeac1a98c35ad85ef836f8a764d55e2b6a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157454
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [060f6be53c1813209f4cdd2d39dd11b07e331ec7]

        cid#1545284 UR: Uninitialized read of field in constructor
        
        and
        
        cid#1545614 UR: Uninitialized read of field in constructor
        
        Change-Id: I7d801651951fa7243cdd106f54f6a15bdfb0e423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157470
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9150c8c09645be12849cdb5aad484ee344b7b313]

        Resolves: tdf#157515 only remove RID_SVXPAGE_PARA_ASIAN once
        
        Change-Id: I65faa99444636c5bc5b21008d4cfb144fbcafb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fe2031b993721dbe40d71684f4609ee3cf018958]

        cid#1547033 Dereference after null check
        
        Change-Id: Id407ef300fca83167fb9813534fb099c6e56fc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157449
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-10-01  Patrick Luby  <plubius@neooffice.org>  [fe3fa1699f12eb007d26bbb19f5ff80826bc384f]

        tdf#156881 Disable Metal with AMD Radeon Pro 5XXX GPUs on macOS Catalina
        
        When running macOS Catalina on a 2019 MacBook Pro, unexpected drawing
        artifacts are drawn so disable Metal for the AMD Radeon Pro GPUs listed
        for that model in https://support.apple.com/kb/SP809.
        
        Change-Id: Iffe44da1f07af2f3bbc367051b5ea4d522216eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157443
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-10-01  Patrick Luby  <plubius@neooffice.org>  [53c27f66fcb5a624ef27d2480b0f3e584a1ba1ef]

        Fix iOS build breakages when building on macOS Sonoma
        
        Change-Id: I347e48e9da69c8c9b15581a5afa5c61cdd1d380d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157411
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Patrick Luby <plubius@neooffice.org>

2023-10-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [abe09b45da5002a0011f7289a26e7971e4ea8f06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e9dfbfb189c9535944a8b883191faa631e9a730
          - Mute  L10n
            
            Change-Id: I1b2fa616fbea350e04c82eb54b71c7642615a5a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157329
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-10-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [8938bc703980e3bdf4a32863f3e0193302a08cde]

        tdf#154449 Add support for hidden named ranges
        
        This patch adds the possibility of having "hidden" named ranges in Calc, in a way similar to what MS Excel has (i.e. they're not visible in the UI and can only be hidden/shown via scripting).
        
        This is done by creating a new HIDDEN flag in com.sun.star.sheet.NamedRangeFlag.
        
        Hence thia patch makes it so that named ranges can be made hidden/visible via scripting. For instance, consider a Calc document with a named range "NamedRange1". The following scripts hides "NamedRange1" from the UI (i.e. it's no longer visible in the Manage Names dialog):
        
        Sub SetHidden
          Dim eFlags : eFlags = com.sun.star.sheet.NamedRangeFlag
          aNamedRange = ThisComponent.NamedRanges.getByName("NamedRange1")
          nType = aNamedRange.getType() Or eFlags.HIDDEN
          aNamedRange.setType(nType)
        End Sub
        
        To make the named range visible again:
        
        Sub RemoveHidden
          Dim eFlags : eFlags = com.sun.star.sheet.NamedRangeFlag
          aNamedRange = ThisComponent.NamedRanges.getByName("NamedRange1")
          nType = aNamedRange.getType()
          nType = nType - (aNamedRange.getType() And eFlags.HIDDEN)
          aNamedRange.setType(nType)
        End Sub
        
        This patch also implements ODS and OOX import/export, as well as QA tests.
        
        Change-Id: I10efe46938fe772b87dc17fc597cb83648b5efb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155599
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-10-01  Alain Romedenne  <alain.romedenne@libreoffice.org>  [eb68c77168db379d9d805a221a30581962040afb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8313fdfe3877948b51781949448c6439ee08b734
          - SF_Dialog help page updates:
            -  missing literals
            -  method signature review
            -  mute Basic & Python
            
            Change-Id: I64ceaa4c90c2b4b9e684359a838e4bd0a299c81c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154127
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [506fb766885f147a40f09ffca803b4e31b14b1e1]

        cid#1546192 SIC: Inner class could be made static
        
        Change-Id: Ib8a298d86a7f04a2ca63751e3e39960e276b6514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157439
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [adde35839be1b302547ec39bc330999dc3d55727]

        cid#1545655 Dm: Dubious method used
        
        Change-Id: I76b447d51429c867e24c1bcdd357689c849ea103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157438
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1064a0d941099203fb5781edf599274dbf078931]

        cid#1545766 silence Unguarded read
        
        a bit zealous here, its all on the same thread as it turns out
        
        Change-Id: Ic2e8d8eba4fea672fa56c88abedb853fd886cecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157437
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8be0f46db22c1d73816acd5df37f7082dc46c23]

        cid#1546839 Logically dead code
        
        Change-Id: Id4c97f0f18a88ee973acdb9a8e703f0ed3c5ee1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157436
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-30  Jim Raykowski  <raykowj@gmail.com>  [9f2b1f30c98a351ec0330db9f131d608c29a3336]

        tdf#152029 Improve bringing sections to attention
        
        Makes bringing nested sections to attention behave better
        
        Change-Id: I086f301b095191eac90c547b61e0cec590b03705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157261
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-30  Justin Luth  <jluth@mail.com>  [1cf500366e8de4c1c89c1f9235629d2efeaa89af]

        NFC pdfexport dialog: cleanup impdialog.cxx
        
        No Functional Change intended
        
        Change-Id: Ie08883af2a6cf3d84f77f550e147f8aba24a152b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157432
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-09-30  Justin Luth  <jluth@mail.com>  [4cf4516bac88fb8f58743e6ae68eab0393059d7f]

        tdf#157038 sc: avoid spell-check dialog from outside selection
        
        Fixes 7.4 regression from cf18038c66075f7a18d89e47f3a2ab1a5bf7c4fd
        
        To avoid the HIGHLY LIKELY risk of losing the selection
        because of the LOW POTENTIAL of the right click
        being over a misspelling (that overflowed from outside the selection),
        simply don't even attempt to spell-check in that case.
        
        The opposite was already true (and is even worse).
        If the misspelling originates in the selected cells,
        but has overflowed into an unselected area,
        right clicking on the misspelling is deliberately ignored
        by SelectForContextMenu().
        
        Change-Id: I7dfc5b190036f1705d848cb621e527cbff37e425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157430
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-09-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f401545131119de63f38a7c4f0877405a040292c]

        Fix typo
        
        Change-Id: I178b1612466971a139817aee217a80cc19449291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157427
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cd0337df5e8d5b0ada76eff847c36146fc9704b7]

        Fix typo
        
        Change-Id: I4bfea09a6f400e49af47cd898ec2941c44430fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157426
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b6e2576798c48eba907a20728afb83fdafe51ee6]

        Fix typo
        
        Change-Id: I906deadf53e1c564c786e5b5f8184e706c4dbdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157425
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c499f5224e182b5053cd043b4678f1032ac62cbb]

        Fix typo
        
        Change-Id: I00eab84ed12c14d2d1c5bb8c4d5f532b04e6b84a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157428
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9158c3df139833064c510aff79cd7f256e9d97c3]

        Fix typo
        
        Change-Id: I8b32a9695aefbfa354631c6d8c0c28a9a03f2cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157429
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [01aa741b581c3317e5d81768b0635060b200f297]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 599b75ff934b46337634daa80282d6a101788dea
          - tdf#155876 More Tools Help page adjustments
            
            Change-Id: I615ae7a09c05e94e6faca11063bec82b086d65c6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157414
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [40a4f538b58798e027b47d99ea37f8f99b8c6b29]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 126c955770bfbf8cbc60d77068b3a8b9db6a0aa0
          - Update A11y check Help page
            
            Change-Id: Id4cb2142bc53e48287bd6202388d3a5e228b0c7d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157412
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-30  Justin Luth  <jluth@mail.com>  [ba07ae10e765cb135097dceefd94346ff43bf472]

        pdf-dialog general-tab: set_sensitive if config not read-only
        
        Disable (gray out) Export as PDF options
        that are enforced (unchangeable) in the settings,
        similar to how optsave does it for tools - options.
        
        It is possible for an config extension to set oor:finalized="true",
        which needs to prevent the user from changing the value.
        
        Noticed during the LibreOffice conference in Bucharest, RO.
        
        mxCbExportBookmarks == Export Outlines
        
        Change-Id: I27f28107d1c1dc5d46fc6e2b8a8a83933e30d6ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157408
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-30  Gabor Kelemen  <kelemeng@ubuntu.com>  [a2b389d3a94e93cbddf5f1bbb1396ccc9031cdd1]

        tdf#146619 Recheck include/oox with IWYU
        
        Change-Id: I91b63fa67ca9552a4725b9b7dcb8f7217195b3ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156988
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-30  Kohei Yoshida  <kohei@libreoffice.org>  [cba8c933d1ff2e31ec55544f46d6fff99e8a5ccd]

        Set grammar type to gnumeric before loading the content
        
        Without this, the document model side would not know what grammer
        to use to parse formula expressions.
        
        Change-Id: I7e921f9c0f9b088fb98fe126ad4a84db006c8747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157413
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [77243143dfe8c462a3e4e74a1f5a8a1e58046635]

        Simplify a bit
        
        Change-Id: I278836e7a61ac17690e5b89e38189cfdeb5f0b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157409
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d36251295b277181259eca030b995df8713d6e4d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e1fc70c20fcf102b88d5232f133150d8961cb12a
          - Housekeeping navigation of Tools menu (2)
            
            Change-Id: I4f26909c784364290fcb09d06ce3ca9bb65315a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157406
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-29  Stephan Bergmann  <sbergman@redhat.com>  [5a40abc86b94c0be5b4a252c6ab5b0b0df6e520d]

        Drop some newly obsolete __cplusplus version checks
        
        ...after 1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20".
        
        Which revealed that at least for VS 2019 16.11.30 (but not for at least VS 2022
        17.7.4), in /clr mode (e.g., when compiling
        cli_ure/source/climaker/climaker_app.cxx), the -std:c++20 is effectively
        ignored, and compilation of such source files failed with
        
        > include\rtl/string.hxx(191): error C2955: 'rtl::OStringLiteral': use of class template requires template argument list
        > include\rtl/string.hxx(88): note: see declaration of 'rtl::OStringLiteral'
        > include\rtl/string.hxx(191): error C7592: a non-type template-parameter of type 'rtl::OStringLiteral' requires at least '/std:c++20'
        > include\rtl/string.hxx(397): error C2955: 'rtl::OStringLiteral': use of class template requires template argument list
        > include\rtl/string.hxx(88): note: see declaration of 'rtl::OStringLiteral'
        
        etc.  To work around that, keep the 27d1f3ac016d77d3c907cebedca558308f366855
        "O[U]String literals (unusable for now, C++20 only)" functionality disabled when
        compiling /clr sources (i.e., where _MANAGED is defined) for that old compiler.
        
        Change-Id: If62ceef5f8e55a828b880f197111fe387e4953fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157205
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ef5cb6cdcd50942aea56ffb322bc89a4c7069bc6]

        make FunctionBasedURPConnection simpler
        
        and leave it to the client how it wants to read/provide the data
        
        Change-Id: Ibd4d967b79a699c96d1ea8529544b585a97cc0c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b409fb0eba05b6b6d78156499210aa75a9cfc14c]

        cid#1546393 SBSC: String concatenation in loop using + operator
        
        Change-Id: I697830e97b3168aab3e41e96b744ab80edbad31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157401
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1ca97423ab6980a6f6d85c2ca52e400c56baa1e1]

        cid#1545913 Big parameter passed by value
        
        Change-Id: I5fd72f80a01808f9c24dae7ab6e79391fc9603da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157400
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ace3634dacfc177a9ad92db8b2d0b596891c1814]

        cid#1546831 Dereference after null check
        
        Change-Id: I8c51dd1b312f02534f138b4fe6752ad26f5ac96c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86160b081b316532ed83cb9365714a06b1c13326]

        cid#1546834 Unchecked return value
        
        Change-Id: Id2c54c61d3d44611ab02db81b8e64cedb0010ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [348591702a84209476aedc8cc286cc90ff16558a]

        cid#1545230 Unchecked return value
        
        Change-Id: If25dcbb9784c041b61fe9aaea213035a4769962b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157397
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d282d737921e33bacb3ca81b16270702903fdbed]

        cid#1537991 Unchecked return value
        
        Change-Id: I303817f007dd0035e64d15b3f9310a06aab18060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157396
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [56c6e1d6f2e5f16ac498305470fb35d4f5e1fea1]

        cid#1546827 Unchecked return value
        
        and
        
        cid#1546828 Unchecked return value
        cid#1546830 Unchecked return value
        cid#1546833 Unchecked return value
        
        Change-Id: I9ed0246f27a3e652d31346e0543b207249f7e1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-29  Heiko Tietze  <tietze.heiko@gmail.com>  [5a9c035486a1b2d0796656e33a659718d0b21c09]

        Related tdf#155561 - Query logic inverted
        
        "Don't ask again" was working like "Show this dialog" or
        "Ask for confirmation" before
        Decided against a renaming since we use the "Do not again"
        text on other places and it is more common in this type of
        confirmation dialog than the positive (and checked) form
        
        Change-Id: I705376d11bc662b157d38bf7a89fb8db13819e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157404
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-29  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [b45ab5256c9768914bcad854ce32b06caa0539b8]

        ITEM: Correct handling of Items in sw
        
        ...that use internally an sw::BroadcastingModify*. This caused
        an error/crash with the testfile ooo58307-1.sxw, thanks to
        Caolan to find it. For BG info please see comments in
        the changed sw/source/core/attr/swatrset.cxx
        
        Change-Id: Ia91fff19ffb39873c7e2bd5ff8806b95fc5ac7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157383
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-09-29  Miklos Vajna  <vmiklos@collabora.com>  [83abd141bf41c1c8a1d4e5a894b235c842da2a07]

        Related: tdf#126449 sw floattable: fix bad position of in-table follow fly
        
        The reduced bugdoc is of 4 pages, an inner floating table should be on
        pages 2 -> 4 but was only on 2 -> 3.
        
        The reason for this seems to be that we correctly split the inner table
        twice, but the 3rd fly frame in the chain is positioned on page 3, and
        once the anchor moves to page 4, we never re-position the fly frame. The
        fly frame is normally only positioned once, since the position of the
        anchor and the fly frame depend on each other, so the loop has to be
        broken, and this is normally done by locking the position of the fly
        after one positioning.
        
        Fix the problem by extending the condition when to unlock the position
        of anchored fly frames in SwTextFrame::MakePos(): similar to not yet
        positioned fly frames, do one more cycle in case the anchor and the fly
        frame are not on the same page.
        
        This just fixes a simplified DOCX bugdoc, the full document still needs
        more fixes.
        
        Change-Id: I066c64cf4e12bf31f22218f84f0f2425256ba63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157393
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-29  Szymon Kłos  <szymon.klos@collabora.com>  [610dea096d08a2f6c31ba4bcf5419a589fd054fb]

        jsdialog: setup LOKNotifier for interaction handler errors
        
        This allows to show error dialogs on file errors like:
        "file is write protected". Without that patch it was
        crashing on assertion that LOKNotifier is not set.
        
        Change-Id: I1bc722116142c99613fa0715a49cd847896af170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157317
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-29  Miklos Vajna  <vmiklos@collabora.com>  [f3aca194d3c1b52387a53e12b3c26b9bfd86ae21]

        sw layout xml dump: move SwFont dumper next to the rest of the font code
        
        So it's more likely that it gets updated as SwFont changes.
        
        Change-Id: Ia202ba05d00a2adde7dcf8d8f2ba9e91527cc35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157384
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-29  Noel Grandin  <noelgrandin@gmail.com>  [ed774e9fb5fe33ac93699e6f1f6773f7c63deef5]

        rename SfxMedium::GetError -> GetErrorIgnoreWarning
        
        to distinguish it from the very similar GetErrorCode()
        
        Change-Id: I937e3dcfd6ce116046ac7b1c98cf79479b322f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157388
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-29  Kohei Yoshida  <kohei@libreoffice.org>  [e9a0c97de95688b2f86bbb4dd8c823af5442401c]

        Set the correct version number of orcus
        
        Ideally we should fix the Windows build properly, but cmake isn't
        available to us.
        
        Change-Id: I3f612604195212ba3a699c0b76785b5aa5f7925b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157391
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-09-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [655045d018937b1323f4d576214a50d29e15433d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5b56a1033406ebde26e98f2e9dbb843b7b93e73d
          - Housekeeping navigation of Tools menu
            
            tdf#155875
            tdf#155876
            tdf#155877
            tdf#155878
            
            Change-Id: I899bb3c5d91645381a868fb8184dba045022a118
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157392
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b519c212716a8f46331b6168aa2ef8ba2bc9254d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb0675b83b007afc59e919dea066889d19d44044
          - tdf#155878 Impress UI - Tools menu review
            
            + Refactor
            + Presentation Minimizer help page
            
            Change-Id: Ia90ed0db5352f97b2cd1e34fb87920d1cd8adfde
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157390
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3e550ac59d97dc403b3e54dd961ca7cddbc66866]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 59e38b61f4aecf25633770d24ac60fc7d3210705
          - tdf#155876 Calc UI - Tools menu review
            
            + Refactor
            
            Change-Id: I7bafaf32d0ae4561bafff7d2f42ee3256452ec66
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157389
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d82dec842818cc7099633bf1819b3ac8edbf8c96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c93d4ba6e0b516918ff22c8cdcbc9b808a491ad
          - tdf#155875 UI cmds Writer/Table in Help(47)
            
            + refactoring
            + Tools menu - Writer part.
            
            Change-Id: I46fddc444fc1912297dd8474dd30e978fd76c5e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157385
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-29  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [271491c338bd1f0faad627c8d43076e6e6d2a754]

        upgrade zlib to 1.3
        
        Change-Id: I474d1f3bc0ae804bd579d32712ed9e2fba4e89e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157378
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-09-29  Kohei Yoshida  <kohei@libreoffice.org>  [a593e018d4e3033ae95353a5ac3063a8c651a158]

        Upgrade liborcus to 0.19.0
        
        Change-Id: I57b92a86a155f244742fd70b1ab9a1acbc206a29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157345
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-09-29  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [d5afeecbffec0457b87faaff38f913fad489e08d]

        Use less libxml2 external headers dependency
        
        Change-Id: I1749628e0104dff856161bc0bdfd343ef0db208e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156784
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-28  Michael Stahl  <michael.stahl@allotropia.de>  [7cf5faec6fdbc27dd77d2d36fb2ff205322cba0d]

        tdf#156146 xmloff: ODF import: add backward compatibility hack
        
        As a follow-up to ade0a153f453500f15343380ac937252992733e0 "tdf#114287
        xmloff: ODF import: fix text:list override of list style", add some ugly
        compatibility hack to preserve the visual layout of documents produced
        by LO versions before 7.6.
        
        Override the left/first-line margin of the applied numbering rules with
        what is in the paragraph or paragraph style, and try to do this only in
        the specific situation where the list style is the same.
        
        Change-Id: I1f4520c9bf9d2257d2e3864e4ddb2d28451bbd2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157284
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-28  László Németh  <nemeth@numbertext.org>  [65efbf64cfa30ba96bc9f0ba539eb1414b861c49]

        tdf#157492 sw: fix tracked drag & drop of table row
        
        Selecting table rows by the left row border, and
        moving them via drag & drop resulted only tracked
        deletion, but not tracked insertion.
        
        See also commit 3e6125c72f8c07c14df42d45571cab44f24e9f70
        "tdf#155846 sw tracked table column: fix drag & drop".
        
        This reverts also commit 5a1c19624eda0c8b847af0dcee70b82502578ceb
        "tdf#146965 sw track changes: fix tracked table row moving".
        
        Change-Id: I7287e46188eee123b5fd36a5ec7ac5311699840b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157382
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [9b8ea553cf7f2fe5c913cb2b5e90d6d300b6be43]

        CppunitTest_sw_ooxmlexport15: replace to Noto Sans in tdf134063.docx
        
        Failed with:
        
        ooxmlexport15.cxx:895:Assertion
        Test name: testTdf134063::Load_Verify_Reload_Verify
        - Expected: 2
        - Actual  : 3
        
        Replace Verdana with Noto Sans.
        
        Change-Id: I86d393ec4751b9c8c1b504cf4ed3dc0560d362ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157381
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-28  László Németh  <nemeth@numbertext.org>  [3e6125c72f8c07c14df42d45571cab44f24e9f70]

        tdf#155846 sw tracked table column: fix drag & drop
        
        Selecting table columns by the top border, and
        moving them via drag & drop resulted only tracked
        deletion, but not tracked insertion.
        
        See also commit 912336f3c85d9a631fa0ac0f270bab04b204f619
        "tdf#154599 sw: fix crash at drag & drop table columns".
        
        Change-Id: Ib392f0700ec8c17a342df435c8bb1883967b0711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157370
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [7a4766683558999f0bc39cc4ac46dd4562fa337c]

        CppunitTest_sw_ooxmlexport16: replace to Noto Sans in tdf134951_duplicates.odt
        
        This failed on me with:
        
        Test name: testTdf134951_duplicates::TestBody
        equality assertion failed
        - Expected: 1
        - Actual  : 2
        
        Abyssinica SIL and Ubuntu Condensed used to fall back to Noto Sans, but
        for some reason it started to fall back to Noto Naskh Arabic, perhaps
        since commit 4d6533a5babd23262f27eb65fd4b5b12a5d889c0 (tdf#124591:
        Update Noto Naskh Arabic to v2.016, 2023-09-26).
        
        Use font names that we bundle to avoid the trouble.
        
        Change-Id: Id686c17c4c982a5b89232d8a8f09f47a2e06d387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157379
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [eb8c3bd992e44af4fec64aab9b707e89ca57dcb9]

        rpm packaging: don't add /usr/.build-id/* symlinks
        
        the packages are meant to be fully relocatable, having that additional
        dir makes that more tedious and the files don't add any benefit for
        packages created via epm - they're meant to support parallel installable
        debuginfo packages which are not provided by our way of packaging
        
        Change-Id: I30284942846bae2f7030884cc15b02507e84e778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155614
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [b355d65ca56e886925f0eb17d70dc5d3e0312cb2]

        CppunitTest_sw_ooxmlexport17: replace Verdana with Noto Sans in tdf146955.odt
        
        This started to hang for me.
        
        Verdana used to fall back to Noto Sans, but for some reason it started
        to fall back to Noto Naskh Arabic, perhaps since commit
        4d6533a5babd23262f27eb65fd4b5b12a5d889c0 (tdf#124591: Update Noto Naskh
        Arabic to v2.016, 2023-09-26).
        
        Use font names that we bundle to avoid the trouble.
        
        Change-Id: I3d01fb9866c626fe0e89ede5ac8ba01fd982a24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157376
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-28  Jean-Pierre Ledure  <jp@ledure.be>  [bbe4d3498c2f994342b4d213f0ae874e7b0b7775]

        ScriptForge (SF_Base) tdf#156599 Error message when loading a form
        
        Error occurs in SF_Base.IsLoaded(...)
        "Object variable not set"
        
        When user scripts run the method repeatedly from
        nearly simultaneous events, it might happen
        that the _FormDocuments private variable is
        not initialized.
        
        Simultaneous calls may be interpreted as internal
        calls. Internal calls do not execute the "Check"
        part of the published API.
        Hence the failing initialization.
        
        Solution: force the initialization of that specific
        variable at each run.
        
        Change-Id: I489cbaed7b8e57d6876b7af4b26f5be0beb3db69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157374
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-09-28  Mike Kaganski  <mike.kaganski@collabora.com>  [11aa86140eaac3d1d67db1f337fc1c76a511778f]

        Improve OleRun error reporting
        
        1. Pass its error message up the call stack as the exception's message.
        2. In case of REGDB_E_CLASSNOTREG, also obtain the object's class name
           and append it to the message.
        3. Show this information in the message displayed for OLE activation
           error.
        
        This introduces a new SetExtendedMessage method in SfxErrorContext to
        store extra information for specific errors.
        
        Change-Id: Id3863276266d992ae407fbfa5568acf5c57aa96f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157372
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [608c35665bee5990bd7e2799854e233d1454b6a4]

        tdf#105303: re-introduce single-document html export filter
        
        which was deleted in 28b6480c6bdd179f3943f768926b7f196226c768
        "tdf#105303: Drop html export wizard"
        
        With this commit, exporting to HTML from File - Export dialog
        behaves the same way as using --convert-to html:"impress_html_Export"
        from the commandline. The slides are exported as a single document
        For more information see the discussion in tdf#105303
        
        Change-Id: Ib96b3d855ae807e79f276099422903c86ea2628a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157331
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [9169202e7217d24a108d97d1af7b4ef2d2dc4ac5]

        CppunitTest_sw_ooxmlexport14: replace Verdana with Noto Sans in tdf83309.docx
        
        This failed on my with:
        
        Test name: testTdf83309::Load_Verify_Reload_Verify
        equality assertion failed
        - Expected: 2
        - Actual  : 4
        
        Verdana used to fall back to Noto Sans, but for some reason it started
        to fall back to Noto Naskh Arabic, perhaps since commit
        4d6533a5babd23262f27eb65fd4b5b12a5d889c0 (tdf#124591: Update Noto Naskh
        Arabic to v2.016, 2023-09-26).
        
        Use font names that we bundle to avoid the trouble.
        
        Change-Id: I11bfce56e85463ae20382b4659d4976360358166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157371
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cf33327fec4a8bb440d94788eff1f35678c964e6]

        cid#1545341 Dereference after null check
        
        Change-Id: I58fc2f00667f6e3c12ab5a2d37b6ce923a996817
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157355
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Khaled Hosny  <khaled@libreoffice.org>  [fb0ecd64011922bc47716f77d4225bca3a8b0858]

        starmath: Add Arabic functions to elements panel
        
        Change-Id: I9aa1bdd344dbca078aec683b5fcd93fd07d98521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157365
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-28  Khaled Hosny  <khaled@libreoffice.org>  [0eebe81f9def5f65e797281927e74ae20a4a6564]

        starmath: Add Arabic functions
        
        Change-Id: Ie7597cbde29c8b9cd53d591dc9a722e7df76048b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157361
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-28  Khaled Hosny  <khaled@libreoffice.org>  [ff28544c5310870cd98402d89ba53cfa7b7f598d]

        starmath: Arabic text should always be upright
        
        Change-Id: Ibe9f3092432ae4ffd81903df8672daf90947000c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157349
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-28  Khaled Hosny  <khaled@libreoffice.org>  [c7f20a1dad66a7d3241c103546cd268152bc778f]

        tdf#142095: Render symbols in Math Symbols Catalogue using document settings
        
        Use the document format to resolve the font and style of the symbol.
        This makes the symbols use the current document font, as well as apply
        settings like GreekCharStyle.
        
        Change-Id: I668e582704b7e011e032f8b9e1dfb509e0d00d3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157348
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-28  Khaled Hosny  <khaled@libreoffice.org>  [d68cb3beddcf26e0b19101f18bd77a56c53d2009]

        starmath: Arabic symbols from Symbols Catalogue should not be italic
        
        Arabic math symbols are not set in italic, so we need to unset the
        italic style if set.
        
        Change-Id: Id6db51a944236722a9724ad0d128ff6435a6bac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157346
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a3bd64c4a1fceb20fe5d72da142a46a72b8ae5dc]

        cid#1545264 COPY_INSTEAD_OF_MOVE
        
        Change-Id: If46030df202c9c569835bae0713bc2fb681b623d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157366
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c5d512203e1a63a9686f7b648a6e4ae9354ba314]

        cid#1546008 silence Using invalid iterator
        
        Change-Id: I76043da245d47d10993361235425f48b7f6d4034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [77d1affc868b137db0ba2c5db431fa99e6d1ad51]

        cid#1545248 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I67cb6bbebeecb595f68b0a70c7416e6aaa56399f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157358
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e7b1f30159a25848a4ffa3ad6df024556d372bb5]

        cid#1545247 COPY_INSTEAD_OF_MOVE
        
        Change-Id: I921d2971c76b9a1d4b1fde7531ad0e96f5f3428e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157357
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [984dfa1f478db52c2adf8e77a15687b6fecc176b]

        cid#1545233 sidestep COPY_INSTEAD_OF_MOVE
        
        Change-Id: I93b8225b7ae2fdb4ea5fc371ce278f00d3dec33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157356
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3a871a0a2c5d6d5d3fd4091072903a389c27b277]

        Update git submodules
        
        * Update translations from branch 'master'
          to 98c203d02754d23b7de420745152377ca0f0b55f
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I20e94552ba33d500d4c949a919dd3f1648d70715
            
2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1150a34f0f4ba3d7ce8022c0ff9b1e486deeca9b]

        cid#1500628 Dereference after null check
        
        Change-Id: I6dc6c3fdf1924e0cd012dab1ece0adbb0c405335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157354
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a4716c316689de359eba1eb2a9f99e169c48cf59]

        cid#1546174 Unused value
        
        Change-Id: I79caaeccb044eef0caecb931e1e8289e3904b806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157353
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [337796cdab209f4dd0768bb61134a37f8f713371]

        cid#1546404 Explicit null dereferenced
        
        Change-Id: I5c868219125387d8f0e5ebd25799be94cfab7188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157352
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f68a27f3592d7f419dfdea24bd35a97910662676]

        cid#1545733 Logically dead code
        
        detectable since:
        
        commit cbaa4d3f27aa458142b0eeca88053d7fac3cce4d
        Date:   Thu Sep 14 15:17:25 2023 +0200
        
            remove some unnecessary casting in SwXText::createTextCursor
        
        Change-Id: Ib1d9dd53331e4c026cd4bc34b19db9d12e642f65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157351
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7dc918b905dfeffec05868243f0eaee4ccff7a8d]

        cid#1546363 Unused value
        
        Change-Id: I416db8a528b4db3f4d4449ec371c0935b29568ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157350
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9dd0af943df70d7797196ee8f9717596f28b1849]

        cool#7307 short-circuit pdf parsing during detect if no 'AdditionalStreams'
        
        looks to me that we ignore the contents of the AdditionalStream and
        re-parse to get it in the final importer, in which case we could
        presumably parse the mimetype in AdditionalStream here and drop the
        extraction of the stream.
        
        Change-Id: I28e42c2b2fe8d4e10591e523260b08a0d0f7ca28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [25b8fdd3b939a221ba00ca37fbf89adaf893aab7]

        sw floattable: maintain the invariant that fly height is at least MINFLY
        
        Fixes these warnings on loading sw/qa/core/layout/data/floattable-in-inlinetable.docx:
        
        warn:legacy.osl:6908:6908:sw/source/core/layout/flylay.cxx:703: <SwFlyFreeFrame::CheckClip(..)> - fly frame has negative height now.
        warn:legacy.osl:6908:6908:sw/source/core/layout/flylay.cxx:295: SwFlyFreeFrame::Format(), flipping Fly.
        
        Change-Id: I20d01e3289ea597a5b5f4ee43a5e1b892a618648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157347
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-28  László Németh  <nemeth@numbertext.org>  [5d490133efe7a2509515ac6d85ed3db0a7988b3c]

        tdf#156900 sw tracked table column: fix row deletion
        
        If the last deleted table column was hidden, it was
        not possible to delete the table rows.
        
        Regression from commit aff269c18b9029fec992135a406dc5031927c401
        "tdf#155345 sw tracked table column: hide them in Hide Changes mode".
        
        Change-Id: I51b78f6f5552bdba2240bf278ac1d796830a1beb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157330
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-28  Miklos Vajna  <vmiklos@collabora.com>  [2be27d23b9a4adbb491c48a0abeaa8ed7482e530]

        UITest_impress_demo: use oneprocess mode
        
        Before: 0m54,459s
        
        After: 0m41,705s
        
        Change-Id: Ie4cccff79b0df3bd4f01c10414c61ca46cade5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157338
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f8e591ab9182e0a61c4ae5b8f77b166fcaeaa877]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 192bfeba34fca4548b6bfd45951a3d84738f9df4
          - tdf#155875 UI cmds Writer/Table in Help(46)
            
            + refactoring
            + Form menu (final tweak)
            
            Change-Id: I3d328130aedb156ca740f9d893ca08054a0d9e68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157344
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fcf3ed3af78cdaefc0caad8b814617d524ac9ef1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to edbc7c699673f0ded9c121d50f5909cea3bb3c6f
          - tdf#155875 UI cmds Writer/Table in Help(45)
            
            + refactoring
            + Form menu (remaining)
            
            Change-Id: I2c1570dd1672dae30f07705e8cf12923b0e914a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157343
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9d63f4372e82959e658c43dd32083a6797b9e9a5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e35929abf073e865fa62cf50dc211b79f34c0a5f
          - tdf#155875 UI cmds Writer/Table in Help(44)
            
            + refactoring
            + Form menu
              + Design mode
              + wizard
            
            Change-Id: I71fbc4071c39cd4a635294eae1bf3e74d750c2e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157341
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7753525d5692eb39d24c7eb342fe26e878f8122d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06c14b098142b850d088ecbcf7a57fbd68770154
          - tdf#155875 UI cmds Writer/Table in Help(43)
            
            + refactoring
            + Table - Properties (fixes, remove ambiguous target)
            
            Change-Id: I2f4fda400c88bb9d6cc75aa9981617c2dedfbb7e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157340
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-27  Patrick Luby  <plubius@neooffice.org>  [d43e2a9214c0d06465a3027231948760e65ad4ee]

        Let SkBitmap determine when it is safe to delete the pixel buffer
        
        Also, make bitmap immutable to avoid making a copy in bitmap.asImage()
        and, just to be safe, flush the canvas after drawing the pixel buffer.
        
        Change-Id: I3ac99cf4acf0bf4c8b274dc73295ca7b9f386c70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157333
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [8eb53f735eba218b6911e7aa5a805972dfb54809]

        reduce allocation when cloning SwAttrSet
        
        Change-Id: Ic37355cd2a6091576426c48ff694023e24ae6342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157334
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-27  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [4fd753d4230e719aba1d621fbcd5fddbbc3253bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1aa4440126530425550bf6e37930861413b99cd
          - tdf#154019: change string and description in help too
            
            Change-Id: If910f502d885812a8925847aa3d18e79b92b6f66
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157314
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-09-27  Heiko Tietze  <tietze.heiko@gmail.com>  [a52bc9b5d6f86b6919931db21d83834d6c14e955]

        Resolves tdf#155561 - Notification for the overwrite mode
        
        Dialog shown when it's enabled for the first time
        Introduces the registry variable QuerySetInsMode
        Adds an eye-catching image under res/queryinsmode.png
        
        Change-Id: I0131177fb54238d48a671bc9ceb88283f796a526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153505
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [47c4d0fbdc681287f2fd9f5240ca1ce7a960ec18]

        vcl: remove rTargetDevice from OutputDevice::ImplGetEllipsisString()
        
        Change-Id: I886510af06bbfb77e24ea004cc3abfd6ff3a8832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157194
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b6ab16fb783d041bfe3f80b1bc943716d441aa3]

        no need to copy the itemset in SID_ATTR_PAGE_BITMAP
        
        Change-Id: I659f8a3d691143dfc237d5ab3baa9e9f6906567a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-27  Michael Weghorn  <m.weghorn@posteo.de>  [1215e1bcb149791ce293c0bcb235fcd9548136c7]

        gtk4 a11y: Map paragraph role to Gtk equivalent
        
        Map `css::accessibility::AccessibleRole::PARAGRAPH`
        to the new `GTK_ACCESSIBLE_ROLE_PARAGRAPH` role newly
        added to Gtk in commit [1]
        
            commit 9f078bd5c975f33d832b6da71cba2923450d3127
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Sep 25 10:41:42 2023 +0200
        
                a11y: Add paragraph role
        
                Add new GTK_ACCESSIBLE_ROLE_PARAGRAPH role
                for paragraphs.
        
                ARIA has a paragraph role as well.
        
                The paragraph role is used e.g. in document editors
                like LibreOffice or web browsers like Firefox.
        
                According to the ARIA spec [1], naming paragraphs
                is forbidden (§ 5.2.8.6), and the superclass role
                is section.
        
                This role will be more useful once a way to expose
                the textual data via the AT-SPI Text interface is
                also available (s. issue #5912 [2]).
        
                [1] https://www.w3.org/TR/wai-aria-1.2/
                [2] https://gitlab.gnome.org/GNOME/gtk/-/issues/5912
        
        With this in place, a Writer paragraph reports the
        proper role to AT-SPI.
        
        There's however currently no way to expose the
        paragraph text via the AT-SPI Text interface since
        Gtk 4 currently lacks the required API for that (s. [2]).
        
        Without this change in place, the paragraph text was
        exposed as the accessible name of the a11y object
        (see the "for now set GTK_ACCESSIBLE_PROPERTY_LABEL
        as a proof of concept" comment in
        `lo_accessible_get_property`), but since ARIA does not
        allow naming paragraphs and Gtk 4 follows ARIA, this
        is no longer the case with the new mapping in place.
        
        But then, I don't see how to have proper a11y
        without supporting the Text interface, so that
        will be needed at some point anyway.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/9f078bd5c975f33d832b6da71cba2923450d3127
        [2] https://gitlab.gnome.org/GNOME/gtk/-/issues/5912
        
        Change-Id: I44315754a6376ecc06bee01d16eedb8a769c3d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157241
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2ab40af9efd19d386a486a934986731b7a80d6d]

        pass SwAttrSet around explicitly
        
        instead of using SfxItemSet and static_cast'ing it everywhere
        
        Change-Id: I12d1a6bd2dec7035fa16206ea01346a3a73c1457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5484007fceb8099f771a544472ba66f49631fe4f]

        java_websocket needs ant
        
        Change-Id: Ic1a27055b2e63e4df44d5856d8c65b0b15958470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-27  Mike Kaganski  <mike.kaganski@collabora.com>  [3ae9860b9c4c9cbf4b5b7c47617303f29042783d]

        OUString -> OUStringLiteral
        
        Change-Id: I80b6c736960badf1a6e3af89740a80f46a651f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157305
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8705b4ccaa7b8ea28eda95307c9add2b23e0716b]

        perf: NumFmtUtil::isLatinScript doesn't need to copy OUString
        
        the original const OUString& from LocaleDataWrapper::getNumDecimalSep is
        sufficient
        
        aDecSep OUString dtor appeared as 2% of a sampled session
        
        Change-Id: Ib9408b32443eb6ba66a9dfc32a9179941c67bdf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157298
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-27  Miklos Vajna  <vmiklos@collabora.com>  [c86d6111525f09e895483c7c4919a4b9a5dbd9b9]

        Related: tdf#126449 sw floattable: fix bad join of inline tbl with inner fly
        
        The problem is that the bugdoc has 3 pages with an inline outer table,
        where pages 2 & 3 have an inner floating table. The outer table is only
        on pages 1 -> 2, while it should be on pages 1 -> 2 -> 3.
        
        The trouble is similar to point 4) of commit
        cfe9c68a7a19dd77d1fcbde3a7dd75730634becc (tdf#157119 sw floattable: fix
        moving master of split fly to next page, 2023-09-21), i.e. our normal
        behavior would move up the follow table to page 2 from page 3 and simply
        shift up the floating table, which is fine for images, but not for
        floating tables.
        
        Fix the problem by checking for flys on the old page when determining if
        it's OK to move or not. Checking for flys on the new page is already
        done in SwTabFrame::ShouldBwdMoved(), when it calls the precede's
        CalcFlyOffsets().
        
        This just fixes a simplified DOCX bugdoc (inline outer table, floating
        inner table), the full document still needs more fixes.
        
        Change-Id: I7946c0f3cb9995a497fdfff3bfac28b6f16ff844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157306
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-27  Miklos Vajna  <vmiklos@collabora.com>  [4094e07ea738b47a99e30cbf70cdf943a5088355]

        CppunitTest_sw_ooxmlimport: fix comment in testFdo87488
        
        I forgot to do this in commit 566370dc3754ed3f858f1617e776ec0bc3399499
        (sw: rework to avoid the DECLARE_OOXMLIMPORT_TEST macro, 2021-06-01).
        
        Change-Id: I0ec080d4921a400422771188df9060a35b13feda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157295
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-27  László Németh  <nemeth@numbertext.org>  [dc748d7dbd114fbf663752258dbaf003af2926c3]

        tdf#141198 sw: fix cycle case with change tracking
        
        Fix cycle case with change tracking by rejecting
        changes of the word, and setting the cursor inside
        the original word.
        
        Previously the cycle case resulted only in a tracked
        deletion and tracked insertion, putting the text
        cursor at after the word, so it was not possible to
        cycle on the different cases e.g. by pressing Shift-F3
        multiple times (and moving the text cursor inside
        the tracked insertion didn't help, because resulted
        in broken text at asking for the next cycle).
        
        A regression from commit 2d3c77e9b10f20091ef338e262ba7756eb280ce9
        "tdf#109266 sw change tracking: track transliteration".
        
        Change-Id: I819cf0ec722d54852bfc31f7765e0f06e2a07fd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157303
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-27  Jim Raykowski  <raykowj@gmail.com>  [a0955317900075371d6adb7f924af24c22f02d09]

        tdf#139935 Part B: Show all menu items possible/potential actions,
        
        but grey-out and deactivate, when not applicable
        
        This patch makes VCL PopupMenu respect the
        officecfg::Office::Common::View::Menu::DontHideDisabledEntry setting.
        
        Change-Id: I4df0de82585b602e12481ae46bc4f94c2588970d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156979
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-27  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c2930ebff82c4f7ffe8377ab82627131f8544226]

        curl: upgrade to release 8.3.0
        
        Fixes CVE-2023-38039
        
        * NSS support was removed in this release, so NSS related patches are not necessary now.
        * add configure options for curl.
        
        Change-Id: I71e09bac3c69ce4b13deee770a32225f39f79c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156917
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-09-27  Laurent Balland  <laurent.balland@mailo.fr>  [c76678bbe9c3f835e0fd3dc2ec2381ec821dd548]

        tdf#155390 Impress template Growing Liberty update
        
        Remove last page
        Remove styles only used by this page
        Update manifest.xml to get conformant ODF 1.3 extended
        
        Change-Id: I6a4227498909b8dc1fb546d2c9c82b30f55ca204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153295
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-27  Adam Eric Fallon  <adam.eric.fallon@gmail.com>  [3f20d1dad1b84367f8ec322690dae20b0defbb08]

        tdf#146609 Renamed line width to thickness.
        
        Change-Id: Ib1977bef8cf0f5cba91c37fd80871f1d64bb49fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157104
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [2902ab24ecc5ffbf4907ea83b2028508b9de6364]

        tdf#124591: Rename *noto.mk to *noto_kufi_arabic.mk
        
        Since it is the only one left in this package. Still using the old
        tarball, though, since there does not exist any releases upstream (yet):
        https://github.com/notofonts/arabic
        
        Change-Id: I9a21fda5519bbf184af9b2e70b8cf65e3046a724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157283
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [739ee655294be56021dc6244dde3faa75e288bd5]

        tdf#124591: Remove Noto Mono
        
        It no longer exists upstream, probably renamed to Noto Sans Mono, so if
        it is going to be a new font we are better off dropping it entirely.
        
        Change-Id: I8d727c2419a6081b37802324ff115611bce3c9dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157282
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [4d6533a5babd23262f27eb65fd4b5b12a5d889c0]

        tdf#124591: Update Noto Naskh Arabic to v2.016
        
        from:
          https://github.com/notofonts/arabic/releases/tag/NotoNaskhArabic-v2.016
        
        Change-Id: Ic5d23046afddb8d7230ed3f71363cb178f572124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157271
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [00db8423d18d75f982b337744ec39c4b7269a433]

        tdf#124591: Update Noto Sans Lisu to v2.102
        
        from:
          https://github.com/notofonts/lisu/releases/tag/NotoSansLisu-v2.102
        
        Change-Id: I205cf05d6f33e1083e30193d7ed775d9775af2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157280
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [114b94f7e04daf699dad44857c1a86932f466c46]

        tdf#124591: Update Noto Serif Lao to v2.003
        
        from:
          https://github.com/notofonts/lao/releases/tag/NotoSerifLao-v2.003
        
        Change-Id: I58b69f3219a7afa7a60a17167cc9d4c4f1d8397b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157279
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [c4609a0721b466a805514197cd6872e0dfb07aa6]

        tdf#124591: Update Noto Sans Lao to v2.003
        
        from:
          https://github.com/notofonts/lao/releases/tag/NotoSansLao-v2.003
        
        Change-Id: I5a857c4f335cf29473b9baeffffddcc6d810e0b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157278
        Tested-by: خالد حسني <khaled@libreoffice.org>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [0d49ac1ba30e2cb6247a77e75383176a4624adfd]

        tdf#124591: Update Noto Serif Georgian to v2.003
        
        from:
           https://github.com/notofonts/georgian/releases/tag/NotoSerifGeorgian-v2.003
        
        Change-Id: I230b8eed49f024e2361e27df963424d7113e52fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157277
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [529ddd57c673f49a334b0813f979e7c88db2f46b]

        tdf#124591: Update Noto Sans Georgian to v2.003
        
        from:
          https://github.com/notofonts/georgian/releases/tag/NotoSansGeorgian-v2.003
        
        Change-Id: I007a55194fe77d07c05c704a69c36e489ca5db46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157276
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [15f234bab54c990f3d5362b89afc097f82718e9b]

        tdf#124591: Update Noto Serif Armenian to v2.008
        
        from:
           https://github.com/notofonts/armenian/releases/tag/NotoSerifArmenian-v2.008
        
        Change-Id: If956e731eaa484b9d48c95cab707d77d39aaeeff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157275
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [d69317ca8f4b39c7fe62e9404f93d5d43e5495d6]

        tdf#124591: Update Noto Sans Armenian to v2.008
        
        from:
           https://github.com/notofonts/armenian/releases/tag/NotoSansArmenian-v2.008
        
        Change-Id: I92bd6f05e9022b6c1f25ac460e64b12209016297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157274
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [7376eed0f00ab7d3217f484a707aaf5ef4bc801e]

        tdf#124591: Update Noto Serif Hebrew to v2.003
        
        from:
          https://github.com/notofonts/hebrew/releases/tag/NotoSerifHebrew-v2.003
        
        Change-Id: Ibffe8d4b629ecd61c2644f4811fda68fa28d9a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157273
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [448d5d7fbfc3d545cb9f8e5e89514784b03e4cd1]

        tdf#124591: Update Noto Sans Hebrew to v2.003
        
        from:
          https://github.com/notofonts/hebrew/releases/tag/NotoSansHebrew-v2.003
        
        Change-Id: I710c49a9dc4f7f1c7460a777e3e224aaea332009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157272
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [9998c242c6c2ece5f240db2f6ffdf04e7ca7cbb4]

        tdf#124591: Update Noto Sans Arabic to v2.010
        
        from:
          https://github.com/notofonts/arabic/releases/tag/NotoSansArabic-v2.010
        
        Change-Id: Icb4a2932c84884180eed7f391ecd7285311299b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157270
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee9b13668cf955d2f3ad927f26bf3e1910779047]

        tdf#97710: do not create nonzero conform for polyline
        
        Change-Id: Ib9d4e957b83ad84b79ae4ade5c6be3ab3d9d8028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157286
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [96aba2de78ffa641f6c0c898b99158715b2f2703]

        tdf#124591: Update Noto Serif to v2.012
        
        from:
          https://github.com/notofonts/latin-greek-cyrillic/releases/tag/NotoSerif-v2.012
        
        Change-Id: I769f162c3fb7256fd6aba4e666cb91fbc3b12131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157269
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Khaled Hosny  <khaled@libreoffice.org>  [69943f33bf219558d6b219f0eaeda1e25e487b05]

        tdf#124591: Update Noto Sans to v2.012
        
        from:
          https://github.com/notofonts/latin-greek-cyrillic/releases/tag/NotoSans-v2.012
        
        Change-Id: Icdd604614a97071c0ff703eb9fe2468137826489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157268
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [defc3dd75ff8ff937d2161237b281284240b86f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3f86b2bea5e047e1f4d88dc66f4c42fb433eed9
          - Mute L10n
            
            Change-Id: Ic74894ba6b6d5dfc0e3e64075d293f0bd2478836
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157226
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-26  Gabor Kelemen  <kelemeng@ubuntu.com>  [2b153ad42904e433d41b630fc80daf4a57112681]

        tdf#146619 Recheck include/o3tl with IWYU
        
        Change-Id: I25833a776b4b7f2055805159583f363b860bc4cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156987
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [e0021031f6cb0c52892142d5753b222d571acf49]

        tdf#85263 Resolve accelerator collision in Options - User Data page
        
        Set explicit accelerators for labels missing them, to not rely on
        automatic assignment
        
        Change-Id: I97356b06136a1688cfaa96c94f11564c5ce0d7a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157257
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [8d7a27a3e4b71e6be44e7fc07f370e18bf475b4c]

        Resave in newer Glade version
        
        Change-Id: Ib531c114e0167f48f5e9e1ee3ab61a99a161519c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157256
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-26  Gabor Kelemen  <kelemeng@ubuntu.com>  [e53a99c4bbf09763ecfb05a0926e7957b31c1fff]

        tdf#105303 (related) Drop unused translation strings
        
        Obsoleted by
        commit 28b6480c6bdd179f3943f768926b7f196226c768
        commit c5cff66335ca162b52270059e57214c4065caf66
        
        found with simple script:
        for i in $( grep "^\#define" sd/inc/strings.hrc | cut -d " " -f 2 ) ; do if [ $(gg -l "$i" sd | wc -l ) -eq 1 ] ; then echo "$i: appears once" ; fi; done
        
        Change-Id: I1f07ebc275b8ee9a165c5e1f5ad1d1e68f9eaa81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157239
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b7c732215f2dc34d1f0cfc08ea912a3925b13b0]

        Resolves: tdf#151919 mark blanked fields as requiring a reformat
        
        the next time a format is requested, even if the value of the
        Formatter is the same, otherwise if the value is the same it
        will remain blank.
        
        Change-Id: Iec77e6d9f792b51a83a9e289cbdb197605ab1a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [c2d6ae1781ad4be5f9acefecce7e1504df02cf8f]

        tdf#157299 sc a11y: Limit amount of reported cell relations
        
        For the cells referenced in formulae, the a11y `CONTROLLED_BY`
        relation is reported.
        
        Since formulae can reference a large amount of cells, creating
        the a11y objects for each of these cells can result in Calc freezing,
        e.g. for the tdf#157299 `SUMIF` example that was referencing a whole
        column (containing 1048576 cells).
        
        Prevent that by limiting the maximimum amount of cells to handle
        here to 1000, and just printing a warning to the log otherwise
        and ignore cell ranges having more cells.
        
        If there's a need to increase the limit, that should be possible
        within certain bounds. My test with a modified SUMIF that just
        uses 999 cells wasn't causing any noticeable delay and the
        relations were shown in Accerciser as expected.
        
        From a quick look at the Orca and NVDA source code,
        they currently don't seem to make use of the
        `CONTROLLED_BY` relation for LibreOffice at all.
        
        Change-Id: Ia74e0e88d9dbd7650832664b9c027262367b428e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157265
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d724b51c7da391c9afe5e47476d432aecf1c4c67]

        tdf#157448: ignore FILE_ATTRIBUTE_READONLY when FILE_ATTRIBUTE_DIRECTORY is set
        
        Change-Id: I3fbcf15924b30e2c7fe5501e706cdaf32921e103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157263
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a691337aaa79e03f12b87f9fc2ce85857d9fb621]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a83574c073321df45582cce99d7b811774438723
          - tdf#157006 update label change for "Expand word space..."
            
            Change-Id: I0b552f127d86846180783a9013f73c9c0dbd6130
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157223
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0d375d059f52348d53858ff80e6a4d5372c7d71a]

        tdf#157006 shorten "Expand word space..." label
        
        Change-Id: Iaaf6beff5e6c7845c2cb06b2f35ac080fed9d5e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157118
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-09-26  Aron Budea  <aron.budea@collabora.com>  [5b52a7c3154f5263db82f19f7cc7d0e7b32da603]

        tdf#152675 treat all cairo versions <= 1.17.8 the same (actually)
        
        Use correct condition.
        
        Follow-up to 1dd357ccf7ca9edbe5f2ef60465c2559f678d306.
        
        Change-Id: Icc2d04c0023b0a6595ece89d389919f3821aacbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c3e654ad373407b774ab80c39b15f56b33bfafa6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0c24f409c31e4ca8a85b6a1486e2c6eaf26942d6
          - tdf#157360 Local help should not phone home
            
            + Remove call to matomo TDF server instance when help is local
            + Keep when Help is online.
            + refactor javascript
            
            Change-Id: I285b426531c91ff558c01798f803bf3f89720b1f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157255
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-26  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [da38a44b2839480cc333c18f312979d61324d6b9]

        WASM: Embind: get rid of redundant EMSCRIPTEN conditional
        
        As suggested by Stephan Bergmann in
        https://gerrit.libreoffice.org/c/core/+/156273/comments/4087f8b8_8ab9a1bc
        
        It appears whole thing was redundant since the template specialization of
        emscripten::internal::raw_destructor in
        codemaker/source/cppumaker/cpputype.cxx:1228.
        
        Likely this bit causes memory leaks when the API is used and it is a
        temporary workaround.
        
        Change-Id: Ifb015754f16ddff1065b3285268acf8a339f975b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157234
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-26  Gabor Kelemen  <kelemeng@gnome.hu>  [46fe54c147b540ef8447fcfca7fe0f3723e77f53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 491f223b3e7a1b272d3050fbaa84be897ef45c2d
          - tdf#105303 (related) Drop HTML Export wizard help pages
            
            Change-Id: I5d7714356f56f88d9c595b420b724ea8c6564f5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157254
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-26  Bogdan B  <buzea.bogdan@libreoffice.org>  [483b8d065f9a5359c7543ff104bbf3365d91b968]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5b7fc24e7978b3096c91d0e0e23aebbe17cebe7d
          - tdf#148904 Improve Help for vertical positioning
            
            Change-Id: Idf68a186201fd88853fb1f895532c15a9722ec21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150091
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-26  Miklos Vajna  <vmiklos@collabora.com>  [d5a43da338e4afe3630a072351516e39865a1f2f]

        tdf#148959 cui: fix hiding semi-transparent UI for chart axis font
        
        Regression from commit b4554b8eddd048532269df610e89ae739c46fab7 (cui:
        add UI for semi-transparent shape text, 2019-11-22), the trouble was
        that even if semi-transparent text UI is meant to be opt in, we enabled
        it by accident also for charts.
        
        This happens because I assumed that we always get a SID_FLAG_TYPE, and
        then we can hide the not wanted UI in case SVX_ENABLE_CHAR_TRANSPARENCY
        is not in the flags, but even SID_FLAG_TYPE can be missing.
        
        Fix the problem by assuming that in case SID_FLAG_TYPE is not provided,
        that means no flags.
        
        An alternative would be to actually add support for semi-transparent
        text in chart2/, which is doable, but
        chart::wrapper::ItemConverter::ApplyItemSet() assumes that each pool
        item can be mapped to exactly one UNO property, which is not the case
        for SvxColorItem (it would have to map to CharColor and
        CharTransparence), so don't do that yet.
        
        Change-Id: I825ca56b2e03d48c8acff93e1deadf8f86b0dcb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157258
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-26  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [3575abbab1994aa1e0ccd8774a7d7fafb22d79e0]

        Resolves tdf#154019 - Better label in Area dialog more informative
        
        Change-Id: Iaa20a88f42e056c6fa005df9854ae0b83d6ce662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157184
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-26  Jim Raykowski  <raykowj@gmail.com>  [5e9c8d21874eea8cb5adf2ecab1905295af2308f]

        tdf#152029 Fix sections not brought to attention in master document
        
        SwSectionFormats::FindFormatByName doesn't seem to find section formats
        by name for sections of a document contained in a master document. This
        causes the document sections to not be brought to attention by hovering
        the mouse over the section entry in the Navigator. This patch makes the
        document sections be brought to attention by using an approach similiar
        to what is done to fill the sections entries in the Navigator content
        tree.
        
        Change-Id: I10e265d23a311440ac91d44b3185f807b205edb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157231
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f75bfd0f6b1bf4debb69e96c114e453c62685f8]

        Don't enable the requires clause for Clang 15
        
        similar to 5831d5f03a5ea5b89984574ffe436f38500726da
            Don't enable the requires clause for some Xcode Clang
        
        Step #3 - "compile-honggfuzz-address-x86_64": checking whether Clang is new enough... yes (15.0.0)
        
        In file included from libreoffice/core-clang/animations/source/animcore/animcore.cxx:20:
        In file included from libreoffice/core-clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:
        libreoffice/core-clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65: error: invalid application of 'sizeof' to an incomplete type 'animcore::(anonymous namespace)::AnimationNode'
        template<typename T> inline constexpr auto isUnoInterfaceType = sizeof (T) && IsUnoInterfaceType<T>::value;
                                                                        ^~~~~~~~~~
        libreoffice/core-clang/include/unotools/weakref.hxx:119:33: note: in instantiation of variable template specialization 'cppu::detail::isUnoInterfaceType' requested here
                requires(!cppu::detail::isUnoInterfaceType<interface_type>)
                                        ^
        libreoffice/core-clang/animations/source/animcore/animcore.cxx:309:44: note: in instantiation of template class 'unotools::WeakReference<animcore::(anonymous namespace)::AnimationNode>' requested here
            unotools::WeakReference<AnimationNode> mxParent;
                                                   ^
        libreoffice/core-clang/animations/source/animcore/animcore.cxx:121:7: note: definition of 'animcore::(anonymous namespace)::AnimationNode' is not complete until the closing '}'
        class AnimationNode final:  public AnimationNodeBase
              ^
        
        Change-Id: I4feb54d5739464d356e2769eeb368c368cc29104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157250
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c90de36ede6d35e2cf1ebea195e0ff28f618f319]

        change bool header or footer parameter to use enum type instead
        
        Is much more readable.
        
        Change-Id: Ie81aaf344758182915796b18efbe25d3f45df4b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157236
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [33c347fb3b0fbbae9c1005b1ca7a6105284a6d31]

        oox: remove returning sRelId and rename WriteImage
        
        Rename WriteImage -> writeGraphicToStorage to make it more clear
        what the method does.
        
        Remove returning the rel ID string in some methods that write the
        graphic into the stream (or the call chain), as it is never used
        later on, so it is better to not return it if it is not used (it
        could be abused).
        
        Change-Id: I78558671b82aedb34bd0f37bf7781c47ebf1cf5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157235
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-25  Michael Stahl  <michael.stahl@allotropia.de>  [3d31dfa9b99d0df5e400c1a6d7e8df6c46129b3c]

        poppler: upgrade to release 23.09.0
        
        Fixes CVE-2023-34872
        
        Change-Id: I289b3016695a01aff7d393cb09d66cd726d9b592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157247
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-25  Michael Stahl  <michael.stahl@allotropia.de>  [3daab618c759be2b93ad337061ef347c76229a22]

        libtommath: upgrade to release 1.2.1
        
        Fixes CVE-2023-36328.
        
        Change-Id: I1193f5df789c7dd10855e35936fc2697697c464e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157246
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cc564cea7eda29ed7e98ea27056f3ab57a6e2027]

        ofz#62688 Null-dereference READ in SwRubyPortion::SwRubyPortion
        
        seen with fodt2pdf fuzzer
        
        Change-Id: If761f5ecc473f4c936db82f3fcb7dd891e82573f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [788ef4f347d8a3c87d45d38ce6bf13cdd3dd76a2]

        ofz#62439 Integer-overflow on scale using SAL_MIN_INT32
        
        Change-Id: Ib26feee174caab9f515cd88cc3cb4a83debb0d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [71cae3a219ff1629368b8f324d0de89afc9445e9]

        tdf#155698 - Start Center: Retain pinned items when clearing the list
        
        Change-Id: Ife54845e020977cdb80a7fcc1fa63333afc17b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157169
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-09-25  apurvapriyadarshi  <apriyadarshi.1995@gmail.com>  [31ca96ff3075343c8d0c334fc77a9d0969986d77]

        tdf#146150 Use dispatch cmd for the corresponding SID
        
        Change-Id: I0d987a8b10f2c69192d080b534a1d6aa71a6cf4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157105
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-25  Miklos Vajna  <vmiklos@collabora.com>  [fca39498dfc29a1c026ff854ca797ea39161124b]

        sw: fix crash in SwTextShell::ExecField()
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 128 for address: 0x0
        
        program/libswlo.so
                SwTextShell::ExecField(SfxRequest&)
                        sw/source/uibase/shells/textfld.cxx:456
        program/libmergedlo.so
                SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
                        sfx2/source/control/dispatch.cxx:257
        program/libmergedlo.so
                SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short)
                        sfx2/source/control/dispatch.cxx:814
        program/libmergedlo.so
                SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&)
                        sfx2/source/control/unoctitm.cxx:682
        
        Change-Id: I359f9ee643daff9acfb67800e38666cce060c0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157171
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 1dc16c277107f8f67b52c1b3eaef21e0f2d20fde)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157213
        Tested-by: Jenkins

2023-09-25  Bayram Çiçek  <bayramcicek2125@gmail.com>  [0eb05b47a6d89fdfc533515483584fc739962b65]

        tdf#49895: search in Options: check if label exists (related to tdf#157266)
        
        - since ids in ui files can be changed or removed,
        we have to check if they are exits or not, to prevent
        any crash or misbehavior.
        - Proper solution will be iterating over the
        widget ids and collecting their strings without
        based on a list of identifiers.
        
        Change-Id: I2088af6842ad0acd00838a37295dc2e6140096f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157103
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-09-25  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [a499a3f2486b44c8b1918e69490f9d26bdb0e1f5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f90597efbc302b0cbf46acd07cfbe22cc445a28
          - link to relevant Index section rather than whole guide
            
            Change-Id: I49eb397264a8ba72a58a16b5fbf8a03b22086f8e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156952
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-25  Miklos Vajna  <vmiklos@collabora.com>  [b8521d969ab5be4fc947e467d4afe969f9d3b563]

        tdf#157263 sw floattable: prefer join over split after moving fwd
        
        Regression from commit a4af5432753408c4eea8a8d56c2f48202160c5fe
        (tdf#120262 sw floattable, legacy: fix text wrap around fly when no
        content fits, 2023-07-17), the bugdoc was of 3 pages in both Word and
        Writer, but is now of 4 pages in Writer.
        
        The above commit fixed the layout, so the first row of the table around
        the page 1 -> page 2 boundary goes to the start of page 2 instead of to
        the end of page 1. This matches the Word layout, so a wanted change on
        its own, but it regressed the page acount. The reason for this is that
        the table has a single row on page 2 and its follow on page 3 is not
        joined, even if there would be still space on page 2. A reduced bugdoc
        appears to reproduce this problem even without floating tables, also
        with old versions, so it's not a new problem, but it's now more visible.
        
        Fix the problem by tweaking what to do in the next iteration in the loop
        of SwTabFrame::MakeAll() after moving forward. Moving forward is
        followed by a next iteration in that function, but it does both a
        MakePos() and a Format(), so it'll be the last iteration in the "is the
        postion / size of this tab frame valid" loop. We used to hit the "bSplit
        == true" case, there we found that there is enough remaining space, so
        no need to split and we quit the loop. This is now changed, so in case
        we moved the table forward and there is still enough space for the
        follow to be next to us, then the last iteration will try to join
        instead of trying to split.
        
        Note that probably split almost never makes sense after moving forward
        in the !HasNext() && HasFollow() case, but let's stay on the safe side
        and only do this when the follow definitely fits, which is enough for
        our needs here.
        
        Change-Id: I64b0a7d257b0ab01353741506969a287b361c5ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157233
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-25  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [6acdde8006e6b59758b00bc178f15f32796a1987]

        upload libwps 0.4.14
        
        Change-Id: I0d10aafa17afaaef9b154255bf17638dd67070e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157149
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-09-25  Miklos Vajna  <vmiklos@collabora.com>  [d6a1324380cc8362d509a1f29dcd2ca4ad4bee9d]

        svx: prefix members of SdrHdlColor
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic987e38bb2f1a23504e27a32062df75215de6b3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157232
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-24  Stephan Bergmann  <sbergman@redhat.com>  [19e9fe7c8c89399753ac1730e1c76378b18418bc]

        Adapt a hard-coded value hack
        
        ...from 22267b7797340d1eb52ced10fe05afeb8a42fc2b "When building with clang-cl,
        nevertheless use MSVC's CXXFLAGS_CXX11 for CLR" to
        1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20"
        
        Change-Id: I817a33b7ca5ae4db232bf4c983d46e808dc83f24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157230
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-24  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [90c97ccfd8c0324fffec8852935e71e1f0670d76]

        Resolves tdf#136216 - Hide uno:AdditionsDialog from customization
        
        Change-Id: I0948a85cf222a44534473ee465087213734536b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157185
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-24  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [a5ece3a525466198c91633af3b9e0d6edfe9802f]

        Resolves tdf#155044 - Rename "Description" to "Alt Text"
        
        Change-Id: Idc6602c6dfc7c6c8703fb8fc643665d7149486a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157183
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c5cff66335ca162b52270059e57214c4065caf66]

        loplugin:unusedmethods
        
        Change-Id: I231b80cb0779d92bba32da67f6878c07d757c967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157198
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [df2c41859287282501c8ebd7b3c67465455a457c]

        MoveFocusInsideDeckTitle is dead
        
        after
            commit 9ca60dc90958001c078ed6331bd432c36961a425
            Author: Rafael Lima <rafael.palma.lima@gmail.com>
            Date:   Wed Jul 26 02:00:40 2023 +0200
            tdf#156156 Add Help button to sidebar decks
        
        Change-Id: I71893e5f0b35ffec3eb718b0dfb556a3405b5c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-24  Khaled Hosny  <khaled@libreoffice.org>  [d9eed9b489d8ad208df307588595f3a8d3b7539b]

        tdf#157067: Fix missing background color in style preview
        
        Set the colors after setting the font not before as otherwise they seem
        to get overridden.
        
        Change-Id: I258cb762fd2328369bd8adae63e94ec87c666bb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157208
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-24  Stephan Bergmann  <sbergman@redhat.com>  [414316a04fe9479dafcb36e3617ee1f5813c6a30]

        Drop some newly obsolete __clang_major__ version checks
        
        ...after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 "Adapt Clang and GCC minimum
        version checks"
        
        Change-Id: Ib25fbb76211d1bda1d230de771f207960e645421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-24  Stephan Bergmann  <sbergman@redhat.com>  [72da78be20ebe1cd62ba7a5ac6e29b9d40f00f15]

        Drop some newly obsolete __GNUC__ version checks
        
        ...after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 "Adapt Clang and GCC minimum
        version checks"
        
        Change-Id: I5f3bcda2ce8e0e093af3bdd9d2cca741a5b95306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157202
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23de37d22c9fecbcffdcf4eb02c926f0f9403d5e]

        Fix typo
        
        Change-Id: I88c3e9f36c38bd31cd78871d5e86c607ebb39211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157209
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-24  Julien Nabet  <serval2412@yahoo.fr>  [553e09879b1ed20f09224582ab904b6ab1646259]

        tdf#157388: LibreLogo sqrt undefined
        
        Change-Id: Ief68aa9067e3c817f9ce5694ce015ca9049b4375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157206
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-24  Julien Nabet  <serval2412@yahoo.fr>  [be637958995db309782c7e1a8cc4a80a5d30c9a6]

        Blind fix for TBs sd_web error
        
        "blind" because I don't reproduce this on pc Debian x86-64 with master sources updated today
        + "make clean && make"
        
        It might be since https://cgit.freedesktop.org/libreoffice/core/commit/?id=28b6480c6bdd179f3943f768926b7f196226c768
        tdf#105303: Drop html export wizard
        
        Change-Id: Ib5b705a6f98d7e88d84217906b32c371aac96d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157203
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-24  Julien Nabet  <serval2412@yahoo.fr>  [aaccb43dad5290cde04b36209ca9fa95d69ba060]

        tdf#157288: "Primary key" missing when right click a field during table edition
        
        Revert partly 0c2b2c9babfd781e0d9d68bb2a14a045b0c6ec4c
        "Use getXWeak in stoc"
        
        Change-Id: I0344510dee33c8740937354d64c0e60115606d26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157178
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-24  Patrick Luby  <plubius@neooffice.org>  [c43d11cbbabc871a3c71062239b0d9b6db99961e]

        tdf#156539 Draw the gradient with polypolygonal clip when using Skia
        
        For some unkown reason, the previous "draw gradient with XOR, draw
        polygon with N0, and draw gradient again with XOR" does not work
        with Skia/Raster (at least on macOS). Fortunately, Skia supports
        polypolygonal clipping so just clip and draw the gradient.
        
        Change-Id: Id069160312a270096f5ec9c670615eb95ec6200b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157199
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-24  Julien Nabet  <serval2412@yahoo.fr>  [3399854b66bb1fb175b8504c964008e53167ca7b]

        tdf#157260: don't add a "port" param if already present in the connection DB url
        
        Regression of https://cgit.freedesktop.org/libreoffice/core/commit/?id=afe99617707c92460e66486c0057ef327e8aa017
        "tdf#43369: Specific UI for collecting PostgreSQL connection settings"
        in 2023-04
        
        Change-Id: Id6e9c9a1aa8586cb4081e22988060476183369d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157193
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-23  Stephan Bergmann  <sbergman@redhat.com>  [6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441]

        Adapt Clang and GCC minimum version checks
        
        ...that were missing from 02f48a32400f81413329d81203c417521882cab6 "Adjust for
        new linux baseline"
        
        Change-Id: I3e204107239612595bfac0d1f9d4c4d6a6900f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157176
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-23  Ankit_Jaipuriar  <ankitjaipuriar07@gmail.com>  [18bc7b514c31270af37e98a0183eb34ed7970265]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Ied9c8342cdfa44d6a468a39acbb577af79ef1e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157164
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-23  Julien Nabet  <serval2412@yahoo.fr>  [c81a6071536a07734dec2cc36384f583e70c9b5f]

        Revert partly "Use less epoxy external headers dependency"
        
        Following these errors:
        [LNK] Library/libdeployment.so
        ld.lld: error: undefined symbol: epoxy_glBindRenderbuffer
        >>> referenced by gtkinst.cxx:2081 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:2081)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2082 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:2082)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:1925 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:1925)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::adjustToNewSize())
        >>> referenced 5 more times
        
        ld.lld: error: undefined symbol: epoxy_glBindFramebufferEXT
        >>> referenced by gtkinst.cxx:2083 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:2083)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2061 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:2061)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::restoreDefaultFramebuffer())
        >>> referenced by gtkinst.cxx:1929 (vcl/unx/gtk4/../gtk3/gtkinst.cxx:1929)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o:((anonymous namespace)::GtkOpenGLContext::adjustToNewSize())
        >>> referenced 2 more times
        
        ld.lld: error: undefined symbol: epoxy_glBindRenderbuffer
        >>> referenced by gtkinst.cxx:2081 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2081)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2082 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2082)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:1925 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:1925)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::adjustToNewSize())
        >>> referenced 5 more times
        
        ld.lld: error: undefined symbol: epoxy_glBindFramebufferEXT
        >>> referenced by gtkinst.cxx:2083 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2083)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2061 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2061)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::restoreDefaultFramebuffer())
        >>> referenced by gtkinst.cxx:1929 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:1929)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::adjustToNewSize())
        >>> referenced 2 more times
        
        ld.lld: error: undefined symbol: epoxy_glFramebufferRenderbufferEXT
        >>> referenced by gtkinst.cxx:2084 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2084)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2086 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2086)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::makeCurrent())
        >>> referenced by gtkinst.cxx:2062 (vcl/unx/gtk3_kde5/../gtk3/gtkinst.cxx:2062)
        >>>               /home/julien/lo/libreoffice/workdir/CxxObject/vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.o:((anonymous namespace)::GtkOpenGLContext::restoreDefaultFramebuffer())
        >>> referenced 6 more times
        
        Change-Id: Iaba2323e294aba74a74d3ac98679143a68bbd53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [810fdf5e562324b03c7d08ab710ac14eb692bd08]

        tdf#105303: drop webview files too
        
        leftover from 28b6480c6bdd179f3943f768926b7f196226c768
        "tdf#105303: Drop html export wizard"
        
        Change-Id: I2f202685b0919754098a65f4e1c847706d00b438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157181
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-23  Arnaud Versini  <arnaud.versini@libreoffice.org>  [da9582aacb3fa9f00f172e0698b3b53aedee87f9]

        animations : remove useless use of XComponentContext
        
        Change-Id: Ie7aa03a9ff1127f2c73ab30528dd2b732f6c4b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157143
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-09-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1dd357ccf7ca9edbe5f2ef60465c2559f678d306]

        tdf#152675 treat all cairo versions <= 1.17.8 the same
        
        wrt unwanted sideeffects of CAIRO_HINT_METRICS_OFF seen
        in https://gitlab.freedesktop.org/cairo/cairo/-/issues/643
        and https://bugs.documentfoundation.org/show_bug.cgi?id=152675
        
        Change-Id: Ib3f43fd3832083f1768b737e3a5fb28063c0ae23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [28b6480c6bdd179f3943f768926b7f196226c768]

        tdf#105303: Drop html export wizard
        
        Done during the conference hackfest
        
        Change-Id: I765e6dc839a98038c4071c8444ce3db9293c8a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157173
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [7d66020d291928d03b638e03371359e756583178]

        tdf#146619 Recheck include/[e-j]* with IWYU
        
        Change-Id: I705becd4618989ca274ca8c42eeff3bc18a4ae76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156986
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c17d369230b1eac80395a1aebf058bace12885be]

        Use less epoxy external headers dependency
        
        Change-Id: If5d4e5a65a0fcea6bd67cdba48742f6aaec0811d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156556
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c794cc61cdb07f2b7d1a2f30add52a53ccdac458]

        tdf#157168 GtkSpinButton ignores out-of-range value instead of limiting
        
        (to range)
        
        Change-Id: Ib25276ccea18b45756ac2769cb00cb9d7db0c400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [35af9aa55056299a20983777069f6d3f6007c03a]

        tdf#146619 Recheck include/d* with IWYU
        
        Change-Id: Ib17953b49e5035255203e33778a262211d1491f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156985
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7d6ca465224e5e839055e9607deeb2a80a93621b]

        update credits
        
        Change-Id: I376459b1bee20e819ba3ee8fa6776d79fe84e8b8

2023-09-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [281a7e96495f4c8665c1fffee5bac287b6f002f2]

        Related: Ignore warning C4723 for windows arm64 build
        
        Add description of C4723 error.
        
        follow-up: 246d4f14c347ddd8cf49a397984a5f13c9687896
        Change-Id: I7752f8989e21a1af772bea47aeaf2a832e0af175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157047
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-09-22  Cosmin Humeniuc  <cosmin.humeniuc@1and1.ro>  [69d0a140ae133f6c9ec708034ca8a888a734f9b9]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I800806bc45f8eb9d99a49697fe6142cf93c0f322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157153
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-22  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [daa5049f2dbf94f8003f4d35a973f002b899fc24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a4952ec1b49ab70ba0271b5ff3f5e34e0405c82d
          - tdf#128150: document Use Background fill
            
            Change-Id: I64313179e41593ed9e34e0b5a29874d5875dd70d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156544
            Tested-by: Jenkins
            Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-22  Mihai Vasiliu  <mihai.vasiliu.93@gmail.com>  [59b685e20cc7c74954757ab6b48a27ddf4d689f1]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Ib3c0d6c158e5efbbca55e03f189dccaf67832fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157155
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-22  Patrick Luby  <plubius@neooffice.org>  [f4c2c7c79cfe4464ac596afda37b8904d06969db]

        tdf#157312 Don't change priority
        
        Instances of this class are constructed with
        TaskPriority::POST_PAINT, but then it was set to
        TaskPriority::HIGHEST when reused. Flushing
        seems to be expensive (at least with Skia/Metal) so keep the
        existing priority when reused.
        
        Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-22  Jim Raykowski  <raykowj@gmail.com>  [bb3a60cfdbed880e482229e0eed08b5e2e7e311b]

        tdf#152029 Fix bringing a heading to attention brings a section to
        
        attention when the heading is the first content node in the section
        
        Change-Id: I37a8e03fc4aa7c59d82449d467279587c494b416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157163
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-22  Gabor Kelemen  <kelemeng@ubuntu.com>  [2f85eb7a2dcd9a53245897c87d16f5a51772846b]

        tdf#146619 Recheck include/c* with IWYU
        
        Change-Id: I0cf6f675483bddf82e7347b484a874c71963bfd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156984
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-22  Stephan Bergmann  <sbergman@redhat.com>  [1eef07805021b7ca26a1a8894809b6d995747ba1]

        Bump baseline to C++20
        
        Change-Id: I47c3a3bdbf2b7b85f8f6f91b694625197aab8002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-22  Bogdan Buzea  <buzea.bogdan@libreoffice.org>  [0f2918c25daab25cd0721d69f0506fe04456262d]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I3f0c0b4e9004c45e8f1d12065a322b7a91b09150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157152
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-22  Miklos Vajna  <vmiklos@collabora.com>  [652ab50ce18d0ce7fa1209e6bcf3b10ac5c9a933]

        tdf#154198 sw: fix lost vertical table cell borders for WordTableCell + RTL
        
        This went wrong in commit 0dbecd2d2ebe18a262cfab96e105637840b5b7fe (sw:
        fix too long inner borders intersecting with outer borders for Word
        cells, 2022-01-06), the problem is that in its current form this assumes
        that the first cell is on the left and the last cell is on the right,
        which is not true for RTL, so only tweak the length of the borders in
        the LTR case.
        
        Change-Id: I513af974855496e507134cf156f9ee5a937a46db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157161
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-21  Jim Raykowski  <raykowj@gmail.com>  [b97f7b6bee733e108d8214d5387b2dc019d93d8f]

        tdf#152029 Don't include frame area top margin in the bring table to
        
        attention overlay
        
        Change-Id: I13b8c09640dfc269330a3786b6449139f5f64661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157131
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-21  Khaled Hosny  <khaled@libreoffice.org>  [d31cc3545ba05d5a45d38d8e72c2428af91cb784]

        starmath: No need for the OUString copy here
        
        Change-Id: I71e6fd6ff9f5420899ece59b97b81b5e837f919b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157142
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-21  Khaled Hosny  <khaled@libreoffice.org>  [899522378bfb754af757c1a4a0f6bce699ac8721]

        starmath: Rename SmSym::GetName() -> GetUiName()
        
        To make it obvious this is the UI (localized) name.
        
        Change-Id: Id0dbffeaa9c331ce90dee3e7fbc88f93fab1b654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157138
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-21  Khaled Hosny  <khaled@libreoffice.org>  [7de4c6b95da7d187c403ee478786bb74467c1eb5]

        tdf#62174: Fix saving of localized iGreek symbols
        
        When saving symbols we use the non-localized name, but iGreek symbols
        are a bit of a hack since they are added at runtime and don’t have
        localizations of there own but use the Greek symbols names with an “i”
        prefix.
        
        Instead of looking directly for localized names, we now go through the
        symbol manager that already knows about iGreek and use the export name
        of the symbol. We have to also make sure the iGreek symbols has
        non-localized export name.
        
        Change-Id: Ia3e38579abba56ae12ade126f564f8c6f9c3229a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157137
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-21  Miklos Vajna  <vmiklos@collabora.com>  [cfe9c68a7a19dd77d1fcbde3a7dd75730634becc]

        tdf#157119 sw floattable: fix moving master of split fly to next page
        
        The problem with the bugdoc is that in case you split the text frame
        hosting the start of the anchor text, then the fly will be split in a
        broken way on pages 1 -> 4 -> 2, while we want a split on just pages 2
        -> 3.
        
        There were several problems here:
        
        1) We created an unnecessary follow fly in SwFrame::GetNextFlyLeaf():
           when page 1 wanted to split, we discarded the flys on page 2 and 3,
           because the original anchor was in the body text and the flys on page
           2/3 was in a fly, so that's rejected. This resulted in a follow fly on
           page 4, which is not correct. Fix this by using an existing follow if
           possible, this is similar to what SwFrame::GetNextSctLeaf() does.
        
        2) SwFlyAtContentFrame::DelEmpty() broke the invariant that in case the
           fly is split to N pieces then the anchor chain's first N frame is
           matching that. Fix this by joining the unwanted anchor with its
           follow right before unlinking the to-be-deleted fly from the fly chain.
        
        3) SwToContentAnchoredObjectPosition::CalcOverlap() tried to shift down
           flys due to overlapping with the to-be-deleted frames, fix this by
           ignoring flys which are already in the to-delete list.
        
        4) SwContentFrame::ShouldBwdMoved() tried to move the master fly back
           from page 2 to page 1, which makes no sense, since there is not
           enough space there to lay out the fly master correctly there.
        
           Normally we only check if the paragraph fits the remaining space on
           the previous page, and this is wanted: if there is a normal to-para
           anchored image that would not fit, we simply shift up the image. But
           this is not wanted to floating tables, since here the anchor's only
           purpose is to host the start of the fly chain at a correct position.
        
           Fix this by checking not only for the text frame height vs the
           available space, but also the height of our (only) anchored object.
        
        Note that 3) is not a huge problem, it just causes some extra cycles for
        the layout (erase the to-delete flys, then position flys once more), do
        it because things are complicated enough already.
        
        Change-Id: I6f2c9d479125309d16b95df0236715c9353e8ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157133
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-21  Gabor Kelemen  <kelemeng@ubuntu.com>  [7ac978c4d18c1a91fdc784eb3e5ea381a783efdb]

        tdf#146619 Recheck include/basegfx with IWYU
        
        Change-Id: I08dad6ceeaa9e5470491c09f06d819c4c27ec5f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156983
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-21  Miklos Vajna  <vmiklos@collabora.com>  [a64d90da6976e6f04c68a5ea470c3dad2b8eb5a1]

        UITest_writer_tests7: use oneprocess mode
        
        Before: 7m37,421s
        
        After: 5m29,121s
        
        Also UITest_demo_ui: 1m43,126s -> 0m55,159s
        
        Change-Id: Idf705fdcdb62e27b4d42287f4c95fcd3893cdd4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157106
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-21  apurvapriyadarshi  <apriyadarshi.1995@gmail.com>  [9844a197bfe91e7adb74e9e5859c7fbfaaf99e28]

        tdf#147906 used StrictMath.hypot for Pythagorean addition
        
        Change-Id: I529dc199c2cc20ce91b7181f650c36db8d81fc9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157098
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-21  Juan C. Sanz  <jcsanz@libreoffice.org>  [fbf71a4c21106fbed7c070ba940809fd84c76dfe]

        Revert "tdf#117118 - Saves data automatically in Firebird embedded database"
        
        This reverts commit 9227fbabe0a33134f56aefdd8ec16024f006a659.
        
        Reason for revert: This patch generate a new bug, so I revert it until further investigation
        
        Change-Id: I4d613db8cef5363c6b276b8646147443871c312a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157116
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7f69bca41c5034207ba9170420f6b3b214121a7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c54900b4d40d11cbef8f14d2907d8d9f12c9f7b
          - (related)tdf#107447 update option names; tdf#121596 add "narrow no-break space"
            
              * "Non-breaking space" -> "No-break space"
              * "No-width optional break" -> "Zero width space"
              - remove xml-lang="en-US"
            
            Change-Id: I63454d2ae2c2c73eaa1023ac62dfc505d81e8762
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156955
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4fdb26f728d72bde645fd7fd1a3601340cec82dd]

        tdf#107447  add hyphen to zero-width, improve keyboard accelerators
        
        Change-Id: Ib9fae582157af992a4d7f76d10bb73939c4c8ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156959
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-20  Hossein  <hossein@libreoffice.org>  [a34dcd03254480927c403d904c0e754802d97b90]

        Prepend instdir/program to the PATH in bin/run
        
        To avoid problems described in 21cf443235bf6579959988edee325e8332a42f9f,
        do not change directory.
        
        Change-Id: I56590c4728a6505c089a5bc06bed2a31a0cd0362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156973
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-20  Khaled Hosny  <khaled@libreoffice.org>  [6ae1c47fa1033619bf191a0f4228394ff90f5df6]

        tdf#32418: Add Tools -> Special Character... to Math
        
        Change-Id: I0f4e12f82a3b8e7be2459f4ccfa91f7d30d67f78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157095
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-20  Khaled Hosny  <khaled@libreoffice.org>  [8bf38cc394f96a1f1592a7bbd62e1f7db03f3db6]

        starmath: Don’t set empty font name when reading font format from file
        
        If a setting is missing, e.g. math font when reading old file, we would
        set it to an empty font instead of using the default.
        
        Regression from:
        
        commit 626d17a8ec270937575e9684a325eb0669327a25
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Aug 31 14:54:52 2023 +0300
        
            tdf#143213: Fix reading math font settings from file
        
        Change-Id: Ib8b3cede3d4bea7e03a146b7e5f39ad2c7dfa363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157094
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-20  Michael Stahl  <michael.stahl@allotropia.de>  [b20ca8d951e8205c8b963c6b7407f984053b4094]

        tdf#157129 sw: fix wrong cursor position after paste
        
        This asserts in SwUndoInserts::UndoImpl():
        index.cxx:234: virtual SwContentIndexReg::~SwContentIndexReg(): Assertion `!m_pFirst && !m_pLast && "There are still indices registered"' failed.
        
        Because there is a bookmark still registered, because the content was
        inserted wrongly into a fly frame that contains a SwGrfNode, because
        earlier the cursor was in a hidden text node and
        SwCursorShell::UpdateCursorPos() moved it into an as-char anchored image.
        
        UpdateCursorPos() should put the cursor only onto a text node.
        
        (somehow regression from commit bb733957dd39e6f0b9d80bb59eb0177188794797)
        
        Change-Id: If00d1e09a612849a44bb3e2d3bd7bac6fa9ac05f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157071
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-20  Patrick Luby  <plubius@neooffice.org>  [c2d7c8e5c616980d5fa77ac48babbf27342b2f0a]

        tdf#156842 increase scale for external PDF data
        
        For some unknown reason, the scale is 8 times larger than for
        non-external PDF XObjects.
        
        This fix also allows the CppunitTest_vcl_pdfexport to run
        successfully on macOS.
        
        Change-Id: I166914e6ac575c50985efba3fb7a38ec758dea1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157090
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [489eb5dcffcb6fec819cd855d563494fa4d32b28]

        Use less boost external headers dependency in sc
        
        Change-Id: I531a357d14afc73b51abee0586516d8b28867562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156554
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-20  Arnaud Versini  <arnaud.versini@libreoffice.org>  [08a2de20238e250d5ddf8cc43341a9f48ed9d759]

        basic : remove useless allocation in BasicDLLImpl
        
        Change-Id: I8e2628da08cb621087915dcfb4d55ddacfeaabc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157048
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-20  Miklos Vajna  <vmiklos@collabora.com>  [35f43bfafa763b7e45188f155fab746c0aec8804]

        writerfilter: get rid of not needed RowPointer_t indirection
        
        RowData::Pointer_t is already a typedef, can use that directly
        everywhere.
        
        Change-Id: I393f8878abcdc9e053a08e70f26b6b1030ee5e8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157049
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [211c4df7656bc81617e98ec89466c12f998a6130]

        Fix typo
        
        Change-Id: I1d248f2980292cdbb9f2c3275c4f371b75f1a2f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157028
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [41208b2c46f082814faf721eb84baaf4fc7e9e78]

        Remove duplicated includes
        
        Change-Id: Ia76c2a83f5c5e0ea31260dace7bd32763eb4d0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157035
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [db41fbf7224d1d1dd1ef2d7f2ac0dd005d6367be]

        Remove executable bits on odt file
        
        Change-Id: Ie7ee5bc7586835f65eae7275f2cfc1d86a2cbbdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157091
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-20  Jim Raykowski  <raykowj@gmail.com>  [91ca15e3f8ae13b22531745a634459a2d9b4596a]

        tdf#139923 Part A: Master Navigator: Fix Insert popup menu
        
        Makes Master Navigator content tree popup menu item 'Insert' submenu
        items set sensitivity settings work for SalInstanceMenu.
        GtkInstanceMenu doesn't seem to require additional menu declarations
        for submenu items to be able to set sensitivity.
        
        Change-Id: Ifec28429927591f80859e3b20765c59374a64faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156980
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [486ae5db6987411d5e394de94b2b077099d03856]

        tdf#106663 - Test GoToNextPlacemarker in header's fly frame
        
        Change-Id: I3a2d63c0a1f07460db4aeabd1df289090c5f013b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157070
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-09-19  Noel Grandin  <noelgrandin@gmail.com>  [6ae1794736666b2a483120977479fc6f12406021]

        rename SfxObjectShell::GetError -> GetErrorIgnoreWarning
        
        to distinguish it from the very similar GetErrorCode()
        
        Change-Id: Ic863742a7546e2835826d12181bf073ccbbbfb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-19  Khaled Hosny  <khaled@libreoffice.org>  [9e92a17cb6e03beedeeca40bfc8524c2623d31eb]

        starmath: Improve glyph positioning
        
        Using twips everywhere and not rounding to pixels seems to improve
        positioning (at least on hipdi displays). Hopefully the issue that
        required rounding is no longer relevant.
        
        Change-Id: I0ee4a4453b2a3d8e06be56d586761f7960a2d4d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157044
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-19  Khaled Hosny  <khaled@libreoffice.org>  [37f91706e6efd36074187234530f8c8ee8a3edd8]

        starmath: Get the font from current format for special symbols
        
        We want to use the current format when using the symbol in a document,
        and fallback for stabdard format when rendering the symbol in symbols
        dialog.
        
        Fixup for the following two commits:
        
        commit f28b043b4eb40e90b330721fc43d19ae6c06951e
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Mon Sep 18 19:00:02 2023 +0300
        
            starmath: Fix editing symbols in the Symbols Catalogue
        
        commit 32d2e001bb056e7d98aa143b222f2721967337dc
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Tue Sep 12 18:35:46 2023 +0300
        
            tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbols
        
        Change-Id: Id3730749a49015120ecf9719027f932fd90c605a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157043
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8a9c3e82386d700549cac30f2555952046e021cb]

        oox: change frozen::make_set to "conventional" frozen::set construction
        
        Fixes compile issue with bisect repo started with commit: b839c09760919d4f4a21ed1819885b5385f27e31 (https://gerrit.libreoffice.org/c/core/+/157003)
        
        Log:
        
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: error: no matching function for call to ‘make_set<std::u16string_view>(<brace-enclosed initializer list>)’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:223:16: note: candidate: template<class T> constexpr auto frozen::make_set(frozen::bits::ignored_arg)
         constexpr auto make_set(bits::ignored_arg = {}/* for consistency with the initializer below for N = 0*/) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:223:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: note:   cannot convert ‘{"b\000l\000o\000c\000k\000-\000a\000r\000c\000\000", "r\000e\000c\000t\000a\000n\000g\000l\000e\000\000", "e\000l\000l\000i\000p\000s\000e\000\000", "r\000i\000n\000g\000\000", "c\000a\000n\000\000", "c\000u\000b\000e\000\000", "p\000a\000p\000e\000r\000\000", "f\000r\000a\000m\000e\000\000", "f\000o\000r\000b\000i\000d\000d\000e\000n\000\000", "s\000m\000i\000l\000e\000y\000\000", "s\000u\000n\000\000", "f\000l\000o\000w\000e\000r\000\000", "b\000r\000a\000c\000k\000e\000t\000-\000p\000a\000i\000r\000\000", "b\000r\000a\000c\000e\000-\000p\000a\000i\000r\000\000", "q\000u\000a\000d\000-\000b\000e\000v\000e\000l\000\000", "r\000o\000u\000n\000d\000-\000r\000e\000c\000t\000a\000n\000g\000u\000l\000a\000r\000-\000c\000a\000l\000l\000o\000u\000t\000\000", "r\000e\000c\000t\000a\000n\000g\000u\000l\000a\000r\000-\000c\000a\000l\000l\000o\000u\000t\000\000", "r\000o\000u\000n\000d\000-\000c\000a\000l\000l\000o\000u\000t\000\000", "c\000l\000o\000u\000d\000-\000c\000a\000l\000l\000o\000u\000t\000\000", "l\000i\000n\000e\000-\000c\000a\000l\000l\000o\000u\000t\000-\0001\000\000", "l\000i\000n\000e\000-\000c\000a\000l\000l\000o\000u\000t\000-\0002\000\000", "l\000i\000n\000e\000-\000c\000a\000l\000l\000o\000u\000t\000-\0003\000\000", "p\000a\000p\000e\000r\000\000", "v\000e\000r\000t\000i\000c\000a\000l\000-\000s\000c\000r\000o\000l\000l\000\000", "h\000o\000r\000i\000z\000o\000n\000t\000a\000l\000-\000s\000c\000r\000o\000l\000l\000\000", "m\000s\000o\000-\000s\000p\000t\0003\0004\000\000", "m\000s\000o\000-\000s\000p\000t\0007\0005\000\000", "m\000s\000o\000-\000s\000p\000t\0001\0006\0004\000\000", "m\000s\000o\000-\000s\000p\000t\0001\0008\0000\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000p\000r\000o\000c\000e\000s\000s\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000a\000l\000t\000e\000r\000n\000a\000t\000e\000-\000p\000r\000o\000c\000e\000s\000s\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000e\000c\000i\000s\000i\000o\000n\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000a\000t\000a\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000p\000r\000e\000d\000e\000f\000i\000n\000e\000d\000-\000p\000r\000o\000c\000e\000s\000s\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000i\000n\000t\000e\000r\000n\000a\000l\000-\000s\000t\000o\000r\000a\000g\000e\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000o\000c\000u\000m\000e\000n\000t\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000m\000u\000l\000t\000i\000d\000o\000c\000u\000m\000e\000n\000t\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000t\000e\000r\000m\000i\000n\000a\000t\000o\000r\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000p\000r\000e\000p\000a\000r\000a\000t\000i\000o\000n\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000m\000a\000n\000u\000a\000l\000-\000i\000n\000p\000u\000t\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000m\000a\000n\000u\000a\000l\000-\000o\000p\000e\000r\000a\000t\000i\000o\000n\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000c\000o\000n\000n\000e\000c\000t\000o\000r\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000o\000f\000f\000-\000p\000a\000g\000e\000-\000c\000o\000n\000n\000e\000c\000t\000o\000r\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000c\000a\000r\000d\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000p\000u\000n\000c\000h\000e\000d\000-\000t\000a\000p\000e\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000s\000u\000m\000m\000i\000n\000g\000-\000j\000u\000n\000c\000t\000i\000o\000n\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000o\000r\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000c\000o\000l\000l\000a\000t\000e\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000s\000o\000r\000t\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000e\000x\000t\000r\000a\000c\000t\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000m\000e\000r\000g\000e\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000s\000t\000o\000r\000e\000d\000-\000d\000a\000t\000a\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000e\000l\000a\000y\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000s\000e\000q\000u\000e\000n\000t\000i\000a\000l\000-\000a\000c\000c\000e\000s\000s\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000m\000a\000g\000n\000e\000t\000i\000c\000-\000d\000i\000s\000k\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000i\000r\000e\000c\000t\000-\000a\000c\000c\000e\000s\000s\000-\000s\000t\000o\000r\000a\000g\000e\000\000", "f\000l\000o\000w\000c\000h\000a\000r\000t\000-\000d\000i\000s\000p\000l\000a\000y\000\000"}’ (type ‘<brace-enclosed initializer list>’) to type ‘frozen::bits::ignored_arg’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:228:16: note: candidate: template<class T, long unsigned int N> constexpr auto frozen::make_set(const T (&)[N])
         constexpr auto make_set(const T (&args)[N]) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:228:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: note:   mismatched types ‘std::basic_string_view<char16_t>’ and ‘const char16_t*’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:233:16: note: candidate: template<class T, long unsigned int N> constexpr auto frozen::make_set(const std::array<_Tp, _Nm>&)
         constexpr auto make_set(std::array<T, N> const &args) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:233:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: note:   couldn't deduce template parameter ‘N’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:238:16: note: candidate: template<class T, class Compare, long unsigned int N> constexpr auto frozen::make_set(const T (&)[N], const Compare&)
         constexpr auto make_set(const T (&args)[N], Compare const& compare = Compare{}) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:238:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: note:   mismatched types ‘std::basic_string_view<char16_t>’ and ‘const char16_t*’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:243:16: note: candidate: template<class T, class Compare, long unsigned int N> constexpr auto frozen::make_set(const std::array<T, N>&, const Compare&)
         constexpr auto make_set(std::array<T, N> const &args, Compare const& compare = Compare{}) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:243:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:622:2: note:   couldn't deduce template parameter ‘Compare’
         });
          ^
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: error: no matching function for call to ‘make_set<std::u16string_view>(<brace-enclosed initializer list>)’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:223:16: note: candidate: template<class T> constexpr auto frozen::make_set(frozen::bits::ignored_arg)
         constexpr auto make_set(bits::ignored_arg = {}/* for consistency with the initializer below for N = 0*/) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:223:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: note:   cannot convert ‘{"h\000e\000a\000r\000t\000\000", "p\000u\000z\000z\000l\000e\000\000", "c\000o\000l\000-\0006\0000\000d\000a\0008\0004\0006\0000\000\000", "c\000o\000l\000-\0005\0000\0002\000a\000d\0004\0000\0000\000\000"}’ (type ‘<brace-enclosed initializer list>’) to type ‘frozen::bits::ignored_arg’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:228:16: note: candidate: template<class T, long unsigned int N> constexpr auto frozen::make_set(const T (&)[N])
         constexpr auto make_set(const T (&args)[N]) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:228:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: note:   mismatched types ‘std::basic_string_view<char16_t>’ and ‘const char16_t*’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:233:16: note: candidate: template<class T, long unsigned int N> constexpr auto frozen::make_set(const std::array<_Tp, _Nm>&)
         constexpr auto make_set(std::array<T, N> const &args) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:233:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: note:   couldn't deduce template parameter ‘N’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:238:16: note: candidate: template<class T, class Compare, long unsigned int N> constexpr auto frozen::make_set(const T (&)[N], const Compare&)
         constexpr auto make_set(const T (&args)[N], Compare const& compare = Compare{}) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:238:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: note:   mismatched types ‘std::basic_string_view<char16_t>’ and ‘const char16_t*’
         });
          ^
        In file included from /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:90:0:
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:243:16: note: candidate: template<class T, class Compare, long unsigned int N> constexpr auto frozen::make_set(const std::array<T, N>&, const Compare&)
         constexpr auto make_set(std::array<T, N> const &args, Compare const& compare = Compare{}) {
                        ^~~~~~~~
        /home/tdf/lode/bibisect/core242/workdir/UnpackedTarball/frozen/include/frozen/set.h:243:16: note:   template argument deduction/substitution failed:
        /home/tdf/lode/bibisect/core242/oox/source/export/shapes.cxx:630:2: note:   couldn't deduce template parameter ‘Compare’
         });
          ^
        make[1]: *** [/home/tdf/lode/bibisect/core242/solenv/gbuild/LinkTarget.mk:340: /home/tdf/lode/bibisect/core242/workdir/CxxObject/oox/source/export/shapes.o] Error 1
        
        Change-Id: Ie2d4dbe05df89578e5f86c4d2ef8367a563e3942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157024
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-19  Michael Stahl  <michael.stahl@allotropia.de>  [655874489a13af50b763b75c188b2a8db52c7fc0]

        tdf#157131 sw: only check for table in same top-level section
        
        The problem is that SwNodes::FindPrvNxtFrameNode() is called with the
        first node in the body and moves backwards to a node that is in a table
        in a text frame.
        
        (regression from commit faf2d9e2cb13c3750ac359338f8f31fc1afce368)
        
        Change-Id: I9bd353f07ea6361b332134186a6a4462119b597c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157045
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-19  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [0c4913e03e8427a576138601958f2dbf13b8c37b]

        xmlsecurity : simplify DigitalSignature
        
        Change-Id: I05777731f1d69b5714942411401afb5fd605d726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155668
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [55afdf6d1748edd50be3fa6a67a5e36e74013815]

        loplugin:unusedfields
        
        Change-Id: Ic102ae992fc2fbfd187149b9d20bf1d2202ba5c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157042
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-19  Szymon Kłos  <szymon.klos@collabora.com>  [f850458af4b09f6f860223254c95b2d3fb24fa49]

        jsdialog: enable chart trend line tab
        
        Change-Id: I89bae89a703fbd3ac07fc4e23659b092402e8a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157050
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6b055e4c6e6d70082708122d7c36487caca65015]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fed34532d998019b7bee3aff933e3b0ddeff9493
          - tdf#157006  update label change for "Tolerate white lines..."
            
            Change-Id: Iab618fb9cde15e344a86ced0ceed2394f0eb1472
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157051
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5debde6869e61d20148d16a9d47fb87dbf42f354]

        tdf#157006  shorten "Tolerate white lines..." label
        
        Change-Id: I84fb8733940c88c6120b1132f046040931ee206f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156960
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f787581ee67207921906442c0cf7f6ed87eebd7]

        m_nLastTableCellParagraphDepth is write-only
        
        ever since
          commit 2d43c34333076fad092f0cdc0f60f81580acdbee
          Author: Miklos Vajna <vmiklos@collabora.com>
          Date:   Fri Sep 15 13:37:41 2023 +0200
        Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at
        cell start
        
        Change-Id: Ifa2837fde41cecdf51ba4858dd52a59d79e4474e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157041
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-19  Miklos Vajna  <vmiklos@collabora.com>  [cf2be3754b4c48382a61e044209c077bf59c72f2]

        tdf#157005 sw floattable: fix missing format of next row in follow fly
        
        The bugdoc has a multi-page floating table, the B1 cell is on page 1.
        Pressing enter at the end of the cell first creates a split cell (on
        page 1 and page 2), but then pressing enter once more leads to
        overlapping text.
        
        The trouble seems to be that the second row has its
        mbFrameAreaPositionValid set to false, but nobody formats the row, that
        would recalc its position.
        
        Fix the problem by relaxing the check in SwLayAction::FormatContent(),
        so we do a full format not only in case there are to-para anchored
        objects to the current content frame, but also do the same in case it's
        a follow and the matching master has some draw objects that are
        effectively anchored in the current content frame.
        
        Previously this wasn't a problem, because split flys are the only
        construct where a follow frame can have to-para anchored objects.
        
        Change-Id: I0893aced3ad59963f87874c5aff0e57ad325c01b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157039
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-19  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [2e71c439057c8d31b6af191ef38607600cb996f0]

        tdf#146619 Remove unused includes from sal/ [cpp files]
        
        Change-Id: I11a54c1ddf73c16ce46a0d1c375bf43157870db7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155856
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-19  Miklos Vajna  <vmiklos@collabora.com>  [f2f32aaa839b25a2413928b7b92fff3d71034508]

        sw: document SwFormatCol
        
        It's not too obvious that you can have columns directly inside the body
        text as well, not only inside a UI-level section.
        
        Change-Id: I8194aa472fd1d515552dddbe6d14a3d38fa5c1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157030
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [024685f655c368fdcf4b9d29206526758eaf9015]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49cc168cf18562283b308f039cc8fc37b8866fed
          - tdf#155214 Rename Modify to Assign in keyboard shortcut customisation
            
            Change-Id: I0eed5cd062ad1c726444493ab9726240818d7dc1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157038
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-09-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [02f48a32400f81413329d81203c417521882cab6]

        Adjust for new linux baseline
        
        Change-Id: I6916ee8e6f7f8beac1f3eade7ae539340ce3a2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156920
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-19  Gabor Kelemen  <kelemeng@ubuntu.com>  [05418537bf82929c1e4a8575453b26d7d4c843fe]

        bin/find-unneeded-includes: silence error on include/vcl/toolkit
        
        Change-Id: Ia40717df6d6137ca5a8f6d91dd5b95a1decbaa72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156991
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-19  Andras Timar  <andras.timar@collabora.com>  [957d4254d6ab13bfa5df01b728d3396f11c82e9a]

        The name is macOS since 2016
        
        Change-Id: I9f2011e1f9619652b4ed417f135451d8ccfe90bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157033
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [5416c9183384d46f9eb347871541c6ee1e30c28b]

        tdf#111705: Add Arabic math symbols to the symbols catalogue
        
        Change-Id: Ieabf4d3173a7ce985a9164db8b2de4c8b6d0da36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157029
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-18  Andras Timar  <andras.timar@collabora.com>  [ade5e9f7a93b6cbbdc8348062cfed4ebfac1506b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d1f356ef5b582aaf4abdf950dec1a948743dc38
          - The name is macOS since 2016
            
            Change-Id: Id344c2bb54d5bc7400ba9ec61c06619b5310ee2c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/157034
            Tested-by: Jenkins
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2023-09-18  Martin Srebotnjak  <miles@filmsi.net>  [967471cf3c40b76299cab644e0732814b3507c69]

        Update git submodules
        
        * Update translations from branch 'master'
          to 59f229c573e676a78060014fab5a181fd16c5335
          - Updated Slovenian translation
            
            Change-Id: I659ec47d800cf28c4f8a87e8465b5a48ebe17f6c
            
2023-09-18  Szymon Kłos  <szymon.klos@collabora.com>  [ba81501e6094d89c18629dc1ad9b7eb6e3837e50]

        jsdialog: vertical notebook
        
        Change-Id: I584509bfd3d367c8b1c4183c8d176ba7b7ad0cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155755
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157027
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-18  Szymon Kłos  <szymon.klos@collabora.com>  [fa2e2757f35883f61841c49f53ad5f80979c8a76]

        Move SalInstanceVerticalNotebook decl to header
        
        Change-Id: I38c7ed846c8a19f72f5738bd137cefebd6a33070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157026
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-18  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [841f898574affb526a516224d7c3db9b137ea62b]

        JavaScript uno bindings for WASM with Embind - first cut
        
        A rough implementation of uno bindings for LOWA using embind.
        
        Adds new parameter '-W' to cppumaker to generate _embind.cxx
        files alongside .hdl & .hpp.
        
        For usage examples see static/README.wasm.md
        
        Change-Id: Iee5d05e37bfba8e101c08212b15c05f7f2fa6c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156273
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-18  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [971425f9b7613183a565e9b4ec5792b3f67bb133]

        fix emscripten build
        
        Change-Id: I15df992e410f741a22d1f140b85e57a97195a5f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157020
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [f28b043b4eb40e90b330721fc43d19ae6c06951e]

        starmath: Fix editing symbols in the Symbols Catalogue
        
        Fallout from:
        
        commit 32d2e001bb056e7d98aa143b222f2721967337dc
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Tue Sep 12 18:35:46 2023 +0300
        
            tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbols
        
        Change-Id: I1f440dccc920b24010160dbeee58795ffd8f85ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157025
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-18  Szymon Kłos  <szymon.klos@collabora.com>  [6182deca602d533d1b2e379ba62d890681608144]

        jsdialog: set WindowId for font size combobox
        
        this is required to put combobox in correct map
        for receiveing events from user. without that
        font size was not possible to be changed from
        notebookbar in lok
        
        Change-Id: Id688b8fc1b3f565278ae651e050d18d75a048103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156783
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157023
        Tested-by: Jenkins

2023-09-18  Szymon Kłos  <szymon.klos@collabora.com>  [cea900fe9864bbc5314415cb369fc7b6111cd050]

        Schedule conditional formating repaint after filtering is completed
        
        When we have sheet with lots of data with applied conditional formatting
        and that data is used with autofilter feature - filtering is very slow.
        That was caused by repaints synchronously called on every row show/hide.
        
        ScConditionalFormat::DoRepaint()   called by ScFormulaListener callback
        ...
        ScDocument::Broadcast
        ScColumn::BroadcastRows
        ScTable::SetRowHidden
        ScTable::DBShowRows
        
        This patch schedules repaint in the Idle so we do that after all changes
        are already applied.
        
        Change-Id: If0876ada0f336a41b69560db6a581d6e24d7ac16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157016
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-18  Michael Stahl  <michael.stahl@allotropia.de>  [d19fb1dd668473f2d4f8dbde8bac1fcb34042a6a]

        sw: fix crash when moving nodes into undo array
        
        In SwUndoSaveContent::MoveToUndoNds() a node is split and in
        sw::OnlineAccessibilityCheck::runAccessibilityCheck() we get:
        
        sw/inc/ndindex.hxx:99: bool SwNodeIndex::operator<(const SwNode&) const: Assertion `&GetNodes() == &rNd.GetNodes()' failed.
        
        Try to make sure that OnlineAccessibilityCheck doesn't touch nodes in
        the undo array.
        
        Change-Id: Iaeb0d36c341c05948cdfcce08009b0430a78f214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156970
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [b2b43e83ccc41c37bad32a4dcf07ca86bf2f8a15]

        a11y: Call base class impl at beginning of Edit::GetFocus
        
        Call the base class implementation `Control::GetFocus()`
        (which currently is just `Window::GetFocus`) before doing
        anything else, not at the end. This ensures that
        a focused event is sent to the a11y layer before e.g.
        adapting text selection. Assistive tooling
        handles the currently focused object with
        special interest (and announces events on that
        object much more likely than for any other objects).
        
        This e.g. makes Orca announce the labels for the
        spinboxes (like "Width", "Height", "Left", "Right")
        in Writer's "Format" -> "Page Style" dialog -> "Page"
        page when using the qt6 VCL plugin.
        
        Previously, only the current value
        of the spinboxes was announced without the label
        when moving focus into one of them
        using the Tab key.
        
        The following 2 Orca commits [1] [2] in the
        LibreOffice-specific Orca code look related:
        
            commit c4c5d11656ec7221e4aa4b980e51c010dcc62674
            Author: Joanmarie Diggs <jdiggs@igalia.com>
            Date:   Mon Aug 7 13:53:41 2017 -0400
        
                Work around event-ordering issue in LibreOffice
        
            commit 38b995d9bacc55bb455c4464b01c82b885ed5549
            Author: Joanmarie Diggs <jdiggs@igalia.com>
            Date:   Fri Feb 15 09:40:07 2019 -0500
        
                Don't present locusOfFocus changes due to text-selection-changed events
        
        (The first one makes the object sending a
        text-selection-changed event the focus object in Orca,
        the second one then causes this implicit focus object
        to no longer be announced. And when LO itself sends
        the focused event for the object, the object is already
        considered as the focus object, i.e. not announced
        either because the assumption is that the focus hasn't
        changed.)
        
        If the new event order causes any issues elsewhere because
        other places depend on the previous order, that will have to
        be looked into individually, s.a. the discussion in the
        Gerrit change for some thoughts on that [3].
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/commit/c4c5d11656ec7221e4aa4b980e51c010dcc62674
        [2] https://gitlab.gnome.org/GNOME/orca/-/commit/38b995d9bacc55bb455c4464b01c82b885ed5549
        [3] https://gerrit.libreoffice.org/c/core/+/156679
        
        Change-Id: Ib0188fe206a49c9052ec9694bafd451586ff0b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156679
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [489985a6fbba71f74ea343c4162d599eacb9c7d0]

        tdf#157304 Use normalized selection indices as string indices
        
        The start index of the selection can be larger than the
        end index.
        Take that into account when using these indices to
        calculate the index and character count to copy
        the relevant substring using `OUString::copy`.
        
        Without this, running the tdf#157304 macro would trigger
        an assert due to invalid indices being used.
        
        Backtrace:
        
            soffice.bin: .../libreoffice/sal/rtl/strtmpl.hxx:890: void rtl::str::newfromsubstring(rtl_tstring**, const rtl_tstring*, sal_int32, sal_int32) [with rtl_tstring = _rtl_ustring; sal_int32 = int]: assertion `false' failed.
        
            Thread 1 "soffice.bin" received signal SIGABRT, Aborted.
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a814f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff785a462 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78444b2 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007ffff78443d5 in __assert_fail_base
                (fmt=0x7ffff79b8dc8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7ffff7f6f2ec "false", file=file@entry=0x7ffff7f6be70 ".../libreoffice/sal/rtl/strtmpl.hxx", line=line@entry=890, function=function@entry=0x7ffff7f6f260 "void rtl::str::newFromSubString(rtl_tString**, const rtl_tString*, sal_Int32, sal_Int32) [with rtl_tString = _rtl_uString; sal_Int32 = int]") at ./assert/assert.c:92
            #5  0x00007ffff78533a2 in __assert_fail
                (assertion=0x7ffff7f6f2ec "false", file=0x7ffff7f6be70 ".../libreoffice/sal/rtl/strtmpl.hxx", line=890, function=0x7ffff7f6f260 "void rtl::str::newFromSubString(rtl_tString**, const rtl_tString*, sal_Int32, sal_Int32) [with rtl_tString = _rtl_uString; sal_Int32 = int]") at ./assert/assert.c:101
            #6  0x00007ffff7eee8b7 in rtl::str::newFromSubString<_rtl_uString>(_rtl_uString**, _rtl_uString const*, int, int) (ppThis=0x7fffffffae40, pFrom=0x55555e7af450, beginIndex=6, count=-6)
                at .../libreoffice/sal/rtl/strtmpl.hxx:890
            #7  0x00007ffff7ee91ca in rtl_uString_newFromSubString(rtl_uString**, rtl_uString const*, sal_Int32, sal_Int32) (ppThis=0x7fffffffae40, pFrom=0x55555e7af450, beginIndex=6, count=-6)
                at .../libreoffice/sal/rtl/ustring.cxx:1219
            #8  0x00007ffff1697b52 in rtl::OUString::copy(int, int) const (this=0x7fffffffae88, beginIndex=6, count=-6) at .../libreoffice/include/rtl/ustring.hxx:2229
            #9  0x00007ffff1814180 in svt::EntryImplementation::GetSelected(LineEnd) const (this=0x55555ed5e660) at .../libreoffice/include/svtools/editbrowsebox.hxx:371
            #10 0x00007ffff180d61b in FmXEditCell::getSelectedText() (this=0x55555ed5d500) at .../libreoffice/svx/source/fmcomp/gridcell.cxx:3739
            #11 0x00007fffdc1496f5 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
                (pThis=0x55555ed5d600, nVtableIndex=8, pRegisterReturn=0x7fffffffb2f0, pReturnTypeRef=0x555555743db0, bSimpleReturn=false, pStack=0x7fffffffb020, nStack=0, pGPR=0x7fffffffb180, pFPR=0x7fffffffb1b0)
                at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:75
            #12 0x00007fffdc1481a0 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**)
                (pThis=0x55555e7b0490, aVtableSlot=..., pReturnTypeRef=0x555555743db0, nParams=0, pParams=0x0, pUnoReturn=0x7fffffffb2f0, pUnoArgs=0x7fffffffb2e0, ppUnoExc=0x7fffffffb3d0)
                at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
            #13 0x00007fffdc148cdd in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**)
                (pUnoI=0x55555e7b0490, pMemberDescr=0x55555cccccc0, pReturn=0x7fffffffb2f0, pArgs=0x7fffffffb2e0, ppException=0x7fffffffb3d0) at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
            #14 0x00007fff5beb45f2 in stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&)
                (this=0x55555ed792f0, rObj=uno::Any("com.sun.star.uno.XInterface": ...), rArgs=empty uno::Sequence) at .../libreoffice/stoc/source/corereflection/criface.cxx:590
            #15 0x00007fff68020606 in (anonymous namespace)::IntrospectionAccessStatic_Impl::getPropertyValueByIndex(com::sun::star::uno::Any const&, sal_Int32) const
                (this=0x55555cc55910, obj=uno::Any("com.sun.star.uno.XInterface": ...), nSequenceIndex=13) at .../libreoffice/stoc/source/inspect/introspection.cxx:588
            #16 0x00007fff68020161 in (anonymous namespace)::IntrospectionAccessStatic_Impl::getPropertyValue(com::sun::star::uno::Any const&, rtl::OUString const&) const
                (this=0x55555cc55910, obj=uno::Any("com.sun.star.uno.XInterface": ...), aPropertyName="SelectedText") at .../libreoffice/stoc/source/inspect/introspection.cxx:498
            #17 0x00007fff68022522 in (anonymous namespace)::ImplIntrospectionAccess::getPropertyValue(rtl::OUString const&) (this=0x55555f4211a0, aPropertyName="SelectedText")
                at .../libreoffice/stoc/source/inspect/introspection.cxx:1014
            #18 0x00007ffff4edb132 in SbUnoObject::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55555e7b0530, rBC=..., rHint=...) at .../libreoffice/basic/source/classes/sbunoobj.cxx:2059
            #19 0x00007ffff39c55f6 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x55555e7b07d0, rHint=...) at .../libreoffice/svl/source/notify/SfxBroadcaster.cxx:40
            #20 0x00007ffff505a52b in SbxVariable::Broadcast(SfxHintId) (this=0x55555e7b09d0, nHintId=SfxHintId::BasicDataWanted) at .../libreoffice/basic/source/sbx/sbxvar.cxx:155
            #21 0x00007ffff5054564 in SbxValue::Get(SbxValues&) const (this=0x55555e7b09d0, rRes=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:289
            #22 0x00007ffff50568fe in SbxValue::Compute(SbxOperator, SbxValue const&) (this=0x55555f441ac0, eOp=SbxCAT, rOp=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:809
            #23 0x00007ffff4fd4fb9 in SbiRuntime::StepArith(SbxOperator) (this=0x55555f43f5d0, eOp=SbxCAT) at .../libreoffice/basic/source/runtime/runtime.cxx:1305
            #24 0x00007ffff4fd580d in SbiRuntime::StepCAT() (this=0x55555f43f5d0) at .../libreoffice/basic/source/runtime/runtime.cxx:1418
            #25 0x00007ffff4fd2fb8 in SbiRuntime::Step() (this=0x55555f43f5d0) at .../libreoffice/basic/source/runtime/runtime.cxx:795
            #26 0x00007ffff4f1c85f in (anonymous namespace)::RunInitGuard::run() (this=0x7fffffffbb40) at .../libreoffice/basic/source/classes/sbxmod.cxx:1017
            #27 0x00007ffff4f1d2f5 in SbModule::Run(SbMethod*) (this=0x55555cc779e0, pMeth=0x55555f435130) at .../libreoffice/basic/source/classes/sbxmod.cxx:1177
            #28 0x00007ffff4f1b907 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55555cc779e0, rBC=..., rHint=...) at .../libreoffice/basic/source/classes/sbxmod.cxx:775
            #29 0x00007ffff39c55f6 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x55555f4305d0, rHint=...) at .../libreoffice/svl/source/notify/SfxBroadcaster.cxx:40
            #30 0x00007ffff4f221e4 in SbMethod::Broadcast(SfxHintId) (this=0x55555f430500, nHintId=SfxHintId::BasicDataWanted) at .../libreoffice/basic/source/classes/sbxmod.cxx:2121
            #31 0x00007ffff5054564 in SbxValue::Get(SbxValues&) const (this=0x55555f430500, rRes=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:289
            #32 0x00007ffff4f21e88 in SbMethod::Call(SbxValue*, SbxVariable*) (this=0x55555f430500, pRet=0x55555f42fff0, pCaller=0x55555f441b60) at .../libreoffice/basic/source/classes/sbxmod.cxx:2077
            #33 0x00007fff60031152 in basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&)
                (this=0x55555eddeae0, aParams=uno::Sequence of length 1 = {...}, aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence) at .../libreoffice/scripting/source/basprov/basscript.cxx:252
            #34 0x00007ffff440c3e8 in SfxObjectShell::CallXScript(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&, bool, com::sun::star::uno::Any const*)
                (_rxScriptContext=uno::Reference to (SwXTextDocument *) 0x55555c8acf20, _rScriptURL="vnd.sun.star.script:Standard.Module1.TestFocus?language=Basic&location=document", aParams=uno::Sequence of length 1 = {...}, aRet=uno::Any(void), aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence, bRaiseError=true, pCaller=0x7fffffffc670) at .../libreoffice/sfx2/source/doc/objmisc.cxx:1439
            #35 0x00007ffff440c8ea in SfxObjectShell::CallXScript(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&, bool, com::sun::star::uno::Any const*)
                (this=0x55555794e5c0, rScriptURL="vnd.sun.star.script:Standard.Module1.TestFocus?language=Basic&location=document", aParams=uno::Sequence of length 1 = {...}, aRet=uno::Any(void), aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence, bRaiseError=true, pCaller=0x7fffffffc670) at .../libreoffice/sfx2/source/doc/objmisc.cxx:1468
            #36 0x00007ffff1904e37 in svxform::(anonymous namespace)::NewStyleUNOScript::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&)
                (this=0x55555e778920, _rArguments=uno::Sequence of length 1 = {...}, _rSynchronousResult=uno::Any(void)) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:831
            #37 0x00007ffff1905461 in svxform::FormScriptingEnvironment::doFireScriptEvent(com::sun::star::script::ScriptEvent const&, com::sun::star::uno::Any*) (this=0x55555c8e5f10, _rEvent=..., _pSynchronousResult=0x0)
                at .../libreoffice/svx/source/form/fmscriptingenv.cxx:905
            #38 0x00007ffff1904264 in svxform::FormScriptListener::impl_doFireScriptEvent_nothrow(std::unique_lock<std::mutex>&, com::sun::star::script::ScriptEvent const&, com::sun::star::uno::Any*)
                (this=0x55555c8e80e0, _rGuard=..., _rEvent=..., _pSynchronousResult=0x0) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:684
            #39 0x00007ffff190469f in svxform::FormScriptListener::OnAsyncScriptEvent(void*) (this=0x55555c8e80e0, p=0x55555e778870) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:744
            #40 0x00007ffff19045eb in svxform::FormScriptListener::LinkStubOnAsyncScriptEvent(void*, void*) (instance=0x55555c8e80e0, data=0x55555e778870) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:733
            #41 0x00007fffeddb80ed in Link<void*, void>::Call(void*) const (this=0x55555e7788c8, data=0x55555e778870) at .../libreoffice/include/tools/link.hxx:111
            #42 0x00007fffeddb51aa in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x55555e7788c0) at .../libreoffice/vcl/source/window/winproc.cxx:2287
            #43 0x00007fffeddb70d7 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x555556c6da40, nEvent=SalEvent::UserEvent, pEvent=0x55555e7788c0)
                at .../libreoffice/vcl/source/window/winproc.cxx:2851
            #44 0x00007fffe2e98caa in SalFrame::CallCallback(SalEvent, void const*) const (this=0x555556c6f760, nEvent=SalEvent::UserEvent, pEvent=0x55555e7788c0) at .../libreoffice/vcl/inc/salframe.hxx:310
            #45 0x00007fffe2eb8973 in QtInstance::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x55555573db20, aEvent=...) at .../libreoffice/vcl/qt5/QtInstance.cxx:484
            #46 0x00007fffee46593b in operator()() const (__closure=0x7fffffffcc20) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119
            #47 0x00007fffee465c0f in SalUserEventList::DispatchUserEvents(bool) (this=0x55555573db58, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120
            #48 0x00007fffe2eb8458 in QtInstance::ImplYield(bool, bool) (this=0x55555573db20, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt5/QtInstance.cxx:410
            #49 0x00007fffe2eb8603 in QtInstance::DoYield(bool, bool) (this=0x55555573db20, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt5/QtInstance.cxx:432
            #50 0x00007fffee5221a8 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:377
            #51 0x00007fffee522f46 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:461
            #52 0x00007fffee521e9b in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:355
            #53 0x00007ffff7a36296 in desktop::Desktop::Main() (this=0x7fffffffd720) at .../libreoffice/desktop/source/app/app.cxx:1601
            #54 0x00007fffee541f42 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:204
            #55 0x00007fffee542077 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:236
            #56 0x00007ffff7aa1b81 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94
            #57 0x00005555555549d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51
            #58 0x00005555555549ba in main (argc=2, argv=0x7fffffffd948) at .../libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Ib6989cc302419bf44a59bd2fff159257f647726d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157017
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-18  Szymon Kłos  <szymon.klos@collabora.com>  [4c76b9568a3d008219a3dc0818f2f6db2939e354]

        lok: don't convert save request to save as
        
        Don't force save as in LOK but report that file cannot be written.
        Without that we go through save as process which is used for export
        functionality and client's browser downloads the file in the end
        instead of uploading to the storage.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I2784bfc25055934363c304b5f5a87ae4da620a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156819
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157021
        Tested-by: Jenkins

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b47a69ebee54a4b399c90311e17b994635140002]

        use more concrete UNO types in sw
        
        Change-Id: I04d790ff9247f4a810da975128e91073e285f267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0b73760a29ea80d242958942b153769a59bf0f9]

        use more concrete UNO types in sw
        
        Change-Id: I446cf00ac7e320586da2dd0837cf873ca9ab0ca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157013
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [301e522e7ee440b9c026042dd94815134c88adf2]

        use more concrete UNO types in sw
        
        Change-Id: I9eadb749cf8971a9753227e848e72903d06b11ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157012
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [34d6dfb68224f576fb316a0822143470233fd40a]

        use more concrete UNO types in sw
        
        Change-Id: Ia6e3c30267a80726793edfccb891970d706d913f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Gökay Şatır  <gokaysatir@gmail.com>  [dea852d00bed5cfe2c223b8bf30dff19a60a50a6]

        We can allow one to answer their own comment.
        
        Other office implementations allow this.
        
        I think we can enable reply button for the owner of the comment, unless there is a good reason to not to.
        
        Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
        Change-Id: I6969122efe24d2804b4092e0afe0709a2fd1ef98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156688
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157018
        Tested-by: Jenkins

2023-09-18  Stephan Bergmann  <sbergman@redhat.com>  [384e12a806dbf86bd69c2c994a84a8b9f64fd67f]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/c4535c99d165fe22f4ae0dcc59a505f1e96a6f72>
        "Update gvfs-1.50.6.tar.xz to 1.52.0"
        
        Change-Id: I5554a832efc03cfaf35d18f99b459ac2147c4d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157015
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-18  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [15cacb9054b3cdbdc803634b73d697c3147167bf]

        Use less boost external headers dependency in shell
        
        Change-Id: Ie9c184abe3f30b79163bed10c89f4cf76015a5aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156555
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e130cd6cc8c3c4ece6b803c54fad21d4287a16f]

        use more concrete UNO types in sw
        
        Change-Id: I60adb24adbbf202fd0ae0e81798799644760724a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157010
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Dan Horák  <dan@danny.cz>  [e03be024ae9c16fa8542757ad2c327259d5b9b0c]

        sw/qa/extras/globalfilter: check for pdfium availability
        
        A section of testListLabelPDFExport requires pdfium. The pPdfDocument pointer
        is set to NULL when pdfium is not available, so check it first. This
        avoids a segfault when LO would be built without pdfium.
        
        Change-Id: Ic66a4552c8512702bbfd6d24f5bb581ab824bbe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156940
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-09-18  Miklos Vajna  <vmiklos@collabora.com>  [fec20d4bba32b06fa3641290deaa4e4fec98ae42]

        svx: prefix members of SdrHdlBezWgt
        
        See tdf#94879 for motivation.
        
        Change-Id: I1bacd92ad30fe3765d2eb5054018f6fd64a3835d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157005
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-18  Miklos Vajna  <vmiklos@collabora.com>  [a33316afa4a20499159b8c900e56658512deb74a]

        tdf#55160 sw floattable, nested DOCX imp: fix inner tables at cell start
        
        The trouble was that in case two floating tables start at an (outer)
        cell start, then everything up to the end of the first inner table ended
        up in the body text, not in the outer table.
        
        This happens because the table depth of the inserted dummy character was
        incorrect.
        
        Fix the problem by comparing what model.xml does at <w:p> start and what
        OOXMLFastContextHandlerTextTable::lcl_startFastElement() did in the
        dummy paragraph case, and sending the table depth in the dummy case as
        well.
        
        With this the bugdoc has the expected 19 floating tables in Writer and
        is of 1 page, both matching Word.
        
        Change-Id: I604956f28fdc01943ab913c5aa30365376c4d2b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157006
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [92096f7f645f58889e86573b620b1e23d74758cb]

        use more concrete UNO types in sw
        
        Change-Id: I4209069f0d930af1f3aed1a00c5c6a775bdc5dbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [6f60670877208612b5ea320b3677480ef6508abb]

        Use less zlib external headers dependency
        
        Change-Id: Ibcc7f37e464cde44cfbb6fbd70c3dc66667102bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156553
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b3118be28fa6e5906b44c4963b0bb2ca804a863]

        use more concrete UNO types in sw
        
        Change-Id: I6afcc0443081efebdf8b4d291f1a81b2667c4d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [af83536685cf50a564d9c8290bf6ea5982de73b7]

        use more concrete UNO types in sw
        
        Change-Id: I6a1b2cc07928a053e70cf4707ab5d5f3d3bf9407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [acdc5c50938a3c7032a00ab08efbb4916519e06b]

        use more concrete UNO types in sw
        
        Change-Id: Ied57649bba82b3d9c7324e1e1c6d29a8b4f5390c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [2cedcebc15f7199c8a3c16bb3f25c7a422770ecc]

        tdf#111705: Add the new maj and hadd operators to the elements panel
        
        Change-Id: Ib62592d86a1bf2e5d94348fca731473dba92be74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156996
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [49a3e606856167f4e9c3a80e89900bf7c29c8423]

        use more concrete UNO types in sw
        
        Change-Id: I028032671a346e1d046b846d3f9617b5a12ffd70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156998
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b839c09760919d4f4a21ed1819885b5385f27e31]

        oox: some more conversions to frozen map and set
        
        Change-Id: Ibe557006ee4393a2cfa2cb600744ca5ba7090ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157003
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-18  t-aswath  <aswatht.cse2022@citchennai.net>  [e425c837aec0b11f381ddb49fe651acf5509bd82]

        tdf#155214 - rename "Modify" button to "Assign"
        
        Change-Id: Ib8dda9ed48ea5db66b7668b156d8533472cf7d50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156974
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [e472b5b557d2b43b41e488c83db2b188de499610]

        starmath: Show editing window by default again
        
        We are not ready to get rid of it (e.g. undo does not work when it is
        hidden). This flips the default introduced in:
        
        commit e9cc014be4150a5adc9950f366c9bdfa50420dcf
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Tue Sep 12 16:41:37 2023 +0300
        
            starmath: Hide editing window by default and add a menu item to show
        
        Change-Id: If84b25d186c8d133a9fa5cfc0c3d91162c66b389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157004
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [9023cbc96c3538995f0ef9042aebcad14711cd60]

        tdf#111705: Add support of Persian limits operator (U+1EEF1)
        
        Change-Id: I9936a206b2ce6c8d195967d1e14596c5903c1ef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156995
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-18  Khaled Hosny  <khaled@libreoffice.org>  [d4edecb26cc5a801815a612cdd27f3dc621d5038]

        tdf#111705: Add support of Arabic summation operator (U+1EEF0)
        
        Needed to fix a punch of code to work with UTF-16 not just UCS-2 (in
        other words, handle surrogate pairs).
        
        Change-Id: Idd7aa823349a032f20f37abbb588856afbc548d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156994
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-17  Jim Raykowski  <raykowj@gmail.com>  [80a24870491385ba145757bf517c5f1cf7939017]

        tdf#152029 Don't include frame area top margin in the bring headings to
        
        attention overlay
        
        Change-Id: I1ddd842b01d2a134a281f97d9377a3d41b3ecb41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156981
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3e16b50525422e77f2a293ab36e0da5b6afccda]

        use more concrete UNO types in sw
        
        Change-Id: Ifddd96357d39e17bc8d301a0738bfabc736afe13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156997
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ad66ed2c5345f63e0581b6053222c80a9c612c3]

        remove unnecessary dynamic_cast around SwXText
        
        Unusually, we cannot use rtl::Reference to hold SwXText,
        because rtl::Reference assumes that its pointee is a subclass
        of OWeakObject, which SwXText is not (and we cannot make
        it so because the UNO bridge does not support virtual base
        classes).
        
        So we have to use css::uno::Reference<SwXText> and carve
        out an exception in loplugin:refcounting.
        
        Change-Id: If3a1307e30fdcd3b47aa665252be081fb5063400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156982
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-17  Julien Nabet  <serval2412@yahoo.fr>  [8f55b9fccda8abe690693d8630a9a52369f984ec]

        tdf#157277: fix Writer crash when hiding Sidebar + using bookmark in Navigator
        
        Relevant part of bt (from exception thrown):
        1  0x00007f00b5398a34 in SfxUnoDecks::getByName(rtl::OUString const&) (this=0x559ce97aff60, aName="NavigatorDeck") at /home/julien/lo/libreoffice/sfx2/source/sidebar/UnoDecks.cxx:45
        2  0x00007f00b5398edf in non-virtual thunk to SfxUnoDecks::getByName(rtl::OUString const&) () at /home/julien/lo/libreoffice/instdir/program/libsfxlo.so
        3  0x00007f008bc016a5 in SwContentTree::GotoContent(SwContent const*) (this=0x559ce849e850, pCnt=0x559ce4b8cc10) at /home/julien/lo/libreoffice/sw/source/uibase/utlui/content.cxx:5463
        
        See full bts (initial + from exception thrown) here:
        https://bugs.documentfoundation.org/attachment.cgi?id=189632
        
        Test if xDecks has "NavigatorDeck" before trying to retrieve it since it seems it's not the case when sidebar disabled.
        
        Change-Id: Ia0aa64ebf26ad06fd4fe4b14f949453ae7948456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156978
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-16  Julien Nabet  <serval2412@yahoo.fr>  [a4522ef5ce6a625054d83ec907aee07c156e94ed]

        tdf#157266: fix crash related to tdf#157006
        
        Relevant part of bt:
        0  0x00007f417347028d in SwCompatibilityOptPage::GetAllStrings() (this=0x558e50180c80) at /home/julien/lo/libreoffice/sw/source/ui/config/optcomp.cxx:344
        1  0x00007f424dfc35e7 in OfaTreeOptionsDialog::initializeCurrentDialog(OptionsPageInfo*&, std::unique_ptr<weld::TreeIter, std::default_delete<weld::TreeIter> >&)
           (this=0x558e4d958ff0, pPageInfo=@0x7fff217470b8: 0x558e4d41f380, xEntry=std::unique_ptr<weld::TreeIter> = {...}) at /home/julien/lo/libreoffice/cui/source/options/treeopt.cxx:1253
        2  0x00007f424dfc22a7 in OfaTreeOptionsDialog::initializeFirstNDialog(short) (this=0x558e4d958ff0, nNumberOfNode=-1) at /home/julien/lo/libreoffice/cui/source/options/treeopt.cxx:877
        3  0x00007f424dfc1ca8 in OfaTreeOptionsDialog::ImplUpdateDataHdl(Timer*) (this=0x558e4d958ff0) at /home/julien/lo/libreoffice/cui/source/options/treeopt.cxx:805
        4  0x00007f424dfbbc1d in OfaTreeOptionsDialog::LinkStubImplUpdateDataHdl(void*, Timer*) (instance=0x558e4d958ff0, data=0x558e4d959060) at /home/julien/lo/libreoffice/cui/source/options/treeopt.cxx:792
        
        Full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=189631
        
        "label2" had been removed with https://git.libreoffice.org/core/+/1d4cd39262fb71f72311e33ac2bdb7d925be5d98%5E%21
        "Related tdf#157006 - Remove global compatibility options
        
        Clean-up the UI in favor of the advanced options
        "
        
        Change-Id: I8e3532fb79afedf05fe42d0745c823fa2f1c362c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156977
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-16  Martin Srebotnjak  <miles@filmsi.net>  [bd46feef5a65b3ea152da839b19131b1787c8257]

        Update git submodules
        
        * Update translations from branch 'master'
          to bdb4063cfd1b431b7281c8f3ad6e804bc43190e0
          - Updated Slovenian translation
            
            Change-Id: I6a612b5c9329db26d9368dda230a0db21f18ff6b
            
2023-09-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5fd0d769a2a0106b6b12faed28dc81d90153c16c]

        oox: use frozen unordered_map for mapping the name string to token
        
        Change-Id: Ib1f7d28509a1bc2680ad66b2cb1bf0ed35315f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156975
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-16  Hossein  <hossein@libreoffice.org>  [930f0aa232611d751209c5cb089b9f282f26bde8]

        tdf#157273 Port DevelopersGuide/FirstSteps examples to BASIC
        
        These 3 examples from the chapter 1 of the DevGuide are ported to BASIC:
        
        1) FirstUnoContact
        2) FirstLoadComponent
        3) HelloTextTableShape
        
        More details can be found in the LibreOffice DevGuide:
        
        LibreOffice Developer's Guide: Chapter 1 - First Steps
        https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
        
        Change-Id: I577ad81d76cec06102f00b2646b004caa5f7b401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156976
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-15  Hossein  <hossein@libreoffice.org>  [36163d269bd8f77a86605e4c5ff5adce17b4c66c]

        Make svptest VCL example build on all platforms
        
        Previously, svptest VCL example was not built on all paltforms. Now,
        svptest is built on Windows and elsewhere. To run, one can invoke:
        
         ./bin/run svptest
        
        Change-Id: I915a4ef9748e2248d2d209969d1fef079ee06cff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156972
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-15  Hossein  <hossein@libreoffice.org>  [140fe3080da8dd6468a223cb7bb56d3734377b9c]

        Make sure bin/run script finds the correct dlls
        
        On Windows/Cygwin, if you put "C:\Program Files\LibreOffice\program"
        in PATH, bin/run will have trouble finding correct vcllo.dll and other
        LibreOffice .dll files inside instdir/program. Because the script uses
        the absolute path of the executable, it is enough to use instdir/program
        as the current working directory.
        
        The symptom was that in the above case it was not possible to run the
        workbenches like vcldemo, minvcl, etc. The error was:
        
        $ ./bin/run minvcl
        
        minvcl.exe - Entry Point Not Found | The procedure entry point
        ?RasterFromBitmap@SKImages@@... could not be located in the dynamic
        link library vcllo.dll
        
        $ ldd ./lode/dev/core/workdir/LinkTarget/Executable/minvcl.exe
        	...
                comphelper.dll => not found
                fwklo.dll => not found
                i18nlangtag.dll => /cygdrive/c/Program Files/LibreOffice/program/i18nlangtag.dll (?)
                sal3.dll => /cygdrive/c/Program Files/LibreOffice/program/sal3.dll (?)
                vcllo.dll => not found
                MSVCP140D.dll => /cygdrive/c/WINDOWS/SYSTEM32/MSVCP140D.dll (?)
                VCRUNTIME140D.dll => /cygdrive/c/WINDOWS/SYSTEM32/VCRUNTIME140D.dll (?)
                VCRUNTIME140_1D.dll => /cygdrive/c/WINDOWS/SYSTEM32/VCRUNTIME140_1D.dll (?)
                ucrtbased.dll => /cygdrive/c/WINDOWS/SYSTEM32/ucrtbased.dll (?)
        
        Change-Id: I02b6d9aca1062b22a91d5a1f9bce0cf7238a896a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156902
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [0e6f5ac45e46fa9b17a656d28734666653373d7d]

        Related: tdf#157254 Shorten paths by removing relative parts
        
        E.g., a path like
        C:\lo\src\build\instdir\program\..\program\..\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl
        would become 22 characters shorter:
        C:\lo\src\build\instdir\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl
        
        Change-Id: Id6d397fdd7a1771225eef2e7e49ddb80802685b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-15  Julien Nabet  <serval2412@yahoo.fr>  [4bab6b0b870ae56b8d40eac22dbb0a433006789e]

        tdf#71224: Remove "Insert fields" option for an existing table (workaround)
        
        For the moment, we don't implement insert field at specific position
        It's not SQL standard and each database has made its choice (some use "BEFORE", other "FIRST" and "AFTER")
        and some, like Postgresql, don't allow this.
        So for the moment, test if the table already exists (and so it's an edition), in this case only
        we remove "Insert fields" entry. Indeed, in case of new table, there's no pb.
        
        The real fix is to implement the insert for each database + error message for those which don't support this
        
        Change-Id: I27010ed2dddee3f8746245406f2a0cb629b3d8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156948
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d61e34e5623eab8f735344b0e659d834f6069e0]

        reduce casting around ScDocShell
        
        instead of using SfxObjectShell and then static_cast'ing it
        everywhere.
        
        Change-Id: Id3184e44f048228dc4d0d9fa5d579e663c2762cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-15  Michael Stahl  <michael.stahl@allotropia.de>  [5a33420923c76d3e282f6d4ce0f3a63616ca3cff]

        tdf#157096 sw: layout: fix UAF crash from stale mpFlyDestory entry
        
        It doesn't make sense that mpFlyDestory entries survive exit from
        SwLayAction.
        
        Call DeleteEmptyFlys() whenever DeleteEmptySct() is called.
        
        (reportedly crashes since commit c303981cfd95ce1c3881366023d5495ae2edce97
         although i'd rather blame commit f6fbd9d5ff5b049112e6ca7a8943c156b3e4f411)
        
        Change-Id: Ie03e91a7d089c8aae8a1db65df835841f985771f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156949
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [c36fd4286c93da4b7b56da95b9693a97e0be71fc]

        tdf#157254: CLucene: fix pure virtual call in destructor
        
        When HelpIndexer::indexDocuments creates lucene::index::IndexWriter
        with a long path like
        C:\lo\src\build\workdir\longPathTest_123456789012345678901234567890123456789012345678901234567890\instdir\program\..\program\..\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl
        then CLucene's FSDirectory::FSIndexOutput::FSIndexOutput may fail
        and throw, which would unwind, and call FSIndexOutput destructor,
        then procede to inherited BufferedIndexOutput destructor, which
        calls close(), which calls flush(), which finally calls flushBuffer;
        and that one was pure virtual in BufferedIndexOutput, which meant,
        that in BufferedIndexOutput destructor, that was a pure virtual
        function call, crashing the process.
        
        Patch CLucene to have a default implementation of the function,
        usable in its destructor.
        
        Change-Id: I6f84c8cf2bd24b9bb92a71da485089ebf832530a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156944
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-15  Julien Nabet  <serval2412@yahoo.fr>  [5b49cf64482ca8246dbcf5b5f12a11d7f9ed081b]

        Fix assertion 'GTK_IS_CHECK_MENU_ITEM (check_menu_item)' in dbaccess
        
        Retrieve odb file https://bugs.documentfoundation.org/attachment.cgi?id=102977
        Open the file and edit the only table
        Right click at left on a field (except first one)
        
        (soffice:271527): Gtk-CRITICAL **: 14:35:42.787: gtk_check_menu_item_set_active: assertion 'GTK_IS_CHECK_MENU_ITEM (check_menu_item)' failed
        
        (soffice:271527): GLib-GObject-CRITICAL **: 14:35:42.787: invalid (NULL) pointer instance
        
        (soffice:271527): GLib-GObject-CRITICAL **: 14:35:42.787: g_signal_handlers_unblock_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
        
        If primary key entry is removed, don't try to call xContextMenu->set_active on it
        
        Change-Id: Ice57d840d12e986eb60514326806782e40f249fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156946
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2023-09-15  Miklos Vajna  <vmiklos@collabora.com>  [2d43c34333076fad092f0cdc0f60f81580acdbee]

        Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at cell start
        
        The bugdoc has an outer table and also two inner tables: the problematic
        one is the floating table anchored at the start of B1, which should
        float but does not.
        
        This special-casing was added in commit
        c1eebcdac9f2b289fd363399130c485ca5ff444c (tdf#79329 DOCX import: fix
        missing outer table with floattable at cell start, 2016-11-08), because
        there was no easy way to make sure that an inner floating table at cell
        start keeps the outer table import working, and having 2 inline tables
        is better than having an inner floating table and no outer table at all.
        The root of the problem is that in case an SwXParagraph tracks the outer
        cell start and we have an inner floating table, then the inner
        conversion to text frame will invalidate that SwXParagraph, so the outer
        table conversion will fail.
        
        Fix the problem by creating a cursor at cell start, moving it away,
        performing the inner table resolution. And in case the cell start
        SwXParagraph is now invalid, then move the cursor back and work with
        that position.
        
        The original bugdoc has 2 floating tables at cell start, which is still
        broken, but this approach allows fixing that in a later commit; while
        the old approach simply didn't notice that the 2nd floating table is
        also at cell start.
        
        Change-Id: Iedad7b2f023e88dfc5de7875ebc00320c2e6ad65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156937
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-15  Julien Nabet  <serval2412@yahoo.fr>  [17cd1dacf6a4b587b524edc7384ff26990208132]

        tdf#157174: fix crash when clicking "Print Preview"
        
        Don't call Reformat method when treating a virtual SdrObject
        
        bt:
        4  0x00007fd7ff446eb4 in SdrObject::GetBroadcaster() const (this=0x4) at /home/julien/lo/libreoffice/svx/source/svdraw/svdobj.cxx:698
        5  0x00007fd7ff48eaee in SdrEdgeObj::Reformat() (this=0x564e82ef22d0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdoedge.cxx:1666
        6  0x00007fd7ff551bd9 in SdrObjList::ImplReformatAllEdgeObjects(SdrObjList const&) (this=0x564e82a371e0, rObjList=...) at /home/julien/lo/libreoffice/svx/source/svdraw/svdpage.cxx:760
        7  0x00007fd7ff551b38 in SdrObjList::ReformatAllEdgeObjects() (this=0x564e82a371e0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdpage.cxx:744
        8  0x00007fd7ff3d8d1c in SdrModel::ImpReformatAllEdgeObjects() (this=0x564e7f79dc50) at /home/julien/lo/libreoffice/svx/source/svdraw/svdmodel.cxx:752
        9  0x00007fd7ff3dda3b in SdrModel::setLock(bool) (this=0x564e7f79dc50, bLock=false) at /home/julien/lo/libreoffice/svx/source/svdraw/svdmodel.cxx:1618
        10 0x00007fd7c58a9a76 in SwView::~SwView() (this=0x564e82e7bb00) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1163
        11 0x00007fd7c58a9f99 in SwView::~SwView() (this=0x564e82e7bb00) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1122
        12 0x00007fd801835308 in SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) (this=0x564e82b17680, nViewIdOrNo=1, bIsIndex=true) at /home/julien/lo/libreoffice/sfx2/source/view/viewfrm.cxx:2528
        
        See complete bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=189470
        
        Change-Id: I4de5127686c01a40c1666f6089efa4fe7a114cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156934
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [b5a8cdbd71a61c76f2b1a6ad33b0757911603184]

        tdf#122718 Add search functionality to the Functions sidebar
        
        With this patch it is possible to search the list of functions in the Functions sidebar.
        
        To use this feature:
        1) In Calc, go to View - Function List
        2) The Functions sidebar will open with the "Search" entry focused
        3) You can now type your search
        4) With the "Search" entry focused, it is possible to use the arrow keys (up/down) to select the function to insert
        5) Press "Enter" to insert the function
        
        The Escape key will clear the search box and F1 will open the help page of the selected function.
        
        Change-Id: I1af6c1c2489ff736c44e1b3750bea21c05786602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154917
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [2876b31eee9b2946dfaa74b17645c6812c7a20db]

        loplugin, merge weakobject into weakbase
        
        and make them support virtual bases, even though the bridge code does
        not support that (yet)
        
        Change-Id: I247e795391fa452dea2922869b15ab043eb2bdd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-15  Khaled Hosny  <khaled@libreoffice.org>  [a15762233047a75588f8c5da1cee1134f1259417]

        starmath: Improve root rendering for fonts other than OpenSymbol
        
        The radical glyph in OpenSymbol is aligned to the font ascender, which
        is not essentially true for other fonts, so we now use the bounding
        rectangle of the glyph to get accurate positioning.
        
        Change-Id: I83c21cd21de25f23f96f819e168f43aa9ab22351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156926
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-15  Stephan Bergmann  <sbergman@redhat.com>  [b9ffee3074d8eb0e95b3d8f78cb7aac10b41c279]

        StringHolder detour is only really needed for ""_tstr
        
        Change-Id: Ifd3b21cdfa3738737b47fde0d014c312494227e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156933
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-15  Miklos Vajna  <vmiklos@collabora.com>  [f1e4401dfbe7631de5de04960bebb72537618033]

        sw doc model xml dump: show when a redline is moved
        
        E.g. the DOCX import sets this bit on inserts and deletes.
        
        Change-Id: If7b654125071b204c9accfc3ea49e30767e82832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156929
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-15  Stephan Bergmann  <sbergman@redhat.com>  [233e0a009a6a22342a86a03eeb1349be2cd2d3eb]

        A more principled suppression of -fsanitize=function in external C code
        
        ...after
        <https://github.com/llvm/llvm-project/commit/279a4d0d67c874e80c171666822f2fabdd6fa926>
        "-fsanitize=function: support C".
        
        This includes reverts of 16af9e81863a80116f808ee3cfa4a1bab7c67ac5 "update clang
        asan suppressions" and 151a43f3d00f6523079c53d6c2d064f80b9a55d6 ""update clang
        asan suppressions".
        
        Change-Id: I49740f5f3a784af1d62b830b47bfdfa27fe3e471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156935
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-15  Adam Seskunas  <adamseskunas@gmail.com>  [d039fcd1cc6ce1f746b412f364790614bf972740]

        Move nUnicode variable to for loop condition statement.
        
        Use nUnicode directly in range based loop condition statement
        instead of declaring seperately in loop body.
        
        Change-Id: I07d8fb7a693909e0cf43ae0562547c51d001eb14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156936
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b3fdd999f87312447d03915585812b3a5cd48141]

        unfold SwFEShell::IsShapeDefaultHoriTextDirR2L to something readable
        
        return early on not meeting each successive condition
        
        Change-Id: Iad6c9f8a0a2f2c578609f7584a86c553d75c0792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [105d1c010c4dc3caedf66a2080045c9c5f6fb9e3]

        crashreporting: apparent null deref at SwFEShell::IsShapeDefaultHoriTextDirR2L
        
        https: //crashreport.libreoffice.org/stats/crash_details/73028951-19a0-409b-89d2-a080495df925
        Change-Id: I440465a3c7d5b98ecdd1c5f1973a2b8f64d6772e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [31a7e0e46fe9bde0d68eabcc185ffccb931f9f7e]

        Fix typo
        
        Change-Id: I69213830616ecb2532e4b34dbcc14c0241219f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156928
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a32d49bdf1b3f642188b46d2bd7e1bef135edc6d]

        Fix typo
        
        Change-Id: I94b00910d261731b712f21a92766d97fed4889a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156927
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b34359bcf2f387bc250411a3b78ffcde88329b0e]

        nFrames can't be trusted to believe nSequence exists
        
        Change-Id: Id4745487c97ce89fcf149676c15a974e40ee0eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0aa3e40a733230ae439c98244f6db2f97ede1b01]

        ofz#62352 Null-dereference READ
        
        Change-Id: Ibf8aa63a6d63809b361902b853dabd8ff0944503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9951748c1a877f189fc145f87d8e6f3024c40ee6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 83cb5551ff5ce81e38396856c0c0595536815d9b
          - tdf#97551 Help for cell formula indicator and hint
            
            + refactor
            
            Change-Id: I93f762f301210dd7db6687058af494773f149889
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156930
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [9bd14aef0895e7d3cc709f96bc7b284877b35576]

        remove some unnecessary dynamic_cast
        
        Change-Id: Ic2ce9ec8fbe9e61216f8785e7ebfb4a0377b3328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156923
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e46162c8bf196e0b3ec83384b99db9c7ee3f8db9]

        simplify some exception throwing
        
        Change-Id: I28d6e221443bb0a39d7dd90c6db16c9de2ac452d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [cbaa4d3f27aa458142b0eeca88053d7fac3cce4d]

        remove some unnecessary casting in SwXText::createTextCursor
        
        Change-Id: I3dc1c9839b6ac34244d3afcaa8bf4795ce765951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5dae4ad45be14ea5ab29308f024b8ea1dc1a02e9]

        check-missing-unittests: change to dump JSON
        
        Change-Id: I697db0cb18e0a5119be74486a2258dfb35161c04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156667
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2023-09-14  Adam Seskunas  <adamseskunas@gmail.com>  [046cee10e62993238534c68e33d97ed63067b290]

        tdf#145538 Change traditional for loop to range based for loop
        
        Change-Id: I6c589c588a363cf09a1e6ae79a48911e23cbcf28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156676
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2a0530a26b5c5b5f48d3e3c695b839d0e5c0164]

        fix use of reference
        
        where we may end up with a reference to a different element of the queue
        than we want.
        
        regression from
            commit 31e66bd07c1082bb375be8aaf7835f019351d9bb
            Author: Michael Stahl <Michael.Stahl@cib.de>
            Date:   Mon Aug 6 19:03:22 2018 +0200
            sw: fix ignored frames in AppendAllObjs()
        
        Change-Id: I94801df84b4b130315f67292851fbd129b2fe7d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156919
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-09-14  Michael Stahl  <michael.stahl@allotropia.de>  [c57f9b67aa9735f8dcf966a8110ba9998353068b]

        flat-odf-cleanup.py: remove theme
        
        Change-Id: I326a4af0f7f6a910fb51b67f6872c49b1d56bd5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156918
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-14  Stephan Bergmann  <sbergman@redhat.com>  [eb2e7483727c060b0aa735f401aaa89cc0505200]

        Improve Plugin::checkIdenticalDefaultArguments
        
        ...to avoid
        
        > In file included from /home/sbergman/lo/core/cui/source/factory/cuiexp.cxx:20:
        > /home/sbergman/lo/core/cui/source/factory/dlgfact.hxx:524:116: fatal error: TODO: Unexpected 'IdenticalDefaultArgumentsResult::Maybe' [loplugin:overrideparam]
        >   524 |                                             const OUString& rName, const OUString& rDesc, const OUString& rTitle = "") override;
        >       |                                                                                                                    ^~
        > /home/sbergman/lo/core/include/svx/svxdlg.hxx:380:116: note: TODO: second argument is here [loplugin:overrideparam]
        >   380 |                                             const OUString& rName, const OUString& rDesc, const OUString& rTitle = "" ) = 0;
        >       |                                                                                                                    ^~
        > MaterializeTemporaryExpr 0x7f6fd76d4218 'const OUString':'const class rtl::OUString' lvalue
        > `-CXXBindTemporaryExpr 0x7f6fd76d41f8 'const OUString':'const class rtl::OUString' (CXXTemporary 0x7f6fd76d41f8)
        >   `-CXXConstructExpr 0x7f6fd76d41b8 'const OUString':'const class rtl::OUString' 'void (const char &[1], typename libreoffice_internal::ConstCharArrayDetector<const char[1], libreoffice_internal::Dummy>::Type)'
        >     |-StringLiteral 0x7f6fd76d3e48 'const char[1]' lvalue ""
        >     `-CXXDefaultArgExpr 0x7f6fd76d4170 'libreoffice_internal::Dummy':'struct rtl::libreoffice_internal::Dummy'
        > MaterializeTemporaryExpr 0x7f6fe30b5f58 'const OUString':'const class rtl::OUString' lvalue
        > `-CXXBindTemporaryExpr 0x7f6fe30b5f38 'const OUString':'const class rtl::OUString' (CXXTemporary 0x7f6fe30b5f38)
        >   `-CXXConstructExpr 0x7f6fe30b5ef8 'const OUString':'const class rtl::OUString' 'void (const char &[1], typename libreoffice_internal::ConstCharArrayDetector<const char[1], libreoffice_internal::Dummy>::Type)'
        >     |-StringLiteral 0x7f6fe30b48f8 'const char[1]' lvalue ""
        >     `-CXXDefaultArgExpr 0x7f6fe30b5ea8 'libreoffice_internal::Dummy':'struct rtl::libreoffice_internal::Dummy'
        
        after c7a608a6691c790783c63f504010bc796c36af25 "tdf#155503 Add title to document
        title dialog" in an --enable-compiler-plugins=debug build.
        
        (Instead of trying to inspect deeper into the code that compares two
        StringLiteral directly in Plugin::checkIdenticalDefaultArguments, it looked
        simpler to just extend structurallyIdentical.)
        
        Change-Id: Ie1eecff210413f0a29213d867aad249420c1c278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156916
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2b9f5a7929910951a72372c8d56fcae605146477]

        Fix typo
        
        Change-Id: Ifb3a875b0079f43d5b0f121992ca66180beb2ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156913
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-14  Mike Kaganski  <mike.kaganski@collabora.com>  [5bf7c2fa57946cc3323a1d4ee1b2f31d805ae06f]

        Fix --disable-curl build
        
        Change-Id: I3020d41eb6d0988cc886495a88a073a23bc8161c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156910
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-14  Heiko Tietze  <tietze.heiko@gmail.com>  [1d4cd39262fb71f72311e33ac2bdb7d925be5d98]

        Related tdf#157006 - Remove global compatibility options
        
        Clean-up the UI in favor of the advanced options
        
        Change-Id: I11ffa643fc577e7eee41f42bd3e16fb290202f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156911
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bbd1cae866630e1545b603b2b31417713d63d226]

        sc: add test for the row import default index issue
        
        Change-Id: I09f94977602122ac751cc64dc7c3cec1a954aea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156901
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [39dc34d33bb01f595fbea214bf3ea315cea5f707]

        tdf#157231 CVE-2023-4863 upgrade to libwebp-1.3.2.tar.gz
        
        Change-Id: Ib60466a59069b59fa884654167f33ccc58e59330
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9f03538b439472b4fba3427c32e61c4e4e7fc2ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to be4de7018027689a105e8cf60f30bf2ce46690a4
          - Typos
            
            Change-Id: Ied4fc30f8f8b27b94bd7dbf699b5f5d48ecba38f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156886
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [0ff322adfecec99751b249bac0c75b02ac570bf0]

        Latest VS 2022 Preview is 17.8.0 now
        
        ...while latest proper VS 2022 is 17.7.4
        
        Change-Id: I949913ffd79a338b2792ad9baa88532a1406cf4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156820
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-14  Miklos Vajna  <vmiklos@collabora.com>  [d50e5d6d53c94124f825758a74e186b934fc2a4e]

        Related: tdf#55160 sw floattable, nested DOCX exp: fix inner tbl at cell start
        
        A cut-down bugdoc had an inline table, and an inner floating table,
        anchored in the start of the C1 cell.
        
        Exporting to DOCX resulted in a layout that looks like the floating
        table is not anchored inside the outer table anymore. Checking the
        markup, the floating table was written between row 1 & row 2, which is
        not a valid position for a floating table. Probably the intention was to
        write the floating table before the first paragraph in C1.
        
        Fix the problem by still writing the floating table in
        DocxAttributeOutput::StartParagraph(), before opening <w:p>, but do this
        after opening table/row/cell, which is late enough to have a correct
        anchor but is early enough to be still outside the paragraph.
        
        The import side of this still needs fixing.
        
        Change-Id: I1827b2def1faaf53312522f5a8415fbe697fcb8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156904
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [016f3aea1e1a3731f925a3f8e7e5a92fff3ef28d]

        tdf#106663 - Fields: use the starting position of the frame
        
        instead of the length of the text in the frame. Otherwise,
        the searching position is after the first field,
        e.g., "Heading x1", where x1 is the field and the postion
        of the index would be at the end of the paragraph.
        
        Change-Id: Ifb48bfea09e29c6263f4f81190643a88b0f57aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156894
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-14  Miklos Vajna  <vmiklos@collabora.com>  [297e0b6bdd6fb682974f9e3201c7842dd76e31c8]

        crashtesting: fix PDF export of forum-mso-de-118466.docx
        
        This went wrong in commit 19a559b0ec9b806519c405651d6d2b2e14712b4a (sw:
        SwSubFont::GetTextSize_() assert on presumably dead code, 2019-10-14):
        
        - as the bugdoc shows, it's not dead code after all, so downgrade the
          assert to a warning
        
        - SwDrawTextInfo::SetText/Idx/Len asserts that the index and length are
          valid for the text, so set / restore these together
        
        Change-Id: I967605324bde757ca11e6684ba6f40c578a211fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156891
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cc72fd4fc493b34cacc50fe8b390bcaf8a299904]

        Fix %PRODUCTNAME in security dialog.
        
        Change-Id: I9d14fe3abf3226a32392c24b5362b9cd41d58afe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156860
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-14  Patrick Luby  <plubius@neooffice.org>  [4942aa1533af25cf102da7516bd5e521c553aa07]

        tdf#156808 force an alpha mask to be created even if it has no alpha
        
        We need an alpha mask, even if it is totally opaque, so that
        drawinglayer::primitive2d::ProcessAndBlurAlphaMask() can be called.
        Otherwise, blurring of edges will fail in cases like running in a
        slideshow or exporting to PDF.
        
        Change-Id: If03b32a8a22ed960f1475710a9831cab33799b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156903
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-13  László Németh  <nemeth@numbertext.org>  [d23ba9e6103bba27b57c59505641cc64db63ec98]

        tdf#157187 sw tracked table column: fix DOCX export
        
        DOCX export of tracked table column changes
        could result dummy content boxes and missing
        tracked table column changes in MSO, i.e. lost
        interoperability. As a workaround, skip
        exporting content boxes within tracked table cells.
        
        Note: bad 0x01 characters and incomplete w:sdt export in table
        cells since commit b5c616d10bff3213840d4893d13b4493de71fa56
        "tdf#104823: support for sdt plain text fields".
        
        See also commit 4697d2bda1b37f9cf8b301f5bf044c2390f56333
        "tdf#157011 sw tracked table column: fix DOCX import of empty cell".
        
        Change-Id: I32f77c7532a9cc6bf5d88a626ac3c62a5c02a34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156895
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [92d0fa8c3a7998e51c8f27409ed8c44f34c42c8e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 04a7d6325b3a472b36e4509f41c381ab36e83d05
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I948f10ddd4075b838a75adb8c73c5c4d1fb1f7cf
            
2023-09-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bcb3e9c54441fd47d673774583f573d391556866]

        tdf#157223 get sequence name before toggling checkboxes
        
        The expectation is that setting state/values on widgets from code
        doesn't trigger any callbacks, which are assumed to be from user
        interaction only.
        
        But explictly toggling on a radio implicitly toggles off the other
        radio, and while there is no callback from the explicit toggle on,
        there is from the implicit toggle off.
        
        Just move the explicit toggles to the end, after where the
        values are read which the callback affects.
        
        Change-Id: Icfc2c94950be671d6fc23789584b4d3c6e5395d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aa4efca9458da39cef6cadb710a0d31d60d4e68f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dab0c782e5d051741a7a3b103a55ae591783b627
          - tdf#157180 DDE links works in Linux and Mac
            
            Change-Id: I764d477d7e2505ca44f97f5bf82cedbdee0efab4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156880
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f4ccc63346b26d8d774b22124da0842ef18e0bc]

        tdf#156995 speed up dragging complex group objects
        
        These shaves 20% of the time of the construction of the "drag view"
        object. Of course, it is still heinously slow.
        
        Change-Id: I4c6ee2d7e0cc2030a9966a281d2fdbe7f6859289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [747a9838ee53a4d2c005729419047b1ffde0db70]

        loplugin:unusedmethods
        
        Change-Id: I00f228451574ca9f9e352d233c7f326c88e90a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Khaled Hosny  <khaled@libreoffice.org>  [32d2e001bb056e7d98aa143b222f2721967337dc]

        tdf#101174: Don’t hard-code OpenSymbol font for predefined special symbols
        
        Leave the format empty and use the variables font instead.
        
        Change-Id: I3e3cdf40dc285dee7375054e85b4a2bed352eb66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156855
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-13  Khaled Hosny  <khaled@libreoffice.org>  [e9cc014be4150a5adc9950f366c9bdfa50420dcf]

        starmath: Hide editing window by default and add a menu item to show
        
        We are enabling inline editing bu default, so this window is of no
        interest by default.
        
        Change-Id: I66fe988790fe4f174f6cb4f691af69888b0b05b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156852
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f3031b33a16cf11045006616b01dd89d6d59a32]

        Revert "loplugin:unodispose in binaryurp"
        
        This reverts commit 3d9f9b1b299251c5c28d74e951b4447193ad7ade.
        
        Reason for revert: comment from sberg:
        
        I'm not convinced that a general rule of "clear all references in dispose()" is a good idea.  For example, in this class, access to connection_ and provider_ is not guarded against MT-races, on the basis that those two are never modified post construction.  That is broken now.  Also, e.g. Bridge::getDescription dereferences connection_, and benignly used to work fine even when called on a disposed instance.  Now, it causes UB.
        
        Change-Id: I6039d5b1488146f09439312800ceb1de3cfcf0ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156878
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Miklos Vajna  <vmiklos@collabora.com>  [5127b1961b762643d47a26704556fd9b8664c6fc]

        sw floattable, nesting: add DOCX import
        
        There were two problems here:
        
        1) writerfilter/ didn't even try allowing split floating tables for the
           inner case, because layout didn't support that previously.
        
        2) CppunitTest_writerfilter_dmapper's test3NestedFloatingTables crashed
           because we expected that in case a fly+table is not toplevel, then
           the parent is also a fly+table frame, but in this case the parent was
           just a table frame.
        
           Fix this by checking for a table parent instead of a fly parent when
           deciding if we handle the split as a nested case or a toplevel one.
        
        Change-Id: I4c58636ef80371b8ec51a96fe436fa6379c795d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156865
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa0e4fa0154b15fa1c04495562d08b4490ec984b]

        loplugin:unodispose in editeng..extensions
        
        Change-Id: I6545cf93b0a101d3a3eea0abe9c1732fcf3dc2d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156850
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [7bbe6602552fc7691bbfee8e9e31489fbd906140]

        loplugin:unodispose in dbaccess
        
        Change-Id: I7a28204ababc9fec4e90ccbd2f0a485d6bc8d560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156849
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d9f9b1b299251c5c28d74e951b4447193ad7ade]

        loplugin:unodispose in binaryurp
        
        Change-Id: Iab83b304ab7928dc4ca88a90f3184e2b2e7bf741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [fdef35f01e80df0b35bafc0faed285b3838474a8]

        loplugin:unodispose in comphelper
        
        Change-Id: I0f23916204fd6d96b2b1641effe693cb0764f630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156848
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-13  Szymon Kłos  <szymon.klos@collabora.com>  [b33c175233ef6a9754fc4af647d82b9a51871a22]

        lok: fix notebookbar not initialized when switched from classic mode
        
        This is revert of "tdf#155720 remove old skip notebookbar init workaround"
        This reverts commit f95b5d12c59e612ee4643b385389fc791e31f76d.
        
        Mentioned change introduced regression in loading notebookbar.
        
        Steps to reproduce bug:
        1. be sure cool is in classic/compact mode
        2. restart the app so it will load in classic mode
        3. switch to tabbed mode
        
        Result: notebookbar is not initialized and style previews
        and font selector are not present
        
        Change-Id: I35d6682cdd6c028437b373a748ed9ec36418ac17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156836
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit c0234520ba9afda5a8b32f7a04c2155cbfbe30ed)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156875
        Tested-by: Jenkins

2023-09-13  Miklos Vajna  <vmiklos@collabora.com>  [3ad4fd34ce1d4ff5f052bee8857c38582ff3e4fd]

        CppunitTest_sw_odfexport: fix outdated comment
        
        There is no preTest() in this suite anymore.
        
        Change-Id: Iffbaa4d77ede557e5cab2e85cdf4272ffd1888ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156856
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3396d0aace6fe6a280af9e18c07749250c74ca40]

        Fix typo
        
        Change-Id: Ib76e9bf09a607dc79bd9ae083927af6124471e1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156834
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3020dfbee490761e7192668f39e65989dd2b1a50]

        Fix typo
        
        Change-Id: I1ede635acbbe3a4e18d5b9a90be19a04292f662e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156859
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-13  Julien Nabet  <serval2412@yahoo.fr>  [93c5885dad3343f3d1a55e33bf83fecd1fed8cab]

        svx: prefix members of SaveGeoData
        
        See tdf#94879 for motivation.
        
        Change-Id: I9ba78fdbb7f2390f43e3315c8cdf86c56f96f478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156863
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-13  sahil  <gautamsahil1947@gmail.com>  [bf81be2641e8c66d78374289497b117fe3dfb024]

        tdf#90341 Clean up excessive const_cast'ing
        
        Change-Id: I5e3cc14ed75309d0569a4bad710e7adea007329f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156807
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-12  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [43df1237a091e2b0f4495d5a7e959f7beaab025d]

        remove repeated idl file in gb_UnoApi_add_idl_files call
        
        XConditionEntry was repeated twice on line 3498 and 3495 of
        offapi/UnoApi_offapi.mk
        
        Removed the first one.
        
        Change-Id: I7dd7db3c527a2a6825363ba4fb24eb266f870f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156857
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [fb07dcf993bd3ff7880b26414e4095560c296d8b]

        tdf#149545: increase svg check size
        
        otherwise it will fail to open documents like the one in
        tdf#149545 with long comments before "<svg"
        
        Change-Id: Ia46dad92052ae4ef7fee791098bf96df03257282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156844
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-12  Patrick Luby  <plubius@neooffice.org>  [798de29936b9a0c618bd31629936a4c836429e90]

        tdf#157086 invert the blur mask instead of the alpha mask
        
        An invert is needed to fix tdf#156808 but inverting the alpha mask
        causes tdf#157086 so invert the blur mask instead.
        
        Change-Id: Id695d04f008932caadb0fc2b477b0a4b152fa66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156854
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0da88ee88255083ec9557ff25005a745dcdbef14]

        sc: row import - default style index is 0 and not -1
        
        When importing CT_Row structure, the style index is 0 by default
        and not -1. The effect of this is that the style is not applied
        for the rows, because the index is -1. With the change to 0, the
        style applied is the first style, which is the correct behaviour
        and this fixes the issue with the test document.
        
        Change-Id: If5ab571e8dd7ec1319e7cb4d26ba006ca827eca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156845
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-12  Dan Horák  <dan@danny.cz>  [6d24e32d0278e1e71cbd1bfdc16899659e47b2a2]

        bridge/powerpc64: fix integer ABI
        
        The ABI document for PowerPC64 specifies that integer values shorter than
        a doubleword are sign or zero extended as necessary. Until now the smaller
        values were treated as unsigned values and only zero-extended. Handling of
        signed values was incorrect.
        
        Change-Id: Icbbe8fc8d4facfa6d1b3252c99ec2d8c2552d9f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156847
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [cdf4b60e3ed8beafc573ed9741a7828e299f14cc]

        add a unit test for AlphaMask::BlendWith
        
        Change-Id: Id4602470292d0ba66601c5d2446a06df7e4b508b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2f6b4fcd380e227a8767f08b3b4853db5743db40]

        Update git submodules
        
        * Update translations from branch 'master'
          to c58409eff8ea9a29f723db6dfc69a1700a1807cc
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I7215d39a88ed28dba327b4d13bc0e464210addcf
            
2023-09-12  Dan Horák  <dan@danny.cz>  [f171d5cb322ed99b3c4cd6c0b18abbf03882ec98]

        bridge: modernize printf debugging in powerpc64
        
        Use correct types and also typecasts to avoid compiler warnings.
        
        Change-Id: I3b58ec6a4be54ecd8bc07a7febbaf721eba9b945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156846
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-12  Gökay Şatır  <gokaysatir@gmail.com>  [62cc2217217650d23c72e4646ccd793f76722d94]

        Added parent / child relationship to comments.
        
        Adding parent name of a comment into odf file when there is a parent.
        
        Also includes:
        
            Added test case to comment property test.
        
            Change-Id: I033f6574b4875fcb76b16c8b5b9d9f7d55b52cbe
        
        Also includes:
        
            Add parent / child relations to replied comments.
        
            Change-Id: Ia7d95c4e6020b501798a89cbdcae64dc5691437c
        
        Change-Id: I08b5ab6eb11adcafcbf3559896d79d41b449b26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156824
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-12  Dennis Francis  <dennis.francis@collabora.com>  [b8f6f91f476f1c3f93bb44265381305f6f02b161]

        sc:pivot allow sort by selection in non-manual mode
        
        Otherwise it is currently impossible to sort a field by its data
        summarization values.
        
        The RadioClickHdl is now doing nothing hence is removed with this
        change.
        
        Change-Id: I76064ce05e5b996ad96f596524be351708ef35e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156747
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [43677cb0d95de06bea0f08e87ccfa3230dc8bd6b]

        Resolves: tdf#157148 spelling dialog sentence box has no scrollbars
        
        Change-Id: Ia1a7c2d73b0a5406ce3b08c4729e85ad724b44ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [1d76dccefa895c251bdcc612c046b42aef61a34b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cbc8df1f326c1ddc4b2785a62b87766a24c3f88a
          - correct heading for Table of Figures link
            
            Change-Id: Id9da26d7950b35775013e7005d2d50ff4beae83f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156749
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9cef1d069a21cb821b1ef880da0358aa2a959a40]

        loplugin:unodispose in UnoControls
        
        Change-Id: Id3cc80804b982cec04e288d0709c5d402e69860d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f05605997ffcfbf3b7969f565556a261c8e61a42]

        loplugin:unodispose in accessibility
        
        Change-Id: I7e4f464c9130318c8b10d8e00e01ce4b6c05e06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-12  Khaled Hosny  <khaled@libreoffice.org>  [aa396ee162ee0eb223c90ab4f9bd55014cf94775]

        starmath: Keep focus on math widget when inline editing is enabled
        
        Since originally all editing happened in the edit window, it was made to
        grab focus instead of the math widget, but we don’t want that anymore
        when inline editing is enable as we want to edit everything in the math
        widget.
        
        This also removes ancient test that is now failing. We will eventually
        drop the edit window altogether.
        
        Change-Id: Ia1628a454bbbdd923ff582564eca1ab4ec830f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156579
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-12  Patrick Luby  <plubius@neooffice.org>  [26313599b0eae3b397bb341c63d185f8771af82d]

        attempt to fix macos jenkins hangs - part 3
        
        oox::xls::WorkbookFragment::finalizeImport() calls
        AquaSalInstance::DoYield() with bWait set to true. But
        since unit tests generally have no expected user generated
        events, we can end up blocking and waiting forever so
        don't block and wait when running unit tests.
        
        Change-Id: I14cfdb88f04b82f49e8c15e554e5c4b4053e77b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156826
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [765ad727ebf11e645b4237179d75491a65e04da6]

        resave with latest glade
        
        Change-Id: Ie0109410c338764f5a138822053f8de232b1b319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156838
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6a77594f380b596371a0a036a1e229e02e8666b9]

        ofz#62155 skip line with negative width
        
        Change-Id: I5549ac15a179051f6fb02786c53469479b0a2e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156839
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b65c770d095f1c3c6ae68df699b2055a4596fe5a]

        tdf#157148 ensure we auto-scroll to current location to make it visible
        
        Change-Id: I03286c10e488adf3a882fa7fe2813724f27c66f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Gabor Kelemen  <kelemeng@ubuntu.com>  [f9f5f80c758ca5f690827bc045b8ef66e16a46a2]

        tdf#157101 Make Area dialog narrower
        
        by turning off the homogeneous setting of the top button bar
        
        Change-Id: I1e2e4f4db04c4a061c4e699a32b51997495880a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156804
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-09-12  Miklos Vajna  <vmiklos@collabora.com>  [2887e6b8edbb4fdb093515a3a68269ed40e42116]

        sw floattable, nesting: fix DOCX export
        
        There were two problems here:
        
        1) DocxAttributeOutput::StartParagraph() didn't try to export an inner
           floating table as a floating table, resulting in writing a shape that
           can't span over multiple pages.
        
           Dropping the !pTextNodeInfo check should be OK, we'll just now
           clear the m_aFloatingTablesOfParagraph list at the end of the outer
           table.
        
        2) Once we tried to export the inner fly, the actual table/row/cell
           start was missing, because m_tableReference.m_nTableDepth wasn't
           reset, so DocxAttributeOutput::StartParagraph() didn't know it has to
           emit a table definition before the first para of the table.
        
           Fix this by stashing away the table state before the inner fly's
           export and restoring it after the inner fly export, similar to how this
           is done in e.g. DocxExport::WriteHeaderFooter().
        
        This is related to tdf#55160.
        
        Change-Id: Ib860283d32e392e2906aa12bc9eb61b5af5ca8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156833
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [af11de36dc30df8f3f66cee7be836b6250bae4f5]

        tdf#154063 allow autocorrect GtkTreeView to shrink
        
        It will allow shrinking if there is a horizontal scrollbar.
        
        We don't actually want to show a horizontal scrollbar so use "external"
        which vcl will ignore, and gtk not show a visible scrollbar but
        allow scrolling. So when we shrink it will "scroll" and the resize
        handler sets the column widths as we want and it works out to behave
        like vcl does.
        
        If this fails to work out for some reason we could put this inside
        some other container which can shrink as an alternative solution.
        
        Change-Id: Ic7e3ab4bff344f4ed5c1a6317644e697c9cfc395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5f418077a9e257f66ab78a695e6bd73891a43e2]

        resave with latest glade
        
        Change-Id: I7a721aec05f8d96d9c7ecc6c6a8e863e2265c1d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-12  Miklos Vajna  <vmiklos@collabora.com>  [8232cae49bc20ddff3047c363233e85c407055aa]

        sw: document SwFormatField
        
        Note that SwField is abstract, so in practice this always wraps a
        subclass, e.g. SwPageNumberField has an actual ExpandImpl() definition.
        
        Change-Id: I579cc9f2f9d1f64885512bceabc2fc684b8c3701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156828
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-12  Julien Nabet  <serval2412@yahoo.fr>  [01d7bd4f08cf05dd44b1239287451c52a965e343]

        svx: prefix members of SdrObjConnection
        
        + modify GetObject() into GetSdrObject()
        + modify pObj into m_pSdrObj
        The goal was to be a little bit more specific since they concern a class and not a local function.
        
        Change-Id: I1b3f19a16a452f22af82da22e33cd2f1522e1a7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156832
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-12  sahil  <gautamsahil1947@gmail.com>  [f5bcc34580d02f92af01963155f2d54776a5249b]

        tdf#114441 - Convert sal_uLong to better integer types
        
        Change-Id: Idc6de0c0275ce9913e248548466b77aaef180d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155873
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-12  Jim Raykowski  <raykowj@gmail.com>  [4b2543693ed3ffb4d9f0d70f53f32127115c128d]

        tdf#156890 SalInstanceTreeView: Indent the entry context bitmap
        
        when the bitmap is too large to center without it touching the expand
        button
        
        Change-Id: If4e307ed50eff9bdebe6c377847283ae2eea9543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156787
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-11  Khaled Hosny  <khaled@libreoffice.org>  [d52feb11c7eab0adf82c1fb410adfd3127bf9497]

        starmath: Fix selection of surrogate pairs in inline editing
        
        Don’t split nodes in the middle of surrogate pairs.
        
        Change-Id: I3ce8cf19d4c331e2ead73ed375745e8866b3d7a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156827
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf11a197519f6637b5a4f1f42436c2c9f262ef97]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c666c14f61cdd4ac0cb77aba41dd7887ce7698c
          - tdf#155875 UI cmds Writer/Table in Help(42)
            
            + refactoring
            + Table - Formula
            + Table - Sort
            + Table - Properties
            
            Change-Id: Ib68a5aa59ff628c52c53a6abb0583143e5a0c59e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156829
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d30f9c74201880b62c51dc8c456a59a89b70d7da]

        remove dead m_bCancelOperation flag from XMLFilter
        
        has always been ignored
        
        Change-Id: I272ca7026ddf25fbc679e7933ea23986466ad70b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156822
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Stephan Bergmann  <sbergman@redhat.com>  [0867f7f3a955549079722d61e0c13e233e0af150]

        In test, use char from older Unicode version, supported by older ICU
        
        3af30bafbedb8eb481024efb35cb7876c63d26dc "sw: Handle surrogate pairs when
        tweaking script info" had added a test involving U+10EFD ARABIC SMALL LOW WORD,
        which was only introduced in Unicode 15 (cf.
        <https://util.unicode.org/UnicodeJsps/character.jsp?a=10EFD>), which is only
        supported since ICU 72 (cf. <https://icu.unicode.org/download/72>).  But at
        least the Flathub builds with org.freedesktop.Sdk//22.08 are done against
        ICU 71, and those builds failed with
        
        > Test name: testScriptinfosurrogatePairs::TestBody
        > equality assertion failed
        > - Expected: 11
        > - Actual  : 11◌
        > - In <>, attribute 'portion' of '//txt[1]/SwParaPortion/SwLineLayout/SwLinePortion[1]' incorrect value.
        
        U+10A01 KHAROSHTHI VOWEL SIGN I appears to be a character with similar
        properties (it would make the test fail in the expected way when
        sw/source/core/text/porlay.cxx is rolled back to before
        3af30bafbedb8eb481024efb35cb7876c63d26dc), but is already present since Unicode
        4.1 (cf. <https://util.unicode.org/UnicodeJsps/character.jsp?a=10A01>), so
        should be less problematic.
        
        Change-Id: I61f6e32069b895720cbee5e3d2ce1295727cfd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cea165a3ebdb5f2a2b172004ff1b3848f303d78a]

        gbWatchdogFiring, replace 'volatile bool' with std::atomic<bool>
        
        this can be touched from different threads, so atomic is a better
        tool than volatile.
        
        Change-Id: I7304eb50cf565efc4322871e56d21eb4128c4a8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156821
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [89efaa6e770ccbc65c498f2a688c90a94a365a3d]

        SvxSimpleUnoModel does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I54b6d8224bd9d996781cfac6cf9846721a8c5d3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Noel Grandin  <noelgrandin@gmail.com>  [f53ed5e832289560a75e685ededb66732fa16659]

        AccessibleListBoxEntry does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I92ec69dfab2aa5eb2acbb9804359853ffc27e565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Noel Grandin  <noelgrandin@gmail.com>  [0c4cdb001fa95252e4b5c1e78dcaaa082511e8b9]

        accessibility::Paragraph does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: Ic0e9e3d58792fb21950a66253176eba413861600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [5f7a3126fcad1b490b6e1ef6775b31bac99f3c18]

        ITEM: Diverse further changes/cleanups/preparation
        
        Added a counter for SfxItemSet usages, similar to the
        already added one for SfxPoolItems to allow quick info
        about evtl. problems/drawbacks of changes.
        
        Replaced enum SfxItemKind in favour of settable boolean flags
        directly at SfxPoolItem. These are organized as bitfield, do
        not need more space as the enum and allow to be set separately
        and multiple ones at the same time.
        
        Flags for PoolDefault/StaticDefault/DeleteOnIdle use this now
        and are quickly accessible booleans. It is not a problem that
        theoretically the flags for PoolDefault/StaticDefault could now
        both be set - this is internal to SfxItem stuff and not accessible
        from normal code, so can be managed.
        
        Added for debug build a bitfield boolean m_bDeleted
        that will be set in the SfxPoolItem destructor. Of course
        it's usability will depend on the freed space not yet being
        re-used, but will hopefully help in the debugger to detect
        reasons for failure (would have helped at least me before).
        
        Added for replacement of virtual method IsVoidItem() another
        bitfield bool m_bIsVoidItem that is set in the constructors
        of SfxVoidItem. Also had to add some constructors to do that
        which were defaulted before. This is mainly because the base
        class SfxPoolItem does *not* have a copy-constructor that
        copies the members (flags/RefCnt/WhichID) and we should keep
        that 'indirect reset' when Cloning. isVoidItem() is now a simple
        boolean member access - the bitfield does the needed masking.
        This spares one entry in the virtual function table of
        SfxPoolItem which is derived more than 500 times.
        
        Used the results of the experiment at
        https://gerrit.libreoffice.org/c/core/+/156774 to change
        some accesses to IsVoidItem() to use SfxItemState instead.
        This is for preparation of splitting up the two usages of
        SfxVoidItems, see commit text in the experiment.
        If this shows problems in the future those six places documented
        there may have to be changed back to use the new isVoidItem(),
        but should also check the ptr this time to be non-zero.
        
        Removed SFX_ITEMS_SPECIAL that is no more used anywhere.
        
        Change-Id: Ib687ca2362d72a4651c75aee0c67029088f68947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156805
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-09-11  Noel Grandin  <noelgrandin@gmail.com>  [dfd890c414352b1abab62d6a38bf45561bb874ab]

        VCLXAccessibleList does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I561af7931b5863857311df3cd6c3a85ad494f578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156799
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Noel Grandin  <noelgrandin@gmail.com>  [8d98273dab1a31243801614ec4b07ac7f2e46349]

        SvtRulerAccessible does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I49e2c013c82687b71d0b442662ca9de229d0dddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Szymon Kłos  <szymon.klos@collabora.com>  [888e20f8fadf570b8fa6d07a6cd208f2fa8921a1]

        svg: export text decoration for text run not paragraph
        
        Previously we exported text-decoration and other properties
        for whole paragraph what was overriding run properties.
        So we reused properties of the first run for all other runs
        in the paragraph.
        
        Change that so we write font properties for individual runs only.
        
        Change-Id: Ie30f0166132b2ee302d0fdd12e7eb3ee36766a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155348
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156814
        Tested-by: Jenkins

2023-09-11  Szymon Kłos  <szymon.klos@collabora.com>  [359190cb6ae2c76356de7f9368abc849c7696415]

        jsdialog: fix layout of chart type dialog
        
        directly set content area container to avoid
        buttons on top of the dialog in lok case
        
        Change-Id: I8353102f679a8f19c3041c7b4ec0b1200ed7d515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156254
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156813
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [819dec3533750a3a8f483351febe40aae85ca0b7]

        tdf#157173 Enlarging Fontwork shape replaces used font
        
        regression from
            commit b153d147c9d813f78dd551fc186c261f52c929a1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Apr 28 15:27:14 2021 +0200
            remove support for BITMASK in vcl backends
        
        So the code that I removed had
            if (meFormat == DeviceFormat::BITMASK)
                SetAntialiasing( AntialiasingFlags::DisableText );
        in the
            VirtualDevice::ImplInitVirDev
        method.
        
        Possibly we will need to make similar fixes in other places that used
        BITMASK, but this looks like the only spot that really needs it.
        
        No idea exactly how this line of code relates to the observed bug
        though.
        
        Change-Id: I858f15cf70a452568128d5ccccb365d9a11f7062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Noel Grandin  <noelgrandin@gmail.com>  [8b08885042d93aa1e0884fe9197a161a36d54267]

        AccessibleIconChoiceCtrlEntry does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I80459b404d610847395d2eae4d529a808c53f3d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-11  Szymon Kłos  <szymon.klos@collabora.com>  [1d50bbc8df0b9b1cad16bccc835f1aecfdf2abfb]

        lok: don't prerender font previews
        
        Change-Id: Id83a6804f658d56793913b8e8e07f7ec1f2ff82a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156116
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156812
        Tested-by: Jenkins

2023-09-11  Miklos Vajna  <vmiklos@collabora.com>  [c8c42754ca8adf2b909261fde01fb3dbad8d50c0]

        svx: prefix members of SdrHdl
        
        See tdf#94879 for motivation.
        
        Change-Id: Icd2be0663b7b498bb06f09ced97673244e328a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156809
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-11  Miklos Vajna  <vmiklos@collabora.com>  [e20bacc209a8e8483209cb4ec51c9e0b55423cdb]

        sw floattable, nesting: fix overlap support
        
        The bugdoc had a nested, split floating table with overlap=never and
        that lead to a layout loop.
        
        The root of the trouble seems to be that the inner fly will obviously
        overlap with its outer fly but we tried to prevent that and we failed.
        
        Fix the problem by ignoring inner flys in
        SwToContentAnchoredObjectPosition::CalcOverlap().
        
        This also allows removing special handling of nested split flys in
        lcl_ArrangeLowers() and special handling of split flys at an other place
        in the same function, because now the non-bDirectMove case works out of
        the box.
        
        Change-Id: Icf3a8f776aa758ef4ae2c2994a7216c5a6142a62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156810
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-11  Justin Luth  <justin.luth@collabora.com>  [6a24155269d26d1a31a88158154bb4db0c933871]

        tdf#137595 sw: current fly might not be selected
        
        Likely true with draw flies.
        
        In the noticed cases, sometimes the fly would be selected
        (and then things worked as expected),
        but if it was not selected or if the fly was changed,
        then it just became the current fly, but not selected.
        
        So, check for both. Since this function already occurs,
        likely this draw/writer synchronization has already
        bitten a lot of cases. Here is one more...
        
        Change-Id: I238027489e6e2cc49e7503c1f93779d1e96dbdcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156786
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-10  Patrick Luby  <plubius@neooffice.org>  [be9d7bee88eff89c0d361f23abb447ac2086c3b4]

        attempt to fix macos jenkins hangs - part 2
        
        Commit a1174a5f1e312ebb98c3941d35287a8ffcb368e9 attempts to fix
        sporadic blocking and waiting when fetching a native event so
        use the same fix in AquaSalInstance::AnyInput() just to be safe.
        
        Change-Id: I1505b6089f11be825bd13e0219a305159dfc324f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156803
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-09-10  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [aa1ab7d3b7646ee5d5ee879b5faaecf620969958]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bb07bc0599affc52cebc346ddc330fb61b496462
          - tdf#154872 Add Poisson distribution entry to documentation
            
            Change-Id: I50d715f5ceb10e4560ee639f89c84752ecf65aae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156806
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [e23d2be0ce41ea0a1f6d3d58d626a546c25cb516]

        using decls should come after #include
        
        Change-Id: I058551e87bca42adede860f6f299b0f7ae2af3b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156798
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [76ea287c040dcfc2fe71b0588e1701cfe1ae6940]

        EnumerableMap does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I98b05a5bc83e3a747ffc45909ca3de4969d4e187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156797
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [2b362ab651e197e4d96457503848504d9ed2a001]

        GenericPropertySet does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I64f260f659f49f50f5bdaebaa9bc1cf9c67ffc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156796
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [8d8afabeab1e93c42d13496a855f0ad4efd2e9cd]

        SvUnoImageMapObject does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I79cf929cc64ea7af7351674e02fb0bc83538c869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156792
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [83dea83cc5079c615923910727b95ef89a1936cc]

        GraphicRendererVCL does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: Ie2ee4b774167dd5f26ac88b97b0a5013ff379ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156793
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [a1174a5f1e312ebb98c3941d35287a8ffcb368e9]

        attempt to fix macos jenkins hangs
        
        I see sporadic hangs, and the backtrace indicates that the process
        is locked up inside _nextEventMatchingEventMask. Try an
        alternative formulation of this method.
        
        Change-Id: Id8d7631bb0421cfb3c91a673ea14c0fe458c6f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156794
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [0db4cad99ff3746cc39f106a32bf2642628e336b]

        SvxGraphCtrlAccessibleContext does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I4735bb086df297baff3b066a69e817e365007ba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [8730202879bbf1423c516ef9a99d34882e44c11c]

        FontIdentificator does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I13d3d34e202718894a50deb9dfa40041bdc5d25c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156771
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9ecb98b3060dfc7f6291391792d1a3d73a282ba]

        MutableTreeDataModel does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I81b0c46be19bfafb220f0ae908eedfd9c5b20b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156726
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [d6d0bd11ec38978156b9dbbda50bdddc9159e064]

        PropertySetMergerImpl does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I40f4906723ab040b95a8db5c34e81b09a5ede38c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156772
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [67e0e7f57c37162ce5a8f888094c46a8267c1cc3]

        OMergedPropertySetInfo does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I8623da7e9962df1dbb09327933fccbddd82a4562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Noel Grandin  <noelgrandin@gmail.com>  [d3ad7b534774f3cbef9d400170fefedccfe70b60]

        SvxUnoNumberingRules does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: Ifc02ca4c3173f593912a6d40d55922ff737b2b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156770
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-10  Julien Nabet  <serval2412@yahoo.fr>  [5424bcd28f89b3622f85783633c725be643a0595]

        tdf#153034: Three wrong Greek characters in WordPerfect 5 import
        
        Retrieve of the commits of upstream, waiting for libwpd 0.10.4 release.
        
        Change-Id: Ie7ef425d1a25e0cb77a00c75c13bc392c30aae12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156768
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-10  Julien Nabet  <serval2412@yahoo.fr>  [44d50f0226b1003f60dd0a890e2309cac9660812]

        tdf#149195: Impossible to change link of a DB and keep the same registered name
        
        Just test nEntry to know if it's a new entry (and so the name must be different from an existing one)
        
        Change-Id: I3bda6b1d3d9bae3d79fdfc2cb1323f20add410c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156785
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-10  Michael Weghorn  <m.weghorn@posteo.de>  [7737dab14baea000810965c572f06a10a94f73df]

        tdf#157160 a11y: Don't assert ValueSetAcc parent on add/remove
        
        After
        
            commit 2f5e7a07775690e57d639eeca7a1e41733fa93a9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 7 08:09:31 2023 +0200
        
                tdf#157092 a11y Let only drawing area dispose its ValueSet acc
        
        had fixed a crash when using the search feature with the Qt-based
        VCL plugins, the previous `DBG_ASSERT` that got promoted to a
        real assert with the above commit got triggered now that a11y CHILD
        events for removed children are handled since
        
            commit be8b031d8b3c66b223ea2478f1129427f3a362bd
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 7 09:51:38 2023 +0200
        
                qt a11y: Forward CHILD event for removed child
        
        , s. the backtrace in tdf#157160.
        
        Since the ValueSet isn't needed for this, and at least removing
        a listener after the ValueSet has been dropped even seems logical if it's
        a valid use case to delete the ValueSet before e.g. hiding the
        window (s.a. comment in above-mentioned
        2f5e7a07775690e57d639eeca7a1e41733fa93a9), don't check for it,
        but only that the object hasn't been disposed yet
        (as was effectively the case before
        2f5e7a07775690e57d639eeca7a1e41733fa93a9, when
        only a SAL_WARN would have been triggered).
        
        Change-Id: I5be0a44decbe4508f4a419ec3dca9f8aaf85e951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156782
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-10  Joan Montané  <joan@montane.cat>  [8740a1db21298be2dc81a8388a2df3aa8451531c]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 272686e247e81719b86c71d7d1672bc775d91031
          - Fixes issue #156669: Updates Catalan dictionaries (spelling, hyphenation, and thesaurus) with latest releases.
            
            Change-Id: Iac7161011d3fc2e684b22f4588be1f812f6d8da1
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/155469
            Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2023-09-09  Aron Budea  <aron.budea@collabora.com>  [7317420bf85e8f6f40f544321096dcb3adcc5e23]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1a0dc6e5aee05f2a07a632adf6e121082fbd1bf5
          - Add Indonesian hyphenation library to dictionary package
            
            Change-Id: I807f295947ef9ab053f990c9220a78dad8485629
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/145372
            Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2023-09-09  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [380348d7188fcdd9e5a4427771e1d226455bee9a]

        libgpg-error: upgrade to release 1.47
        
        * Remove external/libgpg-error/w32-build-fixes-3.patch.1, which has
          redundant contents with a part of external/libgpg-error/w32-build-fixes-5.patch.
        
        Change-Id: I330b5f92717c1c5f6c0637940dfe7c3ac7e58b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145169
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a4f79e13ca41697d96e7c4b0d80d402f0cab1d5]

        SvxUnoTextContentEnumeration does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: Iabe77c0bd01177066a7a565c0d83c03f61f5fc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156716
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [328f9b6de0b1d66dec815857c43df62dccf5f7d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f419319c17c61a5fbd36e1bdd1a6b281283ac421
          - Create a menu file for writer-only table commands
            
            Change-Id: I401d42c9af27881da223cc51e666d14999d64062
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156780
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Noel Grandin  <noelgrandin@gmail.com>  [c32b1b2dd2722a85d0bee5891a9a8d5c38f67642]

        disable more flaky navigator UITest
        
        Change-Id: Ieadd35fef7f709e9eaf0f26238f7613076aa8c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [408a4b76c3dae617842a967264cc9342af86759c]

        SvxUnoShapeModifyListener does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        WIP SvxUnoShapeModifyListener
        
        Change-Id: I6ec837deec36d5a9c232a02b3759f4f1f9a8686d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c6087df82e2705db718548b0b230e7b415b75e6]

        FastPropertySet does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I6ec236f317d4da7559422a82acdc8d1b2ae8a44e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9ff22fa080bb896f771f82c197bd05a972b5e024]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3d76b0da48187a968762fb3c4b2cdd462abc7688
          - tdf#155875 UI cmds Writer/Table in Help(41)
            
            + refactoring
            + Table - Convert menu (part 41)
            
            Change-Id: I9fd415b9b26b8cddde419c09ee7ef85f3ea77a6c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156779
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b1400c1fa8c978f4500e7abbbcc7285d33f6733e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ecdb331fcdc8bd47a3556d6cc39380ff40e0e9ad
          - tdf#155875 UI cmds Writer/Table in Help(40)
            
            + refactoring
            + Table - RowSplit command (part 40)
            
            Change-Id: Ieae864974dfd600bf9c2c75cf2cfeff7f076dbdf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156778
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [25dd2236a851f5558ddae17afc6b168ba17d5271]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7be50ba620c4b90e136442087f5eb36b97fc608
          - tdf#155875 UI cmds Writer/Table in Help(38)
            
            + refactoring
            + Table - Headers Repeat command (part 38)
            
            Change-Id: Ibb03109bb1b4d6dfc7460be181e8457b14f9d1c0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156777
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bb0d7dc01d10b8d4cc6208aa169119e4371756e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff28718632e3062ced6aea9f38cf8934bf3f36d4
          - tdf#155875 UI cmds Writer/Table in Help(37)
            
            + refactoring
            + Table - Number recognition (part 37)
            
            Change-Id: I0fba1c1d55aade21c39321ae5c5c4ddabfc72a9d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156776
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Noel Grandin  <noelgrandin@gmail.com>  [2d4f840a950ba64be5ba81ff72b2cb4bdc0f97de]

        fix XPdfDecomposer
        
        accidentally pushed the test commit:
            commit d3e0130b1e5a0beb7995565b6e365aec248eece0
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Sep 8 14:02:13 2023 +0200
            XPdfDecomposer does not need to implement XAggreggation
        
        Change-Id: I8d65d69723120648020654ded658d0fa7c62d906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc69edc50c8ccde2422d21d5b3899d08f7510574]

        NestedRegistryImpl does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +  void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I3eb7f69ab16bedbe32e457f67257393822dc90d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7431e530145c543604cf02808e439feca034333]

        TableColumns does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: I650ef48d993450650bfe466ca9d4a9ab32b4493d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156724
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [b999d4c53c2a7e90576c402fed38039856f97348]

        XSvgParser does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        Change-Id: Id392a4fc3ddf34ce1fa2b66eb1e509e05184e50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [43ad56252d788dd1e7f4a14d07662e5b1854adee]

        SwXFootnoteProperties does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        
        WIP SwXFootnoteProperties
        
        Change-Id: Id1e1a0195e770bcbcebd9b55355de230c8641547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Noel Grandin  <noelgrandin@gmail.com>  [2e49ec0eaa59b5b513ea756861ecac5482b930b2]

        disable more flakey navigator UITest
        
        Change-Id: I174a9e84eba4e136d1f487a09afc0b37952ce9e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156766
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [12581c33ea083a16c4ef6a46e54e4134127af265]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f24e78f7c45b3fae572c80e3a0542203c829fa8
          - (related) tdf#149796 "autoupdate" -> "Automatic update from document"
                  
                  Update label, and add "tip".
            
            Change-Id: Ief8a36820cf83ccc92b242f7a7b085211303f0ff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156595
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b5b197c96242ade1982a295d6573ea9db031e6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8c9e70bd53f131132fcb79c3fc2f5f16dc3c2c8
          - tdf#155875 UI cmds Writer/Table in Help(36)
            
            + refactoring
            + Table - Format Numbers Styles (part 36)
              + Fix links for AutoFormat.xhp
            
            Change-Id: Ifa15a17e072a2d0d2bcfd8312d8fa47b93e8b742
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156761
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [76ac48081838a5ae4e1e2a38b4b7ae621201f9d4]

        Fix typo
        
        Change-Id: I89d3a3074929ba867975ae57d350b7e4211ed67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156757
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5589f0de0f3b1e8fafc3fe21015c5292147d308d]

        Fix typo
        
        Change-Id: I88d79ca31981a49736af571067831c703cf65d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156755
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fafb156b2dfe1169997b1546da7966355684f611]

        Fix typo
        
        Change-Id: Ifac298898f2d36bcbaffb111346d1e9fa71b2e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156758
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9389551e435818da9fb19dbb13786ffc7761651c]

        Fix typo
        
        Change-Id: I1a853bec38ce31d7961a150d4f3958c38c896559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156756
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [545e649e03b3f994757a7f5ca0671eae2d2b9643]

        Fix typo
        
        Change-Id: Icf7b6216180fe259cc9c529ea5c48720324c9262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156759
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f4d19e6bd5d33263019396d596dcc819f2b8e26a]

        tdf#149796 "autoupdate" -> "Automatic update from document"
        
           Also add tooltip for this option
        
        Change-Id: Ie3725219da3b617f8fa6027de7ffac357cf5adeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156593
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-09-09  Jim Raykowski  <raykowj@gmail.com>  [10689e0f24e96781664e734fe23d109af6df77f1]

        Improve the HasFoldedOutlineContentSelected function
        
        Return false immediatly if there are no outline nodes in the document
        since then there can be no folded outline content selected.
        
        Adjust selection that includes the end of content node so that the
        end of content node is not included in the selection. This fixes a
        crash that occurs when outline folding is enabled and Master
        document 'Text' is deleted by using the Navigator popup menu item
        'Delete'.
        
        Change-Id: I28be127566c3820b3e78834495bbb354cf2d01aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156631
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-09  Hossein  <hossein@libreoffice.org>  [65325f9c2f9aff6782fa5df910e8f2f5e63dfd93]

        Rename .cpp examples to .cxx
        
        The files are renamed, and the associated lines in Makefiles and
        elsewhere are also changed.
        
        Change-Id: Ieec38055690e03afd8982320ee0836904a3f41eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156670
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [debd9a749cbaaa6ec97992b6908293ec5d41bffc]

        no need to use XAggregation for DatabaseRegistrations
        
        the delegating class already implements the interface and forwards the
        method calls
        
        Change-Id: I8b0c74be87656675a887ddda2e7c44b63f165c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d3e0130b1e5a0beb7995565b6e365aec248eece0]

        XPdfDecomposer does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I324e0f8825f8b9e8619b1238624b4288720b08cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [59bf2fbb5f6ebe62b4176c040054ff1c80e2d29a]

        SvUnoTextRangeEnumeration does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I4313e8c25ab3fec4b96c7a0643c7acf9ba89785f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156717
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [b438f10910234241f7367d2598c81e0bf1e44cd4]

        XEmfParser does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I5ff6b1e166aff1ad67464785cf39d748f5dfc236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2ba17fecb60d936599efb975d96a3ea06c2a43f]

        disable more flakey navigator UITest
        
        Change-Id: Icf6a28f1270fc95a4edfc81a06fc79d5d2da17df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e24e0160b3cb0d2bbd5ffe584d98a126783d279]

        improve log message
        
        Change-Id: Ifb793b9f1d1476617239b826705f8838bdc66303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156714
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c1f3b34f871d2a6bb9ee7b912492be1164eec96f]

        ITEM: preparations for more/easier changes II
        
        Again this is a change to improve understandabilty/changeability
        of SfxItemSet code plus some cleanups. Still did a callgrind round
        to check - it slightly got faster. In a start/load(complex SW doc)/
        show/shutdown cycle compared with master I get 96.722 mio cycles
        compared with 99.851 mio in master.
        
        Main focus was to isolate two aspects: preparation and cleanup of
        an Item for usage in an SfxItemSet. For that we now have
          implCreateItemEntry: to do all needed actions to create/prepare
            an Item for membership, including evtl. AddRef/Cloning/using
            ItemPool stuff.
          implCleanupItemEntry: to do all needed actios to correctly
            clean that Item up again.
        All formally accesses distributed over SfxItemSet (and other places)
        are cleaned-up to use these. The Item-counter in DBG code that I
        already added helped a lot to do this.
        
        Also cleaned up PutImpl to 1st check if action is necessary (Item is
        already in place) or not, reducing spot to cleanup an Item that
        was handed over as bPassingOwnership to one place.
        
        I also added a 2nd flag, bItemIsSetMember, that tells if the Item
        given as input is already member of an SfxItemSet, in that case a
        shortcut can be used (increase AddRef, use).
        
        Adapted all places AFAP to use the new container interface
        (begin(), end(), ...) where useful.
        Made GetItemState inline and directly use the tooling method. Same
        for InvalidateItem.
        Added much more comments to describe what's going on or to hint at
        problems (check for CAUTION).
        Removed PutDirect - not needed anymore, probably was there to not get
        recursive death loop with callbacks in SW.
        More smaller changes.
        
        Checked with all apps, played around. Still, stuff may come up, so
        I put on gerrit  the tests will show and give further hints. At last
        SfxItemSet is a minefield :-)
        
        Had to adapt SfxItemSet::implCreateItemEntry when input Item is
        a StaticDefaultItem. SfxItemPool::PutImpl needs to be called in
        that case.
        
        Had to correct bItemIsSetMember in all cases if the transfer
        of SfxPoolItems is between SfxItemSets with different
        SfxItemPools. This is and will be necessary as long as the
        Items are stored at the pool.
        
        After a hard deep-dive I found the error: m_nCount was not in
        all cases correct, invalid items get counted.
        
         Win build *insists* for initialzation of local var aEntry in
         SfxItemSet::PutImpl, triggers warning C4701:
         "potentially uninitialized local variable 'aEntry' used". This
         is not the case here, but I know of no way to silence the
         warning in another way, so added an extra-call to begin().
        
        Re-added to use static pool defaults directly, possible After
        the fix 6d8c6e8d60956fd36094035a526c1a29a902204b, thanks for
        that. This avoids some cloning of Items.
        
        CAUTION: static default items are not *that* static as it seems
        (or: should be). If they are freed with the Pool (see
        ::ReleaseDefaults) they will be deleted. If the target pool is
        different from the source pool static default items from the
        source pool can be used that then might be deleted (sigh).
        
        A solution would be to change all pools to really work on
        static instances of default items.
        
        Another one would be to know here that the
        targetPool != sourcePool, so maybe extend
        bItemIsSetMember -> bSamePool.
        
        A good test for this is CppunitTest_chart2_uichart/testTdf98690.
        Until solving/cleaning up we unfortunately *have* to continue
        to clone static default items...
        
        Change-Id: Ibd8dc6d612f594a5ad88c75fcee8726d89a6090c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156306
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-09-08  Stephan Bergmann  <sbergman@redhat.com>  [93aa47535267435fd327368875e46a33f86b39d6]

        Flatpak build needs external/java_websocket
        
        Change-Id: Ie327885b238134092b4d3dd5f406941cf452239a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156707
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [425ca75d71497aebae5f5fdfdb20f65a6422a9d3]

        WARN->INFO in XMLIndexSimpleEntryContext
        
        This is not generally a problem
        
        Change-Id: If7957da45e5ad00f881ef3a7c5c676b09494ec77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156713
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [edffc763fb56453dc2eba15bb8c9450639c69db1]

        improve exception message
        
        Change-Id: If4d924b07875ffb8586e93eb84b4f01cd0c3ba34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156712
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2768ada1943a4dfb7ac2fc080656e151dd55efb8]

        tdf#157134 Fix selecting shape when image was selected before
        
        Change-Id: Ia45385aa5f76390f17fbcb14f7872ba0a0d9e14f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156665
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbe8cc7feb9ead5918b0c52d4211caf4a10c8212]

        inline SC_QUERYINTERFACE macros
        
        which means we need a few more cppu::queryInterface variants
        
        Change-Id: I5cf7805ab9576919bfd66a3b239917e48a7f8f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Julien Nabet  <serval2412@yahoo.fr>  [b69e14038288387b5f288a06821fb5df66dcf94e]

        tdf#157138: Can't switch from Use Background to None area fill
        
        Revert partly tdf#151260 fix
        
        Change-Id: I4c052e2cd1cb41dc8bda4b388b46e4416e351434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156669
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c7a608a6691c790783c63f504010bc796c36af25]

        tdf#155503 Add title to document title dialog
        
        Otherwise the title was just "Name"
        
        Change-Id: I883d2468c7bd97782b0aef4165a6afe4ff39ce31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156659
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [48129cabb9a5636207d3b8f4f9fa4e4abac61b8a]

        tdf#157085 Make doc title dialog modal
        
        Change-Id: I7a7574c3ffaa45aeb9bb97d9a1963c52d5619d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156658
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [7585667c83578e7f073409b2b94a4d34e7124115]

        replace ScUnoHelpFunctions::VectorToSequence..
        
        with the more standard comphelper::containerToSequence
        
        Change-Id: I29a67e52e7c25c2d67b0cd617acc7068737bad5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [033959aae1744a7bc7315e9abd051805805b33a3]

        SvUnoAttributeContainer does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: Iddfef9353c3a63547546e2db49083083d2dc74c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156695
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [74895033b99ba8b1496dc71699f52402b6d3db11]

        add SAL_WARN to UIObjectUnoObj::getChild
        
        to help track down an intermittent UITest failure on jenkins, which
        would otherwise assert inside the UIObjectUnoObj constructor
        
        Change-Id: I1b06c1eef5fe3402857b7a300decd48488ec621c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [777252f9f091ddaa51423e1978e233fa9510cabe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba616b2299e419762f2eca9ba5b55ed5a4f31c9f
          - tdf#155875 UI cmds Writer/Table in Help(35)
            
            + refactoring
            + Table - AutoFormat Styles (part 35)
              + uno:AutoFormat refers to similar dialogs in Calc and Writer
              + but each on its module
              + merged in shared/01/AutoFormat.xhp with app switch
              + removed obsolete files (merged)
            
            Change-Id: I9324c517f19934027311c297d012397650b60cf4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156685
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [19e32f6a3661a5f161db0d5a722f25fb315bd45a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8daa94aa1ff1135d3d2552182c7f2d23cc21d6f2
          - tdf#155875 UI cmds Writer/Table in Help(34)
            
            + refactoring
            + Table - Protection (part 34)
              + protection is called by "uno.Protect" in menus
              + in Calc: protect sheet dialog
              + in Writer: protect cell directly
              + merged in shared/01/Protect.xhp with app switch
              + removed obsolete files
            
            Change-Id: Ieada8a774a14a19f79f58e22fd807bf5aacaf64b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156678
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [87f9e703bfa13652e2bca59e89f45b196f9d9580]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f31e41620bb668c611701c87a9f2b1cbf3c93c9
          - tdf#155875 UI cmds Writer/Table in Help(33)
            
            + refactoring
            + Table - split/merge table (part 33)
            
            Change-Id: I86a47fc6b6941d7efd89e485e299271bea737826
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156677
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-08  Stephan Bergmann  <sbergman@redhat.com>  [2bd5b489db722905a81e40f9d6dd90c5a73a2d89]

        Fix some misspelled LibreOffice @since tags
        
        Change-Id: Id6602a06574e435b09a36997f3d1dd5cf3a6859e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [380b586d6e69412aa5f4b9558ebb192ed8bcfc38]

        XPrimitive2DRenderer does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I2b3c0cfd43a3437a1376e64421a66c595083e486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156661
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f0d41c14d2198fcf86104050dd42cdb82b3e9a4]

        document SvNumberFormatsSupplierObj
        
        Change-Id: Ic07f09f1f01f850caa489f0dfdb5622d8b49a990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-08  Hossein  <hossein@libreoffice.org>  [7dc3be651b050c7b4d383d8ee25b69728418acc7]

        tdf#143123 Port DevelopersGuide/FirstSteps/FirstLoadComponent to Python
        
        Porting FirstSteps/FirstLoadComponent.java to Python is done. More
        information on this example can be found on LibreOffice DevGuide:
        
        LibreOffice Developer's Guide: Chapter 1 - First Steps - First Contact
        https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
        
        This is the last of the 3 examples in the first chapter which are ported
        to Python.
        
        Change-Id: Iac0682943d4286168bbdadf792423670f41bdee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156686
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-08  Miklos Vajna  <vmiklos@collabora.com>  [facdac2443d50339f81415d09c1869d19dded7bf]

        sw floattable, nesting: fix PDF export
        
        The problem was that the bugdoc rendered fine when opened interactively,
        but not when converted to PDF via 'soffice --convert-to pdf'.
        
        The direct cause was that the interactive case also enabled the
        navigator that did one more calculation for each fly, and that fixes the
        layout. The headless export to PDF has no navigator, so that didn't
        happen.
        
        The root of the problem seems to be that:
        
        1) There is a bad left position for the inner follow fly (it's outside
           the page rectangle).
        
        2) SwTabFrame::Split() for the outer tab normally calls
           lcl_RecalcSplitLine() which moves flys away + back.
        
        3) Moving away happens in lcl_InvalidateLowerObjs() in the
           _bMoveObjsOutOfRange case, here we move away both fly 10 and 20 (both
          inner flys).
        
        4) Moving back happens in
           SwToContentAnchoredObjectPosition::CalcPosition(), but that's not
           invoked for the inner follow fly.
        
        Fix the problem by extending SwObjectFormatter::FormatObjsAtFrame_() to
        be more consistent here and move back both flys.
        
        This is related to tdf#55160.
        
        Change-Id: Ia264a828f36cf2bc1d67986ab3a97d57e9d167a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156691
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-08  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [b0e8ce9967acf3a759e5b85c4a0d16d7dad275fe]

        tdf#156649: oox: correct import alphaModFix for custom shapes
        
        alphaModFix should be imported into PROP_FillTransparency
        for custom shapes.
        
        Change-Id: I19621e424a64b097d5e6881877d60de253be636d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156660
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-08  Miklos Vajna  <vmiklos@collabora.com>  [edd121dd668e141cd61f0992340fa07eb6df8e76]

        sw doc model xml dump: show all redline data of a range redline
        
        E.g. Alice does an insert, then Bob does a delete in the middle, then
        the deletion redline will have 2 redline data, the first will be the
        delete, the second will be the original insert, show this in the xml
        dump.
        
        Change-Id: Ide9777cdbc8a5460fe28c646104901c968a33382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156680
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-08  Khaled Hosny  <khaled@libreoffice.org>  [3c24177104dfa5b8d68d74bf1735839964e93ba6]

        tdf#88744: Use real clipboard when inline editing is enabled
        
        Instead of using a fake clipboard that works only inside the same
        formula.
        
        Change-Id: Ia1e97028e1aafa15912bc9b4397d66afb0d23ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156671
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-07  Khaled Hosny  <khaled@libreoffice.org>  [beaea2e992912b4747d790070b26371f557b1f57]

        starmath: Properly update the state to copy/cut/paste buttons
        
        Invalidate the slots explicitly instead of implicitly by updating the
        edit window.
        
        Followup to:
        
        commit 065609f86f730d4eedc6b7ae28382dc7daea11ac
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Mon Sep 4 13:22:04 2023 +0300
        
            starmath: Make cut/copy/paste buttons work with inline editing
        
        Change-Id: If0648c249d6145475202e1a48364d7fe142a5e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156674
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b7a5c2502434d3da92d1fbcad528cabeb61a2719]

        tdf#157136: apply top context properties to the text input field
        
        Change-Id: Ie3877811e482c1ec395a00ec6bf67155220b2b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156675
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [f6a6b1454c7c765c0fc2ef9dc3e6111509a88307]

        tdf#157137 a11y: Don't report active descendant when not focused
        
        Since an active descendant is the UI element with keyboard focus,
        only send an `ACTIVE_DESCENDANT_CHANGED` event in `VCLXAccessibleList`
        if the listbox/combobox actually has focus, not when the selection
        changed otherwise, e.g. because the value was changed programmatically
        because it depends on another UI control (like the paper size
        in the print dialog depends on the selected printer.
        
        Change-Id: I008e742ccf3b81c70832707b2f3a6551827a0706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156666
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b814e8db4ce5f233c4bea041f90b6893084ede0]

        GalleryItem does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I136a7b51ba7d5500876dcd8892f1165334daa15f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156643
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [46b8c7a83f2cae57966ac55591e6f512ceaa114f]

        merge SvxFmDrawPage into SvxDrawPage
        
        it adds hardly any functionality.
        
        Change-Id: I82f5c52148222596d52f1fb41d726733ca1cf40d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [18502f44fc68ee9aa7967377b81c06b81d649858]

        fix warning of gtkwidget.c:8652: widget not within a GtkWindow
        
        drop the has-focus here which defaulted this button to be the
        default one, which we don't want anyway here
        
        Change-Id: I4392bcedeb48289d262dd40c6fe6f61e7baf60db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-07  Khaled Hosny  <khaled@libreoffice.org>  [8c982bf86ff9ca5a4ed86505ec1133cc183f1b58]

        tdf#130741: Insert brackets around horizontal binary nodes more generously
        
        When converting node tree creating with visual editor back to text for
        the command editor, try to always insert brackets around binary
        expressions. It might look redundant at times but it is safer, and the
        code is not supposed to be edited by hand anymore so doesn’t have to
        look pretty.
        
        Change-Id: Ifff574494c9e8f8b948e432f6832d88c334aba00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156640
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [e59516e8b31f0a1880de153229f5b193a447fb60]

        SvxUnoNumberingRulesCompare does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I3e08b565974cf1532ba8af36b4399b2f4b28bfb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ff155649c40d4114c4f253e371ef5dd75a3133ee]

        increase max_len for fodt2pdffuzzer further
        
        Change-Id: I517fe5c9a3168cbaea670e0ead6d1f9588f588a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156664
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20f0c887f41cae9f7ce5ac61925db39aa9a9ef25]

        don't need non-default image-position with no image
        
        Change-Id: I8a165221c9b2175d6e9b4096427bfe309cbee36c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f4c6b97fc161d5d8a2c04022ba988108bec34166]

        fix translation context for new strings
        
        since:
        
        commit 92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f
        Date:   Fri Jun 30 11:22:01 2023 +0300
        
            Allow selecting a custom certificate manager
        
        Change-Id: Ie96a6e932e09318d031e954b73b928e5b854ec5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [dd9db8f8a47e49d92738b1dea2710f43d76c13b7]

        svgio: update comment
        
        After 4f656a057e2a92e2107f7820fc563498c801d7d3
        "svgio: handle addGap internally inside SvgCharacterNode"
        
        Change-Id: Ib3ddbaed7a07c1b3b9f21eafd0715622751829ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156648
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [c29d86fc92509bb9c853a07970963b7b3be09d52]

        no need to take a lock and do nothing
        
        It has been this way since initial commit in
        
            commit 5eb0040d0199f8c80d47ed912e055f27a193b81d
            Author: Mihaela Kedikova <misheto@openoffice.org>
            Date:   Thu Aug 12 17:44:19 2010 +0200
            tabcontrol: new source code for tabcontrol added
        
        Change-Id: I0e9730525249a3da8857e5c19070a6aad05ad768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [76932ec6c45089f3319c4fc211d92d19d92666c3]

        tdf#48083 Handle mso_fillBackground directly when processing the shape
        
        And remove the no longer needed special handling
        in SdrPowerPointImport::ImportPage
        
        Follow-up to a43f1ac6c964181cbaa4c889409688197cbf7a2b
        
        Change-Id: I0382d5cf93f9e3dfba2b7822032e3eb3cf668a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156638
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-07  Julien Nabet  <serval2412@yahoo.fr>  [1806691c91b45b3ee5a52efc585930c41c705127]

        tdf#141123: impossible to replace an event after it has been set
        
        Change-Id: Iabecd5b4cff803e45fede6b25db03d553eb835a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [7bc010d624215b3d1830546e5c6f0a24567c54f4]

        SvxUnoDrawPool does not need to implement XAggreggation
        
        Checked on jenkins using 'make check' and
        
        +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        +
        
        Change-Id: I50283dff8832557ffaa9074532a2245210dc6d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [be8b031d8b3c66b223ea2478f1129427f3a362bd]

        qt a11y: Forward CHILD event for removed child
        
        No longer comment out the code to send a
        `QAccessible::ObjectDestroyed` event when
        receiving an `AccessibleEventId::CHILD` event with
        its `OldValue` set.
        
        The underlying issues causing crashes previously seem
        to be fixed, I can no longer reproduce these on Debian
        testing with Orca 44.1-2 when using the font color
        popup as described in
        
            commit 734d10ed3612d75edcee145475ddd0b0165efeac
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 14 16:57:09 2023 +0300
        
                qt a11y: Send QAccessible::ObjectCreated event for correct object
        
        > Adapting this for the case where a child has
        > been removed (bridged to Qt as `QAccessible::ObjectDestroyed`
        > event) would currently results in crashes when closing the
        > application e.g. after using the character font color popup in
        > the Writer toolbar. This needs further investigation, so don't
        > send the event for now, but add a `SAL_WARN`.
        
        Change-Id: Ib8f21850dd56645cf64a74be0e1ff8242615b928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156647
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [2f5e7a07775690e57d639eeca7a1e41733fa93a9]

        tdf#157092 a11y Let only drawing area dispose its ValueSet acc
        
        Don't dispose the a11y object in the `ValueSet` dtor, because it
        doesn't own its a11y object, but it is owned by the `weld::DrawingArea`
        of the `CustomWeld` that the `ValueSet` (as a sub-class of
        `CustomWidgetController`) belongs to.
        
        The `CustomWeld` ctor passes the a11y ref retrieved by
        `CustomWidgetController::createAccessible` to `weld_drawing_area`,
        which takes ownership and disposes the object.
        (For Gtk, see  `GtkInstanceDrawingArea::~GtkInstanceDrawingArea`.
        For non-Gtk, see how the `SalInstanceDrawingArea` ctor
        passes the reference to `VclInstanceDrawingArea::SetAccessible`/
        `vcl::Window::SetAccessible`, so it gets disposed when that
        `VclInstanceDrawingArea` gets disposed, s. `vcl::Window::dispose`.)
        
        Other classes derived from `CustomWidgetController`
        also don't dispose the a11y object themselves.
        
        Still reset the `ValueSet` pointer in `ValueSetAcc` to
        nullptr when the `ValueSet` gets destroyed and turn the
        check for a valid pointer from just an `OSL_ASSERT`
        to a real assert and throwing a `RuntimeException`.
        But still allow getting the a11y context when only
        the ValueSet has been deleted but the object has not
        been disposed yet.
        
        Fixes a crash due to a `com::sun::star::lang::DisposedException`
        being thrown when using the new search feature in the "Tools" ->
        "Options" dialog (or when just switching to the "LibreOfficeDev
        Writer/Web" -> "Background" page with the qt6 VCL plugin or
        on Windows when the NVDA screen reader is running.
        
        This happens when the drawing area is hidden and the a11y layer
        is meant to be notified about this (so the a11y object can be
        removed).
        
        It still seems a bit odd that the `ValueSet` gets destroyed
        (in `SvxColorTabPage::~SvxColorTabPage`, frame 20 in below backtrace)
        before the corresponding `vcl::Window` gets hidden (in the base
        class dtor, `SfxTabPage::~SfxTabPage`, s. frame 19 in the backtrace).
        
        Backtrace for how the exception gets thrown:
        
            1   com::sun::star::lang::DisposedException::DisposedException               DisposedException.hpp       40   0x7fa385fd9ca9
            2   ValueSetAcc::ThrowIfDisposed                                             valueacc.cxx                956  0x7fa385fd9342
            3   ValueSetAcc::getAccessibleContext                                        valueacc.cxx                473  0x7fa385fd69fa
            4   VCLXAccessibleComponent::ProcessWindowChildEvent                         vclxaccessiblecomponent.cxx 186  0x7fa3853dc905
            5   VCLXAccessibleComponent::WindowChildEventListener                        vclxaccessiblecomponent.cxx 124  0x7fa3853dc51d
            6   VCLXAccessibleComponent::LinkStubWindowChildEventListener                vclxaccessiblecomponent.cxx 114  0x7fa3853dc43f
            7   Link<VclWindowEvent&, void>::Call                                        link.hxx                    111  0x7fa382c56ccf
            8   vcl::Window::CallEventListeners                                          event.cxx                   296  0x7fa382c53e5b
            9   vcl::Window::ImplResetReallyVisible                                      stacking.cxx                719  0x7fa382b51a49
            10  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            11  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            12  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            13  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            14  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            15  vcl::Window::ImplResetReallyVisible                                      stacking.cxx                735  0x7fa382b51b0e
            16  vcl::Window::Show                                                        window.cxx                  2234 0x7fa382d94f7c
            17  vcl::Window::Hide                                                        window.hxx                  880  0x7fa382b23600
            18  SalInstanceContainer::move                                               salvtables.cxx              1352 0x7fa3834789f3
            19  SfxTabPage::~SfxTabPage                                                  tabdlg.cxx                  157  0x7fa38928ab47
            20  SvxColorTabPage::~SvxColorTabPage                                        tpcolor.cxx                 166  0x7fa350950d3e
            21  SvxColorTabPage::~SvxColorTabPage                                        tpcolor.cxx                 166  0x7fa350950d5a
            22  std::default_delete<SfxTabPage>::operator()                              unique_ptr.h                99   0x7fa350538fdc
            23  std::__uniq_ptr_impl<SfxTabPage, std::default_delete<SfxTabPage>>::reset unique_ptr.h                211  0x7fa35080dcbe
            24  std::unique_ptr<SfxTabPage, std::default_delete<SfxTabPage>>::reset      unique_ptr.h                509  0x7fa350808555
            25  SvxAreaTabPage::SetOptimalSize                                           tparea.cxx                  155  0x7fa35093db3e
            26  SvxBkgTabPage::Create                                                    backgrnd.cxx                230  0x7fa350864dbc
            27  SwModule::CreateTabPage                                                  appopt.cxx                  509  0x7fa339e10973
            28  OfaTreeOptionsDialog::SelectHdl_Impl                                     treeopt.cxx                 1335 0x7fa3507f947a
            29  OfaTreeOptionsDialog::ShowPageHdl_Impl                                   treeopt.cxx                 625  0x7fa3507f4782
            30  OfaTreeOptionsDialog::LinkStubShowPageHdl_Impl                           treeopt.cxx                 623  0x7fa3507f4763
            31  Link<weld::TreeView&, void>::Call                                        link.hxx                    111  0x7fa3834b18f1
            32  weld::TreeView::signal_changed                                           weld.hxx                    953  0x7fa3834aa10d
            33  SalInstanceTreeView::SelectHdl                                           salvtables.cxx              5276 0x7fa38349363e
            34  SalInstanceTreeView::LinkStubSelectHdl                                   salvtables.cxx              5272 0x7fa3834935fb
            35  Link<SvTreeListBox *, void>::Call                                        link.hxx                    111  0x7fa382b8a339
            36  SvTreeListBox::SelectHdl                                                 treelistbox.cxx             452  0x7fa38307f5c2
            37  SvTreeListBox::Select                                                    treelistbox.cxx             2111 0x7fa383085b4a
            38  SvImpLBox::SetCursor                                                     svimpbox.cxx                614  0x7fa3830a66c3
            39  ImpLBSelEng::SetCursorAtPoint                                            svimpbox.cxx                2575 0x7fa3830aeaa8
            40  SelectionEngine::SelMouseButtonDown                                      seleng.cxx                  172  0x7fa382d09354
            41  SvImpLBox::MouseButtonDown                                               svimpbox.cxx                2004 0x7fa3830ac9f8
            42  SvTreeListBox::MouseButtonDown                                           treelistbox.cxx             2260 0x7fa383086422
            43  ImplHandleMouseEvent                                                     winproc.cxx                 707  0x7fa382daed00
            44  ImplHandleSalMouseButtonDown                                             winproc.cxx                 2340 0x7fa382db5c5d
            45  ImplWindowFrameProc                                                      winproc.cxx                 2685 0x7fa382db6f7e
            46  SalFrame::CallCallback                                                   salframe.hxx                310  0x7fa378ca4edc
            47  QtFrame::CallCallback                                                    QtFrame.hxx                 230  0x7fa378ca6418
            48  QtWidget::handleMouseButtonEvent                                         QtWidget.cxx                181  0x7fa378cf959b
            49  QtWidget::mousePressEvent                                                QtWidget.cxx                186  0x7fa378cf95f3
            50  QWidget::event                                                           qwidget.cpp                 8978 0x7fa376a2f327
            51  QtWidget::event                                                          QtWidget.cxx                730  0x7fa378cfb2f6
            52  QApplicationPrivate::notify_helper                                       qapplication.cpp            3287 0x7fa3769a666a
            53  QApplication::notify                                                     qapplication.cpp            2774 0x7fa3769a4539
            54  QCoreApplication::notifyInternal2                                        qcoreapplication.cpp        1125 0x7fa3783a5ed0
            55  QCoreApplication::sendSpontaneousEvent                                   qcoreapplication.cpp        1573 0x7fa3783a6a1d
            56  QApplicationPrivate::sendMouseEvent                                      qapplication.cpp            2358 0x7fa3769a31a2
            57  QWidgetWindow::handleMouseEvent                                          qwidgetwindow.cpp           627  0x7fa376a5f7cb
            58  QWidgetWindow::event                                                     qwidgetwindow.cpp           241  0x7fa376a5dcfd
            59  QApplicationPrivate::notify_helper                                       qapplication.cpp            3287 0x7fa3769a666a
            60  QApplication::notify                                                     qapplication.cpp            3238 0x7fa3769a647a
            61  QCoreApplication::notifyInternal2                                        qcoreapplication.cpp        1125 0x7fa3783a5ed0
            62  QCoreApplication::sendSpontaneousEvent                                   qcoreapplication.cpp        1573 0x7fa3783a6a1d
            63  QGuiApplicationPrivate::processMouseEvent                                qguiapplication.cpp         2315 0x7fa3775f21cd
            64  QGuiApplicationPrivate::processWindowSystemEvent                         qguiapplication.cpp         2061 0x7fa3775f15cf
            65  QWindowSystemInterface::sendWindowSystemEvents                           qwindowsysteminterface.cpp  1109 0x7fa37769ce23
            66  xcbSourceDispatch                                                        qxcbeventdispatcher.cpp     57   0x7fa376064df7
            67  ??                                                                                                        0x7fa37df2b5b4
            68  ??                                                                                                        0x7fa37df2e607
            69  g_main_context_iteration                                                                                  0x7fa37df2ebfc
            70  QEventDispatcherGlib::processEvents                                      qeventdispatcher_glib.cpp   395  0x7fa3787b6b33
            71  QXcbGlibEventDispatcher::processEvents                                   qxcbeventdispatcher.cpp     96   0x7fa37606502c
            72  QtInstance::ImplYield                                                    QtInstance.cxx              421  0x7fa378cc7502
            73  QtInstance::DoYield                                                      QtInstance.cxx              432  0x7fa378cc762b
            74  ImplYield                                                                svapp.cxx                   372  0x7fa3835220ea
            75  Application::Yield                                                       svapp.cxx                   456  0x7fa383522e88
            76  Dialog::Execute                                                          dialog.cxx                  1078 0x7fa382c063e1
            77  SalInstanceDialog::run                                                   salvtables.cxx              1877 0x7fa38347c313
            78  weld::DialogController::run                                              weld.hxx                    2659 0x7fa3504a26e6
            79  OfaTreeOptionsDialog::run                                                treeopt.cxx                 2587 0x7fa3508035fd
            80  CuiAbstractController_Impl::Execute                                      dlgfact.cxx                 144  0x7fa35069d829
            81  SfxApplication::OfaExec_Impl                                             appserv.cxx                 1463 0x7fa388faf85e
            82  SfxStubSfxApplicationOfaExec_Impl                                        sfxslots.hxx                1309 0x7fa388f88faf
            83  SfxDispatcher::Call_Impl                                                 dispatch.cxx                254  0x7fa3890bfb4a
            84  SfxDispatcher::Execute_                                                  dispatch.cxx                753  0x7fa3890c31f4
            85  SfxBindings::Execute_Impl                                                bindings.cxx                1061 0x7fa3890aefa0
            86  SfxDispatchController_Impl::dispatch                                     unoctitm.cxx                688  0x7fa389185ba6
            87  SfxOfficeDispatch::dispatch                                              unoctitm.cxx                250  0x7fa389183867
            88  framework::MenuBarManager::Select                                        menubarmanager.cxx          827  0x7fa38a7e2dff
            89  framework::MenuBarManager::LinkStubSelect                                menubarmanager.cxx          791  0x7fa38a7e2ab7
            90  Link<Menu *, bool>::Call                                                 link.hxx                    111  0x7fa382cb0337
            91  Menu::Select                                                             menu.cxx                    358  0x7fa382ca1c90
            92  Menu::ImplCallSelect                                                     menu.cxx                    2135 0x7fa382caa907
            93  Menu::LinkStubImplCallSelect                                             menu.cxx                    2132 0x7fa382caa8d9
            94  Link<void *, void>::Call                                                 link.hxx                    111  0x7fa382db870d
            95  ImplHandleUserEvent                                                      winproc.cxx                 2287 0x7fa382db57ca
            96  ImplWindowFrameProc                                                      winproc.cxx                 2851 0x7fa382db76f7
            97  SalFrame::CallCallback                                                   salframe.hxx                310  0x7fa378ca4edc
            98  QtInstance::ProcessEvent                                                 QtInstance.cxx              484  0x7fa378cc799b
            99  operator()                                                               salusereventlist.cxx        119  0x7fa383465b7b
            100 SalUserEventList::DispatchUserEvents                                     salusereventlist.cxx        120  0x7fa383465e4f
            101 QtInstance::ImplYield                                                    QtInstance.cxx              410  0x7fa378cc7480
            102 QtInstance::DoYield                                                      QtInstance.cxx              432  0x7fa378cc762b
            103 ImplYield                                                                svapp.cxx                   372  0x7fa3835220ea
            104 Application::Yield                                                       svapp.cxx                   456  0x7fa383522e88
            105 Application::Execute                                                     svapp.cxx                   350  0x7fa383521ddd
            106 desktop::Desktop::Main                                                   app.cxx                     1601 0x7fa38ca36276
            107 ImplSVMain                                                               svmain.cxx                  204  0x7fa383541e84
            108 SVMain                                                                   svmain.cxx                  236  0x7fa383541fb9
            109 soffice_main                                                             sofficemain.cxx             94   0x7fa38caa1b5d
            110 sal_main                                                                 main.c                      51   0x5568fd6859d4
            111 main                                                                     main.c                      49   0x5568fd6859ba
        
        Change-Id: I247648a7a707f02bf1fdd339d3c329694636d835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156645
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-07  Szymon Kłos  <szymon.klos@collabora.com>  [2c3b690a900082a242e1a6494ac35338f5e8aad4]

        lok: save to xlsx changes column size
        
        When xlsx spreadsheet was opened in LOK on
        every save default column width was decreased.
        This doesn't happen in non-LOK case.
        
        Column width in Excel are defined by double value
        which specifies number of '0' characters which fit
        into the column.
        
        On export we use mnCharWidth from XclRootData to
        convert Calc twips size to number of characters.
        In LOK case it was 102 while in non-lok case 101.
        
        It was caused by different Reference Device used in
        ScDocument::GetRefDevice() because in LOK case we
        are in WYSWIG mode as introduced in
        ScModelObj::initializeForTiledRendering in commit c25062f:
        sc tiled rendering: Don't adjust the text width according to printer.
        
        Let's use for export purpose the GetVirtualDevice_100th_mm()
        
        Change-Id: I6709194d7924e8c7e0aaa75ff3901afbcc1f8c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156576
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 29f72210e92e0152d52b3a1d0253fbb5d8e2dead)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156604
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2b807baa2fd596ce4728cbc5ffbf8f8a50a60a54]

        Fix typo
        
        Change-Id: I4f2f281c12fefe6f69ceacb715faf2b8644abeaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156635
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-07  Dung.Saga  <dung.saga+documentfoundation@gmail.com>  [7113a11a3cfa38a27dde4779b6565cf723b4b0d2]

        tdf#157114 The popup "Search Commands" should also search by sub-menu
        
        Currently, the popup "Search Commands" only search by menu item. For example,
        searching for "right" yields "Format / Align Text / Right", but searching for
        "align" yields nothing.
        
        I updated function findInMenu to search in both sub-menus and menu items. This
        makes it easier to discover related actions in the same sub-menu.
        
        Change-Id: I8aa03619c5a3db9c95b09600a80caed1e029d1af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156617
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a24b2c9ec7f57f2dafa92564860878e829967341]

        Fix typo
        
        Change-Id: I330ff642b93e07c402f8dbb2fa0cefb1af1a7671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156634
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8658568f8c3946cf88af708928e092f7c5835b17]

        Fix typo
        
        Change-Id: I8902bfb3c779471d4aff80ca7e94a9848b9ece51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156636
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-07  Hossein  <hossein@libreoffice.org>  [7a643f40b4c76bc55f17c3137aad90dbf55463ea]

        Simplify condition in a loop over a single element
        
        The loop was over an array which has only one element, so the
        condition should also work directly with its only element.
        
        Change-Id: I5b87cf03d90e9da67ac3ff72b593be0ff5fa322c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-09-07  Miklos Vajna  <vmiklos@collabora.com>  [3aa3f0a1638a8d8006955b62bb647526768be3d8]

        sw floattable, nesting: fix position of the inner follow table
        
        The bugdoc was no longer crashing, but the inner table's follow part on
        page 2 was not visible.
        
        The problem was that lcl_ArrangeLowers() didn't try to update the fly's
        position when the cell's position changed, now we do this for split
        flys.
        
        The other problem was that as SwTextFly::GetTop() is called by
        SwTextFly::InitAnchoredObjList(), the inner flys were ignored while
        collecting the intersecting fly frames for a paragraph, leading to an
        overlap between the inner follow fly and the inner anchor text. This is
        now fixed by explicitly checking for the splitfly-in-splitfly case.
        
        With this, the ODT bugdoc now renders correctly when opened. (This is
        related to tdf#55160.)
        
        Change-Id: I60997e7913984872319250b0fb1cb91e02512800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156632
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-07  Darshan-upadhyay1110  <darshan.upadhyay@collabora.com>  [c4fc18308074634e9578ad12d94d937f259aa22a]

        Autocorrect: Add option for autoformat bulleted lists after space
        
        Enable option in Autocoorect => bulleted lists after pressing space
        Example: press * or - and space will change into bullets
        
        Change-Id: I9741ad4c3eb4123074f06b762b58fe7ffdb44613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156616
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-09-07  Khaled Hosny  <khaled@libreoffice.org>  [d93f3243d51438e2492ca6f450ae3f1f63b617b1]

        tdf#157112: fix off-by-one error in /LastChar of PDF Type 3 fonts
        
        It should be the index of the last glyph in the subset, so nGlyphs - 1.
        
        Change-Id: I62853a27b602d7b3e6b6265555542dd417438fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156630
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-07  Miklos Vajna  <vmiklos@collabora.com>  [f1703e6aa74ab0101aac0bb73ea1cbdbf05d0a1b]

        UITest_writer_dialogs: use oneprocess mode
        
        Before: 1m37,397s
        
        After: 0m47,049s
        
        Also having this in UITest_sw_ui_index and UITest_sw_ui_misc doesn't
        hurt.
        
        Change-Id: I89625c024c1b44f7ab9abed21751490de3e62b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156627
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9a37652b79001bf5208841b9221dee851b9b6d0f]

        tdf#156959 - Remove pinned icons from thumbnail view item
        
        Remove pinned icons from thumbnail view item and pushed it down
        to the recent documents view item. This avoids that the pinned
        icon will be shown in a simple thumbnail view, e.g., in the
        thumbnail view of the side pane in base.
        
        In addition, fixed an error with the number of elements in the
        thumbnail view in the start center when items are pinned, i.e.,
        removed a spurious new line.
        
        Change-Id: I76026bfa9239f709aa60ff12efabe28cb09f0d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156625
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-09-06  László Németh  <nemeth@numbertext.org>  [4697d2bda1b37f9cf8b301f5bf044c2390f56333]

        tdf#157011 sw tracked table column: fix DOCX import of empty cell
        
        OOXML w:std elements are imported with 0x01 characters in text
        content of tracked table columns (as a regression in LO 7.3?),
        losing change tracking data. Fix this temporarily by completing
        SwTableBox::IsEmpty() handling the bad 0x01 characters of the
        imported tracked empty cells.
        
        See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
        "tdf#143215 DOCX import: fix tracked empty row insertion/deletion".
        
        Change-Id: I4895754e540cca6ba2cb3442f24a8affcedd51fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156626
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-09-06  Michael Weghorn  <m.weghorn@posteo.de>  [d9e31f3c82082226dbc5afa697d0f0ac7e4214a2]

        tdf#156683 a11y: Handle both disposing variants in context wrapper
        
            commit db0044242a897e447988169630ff74e4c8bfecf9
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Sep 6 09:12:23 2023 +0200
        
                tdf#156683 a11y: Forward when wrapped a11y context is disposing
        
        switched from overriding `disposing()` to overriding
        `disposing(const css::lang::EventObject&)` in
        `OAccessibleContextWrapperHelper` in order to
        make sure that the corresponding entry in the
        `AccessibleEventNotifier` client map is removed and
        event listeners for the wrapper get notified
        (via `AccessibleEventNotifier::revokeClientNotifyDisposing`)
        when the wrapped object is disposing.
        
        As Noel points out in [1], the `disposing()`
        case should probably still be overriden/handled
        and make sure that the wrapped object etc. get
        disposed, so disposing one object via the other
        works both ways.
        (If the wrapped object is disposed, so is the
        wrapper. If the wrapper gets disposed, so is
        the wrapped object.)
        
        Therefore, add back `OAccessibleContextWrapper::disposing()`
        and extract the logic to a separate helper method
        that is called from both `disposing` variants.
        
        [1] https://gerrit.libreoffice.org/c/core/+/156592/comments/bb7c24bc_94033649
        
        Change-Id: If15fd1839b222ad94fcbc569842dc43b517d3574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [268a2009bc8acd9412183b4cd9bb7023b31e4f0b]

        update credits
        
        Change-Id: I49e7c7ebf91d07f1fb0758933b32ae1b53ac2240

2023-09-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7f5a9096be8518aff99c3a227d78f36c6dc124fb]

        fix "variable 'nRow' set but not used [-Werror,-Wunused-but-set-variable]"
        
        as seen on non-debug builds with compiling for x86_64 with XCode 14.3.1
        
        Change-Id: Ib0b97cfcf15cc58d08a90bc0b4aaf43fc1be3c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156614
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-09-06  Hossein  <hossein@libreoffice.org>  [218b73d937453d5d813a050f1216840ba71f4fe7]

        tdf#154271 Fix automatic cursor/screen jump in Calc
        
        Previously, when using ctrl+end, the screen/cursor jump was done to the
        middle of the screen. In this way, the available space of the screen was
        not optimally used.
        
        In this patch, the jump is adjusted to move the cursor to the end of the
        screen, and the visible/usable space will be all of the screen.
        
        In this patch, previous behavior for showing the search results and
        other purposes other than pressing ctrl+end to jump to the last cell are
        preserved, and in those cases, the selected cell will be in the middle
        of the screen, as before.
        
        Also, in the situations that the jump is done from a cell lower or right
        of the last cell (in other words, further than the last cell), the
        behavior is preserved.
        
        Change-Id: I25f308f84f096ec271c23df75998ddeea32119ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156266
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [de42529ca9107b24b6367b40801300416d4a51a1]

        replace svx::PropertyValueProvider with simpler implementation
        
        it was not actually doing much besides managing the listener list, so
        just use a regular listener list implementation.
        Registering was unnecessary as well, we can use getPropertyValue() to
        retrieve the current value.
        
        Change-Id: I53ae496e07ff028b12646668b134ffcab18484aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [25664e5da6b5196f5969188bce06e85730ceeaf2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f9f74aac7105208ded70127e5acd6cd2bae8b093
          - tdf#155875 UI cmds Writer/Table in Help(32)
            
            + refactoring
            + Table - merge menu (part 32)
               + includes Calc merge cells
               + Some pages will be revisited
            
            Change-Id: Ic6ebfedd363421ab33ad325609f2427cc2043998
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156618
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c9b5c627ccb5b70c103c559b1df38c1175efc2d1]

        add referer to ole objects
        
        so we can identify what document is requesting their contents
        
        extends:
        
        commit 5668e73beb30b95abc6520b7432c54972ca3ab2c
        Date:   Wed Nov 20 14:43:45 2013 +0100
        
            avmedia: Implement "block untrusted referer links" feature
        
            See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block
            untrusted referer links' feature" for details.  This adds some further /*TODO?*/
            comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not
            blocked during a slideshow presentation.
        
        to these objects too, namely OLE2Shape and derivatives AppletShape,
        FrameShape and PluginShape
        
        so in paranoid mode we won't load the contents of such objects from
        documents considered "untrusted".
        
        Change-Id: I6d988035d0cd09fd3fade5f6885fe336c95579ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc25df351f946c799112533af1cf9b1dcb2f6079]

        tdf#157113: Add gap even if baseline is different
        
        This was a workaround for https://bz.apache.org/ooo/show_bug.cgi?id=122524
        but it's no longer needed since 5079e7937ef471a44dcf119dc6ae0a334d9c6adc
        "tdf#156251: Add gap between text elements when needed"
        
        Change-Id: I83af59a515d56af6b0e3cf3e351d3df52510a17d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156613
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-06  Miklos Vajna  <vmiklos@collabora.com>  [d29c1a90ae77dde7c87c51f21e859fa254f23e01]

        sw floattable, nesting: fix layout crash
        
        The manually created ODT bugdoc has a nested floating table. The outer
        table is just 1 cell, the inner one has 2 rows: it's meant to span over
        2 pages. This bugdoc currently crashes the layout.
        
        In practice what happens is that the inner fly would split + move the
        follow to the next page, so we hit a case where the inner fly is marked
        to be "in table", but it won't have a table parent anymore, so the
        layout crashes.
        
        As a first step, fix the crash:
        
        1) SwFrame::GetNextFlyLeaf() should only split the inner fly and its
           anchor (not move it), the move will happen with the split of the
           outer fly.
        
        2) Fix SwToContentAnchoredObjectPosition::CalcPosition() to move the
           inner, follow fly down (it should not overlap with its master). This
           was not visible previously, as we manually moved the follow fly to the
           next page, but now we need a vertical cut position that is between the
           inner master and follow flys.
        
        3) lcl_ArrangeLowers(), called by SwCellFrame::Format() now updates the
           position of follow flys, so exactly two master flys are on page 1 and
           two follow flys are on page 2.
        
        This is related to tdf#55160, but it's not yet focusing on DOCX, where
        nested floating tables are currently disabled at a filter level. Also,
        this fixes the crash, but the position of the inner follow table still
        needs fixing.
        
        Change-Id: Ife42b64cda53946a8262ddabfd000803620c4ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156587
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ce2232c05f13a5b1303156d2b0321009b017620]

        tdf#157115 crash on inserting chart (gtk3)
        
        regression from
            commit bdf2d664784b3ebe3e7078b9ec82a02d09d9ded8
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Sep 2 10:44:51 2023 +0200
            use more concrete type in AccessibleChartView
        
        Change-Id: I5f76f10404d6a202b1653f5e7cabc665b5962557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5ddc65cc8544f0483ead1a021ac1f5b6df425f75]

        Update git submodules
        
        * Update translations from branch 'master'
          to 85096d36e4403fa7b9615f3c41932e5eea4670c9
          - update translations for 7.6.1 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I0c30495af44a6b38a0fc6ea46352a6ee54e9dad2
            
2023-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc3d33858629279f88717e3cec9b1761de890774]

        improve debug logging in SdXMLShapeContext::AddShape
        
        so we get source info for the exception
        
        Change-Id: Icd54a4d1388c7a48ab3e0c8bd17c21f6004a470b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156589
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [a06c580643ebcca37f0baac009534fd826602966]

        related: tdf#150557: improve test a bit
        
        Change-Id: Idf596d26a6b9cce29ae690a4975bff70f5f05ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156611
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ee45ccecdad9a2945c1985a7ce553869ca297735]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eaf5a5d10f601c9943851b79aa5c784c00eedd84
          - tdf#141676 change in command name
            
             "Add paragraph and table spacing at tops of pages" ->
             "Add paragraph and table spacing at top of first page and page breaks"
            
            Change-Id: I96d3ee1b7ca4fe55672d68ea57bb9224d4157521
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156596
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [500a48b5923a0a76bc6a1a9c828cf3803fdba8e5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1059596b74bcecea902bb6f31b012f059e1cf63d
          - (related) tdf#152905   Modify -> Edit Style
            
               also correction "Enable" -> "Insert" in 
                  text/swriter/guide/pageorientation.xhp
            
            Change-Id: If97e3cdab03e659daeb75bec777a686a79980635
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156446
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [15b092ab1938f5e514f0acfc0621d3d3e87172a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 763209bbaf47baa0c599a390c736f3b43fc35f0a
          - remove xml-lang="en-US"
            
            Change-Id: If6469a99d4a2e855c89b99998e1a716bfdb5fd1f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156221
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-09-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [645852b418b759e6576848385b782db6031b9ebc]

        tdf#141676  make command label more precise
        
        "Add paragraph and table spacing at tops of pages" ->
          "Add paragraph and table spacing at top of first page and page breaks"
        
        Change-Id: I05f53dde0c4782cc1adf1809a9a24f6f5a94b405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156220
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-09-06  Michael Weghorn  <m.weghorn@posteo.de>  [db0044242a897e447988169630ff74e4c8bfecf9]

        tdf#156683 a11y: Forward when wrapped a11y context is disposing
        
        `OAccessibleContextWrapper` wraps an `XAccessibleContext`
        held in the `m_xInnerContext` member and forwards
        calls to its own methods to that one.
        
        The lifecycle of the wrapper should match that of
        the wrapped context, so handle when the
        wrapped context is disposing by overriding
        `XAccessibleContext::disposing` (that takes
        a `css::lang::EventObject&` parameter) instead of
        overriding `WeakComponentImplHelperBase::disposing`
         (the `disposing` method not taking a param)
        that's meant to be called when/right before the
        object itself gets disposed (but wasn't called
        at all e.g. for the `OToolBoxWindowItemContext`
        case in tdf#156683).
        
        This makes sure that the corresponding entry in the
        `AccessibleEventNotifier` client map is removed and
        event listeners for the wrapper get notified
        (via `AccessibleEventNotifier::revokeClientNotifyDisposing`)
        when the wrapped object is disposing and fixes the tdf#156683
        crash on exit with gtk3 observed in the libreoffice-7-6 branch:
        
            /usr/include/c++/13/debug/vector:450:
            In function:
                std::debug::vector<_Tp, _Allocator>::const_reference std::
                debug::vector<_Tp, _Allocator>::operator[](size_type) const [with _Tp =
                com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>;
                _Allocator =
                std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>
                >; const_reference = const
                com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>&;
                size_type = long unsigned int]
        
            Error: attempt to subscript container with out-of-bounds index 0, but
            container only holds 0 elements.
        
            Objects involved in the operation:
                sequence "this" @ 0x561465d8e510 {
                  type = std::debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >;
                }
            warn:desktop:197113:197113:desktop/source/app/crashreport.cxx:61: minidump generated: /home/michi/development/git/libreoffice-WORKTREE/instdir/program/../program/../crash//e338ad13-2338-4cd0-8d5c069d-c28f5cf5.dmp
        
        Backtrace:
        
            1   comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear                                             interfacecontainer4.hxx     397  0x7f2c39915cdc
            2   comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing                                                                                             accessibleeventnotifier.cxx 204  0x7f2c39913c75
            3   comphelper::OAccessibleContextWrapper::disposing                                                                                                             accessiblewrapper.cxx       610  0x7f2c3992f033
            4   cppu::WeakComponentImplHelperBase::dispose                                                                                                                   implbase.cxx                104  0x7f2c3947491b
            5   cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleContext>::dispose compbase.hxx                90   0x7f2bf8b31c70
            6   cppu::WeakComponentImplHelperBase::release                                                                                                                   implbase.cxx                79   0x7f2c39474664
            7   cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleContext>::release compbase.hxx                86   0x7f2c3993133c
            8   comphelper::OAccessibleContextWrapper::release                                                                                                               accessiblewrapper.cxx       475  0x7f2c3992e536
            9   com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::clear                                                                     Reference.hxx               231  0x7f2c26929685
            10  atk_object_wrapper_dispose                                                                                                                                   atkwrapper.cxx              1074 0x7f2c26928a2e
            11  atk_object_wrapper_finalize                                                                                                                                  atkwrapper.cxx              670  0x7f2c26927677
            12  g_object_unref                                                                                                                                                                                0x7f2c3418c48c
            13  AtkListener::~AtkListener                                                                                                                                    atklistener.cxx             57   0x7f2c26900547
            14  AtkListener::~AtkListener                                                                                                                                    atklistener.cxx             58   0x7f2c2690057e
            15  cppu::OWeakObject::release                                                                                                                                   weak.cxx                    230  0x7f2c39556056
            16  cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release                                                                       implbase.hxx                115  0x7f2c2690a92e
            17  com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference                                                          Reference.hxx               114  0x7f2c39921b9f
            18  std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>>                                                       stl_construct.h             151  0x7f2c399217af
            19  std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> *>                               stl_construct.h             163  0x7f2c39920bd5
            20  std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> *>                                                     stl_construct.h             196  0x7f2c3991f10b
            ... <More>
        
        Reverse-debugging to the start of `atk_object_wrapper_dispose`
        (s. frame 10 above), shows that the the `mpContext` is`:
        
            uno::Reference to ((anonymous namespace)::OToolBoxWindowItemContext *) 0x5637df79f1b8
        
        Also, call the base class implementation of
        the same method, i.e.
        `OAccessibleContextWrapperHelper::disposing`
        instead of directly disposing via
        `OAccessibleContextWrapperHelper::dispose`.
        The former will call `dispose` via its base
        class implementation if it hasn't been
        disposed yet, s. `OComponentProxyAggregationHelper::disposing`.
        
        Change-Id: Ief66ffbe075af40f10c5fafa62063bda55f66b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156610
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [5462924437213934c2993c1fe966803a4a9f9a52]

        SAL_WARN->SAL_INFO in ScXMLAnnotationContext
        
        these attributes are mostly irrelevant, and do not constitute an error
        
        Change-Id: Iac35b25b0077a8e1efa3b6e0a406507c80d5bb0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [13de5fc5396db63d4bd2f3e5fb4dc66c7ddd601f]

        simplify VclEventId::TabpageRemoved handling
        
        Change-Id: I9fe97a8d71fb898c0603ec76f7b86afb19c60654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-06  Miklos Vajna  <vmiklos@collabora.com>  [503a9252f1d51cc32095e09b11f6c95a57328019]

        CppunitTest_sw_xhtmlexport: rework to avoid preTest()
        
        Allows having the test setup and assert code next to each other, which
        helps debugging when the test fails.
        
        Change-Id: I39f5357798f9ec9866a1e504e196a9160c761bb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156580
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-06  Michael Weghorn  <m.weghorn@posteo.de>  [7aa758b9f4c5153673cdbedd558289df8b0cbd14]

        a11y: Just use std::map::clear
        
        ... instead of creating an empty map and calling
        `std::map::swap`.
        
        Change-Id: Ieb53cc1a75d1e52452987ad234562d175f762ad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156582
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-06  Michael Weghorn  <m.weghorn@posteo.de>  [e151ea63b0fb1d099410dab141953621a2d67328]

        a11y: Drop unnecessary casting/code for toolbox items
        
        All (top-level) toolbox items have always been
        `VCLXAccessibleToolBoxItem` ever since
        
            commit f7da8972336b8ce3e0fb71b0c50464508837a5f3
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Wed Jun 27 14:41:59 2007 +0000
        
                INTEGRATION: CWS a11ysep (1.1.2); FILE ADDED
                2007/02/28 07:29:13 fs 1.1.2.4: #i10000#
                2006/10/05 08:20:15 fs 1.1.2.3: MANUAL RESYNC m130->m185:
                file had been modified in MWS, but moved herein in CWS
                2005/09/28 11:35:38 fs 1.1.2.2: manual resync (files have been moved herein from another location): licence change
                2005/03/07 08:29:10 fs 1.1.2.1: #i44293# moved implementations herein from toolkit module
        
        , so the dynamic_cast to check whether an item is a
        `OToolBoxWindowItem` is unnecessary and misleading
        when reading the code.
        
        This is even easier to see now after
        
            commit af08e6c2f46a6d99b2e18fe176c15ec2b6edb2fd
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Aug 30 14:02:11 2023 +0200
        
                use concrete type for ToolBoxItemsMap
        
        `OToolBoxWindowItem`s are only set as children
        for the `VCLXAccessibleToolBoxItem`s, s.
        `VCLXAccessibleToolBox::getAccessibleChild`.
        
        Also drop now unused
        `OToolBoxWindowItem::getIndexInParent` and
        `OToolBoxWindowItem::setIndexInParent`.
        
        Change-Id: I7dcef304942ed25b77918f01cf9b679b6be6e23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156566
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2ae9eb8be8d7eb9c3a72953a295d128b45639ea3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd6faa2767ad72d56c94259cf100cab49591b209
          - tdf#155875 UI cmds Writer/Table in Help(31)
            
            + refactoring
            + Table - Size menu (part 31)
              + Merges optimal row/height into shared file
              + delete obsolete help pages
              + delete pages with no HID (obsolete)
            + Some pages will be revisited
            
            Change-Id: I06593f96f3953f0de43a290a956acab94af09b34
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156584
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-05  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fdb2a457708f345affa6dd254180220b08393c2e]

        (related) tdf#149796  align labels left - according to design guidelines
        
        Change-Id: If9973b94b19635efd607d4c057e098021eca474e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156532
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-09-05  sahil  <gautamsahil1947@gmail.com>  [b4dd91f3a10610924e736445e17506b49b619a70]

        tdf#114441 - Convert use of sal_uLong to better integer types
        
        Updated scrolling related variables to double from sal_uLong
        
        Change-Id: Ibf4bb3d55b074b5d2e369e4bc708b87bdfa302b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155644
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-05  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [300dc54b0424add2dbab5443dcbd46ba12f418fc]

        related tdf#150557: fix unified transparence initialization with alpha
        
        In 98319164284c4a25d6a2313e6b8a35d244d94e91, shadow alpha
        was passed in to UnifiedTransparencePrimitive2D instead of
        shadow transparence mistakenly.
        
        Fix that and pass shadow transparence instead.
        
        Change-Id: Idabedade5d753961648683869cb077de0e4523eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156573
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [277c651875604a98032b70d6b0bd0f274cfe5d12]

        use more concrete type in VCLXAccessibleBox
        
        and avoid some casting
        
        Change-Id: I755caf9ba5a333862d1a89a054359781544930f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c5deed0c5e1ca1e9a2a9315a38ab7b035d88bb9]

        use more concrete type in ParagraphInfo
        
        and avoid some casting
        
        Change-Id: I22ff61a028c102b0b8b03b53ac9657af0fbe5acd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6d9b793512a60f18db624452d8773f0e52c00081]

        drop a stray printf
        
        Change-Id: Ie9b48ab2db03c7c45aa4ffc24ca4532522bb60a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-05  Khaled Hosny  <khaled@libreoffice.org>  [ee187f6ed7873f3ebc1f845a4384a84713be1e9c]

        starmath: Always insert using SmCursor when inline editing is enabled
        
        Choosing which code path based on which widget has focus is not a very
        good idea, and leads to unreliable UI tests as each code path inserts
        the text slightly differently (one code path inserts plain text then
        parses the whole equation again, while the other parses the new text
        then inserts the parsed node directly).
        
        Change-Id: Ib2ca942c537e466f6ff100be7f95adaead99f1d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156578
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [15e0dfe709636b517bc1876caa3853606d9b499c]

        tdf#154138 C/P regression - used setWidth instead of setHeight
        
        Change-Id: I2433b4d32e939cadf499b61dfa9033125eaa3c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156557
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [185ca3f1010283f84009c160f0dc564f71039b0c]

        call WebSocketClient.close from XConnection.close
        
        to drop the connection, otherwise we stick around until we timeout
        after trying to exit
        
        Change-Id: Ia4ca95b022b9234219da4658512603ebf918ff35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0766ffbf7fae8f250d735ed1473909fcec412c6]

        use more concrete types in AccessibleListBoxEntry
        
        which means we only need one field, not two
        
        Change-Id: I0229348a797d0f01f3d35c46563efed161676efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [1775b0c25ab13dab94c5ce930d45347a25198af4]

        disable unreliable navigator UITest
        
        Change-Id: I8f7c895a983d75814e237284f37692ba6cf7a077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156558
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [55eef24a55afb3708f2e02abf65b6934bed7f3de]

        crashreportScraper: Add ratio column
        
        it makes sense to sort the sheet by this column
        
        Change-Id: I05603dac80289605c18e86fbf27c3d899f9862c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156562
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [12f271ac519dfb018395b9680f082c183cd3dd14]

        tdf#156569: '%' can be in the middle of the string
        
        Change-Id: I5d6ab57c17ab2cbce4d3df629a91a006fad2198d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1247697aff263fa3098edb6fd78e0c47b5ab026]

        DRY use existing method in SwXShape rather than open-coding
        
        Change-Id: I1dc66d4161411998ab36e454ad168cada2dc7a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [da558946bec0f052fd6f3815faf859b69262a2b0]

        websocket URP flush hangs with large buffer
        
        over 4k hits limit so flush waits until something reads, but the
        read is in the same thread after the flush.
        
        We are just using _outputStream to accumulate the bytes to be send
        so change this to use a ByteArrayOutputStream and take over its bytes
        and clear it when we flush.
        
        Change-Id: I17b90e1c7d4302f153b5832e60ac0e0f2b86ace9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156565
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a7c5151a5bab89c70984a9b04540c9e0244ecf0]

        SAL_WARN->SAL_INFO in XMLShapeImportHelper
        
        these attributes are typically processed elsewhere, so this warning is
        not useful
        
        Change-Id: I2ebfe87e81e2959fbf25b17ed93a3bc80e1c6ab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fac945201bc381e0642218c380a6a72cfc6328c]

        SvxDrawPage does not need to use aggregation
        
        we use custom subclasses when we want to modify behaviour
        
        Change-Id: I1aef9e87c76ea97f1868134f5e1ac0e317b5c698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156559
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d8dbf35c48698e49c527d740853ce4edc4f1afa9]

        set java_websocket source as UTF-8
        
        to avoid
        
            [javac] core/workdir/UnpackedTarball/java_websocket/src/main/java/org/java_websocket/util/Charsetfunctions.java:88: error: unmappable character (0xC3) for encoding US-ASCII
            [javac]    * Implementation of the "Flexible and Economical UTF-8 Decoder" algorithm by Bj??rn H??hrmann
        
        with LANG=C
        
        Change-Id: Idc7296101f18ef4d0cbedb232834b1cc674444c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156552
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ca120667c3855fbfc1e3579d4cf4ed0e3b93770a]

        xmloff: rename m_aObject in XMLThemeContext and clarify
        
        Clarify what m_aObject is in the theme import (XMLThemeContext)
        and rename to a better name. It is refering to an object that has
        the "Theme" property, which is usually found in on XPage (master
        page) or XModel, but technically could be any object that has the
        property (for getting and setting the XTheme type).
        
        Change-Id: If15a8c42a0c516cd0566f4ee9e81f7315ef1651e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156511
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-05  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [98319164284c4a25d6a2313e6b8a35d244d94e91]

        tdf#150557: svx: don't factor in transparence twice for cell shadows
        
        multiplying child transparence with shadow alpha to get the
        correct shadow alpha has been incorrect maybe since commits:
        7eb4f92ed90e13ce5cbf7286fae623770e71324c,
        e735ad1c57cddaf17d6ffc0cf15b5e14fa63c4ad
        
        In ShadowPrimitive2D::create2DDecomposition the
        shadow-casting primitive's alpha(mask) itself is already
        being taken into account.
        
        Therefore getting cell shadow alpha by multiplying child
        transparence with shadow alpha, has the effect of child
        transparence being applied twice for the table cell.
        
        Change-Id: I78f9bbfcb0694a86eabc061330677784e887b5dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156528
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-05  Miklos Vajna  <vmiklos@collabora.com>  [6ee0f9f02f7255339e18ab9e6189b2200bb71e6e]

        sw: document SwFormatAutoFormat
        
        It can be a bit confusing that char formats go via an autostyle, while
        para formats go into the attribute set of the text node directly.
        
        Change-Id: Ie1138e91268974b1290c5754af5901cc360d4f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156550
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-05  Stephan Bergmann  <sbergman@redhat.com>  [d0166429887ab3cbe8c8369fd73668502d638a4a]

        Update the reference rdbs to libreoffice-7.6.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.6.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.6.0.3/instdir/program/types.rdb \
         .../libreoffice-7.6.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I3ed0f2fd05caaeb083ac8d5f3c40c30c389847b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156529
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-04  Michael Weghorn  <m.weghorn@posteo.de>  [410632ac4b8a280e0993e665ffa9cfede8326b49]

        a11y: Hold list items by rtl::Reference
        
        Use a vector of `rtl::Reference<VCLXAccessibleListItem>`
        for the children instead of a vector of
        `css::uno::Reference<css::accessibility::XAccessible>`
        and casting in various places.
        
        Change-Id: I1d0e72a7c844a685d762069002d747cf5e7d02dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156525
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-04  Michael Weghorn  <m.weghorn@posteo.de>  [307b9af2420d649b2e50817e38f8cb63687abf8b]

        a11y: Drop ListItems typdef
        
        Change-Id: Ie8d62b769c44ab74a21fadd9ab395fe0f908ee76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156524
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-04  Michael Weghorn  <m.weghorn@posteo.de>  [51de048ae97cbd371457dbc07120e30db9ee4187]

        tdf#157088 a11y: Dispose list items with list
        
        Don't only clear, but also dispose the
        list items when the `VCLXAccessibleList`
        gets disposed.
        
        Interestingly, there was already a comment
        saying
        
            // Dispose all items in the list.
        
        , but that wasn't done so far...
        
        Fixes a crash on exit with the below backtrace
        after using the font color toolbox item with
        the qt6 VCL plugin and Orca running:
        
            1  __pthread_kill_implementation  pthread_kill.c  44  0x7fe2a2ea80fc
            2  __pthread_kill_internal    pthread_kill.c  78  0x7fe2a2ea815f
            3  __GI_raise raise.c 26  0x7fe2a2e5a472
            4  __GI_abort abort.c 79  0x7fe2a2e444b2
            5  __assert_fail_base assert.c    92  0x7fe2a2e443d5
            6  __assert_fail  assert.c    101 0x7fe2a2e533a2
            7  (anonymous namespace)::implLookupClient    accessibleeventnotifier.cxx 140 0x7fe2a21138a4
            8  comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing   accessibleeventnotifier.cxx 185 0x7fe2a2113bb8
            9  VCLXAccessibleListItem::disposing  vclxaccessiblelistitem.cxx  164 0x7fe26870cb58
            10 cppu::WeakAggComponentImplHelperBase::dispose  implbase.cxx    230 0x7fe2a1c755e3
            11 cppu::WeakAggComponentImplHelperBase::release  implbase.cxx    204 0x7fe2a1c75312
            12 cppu::WeakAggComponentImplHelper6<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::release compbase6.hxx   142 0x7fe26870fc0c
            13 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference Reference.hxx   114 0x7fe28f2428a7
            14 QtAccessibleWidget::~QtAccessibleWidget    QtAccessibleWidget.hxx  39  0x7fe28f262cf9
            15 QtAccessibleWidget::~QtAccessibleWidget    QtAccessibleWidget.hxx  39  0x7fe28f262dd0
            16 QAccessibleCache::deleteInterface  qaccessiblecache.cpp    173 0x7fe28e0c8e4b
            17 QAccessibleCache::~QAccessibleCache    qaccessiblecache.cpp    31  0x7fe28e0c845c
            18 QAccessibleCache::~QAccessibleCache    qaccessiblecache.cpp    32  0x7fe28e0c84e2
            19 cleanupAccessibleCache qaccessiblecache.cpp    24  0x7fe28e0c83c8
            20 qt_call_post_routines  qcoreapplication.cpp    327 0x7fe28e9a4593
            21 QApplication::~QApplication    qapplication.cpp    663 0x7fe28cf9dff6
            22 QApplication::~QApplication    qapplication.cpp    717 0x7fe28cf9e2f4
            23 std::default_delete<QApplication>::operator()  unique_ptr.h    99  0x7fe28f2cf3ae
            24 std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication>>::reset   unique_ptr.h    211 0x7fe28f2cf7f6
            25 std::unique_ptr<QApplication, std::default_delete<QApplication>>::reset    unique_ptr.h    509 0x7fe28f2cd72d
            26 QtInstance::~QtInstance    QtInstance.cxx  273 0x7fe28f2c614f
            27 QtInstance::~QtInstance    QtInstance.cxx  274 0x7fe28f2c6226
            28 DestroySalInstance salplug.cxx 389 0x7fe299a62611
            29 DeInitVCL  svmain.cxx  600 0x7fe299b41226
            30 ImplSVMain svmain.cxx  229 0x7fe299b3f9f7
            31 SVMain svmain.cxx  236 0x7fe299b3fa53
            32 soffice_main   sofficemain.cxx 94  0x7fe2a30a1b5d
            33 sal_main   main.c  51  0x55c86565c9d4
            34 main   main.c  49  0x55c86565c9ba
        
        Change-Id: I42ddcf5501ddfb363aeae10a86f1c38251e6793b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156522
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-04  Michael Weghorn  <m.weghorn@posteo.de>  [bfa9d01920e7e042a83627d7fa4e78c70bc7ece5]

        tdf#157088 a11y: No need to use WeakReference for list children
        
        `VCLXAccessibleList` is the owner of the
        `VCLXAccessibleListItem`s held in that vector,
        so I see no reason to hold them by weak reference,
        which according to the doc in
        `udkapi/com/sun/star/uno/XWeak.idl` is to avoid
        affecting the lifetime of the objects:
        
        > <p>The sense of weak references is to hold a reference to an object
        > without affecting the lifetime of the object. That means that a weak
        > reference may become invalid, at any time, if the referenced object dies.
        > </p>
        
        Quite the contrary, it is actually responsible for the
        lifecycle of the list item a11y objects and should dispose
        them when itself gets disposed, which will be added
        in a subsequent commit.
        
        Change-Id: I57fe3367f1199cd0c24f006f6e25a1e9c930c154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156521
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-04  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [b273a0c1527193e21fbd0ccbc23853205f90056b]

        tdf#138792: PDF export: export metadata dc:format
        
        Export application/pdf MIMEType in dc:format
        
        Change-Id: I7cb658c869898df3a9436937329b4082843338bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156507
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-04  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [0deea02b1da1001fa497dc5afa5e43207af491d5]

        tdf#138792: PDF export: add batch of dublin core attributes
        
        Adds support for exporting, editing in the UI and storage in
        ODF for the dublin core attributes listed below.
        
        Contributor (http://purl.org/dc/elements/1.1/contributor)
        Coverage (http://purl.org/dc/elements/1.1/coverage)
        Identifier (http://purl.org/dc/elements/1.1/identifier)
        Publisher (http://purl.org/dc/elements/1.1/publisher)
        Relation (http://purl.org/dc/elements/1.1/relation)
        Rights (http://purl.org/dc/elements/1.1/rights)
        Source (http://purl.org/dc/elements/1.1/source)
        Type (http://purl.org/dc/elements/1.1/type)
        
        Introduces XDocumentProperties2 to extend XDocumentProperties interface.
        
        Change-Id: Ie2e0b1fbbbd00b66aef477ba1bf4e4f61c03a3b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156330
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-04  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [a45f72b8122d3bb4c0d5ac4252cf7e5a25d52291]

        tdf#138792: PDF export: export metadata pdf:PDFVersion
        
        Adds export of pdf:PDFVersion metadata.
        
        Change-Id: Ic4c3eec3672839d0d125b64dfca6149912cd2458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156329
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-04  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [7803c5749365c6dca6583708c14d6229c9659572]

        tdf#138792: PDF export: export metadata xmp:ModifyDate, xmp:MetadataDate
        
        Export metadata xmp:ModifyDate & xmp:MetadataDate - populate
        both with the same information as CreateDate.
        
        Change-Id: I391a72cbe4e7d1ebba5c04c402a68534bbeb4743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156328
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-04  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [07ac61f2c67020ad2941462ea7081f06495bcb92]

        tdf#138792: PDF export: fix date of xmp:CreateDate
        
        for pdf export xmp:CreateDate should be the modification
        date instead of the creation date.
        
        Change-Id: I2a86f30cb528cb2bd5e0f9e7c9a8a8b8d2993f50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156327
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-09-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a43f1ac6c964181cbaa4c889409688197cbf7a2b]

        tdf#48083 Import mso_fillBackground from ppt
        
        Change-Id: Ic60fbc5fcfd7b38e7dd594690e5cfe784061a3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156517
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [065609f86f730d4eedc6b7ae28382dc7daea11ac]

        starmath: Make cut/copy/paste buttons work with inline editing
        
        Check for visual cursor selection when in inline editing mode, and update edit
        window when updating visual cursor.
        
        Change-Id: Id1a259b67db47eea0b36b55d08ef5dc5f8aa8246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156513
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [f80c2c70756e3620daed6675c8546caca4153d4b]

        tdf#134193: Fix inline editing with RTL direction
        
        Change-Id: I65d3ed0d7c56839ce3674318144269719b043ba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156261
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [fe3098b4c4b5b8099e43279044db9ae7a1e0999d]

        tdf#134193: Fix RTL selection and cursor handling
        
        Change-Id: Ib9d7dd56d884aaca9b88a8b9403aeef30a9917d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156167
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [b6c30b3d35eb01205acf0271d0192921c60eb73b]

        tdf#134193: Allow setting math direction
        
        Add LTR/RTL buttons to the toolbar and make them change the
        IsRightToLeft property.
        
        Change-Id: I8ae793a9899c50b6dfaf3563a7c22c1f1eab8c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155739
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [fb43c497f2cc71c988a967fa0126c27561f8c16d]

        tdf#134193: Support rendering math in RTL mode
        
        Respect IsRightToLeft property and render accordingly.
        
        This also fixes math rendering in RTL UI, which was incorrectly rendered RTL.
        
        Change-Id: Id8520930f09a21daa1c70e40a765ac25572ea994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155738
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [5c5c71266ff14493975f20ff5807f31565a3f909]

        tdf#134193: Add the ability to set RTL math direction
        
        This adds a new IsRightToLeft document property, reads/writes it, and
        sets dir="rtl" on the top level MathML <math> element if set to true.
        
        Rendering will be handled in next commits.
        
        Change-Id: Ia3078b8a269fef7c3f037a2f1b7799744df2680b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155737
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e3d13aaf1a22edbbdb988538daa20ff4e140e845]

        bump to glade 3.40
        
        Change-Id: I3a40bce7391fef9228fa63b225e4d4fe89a9b928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156445
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-09-04  Miklos Vajna  <vmiklos@collabora.com>  [9bb4fa71c230a34a07ea9b7c4e4f13f4d3f7b5fe]

        svx: prefix members of SdrGluePointList
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia58a0c5319d51c463db23bae250e6c0c5e7a9741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156505
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ac7d339a97efa638124c2862551e0876487833b]

        tdf#156985: sc_ucalc_formula2: Add unittest
        
        Change-Id: Iaf6d4310eb40bfc4880902f57a75b7f85a8af906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156508
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-09-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d4cebb60c7757086fd737e7a2134326209bd4190]

        tdf#154875 "Use slide background" is only for Impress
        
        Change-Id: I078437a1cff58b868f4db4b482ad2aff335dc965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156514
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-04  Adam Seskunas  <adamseskunas@gmail.com>  [b1b002c293ddf38be125dc9083f41eb27452c450]

        tdf#147021 use std::size instead of SAL_N_ELEMENTS
        
        Change-Id: Ibc6c83f950890ac9b7a754cc49973736fa81dcb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156364
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-04  Aron Budea  <aron.budea@collabora.com>  [4d8cff696cfdb23733b0e91348b28a83f1c3bedc]

        sc: ui: view: Use conditional assignment
        
        Change-Id: I51ba012079a955c139a0c55f12a4b141ba536aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156502
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2023-09-04  Dan Horák  <dan@danny.cz>  [3426c96d0e32e0c83e4ce5fdb3405787a0c81e6c]

        limit tests giving dubious results to x86_64
        
        We have confirmed that ArrayFunctionsTest::testDubiousArrayFormulasFODS
        gives different results depending on the -ffp-contract setting on
        ppc64le and likely also on s390x in addition to aarch64. Thus limit the
        check only to x86_64 where it's known to give consistent results.
        
        Change-Id: Iedb63fb4340cfe9a88e374c7498d97574bcdfcc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156453
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-04  Julien Nabet  <serval2412@yahoo.fr>  [4a501a7270a0dd476ff71f72fae2c9fb9b40520a]

        Related tdf#108976: Crash in: OutputDevice::GetOutputSizePixel()
        
        On pc Debian x86-64 with master sources updated today, I encountered this:
        5  0x00007f68124533a2 in __assert_fail
            (assertion=0x7f67016aea9b "_pInterface != NULL", file=0x7f670156834a "/home/julien/lo/libreoffice/include/com/sun/star/uno/Reference.h", line=385, function=0x7f6701592970 "interface_type *com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject>::operator->() const [interface_type = com::sun::star::embed::XEmbeddedObject]") at ./assert/assert.c:101
        6  0x00007f67023ed042 in com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject>::operator->() const (this=0x7ffe3b5f11c0) at include/com/sun/star/uno/Reference.h:385
        7  0x00007f67030a7ba9 in ScClient::ViewChanged() (this=0x55fb3b69e7b0) at /home/julien/lo/libreoffice/sc/source/ui/app/client.cxx:191
        8  0x00007f680f1d13db in SfxInPlaceClient::Invalidate() (this=0x55fb3b69e7b0) at /home/julien/lo/libreoffice/sfx2/source/view/ipclient.cxx:840
        9  0x00007f680f1d59db in SfxInPlaceClient::SetObjArea(tools::Rectangle const&) (this=0x55fb3b69e7b0, rArea=...) at /home/julien/lo/libreoffice/sfx2/source/view/ipclient.cxx:764
        10 0x00007f6703b74c30 in ScTabViewShell::ConnectObject(SdrOle2Obj const*) (this=0x55fb3ca0b880, pObj=0x55fb3c68b2c0) at /home/julien/lo/libreoffice/sc/source/ui/view/tabvwshb.cxx:107
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=189332
        
        Change-Id: I0b48f2e624b249438d8d4fbc53057f89f5877c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156509
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-04  Adam Eric Fallon  <adam.eric.fallon@gmail.com>  [b0a9a21aee0588998d43f73ddb44b94391e2d40e]

        Added horizontal line and autocorrect to tabbed and compact tabbed interfaces.
        
        Change-Id: I8a269052f3da09d079f0f872ef24ca23bbba4107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156348
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-09-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b5effb66ee1563689c27ff10b682357120ab7786]

        tdf#151188 Select correct fill type in sidebar
        
        Change-Id: Ic123e6b21009cc57bf1c4b5f4edc6dcd277bae0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156510
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-09-04  Bayram Çiçek  <bayramcicek2125@gmail.com>  [c68e1dca3a5a06248ce129bfb13206753163d71d]

        tdf#49895: show wait cursor while Options dialog loads
        
        initializing of the dialogs happens at two stage:
        - at the loading of the Options dialog
        - at the time of searching
        
        We have to notify the user that there is a process ongoing.
        Therefore, a wait cursor indicator added to the both
        stage of the initialization.
        
        Change-Id: Ia1c6318aa961424e957ae27ac2ff5f496180cb81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156312
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2023-09-04  Khaled Hosny  <khaled@libreoffice.org>  [03c43d303b6d32dc4c39bd273d446b66a3e6c42d]

        Math: enable in-place editing on desktop
        
        Move the code outside the else block as it doesn’t get hit for me on
        desktop otherwise, and use SmViewShell::IsInlineEditEnabled() instead of
        comphelper::LibreOfficeKit::isActive() (which is included in the former).
        
        Followup to:
        
        commit 737a270c61cd2038ede7911b7d7b4afcf020f53c
        Date:   Mon Jan 17 17:15:46 2022 +0300
        
            lok: enable in-place editing of math equations
        
        Change-Id: Ie604f152344b83479eaf6024b6d58e374abb39b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156331
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-04  Miklos Vajna  <vmiklos@collabora.com>  [401c175d1bbe3c64e5dd96e3b23779999271cfb1]

        tdf#156318 sw floattable: fix follow text flow handling on interactive edit
        
        Once the bugdoc has 1 col for pages, setting the top and bottom margins
        to 2.5cm created a split fly, but the follow fly was on page 3, not on
        page 2.
        
        What happened is that the layout was already wrong before calling into
        SwFrame::GetNextFlyLeaf() (that does the split), the "follow text flow"
        feature shifted the fly down (top was originally 1341, then the
        increased margin means 2475, but an additional 4329 was set), and then
        the fly was created on the wrong page.
        
        Fix the problem by not calling GetAnchoredObj().SetObjTop() in
        SwToContentAnchoredObjectPosition::CalcPosition() when the fly doesn't
        fit anymore, this way the fly can shrink, a follow can be created and
        some of the content will be moved to the follow fly, leading to a
        correct split fly on pages 1 & 2.
        
        This also fixes the previously appearing "fly frame has negative height
        now" warnings on setting the page margin.
        
        Change-Id: I75bf9cfa19dc5c7ce9607417d6a4121b8e85ac47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156506
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-04  Julien Nabet  <serval2412@yahoo.fr>  [1761680a8f8f4a4dfa50e5be4c9a94ffa2aa46b2]

        Make nPropSetId vars sal_uInt16 instead of sal_Int8
        
        since:
        - for some lines, it's initialized from propMapType() which returns m_nPropMapType which is sal_uInt16
        - for other lines, it's used with GetPropertySet which takes a sal_uInt16 as parameter
        
        Change-Id: I7fd29c5aabd6a32ff38f72ca245d7549627e3e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156501
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-03  Khaled Hosny  <khaled@libreoffice.org>  [cc7d6211bc01e5ec84dbad542605d2e93dea925c]

        starmath: Disable formula cursor toolbar button when inline editing is enabled
        
        It is ignore when inline editing is enable, so better disable it to make
        it clear.
        
        Change-Id: Ie79a1c16109109e213658d44a6ffc0bff2291c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156487
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-03  Khaled Hosny  <khaled@libreoffice.org>  [2d47c824cd31294899fa24989b3d7bd4f98dcdee]

        starmath: Graduate inline (visual) editing from experimental features
        
        It has been experimental for as long as LibreOffice existed, lets make
        it non-experimental but add an option to disable it. If it turns to be a
        disaster, we can flip the option and disable it by default.
        
        Change-Id: I63672c054d1ead269863079e7f9c118a44b3ba19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156486
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-03  Khaled Hosny  <khaled@libreoffice.org>  [0fd5465b80063fcfc9d1230bc88627d2f69f9b51]

        starmath: Re-save smathsettings.ui with newer glade
        
        Change-Id: I2a2802eafa0d77e1a35131dbe7bd9ca003aa3c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156485
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-09-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f7d3d0e39025b6019922b62fc60961e09c5296d]

        each websocket URP message is taking a full second
        
        because the data written here doesn't appear to the reader
        on the other end until a full second expires.
        
        https: //bugs.openjdk.org/browse/JDK-8014239
        Change-Id: I9b6f4d51562f4dd0866ff0fccd5951b1efe38f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b4b2f1a58a888855a03a3d4d5c2104350e05b1a9]

        Related tdf#156116 - A11Y - fix goto textframes after renaming object
        
        Only give one warninig message (Anchor Frames/Text boxes “As Character“.)
        per floating textframes.
        Fix goto after renaming textframe.
        
        Follow-up of:
        bac847ded67941c6db21a2f041a0b9dad9d2b0bd
        069569e4a095f2fe42e94c2dad15356e2038727a
        
        Change-Id: Icc2a9cc90fcb948821a5420b8a1dab61a3a977ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156303
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-09-03  Julien Nabet  <serval2412@yahoo.fr>  [a853af876ff59733c60f205c0cdbc240c10f01a0]

        tdf#156958: fix crash when clicking out after having selected rename layer
        
        When renaming and clicking on canvas, LO goes into GetParent()->EndEditMode first time
        then it calls TabBarEdit::dispose method which resets m_xEntry BUT, on the same thread, LO comes here again
        so return if already disposed to avoid a crash
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=189316
        
        Change-Id: Id227e8aa32ab52643ab17f714c9e3325ced94907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156482
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-03  Jean-Pierre Ledure  <jp@ledure.be>  [f9c4973ac604ae091de08484ee2f5599db90a3a3]

        ScriptForge - Upgrade version number (7.6 => 24.2)
        
        Change-Id: I0e7ceeafcf4c5a802249125e6be44a71adb1456b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156480
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [58cfb2ca63b1f08cc1f527d342ece0e4c68035c9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ae7099c3ba435fc466b2483d2d63d5e1bf493f6
          - tdf#155875 Tab'd UI cmds Writer/Table in Help(30)
            
            + refactoring
            + Table - Select menu (part 30)
            
            Change-Id: I50fb5b6ce2e9f9853ae6d182e9c022b66b20a33a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156481
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b83dc3b47c5c46fedb7d8b042b0ccd43b02a9147]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f4db39698603879915e68dad07c67251dacb417
          - tdf#155875 Tab'd UI cmds Writer/Table in Help(29)
            
            + refactoring
            + Table - Delete menu (part 29)
            
            Change-Id: Ic4220a237cd8bf71e4444b22a6c028c6ab126b1b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156478
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cd49503f6e8a65d9f42ac04b5ec6d9df45f8fc89]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d7d0008afcbcca0d8e3724eeff9125ddae37e77
          - tdf#155875 Tab'd UI cmds Writer/Table in Help(28)
            
            + refactoring
            + Table menu (part 28)
            
            Change-Id: I86e159ff2bcfb5edbd3b840dad5b1a7279fe57b4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156477
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-03  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [115c8b42b8db7882f3e10e7ff1ef2f48d3ef973c]

        Revert "tdf#130924 replace '*printf' with 'SAL_*' logging macros."
        
        My mistake, did not notice
        https://bugs.documentfoundation.org/show_bug.cgi?id=130924#c5
        
        We shouldn't hide test output.
        
        This reverts commit df0db4132428e95d276e923d8d5fb603dbb7f7bb.
        
        Change-Id: Ieac40effb57333322f8db8ead093a83765d17a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156479
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-09-03  Jean-Pierre Ledure  <jp@ledure.be>  [b3278aa41d036a7fd9f3a8ce9aa683397e87e6a8]

        ScriptForge (SF_Document) new XDocumentSettings property
        
        The XDocumentSettings property returns a
           com.sun.star.XXX.DocumentSettings
        UNO object.
        
        XXX = sheet, text, drawing or presentation
        
        It gives access to a bunch of UNO internal
        properties, specific to the document(s type.
        
        The property is available in Basic and Python
        user scripts.
        
        An update of the SF_Document service help
        page is required.
        
        Change-Id: I9d6db473c91ac5b1814def9cd100e874aa5490cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156475
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [3c7a35dd28fbc337a23473873b3dd47392b883ae]

        no need to use UNO_QUERY_THROW here
        
        Change-Id: I01b4e401fec1792829fc2efaad5a74a035a418f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [21af3e5b5df02747691f08c453407d0abfc91242]

        use more concrete type in chart::AccessibleTextHelper
        
        Change-Id: I3ad20c37bb2009964cf20a1ee184b2674de82817
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156470
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [2b1d21d5cd79da6990412e0bd390f1514218f1c9]

        drop ChartController service name
        
        not the implementation, just the registering as a component - there
        is no way to instantiate and use this object as a real service, it
        is intimately tied into the chart2 internals.
        
        Change-Id: I5c80e23f2b043bef23650664a7cc2c7813248433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156471
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [7d02c59170a0ec1b9ef726554795d06f5e3ea05c]

        use more concrete type in AccessibleCell
        
        Change-Id: I21869dbbf722b9d5985e97e921fc131fe8fe2d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [151eb21f7a5e14df0d3367466b150afd2571bddd]

        use more concrete type in AccessibleTableShapeImpl
        
        Change-Id: I6acc54c1c178815805fc1a724ad4c00b17a5ed6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [19b8bac2aa59d02968c33ac6f83c66907d5ab94c]

        tdf#149611 qt: Make auto-selection of dark app colors work
        
        Rename the newly introduced method
        `QtFrame::isUsingDarkColorScheme` to detect whether
        a dark color scheme is in use from
        
            Change-Id I8f347c6e7f775cc55377c5c84481de3051c3cf24
            tdf#156894 qt: Prefer dark icon theme in dark mode
        
        and let it override `SalFrame::GetUseDarkMode`.
        
        This gets used (via `MiscSettings::GetUseDarkMode`)
        in `ColorConfig::GetDefaultColor` to determine what
        application colors to use.
        
        With this, setting "Tools" -> "Options" -> "LibreOfficeDev"
        -> "Application Colors" -> "Automatic" to "System Theme"
        will now automatically switch to dark application colors
        (like a dark doc background instead of white) for kf5/qt6
        when a dark global theme is active (e.g. because "Breeze Dark"
        has been selected in Plasma system settings).
        
        Change-Id: I151e7eb35a94a9c525452a7d90b24283f6226904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156467
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [73d0d205c43a9848acd313ff1845ebafe63e807c]

        tdf#156894 qt: Prefer dark icon theme in dark mode
        
        When in dark mode, pass the param to prefer a dark
        icon theme to
        `StyleSettings::SetPreferredIconTheme`.
        
        For Qt >= 6.5 use `QStyleHints::colorScheme`
        introduced in Qt 6.5 to get the color scheme.
        For older Qt versions, use the same algorithm based
        on the gray value of the window background as
        xdg-desktop-portal-kde does for evaluating whether
        a light or dark color scheme is preferred [1].
        
        On my Debian testing, the Breeze dark icon theme is
        now used as expected with kf5 or qt6 when setting
        the Global KDE Plasma theme to "Breeze Dark" and
        manually setting the Icon theme to "GNOME" afterwards.
        Previously, this would not use a dark icon theme and
        icons would be hard to see.
        
        Without manually setting the icon theme to "GNOME",
        the Breeze Dark icon theme would already be used
        before, because selecting "Breeze Dark" as the
        global KDE Plasma theme also selects the "Breeze Dark"
        icon theme by default, and therefore "breeze-dark"
        was already passed as the first param to
        `StyleSettings::SetPreferredIconTheme` and since
        that icon theme is present, the `bPreferDarkTheme`
        wouldn't be evaluated at all; it's only used
        when determining the fallback icon theme when
        the specified icon theme is not present.
        
        (Likewise, by enabling the "Breeze Dark" global theme
        and then manually setting the icon theme to "Breeze"
        in Plasma System settings, the Breeze light icon theme
        will be used in LibreOffice as well, resulting in hard
        to see icons, but I tend to think that that behavior is
        correct and works as designed - it's a misconfiguration.)
        
        The color scheme is also specified in xdg-desktop-portal
        (s. commit [2]) and can be retrived via dbus.
        
        Example with "Breeze Light" active:
        
            $ dbus-send --session --print-reply=literal --reply-timeout=1000 --dest=org.freedesktop.portal.Desktop /org/freedesktop/portal/desktop org.freedesktop.portal.Settings.Read string:'org.freedesktop.appearance' string:'color-scheme'
               variant       variant          uint32 2
        
        With "Breeze Dark":
        
            $ dbus-send --session --print-reply=literal --reply-timeout=1000 --dest=org.freedesktop.portal.Desktop /org/freedesktop/portal/desktop org.freedesktop.portal.Settings.Read string:'org.freedesktop.appearance' string:'color-scheme'
               variant       variant          uint32 1
        
        [1] https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/blob/0a4237549debf9518f8cfbaf531456850c0729bd/src/settings.cpp#L213-227
        [2] https://github.com/flatpak/xdg-desktop-portal/commit/d7a304a00697d7d608821253cd013f3b97ac0fb6
        
        Change-Id: I8f347c6e7f775cc55377c5c84481de3051c3cf24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156465
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-02  Noel Grandin  <noelgrandin@gmail.com>  [bdf2d664784b3ebe3e7078b9ec82a02d09d9ded8]

        use more concrete type in AccessibleChartView
        
        Change-Id: I1ec6c7bdd0f7ab487ba1ade89cd545f5bc97f540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b0b7db318717b64259fc136e8d5b3268cd9af1c3]

        Remove duplicated include
        
        Change-Id: I3a3ca7313e1921f806b256c7a66340d0e90a582e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156428
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-09-02  Julien Nabet  <serval2412@yahoo.fr>  [2ee60cb3535937eb85b808977a020b55a7123a92]

        tdf#156126: fix crash when using gpl color palette
        
        keep the do/while instead of a plain while since:
        1) you'll always got a empty line since aLine isn't initialized
        2) some palette may contain empty line
        eg: "Office 2016" palette from https://extensions.libreoffice.org/en/extensions/show/o2k10-color-palette
        
        Change-Id: I2874261b8dd13ce180ed05628b11bd3efce6720c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156421
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [16af9e81863a80116f808ee3cfa4a1bab7c67ac5]

        update clang asan suppressions
        
        which started showing up with my local clang asan build
        clang version 18.0.0 (https://github.com/llvm/llvm-project.git
        77c780816779bb595b5befe1d711addae67010d6)
        
        Change-Id: I7904be80657b4e5e7d2046a932b8ad9a34514a24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [aff6205058e896ffa129f9efa470b49adee0a09d]

        replace set(nullptr) with clear()
        
        It's a little easier to read, but mostly it makes an upcoming
        loplugin easier to implement
        
        Change-Id: I4ae7db8eda77795dab3255d1afd8ba4f20a8de76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156451
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9c636d76a9a7e167da39913ab60f5135f8e831a6]

        tdf#147704 fix reading TIFF metadata (width and height)
        
        When we prepare (not read and load) the bitmap we need to read
        only the metadata - most importantly pixel width and height. This
        didn't work correctly for the TIFF files or more importantly the
        specific TIFF files in the document, and the result was that the
        size reported was 0,0 and somehow the crop factor wasn't applied
        correctly. This change fixes the metadata reading and makes it
        more robust.
        
        Change-Id: I60951e5d01afc311c400589496ae82377ccb4cf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156457
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-02  Kohei Yoshida  <kohei@libreoffice.org>  [78d9d0d8dccb6fd8952435b8a13d525c7606f467]

        Apply font names and sizes to formatted strings via orcus
        
        Change-Id: I6809a184652b278eb66ee104558af19ea4a22ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156459
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-09-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [03bc5199f92e70b6168e4f79600ac288aa7b26ec]

        various theme and complex color related fixes
        
        Most of changes are a results of code reviews.
        
        Added comments and clarifications, removed unneeded methods,
        renamed variables to be more clear, protection against nullptr
        dereference,...
        
        Change-Id: Iae2b6abfa90b3bbd3f28328ca7fcf429765cbe9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156203
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-01  Michael Stahl  <michael.stahl@allotropia.de>  [ee3c3fcf5c48964f7bc1d64484409f072c614866]

        tdf#157028 sw: PDF/UA export: reduce the number of Span ILSEs
        
        Currently every text portion produces its own Span ILSE, which means
        there's at least one per line.
        
        But that seems a bit excessive, let's try to merge the portions and
        create new Spans only when needed, i.e. when the formatting properties
        that are exported change.
        
        ILSEs may even be nested, e.g. a Span may contain Link or Span.
        
        This will only merge within one SwTextFrame; merging across split
        SwTextFrames looks too difficult to implement.
        
        Change-Id: Id9b02332c580266f78da048be80ecceff1b28eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156299
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [6896c46567c571a7ae6eb60268de962e3d4ae8bb]

        connectiviy: fix to detect column data type
        
        if Base SQL query:
        
        SELECT COUNT("test"."id") from Test
        
        If changed to Spanish UI, detect the column type
        from a neutral context parser.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I1faa8ff8417a0fc4996b289bd2ce0baad52fc00c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156298
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156425
        Tested-by: Jenkins

2023-09-01  Henry Castro  <hcastro@collabora.com>  [3d910abdaa18bbd237834f412675ab25d90836bc]

        connectivity: add neutral context parser
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I12b0fe811d141873aaa64af5b6c457051c3356b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156297
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156424
        Tested-by: Jenkins

2023-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [136fbdec2cd3b3364c6d054793bdcb3b32d562eb]

        prefix the UNO-Url example with recommended 'uno:'
        
        as http://www.openoffice.org/udk/common/man/spec/uno-url.html suggests.
        
        Change-Id: Ifce9a9944f1a25bc0b6f89e5cec127a22bc6f990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [982bd513c65add804e83e2e74782740a5653742f]

        Fix typo
        
        Change-Id: I63b019aa12eb4898374162b0226728fd49bef93c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156427
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [443e72497e5ae55facad8ad24ae10c82d6c25f4d]

        android: Update Android Gradle Plugin to 8.1.0
        
        ... and gradle to 8.0, as suggested by Android Studio.
        Also, as suggested, let the upgrade assistant set the following properties
        to keep the previous behavior for these for now instead of applying the new
        default behavior:
        
            android.defaults.buildfeatures.buildconfig=true
            android.nonFinalResIds=false
            android.nonTransitiveRClass=false
        
        Those may be revisited in a follow-up step.
        See the Android Gradle Plugin release notes [1]
        for more details on the properties.
        
        [1] https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes
        
        Change-Id: Iec2f5766c0888e0f38438290b8fd814494afd837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155376
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e3b4bb25d4ef1684e1a370a34bc13ec65df23ea5]

        accessibility: fix crash in getAccessibleActionDescription
        
        See https://crashreport.libreoffice.org/stats/signature/SvTreeListEntry::HasChildren()
        
        Change-Id: I21879ad531a5c61b3a6808c373454522557e2ff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156403
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [4f60660bca1796184a4fe079b5ecdd562a36aa32]

        qt: Set window title etc. in main thread
        
        These QWidget methods need to be called
        in the main thread.
        
        Otherwise, opening the Update dialog
        ("Help" -> "Check for Updates", enabled
        by `--enable-online-update` autogen switch)
        triggers asserts like the one below with
        a self-compiled Qt 6 development build
        (qtbase dev branch as of
        c802a9e987c9e38c01580f467eab92a651b3e033).
        
            ASSERT failure in QCoreApplication::sendEvent: "Cannot send events to objects owned by a different thread. Current thread 0x0x7fff780160e0. Receiver '' (of type 'QtWidget') was created in thread 0x0x5555555fcd30", file /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp, line 537
        
            Thread 40 "InitUpdateCheck" received signal SIGABRT, Aborted.
            [Switching to Thread 0x7fff7ffff6c0 (LWP 1516868)]
            __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            44      ./nptl/pthread_kill.c: No such file or directory.
            (gdb) bt
            #0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44
            #1  0x00007ffff78a815f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
            #2  0x00007ffff785a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
            #3  0x00007ffff78444b2 in __GI_abort () at ./stdlib/abort.c:79
            #4  0x00007fffe32eb45a in qAbort() () at /home/michi/development/git/qt5/qtbase/src/corelib/global/qglobal.cpp:161
            #5  0x00007fffe32f9ee5 in qt_message_fatal(QtMsgType, QMessageLogContext const&, QString const&) (context=..., message=...) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:2057
            #6  0x00007fffe32f620c in QMessageLogger::fatal(char const*, ...) const (this=0x7fff7fffb980, msg=0x7fffe37fd9a0 "ASSERT failure in %s: \"%s\", file %s, line %d")
                at /home/michi/development/git/qt5/qtbase/src/corelib/global/qlogging.cpp:938
            #7  0x00007fffe32e9d54 in qt_assert_x(char const*, char const*, char const*, int)
                (where=0x7fffe38131e9 "QCoreApplication::sendEvent", what=0x7fff78180110 "Cannot send events to objects owned by a different thread. Current thread 0x0x7fff780160e0. Receiver '' (of type 'QtWidget') was created in thread 0x0x5555555fcd30", file=0x7fffe3812e18 "/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp", line=537) at /home/michi/development/git/qt5/qtbase/src/corelib/global/qassert.cpp:77
            #8  0x00007fffe33a4d74 in QCoreApplicationPrivate::checkReceiverThread(QObject*) (receiver=0x55555d27d5d0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:537
            #9  0x00007fffe19a3a81 in QApplication::notify(QObject*, QEvent*) (this=0x5555555fcb80, receiver=0x55555d27d5d0, e=0x7fff7fffc0b0) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:2584
            #10 0x00007fffe33a5ed0 in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x55555d27d5d0, event=0x7fff7fffc0b0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1125
            #11 0x00007fffe33a6991 in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x55555d27d5d0, event=0x7fff7fffc0b0) at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:1559
            #12 0x00007fffe1a279b4 in QWidget::setWindowTitle(QString const&) (this=0x55555d27d5d0, title=...) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qwidget.cpp:6119
            #13 0x00007fffe3c9d4c4 in QtFrame::SetTitle(rtl::OUString const&) (this=0x555555619d20, rTitle="Check for Updates") at /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx:365
            #14 0x00007fffedd98d44 in vcl::Window::SetText(rtl::OUString const&) (this=0x7fff7803cd90, rStr="Check for Updates") at /home/michi/development/git/libreoffice/vcl/source/window/window.cxx:3042
            #15 0x00007fffedd311c9 in SystemWindow::SetText(rtl::OUString const&) (this=0x7fff7803cd90, rStr="Check for Updates") at /home/michi/development/git/libreoffice/vcl/source/window/syswin.cxx:1048
            #16 0x00007ffff048bd6b in VCLXWindow::setProperty(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x7fff7804ac00, PropertyName="Title", Value=uno::Any("string": "Check for Updates"))
                at /home/michi/development/git/libreoffice/toolkit/source/awt/vclxwindow.cxx:1515
            #17 0x00007ffff03e486d in VCLXContainer::setProperty(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x7fff7804ac00, PropertyName="Title", Value=uno::Any("string": "Check for Updates"))
                at /home/michi/development/git/libreoffice/toolkit/source/awt/vclxcontainer.cxx:260
            #18 0x00007ffff04dfa2c in VCLXDialog::setProperty(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x7fff7804ac00, PropertyName="Title", Value=uno::Any("string": "Check for Updates"))
                at /home/michi/development/git/libreoffice/toolkit/source/awt/vclxwindows.cxx:2364
            #19 0x00007ffff06a89b7 in UnoControl::ImplSetPeerProperty(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x7fff7803b4f0, rPropName="Title", rVal=uno::Any("string": "Check for Updates"))
                at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrol.cxx:288
            #20 0x00007ffff06aa701 in UnoControl::ImplModelPropertiesChanged(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyChangeEvent> const&) (this=0x7fff7803b4f0, rEvents=uno::Sequence of length 51 = {...})
                at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrol.cxx:649
            #21 0x00007ffff0531ae9 in ControlContainerBase::ImplModelPropertiesChanged(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyChangeEvent> const&) (this=0x7fff7803b4f0, rEvents=uno::Sequence of length 51 = {...})
                at /home/michi/development/git/libreoffice/toolkit/source/controls/controlmodelcontainerbase.cxx:1600
            #22 0x00007ffff0575a25 in UnoDialogControl::ImplModelPropertiesChanged(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyChangeEvent> const&) (this=0x7fff7803b4f0, rEvents=uno::Sequence of length 51 = {...})
                at /home/michi/development/git/libreoffice/toolkit/source/controls/dialogcontrol.cxx:651
            #23 0x00007ffff06a95f3 in UnoControl::propertiesChange(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyChangeEvent> const&) (this=0x7fff7803b4f0, rEvents=uno::Sequence of length 51 = {...})
                at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrol.cxx:431
            #24 0x00007ffff66bc4ee in cppu::OPropertySetHelper::firePropertiesChangeEvent(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener> const&)
                (this=0x7fff78006170, rPropertyNames=uno::Sequence of length 51 = {...}, rListener=uno::Reference to (UnoDialogControl *) 0x7fff7803b540) at /home/michi/development/git/libreoffice/cppuhelper/source/propshlp.cxx:961
            #25 0x00007ffff06a8c6b in UnoControl::updateFromModel() (this=0x7fff7803b4f0) at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrol.cxx:320
            #26 0x00007ffff06aefc9 in UnoControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x7fff7803b4f0, rxToolkit=empty uno::Reference, rParentPeer=empty uno::Reference) at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrol.cxx:1325
            #27 0x00007ffff06c9905 in UnoControlContainer::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x7fff7803b4f0, rxToolkit=empty uno::Reference, rParent=empty uno::Reference) at /home/michi/development/git/libreoffice/toolkit/source/controls/unocontrolcontainer.cxx:727
            #28 0x00007ffff057336d in UnoDialogControl::createPeer(com::sun::star::uno::Reference<com::sun::star::awt::XToolkit> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindowPeer> const&)
                (this=0x7fff7803b4f0, rxToolkit=empty uno::Reference, rParentPeer=empty uno::Reference) at /home/michi/development/git/libreoffice/toolkit/source/controls/dialogcontrol.cxx:358
            #29 0x00007fffb7264e62 in UpdateHandler::createDialog() (this=0x7fff78003aa0) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatehdl.cxx:1232
            #30 0x00007fffb725b0e1 in UpdateHandler::setVisible(bool) (this=0x7fff78003aa0, bVisible=true) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatehdl.cxx:188
            #31 0x00007fffb7235887 in UpdateCheck::showDialog(bool) (this=0x7fff78000b90, forceCheck=true) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheck.cxx:1171
            #32 0x00007fffb7255c5e in (anonymous namespace)::InitUpdateCheckJobThread::run() (this=0x55555d192690) at /home/michi/development/git/libreoffice/extensions/source/update/check/updatecheckjob.cxx:148
            #33 0x00007fffb723a74a in osl::threadFunc(void*) (param=0x55555d192690) at /home/michi/development/git/libreoffice/include/osl/thread.hxx:189
            #34 0x00007ffff7f3f693 in osl_thread_start_Impl(void*) (pData=0x55555d1a68b0) at /home/michi/development/git/libreoffice/sal/osl/unx/thread.cxx:237
            #35 0x00007ffff78a63ec in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:444
            #36 0x00007ffff7926a1c in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
        
        Change-Id: I6ccdee00fe26619f201459ebbe6c4d8cf8b57b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156426
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Michael Stahl  <michael.stahl@allotropia.de>  [d5f68529a79c615f989fcfeef248d887a6e10f5a]

        sw: PDF/UA export: produce nested Sect SEs for nested sections
        
        Change-Id: I5b142acf00629ffd00562e2c8791587b7a7761df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156357
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [47d77c822fb58f9617379969b078c8a6230767d6]

        svx: add class "ONeutralParseContext"
        
        If Base SQL query:
        
        SELECT COUNT("test"."id") FROM Test
        
        Then changed to Spanish interface, it is required
        to have a neutral keyword localized, the "COUNT"
        will fail to detect column type, because the keyword
        in Spanish is "RECUENTO"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I191b9591ad796d0dd9509c0fb10b11c16f72e1ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156296
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156423
        Tested-by: Jenkins

2023-09-01  Henry Castro  <hcastro@collabora.com>  [50f36b75cee6591a00102c6e9fa71ba91df5bbd8]

        connectivity: fix return column type "DataType::SQLNULL"
        
        The Base SQL query:
        
        SELECT COUNT( "Test"."id" ) FROM "Test"
        
        And the UI language is set to Spanish, the function
        "getFunctionReturnType" returns misleading column type.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2b57d1dfc005711374d7ae0de66b412f4f551d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156295
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156422
        Tested-by: Jenkins

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [d57861bc1526122024a8f8d9051582ca22e1d7be]

        SAL_WARN->SAL_INFO in SfxDispatcher
        
        nobody cares if child window slot is missing
        
        Change-Id: I24978daa9a2770e8f0bd44b5b816f94b8d01da0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156407
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [7848c24fe7afbe1bece2499158aa2467b1f76f27]

        SAL_WARN->SAL_INF in SvxUnoTextField
        
        these are not indicative of any kind of problem
        
        Change-Id: Iad8b265fa7b397a4551b3037572a534d64952ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [34961dbc26856cfef518c606bc3b5972e8a062ce]

        remove DBG_ASSERT in MergedCellIterator
        
        this does not actually seem to be an error
        
        Change-Id: I6d286a3e614bc18f9655fa7e7c9716d2ae067fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156409
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b4545be2829e7184697718713fe505090d13872f]

        Fix typo
        
        Change-Id: I02772f9b9ace5c1fe955bd0039c5e6d8ce2cc4eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156450
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [89e2f268771ecb07948d3e67d220e28b2ae82e20]

        Fix typo
        
        Change-Id: If259a049d38f82210819a5adbf458eae1651cfaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156429
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [964fe83ec0ce36dab611c7e1cf22af7c8cce5860]

        tdf#155799: lok: sc: fix extend reference mark
        
        In the tiled rendering case, the server sends a reference
        coordinates to client side, so extend the range end point
        reference if merged cells.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ie9611aea3f6645a6cf45514939ae6364afac0b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155564
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156417
        Tested-by: Jenkins

2023-09-01  Eike Rathke  <erack@redhat.com>  [1f8cc7644293e62ad6430bbeec243d3283e478d7]

        Resolves: tdf#156985 Treat adding two KahanSum differently
        
        When summing mixed formula cells and numeric cells, cell type runs are
        summed using KahanSum that when switching cell types are added. Using
        add() to explicitly add the rhs m_fError compensation value separately
        may had lead to effectively cancelling out the relation of sum and
        error, living on with an unrelated error value. Instead, add a "final"
        rhs sum+compensation.
        
        Change-Id: I751d3e0eeef9cd80482895c24f05b1ab667c3020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156253
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [63b44ef7685c9a8e4a55584790521c75f7cc2628]

        distro-configs: Switch from JDK 11 to 17
        
        ... to prepare for the upcoming
        Change-Id I18251151392ca5edec8ca3d5cffd192d5f9f38b1
        ("Bump Java build baseline from JDK 11 to 17").
        
        Change-Id: I3bedc42fd8e05c1e5c61e0b2c9e8eefce31d0fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155377
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Skyler Grey  <skyler.grey@collabora.com>  [8e246331f6f71320cfcc8defdd04e756a75f71cf]

        Add a FunctionBasedURPConnection and a websocket URP connector
        
        - FunctionBasedURPConnection is used to enable a client to open a URP
          connection to a fresh Kit instance in COOL.
        - This URP connector can be used with that and
          https://github.com/CollaboraOnline/online/pull/6992 to use a Java Uno
          Remote Protocol client over websockets
        - For interoperability with existing Collabora Online websockets a
          prefix (urp ) is added to each message sent and a similar prefix
          (urp: ) is expected on each message recieved. This allows sending over
          the same websocket as other data is being transmitted through. If you
          are writing a bridge to work with this, you will need to add/strip the
          prefixes accordingly
        - This commit uses Java WebSocket
          (https://github.com/TooTallNate/Java-WebSocket) to send data over
          websockets.
        
        Change-Id: I2bda3d0b988bef7883f9b6829eeb5b7ae8075f27
        Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [cb72f56977faccbda9490bc16ea3cbf7a22c01b0]

        sc: filter: rtf: add method "WriteFontTable"
        
        Write the font table while visiting column/row and
        get the unique index to reference it.
        
        "The \fonttbl control word introduces the font table group.
        Unique \fN control words define each font available in the document,
        and are used to reference that font throughout the document."
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I20c5d1128972f5ec9b9b2e246f466bdb173ef8a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154906
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156415
        Tested-by: Jenkins

2023-09-01  Henry Castro  <hcastro@collabora.com>  [f0b2a9b1b33b55487dacc0998736dd403416d4df]

        sc: filter: rtf: add method "AddFont"
        
        Create a map font name associated with unique index.
        
        "The \fonttbl control word introduces the font table group.
        Unique \fN control words define each font available in the document,
        and are used to reference that font throughout the document"..
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I028226cb539865f1980f953385c887a3bd4b8e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154905
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156414

2023-09-01  Henry Castro  <hcastro@collabora.com>  [18e8c72d680b91da730dd8bb7c26c60b954ee074]

        sc: filter: rtf: prefix m_* private members
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If8389b6e63a90616131d0dd9fbb5a7b8b96ffe3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154904
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156413
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [a0a3500c58ae5bcb8ffb4126c43227ba0544f8bf]

        sc: filter: rtf: use a separate document stream
        
        "An RTF file has the following syntax:
        '{' <header> <document>'}' "
        
        In order to build the header:
        
        <header>
        	\rtf <charset> \deff? <fonttbl> <filetbl>? <colortbl>? <stylesheet>? <listtables>? <revtbl>?
        
        The font table should be created while visiting the column/rows.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Id72a3c87acab6cfc7889cf81f7e83a0d73e378a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154903
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156412
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [a5593114bb409c93c7cf79a3abac0c60a8aebb18]

        tdf#104833 a11y Send name changed event for text controls
        
        The text is at least often used for the accessible name of
        text controls (e.g. the MultiLineEdit case in tdf#104833).
        
        Therefore, also check whether the a11y name has changed
        from the previously remembered one in
        `VCLXAccessibleTextComponent::SetText` and send
        a NAME_CHANGED event if it has.
        
        This e.g. makes sure that the a11y name for the multi line
        edit in the update dialog is updated on Windows
        and NVDA properly announces it when it receives focus.
         (It now correctly announces "LibreOfficeDev 24.2 is up to date."
        instead of the obsolete cached name "Checking...").
        
        Also see how `VCLXAccessibleTextComponent::ProcessWindowEvent`
        calls `VCLXAccessibleTextComponent::SetText` when processing
        `VclEventId::WindowFrameTitleChanged` and this comment in
        `Window::SetText` mentions that `VclEventId::WindowFrameTitleChanged`
        is used to notify about a11y name changes:
        
            // #107247# needed for accessibility
            // The VclEventId::WindowFrameTitleChanged is (mis)used to notify accessible name changes.
            // Therefore a window, which is labeled by this window, must also notify an accessible
            // name change.
        
        Change-Id: I2f15fe78324b14c3bbeae943cb87384007e21618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156411
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [a766f7555c55c73e2dfd167e66f1bf32c75de6df]

        tdf#104833 a11y: Use VCLXAccessibleEdit for VCLXMultiLineEdit
        
        Instead of the generic `VCLXAccessibleComponent`,
        use `VCLXAccessibleEdit` as a11y class for
        `VCLXMultiLineEdit` (the component interface
        class for MultiLineEdit) as well, not just for `VCLXEdit`.
        
        With the preparatory changes from
        
            Change-Id I8218db61feb07605f6ea5309f26eebd38312458a
            tdf#104833 a11y: Don't use VCLXEdit in VCLXAccessibleEdit
        
        in place, it behaves as expected when interacting
        with the multi line edit from the sample dialog in
        attachment 189287 in tdf#104833 using Accerciser and
        the qt6 or gtk3 VCL plugin (and the text can also be
        edited when removing the readonly flag from the control)
        or the update dialog (which uses UNO controls,
        `UnoControlEditModel` for the panes that were not
        announced, s. extensions/source/update/check/updatehdl.cxx ).
        
        In particular, the a11y text interface is supported by
        the multi line edit on the a11y layer, which makes
        Orca with the gtk3 VCL plugin announce the text content
        when the control gets focused.
        
        NVDA on Windows still announces "Checking..." instead
        of using the actual text that would be retrievable via
        the IAccessibleText interface now. This is probably
        because "Checking..." is the (outdated) accessible name,
        as can be seen by interacting with the object in NVDA's
        Python console:
        
            >>> focus.name
            'Checking...'
            >>> txt = focus.IAccessibleTextObject
            >>> txt.text(0, txt.nCharacters)
            'LibreOfficeDev 24.2 is up to date.'
        
        For both, gtk3 and qt6, the a11y object does have the
        new text as a11y name as well, as can be verified in
        Accerciser:
        
            In [10]: acc.name
            Out[10]: 'LibreOfficeDev 24.2 is up to date.'
            In [11]: txt = acc.queryText()
            In [12]: txt.getTextAtOffset(0,3)
            Out[12]: ('LibreOfficeDev 24.2 is up to date.', 0, 34)
        
        Change-Id: Id80e191cdd5342b3215fdb9d2ad3847470366337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156402
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [847df831b1c46a257fd371c6a193387cc9c06c4b]

        tdf#104833 Move VCLXMultiLineEdit to public toolkit header
        
        This is in preparation of having the a11y factory
        create a proper accessible context for it.
        
        Change-Id: If60efa84263c2d68eb57daa3aae4834a060529c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156401
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [9a559df3fe2f623ac4eace30cdfeabb3a747c0e9]

        tdf#104833 a11y: Don't use VCLXEdit in VCLXAccessibleEdit
        
        Don't rely on the `VCLXWindow` of the control
        being a `VCLXEdit`, but use the `Edit` control
        directly, as is already done in other methods
        of this class.
        
        This is in preparation of using
        `VCLXAccessibleEdit` as the a11y class
        for `MultiLineEdit` as well, which derives
        from `Edit`, but its component interface class,
        `VCLXMultiLineEdit` does not derive from `VCLXEdit`.
        
        Already add reporting of the
        `AccessibleStateType::MULTI_LINE` state instead of
        `AccessibleStateType::SINGLE_LINE` to
        `VCLXAccessibleTextComponent::FillAccessibleStateSet`
        if the window type is `WindowType::MULTILINEEDIT`.
        
        Add a small helper function,
        `VCLXAccessibleEdit::isEditable` to use instead
        of `VCLXEdit::isEditable`, which does the same.
        
        Interacting with the single line edit from
        the sample dialog in attachment 189287 in tdf#104833
        in Accerciser still behaves as expected (and the
        text can still be edited when removing the
        readonly flag from the control).
        
        Change-Id: I8218db61feb07605f6ea5309f26eebd38312458a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156400
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-09-01  Henry Castro  <hcastro@collabora.com>  [4c2aa7e073d6ab9f063272011d2866addeeed526]

        lok: use constant keys enumeration
        
        Useful to better readability code.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I335d010c3b1ddf3f8052b7ed6cb0f94ad20045f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155495
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156416
        Tested-by: Jenkins

2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [670f0c406707a20422124396b6f8da235de7b3a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dd8981d39d51a2b75f014a7196f16fb7622461a7
          - tdf#155875 Tab'd UI cmds Writer/Styles in Help(27)
            
            + refactoring
            + Manage Styles menu (part 27)
            
            Change-Id: Ic3d001bdcf707354b53f92fe4774065f6b81ccf1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156419
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b991f7024d30ab790a6b699404563c38904296e4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96d055e7a733a62dc39ddd4dec58e31e6ad7db85
          - tdf#155875 Tab'd UI cmds Writer/Styles in Help(26)
            
            + refactoring
            + Style Update dialog box (part 26)
            
            Change-Id: I4e9280e84a90b87cb8efab6b9035e24cfaa99345
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156418
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [4efade746a70e61bda6be17bcdb4aaa425c5efc1]

        disable unreliable librelogo uitest
        
        Change-Id: Icdd2add6260cc1a3dc309abcaaf9e7531676081c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Julien Nabet  <serval2412@yahoo.fr>  [85aa230aebfe383eecdb4fc6704d093db8a18402]

        tdf#157034: FILESAVE loext:theme-type is off by one
        
        nItemId begins with 1 but list of themes begin with 0 so decrement nItemId
        part of bt here:
        https://bugs.documentfoundation.org/show_bug.cgi?id=157034#c1
        
        + adapt QA tests
        
        Change-Id: I7913ea0f71abb9ff98039a9c45a49fdb8f709ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156350
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [151a43f3d00f6523079c53d6c2d064f80b9a55d6]

        update clang asan suppressions
        
        which started showing up with my local clang asan build
        clang version 18.0.0 (https://github.com/llvm/llvm-project.git
        77c780816779bb595b5befe1d711addae67010d6)
        
        Change-Id: Ia0290839300e245dd11161a5fbea0db746f9022e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156395
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [590408329ee47496c813709a1bcc8cd35f6ebbb1]

        adjust VclTextTest::testSimpleText
        
        on my machine, after a recent update, the text is scaled slightly
        differently (Ubuntu 23.04)
        
        Change-Id: I5ac5e0c76a4cc4c0468a9f0e9186f95004d4d24f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5c988edee5dd87b3c1a67f62a554c6e1c09d1fc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66868265f68f9f21a015995adac39fa3923d837b
          - Add missing file for Edit Styles
            
            Change-Id: If176ec185769def7eafb7113c8dc107487bccf6b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156390
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d20aa9013152cf71ca2073691705ad8e82d67c6c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd13056cba22995c1b846aa466fac2b7995a1919
          - tdf#155875 Tab'd UI cmds Writer/Styles in Help(25)
            
            + refactoring
            + Edit Styles dialog box (part 25)
            
            Change-Id: I3a627e45c659910696a3ab29cfa51870dd44c436
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156369
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [275a89cc095819bed7a0acb1f23f6132e7823002]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc32ce4040119c1a6b950e95f0612e04babb03ce
          - tdf#155875 Tab'd UI cmds Writer/Styles in Help(24)
            
            + refactoring
            + Writer Styles menu (part 24)
            
            Change-Id: I4ed8faa98d19642c7d682af2c8b3ca2a048a4c05
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156368
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff66803ec9ec26c918ef652a1478ff9d7da0c97b]

        Revert "tdf#100894 lots of Conditional formatting freeze calc Styles sidebar"
        
        This reverts commit 6fd755fb36472938757b2581cbe99f5e5fe1ae40.
        
        This causes tdf#157021, so revert until Caolán can look into it some more
        
        Change-Id: I4e25c72988468015ee3a76baf8ecdafc72c79d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [206ac77ec51d3ab25a83a573d49cb8995ea39065]

        show status indicator progress on svg export of slides
        
        somewhat related to https://github.com/CollaboraOnline/online/issues/6616
        just for standard export case for now
        
        Change-Id: If2399e29a1463b0a3b465e77c5d67565655999e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156360
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6bcdfb86d872e1a5c33c21dce68e7ee3da49d85f]

        outer check is mbExportShapeSelection so inner !mbExportShapeSelection
        
        Change-Id: If4356a0217296a1d91a1daa145f8deccd8ea0f8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156359
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-09-01  Miklos Vajna  <vmiklos@collabora.com>  [7d4213b9f0253b323750acceca8f4edb9d1a7fc5]

        Related: tdf#156318 sw floattable: fix handling of vert orient == top
        
        The bugdoc resulted in a layout loop on load. It was created by forcing
        pages to be in a single column + increasing the top+bottom margin of the
        page to 2.5cm.
        
        The problem was that the SwFormatVertOrient's m_eOrient is usually
        text::VertOrientation::NONE ("from top" with 0 offset), but here it's
        text::VertOrientation::TOP. These are meant to be more or less
        equivalent, but SwToContentAnchoredObjectPosition::CalcPosition() has
        different codepath for them.
        
        Fix the problem by making sure that TOP doesn't have a vertical offset
        for follow fly frame: do this by realizing that in case the "orient
        frame" and the "anchor" is not the same that may need no action, since
        the fly frame case changes the "orient" to the follow anchor and the
        "anchor" is the master anchor.
        
        The original scenario still needs more work, we don't hang anymore but
        the follow fly appears on page 3 instead of page 2.
        
        Change-Id: I1596a07b78575583070d494ddb8e1400e5653820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156392
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-09-01  Michael Stahl  <michael.stahl@allotropia.de>  [7aca867aa1e1e675c0a9d27d76bd069bc6d5f512]

        tdf#156306 sw: PDF export: refactor, split out BeginTagImpl()
        
        Change-Id: Ifcb8db6d9a5caaf50c0ca2794266fb501b59dee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156356
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-09-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b36f7769dd07a6b6f55cdf4ce76e2f39ed186e89]

        sc: add ODF import/export of the Theme + tests
        
        One missing thing is the support in calc to save the Theme into
        the ODS document and read that back. The theme element is added as
        a child element to the office:styles - the same as it already is
        added in Writer.
        
        Also adds "Theme" property as a top level document property
        so it is possible to get and set the theme in xmloff.
        
        Also tests have been added to cover this usecases.
        
        Change-Id: Ic214ff5e945b77d50e6c881def9d49509560a0e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156363
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b53a03d1d55de7fd04efc47c4a57baa11d72dd85]

        move theme element export to xmloff to remove code duplication
        
        Both Impress/Draw and Writer export the model::Theme in a similar
        way, but the code is duplicated. Remove duplication and move the
        code to a common place (on the SwXMLExport class) so it can be
        reused at both places.
        
        Change-Id: Id93acfafb0dd4ab0168b3228079f6ce6f64e6b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156362
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-01  Noel Grandin  <noelgrandin@gmail.com>  [6d8c6e8d60956fd36094035a526c1a29a902204b]

        fix ImpGraphic::operator==
        
        This was broken in
            commit 7b355669c6ddeab2e6cec692d6afdff41c61d0fb
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Sat Apr 14 15:13:05 2018 +0900
            Function to load graphic swapped out (loaded on demand)
        
        Change-Id: I8ad120b65da5a7c53e8f90c6e01207f75da11c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156310
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3bd81335c4128cb2f62487868a94882a97eaf66]

        use concrete type for SwAccessibleShapeMap_Impl
        
        avoid some unnecessary casting
        
        Change-Id: I422428fa3c31141d73171a22c6c58242a1c1be2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156319
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [14dc749f575a8faea301472ed22f9c6b24044e8d]

        use concrete type for SwAccessibleMap::mxCursorContext
        
        avoid some unnecessary casting
        
        Change-Id: I354ac67aa7a0c7f8ebe676315c66c97af31dc4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156318
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-09-01  Miklos Vajna  <vmiklos@collabora.com>  [f81554ef7855d76fbb1708b127c66e29c5d125bd]

        sw layout xml dump: move at-content fly dumper to flycnt
        
        That's where the rest of the SwFlyAtContentFrame member functions are
        defined.
        
        Change-Id: I0215a21c6f3bf41a1e5998b2c5a91864c70f2f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156355
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-09-01  Stephan Bergmann  <sbergman@redhat.com>  [0feb934fbe3a5deee24cf373922d824ddf5ea7c4]

        Replace a macro with a function
        
        Such test code should generally be non-DRY, but using a macro rather than a
        function here didn't help much in that regard:  For a failing test, it just
        traded reporting the line of the failing CPPUNIT_ASSERT for reporting the line
        of the failing CHECK_GREEK_SYMBOL call, neither of which by itself gives
        sufficient context.
        
        Change-Id: Icce6a68d67d36e8809bf96dcd36ceef6b7b7c9eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156351
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-09-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [70663f464b24f223c4174681b9a469d9f554bcee]

        sd: set the theme for all master pages
        
        It can be annoying for the user to set the theme one by one for
        each master page. The reason for this is that in MSO the master
        slide (which contains the theme) has multiple layouts, which are
        converted to master pages in LO. As LO doesn't group master pages
        together the theme is defined on each master page, so it is needed
        to change each master page one by one.
        
        Change-Id: I94d75246ca012bbbb005ab376446c0941b8f57ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156361
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-09-01  Jim Raykowski  <raykowj@gmail.com>  [d88779fc86385dde1215fd28b78a69eacc6b4f97]

        tdf#156538 follow up: Use better tooltip activation rectangle
        
        This patch corrects the tooltip only being shown when the mouse pointer
        is in the top third of the window when using gtk3.
        
        Change-Id: I9d705c064bc4654ed660842215ffd59edc14891b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156358
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-09-01  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [140079362502408c75ceee67e86d779f61c0ac1b]

        remove AUTOFMT_DOCNODE
        
        - remove obsolete GetInfo()s
        - introduce SwFormat::IsUsed()
        - move handling from GetInfo to SwClientNotify
        - make sure SwAutoFormatUsedHint is forwarded to clients where needed (e.g. SwTextFormatColl, SwDDETable, SwPageDesc, ...)
        
        Change-Id: I07d9e94ee791ca6e738b4eb3e597055ad8fbe755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155504
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-09-01  Hossein  <hossein@libreoffice.org>  [345b214c37d1f645dd0e6e084358f8ca81d9ed66]

        tdf#149069 Revert "ridljar: check UnoClassLoader used for NativeLibraryLoader"
        
        This reverts commit 97b61ea3297e04e64aab1e1a4ec50202e9f86fff. It checked
        that the NativeLibraryLoader is an instance of the class
        com.sun.star.lib.unoloader.UnoClassLoader. If this is not the case, a
        warning was displayed. This was for java_uno bridge to work.
        
        On the other hand, as the comment in the code implies, "not a problem
        if this is using Java remote bridge or (in a) unit test". But, in the
        code there was no check for that. As a result, this warning is displayed
        in many places like the simple examples that want to connect to the
        LibreOffice process via Java API.
        
        Change-Id: I056ed372ad071573051024a63e51afd6b4425ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156302
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [462b0fee32442d6e6baffaf8a157d448dd0ecb4f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4913c6e46228cf9b750f30f686fbb2c70baf21c7
          - PDF export Help page, improve navigation
            
            Change-Id: Ic4f061289ed82cf2a42d2f0e714a4f7a40cd47e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156365
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [af8ee87852496e51d4c3e0e8f446503e4a8faabb]

        SAL_WARN->SAL_INFO in Access::getChild
        
        reduce log noise
        
        Change-Id: I95393f18fe8cc019c89ad4779d5b10f64993bd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [774ca713bf838ef6996e2598d4a43c6fea6bc85c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ffaa9e1adb04a683ec87eb5c4c35387384e32702
          - Prevent literal words to wrap in lines.
            
            Applies mostly on table columns
            
            Change-Id: Ie18b84d9a052f4b189f06c43132457a3a925dcaa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156354
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6363ecce73a9d5dfb5010b6b6fad4686ec4ab6fa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d686d91fb8d108c8283dd8d9f537224ed43ac6ac
          - tdf#147105 More PDF export param documented
            
            + Added index to this long page.
            
            Change-Id: I58089001532a4a2d8b2f309958117821e6fc237f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156353
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-31  Khaled Hosny  <khaled@libreoffice.org>  [626d17a8ec270937575e9684a325eb0669327a25]

        tdf#143213: Fix reading math font settings from file
        
        The order of reading the settings is significant, e.g. if font italic
        was read first then font name, font name would set a new font
        overriding the italic setting.
        
        We now collect all font settings and apply them at once.
        
        Change-Id: Idb32d7d416607011bc325eff0b73c03b2d12e7d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156352
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-31  Pierre  <prrvchr@gmail.com>  [5b205d2b3946acd79dcb8f5abed88a0bd8afaef4]

        tdf#156816 Base handles scale on SQL type TIME as with TIMESTAMP
        
        Generally import new DataType identification constants from OpenJDK's
        java.sql.Types
        Use same values for compatibility.
        
        Change-Id: I6e3eb986dc34e8a5e2af75669363177785ff56e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155866
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-31  Michael Stahl  <michael.stahl@allotropia.de>  [cd57d3c5743ca4ed4cf59eaabaee551c085d430c]

        tdf#156306 sw: PDF export: another implicit structure element
        
        BeginBlockStructureElements() calls BeginTag(vcl::PDFWriter::TOCI)
        when exporting fdo51792-1.odt
        
        sw/source/core/text/EnhancedPDFExportHelper.cxx:501: void SwTaggedPDFHelper::BeginTag(vcl::PDFWriter::StructElement, const rtl::OUString&): Assertion `rFrameTagSet.find(pKey) == rFrameTagSet.end()' failed.
        
        Change-Id: I71ab6a6522c580e8bb740862dc0867ee615d0273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156308
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-31  sahil  <gautamsahil1947@gmail.com>  [df0db4132428e95d276e923d8d5fb603dbb7f7bb]

        tdf#130924 replace '*printf' with 'SAL_*' logging macros.
        
        Change-Id: I5bb4052ded82c355f7d71e4f38ebdefe3fcc25da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156283
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [dec20ed5e833801f70f4138a47fb0f09f006f963]

        disable more of the unreliable track changes UITest
        
        tends to get stuck here, and then the build is eventually killed
        
        Change-Id: I281e3a54be2abfb54b24028b4775eb79bbdacf70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156349
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [cffc470c31062cd35f715bc45a53080735ff3356]

        ignore UnknownPropertyException in SdStyleSheet::setPropertyValues
        
        reduce log noise
        
        Change-Id: I25a61ecbc7c3357b980086b591f5906991244012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Eike Rathke  <erack@redhat.com>  [0603e8fd85f626340c756d80df5612343480beea]

        Related: tdf#156985 Adjust doc layout to what FunctionsTest::load() expects
        
        In case of failure to show failure details sc/qa/unit/functions_test.cxx
        FunctionsTest::load() assumes result in A, expected in B, check in C and
        formula in D.
        
        Change-Id: I48d9e123664da314a1f7791f949d89569150b0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156346
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [437db5267842d3985e3d4050096275da6dd45c3b]

        remove null checks for mpObj in UIObjectUnoObj
        
        Checking for mpObj == nullptr implies that in some sense this object
        could end up in that state, but the only way that can happen is if we
        call this object after its destructor has been called. In which case
        throwing RuntimeException is not appropriate because calling a dead
        object should not be possible.
        
        Rather just let it SIGSEGV instead of hiding it behind an exception that
        might be ignored.
        
        Change-Id: I92911a3108f74ed5dfa4986bec028cbc365ac916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [fffdfd9e58a6ec31be775123ae6d3f90a6e8e840]

        SAL_WARN->SAL_INFO in ImplGlyphFallbackLayout
        
        reduce log noise
        
        Change-Id: I479f936284922ad1062cab0e9ae78795aed84e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Regina Henschel  <rb.henschel@t-online.de>  [be53bf55c44dedd9a94c74b8f7c1c222746ed23f]

        tdf#157018 Enable import of color theme for Draw
        
        Use the color theme import in Draw too, otherwise we will not be able
        to detect theme colors.
        
        Change-Id: I8f01ba69848a6265193407a952144b31e3a7fdb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156313
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-31  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d1411afab98f7b41e9e700ef26b43dc77242d917]

        tdf#150815 sc: fix repainting sparkline
        
        On Windows, if the input range of the sparkline is not in the
        same row as the output range, the sparkline wasn't repainted
        after changing the data within its range. Force the update
        to avoid of showing obsolete data.
        
        Change-Id: Id56209b20387ee68144507a0102d3a0d093ff1ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156304
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f89cf39c8c6228e3580aa94db4978825ea1fba2]

        improve debug warning message
        
        Change-Id: I72f5966a6c144a40d81e479c3d8d27d345064993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Julien Nabet  <serval2412@yahoo.fr>  [8109a05543e16a5a499bf3ddc9d45b7c979480bc]

        Related tdf#156986: blacklist Nvidia RTX 4070 for Skia hardware rendering
        
        Change-Id: I3f59be1f5501684238a5ccd2736509afe7ac8d57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156334
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-31  Eike Rathke  <erack@redhat.com>  [63582b234ddcca3bcb1f76843363e5e7d0b0a08e]

        Related: tdf#156985 Do not fail for first empty check cell in test failure case
        
        So we can actually find a detail if there are empty rows and not
        just bail out with "Sheet2.A1 '' result: 0, expected: 0" or such.
        
        Change-Id: I163f84edebfb98f6f0351ba3dc889d3fab0e6789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156344
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [bbd1eaeb4f8a923d861aae15264b2d4138590642]

        a11y: Re-add check for empty reference in VCLXAccessibleTabControl
        
        It got lost with
        
            commit a3f77a61c03340b79930e89d5c4045d814b93edf
            Date:   Wed Aug 30 14:43:18 2023 +0200
        
                use concrete type for VCLXAccessibleTabControl::m_aAccessibleChildren
        
        and resulted in a crash when e.g. doing the following
        with the qt6 VCL plugin on Linux:
        
        1) open attachment 189287 from tdf#104833
        2) "Tools" -> "Macros" -> "Organize Dialogs"
        3) select the dialog from the doc
        4) select "Edit"
        
        Change-Id: I2c4aea951976738c575943a64d01eaac2766fdd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156343
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [6baacabbb74171287d449f23cb70bd2523b18039]

        ignore UnknownPropertyException in SvxShape::setPropertyValues
        
        which greatly reduces the log noise when debugging
        
        Change-Id: I556fb79c04b23f757b92ed635233d5222c177df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [60880c9a7634468a852d4b0bf2d7a69d41ac7d11]

        cid#1542447 Explicit null dereferenced
        
        Change-Id: I1de10a8a459175f79bb2b8f796cde287be1945c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9d9f9ee71464425a52c5798503840b106b210bc]

        tdf#156967 cal basic, CSV import macro crashes
        
        regression from
            commit ba4191ff0de05334ba32b53a09ad992710f03f9d
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jan 30 21:48:53 2023 +0200
            osl::Mutex->std::mutex in ImplEventAttacherManager
        
        Change-Id: I1557d9b6f66628fae1f466198ac4a8961e85e5bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fb467ae240de07bc381385ec0589a6e99ca7042]

        use concrete type for SvxShowCharSetAcc::m_aChildren
        
        avoid some unnecessary casting
        
        Change-Id: I73338c00b90357fe939e38a53f87a4ef9f13e86c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2c61ed43006066902984c37e6bd6b28a15968c9]

        use concrete type for SvxPixelCtlAccessible::m_xCurChild
        
        avoid some unnecessary casting
        
        Change-Id: I83ee8605052c8635b643f9c163b2b6b69b154884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [379d6042cd379df4988f891d068996ba8035f9da]

        cid#1542448 make_iterator always succeeds
        
        so (!xEntry) here doesn't happen
        
        Change-Id: I9d4d63a14220ba69bf57f1a58a6d36e270252e8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-31  Noel Grandin  <noelgrandin@gmail.com>  [2279fce1292fb5d699dda51e3bd19efdff8fb077]

        disable failing inputline UITest
        
        this test fails here on jenkins about 30% of the time
        
        Change-Id: Ie82f4f2621b7d05b7a74bba1b0b5c96b98314b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c21ed0c9136c0a26b6e7258492c635e988bb87a5]

        use concrete type for SwAccessibleTable::Cells_t
        
        avoid some unnecessary casting
        
        Change-Id: If9998f5ffd3c4b71f81f10e8f274671bb72da017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156317
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [89b6d1cd2ed3ea4633a8f4e90daf99001decef3e]

        use concrete type for AccessibleTabBarPageList::m_aAccessibleChildren
        
        avoid some unnecessary casting
        
        Change-Id: Ib8bddff9fe91afd192584fa1ad2728d0701f425a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [28c89e58d90ea73513e273db274eb46ff9081c35]

        use concrete type for OAccessibleMenuBaseComponent::m_aAccessibleChildren
        
        avoid some unnecessary casting
        
        Change-Id: Iaa9ce18d7a0772d894ec8f93e16f4f59ffaae77d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156315
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [5dbc129d49937f643f66eeeb23cbd8952597db15]

        use concrete type for VCLXAccessibleStatusBar::m_aAccessibleChildren
        
        avoid some unnecessary casting
        
        Change-Id: Id9e52b0b6dd8dc2cedc8b9cf80c17f1cf4afe502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Szymon Kłos  <szymon.klos@collabora.com>  [038bce9b92d8b8f64d1f3797c02d3cde3a9471c2]

        jsdialog: combobox rendering with DPI set
        
        Change-Id: I0efb8f765cc95e0eee02fb5905bc392fc754f3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156114
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156250
        Tested-by: Jenkins

2023-08-31  Szymon Kłos  <szymon.klos@collabora.com>  [3fad74eb9def27788faddd74f5285120e0aefdd9]

        jsdialog: render font previews with hidpi
        
        we pass dpi scale, let's use it to determine combobox entry size
        
        Change-Id: I4088eca565b301c5693e52b1c05af1a335fc34fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156115
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156251
        Tested-by: Jenkins

2023-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [eecf74196b852cddaaffbf7e0442fd2abbc36a5d]

        use concrete type for ThumbnailView::mxAccessible
        
        avoid some unnecessary casting
        
        Change-Id: Id3c4d8b91ec04beb1fed61050066e2b79d01d2df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156288
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-31  Miklos Vajna  <vmiklos@collabora.com>  [d082621130b01ebc6c7794dc54ff7ace76468599]

        sw: document SwFormatFollowTextFlow
        
        Change-Id: I720f01bea49415c0b150fcea222074fb1cbe61cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156307
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-31  Kohei Yoshida  <kohei@libreoffice.org>  [695ae365dcab7c7dd59b39411299c5c200081885]

        Add support for rich-text string import via orcus interface
        
        It was previously imported only as non-formatted strings.  Font names
        and sizes are to be imported later.
        
        Change-Id: I93a313851e87f1d6d9ccc409ca9a9f1abff3de0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156271
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-08-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4ffea8f932cbad912863f7df668ed7090e6f1821]

        increase max_len for fodt2pdffuzzer
        
        it's all gone very quiet since ofz#61511 Direct-leak
        
        Change-Id: Ia78de8b10e89905a29c0150f9582ad769e6984a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156311
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3f77a61c03340b79930e89d5c4045d814b93edf]

        use concrete type for VCLXAccessibleTabControl::m_aAccessibleChildren
        
        avoid some unnecessary casting
        
        Change-Id: I2f6ed71fbffbcdfad18ed03dd45c12ea1f52fff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [af08e6c2f46a6d99b2e18fe176c15ec2b6edb2fd]

        use concrete type for ToolBoxItemsMap
        
        avoid some unnecessary casting
        
        Change-Id: I582144f0654837ac8864679b38c3d2676d1089b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Ismael Olea  <ismael@olea.org>  [0974b4e97320a43040201557ff9c648a5f582b29]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c1ddcf602ba97f8e99383f34e8027074d8193f61
          - Updating RLA-ES Spanish spellcheker to v2.8.
            
            Change-Id: I749268a6e38e65e86633f39ea14710893cb6b468
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156268
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b58aeda083b245bd12b31f53c0fb1717af188cc4]

        use concrete type for ChildDescriptor::mxAccessible
        
        avoid some unnecessary casting
        
        Change-Id: I23e0257d1831c1c43d2d646d4ff8e1d654c0b528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbe8597ce4f8c503ac10836570a76a607b2ebb9c]

        use concrete type for ThumbnailViewItem::mxAcc
        
        avoid some unnecessary casting
        
        Change-Id: I86d48cb463f4e9a1661025fa6e1f4f8c03d61eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156287
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7379decd74f9f66011f0023d8903430293dc0532]

        use concrete type for ValueSet::mxAccessible
        
        avoid some unnecessary casting
        
        Change-Id: I2569aafb10431bcf1445efefd277b1aeecf7b404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156286
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [129e395935bf7330a1fe84986dd78502af36e07e]

        make IAccessibleBrowseBox extend cppu::WeakImplHelper
        
        i.e. push this up from the implementation class
        AccessibleBrowseBoxAccess to the interface class.
        
        Which means we don't need the getMyself helper method, and make the
        memory management simpler.
        
        Change-Id: Icecb83834bb3f5304908bbd3682b3d2ea06dbfe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156285
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c58ea89f4bbf7ec9a0ea88a8b753209ff68af64]

        make IAccessibleTableControl extend cppu::WeakImplHelper
        
        i.e. push this up from the implementation class
        AccessibleGridControlAccess to the interface class.
        
        Which means we don't need the getMyself helper method, and make the
        memory management simpler.
        
        Change-Id: Iced5f259638531a74ce86876d1a295e105530474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-30  Regina Henschel  <rb.henschel@t-online.de>  [cf1cdc00e1e2d2684cfe57ac002a37c5f3d100c5]

        tdf#156975 Save a Theme in Draw too not only in Impress
        
        Draw and Impress have many things in common and should therefore be
        treated equally where possible.
        
        Only if the theme colors are present in the document, colors can be
        recognized as theme colors during import.
        
        Change-Id: Ia1fae2aff989ae305c210efa3f925a80898880e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156267
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9254fbce6b9e20a75aa2a379bcf2fc9dc41a5b44]

        tdf#156835 - FILEOPEN XLSX: add SHA-384 encryption support for ooxml import
        
        Password protected file with SHA-384 encryption does not open before this
        patch.
        
        Change-Id: I482233f788b8e9da210ad6d2a6c4ece18d05d248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156282
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-30  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [53fed6a869d0fa983dd28a2f4c62b46d1e67a9f5]

        a11ycheckissuespanel.ui: rename label from Fakes to Simulated captions
        
        Change-Id: I8f46ac64dfb5cd72454abcc43dd2589da7091380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156238
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [efd357d70438b905c5349c304a43347fd293ee6a]

        a11y: Hold focused list box entry by rtl::Reference
        
        Use an `rtl::Reference<AccessibleListBoxEntry>` for the
        currently focused entry instead of using a
        `css::uno::Reference<css::accessibility::XAccessible>`
        and casting almost every time that it's used.
        
        Change-Id: Ia3aeca18e61d82b127bf19dd0902d781168b93d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156281
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [92d8c2cecd452374d17072b7d6fee09e0313ea85]

        update credits
        
        Change-Id: Ie682a8747bb5f51115815ccd0ac9e26a4c4c32f9

2023-08-30  Tibor Nagy  <nagy.tibor2@nisz.hu>  [f4c2ad6cc750a850dd32e5ae3aceb184ccc54fb5]

        Follow-up to tdf#152070 sd: fix unit test of tile background
        
        The test always failed if the output device DPI value is
        higher than 96, because of its PNG image without pHYs (physical
        pixel dimensions), so the size depended on the output device DPI
        and therefore offset value of image changes. Fixed with extending
        the PNG image with pHYs metadata.
        
        Follow-up to commit b12e38c1ccb388e62e35d856d4a575e1724a10e9
        "tdf#152070 PPTX import: fix offset of tile background image".
        
        Change-Id: Ic936ec8013bf39bea5fd5f7fce7f17588a72fed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156205
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-08-30  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bac847ded67941c6db21a2f041a0b9dad9d2b0bd]

        Related tdf#156116 - A11Y - show only one warning/textframes
        
        Only give one warninig message (Anchor Frames/Text boxes “As Character“.)
        per floating textframes.
        
        Change-Id: I6cff4022a30de9734d6afc592f52c7ad4297c18a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156200
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-30  Tibor Nagy  <nagy.tibor2@nisz.hu>  [7b93531ba7f3edf98a54392cfc83dcf3185888bd]

        tdf#156829 PPTX import: fix connector regression at missing glue points
        
        Glue points weren't imported if the custom shape type is
        "non-primitive", resulting broken line connectors, moreover
        broken graphic design, as attached to the original bug report.
        
        ~Regression from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8
        "tdf#89449 PPTX import: fix line connectors".
        
        Change-Id: I9908a23f8e6997bc1384aaeb3e8ba43c08d20d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156171
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [978cce0001ef9f37fb5fa5037a876f31ec558166]

        tdf#156683 a11y: Dispose a11y cells with tab list box header
        
        When disposing the `SvHeaderTabListBox`, also dispose
        the a11y objects for its header cells and clear
        the vector.
        
        This fixes a crash on exit that could e.g. be triggered
        as follows when using the qt6 VCL plugin on Linux:
        
        1) start accerciser
        2) start Writer with qt6 VCL plugin
        3) press Alt+F12 to open the options dialog
        4) enable "LibreOfficeDev" -> "Advanced" (i.e. Java Options dialog)
        5) in Accerciser, click through LO a11y hierarchy, in particular on all of the cells of the JRE table
        6) close the dialog and LO
        
        Backtrace:
        
            ~"#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44\n"
            >~"#1  0x00007f0f296a815f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78\n"
            >~"#2  0x00007f0f2965a472 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26\n"
            >~"#3  0x00007f0f296444b2 in __GI_abort () at ./stdlib/abort.c:79\n"
            >~"#4  0x00007f0f296443d5 in __assert_fail_base (fmt=0x7f0f297b8dc8 \"%s%s%s:%u: %s%sAssertion `%s' failed.\\n%n\", assertion=assertion@entry=0x7f0f28b376a0 \"rClients.end() != rPos && \\\"AccessibleEventNotifier::implLookupClient: invalid client id \\\" \\\"(did you register your client?)!\\\"\", file=file@entry=0x7f0f28b37478 \".../comphelper/source/misc/accessibleeventnotifier.cxx\", line=line@entry=140, function=function@entry=0x7f0f28b375b0 \"bool {anonymous}::implLookupClient(comphelper::AccessibleEventNotifier::TClientId, std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::iterator&)\") at ./assert/assert.c:92\n"
            >~"#5  0x00007f0f296533a2 in __assert_fail (assertion=0x7f0f28b376a0 \"rClients.end() != rPos && \\\"AccessibleEventNotifier::implLookupClient: invalid client id \\\" \\\"(did you register your client?)!\\\"\", file=0x7f0f28b37478 \".../comphelper/source/misc/accessibleeventnotifier.cxx\", line=140, function=0x7f0f28b375b0 \"bool {anonymous}::implLookupClient(comphelper::AccessibleEventNotifier::TClientId, std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::iterator&)\") at ./assert/assert.c:101\n"
            >~"#6  0x00007f0f28913886 in (anonymous namespace)::implLookupClient(comphelper::AccessibleEventNotifier::TClientId, std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::iterator&) (nClient=218, rPos=...) at .../comphelper/source/misc/accessibleeventnotifier.cxx:140\n"
        
            >~"#7  0x00007f0f28913b9a in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&) (_nClient=218, _rxEventSource=uno::Reference to (accessibility::AccessibleBrowseBoxHeaderCell *) 0x55fb25c8b3d0) at .../comphelper/source/misc/accessibleeventnotifier.cxx:185\n"
            >~"#8  0x00007f0eef073244 in accessibility::AccessibleBrowseBoxBase::disposing() (this=0x55fb25c8b3d0) at .../accessibility/source/extended/AccessibleBrowseBoxBase.cxx:113\n"
            >~"#9  0x00007f0f28474aeb in cppu::WeakComponentImplHelperBase::dispose() (this=0x55fb25c8b3d0) at .../cppuhelper/source/implbase.cxx:104\n"
            >~"#10 0x00007f0eef0712c2 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XFocusListener, com::sun::star::lang::XServiceInfo>::dispose() (this=0x55fb25c8b3d0) at .../include/cppuhelper/compbase.hxx:90\n"
            >~"#11 0x00007f0f28474834 in cppu::WeakComponentImplHelperBase::release() (this=0x55fb25c8b3d0) at .../cppuhelper/source/implbase.cxx:79\n"
            >~"#12 0x00007f0eef072124 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::awt::XFocusListener, com::sun::star::lang::XServiceInfo>::release() (this=0x55fb25c8b3d0) at .../include/cppuhelper/compbase.hxx:86\n"
            >~"#13 0x00007f0eef07544a in accessibility::BrowseBoxAccessibleElement::release() (this=0x55fb25c8b3d0) at .../accessibility/source/extended/AccessibleBrowseBoxBase.cxx:518\n"
            >~"#14 0x00007f0f15842747 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference() (this=0x7f0f0c0246e0, __in_chrg=<optimized out>) at .../include/com/sun/star/uno/Reference.hxx:114\n"
        
            >~"#15 0x00007f0f15862b9f in QtAccessibleWidget::~QtAccessibleWidget() (this=0x7f0f0c0246a0, __in_chrg=<optimized out>) at .../vcl/inc/qt6/../qt5/QtAccessibleWidget.hxx:39\n"
            >~"#16 0x00007f0f15862c76 in QtAccessibleWidget::~QtAccessibleWidget() (this=0x7f0f0c0246a0, __in_chrg=<optimized out>) at .../vcl/inc/qt6/../qt5/QtAccessibleWidget.hxx:39\n"
            >~"#17 0x00007f0f146ca101 in QAccessibleCache::deleteInterface(unsigned int, QObject*) (this=0x55fb1ef073e0, id=2147483876, obj=0x55fb25c8abf0) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:173\n"
            >~"#18 0x00007f0f146c9712 in QAccessibleCache::~QAccessibleCache() (this=0x55fb1ef073e0, __in_chrg=<optimized out>) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:31\n"
            >~"#19 0x00007f0f146c9798 in QAccessibleCache::~QAccessibleCache() (this=0x55fb1ef073e0, __in_chrg=<optimized out>) at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:32\n"
            >~"#20 0x00007f0f146c967e in cleanupAccessibleCache() () at /home/michi/development/git/qt5/qtbase/src/gui/accessible/qaccessiblecache.cpp:24\n"
            >~"#21 0x00007f0f14fa22f7 in qt_call_post_routines() () at /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp:325\n"
        
            >~"#22 0x00007f0f13599da0 in QApplication::~QApplication() (this=0x55fb1dfd77b0, __in_chrg=<optimized out>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:663\n"
            >~"#23 0x00007f0f1359a09e in QApplication::~QApplication() (this=0x55fb1dfd77b0, __in_chrg=<optimized out>) at /home/michi/development/git/qt5/qtbase/src/widgets/kernel/qapplication.cpp:717\n"
            >~"#24 0x00007f0f158ce2c4 in std::default_delete<QApplication>::operator()(QApplication*) const (this=0x55fb1e07b220, __ptr=0x55fb1dfd77b0) at /usr/include/c++/13/bits/unique_ptr.h:99\n"
            >~"#25 0x00007f0f158ce70c in std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication> >::reset(QApplication*) (this=0x55fb1e07b220, __p=0x0) at /usr/include/c++/13/bits/unique_ptr.h:211\n"
            >~"#26 0x00007f0f158cc643 in std::unique_ptr<QApplication, std::default_delete<QApplication> >::reset(QApplication*) (this=0x55fb1e07b220, __p=0x0) at /usr/include/c++/13/bits/unique_ptr.h:509\n"
        
            >~"#27 0x00007f0f158c506b in QtInstance::~QtInstance() (this=0x55fb1e07b090, __in_chrg=<optimized out>) at .../vcl/qt6/../qt5/QtInstance.cxx:273\n"
            >~"#28 0x00007f0f158c5142 in QtInstance::~QtInstance() (this=0x55fb1e07b090, __in_chrg=<optimized out>) at .../vcl/qt6/../qt5/QtInstance.cxx:274\n"
        
            >~"#29 0x00007f0f202615d9 in DestroySalInstance(SalInstance*) (pInst=0x55fb1e07b0a0) at .../vcl/source/app/salplug.cxx:389\n"
            >~"#30 0x00007f0f203401ee in DeInitVCL() () at .../vcl/source/app/svmain.cxx:600\n"
            >~"#31 0x00007f0f2033e9bf in ImplSVMain() () at .../vcl/source/app/svmain.cxx:229\n"
            >~"#32 0x00007f0f2033ea1b in SVMain() () at .../vcl/source/app/svmain.cxx:236\n"
            >~"#33 0x00007f0f2989f6ed in soffice_main() () at .../desktop/source/app/sofficemain.cxx:94\n"
            >~"#34 0x000055fb1c8769d4 in sal_main () at .../desktop/source/app/main.c:51\n"
            >~"#35 0x000055fb1c8769ba in main (argc=3, argv=0x7fffd6677498) at .../desktop/source/app/main.c:49\n"
        
        Change-Id: Ic5ba4f75cbeac3955417ca54c189b262289bfc79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-30  Miklos Vajna  <vmiklos@collabora.com>  [739597df38dcaab0460482e3bc3f18f2471d43ab]

        tdf#77760 sw floattable: add support for footnotes, UI
        
        Import filters could already create footnotes in floating tables, allow
        the same from the UI.
        
        Use IsFlySplitAllowed() as the check, because that already knows
        rejecting special anchor locations like footnotes/headers/footers in
        addition to actually decide if this is a split fly or not.
        
        Change-Id: Ib9bab7b29d1bea0c15f3d829d16c9edbf1455b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156275
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-30  Michael Meeks  <michael.meeks@collabora.com>  [1fbf566ad06cb41ae181b3848dfd2535e2dd87a2]

        lok: avoid forcing expensive re-layout of the calc input bar.
        
        This occured on doc_setView and was unreasonably expensive - loading and
        de-compressing new PNGs as multiple users typed, re-sizing and
        re-rendering a toolbar that is not visible -> do nothing here.
        
        cf. cool#6893.
        
        Change-Id: I1980a3a4516fb2aa629da85de9d4628f29de5af7
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156270

2023-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [c2b621b6d9f41d269b4d1aafc5e8911dde51d607]

        a11y: Drop AccessibleChildren typedef
        
        It's only used a single time anyway.
        
        Change-Id: Icef8bb635b9cf2cb2d244619fb9b63eb395213d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156258
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-30  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [252132d9752964a4aa82567b6a3ca8cd7df5ccfb]

        tdf#146619 Remove unused includes from sal/osl/unx
        
        Change-Id: Icc9cd3410cde2589ea51385c651243e11cc2f1d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155855
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-30  Miklos Vajna  <vmiklos@collabora.com>  [9e53afb9cad0e6ed66904ac38b61d1450e12f01d]

        svx: prefix members of SdrGluePoint
        
        See tdf#94879 for motivation.
        
        Change-Id: I1f1abdf5c522306a5d897250afdb99221e5609f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156274
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-30  Adam Seskunas  <adamseskunas@gmail.com>  [005f1547b8e5b37da243320b2eb7a84a47f4c821]

        tdf#143148 Use pragma once in uibase-app
        
        Change-Id: I95cf120f9aaf47bb4c588471a8cbdb4c0ceb6c99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156262
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-08-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [748d21a4675321f88bcd5fa4bec190ac32e87502]

        Fix typo
        
        Change-Id: Ibc68bc830aaf01d2ad3df8cf11bb150ef60eea6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156263
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ec6bc744020f22bea1a7db165b39287725db7637]

        Fix typo
        
        Change-Id: I33bf9779387529da4340af340744386f89320000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156264
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-30  Yli875  <qq3202390739@gmail.com>  [abbdb9cf2a40132f67cd6e0f2e9ad686ff36798b]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I84408aa0d48dd7804b70d012c85035e0572fa4e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156256
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-30  Jim Raykowski  <raykowj@gmail.com>  [33ae7c12bbdf19b76ced472ca8aed6cf66477bbe]

        tdf#156978 SwNavigator: fix gtk3 crash on treeview get_sensitive
        
        Change-Id: Ife866103b61940138cd044c666e0556760dcefa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156272
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-29  Andras Timar  <andras.timar@collabora.com>  [642f2d7177ea3e6c365da2c2082a50a5137cd988]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 14689ec8caaecc2e58281e1876beb2800285be14
          - Updated Slovak dictionaries (v2.4.7 2023-08-29)
            
            Change-Id: Id35b971fdb7a0391cc75623b176d8bb47fd6d3d4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156265
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2023-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [73af6241e9448af2dcbd0352e472e4d3153d0e1b]

        Revert "remove warning about qt and icccm"
        
        This reverts commit 1ccd236d8dc833ab9de639cf903684d1ecebf5e1.
        
        As pointed as by mikekaganski, "Isn't 5.6 older than 5.12?", so I cannot remove this yet
        
        Change-Id: I33d5cf62063fa7cc05c5317b49665844760b7101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd1f63a6ed8b6edae098b987861f83c30f484759]

        simplify error handling path in OutputDevice::BlendBitmap
        
        Change-Id: I1c8f8ba7d24e5d85057790249901adc69f295af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156246
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-29  Bayram Çiçek  <bayram.cicek@libreoffice.org>  [a4633dadb4233ad5587bd238449671d610540c81]

        tdf#49895: Add search functionality to Options dialog
        
        - Search field added.
        - Dialog names of all treeview nodes with their parent names
          were included in searching.
        - Strings of labels, check buttons, radio buttons,
          toggle buttons, link buttons and buttons were
          included in searching.
        
        Change-Id: Idf67c160519402ee390d94b1b3135b56324f3990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152519
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-08-29  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [62e201d2cf82f4ccaa6564bd2420ac6582594b8f]

        tdf#155495 sc: fix cursor positioning editing centered/right-aligned cells
        
        It was not always possible to place the cursor in edited text
        by mouse clicking in case of centered and right-aligned cell
        content, i.e. when the edited content has been shown before
        the original (not edited) cell position.
        
        Now it's possible to place the cursor by mouse clicking before
        the left border of the not edited cell (instead of selecting other
        cells covered by the edited content).
        
        Change-Id: I23c59ca3ef67d223181a7e3dfd71b84f43fca32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155579
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-29  Szymon Kłos  <szymon.klos@collabora.com>  [62d5a5c376f06a22fdfd8708d2aefd7e987a4478]

        jsdialog: don't send update if we not change selection
        
        Change-Id: I3eb1e5df4133f010d0c4f7abde0f73bfeda75a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156046
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156237
        Tested-by: Jenkins

2023-08-29  Szymon Kłos  <szymon.klos@collabora.com>  [f232b5945151e911db1e37c64e38ca1ed2c95854]

        jsdialog: make font previews background transparent
        
        Change-Id: I9dc75ab91f591191be7a354274a0783b0fd093b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156029
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156244
        Tested-by: Jenkins

2023-08-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7ceecfbf209d99d9e1cd2fd97175a5ee7b081808]

        Fix typo
        
        Change-Id: If4a80e7a3427e88f29e6ee36d05ec96ae820b60e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156249
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6717532b37a5895206820e6429048ae2df3626f9]

        Fix typo
        
        Change-Id: I2a3c65f012558aa388d02f88f9a359d6433a91f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156248
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [988851cb5cc8d435581f8018f664f31da67d5785]

        Fix typo
        
        Change-Id: I76773e5273579536aef330d5eb83887bba7e7be8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156247
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2123f9441859b700d17378965870d1baabbac32]

        remove dead code
        
        in OutputDevice::BlendBitmap. This case will always be handled by the
        block inside
            if( GetBitCount() <= 8 )
        just above.
        
        Has been this since initial import in
        
            commit 5120979b55c888d5090e91792616c57287929d85
            Author: Kurt Zenker <kz@openoffice.org>
            Date:   Mon Nov 6 13:49:09 2006 +0000
            INTEGRATION: CWS vcl67 (1.31.16); FILE MERGED
        2006/10/20 14:38:03 thb 1.31.16.3: #i70653# Handling the
        both-alphas-zero case properly now
            2006/09/22 11:51:51 thb 1.31.16.2: #i10000# Fixed a warning
        2006/09/22 11:42:05 thb 1.31.16.1: #i47518# Properly blending alpha
        bitmap into alpha vdev now.
        
        Change-Id: I1779b17d85685f4b3ecdbda4920b4417ad29452b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-29  Michael Stahl  <michael.stahl@allotropia.de>  [74b3a0fe9840c6076fd805db7cf8a66f056c5832]

        vcl,sw: PDF export: move SwEnhancedPDFExportHelper statics to member
        
        New struct SwEnhancedPDFState to contain the state; it is transported
        from SwEnhancedPDFExportHelper instance to SwTaggedPDFHelper instances
        via vcl::PDFExtOutDevData.
        
        Change-Id: I0c0f10587ce8bc6f5f1125da4761b7504ad2b970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156241
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-29  Szymon Kłos  <szymon.klos@collabora.com>  [af0f610f90b315c20773c39579b70fb6e456412b]

        jsdialog: rendering of custom entries in combobox
        
        Change-Id: I22cca2e89c38d927a21a39886b795f42c1546afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155854
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156243
        Tested-by: Jenkins

2023-08-29  Szymon Kłos  <szymon.klos@collabora.com>  [59dd6ae2c887ef89afd89c9c64eb8c208846c3c3]

        jsdialog: inform that combobox has custom entries
        
        Change-Id: I6241961db2e0fa676289ce50873a2aae7ec18282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155937
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156236
        Tested-by: Jenkins

2023-08-29  Szymon Kłos  <szymon.klos@collabora.com>  [beeeb3b8d5dcdee45d3fb2cb97f3def789db0f6a]

        jsdialog: detect special window id earlier
        
        Change-Id: Ib90d9d728d93a26d44a7f52b7ca0074338b1fae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155853
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156235
        Tested-by: Jenkins

2023-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7cdefb880ed6fd413b9e31fa45352cdeb074a24f]

        supplement setting SYMBOL encoded charset with SymbolFont flag
        
        as well as using the well-known symbol font names
        
        Change-Id: I2d0eb28ca89a74ae467f29a1173807b3b83bf4a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156234
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-29  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [5eea6974d937148a9a1f3d078c2174fe8d420d31]

        tdf#103706: tdf#142857: sd: context aware paste for clone format
        
        Introduces selection aware pasting for Impress/Draw's Clone
        Format where paragraph properties are applied when the selection
        contains a whole paragraph or there's no selection at all (i.e.
        clone format applied with just a left click - without drag).
        
        Change-Id: I37e7197580c2b8da333ada1a60408f40f85d7ef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155108
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-08-29  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [7b5327ffcb18a4b4f456afecea313039dd79449a]

        tdf#103706: tdf#142857: sw: context aware paste for clone format
        
        Introduces selection aware pasting for Writer's Clone Format
        where paragraph properties are applied when the selection
        contains a whole paragraph or there's no selection at all (i.e.
        clone format applied with just a left click - without drag).
        
        Change-Id: I9f3eedb4544bf53dabed4bb659ce2e44313a692a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155107
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-08-29  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [e9bb17369dc6fd3064fce55a1afacaacea4faae2]

        related tdf#103706: sw: correct format paintbrush attribute reset
        
        Reset all direct formatting before applying **any** attributes.
        
        For instance, before this patch paragraph font colors were lost
        on apply.
        
        Change-Id: I62d202713e60e7e3690c67d63989179c3d5dc900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155106
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-08-29  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [36aa809fbd3c44da1ed266104f175e8c872d38b3]

        tdf#103706: sw: Revert "Format paintbrush default behaviour"
        
        This reverts commit 1574c76ec20d1da479ed7e9c85a6cefacc132dfe.
        
        Reason for revert: The default behavior should copy *all* formatting.
        
        Change-Id: If3ae81d412374433f2d95a04345c651a788de4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155103
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-08-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7f1c2b6ccf318d3b6bbf46f6559b2a3017a72821]

        pptx using Wingdings didn't fallback to OpenSymbol
        
        <a:sym typeface="Wingdings" pitchFamily="2" charset="2"/>
                                                             ^
        
        The charset indicating that it was symbol encoded wasn't
        applied.
        
        There are quite a few uses of GetFontData so make this
        an optional request and only apply it right now to the
        problematic case.
        
        Change-Id: Ie1c4b9ac38c2bf5f0867d64eddea853a6dd05aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156230
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-28  Paris Oplopoios  <paris.oplopoios@collabora.com>  [16d43b7c5396d6382926d514dc9ce10b3ce94cba]

        Shared string shouldn't account preserve space property
        
        XLSX documents opened in Excel don't seem to account for the
        xml:space="preserve" value for whether the string is single line or not
        
        The test that was changed seems to have more accurate behavior now,
        where the second cell does not have multiple lines (like in Excel)
        
        Change-Id: Iad8f351c19102249e2cb1e1d063c8690dfb3d753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156206
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-08-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fcb42f363bd1212bebb880d265c95d28deac84f3]

        Update git submodules
        
        * Update translations from branch 'master'
          to dc344b7d1c77b98b5928e94f2f107b8c3764fee2
          - update translations for master/7.6
            
            and force-fix errors using pocheck
            
            Change-Id: I74e16ad11eef735a123cc21a516dc6d6d31bc6a7
            
2023-08-28  Stephan Bergmann  <sbergman@redhat.com>  [e235e4bb7ce79d6738e1e6267c965f71960466a6]

        Adapt loplugin:unnecessaryparen to user-defined string literals
        
        Change-Id: Ieab59fa456bce13145b61cb5e8b2fb9ff9b4c573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156193
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9dfa816f7002c686ad155682a21a06ec6041b5f]

        tdf#156808 soft edge effect makes image (except for soft edge) disappear
        
        This is clearly fallout from
             commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
             Date:   Fri Apr 16 20:33:10 2021 +0200
             Convert internal vcl bitmap formats transparency->alpha (II)
        And it clearly fixes the problem, but I'm not sure __why__ it fixes the
        problem.
        
        Change-Id: I805ed85dd22b2124328e6b4dba098c5f093aec55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156198
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b7d5b8cee77e4cfd931cdbd6f4ba8673c6bbe490]

        Related: tdf#156611 move long explanation string into tooltip
        
        Change-Id: Iddd600855f97bc505f30d06ae364c0ae2a935a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156186
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-28  Julien Nabet  <serval2412@yahoo.fr>  [1eb683b6aff38d9b8226268f428600fa0d3ed58f]

        incorrect usage of erase..remove idiom
        
        since commit 66a33ea9ef0ede9c90714455e6ad46197425f075
        Replace list by vector in Metadatable (sfx2)
        Change-Id: I707dd27be91711e4f80d39c620a3b9784b5ef122
        Reviewed-on: https://gerrit.libreoffice.org/43376
        Tested-by: Jenkins <ci@libreoffice.org>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        
        Change-Id: I9be82687cc9d7302e5d0ebc7bb52bac74540ce50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156199
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-28  Stephan Bergmann  <sbergman@redhat.com>  [78a3448f056fd4863c12fdba5d911e05a1540568]

        Fix CppunitTest_sw_apitests
        
        For one, a dependency was missing to avoid
        
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetByName
        > standard
        > test/source/container/xnameaccess.cxx:30:(anonymous namespace)::SwXAutoTextContainer::testGetByName
        > unexpected exception caught
        > - Caught: unknown.
        >
        > (anonymous namespace)::SwXAutoTextContainer::testGetByName finished in: 147ms
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetElementNames
        > standard
        > (anonymous namespace)::SwXAutoTextContainer::testGetElementNames finished in: 0ms
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testHasByName
        > standard
        > test/source/container/xnameaccess.cxx:48:(anonymous namespace)::SwXAutoTextContainer::testHasByName
        > assertion failed
        > - Expression: xNA->hasByName(m_aName)
        >
        > (anonymous namespace)::SwXAutoTextContainer::testHasByName finished in: 0ms
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetCount
        > standard
        > test/source/container/xindexaccess.cxx:26:(anonymous namespace)::SwXAutoTextContainer::testGetCount
        > equality assertion failed
        > - Expected: 3
        > - Actual  : 1
        >
        > (anonymous namespace)::SwXAutoTextContainer::testGetCount finished in: 0ms
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetByIndex
        > standard
        > test/source/container/xindexaccess.cxx:32:(anonymous namespace)::SwXAutoTextContainer::testGetByIndex
        > equality assertion failed
        > - Expected: 3
        > - Actual  : 1
        >
        > (anonymous namespace)::SwXAutoTextContainer::testGetByIndex finished in: 0ms
        
        And for another, executing the XAutoTextContainer test code in
        SwXAutoTextContainer corrupted instdir/,  testInsertNewByName creating a
        spurious instdir/share/autotext/en-US/crdbus50Insert.bau, and testRemoveByName
        removing instdir/share/autotext/en-US/crdbus50.bau, which caused subsequent runs
        of the CppunitTest to fail with
        
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetCount
        > standard
        > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/test/source/container/xindexaccess.cxx:26:(anonymous namespace)::SwXAutoTextContainer::testGetCount
        > equality assertion failed
        > - Expected: 3
        > - Actual  : 4
        >
        > (anonymous namespace)::SwXAutoTextContainer::testGetCount finished in: 0ms
        > [_RUN_____] (anonymous namespace)::SwXAutoTextContainer::testGetByIndex
        > standard
        > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/test/source/container/xindexaccess.cxx:32:(anonymous namespace)::SwXAutoTextContainer::testGetByIndex
        > equality assertion failed
        > - Expected: 3
        > - Actual  : 4
        >
        > (anonymous namespace)::SwXAutoTextContainer::testGetByIndex finished in: 0ms
        
        (<https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/44666/>).  So this
        commit reverts that part of 7b999ca22824e102d283a8b7327fa2717db6568a "tdf#45904:
        Move _XAutoTextContainer Java tests to C++" for now.
        
        Change-Id: I46387d3fea21706846f2c1ba4c462402f9343fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156192
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-28  Tobias Kokolakis  <kokolakis@mail.de>  [0e51bb2c6b29928403dde5b3af88eb6cf3878f36]

        tdf#143148: Replace include guards with pragma once
        
        Change-Id: I24e4526c66488067f1e82320f3c921177bf668d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156177
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-08-28  Stephan Bergmann  <sbergman@redhat.com>  [a89f2e01b7371fec278f9a42d7c186a3149ff3c4]

        Missing test dependency
        
        > [_RUN_____] (anonymous namespace)::SwXBodyText::testCreateTextCursor
        > warn:vcl.builder:2348481:2348481:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/scrollbars.ui at xmlreader/source/xmlreader.cxx:67"
        
        Change-Id: I51dedf7114091b53ac6883d41e44cb9e5703f657
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156191
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ccd236d8dc833ab9de639cf903684d1ecebf5e1]

        remove warning about qt and icccm
        
        since the minimum qt5 version we requre is qt5.6
        
        Change-Id: If60d20c5220c02c614788a0c49f943d4708df142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Stephan Bergmann  <sbergman@redhat.com>  [43939d0b3286266217a2625d5a7a3de1a2cdd303]

        Do a real compile after a successful COMPILER_PLUGIN_TOOL=... compile
        
        ...so that object files are generated after all, even though the
        COMPILER_PLUGIN_TOOL=... compile itself doesn't generate them.
        
        (This required the existing gb_COMPILER_PLUGIN variable to be disambiguated, by
        splitting off a new gb_COMPILER_PLUGINS_TOOL variable.)
        
        Change-Id: I652c98c9ef2a6120a6e3f809af5ab2ccf09dabc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [1197d2c3ed1d2bddea6b114f41184b364c4e9cb5]

        disable more unreliable track changes UI test
        
        Change-Id: Ief5e140684a81c9bc4b4d26eb19eb6be2e6b8516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c0f772aedf505460812b76403583bcde6b9a903]

        fix duplicate I introduced to tsan-suppress
        
        Change-Id: I24f6c9667bbe66c510fbed7a0dd60e9490cb93b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156187
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [802377d604025fb48da4b5efec76bb85ffbd2092]

        Fix typo
        
        Change-Id: Idd6b551bdfbbb613703dd948298deed0462097af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156195
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-28  Michael Stahl  <michael.stahl@allotropia.de>  [8c24bc5baa1f501943bf955e07787d80cb7a5763]

        (related? tdf#155177) sw: layout: fix another RemoveFollowFlowLine SNAFU
        
        This happens with the following commit, on testForcepoint76, for no
        obvious reason.
        
        A follow table frame is in SwTabFrame::MakeAll(), then its follow flow
        line becomes empty and it does SetRemoveFollowFlowLinePending() on the
        master, then it formats its follow flow line (but at that time there's
        again a text frame in it), then that content moves backward, formats its
        uppers until it gets to the master table frame, which wants to join the
        row frame that's being formatted on the stack.
        
        Obviously a SwFrameDeleteGuard in lcl_RecalcRow() can't hurt, but it
        needs an additional change later to prevent it from moving rows of the
        follow back.
        
        Change-Id: Idca90b7eb67994385ccd306562ea26ff39e884f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156117
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-28  Michael Stahl  <michael.stahl@allotropia.de>  [c1586ef57b5770f80ef200ab38ff4538c2dfb145]

        python3: upgrade to release 3.8.18
        
        Fixes CVE-2023-40217
        
        Change-Id: Ie08af471009b7f5c42aa6875dd4f9d886ad1d617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156183
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-28  Michael Stahl  <michael.stahl@allotropia.de>  [fe89122c15744afcaccaa6d6628fa0436adf12e1]

        tdf#155177 sw: fix 2-line bug in WidowsAndOrphans::WouldFit()
        
        The problem is that the check if the line contains a non-fly portion
        was only done in the loop, but the first line is already handled before
        the loop, so its non-fly portions are ignored and never less than 2
        lines are moved, regardless of widow/orphan settings.
        
        (regression from commit 8c32cc17ce914188ea6783b0f79e19c5ddbf0b8d)
        
        Change-Id: Ic017a17233fcd58e22d54386650328f00fb3e9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156121
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [825e925ee8fb9495a76cba0407f34418f7bddda0]

        assert seen on closing navigator while dragging
        
        seen when dragging from floating navigator and pressing alt+f4 while
        continuing to drag
        
        Change-Id: Idb563c4ec4d8ab74b794e06194ef748e6346eb1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [77e13931fd2221daa56a101ef57d8a129d05c05b]

        incorrect usage of erase..remove idion
        
        since
            commit c95221f151fbaab5f181bb5f8a5428a380d4d1bf
            Author: Julien Nabet <serval2412@yahoo.fr>
            Date:   Mon Oct 9 21:19:43 2017 +0200
            Replace list by vector InputStreamsList_Impl (package)
        
        Change-Id: Icd35f74863e68315c7fa580a1009743cc957192a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [df3b95a39472e18ea8acdaae447b7176e37a9256]

        Related: tdf#144906 unset g_DragSource if drag end callback never called
        
        a scenario I can reproduce with alt+f4 while dragging from the
        navigator
        
        Change-Id: I7123602e036fbe15e0ae8f9a7e1d5fc7483dc6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156182
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-28  Paris Oplopoios  <paris.oplopoios@collabora.com>  [1760ee4d328cfb6ba22a5b3c84016625b12adb25]

        sc: Fix wrapText not being applied correctly on export
        
        Change-Id: I03aaa36af8fe820fa07d2eea13c5b0f69ad74dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155970
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-08-28  Szymon Kłos  <szymon.klos@collabora.com>  [407297d9c592479d9fc90033876cad96206f9259]

        jsdialog: dump vertical tab control
        
        Change-Id: I673199dfd7e95bfdb748791db094e7a1c3e74dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155759
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156158
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [68e797402692c5c8abf1b2c4374e12a8d2707d07]

        new loplugin:optionalbool
        
        which warns against using the 'operator bool' conversion of
        std::optional<bool> which can lead to interesting bugs
        
        The bugs that this plugin have been submitted independantly,
        so this change is just using has_value() in relevant places.
        
        Change-Id: I259b837feeecddcb8cd1d7e5db1e85bf505907cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-28  Szymon Kłos  <szymon.klos@collabora.com>  [5733cdba90b099637805648b193510268def74be]

        Theme dialog: fix crash when closing parent first
        
        When we have 'Add' subdialog opened and we close parent
        by clicking 'cancel' - subdialog wasn't closed and we had
        a crash on next interaction with 'Add' subdialog
        
        Change-Id: I5865a725e93d7c11aa933b7566a7c584018740ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155715
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156157
        Tested-by: Jenkins

2023-08-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d3b06d044fafec0b31ada9ecbaf60f396555fb12]

        sd: add undo/redo action for changing the model::ColorSet
        
        And add the undo action when changing the theme colors in the
        ThemeColorChanger.
        
        Change-Id: Ibeee8aeff420b42fd961e0abd630569e74075585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156178
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-27  Patrick Luby  <plubius@neooffice.org>  [e7496f41562b75ea9732ca48f9aa0c07b69e424f]

        tdf#150610 fix broken rendering of text meta actions
        
        Even when drawing to a VirtualDevice where antialiasing
        is disabled, text will still be drawn with some
        antialiased pixels on HiDPI displays. So, expand the
        size of the VirtualDevice slightly to capture any of
        the pixles drawn past the edges of the destination
        bounds.
        
        Change-Id: Ibcba8234708d8784c12f984289ec0a8fcad6694e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156098
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-27  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [aa3eea21fcf302ef4ddbba5841037378945f9d5e]

        svx : replace local function with OUStringLiteral
        
        Change-Id: Ica39cd5b6da3c97dd03aa9844e2dd8d99c279697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-27  Szymon Kłos  <szymon.klos@collabora.com>  [34d5abf464dfbf4bdc36f6b87e606c84a1f4d99d]

        lok: notify only affected tabs on cell resize
        
        When row has automatic height and we type something into
        one cell - it may be resized. That caused sending
        document size changed callback to all the views, also
        affecting all the parts/tabs.
        
        This patch calls that only for affected views which
        are looking at modified parts. It will not invalidate
        all the tabs when only one is modified.
        
        Change-Id: I93e574cf967d608696c1a95ad8b5a7614973c3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154891
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156156
        Tested-by: Jenkins

2023-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3f2484d071edb415216f5a2d09d146005cdd063e]

        Fix typo
        
        Change-Id: Iadaed462970f7bc70769664920524ac2c193433a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156152
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6d58d3aa8620a23abd0dfdc3cda86aa51bc88268]

        Fix typo
        
        Change-Id: I618431147060b4bec7d1957b949dc270eeaafdd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156153
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e0142562a1dafb7d1d1b60684934525dbbeb76c0]

        Fix typo
        
        Change-Id: I9880e5a7957bf2124f1ce8d9fc0cd3e44e129e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156154
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f0da3af62d39d31024133784c736b58cd35e3e23]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d122af7bbaa552c59a060682331149d102533561
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(23)
            
            + refactoring
            + Writer Format menu (part 23)
            + Grouping of objects
            
            Change-Id: I61f6cc5ed587da17db63c3ecb9dd734e3135bf34
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156169
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e2f1eaa8d86596cda116197e5092e071f05130ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c2ad05f8621f3af05ea573a529e00e417f6f9d3
          - Indexing of flip UNO commands
            
            Change-Id: I282d7e926eb4114d3ef35274492f2573a27f570f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156168
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f34750b6a6c0c120aa9f2c66c4243779553c5d02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c82e14e8313305ba4fee0cc8662462005cac535d
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(21)
            
            + refactoring
            + Writer Format menu (part 21)
            + rotate or flip submenu
            
            Change-Id: I346f7361eec94a89467d572c898697591b1061fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156155
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [38b1ee4268679af8cd3e6b8d9dcf26677076656f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e1b40215eecbaa0de54536778d012c6f4f974c7d
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(20)
            
            + refactoring
            + Writer Format menu (part 20)
            + Arrange menu covering other modules too.
            
            Change-Id: Ib875d27d83ac36a23c6f2e72ce44b22c9e82d2bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156125
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8cd30c86eec55d93dbd6c5fcf96cbbafc502de7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bc1437b6ac1d9a51eea44fd3b7fe2f290e58cbba
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(19)
            
            + refactoring
            + Writer Format menu (part 19)
            + Wrap text
            
            Change-Id: Idd607e5a4a5443530188e0064e1b564e08375554
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156112
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d150b7a60d7be4b09a838ae4c038e78509f75126]

        Change theme location to SdrModel and SdrPage (master page only)
        
        In Writer and Calc we only have one theme per document, so the
        theme can be stored inside the SdrModel. For Imporess/Draw the
        theme is defined per master page, so it needs to be stored on the
        master page. This changes the implementation to reflect that.
        
        In addition refactor all the usages in writer and calc to get and
        set the theme to SdrModel, when needed and rename the methods on
        the SdrPageProperties from {Get,Set}Theme to {get,set}Theme.
        
        Change-Id: I0cc3b332c029c28d15f8cda748c578c2a54a5c61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156128
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-27  anfanite396  <dipamt1729@gmail.com>  [8496f805da8ea9f2585b7485b448dda52557db9a]

        tdf#45904: Move _Footnote Java tests to C++
        
        Change-Id: I1e69267a72296f55fac12326ec69d3c29e63561a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156055
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-27  Paris Oplopoios  <paris.oplopoios@collabora.com>  [01230c5c499d3f9c010b88e0b5ee9649cbe80190]

        Add APNG export option in File -> Export
        
        A separate filter was made to allow for the option of exporting a still
        image instead if the user wants to
        
        Change-Id: I8140c834990e592ee579425d6cd18ae764128576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155878
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-27  anfanite396  <dipamt1729@gmail.com>  [9a4f776e5ad7e0b47a884765a11c72a8f7ada6dc]

        tdf#45904: Remove old SwXReferenceMarks Java test
        
        Change-Id: I8830e54fdba98d3cfd1e2844e7faf02e55e7d0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156044
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-27  László Németh  <nemeth@numbertext.org>  [e16e84c44fc7517529c8a183fbd8f97c0c3e380e]

        tdf#156784 sw tracked table column: fix crash at Select All
        
        Section starting table with hidden deleted first column
        freezed at Select All, resulting crash because of infinite
        recursion during waiting frame creation of a hidden cell
        without frame in Hide Changes mode.
        
        Regression from commit d1004cdd6a445ae73673b0ca360ae034b0ec09f2
        "tdf#150673 sw offapi: add change tracking of table column deletion".
        
        Change-Id: I15d9fa0138261d7a95c6e34a8d07fb2e001d0c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156056
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f4ed90bcad83ea24644c1cbf077b369ae05f004e]

        sd: remove theme tab page
        
        Change-Id: Iffb3d0f6d6933891333da68fa4569a3638ba18f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156123
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a535bacb2adeb491e919992a38e891945ca248f0]

        sd: disable ThemeDialog when not in a master page
        
        Change-Id: Ic6ea74c877415f337d81d92bdef869c5fb61d239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156122
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6471181b66ebe634e9ffbdc2b55dbf1da17a3acf]

        svx: remove theme related parameters for Color and FillColor
        
        For SvxColorItem, XFillColorItem, XLineColorItem,... we set the
        ComplexColor via the JSON additional UNO Command argument, so we
        don't need the parameters to set the theme color and LumOff and
        LumMod color modifiers for the UNO Command. Actually this has
        broken the setting the colors in certain situations, so we must
        remove this.
        
        Change-Id: Ic28aa1e43559d3627703d93c7c1bd9310a149986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155864
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [146f0e4ce15b48c6914fa310e805ef45a50ab6eb]

        reportdesign: fix crash in ORptExport::exportSectionAutoStyle
        
        See https://crashreport.libreoffice.org/stats/signature/rptxml::ORptExport::exportSectionAutoStyle(com::sun::star::uno::Reference%3Ccom::sun::star::report::XSection%3E%20const%20&)
        
        Change-Id: Ibe5a6de1888728fba22f8cc0d128dcb04da9ede9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156096
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins

2023-08-26  anfanite396  <dipamt1729@gmail.com>  [0ab3f09011e4c4c1b85dda72f81f252899162ab5]

        tdf#45904: Move _XFootnote Java tests to C++
        
        Change-Id: Ibdc28ab8818860b9c94abeac33713607dbcf8df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155635
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  Michael Weghorn  <m.weghorn@posteo.de>  [3ebd1371cbcfc03ca525146c680f076066ceb361]

        gtk3 a11y: Force running a11y tests with X11 GDK backend
        
        On Debian testing, tunning the gtk3 a11y tests with
        
            make CppunitTest_vcl_gtk3_a11y
        
        in a Wayland session resulted in a visible
        Writer window popping up (while that should not be
        the case and isn't when run in an X11 session instead,
        as the application is meant to run in a virtual
        X server environment via xvfb-run)
        and a test failed like this:
        
            .../vcl/qa/cppunit/a11y/atspi2/atspi2.cxx:432:Test1::TestBody
            equality assertion failed
            - Expected: ATSPI_ROLE_PANEL
            - Actual  : ATSPI_ROLE_FILLER
        
            warn:sw.core:15950:15950:sw/source/core/attr/calbck.cxx:196: a 16SwTextFormatColl client added as listener to a 16SwTextFormatColl during client iteration.
            warn:sw.core:15950:15950:sw/source/core/attr/calbck.cxx:196: a 16SwLineNumberInfo client added as listener to a 12SwCharFormat during client iteration.
            Test1::TestBody finished in: 56011ms
            atspi2.cxx:432:Assertion
            Test name: Test1::TestBody
            equality assertion failed
            - Expected: ATSPI_ROLE_PANEL
            - Actual  : ATSPI_ROLE_FILLER
        
            Failures !!!
            Run: 1   Failure total: 1   Failures: 1   Errors: 0
        
        Force use of the X11 GDK backend by setting env
        var `GDK_BACKEND=x11`, which makes that scenario
        work as expected.
        
        Change-Id: I7de03593998ffa3bc18d487cb92e00ae75427598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156086
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-26  anfanite396  <dipamt1729@gmail.com>  [d1fef008f10da02700fe9d46bc86c3a50cae7a21]

        tdf#45904: Move _DocumentIndexMark Java tests to C++
        
        Change-Id: I144d06ab3abb47134060d554a4016009246aa739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155163
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  anfanite396  <dipamt1729@gmail.com>  [38170c21461a5933fe6b2341532ef6527b5a65b6]

        tdf#45904: Remove old SwXAutoTextContainer Java test
        
        Change-Id: Idcb3c17e328894bbd64939f2e3ad076204b35bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156113
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0f1eeebfcb6177073ce15ec4a357ab80d6955870]

        Remove duplicated include
        
        Change-Id: Ife90baef2ceff442f51c03805eda945b2b2baf34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156118
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8e35551f8e860bdfbf869b983909e483ac296d1]

        Fix typo
        
        Change-Id: Ie3c298535db35219e46b1d6229d2079230b6b4c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156120
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bc7464f3871d3e521cdefe7c565097958fa8a317]

        Fix typo
        
        Change-Id: I53aed5857863162d1c6bbfa5ee5bf63be3d7de58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156119
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [8bb505d3e16deed2c7bb5636cfd765013ec23965]

        editeng: fix crash in EditDoc::FindAttribs
        
        check pNode before calling EditDoc::FindAttribs.
        This is the only place where EditDoc::FindAttribs is called from
        
        See https://crashreport.libreoffice.org/stats/signature/EditDoc::FindAttribs(ContentNode%20*,long,long,SfxItemSet%20&)
        
        Change-Id: I3ed0724b1113965c09c66413987bb85777ec9a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [61a308be8d7e2a578054c3d6d540873eecc88145]

        tsan: use std::atomic<bool> for mbAppQuit
        
        which is (IMO) the same as using volatile, but seems to make tsan
        happier
        
        Change-Id: I52024716ea75d7113357a169e225eee85cf22229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-26  Jim Raykowski  <raykowj@gmail.com>  [f24f352da00b3e9a57e723c83008fc5854c38227]

        tdf#156282 Make 'Fold/Unfold Including Sub Levels' menu items
        
        show for outline folding 'Include sub levels' mode
        
        In addition, when sub outlines are not visible in the document view,
        grey them out in the Navigator content tree instead of not including
        them.
        
        Change-Id: Icbdd254734df6c2fa95a7477a704e313b73d1cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155881
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [bce1f0b3d103fb435d4fa468c91efec8bf9a5b2d]

        vcl does not actually use mdds
        
        This was added in a copy-paste accident
        
        Change-Id: Ifdc9dde30a2d933d4f709f1344d402f9585bbf9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155931
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-26  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [16cd8cf06f23696fc057dd3469f7698154825886]

        Drop glm dependency from vcl
        
        Serious use of glm was removed from vcl in
        commit db89f53c31af997b9bf422b0e784afba8d62a42e
        remove OpenGL VCL backend code
        
        This is a bit of leftover from that
        
        Change-Id: I019279cd0cc804d3fa4535a651704bccca38b9db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155909
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-26  TokieSan  <eltokhy@aucegypt.edu>  [a6636c451b54728741be0a770b053e093134b90d]

        XMLSecurity Module Documentation Update
        
        Updated the README Documentation file for xmlsecurity module. Fixed
        broken sxd file for signatures workflow. Added dumb certificates creator
        shell script for testing purposes in qa.
        
        Change-Id: Ibee17193a1a38348f2e7fc460dfdd0c54dd31f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155932
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-26  TokieSan  <eltokhy@aucegypt.edu>  [fb9874231fb242b4a6a7d1ce097e66dd4ed8f32e]

        Caching Certificates in the CertificateChooser dialog session-wise
        
        Added the functionality of caching certificates per session using a
        single instance with internal memoization. Added Reload Certificates
        button in case of certificate changes in-session. Updated all instances
        of certifcate chooser in the codebase to work with the new change.
        
        Change-Id: Icb25a2b2e9787b029fa6189f70bd4ba3b6806f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155373
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6e042b1e26bedcc8d8bdcf105ec750b03665c7b0]

        tdf#150316 Fix missing first line indent in pptx export
        
        Change-Id: Ib2cac800b151823b77e44831100c2de9bbda8a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156107
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3f7e9b2ea67a8de9ad9dd819ec2eb91e8180af95]

        cui: use common menthod to get the complex color from a NamedColor
        
        NamedColor implements a getComplexColor method, which creates the
        ComplexColor from the NamedColor attributes. We don't need to do
        this ourselves.
        
        Change-Id: If2629d49b7b2e561b85b93314f56a95492cafd93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155863
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [32400a791522d90c3b9b731b73c751b7967f660c]

        svx: refactor text color theme changing and add undo support
        
        This refactors text theme color changing to use editeng directly
        and also makes it possible to add undo support.
        Some refactoring changes were also needed in Writer and Calc
        ThemeColorChanger implementations.
        
        Change-Id: I5cc21205aa3866f65f5b2132ecaa760292401263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155819
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [b44581d9cbb103390f99f73167ec37960895f95f]

        update tsan suppress
        
        with some more false+
        
        Change-Id: I493a1b19286d1775d0a9c84e0fb2616fe2be858a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-25  Laurent Balland  <laurent.balland@mailo.fr>  [74d9da037cac01c5abd768a99b2f948553fbf144]

        tdf#152724 Extend ODF for blank width "_x"
        
        Number format code "_x" is currently saved as a text string containing a
        number of spaces corresponding to the width of character "x". It may be
        confusing for user if its format code is modified.
        This change introduces a new XML tag XML_BLANK_WIDTH_CHAR to replace the
        previous text string if ODF version is extended
        
        <number:text> and <number:embedded-text>:
        the attribute is composed of a string containing the used character and its
        position in the text string (if position is 0, it is omitted).
        Several blank code characters are separated by '_'.
        Replacement blanks in the text string are preserved to enable compatibility.
        
        Example: format code
        "foo"_M_I_N"!"???,???.000_.000"!"_)
        is saved as:
          <number:number-style style:name="N173">
           <number:text loext:blank-width-char="M3_I6_N7">foo       !</number:text>
           <number:number number:decimal-places="6" number:min-decimal-places="6" number:min-integer-digits="6" loext:max-blank-integer-digits="6" number:grouping="true">
            <number:embedded-text number:position="-4" loext:blank-width-char="."> </number:embedded-text>
           </number:number>
           <number:text loext:blank-width-char=")1">! </number:text>
          </number:number-style>
        
        Add QA test
        
        Change-Id: I785e1a14ecccc900e9fd5af88dd7b743fefcc48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146582
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-08-25  Miklos Vajna  <vmiklos@collabora.com>  [c7b59c9484ae6ff88cd8d7017aeb83b02e212c9c]

        tdf#77760 sw floattable: add support for footnotes, DOC import
        
        This is similar to commit 178421a6c719dac9c16f220b76292fec16a53f60
        (tdf#77760 sw floattable: add support for footnotes, DOCX import,
        2023-08-24), the problematic part was to reject everything that is not
        in the body text, relax that to allow insertion into split flys.
        
        Do an early check to see if we'll insert into the fly/header/footer
        section, because otherwise it would be pointless to call
        SwNode::GetFlyFormat(), which can be expensive in case we don't have a
        layout yet.
        
        The DOC export, the RTF import and the RTF export was working already,
        so filters are mostly covered with this.
        
        Change-Id: I59c69fac0692c6656c054e32503ec0cbc2fd11e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156083
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [772d9abb6006bb03b8bd783bbe95a54360ebc3a9]

        downgrade from assert to SAL_WARN
        
        Change-Id: I78130d438fb9da60e929d7b6bad99bb6ec3d3e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156095
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [64474237cde14f9fde9e9bda3c635954c69cc795]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1120b5793d455cf4bda04fb01c8ee3b62934e368
          - Fix typo
            
            Change-Id: I1aa7bb120b7b025b63b53717d1e76500719c5885
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156111
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-08-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bbbd7e346c5b929ca3b867b6dd80c71b8dd788d6]

        crash case seen on clicking on drawing text box inside a footer
        
        Change-Id: Id7645ad651d237c94fecb2fc2b6c57a88f3caa55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-25  Michael Stahl  <michael.stahl@allotropia.de>  [4aa8fea8ac515e55bf3542e2717a3d85f1354054]

        tdf#128966 sw: add unit test
        
        Reverting commit c303981cfd95ce1c3881366023d5495ae2edce97 it fails with:
        
          Test name: testTdf128966::TestBody
          assertion failed
          - Expression: nContentBottom > nCellCenter
          - Cell nr.: 80 id=207
        
        So probably bfa81a200ab59971b69823f9a29d8ce222d655e6 was the wrong commit
        to contain the bug id...
        
        Change-Id: I69d309d5d5ddeacf66e865db4bb666d8120e717f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156092
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [e78eee620235817c01a8516e0cb9f1be5d5bf361]

        Simplify a bit
        
        Change-Id: Ie3a826430f016f79190a3d74885551cd72a2a1b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156088
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [87db52ab1e9c39ad8319aaf9c0c59d4435b6ffb5]

        Revert "use more Reference::query instead of UNO_QUERY_THROW"
        
        This reverts commit 7fc6063914432d58d86cfcbd728d967e7c86ebfd.
        
        sberg noticed that there is a difference now:
        
        there's a subtle difference now, in that if  y  was null originally, it would have thrown a (caught) exception, whereas now it will crash in the  y.query<X>()  call.
        
        Change-Id: Idbb5a08d635d15b5ca63f4822eddf05fb0a5afa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [139cffc531277b57bae8e272fef13af00ace5366]

        tdf#39519 - Rename slide if its name is not unique
        
        For instance, if a slide is copied by ctrl + drag and drop (DND_ACTION_COPY)
        
        Change-Id: I1c669c299a38431680ce602922c1e2c7f117a2ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154838
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-08-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a29d4aba60f9e0e7e8d34f8973a351f75a114426]

        sd: change text theme colors for graphic styles on theme change
        
        Change-Id: I6703c01999663c38d8e75654dcc308c49e014175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155818
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [286bde4f083470490251c2f43ffb7ea9b236b4fd]

        sd: add undo/redo for line/fill styles theme change
        
        Change-Id: I780e261c013a44426ce1baa3b10ddcf497dd54c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155817
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [7d7b2747751c442b7c75680d9960de70037e38d8]

        Use std::optional instead of out arguments
        
        Change-Id: I6dde7d602695d44488f7debf65d8ef278fa8704c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156087
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [c46f00166027fa3eefc75f9cb13bf4afc887bf1d]

        sc: fix crash in ScAttrDlg::PageCreated
        
        See https://crashreport.libreoffice.org/stats/signature/ScAttrDlg::PageCreated(rtl::OString%20const%20&,SfxTabPage%20&)
        
        Change-Id: I3f89cc917648462f819eb35461055096a6eb3853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156093
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b022db4cd397fd88f8078fc7f5ff85f21635155]

        sc: fix crash in ScTransferObj::DragFinished
        
        See https://crashreport.libreoffice.org/stats/signature/ScModule::GetDragData()
        
        Change-Id: Ic5cdc3e1796fa20ac84150a04bed539bc9ca7321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156094
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [c22720f3b8a3c5c6ce08a088513d9525c2837184]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07d0a97995ad6ea6f853e499b187fbe4ab8d4551
          - Document new SF FormDocument service
            
            Change-Id: I6bcf114d25877f5c69463285f9bddcf0c8339079
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155783
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2023-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [76e11899e1439b298883721907b49bd1813f5d0c]

        WNT -> _WIN32
        
        Change-Id: I09b1744c568b39c5b4160154536730962feb3a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156089
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-25  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [df982f67ced630fc417540941392459dee8ab7eb]

        Resolves tdf#155926 - Rename "Line Style 9"
        
        Sparse dash
        
        Change-Id: Ia676358ea0de4437dd2e5f210b26a4e97f8d8758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156090
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-25  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [05f7ab11bec87b706f598ae4e81d1f20cd4f1312]

        Resolves tdf#156404 - No hotkey to apply cloned formatting
        
        Block customization for FormatPaintBrush as it allows modifier
        keys and has a multi-step workflow
        
        The patch has no effect yet because of tdf#147411
        
        Change-Id: I4f5e423f483c490a994af4708552442f7716fc2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156052
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-25  Stephan Bergmann  <sbergman@redhat.com>  [bb2bd14b941ea0a8463264dcf8902ae67302b386]

        This copy ctor should probably take its arg by const ref
        
        It was introduced in 3426dcfec2b4d5c755024c355f323ecc9f656e4a "vcl gtk3:
        Introduce AT-SPI2 tests for the GTK3 accessibility layer", and caused at least a
        build with recent GCC 14 trunk to failed with
        
        > In file included from vcl/qa/cppunit/a11y/atspi2/atspiwrapper.cxx:10:
        > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx: In member function ‘Atspi::Accessible::iterator Atspi::Accessible::iterator::operator++(int)’:
        > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:524:20: error: cannot bind non-const lvalue reference of type ‘Atspi::Accessible::iterator&’ to an rvalue of type ‘Atspi::Accessible::iterator’
        >   524 |             return other;
        >       |                    ^~~~~
        > vcl/qa/cppunit/a11y/atspi2/atspiwrapper.hxx:508:28: note:   initializing argument 1 of ‘Atspi::Accessible::iterator::iterator(Atspi::Accessible::iterator&)’
        >   508 |         iterator(iterator& other)
        >       |                  ~~~~~~~~~~^~~~~
        
        Change-Id: Ia9a1e3f58d67db1fc9851fe8a844f2076ff740c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156075
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-25  Khaled Hosny  <khaled@libreoffice.org>  [900ce2fa32ae1726f64fc6959010650e93854ab3]

        tdf#101174: Add the ability to change math font in Math
        
        The math font (default is OpenSymbol) can now be changed from the fonts
        dialog like other fonts (variables, numbers, etc).
        
        Change-Id: I57f416173abf7bef8bb66b5e5e393dd928e30652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156053
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [b0652124dc92d5f62cef19f63a98aa8b68f5a850]

        tdf#45904: Remove old SwXParagraphEnumeration Java test
        
        Change-Id: Ia8b639e016971e389d24d4468492af902d1dc35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156042
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [30b7721f59d9ccfce7e2b40916309adff8ad851c]

        tdf#45904: Remove old SwXFootnotes Java test
        
        Change-Id: I7444b8521b560c91d2908d14330a3c6d6ff420cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156041
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [3b2d95ab67456c7d7b5e51ffcb664702c6c4d71b]

        tdf#45904: Remove old SwXFieldEnumeration Java test
        
        Change-Id: I5bbefc7c1c5ac9ebd88669ac328bba28183b76ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156033
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [e346c663e8ae835e9b1a618d7a5781bc1da9004e]

        tdf#45904: Remove old SwXDocumentIndexes Java test
        
        Change-Id: I93556b3c56887b424dd8720d752986563a0fa807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156032
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [1dca3e5839089608b640a1b9f69d1c8521d4b10e]

        tdf#45904: Remove old SwXStyleFamilies Java test
        
        Change-Id: I3057e4a2fcf1b057d35050bfeb7c22fbad19325b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156045
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [4453918e67a137440432381ef3bb2d03841e55d5]

        tdf#45904: Move SwXTextField Java tests to C++
        
        Change-Id: I11052e68289507778767df0d69cc8924f394b4f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156047
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [534326bf573ace5877c7d790b37399623aa71d79]

        tdf#45904: Move SwXTextEmbeddedObjects Java tests to C++
        
        Change-Id: I05ad9e264162e3fb97ebea814f59ed44bf23056a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156050
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [7a762a2c7ec5fe107697c06d31bc7a184011a338]

        tdf#45904: Move _XTextRangeCompare Java tests to C++
        
        Change-Id: I40390a8b05f0e685a9408f0c486f6129633bc5b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155634
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [52f785d15197b4ef645ae08015994f5accf2ec8e]

        tdf#45904: Remove old SwXReferenceMark Java test
        
        Change-Id: I81acf617726b7e7e5b5510b0d6d7677c7d08aba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156043
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [0440f57a096c2d8da704b3bc409ecfd74202ac8f]

        tdf#45904: Move SwXTextFieldMasters Java tests to C++
        
        Change-Id: Ifa185b24fe49f2c88e4d3687a09ebce5987503a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156051
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [7b999ca22824e102d283a8b7327fa2717db6568a]

        tdf#45904: Move _XAutoTextContainer Java tests to C++
        
        Change-Id: Ie6ebc43c52204984cb6196f539c735701d13dc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155627
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [bb8f57dfa17e108c4cd5d08a538077c3d2c6f195]

        tdf#45904: Move _BaseIndexMark Java tests to C++
        
        Change-Id: Ie6c09c0cfedbad8168281af354590ab7c9dd374e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155162
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  anfanite396  <dipamt1729@gmail.com>  [594665e757c4adec4d243e4c33299877b2264552]

        tdf#45904 Move _NumberingRules Java tests to C++
        
        Change-Id: I86d559767204e1e8e1fd232db63f26a5c1ce67da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155089
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Miklos Vajna  <vmiklos@collabora.com>  [80940d0fe5ab266ddf3000e5fdffcd9b8e0a1d86]

        sw layout xml dump: merge some copy&paste into a SwFrame::dumpAsXml()
        
        The idea is that each SwFrame subclass just dumps its own members, the
        rest of the dumper should be shared, not copy&pasted.
        
        Change-Id: I6ca837770f787f519071ed2f679353bd3f4b7b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156060
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9d1140cb745613625bbd8af251c778a7c789e6d0]

        xmloff: support stroke/line complex color import/export + test
        
        Change-Id: I4ed901fd5b23e58aafa781e2b07f460f034fbba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155685
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-25  Andrea Rosetti  <andreamassimo03@gmail.com>  [826300d55b8f18593c4b56fb448d09fac52820bd]

        tdf#86628 Add reset crop function to dialog
        
        Added a function that uncrops the image, keeping the modified size
        (which can be restored using the already existing Original Size button)
        
        Change-Id: I8e98de2b586c68d52f819955ce5a74f20cbe6698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155219
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e15bf7363adb20c77aee51e09b6f2604d741619b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a002539ad82004b15916510d2feaec5771a9c198
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(18)
            
            + refactoring
            + Writer Format menu (part 18)
            + Anchors (include Calc image anchor)
            
            Change-Id: I0f9f1f36d707ae0267c2fe23ab3382b6014adf16
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156073
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-24  Khaled Hosny  <khaled@libreoffice.org>  [5ca5acdd6e12fec08927743b60899100bc89af4d]

        tdf#140881: Ignore WOFF/WOFF2 fonts with FontConfig
        
        FC_FONT_WRAPPER requires unreleased FontConfig, but lets have this in so
        it works when FontConfig have it.
        
        Change-Id: I8f48ac1f68a3af6e1853e9eb1925d382b57136c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156049
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9b6f0bcb042354fd5c25f78e432b8983963e0e9c]

        Remove duplicated include
        
        Change-Id: I5bfb0f4bbebdd21c3ceef04b6a7eb36bdd41c52c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156034
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30c3bfe43049a63d934dac192961a069f6c34a3f]

        Fix typo
        
        Change-Id: I86dbe2909b19a8a9108f3ba76529ef378c2d663e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156039
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2c38f5fdaba37dd9f7239e95c28ad63e7174d6e0]

        Remove duplicated include
        
        Change-Id: Ie95a596a9ee9928ee475f49fb666150f67e0b122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156035
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9967f22ca160b1fe9784b8f67428c52ef8d4f2c2]

        Fix typo
        
        Change-Id: I1f4d28f834d7e9deb09460fde978bc30d05e351e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156037
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [482ebb5b5e3cd75199b386584da9753066b64e39]

        Fix typo
        
        Change-Id: Iab3ff5a5f9c8917d7de1d886aa331e6110b0ae4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156040
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7fe77a2d4d580817fa83d5d22bf53683ee38c9ce]

        Fix typo
        
        Change-Id: I97450e0259bca2188547bcc71328e27544edbc10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156036
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5391006caf76bfbb81238f709ad30ac37809b0f5]

        Fix typo
        
        Change-Id: Ief8634c54b5dcf8cdf92882e9026e42cf3e9935e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156038
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9679bc5f24a8965341840c458ba69479585815f7]

        Fix typo
        
        Change-Id: I9d1b0bbd99caa53515b8d8bf7d86723cd51aca6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156059
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-24  Miklos Vajna  <vmiklos@collabora.com>  [2e1ddc8aeb0a92cc43ef4b7dc4762cd50a6b7fbc]

        sw floattable: don't split if anchored inside a footnote
        
        See
        <https://gerrit.libreoffice.org/c/core/+/156025/1#message-94d8cdd4d59a4b991186e5780d41f213105a533d>,
        if we import an (inline) table inside a footnote from DOCX, we currently
        put that into an as-char anchored fly. In case the user would later
        change the anchor type to to-para, then we would crash in
        SwFlowFrame::GetPrevFrameForUpperSpaceCalc_().
        
        Avoid all this trouble by simply not allowing split floating tables in
        footnotes, seeing that the Word UI is also disabled for this case.
        
        Change-Id: I3cf9461beb291084e1cced5c66ca14e6b6d55126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156058
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-24  Regina Henschel  <rb.henschel@t-online.de>  [44c0f2da567b49ef8a539958a834f1bc841c2003]

        tdf#112687 Simplify polylines from slideshow annotations
        
        Drawing with 'mouse as pen' in a slideshow creates hundreds of points.
        By commit 631964a2ce1da3fbbeb53a5550c0e6728ba644aa they are at least
        already combines to a polyline. The patch here now reduces the amount
        of points in such polyline to a reasonable number. If at some point the
        drawings in the slideshow are improved, this can be removed.
        
        The reduction is performed using the Douglas-Peucker algorithm. I have
        added the method to b2dpolygontools because I think it could be useful in
        other contexts.
        
        Change-Id: I9224ec3546d4442da8bc348aea8ce7b88fcc46dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155811
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85d26674284bacff8f90de662b583d4d4291e65d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69be688d8006621fbf52a5a13cb7a46caaba4d62
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(17)
            
            + refactoring
            + Writer Format menu (part 17)
            + name and description
            
            Change-Id: I9561621a2fc628eec9da0636c31c81f5575059a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156057
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-24  Jun Nogata  <nogajun@gmail.com>  [feeb3a4604daa113894bdaa8c8698e0ded97050c]

        Template: tdf#86483: Add Japanese template to the Localization category
        
        As Kevin Suo noted in tdf#86483, CJK and CTL use different formatting than
        the US and Europe. Japanese is no exception, and must be formatted according
        to Japanese typesetting rules[1][2] before the document is created. However,
        many Japanese language users use LibreOffice without knowing this, resulting
        in strange Japanese documents. This template sets up the necessary Japanese
        formatting to reduce this.
        
        Originally, the template was supposed to be provided by the language pack.
        However, since a localization category was created, we thought it would be
        a good idea to provide the template first, as we did with Chinese, so we
        added it.
        
        This template has the following settings And the template is inspired by
        the OpenOffice.org Japanese Environment Improvement Extension Template[3]
        and Kevin Suo's Chinese template, which we have previously attempted to do
        the same.
        
        * Western and Asian languages are in the same font.
        * Paragraphs have been set to be justified.
        * Japanese paragraphs are originally indented by one character. However,
          since some documents do not use it, it is not set. Instead, the original
          Japanese paragraphs are set to First line indent style.
        * Italics has been removed from the style. Japanese does not use italics.
        
        [1] Requirements for Japanese Text Layout:
            <https://www.w3.org/TR/jlreq/>
        [2] Japanese Industrial Standards - JIS X 4051:2004(Japanese):
            <https://kikakurui.com/x4/X4051-2004-02.html>
        [3] OpenOffice.org Japanese Environment Improvement Extension:
            <https://ja.osdn.net/projects/openoffice-docj/releases/40804#note>
        
        Change-Id: Ieaf57c8e018d479e7922fbd9d616b9a6c271b1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155764
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-24  Jun Nogata  <nogajun@gmail.com>  [3adf0140c1c31ea82c023250f23404b6b54f833a]

        tdf#114746 Fix CJK and CTL font style in Impress templates
        
        The Impress template has the font styles required for CJK and CTL
        languages removed. Therefore, when CJK and CTL language users use
        the templates, the wrong fonts are selected.
        
        To fix this, CJK and CTL language font styles have been added.
        The fixed themes are as follows.
        
        Beehive, Blue Curve, Blueprint, DNA, Focus, Forest bird, Inspiration,
        Lights, Metropolis, Midnight Blue, Nature Illustration, Pencil, Piano,
        Portfolio, Sunset, Vintage, Vivid
        
        Change-Id: I41253d6cd67694eab10d0638f289c0c0241aff2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155659
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-24  Quentin PAGÈS  <quentinantonin@free.fr>  [d7493fcce9bb742791a835c9aff77d0b5ef81059]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 37935d20de99a065b8660d334a53d7b969446714
          - Update of Occitan spellchecker (more words and up-to-date licence
            
            Change-Id: Icf0cb0e4e00460116db7ac68d91c587e5715f85c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/151730
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2023-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0f31c19fb303b50eeba7d6a5812854314cc7bf70]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89e4b94cab3bc2ce743521cff019a9b8db7ddefd
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(16)
            
            + refactoring
            + Writer Format menu (part 16)
            + fraems and link frames
            
            Change-Id: I04e90e58bbaf4d59334fcb5f06aabb75bb572077
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156054
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-24  Patrick Luby  <plubius@neooffice.org>  [462f1c43cc97eb5c13343f285516702aa0c47a8d]

        tdf#156866 use mSize instead of mPixelSize for inverted surface
        
        Commit 5baac4e53128d3c0fc73b9918dc9a9c2777ace08 switched to setting
        the surface size to mPixelsSize in an attempt to avoid downscaling
        mImage but since it causes tdf#156866, revert back to setting the
        surface size to mSize.
        
        Also, in release builds, tdf#156629 and tdf#156630 reappear in many
        cases because a BitmapInfoAccess is in a debug block. So, instead
        of relying on other code to a create a BitmapInfoAccess instance,
        create one here to force the alpha mask to handle any pending
        scaling and make the alpha mask immutable.
        
        Change-Id: If9f0dfb7b9a82cf7a3e402965ceffd42eace4c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [edf922a05be1d9626164e9f07c2ed1826d039d95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 936109a862df5b8f25a350415d3d77ec67d985f6
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(15)
            
            + refactoring
            + Writer Format menu (part 15)
            + color toolbar and color submenu
            
            Change-Id: I86db2cda6c54fcd7610b8ec0befb200642536e36
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/156020
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-24  Khaled Hosny  <khaled@libreoffice.org>  [611694b707eb43e4c0f20b781f6869016a3ba099]

        vcl: Allow pushing/popping OutputDevice’s RTLEnabled state
        
        Change-Id: Icafdc307c5c9df768f00c3ac0d128936607bf3e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155794
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-24  Khaled Hosny  <khaled@libreoffice.org>  [a21ae72ab208b60bfd284d4630295f06e21c3481]

        starmath: Use OutputDevice::Push()/Pop() instead of doing it manually
        
        Change-Id: I628385cd64f3d65a1a567590bce754693b4d0684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155795
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-24  Michael Stahl  <michael.stahl@allotropia.de>  [bfa81a200ab59971b69823f9a29d8ce222d655e6]

        tdf#128437 tdf#128966 sw: layout: partially revert fix of tdf#124675
        
        The tdf#128437 bugdoc works since LO 4.1 commit
        84203fab20b7eb98f0d3667e6626f5c2139e5a7f "Resolves: #i120016# refine
        condition for allowing split of a table row".
        
        The non-obvious way in which commit cc5916cd314a27b0cc99560ab887480026630a95
        changes the layout is the FlowFrameJoinLockGuard on the table frame.
        
        While layouting page1, with LockJoin, formatting the content in the rows
        of the table leaves the table follow valid.
        
        Whereas without LockJoin, formatting the content in the rows grows the
        table frame and this invalidates the position of the follow table frame.
        
         0  SwFrameAreaDefinition::setFrameAreaPositionValid(bool) (this=0x7c85390, bNew=false) at sw/source/core/layout/wsfrm.cxx:90
         1  SwFrame::ImplInvalidatePos() (this=0x7c85390) at sw/source/core/layout/wsfrm.cxx:2001
         2  SwFrame::InvalidatePos() (this=0x7c85390) at sw/source/core/inc/frame.hxx:1053
         3  SwFrame::ImplInvalidateNextPos(bool) (this=0x6edefb0, bNoFootnote=false) at sw/source/core/layout/findfrm.cxx:1368
         4  SwFrame::InvalidateNextPos(bool) (this=0x6edefb0, bNoFootnote=false) at sw/source/core/inc/frame.hxx:1083
         5  SwTabFrame::GrowFrame(long, bool, bool) (this=0x6edefb0, nDist=10, bTst=false, bInfo=false)
            sw/source/core/layout/tabfrm.cxx:3428
         6  SwFrame::Grow(long, bool, bool) (this=0x6edefb0, nDist=10, bTst=false, bInfo=false) at sw/source/core/layout/wsfrm.cxx:1547
         7  SwTabFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x6edefb0, pAttrs=0x6f74d00) at sw/source/core/layout/tabfrm.cxx:3357
         8  SwTabFrame::MakeAll(OutputDevice*) (this=0x6edefb0) at sw/source/core/layout/tabfrm.cxx:2157
         9  SwFrame::PrepareMake(OutputDevice*) (this=0x6edefb0) at sw/source/core/layout/calcmove.cxx:375
         10 SwFrame::Calc(OutputDevice*) const (this=0x6edefb0) at sw/source/core/layout/trvlfrm.cxx:1803
         11 SwFrame::PrepareMake(OutputDevice*) (this=0x6f118a0) at sw/source/core/layout/calcmove.cxx:253
         12 SwFrame::Calc(OutputDevice*) const (this=0x6f118a0) at sw/source/core/layout/trvlfrm.cxx:1803
         13 SwFrame::PrepareMake(OutputDevice*) (this=0x6f11a30) at sw/source/core/layout/calcmove.cxx:253
         14 SwFrame::Calc(OutputDevice*) const (this=0x6f11a30) at sw/source/core/layout/trvlfrm.cxx:1803
         15 SwFrame::OptPrepareMake() (this=0x6f14da0) at sw/source/core/layout/calcmove.cxx:386
         16 SwFrame::OptCalc() const (this=0x6f14da0) at sw/source/core/inc/frame.hxx:1090
         17 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffdabdf0c90, pLay=0x6f11a30, bAddRect=false)
            sw/source/core/layout/layact.cxx:1461
         18 SwLayAction::FormatLayout(OutputDevice*, SwLayoutFrame*, bool) (this=0x7ffdabdf0c90, pLay=0x6f118a0, bAddRect=false)
            sw/source/core/layout/layact.cxx:1455
         19 SwLayAction::FormatLayoutTab(SwTabFrame*, bool) (this=0x7ffdabdf0c90, pTab=0x6edefb0, bAddRect=false)
            at sw/source/core/layout/layact.cxx:1679
        
        Thus invalidated, the follow frame's first row will move back and split.
        
        Unable to reproduce tdf#124675 with the FlowFrameLockGuard reverted -
        let's assume that some change elsewhere prevents this kind of crash now.
        
        The only problem with this is that some test fails (and i forgot which
        one), that's why the 3 previous commits are needed.
        
        What's amusing is that the layout with this fix is the same as the one
        in Word 2013, whereas the layout without this fix is the same as the one
        from exporting the bugdoc from Word 2013 in DOCX without compatibility
        mode, so this will be a "regression" for DOCX layout but it was all an
        accident anyway...
        
        This also fixes the last case of tdf#128966 so every row is vertically
        centered now; some previous commit improved it already.
        
        Change-Id: I46d77930666a1762ae16af09525f0b23660beba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155989
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-24  Michael Stahl  <michael.stahl@allotropia.de>  [c303981cfd95ce1c3881366023d5495ae2edce97]

        tdf#156724 sw: layout: fix tables not splitting due to footnotes differently
        
        Revert commit 610c6f02b11b4b4c555a78b0feb2a1eb35159e39 and
        and 61a78a523a6131ff98b5d846368e5626fe58d99c instead do the
        opposite: never calc content frames in FormatLayout().
        
        There were a few cases where documents looked worse with the fix, such
        as the somewhat pathological tdf120139-1.odt and tdf124474-1.odt, but
        typically these went from a bad layout to a worse layout, e.g.
        --convert-to pdf tdf120139-1.odt went from 11 minutes to 33 minutes
        (dbgutil) with twice as many more half-empty pages.
        
        Worse is that the previous fix appears to prevent tdf#128437 from
        working.
        
        It should also be less risky to never calc content frames in
        FormatLayout(), because with IsPaintLocked() check that used to be done
        led to doing it only for pages which were visible when loading the
        document, so any regressions with this new approach would appear on few
        pages at the start of the document, instead of many pages at the end.
        
        Note that without the previous commit, this would cause
        * CppunitTest_sw_core_layout CPPUNIT_TEST_NAME="testTablePrintAreaLeft"
          to fail
        * tdf#137523 SwLayoutWriter3 testTdf137523 to fail,
          *only* on the last text frame
        
        This also appears to fix tdf#125749.
        
        Change-Id: I3d72f8e9d2b89aa3738e554308fd9dce12e92238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155988
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-24  Michael Stahl  <michael.stahl@allotropia.de>  [7b1c03ed87f7a21606e09863b23074e6b96e26d1]

        tdf#154775 sw: layout: avoid breaking this with following commits
        
        The problem with commit 1b5bc2ae2f19a190bf588a5a26c4d125c3960991 is that
        the fix only works in case the fly is invalid at the time when
        SwTabFrame::CalcFlyOffsets() is called; if it is valid (which will be
        the case with following commits, for non-obvious reasons) then the fix
        does nothing, causing testTablePrintAreaLeft to fail.
        
        In Word 2013, this fly causes the table to shift down, despite its
        HoriOrient being LEFT; so adapt SwTabFrame::CalcFlyOffsets() to also
        shift down in this case.
        
        Likely it would be best not to check HoriOrient at all for ShiftDown
        case, but needs checking first what Word does in other cases.
        
        Change-Id: I465a55bbf1a783abce8b8d6d65099bd9df5695f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155987
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-24  Michael Stahl  <michael.stahl@allotropia.de>  [492ddef596c99a9c24d2778276025aafc612a7cb]

        tdf#137523 sw: layout: fix text below tables in footer differently
        
        This fix is better than commit 027f8328eef1e149b6c99b478ed5df870291dc2d
        because it turns out the last text frame had a height of 219 in 6.1.
        
        One of the following commits would break this, so a different fix is
        needed.
        
        In SwFrameNotify::ImplDestroy(), if the frame changes its position the
        next frame's position is invalidated; if the next frame is undersized
        then also invalidate its size so that it will be formatted again, with
        more space.
        
        Change-Id: I8e6a3fe3127ebfa2246c440d2a3455b217476475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155986
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-24  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [382dfb3e6ee73fc94a556e37d261e8219e08826c]

        Reset buffered GridOffset(s) for suspicious values
        
        Huge offsets of GridOffset(s) are a hint for error -> usually the
        conditions for calculation have changed. E.g. - I saw errors with
        +/-5740, that was in the environment of massive external UNO API
        using LO as target.
        If condtions for this calculation change, it is usually required to
        call
        - ViewObjectContact::resetGridOffset(), or
        - ObjectContact::resetAllGridOffsets() or
        - ScDrawView::resetGridOffsetsForAllSdrPageViews()
        as it is done e.g. when zoom changes (see ScDrawView::RecalcScale()).
        Theoretically these resets have to be done for any precondition
        changed that is used in the calculation of that value (see
        ScDrawView::calculateGridOffsetForSdrObject).
        This is not complete and would be hard to do so. Since it is just a
        buffered value and re-calculation is not expensive (linear O(n)) we
        can just reset suspicious values here  what fixes the problem.
        Hopefully - when that non-linear ViewTransformation problem for the
        calc-view gets solved one day - all this can be removed again. For
        now, let's just reset here and force re-calculation.
        Added a SAL_WARN to inform about this, too.
        
        Change-Id: I09137f7703fd00c2351a288a40bf87a2691ba6e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155983
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-08-24  Miklos Vajna  <vmiklos@collabora.com>  [178421a6c719dac9c16f220b76292fec16a53f60]

        tdf#77760 sw floattable: add support for footnotes, DOCX import
        
        This was originally added in commit
        2fe248f2b36d541c0d243a620c217058a50a9d5d (tdf#87460 DOCX import: fix
        missing endnote in floattable, 2015-06-23), because Writer core only
        allows footnotes in floating tables since commit
        56da1d30afe48cc4acd79567052a575e81f8c7a0 (tdf#77760 sw floattable: add
        support for footnotes, doc model, 2023-08-22).
        
        The DOCX export works already.
        
        The ODT filter also works: there is a mechanism to try to not insert
        footnotes in text frames, but the way XMLTextImportHelper::IsInFrame()
        is implemented means that it only rejects footnotes directly in text
        frames, not in tables-in-textframes, which is the interesting case for
        us.
        
        Change-Id: I90a5f0228385b2e3db8d994c6c76064fe595f439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156024
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bf1e649e6f626268db99d20ae921669ed557c3af]

        cid#1541185 Operands don't affect result
        
        when sal_Int64 == long
        
        Change-Id: I36fab92613a2e7dd8f3817b151e9a836b29803f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156014
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-24  Stephan Bergmann  <sbergman@redhat.com>  [b395d997f1cb501a4318f85d1095d09a3f3bfcad]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/92445f216f64ed63e46cbb29be1892449180eed9>
        "Update krb5-1.21.1.tar.gz to 1.21.2"
        
        Change-Id: I6c87a88416f3d8b6b335f8bbe0af5f8e8e7f7c96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156023
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [bff6a734dd4c2d5572a10f39a3a8dd5313c2278a]

        tdf#156847 Transparency in drop-down lists Line and Width on Sidebar
        
        regression from
            commit 1527fa8435ef415678b2e4a6972f5e378ee5cab1
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 6 11:20:17 2023 +0200
            convert SvtAccessibilityOptions to officecfg where possible
        where the method call returns a std::optional<bool> which is translated
        to a bool, resulting a true value from an optional<false>
        
        Change-Id: I2182cae5172798f38194ee86dbb32ef65e3e24be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [a3ce697e10a63d96cd081979b0f134239305a7cc]

        Small refactor
        
        Change-Id: I25fb8a769cd5e97863e5bd9fabae670589e4a18a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156018
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-24  Noel Grandin  <noelgrandin@gmail.com>  [8711197ac600621d40ae481d1c1eb85dd9e52fba]

        disable test_crashWithHiddenFirstTableColumn uitest
        
        it gets stuck about 50% of the time
        
        Change-Id: I5b2a68fa0d13633a4efd2fa0528b8937c27302e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-24  Miklos Vajna  <vmiklos@collabora.com>  [08517cb15b2a10d908f06c46e77677e659005e1e]

        UITest_sw_ui_frmdlg: use oneprocess mode
        
        Before: 0m15,305s
        
        After: 0m13,290s
        
        Also having this in UITest_sw_ui_fmtui, UITest_sw_uibase_docvw and
        UITest_sw_uibase_shells doesn't hurt.
        
        Change-Id: I3dbfd4cdccdd059d6daa03211409cea234c04617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156016
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-24  Michael Weghorn  <m.weghorn@posteo.de>  [f0a6c9c7da2f0393bdde2729565b2458d1ff6c5a]

        vcl: Fix gcc 13.2 build (vcl::PDFWriterImpl::emitType3Font)
        
        Fix this build failure seen with a gcc 13.2.0 `--enable-werror`
        build on Debian testing:
        
            .../vcl/source/gdi/pdfwriter_impl.cxx: In member function ‘bool vcl::PDFWriterImpl::emitType3Font(const vcl::font::PhysicalFontFace*, const vcl::pdf::FontSubset&, std::__debug::map<int, int>&)’:
            .../vcl/source/gdi/pdfwriter_impl.cxx:2719:47: error: moving a temporary object prevents copy elision [-Werror=pessimizing-move]
             2719 |                 BitmapEx aBitmapEx = std::move(aReader.read());
                  |                                      ~~~~~~~~~^~~~~~~~~~~~~~~~
            .../vcl/source/gdi/pdfwriter_impl.cxx:2719:47: note: remove ‘std::move’ call
            cc1plus: all warnings being treated as errors
            make[1]: *** [.../solenv/gbuild/LinkTarget.mk:337: .../workdir/CxxObject/vcl/source/gdi/pdfwriter_impl.o] Error 1
        
        Change-Id: I9f0ba1afd0dee2a8aaa4708672c755ab3a97e5a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156021
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b5aaf194866c5e416167cb54d37f9f04dabc5375]

        sd: change fill/line theme colors for graphic styles on theme change
        
        Change-Id: Ieeb425519e805160bf6726a64086508290f9d521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155684
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [37203cb43758048134584f7d52efbc9b3dc59f65]

        Fix setting ComplexColor for lines/strokes through the dialog
        
        Setting the line/stroke color through the (tab) dialog did not
        work as the complex colors was not set to the XLineColorItem.
        
        Change-Id: Ie1404264f2f82964fe3a5507a6f61ba269254134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155683
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ad873064b0135e4e00389cd38c7de688286c1fa1]

        sd: add ThemeDialog to Impress/Draw, refactor ThemeColorChanger
        
        Add "Theme" menu action, which starts the common ThemeDialog.
        Add Impress/Draw specific ThemeColorChanger and remove the one in
        svx, so that only the interface and common function remain.
        Rename the svx ThemeColorChanger files to THemeColorChangerCommon.
        
        Change-Id: Ibf07a443cadf0452747ab6685f65df37b145c984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155682
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [bf15445b7102a4e2bea2f96891093bc4bf07c4c6]

        tdf#99609 tdf#156473 a11y: Check whether row header exists
        
        Don't allow using `BBINDEX_ROWHEADERBAR` as the
        child index unconditionally, but only if the
        browse box actually has a row header.
        
        An `AccessibleTabListBox` doesn't have a header
        and instead returns the table when requesting the
        child at index 1 (`BBINDEX_ROWHEADERBAR`).
        
        Now that row headers are propagated to the Windows
        platform accessibility layer with
        
            commit 2b30d37bd555188733a006e1a5796461ab11d326
            Date:   Thu Aug 3 15:48:48 2023 +0100
        
                tdf#156473 wina11y: Fix invalid write due to row/col mismatch
        
        in place, NVDA confusingly started announcing all cells
        in the currently selected row as row headers for
        the currently selected cell in the Expert Configuration
        dialog, because of the table being returned without
        this change in place (while the cells in that table don't
        actually have any row headers).
        
        Related backtrace of how the table was returned
        for the row headers:
        
                1   accessibility::AccessibleTabListBox::getAccessibleChild          accessibletablistbox.cxx     90   0x7fffb8ab64bb
                2   accessibility::AccessibleBrowseBoxTable::implGetHeaderBar        AccessibleBrowseBoxTable.cxx 214  0x7fffb8a7e241
                3   accessibility::AccessibleBrowseBoxTable::getAccessibleRowHeaders AccessibleBrowseBoxTable.cxx 116  0x7fffb8a7da02
                4   QtAccessibleWidget::rowHeaderCells                               QtAccessibleWidget.cxx       1808 0x7fffe3e51e97
                5   AtSpiAdaptor::tableCellInterface                                 atspiadaptor.cpp             2801 0x7fffe2cee526
                6   AtSpiAdaptor::handleMessage                                      atspiadaptor.cpp             1450 0x7fffe2cde6ee
                7   QDBusConnectionPrivate::activateObject                           qdbusintegrator.cpp          1416 0x7fffe14cc216
                8   QDBusActivateObjectEvent::placeMetaCall                          qdbusintegrator.cpp          1572 0x7fffe14cceba
                9   QObject::event                                                   qobject.cpp                  1438 0x7fffe3621280
                10  QApplicationPrivate::notify_helper                               qapplication.cpp             3287 0x7fffe1ba2414
                11  QApplication::notify                                             qapplication.cpp             3238 0x7fffe1ba2224
                12  QCoreApplication::notifyInternal2                                qcoreapplication.cpp         1123 0x7fffe35a3c34
                13  QCoreApplication::sendEvent                                      qcoreapplication.cpp         1557 0x7fffe35a46f5
                14  QCoreApplicationPrivate::sendPostedEvents                        qcoreapplication.cpp         1924 0x7fffe35a55b2
                15  QCoreApplication::sendPostedEvents                               qcoreapplication.cpp         1781 0x7fffe35a4eba
                16  postEventSourceDispatch                                          qeventdispatcher_glib.cpp    240  0x7fffe39b26d3
                17  ??                                                                                                 0x7fffe97135b4
                18  ??                                                                                                 0x7fffe9716607
                19  g_main_context_iteration                                                                           0x7fffe9716bfc
                20  QEventDispatcherGlib::processEvents                              qeventdispatcher_glib.cpp    390  0x7fffe39b2f67
                ... <More>
        
        Also add an assert that
        `AccessibleBrowseBoxTable::implGetHeaderBar` only
        gets called with indices for row/col header, not
        arbitrary integers.
        
        Change-Id: Id7ebab9bfa8a7f05cb43da1bf5756e5980f4ed20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156012
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [16cf257554887aeb6dc426c54ceeb8d70a6aadd0]

        a11y: Simplify AccessibleBrowseBox::implGetHeaderBar
        
        Use the `mxColumnHeaderBar` and `mxRowHeaderBar`
        members directly instead of a pointer to an `rtl::Reference`
        that can be either of them.
        
        Change-Id: I620c7ba92a14fad50d9371b1762b5d5ad05fd7ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156011
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [9ba4b01ba57d059a04038823a1f0cf3bb2cb383c]

        a11y: Make AccessibleBrowseBoxBase's client ID private
        
        The getter and setter are only used by the class itself, not
        by any derived classes, and the client ID is an implementation
        detail, so make the methods private instead of protected.
        
        Change-Id: I380aa9848ae515b7b4ae1a727b3c5720b53250fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156010
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f6e8e1799315fd9494db514d969c24cf0ca46753]

        crashreporting: crash seen in FormNavigator
        
        set_text(rVclIter.iter, rText, col);
        ...
        m_xTreeView->set_text(*xEntry, pNameChangedHint->GetNewName());
        ...
        m_pNavModel->Broadcast( aNameChangedHint );
        
        Change-Id: I31275dd37de0146eae2ebb0931a5450e34fd21fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155985
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [6fd755fb36472938757b2581cbe99f5e5fe1ae40]

        tdf#100894 lots of Conditional formatting freeze calc Styles sidebar
        
        use bulk_insert_for_each to reduce time spent adding to treebox
        
        Takes it from "who knows, I gave up", to about 10 seconds on my machine
        
        Change-Id: I7cfa88c7378007f4f27c7177d1f7509656e4052a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9f6927e882b8e4f207ec632f0802a6136a165d88]

        cid#1541186 Operands don't affect result
        
        We probably manually silenced this in the past, so now it has returned
        after the code has changed enough to trigger it.
        
        I don't think we need to check for LONG_MAX in this case, we only return
        0 or -1 here anyway.
        
        Change-Id: Ic2ba171a8c7c3f74d98088434a85e947fcadf7b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155958
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [50b17f70c4f780d0a8e3f3c30f2b647ba400d504]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9d9886700eafd2f71be1f0c5b25d991d4612bc2a
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(14)
            
            + refactoring
            + Writer Format menu (part 14)
            + UNO commands get a help page of its own.
            
            Change-Id: Iccac500359fece107e91393c3fa38df393a217b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155984
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-23  Patrick Luby  <plubius@neooffice.org>  [2f5bc5989bab384fee066d0346eb7312f4a58d2a]

        tdf#156854 invert alpha mask for macOS native menu item images
        
        At the time of this change, only the AquaSalMenu class calls this
        function so it should be safe to invert the alpha mask here.
        
        Change-Id: Id67ad0f453bbf88b43d37087eef36a27ced3ad37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155977
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12a754e7bc94e96ac3e8ddb9e62454e7192bd62d]

        Fix typo
        
        Change-Id: Iaa9fbb1545a2dbe373ba0f71eaf10fe067888ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155982
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [34a6f9caa261aa59f2d9c653cdecdbf555be0f69]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1d3d960ade9a1f61ab715ee7d16335a44625100
          - Fix typo
            
            Change-Id: Ieb3dad4e32bb23aaa91dbc83036e552ca9e07c8c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155981
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc2dc496434fdb6f0babde509ee22c2952d532d0]

        fix bug inScGlobal::CheckWidthInvalidate
        
        introduced in
            commit 6adabd915d931b845fcf2fef15fbf3fca14ec9b3
            Author: Luboš Luňák <l.lunak@collabora.com>
            Date:   Sun Mar 6 16:53:47 2022 +0100
            faster check whether attributes have changed (tdf#117366)
        
        Change-Id: I6f4eadcda9bd59f7ae8eff61b66162223fdc9700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-23  anfanite396  <dipamt1729@gmail.com>  [6d9f68e47a1984fe310293ea2318e314f4a18bb2]

        tdf#45904: Remove old SwXBookmark Java test
        
        Change-Id: If17818329b805a03b975e105ea97f7c6cc16d1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155767
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  anfanite396  <dipamt1729@gmail.com>  [bb720ac6aba93256c0ecdd8e50b29e750428ff49]

        tdf#45904: Remove old SwXDocumentIndex Java test
        
        Change-Id: Idca41ac1aed35552a749eb62e886c06cec94b3e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155790
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  anfanite396  <dipamt1729@gmail.com>  [2c5dfcf4b076aa8a75423a26b0804d5afc90ff0f]

        tdf#45904: Move SwXTextTables Java tests to C++
        
        Change-Id: I3946e68ce5c8a9611c243e427bc94c277c0a5456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155810
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  anfanite396  <dipamt1729@gmail.com>  [49c4f0581c7a926f0ab836241f912c70fc9cac75]

        tdf#45904: Move SwXTextSections Java tests to C++
        
        Change-Id: I24f7098f71a126790a177715a85fcea2724cb4aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155808
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  Attila Szűcs  <attila.szucs@collabora.com>  [24cd55341bc3f3e8ed9d5ff23efd47a53532f283]

        tdf#156611 SC: hyperlink option for MS behaviour
        
        Added an options that can limit Calc to behave like MS excel in case
        of inserting hyperlinks, when MS format document is used.
        Tools -> Options -> LibreOfficeDev Calc -> Compatibility -> Hyperlinks
        
        In MS excel, only cells can have a hyperlink, and only 1.
        In Calc even textfields in a cell can have hyperlinks, so it can have
        multiple links in a cell, but once saved as MS format, and reloaded,
        textfield links will become cell links, if there was 1 link in the cell.
        If there was more links in the cell, then all will be lost.
        
        So, when MS excel format document is edited in calc, the ability to make
        text field links is useless can be missleading, and confuse users.
        
        If this option is set, and an MS file format is opened, then insering a
        hyperlink will work like if we selected the whole cell to insert the
        hyperlink.
        
        Change-Id: I7174216d10cf250d48f23f71ae681c46f7610bbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [a2d8f1dda7ce89ad9eef9f7c6da1024e607dc186]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3d767df226fbda339165a48ca79fa6d21e6b71be
          - Document new UserData property in SF_Platform
            
            This patch also creates a new example and refactors the previously existing one.
            
            Change-Id: I7523188afcb058f0c8457b57c9680b6d8ec166e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155918
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-08-23  Patrick Luby  <plubius@neooffice.org>  [7d745697eec8dc5702eb0ebaa8c4b5122c31edab]

        tdf#156853: Fix PDF export of bitmap color fonts
        
        Emoji bitmaps need to have their alpha mask inverted like is done
        with transparent images and shapes. So, invert the alpha mask of
        Type 3 font bitmaps.
        
        Also, add links to test documents for future development and testing.
        
        Regression from:
        
        commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
        Date:   Fri Apr 16 20:33:10 2021 +0200
        
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I18223a231ab751945883ede029d660949a406f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155960
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-23  Balazs Varga  <balazs.varga.extern@allotropia.de>  [069569e4a095f2fe42e94c2dad15356e2038727a]

        tdf#156116 - A11Y - fix object name does not update in accessibility sidebar
        
        when we modify the name on the Navigator sidebar.
        Update the related accessibility issue after we modify the name on the sidebar.
        
        Change-Id: I8f4b8780ff1ffe7cfb86ff837c9579d6b785b832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155904
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-23  Miklos Vajna  <vmiklos@collabora.com>  [3f92b781400c47ead0fa535d19ec33e6273be2ab]

        vcl: fix gtk4 build
        
        See
        <https://gerrit.libreoffice.org/c/core/+/155750/4#message-036c9ad1bebd18ae6458cb23d582e0fbd0272b61>.
        
        Change-Id: Ibee5c4973a1ea80515742852385e97718b10a260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155965
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f12d6b76b6dd80c81a4d9902593ef5c762a3af73]

        tdf#156701: Move DontEnableJava handling into askForRetry
        
        Change-Id: I0deeed09fcea765e66c1967f40d60a1222f90c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155964
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a3060f6eb1f6d66fe230f919e560c28987135be]

        update credits
        
        Change-Id: I9747388a7b1514a165b2e6aad3e211139a0e4633

2023-08-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6110a43bf0be6c87747a3d16fac25557ca99d4b2]

        Update git submodules
        
        * Update translations from branch 'master'
          to f241f292e37625cfdf3d0ec6f5d73b34da1b62bb
          - update translations for master/7.6.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Ibf94fb3aaa4d0146d310c54bb99238dd767e31ad
            
2023-08-23  Miklos Vajna  <vmiklos@collabora.com>  [f8e1a62f944e5358fe498008b4ff8701f1e190a0]

        tdf#77760 sw floattable: add support for footnotes, layout
        
        Once the footnote was inserted to the document model, the layout was
        also missing (footnote portion, footnote frame).
        
        One problem is that the footnote portion was empty instead of the
        footnote counter, because SwTextFormatter::NewFootnotePortion() returned
        early in the fly case.
        
        The other problem was the missing footnote frame, but once the footnote
        portion was created correctly, the matching footnote frame was also
        created.
        
        File filters (ODT, DOCX) still needs more work.
        
        Change-Id: If71c44962f604f23fdcfccfe80b0d97787fd99d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155961
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eb217182a5c44de748218fea009a245254f30b95]

        move theme test from svx to sd - so we can use ThemeColorChange
        
        Change-Id: I39cdc3baf81d3cb75d21ec963c05be57b97f30ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155865
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-23  TokieSan  <eltokhy@aucegypt.edu>  [9f327102c435887bbae650b3a573f44500b6f534]

        Removed Type and Usage Columns from Certificate Chooser
        
        Both columns are irrelevant in the main dialog's view, can be viewed
        through viewing certificate's details.
        
        Change-Id: I265a7e125c2679f3a05dba4414f4104f3a5cac2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155746
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-23  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [fabb63ff5f2b626724517e4a9ab1739e7956a37e]

        tdf#146619 Remove unused includes from vcl/inc
        
        Change-Id: I8fbe02547d5045cfdb5021720b10ddd10106209a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155750
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-23  Miklos Vajna  <vmiklos@collabora.com>  [7c15750cecea2aeb05653c0ee67b933d969b1f0b]

        tdf#155510 ODT import: ignore props of covered table cells, unless in comp mode
        
        The problem was that the A5 cell on page 2 used to have a solid
        background, but this was lost after commit
        1001dbaef4dec2b51c25ed8343bab6910f1219e1 (ODT import: handle style name
        of covered cells, 2021-03-19).
        
        Covered cell formatting was interesting for cell borders, in Word compat
        mode the covered cell can have its own border style, so e.g. there is
        left border on a vertically merged cell till its center, but not after
        its center.
        
        Fix the problem by limiting the import of covered cell formatting to the
        case when the TABLE_ROW_KEEP compat flag is on, to keep both native ODT
        and ODT-from-Word documents happy.
        
        If there is a need, some smarter way of merging properties could be
        implemented in the future.
        
        Change-Id: Icc1e6f48d9f5a0379d9a9052a1f5b9ae3f294477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155957
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-23  Mike Kaganski  <mike.kaganski@collabora.com>  [1530584a7214ca92b457b24ebf5f0e444d805dca]

        MPL subset: don't stop on first error - collect it all
        
        Otherwise, I have to disable items one by one, only to get to the
        next error.
        
        Change-Id: I21b915ccc2ebca32d185c8b68697fcb2991e005c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155959
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c9916d9be9c060d43fc063b76d70629162650fea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2aa198ab57081bed9c012ea49c25fcd9d05dbfcb
          - (related) #tdf144512 change in AutoRecovery behavior
            
               *  unify diverse references to "AutoRecovery"
               *  update xml to current practice
            
            Change-Id: I2b4192582be9b813b683b379a9e2fda5bf6dfdfd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155595
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-08-22  Michael Weghorn  <m.weghorn@posteo.de>  [18d45783a6c9f0d13fa0fae7b623be0805d8d825]

        wina11y: Drop CAccActionBase::GetXInterface
        
        Just use the `pRXAct` member directly.
        In particular the fact that all of the `CAccActionBase`
        methods mixed both ways of accessing the member (first checking
        `pRXAct` directly, but then retrieving it via
        `CAccActionBase::GetXInterface` to call a method
        on it) didn't really increase readability of the code.
        
        Change-Id: Ic6f5ce9a9b229b949ac656668e3bbf01cb65af2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155956
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-22  Michael Weghorn  <m.weghorn@posteo.de>  [cd00bc50a7425e2f58d54de80b714cb6b0362dce]

        tdf#156473 a11y: Keep a reference to table's a11y object
        
        Keep a Reference to the a11y object in `TableControl_Impl`,
        to prevent the object from getting deleted while it's still
        needed.
        
        Fixes a crash with this backtrace on Windows when closing
        the macro dialog from tdf#156473 with the NVDA screen reader
        active:
        
            1 cppu::WeakComponentImplHelperBase::release implbase.cxx 70 0x7ff97c1f0f72
            2 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext,com::sun::star::accessibility::XAccessibleComponent,com::sun::star::accessibility::XAccessibleEventBroadcaster,com::sun::star::lang::XServiceInfo>::release compbase.hxx 86 0x7ff9200cc5a4
            3 rtl::Reference<accessibility::AccessibleGridControl>::clear ref.hxx 198 0x7ff9200cc25b
            4 accessibility::AccessibleGridControlAccess::DisposeAccessImpl AccessibleGridControl.cxx 335 0x7ff9200cc17a
            5 svt::table::TableControl_Impl::disposeAccessible tablecontrol_impl.cxx 2397 0x7ff955829173
            6 svt::table::TableControl::dispose tablecontrol.cxx 74 0x7ff9558190e4
            7 VclReferenceBase::disposeOnce vclreferencebase.cxx 39 0x7ff9494f4fda
            8 VclPtr<vcl::Window>::disposeAndClear vclptr.hxx 207 0x7ff9556b0fbe
            9 VCLXWindow::dispose vclxwindow.cxx 927 0x7ff9556b0c9c
            10 SVTXGridControl::dispose svtxgridcontrol.cxx 766 0x7ff9557e2577
            11 UnoControl::dispose unocontrol.cxx 362 0x7ff95585bc3c
            12 toolkit::UnoGridControl::dispose gridcontrol.cxx 292 0x7ff9557c9667
            13 UnoControlContainer::dispose unocontrolcontainer.cxx 413 0x7ff955874606
            14 ControlContainerBase::dispose controlmodelcontainerbase.cxx 1387 0x7ff95573f480
            15 UnoDialogControl::dispose dialogcontrol.cxx 336 0x7ff95576aca1
            16 UnoControl::disposing unocontrol.cxx 670 0x7ff95585ee37
            17 UnoControlContainer::disposing unocontrolcontainer.cxx 432 0x7ff95587487c
            18 ControlContainerBase::disposing controlmodelcontainerbase.cxx 1394 0x7ff95573f555
            19 UnoDialogControl::disposing dialogcontrol.cxx 343 0x7ff95576ad45
            20 comphelper::OInterfaceContainerHelper4<com::sun::star::container::XContainerListener>::disposeAndClear interfacecontainer4.hxx 397 0x7ff955748752
            21 ListenerMultiplexerBase<com::sun::star::container::XContainerListener>::disposeAndClear listenermultiplexer.hxx 106 0x7ff95572da7b
            22 ControlModelContainerBase::dispose controlmodelcontainerbase.cxx 223 0x7ff95572d855
            23 OGeometryControlModel_Base::disposing geometrycontrolmodel.cxx 429 0x7ff9557930f9
            24 cppu::WeakAggComponentImplHelperBase::dispose implbase.cxx 230 0x7ff97c1f1dca
            25 SbiInstance::~SbiInstance runtime.cxx 360 0x7ff975dfdd1b
            26 SbModule::Run sbxmod.cxx 1189 0x7ff975d532e7
            27 SbModule::Notify sbxmod.cxx 776 0x7ff975d525d3
            28 SfxBroadcaster::Broadcast SfxBroadcaster.cxx 41 0x7ff96c5366ab
            29 SbMethod::Broadcast sbxmod.cxx 2121 0x7ff975d59c07
            30 SbxValue::Get sbxvalue.cxx 290 0x7ff975e7a6be
            31 SbMethod::Call sbxmod.cxx 2077 0x7ff975d5988d
            32 basprov::BasicScriptImpl::invoke basscript.cxx 255 0x7ff8bb962d8f
            33 SfxObjectShell::CallXScript objmisc.cxx 1439 0x7ff96dfe53a0
            34 SfxObjectShell::CallXScript objmisc.cxx 1468 0x7ff96dfe60c2
            35 SwDoc::ExecMacro docbasic.cxx 122 0x7ff8c8b30c33
            36 SwWrtShell::ExecMacro wrtsh3.cxx 326 0x7ff8c9ee2a45
            37 SwWrtShell::ClickToField wrtsh2.cxx 396 0x7ff8c9ede8ce
            38 SwEditWin::MouseButtonUp edtwin.cxx 4969 0x7ff8c9abbeae
            39 ImplHandleMouseEvent winproc.cxx 720 0x7ff949306165
            40 ImplHandleSalMouseButtonUp winproc.cxx 2353 0x7ff94930b0e7
            41 ImplWindowFrameProc winproc.cxx 2702 0x7ff949309b92
            42 SalFrame::CallCallback salframe.hxx 310 0x7ff9240b2c89
            43 ImplHandleMouseMsg salframe.cxx 3292 0x7ff9240d48c1
            44 SalFrameWndProc salframe.cxx 5688 0x7ff9240bbf9c
            45 SalFrameWndProcW salframe.cxx 6043 0x7ff9240bb6f4
            46 CallWindowProcW USER32 0x7ff9c395e858
            47 DispatchMessageW USER32 0x7ff9c395e299
            48 ImplSalDispatchMessage salinst.cxx 474 0x7ff924008e03
            49 ImplSalYield salinst.cxx 546 0x7ff924008cad
            50 WinSalInstance::DoYield salinst.cxx 580 0x7ff9240090f5
            51 ImplYield svapp.cxx 352 0x7ff9499a3f3b
            52 Application::Yield svapp.cxx 437 0x7ff9499a3923
            53 Application::Execute svapp.cxx 329 0x7ff9499a372b
            54 desktop::Desktop::Main app.cxx 1601 0x7ff97ef6caf3
            55 ImplSVMain svmain.cxx 204 0x7ff9499be0a0
            56 SVMain svmain.cxx 236 0x7ff9499bfce9
            57 soffice_main sofficemain.cxx 94 0x7ff97efdb1d8
            58 sal_main main.c 51 0x7ff7e580104a
            59 main main.c 49 0x7ff7e5801029
            60 invoke_main exe_common.inl 79 0x7ff7e5801269
            61 __scrt_common_main_seh exe_common.inl 288 0x7ff7e580139e
            62 __scrt_common_main exe_common.inl 331 0x7ff7e580141e
            63 mainCRTStartup exe_main.cpp 17 0x7ff7e580143e
            64 BaseThreadInitThunk KERNEL32 0x7ff9c2eb7614
            65 RtlUserThreadStart ntdll 0x7ff9c4bc26b1
        
        Change-Id: I10e44024f88465950953229e695e0cfe4c4a69c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155953
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a701a726dc3ccc174d1323a298c3550733773df9]

        tdf#101895 don't unconditionally default to ch[ar]/line
        
        if CJK typography is available.
        
        Given that we choose to show cm vs inch based on
        SvtSysLocaleOptions::GetRealLanguageTag() also choose to use ch[ar] and
        line based on that setting when bApplyCharUnit is enabled.
        
        Change-Id: I812d05e0639f7e214d5c3d4dcca01b0709126fd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2247336409b7b3b0ae04356a167dcd204badb04]

        tdf#129356: handle css combinator when the element name is combined...
        
        ... with the ID or the class
        
        While at it, simplify the code a bit
        
        Change-Id: I9e36f334b884d31229568835a346d4427a47c760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155945
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [3cf3e0e21d2f7fa33abced5e2f7291de6e4441eb]

        tdf#156856: close write access before using AlphaMask
        
        Change-Id: I432417f03d378f81c890ce6c313a2f140b564a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155955
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-22  Jim Raykowski  <raykowj@gmail.com>  [6761b79e7b48a5885adecf445f0206f141888613]

        tdf#156610 tdf#139633 SdNavigator: Fix object not selected
        
        for entry that context menu is shown for, GtkInstance only
        
        Commit fdb504add8e21c137a37fde48fedb93638e8ee97 introduced a hack to
        make inplace editing work for the SalInstance of the treeview that,
        for Gtk3, breaks object selection before the entry popup menu is
        displayed which causes the menu item Rename... not to always work as
        expected. Sal doesn't notice this because the mouse pressed signal is
        seen when there is a popup menu handler set. Gtk3 does not fire the
        mouse pressed signal when a popup menu handler set. This patch makes
        object selection always happen before the popup menu is shown.
        
        Change-Id: I562ddf99bd15a48631170a7d70821021a4139295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155867
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e46e663cc350d89e4997095466d675b875eb2e04]

        Related: tdf#98367 allow drawing shapes in calc to have smallcaps
        
        which is something excel allows, so allow this too
        
        Change-Id: I084969f09030999d623da80d1bd46bdf1f8aa897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49b321f659fd51c1fd4ff0be54b09a6113cff273]

        smallcaps: support dxarray in SvxDoDrawCapital
        
        Change-Id: I1924fce8323fb14f75f49cb67320f21a3ca62cc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36ab04a0e4fd6d8b8747a8e435a7143f4e3b10dd]

        smallcaps: we only use width, so drop the height
        
        Change-Id: I860e5ff246cb21749a73deb83cdd2e26c0ad4b3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155936
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ffaed5cae29d6bb14faf870cb935ccd3c35d4a3c]

        tdf#98367 implement rendering of draw/impress small capitals
        
        arising out of Þe old tdf#91932
        
        Change-Id: I953aabc280bc31ef1297dc79d483eb3d28a542f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155846
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [97469c2cac442fc3231694e35a8cd7a0f8d16af4]

        Related: tdf#98367 export editeng EE_CHAR_CASEMAP the same as writer does
        
        so can cut and paste from impress/draw to writer, import already works
        
        Change-Id: Ifc35687b1f77f6519d14a71820bb635ff25a159f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Miklos Vajna  <vmiklos@collabora.com>  [56da1d30afe48cc4acd79567052a575e81f8c7a0]

        tdf#77760 sw floattable: add support for footnotes, doc model
        
        The bugdoc had a floating table, but we didn't convert the inline table
        to floating because it had a footnote, and having footnotes in fly
        frames is not supported in Writer.
        
        One benefit of not having footnotes in fly frames is that once these are
        saved to Word shapes, those can't have footnotes, either -- there is
        value in limiting the UI to the constructs that can be also saved in
        Word formats.
        
        Fix the problem by allowing this for split flys, but not for
        flys/headers/footers in general.
        
        This is just the doc model, later steps (layout, etc) still need doing
        in follow-up commits.
        
        Change-Id: Ic3ba95877d7fad3f5f30743b89e2cf90e0d0af52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155944
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-22  Patrick Luby  <plubius@neooffice.org>  [8dc8413b4f8037b9c89f08a5b0b939bb61052585]

        Revert "tdf#156853: Fix PDF export of bitmap color fonts"
        
        This reverts commit 3e20c3e73cbd10e8323f0997e3a6536abd11e2bd.
        
        Reason for revert: This breaks every single fix that I have made for exporting alpha masks to PDF. A different solution is needed as the invert needs to be where it was to snapshot the AlphaMask.
        
        Change-Id: I5f743b67067dff43a2324d6ca9bc1f444e245a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155917
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Patrick Luby <plubius@neooffice.org>

2023-08-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3c4dd500820bd4214e9dc157e93e060c7fd14380]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba66530a081cf3aadd706939fc7c580934af09dd
          - Fixes some "D'oh! you found a bug".
            
            Change-Id: Ic3de5b49ef7bc3c33824bdde0a730adad09128ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155947
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e1352a2d7a5fcd4451e039f6ef8c454fd46f1851]

        Fix typo
        
        Change-Id: Ide2a33e282b575caf14374d7ae8034da41a6ed63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155942
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c5607f2dc029baed59f322e849dbd67551c7a87]

        Remove executable bits on docx file
        
        Change-Id: Ia869d126d137297972696be55db5951629676a4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155940
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [88ade32040e522e6d3aff0c5d1ebee4a92e6136c]

        Fix typo
        
        Change-Id: I05e93bd2c9ca3a270e07a4c0c7d09e4d3d6cea81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155941
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-22  Deepika Goyal  <deepika.goyal07@gmail.com>  [3297c1912f40450f92b67ad592ac255e1cd21749]

        tdf#143148 Use pragma once in vcl
        
        Change-Id: I99ef7d219a427989397d7d7dc75e1e0ebc8e22d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155812
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [3eee14d4e769ad063e71ccb476f722188a66d50f]

        tdf#156825 Half of the splash screen is visible on both monitors under Linux
        
        Blind fix, since I don't have two screens.
        
        regression from
            commit 4c00a5bce384c5fa3b46cf5bb29c7e9b1e506ea0
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jul 20 11:27:17 2023 +0200
            Assume that, if we have X11, it supports Xinerama
        
        It looks like I missed the removal of some USE_XINERAMA pieces
        
        Change-Id: I402db170916efe935d8ff9f96cc9b327070809b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0541176c24e044fc296d7431e033faf48f69ef09]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5eebefd650b99cd9cabba9b1d717e7c0e0b71037
          - Add missing file
            
            Change-Id: Ia9c750ea8a6fa49eeb4c30a7a9e9fdbcabb8dce5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155946
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-22  Michael Weghorn  <m.weghorn@posteo.de>  [f075fa01cb4f74185f13eb0a8d7f84cf1f47af49]

        tdf#141101 tdf#101886 a11y: Restore previous focus on col/line popup close
        
        Don't request focus for the color window
        before the menu button popup opens.
        
        Doing so would prevent properly restoring focus to the
        menu button itself after the popup closes again.
        
        Without this change in place, the call to
        `MenuButton::Activate` in `MenuButton::ExecuteMenu (s. frame 14/15
        in below backtrace) would already set focus to the "Automatic" button
        in the color window:
        
                1  PushButton::GetFocus   button.cxx 1490 0x7f4acfdc83b6
                2  vcl::Window::CompatGetFocus    window.cxx 3888 0x7f4acfd9d26d
                3  vcl::Window::ImplGrabFocus mouse.cxx  384  0x7f4acfcd5215
                4  vcl::Window::GrabFocus window.cxx 2979 0x7f4acfd988e9
                5  SalInstanceWidget::grab_focus  salvtables.cxx 390  0x7f4ad046f505
                6  ColorWindow::GrabFocus tbcontrl.cxx   2127 0x7f4ad3f21af1
                7  ColorListBox::ToggleHdl    tbcontrl.cxx   4291 0x7f4ad3f313d6
                8  ColorListBox::LinkStubToggleHdl    tbcontrl.cxx   4285 0x7f4ad3f31369
                9  Link<weld::Toggleable&, void>::Call    link.hxx   111  0x7f4ad04aec71
                10 weld::Toggleable::signal_toggled   weld.hxx   1539 0x7f4ad04a77a3
                11 SalInstanceMenuButton::ActivateHdl salvtables.cxx 3075 0x7f4ad0483086
                12 SalInstanceMenuButton::LinkStubActivateHdl salvtables.cxx 3071 0x7f4ad0483043
                13 Link<MenuButton *, void>::Call link.hxx   111  0x7f4acfe9e9c1
                14 MenuButton::Activate   menubtn.cxx    237  0x7f4acfe9e136
                15 MenuButton::ExecuteMenu    menubtn.cxx    61   0x7f4acfe9cca1
                16 MenuButton::KeyInput   menubtn.cxx    226  0x7f4acfe9e092
                17 ImplHandleKey  winproc.cxx    1211 0x7f4acfdb0962
                18 ImplWindowFrameProc    winproc.cxx    2724 0x7f4acfdb6fcf
                19 SalFrame::CallCallback salframe.hxx   310  0x7f4ac5aa3dfa
                20 QtFrame::CallCallback  QtFrame.hxx    229  0x7f4ac5aa5336
                ... <More>
        
        As a consequence, this "Automatic" button inside of the color window
        would be the UI element remembered as the the one to which focus
        focus should be restored when closing the popup, see the
        
            mxPrevFocusWin = Window::SaveFocus();
        
        in `FloatingWindow::StartPopupMode`, which gets called like this:
        
            1   FloatingWindow::StartPopupMode           floatwin.cxx         824  0x7f4acfc61a61
            2   ImplDockingWindowWrapper::StartPopupMode dockmgr.cxx          846  0x7f4acfc43bd3
            3   DockingManager::StartPopupMode           dockmgr.cxx          341  0x7f4acfc412c3
            4   MenuButton::ExecuteMenu                  menubtn.cxx          94   0x7f4acfe9cfa9
            5   MenuButton::KeyInput                     menubtn.cxx          226  0x7f4acfe9e092
            6   ImplHandleKey                            winproc.cxx          1211 0x7f4acfdb0962
            7   ImplWindowFrameProc                      winproc.cxx          2724 0x7f4acfdb6fcf
            8   SalFrame::CallCallback                   salframe.hxx         310  0x7f4ac5aa3dfa
            9   QtFrame::CallCallback                    QtFrame.hxx          229  0x7f4ac5aa5336
            10  QtWidget::handleKeyEvent                 QtWidget.cxx         671  0x7f4ac5af9f38
            11  QtWidget::handleEvent                    QtWidget.cxx         707  0x7f4ac5afa094
            12  QtWidget::event                          QtWidget.cxx         730  0x7f4ac5afa1f7
            13  QApplicationPrivate::notify_helper       qapplication.cpp     3287 0x7f4ac37a2414
            14  QApplication::notify                     qapplication.cpp     2715 0x7f4ac379fd5b
            15  QCoreApplication::notifyInternal2        qcoreapplication.cpp 1123 0x7f4ac51a3c34
            16  QCoreApplication::forwardEvent           qcoreapplication.cpp 1138 0x7f4ac51a3cac
            17  QWidgetWindow::handleKeyEvent            qwidgetwindow.cpp    669  0x7f4ac38567b1
            18  QWidgetWindow::event                     qwidgetwindow.cpp    234  0x7f4ac3854924
            19  QApplicationPrivate::notify_helper       qapplication.cpp     3287 0x7f4ac37a2414
            20  QApplication::notify                     qapplication.cpp     3238 0x7f4ac37a2224
            ... <More>
        
        and then properly restoring focus fails in
        `FloatingWindow::EndPopupMode`.
        
        Move the call to `Activate` to after showing the
        popup instead. This makes sure that the actual
        widget that had focus *before* the popup opened
        is remembered and focus is correctly restored
        on close.
        
        The handler for the toggled signal had been added in
        
            commit e55a1dc163165cb79fc9113101d16ee8d3db7298
            Date:   Wed Nov 27 14:58:00 2019 +0000
        
                don't put focus into unmapped windows
        
                defer until the color selectors are activated to grab focus, otherwise
                esc doesn't work to close a dialog under gtk3 until focus is put
                into some visible widget
        
        which apparently already moved the focus request to later than it was
        before.
        
        With this change in place, the NVDA screen reader announces the
        menu button again once the color popup closes (tdf#141101) and it also
        makes opening the popup menu again right away work
        by pressing Alt+Down button again on Windows or with the
        gen or qt6 VCL plugins on Linux, which didn't work beforehand,
        but required either using the mouse or tabbing to another UI
        element and back before that keyboard shortcut would work again.
        
        The same is true for the border line style popup (tdf#101886).
        
        Setting the focus only when the popup shows also
        makes the focus correctly be on the previously
        selected color for the non-gtk3 case when opening
        the popup again. (Previously, the "Automatic" button
        would always have focus.)
        
        Ensure that the required preparations for showing the
        popup in the `ManagedMenuButton` subclass are still
        done before executing the menu by doing what's
        needed in the newly named `ManagedMenuButton::PrepareExecute`
        method rather than in `Activate` and call that
        one before showing the menu.
        
        Change-Id: I82fbfea2ae8b9064979796da279750350deb742d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155891
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-22  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [cb141564733eef078347b89ea657e46e193bd140]

        tdf#103480 sc: fix lost hyperlink at merging an empty cell with its cell
        
        Merging a cell containing a hyperlink with an empty cell
        resulted the loss of the hyperlink, i.e. only the text
        content was kept.
        
        Change-Id: I5148ce55157e3ad7926f5b5a82a682b837a784ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154520
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-08-22  Khaled Hosny  <khaled@libreoffice.org>  [bc3f6c3a47411a3b5dafadca4e5c55cd24e30662]

        tdf#155610: Workaround Acrobat bug with Type 3 fonts and unusual UPEM
        
        Adobe Acrobat seems to have a bug with Type 3 fonts with unusual UPEM,
        the common 1000 and 2048 UPEM work fine, but Sitka has 2250 UPEM and
        Acrobat handles the advance widths in this case incorrectly and
        everything gets cramped up with gaps when we re-start glyph positioning.
        
        Workaround this by always using 0.001 scale in FontMatrix (equivalent to
        1000 UPEM) and scale everything if the font’s UPEM is different.
        
        Change-Id: I80d25a16456f04bb00304b22b967688fa8260a83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155935
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-22  Michael Stahl  <michael.stahl@allotropia.de>  [027f8328eef1e149b6c99b478ed5df870291dc2d]

        tdf#137523 sw: layout: fix text below tables in footer
        
        In the footer, the text frames below a table have a very small height
        and are effectively invisible.
        
        This is because the JoinLock in SwLayAction::FormatLayoutTab() causes
        SwTabFrame::MakeAll() to return early, which is called for every cell
        frame in the table, and which would move the table up the page in
        MakePos(), by calling SwHeadFootFrame::Format().
        
        (regression from commit cc5916cd314a27b0cc99560ab887480026630a95)
        
        Change-Id: I4add9fdd73ad3756000969af20ebf758025a0ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155902
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-22  Khaled Hosny  <khaled@libreoffice.org>  [77dab2ac3a4dfdc6f51fdfc31078fb828e8164fa]

        vcl: Fix dumping meta file layout flags to XML
        
        These are bit flags, so we were always writing #0000, so now it does
        bitwise check for the flags and while at it write the names of the flags
        not the numeric values.
        
        Change-Id: I13cae38c0e549b2da1f834a264e3a3255bfa5c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155793
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-22  Caolán McNamara  <caolan.mcnamara@collabora.com>  [83f2a294fde74e968a564fe69cce0e85c86b3543]

        Related: ofz#57493 Timeout
        
        restore this now that ofz has closed ofz#57493 and has reset
        
        Change-Id: Ibf5545d1f499e1c986a8242eb501ac870a7a6d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-22  Khaled Hosny  <khaled@libreoffice.org>  [3e20c3e73cbd10e8323f0997e3a6536abd11e2bd]

        tdf#156853: Fix PDF export of bitmap color fonts
        
        Move the alpha inversion down to createBitmapEmit() so that it gets
        applied to any bitmap embedded in the PDF, especially since embedded
        color bitmap glyphs don't go through the higher level code path.
        
        Regression from:
        
        commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
        Date:   Fri Apr 16 20:33:10 2021 +0200
        
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I68601a7a0d9ac01f5e8054f074f8e18fcbdea1be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155930
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [b2f7fa71af28c2095d42396306cf7818e9e73175]

        tdf#146619 Remove unused includes from sal/qa
        
        also drop now-unused osl_Condition_Const.h
        
        Change-Id: I40beb5b1ad49c126a126bb444d5f66703664d56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155820
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-22  Miklos Vajna  <vmiklos@collabora.com>  [a490cbfd9a5c9e69979b412d78dbe08bc307541f]

        sw: document SwFormatLayoutSplit
        
        Here layout means a table, given that rows have a dedicated
        SwFormatRowSplit.
        
        Change-Id: I02255e2b787923ad56a9bfc8b7e7e8b02d8551cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155903
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5534c0ab539d4784a76d29f73d2df0d13ac67d20]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f788f5e73fee691917bb3a2d671b013a5bce071
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(13)
            
            + refactoring
            + Writer Format menu (part 13)
            
            Change-Id: I1137ac139b48bcd0d9ce53fc0071ca565d41f274
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155908
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2ffed6f2d4936091285190d9d8b7f1141444f12e]

        split to allow getting decoration on its own
        
        Change-Id: Ib65750245906de0852c39e4a4bdaa85a2f822282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [8fa209ce2e800dc8a51e941cd42a65fa8b2eb14b]

        tdf#156834: Add basic support for dominant-baseline attribute
        
        Change-Id: I005d6ca6bc340d73cae639ccd09321a0a00bc4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155892
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-21  Michael Stahl  <michael.stahl@allotropia.de>  [e6a5ccbe578898878468180c2d4c9ee9e6afbad9]

        flat-odf-cleanup.py: remove unused table styles and page layouts
        
        Change-Id: I8af888c2f2d5f8f2a73a1b6240d1ea607ab1f91f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155901
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-21  Jean-Pierre Ledure  <jp@ledure.be>  [84bc3ffcf5c570f044843125552589456b07f5a1]

        ScriptForge - fix tdf#156836 Abort on MoveFirst()
        
        The incident occurs when a move (last(),
        first(), next()) within the form's resultset
        is done from a Basic script immediately
        after the opening of the document
        containing the form.
        
        The insertion of a
            Wait 1
        statement prevents the occurrence of
        the incident by interrupting very shortly
        the Basic process.
        
        Change-Id: I5e798db6e3f9ffaeeef38fb9badd008cbb190d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155897
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [19281c62b5e315da422318dbc9d4ba619a6eeab5]

        character preview is drawing two overlines for Small Caps
        
        we already handle the underline and strikethrough case, so add
        the overline case here too
        
        Change-Id: I9ca0a5623a559e0cde07437439aa372e3c517159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [56a360328790eb009efed6fce94a795f6fe0a7d2]

        tdf#156837: check baseline-shift from parent too
        
        Change-Id: I6e62d794dd4410447db3bee26c1e18fe9dad6a9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155895
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-21  Mike Kaganski  <mike.kaganski@collabora.com>  [0a17e45e3fed13c240629fdf0dbb00b8908f5acc]

        Drop a leftover
        
        ... from commit a3acf41195f4c39cba7950c389dc817b824f76ed (CWS-TOOLING:
        integrate CWS chart37, 2009-06-04)
        
        Change-Id: I32b3813ff0d76fc1dffd98080ce894781f3028cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155893
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-21  Hossein  <hossein@libreoffice.org>  [40ed8dd3a5a16f21f2e98440c62efa0fa6ec60ff]

        tdf#155470 DOCX export: fix RTL numbers changed to LTR
        
        When using numerals in "context" mode in "Tools > Options", in
        "Language Settings > Complext Text Layout > General Options > Numerals",
        the actual display of the numbers is dependant on the direction and
        the language of those numbers.
        
        Previously, when exporting the DOCX in LO the RTL direction was lost,
        and because of that, the numerals were shown incorrectly after saving
        in LibreOffice, and loading again.
        
        This patch adds <w:rtl/> where <w:lang> contains an RTL language.
        For example, before <w:lang w:bidi="fa-IR"/> inside <w:rPr>, it always
        adds <w:rtl/>.
        
        It is worth noting that this is not always the case, as there are
        situations that <w:rtl/> is not present in <w:rPr> with an RTL language
        like <w:lang w:bidi="fa-IR"/> and <w:rtl/> should not be in the output.
        This patch does not handle that case, because currently loading such a
        text is not done correctly in LO, and the LTR numbers inside RTL
        environment are shown just like RTL numbers. To fix it, first loading
        and displaying of that should be fixed.
        
        A test is added to check the export of the sample file, which can be
        invoked with:
        
         make CppunitTest_sw_ooxmlexport CPPUNIT_TEST_NAME=testTdf155470
        
        Change-Id: I8fc54916fcd3295010c5c81ccb632bc6082ffaa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155721
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-08-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8ec43f37a7a5babe9227a5ca1ea84720fc2e15e5]

        spellchecking wave doesn't extend to the full width of superscript text
        
        or subscript, e.g. enter tmalltmalltmalltmalltmalltmalltmall in
        impress, format character, position, superscript, ok and without this
        change the wave extends only 80% of the width of the misspelt text
        
        Change-Id: I5d3ad61541152199809c950349533ca3fa7ed1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab38a8d13de0b14b3c389ef27152aac958033401]

        tdf#156721 Crash if cursor in Basic IDE is in a macro from a document..
        
        .. and that document is closed
        
        regression from
            commit f3e127217d8daa443b8eda52ac4810e375cc7d63
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue May 9 15:21:20 2023 +0200
        use comphelper::WeakComponentImplHelper in
        DocumentEventNotifier::Impl
        
        Change-Id: I5c8e68cd222ee1d66dc832700c4a39fd74223643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155889
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e22a901ac887bd015b3384cebf3f9a128362c60]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2dd56744064e9442dee1c1d9a205c19fa1b9bc2b
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(12)
            
            + refactoring
            + Writer Format menu (part 12)
            
            Change-Id: Ifb2f4c57ee8c07a738efbfdb2ff2b2b21b9c3f22
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155880
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [37334c5a36a4f3ab1acaf3f8c85b87f4942548e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b9ff9295e55037f835b749a6daedfa08aa2d731f
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(11)
            
            + refactoring
            + Writer Format menu (part 11)
            
            Change-Id: I61634acae0b8074ea4ba726ff120ee9515103db5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155870
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d0f3f62414ce8c49b1a9ad83e2f7bd57d6fb7f63]

        Fix typo
        
        Change-Id: Ieb6e4ccf543b4d015b83cea4614983d5fcaea8cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155886
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [68becc464fc585bd9716c1566c04a7e9d62647f6]

        Fix typo
        
        Change-Id: I9ebbbaa470ada2559f206ef84d825a383b7adb02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155888
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-21  Miklos Vajna  <vmiklos@collabora.com>  [5bf9c2a5da15e1b91b42aca679288d8a37d47984]

        svx: prefix members of SdrEdgeObj
        
        See tdf#94879 for motivation.
        
        Change-Id: I5236f1d6d2294172640ec671424fbcd78a866d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155883
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-21  Noel Grandin  <noelgrandin@gmail.com>  [ab56dbc2eea1b8617068f424dfa71bfe7b75b1eb]

        remove pimpl in WPXSvInputStream
        
        no need for pimpl in class only included by a small number
        of other files
        
        Change-Id: Ib1df25388d90da2aa8158d070a45a769bd608bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155871
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-21  anfanite396  <dipamt1729@gmail.com>  [63464fdf552ce82ec29631f0736edd43c0ba4146]

        Move SwXTextFieldTypes Java tests to C++
        
        Change-Id: I77ca9bc6cd0db626df826e2084514d34becf39bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154208
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-21  anfanite396  <dipamt1729@gmail.com>  [d71d61326f4ed87151bb4cee1185561f3ae49204]

        tdf#45904: Remove old SwXBookmarks Java test
        
        Change-Id: Ie8d66b74192d1741922a7728934317859821fa00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155745
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-21  Miklos Vajna  <vmiklos@collabora.com>  [08aea5526c75ff4c5385e960bd940f10ffa19cd5]

        tdf#156351 sw floattable: fix missing bottom border in master table
        
        The problem was that the bugdoc has a split floating table, and the
        bottom of the table on the first page was missing its border. The
        borders on the second page were correct.
        
        This happens because the cell itself has no bottom border and the layout
        did not extra effort to mirror the top table margin at the buttom, like
        Word does.
        
        Fix the problem similar to commit
        53798fef2cc0b5b0b9706081a4af5ceca964a41b (Related: tdf#156351 sw
        floattable: fix missing top border in follow table, 2023-08-18), so we
        add a bottom border for master tables at a layout level, similar how a
        top border was already added for follow tables.
        
        Given that this kind of worked already in the past (just top borders,
        just the 1 row case), do this unconditionally; but if needed this could
        be limited to the "Word table cell" case.
        
        Change-Id: Iafdcd90226fdc425be597d36ad97fb69dca5a89a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155884
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [242bb3fdda5be165bd00701518df47cc1276438f]

        move BGradient to awt::Gradient2 UNO conversion into docmodel
        
        This is needed because the module dependencies are an issues if
        the conversion is done in basegfx. The bigger issue will come when
        the ComplexColor conversion will be done as basegfx can't depend on
        docmodel because of circular dependencies.
        
        The BGradient is also more suitable for docmodel anyway as the
        previously it was part of the model and is not a basic (gfx)
        type - however this doesn't move the whole BGradient into docmodel
        yet.
        
        Change-Id: Id91ce52232f89f00e09b451c13da36e2854ae14b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155674
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-21  Noel Grandin  <noelgrandin@gmail.com>  [84b12cd3ea96ee9b02365b5239f391af242f7303]

        remove pimpl in ButtonSet
        
        Change-Id: I117b3b0002fb6151cc03245dcd3f892d6e211f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [73ec9c71689525ff14db219238083ff75028f8c8]

        Tests with color stops to assert Color and not BColor values
        
        For testing color stops of a gradient we don't need to assert super
        precise values (doubls to the n-th decimal point) as long the end
        results in the same (8-bit) Color value. So change the tests to
        convert the BColor that is in gradient color stops to Color and
        assert the Color value.
        
        Change-Id: Ibd7661e2f72955a0778e822df1fae568973be357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155360
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e60ef8651cfb30335471d1622e58c13eebc7d58b]

        ofz: Use-of-uninitialized-value
        
        same as seen at: https://gitlab.com/libtiff/libtiff/-/issues/582
        
        Change-Id: Ifc4eaaa47ad392968db814783281f1db76564d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155874
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db8edaf6cbe4fc28e40b832ecc18251f55a6993b]

        ofz#61511 Direct-leak
        
        Change-Id: Id1510fb8271a67cc924e2751d5081f54da209ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-20  Jean-Pierre Ledure  <jp@ledure.be>  [0bbe5b4f2a7797bfd05fdbde316857fceaf84d77]

        ScriptForge - Refactor Python <=> Basic protocol
        
        Incremental changes had made the code in
           SF_PythonHelper.xba
           scriptforge.py
        (which manage the protocol between the Python
        user scripts and the ScriptForge services
        implemented in Basic) less readable and efficient.
        
        Next features have been reviewed:
        - dict instances may be passed as arguments
          and returned. Conversions are done on-th-fly.
        - dates may be passed as arguments
          and returned. Conversions are done on-th-fly.
          The lists of hardcoded methods have been removed.
        - 2D arrays in standard modules may be passed
          as arguments and returned. Conversions are done
          on-th-fly. The lists of hardcoded methods have
          been removed.
        - The hardcoded list of methods requiring a post-
          processing has been reduced.
        - Methods in standard modules, when not returning
          an array, are also executed with CallByName().
        - The unused 'localProperties' attribute in Python
          services has been removed.
        - Flags about arrays in standard modules have been
          adapted in
           filesystem.Files()
           filesystem.SubFolders()
           session.UnoMethods()
           session.UnoProperties()
           string.SplitNotQuoted()
           string.Wrap()
           ui.Documents()
        - The platform.UserData property became a usual
          property.
        
        Dictionaries are admitted as arguments and return
        values. As a consquence next functions are supported
        in Python as well:
           session.GetPDFExportOpetions()
           session.SetPDFExportOptions()
           document, calc, writer.CustomProperties
           document, calc, writer.DocumentProperties
        These changes require an update of the help pages.
        
        Non-regression tests were run with success. All changes
        are transparent for existing scripts.
        
        Change-Id: Iae7a1f5090c590209cd3cb2314c919c44736eba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155860
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-08-20  Jim Raykowski  <raykowj@gmail.com>  [6c149bffd798d401db0945f6f3ee8ab777020298]

        SwNavigator: Save some cycles by using break instead of continue
        
        When a content change is detected the Display function will clear and
        recreate the content tree from the content type member arrays,
        therefore, when a content change is detected there is no need to
        continue the loop here to set tree entry user data, which may have
        been the reason for using continue.
        
        Change-Id: Id1bc6fe6dddac54aa7299d3921c9352dc2314f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155730
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-20  Justin Luth  <jluth@mail.com>  [91358f11ee7e87c8c8290b9507f64d8f90aac3ea]

        tdf#148834 docxexport: also write suppressLineNumbers = false
        
        This code also affects DOC export,
        but shouldn't be detrimental.
        It just means that some unnecessary sprms
        will not be added to DOC files.
        
        RTF - similar to old DOCX - only outputs if !IsCount,
        but I didn't find a corresponding "enable" to offset \noline.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf148834_lineNumbering
        
        Change-Id: Ib5369c2f2c24f75dab7d02e3591a4ddefa335ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155858
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [81c19355d7ad830c2356d7d82e244929be3823a8]

        crashtesting: parallel calc assert with Lookup
        
        seen in forum-mso-en4-55192.xlsx with a singlecell as the result vector
        which gets autoextended outside the range that the pre-parallel calc
        took into consideration on set up. For simplicity if there is a result
        vector assume that if it doesn't match the size of the search vector
        that we can't parallelize this.
        
        Change-Id: Ic67e1b5b35964760ac5b1608cd516a69e08d0540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-19  Patrick Luby  <plubius@neooffice.org>  [f9d5887697405e600cb85cd49b0ce1d8e63cdc27]

        Eliminate special alpha mask inversions when Skia is disabled
        
        Commit ad1f69d28d31725a22e7e1cbb4d950aa9ad3bea7 fixed an alpha
        blending bug in AlphaMask::BlendWith(const AlphaMask&) so almost
        all of the special alpha mask inversions when drawing transparent
        meta actions are no longer needed and so, when Skia is disabled,
        the same inversions as Skia are now used.
        
        The one special alpha mask inversion that is still needed when Skia
        is disabled is when exporting to PDF documents like the following
        with transparent gradients:
        
          https://bugs.documentfoundation.org/attachment.cgi?id=188084
        
        Change-Id: I3212a38916be3d238bb9c868b161031616baf0a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155859
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f9b2999b36a171f7708d51a025dabab33bc54733]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f46135d08a1174b15985b2e46e82a23733b8087
          - LibreOffice 7.6 video
            
            Change-Id: Ie4853969bbdf9eafad05d4c925aeab63bdd99419
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155861
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ffa7e56c0202227f2ec75fce5234bb2bf89e455]

        loplugin: new global analysis locking2
        
        look for methods where we don't need to guard access
        to the field, because the field is never modified
        
        Change-Id: I62c33cc3f52881557515765d3733c4afc78547aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-19  Patrick Luby  <plubius@neooffice.org>  [5baac4e53128d3c0fc73b9918dc9a9c2777ace08]

        Reimplement fix for tdf#156629 and tdf#156630
        
        Reimplement fix in commit 926c5246b6694d469a6caed5d7ea4c3a68648468
        in an attempt to reduce the fix's performance hit. Instead of
        invoking EnsureBitmapData() and converting the SkImage to a
        memory buffer, any pending scaling on alpha masks is handled by
        creating a new, scaled SkImage.
        
        Note that in commit 926c5246b6694d469a6caed5d7ea4c3a68648468,
        EnsureBitmapData() was invoked which converted the SkImage to a
        memory buffer. That in turn would make Invert() a noop which
        fixed the related bug where an image has been opened and, before
        it has been printed or run in a slideshow, the alpha mask would
        unexpectedly be inverted. So keep this immutable behavior without
        calling EnsureBitmapData() by adding a new mutability flag.
        
        Change-Id: I99dc272b40c53664ea49333402a6a637b1548a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155850
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [56ca109d841b02e1646d7c92b8d0acd74c2683c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e7394856b4a21493b7da5e29db35f3227c3e0fb9
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(10)
            
            + refactoring
            + Writer Format menu (part 10)
            
            Change-Id: I0adcec8732aa9c22b4c9e7c2140531a4a3a3a5bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155852
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1d46f502498290d33dbea63df9f16b90891ec3b6]

        Fix typo
        
        Change-Id: I6649e13646e4fd33dd1858f5a5a56ec0955005dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155841
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [34d32740d89876c3d4fd2743a07d6e2578601683]

        on invalidating other views, specific what Tab is invalidated
        
        the other views might be viewing other tabs and it is only
        the tab ('part') this view is on which is invalidated
        
        Change-Id: I9f054ffa6158a6bc62e3eb7b7170450e26870b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a35311beef378c15ecbb3bb0560035c17f4657ca]

        for LibreOfficeKit::isActive we can skip to LogicInvalidate
        
        it should be the same effect
        
        Change-Id: I2faa0b728fdebe837855e1f23e066ae8b1a2bde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155815
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1d361ad42a687bd6730d251d060ce867cc0b882b]

        Related: tdf#151059 assign Alt+7 to new manage changes deck
        
        and move a11y one to 8 to match visual order
        
        Change-Id: Ifb4e08f6214da1cdd75bd3b5aa43ac9143e70376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [912374164f16a4157f04c74994e15f8658b37f03]

        svx: Use FRAMEBORDERTYPE_COUNT instead of magic number
        
        ... just as is used for `maAllBorders` below.
        
        Change-Id: I0741a039cc0ee9ad01055414f471dab45f420ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155849
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [79cc574270582d03408286544d99227881f13bb8]

        related tdf#156683 a11y: Dispose FrameSelectorImpl a11y children
        
        Don't just invalidate, but also dispose the a11y children
        in `FrameSelectorImpl::~FrameSelectorImpl`.
        
        This fixes a crash on exit that's reproducible with
        the gtk3 VCL plugin e.g. like this (maybe some
        steps aren't even needed):
        
        1) start LO Writer with the gtk3 VCL plugin
        2) right-click, select "Character" > "Character"
           in context menu
        3) switch to "Font Effects" tab
        4) press space key with focus in the font color combobox
           to open the popup
        5) use Tab key to get to the view of colors
        6) move around with arrow keys a bit
        7) close the dialog and Writer
        
        Reverse-continuing to `atk_object_wrapper_dispose`
        (frame #10 in the below backtrace) in rr
        showed the involved a11y object:
        
            uno::Reference to (svx::a11y::AccFrameSelectorChild *) 0x5557832b9150
        
        Backtrace (somewhat similar to the one in tdf#156683):
        
            #0  0x00007ffff6b15cd6 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear(std::unique_lock<std::mutex>&, com::sun::star::lang::EventObject const&)
                (this=0x7fffffffca88, rGuard=..., rEvt=...) at .../include/comphelper/interfacecontainer4.hxx:397
            #1  0x00007ffff6b13c6f in comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
                (_nClient=1058, _rxEventSource=uno::Reference to (svx::a11y::AccFrameSelectorChild *) 0x55555cecfdf0) at .../comphelper/source/misc/accessibleeventnotifier.cxx:204
            #2  0x00007ffff6b1028a in comphelper::OCommonAccessibleComponent::disposing() (this=0x55555cecfdf0) at .../comphelper/source/misc/accessiblecomponenthelper.cxx:61
            #3  0x00007ffff6674aeb in cppu::WeakComponentImplHelperBase::dispose() (this=0x55555cecfdf0) at .../cppuhelper/source/implbase.cxx:104
            #4  0x00007ffff2ddf0e0 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::dispose() (this=0x55555cecfdf0)
                at .../include/cppuhelper/compbase.hxx:90
            #5  0x00007ffff6674834 in cppu::WeakComponentImplHelperBase::release() (this=0x55555cecfdf0) at .../cppuhelper/source/implbase.cxx:79
            #6  0x00007ffff2ddf642 in cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleContext2, com::sun::star::accessibility::XAccessibleEventBroadcaster>::release() (this=0x55555cecfdf0)
                at .../include/cppuhelper/compbase.hxx:86
            #7  0x00007ffff2ddf378 in cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent, com::sun::star::accessibility::XAccessibleComponent>::release() (this=0x55555cecfdf0)
                at .../include/cppuhelper/implbase.hxx:171
            #8  0x00007ffff2ddf0a0 in cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper, com::sun::star::accessibility::XAccessible>::release() (this=0x55555cecfdf0)
                at .../include/cppuhelper/implbase.hxx:171
            #9  0x00007fffe3f29535 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::clear() (this=0x55555d40a010) at .../include/com/sun/star/uno/Reference.hxx:231
            #10 0x00007fffe3f288de in atk_object_wrapper_dispose(AtkObjectWrapper*) (wrapper=0x55555d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:1078
            #11 0x00007fffe3f27527 in atk_object_wrapper_finalize(GObject*) (obj=0x55555d409fa0) at .../vcl/unx/gtk3/a11y/atkwrapper.cxx:674
            #12 0x00007ffff138c48c in g_object_unref () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
            #13 0x00007fffe3f003f7 in AtkListener::~AtkListener() (this=0x55555ce6ecb0, __in_chrg=<optimized out>) at .../vcl/unx/gtk3/a11y/atklistener.cxx:57
            #14 0x00007fffe3f0042e in AtkListener::~AtkListener() (this=0x55555ce6ecb0, __in_chrg=<optimized out>) at .../vcl/unx/gtk3/a11y/atklistener.cxx:58
            #15 0x00007ffff6756838 in cppu::OWeakObject::release() (this=0x55555ce6ecb0) at .../cppuhelper/source/weak.cxx:230
            #16 0x00007fffe3f0a7de in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x55555ce6ecb0) at .../include/cppuhelper/implbase.hxx:115
            #17 0x00007ffff6b21b99 in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference() (this=0x55555d40a0c0, __in_chrg=<optimized out>)
                at .../include/com/sun/star/uno/Reference.hxx:114
            #18 0x00007ffff6b217a9 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*)
                (__pointer=0x55555d40a0c0) at /usr/include/c++/13/bits/stl_construct.h:151
            #19 0x00007ffff6b20bcf in std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55555d40a0c0, __last=0x55555d40a0c8) at /usr/include/c++/13/bits/stl_construct.h:163
            #20 0x00007ffff6b1f105 in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*>(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*) (__first=0x55555d40a0c0, __last=0x55555d40a0c8) at /usr/include/c++/13/bits/stl_construct.h:196
            #21 0x00007ffff6b197aa in std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>*, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >&) (__last=0x55555d40a0c8, __first=0x55555d40a0c0) at /usr/include/c++/13/bits/alloc_traits.h:947
            #22 std::__cxx1998::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector()
                (this=0x55555cf22af8, __in_chrg=<optimized out>) at /usr/include/c++/13/bits/stl_vector.h:732
            #23 0x00007ffff6b17402 in std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >::~vector() (this=0x55555cf22ae0, __in_chrg=<optimized out>) at /usr/include/c++/13/debug/vector:230
            #24 0x00007ffff6b1742a in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::impl_t::~impl_t() (this=0x55555cf22ae0, __in_chrg=<optimized out>) at .../include/o3tl/cow_wrapper.hxx:176
            #25 0x00007ffff6b17485 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::release() (this=0x55555d40a0b0) at .../include/o3tl/cow_wrapper.hxx:207
            #26 0x00007ffff6b15700 in o3tl::cow_wrapper<std::__debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >, o3tl::ThreadSafeRefCountingPolicy>::~cow_wrapper() (this=0x55555d40a0b0, __in_chrg=<optimized out>) at .../include/o3tl/cow_wrapper.hxx:271
            #27 0x00007ffff6b145b4 in comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::~OInterfaceContainerHelper4() (this=0x55555d40a0b0, __in_chrg=<optimized out>)
                at .../include/comphelper/interfacecontainer4.hxx:126
            #28 0x00007ffff6b206c6 in std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >::~pair() (this=0x55555d40a0a8, __in_chrg=<optimized out>)
                at /usr/include/c++/13/bits/stl_pair.h:187
            #29 0x00007ffff6b1aac4 in std::__new_allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >::destroy<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__p=0x55555d40a0a8, this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>) at /usr/include/c++/13/bits/new_allocator.h:194
            #30 std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::destroy<std::pair<unsigned i--Type <RET> for more, q to quit, c to continue without paging--
            nt const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >(std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> >&, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >*) (__p=0x55555d40a0a8, __a=...)
                at /usr/include/c++/13/bits/alloc_traits.h:557
            #31 std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*)
                (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>, __n=0x55555d40a0a0) at /usr/include/c++/13/bits/hashtable_policy.h:2020
            #32 0x00007ffff6b188b7 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, false>*)
                (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>, __n=0x55555d409ef0) at /usr/include/c++/13/bits/hashtable_policy.h:2042
            #33 0x00007ffff6b164e6 in std::_Hashtable<unsigned int, std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> >, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > >, std::__detail::_Select1st, std::equal_to<unsigned int>, std::hash<unsigned int>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::clear() (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>) at /usr/include/c++/13/bits/hashtable.h:2509
            #34 0x00007ffff6b187cc in std::__cxx1998::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7ffff6f64988 <(anonymous namespace)::gaClients+40>)
                at /usr/include/c++/13/bits/unordered_map.h:798
            #35 0x00007ffff6b164a0 in std::__debug::unordered_map<unsigned int, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>, std::hash<unsigned int>, std::equal_to<unsigned int>, std::allocator<std::pair<unsigned int const, comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> > > >::clear() (this=0x7ffff6f64960 <(anonymous namespace)::gaClients>)
                at /usr/include/c++/13/debug/unordered_map:234
            #36 0x00007ffff6b14151 in comphelper::AccessibleEventNotifier::shutdown() () at .../comphelper/source/misc/accessibleeventnotifier.cxx:268
            #37 0x00007fffee53fa20 in DeInitVCL() () at .../vcl/source/app/svmain.cxx:594
            #38 0x00007fffee53e227 in ImplSVMain() () at .../vcl/source/app/svmain.cxx:229
            #39 0x00007fffee53e283 in SVMain() () at .../vcl/source/app/svmain.cxx:236
            #40 0x00007ffff7a9f51d in soffice_main() () at .../desktop/source/app/sofficemain.cxx:94
            #41 0x00005555555549d4 in sal_main () at .../desktop/source/app/main.c:51
            #42 0x00005555555549ba in main (argc=2, argv=0x7fffffffd8e8) at .../desktop/source/app/main.c:49
        
        Change-Id: I22c665f3c41624f4916b956ea266ff1d39fbe507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155848
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0367a168cd01f4a2c16101726714f696ba023a6f]

        tdf#151134 Always write inset properties when exporting placeholder shapes
        
        The default value works for text boxes, but not for these special
        presentation placeholder objects - here the values need to be written
        explicitly.
        
        Change-Id: Id606bd5e6b63dee2fd3b385435ce13ecec63b5f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155838
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [f09e2e1d92a7d7f99b05c739952eed876f741f75]

        configure.ac: Update Java check for JDK >= 9 version string
        
        Since Java 9, the major version number is the actual one,
        while up to including Java 8, that wasn't the case
        (Java 8 would use a version string of 1.8.x).
        
        Update the version check accordingly, which was still
        assuming the old versioning scheme, i.e. would pass
        for any Java version >= 1.9.0.
        (This shouldn't make any difference in practice yet,
        but will once the minimium version is increased.)
        
        Change-Id: I79eeb247315499caddd63d6abbb1e14ea6a72a4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155826
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [94c94633a4e6f1622c7cc31ce6efd41862691d59]

        Drop JAVA_CLASSPATH_NOT_SET which is always TRUE
        
        The variable was introduced in
        
            commit b97cade9183d14ad21ae71892348a9a81689488b
            Date:   Sun Apr 7 12:14:36 2013 -0400
        
                Supress warnings about unset classpath
        
                I get the below warning for every single jar file without this patch.
                warning: [options] bootstrap class path not set in conjunction with
                -source 1.5
                1 warning
        
                Change-Id: I71c01aeea993640f1ec86fe1d8a977656861358d
        
        , at a time when Java 5 was the minimum version,
        likely to suppress warnings with JDK versions >= 6
        (greater than 1.6.0 to be exact...).
        The version check was then just bumped along with the Java
        baseline bumps in
        
            commit aafc10c9edb61e13ac557c7e43c8d4a31dce4f37
            Date:   Fri Jul 26 10:19:39 2019 +0200
        
                Bump Java baseline to Java 8
        
        and
        
            commit 941b567a41569260fef14a7337511e8f42337323
            Date:   Thu May 7 09:42:22 2020 +0200
        
                tdf#131572 Add java 9 module info for libreoffice.jar
        
        for no apparent reason.
        
        In any case, the variable will always be set to TRUE,
        since the Java version string is using the actual
        major version number as the first digit since
        JDK 9 (while JDK 8 would still use 1.8.x as version
        string), s.a. upcoming commit
        Change-Id I79eeb247315499caddd63d6abbb1e14ea6a72a4a
        ("configure.ac: Update Java check for JDK >= 9 version string").
        
        Drop the variable and set the Java params
        in `solenv/gbuild/JavaClassSet.mk` unconditionally.
        
        Change-Id: Ib4aad07da3937289fc6ff29dd80abdd4c35f1773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155825
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [0008ff3597e9d89481d5fccb5cefa7f058400a43]

        tdf#141101 a11y: Ensure focused event after showing popup content
        
        If the `FloatWinPopupFlags::GrabFocus` flag is set,
        don't only pass it to `FloatingWindow::StartPopupMode`,
        but explicitly grab focus again after showing the
        docking window (client window of the floating window).
        
        At least proper handling for accessible focus/focused
        events depends on the window being visible at the point
        it receives focus.
        
        For winaccessibility, the a11y event listener only
        gets registered once the window gets shown
        (`VCLXAccessibleComponent::ProcessWindowChildEvent`
        forwards a `VclEventId::WindowShow` as
        `accessibility::AccessibleEventId::CHILD` event, which
        winaccessibility then processes and registers an
        event listener for the new child).
        
        This makes NVDA on Windows announce focus for the
        "Automatic" button in the color popup in Writer's
        character style dialog also when the popup shows
        for the first time.
        
        Change-Id: I2e4028eb4ec68a8b586cbd1a0dc5351d1453937e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155843
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5296b0ffe3ce031cab29d64d62e1bdc3fb2595fe]

        don't access network during a UITest
        
        Change-Id: If6cc3da3e75ad7689a0de35784c2d29d5b01b96e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-18  Michael Stahl  <michael.stahl@allotropia.de>  [987fe1175de2db53235cc6f2441335fcc3548d64]

        tdf#156419 sw: layout: don't prevent moving between linked flys
        
        ... when there is a page break on the next page.
        
        Of course you can put a section into a fly, and then link multiple flys.
        
        (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525)
        
        Change-Id: I5cb854fc7ee5caa2af4e04f4da2d8a8083c0d007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155842
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [40b2464bf346f1aeda44f719a301e2e60f4d0fd0]

        ignore exception in UUIInteractionHelper::handlerequest
        
        otherwise I sometimes get a crash during
            make UITest_sw_options
        when an exception in configmgr goes up the stack and hits
        the noexcept lamba in the vcl/
        stuff that executes Application::PostUserEvent stuff
        
        #1  in configmgr::RootAccess::getNode()
        #2  in configmgr::Access::isValue()
        #3  in configmgr::configuration_provider::(anonymous namespace)::Service::createInstanceWithArguments
        #4  in non-virtual thunk to configmgr::configuration_provider::(anonymous namespace)::Service::createInstanceWithArguments
        #5  in UUIInteractionHelper::getInteractionHandlerList
        #6  in UUIInteractionHelper::tryOtherInteractionHandler
        #6  in UUIInteractionHelper::handleRequest_impl
        #7  in UUIInteractionHelper::handlerequest
        
        Change-Id: Id90b4d27d3886984c64acdfee98d9c4696c3c03f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155766
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-18  Michael Stahl  <michael.stahl@allotropia.de>  [f88af95552f9b46e1714964d84c447327b50ed40]

        ucbhelper,ucb,desktop: InternetProxyServer is problematic
        
        It turns out that every single client of InternetProxyDecider simply
        concatenates the 2 members of InternetProxyServer into a single string
        and passes it on to curl_easy_setopt(CURLOPT_PROXY), which will happily
        take a URL including scheme and everything.
        
        It turns out that the awful GetUnixSystemProxy() tries to cut off the
        scheme in a terrible way, but GetPACProxy() does no such thing and
        WINHTTP_PROXY_INFO::lpszProxy may or may not contain scheme in its
        entries; fix this to only separate the port and leave the rest alone.
        
        So why do we need a InternetProxyServer struct?  Because officecfg has
        separate entries that correspond to its members, and so
        InternetProxyDecider gets separate events on its listener interface when
        any of them changes, which is easiest to handle if it stores these
        separately.
        
        So just return a concatenated URL with or without scheme in getProxy().
        
        Change-Id: I43c696471c8bec90667b5930fa00975adb432fe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b30b4b1678e8be15ba51d236bd9a3e693d8d3d6]

        Fix curl proxy access for non-authenticated proxy
        
        If rSession.m_Proxy.aName is a simple host-name, the CurlUri constructor
        will fail with CURLUE_BAD_SCHEME, so just ignore the error here,
        we only care about parsing out the username/password
        
        Change-Id: Iec2d6e7315a5899ddddf6120a43199b75bf62db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155834
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [28d41e60416ef10ae2a59d1c4ad34a2eb75dc408]

        add a LogicInvalidatePart which can take a 'part'
        
        no change in behaviour intended
        
        Change-Id: Idee6615cc86cd01bea9aaf17fff2840eea6521a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155814
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [560b5112f6738f02a12adec7d5be04e2411c93b9]

        add a SfxLokHelper::notifyInvalidation which can take a 'part'
        
        no change in behaviour intended
        
        Change-Id: I6040eafb03bcf39724761d7708540e9b25edd8f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155813
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30febe5fc4ac3117ff5dabcd1fec4acfc7b759d8]

        cool#6616 compare graphics for equality with operator==...
        
        instead of checking equal CheckSums.
        
        For better or worse while Bitmap::operator== also considers equal
        CheckSums as equal Bitmaps operator== can quickly return true if
        both Bitmaps share the same underlying SalBitmap which is nearly
        always true in the example here
        
        Change-Id: I6b5cd484aeef7505721a493a3bff23ee345147dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3614953bf1f4ada22247d04a772d1e3e1d361cef]

        tdf#151059 don't use Ctrl+Alt+3 etc by default for gallery
        
        because on some keyboard layouts ctrl+alt is basically
        equivalent to altgr and removes the possibility to enter
        specific letters.
        
        use Alt+3 etc because that 1-9 sequence seems free and
        unproblematic vs other combinations.
        
        If that doesn't work out then maybe we don't need one per sidebar entry
        and just have a single entry to jump to the sidebar toolbar and a follow
        up of press of 1-9 to activate a specific deck.
        
        Change-Id: I676d03c7e1c7bcb3b6c08e6d30aa23cf61838b38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155831
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [47edf86a62784aa275de7cc89df01a4fcd4e90c8]

        tdf#156795, tdf#156109 Avoid typesetter language: orphan, widow control
        
        Instead use descriptive language to make it obvious what these options are for.
        Also invert the logic of the "Do not split paragraph" option as suggested in tdf#156109.
        
        Change-Id: I619c0558597aff26b8b7fafea3548d8bf1f24a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155769
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [abff4a7423a31fc88da63ab92028c22c575131ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01eaa54adbab405db6aad6c2d476bd4ee775e61f
          - Mute l10n on string
            
            Change-Id: I7c4eddb32ca0551f0683d380c202946ea754d0de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155777
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-18  Miklos Vajna  <vmiklos@collabora.com>  [53798fef2cc0b5b0b9706081a4af5ceca964a41b]

        Related: tdf#156351 sw floattable: fix missing top border in follow table
        
        The problem was that in case a table has a table border but no cell
        border, then the follow table was missing a top border in case the
        follow table had multiple rows.
        
        This was already working for single-row follow tables since commit
        a4da71fb824f2d4ecc7c01f4deb2865ba52f5f4c (INTEGRATION: CWS fmebugs04
        (1.115.46); FILE MERGED 2008/05/13 13:56:19 fme 1.115.46.2: #i9860# Top
        border for tables - correction 2008/05/13 13:49:23 fme 1.115.46.1:
        i#9860 Top border for tables, 2008-06-06).
        
        Fix the problem by checking for the case when the first row in a follow
        table has no own bottom border and then take that bottom border from the
        last row instead, if that has a bottom border.
        
        The reported case around the missing bottom border in the master table
        still needs work.
        
        Change-Id: Ib418da99067a42efcf3bd0e2d6a9467797de619a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155824
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8bbabd64ca642b8e9dec5cc6479177315be1210]

        Fix typos
        
        Change-Id: I29aa97b8072fccee24ed0053c9492d61bef44cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155828
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b0cfba866a664b6d70a7b10a20da1971c891ab5e]

        Fix typo
        
        Change-Id: I0c7e1d2c2cf9d20ca40a45d2880ff5dcea4a238d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155830
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bfa592ab0ce94d1adb905cbd7c1c4a2fd7f16192]

        Fix typo
        
        Change-Id: Ia78a6a37b21cd2e286574adcd5fa64818f7d0d75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155829
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-18  Miklos Vajna  <vmiklos@collabora.com>  [20f6e960cda073012a56597bf6544524240ce246]

        sfx2: fix crash in SfxLokHelper::notifyOtherView()
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 1 for address: 0x0
        program/libmergedlo.so
                SfxLokHelper::notifyOtherView(SfxViewShell const*, SfxViewShell const*, int, boost::property_tree::basic_ptree<std::string, std::string, std::less<std::string> > const&)
                        sfx2/source/view/lokhelper.cxx:473
        program/libmergedlo.so
                ImpEditView::ShowCursor(bool, bool)
                        editeng/source/editeng/impedit.cxx:1423
        program/../program/libsclo.so
                ScViewData::SetEditEngine(ScSplitPos, ScEditEngineDefaulter*, vcl::Window*, short, int)
                        sc/source/ui/view/viewdata.cxx:1635
        program/libsclo.so
                ScTabView::UpdateEditView()
                        sc/source/ui/view/tabview3.cxx:2190
        
        Change-Id: I219a1e9685db9bc3ea03d6ab67ff5db74aac9343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155823
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [56d5b243688e6904620920fbbe9dc3f97f18e932]

        Add dots to "Fix" button to indicate it opens a dialog
        
        Change-Id: Ibafcd3998396f4d763faad4296c3f7355cd90cf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155718
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7fc6063914432d58d86cfcbd728d967e7c86ebfd]

        use more Reference::query instead of UNO_QUERY_THROW
        
        since querying with exceptions is consideably more expensive
        
        Change-Id: I968a9a40766b2abb0d3058549b0ed44011fd5716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-18  Michael Stahl  <michael.stahl@allotropia.de>  [db83c41d460103df5d80f5bd99816575c4ead5cd]

        tdf#156725 sw: layout: don't prevent moving between columns ...
        
        ... on the same page when there is a page break on the next page.
        
        The existing, presumably pointless/always-false in case of same page,
        check of WrongPageDesc() let me assume that this would only be reached
        if the current page and the target page are different, but that was a
        mistake.
        
        (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525)
        
        Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-18  Michael Stahl  <michael.stahl@allotropia.de>  [ee82accbd0d67eaf0f5a164a82b86abd00c3b0c9]

        tdf#156728 sw: layout: invalidate fly on header/footer size
        
        On page 30 there are at-page anchored shapes Shape22, Shape23 and
        Shape25.
        
        Shape22 and Shape23 are positioned relative to the bottom of the page
        text area, and that is working; Shape25 is positioned with an offset to
        the top of the page text area, and that doesn't work.
        
        The problem is that the shapes are positioned when the header on the
        page hasn't been formatted yet, and once the header is formatted, the
        position of the Shape25 is not invalidated, so it's a header-height too
        far up.
        
        (regression from commit 425a252c3cc5e5a79a533965026dd4af6b8df739)
        
        Change-Id: Ic907d98b1bcd4bb544fd1af9bf93ebc7b75bf362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155762
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c351f920c426542f0d3685bb9df1363d3a6393f8]

        ITEM: preparations for more/easier changes
        
        This change is not about speed improvements but diverse
        preparations to make changes/reading/understanding easier.
        It does not change speed AFAIK.
        
        Added a global static debug-only counter to allow getting
        an overview over number of all allocated SfxPoolItem's
        and the still alloated ones at office shutdown. The values
        are used in Application::~Application to make a short info
        statement. It allows to be able to quickly detect if an
        error in future changes may lead to memory losses - these
        would show in dramaitically higher numbers then (hopefully)
        immediately.
        
        Moved SfxVoidItem to own source/header.
        
        Added container library interface support to SfxItemSet,
        adapted already some methods to use it - not all possible,
        I will commit & get status from gerrit 1st if all still works
        and then continue.
        
        Changed INVALID_POOL_ITEM from -1 to use a global unique
        incarnation of an isolated derivation from SfxPoolItem. It
        allows to avoid the (-1) pointer hack. Since still just
        pointers are compared it's not worse. NOTE: That way, more
        'special' SfxPoolItem's may be used for more States - a
        candidate is e.g. SfxVoidItem(0) which represents ::DISABLED
        state -- unfortunately not only, it is also used (mainly for
        UI stuff) with 'real' WhichIDs - hard to sort out, will have
        to stay that way for now AFAIK.
        
        Changed INVALID_POOL_ITEM stuff to use a static extern
        incarnated item in combination with a inline method
        to return it, called GetGlobalStaticInvalidItemInstance().
        
        Isolated create/cleanup of a SfxPoolItem entry in
        SfxItemSet to further modularize/simplify that. It is
        currently from constructor & destructor but already shows
        that PoolDefaults are handled differently - probably an
        error. Still, for now, do no change in behaviour (yet).
        
        Got regular 'killed by the Kill-Wrapper' messages from
        gerrit, seems to have to do with UITest_sw_findReplace.
        That python/c++ scripting stuff is hard to debug, but
        finally I identified the problem has to do with
        the INVALID_POOL_ITEM change. It was in
        SfxItemSet::InvalidateAllItems() where still a (-1)
        was used -> chaos in detecting invalid items.
        
        Change-Id: I595e1f25ab660c35c4f2d19c233d1dfadfe25214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155675
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a43a9dd8205f089c92737cb5519ed2a96a8d8ff2]

        logs full of "OConfigurationNode::hasByName: object is invalid"
        
        warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:408: OConfigurationNode::hasByName: object is invalid!
        warn:legacy.osl:3509:3314:unotools/source/config/confignode.cxx:409: OConfigurationNode::hasByName: object is invalid!
        warn:legacy.osl:3509:3314:comphelper/source/misc/types.cxx:90: comphelper::getBOOL : invalid argument !
        
        in cool, open a document, switch from light to dark with sidebar open,
        click on a paragraph and then on another with different properties, e.g.
        normal vs heading and each change of a sidebar context triggers the
        warning over and over again.
        
        The config has no mention of notebookbar_online.ui but we set
        notebookbar_online.ui as the default to use for a notebookbar
        so replace mentions in the config of notebookbar.ui with
        notebookbar_online.ui for consistency when we do that and we
        can drop the constant log spam.
        
        Change-Id: I41860f5422d4426d8e3786b38c967e52bc803ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [60d91bed3fdfb0a3d89c51831b27d2187bd24c40]

        SAL_DEBUG "is never meant to remain in the code"
        
        Change-Id: I8c0e513d36c087e9ea8019325cdb3122bec744be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155743
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-18  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [27fa859bb85ba7ac5b8cb22db5ae85750c7effba]

        Resolves tdf#156357 - Submit Show Formula to document
        
        Change-Id: Ic893e573b2409342d61877313a3b60e83bb13690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154984
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5444b73219fcd50ddbb1fe5e685a401cfd8c9cf3]

        Resave with latest glade
        
        Change-Id: I466d873791351f1eee02cc6bff2adc43e539eece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155768
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-18  jucasaca  <jucasaca@gmail.com>  [ccf30787a701860d19941a1d36ad3d1db2fb2e06]

        tdf#156534 Add Firebird's DATEADD function to SQL parser
        
        Add DATEADD function to SQL parser, so the function can be used in
        Query's Design and can produce  editable queries
        
        Change-Id: I14f9d88f6a96021b0f9199fd79df18c8f4bb5ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155071
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [e59c026c561da4ae0b9bd1a33fcee3fbc724dece]

        vcl a11y: Fix nullptr deref in SvHeaderTabListBox::calcHeaderRect
        
        While working on tdf#156561 and tdf#141101, I experienced
        a crash with the below backtrace on Windows at some point.
        
        Potentially a regression from:
        
            commit 0e8b7dd7a013dffe080148baac926a698f36ad85
            Date:   Wed Jul 19 15:19:28 2023 +0200
        
                split GetWindowExtentsRelative asunder
        
        Use the `GetWindowExtentsAbsolute` variant when
        screen coordinates are wanted, as is done elsewhere
        since the above commit.
        
        Backtrace:
        
            1  std::unique_ptr<WindowImpl,std::default_delete<WindowImpl>>::operator-> memory                           3295 0x7fffa807a02a
            2  vcl::Window::GetWindowExtentsRelative                                   window.cxx                       2953 0x7fffa82b7132
            3  SvHeaderTabListBox::calcHeaderRect                                      svtabbx.cxx                      771  0x7fffa850a1a6
            4  accessibility::AccessibleBrowseBoxHeaderBar::implGetBoundingBoxOnScreen AccessibleBrowseBoxHeaderBar.cxx 311  0x7fffa41b2728
            5  accessibility::AccessibleBrowseBoxBase::getBoundingBoxOnScreen          AccessibleBrowseBoxBase.cxx      408  0x7fffa41ada97
            6  accessibility::AccessibleBrowseBoxBase::getLocationOnScreen             AccessibleBrowseBoxBase.cxx      228  0x7fffa41ae134
            7  CMAccessible::accHitTest                                                MAccessible.cxx                  988  0x7fffbf8d7fad
            8  NdrSendReceive                                                          RPCRT4                                0x7ff81155b4b3
            9  NdrSendReceive                                                          RPCRT4                                0x7ff81155a282
            10 NdrStubCall2                                                            RPCRT4                                0x7ff8114fe1ca
            11 NdrStubCall3                                                            RPCRT4                                0x7ff8114fd494
            12 CStdStubBuffer_Invoke                                                   combase                               0x7ff812295f1c
            13 CStdStubBuffer_Invoke                                                   RPCRT4                                0x7ff81153a74b
            14 CoWaitForMultipleHandles                                                combase                               0x7ff81226bad3
            15 CoWaitForMultipleHandles                                                combase                               0x7ff81226b85e
            16 HSTRING_UserSize                                                        combase                               0x7ff81229aaa6
            17 RoGetActivatableClassRegistration                                       combase                               0x7ff812211283
            18 CoWaitForMultipleHandles                                                combase                               0x7ff812269d7d
            19 SetErrorInfo                                                            combase                               0x7ff812205036
            20 CoMarshalInterface                                                      combase                               0x7ff8122635fa
            21 CallWindowProcW                                                         USER32                                0x7ff8126be858
            22 DispatchMessageW                                                        USER32                                0x7ff8126be299
            23 ImplSalDispatchMessage                                                  salinst.cxx                      474  0x7fffa48301d8
            24 ImplSalYield                                                            salinst.cxx                      551  0x7fffa48308fd
            25 WinSalInstance::DoYield                                                 salinst.cxx                      580  0x7fffa482fe01
            26 ImplYield                                                               svapp.cxx                        352  0x7fffa891790d
            27 Application::Yield                                                      svapp.cxx                        437  0x7fffa891b862
            28 Application::Execute                                                    svapp.cxx                        330  0x7fffa8914c4a
            29 desktop::Desktop::Main                                                  app.cxx                          1601 0x7fffc71696b2
            30 ImplSVMain                                                              svmain.cxx                       204  0x7fffa892d08c
            31 SVMain                                                                  svmain.cxx                       237  0x7fffa892d8f2
            32 soffice_main                                                            sofficemain.cxx                  94   0x7fffc71b81f2
            33 sal_main                                                                main.c                           51   0x7ff6b4f91013
            34 main                                                                    main.c                           49   0x7ff6b4f9105a
            35 invoke_main                                                             exe_common.inl                   79   0x7ff6b4f91459
            36 __scrt_common_main_seh                                                  exe_common.inl                   288  0x7ff6b4f9137e
            37 __scrt_common_main                                                      exe_common.inl                   331  0x7ff6b4f9123e
            38 mainCRTStartup                                                          exe_main.cpp                     17   0x7ff6b4f914ce
            39 BaseThreadInitThunk                                                     KERNEL32                              0x7ff810cd7614
            40 RtlUserThreadStart                                                      ntdll                                 0x7ff8128e26b1
        
        Change-Id: I43c2a19e6ec2ccda11114251883e41b47f74929c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155807
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [230789766b364bf995e6659dd589cdf902c69f2c]

        tdf#156561 tdf#141101 Revert "tdf#140762 tdf#152671 Make dock win ..." et al
        
        Revert
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        and 2 follow-up commits, since it's no longer necessary to
        have the window visible already when the popup shows in order
        for NVDA on Windows to announce the content.
        
        This unifies the code path between gtk and non-gtk again,
        as already pointed out in
        
            commit 3bb762c53ea79f8915a1b8fa39f3f5f57aa68c84
            Date:   Tue Aug 1 09:44:56 2023 +0200
        
                tdf#156100 tdf#156561 Revert to previous behavior for gtk popups
        
        > Further analysis of the root causes is planned in the context of
        > tdf#156561, so hopefully the code paths can be unified again in
        > the future.
        
        The underlying issues have now been addressed by these
        commits instead now:
        
            commit 1d92445fcac1c51c17d8dbfd1a4017430fe7bc46
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 1 09:26:37 2023 +0100
        
                tdf#156561 wina11y: Handle CHILD event
        
            Change-Id I83cf5732bfc9d4886e4f7fa75d4ff462e4d4af6d
            tdf#141101 tdf#156561 a11y: Handle a11y child events in win parent
        
            Change-Id I69c6066127c8b853a27cc1f692f139572541f8eb
            tdf#156561 a11y: Create VCLXTopWindow peer for border win frame
        
            Change-Id If374032387babf41b28067d5df54d5f6ce682c48
            tdf#156561 a11y: Don't ignore child events in AccessibleListBox
        
            Change-Id Ifbe27de01739103d1da04951475db32aa50d429d
            tdf#156561 svtools, a11y: Return created popup win for focus handling
        
        Together with the above-mentioned commits, this also makes NVDA
        announce the font color popup in the "Character" (character style)
        dialog. (Announcement starts as soon as Tab is pressed once,
        not yet for the initially focused item right away.)
        
        Reverted commits:
        
            commit 3bb762c53ea79f8915a1b8fa39f3f5f57aa68c84
            Date:   Tue Aug 1 09:44:56 2023 +0200
        
                tdf#156100 tdf#156561 Revert to previous behavior for gtk popups
        
            commit 70642bb7afd2cee6f7ae6eff2936a35978bd0597
            Date:   Thu Apr 6 15:07:15 2023 +0100
        
                tdf#154470 try moving the Show of the client to after the float positioning
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        Change-Id: Ic621b4344311679af2d13b5a80220e1daf411061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155803
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [e8028cbc11661effbb38ecb6146b9a9557b650da]

        tdf#156561 svtools, a11y: Return created popup win for focus handling
        
        Actually return the popup window created in
        `PopupWindowController::createPopupWindow` instead of just
        an empty reference.
        
        With this in place, the popup window is initially announced
        by NVDA on Windows for the "Borders" toolbar item when expanded
        even after reverting
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        , because the focus event is now sent when focus is
        set via `XWindow::setFocus` in
        `framework::ToolBarManager::OnDropdownClick`
        (s. frame 41 below), while the above commit previously
        ensured that the window was already visible earlier and
        thus the corresponding event would be
        sent earlier already.
        Related backtrace for the winaccessibility case:
        
            1  AccObjectWinManager::NotifyAccEvent               AccObjectWinManager.cxx               185  0x7fffaac46118
            2  AccComponentEventListener::FireStateFocusedChange AccComponentEventListener.cxx         308  0x7fffaac4fddb
            3  AccComponentEventListener::SetComponentState      AccComponentEventListener.cxx         171  0x7fffaac50c14
            4  AccEventListener::HandleStateChangedEvent         AccEventListener.cxx                  166  0x7fffaac4ea44
            5  AccEventListener::notifyEvent                     AccEventListener.cxx                  72   0x7fffaac4faaa
            6  AccComponentEventListener::notifyEvent            AccComponentEventListener.cxx         82   0x7fffaac5123c
            7  AccDescendantManagerEventListener::notifyEvent    AccDescendantManagerEventListener.cxx 70   0x7fffaac56686
            8  AccListEventListener::notifyEvent                 AccListEventListener.cxx              66   0x7fffaac56ca2
            9  ValueSetAcc::FireAccessibleEvent                  valueacc.cxx                          430  0x7fffbad4578d
            10 ValueSetAcc::GetFocus                             valueacc.cxx                          452  0x7fffbad458ed
            11 ValueSet::GetFocus                                valueset.cxx                          271  0x7fffbad4f6b8
            12 weld::CustomWeld::DoGetFocus                      customweld.cxx                        72   0x7fffaf12b2ed
            13 weld::CustomWeld::LinkStubDoGetFocus              customweld.cxx                        72   0x7fffaf12b726
            14 Link<weld::Widget &,void>::Call                   link.hxx                              111  0x7fffaf16be63
            15 SalInstanceWidget::HandleEventListener            salvtables.cxx                        736  0x7fffaf16f436
            16 SalInstanceDrawingArea::HandleEventListener       salvtables.cxx                        6167 0x7fffaf16f3c7
            17 SalInstanceWidget::EventListener                  salvtables.cxx                        824  0x7fffaf16e805
            18 SalInstanceWidget::LinkStubEventListener          salvtables.cxx                        821  0x7fffaf170b86
            19 Link<VclWindowEvent &,void>::Call                 link.hxx                              111  0x7fffaea625c3
            20 vcl::Window::CallEventListeners                   event.cxx                             263  0x7fffaea62970
            21 vcl::Window::PreNotify                            event.cxx                             71   0x7fffaea649a3
            22 vcl::Window::CompatPreNotify                      window.cxx                            3921 0x7fffaeb730e8
            23 ImplCallPreNotify                                 winproc.cxx                           70   0x7fffaeb8eb00
            24 vcl::Window::ImplGrabFocus                        mouse.cxx                             383  0x7fffaeacff8c
            25 vcl::Window::ImplControlFocus                     dlgctrl.cxx                           560  0x7fffaea391b6
            26 vcl::Window::EventNotify                          event.cxx                             210  0x7fffaea633a5
            27 DockingWindow::EventNotify                        dockwin.cxx                           528  0x7fffaea58d21
            28 vcl::Window::CompatNotify                         window.cxx                            3929 0x7fffaeb73058
            29 vcl::Window::GetFocus                             window.cxx                            1852 0x7fffaeb75e94
            30 InterimToolbarPopup::GetFocus                     toolbarmenu.cxx                       187  0x7fffbad41eed
            31 vcl::Window::CompatGetFocus                       window.cxx                            3889 0x7fffaeb72f3d
            32 vcl::Window::ImplGrabFocus                        mouse.cxx                             385  0x7fffaeacffde
            33 vcl::Window::GrabFocus                            window.cxx                            2980 0x7fffaeb770ee
            34 vcl::Window::ImplGrabFocus                        mouse.cxx                             223  0x7fffaeacf4bb
            35 vcl::Window::GrabFocus                            window.cxx                            2980 0x7fffaeb770ee
            36 FloatingWindow::StartPopupMode                    floatwin.cxx                          845  0x7fffaea6dd90
            37 FloatingWindow::StartPopupMode                    floatwin.cxx                          880  0x7fffaea6e076
            38 ImplDockingWindowWrapper::StartPopupMode          dockmgr.cxx                           840  0x7fffaea543ae
            39 DockingManager::StartPopupMode                    dockmgr.cxx                           349  0x7fffaea54131
            40 svt::PopupWindowController::createPopupWindow     popupwindowcontroller.cxx             240  0x7fffbae3648a
            41 framework::ToolBarManager::OnDropdownClick        toolbarmanager.cxx                    1772 0x7fffbc461a0c
            42 framework::ToolBarManager::DropdownClick          toolbarmanager.cxx                    1752 0x7fffbc45c4d3
            43 framework::ToolBarManager::LinkStubDropdownClick  toolbarmanager.cxx                    1749 0x7fffbc460026
            44 Link<ToolBox *,void>::Call                        link.hxx                              111  0x7fffaeb33e23
            45 ToolBox::ImplOpenItem                             toolbox.cxx                           4270 0x7fffaeb5277c
            46 ToolBox::KeyInput                                 toolbox.cxx                           4415 0x7fffaeb5357b
            47 ImplHandleKey                                     winproc.cxx                           1212 0x7fffaeb90b5e
            48 ImplWindowFrameProc                               winproc.cxx                           2724 0x7fffaeb9793e
            49 SalFrame::CallCallback                            salframe.hxx                          310  0x7fffae93a3f6
            50 ImplHandleKeyMsg                                  salframe.cxx                          3752 0x7fffab04568b
            51 SalFrameWndProc                                   salframe.cxx                          5723 0x7fffab04c689
            52 SalFrameWndProcW                                  salframe.cxx                          6043 0x7fffab04d360
            53 CallWindowProcW                                   USER32                                     0x7ff8126be858
            54 DispatchMessageW                                  USER32                                     0x7ff8126be299
            55 ImplSalDispatchMessage                            salinst.cxx                           474  0x7fffaafa01d8
            56 ImplSalYield                                      salinst.cxx                           551  0x7fffaafa08fd
            57 WinSalInstance::DoYield                           salinst.cxx                           580  0x7fffaaf9fe01
            58 ImplYield                                         svapp.cxx                             352  0x7fffaf1d513d
            59 Application::Yield                                svapp.cxx                             437  0x7fffaf1d9092
            60 Application::Execute                              svapp.cxx                             330  0x7fffaf1d247a
            61 desktop::Desktop::Main                            app.cxx                               1601 0x7fffbd5c96b2
            62 ImplSVMain                                        svmain.cxx                            204  0x7fffaf1ea8bc
            63 SVMain                                            svmain.cxx                            237  0x7fffaf1eb122
            64 soffice_main                                      sofficemain.cxx                       94   0x7fffbd618222
            65 sal_main                                          main.c                                51   0x7ff6751e1013
            66 main                                              main.c                                49   0x7ff6751e105a
            67 invoke_main                                       exe_common.inl                        79   0x7ff6751e1459
            68 __scrt_common_main_seh                            exe_common.inl                        288  0x7ff6751e137e
            69 __scrt_common_main                                exe_common.inl                        331  0x7ff6751e123e
            70 mainCRTStartup                                    exe_main.cpp                          17   0x7ff6751e14ce
            71 BaseThreadInitThunk                               KERNEL32                                   0x7ff810cd7614
            72 RtlUserThreadStart                                ntdll                                      0x7ff8128e26b1
        
        With this and all the previous tdf#156561-related commits, the
        above mentioned commit is no longer necessary for
        NVDA to announce the auto filter popup in Calc (tdf#152671)
        and many toolbar popups like the "Boders" toolbar item in
        Calc (tdf#140762) and will therefore be reverted in a
        follow-up commit.
        
        Change-Id: Ifbe27de01739103d1da04951475db32aa50d429d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155802
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [581427c2d62f6bde5b843a1f89fea1914583b96a]

        tdf#156561 a11y: Don't ignore child events in AccessibleListBox
        
        Don't ignore the `WindowShow` and `WindowHide` child events
        in `AccessibleListBox::ProcessWindowChildEvent`, but let the
        base class implemenation handle them just like all other
        child events.
        
        This causes them to be forwarded as `AccessibleEventId::CHILD`
        events to the a11y layer, which e.g. triggers registering
        a11y event listeners for newly created/shown child objects
        in winaccessibility.
        
        This makes the announcement of sub menu entries in Calc's auto
        filter work even after reverting
        
                commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
                Author: Michael Weghorn <m.weghorn@posteo.de>
                Date:   Wed Mar 15 17:00:27 2023 +0100
        
                    tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        , which will be done in a follow-up commit.
        
        `AccessibleListBox` is the a11y class used for
        tree views in the non-gtk case (i.e. `SalInstanceTreeView`).
        A tree view is passed as the parent of the sub menus in
        the autofilter popup (s. `ScCheckListMenuControl::addSubMenuItem`),
        but due to ignoring the events, the submenu would not be
        announced by NVDA before the above-mentioned commit.
        
        The events were ignored since
        
            commit 4c01898e02d7b80f70f19de12f2598644fc421e3
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Mon Jan 28 13:14:03 2008 +0000
        
                INTEGRATION: CWS tbe32 (1.2.16); FILE MERGED
                2007/11/05 15:14:07 tbe 1.2.16.1: #i70908# [A11y] OOo crashes in Customize dialog - Add when large icons and A11y ONcommit 4c01898e02d7b80f70f19de12f2598644fc421e3
        
        to fix a crash in the customization dialog,
        but that problem described in [1] is no longer
        reproducible for me with the change here
        in place.
        
        Comment 8 in the ticket mentions:
        
        > The problem was the accessible child event, which was sent for the
        > help text window. This event triggered some callbacks which caused
        > the dead lock. As the help text window is not exposed as accessible
        > child of the tree list box, I removed the accessible child event.
        
        The fact that extra children from the `vcl::Window`
        hierarchy (besides the entries in the `SvTreeListBox`
        are currently not exposed via
        `AccessibleListBox::getAccessibleChildCount` and
        `AccessibleListBox::getAccessibleChild` is still
        true, but not a problem in this context.
        (If necessary, handling for those should be easy to
        add by forwarding to the corresponding
        `VCLXAccessibleComponent` methods, and adapting
        the child index used as needed.)
        
        [1] https://bz.apache.org/ooo/show_bug.cgi?id=70908
        [2] https://bz.apache.org/ooo/show_bug.cgi?id=70908#c8
        
        Change-Id: If374032387babf41b28067d5df54d5f6ce682c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155801
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [2cd1408dd7d6688357257f4a58a8b467628b1884]

        tdf#156561 a11y: Create VCLXTopWindow peer for border win frame
        
        If a border window is a "native frame", i.e. a top level
        window, then also create a `VCLXTopWindow` for it instead
        of just a simple `VCLXWindow`.
        
        This also addresses another cause why the Calc autofilter
        popup would not be announced by the NVDA screen reader
        before
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        For winaccessibility, an accessible event listener
        is registered for an object when either
        `AccTopWindowListener::windowOpened` gets an event
        with the top level window set or the parent of
        the window sends an `AccessibleEventId::CHILD` event
        for the child object.
        
        In case of the autofilter popup in Calc, the top-level
        border window of the work window (created and set in
        `WorkWindow::ImplInit` and retrieved via `Window::GetFrameWeld`
        in `ScGridWindow::LaunchAutoFilterMenu`) is set as the
        parent window of the popup, but since it is a top-level
        window and was so far not considered as such due to its
        peer/component interface not implementing `XTopWindow`
        (s. `Window::IsTopWindow` and the corresponding check
        in `VCLXToolkit::callTopWindowListeners`), it would
        not have any accessible listener set, and thus no
        child event for its new popup child would be sent
        to the winaccessibility layer. Therefore, no
        accessible events would be sent for the popup
        and it's children either, resulting in NVDA not
        announcing any focus changes, etc.
        
        With this change in place, NVDA announces focused
        items in the auto filter popup even with a revert
        of the above-mentioned commit (and follow-up commits),
        except for submenu entries (which still suffer from
        another problem that will be addressed separately).
        
        Change-Id: I69c6066127c8b853a27cc1f692f139572541f8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155800
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [4d27d2c5f9d83112b6db9b6234e2ae617ffced22]

        tdf#141101 tdf#156561 a11y: Handle a11y child events in win parent
        
        `VCLXAccessibleComponent::ProcessWindowChildEvent` was only
        processing `WindowShow` and `WindowHide` events when the
        `vcl::Window::GetAccessibleParent()` for the window sent in
        the event would return the window that the `VCLXAccessibleComponent`
        refers to.
        
        This generally seems reasonable, but when the child events
        are sent for the corresponding window, the window's hierarchy
        is iterated over using `vcl::Window::GetParent()`, so if the
        accessible window is not in that hierarchy, no window would
        take care of the child events.
        (Note e.g. how `Window::GetParent` uses `mpWindowImpl->mpRealParent`
        while `Window::getAccessibleParentWindow` uses `mpWindowImpl->mpParent`
        and has some special handling.)
        
        Due to the way that `ImplDockingWindowWrapper::ImplPreparePopupMode`
        reparents the windows, this is at least the case for the auto
        filter popup in Calc and the font color popup in Writer's "Character"
        dialog, so the `VclEventId::WindowShow` event would not be forwarded
        to the a11y layer as an `AccessibleEventId::CHILD` event, and thus no
        listener would be registered for the children. As a result, the NVDA
        screen reader would not announce these objects when they receive
        focus.
        
        Make sure that the child event gets handled by making
        `VCLXAccessibleComponent::GetChildAccessible` also take
        into account the `vcl::Window::GetParent()`.
        
        This addresses one of the underlying issues why the Calc autofilter
        was not announced by NVDA before
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Author: Michael Weghorn
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        It might make sense to reconsider the way of
        reparenting in `ImplDockingWindowWrapper` and general
        a11y parent handling at some point, but that will need
        further analysis and would presumably require more
        fundamental changes elsewhere, too.
        
        Change-Id: I83cf5732bfc9d4886e4f7fa75d4ff462e4d4af6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155799
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [eb812cb94f20dd04fa4cf3ec89df8bb813811359]

        Rename Window::ImplIsAccessibleNativeFrame and make it public
        
        The way to determine whether this window is a "native frame"
        doesn't look particularly specific to a11y, so rename it
        to just `Window::IsNativeFrame` and make it public in order
        to reuse it in a follow-up commit.
        Also move the implementation out of the source file that
        implements accessibility-specific Window methods for
        consistency.
        
        Change-Id: I980f251cacce6a601e86fc6261a231b799b30317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155798
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [756febf9a889cc969c3c7812806ef999d0befb95]

        vcl: Reuse existing Window::ImplIsAccessibleNativeFrame
        
        ... instead of duplicating what it does in
        `Window::ImplIsAccessibleCandidate`.
        
        Change-Id: If422597046447bbf30a0488ceed2cf1d2fa49c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155797
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Michael Weghorn  <m.weghorn@posteo.de>  [c192c46d3f2be5e48783d590313f875e1f0477a1]

        vcl: Deduplicate 2 common lines for border win frames
        
        These 2 members are set the same way for all of the
        3 branches.
        
        Change-Id: I2acbb519e30926eb5798bb52e1ef95dceca47b5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155796
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b9643960117612b7e1cae1ed8325c2630232d0f]

        tdf#142424: Revert "related tdf#156579: just break for switch element"
        
        This reverts commit e222f60ac2a71032dbdf62d7c7e28978b5a0b19c.
        
        To make the switch element behave like a
        group as least, so the transform attribute is parsed
        Change-Id: Id8c21ac6da217d8f7bc350ff41022335bf1e0f1f
        
        Change-Id: If1e53f9baad8995f26f9b885cfef6265040736bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155758
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-18  László Németh  <nemeth@numbertext.org>  [e79f0f65ab06baafc7e8a6aeb1d89ca748087b24]

        tdf#156783 sw tracked table column: fix crash setting border
        
        or border padding without correct table cursor.
        
        Table formatting is allowed on text selections starting
        with tables, but adding border or border padding
        resulted crashing. This regression became more visible
        with hidden deleted table columns, where SelectTable
        (e.g. Ctrl-A) doesn't select the whole table, but only
        the text content of the visible cells, and in the case
        of hidden right table columns, without table cursor.
        
        Manual test: insert two tables in the document, and in the
        first cell of the first table, select the whole document
        by  pressing Ctrl-A 2 times or more. In table settings,
        enable table border or modify padding to crash LibreOffice.
        
        Regression since version 7.5.
        
        Change-Id: If8ebb52c7662ff37ac42348c8f412549b793b6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155749
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5ca28013a5ceb1b633fd4df8f9451778be5f1734]

        Skia: Avoid assertion failure inside ProcessAndBlurAlphaMask
        
        As seen opening https://bugs.documentfoundation.org/attachment.cgi?id=182024
        from tdf#150610.
        
        The upscale is pending, and SkiaSalBitmap::mImage is empty here;
        EnsureBitmapData call works correctly in this case.
        
        Change-Id: I71575b09b3b4513b06b55271f6440688785cfb84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155792
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [a5951db71b2af380c9a522ec93df77583ec9b64f]

        Simplify Point/Size/tools::Rectangle templates
        
        Avoid reinterpret_cast; drop unneeded 'using'; deduplicate some code
        
        Change-Id: I9c39552b0ccaa45344808e02ad89b21a42766784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155761
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8386d8e51067b13124ed7cbb693719c0b6463601]

        tdf#156654 - A11Y - fix no fixable button for warning about
        
        "Document default language is not set."
        
        Open dialog "Tools/Options/Language Settings - Language" for
        fixing the issue for the actual document.
        
        Follow-up of ca9cb1df613789d99154d50e77847c3e32330642
        (tdf#156591 - A11Y - add fix button for "Style has no language set.")
        
        Change-Id: I0d13ad49b8f2eb196e4212f3e3719cf036087dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155665
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2023-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [e304163c8a70daab587f0b328554444513887779]

        Simplify a bit
        
        Change-Id: I4cc8f6dbaec0edd8a7a761f03868035350e01734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155760
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-17  Michael Weghorn  <m.weghorn@posteo.de>  [8c4fa83191e6df5d823386cca2adc30dbbc9e297]

        tdf#156699 a11y: Set a11y name for SvxCharView
        
        Set the character name as a11y name for the `SvXCharView`.
        
        Also add a check for the string to be non-empty in
        `SvxCharView::GetDecimalValueAndCharName`, since
        `SfxCharmapContainer::updateRecentCharControl` sets the
        text to an empty string, and calling
        `OUString::iterateCodePoint` on that empts string
        would trigger an assert now that
        `SvxCharView::SetText` tries to retrieve the character
        name right away.
        
        This makes NVDA on Windows announce the focused
        character by its name in the Special Characters dialog
        and the Special Characters toolbar group button.
        
        Orca with the gtk3 VCL plugin now announces the
        focused character in the Special Characters dialog,
        but not yet in the toolbar group button.
        
        Change-Id: I79c8e0c2de6e817a467a405dc7d9e103cba07dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155757
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-17  Michael Weghorn  <m.weghorn@posteo.de>  [5b7d9f21ef74601f4893dd07e8e3f2bf34427eb0]

        tdf#156699 sfx2: Extract helper method to get char value + name
        
        It will be reused in an upcoming commit to set the a11y
        name for the `SvxCharView`.
        
        Change-Id: Ib5938e5363571e547ee00cac8432f919b60cd97a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155756
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [188cff995830d52f4b04ee4d2ffcabeff5d17b27]

        tdf#142489 Do not show the table toolbar when Notebookbar is active
        
        When the Notebookbar UI is being used, all the commands are already accessible via the "Table" tab in the notebookbar, so showing the toolbar duplicates the commands on the screen.
        
        Therefore, this patch disables showing this toolbar when the Notebookbar UI is being used. Obviously, it can be enabled manually via View - Toolbars.
        
        Change-Id: I115effbd94f61df518ff90411a45431fefa9e844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155473
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-17  Attila Szűcs  <attila.szucs@collabora.com>  [c6250e82472f0d36c0c0c4b33c76882c94da8170]

        SW: LOK: crashfix for ios navigator
        
        Added conditions to check if m_pNavigateByComboBox
        exist, because on ios, navigator does not have
        thit combobox.
        
        Change-Id: If5411a1687338caaa9fd76ae5471be4648ab61de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155388
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-17  Michael Stahl  <michael.stahl@allotropia.de>  [802d748d9ce5541dc54a0369910a442afeeaa43e]

        tdf#156727 sw: layout: allow MoveBwd if previous has keep-with-next
        
        In the pathological fdo56431-6.odt there are 16 pages of 1-line
        paragraphs that all have keep-with-next set, and only the first of them
        has a page break before.
        
        The layout temporarily uses 5 pages for the table of content at the
        start but then everything fits on 4 pages, so page 5 is empty.
        
        Now the first text frame on page 6 moves backward despite its
        keep-with-next, because it hits SwFlowFrame::SetMoveBwdJump(true) in
        SwFrame::GetPrevLeaf().
        
        The next one however nopes out in SwContentFrame::WouldFit_().
        
        This is because it continues along the sequence of keep-with-next frames
        until it runs out of space in the new upper; this happens with a frame
        that's actually on page 7.
        
        Ignore keep-with-next in case the previous frame in the new upper also
        has it set, because it really doesn't mean anything then.
        
        (somehow regression from commit 25a252c3cc5e5a79a533965026dd4af6b8df739)
        
        Change-Id: I0cfbc8b67bd0b95dfe08054660a2935de923a661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155741
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-17  Miklos Vajna  <vmiklos@collabora.com>  [b32c9df02bf4abc9d36083c51b28bad6565465c6]

        sw: fold SwSectionFrame::dumpAsXmlAttributes() into dumpAsXml()
        
        One dumpAsXml() per SwFrame subclass is enough, no need to have a
        separate function that dumps just the attributes.
        
        Also eliminate a manual reinterpret_cast<> and a static_cast<>.
        
        Change-Id: I99c44f4b097586bdc174d3133bbb4ee9f26e57cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155747
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [ee52f20ec727e5c296cc5d8f4c2a25f1414eb0fe]

        Drop defines obsoleted by Windows 7 baseline
        
        I.e., those that are guarded in Windows headers by stuff like
        
          #if(_WIN32_WINNT >= 0x0600)
          #if(WINVER >= 0x0501)
        
        Change-Id: If9ab06663b2c9f511549823f14c8bc759a30a74c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155751
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [953e586dbce1c3195ecb07b2491b6e1a20a2cd7f]

        tdf#153012: import chart's c:clrMapOvr element
        
        Otherwise, a wrong mapping could be used, e.g. from slide.
        
        Change-Id: I8b0fcebcd21ac2bab8b7f58d0c24753d2eca02c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155748
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [930cb8440697d80df0a399d765dc85966732ddce]

        Resolves: tdf#156751 add "Special Character..." to GtkEntry context menus
        
        translation exists so doesn't require additional translation
        
        Change-Id: Ibc5df15b9b8442307195d79c862c69e0506c4057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-16  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b4cbf44e8d5072e79b62e6b4e3b1c2480e4a34f3]

        tdf#156591 - A11Y - add fix button for "Style has no language set."
        
        Open style language character settings if the language is set to 'None'.
        Add EditStyleFont uno command for editing directly Font of paragraph styles.
        
        Change-Id: I8b7d7880cc77f7352edac089ee95b4a6d0744575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155494
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2164850f20d9342db94faa84c78fbb5b976552e]

        cid#1539911 Big parameter passed by value
        
        Change-Id: I761fb02d80a224a4b170bb287169da923a003d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [89d020bc5887077a2e5175bcaec7cd7e4c453305]

        itemset is always passed, so can use a reference
        
        Change-Id: Id238066861ee21a9a69f40d1c136bd5b5bd0f804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155735
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-16  Patrick Luby  <plubius@neooffice.org>  [f6cae6f1b661baafe8a1ac4655765ec49d56317d]

        tdf#144073 and tdf#147645: use bounds and angle for gradient
        
        Passing an expanded, rotated polygon noticeably modifies the
        drawing of the gradient in a slideshow due to moving of the
        starting and ending colors far off the edges of the drawing
        surface. So try another way and set the angle of the
        gradient and draw only the unadjusted bounds.
        
        Change-Id: I95441dfa3215396d5bc7edfa9f985335480b37de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155729
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [d9f2193b72f6bd9e5f551c12331a5e547c3ac557]

        Fix a DPI-dependent test
        
        Change-Id: I228b927c4daac3a4da0819e490a9963b514b4c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155731
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-16  Denis Sorotnik  <sorotnik@gmail.com>  [552170c9c8ad6d215aa456ba9d622af01c25d275]

        tdf#156311 Cycling through tabs in Calc
        
        Change-Id: Ieadae5dea642b27a2c91fd8c34049dc5a79bdf6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155449
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8da4e517266e74d8b0e2cda02416263d8dd6f6bd]

        svgio: fix typo in code
        
        Change-Id: Ice8e830cebf307b6a4deb9dbbd26e65b34420a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155734
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [500c73ba9e7dbe98ed82a64302f5b3a64f14b1ee]

        update credits
        
        Change-Id: Ife0d509b91f17510e6a32494e6456fe7043781ec

2023-08-16  László Németh  <nemeth@numbertext.org>  [a9b3d3ec7fe6fe995b689c1de7e065b68845ea85]

        tdf#156782 sw tracked table column: fix missing right table border
        
        Last visible column of a table followed with hidden deleted columns
        hid also the right border of the table, if the inner vertical column
        borders drawn only by left-only borders (like in the default table
        style).
        
        See also commit f9898fa64bd2a575be94c309b43373de53c5331b
        "tdf#150308 sw: fix missing top table border after hidden table rows"
        
        Note: layout testing doesn't work, because of the missing calculation
        with the width of the enabled border of the row frame. Also there is
        a problem with metafile testing (empty meta file?).
        
        Change-Id: I5e98c6751d889f8d5a3f7f2b0b31e44149742e25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155669
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [45de95dc585d79e7165a3035b27d65bb3f0af3d5]

        Update git submodules
        
        * Update translations from branch 'master'
          to a2d843f1212a3a04da04244c4a21a70f46e22b9d
          - update translations for master/7.6.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Ie4e0754d95811399ba74227f3387d7930a640cb1
            
2023-08-16  Miklos Vajna  <vmiklos@collabora.com>  [1cf29168840f84c2e946e2678b99988e83503c96]

        tdf#156682 sw floattable: fix missing del of master anchor para por on split
        
        Pressing "enter" at the end of B1 in the bugdoc resulted in a split
        floating table, which had the anchor text duplicated (both on page 1 and
        page2).
        
        What happened is that the master anchor frame didn't have its paragraph
        portion cleared, the follow anchor frame had a correct frame offset (of
        0).
        
        Fix the problem in SwTextFrame::FormatEmpty(), similar to what commit
        00b9b33334791079c2dc26b1ed4c123450cabf7d (sw: call FormatEmpty() in
        SwTextFrame::Format() for split fly masters, 2023-02-09), did; here what
        we want to avoid is setting some properties on the paragraph preventing
        the deletion of non-last anchor paragraph portions.
        
        As a side effect, this also fixes the hang from the bugreport, after
        pressing "enter" 5 times at the end of B1.
        
        Change-Id: I16e6d786f02ad503a0fdff465ecf7716c1c5f8b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155732
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa728837ecab38b59c2c562ed48505f204a89bea]

        no need for mutex locking here
        
        these values are assigned in the constructor and never updated
        
        Change-Id: Ia4e0524c2b5c5465f9659eb88a11b955492e7e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-16  Miklos Vajna  <vmiklos@collabora.com>  [6cda5cd1b768f99e01e483f5e76092403aeb69a7]

        CppunitTest_sw_xhtmlexport: convert one test to use CPPUNIT_TEST_FIXTURE()
        
        The tests in this suite only assert at the end of an import + export, so
        no need go via Writer-specific macros. This also keeps all code of a
        test in a single place, no need to trigger the preTest() magic.
        
        Change-Id: Ibf8c2dee99e02483642887ab74cc4f997389da3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155727
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-16  Jim Raykowski  <raykowj@gmail.com>  [b363a689bf5b434113648373f98ee46aa00c09d7]

        tdf#156610 tdf#139633 SDNavigator: Fix object naming/renaming
        
        implementation
        
        This patch makes the Rename... menu item open the Name dialog and
        makes name editing start in the tree when a selected entry is left-
        clicked on and released without moving the mouse pointer to begin a
        drag operation.
        
        Change-Id: I8d8b93895b797d7e1be860a17a5c1fe6d82e474e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155647
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-16  Jim Raykowski  <raykowj@gmail.com>  [717fa28e88f382ad86b2be2fdbc24f4f60bc524d]

        tdf#156538 Enhancement to show character information in the insert
        
        special characters control
        
        This patch makes a tooltip show when the mouse pointer is over a
        character window in the special characters control. It also adds a
        label that is used to display character information of the highlighted
        character. Code for creating the character information text shown in
        the tooltip and label was referenced from SvxCharacterMap.
        
        Change-Id: I4b62e63b27310cbe9e9661ff51c2db206e9e3507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155547
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-08-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5fecd865303b3f0a2eeb0b9466d2bcf23cfce068]

        Fix typo in default Impress template text
        
        Change-Id: I7c8550e3b71e8efaa70d966f91fc3fbee2b93939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155551
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [20f57e14362674d321ef184e1987f41a6418adc2]

        tdf#156777: check for css style in textpath
        
        Change-Id: I63a274dd9fba37852412a194a490cb2b7634f1cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155726
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [d2c7cbc7d724d608f6d37bbb0233ad2b39eb938e]

        Simplify and improve conversion
        
        Using o3tl::convert makes sure that rounding is correct, which
        shows in the improved unit test, that now doesn't need different
        values before and after roundtrip.
        
        Change-Id: If46e27300bc199e89c0abf0ea4d0cd825024aeb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155728
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-15  Michael Stahl  <michael.stahl@allotropia.de>  [7712221f5340b8eb875d391967b2726e93285ab4]

        sw: PDF/UA export: add /Placement/Block to Note
        
        PDF 1.7 defines Note as an ILSE (inline), but that is rather odd and
        definitely not how footnotes work in Writer.
        
        PAC 3 complains about "Possibly inappropriate use of a "Note" structure
        element" and "Possibly inappropriate use of a "P" structure element"
        which is rather opaque but experimenting shows the warnings disappear
        when the Note has a /Placement/Block attribute.
        
        PDF 2.0 (ISO-32000-2:2020 Annex M) even removes the Note ILSE and
        introduces FENote as a BLSE to replace it.
        
        Change-Id: I46ee32c88d4be495bf79549280e2fa68d7da091c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155722
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9d5a7d9257db78eb3f4d77c39eae1affe877ea6b]

        ComplexColor various clean-up and (trivial) refactorings
        
        Don't allow access to member variables of ComplexColor and makes
        them private. Needs a lot of changes.
        
        Change "scheme" to "theme" to be more consistent. In LO we usually
        call the "theme color" what is usually refered to as "scheme color"
        in OOXML, where it is sometimes refered to as "scheme" and other times
        as theme color.
        
        Remove ThemeColor class which was replaced with CmplexColor some
        time ago.
        
        Remove un-needed includes and un-needed components.
        
        Use isValidThemeColor in many places where we check that the
        ComplexColor is of "Theme" type and that ThemeColorType is set to
        a valid value.
        
        Change-Id: I325595fa65b8e56a4707e9d22acc6330aac28961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155359
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-15  Justin Luth  <jluth@mail.com>  [918cd8cbf383e0099d80db2e12a1071a0bc4f200]

        VCLSession: avoid null dereferences
        
        Found while I was (mis)using
        XSessionManagerListener2 in
        https://gerrit.libreoffice.org/c/core/+/155460
        
        But I think these are valid anyway.
        Certainly one is when it is checked in the try clause
        but not in the catch clause.
        
        Change-Id: Ia3f7211e4a4c86dd503ffe1b04e5b5c13227218e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155719
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6c06c8a2be3d8cbbcb8ab1aaaeb04db95114dfcb]

        tdf#153008: srcRect may have some members negative
        
        The overly strict check (implying that all members must be non-negative,
        to perform the crop) excluded valid cases where some of the members were
        negative, and some positive.
        
        Change-Id: I629689bdccedf9e37632a9fe14654778c0f14a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155717
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-15  Balazs Varga  <balazs.varga.extern@allotropia.de>  [54c158ff35ab5a0b5fa538562755638e052d51f2]

        tdf#156741 - A11Y - fix drawing shape is not highlighted by clicking
        
        "Avoid floating text" warning.
        
        If GotoFly not select the textframe object try GotoDrawingObject.
        
        Change-Id: Ica7829dd0cc21f3f1fb344dfb21afdfb43783cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155676
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [72b118e4cb7f97cbd296fd829a463fe9fafb8486]

        set libtiff ac_cv_lib_jpeg_jpeg12_read_scanlines cache val to false
        
        to avoid:
        
        ...
        checking for jpeg12_read_scanlines in -ljpeg... yes
        ...
        JPEG 8/12 bit dual mode:            yes (libjpeg turbo >= 2.2 dual mode)
        ...
        tif_jpeg.c:143:25: error: unknown type name ‘J12SAMPARRAY’
          143 | #define TIFF_JSAMPARRAY J12SAMPARRAY
        
        where the system jpeg is linked against during configure but the build
        is against the internal jpeg and the system one happens to support
        jpeg12_read_scanlines
        
        Change-Id: I895d77c59a5bef1af0b1a85d44da1a54e502f8e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155670
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-15  Miklos Vajna  <vmiklos@collabora.com>  [4afd83245b6ab2232032c74b1d242122fc734352]

        Update pdfium to 5941
        
        - Remove part of ubsan.patch, upstream switched to FXSYS_memcpy() in
          those two functions, which does the same length check as our patch
          did.
        
        - Part of build.patch.1 doesn't apply anymore, remove the FXFT_Free()
          part and just assume that the new FT_Done_MM_Var() introduced in
          freetype-2.9 is something we can use unconditionally (at least the
          almalinux 8 has freetype-2.9.1).
        
        Change-Id: I77efc9921e76957edbcb68e8f3861ab5194b31e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155678
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-15  Julien Nabet  <serval2412@yahoo.fr>  [dedf098e742550622cec6fdc639550371d9e58cf]

        GTK3 Disabled menu items are not hidden in DontHideDisabledEntry = false mode
        
        Change-Id: Iece7d9de56477702fadbf1cadc2e0f5d9224c96e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155197
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-15  Regina Henschel  <rb.henschel@t-online.de>  [64121a303b5ceb3dd149215529ef8346b6d00dcd]

        CID 1539919:  Null pointer dereferences
        
        The problem was introduced in 631964a2ce1da3fbbeb53a5550c0e6728ba644aa
        tfd#112687 Combine adjacent lines into one shape
        
        Change-Id: I4c064a22e5fcc0040e249dbde09ee591ac2693c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155686
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-15  Michael Stahl  <michael.stahl@allotropia.de>  [61a78a523a6131ff98b5d846368e5626fe58d99c]

        tdf#156724 tdf#156722 sw: layout: remove IsPaintLocked() check
        
        Get rid of the problematic IsPaintLocked() and only check for a column
        parent; effectively this prevents formatting frames in columns even when
        loaded from the UI, so the layout will hopefully be the same regardless
        of how it is invoked.
        
        Change-Id: Ib4cc2efdb68ef4db73dcad01c7e1bd4be35de071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155673
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-15  Noel Grandin  <noelgrandin@gmail.com>  [3039737af6d6e539c652f0d4b25303c30713836e]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I1efda255a7ab1e90ad3a41cb36c72384743a7980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155677
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-15  Miklos Vajna  <vmiklos@collabora.com>  [68c8466dd80e7a964e1377ee3e0308dc449fbf2d]

        sw floattable: handle AllowOverlap==false in the RTF filter
        
        Map \tabsnoovrlp to SwFormatWrapInfluenceOnObjPos::mbAllowOverlap on
        import and do the opposite on export.
        
        Change-Id: I3d786041648d62e80f2ea9e3d726426e01a8d192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155687
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-15  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e027ef6c0534b7ce50dc5f8b74e27ce85b9eb97b]

        tdf#156670 - A11Y - Open the Format->Description dialog with the fix button
        
        The Fix button will open the Format->Description dialog in case of shapes,
        textBox, graphic, OLE objects.
        
        (Remove Description text from (AccessibilityTests1.odt) the shape for proper
        testing of no_alt_text.)
        
        Change-Id: I6678fa44a0a47bab60558f770cc709012f02d83b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155653
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [751104215e6c4b42b68dd255e48d771e319555b4]

        fix crash in LOK
        
        ImpEditView::lokSelectionCallback(std::optional<tools::PolyPolygon>
        const&, bool, bool)
          editeng/source/editeng/impedit.cxx:446
        ImpEditView::DrawSelectionXOR(EditSelection, vcl::Region*,
        OutputDevice*)
          editeng/source/editeng/impedit.cxx:642
        ImpEditEngine::Paint(ImpEditView*, tools::Rectangle const&,
        OutputDevice*)
          editeng/source/editeng/impedit3.cxx:4164
        ScGridWindow::DrawContent(OutputDevice&, ScTableInfo const&,
        ScOutputData&, bool)
          sc/source/ui/view/gridwin4.cxx:1226 (discriminator 1)
        ScGridWindow::PaintTile(VirtualDevice&, int, int, int, int, long, long,
        short, int)
          sc/source/ui/view/gridwin4.cxx:1700
        ScModelObj::paintTile(VirtualDevice&, int, int, int, int, long, long)
        
        Change-Id: Ib142e6bd52bf0271d8e0e97af7701454144ead9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-15  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [88617f24d5a724c86a89058682ac04d7af9c8ea3]

        Revert "Fix typo"
        
        This reverts commit 9d322bfa580839f48d2f4ce6cdd6b18c8253af85.
        
        Reason for revert: British spellings are not "typos"
        
        Change-Id: I0d9861435931b839747da9c9abad4cf61b1a4d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155693
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-08-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a2b6be8af9be3237efc3ed1244302cf899680e97]

        tdf#86938: fix calculation of baseline-shift
        
        Change-Id: I8c30c29052f2ea1fe6e49360b972af868851131b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155671
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [5cfd31e505b4d1b4f9d2e21b0f9f8aac22539f47]

        tdf#93583: use getTextWidth to calculate line's width
        
        Since every character in the line might use different styles
        Change-Id: I2ce079d4308f4acde42a8366838749a7c20331b4
        
        Change-Id: I01f51f157caa667cebc8860ae37d4458fac2d511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155666
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [850b66f969834e61f3cb1a1ccd4bfc15f23d558f]

        tdf#154265 Disable automatic slide advancement when moving backwards
        
        When a slide has a 0 second automatic slide advance setting, and you move
        back to that slide, it would immediately move forward again.
        
        Only enable automatic slide advancement when moving forwards.
        
        Change-Id: I3c901bed5323569f5cf52aeca5b3227c87b6e539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155663
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d827d36625e8952ef3bfadbf8de76578074d474d]

        move GetEditTextObject to after it is potentially generated
        
        Change-Id: Iadd6a2b66e3131b8883cf3812b5f0a8153631abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-14  Michael Stahl  <michael.stahl@allotropia.de>  [610c6f02b11b4b4c555a78b0feb2a1eb35159e39]

        tdf#156724 tdf#156722 tdf#156745 sw: layout: partially remove IsPaintLocked()
        
        Having the layout algorithm dependend on IsPaintLocked() is very
        problematic; it is typically set when the layout is invoked from
        SwViewShell code, as happens several times when loading a document in
        response to window resize events etc., but not for idle formatting or
        from SwXTextDocument::getRendererCount(), hence these bugs only
        reproduce with soffice --convert-to pdf, not via UI.
        
        For tdf#156724 the problem is that the table is split, during formatting
        of the split row a new footnote is created on page 1, and this reduces
        the space, so splitting fails and is never attempted again.
        
        When the document is loaded from UI, when the table is split the
        footnote already exists and so splitting succeeds; it was created by
        a call from SwLayAction::FormatLayout() of the cell frame.
        
        It turns out that when the condition is removed completely, testUXTSOREL
        will take 5 minutes instead of 5 seconds, which seems excessive; the
        problem there appears to be that a text frame in a columned section
        moves forward and backward; plausibly columned section content should be
        formatted by ::CalcContent() only.
        
        (reportedly regression from commit c605283ad6785dea762feab5fdffd9d27e75c292 and commit
        7e8b4756d95057f069467b34e7849f9354856578)
        
        Change-Id: I9ed73588efeec654a769eee8aa825186bd51e059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155672
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-14  anfanite396  <dipamt1729@gmail.com>  [b9e72b2577da2a0a61e95ff8a0a7f289f194c59b]

        Move SwXTableCellText Java tests to C++
        
        Change-Id: Iea2113030bb82ee02bd84140f5def7040b4f4fcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154087
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-14  anfanite396  <dipamt1729@gmail.com>  [88fe6dc44919b0a525e06bf0ac6e628b0f6c8a28]

        Move SwXReferenceMarks Java tests to C++
        
        Change-Id: I3d825590e60190cf95f514b5df606a83ea4193b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154086
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8d2ab36f41f8f11e9f5986bba6ebb5b95d7e1eef]

        tdf#156620 - A11Y - fix not clickable warning about tables have headings
        
        Make warning messages clickable and go to the problematic paragraph.
        
        Change-Id: I5ca0b33b6f50b5d08993ebd0fc2749804e80de48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155587
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [13d51d47e8c7c8cca6d1271dfad42e0af982945f]

        tdf#156622 - A11Y - fix not clickable warning about blinking text
        
        Make clickable and highlight the problematic text.
        
        Change-Id: Ie53c74b0364d08e4299e4c27ff2744a8c547844e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155586
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d8e012b6a71ed1499d0e25122cc65c13cdadddf6]

        Fix typo
        
        Change-Id: I5975a46e2692b1af221ca716d2a117e424948c15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155664
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-14  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [7c5188cbd483c1aab8c7bb55a29efcd935196fa1]

        sp2bv : no need to use fprintf without any formating
        
        Change-Id: Ieb276dcbd91873bd5121ae7534f0e120c88a88d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-14  Michael Stahl  <michael.stahl@allotropia.de>  [fcf6f5550cc7949e94dc74cbcd10a700a225e574]

        tdf#142694 sw: layout: fix infinite loop in SwFrame::PrepareMake()
        
        The problem is that SwFrame::FindNext_() returns itself, because it's a
        table frame 401 and its last cell is empty.
        
        There was a nested table in the cell, but during an attempt to split the
        outer table 401, the inner table moved backwards.
        
        This is due to code that was added in commit
        c9c956f2716c58e2573a9ac07073f712d736ed02, which only checks that the
        height of the table frame is 0, but in this case the inner table does
        contain a text frame which has never been formatted yet, but still the
        table frame's size and print area was set to valid.
        
        Unfortunately adding an obvious !ContainsContent() check to the
        condition breaks uiwriter4 testTdf114306_2, the last table is not on
        page 4 but on page 5, for no good reason.
        
        So just fix SwFrame::FindNext_(), it should never return "this" anyway.
        
        (somehow regression from commit 53a0a86df6eb5fc64a85ecd03f2e354fd4d8e213)
        
        Change-Id: If043a53c32f175fc560d422c4a4e16d8e8c6ef49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155563
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-14  Miklos Vajna  <vmiklos@collabora.com>  [518fa99dd7693d64a53e404a065090aedc0002b1]

        starmath: fix -Werror=unused-variable
        
        Seen with gcc 7.5.0.
        
        Change-Id: I34940865f62ff397a3a6813fbabd0fb45a01d88f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155654
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85bf5d395039b627dd63e1b11d8f7b0fa529d28b]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e32c98b7aa5dc8b451f3ca1ba2f447f4534e77fc
          - tdf#156723 Remove false pleonasms for pt-BR
            
            + Removed "prefeito municipal"
            + Removed "Pessoa humana"
            + not removed "salário-mínimo" (rule does not exist)
            
            Change-Id: Ic5a9487cf49f764ff3bc5587b54bca7f40d7264f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/155570
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-14  Miklos Vajna  <vmiklos@collabora.com>  [d44af60677740b151305799a4325d0f0699fce66]

        sw floattable: handle AllowOverlap==false in the DOC filter
        
        Map sprmTFNoAllowOverlap to
        SwFormatWrapInfluenceOnObjPos::mbAllowOverlap on import, and do the
        opposite on export.
        
        Change-Id: Id61be49adb39862e30ffb2da9ff9aabae11f7d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155650
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4403b4e6bac19d89afded080d80de049aaa294ca]

        tdf#156677 if CheckComputeDependencies failed in expanded range...
        
        it may have left a cell the original range needed in a dirty state,
        leading to an assert when the threaded calculation is attempted which
        would not have happened if the attempt to expand the range wasn't
        attempted.
        
        seen in crashtesting example: forum-mso-en4-784502.xlsx
        
        to reproduce this, load sample document
        
        after it has loaded:
        
        (gdb) break column4.cxx:1946
        (gdb) break column4.cxx:1966
        
        data, recalculate, recalculate hard,
        
        the first time breakpoint #1 gets hit:
        
        at column4.cxx:1946 NeedsInterpret is true, so cell
        {nRow = 1, nCol = 0, nTab = 3 } was dirty and is set
        not-dirty by Interpret. mxGroup->mbPartOfCycle is false
        so this returns successfully to allow threading.
        
        the bt to there was:
        
         #0  lcl_EvalDirty(mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>&, int, int, ScDocument&, boost::intrusive_ptr<ScFormulaCellGroup> const&, bool, bool, bool&, bool&)
             (rCells=..., nRow1=1, nRow2=4, rDoc=..., mxGroup=..., bThreadingDepEval=true, bSkipRunning=false, bIsDirty=@0x7fffffff4a16: true, bAllowThreading=@0x7fffffff4a17: true)
             at sc/source/core/data/column4.cxx:1963
         #1  0x00007fff9eef70d1 in ScColumn::HandleRefArrayForParallelism(int, int, boost::intrusive_ptr<ScFormulaCellGroup> const&) (this=0x15ee480, nRow1=1, nRow2=4, mxGroup=...)
             at sc/source/core/data/column4.cxx:2012
         #2  0x00007fff9f44448a in ScTable::HandleRefArrayForParallelism(short, int, int, boost::intrusive_ptr<ScFormulaCellGroup> const&)
             (this=0x1eebda0, nCol=0, nRow1=1, nRow2=4, mxGroup=...) at sc/source/core/data/table1.cxx:2567
         #3  0x00007fff9f06b691 in ScDocument::HandleRefArrayForParallelism(ScAddress const&, int, boost::intrusive_ptr<ScFormulaCellGroup> const&)
             (this=0x1ba9a40, rPos=..., nLength=4, mxGroup=...) at sc/source/core/data/document.cxx:1792
         #4  0x00007fff9f3018f7 in (anonymous namespace)::ScDependantsCalculator::DoIt() (this=0x7fffffff4eb8) at sc/source/core/data/formulacell.cxx:4585
         #5  0x00007fff9f30085a in ScFormulaCell::CheckComputeDependencies(sc::FormulaLogger::GroupScope&, bool, int, int, bool)
             (this=0x2142cf0, rScope=..., fromFirstRow=false, nStartOffset=0, nEndOffset=3, bCalcDependencyOnly=false) at sc/source/core/data/formulacell.cxx:4720
         #6  0x00007fff9f2ff392 in ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)
             (this=0x2142cf0, aScope=..., bDependencyComputed=@0x7fffffff56d7: false, bDependencyCheckFailed=@0x7fffffff56d6: false, nStartOffset=0, nEndOffset=3)
             at sc/source/core/data/formulacell.cxx:4829
        
        so the CheckComputeDependencies at the start of
        ScFormulaCell::InterpretFormulaGroupThreading is successful for aPos of
        {nRow = 1, nCol = 1, nTab = 3 } and the cell is not dirty at that point
        
        *however* in the following loop of
        for (SCCOL nCurrCol = nColStart; nCurrCol <= nColEnd; ++nCurrCol)
        in InterpretFormulaGroupThreading, CheckComputeDependencies for
        column 3 is called and the breakpoint #2 is hit, in this case
        mxGroup->mbPartOfCycle is true and the {nRow = 1, nCol = 0, nTab = 3 }
        cell is set dirty again.
        
        so later during the threaded calculation the cell is found dirty and the
        ScFormulaCell::MaybeInterpret() asserts that
        !rDocument.IsThreadedGroupCalcInProgress()
        
        Change-Id: I40385f5e8240680c220249dd2966b196efaf5e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-14  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [7e3f1e61e20dee523c7db48164c3fadbc953ed85]

        Improve accessibility warning text
        
        Instead of referring to developer-only terminology
        tell users what to do
        
        For example, Word uses the warning "Objects not inline" in this
        case and actually explains below what needs to be done
        
        Change-Id: I7650807b7520d2f10d75e1417cdf42978a31a417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155629
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2023-08-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f2c7422216f568b148ddfbe75412d605335c110]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ebdeebb9b004df574ec90ead903ffa9c9b1f3235
          - Revert "tdf#155193 Do not deliver Help files with indexer=exclude"
            
            This reverts commit 539abfa7c3bbc9f0b234402083c743890b965cf7.
            
            Reason for revert: daily builds fail to build with errors like
            ERROR: file '/home/tdf/lode/jenkins/workspace/lo_gerrit/tb/build_master/instdir/help/en-US/text/shared/autokorr/01000000.html' does not exist
            See https://ci.libreoffice.org/job/lo_daily_tb_linux_dbg/654/console
            
            Change-Id: I9d00fb2596b280bf09934dfc87db64feb8fe6a80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155600
            Tested-by: Jenkins
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
            
2023-08-14  Michael Weghorn  <m.weghorn@posteo.de>  [efadd5210e56ba67f1b040dff4972fead6a56131]

        qt: Implement pinch/zoom gesture handling
        
        Subscribe to receive pinch gestures by calling
        `QWidget::grabGesture(Qt::PinchGesture)` and
        forward that as the corresponding `SalGestureZoomEvent`.
        
        From looking at what values the gtk implementation uses,
        `1 + pPinchGesture->totalScaleFactor()` seems to be a
        proper choice for the
        `SalGestureZoomEvent::mfScaleDelta` value.
        
        With this in place, zooming in and out of a Writer
        document with a two-finger zoom gesture works for
        me with the Qt-based VCL plugins in Writer on my laptop
        that has a touch screen.
        (It seems to be a bit more smooth with qt5/kf5 than
        with qt6, where doing several zoom gestures after
        each other sometimes requires to wait a bit before
        doing another gesture in order for that one to be
        processed properly.)
        
        Qt documentation for gestures: [1]
        
        Corresponding commit for gtk VCL plugins:
        
            commit f2bd19f6720239db228cd4388be8e928505c51b6
            Author: Povilas Kanapickas <povilas@radix.lt>
            Date:   Thu Aug 25 00:18:30 2022 +0300
        
                vcl: implement touchpad zoom gesture support on gtk backend
        
        [1] https://doc.qt.io/qt-6/gestures-overview.html
        
        Change-Id: I288943d923463fee44314969648e03dca84c483f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155649
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-14  Miklos Vajna  <vmiklos@collabora.com>  [2d0f43befdaa1010062b534dffa82adad8c956c8]

        tdf#156321 ODT import: fix lost char format on outer span elements
        
        Regression from commit 209dce614c43f63f63f5b42a746665c0ec1cbfe3 (sw: fix
        ODT import of paragraph marker formatting, 2022-12-20), the bugdoc has a
        first paragraph with nested spans (the outer sets the boldness) and the
        text does not appear as bold in Writer anymore.
        
        What appears to be the problem is that our model is just a list of spans
        for a paragraph, so nesting is converted to a list of spans, but now the
        outer span char format is lost.
        
        Fix the problem by making the condition of the 'no upgrade from char
        format to para format' more strict: do this in case we have empty spans.
        That fixes this new use-case and leaves the original one fixed.
        
        Note that in the long run it may make sense to always disable the
        upgrade from char format to para format, but that has to be done in a
        way that does not break the import of nested spans.
        
        Change-Id: Ie6fafb3e9649e50790c7ecae8e136e6600f3341e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155648
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-14  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [10a87728636492afc48bbb8eee7d49f3f653293e]

        tdf#146619 Remove unused includes from sal/ [headers]
        
        Change-Id: I8fae71e5053950441a2e0920590264c2cb858924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155546
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-14  Marco Cecchetti  <marco.cecchetti@collabora.com>  [59c2e114f76247158a0da9dcf91d6449d5d61224]

        lok: a11y: when we are inside a table notify table and current cell info
        
        When we get in one or more tables we notify row and column count.
        When we get out one or more table we notify we are leaving a table.
        When the fosused cell changes we notify the new row/col index.
        The paragraph content is notified together with table info, so that
        client has some opportunity for getting the screen reader to report
        together content and table info.
        
        Change-Id: Ic524259aa1879a70fc3de2467bdee27475352b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155577
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-13  Patrick Luby  <plubius@neooffice.org>  [926c5246b6694d469a6caed5d7ea4c3a68648468]

        Related tdf#156630 and tdf#156629 force snapshot of alpha mask
        
        On macOS, with Skia/Metal or Skia/Raster with a Retina display
        (i.e. 2.0 window scale), the alpha mask gets upscaled in certain
        cases.
        
        This bug appears to be caused by pending scaling of an existing
        SkImage in the bitmap parameter. So, force the SkiaSalBitmap to
        handle its pending scaling.
        
        This change consolidates the three duplicate fixes added in the
        following commits into the AlphaMask(const Bitmap&) constructor.
        
          commit 12fd870113a663dde5ceb38c61f1986a34095d0e
          commit ce2d9f5dd4b6a26847c4779bce4866d969ff4400
        
        From my light testing, the bitmap's SkImage is not scaled except
        when running macOS with a Retina display. The only exception is
        that this fix will be triggered on all platforms when exporting
        to PDF images with an alpha mask.
        
        Change-Id: Iea5afd55aac984ca606b2b4b44e457d81d76fac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155568
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2bda87fd8758448267c447ba26f1932325a1338d]

        defer turning xlsx notes into SdrCaptions until activated
        
        to improve import performance
        
        Change-Id: I8dd3483372d20cbbb8694bae02a7d8b062324ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155613
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b2219cec9abe0ac77360ca2cc252d11d7f512e3]

        cid#1539911 Big parameter passed by value
        
        Change-Id: Ib48be194ca09c5d94253da9d725ed51bd8b71a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5374b7107648757b572249777a5a00d4ad2eaac8]

        cid#1539910 avoid Missing move assignment operator
        
        and
        
        cid#1539912 Missing move assignment operator
        cid#1539913 Missing move assignment operator
        
        Change-Id: If46cb15c20479a4a88fdfa70fe4bb662004239d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-13  Henry Castro  <hcastro@collabora.com>  [f2febdd756723a5835f98ca8cd749d51875f8bcc]

        tdf#155799: sc: fix input formula reference
        
        If the start point reference mark is selected
        with mouse direction up, it should extend to show
        the correct input formula reference.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I41f2ea52bf7de341eccadfba80e91fd76a6fd2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155618
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit f4f171506dc64a288344cb3c1eacc2c2d53283e8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155591
        Tested-by: Jenkins

2023-08-13  Regina Henschel  <rb.henschel@t-online.de>  [631964a2ce1da3fbbeb53a5550c0e6728ba644aa]

        tfd#112687 Combine adjacent lines into one shape
        
        When the user makes a 'mouse as pen' drawing in slideshow, then each
        mouse drag step generates a separate, very short two-point line. When
        the drawings were made persistent, from each of this mini lines an
        individual shape was created.
        
        Now lines, were the end point of one line equals the start point of
        the next line, were combined to a polyline. That way a drawing, which
        was drawn with one mouse drag, becomes one shape now.
        
        This does not solve, that too many of such mini lines were generated.
        But it makes it easier to handle them in edit mode.
        
        Change-Id: I8662831f309b201c049844a613877190ca0da5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155643
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6f6349a679c4aeed906115f62edf7a66d200240]

        Revert "clang-tidy bugprone-parent-virtual-call in vcl"
        
        This reverts commit 69972719542cd686687ddd91f2b5284483513608.
        
        There are some odd things gone in with some of these changes that I do understand. Reverting until I have worked it out.
        
        Change-Id: If5316654c16a697a2aff5eccdffaa5b2a6e0052d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9b5b299a5efa03aaa752e30afe960ef25305d62]

        Revert "clang-tidy bugprone-parent-virtual-call in sfx2"
        
        This reverts commit 0f3b36bd2749f360df84d1594c01e619ba0f4930.
        
        There are some odd things gone in with some of these changes that I do understand. Reverting until I have worked it out.
        
        Change-Id: Ifa383ee7ed2db4f81e2b0ac593e652288a07514f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155596
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5463f2a985937562a21c2b7c706fa004748ee5f4]

        Revert "clang-tidy bugprone-parent-virtual-call in canvas"
        
        This reverts commit eb6110aae0af9e27f71dac95274b8f3879090deb.
        
        There are some odd things gone in with some of these changes that I do understand. Reverting until I have worked it out.
        
        Change-Id: I3856b878cfaa6fd1b282a473965b2ec68779a616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ab4f4c9d5c621286cca38d103fe16ecaa4b649ab]

        Fix typo
        
        Change-Id: I7e716a9a9c93b848a332c782f75db8e02f034416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155642
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d635e73308dc6fcea9897855b5167be09f52f840]

        tdf#156686 AutoFilter arrows have white background in kf5/gen
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: Ia2248b27cbe20296fc6f96a4afc0c38e29f8750f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3cc72a1880d1fe2507892eabeb979aa0938dadc5]

        add a CreateNoteFromObjectProperties
        
        which an importer can use to insert a note and defer instantiating an
        SdrCaption until the user activates it
        
        Change-Id: I7d4afe7857d4ee9c49e7b43c5f94150b72ce9a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-12  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [4d7eab5090fd7223752920203033629b9166a030]

        Use less boost_headers in sal
        
        Change-Id: I2403143fc5c33c95755f1c7f5d6c8f9dbff23226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e6007b3be10a47b5a5382cfffa21b4106633f4b7]

        Fix typo
        
        Change-Id: Id2c317c44e6bc4e2c9d0d0e7fd830b6b414e8c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155624
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9d322bfa580839f48d2f4ce6cdd6b18c8253af85]

        Fix typo
        
        Change-Id: Icd34f01536d29c1bdee77a97311682019e6352b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155626
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [dcb3cb0bd4e4bf2bed05ae3b9d370e17a331a9b1]

        tdf#156616: check if character's parent has x or y
        
        if so, only concatenate the characters that are in the same line
        so the alignment will be calculated based on the
        line's width
        
        Change-Id: I704370c0a470f8b4cff97c51ad9863158118ee8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155636
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f3b36bd2749f360df84d1594c01e619ba0f4930]

        clang-tidy bugprone-parent-virtual-call in sfx2
        
        Change-Id: Id1e32a696dd97d1bded467834e5fbd14345d02c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-12  Justin Luth  <jluth@mail.com>  [f1c3526dee49927f7efb79bef285e3688264ec3f]

        tdf#137878 autorecovery: reduce "file not found" pop-ups
        
        For a DOCX file, there were four of them during a recovery
        if the file was on a USB or renamed or whatever.
        
        Now there aren't any.
        
        Change-Id: I5cbad6e4ed1a1bc1d3b8e805a6b493f4ee61ec68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155567
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [166d3f204aad40f2cd023e4860200182dbe48d8f]

        Get LOKDocumentFocusListener to handle enable/disable a11y properly
        
        This patch fix the following problems:
        - Remove all children when accessibility is disabled
        - Update the currently focused paragraph when accessibility is enabled
        
        Change-Id: Ib65a14052ee8e0f965c0546897fd67641bba50ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155576
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb6110aae0af9e27f71dac95274b8f3879090deb]

        clang-tidy bugprone-parent-virtual-call in canvas
        
        Change-Id: Ibaaec56e7cb42d113be07bb719de3534de24833c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cf686f4586fb0a94643efdde1c36ddd714d7479c]

        Fix typo
        
        Change-Id: I0336d39dd003f18383326b3f7806597612edf755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155623
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [9de08c6f8f2b4150da628fe3e9311f5dc64137b0]

        lok: a11y: get focused paragraph notified on document load
        
        Usually, when the document is loaded, a CARET_CHANGED accessibility
        event is automatically emitted for the first paragraph. That allows to
        notify the paragraph content to the client, even if no input event
        occurred yet. However, in Cypress tests no accessibility event is
        automatically emitted until some input event occurs. So we use the
        workaround in this patch to notify the content of the focused
        paragraph, without waiting for an input event.
        
        (cherry picked from commit d6f929c03ca08a0c1134937a1ff1a42f75221e93)
        
        Change-Id: I8696c5f9ea069824614e9b541f4959b315dbda5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155575
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [69972719542cd686687ddd91f2b5284483513608]

        clang-tidy bugprone-parent-virtual-call in vcl
        
        Change-Id: I270bb35f577cc1ee56233c585665478cbaab9085
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ac40c3923580e4ec0e738d57ff8b885da93301ef]

        split out a common CreateNoteData
        
        Change-Id: Ieeaf50f3a086d01b5492eb3ab9b211f132f045ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5ae486eea7a381403a9f81e5aa8ef1a0a57b95b6]

        split out common ScPostIt insertion piece
        
        Change-Id: Ie9d718293f907e19e29ed6f8aea4a2bf9d88dfe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155610
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e11a0e646b8eb75e102f878dc70f5196c4efbea2]

        rearrange to collect the properties set on the annotation together
        
        and set them in one block. No behavior change intended.
        
        note: type passed as TextFitToSize seems to be wrong
        Change-Id: I349aeba5176ef6c10163069a73d0367469aadd6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155588
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6945d031e759823ab52bdf077e43196b67f594a4]

        move setting properties into note comments from oox to sc
        
        no change in behavior intended, the SdrCaption doesn't support
        the skipped conditions
        
        Change-Id: Id909ae4ed115c1ad3398d2a62c6432ff1dfde453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c88855c45a675cf28e2cfe4fa261c2b0339f5898]

        split ShapeBase::convertShapeProperties into two parts
        
        Change-Id: I62f42e54c776f15ea83c5fc861bb4f4ff899e891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155584
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5aeb15e95d26ce6de28eb5f5933324828d553f41]

        refactor to return the position to be set by the caller instead
        
        no change in behavior intended
        
        Change-Id: I32043bdf1d29521d8503df315fa786236e272f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155580
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [de20853e5243843ac9f4c5927ce0b4cf0e407c15]

        xlsx with a lot of comments repeatedly calls OutputDevice::HasGlyphs
        
        on the same font over and over again getting the same results
        
        Change-Id: I0c301e3fd4c1838645c25d4f6f7b330acc988135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4db0a2c1c3b0a9c9868574b5c538bfd92adfb48a]

        cid#1539807 Uninitialized pointer field
        
        Change-Id: I500c5d9f15c6a57622a28ea7cbf3b5f90761b5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155582
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fa3cfa7ac8b9000aec943e13dc75f8d3828685b4]

        cid#1539806 Dereference after null check
        
        Change-Id: I5fe74e633e8374eb38cf39f5989f7d2e696e445e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155581
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab4de498475930ba829a23262f82e32df36f1ea2]

        fix SfxBroadcaster::ForAllListeners
        
        regression from
            commit 7c66fc45239d2589e90fd694d54b3ff826b1bd15
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 1 14:22:57 2023 +0200
            use internal iterator for SfxBroadcaster
        
        Change-Id: Ibd3abf23337c8fb0937d245474f2b89c8936a3ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-11  Marco Cecchetti  <marco.cecchetti@collabora.com>  [5964796de82a4050081d25ab20151020de0a16cc]

        lok: a11y: paragraph notifyied on text change, even coming from another view
        
        Debug code has been re-organized.
        Paragraph content is notifyied on any text change.
        That fixed issues related to fast typing.
        Paragraph content is also notified on text changed performed in
        another view.
        A paragraph is regarded as focused whenever the cursor position is
        valid.
        
        (cherry picked from commit cd726ba43c22e723b243dd6dfd5e3c253e81000b)
        
        Conflicts:
        	sfx2/source/view/viewsh.cxx
        
        Change-Id: I33a187ced368b74824e55265be921804a492349c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155574
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [996890180dc143df1de97072c81799ec1f1de083]

        reduce noise in debug logs
        
        Only set this property if the object supports it
        
        Change-Id: If3adf76bbab5393e20a685b1af5016624c28fa79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-11  Miklos Vajna  <vmiklos@collabora.com>  [5af44a176d2a738dd7523713202aeee27c5578b6]

        sw floattable: export <w:tblOverlap w:val=never> to DOCX
        
        Once split flys containing tables have "allow overlap" disabled, this is
        not saved to DOCX when we map them to floating tables.
        
        The working case is the allowOverlap attribute on shapes, added in
        commit f8c7a2284b88c149addc8a30abb0cad8a10dad77 (Related: tdf#124600 sw
        anchored object allow overlap: add DOCX filter, 2019-09-20).
        
        Fix the problem by extending DocxAttributeOutput::TableDefinition(), to
        write <w:tblOverlap> in case overlap is not allowed, after <w:tblpPr>.
        
        DOC and RTF filters are still missing.
        
        Change-Id: I7d0bd4a15567014d3add8cbbcd92c62c5a33b7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155573
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5484657d2b1677b7e385ab6ef87ad64dcb9934e4]

        tdf#156209 Font size increases when copying from cell in edit mode
        
        Regression from  0558926c2f9201a12b4c46efc36b8a4080af4d46
        "use more officecfg for SvtMiscOptions".
        
        However.... even reverting the above commit does not fix the problem.
        This is because there is an underlying latent bug, where depending on the order of initialisation of various and when they fire events, we can end up calling the alternative path in ScInputHandler::ImplCreateEditEngine which creates a pool via EditEngine::CreatePool(), which ends up having the "wrong" default map unit. And then that pool sticks around even after we have a document, and causes the reported bug.
        
        Solve it by simply not initialising the pool until we have an associated document, which is fine, since we don't actually need the pool until then.
        
        
        Change-Id: If012c82df225e59dca828556bfca84c1948b5887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155560
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-11  Miklos Vajna  <vmiklos@collabora.com>  [af4341a0262352efecd772a7390fb2cff544564b]

        sw: fold SwTabFrame::dumpAsXmlAttributes() into dumpAsXml()
        
        One dumpAsXml() per SwFrame subclass is enough, no need to have a
        separate function that dumps just the attributes.
        
        Change-Id: I7341e6a2c71c9a3596f70397c4450206222b76f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155572
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-11  Paris Oplopoios  <paris.oplopoios@collabora.com>  [b29769bfab386c9d56e72c4e9c9ec5abeb09eb46]

        Initial APNG export support
        
        Change-Id: I27877d4bdf27cd92bdd939fd25e3820edad10f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155387
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-11  Justin Luth  <jluth@mail.com>  [47cff47966ea2876765bdfb2dfb83eaeb1db1e1a]

        autorecovery: DLG_RET_OK_AUTOLUNCH => DLG_RET_OK_AUTOLAUNCH
        
        Change-Id: I3f1436fa1b8ff5b34c65b103b0dd26dffc0e558d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155566
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-11  Justin Luth  <jluth@mail.com>  [3b81780ae907046b667282b051281888ef00d210]

        autorecovery: add some documentation
        
        Change-Id: I9a037e263ecdc374df9450ee9a066468dc6ab5e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155426
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-10  Justin Luth  <jluth@mail.com>  [c3cb2f956d760ba6ddd9a882e952b2bd7c1af145]

        partial Revert "tdf#144512 autorecovery: always wait for user idle...
        
        ... with timed save" in order to restore useful comments
        
        This reverts 24.2 commit 75d7464e7eb94df1ad9904ad750b27d99d91abc5,
        where the ResettableMutexGuard's safety is cancelled by a g.clear()
          // } /* SAFE */
        and re-instated with a g.reset()
          // /* SAFE */ {
        
        Thanks Mike for explaining the obvious to me.
        
        Change-Id: I98016a50221b734a38d14bce0a958c6af9e57944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155514
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc5aae69934000d81492668b3a40889bba5d3099]

        tdf#156270: use double for width/height
        
        Otherwise 0.313159 is rounded to 0
        
        Regression from
            commit 99f43923b66a98b75c78a50577f19293aa480998
            Author: Xisco Fauli <xiscofauli@libreoffice.org>
            Date:   Tue Apr 18 14:37:32 2023 +0200
        
            sw: fix divide by 0
        
        Change-Id: Ib8bf0a770834e0ff73d215c27788df7a3b98404d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155561
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-10  Henry Castro  <hcastro@collabora.com>  [e4e080086e76a0bedd7ce62dc610889dc5c86401]

        tdf#155799: sc: fix paint the reference mark
        
        If a reference mark is initiated with the first click,
        the initial range points are the same and extended
        if merged cells, but if the user drag&drop more cells
        the Range end has to extend if merged cells
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ife7c4514a9303226b73bff61bd0df689f81af42f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155533
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit ebd1a4d6fc3f9ba533a29fa54acf7b3b41c398d5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155483
        Tested-by: Jenkins

2023-08-10  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [23d1395a7856119173b37a6d787171f519554623]

        ITEM: improve SfxItemSet notification callback
        
        When browsing cachegrind data I stumbled over the notification
        callback used by Writer in SfxItemSet::Changed. That is a
        virtual method that gets called in quite some places to forward
        item changes, SW uses it to record these.
        For that purpose always (quite some) data gets prepared without
        checking if this is necessary, this uses calls to ::Get and
        ::GetDefaultItem to have either the old or new Item from the
        parent or default (pool).
        This is not needed - except for Writer. Even there this
        mechanism is not always active. Thus I:
        
        - removed SfxItemSet::Changed, replaced with a settable callback
        member of type std::function<...>. Thus one less virtual function
        and depenence in SfxItemSet
        - added a callback functor to SwAttrSet that can be set at the
        SfxItemSet it is derived from
        - setting/releasing this only in used cases. It is not even used
        all the time in SW.
        - moved the creation/processing of needed data to a member
        function in SW (SwAttrSet::changeCallback). All processing and
        evtl. needed data is now created there - on demand.
        - adapted all places in SfxItemSet where that mechanism is used
        to only call it if set & without pre-calculating anything
        - since all former calls/usages were pretty similar I could put
        all of this to SwAttrSet::changeCallback
        
        This leads to use that only when needed now. Naturally, SW will
        potentially profit less than the other apps.
        
        Here are callgrind numbers with this change using OfficeStart,
        DocLoad, DocClose, OfficeShutdown. This change also has potential
        avantages @runtime/UI which also did all preparations to call
        SfxItemSet::Changed all the time:
        
        Writer doc: 0,9907 ~1%
        old: 93842 mio
        new: 92971 mio
        
        Draw/Impress doc: 0,9971 ~2,8%
        old: 170023 mio
        new: 169544 mio
        ::Get reduces from 1416103 to 293874 calls
        ::GetDefaultItem reduces from 2252336 to 1927209 calls (nearly half)
        
        Calc doc: 0.9868 ~1,3%
        old: 194708 mio
        new: 192130 mio
        ::Get reduces from 882298 to 880087 calls
        ::GetDefaultItem reduces from 4611901 to 2633555 calls (nearly half)
        
        Of course this highly depends on the used test documents, so it can
        only be a excerpt result.
        
        Also adapted SfxItemSet::MergeRange a little bit: Do nothing not only
        when a single new slot is already contaioned, but check if all slots
        are already present. This works well and fast using the formally added
        caching mechanism.
        
        Change-Id: I4d369d2e5b21aa7a21687177518150515e3de954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155559
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-08-10  Patrick Luby  <plubius@neooffice.org>  [ce2d9f5dd4b6a26847c4779bce4866d969ff4400]

        Related tdf#156629 force snapshot of alpha mask
        
        On macOS, with Skia/Metal with a Retina display (i.e. 2.0 window
        scale), the alpha mask gets upscaled for the font color and the
        character background color icons in Writer's properties sidebar
        with most icon sets. The Breeze and Colibre icon sets running in
        light mode are the most obvious cases.
        
        This bug appears to be caused by asynchronous rendering of the
        returned image. So, we force a copy of the alpha mask in case it
        changes before the image is actually drawn.
        
        Change-Id: Ie3aa3b26acaee4bd9173e6b356137980c070c7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155562
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-10  László Németh  <nemeth@numbertext.org>  [8258a70a7ca596a8ce5ff417f312a99a96694bed]

        tdf#156492 sw: fix alt-Enter in cells merged vertically
        
        Inserting empty paragragh after the tables didn't work,
        if the bottom right corner of the table contains cells
        merged vertically.
        
        Manual test: positionate the text cursor at the end
        of the last paragraph of the bottom right cell of the
        table (which contains also cells merged vertically), and
        press alt-Enter to insert an empty paragraph after the
        table.
        
        Note: SpecialInsert, i.e. inserting empty paragraph by pressing
        alt-Enter is the quick and sometimes the only possible way to insert
        an empty paragraph before or after tables and sections.
        
        Change-Id: Ic845c3d683a561784afe69588b3b1538e82c35c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155556
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad3d6732dc8905b1660fa25147a00024b0ac0cd0]

        related: tdf#151103: simplify code
        
        Keep the text line in the SvgTextNode and not in each
        SvgCharacterNode
        
        Change-Id: Ia33e46cc974a39a915e7b933337b4c529e6eeca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155558
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [fff601edf76b1783c5a47353452a83ac9c5ac07a]

        svgio: move SvgTextPosition to its own file
        
        In order to avoid a circular dependency in a follow-up commit
        
        Change-Id: Ib7b16e73282dfa6f3ca87aab1044cb92df72b6bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155555
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f656a057e2a92e2107f7820fc563498c801d7d3]

        svgio: handle addGap internally inside SvgCharacterNode
        
        Also add the gap at the beginning of the current node,
        not at the end of the previous one
        
        Change-Id: I6583059b4a7418010ac2af459e00fb0d02d39605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155552
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b54f61e2c969a547582f759803f3c4f80d44697]

        svgio: avoid dynamic_cast
        
        Change-Id: I9a2e2c4341476a59ffb001c42e7812cb8249c856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155548
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [058a9522e067ac7a49a13797fc0f13269967bf24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a78e5c75ae11f7c401353e526a30f16187cc1f92
          - tdf#156715 Housekeeping on files that must not be indexed
            
            Change-Id: I5dfbc2e3261d66cc81964b3f88d08420c7b5e72a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155557
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-10  Khaled Hosny  <khaled@libreoffice.org>  [25b2e4a4e2f9b2191bdd80cca5a015e5b6089399]

        tdf#32415: Always accept English symbol names in math
        
        If symbol name does not match localized names, try to find a match using
        English (export) names.
        
        Change-Id: Id668ee68b07c8431c2780b78e26e07d3aef043aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155553
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-10  Miklos Vajna  <vmiklos@collabora.com>  [d7cd82948a4afe0f2049acaf68890d22f14e4396]

        sw: improve naming of ApoTestResults members
        
        - Sp29 -> PPc or TPc (paragraph or table position code)
        - Sp37 -> PWr (paragraph wrap)
        
        Change-Id: I49400cc325e9981586490f5221a6a5f5d59c0084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155554
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-10  Patrick Luby  <plubius@neooffice.org>  [12fd870113a663dde5ceb38c61f1986a34095d0e]

        tdf#156630 eliminate opaque parts when drawing animated PNG images
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, flip the background colors
        for the VirtualDevices and invert an alpha mask.
        
        On macOS, with Skia/Raster with a Retina display (i.e.  2.0 window
        scale), the alpha mask gets upscaled. Also, when Skia is enabled,
        the alpha mask gets inverted in the first export to PDF after
        launching the application. These two bugs appear to be caused by
        asynchronous rendering of the returned bitmap. So, we force a copy
        of the alpha mask in case it changes before the bitmap is actually
        drawn.
        
        Lastly, respect system animation settings when determining if the image
        should be animated.
        
        Change-Id: I8144691a6c99bf8361b301b88d22172991463f26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155429
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [0d8a5f89bff51480d721395729a67e7b4260aea5]

        Simplify conversion, and fix a comment
        
        Change-Id: I0a952b26e486dcfdedf586e33afa6771b480ac65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155540
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-10  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [f8127bced4934f6a8ede39fb076beebf4c49f24e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfda7b1348f262821f25d18d8f275602cb57bb25
          - tdf#142705 consistent order of keys for shortcuts
            
            Change-Id: Iffb7c5e5cb872eb5e2c1bfcbdf5e83357e7896fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155476
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-10  Khaled Hosny  <khaled@libreoffice.org>  [ca78e610e1a4d20021d204c3d7857e6edb591fa6]

        tdf#80467: Fix math rendering in elements dock with RTL UI
        
        Make sure to disable RTL on the OutputDevice, otherwise the math will be
        rendered right-to-left without even mirroring the parenthesis.
        
        Change-Id: Iea43dbc0d7efe914120d5cc1605522254344b4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155538
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fc7e8394c1c5ad080e5df9cf3325e1708c177acd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 539abfa7c3bbc9f0b234402083c743890b965cf7
          - tdf#155193 Do not deliver Help files with indexer=exclude
            
            + Add condition to skip indexer=exclude files.
            + delete empty files generated by exclude
            + delete empty directories generated by exclude
            
            Change-Id: Id992e6c83086d3cd3911b84890a50b309ad92c3b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151897
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [81c535c18af1f7aafda2822aabcce5658289736b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfca100198e690f05987033bcd2b74e9057bcf8d
          - tdf#155462 Help for tool tips when dragging scrollbars
            
            Change-Id: I6ded8c8a2e463154cac8c2b7602eda7dcd70dfe7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155525
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d190758ecee87c2d5d3944e40c4cca6850ce7fd2]

        tdf#156594 - A11Y - add fix button for "Avoid background images."
        
        - add fix button for "Avoid background images."
        - add .uno:PageAreaDialog command to navigate page style-->Area tab
        
        Change-Id: Ibad4e8896d05e72713189a0042c3f156a0733171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155464
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2023-08-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8112e3dae2550acc43e064a69759ddbf7993142b]

        tdf#156619 - A11Y - fix not clickable warning about content control
        
        in header/footer. Goto content controls in header and footer.
        
        Change-Id: I1e7eda0e9ab73a94d3f4963630901ff6701b521f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155535
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-10  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [750f60174ea0dacf1cf007cd67eb70acd83fe649]

        Related tdf#156614 Improve wording of non-interactive forms text
        
        Change-Id: I063cb144a7d94e15e9405135ad321d9f2e74d414
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155534
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-10  Miklos Vajna  <vmiklos@collabora.com>  [905962db870e9d1cf1dcf3bd1be44c347cddafe1]

        sw floattable: handle AllowOverlap==false in the layout
        
        The bugdoc has two floating tables, and these would normally overlap,
        but SwFormatWrapInfluenceOnObjPos::mbAllowOverlap requests tweaking the
        position at a layout level to avoid that overlap.
        
        This is similar to what commit d37096f59e7e0286e55008153591a60bab92b9e8
        (Related: tdf#124600 sw anchored object allow overlap: add layout,
        2019-09-19) did, but that was for draw shapes and this is for split
        flys.
        
        Fix the problem by extending
        SwToContentAnchoredObjectPosition::CalcOverlap(): the overlap detection
        can be reused, just need to look for split flys on the entire page +
        need to check split flys against other split flys.
        
        The ODT filter works out of the box.
        
        Change-Id: Id31308a67ba502bcc830f15a1679996ec153f209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155536
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0d2fc6c053cad80c685755d030c6b57202f78d50]

        tdf#156553 tdf#156554 A11Y: fix issue update after image deletion
        
        Reset accessibility check issues when deleting graphic/ole nodes.
        
        Change-Id: I5f0698f6cf9e97045be22482de64518ab22d5946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155355
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2d0268f5ae6061bc96c00481c9ef3547be300b5a]

        tdf#156615 - A11Y - fix not clickable warning about empty table cells
        
        Make "Empty table cells for formatting" warning clickable and go to the
        table.
        
        Change-Id: I65a258cd559b423692307af9bbbb778754076894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155532
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-10  Miklos Vajna  <vmiklos@collabora.com>  [bad71a9d92eeb06916aad820b6b8cb3f1144e082]

        UITest_librelogo: use oneprocess mode
        
        Before: 0m22,417s
        
        After: 0m18,233s
        
        Also UITest_sw_fieldDialog: 0m34,065s -> 0m23,113s
        
        And UITest_sw_options: 0m38,468s -> 0m32,033s
        
        Change-Id: I709205bb8ebe55fe71bc2713d9443b672380b9b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155530
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7c8c71ecf7dc3d86ebe783de8f4886c0d8b896f0]

        tdf#156614 - A11Y - fix not clickable warning about fake forms
        
        Make the warning message clickable and select the text.
        
        Change-Id: I5b503ba278980c128bbef83631dabc897bb33b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155519
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-08-09  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [218a7650a5cf03f895bed19c68d6f02daec536e9]

        tdf#146619 Remove unused includes from sal/ [system.hxx]
        
        Change-Id: I30f3ce338e86f1a6dad5e16023ce4c883079fbcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155351
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [c1d690d8c478a9d2692a89cbb982b59df5438972]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I34a8ec2f69d9d58f8847e9cfb45937eae6159590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [b321cf78808f918669139793a65a3bf4908faa46]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I2c89096c306e1537622fc52644d20ae605183b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [d955016f31069b51761b7fe56d62aa2a44d7beda]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I09285716b6d17d8de95af91d822966520af35605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Mike Kaganski  <mike.kaganski@collabora.com>  [4aa3cfda7a6007867eba922a1b549471cbced425]

        tdf#120715: handle LOK case
        
        Commit 690d4eb71509649ad147cfe60f5b97e2cfaaa519 fixed the two problems
        of wrong paragraph mark position and wrong cursor position, calling
        AddExtraBlankWidth from SwTextPainter::DrawTextLine. Since this function
        is called before calculating cursor position in desktop case, this fixed
        them both: SwCursorShell::EndAction calls SwViewShell::EndAction before
        UpdateCursor; the former calls ImplEndAction, and in it, PaintSwFrame is
        called when not in LOK mode.
        
        But in LOK mode, PaintSwFrame is not called until SwViewShell::PaintTile
        runs in a later request; thus, UpdateCursor operated on unadjusted data.
        The cursor position arrived wrong, but the paragraph mark was painted OK
        when tiles were rendered.
        
        To avoid dependency on the call order, also call AddExtraBlankWidth from
        SwTextCursor::GetCharRect, which is called inside UpdateCursor.
        
        Change-Id: I0984d7c6235a7f2573f9fa8b7ed0cefee5747658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155531
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e4d10dcfbeeeb997bf93145da2326514ffcfad3]

        svgio: get rid of SvgTextPositions
        
        and make SvgText inherit from SvgTspan
        
        Change-Id: Ief25e52ba2a493936f82f1674f73168ed5647278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155521
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [9346f31f39586445b0547a4810d11ebe3884e0e3]

        svgio: remove recurrent checks
        
        Change-Id: I26c37e6b58e7c54e2bdc2c77543896daceb638d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155520
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-09  Mike Kaganski  <mike.kaganski@collabora.com>  [8a0c43fa86bd32b4d47fd7e46d3ed414c9282ffa]

        Use _beginthreadex instead of CreateThread
        
        The documentation for ExitThread [1] has this comment:
        
          A thread in an executable that calls the C run-time library (CRT) should use
          the _beginthreadex and _endthreadex functions for thread management rather
          than CreateThread and ExitThread; this requires the use of the multithreaded
          version of the CRT. If a thread created using CreateThread calls the CRT,
          the CRT may terminate the process in low-memory conditions.
        
        Since ~all our code uses CRT, be safe and use _beginthreadex.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createthread
        
        Change-Id: If3e566592e921b00240e08aa759d8cdbc421d44b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155513
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [da54fbce1c9101925059b980a0d9fe441bf0461f]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I2869e115941b3e1f52911d58d54ec1b2831d0524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155524
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [55c0d6caec990ed2d5433251bfed9c51d1207e47]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: Id94c6615f857f3ad3497b1abef1e1f2bd67bd4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [9a1de2cfdf2ac4d43d465556390025b427ddb688]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: I0752d158c648f6ebfa17c9273bab2176e1ca6c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155518
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  László Németh  <nemeth@numbertext.org>  [f65c04b2b32a9e00dd05a16614b4dedb86171c97]

        tdf#156487 sw tracked table column: fix Hide Changes
        
        In Hide Changes mode, deleting table columns with change tracking
        wasn't applied on the table layout immediately, only using Show
        Changes and Hide Changes again. Now the deleted column removed from
        the table instead leaving an empty table column.
        
        Also revert commit 33058b5dc47a140516669945efbdd30ea65138a6
        "tdf#156544 sw tracked table column: delete empty column".
        
        See also commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes".
        
        Change-Id: If03d2bc5996a168cb44839b0753effb9031edbc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155522
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-09  Noel Grandin  <noelgrandin@gmail.com>  [c9da81db9684cc3d83bd25fcae5ed2bed5401550]

        use sal_uInt64 when dealing with stream position
        
        Change-Id: Ibb8637e4648f56d7f9895a31df006915df8f8fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155517
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [b5a41467efdce02b80ffe3824fdefe9fbc01fc95]

        tdf#147938 sw_redlinehide: move fix into SwNodes::UndoTableOfText()
        
        Reproducing tdf#151866 on the .odt attachment, it becomes clear that the
        fix for tdf#147938 is in the wrong place.
        
        There a node has the merge flag None although it is the last node of a
        merge, because CheckParaRedlineMerge() first sets the node flags and
        then calls DelFrames(), which now resets the flags.
        
        In case there's another caller of DelFrames() that needs this, it's not
        obvious, can be added later.
        
        (regression from commit 5b55ccfd384d3c0c11e05f22bd7e956b4bc7e43a)
        
        Change-Id: Iba0cb83260ecb18a4b96ded20a95b2b20d696fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155516
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [1ba5f6682c2eaf46cbe6447125aaed5f87edeb34]

        wina11y: Drop "#CHECK#" comments
        
        ... and "#CHECK XInterface#" comments;
        it's obvious that this is what the next lines do.
        
        Change-Id: I09234d1a2f5c58cfab1580f188229d28d27fc402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155506
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [63a004f51f063cad68c007d79d5cd4f56adde96b]

        wina11y: Use return value instead of out param
        
        ... to return the `IAccessible*` in
        `AccObjectWinManager::GetIAccessibleFromXAccessible` and
        `CMAccessible::get_IAccessibleFromXAccessible` and adapt
        the call sites accordingly.
        This is more straight-forward and the extra bool return
        value didn't add anything, since it was also just
        saying whether the pointer was a nullptr, so rather
        check that directly.
        
        Also drop `AccObjectWinManager::GetIMAccByXAcc` that
        does the same thing and switch the only call site
        to use `AccObjectWinManager::GetIAccessibleFromXAccessible`
        instead.
        
        Change-Id: I72933df62aa9ac1ff3f2a84c5045dfae354c18e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155505
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-09  Jean-Pierre Ledure  <jp@ledure.be>  [d2c1a4fa508572cc2908787deeebc5baa9d6e0c3]

        SCriptForge (SFDatabases) manage database credentials
        
        When not embedded, databases usually
        require user and password to grant
        access to scripts.
        
        When the access was refused, so far the
        execution was stopped brutally with an
        error message provided by LO internal
        code.
        This was made visible during some tests
        with a MySql database server.
        
        The code to be reviewed is located in the
        creation of the "database" service. This
        service has the sungularity that it can
        be called from several other service
        instances.
        
        As from this commit unsuccessful tentatives
        to login to a database from code are
        rejected with a clean SF error message.
        
        The different scenarios to create a
        database service have been (re)tested.
        
        Change-Id: I695d108242872d27671688af76916784908aeebe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155507
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-08-09  Khaled Hosny  <khaled@libreoffice.org>  [3b7eb222411da48a9b7a585b39ef7a240f6222bc]

        vcl: Organize CoreText font code a bit
        
        The code was all over the place with classes split between files or
        grouped in some files and I couldn’t make a head or tail of it. Move
        each class to a dedicated source/header file.
        
        Change-Id: I35daa05b4684c13339c637819dc30fa47a60cf65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155503
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-09  Justin Luth  <jluth@mail.com>  [90b23d0b4528a12ababa3c2897ab3f1a3719b2f1]

        tdf#144512 autorecovery: always wait for user idle with timed save
        
        Only the "active" document was waiting for a user idle.
        But that doesn't make sense because the background apps
        still lock the foreground app during file save.
        
        So all timed backups should wait for a user idle period
        before starting their recovery / autosave.
        
        Once an idle loop is triggered, no autosave will ever run again
        until an idle timeout occurs! So a busy user who switches from
        one doc to another without ever pausing still wouldn't ever
        get a backup - even from the background docs!
        
        Without this patch, only the first modified documents
        (if backgrounded within 10 minutes) would ever
        get a recovery save. So in pretty much every case
        this patch makes sense AFAICS.
        
        Change-Id: I6e9e04aa2e50895e53826b427cb52c129da43701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155459
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [13eb63f377f46a61bc763ab0f40eb6769dcefbb8]

        Resolves: tdf#156661 only set a fixed height for the single row case
        
        of the insert special character dialog. The character popdown uses
        multiple rows instead.
        
        Change-Id: If3c5578a018a31dbdb0a0d9785f18b570e13112f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [2f9e67d1e70bdc45dfc59554547bc3730481a757]

        tdf#151866 sw: layout: prevent deleting newly created SwSectionFrame
        
        A section frame is created so that content can move back from another
        page into it.
        
        Apparently only the pPrv frame is on the same page, and formatting it in
        SwFrame::MakePos() moves it backward, then CheckPageDescs() sees a page
        with only empty section frames on it and deletes the whole page.
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: I4f8e4debd4bcf993c9355dcfc3ced779fe6732ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155467
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-09  Hossein  <hossein@libreoffice.org>  [0c9f095a01682d8cb99a596e568bd81ae96906a5]

        tdf#155446 Fix problem with ccache on Windows
        
        This patch fixes the recent problem with building LibreOffice with ccache
        on Windows which was caused by the lack of double quotation mark between
        ccache.exe and path to the MSVC compiler.
        
        Change-Id: I1a714513ccb8cd674895d0c887013ea862d3b544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152277
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-08-09  sahil  <gautamsahil1947@gmail.com>  [a00cf4bc779b1da85423371fec43f8638c77e423]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: I0ba6e7c1e128f3216eb3b77246c659a728df1324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155011
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-08-09  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [af3e5bef6c4e6b3158a7ab5a97c22909a7a1faa5]

        openldap: upgrade to release 2.6.6
        
        * remove Wint-conversion.patch and configure-c99.patch, which were fixed upstream.
        
        Change-Id: Ia93b0190e60ab3420fe79c5446f22a1573b1ea6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155441
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-08-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [954b8253b798d0c1fe37806dc773ce0128bde785]

        ofz: Integer-overflow Tell() returns sal_uInt64 not sal_Int32
        
        Change-Id: Ib17cc045316d468be306a678ddb9b2b4b08f6f4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155497
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-09  Miklos Vajna  <vmiklos@collabora.com>  [d3a0ff741f5a7ff0dcec301e5b34ee9d638acf98]

        sw floattable: import <w:tblOverlap w:val="never"> from DOCX
        
        The bugdoc has 2 floating tables, the second one is shifted down in
        Word, so it doesn't overlap, even if the positioning attributes would
        lay them out with an overlap.
        
        The bugdoc has <w:tblOverlap w:val="never"> set for the second table, we
        can import that to Writer's
        SwFormatWrapInfluenceOnObjPos::mbAllowOverlap, which was originally
        added for shapes.
        
        writerfilter/ only has access to the UNO API, so do this via the
        AllowOverlap text frame property.
        
        The layout is still missing for this, but now the doc model is correct.
        
        Change-Id: I25df9b75633c05af206b94ff0ad71bd240f393f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155499
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-09  Miklos Vajna  <vmiklos@collabora.com>  [84e39fb0540aae504beb0e8a3ac29d0e7f6f2426]

        CppunitTest_sw_htmlexport: drop single-use DECLARE_HTMLEXPORT_ROUNDTRIP_TEST
        
        Which means what the test actually does is now not hidden behind a
        custom macro.
        
        Change-Id: I75d2429dab899ab44f41c9930adbe66f09cacefd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155468
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3dcf2acadb847ec76d7e1dff3b4b730a64b52c41]

        sc: fix tiledrendering test execution order issue with comment IDs
        
        ScPostIt::mnLastPostItId is a static variable, which is used for
        generated the comment ID. In the test we depend that the ID are
        consistent and start with 1, but as we have more tests that insert
        comments this can be a problem.
        
        testCommentCallback and testCommentCellCopyPaste, both add comments
        and the expected execution order is testCommentCallback and then
        testCommentCellCopyPaste, so the latter test resets the mnLastPostItId
        variable to 1, so the IDs are consistent. In a LO 7.6 build for
        Fedora, it happened that the testCommentCellCopyPaste was executed
        first and testCommentCallback afterwards, but in testCommentCallback
        we do not reset the mnLastPostItId and the build failed.
        
        This change resets the mnLastPostItId also in testCommentCallback.
        
        Change-Id: I123b2f47b0d6177b2f5bdefcf6d8e9c301a7413b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155498
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [d1d07992a89ba503f1d457a8f79926063f4d3f9c]

        tdf#156679 wina11y: Convert screen to local coords as needed
        
        When `AccTextBase::get_offsetAtPoint` gets called with
        screen coordinates, convert them to local coordinates
        within the text object first, because that is what
        `XAccessibleText::getIndexAtPoint` expects.
        
        Not doing so resulted in NVDA failing to create
        a TextInfo object in the mouse event handler [1]
        when hovering over a Calc cell containing text,
        because the method would always return an offset
        of -1.
        
        With this change in place, NVDA now announces the
        text when hovering over the text and mouse tracking
        is enabled in NVDA (which is the case by default).
        Other than with Microsoft Excel, the text is only
        announced when the mouse is actually over the text,
        not over free space in the cell, which might be
        because Excel uses UIA and the UIA equivalent,
        `ITextProvider::RangeFromPoint` [2] shall also return
        the index of the closest character when the point
        itself is not over the actual bounds of any
        character.
        
        [1] https://github.com/nvaccess/nvda/blob/a198c9b5f27e47ff2830f77c833eec584078dfd8/source/NVDAObjects/__init__.py#L1209
        [2] https://learn.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-itextprovider-rangefrompoint
        
        Change-Id: I1e4ab2dd3dace5fea1de2eef67a91fe3c31218a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155492
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [39302875c27d4cf4246bb7520ed90abcf0af777a]

        tdf#156679 wina11y: Implement accHitTest via UNO equivalent
        
        Instead of manually iterating over the children
        and checking whether the given position is in the location
        that they're in in `CMAccessible::accHitTest`, use
        `XAccessibleComponent::XAccessibleComponent`, which
        provides exactly the functionality that's needed.
        (This is similar to what the Qt-based VCL plugins
        on Linux do, s. `QtAccessibleWidget::childAt`.)
        
        This also drops the need to limit this to objects
        that have at most a certain amount of children
        for performance reasons (previously 256) and thus
        makes this work e.g. also to identify a Calc cell
        that the mouse pointer is currently over while previously
        the document was returned, as could be seen also in
        NVDA's Python console:
        
        1) start NVDA
        2) hover over a Calc cell
        3) press NVDA+Ctrl+Z to capture snapshot variables
        4) check what NVDA identifies as the mouse object
           via the Python Console:
        
        Before:
        
            >>> mouse
            <NVDAObjects.IAccessible.IAccessible object at 0x00FB9910>
            >>> mouse.name
            'Untitled 1 - LibreOfficeDev Spreadsheets'
            >>> mouse.role
            <Role.DOCUMENT: 52>
        
        With this change in place:
        
            >>> mouse
            <NVDAObjects.Dynamic_SymphonyIATableCellEditableTextWithAutoSelectDetectionIAccessible object at 0x0774DD10>
            >>> mouse.name
            >>> mouse.role
            <Role.TABLECELL: 29>
        
        The cell's text still isn't announced by NVDA even
        with mouse tracking enabled, but that's another issue.
        
        Change-Id: Ib821020cef6303ab786c4c3fc3ccd917398214f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155491
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [0044ec90b3182a25740b53fb8679d83f0dc8f369]

        wina11y: Move these 2 checks out of try/catch
        
        Change-Id: I4ae7527d9b5047d46aab44a1ab6fa42a99c43a14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155490
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-09  Justin Luth  <jluth@mail.com>  [c3cf88f73e29a79f890782b31d1ecc6ed1c376ea]

        tdf#144512 autorecovery: only wait once for user idle
        
        If we currently are in a user idle state, then don't delay
        any recovery / autosave's until a future idle timeout.
        
        Change-Id: Ie3953bb7456370d046b76a4cad816498dbfc85e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155462
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-08  Jim Raykowski  <raykowj@gmail.com>  [383e68da6c429c243c1e7be6699acaa942b712bc]

        tdf#125797 Sidebar: Skip over disabled tabbar tabs
        
        This patch makes keyboard navigation of the sidebar tabbar skip over
        disabled tabs. Tabs become disabled when a document is set in read-
        only mode. They can also be disabled by user customization of the
        tabbar.
        
        Change-Id: Iafabfe27fbeaea60acf66527eafbb5396edaf647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155442
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a921c4121d21e166f08b08d2aada3d7ea82235c0]

        update credits
        
        Change-Id: Id87aa5eb32e5f60f2c6a3148d762475fe87d78f0

2023-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [d27c206faa600444d2753d1f2596b6ca83b4c117]

        tdf#156286: sc_uicalc2: Add unittest
        
        Change-Id: Iba1a473293f013e1d5d395ad6ee5f7e61fa759cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155446
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-08  Michael Stahl  <michael.stahl@allotropia.de>  [9c291ea8c63284fe5c344553fcb338e66c17c797]

        tdf#147666 sw: layout: no IsShortCut() if fly was moved to page
        
        The problem was that the fly's anchor frame was moved to page 2, and
        then IsShortCut() returns true for the anchor frame, which means only
        the anchor frame itself is formatted, but not its fly.
        
        Thus the fly remains invalid and positioned on page 1 when its rectangle
        is passed to SwViewShell::VisPortChgd(), and only later it is properly
        positioned.
        
        (regression from commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf)
        
        Change-Id: I9e0554bd0d9751b47a11a3917575d382139ee93a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155461
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [009a24d64f775aabf7fc6307117ada45226df9a5]

        simplify ODatabaseDocument inheritance
        
        no need to use two different ImplHelpers here
        
        Change-Id: I1c871f8e0e49ff8a0a540e8051f3a89a54130322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-08  Khaled Hosny  <khaled@libreoffice.org>  [1e13ee5273848306cc6000d90e9f48593ea39bd8]

        Revert "UI Workaround for tdf#146653: change localized Source Han {Sans,Serif}
        
         CN..."
        
        This reverts commit 22c7ce6c8e7d5b7f8b37ad6c519c2b8ca4853724.
        
        Not needed any more as we now get the style from FontConfig, since:
        
        commit 0b5e88bc88df6f0cd47e84cbd8bc53b649678f8b
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Aug 3 13:44:43 2023 +0000
        
            tdf#114192: Speed up populating font list when FontConfig is used
        
        Change-Id: If6a51ffe681896a7ffda1a06da02585e8141c81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155458
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dac7be0a9984ec00aaad71aa7af22aa1ae255058]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9c0d5620123db0ea25d5ecddbc4136c00d9413a7
          - update translations for 7.6.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: I39580c4b4ae6b4baffb5a959d7275c8f49751059
            
2023-08-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f238f5bf1ba51b03dcbbdc6195c9c9bd590777dd]

        when notes are not shown don't do expensive comment size calculation...
        
        and positioning, etc.
        
        Change-Id: Ice2f1a506bc6ae6d463e51e3d98e075a88c93cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155450
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dc915b2b9ed3fe9a2b97f15aca47ee39ab4db3bf]

        ShowNotes() has to be true to enter this block
        
        so checking for ShowNotes() again is redundant
        
        Change-Id: I0045a352232ed4e09344b36d2774aae81f8b0d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155448
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [ef538b5441875cc3af97e25c83ed15b393d9bfce]

        tdf#155799: sc: qa: add unit test "testMouseMergeRef"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2e46a014a3a66fe41b06a07a68c75e52ae5530f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154602
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [cdca06306e0d4ae2d9874bc7bbd0290d100d54cc]

        tdf#155799: sc: qa: add unit test "testKeyboardMergeRef"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I4d80ad5d9e5fe2c131f9397ec59c6c16ef92c094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154601
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [3273d44baaf0679a19527e953809b9d61d8e2201]

        tdf#155799: sc: add getter function "GetEditString"
        
        Useful for QA test queries.
        ..
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ibd3c902405f478032447b10286a788cd0769c855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154600
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [a58b3984c1ad05d77eaefd424da12d9b833f76b8]

        tdf#155799: sc: fix formula reference "key up"
        
        When the formula reference mode is active and it process
        the keyboard event UP, it should decrease -1 according
        the merge attribute row, col span.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I278bcd9d52caeb09e4a47336af8c8e9b522397c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154599
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [6ca51786b90270c86e854f85728f77d0ef5cffa6]

        tdf#155799: sc: abstraction "moveRefByCell"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ib00e3cddcd4a5dc4ef3d74d3939cdf278f2cb44d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154598
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Henry Castro  <hcastro@collabora.com>  [0ccb2ace2825015873cbae550acc83a29cfbb18e]

        tdf#155799: sc: fix "UpdateRef"" to update extended merged cells
        
        Extend the merged cell if the current has the attribute "Merged".
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ia2d5983d89b8661abb683d10d4de8bd0c5adea7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153657
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [f3754e5dbb3c70264df986fe3fd814b74a8f994b]

        a11y: Drop extra "no" in XAccessibleComponent doc
        
        Change-Id: I32870920d3eacf8c557870abf4a243bb1ba9f584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155454
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [dddbb8a219f13344213b0ef6183529922bca7d50]

        loplugin:unnecessarygetstr fix false +
        
        encountering when we need to pass a std::string to an OString
        
        Change-Id: I91d2aa1f20e7c2407c708c9ce4ae82fb52934c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-08  Michael Stahl  <michael.stahl@allotropia.de>  [a9b19f78f3cdcbf5c949a85b45877e903114cc54]

        tdf#156551 tdf#150606 sw: layout: only invalidate SwTabFrame if it...
        
        ... wants to move back.
        
        In this document, the table 1709 splits across 3 columns of the section
        1702 with 1 row each, and when its follows are invalidated in
        CalcContent(), the later SwTabFrame::MakeAll() of the 1st follow joins
        the 2nd follow and invalidates the size of the section frame, causing a
        loop.
        
        So only invalidate if that actually looks necessary.
        
        (regression from commit 59987d3c77ec7dbf59fbea9f47cc226f4e8903f9)
        
        Change-Id: I360c8f697a7666a19a08d8ebcabbcfa3a7cdf844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155452
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-08  Michael Stahl  <michael.stahl@allotropia.de>  [8b53c28c8a1a7eee70e2517d987ed9badd63a2f3]

        sw: tweak some comments
        
        Change-Id: I0bb2949188378b8f1089210ad417bcb1335fad4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155451
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-08  Arnaud Versini  <arnaud.versini@libreoffice.org>  [4d54aeb67a43a42acf8f3cd94d83584f6870ade2]

        avmedia : use std::recursive_mutex instead of osl::Mutex.
        
        Mostly reverts 621143588b3cb438baf27fb6893ab02e7b06f9dd but using recursive_mutex instead.
        
        Change-Id: I4b23410720834e19c5dd28c43bc84ed1b3e08072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153236
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-08-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4582cea56eedfe3529fe360c68fc4b95b7d47ac5]

        crashtesting: null-deref on kde114933-2.svg
        
        Change-Id: If344bd676eb0eefd2d1bb4728bd0ca1e602c076e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155432
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-08  Miklos Vajna  <vmiklos@collabora.com>  [196c689b9403b0f5874395fb53aedb83794893f7]

        sw: document SwFormatFootnote/EndAtTextEnd
        
        In this case footnote really means footnote, as there is a separate
        class for endnotes.
        
        Change-Id: Ic701e33b45d22ac42a9518a7d44b2e8a43fac4a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155431
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-08  Miklos Vajna  <vmiklos@collabora.com>  [0d571ff8079f858a5650bf6cbb38296d22cc58e1]

        tdf#156589 sw floattable: fix follow fly moving inside a table on the next page
        
        Opening the bugdoc and inserting a page break at the document start
        resulted in a crash.
        
        The direct problem was a nullptr deref in Notify_Background(), because
        pCnt reported true for IsInTab(), but then FindTabFrame() didn't find
        anything. The deeper problem was that SwFrame::GetNextFlyLeaf() had a
        case where it created a follow text frame for the anchor of a floating
        table, but that follow text frame went inside a table on the start of
        the next page, not to the start of the page.
        
        Fix the problem by continuing to use GetNextLayoutLeaf() (which knows
        how to traverse the layout tree from a fly frame to its anchor and then
        to a next page), but once we moved to a body on a next page and we would
        insert inside an inline table, insert before the table instead.
        
        Need to make sure the target is in a body frame, because a next layout
        leaf in a footer's table is not OK.
        
        Change-Id: I3ff6a0bbc2cac5f1bc2803a52a632c13053d4daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155444
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-08  Stephan Bergmann  <sbergman@redhat.com>  [9fabf47aba423d74d8cfa2dc2cb28d24df83a8ea]

        loplugin:redundantfcast
        
        Change-Id: I6b19cbd146de479754b9e8833076ed7f077c87f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155443
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [37b72ba4542ca8dc49d0121be995d9253c65d6ba]

        wina11y: Drop AccObjectManagerAgent indirection
        
        `AccObjectManagerAgent` was holding an
        `AccObjectWinManager` object and forwarding
        everything to that one and the event listeners
        were holding a pointer to the `AccObjectManagerAgent`
        object.
        
        Drop this `AccObjectManagerAgent` indirection
        and let all of the classes that were interacting
        with the `AccObjectManagerAgent` directly interact
        with the `AccObjectWinManager` instead.
        
        The idea of having the agent seems to have been
        to have an abstraction layer and implement
        different accessible object managers for all
        platforms, but the agent already has quite some
        Windows-/IAccessible-specific code/interface and by now, the
        Linux VCL plugins and macOS have their own
        a11y bridges, so the TODO do implement this here
        for Linux as well seems outdated to me.
        
        Even if implementing this for Linux and/or macOS
        in a similar way, I don't see the need for the
        agent layer, but one way might be to
        just have an abstract base class
        (e.g. `AccObjectManager`) that `AccObjectWinManager`
        and implementations for other platforms derive from,
        and have the SalInstance return the platform-specific
        implementation that the `AccTopWindowListener` would
        then retrieve and pass on.
        
        Given that `AccObjectManagerAgent` was forwarding
        all calls to `AccObjectWinManager` and the methods
        and params are mostly the same by now (s.a. the
        preparatory commits), this change is mostly
        straightforward.
        
        A few notes:
        
        * `AccObjectManagerAgent::InsertAccObj` had a default
          nullptr value for the HWND that
          `AccObjectWinManager:InsertAccObj` didn't have yet,
          so add that.
        
        * `AccObjectManagerAgent::GetIAccessibleFromResID` had
          an out param instead of a return value; call sites
          were adapted to fit
          `AccObjectWinManager:GetIAccessibleFromResID`.
        
        * The `UpdateValue` and `UpdateAccName` methods
          taking 2 params are called `SetValue` and
          `SetAccName` in `AccObjectWinManager` instead,
          so adapt call sites accordingly.
        
        * prewin.h and postwin.h includes had to be added
          around the windows.h include in AccObjectWinManager.hxx
          (build would otherwise fail)
        
        * A few `AccObjectWinManager` methods had to be made
          virtual to make linking work.
        
        Change-Id: I88741bf416d4db25d78e973c0db060a828f27926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155440
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [df73c73b3f798453675f286bca537f102a71e770]

        wina11y: Drop unused include
        
        Change-Id: I71659b8aa3ba0f0097aa4200ec159272c5c75b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155439
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [0724cb04e7f20ad01fa544a0d75ae58ab0e9cd8a]

        wina11y: Align param order with other methods
        
        Switch the param order in `AccObjectManagerAgent::NotifyAccEvent`
        to be consistent with all of its other methods that take the
        `XAccessible*` first, and also with
        `AccObjectWinManager::NotifyAccEvent` that is called by the
        method.
        
        This is also in preparation of dropping
        AccObjectManagerAgent altogether.
        
        Change-Id: I83d331176971cc728524266d87939f33acd375f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [b45481d6895e196177dfd9ef4df6b29dc32a8347]

        wina11y: Drop unused default nullptr arg
        
        Calling this without passing an actual XAccessible*
        wouldn't make any sense anyway.
        
        Change-Id: Ie8d8aecc0c0a3a8a2c1ef62015fba7ad242059b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155437
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [b9a981e88f54d24b2a39e7e1801de8ab503daccf]

        wina11y: Move and simplify casting for Get_ToATInterface
        
        Move the casting from AccObjectManagerAgent::Get_ToATInterface to
        AccObjectWinManager::Get_ToATInterface and just do a
        `reinterpret_cast<HWND>(...)` right away instead of a
        `static_cast<HWND>(reinterpret_cast<void*>(...))`.
        
        This is in preparation of dropping the AccObjectManagerAgent
        indirection altogether.
        
        Change-Id: Iad759f856f727418aab0d20b479fc38feac714ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155436
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [e5aab6900f86042e4360bb792bc47690d09eaed7]

        wina11y: Move GetIAccessibleFromXAccessible logic
        
        Move the logic from AccObjectManagerAgent::GetIAccessibleFromXAccessible
        to the new AccObjectWinManager::GetIAccessibleFromXAccessible and just
        forward to that one.
        
        This is in preparation of dropping the AccObjectManagerAgent
        indirection altogether.
        
        Change-Id: Ic276a04cf7dda3762cee0d3932962e2a0947cfde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155435
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [532078a68b7e491845262524ba5e8338cd42f303]

        wina11y: Replace nullptr check with assert
        
        `AccObjectManagerAgent::pWinManager` gets set
        in the ctor and is never reset explicitly, so
        I don't see any way it can ever be null before
        the `AccObjectManagerAgent` object itself gets
        destroyed.
        
        Change-Id: I027ca0d15cbc7ca8e183b71b0dbee7ce1acc925d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [2f41574c3472f46feede6f5a62a4f26254dccee1]

        wina11y: Drop AccObjectManagerAgent indirection to get a11y role
        
        Just retrieve it from the context directly here, and drop the now
        unused `AccObjectWinManager::GetRole`.
        
        Change-Id: I4c14d2f9b6fb1df9c58149576897c8585ba4a437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155433
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-07  jucasaca  <jucasaca@gmail.com>  [42364fbfafaa95773c073cc080142b64ec1786fb]

        tdf#104918 Add Firebird's DATEDIFF syntax to the sql parser
        
        Add one of the Firebird's DATEDIFF syntax to the parser so now it is possible to execute DATEDIFF(unit, datetime, datetime) in the
        Base Query designer and don't need to execute it in SQL direct anymore
        
        Change-Id: I0514542785c47a2a4693cba26de1815c96ee1b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155027
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [616c1da0cc8b345e13bec14b4794e7bab7e1d046]

        Fix typos
        
        Change-Id: If6cdd69d4508cc938ee90f286b2a6103f24a917b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155430
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [5eca134cf91307f0e7ffc89e9074b37d26fcac99]

        tdf#127334: sc_ucalc_formula2: Add unittest
        
        Change-Id: I61ce8847f0ac571815a02dca6456ce526ae711d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155428
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-07  Justin Luth  <jluth@mail.com>  [ceeb48b33b374dfcd970d4fdd194ce0301bbb65a]

        tdf#57414 autorecovery: ignoreClosing during Emergency/SessionSave
        
        Unmodified documents were losing the enties from RecoveryList
        when implts_deregisterDocument was triggered,
        which prevented the Session recovery from being able to reload them.
        
        Change-Id: I991a9821105aca81ec596b28341ef4335b817439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155380
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-07  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [bd6c6d46e82eb5cf5839a5b99e4838471250e959]

        ITEM: speedup WhichRanges access by buffering
        
        I checked for was to speedup SfxItemSet stuff, so had
        (besides other things) a look at WhichRangesContainer
        and it's usage(s). Problem with the WhichRanges is that
        a WhichID which you try to find is usually inside that
        range, so binary search is no option. You have to detect
        in which range the WhichID is hosted and can the directly
        calculate the index into the array of Items at the
        SfxtemSet.
        Currently when needing to transform a WhichID to an index
        into the array of Items in SfxItemSet the array of the
        WhichRangesContainer is searched linearly from the start
        every time.
        This can be a little bit speed up by buffering the last
        successful 'hit' and trying to re-use it. Also the
        special case of a single WhichPair (e.g. UI stuff) is
        worth having a look.
        All acesses to that transformation are changed to use
        the tooling method getOffsetFromWhich() at the
        WhichRangesContainer which does the transformation.
        This also needed cleanup of ItemOffsetHint instances
        & stuff around it. It does not more than before but
        also profits from the single entry buffer.
        I added some DBG_UTIL-based stuff to watch the hit/miss
        ratio, which is heavily changing from app to app & usage,
        but varies around 1.5 to 3.5, also saw 6.5 and more at
        document import.
        NOTE: I already checked if sorting the WhichPair(s) in
        WhichRangesContainer by their 'width' (highest WhichID
        mnius lowest WhichID helps. The idea was when the Items
        would be used in a regular manner that when having the
        widest WhichPairs at the start, the buffer would even
        be better used - but doing tests in all apps shows
        nearly no gain, so I left that out.
        NOTE: Not too much speedup, but faster...
        
        Had to deep-debug due to CppunitTest_sw_odfexport failing,
        found a slight diff between GetItemState impls, corrected.
        Also added more changes, e.g. TotalCount is now a member
        to not always have to calculate it from the
        WhichRangesContainer.
        Extended GetWhichByPos to 1st try to find a set Item, else
        iterate over WhichRangesContainer.
        This is due to SfxItemIter's implementations of
        GetItemState and ClearItem which both up to now just
        accessed the SfxPoolItem array of the SfxItemSet, ignoring
        that no Item (nullptr) or state DONTCARE (-1) may have been
        set there (no item is prevented by ite Iterator, but better
        be careful).
        
        Added WhichRangesContainer::getWhichFromOffset and made
        SfxItemSet::GetWhichByOffset use it. Addedd optimizations
        there for single-entry WhichPair and using the buffer at
        WhichRangesContainer which is possible.
        Removed debug comparing stuff (had a test that used the
        former adapted GetItemStateImpl method in
        SfxItemSet::GetItemState and compared with the changed
        GetItemState_ForWhichID).
        Added some comments and assertions where useful.
        Made ClearSingleItem_ForOffset work without handing
        over WhichID, that makes calls using it simpler and
        avoids calculating the WhichID just for that call.
        
        Change-Id: I54de552368b654f00f115978715f8241eb603752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155316
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-08-07  Justin Luth  <jluth@mail.com>  [63bb760acc8aa50c352f3349e8adf3db381b4911]

        tdf#57414 autorecovery: avoid unnecessary storeToRecoveryFile
        
        With a successful UserAutoBackup, the document is fully saved,
        and the recoveryInfo entry is removed.
        
        So just avoid the recovery that would just be deleted anyway.
        
        Change-Id: I3cc9fe2730640df48f450f900f33afc2df7f020a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155273
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-07  Justin Luth  <jluth@mail.com>  [f5d6888bd1b945596684cb643118e0e07477d3fa]

        tdf#57414 autorecovery: don't store unmodified docs in RecoveryList
        
        When a document is successfully saved (manually),
        it is removed from RecoveryList (implts_markDocumentAsSaved)
        and all of the temporary recovery files are removed
        from the user's backup folder.
        
        If the document is automatically saved (UserAutoSave)
        successfully, it doesn't need to remain in the RecoveryList either.
        
        storeToRecoveryFile can benefit from knowing if it will be removed,
        so determine whether to bRemoveIt just prior to that call.
        
        Change-Id: I2cb30b426e600cfe34987a091acaf8826316ede5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155272
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-07  Justin Luth  <jluth@mail.com>  [9fffac201136dc4f0a128171c17b0fd38836c043]

        tdf#57414 autorecovery: not in RecoveryList? always delete tmp files
        
        In all but one case, the storeToRecoveryFiles were deleted
        when the entry was removed from the RecoveryList
        (and likely it should have been removed in that case as well,
         since the program could not open that file anyway).
        
        So, move that function into the flushConfig function
        to ensure that recovery files are not orphaned
        in the backup folder.
        
        If the URLs are not cleared, and the recovery tries to load
        the non-existing file, then LO will assert (or maybe crash).
        
        (For implts_markDocumentAsSaved,
        it does the deletefiles/flushCOnfig outside of the SAFE area,
        but updates m_lDocCache with *pIt = aInfo inside the SAFE area,
        so those deletefiles/clears cannot be cleaned up.)
        
        (implts_cleanUpWorkingEntry and implts_deregisterDocument
        both remove the m_lDocCache entry competely, so it was not
        necessary to clear the URLs in those two cases.)
        
        Change-Id: I765f3a815f28082495a7f286a8b28b977e0cad75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155118
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-07  Justin Luth  <jluth@mail.com>  [9e0f13b2c4d31537162434b5b932b265c62349e0]

        tdf#57414 autorecovery: don't always add every file to RecoveryList
        
        There is no need to recover documents that are not modified,
        and certainly not if there is no storeToRecoveryFile.
        This specifically is nice for read-only files, new files,
        or e-mailed files that have just been opened for viewing.
        
        registerDocument: A just opened file has nothing to recover,
        so wait until it has storeToRecoveryFile'd.
          - Emergency and Session pre-register all documents
            via implts_persistAllActiveViewNames, so no problem here.
        
        resetHandleStates: shouldn't add, just update the existing states
        
        saveOneDoc: shouldn't add before storeToRecoveryFile, only after.
        
        Change-Id: I4a935ee325af6469b25c5bf3d2860c4065d9130d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154490
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-07  Aron Budea  <aron.budea@collabora.com>  [c9e863801509fb37b125a8fb07358fb1b235496d]

        tdf#150137 fastparser: don't crash on undeclared namespace
        
        Change-Id: Icc8bbb391c7e34754b7274d67d73ff509827a3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155381
        Tested-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-08-07  Justin Luth  <jluth@mail.com>  [db9fa6da9d57853e0089a063ec372e11ce6046a9]

        related tdf#57414 autosave: try harder to know when !IsModified
        
        The cache that holds document status did:
        -saveDocs: for each cached document status:
          -creates a copy of the cached status
          -call saveOneDoc: given the copy
          [-updateModifiedState should get called, updating the cache itself]
          -saveOneDoc: flushConfig writes copy to RecoveryList (as modified)
          -cache is updated with the results from saveOneDoc (*pIt = aInfo)
        
        Now, it is easily possible that saveOneDoc changed the status from
        modified, to not modified, wouldn't you think (if UserAutoSave)?
        But since the copy was never updated, it reported as modified still!
        
        storeToRecoveryFile can benefit from knowing the real modified status,
        so do the update just prior to that call.
        
        Change-Id: Iee1ddd0bf7bee25d5ba3e7abb1ac6713295906af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154683
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [f69a98d1175720db3b1ce5f5ae2c7fc0fc35a2b2]

        tdf#156629 Font,highlighting color buttons in sidebar have white background...
        
        ..after transparency -> alpha change
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: Id1a578fcd30a9315fd5910ccdbff5d759cba77fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155425
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-07  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [6c3989b3a09c4b43c2c5f548c8ae9248db901dc6]

        refactor: remove dead docnode hint code
        
        - the deleted code should not have side effects
        - it had been used to find an actual node to return in the hint before
          9b68ce7b0f2326ec540717ec5c8207825403774e, which removed the need to
          return the node
        
        Change-Id: I8f28765a5dd9355e7fdc7a7ff069a76b714287fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155419
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-08-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9a41532ffc725706b27e20d2f4153cdde5d23e9f]

        Update git submodules
        
        * Update translations from branch 'master'
          to de6c38f1953732b32d8fe81d58e6dc770805c5dc
          - update translations for 7.6.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: Id5898b2b9e8d86165254314ba5b6d9f39ae2b0e6
            
2023-08-07  Khaled Hosny  <khaled@libreoffice.org>  [fed82c416aba3380b8c8931f7d8e0ec359e52a2c]

        tdf#139164: Revert "tdf#54908 Make selection active if there's a selection
        
        (Writer)"
        
        This reverts commit 87d5c863109f7991e3f2f3a1eb970c00d5a27bd5.
        
        Making Writer print selection only by default is not something people
        expect, and it is not the default in any other application. Judging by
        the number of duplicates, it seems to have caught a lot of people by
        surprise, which is not a good UX.
        
        Change-Id: Ia7c8928c474d3390d7f7fee6e0c2e504a41d51b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155422
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-07  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [127a55391c90e8503aa1007c35d8f683a4b8acbc]

        xmlsecurity : simplify DigitalSignaturesDialog
        
        Change-Id: I460d56a5a13dde1bd77f21e0bb6467dd00cb3f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154498
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1faac635fd37dd04f78c9b420ffefd289969c90d]

        ofz#57384 Timeout
        
        Change-Id: Ic2007f52056acd46f96d454c1fdb7b8ca8838d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [daa589af6a7c8ad6bdb273fda949553ad508bd9e]

        ofz#57493 Timeout
        
        the oss-fuzzer has gotten itself into that nasty state where it
        can't reproduce the original problem (because its fixed) but keeps
        finding other unreproducible ones that don't allow the fixed one
        to get closed. Disable this part of the fuzzer for a while so the
        original issue can close and then we can reenable and new findings will
        be recorded as a new fresh bug.
        
        Change-Id: Ie73c5c50a850a0ac6ea51345f6478f5750f8248e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d384da42a0f710040fffcf12120e8f81e99ac56a]

        ofz: Use-of-uninitialized-value
        
        For tdf#149417 we generally allow one short read for fidelity with the
        old parser that this replaced. But don't allow that for new format
        variations that the old parser didn't handle so we don't take libtiff
        into uncharted territory.
        
        Change-Id: I8d2d6954257a63a56d201eaed6510fcc38f9a5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155384
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-07  Szymon Kłos  <szymon.klos@collabora.com>  [b430cc2c3fba0ef2e56a1eb8610681c66714ef80]

        pptx: import ellipse shape correctly
        
        Preset geometry "ellipse" was ignored:
        <a:prstGeom prst="ellipse">
        
        Don't change service name to com.sun.star.presentation.OutlinerShape
        it should stay CustomShape to be correctly shown as an ellipse.
        
        Added next case: XML_body subtype in Layout and Slide mode.
        
        This is continuation for:
        commit 6df267780c4d41b41101c1be0a954b2f16ee8012
        tdf#132557: PPTX import: Workaround for slide footer shape presets
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ifb914c58203a1ad533f9cc9b1857a48983354de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155015
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        (cherry picked from commit e63a9553c022a9976d59113938df068f9d2b5d6c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155233
        Tested-by: Jenkins

2023-08-07  Mike Kaganski  <mike.kaganski@collabora.com>  [97a6e3f22185b26745dbe27949a9b283937f98da]

        tdf#156647: restore the explicitly set properties after applying defaults
        
        Since commit 63c91b9cb3f73b66a915875721b0efd65b8aebac (sw HTML import: apply
        default table autoformat on cells in reqif mode, 2018-08-08), defaults are
        applied to imported-from-ReqIF tables. This resets the padding correctly
        imported from the markup.
        
        This change saves the previous box item, and restores the non-default line
        and distance settings from it after the defaults application.
        
        Change-Id: Ibcd8868875905fa93ab2e0443b2a8900ce1441a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155410
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-07  Stephan Bergmann  <sbergman@redhat.com>  [aff642067712df55c0b5212b4c496e9391777733]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/a124ad5042c1ae042049e5b6464db91c221516a6>
        "Update gvfs-1.50.5.tar.xz to 1.50.6"
        
        Change-Id: I5b3095d5496c2e9ea0aa428516ee889cb0e7327b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155411
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [cdc2b4fe656d92e3817195323993698e052b6fa5]

        Remove unused header file
        
        Seems like it was committed accidentally
        
        Change-Id: Idc086b7b92ef9c4a8b3bafa2114b7da3e8d42618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155350
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-07  Miklos Vajna  <vmiklos@collabora.com>  [16ee4471db74b9e3417106048172eb98ae553f3f]

        svx: prefix members of SdrEdgeInfoRec
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia1f0f7016217f17d45e863484bdb176e7d47a594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155389
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-07  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [97b9d8813edb18f8acecbbd93cb369fd6dfb6fba]

        Drop unnecessary header osl_Mutex_Const.h
        
        It only contained a single define used in a single file
        
        Change-Id: If9f16ab13bb28d2923b97390f1acb013101d0a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155349
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-07  Michael Weghorn  <m.weghorn@posteo.de>  [616a03c7addf78d50cf20e161becf17cb35b90ec]

        android: Update com.google.android.material to 1.9.0
        
        Change-Id: I52b2060cbf1f8eb06a49c58b8d35461aec99f3a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155375
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-07  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [5cd48b4969d25400cc6634fb64706a763528ec65]

        Revert "tdf#116412: include bz2 in internal python"
        
        This reverts commit 5e3510dbb62229cfb01da371d39ecc27b0d44880.
        
        Reason for revert: occured build error at https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_win_arm64/966/
        
        Change-Id: I9f9087964f7a85c03bca6be4eff5717d6d274c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155391
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-08-07  sahil  <gautamsahil1947@gmail.com>  [6e12b7f296930c6f37e036407e9fb832d9a9f027]

        tdf#147906 used std::hypot for Pythagorean addition
        
        Change-Id: I8a926c621dee746e47ebdaaff4e0c558d7a7e6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155073
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-08-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c2b8e86b96d8abfbf1758a2b4161fe29735d38de]

        increase max_len for fodt2pdffuzzer
        
        very little output from this fuzzer to date
        
        Change-Id: I1bd0eaf983c3c88f620803bbd85f464923d6484d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e4b0e5a36b5fe5b1a391e8417b28a7900acc560]

        fix "move SwVirtPageNumInfo to SfxHint"
        
        commit 7f85415a2f07d62bf688cb33680054940d4dd7f1 caused
        
        > 0x7f206906bd30: note: object is of type 'sw::VirtPageNumHint'
        >  80 60 00 00  f0 33 8b 16 20 7f 00 00  6d 00 00 00 00 00 00 00  00 00
        00 00 00 00 00 00  80 94 5c 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'sw::VirtPageNumHint'
        >     #0 0x7f2007e0e38b in SwTabFrame::SwClientNotify(SwModify const&,
        SfxHint const&) /sw/source/core/layout/tabfrm.cxx:3525:20
        >     #1 0x7f2004957b22 in SwModify::CallSwClientNotify(SfxHint const&)
        const /sw/source/core/attr/calbck.cxx:322:18
        >     #2 0x7f2004957e25 in
        sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const
        /sw/source/core/attr/calbck.cxx:327:15
        >     #3 0x7f2007ea97eb in SwFrame::GetVirtPageNum() const
        /sw/source/core/layout/trvlfrm.cxx:1844:19
        >     #4 0x7f20089f092b in
        SwTextFormatter::NewFieldPortion(SwTextFormatInfo&, SwTextAttr const*)
        const /sw/source/core/text/txtfld.cxx:160:47
        >     #5 0x7f20089f9be6 in
        SwTextFormatter::NewExtraPortion(SwTextFormatInfo&)
        /sw/source/core/text/txtfld.cxx:382:20
        >     #6 0x7f200863dbe8 in
        SwTextFormatter::NewPortion(SwTextFormatInfo&,
        std::optional<o3tl::strong_int<int, Tag_TextFrameIndex> >)
        /sw/source/core/text/itrform2.cxx:1737:28
        >     #7 0x7f200862661f in
        SwTextFormatter::BuildPortions(SwTextFormatInfo&)
        /sw/source/core/text/itrform2.cxx:440:27
        >     #8 0x7f200865f573 in
        SwTextFormatter::FormatLine(o3tl::strong_int<int, Tag_TextFrameIndex>)
        /sw/source/core/text/itrform2.cxx:1952:9
        >     #9 0x7f200844aef2 in SwTextFrame::FormatLine(SwTextFormatter&,
        bool) /sw/source/core/text/frmform.cxx:1303:44
        >     #10 0x7f2008459474 in SwTextFrame::Format_(SwTextFormatter&,
        SwTextFormatInfo&, bool) /sw/source/core/text/frmform.cxx:1663:23
        >     #11 0x7f200845edcb in SwTextFrame::FormatImpl(OutputDevice*,
        SwParaPortion*, std::__debug::vector<SwAnchoredObject*,
        std::allocator<SwAnchoredObject*> >&)
        /sw/source/core/text/frmform.cxx:1854:5
        >     #12 0x7f2008465458 in SwTextFrame::Format(OutputDevice*,
        SwBorderAttrs const*) /sw/source/core/text/frmform.cxx:2058:17
        >     #13 0x7f200758ac43 in SwContentFrame::MakeAll(OutputDevice*)
        /sw/source/core/layout/calcmove.cxx:1515:17
        >     #14 0x7f200755b0a1 in SwFrame::OptPrepareMake()
        /sw/source/core/layout/calcmove.cxx:399:9
        >     #15 0x7f2007953230 in SwFrame::OptCalc() const
        /sw/source/core/inc/frame.hxx:1090:37
        >     #16 0x7f20079208f7 in SwLayAction::FormatLayout(OutputDevice*,
        SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1430:19
        >     #17 0x7f200792060a in SwLayAction::FormatLayout(OutputDevice*,
        SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1423:29
        >     #18 0x7f20079344a2 in SwLayAction::FormatLayoutTab(SwTabFrame*,
        bool) /sw/source/core/layout/layact.cxx:1642:25
        >     #19 0x7f2007920133 in SwLayAction::FormatLayout(OutputDevice*,
        SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1417:32
        >     #20 0x7f200792060a in SwLayAction::FormatLayout(OutputDevice*,
        SwLayoutFrame*, bool) /sw/source/core/layout/layact.cxx:1423:29
        >     #21 0x7f2007908ac6 in SwLayAction::InternalAction(OutputDevice*)
        /sw/source/core/layout/layact.cxx:591:25
        >     #22 0x7f2007903d4e in SwLayAction::Action(OutputDevice*)
        /sw/source/core/layout/layact.cxx:388:5
        >     #23 0x7f200a3ff241 in SwViewShell::ImplEndAction(bool)
        /sw/source/core/view/viewsh.cxx:309:17
        >     #24 0x7f2004ccef61 in SwViewShell::EndAction(bool)
        /sw/inc/viewsh.hxx:628:9
        >     #25 0x7f2004c2e8a0 in SwCursorShell::EndAction(bool)
        /sw/source/core/crsr/crsrsh.cxx:263:18
        >     #26 0x7f200c9ff99c in SwView::OuterResizePixel(Point const&, Size
        const&) /sw/source/uibase/uiview/viewport.cxx:1107:22
        >     #27 0x7f2026f7a582 in
        SfxViewFrame::DoAdjustPosSizePixel(SfxViewShell*, Point const&, Size
        const&, bool) /sfx2/source/view/viewfrm.cxx:2058:18
        >     #28 0x7f2026fa205f in SfxViewFrame::Resize(bool)
        /sfx2/source/view/viewfrm.cxx:2852:13
        >     #29 0x7f2026ff3179 in SfxFrameViewWindow_Impl::Resize()
        /sfx2/source/view/viewfrm2.cxx:72:17
        >     #30 0x7f204ea688e0 in vcl::Window::ImplCallResize()
        /vcl/source/window/event.cxx:525:5
        >     #31 0x7f204f23f74b in vcl::Window::Show(bool, ShowFlags)
        /vcl/source/window/window.cxx:2293:13
        >     #32 0x7f2026e731b8 in
        SfxBaseController::ConnectSfxFrame_Impl(SfxBaseController::ConnectSfxFrame)
        /sfx2/source/view/sfxbasecontroller.cxx:1182:24
        >     #33 0x7f2026e6f0aa in
        SfxBaseController::attachFrame(com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) /sfx2/source/view/sfxbasecontroller.cxx:530:9
        >     #34 0x7f2026dd0b8e in
        utl::ConnectFrameControllerModel(com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&,
        com::sun::star::uno::Reference<com::sun::star::frame::XController2>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XModel>
        const&) /include/unotools/fcm.hxx:48:18
        >     #35 0x7f2026dc47e3 in (anonymous
        namespace)::SfxFrameLoader_Impl::impl_createDocumentView(com::sun::star::uno::Reference<com::sun::star::frame::XModel2>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&, comphelper::NamedValueCollection const&, rtl::OUString const&)
        /sfx2/source/view/frmload.cxx:584:5
        >     #36 0x7f2026dbbfde in (anonymous
        namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) /sfx2/source/view/frmload.cxx:759:13
        >     #37 0x7f1fd762b75b in framework::LoadEnv::impl_loadContent()
        /framework/source/loadenv/loadenv.cxx:1176:37
        >     #38 0x7f1fd7621b5b in framework::LoadEnv::start()
        /framework/source/loadenv/loadenv.cxx:412:20
        >     #39 0x7f1fd7619a1c in
        framework::LoadEnv::startLoading(rtl::OUString const&,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&, rtl::OUString const&, int, LoadEnvFeatures)
        /framework/source/loadenv/loadenv.cxx:308:5
        >     #40 0x7f1fd7614d57 in
        framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader>
        const&,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, rtl::OUString const&, rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) /framework/source/loadenv/loadenv.cxx:168:14
        >     #41 0x7f1fd76ed70d in
        framework::Desktop::loadComponentFromURL(rtl::OUString const&,
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) /framework/source/services/desktop.cxx:593:16
        >     #42 0x7f1fd76ed936 in non-virtual thunk to
        framework::Desktop::loadComponentFromURL(rtl::OUString const&,
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) /framework/source/services/desktop.cxx
        >     #43 0x7f1ff52cbb7a in
        unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString
        const&,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) /unotest/source/cpp/macros_test.cxx:71:62
        >     #44 0x7f20214a91ac in UnoApiTest::load(rtl::OUString const&, char
        const*) /test/source/unoapi_test.cxx:115:11
        >     #45 0x7f1ff578a483 in SwModelTestBase::loadURL(rtl::OUString
        const&, char const*) /sw/qa/unit/swmodeltestbase.cxx:468:20
        >     #46 0x7f1ff578df71 in SwModelTestBase::loadAndSave(char const*,
        char const*) /sw/qa/unit/swmodeltestbase.cxx:486:5
        >     #47 0x7f202d75f0b9 in testCrashWhileSave::TestBody()
        /sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:1016:5
        
        during CppunitTest_sw_ooxmlexport3
        (<https://ci.libreoffice.org/job/lo_ubsan/2871/>).
        
        Change-Id: I41838d3493bd4b1a68cb29cf1e90494eb8db0077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-06  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [ad1f69d28d31725a22e7e1cbb4d950aa9ad3bea7]

        tdf#156540 invert alpha mask when drawing sprites
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, a sprite's
        alpha mask needs to be inverted.
        
        Additionally, fixes an oversight in vcl's alpha.cxx, where manual
        blend math got mangled, also in
        81994cb2b8b32453a92bcb011830fcb884f22ff3.
        
        Change-Id: I8ebbbc7fe624d8dfc8121d8814d30875c498870d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155378
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [f454a774053d2f631009612c78713822f6afdbd2]

        Revert "external/python3: fix Windows build"
        
        This reverts commit 219bef04b7084eef49e1001312e186f390f4f735.
        
        Reason for revert: occured build error at https://ci.libreoffice.org/view/tb%20platform%20status/job/lo_daily_tb_win_arm64/972/
        
        Change-Id: I26bb1a790ffddd7cb2f102f09cfb46b9327bb94b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155309
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-08-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [72f28e12b15823197e42265af1f8dda21224c90a]

        openssl: upgrade to release 3.0.10
        
        Change-Id: Iee5716bdd111e2f30cb38d48a86104da52872dd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155382
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-08-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [219bef04b7084eef49e1001312e186f390f4f735]

        external/python3: fix Windows build
        
        ...after commit 5e3510dbb62229cfb01da371d39ecc27b0d44880
        (tdf#116412: include bz2 in internal python)
        
        add _bz2*.pyd modules.
        
        Change-Id: Icae5971fd766af738287d34f7abc4187a7a1fcca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155367
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-08-06  Justin Luth  <jluth@mail.com>  [6444f5e2c5c8b3d1fac12755af09339083c74055]

        tdf#145606 autorecover: skip "Finish" button if all recovered OK.
        
        Change-Id: I59036b98b33d85305b13430113a3a3d399dea27d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155379
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-08-06  Patrick Luby  <plubius@neooffice.org>  [b3053b63c65372627c5fb4df6b4ddcd5e12e16f7]

        Revert "tdf#156540 invert alpha when drawing sprites"
        
        This reverts commit 52637f46cc79eb7f65a97524e92a0b2f45d3d598.
        
        Reason for revert: A better fix is being worked on in https://gerrit.libreoffice.org/c/core/+/155378
        
        Change-Id: I91c6ed96bdd202612d4b10458c015532b9162c1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155308
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Patrick Luby <plubius@neooffice.org>

2023-08-05  Patrick Luby  <plubius@neooffice.org>  [52637f46cc79eb7f65a97524e92a0b2f45d3d598]

        tdf#156540 invert alpha when drawing sprites
        
        Due to the switch from transparency to alpha in commit
        81994cb2b8b32453a92bcb011830fcb884f22ff3, a sprite's
        alpha mask needs to be inverted when Skia is enabled and
        the fAlpha value needs to be inverted when Skia is disabled.
        
        Change-Id: Ie802924b07ddbab536a2eddb57bf82e5146cffe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155358
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [484182b04d35f15437c09008cede361edde71d01]

        cid#1539504 Division or modulo by zero
        
        Change-Id: I201d821a3f6e2f3dd5596d05c38e394637617878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155371
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-05  Patrick Luby  <plubius@neooffice.org>  [fe9efb6d5eeba3adf81cd1f33b684fd8f57899f5]

        Related tdf#156508 fix rendering of the About dialog .svg
        
        After 0e7d4ea64f84bdc62c10692dcd97c3a32e72e16e, white polygons are
        drawn in the LibreOffice about .svg in both the About dialog and with
        the .svg in a document.
        
        Creating the mask with COL_WHITE instead of COL_BLACK appears to fix
        this without causing tdf#156508 to reoccur.
        
        Change-Id: I886451245126c2b7f936e30275965148bf029627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155362
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5b250eda6cc8c07fead45a65f871d52f5020f485]

        cid#1539502 Dereference before null check
        
        Change-Id: Ieb785e9f1a1e4b713b9d4935390f5a753c899813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155370
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6164600ec1e60d450a6f2154f231e5c284c148ab]

        cid#1539501 Unchecked dynamic_cast
        
        Change-Id: I5b369c51259036e02609e5ad66b882063aa9e309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155369
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [46d6dc0e67f9ff1d4b606372ed58101e3c62b7a1]

        cid#1539503 Unchecked dynamic_cast
        
        Change-Id: Id54f46aa4ac7a2afcbc8fa4f898c812738f10f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155368
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [6d5848ec01d615e89d9c62e18a29fcb0a9febcca]

        Define px as 1/96 in in HTML filter
        
        Ref: https://www.w3.org/TR/css3-values/#absolute-lengths
        
        Change-Id: Idf1def9497b35f67ef1554220d1abbe640840f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155366
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aaa60f31dce7942c083513bbcb3587f85e833f9f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c3257e391a8fbbdcde2dc380d9a8227745894bc
          - tdf#155193 Fill indexer= when omitted in Help files
            
            Change-Id: I10f3c9e1e698619dcace7c4314f2bd37adf698de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155363
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [06f5e9160c0adfbaf60dadbb2751ec32163a5914]

        Fix typo
        
        Change-Id: Ic705d2b943b84a7589f4b2c7389a4a034b03770f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154877
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fc3f787af1883ff05768c6975e7db126491adab4]

        Fix typo
        
        Change-Id: Iea0d313fd641927eb83f11364a0ea690e3e4c635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155365
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [c66040da562778e7f8ca52c602dbaa78b6733eeb]

        Rename setRGB to createRGB to make it less misleading
        
        Somehow I overlooked completely, that there already is a non-static
        setRGB. Thanks Miklos and Tomaž for the heads up!
        
        Change-Id: If20018a317d90e0a6297950dff201671316aacad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155353
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [e25e27c85ed970cdb97c468bdac86c80964f4231]

        Fix crash in lokit form control mouse handler
        
        Since 7adfecb0f5947ae258226c8d1652546f81577026
        
        , clicking on form controls results in a crash like this one:
        
          0x00007f7c81092a7c in __pthread_kill_implementation () at /lib64/libc.so.6
          0x00007f7c81041226 in raise () at /lib64/libc.so.6
          0x00007f7c81029897 in abort () at /lib64/libc.so.6
          0x00007f7c812e4c60 in __gnu_debug::_Safe_sequence_base::_M_get_mutex() () at /lib64/libstdc++.so.6
          0x00007f7c2aaaf36f in std::_Optional_base_impl<PointerStyle, std::_Optional_base<PointerStyle, true, true> >::_M_get()
          (this=0x7f7c2c673b50 <LokControlHandler::postMouseEvent(SdrPage const*, SdrView const*, vcl::DocWindow&, int, Point, int, int, int)::eDocPointerStyle>)
          at /usr/include/c++/13/optional:477
          0x00007f7c2aaa9b24 in std::optional<PointerStyle>::operator*() &
          (this=0x7f7c2c673b50 <LokControlHandler::postMouseEvent(SdrPage const*, SdrView const*, vcl::DocWindow&, int, Point, int, int, int)::eDocPointerStyle>)
          at /usr/include/c++/13/optional:974
          0x00007f7c2aaa66bb in LokControlHandler::postMouseEvent(SdrPage const*, SdrView const*, vcl::DocWindow&, int, Point, int, int, int)
          (pPage=0x7f7c6ec35910, pDrawView=0x7f7c6f097a40, rMainWindow=..., nType=0, aPointHmm=Point = {...}, nCount=1, nButtons=1, nModifier=0)
          at core/include/sfx2/LokControlHandler.hxx:79
          0x00007f7c2aa9d784 in SwXTextDocument::postMouseEvent(int, int, int, int, int, int) (this=0x7f7c6eae94f0, nType=0, nX=1756, nY=4106, nCount=1, nButtons=1, nModifier=0)
          at core/sw/source/uibase/uno/unotxdoc.cxx:3741
          0x00007f7c7c8fb074 in doc_postMouseEvent(LibreOfficeKitDocument*, int, int, int, int, int, int) (pThis=0x7f7c6f37fe90, nType=0, nX=1756, nY=4106, nCount=1, nButtons=1, nModifier=0)
          at core/desktop/source/lib/init.cxx:5062
          0x00007f7c81642c9e in postMouseEventInThread(gpointer) (data=0x19aa340) at core/libreofficekit/source/gtk/lokdocview.cxx:2335
          0x00007f7c816441fb in lokThreadFunc(gpointer, gpointer) (data=0x19aa340) at core/libreofficekit/source/gtk/lokdocview.cxx:2567
        
        Change-Id: I77e85df6a77adc033cc793488924ed676a9900be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155364
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-05  Rafael Lima  <rafael.palma.lima@gmail.com>  [9ca60dc90958001c078ed6331bd432c36961a425]

        tdf#156156 Add Help button to sidebar decks
        
        This patch adds a Help button to the sidebar deck, so that each deck has its own Help ID, which can later be used as reference to write help pages.
        
        The Help IDs of each sidebar deck is a combination of the string "SIDEBAR_" + the deck ID (as defined in Sidebar.xcu).
        
        Change-Id: Ib7f106ff917e41130bde136e1e6f04bb2af40daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154918
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-08-04  Stephan Bergmann  <sbergman@redhat.com>  [be58058b0e49cceff1732535b5a9ab57aeb9aa7c]

        Avoid "function 'testDynamicCast()::S1::~S1' has internal linkage...
        
        ...but is not defined"
        
        Change-Id: Ib1350d5d34eef0d544ca8f436ae63c693b7d2f5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155354
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Stephan Bergmann  <sbergman@redhat.com>  [ed5d9496320d78032ab4a65fc5547aad069d19f2]

        external/hunspell: Work around missing C++20 std::bit_cast
        
        ...as witnessed with <https://ci.libreoffice.org/job/gerrit_android_x86/31690/>
        on top of patch set 4 of <https://gerrit.libreoffice.org/c/core/+/155121/4>
        "Bump baseline to C++20",
        
        > In file included from /home/tdf/lode/jenkins/workspace/android_x86/lingucomponent/source/spellcheck/spell/sspellimp.cxx:35:
        > In file included from /home/tdf/lode/jenkins/workspace/android_x86/workdir/UnpackedTarball/hunspell/src/hunspell/hunspell.hxx:74:
        > /home/tdf/lode/jenkins/workspace/android_x86/workdir/UnpackedTarball/hunspell/src/hunspell/w_char.hxx:62:17: error: no member named 'bit_cast' in namespace 'std'
        >     return std::bit_cast<unsigned short>(*this);
        >            ~~~~~^
        
        Change-Id: Ic4a799a0918ff6bcc4dd414d5ae59e02181074bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155346
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Jim Raykowski  <raykowj@gmail.com>  [e2db54b9bf48b79802154d5fc9460fc432ea69a0]

        tdf#156557 Sidebar: Make Shift+Tab kb navigation behave as expected
        
        This patch makes Shift+Tab change keyboard focus to the last panel
        control of the previous panel when focus is currently on a panel title.
        It also makes Shift+Tab change keyboard focus to the Tabbar hamburger
        menu when focus is currently on the "Close Sidebar Deck" button.
        
        Change-Id: I3ff849655afc4f01dba2268055292eee573adf43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155333
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-04  Michael Stahl  <michael.stahl@allotropia.de>  [5b55ccfd384d3c0c11e05f22bd7e956b4bc7e43a]

        tdf#147938 sw_redlinehide: fix undo of table to text
        
        The problem is that when the text node is split in
        SwNodes::UndoTableToText(), the 2nd one retains the merge flag NonFirst,
        not the 1st one, and it ends up in the 2nd table cell, so it's skipped
        when creating the layout frames (and an assert in InsertCnt_()
        segfaults).
        
        SwContentNode::DelFrames() should probably reset the merge flags of
        nodes when it deletes the merged frame.
        
        (regression from commit 32902f66e7749b2d06d13f50416be5323a0c0ea9)
        
        Change-Id: I7b3b1ca873bde831481c676780200a3206ae667c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155345
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-04  Michael Stahl  <michael.stahl@allotropia.de>  [3d8697dab9a4a29666440a30c5c7a6d9d9f76d76]

        tdf#147938 sw: Undo of table to text uses ContentIdxStore wrong
        
        ContentIdxStore must be created for every SplitContentNode() with its
        content index and used there; SwNodes::UndoTableToText() creates it once
        per text node which is rather unhelpful and in this case results in a
        redline with incorrect range, starting in one table cell and ending in
        another.
        
        This problem exists since initial CVS import.
        
        Change-Id: I8a20b13b42384658bf869c5202ccbad2213c12f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155344
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-04  Stephan Bergmann  <sbergman@redhat.com>  [085d25d9cac695e63ecef0ed07fa40f15cd37259]

        Drop --with-system-mariadb from Linux_ubsan_master.conf
        
        It had been there ever since 2b9a57482bb935c330e30eb948897a8bfb9fbcbf "file for
        ci-based ubsan build", but the reason appears lost to history, and it now
        started to cause issues for <https://ci.libreoffice.org/job/lo_ubsan/2868/>,
        
        > configure: error: mysql_config is missing. Install MySQL client library development package.
        
        Change-Id: Ie4ffca5990c029a5df9e9c0814d09cc025162942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155347
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Stephan Bergmann  <sbergman@redhat.com>  [6c15598a3ff60b3d078fa9bf8b3b077c16343517]

        Avoid a Clang template instantiation bug with libstdc++ and C++20
        
        See patch set 2 of <https://gerrit.libreoffice.org/c/core/+/155121/2> "Bump
        baseline to C++20" for how that would affect us here,
        
        > /opt/rh/gcc-toolset-12/root/usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/basic_string.h:620: error: undefined reference to 'void std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> >::_M_construct<char16_t const*>(char16_t const*, char16_t const*, std::forward_iterator_tag)'
        > clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/solenv/gbuild/LinkTarget.mk:841: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/workdir/LinkTarget/CppunitTest/libtest_sal_rtl.so] Error 1
        
        (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/145874/>)
        
        Change-Id: Ibda1a5687a16e45aa0e77958f2bf547766cb0f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155343
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [b1c339686cf0e1cb3cbbc40618a191bc31f8993f]

        docmodel: Fix comment at end of namespace
        
        Change-Id: I6a89ae49f735bde8220a110d83001604cc3c335e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155337
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5dc450c43fb48e19c8ae400cd22e50f561c97967]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6cd38151a2c1008ce4b37dc40bbaf7ed3a8b047d
          - Add precisions on computed colors in Themes topic.
            
            Change-Id: Ic607d49b2281cb54b3273e95917868c17a849e51
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155303
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6edb8e053005cf9a65aa118c4496c25c073e9d0]

        cool#6911 draw the note indicator browser-side
        
        Change-Id: I0770641bbd1c6d023cbd14ad9404256cc92892c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155223
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e59780c1e0670c4a79bd465da08d5cf51d421f62]

        Reduce differences between _test_asserts.bas and _test_asserts.vb
        
        Change-Id: Ic546f6454f2b8581300320e1690644152d44eb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155341
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-04  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [ade2c454c2856f727e877207dfc4f7840acd4d7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ceb7ce7ac4ce11fb9d57c346359a9e3203d950c5
          - tdf#156605 Document new "Comments in margin" options for PDF
            
            Change-Id: I5b0fe3f038a1992d533978d1d89f0b1ad612b6ec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155302
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-04  Colomban Wendling  <cwendling@hypra.fr>  [0f0a4c68bec8bf7e995142961925f74b83e1ed90]

        Fix --disable-atspi-tests when requirement are found
        
        Drop `test_atspi_tests` altogether which only adds complexity, and fix
        the case where using `--disable-atspi-tests` was not disabling
        anything.
        
        Change-Id: Iadcb5b757433917a2150801c8de0ba4634c7e2fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155288
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e7d4ea64f84bdc62c10692dcd97c3a32e72e16e]

        tdf#156508 Blur shadow is solid in edit and presentation mode
        
        regression from
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: I14f62547e3301cab0eff79716bf7bc2a51ead563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9ecca53e178543ade77a1bca11a395f2d599c485]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3cb6dbe25ae87882ca810a56794a05a65412bf17
          - tdf#105122 Initial contents for document themes help
            
            Change-Id: Ia415169020698f53bf6019d546fcd42fd9be31bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155329
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [c08dc58e470c788e8c8d2fa8e45e50f5fdcd8bb1]

        Rename ComplexColor::RGB to setRGB, to avoid conflict with Windows define
        
        Affects Windows' no-pch builds.
        
        Change-Id: Ifff401df40854f59760bd398c156a8837b528efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155340
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-04  Miklos Vajna  <vmiklos@collabora.com>  [c545a0729e89ee2e8f14534b77422cc9eb4eb7cf]

        sw floattable, crashtesting: fix PDF export of tdf73201-1.docx
        
        The direct cause is that in in the SwTextFrameBreak ctor, m_pFrame has
        IsInSct() as true, but FindSctFrame() then doesn't find anything, which
        should not happen.
        
        The bigger problem is that currently the fly split code assumes that
        frames grow from (logical) top to bottom, so in case the vertical
        orientation is bottom, and we have to grow from bottom to top, that
        needs re-positioning the fly, but the fly split code has no support for
        that.
        
        Fix the crash by denying this case in SwFlyFrame::IsFlySplitAllowed()
        for now, the document's table is not supposed to split in the first
        place.
        
        In case later there is a real need to split such flys, then more
        research is needed how that re-positioning works in detail for non-split
        flys and then we have to adapt the fly split code accordingly.
        
        Change-Id: I56cf074a3d740ab716f7de232fbd131d17544d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155339
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [094fc93dfb5f9f6d441e63a8515c09d6165add00]

        tdf#156602: fix handling of nesting of tables in the document beginning
        
        The old code only accounted for a single table in the document start,
        finding the innermost table, and so ignoring any outer tables there.
        Do the same as for nesting sections: find the outermost one.
        
        Change-Id: Ide0e5bcf7c81e43fa5467da86e2e7e00a7076528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155332
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-04  Szymon Kłos  <szymon.klos@collabora.com>  [a68d39c34ea1e418deadc0a5ee2acc2019a582cf]

        oox: default first line indent is 0
        
        When First Line Indent was defined in paragraph properties
        Impress remembered that value and applied for the next
        paragraph. Let's set it to default value (0) if property is
        not set explicitly.
        
        Change-Id: I3b075fab594fce64d953553634a49b9769c9341c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155336
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-08-04  Szymon Kłos  <szymon.klos@collabora.com>  [ae3b97a69688553e6c40ef4b64655db09d5a0f5e]

        pptx: import shape text from master page
        
        If shape has custom text defined in master page
        but no text itself - don't prefer placeholder text
        but text from master page.
        
        Change-Id: Id4f7aeca0e74ecd8565905cd656a182c1195fa30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154980
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155335
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-08-04  Szymon Kłos  <szymon.klos@collabora.com>  [d501959c1b93f90321a0f1155262997e8c849753]

        lok: don't calculate document area in tile rendering all the time
        
        GetCellArea does the same that GetPrintArea but faster
        thanks to caching the results if document wasn't modified.
        
        Change-Id: Ic0c43c3efe046419910a4056f6334099afa3fa45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154437
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154593
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-08-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [51d2107788f6bcc2734f6dc0decd62556fab5112]

        Fix typo in code
        
        Change-Id: Ic4ba514198523bb31da7af12926808cce48a19f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155330
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [efb3442b3299c9c98a99d8d4eb8cddf3eb9ff08e]

        Removed executable bits
        
        Change-Id: Id713c776c1311ab145d4a64f9d71ee87bda864c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155331
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-08-04  Szymon Kłos  <szymon.klos@collabora.com>  [ccd07c3bf5849a7939ea02a46b1c160ede16f03c]

        oox: don't use master style by default
        
        By default a shape with empty type attribute in placeholder tag: <p:ph/>
        will get subtype = XML_obj (oox/source/drawingml/shapecontext.cxx:81)
        
        When it is not referencing any master style shape by idx attribute
        we shouldn't use master list style to be compatible with MSO.
        
        Change-Id: Ib695b695885892dbe659e70a28daff1799c5f50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155232
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-08-04  Tibor Nagy  <nagy.tibor2@nisz.hu>  [694bacca057c9f1d93ab27d61199aec9d060b868]

        Fix heap-use-after-free
        
        The issue is caused by commit Ic87983fa6e3279a64841babc565fbe97710ff730
        (tdf#99808 sc: fix background of conditional formatting in merged cell)
        
        Change-Id: Ic72ba16c2649537dc3b486e07c12e2486cdf1957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155328
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-04  Miklos Vajna  <vmiklos@collabora.com>  [af24ca0ab7ccb7d6c1d07bdb528f577b1e649671]

        sw: fold SwTextFrame::dumpAsXmlAttributes() into dumpAsXml()
        
        One dumpAsXml() per SwFrame subclass is enough, no need to have a
        separate functiont hat dumps just the attributes.
        
        Change-Id: I23888dadc36848d28dee1b1d2e4eecd964ed4fe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155323
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-04  Colomban Wendling  <cwendling@hypra.fr>  [150a1528882347882e857649290fe81d5aa08345]

        gtk3 a11y tests: Increase DBus timeout
        
        We apparently get recurrent spurious timeout failures in the CI
        related to DBus timeout, so increase that value.
        
        The chosen value is a bit arbitrary, but is below the maximum
        recommended by the documentation (even though the recommendation hardly
        applies to our use case), and more than 3 times larger than the
        default.  That will hopefully be enough.
        
        Change-Id: I244f711f46353009743015d00b303aeb87332936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155310
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b0b4ddc8bd8fdd4cd689300620fe4621d7533b7]

        svgio: Simplify code
        
        Change-Id: Ibd28973fee006f3853fde64c519dd0cd8c1573ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155322
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f17ce9ac89c1ad380bde39036000a1979f567bb]

        Revert "fdo#50114 ingore flowRoot element during svg import"
        
        This commit reverts 5bd241b99b76ae7f4b3c1d4f2bcbaf7c487bb339
        which is no longer needed after
        13a41e7a12598c7896d6dc8d34aba6af5b80b83c
        "tdf#150124: do nothing when parent is of unkown type"
        
        and might cause unexpected results as seen with
        https://bugs.documentfoundation.org/attachment.cgi?id=124782
        from https://bugs.documentfoundation.org/show_bug.cgi?id=99628
        
        Change-Id: I8bb700f5c5553700f91b937330bc3730e8ea84c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155320
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [e222f60ac2a71032dbdf62d7c7e28978b5a0b19c]

        related tdf#156579: just break for switch element
        
        Change-Id: I4a31431325c44440f773f6f345d2a0a057d1fa37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155317
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-03  Eike Rathke  <erack@redhat.com>  [46e672db8002e7aaac881bee65b5c50c4e14c666]

        Resolves: tdf#127334 Increase tools::Duration accuracy epsilon unsharpness
        
        ... when converting from double, i.e. to 300 nanoseconds.
        Empirically determined..
        
        Change-Id: I92c43b5f244923363af5d44bece9c155126ca343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155324
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-08-03  Khaled Hosny  <khaled@libreoffice.org>  [0b5e88bc88df6f0cd47e84cbd8bc53b649678f8b]

        tdf#114192: Speed up populating font list when FontConfig is used
        
        Instead of calling psp::PrintFontManager::analyzeFontFile() get the font
        names and metadata, use the values taken from FontConfig which nowadays
        provides everything we need. This speeds up startup time significantly,
        especially when there is a large number of fonts installed.
        
        This also uses the correct style name, we were mixing name id 1 (family)
        with name id 17 (typographic subfamily) while we should have been using
        name id 2 (subfamily). The name ids 1, 2 and 16, 17 should be used
        together not mixed and matched, and we need the former because it is
        compatible with the R/I/B/BI model we (and the other office suite) use.
        
        So instead of "Foo Black, Black", we now get "Foo Black, Regular".
        
        On a system with 6616 fonts installed. Before:
        
        $ export OOO_EXIT_POST_STARTUP=1
        $ time ./instdir/program/soffice.bin --headless
        
        real    0m4.744s
        user    0m1.672s
        sys     0m2.547s
        
        after:
        $ export OOO_EXIT_POST_STARTUP=1
        $ time ./instdir/program/soffice.bin --headless
        
        real    0m1.377s
        user    0m0.563s
        sys     0m0.297s
        
        Change-Id: Ib7e358f16530c2daabc7ef677ef6a148fdf08e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155313
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-03  Khaled Hosny  <khaled@libreoffice.org>  [803747fa9cb9a47e2f392d55b72033185c905e22]

        Raise minimum FontConfig version to 2.12.0
        
        I want to use FC_SYMBOL and this the first stable version to have it,
        and our baseline has 2.13.x already.
        
        Change-Id: I606b99190020085cdf20a52788a021543c365fca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155312
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [61845b3d9fed6a8b97e90ec12126d1e1e4cc18d0]

        tdf#156570 - A11Y - Fix heading accessibility warning not clickable
        
        Make "Wrong heading..." warning message clickable.
        
        Change-Id: I90d2100551de523e9825cee8788d1c8bb914216c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155252
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [22e8d9c42a2ffa19c9efeeaf581016c39c724134]

        tdf#156568 - A11Y - Make clickable the "Hyperlink text is the same as..."
        
        warning message.
        
        Change-Id: Iad391e14f3f414bd4674e634a160bd749b281197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155225
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-08-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2795a230464aea3a792e67b5625fce2a0c01d547]

        tdf#151103: Use the whole text line to calculate the align position
        
        Change-Id: I7ecd41c422afbf028101924972c47a510834ba5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155314
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [490cf5393d30dd2e9ab201286ef863b3c266a8b4]

        tdf#154210 Add help IDs for the Navigator context menu
        
        This patch adds the missing HIDs for all entries in submenus of the context menu in the Navigator. The entries in the main level already work.
        
        For this patch to work, the related patch in the "help" repo needs to be accepted to create the target HIDs.
        
        Change-Id: Ic5917ce16a1430c6f7031ea6b9eb71a09f52624a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155049
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [024fbfc1ae7906e0c62e28ab9c3066d38ddf8d7c]

        SAL_WARN->SAL_INFO
        
        This warning fires all the time, but does not seem to indicate any real
        problem. It dates back to
        
        commit acea502ce05285043c2ebc12de6218d7ea59fa7e
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Tue Aug 19 08:58:56 2008 +0000
        
            INTEGRATION: CWS dba31a (1.240.62); FILE MERGED
        2008/07/30 12:08:05 fs 1.240.62.3: RESYNC: (1.241-1.242); FILE
        MERGED
        2008/07/16 06:15:45 fs 1.240.62.2: RESYNC: (1.240-1.241); FILE
        MERGED
        2008/06/09 10:20:50 oj 1.240.62.1: #i88506# insert new flag to offer
        word boundary breaks
        
        Change-Id: I65b62e1c7851ef3e3443f02ccd9f5f609f645341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d4d95e7fe13bdf6eb50e01081c93dfe7a963f23]

        tdf#144072 Base crash when 2 fields selected in reportbuilder..
        
        from different sections and width is adjusted 2nd time
        
        Change-Id: Id627a222a8c485fcd0458b4b9109fed7f2292ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155284
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-03  Michael Weghorn  <m.weghorn@posteo.de>  [2b30d37bd555188733a006e1a5796461ab11d326]

        tdf#156473 wina11y: Fix invalid write due to row/col mismatch
        
        With the grid control now reporting row/column headers
        due to the previous tdf#156473-related commits, this
        copy-paste mistake in
        
            commit 8a4271e168f70f9147b567189c1770a243e7fcb1
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Aug 5 09:49:02 2022 +0100
        
                wina11y: Implement IAccessibleTableCell::get{column,row}HeaderCells
        
        was now causing hard to debug crashes when moving around
        in the table from the tdf#156473 sample macro with
        the NVDA screen reader running on Windows.
        
        Change-Id: I9fa30c1181d0fd21a85a73fd660c49667850d82b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155311
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-03  Michael Weghorn  <m.weghorn@posteo.de>  [f7ff0468616d3ed8ded78598649a32bcb4e1ef1a]

        tdf#156473 a11y: Implement AccessibleGridControlHeader::getAccessibleCellAt
        
        With this in place, selecting a grid control cell from the tdf#156473
        example in Accerciser's treeview of the LO a11y hierarchy now shows
        a corresponding row and header cell.
        
        Change-Id: I89978051cdb285a02cbce7a560a788b6d24ca7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155251
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-03  Michael Weghorn  <m.weghorn@posteo.de>  [8c330cd741a55546ee7fdf416600d3f44dd2a40a]

        toolkit: Use range-based for, drop invalidTableControlAction
        
        The `invalidTableControlAction` enum value was apparently
        only used to detect when to stop the iteration and is
        no longer, so drop it.
        
        Change-Id: Idec6572a9f328b246445191f0a3e6a131bb0f688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155229
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-03  Michael Weghorn  <m.weghorn@posteo.de>  [18aed6fc4ff5b981ae7deb6584197b661721e7df]

        tdf#156473 a11y: Use actual row/col index/count in grid control header
        
        The row header bar of a grid control is a table with
        just one column, containing a row header cell for
        each of the rows in the table holding the actual data.
        Likewise, a column header bar just has one row.
        
        This was previously incorrectly reported on the a11y layer,
        as could e.g. be seen in Accerciser with the sample macro
        from tdf#156473.
        
        Also make the `AccessibleGridControlCell` ctor pass the
        `_nColumnRowId` as what it actually is (a row index
        in case of a row header cell, a column index in case
        of a column header cell) instead of always as a row
        index, and then having special handling for that
        elsewhere again
        (s. `AccessibleGridControlCell::getAccessibleName`).
        
        Also move an assert from
        `AccessibleGridControlCell::getAccessibleName` to
        the ctor and check the indices there.
        
        With this in place, the row and column header bars
        for the example from tdf#156473 now report the correct
        amount of rows and columns, and the row/column header
        cells report the correct row and column indices.
        
        Change-Id: I29f71ac46b6d841e26d68ca01bd05ba9412aed13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155224
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-03  László Németh  <nemeth@numbertext.org>  [d17b16215629ff078d5707309115233d4752f7d8]

        tdf#156595 sw tracked table column: fix crash at row deletion
        
        In Hide Changes mode, deleting a row, which has
        a hidden column deletion before the first cell,
        resulted a crash because of missing cell frame/table
        cursor.
        
        Regression from commit aff269c18b9029fec992135a406dc5031927c401
        "tdf#155345 sw tracked table column: hide them in Hide Changes mode".
        
        Note: it seems, plain uiwriter testing is not enough to catch
        the problem.
        
        Change-Id: I12675ecd402d6411107b90809728454f13e60580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155287
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-03  Stephan Bergmann  <sbergman@redhat.com>  [3bcc14b4e2b226f97e937ca7a152218f8276ee39]

        Fix handling of float vs. double values
        
        ...which had been broken ever since f424e55b4e66ffbee5b34f45ef5ea18d77c4d15c
        "INTEGRATION: CWS sixtyfour11 (1.7.22); FILE MERGED" had merged the
        typelib_TypeClass_FLOAT case into the typelib_TypeClass_DOUBLE case, and which
        caused
        
        > ==612573==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7fff4e6b0700 at pc 0x7f45a9d77d9e bp 0x7fff4e6af3f0 sp 0x7fff4e6af3e8
        > WRITE of size 8 at 0x7fff4e6b0700 thread T0
        >  #0 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:155:51 (instdir/program/libgcc3_uno.so +0x118d9d)
        >  #1 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 (instdir/program/libgcc3_uno.so +0x112c1e)
        >  #2 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:330:13 (instdir/program/libgcc3_uno.so +0x10e333)
        >  #3 in stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::get(com::sun::star::uno::Any const&) at stoc/source/corereflection/criface.cxx:141:9 (instdir/program/libreflectionlo.so +0x1f89e0)
        >  #4 in non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::get(com::sun::star::uno::Any const&) at stoc/source/corereflection/criface.cxx (instdir/program/libreflectionlo.so +0x1fc5fb)
        >  #5 in cppu::PropertySetMixinImpl::Impl::getProperty(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&, rtl::OUString const&, com::sun::star::beans::PropertyState*) const at cppuhelper/source/propertysetmixin.cxx:563:24 (instdir/program/libuno_cppuhelpergcc3.so.3 +0x7d5059)
        >  #6 in cppu::PropertySetMixinImpl::getPropertyValue(rtl::OUString const&) at cppuhelper/source/propertysetmixin.cxx:994:20 (instdir/program/libuno_cppuhelpergcc3.so.3 +0x7e462f)
        >  #7 in reportdesign::OFixedText::getPropertyValue(rtl::OUString const&) at reportdesign/source/core/api/FixedText.cxx:143:34 (instdir/program/../program/librptlo.so +0x7452ad)
        >  #8 in non-virtual thunk to reportdesign::OFixedText::getPropertyValue(rtl::OUString const&) at reportdesign/source/core/api/FixedText.cxx (instdir/program/../program/librptlo.so +0x7452eb)
        >  #9 in rptui::OPropertyMediator::OPropertyMediator(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, std::__debug::map<rtl::OUString, std::pair<rtl::OUString, std::shared_ptr<rptui::AnyConverter>>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, std::pair<rtl::OUString, std::shared_ptr<rptui::AnyConverter>>>>>&&, bool) at reportdesign/source/core/sdr/PropertyForward.cxx:68:119 (instdir/program/../program/librptlo.so +0xbbbdb7)
        >  #10 in rptui::OUnoObject::CreateMediator(bool) at reportdesign/source/core/sdr/RptObject.cxx:878:31 (instdir/program/../program/librptlo.so +0xc16451)
        >
        > Address 0x7fff4e6b0700 is located in stack of thread T0 at offset 4288 in frame
        >  #0 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:50 (instdir/program/libgcc3_uno.so +0x1181d7)
        >
        >   This frame has 3 object(s):
        >     [32, 104) 'data' (line 53)
        >     [144, 160) 'longs' (line 162)
        >     [176, 192) 'doubles' (line 166) <== Memory access at offset 4288 overflows this variable
        > HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
        >       (longjmp and C++ exceptions *are* supported)
        > SUMMARY: AddressSanitizer: dynamic-stack-buffer-overflow bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:155:51 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
        > Shadow bytes around the buggy address:
        >   0x7fff4e6b0480: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0680: 00 00 00 00 00 00 00 00 00 00 00 00 ca ca ca ca
        > =>0x7fff4e6b0700:[04]cb cb cb cb cb cb cb 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        >   0x7fff4e6b0980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
        > Shadow byte legend (one shadow byte represents 8 application bytes):
        >   Addressable:           00
        >   Partially addressable: 01 02 03 04 05 06 07
        >   Heap left redzone:       fa
        >   Freed heap region:       fd
        >   Stack left redzone:      f1
        >   Stack mid redzone:       f2
        >   Stack right redzone:     f3
        >   Stack after return:      f5
        >   Stack use after scope:   f8
        >   Global redzone:          f9
        >   Global init order:       f6
        >   Poisoned by user:        f7
        >   Container overflow:      fc
        >   Array cookie:            ac
        >   Intra object redzone:    bb
        >   ASan internal:           fe
        >   Left alloca redzone:     ca
        >   Right alloca redzone:    cb
        > ==612573==ABORTING
        
        when opening <https://bugs.documentfoundation.org/attachment.cgi?id=174542>
        Example2Fields.odb attached to
        <https://bugs.documentfoundation.org/show_bug.cgi?id=144072> "LibreofficeBase
        crashed when 2 fields selected in report builder from different sections and
        width is adjusted 2nd time" and clicking "Edit..." in the context menu of the
        "RptTasks" report.
        
        Change-Id: I318765aede68353d475a0d672e0aea36ed12af29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155286
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-03  Stephan Bergmann  <sbergman@redhat.com>  [40bb18802eb7ccdb60cbf9a68f6228f769468410]

        Silence another C++20 -Wdeprecated-volatile with old GLib
        
        ...that hit with patch set 3 of
        <https://gerrit.libreoffice.org/c/core/+/155121/3> "Bump baseline to C++20",
        
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/vcl/unx/gtk3/customcellrenderer.cxx:29:1: error: use of result of assignment to object of volatile-qualified type 'volatile gsize' (aka 'volatile unsigned long') is deprecated [-Werror,-Wdeprecated-volatile]
        > G_DEFINE_TYPE(CustomCellRenderer, custom_cell_renderer, GTK_TYPE_CELL_RENDERER_TEXT)
        > ^
        > /usr/include/glib-2.0/gobject/gtype.h:1595:43: note: expanded from macro 'G_DEFINE_TYPE'
        > #define G_DEFINE_TYPE(TN, t_n, T_P)                         G_DEFINE_TYPE_EXTENDED (TN, t_n, T_P, 0, {})
        >                                                             ^
        > /usr/include/glib-2.0/gobject/gtype.h:1737:117: note: expanded from macro 'G_DEFINE_TYPE_EXTENDED'
        > #define G_DEFINE_TYPE_EXTENDED(TN, t_n, T_P, _f_, _C_)      _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, _f_) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
        >                                                                                                                      ^
        > /usr/include/glib-2.0/gobject/gtype.h:1985:7: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_END'
        >       g_once_init_leave (&g_define_type_id__volatile, g_define_type_id); \
        >       ^
        > /usr/include/glib-2.0/glib/gthread.h:257:17: note: expanded from macro 'g_once_init_leave'
        >     (void) (0 ? *(location) = (result) : 0);                         \
        >                 ^
        
        (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/145888/>), but which
        is also addressed by upstream
        <https://gitlab.gnome.org/GNOME/glib/-/commit/fab561f8d05794329184cd81f9ab9d9d77dcc22a>
        "gobject: Drop use of volatile from get_type() macros"
        
        Change-Id: I9f7e45133cb15a71cba838190454a809488142d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155277
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e4429983eb73c8e0ce27feb3c5fa35bead64b88]

        tdf#147955: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I8247d55a5d31512deeb778ad3cbe4f2569d50440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155281
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [313be607903a381830600c0a60b2e299fcaec685]

        Related: cool#6911 opt to skip SdrObject::GetViewContent() when possible
        
        as seen in: https://user-images.githubusercontent.com/122848/253732636-3dfeddad-f146-4268-bde5-85788b72d539.svg
        
        SdrPageView::DrawLayer takes ~11% of the time when scrolling with
        many comments in calc, but none of these comments actually get drawn,
        all this effort is to find that they are not to be drawn.
        
        optimize ViewContactOfPageHierarchy impl over its parent impl to skip
        SdrObject::GetViewContent(), etc if the SdrObject isn't shown on the
        target layer.
        
        ViewObjectContactOfSdrobject::getPrimitive2DSequenceHierarchy does the
        same check, but after a set of allocations which is expensive in the
        case of SdrCaptions in a calc internal layer where there can be
        thousands of such objects.
        
        Change-Id: Iad86c77e8fa71ec90f54ce06d5a27c0380fb03ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155269
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-03  Hossein  <hossein@libreoffice.org>  [a99a63287f96290f5641a4216432f7b637402ea6]

        tdf#156560 Fix assertion failure editing RTL header
        
        Clicking on an RTL header previously lead to assertion failure, but now
        it is checked if the SwFrame pointer is null. If so, an empty vector is
        returned.
        
        It should be noted that the rendering of the rtl header in the
        attachment 188689 is still wrong as the text and image are misplaced.
        
        A test is added to the patch, and can be run using:
        
         make CppunitTest_sw_uiwriter8 CPPUNIT_TEST_NAME=testTdf156560
        
        Change-Id: I9e8f66895b4ef9369300c9d7c03d22a2085a1d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155159
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-08-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [88e7ef864076d9ebe62c2afe926f67c768884b77]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b9431287ea5b01b4f854c9363d6250bcfc1f767
          - tdf#154210 Add target HIDs in the Navigator help page
            
            This patch adds new HIDs to the Navigator help page corresponding to the entries in the submenus of the Navigator context menu.
            
            Change-Id: I7a47339dda54c7f7c03a55684b4387707032dcda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155242
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-03  Michael Stahl  <michael.stahl@allotropia.de>  [bd996a23bc4780579fc17e23d8f9f16e2af60289]

        tdf#145743 sw: don't delete empty page with ColLocked section
        
        In MakeFrames(), the new frames are inserted into a section frame,
        before an existing frame; the existing frame is MoveFwd() to the next
        page, so the call to CheckPageDescs() finds the page frame empty and
        deletes it, along with the section frame.
        
        Check the mbColLocked flag set by MakeFrames() to prevent it.
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: I4e02a85314adaf07794fd6b5447bd78d39597b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155266
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a53c693564f95acdbf6686e00b86671c0e068c48]

        Related: cool#6911 refactor for an optimization
        
        no change intended here
        
        Change-Id: I34b72776b1a05979fbe3a02ff1548b6aa8a183df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-03  Miklos Vajna  <vmiklos@collabora.com>  [107de1a2c6882213cf0ef6783417302f43cdada0]

        tdf#156349 sw floattable: fix caption insert for tables inside split fly frames
        
        Inserting a long enough caption below the table inside a split fly
        resulted in a layout loop.
        
        An additional, second problem is that in case a split fly only has a
        table, that can be mapped to a floating table in Word formats, but once
        a caption is inserted after the table (but still inside the frame), then
        this will be a normal shape, which can't be split.
        
        Fix the problem by disabling the "is split allowed" property on the fly
        in case it's on, and only then insert the caption.
        
        This not only avoids the layout loop, it also results in rendering that
        will match after save + load, for Word formats.
        
        Change-Id: Ie8b04e6266dd5c4068e5add86efb09cc6a6ea01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155276
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-03  Paris Oplopoios  <paris.oplopoios@collabora.com>  [981f0f2a661b4615ef9cc4fb24fd05087fb22c10]

        Test paintPartTile behavior for views with different schemes
        
        It would be the case that sometimes paintPartTile would use a different
        view to draw the tiles without first checking if they have matching
        schemes, which would cause bad tiles and previews
        
        Change-Id: I3a268552132718a25eccbc4284c82dc31c6ca2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155154
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 8b96443e6c726a707069412b77e87be5da852150)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155240
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-08-03  Miklos Vajna  <vmiklos@collabora.com>  [3bf0f056eb7eba1f3569f95731e1014384fc53dd]

        sfx2: fix crash in SfxLokHelper::notifyOtherViews()
        
        Crashreport signature:
        
        program/libmergedlo.so
                SfxLokHelper::notifyOtherViews(SfxViewShell const*, int, boost::property_tree::basic_ptree<std::string, std::string, std::less<std::string> > const&)
                        sfx2/source/view/lokhelper.cxx:518
        program/libmergedlo.so
                ImpEditView::ShowCursor(bool, bool)
                        editeng/source/editeng/impedit.cxx:1447
        program/libsclo.so
                ScViewData::SetEditEngine(ScSplitPos, ScEditEngineDefaulter*, vcl::Window*, short, int)
                        sc/source/ui/view/viewdata.cxx:1635
        program/libsclo.so
                ScTabView::UpdateEditView()
                        sc/source/ui/view/tabview3.cxx:2190
        program/libsclo.so
                ScTabView::extendTiledAreaIfNeeded()
                        sc/source/ui/view/tabview.cxx:3098
        program/libmergedlo.so
                doc_setClientVisibleArea
                        desktop/source/lib/init.cxx:6248
        
        The current view should ideally never be nullptr, but if that's the
        case, at least don't crash.
        
        Change-Id: I521faa54373d2ce5ffb0983bac6caf0705767fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155275
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-03  Miklos Vajna  <vmiklos@collabora.com>  [da68615da5c8ee06d02872dd60062f7c2d59f019]

        UITest_validity: use oneprocess mode
        
        Before: 0m44,958s
        
        After: 0m29,853s
        
        Also UITest_chapterNumbering: 0m27,926s -> 0m20,910s
        
        Change-Id: I0172e3d96a4e6d19e3cf1e98fb9145b9bae1096e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155267
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-03  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7f85415a2f07d62bf688cb33680054940d4dd7f1]

        move SwVirtPageNumInfo to SfxHint
        
        - also remove now obsolete GetInfo overrides
        
        Change-Id: Iaac75ed2e53daead06242ce4620fd2b879909e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155061
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-08-03  Justin Luth  <jluth@mail.com>  [eef0c5d4d45ba35acfb6d8f7551fe565ca4badaa]

        tdf#71550 autorecovery: use osl::File::Remove when isEmptyFileUrl
        
        Mike K suggested I just use the simpler, faster function in this case.
        
        Change-Id: I0f7f6611f12f88cd1daa4104b58eb44365a44ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155271
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-03  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [34387332173782498acd4998c7c665d04ebc3c7d]

        tdf#153102: use given RedrawArea in DoProcessDisplay
        
        In ObjectContactOfPageView::DoProcessDisplay someone changed
        (seven years ago) to ignore the given RedrawArea if
        comphelper::LibreOfficeKit::isActive(). Using and setting that
        RedrawArea is needed to get the visual clipping against e.g.
        PageBounds in Writer paint working. Adding that again.
        
        Change-Id: If628039379c2756aac8865c3632e37c19993d0da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155262
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [041e8806f2640e69634aee6a0a681e2f07b387eb]

        tdf#156550 - a11y - fix sidebar complains about TOC hyperlinks
        
        Just comparing strings of url text and url link target.
        
        Change-Id: Iaf6196512214195a947429cd2d5e00cf9be46b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155202
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-02  Paris Oplopoios  <paris.oplopoios@collabora.com>  [06ebb2a0c94e89eb638b0aec3d597a83dfafd10c]

        Compare viewRenderState before setting view on doc_paintPartTile
        
        It shouldn't be the case that the view is changed upon painting a tile
        if the new view has different view options, as it may have a different
        theme (light/dark)
        
        Change-Id: Ie218ab1ca99a588cd04e93deb7b42a18b354b811
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154940
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 8e90368b55b2a8c23ccae8aa6cd1e157294a67db)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155172
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-08-02  Justin Luth  <jluth@mail.com>  [fe55282c02a3306ac1c7971a5c2c85c52f54d205]

        tdf#144512 autorecovery: don't delay autosave on shutdown
        
        Change-Id: I98ee31369aa46c4e3aeb405ec11a1ef197c31fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155165
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [7aae2fbef91d00afaded26215f48fcdb2070b6ef]

        tdf#95400: svgio: Add unittest
        
        Change-Id: I88d56bafce22231ca05864ee9dbeb8c31b4dcb50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155265
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bb51f5096fd37925c2124161ef8637645320d7de]

        tdf#156581 Add extended tips to Title Page dialog
        
        Change-Id: Id0a2e06c1683c591190694dd40b2b3548272405a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155256
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3a4fc93c74760956fdfe88bd6a25c9062fc29b42]

        Bump titlepage.ui to latest Glade release
        
        no changes
        
        Change-Id: I8d0f9d698d0bd8c37a6d0baa5e4de904bcdc019a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155255
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-08-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c8d8bf4282cbd04abacfa69ba2cc0fa4300e35e1]

        sc: theme color support for sparklines + ODF & OOXML import/export
        
        This changes Sparkline colors to use complex colors instead and
        adds Sparkline theme color import and export support for ODF and
        OOXML.
        
        Change-Id: I58edd525d50f95199bd4fe7825afb51aaa7fc091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155113
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-02  Michael Stahl  <michael.stahl@allotropia.de>  [2d96d69322ac18f53668b75397c8587f94cd043b]

        tdf#156546 sw: fix infinite loop in SwUndoInsert::RedoImpl()
        
        The problem is that SwUndoSaveContent::MovePtBackward() sets the point
        of a shell cursor to the document body's start node, which is not a
        valid position for a shell cursor; FindParentText() then loops forever.
        
        The purpose of this appears to be to move the point temporarily
        somewhere where subsequent inserting operations won't move it further,
        so that it can be restored to the start of the inserted stuff.
        
        Refactor a bit to use a temporary SwNodeIndex instead, which should work
        as nothing should delete the node it's pointing to.
        
        (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
        
        Change-Id: I471bcced1741c77c07239ed124d4fd39ff7a7515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155227
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [79646e204f5d558f5519186cb62ef1c9254f857f]

        tdf#156577: do no use parent position if x array is empty
        
        Change-Id: Id29e5a440dbc3719c53bcc9226336a3c99d469e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155216
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [aaba06d2fca3264cd73093ffc048af27992bd0fb]

        Silence C++20 volatile increment deprecation warnings
        
        ...as seen with path set 2 of <https://gerrit.libreoffice.org/c/core/+/155121/2>
        "Bump baseline to C++20",
        
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/vcl/source/app/watchdog.cxx:19:
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/vcl/inc/opengl/zone.hxx:16:
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:59:39: error: increment of object of volatile-qualified type 'CrashZone::AtomicCounter' (aka 'volatile unsigned int') is deprecated [-Werror,-Wdeprecated-volatile]
        >     static void enter() { gnEnterCount++; }
        >                                       ^
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:60:39: error: increment of object of volatile-qualified type 'CrashZone::AtomicCounter' (aka 'volatile unsigned int') is deprecated [-Werror,-Wdeprecated-volatile]
        >     static void leave() { gnLeaveCount++; }
        >                                       ^
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:59:39: error: increment of object of volatile-qualified type 'CrashZone::AtomicCounter' (aka 'volatile unsigned int') is deprecated [-Werror,-Wdeprecated-volatile]
        >     static void enter() { gnEnterCount++; }
        >                                       ^
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:54:19: note: in instantiation of member function 'CrashZone<SkiaZone>::enter' requested here
        >     CrashZone() { enter(); }
        >                   ^
        > /home/tdf/lode/jenkins/workspace/android_arm/vcl/inc/skia/zone.hxx:23:5: note: in instantiation of member function 'CrashZone<SkiaZone>::CrashZone' requested here
        >     SkiaZone() { assert(comphelper::SolarMutex::get()->IsCurrentThread()); }
        >     ^
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/vcl/source/app/watchdog.cxx:19:
        > In file included from /home/tdf/lode/jenkins/workspace/android_arm/vcl/inc/opengl/zone.hxx:16:
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:60:39: error: increment of object of volatile-qualified type 'CrashZone::AtomicCounter' (aka 'volatile unsigned int') is deprecated [-Werror,-Wdeprecated-volatile]
        >     static void leave() { gnLeaveCount++; }
        >                                       ^
        > /home/tdf/lode/jenkins/workspace/android_arm/include/comphelper/crashzone.hxx:55:20: note: in instantiation of member function 'CrashZone<SkiaZone>::leave' requested here
        >     ~CrashZone() { leave(); }
        >                    ^
        > /home/tdf/lode/jenkins/workspace/android_arm/vcl/inc/skia/zone.hxx:23:5: note: in instantiation of member function 'CrashZone<SkiaZone>::~CrashZone' requested here
        >     SkiaZone() { assert(comphelper::SolarMutex::get()->IsCurrentThread()); }
        >     ^
        
        (<https://ci.libreoffice.org/job/gerrit_android_arm/31168/>)
        
        Change-Id: Ia63c54ed5bde6678ef6b544c1edad9600534ff05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155264
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Justin Luth  <jluth@mail.com>  [f080ef9daf7519cc53f5f341bfa1d60b1ee4b964]

        tdf#65509 autorecovery: don't UserAutoSave during EmergencySave
        
        Saving overtop of the working document during a crash save
        does not sound like a safe thing to do.
        
        However, an ODF recovery export is attempted
        which will preserve unsaved modifications,
        so avoiding this save should not cause data loss.
        
        Change-Id: Ie993042b4c99d5dfb816727d4bfae5bca694d72f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155166
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-02  Michael Stahl  <michael.stahl@allotropia.de>  [16aa870598d00eb3e6ac15435fef080d3b87cbc1]

        tdf#156306 sw: PDF export: duplicate structure element from ...
        
        ... lazy open LIBody - with mpFrameInfo, not mpNumInfo - causes this
        assert and later an infinite loop as the SE is its own parent:
        
        sw/source/core/text/EnhancedPDFExportHelper.cxx:468: void SwTaggedPDFHelper::BeginTag(vcl::PDFWriter::StructElement, const rtl::OUString&): Assertion `rFrameTagSet.find(pKey) == rFrameTagSet.end()' failed.
        
        (regression from commit d467f1aa3d028f399826c97e2eecedcd79efcf65)
        
        Change-Id: I90f057c45a22e5ef44ae5ae9d1cb1d6b8870379f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155253
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [4e63159387b490e5ea49471f13c30ad60923e866]

        Make the Xcode workaround apply more broadly
        
        ...so that it should also work for
        <https://ci.libreoffice.org/job/gerrit_mac/151630/>, which reports
        
        > checking whether Xcode is new enough... yes (13.3.1)
        
        Change-Id: Ifae5d4d3516d4af8947fe663d557dc232ea22ab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155263
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [f76acf9bd97e65ba50303b6e5a25e5877996ebe1]

        tdf#156525 Save as > HTML loses drawing object as invalid gif
        
        regression from
            commit 1c7cbd685633d44eac554629572f3401c450f855
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sun May 7 16:56:21 2023 +0200
            use AlphaMask for variables when calling GetAlphaMask
        
        where after my change, the code is now calling
            Bitmap::Replace(AlphaMask,...)
        instead of
            Bitmap::Replace(Bitmap,...)
        and those two methods do quite different things.
        
        However, we have to
        (*) restore Bitmap::Replace(Bitmap,...) which was removed in
            commit 8270eb5d5600cc84dbf5f0e339f90c4519ef88bb
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri May 19 13:35:31 2023 +0200
            loplugin:unusedmethods
        (*) restore BitmapWriteAccess::SetPaletteEntryCount which was removed in
            commit 74cd0d0b281f8df75612bfb600df2eae62c4d21d
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 29 13:53:30 2023 +0200
            loplugin:unusedmethods
        (*) Invert the mask/alpha layer, since after
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        we are dealing with real alpha, and not transparency.
        
        Also add an assert in GIFWriter::WriteAccess, since it is a logic error
        to get here and have the image in the wrong format.
        
        Change-Id: I0e09b3ca82af0bd5b58d80e0a6eac4c7bdf7c48e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155254
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [76f50549f4898313ef4a18ce32d1f0a625ce766d]

        tdf#156579: treat switch element as a group
        
        Regression from
        
        commit 13a41e7a12598c7896d6dc8d34aba6af5b80b83c
        Author: Xisco Fauli <xiscofauli@libreoffice.org>
        Date:   Mon Jul 3 14:11:43 2023 +0200
        
        tdf#150124: do nothing when parent is of unkown type
        
        because 'switch' is not a known token. For now it, treat
        it as a group
        
        No need to have a unittest for this
        
        Change-Id: I4cae92a010e45cd729db475a7abccab19a5d5403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155250
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-02  Julien Nabet  <serval2412@yahoo.fr>  [5f6c337bbb3bdfbea05484ad0cc6ff58d575a39b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c1992ef335ba67137134fe99672db631a7782c7
          - Related tdf#156580: CreateUnoServiceWithArguments is spelled differently in help
            
            Change-Id: Ibad8b393d2a41e4aecc24fefa9bd95ffe27e35f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155235
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [14e016954f40216db10fab72fe41a7def6739aab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to be5d286b0ffd12cf11d8f6fa89c46bf72a9140de
          - tdf#156581 Improve Title Page Help
            
            Change-Id: I869479693e045862f49bcf555ff6463946bce8cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155257
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [e5ac79108ae8605a435d254c5d9cca142e1eecd8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a31551f0c593fc33f59afca3f8bdb8d1a4473912
          - tdf#156332 Fix HID in View - Toolbars (Writer)
            
            This patch adds the target HIDs for all toolbars that currently have help pages.
            
            The exceptions are listed below (they were not fixed because they do not have help pages of their own)
            - 3D Settings
            - Media Playback
            
            Change-Id: I24077431495b2bf98ae4be982734c07a11734b7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154965
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Julien Nabet  <serval2412@yahoo.fr>  [9980ccb59af9149d20cba92d31e840f91c1dbe02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37c3a04916cc6d3e605e33de0733d58e6ba37f1f
          - tdf#156580: CreateUnoService is spelled differently in help
            
            Change-Id: I98728e1215a716f9e35080e819956d0801922284
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155234
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Mike Kaganski  <mike.kaganski@collabora.com>  [ee24f1680bc48d62e03221014af642b3cb8923d8]

        Replace separate components list with 'gb_CppunitTest_use_rdb'
        
        Change-Id: Iab1556d0f32707edb52c3cae7c1443a1eaf3b57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155213
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [5831d5f03a5ea5b89984574ffe436f38500726da]

        Don't enable the requires clause for some Xcode Clang
        
        ...even when building with -std=c++20 (cf.
        <https://gerrit.libreoffice.org/c/core/+/155121> "Bump baseline to C++20"), as
        that causes
        
        > In file included from animations/source/animcore/animcore.cxx:20:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:
        > workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65: error: invalid application of 'sizeof' to an incomplete type 'animcore::(anonymous namespace)::AnimationNode'
        > template<typename T> inline constexpr auto isUnoInterfaceType = sizeof (T) && IsUnoInterfaceType<T>::value;
        >                                                                 ^~~~~~~~~~
        > include/unotools/weakref.hxx:119:33: note: in instantiation of variable template specialization 'cppu::detail::isUnoInterfaceType' requested here
        >         requires(!cppu::detail::isUnoInterfaceType<interface_type>)
        >                                 ^
        > animations/source/animcore/animcore.cxx:310:44: note: in instantiation of template class 'unotools::WeakReference<animcore::(anonymous namespace)::AnimationNode>' requested here
        >     unotools::WeakReference<AnimationNode> mxParent;
        >                                            ^
        > animations/source/animcore/animcore.cxx:122:7: note: definition of 'animcore::(anonymous namespace)::AnimationNode' is not complete until the closing '}'
        > class AnimationNode final:  public AnimationNodeBase
        >       ^
        
        at least with Xcode 14.3.1.
        
        Change-Id: Iea6690578cd328545f54254acc0099947778c03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155220
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [9bbed2130708aa28d8650394cf112b5932224059]

        external/skia: Avoid -std:c++20 with known-broken VS-provided clang-cl
        
        ...as witnessed with patch set 1 of
        <https://gerrit.libreoffice.org/c/core/+/155121/1> "Bump baseline to C++20",
        
        > In file included from C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/skia/src/base/SkBezierCurves.cpp:8:
        > In file included from C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/skia\src/base/SkBezierCurves.h:10:
        > C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/skia\include/private/base/SkSpan_impl.h(122,1): error: C++ requires a type specifier for all declarations
        > SkSpan(Container&&) ->
        > ^
        > C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/skia/src/base/SkBezierCurves.cpp(185,12): error: use of class template 'SkSpan' requires template arguments
        >     return SkSpan{intersectionStorage, intersectionCount};
        >            ^
        > C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/UnpackedTarball/skia\include/private/base/SkSpan_impl.h(64,7): note: template is declared here
        > class SkSpan {
        >       ^
        
        etc. (<https://ci.libreoffice.org/job/gerrit_windows/160027/>)
        
        Change-Id: I6166f1cb49ac1540ec1c4d3bc3331c8b228efa27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155228
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [4a3da80a9eb1a95a4cd3c8a98a37d480d7a29bba]

        Make RectangleTemplate comparison operators symmetric
        
        ...to avoid
        
        > In file included from tools/qa/cppunit/test_rectangle.cxx:10:
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:59:18: error: ISO C++20 considers use of overloaded operator '==' (with operand types 'const tools::Rectangle' and 'const tools::Rectangle') to be ambiguous despite there being a unique best viable function [-Werror,-Wambiguous-reversed-operator]
        >         return x == y;
        >                ~ ^  ~
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:166:30: note: in instantiation of member function 'CppUnit::assertion_traits<tools::Rectangle>::equal' requested here
        >   if ( !assertion_traits<T>::equal(expected,actual) ) // lazy toString conversion...
        >                              ^
        > tools/qa/cppunit/test_rectangle.cxx:70:9: note: in instantiation of function template specialization 'CppUnit::assertEquals<tools::Rectangle>' requested here
        >         CPPUNIT_ASSERT_EQUAL(aRect, aRect2);
        >         ^
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:333:17: note: expanded from macro 'CPPUNIT_ASSERT_EQUAL'
        >   ( CPPUNIT_NS::assertEquals( (expected),              \
        >                 ^
        > include/tools/gen.hxx:817:18: note: ambiguity is between a regular call to this operator and a call with the argument order reversed
        >     bool         operator == ( const RectangleT& rRect ) const
        >                  ^
        
        when building with -std=c++20 (cf.
        <https://gerrit.libreoffice.org/c/core/+/155121> "Bump baseline to C++20")
        against at least Xcode 14.3.1.
        
        It was presumably an accidental oversight that
        b6b26421a1029b18b48b69dbdac4bb70fb622604 "split Point/Size/Rectangle into
        AbsoluteScreenPixel* types" made these operators asymmetric in the first place.
        
        Change-Id: Ic1f08b79fbd727d972ce95c3f21eab3a2a74f942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155221
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Miklos Vajna  <vmiklos@collabora.com>  [f151ba5ebc8662d5459eacb1c5d6f01a4c826f26]

        sw floattable: simplify collecting frames at node with layout
        
        See
        <https://gerrit.libreoffice.org/c/core/+/155081/2#message-504c4b6d36580e30bf79498a4ca5e37573194dba>,
        one dynamic cast is enough.
        
        Change-Id: I1f57b1b64fb501e522c949e013160df79ea55094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155218
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-02  Stephan Bergmann  <sbergman@redhat.com>  [1c3c27bc2e42f70e588ef5dbc769a8a346042e04]

        Silence some bogus -Werror=array-bounds etc. with GCC 12 and -std=c++20
        
        ...as witnessed with patch set 1 of
        <https://gerrit.libreoffice.org/c/core/+/155121/1> "Bump baseline to C++20",
        
        > In file included from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/char_traits.h:46,
        >                  from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/ios:40,
        >                  from /opt/rh/gcc-toolset-12/root/usr/include/c++/12/ostream:38,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/include/rtl/ustring.hxx:34,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/include/svl/gridprinter.hxx:13,
        >                  from /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/svl/source/misc/gridprinter.cxx:10:
        > In function ‘constexpr decltype (::new(void*(0)) _Tp) std::construct_at(_Tp*, _Args&& ...) [with _Tp = long unsigned int; _Args = {const long unsigned int&}]’,
        >     inlined from ‘static constexpr void std::allocator_traits<std::allocator<_CharT> >::construct(allocator_type&, _Up*, _Args&& ...) [with _Up = long unsigned int; _Args = {const long unsigned int&}; _Tp = long unsigned int]’ at /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/alloc_traits.h:518:21,
        >     inlined from ‘constexpr void std::vector<_Tp, _Alloc>::_M_realloc_insert(iterator, _Args&& ...) [with _Args = {const long unsigned int&}; _Tp = long unsigned int; _Alloc = std::allocator<long unsigned int>]’ at /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/vector.tcc:462:28,
        >     inlined from ‘constexpr void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = long unsigned int; _Alloc = std::allocator<long unsigned int>]’ at /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/stl_vector.h:1287:21,
        >     inlined from ‘mdds::mtv::soa::multi_type_vector<Traits>::iterator mdds::mtv::soa::multi_type_vector<Traits>::set_cell_to_empty_block(size_type, size_type, const T&) [with T = rtl::OUString; Traits = mdds::multi_type_matrix<svl::{anonymous}::matrix_traits>::mtv_trait]’ at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/mdds/include/mdds/./multi_type_vector/soa/main_def.inl:2995:50,
        >     inlined from ‘mdds::mtv::soa::multi_type_vector<Traits>::iterator mdds::mtv::soa::multi_type_vector<Traits>::set_impl(size_type, size_type, const T&) [with T = rtl::OUString; Traits = mdds::multi_type_matrix<svl::{anonymous}::matrix_traits>::mtv_trait]’ at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/mdds/include/mdds/./multi_type_vector/soa/main_def.inl:1240:72,
        >     inlined from ‘mdds::mtv::soa::multi_type_vector<Traits>::iterator mdds::mtv::soa::multi_type_vector<Traits>::set(size_type, const T&) [with T = rtl::OUString; Traits = mdds::multi_type_matrix<svl::{anonymous}::matrix_traits>::mtv_trait]’ at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/mdds/include/mdds/./multi_type_vector/soa/main_def.inl:696:14,
        >     inlined from ‘void mdds::multi_type_matrix<Traits>::set(size_type, size_type, const string_type&) [with Traits = svl::{anonymous}::matrix_traits]’ at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/workdir/UnpackedTarball/mdds/include/mdds/multi_type_matrix_def.inl:356:5,
        >     inlined from ‘void svl::GridPrinter::set(size_t, size_t, const rtl::OUString&)’ at /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_gcc_release_64/svl/source/misc/gridprinter.cxx:68:25:
        > /opt/rh/gcc-toolset-12/root/usr/include/c++/12/bits/stl_construct.h:97:14: error: array subscript 0 is outside array bounds of ‘long unsigned int [0]’ [-Werror=array-bounds]
        >    97 |     { return ::new((void*)__location) _Tp(std::forward<_Args>(__args)...); }
        >       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        (<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/148699/>), etc.
        
        (The curly braces in sw/source/core/doc/doc.cxx had to be added to avoid an
        ensuing bogus
        
        > sw/source/core/doc/doc.cxx: In static member function ‘static void SwDoc::CalculatePagePairsForProspectPrinting(const SwRootFrame&, SwRenderData&, const SwPrintUIOptions&, sal_Int32)’:
        > sw/source/core/doc/doc.cxx:1000:5: error: ‘else’ without a previous ‘if’
        >  1000 |     else
        >       |     ^~~~
        
        )
        
        Change-Id: I902f6d74d897b9bf281dc9c821aff30e7e72582a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155215
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [37421677cea4969ffecdeb2a58488bae22f81782]

        tdf#156514 Check spelling red underlines are gone
        
        Regression from
            commit af34f4ea62d8aabbab5d4028034aa2482c16fe8a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jul 6 10:52:07 2023 +0200
            avoid skia assert and slow-path
        
        Change-Id: Ib81c7d341a88e72fb0a48a39703485261ac6679c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-02  Julien Nabet  <serval2412@yahoo.fr>  [045d0d6845e0120020140407879e050d52ceb6fa]

        Fix gtk4: conversion from 'AbsoluteScreenPixelRectangle' to 'tools::Rectangle'
        
        Following b6b26421a1029b18b48b69dbdac4bb70fb622604
        "split Point/Size/Rectangle into AbsoluteScreenPixel* types"
        
        I got this error:
        In file included from /home/julien/lo/libreoffice/vcl/unx/gtk4/gtksalmenu.cxx:10:
        /home/julien/lo/libreoffice/vcl/unx/gtk4/../gtk3/gtksalmenu.cxx:470:22: error: no viable conversion from 'AbsoluteScreenPixelRectangle' to 'tools::Rectangle'
            tools::Rectangle aFloatRect = FloatingWindow::ImplConvertToAbsPos(xParent, rRect);
                             ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/include/tools/gen.hxx:
        879:23: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'AbsoluteScreenPixelRectangle' to 'const tools::Rectangle &' for 1st argument
        class SAL_WARN_UNUSED Rectangle final : public RectangleTemplate<Rectangle, Point, Size>
                              ^
        /home/julien/lo/libreoffice/include/tools/gen.hxx:879:23: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'AbsoluteScreenPixelRectangle' to 'tools::Rectangle &&' for 1st argument
        /home/julien/lo/libreoffice/include/tools/gen.hxx:888:24: note: explicit constructor is not a candidate
            constexpr explicit Rectangle(const AbsoluteScreenPixelRectangle & r);
        
        Change-Id: I3e77ce65ba1c5f2ab8cad818f8158b65abe510eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155214
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2023-08-02  Khaled Hosny  <khaled@libreoffice.org>  [790ccec0bdb65adca32e7cde6d1b42c59ca6d567]

        vcl: Simplify analyzeSfntFamilyName
        
        We only need a family name not a set of name, and drop a work around for
        a broken font that is probably long obsolete.
        
        Change-Id: I219ec58e65826250d08b3e88462fdcc1e2e2b7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155195
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-02  Khaled Hosny  <khaled@libreoffice.org>  [444e246535a7cf56b94143823845ec4bd2628236]

        vcl: Drop the PrintFont -> FastPrintFontInfo -> FontAttributes indirection
        
        We want FontAttributes at the end, so lets have them up front instead of
        the intermediary structures.
        
        Change-Id: Iafdf17f4a7615f0c3d972e6080cebea0183840b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155191
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-02  Khaled Hosny  <khaled@libreoffice.org>  [0c019cb7c13be75210be824e0f1601d59310a23f]

        vcl: Drop unused FontAttributes::GetMapNames()/AddMapName()
        
        Change-Id: I50e06ad24e95cab39009a8affb876ebc920c1c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155168
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-02  Khaled Hosny  <khaled@libreoffice.org>  [aa53ccd834adcd4dde36dcf36b620984b18711b3]

        vcl: Drop unused PhysicalFontFamily::GetAliasNames()
        
        Change-Id: Ide306f0656230460f976daef0ed213f734136030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155167
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-02  Khaled Hosny  <khaled@libreoffice.org>  [b3911f617d6af1e4fa7a3ed47ff6b85502d8066b]

        vcl: Fold two static method into their only call site
        
        Change-Id: Ifa943bd658892d4fcf8e47a6abfa245fbcaa78a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155161
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-02  Gülşah Köse  <gulsah.kose@collabora.com>  [5a683f2d7c59bbb9ad93172f8dcf43e9efa56053]

        Prevent to open multiple Theme Color Edit dialog
        
        When we do super fast clicks to Add button prevent to open multiple
        dialog. Follow-up commit e73b2bc4e6fdaba3098fa2c701342e1df112514c
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: If40c4982b873d41984bea298284eae062742b057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155083
        Tested-by: Jenkins

2023-08-02  Michael Stahl  <michael.stahl@allotropia.de>  [06bbcee6e367d1bc319c1f9cb0e749168e4d890c]

        tdf#152307 sw: layout: invalidate more frames when footer grows
        
        While on page 12:
        SwTabFrame::MakeAll() is called on 523 while it's on page 12; there is
        one invalid pos text frame 492 with a fly somewhere before it;
        PrepareMake() of 523 formats prevs 492 then 493 which MoveFwd() taking
        523 with it.
        
        While on page 13:
        TabFrame 523 is valid, and the footer 6651 never formatted (0 height).
        Formatting the footer in SwHeadFootFrame::FormatSize() invalidates the
        body 1031, immediately calls Calc() from SwFrame::MakePos(), where
        ~SwLayNotify() -> SwLayoutFrame::ChgLowersProp() invalidates
        SectionFrame 1034.
        
        Then SectionFrame 1034 is formatted, which via
        SwSectionFrame::CheckClipping() -> SwLayoutFrame::ChgLowersProp()
        invalidates only the last lower frame, because it checks the position of
        the frame and this frame still has a position on a previous page (it
        moved from page 12) and isn't even invalid yet.
        
        So in case there are invalid frames, the positions of the frames
        following these cannot be trusted to be used to optimize invalidations
        in SwLayoutFrame::ChgLowersProp().
        
        (aside: it seems odd to format the body text before the footer text, but
         in this case doing it differently wouldn't have helped because the
         problem was already caused on a previous page)
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: I23b35c09af3a373d0913d931a2ba59d45fadf2c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155196
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-08-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [f8c6be45b5862eb073eba0b8c327e38e3ac0c33c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c13eb798f7eb33dbaa98fdd09ddb5374c5fbf0fc
          - tdf#156573 Correctly resolve HID with "?" character
            
            Change-Id: I1642e5c56d0d67fe4170358a61ec786f313029e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155184
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Miklos Vajna  <vmiklos@collabora.com>  [b6a22e2be79cd874c7526107a6793fae692620dc]

        tdf#156260 sw floattable: avoid moving text from the last anchor to its precede
        
        The 5 page long bugdoc had a "dt" in the last paragraph, expanding that
        to an actual dummy text with F3 resulted in anchor text on both page 4
        and page 5, while the expected behavior is that text only wraps on the
        last page, i.e. page 5.
        
        What happened is that the (text) "offset" of the text frame anchors on
        pages 1..5 are meant to be all 0 (so the actual anchor text is only on
        the last page), but in practice the anchor text frame on page 5 had an
        offset of 1123, which breaks the invariant that in case a fly frame is
        split to N pages, then only the last matching anchor text frame has
        text. (If it has too much text, then a next page with just anchor text
        is fine, but 0..N-1 pages should have no anchor text.)
        
        Fix the problem by SwTextFrame::AdjustFollow_(): in case it would reach
        the end for the "has follow, but no follow's follow" case, then still
        avoid setting the offset of the follow in case we know this is text
        frame has a non-last split fly anchored in it.
        
        With this, the render result matches in no overlaps and also what Word
        does in a similar edit session. (No F3 there, but can paste similar text
        at the document end.)
        
        Change-Id: I6c8d4f825d9dc356bb2a3a87a2f9c2e6529ce533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155209
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [90189fb8a8786cc683ff88f04eb3d764cc46e32a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0de5c3029b8e31e68bc3324fdbc54667377ec923
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(9)
            
            + refactoring
            + Writer Format menu (part 9)
            
            Change-Id: I5de345ea59c4f11327d5dd56b91c3d63fa4f3745
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155205
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d38052fad0e0b32525ce76e82ca7fa4f449a3e8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8639e492e3161f216cd0ec16c32b0d4149e937dd
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(8)
            
            + refactoring
            + Writer Format menu (part 8)
            
            Change-Id: I70ae77276c69b0080608ca68586809d9f138f1fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155203
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1eae9c5cc2a62f007e6f33e6466bdb9eb28482ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 767abbced350d007bf6c3d88aedae16463c8c7a6
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(7)
            
            + refactoring
            + Writer Format menu (part 7)
            
            Change-Id: Ie42db50e3db0a0c22b819c0d9e2650dcab7beaf8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155201
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f00d81a5ebe5849ece498ea1792dfec603932a7c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9415fea9cfb6f28c9e2214736aabee2cff5fea40
          - tdf#135837 - Update anchoring of images in Writer
            
            + refactor
            
            Change-Id: Iee9f1bdc846d67dfc2d9a1b12782bd7203f8fb21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155200
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-08-02  Mike Kaganski  <mike.kaganski@collabora.com>  [53642824823d47c623527b33f2ea797fbb7383db]

        No boost in basic
        
        Change-Id: Iba8d1bacf37d29137c2d4f4ed6f0ea1206c84f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155186
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-02  Matt K  <mattkse@gmail.com>  [efae7b4a1f7248b01e8cd95577c09d772cfe5709]

        tdf#129713 Output message when using "--cat" with other LO instances running
        
        This change modifies the code that determines whether a 2nd LibreOffice
        instance is running during the startup of the new soffice.bin process.
        In that section of code, we simply write a new error message to console
        and pop-up a message box via FatalError.  The message tells the user
        that they should close other LibreOffice processes if they want to use
        the "--cat" or "--script-cat" command line options.
        
        Change-Id: I2c2a00c07d733e2f0ed6c0632f0f0d115188b116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154909
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6b26421a1029b18b48b69dbdac4bb70fb622604]

        split Point/Size/Rectangle into AbsoluteScreenPixel* types
        
        to attempt to make it obvious in code what kind of coordinate
        system we are dealing with.
        
        The idea is that by doing this, the compile-time type checking
        will flush out inconsistencies between different code.
        
        I started with vcl::Window::OutputToAbsoluteScreenPixel
        and worked outwards from there.
        
        Change-Id: Ia967d7a0bb38886695f3a761b85c8b9340ddb1c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154676
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d66ffef8558785f19908c8e526211b8225fa9125]

        fix up testTdf125334 to set a language of "none" for the chart labels
        
        i.e. add fo:language="zxx" fo:country="none" to the
        "Some long X Axis Label on Vertical X Axis..." labels
        so that there is no hyphenation attempt made on the
        text so that the same behaviour in the jenkins build
        where there is (presumably) not hyphenation available
        is seen on personal builds which might have hyphenation
        available.
        
        See commit d0cf5bb9bc267847f23f1bf1fde0df062a554059
        Date:   Mon Jul 31 13:17:15 2023 +0200
        
            CppunitTest_sw_layoutwriter2: fix up testTdf125334
        
        for more details
        
        Change-Id: Id0dc0abd785a32349eece6b7f658826f0fea571c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155151
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-02  Noel Grandin  <noelgrandin@gmail.com>  [39a6740b9b8ebea2cb169392a1cce95bf0633f6e]

        std::set->o3tl::sorted_vector for m_aFontFileToFontID
        
        sorted_vector is perfect for small sets of small objects, and
        fontId is an int.
        
        Change-Id: I6955ae1a8793c47cf79b3080e566d7b50896b3e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155192
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-08-02  Miklos Vajna  <vmiklos@collabora.com>  [da468c92cfd93c810a79ce7769832367df4ea2b8]

        CppunitTest_sw_htmlexport: clean up testFdo81276
        
        Still fails with commit 7dff37c65e08985b80ac79e13f5571819a8e739d
        (fdo#81276: sw: HTML import: fix inverted test in CSS import,
        2014-07-22) reverted, but now avoids the almost unused
        DECLARE_HTMLEXPORT_ROUNDTRIP_TEST macro.
        
        Change-Id: I8298606b8521009e733ba1e0ce6e513cd8f3db2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155198
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [3b1da48e8c5506e366977a5e888ec3897e3e1ca3]

        a11y: Don't always append window type to a11y name in debug builds
        
        Appending " (Type = <number>)" to the accessible name is probably
        meant for debugging purposes to see what type of window is
        involved, but doing that by default in debug builds has disadvantages,
        e.g.:
        
        1) It affects how assistive tooling, like screen readers, handles
        the accessible objects, therefore the behaviour with a debug build
        (what a developer working on something experiences) does not
        necessarily match what happens in non-debug builds (what end
        users will experience).
        
        For instance, when Orca announces the "Update styles" push button
        in Writer's formatting toolbar, it not only announces the extra
        type information for the objects in the hierarchy it announces
        anyway, but announces the panel in addition, since it has a non-empty
        name due to the appended type information.
        
        Announcement without this change in place (from Orca log):
        
            INFO:speech:SPEECH OUTPUT: ' (Type = 371) panel.'
            INFO:speech:SPEECH OUTPUT: 'Formatting (Type = 356) tool bar'
            INFO:speech:SPEECH OUTPUT: 'Update push button.'
        
        Announcement with this change in place:
        
            INFO:speech:SPEECH OUTPUT: 'Formatting tool bar'
            INFO:speech:SPEECH OUTPUT: 'Update push button.'
        
        2) It breaks selecting the object under the mouse cursor in
        Accerciser at least with the qt6 VCL plugin when the object is in
        a dialog, because the window name retrieved via the accessibility
        APIs (with the appended type information) does not match the one
        retrieved via Wnck [1].
        
        Therefore, don't append the type information by default,
        but only if environment variable
        `LIBO_APPEND_WINDOW_TYPE_TO_ACCESSIBLE_NAME` ist set
        (typically `LIBO_APPEND_WINDOW_TYPE_TO_ACCESSIBLE_NAME=1`,
        but any value other than "0" will do),
        so that can still be used for cases where having the type as
        part of the accessible name is useful.
        
        [1] https://gitlab.gnome.org/GNOME/accerciser/-/blob/5af3fdbfb8a7832e434ad6fc7d2ecaad18f2e32e/plugins/quick_select.py#L109
        
        Change-Id: Ie33b14fbdf9731b02c8c620d7a5ac718ef99367d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155094
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [e4ec702df16e04e66af42e2e35a607cb67d7d2c1]

        a11y: Convert AccessibleTableControlObjType to enum class
        
        Change-Id: I227ca242ae8fa22940b1bf302541f8d9b7b40eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155199
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [de9de202a6336f3ba8da0d2deeb8e1e34ac569ab]

        tdf#156473 a11y: Properly retrireve a11y context from XAccessible
        
        ... by using `XAccessible::getAccessibleContext` rather
        than trying to just query for the `XAccessibleContext`
        interface on the `XAccessible` object.
        (While in many cases, the class implementing
        both interfaces is the same, that doesn't have to be
        the case.)
        
        Change-Id: I281082672447c7bfd2812d7f3cd54c74414df66e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155193
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-02  Michael Weghorn  <m.weghorn@posteo.de>  [256926cace5819b0107e8d24579e05bcab9b5a7e]

        tdf#156473 a11y: Don't use selection index as child index
        
        `XAccessibleSelection::getSelectedAccessibleChild` takes
        the index into the selection, not the child index, as its
        documentation (in
        `offapi/com/sun/star/accessibility/XAccessibleSelection.idl`)
        says:
        
        > @param nSelectedChildIndex
        >     This index refers only to the selected children, not to all the
        >     children of this object.  Even if all children are selected, the
        >     indices enumerating the selected children need not be the same
        >     as those enumerating all children.  If only single selection is
        >     supported the only valid value is 0.
        
        The previous handling here in
        `AccessibleGridControlTable::getSelectedAccessibleChild`
        was treating it as the child index, though. Therefore
        trying to get the selected children would break once
        any row other than the first was selected.
        
        Fix this by calculating the actual row/column index
        of the cell from the given *selection* index.
        
        This could be observed e.g. with the qt6 VCL plugin by
        querying selection from Accerciser, with the last row
        selected in the table from the tdf#156473 macro in LO
        and the corresponding table object selected in
        Accerciser's tree view of the LO a11y hierarchy:
        
        Before:
        
            In [41]: sel = acc.querySelection()
            In [42]: sel.nSelectedChildren
            Out[42]: 5
            In [43]: sel.getSelectedChild(0)
            In [44]: sel.getSelectedChild(0) == None
            Out[44]: True
        
        With the fix in place:
        
            In [48]: sel = acc.querySelection()
            In [49]: sel.nSelectedChildren
            Out[49]: 5
            In [50]: sel.getSelectedChild(0)
            Out[50]: <Atspi.Accessible object at 0x7fcaeaddb900 (AtspiAccessible at 0x3ae4a80)>
            In [51]: sel.getSelectedChild(0).name
            Out[51]: 'C1 , R4 , '
            In [52]: sel.getSelectedChild(1).name
            Out[52]: 'C2 , R4 , '
            In [53]: sel.getSelectedChild(4).name
            Out[53]: 'Column 5 , R4 , '
        
        Change-Id: Id7d42a89b913d2ed101a9edb45dee5f3d870dbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155190
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-02  Balazs Varga  <balazs.varga.extern@allotropia.de>  [47ca3f1f762352b488d58b3bf23d5776576f1cca]

        tdf#156545 - a11y - fix warns about background character style formattings
        
        Do not add warn to a11y sidebar if we use charstyle for character background
        format.
        
        Change-Id: Ide558b590cae2bc20c71c5c44909cd2cdeb89985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155095
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [a454ee60efcb4eb3401d3c6b5196155375452993]

        Add translator comment to clarify meaning of the Fix button
        
        Change-Id: I9e792bb27523a2daf6afca00ad1c210e6b274573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155087
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-08-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac8fd70e4e23d12857f766a4918747bbc5a7cb9b]

        tdf#156283: take remaing dx value into consideration too
        
        Change-Id: I27c6f12edacd68c7f956b67dcf9ef0cc5045e3d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155169
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-01  Patrick Luby  <plubius@neooffice.org>  [73adf93acc9bbac4c8db9aa844930629a429410e]

        Revert "tdf#144072 prevent use of a deleted pointer"
        
        This reverts commit 01a1d2a84992973b8a0e5f1ae99fd32f5913b58f.
        
        That commit appeared to fix tdf#144072 but it only delays the crash as the reportdesign module will keep reusing the same SdHdl pointer that has already been deleted.
        
        Change-Id: I8e416b0376aa8724b697f54ed45f58341b47dc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155181
        Tested-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-01  Venetia Furtado  <venetiarosita@gmail.com>  [025f540dba1c5b046b4fdbd9418dcaaa900e006d]

        tdf#146619 Remove unused #includes from C/C++ files
        
        Change-Id: Ia8b406b6a59086160a5167480c6d3bde6574ffbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155029
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-08-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfb1e6354e095d0addf9f7a1114902b2bce5f627]

        tdf#156462: sc_uicalc: Add unittest
        
        Change-Id: Ib02bcb33c243450cdc94328e07d02510d50eb7c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155164
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-08-01  Khaled Hosny  <khaled@libreoffice.org>  [21f13b90295edf84f87125791e05810666058a1c]

        Fix reversed expected and actual unit test results
        
        Change-Id: Ie7eaec7ce9ad6f85b02edc831f1d138f45c18220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155152
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [27701d49327f8303ec1791f1b3fa4661b0480ac9]

        Fix typo
        
        Change-Id: Ib15fe6d0d9df549a9c7952494bfca78ec66b7f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155160
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-08-01  László Németh  <nemeth@numbertext.org>  [33058b5dc47a140516669945efbdd30ea65138a6]

        tdf#156544 sw tracked table column: delete empty column
        
        Empty table columns were removed without change tracking
        in Record Changes mode, too.
        
        Follow-up to commit fe43f5971dfd2a121634eea9e39c7ad0cf3f962a
        "tdf#156475 sw tracked table column: delete empty cell".
        
        Change-Id: I8154cb1c75cf793f5a60e8259a91dd779fc766e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155153
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-08-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f363777f1c518ed9633596e482d4a11eee17295d]

        cool#6911 report the position of comments as cell addresses
        
        and leave it to the client to determine the bounds of the cell
        
        Change-Id: I20a1bece5d0717c0e099b38610842d4800d6a074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-01  Patrick Luby  <plubius@neooffice.org>  [01a1d2a84992973b8a0e5f1ae99fd32f5913b58f]

        tdf#144072 prevent use of a deleted pointer
        
        BegDragObj_createInvisibleObjectAtPosition() may clear the handle
        list and that will delete the SdrHdl instances owned by this section
        view so set _pHdl to null if it has been deleted during the call.
        
        Change-Id: I89606958f8a76a2c35685d1aff6b0159739a464a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155119
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-08-01  Paris Oplopoios  <paris.oplopoios@collabora.com>  [0004de149269ed2ab5423947b9930653f3da6038]

        Allow getViewRenderState to get from a specific view
        
        getViewRenderState would get its output from the current view, make it
        so that it's possible to specify a specific view
        
        Change-Id: I279b215f8311b079c220c79b8b41c76bc0210154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154943
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit eff5643dbc5bb9dfede530e8e07261bb9bdc98f0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155046
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [f9631765c9dfd805ae486a94eacb69d307c9eef1]

        wina11y: Drop/Clean up CHILD event handling in subclasses
        
        Now that Change-Id I62ab32342ef67c770ced9f0d2be867dc9355bd4a
        ("tdf#156561 wina11y: Handle CHILD event") has implemented
        handling for the CHILD event in `AccEventListener`,
        drop the overrides in child classes that effectively
        do the same.
        
        For the case that a new child gets added,
        `AccFrameEventListener::HandleChildChangedEvent`
        also passes the HWND, so leave that and only
        forward to the base class for the other case.
        
        Change-Id: I68d836abedbf3563df84187d56851820c043866f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155127
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [1d92445fcac1c51c17d8dbfd1a4017430fe7bc46]

        tdf#156561 wina11y: Handle CHILD event
        
        So far, `AccessibleEventId::CHILD` events were ignored by
        `AccComponentEventListener` and its base class,
        `AccEventListener`.
        As a result, no event listener would be created when
        e.g. a child that was previously hidden got shown,
        resulting e.g. in NVDA not announcing that object
        when it receives focus later.
        
        Handle the event and register a listener when notified
        about a new child and drop the old child when one gets
        removed, like some of the derived classes already do
        in pretty much the same way.
        (Those implementations will be cleaned up/dropped
        in a separate commit.)
        
        This addresses one of the root causes of why
        tdf#140762 ("No text spoken by screen reader for 'Borders'
        dropdown button items in Calc's formatting toolbar (NVDA on Windows)")
        occured without
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        , i.e. when the window is made visible only after its
        parent.
        
        Still, this change at least by itself does not yet solve
        tdf#152671 ("ui, accessibility: auto filter drop down menu is not
        spoken by the screen reader") and also for the case of the
        toolbar popup, the initially focused item would no more
        be announced when reverting the above-mentioned commit and
        its follow-up commit
        
            commit 57c2209dd04abfda90e0aba782bc174243633ec9
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Thu Apr 6 15:07:15 2023 +0100
        
                tdf#154470 try moving the Show of the client to after the float positioning
        
        Example backtrace of the font color popup in the formatting
        toolbar where no event listener was created previously:
        
            1   AccEventListener::notifyEvent                                 AccEventListener.cxx          74   0x7ffe4b4ecf14
            2   AccComponentEventListener::notifyEvent                        AccComponentEventListener.cxx 82   0x7ffe4b4ee699
            3   comphelper::AccessibleEventNotifier::addEvent                 accessibleeventnotifier.cxx   256  0x7ffe5e80ebac
            4   comphelper::OCommonAccessibleComponent::NotifyAccessibleEvent accessiblecomponenthelper.cxx 127  0x7ffe5e80443e
            5   VCLXAccessibleToolBoxItem::NotifyChildEvent                   vclxaccessibletoolboxitem.cxx 213  0x7ffe4b337e10
            6   VCLXAccessibleToolBox::UpdateCustomPopupItemp_Impl            vclxaccessibletoolbox.cxx     373  0x7ffe4b33334d
            7   VCLXAccessibleToolBox::ProcessWindowEvent                     vclxaccessibletoolbox.cxx     547  0x7ffe4b33263c
            8   VCLXAccessibleComponent::WindowEventListener                  vclxaccessiblecomponent.cxx   112  0x7ffe51e871c5
            9   VCLXAccessibleComponent::LinkStubWindowEventListener          vclxaccessiblecomponent.cxx   98   0x7ffe51e861f6
            10  Link<VclWindowEvent &,void>::Call                             link.hxx                      111  0x7ffe504204b3
            11  vcl::Window::CallEventListeners                               event.cxx                     263  0x7ffe50420860
            12  svt::PopupWindowControllerImpl::WindowEventListener           popupwindowcontroller.cxx     148  0x7ffe53c65593
            13  svt::PopupWindowControllerImpl::LinkStubWindowEventListener   popupwindowcontroller.cxx     89   0x7ffe53c64f76
            14  Link<VclWindowEvent &,void>::Call                             link.hxx                      111  0x7ffe504204b3
            15  vcl::Window::CallEventListeners                               event.cxx                     263  0x7ffe50420860
            16  vcl::Window::ImplResetReallyVisible                           stacking.cxx                  723  0x7ffe5033d6f1
            17  vcl::Window::Show                                             window.cxx                    2234 0x7ffe5053eca7
            18  ImplDockingWindowWrapper::ImplPreparePopupMode                dockmgr.cxx                   769  0x7ffe5041154e
            19  ImplDockingWindowWrapper::StartPopupMode                      dockmgr.cxx                   816  0x7ffe50413d4c
            20  DockingManager::StartPopupMode                                dockmgr.cxx                   349  0x7ffe50413c11
            ... <More>
        
        Change-Id: I62ab32342ef67c770ced9f0d2be867dc9355bd4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155126
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [3bb762c53ea79f8915a1b8fa39f3f5f57aa68c84]

        tdf#156100 tdf#156561 Revert to previous behavior for gtk popups
        
        In order to fix announcement of items in the popups with at
        least NVDA on Windows,
        
            commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb
            Date:   Wed Mar 15 17:00:27 2023 +0100
        
                tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        made sure that the dock window is made visible before the
        popup is shown.
        
        That's problematic for the gtk implementations, though.
        
        On issue was addressed with
        
            commit 70642bb7afd2cee6f7ae6eff2936a35978bd0597
            Date:   Thu Apr 6 15:07:15 2023 +0100
        
                tdf#154470 try moving the Show of the client to after the float positioning
        
        , but there's still an issue for the RTL case (tdf#156100).
        
        To unbreak that while leaving the announcement with NVDA working
        properly, effectively revert to the original behavior for the
        gtk VCL plugins (which have their own implementation for popup
        handling) for now.
        
        Further analysis of the root causes is planned in the context of
        tdf#156561, so hopefully the code paths can be unified again in
        the future.
        (One issue is addressed by Change-Id I62ab32342ef67c770ced9f0d2be867dc9355bd4a,
        "tdf#156561 wina11y: Handle CHILD event", but that's not enough
        by itself.)
        
        Change-Id: Ie67bded6c380695866d5343dab9d3f563ada057a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155125
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-01  Mike Kaganski  <mike.kaganski@collabora.com>  [38feff6a04b2785b219fabe7172c857e97ef90ae]

        tdf#156548: make truncated long bookmark name unique, and use it in hyperlinks
        
        Change-Id: I156359339ff8be85fe90cb6612eafdc6030c851f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155092
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-08-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [eff5a3fe98ca5d1d28c4f5386c4af8a3be8f5703]

        gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed
        
        on loading sw//qa/extras/layout/data/tdf125334.odt and double clicking
        chart
        
        Change-Id: I65b10c0223e9c217d77dc7daa73580fadffc32c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155096
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-08-01  Miklos Vajna  <vmiklos@collabora.com>  [073072f0a3abacfe4f9cc920b8138d7abc84db70]

        tdf#156260 sw floattable: avoid overlapping flys on anchor change
        
        Going to the end of the document, typing "dt" and F3 collapses the
        multi-page floating table into a single page, with overlapping text.
        
        In practice we insert a new paragraph before the "dt" one, insert the
        dummy text there and then re-anchor the floating table from the old
        paragraph to the new one. Such re-anchoring isn't really meant to be
        done with floating tables, which are always just anchored in the next
        paragraph in practice. An additional problem is that the amount of fly
        frames created depends on the position of the first fly frame, so if the
        anchor changes, we may need a different number of split fly frames.
        
        Fix the problem by not trying to reuse the old fly frames on anchor
        change: delete the old frames, change the anchor and finally create the
        new frames, which leads to correct layout with complicated logic trying
        to update the old fly chain to the new anchor.
        
        The original document still puts some dummy text on page 4 instead of
        starting it on page 5, that part is still unfixed.
        
        Change-Id: I74549e2ea8ca0d06a9e4814a58aaa8ca476263dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155122
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [2ef9880f97de6629ddef12eb788123ab4be1ec83]

        tdf#156376 qt: Open help for focused native menu entry on F1
        
        In order to allow have pressing F1 (`QKeySequence::HelpContents`)
        open the corresponding help entry for the currently selected
        menu entry, connect to the signal that gets emitted when
        a menu entry is selected (`QAction::hovered`) and remember
        its help ID. Register the F1 shortcut for the menu
        and connect its `activated`/`activatedAmbiguously`
        signal with a slot that opens the help for the current/
        last selected menu entry.
        
        Change-Id: I24eec4806e5a202052a49c239e4836b92c9f0228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155055
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-08-01  Stephan Bergmann  <sbergman@redhat.com>  [85c07891ad9424661d8e1adb8e93364e3964ce34]

        Update to curl-8.2.1.tar.xz
        
        ...obtained from <https://curl.se/download/curl-8.2.1.tar.xz>
        
        Change-Id: I7260f79e2f72501869ff58c77f0d9dfa3ebdece1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155116
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-08-01  Miklos Vajna  <vmiklos@collabora.com>  [b54776293ad21363e8a1251bf71ff1ae74f61365]

        sw: document SwFormatINetFormat
        
        Especially how it relates to SwFormatURL, which is for images, not for
        Writer text.
        
        Change-Id: Idc00f3b9803d2fb603647b692de2c1a6ce068361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155115
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-01  Miklos Vajna  <vmiklos@collabora.com>  [d0cf5bb9bc267847f23f1bf1fde0df062a554059]

        CppunitTest_sw_layoutwriter2: fix up testTdf125334
        
        This started to fail for me after commit
        4b743de97fc133623e46827869c4ea3eb845ad47 (tdf#156234: Don’t round glyph
        coordinates when doing subpixel positioning, 2023-07-17), the test was
        added in commit 75ef0e41ea8a9096ac619356d2b837c5333b47e6 (tdf#125334
        Chart: allow text break in bar chart axis labels, 2019-05-17). Manually
        opening the test document indeed shows chart axis labels that are not
        wrapped to multiple lines, while they were in the past.
        
        Tweak the test to accept the new state just to unblock make check, but
        add a FIXME because in the long run this should probably needs some more
        investigation either on the chart2 or on the vcl side.
        
        Interestingly the test still passes on Jenkins (but not locally) and it
        seems the available / missing system fonts don't influence the result,
        because CppunitTest_sw_layoutwriter2 has
        gb_CppunitTest_set_non_application_font_use set to "abort" already.
        
        Change-Id: I2bf105d04f2fe69aac386a13103681536a19d02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155090
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [144d16443a74839f885dc9597bee1e48493b278f]

        fix C/P typo that allowed setting LumMod color transform value 0
        
        should be m_nLumOff instead of m_nLumMod
        
        Change-Id: I14b04fb0fecad949a41abf752d2ac05ceed5ba83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155112
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [614dfb98cd4705b63bf1e525d3d34df9ce950ebb]

        set finalColor of the ComplexColor in BorderLine and BrushItem
        
        The final color is stored inside the ComplexColor and is used to
        represent the final computed color from theme color and/or
        transforms.
        
        Change-Id: I405615bba144bfe876b75c565746d9eebc88e973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155111
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fc996d8d195263f09d8aaf65deaf9d42f7413be8]

        sc: remove code duplication at OOXML export of ComplexColor
        
        This removes the code duplication when exporting the ComplexColor
        to OOXML. Now we use a common oox::xls::writeComplexColor function
        which writes a ComplexColor to the stream.
        
        Change-Id: I4e7bb1f8427409d09550c71894c327dba5096bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155110
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f265875ef784d717f5a534bdca2cd36fdce7ecb]

        sc: rename oox::xls::Color to oox::xls::XlsColor
        
        It's annoying that the class name is so similar to the commonly
        used class Color, even when it is in its own namespace. To avoid
        unneccesary conflicts and confusion, it was renamed.
        
        (Similar would be also good for oox::drawingml::Color)
        
        Change-Id: I68dcaf951b7faf089cb2b13d94576007f40c441e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155109
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5e34a25aa7f58b37a2303aef9318bbe5a9af5d37]

        sc: Add import/export ODF support for border complex colors
        
        ODF Import and export support for border {left,right,top,bottom}
        complex colors. In addition round-trip test was extended with the
        border use case.
        
        Change-Id: I1d14690272c06e8ffcfcd483eb7f688ca5bb1e5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155014
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b543463f639ecee793484e8b419147d565a53d52]

        xmloff: fix import of CharComplexColor - add StylePropertiesContext
        
        Import of CharComplexColor in Calc didn't work because the class
        XMLComplexColorContext wasn't used.
        
        This introduces a new class StylePropertiesContext, because the
        plain SvXMLPropertySetContext is not enough as we can't define to
        use XMLComplexColorContext when XML_CHAR_COMPLEX_COLOR is used on
        that class.
        
        Also adds a import/export test for CharComplexColor.
        
        Change-Id: I765ac71a801a5e9bcb105aaea73637df5e601b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155008
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-08-01  Justin Luth  <jluth@mail.com>  [d16d86685afdf3d321cc282a39a65f38381b6eaa]

        tdf#57414 autorecovery: if no recovery doc, remove from RecoveryList
        
        The document has just been saved
        (perhaps manually, perhaps automatically)
        and so the recovery ODF files are being removed.
        
        So remove from RecoveryList since there is nothing
        recoverable at this point.
        
        Sure the document is open, and perhaps
        there is even a modification already,
        but if there are no recovery files available,
        then why display it to the user?
        
        Change-Id: I309cd7df573c960f75c2240c8b5cf171fc1d95be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155059
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-08-01  Eike Rathke  <erack@redhat.com>  [2a9e83a673300dfe15a3acc66acd560b2a7cae43]

        Correct Esperanto {eo} group separator formats wrong since initial 2005 commit
        
        Instead of # ##0,00 and similar it used # #0,00 that probably went
        unnoticed since ever because it generates an expected display
        string using the group separator at the right position; editing
        such format yielded the format code ##0,00 with the group
        separator flag set.
        
        Change-Id: Id6ebb533f43a49a9aea1dd9ba87230e5d59901ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155114
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-07-31  Stephan Bergmann  <sbergman@redhat.com>  [5d80385fd167e5e88bb0ce959c78568d7d817842]

        loplugin:stringconstant: Catch some O[U]String::getStr anti-patterns
        
        Change-Id: I36bc86fcffc3c10fe44e60d779c9aa48eeed00f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154749
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f0b8ad888aff453e1a765611dceb6bc1cf970780]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cf513784b53bc12d95e39c326555831135a46f42
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(6)
            
            + refactoring
            + Writer Format menu (part 6)
            
            Change-Id: I2f279db33798ed9ce7daae2533f3efddf28e14b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155052
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f58823739382ef080a3d569baffec552b36f465a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 865f97e76885c4f15494dc42fb29265a48a3e654
          - More fix in product name
            
            Change-Id: I1de6ee379dc116b40794c81e8d6e505d51e7e5f8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155047
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [316215486b2fb255f4deea073e4d43671c4325c1]

        use more tools::Rectangle::Adjust*
        
        Change-Id: I6fb9e838f493149c52936932ef3b977db034ec1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a440949c6653f7f1f81cb8aff4dabd326ed96a8]

        loplugin:constantparam
        
        Change-Id: Iac66822757814d67383f6e19f3ab25e3dc7f8b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-31  Miklos Vajna  <vmiklos@collabora.com>  [2b401b7c0322d9ff972d252208ebe9a77913778d]

        tdf#156350 sw floattable: fix bad additional <draw:frame> in ODT with layout
        
        The document has a floating table, split on two pages. Saving as ODT
        creates two <draw:frame> elements, while we only expect one.
        
        The document model is correct, SwDoc::mpSpzFrameFormatTable only
        contains one frame, and in general the ODT export works with the SwDoc,
        but CollectFrameAtNode() uses the layout to help performance, and the
        layout is available when saving interactively (i.e. not --convert-to),
        which visits both layout frames of the same frame format.
        
        Fix the problem by ignoring follow fly frames in
        lcl_CollectFrameAtNodeWithLayout(), just working from master should
        ensure there is no duplication.
        
        This is similar to 4721729fba32a02683ecc930b630491599f8c6c5
        (SwXParaFrameEnumeration: ignore textboxes, 2014-05-27), but that was
        for fly frames of draw shapes, and this is for split flys.
        
        Change-Id: I09729c0b0f9afd694e3cbf8886ccbc530bfc9674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155081
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-31  Stephan Bergmann  <sbergman@redhat.com>  [fe1d6bf5751005054520b1fea95d0b9d40e910eb]

        Fix C++20-only "..."_tstr test code
        
        ...added by 6fce450b8a66d7e98a4d39528f8591184277e9fa "Introduce "..."_tstr as a
        companion to "..."_ostr/u"..."_ustr in template code"
        
        Change-Id: I779cf8e586b2a57aadfe9e57a546ee613bb505e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155093
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Stephan Bergmann  <sbergman@redhat.com>  [2a68dc02bd19a717d3c86873206fabed1098f228]

        Adapt test code to cURL 8.2.0
        
        ...for which CppunitTest_ucb_webdav_core would fail with
        
        > ucb/qa/cppunit/webdav/webdav_local_neon.cxx:60:(anonymous namespace)::webdav_local_test::WebdavUriTest
        > equality assertion failed
        > - Expected: ?query#fragment
        > - Actual  : /?query#fragment
        
        and
        
        > ucb/qa/cppunit/webdav/webdav_local_neon.cxx:89:(anonymous namespace)::webdav_local_test::WebdavUriTest2
        > equality assertion failed
        > - Expected: ?query
        > - Actual  : /?query
        
        because of
        <https://github.com/bch/curl/commit/5752e71080cb3aafa8b24c3261419345b832bc92>
        "urlapi: have *set(PATH) prepend a slash if one is missing".
        
        All that test code had been added with b03e070420606d407df2ec5e9dfa7043ecc46177
        "ucb: webdav-curl: fix CurlUri::CloneWithRelativeRefPathAbsolute()", and it
        looks harmless for our use cases that cURL started to behave differently there
        now.  So instead of accepting either of the outcomes depending on what cURL
        version is being used, just change the test code to not leave out the
        path-absolute in the calls to CloneWithRelativeRefPathAbsolute (which is
        documented in ucb/source/ucp/webdav-curl/CurlUri.hxx to take
        
        >     /// @param matches: relative-ref = path-absolute [ "?" query ] [ "#" fragment ]
        
        and path-absolute cannot be empty as per RFC 3986 "Uniform Resource Identifier
        (URI): Generic Syntax").
        
        Change-Id: If07a28598dfa047ebe89d8bcda19e8fcaa36aed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155099
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Miklos Vajna  <vmiklos@collabora.com>  [bf570139782418b0276ffd81669c8e1cdd3acbd5]

        svx: prefix members of E3dVolumeMarker, ImpEdgeHdl, NameOrIndex and ...
        
        ... SdrObjUserData
        
        See tdf#94879 for motivation.
        
        Change-Id: I4d330b0f8e08a3bdfc2c256c2ee86ac584947fc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155080
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-31  Patrick Luby  <plubius@neooffice.org>  [ccc31ed4d96bada134d08046f22f64c095a29041]

        tdf#156470 add SAL_INFO calls for debugging
        
        In the verious LibreOffice samples attached to tdf#156470, it appears
        that LibreOffice spends a lot of time the GetTextArray() calls in
        SvxFont::QuickGetTextSize(). So add logging to determine if any of
        the GetTextArray() calls are returning unusual sizes.
        
        Change-Id: Ie6f0fcc85396b47342b6a93180d4bc9873420931
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155072
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [e675d9673f138286e3c4654c522e3930ec96b4bd]

        tdf#156230 one more unused piece
        
        Change-Id: I903c55b1f4718c99269460a940be86cad95d11ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7822db0cfe5da126cf8980804d0959c3f4409c16]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9a42d2d1dc252113f48cd074d7e129adde37b859
          - Fix mistake in product name
            
            Change-Id: I33022758a73117e6b12ad882963f008005ce334a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155045
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [488e83ad90ee33f78b9d0012eeb036cb57326854]

        new baseline uses gcc-toolset-12 (and sets that globally)
        
        source /opt/rh/gcc-toolset-12/enable is part of the shell startup
        
        Change-Id: Idf20d911c920c3a6c5837cc12da5654db3f0bffa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155086
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-07-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e7c4166f1e150b10bc2ac52e93f8ad7503db09dc]

        silence use-after-free warning in mdds for gcc12 in optimized build
        
        Change-Id: I15385718dd705128e9e02541f33e46069dec5251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154890
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [dbe0ad486c60bde96b7f8019f31d855e3eae545b]

        tdf#156161: Honor "DontEnableJava" when failed because selected JRE uninstalled
        
        Change-Id: Id90f530fda9e565a5a53853a3acb8195035a80ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155078
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6f0238a2b076afb5438b61553dc92c6f68d67faa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 886cebba80267127e47de6f5dad57745cfe54752
          - tdf#144859 - fix switch javascript logic.
            
            Change-Id: I7add8db42f1944052ea5907e24b889cb9e504d3f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/155097
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-31  Michael Weghorn  <m.weghorn@posteo.de>  [b0a26a3c4ffb9994f19e4565c13a7f0ed5959cc6]

        qt: Drop unused QtMenu::adjustButtonSizes declaration
        
        It was only declared and never defined ever since it
        was added in
        
            commit 9ea767cb568cef1b142190d2adb0e301baa382e2
            Date:   Thu May 26 13:48:38 2022 +0200
        
                tdf#132350 Qt implement SalMenu button interface
        
        Change-Id: Ic097dae56a886e70438c25950e4cbaa0d954e85d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155056
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-31  Sakura286  <sakura286@outlook.com>  [2c258079113eae993fdaff113ba082455c920f89]

        fix 32 bit int simple return of riscv64 bridge
        
        Sometimes we need to return a 32 bit integer into a 64 bit integer.
        For example, in pyuno.cxx:PyUNO_bool(), an int(32bit) is returned in
        type Py_ssize_t(64bit). We assume that this 32bit int was put in low
        32 bit of register a0. The bridge may return with high 32 bit
        uncleaned and compiler might directly bind this register to 64 bit
        variable in error.
        
        This bug produces when build pyuno with gcc-12 with -O2.
        https://bugs.documentfoundation.org/show_bug.cgi?id=155937
        https://lists.debian.org/debian-riscv/2023/07/msg00011.html
        
        So we need to clean the high 32 bit in bridge.
        
        Change-Id: I37aafb03ba9523cfb90912871308921fbeaf5f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154837
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Khaled Hosny  <khaled@libreoffice.org>  [5526c523bc9fda890e15eacd45f280b0827f8ea0]

        Fix surrogate pairs handling when tweaking script info
        
        Followup to:
        
        commit 3af30bafbedb8eb481024efb35cb7876c63d26dc
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Jul 27 19:03:28 2023 +0300
        
            sw: Handle surrogate pairs when tweaking script info
        
        and:
        
        commit d6efe8c302b81886706e18640148c51cf7883bbf
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Jul 27 20:39:22 2023 +0300
        
            tdf#112594: Group NNBSP with the Mongolian characters after it
        
        Change-Id: Ie273c457e4f3ed31a3372bc8eb0eb0055c1b97b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [74963f654768d6f25ac1ea907736731d9a886853]

        all drawPolyPolygon variants return true now
        
        since:
        
        commit 4998de76ed1da4039e30718941d50d6f1dfe4f82
        Date:   Sun Jul 30 07:40:48 2023 +0000
        
            tdf#156230: Drop freshly unused GenPspGfxBackend
        
        Change-Id: I7fc2a068f807777ed392c5d58772d130bf7f51c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155076
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-31  wujiahuan  <wujiahuan@loongson.cn>  [ff55268583324c7c62c6c0988384a9f0f2d18d8b]

        fix CustomTarget_uno_test check failed with enable java on loongarch64
        
        Change-Id: Iadb1f16eb10761cdef392110986bddda44ddee3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154833
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [acbdda150534927852cd475f94c3fcb1f9db53da]

        supportsOperation OutDevSupportType::B2DDraw is always true now
        
        since:
        
        commit 4998de76ed1da4039e30718941d50d6f1dfe4f82
        Date:   Sun Jul 30 07:40:48 2023 +0000
        
            tdf#156230: Drop freshly unused GenPspGfxBackend
        
        Change-Id: I1adc30a60aec0c5aab9289e9c0505d1dbad10631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-31  Stephan Bergmann  <sbergman@redhat.com>  [6fce450b8a66d7e98a4d39528f8591184277e9fa]

        Introduce "..."_tstr as a companion to "..."_ostr/u"..."_ustr in template code
        
        ...like
        
        >         *path = "/";
        
        in
        
        > template<typename T> oslFileError getSystemPathFromFileUrl(
        >     OUString const & url, T * path, bool resolveHome)
        
        in sal/osl/unx/file_url.cxx, where T is either OString or OUString.  That can
        now be replaced with
        
        >         *path = "/"_tstr;
        
        and for OString it will be a no-cost constexpr operation, while for OUString it
        will still construct the OUString instance at runtime (as did the original code
        for both OString and OUString).
        
        (This change required moving the definition of rtl::detail::OStringHolder
        around in include/rtl/string.hxx.  For consistency, I similarly moved around the
        definition of rtl::detail::OUStringHolder in include/rtl/ustring.hxx, too.)
        
        Change-Id: I7fb3a81b438f98c609684f7e70b7a60068d32fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154748
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [3564e11a41c8d3f06c8be387691d5997942e9738]

        tdf#156230 remove now unused various bit and pieces
        
        Change-Id: I0ad88d402329bbc6882f53f6c20c22b97189a27f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155077
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [d7b8dc9f3f866d65c2e1ae3727b3738ae954e325]

        Log SSL default verification path for mailmerge debug
        
        related: follow python recommendation and pass SSL contexts
        
        Change-Id: I992535a7fbe0bd21ff1de8241715babc0cb5cdc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155050
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [3e563f6ed42224e5c7fbb11428604a7719e178af]

        Drop freshly unused PrintFontManager
        
        Change-Id: If4cec80eaf1301907d144ecb8518a4de5acdeefb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155070
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [3a01df55db376ecbed0d89ebb4dd9d2d2f4b520f]

        Drop freshly unused font subsetting code
        
        These output font formats were for PostScript that is now gone.
        
        Change-Id: Ib29f921fe25432aaa558ba842ee77fe1e8023d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155069
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Tested-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [984e2e78340c4818538f653e07f19acfc29646c5]

        tdf#156230: Drop freshly unused PSLevel setting
        
        Change-Id: I9331b5532f8066f7d13815487c7af0e7fd37e54f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155068
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [c106e5d95918f569bc2e45bec3792ddad6db99e4]

        tdf#156230: Drop freshly unused PrinterJob and PrinterGfx
        
        Change-Id: I5149fb447e76044e7f4bfdd9a79ee3b454859375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155065
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [4998de76ed1da4039e30718941d50d6f1dfe4f82]

        tdf#156230: Drop freshly unused GenPspGfxBackend
        
        Change-Id: Idfc4364b99ed605462aae58391e98960be6021b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155064
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [e7249131dcfb62cbb68ab1797b9591c90ba2e9e1]

        tdf#156230: Use SvpGraphicsBackend in GenPspGraphics
        
        We no longer draw to PostScript, so old backend is unneeded.
        
        Change-Id: I069ce735b303721be7de6abf69aa26c1b25a9107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155063
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [45c3bf8bf38fa9b4b8fb5562178956bdfeef147f]

        tdf#156230: Use CairoTextRender in GenPspGraphics
        
        We no longer draw to PostScript, so old layout implementation is
        unneeded.
        
        Change-Id: Ifd007f8dd7794e348abb863c1c36d5c79ac7e0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155062
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [4a0c8c722289f9a94e87cbc90eca17e1b865be64]

        tdf#156230: Drop freshly dead PspSalPrinter code
        
        Change-Id: I272c8f3a4d70ef9d5d03eecc8c91ee8423c52ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154976
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [55a0a70e8fd5a76b8d3f49ceed902613025ad6b3]

        tdf#156230: Drop PDFDevice handling
        
        Change-Id: I53759eb6025a4fc7e1319d0d1e7b3072edde93c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154975
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [3d8b7fd32b63370919b6d215be0af6fba6eb4ca4]

        tdf#156230: Deprecate and stop using PDFAsStandardPrintJobFormat
        
        PDF is the only supported printing format (on Unix) going forward.
        
        Change-Id: I1bd442bac370b89a77e2035d4c17bfc43a869ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154974
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Mike Kaganski  <mike.kaganski@collabora.com>  [e80e2a8dbed8a6cea71eca333564a9fa75b5cfbc]

        tdf#156528: Fix handling PDF page scaling factor after large pages
        
        The map mode wasn't set when current page's user unit was 1, which meant
        that it used the unchanged value from the previous page, where it could
        be different.
        
        Change-Id: Id1f1515dceac25cddc12081a86fabf8b32d633f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155025
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-30  Jean-Pierre Ledure  <jp@ledure.be>  [bd640d338b6c8a1a4915c4b88b52ac1cc48f7dd0]

        ScriptForge (SF_Session) fix SendMail() w/o attachment
        
        Fix error message when no attachment
        passed to the method.
        
        Execution continues now without trouble.
        
        Change-Id: I447af45db97f086963027c131c6b5fb9dab93c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155066
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-30  Patrick Luby  <plubius@neooffice.org>  [f324cba8600f9aa2c13e8531e1ce5467442b097b]

        tdf#156506 Fix failure to draw copy border on Windows
        
        Revert portion of commit 9d68c794d67259a38de1465090f6f1e7fb588d62
        that stops the animated border when a copy action is performed in
        a different document by cancelling the animated border.
        
        While the change worked on macOS and Linux, on Windows it stops
        the currently active copy border so revert this fix.
        
        Change-Id: I0dbdc8b1bf3077eecadbbe591a27e60ef3d48b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155067
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-30  Aron Budea  <aron.budea@collabora.com>  [c93267f2901805aa6fe7b7ea44d4ba24e47233da]

        Send Calc pivot table command state changes to LOK
        
        Change-Id: I0d9e04b0a0452f66cb9703d9f34fe6cb44d724c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154506
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit b62f9f484a0fc9215e34153daac4a8bdb9698d4b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155034
        Tested-by: Jenkins

2023-07-30  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [4d7a98b582dc70bbffc78e6622969e218f108433]

        Related tdf#58434 - Treat ZWSP and WJ as hard space
        
        U+200B ZERO WIDTH SPACE and U+2060 WORD JOINER are not highlighted
        anymore if Formatting Aids > Non-breaking spaces is off
        
        Change-Id: Id35fb725bbfa14683ceb31d2043848a66328b364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155019
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-30  Khaled Hosny  <khaled@libreoffice.org>  [d4653fa961b1aa1cd4bf568e7d1fe50ae97df484]

        tdf#107612: Include NNBSP and Mongolian characters in the same fallback run
        
        When a Mongolian character is preceded by a Narrow No Break Space
        (NNBSP), it is used to trigger special letter forms, but when we do font
        fallback NNBSP is always taken from the main font (HarfBuzz synthesises
        it when missing from the font, so we almost never use font fallback for
        it).
        
        We now check if the start of the fallback run is a Mongolian character
        and the previous is NNBSP and extend the fallback run to include it.
        
        Change-Id: I7607dba37ee51ff62bc9e86c3dbc555cd77e8d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155060
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [49fc6598426fb4552904c66702cddc6534124227]

        Fix typo
        
        Change-Id: I7ac33586a01a65e20143ec1e853c6720de453d35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155054
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [5e3510dbb62229cfb01da371d39ecc27b0d44880]

        tdf#116412: include bz2 in internal python
        
        Change-Id: Ie257446692227ae689fad2e61a42405a68e4f665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139580
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-30  Justin Luth  <jluth@mail.com>  [0e17d8ddccdee7d4f46b256153853e1cab87c99e]

        partial Revert "tdf#152463 Turn on AutoSave by default"
        
        This reverts 7.6 commit 5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22,
        because this setting is not used in 24.2, and was reverted
        for 7.6 as well. So no point in changing a deprecated setting.
        
        In 24.2, the officecfg was corrected to point to the traditional
        Recovery::AutoSave::TimeIntervall (which as broken in 7.3,
        but had always been a bit of a mess.)
        
        This original setting already has AutoSave enabled by default,
        so this patch is NOT turning off AutoSave for 24.2.
        
        Change-Id: I392d5a1511792ec0a42add11a37de8f7e0181631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155057
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [69202a4443411b45cdd95cc91d63a27d58a855bd]

        Simplify WrapReqifFromTempFile usage
        
        This function was only ever used together with creation of a memory
        stream, and parsing the result. So put it all inside.
        
        Change-Id: I4d77b9b0519539f774b73936c3f2eacaab481cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155018
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9807d927a00e538af1561889fd897154ad9f3349]

        Fix typo
        
        Change-Id: I2402ff95f4b9e66bf9ee7321a3e5db55cd10787f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155051
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-29  Jean-Pierre Ledure  <jp@ledure.be>  [0f43960ec87229f15f9138d83072bb1f510fa9b2]

        ScriptForge (SF_Platform) new UserData property
        
        The UserData property lists the content of the
        "User Data" oage of the Options dialog.
        
        The content is returned:
        - in Basic: in a SF_Dictionary instance
        - in Python: in a dict[] instance.
        
        The list of the available keys is:
         city, company, country, email, encryptionkey,
         encrypttoself, fax, firstname, homephone,
         initials, lastname, officephone, position,
         postalcode, signingkey, state, street, title
        Many are different from the UNO/priginal values
        to make them more user understandable.
        
        This commit will require an update of the SF_Platform
        help page.
        
        Both Basic and Python user scripts are supported.
        
        Change-Id: If645579ee9109a1b8180da5a5f3a71979bb5ca59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155024
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-29  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [163fe25cb86435109aef7ce6dd1c37e5cf5cfbfa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6417a881f92e9e18d2c73ab2595ce0f23c2dc84c
          - use consistent wording for Label field descriptions
            
            Change-Id: I3dfc14b68236fa5b187de2b7b42b834131cd62f3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154956
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-29  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [6f98aab121ff782f24db997a4c9e2ae95d80104b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67cc71d2ab80826082b292f61593031474499839
          - correct description of Outline Folding option
            
            Change-Id: I8d96f7eac229f29911a73fa363dedc4a8d44b4e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154966
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-29  Baole Fang  <baole.fang@gmail.com>  [e26aeb882dd236adf19679d5df9b7ba5da1ed226]

        tdf#156165: Fix replace custom styles while typing
        
        Originally, Replace Custom Styles changes styles to text body by entering BuiltText. Since styles change to text body is removed from BuiltTest, it is converted independently.
        
        Now, conversion is applied even during typing because m_aFlags.bChgUserColl is true (its default value) during typing. Therefore, its default value is changed to false.
        
        Change-Id: I8ce067b311922b5e1bdcd84036229c369b50a977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154144
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-29  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e3d28846c2343072750197fcdeaf44a945ddcb61]

        follow python recommendation and pass SSL contexts
        
        i.e. https://docs.python.org/3/library/ssl.html#security-considerations
        
        Change-Id: I67a0f9e1c25abc6644412b014f30933a7e681da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155016
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [2f9c1990a85b0e867400f5952095704e178680ad]

        ReqIF: allow to output a single selected OLE object
        
        To do that, "SelectionOnly" boolean propertyvalue is supported in the
        store arguments.
        
        Change-Id: I265e802256a9a678779bbd021dde9b0c87ca08b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155012
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-28  Michael Stahl  <michael.stahl@allotropia.de>  [0f39ecfed57f3f32d4f5cadf50b7dd9de77f8d7e]

        tdf#149555 sw: convert RANGE_IS_SECTION SwXTextRange if possible
        
        The writerfilter import got an exception in
        SectionPropertyMap::CloseSectionGroup() because XTextRangeToSwPaM()
        can't handle RANGE_IS_SECTION SwXTextRange.
        
        (regression from commit 7ab349296dac79dad3fec09f60348efcbb9ea17e)
        
        Change-Id: I38b37fdec64f4699c0fa1a090c72a8676ff386a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155026
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2f2cd7558e1d01f9670436412d62d03f28bab2c1]

        tdf#142600 - External links dialog: list database ranges
        
        Regression from commit 462f9d1f589a7afd66d3fc61925467d3b68e5b31 where
        the database ranges were dropped.
        
        Change-Id: Ic0e453fc6fe62849d72b6acf88ed7ebd3c47775b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155009
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf704afbb7c9ff843d66fec2eddbb00c43a9ab42]

        Fix typo
        
        Change-Id: I1973ac5efd12b2071a92a97d8d669f1e46b9c594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155020
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e326acc1ec13b90672e86811013850f26f4d96b6]

        Fix typo
        
        Change-Id: Icb1c8ceaad806a53dbad4feb8ab1ab31c8d23242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155021
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [514dfe603797351223b1c570a92687399cca7e06]

        Fix typo
        
        Change-Id: I56877d764075bc267708e380a5972fe08798e8e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155022
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [92bc3c8c1968d177d7db365b7062e4750d451ff6]

        Fix typo
        
        Change-Id: Ia8d0859088614c29ae358fed46d0c750d5a54e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155023
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-28  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [1fb3584d61441d864c14ff3376d2fa485edf400b]

        Resolves tdf#156504 - Strings in media player made translatable
        
        Change-Id: I2798d0becf7075bd0f484b4e96b44fa29c551415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155013
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-28  Michael Stahl  <michael.stahl@allotropia.de>  [2bf98b495cf187c80ab105f30b51da8f65561e35]

        sw: layout: invalidate row after fixed-height row too
        
        In SwLayoutFrame::GrowFrame(), invalidate the position of not only the
        next frame, but continue to invalidate until there is a frame with a
        non-fixed height.
        
        The idea with invalidating only the next frame is that the next frame
        will then be formatted and this will then invalidate the position of the
        frame after that.
        
        But with a table row with fixed height, this doesn't work:
        SwLayoutFrame::GrowFrame() returns without doing anything, not invalidating
        next frame; the next-next row is never repositioned and overlaps the
        next row.
        
        (this reproduces as a user-visible problem only when using the API to
         export to PDF, and only in a 6.3-based downstream branch, because
         in SwXTextDocument::getRendererCount() view settings are applied and
         this will differ on the IsParagraph() setting and in master this causes
         all pages to be invalidated and another run of the layout fixes the
         problem; also on the downstream branch backports of commit
         383032c50a3e3354f04200ce984a47ab9d2c5c67 "tdf#123583 use TaskStopwatch
         for Writer Idle loop" and commit
         c605283ad6785dea762feab5fdffd9d27e75c292 "sw: fix spurious layout
         invalidation from ~SwCallLink()" are required to reproduce.)
        
        Change-Id: Ic8a0aa23c496eeab2f3fd87bff7212c8d8ca1cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155017
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5f00f2365cdc62e6b0db4aa9e8f54d9ed859ce0a]

        make the themeeditdialog and themedialog ui modal
        
        doesn't affect that they are run async
        
        Change-Id: I7336e64258f5042ee80acb7295b1ed7370be54b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [01f4c0a25e4749875e27c63bfb824df6c4687535]

        crashtesting: std::bad_alloc on load of forum-mso-en4-123509.xlsx
        
        this appeared in crashtesting with:
        
        commit d15c4caabaa21e0efe3a08ffbe145390e802bab9
        Date:   Tue Sep 20 08:14:41 2022 -0400
        
            tdf#123026 xlsx import: recalc optimal row height on import
        
        rut existed as a caught exception during load before that.
        
        Change-Id: I90405a7acb84c95bac350808b20482e5069e2fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154990
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-28  Venetia Furtado  <venetiarosita@gmail.com>  [c37e50f5f2be3acff1ed32f1a1bf18d0ed7d6bdf]

        tdf#146619 Remove unused #includes from C/C++ files
        
        Change-Id: I5746cf045fc7d3191781c2c31631db39ee81bb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155002
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-07-28  Jaume Pujantell  <jaume.pujantell@collabora.com>  [a52ba26e6a3567a1f63aeb8d20c084eb286974b4]

        Added possibility to set password on save through arguments
        
        Change-Id: I579ed7487f87515a21d83912d9c0d12e9edc5eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154415
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-28  Balazs Varga  <balazs.varga.extern@allotropia.de>  [630303ad8e94bd634b98e691935a1f4c19582a3a]

        tdf#104382 - Menus should be disabled when they have no enabled submenus
        
        Disable menu elements if they only have disabled submenu elemets.
        TODO: GTK3
        
        Change-Id: I83cdc58846afd61719ceeba9f993df894ce6fd01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154938
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-28  Pierre  <prrvchr@gmail.com>  [9c071c148afce0b95a16b36c27b709380d1130b5]

        tdf#156471: New database wizard - add generic support for embedded databases of unknown type
        
        e.g. provided by extension or future code.
        
        The core assumption is that an embedded database doesn't need a user-configured "connection URL"
        configured so don't ask for one.
        
        Change-Id: I7d11cc0b492782634dd49f74d9d709dca434e990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154989
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [f5dd4faef6c6ee23bb33a0662087e1892db78b3d]

        SfxMedium::GetItemSet never returns nullptr
        
        Change-Id: Ibfc98a49022aa09ebf5315e5d3328308c1e51d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154997
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-28  sahil  <gautamsahil1947@gmail.com>  [0c45d90cfb1cc60218fbce3743df442b1f1d3f70]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I7217c04aa13082c1d2006c0c6a145b1b4fdbac0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155003
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-07-27  Khaled Hosny  <khaled@libreoffice.org>  [d6efe8c302b81886706e18640148c51cf7883bbf]

        tdf#112594: Group NNBSP with the Mongolian characters after it
        
        Narrow No Break Space has special uses in Mongolian, so we want to make
        sure it is in the same portion as the Mongolian text, even when it comes
        after text from another script group.
        
        We limit this to Mongolian to minimize potential side effects.
        
        Change-Id: Idb4c64cec8581e56acfe9bbb8adf4ddc213aaf19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155000
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-27  Khaled Hosny  <khaled@libreoffice.org>  [3af30bafbedb8eb481024efb35cb7876c63d26dc]

        sw: Handle surrogate pairs when tweaking script info
        
        Change-Id: I18e8358657303571d5d90e5162dbb68cbe067980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154995
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-27  László Németh  <nemeth@numbertext.org>  [fe43f5971dfd2a121634eea9e39c7ad0cf3f962a]

        tdf#156475 sw tracked table column: delete empty cell
        
        Tracking changes, only non-empty cells of the deleted
        columns got coloring, and were hidden in Hide Changes
        mode.
        
        Add dummy text content to empty cells of the deleted
        columns to get visible deletion in Show Changes mode,
        also working context menu in that cell; to allow hiding
        them in Hide Changes mode, also to store the time stamp
        of the deletion, if all the other rows are removed during
        editing.
        
        Follow-up to commit 472abf99a4d90d7a53316394a2e51a26b7e62345
        "tdf#155341 sw tracked table column: add insertion".
        
        Change-Id: Ieb5d237b3c82c81fded25608ef3d2906d7474003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154994
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [724ba1e455d4ae47a00248586487443347f1be96]

        tdf#156459: fix WM_UNICHAR implementation
        
        It was implemented in commit c62f48790047014d7d718f949ef6298961100e6f
        (INTEGRATION: CWS vcl07 (1.89.2.5.20); FILE MERGED, 2003-04-11), but
        handling of non-BMP codepoints was done incorrectly: high surrogate
        was calculated, but not used; and SALEVENT_KEYINPUT / SALEVENT_KEYUP
        pair used a default value of the SalKeyEvent's mnCharCode. Then the
        unused variable, and the macro taking its value, were commented out
        in commit fd3e69a1c0d311515eb8db92dd1a72657b405a25 (INTEGRATION: CWS
        warnings01 (1.125.6); FILE MERGED, 2006-06-19).
        
        I have no idea if WM_UNICHAR is used in the wild, but *some* sources
        suggest that some third-party IMEs could use it [1]; so just fix it.
        
        [1] http://archives.miloush.net/michkap/archive/2012/05/21/10308135.html
        
        Change-Id: I58190afd9fe295e62cb08acaefd32e99c1f383bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154996
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-27  Noel Grandin  <noelgrandin@gmail.com>  [7dc176bd29bc9952f869bad636a0ea7c9687ca97]

        pack the MapMode::ImplMapMode struct
        
        and move the hot fields to the front, since we hit this data
        fairly hard
        
        Change-Id: I852bd64557d586bc73ea64cdce9f5004e64dea93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-27  Colomban Wendling  <cwendling@hypra.fr>  [3426dcfec2b4d5c755024c355f323ecc9f656e4a]

        vcl gtk3: Introduce AT-SPI2 tests for the GTK3 accessibility layer
        
        Add tests for the GTK3 accessibility platform layer.  These tests
        compare the internal LO representation with what is visible to the
        platform, and thus the user's accessibility tools.
        
        In most cases the tests are fairly trivial as LO's internals are not
        far off AT-SPI2's expectations.  There are however notable exceptions
        like for example the text attributes, that have a wildly different
        representation and require more complex checks matching what LO's
        platform layer does, the other way around.
        
        These tests use libatspi2 directly, but as the C API is awful to work
        with regarding resource management, there are wrappers to handle the
        complexity using RAII.  The resulting API is fairly trivial to use.
        
        As these tests require using the GTK3 VCL plugin and for the a11y tree
        to be visible to AT-SPI2, they are run under XVFB using a separate dbus
        session through dbus-launch.
        
        Working on this has already lead to reporting and/or solving some
        issues:
        
        * https://gerrit.libreoffice.org/c/core/+/151303
        * https://gerrit.libreoffice.org/c/core/+/151650
        * https://gerrit.libreoffice.org/c/core/+/152456
        * https://gerrit.libreoffice.org/c/core/+/152457
        * https://bugs.documentfoundation.org/show_bug.cgi?id=155625
        * https://bugs.documentfoundation.org/show_bug.cgi?id=155705
        * https://gerrit.libreoffice.org/c/core/+/152748
        
        Only a subset of the a11y APIs are covered for the moment, but the
        current state should make it easy to extend upon.
        
        Change-Id: I1a047864ce8dc1f1bc3056ad00159f7fd5e5b7d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-27  Michael Weghorn  <m.weghorn@posteo.de>  [3121642fb1927c9cb1aa35c6b3e6afa818459117]

        a11y: Clarify AccessibleEventId::ROLE_CHANGED doc
        
        Mention that old and new value don't need to be
        set in this kind of event and how the new role
        can be retrieved.
        
        Change-Id: Iefde16a91b71af87feccb5ec2e6a32e682d60b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154987
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-27  Michael Weghorn  <m.weghorn@posteo.de>  [ce0a48a1eb16d6309dba175e032a52eb5ede2542]

        tdf#155625 a11y: Notify about menu item role change
        
        Send a `AccessibleEventId::ROLE_CHANGED` event
        when the accessible role of a menu item changes
        (s. how `VCLXAccessibleMenuItem::getAccessibleRole`
        takes into account `MenuItemBits::RADIOCHECK` and
        `MenuItemBits::CHECKABLE` to determine the accessible
        role for the underlying menu entry).
        
        This fixes the issue of obsolete values for roles being
        used, which was uncovered by the upcoming
        Change-Id I1a047864ce8dc1f1bc3056ad00159f7fd5e5b7d3
        ("vcl gtk3: Introduce AT-SPI2 tests for the GTK3 accessibility layer").
        
        With this in place, the workaround for tdf#155625 in
        the upcoming gtk3/AT-SPI tests is no longer necessary
        and `make CppunitTest_vcl_gtk3_a11y` with
        https://gerrit.libreoffice.org/c/core/+/153069 patch set 11
        still passes after dropping the workaround:
        
            diff --git a/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx b/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx
            index bbcd263fee0c..762401181bf4 100644
            --- a/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx
            +++ b/vcl/qa/cppunit/a11y/atspi2/atspi2.cxx
            @@ -264,9 +264,6 @@ void Atspi2TestTree::compareObjects(uno::Reference<accessibility::XAccessible> x
                  * be represented with a round trip. */
                 const auto nLORole = mapToAtspiRole(xLOContext->getAccessibleRole());
                 auto nAtspiRole = pAtspiAccessible.getRole();
            -    // FIXME: workaround for https://bugs.documentfoundation.org/show_bug.cgi?id=155625
            -    if (nLORole == ATSPI_ROLE_CHECK_MENU_ITEM && nAtspiRole == ATSPI_ROLE_MENU_ITEM)
            -        nAtspiRole = nLORole;
                 CPPUNIT_ASSERT_EQUAL(nLORole, nAtspiRole);
                 /* name (no need to worry about debugging suffixes as AccessibilityTools::nameEquals does, as
                  * that will also be part of the name sent to ATSPI) */
        
        Change-Id: I0d88a7eda592f5ee9abf368ce1d5feb6611b9971
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154947
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7d830be6d4ec1781e683001d1b649828be5ab2bd]

        gtk: silence gtk_label_set_label: assertion 'GTK_IS_LABEL (label)' failed
        
        Change-Id: I7c6a4add9fe11ed123ce81302998ad246538c7fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154991
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-27  Noel Grandin  <noelgrandin@gmail.com>  [be8e52ca8bcc674ff20432766bbe2748cbfc122b]

        avoid some allocation in MapMode
        
        the vast majority of the time we call the single-arg constructor
        for MapMode, and don't modify the resulting object, so declare
        some singletons for those cases.
        
        Change-Id: I5f6e98c638a86acfa5da8bb5944394caa66af9cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [a7ffd469fb125f92da9848c2cfb09991862599c5]

        Check / adjust the correct variables
        
        mnNumerator / mnDenominator are sal_Int32, so after they were assigned,
        they can't be out of range.
        
        Introduce a gcd initial step to avoid precision loss sometimes.
        
        Negative denominator is used quite some time, so drop the obsolete
        comment, while here.
        
        Change-Id: I66b77fb3d69cfd2265ac2ed88344af9cfade405b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154957
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [89ccdd1b7be48461a33200c43b2fd340e646df8b]

        tdf#156482: fix order in SvxBaseAutoCorrCfg::ImplCommit
        
        Change-Id: I0c7315357a7a9ec446b06cf33420c20a58a8ec42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154958
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e06456180ade61aa519819702810a3b9779a6e9e]

        crashtesting: crash on export of forum-en-41439.odp to pdf
        
        and various others.
        
        since:
        
        commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
        Date:   Fri Apr 16 20:33:10 2021 +0200
        
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        changed drawinglayer/source/tools/converters.cxx convertToBitmapEx
        
        return BitmapEx(aRetval, aAlpha);
        
        if (aAlpha.hasAlpha())
            return BitmapEx(aRetval, aAlpha);
        else
            return BitmapEx(aRetval);
        
        and SoftEdgePrimitive2D::create2DDecomposition assumes a mask exists.
        
        Presumably no mask -> fully opaque -> do nothing is the right outcome
        here.
        
        Change-Id: I7379c55c822c149a4320509d27a159cf5a07cc09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154985
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-27  Michael Weghorn  <m.weghorn@posteo.de>  [b73a8731c6f71a9a7cedc8e97afcd5a89b55cfe9]

        qt a11y: Return app as parent for top-level objects
        
        If an accessible object does not have a parent in the
        LO a11y hierarchy or in the QObject hierarchy, return
        the app as accessible parent.
        Top-level items (like dialogs) don't have another
        accessible parent, but are children of the app.
        This can also be seen e.g. in Accerciser: For example
        Writer's "Page Style" dialog is listed as a child of the
        application, but it had no parent without this change
        in place, breaking automatically selecting the bookmarked
        a11y object in Accerciser's treeview of the LO a11y hierarchy
        when restoring the bookmark, since that relies being able to
        walk up the a11y hierarchy.
        
        This is in line with what Qt itself does, s. e.g. qtbase
        commit [1]:
        
            commit 6ec35ff8c56222a317b838b6aac390eb6974de85
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat Jul 8 15:16:12 2023 +0200
        
                a11y: Report app as parent for top-level item views
        
                As happens for other widgets
                (s. QAccessibleWidget::parentObject), report the app
                as accessible parent for item views that don't
                have another parent set.
        
                Otherwise, the accessible tree is broken when
                there's a top-level item view:
                The application has the item view as a child,
                but the child does not have any parent set.
        
                Extend a QListView autotest accordingly.
        
                Fixes: QTBUG-115135
                Pick-to: 6.6 6.5
                Change-Id: Ie06874681180a30fc6248dc98f80c4158d837278
                Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=6ec35ff8c56222a317b838b6aac390eb6974de85
        
        Change-Id: Ia20bf1d5311dd918eb7563161745cdb70edc0787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154982
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9d1cc55a7738ac401aaa787c42ce9c330c38631b]

        Fix typo
        
        Change-Id: I09fc9db6621a1e074a76e38d1d98a666ab2159f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154983
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-27  Hossein  <hossein@libreoffice.org>  [f58dc86c9c8a257f620b009e243ab591a4a67ced]

        tdf#156268 Add UITest for Calc ### display crash
        
        UITest loads a minimal .fods example to check if Calc crashes with that.
        The example file does not crash without UI, as it needs the ###
        indication to be painted on the screen. Calc does not crash with the
        CppUnitTest, tested using testImportCrash() to load the file in a test
        added to sc/qa/unit/subsequent_filters_test4.cxx. Also, PDF export works
        without problem. But, UITest leads to crash without the fix in place.
        
        The UITest can be run using:
        
         make UITest_calc_tests9 UITEST_TEST_NAME=tdf156268.Tdf156268.test_tdf156268
        
        Change-Id: I9712d70f057cfc11f10fd98caadbf6e10ee67d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154977
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-07-27  Noel Grandin  <noelgrandin@gmail.com>  [ece0132a574beb5e56cf7470a10c209c2a3df412]

        deduplicate some code in ImplCalcMapResolution
        
        Change-Id: I792394079c0efbea0ea62f580fbad3bd2a66f93a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [175c01e4307ba04883e531fd7899d35f160c2d6b]

        rename GetFieldRectPixelAbs to GetFieldRectPixel
        
        since it can return either absolute or relative values
        
        Change-Id: I23f2403879eded3ec4b3ca20a639ea18b28f5de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ba0c39064fd97816774f4c06ca84c92c4a137450]

        Invalidate less on entering/leaving header/footer
        
        Instead of invalidating the entire window, just invalidate the
        parts that need to change.
        
        Invalidate a sequence of Rectangles rather than bundle them
        into a vcl::Region. Currently Window::Invalidate(const vcl::Region&...
        does a LogicInvalidate(rRegion.GetBoundRect()) so get a mega rectangle
        that covers everthing which is the opposite of what I want to get here.
        It might be worth using GetRegionRectangles there.
        
        Change-Id: Idc3f5f7d19dd57da725072ec4161d932c0c26902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [89d3735e05b98223a49a387421386fd736fc3de6]

        tdf#146576 - Propose clipboard content when inserting a hyperlink
        
        Change-Id: I30067b88b3d1e196f7ecfd150f5215cc93adf095
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154931
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-07-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [cf8f7b91f41821b79495c0388359c4cb1156ea67]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b2d15fb7c2a59e7ca7f2e53001df4f9defe4e7dd
          - tdf#149318 Fix HIDs in Format menu (Draw)
            
            This patch fixes the missing HIDs of menu entries that have submenus in Draw's "Format" menu.
            
            The help pages of two missing entries are also created.
            
            Change-Id: Ia64c4a8a714a6eac51bace2718e464aaf7dc3103
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154950
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [1f10a5b5a04a9d0cd5f456293e62e4f2c0fd7bb3]

        tdf#149888 Make F1 work in Math initial state
        
        Currently, when Math is opened and F1 is pressed in its initial state, no help page is opened. This is caused by the GrabFocus call in InitialFocusTimerHdl (see comments in its implementation).
        
        This patch ensures that pressing F1 both in the Edit and Graphics windows will open the main help page of the Math module.
        
        NOTE: This patch will only work after the related patch in helpcontent2 gets accepted, since it is responsible for creating the HID target in the XHP file.
        
        Change-Id: I59980cea1816a863e1aaa2d0757d9b141437ead5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154691
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-07-26  Eike Rathke  <erack@redhat.com>  [ec912956903b2657f4a6b67a68c2687e8be32508]

        Resolves: tdf#147955 Recalculate OOXML for bad generators with all 0.0 results
        
        Change-Id: I0ad301dddfe986a38303ce1134e080bafbf312de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154944
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-07-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [16b80e2fd18b61f638e9387bb134fbe9e582f421]

        tdf#151902 Doc themes - place Help button on the left
        
        This patch places the Help button of the 2 dialogs on the left
        
        Change-Id: I11bc0c220fa15fd78dbd789d71f5f0268f08d089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154942
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-07-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6d5c6551a06399308cfbb4ab741467256659eada]

        Update git submodules
        
        * Update translations from branch 'master'
          to a6bc06de12b6ce836095e976d7fa7a27f3c8bd26
          - update translations for 7.6.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I075679900c1be669a6aef260e502a1d240285918
            
2023-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [39eaf879c07f730f3af25e5c9a4b66b064f4171c]

        no need to check IsMapModeEnabled here
        
        LogicToPixel already does this for us
        
        Change-Id: If208a9e57ab8f5f0b6a26d715aa8493523682977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154932
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c70afbcc2a2aea243caf6ddac606c15a06fc5f9]

        improve override of Window::Invalidate(*)
        
        rather than having to override 3 different methods, have them override
        the ImplInvalidate, which is where the code ends up anywhere.
        This already exposes a couple of places that were not overriding all 3
        methods.
        
        Change-Id: If76abcf18325b7138ea451fbd0213cd6c7b4daa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [70f84abd6379c47db96d81d4b028041daa8c5d24]

        cid#1538888 silence Improper use of negative value
        
        and
        
        cid#1538887 Improper use of negative value
        
        Change-Id: I0d62fb6b3650351dbe6c3cbbc0809b145afc2f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-26  Aron Budea  <aron.budea@collabora.com>  [97a32713174a14758672d388de7627c71e2b70f8]

        lok: sfx2: fix change state "SheetRightToLeft" 2nd attempt
        
        This reverts commit 71e5f7e43471cc479ea1e818c813170a389964e6,
        and adds SheetRightToLeft in a different place.
        
        Change-Id: Id7001d06b247713de2e4dfe5076d156988e932d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152808
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        (cherry picked from commit f44aed75f1c1f64c07651376fd2f638f61e0c3b1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154928
        Tested-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-07-26  Khaled Hosny  <khaled@libreoffice.org>  [82e263550b81267611f90aecd1aeef163d47ed8a]

        Add short ContextLabel for special character commands
        
        Restore the “Insert” in full labels, and add short ContextLabel without
        it.
        
        Followup to:
        
        commit a9180786cf39c12b9000c7372e7c30cd2ee8501e
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Tue Jul 25 12:11:48 2023 +0300
        
            tdf#107447: Align special character names with Unicode names
        
        Change-Id: Iea8c45cbe8acb4497b515ecbf7fe0d46803d18bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154939
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-26  László Németh  <nemeth@numbertext.org>  [7f0e31976793c2701110742eb3d7ef4858eec72a]

        tdf#156474 sw tracked table column: fix accept of insertion
        
        Accepting tracked table column insertion didn't reset
        HasTextChangesOnly bit of the table cells, resulting
        blue/pink cells (i.e. column change) after modifying
        only text content of the text, and later bad column
        deletion at accepting text-only deletion and at rejecting
        text-only insertion.
        
        Follow-up to commit 472abf99a4d90d7a53316394a2e51a26b7e62345
        "tdf#155341 sw tracked table column: add insertion".
        
        Change-Id: I2e06e1b064d51c5e7cf8140a5fd7932e7be4f765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154935
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [5d7a602bad394d219599af07e13535acf2481ef8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 92e7259e70677f4aa6bdd6c43643b8dbbbc6e08d
          - tdf#149321 Add HIDs for the Table menu
            
            This patch adds the corresponding HIDs that are missing in the Table menu (Writer).
            
            Change-Id: I49de66b9aa04fbacc9a51321cd0a57a3e6508ee2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154929
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-26  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [bf2bc6ccb073d2c4c4a9d67d02e6cdb580a2fa8c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3d47594bb645481a562b5650ab51a18f1340e319
          - add note about needing hyphenation rules
            
            Change-Id: Ia470a2475027dbcd7a8fd0def56db69768df9158
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154921
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-26  Patrick Luby  <plubius@neooffice.org>  [1184a0130e7f340093a4bc0de032ebea1866b467]

        tdf#144053 Compare version to ProductKey entry in bootstraprc
        
        Using the mdls command fails if macOS Spotlight is disabled for the path
        selected by the user. So, instead, check if the path contains a matching
        "ProductKey=<version>" line in its Contents/Resources/bootstraprc file.
        
        Change-Id: Idbf8e2712b9fae8efa0997cf5c5c0f3fa6e68658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154718
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0818c81e51eaada43321b12f013c29dd2a263017]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5332d9c54e70cdc827bad5f2d5d8a42b9e8c0ea7
          - tdf#105122 entry page for doc themes.
            
            Work in progress
            
            This patch adds 2 help pages for the document themes dialog and document theme color dialog.
            
            Contents will be added later.
            
            Change-Id: Ia357a30e6c749898a3a636eba922bd1629c3249f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154941
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [6fa4e5965b2a79ae6735f4191a2261713a42356e]

        tdf#149318 Set HID for menus that have sub menus
        
        This patch fixes the following issue when pressing F1 while hovering on a menu entry that has submenus:
        1) Place the mouse over a menu entry that has submenus (f.i. in Draw go to Format - Table)
        2) A submenu will appear, however leave the mouse over "Table"
        3) Press F1... the help ID used will be "slot:0" because LO is trying to find the help ID of the selected entry in the submenu, but since none is selected, then the generic "slot:0" value is used.
        
        To fix this problem, this patch assigns a Help ID for the submenu (not for its entries) so that when no entry is focused, then the submenu HID is used.
        
        IMPORTANT: note that pressing F1 on menus only work with gen and win. Due to bug 156376 pressing F1 on menus does not work with kf5 and gtk3 (yet).
        
        Change-Id: I717e7669faac47a12c929129c0de98dee7f44439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154862
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7dc697addd0895b8aee0c051c0d4d4125414f012]

        Resolves: tdf#155716 grab focus when context menu is activated
        
        Change-Id: I194aba413d5adf07c8d78823f2f9a086f95cf248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b3dcd24e4da1f83bfaf8e0ffd93839eeae621b0]

        Revert "simplify logic in FloatingWindow::ImplCalcPos"
        
        This reverts commit ea3317188589554ea5773db53aa9e0cc88bee271.
        
        Reason for revert: There are 3 different coordinate systems at work here, not 2, my mistake.
        
        Change-Id: Iee69b8ba3c2fe60b26b118e79116035be42c6c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6a51ab527b56ddc2bf6ec6ccbfbf2bc608244355]

        Resolves: tdf#156411 listen to "value-changed" not "changed"
        
        we were listening to "changed" and querying the "value", but the value
        isn't guaranteed to have changed while the contents are being edited,
        only when "value-changed" arrives.
        
        Change-Id: I077051555813df48adae4259aa9a93d39c360dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1b6c01bdf769582508c852b24ab9d2a04fc0956f]

        Related: tdf#156137 allow GtkLinkButton to wrap
        
        Change-Id: I00ca5a9056b64389f1d55aa8ca6a9d5fd8a16372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-26  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [90e3af16c12f94f487ff7516048a239db1d2ff7d]

        Resolves tdf#95329 - Number of comments in word count dialog
        
        Change-Id: I29ca811065cce83f9c8630f79a2b78c2c3fe0da1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154581
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-26  Eike Rathke  <erack@redhat.com>  [49b601937f5ba7739198a1b16ba6da2351897750]

        Resolves: tdf#156467 Let array ROW() and COLUMN() return a scalar value
        
        ... instead of a single element matrix.
        
        Change-Id: I8307e24ef68dc54350fbdda74bc61b1df6a5107b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154908
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-07-26  Noel Grandin  <noelgrandin@gmail.com>  [41a3620e51726fac1419df77f87113cb32e9981a]

        add code pointer to comment
        
        Change-Id: If61d6bcc9703e6a8359fc3e51af4c1516b64a87d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154902
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [6568a29fa256d143a332b424c0582b0e665b65d6]

        cool#6931 on ctrl+[right/down] don't leap to the limits of the document
        
        ...when there is no more data, instead jump a generous block of emptiness.
        
        Limit to direct interaction by user and the simple navigation case
        (leaving block selection alone) and only for LibreOfficeKit::isActive
        
        Change-Id: I66234394529785d3f0f8fe6a6524239dad8ffb32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-26  Noel Grandin  <noelgrandin@gmail.com>  [ea3317188589554ea5773db53aa9e0cc88bee271]

        simplify logic in FloatingWindow::ImplCalcPos
        
        no need to convert this position backwards and forwards
        
        Change-Id: Iba4ebcba420025865638c99fa143ea0d7d262805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154901
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-26  Khaled Hosny  <khaled@libreoffice.org>  [24d0a62bd75b9a895c419aa165da648ab18f134d]

        tdf#156368: Fix setting watermark font for CJK/CTL text
        
        We were setting only Western font when getting the shape, so if there is
        no Western characters in the text the default font would be used. There
        is no separate setting for CJK/CTL fonts, so we sets the same font for
        all the three.
        
        Change-Id: If2ba2a206f95e0efe9139b9d092b1d6dbf05967c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154894
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ba57377698e7453638233524bc38e6bada5cd7e0]

        keep gtk3->gtk4 automigration rules
        
        Change-Id: Ie66f1343dffce441836beaf5a779b32b92e3bbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Laurent Balland  <laurent.balland@mailo.fr>  [5ae709d8519dd6d0de265d516c6158ccbdf4882e]

        follow tdf#154131 Treat also HMTL import
        
        Add Detect numbers in scientific notation option to HTML paste
        Still need some qa tests
        
        Change-Id: I553404a01ab2a61566b861b3c01d14bdc0c46668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152591
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-07-25  Mike Kaganski  <mike.kaganski@collabora.com>  [10f91e94c2880c10c546eef094630f5b5699f2b0]

        Do not emit C++ officecfg struct from deprecated property
        
        This would prevent mistakes like what was fixed in commit
        514cc22875a90c8faa3d946ad47ebb68bd710ac7.
        
        Change-Id: Icc67d485461e23d25f2003303a243c830d48b8c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154623
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-25  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [98b04571e8787efa34bc3db2a93ee09f2241e262]

        Revert "tdf#156137 - A11Y - Fix Long object names need to proper handling"
        
        This reverts commit d89dc4ac09d3c2bd55174f09485173057cc1403b.
        
        Reason for revert: GtkLinkButton.wrap is not available for native gtk widgets.
        
        Change-Id: Ie1634691996fb6d54b69013a585914d123d5e195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154913
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dc4af409ab8236ad36c603502042e826c4ff183b]

        fix .ui indent
        
        Change-Id: Ib6ebed36b857d5ffa449f66319ef67f2f84722dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154897
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bc31aed0eda23fd0a143a54f6aecdbbde1018ccc]

        move %PRODUCTNAME using accessible description into a .hrc
        
        similar reason as
        
        commit 3cca2c605313576187878a195fb612eb25bd6150
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Sat Jun 4 21:10:16 2022 +0100
        
            restore %PRODUCTNAME to accessible descriptions that need them
        
        reading all a11y desc at load time in order to possibly substitute
        %PRODUCTNAME and re-write a11y desc at runtime explodes gtk's a11y, so
        we limit it to where we have to do it.
        
        Change-Id: I6e92bfa7db2ba769e2bd899b31d3ef42b4d37e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [29d7b55af594e18065684ef127d781d76324c31b]

        Control::LogicInvalidate takes a pixel rectangle
        
        not a logic rectangle
        
        Since
            commit 7adfecb0f5947ae258226c8d1652546f81577026
            Author: Marco Cecchetti <marco.cecchetti@collabora.com>
            Date:   Sun Feb 5 17:47:34 2023 +0100
            lok: form controls: rendering and mouse event forwarding
        
        Change-Id: Ibbc0ea03d014ac2141bd59858f0a73e74ffe1144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154895
        Tested-by: Jenkins
        Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2023-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [05d1790f746dfb7367a4c79aa43b00457b7b2cc9]

        tdf#156463 crash on exit after editing a chart (gtk3)
        
        regression from
            commit 1ed765c818af2186e459c5ad0eff24dc39a20d34
            tdf#155235 workaround gtk3 accessiblibility crashes on close
        
        Change-Id: I1a43c7df6394426d8ce09ed382dcc6833dbe1c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154893
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-25  Khaled Hosny  <khaled@libreoffice.org>  [a9180786cf39c12b9000c7372e7c30cd2ee8501e]

        tdf#107447: Align special character names with Unicode names
        
        Unicode names are recognizable more prevalent, no need to invent our own
        names.
        
        * Non-breaking Space → No-break Space (aligns also with Narrow No-break Space)
        * No-width Optional Break → Zero Width Space
        * Remove redundant “Insert”
        
        Change-Id: I005c3fefd24045eb4b5c2054d82638b3f2d5f59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154886
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [7ec4c6df68233b73b1e257e013583ca49fc2ec9b]

        tdf#142905 XLSX import: don't trim leading spaces in formula cell
        
        When importing an XLSX file, there was a discrepancy between the
        read and recalculated cell values if it contains leading/ending
        spaces. With this fix, trimming in worksheet files is only applied
        to elements that contain a parameter and do not have a
        space="preserved" parameter.
        
        Change-Id: I91e09eaa3cb79537ddbed36e1124e4afd124d8f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154674
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-25  Tünde Tóth  <toth.tunde@nisz.hu>  [94ca402cd1fe2fd9776d08448f7216b7f638e69a]

        tdf#156174 sc DBData: fix regression of database ranges
        
        Regression from commit 0c0444c44107f1a18f23dd0833d462d8dbf56569
        "tdf#126926 sc DBData: delete the database range".
        
        Change-Id: If6cccc41af42a44cadbb8485bfa5b9a8eca5a757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154582
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-25  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [56ce1aa9239637a10f747c00ba93e96bb2e613ab]

        Resolves tdf#58434 - No field shading for soft hyphen and non-breaking spaces
        
        Change-Id: I27123b013aa8fc876ddb06e1dd96f4ac50d6ebbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154847
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-25  Michael Weghorn  <m.weghorn@posteo.de>  [609ed2944b030a692c942428afa8bf7c3ac93672]

        tdf#155414 win a11y: Honor system setting to disable animations
        
        Use `SPI_GETCLIENTAREAANIMATION`, the "client area animation
        parameter [that] indicates whether the user wants to disable
        animations in UI elements" [1] to determine whether
        animations should be disabled.
        
        The parameter can be set in Windows, as documented in MDN docs
        for the "prefers-reduced-motion" CSS media feature [2]:
        
        > * In Windows 10: Settings > Ease of Access > Display > Show animations in Windows.
        > * In Windows 11: Settings > Accessibility > Visual Effects > Animation Effects
        
        On top of
        
            commit 9d68c794d67259a38de1465090f6f1e7fb588d62
            Author: Patrick Luby <plubius@neooffice.org>
            Date:   Fri Jul 21 19:55:02 2023 -0400
        
                tdf#155414 include system "reduce animation" preferences
        
        , this implements the Windows equivalent of what that change does for macOS.
        
        [1] https://learn.microsoft.com/en-us/windows/win32/winauto/client-area-animation
        [2] https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
        
        Change-Id: I1485cd7dc97b7d93abdeab78ec330874f2a5cb98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154889
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-25  Michael Weghorn  <m.weghorn@posteo.de>  [f3a4b6e1d71ed40d84ef65c6626fb7eb77a13545]

        tdf#155414 kf a11y: Honor KDE Plasma setting to reduce animation
        
        When using the kf5/kf6 VCL plugin on KDE Plasma, use the animation speed
        setting to determine whether animations should be disabled, in line with
        what is documented in MDN docs for Firefox using for the
        "prefers-reduced-motion" CSS media feature [1] and how
        kde-gtk-config maps that to the "gtk-enable-animations" setting [2].
        
        The setting can be set as described in [2]:
        
        > In Plasma/KDE: System Settings > Workspace Behavior -> General Behavior >
        > "Animation speed" is set all the way to right to "Instant".
        
        On top of
        
            commit 9d68c794d67259a38de1465090f6f1e7fb588d62
            Author: Patrick Luby <plubius@neooffice.org>
            Date:   Fri Jul 21 19:55:02 2023 -0400
        
                tdf#155414 include system "reduce animation" preferences
        
        , this basically implements the KF5/KDE Plasma equivalent of what that change does
        for macOS.
        
        Other than Gtk, Qt does not seem to have a general way to specify
        that animations should be reduced/disabled, so evaluate
        that based on the desktop environment instead, and implement
        for KDE Plasma for the kf5/kf6 VCL plugin only for now, which is
        probably the most common use case.
        
        Logically, this would better fit in the qt5/qt6 VCL plugin
        than the kf5/kf6 one, but do it in the KF-specific code to avoid
        a dependency on KF5/KF6 libraries in qt5/qt6. (And other than
        qt5/qt6, kf5/kf6 are auto-selected in Qt-based desktop environments,
        so it shouldn't make much of a difference in practice.)
        Another alternative - should the need aries - might be to move this
        from the VCL plugin to the desktop backend (`shell/source/backends/kf5be/`
        for the case of KDE Plasma 5.) and introduce a new property for that.
        
        [1] https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
        [2] https://docs.gtk.org/gtk4/property.Settings.gtk-enable-animations.html
        [3] https://invent.kde.org/plasma/kde-gtk-config/-/blob/881ae01ad361a03396f7f327365f225ef87688e8/kded/gtkconfig.cpp#L205
        
        Change-Id: I35cd6c2568a3716491581e51dfaeaf32cad454aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154888
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-25  Michael Weghorn  <m.weghorn@posteo.de>  [e320460f9793608ef79aab402b3a03dc28ba7dd5]

        tdf#155414 gtk3 a11y: Honor gtk setting to reduce animation
        
        Use the "gtk-enable-animations" setting [1] to determine whether
        animations should be disabled, as is documented in MDN docs
        for Firefox using for the "prefers-reduced-motion" CSS media
        feature [2].
        
        Note that KDE Plasma's system settings also set this Gtk preference
        when taking the steps that [2] describes for reducing motion on KDE
        Plasma (s. implementation in [3]):
        
        > In Plasma/KDE: System Settings > Workspace Behavior -> General Behavior >
        > "Animation speed" is set all the way to right to "Instant".
        
        On top of
        
            commit 9d68c794d67259a38de1465090f6f1e7fb588d62
            Author: Patrick Luby <plubius@neooffice.org>
            Date:   Fri Jul 21 19:55:02 2023 -0400
        
                tdf#155414 include system "reduce animation" preferences
        
        , this implements the Gtk equivalent of what that change does for macOS.
        
        [1] https://docs.gtk.org/gtk4/property.Settings.gtk-enable-animations.html
        [2] https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion
        [3] https://invent.kde.org/plasma/kde-gtk-config/-/blob/881ae01ad361a03396f7f327365f225ef87688e8/kded/gtkconfig.cpp#L205
        
        Change-Id: Ie229f0d58d53f4629721dd6db465e5b029d9699e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154887
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bbdb62ca2f5545588b2e6d11421c6038425cebab]

        Resolves: tdf#156462 ctrl+left in calc doesn't always jump to the correct cell
        
        since:
        
        commit 9e2d48b9e04f7ea895fb095699c32ed8a44eb129
        Date:   Wed Mar 30 11:58:04 2022 +0200
        
            reduce Calc's INITIALCOLCOUNT to 1
        
        but:
        
        commit a680f6988482f13489d6c802b6078d43564ae934
        Date:   Wed Jun 7 22:48:01 2017 +0530
        
            tdf#50916 : More refactoring in table1.cxx
        
        is likely also relevant wrt: "If nCol is in the unallocated range
        [nLastCol+1, MAXCOL], then move it directly to nLastCol"
        
        If the cursor is outside the allocated column range then the search
        started 1 cell to the left of the last allocated column
        
        Change-Id: I854173ad13d50e50d85e9902b31585e8ae3e2c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154885
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Tibor Nagy  <nagy.tibor2@nisz.hu>  [e384be0f6ea6453e57cd4a7c4402d26b49debc41]

        tdf#99808 sc: fix background of conditional formatting in merged cell
        
        The background color of conditional formatting is applied only to the
        first cell in the merged block, at least under Windows.
        
        Note: Undo/Redo is still not perfect, at least under Linux.
        
        Change-Id: Ic87983fa6e3279a64841babc565fbe97710ff730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154390
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [99e6e4dd273752ee671d1ade00b381786800a508]

        tdf#156354 - Fix UI Basic dialog contents not visible in preview mode
        
        with scrollbars enabled. Basic dialog elemets appear under groupbox
        in case of the dialog have scrollbar.
        
        Change-Id: I07b26c4a4f733cb08b3432ee41d829552ec5e08d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154876
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2263f5d081155531c5df0d63251d7ae3dc85836]

        drop long-commented-out code
        
        since:
        
        commit a2c67975c03010b90c706523293f180c1f29e229
        Date:   Wed Aug 28 14:28:40 2013 +0200
        
            fdo#67358: sw: "fix" line painting artifacts when resizing columns
        
        Change-Id: Ia8ae86e7e07d7e98698761541eabb69dba81e6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154884
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [c49b377798f5abd0e30acc32d562f63481daa287]

        loplugin:redundantcast
        
        after
            commit 81994cb2b8b32453a92bcb011830fcb884f22ff3
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 16 20:33:10 2021 +0200
            Convert internal vcl bitmap formats transparency->alpha (II)
        
        Change-Id: Ia0b29e87696b99459c62275898e1ec47283072b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154883
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [fa61fb2b49327de8583505bdadf58067773409bd]

        tdf#156170 - A11Y - Fix "Avoid endnotes." issue is not hyperlinked
        
        to jump to corresponding anchory.
        
        Change-Id: Id01f66b8d75d85b4618ca30873bf3dc4951b74d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154882
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-25  Tibor Nagy  <nagy.tibor2@nisz.hu>  [ee4bd745be5dee15b68ca483f7f7771957ae3b3e]

        tdf#155322 sc: fix conditional format color scale in merged cells
        
        Only first cell of a merged range got coloring, now all of them.
        
        See also commit f142b3e84f97ae678bd0a94614e867d369680458
        "tdf#131471 sc: fix background color of conditional formatting style".
        
        Change-Id: I0e95bf49369de219e659295643aaf2659dd3de48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154362
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8bf6b877c6c4ee53611569a28114e7bbae000479]

        crashtesting: a lot of crashes on exporting to ods
        
        since:
        
        commit 1d2380516ac9871743c5a5455f0734d02be8eade
        Date:   Thu Apr 20 20:33:56 2023 +0530
        
            tdf#129847 Show "more content" red arrow along with ### indication
        
        e.g.
        
        soffice --headless --convert-to ods forums/xlsx/forum-mso-en4-566515.xlsx
        
         #3  0x00007ffff7b61662 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
         #4  0x00007fffe1f6cd02 in RowInfo::cellInfo (nCol=187, this=<optimized out>) at sc/inc/fillinfo.hxx:201
         #5  ScOutputData::LayoutStrings (this=this@entry=0x7fffffffb0d0, bPixelToLogic=bPixelToLogic@entry=false)
             at sc/source/ui/view/output2.cxx:1908
         #6  0x00007fffe1f6df21 in ScOutputData::DrawStrings (this=this@entry=0x7fffffffb0d0, bPixelToLogic=bPixelToLogic@entry=false)
             at sc/source/ui/view/output2.cxx:1478
         #7  0x00007fffe1f9d52e in ScPrintFunc::DrawToDev (rDoc=..., pDev=pDev@entry=0x5555567d9890, rBound=..., pViewData=pViewData@entry=0x7fffffffb270,
             bMetaFile=bMetaFile@entry=true) at sc/source/ui/view/printfun.cxx:619
         #8  0x00007fffe1a49150 in ScDocShell::Draw (this=0x55555652c630, pDev=0x5555567d9890, nAspect=<optimized out>)
             at sc/source/ui/docshell/docsh4.cxx:2205
         #9  0x00007ffff5c66771 in SfxObjectShell::DoDraw_Impl (this=this@entry=0x55555652c630, pDev=pDev@entry=0x5555567d9890, rViewPos=Point = {...}, rScaleX=...,
             rScaleY=..., rSetup=..., nAspect=2, bOutputForScreen=false) at sfx2/source/doc/objembed.cxx:204
         #10 0x00007ffff5c66976 in SfxObjectShell::DoDraw (this=this@entry=0x55555652c630, pDev=pDev@entry=0x5555567d9890, rObjPos=Point = {...}, rSize=Size = {...},
             rSetup=..., nAspect=nAspect@entry=2, bOutputForScreen=false) at sfx2/source/doc/objembed.cxx:151
         #11 0x00007ffff5c6207d in SfxObjectShell::CreatePreview_Impl (this=this@entry=0x55555652c630, bFullContent=bFullContent@entry=false, pDevice=0x5555567d9890,
             pFile=pFile@entry=0x0) at sfx2/source/doc/objcont.cxx:197
         #12 0x00007ffff5c6412c in SfxObjectShell::GetPreviewBitmap (this=this@entry=0x55555652c630) at include/rtl/ref.hxx:206
         #13 0x00007ffff5c9c5a4 in SfxObjectShell::WriteThumbnail (this=this@entry=0x55555652c630, bEncrypted=bEncrypted@entry=false, xStream=
             uno::Reference to (OWriteStream *) 0x555557e84818) at sfx2/source/doc/objstor.cxx:3748
        
        use the same guard around accessing cellInfo as used elsewhere in this
        method
        
        Change-Id: If1fd5cff92655f8b51436f27a9b3d22fdc7a390b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [80966e2cdc1794d489b254b46a713b2a061c55ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5c83fcce4f02aed87ea15b04644eb9ebc413f03
          - Fix typo
            
            Change-Id: I029b3aa79ffd605c00603ff89fc265a70b45057a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154878
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-07-25  Noel Grandin  <noelgrandin@gmail.com>  [81994cb2b8b32453a92bcb011830fcb884f22ff3]

        Convert internal vcl bitmap formats transparency->alpha (II)
        
        (Second attempt at landing this)
        
        Image formats and graphics APIs use alpha, not transparency,
        so change our internal formats and data structures to work directly
        with alpha, so we don't need to modify data before we push it to
        graphics APIs.
        
        Add a couple of new Color constants to make the intention
        of the vcl code clearer.
        
        Notes
        (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask
        to more accurately reflect the requirements of the
        CGImageCreateWithMask function seems to fix some
        tests.
        
        (*) The vcl code does not properly support gradients
        with transparency. So the previous code was wrong, and this
        change is going to result in slightly different wrongness.
        
        Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [dabedcaf27b0af1e38a611b8d8e48444f848e01d]

        loplugin:unusedfields
        
        Change-Id: If9c76b9c500a5bee0fbf20a44597a250b7fa2af0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-25  Khaled Hosny  <khaled@libreoffice.org>  [42f0422d19c4d0a2fb09654fb6d1d92e50f6dd5c]

        tdf#156437: Fix missing name inside embedded Type 1 font in PDF
        
        Regression from:
        
        commit 7415ce2b9795a78f836bc5e5bffb4b56eee26b21
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Mon Dec 5 20:52:13 2022 +0200
        
            tdf#113048: Fix PDF ascender and descender of some fonts
        
        We were setting the font in PDF /Font dictionary, but not inside the
        font itself.
        
        Change-Id: I1936f615f62fd7afa8f31d66d35dbded879328c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154880
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Khaled Hosny  <khaled@libreoffice.org>  [529dce3d5b695637a1ccc8b4b697d87c5db0d3a2]

        editeng: Call unicode::getUnicodeType() on UTF-32 code units
        
        By using OUString::iterateCodePoints() instead of accessing individual
        UTF-16 code units that might be surrogate pairs.
        
        Change-Id: I5e3e513a788f0c939f96b0521fed16fe4848a053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154875
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Khaled Hosny  <khaled@libreoffice.org>  [2e6e40b7453e2005d46ba7866feff2f2caa1f100]

        i18nutil: Make unicode::getUnicodeType() take a UTF-32 code point
        
        Still need to fix call sites to handles surrogate pairs.
        
        Change-Id: I3ba896714fc6a90596c041148a3c9d965f60f4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154874
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Khaled Hosny  <khaled@libreoffice.org>  [89229524298398ca1b5239c2a7ca798900733f5d]

        i18nutil: Fix ICU case folding of surrogate pairs
        
        It can’t be easily made to work when mixing our case folding data (which
        seems to work on individual surrogates) and ICU functions, so port it
        over completely to ICU.
        
        Change-Id: I0e12b81b23a053a2a9a299e51908930a3d0b82d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154843
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-25  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [87ca7d2f146be2c309fc6fd36f9154f3ea4e4bd8]

        tdf#93315 sc: Only 84 empty row show in the Print Preview
        
        Change in Calc behaviour, dropping the 84 line limit.
        This way, if all rows or columns are bordered, only up to the last
        cell containing data is displayed in the Print Preview. In other
        cases, all bordered cells are visible.
        
        Change-Id: I7d874a093d76d5ed92b1b63b645b97582d52629e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153256
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [851f0dc7cd85eb146b205027cadc8decce0e5bed]

        i18nutil: Port unicode::getUnicodeType() to ICU
        
        One-less Unicode data table to forget to update.
        
        Change-Id: Icf64e55ec322578b2eefb9065842c218d6f3e061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154873
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  Patrick Luby  <plubius@neooffice.org>  [e7ff004892c950a863602e9380aef91a7ae2404d]

        Regression: eliminate white lines in infobar's close button
        
        When drawing the close button's background, the right and bottom need to be
        extended by 1 or there will be a white line on both edges.
        
        Change-Id: I67dcad422c0f33af3035621cd624c1ddafc89d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154871
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [d592e502488857871c44ba5d6e06043b1b6a63c4]

        i18npool: Test case folding of surrogate pairs
        
        Change-Id: I3097651927b85aaa46fc4fc59badf22d24fcb928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154872
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [88790291ddc00bfa18d3f7bcc0825b1ce14cb490]

        tdf#97152: Fix upper case mapping of lunate sigma (U+03F2)
        
        It was mapped to uppercase sigma (U+03A3) while it should be mapped to
        uppercase lunate sigma (U+03F9). Fix by letting this slot fallback to
        ICU case folding.
        
        Change-Id: I14ffa0151c740779b67af14be8c7af8c51c3a1e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154845
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [9eb88d78c8bc9e942814eb6fc4fe06a4e5736256]

        tdf#96343, tdf#134766, tdf#97152: Fallback to ICU for case mapping
        
        If we are requested to case map a character not present in our case
        mapping data, fallback to ICU case mapping functions.
        
        We should switch completely to ICU at some point, but we need to
        evaluate our case mapping data and see if it differs from ICU and if
        there is a reason for it.
        
        Does not handle the case of U+03F2 turning into Sigma from tdf#97152.
        
        Change-Id: Icf13ac7aab6d07b2a90fc0ff5ef1c4f50c7a7f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154803
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  TokieSan  <eltokhy@aucegypt.edu>  [e8d79381bf97d550920cec079fddf2b80927805a]

        Improved Accesibility String in Certificate Chooser Dialog
        
        Change-Id: Ib9f93d626b7f2629ebfb17f0f0f43af8fe24d4ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154744
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-24  TokieSan  <eltokhy@aucegypt.edu>  [eef190228ac5d3334e26204adb11e5f4c6f373c4]

        Added search icon to certificate chooser dialog search box
        
        Change-Id: I8abcee4739a218e9856fbf603792b480efe89dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154797
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dcc8d18be7e25aa46a1bb315c1039af405940047]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac281f6182dbb4ba1190c7bf89bfd693c58d6c5c
          - tdf#156441 Add help page for Calc drawing styles
            
            + refactor and fix for several outdated pieces.
            
            Change-Id: Ibc38e67fe988020974315e0508d623f0ba78ab20
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154870
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [231e4b2aa85968706049e7fd789cdea726089dba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c868b00dfc7f66231bdc6f241bd94182108fa02
          - refactor - no changes
            
            Change-Id: I4570164c2bf804c91f5e8a50a2a4c9f9eafaa256
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154849
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-24  Michael Stahl  <mstahl@redhat.com>  [2295c2b17cd7b4648f7d0842929be18125c0edab]

        sw, forms: some hacks to nerf time-fields so convwatch works better
        
        This is useful for PDF-based layout-comparison regression testing
        where date/time fields were updated upon PDF export and create
        lots of false positives. Hopefully these can be eliminated this way,
        at least from text documents.
        
        To test:
        Download https://bugs.documentfoundation.org/attachment.cgi?id=48452
        from tdf#38703 and export it with:
        
        STABLE_FIELDS_HACK=1 instdir/program/swriter --convert-to pdf DeleteStackSample.odt
        
        The date and time fields are now reset to
        30/12/1899 00:00:00
        
        Change-Id: Ic89111615074adb50f16a605f920f9a89c437dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/24442
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-07-24  Patrick Luby  <plubius@neooffice.org>  [9d68c794d67259a38de1465090f6f1e7fb588d62]

        tdf#155414 include system "reduce animation" preferences
        
        Allow the system's "reduce animation" preferences to disable the
        Calc animated border when copying a selection of cells.
        
        Also, fix failure to stop the animated border when a copy action is
        performed in a different document by cancelling the animated border.
        This transferable has lost ownership of the system clipboard so,
        in essence, the previous copy action that created this transferable
        has been cancelled.
        
        Change-Id: I4da6d557c5dbf653c38a99eb7a16d961843a41d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154752
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-24  Szymon Kłos  <szymon.klos@collabora.com>  [9429f5aa7912f6d7da67834b0d9e0451f49ecdd6]

        jsdialog: dark mode support in drawing area
        
        Change-Id: I235cf327c4c97d2f256c201ea4daf0c99f3d9005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [447b91964daf3ffed5bfd59382ba5724e9992fe8]

        tdf#154447 qt: Take menu bar into account for popup pos
        
        Change-Id I66b312fe09e078ec067773a483f9e59f627fcf93
        ("tdf#154447 Fix menu position in kf5") fixes the
        position for menu popups for the case where no menu
        bar is present, e.g. the default after switching to
        the Tabbed interface.
        
        While it improves the case where a menu bar is present,
        the menu would would still open a bit too far up for
        that case.
        
        Adapt the position by the menu bar height to make that
        case work as expected as well.
        
        Do this in `QtMenu::ShowNativePopupMenu` for now since that's
        easiest. Potentially, the height should have been taken
        into consideration somewhere earlier, but since the whole
        handling of menu bar height is quite "special", don't
        aim to address that elsewhere now, s.a. an earlier attempt
        to rework the whole handling in
        
            commit afc828b9833b7a612369e95606ba56d41ef2c369
            Date:   Sat May 28 23:47:21 2022 +0200
        
                VCL expect correct frame size for native menubars
        
        which was later reverted in
        
            commit f51b220b953ec71fb742f799fbe645a93cf3d944
            Date:   Fri Mar 24 08:06:56 2023 +0100
        
                tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect
        
            ... correct frame size for native menubars"
        
        Change-Id: Iafd80997f9f506cb22afe1aaf6d1a3f716700ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154839
        Tested-by: Jenkins
        Tested-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-07-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [7b060d1c2acf03378c87abb7215f9c0a957b549c]

        tdf#154447 Fix menu position in kf5
        
        Prior to this patch the menus were using "topLeft" as reference for positioning the menu, which made them appear on top of the control that originated their appearance.
        
        With this patch, it now uses "bototmLeft" to place the menu below the control (similar to gtk3).
        
        Change-Id: I66b312fe09e078ec067773a483f9e59f627fcf93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154771
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b2fdfa0e9aea207a065506c56c2a0033b4cbd44]

        fix COOL crash in theme dialog
        
        ==3975==ERROR: AddressSanitizer: heap-use-after-free
        /opt/collaboraoffice/program/libmergedlo.so
        	std::vector<model::ColorSet, std::allocator<model::ColorSet>
        >::clear()
        
        /home/collabora/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:1248
        /opt/collaboraoffice/program/libmergedlo.so
        	operator()
        
        /home/collabora/online-buildscripts/staging/builddir/libreoffice/svx/source/dialog/ThemeDialog.cxx:96
        /opt/collaboraoffice/program/libmergedlo.so
        	std::function<void (int)>::operator()(int) const
        
        /home/collabora/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706
        /opt/collaboraoffice/program/libmergedlo.so
        	Dialog::EndDialog(long)
        
        /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/source/window/dialog.cxx:1192
        /opt/collaboraoffice/program/libmergedlo.so
        	jsdialog::ExecuteAction(std::__cxx11::basic_string<char,
        std::char_traits<char>, std::allocator<char> > const&, rtl::OString
        const&, std::map<rtl::OUString, rtl::OUString, std::less<rtl::OUString>,
        std::allocator<std::pair<rtl::OUString const, rtl::OUString> > >&)
        
        /home/collabora/online-buildscripts/staging/builddir/libreoffice/vcl/jsdialog/executor.cxx:566
        /opt/collaboraoffice/program/libmergedlo.so
        	lcl_sendDialogEvent(unsigned long long, char const*)
        
        /home/collabora/online-buildscripts/staging/builddir/libreoffice/desktop/source/lib/init.cxx:4735
        /usr/bin/coolforkit
        	lok::Document::sendDialogEvent(unsigned long long, char const*)
        
        /home/collabora/online-buildscripts/staging/builddir/libreoffice/include/LibreOfficeKit/LibreOfficeKit.hxx:323
        /usr/bin/coolforkit
        
        Change-Id: I7b34c9649c96f6745c2230ac347644fb45ec7f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154836
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 2ee535bfdb089511261daff20e515714ed2c0563)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154851
        Tested-by: Jenkins

2023-07-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ed016c422f79777388c39d988c03c939730c0f2b]

        tdf#156299 Sync Insert Shape & sidebar Shape deck
        
        Change-Id: I2cf0eb6cdd9256c447de5bbb62e0b516e15cd80d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154835
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-07-24  Tibor Nagy  <nagy.tibor2@nisz.hu>  [f142b3e84f97ae678bd0a94614e867d369680458]

        tdf#131471 sc: fix background color of conditional formatting style
        
        The issue appears for merged cells when you trigger a change that
        causes the condition to be evaluated again.
        
        Manual test: open unit test document, put "1" in A1, and press Undo:
        the green background color of the condition was removed only
        partially.
        
        Change-Id: I8bb17c77ac49a1ee897c3e2b4902723d237765d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154277
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-07-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [17154ceafe4b96b43fdc9994736e378d6a11f3e4]

        tdf#92620 - Adjust error message about exceeding legacy module size
        
        Adjusted the error message about exceeding legacy module size and
        removed the code for saving image version 11. Modules using image
        version 11 still can be loaded. Saving modules always result in
        an image version higher than image version 11 depending on the
        size of the module.
        
        In addition, some minor performance issues (construction of the error
        message and the correct list of modules) were fixed.
        
        Change-Id: I3bde9fcc1596b63446193c836fa7b5cb06eb7d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149687
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-07-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5a82470f27898c8b453e63d3ee22d0b57f7836c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 94bda149c7f824e4c31db3efe1df6bb8df8a98be
          - tdf#38948 - Help on solver saved settings
            
            Remove warning on solver saved settings
            
            Change-Id: I84b10ee0ebabf686fa403b677cc12bc3a707ebc1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154842
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-24  Michael Weghorn  <m.weghorn@posteo.de>  [da5d11f0cb45d0f3655d84cd191508d0f93e57fc]

        Fix gtk4 build (set_item_help_id)
        
        After
        
            commit 65c91bd5aa6f9b68390739a0e027d23c8a32da08
            Date:   Fri Jul 21 14:47:47 2023 +0200
        
                tdf#147911 Implement set_item_help_id for context menu items
        
        , my `--enable-gtk4` build failed like this:
        
            In file included from /usr/include/glib-2.0/gobject/gobject.h:26,
                             from /usr/include/glib-2.0/gobject/gbinding.h:31,
                             from /usr/include/glib-2.0/glib-object.h:24,
                             from /usr/include/gtk-4.0/gtk/css/gtkcssenumtypes.h:11,
                             from /usr/include/gtk-4.0/gtk/css/gtkcss.h:34,
                             from /usr/include/gtk-4.0/gtk/gtk.h:30,
                             from .../libreoffice/vcl/unx/gtk4/convert3to4.hxx:11,
                             from .../libreoffice/vcl/unx/gtk4/gtkinst.cxx:13:
            .../libreoffice/vcl/unx/gtk4/../gtk3/gtkinst.cxx: In member function ‘virtual void {anonymous}::GtkInstanceMenu::set_item_help_id(const rtl::OUString&, const rtl::OUString&)’:
            .../libreoffice/vcl/unx/gtk4/../gtk3/gtkinst.cxx:11670:34: error: ‘m_aMap’ was not declared in this scope
            11670 |         ::set_help_id(GTK_WIDGET(m_aMap[rIdent]), rHelpId);
                  |                                  ^~~~~~
            make[1]: *** [.../libreoffice/solenv/gbuild/LinkTarget.mk:337: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkinst.o] Error 1
            make: *** [Makefile:289: build] Error 2
        
        This doesn't yet implement actually setting the help ID for gtk4,
        just fixes the build for now.
        
        Change-Id: I82dc997b998dbbc15e6fde3d6d80ec1944d2662c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154834
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-24  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [a407562a293d2cc5c7755951948a4e1e168d92bf]

        tdf#156262: use default ToC accelerator to avoid duplicate
        
        Change-Id: Ib995ce2921e1055fddf7ac965947c423c452eef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154438
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-07-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b0de2c49022b2562664d9379872799221b071c50]

        Clean up Sifr's links.txt
        
        Change-Id: Iee939486a9010ed8146fab9ac4be4387522871e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154830
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [c728b15cbad331f8be545d6b4aad167c1244f3d0]

        i18npool: Add a test for sigma case folding
        
        This is one of the special case folding characters.
        
        Change-Id: Icfe986b216eb62ed595402b31908c2fd22cd475e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154821
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  Khaled Hosny  <khaled@libreoffice.org>  [9d6134508405a403612a3463bae3fadcceec9245]

        CppunitTest_i18npool_characterclassification: use CPPUNIT_TEST_FIXTURE()
        
        Change-Id: I6cc87255af385116b7e86ceaea67b26ca1f44709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154806
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [94caaf5c9e2917a3202cf515d61eaa9399b2c2b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69cb2215657f692c62a564d3a4926d3272757fc9
          - tdf#147911 Add target HIDs for Template Manager context menu
            
            Change-Id: I88d2ce0061419a73d62bb4200b67ce09722d8df6
            Note: F1 on context menus only work with "gen" and "win" at the moment. For kf5 and gtk3 we still need to fix bug 156376.
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154772
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ed071f30ec301c96236d4dcb5d6b60cf80ee119b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67f6b667b074e7ec1372391b56f5cf6f82cfb87e
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(5)
            
            + refactoring
            + Writer Format menu (part 5)
            
            Change-Id: I9c5f9c62e90f3e72dd36028956151e23388d7ac8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154820
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e4ee999d6d9c10ee10d6778eca9354d8fbaa720f]

        ofz#60533 Timeout with fo:font-size="842pt"
        
        We end up exporting thousands of pages from minimal input size and
        time out, so just export up to some semi-reasonable amount of pages.
        
        Change-Id: I98667b4b94f10ab50e2d8e3f5bb58c8c75a77130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154814
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [461596dad7f34d40745fb6819fc1443dc896e017]

        don't need to duplicate CloseResponseToJustHide here
        
        the one in sfx2/childwin.hxx is enough
        
        Change-Id: I3b9f96fa99cb09875091561244297df5227a7b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ec911fad4836206f3ca5c5f35a37f6edf7224904]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5fd4936ad7e7519167668724ad85506b95f8acb
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(4)
            
            + refactoring
            + Writer Format menu (part 4)
            
            Change-Id: I5d478579b726918b1f0df95a7dce41683dc117ff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154813
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-23  Jim Raykowski  <raykowj@gmail.com>  [efbdd13f96888ae06717afafb1e4014ce502aa3e]

        tdf#154038 tdf#83618 fix wrong line spacing value
        
        Impress and Writer seem to require different MapUnit values for fixed
        line spacing metric values to be correctly calculated. This patch
        initially sets the MapUnit unit value to Map100thMM, which is what it
        was before commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1, which works
        for Impress. For Writer, the value is set to MapTwip.
        
        Change-Id: I49e9b80aa4d3fbda1f19101903d2a4459089024c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154665
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-07-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3da5cfb1c515674bf3b9647face1d965954117c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e091684b48a7aed1778e8c72bfd92eb31f43177
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(3)
            
            + refactoring
            + Writer Format menu (part 3)
            
            Change-Id: Ia192d378bc373be9e9e57de422fc1e6eccd02694
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154810
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b092b30dc2a49cb3ebc9a49ea270c34bd0b08819]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 187dca98f0b3cf280985d399a97c63bfa3f3d489
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(2)
            
            + refactoring
            + Writer Format menu (part 2)
            
            Change-Id: Ia98b63e2655cc2c5f1372f75d1e59b7c3c5a5c21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154809
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ec84398ead7469fd394251666e33b74c7cf8f9d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 63b4c1e42c58e5e0600397c86759d8979c9db76e
          - tdf#155875 Tab'd UI cmds Writer/Format in Help(1)
            
            + refactoring
            + Writer Format menu (part 1)
            
            Change-Id: I77096e6d4890e64f6a5e20a33ca518eaa10f302d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154807
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [441ef781301f0349512df6b4a9bfca3d50928ff9]

        update script to python3
        
        didn't find anything new
        
        Change-Id: Ibb918ce99b552c45ebfd49280bd3b9fc2ea7bc19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b4a7b6c4afad4eb07b456ca889e9166a03054f5]

        remove some unused #defines
        
        Change-Id: I2c8168cd804ae8d1e4effa61be1d9dc902ecf9b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-23  Jean-Pierre Ledure  <jp@ledure.be>  [d5e1e4103b2ee77140d4866c4b4f482cb0ee184f]

        ScriptForge (SF_FileSystem) Fix typos
        
        Typos in comment lines
        
        Change-Id: I5e92417af0c9fb1f6f4d240a5a7731c9efa5230d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154802
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-23  Rico Tzschichholz  <ricotz@ubuntu.com>  [caddaaa6afd2709f72dfb6160a485d405ac03966]

        Only pass -I... arguments to g-ir-scanner by using pkg-config's --cflags-only-I
        
        Otherwise it is possible that e.g. -Wl,--export-dynamic is passed which is fatal.
        
        Change-Id: I1735641e3149c86456e1164b67509a719e09d446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154340
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [65c91bd5aa6f9b68390739a0e027d23c8a32da08]

        tdf#147911 Implement set_item_help_id for context menu items
        
        This patch adds the method set_item_help_id for weld::Menu (similarly to what we already have for weld::Toolbar). This way, it is possible to define help IDs for each entry in context menus that are created during runtime.
        
        This is necessary to fix various bug tickets that request F1 to redirect to the corresponding help page when a context menu item has focus. This currently works for context menus created from XML files, but fails for context menus created during runtime.
        
        Besides implementing the new method, this patch fixes bug 147911 (see changes in file templatedlglocalview.cxx) to showcase how set_item_help_id can be used.
        
        NOTE: Pressing F1 in context menus only work with "gen" and "win"... unfortunately it does not work in kf5 and gtk3 due to a separate bug (see bug 156376).
        
        Change-Id: Ic9bb1bca3e646cb4d0b879d8672c5dcc9c19c4c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154699
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d28ba797dfb804e020e1cd8be5505f31b2adb74a]

        nDigitPos no longer appears in expression
        
        so presumably we no longer need this suppression since:
        
        commit d969715fa4df9de762c652a7af27601fa75fb275
        Date:   Wed Jul 19 22:29:35 2023 +0200
        
            Simplify a bit by removing a redundant condition
        
            line 627 already contains: if( nMaxDigit > nDigitPos )
        
        Change-Id: If6ff93f91f5bd20a9a03ed828d6f4e598ff4f3da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [4e8b4a34c49d700cfebd3baeb0f2430e879cc236]

        editeng: Don’t unintentionally set KernArray.mnSubUnitFactor
        
        The first (and only) argument to KernArray constructor is nSubUnitFactor
        not array length as the code here seems to imply.
        
        Change-Id: Ie89c41d07f1aa13be595ead604df82ad775df433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154799
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a7181c0b3898d32bae0deaf12ebcadd3de30a50e]

        cid#1538304 Big parameter passed by value
        
        and
        
        cid#1538309 Big parameter passed by value
        
        Change-Id: I6c3f86c3c57f561b71809d0193ab663d2f92a4b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154794
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [cb78012a9ba17e264605e10c49303d2bf5e1460d]

        cid#1539071 Division or modulo by zero
        
        Change-Id: Icc730f5097609a845e287e580881a8466b0b128d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154793
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f007378b74c1d316a510f4fe2491ec7724958c1c]

        cid#1539070 Dereference before null check
        
        Change-Id: I32bb7a7e6689b5b9cf9847726cc813ddb2404e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e355206fe882b01fff676ab572feed595a94ff8]

        cid#1538306 Uncaught exception
        
        and
        
        cid#1538308 Uncaught exception
        
        Change-Id: Ifd274b71e9fc1d744799451f460fdcb0ee1ca91d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d6f6bcec4dbfa30c199cb5f4db7bea88ebbeb85d]

        cid#1401342 Uncaught exception
        
        Change-Id: I139c5989d243f6f8fd1b37395f1071f7cb179f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154790
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6f3b76fb611a5f2c7f32296bc86316b6abb32cb]

        cid#1538889 Pointer to local outside scope
        
        Change-Id: I32c6336d33b6fa7caa2a3b7861220f12096ae53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154767
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [7e164e4dcdda66f4077872065a5d2412d5130bc3]

        ofz#49217 Out-of-memory
        
        just abandon in this case
        
        Change-Id: I2234f130e3c8de0b044256921f5d6941acc72e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154769
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [27ad68a95b513bfed5f837b66495cc210d044321]

        ofz#57493 Timeout
        
        Change-Id: Id8811e65227142881fc86f6d2db231fa053fc2d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [56edc523a4aa2a99ce15c66d42a8c7ba55bf1580]

        Fix typo
        
        Change-Id: I2a14c233aa09aec55b18dae2d4018a07c012ab52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154795
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1d0adde905fa5353fdb38f743dce9d50e8a53ef7]

        Fix typo
        
        Change-Id: Ia6252da165d734b752ea6cad96f8014556bb4bfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154796
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-23  Julien Nabet  <serval2412@yahoo.fr>  [22914d1eb8afa35827b33f2d8bdce9da7283e735]

        No need to create an identical obj if we return the same property values
        
        Change-Id: Ib932de42ffec6d71b31a25d53f46f18a26b0b2b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154762
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2023-07-23  Jim Raykowski  <raykowj@gmail.com>  [c6b404c39569b6bc972b821a13f6bba0a68d8d9d]

        tdf#156111 SwNavigator hyperlink dnd enhancement
        
        Enhancement to use the selected document text dropped on as the
        hyperlink name for hyperlinks created by drag-and-drop from the
        Navigator.
        
        Change-Id: I6c458b24574cae28ab390644b8a3e1982675c4c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154508
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [21013c4662a9ab32d293de263c54ebeceb66828c]

        tdf#156377: Improve cursor traversal in UI widgets
        
        Re-implement GetCaretPositions() on top of GetCharWidths() so it can
        benefit from our code that handles cursor insertion in middle of
        ligatures.
        
        Change-Id: I2b76b3b0125f2454f78cb6779d88617dc29386fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154660
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [620fdb3a93e07eb87884ce3de8e436d840dc79e1]

        vcl: Drop recently unused ITextLayout::GetCaretPositions()
        
        Change-Id: Ibabdeee029f19133afc5ff766cf1256a394362fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154649
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [60c8a8062cc4632b400e5498310d4ade84b8fe34]

        drawinglayer: Drop recently unused TextLayouterDevice::getCaretPositions()
        
        Change-Id: I07255d45bc03a5f86a22d7f392c14053eec7f6ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154648
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [d9ae579c8a2f5d305fd6419069ed00cf4d8bb015]

        editeng: Use GetTextArray() instead of GetCaretPositions()
        
        One way of getting text widths should be enough.
        
        Change-Id: I21e24c3f69a116e5210685d76268936219aae279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154639
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [11b513da7f850307cf8371f155e87e9c52f2dd87]

        vcl: Drop now unneeded DevicePoint typedef
        
        It has been always typedef'd to basegfx::B2DPoint since:
        
        commit 5e218b5c51f7d9cd10bd9db832879efca41b9c75
        Date:   Wed Jan 12 21:19:32 2022 +0000
        
            always use B2DPoint for DevicePoint
        
        Change-Id: I9f5202d5a71c77dd79f1759923917c26bf68a9af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154632
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [063d71f4d3a145a5e28b26c6e5d1a7ae5b5f8891]

        Drop --enable-float-device-pixel configure option
        
        This does nothing now, as we are now always using doubles for VCL glyph
        coordinates.
        
        Change-Id: I87e4e3057dbc54a2ecf0924d3d6a408cf519f842
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154631
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [ecf352701411fe178b51841b5714e27bef500206]

        vcl: Use GetTextArray() when drawing mnemonics
        
        Instead of using a different function to get the character width, use
        the same function used for getting the character widths elsewhere.
        
        Change-Id: I21428f34bb0f3a60fa17f5e8ecc3420545356337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154609
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [2ce3398d3863114a8f5333a86b76f2520eb7c7d8]

        vcl: Drop recently unused OutputDevice::LogicWidthToDeviceCoordinate()
        
        Change-Id: Iff87edfcfa46258236c24bd8f88b552fe9db8891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154608
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [ee2238aa68eac68f467704629d22b699f0a92a1b]

        vcl: Use double for width in OutputDevice::ImplDrawTextLine()
        
        Change-Id: Ia6bde62b20e87d7ce3c15b0e915a0c6ecc02c393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154607
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [9057641f678b8e36c9dbc41960b182c6ecfdda15]

        vcl: SalLayout::GetTextWidth() returns double
        
        Change-Id: I4c8cfec4160da260556615bc17939af6b20d60ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154596
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [f9e993a91c2c11a17948d394bf207f836e10d28b]

        vcl: Don’t use nSubPixelFactor when in map mode
        
        We are already using a subpixel factor when in map mode, so no need for
        one more.
        
        Change-Id: I704d52bf402f92f83a3d4ef40409d644921314d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154587
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [a21958db9111e27312c6ae52e2d5e3a9e8a39e08]

        vcl: Use doubles in GetTextBreak()
        
        Change-Id: I88ee2434ba6ddb41cf1983afceebe1ae72be8d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154584
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [9d9e3b439883c3c315501f56bb613e080863db64]

        tdf#156211: Don’t round Kashida width when doing subpixel positioning
        
        This improves our calculated positions for the inserted Kashida glyphs,
        which has the side effect of fixing this issue, and generally improves
        Kashida positions so that there is less rounding errors and visible gaps
        between them.
        
        Change-Id: If60126e77e59c2c1246298e2993609547d38c79c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154550
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [4b743de97fc133623e46827869c4ea3eb845ad47]

        tdf#156234: Don’t round glyph coordinates when doing subpixel positioning
        
        When doing subpixel positioning (i.e. OutputDevice is in map mode),
        delay the rounding of the glyph coordinates after converting from pixel
        to logical units to minimize the loss of precision as much as possible.
        
        Some test expectations, expectedly, changes due to the improved
        positioning precision.
        
        Change-Id: I2591e3c7d4923ba7886a35bf53db759273354e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154292
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [ea0f9776ed8e7e9809853d292923b86756274564]

        Improve CppunitTest_sw_globalfilter CPPUNIT_TEST_NAME=testListLabelPDFExport
        
        Extract the textual content of the page using high level PDFiumDocument
        API instead of fiddling with low level PDF text stream details.
        
        Change-Id: If989addb3200e728e8ed771bfcc23cc18c7664de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154579
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [dd4a3fe191aab884380784250144c9fdd9647be3]

        vcl: TextRenderModeForResolutionIndependentLayout → SubpixelPositioning
        
        Change-Id: I8698d0f74889ac8a7de64a97e8cf0e8878ef7fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154517
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [c46f8c356d812230c3a43cd08fb79674be88d9a8]

        vcl: Simplify AquaGraphics*::drawTextLayout() calling
        
        Take TextRenderModeForResolutionIndependentLayout() from the SalLayout
        argument instead of passing it separately.
        
        Change-Id: I155ea645e401618ad884fdc36c4c1aeab69980ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154516
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [172b500ccbc8dac0496cc2936a9bcca793c0b594]

        vcl: Use more doubles for text measurements
        
        Change-Id: I5695d9ab51eb09929b4c290ceaf7ae2be46f5989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154504
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [507a8745870e9a755be3a72f59c6e9a9d811fdcf]

        vcl: Use doubles for glyph item coordinates
        
        Change how glyph coordinates are represented inside VCL to use floating
        point instead of integers. Should make no functional difference because
        we are still rounding them.
        
        Change-Id: I5480ee3dec3afab50194954095fd6829ebaa4a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154499
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [8e9b65c874d99e3302a9e7dfd0c7a30963526bc2]

        vcl: rename NaturalDXArray to DXArray
        
        The unnatural DXArray is gone for a while now.
        
        Change-Id: I6cda530f332839e49aa91da2d5e347401c4d159d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154502
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [2a19b5fb9af4b0d6c8903ce64ce67ccb536276e1]

        vcl: Set font size to UPEM in some tests
        
        Reduces the chance of rounding differences.
        
        Change-Id: I4ad3e00a41c2dba01fe113ba1261dcf12f0b19f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154381
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [dfe42e756b37642355356a6035081f4473609832]

        vcl: Use HarfBuzz to get glyph bounding rectangle
        
        For consistent cross-platform results that also matches our glyph
        advances since platform functions might be using hints which we don’t
        use.
        
        Change-Id: I4aebd3e7c5f460dff584f5eba74f7a11bab0f9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154388
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [32144b5dc617d5a375eeadf25b5b62befb529785]

        Make CppunitTest_vcl_pdfexport CPPUNIT_TEST_NAME=testTdf108963 less sensitive
        
        The test does not need all that precision, without the bug fix for
        tdf#108963 it fails with:
        
        double equality assertion failed
        - Expected: 245
        - Actual  : 255.401992797852
        - Delta   : 0.999
        
        Change-Id: Iae20417465e7c43f5be2819f710f768645dc3253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154522
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-23  Khaled Hosny  <khaled@libreoffice.org>  [7774e0bb716d6f60e32f259d49d2e07e5b0de792]

        Make CppunitTest_svgio CPPUNIT_TEST_NAME=testCssClassRedefinition more robust
        
        The commit:
        
        commit 9e83d35c4a22bcb465f0736dda9b752b29f83959
        Date:   Thu Jun 23 21:52:52 2022 +0200
        
            Make CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust
        
        Changed the font from generic Sans to Open Symbol to avoid failure when a
        different font is used, but it didn’t change the text string to a one
        supported by Open Symbol, so font fallback would still make the test
        fail. Change the text string to “012” which is supported by Open Symbol.
        
        Change-Id: I6e6ba22614ef1bafe5aece05c42d57d71923380c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154492
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d89dc4ac09d3c2bd55174f09485173057cc1403b]

        tdf#156137 - A11Y - Fix Long object names need to proper handling
        
        Add text wrap option (long names ends with '...') for in case of proper
        handling of long GOTO GtkLinkButton objects in case of accessibility sidebar.
        
        Change-Id: I3c4af522fc34289ca57b1a7878134c34353bbc47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154726
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [81f4f1ea1d13dcdf8ea693a48ce2d753729d87aa]

        simplify some calls to XmlWriter::attribute
        
        Change-Id: Ibc3aa732dec2f6c26750ba056f5f8d71ae34b63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [2006d7455f529d3d6f44d09a83be9a80e73b1d34]

        no need to create OString temporaries when calling XmlWriter methods
        
        Change-Id: Ief1101c55a0635dac43a7c4d66dd4ed0d5be70bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154764
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-22  jucasaca  <jucasaca@gmail.com>  [f8a312617838e8626e6e406791ad8d0aac368f23]

        fixing a typo in sqlbison.y
        
        schema_glement_list is not registered, son can't be used. schema_element_list is registered and defined and seems to be the correct
        
        Change-Id: I7661532707ce6ddb32b95629192e9ba9847f21df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154766
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Lionel Mamane <lionel@mamane.lu>

2023-07-22  Jean-Pierre Ledure  <jp@ledure.be>  [c216a5fc499dd3cd4324c30aa69df415ecf22113]

        ScriptForge (SF_FileSystem) IncludeSubfolders argument
        
        In the FileSystem service, the
           - SubFolders()
           - Files()
        methods receive an optional argument
           IncludeSubfolders (Boolean).
        
        That argument determines whether or not only
        the given FolderName is explored or also its subfolders
        up to the bottom of the folders structure.
        
        The argument must be used with caution as the number
        of returned folders or files may increase rapidly.
        anThis could consume excessive process time.
        
        This patch will require an update of the
        help page about the filesystem service.
        
        The new argument is available both for Basic and Python
        user scripts.
        
        Change-Id: Id2a96cd63cb51f8681f20a203a711b47a636fc3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154763
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [60d7b73d6d92eeb331cfe48734094330546477db]

        avoid some unnecessary string copies in tools::XmlWriter
        
        Change-Id: I5844a878f3e1d85956eae828e9093b2fd1f5a275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-22  Julien Nabet  <serval2412@yahoo.fr>  [9b887f63147914793f881c0cf4a730a46d6f688c]

        tdf#146584: FB Setting default with ALTER TABLE works but gives useless message
        
        ALTER is a DDL (DATA DEFINITION LANGAGE) instruction, no count row is expected.
        
        Change-Id: I3d5bfe240b85c5b79392c92fdd870bc045e1eb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154755
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-07-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [78fdaa670d80c880bbf07201619dc660fbf0f682]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 141b19cf577d2c6b3fb7b3c29dc67977352895c5
          - tdf#155875 Tab'd UI cmds Writer/Insert in Help(17)
            
            + refactoring
            + Writer Insert menu (part 17)
            
            Change-Id: Ia7764ad9125f14d288470b53275e626581b2534e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154759
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d9a984581319c3aacdd4852f0a4f76ddf1396262]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f7c011c3ea533d8283b17dff0d191deb7235645
          - tdf#155875 Tab'd UI cmds Writer/Insert in Help(16)
            
            + refactoring
            + Writer Insert menu (part 16)
            
            Change-Id: Ia062ae356f3814514c2b9009bf5d50a040551e19
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154758
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4863f4fcbb48bd937283422c5d5b0c77d70db04a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac354a87fb9f5d47d61b4532466ed5954680b5da
          - tdf#155875 Tab'd UI cmds Writer/Insert in Help(15)
            
            + refactoring
            + Writer Insert menu (part 15)
            
            Change-Id: Ic1af863bf61796af846f79e38cc793337eb8c91d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154756
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-22  Julien Nabet  <serval2412@yahoo.fr>  [072ecc03c496dcf33a14f7f0ef6aab9b5766cdd0]

        Simplify a bit construction of AccessibleEventObject object
        
        Change-Id: I0012de655d2ea24c822cf10828e7a31fa2e535ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154754
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-07-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [42115cdc1d51158c49bc9fe20cce015db440710f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to acfa489281ad217a46cdfe5558a2bcdcd963d347
          - tdf#155875 Tab'd UI cmds Writer/Insert in Help(14)
            
            + refactoring
            + Writer Insert menu (part 14)
            
            Change-Id: I3e22d333174bde886ffb633568b3effc5a1cdf04
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154751
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0df982ac881d80db7caf06ce9402691a4a0ad7fd]

        merge SetOptions_Nbc and SetOptions
        
        since the Nbc variant is no longer necessary
        
        Change-Id: I4a846dcdbe68116dd511e45f018af2cdc5fbcf48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d9e304d1748668cc25905945129095bd14fd1af]

        SfxItemSetHint is dead
        
        since
            commit 519876dffdc8c93710af543cc11332dab9a50c14
            Author: Mike Kaganski <mike.kaganski@collabora.com>
            Date:   Tue Jul 18 23:45:47 2023 +0300
            Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs
        
        Change-Id: I8d306bf6792630cfdaa0a0ac8b77730e1e1f0070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-22  László Németh  <nemeth@numbertext.org>  [818f8f13128ba78769b4f542ed1efef658de38d9]

        tdf#149498 sw: fix Undo crash at bookmark over cells
        
        Importing DOCX files with bookmarks between w:p paragraph
        elements resulted bookmark ranges over cell boundaries
        within text tables, causing crash with Undo.
        
        Partial revert of commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        to avoid bookmark ranges over cell boundaries, creating
        only collapsed bookmarks here, as before.
        
        Regression from commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving".
        
        Note: to avoid of another assertion, skip testing with
        debug builds.
        
        Change-Id: I3ed6daa55323f20130fcee6cc24d00a480731d0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154743
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-22  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [ade2565cc2b2e5e8cf35fe828bf85649f7ff593a]

        tdf#117307 sc: Comments are duplicated after Row delete and Undo
        
        The comment was cloned if you deleted and restored its filtered cell.
        During Undo, the comment was cloned even if it was for the
        same cell, resulting duplicated comments there.
        
        Regression from commit eefe13c77d01be37c911e75af191717a944fedb3
        "shrinking the DB area just causes problems, tdf#89546".
        
        Change-Id: I86d0813c56ba63370aae6b5f7807a19747e2378c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153803
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [399065b7c5af05717321f00b8fec8db5a569023a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04f63a94b233bd31339146384fb0f3815dead3d1
          - tdf#155875 Tab'd UI commands Writer/Insert in Help (13)
            
            + refactoring
            + Writer Insert menu (part 13)
            
            Change-Id: I8d61e15676fa4a5b7197d246e13f43259e2a15f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154747
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [0e3d0612a0942b3627a8dca61a072fc04f59d161]

        a11y: Don't look for grandparent when asked for parent
        
        `AccessibleListBoxEntry::implGetParentAccessible` was first
        retrieving the parent, and then that one's parent, which
        was failing (and thus returning an empty reference) e.g.
        for the 2nd level items (like "2nd Reminder") in Writer's
        AutoText Dialog (Ctrl+F3).
        
        This resulted in Orca not announcing any such item when
        focused with the qt6 VCL plugin in use, because Orca
        considers the object a zombie due to it reporting
        an index of -1 in the parent.
        
        Since the parent is requested, drop one level of
        finding the parent (don't look for the grandparent).
        
        Also convert an `OSL_ENSURE` to a real assert so
        this triggers if there are still any remaining
        issues that need to be addressed.
        
        This makes Orca announce the item just fine and the
        hierarchy now looks good in Accerciser, too.
        (Orca announces the item's text twice for qt6 now
        instead of not at all, which matches the behaviour
        with gtk3 that's using native Gtk widgets.)
        
        With the "2nd Reminder" item selected in Accerciser's
        treeview of the LO a11y hierarchy:
        
        Before:
        
            In [7]: acc.get_index_in_parent()
            Out[7]: -1
            In [8]: acc.parent
            In [9]: acc.parent == None
            Out[9]: True
        
        With the fix in place:
        
            In [11]: acc.get_index_in_parent()
            Out[11]: 1
            In [12]: acc.parent
            Out[12]: <Atspi.Accessible object at 0x7f14fa3e2340 (AtspiAccessible at 0x3c09da0)>
            In [13]: acc.parent.name
            Out[13]: 'Standard'
        
        Change-Id: I2994211368508c74093b73eb8c330aa293411e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154746
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [ef9bfcdbc67667f217ea01886ee728f8d1cbeb19]

        a11y: Drop obsolete check for empty Reference
        
        The default Reference ctor always creates an
        empty Reference, so checking for that here doesn't
        make any more sense here since
        
            commit 77ea0535271d3fb3d49c8d916ecf80e0a7f70653
            Date:   Wed Sep 18 15:54:23 2019 +0200
        
                accessibility: fix leak of AccessibleListBoxEntry
        
        (`git -w shows it's only the check that was dropped besides
        adapting indendation accordingly.)
        
        Change-Id: I18cda45f8730b0234eed0edf31fc6e0a32b1cb9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154745
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b735eba5a80984ca6c291e4265fae5551b11e64e]

        loplugin:unusedmethods
        
        Change-Id: Id2bbe63ca8d4255fd883798581ac7fa1fda7dba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc79cd60e98804bbb0f23234f45fa214040970ae]

        remove unused SvtPathOptions methods
        
        ever since
        
            commit 519876dffdc8c93710af543cc11332dab9a50c14
            Author: Mike Kaganski <mike.kaganski@collabora.com>
            Date:   Tue Jul 18 23:45:47 2023 +0300
            Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs
        
        Change-Id: I988177fd82f7cd17f38123addb78978b847f8d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a66b9c9adfb2306a021cd286c8346dd1058499ce]

        loplugin:unusedfields
        
        Change-Id: Ic2e9de67a00bb9ca8ab4d0f7528b22c58d0cc360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [70d78fdac115a98b64c8e3333519c0a80573ee4a]

        mStructIdMap is unused
        
        ever since
        
            commit 07d790ca473cd6e71f0343419b819fa6b485dc01
            Author: Michael Stahl <michael.stahl@allotropia.de>
            Date:   Wed Jul 12 15:26:25 2023 +0200
            tdf#154982 vcl: PDF Export: split BeginStructureElement
        
        Change-Id: I4708fde93fe9a10e67fefc7e87fa9f3f49075375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0a8cc9e2f4f09144857f9f0f0f88dd23d07982f9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc37d66fb5384cd6cd4460cfacbe874b7e0911e6
          - adjustment in describing backup failure to indicate attempt
            
            Change-Id: I32571513a1958071d8c02b6f0d9bf2fc5807a2f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154629
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-07-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [3dc2f4f0d2a8a7c51d01d29fd55ca9e4e6926596]

        related tdf#152992: fix minor logic error in hittestprocessor2d
        
        Fix logic errors I've missed previously on
        (2c8c436c4a8546276e285dd18f3f7ded091a2c4e) where initialization of
        aDiscreteHalfLineVector wasn't adapted to new HitTolerancePerAxis in
        PRIMITIVE2D_ID_POLYGONSTROKEPRIMITIVE2D & PRIMITIVE2D_ID_POLYGONWAVEPRIMITIVE2D.
        
        Change-Id: I5d9f0347e489301d7e4f06f98f4a9c9d1385d6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154717
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-07-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [2acfc1448facebd254bda18b2bf286a29be636a7]

        related tdf#152992: rename HitTolerance to HitTolerancePerAxis
        
        Rename ...HitTolerance instances to ...HitTolerancePerAxis as
        suggested by Noel on:
        https://gerrit.libreoffice.org/c/core/+/154694/2/include/drawinglayer/processor2d/hittestprocessor2d.hxx#45
        
        Change-Id: I9c5b69218a4809f795c9a6324d76b2e2c1b12343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154716
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-07-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [396cbd8cd017f883946f1a0be7285c89f84f40af]

        Related: tdf#155708 Clean-up - Fix validity dialog closes
        
        Do not close Validation window if click on another Calc sheet.
        
        Follow-up of commits:
        1 - a5c61b143d53bb10430b8a486874856c16a2d86c
        2 - efaa065eb7053954242c83760f897e7dba2e9fe8
        
        Change-Id: I5352ee869f3e8a93b49abec863089f57cdf0aeba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154369
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [3f6ad9d3cdd6fe97989d85b7ec31fe9b8ae340cd]

        tdf#155000 - A11Y - Add warning message if content control in header/footer
        
        Add warning message if content controls are in the header or footer.
        
        Change-Id: Ie2a0a8aa1bfaf629f8e17828f2f99e590ea4e3af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154715
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [bcd3ae98a1292a02b8a2c56e114c6016a9a7df51]

        tdf#99609 a11y Set old/new value correctly in a11y event again
        
        ... after
        
            commit 7835f97113460922cfe14685baa7bcaea2de736a
            Date:   Tue Jul 18 16:28:08 2023 +0200
        
                add IndexHint -1 for 2 commitEvent methods in accessibility
        
        had switched from using the default AccessibleEventObject ctor
        and setting all of the members manually, but
        presumably unintentionally swapped old and new value along
        the way, since the ctor takes the new value as 3rd and the
        old value as 4th argument.
        
        I ran into this because because announcement of the items
        in the Expert Configuration dialog with Orca and the qt6 VCL plugin
        dialog no longer worked after merging
        
            commit 452c17e08fd8f18d032788170d873b019c8e9716
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jul 21 08:27:09 2023 +0200
        
                tdf#99609 a11y: Announce the correct entry in tab list box
        
        , while it did still work with the tdf#99609 commit series
        on top of master just a few days old.
        
        Change-Id: I516a3067ca04b2e4a06011148ac2690bd301fefa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154719
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-07-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [aba88061e5091e932418b5b03c7d189a28a8256d]

        tdf#156140 - A11y fix warnings when using default heading/title styles
        
        No warnings when we use default paragraph styles.
        
        Change-Id: Idbbd542a33c23ff38f691098bf0ceba610efad84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154673
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [645197d81fec7328b1ddef9d2996a2b068451b61]

        tdf#99609 a11y: Fix reporting selection in tab list table more
        
        Besides the issue already fixed in
        Change-Id I394027695616b17f7290136d8ee10c06a0282e80
        ("tdf#99609 a11y: Fix reporting selection in tab list table"),
        the previous use of `GetEntry` here in
        `AccessibleTabListBoxTable` is problematic, as described
        for the previous uses in `SvTabListBox` and replaced in
        Change-Id I35f7280d2c386a9a8e04e636ebf34850a733c84a
        ("tdf#99609 a11y: Announce the correct entry in tab list box")
        and follow-up commits.
        
        Therefore, replace that here as well. Instead of
        having to use `SvTabListBox::GetEntryOnPos`, just
        use the existing `SvTabListBox` methods that already
        take a row index (and use `SvTabListBox::GetEntryOnPos`
        internally).
        
        This fixes querying the selected status of children (=cells)
        via the Selection interface.
        
        Sample use in Accerciser before, with the
        tree view in the Expert Configuration dialog
        selected in Accerciser's treeview of the a11y hierachy,
        and entry "org.openoffice.Interaction" selected in the
        dialog.
        
        Before:
        
            In [6]: sel = acc.querySelection()
            In [7]: sel.getSelectedChild(0).getIndexInParent()
            Out[7]: 56
            In [8]: sel.isChildSelected(56)
            Out[8]: False
            In [9]: sel.selectChild(56)
            Out[9]: True
            In [10]: sel.getSelectedChild(0).getIndexInParent()
            Out[10]: 112
        
        With the fix in place:
        
            In [11]: sel = acc.querySelection()
            In [12]: sel.getSelectedChild(0).getIndexInParent()
            Out[12]: 56
            In [13]: sel.isChildSelected(56)
            Out[13]: True
            In [14]: sel.selectChild(56)
            Out[14]: True
            In [15]: sel.getSelectedChild(0).getIndexInParent()
            Out[15]: 56
            In [16]: sel.selectChild(114)
            Out[16]: True
            In [17]: sel.getSelectedChild(0).getIndexInParent()
            Out[17]: 112
        
        (112 instead of 114 for the index of the first selected
        child is OK because selecting a cell selects the whole
        row and child with index 112 is the first cell in the same
        row as the child with index 114.)
        
        Change-Id: I28cd1633dae601818e2a1d310859bd4d55d311ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154714
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [5f7ae99211594919408dd20cd1215393b3c4b76b]

        tdf#99609 a11y: Implement retrieving selected rows in tab list box
        
        With this in place, the index of the selected row
        in the Expert Configuration dialog can e.g. be seen
        in Accerciser using this in its Python console with
        the table object selected in the tree view of the a11y objects:
        
            In [1]: table = acc.queryTable()
            In [2]: table.getSelectedRows()
            Out[2]: [12]
        
        Change-Id: I2f07e73552ef12989acab461b33c3e41d9195490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154713
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [ab72f6a4a4ceee41842c8a87b23086bce692b1e3]

        tdf#99609 a11y: Use GetEntryOnPos in more places in tab list box
        
        As described in more detail for the case in
        Change-Id I35f7280d2c386a9a8e04e636ebf34850a733c84a
        ("tdf#99609 a11y: Announce the correct entry in tab list box"),
        `GetEntryOnPos` is the method that returns the correct entry
        when passing the row index (when there are also non-visible
        dummy entries) and that commit also mentioned:
        
        > There are more uses of `GetEntry` that will be
        > looked at separately.
        
        These two uses in `SvHeaderTabListBox::GetCurrRow` and
        `SvHeaderTabListBox::IsCellCheckBox` are also using a row
        index, so it looks to me like they should also be using
        `GetEntryOnPos`.
        
        Change-Id: I1170063d760c020ad543fb458cac99a10e37c9a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154710
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [10129ea98f808c19990abe08aba2e62ed10ebf81]

        tdf#99609 a11y: Fix bound rect reporting for tab list box
        
        As described in more detail for the case in
        Change-Id I35f7280d2c386a9a8e04e636ebf34850a733c84a
        ("tdf#99609 a11y: Announce the correct entry in tab list box"),
        this also needs to use `SvTabListBox::GetEntryOnPos` for the
        correct entry to be used.
        
        With this in place, Accerciser now highlights the correct entry
        when clicking on the corresponding object in its treeview of
        LO's a11y hierarchy.
        
        Change-Id: I850247cd384a6a9bb909f51b39c4743548ec1105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154689
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [44de8e68c40be6c4bddeadd627d58251639487e2]

        tdf#99609 a11y: Fix reporting selection in tab list table
        
        The previous calculation of row and column index
        in `AccessibleTabListBoxTable::getSelectedAccessibleChild`
        based on the selection index was wrong, so fix that.
        
        Only increase the the loop variable `nRow` in
        `AccessibleTabListBoxTable::implGetSelRow` at the end
        of the loop, since the comparison still needs to use
        the original value. (Index starts at 0. Trying to retrieve
        the first selected child at index 0 would otherwise
        fail, and always return the fallback value of row index 0,
        making NVDA always announce the first row as selected instead
        of the actually selected one.
        
        The issue could also be observed with Accerciser and the qt6
        VCL plugin. With the "org.openoffice.LDAP" row selected
        in the dialog, and the table object selected in Accerciser's
        treeview of the a11y hierarchy, the cells in the first
        row ("org.openoffice.VCL") would always be returned when
        querying the selection using the AT-SPI Selection interface:
        
            In [1]: sel = acc.querySelection()
            In [2]: sel.nSelectedChildren
            Out[2]: 4
            In [3]: sel.getSelectedChild(0).name
            Out[3]: 'org.openoffice.VCL'
        
        This works as expected now with this fix in place:
        
            In [4]: sel = acc.querySelection()
            In [5]: sel.nSelectedChildren
            Out[5]: 4
            In [6]: sel.getSelectedChild(0).name
            Out[6]: 'org.openoffice.LDAP'
        
        With this fix in place, NVDA now properly announces the
        currently focused row in the Expert Configuration
        dialog (i.e. both, the focused cell first, and then
        the whole row as selection).
        
        Change-Id: I394027695616b17f7290136d8ee10c06a0282e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154688
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [452c17e08fd8f18d032788170d873b019c8e9716]

        tdf#99609 a11y: Announce the correct entry in tab list box
        
        The tree view in in the Expert Configuration dialog
        has a lot of "<dummy>" entries to implement creating
        entries on demand when expanding an entry (see
        `SalInstanceTreeView`). While these
        are not visible in the user interface, these
        have the effect that calling
        `SvTreeListBox::GetEntry` with the row index does
        not actually return the correct entry, but an entry
        further down in the tree view if there are non-expanded
        nodes (as is the case e.g. right after opening
        the Expert Configuration dialog, without having
        done any search).
        
        Use `SvTabListBox::GetEntryOnPos` that does exactly
        what is needed and returns the correct entry.
        
        With this in place, Orca with the qt6 VCL plugin
        now correctly announces the focused entry in the
        Expert Configuration dialog.
        NVDA on Windows now also announces the focused
        entry correctly at first. It then still always incorrectly
        announces the first row as selected, but that's another
        issue that will be addressed separately.
        
        This fixes the remaining issue about the selected/focused
        states not being reported correctly mentioned in
        Change-Id I6b532bfd6c3f437e44b3d67da8a5cc5f77b562d2
        ("tdf#99609 a11y: Handle focused state for cells in tab list box"):
        
        > This at least makes the focused state being reported
        > properly for the first item ("org.openoffice.VCL")
        > in the Expoert Configuration dialog, but others still happen to not
        > have the focused state set properly when moving there with the arrow
        > down key, so there seems to be another issue somewhere.
        
        There are more uses of `GetEntry` that will be
        looked at separately.
        
        (Whether the dummy entries in the tree view should be exposed
        as cells of the table on the accessibility layer, as it is now,
        is another question, but leave it like that for now.
        With gtk3, which uses native Gtk widgets instead,
        the dummy entries are not exposed, which seems
        reasonable.)
        
        Change-Id: I35f7280d2c386a9a8e04e636ebf34850a733c84a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154687
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [1c0f0ab9b5bf23997640f44b7edd45c693c3f74d]

        tdf#99609 a11y: Handle focused state for cells in tab list box
        
        Report the focusable state for cells in the tab list box,
        and the focused state when the row is selected and child
        focus is on the table or a child.
        
        Not properly reporting the focused state would e.g. prevent Orca from
        announcing the newly focused row in the Expert Configuration dialog
        when using the qt6 VCL plugin.
        (It already worked fine with gtk3 because that one is using
        native Gtk widgets.)
        
        This at least makes the focused state being reported
        properly for the first item ("org.openoffice.VCL")
        in the Expoert Configuration dialog, but others still happen to not
        have the focused state set properly when moving there with the arrow
        down key, so there seems to be another issue somewhere.
        
        pyatspi script that prints state change events:
        
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if e.host_application.name != 'soffice' and e.host_application.name != 'soffice.bin':
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, 'object:state-changed')
            pyatspi.Registry.start()
        
        Sample output when moving between entries in the table
        (only "org.openoffice.VCL") has focused state set.
        
            object:state-changed:focused(1, 0, [table | ])
                    source: [table | ]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(1, 0, [table | ])
                    source: [table | ]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(0, 0, [table cell | org.openoffice.Inet])
                    source: [table cell | org.openoffice.Inet]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(1, 0, [table cell | org.openoffice.VCL])
                    source: [table cell | org.openoffice.VCL]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(0, 0, [table cell | org.openoffice.Inet])
                    source: [table cell | org.openoffice.Inet]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(0, 0, [table cell | org.openoffice.LDAP])
                    source: [table cell | org.openoffice.LDAP]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
            object:state-changed:focused(0, 0, [table cell | org.openoffice.Setup])
                    source: [table cell | org.openoffice.Setup]
                    host_application: [application | soffice.bin]
                    sender: [application | soffice.bin]
        
        Change-Id: I6b532bfd6c3f437e44b3d67da8a5cc5f77b562d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [29ab560c21b80e9e5886a8f507300d61047d0ee7]

        tdf#99609 a11y: Set proper parent for cells in tab list box
        
        The a11y tree was broken: While the table has the cells
        as children, the cells did not have the table set as parent,
        but the table's header.
        
        Since the IAccessibleTableCell implementation in
        winaccessibility relies on the table being set as
        the parent, this wouldn't work when moving around
        within the tree view in the Expert Configuration dialog.
        
        Fix this by setting the table as parent.
        
        The issue could also be observed with the qt6 VCL
        plugin on Linux and Accerciser.
        
        With the table selected in Accerciser's tree view
        of the a11y hierarchy, the incorrect hierarchy could be
        seen using this in Accerciser's IPython console.
        
            In [8]: acc.childCount
            Out[8]: 48
            In [9]: acc.get_child_at_index(4).name
            Out[9]: 'Migration'
            In [10]: acc.get_child_at_index(4).parent == acc
            Out[10]: False
            In [11]: acc.get_child_at_index(4).parent.childCount
            Out[11]: 4
        
        With the fix in place, the table's child's parent is
        now the table again as expected:
        
            In [13]: acc.childCount
            Out[13]: 48
            In [14]: acc.get_child_at_index(4).name
            Out[14]: 'Migration'
            In [15]: acc.get_child_at_index(4).parent == acc
            Out[15]: True
            In [16]: acc.get_child_at_index(4).parent.childCount
            Out[16]: 48
        
        NVDA on Windows now announces *something* when moving
        between rows in the Expert Configuration dialog, but
        it's not the correct row yet.
        (That looks like another issue in winaccessibility code
        that needs to be fixed separately.)
        
        Change-Id: I400fa9811bb297ea7fd1accb0970811cdf11a119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154670
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-21  Michael Stahl  <michael.stahl@allotropia.de>  [2582d2407c9b01a80aaa9ff1850eba576ed56eda]

        tdf#154955 svx: PDF/UA export: tag SdrObjGroup properly
        
          ISO 14289-1:2014, 7.3 Graphics
          Graphics that possess semantic value only in combination with other
          graphics shall be tagged with a single Figure tag for each group.
        
        Also produce the missing alt-text.
        
        Change-Id: I78e802d8e17a29c2d19fcf3a7ec9961f8f04e391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154684
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [83f7c6fe5bb233fa9827ff968710822b95562075]

        tdf#50725: sd: add new configuration option DragThresholdPixels
        
        Adds new expert configuration option DragThresholdPixels for
        Impress and Draw under Misc/DragThresholdPixels.
        
        Also bumps up the previous hardcoded default
        value from 2 to 6.
        Assuming this value was set when 640x480 resolution was the
        most common resolution, currently scaling the hardcoded
        default by 3 makes sense.
        
        (eg. GTK uses 8 pixels as the default)
        
        Change-Id: I35c0eed3ce477685c759f517471ce0bdc8315864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154379
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3a23c6c7a38317794cc7e8894e6a82f4418c8c6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c52b29e3858fd600a651635d4d4172a4a5d04d9
          - tdf#155148 - Reflect the fact that CDbl/Csng is locale dependent
            
            Change-Id: I67374217490e3016c20065bf39118de8106549a5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154695
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [87365fccc636812983cc8df17288e76cf6a0b667]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0a11014c12d12432e66be19775a44761a8282599
          - tdf#149888 Create HID target for Math's main help page
            
            This patch creates the target STARMATH_HID_SMA_MAIN_HELP for the main help page of the Math module, which is necessary for a related patch that redirects F1 in the initial window state for the main help page.
            
            Change-Id: Ic0a12fc036769355c708e326abd41e607ed06ff0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154692
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [7d93c79aaf1cf8b6f55c3e61bb0254eef8b8c260]

        Sync ScriptForge pt.po translation
        
        Change-Id: I67075b3ae5e57b8924e12770d835a83513147da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154536
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [7aebfcce5987655ef52e724befa0dc7b1012a253]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e639a07cb41318324867952f5ef0d81dbda54236
          - tdf#151695 Improve documentation on setting PYTHONPATH
            
            Change-Id: I7bfb2feea3d76bde6c762073df680d4023c481e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154610
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f2ff4a0a31c7919bc6d4e0ac63024252f0bd889]

        loplugin:redundantcast small improvement
        
        Change-Id: I2c96b367138b94d6178a3c4a0f83049f13a04f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154679
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7aca5ee1192b45d05a601946a5c784b8c5bd61bd]

        Assume that all modern X servers have a unified display area
        
        Change-Id: I704e6147085b2eca7fc6fd93261aced3e04b2fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154667
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c00a5bce384c5fa3b46cf5bb29c7e9b1e506ea0]

        Assume that, if we have X11, it supports Xinerama
        
        By now, Xinerama is old enough that we can use the X11 server supports
        it
        
        Change-Id: Ida95902916697808c611a53274b1f0299fd298b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154666
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f3a82f04dd1e16a3c317fd73ad7dc076e73cf4da]

        Fix typo
        
        Change-Id: I37e5692fc75089fc889116f86fcb0846be1ba1b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154563
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [142082d216cf48bc905c2468809bcc074fe2c638]

        Fix typo
        
        Change-Id: Ied624a73804f99a63b71f9088d6179ad2d93cef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154564
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [777d85be2e202a72eb5b4edeac8a1dabae09328a]

        Removed executable bits on xml file
        
        Change-Id: I594bcf47eedcb2ee6964ea48f3a4bdffdb0734c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154682
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [55f22949a96a5b05d661dc8619e170190e1a9345]

        Fix typo
        
        Change-Id: I56dedfc5eb14df5578f0a14a7a47f73d09c23884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154686
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-21  Stephan Bergmann  <sbergman@redhat.com>  [014336cc67710dd84a8e4caf3372773826be056f]

        Remove officecfg/util/sanity.xsl check of no value
        
        .xcs <desc> is merely glorified comment syntax by now, and the check had caused
        unnecessary grief in 3c41b32562d5ccdd306000484c5b16245b2b4a4f "tdf#156308:
        Restore use of /org.openoffice.Office.Recovery/AutoSave"
        
        Change-Id: I1c44836e497e4066766033ffac9b9c39a8f007be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154672
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a5ea9d89e623ffae905393dacbd73683a07d5d76]

        tdf#155374 Icons for PageNumberWizard
        
        Change-Id: Iedea46b31a36c7d1d2a3ab539c3ada0b029293c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154675
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-07-21  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [2c8c436c4a8546276e285dd18f3f7ded091a2c4e]

        tdf#152992: for Impress/Draw add horizontal hit tolerance for quick text edit
        
        Implements horizontal hit tolerance for quick text edit in Impress & Draw
        making it more forgiving. Previously it was required to click exactly on
        the glyph to get a direct text cursor.
        
        Refactors hittestprocessor2d so that it now supports pseudo per axis hit
        tolerance.
        i.e. underlying isInEpsilonRange hit check is still the same utilizing
        the larger tolerance of the two per axis tolerance, but the preliminary
        check that uses aPolygonRange.grow() and later aPolygonRange.isInside()
        now filters hit misses out with respect to the per axis hit tolerance.
        
        Utilizes hittestprocessor2d's new per axis tolerance to introduce hit
        tolerance for quick text edit, making it similar to TextEdit mode hit
        tolerance which only has horizontal tolerance.
        
        Fixes wrong use of BoundRect hit to determine text frame border hits.
        Which previously only made sense for TextFrame borders, and was mostly
        useless for shapes with text inside.
        
        Change-Id: I749e63752da05b01270bfcab2632c41879a848ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154640
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [3d4f9e3818cde6efcf88a8bfa39eb42c0fa949f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8dcfe198356b4be518c2de4beb2c2fa92716fed7
          - tdf#155884 Fix "Navigate By" target in help
            
            Change-Id: Iba81e9b7186ba0803043068694e35f909d833c86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154625
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-21  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [3f96f9cdd542bcc05cdd531da3c35bc6f0c2986b]

        tdf#139306 Incorrect nDecPlaces value after clamping
        
        nDecPlaces clamping diap changed from +-20 to +-309 and buffer is resized for new value
        
        Change-Id: Icb2130891598cf02623bbf5bd0273edab529d124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153815
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-07-20  Patrick Luby  <plubius@neooffice.org>  [3c63cb1298fc17b71629e04d181244b5acdf8409]

        tdf#156361 use slow blending path if alpha mask blending is diabled
        
        SkiaSalGraphicsImpl::blendBitmap() fails unexpectedly in the following
        cases so return false and use the non-Skia alpha mask blending code:
        - Unexpected white areas when running a slideshow or printing:
            https://bugs.documentfoundation.org/attachment.cgi?id=188447
        - Unexpected scaling of bitmap and/or alpha mask when exporting to PDF:
            https://bugs.documentfoundation.org/attachment.cgi?id=188498
        
        Change-Id: I13ae613f24bff4cd018110a08ed70559a1714687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154678
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-20  Jim Raykowski  <raykowj@gmail.com>  [de586d8bb1ee72f25729b86cac61e7ddf5839f08]

        tdf#141102 related: Improve names of menu items used to fold and
        
        unfold outline content including sub level outline content
        
        Change-Id: I686b3acdec910a7b6ae11b498eea3e4c01b6ada8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154558
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-07-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [b21159a74f287acd07c94422eb5cb3375f06c6bc]

        tdf#156378 Open function help page on F1 in the Functions sidebar
        
        With this patch, when the user opens the Functions sidebar, select an entry and presses F1, the help page about the selected function will be shown.
        
        Change-Id: I37eecc4e325cee7f25ddb1cd81098ca318ce6518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154617
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-20  Matt K  <mattkse@gmail.com>  [58a4459627a92958ef133868f72af10d8d56ccad]

        tdf#150302 Fix FontworkSameLetterHeights button in Draw
        
        This change fixes the Font Work Bar SameLetterHeights button
        at the bottom of Draw when opening a file without a
        FontWorkSameLetterHeights property initialied in the XML
        of the file.  The change now applies a default property value
        which allows the button to properly work and switch the boolean
        value of property which can then be saved in the XML of the file.
        Also added a unit test which checks for the correct property
        value after toggling the button 2 times.
        
        The command to run the new unit test is:
        make CppunitTest_svx_unit CPPUNIT_TEST_NAME=testTdf150302
        
        Change-Id: Id55eaedb625139f0071cdca5f628a0766afab0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154402
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-07-20  Justin Luth  <jluth@mail.com>  [d795d147b644a9abdb9fb343dec5970e435b527b]

        Revert "tdf#149401 show "Restart LibreOffice" dialog changing AutoRecovery"
        
        This reverts 7.4 commit 18cc891483fef63ad168273658a30bff72b87a95.
        
        The bits are no longer used because all options in this dialog
        apply immediately, thanks to tdf#65509 and even more so tdf#156308
        (which are API changes that won't be backported - so 24.2+ only).
        
        I didn't see any other option in this dialog that could have
        benefitted from a restart request, and the scope of this
        dialog is rather small, so no value in ignoring the dead code.
        
        Change-Id: I3f40421af079fd42c10d6862949279328ef5583b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154669
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [46ef53f8ab839f659892589cbd7d143beb3eea9f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e6ed0152d5a8f824a4e1a3066caef1e0ad1be85
          - (related) tdf#68565 add "Place backup in same folder as document" option
            
              + add new option and description
              * move position of three options to align with dialog
                (no content changes for i10n)
            
            Change-Id: I99fa9a3ba58dea844cf94dd2653f9aefb4f3d4e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154468
            Tested-by: Jenkins
            Reviewed-by: Justin Luth <jluth@mail.com>
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-07-20  Michael Stahl  <michael.stahl@allotropia.de>  [49dca4be647733507b2082a9c74187076a4a8d9b]

        tdf#154990 vcl: PDF export: incorrect checks of annotation struct parents
        
        The first form annotation is missing /StructParent.
        
        The invalid value is -1, not 0. Typically 0 is the index of the MCIDs
        entry (m_aMCIDParents) in the ParentTree /Nums, but if there is not a
        single MCID in the document, this is omitted and 0 may be a valid
        annotation then.
        
        Change-Id: I9885d176eae272d98000f9d9f0ffae82558c0ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154668
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-20  TokieSan  <eltokhy@aucegypt.edu>  [ad6f23d2a3842c40f7c812003af4031150ea8183]

        Added searching and filtering features to certificate chooser dialog
        
        Added a new search box in the certificate chooser dialog, introduced
        local caching for certificates to allow instantaneous filtering and
        searching. Modified viewing signatures function to allow searching
        functionality.
        
        Change-Id: I361a47da7bd5d24efcbfc17065935851db951c44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154630
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-20  sahil  <gautamsahil1947@gmail.com>  [e9dcbb2a5965e062c84b2e222239e83fdf3f3227]

        tdf#143148 Use pragma once in sw
        
        Change-Id: Ibb1fc8d8419dd4e1c805134fab3ee91476e5c5ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154662
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-07-20  sahil  <gautamsahil1947@gmail.com>  [e99f7feb57e62d395d5b31f12e1c54194ffbf99d]

        tdf#143148 Use pragma once in vcl
        
        Change-Id: I4cf05114c7568d6c7b7ddba1b3c4a862d7a24dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154656
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-07-20  Justin Luth  <jluth@mail.com>  [97e5f7be679c9cc34d905987d08b62a67dde022c]

        tdf#65509 autosave: apply UserAutoSave without restarting
        
        Now that I know there is a config listener running in AutoRecovery,
        listen for the config change and apply it immediately
        instead of requesting the user to do a restart.
        
        Change-Id: I69912c0e95c04cc1a5e680d5e8c59b15e94efb05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154664
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-20  Julien Nabet  <serval2412@yahoo.fr>  [d969715fa4df9de762c652a7af27601fa75fb275]

        Simplify a bit by removing a redundant condition
        
        line 627 already contains: if( nMaxDigit > nDigitPos )
        
        so here we know that nMaxDigit >= nDigitPos
        
        Change-Id: Ia7ed69e19a6567a5947edaa57f687bf97476a616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154661
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e8b7dd7a013dffe080148baac926a698f36ad85]

        split GetWindowExtentsRelative asunder
        
        sometimes it returns a relative position, sometimes an absolute
        position.
        
        Rather have two different methods with names that match what
        they return.
        
        Change-Id: Ie1e73c6be1c797fd59934c96866d1fef1f972b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [669d6ed4fa2e7a01c372a6e27dd5468ec8eb3077]

        simplify the operation of ImplGetWindowExtentsRelative
        
        instead of inlining OutputToAbsoluteScreenPixel
        
        Change-Id: I4914392e6dfb5c1ace7041642fecbaa084cf7626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4bba62e69bae1d1e065b8634b2fea291372ea1ba]

        remove dead code in ImplDrawFloatwinBorder
        
        Change-Id: I4f71d7dbf3ae3fbc139f770084dbdea4cbf9b848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1279dbe3169eda9a431b87a703f03a619731d5d]

        no need to return a mutable ref from ImplGetItemEdgeClipRect
        
        and risk updating internal site.
        Luckily, all of the current callers are making a local copy
        
        Change-Id: I8b85d087ef934b1bb32f5a902a4fbf08659b7511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-20  Justin Luth  <jluth@mail.com>  [896f19764abf9301169bf9631877bdae075edde4]

        tdf#156308 autosave: re-listening to config, no restart requests
        
        The reason the restart request was added was because of the
        broken config. Now that the config is correct again,
        the listener notices the enable change and turns AutoSave on/off
        immediately. So there is no need to prompt the user to restart
        after modifying the setting in Tools - Options.
        
        Change-Id: I0c775964ce5d9f860b0ce320db86d8db7226a489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154663
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-20  Justin Luth  <justin.luth@collabora.com>  [e823cd380a2ad38cbc7598c7393752f6398cb24f]

        tdf#86630 sw page number wizard: add to notebookbar layout tab
        
        I think putting this in layout makes the most sense,
        since Title page is already there, and these are all
        page style tasks.
        
        The other possible location is Insert. Title page is here also.
        I'd suggest putting it under Title page,
        and moving Fields above Section
        
        Change-Id: I6f432af3726b44b4fb7554fc73e343959cfe2d0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151398
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-07-19  Satya  <skompella@opentext.com>  [a3b76c2cb216a55d60fdf8b4533ac02c7f37c005]

        tdf#156372 sw: Stop adding GetLower to every cell in header table
        
        The code was doubling the lower spacing of the last paragraph
        in every cell of the table. This change is to not add the space
        when in tables, since that was intended to only apply
        to the last paragraph in the header.
        
        make CppunitTest_sw_ooxmlexport19 CPPUNIT_TEST_NAME=testTdf156372
        
        Change-Id: Ia8c2b31e3e56302735e858c39f80cc35e190af6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154643
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [514cc22875a90c8faa3d946ad47ebb68bd710ac7]

        Use correct configuration
        
        I introduced it in commit 79113484cacb630f93f87c483b6c5d97c47b8728
        by mistake, when rebased on 3c41b32562d5ccdd306000484c5b16245b2b4a4f.
        
        Change-Id: Ia3ba91cda9e54d9434b6d79bf78afd13f2b20d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154619
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [ba99cc9d9cf781d9b3888e1cf5becd95bb9fc6d2]

        tdf#153115 sw: fix yet another FindPrvNxtFrameNode() issue
        
        In the SwUndoTextToTable for the middle cell it happens that there is no
        frame remaining in the cell frame and SwNodes::FindPrvNxtFrameNode()
        erroneously returns a frame from inside the preceding cell, so it
        creates the frame in the wrong cell.
        
        (regression from commit faf2d9e2cb13c3750ac359338f8f31fc1afce368)
        
        Change-Id: I2e4f460541e20dda23c1fafb6d63c023dae9b152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154654
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [cd20d9512aa4f9fbe39fce48b3c49cdb13cca6e6]

        tdf#153115 sw: SwDoc::TextToTable(), first remove all redlines
        
        The problem is that there are redlines that overlap the created table
        cell nodes.
        
        For the writerfilter-import-API TextToTable() that was solved by
        splitting the redlines, but that would take a lot of effort here as it's
        not known ahead of time where the cells start and end, so just get rid
        of the redlines.
        
        Another issue is that the temporary SwPaM in
        DocumentRedlineManager::AcceptRedline() caused ~SwIndexReg() assert.
        
        (reportedly regression from commit 471212d464f54054f7419ef1890267d0def852d9)
        
        Change-Id: I6b211b6c8e5c7e4bdab1dac858707d7d7fd85029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154655
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-19  Jean-Pierre Ledure  <jp@ledure.be>  [3480cfdb1e153ff489dcbd3790c3f120fdde13a0]

        ScriptForge (FormDocument) fix tdf#156356 Variable not defined
        
        Change-Id: I4bbd4b05ca42ccde4b83eb55a1f1ae80ebca9680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154592
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-07-19  Julien Nabet  <serval2412@yahoo.fr>  [7835f97113460922cfe14685baa7bcaea2de736a]

        add IndexHint -1 for 2 commitEvent methods in accessibility
        
        Change-Id: I3a2d4e0935d48e8d7ff57745dc05aa3e85bd0bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154590
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-19  Paris Oplopoios  <paris.oplopoios@collabora.com>  [6819adb7a66a162f5be40990ea62689cd58f7c8b]

        sw: Add test for continuous section breaks not adding page breaks
        
        Change-Id: I1dbaa0075ff33012c7cc94f1aa82dd992dd0e680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154588
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-07-19  Paris Oplopoios  <paris.oplopoios@collabora.com>  [b33e485b1dc9aec04a8899671abf5397face30cd]

        Fix inline page breaks not imported correctly from .doc files
        
        The way we handle page breaks is by creating new paragraphs. This
        visually looks fine until the imported file has stuff like first line
        indentation.
        
        Change-Id: I26d5bbc1ce8b0ff4492b099305f0ff22de41e4cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154358
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-07-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [3bc3ba51d25ff1fd0fbdf1b09863cf90b20c8950]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5220ee012cb07e1006b5915faaaf44fc623ddb0b
          - tdf#118591 Fix help target when editing chart
            
            Change-Id: I424202a600ce508e81debb12b8de2fa674d17cb1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154611
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [4cf0243e8784ce4af3cabc613c6e2c6edf7a8fc8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7373f6259cd7270ab4263b54aa828c040fdaa133
          - Document new FileSystem feature in ScriptForge
            
            This patch also updates the documentation of the GetTempName method.
            
            Change-Id: Id15ddd909733a04ee5fe2ec208b9b010d0aa7de6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154469
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2023-07-19  Miklos Vajna  <vmiklos@collabora.com>  [45574624ff05673d44f11cdbbbb49e1af599133e]

        tdf#120262 sw floattable: no split when none of first row fits the vert space
        
        The final problem with the bugdoc is that half row of the second
        floating table was still on page 1, while it should be fully on page 2.
        
        The reason for this was that first we thought we can't move forward,
        since GetIndPrev() returns nullptr for a table that's inside a fly
        frame. Then we thought it's a good idea to split, even if the split
        would move the entire first row to the next page.
        
        Fix the problem by:
        
        - In SwTabFrame::MakeAll(), handle split flys after calling
          GetIndPrev(), an indirect prev of the anchor has the same meaning in
          this context.
        
        - In SwTabFrame::Split(), fail for split flys in case only half of the first
          row's first line would fit, which gives an opporunity to call
          MoveFwd().
        
        - In SwTabFrame::MakeAll(), call MoveFwd() in a way that it's not a
          problem that the GetIndPrev() call in MoveFwd() gives us a nullptr.
        
        - At this point we don't split the table, we move it forward, but an
          empty master remains on page 1. Fix that by improving
          SwFlowFrame::MoveSubTree() to mark empty flys for deletion, similar to
          how it does the same for sections.
        
        - Finally avoid a layout warning in SwTabFrame::MakeAll(), it's OK to
          try to split in case our split fly has a follow, we can move there on
          split failure.
        
        Also bring the test document closed to the original bugdoc, so we can
        assert the content on both pages.
        
        Change-Id: I2d3f88342d91b3e256bc41416a9afb274a9309d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154633
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-19  Miklos Vajna  <vmiklos@collabora.com>  [a85cb997bc84a26196d8852bd0d546db1de3b761]

        CppunitTest_sw_htmlexport: rework to avoid preTest()
        
        Which means no magic happens just because a test document is called
        charborder.odt.
        
        Change-Id: I8eda9d1cdc905a6041369321469cbf34c375da83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154597
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [b68a6d6ce18a611873c166e72a97930812bfbbc0]

        tdf#146258 sw: commit 34b607bb455bd30d3adf8e3f72182c7cc4d062ee
        
        ... used wrong issue id.
        
        Change-Id: If042ba0b5dcb13f7b1634e7dff2c385a7bce9a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154644
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [34b607bb455bd30d3adf8e3f72182c7cc4d062ee]

        tdf#148729 sw: invalidate section frame for new text frame at start
        
        SwFlowFrame::CalcUpperSpace() uses the first text frame inside to
        compute the upper margin of section frames.
        
        Before commit 69d2d24b3579ad21fb1ba2746f81a02f8bbfb984 this was
        working because a temporary SwTextFrame for the new SwTextNode was
        created and then deleted again, but while it was alive the SvULSpace
        item was copied and then it invalidated the section frame:
        
        1  SwFrame::InvalidatePrt_()
        2  SwContentFrame::Modify()
            at libreoffice-6-1/sw/source/core/layout/wsfrm.cxx:2336
        3  SwTextFrame::SwClientNotify()
        ...
        7  SwTextNode::Modify()
        8  SwContentNode::SetAttr()
        9  SwTextNode::SetAttr()
        10 SwAttrSet::CopyToModify()
        11 SwTextNode::CopyText()
        12 SwTextNode::CopyText()
        13 SwTextNode::MakeCopy()
        14 SwNodes::CopyNodes()
        15 sw::DocumentContentOperationsManager::CopyWithFlyInFly()
        16 SwIntrnlSectRefLink::DataChanged()
        
        Now however nothing invalidates the section frame, so do it in
        InsertCnt_(), hopefully it works for columned sections too.
        
        (regression from commit 166b5010b402a41b192b1659093a25acf9065fd9)
        
        Change-Id: I339286ac37c9ee9a0bef730a73215bc139386514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154594
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [473da3a79758b061409ca6f0d8a41a0a91541842]

        tdf#127294 add tip about "Search Commands"
        
             also provided uri
        
        Change-Id: I7e757b41dfb8532b4b39f4d8a9bbf9b296c69b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154539
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-07-19  Stephan Bergmann  <sbergman@redhat.com>  [e83e62fe376a91f7270435e06ee7f6864c48fb4b]

        Work around MSVC bug with "..."_ostr vs. u"..."_ostr
        
        Since 27d1f3ac016d77d3c907cebedca558308f366855 "O[U]String literals (unusable
        for now, C++20 only)",
        <https://developercommunity.visualstudio.com/t/Using-same-string-literal-suffix-for-cha/10416970>
        "Using same string literal suffix for char and char16_t string overloads causes
        'no matching overloaded function found'" caused --with-latest-c++ builds to fail
        with
        
        > sal/qa/rtl/strings/test_oustring_stringliterals.cxx(432): error C2672: '""_ostr': no matching overloaded function found
        > include\rtl/ustring.hxx(3604): note: could be 'rtlunittest::OUString operator ""_ostr(void)'
        > include\rtl/string.hxx(2402): note: or       'rtlunittest::OString operator ""_ostr(void)'
        > sal/qa/rtl/strings/test_oustring_stringliterals.cxx(432): error C2672: 'CppUnit::assertEquals': no matching overloaded function found
        > workdir\UnpackedTarball\cppunit\include\cppunit/TestAssert.h(161): note: could be 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)'
        > sal/qa/rtl/strings/test_oustring_stringliterals.cxx(432): note: 'void CppUnit::assertEquals(const T &,const T &,CppUnit::SourceLine,const std::string &)': expects 4 arguments - 3 provided
        
        etc.  So help MSVC along by renaming from u"..."_ostr to u"..."_ustr for now.
        
        Change-Id: Iad401f0681ac9326b7c57259c5483263ddfbfd4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154634
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fd361874d5c4da99dec763dfdc9c4dd21dfe34a6]

        tdf#130581 - Improve unit test of undo command for hide/show slides
        
        The test has the following structure:
        
        1. The first slide will be selected and set to hidden
        2. Then, the test checks if the slide is hidden and
        if there is the undo command for hiding the slide
        
        3. Second, hiding the slide will be undone
        4. Again, the test checks if the slide is visible and
        if there is the redo command for hiding the slide
        
        Finally, the same actions will be tested using the show slide command
        where the tests checks for two undo actions, i.e., show and hide slide.
        
        Change-Id: I8e9c4905f4ebbb45d872f5e6ca76179dbfae3a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154464
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-07-19  László Németh  <nemeth@numbertext.org>  [f9898fa64bd2a575be94c309b43373de53c5331b]

        tdf#150308 sw: fix missing top table border after hidden table rows
        
        First visible line of a table with preceding hidden deleted rows
        hid also the top border of the table, if the inner horizontal row
        borders drawn only by bottom-only borders (like in the default table
        style).
        
        Note: re-use an existing workaround to show the missing line,
        see commit 3a4b7c3555f2ffb4e89502bb04ff063d8c08f628
        "fdo#39415: sw: fix collapsing border painting more:"
        
        Note: layout testing doesn't work, because of the missing calculation
        with the width of the enabled border of the row frame. Also there is
        a problem with metafile testing (empty meta file?).
        
        Change-Id: Ia8476a2ec592be1dc36e0ea71c10a71c257c29e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154595
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5c43adc8e6f9948038be6c1fb20f4ac5718a74ea]

        tdf#156139 - A11Y - Improve issue text when document starts with wrong
        
        outline level.
        
        Change-Id: I68bff66171af61089f0f8b06a0842f1f3dfdd7bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154139
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-19  Miklos Vajna  <vmiklos@collabora.com>  [210f8158c834e5a3f528795078a22a5d89d5d910]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6e573845ec522e075ed2774dc8ce45c373be1c79
          - sw floattable: add initial help
            
            Change-Id: I8f850bf3ea8c11337aa7db4593e9ff139461706d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154635
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2023-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [519876dffdc8c93710af543cc11332dab9a50c14]

        Cleanup SfxApplication::Get/SetOptions, and drop unused SIDs
        
        The removed stuff was never used elsewhere; e.g. all uses of GetOptions
        use Which Ranges that don't include the removed identifiers. Elements
        removed from SetOptions weren't passed to that function from anywhere.
        
        Change-Id: Id81b57014b82f89538a46a609f3e4b328864bbcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154604
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-19  anfanite396  <dipamt1729@gmail.com>  [9b7df92ba0cc911f956bf159d106aa001c30de52]

        Move SwXReferenceMark Java tests to C++
        
        Change-Id: I95777931fd039b22983218d7472c3f7037e6c62d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154085
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-19  anfanite396  <dipamt1729@gmail.com>  [08a322995cd54038c9d210f5016f57b1fe9e738a]

        Move SwXParagraphEnumeration Java tests to C++
        
        Change-Id: I8315d52e75ddbe3b4f844fcb645f857da3d12acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154084
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b15ffce29fb72785a357695a152df50e2a7db71]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f94e18ea85ea872081a15b2414b395eec2fbbcf5
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 12)
            
            Change-Id: I0ebf03b829f22b373a9f5711afb9210933f6c1fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154605
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [91ae79dc84dc26fa6eb1d7bac4824f3efd62a600]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b2c510207a640e706857bb5fa716de56e0e55751
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 11)
            
            Change-Id: I82b68c5b041cf9b531c96870eeec7b35c43b0467
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154603
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-18  Justin Luth  <jluth@mail.com>  [24c52c6f8674a716f3f5102095421c97d03b19d8]

        related tdf#68565 tdf#123877 autosave: identify by args, not path
        
        It shouldn't matter where the autosave is being stored,
        the password request wants to be cancelled any time
        the save event is triggered by autosave.
        
        I couldn't really follow the discussion about needing a re-hash,
        whether the old password has would just be stored
        without being confirmed.
        
        Based on a code read, it looks like this would happen with any
        kind of password, so I'm not sure why only calc8 was singled out.
        So I eliminated that clause - even though at the time it likely
        is the only format that will trigger the need for a rehash.
        
        Change-Id: I72a11910e29e101aa98f7f8ecc0cffc7956102a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154480
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [3394fe4f19def29e314798fa64235b28d9df50a6]

        fix DNDEventDispatcher::findTopLevelWindow
        
        for the unlikely case of antiparallel desktop (whatever that is)
        
        regression from
            commit ea05f2aa4e28fd40238c4962e9dcbbf0d873cabd
            Author: Norbert Thiebaud <nthiebaud@gmail.com>
            Date:   Thu Oct 14 22:12:16 2010 -0500
            migrate OClearableGuard(SoalrMutex) to SolarMutexGuard
        
        when the code findTopLevelWindow was extracted into its own method,
        the location parameter was not made a reference, which is necessary to
        propogate the update that occurs in OutputDevice::ReMirror
        
        Change-Id: I37c18497660cd157ca4e4cfb1cbb60ed07e11da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [bb01ef3865c406f322d6e656faba2191aaeeb6da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8208d85dbba1b02033b022832a85618ab736ce12
          - tdf#156327 Fix help target for Search Commands
            
            Change-Id: Ie0aa9822bf930cd62fc56846c32f7ed642a83e12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154548
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-18  Justin Luth  <jluth@mail.com>  [09d3e887b41a36bd0852ac004c6744f447361ac6]

        tdf#68565 autosave: add option to store backup in document's folder
        
        Creating a backup copy became the default in LO 7.6.
        
        Allow the user to choose whether to store this previous version
        of the file beside the original file (in the same folder).
        The historical (and still the default) action
        is to store it in a special backup folder instead.
        
        The problem with the backup folder is that it overwrites files
        that happen to have the same name (because the originals
        reside in different directories), which is not uncommon.
        Adding this option allows the user to overcome that limitation.
        
        However, I do not want this new option to become the default,
        because it effectively doubles the number of documents
        stored in the document folder.
        I think that is very messy, and previous versioning is best
        left to dedicated backup tools - which would not appreciate
        doubling the number of documents they preserve.
        Plus I've worked with enough novice users to know that people are easily
        confused when multiple documents have (essentially) the same name.
        
        Change-Id: I503f656af91807019587e3d7b0d82b661f1eb437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154489
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Mike Kaganski  <mike.kaganski@collabora.com>  [79113484cacb630f93f87c483b6c5d97c47b8728]

        [API CHANGE] tdf#144512: keep autosave interval separately for each document
        
        Maybe this would make a better UX, as the request suggests ... or maybe not.
        
        css::document::XDocumentRecovery2 is introduced for this, allowing to query
        the document dirty state duration.
        
        Change-Id: I25997788bc5da261f7e4131616ab8d4a245de380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154505
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fc4c3504947d0e5c34978cb8ae9bdd2a2196fd1]

        remove ImplFrameToOutput and ImplOutputToFrame
        
        in favour of ScreenToOutputPixel and OutputToScreenPixel, since their
        implementation is exactly the same
        
        Change-Id: Iede024bfc5654e3f671984620f8e88d2414003f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154591
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-18  Paris Oplopoios  <paris.oplopoios@collabora.com>  [df00cd5cf77eb2322f53b80296862940ba815d9a]

        Revert "ww8import create a pagedesc if continuous section changes margins"
        
        This reverts commit c5ed52b1cd6f22787c94bec035ceecf9e1da3271.
        
        The reverted commit would insert a pagebreak on section breaks if the
        margin before and after the section break was different. While this
        means a table after the section break will get the correct margin, it
        would also create a page which is very breaking - it shouldn't be the
        case in documents that have multiple continuous section breaks in a
        single page that a new page is created for each of those breaks if the
        margins are different - there are documents where this happens and in
        those documents a single page gets converted to multiple messy pages.
        Thus the table margins being correct after a section break with a margin
        change should be fixed in a different way.
        
        Change-Id: Ia5d5b98ddbd021803a6a9f80762b97db5808509f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154565
        Tested-by: Jenkins
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-07-18  Venetia Furtado  <venetiarosita@gmail.com>  [63a9b0bed08a68f3619cadf7b7cef0a087154c10]

        tdf#145614 Convert #define to enum
        
        Change-Id: I4e0aa0b167a8e54c1ba85f2b4c86f3f198672553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154075
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dceeb9550dfd4e40e93180b7e10f2539b594529f]

        sc: ODF import/export of background cell complex color
        
        Change-Id: Idf526aea21ccfeda9b03d1fb69588f120b6e161d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154571
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2455826917868a5da5ab1bb4586e067d6c968c43]

        xmloff: move XMLComplexColor* import/export classes to public include
        
        Change-Id: I52aad31f63858eba905481812cbf971493252642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154570
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-18  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [4adc868328e958a4a9cead3731bd3468497c97c8]

        Resolves tdf#112876 - Make use of scroll lock configurable
        
        Change-Id: I8e2f238e59601fcc1d92fc0593c3d20e75396cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154528
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2023-07-18  Venetia Furtado  <venetiarosita@gmail.com>  [a8a7fb58398047ad4b146b96a13567ed9e256100]

        tdf#114441: Replace sal_uLong with size_t in doccomp.cxx
        
        The caller of Compare::CheckDiscard passes value of type size_t.
        Therefore, replaced the type of the method’s first argument from sal_uLong to size_t.
        Further, refactored all dependent variables to size_t as well.
        
        Change-Id: Id32a88936e92f0d30aa6a7a07412a91845beed63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154203
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-07-18  Kohei Yoshida  <kohei@libreoffice.org>  [9a96c395d52984628b759104f9ce2a7781d0e139]

        Make the reference resolver really available for orcus
        
        It was there, but was never really made available.
        
        Change-Id: Id7093c4c6b52aa1831f42046a83991b923c70781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154569
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-07-18  Justin Luth  <jluth@mail.com>  [5aa4ec482cf9ebb22571b1e5e8af0ff46d6ad3eb]

        [API CHANGE] Drop unused AutoSavePrompt config key
        
        Never been used since prior to 2004 AFAICS
        
        git grep -i -C20 "auto.*save.*prompt"
        
        A git log -S AutoSavePrompt indicates that a
        seemingly superfluous use of it was removed with
        commit 1507e3b63b80b541a241d0ce1c977abb45cbeef8
        Author: Rüdiger Timm on Fri Nov 26 13:37:09 2004 +0000
            INTEGRATION: CWS recovery04 (1.52.36); FILE MERGED
        
        and the superfluous function itself was removed with
        commit 36a665a6754bbc4bb0a2d612a15b1b8413af3721
        Author: Caolán McNamara on Wed Jul 27 22:09:03 2011 +0100
            callcatcher: remove various unused methods
        
        This was probably all obsoleted by
        // functionality moved to new AutoRecovery Service!
        
        Change-Id: Iedc48a1913a09f8c22a4476f2e8441cff448f06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154568
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [5f2c99839bf041faf5b15aa9d4bb4c73b4b041f0]

        deduplicate virtual page info update in SwPageFrame
        
        Change-Id: I2753f080f7751189675007ded8ba050245a8758c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154562
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-18  Miklos Vajna  <vmiklos@collabora.com>  [9a5d1c250cbaac855b3e63d8c5fa0882ba7d14a2]

        tdf#120262 sw floattable, legacy: go outside body only for page frame vert pos
        
        The bugdoc has to pages, the floating table from the top of page 2 is
        partially moved to page 1 and overlaps with the footer text.
        
        Part of the reason this happens is that in case the vertical position is
        relative to the page frame, then Word allows using the footer area for
        floating tables (see tdf#155118), but turns out that in case the
        position is relative to other places (e.g. paragraph), then this is not
        necessary.
        
        Fix the problem by making the "is legacy" condition in
        GetFlyAnchorBottom() more strict, which keeps tdf#155118 fixed, but
        improves this bugdoc.
        
        Leave the layout unchanged for cases where the floating table is not in
        the body text (e.g. footnotes). Now the overlap is fixed, but still a
        bug remains where the first row on this split table is not moved page 2.
        
        Change-Id: I96d6eb527d7f33dd65de8a66f815219c02625d93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154573
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-18  Julien Nabet  <serval2412@yahoo.fr>  [007ef352c2e6a061c52a45a35d3930d318b8ca8b]

        Revert "tdf#155431: SQL Editor does not recognize UNSIGNED"
        
        This reverts commit 408a51a964d06e86c12d3a938c1295c75eecea63.
        
        Reason for revert: I gave a new try, it indeed doesn't work, I must have missed something.
        
        Change-Id: Ibf3318374cf68eaf093b9fa140b79beef2ddbd3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154546
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-18  Michael Stahl  <michael.stahl@allotropia.de>  [7e9b2b71db72b8c4c9c6ca83d08d3b6b05775ac8]

        tdf#153319 sw: don't move footnotes to follow if portions in master
        
        SwTextFrameBreak::IsInside() may be called in different situations,
        during formatting it should be possible to move the footnotes, but when
        called from SwTextFrame::CalcPreps() this is problematic as it does not
        format the lines, it iterates over existing lines.
        
        The problem is that the footnote frame is moved to the follow's page,
        but the footnote portion remains on the master, and then the follow is
        joined while the footnote frame's mpReference still points to it.
        
        (regression from commit 391613785ae6fbb735cf7a86ea2f6a93161a8769)
        
        Change-Id: I4290dcd242a7f5292ad4f50c1407c9cd88e80a6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154557
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c4bbd05d506c14a29cfb07f118f710c11958d83c]

        tdf#156325 - Index of tables: support ctrl + click on an item
        
        Change-Id: I6de76d946ab0810cc3c2ba9fbec5d3c1db043a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154574
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-07-18  Julien Nabet  <serval2412@yahoo.fr>  [408a51a964d06e86c12d3a938c1295c75eecea63]

        tdf#155431: SQL Editor does not recognize UNSIGNED
        
        Change-Id: I2d618b27a92e1a85a6b7730aca3341f5259c4037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152128
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-18  Mike Kaganski  <mike.kaganski@collabora.com>  [c5ae73c8f3abdb067e3cef0cb5565e1f00ae08ea]

        Drop aSendSet
        
        ... which was never used, since its introduction in the initial import.
        
        Change-Id: If962e24663a53911977992e4d60fa8abe5b6ff75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154461
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-18  Stephan Bergmann  <sbergman@redhat.com>  [33eb52e005eb67856137475ff761ce4df006bd57]

        MSVC: Silence C++23 std::numeric_limits::has_denorm deprecation warning
        
        ...as seen at least when building against VS 2022 Preview 17.7.0 Preview 3.0 and
        --with-latest-c++,
        
        > [build CXX] connectivity/source/commontools/RowFunctionParser.cxx
        > workdir\UnpackedTarball\boost\boost/spirit/home/classic/core/primitives/impl/numerics.ipp(199): error C2220: the following warning is treated as an error
        > workdir\UnpackedTarball\boost\boost/spirit/home/classic/core/primitives/impl/numerics.ipp(199): warning C4996: 'std::_Num_base::has_denorm': warning STL4042: std::float_denorm_style, std::numeric_limits::has_denorm, and std::numeric_limits::has_denorm_loss are deprecated in C++23. You can define _SILENCE_CXX23_DENORM_DEPRECATION_WARNING or _SILENCE_ALL_CXX23_DEPRECATION_WARNINGS to suppress this warning.
        > workdir\UnpackedTarball\boost\boost/spirit/home/classic/core/primitives/impl/numerics.ipp(193): note: while compiling class template member function 'bool boost::spirit::classic::impl::negative_accumulate<T,10>::add(T &,T)'
        > with
        > [
        > T=int
        > ]
        [...]
        
        etc.
        
        Change-Id: If9f03e0c5e910549df1c5eb0e089b39623776311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154552
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-18  Miklos Vajna  <vmiklos@collabora.com>  [de9aeed35461b0884c55318519333070b7726c2b]

        sw: document SwFormatFootnote
        
        Explain this is just the anchor side, the content side is described by
        the SwTextFootnote around us.
        
        Change-Id: Id27ce3cabf30b31c494a9dbfbc94130c35bb61cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154556
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-18  Mike Kaganski  <mike.kaganski@collabora.com>  [8e9b3abce97f6ec1851cb7e3464e63107fad2793]

        Make sure that root listeners are notified first
        
        The problem appeared when in a configuration listener's changesOccurred,
        a configuration value was read using officecfg machinery, which could
        return the old value of the configuration, or an updated one, at random.
        
        This was caused by use of a cached value in
        comphelper::detail::ConfigurationWrapper::getPropertyValue, which is
        cleaned in ConfigurationChangesListener::changesOccurred; but the order
        in which the listeners' changesOccurred methods were called depended on
        the implementation detail of configmgr::Components::roots_, which was
        previously a std::set of pointers, and now is a sorted vector. This
        made the pointers sorted in order of the pointers' addresses (basically
        random), and when a broadcaster's common list of change listeners was
        prepared in Components::initGlobalBroadcaster, ConfigurationWrapper's
        listener could arrive last. This meant, that the cache could be cleaned
        too late, after its obsolete content was already used in a previous
        listener.
        
        The problem could be partially mitigated by clearing the cache in the
        comphelper::detail::ConfigurationWrapper::setPropertyValue, but that
        would only handle cases of config modifications using comphelper.
        
        Instead, take into account that ConfigurationWrapper listens on the
        root of configuration tree; and introduce a separate container in
        configmgr::Broadcaster for root listeners. They would be triggered
        first, before all other listeners.
        
        Still, this would not guarantee the proper order, if another listener
        is registered on root. To handle all cases, a special listener category
        could be used, which could be filled using a dedicated internal API, so
        comphelper could use it to register its privileged listener close to
        the heart of the broadcaster :) This might be implemented later.
        
        Change-Id: I956b7989b3927dca2683f63cf92b0dda04db9bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154561
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-18  Aron Budea  <aron.budea@collabora.com>  [4202dfcae19ee47e9a3fda02fac34c18cb0d16ff]

        tdf#155661 Apply border from center point not from whole size
        
        Regression from 6965bb07bb33429a7663a3f3ebe58ed89c4327d9
        and 8b8a988f38b704e466211bb91a3269756c34222b.
        
        Change-Id: I2e8c21fbdbbc7efb4b473c63b098044384a70d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154501
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-18  Justin Luth  <jluth@mail.com>  [6256d5fe2e7cb1bb002d5fe59527d3a3fbf6963f]

        tdf#136905 NBB: use label font in ValueSetWithTextControl
        
        The label font is taken from the system settings,
        and doing this matched the "more options" button font
        as well as the nearby "margins" and "columns"
        as well as pretty much everything else in the notebookbar.
        
        I tested this by changing "Font Selection" in my Ubuntu Cinnamon
        to a flowery font. Prior to the patch it was a normalish font,
        but after the change it was using the flowery font.
        
        Change-Id: I2585e6aec31aa4195a2354337eb243e63c719ec0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154555
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Justin Luth  <jluth@mail.com>  [e58e251756ecb0312cb6891d4df23e17ef8f6fcb]

        tdf#126095 sd notebookbar: don't force table/media toolbar
        
        Perhaps the entire function could return early
        in case the notebookbar is active, but only if all of them
        have a context notebookbar tab.
        Some of them I can't check since I don't know how to trigger them.
        
        Images, media, and tables all do have a context bar.
        (Media's bar is missing useful things like location, mute,
        and even file-location path.
        (Those will come separately in another commit.)
        
        Change-Id: Ic4623a1cab3abc1ac1f83622cbd11e549d2b0b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154559
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Justin Luth  <jluth@mail.com>  [1de07de0cb063760474df70d0e4b6a7976ac2a8a]

        related tdf#126095 sd notebookbar: give room to .uno:AVMediaToolBox
        
        There are lots of controls on the media player (like mute, position etc)
        that are obviously not accessible if the control is squished to a small size.
        
        Giving full access is especially important if we do not show
        the extra toolbar, but depend on this notebookbar context switch.
        
        Change-Id: Ie766c426182469015a3431b83c852ce16d7436f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154560
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Justin Luth  <jluth@mail.com>  [1876feb8a8805b2f80537e2828c152ccbdf67fe2]

        tdf#136905 NBB: let ValueSetWithTextControl set optimal height
        
        There was no way to specify a "good font size" to use
        for .uno:AttributePageSize in the notebookbar.
        The font "resized to match to size of the box"
        which is hard-coded to aSize(250, 300).
        
        (Even if ValueSet::SetOptimalSize worked, it would set an
        inadequate height.)
        
        So it seems like the best thing to do is simply add a function
        that allows the box height to be modified.
        
        Using the fontsize from GetDefaultFont is not correct.
        Use the OS-defined label font size instead, which seems to be
        the most common choice - GetPushButtonFont would has also worked.
        
        I verified that the label font size is controled by
        the OS' font preference.
        
        The ability to define the box's optimal height
        is still (somewhat) necessary. It isn't good enough
        to just "use the system font size".
        I tested with an OS font size of 48 (instead of 11),
        and in that case the box height was too small
        (but with the font only using 4/9's of a 12pt space,
        even a 24pt font looked OK without adjusting optimal height).
        
        Change-Id: I0a0774dea9c2a6c21a8e84439318a94f39783413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154286
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-18  Justin Luth  <jluth@mail.com>  [ef1484c731140699f26d15f4cda36f1a81e73abe]

        Revert "Revert "tdf#126006 sc SID_RELOAD: restart notebookbar""
        
        This reverts commit d0bbc16b1715a3711d872a36c7e525e8d3811669.
        
        My laptop is failing to complete UITests all the time,
        so likely this patch wasn't to blame after all.
        
        Change-Id: I3fa9fbb8ffc8df1fd9e45f8bcb6489594a8c0c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154199
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-17  Stephan Bergmann  <sbergman@redhat.com>  [39927fa6a9744b89b8ddf3abed0fd905510a9675]

        external/clucene: More uses of obsolete std::binary_function
        
        ...as seen at least when building against VS 2022 Preview 17.7.0 Preview 3.0 and
        --with-latest-c++,
        
        > workdir\UnpackedTarball\clucene\src\core\CLucene/util/_Arrays.h(128): error C2039: 'binary_function': is not a member of 'std'
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1437~1.328\Include\vector(26): note: see declaration of 'std'
        > workdir\UnpackedTarball\clucene\src\core\CLucene/util/_Arrays.h(153): note: see reference to class template instantiation 'lucene::util::CLListEquals<_kt,_comparator,class1,class2>' being compiled
        
        etc.
        
        Change-Id: Icea14fe0c0ad85501367ac6c81a3b8aada595383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154551
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [ca460e654a1ee17d755cff6943f07bfa88da9a27]

        Simplify a bit
        
        Change-Id: I6c20a9809ee8cae27e8894c91266d82ea04540f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154534
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [3c41b32562d5ccdd306000484c5b16245b2b4a4f]

        tdf#156308: Restore use of /org.openoffice.Office.Recovery/AutoSave
        
        ... instead of respective values from /org.openoffice.Office.Common/Save/Document
        
        The history of the problem:
        
        d0f9685d2cfc3927add412b276c804dcc20cb6a5 (2004-11-26)
          made SvtSaveOptions use org.openoffice.Office.Recovery/AutoSave,
          *in addition* to org.openoffice.Office.Common/Save/Document/*,
          as "forward AutoSave/AutoSaveTime to new config location" part
          of i#27726; at this point, org.openoffice.Office.Recovery/AutoSave/*
          took precedence (they were read last).
        
        8e6031e126782ced6d7527b19cf817395e9b63e4 (2004-11-26)
          implemented autorecovery.cxx, already reading
          org.openoffice.Office.Recovery/AutoSave/*
        
        d5b9283985633fdb423269cab961bba2acc3539e (2021-07-25)
          made SvxSaveTabPage and SfxApplication::SetOptions_Impl use
          officecfg::Office::Common::Save::Document::* instead of
          SvtSaveOptions.
        
        134f40136a9bea265d8f2fedfdb41a1e65d81b49 (2021-07-25)
          dropped SvtSaveOptions_Impl::ImplCommit, and its saving of
          officecfg::Office::Recovery::AutoSave::* (which likely
          detached officecfg::Office::Recovery::AutoSave from
          officecfg::Office::Common::Save::Document, making UI edits
          not stored to the former).
        
        aeb8a0076cd5ec2836b3dfc1adffcced432f995f (2022-05-23)
          made AutoRecovery::implts_readAutoSaveConfig read
          officecfg::Office::Common::Save::Document::* instead of
          proper officecfg::Office::Recovery::AutoSave::*.
        
        This change restores the intended use, and deprecates corresponding
        values in /org.openoffice.Office.Common/Save/Document.
        
        Change-Id: I33d48e3945326c80d356bfc930ed8a7f042c982b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154500
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-17  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [71f2aea3151b82ba4793eb21a2251d587e425511]

        sc : small simplification in ScXMLTableRowCellContext::IsPossibleErrorString
        
        Change-Id: I3c5bd6b53528b1cc1d695fb48f89b6f19f5c0f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150532
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [bb7387236a9fe19656e86de6d00d02beceb7d84b]

        Simplify a bit
        
        Change-Id: Iaf09fd3ad3587cdd7079c70785cdee6ea52b247e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154531
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5c97c320338da4bb33ea3cf2479079923d8723e3]

        Simplify a bit
        
        Change-Id: I20e7c1082687d780eded364f2620dd0dcbe831ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154532
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-17  Julien Nabet  <serval2412@yahoo.fr>  [77a2fe5a649d089d7c09c5558c42c2ea38116fd7]

        tdf#118817: add WEEK, WEEKDAY, YEARDAY AND MILLISECOND for EXTRACT
        
        Change-Id: I912e9c2f8394f487dc3753d653f5a9ba19d7f416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154524
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-17  Michael Stahl  <michael.stahl@allotropia.de>  [faf2d9e2cb13c3750ac359338f8f31fc1afce368]

        sw: handle sequence of sections containing only table
        
        SwNodes::FindPrvNxtFrameNode() still relies on the special-case code at
        the end to handle this situation, which exists only in the forward
        direction, and since commit af4e20426ad24c6f2c0164b37472f2b7b54ecd30
        there's an assert which is triggered by forum-de3-11230.odt
        
        Add the handling to the loop, both backwards and forwards.
        
        Change-Id: I79702653ec6fc27854f664c2a41c02f9c97edff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154553
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-17  Mike Kaganski  <mike.kaganski@collabora.com>  [8362ec6646df330629b1c6c2e28b634487d55612]

        Small simplification
        
        Change-Id: I36bbdb48f0fa0d81e7ba294e9ac01b0d187e4800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154462
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-17  Hossein  <hossein@libreoffice.org>  [4ea4ce78d116757638b08a389d9c509c523085f3]

        Remove leftover debug code
        
        This fprintf was leftover from 1653bb9bffaa84a40b7d81a8277e887ea28df4e4
        which came up with attachment 94167 from tdf#75059 in terminal output
        with just opening and closing in the official 7.5.1.2 binaries.
        
        Change-Id: Ib04b5f6dd3426e97a14b3c6f38b68481f1bf85b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154518
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-07-17  Michael Stahl  <michael.stahl@allotropia.de>  [2c524ab87e336418c3ee7370f76284a53dff1c82]

        solenv: gdb: BigPtrArrayPrinter, try both 0 and 0ul
        
        Apparently commit ea858ca92488309789e83666681a358af1d9f6f6 broke it on
        Fedora 38, where i now get:
          gdb.error: No type named std::_Head_base<0ul, BlockInfo**, false>.
        
        So try both variants.
        
        Change-Id: If344077df7a6b329286bc1296446562301305946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154525
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0821457cdb6476b2b1860c8aeda718b130ab808e]

        simply some LogicToPixel calculation sites
        
        Change-Id: I9698562dd1f8d4679c9999342ded1022bde698be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-17  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [da2e7b1e0b58aed20d44b7c588ee86d922d614a8]

        tdf#156030: sw: better import of IF field for RTF and DOCX
        
        Since long time IF field was converted to ConditionalText, but no
        parameters were given. So condition, then text and else text were
        lost during import.
        
        Change-Id: I9b45e8ab394f3c53bb34370bf3ea15a939a400fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154101
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-17  Gülşah Köse  <gulsah.kose@collabora.com>  [e73b2bc4e6fdaba3098fa2c701342e1df112514c]

        Prevent to open multiple Theme Color Edit dialog
        
        Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
        Change-Id: Ibf4db096b44ce941140a12d003b89b636f5e7224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154514
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-17  Julien Nabet  <serval2412@yahoo.fr>  [e43d5776fee7c89029389fcc3b8011d041033108]

        tdf#74934: remove Install button and related
        
        Change-Id: I7866f11e744f4159f1ff5fb5175ee7fe87bbf4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154515
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-17  Miklos Vajna  <vmiklos@collabora.com>  [a4af5432753408c4eea8a8d56c2f48202160c5fe]

        tdf#120262 sw floattable, legacy: fix text wrap around fly when no content fits
        
        The bugdoc is created from DOC (so tables are shifted to the left,
        slightly) and has 2 floating tables on 2 pages. Writer puts them to a
        single page, so they overlap, which is not wanted.
        
        The trouble is that there is some space (but not much) on the right of
        the floating table on page 1, and Writer wraps the empty anchor of the
        floating table on the right of the floating table, while Word puts it
        below the table, so no overlap happens.
        
        Fix the problem by extending the work from commit
        8f8b31abd02876c3601e343b8b3274754f8a61b6 (compatibility setting for MS
        Word wrapping text in less space (bnc#822908), 2013-08-06), and work
        with that limit in SwTextFormatter::CalcFlyWidth(). This way Writer
        keeps its behavior that PARALLEL wrap text mode requires no minimal text
        width for existing documents, but correctly ~300 twips minimal text
        width (Word formats).
        
        The bugdoc still has a footer vs floating table overlap, but at least no
        2 floating tables overlap now.
        
        Change-Id: Ib307ede08ead272fe16dca261db615fd8e9c547d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154509
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-17  Miklos Vajna  <vmiklos@collabora.com>  [107ab712725e92fc527b54e91f317f932b78146a]

        svx: prefix members of SdrCustomShapeGeometryItem and SdrFormatter
        
        See tdf#94879 for motivation.
        
        Change-Id: If7ca1e0117943f82c9ea46d6a6eb9ba9f67b1b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154507
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-17  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [d22ab7b444a4e16dc2bd1f7d15fa36a848eaaaed]

        xmlsecurity : simplify DigitalSignaturesDialog::canAddRemove.
        
        (!a && b) || (a && b) => b
        
        Change-Id: Iee9ae38d9dc5f6aa94eaff61b3937633f5da7af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154285
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-07-17  Sarper Akdemir  <sarper.akdemir.extern@allotropia.de>  [dc5163af166cb2afb9811dbf0443e1fcceafbb9a]

        tdf#90023: vcl: fix tooltip displaying over two monitors on Windows
        
        To determine the WorkArea correctly in ImplSalGetWorkArea,
        pass in the mouse pointer as pParentRect.
        
        Similarly to how it has been done on:
        vcl/win/window/salframe.cxx:1393
        
        Change-Id: I43123be315c5ea146c118e8e2a582ceaaab0a35e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154442
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>

2023-07-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2b3a950e937efe77ad39b034819c9f7a707fe29e]

        tdf#130581 - Add undo command for hide/show slides
        
        Change-Id: I7305e222df65fda6523940ca63f5759857c94bea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153375
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-07-17  Stephan Bergmann  <sbergman@redhat.com>  [182641750c7e5c968cbbc1fcb2e6b7ce60723c97]

        Simplify some UTF-16 string literals
        
        Change-Id: I434496b79a8d26e4ace4f3cb2be77bf71d5a93a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154439
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-16  Julien Nabet  <serval2412@yahoo.fr>  [07074836b0055a94c3ad9319e97e733b019c0519]

        Fix postprocess/README packimages.pl has been replaced by pack_images.py
        
        with 423ee1020afe1bca896f2ecfc67ffbd49db5081c
        tdf#106894 Rewrite packimages.pl in Python (pack_images.py)
        in 2017
        
        Change-Id: I337d4e048f59dd5f268930a7e51ab793d6008afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154503
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4251192ef5d10fa3595632ea665d86dcdd1fa947]

        SfxAllEnumItem::GetTextCount should return sal_uInt16
        
        To be consistent with its other methods (Get/SetTextByPos),
        taking sal_uInt16
        
        Change-Id: I1c6e7c9fcb8bb6bf57d4ed4481240e0c7b606049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154460
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-16  Laurent Balland  <laurent.balland@mailo.fr>  [6fc12ad600a1ee10253c269a5988907a2894be76]

        tdf#155526 Remove Insert R2 in all cases
        
        When opening a file containing a Moving average trend line,
        addRegressionCurve is not used, then MayHaveCorrelationCoefficient property is not
        correctly set.
        This change modify this property in all cases.
        Update property in firePropertyChangeEvent() as it is not possible in
        constructor: JunitTest_chart2_unoapi fails in MeanValue as SolarMutex
        is not owned
        
        Add QA test
        
        Change-Id: I13bdb81239a7362431edcf28bfc38ac4820a7776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153859
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [82bb3a9a5a0f347a0b2c204605c11b82c2a77840]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b56d161eacb262bc492d414f382f620a96bffc7c
          - Document new Echo method in SF_Document service
            
            Change-Id: I89cdd33d1710f17a54d0f0a0b3078153b991a3f9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154183
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dcc9d50fe04c592e7301d72e18e5da34dfcc2d86]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2a891305f3365fa516379a2485201578c53c8b37
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 10)
            
            Change-Id: I21c3e4c80e395400fb5999401c47c42a83609ae0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154495
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf8dd90f503a4981beca29566f12b9cfaf131425]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c9e087cbb4aa8fde2259b40d9223abb667cec66
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 9)
            
            Change-Id: Ie32aae35987ab98bb9ec8c1e14b04fddd4662645
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154494
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [80c5cb83c004b28c2c7d9c42576be6db3c70a9b0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8efe6cbfa9f6a6de6df6512856c1ff0f429c0de
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 8)
            
            Change-Id: I7e8f81b709cf53369bea042748cbc64b3dd79474
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154493
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-16  Dr. David Alan Gilbert  <dave@treblig.org>  [ab42fe0c09a4f5fefe9ba46b3be11dff4deff472]

        editeng: Use RotateAround rather than another copy
        
        Replace lcl_ImplCalcRotatedPos by Tools::Point's RotateAround.
        
        Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
        Change-Id: Id1d8baebafb019f1bc574acc71078150442f20dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-16  Dr. David Alan Gilbert  <dave@treblig.org>  [80b4e90e055825e3fef6fa11796bf4f40627c478]

        editeng/Outliner: Use RotateAround rather than open coding
        
        In PaintBullet, use Tools::Point's RotateAround instead of open coding.
        
        Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
        Change-Id: I4f5a50a70d8fcadd2e5af60e365de80f2e9a271e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-16  Dr. David Alan Gilbert  <dave@treblig.org>  [38372f103aa5035ec32570972e55656e07647791]

        editeng: Use Tools::Point::RotateAround instead of our own
        
        Remove our own Rotate function by calls to Tools::Point's
        RotateAround method.
        Add a comment on RotateAround to emphasise that the point rotated
        is the parameter and the This object is used as the origin.
        
        Using TOOLS_DLLPUBLIC to fix link error (as suggested by Arnaud)
        Added tl to slideshow (from Neil)
        
        Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
        Change-Id: I296bbdf910d262401bfa18f0fc4f431b9e79b8f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-16  Julien Nabet  <serval2412@yahoo.fr>  [5ae47ac0a750dd7220c74daa4bdcd5a3e92924f7]

        cid#1537992 deadcode
        
        since 16b0da38515467bf1819ccd88027934481cc5727
        jsdialog: encode properly control characters
        
        Change-Id: Ic447a819d3d0b3f9ff66e00f0b05a037ec53a9cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154488
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-16  Julien Nabet  <serval2412@yahoo.fr>  [a0d12dcb83e75c33d0fa6c64d4f749ef8baa1b1e]

        cid#1538310 useless_call
        
        since:
        3cc198a0706b25c42cc8dae7e25635cbd911ac02
        sc: remove duplicated table validity checks and other duplications
        
        Change-Id: I1d86a73f7d16e83f900c58f9a54291b0c3274092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154487
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4df9c056de4930eea42a2bfe45075413a45dbf5e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d43b773eb9e3e3fd45c627f83d9f57a926ae411
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 7)
            
            Change-Id: I1baff8eeba2fec2783d4deadb1989184004aa848
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154479
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2bf90e900b99adb05d0dcffbf5482ff3d7018582]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3606293451c58ee9b279837041875dcbcc4ad54a
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 6)
            
            Change-Id: I87171ec6d514a1bb6fa1794fbd392f4a4799741a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154478
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [83652130589f933b4492b9822472472615fc5d7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bb0eda82d211a47996b37fb0f900b32c49ff9074
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 5)
            
            Change-Id: I8cb0963532936b5b20ede6a36d49d693f3434068
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154477
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [83a169d04aca94f6f2a5b6ef9fdfba3c0fc4ede3]

        Fix typo
        
        Change-Id: I04d3440d121e6305b3435964b88d221bf4bce221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154486
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1c22e2e6561a23a6a19b54c3c986d3ef040575f0]

        Fix typo
        
        Change-Id: If33699080b8f56998416b87db1e75e91b0ed18ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154485
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [38b7754d5ead0b43443acd9ef2cd956b94dad88b]

        Fix typo
        
        Change-Id: I62c3e5394e52591df08e2f6acd826718dc1a0cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154484
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eb6da4a089ee58e1237a3b764d1e05c00b9f9f9b]

        Fix typo
        
        Change-Id: I5e1093f05a9916991304a178a73d81c073883479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154483
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9e332f41250e21d692e9b5464206a67e2267d0c7]

        Fix typo
        
        Change-Id: I7a1afd67e976abe504f859f0f5561ac5ebc6df98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154482
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [47a0a8d87023b6cf4e98eb3a5b1989d6d28153d6]

        Fix typo
        
        Change-Id: If692d47efd95e3383734b91ea72d4d665503b3d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154481
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3e3e9d6db03cea5751c6a7ed55da47fd9bda087f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8cde1df1a991d749d185144f57a8feb8df8f04aa
          - Correct access for Direct format spotlight.
            
            Change-Id: Icbe7b1432b5f803b9adba0afc9b07670c0dc7a87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154458
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-15  Jean-Pierre Ledure  <jp@ledure.be>  [44334328f75dd0023122a4cb446ccba0d507720c]

        ScriptForge (SF_FileSystem) support document(s internal file structure
        
        1. The SF_Document services (document, base, calc,
           formdocument, writer) receive a new FileSystem
           property that returns the "root" of the
           component's file structure under the format:
              "vnd.sun.star.tdoc:/XXX"
           XXX being the document's identifier.
           The implementation does not use the RuntimeUID
           (UNO property of the OfficeDocument service) which
           is optional and, f.i. not present for Base documents.
           Instead the
            css.frame.TransientDocumentsDocumentContentFactory
           service is used.
        
        2. The SF_FileSystem and SF_TextStream modules have been
           reviewed to support the new context.
           Next restrictions have been met:
           - The FileNaming property is always cnsidered as 'URL'
           - CompareFiles() is not applicable
           - GetFileLen() always returns zero
           - HashFile() is not applicable
           - Normalize() always returns the input string unchanged
           - PickFile() is not applicable
           - PickFolder() is not applicable
           Additionally,
           - CreatetextFile()
           - OpenTextFile() in write or append modes
           copy or initialize the file in a temporary storage
           and write it back in the document when it is being closed.
           The process is transparent for the user.
        
        3. The GetTempName() method accepts an option
              Extension
           argument, for better convenience.
        
        The new functionalities are available in Basic and Python.
        
        Changes require an update of the help documentation.
        
        Change-Id: Ibf8dd9983656923cf6ab43d9f48398dc4d1e6307
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154443
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-15  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [ddb483509113e469b771320fea52f1b089574021]

        Resolves tdf#156182 - Automatic text color unreadable with darker cells
        
        Change-Id: Ia5e405fc05613726b5011174c8d00ca204eb31b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154352
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-15  Patrick Luby  <plubius@neooffice.org>  [693411e60c6bbd1c2ef25490cc3902f6b2461682]

        Related tdf#155125: add MacPorts to GPG's fallback search on macOS
        
        Change-Id: I52a5031b531dc542b2eea72191a1c240f78820bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154474
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-15  László Németh  <nemeth@numbertext.org>  [e4ae409b8e57f5efe53af7bacd08b0d226a0d96f]

        tdf#156286 sc: fix crash with column deletion
        
        Skip negative indices, which caused the crash, when
        more columns were deleted, than the remaining columns
        before them.
        
        Regression from commit dd8e061406fac581d399da088c7f0187278035dc
        "tdf#153437 sc: fix broken formatting without performance regression".
        
        Change-Id: I223e2fbb321fc4bd2ddb7a67a16a64c69e1e7872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154445
        Reviewed-by: Czeber László <czeber.laszloadam@nisz.hu>
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a051601a4cef506bc257c647cbce6288ba8068d4]

        Use SwAnchoredObject::RegisterAtPage
        
        Change-Id: Icdc8266656bea5b44ce744457ad6a1d0ba87c473
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154447
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-14  Justin Luth  <jluth@mail.com>  [65db5b6a34c4cb781e7a9ab813801a0e0d114da5]

        tdf#71550 autosave: remove empty, new file on failed autosave
        
        before throwing and losing any control.
        
        Change-Id: I2340c6f08bae116f3c1a390bccca2075c047a737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154446
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [c9af660cd26e39a6d933dd862fd6630c4055c91f]

        tdf#156287: don't try to move objects to pages other than their anchor
        
        Objects may have offset moving them outside of the current page, where
        their anchor is. This doesn't mean that they would move to another page,
        just that they will be clipped.
        
        Without this taken into account, objects which rectangle would be on
        another page, would trigger infinite loop because of their position
        invalidation in SwLayAction::FormatContent's cleanup code, where they
        will move to their correct page; and then their off-page rectangle
        would move them to another page again.
        
        Change-Id: I2b818403163041a49a3bc1640b1af9a1705fd671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-14  Michael Stahl  <michael.stahl@allotropia.de>  [4270552395600487f9d680cfdc9cd0ad6f457497]

        tdf#156267 sw: remove DdeBookmarks in SwDoc::DelTable()
        
        On Copy, a SwTransferDdeLink is created, which also creates a
        DDE_BOOKMARK (it's the only thing that does that) without Undo.
        
        On Delete, the DelTable() creates SwUndoDelete which creates a
        SwHistoryBookmark; then the DeleteAndJoin() deletes the DdeBookmark.
        
        On Undo, the SwHistoryBookmark doesn't find its bookmark, and crashes.
        
        Because the DdeBookmark is artificial and deliberately created without
        Undo, DelTable() should prevent the SwHistoryBookmark by deleting it
        first.
        
        (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
        
        Change-Id: Ib24c788a49a6fee364b44a1dbc8d53870c074596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154440
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b573006f3d268d3e31c9b4f740ff4d0ad92a2371]

        Fix typo
        
        Change-Id: Ic994555b5d9c87260a4a76b76deb60a5ab6c4bb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154441
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ab8dc5628499b47a065ed2ba54cdd4a90ca43a0]

        simplify calculations in SeriesHeader::SetPos
        
        Change-Id: I0a3afe10dec530a6d7ddc32cf7d96ec5095604c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-14  Justin Luth  <jluth@mail.com>  [b6f3129569c22d9d139ca712dcf0db6dc2041565]

        tdf#143038: preserve extension on backup file
        
        This allows knowing what kind of backup this is,
        as well as allowing the same named document
        for every kind of file format to be retained in backup.
        
        Change-Id: Iff22802d73adad351cb129b402db7567f0af7c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154407
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a22f1aa4ff46328327d209e524300d8bfe464511]

        Simplify the logic a bit
        
        At least for me, it's easier to understand it this way.
        
        Change-Id: Ib66d4163c85263971e93390161c37614c0e5d87b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154436
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-14  Michael Stahl  <michael.stahl@allotropia.de>  [d467f1aa3d028f399826c97e2eecedcd79efcf65]

        tdf#154982 drawinglayer,svx,sw,vcl: PDF export: hell flys and shapes...
        
        ... should be below their anchor paragraph in the structure tree.
        
        Refactor SwEnhancedPDFExportHelper (etc.) to use the new
        EnsureStructureElement()/InitStructureElement() functions instead of
        SetCurrentStructureElement() for the frames, and allow it for flys that
        don't have their anchor paragraphs created yet because the hell layer is
        exported before the document body.
        
        Change-Id: I1be3b54002e8196772e6f9d81dd0fd0c85b6e34b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154399
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-14  Michael Stahl  <michael.stahl@allotropia.de>  [07d790ca473cd6e71f0343419b819fa6b485dc01]

        tdf#154982 vcl: PDF Export: split BeginStructureElement
        
        ... into 3 parts:
        EnsureStructureElement/InitStructureElement/BeginStructureElement
        
        So EnsureStructureElement and BeginStructureElement/EndStructureElement
        can be called multiple times for the same object, passing in a unique
        key and PDFExtOutDevData will only create the element once.
        
        InitStructureElement will be used exactly once for each object when its
        actual content is exported.
        
        In PDFExtOutDevData rely on the indexes being the same here and in
        PDFWriterImpl, because then only PDFExtOutDevData needs to maintain the
        map from key to index.
        
        Change-Id: Idea6e34627fe559038cf13cf01dafe84b759e3c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154357
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-14  Michael Stahl  <michael.stahl@allotropia.de>  [9a148e4fb402d203ab0d2683dc316aa8217b576c]

        tdf#154982 drawinglayer: post-order traversal of ObjectInfoPrimitive2D
        
        For the signature line, the wrong alt-text is exported to PDF, because
        the cui/source/dialogs/signature-line.svg contains lots of "desc"
        elements, which are converted to ObjectInfoPrimitive2D, and currently
        these are applied after the ObjectInfoPrimitive2D for the SdrObject.
        
        So let's try to switch the order, fixes the bugdoc at least.
        
        Change-Id: I7b5f6f4e68a3421ab33d7780995080deb6cf2238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154308
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-14  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [79ebf2c887411345709e11465d0c81b7b9e04d66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ee33ab728cf9633b24ef3d68514fd55047d06088
          - correct heading levels for Direct Cursor options
            
            Change-Id: I766a7e3435404ec1d60d79794b7273fcd5dcf880
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154412
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-14  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [bcdc0ba6caf5d2f98336dba9f894214d24dfeef3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80e08b87acad5fa3b5cf4b452cdcbeb4d03b1326
          - correct software names for PGP on macOS
            
            Change-Id: I5d9295c196dadbd71a932b54da65a63516112cdf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154329
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [538d3e8d7ff08ea9287c4808b71ef4362cc54b98]

        fix ubsan
        
        after
            commit e40f69419e86fb9d189032410686c5c06efbdbbb
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jul 10 18:33:52 2023 +0200
            use more frozen
        
         =================================================================
        ==27441==ERROR: AddressSanitizer: global-buffer-overflow on address
        0x7feaccd42aa8 at pc 0x7feacc86a5e7 bp 0x7ffc3e6e9390 sp 0x7ffc3e6e9388
          READ of size 4 at 0x7feaccd42aa8 thread T0
        /sc/source/ui/vba/vbainterior.cxx:103:58
        ScVbaInterior::setColor(com::sun::star::uno::Any const&)
        /sc/source/ui/vba/vbainterior.cxx:90:9
        ScVbaInterior::setColorIndex(com::sun::star::uno::Any const&)
        /sc/source/ui/vba/vbainterior.cxx:150:9
        
        Change-Id: Iee3667ae975caffdeb63149738daea5c1b8ae01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [64140e0e7f8a151f298568c9173364efca636a46]

        fix "incomplete type" type in skia build
        
        seen by ohallot on a Kubuntu system
        (gcc version 12.2.0 kubuntu 23.4)
        
        /usr/include/c++/12/bits/unique_ptr.h:396:17:   required from
        ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = SkImageGenerator;
        _Dp = std::default_delete<SkImageGenerator>]’
        /mnt/bigfast/git/lom/workdir/UnpackedTarball/skia/src/ports/SkImageGenerator_none.cpp:14:12:
        required from here
        /usr/include/c++/12/bits/unique_ptr.h:93:23: error: invalid application
        of ‘sizeof’ to incomplete type ‘SkImageGenerator’
           93 |         static_assert(sizeof(_Tp)>0,
              |                       ^~~~~~~~~~~
        
        Change-Id: I172bfd1aa063de2c283c7205637de58c47dc73fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154386
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-14  Stephan Bergmann  <sbergman@redhat.com>  [27d1f3ac016d77d3c907cebedca558308f366855]

        O[U]String literals (unusable for now, C++20 only)
        
        Change-Id: I0ecd1a8b60a01aefdf0139e3777dc006532764fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154434
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fb130a4982884bf88b6cdf91d9450016e272ddc4]

        check if pTable is null after FetchTable
        
        Change-Id: Ia1d208a329c46812e4a9e1d1412e2b69befa3d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154435
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3d8f4079dc31a0496f86dc2f80eee9ad60415f5]

        tdf#156271: add dx shift on top of x position
        
        Change-Id: I61263a7fec2ec8236221a10f8cb730899c878f5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154403
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-14  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [d86a6d2b47c6a22d185dc631388ca3f2c0386a35]

        tdf#153866: Fix TOX crash
        
        Im not sure why it should be valid that the ContentFrame should ever be
        nullptr here, but a simple check prevents the immediate crash.
        
        Change-Id: I19a2d04e41271ae6a5b6a3a79c31c3efd5db7875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154404
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-14  Miklos Vajna  <vmiklos@collabora.com>  [8bd30999098567b3bdb84a6ca65c071952192932]

        tdf#120262 sw floattable: don't wrap text around fly when no content would fit
        
        The document has 2 pages with 2 floating tables, but instead Writer had
        a single page with 2 overlapping floating tables.
        
        What happened is that most of the horizontal space on page 1 was used by
        the floating table, but out of the 10466 twips body width, 11 remained
        (after accounting for the floating table and its margin. Considering
        that the empty paragraph needs no space, the paragraph marker was
        shifted up, next to the floating table, leading to losing page 2 and
        overlapping floating tables.
        
        Fix the problem by checking if the remaining space has some minimal
        size: if it has no space to host any actual content, then shift the
        paragraph marker down (in compat mode), similar to what Word >= 2013
        does.
        
        Note this only fixes the "DOCX, Word >= 2013" version, the original
        bug DOC file still needs more work.
        
        Change-Id: I00864d9b3ae662cdf19fa63e004da1ee1cc7be7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154409
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-14  Miklos Vajna  <vmiklos@collabora.com>  [46d7119b8be03968017e59d882e5671350304e15]

        sw layout xml dump: extract SwNoTextFrame::dumpAsXml() from SwFrame
        
        Which means finally SwFrame::dumpAsXml() can be pure-virtual as all
        subclasses overwrite it.
        
        Change-Id: I5a8c5437bb64f6745653038105891e4fb6b54399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154397
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [4ded0e7c874e8b8052a2afa55c4cdaa0b5d095b8]

        gtk3 a11y: Map push button menu role to ATK equivalent
        
        at-spi2-core commit [1]
        
            commit ed16f50e4930e32c29f80552eb698baa35b4677e
            Date:   Thu Jul 21 21:49:32 2022 +0800
        
                Add `ATK_ROLE_PUSH_BUTTON_MENU`
        
        has added a `ATK_ROLE_PUSH_BUTTON_MENU` role
        (and `ATSPI_ROLE_PUSH_BUTTON_MENU` on the AT-SPI
        layer, note also pending related MR [2] to also
        increase `ATSPI_ROLE_COUNT` accordingly),
        so map LO's `BUTTON_MENU` role to that
        when using a new enough ATK version
        (available from ATK 2.46 on).
        
        [1] https://gitlab.gnome.org/GNOME/at-spi2-core/-/commit/ed16f50e4930e32c29f80552eb698baa35b4677e
        [2] https://gitlab.gnome.org/GNOME/at-spi2-core/-/merge_requests/146
        
        Change-Id: I9fbbc595245d212b8e79a80a1f82c363b2b402c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154387
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-14  Colomban Wendling  <cwendling@hypra.fr>  [d54a48c008dc9c9cf206d7c7dd37b8d2fdd4e86d]

        Add test case for tdf#155705
        
        Change-Id: Ib70bcd6ab8e269f21f7182e544490e6d19f2c940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154130
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-14  Matt K  <mattkse@gmail.com>  [b247630d8b5e81041e0ed515572dfede49ccdf46]

        tdf#150262 Split Autosum button and default to sum on click
        
        This change follows with comments in the bug report by
        changing the Button Type to dropdown and adding back
        the code to do the autosum on default click of the
        sigma button.
        
        Change-Id: Ibe7afa1c7b8346b6a6de5d1db8223dab17ee720a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154405
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-14  anfanite396  <dipamt1729@gmail.com>  [73367f09716f5709264885486a2bb03626d39884]

        Move SwXNumberingRules Java tests to C++
        
        Change-Id: I3f5b1b6ce5ed475ef923f2c605c6ada7d29e0439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154336
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-14  anfanite396  <dipamt1729@gmail.com>  [9460302fdda20fa83e795e84a9d8234ac78b0fd2]

        Move SwXFrames Java tests to C++
        
        Change-Id: I92276f7b0b6537ebf2c5b4d554be1759c09e9544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154299
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-14  anfanite396  <dipamt1729@gmail.com>  [979bdded307531f8b6a930a6515c675d9445de65]

        Move SwXFieldEnumeration Java tests to C++
        
        Change-Id: I6f1eb42e9284593bcc0db1934f3b14d090349d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154298
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-14  anfanite396  <dipamt1729@gmail.com>  [0fa8010a07c6e6fd7d3506087a417bf84e948e16]

        Move SwXDocumentIndexes Java tests to C++
        
        Change-Id: Ib764152762e55ba56df765f425b0f9254113c280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154297
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [3bf6ec92379a14ac97ccfff5c6d0ca14b70d7b7e]

        svgio: remove redundant check
        
        Change-Id: Ie507fb1bf06f75e2fd673864a9ee9046aeb19377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154401
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a177a4474b8c31f44741e2834df2c76ea8074aa3]

        tdf#142808: use SvxLRSpaceItem::GetTextLeft instead of GetLeft
        
        Because we need the value without the negative (hanging) indent.
        
        Change-Id: I65f779476be5e8a57b723c289c6c3a9c75875bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154398
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-13  Stephan Bergmann  <sbergman@redhat.com>  [bca5ba30e0bbfe04de652eb55d1a9ceac4be2b0b]

        Restrict deleted catch-all O[U]StringChar ctor to arithmetic/enum types
        
        ...which should still cover the issues that
        7320d7a4a4dd0657f2d650a6f580ad399529f0f1 "OUStringChar must either take a
        sal_Unicode or an ASCII char" wanted to address, but without causing ambiguities
        where some unrelated type would unexpectedly be sucked into a conversion chain
        going through these ctors
        
        Change-Id: Iee3769dc6af5d7a1c8540a548bc2e10a89e637da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154391
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-13  Justin Luth  <jluth@mail.com>  [0c421a9aa3210d3bafdc8bb5e0d79cc1b58b4b33]

        tdf#153446 sd FuText: handle mouse-up without mouse-down
        
        This is a follow-up to the previous commit which did the same
        thing to all of the other FuConstruct elements.
        It isn't essential to have for FuText, just nice for consistency.
        
        FuText is much more complex than the other FuConstructs,
        and has been this complex since initial import.
        
        In patchset1, I removed a large chunk of code that I assume
        is now obsolete with my change, but now I just left it in.
        Without any documentation or unit tests, it is hard to know
        for sure why this function creates a textbox on mouse-up.
        So I chickened out and did the smart thing of just leaving
        stuff I don't know anything at all about alone.
        
        Change-Id: I105178e6af343eed505a803c6c3642eec073f6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154083
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [1df7a1ac274db509f1a135b84a01ea51c4d0c1f9]

        tdf#156269: dx and dy do not depend on x and y
        
        Change-Id: I99be5aa45b333ec3825373c3a10be0e24d23cb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154380
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [99f5bf03caa2538ca79b04e7fd017cebfb4c7a95]

        Fix typo
        
        Change-Id: I852895d5867af94b2e5cf4a05b6d8e4080960b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154371
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [42f6dd4a22ed3c87ccd30b3e8007f4d614f86754]

        Fix typo
        
        Change-Id: I2a7613fbedf05b9d30695605ad9e568c0a77c0b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154385
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b9addab4426745fa484f0012814699e31d5239b3]

        Fix typo
        
        Change-Id: If127e00bab20839021afe82df555083bbae72ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154384
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-13  Patrick Luby  <plubius@neooffice.org>  [3c7b230910c95838d644d1d3971f2a656b64f635]

        tdf#155125 add "Encrypt with GPG key" checkbox in macOS native save dialog
        
        Change-Id: I85cdf71c1beaef51e8c66e30aa5b0c7de5f4b72c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154396
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [bfa25258d21430560584e3265cdd4629ee47a1b8]

        tdf#154035: use correct Which range including the new WIDs
        
        After commit db115bec9254417ef7a3faf687478fe5424ab378 (tdf#78510 sw,cui:
        split SvxLRSpaceItem for SwTextNode, SwTextFormatColl, 2023-02-24),
        aCoreSet is now querying RES_MARGIN_FIRSTLINE, RES_MARGIN_TEXTLEFT,
        RES_MARGIN_RIGHT instead of RES_LR_SPACE. Without the fix, it would
        return wrong state, and disable the respective item in the cases of
        SID_ATTR_TABSTOP_VERTICAL / RES_PARATR_TABSTOP, which disabled the
        ruler.
        
        Change-Id: I8ca4ce586b414cefe2be79ec0226ac7808a231d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154395
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-13  Rico Tzschichholz  <ricotz@ubuntu.com>  [55d62057c0ccd533af63b2a01edb0cddbd619721]

        vcl: Move include of <hb-icu.h> to the appropriate place
        
        hb_icu_script_to_script is used in CommonSalLayout.cxx only
        
        Change-Id: I1d8de8c420963b42623bb06a7f5e1f37986e1c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149935
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef609a580b3e1de7c39ef391bb5df92680a22f36]

        ImageMap::GetHitIMapObject can be const
        
        which removes an unnecessary const_cast
        
        Change-Id: I9ef2e7c8b87e15ebd04e8864bfdd322991d9af00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [deb9236d71dddbda6517bdc3a6f0911d38a77113]

        remove very dodgy const_cast in SvxIMapInfo::GetHitIMapObject
        
        This code has been here since
            commit 8a6861a404c082226b52df335e3b0046164e6432
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon Sep 18 23:16:46 2000 +0000
            initial import
        
        but it really does not seem likely that it actually wants to update the
        internal LogicRect of the svx object.
        
        Change-Id: If0523c1e353faf96ca70c6afb3c0125472ca256d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-13  Justin Luth  <jluth@mail.com>  [5eae366cbdfb4c2e9f7a9b88257d12c400831456]

        tdf#65509 - re-make visible userautosave config option
        
        This reverts LO 5.0 commit 4653c91a89cfe802754377bcdafc291526254a03
        
        It was hidden because the feature didn't work well.
        Many of the "stumbling blocks" have been removed since version 5,
        and many people - especially in this age of web apps - expect
        a program to automatically take care of saving their documents.
        So make the option visible again.
        
        Change-Id: I09e73b0c96df697b4dfb8b7705ca28191ce6f8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154389
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f896bbcffeccd27248f908d2628d03dddf83ea94]

        basegfx: replace typedef with a class B2ISize based on Size2D
        
        Change-Id: Iaf7d02bb236f81a38a67a1430a718b6c3c78efae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139708
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-13  Szymon Kłos  <szymon.klos@collabora.com>  [6086d896183a529d4a0b83d4862970c8f320b0aa]

        linking: api: use JsonWriter
        
        Change-Id: If5bf1897f1aef8db1672789cbee14b90cb96dc08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151959
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154378
        Tested-by: Jenkins

2023-07-13  Miklos Vajna  <vmiklos@collabora.com>  [52d265c0d2f2638c386475e58c3ee489ccd3f06c]

        sw floattable: fix lost floating table right before a hidden para from DOCX
        
        The bugdoc has a floating table, but that was not visible in Writer.
        
        What happens is that the table's anchor was hidden, so Writer was hiding
        the anchored table as well, but Word still shows the table in this case.
        
        Fix the problem similar to what commit
        79ddca4def81198e3eee42eca8aca42fef964c80 (sw floattable: fix lost
        floating table right before a table from DOC, 2023-07-05) did for the
        DOC import: if the paragraph has an anchored floating table and is
        hidden, then show the paragraph.
        
        An alternative would be to change how NS_ooxml::LN_EG_RPrBase_vanish is
        handled in DomainMapper::sprmWithProps(), but that would be too early:
        by the time we get the SPRM, there is no floating table yet. Another
        alternative would be to make sure floating tables are part of the
        "anchored object" list in DomainMapper_Impl::finishParagraph() (that's
        how shapes don't have this problem), but the anchor paragraph is
        finished before creating the floating table, so that would be again too
        early.
        
        Change-Id: I7df7e318b15e78ceb51474440923a80bfdc6054b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154376
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-13  Szymon Kłos  <szymon.klos@collabora.com>  [6532f77926154340c27131de452666788ca42e6c]

        jsdialog: enable Manage Changes dialog
        
        Change-Id: Ibc501dc595eba93adde7b635a5de1122b22c9651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153190
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154331
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8e4fb36a69d517bc5111d64d12b2c7df4f9791de]

        sc: add test for changing theme colors and undo/redo
        
        Change-Id: Ieaae64cd6cfd96b8c1627cf1c3935bc546a36617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154306
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-13  Noel Grandin  <noelgrandin@gmail.com>  [e40f69419e86fb9d189032410686c5c06efbdbbb]

        use more frozen
        
        Change-Id: Ie3e6e7e947d9322f3999cf3274a6c10ea717afe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-13  Miklos Vajna  <vmiklos@collabora.com>  [5ae9c5f365c7d6f3a37c604e9721d3e964154f91]

        UITest_statistics: use oneprocess mode
        
        Before: 2m44,678s
        
        After: 2m2,724s
        
        Also UITest_textToColumns: 1m30,542s -> 1m1,339s
        
        Change-Id: I25c176ffde5cacfb9c610709dc3e4e6fdddf0c84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154368
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-13  Szymon Kłos  <szymon.klos@collabora.com>  [a2528102bfc2e51aefe1ac99d5ead438b8e121d3]

        lok: sidebar: send full update only when changed panels
        
        we only need to send update when:
        - we switch to other deck
        - panels were hidden, shown, created
        
        this helps to avoid full updates in navigator when
        clicking on images, what causes context change
        
        Change-Id: If1bca6167cdc3e9294eb5aefb923e92bc9043edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153401
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Tested-by: Attila Szűcs <attila.szucs@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154360
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-13  Szymon Kłos  <szymon.klos@collabora.com>  [642a628355f2bcfc45b829e7763b69351324634f]

        jsdialog: formatted spin field
        
        Change-Id: I5830dd523e0ccc736a686f38319a6c509e5650be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154193
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154363
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3cc198a0706b25c42cc8dae7e25635cbd911ac02]

        sc: remove duplicated table validity checks and other duplications
        
        Remove the duplicated table validity checks and replace them with
        FetchTable(..) call, which returns nullptr if the table is not
        valid and available, or the table itself. This simpifies the code
        all around.
        
        When only the check if the table is available is needed, use
        HasTable(..) in those cases.
        
        The call TableExists(..) is identical to HasTable(..) and has been
        removed.
        
        Finally use GetTableCount(), which return a SCTAB type for the number
        of tables is used instead of static_cast<SCTAB>(maTabs.size())
        that was used all over the code.
        
        Change-Id: Ibfd9777b1350ba8e0cbe577783db81589f95591c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154225
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-13  Justin Luth  <jluth@mail.com>  [d36ae6786e05deda7e78338d36624af371e7a3ed]

        tdf#65509 apply new AutoRecovery timeInterval without restarting
        
        Another option would be to listen for config changes I guess.
        
        However, this alternative method of setting the timer interval
        (which I assume is related to Impress slideshows, but couldn't reproduce)
        is basically never used.
        
        At worst (in case this alternative method sets a non-zero time)
        it will be the same as before where a restart is needed to
        gain the new time.
        
        I'm not worried about having the user wait for the current
        timer to run out (in 10 minutes based on the default state)
        before their new time kicks in.
        
        Change-Id: Iaa2b9e3e0912918ae29aaf262b5d7f51924b8147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154365
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Patrick Luby  <plubius@neooffice.org>  [dd1d74281a119f076e58598c8e022ee30232e5bf]

        Natively draw to pixel buffer with RBGA pixel format in iOS app
        
        Change-Id: I31917f914ed22bebffc52777cb974224d08bed83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154367
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 272de6ec30021fdbda38a1bd84a3036a0afc73d6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154325
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [5079e7937ef471a44dcf119dc6ae0a334d9c6adc]

        tdf#156251: Add gap between text elements when needed
        
        Partially revert a42f5faac7c6d4590e632cf40e3ba9eb618e6f56
        "tdf#103888: Do not add a gap at the end of each text portion"
        and adapt code to keep tdf#103888 fixed
        
        Change-Id: I4b3f1ff7d87b1945233d9b05824d58af1e001d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154364
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-12  Justin Luth  <jluth@mail.com>  [24e02d55b7602f0f3bc74656ecec54635ab09f96]

        related tdf#148121 no custom notebookbar.ui file unless modified
        
        Copying the default notebookbar.ui into the user folder
        means that any future changes in future versions of LO
        will not be seen by the user until they again reset the notebookbar.
        
        Only if the user actually makes a modification
        should the file be created in the user's config folder.
        
        Certainly just opening tools - customize - notebookbar
        should not condemn the user to be stuck on some old
        configuration of the notebookbar.
        
        Change-Id: I888867a8df452ddce0b2b75ec28f2698ab7d443f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154220
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Justin Luth  <jluth@mail.com>  [c2a77967cf16a9465f86b5aed62497141fbef535]

        tdf#125504 SvxStyleBox: don't use disposed DispatchProvider
        
        .uno:StyleApply in the notebookbar was doing nothing
        because the view switching from print preview caused
        the saved XDispatchProvider to become disposed.
        
        Thanks to Maxim, my patch is completely re-written.
        
        Change-Id: I655c393def75f966a97ac7a04395aee19befd132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154196
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Justin Luth  <jluth@mail.com>  [24c04a2c13c2bf110c4b600f03236c35a5ddfd14]

        tdf#125504 SvxFontNameBox: don't use disposed DispatchProvider
        
        .uno:CharFontName in the notebookbar was doing nothing
        because the view switching from print preview caused
        the saved XDispatchProvider to become disposed.
        
        Thanks to Maxim, my patch is completely re-written.
        
        Change-Id: I5ac1aa870de2f4ac922f076a5401f1264d6b085f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154195
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Justin Luth  <jluth@mail.com>  [634e13e9d6d9bbe2d051978538c02926f764e51b]

        tdf#153446 sd fuconstruct: handle mouse-up without mouse-down
        
        The situation where this was happening occurred when the notebookbar
        had a pop-out of additional functions available. This pop-out removed
        the focus from the draw window, so the mouse-down was used
        to regain focus in Draw. The mouse-up just needed to be absorbed
        or else the "drag the shape to create" would be changed into a select.
        
        I checked as many "situations" as I could possibly have conceived of
        after reviewing the code in this area. The ones I know I need are !bMBDown
        and !IsAction(). The rest are just to try to avoid getting me into trouble.
        
        [FuText also could benefit from this,
         but that function is much more complex,
         and so I don't dare to interfere.
        
         It already does BegCreateObj on a mouse-up,
         but the textbox it creates is hard to notice.]
        
        Change-Id: I4ed2564e81d8a7ce82e7edec43e4e9acc6e97760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154069
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5a6b938d324798433298ec7320c813c82ace4590]

        update credits
        
        Change-Id: Ie5565acd9f6acdda012fb64ac0d43de3a375135c

2023-07-12  Szymon Kłos  <szymon.klos@collabora.com>  [80f96e0aad80d425e3a54ad46193be3655eb29be]

        jsdialog: calendar widget
        
        Change-Id: I5b2b8a1516ed2e851309dca6ef3200ed522d1b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154136
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154361
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3996eed1870ced736d9f4a01550f5c9f0568edfa]

        tdf#105362 better support for transparency in PNG & GIF export
        
        The granularity to decide at the SdrView what to paint was not
        fine enough, so I added code to get what we need: Do avoid
        page decorations (including PageBackgrund aka 'wiese'), but
        do include/process MasterPage content.
        
        Change-Id: I49df05abc89b4bcebc973c37d30be0a0c72e59ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154301
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-07-12  Miklos Vajna  <vmiklos@collabora.com>  [54a36dd93a97fb6f5d25e1dbdbe1ef95a7cbaf52]

        CppunitTest_sw_layoutwriter: fix unclosed component in testTdf109137
        
        Is meant to fix this warning at the end of CppunitTest_sw_layoutwriter:
        
        warn:vcl:25875:25875:vcl/source/app/svmain.cxx:469: DeInitVCL: some top Windows are still alive
        text = "" type = "14FloatingWindow", ptr = 0x636cff0
        text = "tdf109137.docx — LibreOfficeDev Writer 24.2 [ad8be98155e24a8d15948be493580df9eb2e56f5]" type = "10WorkWindow", ptr = 0x7d82920
        
        Change-Id: I7a0a53c8a9aca0ed6e0eb04107c523be7cc23535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154359
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-12  anfanite396  <dipamt1729@gmail.com>  [23e25ed6c053a1bca6733c3ab05daca9ba28727e]

        Move SwXStyleFamilies Java tests to C++
        
        Change-Id: I1a399f33e71d05506b86b66c5ac15a9fe1106cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154347
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-12  anfanite396  <dipamt1729@gmail.com>  [c6397c905ac2ef9cd0eea488aa0da814b36f08fe]

        Move SwXChapterNumbering Java tests to C++
        
        Change-Id: I891f74f73b18cd0ccc3b45e455913da292e558a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154275
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-12  Miklos Vajna  <vmiklos@collabora.com>  [d59704b6b8c7e5395c0606fa01f37392afc4b2cd]

        cool#6857 sw floattable: try harder to keep anchor text in the last follow
        
        The bugdoc has a single floating table, spanning over 6 pages. Loading
        results in a layout loop, SwFrame::GetNextFlyLeaf() never finishes as
        the last follow fly has no anchor, which should never happen.
        
        The root of the problem seems to be already on page 3. The 6 fly frames
        are meant to have 6 matching anchor frames, where the offset of these
        text frames is all 0, i.e. the anchor frame's text goes to the last
        follow, since commit 73bada774ef37efd5a4498ccc083b1358314557d (sw
        floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 3,
        2023-04-26).
        
        Fix the problem by improving SwTextFrame::FormatAdjust(), so it never
        sets the offset of a follow anchor frame to non-zero when the current
        frame has a non-last split fly. All the negative fly frame heights and
        the final layout loop was a result of this.
        
        Note that there are still calls to ManipOfst() on the follow frame after
        this, but all such calls are from SwTextFrame::RemoveFootnote(), and
        that always just sets a non-zero offset + restores it, so that is not a
        problem for us.
        
        Change-Id: If62a1e2690cffed2de0be047ffb741d524532dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154343
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-12  Pranam Lashkari  <lpranam@collabora.com>  [f5dbb93f102033b552ecfc0b959b45c1e9b3bacb]

        jsdialog: enabled readonly content warning dialog
        
        Change-Id: I12e9af2e55902862df557ea4fe36a7463d6a95f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149277
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154330
        Tested-by: Jenkins

2023-07-12  Miklos Vajna  <vmiklos@collabora.com>  [a0471ec6e9a000a4985af2ad2967498c71004085]

        xmlsecurity: fix deadlock on preloading libsdlo.so
        
        The trouble is that calling into the configmgr would require recursive
        access to the service manager, but that's protected by a non-recursive
        mutex.
        
        See
        <https://gerrit.libreoffice.org/c/core/+/153798/24#message-b04c747da2cb73230d88ec65cc8207ac8b124dda>
        for details.
        
        Change-Id: If75779a995c2ad8855073bd6538832a18953d4cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154356
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-12  Stephan Bergmann  <sbergman@redhat.com>  [6716b9a8ddc255f3d2fc28591c36b16b59e7b9a6]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/2420296977a9aac805f2fcba88e0a262ba45ccce>
        "Update krb5-1.21.tar.gz to 1.21.1 (#248)"
        
        Change-Id: I6c931f0c25cbd866f9c643dd952fb9945e56271a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154355
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [972aea543ef94066946dedd6cf6890d34869d89c]

        simplify
        
        Change-Id: I276ba7809b08a359b377ea56259140675c5e00a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [1afe0df7f3a8d19a034257dcd68e182205dfc649]

        sw: getTestName() can go
        
        after
        commit 54d69f55d13ec39e1b2a2a6883b98cd23c6609a4
        Author: Miklos Vajna <vmiklos@collabora.com>
        Date:   Tue Jul 11 20:11:25 2023 +0200
        
            CppunitTest_sw_htmlexport: clean up not needed reqif part of preTest()
        
            All reqif tests set the filter options explicitly already.
        
        Change-Id: Ib7962578ddb2ce002910868c6d6f85ae4a1f6c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154353
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [d706f5dc6872b94859444f1cacb31d89e0fb840f]

        Simplify a bit
        
        Change-Id: Idd3e96d99f13b1e87e2a01de9c9392ead0864de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2dc9b2d8404ac467bb74b5db423c84a249381bb]

        fix missing typeinfo for SkImage_Base in ubsan build
        
        Change-Id: Ic17d45a93f521920fb45fbc5e88819b65638b4a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154351
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [375d423573cf237fb082ed2b4908d8067036d8b2]

        Simplify a bit
        
        Change-Id: I452619c5a1d0b414f09c1e3178fac9905b6d0374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154349
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [8d03f1d83d4ca561c11463325f16d7520a36df32]

        svgio: re-implement to use virtual function
        
        kudos to Mike Kaganski for the hint
        
        Change-Id: Iea58a31ffa481c4d9579a31f045f2a73d30ad883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154344
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-12  Michael Weghorn  <m.weghorn@posteo.de>  [bc662b15bf56bd405cb86e592e4ade9917ab49d1]

        qt a11y: Check child index in QtAccessibleWidget::child
        
        Check the child index is valid. Otherwise, calling
        the method with an invalid index would result in a
        crash due to a com::sun::star::lang::IndexOutOfBoundsException,
        e.g. when manually using an invalid index in Accerciser's
        IPython console:
        
            In [12]: acc.get_child_count()
            Out[12]: 3
            In [13]: acc.get_child_at_index(3)
            In [14]:
        
        Change-Id: I95f680a5ac6ee1052f3046a83000fa5b07009239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154345
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a5efa490b09f966e3d863ab948fc1608ba863899]

        Fix typo
        
        Change-Id: Ie93cc4651f51cc239d3a739c76a71c79b9c3dfad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154338
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-12  Miklos Vajna  <vmiklos@collabora.com>  [54d69f55d13ec39e1b2a2a6883b98cd23c6609a4]

        CppunitTest_sw_htmlexport: clean up not needed reqif part of preTest()
        
        All reqif tests set the filter options explicitly already.
        
        Change-Id: I50e437c9922feaff94ce331df416114e25ac6aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154339
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [94e6049b6467d9bc1e52a1a80c7cf1a5f138e82d]

        Revert recent LanguageTool commits
        
        Reason for revert: See discussion in https://gerrit.libreoffice.org/c/core/+/154302
        - it's causing CppunitTest_sw_layoutwriter2 to fail on Windows.
        - it's causing CppunitTest_sw_layoutwriter to fail on Linux.
        - Probably other recent CI failures are also related.
        - A similar commit was reverted one year ago for similar reasons -> https://gerrit.libreoffice.org/c/core/+/135859
        
        This commit contains the following commits:
        
        Revert "lok: remove old hack for LanguageTool locales"
        
        This reverts commit 9a5329a266bd74abc4794f1fcbae3db07582dbde.
        
        Revert "lok: LanguageTool provides list of languages"
        
        This reverts commit 21d0489a5efa970e975ce1a70dfda2fd9e2c186d.
        
        Revert "lok: remove duplicated locales for LanguageTool"
        
        This reverts commit a0865169ab62508a7b933ed4634defa57b25f7b7.
        
        Revert "Load the locales from config file for languagetool"
        
        This reverts commit 81b0d9a951c9b15f4f1a76d45d0bd955b4dfc95b.
        
        Change-Id: I3dc48097615f510e33e233e868b6b10704d81e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154342
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-12  Szymon Kłos  <szymon.klos@collabora.com>  [e78f60a369146774ca2a38ca121f294b562b2be5]

        Categories for link targets in Impress
        
        Writer and Calc presented possible link targets inside
        documents as a Tree, with items under their categories.
        This patch makes the same for Impress so we don't mix
        master pages with regular pages.
        
        Change-Id: Ifd98300b0d609c28d6c1880332fff7e750b5e1b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152389
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153985
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-12  Szymon Kłos  <szymon.klos@collabora.com>  [43c564da59d7d951ee9a903b80e82fd1159d0c71]

        lok: copy simple selection even when filtered
        
        when selected cells contain data filtered with autofilter
        and regular cells after that - we get different type
        of selection called SC_MARK_SIMPLE_FILTERED
        
        allow copying that too
        
        Change-Id: I69f91a674f427a7b956fd87b8dc56937b3b55e86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154239
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154309
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f7af4c311ad04ce5e54e08b9d7ccd71b75b7a32d]

        tdf#156236: For the rx or ry properties, "0" is valid
        
        Change-Id: I32c865e409a339c444440e00ee0f624c45380773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154307
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6f77ed620bbff11a1232b593be97e7d6f29aa8ac]

        sc: Theme color change undo/redo - styles and direct format
        
        This adds the code for undo/redo for change of theme colors in
        styles and direct formatting.
        
        Change-Id: I58568b18ab18562e6148ec8530d3d22c62ef2b95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154305
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-12  Justin Luth  <jluth@mail.com>  [42ee261d01983c94d8be60fccae37ae5af53bf5e]

        tdf#125504 StylesPreviewWindow: don't use disposed DispatchProvider
        
        .uno:StylesPreview in the notebookbar was doing nothing
        because the view switching from print preview caused
        the saved XDispatchProvider to become disposed.
        
        Thanks to Maxim, my patch is completely re-written.
        I think I have implemented the method he has suggested.
        
        Change-Id: Iae01116c742bc27ed2c14d983e7347d39c9acaf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154148
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-12  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [21d0534d8ca6ec5362848fb29b6f1ead7d1643d6]

        Upgrade Harfbuzz to 8.0.0
        
        Change-Id: I04d81509c50f0335d201b5286460989f526b58f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154233
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-12  Justin Luth  <jluth@mail.com>  [9a020a155eaad3f318ac44c6e54a502f64e6b982]

        tdf#141135 notebookbar: use radio buttons instead of checkboxes
        
        I mean of course in the places where mutually exclusive options
        are side by side.
        
        I mainly searched in menu.xml where menu:style="radio",
        and then changed the notebookbar menu items to do the same thing.
        It was all done by hand, unfortunately.
        
        Before testing, ensure you have no customized notebookbars:
        rm instdir/user/config/soffice.cfg/modules/*/ui/*
        
        git grep -B10 '.uno:NormalView\|.uno:BrowseView' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:PageMode\|.uno:MasterPage' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:.uno:PagebreakMode\|.uno:NormalViewMode' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:DefaultCellStyles' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:CommonAlign' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:StyleApply' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:TextBodyParaStyle' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:NumberListStyle' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:OutputQuality' *.ui | grep -A10 GtkMenuItem
        git grep -B10 '.uno:ParaRightToLeft\|.uno:ParaLeftToRight' *.ui | grep -A10 GtkMenuItem
        git grep -B10 .uno:SpacePara *.ui | grep -A10 GtkMenuItem
        
        git log -p -1 | grep '^+' | grep -v GtkRadioMenuItem
        
        Change-Id: Ia2e29a6541fed66f4bcb0936d715969994671e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154337
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-12  Rene Engelhard  <rene@debian.org>  [091eec9828c3cba728fb52924ad9a4103175e41f]

        add linux_riscv64 and linux_loongarch64 to dp_platform.cxx
        
        forgotten in bc9487f745befde6534fd46058e119256952323d and d3625d968901eb93a9680db8d1165f70de3fd64e
        
        Change-Id: I7f33c1db54b8f66e797a29cd1ccf96d19a88cc60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154333
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>

2023-07-11  Miklos Vajna  <vmiklos@collabora.com>  [25d50f08a27ee28698226a44db9c74a66a260754]

        sw layout xml dump: don't crash when text frame length is -1
        
        Of course this should not happen once the layout settles, but it can
        happen in the middle of debugging and the dumper itself should never
        result in an assertion failure.
        
        Change-Id: I425b8758f6f6f948752d40d081c8ed61855f9bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154294
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-11  Szymon Kłos  <szymon.klos@collabora.com>  [97c56d3d8912391d6151e99de27d91c1f0c4561f]

        jsdialog: dump calendar data
        
        Change-Id: I51d5e553c5ec1ba9fa5fd63844621368f3cedbd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154133
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit b61b6fa6ee97a735ba30a4b725075b4c0fffbdd5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154314
        Tested-by: Jenkins

2023-07-11  Szymon Kłos  <szymon.klos@collabora.com>  [11d874ee2fc1aeaa468648027050d677ac664ef7]

        Move SalInstanceFormattedSpinButton decl to header
        
        Change-Id: I64582387b9169efa700a0df5c89e042a9a150423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154192
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit b0de1f5fc3b6170f562328de8abd3680f2382a7a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154313
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-11  Justin Luth  <jluth@mail.com>  [f1ef3012fc7391d3dd4060a8f3108c60243dc45f]

        document the unusal application of a style-property to define DF
        
        One would expect the normal process of a style defining a property,
        and direct formatting overriding the style.
        
        However, in the case of a list level, ODF spec says that the
        definition in the list level has no meaning at all,
        except at the time when the style is applied to a paragraph.
        At that time, the program can chose whether or not to set
        the list level directly on the paragraph to the suggested level.
        
        Change-Id: Ia415f7be438b5123127f292c9f02cb9b9cfe66fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154249
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-11  Justin Luth  <jluth@mail.com>  [d15c4caabaa21e0efe3a08ffbe145390e802bab9]

        tdf#123026 xlsx import: recalc optimal row height on import
        
        This patch depends on the previous patch for this bug report,
        which allows each sheet to hold its own default row height.
        
        The given height for the row might not be enough to fit
        the content. If the row is set to use optimal height,
        that will be corrected as soon as the row is edited.
        
        Obviously, it should not require an edit to be correct
        on FILEOPEN, so this patch recalculates after loading the document.
        
        This might have a very negative effect on the time needed
        to open a file. I couldn't duplicate the XLS method
        because Library_scfilt.mk doesn't link to ScSizeDeviceProvider.
        The existing UpdateAllRowHeights wasn't designed to
        allow any performance improvements, so I made a new one.
        The new one is based on the newer ScDocRowHeightUpdater
        class - so perhaps the older method can be phased out.
        This new UpdateAllRowHeights could replace the
        XLS bSetRowHeights clause - with hopefully some performance
        benefit.
        
        I'm not sure I'm ready for the regression hate
        that would come from the inevitable performance implications.
        
        Testing however doesn't suggest a huge slowdown. I tested with
        time make sc.check
        before the fix I was getting 16m 4s +- 10s
        after the fix I was getting 16m 25s +- 10s
        
        Specific test showing the need for these patches:
        make CppunitTest_sc_subsequent_filters_test2 \
            CPPUNIT_TEST_NAME=testTdf123026_optimalRowHeight
        
        Impacted unit tests (without the previous patch)
        are documented in earlier patchsets.
        
        make CppunitTest_sc_subsequent_export_test \
            CPPUNIT_TEST_NAME=testMiscRowHeightExport
        
        make CppunitTest_sc_subsequent_export_test2
        
        make CppunitTest_sc_jumbosheets_test CPPUNIT_TEST_NAME=testTdf134553
        
        Change-Id: I6d020c1a5137dd4f05e20e82b1764a102b7f56d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140260
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [cf07373d84b0ad6d0110b62966705b3e101785b5]

        svgio: use frozen::make_unordered_map so no need to specify the count
        
        Change-Id: Id8400cba4c00439b4f4b888782d68531f7a64617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154293
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-11  TokieSan  <eltokhy@aucegypt.edu>  [92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f]

        Allow selecting a custom certificate manager
        
        Added a new option in Tools>Options>Security that allows choosing the
        path of a different certificate manager.
        
        Made Certificate Manager Button be disabled instead of hidden in case no
        certificate manager is detected. Added a box notifying that the
        certificate manager is opened (or not working in case it failed for some
        reason).
        
        Change-Id: I64a901766d4fb05c59c0f85fdf94c08a3ca4bdab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153798
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-11  Stephan Bergmann  <sbergman@redhat.com>  [254b90801d4af1b775447dc701c2f0d71fcfd773]

        external/skia: Fix use of incomplete type
        
        ...as reported at least with --with-latest-c++ against recent LLVM 17 libc++,
        
        > In file included from workdir/UnpackedTarball/skia/src/gpu/ganesh/image/GrImageUtils.cpp:8:
        > In file included from workdir/UnpackedTarball/skia/src/gpu/ganesh/image/GrImageUtils.h:12:
        > In file included from workdir/UnpackedTarball/skia/include/core/SkSamplingOptions.h:13:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/algorithm:1778:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:28:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:66:19: error: invalid application of 'sizeof' to an incomplete type 'GrFragmentProcessor'
        >    66 |     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >       |                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:300:7: note: in instantiation of member function 'std::default_delete<GrFragmentProcessor>::operator()' requested here
        >   300 |       __ptr_.second()(__tmp);
        >       |       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:266:75: note: in instantiation of member function 'std::unique_ptr<GrFragmentProcessor>::reset' requested here
        >   266 |   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >       |                                                                           ^
        > workdir/UnpackedTarball/skia/src/gpu/ganesh/image/GrImageUtils.h:106:12: note: in instantiation of member function 'std::unique_ptr<GrFragmentProcessor>::~unique_ptr' requested here
        >   106 |     return AsFragmentProcessor(ctx, img.get(), opt, tm, m, subset, domain);
        >       |            ^
        > workdir/UnpackedTarball/skia/src/gpu/ganesh/SkGr.h:32:7: note: forward declaration of 'GrFragmentProcessor'
        >    32 | class GrFragmentProcessor;
        >       |       ^
        
        Change-Id: I181f7416c80fd97c505359f275dd61f69ee27ef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-11  Szymon Kłos  <szymon.klos@collabora.com>  [16d600edcc33b72a9d09b7f2f496313612ffebd4]

        jsdialog: Move SalInstanceCalendar decl to header file
        
        Change-Id: Ide9e685d724d646f0ab8825b1fce2b6fd130d3ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154135
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit d792875d79a63364dba02426ef75d696ae0f02ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154266
        Tested-by: Jenkins

2023-07-11  Svante Schubert  <svante.schubert@gmail.com>  [0ee798d3a4cc90629e96f0f6c780c2887ae521d0]

        tdf#156093 filter: XHTML export: Enabling previous test files ...
        
        ... again and neglecting @draw:fill-color in base style to avoid
        duplication of fo:background
        
        Change-Id: I4905a7f8371d422944172140ab04c6bad6e7bd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154296
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-11  Svante Schubert  <svante.schubert@gmail.com>  [e2735d07e4bd9af0edfa561112393b9ae92ff923]

        tdf#156093 filter: XHTML export: Enabled all three different ...
        
        ... influences for CSS background-color: fo:background-color,
        draw:fill-color and draw:fill='none' the latter is the value
        'transparent'
        
        Change-Id: I8891bbaca224ad5f4340cded93182523e396223f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154295
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9fac0bae1b7da1145217aa7f9f864a784bf07ebb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ee57bcddb3488d2eb046cacfc63f86f4a774e2ba
          - Fix typo
            
            Change-Id: I94fc0b9b5571be5aa4ef00ea5b334d72f6fc0fec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154268
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-11  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [13bc0489d98b1f49a4f82fccb89d640439db4f4e]

        LibTomMath: upgrade to release 1.2.0
        
        * external/libtommath/clang-cl.patch: removed "typedef unsigned __int128    mp_word" from tommmath.h
        * external/libtommath/libtommath-msvc.patch: fixed upstream
        
        Change-Id: I38fe730ff0e9649c6a0ad8d64b723a27e3434012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153871
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b13a7112d89b402b41640a19f55ad9edb6433592]

        tdf#150408: Implement UI for "Legal" numbering
        
        Change-Id: I16849a2d823539040ecb91416b5214d25851950a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154287
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [fd64b426bc6175841143714ccc16bad181fd088f]

        tdf#150408: Implement "Legal" numbering (all levels using Arabic numbers)
        
        Enabling this feature on a list level makes all numbered sublevels, that
        constitute the number of this level, to use Arabic numerals. This doesn't
        change the labels of other levels: e.g., if level 1 uses A,B,C; level 2
        uses i,ii,iii; level 3 uses a,b,c, and is "Legal"; and level 4 uses 1,2,3;
        then a list may look like
        
          A. Something
            A.i. Some subitem
            A.ii. Another subitem
              1.2.1. This is a "Legal" sub-subitem
                A.ii.a.1. And its child
        
        This improves interoperability with Word.
        
        This change introduces document model, ODF and OOXML import and export.
        In ODF, a new boolean attribute of 'text:outline-level-style' element,
        'loext:is-legal', is introduced; its default value is "false".
        
        Change-Id: I5ae9f970864854c7e84c4b2f7ce46634b3ef104e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154288
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-11  TokieSan  <eltokhy@aucegypt.edu>  [6b0684b2c48bcd8fd6ded3817cbe12aa4e02b4dc]

        Allow columns' sorting in certificate chooser dialog
        
        Allowed native GTK TreeViewColumn sorting for the Certificate Chooser
        Dialog (selectcertificatedialog.ui)
        
        Change-Id: I4acba667ebd6fd5801730bf4413a00149b3b6528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154227
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-07-11  Michael Stahl  <michael.stahl@allotropia.de>  [41d8bb928231372f3ef08ce4ba3ea91b17e3ae29]

        (related tdf#154777) drawinglayer: add BBox to Figure fallback of forms
        
        PAC3 complains if the BBox is missing.
        
        Change-Id: I2cd61b2d01b64ffe77f28c661a3bd6f713df134f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154283
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-11  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [09c6ef36f43a9c7cc594c7e2d4044fee41a96406]

        zxing-cpp: upgrade to release 2.1.0
        
        - remove external/zxing/invalid_argument.patch.1 and
          external/zxing/no_sanitize_ignored.patch.0, no longer needed in 2.1.0.
        
        - If "Utf.h" can be included, use ZXing::FromUtf8() instaed of
          ZXing::TextUtfEncoding::FromUtf8().
          This makes external/zxing/undeprecate-warning.patch.0 unnecessary.
        
        Change-Id: I06acebb623aa8b60c5d2e5f7f265998571d75a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154221
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e339b3dea0c48aa9598a4e202b18519a494e86c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ea59b72bfa1b74e1b3a294778ec1d490d4e6962b
          - Add example on how to get user data from registry
            
            Special thanks to Rafael Lima and and Mike Kaganski
            
            Change-Id: I6bd04949680a2f11468debacd23be686e38fdf25
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154228
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-11  Michael Stahl  <michael.stahl@allotropia.de>  [1ae1f76caeef35a0db7705dd0c330936a77b6a8c]

        tdf#152234 vcl: Role values are lowercase
        
        Old version 3 of PAC throws exceptions if these are capitalized;
        presumably this is case sensitive, and all-lowercase unlike everything
        else.
        
        Change-Id: Ifc0cef38e333123e810376ab6a7630443d253841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154282
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6048355f479174d8f27d569542400c7b34b07df6]

        Fix typo
        
        Change-Id: I31031adff2ebecba430b79e301ff7d628d9301a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154289
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-11  Michael Stahl  <michael.stahl@allotropia.de>  [f2d5653a6792a19e9a45d34ac9dce22e717b8cbf]

        tdf#154939 sw: PDF/UA export: produce Link StructElem inside Figure
        
        ... for a fly frame with a hyperlink set.
        
          Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 1
          Links shall be tagged according to ISO 32000-1:2008, 14.8.4.4.2, Link Element.
          A Link annotation is nested within null tag instead of Link
        
        Change-Id: I7a2bef8d6100adffb1f40085bba8f18fc68bd8d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154280
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-11  Miklos Vajna  <vmiklos@collabora.com>  [663db89378aa1f0425e795ef5d471f134e658dc4]

        sw floattable: make sure floattable after floattable gets own anch pos from DOC
        
        The bugdoc has 2 floating tables next to each other, which overlap in
        Writer, but not in Word.
        
        This looks quite similar to the DOCX case, which was solved in commit
        01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable: fix lost tables
        around a floating table from DOCX, 2023-06-05).
        
        Fix the problem by improving SwWW8ImplReader::StartApo() so it inserts a
        fake paragraph when a floating table is immediately followed by a
        floating table. A similar case, floating table followed immediately by
        an inline table was already handled like this in
        WW8TabDesc::CreateSwTable().
        
        Creating a reproducer document from scratch is quite tricky, as Word
        will also insert a fake paragraph on the first save of the DOC test file
        (so the doc model will be floattable-para-floattable-para) and manual
        edit of binary DOC files is also not easy. So the compromise is that the
        testcase file has 2 floating tables anchored to the same paragraph, but
        they don't overlap visually, while they do overlap in the original,
        internal bugdoc. With this, finally the bnc#816603 DOC bugdoc renders
        without overlaps, which was the case before my multi-page floating table
        changes.
        
        Change-Id: Ib1b4c7c80833db5a7bde38092c8c3ed6fd1d2462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154290
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9ae63fc4a4ca683a58744f5333301e1606229069]

        Document connections between sw/inc/comcore.hxx and sw/inc/utlui.hrc
        
        Change-Id: Ibb646964ff031a34e13a814b79b0e73cb885fe37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154261
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b915dd9e1559870045481403806dd073f4fb5818]

        tdf#156130: Use default tab stop when TOC*N style doesn't define one
        
        When TOC*N style only defines one tab stop, it's used by Word as the
        page number position, and the tab between chapter number and chapter
        name is set to a default position. When the style has no tab stops,
        they are both defaulted.
        
        testTdf154319 is updated to test this.
        
        Change-Id: I561995a8e96882e1f17ee9982e3fc640e621cda2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154281
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-10  Stephan Bergmann  <sbergman@redhat.com>  [fcbae818b793a9ee97a1b5ddc53902be7a2376f5]

        Flatpak build needs external/frozen
        
        Change-Id: I701bf6999d29b54438c7cb47f73453aae3fbb457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154246
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-10  Michael Stahl  <michael.stahl@allotropia.de>  [f7974dc8d6d0cca08da52c4fbdb312ed6b7d71da]

        tdf#148729 sw: PDF export: fix link targets when "comments in margin"
        
        ... is enabled but there are no comments; the conditions in
        SwViewShell::PrintOrPDFExport() and
        SwEnhancedPDFExportHelper::SwRectToPDFRect() were out of sync.
        
        (regression from commit c77e01d63b4bd4805c4a499e4e0cab917d0eb403)
        
        Change-Id: I617185e6f30843a79190a54b73a5f44666697388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154279
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-10  Szymon Kłos  <szymon.klos@collabora.com>  [c6619100ed6d0524ac5294c1a9e1467a4371aee0]

        math: set initial formula width to non-zero
        
        After:
        commit 96de6dee60aaf2f0d332291fa3b0ad7bb8b7127c
        tdf#65067 Remove excessive spacing from Formula objects
        
        Initial size of formula object is 1 (width).
        This makes it ugly and hard to resize.
        
        Let's make it bigger when it is empty.
        
        Change-Id: I823de83b0f79a5a30c6ea6227f117daca3157e5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154160
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit 9fefa504be3e5ef28a5ef9a0dab7be7044def3c0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154252
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-10  Khaled Hosny  <khaled@libreofice.org>  [199dbff478dacee0b1d65d521e5147ba88c96567]

        tdf#147999: Fix canvas font width for fallback fonts on Windows
        
        For some reason we are getting the wrong font width for fallback fonts, which
        results in rendering them squished. This happens only with VCL canvas, but not
        with DX one, so it shows when hardware acceleration is disabled (either
        explicitly or implicitly when Skia is enabled).
        
        Change-Id: I5a45b1c1d68f4c6e6dd6b43371602af3330a7cd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154272
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [7db3c6b25a8c57beab7dae4e0e1497e7b06f3662]

        svgio: remove recurrent check
        
        Change-Id: I1b346007f5ae5e95b559cae1a9e8fdd3f4d93502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154271
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [56039daae4a436d7ea1b093a02cf0e8ad3bda4a9]

        tdf#149673: only check opacity from parent...
        
        ... if it has a local css style
        
        Because it's the first in the style stack
        
        Partially reverts 3e0e67a152e9631574e28dacb6e06a96f03ebca2
        "tdf#155932: tdf#97717: only apply opacity when primitive"
        
        Change-Id: I6a6bf08a519c84ac58c6111fd7da308cbf8a3021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154270
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d5b5914ef56395a8ba3d4c0a2eff8a5c52046b4]

        tdf#156201: just check one level up in the style stack
        
        Otherwise, the parent might also have a local css style
        
        Change-Id: Ib6d1340045f22861aee3e526d22d014eeb2f5d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154248
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-10  Matt K  <mattkse@gmail.com>  [7019eef453954785ad039bebd8c8a00183992584]

        tdf#146273 Do not allow non-numeric values for Navigator "Go to"
        
        This change modifies "SwNavigationPI::EditAction" and adds a new
        "connect_changed" handler "PageModifiedHdl" to the spin control
        (needed to intercept text handling).  In both functions we
        perform checks to ensure that only numeric values can be entered
        and only values within the page range of the document.  This
        now matches the behavior of the "Go to Page" feature.  To go
        to the first page, just enter a character input.  To go to
        the last page, just enter a value higher than the total number
        of pages.
        
        Change-Id: Ia020d72f4bed5b98b668ba95888bc4bc1d65e07d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154156
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-10  Miklos Vajna  <vmiklos@collabora.com>  [b26ddd42b434c84e5f8c939c2903fc7a0f79285f]

        svx: prefix members of GeoStat
        
        See tdf#94879 for motivation.
        
        Change-Id: Id8d116bfa375f7dd30ca8dcdec0ee02df8105030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154234
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-10  Justin Luth  <jluth@mail.com>  [6ed4c4a1b008e7bd4917d9cca255c862fbcd08aa]

        fix build: SkiaHelper.cxx missed W on -Wunused-parameter
        
        The error message was
        vcl/skia/SkiaHelper.cxx:75:32: error: ‘-unused-parameter’
        is not an option that controls warnings [-Werror=pragmas]
           75 | #pragma GCC diagnostic ignored "-unused-parameter"
        
        This fixes commit f8c15850dbfaa46605e1e353ae1f49e69184e8a1
        for gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
        
        Change-Id: Iae927e6c794e09cdab2d0fbd30a84a631800c9a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154247
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-10  Khaled Hosny  <khaled@libreofice.org>  [88d72b44a1a9345e7eacdd707cecfb300517df9c]

        Drop unused WinFontInstance scale
        
        Unsed since:
        
        commit 7cb3e475f2fb0162c7290414509de4fb8fe57e30
        Author: Jan-Marek Glogowski <glogow@fbihome.de>
        Date:   Thu Sep 6 14:04:25 2018 +0200
        
            WIN add SalGraphics* to WinFontInstance
        
        Change-Id: I7d14f2efce04c919cffee612b09833810ff3f78b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154240
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-10  anfanite396  <dipamt1729@gmail.com>  [a389e6bd7aacfa4e1ff1ea3a46199fb381d1131f]

        Move SwXDocumentIndexMark Java tests to C++
        
        Change-Id: I3aa19a10af87a6a41c9538dd6d743a8656a3a0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153557
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-10  anfanite396  <dipamt1729@gmail.com>  [bcbfdd2fe4d61ea619689a9754e018c691bf6ef7]

        Move SwXBookmarks Java tests to C++
        
        Change-Id: Ia640c59c97889c27f1c7b3ecf3b2630ac1d5e1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154231
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-10  anfanite396  <dipamt1729@gmail.com>  [74d286e269b727ae6731b426ec4d12dbfbc0212e]

        Move SwXAutoTextContainer Java tests to C++
        
        Change-Id: Ib785d9c1d143f0f51247ae73f01d9ee6d3806947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154230
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-10  Stephan Bergmann  <sbergman@redhat.com>  [a2589c4972b476937994b7ef546de22f89da134c]

        Remove duplicated entry
        
        ...that had been duplicated by c2fb518a6889fa9beac2d7e512ce3dcbf06c6d85 "update
        Japanese font order list", apparently by accident
        
        Change-Id: I194f73668f0cc2d3f10931a9cb56a2f523ec6c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154200
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa61e8b220aa1f34b022b9af485f0209b2cb25d1]

        tdf#99562: Do not ignore last column from matrix
        
        Change-Id: I1dff65963e2c414d1771a1592159930150c513e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154241
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8c15850dbfaa46605e1e353ae1f49e69184e8a1]

        update skia to m116
        
        (from m111)
        
        SK_SUPPORT_GPU is now SK_GANESH
        
        GR_OP_ALLOCATE_USE_NEW was removed in skia m111
            commit dd8f8ed3848cbe2032edc7ec08ef648a23e28ad9
            Author: Mike Klein <mtklein@google.com>
            Date:   Thu Apr 22 12:17:33 2021 -0500
            clean up defines that do nothing
        
        the fast-png-write patch was removed. The underlying helper
        function we need was removed in
            commit 0ec4c84abd0b578a5c792b04b56653cbc325530e
            Author: Kevin Lubick <kjlubick@google.com>
            Date:   Thu Apr 20 14:46:28 2023 -0400
            Remove SkImageEncoder and SkImage::encodeToData
        So I updated our dump() function in SkiaHelper.cxx to
        use the new Skia API.
        
        The constexpr-template patch seems to be superceded by skia
        changes.
        
        SkOpts: :hash_fn has been replaced with SkChecksum::Hash32
            commit 657ed9cf2379a950b925cb2aba7c85d6e1dd36ed
            Author: Brian Osman <brianosman@google.com>
            Date:   Tue May 23 12:40:12 2023 +0000
            Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32"
        
        The SkDebugf function needs to be exported from the library since
        it leaks out to calling code via some of the headers.
        
        Change-Id: I80ace8f25e660fa7889d22ef90676f47264d866c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-10  Szymon Kłos  <szymon.klos@collabora.com>  [9a5329a266bd74abc4794f1fcbae3db07582dbde]

        lok: remove old hack for LanguageTool locales
        
        Change-Id: I1098c51f03b4cdd4f21a635f7b6aae8e90fd9f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146779
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153962
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154162
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d5deff0553417edcd40731258512c1b49d167037]

        Fix typo
        
        Change-Id: Ic70380a7a3d8cefca5214ea70b87e92772535c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154232
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-10  Miklos Vajna  <vmiklos@collabora.com>  [1f2d523aeeafd241c71a468c970054120fb23b3d]

        sw floattable: enable AddVerticalFrameOffsets compat flag for DOC
        
        The bugdoc has a floating table, followed by an inline table. The inline
        table should be on the second page, but instead it's on the first page,
        overlapping with the floating table.
        
        It seems this works already for DOCX since commit
        50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add
        AddVerticalFrameOffsets compat mode, 2016-03-31).
        
        Fix the problem by enabling the same compat flag for DOC, since the
        intention was to have this on for Word formats in general.
        
        The original bnc#816603 bugdoc still needs more work, though.
        
        Change-Id: If9b4e1d3feeeaa24d6e84fea9a10ecdfd995c18f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154235
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-10  Balazs Varga  <balazs.varga.extern@allotropia.de>  [9068376ac4addcac9b9024567d74266a61a6b004]

        tdf#156135 - Add "Go to" action for "Avoid floating text" issue type
        
        Change-Id: Ie98f291141f38ac5544c9e51a209fb9bf1f26d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154107
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-10  luigiiucci  <luigi.iucci@collabora.com>  [c1cfe85f8bba10d367ef9ef1d6d569f53969dd34]

        tdf#62032 use style list level when changing style
        
        If a style S1 has a list level L1, and we
        change the style to S1 in a text node that
        has list level L2, the new text node
        list level must be L1
        
        Change-Id: Ic25b222202cb2da3153fc5c3723998c9f7f01247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153161
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Tested-by: Jenkins

2023-07-09  Mike Kaganski  <mike.kaganski@collabora.com>  [81726f5af5fda25f0d92ffc8458d7f24eb16f408]

        No need to clean up the desktop, when the process is finishing
        
        It will be cleaned up anyway.
        
        Change-Id: I67b936ee0d89280555e6d595fd53957952900057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154226
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-09  László Németh  <nemeth@numbertext.org>  [6d153fa9f5277b7324885e18b0a63e1af830b6c5]

        tdf#153804 DOCX import: fix lost footnotes in case of comments
        
        Incomplete handling of m_bIsFootnote had a conflict with
        XNote stream COMMENTS (i.e. not FOOTNOTES and ENDNOTES)
        since commit 96a856f87f16cca2e039c973c18d57c8b9dca362
        in DomainMapper::lcl_checkId(), resulting lost (order or
        content) of footnotes, when were comments in the document.
        
        Regression from commit 96a856f87f16cca2e039c973c18d57c8b9dca362
        "tdf#152206 DOCX import: fix mixed first footnote".
        
        Change-Id: I8d6901e8db1e183b959fecd350d6a263e79b5591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154147
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-07-09  Khaled Hosny  <khaled@libreoffice.org>  [2c040dc9919e4c5aa5f582d58ca5717a6ec1e12b]

        qt: Check for SAL_VCL_QT_USE_QFONT in a central place
        
        Change-Id: I7f0a2cf8daaf72de02261e2a9a5c3a70f5a42270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154224
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-09  Khaled Hosny  <khaled@libreoffice.org>  [f9b16330f13d3ad43de6de026206577bfa1ac85d]

        tdf#151273, tdf#151925: Don’t use QFont text layout by default
        
        We were enabling QFont for qt5 VCL plugin by default, but it is buggy
        and some distributions seem to enabled qt5 VCL plugin even if we don't
        recommend it.
        
        Since the QFont code is incomplete and no one is working on it, lets
        make people’s life easier by making it always off by default.
        
        This removed the SAL_VCL_QT5_USE_CAIRO envvar and replaces it with
        SAL_VCL_QT_USE_QFONT that does the reverse. Also SAL_VCL_KF5_USE_QFONT
        is dropped in favor of SAL_VCL_QT_USE_QFONT.
        
        Change-Id: Id7471acd12fe277908f567140b63ae8d27b03033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154222
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-09  Mike Kaganski  <mike.kaganski@collabora.com>  [1f24d35033c2f02335ce254bbcf6ba89e1b7565e]

        cppunittester: use a dedicated desktop on Windows
        
        Since introduction of accessibility tests infrastructure in commit
        0185ddd6d5f0324ba57b3fa36229103a6b27138e (Add infrastructure and
        basic tests including slight UI interaction, 2022-08-01) and the
        respective tests, running 'make check' on Windows produces pop-up
        dialogs, while these tests run. These dialogs distract, steal focus,
        swallow text that I type elsewhere, and may fail the tests if
        accidental user input interferes with what the tests check.
        
        This commit creates a dedicated system desktop for cppunittests,
        which would be isolated from the active desktop, yet allow creation
        of windows, thus not preventing accessibility testing. This way,
        it workarounds unavailability of svp vcl plugin on Windows.
        
        Change-Id: I83db54c82bfe98d14171355cc19cdd5767549fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154194
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-08  Jean-Pierre Ledure  <jp@ledure.be>  [b16861f667673560cf57d28bdd16bb592e6e3c22]

        ScriptForge - (SF_Calc) fix typo in CopyToRange() method
        
        Change-Id: I07db487d94c2d0a8f2ec5955f6e94b00911d25c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154214
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-07-08  Khaled Hosny  <khaled@libreoffice.org>  [f1998c01bf0a85481201589ffbd8b0df400491ee]

        tdf137553: Fix advance width for text using Graphite fonts
        
        This is a HarfBuzz bug and it was reported upstream.
        
        Change-Id: Ibf945d30f57c7fb847b63c40f5a7b2903958ab89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154213
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3e0b956cfff8d8aedc86d5e29b711b3f420f53c8]

        Fix typo
        
        Change-Id: I00578ea5123709ad8eee02fb8bc0c9a58ae31af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154205
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b1d93832e5f1d1a38d1a93f41753d15c134ca9f1]

        make SID_ATTR_TRANSFORM_POS_* and SID_ATTR_TRANSFORM_ROT_* SfxInt32Item too
        
        to be consistent with findings from:
        
        commit c64828a1cf55e9252e7acd236e3331f2635ae249 (origin/master, origin/HEAD)
        Date:   Fri Jul 7 17:05:10 2023 +0100
        
            ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32Item
        
        Change-Id: I6c50e4d5363ff9d79b459abb6192f2cedb39709e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154202
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-08  Michael Weghorn  <m.weghorn@posteo.de>  [7f7ccf955fa1138b712233628de4a73b3f845c7e]

        tdf#155705 sw a11y: Only handle paragraph's own spell check data
        
        When a paragraph is split across multiple pages, there
        are multiple accessible paragraphs on the
        accessibility layer, but there's still just a single text
        node in the underlying Writer core model.
        
        The `sw::WrongListIteratorCounter` used in
        `SwTextMarkupHelper` is for the whole text node, i.e.
        iterates over the spell check data from other pages
        (i.e. other accessible paragraphs) as well in that case.
        This caused invalid indices to be used when calculating the
        index within the current accessible paragraph again when
        iterating over all elements, causing a crash.
        
        Fix this by filtering out the elements that are outside
        of the accessible paragraph when handling markup information.
        
        Change-Id: If76cc60cc9ff5614d0bcbaff196ac34ec908936e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154109
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-08  Michael Weghorn  <m.weghorn@posteo.de>  [472950414a0fb07d5260b7b6b2d3a5d2dc18a68d]

        tdf#155705 sw a11y: Unify iterator use in SwTextMarkupHelper
        
        Introduce a new helper method `SwTextMarkupHelper::getIterator`
        to get a `sw::WrongListIteratorCounter` and use that to deduplicate
        and unify handling in three methods.
        
        Change-Id: I81790c547f70f0649ce800bc481db70982dfa742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154108
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [243e54564050f87535a5e7b96cd5bc143dffae0c]

        give fodt2pdffuzzer more rope to play with
        
        Change-Id: I30ee4e76e1ffb8cdec989f81d5bb43ed7bf7529e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154204
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c64828a1cf55e9252e7acd236e3331f2635ae249]

        ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32Item
        
        in online, insert smiley face in to calc and drag it around the
        spreadsheet
        
        include/svl/itemset.hxx:162:20: runtime error: downcast of address 0x603001c19b30 which does not point to an object of type 'const SfxInt32Item'
        0x603001c19b30: note: object is of type 'SfxUInt32Item'
         00 00 00 00  68 3c 7a e8 56 7f 00 00  01 00 00 00 68 27 00 be  9e 2e 00 00 be be be be  2b cd bc 9c
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'SfxUInt32Item'
        SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior include/svl/itemset.hxx:162:20 in
        
        Change-Id: Icb4f86104e804d697d1b71822ee224fa08f7519a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154191
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-07  Michael Weghorn  <m.weghorn@posteo.de>  [469fc646ec782f42e42947f480d5931b97e686ab]

        gtk3 a11y: Use sal_Int32 consistently to fix i386 build
        
        ... after
        
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Date:   Thu May 4 10:06:14 2023 +0200
        
                tdf#105404 [API CHANGE] add index to accessiblity change event
        
        Reported to fail like this:
        
            /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.cxx:164:6: error: no declaration matches 'void AtkListener::handleChildAdded(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>&, const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, sal_Int32)'
              164 | void AtkListener::handleChildAdded(
                  |      ^~~~~~~~~~~
            In file included from /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.cxx:29:
            /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.hxx:54:10: note: candidate is: 'void AtkListener::handleChildAdded(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>&, const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, int)'
               54 |     void handleChildAdded(
                  |          ^~~~~~~~~~~~~~~~
        
        Change-Id: I03caa5480ef133091ccd5c9ae682629cec3a789b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154190
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins

2023-07-07  Szymon Kłos  <szymon.klos@collabora.com>  [21d0489a5efa970e975ce1a70dfda2fd9e2c186d]

        lok: LanguageTool provides list of languages
        
        - it sends supported list to the LOK client
        - disables Spell Checker for locales supported by LanguageTool
        - duden protocol supports only german
        - initialize language tool config before usage to fetch correct
          list of supported languages
        
        Change-Id: Id9de8519303774163721def8661fa408da449348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146665
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153960
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154161
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-07  Mike Kaganski  <mike.kaganski@collabora.com>  [602ea7c873082f80626d562209cb36d99e20bbf5]

        Prolongate hide timeout in call to Help::Show*, when reusing existing window
        
        Otherwise, when moving mouse, and the tooltip follows it and updates its content,
        it would still hide after the initial timeout, only to re-appear on the next move.
        
        Change-Id: I3c93240f752301f2a86acabce54fe735d6e06550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154163
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-07  Michael Stahl  <michael.stahl@allotropia.de>  [41717420af68994c2fde522ea86db6e5ed643034]

        tdf#153472 vcl: PDF/A export: produce valid XMP metadata
        
        * historically the PDF export claimed to produce PDF/A-1a, which was
          removed from the UI in commit ed4a0eed82e2f29e8163a445db992d22c6d07134
          "tdf#62728 add PDF/A-2 support, change UI default to use that", and
          then reintroduced, presumably intentionally changed, as PDF/A-1b in
          commit 49cfcf777d03abf59557cad021b4e5c4445de3c0 "tdf#62728 Provide
          both A/1 and A/2 in PDF export dialog"
        
          Adapt the XMP metadata to always write "B".
        
        * if PDF/UA is enabled, veraPDF complains about the added pdfuaid:part:
        
          Specification: ISO 19005-2:2011, Clause: 6.6.2.3, Test number: 7
          All properties specified in XMP form shall use either the predefined schemas defined in the XMP Specification, ISO 19005-1 or this part of ISO 19005, or any extension schemas that comply with 6.6.2.3.2.
        
        Change-Id: I77b9fb728476e85830e3771135ac5a269e96b306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154169
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0d15535a3a022cc8367c968083fe3e19db943263]

        Update git submodules
        
        * Update translations from branch 'master'
          to 99b28edb4e0f6459eca71faa64df163a63618bdc
          - update translations for master/7.6.0 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I30df4b585f12a47e377eeaf1d6f07346aca1631a
            
2023-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [22e46544eebe027654bb4ecfc42e8d8ebb41ec48]

        related: tdf#155735: clamp RGB values
        
        So when a green matrix is used, everything becomes green.
        Also set alpha to 1.0 so at least a green matrix on black returns
        green and not black
        
        Change-Id: I9104c7511545fb244750b066bb1e996b6ce229f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154167
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-07  Michael Stahl  <michael.stahl@allotropia.de>  [04e90103b9a031af4073967228c6ccfc59438ec0]

        tdf#152484 cui,sw: if decorative is enabled, disable title/description
        
        ... in sw Frame Properties dialog and cui SvxObjectTitleDescDialog.
        
        Reportedly Word behaves weirdly if decorative is set and a description
        exists at the same time.
        
        Change-Id: I9fa149127bacc3567486334a14f42b05871a629f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154165
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-07  Balazs Varga  <balazs.varga.extern@allotropia.de>  [efaa065eb7053954242c83760f897e7dba2e9fe8]

        Related: tdf#155708 Clean-up left over nCloseResponseToJustHide
        
        cont int variable in dialog header.
        
        Follow up (Clean-up) of a5c61b143d53bb10430b8a486874856c16a2d86c
        
        Change-Id: I13ddbad581ee920a72726e18ccb9e7daf4eb7887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154164
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6d9dc8395b76bbe358510ecbfe289f80fb3b15c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8bd42f2c52d4290b41ea5a0304184e2810098a09
          - Fix typo on pagenumbering.xhp
            
            Change-Id: Ibdd64e92e7630707e97bff32764c72e952462f71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154175
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [445ab2355333ddb46081baffb8b0e3bb14fe00b3]

        combine PixelToLogic+LogicToPixel into LogicToLogic
        
        avoiding some precision loss
        
        Change-Id: I946f4f820321f76fb7634c722a28035600bac359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-07  Szymon Kłos  <szymon.klos@collabora.com>  [a0865169ab62508a7b933ed4634defa57b25f7b7]

        lok: remove duplicated locales for LanguageTool
        
        Change-Id: I8fd1632f36a6c2c2d61331d6ce5dbd3cce83e2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146776
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153961
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154155
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-07  Mert Tumer  <mert.tumer@collabora.com>  [81b0d9a951c9b15f4f1a76d45d0bd955b4dfc95b]

        Load the locales from config file for languagetool
        
        Locales needs to be read again
        in the Preferences/Writing Aids section and since
        this is a network operation it can cause a problem.
        Better to list all the supported locales in the xcu
        and load it right away.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I2ced6789df2a1d6fa2996e2d6b7d2a18e266afac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154154
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-07  Matt K  <mattkse@gmail.com>  [6d30ef2d9418ff6d2bd89c20a61c757bc3abb9b2]

        tdf#69183 Pasting a table in Writer no longer inherits list formatting
        
        The entry point of the paste is in SwFEShell::Paste as stated in
        the bug comments.  This code calls
        "rClpDoc.getIDocumentContentOperations().CopyRange" which calls
        "DocumentContentOperationsManager::CopyImplImpl".  In that
        function, there is a check for whether to propagate the
        formatting of a previous list in the document.  All we do is
        add a check there to see if additionally it is a table we
        are pasting, and if so to ignore propagating the list format.
        
        Change-Id: I655f54c4df44385fc82976b37d3e21b5fabf45ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154149
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-07  Szymon Kłos  <szymon.klos@collabora.com>  [7f2f58f88348e2d1b4cb655f12d75c9d20c2625a]

        lok: formulabar: use position sent from client
        
        Change-Id: I0877cd9d5a5ba0319701e50bd5b9e5d63b23becd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153717
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153988
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-07  Szymon Kłos  <szymon.klos@collabora.com>  [cc397d753936745fccaa1780a5e3cdd2c2d596bf]

        jsdialog: enable Insert Title Page dialog
        
        we need to weld also RB_INSERT_NEW_PAGES so
        when we check it - JSDialog executor will make
        it active and RB_USE_EXISTING_PAGES inactive
        
        Change-Id: I0abc5b6610e301abb1d24ecea680f63358dc5584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153189
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153987
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-07  Maxim Monastirsky  <momonasmon@gmail.com>  [6591a83a6e6bfaed336c11ea6f928e8764b6563d]

        Fix .uno:CharBackColor status update
        
        We have the editeng pool set as our secondary, and it maps
        SID_ATTR_CHAR_BACK_COLOR to EE_CHAR_BKGCOLOR, which then
        can't be found in the switch in SwTextShell::GetState.
        But handling EE_CHAR_BKGCOLOR here will be very confusing
        for anyone reading this code, so let's map it back to the
        slot id.
        
        Without this fix, the current highlighting color isn't
        preselected in the toolbar dropdown.
        
        Change-Id: I85e5ceb6d2193f831928f224577d6f87e889981f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154102
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-07  Maxim Monastirsky  <momonasmon@gmail.com>  [371f9131f15e41b1f121f26478ab997d13afc56a]

        reportdesign: Fix setting font color from the toolbar dropdown
        
        Seems like a recent regression from changing the argument name
        in PaletteManager::DispatchColorCommand.
        
        Change-Id: I2756a2c615398d40b15991cad2982cc80d6f6a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154150
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-07  Mike Kaganski  <mike.kaganski@collabora.com>  [1652fe3ece911af37b6d3a65d452cbcf86513c42]

        Some refactor to combine code deciding bNoDelay value
        
        Change-Id: Ie04288c14801dfc8090ed8bd92a85e426a66d654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154153
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a6b8c40d26c023cf8936017b92821f2b0df7ec58]

        Related: tdf#155462 Repaint changed tooltip text immediately
        
        When moving scrollbar thumb, its tooltip is constantly updated. This
        changes the window position and size, which appear immediately; but
        the text wasn't repainted, until events with higher priorities were
        processed, which gave visible discrepancies between the window size
        and its contents. When tooltip window size decreased, the old text
        could become cropped; or the window could become much larger.
        
        Also, not updating the text broke the idea that the tooltip helps
        user to see where they are in the document in real time.
        
        Change-Id: Ibdc7cc15bd40896428004ef70bbe8c8c5a0858ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154152
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b4a0680d6cf059aef5b274e8ce5a0453cf376655]

        Related: tdf#155462 Avoid tooltip window hide before showing again
        
        SwView::EndScrollHdl calls Help::ShowQuickHelp with empty text when
        nPgNum is not 0, which hides and destroys the window immediately.
        When moving the scrollbar thumb, tooltip should just move to the new
        position (and update text), which happens in ImplShowHelpWindow, if
        the window exist, and its parent is unchanged.
        
        So avoid hiding/destroying the tooltip window before checking if it
        should be updated, and only do that when necessary.
        
        Additionally, I noticed that the guarding condition around the code
        showing tooltip, 'if( !nPgNum || nPgNum != nPhNum )', was always
        true, because SwView::EndScrollHdl called previously makes sure that
        nPgNum is 0 unconditionally.
        
        Change-Id: Id10dd6236379660ab0b1d6f14159cfd4f9c61256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154151
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-07  Jaume Pujantell  <jaume.pujantell@collabora.com>  [341029de72cf957b7bc7775e51544070d4a49874]

        tdf#155796 sc: fix select with merged cells
        
        When selecting multiple cells or modifying a selection with shift+arrow
        make sure that a merge group is never partially selected.
        
        This also fixes tdf#128678
        
        Change-Id: Ida00939cec11240c0d06375feb21afa82a6876da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154093
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2023-07-07  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [f57bb8bbadf086873155401445b03bdb971ecc6f]

        xmlsecurity : remove deadcode and usage of array template
        
        Change-Id: I282e2af395471aa4818bfb4586ac06c7850c8a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153862
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
        Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [77fca616e0bd79e0b405fd0b3543cf8e94e15df3]

        Don't modify configuration / Windows registry in CppunitTest_sw_a11y
        
        After commit 889c12e98e04edb4bc25b86bf16b8cf1d9b68420 (tdf#155794
        vcl: handle WM_GETOBJECT without SolarMutex, 2023-06-13), running
        CppunitTest_sw_a11y resulted in a failed assertion in VCL cleanup
        on some Windows systems:
        
          Assertion failed: !IsModified(), file C:/lo/src/core/vcl/source/gdi/configsettings.cxx, line 56
          abort() has been calledwarn:sal.cppunittester:16572:26632:sal/cppunittester/cppunittester.cxx:598: CAUGHT SIGABRT:
          25: sal::backtrace_get - 0x7fffcca3162a
          24: AbortSignalHandler - 0x7ff7ee9eaf4f
          23: raise - 0x7fffc37c90ed
          22: abort - 0x7fffc37cae49
          21: get_wide_winmain_command_line - 0x7fffc37d0c6f
          20: get_wide_winmain_command_line - 0x7fffc37cebc8
          19: wassert - 0x7fffc37d18af
          18: vcl::SettingsConfigItem::~SettingsConfigItem - 0x7fff2bbfd3cd
          17: vcl::SettingsConfigItem::`scalar deleting destructor' - 0x7fff2b861dc0
          16: std::default_delete<vcl::SettingsConfigItem>::operator() - 0x7fff2bbfdc38
          15: std::unique_ptr<vcl::SettingsConfigItem,std::default_delete<vcl::SettingsConfigItem> >::reset - 0x7fff2bbfeae7
          14: DeInitVCL - 0x7fff2bfacd68
          13: `anonymous namespace'::Protector::~Protector - 0x7ffffa341357
          12: `anonymous namespace'::Protector::`scalar deleting destructor' - 0x7ffffa341520
          11: CppUnit::ProtectorChain::pop - 0x7fffcc55dedf
          10: CppUnit::TestResult::popProtector - 0x7fffcc52e4e8
          9: `anonymous namespace'::ProtectedFixtureFunctor::run - 0x7ff7ee9f0e18
          8: main2 - 0x7ff7ee9ef5f9
          7: sal_main - 0x7ff7ee9f0e69
          6: main - 0x7ff7ee9f1bca
          5: invoke_main - 0x7ff7ee9f25e9
          4: __scrt_common_main_seh - 0x7ff7ee9f250e
          3: __scrt_common_main - 0x7ff7ee9f23ce
          2: mainCRTStartup - 0x7ff7ee9f265e
          1: BaseThreadInitThunk - 0x7ff8039d7614
          0: RtlUserThreadStart - 0x7ff8059826f1
        
        because it called MiscSettings::SetEnableATToolSupport at some point.
        It seems reasonable to avoid such configuration changes for unit test
        anyway.
        
        Change-Id: I00edc4f6e1183dad66e0504f7d702ad90d7edcd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154134
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [06c552cf45a01bca6eff68033c59308c41dd79e8]

        use logical pixels in ORoadmap::DrawHeadline
        
        which is what DrawText wants
        
        Change-Id: I5dd98314f84f25f65e199444af87e4f34f7bfbce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [faadaa111d0c4025af5cffb8c8dbd084040f7217]

        tdf#153517: sc_ucalc: Add unittest
        
        Change-Id: Idaa8bd4e0d6e34b0f45faa1ab49b46c5fb154475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154138
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-06  Michael Stahl  <michael.stahl@allotropia.de>  [e751d59264c369cfc342dab5f0759be12341d306]

        tdf#141058 oox,sw: OOXML import/export of decorative on shapes
        
        Also add a test for PPTX (using the oox filters), and add a SdrObject to
        the testTdf143311 for DOCX (using the writerfilter/docxsdrexport).
        
        Change-Id: Iccee46c0d30316c33c0947b117e2604c96fa0182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154137
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [13d71843510964a98d3c480d1e42533bdd34deab]

        make tools::Poly*gon single-arg constructors explicit
        
        which will help avoid ambiguity in method calls in an upcoming patch
        
        Change-Id: Ic7607ac7d95559e0942a84fb3226cfdd6ade22bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [11419c34eb38b1d15bd83ca8c511346a7bc30537]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8714d297f8bd8be89ca8e18a44777bab1e1b7cf0
          - SF_Calc updates
            -  sort ranges on more than 3 keys
            
            Change-Id: Iff58c0ba38fba93efe4e515702996352cc9d9733
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154041
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2023-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [359e2be93a4560a86237f076003c23a6635fb1bb]

        starmath: check GetEditWindow()
        
        it might return nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/SmPrintOptionsTabPage::~SmPrintOptionsTabPage()
        
        Change-Id: I4b34b0da3dc282ae89fd58defa12045c34a12cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154026
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-06  Adoche Onaji  <dochieonaji@gmail.com>  [3d2f9b63e61a32ff07d850103f059dda88b56d6e]

        tdf#113478 'Decimal separator key' property was renamed to 'Numpad decimal key'
        
        'Decimal separator key' was renamed to 'Decimal key on the numpad' to give it
        more acceptance and understanding on various platforms
        
        Change-Id: I6d8411026bf7b2c9f5d85d9ee3f19f7f7f603d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150809
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8bc077c961a84f8a3186bc1bdc7b417c112b825e]

        flatten some bitmap code
        
        Change-Id: I0f4435899e3002c152767aaa68ffa1629b4a172d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2dde0bf99ed11feb32d361303bb15fbd6d33ec0e]

        tdf#122735 get the correct ActiveViewContact
        
        In ObjectContactOfPageView::getActiveViewContact() the decision
        which ViewContact is to be returned depends on if the SdrObjList
        fetched from the SdrPageView is a SdrObject or a SdrPage.
        
        Both are derived from SdrObjList, so to decide that the helpers
        getSdrObjectFromSdrObjList and getSdrPageFromSdrObjList are
        used.
        
        For SdrObject the 1st will return ptr, 2nd nullptr. For SdrPage
        the 1st and 2nd will return ptr due to 1st trying to return
        something useful by getting up the hierarchy and return the
        SdrPage the SdrObjList/SdrObject is inserted (as the name says).
        
        This means that here the test for SdrObject *has* to be used 1st
        to correctly decide of what nature SdrObjList is.
        
        NOTE: Here it would also be possible to use dynamic_cast(s) to
        the classes to test for, but tooling is virtual/faster.
        
        Change-Id: I113afceddd3210aa63960d248f7c7356f82cf413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154065
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [732d0e89363abb009ff13a23957ab7257a378a11]

        Related: tdf#141969 Make sure to use SwAttrSet for paragraph autostyles
        
        See https://gerrit.libreoffice.org/c/core/+/153947/8#message-45a748bf68235bf143bec07cda2d704abb2b140f
        
        > This started to cause e.g.  CppunitTest_sw_rtfexport3  to fail with
        >   /sw/inc/node.hxx:493:53: runtime error: downcast of address 0x606000617540 which does not point to an object of type 'const SwAttrSet'
        >   0x606000617540: note: object is of type 'SfxItemSet'
        >    00 00 00 00  30 15 0f a9 a6 7f 00 00  50 6a 4a 01 40 60 00 00  c8 98 0f 00 30 61 00 00  80 30 6c 00
        >                 ^~~~~~~~~~~~~~~~~~~~~~~
        >                 vptr for 'SfxItemSet'
        >       #0 0x7fa671d1b765 in SwContentNode::GetpSwAttrSet() const /sw/inc/node.hxx:493:53
        >       #1 0x7fa671d7159e in SwContentNode::GetSwAttrSet() const /sw/inc/node.hxx:729:25
        >       #2 0x7fa673be6c4a in SwDoc::TextToTable(std::__debug::vector<std::__debug::vector<SwNodeRange, std::allocator<SwNodeRange> >, std::allocator<std::__debug::vector<SwNodeRange, std::allocator<SwNodeRange> > > > const&) /sw/source/core/docnode/ndtbl.cxx:1236:51
        >       #3 0x7fa6775f46a5 in SwXText::convertToTable(com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::text::XTextRange> > > > const&, com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > const&, com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/core/unocore/unotext.cxx:2279:51
        >       #4 0x7fa6775fba56 in non-virtual thunk to SwXText::convertToTable(com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::text::XTextRange> > > > const&, com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > > const&, com::sun::star::uno::Sequence<com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> > const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sw/source/core/unocore/unotext.cxx
        >       #5 0x7fa61c596a81 in writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool) /writerfilter/source/dmapper/DomainMapperTableHandler.cxx:1481:35
        >       #6 0x7fa61cf2fdee in writerfilter::dmapper::TableManager::resolveCurrentTable() /writerfilter/source/dmapper/TableManager.cxx:409:33
        >       #7 0x7fa61cf30bb1 in writerfilter::dmapper::TableManager::endLevel() /writerfilter/source/dmapper/TableManager.cxx:427:9
        >       #8 0x7fa61c642f37 in writerfilter::dmapper::DomainMapperTableManager::endLevel() /writerfilter/source/dmapper/DomainMapperTableManager.cxx:496:19
        >       #9 0x7fa61cf2cae1 in writerfilter::dmapper::TableManager::endParagraphGroup() /writerfilter/source/dmapper/TableManager.cxx:338:9
        > (<https://ci.libreoffice.org//job/lo_ubsan/2836/>)
        
        Regression after commit b036e563e699595fa7625888f11ab0c76f1abd66
        (tdf#141969: use paragraph autostyle to mimic Word's table style,
        2023-07-04).
        
        Change-Id: Idc905cdea35bd0c5f3cfbd562d63894f44e64446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154106
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [04c78e1a46a423071d7ea68724525ec7ef92e0e8]

        tdf#156167: create separate map for case insensitive strings
        
        Add static_assert to make sure both maps have the same size
        
        Regression from:
            svgio: use "frozen" for mapping between token strings and enums
        
            Change-Id: I2061606146cfcb34169dccf69b6f720727839d04
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153174
            Tested-by: Jenkins
            Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        
        Change-Id: Ic54dfe45eaff5ef75bcd4ebab715f278540da913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154055
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [af34f4ea62d8aabbab5d4028034aa2482c16fe8a]

        avoid skia assert and slow-path
        
        Otherwise, several lines below, we might call
            mpAlphaVDev->GetBitmap
        which will return no bitmap (because the resulting bitmap would be
        empty).
        And then either we will hit the assert a few lines lower, or we will go
        into the very very slow path below.
        
        Change-Id: I41a62cddef5e0a6822ca09ed954e3fe431ca0021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Khaled Hosny  <khaled@libreoffice.org>  [f348425e0b9187f56370d9b76594872f935b4d8e]

        tdf#52577: Classify superscript numbers in Latin-1 block as ScriptType::WEAK
        
        So that they inherit the script from the surrounding text like the rest
        if superscripts and subscripts.
        
        Change-Id: Ib5c19f84b080eca0f24009a4e6dd2dd4019441d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154094
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [a0ab053c9f7645ff10a1ab69858a30bb3bb4857c]

        lok: Register sidebar for frame explicitly
        
        For some reason, it is needed in 22.05 (unlike master). Without this,
        sidebar sometimes isn't shown in inline edit mode.
        
        Change-Id: Ie225ff0676786e9164e8640c6e159efb8aebf241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140640
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154022
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 8a1f78dab16e3b27752b76e9013ec2249c894dbc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154113
        Tested-by: Jenkins

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [107ec1a9bd17c195998687460a3aee0eb41ff897]

        lok: find active SmViewShell reliably in Elements panel
        
        It is needed in 22.05, unlike master
        
        Change-Id: I76265888e7814f47b09c405dc1e907aa0dfbc743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140646
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154114
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-06  Stephan Bergmann  <sbergman@redhat.com>  [7c6c3ec2b46ff037c4c85073232188391f627eb5]

        Missing test dependency
        
        Change-Id: Ic0aced78a6667116fd77b73a3965a2155d5941bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154095
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [3e49ba051b9cc077ffeca66afe341c67194e90f9]

        tdf#156136 - Add "Go to" action for "Text contrast too low" issue type
        
        Change-Id: Icce3b56877679ca40a52a2c5f4b8f70f14268fac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154078
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [4bb80847578fb85119d2ddb2008a90f916a5baf0]

        Optimize a bit
        
        Change-Id: I1ac373bea06b946b3c51154dfcdbe6aa22eeae49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154089
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [58d155b8be249a2814fa48df802b42a85b810eca]

        loplugin:unusedfields all-can-be-private
        
        these fields can be private
        
        Change-Id: I74423a9ae2ef0263a28c8a716ab1c55861e453d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154092
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [a62af0444515ab28bc0ffdc8ff7f320ca962bbc0]

        sw: fix crash in SwTextNode::Update
        
        FindPageFrame might return nullptr
        Introduced with c684301352bcca709bc8d1c99e0f08e7096e9716
        "(related: tdf#149595) sw: also re-sort SwSortedObjs on SwPageFrame"
        See https://crashreport.libreoffice.org/stats/signature/SwTextNode::Update(SwContentIndex%20const%20&,long,SwContentIndexReg::UpdateMode)
        
        Change-Id: I2e8df1428400f6752eafaaa6102a1fc3de3f0daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153977
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-06  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [45d7ffb7f238fbb8cf99cdcd386c496223915ab7]

        sfx2: disable setting password on text documents
        
        Since we can't preserve the password in a plain-text
        file, we should disable the ability to set/change
        it. Otherwise, it's misleading to users.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I3176243ddd2826eb07def1ff5ab251e33cb7125e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153917
        Tested-by: Jenkins
        Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>

2023-07-06  anfanite396  <dipamt1729@gmail.com>  [1d2380516ac9871743c5a5455f0734d02be8eade]

        tdf#129847 Show "more content" red arrow along with ### indication
        
        Change-Id: Ia753772d5db34094d7d201c1ed72663b2022b1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150703
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [78dc5a38048d0fc8bcabc9e48520578d618176fa]

        GROUPEDCENTER constant is unused
        
        added in
            commit 46695f3d66cc77b38865c1817b09d95e9c4b6683
            Author: Attila Bakos <bakos.attilakaroly@nisz.hu>
            Date:   Thu May 7 17:23:48 2020 +0200
            tdf#133030: DOCX export: fix formula alignment - part 3
        but unused even then?
        
        Change-Id: If21f9c68c1e7951ef7123f88d98ec823fbbc6864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154029
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [080bc640358aad36d93a02fe51b922eec994cfe7]

        fix bug in "Replace RES_NAME_CHANGED with an SfxHint for stronger typing"
        
        where
        
            commit f48cb25a914902d92bd109eff86ec3b6d26ba9c3
            Author: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
            Date:   Thu Sep 15 00:34:50 2022 +0200
        
        added a new constant SfxHintId::SwNameChanged and then used it in some
        places, but not others
        
        Change-Id: Id9fa07a1d5fe07a3ac8a74d9d32b9bfe8e6c38e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8be539b0eba0ec1e4cbea0b4464ff4945fdacb1]

        ScAutoFontColorMode::Black is unused
        
        since
            commit 3537cef02c25c2c2459d7900eed13eeec533b7ae
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Tue May 16 22:10:10 2023 +0900
            sc: factor out color from setting vcl::Font from a ItemSet
        
        Change-Id: Ia8781d69ed4969eb9617c96c6991cc39ce162e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [62127bb799178dfe91ab005db0aad732b85ac1a1]

        DrawTextFlags::HideMnemonic is unused
        
        ever since
            commit 3fbae5dc7e7b200776bbc8a7c2a43e1e04f15a2b
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Thu Aug 5 14:57:59 2021 +0100
        gtk is the only case auto-accel is true, and the menubar is native
        gtk there
        
        Change-Id: I209a410a231952dcbbb587ed6034fcfec77eaead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Michael Stahl  <michael.stahl@allotropia.de>  [c70710e334ae89681d25055955c2228e5a22f0c2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d749df06bd33ae91361b49e456e44b9c8ba859d9
          - tdf#138504 helpcontent for decorative on shapes
            
            Change-Id: Iacccc8064140cb9b264eb0e6b584f1c6e0668606
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154096
            Tested-by: Jenkins
            Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
            
2023-07-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9b84955c11dc893901966b645a71b15436004751]

        cairo RGBA needs to take account of custom RGB24_888 format
        
        Change-Id: I929d20f134c4fb7dedfd2c581263c303cae87eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c07810abf1a08e6abfa57163eb8a8d4786fbf88d]

        tdf#156138 - Add "Go to" action for heading level issue types
        
        Change-Id: Id491e2ca4ae7f63d25f7ad76704084bbda2f14ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154076
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-06  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e894bdace448addd73c8f1aaf079c0e7ec84308d]

        tdf#156134 - Add "Go to" action for "Simulated numbering" issue type
        
        Change-Id: I92f7ae620eb0fd540c8919a4bbb9cae1d375a391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154071
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-06  Maxim Monastirsky  <momonasmon@gmail.com>  [619ac8bbb31a62087ac1e3745cc28b461bfb49c0]

        tdf#126382 Correct check for transparency
        
        Change-Id: I0664abae6f83736678108fab31dd119fae811054
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154082
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-06  Michael Stahl  <michael.stahl@allotropia.de>  [1e7cab690d238f8e644e28a3de54c4deeec12a23]

        xmloff: ODF export: stop producing decorative on draw:frame etc.
        
        The attribute was moved to the style graphic-properties in commit
        2721520ca37654056c3d509657c50ee42e3dcae4, which is in 7.5.2 so users
        likely have upgraded from 7.5.0/7.5.1 and this can be removed now.
        
        Change-Id: I69ef3e2e501af21f04df440bf176e46f651d671b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154074
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-06  Miklos Vajna  <vmiklos@collabora.com>  [9ac864159b241d2093e86f664ab6f4b76c69196d]

        tdf#156059 sw floattable: fix lost 0 bottom margin of anchor in ftn from DOCX
        
        The bottom margin of floating table anchor paragraph in the footnotes
        was non-zero, which meant that the document had 2 pages in Writer, but
        only 1 in Word.
        
        What happened here is that commit
        d1ac8df139a2a65db45d1970ccc0b80e17d827f6 (tdf#146346 DOCX import: fix
        table margins in footnotes, 2022-05-03) fixed this, but only for the
        case when the floating table conversion was delayed and not in the
        instant conversion case. Then later commit
        c50bf5a5daaae3d40f89ea0784a75a8a571c208d (sw floattable: remove no
        longer needed DOCX import heuristics, 2023-04-12) made all floating
        table conversions instant, so the problem was re-introduced.
        
        Fix the problem by now fixing the problem in
        DomainMapperTableHandler::endTable(), restoring code that was removed
        from SectionPropertyMap::CloseSectionGroup().
        
        There was a disabled testcase for this, so just enable that.
        
        Change-Id: Ifb7c8fe2bdc70625d3e334cea0893b8e563664ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154088
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [9239c50a3a154ef6725d6ad36641279cf6f69752]

        svgio: use frozen more
        
        Change-Id: I64c5d12321a10cc1f63d7892c83ff7bd3a232a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154072
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [cea402a5adfda2ba2d75411691401a2971d78d83]

        ScanlineFormat::N1BitLsbPal is unused
        
        ever since
            commit 4160be791daaef1a0c059a248f678cbad6408a69
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Tue Jan 10 20:55:31 2023 +0000
            no more X11SalBitmap
        
        Change-Id: I9dd55acdde6af1bf7501a71e92725ab739801b0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-06  Miklos Vajna  <vmiklos@collabora.com>  [e5e324a3420fc74fc147601bb125421e87060d93]

        UITest_range_name: use oneprocess mode
        
        Before: 1m0,979s
        
        After: 0m40,131s
        
        Change-Id: I48af7b9c80a7bf7d2677b09c358cfdf0b477d094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154070
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [ef32908467cc44d20b01c25757a6ad96c8ae9286]

        Drop commented out obsolete code
        
        Change-Id: I869e9f20e30f69d8da713f2c69b10a038169891f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154045
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [7e997097eb0e36bbb6f1eb8519acfc4e8eb6337a]

        tdf#155462: fix the scrollbar tooltip text
        
        Over the time when it was completely unused, it regressed in a couple
        of aspects:
        
        1. It got assembled in incorrect order: instead of appending chapter,
           it got prepended in commit 832e5aadbff006ec24959162c29756fe2b1982be
           (Related: fdo#38838 remove UniString::SearchAndReplaceAll, 2013-10-08);
        2. It started to show chapters, only when the respective heading are
           at the very top of screen, and show only page elsewhere, likely in
           commit 835cd06a047717dfe5e0f117959f3c042e13b21b (tdf#38093 Writer
           outline folding - outline visibility and on canvas ui, 2020-07-30),
           where a call to SwNode::FindOutlineNodeOfLevel was replaced with
           SwOutlineNodes::Seek_Entry in SwCursorShell::GetContentAtPos.
        
        Change-Id: I3f427f7ecb3b6c58a441220c555b22e765a533c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154077
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-06  Patrick Luby  <plubius@neooffice.org>  [aa5c3d32d7c85b496fa86d8198478fb6dc157811]

        Fix failure to generate the correct color mask
        
        OutputDevice::ImplDrawRotateText() draws black text but
        that will generate gray pixels due to antialiasing so
        count dark gray the same as black, light gray the same
        as white, and the rest as medium gray.
        
        The results are not smooth since LibreOffice appears to
        redraw these semi-transparent masks repeatedly without
        clearing the background so the semi-transparent pixels
        will grow darker with repeatedly redraws due to
        cumulative blending. But it is now better than before.
        
        Change-Id: If64ff5ab52a6e441b587aa3c3c12b08137ecf34e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154079
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-07-05  Justin Luth  <jluth@mail.com>  [71358fa5ebbb086bac822ddbfcd3500dce09ae63]

        simplify sd: already asked if mxTextObj.get().is()
        
        Change-Id: Ibb303cf53722684b0f98f0195ec6d55376bcfd1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154073
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-05  Khaled Hosny  <khaled@libreoffice.org>  [5d2fa4ab6e75609c30351f0623dac63182be4c27]

        tdf#113290: Fix handling of grapheme clusters in slideshow animations
        
        When doing animations by character cells (AKA grapheme clusters), we
        were taking the first character of the cluster only and lumping the rest
        with the next cluster, so a combining mark would appear at the start of
        the next sequence instead of the end of the current one.
        
        For surrogate pairs it was even more broken we were splitting in the
        middle of the pair resulting in invalid Unicode sequence.
        
        Change-Id: I9bbfe412e9b0a876b69e33c0916067bf75064122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154066
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [d378a44b4aa917d1f000f6ed2aa682009c544b6f]

        svgio: simplify code
        
        Change-Id: Ieaf0430cd0e84d861f108ec33bf98ff2870ba2df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154067
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef049c4d10023f866173ea344d13e5d99d485066]

        simplify SvxUnoDrawPool initialisation
        
        Change-Id: Iaca5eec19935c50cc7cade4f3dab139a5232473a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [18446cdd6007679f227f192a606c86fe2eea1ef6]

        loplugin:finalclasses
        
        Change-Id: I62b094a3bd9a4f630cebdf538c04391e2920ff2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154064
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Mike Kaganski  <mike.kaganski@collabora.com>  [e55e64a7b736df7dd902f88fcf0c889d43d2eed0]

        tdf#155462: Re-enable ShowScrollBarTips expert config
        
        ... accidentally broken by commit 4ed26badfd6fd9190cb6e54078b41eb38cb37dca.
        
        Change-Id: I407e1eab47277dd8fa00c123b32596557fd5f2a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154032
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-05  Michael Stahl  <michael.stahl@allotropia.de>  [6efc72b99a08384e56c5a4da7918177be60b3b09]

        tdf#138504 svx,etc.: decorative flag on SdrObject shapes
        
        * SdrObject new member m_IsDecorative
        * new Undo SdrUndoObjDecorative
        * surprising amount of changes in sw including additional SwUndoFlyDecorative
        * svx API SvxShape property "Decorative"
        * UI checkbox "Decorative"
        * ODF import/export as loext:decorative on style:graphic-properties
        * PDF/UA export: ViewObjectContcat tag shapes with this flag as Artifact
        
        Change-Id: I37f7a0597eab92c6c6aff94fad6c16c59b231c80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154063
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [082993c38e68089282b42fdb46179ac2574d61d5]

        SvtCJKOptions::EOption is unused
        
        ever since
        
            commit 5db72ef0b381671b7867bda759098a92909e06d8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jul 26 13:51:57 2021 +0200
            drop SvtLanguageOptions class
        
        Change-Id: I2d56b0c21510239ef1ee1d0b95748641d485580c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154053
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea0e9c0d4de19ac3f8fdfe91bdb085ad9e2b1757]

        these enums are unnecessary
        
        Change-Id: I29bf28202e11db836764276f773b134356d93e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9dc0e4abbd6c06ee886302b2052e1f6814dfa76]

        WriterInsertDoc constant is unused
        
        ever since it was added in
        
            commit d157c1bd70d630a58db33910d550bb8dee9fe62e
            Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Date:   Thu Jul 8 05:50:25 2021 +0200
            tdf#126665 Remember last used file picker directory
        
        Change-Id: I49764ab44d6ca37efeafaf9e02a25b6d7d9a8eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154050
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Rene Engelhard  <rene@debian.org>  [5b1f68461ccfa475f70640cafd0af769b814e3fa]

        add .pages to bin/generate-bash-completion.py
        
        Change-Id: I7ec0244dad1b80eb577bfbe0bb6e3e46b14dce9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154011
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2023-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6ab906ebe9995fb813db7b66df4f9b2def76a1c]

        tdf#156168: do nothing when there is no concatenation
        
        Regression from:
            tdf#156034: check for css style further up in the hierarchy
        
            Change-Id: I92c6673f1249cc4a273c490cdc0496474ce1f0c5
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153498
            Tested-by: Jenkins
            Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        
        Change-Id: Ie699f40ea813d2ba5dc031008d56e2fce73a5715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154056
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-05  Michael Stahl  <michael.stahl@allotropia.de>  [a67675e7e248e056637be8b70d620379cdfb682e]

        offapi: add Title/Description properties from CWS aw038 (OOo 2.2)
        
        Change-Id: I2a851ef76b840d1fa5479dcb182a63590a2d4065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154052
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-05  TRaXIn  <raghav.29.khanna@gmail.com>  [8dbbeadbc7eabe76736d37fe3bcafe3e537f0bc0]

        tdf#153328 ZXing::ToSVG() Conditional usage
        
        Change-Id: I8874f596be808d5d255139654a19b25f71299179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147677
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-07-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0dfd8288a87b58e503bb3a41be6137485fbf3f68]

        ofz#60384 Direct-leak
        
        since:
        
        commit 13a41e7a12598c7896d6dc8d34aba6af5b80b83c
        Date:   Mon Jul 3 14:11:43 2023 +0200
        
            tdf#150124: do nothing when parent is of unkown type
        
        Change-Id: I58edf5f63d97e8afb1cd58c7e23452a9ea6a87eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154023
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-05  Rene Engelhard  <rene@debian.org>  [451f15888a7f3e747a34d24a047d4ec73a40c6c5]

        don't use SSE in skia on "INTEL" (except on Windows...)
        
        as i386/i686 in Debian is non-MMX, non-SSE, cf.
        https://wiki.debian.org/ArchitectureSpecificsMemo#i386-1
        
        Regression from 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 which claims
        to have set the define instead of skia_sk_cpu_sse_level_0_by_default.patch.1
        but actually sets it to SSE2...
        
        Change-Id: I4157a580470732fd7bbc5cf1b2384b76182340cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153984
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [29eb0b94f27b956d3c9917b318ef7077c6e01036]

        convert *CommandId enum to scoped enum
        
        merging two different enums in the process
        
        Change-Id: I81ff8f10158a19a1b3a4ffe35fac6653beb677ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154028
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a5c61b143d53bb10430b8a486874856c16a2d86c]

        tdf#155708 Fix validity dialog closes when moving focus to another window
        
        Do not close Validation window if click on another Calc sheet.
        
        Change-Id: I75569cbb91ebd445ac57f7a52d914297c21349e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153930
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [f98296117b2c27af73c093525ad828909fd8fb31]

        loplugin:unusedenumconstants
        
        Change-Id: I53817a6b017203d8694032320869d11412c57ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154027
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d2742b30968037a40eeb4679192c1706124965a5]

        Fix typo
        
        Change-Id: I72e6b45ab5ddd974c8f93633c5df511ca7cfdaf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154025
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-05  Szymon Kłos  <szymon.klos@collabora.com>  [ea030aeffd839f1078c137cb19cb1694d0581d42]

        lok: use correct shell when doing undo
        
        When doing undo we save EditShell reference in the context object.
        Later it is used to get cursor we want to move to the place
        where modification was done (in sw/source/core/undo/unins.cxx:281).
        
        In LOK case when 2 different sessions were used and undo was done
        by user A - then user's B cursor was moved. This fixes that issue.
        
        We use current shell instead of getting it indirectly through
        SwDoc::GetEditShell()
        
        Change-Id: I7a10ea98587f48818e8d0aaa9ad739d4eed514f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153461
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153986
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-05  Alain Romedenne  <alain.romedenne@libreoffice.org>  [05c3a3e12e6424d13a777f863921193ab7fe172e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd0f9167653bee82301d8635ef5a6ea494739183
          - SFDialogs help pages (final)
            - new methods: cloneControl, createDialog, OrderTabs
            - dialog creation on-the-fly
            
            Change-Id: I672f6ae27f59efca6a7e4118ce4538cf011cd72d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154005
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [4567008914239b26533c1968820bf461d606f96d]

        oox: fix crash in lcl_GetGluePointId
        
        See https://crashreport.libreoffice.org/stats/signature/static%20long%20oox::drawingml::lcl_GetGluePointId(const%20class%20com::sun::star::uno::Reference%3Ccom::sun::star::drawing::XShape%3E%20&%20const,%20long)
        
        Regression from b7c542b5085374f1d031183cb86ceeefcf24964d
        "tdf#154363 sd: fix line connectors regression of mirrored shapes"
        
        Change-Id: I926d32f5b68582df588c28a800b0ec10e7e3e19f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154021
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-05  Miklos Vajna  <vmiklos@collabora.com>  [79ddca4def81198e3eee42eca8aca42fef964c80]

        sw floattable: fix lost floating table right before a table from DOC
        
        The bugdoc has a floating table, anchored in a paragraph that is hidden
        via character formatting. The bugdoc also has a normal table. This leads
        to 1 table in Writer, but 2 tables in Word.
        
        We already have code that tries to make sure floating tables have a
        suitable anchor, see the code in WW8TabDesc::CreateSwTable(), but that
        checks for the case when the next node after a floating table would be
        table (and not text), instead of the hidden character property.
        
        Fix the problem by not creating the hidden char attribute in the first
        place in SwWW8ImplReader::SetToggleAttr() in case the pool item would be
        inserted at the paragraph start and we just inserted a floating table,
        which makes the 2nd table visible in Writer as well.
        
        This is for DOC, interesting when Word converts this document to DOCX,
        then the hidden attribute is removed, so there this is not really needed.
        
        Change-Id: I3a7411e6fcc318740bcbd4b0cde9f34134f384a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154017
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-05  Mike Kaganski  <mike.kaganski@collabora.com>  [1ca926cd6eff2df195e673397d7b34e0a4fb569b]

        Optimize a bit
        
        Do not create selection and calculate paragraph text string each time.
        
        Change-Id: I6781695c05e3bb26c2656cf841c0a9093f260c8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154020
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-05  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c5f726420ac7906d9c425bfa4958a5702d55bbd8]

        cid#1532449 Big parameter passed by value
        
        Change-Id: Iad69437b2349bda6729395a4e2bd876a1a6c968e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-05  anfanite396  <dipamt1729@gmail.com>  [03ba4196865bd445208f39f31475ea82b39b9e17]

        Move SwXFootnote Java tests to C++
        
        Change-Id: Id78be9ba0f42a7fcc4685b188de40dcfb4ccdbf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153589
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-05  Khaled Hosny  <khaled@libreoffice.org>  [d0790998da7b273d7acf83cb6dd81c1d46d9809f]

        Add all source directories as folder references to the Xcode project
        
        Instead of tracking individual files, hopefully this way I will always
        find the files I’m looking for while debugging.
        
        Change-Id: Ic9da2c576aebde6901a5c3907d24db5b84c01065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154019
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-05  Paris Oplopoios  <paris.oplopoios@collabora.com>  [63d019c6780733018ffc0b157a235cb57893d6d4]

        Make sure views get new themes on .uno:ChangeTheme
        
        It would be that sometimes .uno:ChangeTheme would not load the new
        scheme because it was using EditableConfig::GetCurrentSchemeName which
        uses a static name - normally great except for when you need different
        views to have different color schemes in tiled rendering
        
        Change-Id: I5b149bd1a4776337f76753c6de98d5386a899d34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153939
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        (cherry picked from commit 77f5b9259864798b6efc213f6dfa685cd440f71a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154001
        Tested-by: Jenkins

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a561775a486b5daf4b04b287dc3849b387ec388]

        loplugin:constantparam
        
        Change-Id: I0b4b2854f5e82e78e63b01b78b949e27011630c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153982
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [50d9f755a9a2894c2f6e781a3e5ccb94278761b8]

        loplugin:constantparam
        
        Change-Id: I1925234e3f82adfa1f82755e9cef7e3e3bc00d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153981
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [23583706b51f4c1cde8ceb20557fe376691fad88]

        loplugin:constantparam
        
        Change-Id: Ib7bba815fcd4d2d4092bdd96055517468f6c6b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153983
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-05  Mike Kaganski  <mike.kaganski@collabora.com>  [4cb31f481e8bc271a39aaa4953edda8d898413be]

        Related: tdf#131062 Simplify a bit
        
        The overly complicated processing was added in commit
        7f805108a4ccc5751d7cbcb722ded5247e398578 (tdf#131062 DOCX import:
        fix table-style paragraph background color, 2020-03-02). Setting
        sPropertyName to "ParaBackColor" was then nullified by not using
        its value for PROP_FILL_COLOR case, and using the old "FillColor"
        value instead. Likely that was just forgotten cleanup after some
        experimentation.
        
        Change-Id: I1facec63bf74a50b1f16a7accd243345c017a032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154016
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-05  Miklos Vajna  <vmiklos@collabora.com>  [e501e4549b3343f69b7ce19957e7bbc17d007d65]

        CppunitTest_sw_htmlexport: avoid reqif magic in testFieldShadeReqIf
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I949cae81ee74ac7f85e6ff6685fad74c200fa575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154015
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-05  Maxim Monastirsky  <momonasmon@gmail.com>  [c0f1f67bfd2853554b58127e91443526c44163d7]

        Swap .uno:FontColor for .uno:Color
        
        Following tdf#105293, which left some UI elements unchanged.
        This also simplifies the sidebar, as .uno:Color is universal
        while .uno:FontColor works only with Writer text. It also
        benefits tdf#154270, as using the same command in the toolbar
        and the sidebar will keep their color in sync.
        
        Change-Id: Ia6e1ffef4012b6f8db4c9079d0b0c99a59887670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154012
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d74344f6cae0cf1c12f08249c8f49be1374fb98f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccaa099da1def9e89347af3f1759f48f9fa538ba
          - Add bookmarks to PostgreSQL help page
            
            Change-Id: I8e3e52446b9b58e34faf479829ce72cfc4680f8b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154013
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [16a94d2b25198442af1257574bf88007c8b352f3]

        sw: fix crash in CreateParentXText
        
        See https://crashreport.libreoffice.org/stats/signature/SfxObjectShell::GetBaseModel()
        
        Change-Id: Idcfc8219b5765bca9c45819bde5f276ce68c45de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153971
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [58550b67a89b2aa189043e8c6a8be2e8a5976d84]

        sc: fix crash in ScInputHandler::ShowArgumentsTip
        
        See https://crashreport.libreoffice.org/stats/signature/ScInputHandler::ShowArgumentsTip(rtl::OUString%20&)
        
        Change-Id: I0fd61d5cca58121e77e102edd3c8e77c75baf800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153976
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Szymon Kłos  <szymon.klos@collabora.com>  [3e10169b0508d46ffea2e72f11608a19038b8016]

        jsdialog: enable sparkline dialog
        
        Change-Id: Iaf5de5c1c15313075afdf8dbc48dcb22da448fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152417
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153949
        Tested-by: Jenkins

2023-07-04  Szymon Kłos  <szymon.klos@collabora.com>  [d077c6bf7b1697abc977a8bea5b19cb624c4a5b1]

        jsdialog: lazy json generation when closing tab in dialog
        
        After profiling Writer -> Format -> Character dialog
        I found that full dialog update happens while creating
        the dialog as some of the tabs are destroyed.
        
        Instead of instant JSON generation we should
        add the message to the queue and send it in idle time.
        Problem is that we are closing the tab and it's builder
        so we will not be able to do it later.
        
        So using jsdialog::SendFullUpdate trigger update in parent
        dialog which shares the same WINDOW_ID.
        
        This behaviour can be tested in Highlight tab when switching
        between "Color" and "None". As previous solution was introduced
        for it in:
        
        commit 41a1a2f04301dc22b156b4e11767859e40473897
        jsdialog: don't close dialog on tab page destroy
        
        Change-Id: I916250cf08d87c1109dc2db6dbbc1fbff7f48c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152008
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153945
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2023-07-04  Szymon Kłos  <szymon.klos@collabora.com>  [16b0da38515467bf1819ccd88027934481cc5727]

        jsdialog: encode properly control characters
        
        according to https://www.rfc-editor.org/rfc/rfc7159#section-7
        strings in JSON should contain control characters (0x00-0x1f)
        encoded as \uXXXX
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I1f828f64e57328b5fa2dcf5853afe0d6ea643081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152262
        Reviewed-by: Attila Szűcs <attila.szucs@collabora.com>
        Tested-by: Attila Szűcs <attila.szucs@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153946
        Tested-by: Jenkins

2023-07-04  Szymon Kłos  <szymon.klos@collabora.com>  [8fc7ac5569592d5cd026d292202e8c51d670c241]

        lok: linking-api: export correct target string
        
        export target string instead of boolean so user
        can jump into the target using that.
        
        this is fix for:
        https://github.com/CollaboraOnline/online/issues/6230
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Id4b1a1c65ddcb6f4d94d3939dda9124f2d10e9d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151884
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153944

2023-07-04  Maxim Monastirsky  <momonasmon@gmail.com>  [8ffb8e164d9d350a1b9887d0a75e0a82892008ee]

        tdf#154270 Sync toolbar button recent colors
        
        As the last used color is stored per button instance, these
        will go out of sync with several buttons being visible (e.g.
        a toolbar and a sidebar, or a toolbar overflow popup), and
        will reset whenever the toolbar resets (e.g. change in
        selection, switch from print preview, or customization).
        
        Fix that by storing the last colors per-document, and
        notifying other buttons on changes. Keep the last color also
        stored per-button for now, as a fallback for reportdesign
        (which isn't sfx2 based).
        
        Change-Id: I866f1de5c8ff6f56c47dc4b6b5acf52957d4e6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153943
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [203476b6676505acafd1c41561800afd9316a0f6]

        loplugin:constantparam
        
        Change-Id: Iee554baae7239c9bf0ac35cab6ff235a88dc29a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153973
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f73e8c895e24fda10931ecf344a1a0dd8bcdf92c]

        unnecessary LogicToPixel in TabPage::Draw
        
        we are already using logical pixels here, and DrawBitmapEx wants logical
        pixels
        
        Change-Id: Ia099fbfbf33349003df23a93e1183472b27dc7a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2dacae0c8acfad8a5e5a16c766ee740ec202c5e]

        unnecessary LogicToPixel in ComboBox::Draw
        
        we are already using logical pixels here, and Draw wants logical pixels
        
        Change-Id: I5409abccef4473cbca4d38654a27a677e68d82f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Khaled Hosny  <khaled@libreoffice.org>  [c1dcffceb14cd35c7168ba2108b2f2e9aa875b56]

        tdf#156151: Take PDF DPI into account when outputting Type 3 glyphs
        
        We were always assuming the default 720 DPI, but this is not always true
        when printing to file as the DPI would depend on printer settings in
        this case.
        
        Change-Id: I747f8e24f0942ecb94eb8acfc1dd9972d83ba0e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153978
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [b036e563e699595fa7625888f11ab0c76f1abd66]

        tdf#141969: use paragraph autostyle to mimic Word's table style
        
        Word's table styles may define paragraph and character properties. They are
        handled in DomainMapperTableHandler::ApplyParagraphPropertiesFromTableStyle.
        
        When setting such a character property using setPropertyValue, it may apply
        to the text runs inside the paragraph, overriding values from character
        style and direct formatting, which must be kept.
        
        To fix that, this change creates a *paragraph* autostyle first, containing
        the properties; and then applies only this autostyle to the paragraph; the
        autostyle can't apply to runs, so the properties apply at paragraph level.
        
        Sadly, it is impossible to create a useful autostyle in writerfilter using
        UNO, because of the same problem that caused tdf#155945. UNO properties
        may define only parts of complex SfxPoolItem; setting them without having
        already applied values of such SfxPoolItem's would create wrong values for
        properties that weren't set by the UNO properties, but happen to share the
        same SfxPoolItem. To workaround that in writerfilter, a map of UNO names
        to sets of UNO names defining the complex property would be required, and
        then maintained.
        
        Instead, introduce a hidded 'ParaAutoStyleDef' property of SwXTextCursor,
        taking the same PropertyValue sequence as in XAutoStyleFamily::insertStyle.
        Implement it similarly to SwUnoCursorHelper::SetPropertyValues: first,
        build a WhichRangesContainer for specific WIDs needed for the properties;
        then obtain the actual values for these WIDs from the paragraph; and then
        set properties from the PropertyValue sequence.
        
        To create the autostyle properly, the code from SwXAutoStyleFamily::insertStyle
        is reused.
        
        There are more "proper" ways to fix this in part or as a whole, e.g.:
        
        * Split all complex SfxPoolItem's to simple ones, as done for one of them
          in commit db115bec9254417ef7a3faf687478fe5424ab378 (tdf#78510 sw,cui:
          split SvxLRSpaceItem for SwTextNode, SwTextFormatColl, 2023-02-24);
        
        * Rewrite writerfilter in sw;
        
        * Implement the missing proper table styles with paragraph and character
          properties, having the same precedence.
        
        But I don't feel crazy enough for any of these :D
        
        Change-Id: I07142cb23e8ec51f0e8ac8609f367ba247d94438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b2dc641d67c47ab9492f3d0a65bd57ea5d88311]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fd43ac04f55c78c7e323dc28509889d027f7a42
          - Fix a d'oh! you found a bug
            
            Change-Id: Id8da79e4ba7bad65143624318f76b8697d0a3445
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153980
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [7441aaa4c5b2215e369c62e22af098184e8ce807]

        unnecessary LogicToPixel in RadioButton::Draw
        
        we are already using logical pixels here, and ImplDraw wants logical
        pixels
        
        Change-Id: I0edc990c9943d68228600a15ccadca62127b02bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d408fe5cd45c9594feecec727ab2f73c66e361d0]

        unnecessary LogicToPixel in CheckBox::Draw
        
        we are already in logical pixels here, and the ImplDraw call expects
        logical pixels
        
        Change-Id: I7eab69b92998fd36c811fc7ac3949adb2f4fff7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153966
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [77befddec9486403c471b2beafd4ca0fd2429c5a]

        loplugin:unusedvarsglobal
        
        Change-Id: Ia86c8bd0bdc85c375eb3837ba97f9e171d9dac6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Nay Catina Dia-Schneebeli  <nc.dia_schneebeli@pm.me>  [798ea743033273714780ba7bcf5a29a9b6c2d4a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f3a4fe926e1c8b554160094d81087b9ab346a07
          - tdf#155031 Help page for Style Spotlight
            
            Change-Id: Id25e7aed6db62621e3fc4fd2e430efec8c6d397e
            Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153979
            Tested-by: Jenkins
            
2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6cf27e46a48580892ecd0d82f8e55ff9aed465d]

        tdf#156016: vcl_graphic_test: Add unittest
        
        Change-Id: I0b8a9c8d8440e5084f1cce6e666e20d4508cc691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153963
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2559baf56eed67dd97183d8852360866b5fe9d4e]

        32bit is enough for the word completion limit
        
        and we don't have to change the xcs in that case
        
        Change-Id: I246d81e4eccf3ce390b179ad6473db6ee4e4fdbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-04  Michael Stahl  <michael.stahl@allotropia.de>  [9410a22cdbe7c977206456218c75683a305ef79e]

        tdf#156155 sw: export draw:fill to top-level ODF graphic styles
        
        The default for XATTR_FILLSTYLE for Writer flys differs from the default
        in the item pool, which is intended for svx shapes/SdrObjects.
        
        This is implemented with an intermediate mpDfltFrameFormat but it needs
        some special handling so the attribute ends up in the styles.xml.
        
        Change-Id: I8f369809a9f3b7e85a8bc7ad5d309dbc3cd6ccfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153970
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [48d1573c0d862cb64cdbb4854bced60e5f0cdbaf]

        sc: fix crash in ScVbaWorksheet::Cells
        
        See https://crashreport.libreoffice.org/stats/signature/ScDocShell::GetDocument()
        
        Similar to 286a1c03fa10acf60f076a0af987112d24cb2ff5
        "sc: check excel::getDocShell"
        
        Change-Id: I102e575b4992e175d4e780ef2b43f887d94bbd24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153964
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [b88b9504503298996de1feaa3f86b1adf36563a2]

        sfx2: fix crash in SfxViewShell::StartPrint
        
        See https://crashreport.libreoffice.org/stats/signature/SfxViewShell::StartPrint(com::sun::star::uno::Sequence%3Ccom::sun::star::beans::PropertyValue%3E%20const%20&,bool,bool)
        
        Change-Id: I3d10414d4cfd027bf80ceaf6692bb7f92269f6c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153965
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [b68e4a2d0179558180085bfe28a32a1510aeb3e1]

        Fix build on Win64, where int != sal_Int32
        
        Change-Id: Id835da668042a656ace0f09a7fa9bc852b968b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153926
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c9e09af8ab85122e56bf0a40e1056248565ed75]

        CppunitTest_vcl_graphic_test: use CPPUNIT_TEST_FIXTURE()
        
        Avoiding the declaration/registration/definition of each
        test manually saves a lot of space.
        
        Change-Id: I8a310a6aca3e575f93737cc50e0614592a7ffc8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153958
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [cf40ee4a162da5f357793463e5707492030eb5df]

        CppunitTest_vcl_graphic_test: Demultiplex test code
        
        and relax hack a bit, enabling webp based on testname is
        dirty since they might change
        
        Change-Id: Id933095701d01426d2802d6a194d6f74c07baaa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153957
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5d439a07b60d505ac1a9fafad90849aa13f0c2aa]

        Fix typos
        
        Change-Id: I1049c2bec21caa751a37708023338a1449dc5539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153953
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-07-04  Michael Stahl  <michael.stahl@allotropia.de>  [dd4ce9b2fc7feaf288055b24b5bc4842c0d2b4de]

        tdf#152235 filter,vcl: PDF/UA export: tag watermark as Artifact
        
        Change-Id: I64e57a832678be935b69a5cea328cc252a4bf29d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153951
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef1c755e31971d92429d70fbab58446ccb2bfcda]

        Fix typo
        
        Change-Id: I14c4862788b3fe28f9c2f6b0ef41601192f5560e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153881
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [83d7f565101f154de23857537726dc11ca7bccb5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7656ffac6fbbacd8739ee690549517a8e0e49f6b
          - Fix typos
            
            Change-Id: I9b855f5b4af6c5cba368b5649ecce61d9dcfc202
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153952
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4e7bb39c3972d284ece80d5002c9411d3cd8c835]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 11126b46e48f2a504eafdc4cd14e43a0b532e8b3
          - Fix typo
            
            Change-Id: Ia94aac3b44f6c4a9b7671fef82f93fcc83bc7335
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153954
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a08e33a36364331a8c5c7d78345e6e691df0754]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77b7e3cd801902564050d17ffaa20754fed39347
          - Fix typo
            
            Change-Id: I943773674d5d57cd030075887fa60d92ff1068e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153955
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-07-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8808e52e922b748b2e7ce9ffa944c47da9db864]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b29c320e0e7a7fd2b0839e3aa7e353252a1f811
          - Fix typo
            
            Change-Id: I06f6b6f701ab87932f2f5784bf10ab0bdc838e8d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153956
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d697e25846433c3a589228262cf8d0f7b6f5fd7e]

        remove skia workaround
        
        No longer necessary since
        
            commit 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 27 10:48:45 2023 +0200
            Update skia to m111
        
        Change-Id: Icfef07ed3683e84bdd8b94350f40ea83e95bf324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Baole Fang  <baole.fang@gmail.com>  [254161f9dd2b7b3e416c54dfeb8e8c6e81cd7dcd]

        tdf#92311: increase word completion limit
        
        Change-Id: I0198327d235bdb4048e002aab211e20d1701fa6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153571
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-04  Regina Henschel  <rb.henschel@t-online.de>  [7fede2c47f8a24b80700fe3b82f71a0f60bffd3d]

        tdf#153487 First color item needs mnId = 1
        
        The SvxColorValueSet for the other color palettes is build so that the
        first item gets value 1 in its mnId component. But for the new theme
        color palette it was 0. That results in the error, that the first
        color (top-left in the dialog) could not be selected. An Id of value 0
        is handled as 'fail' in various places. Thus use starting mnId = 1 for
        theme color palette too.
        
        Change-Id: Ic0b63fee641d4424cabaf25a7f803acd734cbfa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153860
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8164915520b27b655372e7521b2a58978516f88d]

        sc: test export of model::Theme into theme1.xml with xpath
        
        Change-Id: I9b2b61a5ae93a0738fb90aa20b20f9a9ecc7272b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153786
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Caolán McNamara  <caolan.mcnamara@collabora.com>  [650ab6e645c51aaffc8dc5e638295d6da74d44ff]

        crashtesting: assert on exporting fdo68105-1.ods to xls
        
        and ooo101471-3.ods to xls
        
        Change-Id: Ieb5339664a2bb647e8a09a44e60cad651bf65247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-04  Stephan Bergmann  <sbergman@redhat.com>  [d1fc1c326470461def5ab092a311afee31950880]

        Fix Linux --without-system-libxml build
        
        ...after 362dfc50a28a918ec73609a00d2851eb3058375d "libxslt: upgrade to release
        1.1.38"
        
        Change-Id: Id0ebf5676f79c43bb4fab3a33a2a19e303881aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153942
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d1d1279790807235b1edcee8f807d594636fda7]

        ImplGetUnmirroredOutOffX can be const
        
        which avoids some unnecessary const_cast
        
        Change-Id: I8bf6a2ab36928dd1df302b64d9552f07f3f1003f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153932
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [42bbc9fbdf940e55213ee2a259c1d31de2e4cbec]

        sc: add border export and enable round-trip test
        
        Change-Id: I76071185d819b9645d97a3e599ea7f48b341a145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153820
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [20dbfa10d851b9df67fab561c3b86cba4f55cc8a]

        sc: OOXML export of theme colors for text and background
        
        Change-Id: Ifd0d8184c9210caa5ca099767baa5dbbf8783f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153785
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [80569dc996a9a814ad7c2e729f30443debdbc6fe]

        Fix a UITest on Windows
        
        Change-Id: I9645cea2394f945355f86b3f6013d1d0f5117c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153940
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-04  Jim Raykowski  <raykowj@gmail.com>  [c4515f6be4a0ec923d85fd6b4c85bfaafb0b26ae]

        tdf#156128 Make drawing object hyperlinks created by dnd
        
        from Navigator functional
        
        Change-Id: Ic12f3c43c079865e31c3bb89d9f277d3567d8c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153887
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [30ee52e6c284be1095fdf278439b4c0a7c5982f0]

        sc: change theme color for SdrObjects
        
        Change-Id: I318821c843fe937b7011f1674809f8c78df24a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153938
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [548e5b6d825606bd218ef18591df642872e6acd0]

        sc: fix failed assert in when setting a color on a shape
        
        When setting a color with a colorpicker, and assert failed,
        because it's not possible to clone a SfxItemSet by value - use
        a plane Clone instead, which clones into a SfxItemSet.
        
        Change-Id: I8780ed42d3807e9802d3f4fa1d68e16bd5d5a5e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153937
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cbc45a7f713ea1f2c44ed27b371e342ed7547e05]

        svx: PaletteManager - remove printf
        
        Change-Id: I7d631352d423b6465d8bea4b09561f33d2ad98f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153936
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [63a331b3118c62541dfec809b9cf35d258e78f2b]

        libatomic_ops: upgrade release to 7.8.0
        
        use new configure option (--disable-gpl) added in 7.8.0
        to skip building libatomic_ops_gpl.
        
        Change-Id: If4b3b1994399099906b306fb2ea22fa47a87300b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153886
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [2c733d79d8d1ce630711c5b9bcceb2b6f99eb51a]

        libpng: upgrade to release 1.6.40
        
        Change-Id: I2f366045097a6f063e26703b4132710573a40e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153879
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-04  Marco Cecchetti  <marco.cecchetti@collabora.com>  [dbd124519daa507f560fad4619c0b41f24001818]

        lok: on switching from tabbed to compact ui 2 buttons were disabled
        
        Number Format Increase Decimals, Number Format Decrease Decimals were
        not enabled on switching ui.
        
        Change-Id: Ia81a43ef40168dcbf071d071231b795f9bf8659e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153050
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit cd4ad81ca334a3d2bc90bab81502ae5350bac84d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153594
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-07-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [f283fc0fd3fe3c7406a2946e5e4ea66dead1b6ef]

        fix crashes in Bitmap::Invert
        
        after
            commit 0bfe57f50b79362ab1167388ba95c8f0bf988c4f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jul 3 11:25:02 2023 +0200
            fix assert when using skia and DBG_UTIL
        
        Change-Id: I95a77e13f93229696b3a1e4ba5a234afb3b3e957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153931
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-03  Dr. David Alan Gilbert  <dave@treblig.org>  [a780c820f5cf3bfbb5d88bd5c6ca670e0a0c730f]

        tdf#155630 Use common getPolygon for sd
        
        Unfortunately the SetLineEnds in sw is different enough from sw and sc
        to make sharing it a pain.  However we can share the GetPolygon function
        we already moved into svx.
        Expose the svx function into the header and use it in sd.
        
        Change-Id: I05b0f820286c8ce848fa0d6c69603d3625c2b4d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-03  Dr. David Alan Gilbert  <dave@treblig.org>  [f239b3dec1acbe7ad70df31e8264bb16ac095502]

        tdf#155630 Use common SetLineEnds in sw
        
        Use the shared SetLineEnds code from sw.
        
        Change-Id: Ie388bb00401b6eb956ad5dc9032f1fae2d62d471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153827
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-03  Dr. David Alan Gilbert  <dave@treblig.org>  [32fd602d3918be032d79322f76021c6ebc27ccba]

        tdf#155630 Move sc's SetLineEnds into svx
        
        SetLineEnds is duped in sc,sd and sw.  Swing SetLineEnds into
        svx where we'll share it.
        
        Note: a) We also move it's helper function getPolygon
          b) sc, sd and sw use different values for the magic nWidth value
             so parameterise
        Change-Id: I6011b41d9db7b7fab364038227e1866fb9d64b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153826
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [82a8ba2815006852cfdb5b945db2f3920e8c4102]

        crashtesting: crash on import of moz610347-2.svg
        
        Change-Id: I0793d00216586bf68b4b74305bba2f352eb320bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-03  Stephan Bergmann  <sbergman@redhat.com>  [4e3c8933bfe274874cbec203cd9345559822df9d]

        Drop unused include
        
        ...left over by c33e81615c85eb9acd5956973e3bbc27ea068b41
        "loplugin:unusedmethods" (cf. abandoned
        <https://gerrit.libreoffice.org/c/core/+/153329>
        "-Werror,-Wunused-private-field")
        
        SwShadowCursor::m_aCol became unused with
        f9f7cfc080c3adb751ceca96be4ca5440de4a2b6 "tdf#122970 Fix direct cursor leaving
        screen trail", which in turn caused all of the following to become unused, too:
        the second parameter of the SwShadowCursor ctor;
        SwViewOption::GetDirectCursorColor; SwViewOption::m_aColorConfig; and
        ColorConfigEntry::WRITERDIRECTCURSOR.
        
        Change-Id: I34d1249c4ddcb9fbfeb9bf97388a980d3a0334e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153880
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-03  Alain Romedenne  <alain.romedenne@libreoffice.org>  [75f7501f1caae5177ad0ff562eb9f0392a06f9bc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 257fec6735fa0d0e57c0c2d0220bd71ce987b947
          - SF Dialogs can be dynamic (WiP)
            
            cf. https://gerrit.libreoffice.org/c/core/+/151896
            Change-Id: I383a2f96394ea69a09265645d63e6dbb730f4e88
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153697
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-07-03  Khaled Hosny  <khaled@libreoffice.org>  [18575cc42464acdf28d8b5f271935f7dd87ec0fa]

        Make the test more explicit
        
        Add also comment about the embedded font.
        
        https: //lists.freedesktop.org/archives/libreoffice/2023-June/090532.html
        Change-Id: I65a7bb5e57bab2cdd4c9b322bee1d2b1b22a8813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153621
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-03  Khaled Hosny  <khaled@libreoffice.org>  [13c4456ca382a92b93395db367ef8edb27a349fa]

        tdf#48707: Explicitly set overline color in PDF export
        
        Like we do with underline color, so that color does not leak from
        elsewhere.
        
        Change-Id: I3716a117a0d0a1260e47cbfed2242f401a09d7b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153877
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [13a41e7a12598c7896d6dc8d34aba6af5b80b83c]

        tdf#150124: do nothing when parent is of unkown type
        
        Change-Id: I745b2a81200b0d8138b5f1b844849f20571d9546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153878
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-07-03  anfanite396  <dipamt1729@gmail.com>  [ba4aa9e6f0e4947d1e111bdb4c765a6b58307d48]

        Move SwXHeadFootText Java tests to C++
        
        Change-Id: I9288d5d9835cf4559daac720c368a2d8f8222165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153636
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-03  anfanite396  <dipamt1729@gmail.com>  [5a3e0414e6f613ea417c4868faceb210274ad0f0]

        Move SwXBookmark Java tests to C++
        
        Change-Id: I6a4b62ba6815ba6d88c9ab1b59c7e30556520a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153534
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-03  anfanite396  <dipamt1729@gmail.com>  [a4e44a55f96fd6bc0be1afe9018944d3d8d3930e]

        Move SwXFootnotes Java tests to C++
        
        Change-Id: I905ed0b99d6fd6bb73b1278b62d5e06b25f410c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153635
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-03  Khaled Hosny  <khaled@libreoffice.org>  [6ae13c5fc5b28efeb1f6b75d4f6574bae20af37c]

        Rename and move header next to other font headers
        
        Change-Id: I5485817b5a6c2e9538ed6fb00893663d09e7fa26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153869
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-03  Khaled Hosny  <khaled@libreoffice.org>  [206f8b905dc00b86f9926a3ee6b503bd56bc0115]

        Rename ImplFontMetricData -> FontMetricData
        
        Change-Id: I0f8753a5ef1865f4ea0431125e74d0f52aa1c396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153868
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-07-03  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [362dfc50a28a918ec73609a00d2851eb3058375d]

        libxslt: upgrade to release 1.1.38
        
        Change-Id: I0534d7e02c9486b3d58f56e1a26fe6846b4a20b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153874
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-03  Michael Stahl  <michael.stahl@allotropia.de>  [9eacbf7874320d44b79966cac8fa59c52a191715]

        tdf#152231 vcl: PDF/UA export: content of comments in the margin
        
        ... is also Artifact.
        
        The problem is that ImpEditEngine::Paint() always produces tags,
        it can't easily check if it's inside a layout environment that is an
        Artifact.
        
        But it looks like PDFWriterImpl::beginStructureElement() already wants
        to handle and suppress a structure element inside a NonStruct, except
        that it calls endStructureElementMCSeq() before checkEmitStructure(),
        so no structure marked content sequence is produced, but the content is
        outside the Artifact marked content sequence, and possibly a second
        Artifact marked content sequence will be opened once the structure
        element is finished.
        
        (btw, it's allowed to nest marked content sequences in PDF, but
        nesting a structure element inside an Artifact appears dubious)
        
        Change-Id: Ib3eef9c611e28242854c712ce974fd8cfecd8ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153810
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-03  Michael Stahl  <michael.stahl@allotropia.de>  [20901a1a8633dc693cfd6354d0b660b81c242b70]

        tdf#152231 sw: PDF/UA export: tag comments in the margin as Artifact
        
        Comments aren't part of the document content.
        
        There is a separate option "Comments as PDF annotations" in the dialog
        that can be enabled even in addition to "Comments in margin" for getting
        something that's presumably accessible in PDF readers.
        
        This doesn't work completely yet, because EditEngine still produces tags.
        
        Change-Id: I66c020103a69f1d1fbbf317ae6b638158cd51868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153809
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [0bfe57f50b79362ab1167388ba95c8f0bf988c4f]

        fix assert when using skia and DBG_UTIL
        
        after
            commit 72f2de04a23680fcb75cf5bc89b3422f9e89cdef
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jun 30 15:02:16 2023 +0200
            optimised Skia Invert() operation
        
        Change-Id: I173b5a4693d4aefff82c45059874ee21b1e93996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3fc6a189933440ac318074a10d9612a7f04df048]

        tdf#152575 Fix missing comment export in some cases
        
        Comments in margin were not exported to PDF when there was no comment
        on the first page.
        
        Change-Id: I102834d6e39b0cf471e4b28f7f6b112ad52c54a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153870
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-03  Juan C. Sanz  <jcsanz@libreoffice.org>  [ff9ca1a96b868c955144fd6fc347f2be72be2e48]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00fdaa24ea0de17c8036c3dd594890d6bf666d16
          - Add new content to the PostgreSQL connection page
            
            Change-Id: I350aa8090026bd151c4a22e9b326dbe5ce304763
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153831
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-07-03  Mike Kaganski  <mike.kaganski@collabora.com>  [fd65712dc90634036b4ddc9fcfa0bcf58db917d3]

        Fix a copy-paste error
        
        Thanks Miklos for spotting this!
        
        Change-Id: I6cdba2a2c6280fa1cb85e3ab8172b3e66aeda1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153890
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-03  Michael Stahl  <michael.stahl@allotropia.de>  [a225b4dbd46897903b217969da5f97f2660022c9]

        tdf#152231 vcl,sw: PDF/UA export: fix comments in the margin
        
        If enabled, the comments mess up the structure elements, because the
        PageSyncData::mActions stores indexes into the GDIMetaFile::m_aList
        vector, and in PageSyncData::PlaySyncPageAct() the indexes don't match.
        
        This is because SwViewShell::PrintOrPDFExport() replaces the GDIMetaFile
        with a temporary one, then records the page content, then applies
        scaling to the temporary one and replays it, recording with the original
        one; somehow replaying a temporary GDIMetaFile with 270 actions to one
        that already has 4 actions results in 392 actions.
        
        It's not obvious how this can work with the temporary GDIMetaFile, so
        try to get rid of it; not sure if there any drawbacks to this but the
        GDIMetaFile is freshly created by the caller in any case.
        
        Change-Id: Ic297367ea307aa8eee8d609751d06abf417e9629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153808
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-07-03  Paris Oplopoios  <paris.oplopoios@collabora.com>  [7f1012806f5cf2cd53e52d8f2a95c09a2215efbc]

        Delete DrawViewShell copy constructors
        
        DrawViewShell does not get copied so best to set these to deleted to
        highlight this.
        
        Change-Id: I3d35d3a47137b15346d54a08d3d7af480b0872bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153864
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-07-03  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7678bb123d79eed1bdb1c74bda7ca6cc239e7078]

        license: add frozen
        
        Change-Id: I3dc6dd34344c0afd6cfcc3d771990e07307d432b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153867
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-03  Miklos Vajna  <vmiklos@collabora.com>  [16b5b21d36da87be9b50235acbbb8008ed23b8bb]

        sw floattable: fix negative vert offset with on page boundary without anch text
        
        The bugdoc has 3 floating tables on page 1, and the anchor of the last
        floating table goes to page 2. All anchors are empty (no text), apart
        from serving as an anchor for the floating tables. The last floating
        table goes to page 2 in Writer, but not in Word.
        
        The problem is quite similar to what commit
        2d0a4ef1d83b8de6cb133970c2c35ae706fb058e (sw floattable: fix negative
        vertical offset handling on page boundary, 2023-06-20) fixed already,
        but here the anchor of the floating table is empty, and there it had
        some text, which is a different codepath.
        
        Fix the problem by first requesting a frame split in
        SwTextFrame::FormatAdjust() even for empty paragraphs with flys (so the
        fly part can go to page 1 and the empty paragraph can go to page 2) and
        second disabling the SwTextFrame::FormatEmpty() optimization that would
        assume no split is needed, while a split is required for a correct
        layout here.
        
        With this, the DOCX version of the original bnc#816603 document finally
        renders without overlaps (4 pages, 11 floating tables).
        
        Change-Id: Ie64ce92bf19b3dee8059fa14294d7599b41cc53f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153866
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-03  Mike Kaganski  <mike.kaganski@collabora.com>  [64216c8b2c451659a1f08211685e4d8ac2685de8]

        No need to name the temporaries
        
        Change-Id: Idadb3473afd7890d329cc8effff7ec985d06c2e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153846
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-03  DaeHyun Sung  <sungdh86+git@gmail.com>  [4ffa5f2d741368bcc70ec3fd5d5ca1249cfc1e37]

        tdf#155947 Korean word default font size is 10pt
        
        Korean word processors(HWP & MS Word) default font size is 10pt.
        So, I set to 10pt on LibreOffice Writer.
        
        Change-Id: Ic31332e37b3b450589ded6df243aae6961fdf394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153324
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-07-03  Miklos Vajna  <vmiklos@collabora.com>  [fc5760cfa0609da29f5b794896e7762ba199c5f6]

        svx: prefix members of FrPair
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib12ffa50150b5c5b9a60c57088a627972708482a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153865
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-07-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f551747116ab6d1d05b46fb4b3d0d66d180a01ec]

        tdf#156094 - Add "Go to" button to "Avoid footnotes" issues
        
        And the button points to the footnote anchor point in the text content.
        
        Change-Id: I3193714a69a432094cd194a60223b255a6c8f24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153805
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-03  Balazs Varga  <balazs.varga.extern@allotropia.de>  [a89d05840e59c41b6122d551e4dfc26fd3ee515f]

        tdf#156096 - A11Y - Fix moving the cursor from selected frame object
        
        after we 'GOTO' an a11y frame issue.
        
        Change-Id: Ia828b2ac72edfc2045090d22ccdf3f95d1877170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153742
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-07-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e4e5fb4b2935e395c7e4b3a794d544a6f44709ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed6df33b51517b0abe9a763fd5bea45ba7dd0b9b
          - clarify that data has to be selected to be sorted in Writer
            
            Change-Id: I22d4757d1c0908e2740104b83c8e1e44df01102b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153861
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-07-02  Jim Raykowski  <raykowj@gmail.com>  [4f9294ec702a82765c04c8652dddec4dda1e6075]

        tdf#156112 SwNavigator: Disallow footnote and endnote dnd
        
        Change-Id: I892f8a34f43629f3e76aa187299dc8c805b72545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153855
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [756bef92bebe7d8549ed4ddbf560a1b1e63af885]

        Drop redundant assignment
        
        Assigned the same value a couple lines above.
        
        Change-Id: Id1117189142fab373f5057f8f48a49b265a07fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153842
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [72f2de04a23680fcb75cf5bc89b3422f9e89cdef]

        optimised Skia Invert() operation
        
        which is not that important right now, but my upcoming
        transparency->alpha patch will make more heavy use of Invert(),
        and this change will reduce the cost of that
        
        Change-Id: I53d8dfbf153f16f4d94022527c71d70d08392dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [13f3ccd125e42cc01a7f262434ae935adbe5e192]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 3fdd5e2b1d652e4ee7212c934d916971fc74a203
          - tdf#156101 add en-IL alongside the other English locales
            
            Change-Id: Iae8812e6bd0f10c2ecbf2f985d465e8fd1c4993e
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/153852
            Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
            Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
            
2023-07-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [968428500501e247529ab998af0f8a1921782b0b]

        pAttr is always dereferenced, use a reference instead of a pointer
        
        Change-Id: I76ebce9085b9e47a6c571ddbcafa44d0d3a0f97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [884a2cd39a7c0433a5bbbf4e83e2a9b16cdad71c]

        loplugin:singlevalfields
        
        Change-Id: I091fac5ed41b2fb58dee5e3e1b8dd805c8dc4966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-07-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [99c0922f9b16e0f2a015db41f1acbeece3cc5e69]

        Fix typo
        
        Change-Id: I0fd7f5aaa51e58ec88daad30f003bf5c853385b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153853
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-07-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9a6cdc8a90cd32e8d9ecdae6fb6684cfa8aadbab]

        sc: OOXML import and export the model::Theme properly
        
        Change-Id: I76fc928a53d007a9f5e9174167e0594208a4b47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153784
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c7d202a61f9ce81b76b29e61252c23aa66daff07]

        cid#1532376 Big parameter passed by value
        
        Change-Id: I6e0717ce5b035c1a4f4ec3abbd23ae60c98c8181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153851
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-01  Khaled Hosny  <khaled@libreoffice.org>  [c3a4f689f44d83e3e9520bc280c566c83c4f2b5e]

        Remove option to set printer language type
        
        Drop support for changing printer language type from printer properties
        dialog, in preparation for dropping support for PostScript printing.
        
        This is a follow up to:
        
        commit 2a40505d00fcd79bfa433c301ddc05a35287bfb1
        Date:   Thu Jan 26 11:49:43 2023 +0000
        
            remove option to toggle IsPDFAsStandardPrintJobFormat from UI
        
        Change-Id: I970d627588396d6ff648d6e6304e449da7ec1425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-01  Khaled Hosny  <khaled@libreoffice.org>  [b1c97304f135702e53e6aa48483ede31eaa54fec]

        Resave with glade
        
        Change-Id: I9ef19ef10be497842be25e03fb72d97d1465bedf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-01  Stephan Bergmann  <sbergman@redhat.com>  [5135348ca36ba35dac9b40bc7ad78009b881f9f4]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/1e12b1f1de1f5f3dbe65f2f973d411388166f4ed>
        "Change gvfs source back to download.gnome.org",
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/dc0eccf0258c430602c07ad38f12bc084f716162>
        "Add metadata for flatpak-external-data-checker",
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/155bff6463688904e14db1374393894daa459492>
        "Update bundled krb5",
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ec8c3556e423d435599a5b24234caa5ffe9db2a7>
        "Reformat the JSON source (#240)", and
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e09a13847fdc6c18d42aa99fa476e2b736c0c9e0>
        "Update gvfs-1.50.4.tar.xz to 1.50.5 (#244)".
        
        Change-Id: I970276ebe815b9dd2f61000abcb1a726cfd258ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153787
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-07-01  Justin Luth  <jluth@mail.com>  [d0bbc16b1715a3711d872a36c7e525e8d3811669]

        Revert "tdf#126006 sc SID_RELOAD: restart notebookbar"
        
        This reverts 24.2 commit 0211c88f884065aa179725bd2eb846edd4c5bb6b.
        
        Although it passed on Jenkins, my own computer seems to hang
        on UITests - both Writer and Calc.
        
        Change-Id: I57e8a176cce55a514490db81f211582c0ad86675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153829
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d31f61f47293b1ea9b9d86def4a412c3c45797b5]

        cid#1533667 silence Uninitialized scalar variable
        
        Change-Id: I6121ed3f9a316172423c9ffc2104510498a58d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [92ec5c70691778ccff8a37be361e638379ee6b4d]

        cid#1500458 help coverity see that Dereference after null check is false
        
        Change-Id: Ieb61797fa230d4b7d7650cfcb8b7c988bf292189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-07-01  Justin Luth  <jluth@mail.com>  [0211c88f884065aa179725bd2eb846edd4c5bb6b]

        tdf#126006 sc SID_RELOAD: restart notebookbar
        
        Change-Id: Icca41461d203615be58f9cf1214b82d70ee55ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153818
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-07-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f0c8ccaef39dc7cb876e00679f70c36ca60883d9]

        sc: improve import tests for text, background, border theme colors
        
        Change-Id: Icdc658e47c0e4fe20b2b38897d31278f058a6a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153783
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-07-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [8492195582a546b607bb15bc61adb64dcd74b904]

        Upgrade Harfbuzz to 7.3.0
        
        Release Notes:
        https://github.com/harfbuzz/harfbuzz/releases/tag/7.2.0 (v7.2.0)
        https://github.com/harfbuzz/harfbuzz/releases/tag/7.3.0 (v7.3.0)
        
        Change-Id: I4f57b7e829f2356b5e2b442ff00df555121c0e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153729
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c1fe534ae49e7e97b5965a5d1fbf910598215102]

        upgrade libwebp to 1.3.1
        
        Fixes CVE-2023-1999.
        
        Change-Id: I3d0f5f718242977156729521d14efb1a8d71aee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153819
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [e693d340a86e4e5f16c3beda062aaec3a71e5e2e]

        Use getXWeak in ucb
        
        Change-Id: Id94a89596bd473ed8c83d7be89ba673d8dc1bba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150878
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c5bd661dc032ed8f664b0eac47f246d4d51b4d2c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e39f60457632012b51159df1616b3cce8514ebca
          - Synch term between UI and Help - Slide menu
            
            Change-Id: I0b4d924befa43633f9ef3da1cdb99b3ac760416f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153832
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [396f7dfc17ceb24de8cfa0a9480943f7b397f8f4]

        mbFrameView is dead since
        
        commit 407731c9f403c35357a0d1428c9b99835f79a5f7
            Author: Noel Grandin <noel@peralex.com>
            Date:   Tue Jul 21 10:44:17 2015 +0200
            loplugin:unusedmethods sw
        
        removed the SetFrameView() method, which in turn
        was dead since
        
            commit 1c6da69ba2bc437d826573c7909a220290a67311
            Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com>
            Date:   Mon Nov 30 12:56:05 2009 +0100
            [CWS autorecovery] removed some dead/unused stuff
        
        Change-Id: I6e74dd7609ecd6ce459b6397a852caa6bde7fac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-30  Justin Luth  <jluth@mail.com>  [f7f96175d37d87b266e85726ae01877a39251f16]

        tdf#141720 sw pagemargincontrol: add more options
        
        There are advanced gutter controls available,
        so lets just add more options to this one as well.
        
        It already exists for Page Size and Page Columns.
        
        Change-Id: I5a94044fd18b57962272d8099cf17fdb71e83d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153775
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-30  Justin Luth  <jluth@mail.com>  [3f35fd1a37b22ac0d501ae2aa1d39e12969c7628]

        Revert "tdf#118335 notebookbar: set visible false for PrintPreview in MenuFile"
        
        This reverts 24.2 commit 506db23af4da2c5c8775fb0fd6fb9b8668e2fe86,
        because the PopupLabel has been removed, so the label showing for Print Preview
        is now "Print Preview" instead of "Close Preview".
        
        Because it is a toggle, it will have a checkmark as the picture
        when the feature is active (and thus would act as a close preview).
        
        The "close preview" instances were converted to .uno:ClosePreview
        to allow the PopupLabel to be removed.
        
        Change-Id: I7c38e863b39d3f3979466a8ab10f29dcda561d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153811
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-30  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [59abf300e342556ad9cdcd5fd57b9d887776c441]

        MCGR: tdf#155913 Non-supported attributes for TransparenceGradient
        
        In ODF spec there is no
        - MID_GRADIENT_STARTINTENSITY
        - MID_GRADIENT_ENDINTENSITY
        - MID_GRADIENT_STEPCOUNT
        so these should not be used in the core data, too. The last one
        leads to this error.
        
        I experimentally added to hanle these 'harder' in the UNO API
        implementation, too, to reflect that these are not supported
        and produce UNO API access errors. This is not urgently
        necessary, but let's see if that triggers problems.
        
        That these attributes were initially supported is due to the
        Item hosting those values for transparency gradient is directly
        derived from gradient and the implementations usually use the
        fallback to call the parent implementation(s).
        
        Change-Id: I982c4047d82bfe306dbcef9d1b64b8d212bf8d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153799
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-06-30  Justin Luth  <jluth@mail.com>  [cc836756d35df4ab8f54a24bd495dd1b8e1c6be9]

        tdf#118335 remove "Close Preview" PopupLabel from uno:PrintPreview
        
        The PopupLabel cannot be depended on to only be used
        when PrintPreview is already running.
        Specifically, in the notebookbar menus,
        it always said "Close Preview" even when
        the preview was not yet toggled on.
        
        Instead, use uno:ClosePreview in contexts
        that only show up when the preview is running.
        This has already been done in LO codebase.
        
        Change-Id: I3c743da895f9ac4febc18329f251d283c0cec1cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153779
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c33e81615c85eb9acd5956973e3bbc27ea068b41]

        loplugin:unusedmethods
        
        Change-Id: I8d3402a69237b665462e04440ad73fe29e2133db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153807
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [105f057f5b994b7d79a55ca719240839c2d45b54]

        Throw correct exception, and do not warn
        
        Change-Id: Ia4548d377e6f9104b5f2b3a7a6cebe4928f51506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153801
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [b391d6e2934fb5f6417a4ac37d510816e0773942]

        tdf#118087: set matrix as default value for type
        
        From https://www.w3.org/TR/SVG11/filters.html#feColorMatrixElement
        "If attribute ‘type’ is not specified, then the effect is as if a value
        of matrix were specified."
        
        Change-Id: I8ddaa9129661d9a9f51c474461cf788d8d524a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153804
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-30  Julien Nabet  <serval2412@yahoo.fr>  [32d8db9bb6d8d3e2dcfe3d3317505bca3cb870ca]

        tdf#156090: "Counting" and "Start at" are reversed in "Footnotes and Endnotes"
        
        Change-Id: I58d4643aa37fb2f63544cfe3a26d14d4d04a9384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153802
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-06-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d3a6694c0245100f6c83cabd2a9473dab07c1763]

        crashtesting: assert/crash on export of fdo66241-1.ods to xls
        
        and others, e.g.
        
        ooo101471-3.odf fdo68105-1.ods fdo66241-1.ods
        fdo68105-2.ods fdo64646-4.xls ooo101471-2.sxc
        
        Change-Id: I5a639cc6539130bc6a7ada00652d02529544f650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153800
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-30  Amin Irgaliev  <irgaliev01@mail.ru>  [431dc963a0d18341c9b4869a2a64009b7ff7f699]

        tdf#125543 Fix window size in GTK3 plugin
        
        When importing a csv file, the size of the main window Calc in windowed mode were not set
        because of erroneous check for widget visibility in gtk3.
        Now it isn't the visibility of the widget that is checked, but whether the checked widget is a window.
        A similar problem was observed in Base
        
        Change-Id: I48f882f407ba17c6c983c5b0939b9ff789ee59f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153670
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a815a1dbc765df464a36f120ff32c2a834c1fc8f]

        postgresql: upgrade to release 13.11
        
        CVE-2023-2454 and CVE-2023-2455 don't affect LibreOffice.
        
        Release Notes: https://www.postgresql.org/docs/release/13.11/
        
        Change-Id: I1de521b6aa9af1e6d84ea794b0f4f5d62de377f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153728
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-06-30  Maxim Monastirsky  <momonasmon@gmail.com>  [ce391e52fbb759997f7e2c225513cc074a0f3974]

        Drop SfxStyleSheetBasePool::SetParent
        
        Use SfxStyleSheetBase::SetParent directly instead. The
        base class was just calling it anyway, while the
        SwDocStyleSheetPool override was mostly a copy & paste
        of its override in SwDocStyleSheet.
        
        Change-Id: I18d8208ed2d079e0f2ce4f13a5dbdda6fe4730e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153773
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [263264315102519a0557bbf69beeaffb7ed6c873]

        partially revert "loplugin:unusedmethods"
        
        partially revert
            commit 74cd0d0b281f8df75612bfb600df2eae62c4d21d
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jun 29 13:53:30 2023 +0200
            loplugin:unusedmethods
        
        It generates
        /home/tdf/lode/jenkins/workspace/lo_gerrit/tb/src_master/extensions/source/update/ui/updatecheckui.cxx:35:10:
        fatal error: vcl/menubarupdateicon.hxx: No such file or directory
        10054          #include <vcl/menubarupdateicon.hxx>
        10055                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I42cd6f5fecf7c0154f5d733119d5cdac0830182d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-30  Khaled Hosny  <khaled@libreoffice.org>  [6c51710969003c0b97e4739d515fe5734798b92d]

        tdf#156084: Fix PDF export of bitmap color fonts
        
        A regression from the commit below caused the resources dictionary of
        the Type 3 font to be omitted making the images inaccessible:
        
        commit 845fbfcce9091e541bab657163b026aad8648261
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Jun 15 06:27:38 2023 +0300
        
            Don’t add empty Fonts dictionary to Type 3 font resources
        
        Change-Id: I479ca328bd1b1228ba722678d3d9686c8456b350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153780
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-30  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [d1ee7e816cc8f4edd146a035cd37ef848738bc21]

        Fix typos in external/libtommath/README
        
        The LibTom Projects website is not "http://www.libtom.org/"
        but "https://www.libtom.net/"
        
        Change-Id: I2334242aef7ed82de94e8814a8102d2ef970745a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153781
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-30  gilssonn  <gilsonnyirimana@gmail.com>  [d61baaff35e6b180c17b3d93309f00e0255e1a9b]

        Corrective and refactoring changes in drawinglayer module
        
        Correct and simplify comparison logic
        and use std::transform for vector assignment.
        
        Change-Id: Idc92137db6d4648547a410f2cfd7e26edc797370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152842
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-06-30  Mike Kaganski  <mike.kaganski@collabora.com>  [4e20f95cf6744ca85bc8c090b926031729addc89]

        tdf#156091: handle OWN_ATTR_TEXTCOLUMNS in SdStyleSheet::getPropertyValue_Impl
        
        Somehow I failed to implement this from start. In commit
        95ebd24a629b4c8cd62cc20c0701683512cc8fa0 (editengine-columns:
        ODF support [API CHANGE], 2021-06-08), I implemented its
        support in SdStyleSheet::getPropertyState; then, in commit
        f2ea39c70da3f82bb39f8b51b5484172360b1fc2 (Avoid crash getting
        default item for OWN_ATTR_TEXTCOLUMNS, 2021-06-22), I added
        its support in SdStyleSheet::setPropertyValue; and finally,
        the time has come to support getting its value. Better late
        than never.
        
        Change-Id: Ifa1f933f00336bf6d01a5c71d0c92baf846ccabb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-30  Justin Luth  <jluth@mail.com>  [7afa9ba25311e70d31cd5bce66191c3d785630cc]

        sw doc import: suggest setting ADD_EXT_LEADING = false might be wrong
        
        Historically, it switched from forcing on to forcing off.
        A bug report suggests it shouldn't do either one...
        
        Change-Id: I4a1326bfe83ed0aa3e4948c71534148154271e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153776
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-29  László Németh  <nemeth@numbertext.org>  [7520349b61a74e93a1d5d992f41b60631c3c5937]

        tdf#146346 fix unit test & extend it to empty multi-page footnote
        
        Implementing multi-page floating tables resulted a partial
        regression here: not last table of the footnote, but empty
        paragraph under it resulted an empty split footnote on the
        second page, without noticing the problem.
        
        Problem with the previous unit test of tdf#146346 was
        reported by Mike Kaganski: "using getPages, does *not*
        fail when there are two pages - because getPages is
        (problematically) implemented as jumping to the end of
        the document (body!), and texting which page is this; and
        for the original problem, only a part of footnotes moved
        to the second page, while all the body text was on the page 1."
        
        Add unit test to catch the original problem (all tables of the
        footnote must be on the first page), which fix likely wasn't
        tested correctly using only getPages(), also add a (disabled) test
        for the new regression, too.
        
        Follow-up to commit d1ac8df139a2a65db45d1970ccc0b80e17d827f6
        "tdf#146346 DOCX import: fix table margins in footnotes".
        
        Change-Id: I6006db3fe2b5e6f7029a8a2d5d9cf99a17ec2ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153739
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-29  Justin Luth  <jluth@mail.com>  [736cf835b9edb7a18fa52a12b03c252a9b63ff7c]

        tdf#118335 use .uno:ClosePreview instead of PrintPreview
        
        in contexts where only closing the preview is useful.
        
        Doing this will allow us to get rid of the PopupLabel on PrintPreview
        
        Change-Id: Iebd02af2dee12726e601d79e94252d3bfacb2dd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153730
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-29  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1b4f40165850ffdc0399d39390878925ef5e9be4]

        Point to LO DevGuide instead of OOo
        
        Change-Id: Ib8ac0a69491f4cab3fbb1b4ba7ab29e55d3c8350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153774
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [7881ae1ee91b5739f8d6b8adfac04bc432717a9a]

        Use getXWeak in svx
        
        Change-Id: I7e5c029a79b8437ae5f803df5ad20217c240d1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150874
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [74c9fd3ae5b63981fb256e019f0cf974329157f0]

        tdf#156066: Add support for feImage filter
        
        Change-Id: I76cf8932ae352c271283483c9c734408a35b6074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153770
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [210f2345c2eea2c52b673e2327a2ed096d9a888a]

        svgio: simplify code
        
        Change-Id: I18c4179c36c052cc0ed5b416125e72d542cb7407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153749
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-29  Gabor Kelemen  <kelemeng@ubuntu.com>  [c48e810f1a856d392b2ffce6b343082406644ab8]

        [API CHANGE] Drop deprecated org/openoffice/ucb/InteractionHandler.xcs file
        
        Deprecated in 2010 by
        commit af66a011a47f673a9a0ee2c6a0b27e23b11b6ebf
        
        Change-Id: I805f9771fe3730f3e186162cab9ea192517a4f2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152401
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-29  Gabor Kelemen  <kelemeng@ubuntu.com>  [29d91a668c86a61bc406f34bcb36d8dc9d9bc6b6]

        [API CHANGE] Drop deprecated FormulaSyntax property
        
        It was marked as deprecated when added in 2010
        commit 81571e00b1b423929459ffdb34fd519e7f3d0961
        could not find whether it was used ever since
        
        Change-Id: I2c14c923f07d97d1df0604b95b3c65b350248029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152403
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [26d191e8ee53a38d350c10d5666c6dd8629c8ab2]

        m_aMouseClickHdl is dead
        
        It was added in
        
            commit c706fde1c4ecc6974bcf32ce33aacf3093355ae1
            Resolves: tdf#156067 merge special char dialog/popup logic
        
        But is never assigned a useful value
        
        Change-Id: I476b00a96c53298414239509b2ca5452f0bf08c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153743
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fdfc6eb3fd37f87d51d1836d01259a14a4346a45]

        fix cross-compilation with frozen headers
        
        FROZEN wasn't part of the PERMITTED_BUILD_TARGETS in configure.ac, that
        in turn means it is not part of BUILD_TYPE when building the crossbuild
        build-tools.
        That in turn means gb_Helper_optional in external/Module_external.mk
        doesn't add it to the external module dirs, and that means the makefiles
        from external/frozen aren't read, more specifically there won't be any
        gb_UnpackedTarball_UnpackedTarball,frozen definition.
        
        The UnpackedTarball definitions don't error out in this case, and the
        gb_Library_use_extenals,module,frozen then doesn't work as expected. It
        happily depends on the UnpackedTarball_get_final_target for frozen, but
        since there is nothing to unpack (since the makefiles with the
        definitions are skipped) that is a noop/it goes straight to just touch
        workdir_for_build/UnpackedTarball/frozen.update to fulfill the
        dependency without actually extracting any files.
        
        This patch deals with the first problem only, adding it to the
        PERMITTED_BUILD_TARGETS will allow the mechanism to work as intended.
        
        Change-Id: Ie9e8ad47ba4c281fb3246daf67450a16f792b908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153747
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [74cd0d0b281f8df75612bfb600df2eae62c4d21d]

        loplugin:unusedmethods
        
        Change-Id: I95ab7581dec35b113cb657ce8e5ee27c89c73593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c51f2e0dfdddfe0efb4218d2cd1deefd90b6eff]

        various XLink fields are dead
        
        after
            commit 195364a57a5e3090648cb327607bc52da2be583c
            Date:   Thu Jun 8 13:49:11 2023 +0200
            tdf#155733: no need to store these values
        
        Change-Id: I4a998add0079cbbcf9eaba38a43fc5411647dd64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153745
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d24564ef01396f1a66dcd971f11e34d84d65d7d]

        mbIsUIReadOnly is dead
        
        after I removed SetUIReadOnly in
            commit e2c7a6bd572644b928704f6cb3696b568ac0aba1
            loplugin::unusedmethods
        
        and that was dead because of
            commit cb32938d572777c9a5d75007cc76ba50c5a698eb
            [API CHANGE] remove unused SlideSorterService
        
        Change-Id: Ib0e170794e0f448b094b3d1ca5d309deab4c1bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [62d9d507fc8739722df2e45483b29910f2743699]

        loplugin:unusedfields make it a little smarter
        
        around dealing with operator[] on map data-types
        
        Change-Id: Idd6654948ae2d03d634fcf30a8d98530a78ab4ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c89b7f4a31298360e14663f3c192e4e832759a1f]

        set->unordered_set
        
        which is more efficient, and we don't need ordering here
        
        Change-Id: I1af4412d94680f4449a2eb00168f6c4cef20bd06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153741
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Paris Oplopoios  <paris.oplopoios@collabora.com>  [8dfde7d69a8bbdc8ce88aefded231b94e30271d6]

        tdf#104877 Implement APNG blending modes
        
        Change-Id: Ib7ce4d113ccaa4843b8332087ebe52ac3828180e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153556
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [532e37c8127c9ae8bc1c455ef2d582e6d2252fb5]

        XML-encode text that will appear in ReqIF
        
        Change-Id: I56ced6717496d6c0a5fe0bcb86de47ae4142e953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153738
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [2d8e0ce32d6dccc3441c25dc29bb60489f886ea0]

        ReqIF: add unit test for frame text in 'object' elements' alt text
        
        Change-Id: I369ee9a4e50d758f2a463f79e37e60fb38ca49b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153734
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Gabor Kelemen  <kelemeng@ubuntu.com>  [95e5001d934fb2e27173087c64443b160bf0593f]

        [API CHANGE] Drop obsolete Mapping config key
        
        Obsoleted in 2010 by
        commit c79b576a3dbbbce2a67c6215a4180ac060131790
        
        Change-Id: Iaca64f7560d485338d9de9be19e09d69a83c0d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152402
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-29  Aron Budea  <aron.budea@collabora.com>  [19fbd6862302065cdf490085d1a8fea49f73d6ca]

        tdf#155706 tdf#86630 sw page number wizard: make OK default
        
        Change-Id: If1b902d34157be8c9eab2d5ec140f5e85dfc49e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153731
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [3eba3f6c22b9de02b22a2e3fe3d348940db81e13]

        getComplexColor: return a const reference, to avoid an extra copy
        
        Change-Id: I28ff81c08be4e18169fe8b8fcd67818ea5319d9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [64ecbdd1e56982b4dc72eb97016bb39e472a21d9]

        Fix build
        
        Failing like
        
          ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class Color const & __cdecl SvxBrushItem::GetColor(void)const " (__imp_?GetColor@SvxBrushItem@@QEBAAEBVColor@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ)
          ThemeImportExportTest.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class model::ComplexColor const & __cdecl SvxBrushItem::getComplexColor(void)const " (__imp_?getComplexColor@SvxBrushItem@@QEBAAEBVComplexColor@model@@XZ) referenced in function "public: void __cdecl testCellBackgroundThemeColor::TestBody(void)" (?TestBody@testCellBackgroundThemeColor@@QEAAXXZ)
          C:\lo\src\build\workdir\LinkTarget\CppunitTest\test_sc_theme_import_export_test.dll : fatal error LNK1120: 2 unresolved externals
        
        Change-Id: I7a64405e3e8bf774163d8f101681c2c0de892767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153736
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [429d26a7386413ebccdedf72f9ac0115b1b6db1b]

        Simplify a bit
        
        Change-Id: Ia1c142d9841075f307fba69f79999697992a5c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153735
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Noel Grandin  <noelgrandin@collabora.co.uk>  [8863ca276efd7f915b7e3584172a1adb09643237]

        increase space around tabbed pane titles
        
        Tabbed pane titles are currently incredibly cramped,
        increase the space a little to make them match better
        with current OS layouts (all of the different OSes
        we support use quite a lot of space around the
        titles)
        
        Change-Id: If9c7b4df81f8d206556e7c75097650ae21508384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [14c40c460526f2e4ed2c24a3f50baae25a43a8f2]

        tdf#156066: Add support for feDropShadow filter
        
        Change-Id: I0b2772a7211efb91821853e3369cfc3a5ef6a932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153727
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-29  Julien Nabet  <serval2412@yahoo.fr>  [db591df99424dd7e1837946b36ca0658a02d520c]

        tdf#152723: NatNum12 modifier, keep decimal separator from local settings
        
        Change-Id: If49e7b42ac37eead4ef0a902b2e56735bb4017bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153732
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-06-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [3b250bcd95f6be183b2694c57512eba9b1a0ca67]

        tdf#156032 - A11Y: fix remove of empty issue sections
        
        Remove issue categories if there is no more issue in it.
        
        Change-Id: Ic5dddf3db59c574d1e8712d79bdf203a6b637eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153724
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2023-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [e2ee51b6b2aa2cbb347f99b8c7b1aee0ad8e5f9c]

        ReqIF: output frame text instead of name in 'object' elements' alt text
        
        Change-Id: I79d827edf00143e06b2601018fdf647d6d342355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153721
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [da8dead8e9282010893cbd12519e107baf03cd1a]

        tdf#73537 - sc: show author and creation date in calc comments
        
        in temporory mode. Show the author and creation/modification
        date of the the comment only in temporory mode. In edit mode, or
        visible mode, shows only the original text.
        
        Change-Id: I2c5856e4c6a813dbef4ad55de319f922daa57f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153358
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-06-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b3594e01ec6d0156277f354efe5cacc04b33c4b6]

        tdf#154981 - A11Y sidebar: fix warning missing signature line desc
        
        Add graphic shape objects to "Go to" and "Fix" functions.
        
        Change-Id: I258d3664613cbd53b7b26aaa8d88715660d921dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152707
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [160ea29f0003812ab1d4e1f6689c608c879ef509]

        maLayoutLineToPageId and maLayoutPageIdToLine are dead.
        
        I removed the code in ImplDrawItem that added data to them,
        because ImplDrawItem was only ever called with bLayout with false,
        and removing the bLayout param removed that code.
        That removal happened in:
        
            commit f0f973da8560e16cba85d2c9465c3a8c4c0ebbb3
            Author: Noel Grandin <noel@peralex.com>
            Date:   Wed Mar 16 08:49:35 2016 +0200
            loplugin:constantparams in vcl/
        
        And that happened because....
        I noticed that ImplPaint was only ever called with bLayout==false,
        which meant I removed that param and passed bLayout==false to
        ImplDrawItem,
        in:
        
            commit 911ae0aeca443fb4b5e400ae0f939567b580e443
            Author: Noel Grandin <noel@peralex.com>
            Date:   Fri Feb 26 09:36:26 2016 +0200
            loplugin:unuseddefaultparams in /include/vcl
        
        which was because the last call to ImplPaint with bLayout == true
        was removed in:
        
            commit a6b9d9a19fb8c5c9f166682f52941aee25b89c94
            Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
            Date:   Wed May 6 13:00:13 2015 +0900
            refactor "TabControl" to use RenderContext
        
        Change-Id: Id234257201726de95e2c10bfacb30670123ca8a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153713
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0c12b34ac593ea5ac6615f844f709074ab1b6c1c]

        tdf#156031 - UX/A11Y: Clicking on a11y check status bar icon opening a11y
        
        check sidebar deck.
        
        Clicing on the a11y check status bar icon, the a11y check sidebar
        deck will be opened.
        
        Change-Id: Iee2e0e9345ed47dd971a9a61e55471d082d5461d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153723
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d17603b9ad8b82d98eb2bca0ec4dd9bac02b7766]

        tdf#156023 - A11Y: Add visual hints when fixing an accessibility check issue
        
        Go to the issue object and select it, before fixing the issue.
        
        Change-Id: I0217922c91045c288df7e48965be259e4d4f7ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153642
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-29  Laurent Balland  <laurent.balland@mailo.fr>  [125b0f6609332523d30bef600979b698c2d216f8]

        tdf#155526 Restore status bar for moving average
        
        Previous commit	dc03f59374d4fc74dd44ddedc903bb9c00a74bb7 broke text in
        status bar when a moving average trend line is selected
        
        Change-Id: I259fb9aee1eccf9fac93038c6dd2755490769f88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153677
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-29  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c2018d21b64ef47ab10228915b8fdd52b36c75bc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6bba9672d36c691c779ce6d40bbf816e661ec882
          - related tdf#153721 new command names: move/delete "chapter" -> "heading"
            
            Change-Id: I7415fec49fec0319583a5f87e44e7bd3ee96ef4a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153656
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e836e69eb6f2f01a475c5679fb338dda7936643f]

        sc: Add import tests for text, background, border theme colors
        
        Change-Id: I03f0ddb42e6491618e56ba98f5bd8befc9ba47a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153506
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7501f8928264c48c88ab6ee6b757b295b13b63d4]

        sc: use ComplexColor for font color (+others) in OOXML export
        
        Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ba29922dcc0a7b079fb76df445c4cd3a80102e83]

        oox: convert Excel tint value into LumOff and LumMod
        
        tint value can be converted into LumOff and LumMod values, so we
        don't need a special Excel case for calculating the final color.
        
        Change-Id: I0725c06f9df6a37a309ea5d17b183e4100a228f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153716
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [e24a3a3c339d7a175ebfeef31a280becda9d5950]

        tdf#156078: Use TabOverSpacing compat option instead of TabOverflow
        
        As Justin Luth noted, "TabOverflow is basically always true", and
        using it basically equal to making the test always true. On the
        other hand, TabOverSpacing is accurate for the task.
        
        Change-Id: I608b200dac0169cbafc935a03452aac9ba0527a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153722
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-28  Justin Luth  <jluth@mail.com>  [73ac60c4c3a209d23642ac4d0e8c4ac6dba22d86]

        tdf#148416 saveas: preserve loadreadonly with password
        
        If a document is set to load readonly,
        and that setting is password protected,
        then at least suggest using a password on save-as.
        
        Change-Id: I788da43733470e56af988e7c4b9f2cae01573e50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153726
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-28  Justin Luth  <justin.luth@collabora.com>  [49e34144a8148bf3c77bcfd70bf6c628dcefeedd]

        tdf#148416 password dialog: suggest current loadreadonly status
        
        If a document is set to load readonly,
        and the user saves with a password,
        then suggest LoadReadOnly status
        by pre-populating and displaying the checkbox for that setting
        
        Change-Id: I3e848b6f97ed4218d066e8f1790cb8fbea8b208c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153725
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-28  Regina Henschel  <rb.henschel@t-online.de>  [48a9ade1dacc63e61cc9a5748f29119d1d01d841]

        tdf#107787 Sync FillGradientStepCount and StepCount
        
        The FillGradientStepCount property of a shape or page background and
        the StepCount member of the Gradient2 API struct or nStepCount member
        of the basegfx::BGradient class are used parallel and mixed. Therefore
        we need to be careful to keep the values in sync as far as possible.
        
        Change-Id: I58ab9654ba0106417794fafe68fb296e66cb3bf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153714
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0b3518c50c138bd4c4d02c9c2316eb638bdf9460]

        Fix typo
        
        Change-Id: I21b6a4ae3cac15891a6b50bf975658ac404aefa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153613
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [985ac59356a62ff30518355235c66e0e3126fbb6]

        Fix typo
        
        Change-Id: I4c55e4a263a01fd4fa1d84feb49ac97bed793a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153710
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-28  Michael Stahl  <michael.stahl@allotropia.de>  [ff8ec4cfe5df1e15c3e9f6adc843dfe31358e097]

        tdf#156077 sw: layout: call AssertFlyPages() in Init()
        
        The bugdoc has 3 pages, and there are at-page flys anchored to the 3rd
        page, and these are not displayed - simply missing from the layout.
        
        In LO 6.1, this worked because the layout-cache was read from the file,
        and 3 pages were created in SwRootFrame::Init() calling InsertCnt_().
        
        But now this creates only 2 pages, and later SwLayAction creates the 2nd
        page between the existing ones on some MoveFwd(), but despite page nr 2
        becoming page nr 3 nothing attaches the at-page flys to the now-page-3.
        
        If a document is loaded containing at-page flys, then all pages that
        have flys anchored to them should be created in SwRootFrame::Init()
        already.
        
        (regression from commit 7e8b4756d95057f069467b34e7849f9354856578)
        
        Change-Id: I4792c483a7620efd81211e6ad0d9220152367d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153720
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-28  Michael Stahl  <michael.stahl@allotropia.de>  [695dac86a6862a031060793b65052fbd20f2ba7d]

        flat-odf-cleanup.py: remove unused user field decls
        
        Change-Id: I5271f975ee8bae558dc00bcf8ea778a3203bbc18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153719
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-28  Alain Romedenne  <alain.romedenne@libreoffice.org>  [52831bbdd39f37750ecb1bebb99d3cdfe4b3d315]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 114401853f335d1e85edee8229c4450c575f1f0c
          - New features of SF_Dialog and SF_DialogControl services (WiP)
            Change-Id: I5806e7c9cd014bd92e58b2f9aa739a610050ea76
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153598
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-06-28  Paris Oplopoios  <paris.oplopoios@collabora.com>  [367e9205e10d10cb564bb462dea821ce554b99da]

        Send writer document background color on theme change
        
        Send the doc background color to the kit on theme change
        
        Change-Id: Ic025e542417da004c1c4a2bfd58a858deb4caa58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153715
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-28  Henry Castro  <hcastro@collabora.com>  [56c303a0382003fa0030e55a420c1600fddb6673]

        sc: prefix m_* ScViewFunctionSet class members
        
        ..
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153405
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit 8276b9593a2a9e3a0d5aaeaadd64369667120303)
        
        Change-Id: Ic16ae0fc6580e350444576a087c333d52296ec5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153663
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2023-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [88fcc30cf2f130168eb522a2a2b5f8e5725378b8]

        these TAB_ constants do not need to be in the header file
        
        they can be inside the .cxx file
        
        Also rename slightly and document.
        
        Change-Id: Iffd46e9ed6c02aad597a616ac1c583ae657fab40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-28  Tünde Tóth  <toth.tunde@nisz.hu>  [863a32171ed8efdf1aaee59918e49613e7ccd7a9]

        tdf155903 DOCX export: fix corrupt file with embedded media
        
        Regression from commit bc72514f90d90e1ab3fed8167663e835edf03508
        "tdf#53970 PPTX: fix export of embedded media files".
        
        Change-Id: I04521227346817d91f720b1f6a77beb7f4a01f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153619
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2023-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [dbd0f224cfaf669ccfcbf300ccc0c11c904ec037]

        Simplify SvxSearchItem::PutValue a bit
        
        Change-Id: I2cbc5dce800b773e6c20cb3ea6f0e520a3f69db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153688
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-28  Michael Stahl  <michael.stahl@allotropia.de>  [79241a1fd32ab03cd2bb34fb303ce7f2fa93e57e]

        tdf#146547 sfx2: preserve modified state from read-only to editable
        
        SfxViewFrame::ExecReload_Impl() calls DoSaveCompleted() which resets the
        modified state, but in this case the document wasn't actually saved.
        
        Change-Id: I54f6508a652cc42a127bc59058c5b435dd1a25a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153676
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-28  anfanite396  <dipamt1729@gmail.com>  [50e154fe5cea061a1b820ab2135d4d60b7bc1bc9]

        Move SwXFootnoteText Java tests to C++
        
        Change-Id: I7f3477799f532f52993cd0add51185bfd15c7446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153631
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [67c807ada5d7930f262ace9798629c06f0175a86]

        Drop i18nutil::SearchOptions
        
        It was mostly unused by now, only remained in a couple of function
        arguments, where callers actually passed SearchOptions2, and where
        internally it was converted back to SearchOptions2.
        
        Change-Id: Ib188ec3bf0de6d1f70a04eb90fb3a577df8b3d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153687
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-28  Michael Stahl  <michael.stahl@allotropia.de>  [b1ce8bb078904db1df542f7a1c2ed527dde1a2d3]

        xmloff: ODF import: adapt generator parsing to 2-digit major versions
        
        DocumentInfo currently assumes that a LO version encoded in "BuildId"
        property has only 1 digit major version, which is now wrong and would
        start to give incorrect results when major version "30" will be detected
        as LO_3x.
        
        Add the dots as separators into the BuildId because it's not going to
        work without.
        
        Change-Id: I8918afe3642cbefa8488c57658f1505c9a20eddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153649
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-28  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [f1b0aca6bf520626d3c9a1fac67cd2de2c10c78c]

        Related tdf#106556 - Spotlight DF on the main menu
        
        Added to the Format menu
        
        Change-Id: I9b601aa4b55e9ce5a78fd8306d72baee71fd357f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153641
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-06-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a18f318a13d4a9b81f717498d3a02ee274542de]

        tdf#156066: Add support for feFlood filter
        
        Change-Id: I4d01d40edd6fb91555fd734fc8378df1cbd5743a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153684
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c706fde1c4ecc6974bcf32ce33aacf3093355ae1]

        Resolves: tdf#156067 merge special char dialog/popup logic
        
        there was some cut and paste done to create the popup
        at some point, so put it back together and reuse the
        "delete recent" etc which is missing from the popup case
        
        Change-Id: Idc33d83ea04b46b0255e77bcecf565dc8174e426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153647
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c58f9dac4ed9123bed2869957f866e409b6db9fe]

        Fix typo
        
        Change-Id: I0b4abdb362b86a3e1f622a04411e9f9ea0062295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153674
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8eb695574986fdda5147adf958432c31a354592]

        Fix typo
        
        Change-Id: I41ca7f8c9b998436f0b2810236161697e9f501c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153675
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [56da3d41bbd2f7c48dc108a8697757b1493030e0]

        Fix typo
        
        Change-Id: I7e77830bb32c100e3ae5c2d5aaa8fb6ba5f69d4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153673
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [dbfa56424f3d41bb58b7c9137f25f4ccb76dc92d]

        tdf#156078: also consider TabOverflow for tabs outside of line bounds
        
        Before commit 29bd00f7628e7a54e69cabcc7e2a1792c24aa55c, TabOverMargin
        compat option was set for DOCX with any compat mode. After that commit,
        the unset option disallowed output of content after a tab stop outside
        of the paragraph indents, even within page margins.
        
        SwTabPortion::PreFormat consults TabOverflow when checking if position
        is outside the frame; so let's consult it also when painting.
        
        Change-Id: I05ada0da6cd765c70b7bad1287ccc8c11d9b60ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153672
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ae5cb9b75984d9a63b392d8bfc5b3d224f00c741]

        Simplify a bit
        
        Change-Id: Iad2564853a2a0d74cd526b1574e421e121fd6986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153644
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-28  luigiiucci  <luigi.iucci@collabora.com>  [3551d18404cb19cdaa8edb170a549f5c5405d0cb]

        Header columns can disappear with filtered data in pivot tables
        
        When we set on a pivot table a filter that filters all the rows,
        the pivot table showed only the first header columns and computed
        column, but all the columns headers should still be shown so we can
        adjust the filter for the column. This fixes this issue.
        
        Also add more debug output and prevent a crash when running pivot
        table tests.
        
        Change-Id: I30b4ee72cf8436c4522ab4ba0781462b214816dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151871
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [6838fbbc5c52ae001dbffcffb8e86922ece02cd8]

        Fix gpgme build on Windows
        
        Commit 97c67afac1ec9351d0a64011a7ddfb7dfa876484 (Update gpgme to 1.20.0,
        2023-06-23) defined ssize_t in external/gpgmepp/w32-build-fixes.patch.1.
        It was done to address the use of ssize_t in src/debug.h, appeared in
        https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=patch;h=7d1159c1e99bb1bae0ab698c85105dcdcb95b7ea
        
        This led to build errors like
        
          C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\workdir\UnpackedTarball\gpgmepp\src\debug.h(26): error C2371: 'ssize_t': redefinition; different basic types
          C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\workdir\UnpackedTarball\libassuan\src\assuan.h(47): note: see declaration of 'ssize_t'
        
        To fix it locally, just revert the problematic patch, until fixed upstream.
        
        Change-Id: Ib89496cc08b0ce6d24d5c9e9c7e615c6909d071b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153671
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c685e244f44271e0dde1960e0973da9708576fe]

        remove this SAL_WARN
        
        has not revealed anything interesting on jenkins
        
        Change-Id: I15ebabc171dbb38f440ec607ea05be9b807bdea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [858dfb53598ed379a2e72c887a7f77909b550ca0]

        Fix typo
        
        Change-Id: I8dee1f762a39b21e88609d1d108846623d0b8bc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153207
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3b06c1835e9fcbbcdcd6ce2b207301f4f8bb6388]

        MCGR: tdf#155479 always propagate SVG-flag for sub-content metafiles
        
        For SVG export it is necessary to always propagate the SVG-flag for
        metafiles in *any* case impDumpToMetaFile is used and a new metafile
        gets created (aContentMetafile here).
        This is due to the subContent again may have any combinations of
        gradients/transparenceGradients that are non-vcl-renderable and need
        special handling.
        
        Change-Id: I7edee8afa81c0b6f3fb0e183d144c50f29c5bb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153645
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-06-27  Laurent Balland  <laurent.balland@mailo.fr>  [983644d061e1415c7c5554dd6fd51fe1043e9b9a]

        Import CSV: remove erroneous warning
        
        If Fixed width is selected, clicking on any option in Other section generates a
        warning about option not allowed, which is wrong. Only checkboxes in
        Seprator section are not allowed
        
        Change-Id: I3fc6fd6ac870e8c681aae8fd1d033b550d9bc20d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152573
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-06-27  Laurent Balland  <laurent.balland@mailo.fr>  [8ef4d3a4160af967937e9bb7c60bee4a8eb71a1b]

        related tdf#153993 Embedded text in scientific numbers
        
        Embedded text was limited to number:number. But scientific notation may
        require embedded text like
        0.000" "000E+00
        This change extend ODF format to support embedded text in
        number:scientific-number also
        
        Change-Id: I4e3220b06efbd9228d722bf518e137d7707ccf4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150804
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-06-27  Eike Rathke  <erack@redhat.com>  [bc82afbfd320ecf5e7ed5dc87d1606b97dd10821]

        Update language-subtag-registry to 2023-05-11
        
        Change-Id: Ieb1c3eab66c06c8e7b3d9751d9e4548dbd7efc04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153643
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-27  anfanite396  <dipamt1729@gmail.com>  [dab294beb861b651e02ff8598aa5b30fd852f5d3]

        Move SwXFootnotesSupplier Java tests to C++
        
        Change-Id: Ib6b33d33dc813400526b0d641faefbfdeea9fc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153610
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [c8caee61ff392db8bcf630309324b46d962886e1]

        tdf#156068: Add support for feOffset filter
        
        Change-Id: I1b3dea0ee4f9eb2ee7498962b04baaf5ba68855c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153629
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-27  Regina Henschel  <rb.henschel@t-online.de>  [9321f8602ec903e1e311b831da0504826e1e4f90]

        tdf#145130 Keep existing gradient geometry using sidebar
        
        When setting the start or end color of a gradient of a slide using the
        sidebar, the new colors were set to a default gradient instead of using
        the existing one.
        
        Change-Id: I0212d2d88e7eb144334308dedd057958ae0a8287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153634
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [f5bf91ea73bf8a7cd3abc0f343ab2bdceaad905a]

        tdf#54768 sc: fix resizing of cropped images to original size
        
        This is a follow up to commit a4e12cbfc69cfe668fa30756a3c5843e911e22b1
        (tdf#155863 sd: fix resizing of cropped images to original size)
        
        Change-Id: I923ed8b1df6c6559d527d43e4abe842497c4c28f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153449
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [3e0537a6e746db6ea746af6b91f94aeb9d2b05d9]

        tdf#156028 sc: use color of the highest value if only one value
        
        (in a single cell or the same value repeating in all cells of the
        data set) on percentile color scale, like other spreadsheets do.
        
        This is a follow up to commit 6a059f8d1b0a7a5b64bd272e1e7b8291979bcd56
        (tdf#155321 sc: fix color of the highest value on percentile color scale
        if the highest value occurs multiple times in the data set.)
        
        Change-Id: I630df332e403705e8338e3441af093c2de95c280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153577
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-06-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6870e22ada9363d86ba8aa0908d49018d76037bb]

        Fix typo
        
        Change-Id: I3934967d97ee3841b37882355a5006738679976a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153639
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [e266d448f45348f27f8291ea5d0542747d7c8168]

        loplugin:stringstatic look for more strings
        
        that can be initialised at compile-time instead of runtime
        
        Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-27  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [05c6cdb144d1732ca51d463845fa6ddef7c08265]

        Update ICU to 73.2
        
        Remove external/icu/ubsan.patch.1 that was applied upstream.
        
        See https://icu.unicode.org/download/73
        
        Change-Id: Ic2bc450b093f1c0ddb09ebe915a9c3e70d7e0964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153574
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [28e9f2bc390e10339859306ad5f733d377134ca8]

        sc: import and prop. theme color support for cell borders
        
        Adds import for theme colors for cell borders and UNO properties
        for the cell border theme (complex) colors.
        
        Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [22ab4f30ac2125579c43ad889f7b8b45b1dda3e3]

        add an --enable-cairo-rgba to set the order of pixels for internal cairo
        
        Change-Id: Ieab2ef59f63a7722bffea3273d2eeefadef47b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153628
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-27  Laurent Balland  <laurent.balland@mailo.fr>  [aa86e7e8c22527eb5da0b8a05dbd4bd749f7a2b8]

        tdf#155526 Moving average: remove Insert R2
        
        Moving average trend line does not R² value.
        This change remove "Insert R²" from context menu when the trend is of
        type "Moving average"
        
        Change-Id: I729a6421df34859e7176c798a2b68a6f13cfb544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153294
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [191814f47afd2dd6340e1da4499ca794d6dff268]

        sw: simplify SwXTextFrame UNO API test
        
        make it more inline to Calc UNO API tests
        
        Change-Id: I92e3f4f9b7286ea402cc0e869fec24ee9d2c05e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153611
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-27  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [097cf021cb946da7ebc6fe548fb035aec2d4eaa5]

        lok: only publish MEDIA_SHAPE to selecting view
        
        We now publish the url for the media shape
        in the LOK_CALLBACK_GRAPHIC_SELECTION message.
        
        This has many advantages, most notably that it
        only sends the URL to the view selecting the
        media. Also, it is now easier to handle
        the message as there is no need for both
        a LOK_CALLBACK_GRAPHIC_SELECTION and
        a LOK_CALLBACK_MEDIA_SHAPE. However, the
        latter is still defined as we might still
        use it at some point.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-06-27  Justin Luth  <jluth@mail.com>  [609a1567d0e60ca11800df56059b97b6a61ad117]

        tdf#151548 ContentControls vba: allow search by float #2
        
        I don't know how to figure out where the basic parsing
        is mishandling the double-specifier of "#",
        so just hack in a re-attempt to find a control with the
        name of an unfound index.
        
        This should be fine. If it really was specifying an index,
        then it won't get to this code.
        
        If the number is larger than the index and a control exists
        with that id, then it almost certainly was intended as a name.
        If by some chance it wasn't, then instead of the code failing,
        it will actually go ahead with the operation.
        
        Since in practical terms this won't happen,
        just go ahead and fix the likely case of a
        positive-number-as-a-name control not being found.
        
        Change-Id: I2a34184d86b99a50fdc6b806264f1d5e7794ad48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153630
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-27  Justin Luth  <jluth@mail.com>  [b0f55a04f081ff7f566c3ba5b6d6d6be3675e0f7]

        tdf#123026 sc xlsx: provide per-sheet optimal row height setting
        
        This patch is a pre-requisite for a follow-up patch
        which will run SetOptimalRowHeight on all un-sized rows
        on FILEOPEN.
        
        XLSX sheets can provide a default height for all rows on that sheet.
        That imported/round-tripped well.
        However, if Calc optimizes these rows, the undefined rows likely
        will change height - since the default XLSX row height tends to be
        300 twips, while Calc uses 256 (in ScGlobal::nStdRowHeight).
        
        This patch allows a sheet to define its optimal row height,
        so that running .uno:SetOptimalRowHeight doesn't change
        any row heights, and doesn't cause all kinds of new row definitions.
        
        make CppunitTest_sc_subsequent_filters_test2 \
            CPPUNIT_TEST_NAME=testTdf123026_optimalRowHeight
        
        Change-Id: I35008107d71f66375c7e9469e559f3836cf14df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152909
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-06-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [9951ffedd6941234447b9655fbc49ed6ca4cc64c]

        Revert "tdf#132246, tdf#155735: Add support for SourceAlpha"
        
        This reverts commit 75399b8aad6c0f0998b9d0a6eddb2e29f8bc114c.
        
        it was incomplete.
        While at it, do not parse 'in' attribute for now, so only
        in="SourceGraphic" is used.
        Implementing the 'in' attribute is not trivial
        
        Change-Id: I66c721c1144638f5e3759e0aa3a1c2c062499a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153627
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-26  Pranam Lashkari  <lpranam@collabora.com>  [1be3ab048d417611055a76d1776a0a69eb6fc6dd]

        LOK: send state of DataFilterAutoFilter
        
        Change-Id: Ib71dcdb6b02f3c1e9e1c552a718cb03e7cd9a4b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153532
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        (cherry picked from commit 0407d4290617dc717abed3ea48f1abf3cf1d750f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153602
        Tested-by: Jenkins

2023-06-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [930eb99a712a3ad9b76e9edb68bbcea68af36656]

        tdf#156038, tdf#78232: support css child combinator
        
        Change-Id: I874c368f66db97017357030867f1255551996228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153626
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [897fce4abd0c731bf697ca1e38a8049f66f9ac7c]

        svgio: simplify code
        
        Change-Id: Ie363236a4b2e2d74d583b9f842b48743eefa9d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153625
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fb3dfbd57d91307de383d401c1caf4bb0d9029b9]

        tdf#153721  label change: "Move Chapter..." -> "Move Heading..."
        
        Change-Id: I61fd56566f7a2726492db6fb93699c18dbd2d2ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153591
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-06-26  Henry Castro  <hcastro@collabora.com>  [2f6859071031841be0126bc01587fcef0f8b8208]

        sc: filter: oox: fix crash delete ScDatabarFormatData
        
        Unfortunately, the instance of "ScDatabarFormatData" is
        deleted before finalizeImport is called.
        
        The "maEntries" is not usable, the global format buffer is
        required to hold the reference.
        
         #1 0x7f2ef19081c0 in oox::xls::CondFormatBuffer::finalizeImport() co-23.05-asan/sc/source/filter/oox/condformatbuffer.cxx:1322:23
            #2 0x7f2ef1b9999a in oox::xls::WorksheetGlobals::finalizeWorksheetImport() co-23.05-asan/sc/source/filter/oox/worksheethelper.cxx:942:22
            #3 0x7f2ef58d030e in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) co-23.05-asan/sax/source/fastparser/fastparser.cxx:910:36
            #4 0x7f2ef23f0e46 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) co-23.05-asan/oox/source/core/fastparser.cxx:121:15
            #5 0x7f2ef23f1544 in
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ieb3840cc10372867d5462a19d9efa9771f633437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [633be9b03c870d9f242279e7f8617ae6daaef460]

        attempted fix for sporadic hang on macos
        
        Change-Id: I75d624eb98a87cb15f41be02631205cb86d7d270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-26  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [97c67afac1ec9351d0a64011a7ddfb7dfa876484]

        Update gpgme to 1.20.0
        
        * remove external/gpgmepp/0001-cpp-Fix-building-with-C-11.patch.1
          and external/gpgmepp/gcc9.patch that were applied upstream.
        * remove unneccesary external/gpgmepp/macos-include.patch.
        * remove a bit of external/gpgmepp/w32-build-fixes.patch.1
          that was applied upstream.
        
        Change-Id: I9982a3a47e62a5e06e3c04ddc3ee3f247eefa8ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153544
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2023-06-26  Luigi Iucci  <luigi.iucci@collabora.com>  [46fa17b70db0d543518dde52908f46c85838ac12]

        problem pasting to calc an image copied from firefox (windows)
        
        Calc tries to paste the image as html.
        In case both HTML_SIMPLE and BITMAP flavors are present in
        the clipboard, we paste as BITMAP
        
        Change-Id: I2527bedf11eb6986b58329acaf360a397af03101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153614
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2023-06-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [424e537b9f02aadef60c9b0c29f27503f7d7d51a]

        Fix typo
        
        Change-Id: Ic071259d68e0fa9d7a2541e32d30c11bb0f21d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153612
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-26  anfanite396  <dipamt1729@gmail.com>  [ed78d54f7caf1d556ed16f8c78437845541377be]

        Move SwXBodyText Java tests to C++
        
        Change-Id: I5d2807125fb374d8d05718d8bf5415d30f1a992a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153503
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [be19f007db146e9b22c1f01dacec0840e44929cb]

        tdf#153721  label change: "Move Chapter..." -> "Move Heading..."
        
        Change-Id: Ice74663d3381b9e360cb8cb739bb5dc4103a0bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152435
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [0193b284e880a659ab73160e42238e1d5fe5cf8f]

        new loplugin:constexprliteral
        
        OUStringLiteral should be declared constexpr, to enforce
        that it is initialised at compile-time and not runtime.
        
        This seems to make a different at least on Visual Studio
        
        Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-26  Khaled Hosny  <khaled@libreoffice.org>  [2ef138de767c312188d41a7f206234eafac3108b]

        tdf#156050: Fix how misspelling line is calculated for RTL text
        
        Partially revert:
        
        commit 74b6c5ea3c333de7c5e7ef8636732edadd9083f2
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu Jun 8 16:41:18 2023 +0300
        
            tdf#151968: Fix vertical position of RTL spelling wavy line
        
        Instead of changing how fStart and fEnd are calculated, calculate them
        like before then swap them. This seems to be more reliable, and matches
        what we do in Writer.
        
        Change-Id: Ia15408881666a86151a12fcf016cc81c1568f7e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153572
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b302b98795310befdae4a4f925ab9921682b79c]

        upgrade libtiff to 4.5.1
        
        Change-Id: Ia07f368a371930f655bdc3495e76295dad740d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6589ad8c7a5aed5ae13cf8bf8482ceba19a2067]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ia064835f3fee71e9a177b2ab37f66e3fd2a94fce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [db90a3838f9cdd4866a0add4a5b5f5859d78e0d7]

        FillSdAnimationInfo is never passed a null
        
        Change-Id: Iaf292fc3476fbbc21fede3856a50864951c1db8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153568
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-26  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [66e25cfe4f50c142077a54f005d09cee2bb63dab]

        xmlsecurity : remove unneccessary static variables
        
        Change-Id: Ie7ecba234f33cc09ebd4cf5a390919acb4bc7e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-26  Noel Grandin  <noelgrandin@gmail.com>  [f55792eed4d2e0f6891a2bdd8639f8e962d95c5b]

        convert ScAutoFontColorMode to scoped enum
        
        Change-Id: Id34bac78719943bd4c4cbfa60e0cb86b4ca570f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153562
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9fc0b2b9b96d87eb642a3b29e9dcb5d6273265eb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d380411c947e8fcc3887889497349f45f01c28ac
          - (related) tdf#128192 remove mention of "Default PS" limitation
            
            Change-Id: I8c53745039d14e0d43debdd6aeaf37311ccb750f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153592
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-06-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d7587e96f9769d856657d78b2e262442298aed52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 62a280c3b288b30ac34f68e4665c76369336cda1
          - (related) tdf#90507,tdf#154933 Text Body -> Body Text
            
            Change-Id: If7e84952f10d081747d690e7120c9d43b44aba4e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153529
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab094c4b7e5c0914dcc3d378c08129c5be2108ef]

        tdf#156034: improve test a bit
        
        Change-Id: I164103c92cfb53c4f1ce48dd1ca39dbd9a1efb1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153566
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [99b1459dbbe5faa47b5fc9b4ed767932d46a02cb]

        tdf#155735: use 4x4 matrices in tests
        
        Change-Id: I7258443036eb89e7a67fce2a683f3212972a7395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153565
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [a013911b8661daff2cdd58f0bf233ee7116f3029]

        tdf#155735: cid#1532475 Out-of-bounds access
        
        Change-Id: Ifb3153cc492d042098398695642cd2530bc3b4b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4acf48b99804be712d2bd6e3e73c1f030ec637d5]

        cid#1532451 silence Iterator container mismatch
        
        Change-Id: I8560f3e5c7820fef8e27433321c97fc3a0b29746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153552
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bcd3ca80cd1f59c4b94660daa8c3e66944caf58f]

        sc: simplify and fix prop. mapping for cell BG and char theme color
        
        Change-Id: I461106200d37f0c605c07095c6b5871ea89e0e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153501
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [95d199e3d1a04a469e1d22896ffd967c7a06c3f0]

        sc: ThemeColorChanger - change theme color for borders
        
        Change-Id: Id6b08ad48b496d2f1138aeea8d024a5f61bee633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153500
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [163ad701b61af6888bb9fbaaf2d8a49054f9a846]

        oox: map color transforms direct to create model::Transform
        
        Change-Id: I82382f8d0936e90218fefe889ea5bfdd04c3e82b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153507
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-25  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f95c213cc9107e25f78e25c6a1bdfb8a5a61be2a]

        crashtesting: crash seen on exporting fdo66241-1.ods to xlsx
        
        Change-Id: I730bd782ddf67555c40651aed1442465574a1c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153560
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [bea05a79c8ed565909e341a24b298d8deab7e042]

        Resolves tdf#147514 - Number of copies on top of the print dialog
        
        Swapped with Odd/Even pages option to keep the dialog small
        Number of copies is assume to be the more relevant function
        Simple "More" renamed to give some clue of the options
        
        Change-Id: I8d1bd3455d5b8d57f47ac97c1a310fd47a4a5bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153495
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-06-24  Regina Henschel  <rb.henschel@t-online.de>  [81daca18b69d31995bcd56f804659318398c02e2]

        CID several. Use ctor 'from other' instead 'first..last'
        
        This covers CID#1532461, CID#1532462, CID#1532464, CID#1532467,
        CID#1532479.
        Now solutions without iterator are used.
        
        In all cases constructions like
        maColorStops = basegfx::BColorStops(rGradient.GetColorStops().begin(),
        rGradient.GetColorStops().end());
        are replaced with solutions like
        maColorStops = rGradient.GetColorStops();
        
        And instead of constructions like
        aColorStops.emplace_back(maColorStops.front().getStopOffset(),
                    aStartBColor);
        aColorStops.insert(aColorStops.begin(),
                           maColorStops.begin() + 1, maColorStops.end() - 1);
        aColorStops.emplace_back(maColorStops.back().getStopOffset(),
                                 aEndBColor);
        now it is like
        aColorStops = maColorStops;
        aColorStops.front() =
            basegfx::BColorStop(maColorStops.front().getStopOffset(),
                                aStartBColor);
        aColorStops.back() =
            basegfx::BColorStop(maColorStops.back().getStopOffset(),
                                aEndBColor);
        
        Change-Id: I66662d2286e7707b205c58977bc3f850b2a49dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153555
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [5b02c7225837615d15f90e36a163fd3c39108465]

        Add missing dependency
        
        Similar to commit 012875da5bb23e2c90e9cb6132c4b36a7f56648a ("Add missing
        dependency", 2022-11-08).
        
        Change-Id: Iba8024782440b31b24932f5b0b17c392884d2816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153559
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-24  TokieSan  <eltokhy@aucegypt.edu>  [17ba20e132d581c2298969451b510fb69c19f5fe]

        Certificate Manager button is hidden in case no manager exists.
        
        A new function is implemented to check for that in
        digitalsignaturesdialog.cxx
        
        Change-Id: I4cf1c710e6a145e8f0d10716cb81394bdcf7a74f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153367
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [79bce686b7d3691deefcac23d5f8a090ff2e20ce]

        cid#1532478 silence Unchecked return value
        
        Change-Id: I62caefd23f542d5c00ea86d84d199ce8ac09833b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153553
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [93b87910854e7c2a4fbe8abf2f2e704819c3dffe]

        cid#1532474 Uninitialized scalar field
        
        Change-Id: I23bb555a8104a60f6e81954637127acf181bb9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153551
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3ee1691a82cce40263ba6e3fe5c455ea519d4c99]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9615cb2ed0275615f853c027087fa5ef46f72eae
          - tdf#156029 operator precedence in Calc
            
            Change-Id: If6410c72b4b085f3012e926c9a0dc2175d4ce2af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153542
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da9dece79dd79d227e715e9c753e27175bcc445e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d7fd5dd8910f3d7bc98c8a3d452102d133f4ffa
          - Refactor, no changes.
            
            Change-Id: I11d58e24520d749c30b73913555d478a24806cfc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153541
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [75399b8aad6c0f0998b9d0a6eddb2e29f8bc114c]

        tdf#132246, tdf#155735: Add support for SourceAlpha
        
        Change-Id: I8feae2447b17e15113ca45fe46c0d68cb6b6ab71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153550
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-24  Paris Oplopoios  <paris.oplopoios@collabora.com>  [85013c57dd29e32ec0411c159ea72824ebca5aa9]

        tdf#156016 Fix bug where SVG check size would be 0
        
        Change-Id: I1c4adf75bbfbce7cb6b779375714b1c1bc7ec50d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153543
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [ad3cbef7f60de1e490c752051823a35ee37b311e]

        ReqIF: 'ol' elements must have no 'start' attribute
        
        Change-Id: If02f4d2f0a34f2f39b90fb7b8c6d29e46d0da0ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153549
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [698d82ec6c582fdd4633e9e5cc9c439d4a0eff7d]

        Add a natvis entry for o3tl::span
        
        Change-Id: I6023047e166dce0e46b24338bc60c470666aa5b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153548
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [fc1b9ab2913bc8c2d8414b6d8de3ceed3910c5d8]

        tdf#133560: re-anchor objects, to use paragraph's dispose for bEndOfDocument
        
        1. During import, XParagraphAppend::finishParagraph(Insert) are called,
           which are implemented using SwXText::Impl::finishOrAppendParagraph,
           and the latter calls
        
            m_pDoc->getIDocumentContentOperations().AppendTextNode( *aPam.GetPoint() );
            // remove attributes from the previous paragraph
            m_pDoc->ResetAttrs(aPam);
        
           so that there is always another (empty) paragraph after the finalized
           one;
        
        2. During import, lcl_AddRange is called to create anchored text content;
           the start and end of it may reference the very end of the document
           (using xTextAppend->getEnd()) - i.e., that last (maybe empty, maybe
           extra) paragraph.
        
        3. In many places, and in particular, in DomainMapper_Impl destructor,
           DomainMapper_Impl::RemoveLastParagraph is called; and the latter uses
           one of the two techniques to remove that last paragraph:
        
        3.1. It either obtains the paragraph's lang::XComponent interface, and
             calls its dispose (SwXParagraph::dispose), which eventually calls
             DocumentContentOperationsManager::DelFullPara;
        
        3.2. Or it uses cursor to select 1 ch back, and replace the resulting
             selection with nothing.
        
        3.1 has an advantage of keeping the formatting of the remaining (second-
        to-last) paragraph, but DocumentContentOperationsManager::DelFullPara,
        among other things, removes all anchored objects, thus this mode is not
        used for the end-of-document case (e.g., see commit message of commit
        e521930ea1c855c236efb67793e540d07c201d35 "fdo#58327: writerfilter:
        RemoveLastParagraph is tricky:", 2013-01-10);
        
        3.2 keeps the anchored objects, but needs workarounds to keep bookmarks,
        and destroys the remaining paragraph character formatting.
        
        Let me try to use #3.1 also in the end-of-document case, by introducing
        code to move anchored objects to previous paragraph before calling
        XComponent::dispose. Indeed, it may happen that more processing could be
        needed, if more properties would happen to be bound to the very last
        extra paragraph.
        
        This change adds a call to DocumentRedlineManager::CompressRedlines in
        DocumentContentOperationsManager::DelFullPara, because previously, this
        was called during #3.2 inside setString. testTdf150086 failed without
        this change.
        
        testTdf131386 and testTdf152872 were changed to the now-correct import of
        last paragraph properties (previously both of them relied on the hidden
        property not present there, while it is there in Word).
        
        In DomainMapper_Impl::RemoveLastParagraph, the check of the content of
        selection made by moving backward one character was generalized to be run
        before both cases, because RTF sometimes has only one paragraph after a
        table (see e.g. testTdf148515), which now could be removed in the absence
        of the check.
        
        testTdf104390 was changed to not check the number of runs, because now
        the paragraph keeps the trailing "paragraph mark formatting" empty run,
        which previously was dropped using setString path.
        
        Also, the fix for tdf#148273 is re-implemented here, by dropping
        RES_PARATR_LIST_AUTOFMT in lcl_RstAttr. Likely keeping it was an
        unintended side effect of placing RES_PARATR_LIST_AUTOFMT inside
        RES_PARATR_LIST_BEGIN/END. After the change, explicit drop of it will be
        not needed at arbitrary boundary, which is section break; this property
        should only be applied where it's defined. This change can't be done
        separately, because of interrelated unit test failures left and right.
        
        In XMLParaContext::endFastElement, setting ListAutoFormat property must
        be set only after setting style now, because otherwise it will be reset
        in lcl_RstAttr when the style is set.
        
        Some test documents were modified, to drop font from the last paragraph
        properties, because their respective tests started to crash (see commit
        172270a8f04388a8f8062f672f9c3f3144a01a1f "abort writer layout tests if a
        font isn't found", 2022-05-01). Before this change, these paragraphs had
        lost their formatting, so those fonts weren't used in layout.
        
        Change-Id: I7e41c20e68e24c78fae1d2005c3fd75fb146ba2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153481
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [88019e3ac34e35c193df0ae682722f6ec3ba5133]

        Update libassuan to 2.5.6
        
        Change-Id: Iea5af01231e67c24d34287929a54f5ec86af47ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153545
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2023-06-24  Eike Rathke  <erack@redhat.com>  [c20337889469e41cec89bd421fab533f16b4b451]

        Change LocaleDataWrapper::getDuration() parameter to tools::Duration
        
        ... instead of tools::Time
        
        Change-Id: I8e49de43a1870541d75add34089eec67b7a8be31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153533
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-24  Khaled Hosny  <khaled@libreoffice.org>  [4a92323b54e7d63a8bc0b8e62fdc6b31760dcd05]

        tdf#129810: Compress fullwidth CJK punctuation
        
        When compressions CJK punctuation, compress also full width versions to
        match Word behaviour.
        
        Change-Id: Ic35cfcbacca1974b7241d657f078148bac06478e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153530
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [d84291f55746cd4fa7c1f236a14b362eaddde7b9]

        Rename "aStrTextColor" to "aStrFontColor"
        
        This patch improves consistently with item labels in AutoFilter/Standard Filter menu.
        
        Change-Id: Ibee26623f5561d228930b887778d5c61b32a1456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147747
        Tested-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2023-06-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [45d13c26d815cbbb73db5d327809368c89b9eec3]

        tdf#156034: check for css style further up in the hierarchy
        
        Change-Id: I92c6673f1249cc4a273c490cdc0496474ce1f0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153498
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4df8266d42dd51a1cf82833de5b99a6a138a6491]

        fix a from-scratch i18npool build problem
        
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/count_word.brk] Error 4
        make[1]: *** Waiting for unfinished jobs....
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/edit_word_he.brk] Error 4
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_he.brk] Error 4
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_prepostdash.brk] Error 4
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_nodash.brk] Error 4
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word_hu.brk] Error 4
        genbrk: Could not open output file "/mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk", "U_FILE_ACCESS_ERROR"
        make[1]: *** [/mnt/i18npool/CustomTarget_breakiterator.mk:91: /mnt/workdir/CustomTarget/i18npool/breakiterator/dict_word.brk] Error 4
        
        probably since:
        
        commit c276694bc06ae460a78532757db08e531b478e20
        Date:   Wed Jun 21 13:14:42 2023 +0300
        
            Remove another workaround for old versions of ICU
        
        Change-Id: I31f07900d46a042a50d1bbbdd889ef6cee6bed8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-23  Baole Fang  <baole.fang@gmail.com>  [caab94a3e0387bde05538cff91ff13446f330785]

        tdf#142437: Fix word boundary detection in autocorrect
        
        Marks (combining and spacing) were incorrectly considered word separators,
        because isLetterNumeric() matches only for letters and numbers.
        
        The new isBase() matches any character with BASE_FORM character class, which covers letters, numbers, and marks.
        
        Change-Id: I27ec2f7fb8d360791a280d10aba9b6d16e7cfb71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153509
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9bb6f3083b8b2a763417ca1cdce21865a41ddd08]

        update LibreOfficeCoverity.conf
        
        Change-Id: I61b62814b39d18c589e447c6518b7011f0b9bf26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153536
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-23  Justin Luth  <jluth@mail.com>  [805abacd0d1fe2d5522a2041fc3c07961a62ba5f]

        related tdf#68695 tdf#141136 sc: comment can't resize; avoid context change
        
        In order to avoid having the notebookbar
        constantly flipping back to the home tab,
        try to avoid useless context switches.
        That should also be a nice performance win.
        
        In this case, the context change occurred because handles were enabled,
        but that broke in LO 4.1, so just revert that broken OOo fix.
        
        Back in OOo, https://bz.apache.org/ooo/show_bug.cgi?id=33764
        added resize handles to a newly inserted comment,
        and was added to LO as part of a huge batch.
        commit 07b0c01857137de7e4bd02375e7c892d622d270e
        Author: Oliver Bolte on Mon Mar 2 14:19:13 2009 +0000
            CWS-TOOLING: integrate CWS dr66
        
        But that didn't allow select and copy, so in LO 4.1
        commit 54a1feb9b9bd654774b9aa60cda7ef9a1cd11064
        Author: Armin Le Grand on Fri May 10 12:08:40 2013 +0100
            Resolves: #i122142# use simple text hilight frames
        
        Bug 68695 exists to complain about the inability to resize.
        
        Change-Id: If04d718b7de9cff1038bbe9f6372d4859643d3f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153508
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-23  Justin Luth  <jluth@mail.com>  [9f5393abea012be04ab7ecb26d8031019bc50f62]

        tdf#141136 NBB SetContext: try to stay on the same tab
        
        The user was forced on the HOME page at almost any
        context change.
        
        Instead, this should only happen if:
        -there is a special context tab
        -there is no special tab, and some "random" tab is needed.
        
        This helps in a lot of cases, but there are still plenty
        of cases where TWO context changes are emitted for one logical event.
        For example, in Calc a new comment switches to special DRAW tab,
        and then immediately to DrawText which has no tab -> home tab.
        
        So further fixes are needed to prevent machine-gun fire context events.
        
        Change-Id: Ibaf18fa823c613b4d11d33284842e439d3689542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153476
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-23  Eike Rathke  <erack@redhat.com>  [c968d8989004301b49d67a093a6eb8a629533837]

        Introduce tools::Duration individual time values ctor
        
        Change-Id: I516d3727cbcf6667b32dc963febbf4b753ef6a91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153497
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-23  Maxim Monastirsky  <momonasmon@gmail.com>  [759d414748bda99f29b04806f72d479e320c2f9f]

        tdf#103064 Simplify the code a bit
        
        - Use SfxItemIter instead of manually iterating the ranges.
        While SwFormat::GetItemState does some extra stuff on top
        of SfxItemSet, it doesn't seem to be relevant for our
        use case.
        
        - Avoid searching for styles again and again.
        
        Change-Id: I397dd71a5ffb8cbf7d508b68abb3fc1b585938af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153479
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df29592493367bc03c9602c924711852eecf64c4]

        Fix typo
        
        Change-Id: Ib72e45a25e80559b2493d0901d1a2bfacb56077b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153496
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-23  Eike Rathke  <erack@redhat.com>  [b07d72c6c1075efa6b64c67758566426c22c5225]

        Clamp and assert maximum hours value in Time::init()
        
        Change-Id: Ia777222f3c797b90663b55499a57025e410b1d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153407
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-23  Heiko Tietze  <tietze.heiko@gmail.com>  [d0a9d04d2287da456317c5a59af3ccbe3b98b977]

        MCGR: Some exemplary multi-color gradients
        
        * "Rainbow, Sunrise, Sunset" added
        * "Preset, Spotted Grey, Teal To Blue" removed
          to keep items inside scrolled window
        
        Change-Id: I3be6c8596accc769df92a8610260ed38a6c29602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153166
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-06-23  Regina Henschel  <rb.henschel@t-online.de>  [bb19bda1dc620f0f8662776d9818aedf45486994]

        tdf#155901 MCGR: preserve first and last gradient stop too
        
        Error was, that only the in-between gradient stops were preserve. First
        stop was set with fixed offset 0, last stop with fixed offset 1. The
        offsets of first and last gradient stop of the original gradient were
        lost. Now in all cases (hopefully) the complete gradient stops vector is
        preserved and the original offset is used, if e.g. the user changes the
        color.
        
        For calculating transparence the indirect way over Color is removed.
        Instead percent is directly transformed to the 0..1 values of BColor.
        That avoids rounding errors.
        
        Change-Id: Icdf699a6c2e9c6289d2f77033858448e58396a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153395
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ec8d592e31aebe19075e9f89c4c2c7abcf8d420]

        Speed up scrolling through large document with lots of patterns
        
        Cache visibility for use in ScPatternAttr::IsVisible
        
        Change-Id: Ia248a06b876b53115bbc3017d97538bbbc03830d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-23  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1dc60ddafbbc1b1e8612cf1263f6987a1f3417b6]

        tdf#152576 - A11Y sidebar: improving update of issues on sidebar
        
        Put the empty paragraph nodes to the correct WeakNodeContainer.
        
        Change-Id: I2db5608b0f7a625b6221d9290ea3d2502f4cadea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153469
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-23  László Németh  <nemeth@numbertext.org>  [952fb2a4386a6ae2187b646e372131a5345f59fe]

        tdf#155847 sw tracked table column: fix crash in Manage Changes
        
        In Manage Changes dialog window, accept/Reject multiple tracked
        table columns need major tree list update because of not continuous
        redline ranges in the child lists of the multiple tree list parents,
        otherwise assert/crash could occur.
        
        Follow-up to commit 4a40a42afc3ba551e6e58947fc2e44689979b629
        "tdf#155847 sw tracked table column: manage multiple changes".
        
        Change-Id: I3c7f61d35cbb433067c1f4fd28b80ad7da8ba12e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153464
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-23  Balazs Varga  <balazs.varga.extern@allotropia.de>  [bbb104ea2b8f3e48273f316cfad406e904a2f331]

        tdf#155503 - A11Y sidebar: Add quick fix action to set document title
        
        Add fix button to set the document title.
        Fix updates issue of document level changes.
        
        Change-Id: Ibab5cab3b595de4df68c3022a5864b2d2d4bed2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153352
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-23  Maxim Monastirsky  <momonasmon@gmail.com>  [6cc71f3eef4e5108e44ab6c1943def1d3a0f707a]

        tdf#103064 Fix reset to parent style handling
        
        If the style ends up empty, it still needs modification
        broadcasting if it used to be non-empty. So let's just
        trust the pool notification for when to notify clients.
        And given that broadcasting happens now always after
        EnsureStyleHierarchy, I assume that the explicit
        broadcasting in SetParent is no longer needed.
        
        Also added broadcasting to the undo of a reset. And the
        undo actions were combined, so we don't get separate
        notifications for each reset attribute.
        
        Change-Id: Ia2895fe346ef337cc0b4fe5dc4275f5b2dc60cd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153478
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-23  Maxim Monastirsky  <momonasmon@gmail.com>  [9cfed79cc1eb6182a807dafec796c0423d6003d6]

        This can be const
        
        Change-Id: Ie69b8a926c20d1923c4e1ad580838f1b57bbd3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153480
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-23  Maxim Monastirsky  <momonasmon@gmail.com>  [5ca721c182251e94922a7d11c6756f8ba789a574]

        tdf#103064 Refresh spellcheck marks on default lang change
        
        i.e. Tools > Language > For All Text, or Tools > Options... >
        Language Settings > Languages.
        
        The new language was already set as a pool default and picked by
        comments, just the spellcheck marks weren't refreshed.
        
        Another issue is that (unlike the Options dialog) menu items for
        specific languages (e.g. "English (USA)") also reset language
        settings in all paragraph/character styles, as implemented in
        tdf#35282, and this needs to be broadcasted as style modification.
        However as it turns out, the problem described in tdf#35282 was
        also reported in i#102191, for which the OOo devs provided a
        different fix (setting the new lang as DF), which was eventually
        merged as well as commit 8780cc5c294085fe7379a24eee58ac446cc40d0c
        ("cws tl84: #i102191# 'set language for all text' now uses
        hard language attribute"). So now we have two solutions for
        the same problem applied both. Given this, I prefer to instead
        revert the commit of tdf#35282, as it seems odd that a menu that
        claims to modify text actually modifies arbitrary styles (which
        might not even be used in the text).
        
        (fwiw there is also a third possible solution for i#102191/tdf#35282
        which wasn't even discussed: Just rename the menu title from
        "For All Text" to "Document", as the problem seems to be really
        that the menu title sets wrong expectations that it modifies the
        text attributes, and not just the document defaults.)
        
        An open question regarding the fix of i#102191 is whether
        comments and shapes should also get the default language as DF.
        This actually used to work for comments until recently, as we used
        to force the document body language on attached comments. But this
        is no longer the case, so a different solution would need to be
        developed if this is still wanted.
        
        Change-Id: Ib097765e30a7272270737fc61df6d10aa51565fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153477
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-23  Khaled Hosny  <khaled@libreoffice.org>  [97aff867f519d7bcb530486208faec68671190a9]

        Remove recently unused unicode::isCJKIVSCharacter()
        
        Change-Id: I7d41657e2611aa66303f9315ff6e36a8e08d8688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153453
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-23  Khaled Hosny  <khaled@libreoffice.org>  [96964547dc40b9d6396aad40c29709bb83070fee]

        Make backscpace always delete whole variation sequences
        
        We don’t want to limit this to CJK chars, since variation selectors can
        be used with Emoji, mathematical symbol, and possibly more in the
        future, and in all these cases the character + variation selector is
        considered one unit.
        
        Change-Id: Ifc41183ec27a9e3715058cc0b5865a5bd4fcaa69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153452
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-23  Khaled Hosny  <khaled@libreoffice.org>  [1adae2e08949c5d73b3bc68b9cda81f8614289c0]

        Improve and rename unicode::isIVSSelector()
        
        Check Variation_Selector Unicode property instead of hard-coding
        variation selector classes. This now handles also Mongolian Variation
        Selector.
        
        Change-Id: I2dd5c4770d7bb9bf4c1e9edc43926fe0863b0da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153460
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-23  Khaled Hosny  <khaled@libreoffice.org>  [aed0344f9053bddca905d154f2e3b92f35313a7b]

        Improve ScImportExport::CountVisualWidth()
        
        - Use East_Asian_Width Unicode property to check for double width chars
          instead of hard-coding CJK characters.
        - Use Default_Ignorable_Code_Point Unicode property to check for
          characters that shouldn’t be counted, instead of checking only of IVS
          characters.
        
        Change-Id: I4349ea0ee6a32736865f37cd0a6e1a8e7e9a6e71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153451
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bbf6fa94a92abc1085addaba20519ee0166bae5e]

        fix crash in PaletteManager triggered by the color picker
        
        The code expects the SfxObjectShell::GetThemeColors() always
        returns a current set of theme colors, but then for some modules
        we return nullptr.
        
        Change-Id: I4096b75942d818965cedf43f35444faeb870cb74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153424
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-23  Henry Castro  <hcastro@collabora.com>  [0533b51dbe13838d2bffdf59fdf6fcfe36c4a451]

        sc: qa: filter: add import excel unit test
        
        single line.
        
        Change-Id: I2d76f54e0ccf943794bd817b2e80583b8dd69558
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148005
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153473
        Tested-by: Jenkins

2023-06-23  Justin Luth  <jluth@mail.com>  [7626e37b7c77980ba41bdc7e9131b9c373dea038]

        tdf#141136 NBB SetContext: don't SetCurPageId twice for the same page
        
        I noticed that SetCurPageId was running multiple times
        for the HomeLabel page.
        
        Plus, let's flatten this a bit more.
        
        It has always been like since, since
        commit d7da58ae362b661c03fc754e4e8f4a89798b0127
        Author: Szymon Kłos on Fri Jul 22 11:50:57 2016 +0200
            GSoC notebookbar: better default page handling
        
        Change-Id: Ied13ea5019df7cce2afe38d5d5d3615168338f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153475
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [758c8539024769188c4aca647a0b5b42362fcf0b]

        Remove duplicated include
        
        Change-Id: I77bfc427afa62cf1667b0dc5cd60c82032aed856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153465
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [06dbdb0f5b618ce01a79f07dc78e8049c419cc5f]

        Use kf6 VCL plugin by default on Plasma 6
        
        If running in a Plasma 6 session, use the kf6
        VCL plugin if available. Otherwise use the same
        fallbacks as on Plasma 5 or LXQt.
        
        Change-Id: I223002d116c896d628f6ab4e3c1246a774b5ebe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153439
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [720bf6ac8612c32942bb059f9086ee86c2963bb5]

        kf6: Add a kf6 VCL plugin
        
        Add a "kf6" VCL plugin that uses the KF6 (KDE Frameworks 6)
        libraries to provide a native KDE/Plasma file chooser,
        just like the kf5 VCL plugin does for KF5.
        
        Building the plugin is disabled by default and can be enabled by
        autogen option '--enable-kf6'.
        
        Selecting the VCL plugin can be done by starting LO
        with environment variable 'SAL_USE_VCLPLUGIN=kf6' set.
        
        The kf6 VCL plugin reuses the kf5 VCL plugin code.
        (The kf6 headers and sources for now just `#include`
        the kf5 ones.)
        
        This was quickly tested on KDE Neon unstable,
        which provides a daily snapshot of Plasma 6 and the KF6
        libraries.
        (Regarding a potential release date, [1] mentions:
        "Plasma 6 is built on top of Qt 6 and is
        tentatively planned to be released in late 2023 or early 2024.")
        
        [1] https://community.kde.org/Plasma/Plasma_6
        
        Change-Id: I4c2b7e3be8e60f1d8cf60119f6f3f642b71349f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153438
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [8b0e1f2a914d672182d585d8cb2d4a815e88977e]

        Detect Plasma 6 desktop
        
        Add detection for Plasma 6, which is currently in development stage.
        With the following plasma-workspace commit [1] in place,
        KDE_SESSION_VERSION is set to 6, so use that to detect it:
        
            commit 4c2242d7dfafac161baec3ec316af24d7b48ef8b
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jun 22 07:47:31 2023 +0200
        
                Set KDE_SESSION_VERSION to 6
        
                Since the master branch is based on Qt6/KF6 and will
                become Plasma 6, set KDE_SESSION_VERSION to "6".
        
                This will allow other applications to detect they're
                running in a (preview of a) Plasma 6 session and react
                accordingly.
                (E.g. LibreOffice can use this to choose to
                use its upcoming kf6 integration by default instead of the
                kf5 one.)
        
        [1] https://invent.kde.org/plasma/plasma-workspace/-/commit/4c2242d7dfafac161baec3ec316af24d7b48ef8b
        
        Change-Id: I5a15ad1fb177721fbfa016139c56a08b228f2e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153437
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [4239a29760ff9748965b4c670d1d4e272f81205d]

        kf5/kf6: Don't hardcode reported KF version to 5
        
        Use the Qt major version number instead of a hardcoded "5"
        when constructing the toolkit ID, so the upcoming
        "kf6" VCL plugin will be reported as such (e.g. in the
        "About LibreOffice" dialog), not as "kf5".
        
        Change-Id: I8ff0721b8b22fd4b1ca035def37a84bcc5ffede6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153436
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [f5a2f4739b26428d87a2538988ed114c834f9c72]

        kf5: Drop "5" from VCLPLUG_KF5_{IMPLEMENTATION,PUBLIC} defines
        
        Rename those to no more include the Qt/KF version number,
        since they will be used for the upcoming kf6 VCL plugin
        as well.
        
        This is basically the same as
        
            commit 51d148c748d8e23b69ba91d3c1b5a9057bd22548
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Sep 29 10:26:03 2021 +0200
        
                qt5: Drop "5" from VCLPLUG_QT5_{IMPLEMENTATION,PUBLIC} defines
        
        , just for the kf5 instead of the qt5 VCL plugin.
        
        Change-Id: I9ec6d40a05ee55ff0df4869966831d6bff94f575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153435
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [6922c2fcfec92292d763c0346b7afdc44c63d1e9]

        kf5: Rename sources + headers according to new class names
        
        As
        
            commit b9cd02937b358ae035ed554a28037237a6c8434c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Sep 28 15:55:43 2021 +0200
        
                qt5: Rename sources + headers according to new class names
        
        did for the qt5 VCL plugin, this renames the source and header files
        according to the new class names without a "5" in them, as mentioned
        in
        
        Change-Id If785792f8669688de2156b1a990d7956dbe7a401
        ("kf5: Remove "5" from class names in kf5 VCL plugin"):
        
        > Renaming the headers and source files will be done
        > in a separate commit to make tracking git history easier.
        
        Change-Id: Ieb49cda25b170ac777029f7288a885a0b953e02d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153434
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Michael Weghorn  <m.weghorn@posteo.de>  [0914025d93af5797b662fda82cd954081b2fda39]

        kf5: Remove "5" from class names in kf5 VCL plugin
        
        This is the kf5 equivalent of what
        
            commit dfd3fdfe664e214ca1bba72b96d19b89ff25e7bc
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Sep 28 15:02:47 2021 +0200
        
                qt5: Remove "5" from class names in qt5 VCL plugin
        
        did for the qt5 VCL plugin.
        
        This is in preparation of an upcomng kf6 VCL plugin.
        
        Renaming the headers and source files will be done
        in a separate commit to make tracking git history easier.
        
        Change-Id: If785792f8669688de2156b1a990d7956dbe7a401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153433
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5141834c378fa731cabe0f325c5a95d56034e3f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b96b109055418994353b2d36c8735b0fff14637
          - tdf#1552354 Update page number wizard help page
            
            + synch with latest 7.6 features.
            
            Change-Id: Ia84f044cbb0e9f46da30219ac0c950dc1dda6396
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153474
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aaace6fbdf302e32417da86681a366efb388a030]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 47a2e63384c754cf2c8766bc1d03b9a1d009c498
          - tdf#156015 Mark unimplemented args of BASIC Shell
            
            + refactor
            
            Change-Id: Ide7bc5a4abd4685b2bbe2727740358ac4c811030
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153455
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-22  Henry Castro  <hcastro@collabora.com>  [b224e450d09a0405043a011d48f4f57e88cdc344]

        sc: filter: excel: import cell multi-line text
        
        The excel document, if the cell has multi-line text and
        the property wrap text is off, the paragraphs are rendered
        all in a single line.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I3b5c82dde2616887e51ad6e3dfe91d100482f747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148004
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153470
        Tested-by: Jenkins

2023-06-22  Henry Castro  <hcastro@collabora.com>  [0af60a8c7c98069d8f070f8bf2eea368ca129c4f]

        sc: filter: excel: add getter function LineBreak
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I17646ed53f663fd72a10437d7a3a4407df0c176e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148003
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153468
        Tested-by: Jenkins

2023-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [079cd3429ace2f9568d42368bb0c56487335d44d]

        tdf#156018: check if there is a css style with element inside element
        
        Change-Id: I54fa5bea42560eec5ae51dd7ba07de11f418c75c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153466
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [83ff25f09c4b897a19b9de14980c83c1236813c1]

        basegfx: Add test for BColorModifier_black_and_white
        
        Change-Id: I35193c68034e5500f12a2e474886c6aa9c2307ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153457
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-22  Henry Castro  <hcastro@collabora.com>  [94297e037dd963b7e74dfff369145d0e0db30c97]

        sc: filter: oox: fix preserve space, single line case
        
        The unit test testPreserveTextWhitespace2XLSX fails
        when a single line is enabled
        
        Test name: ScExportTest::testPreserveTextWhitespace2XLSX
        equality assertion failed
        - Expected: 1
        - Actual  : 0
        - In <>, XPath '/x:sst/x:si[2]/x:r[1]/x:t' number of nodes is incorrect
        
        In order to fix, the single line cell should not be enabled and
        import the attribute:
        
        <t xml:space="preserve">abc</t>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I380ba8726c03abc40bdc745ea74eceb80fec6e54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151599
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 2dd86aa3f365057494bf41f4da7f2f410ea3bf2e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153459
        Tested-by: Jenkins

2023-06-22  Vladislav Tarakanov  <vladislav.tarakanov@bk.ru>  [be53ee28d7435809e71e7e6b2ce929c87f07ba33]

        tdf#155955 - small Calc window size after deleting the configuration file
        
        Set the default window size for the case when the configuration file is missing
        
        Change-Id: I58391590557678e927fcefd49a8f43511c08e3ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153430
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-22  Justin Luth  <jluth@mail.com>  [1310ce65f18c0b03051c6f23e40b8b39b8053fec]

        tdf#147056 sc: convert xml menu to popupmenu .uno:PrintRangesMenu
        
        The labelling in the notebookbar left much to be desired
        when adding the print ranges separately in the "context menus".
        
        Making this into a proper submenu fixes the problem.
        
        Thanks to Maxim for reviewing and for the commit template:
        commit 0e7cd653ea90da388820220bf6a3eb140b57bbd6
        Author: Maxim Monastirsky on Mon Jan 25 01:09:03 2016 +0200
            tdf#86567 Dropdown for conditional formatting
        
        Change-Id: If92836ee29d322f5a2fca1e27d2e034e5cc995e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153402
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [59380e2b0933b0aa6d0f5c3c88d47e751fe31616]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff091dd8df2ad426820ecccbbdb7eb7fb746dceb
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 4)
            
            Change-Id: Ifa2c290d2a90133d6ee21d4827f83b5690e59f9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153462
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [e121f7b37c48b6d843dfdd1d774d2a40567c46c7]

        tdf#155735: Add support for matrix type
        
        Change-Id: Icc172c5f47731ddcf0beca64c72c2022313e74a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153177
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cdce0b615a0bd599cd90dfd145d8270287045619]

        Fix typo
        
        Change-Id: Ibff595640fa219b3076d4f44ef18385f63af3e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153456
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb13c889c760cfe153d5b41188e218bdda797d52]

        Speed up scrolling through large document with lots of patterns
        
        Optimise comparison in ScPatternAttr::IsVisibleEqual
        
        Change-Id: I8e569c888c695a3ce89c2b9993ed729754d402e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153454
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [49219b29e88de376b0b8deb50be8eef7c9805590]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18ae7e5ede3336e23703fe44497891a57884c522
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 3)
            
            Change-Id: I06cd0531f88a22e529001ba465dc427546448182
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153431
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-22  Stephan Bergmann  <sbergman@redhat.com>  [2b3aead9f4d9cbe011b9db65377997c56df2e956]

        Missing test dependencies
        
        Change-Id: I2441d2d4df0e7f72a80828a131d82d8bb22e4181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153432
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a62513e1e80e39f9928e9e1815a84761403a4f2b]

        tdf#155735: Add support for hueRotate type
        
        Change-Id: I9c7ada2908c0739708fbc9e28ac58430350da7a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153112
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [25aa310b923ac26b62a97c0e95549e053d294da4]

        sc: theme color export for cell fill color + test
        
        Change-Id: Ibaad410f094f86d9f7197090db702ae45340c239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151859
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3537cef02c25c2c2459d7900eed13eeec533b7ae]

        sc: factor out color from setting vcl::Font from a ItemSet
        
        vcl::Font color parameter is deprecated so we need to handle the
        color separately from font data. This refactors GetFont into 2
        separate functions - fillFontOnly and fillColor, where fillFont
        now does the same as previously GetFont function did.
        All GetFont calls have been changed depending on if we need only
        the font data or also color - where the color is now treated in
        a different call. There are a couple of calls where fillFont was
        used, because to change that needs a more complex refactoring.
        
        Change-Id: I0a2ce50a0cb28d196fcff87e1e80099a2bb60a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151858
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-22  Eike Rathke  <erack@redhat.com>  [986c2d86a7b53a6599d014db7327f47cb33d4fea]

        Introduce tools::Duration(sal_Int32 nDays, const Time& rTime) ctor
        
        Change-Id: If002e04536149b49b2249103ac914d17dec3fae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153409
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-22  Henry Castro  <hcastro@collabora.com>  [5435c1b80e93811c851878768bb3d2f4b5bc66a7]

        editeng: qa: add single line unit test
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8abd816ec7c115d5a1f17d3b68e3e758cea02d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148002
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153404
        Tested-by: Jenkins

2023-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3db857905437d4ce3b41fd75bd591e2f7801c5f]

        tdf#155735: Add tests in basegfx
        
        Add tests for BColorModifier_luminance_to_alpha and
        BColorModifier_saturate
        
        Use basegfx::fTools::equal in B3DTuple::operator==,
        otherwise some asserts fail with
        
        - Expected: [0.3575, 0.8575, 0.3575]
        - Actual  : [0.3575, 0.8575, 0.3575]
        
        Although they are equal
        
        Change-Id: Iad6d9ff78a390f5ee2a3e33e479e34d98e751b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153394
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ff1d94ba28b6c3c7e7d1599c5de0333426d5e2c]

        tdf#155735: use B3DHomMatrix in BColorModifier_saturate
        
        Change-Id: Ibdbe9c55220239f4b8458742ac5625c002963217
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153390
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-21  Eike Rathke  <erack@redhat.com>  [9cf4983e7e6db5c2198c61c30b9c77d089105b3a]

        Change DateTime friend operator-() to return tools::Duration instead of double
        
        Change-Id: Ica69b1a8916c73443d9ec91dd35ed126fcf97151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153392
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-06-21  Miklos Vajna  <vmiklos@collabora.com>  [8b330bb761e05fcfabd5a30f8784046c93b91431]

        cui: don't build SvxJavaClassPathDlg::SetClassPath() for the non-java case
        
        Since SvxJavaClassPathDlg::SetClassPath  is only called from #if
        HAVE_FEATURE_JAVA  code (in IMPL_LINK_NOARG(SvxJavaOptionsPage,
        ClassPathHdl_Impl, weld::Button&, void)  in
        cui/source/options/optjava.cxx ) anyway, see
        <https://gerrit.libreoffice.org/c/core/+/153386/2#message-06ee95be419a14ee8f08035142b5718e0377d120>.
        
        Change-Id: I0e5a21036ce048c18d408c07cce088dbab7fc030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153396
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-21  Henry Castro  <hcastro@collabora.com>  [a6535604dea24c1907c24bfe6be22f79f1d85d56]

        editeng: ignore line breaks
        
        Add option to ignore line breaks, and
        draw the paragraph as single line.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I957c3462f6dabe7c1a3322dcbe6753c0c5adc851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148001
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153400
        Tested-by: Jenkins

2023-06-21  Justin Luth  <jluth@mail.com>  [2273c72730cc2ab040c191242989315c0805ba4d]

        tdf#142833 sd notebookbar: There is no PrintPreview, use WebHtml
        
        Well, that surprised me, but there is no print preview available
        in Draw or Impress. They can only do a pathetic
        Preview in Web Browser.
        
        AFAIAC, this could be removed since it is so useless.
        But that would leave an empty hole under "Print directly"
        so for now just substitute something useless for something non-functional.
        
        Change-Id: If7fbb1b549c2b24d2ca6f77f14333811c405e465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153196
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-21  Justin Luth  <jluth@mail.com>  [22c4df0282dce9d56207a440c523c2f3a16bc9f2]

        tdf#133507 sw layout: fix missing contextual spacing at section end
        
        Most of the fix was included in 12f256cd1ae3e625c7b7f48987b7e843046924fa
        which was hunting for examples. Bad idea. Merge these two together.
        
        So this patch is just removing the document hunting aspect
        and enabling the fix itself. (Yeah, really bad idea.)
        
        When a paragraph style has "contextualspacing" with Spacing Above,
        and option "Don't add space between paragraphs of the same style,
        the spacing should apply after a section end.
        
        Contextual spacing was officially added to 1.3 spec in 7.0-ish timeframe:
        "The space between the paragraphs is zero,
        if all of the following conditions hold:
        ...
            The paragraphs belong to the same content area.
        ...
        
        Contextual spacing was actually added in LO 3.6,
        and it applies as expected when transitioning
        from one section to another.
        
        The missing case was when transitioning from a section
        back to the main body text.
        
        This was an implementation error. So the question is
        whether we add yet another compatibility flag
        to handle the old way of doing things,
        or just fix it.
        
        I'm leaning towards no compat flag because
        -it is a recent official addition to ODF
        -it is an implementation error
        -it currently is inconsistent - works on section start, but not end
        -rarely used: it is primarily an interoperability feature
        -rarely encountered: sections aren't really needed in LO.
        -no existing unit tests matched the condition.
        -interoperability isn't affected - section end == document end.
        
        Miklos agreed that a compat flag is warranted in this case.
        It is easy enough for a human to "fix" the document
        by removing the undesired "spacing before/after" settings.
        
        make CppunitTest_sw_odfexport2 \
            CPPUNIT_TEST_NAME=tdf133507_contextualSpacingSection
        
        Change-Id: I5db903e0f1ba41aab54f881256c50d3d1927d6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153187
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [b8ccf3dacb19e157d9b2c35cc2b083cb39e76da0]

        tdf#155945: do not turn another style attributes to direct formatting
        
        SwUnoCursorHelper::SetPropertyValues obtains the node's item set using
        SwUnoCursorHelper::GetCursorAttr, adds new items for the property values,
        and calls SwUnoCursorHelper::SetCursorAttr to set the updated item set
        to the node. This puts all the item set data as direct formatting of the
        node (autostyle).
        
        For complex SfxPoolItem, containing several properties, it could result
        in some properties having incorrect values e.g. in this sequence:
        
        1. SwUnoCursorHelper::SetPropertyValues is called with a property sequence
           including "ParaStyleName" and "ParaTopMargin", represented by a complex
           SfxPoolItem (SvxULSpaceItem's nPropUpper). The current node uses another
           style, which has a non-default bottom margin; new style has 0 as bottom
           margin.
        2. It builds a set for the union of all WhichIds corresponding to all the
           passed properties, which includes WIDs for paragraph style and for the
           respective SvxULSpaceItem.
        3. It calls SwUnoCursorHelper::GetCursorAttr to fill the set with current
           values for these WhichIds, getting also values defined in still applied
           style, including an SvxULSpaceItem with both upper and lower spacing
           (the bottom margin value of old paragraph is stored there).
        4. It sets new value of paragraph style in this item set, and then calls
           SwUnoCursorHelper::SetCursorAttr with the item set.
        
        Now the set contains a new value for paragraph style, *and* an old value
        of the paragraphs margins. This margins value is set as the paragraph's
        direct formatting (autostyle).
        
        5. SwUnoCursorHelper::GetCursorAttr is called, updating the item set with
           new values of paragraph style and margins; the direct-formatted value
           for the latter is returned, still containing the values previously
           inherited from old style.
        6. New value of top margin is set, modifying only nPropUpper member of
           SvxULSpaceItem, and keeping nPropLower (value for bottom margin) as it
           was, i.e. keeps the value incorrectly saved from old style.
        
        This happens e.g. on DOCX import. Commit db115bec9254417ef7a3faf687478fe5424ab378
        (tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl,
        2023-02-24) has incidentally fixed handling of left and right paragraph
        indents, making their items independent; but top/bottom margins still need
        to be fixed.
        
        This change splits the properties that cause side effects (styles) from the
        rest; so that properties with side effects are processed first, with item
        sets containing only one WID for the currently processed property. This
        both allows to avoid the problem, and simplifies the code.
        
        Change-Id: Idd451fa1e53806cdb6b9064dec31e9171d14d5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153384
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [91eaaaf5317ef5bdbedac8a3f2ed6332439a63a9]

        Use Unicode hex instead of string literal in readme
        
        Apparently the string literal in command line argument does not work
        everywhere.
        
        Change-Id: I4d742f53757699a69d9ba13326a54478f18e51a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153403
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2023-06-21  Henry Castro  <hcastro@collabora.com>  [ba38ef8f7733a8fcfdc9228c5cf746c3130976c7]

        editeng: add setter function SingleLine
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I66cad37e1d3728369f0a08195bf85e6c0d50f0ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148000
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153399
        Tested-by: Jenkins

2023-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2bef6e112b5ed9b37fafd71a71b883d01c8716d7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4346eb1c17ffbf2ce3497400f8cf3ce72a2e996b
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 2)
            + fix some bad links (D'oh!)
            
            Change-Id: Ic9daa1df531daa2402ed28c6e7482e8e4392443a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153398
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3653fb627c777de4b6400fc5f35a0d08f15b519f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3cfb09675efbdf0c63cb6285c3bedc5176e6017d
          - tdf#155875 Tab'd UI commands Writer/Insert in Help
            
            + refactoring
            + Writer Insert menu (part 1)
            
            Change-Id: Ie99bdfbbaacb34db20feb06aa3bb847fcb589ea9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153397
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [40e43ae633e00811236ce09710b52062789236ab]

        No need to fiddle with ICU UChar typedef anymore
        
        The affected external dependencies should be building with c++11 by now
        already.
        
        Change-Id: I0d1f8aed6ed28f510f456a368b724c3c4eeb3240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153389
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [c276694bc06ae460a78532757db08e531b478e20]

        Remove another workaround for old versions of ICU
        
        Change-Id: Id13bdb10bf4bf89a136b28a26c4b3d1113971871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153388
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [f0b87e8162511202aa3fe0c2af09c74107a7b3ea]

        Require icu-i18n >= 66
        
        We were requiring ICU 4.6 which was released in 2011, and ifdef'ing our
        way through newer ICU versions. ICU is a core dependency and it makes no
        sense to build LibreOffice with such ancient versions of it.
        
        This change requires ICU 66 (released in 2020), and removes all the
        ifdefs for older versions. There are more cleanups to do, but these will
        be done separately.
        
        Change-Id: I2e4f7608a08f4d531b0a4c74bbfdf91a451f833f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153387
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Eike Rathke  <erack@redhat.com>  [c7b2277f57cf72b7dc6e4cbd179ce40951fbae8c]

        rbOverflow was already set for bBadNS, unnecessary to set it again
        
        Change-Id: I26e32b25b53be590bc24646803c7442385ec4d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153393
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ea1cd4993be992b89930db4811d08a4a51b1f68d]

        sc: OOXML import of theme colors for char and background colors
        
        Change-Id: I8209238927bb425e8e306352f1fa78d63378f005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151707
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [17bc0f05908769f024f3aa49554b96388dd49e96]

        sc: change text and background theme colors for direct attributes
        
        Change-Id: Ia1ef2d151476bb627a0cb999135f6add827fb341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151675
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-21  Henry Castro  <hcastro@collabora.com>  [7c5b6a07b4b7d85c011730c74749fd767c19c957]

        editeng: add flag EEControlBits::SINGLELINE
        
        The purpose of this flag is to draw a paragraph
        into a single line ignoring line breaks
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I0a01e6d4db51d43707f7cdd0ab9d9cf3288e2221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147999
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153391
        Tested-by: Jenkins

2023-06-21  Julien Nabet  <serval2412@yahoo.fr>  [10cf2e7da6048eca7526149f4a2c824e7c3cfdfe]

        Related tdf#155143: blacklist Nvidia GTX 960M for Skia hardware rendering
        
        Change-Id: I1404ef059de9781f1fe8123a880a70495b159a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153383
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-21  Eike Rathke  <erack@redhat.com>  [dd33515b8c1a718f314683235738131cb2759bb1]

        sw: Use DateTime::Sub() instead of operator-()
        
        Change-Id: I0c2ce0e3eb6eab70e694adc567b688b579bb52d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153385
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Miklos Vajna  <vmiklos@collabora.com>  [af3963c32c63893949a3028396af90ee7d811e5b]

        cui: fix --without-java build
        
        This went wrong in commit 7795a2adc0a724220440dca997495043902f1384
        (Allow bootstrap variables in Java user classpath settings, 2nd try,
        2023-06-12), I assume that _rPath is always empty in the without-java
        case.
        
        Change-Id: I8749f5bd30b0853a76fb9ccf5d1e7a8e4e23f1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153386
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2023-06-21  Pranam Lashkari  <lpranam@collabora.com>  [3924368f4837332bba640906be9a9d2e2e6b22cf]

        sd: send correct slide visibility status
        
        The term visible may be a bit aambiguous here,
        we try trying to send info about if the slide is hidden or
        visible in the slide show.
        The correct property for that is "exclude"
        
        Change-Id: Ic505036181b71686656bd2338b9d0329c12d9e74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152688
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit fe79008f70e7a790e4f78c1714c27ea223512327)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152988
        Tested-by: Jenkins

2023-06-21  Eike Rathke  <erack@redhat.com>  [02fc35d879dda6e9c48c89fbb09fe1c618d6673b]

        svl: Use DateTime::Sub() instead of operator-()
        
        Change-Id: I036798013404df4bcfb988d4f231fcf30cec3162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153382
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [299ea597d154e1dc3d0f09adf67e05747cca54cf]

        openldap: upgrade to release 2.6.4
        
        Because NSS support has been removed in release 2.5,
        switch TLS/SSL module used by OpenLDAP to OpenSSL.
        
        Add -pthread flag to openldap_LDFLAGS when building on Linux.
        This avoids errors that occur in libcrypto.a (libcrypto-lib-threads_pthread.o).
        
        Change-Id: I4779ce40233d144d930f20e85db7b4ba08f91ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143646
        Tested-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-06-21  Eike Rathke  <erack@redhat.com>  [ea4f47752391cecef670cbefc9dbfc8b51182c49]

        sc: Use DateTime::Sub() instead of operator-()
        
        Change-Id: Ib73eec1c11ced76890b8eacb0079ae336072a4c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153379
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Eike Rathke  <erack@redhat.com>  [ba54ce4c65b2fcaa549ec3962604c4d5c9bd10fd]

        Use DateTime::Sub() instead of operator-()
        
        Commit this central place use early.
        
        Change-Id: Ib2e40ae7fbe9dc219ba0a7ec4e0f12a82d7b37b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153378
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [10214546a8d0cf745a1d01c0ba3c699143f7d85f]

        Fix script classification of USCRIPT_WARANG_CITI
        
        When the original code was introduced in:
        
        commit d83e115bae521fcf193978496d62dbc677a1d6ef
        Author: Martin Hosken <martin_hosken@sil.org>
        Date:   Fri Mar 4 19:57:29 2011 +0700
        
        USCRIPT_CODE_LIMIT was set to 146 and that what the original code wanted
        to classify as ScriptType::WEAK. ICU changes USCRIPT_CODE_LIMIT as it
        adds new scripts, so it got re-assigned with newer ICU releases and
        USCRIPT_WARANG_CITI was unintentionally classified as ScriptType::WEAK.
        
        Change-Id: I5deb5f2050380968ea83b3af969ceae75b1c0070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153373
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [56e58e6a1280d9bdd23550ba998f14aef4980244]

        sc: add CharComplexColor and CellBackgroundComplexColor properties
        
        Change-Id: I30153796a39b2aa3648cb107905974ed6f0f3851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151668
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [bb2c55b2c8f72bfbb7f98cf88911cb88ee1a71d6]

        tdf#114432: classify Tangut and Khitan Small Script as ScriptType::ASIAN
        
        They are CJK scripts so should not get spacing applied between them and
        other CJK scripts for instance.
        
        Change-Id: Iab88ff1490733e514fd37436cff937dc5fc8dce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153372
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Khaled Hosny  <khaled@libreoffice.org>  [b1d226bdf963902782abac128e155956be6aae0d]

        Use switch statement in unicode::getScriptClassFromUScriptCode()
        
        Makes it easier to tell which is script is given which class, and to
        extend it with newer scripts.
        
        Change-Id: I736e078b94f4d324dd5ceabeac5a2d11c25da3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153371
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [98229bb7b7f2bdcfbcb9275eeee797d638f13bac]

        Fix typo
        
        Change-Id: Id2a9f8eeb5032ef65c5457cd747915914bc32d64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153317
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-21  László Németh  <nemeth@numbertext.org>  [993e420e3b89193b14c8289abcaecca9a90fc42f]

        tdf#155951 sw: fix crash using XTextRange::getString() in selectionChanged()
        
        XTextRange::getString() triggered selection change event,
        resulting infinite recursion, when getString() used
        in selectionChanged() of the listener.
        
        Steps to reproduce (used by the unit test, too):
        
        Add a XSelectionChangeListener to the document with a
        selectionChanged() calling the getString() of the selected
        text range. Select a word in the document editor using
        the Ctrl-Shift-arrow keys.
        
        Change-Id: I87a0f60cee3663f5303d6eb6980058ccdcc373e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153356
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-21  Miklos Vajna  <vmiklos@collabora.com>  [e68259e0bd757ef2a2be94207b9766125a1fb017]

        CppunitTest_sw_htmlexport: avoid reqif magic in testNoLangReqIf
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I49cf0e34354178054db2daa10902917cb5d45080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153361
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-21  Eike Rathke  <erack@redhat.com>  [66da786bdd4588b31755058acf46034c2056215c]

        Introduce double DateTime::Sub() as a substitute for friend double operator-()
        
        Change-Id: Idb93b3e9b4dcbd09ad7f4253a523fe5be24d0776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153354
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-21  Paris Oplopoios  <paris.oplopoios@collabora.com>  [098e8d6f111ca9d7680ed1eec00522fed6487e95]

        sw: Fix spell checking having no view separation in tiled mode
        
        Turning spell checking on or off for a single view would turn it on/off
        for every view which is correct behavior normally but not in tiled mode
        because different views might want different view options
        
        Change-Id: Ib422f692e97618cfba6a7cb8b2a4f2b3f20a0ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153343
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-21  Justin Luth  <jluth@mail.com>  [e321d85089fc1dd73cd1f1443a53226a25695194]

        tdf#122270 sd: refresh notebookbar after switch to/from master view
        
        Although the state of the uno items was changing,
        the notebookbar was not refreshing to display the new state.
        
        Change-Id: Ifda5e6dcfa1d569ba75d0c94cdf0bc94c63977d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153360
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-21  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7795a2adc0a724220440dca997495043902f1384]

        Allow bootstrap variables in Java user classpath settings, 2nd try
        
        Add a second mode: When a classpath starts with '$', bootstrap variables are recognized.
        The classpath must then be provided as URL, not native path.
        
        Change-Id: Idcc229a2b4e9a512b0e712ea932a6e4293907db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152899
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [27e1c198a504deb4634f5f6673a77b5944c9f8cc]

        poppler: upgrade to release 23.06.0
        
        Add external/poppler/disable-nss-and-gpgmepp.patch.1 to get rid of
        some code that requires NSS or GPGMEPP.
        
        Update external/poppler/inc/pch/precompiled_poppler.hxx.
        
        Change-Id: I5e61371776c64962452022516446b5079c3840e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153097
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-06-20  Henry Castro  <hcastro@collabora.com>  [484467978c5309f3c7adb7544242e96de4efb7e8]

        lok: vcl: fix "ImplConvertToAbsPos" function
        
        The conversion to absolute position is ignored for mirrored graphics,
        otherwise, the popup window will be closed after the mouse up event.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2cb101b07f1aa79ab8aa605637b276ad3a56ce88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152681
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153328
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153368
        Tested-by: Jenkins

2023-06-20  Henry Castro  <hcastro@collabora.com>  [51ea59ad5441a68aa89ce5faf0cbfde8589c2ce7]

        lok: sc: reset RTL if it is changed
        
        Reset the LOKSpecialFlags, otherwise the
        selection engine select wrong lines.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I94e33cc3e293330d9a3480bd3838a20c1d94d15f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151841
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153365
        Tested-by: Jenkins

2023-06-20  Henry Castro  <hcastro@collabora.com>  [a4677551e8c3a7774f039a8344616e5e5b6e402f]

        editeng: fix assertion uninitialized enum
        
        constexpr typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = LOKSpecialFlags; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<LOKSpecialFlags, 119>::Wrap]: Assertion `o3tl::detail::isNonNegative( o3tl::to_underlying(lhs))' failed.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8617c877ad2d705988f4dea0e54442e5002a43be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151533
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit cce4ad3dd4d678e1cc6bf7523f5375e10b100147)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153362
        Tested-by: Jenkins

2023-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0c2e580a1c5b055295d303ebb9c9e905ab4890c]

        tdf#155814: only check parent style when it has a local css style
        
        This also fixes the problem for filters and mask, since they
        are call from add_postProcess
        
        Adapt some tests to the new xml output. Visually nothing has changed
        
        Change-Id: I65d2491409019f4cd0b1113a9a7931fc602c57b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153355
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-20  Henry Castro  <hcastro@collabora.com>  [862cdd148d5c6f9563f8a9b11f7559cd022c9c4a]

        lok: sc: fix layout RTL mouse selection
        
        If the Calc is in layout RTL, the edit view mouse
        selection does not change.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I0bd2640dac3cdc96fa247c305c379b2d1a8564ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151974
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153357
        Tested-by: Jenkins

2023-06-20  Henry Castro  <hcastro@collabora.com>  [c318f7bf20f21ea0e61b7069e4879868265b70c7]

        lok: sc: fix layout RTL
        
        The function "IsRightToLeft" fails in Hebrew language
        when Calc has a layout RTL, add additional condition
        to check the layout.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If3972b80770a7aa6073881487e411a34cc6871d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150758
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153350
        Tested-by: Jenkins

2023-06-20  Khaled Hosny  <khaled@libreoffice.org>  [e0a461466846f64a39868ac921d4b9e1636f5e26]

        tdf#115321: Fix PDF position of emphasis mark in vertical text
        
        This aligns the code in PDF writer with
        OutputDevice::ImplDrawEmphasisMarks().
        
        Change-Id: I404beda30ff0eb1d6c59d971a7daa59b559ef70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153326
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-20  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a4e12cbfc69cfe668fa30756a3c5843e911e22b1]

        tdf#155863 sd: fix resizing of cropped images to original size
        
        Resizing with the function "Original Size" (e.g. in the context menu) resulted distortion in case of cropped images, if the original image
        and its cropping have different aspect ratios. Now zoom the cropped
        image to the original resolution instead of stretching it to the
        same size.
        
        Change-Id: I5e59f8b48dc03844a739c3eb803e3195a12d9c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153170
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e0e67a152e9631574e28dacb6e06a96f03ebca2]

        tdf#155932: tdf#97717: only apply opacity when primitive
        
        Partially revert d47b37eea9779e3c354e6c19a7211a306965b7ef
        "tdf#97717: do not call add_postProcess from g element"
        since we still need to call add_postProcess from g to
        apply the clip-path
        
        Change-Id: Ibdc5afadc0db239d0b0e14810943009a4c0a16a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153353
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c226d2624c2320f22f5c14895d419d4df82a91d]

        svgio: simplify test file a bit
        
        Change-Id: I2ecbe089b74b9c9f155a44f8706b6832f778c3f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153320
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [a9e819430702e89454ef7af0c1019ba8e2617903]

        Remove German capitalization from some translatable strings
        
        Change-Id: I74f886c651ea7973cc60e3771f2de6eaa449fe4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153231
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-06-20  Eike Rathke  <erack@redhat.com>  [d3d77d99e3e6f05b232923edc2ea23e513a721d5]

        Use tools::Duration in friend double operator-() if DateTime has Time set
        
        Change-Id: Iff3e2aad596fdfd1530c46cdeff28b44e5142517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153327
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-20  Justin Luth  <jluth@mail.com>  [1ff817faad79952e6271bab178d41cae2a0d9ecd]

        tdf#126095 impress notebookbar: don't force Master/Presentation toolbars
        
        When in the notebookbar mode, non-notebookbar toolbars should
        not be enabled automatically by the application.
        
        The user still has the ability to turn them on.
        
        
        Change-Id: Ib601b63390a8d806604b68ed2ea198198f4318ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153303
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [90f40e996fe1aaa93606f7e1b1fb60882bcf058b]

        tdf#43369 Refactor PosgresSQL connection setup
        
        + Moved static strings to ui file, handled by Glade
        + added extended tips to widgets
        + deleted references to strings in the controller.
        
        Change-Id: I0acb444eff37adbfc0225656669af9d5650b7bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153127
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-06-20  Henry Castro  <hcastro@collabora.com>  [e7f486f10fd21bee78dea0d2eda241dd094d783d]

        lok: sc: restore edit output area
        
        The edit view output area is modified after the draw,
        restore it so the mouse can handle selection at layout RTL.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I94dd9db385a3a9c60f015027894338504b4ce533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151972
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153325
        Tested-by: Jenkins

2023-06-20  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [72e70088dc45fbe15f809abf5263247b13d937ac]

        tdf#122676 sc: fix format with * (filling) and NBSP thousand separator
        
        Numbers containing no-break space (NBSP) thousand separator enabled
        the EditEngine layout, losing filling e.g. for stretching spaces.
        Enable EditEngine for NBSP characters only if there is no filling
        in the number format code, fixing MSO interoperability, too.
        
        In number format codes, asterisk (*) followed by a character is used
        to fill the available space in the column with that character, e.g.
        format code
        
        [>0]" "* # ##0" € ";[<0]-* # ##0" € ";" "* -#" € ";" "@" "
        
        put the minus sign at the left side of the column, while
        the number at the right side of the column. Because of the NBSP
        thousand separator, bigger numbers got different layout previously,
        i.e. minus signs right next to the numbers.
        
        Note: there is a better solution for the layout problem: using narrow
        no-break space (U-202F), which is the proposed thousand separator in
        typography, and it's back-compatible, because it doesn't enable the different layout.
        
        Change-Id: Ia35f01733687ee6005f06ff3ab999b7a4b712ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152901
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-06-20  Henry Castro  <hcastro@collabora.com>  [baf500ba9abed7f32439a1be60a1c51cc10f9d67]

        lok: editeng: add LOK special flags
        
        The function "IsRightToLeft" fails in Hebrew language
        when Calc has a layout RTL, create a special flag to handle.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I661f49dc5990f39807c6dba10970dea8c502643c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151971
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153322
        Tested-by: Jenkins

2023-06-20  Khaled Hosny  <khaled@libreoffice.org>  [1afc13b0b84353109827d78807836c01f030ab66]

        tdf#107718: Fix script itemization of vertical text
        
        Mixed script vertical text was not correctly splitting runs at script
        changes, resulting in Hangul text being mixed with Han text in the same
        run breaking the Hangul composition.
        
        Change-Id: I09c3f799bede6aa8a19684779d500504a9813af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153313
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-20  Daniel Lohmann  <LibreOfficeContribution@dldld.de>  [ca90149fa3f7c8161393490d4c0149c1cbcc3c28]

        tdf#155920: next effect in END mode should no resume show
        
        When starting a presentation and moving over the last slide into the END
        mode the next effect should not resume the presentation. Instead it
        should exit the presentation. Furthermore, when hitting then the back
        key it should show again the last slide (only resuming the presentation,
        not directly resuming and moving back to the slide before the last.
        
        Change-Id: I816232725d923601356e0bc8e39421f256d184eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b13733de130e2f1ca029315e977dc01bd196b05b]

        sd: fix setting theme for notes master
        
        Notes master also needs a theme set or the document will not load
        properly. For now we don't save the theme for the notes master on
        import, so we can only set the default "LibreOffice" theme instead.
        
        Change-Id: Ia9e5db53d4e1a4ca06b10d147cc879475166dfd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153314
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-20  Tünde Tóth  <toth.tunde@nisz.hu>  [6b3e29536ca770d7c2c42429390785c326d223ae]

        tdf#145651 Chart OOXML export: fix write error in exportSolidFill
        
        Don't export the background color, if the FillColor property is empty.
        
        Steps to reproduce:
        
        1. E.g. in Impress, insert a chart (Insert > Chart...).
        
        2. In chart editing mode, select the legend, use the "sidebar > Area >
        Fill" and change from "none" to "color". Notice how the default blue
        that is used does not correspond to the colour in the colour picker
        right underneath.
        
        3. Save as > OOXML format.
        
        Change-Id: I33a060d8fc6c49708029008393e2e22e3d5335b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152951
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-20  Stephan Bergmann  <sbergman@redhat.com>  [12364a7d4ca2f74f57d9a4f3a63ad4dfe8205bb6]

        XMLTextParagraphExport::DocumentListNodes must be a complete type
        
        ...at least when building with --with-latest-c++ against recent LLVM 17 trunk
        libc++,
        
        > In file included from xmloff/source/text/txtparae.cxx:22:
        > In file included from include/o3tl/any.hxx:21:
        > In file included from include/com/sun/star/uno/Any.hxx:28:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/algorithm:1779:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:27:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/uninitialized_buffer.h:14:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'XMLTextParagraphExport::DocumentListNodes'
        >    63 |     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >       |                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<XMLTextParagraphExport::DocumentListNodes>::operator()' requested here
        >   297 |       __ptr_.second()(__tmp);
        >       |       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<XMLTextParagraphExport::DocumentListNodes>::reset' requested here
        >   263 |   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >       |                                                                           ^
        > xmloff/source/text/txtparae.cxx:1333:25: note: in instantiation of member function 'std::unique_ptr<XMLTextParagraphExport::DocumentListNodes>::~unique_ptr' requested here
        >  1333 | XMLTextParagraphExport::XMLTextParagraphExport(
        >       |                         ^
        > include/xmloff/txtparae.hxx:115:12: note: forward declaration of 'XMLTextParagraphExport::DocumentListNodes'
        >   115 |     struct DocumentListNodes;
        >       |            ^
        
        Change-Id: I319c1f682258950caf3571f51e5443d6753bcccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153312
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e55a1ca02b281d8a841361c1315b7e0ee7d75119]

        Resolves: tdf#155750 allow private:factory urls in floating frames
        
        they create a new document so there isn't an associated location
        which would trigger the prompt to allow it so just allow factory
        urls
        
        Change-Id: I7b693bcfe5ac04aaed06905637ab3c1eba43c51f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153316
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-20  Regina Henschel  <rb.henschel@t-online.de>  [b08ceed6e82e58089e58d15e5ac694b8517349be]

        tdf#155827 MCGR: Axial to linear in oox export, apply...
        
        ... separately for color and transparency gradient.
        
        The current solution had the change from axial to linear applied to
        color and transparency gradient at the same time. That resulted in
        wrong gradient if only one of them was axial.
        
        Because changing axial to linear changes the number of stops, it has
        to be applied before color and transparency gradients are synchronized.
        
        As now color and transparency are both linear already after they
        are synchronized, the switch can be replaced with a simple if.
        
        Change-Id: I75e6b495782bc8a9fe94504426efadec2f60b61f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153197
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-20  Stephan Bergmann  <sbergman@redhat.com>  [783851f99c25ba53331fafc03523d3537617cd2b]

        loplugin:cstylecast
        
        Change-Id: I32e3e9bff261f95010582c6e5e2d22abb725f402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153311
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-20  Miklos Vajna  <vmiklos@collabora.com>  [2d0a4ef1d83b8de6cb133970c2c35ae706fb058e]

        sw floattable: fix negative vertical offset handling on page boundary
        
        The bugdoc has 3 floating tables, the last one was on page 1 in Word,
        but it was on page 2 in Writer.
        
        It seems what happens is that the vertical offset of the last table is
        negative, so it is moved above the paragraph before the last floating
        table, but once the anchor frame (last paragraph) is moved to a new page
        (because it doesn't fit), then its fly frame is also moved to page 2,
        which leads to overlapping text in the original bugdoc. Interesting this
        works already with 0 vertical offset, and in that case we split the last
        paragraph, fill the page 1 part with a fly portion and fill the page 2
        part with the anchor text.
        
        Fix the problem by:
        
        - triggering a split of the frame in SwTextFrameBreak::IsBreakNow(): if
          the anchor frame doesn't fit (has to be moved to a next page), then
          split it, so only the anchor text is moved, the fly is not (so its
          position matches Word)
        
        - preventing the manipulation of the frame offset in
          SwTextFrame::AdjustFollow_(), so no content is moved from the follow
          to the parent, because that would mean later we move the joined frame to
          the next page
        
        - finally minimizing the frame height at the end of
          SwTextFrame::Format(), so the master still fits the current page
        
        An alternative approach would be to extend
        SwAnchoredObject::FindAnchorCharFrame(), which already has code to
        handle the case when the text frame master and the anchored object is
        not on the same page, but that operates on existing anchor frames, and
        here the original problem is that the entire anchor frame is moved to
        page 2, so we don't have anything left on page 1. Note that this is all
        specific to floating tables, I could not reproduce the same behavior
        with an anchored shape in Word.
        
        Change-Id: I007b57b369f5c1e98ccad77111958dfd9335f079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153309
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-20  Miklos Vajna  <vmiklos@collabora.com>  [abca28b4db956848271b53b4bc59f79b5f2f2529]

        sw: document SwFormatLineNumber
        
        The primary use-case here is to have this in certain paragraph styles,
        so that they can request "don't count these lines", like Caption or
        Header.
        
        Change-Id: I2af591d2713cc23f4b634b69797f0dd61a37a2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153298
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-20  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [eca4e82cac2c9fea6f9bd23fb0196ee7a3016223]

        Fix typo in .git-hooks/pre-commit
        
        ...to avoid a error "Cannot run git diff-index. at .git/hooks/pre-commit line 51." that occures on Windows.
        
        Change-Id: I868e87940f9fcef950970b59e8cbe747f80c7198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152830
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-06-20  Hossein  <hossein@libreoffice.org>  [f9f7cfc080c3adb751ceca96be4ca5440de4a2b6]

        tdf#122970 Fix direct cursor leaving screen trail
        
        Previously, an old method using RasterOp::Xor rendering (see tdf#38844)
        was used to draw the extra triangle left or right of the mouse pointer
        in direct cursor mode. Now, instead of drawing it manually, we change
        the cursor type to somewhat similar pointer type.
        
        There is no perfect match for the previous mouse pointer shape, so now
        instead of left triangle, PointerStyle::AutoScrollW is used. Also instead
        of right triangle, PointerStyle::AutoScrollE is used.
        
        Change-Id: Iadb955f9fcee0978a190e0b8920186a2579f3a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153099
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-06-20  Henry Castro  <hcastro@collabora.com>  [71e5f7e43471cc479ea1e818c813170a389964e6]

        lok: sfx2: fix change state "SheetRightToLeft"
        
        The UNO command "SheetRightToLeft" can be disabled
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I54742c9d52eb52e36154e0aac2cdf440771eb177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152502
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        (cherry picked from commit fc8270f06eca5ba2ba25673a424b36d9e352f62a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152546
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153267
        Tested-by: Jenkins

2023-06-19  Henry Castro  <hcastro@collabora.com>  [3a827ee8f05a5188eebda90d0e306cc90ee28638]

        sc: filter: oox: fix setting value to color scale
        
        The COLORSCALE_VALUE setValue method reset the mpCell
        that contains formula.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Idbbfcdc5bce78542ce671753d9a70dcd375e7966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153281
        Tested-by: Jenkins

2023-06-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [08a6ca6d426280f9ce225d9f25694c43e7ab810f]

        tdf#145896: set style to 'text/css' by default
        
        This is a regression from 4c31a0be1d8048bf3340acbb59248185e4b93041
        "Resolves: #i125326# accept CssStyles with missing type attribute"
        
        Calling setTextCss(true) when there are no attributes is wrong,
        since it might have attributes like 'id'.
        The unittest added also covers i125326 is still fixed
        
        Change-Id: Ic5e4899211ae98c866f64f17e69a3a8cd24e4959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153290
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [35803990c9b1881074460659acdac6b2799c99ee]

        tdf#43671: Pass through emphasis mark setting with cairo canvas
        
        Other canvas implementations passed it through, but cairo canvas was
        not.
        
        Change-Id: I9b4cc500998635568c095866f9099f83bf1c984e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153299
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [d80d89d98183ee0c1a232b975107c319001f3fbc]

        embeddedfontshelper: use u16string_view instead of char pointer
        
        Change-Id: I7a6088c570ebd0680cc1b2603b946192a19bef26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153268
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c276b859c56a173daeb3070a0b3a8cbbffa1822d]

        Fix typo
        
        Change-Id: I2528c5e9020594c78657ee290f8ca4589d31a2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153257
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a18a7adc4a7892c7ab7f782e7641c7d16aa06353]

        Fix typo
        
        Change-Id: I53b09910c8981003bb77f98e8e1dd10ee9356b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153296
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5f3253cd445fd1a881931111dc192fe4a3e5a9a6]

        Fix typo
        
        Change-Id: If782f7310b1c1b7e7855a6b6050ebe9acdf4da20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153297
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [558892a77d8532edbb7fcd311f7dbd18a8fa7f90]

        CppunitTest_cppcanvas_test: clang-format
        
        Change-Id: Id6497a9dd275ec4e782bcb58b90a27ef569764fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153266
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [5dfaecfd87df45953f6d4a85704aab9eb99b0d0e]

        tdf#155810: Add test
        
        Change-Id: I7cea421778335e8d5dd344dd04efdba843945383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153264
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [1f7a367f0d3722502561701cbafae448cb11cbb3]

        CppunitTest_cppcanvas_test: generalize testComposite
        
        Make it pass without cairo canvas.
        
        Change-Id: I81dd5d21bde6d1e09c2e8eeea75d05ddf1793d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153263
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [fc72d1d0c635031b577a12ffbfa79bd04adbae66]

        CppunitTest_cppcanvas_test: enable even if cairo canvas is not
        
        I want to add more tests to it.
        
        Change-Id: Ibadfbafbaa6d6b1cfc1f9aa3761a04de2e2c1f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153262
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Khaled Hosny  <khaled@libreoffice.org>  [cf6950962832f3d7acf30eaed81c5b660c9c6135]

        CppunitTest_cppcanvas_test: use CPPUNIT_TEST_FIXTURE()
        
        Change-Id: I736e67530643a0949e3078a873ba3105f359ed1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153261
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Jaume Pujantell Traserra  <jaume.pujantell@collabora.com>  [2ab23ac48d5ebbfb87177bcee4acceecd88ce69e]

        fix crash on LOKIT spelling dialog
        
        Update active view before trying to access it's selection.
        
        Change-Id: Ic83d335216304f7122005e447f5bd1c1484d0eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153136
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-06-19  Patrick Luby  <plubius@neooffice.org>  [b31c9722d1fce88b1511f741b152bccecffee1e1]

        Fix nightly build failures on Mac Intel
        
        When adding entitlements in a debug, non-codesigned build, the
        codesign command fails on some Mac Intel machines. Since this
        command is only executed in non-release builds, ignore any
        failures.
        
        Change-Id: I4d89e03bbbc00725b2902446f2abbb99f273eab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153269
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-19  Eike Rathke  <erack@redhat.com>  [174a72f3fd50d1146d6bedd4cc2a1971aa33be67]

        Use tools::Duration in ScInterpreter::CalculateAddSub()
        
        ... for all (date+)time inflicted operands.
        
        Change-Id: I93043d912867e2ef7d4af271b5c4566a3ffb4ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153291
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [e27d4cc31e04be4c47b5085dfa2363ee45457e8a]

        tdf#150534 reduce the memory consumption of cells when calculating
        
        borders - if there are a lot hidden columns, we end up
        allocating a lot of cells. Since most of the cells have the same
        settings, use a SfxItemPool to consolidate them.
        
        Change-Id: If2dd77b3eabc5d37eb8804953f8c89ffa04f2400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-19  Stephan Bergmann  <sbergman@redhat.com>  [281bdb5a979f0516fe7a9cd35585fd3daf4021b1]

        Initialize SfxObjectShell::bRememberSignature
        
        ...introduced in 46722dbaa7795074e3c5043a76ae3f3a7782491e "tdf#155665 Adding
        option to remember signatures for each save", to avoid
        
        > sfx2/source/doc/objserv.cxx:1230:39: runtime error: load of value 190, which is not a valid value for type 'bool'
        >  #0 in SfxObjectShell::ExecFile_Impl(SfxRequest&) at sfx2/source/doc/objserv.cxx:1230:39
        >  #1 in SfxStubSfxObjectShellExecFile_Impl(SfxShell*, SfxRequest&) at workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:220:1
        >  #2 in SfxShell::ExecuteSlot(SfxRequest&, SfxInterface const*) at sfx2/source/control/shell.cxx:456:9
        >  #3 in ScTabViewShell::ExecuteSave(SfxRequest&) at sc/source/ui/view/tabvwsha.cxx:840:34
        >  #4 in SfxStubScTabViewShellExecuteSave(SfxShell*, SfxRequest&) at workdir/SdiTarget/sc/sdi/scslots.hxx:1481:1
        >  #5 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at sfx2/source/control/dispatch.cxx:254:9
        >  #6 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) at sfx2/source/control/dispatch.cxx:753:9
        >  #7 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) at sfx2/source/control/bindings.cxx:1060:22
        >  #8 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at sfx2/source/control/unoctitm.cxx:688:53
        >  #9 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) at sfx2/source/control/unoctitm.cxx:266:16
        >  #10 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx:163:30
        >  #11 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx:120:16
        >  #12 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/dispatchhelper.cxx
        >  #13 in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:94:33
        >  #14 in testInvalidEntrySave::TestBody() at sc/qa/unit/tiledrendering/tiledrendering.cxx:2826:5
        
        during CppunitTest_sc_tiledrendering
        
        Change-Id: Ie3a8453c0222cb0a2a239d6d9133a9aafe1e2870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153265
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [18f4516ae3cf0d0bdc8985eb0d1b804f65278252]

        Restructure a bit
        
        Change-Id: I27f494e8df25163fa3044311ce7c8cfc942980e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153259
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  luigiiucci  <luigi.iucci@collabora.com>  [e7c885389bfb9387acf8a21ea38769e678a76aac]

        tdf#155486 Adding fonts to .odt when there is "no perfect match"
        
        Problem does not seem to have any
         relation with .otf files management.
        Problem arises when:
          - we use a font with setting certain
            family/bold/italic/pitch values
          - we have this font installed, but
            we don't have a version with
            matching
            family/bold/italic/pitch
        In this case the "not a perfect match"
         fonts were not saved in the .odt
        
        Change-Id: Ie4e2b9c34b79ac99f03c57bed4fdc5f4d718dcc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153007
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [d47b37eea9779e3c354e6c19a7211a306965b7ef]

        tdf#97717: do not call add_postProcess from g element
        
        Otherwise, it will be called twice, from g and from its children
        
        Change-Id: I88535a7caab6a7711f917b3f383cd79b3b9fbd2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153260
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-19  Julien Nabet  <serval2412@yahoo.fr>  [99d01ff26fe69ccc66f49b3ddd43b258c3687f2c]

        Fix TB Jenkins_Linux_Ubsan (duration.cxx)
        
        /tools/source/datetime/duration.cxx:190:77: runtime error: negation of -2147483648 cannot be represented in type 'sal_Int32' (aka 'int'); cast to an unsigned type to negate this value to itself
        0 0x7f08bd84936d in tools::Duration::Mult(int, bool&) const /tools/source/datetime/duration.cxx:190:77
        1 0x7f08c1c1d27a in tools::DurationTest::testDuration() /tools/qa/cppunit/test_duration.cxx:219:26
        
        Detected thanks to eac63ab120a181a1dff6317ee3d223327080e992
        Related: tdf#153517 Introduce class tools::Duration
        
        Change-Id: I3804cc4ff4011a7f3b393b82b27f0c805682fbb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153254
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2afff27c5327bcb30f894d9a507131f2ad8f1dc6]

        tdf#155086 remove code that sets theme color to shapes as DF
        
        Remove this functionallity for now until we support theme colors
        in shape styles. Then we can do it for the default style, and not
        as a direct format for each inserted shape.
        
        Change-Id: Ib042072954a79cadc750372333c40269fbe4ca40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153244
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [703c28d76924bcbda3f492de8a14cc9c30ee1dfb]

        sw: Test paragraph level text background
        
        Change-Id: Icea365ae036cae49749dd24bb8412775fafbd6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153247
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f2e0b916fe53c5517f0dc06abb2e2839fb579cad]

        Update git submodules
        
        * Update translations from branch 'master'
          to 25766b4c4f5fe4e28a338f318013d1097228516d
          - update translations for master/7.6
            
            and force-fix errors using pocheck
            
            Change-Id: I49fa67ebe7d8c3ec8f411920017667c1ae1875be
            
2023-06-19  Maxim Monastirsky  <momonasmon@gmail.com>  [4d5508e27bdccb7d1465686773bb57a14310ed14]

        tdf#103064 Don't overwrite all formatting with DF on lang change
        
        i.e. right click on the language field in the statusbar, and
        choose a language from the popup menu.
        
        We now start with an empty itemset and only put there the
        modified items. This in turn makes the spelling restating
        hack unnecessary, so move it near its last consumer in
        ResetLanguages.
        
        Change-Id: Ie0f97a7fa41dc19b5785a41ee2ef4fb9c814f74a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153252
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [23a7fb9582fba4e5b699f0ea4bb270719256b403]

        oox: ThemeExport - add "relationship" xml:r namespace
        
        Blips are referenced by r:embed element, which needs the xmlns:r
        to be present, so add it at the toplevel.
        
        Change-Id: Iccc3d197bf30b428927521c6ba598d8d92fa734d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153243
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-19  Miklos Vajna  <vmiklos@collabora.com>  [01eff4a68b05dd4eeee94bc4b3b018059efa60d4]

        sw floattable: avoid layout loop for negative vert offset in MakePos()
        
        The bugdoc has 2 paragraphs and a floating table between them. The
        floating table has a large enough negative vertical offset so it "pushes
        down" the paragraph that is before the table in the doc model. Our
        layout didn't push the first paragraph down, the second paragraph
        overlapped with the table and the whole layout process was just stopped
        by the layout loop control.
        
        What happened is that we realized that we have to push down the first
        paragraph, so an SwFlyPortion was created for it. Then we made an
        UnlockPosition() in SwTextFrame::MakePos(), so it could be calculated
        again. This lead to an oscillation, and the calculated vertical position
        of the floating table's fly changed between 964 (good) and 2990 (bad)
        twips.
        
        Fix the problem by limiting when SwTextFrame::MakePos() calls
        UnlockPosition(). The general strategy is that flys are only positioned
        once during a layout pass. The exception from this is when the fly moved
        to a new page and it's not yet positioned. So if we unlock when the fly
        only has the page frame top left position, then we keep the original
        use-case working, but fix the layout loop.
        
        Regression from commit 12a9009a1c19ee26c65fb44fc90f3432c88ab6a5 (sw
        floattable: fix bad position of follow fly if anchor is positioned late,
        2023-03-23), where I didn't realize how dangerous UnlockPosition() is.
        
        Change-Id: I0aa0a52db712a464105e8040497fd429e0604309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153245
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-19  Miklos Vajna  <vmiklos@collabora.com>  [4034578cc6cd927b0074106a6f823bec765e4805]

        svx: prefix members of EnhancedCustomShape2d
        
        See tdf#94879 for motivation.
        
        Change-Id: I88eaa11f4eaca381a9cb95aa2f24b5a43c7ca80d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153246
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [173ce4548c0cfe6dd50904cb8a9323426a65feab]

        Expand a macro inline
        
        Change-Id: Icd1e63616af383c98b35d8bd70cf83b007f8473a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153242
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [fb9614ddb4c27c8ef61c84110b481db85b8ad07b]

        Drop code leftovers of HTML 3.2 support
        
        The support itself was removed in commit 3f43b02433b970cd36ee4c9249e425d6b1bd9fbe
        (Remove HTML 3.2 export option, 2011-08-26).
        
        Change-Id: Ide699aed3078fd60490c49bb20b5fc487002726a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153241
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [622e49a2da8243631e413be9335304c458cec9a5]

        Simplify a bit
        
        No other options are possible, as implemented in GetExportMode
        
        Change-Id: I0ed00173d9a7b56bde841831c2964b2572fb1140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153240
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [9e4d16d75156bb1080118353a66846b18cf5ba04]

        Simplify a bit
        
        No other options are possible, as implemented in GetExportMode
        
        Change-Id: Id64ec1b5bd52f28a100bd2b31cd56c6620bb2cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153239
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  Mike Kaganski  <mike.kaganski@collabora.com>  [404298113071c182a24d74b6acfdd4f739dbe86f]

        Mark obsolete options as such
        
        They were removed since commit b7ae1f52ddcc9729e3c078563c5f17e4ee9a00c2
        (#97559# HTML export for Netscape 3.0 removed 2002-07-04), and commit
        3f43b02433b970cd36ee4c9249e425d6b1bd9fbe (Remove HTML 3.2 export option,
        2011-08-26).
        
        Change-Id: Ie05245929bca67ee4ebed66ab1bea25349f62e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [760c7a806ced3861086d5fdfbb7b4b1461948c27]

        tdf#38742 - Start Center: move last opened documents to the top
        
        Change-Id: If395b0784d9bdcdc1200c15fca60647da825ea1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153150
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-06-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1128a505a1637cce4c35871432ac902ca2335c64]

        ofz#59902 Integer-overflow
        
        Change-Id: Iedb4ca9aef44ef8ead9b021075c4808001e9ae5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-18  TokieSan  <eltokhy@aucegypt.edu>  [46722dbaa7795074e3c5043a76ae3f3a7782491e]

        tdf#155665 Adding option to remember signatures for each save
        
        Added the option in digital signatures dialog to remember used
        signature.
        
        Implemented ResignDocument function in objserv.cxx to resign after
        every save in case the option to remember signature is on.
        Added a new dialog box that checks whether there is a need to
        remember the signature.
        
        Change-Id: Ia7dbcc952044e9542e3fe6cd84b5d6633fcd1461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152687
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-06-18  Khaled Hosny  <khaled@libreoffice.org>  [68a4f005bc3e74d847e82dddf3237137cf3a1648]

        tdf#155810: Pass Kashida insertion positions through canvas
        
        This was missed in:
        
        commit 3901e029bd39575f700e69a73818565d62226a23
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Mon Aug 8 22:08:37 2022 +0200
        
            tdf#104921: Cleanup Kashida insertion logic
        
        The width adjustment passed through, but Kashida insertion positions
        didn’t, leaving gaps in place of Kashidas when canvas is used
        (apparently canvas is only used for slideshow).
        
        Change-Id: I25ff30f10cc46a5c87bda2f3936df26b2fc926b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153234
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-18  Baole Fang  <baole.fang@gmail.com>  [94bf26798bb973c7df26e2aa841099bb9cbaf3cb]

        tdf#148836: Alphabetize customize keyboard dialog
        
        "All Commands" is kept at the top, and LibreOffice Macros, Styles and Sidebar Decks are kept at the bottom,
        while others are sorted alphabetally.
        
        Change-Id: I0c8287d4ffed9f9ee901d306a16670933541ba93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152179
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Julien Nabet  <serval2412@yahoo.fr>  [b0bdc7c11cdc98aa02b6bef11868d06f623d5d01]

        Regression from speed up startup time(e51b4fc8c278bfa0b0671bbdb0ab35346881ebb7)
        
        for getOutlineNumberingLevels
        
        TB Jenkins_Linux_Ubsan
        26316         [_RUN_____] SwDialogsTest::openAnyDialog
        26317 NEXT    /i18npool/source/localedata/localedata.cxx:1330:33: runtime error: call to function getOutlineNumberingLevels_de_DE through pointer to incorrect function type ´const rtl::OUString ***(*)(short &, short &, short &)´
        26318         /workdir/CustomTarget/i18npool/localedata/localedata_de_DE.cxx:1475: note: getOutlineNumberingLevels_de_DE defined here
        26319             #0 0x7f5f948b75d8 in i18npool::LocaleDataImpl::getOutlineNumberingLevels(com::sun::star::lang::Locale const&) /i18npool/source/localedata/localedata.cxx:1330:33
        26320             #1 0x7f5f948263ba in i18npool::DefaultNumberingProvider::getDefaultOutlineNumberings(com::sun::star::lang::Locale const&) /i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx:345:36
        26321             #2 0x7f5f948264ee in non-virtual thunk to i18npool::DefaultNumberingProvider::getDefaultOutlineNumberings(com::sun::star::lang::Locale const&) /i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx
        26322             #3 0x7f5fc2d8e917 in svx::sidebar::OutlineTypeMgr::Init() /svx/source/sidebar/nbdtmg.cxx:585:35
        
        Change-Id: Ic291f9badad2047980bff848e83bc56b8beaa723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153235
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d7bc610a359ca7e95b3a600c03da6a0b9e6f439c]

        use frozen::make_unordered_map so no need to specify the count
        
        Change-Id: I08057846e735028fb4634fad8b210c707905e096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153233
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ca64e1829e252a32737eed7dfbe11560a5f890e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8edb78135c45defa38dc4edd2103b687b6326f8
          - tdf#155875 Tabbed UI commands Writer in Help pages
            
            + refactoring
            + Writer View menu (part 8 - end for View menu)
            
            Change-Id: Icaa6d102faa114c1fe93525c249563fc8644fa9b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153232
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [165de43e10b77d7e1062a89542d9fbe6be5b3678]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 273e842f064991c1bc94ebc479680d3bea1c3e86
          - better idiomatic English
            
            Change-Id: I7e4fe0d4143a10bd82d29add898a26c48905ebff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153222
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-18  Khaled Hosny  <khaled@libreoffice.org>  [1d57e682c56dab2eade6fb9595d1e1737064dec3]

        vcl: Document SAL_NON_APPLICATION_FONT_USE
        
        Change-Id: I3d5f691a35a3e79d3ae6774f71aafbc66214ecc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153116
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9e121f3a6b95dab7525aa1583f810b2b504ce1b3]

        ooxml: import and export background and fill theme colors props.
        
        This adds support to import and export background and fill theme
        color properties.
        
        Change-Id: I0f40615fe2d06cdcb4f2f9752602fe2ec699c7b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152835
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-18  Rene Engelhard  <rene@debian.org>  [cd9afc213d768b9870c81c580fbb00282c0cf1c4]

        add --with-system-frozen
        
        Change-Id: Ia09254cab5696fa0a3530fcafa5b48acca631ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153208
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-18  Laurent Balland  <laurent.balland@mailo.fr>  [dc03f59374d4fc74dd44ddedc903bb9c00a74bb7]

        tdf#155526 Add Period to trend line equation
        
        Insert Period value earlier to have it ready for representation
        Allow Moving average equation in dialog UI
        
        Change-Id: I1d20572c39462e60b60ab7eec1f174a3cf934d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153094
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a2d7cabe0d7b28334fb6b9742082b3ad58ce519e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 12fb75b6a6ab7048a9b988f9cf638d168dd36f89
          - tdf#155875 Tabbed UI commands Writer in Help pages
            
            + refactoring
            + Writer View menu (part 7)
            
            Change-Id: Idca2fd23bc5c2893566335edfb7084570fe2df67
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153230
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [0c2b2c9babfd781e0d9d68bb2a14a045b0c6ec4c]

        Use getXWeak in stoc
        
        Change-Id: Icd694eeae002ab28cbd06ba3097e9039e299de3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150871
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [627984834cffbe6d1afce8b2be91277c221525b8]

        Use getXWeak in svl
        
        Change-Id: Ia000bf4afa60a4e5bf1469fef7a611ab07e73331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150872
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [f983e193523f9c7ac605627bbf3f3ad576ee7f03]

        Use getXWeak in sc
        
        Change-Id: I6a120265be4e4f2ec859a17459d9d92ea23f00d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150863
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [8da305acc9bc1fa0a31cd61d5da632e6bb4ae48c]

        Use getXWeak in basic
        
        Change-Id: I0915360548ccc02d731eb915b5d32508cedd1461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150835
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [89a25bcda3dde0147f7b4f24eccfffa3216c8c0e]

        Use getXWeak in package
        
        Change-Id: I838b7c0e45a2a701d400fb7189c5396ed4525a70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150860
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [678cb270a68efac78db790f6509ae4774e1d25bc]

        Use getXWeak in editeng
        
        Change-Id: If68b80bae13b2e507f8286f6e316d86c0d0255f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150845
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [bc70f674c2487ad826f8fe04e626de1829f5b40d]

        Use getXWeak in configmgr
        
        Change-Id: Ia7d9475cecd2208ccf672f2b35c0c841fed7f4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150840
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-18  Maxim Monastirsky  <momonasmon@gmail.com>  [8a0a4a4e1fa63edaa5ef923e0db56df7d08eb73c]

        sc drawstyles: Restore text selection after applying a style
        
        Change-Id: I0a9bb39d8a7a9e770b3593eaa0a97867cbe86913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153171
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [48af1ee603149f09236f980c7b323997696bd946]

        Fix typo in code
        
        Change-Id: I8f7e3b11b952b1882ca8e67619145c0dca71820a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153205
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c041b5a3bc3301f137b141e1731b711178d536d2]

        Fix typo
        
        Change-Id: I1d7b271eed63dd0272bd92431eaac3e2dfbfe2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153206
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-17  Eike Rathke  <erack@redhat.com>  [30c48379c7b791edc615e7691691e344baa455a3]

        Resolves: tdf#153517 Use tools::Duration for FillSeries with (date+)time
        
        Change-Id: I18567fdac512ee786ce4b0785b01b2ae6da7450e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153203
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-06-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5c7196acbdd949005c1b52aeab34b5448e09011e]

        tdf#155402 - sc improving CELL() function return value in case of OOXML
        
        In case of Excel/OOXML formula syntax:
        Before the patch =CELL("FILENAME";D2) returns 'file:///X:/dr/own.ods'#$Sheet1
        After the patch =CELL("FILENAME";D2) returns file:///X:/dr/[own.ods]Sheet1
        
        Change-Id: I34c805aef813632c45ac3fe930d690ae3c1d5d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153098
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-06-17  Eike Rathke  <erack@redhat.com>  [eac63ab120a181a1dff6317ee3d223327080e992]

        Related: tdf#153517 Introduce class tools::Duration
        
        Change-Id: I73ea6e162c73382ba470a306ce2852dbff3d1314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153202
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c9cf554b1f6ecee001c49a3963333fdf48854bb9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fe8a94e99b738bcfe5f36ac999349f9436ef769d
          - tdf#155875 Tabbed UI commands Writer in Help pages
            
            + refactoring
            + Writer View menu (part 6)
            
            Change-Id: I422906f06158e5dcc49b81cf1ef5f108d24dbf95
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153201
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c7430a1deb75f49f2119cff3761035c9530064b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77b1451f125ef99c9fb1a017e27f75120d6f1842
          - tdf#155875 Tabbed UI commands Writer in Help pages
            
            + refactoring
            + Writer View menu (part 5)
            
            Change-Id: I23f49b7a283f53c97725da23f27fab8e6d944fef
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153195
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c6210eb78b26bd9d69c7cf469bcd657a1a40948c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ea5863372e39437174ea1403ef30092013248df0
          - tdf#155875 Tabbed UI commands Writer in Help pages
            
            + refactoring
            + Writer View menu (part 4)
            
            Change-Id: Id3282f560d57a7934a7e54a7c6afe378b6e55b4c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153194
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2fa7d4a88061a599b0ee29ac94c2515c9fdafc79]

        oox, writerfilter, xmloff: use frozen data structures for static data
        
        Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153175
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [215454b5f9327093608aba5fc08ef1c27bf019df]

        svgio: use "frozen" for mapping between token strings and enums
        
        Change-Id: I2061606146cfcb34169dccf69b6f720727839d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153174
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [472fec1b45db7cad7d9e87426a6e8c216174f9f7]

        Add frozen library support - for compile-time dict, set support
        
        Change-Id: I8fa02569ba02048cc3ef02b349aafba1c0cbebb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153173
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-17  Dennis Francis  <dennis.francis@collabora.com>  [447a4bcac071840e5dd19cdaaefc6897d5d19cbe]

        sc: perf: speedup sheets with lots of repetitive...
        
        row styles using a small cache of already allocated patterns that are
        tied to extended format id and number format id.
        
        Change-Id: I3136aef9a034635924f7b7b6d2432f9ae5c2bd15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152692
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 92b13ad1f1a87393cf66a35694f3e542db57f150)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152874
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [d27aac755a58f1c7cd32cb0a0a2a4a5cffd63b4c]

        improve exception message
        
        the colon here made me think a piece had been chopped off.
        
        Change-Id: I1e0f0ef9c16e0fd8f7619a3d8e58e8e0886fda9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153192
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2d290fa917fec68050a930c6297e794b5785244]

        SAL_WARN->SAL_INFO in SdXMLStylesContext::CreateStyleChildContext
        
        This is not an error - this method handles elements if it knows about
        them, and otherwise leaves the elements for other code to handle
        
        Change-Id: I531a2d9aff84ef4a2762923737a6b827e88cd920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153191
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-17  Henry Castro  <hcastro@collabora.com>  [9e2d4e9b43cb835c0fb2783374a1f2666807984c]

        sc: filter: oox: only insert conditional format if has items
        
        Otherwise, the empty conditional format will exists.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I99d83bd50ce4c12ef9be6924cba31b8847c0ad07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149720
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151978
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153200
        Tested-by: Jenkins

2023-06-17  Justin Luth  <jluth@mail.com>  [506db23af4da2c5c8775fb0fd6fb9b8668e2fe86]

        tdf#118335 notebookbar: set visible false for PrintPreview in MenuFile
        
        The label for "Print Preview" comes from ContextLabel in
        these menus - and it displays "Close Preview" even if
        the print preview is not active.
        
        The PrintPreview buttons in the notebookbar ribbon itself work fine.
        
        So just hide the menu ones for now.
        Perhaps that is not good for accessibility,
        but I would imagine accessibility people would
        stick with the traditional menu anyway,
        since the notebookbar is also horrendous
        in many other ways for accessiblity.
        
        The user can turn this back on again if they want.
        Customize - Notebookbar - File Tab | File | Menu File
        
        Change-Id: I807941650295132c9e15f04094cece26246318d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153199
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-16  Henry Castro  <hcastro@collabora.com>  [56095552d34180260113d4c990401eb279395a5a]

        sc: filter: oxx: insert more rules same range
        
        If there are rules with the same range to preserve
        priority order.
        
        <conditionalFormatting sqref="I4:I5">
         <cfRule type="cellIs" dxfId="5587" priority="1500" operator="equal">
          <formula>"GO"</formula>
         </cfRule>
        </conditionalFormatting>
        <conditionalFormatting sqref="E11:I12 E15:I16">
         <cfRule type="containsText" dxfId="5586" priority="1457" operator="containsText" text="R">
          <formula>NOT(ISERROR(SEARCH("R",E11)))</formula>
         </cfRule>
        </conditionalFormatting>
        <conditionalFormatting sqref="I4:I5">
         <cfRule type="containsText" dxfId="5585" priority="1501" operator="containsText" text="R">
          <formula>NOT(ISERROR(SEARCH("R",E11)))</formula>
         </cfRule>
        </conditionalFormatting>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ibb98953f0a50140dbde4d52a79fde968095881d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150436
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153198
        Tested-by: Jenkins

2023-06-16  Henry Castro  <hcastro@collabora.com>  [7f733ff497a2ac1731229b3963602f1feb3ef88e]

        sc: filter: oox: fix conditional color scale same range
        
        Otherwise, the condition color scale the priority order will be lost.
        
        <conditionalFormatting sqref="G1:G5">
         <cfRule type="colorScale" priority="5">
          <colorScale>
           <cfvo type="min" val=""""/>
           <cfvo type="max" val=""""/>
           <color theme="5" tint="-0.249977111117893"/>
           <color rgb="FF92D050"/>
          </colorScale>
         </cfRule>
        </conditionalFormatting>
        
        <conditionalFormatting sqref="G1:G5">
         <cfRule type="colorScale" priority="1">
          <colorScale>
           <cfvo type="min" val=""""/>
           <cfvo type="max" val=""""/>
           <color theme="0" tint="0"/>
           <color theme="0" tint="0"/>
          </colorScale>
         </cfRule>
        </conditionalFormatting>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I33fa73bfe8f0bada1cf79bc07be2e43495a4290c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149721
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151979
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153182
        Tested-by: Jenkins

2023-06-16  Justin Luth  <jluth@mail.com>  [967c8db8e1ebee924b185b7476df712189e4e51b]

        tdf#132061: disable uno:PageColumnType when read-only
        
        When the document is read-only, it should not be able
        to be have the column information changed,
        so disable that toolboxControl, just like everything else.
        
        It was set to be active in READ-ONLY mode since initial import,
        but no indication why it should be different
        from the two other page actions added at the same time.
        
        It was added as part of adding the sidebar.
        However, I don't see where it would be found in the sidebar.
        It is not in the normal menus - just in the notebookbar.
        
        Change-Id: Icf342d5ee51cf8bba296049833e0e520813efb03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153193
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d231453fcc75c2c621522098fe1d42b14be546b]

        tdf#155735: unify unittest
        
        Change-Id: I8de80f869715d4476e62f526e0bb161de8274977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153181
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-16  Justin Luth  <jluth@mail.com>  [d2e7616c66812ab87828720c52f7e1ed975e00ba]

        sw uiconfig: add README to explain the different menus
        
        Inspired by tdf#126379, where a Master Document
        does not use the notebookbar UI - even though it is clearly Writer.
        So now I finally know what sglobal is for.
        
        I had been wanting this information for some time now.
        So I did a bit of experimenting and verified my information.
        (I'm not compiling with database support,
        so I couldn't prove those two, but what else could they be?)
        
        Change-Id: Ie1e7615a401c0c07168219dab3e9f02f9e33e996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153188
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-16  Szymon Kłos  <szymon.klos@collabora.com>  [97497ae3b402c83344c84ec70a34efbf57c7b62b]

        tdf#155720 remove old skip notebookbar init workaround
        
        This was introduced due to not working Paste Special dialog
        in LOK case. Now everything seems to be ok. Single initialization
        should make loading process faster.
        
        Change-Id: Ic464908ef044cc446626fff0fb9b4f57e061aea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153169
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [df98b6015cd2ae4f1573e12cee1b1bc947adabf0]

        tdf#155871: don't forget to close li before starting next
        
        When closing a nested list, the previous condition failed to close
        the last li in case when the next item is numbered (i.e., will need
        another li). Indeed, if the next item is unnumbered, current last
        li should stay open.
        
        Change-Id: Iad7d83d50d2f02d6bd1d046804b7e23b59f9ce8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153179
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ea00bc0aaa6543b3353d307c8ee399d56cc712dc]

        Fix typo
        
        Change-Id: I914d0d62b1807daddea042ced173195d115f31e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153186
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-16  Patrick Luby  <plubius@neooffice.org>  [b6299c9e56f70ebc124814f4001e149e7be298ad]

        tdf#146626 catch IndexOutOfBoundsException when fetching accessible children
        
        com::sun::star::accessibility::XAccessibleContext::getAccessibleChild()
        can throw an IndexOutOfBoundsException exception even when fetching with
        an index that is positive and less than the value returned by a call to
        the accessible context's getAccessibleChildCount() method so put every
        getAccessibleChild() call in a try/catch block.
        
        Note: this is actually expected behavior even though it is rare. For
        example, accessibility::AccessibleTextHelper_Impl::getAccessibleChild()
        uses the following code snippet to throw such an exception:
        
            if( 0 > i || i >= getAccessibleChildCount() ||
                GetTextForwarder().GetParagraphCount() <= i )
        
        In the case of tdf#146626, getAccessibleChildCount() returns 22 but
        getAccessibleChild(1) throws such an exception due to the last
        condition in the above code snippet.
        
        Change-Id: If974afb7b9178faa99b91dcd79eb5f169bbfe13e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153160
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [52c34f4e84c5125e2a3c72b57a3c4d30a593debd]

        Fix typo
        
        Change-Id: I05a77aedfed9ea8dffed134d6748151c88dc4c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153184
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-16  Venetia Furtado  <venetiarosita@gmail.com>  [8d52aac82344c0198a42ea104fb4fb9b157d8ea4]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I83c7405c61edd2c92ad624064326ba9c9e971313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153164
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [97eaf03625d5a0b8d3340b5495143d08a9707275]

        ofz#59859 Timeout
        
        an interesting finding, but we still want this fuzzer to generate
        documents that don't need tweaking to load in the normal office
        so enfore the xml detection rule
        
        Change-Id: Ie21f8f5d985b97068935fab6a6abfee8901b1b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-16  Michael Stahl  <michael.stahl@allotropia.de>  [aca32a55456aa4e907b216fb490b3c15d26c3d55]

        tdf#146547 sfx2: allow read-only documents to be modified
        
        This is particularly useful for a Writer document that contains a
        section that is set to be editable in a read-only document, so that the
        user is warned when closing such a document without saving it.
        
        Originally this check was added in commit
        27db57efc51487b3976fbf73df1868b8fb78d201 "CWS fwkbugfix05"
        "#i39869#: readonly docs should never become modified"
        but the actual problem there was that the read-only document was
        displayed in a wizard dialog, not in a document view, so let's instead
        check that the document is some kind of "internal" document.
        
        Also the dialog's Save button should do something, and since the
        document is read-only, a Save As dialog appears appropriate.
        
        Change-Id: I339cbe92a2c9eb74a1f5061246f921037a47f79c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153180
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-16  Satya  <skompella@opentext.com>  [4da11a5d39ccd9f59e326011d4de7ffee8a71d10]

        tdf#155736 replaced m_bStartTOC condition with a method IsInTOC()
        
        Modified IsInTOC() method and refactored usage of m_bStartTOC with IsInTOC() in the previous commit,but m_bStartTOC is still used at one place and now which is replacing with IsInTOC() to maintain consistency.
        
        Change-Id: I7fe50770741d68d9db35d74e138417728c2e3dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153165
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>

2023-06-16  Michael Stahl  <michael.stahl@allotropia.de>  [29f5742bc8ff36741baac5b71082b3daee70ac18]

        tdf#125154 i18npool,sw: fix group separators in numbers in formulas
        
        Commit 776f7e7463de3e97f3056712ee567f49a314829d changed cclass_Unicode
        to reject group separators in numbers by default, but users are
        complaining that the neat "5.000" numbers in their existing documents
        are now considered invalid.
        
        * in SwCalc, use GROUP_SEPARATOR_IN_NUMBER
        * in cclass_Unicode::parseText(), reject a group separator if it is not
          followed by at least 3 digits
        
        With this, a number from tdf#42518 "0.19" is still considered invalid,
        while "5.000" is now valid again.
        
        Change-Id: If86f2ed4c27be16f866d7f4cee00789344e9ee2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153047
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-16  Henry Castro  <hcastro@collabora.com>  [60086685c91dd5d356b492b34dac613a06639b3c]

        sc: filter: oox: fix conditional color scale empty value \"\"
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I115c3731db85267d115efd24739470bffaeace40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149718
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151976
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153178
        Tested-by: Jenkins

2023-06-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [42e156fd19659bead5eebd78c7bd6fd3d38901ad]

        remove dead code
        
        Change-Id: Ia8523e992b30ba8674ca88374906cb3c671df5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153126
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [e51b4fc8c278bfa0b0671bbdb0ab35346881ebb7]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: Idd27071c1200d6ced2c4f43e10310df786fbc8fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-16  László Németh  <nemeth@numbertext.org>  [4a40a42afc3ba551e6e58947fc2e44689979b629]

        tdf#155847 sw tracked table column: manage multiple changes
        
        In Manage Changes dialog window, group also redlines of
        multiple different column changes.
        
        Follow-up to commit cc52d895314dd7b67de916bd90ccbfa098e77419
        "tdf#155342 sw tracked table column: manage changes".
        
        Change-Id: I3c9e69bf554bc5b4ce9473f95fff5954228758bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153172
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-16  László Németh  <nemeth@numbertext.org>  [c5b1578784c7179bde458640d78e1384ef190a21]

        tdf#154521 sw navigator: allow to query selected bookmark via UNO
        
        If the hidden title of SwNavigatorPanel was emptied via UNO XPanel
        interface, store the name of the selected bookmark there. This allows
        to query the selected bookmark using UNO e.g. in add-ons, i.e. to
        disambiguate when multiple bookmarks are there on the selected text
        range.
        
        Note: this is a workaround because getDialog() of XPanel is not
        implemented for SwNavigatorPanel.
        
        Follow-up to commit c4a58634753a84b09f20f7271d6525a6656522d3
        "tdf#154545 sw Navigator: select & track nested bookmarks" and
        commit 6eb1d540a1e599aa4fe0a321eddb9cc22e0546d3
        "tdf#154521 sw Navigator: fix selection change event of bookmark".
        
        Change-Id: I94f79daf59516331155e0b36502821c769771207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153162
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-16  Regina Henschel  <rb.henschel@t-online.de>  [2b1b2a758cc4666c6cf6b147722223281dfe1f30]

        tdf#155852 same method for StepCount in OOXML as in rendering
        
        Rendering of stepped gradients uses a method that doesn't take the
        color from a cut point, but before or after respectively. For example,
        for StepCount 4, the colors at relative positions 0, 1/3, 2/3 and 1
        are used. So sections are 'start color', '1/3 color', '2/3 color' and
        'end color'. The output to OOXML now uses the same method. That way
        rendering in a produced pptx-file is the same as in the original
        odp-file. Since OOXML has nothing similar to StepCount, it is an export
        only problem.
        
        A second problem comes from the cuddle with StepCount in Gradient
        struct in API and FillStepCount in shape property set. The
        draw:gradient-stop-count attribute in ODF belongs to the graphic style
        of the shape. The gradient definition itself in the <draw:gradient>
        element has nothing about step count. When a file is opened, it can be
        that the StepCount component in the Gradient struct still has the
        default value 0, but the FillStepCount property has the correct value
        of the shape.
        
        The Gradient struct in the API should not have a component StepCount
        to be compatible with ODF. But the API is published and changing that
        struct is far-reaching in the code. So the fix here is not a general
        solution but solves the problem for export to OOXML by reading the
        FillStepCount property while exporting.
        
        Change-Id: Ie1cafe6bdda7c4d74b05f279f0d8212ff67ecc92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153154
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [c66afb209de6132deac8fee9425a351391edc89e]

        tdf#103064 Improve comment style usage detection
        
        With this patch the "Applied Styles" filter should list
        also styles used in comments.
        
        Change-Id: Ifcb716cb66a0d271ca3d7ce477e6299015310ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153163
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [4923ddf33292cafecb5e216a5bdaac5bbe5da869]

        tdf#103064 sw: enable the UI commands
        
        Change-Id: Ic3e5ab9df5386a1cad0801f7044e6148620aa3b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152643
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20e05507fa2d7d9cec485d14f382920edd6f2528]

        ofz#59854 Null-dereference WRITE
        
        Change-Id: Iedbf21248b7d75474ea325905569d192360380f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6faa71b93086dce838a2c80f8935df275955756d]

        Fix typo
        
        Change-Id: I774554c7945d5560e229d6c94e9efbafd77deeca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153106
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b8b5e1e4149c409f42b02c09a7e4ff720af9873e]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: I652f02f6f1f354e2dab4f0ca866e8499cd3c50f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-16  Miklos Vajna  <vmiklos@collabora.com>  [8925e5eda74128503c942bff240ccaae84e13e18]

        sw layout xml dump: extract SwTextFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about text frames.
        
        Change-Id: I2734e76ced3001de1fc1176d6315f8c69c02d8b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153152
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [6cb6f76095d2df07102ffd3da7accf7d075df90b]

        tdf#103064 sw: use the comment style by default instead of DF
        
        As part of that, language changes in the document's body are
        no longer applied to comments, as that would be a DF. Instead,
        the default language of comments is controlled via the style
        (see tdf#153805 for the use case).
        
        Change-Id: Icfa9a7334b52fe74292e82fa8daa01a15197e384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153158
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [6c4edf7f86912084371e15be7321e9c4764a9ca6]

        tdf#103064 sw,editeng: enable UNO API and ODF import/export
        
        Change-Id: Icf30e1f30fe6bf6a7d96d14b975954613cd68b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153157
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [d934aeace6e7049db3959421538ae382cb97b1d1]

        tdf#103064 sw,editeng: make para styles work inside comments
        
        - Style objects for comments are stored in a dedicated stylesheet pool,
        and constantly updated from the "real" styles using modification
        broadcasts. In theory, it should be possible to use same objects for
        both Writer core and EditEngine, as they use separate item ranges. But
        unfortunately SwDocStyleSheetPool isn't really a styles container, but
        just a wrapper around Writer's core styles, with a single mxStyleSheet
        member that is filled each time with data from different styles (while
        EditEngine expects different styles to be represented by different
        objects).
        
        - EditEngine switched to allow duplicate listeners for styles - one per
        paragraph. The use case is 2 paragraphs of the same style, and then one
        of them is switched to another style. In that case we still need to keep
        listening to the former style for the other paragraph. There is probably
        some opportunity for optimization, but it should be good enough for now.
        
        - Copying formatted text from document's body doesn't preserve style
        assignment for now. The editeng RTF import should be tweaked to not
        insert styles into our "special" stylesheet pool (or somehow forward
        them to Writer's core style handling) before we can enable this part.
        
        Change-Id: Ib67c5388f9cd078c73ec0d453017f815843161ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153156
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-16  Henry Castro  <hcastro@collabora.com>  [cc483a88a03f9ee847f3cb5fac83fb5dd49d0ba1]

        sc: filter: oox: do not insert rule too early
        
        The </cfRule> tag is a good place to do a post check
        the conditional format sanity.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Id6e99c81011040ec47034e993490fae5c71d7e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149719
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151977
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153159
        Tested-by: Jenkins

2023-06-15  Satya  <skompella@opentext.com>  [d7dd39e124f8a1fa199dd8322b642e8be04ed360]

        tdf#155736 Modified IsInTOC() to handle IsInHeaderFooter() case.
        
        This fixes a problem of page numbers missing in the footer.
        The importer might start processing the footer before the
        TOC has finished - m_bStartTOC might be true.
        In this case we are not actually IsInTOC,and m_bStartTOC
        should be ignored and make use of IsInHeaderFooter() and m_bStartTOCHeaderFooter to confirm if the footer/header itself
        has TOC.
        
        Change-Id: Ieede9f8e2120556630ba57b9c748935788f3cc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153052
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>

2023-06-15  Henry Castro  <hcastro@collabora.com>  [02ba31714a5f72495df203833ec9772b380b1b77]

        sc: qa: add databar unit test
        
        <x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0">
         <x14:cfvo type="num">
          <xm:f>0</xm:f>
         </x14:cfvo>
         <x14:cfvo type="num">
          <xm:f>1</xm:f>
         </x14:cfvo>
         <x14:fillColor rgb="FF63C384"/>
         <x14:borderColor rgb="FF63C384"/>
         <x14:negativeFillColor indexed="2"/>
         <x14:negativeBorderColor indexed="2"/>
         <x14:axisColor indexed="64"/>
        </x14:dataBar>
        
        Change-Id: Ib57dac07027e2c3c01ee556a3df791f49637be54
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149070
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153120
        Tested-by: Jenkins

2023-06-15  Maxim Monastirsky  <momonasmon@gmail.com>  [e229e13f9d5f1322986775399276f5503ebb83f7]

        tdf#103064 sw: improved notifications on style modification
        
        - More useful notification on undo
        - Added notifications for theme change and UNO API.
        
        Change-Id: I554dceff92f4f8a6dd5c39c6965b7de706ab6678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153110
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-15  Maxim Monastirsky  <momonasmon@gmail.com>  [9474ff4cc0abbd16f91ea582050c2332bdad88a3]

        tdf#103064 editeng: fix handling of char highlighting
        
        Transparency should be set to false if a color is present, but not
        with COL_TRANSPARENT. Compare with what is done for shape text in
        VclProcessor2D::RenderTextSimpleOrDecoratedPortionPrimitive2D.
        
        Change-Id: I5e4c8e53b53a363813ced50358c5ee795cdb61dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153107
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-15  Justin Luth  <jluth@mail.com>  [12f256cd1ae3e625c7b7f48987b7e843046924fa]

        tdf#133507 sw: hunt for documents with ULSpacing at section end
        
        When a paragraph style has "contextualspacing" with Spacing Above paragraph,
        and option "Don't add space between paragraphs of the same style,
        the spacing should apply after a section end.
        
        Contextual spacing was officially added to 1.3 spec in 7.0-ish timeframe:
        "The space between the paragraphs is zero,
        if all of the following conditions hold:
        ...
         The paragraphs belong to the same content area.
        ...
        
        Contextual spacing was actually added in LO 3.6,
        and it applies as expected when transitioning
        from one section to another.
        
        The missing case was when transitioning from a section
        back to the main body text.
        
        This was an implementation error. So the question is
        whether we add yet another compatibility flag
        to handle the old way of doing things,
        or just fix it.
        
        I'm leaning towards no compat flag because
        -it is a recent official addition to ODF
        -it is an implementation error
        -it currently is inconsistent - works on section start, but not end
        -rarely used: it is primarily an interoperability feature
        -rarely encountered: sections aren't really needed in LO.
        -no existing unit tests matched the condition.
        -interoperability isn't affected - section end == document end.
        
        This patch is hunting to prove some of the above points.
        -shouldn't hit any DOC/DOCX/RTF files.
        -only expect to find ODT files related to this bug report.
        
        So, I don't think a compat flag is warranted in this case.
        It is easy enough for a human to "fix" the document
        by removing the undesired "spacing before/after" settings.
        
        make CppunitTest_sw_odfexport2 \
            CPPUNIT_TEST_NAME=tdf133507_contextualSpacingSection
        
        Change-Id: Ia041741bbada8c2f4cd97aa6b7cd98d4d7ffb275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153033
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [183e1f9eef4840689e81bbf4d7734df2c7e63c5d]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: Ief35b1e3e08ed44c1b9161485a69ef504e1a1c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-15  Julien Nabet  <serval2412@yahoo.fr>  [11ac3528f46443cb1f790d0e9ac710cea27fc3a0]

        Related tdf#148263: on Writer, no need to repeat "Delete" for columns
        
        To reproduce the regression, just do this:
        - launch Writer
        - create a by default 2x2 table
        - select a cell
        - right click and take a look at sub-entries of Delete entry
        
        Change-Id: I05bf4824e0786f1b4ea73b24389d38858e01818e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153122
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-15  Maxim Monastirsky  <momonasmon@gmail.com>  [6e2c8f3f56ab52dfaa9bdce37423bac44cc64061]

        tdf#103064 sw: add a comment style
        
        Change-Id: I96acdf3200836efe1d66e19dd85000fca9e7a6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153109
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-15  Maxim Monastirsky  <momonasmon@gmail.com>  [c89d6d690ba4b48c235752a6193aa77d9ecb7384]

        tdf#103064 editeng: invalidate spelling results on style change
        
        Because a style might define a different langauge. This is
        similar to what we do for DF in SetAttribs/SetParaAttribs.
        See also alternative approach in SwLangHelper::SetLanguageStatus
        or SwAnnotationWin::SetLanguage.
        
        Change-Id: I38caa716ec95958580f4ce0ede70eff5d1024e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153108
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [e469a171833c2d88c4e129f339415c15a3a14b1e]

        wrap OSQLParser::s_xLocaleData in vcl::DeleteOnDeinit
        
        since my adaption of i18npool to use OUStringLiteral, this
        data structure might get torn down after the i18npool data is
        has pointers to.
        
        Change-Id: If83d232d5bfb003ed4dbfb70d47f707a73d2bcc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a253362f6d1e1909913dce298630c92d431e41e]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Here we trigger a problem - EditDLL has static data that tends
        to get torn down __after__ the i18npool shared library has been
        removed from memory, which means it tries to access OUStringLiteral
        objects that no longer exists.
        
        So use vcl::DeleteOnExit to explicitly clear that on application
        shutdown.
        
        Change-Id: Ie4bfcef7eb4656316ea825474ac42f85844d1dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7dfec21b44b23c4e52b938721f356f75046f37b]

        remove some misleading typedefs
        
        Change-Id: I8016c42c3ff8d1cf03c276ebbb68ae7872cd43fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-15  Michael Stahl  <michael.stahl@allotropia.de>  [5ab4fb27f4232fe0f36cfc079acb065d1712a355]

        tdf#155685 sw: ExtendedSelectAll with tables, group the Undo objects
        
        Change-Id: I2fba70968c97cd9704212cd799b333d2d158a042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153115
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-15  Michael Stahl  <michael.stahl@allotropia.de>  [4ef548a672658ab164e45e45ebd1b9f0b9282019]

        tdf#155685 sw: fix another ExtendedSelectAll Redo crash w table at end
        
        This can be reproduced with a table containing in the last cell a
        paragraph followed by a table, then ExtendedSelectAll in the cell and
        delete.
        
        On Redo of the SwUndoDelete:
        
          warn:legacy.osl:326138:326138:sw/source/core/frmedt/tblsel.cxx:1775: MakeSelUnions with pStart or pEnd not in CellFrame
          In function:
            const_reference std::vector<SwTableBox *>::operator[](size_type) const
            [_Tp = SwTableBox *, _Allocator = std::allocator<SwTableBox *>]
          Error: attempt to subscript container with out-of-bounds index 0, but
          container only holds 0 elements.
        
        The problem is that DelTable() calls PaMCorrAbs() with a target that is
        outside of the outer table, so the SwEditShell::DeleteSel() rPam has one
        end in the last table cell and other end outside the table.
        
        Change-Id: Ia2764a4c99ba12102957153e005284a44be04fd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153114
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-15  Julien Nabet  <serval2412@yahoo.fr>  [ea858ca92488309789e83666681a358af1d9f6f6]

        gdb: BigPtrArrayPrinter, add the suffix, so 0->0ul
        
        On pc Debian testing with GNU gdb (Debian 13.2-1) 13.2, I got this trying to debug tdf#131173
        
        Thread 1 "soffice.bin" hit Breakpoint 1, SwUndoTableMerge::UndoImpl (this=0x5599a0d302b0, rContext=...) at sw/source/core/undo/untbl.cxx:1878
        1878	        SwStartNode* pSttNd = rDoc.GetNodes().MakeTextSection( aIdx.GetNode(),
        (gdb) p rDoc.GetNodes()
        $1 = (SwNodes &) @0x5599a0477000: {<BigPtrArray> = BigPtrArray of length 18Python Exception <class 'gdb.error'>: No type named std::_Head_base<0, BlockInfo**, false>.
        , m_vIndices = 0x5599a04a4478, m_rMyDoc = @0x5599a0479590, m_pEndOfPostIts = 0x5599a04739b0, m_pEndOfInserts = 0x5599a042da70,
          m_pEndOfAutotext = 0x5599a04764b0, m_pEndOfRedlines = 0x5599a04765e0, m_pEndOfContent = std::unique_ptr<SwNode> = {get() = 0x5599a0478d20},
          m_aOutlineNodes = {<o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes, o3tl::find_unique, true>> = {m_vector = std::__debug::vector of length 0, capacity 0}, static npos = 18446744073709551615},
          m_bInNodesDel = false, m_bInDelUpdOutline = false}
        
        with the patch, I got:
        (gdb) p rDoc.GetNodes()
        $1 = (SwNodes &) @0x55c379492b10: {<BigPtrArray> = BigPtrArray of length 18 = {
        [   0] 0x55c37948c9a0            StartNode ,
        [   1] 0x55c3794859a0              EndNode ,
        [   2] 0x55c379492bb0            StartNode ,
        [   3] 0x55c37948a6c0              EndNode ,
        [   4] 0x55c3794925a0            StartNode ,
        [   5] 0x55c37948ff10              EndNode ,
        [   6] 0x55c379492630            StartNode ,
        [   7] 0x55c379490040              EndNode ,
        [   8] 0x55c3794926c0            StartNode ,
        [   9]  0x55c3795bd170           TableNode ,
        [  10]   0x55c379606280          StartNode ,
        [  11]    0x55c379616ee8          TextNode "",
        [  12]   0x55c37960cd70            EndNode ,
        [  13]  0x55c379612780             EndNode ,
        [  14]  0x55c3794b6628            TextNode "",
        [  15]  0x55c37962d848            TextNode "",
        [  16]  0x55c379616778            TextNode "",
        [  17] 0x55c37948fd20              EndNode }, m_vIndices = 0x55c3794bda68, m_rMyDoc = @0x55c379492f80, m_pEndOfPostIts = 0x55c3794859a0, m_pEndOfInserts = 0x55c37948a6c0, m_pEndOfAutotext = 0x55c37948ff10,
          m_pEndOfRedlines = 0x55c379490040, m_pEndOfContent = std::unique_ptr<SwNode> = {get() = 0x55c37948fd20}, m_aOutlineNodes = {<o3tl::sorted_vector<SwNode*, CompareSwOutlineNodes, o3tl::find_unique, true>> = {
              m_vector = std::__debug::vector of length 0, capacity 0}, static npos = 18446744073709551615}, m_bInNodesDel = false, m_bInDelUpdOutline = false}
        
        Change-Id: I492b49dd1a554dc95abb0ed97fa99541c8dbd7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153111
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-15  Khaled Hosny  <khaled@libreoffice.org>  [47e5264233adbf4c06076dae7474d7e175e684fa]

        Use sal_Int32 instead of overzealous use of auto
        
        Change-Id: Ia307f398260343fe388965673da42d9404195224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153117
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-15  Miklos Vajna  <vmiklos@collabora.com>  [8e307b8affbeb26555b25cf07a8a270a0447f6db]

        sw layout xml dump: show page frame of anchored objects
        
        It's useful to see if this is updated already or not when the object
        moves between pages.
        
        Change-Id: Iccad297585c04d77a95eb6cd31b65919470a97e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153102
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [7db19db341608ba2059543a3c8d61cd458470602]

        ODF export: simplify restart handling to skip list id where possible
        
        This continues to minimize cases where random ids are written, helping
        to make the output more deterministic; it builds upon commits
        8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced
        <text:list xml:id="...">, 2022-03-10), and
        82bbf63582bdf28e7918e58ebf6657a9144bc9f3 (tdf#155823: Improve the check
        if the list id is not required, 2023-06-14).
        
        The previous code used to write 'text:continue-list' when the list is
        restarted. It is unnecessary when there is no other condition requiring
        such a reference (like style change, or interleaving lists); so relax
        the conditions allowing to put simple 'text:continue-numbering="true"'.
        This also allows to simplify a bit the code around 'ShouldSkipListId'.
        
        Change-Id: Idf8be455953d08fd578266bda22f3a55d7b9ee23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153104
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-15  Julien Nabet  <serval2412@yahoo.fr>  [694c9da5076006275a10373e42a1c6ee4e0dbbeb]

        libjpeg-turbo is used for import but also export jpeg filter
        
        Change-Id: I257db8f1c59ff16d70751fe875594faa8e07e902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153002
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-15  Khaled Hosny  <khaled@libreoffice.org>  [198a1afe4d4c3c57a0cf6dc69c2494a2b9119751]

        tdf#155161: Add test
        
        The test document embeds Cantarell font because we don’t bundle any
        fonts with CFF2 table (or CFF table for that matter).
        
        Change-Id: Icdbab58ea3999baa75bc85fad60172218d9f6058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153054
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-15  Khaled Hosny  <khaled@libreoffice.org>  [845fbfcce9091e541bab657163b026aad8648261]

        Don’t add empty Fonts dictionary to Type 3 font resources
        
        If the Type 3 font does not use any other fonts, skip writing Fonts to
        its Resources dictionary.
        
        Change-Id: I1d0489debeb9f0e24022316551eb234b279381c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153100
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [88304309b57abe1e50395c5f71862fabcd1c752e]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: Iae879408d6761098d0e73526a65863d8f3cdb9ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [472d7ce57bdf1473538dda23c9328d44cdf816c8]

        tdf#155833: apply transform to image even if target is equal to viewbox
        
        Change-Id: Ie820528384d096c6a332e2abd0095f68c7f64a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153103
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-15  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [3f6bb9565d4edce563dbd938c655ae853926d362]

        nss: upgrade to release 3.90
        
        Change-Id: Ic446f33abd5355886b8c8c181a088c07ea4605c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153096
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [651d60f79c28c9a8e456817990c21a404c69d700]

        tdf#155699 - MRU: show pinned documents at the beginning of the list
        
        Change-Id: Id08678708ee74a4a278baa1e67930044f25e5d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152690
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-06-15  Miklos Vajna  <vmiklos@collabora.com>  [737d90b7b7cb03bb6128b74a32906b0391868830]

        sw floattable: fix handling of upper margin of anchor for fly intersect
        
        The bugdoc has 2 paragraphs and a shape between them. Word has a small
        amount of space between the shape and the 2nd paragraph, Writer has a
        large amount of space between the shape and the 2nd paragraph.
        
        It seems what happens is that Writer puts both the text node's own
        upper spacing and the previous text node's lower spacing into the upper
        spacing of the text frame, so the check added in commit
        d07fc485d46f431405a3f6a002f951a08c559677 (tdf#116486 Consider upper
        margin in paragraph positioning with flys, 2018-04-10) is not entirely
        correct, as it deal with both upper and lower margins, but its intention
        was just the upper margins.
        
        Fix the problem by (indirectly) using
        GetUpperSpaceAmountConsideredForPrevFrame(), which allows doing the
        intersection for the original text node upper spacing but not for the
        text node lower spacing. This keeps the original bugdoc working, but
        fixes the unexpected vertical space for the new bugdoc.
        
        This is part of the effort so that the original bnc#816603 bugdoc's DOCX
        version moves an overlapping floating table from page 4 back to page 3,
        like Word does. testTdf122878 is modified to just make sure no overlap
        happens, manual testing of the bugdoc shows that our layout still
        matches Word.
        
        Change-Id: I4622fb77dc8a52493766e50688ec92065eac65bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153101
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-15  Stephan Bergmann  <sbergman@redhat.com>  [977878814a3573627026e31edb8a51c8f30c8a0c]

        ooo#41037 Reject URLs containing unencoded NUL characters
        
        Change-Id: I45bbd342734f190ce918b610441ca911a47830b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153062
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-15  Luigi Iucci  <luigi.iucci@collabora.com>  [c183934835a6ab5e74643a671b65e9468592d216]

        sd: fix crash deleting 2 slides during paintTile
        
        pPageView was null in SdXImpressDocument::paintTile while trying
        to paint form controls, which is a corner case in most cases
        then we skip painting in order to avoid a crash
        
        Change-Id: I6c166035220c058fac276f2b7746a8ebc9651f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152379
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-15  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8b9d524008955f6f681d0bde8ef32d3cb3a83214]

        tdf#155728 - A11y sidebar: fix Update issue list after fixing an issue
        
        in case of SdrObjects.
        
        Change-Id: I45608d423c0da0f1a983dcfad43562c3d7c9ee67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152953
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-15  Miklos Vajna  <vmiklos@collabora.com>  [af95fedde797ccfa85f4b876867b57015aa8b382]

        UITest_manual_tests: use oneprocess mode
        
        Execution time goes from:
        
        real    0m42,203s
        
        to
        
        real    0m31,854s
        
        Also the same for UITest_pasteSpecial: 2m4,180s -> 1m39,375s
        
        Also the same for UITest_protect: 0m13,758s -> 0m12,817s
        
        Change-Id: I5fb00ca0c854e4078f7cae12dee507aa61da3770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153090
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [db75a6ecdd39f012fd1237da8169ece21f333b21]

        Fix typo
        
        Change-Id: Ieadd5121185e9c3a5258336e3bfece23c1efdc73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153067
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-15  Henry Castro  <hcastro@collabora.com>  [242de60455e0fc554bb9fb592f8f00d7e5edb918]

        sc: filter: oox: insert a new entry ScDataBarFormat if Id attribute...
        
        does not exist:
        
        <x14:cfRule type="dataBar" priority="1" id="{006000A4-0067-40D4-A5EF-00D900B80077}">
         <x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0">
          <x14:cfvo type="num">
           <xm:f>0</xm:f>
          </x14:cfvo>
          <x14:cfvo type="num">
           <xm:f>1</xm:f>
          </x14:cfvo>
          <x14:fillColor rgb="FF63C384"/>
          <x14:borderColor rgb="FF63C384"/>
          <x14:negativeFillColor indexed="2"/>
          <x14:negativeBorderColor indexed="2"/>
          <x14:axisColor indexed="64"/>
         </x14:dataBar>
        </x14:cfRule>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ie2c1ba2c85d9eead963f4d9b1684d72b64fe815d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149069
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153092
        Tested-by: Jenkins

2023-06-14  Paris Oplopoios  <paris.oplopoios@collabora.com>  [069c7dc4e9706b40ca12d83d83f90f41cec948f8]

        Add editengine view separation in tiled rendering
        
        Editengine now gets the background color from the current view instead
        from a global variable
        
        Change-Id: I98a0fccf4d0c83f4dabf8e534a9228b8a5e271d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152996
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        (cherry picked from commit 7baa475342b67c10537e11da37b8862648679b02)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153073
        Tested-by: Jenkins

2023-06-14  Regina Henschel  <rb.henschel@t-online.de>  [f3f64c77585d0c3c01c0d960f4959e18e9668c30]

        tdf155825 result same size in synchronize gradients
        
        While synchronizing color and transparency gradients two new sequences
        are generated. In case the last offsets where different, the remaining
        stops where not copied to the new sequence and thus they had different
        sizes which triggered an assert in oox/source/export/drawingml.cxx.
        
        Change-Id: I446f8cfafb23735f06ad4e05eee8c922141b864d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153063
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-14  Henry Castro  <hcastro@collabora.com>  [f16b722d7386b47fdc7afa5dfb21a948cb1a4969]

        sc: filter: oox: update databar format before clone
        
        The ScDataBarFormatData should update from import (finalizeImport)
        before cloning, otherwise it loose data.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I4af8b79e93eed8091bf01244bacac1d12e591c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149068
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153068
        Tested-by: Jenkins

2023-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [41bf4139cab36984cff514bfdd6b1b13576746a3]

        tdf#155735: Add support for saturate type
        
        Add getModifierName to BColorModifier class so when
        can assert which modifier is being used
        
        Change-Id: I2bc2a36470a449df4dc84a8440f232149c1f8278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153048
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b6474249caa697513affdbcb02c7a69fda8203be]

        cid#1532384 Out-of-bounds read
        
        sizeof returns num of bytes, not num of elements
        
        Change-Id: I9dea109e5f322d93ee10680f120b15554efa92e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [7c6c58197a84cf22789ca3dc97e863390c31a2f9]

        Related: tdf#150494 add placeholder text to the REST protocol field
        
        Change-Id: I8aab941d9dd03e54a3a39ccb643a5a628d6c5be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153061
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [51819767d341950dfd67448a6cbbf8c1add45f6c]

        online: speed up scrolling large excel document
        
        the expensive part is the GetTiledRenderingArea(), so lets only do that
        once, instead of twice
        
        Change-Id: I2d18bce1ff116d6d711f0908502963c9743dea8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153026
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b53aa7cb6284182c58056b376c1b57dd1414062]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: I95214d09938036935a45e8b8e9752596246dd2e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [f210fd9645258bac88a5fd1c0ffcf11ee428733b]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: Ia8186b2e6540287eae1312bf9755d5e6bea359c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [d900f60fa9f0a1772069cbe6e2536311393bff6d]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: I4aac81c9224971683cfc7c9085edc7dcd3ee5f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b61cfc01fdac9f7162c674e888ccf129c2433b4]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: I7d9b7bd923765b3fd37c4c45f4fd47add26beef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Henry Castro  <hcastro@collabora.com>  [7c2cfc26381dd31ab43e357eea7a3f5e63d3d6f4]

        sc: filter: oox: add missing formula if it is a text ...
        
        conditional format:
        
            <x14:cfRule type="containsText" priority="3" text="Done" id="{00730073-0059-47BC-840A-00E100CE00F2}">
              <xm:f>NOT(ISERROR(SEARCH("Done",C1)))</xm:f>
              <x14:dxf>
              <font>
               <color rgb="FF006100"/>
              </font>
              <fill>
               <patternFill patternType="solid">
                <fgColor rgb="FFC6EFCE"/>
                <bgColor rgb="FFC6EFCE"/>
               </patternFill>
              </fill>
             </x14:dxf>
            </x14:cfRule>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I4da117a1a122b3895788645dcd5de3e36cdcad0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149067
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153008
        Tested-by: Jenkins

2023-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [142aa77265361492e74707b08c5bcd366e7205ad]

        tdf#155690 writerfilter: fix import of bookmark in table...
        
        ... at start of section.
        
        (regression from commit 2e8aad6d45c53d554ccaf26de998ede708cfc289)
        
        Change-Id: I1e0e720758b607b69645b29c46f4092264289f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7b31137fee6b9c81bd88944f9dd08c9ad4620103]

        fix ant related test for paths with non-ascii characters
        
        autoconf forces LC_ALL=C and that in turn sets java's I/O encoding
        without a way to override separately
        (https://bugs.java.com/bugdatabase/view_bug.do?bug_id=4163515)
        and that breaks if the build/source path contains non-ascii characters:
        
        java.lang.ExceptionInInitializerError
          […]
        Caused by: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
          […]
        
        so set LC_ALL to $LANG for the ant/java tests to unbreak that part of
        the tests.
        
        Change-Id: I5bf197acd48610f1861904be027aa027e1d46024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138441
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>

2023-06-14  Khaled Hosny  <khaled@libreoffice.org>  [adc69b98197637b738f18d9a51d248e305247126]

        tdf#139863: Add test
        
        Change-Id: Ia3cb97203b71204688e8911668a274ac491af2bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153045
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-14  Khaled Hosny  <khaled@libreoffice.org>  [91b87ab5ed1d0c3eacf9bf295999bf1786beac34]

        tdf#89288: Add test
        
        Change-Id: Ia58dbd66016727fa61507dae0f4ac4044b959879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153042
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [82bbf63582bdf28e7918e58ebf6657a9144bc9f3]

        tdf#155823: Improve the check if the list id is not required
        
        The implementation introduced in commit 8f48f91009caa86d896f247059874242ed18bf39
        (SwNumRule::HasContinueList) was a bit naive: it assumed that maTextNodeList is
        sorted (it is not, and so, valid cases to avoid the id were missed); it assumed
        that a given list can only consist of items of a single numbering style, and so
        only tested the list of nodes referenced from maTextNodeList of given SwNumRule.
        I.e., this implementation targeted a special case of a list style fully covering
        a single continuous list.
        
        This skipped ids for list items with list styles, in which maTextNodeList passed
        the check in HasContinueList, but which were followed by items with a different
        list style, continuing the same list. This constellation outputs continue-list
        attribute in the following items (see XMLTextParagraphExport::exportListChange),
        which references the skipped id. The resulting ODF is an invalid XML (an xml:id
        is missing that is referenced), and also does not allow to continue such a list.
        
        The change tries to fix this, using a list of nodes in XMLTextParagraphExport,
        and analyzing if the list of the current paragraph has a continuation that needs
        to reference this list id. Two new hidden properties introduced in SwXParagraph
        and SwXTextDocument: "ODFExport_NodeIndex" and "ODFExport_ListNodes", resp. They
        allow to pipe the data to the export. The previous special casing of property
        state for "ListId", used in SwNumRule::HasContinueList, is removed together with
        the mentioned function.
        
        The intention is to have a logic allowing to detect 100% cases where the list id
        is required, and where it's not required.
        
        A related unit test for tdf#149668 was fixed to not rely on the mentioned ListId
        property state workaround, and moved from sw/qa/core/unocore to xmloff/qa/unit.
        
        Change-Id: If6a6ac7a3dfe0b2ea143229678a603875153eedb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153044
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed2ca47393d06786bc055c3c6fa7f84c0f952f14]

        fix ubscan build
        
        after
            commit ee76ed70e97448082f4c00c5c4207a44e1a91617
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 13 21:39:31 2023 +0200
            speed up startup time
        
        Change-Id: I577e2cccc9f17f417e7ae5ef0b8eaa5f90aed48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153041
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-06-14  Szymon Kłos  <szymon.klos@collabora.com>  [71075740aee2e15f574d19d452f0a586e25a6bd0]

        Make encodeForXml accessible for other modules
        
        and share similar code
        
        Change-Id: I7729a46d40845893f577c273c1ab340f69ebb51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151230
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151754
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-14  Paris Oplopoios  <paris.oplopoios@collabora.com>  [427769a751d3f45e41e5a0f4aed385bb2727998c]

        Remove duplicate constants relating to PNGs
        
        The PNG signature constant was defined in multiple places
        
        Change-Id: Ia90636819341295129a37a91199857a612d62177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153032
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [de9107b2b875aa485f2375300cc1ce2c16ffdf89]

        SAL_WARN->SAL_INFO in oox::ShapeContext
        
        Change-Id: Ifd5e1493a8bbe9954ca9420d03b7a2b1db3307f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8f020443fda691878ac05c47503169b390f34188]

        backport CVE-2023-1999 libwebp fix
        
        Change-Id: Idce341a78e44af9940d287d2a08b02d2ee9a6dae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153040
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-14  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4d4920899c10cf5d52dd62bd5b84d8e863fde2ea]

        ofz#59817 Heap-buffer-overflow READ 8
        
        Change-Id: I442d103c7103c0bd88dd7fdefd44c3274a9c80fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153038
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0ef3fed69864530da49cecb09fcc2fcc9acfeaa]

        tdf#151946 cache LocaleDataWrapper
        
        because it is a little more expensive these days to create it, since I
        made it an immutable type (which is also why we can safely cache it)
        
        Reduces load time from 7s to 1.5s for me
        
        Change-Id: I583381f0ee5494b8edf746b2329ac5751a9e5d86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153006
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Regina Henschel  <rb.henschel@t-online.de>  [0028c2311ca14669ca530cd4db422cd3cf9438ca]

        MCGR: Use BGradient in export of Fontwork to docx too
        
        Transparency values are not exactly like in UI because converting
        through rgb-color adds rounding inaccuracy. The unit tests are adjusted
        accordingly. With only start and end values it was possible to use the
        UI values directly. It would be possible to make special cases for
        front and back value, but I think it is not worth the effort.
        
        The previous solution had the error, that the stops were not mirrored
        in case of non linear gradient. That is corrected now. The unit tests
        are adjusted.
        
        The previous solution had assumed that our 'intensity' at start or end
        colors is the same as the 'lumMod' attribute in OOXML. However, this is
        not the case. So now the 'intensity' is incorporated into the color.
        Again, the unit tests are adjusted.
        
        Change-Id: Id02e455dc09d12c5b453637fcb2bdc4f8f1529d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152839
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [667c7ea976fab4691660844560eb2dcc7ecbbd19]

        Fix typo
        
        Change-Id: I042c738e5d6e037a8c658a02cbfaef8f1d23799e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152999
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee76ed70e97448082f4c00c5c4207a44e1a91617]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: Iecc822169a2fcd2f4678e4d6c303083c54a54456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3af9bd139458b534ae72e3e010c8725b826fd12c]

        speed up startup time
        
        by avoid conversion of static locale data from sal_Unicode to OUString
        data - we can declare the data as OUStringConstExpr arrays and then
        no conversion is necessary.
        
        Change-Id: I405806aef050e374b18a57cbf47e13a295821ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-14  Miklos Vajna  <vmiklos@collabora.com>  [4e06ba6e57d8f1166b6e54924a7228b5c85962ba]

        CppunitTest_sw_htmlexport: avoid reqif magic in testOleNodataReqIf
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I08acf610c2880f20fb7e06151566bc7725fb5357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152997
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d3f0a59f3c47095d4b1d8c01b1316a7dc7f5467d]

        tdf#155819: check marker property comes from a style sheet
        
        Since 242b7d0162d55be0945ca849c3de841fbf6cb475
        "svgio: simplify code" where bIsInStyleSheet was replaced by
        getCssStyleParent() incorrectly
        
        Change-Id: I48632e9374f4615e32d18a141aeabec2936e6ec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153031
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-14  Julien Nabet  <serval2412@yahoo.fr>  [a2eb4bcf2363c13af81e4c53710c2703158130bf]

        Fix heap-buffer-overflow in vcl/PngImageReader
        
        From Jenkins_Linux_Ubsan:
        25488         ==1050==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030001a44a4 at pc 0x0000004b6b04 bp 0x7ffed00d4630 sp 0x7ffed00d3de0
        25489         WRITE of size 24 at 0x6030001a44a4 thread T0
        25490             #0 0x4b6b03 in __asan_memcpy /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22
        25491             #1 0x7f3dab812b94 in SvStream::ReadBytes(void*, unsigned long) /tools/source/stream/stream.cxx:1134:17
        25492             #2 0x7f3da1fc7a8a in (anonymous namespace)::getImportantChunks(SvStream&, SvStream&, unsigned int, unsigned int) /vcl/source/filter/png/PngImageReader.cxx:270:27
        25493             #3 0x7f3da1fb7364 in (anonymous namespace)::reader(SvStream&, Graphic&, GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &(Bitmap::AcquireWriteAccess())>*, vcl::ScopedBitmapAccess<BitmapWriteAccess, AlphaMask, &(AlphaMask::AcquireAlphaWriteAccess())>*) /vcl/source/filter/png/PngImageReader.cxx:714:13
        25494             #4 0x7f3da1fb9663 in vcl::PngImageReader::read(Graphic&) /vcl/source/filter/png/PngImageReader.cxx:830:55
        25495             #5 0x7f3d8299c092 in PngFilterTest::testApng() /vcl/qa/cppunit/png/PngFilterTest.cxx:380:32
        ...
        since bf944e33569e4a1d6236a54671b7320cdc6ffaf6
        tdf#104877 Add basic APNG format support
        
        Change-Id: Ib46637a8422e1fbb1ab84ee69bf6f95299dd84a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153003
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-14  Stephan Bergmann  <sbergman@redhat.com>  [0408e5344b5c43bc3384c264588e1d49770fd2dc]

        external/coinmap: Address ODR violations
        
        ...since 2193650b3373ee1889961cfb72d1fe97f73e2c23 "external/coinmp: Update to
        CoinMP 1.8.4", as reported by <https://ci.libreoffice.org/job/lo_ubsan/2805/>,
        
        > ==25531==ERROR: AddressSanitizer: odr-violation (0x7f3df9756e40):
        >   [1] size=4 'CbcOrClpEnvironmentIndex' /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/coinmp/Clp/src/CbcOrClpParam.cpp:1236:5
        >   [2] size=4 'CbcOrClpEnvironmentIndex' CbcOrClpParam.cpp:1236:5
        > These globals were registered at these points:
        >   [1]:
        >     #0 0x43e508 in __asan_register_globals.part.13 /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360
        >     #1 0x7f3df9252a6b in asan.module_ctor (/instdir/program/libCbcSolver.so.3+0x21fa6b)
        > LLVMSymbolizer: error reading file: No such file or directory
        >     #2 0x7ffda20d8279  ([stack]+0x32279)
        >
        >   [2]:
        >     #0 0x43e508 in __asan_register_globals.part.13 /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_globals.cpp:360
        >     #1 0x7f3df4973a4b in asan.module_ctor (/instdir/program/libClpSolver.so.1+0x127a4b)
        >     #2 0x7ffda20d8279  ([stack]+0x32279)
        
        and similarly for CbcOrClpRead_mode and CbcOrClpReadCommand.
        
        There's code using those three extern variables in both libCbcSolver.so.3 and
        libClpSolver.so.1, and some of it is duplicated (in
        workdir/UnpackedTarball/coinmp/Clp/src/CbcOrClpParam.cpp, which is also included
        from workdir/UnpackedTarball/coinmp/Cbc/src/CbcCbcParam.cpp).  Those libraries
        do not appear to make any use of symbol visibility hiding, and it is completely
        unclear to me how all that code is actually meant to work.  But it also smells
        like all that code is only used within standalone programs (see main in
        workdir/UnpackedTarball/coinmp/Cbc/src/CoinSolve.cpp and
        workdir/UnpackedTarball/coinmp/Clp/src/ClpMain.cpp).  So lets try to get away
        with properly sharing those three extern variables across those two libraries.
        Except on Windows, where linking the one library wouldn't find the extern
        variables from the other library (and I'm not sure whether that's a general
        issue on Windows, or is due to how 2193650b3373ee1889961cfb72d1fe97f73e2c23
        modified external/coinmp/windows.build.patch.1).
        
        (This also appears to be fixed on recent upstream;
        <https://github.com/coin-or/Cbc> no longer mentions any of those three extern
        variables.  Maybe a new tarball will eventually appear at
        <http://www.coin-or.org/download/source/CoinMP/> that includes a proper fix of
        these ODR violations.)
        
        Change-Id: I953c7dc31f8e35315c59dc2bedd3fdf780579638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153001
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-14  Jim Raykowski  <raykowj@gmail.com>  [ec60d354359067f8c5c686ef2239ee705916de43]

        SdNavigator: Improve unique name detection
        
        Commit ace75043781b5fe36546ec75574a14617f4feb30 added the ability to
        rename page and object names from the Navigator. An approach that
        searches entry names in the tree was used to check for unique naming.
        This does not guarantee uniquess as the name may already be used
        for an object in another view, for example, Notes view. This
        patch guarantees name uniqueness by checking the document model to
        see if an object with the name already exists.
        
        Change-Id: Iad419420d6010b94380c55b7dc71a8d4abbec784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152843
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-06-14  Paris Oplopoios  <paris.oplopoios@collabora.com>  [63627c174778f7d435a540c43ec0498c76e739ab]

        Remove hardcoded values in pagenumberdlg
        
        Removed hardcoded text width/heights and margins in pagenumberdlg to
        create the preview image and also added a different text preview for
        IncludePageTotal mode
        
        Change-Id: Ib4f4f9ba702f87babf13c1435dc3845add1f43cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153030
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5e9eaaf6f298bced76ddef7bc37efcd75a224520]

        svgio: remove unneeded initializer
        
        Added in b1d1a424a4d291873101f5d2348e5bd9cb9091a4
        "tdf#155735: Add basic support for feColorMatrix"
        Change-Id: I6217c15702f0c0338a6aef5d08c755441d2bfaf8
        
        Change-Id: I5673e2243dec6f9ec195622178be34f4fc25b734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152966
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [6b178c6e88ec5a765ad2b3ccd98182286222f550]

        tdf#153440: Add test
        
        Change-Id: I0c036cd1d8022e6ff265aa67ab177c57eba0c4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152934
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-13  Henry Castro  <hcastro@collabora.com>  [3d4c4a95c32ad2a96831c3db552b0c389c596aea]

        sc: filter: oox: Add a missing tag child of the parent tag "cfvo"
        
        <x14:dataBar maxLength="100" minLength="0" border="1" axisPosition="automatic" direction="context" negativeBarBorderColorSameAsPositive="0">
         <x14:cfvo type="num">
          <xm:f>0</xm:f>
         </x14:cfvo>
         <x14:cfvo type="num">
          <xm:f>1</xm:f>
         </x14:cfvo>
         <x14:fillColor rgb="FF63C384"/>
         <x14:borderColor rgb="FF63C384"/>
         <x14:negativeFillColor indexed="2"/>
         <x14:negativeBorderColor indexed="2"/>
         <x14:axisColor indexed="64"/>
        </x14:dataBar>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ie98507e11a5cdeb0d1adc77a44fd79edb2f26d6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149066
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152998
        Tested-by: Jenkins

2023-06-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [79a96ca0083cdb692bce90d06dd2f51e1bfbdd90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f252a686b4231cfcd3e00756b1a59509aa3ae407
          - Fix typo
            
            Change-Id: Id2a262225d6f9029dc706c309ddcf308fa55ee62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153000
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [76d5bf35a618dc8f7f268ec5cd40e546a4d48e17]

        cid#1532367 Unused value
        
        Within the loop nPrevRowChange is not read after it is set
        and nPrevRowChange is always set to nRowChange at the end of
        the loop. There is no continue within the loop, so it looks
        like there is no point changing nPrevRowChange as it will be
        overwritten with nRowChange in any case.
        
        probably this is the case since:
        
        commit cc52d895314dd7b67de916bd90ccbfa098e77419
        Date:   Wed Jun 7 16:53:42 2023 +0200
        
            tdf#155342 sw tracked table column: manage changes
        
        Change-Id: Ib7cf2da23a7553bdeea13862cf4f67248bc829a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152994
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Henry Castro  <hcastro@collabora.com>  [77a1441aaaa0c3faffb2e2b78c039a989987b0a8]

        sc: filter: oox: add missing attribute "indexed"
        
        <x14:dataBar maxLength="100" minLength="0" axisPosition="automatic" direction="context" gradient="0" negativeBarBorderColorSameAsPositive="0">
         <x14:cfvo type="autoMin"/>
         <x14:cfvo type="autoMax"/>
         <x14:fillColor rgb="FF638EC6"/>
         <x14:negativeFillColor indexed="2"/>
         <x14:axisColor indexed="64"/>
        </x14:dataBar>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If7f6c8c902e4cd0d775f1014acad3dcd19f13f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149065
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152968
        Tested-by: Jenkins

2023-06-13  Henry Castro  <hcastro@collabora.com>  [aebf004ae72e914540526269499bae27f39e04bf]

        sc: filter: oox: add missing tag "fillcolor"
        
        To fill the positive color of the conditional format data bar:
        
        <x14:dataBar maxLength="100" minLength="0" axisPosition="automatic" direction="context" gradient="0" negativeBarBorderColorSameAsPositive="0">
         <x14:cfvo type="autoMin"/>
         <x14:cfvo type="autoMax"/>
         <x14:fillColor rgb="FF638EC6"/>
         <x14:negativeFillColor indexed="2"/>
         <x14:axisColor indexed="64"/>
        </x14:dataBar>
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I17e83a01affff292ff941d92f6ae59954aa246ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149064
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152965
        Tested-by: Jenkins

2023-06-13  László Németh  <nemeth@numbertext.org>  [3c1fee94e007a4c985572ec708bb60afa60f565d]

        tdf#155187 sw track changes: color tables in single changes
        
        In Show Changes mode, whole tables within a single redline,
        i.e. in a single text change get similar coloring, as in
        separately tracked table rows or columns.
        
        Follow-up to commit 48898a72066ff9982feafebb26708c4e779fd460
        "tdf#60382 sw xmloff: import/export tracked table/row deletion"
        and commit f348440e17debacbcba9153e238e010e8c020bdc
        "tdf#146120 sw: show tracked table changes with different color".
        
        Change-Id: I0154a20146cd6689750fa33edfe960eb22d7610a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152959
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [b416006052649ed69ef1dcd711187c860353a0db]

        When adding application fonts, add them also to FontConfig
        
        This way FontConfig can use them for missing chars font fallback.
        
        Change-Id: I63be8a62db9bdacc83be2327555c558d4cd476bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152954
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Miklos Vajna  <vmiklos@collabora.com>  [85f0a5d7bc54dfba75e8d6dd9c905bc1ac31d927]

        DOCX filter: improve handling of negative <w:position> in paragraph styles
        
        The bugdoc has a <w:position w:val="-1"> in its Normal paragraph style,
        which is almost not visible in Word, but we mapped this to default
        subscript text in Writer, leading to very visible bad font height in
        practice.
        
        The root of the problem is that <w:position> works with an absolute
        offset in half-points, while Writer works in percentages, so the
        import/export code can only do a correct mapping in case the font size
        is known. This initial mapping was added in commit
        e70df84352d3670508a4666c97df44f82c1ce934 (try somewhat harder to read
        w:position (bnc#773061), 2012-08-07), and later commit
        d71cf6390a89ea6a4fab724e3a7996f28ca33661 (tdf#99602 writerfilter: import
        subscript into character style, 2019-10-04) gave up on this for
        character styles.
        
        Fix the problem by working with paragraph styles similar to what the
        binary DOC filter already does, just assuming that the font height from
        the style won't be overwritten, or will be overwritten together with a
        matching <w:position>. Do this only for negative <w:position> for now,
        as that's good enough for our needs. Do the opposite of this at export
        time.
        
        It would be still possible in the future to add native handling for
        absolute escapements, and then this mapping would not be needed at all.
        
        Change-Id: I771c7bed27fa2596153aa77c472c91b819fa4cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152962
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d18b5af883bb6b56e758801ee730a08bb88a8f5]

        speed up rendering annotatins, cache meta height
        
        shaves 2% off scrolling profile on a large word doc
        
        Change-Id: I283e3f99c1c385f3d20ea573d15ca59b4629c14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0ea5dde060df7ef638fbd1f2efe6aa221033e69c]

        cid#1532379 Untrusted loop bound
        
        and
        
        cid#1532378 Untrusted loop bound
        
        Change-Id: I06f9267f02a6f41559d617c1a43671d4a8234350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152964
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f412c1e448b0268294ccbccee4f3a6a9e76a7b98]

        cid#1532377 Dereference before null check
        
        Change-Id: Ie85e81cea63578413db2c69020dae6a105466cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152963
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Dr. David Alan Gilbert  <dave@treblig.org>  [c437ccaab235320995af8c272705ac7c01784dd8]

        tdf#147021: sc/source/filter SAL_N_ELEMENTS usage
        
        Two blocks that just use SAL_N_ELEMENTS in a form:
        
          func(array, array+SAL_N_ELEMENTS(array))
        
        just use std::end for the end of it; I'm not seeing an easier
        way to pass the whole array in one.
        
        Change-Id: I1a229d735385cad6d3d4d7c48a6841906f3a8150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152807
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Dr. David Alan Gilbert  <dave@treblig.org>  [880bc4255099132557fe8d7d36a50c06f05cf5a1]

        tdf#147021: vcl/* KeyboardReplacements SAL_N_ELEMENTS removal
        
        A couple more tables using SAL_N_ELEMENTS.
        (I do wonder why these are separate).
        Note, I've not attacked the 'for' use of SAL_N_ELEMENTS in these files
        since they require some separate thinking about their indexing.
        
        Change-Id: I7fe66510fce7d59bda34b1f22417a2fb6070b065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152775
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Dr. David Alan Gilbert  <dave@treblig.org>  [9bc3c4fa8d380bd7ae5689692cc80f815bed4707]

        tdf#147021: sw/source use std::size() instead of SAL_N_ELEMENTS
        
        Three big chunks of repeated use of SAL_N_ELEMENTS.
        
        Change-Id: I1250b22a4bfadb4868382b996208f40c32235268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  Michael Stahl  <michael.stahl@allotropia.de>  [889c12e98e04edb4bc25b86bf16b8cf1d9b68420]

        tdf#155794 vcl: handle WM_GETOBJECT without SolarMutex
        
        SalFrameWndProc() handles WM_GETOBJECT by acquiring SolarMutex and
        calling ImplHandleGetObject(), which again acquires the SolarMutex
        inside Application::SetSettings().
        
        This was introduced with commit db214684057e3ff2fa32d57c00507309dd6c24d6
        due to thread-safety crashes but it turns out that it can be problematic.
        
        When loading a document on a non-main thread, WinSalFrame::SetTitle()
        calls SetWindowTextW which is equivalent to SendMessage(WM_SETTEXT),
        while holding SolarMutex, and if the main thread doesn't finish
        processing it then that's a deadlock.
        
        Typically Desktop::Main() has already created the mxAccessBridge, so
        ImplHandleGetObject() most likely doesn't need to do it, so just skip
        the Settings code there in case the SolarMutex is locked by another
        thread.
        
        In case the SolarMutex is locked by another thread, do an unsafe read of
        ImplGetSVData()->mxAccessBridge - this should work until ImplSVData is
        deleted, by which time no Windows should exist anymore that could be
        receiving messages.
        
        This fixes part of the problem, winaccessibility also needs to stop
        using SolarMutex.
        
        Change-Id: I62b027ad06d2c3eb06a5f64b052a4acd0908f79c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152958
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-13  Michael Stahl  <michael.stahl@allotropia.de>  [ac1099443e70eefbd8fdd7dd3705fff08a9c75b8]

        tdf#155794 winaccessibility: no SolarMutex in getAccObjectPtr()
        
        MSAAServiceImpl::getAccObjectPtr() is called when processing
        WM_GETOBJECT messages, and this can happen (at least when NVDA is
        active) during processing SendMessages.
        
        When loading a document on a non-main thread, WinSalFrame::SetTitle()
        calls SetWindowTextW which is equivalent to SendMessage(WM_SETTEXT),
        while holding SolarMutex, and if the main thread doesn't finish
        processing it then that's a deadlock.
        
        Introduce a new mutex in AccObjectWinManager and use it to guard the 2
        members that getAccObjectPtr() reads, while keeping the rest of
        winaccessibility with the SolarMutex, as the UNO services may be called
        on any thread.
        
        This fixes part of the problem, VCL also needs to stop using SolarMutex.
        
        Change-Id: I6df5889fd76f59146b4b0b1e5f4513232f8ab867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152957
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [cbb215aa20783523555185c83875ea5d5b94535b]

        tdf#143877 Fix failing tests caused by floating point precision
        
        Due to different imlementation of floating-point unit (FPU),
        on different CPU platforms, the floating point numbers could
        could be different.
        https://stackoverflow.com/questions/64036879/differing-floating-point-calculation-results-between-x86-64-and-armv8-2-a
        https://mcuoneclipse.com/2019/03/29/be-aware-floating-point-operations-on-arm-cortex-m4f/
        
        With this path I have changed the tested images,
        to use floating point numbers which are easily represented
        by floating numbers (multiplied/divided by 2), like:
         - change tension to values: 0.125, 0.25, 0.5, 1.0, 1.5 ...
         - change position of curve to of control points to 256.0, 384.0 512.0
        
        Previous values was hard to represent by floating numbers,
        for example tension:
        - 0.4 has been written as 0.399999976158142
        - 0.1 has been written as 0.099999994039535
        
        More information:
        https://observablehq.com/@benaubin/floating-point
        
        Additionally the precision of numbers were
        increased to double.
        
        Change-Id: I5725c1f2f474d0c00821edaa9bb2102cb172093f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152838
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-06-13  Laurent Balland  <laurent.balland@mailo.fr>  [3e3d6aeec92a7252d92243e2de34b424cf5f7cdf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8a5edeadd66edfc0fb0747ba7f1251da1b2597c
          - tdf#154131 Detect numbers in scientfic notation
            
            Add a new option to CSV params
            Add help to dialog
            
            Change-Id: If812698a5083cc19431d6de6c2439d2879baa1f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152407
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [40fb6f95bbe8a80e71a318c1a843ba6772ad9ab5]

        external/curl: fix URL in README.
        
        The current URL of the curl project's website is https://curl.se/.
        
        Change-Id: Ibbbd2b0c8b6616bd1f59af06f2a41f62674d3bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152939
        Tested-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2023-06-13  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bd4d9056cbc40af6b097727d3649ff1e5da09a53]

        turn off undo while creating SdrGrafObj in svg export filter
        
        otherwise in the SdrGrafObj ctor onGraphicChanged is called
        which can put us into the undo stack. presumably as we haven't finished
        constructing yet the ref count isn't right
        
        ==20597==ERROR: AddressSanitizer: heap-use-after-free
        instdir/program/libmergedlo.so
        	SdrObject::SetTitle(rtl::OUString const&)
        		libreoffice/svx/source/svdraw/svdobj.cxx:811
        instdir/program/libmergedlo.so
        	SdrGrafObj::onGraphicChanged()
        		libreoffice/svx/source/svdraw/svdograf.cxx:172
        instdir/program/libmergedlo.so
        	SdrGrafObj
        		libreoffice/svx/source/svdraw/svdograf.cxx:272
        instdir/program/../program/libsvgfilterlo.so
        	SVGFilter::implExportWriterTextGraphic(com::sun::star::uno::Reference<com::sun::star::view::XSelectionSupplier> const&)
        		libreoffice/filter/source/svg/svgexport.cxx:863
        instdir/program/../program/libsvgfilterlo.so
        	SVGFilter::filterWriterOrCalc(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        		libreoffice/filter/source/svg/svgfilter.cxx:590
        instdir/program/../program/libsvgfilterlo.so
        	SVGFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        		libreoffice/filter/source/svg/svgfilter.cxx:135
        instdir/program/libmergedlo.so
        	SfxObjectShell::ExportTo(SfxMedium&)
        		libreoffice/sfx2/source/doc/objstor.cxx:2494
        
        freed by thread T0 here:
        instdir/program/libmergedlo.so
        	~SdrUndoObj
        		libreoffice/svx/source/svdraw/svdundo.cxx:203
        
        previously allocated by thread T0 here:
        instdir/program/libuno_sal.so.3
        	rtl_allocateMemory
        		libreoffice/sal/rtl/alloc_global.cxx:38
        instdir/program/../program/libsvgfilterlo.so
        	cppu::OWeakObject::operator new(unsigned long)
        		libreoffice/include/cppuhelper/weak.hxx:89
        instdir/program/../program/libsvgfilterlo.so
        	SVGFilter::filterWriterOrCalc(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        		libreoffice/filter/source/svg/svgfilter.cxx:590
        instdir/program/../program/libsvgfilterlo.so
        	SVGFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
        		libreoffice/filter/source/svg/svgfilter.cxx:135
        instdir/program/libmergedlo.so
        	SfxObjectShell::ExportTo(SfxMedium&)
        		libreoffice/sfx2/source/doc/objstor.cxx:2494
        
        Change-Id: Ife225b4250fda53514110b176f35e5278d23f287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-13  buldi  <dobrakowskirafal@gmail.com>  [65a20a85c20ddc87d66445657404a46041bcf6e1]

        tdf#145538 Refactor to use range-based for-loop
        
        Change-Id: I7c75593fef6d3226011a938349850dc485b763c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148204
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-06-13  Miklos Vajna  <vmiklos@collabora.com>  [c374628126ad222be48d5d06857b7dc6b879f783]

        sw floattable: fix anchor position of inner floating table
        
        The bugdoc has an outer, split floating table and an inner, non-split
        floating table. The anchor of the inner table was wrong: both were
        anchored in the only paragraph in the body text, while the inner
        floating table should be anchored inside the outer floating table.
        
        The reason for this is commit 9592f56323de27f9e1d890ee6259a5f4f328cbd3
        (n#695479 fix anchor handling in SwXText::convertToTextFrame(),
        2012-02-20), which was necessary to make sure that old-style frames
        after each other are all anchored to the body text, not inside each
        other.
        
        Fix the problem by leaving the behavior unchanged for empty paragraphs,
        but at least when the inner anchor is to-para, the last paragraph of a fly
        content is non-empty and the outer fly range contains the entire last
        paragraph, then consider such a fly as "inside" the outer fly content,
        rather than something that has to be moved so the anchor is still in the
        body text.
        
        CppunitTest_sw_rtfimport's testN695479, CppunitTest_sw_ooxmlexport10's
        testFloatingTablesAnchor and CppunitTest_sw_ooxmlexport13's testFlyInFly
        are all related tests and they continue to work after this change.
        
        Change-Id: I30ed1d884ec465e724b4f133640b9608845a44fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152950
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [2137d04d1ddb80691c29de0df99fc2ba58820ce0]

        openssl: upgrade to release 3.0.9
        
        Fixes CVE-2023-1255, CVE-2023-2650 and 3 more CVEs that
        probably don't affect LibreOffice.
        
        Change-Id: Ic615b008298471267121a0f4deb227ddb3a0409e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152851
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>

2023-06-13  Miklos Vajna  <vmiklos@collabora.com>  [d16606650621a1f9390091be5633772111b88584]

        sw: document SwFormatRowSplit
        
        It's the row equivalent of a table's SwFormatLayoutSplit.
        
        Change-Id: Ibf33df306d4d51ff8f8999b25b03693e1ebc5a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152930
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-13  Noel Grandin  <noelgrandin@gmail.com>  [f22cb3dfab413a2917cd810b8e1b8f644a016327]

        tdf#155376 weakly cache ScAccessibleCell
        
        the macOS accessibility framework repeatedly queries and enumerates
        all of the visible cells.
        Every time this happens we create a new set of ScAccessibleCell,
        which then live until the application shuts down, which then
        causes a very slow shutdown.
        
        So I fix the problem by caching the ScAccessibleCell so we return
        the same one for a given cell position.
        
        Of course, this begs the question of why the ScAccessibleCell
        objects are not dying when we create new ones, which means we have
        some kind of leak or lifecycle problem somewhere, but anyhow,
        this is a fairly simple and comprehensive fix.
        
        Change-Id: Id2765236ac4524f490a51b56268fb8038612fd43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152932
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [4ce43750e7878a813127bdc409d5251369d035f5]

        tdf#152048: Fix measuring text width with font fallback
        
        This is a regression from:
        
        commit 43a5400063b17ed4ba4cbb38bdf5da4a991f60e2
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Thu May 25 10:59:18 2023 +0300
        
            tdf#152048: Fix underline width for Kashida-justified text
        
        It fixed measuring width when there is Kashida justification, but broke
        it for font fallback, because of the way MultiSalLayout measures the
        text width takes the maximum of the text widths for all its layouts, but
        layouts with missing glyphs are now giving wrong text width as they are
        measuring the width of .notdef (GID 0) glyph.
        
        This change makes MultiSalLayout measure the text width by iterating
        over all its valid glyphs.
        
        Change-Id: I8b19e0d44326c6f0afe6e504ab6d90c6fb3575f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152933
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [507759b449415e897ac0a1de03e8dd685b1e50fe]

        tdf#152048: Add test
        
        Change-Id: I321e9f400b0d96b9c3193547f184342ce0c69f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152907
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [6bee2928861692ce8cd7894efc69a997759346c4]

        CppunitTest_vcl_text: use CPPUNIT_TEST_FIXTURE()
        
        Change-Id: Ia1264ea7c5c2208d97427568166c6b12c6d89179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152905
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-13  Khaled Hosny  <khaled@libreoffice.org>  [a44994674eb63d427d6624ed0fd9f0a289b72819]

        CppunitTest_vcl_text: use CPPUNIT_TEST_FIXTURE()
        
        Change-Id: I3e2f0c2de284d1187e3389387a4a1cc3f0d0896c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152904
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-13  Henry Castro  <hcastro@collabora.com>  [d4ee93a54e790acab470667591d61d424831e665]

        lok: sc: disable Value Highlighting
        
        If the document is saved with the option:
        
        View - Value Highlighting
        
        The online client side does not have implemented yet, otherwise
        will not paint the cell background.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I05b1a2ef63602a7bf34f717b87c304d00a8c8efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152019
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152938
        Tested-by: Jenkins

2023-06-12  Henry Castro  <hcastro@collabora.com>  [44362e588686e33ff60ddcb6c1cd0c6082073fb0]

        sc: fix freeze row/column panes
        
        The UNO command  state has changed to Point (row, tab)
        and Point (col, tab), Otherwise, if the row or column
        has the same value for all sheets, the state cache will
        not report any changes to the client side.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2080f5e664825d81c4fa4dbb2c5d782f188dae64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151344
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151975
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152908
        Tested-by: Jenkins

2023-06-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad97339a63929d6c63a31c60421eae8c236db529]

        tdf#154451 UITest_impress_tests: do not use oneprocess mode for now
        
        Jenkins started to fail more frequently after
        
        18cab645488184f1d861fb4e67aebb383f6e3779
        "tdf#154451 UITest_impress_tests{,2}: enable oneprocess mode"
        Let's see wether this improve the situation
        
        Change-Id: I4983cb8bb90808287e1c32d70e73ff2defbbcc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152903
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c5cde93cd4327f55fdd23e6230c2cb101192374d]

        tdf#155041 - A11Y sidebar: fix warning about missing form control description
        
        Add form control objects to "Go to" and "Fix" functions.
        In case of "Go to" a warning dialoge shows up if it is not in Design mode
        and ask to switch on Design mode or not.
        
        Change-Id: I79b6d67568e2ddfd121081d4c47ce7588f5d51b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152698
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-12  Henry Castro  <hcastro@collabora.com>  [e12e9960fb759f2155896a175b5d45754de58396]

        lok: sc: fix RTL auto fill rectangle
        
        In the RTL case, the positive X axis is changed from
        right to left, otherwise the auto fill rectangle overlay
        will get negative coordinates.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If4918f02d185fc19e5ab4e8a273c443c69dc7206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150034
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 27dc2814941423d202053cf65bbf755e403c6044)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150172
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152906
        Tested-by: Jenkins

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [061d6a280d17d18012a2f53e9870b5b2715bcef0]

        Resolves: tdf#155791 export of default impress slide master to svg failed
        
        Change-Id: Ie4ec64fef6d8c2c2844a01d06109ad9022714c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152902
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Henry Castro  <hcastro@collabora.com>  [5b35703d11089975d625fede2605ce3bc449b294]

        sd: lok: only register supported views
        
        The Presentation ViewShells:
        
        SlideSorter,
        Outline,
        Presentation
        
        They are not supported in tiled rendering case,
        so switch to default view.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I33b255e0ca530734af6490d14fe48a2512272afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147095
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152900
        Tested-by: Jenkins

2023-06-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [16ac8db5a078e23ece610e22ad1a4d314b555563]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7a92b48d34b3ca0b1b92abf3587f11cc5523cf59
          - update translations for 7.6/master
            
            and force-fix errors using pocheck
            
            Change-Id: I0bd4569353022758a9593acd89d212af24b7cef0
            
2023-06-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [15a88c00ef4b48009abff781d960c84d6d878ecc]

        sc: uitest: fix sporadic test failures
        
        Sometimes theses tests fail with
        
        ======================================================================
        FAIL: test_tdf153972 (tdf153972.tdf153972)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64_branch/sc/qa/uitest/autofilter2/tdf153972.py", line 37, in test_tdf153972
            self.assertEqual('Lime', get_state_as_dict(xSubMenu.getChild('0'))['Text'])
        AssertionError: 'Lime' != '#81D41A'
        - Lime
        + #81D41A
        
        ======================================================================
        FAIL: test_tdf95520 (tdf95520.tdf95520)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64_branch/sc/qa/uitest/autofilter2/tdf95520.py", line 36, in test_tdf95520
            self.assertEqual('Red', get_state_as_dict(xSubMenu.getChild('1'))['Text'])
        AssertionError: 'Red' != '#FF0000'
        - Red
        + #FF0000
        
        See https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil_branch/10807/consoleFull#4610001379567f988-cbcf-4519-af05-6000b834f13f
        
        and I believe the reason is the color palette fails to load in
        sc/source/ui/view/gridwin.cxx:752 and then its not able to
        translate #81D41A to Lime.
        Adapt the test and document to use colors without a color name
        
        Change-Id: Ie1119fe0ff31147b5395076969e41481706d8dfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152897
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b1b3c70f1f16f02a83e23d2b0265bc97b0188a11]

        cannot export selected fontwork in writer to svg
        
        Background property isn't supported
        
        Change-Id: Ic8c5ff979d16a328fece5b4b2f87c85348606bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [b7b83a5de26567c2f6b482b16c4adf3e4f391ca2]

        ofz#59762 Out-of-memory
        
        this one is a writable SvMemoryStream so Seek(Rel) will attempt to resize
        if the destination is outside the current size
        
        Change-Id: I1f29531979ced103c51bd423ea0d5665f2b5bdb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [64af1d49ed7e623fa991698a30110ee966608d1b]

        ofz#59759 Null-dereference READ
        
        since:
        
        commit bf944e33569e4a1d6236a54671b7320cdc6ffaf6
        Date:   Mon Feb 6 14:19:41 2023 +0200
        
            tdf#104877 Add basic APNG format support
        
        Change-Id: I45080e226f0ad4ccb99b6285c77ed19b702b74d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152893
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Paris Oplopoios  <paris.oplopoios@collabora.com>  [81e815edbf5b4694789aa1d7b9e3ecde08b08b21]

        tdf#153109 Use any_of instead of loop to check a range
        
        Change-Id: Icf65288a7e53257008129b71e8d716b0b0c7f5fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152868
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-12  Mike Kaganski  <mike.kaganski@collabora.com>  [cf0fe26f95b5435d65623165cf7ba381eaa0738a]

        tdf#154349: round before converting to an integer
        
        Commit cfff893b9c82843a90aac4ecdb3a3936721b74a0 (Move unit conversion
        code to o3tl, and unify on that in more places, 2021-02-14) changed a
        custom conversion code in CalcToUnit doing inexact conversion from
        points to mm/20 (with "* 10 / 567"), with correct conversion function.
        A side effect was, however, that the imprecise arithmetics provided
        floating-point values that rounded down to correct integers (or maybe
        it was all the chain of calculations down to this function), while
        the correctly converted values could round down to a smaller value.
        
        Fix this problem using rounding.
        
        Change-Id: I42e0d56b068832ef309f6b696f661642e62ddacb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152894
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-12  Justin Luth  <jluth@mail.com>  [db9d42f8ac4cb4669b79cf5f718f4013a1e81c31]

        tdf#154371 writerfilter outineNumbering: copy inherited listId
        
        LO has a unique heading numbering/chapter numbering/outline numbering
        that has no counterpart in DOCX world.
        One big gotcha is that styles do not inherit numbering that is
        defined by the chapter numbering. So any DOCX paragraph styles
        that inherit outlineLvl, listLvl, listId from a style that
        is assigned to chapter numbering needs to explicitly assign the value.
        
        One thing I am puzzled about is how the listLvl is being set.
        (Perhaps that is one setting that Chapter Numbering allows to inherit?
        But really hard to test because changing ANYTHING triggers all the code
        that ensures that no inheritance occurs/resets listLvl.)
        
        make CppunitTest_sw_ooxmlexport4 CPPUNIT_TEST_NAME=test_ClosingBrace
        
        Change-Id: Ia744b076a86291b06af474934b2f4f705744b8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152515
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-12  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [dc19ef0d42e89edffcc21795194eb1eeb5957d0f]

        curl: upgrade to release 8.1.2
        
        Fixes CVE-2023-28321, CVE-2023-28322, and 2 more CVEs that
        probably don't affect LibreOffice
        
        Change-Id: If8720ba3647216063bffc8678aa64dad9a317128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152809
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi  <20001722@ymail.ne.jp>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-12  Miklos Vajna  <vmiklos@collabora.com>  [423d09bd237ac92382d0f7ff451c5025320823e7]

        xmloff: prefix members of XMLNumberFormatAttributesExportHelper, ...
        
        ... XMLTextImportPropertyMapper, XMLTextShapeImportHelper and
        XMLTextShapeStyleContext.
        
        See tdf#94879 for motivation.
        
        Change-Id: I03e663811f3c7b0208c50a07806a4ba41e82ad29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152892
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-12  buldi  <dobrakowskirafal@gmail.com>  [aff52ed56af99c4f1fcf20efd6303d7653f39233]

        tdf#145538 Refactor to use range-based for-loop
        
        Change-Id: Idc64cae6deccbf62824eadef3a3b4dbb979cfd39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150737
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-06-12  Miklos Vajna  <vmiklos@collabora.com>  [b71a9bcc2e1b4541c14e8197b5b888ee92297a6e]

        sw floattable: import non-split inner floating tables from DOCX
        
        The last floating table from the bugdoc has an inner floating table.
        That inner floating table was imported as a normal table, which means
        that the content is on page 1 in Word, but it on 2 pages in Writer.
        
        Import of nested floating tables were disabled because the layout is not
        yet ready to handle nested split flys. But in case the inner table is
        not in a fly, then the table height is large enough that it doesn't fit
        into page 1, which leads to incorrect layout.
        
        Fix the problem by allowing inner floating tables in floating tables,
        but disable the ability to split for the inner one for now.
        
        In the long run we still need layout-level nested multi-page floating
        tables, but one step at a time.
        
        Change-Id: Ib90cf2873bf7d6c817450a263156764f6f09855e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152891
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-12  Balazs Varga  <balazs.varga.extern@allotropia.de>  [1b0420e9980324f04bfd4b1316b572331f1e83bc]

        tdf#154943 - Accessibility checker: fix no warn of decorative-flagged image
        
        If an image marked as Decorative it will be irrelevant for a11y,
        and no warning will be on the accessibility sidebar.
        
        Change-Id: If4d25fd8043549832a70b2c2be5aa754c76d9c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152737
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-12  Justin Luth  <justin_luth@sil.org>  [d384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8]

        related tdf#80194 SvxEscapementItem: set auto flag as default
        
        This OUGHT to effectively be identical - since nProp
        is the default, and the DFLT_ESC_ values match what
        _AUTO_ ought to calculate. So it shouldn't be too scary.
        It would ?only? expose areas that deficiently handle _AUTO_.
        
        The primary intended effect is on calling .uno:SubScript
        (via the properties panel or toolbar) and getting an
        automatic subscript/superscript for editeng text
        (which would be draw/impress/calc objects, or Writer textboxes).
        
        Instead of setting the default value for subscript/superscript,
        set the auto-flag so the computer can more intelligently handle
        the positioning. That's what I would expect as a user,
        especially since this is the default in the character format dialog,
        and Writer already did this explicitly.
        
        One possible downside to this is that "automatic" is less
        clearly defined for pixel-exact compatibility with other
        programs, or for export/import. But we already do that with
        Writer - which is the most concerned about pixel-exactness...
        
        Prior to 7.0, editeng automatic subscripts weren't calculated very well
        (i.e. subscripts were placed way too low).
        So don't enable automatic mode until after 7.6,
        so that the older, stable versions have a chance
        to not mess up positioning an automatic value
        on newly created documents.
        
        CAUTION: Doing this at such a low level might be too radical.
        The other option would be to specify it at all of the
        SID_SET_SUB_SCRIPT locations - similar to the way that
        Writer did it.
        
        Change-Id: Ic6fb866477653ff57edd02bb894769545a60acf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88998
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [49d9bdd259bf17c1db8aae1e95937a15bb672521]

        cid#1532366 Uninitialized scalar variable
        
        Change-Id: Iea2b38149815c7025f1df0739731142f892ba016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f903d0f14245bc3f2d292cff5d13fb566cb20f51]

        cid#1401342 Uncaught exception
        
        Change-Id: I23459898259415b3b2f8b58e5db05b5646994d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dee1cf105306d6795c50fdf53afe1d10fbf8552d]

        cid#1532369 Unchecked dynamic_cast
        
        Change-Id: I43cd71b608fcddd48d7713e11efdf01d20f963fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [081ceacde942f558e34cfef8ab64a9feed9b4549]

        cid#1532368 Unchecked dynamic_cast
        
        Change-Id: I132b734e74f0b92e7fcb6230163d876783140b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36e1e8d14dc177971db6b1f51b84c53392e7487a]

        cid#1532370 Uninitialized scalar variable
        
        Change-Id: I5673443c75f5698884d5fc7ccfec1c82b8ca88ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152860
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [953ef30494661788b2e980ece84b62c653d77321]

        ooxml: import and export char underline theme colors
        
        This adds support to import and export char underline theme color
        properties.
        
        Change-Id: Ia8948ee5aacd20e0c2b7cbb1b2fdf97fc65c04e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152834
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [92fc0ace46398eeb6c9238c8292459cc78db6694]

        ooxml: import and export border theme colors for various props.
        
        This adds support to import and export various border (lines)
        theme color properties.
        
        SvxBoxItem needed to be fixed, because it can happen that the
        BorderLine is not yet initialised and we already set the border's
        ComplexColor. Now there is a maTempComplexColor inside SvxBoxItem,
        which stores the ComplexColor until the specific BorderLine is
        initialized.
        
        In addition add roundtrip test for import and export cycle.
        
        Change-Id: Idd307a3adaf364745aed8fc8540bf72ef4948198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152833
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3799defaccaaa7160d3a584fdb1c68e0719a0381]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05cb445d5f273ccbeb80b1af28bcb1a13e9b8b14
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            + Writer View menu (part 3)
            
            Change-Id: Id20a4466894c199c229c54c8228b818f4c166126
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152869
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-12  Paris Oplopoios  <paris.oplopoios@collabora.com>  [20a6c2df3ea899cce15775d954ffa50bb9dc81cd]

        Fix unchecked dynamic cast
        
        Change-Id: If662e24bb864690ead959b2599a6448d84da0de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152866
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-12  Patrick Luby  <plubius@neooffice.org>  [ca060dac4beb944ac6994ba9c050ab4eba4fc44e]

        Fix hanging when selecting a column or row in Calc
        
        When a Calc column is selected, the child count will be
        at least a million. Constructing that many C++ Calc objects
        takes several minutes even on a fast Silicon Mac so apply
        the maximum table cell limit here.
        
        Change-Id: I4e3ebf9fdf7367620313e4e10dd0918de9d6bffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152853
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-11  Maxim Monastirsky  <momonasmon@gmail.com>  [7fa6198f29ac18ef2d58129918cb76c5da263d4f]

        tdf#154933 Update style names in autocorrect strings
        
        Change-Id: I8a5157e10179c1813c1fd1a8f94c13c977131cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152855
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [69e180a46a20eb86185a72a652b0b67996f121f6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 97ed4a4faa26d89ee068b12efed26c99caf1ce86
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            + Writer View menu (part 2)
            
            Change-Id: I14c57949b522b1fc17ceb26169a81b1ce48fb8c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152859
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [950848c5f0183e294dd590b27bc8966639e0b9af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 367807066f4e2a1190fe056fd6e52026fd35e2a6
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            + Writer View menu (part 1)
            
            Change-Id: I8848e3102f7294e796a6fcbcd63f22b9bb29f23c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152806
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-11  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d5a973fee90820b529e5fbafbef35917625ffd19]

        Related: tdf#155507 don't broadcast UI Theme change unless it did change
        
        a problem since:
        https://github.com/CollaboraOnline/online/commit/b6d4c88f9011845acae5c8537c0826055c8327a2
        
        Change-Id: Iac1189ba7b892324b5f000f5f6240787b3209892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152799
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [73611b5b81a7d420f9921c1dc24bc4f35c783741]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0137de5673170eac325fc503cf10550d65ebe0c4
          - Do not overcapitalize nouns that are not commands
            
            Change-Id: Ic5d2d6775d170b26fa9e9964da5c461e1c53098e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152858
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c66fc45239d2589e90fd694d54b3ff826b1bd15]

        use internal iterator for SfxBroadcaster
        
        So we can avoid exposing the internal listener vector.
        (which allows further optimisations)
        
        Change-Id: If288141a37314dcc01d203029dc51c71ec2b7f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3a6d360b5e585b8e92cc0d58d5fbc497448e11fb]

        oox: fix theme data in model.xml to use a correct types
        
        Change-Id: Ifaa725d8a3e6c4cfefc92a6c5fcdb581610d3ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152832
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-11  Paris Oplopoios  <paris.oplopoios@collabora.com>  [7588c1f33cdaab58a6b84f4f4e75922c5d4a8a7f]

        tdf#154168 Export no transparency PNGs correctly
        
        When bTranslucent was false the function would simply return, causing a
        0 byte png. Now we just remove the alpha channel.
        
        Change-Id: Ie2578185ac12fb38b6f1b674758e564721e3973f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152840
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-10  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8bcdda7e18148a7f4e15bbec0bd0550355b7bd8d]

        ofz#59696 Abrt
        
        Change-Id: I4cf6043f55a7aae23b6a801dd41b0912b68e1d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152836
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ce8186315fda526235f295ef97dd1352309643f2]

        Fix typo
        
        Change-Id: I797bf9d49d1a0f2cd4d9c523a46bb6ed979581e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152841
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-10  Justin Luth  <justin.luth@collabora.com>  [ce5f7ab57253a39fa52a64566aeae394ce79e241]

        sw content controls: add 'properties' to right-click context menu
        
        Getting to the properties of a content control is buried pretty
        deep in the menu. Make it quickly available via a right-click,
        just like what is possible for fields.
        
        Change-Id: I6f094590dcfcad81dc623754bf9daf036e41aa3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152837
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-10  Michel Weimerskirch  <michel@weimerskirch.net>  [a6a2536b645963c5ed56ae394b057cce4b2f1163]

        Improved Luxembourgish (lb-LU) autocorrect file
        
        Change-Id: I567f7bef0c9cc7ff332bf71f3d30a313cdb525cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152783
        Reviewed-by: Michel Weimerskirch <michel@weimerskirch.net>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-06-10  Khaled Hosny  <khaled@libreoffice.org>  [74b6c5ea3c333de7c5e7ef8636732edadd9083f2]

        tdf#151968: Fix vertical position of RTL spelling wavy line
        
        Second try. This time making sure start > end even for RTL text.
        
        This also now works for horizontal, vertical and rotated Arabic text, in
        Writer and Edit Engine.
        
        Change-Id: I6fe1e9dbb9c071287054200a58d4ddddee073311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152743
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-10  Justin Luth  <jluth@mail.com>  [30662ae380e3d31cc8904fcb1ceeb2592504834d]

        tdf#347349 sc: avoid UpdateEditView when formula building
        
        The problem was that with a split window,
        the editview was being updated when switching to another sheet
        and then you couldn't select a cell during formula building.
        
        GetSelection from ActiveView was
        returning nothing if the editView was updated
        during the switch to another tab.
        
        This only happened under certain conditions
        that are detailed in the bug report.
        
        While I don't have much knowledge about the calc engine,
        this change seems reasonable enough to me to submit it.
        
        Change-Id: Ibb9a70fdfd57c2e1a1a7ae2ebafc4bf1b850f02a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148567
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-06-10  خالد حسني  <khaled@libreoffice.org>  [4ceac7d67d3f3e09dc3f4a03b330d779e6a71e4c]

        Revert "tdf#151968: Fix vertical position of RTL spelling wavy line"
        
        This reverts commit 5899b27e71430e490c2d3a6b87ae52c10f383ba7.
        
        Reason for revert: tdf#155001
        
        Change-Id: I95d21689a50f6413a7b5c126d6eb6b2c8802fbc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152752
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-10  Paris Oplopoios  <paris.oplopoios@collabora.com>  [bf944e33569e4a1d6236a54671b7320cdc6ffaf6]

        tdf#104877 Add basic APNG format support
        
        Add basic APNG (animated PNG) format support that can correctly display
        simple files with no transparency
        
        Change-Id: Ibfb6e13953a8ba48a535a40b08792b3723b7dc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140089
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a7b5fe0c813977347a8d10ac5a52862f6150fbc0]

        Fix typo
        
        Change-Id: Iaf94d6e4c771220167a17131b57be68290203b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152802
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a7481809d7dd9072d965e7fd281b5f2020c09b97]

        Fix typo
        
        Change-Id: I64f539d427a61877a0647b7b4e1a217c5d913cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152803
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [97a4e4582698c74fa4fa5c2fed3cd48d4c66da8b]

        Fix typo
        
        Change-Id: I93f8dc6746a9173847e96f1ba16e5fdc4a817ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152804
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-06-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e4c611ddc731d6a2ca9c3de61a02d1d4b6eefa9b]

        pdf export dialog can crash if async mode used
        
        dialogClosed can cause the owner of PDFDialog to drop it during the
        callback
        
        ==4057599==ERROR: AddressSanitizer: heap-use-after-free on address 0x6130003cc890 at pc 0x7fecd4abe0f4 bp 0x7ffce7ef2d80 sp 0x7ffce7ef2d78
        READ of size 8 at 0x6130003cc890 thread T0
            #0 0x7fecd4abe0f3 in std::__shared_ptr<SfxTabDialogController, (__gnu_cxx::_Lock_policy)2>::operator bool() const /usr/bin/../lib/gcc/x86_64-redhat-linux/13/../../../../include/c++/13/bits/shared_ptr_base.h:1670:16
            #1 0x7fecd4abe0f3 in svt::OGenericUnoAsyncDialog<SfxTabDialogController>::destroyAsyncDialog() core/include/svtools/genericasyncunodialog.hxx:107:13
            #2 0x7fecd4abd362 in PDFDialog::runAsync(com::sun::star::uno::Reference<com::sun::star::ui::dialogs::XDialogClosedListener> const&)::$_0::operator()(int) const core/filter/source/pdf/pdfdialog.cxx:95:9
        
        0x6130003cc890 is located 272 bytes inside of 336-byte region [0x6130003cc780,0x6130003cc8d0)
        freed by thread T0 here:
            #0 0x4b7cfa in __interceptor_free (core/instdir/program/soffice.bin+0x4b7cfa) (BuildId: e1b47bbe1dcc1e4ed692b09b49fe3da8d206f4b1)
            #1 0x7fed09f540b2 in com::sun::star::uno::Reference<com::sun::star::ui::dialogs::XAsynchronousExecutableDialog>::~Reference() core/include/com/sun/star/uno/Reference.hxx:114:22
            #2 0x7fed09f540b2 in ModelData_Impl::~ModelData_Impl() core/sfx2/source/doc/guisaveas.cxx:359:1
        
        previously allocated by thread T0 here:
            #0 0x4b7fa2 in malloc (core/instdir/program/soffice.bin+0x4b7fa2) (BuildId: e1b47bbe1dcc1e4ed692b09b49fe3da8d206f4b1)
            #1 0x7fecd4ab87cf in cppu::OWeakObject::operator new(unsigned long) core/include/cppuhelper/weak.hxx:89:18
            #2 0x7fecd4ab87cf in filter_PDFDialog_get_implementation core/filter/source/pdf/pdfdialog.cxx:170:26
            ...
            #9 0x7fed09f811a4 in SfxStoringHelper::GUIStoreModel(com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, std::basic_string_view<char16_t, std::char_traits<char16_t>>, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, bool, SignatureState, bool) core/sfx2/source/doc/guisaveas.cxx:1561:29
        
        Change-Id: I7ea28b9b4bb7c826f1c3c8ced7ea8217573f733b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152793
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-09  Michael Stahl  <michael.stahl@allotropia.de>  [ca9341cf60f3f9350662d30b61f6eadefca24667]

        cool#6580 sw: fix infinite loop when changing document language
        
        If there's a footnote in the document, changing the document langauge
        goes into an infinite loop in FindParentText(), because the selection
        created by ExtendedSelectAll(true) is actually invalid, apparently
        the intention is that only very limited functions may be called while it
        is active.
        
        Don't handle this invalid "very" extended selection like one created by
        ExtendedSelectAll(false).
        
        (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
        
        Change-Id: Icf1032715cf2e0a05bf485039c483440c08bb6bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152797
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [364c8676f773085031bf454b810280ecbaf12b6a]

        Fix typo in code
        
        Change-Id: I98cd2b8c8a05f293dd85fbdd8828bc9e67aff2fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152786
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [286e3d3fd10bdbec4954aab46eea198e9f0b9602]

        Fix typo
        
        Change-Id: Ica639513051c843bf8065f209427ba4054993463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152791
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c1470e15bd0643be8d91aaf6a0d25c78867d0b3e]

        oox: remove code duplication and add getComplexColor to oox::Color
        
        Change-Id: I9cfbc851d4f303a5a8c92183f01cb5b6545b7984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152800
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bcd076c22c5af0993641e719ea01559548acbc38]

        Fix typo
        
        Change-Id: I4b8e65b686942a20df2d0133ff1208737e272e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152790
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fd1bd06509f4544cc18bdf2319c5456b33d08e52]

        Fix typo
        
        Change-Id: I4f3f148956c0502a3582a232cbd3cad287c0eaa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152787
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cdc015ffd4b2460a9235db72a5411c421ab0e2d4]

        Fix typo
        
        Change-Id: Iaebe55927771985a6b574b2cb9410b0eb75441e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152789
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e1dcf9464e56c0eee9f662f82928b3f99ba78217]

        Fix typo
        
        Change-Id: Ib02cc0e9aaf286d8c39523ea352cfeec17a6336f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152788
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [aae8841e2057d522b3cae7b5792ae75cc8d6b5b4]

        Related: cool#6511 hold json preview cache longer
        
        due to oddities related to tdf155720 the notebookbar the cache is hooked
        to can be torn down and replaced if the 1st session is interacted with
        while multiple other users join. So count goes to 0 just at the wrong
        time to trigger throwing away the cache and forcing regeneration.
        
        An Idle doesn't suffice here.
        
        https: //github.com/CollaboraOnline/online/issues/6511
        Change-Id: I148c99115fc497e34bf8920b6f59adc47605b8a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152720
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-09  Michael Meeks  <michael.meeks@collabora.com>  [6fc48879f8347a53a5ef1bf801fab831be3310f2]

        trimMemory - fix crash modifying structure during clear.
        
        Re-use existing code from shutdown, to avoid ~Bitmap mutating
        maScaleCache while we're iterating it inside clear.
        
        Change-Id: I021d9075cf5c449702af091c2c8a4de64887f2ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152769
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-06-09  László Németh  <nemeth@numbertext.org>  [9486ead7bbd5bd2460f5c75540dfeb731838e655]

        tdf#155747 sw tracked table column: fix crash at table selection
        
        Selecting tracked columns and accepting their deletion resulted
        crashing because of the outdated table cursor in IsCursorInTable()
        call of UpdateTableStyleFormatting(). Remove table cursor before
        calling DeleteCol().
        
        Regression from commit d1004cdd6a445ae73673b0ca360ae034b0ec09f2
        "tdf#150673 sw offapi: add change tracking of table column deletion".
        
        Change-Id: I47f4db11bd7ce4ad851c0658eec3e12ce4fdf4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152792
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-09  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [dd8e061406fac581d399da088c7f0187278035dc]

        tdf#153437 sc: fix broken formatting without performance regression
        
        Follow-up to commit 7be7e1ff95af485a9cb00748800d3d084f96387c
        "tdf#153437 sc: fix broken formatting at Undo of row/column insertion"
        by replacing that with a better version without performance
        regression. This keeps the original performance fix of
        commit 2e86718626a07e1656661df3ad69a64848bf4614
        "don't allocate unnecessary columns when inserting a row"
        related to the support of 16k columns.
        
        The previous fix used extra memory to fix the broken formatting
        of the cells. I have now solved the error in tdf#153437 without
        taking extra memory. It doesn't change the reserved cells, it just
        deletes a row from the default attribute of the cells when deleting
        rows, so they don't slip. When deleting a column, the last column
        in the still reserved area loses its formatting. I copied the default value back here, as the other columns have this value.
        
        Change-Id: I35da1cb79ff4e3493e91d29766cc2b81412080eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152742
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-09  Svante Schubert  <svante.schubert@gmail.com>  [2d9f739ccfead38cdaa13780f7bb5172553dbd77]

        tdf#155244 filter: XHTML export: Making ODF style IDs unique for ...
        
        ... HTML/CSS by adding a prefix (the @style:family with '-' as glue character)
        to their style name.
        
        Disabled debug output for style:family-name in XSL
        
        add text:a to text family
        
        ... and add a unit test.
        
        Change-Id: Ie846f5ea2a872872f38036aff59d29c8f530ed32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152749
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0b1a8cc4a59fadd83bdcf13ba88bb8f68d02e106]

        tdf#125876  "Footnotes and Endnotes" -> "Footnote/Endnote Settings"
        
           also update command name in "tip of day" and add links to the
           dialog for the relevant tips.
        
        Change-Id: I6dbebf3cbe405f5bd1d6d01d992cb096a5e61348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152651
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-06-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c2829c48780820692f1a9ec4e8ad5e423933e09]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9ff981baf27f13da4245b41e3bed652925657f4d
          - Improve wording in accessing commands
            
            Change-Id: I5e3220f33a00fd30a42de465b495802abc6e0462
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152796
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7d2a7307da71b245fe55c55c5a29f4695c3c54f7]

        fix wrong transform type, error handling when JSON parsing
        
        also fix theme export - change scheme enum type name "hlink" to
        "hyperlink" and "folHlink" to "followedHyperlink"
        
        Change-Id: Id5435d59cd51352efc4a4a8e333ec1ff45847a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152782
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-09  Caolán McNamara  <caolan.mcnamara@collabora.com>  [30bc5fdb49621269b7281aace610ca85b150766c]

        Related: CollaboraOnline#6511 cairo backend can do transparent text
        
        and avoid the extra work required here for the generic case.
        
        keep the transparency helper for the other backends, or any case where
        we may be recording to metafile, or pdf export etc
        
        Change-Id: Ic01b8b69f2d59e585605ce1e981298fda9185824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152719
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ce72faa0519c2daba848a80915184b20ffb2c124]

        bump version to 24.2.0.0.alpha0+
        
        calendar based naming - 24.2 is the February release, 24.8 would be the
        one in August
        
        Change-Id: I91d14da7060769e995f67c855e9dda04f2144870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152716
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-06-09  Stephan Bergmann  <sbergman@redhat.com>  [2193650b3373ee1889961cfb72d1fe97f73e2c23]

        external/coinmp: Update to CoinMP 1.8.4
        
        ...originally started mostly to simplify a then-upcoming change to address
        std::bind2nd gone from libc++ for C++17 (which turned out to already be
        partially addressed in this new CoinMP revision).  But that has since been
        addressed with b97e8b9d13ef0f57f7cf0badbefcb038a8bbd137 "external/coinmp: Adapt
        to std::bind2nd gone from C++17" on top of the old CoinMP 1.7.6, because
        updating to 1.8.4 turned out to run into issues on Windows, see the email thread
        starting at
        <https://lists.freedesktop.org/archives/libreoffice/2022-September/089383.html>
        "Maintaining building external/coinmp on Windows".
        
        * <https://dev-www.libreoffice.org/src/CoinMP-1.8.4.tgz> is a copy of
          <https://www.coin-or.org/download/source/CoinMP/CoinMP-1.8.4.tgz>.
        
        * Various of our patches are meanwhile addressed upstream, partially or in
          whole.
        
        * The upstream configure scripts deteriorated and caused one of my Linux build's
          CC=/absolute/path/to/some/clang to be mistaken for MSVC which caused them to
          force LD=link, which in turn caused them to only build archives and not the
          shared libraries that we expect.  external/coinmp/clang-with-path.patch
          addresses that.
        
        * There's apparently a new ClpSolver library now that also needs to be
          installed.  Otherwise at least CppunitTest_sccomp_swarmsolvertest failed due
          to
        
        > warn:sal.osl:1950612:1950612:sal/osl/unx/module.cxx:152: dlopen(instdir/program/libsolverlo.so, 257): libClpSolver.so.1: cannot open shared object file: No such file or directory
        
        * Plus modifications to external/coinmp/windows.build.patch.1 thankfully done by
          Taichi Haradaguchi <20001722@ymail.ne.jp> to make this actually compile on
          Windows (cf. the mailing list thread starting at
          <https://lists.freedesktop.org/archives/libreoffice/2022-September/089383.html>
          "Maintaining building external/coinmp on Windows")
        
        Change-Id: I498c9513fa0d96d8ae2b9ba4c09dd792340db730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-09  Andras Timar  <andras.timar@collabora.com>  [3c7813b095c18744954bb21ec7f773cbba5d4a63]

        improve dictionary package descriptions
        
        Change-Id: I490b8a9b99dae76b92de3b5ed22bb27a9df21591

2023-06-09  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a6e72e2b314e64f3199f3eaf1ecf78157446f6dd]

        MCGR: tdf#155479 repair gradient SVG export for MCGR
        
        Unfortunately SVG export is based on metafiles and thus there
        is (in principle) no way to get the BGradient/ColorStop/MCGR
        data transfered as needed. For that, using UNO API to read the
        model or using B2DPrimitives would help - as is better for the
        export respectively.
        
        Since there is not the time to re-design SVG export I added
        this 'compromize' as a fix. It gets the needed data transported
        over the metafile (that part is the compromize). It then
        exports the MCGR data to SVG (at least - as was already there -
        if it's a linear/axial gradient). This happens now with all
        Gradient Stops when there is a MCGR gradient. That part is/will
        hopefully be re-usable if SVG export  gets redesigned.
        
        I also added a handling for StepCount feature, so when used (in
        LO, others do not have that) 'hard' color stops get generated
        to make the gradient look identical for SVG export.
        
        Had to make adding of that extra-information in metafiles
        dependent on exporting really to SVG. There are 51 cases which
        use 'MetaActionType::COMMENT' which would potentially have
        to be adapted.
        
        Also added code to solve the problem for TransparencePrimitive2D
        at VclMetafileProcessor2D::processTransparencePrimitive2D. This
        will now - also only for SVG export - directly create the needed
        MetaFloatTransparentAction and add additional MCGR information.
        This will be used on SVG export to write a 'Mask' as was done
        before. This is now capable of creating fill MCGR-Masks in
        the sense that any number of TransparencyStops will be supported.
        
        Change-Id: Ic6d022714eae96b8fbc09e60652851ac5799b757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152623
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-06-09  Jaume Pujantell  <jaume.pujantell@collabora.com>  [bbf5f97967fb3cde25829e1c428ace31d7d5b8c7]

        notify async password change
        
        Change-Id: I2d16c9804e65f093239e810d466de35286b28dee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151651
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-06-09  Miklos Vajna  <vmiklos@collabora.com>  [bfd479abf0d1d8ce36c3b0dcc6c824216f88a95b]

        Update libxmlsec to 1.3.1
        
        This time try to do it in a way that doesn't re-introduce tdf#155034,
        i.e. patch out code that would use NSS symbols which are in the RHEL7
        baseline, but are not in Ubuntu 18.04. This is all code like RSA OAEP or
        AES GCM which is relatively new, so not really required for our
        signature needs.
        
        It also helps that this release has a lowered baseline for NSS.
        
        Change-Id: I5a8df6d98462e8173a5508e014bd2d515da2dc9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152747
        Tested-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-09  Justin Luth  <jluth@mail.com>  [278b6d21d36a0ff401fdd9ed6f964cd0dca862bf]

        tdf#152046 Revert "tdf#100680 sw DOCX compatibility: fix wrap of as_char flys"
        
        This reverts 7.4 commit 41b012767feb8552b60a68c7be18d80c403304bf,
        
        The premiss of the commit is that as-char flies needed to be handled differently,
        and yet at the spot where it was implemented, we have no idea whether we
        are even dealing with an as-char fly!!!
        
        As this bug report report shows, it affects paragraphy that don't
        have any fly whatsoever, let alone an as-char fly.
        
        Change-Id: I2fedb2d610093933081e861a16a25de2f2716258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152778
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3b294f6139028014e72379ebe8eda24a2bd32195]

        restore, not clear, existing interaction handler after save
        
        put things back the way they were found.
        
        In this case I want it back to the original state, because
        
        a) lok sets its own interaction handler on load
        b) at framework/source/loadenv/loadenv.cxx:1137
           Because that handler supports XInitialization we show the
           window early
        c) that happens to be before the menubar is set
        d) so the menubar changes the size of the window after
           it is shown
        e) so Window::ImplPosSizeWindow calls
           ImplInvalidateFrameRegion(nullptr, InvalidateFlags::Children)
        f) which sets ImplPaintFlags::PaintAllChildren on the PaintFlags
           of the workwindow
        g) which means that when a SwEditWin calls PaintImmediately vcl
           sees that flag on its WorkWindow grandparent and calls
           ImplCallPaint with the grandparent, not the SwEditWin.
           It happens that the grandparent has no LokId so that does
           nothing.
        
        if we clear this interaction on save, then the next joiner instead
        has no interaction so gets the default one which does not
        support XInitialization, so the window is not shown before menubar
        is added, so when it is shown it is already at the final size,
        so there is no ImplInvalidateFrameRegion and so no
        ImplPaintFlags::PaintAllChildren bits on the WorkWindow, so
        PaintImmediately on SwEditWin calls that Invalidate, which is
        special cased to broadcast the invalidation as a real thing
        
        Change-Id: Ie3fde4c53476aada2b1fdabb1dc70b08485074b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152772
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-06-08  Patrick Luby  <plubius@neooffice.org>  [312adca5c50666d924dce936012fba5b8f626939]

        Fix iOS build breakage
        
        Two new functions that are used only on macOS were added in commit
        75dc3a54fca8b2dc775ba007190d8c2e188f1c0a.
        
        Change-Id: I18d0f7aaa9d1ca6634b13eafc76b4fd39dfa52ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152771
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-08  Colomban Wendling  <cwendling@hypra.fr>  [235b0a4d30598631218dcc289a9efa85cd52ed3a]

        sw: Fix crash accessing default accessible attributes
        
        Fix crash accessing the name of the MMToPixelRatio item in the sequence
        returned by SwAccessibleParagraph::getDefaultAttributes(), because a
        temporary local was used as the property name, but got destroyed when
        the method returns.
        
        This was introduced in 46ce0d28b4c765076c7871358375c4e85e44534b,
        probably by inadvertently removing the `static` qualifier.
        
        Change-Id: I1d5004b0b0fdf9651781b9c71b67afeba61c284c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152748
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [cc00b7dedf8e55a4d1017cde807605225334b8e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 430c011fc24671011cbdd5f6310e7681ecdaf17d
          - Related tdf#154933  update "Text Body" -> "Body Text"
            
            Change-Id: Ib0844b47d6320fe9b543141f811002ccc3ca4e94
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152659
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-06-08  Jaume Pujantell  <jaume.pujantell@collabora.com>  [53d610786ba8085fcce331174c74294c90c41a20]

        pdfium: better suport for annotations and some fixes
        
        Added suport to import FreeText annotations. Added some suport to export
        graphical annotations. Fixed some color issues to be more inline with
        the pdfium library.
        
        Change-Id: I7371595ebb95594ee765ae532ca7c7d4f0499592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152606
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [260bc16e1923016d0628a8779e219b290d4c9011]

        check for empty model like ObjectIdentifier::getObjectPropertySet
        
        a speculative fix for:
        https://crashreport.libreoffice.org/stats/crash_details/5b3c8597-9ffa-49b8-8cc2-132e69456249
        
        Change-Id: I4f45cf4c7ed51c814d4cb01b8f55709586d7a981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-08  Caolán McNamara  <caolan.mcnamara@collabora.com>  [3fe8d0e47418c4ce47a6ae6802ccbb0dd496f853]

        ofz#59696 Abrt
        
        Change-Id: I8ef148ab96e2fedd6b464bff87b43d9736300f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152738
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-08  Stephan Bergmann  <sbergman@redhat.com>  [48d09aa85e01d881995c660f845b60bd8088e7c0]

        No longer append appdata for components to flatpak's metainfo
        
        This had originally been added with
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/945f6caad87658b1df1e8918bd5f64939058ab7f>
        "clean up desktop integration", see its part "append the appdata for the
        separate apps (Base, Draw, etc) to the appdata XML we export for Flatpak, so
        they are visible in software centers etc".  But it now started to cause Flathub
        builds (like <https://buildbot.flathub.org/#/builders/14/builds/3985>) to fail
        its "Check for right id in AppStream xml" step, and reportedly "the problem is
        there are multiple components in the metainfo file and I'm not sure it's
        allowed"
        (<https://matrix.to/#/!RfXaBjokqHAbzZrgHz:matrix.org/$jWhob-a4LEH-e_TXsJwGWNfMYLF1kcWpXV_oW982ZpI?via=matrix.org&via=gnome.org&via=kde.org>).
        
        The solution appears to be to just remove that again
        (<https://matrix.to/#/!RfXaBjokqHAbzZrgHz:matrix.org/$Yrzf_ZjJxBgUVs6kuP_10Tneu1t1wKQJCM_SC1vNHC4?via=matrix.org&via=gnome.org&via=kde.org>):
        
        > I think maybe the problem was from the times that GNOME Software was also
        > moonlighting as a menu editor
        > that without Flatpak providing the metainfo for LibreOffice's different
        > desktop launchers, they were invisible in GNOME Software, which meant you
        > couldn't add/remove them to menus or the desktop
        > but since then GNOME just shows all of the launchers, and menu editing /
        > categories mostly died or sank to the bottom of the 1990s ocean
        > so maybe this is a non-problem
        [...]
        > ah ok
        > ah so they don't show any more 🤣
        
        So remove the now-unused solenv/bin/assemble-flatpak-appdata-step2.sh and
        consequently rename the sole remaining
        solenv/bin/assemble-flatpak-appdata-step1.sh to just
        solenv/bin/assemble-flatpak-appdata.sh.
        
        Change-Id: I3d3fef502f2114274a856102b77edafdd0ecac83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152744
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-08  Franklin Weng  <franklin@goodhorse.idv.tw>  [7f5e2fc7c1ae7c0c2bec76809e11365b255601d5]

        tdf#155182 : fix test of $minLabelWidth which is always true
        
        Change-Id: I74e6e101ba16de1100e71ed950116bceb6862829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151601
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0b98ddee3612568ac640ad05b2d3d59f00d9ca2f]

        tdf#154951 - Accessibility checker fix missing alt text of grouped shapes
        
        Add grouped shapes objects to "Go to" and "Fix" functions.
        
        Change-Id: I4ebdbcadc775e700fe1da3a858e60658a88553db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152709
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-06-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1d1a424a4d291873101f5d2348e5bd9cb9091a4]

        tdf#155735: Add basic support for feColorMatrix
        
        for now, it only supports type="luminanceToAlpha"
        
        Change-Id: Ia84df9af08ac2be2e496a5fadb490deaf48210cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152741
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [195364a57a5e3090648cb327607bc52da2be583c]

        tdf#155733: no need to store these values
        
        Change-Id: I1c22f8f344731eb5fbc5f77fc80267ebcdc81ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152740
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-08  László Németh  <nemeth@numbertext.org>  [cc52d895314dd7b67de916bd90ccbfa098e77419]

        tdf#155342 sw tracked table column: manage changes
        
        in Manage Changes dialog window, where deleted/inserted
        table columns were shown as multiple cell changes.
        Now deleted/inserted table columns are shown with a
        single tree item in the dialog window instead of
        showing multiple cell changes.
        
        Add new Action icons to the tracked table column
        insertion/deletion tree items (re-using table column
        deletion/insertion icons).
        
        Show cell changes as children of the single parent
        item tracked table column change.
        
        Accept/Reject and Accept/Reject All support
        1-click acceptance or rejection of table column changes,
        instead of clicking on all cell changes of a single
        table column deletion/insertion.
        
        Follow-up to commit commit eebe4747d2d13545004937bb0267ccfc8ab9d63f
        "tdf#144270 sw: manage tracked table (row) deletion/insertion" and
        commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column".
        
        Change-Id: Ie9c9d8ef707ee2581cf6d0b066c10901555ca04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152711
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c86622057c51622eca24b79d0644c3686299e829]

        lok: send theme palette after the change in ThemeDialog
        
        For some reason the SdrPage is constructed in Online after every
        change (cursor, selection) so can't use that to send theme change
        callback. Instead of that send it after the theme is changed with
        the ThemeDialog.
        
        in addition this requires that we transport model::ColorSet in a
        shared_ptr more, to prevent doing constant copies. This requires
        that the IThemeColorChanger interface is changed and the signature
        of apply() method.
        
        Change-Id: Iac951fce57a8e9dff467bd27b2f9c64ec65ea30c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152635
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit 6c40e4d1796bcb6418dcb5ec17f46f576c171796)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152728
        Tested-by: Jenkins

2023-06-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba9ac212f9f175b6eed6f569f4d5d3fcf2a8cee3]

        ScPatternAttr does not need a special case for *mxHashCode == 0
        
        I don't why the original
            commit   b26c34267cdf9d0b7ba4e2fda7ae706d5cd76299
            replace SfxPoolItem::LookupHashCode() with Lookup() (tdf#135215)
        did this.
        After I can tell, the Lookup will function perfectly fine with hashcode
        == 0, the operator== method already falls back to using full comparison
        of the underlying SfxItemSets
        
        After this change, running 'make sc.check' with
        ScPatternAttr::CalcHashCode patched to always return 0 reveals no
        problems.
        
        Change-Id: I56c3e6c00796e4cc9c12fd460181d6ca1ec6f066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [1b368909b09cd62494239faaea09bb500dc9f19d]

        tdf#38742 - Start Center: odb files messes up pinned documents
        
        Opening an odb file will mess up the pinned documents in the start center. To fix this issue, newly appended items will be moved to their correct position after their creation in the history vector.
        
        Change-Id: I991ae3ae1018198e054eba3477bb948d7df85b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152689
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-06-08  Julien Nabet  <serval2412@yahoo.fr>  [7364b22c45f4f5592f0d9f9d89e66121b8053c4a]

        tdf#155726: change the location of the 'Sort by Color' option
        
        Change-Id: I3d1abeb654cd2a7d60c9cec947aa583f9f25126d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152734
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-08  rash419  <rashesh.padia@collabora.com>  [1c47cd54da5f193f4b27cf86ef167c8a415c0408]

        tdf#155444 added support for multi image tiff file
        
        Signed-off-by: rash419 <rashesh.padia@collabora.com>
        Change-Id: I188aebae9c853e87dc50ffda5b7d88228559a7c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152657
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-08  Miklos Vajna  <vmiklos@collabora.com>  [81a108770233825557c2dae5776d7417be017fb8]

        sw floattable, compat mode: handle lower margin of anchor for fly intersect
        
        The bugdoc has 2 floating tables and they were overlapping in Writer,
        but not in Word.
        
        What seems to happen is that the document has a floating table, followed
        by an empty paragraph, and in case that empty paragraph goes above the
        floating table, then we overlap, but if it goes below the floating
        table, then the next paragraph will start below the empty paragraph, so
        no overlap will happen. This is possible in Word, because in "Word 2010"
        compat mode it has 327 twips vertical space above the first floating
        table (set by its positioning attribute), and in case the empty
        paragraph has a font size of 11pt (220 twips) + 200 twips of lower
        margin (inherited from the default paragraph style), then this 420 twips
        of space doesn't fit. Note that for new documents Word ("Word 2013"
        mode) does the same as Writer and ignores the lower spacing when
        intersecting lines with flys.
        
        Fix the problem by introducing a new
        SwTextFrame::GetLowerMarginForFlyIntersect() that gives us the lower
        spacing if 1) this is Word 2010 compat mode 2) this text frame has no
        fly portions / multiple lines yet and 3) this paragraph is empty. Then
        use this function at 3 places where we used to intersect with the
        absolute print area of the frame, and extend these places with the lower
        spacing.
        
        This could be extended in the future for non-empty paragraphs as well,
        but the bugdoc works without that, and the change is invasive enough, so
        better to limit the scope.
        
        Change-Id: I6e9693847beaec5d9bbf9f8a5699795579c3ff71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152726
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ac2838a9cd5577f92dbece130fa6fb8b8e26e6cd]

        svx: add "Color" and "ComplexColorJSON" argument for XColorItem
        
        This is needed now that the color picker expects this argument to
        be present. Without the "ComplexColorJSON" argument, it is not
        possible for the color picker to set any ComplexColor attributes,
        which is needed for theme support.
        
        Change-Id: I0a04ea57826afb9f17a54ce24a4cbcc88dfe1481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152727
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [452856addb26a24846505061b08e2dd64a9c5b5f]

        Revert "Allow bootstrap variables in Java user classpath settings"
        
        This breaks existing paths which contain "\" or "$".
        
        This reverts commit cfc2376f804f13eb562f39182cb24fe7dc61d6ef.
        
        Change-Id: Ia58df0a4f061f45140575e89231bd18d044a9bc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152604
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [40725c05ae1eee580a9b974363fd8921c65b5d17]

        tdf#155505 Improve display of individual entries
        
        * Remove "Go to" button and link the issue text directly
        * Improve layout a bit
        
        Change-Id: I3b0dbe7fa5ee0f2fcaeddbf12533ba9169171a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152621
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-08  Martin Jambor  <mjambor@suse.cz>  [db98a3f1b1a703ea8e1284b8815eea2274abb2db]

        Add cstdlib include necessary to build with gcc14 libstdc++ (tdf#155715)
        
        Without explicitely including <cstdlib>, compiling some files
        including store/source/storbase.hxx (such as store/source/storpage.cxx
        which includes it through store/source/storpage.hxx) will result in
        errors:
        
          error: ‘malloc’ is not a member of ‘std’
        
        and
        
          error: ‘free’ is not a member of ‘std’
        
        This patch simply adds the necessary include.
        
        Change-Id: I3d1fa2a17c5ae9d512f1de9d434dac3d82fc353f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152712
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5aefe9d1cb72f94cd6999a489860270f8432a637]

        tdf#154932 - A11Y sidebar: fix warning about missing media object description
        
        Add media graphic object to "Go to" and "Fix" functions.
        
        Change-Id: I796ce53605e5d8d10558494a87b987443ad918ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152695
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-08  Miklos Vajna  <vmiklos@collabora.com>  [2c5f053757dd99f3d514383b796790dd0037a50d]

        UITest_function_wizard: use oneprocess mode
        
        Execution time goes from:
        
        real    0m29,352s
        
        to
        
        real    0m19,938s
        
        Also the same for UITest_goalSeek: 0m30,467s -> 0m26,829s
        
        Also the same for UITest_inputLine: 0m21,856s -> 0m15,508s
        
        Also the same for UITest_key_f4: 0m10,850s -> 0m9,881s
        
        Change-Id: Ie098410d1cef1076f124189f2283770f5a916e11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152718
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ee8405d7567c35ae240e014fe1da289b4bb1abe2]

        tdf#155505 Group issues by type in a11y sidebar panel
        
        Change-Id: I87349e9d3f5680751a91264e055e4579c97fa93e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152617
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fcccb8f8d67dd7deec772746661d2d6dff2c14a3]

        sw: use ThemeExport instead of grab bag
        
        Change-Id: I68d300d58aaa1e5da374a8ddea4ff37e9a1e1819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152723
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [17105fc44bceea61ff8876686cc1362aa787ead2]

        sw: remove char color GrabBag and fix export, fix tint/shade calc.
        
        Don't store values from grab bag when exporting character theme
        colors and tint/shade values. The values could be wrong now and
        aren't needed anyway as we support the values in the model.
        Add proper export support for char color theme information with
        correct conversion of values into tint/shade values in 0-255
        inverted interval.
        This also fixes the import of tint/shade values whcih calculation
        was slightly off. We divided by 256 instead of 255, which
        introduced an error.
        
        In addition introduce ThemeColorUsage enum, which marks if the
        theme color type has a specific "usage" - text or background. This
        is determined on import if the theme type is background{1,2} or
        text{1,2}. This is then taken into account on export, so the
        exact type is preserved.
        
        Change-Id: I0022a159397fd0c3d39a118a7149bb2488dfc149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152705
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5a2c6f4df7149f8c1f543f120fe19bd66abfc189]

        tdf#155404 handle ComplexColor as JSON for XLineColor and XFillColor
        
        This adds support for MID_COMPLEX_COLOR_JSON attribute for
        XLineColorItem and XFillColorItem, which makes it possible to set
        a theme colors from the UI also for fills and lines.
        
        In addition this resolved the issue tdf#155404 which had the effect
        that unsupported "Color" attribute for the UNO call resulted that
        the dialog was opened. This is now not the case anymore as the
        "Color" argument for XLineColorItem and XFillColorItem was added
        in addition to "ComplexColorJSON" argument.
        
        Change-Id: I8876942b07aba453cbe1422b76a1608c78e42109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152713
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [e995fc61cef8fad6076212a0d7e8e357e5db1793]

        tdf#155685: sw_uiwriter3: Add unittest
        
        Change-Id: I13bde9aec9455d38435e6fd0d17d24544d9d0952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152701
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-07  Patrick Luby  <plubius@neooffice.org>  [67b808eea02219ef51324f560e673e3aaaa3e736]

        Set entitlements in non-release in $(INSTROOTBASE) and .dmg package
        
        Also, when building a .dmg for macOS, skip codesigning for non-release
        builds, both with and without the macOS sandbox, if there is no identity
        set but set entitlements to allow Xcode's Instruments application to
        connect to the application.
        
        Lastly, add entitlements when building soffice in $(INSTROOTBASE) if
        this is a non-release build.
        
        Change-Id: I764bf5bd5d44e878669c4287906e6efd6aac593f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152655
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-07  Patrick Luby  <plubius@neooffice.org>  [75dc3a54fca8b2dc775ba007190d8c2e188f1c0a]

        Partial fix tdf#155376 use NSAccessibilityElement instead of NSView
        
        On macOS, accessibility is implemented by creating a native NSView
        for each C++ accessible element. The problem with using an NSView
        for each element is that NSViews are very slow to add to or remove from
        an NSWindow once the number of NSViews is more than a thousand or so.
        
        Fortunately, Apple added a protocol that allows adding a native
        accessible element using the lightweight NSAccessiblityElement class.
        The topmost NSAccessiblityElement elements are connected to the single
        SalFrameView in each NSWindow but since NSAccessiblityElements are not
        NSViews, they are not connected to any of NSWindow's event or draw
        dispatching. This makes NSAccessiblityElements significantly faster to
        add to or remove from an NSWindow with no apparent loss in functionality.
        
        Note: this change is a subset of the LibreOffice 4.4 code changes that I
        wrote for NeoOffice.
        
        Change-Id: I408108d57217db407512dfa3457fe26d2ab455de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152717
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-06-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1c60f18de581d42c200e119aa5efc72fc7ee0bcd]

        temporarily bump product version to 7.7.0.0.alpha0+
        
        next version will use different version scheme, but in order to not
        break scripts, that actual change will go through gerrit
        
        Change-Id: I9e4ed4ef8c7bfbba0ed0f91944c46501504447d1

2023-06-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6f227b0dd912d4c70a01eb3872fff15d52de543a]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4a1edc9b8c2c3f0e0af003050d286ddce84cdbf0
          - update translations for master/7.6.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Ibebf6c575f745ff4e53a2553a5edc0ec42f2ab33
            
2023-06-07  Khaled Hosny  <khaled@libreoffice.org>  [2940fb7d2aba063441e7ce70bb276bfe912ed73e]

        tdf#64830: Don’t require hunspell dictionary for every Arabic locale
        
        For old-style hunspell dictionaries, if “ar” dictionary is found, add
        the rest of Arabic locales for that dictionary’s aLocaleNames, so that
        distributions don’t have to symlink the dictionary files.
        
        This is similar to the fix for macOS spell checking in:
        
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Tue Feb 7 21:29:12 2023 +0200
        
            tdf#153436: Improve handling of Arabic system spell dictionary on macOS
        
        Change-Id: I96b23566cba7b345a10e10c10f1bfe02ce1f8cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152706
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0a6c730b9fc9a86ff28cc615b70d8bde1a54393]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 374b792c275fbfb5fad9d12764fecde6d1d5aaaa
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            + End of Writer edit menu
            
            Change-Id: Ib93d75b18fd596eb27e92ad818656c0ef2bda821
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152710
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-07  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4fff25fc2e5335036bd21b9b3739837f31887351]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I880d86faf3c42480a505b452a15da0701ac7e964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [b542d90447230e1d6705a665f3a3e524fa966b5d]

        tdf#155376 partially convert SvCTLOptions to officecfg
        
        When accessibility is enabled, Calc will add tens of thousands of
        listeners.
        
        We then spend a significant chunk of time creating SvCTLOptions objects
        (attached to ImpEditEngine) and adding and removing those objects from
        the related listener lists.
        
        But the required information is already globally cached by the officecfg
        module, so we can avoid that overhead and just fetch it directly from
        officecfg.
        
        Change-Id: I7ff55fd7c4926866eb7086812275ba8bd6e84c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152645
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-07  Michael Stahl  <michael.stahl@allotropia.de>  [734d53534a6ca023e9c2eb819cde889b01818f1b]

        python3: upgrade to release 3.8.17
        
        Fixes CVE-2023-24329 and a few more obscure security issues.
        
        Change-Id: I4b073ce02c0377e2791e4593d20f2b756de0c8cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152696
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [77354ba8695f66331bfc6cc3f5e3f2e9d15f1740]

        tdf#132246: add basic support for feGaussianBlur
        
        for now only apply it if in="SourceGraphic" is explicitly
        used
        
        Change-Id: I3daea354f61ba5f6b3d13da1e7a71e99d51f6729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152684
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [225f79a068a1b5a51b82f9d1a6b1fc756b572873]

        update credits
        
        Change-Id: Iaaaaf2776a870836a3a9985628e7ccf902c23eff

2023-06-07  Stephan Bergmann  <sbergman@redhat.com>  [29fc791077ae8501b69e8e86ded2197fc5e12b15]

        Remove unused include
        
        ...that had been added with e5fe8434110c1299527a0d03bf450e1b6d08ca57 "use a SIMD
        friendly hashcode for ScPatternAttr", presumably for temporary SAL_DEBUG use
        
        Change-Id: I0a77330cf10c0c4e01a88580c2f4eb6a5e1df92c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152699
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d89d7df77f999a4b3673b0076ab7502c5c63d146]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 850f6ca8e730f867fa981279aaa644c1770bd9a7
          - Calc Sheet Tab Navigator help page fix
            
            Change-Id: I1f26bcaaf01c7cf35c104978199a55796222bd61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152700
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d840aaf13fdf23fea55bd2220381815cfc82af8f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b831f1f137d7bc003204a1245a3d7c33fb4da683
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: Ib680bf78031d83b56695ed79633440aa79fc5c8e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152691
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-07  Stephan Bergmann  <sbergman@redhat.com>  [eb1ec67d4e3f1992d7f31d824f06e48df8429540]

        Avoid signed integer overflow
        
        For whatever reason e5fe8434110c1299527a0d03bf450e1b6d08ca57 "use a SIMD
        friendly hashcode for ScPatternAttr" had changed ScPatternAttr::mxHashCode from
        sizt_t to sal_Int32, better use unsigned sal_uInt32 to avoid
        
        > /sc/source/core/data/patattr.cxx:1444:17: runtime error: signed integer overflow: 31 * 887503681 cannot be represented in type 'int'
        
        during e.g. CppunitTest_chart2_geometry
        (<https://ci.libreoffice.org//job/lo_ubsan/2802/>)
        
        Change-Id: Ia561b245431d812f43586013477208426aa1cc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-07  Michael Stahl  <michael.stahl@allotropia.de>  [86828ea2e323eaba0b0cfa2da73089ee810caacf]

        ucb: webdav-curl: auth data is invalid when receiving 401
        
        Even if it used to be valid before; unfortunately newly entered
        credentials weren't actually used because the flag was never reset.
        
        Change-Id: Ib36689f40ff780596b9cfe6fe589a6f2e79cfcd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152679
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-07  Pranam Lashkari  <lpranam@collabora.com>  [d7cf5429336ea4cf9a92b3338fe03ef7dc142dcd]

        sd: introduced impress slide duplication to particular position
        
        Change-Id: I4931f92158c31506b765376639907d2d4f250deb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152512
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit dc007c18097143bdb192955dda730d696d8bcb31)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152656
        Tested-by: Jenkins

2023-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [a4a570222e1270fecf17fba2c35e96907a327dc1]

        related: tdf#132246: Add basic filter node
        
        Change-Id: Iff451c441f0fe2c2fd2a14db8214f7a7d554dd15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152680
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-07  Miklos Vajna  <vmiklos@collabora.com>  [756254beedf2220a7602c81059ae1d70589072ac]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOle2Odg
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I2fad91a968940ebfd908dde5f312c81535f01599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152686
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-06  László Németh  <nemeth@numbertext.org>  [52f70f04bdc586a072141e069d451a979c5f4cb7]

        tdf#155344 sw tracked table column: 1-click Accept/Reject
        
        Now context menu of a changed table column shows Accept Change/
        Reject Change menu items, which accept or reject
        the deletion or insertion of the table column(s).
        Also Accept Change/Reject Change icons of the Track Changes
        toolbar are enabled, and do the same, if the cursor is not
        before or in a tracked change.
        
        Add the following labels to the Undo actions:
        
        "Accept change: Column Inserted"
        "Accept change: Column Deleted"
        "Reject change: Column Inserted"
        "Reject change: Column Deleted"
        
        Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column".
        
        Change-Id: Idff570dfcf8c3ce35b6223f801608779bf1cd28e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152626
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d3cd939763cad3b25c613464a6789fe643ce2baf]

        Removed executable bits from png and svg files
        
        Change-Id: Iba67b992196e26e7b0dc9eadb8cc4c3416a240d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152639
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-06  Julien Nabet  <serval2412@yahoo.fr>  [4d5fe05d3926d8106f47cac2cfdefac8ec7b36d7]

        Revert "tdf#146547 Mark read-only docs as modified"
        
        This reverts commit e7e9991fd06ba2e0484ae5e6b6acc323ab8bf66b.
        It generated tdf#155638 "Forms: Form couldn't be closed after it has been opened"
        
        Change-Id: I854c194c718cae51fd0081534570269332d119c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152685
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-06  Justin Luth  <jluth@mail.com>  [45906d2dec179aa6868edd0b81ba01b2e479589c]

        tdf#135710 doc import:  force page center on inline images
        
        Relative anchoring is irrelevant for inline images,
        so it is safe to do this in terms of writer layout.
        
        The benefit is clearly seen when the user changes
        from inline to anchored. In ODT format,
        that results in a centered image in the paragraph,
        while in DOC it was anchored somehow to a character
        and didn't lay out nicely at all after the transition.
        
        So this is mainly just side-stepping a layout issue in Writer
        (because checking the properties and hitting OK shifted the image).
        
        Change-Id: I6ff7a191d78bc1597ee9f053e02f161565a27174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152683
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [0558926c2f9201a12b4c46efc36b8a4080af4d46]

        use more officecfg for SvtMiscOptions
        
        Change-Id: I6c87025fc0997b5edbc085fc88333fe9e150eb3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c9d92e3a33e5f21ac2c72c58d49eeb138cece109]

        perf: we don't need to 'really' insert a preview when providing json
        
        if we have intercepting 'image' when generating the json, then we
        don't need to really insert the image into the server side TreeView
        at all, we just need to provide it in the client json payload.
        
        so we generate each bitmap once, and its base64 png representation
        once.
        
        Change-Id: I1b6916b036a0b84ef4346ebf2141240c4ae5b706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-06  Justin Luth  <jluth@mail.com>  [6e2b10c735381babb1ed5df624462735b84a3c64]

        tdf#135709 doc import: force dynamic wrap on inline images
        
        Wrapping is irrelevant for inline images,
        so it is safe to do this in terms of writer layout.
        
        The benefit is clearly seen when the user changes
        from inline to anchored. In all other formats,
        that results in Parallel wrapping, but in DOC format
        the text "disappears" behind the image since it wraps through.
        
        Change-Id: Ia4827814f9c9a3b8865bf8d0d72552b2b44a0207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152682
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [1527fa8435ef415678b2e4a6972f5e378ee5cab1]

        convert SvtAccessibilityOptions to officecfg where possible
        
        Change-Id: Ia530086fe35e64379e55135d392020304b466325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Michael Stahl  <michael.stahl@allotropia.de>  [6fc8a48691bfa011c8b09e560196c5d3b98fdb76]

        sfx2: SfxMedium::Transfer_Impl() ignore exceptions when getting props
        
        Somehow (bisected to commit bc48f2656c9a7bc1f41541bff66ec2c4496466a4)
        this throws an exception now when getting "Title" when storing a
        new file to a WebDAV server (the server naturally replies with 404).
        
        There is already a fallback to get the filename, so just ignore
        exceptions here so the transfer can succeed.
        
        Change-Id: Ic609f2a4f5a67670b2d8eeb74680730053a7d3a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152678
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5fe8434110c1299527a0d03bf450e1b6d08ca57]

        use a SIMD friendly hashcode for ScPatternAttr
        
        which shaves 5% off load time of a large sheet with lots of formats.
        
        We are calculating a hash over a decent sized array of pointers, so
        unroll the loop and reduce data-dependencies to give the compiler (and
        the CPU) a chance to do work in parallel
        
        Change-Id: I3d58fcf547c9280437295b9c9ec10aff16419afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152443
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4df278b4a98637aa5050abfd752eae0a9081b752]

        perf: cache the generated json for an iconview image
        
        before:
        
        |--13.95%--JSDialogNotifyIdle::Invoke
        |          |
        |          |--13.01%--JSDialogNotifyIdle::generateWidgetUpdate
        |          |          |
        |          |          |--11.03%--IconView::DumpAsPropertyTree
        |          |          |          lcl_DumpEntryAndSiblings (inlined)
        |          |          |          |
        |          |          |          |--10.94%--extractPngString (inlined)
        
        after:
        
        |--4.86%--JSDialogNotifyIdle::Invoke
        ...
        |          |--2.90%--JSDialogNotifyIdle::generateWidgetUpdate
        |          |          |
        |          |          |--0.76%--IconView::DumpAsPropertyTree
        |          |          |          IconView::DumpEntryAndSiblings
        |          |          |          Link<std::tuple<tools::JsonWriter&, rtl::OUString const&, std::basic_string_view<char, std::char_traits<char> > > const&, bool>::Call (inlined)
        |          |          |          StylesPreviewWindow_Base::DoJsonProperty
        |          |          |          |
        |          |          |          |--0.55%--StylesPreviewWindow_Base::GetCachedPreviewJson
        
        Change-Id: Id234a84e36710794822945584be3adf028808625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [9b03f778adfb87a10d781860930ed4d09410af9c]

        Language list: sort generic language before country variants
        
        In Edit Modules dialog, the language list may include entries added
        by LanguageTool, and among them are generic language-only entries
        like "Spanish {es}", stanfing for simple language tags like "es".
        These languages should go before country variants like "Spanish
        (Argentina)", but since "{" is sorted after "(", the order is the
        opposite.
        
        This change fixes this. Since other lists do not include generic
        language-only languages (filtered out by lcl_isPrerequisite and its
        requireSublang argument), this does not apply to them, but the code
        will execute nevertheless; hope that this UI-only performance hit
        will not be noticeable.
        
        Change-Id: I97adc1ae8feb4c8a94b567b33363d63d899cabaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152676
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [41c248e066f454355dcceaa233ccf90f2adaee52]

        SvtCommandOptions only supports CMDOPTION_DISABLED
        
        CMDOPTION_NONE is just ignored, so remove this parameter
        
        Change-Id: If9de22a6b0522620a267cbc92b118f79e200d999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7d8c688d7c20ecb49ff5b3577bee3d55b806d3c]

        convert ColorConfig to officecfg where possible
        
        Change-Id: I14f0ada21d328b3b6637709e403bfe973a7035b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [bda52485d63e4cfc58453d9f46bf26c3ea078ed7]

        MCGR: tdf#155537 correct usage of wrong result in tooling
        
        Change-Id: I8f68ecc7ccaecf84abbcda1bcdd65e2295baaf0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152673
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-06-06  Miklos Vajna  <vmiklos@collabora.com>  [5a25d9252791409f5e73616ff752a9ae8227aaf7]

        tdf#140066 sw: fix bad position of textbox after anchor type change + undo
        
        The bugdoc has a to-char anchored textbox. Changing the ancor type +
        undo resulted in a new textbox position, which is not expected.
        
        This is a problem since 7596e26fd259ce5445212949403e7cd32303b2bd (Add
        SwTextBoxHelper::findShapes, 2014-06-24), previously the codepath was
        not hit, since shape + content from DOCX was a fly format, not a draw
        format + fly format.
        
        Looking at the undo item implementation, in
        SwUndoFormatAttr::RestoreFlyAnchor(), aDrawSavePt is initialized from
        the old format (that we try to restore on undo), so in case that already
        matches aFormatPos (which is initialized from the new format / doc
        model), then adjusting the same position looks safe to skip, and that
        solves our problem as well.
        
        The whole problem area could be avoided if the draw layer would store
        absolute positions in its undo actions, because then it would be harder
        to get the abs Writer and the rel Draw undo actions out of sync, but
        that would a larger rework.
        
        Change-Id: Ia1c9f486e54f5967a34a1a269f8d234ae96d5bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152627
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-06  Michael Stahl  <michael.stahl@allotropia.de>  [f66d5331c1f55dfc88b1439f1b8e10ebe41d3f98]

        tdf#155685 sw: fix crash on undo of ExtendedSelectAll with table at end
        
        While the selection with table at the end works for Copy, unfortunately
        it doesn't work for Delete, because SwUndoDelete can't handle it,
        and an empty SwTableNode+SwEndNode pair remains.
        
        This needs some extra code, extract a SwDoc::DelTable() out of
        SwDoc::DeleteRowCol() and call it from SwEditShell::DeleteSel() to
        create separate SwUndoDelete objects per table, which appears to work.
        
        (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
        
        Change-Id: I1534b100d31bc279bce298d3c2bd235cffc1f9d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152628
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [f831b1edd87d934d74fc931a3650e3737ccfe3a8]

        Drop the unneeded optimization for "[All]"
        
        It will only be used *at most* once, but often will not be used at all.
        
        Change-Id: I13b0e9ab8a4918c56a7e710c80d6d9d36019c605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152644
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [1ae50dc4f816f37df50bfcb9d97c071fdf1e143f]

        Sort languages in Edit Modules dialog
        
        After commit e855481ead996a3b8270fae91bd23d6c8d75ef25, these languages
        are already ordered according to css::lang::Locale sorting implemented
        there; but this ordering does not follow the UI language sorting rules.
        TODO: put language without country/variant before respective languages
        having country/variant.
        
        Change-Id: Ic98b50ef4a500c799110611f7c35c74b4a239ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152641
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [1bdc67de20cf3090f07412513dfece356024ef0b]

        SvxLanguageBox::Store id from getReplacementForObsoleteLanguage
        
        ... not the original id passed to the function. Theese corrected ids
        are used e.g. in set_active_id.
        
        Change-Id: I9967d52ed2362ace947ea21f526c4c0694f14476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-06  Miklos Vajna  <vmiklos@collabora.com>  [4c5438b2c447403194420b69311a81ea7d36e157]

        sw floattable, DOCX import: clean up not needed dmapper-level anchor insert
        
        This was added in commit 1c99616f86f7d5b83b91edc225fc95fec227d710 (sw
        floattable, crashtesting: fix PDF export of forum-mso-en3-26783.docx,
        2023-05-02) to ensure that in case a floating table is not followed by a
        text node, then inject one at a dmapper level.
        
        Later commit 01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable:
        fix lost tables around a floating table from DOCX, 2023-06-05) did the
        same at a tokenizer level, as doing it in dmapper is too late in some
        cases.
        
        So keep the testcase from the first commit, but the changes to dmapper
        can be dropped.
        
        Change-Id: If5b702d99e81a3f939491b7ff9de1128da765cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152638
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c28819ace52704494018f14744674fe09af2d593]

        add unit test for loplugin:staticmethods
        
        Change-Id: Ied72c83dbc364f96e5b78a3cb915b23a1751ac0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-06  Stephan Bergmann  <sbergman@redhat.com>  [244f9cf66bc36f229ccb5712bc8d80166b92266d]

        Remove stray defaulted argument
        
        ...that, for unclear reasons, had been added to this declaration in
        436f3f8eb5b45620842351a1f29ba49571043515 "tdf#38742 - Start Center: introduce
        push pins to favorite documents", but without also adding it to the definition
        in unotools/source/config/historyoptions.cxx, causing
        
        > unotools/source/config/historyoptions.cxx:307:13: error: call to 'Clear' is ambiguous
        >   307 |             Clear(eHistory);
        >       |             ^~~~~
        > include/unotools/historyoptions.hxx:47:29: note: candidate function
        >    47 |     UNOTOOLS_DLLPUBLIC void Clear(EHistoryType eHistory, bool bClearPinned = false);
        >       |                             ^
        > unotools/source/config/historyoptions.cxx:71:6: note: candidate function
        >    71 | void Clear( EHistoryType eHistory )
        >       |      ^
        
        Change-Id: I7ad65d72be2c59da0ad6deaadefebf9662571433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152637
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [436f3f8eb5b45620842351a1f29ba49571043515]

        tdf#38742 - Start Center: introduce push pins to favorite documents
        
        Change-Id: I879e4d93e1da222d9acabb776552ca1cf819574b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152136
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-06-06  Justin Luth  <justin.luth@collabora.com>  [026924b192031769449814b9166a7b8d37c869f8]

        tdf#153040: unit test
        
        make CppunitTest_sw_core_text \
            CPPUNIT_TEST_NAME=testDropdownContentControlPDF2
        
        Still wrong/poor with this unit test:
        -wrong font for rich/plain text content
        -slightly offset (shifted right/shifted down) placement
         (tested in Linux Evince anyway).
        
        Change-Id: I586d46eaf5cdf9fbf44a6913f295c440240d180a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152634
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a6041b49b9ced911682973be5522df3190f6baa7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c366e74f9df3dec75df5b6bb21297166599fbf1b
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            + Add comments submenu
            
            Change-Id: I465ea7c0518272e08f5af403f7502a1d10043b5b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152632
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5b18167850dd7a174d6f1d275f11299be95716ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0aef8c7bd50b6f82a196358584fabc91ebd64795
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I0c8d979b42860c04d93b4ad6085bf41ac1aa5f0f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152631
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9fc380d24da8ae055a9ca94eaa8fbaeadfb2e306]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 269d7afe0492c2e438c328de95de3ed445809260
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I3b299d9d26fdf97b7ebc017f18af3624e6256e1e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152619
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [ee2d846031e9921c61ff1ff8399ed1fe9106c5fc]

        Drop unneeded indirection
        
        Change-Id: Ie837aec7e2b4b87665cc98200d38329ec2155c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152614
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [496bd45f1e2f4c3dc90448d1adc81c5c29349f58]

        Drop duplicating function
        
        Change-Id: I15f6aea604f5bc05ae8e2e13c1e79003512b707f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152613
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [4e6c636433f7b1e4e3580fa99cbff2487e53f984]

        Restructure SvxLanguageBox::SetLanguageList for clarity
        
        And extract sorting and removing duplicates to a separate function.
        
        Change-Id: I57ed8d3960eefb8df8128cdb461a0621ed998bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152612
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Stephan Bergmann  <sbergman@redhat.com>  [6f33d21fdd85f49cd15b2770c6557e87f05b7dba]

        Adapt compilerplugins to Clang 17 trunk "Remove llvm::Optional"
        
        (<https://github.com/llvm/llvm-project/commit/397f2e9ebee8d8e45547e90dd05228d7f965df67>)
        
        Change-Id: I51acda5951f8250d1a1b47e1c2612199ae7338a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152618
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-05  Stephan Bergmann  <sbergman@redhat.com>  [c2c1e6a27293bba770b07efb0a4d64ba4b6150fb]

        Latest VS 2022 Preview is 17.7.0 now
        
        ...while latest proper VS 2022 is 17.6.2
        
        Change-Id: I300812fc9f5d380fb2c288bfa19b74502a5b0e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152620
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [367f26ebf0f2be0c0c0ebeab1e14ee26960675e3]

        avoid some UNO querying
        
        Change-Id: I5fa793ab979221252f66bdd38e6950c06a66b00a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-05  Regina Henschel  <rb.henschel@t-online.de>  [6c49886ab46c53398d74610b264e5edb0332a059]

        tdf#155549 MCGR: Recreate 'axial' from symmetric 'linear'
        
        When exporting a shape with an axial gradient fill to OOXML, it is
        converted to a linear gradient with multiple color stops. Versions
        before MCGR had recreated it as axial gradient on import from OOXML.
        But now LO is able to handle multiple color stops and so the linear
        gradient from OOXML is imported as linear gradient in LO.
        
        When such file is then written as ODF, the multiple color stops are
        in elements in extended namespace and versions before MCGR do not
        understand them. They show only the first and last color (which are
        equal) and the gradient is lost.
        
        With this patch LO converts the linear gradient back to an axial gradient
        on export to ODF. The exported axial gradient is rendered in a version
        with MCGR same as the linear gradient when opening the OOXML file. The
        difference is, that versions without MCGR now render an axial gradient
        with two colors.
        
        Change-Id: I2b416b4cdca75d8327107a4f259d63c2e6e97ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152574
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-05  خالد حسني  <khaled@libreoffice.org>  [6014fd047a62e1a002cc27334e39e1d2e54e342f]

        Revert "tdf#155676: Use colon in FontsUseWinMetrics config key"
        
        This reverts commit a38e1537cd06367783a43cc8d3b0e8d674b6e142.
        
        Change-Id: Ic72f1acb7e38209e9b87a8fe80a39acb1eeacfe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152547
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [bdad6055eb32fa6e7ee9e43cf1a54edbd2318fcd]

        tdf#153972: sc: Add UItest
        
        Change-Id: I7479be100d2c0abd9484a4095b3b2acf958beffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152616
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [e855481ead996a3b8270fae91bd23d6c8d75ef25]

        Avoid duplicates in Edit Modules language list
        
        Since different services/categories may add same languages, they may
        become duplicated in the resulting list. Avoid that using std::set.
        
        Change-Id: I9a58341212a4f1190754683b032059408a2653cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152611
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [2c7e2fa0cbf079e659b29a94e5a0a07f94c98a28]

        Use UI language for UI list sorting
        
        Change-Id: I1fd4babe3d577d785015f921e5c8ed95ad4e8fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152610
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Stephan Bergmann  <sbergman@redhat.com>  [436c879b355f2cde763b0386df92e0d3708180a7]

        Missing include (for std::find_if)
        
        Change-Id: I91d70d72ea6cb18ed4fde2f3b3a3d037668767e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152615
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0d49beb1b9b875e82c98439587fcf37b56050b4]

        tdf#132026: sc: move UItest to CppUnittest
        
        Change-Id: I4a8b40c1618421a0c1775d0585c53d90196f0937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152608
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [8149e903db501511193761eebca1640407ad52dc]

        Introduce weld::ComboBox::insert/append taking a single ComboBoxEntry
        
        Change-Id: Ia777daa8ced1df43dd49280ee30269de2b191237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152609
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Bogdan B  <buzea.bogdan@libreoffice.org>  [2f5bffafe4f653aa4ce86f7a27305587680cba58]

        tdf#152431 Fix line count resets to zero after 65535
        
        GetLineCount was a sal_uInt16 value, that allows only 65535 lines to be
        counted. This is changed to sal_Int32 and also the underlying data type
        for the lines number is changed from sal_uLong to sal_Int32, but not for
        pages number. With this change, the maximum possible line number is now
        increased to 2^31-1 = 2,147,483,647.
        
        Change-Id: Ibee2d24e638204133f0ef085564016543f73d351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143173
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e86a0236e69d76769b91f96d71fe852b91c5db6e]

        lok: callback to send the updated theme palette when theme changes
        
        The callback sends the updated theme color palette when the theme
        changes or initially when the view is registered, so the client
        should always have the up-to-date theme color palette stored, so
        it can just show the color picker with the theme at any time without
        the need to call the server.
        
        Change-Id: I7cceccc46c2fad23ba89e6d3f3643e37f8dab292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152589
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c4c040d2ebc4371a706c762e7e6707875c43535]

        svx: extract theme color generation into ThemeColorPaletteManager
        
        The generation of theme colors generation code is moved to the
        ThemeColorPaletteManager class, so it can be reused.
        
        Also change the GetThemeColors return type from std::vector<Color>
        to std::shared_ptr<theme::ColorSet> as we can now safely do that
        and simplifies things.
        
        Change-Id: I4a54bff889a1f97cb1e30467188dc69e07e8c518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152588
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [adce63eb131f0b20a1d72797d92f07efcee75ec4]

        sort row-range-styles
        
        which reduces the amount of data-movement we do in the following loop
        when inserting into the sorted_vector.
        Shaves 2% off the load time of a large document with lots of styles.
        
        Change-Id: I8df4cc35edcc212613068af108b136c2d5acd219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152600
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-05  Miklos Vajna  <vmiklos@collabora.com>  [01ad8ec4bb5425446e95dbada81de435646824b4]

        sw floattable: fix lost tables around a floating table from DOCX
        
        The DOCX file has 3 floating tables: the first one is immediately
        followed by a second one, and the second one also has an inner table.
        
        The problem is that somehow dmapper thinks it's fine to merge the two
        outer table together, than the inner table invalidates some of its cell
        start/end references, so at the end the outer table conversion fails,
        which means we only have 1 table, not 3.
        
        This is a bit similar to commit 1c99616f86f7d5b83b91edc225fc95fec227d710
        (sw floattable, crashtesting: fix PDF export of
        forum-mso-en3-26783.docx, 2023-05-02), but here fixing the problem at
        the dmapper level sounded too complex. Instead inject the text node
        that'll serve as an anchor point at a tokenizer level.
        
        With this, the DOCX version of the bnc#816603 bugdoc (the one that
        started all workarounds in 2013) has one less overlapping table, but it
        still has problems.
        
        Change-Id: I54307b4c554da51bb55287e61bca700d8343d11c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152599
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-05  Miklos Vajna  <vmiklos@collabora.com>  [5841f73d516201576b1841c38fb3eb2a9c7295ea]

        xmloff: prefix members of SvxXMLListStyleContext, SvxXMLNumRuleExport, ...
        
        ... XMLConstantsPropertyHandler and XMLTextMasterPageContext
        
        See tdf#94879 for motivation.
        
        Change-Id: I739c9d4f7e551f84e7a55c6c5eb5109af596f055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152598
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-05  Khaled Hosny  <khaled@libreoffice.org>  [a38e1537cd06367783a43cc8d3b0e8d674b6e142]

        tdf#155676: Use colon in FontsUseWinMetrics config key
        
        The use of comma breaks editing in Expert Configuration dialog, so users
        effectively can’t use this.
        
        After editing
        
        <it>Celticmd,1571,-567,1571,-547,2126,559</it>
        
        becomes
        
        <it>Celticmd</it><it>1571</it><it>-567</it><it>1571</it><it>-547</it><it>2126</it><it>559</it>
        
        Using colon instead of comma seems to fix this.
        
        Change-Id: I4bba26fe9d94a33e62a0d34c3324daae0845c30b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152597
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5ec593ac096395c9915e16acc1a2699432d10af5]

        Update a11y check after quick fix actions
        
        Change-Id: Ie2f9a38ece130bc0cdafedf2c188c4c755233eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152501
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1f09bab0d033953542d17987e1de56cebfa3497b]

        tdf#155504 Add "Fix" function to shapes
        
        Change-Id: I9494207b0bcdf121034f79d936aeadd95cecdf23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152494
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81f9e88e7237f54c636a018b413192f7fdefbaca]

        Fix typo in code
        
        Change-Id: Ie25dfed8d3178f71256b19d9ec3247dff6d0c704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152593
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-05  Khaled Hosny  <khaled@libreoffice.org>  [1263873edf86ce223ee54ecd93297273ac3b0e9f]

        tdf#155297: Use usWinAscent and usWinDescent for B Nazanin font
        
        Its hhea.ascender and hhea.descender metrics are too small, but it does
        not have USE_TYPO_METRICS bit set. Since usWinAscent/usWinDescent are
        equal to sTypoAscender/sTypoDescender, we can use the former.
        
        Change-Id: I638fa81483365f8c44278ee13ad57cd8cf8d8769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152595
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-05  Colomban Wendling  <cwendling@hypra.fr>  [8698b354ca9cd3b48aee513dd1564e46ca513261]

        gtk3 a11y: Consolidate reporting accessible name
        
        Just like in I61c4d8d4713b2b82ebb40d9de2a8a773405591ba, avoid the any
        assumption on what the parent would do in its own implementation, and
        return ourselves when we mean to.
        
        The case of AtkObjectWrapper::get_name() is actually currently fine,
        because AtkObject::get_name() does what we think it does, and
        GtkWidgetAccessible doesn't override it, but it's safer not to rely on
        those assumptions.
        
        Change-Id: Ib500d8efa8501206da66c3cca4f6b93bd426cb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152457
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-05  Colomban Wendling  <cwendling@hypra.fr>  [ac643f1ae48bae7af6e7c0a5cc5a8dc83beac49b]

        gtk3 a11y: Fix reporting accessible description
        
        AtkObjectWrapper::get_description() sets the AtkObject::description
        field and chains up to its parent, expecting it to return that member
        to the caller.
        
        This is a questionable assumption, but that's what AtkObject does.
        However, since f3b0a95f9c2f85604808c21485e46e43aebbbfed which fixed
        tdf#150496, the direct parent is GtkWidgetAccessible, not AtkObject.
        And the assumption about returning AtkObject::description doesn't hold
        then, because GtkWidgetAccessible short-circuits the call if it can't
        find the associate GtkWidget, which doesn't exist.
        
        To fix this, return the member directly when we set it, but leave it
        to the parent if we don't have anything better in case it could
        actually do something useful, and because it's customary.
        
        Change-Id: I61c4d8d4713b2b82ebb40d9de2a8a773405591ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152456
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [07af51d62d84bb843679e086f5f29833cd1359a1]

        Use getXWeak in canvas
        
        Change-Id: I51b4c20eadc594057d5384bff51b4547da86129d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150837
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-05  Julien Nabet  <serval2412@yahoo.fr>  [f97a7b965be154824e108802b386e3132b0a237a]

        Simplify vector intialization in svx/svdmodel
        
        Change-Id: Ieaed80e4621084baf531b794323b2742ccd80310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152594
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-04  Hossein  <hossein@libreoffice.org>  [af27b57521075b35234daed4a6a7b554ed434df7]

        Rename function to SetMetricValueAndSave
        
        Rename the function, remove prefix and suffix
        
        Change-Id: Iaca0541d15a9162f11f8461892bf4c4454c9d674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151843
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [23f918ef6a542cc5f473f6c9bb5897ce5be9dd06]

        Use getXWeak in lingucomponent
        
        Change-Id: Icd70dd656d847f595cc1325ed0decb4941a82cde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150857
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e2360bfd6263dace3c0c441b78537c214687656f]

        Use getXWeak in connectivity
        
        Change-Id: Id301a9321f77e5ccc1269a3b677e9faeb19a4011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150841
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [c6f819836197d519153f9bc6775832cb0435eaf6]

        Use getXWeak in reportdesign
        
        Change-Id: I5d7c6b4b3d9440c6ae63a133e1b7d1374fa61063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150861
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Khaled Hosny  <khaled@libreoffice.org>  [45f6b03349b2626c5e75008bccd4e094f96e2769]

        Fix ccache cache size detection
        
        I have ccache 4.8.1 and it reports:
        
        (/home/khaled/.config/ccache/ccache.conf) max_size = 30.0 GB
        
        With a space between the number and the unit and the configure check
        with then see a unit-less 30 and will warn:
        
        ccache's cache size is less than 1GB using it is counter-productive: Disabling auto-ccache detection
        
        Change-Id: I12bad9204feddfe06be7207d9367586da871a5e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152592
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [7157cf5dee03a8a62033025521a68eec2a08d1f4]

        Use getXWeak in writerfilter
        
        Change-Id: I3e0e68c44750f30bd1998c79dc74a13f2c9ade9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150886
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [4129fca3739090651a9ffb11b35245e09816556f]

        Use getXWeak in filter
        
        Change-Id: I9854e28a4c577fae71bfc7e4bbaaadbdbce08684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150850
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [b00c351f0466c65ba51e980d8554e09efe0b7bd8]

        Use getXWeak in unotools
        
        Change-Id: I61ae9f11c3017442ac7461ca57f5625d1687fc68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150882
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [4900217e74e29c8e19c9a697883c21cbd50c9dbc]

        Move uppercase to SubStr ctor
        
        Change-Id: Ifeeaead20e3ad37705fea04a6c3b9efa4339ddc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152543
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cc6db9f418cae422a4733163f85801c5a14f47c8]

        sw: border and background theme color support for multiple props.
        
        This adds support for theme colors for multiple properties that
        are stored in SvxBoxItem and SvxBrushItem / XFillColorItem. For
        those items the ComplexColor member variable was introduced.
        
        The UNO properties for the colors are added.
        
        The properties with the added support includes paragraph border
        and background + styles, page border and  background, frame border
        and background + styles.
        
        The ThemeColorChanges has been extended to support changing the
        colors for those propertes.
        
        Color picker and tab pages have been fixed so they pass or set
        the theme color properties to the items.
        
        Change-Id: Id27272f5c4a448703a62a759d829e8a9540066e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152397
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-04  خالد حسني  <khaled@libreoffice.org>  [f2b270e79016097077bd49c0ae4ac2b8762dc91b]

        Revert "Fix ccache cache size detection"
        
        This reverts commit 70fd835b4cf75e386ee115c705241a4059fb68a8.
        
        Reason for revert: cache_size_kibibyte is the current cache size not the maximum size
        
        Change-Id: Idca3f7f3af9d2d6f20a50cb8360754dc63729726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152542
        Tested-by: Jenkins
        Reviewed-by: Khaled Hosny (خالد حسني) <khaled@libreoffice.org>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [83eee0095c337e454acd5368f70855e34ec4a174]

        ScUserListData::InitTokens can't produce different splits
        
        ... for the same input, because ScGlobal::cListDelimiter is a constant.
        This means, that the copy ctor and assignment operator can be default,
        and ScUserListData comparison can be simplified.
        
        Change-Id: I500892ab592fd0dd24550c5189151f670efed4d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152541
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [7bbec0dfaac7b4a579c963e0724f5355da2b8df8]

        Simplify a bit
        
        Change-Id: Iaea9a425fc93adc716bdb4944244a14175cf7538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152540
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Julien Nabet  <serval2412@yahoo.fr>  [e7b1f93cd681e2d0094f5937f4132aa4e780ab9e]

        tdf#71096: xlr filetype not associated with Calc in Windows
        
        Change-Id: Ifb9f74f2bd1532ebf364a3d554d303c1209393cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152360
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [182974354e4536af568dfb05a7400e48a2fe1032]

        Optimize ScAppCfg::ReadSortListCfg
        
        Do not initialize defaults when using custom user list.
        
        Change-Id: I8428a20b65182011a25325f0b7298ea51998346b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152587
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [1fa085f223761b8dcd7e7ac592eb70450a774543]

        Simplify ScUserList, don't use unique_ptr.
        
        Change-Id: Idd0ce7bfff115a3b762e963dd6cea7927c78e295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152586
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Julien Nabet  <serval2412@yahoo.fr>  [ca595a7d7e35ca814e4eb6cb5d7afbc88f85c850]

        Remove unused starmathdatabase::Identify_Color_HTML
        
        Seems to be unused since 88c343b50a1de197394e3e22bf82ff455386a80b
        "Corrected my previous mess on mathml export with color export 2.
        
        Now only exports HTML4 colors and others are treated as #RRGGBB.
        Now mathml can import #RGB colors.
        "
        in 2020
        
        Change-Id: Iac006383146afaa62775e6e76fa203925dce51d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152585
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-06-04  Julien Nabet  <serval2412@yahoo.fr>  [97710bbf1df975e896839cd78a34bdab7be7622a]

        MathType::HandleNodes: SmNodeType::Expression does the same as default one
        
        Change-Id: I0b7b17bf93470ac07f53c656f91f12b1cec4cd7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152584
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-04  Julien Nabet  <serval2412@yahoo.fr>  [7932427a39e684d78f2108d14660288a46f42df9]

        Related tdf#155630: deduplicate in starmath/visitors (2)
        
        Change-Id: I86e629260c5f25a67627589f5b33edc939aa1dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152583
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e0c7d7bc511c90e820adaaebb14ca8175364371d]

        tdf#151987: clean default list before using non-default one
        
        This restores the code that I had dropped inexplicably in commit
        8810812e58f1b014d3156235c1ab5a2d6c73c828 (tdf#132145: Synchronize
        ScAppCfg with configuration, 2021-11-29).
        
        Change-Id: Ie0215c9296d9cf9fcd75ed5b08218af9900eadb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152579
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-04  Julien Nabet  <serval2412@yahoo.fr>  [befc6ac8e20863c913da0fd0bac2fa26bab1b025]

        Related tdf#155630: deduplicate in starmath/visitors
        
        Change-Id: I331ce6d2e24e395a1c85789cdc4bd1f973287027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152580
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7b84152bdc580bd7277b96a9bacf63c51e0afa0c]

        Fix typo
        
        Change-Id: I224ba72073d77a0c16ed0669252af7b16fb99d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152582
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-03  Julien Nabet  <serval2412@yahoo.fr>  [df6e819a8f76f927bd7a568a95a535299e795a06]

        Remove unused SmStructureNode::SetSubNodesBinMo with plain pointers (starmath)
        
        and keep the remaining one which uses unique_ptr
        
        Change-Id: I0e4e4aff5c202897a27dfef97750c14c3c5736bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152581
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-06-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [698982c10eec667e4861b1ec72ad871b4368f471]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5bb8d842bc4b232f9291f1d600b8cd05af202e56
          - Fix wrong string.
            
            Change-Id: I8d149d4894c026e94a666e4376afa8c79b68da78
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152537
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f93d503e01987db79500a7f89c780c0e00ece464]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fc809b0331c7399f7dd0acf88236fce9e9972e63
          - Mute L10n on <embedvar>
            
            Change-Id: I43a4ff2c30934d65b34ea53983111d0ceef1b850
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152536
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [86630bc0245654533a1f6e6713c39dd401a15bb4]

        perf: use lighter weight png generation for iconview
        
        before:
        
        |--9.50%--JSDialogNotifyIdle::Invoke
        |          |
        |          |--9.33%--JSDialogNotifyIdle::generateWidgetUpdate
        |          |          IconView::DumpAsPropertyTree
        |          |          lcl_DumpEntryAndSiblings (inlined)
        |          |          |
        |          |          |--8.99%--extractPngString (inlined)
        |          |          |          |
        |          |          |          |--8.21%--GraphicConverter::Export
        |          |          |          |          Link<ConvertData&, bool>::Call (inlined)
        |          |          |          |          GraphicFilter::FilterCallback
        |          |          |          |          GraphicFilter::ExportGraphic
        
        after:
        
        |--7.50%--JSDialogNotifyIdle::Invoke
        |          JSDialogNotifyIdle::generateWidgetUpdate
        |          IconView::DumpAsPropertyTree
        |          lcl_DumpEntryAndSiblings (inlined)
        |          |
        |          |--7.16%--extractPngString (inlined)
        |          |          |
        |          |          |--6.84%--vcl::pngWrite
        
        Change-Id: Iae34c8bde3e0bbd075252de356f64557fd80c9ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152578
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-03  Jim Raykowski  <raykowj@gmail.com>  [4f69e1b07c12ebd8c3655f3205bff143d1ee1a1b]

        tdf#153721 SwNavigator: fix chapter move
        
        Fixes move chapter up/down regressions introduced by commit
        e27b936fe864cdd2753470e0fef1e3cb1f891555. For regression details please
        see comments 14 and 16 in the bug report.
        
        Change-Id: I0a57483fae51656c89e8b4f3711d8057174517e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152347
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-06-03  Caolán McNamara  <caolan.mcnamara@collabora.com>  [666925f2ab06e690c41c470713dc83f2d752bfb7]

        perf: use freeze/thaw around block insert of multiple icons
        
        into the style preview widget in the tabbed view
        
        |--1.67%--StylesListUpdateTask::Invoke
        |          StylesPreviewWindow_Base::UpdateStylesList
        |          weld::IconView::append (inlined)
        |          JSIconView::insert
        |          |
        |          |--1.58%--SalInstanceIconView::insert
        |          |          |
        |          |          |--1.19%--SvTreeListBox::Insert
        |          |          |          SvTreeList::Insert
        |          |          |          SvTreeList::Broadcast (inlined)
        |          |          |          SvTreeListBox::ModelNotification
        
        Change-Id: I1c1058324a056e7c8fb42f31c5b4919fcc5870e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-03  Justin Luth  <jluth@mail.com>  [3eb90b3370ca0284fdbf09f37d7dc63e5d158be7]

        tdf#134114 writerfilter: pass on AllowOverlap to graphics
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf134114_allowOverlap
        
        The unit test has terrible layout after a round-trip...
        
        Change-Id: I448af1c6b0c5135eb6d41dd6aa0c4bf00506ebbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152572
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-03  Szymon Kłos  <szymon.klos@collabora.com>  [d8b834a750a284ecd04cac1f4de4cb9cbf05c42c]

        Styles preview cache cleanup on exit
        
        Change-Id: I28929d4137008ebcca1733837d0b2112b6859a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152563
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152576
        Tested-by: Jenkins

2023-06-03  Szymon Kłos  <szymon.klos@collabora.com>  [5ad502af9cf3d49457082a12d36f8159b6c4ca11]

        Styles preview widget should cache images
        
        Change-Id: I3ee370e5d3ef4227681c4a973ac6f24f9aa241e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152556
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152575

2023-06-03  Julien Nabet  <serval2412@yahoo.fr>  [c50e4b25b2eb278685698182e2a4b541739f2d42]

        Simplify a bit DatabaseObjectView::fillDispatchArgs
        
        Change-Id: Ic6d4c80813286d6b5dbe33dc0289d0f0d9cedfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152569
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Lionel Mamane <lionel@mamane.lu>

2023-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a5847b3716ac64ad422f24164c0b765610ffbd7]

        remove unnecessary ScPatternAttr copy
        
        slightly speeds up loading document with large number of patterns
        
        Change-Id: I1b82145fb0f8a62da0d5a46a43594f7085ce2c22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-03  Justin Luth  <justin.luth@collabora.com>  [7daf830830609cbb13a01ae55634187718c84d8a]

        tdf#153040 sw content controls PDF export: output listbox entry
        
        This fixes a 7.5 regression/wrong implementation.
        
        Prior to 7.5, content controls were just exported as plain text to PDF.
        Now that the content control is exported, the selected entry in
        the list box was not being printed - just a big hole in the text.
        
        Fixed by informing PDF of the selected entry.
        
        TODO: the content control starts too late
        (a somewhat wide space at the front),
        and ends too soon (the last portion of the text is cut off).
        
        The unit test for the TODO will cover this case,
        so skipping that for now since I found no examples to follow.
        
        Change-Id: I1412a57efc070010c6d0d0a37f48d63699b085b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152566
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [00a44a080539fa5d7cbd9cc21442b500b66164ef]

        tdf#155652: use UI language for language service display names
        
        Change-Id: I7a671e3f8db484b04901bd2360aaab4cde36a72c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152565
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Baole Fang  <baole.fang@gmail.com>  [0450c7177f61ba5be15f7b4175b9fb5e89f850ae]

        tdf#132026: Fix selection in text cell
        
        Change-Id: Ic2bf869efa198cba83d1b781b419c3a9e0e606f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152356
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [17339a6e1f090972781af94e96f6a39408e49c88]

        Simplify a bit
        
        Change-Id: I0d03a1c68cec9ff0edc2c14f3837054a2c693a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152534
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Cip Cipricus  <cipricus@gmail.com>  [e7c9f78e4ce5ab5ecd3ccfd06fef71f10f5df8db]

        tdf#155087 Autocorrection in Romanian applies to existing words
        
        Change-Id: I04bc44a4a297f9d0fdccc89a279ff5e11976e561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151770
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Paris Oplopoios  <paris.oplopoios@collabora.com>  [53d5cc538d9c274cc4d7dfe38229f0f54706b403]

        Add Calc view separation for tiled rendering
        
        Calc now uses different colors based on the current view theme to paint
        tiles when using tiled rendering
        
        Change-Id: I1ca84371141ff026ad49ec362518ca13c59c7c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152137
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        (cherry picked from commit f4eb56b8b9ff3492e0a02fb76eb4ea7b851f4774)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152440
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-06-02  Michael Stahl  <michael.stahl@allotropia.de>  [710af7d183370ca6fdd2699ea9f4550d9e53918a]

        tdf#152983 sw: layout: fix crash in SwContentFrame::Cut()
        
        Surprisingly, SwContentFrame::Cut() is called in a situation where the
        frame is not connected to any SwPageFrame yet - it is in a follow fly of
        a fly chain that is anchored in a footer, and SwFlyFrame::ChainFrames()
        removes it.
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: Iad84b7b422126e050493dc3b181d47c4dca2fae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152510
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-02  Baole Fang  <baole.fang@gmail.com>  [69a3bcdaa54700a372151af52ccfbb0deed9db45]

        tdf#43157: Clean up OSL_FAIL
        
        Change-Id: Id4472bd810263ca842d14af6ad4a1359c002fb6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152344
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Dr. David Alan Gilbert  <dave@treblig.org>  [7bec1689fcbe9102aa220739b6113118d9a8dd1f]

        tdf#145538,tdf#147021: qa: range based loops
        
        A bunch of range based loop changes in various qa
        sections that also take out about 1% of SAL_N_ELEMENTS
        
        Change-Id: I8ef000e9aa400cd8363b48f6175f6ab258cefbd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152422
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Heiko Tietze  <tietze.heiko@gmail.com>  [f8036f2f5238adf227d0ffa646e503f0446bb37b]

        Resolves tdf#155200 - Don't scale overlay images in start center
        
        Thumbnails don't change their size so overlay must not too
        
        Change-Id: I83ff2bb60ec619686b583180ebabe194c4a77b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152193
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-06-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4018f1f3fe4599aac3e908b1d594234a84c406d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c34c4d0e85fcbccf9d236a8c7a11cd16b3aecebe
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I01192f8fdf11a2a6571ad8a33bb44afc9eff6770
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152557
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [72869f559021ced673465cb9aa82e461ecaafc91]

        tdf#155647: Pass XFlatParagraph by normal Reference, not WeakReference
        
        Since commit a7ce722b476c4bb0c9a113ae0c2759181edfe48f (tdf#155232:
        drop m_aFlatParaList from SwXFlatParagraphIterator, 2023-05-13), the
        instances of XFlatParagraph are not cached in its iterator. Hence,
        the instances created in GrammarCheckingIterator to pass to AddEntry
        got immediately destroyed upon the scope end, before the checking
        thread (where weak references were passed) had a chance to create own
        hard references. Then GrammarCheckingIterator::DequeueAndCheck found
        that xFlatPara was empty, and exited.
        
        Just pass hard references there. The iterator was passed to the thread
        by hard reference in FPEntry anyway; and so, the use of weak reference
        to flat paragraph objects provided no benefit, when the iterator kept
        hard references.
        
        Change-Id: Ib56652d88b9a5c6f20aa3d70fed18f8be0d3a3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152554
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a5c1c674e031087ef0516cebac049341dcdd2fcf]

        Fix nullptr dereference
        
        Seen e.g. in builds where no grammar checker was available (like
        bibisect, or own builds), and LanguageTool is enabled in its page,
        and then enabled in Writing Aids options page (Available Language
        Modules list) in the same session, without program restart.
        
        Change-Id: I5ac007ec5e1dfc860085bfd3f95aa61a737ec449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152529
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Regina Henschel  <rb.henschel@t-online.de>  [8aa623714fd36cf8303ab3bdef0f26db7e69a07c]

        MCGR: Use tryToRecreateBorder too for transparency
        
        This is similar to 'Use tryToRecreateBorder for better BW comp with LO'
        (see commit 8259a99f41367a1d8326c9157fe1902915715879), but now for
        transparency gradients.
        
        Change-Id: I1c2e11562fa998c364896d517f4ed3bfe92f6c15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152508
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-02  Miklos Vajna  <vmiklos@collabora.com>  [920e76f15b78398de62002e30002f4f8e0fee7c1]

        sw floattable: ignore keep-with-next for anchors of non-last split flys
        
        The bugdoc has a floating table that could split between page 1 and page
        2, but we used to put the entire table to page 2.
        
        What happens is that the anchor of the floating table had <w:keepNext>,
        which means the layout tried to keep the paragraph on a single page, and
        also with the next paragraph (but in this case there is no next
        paragraph, it's the last one in the document).
        
        Fix the problem ignoring the "keep with next" request, in case the
        paragraph is an anchor for a split floating table; unless we're the last
        anchor in the chain.
        
        This is probably consistent with the intent that "keep with next" is
        meant to control the anchor text and not the anchored floating tables.
        
        Change-Id: I387a2db5f5db013da7055686ae6b9d032b467266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152525
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-02  Baole Fang  <baole.fang@gmail.com>  [083975f9666e3dc6fd665dc0418e6c3130628359]

        tdf#90507: Prevent changing default style in AutoCorrect
        
        Change-Id: I3bc7d99daf49ff32d9d80fcbbb7538cc036bc279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151213
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [845054aa25b7cba1daa1ff30b142d549027299bd]

        WaE: fix more warnings I see with gcc-13.1.1
        
        Change-Id: I8f1087cb98991363ec78a21a90a55724ba3628ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152466
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152528
        Tested-by: Jenkins

2023-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [30391deaf6e1726450378bbe5d320bfbbd213abf]

        uitest: sc: check whether current row/column/table has data
        
        Since 41b991ea0cf3f8ce36cbdbf16b9c2c6d2bb16b5d
        "tdf#153709 Adapt message for Delete Sheet"
        when a sheet with no data is deleted the confirmation
        dialog is not prompted anymore.
        Adding this so the code in dev-tools/uitest/mass-testing
        can make use of it
        
        Change-Id: I5b9846982cffeb11d6bcded691255b96a98f5a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152303
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-02  Baole Fang  <baole.fang@gmail.com>  [730e6fa063fccbd12913362dd5d3c74ea14957be]

        tdf#131638: Fix text cell incorrect formula
        
        Change-Id: I086f077540f52c6ed5fb4df9f0ea64aa95aea152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-02  Miklos Vajna  <vmiklos@collabora.com>  [b111418f612a511b94d9b789a57fccf095c00f23]

        CppunitTest_sw_uiwriter5: fix build
        
        See
        <https://gerrit.libreoffice.org/c/core/+/152336/3#message-c6562aa5808e9430d518bb145015ed6260296312>.
        
        Change-Id: I8c45a5457fedbd3b9fecb6cef255f07655798d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152524
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-02  Stephan Bergmann  <sbergman@redhat.com>  [705768837912d38612ab2b06dba1ca491782b773]

        Cannot self-append OUStringBuffer via concatenation
        
        a5084d15e1b72e303e1628fbff84432036b014a9 "loplugin:stringadd in vcl" had dropped
        the intermediary sTemp, but which caused JunitTest_forms_unoapi_1 to fail for me
        once with
        
        > ==2657124==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x50c00086ca58,0x50c00086ca6a) and [0x50c00086ca48, 0x50c00086ca5a) overlap
        >  #0 in __asan_memcpy at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3
        >  #1 in char16_t* rtl::addDataHelper<char16_t>(char16_t*, char16_t const*, unsigned long) at include/rtl/stringconcat.hxx:80:9
        >  #2 in rtl::ToStringHelper<rtl::OUStringBuffer>::operator()(char16_t*, rtl::OUStringBuffer const&) const at include/rtl/ustrbuf.hxx:1765:14
        >  #3 in rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>::addData(char16_t*) const at include/rtl/stringconcat.hxx:195:64
        >  #4 in rtl::ToStringHelper<rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>>::operator()(char16_t*, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0> const&) const at include/rtl/stringconcat.hxx:207:101
        >  #5 in rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>::addData(char16_t*) const at include/rtl/stringconcat.hxx:195:88
        >  #6 in rtl::ToStringHelper<rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>>::operator()(char16_t*, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0> const&) const at include/rtl/stringconcat.hxx:207:101
        >  #7 in rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>::addData(char16_t*) const at include/rtl/stringconcat.hxx:195:88
        >  #8 in rtl::ToStringHelper<rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>>::operator()(char16_t*, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0> const&) const at include/rtl/stringconcat.hxx:207:101
        >  #9 in rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0>::addData(char16_t*) const at include/rtl/stringconcat.hxx:195:88
        >  #10 in rtl::ToStringHelper<rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0>>::operator()(char16_t*, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0> const&) const at include/rtl/stringconcat.hxx:207:101
        >  #11 in rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0>, rtl::OUStringBuffer, 0>::addData(char16_t*) const at include/rtl/stringconcat.hxx:195:88
        >  #12 in rtl::OUStringBuffer& rtl::OUStringBuffer::operator=<rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0>, rtl::OUStringBuffer>(rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, rtl::StringConcat<char16_t, char const [3], rtl::OUString, 0>, char const [3], 0>, rtl::OUStringBuffer, 0>, char const [4], 0>, rtl::OUString, 0>, char const [4], 0>, rtl::OUStringBuffer, 0>&&) at include/rtl/ustrbuf.hxx:378:17
        >  #13 in DoubleCurrencyField::UpdateCurrencyFormat() at vcl/source/control/fmtfield.cxx:1120:20
        
        and e.g.
        
        >         OUStringBuffer b("a");
        >         b = "b" + b;
        >         CPPUNIT_ASSERT_EQUAL(OUString("ba"), b.makeStringAndClear());
        
        would indeed easily fail with
        
        > equality assertion failed
        > - Expected: ba
        > - Actual  : bb
        
        Change-Id: I3108c18b7c941953a73b5731d9973914b7ba1fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152495
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-06-02  Marco Cecchetti  <marco.cecchetti@collabora.com>  [14b3ad0b4e5a540f436db3467f8a4051392f8479]

        lok: accessibility event listener for focused paragraph
        
        LOKDocumentFocusListener keeps track of the currently focused
        paragraph.
        
        Also includes:
        
        	Author: Andras Timar <andras.timar@collabora.com>
        	Date:   Mon May 15 22:06:10 2023 +0200
        
        	    fix unused exception parameter 'e'
        
        	    Change-Id: Ibfee099e4e9b724648d7500b9ebb4e8ab84989b8
        
        and:
        
        	Author: Marco Cecchetti <marco.cecchetti@collabora.com>
        	Date:   Thu May 4 12:11:53 2023 +0200
        
        	    lok: a11y: focused paragraph info sent to client
        
        	    For the currently focused paragraph the following data is notified to
        	    client:
        	    paragraph content, caret position, text selection start/end
        	    These data is kept as an instance state so the client can request such
        	    info at any time.
        
        	    Change-Id: Ic1a3be0d93472300b1b6a91fb0de5bad87c031aa
        
        and:
        
        	Author: Marco Cecchetti <marco.cecchetti@collabora.com>
        	Date:   Sun May 7 11:52:14 2023 +0200
        
        	    fixup! lok: accessibility event listener for focused paragraph
        
        	    It seems it was not a good idea using a unique_ptr as smart pointer
        	    for an instance of LOKDocumentFocusListener
        
        	    Change-Id: I8e6b0f48fee3c5db3c9b074a663f7f3fb96a601e
        
        Change-Id: I0fa400694f3129608228ade0b96e0b4e0aee87e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152488
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [8731701481de649a65d59e018d0ba0c381f670c3]

        sc: fix bug in GetPrintAreaVer
        
        it should return false when checking a non-exising column.
        Since ad2bc869bfe2d34bde7d42e10593db1c5ffccc2a
        "tdf#50916 : Refactor table1.cxx wherever there is column access"
        
        Change-Id: I01a53f5fec7e2029badc5c23c1e26fc0723ba0ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152386
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-02  Miklos Vajna  <vmiklos@collabora.com>  [15b126534b2dc8490d9ddda9baae76f2e87380f0]

        sw layout xml dump: extract SwCellFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about cell frames.
        
        Change-Id: I01c7af5a4ded579a38e78ca9c8218871e0a1d325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152509
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [7acc7660a752497a546263d28e82a2e8f61fd702]

        reduce memory overhead of AquaA11yWrapper
        
        we can allocate this internally, which reduces the number of
        heap allocations we need to do
        
        Change-Id: Id5298e70b6816cd65d8285ceea846dc8e9e4b39d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152489
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-02  Justin Luth  <justin.luth@collabora.com>  [3e6f4bbefaa4f4f83210970210aa7796aab7cf03]

        tdf#154751 writerfilter: last enabled strikethrough wins
        
        The problem is that multiple strikeout character properties can
        be defined for DOCX, but it is implemented using a single property
        in LO. If the last definition was "not *strike" then all strikeouts
        were disabled.
        
        Instead, if any strikeout is enabled, the last one overrides the others,
        but cancelling doesn't negate a previously defined strikeout.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf154751_dualStrikethrough
        
        Change-Id: Iaf17380061a0b37db4bc7a87c703e81f0181bcc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152514
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-06-02  László Németh  <nemeth@numbertext.org>  [472abf99a4d90d7a53316394a2e51a26b7e62345]

        tdf#155341 sw tracked table column: add insertion
        
        All the inserted cells get a dummy redline to store
        the change tracking metadata, setting also the
        HasTextChangesOnly bit of the table box to FALSE.
        
        Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column".
        
        Change-Id: I55f5a44ac0ec040993a100156665f116355c235a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152336
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-02  Caolán McNamara  <caolan.mcnamara@collabora.com>  [389a8d52d9961f89c0b2847b30ee1ca59a8fdc80]

        Related: tdf#122081 null-deref of SwFootnoteFrame
        
        load doc, ctrl+end, ctrl+home, ctrl+6 enter 29, return, wheel scroll
        down 7 or 8 times and this null-deref
        
        Change-Id: I1963a89e3223de89f3414e435accd8d8ebfe80a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Martin Srebotnjak  <miles@filmsi.net>  [30aac756bef3170101194d94070fd0975b781227]

        Update git submodules
        
        * Update translations from branch 'master'
          to 3f048c8b256ce247546dd78472926b65a332edca
          - Updated Slovenian translation
            
            Change-Id: I3e4ff509f47ce76b9d47847d9b77fbf8860a5cce
            
2023-06-01  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [0b5c0d9e9d6c71d3531a7e1020af1753a50e873e]

        tdf#143877 EMF+ Implement EmfPlusDrawCurve with cardinal spline
        
        Change-Id: I98d30b2a8ba63fdddc08668f453c5f0feeb452db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152288
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [0fff72154d0dbb44e09546ff59f8a5ec288dfd2e]

        Resolves: tdf#155425 turn off overlay scrolling for color selector
        
        the overlay width is too close to the column width to easily select
        the colors in the column beside/underneath an overlay scrollbar
        
        Change-Id: I096a6f2414eb69f10a79a4a0591f3a210c6784de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152507
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [068f28aa67bf7a17b722b3342689c845dda533f7]

        Related: tdf#155425 use preferred_size instead of allocated_width
        
        the scrollbar might not actually be visible so has no real
        allocated width yet
        
        Change-Id: Id15af9e481b9971bf79f16da16581f820f8303d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152506
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1ae15fb6fdf7a1a537e51c4ed6973bb5d95a8ab0]

        resave with latest glade
        
        Change-Id: If9a61d218ccee6bb82adf533dc1932cb2dd46ad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Michael Stahl  <michael.stahl@allotropia.de>  [59987d3c77ec7dbf59fbea9f47cc226f4e8903f9]

        tdf#150606 sw: layout: leave follow SwTabFrame invalid in columns
        
        With the minimised bugdoc, on Undo, some 12 or so pages are created, and
        the end of the deleted table is shown in the document view.
        
        So first the last pages are layouted, and then once those are done
        layout proceeds from page 1.
        
        The problem is that on page 9, a table remains in the 2nd column of the
        section, and there is nothing in the 1st column and on pages 5-8.
        
        This is because ::CalcContent() is the last thing that formats the table
        on page 9, and it explicitly disables MoveBwd() for follow tables via
        m_bLockBackMove.
        
        That appears to be intentional but because it's already been there since
        initial CVS import it's unclear why; it might be based on the assumption
        that a previous column would have moved over rows from the follow table
        already.
        
        Try to encourage the table to try to MoveBwd() at a later time, when
        it's being formatted from the SwLayAction::FormatContent_() loop, which
        appears to help.
        
        (somehow regression from commit 723728cd358693b8f4bc9d913541aa4479f2bd48)
        
        Change-Id: I421525269948aa58888f5302e6db234c89230f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152485
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-06-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d7d2b172065f90aa2f61c0216f3722e868ae76a1]

        prefix aPreviousColor and aCurrentColor in SvxColorTabPage
        
        Change-Id: I631ce120d7a2825c6d170f4b25ffefdd155e04e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152396
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e6215c7233c0fb437a81b51c8a8a30bb53eef65f]

        tdf#153361 improve theme color generation in color picker
        
        The theme color generator needs to take color luminocity into
        account, so that the very dark or very light colors are properly
        shaded. Otherwise a too dark color will generate a too dark (almost
        black) color variant, or a too light a too light (almost white)
        color variant. However those colors aren't useful.
        
        Change-Id: Id803a8f6f1a79cbc822ed2d7faca9bec228c0188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152237
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c7b4d15c5c33e8ac05b054aa1d19751fb1b1275a]

        WaE: Py_SetPythonHome is deprecated since python 3.11
        
        not obvious how to replace it, so just accept for now
        
        Change-Id: Id3fc4c95a5cc60e078f06faaa024faa9c770de20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [9ff2b61876843584d6c4fb3cadda48089b8a84b7]

        WaE: -Wmaybe-uninitialized with GCC 13
        
        Change-Id: I69e0f28ab6f6a8a2c7181876735b128d39394b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152503
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [619d022fb0e01a2073b6c2635e2e8dc1c29162bc]

        take a copy of SwAccessibleParagraph::GetString()
        
        take a copy of this a11y and not a reference
        
        it is not guaranteed that listeners to the a11y events called by
        FireAccessibleEvent will themselves not call anything which could end up
        calling ClearPortionData which would leave rText pointing to old
        released memory
        
        seen in the wild with:
        
        ==15145==ERROR: AddressSanitizer: heap-use-after-free
        program/../program/libswlo.so
        	rtl::OUString::equals(rtl::OUString const&) const
        		builddir/libreoffice/include/rtl/ustring.hxx:952
        program/../program/libswlo.so
        	rtl::operator==(rtl::OUString const&, rtl::OUString const&)
        		builddir/libreoffice/include/rtl/ustring.hxx:1713
        program/../program/libswlo.so
        	SwAccessibleContext::InvalidatePosOrSize(SwRect const&)
        		builddir/libreoffice/sw/source/core/access/acccontext.cxx:1196
        
        and
        
        previously allocated by thread T0 here:
        program/../program/libswlo.so
        	SwAccessibleParagraph::UpdatePortionData()
        		builddir/libreoffice/sw/source/core/access/accpara.cxx:442
        
        with free of:
        
        program/../program/libswlo.so
        	std::default_delete<SwAccessiblePortionData>::operator()(SwAccessiblePortionData*) const
        		gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:78
        program/../program/libswlo.so
        	SwAccessibleParagraph::ClearPortionData()
        		builddir/libreoffice/sw/source/core/access/accpara.cxx:451
        program/../program/libswlo.so
        	SwAccessibleParagraph::getCaretPosition()
        		builddir/libreoffice/sw/source/core/access/accpara.cxx:1016
        program/libmergedlo.so
        	LOKDocumentFocusListener::updateParagraphInfo(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleText> const&, bool, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)
        		builddir/libreoffice/sfx2/source/view/viewsh.cxx:685
        
        Change-Id: I72c9894ca842b8f040b27481f0fd8d56542eb530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152486
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d3996db28d88d219a9a1acc98af0cc862ac3d704]

        tdf#155504 Add "Go to" function to shapes
        
        Change-Id: Ic1f39c65565f92ceb86e3b19d45aed7014b88e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152487
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-01  Khaled Hosny  <khaled@libreoffice.org>  [ef30d351da288b3513cfd30cb82bff7e0827fcb3]

        tdf#155623: Revert "tdf#155557: Fix drawing mixed direction underlined text"
        
        This reverts commit 99d22fd79c5532fd6c1b167996e1c27216b92469.
        
        Lets revert and figure out a less radical fix for the original issue.
        
        Change-Id: If3025d32019e953b7946ebe4209daf74efc5e15a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152490
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e899a75fc6dd600ea9992c851a42734b334122b6]

        Revert "Convert XFastParser into a normal C++ interface"
        
        This reverts commit 5e68d6cfade45f40b1ad46025a81afe4cb8dd337.
        
        Reason for revert: Seems like outside users have been using this API
        
        Change-Id: I8814cf1eb4f000eeb4cbbb5db9c282d001465993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [020d72fb85dac7a52eacb29731b8f2d536a2892d]

        WaE: SwNodeIndex GCC12 spurious -Werror=dangling-pointer=
        
        I see this with gcc 13 too
        
        Change-Id: I63aed9a3bdc5bec7f96474145fd2ba30156741cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Khaled Hosny  <khaled@libreoffice.org>  [737854f3c5131d3a64803edc0802dbbc07aa4405]

        tdf#153440: Fix font fallback for surrogate pairs in RTL text
        
        When checking for a font that supports the surrogate pair, code was
        appending code units one by one to string buffer and in RTL case this
        was happening in reverse order leading to invalid text and consequently
        failing to find any font that supports it.
        
        We now iterate over runs not individual positions, so the text of each
        individual run maintains its correct order regardless of the direction.
        
        Change-Id: Icf2e2aed56512bf907dc6b3c36f387a9e3ad497a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152481
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [29224bf7305ab8ba103be145effc8ac467ffcfd6]

        SwModelTestBase: simplify code a bit
        
        and rename reload method to saveAndReload to unify
        code and use it everywhere
        
        Change-Id: I7c0f4e8d2feb7a0f9ca28df4b6dddd7a11b2e57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152455
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [b6b28854c77731f7506b2551dc5dd47f798ca946]

        tdf#154174: sc: move UItest to CppUnittest
        
        Change-Id: I62e1e9a0dbcbea509d5d9a9b493c2484dc373854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152483
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2023-06-01  Miklos Vajna  <vmiklos@collabora.com>  [b64cd9c8e0498b8aecc49eba873d2a3fd3065a6a]

        sw doc model xml dump: show address of SfxBoolItems
        
        I want to know when a relevant keep-with-next pool item is read, but
        there are many of them, so seeing the pointer address is helpful.
        
        Change-Id: I5ff7654430a41eaea6c7b0cf722e34256cdd4d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152480
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6e2993e1a7a61d69717b3fcf93ffa52fa0f26ba9]

        tdf#153972 Fix color filter when cells have no content
        
        Change-Id: I9742fc0627c2311bfe4c067961e0feea476f1899
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151096
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [677ec236e7409681e04578c8501833792c5f8099]

        CppunitTest_sw_htmlexport: fix test after my previous commit
        
        In 6aec73de12a56a56b3ffd9bb86b559bf0609bf58
        "SwModelTestBase: drop mustCalcLayoutOf", I misread the code
        and thought that loadAndReload wasn't calling calcLayout
        anymore. Obviously I was wrong. adapt the code to do
        load and save without calling calcLayout and without reintroducing
        the mustCalcLayoutOf complexity
        
        Change-Id: I4d5619a0443e70bbec89c4513ab86a93d968646c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152477
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-06-01  Regina Henschel  <rb.henschel@t-online.de>  [28f0e847e4e9cebc43cdcf97b8212a70977f2b49]

        MCGR: Unit test for 'Use tryToRecreateBorder for...'
        
        Unit test for commit 8259a99f41367a1d8326c9157fe1902915715879.
        
        Change-Id: Iba3367fe42b5014b98cf575f53006fc09a79d6ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152428
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-06-01  Noel Grandin  <noelgrandin@gmail.com>  [5e68d6cfade45f40b1ad46025a81afe4cb8dd337]

        Convert XFastParser into a normal C++ interface
        
        There is no need for it to be an UNO interface anymore (ever since
        we started supporting dynamic_cast on UNO objects).
        
        Which means that XImportFilter2 also needs become a C++ interface.
        
        Change-Id: Ice2db0f098271bba32b199bd083b08cb8410ce93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152388
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [f15a6e1b1b186bf42e1ade05630d17841add2c46]

        Use OUString for filter
        
        Change-Id: I45c809cfd4ee9b1c6f479db1ad0a6bf2d479fed5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152473
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-06-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c1893df42567c260ca5fb069038d1a55616e7b7f]

        tdf#149598 - Remember window state of the format cell dialog
        
        Change-Id: Ie3b468c674a9a811a5359155cda1d96ed44e50fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152474
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-06-01  Caolán McNamara  <caolan.mcnamara@collabora.com>  [36ec021c6eafe80caefbedbbe674bd1ee0a9429a]

        WaE: WhitespaceToSpace() spurious -Werror=maybe-uninitialized
        
        vcl/source/helper/strhelper.cxx:366:9: error: ‘pBuffer[-1]’ may be used uninitialized [-Werror=maybe-uninitialized]
        
        I see this with gcc 13 too
        
        Change-Id: I3ddc5fadb9177827e6cd49f5b6366a79204e95c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152469
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-06-01  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [a5c1b749a89b662f9a136d774b3dfd5fbd639c50]

        tdf#154174 sc: fix input line to update to the repeated content
        
        Repeating the last text edit by Repeat, e.g. by pressing
        Ctrl-Shift-Y, the input line still contained the old content
        of the cell, and only updated to the new content after moving
        the cursor to another cell and back. Now the input line is updated
        automatically, and the actual content of the cell can be modified
        immediately by pressing F2 or clicking in the input line.
        
        Change-Id: Ia38b833ff77c75d37700715638aa71c7f1863e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152423
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-06-01  Laurent Balland  <laurent.balland@mailo.fr>  [811e67eb45b1fc97d8c8cc9509acb33267a51aa4]

        tdf#154131 Update UI
        
        Change "scientific numbers" to "scientific notation"
        
        Change-Id: Ic895fda8fb98d0307d05c4a540b4ba43079f8682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152405
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-06-01  Miklos Vajna  <vmiklos@collabora.com>  [e2f90d1d0e51c68dd01c9968cdb7a3bbb5658613]

        tdf#103869 sw floattable: fix lost table right before a section break from DOCX
        
        The bugdoc has 2 pages and 2 tables, one table on each page. The table
        on the first page was missing in Writer.
        
        What happened is that the floating table is anchored in the next
        paragraph, but that is removed (since it's the last one in the section,
        so no need for a "next" paragraph), which shifted the table to the next
        section, which was already a wrong anchor point. Then that next section
        (next page) started with a (floating) table, so a dummy text node was
        inserted at the start, which means once it's disposed at the end of the
        2nd section, we lost the first floating table with its bad anchor.
        
        Fixing the problem was a bit tricky, because
        DomainMapper_Impl::RemoveLastParagraph() is called before the text frame
        conversion would be invoked in DomainMapperTableHandler::endTable(), so
        we can't check if this last paragraph has something anchored in it, as
        it's too early. Instead, detect that a floating table will be created,
        and don't remove the last paragraph in this case, since we know that
        we're at the end of the section (that's why we remove the last
        paragraph).
        
        The export result looks OK, we keep the
        paragraph-table-paragraph-table-paragraph model correctly.
        
        Change-Id: I4612a15d0d1ad3fe527593a21a4120096790a33f
        (cherry picked from commit ba2f4ebc5343f3eca27baaaf27906be2e6486fcd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152472
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-06-01  Miklos Vajna  <vmiklos@collabora.com>  [4ee0aa2ebda0ccd61ea4e0da3caa07d5f9a72eb9]

        UITest_calc_dialogs: use oneprocess mode
        
        Execution time goes from:
        
        real    1m36,132s
        
        to:
        
        real    0m49,165s
        
        Also the same for UITest_conditional_format: 1m36,842s -> 1m14,630s
        
        Also the same for UITest_csv_dialog: 1m25,584s -> 0m59,205s
        
        Also the same for UITest_external_links: 0m27,881s -> 0m19,912s
        
        Change-Id: Iec462dd578956d3c62b8944de367e46bd3abe975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152464
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-06-01  Khaled Hosny  <khaled@libreoffice.org>  [99d22fd79c5532fd6c1b167996e1c27216b92469]

        tdf#155557: Fix drawing mixed direction underlined text
        
        The code here first unsets the underline style, draws the text, then
        measures the text size, change the text to two blank spaces, sets the
        measured width back and tries to guess how much space was added by
        justification, sets the underline style back and then draws again.
        
        I have no idea why it is doing it in this highly convoluted way, but
        this code goes all way back to the initial import. However, it currently
        fails to account for Arabic justification when the Arabic text does not
        have any space characters.
        
        Instead of trying to guess more how much width the Arabic justification
        adds, I’m removing this code altogether to let the normal drawing code
        handle the underline drawing.
        
        Lets see what will break.
        
        Update text expectation because we now do one-less drawing.
        
        Change-Id: I8158bd15370005a78b866c8192414e4b46af2727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152452
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-06-01  Khaled Hosny  <khaled@libreoffice.org>  [70fd835b4cf75e386ee115c705241a4059fb68a8]

        Fix ccache cache size detection
        
        I have ccache 4.8.1 and it reports:
        
        (/home/khaled/.config/ccache/ccache.conf) max_size = 30.0 GB
        
        With a space between the number and the unit and the configure check
        with then see a unit-less 30 and will warn:
        
        ccache's cache size is less than 1GB using it is counter-productive: Disabling auto-ccache detection
        
        Instead of relying on the human readable output, use --print-stats
        which prints machine-readable output and is available since 3.7 (thanks
        to Cloph for the suggestion).
        
        Change-Id: I69f994a07cfbf08b66a2010f9c99401881d4acf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152382
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2023-06-01  Justin Luth  <jluth@mail.com>  [a05dc1591ca9122056e95cb2801e7f924bb7ecdb]

        tdf#104704 tdf#145998 doc/rtf import: don't lose section page break
        
        This fixes a LO 7.5 regression from
        commit c37f62b71fa59917ef85ff98480dff18aa936e41
        
        That 7.5 fix focused on DOCX, and didn't realize that the doc/rtf path
        couldn't handle the same logic.
        
        Just reverting to previous behaviour for DOC/RTF for now.
        (It is too hard to find relevant documents because any document
        starting with a section break on the first paragraph
        [and there are MANY of these - an ODT default],
        and that scenario harmlessly matches this code path.)
        
        Change-Id: I82cfe10e217269448d38df0ca03ce6cae3536e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152467
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [74a306ef4aa425a5637c7c4766600de6c4bc504c]

        Fix typo
        
        Change-Id: Ie108cc69cfd0d0e2837de3f1d38329f578866bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152461
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c58ff5befa4c9704ab54f365811af4beeea384a8]

        Fix typo
        
        Change-Id: I9c58980de73dc2f00802f0d589d0c6fafe11d16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152460
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aad2ca8bd3986510b2331752d92958c96ec93f9f]

        Fix typo
        
        Change-Id: I4b877a06c1fc09fa866c29dc39cb9478a50581b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152459
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a2bb3dc8696e52b1bf4b0057e2a3fb349c6ca509]

        Fix typo
        
        Change-Id: Ifbf42470fdf11e072749ec6b7a86a5970f9a2d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152458
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [55b9419e541990fe4f96dd59a42359f86901ab3a]

        Fix typo
        
        Change-Id: Iaeeda3ce15e6765e914eb74c6b1cb0f0f8b6d6f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152463
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [006990b8d6337c232f0fe06fc284d83c44e6dc80]

        Fix typo
        
        Change-Id: I0dfd64a270a2b669bceba435c2e01472ecf277f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152462
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [66eabacb7c3618d2724470203d7e95c256334520]

        tdf#155611: SwFrame::FindNext sometimes returns a sub-frame of this frame
        
        This resulted in wrong split of the section frame, when the table frame
        was the last in the section, the split needed to happen after that table
        (i.e., at the very end of the section), and passing the table frame as
        pFrameStartAfter gave its last cell's subtable as pSav (i.e., the frame
        to move after the split). The first frame of the last cell (the one prior
        to pSav) got lost from the layout, and wasn't destroyed when SwRootFrame
        was destroyed, and then it crashed referencing destroyed root frame and
        view shell.
        
        Change-Id: I1a539818aa890f65e961f4185ce50916ce7e4e4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152454
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [192167f635e87e1acee9c31d1153285479dc04ab]

        Simplify a bit
        
        Change-Id: I3ba0187e46e57650e26faaf798c1e9f2864373c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152431
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-31  Tibor Nagy  <nagy.tibor2@nisz.hu>  [6a059f8d1b0a7a5b64bd272e1e7b8291979bcd56]

        tdf#155321 sc: fix color of the highest value on percentile color scale
        
        if the highest value occurs multiple times in the data set.
        
        Also for coloring based on the percentile, use always the end
        of the color scale for the highest values, like other spreadsheets
        do, i.e. not the first possible color in the case of repeating
        values. For example, the corner case in the test document is not
        a red and two yellow cells any more, but a red and two green cells.
        
        Note: color of the other repeating values still differs from
        MSO, but the same as in Google Sheets.
        
        Change-Id: I1d7eacec6e442c1112a9568e64dd6461e2ff2fbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152117
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [6aec73de12a56a56b3ffd9bb86b559bf0609bf58]

        SwModelTestBase: drop mustCalcLayoutOf
        
        it's not used anywhere since f3294eb1789e9603b5129f0f2d61116fd4853b52
        "CppunitTest_sw_htmlexport: remove not needed mustTestImportOf()"
        
        Change-Id: Ifb27c176bd64ca3efecb0f9b142b6144c5703556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152453
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [58ab2f002fd27974b474151b01287dac221dc102]

        SwModelTestBase: get rid of mustValidate
        
        and remove duplicated save method
        
        Change-Id: I9bdf0e28d59ae281fccbafd266b86cdf89c112da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152421
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [009b889616561176a230bc041699271697f95bf6]

        do not throw DisposedException when inside a dispose() method
        
        There is no need to do this, as the documentation of
        css.lang.XComponent::dispose at
        
            udkapi/com/sun/star/lang/XComponent.idl
        
        states:
        
            After this method has been called, the object should
            behave as passive as possible, thus it should ignore all calls
        
        Otherwise, the effect of throwing here is mostly to disturb the flow of
        logic in caller code, preventing other parts of teardown from proceeding
        smoothly.
        
        Change-Id: I30e6d1b35f85b727debf4405a995fdc0a4fccde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152450
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [046e37faa295889157f0313f2300d93cb0f83b9e]

        update credits
        
        Change-Id: Id34d3ecb170be128bb19d6982845bc4fbd4af598

2023-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f98574b78ed1b06bac1d440d75d8ce1ddea8309]

        speed up tab-switching in a calc document with a lot of graphic objects
        
        if we are in the destructor, and we have never painted the object in
        question, then we don't need to do an expensive object-range calculation
        and invalidation
        
        Change-Id: I857c3d927142f4e90d54f79fa6c293731382f0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152424
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5194bb56b6db3b67389cad977c27a7b34f51044b]

        Update git submodules
        
        * Update translations from branch 'master'
          to b9fc08bbb6763328ebc59b3e5be620b50c0caed0
          - update translations for master/7.6
            
            and force-fix errors using pocheck
            
            Change-Id: I0bdcb9cbf6bc0e0a005f59e98799d3cd7eb8b151
            
2023-05-31  Miklos Vajna  <vmiklos@collabora.com>  [dcc54c4c4bd3c938ba4b06e89f5688ae262b8507]

        vcl: one more nullptr check in Window::GetOutDev()
        
        As it was pointed out at
        <https://gerrit.libreoffice.org/c/core/+/151857/2#message-ced4ba9ebaf5725ec06853682c146211824af158>,
        it makes little sense to have the nullptr check in the non-const version
        of Window::GetOutDev() but not have it in the const version, fix this.
        
        Change-Id: I2f97938a4015d3ce27e35b9971b65090f7289c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152429
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [8811bf5aa94df5beff2249e1f51d383b3df6409c]

        Related: tdf#155507 don't enable field shadings in online case
        
        as in initializeForTiledRendering we don't want field shadings
        
        Change-Id: Ie1ea2c365bcd78cdfd554646474c4ef05a19fcda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ac06469dc0338ed57af76cba9d96117d753422c]

        Fix dynamic-type-mismatch
        
        After
            commit 5315e6069e425aad88873beb5344bb8ea31e0c55
            use more TypedWhichId
        
        flushed out some inconsistency in how SID_NUMBER_TYPE_FORMAT
        was being used, by managed to miss one place
        
        Which started to cause CppunitTest_sc_shapetest
        CPPUNIT_TEST_NAME=testTdf137355_UndoHideRows::TestBody to fail with
        
        > sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx:185:46: runtime
        error: downcast of address 0x503000ef5ae0 which does not point to an
        object of type 'const SfxUInt16Item'
        > 0x503000ef5ae0: note: object is of type 'SfxInt16Item'
        >  00 00 00 00  90 28 c9 3d f7 7f 00 00  01 00 00 00 21 67 00 be  00 00
        be be be be be be  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I4b4f9c88b8c587a9e08955728b3085eb5acece12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152427
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-31  Seth Chaiklin  <sdc.blanco@youmail.dk>  [847f899cb3f9607b55fd5989b2043a0b513dec22]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36b8bd4e7d31ff18c9e8ce85718aa8e9a3f1edcd
          - tdf#121367; tdf#153876 followup to workaround <switch> behavior
            
               For some reason, possibly related to tdf#144859,
               WRITER is not included in <default>, even though it should.
               Patch repeats the <embeds> found in <default> for Writer,
               so that they will also appear with WRITER in help.
            
            Change-Id: I05300853717dcc555645cbf98f8089f70ce3e779
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136712
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-31  Luigi Iucci  <luigi.iucci@collabora.com>  [1bc6d8f811e0941d1a8046c9ba725d0f38223143]

        Added doxygen to calc currency combo
        
        Change-Id: If6a70f38007c385c28f9136e48635e91b9ec93e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151968
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-31  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f1ec565d4843284e43614d208b006420732b98e8]

        Resolves: tdf#109149 don't poll the Default Printer Name on every query
        
        We are queried on every change, so on every keystroke, and we are only
        using this to fill in the printername inside the label of "Print
        Directly (printer-name)" On Printer::GetDefaultPrinterName() is
        implemented with GetDefaultPrinter so don't call this excessively. 5
        mins seems a reasonable refresh time.
        
        Change-Id: I71e87f26ed022241e09f9ab0eed94d09648ec9b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152415
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-31  Stephan Bergmann  <sbergman@redhat.com>  [2cda7933d1ed9e28153f6083e353df352851e235]

        tdf#155543 Get back com.sun.star.cui.AsynchronousColorPicker service impl
        
        901360967dde5d3948d4a28d156ad526b0802ca1 "Combine
        com.sun.star.cui.[Asynchronous]ColorPicker implementation decls" had assumed
        that:
        
        "f54ccf09a5073b6e544c976da68de0c9fc0bdf6c "Make Custom Color Picker dialog
        async" had added the additional com.sun.star.cui.AsyncColorPicker implementation
        entry (later renamed to com.sun.star.cui.AsynchronousColorPicker) for the same
        actual C++ implementation, presumably out of confusion.  (The implementation
        name "com.sun.star.cui.AsynchronousColorPicker" appears to not be mentioned
        anywhere else than in this .component file, so it shouldn't matter to drop it.)"
        
        But turns out that things are even more confused there than I'd initially
        thought they would be:  The names com.sun.star.cui.ColorPicker and
        com.sun.star.cui.AsynchronousColorPicker are actually UNOIDL service names as
        declared in offapi/com/sun/star/cui/[Asynchronous]ColorPicker.idl.  And the
        implemenation is accessed via css::cui::ColorPicker::createWithParent and
        css::cui::AsynchronousColorPicker::createWithParent in
        svtools/source/dialogs/colrdlg.cxx.  Which, in the past, happened to work,
        because creating a service X also looks for registered implementation names X,
        if it does not find a registered implemenation that advertises service name X.
        For com.sun.star.cui.AsynchronousColorPicker it happened to work until I removed
        that implemenation name from cui/util/cui.component...
        
        A minimal fix for that mess is to make that implementation also advertise the
        com.sun.star.cui.AsynchronousColorPicker service name (the
        com.sun.star.cui.ColorPicker service name is still found, unconventionally, via
        the implementation name).  Whether the two additional service names
        com.sun.star.ui.dialogs.ColorPicker and
        com.sun.star.ui.dialogs.AsynchronousColorPicker are relevant in any way I don't
        know---just leave them alone for now.
        
        Change-Id: I37f4fd5b45b97ab27275cd377921063d6e0cc096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152418
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-31  Stephan Bergmann  <sbergman@redhat.com>  [a0ee0fe0d5340ba67e849068af9a50108cd27e5f]

        Improve some error diagnostics
        
        Change-Id: I4e9d19a164fdc035ceabd9d4a04a0f500322dd0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152419
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-31  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [7be7e1ff95af485a9cb00748800d3d084f96387c]

        tdf#153437 sc: fix broken formatting at Undo of row/column insertion
        
        Performance fix for the 16k rows resulted broken
        formatting during Undo of row insertion, e.g. rows
        with background color fell apart, highlighting partially
        also the row under the deleted row removed by Undo, or
        Undo of inserted/copied columns removed the background
        coloring at the place of the removed columns.
        
        Formatting was always deleted after the last column
        containing data, because the row was only allocated until
        then. When deleting row(s) or column(s), allocate the last
        column before updating the references.
        
        Regression from commit 2e86718626a07e1656661df3ad69a64848bf4614
        "don't allocate unnecessary columns when inserting a row".
        
        Change-Id: I8d74d59ff0051fdfe183e14a16d987edc71d55e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152185
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [8259a99f41367a1d8326c9157fe1902915715879]

        MCGR: Use tryToRecreateBorder for better BW comp with LO
        
        For better compatibility with LO versions before MCGR, try
        to re-create a 'border' value based on the existing GradientSteps.
        
        With MCGR we do not need 'border' anymore in quite some cases since
        no Start/EndColor at 0.0 resp. 1.0 is explicitely needed. Since we
        (unfortunately need to) internally continue to support border
        anyways it does no harm to fallback to use the border value - if
        there is an equivalent representation as this helper checks for.
        
        For exports that do not support 'border' this will be adapted as
        needed (see tryToApplyBorder())
        
        Change-Id: If98c64039ff97143d4b5c92ac2a950e70f5bb70a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152395
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-31  Stephan Bergmann  <sbergman@redhat.com>  [c6fcc69ec3a4b36526fbf8ca959371d1ee8e0fb3]

        Missing test dependencies
        
        > warn:vcl.builder:927441:927441:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/scrollbars.ui at xmlreader/source/xmlreader.cxx:67"
        
        and then
        
        > warn:vcl.builder:928408:928408:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/modules/scalc/ui/posbox.ui at source/xmlreader.cxx:67"
        
        and then
        
        > warn:vcl.builder:931775:931775:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:67"
        
        Change-Id: Id7aa68b8bfef8a1d318e3a54614dc284f2dc7f4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152413
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-31  Miklos Vajna  <vmiklos@collabora.com>  [e851d081c614107c450f8ac87e415b49a58bb5bf]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOle2
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I9b3c1ffc87e68da315e58f97d63b4f13cb1a5322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152400
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [f6c753cc0f42e94f89361b7d1c41dae069ed73aa]

        MCGR: tdf#155437 handling of TransparencePrimitive2D for metafiles
        
        In VclMetafileProcessor2D we need to take care of changed
        circumstances for gradients with the MCGR adaptions. The
        method processTransparencePrimitive2D tries to detect the
        special case that the trapsparency part of the handled
        TransparencePrimitive2D is a single TransparencyGradient.
        
        If detected, this is handed directly to vcl using a
        MetaFloatTransparentAction which contains a class
        'Gradient', but the limited form from vcl (see
        include/vcl/gradient.hxx). This class can only in very
        limited scenarios directly handle/hold a gradient from
        the model (even before MCGR).
        
        For that case there is the helper method
        'cannotBeHandledByVCL' that is already used to decide
        if limited direct rendering using vcl can be used.
        This has also be used here.
        
        Also reworked the conversion to Bitmap as needed, the
        existing versions created slight errors. For more
        details see additional comments in the code.
        
        Change-Id: If9af8b1423df5354eaf9ba8ca6243a1b3ad1b965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152392
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-31  Miklos Vajna  <vmiklos@collabora.com>  [2a380dba73d57f825128fbada91c7a9fe79e8a06]

        tdf#150769 sw floattable: fix lost PageDescName if section starts with a table
        
        The bugdoc has 2 tables in it, separated by a section break (next page).
        This page break was missing in Writer, so the tables overlapped.
        
        The page break was lost because the 2nd section started with a table,
        where we insert a dummy initial paragraph (to side-step the problem that
        you can't have a selection starting in a table and finishing outside
        that table), and once it's disposed, its properties are lost.
        
        Fix the problem by copying the PageDescName property from the dummy
        paragraph to the next paragraph before dispose. Note that we need this
        combination of creating a range (using gotoNextParagraph()) and then
        enumerate over the range, because gotoNextParagraph() would skip a
        leading non-floating table, which would lead to an additional, not
        wanted page break, as pointed out by CppunitTest_sw_ooxmlexport15's
        testTdf134649_pageBreak.
        
        This went wrong in ce5f82dbaf1c22f45a08c60eb213bc9bc821c1d1 (DOCX
        import: floating table with negative top margin has to be a fly frame,
        2022-01-21), and it turns out to be related to normal floating tables,
        unrelated to multi-page floating tables.
        
        Change-Id: I83245c78c63ec8f3d6015ce3e72ab232220a9fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152411
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-31  Julien Nabet  <serval2412@yahoo.fr>  [b960668bbde1c77c5eadf0a1ad8abde08114810f]

        tdf#155562: crash when switching to PostgreSQL connector in Database wizard
        
        It seems "label" doesn't exist for AtkObject so rather use "AtkObject::accessible-description"
        
        Regression from afe99617707c92460e66486c0057ef327e8aa017
        tdf#43369: Specific UI for collecting PostgreSQL connection settings
        
        Change-Id: I1f4f7ebe5e20a9ff7b75e6f82ffdd2bdebe7417c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152406
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-30  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [60e499147963e42ce783dffcf9c8d4aba8b5d475]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26a4384689855508e662ae04cb49852280db50ee
          - Proofreading: A document may have “contents”, but not the TOC itself
            
            Change-Id: I5b20b7702a795570832ae88e5fac22d702dccb00
            
2023-05-30  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b2da36a0837c3d2614917f2382c19c070c5750ed]

        tdf#155374 Icons for PageNumberWizard
        
        Change-Id: Ie0317d6640e2c2a40dc3e5808397dfada6edc55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152408
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0d2996d05be4eb0a3fdc6d1a5155e55294cbb11]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e21dbdfd8585da7953ea5f442c7b7b9839a9be1c
          - Synch Contents Controls nomeclature with UI
            
            Change-Id: I4cf44c40b4635b9a145d8d4428baa2532a9d2b71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152409
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [ecd270bc44d094cc01e9978af60715c0d3940416]

        Revert "Resolves: tdf#155453 formatting lost when formula bar edited via IM"
        
        This reverts commit 1a6d250f34c63808552f783a31a315bc7d80ca93.
        
        seemed to work at the time, but it crashes now.
        
        Change-Id: I21bdc7a6494de4190d088552ca89ac831b642ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152404
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-30  Justin Luth  <jluth@mail.com>  [0ceb131e964206efbb1c76a03f19d1992e2f89c7]

        tdf#140508 doc import: auto-contour for textboxes
        
        This fixes a 6.3.1 regression.
        
        The problem was that contour was turned off
        despite settings indicating that it should be on.
        
        An earlier patchset contains the results of a make sw.check assert.
        
        make CppunitTest_sw_ww8export3 CPPUNIT_TEST_NAME=testTdf79186_noLayoutInCell
        
        Change-Id: Ib3df022a1430649b271083f343b470798f4a08c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152398
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-30  Jim Raykowski  <raykowj@gmail.com>  [60e32969a98cad348cf8e55e8f93abc3d6e9c70c]

        tdf#155393 SdNavigator: Enhancement to navigate in Notes view
        
        Change-Id: Icea71217fa5ffadc637bd7d9b8cae2fa18ec93bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152075
        Tested-by: Jenkins
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b5f9debcdb861589c6c9b01858388603dec0d24]

        tdf#152037: sc_uicalc: Add unittest
        
        Change-Id: Ia0fbea3ecc4fab741940a453e8508f417e31e6a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152394
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-30  Michael Stahl  <michael.stahl@allotropia.de>  [35a79eac56f8b93b62de555ea92c28304f2333d9]

        sw: fix infinite recursion in SwEditWin::GetSurroundingText()
        
        This is basically the same as what was fixed by commit
        581ba395222e04e43697484bef9181c877d1fd61 and i'm not sure why this
        problem is now happening here.
        
        Change-Id: I0769d1aa0980031452b69c48dee7aaef211df25e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152390
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-30  Mike Kaganski  <mike.kaganski@collabora.com>  [05bc773b0e88b408a997ffa5851cc9207d3303e5]

        tdf#73483: make sure to not reset style names
        
        The problem was, that resetting direct formatting also used to reset
        RES_FRMATR_STYLE_NAME and RES_FRMATR_CONDITIONAL_STYLE_NAME. These
        are important at autostyles export: in XMLTextParagraphExport::Add,
        SwXAutoStyle is queried for ParaStyleName/ParaConditionalStyleName
        properties, and empty values of these were used to add the autostyle
        to pool. Looking for the autostyle while exporting the paragraph,
        SwXParagraph reports the correct "Standard" as the style name, but
        no matching children were found for the "Standard" parent style, and
        so the paragraph got "Standard" style name, instead of the autostyle.
        
        Change-Id: Iadf24ebd2b85e494267b73336a54b24f85ea0a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152393
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-30  Michael Stahl  <michael.stahl@allotropia.de>  [4c29c7107ed45b777a63c4060340e03f54375391]

        sw: SwView::SetZoom_() shouldn't subtract page margins
        
        In the PAGEWIDTH mode, this has the annoying habit of changing the zoom
        factor when moving the cursor between a page with a mirrored page style
        and a page with a non-mirrored page style.
        
        Change-Id: I0e4290432ebaa5012b10d896fc96ae53b39fa475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152391
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d2c02a9aba3c05e4b3072596d2b3871b7fe67864]

        Fix wrong check
        
        It was introduced in commit 286ba5b6ca60c7f67106059ea56721b86c36925b
        (#79947#: Improve performance, 2001-11-01), and there the size of
        xPropStates did not change when incrementing nIgnoreProps. But later
        commit 8195d7061ed52ebb98f46d35fe5929762c71e4b3 (INTEGRATION: CWS
        swautomatic01 (1.126.4); FILE MERGED, 2006-12-01) started to remove
        the ignored items from xPropStates.
        
        Change-Id: Ida864a83c32dec2884beba9ad68943e936655fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152326
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-30  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d669df25d2ac950da85e9d60074d059f9ef1459a]

        Related: tdf#155542 drop workaround for "XB Roya" issue
        
        Change-Id: I8323ae631c13da80cc3f4b8b8826cb9b23e788f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-30  Dr. David Alan Gilbert  <dave@treblig.org>  [4998370216bbea3bcaff7fac2d62cbb4ac978c5d]

        tdf#145538,tdf#147021: sw/source: range based loops
        
        A bunch of range based loop changes in sw/source
        
        that also take out SAL_N_ELEMENTS usages
        
        Change-Id: I28b929d2ecbe40c1b257454f21b5d2ff51d617e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152251
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-30  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [8c1892cd80a5095b38e88d558f653b27d93b074c]

        tdf#152037 XLSX import: fix false alarm data validation error
        
        Fix validation error on valid input by adding missing
        SimplifyCompiledFormula() to the implementation of
        setFormula1() and setFormula2() of XSheetCondition UNO API,
        which used by the XLSX input filter.
        
        Change-Id: I8389227eb5a609c29e8d466cf62420bae36f7927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152295
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-30  Mike Kaganski  <mike.kaganski@collabora.com>  [20db76c08f870f1f1b4f890d93c0597e2bd36a0a]

        Revert "Use getXWeak in ure"
        
        This reverts commit d9225a59e89907e9d289ab93c44fd8e6883f1be2.
        
        Reason for revert: this is not a LIBO_INTERNAL_ONLY code.
        
        Change-Id: I780afcd88764f8f5bbf99d257a07d19cacb5aa55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152322
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-30  Mike Kaganski  <mike.kaganski@collabora.com>  [c9d3abf80e6d8617b7447d2f291cefe16c133514]

        Revert "Use getXWeak in unodevtools"
        
        This reverts commit 35eb21d563418bdd664677d073c5653ace3da957.
        
        Reason for revert: this is not a LIBO_INTERNAL_ONLY code.
        
        Change-Id: Idd7a6664c89eca1a5bcfe800cf4fb4a9576722d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-30  Heiko Tietze  <tietze.heiko@gmail.com>  [57d5c01ac1bcce56591b4eae96d1e679ef7197d4]

        Resolves tdf#140091 - Tooltip to add sheets should be more informative
        
        Change-Id: I03ae5d11b80472839e2654ff43eb391b5396f026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152383
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-30  Miklos Vajna  <vmiklos@collabora.com>  [d785d26a5599d3d546b96958b0f1c6d5ed777a0d]

        sw floattable: handle \nobrkwrptbl in the RTF filter
        
        This is the RTF import/export for the functionality added in
        commit 08fa2903df1a7cf9a1647fcf967e4c8b57dad793 (sw floattable: add a
        DoNotBreakWrappedTables compat flag, 2023-05-24).
        
        Change-Id: I3c458cbe1f4b0947a94651cc205f2a7660d2ec2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152377
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [5655cc201e5a80997fe21bc2a0c7abcbe4fb488f]

        sc: avoid crash in ScHorizontalCellIterator
        
        At least do not crash with release builds as seen in
        https://crashreport.libreoffice.org/stats/signature/ScHorizontalCellIterator::ScHorizontalCellIterator(ScDocument%20&,short,short,long,short,long)
        
        Change-Id: If253e950bbb709b585dc9398beddd1303dcb1b57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152000
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-05-30  Vojtěch Doležal  <dolezvo1@cvut.cz>  [8716f10f8a3b59ceb8b7673d6c5948b882830167]

        Fix gray shade for NBSPs
        
        28675af broke field shading for NBSPs, showing it only when non-printing characters are enabled.
        
        This commit reverts the behaviour to the original state, where field shade is independent on whether the non-printing characters are enabled.
        
        Change-Id: Ica44937a82d6c3742716e9aa934ab87e7f8b5168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152349
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-30  Khaled Hosny  <khaled@libreoffice.org>  [bf8d1290a4de26f06d429148a92cbdb7a63eecf5]

        tdf#155542: Fix crashtesting assert
        
        When cloning an RTL glyph range, we might end up cutting in the middle
        of a cluster e.g. between a base character and a combining mark since
        both with have the same charPos() after:
        
        commit 09c076c3f29c28497f162d3a5b7baab040725d56
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Wed Oct 5 21:00:46 2022 +0200
        
            tdf#151350: Fix extraneous gaps before marks
        
        (which changed how HarfBuzz sets up clusters back to the default where
        marks form clusters with their bases, before that a mark formed its own
        cluster).
        
        This leads to the cloned glyph range to include the glyph for the
        combining marks, while it is not included in the text string.
        
        Change-Id: I83031e0e0ffc7c5932101649a9cc2bf953a6347d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152380
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-30  Miklos Vajna  <vmiklos@collabora.com>  [385d3323ce23833e8706b0d21f6df07e1927b8e0]

        sw: prefix members of XMLEventsImportContext, XMLFontStylesContext, ...
        
        ... XMLMarkerStyleExport and XMLMarkerStyleImport
        
        See tdf#94879 for motivation.
        
        Change-Id: Ief48236f16c5525c6bd49d78e6ba4f9643ef1214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152376
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-30  Noel Grandin  <noelgrandin@gmail.com>  [cf4a1c42d6a90ec73ab1504d4bfaf3004bad33da]

        merge expwrap into sax library
        
        there is no need for 2 shared libs for such a small module
        
        Change-Id: Id28c9038f3e16931bfb8af3532eca172998da1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152374
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc50abb7f972c53fcca08d2ac3627e7848456520]

        use more TypedWhichInfo
        
        Change-Id: I406c5d070e3dd197b2cf819d63212d5a40a8eadc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fc4f7db59152f606b6aa88cf32197700959d0f8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ffbf68223b981335abdfede5dc5f86c30269c13
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I7db22fb77cd690cfadb8b0fda4776ddb0a1ff0df
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152373
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [5316e32d72584a60054c4ba98c40067712058d26]

        avoid some invalid Fraction objects
        
        when loading spreadsheet with embedded OLE objects
        
        Change-Id: Ib8fe88f0ffec03e8b92d8d8b69c8763164f4dd05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Khaled Hosny  <khaled@libreoffice.org>  [8783f5959c83a4de3b857af3e63d5f3e5d3afdf2]

        tdf#89288: Insert space between CJK and non-CJK text only
        
        When “Apply spacing between Asian and non-Asian text” option is set
        (which is the default), Writer inserts text between any two script
        changes which is not desired.
        
        Change-Id: I9abb672b761a5f25f714cf60cf06c7dab5441af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152369
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-29  Justin Luth  <jluth@mail.com>  [5bdff09d5e7026c8176d11abfa164b1c44bf4222]

        tdf#36711 doc import: special case when DyaAbs is zero
        
        One existing unit test found, but the frame was non-functional.
        Noted in an earlier patchset.
        
        make CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testTdf36711_inlineFrames
        
        Change-Id: I9bc4064b6564b327614e44112304adef59490078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152346
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [949d1ee783f58504fdf7cb6b6a164384ae82533f]

        ReqIF: 'ol' elements must have no 'type' attribute
        
        Change-Id: I62098bac9dc3751f7b939cbf94f1561b4539a294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152368
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-29  Khaled Hosny  <khaled@libreoffice.org>  [d7ddac208516ce2350c84c434aad933b345c9509]

        Remove recently unused CTLScriptType code
        
        This is now unused after:
        
        commit 98f7ec383db74a6491e925e30125d3fbf270afc2
        Author: Khaled Hosny <khaled@libreoffice.org>
        Date:   Sun May 28 16:28:52 2023 +0300
        
            tdf#139863, tdf#155514: Don’t split COMPLEX text portions
        
        The code is also broken as it doesn’t handle surrogate pairs.
        
        The UNO API now throws an exception.
        
        Change-Id: I454ed741e3834e762a2731d671c21a3e73515da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-29  Khaled Hosny  <khaled@libreoffice.org>  [ab1985d0b39e8bcc976543b9700e04610f434423]

        tdf#149297: Fix Y position of vertical glyphs on macOS
        
        Remove the Y position offset that became redundant and now double shifts
        the glyphs after:
        
        commit dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481
        Author: Mark Hung <marklh9@gmail.com>
        Date:   Sun May 2 15:12:46 2021 +0800
        
            vcl: adjust LayoutText() for vertical writing.
        
        Change-Id: Iac7abfa69acfe75860d05800f446c25ed622bb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152366
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-29  Dr. David Alan Gilbert  <dave@treblig.org>  [b20eb3367436de4fb189dc82d14412539c02d30c]

        cppunit/timer: Use a range based loop and cleanup
        
        Use a range based loop in testDurations re
        
        tdf#145538
        
        which also nails a SAL_N_ELEMENTS
        tdf#147021
        
        and takes out a sal_uLong
        tdf#114441
        
        while here, clean out the rest of the sal_uLong's in that file
        to be sal_uInt64 to match timer.hxx which was changed by 9c7016b5b5
        way back in 2015.
        
        Change-Id: Ie065885939a340d9a73af797fb4d7d6f76530242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152250
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Dr. David Alan Gilbert  <dave@treblig.org>  [da398ad3bb511e33451f9d3bf24b0c5abd55ce25]

        replace find_if by any_of
        
        A few cases where find_if is used just to test if there are any
        matches; use any_of as per
        
        tdf#153109
        
        In document3 we can merge two identical loops.
        In langbox we can optimise the arg capture (Arkadiy's suggestion)
        
        Change-Id: I480b80ec1b859980b651c6d727e7fb5d01d390e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152201
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [583c3fcea50b69ca9d3cd866050c9e722a8f780b]

        use more TypedWhichId
        
        Change-Id: If7b4320e199a01f2614e3bf582e5d96fade22aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a12633a9982d34eb8f0b714d5f25cff3040f33ab]

        tdf#155515 tdf#155528 crash on exit
        
        regression from
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 4 10:06:14 2023 +0200
            tdf#105404 [API CHANGE] add index to accessiblity change event
        
        Fix a handful of things related to accessibility objects being
        destructed later than they should and consequently trying at access
        other stuff that has already been destructed.
        
        (1) AccessibleControlShape::disposing check the window still exists
        (2) DocumentFocusListener::notifyEvent, handle INVALIDATE_ALL_CHILDREN
        (3) hold DocumentFocusListener by weak reference in GtkSalData, so that
        it dies when the related UI widgets die
        
        Change-Id: I38bf68a748b37e6abc4a8cfcc961436728e081bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4025ab7a19e730501877040814096c2fa47cefc3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 921da60c0a7bf06943277d27dad3e10b19d7d5bd
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I8d16368723426d6c7f9be66f8000fbe79e4e4e57
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152364
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-29  Patrick Luby  <plubius@neooffice.org>  [b76a3bdc996f275f9d615b32d6ab89d533a7505c]

        Revert "Script that adds "com.apple.security.get-task-allow" entitlement to soffice"
        
        This reverts commit ff95984c8e3475b7ff7832683d621bd09896852e.
        
        Reason for revert: The script was just a quick hack that I whipped up during other development work and I didn't know how to integrate it into debug builds by default. @Christian Lohmeier reviewed the script and noted the existing build scripts that add entitlements based on build type where I can put this new entitlement.
        
        Change-Id: I4246639e99a62c63fb1ba38b19cac0442c71c0a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152031
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-05-29  Patrick Luby  <plubius@neooffice.org>  [cb4fb9e31e42ed719f435919d1ca671ba2d66863]

        Related tdf#tdf155376 fix minor memory leaks
        
        Change-Id: I9cdc5fb38ffba113e3d069d9d766dbe1a82c492d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152352
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        (cherry picked from commit 7ae89a2ad89c9e7702fbd2b31269ee4c61fe5bcb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152316

2023-05-29  Patrick Luby  <plubius@neooffice.org>  [1bf7da609848652ad99d9bde844b90d37de80ffa]

        Partial fix tdf#146626 Catch uncaught DisposedException
        
        Fix crash due to an uncaught DisposedException thrown by
        SwAccessibleParagraph::getTextRange() by using the same try/catch
        block in -[A11yWrapper accessibilityAttributeValue:] in
        -[A11yWrapper accessibilityAttributeValue:forParameter].
        
        Change-Id: Ifcaec3eb2d76f32bddc56a1242f6d86f8b90f782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152361
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        (cherry picked from commit f8cc6f960e8aeb37547d447fed2b2c6e6ddc02e3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152317

2023-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [de6c3385d4cd515862804a9d566e8fded39147e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f527d4cfc5f65bb6fec477f540da3794e9fa744d
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I9fc6a419fbe838015dd991716b5dea682b99dbaf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152362
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-28  Julien Nabet  <serval2412@yahoo.fr>  [3070091c9eafc964ebb3f53d3b44124b40571fd8]

        Typo: aCatlog->aCatalog
        
        Change-Id: I875e94e47d44101a840b711de174f38ad4b85b4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152357
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [27bf610d31dc03495c451dbabc56eaf64fdd906b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bb49f8d719951c9a1dcef0953e8b213def056f21
          - tdf#154996 Review Common File menu entries
            
            Change-Id: I397d3ce8a0a0f89c835bcf31245dfef3ea8a745f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152358
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d4223b3915940da9455cda34efa47363af76e6db]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 98d5ed689681c18a27e8f03824a47cde3c376639
          - Reformat table for Index Help page
            
            + refactor (no contents change)
            
            Change-Id: I02ac63520bdf3930129f6c1ccca725ea072740a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152355
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-28  Khaled Hosny  <khaled@libreoffice.org>  [98f7ec383db74a6491e925e30125d3fbf270afc2]

        tdf#139863, tdf#155514: Don’t split COMPLEX text portions
        
        When a COMPLEX text portion contains more than one script, it gets split
        into multiple portions. This is broken into more than one way:
        * ScriptTypeDetector::endOfCTLScriptType() does not handle surrogate
          pairs, so it split the portion in the middle of a surrogate pair,
          causing tdf#139863.
        * If a combing mark of a different COMPLEX script is used, it gets split
          into its own portion, causing tdf#155514
        
        This was supposedly done to fix https://bz.apache.org/ooo/show_bug.cgi?id=28203,
        but testing the documents from this bug report with this change does not
        show recurrence of any of the kashida issue, so this split is unnecessary.
        
        Change-Id: I9bd60efe3023b96ee74f861a5dc15a2229c27d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152354
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-28  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1a6d250f34c63808552f783a31a315bc7d80ca93]

        Resolves: tdf#155453 formatting lost when formula bar edited via IM
        
        do like we do for simple key strokes and forward to the ScModule
        InputHdl
        
        Change-Id: I2d99c23e8ac03b6de2498c6378a0dc5d11530248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-28  Khaled Hosny  <khaled@libreoffice.org>  [da09513ae6221f46ee453943b3669d1d922a4aa3]

        tdf#154547: Improve Hebrew font preview sample text
        
        The Hebrew font preview sample text include Nikkud (vowel marks) which
        are optional for modern Hebrew and not all Hebrew fonts have them, and
        for fonts lacking them we use a much shorter preview text.
        
        The inclusion of Nikkud is unnecessary and we don’t include vowel marks
        in many other scripts (e.g. Arabic where they are more used).
        
        This patch drop the Nikkud marks and leaves the sample text otherwise
        unchanged.
        
        Change-Id: Ie4e5abcd74599d25db41c4cdf7e1d3bf997a998c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152350
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-28  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [f068ec681775772e3acc1ecbd8be7a17124e70f4]

        [3.0] external/openssl: add patch for CVE-2023-0464
        
        this issue should be fixed in release 3.0.9
        
        Severity: Low
        Security Advisary: https://www.openssl.org/news/secadv/20230322.txt
        
        Change-Id: I8d34acd72ac8eb7e9e83b241eb1235a93111884a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149639
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [b4de1a98e61a75782464a440a33acf7435e1bbb9]

        Use getXWeak in vcl
        
        Change-Id: I665c9dc8c4f9cc4a996d9bf990cbfa33822bd07f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150885
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [44239426ad12050b0e3a7db87efa202288ba2e14]

        Use getXWeak in basegfx
        
        Change-Id: I650a8fcefd179937bdcbb6088658aa960008794d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150834
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [da685e0029ff46f22d169d16986bb2e82e863e51]

        Use getXWeak in embedserv
        
        Change-Id: If50010a2b2ba18623bcf7c049e8f31091a9a46a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150847
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [6bff407d3b62713ec9946086e8c381e0d3f9d842]

        Use getXWeak in eventattacher
        
        Change-Id: I5f10d1404f28d3a16301bbfd755bdbc3886b16a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150848
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c19c775c0b54e797b4b7a30f9acf6a34efeaacca]

        Use getXWeak in binaryurp
        
        Change-Id: If1891fc180126aa5d5ac92772cbca9b485619f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150836
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-28  Eike Rathke  <erack@redhat.com>  [7e3ddf1e5aae5e4e956495e3d86a8cbf6e251b5e]

        Factor out DateTime::NormalizeTimeRemainderAndApply(tools::Time& rTime)
        
        Change-Id: Ie520b10baaeb4c94973c44435c3241e5d2254968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152345
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [20873f073ae4a9478f0a84355f779a2176bd2ec8]

        cid#1448540 Dereference null return value
        
        Change-Id: I72fd7c1a38cb870d99ee085f4f511f2fb9d8d7af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152343
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fc1eb075a5bbddebd3359dae79713af3094bfd38]

        cid#1531780 Dereference null return value
        
        Change-Id: I4aa66284b0a9948cd947cc99a119ce4ea2bbf26e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-27  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2743839c4ac3aaaf6bafc31bebfb67254173f7ee]

        ofz#59362 aPardMap returns 0 'Which' for SID_ATTR_BORDER_OUTER
        
        since:
        
        commit 839c5010241842835a1c066be0838df4a8a53dc7
        Date:   Wed May 24 16:40:59 2023 +0200
        
            use more TypedWhichId in editeng
        
        cause operato[] is just a getter now
        
        Change-Id: I2c5cc21131dffd0e9840b65185c2491ed6183bd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [42a5f14edcea5d2fd2e92955cd70a163a1a27804]

        Use getXWeak in testtools
        
        Change-Id: Iee8f1314fc3d924376b5b6ad6c683c7d451ab900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150876
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [d4182557b5cba1d56041792dfddbd89a131f6ada]

        Use getXWeak in ucbhelper
        
        Change-Id: I6bdc3acf86854fe3f91aa09cb52d67a2b11ca8e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150879
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [87276a497d9aa8a3f8ac0bfceb75d64938945f9a]

        Use getXWeak in io
        
        Change-Id: If2b40ecdca67c6d82ff1a87443cb8533401e9ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150856
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [efcbd2306f0310809f2d6f1db086b839055c77f6]

        Use getXWeak in fpicker
        
        Change-Id: Iedeb452d49718b6e73a526da132bc0fc9b165fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150852
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [5c1c768e128d9356cbe17adb96ef6290ec3bb1ad]

        Use getXWeak in UnoControls
        
        Change-Id: I4e1deaffb3c6926bf57715cb10fc38bf59f791a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150880
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [1aba7cd7385a08e450a4b86ce0b378be5eedb903]

        ReqIF: do not write 'align' attribute to 'div' element
        
        To keep the alignment information, use 'style' in this case. Maybe it
        makes sense to unify on 'style' also in normal case in a later change.
        
        Change-Id: I6e07acd46fbabeaa47ae9dbe71c00e1b1abc6b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152340
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e1f1f2b85379faa79e2b52ee221089b1d01646f7]

        Fix typo
        
        Change-Id: Id0d9335df80539877d1ee27e57e98b0a6aae75db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152337
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [dccf807b7585c0b73700c54642c37821c0836ae3]

        Use getXWeak in unoxml
        
        Change-Id: I141bad0d1b244bd801f613f159b79c4518fdf252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150883
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [35eb21d563418bdd664677d073c5653ace3da957]

        Use getXWeak in unodevtools
        
        Change-Id: I71c8c7f26dac1ce97f29818c73f3268d948d57a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150881
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [1f91efaea987c78c2755ea5d02eb3b1cb50743bd]

        Unify Concat2View
        
        Change-Id: Idb0a0fc620ece33e7ed6bcec3cbd8a0a833b1e38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152314
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [42df2445f3bc34cf006f9b4433671e21a179ff5c]

        Fix typo
        
        Change-Id: I989d9a915c61186b4fd9132f70b916b3dfd7f202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152338
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ab3a2fae34a000e27a9e44accdcc7bcbae60246]

        Fix typo
        
        Change-Id: I99ef22d0062b3e9573abd3c60078e72472681c32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152339
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [d9225a59e89907e9d289ab93c44fd8e6883f1be2]

        Use getXWeak in ure
        
        Change-Id: I5d76890ca1165b74e204b38c5ca9675d40a80823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150884
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Baole Fang  <baole.fang@gmail.com>  [9e92437cbb2180d51fdabc0d5efff24b530ba27a]

        tdf#148756: Fix document type in option dialog
        
        Change-Id: I16ef2adbb5c77960c18426ef6b2211d230adf410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151455
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [38e0e78998153463caf9c3c72ef7f4549ddff0e8]

        xmloff: add color-type attribute to complex color
        
        We need to identify what the color type of the complex color is.
        For now we mostly use "theme", but in the future we can also have
        other types like "rgb",... when the infrastructure for that is
        built.
        
        Change-Id: I38c91d294a191ca3124be4e99050977c9815d23e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152253
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-26  Laurent Balland  <laurent.balland@mailo.fr>  [2b3b4026a5c6a1b92c0b29b94dd62a4c3c7b9fad]

        tdf#154131 Add Detect scientific number option
        
        Add a sub case of Detect special numbers for import CSV (SC_IMPORTFILE),
        paste unformated text (SC_PASTETEXT) and text to columns
        (SC_TEXTTOCOLUMNS). Following cases are treated:
        - If "Detect special numbers" is true, then "Detect scientific numbers"
          must be true and all special formats are treated (date, time,
        scientific notation) in addition to basic decimal numbers.
        - If "Detect special numbers" is false and "Detect scientific numbers" is
          true only scientific notation is treated in addition to basic decimal
        numbers.
        - If "Detect special numbers" and "Detect scientific numbers" are both
          false only basic decimal numbers are recognized as numbers. It is the
        new case treated by this change
        The new option bDetectScientificNumber is append to ASCII options
        
        Change-Id: I73dff9f75d2c7b07ce155daa29dcc4ca9f288664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152072
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-05-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [75cca3bdea8e929bdca590710dc3f44481a72ace]

        Fix typo
        
        Change-Id: I7d6dd38b15df7e18775bc94a64aec215d2106c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152307
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0165b92f8c0980a3c5c4e2d6c77818ee02b73d47]

        Fix typo
        
        Change-Id: I3e63b18e94b26c671d140009db97d82efc346028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152306
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-26  Justin Luth  <jluth@mail.com>  [d42f519be7bcc8e194899a6b3225bcee7e54bc16]

        tdf#60683 tdf#55946 doc import: use style's anchor info
        
        make CppunitTest_sw_ww8export CPPUNIT_TEST_NAME=testBnc787942
        
        Change-Id: Ie1dc179fc3954b5eed73f3ee1f6dc95f4785f3e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152331
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4d4445e698b78ec0c2eb61a685869bd1d8bfd85]

        use more TypedWhichId
        
        Change-Id: Iaa7ce9165da835a638bcc1d633bed0a2ff2c4108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-26  Michael Stahl  <michael.stahl@allotropia.de>  [370533da3f07169791c0a17013ca55c57df2f3c9]

        tdf#155190 svx,sw: PDF export: don't tag SwNoTextFrame as Artifact
        
        The problem is that inside of the Figure tag, in
        SwNoTextFrame::ImplPaintPictureGraphic(), ViewContactOfSwNoTextFrame
        and ViewObjectContactOfSwNoTextFrame are used to create and process
        another primitive sequence.
        
        ViewObjectContactOfSwNoTextFrame does not have access to a SdrObject,
        because that was already processed by the outer layer of code that
        called the SwFlyFrame painting code.
        
        Avoid running the code that assumes anything without an SdrObject is an
        artifact by disabling PDF tags altogether in
        ViewObjectContactOfSwNoTextFrame.
        
        (regression from commit 81ef84648515965bf67afaced946227d0f63a71e)
        
        Change-Id: I9fabe7f7e5296f8d850448ac44865f87cd164591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152335
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-26  Michael Stahl  <michael.stahl@allotropia.de>  [ef2d064c403738660e9ba6bee6de736d0575dade]

        vcl: PDF export: stop adding pointless circular RoleMap entries
        
        ... for standard roles; no idea what these are supposed to be good for.
        
        Change-Id: Ie2ccf394631a2bccb496b2f93e26a571ba84d58d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152334
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-26  Jean-Pierre Ledure  <jp@ledure.be>  [a83643dea9f5922d4706c9e1d8b9f53f71eb01d9]

        ScriptForge (SF_Dialog) new CloneControl() method
        
        Duplicate an existing control of any type
        in the actual dialog.
        
        The duplicated control is left unchanged.
        The new control can be relocated.
        Args:
          SourceName: the name of the control to duplicate
          ControlName: the name of the new control.
            It must not exist yet.
          Left, Top: the coordinates of the new control
            expressed in "Map AppFont" units.
        Returns:
          an instance of the SF_DialogControl class or Nothing
        
        The method is available from Basic and Python user scripts
        
        This change will require an update of the SF_Dialog help page.
        
        Change-Id: I5c2a5404a14ad60b2d4df2ac7eabbf0ddd843170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152333
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-05-26  Laurent Balland  <laurent.balland@mailo.fr>  [6dd2ebbba23b20864d3cf74322540c628088375c]

        tdf#150028 Treat decimal separator after [SS]
        
        Only decimal separator after S or SS was treated
        This change adds [S] and [SS] to treat formats like
        [SS].00
        Update: correct export to XML
        Add QA unit tests
        
        Change-Id: I97ce4084d3caab2fcd18f1c70cd4221596290563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151823
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [31f2de053d89fc782f98f74785643dbd6e19ba73]

        Related: tdf#155507 disable HeaderFooter menu for tiled rendering
        
        Change-Id: I3fa87dc40c8e68d00f2f2fa82a0e6c4179466429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1354d0ffcabc6e7f78767e8cac1e8c127d4e4b6c]

        Related: tdf#155507 Only need this invalidate if using header/footer controls
        
        which is implied from the IsUseHeaderFooterMenu option
        
        Change-Id: I0f9a32ed1a3e0e5e277c33c45206757d133d92e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152330
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2023-05-26  Julien Nabet  <serval2412@yahoo.fr>  [42547b6472cad484bced8aa47ecadd6d21d587ac]

        Related tdf#153317: extra check since we deal with signed integers
        
        Thank you Michael Stahl for having spotted this! :-)
        
        Change-Id: I4e643b562e6dc653a511109531837c228f0e0e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152305
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-26  Justin Luth  <jluth@mail.com>  [4f91e6c91b449ffe1e51cc517e8fc93179feca67]

        tdf#133504 doc import: set the correct wrap
        
        Umm, I'm amazed that
        1.) this hasn't been a bigger, burning issue, and
        2.) that no one has ever investigated or fixed this.
        It was super easy.
        
        The code is mind boggling though. "Auto" and "Not Beside" are NONE,
        but around, none, tight, and through are "Optimal"?
        
        How about auto is optimal, around/tight are parallel,
        none is none, and through is through.
        
        Lets try that and see how it works.
        
        Prior patchsets submitted searched for existing examples.
        They suggest that MS Word's UI only allows for notBeside and around,
        but I kept the others there just in case something can trigger them.
        
        Change-Id: I893dfd66737bcc3148b48c68cb6df778d3f528c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152286
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [94639b415729beb2a27bcb47da2cbd5205006861]

        SwViewShell::ToggleHeaderFooterEdit already calls GetWin()->Invalidate()
        
        so this is a duplicate call, drop it
        
        Change-Id: I4d332217594f7e1ceb4692ea31a6718ecd44d1ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c9581d7ada7d6a0e62653bdfa1e419ede6324970]

        tdf#155507 don't redraw numbering when cursor enters it, if...
        
        "field shadings" are turned off and so the new output would be the same
        as it already is. Which removes a potential source of whole document
        invalidations in a multi-user collaborative scenario where participants
        may be casually clicking around the place with an expectation that it
        has limited effect on the other participants
        
        Change-Id: I2fb51ba3358bfc920aa2bff3593a0dd46f287100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152301
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [5315e6069e425aad88873beb5344bb8ea31e0c55]

        use more TypedWhichId
        
        which flushed out an inconsistency in how SID_NUMBER_TYPE_FORMAT was being used
        
        Change-Id: Ib59ae4c4950136703d18d7485db432a39e3dc39c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152300
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-26  Caolán McNamara  <caolan.mcnamara@collabora.com>  [a82e7cc9ed17a2500ad8cb9ffe54c412b0d8063f]

        ofz#59338 Abrt failed_throw
        
        Change-Id: Ib70dfef2c4ecce024162409ffd8c210d6feef1eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152297
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-26  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [ca10ae200aac01e6b238567fa637cdc293f70f7a]

        Suppress variable not used warning
        
        Change-Id: Ie154c9ad2d187adf735590da2e23420572dd5de4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152294
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-05-26  Heiko Tietze  <tietze.heiko@gmail.com>  [306093f8f82a646a2a82ebfc57fbef70af2d30a7]

        Related tdf#145080 - Less obtrusive col/row header color on macOS
        
        Change-Id: I4821643148afa205d94fe2f6178091c2acfb5bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152299
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-26  Dr. David Alan Gilbert  <dave@treblig.org>  [b480552d9c4ac9be1f53edc6cac21bc45cfe29ca]

        replace find_if by none_of
        
        A set of cases where find_if is used just to test if there are no
        matches; use none_of  as per
        
        tdf#153109
        
        Change-Id: I6c705ab7a8289914743199722a444ee40d11d746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d6dff8d9837c66d5961ea74921306110b9d747b]

        use more TypedWhichId
        
        Change-Id: Icc1cbd2717034c87bdaea1b62253b001243c6652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1b0dbcbd7016fea59b4a509d95045f643b9eeec]

        sal_uLong->sal_uInt16
        
        Change-Id: I5e62c090978cabe3cc9b065fdd2b0e2a235557f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-26  Michael Stahl  <michael.stahl@allotropia.de>  [8061cd765c7854667550d6aafda5832715648876]

        tdf#155436 svx: PDF export: fix crash on SdrMediaObj without URL
        
        Both sw and sd don't call CreateScreen() if there is no URL.
        
        (regression from commit e84b310b59825fd572d79def98c3d21566aac603)
        
        Change-Id: I087511bb6ed41b0e39321f6ca8684f60261f01cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152282
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-26  Stephan Bergmann  <sbergman@redhat.com>  [7d9b3393e2632247624d8a1e3129365290d1b60b]

        external/libxml2: Fix missing external symbols needed by xmllint
        
        After 5b42f148e206cda19467e76c2f9915fc2b6fa5f6 "ExternalProject_libxml2 still
        needs to build the xmllint executable" (which I had happened to prepare on
        macOS, so didn't originally notice the issue addressed here now), Linux builds
        like <https://ci.libreoffice.org/job/lo_callgrind_linux/13374/> started to fail
        with
        
        >   CCLD     xmllint
        > /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: xmllint-xmllint.o: in function `testSAX':
        > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/libxml2/xmllint.c:1646: undefined reference to `xmlNewSAXParserCtxt'
        > /opt/rh/devtoolset-11/root/usr/libexec/gcc/x86_64-redhat-linux/11/ld: xmllint-xmllint.o: in function `myReallocFunc':
        > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/UnpackedTarball/libxml2/xmllint.c:357: undefined reference to `xmlMemSize'
        > collect2: error: ld returned 1 exit status
        > make[2]: *** [Makefile:1007: xmllint] Error 1
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_callgrind_linux/external/libxml2/ExternalProject_libxml2.mk:37: /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/workdir/ExternalProject/libxml2/build] Error 1
        
        Turns out that those two functions have been introduced after the previously
        used libxml2 2.10.4.  No idea how things are supposed to work (given that
        workdir/UnpackedTarball/libxml2/libxml2.syms starts off with "Retained for
        backward compatibility. Don't add new symbols.", it appears that there should be
        some other mechanism at play to make xmllint on Linux find the libxml2.so
        symbols it needs, but which doesn't work as intended in our build), but just add
        those two symbols to libxml2.syms for now.  (With a new version named
        LIBXML2_2.11.4, even if the symbols can actually have been introduced in some
        other version between 2.10.4 and 2.11.4, but who cares.)
        
        Change-Id: Ib9d5c7901fe94b8014a87b049fc27ef5658fd954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152292
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-26  Miklos Vajna  <vmiklos@collabora.com>  [63de1ea465ef72ecb8d4a7dcdaf5e92ea875eb00]

        sw floattable: handle fDontBreakWrappedTables in the DOC filter
        
        This is the binary DOC import/export for the functionality added in
        commit 08fa2903df1a7cf9a1647fcf967e4c8b57dad793 (sw floattable: add a
        DoNotBreakWrappedTables compat flag, 2023-05-24).
        
        Change-Id: I91c29b9049e8e9079ed16b1beeefddfa2f6e9a6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152291
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-26  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c2bea1bedd2ee8bc4007fd23c6cb839a692297a7]

        MCGR: Border restoration support
        
        Due to tdf#155362 I added code to be able in case we
        would need it to convert a BGradient using added
        tooling from having offsets in the GradientSteps
        and no border to adapted GradientSteps and border.
        
        This is preferrable due to our GradientStyle_RECT
        (and GradientStyle_ELLIPTICAL too) use that 'non-
        linear' paint aka move-two-pixels-inside, someone
        else called it 'frame-paint'. This does not bode
        well with the border being applied 'linear' at the
        same time (argh). Thus - while in principle all is
        correct when re-importing a GradientStyle_RECT
        with a border after export to pptx, it looks
        slightly better ('correcter') wen doing so. That is
        because when being able to and restoring a border
        at least that border part *is* applied linearly.
        
        I took the chance to further apply tooling, move
        it to classes involved and instead of awt::Gradient2
        use more basegfx::BGradient since it can and does
        host tooling. This is also a preparation to be
        able to adapt (restore) border in case of turn-
        around in ODF where the importing instance is before
        MCGR existance and has to handle Start/EndColor.
        
        Needed to take more care with using BGradient instead
        of awt::Gradient2 for initialization, also better
        dividing/organization of tooling, already preparation
        to use for other purposes.
        
        Change-Id: I2d3a4240a5ac6fff9211b46642ee80366dc09e3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152194
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-26  Mike Kaganski  <mike.kaganski@collabora.com>  [7d87770986fdfc43dd5d4b514f68026ff6ededcf]

        tdf#155496: Export list header to (X)HTML using 'display: block' style
        
        This re-implements commit 013a4f1f5c9ea5fb511568c53a7e76d1b365a65d
        (sw XHTML export: fix handling of list labels, 2021-05-13), and
        instead of not putting headers (ODF 'text:list-header' elements)
        into lists, this adds 'style="display: block"' attribute to the
        respective list items. This makes sure that the items use proper
        list indentation, and produces correct markup.
        
        Change-Id: I900e4aebbe562830dc2ce5400e3e33b38c2f2faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152280
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-26  Julien Nabet  <serval2412@yahoo.fr>  [16a8943f7dbf338377fe486cc75116b89742c7b0]

        tdf#153317: direct SQL: try to detect Bit field in Mysql/MariaDB
        
        Change-Id: I462cb28c15a0cd1d3c93f2335bcac02ca09c78e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152289
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-26  Miklos Vajna  <vmiklos@collabora.com>  [0360b9940833609b80b7cf0dd782f124212b01bb]

        sw layout xml dump: extract SwRowFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about row frames.
        
        Change-Id: I31e7cbec7466f9d0677755adb631b63c156b55c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152283
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [363c6bec73fbd8677b230892f4e828457e0b5dc6]

        Fix text in IDL file
        
        + Copy&Paste is evil...
        
        Change-Id: I11352ec41d96cfbc7d4176773789066aee292a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f65949452bd3a61f0eeb1b95db7ec2ce2e1c59f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b8794b4b681e2c4f148ca626c766d961e0e3078
          - Add Sheet Events Help page, update command paths
            
            Change-Id: I90d0b82c143d467e48aed65bb422c0323875ece2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152285
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [841cbe121dd98cf51bd6e11a3afcb83126c2c791]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 027d282ebbf0cd889772eb646b756f7ee374105b
          - Refactor - no contents changed.
            
            Change-Id: Ic8492fff71c310a2dc054683ea16338254500afe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152284
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea63b3d25a7c83773721f8ba6bf6d00c059d44fe]

        use more TypedWhichId
        
        Change-Id: I6c54c1276b36cbc71417486ffcee2ef9ef0cff7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [3ec8822b62d647379999b4c09f3e72b9474b61a3]

        CppunitTest_sw_uiwriter4: disable part of test on all platforms
        
        Sometimes Jenkins also fails on mac and linux
        
        Change-Id: I198a30bfbe1dd0952e69ef8066feccc78ea11d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152278
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e810bd2b99777e192fb464572fa64a34bc0768fe]

        merge some stringadds
        
        found with a lightly tweaked version of the loplugin:stringadd
        and some hand-holding.
        
        Change-Id: I146aadcaf665e98fea89a9cad2df4dc3935622f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [578758835e700b38b167753ccda9527f3a8cc43b]

        desktop: check getDialog()
        
        it might return nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/dp_gui::TheExtensionManager::ToTop()
        
        Change-Id: I4023529aec0ba2c72b4e7db5449d235c208ee30b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152268
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-25  Mike Kaganski  <mike.kaganski@collabora.com>  [aed48f26fc8acbcc3a1eaf737619ef1f33d3cb29]

        Fix identical copypaste errors
        
        Change-Id: Ic3d93c9141fcf407493ebb9b7cfc40d1598368ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152221
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b0b164e512448cb6e04f05de6e1f1e8221f5f43c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 31fe3777cb0dc69a3badc026f4de55c096af48d9
          - tdf#154996 Add tabbed UI commands in Help page
            
            + refactoring
            
            Change-Id: I404321de45f8d4c4621a64d2f30a48421f65f86e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152249
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [edef2f05aa18d235cbd2c4f49d49d228dcd263ff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c26935e97327fd87907d41dd07f60bdf71ef8067
          - tdf#154996 Tabbed Interface command in Help pages
            
            + review the Hide / Show  sheet command
            
            Change-Id: I5dd3e9fe40f06c006282c1b62de38daadd01d2a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152248
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [f447cb9bc8ab43a5f737d27dfa61bf0e71667bbb]

        tdf#107965: partially revert fix for tdf#91312
        
        This commit partially reverts 8a11d34c7e08218b5ff9da4870c460297f312332.
        
        tdf#91312 is not reproducible after the revert because the
        conditional format logic has changed since then and now
        conditions are grouped.
        
        Change-Id: I5ae86c8c3b8611e3fdfed6adbcac7b481bc7217f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152273
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-25  Julien Nabet  <serval2412@yahoo.fr>  [e4261e4733f795da33fe8e263cf092b509ff7b4b]

        Related tdf#155443: MySQL/MariaDB direct connect, use more of the new function
        
        ...getAlterTableColumnPart().
        
        getName() and getTableName() don't deal with database/schema prefix + backticks
        
        Change-Id: I31cc9dc98de0449dfe2f6f24305290d4edb9ecb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152276
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cfc2376f804f13eb562f39182cb24fe7dc61d6ef]

        Allow bootstrap variables in Java user classpath settings
        
        This allows for relative paths to be configured as Java class path.
        
        Change-Id: Ie3e6bc3836fb316457e5c9f11dfb77d2fcd49ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152271
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-25  Michael Stahl  <michael.stahl@allotropia.de>  [21473f46fda5f1c7f220493667a96fff7c78a7b3]

        sw: fix crashtesting assert on forum-mso-en-13115.docx
        
        itrpaint.cxx:436: SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed.
        
        The problem is that there are 2 SwNumberPortion, and the 1st one doesn't
        have the m_bHasFollow flag set.
        
        The numbering suffix is 5 consecutive ' ' spaces, which is oddly enough
        considered a hook char in SwFieldPortion::Format() but not in
        SwTextFormatInfo::ScanPortionEnd().
        
        This inconsistency appears to cause the problem, and was already there
        in initial CVS import, but nothing bad seems to happen when it is
        resolved.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd
         and commit df5328ff1e472af9c69d4ff83fa13c71d644ddec)
        
        Change-Id: I602d9adb63220cb63ce8a477b617e9aeae45fb8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152274
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-25  Khaled Hosny  <khaled@libreoffice.org>  [43a5400063b17ed4ba4cbb38bdf5da4a991f60e2]

        tdf#152048: Fix underline width for Kashida-justified text
        
        Fix GenericSalLayout::GetTextWidth() again, this time doing away with
        using linearPos as it is wrong, the glyph’s position is not directly
        related to how much it contributes to the text width (for example,
        combining marks have zero advance width yet their position is different
        from the base glyph they apply too). This is a followup to:
        
        commit ce7c1c608fa99c86c8f2380cd8b82d02123f514e
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Wed Aug 31 07:07:54 2022 +0200
        
            vcl: Fix GenericSalLayout::GetTextWidth()
        
        Additionally, inserted Kashida should have its origWidth and newWidth
        both set to zero, since it does not add to the text width, all
        additional width is already added to the glyph the Kashida is applied
        to.
        
        With both fixes, the text width of Kashida-justified lines is correctly
        calculated and the underline no longer extends beyond the text line.
        
        Fix test expectation now we are reporting the real text width.
        
        Change-Id: I0de93f955929cf3030cf420cb4f4e94df974fb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152267
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@libreoffice.org>

2023-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [99097e32b205b3a37214d6f082f5f831d0422527]

        more TypedWhichId
        
        Change-Id: I2536f09fc48ff641c0e5c646ca7127f293ae5db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152259
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-25  Julien Nabet  <serval2412@yahoo.fr>  [fd113e2f44d4e821e829fb71ac51da33a3284b2f]

        Revert "BaseMutex->std::mutex in OPropertyForward"
        
        This reverts commit b0244ef9e44c5c1dc9faf9705f2ae1dba499d62c.
        
        Lock when trying to save a change in a table:
        
        #0  futex_wait (private=0, expected=2, futex_word=0x55f20be59550) at ../sysdeps/nptl/futex-internal.h:146
        #1  __GI___lll_lock_wait (futex=futex@entry=0x55f20be59550, private=0) at ./nptl/lowlevellock.c:49
        #2  0x00007f462caab262 in lll_mutex_lock_optimized (mutex=0x55f20be59550) at ./nptl/pthread_mutex_lock.c:48
        #3  ___pthread_mutex_lock (mutex=0x55f20be59550) at ./nptl/pthread_mutex_lock.c:93
        #4  0x00007f45fad12a63 in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x55f20be59550) at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/x86_64-linux-gnu/c++/12/bits/gthr-default.h:749
        #5  0x00007f45fad138c5 in std::mutex::lock() (this=0x55f20be59550) at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/std_mutex.h:100
        #6  0x00007f45fad1389c in std::unique_lock<std::mutex>::lock() (this=0x7ffd5b691a78) at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_lock.h:139
        #7  0x00007f45fad136b1 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7ffd5b691a78, __m=...) at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_lock.h:69
        #8  0x00007f45fb060b55 in dbaccess::OPropertyForward::setDefinition(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&)
            (this=0x55f20be59520, _xDest=uno::Reference to (dbaccess::OTableColumnDescriptor *) 0x55f20bd765b8) at /home/julien/lo/libreoffice/dbaccess/source/core/misc/PropertyForward.cxx:128
        #9  0x00007f45fb039edc in dbaccess::OContainerMediator::elementInserted(com::sun::star::container::ContainerEvent const&) (this=0x55f20bd9ac30, _rEvent=...)
            at /home/julien/lo/libreoffice/dbaccess/source/core/misc/ContainerMediator.cxx:105
        #10 0x00007f461ebaa03e in comphelper::OInterfaceContainerHelper3<com::sun::star::container::XContainerListener>::NotifySingleListener<com::sun::star::container::ContainerEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::container::XContainerListener> const&) const (this=0x7ffd5b691c90, listener=uno::Reference to (dbaccess::OContainerMediator *) 0x55f20bd9ac58)
            at include/comphelper/interfacecontainer3.hxx:252
        #11 0x00007f461eba9e4c in comphelper::OInterfaceContainerHelper3<com::sun::star::container::XContainerListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::container::XContainerListener>::NotifySingleListener<com::sun::star::container::ContainerEvent> >(comphelper::OInterfaceContainerHelper3<com::sun::star::container::XContainerListener>::NotifySingleListener<com::sun::star::container::ContainerEvent> const&) (this=0x55f20ba55ee0, func=...) at include/comphelper/interfacecontainer3.hxx:274
        #12 0x00007f461eb8aab3 in comphelper::OInterfaceContainerHelper3<com::sun::star::container::XContainerListener>::notifyEach<com::sun::star::container::ContainerEvent>(void (com::sun::star::container::XContainerListener::*)(com::sun::star::container::ContainerEvent const&), com::sun::star::container::ContainerEvent const&) (this=0x55f20ba55ee0, NotificationMethod=&virtual table offset 32, Event=...)
            at include/comphelper/interfacecontainer3.hxx:289
        #13 0x00007f461eb8527d in connectivity::sdbcx::OCollection::appendByDescriptor(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&)
            (this=0x55f20ba55e80, descriptor=uno::Reference to (dbaccess::OTableColumnDescriptor *) 0x55f20b909188) at /home/julien/lo/libreoffice/connectivity/source/sdbcx/VCollection.cxx:388
        #14 0x00007f45fb060571 in dbaccess::OPropertyForward::propertyChange(com::sun::star::beans::PropertyChangeEvent const&) (this=0x55f20be59520, evt=...)
            at /home/julien/lo/libreoffice/dbaccess/source/core/misc/PropertyForward.cxx:94
        #15 0x00007f462b59ac96 in cppu::OPropertySetHelper::fire(int*, com::sun::star::uno::Any const*, com::sun::star::uno::Any const*, int, unsigned char)
            (this=0x55f20b7e8098, pnHandles=0x7ffd5b69320c, pNewValues=0x7ffd5b6934a8, pOldValues=0x7ffd5b693198, nHandles=1, bVetoable=0 '\000') at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:680
        #16 0x00007f462b59bb77 in cppu::OPropertySetHelper::impl_fireAll(int*, com::sun::star::uno::Any const*, com::sun::star::uno::Any const*, int)
            (this=0x55f20b7e8098, i_handles=0x7ffd5b69320c, i_newValues=0x7ffd5b6934a8, i_oldValues=0x7ffd5b693198, i_count=1) at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:568
        #17 0x00007f462b59a64e in cppu::OPropertySetHelper::setFastPropertyValue(int, com::sun::star::uno::Any const&) (this=0x55f20b7e8098, nHandle=22, rValue=uno::Any("long": 10000))
            at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:543
        #18 0x00007f462b59884b in cppu::OPropertySetHelper::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x55f20b7e8098, rPropertyName="FormatKey", rValue=uno::Any("long": 10000))
            at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:265
        #19 0x00007f45f996faf0 in dbaui::OFieldDescription::copyColumnSettingsTo(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&)
            (this=0x55f20bf4f960, _rxColumn=uno::Reference to (dbaccess::OTableColumnWrapper *) 0x55f20b7e80a8) at /home/julien/lo/libreoffice/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx:623
        #20 0x00007f45f99784c4 in dbaui::OTableController::alterColumns() (this=0x55f20b7931e0) at /home/julien/lo/libreoffice/dbaccess/source/ui/tabledesign/TableController.cxx:1070
        #21 0x00007f45f99731d5 in dbaui::OTableController::doSaveDoc(bool) (this=0x55f20b7931e0, _bSaveAs=false) at /home/julien/lo/libreoffice/dbaccess/source/ui/tabledesign/TableController.cxx:356
        
        Change-Id: I4363cdad7339eb2ad69f9839832b11f448dd989c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152258
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-25  Stephan Bergmann  <sbergman@redhat.com>  [5b42f148e206cda19467e76c2f9915fc2b6fa5f6]

        ExternalProject_libxml2 still needs to build the xmllint executable
        
        No idea why fd6cbd983a3021d22321854d0414bdc42c6cb1b7 "upgrade to libxml2-2.11.4"
        started to only explicitly make libxml2.la (the commit message doesn't say), but
        that caused at least <https://ci.libreoffice.org/job/lo_ubsan/2788/> to fail
        with
        
        > make[1]: *** Deleting file '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CustomTarget/sfx2/classification/example.validated'
        > [build VAL] CustomTarget/sfx2/classification/example.validated
        > /bin/sh: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/libxml2//xmllint: No such file or directory
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/sfx2/CustomTarget_classification.mk:20: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/CustomTarget/sfx2/classification/example.validated] Error 1
        
        Change-Id: I7e7aa2bae05cf8674720cfd72c78840cd7a28919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152256
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-25  Miklos Vajna  <vmiklos@collabora.com>  [98a87f015800cd2e81e43732d7effe723b61e02a]

        [API CHANGE] remove XModuleUIConfigurationManager3 and XUIConfigurationManager3
        
        The motivation was to not modify XModuleUIConfigurationManager /
        XUIConfigurationManager, but as pointed out at
        <https://gerrit.libreoffice.org/c/core/+/151798/10#message-31d00a775989b981a5f50639623cc773d6ea930d>,
        it may be fine to modify XModuleUIConfigurationManager2 and
        XUIConfigurationManager2 instead of adding
        XModuleUIConfigurationManager3 and XUIConfigurationManager3.
        
        Indeed, searching for usage in <https://github.com/libreoffice/wollmux>,
        only the published interfaces are used, so let's fold
        XModuleUIConfigurationManager3 into XModuleUIConfigurationManager2 and
        XUIConfigurationManager3 into XUIConfigurationManager2.
        
        This is a reasonable middle ground between 0 API change and breaking
        known users of the public API.
        
        Change-Id: I2dedee7e255f9dda9c9057961e6c829f83b2b709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152254
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-25  Miklos Vajna  <vmiklos@collabora.com>  [f5dc52dc9a068fec3323c3089929a81675b0d1ba]

        sw floattable: handle <w:doNotBreakWrappedTables> in the DOCX filter
        
        <w:doNotBreakWrappedTables> primarily appears in documents imported from
        RTF, unless \nobrkwrptbl is specified there (which, confusingly, means
        to do split floating tables).
        
        Change-Id: I1891b89787719805e6c87045dee3c63c68ed2940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152255
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9747d9a6ea954dfca4152d36fdb28a8b77fec84b]

        xmloff: rename theme color names and color-table to theme-colors
        
        For ODF it's not needed to abbreviate names and we prefer to use
        full names. The theme color names in OOXML are abbreviated and the
        same names were used also for ODF - this was changed now.
        
        "color-table" used in "theme" element has reused the already
        existing "color-table" element name in ODF, but they don't relate
        to each other. The name was changed to "theme-colors", which makes
        more sense anyway.
        
        Change-Id: I61ec91895d301ad4343f2b977d5cbcf38e360b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152252
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-25  Julien Nabet  <serval2412@yahoo.fr>  [c557b30df03cb09ca7133d6921ece09a2a10eb3c]

        tdf#155443: MySQL/MariaDB direct connect: pb to change fieldname in table
        
        Copy and simplify "getAlterTableColumnPart" from Mysql JDBC part which seems
        to do the right job with table name.
        
        Change-Id: I94d20b002a60f2ce1ea4d7e4de8040a9cbf04994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152247
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-25  Miklos Vajna  <vmiklos@collabora.com>  [dc69e7c52f12f57197f26b56c968139186d4ed5b]

        Update pdfium to 5778
        
        - external/pdfium/abseil-trivial.patch is no longer needed, upstream
          does what we did previously
        
        - external/pdfium/build.patch.1: re-generate with 'patch -p1' + 'git
          diff'
        
        - external/pdfium/include.patch is no longer needed, upstream does what
          we did previously
        
        Change-Id: I39a6f721e436aa53914bbf43b78ac7d86e5eac59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152244
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-25  Miklos Vajna  <vmiklos@collabora.com>  [f0a9d4d4eea6562e98fd92a2797d16504e1d4db5]

        sw: fix wrong downcast in UndoManager::IsViewUndoActionIndependent()
        
        In case a user types in one view, an other user types in an other view,
        finally the first user deletes, then getting the undo state resulted in
        a memory corruption.
        
        This went wrong in commit 2875c65946e59f5dd7968155463bf00bd71d440b (sw,
        out of order undo: allow a subset of a non-empty redo list, 2021-11-11),
        the intention was to check if we have a redo item and it has the
        expected type, but we checked the type of an earlier undo action that
        belongs to the view.
        
        Fix the problem by checking the type of the correct undo action, this
        was probably a copy&paste error of mine.
        
        Resolves <https://github.com/CollaboraOnline/online/issues/6412>.
        
        Change-Id: I6cb2a081067695a045d86b4ef427cc5a76c0f9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152204
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [839c5010241842835a1c066be0838df4a8a53dc7]

        use more TypedWhichId in editeng
        
        Change-Id: I2eb2b50ef7002e23221c985ab3218617b3832aa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9a4b768b0a22bd3ae627c7355bbd223b9cf65015]

        svx: combine svx::NamedThemedColor into NamedColor
        
        Change-Id: I9a9656ddce9c12564411cfcb3e8e8714ae74a418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152236
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8e87f1f2ff4df763e29bdc097786230c6293744b]

        svx: change NamedColor be a struct instead of std::pair
        
        Change-Id: Ice1625e8cae8da859ea8a940b3f8e40f6f9d7037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152235
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [68c4d1ca207a82015120a770fbbc5c12fbe1abda]

        xmloff: rename *-color-theme-reference to *-complex-color
        
        Change-Id: I63dd83522da7699162eb06a019a679d4b8750d10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152053
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-24  Justin Luth  <jluth@mail.com>  [73a82b425b4dc02ef4ad3946b71c067a6411045c]

        tdf#138279 Revert "On double click on chart select the chart backgroud"
        
        This reverts 7.1 commit 6a915073f8400fd34274cf311994bbc9bf498ab6.
        
        The change was simply wrong. There is NOTHING about this context
        that indicates that a double-click is happening.
        
        So whatever this patch was trying to do,
        it simply was made in a completely wrong way.
        
        So best to just revert, and put the onus back on the interested
        parties to redesign a fix for their double-click issue.
        
        Change-Id: Ia209c0552839d6cce1b348432789f0f861ac5703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152023
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-24  Michael Stahl  <michael.stahl@allotropia.de>  [b0e2b60fa45f236f6a993cc1295a7afddabb5098]

        tdf#148897 tdf#143239 sw: move flys off the page in SwTextFrame::Format()
        
        The bugfix regresses testTdf143239, so we add some scary additional hacks:
        
        * testTdf143239: turns out that this was already moving back and forth
          many times but then ran into some loop control - now with the fix for
          tdf#148897 this still happens, but the result is now bad, where
          previously it was good (by accident?).
        
          Move the flys off the page also in SwTextFrame::Format() - there is
          already code there to detect that footnotes have been moved off by
          Format_() - this is similar, the formatting should be redone immediately
          if there is a fly that created SwFlyPortions in the current frame, but
          the fly was actually moved to the next page by the very same
          Format_() splitting the frame.
        
        * testKeepWithNextPlusFlyFollowTextFlow: here the problem was that the
          para with the fly didn't move back to page 1; need to clear the
          SwLayouter when toggling FieldNames.
        
        * testKeepwithnextFullheight: this test document will loop creating
          infinite pages if the newly add move code is run during
          SwObjectFormatterTextFrame - the latter must move the flys if it is
          active, not SwTextFrame::Format().
        
        This is all a bit experimental but i failed to have a better idea...
        
        (regression from previous commit)
        
        Change-Id: Icfcbd270137116198128d549b34e7f49a47b6911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152246
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-24  Michael Stahl  <michael.stahl@allotropia.de>  [35f7f1ad9c2aba1644a46dfb4da0a86f72c6a224]

        tdf#148897 sw: layout: force invalidate background when moving fly off page
        
        The fly 15 moves forward in SwLayAction::FormatContent(), then back
        again later, without being positioned on the next page, and it happens
        to go to the same position that it originally had.
        
        Then SwFlyNotify sees that the position is the same, and doesn't do any
        invalidation of the background, so the fly overlaps a text frame.
        
        When the fly is moved by the object positioning code (before the below
        commit), it first gets a new position on the next page, and then moves
        back, so all invalidations happen.
        
        Force the invalidation of the background in this case.
        
        (regression from commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf
         "sw: layout: if fly's anchor moves forward, move fly off SwPageFrame")
        
        Change-Id: Ifdc9460defe7b1f37cbb05310906146919e8fb6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152245
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [01c12264f1f6ec3b78cab0c6acb04a55b1a52903]

        Fix typo
        
        Change-Id: I9478777b375b69794a3ae61ee35842ca94b6ba1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152202
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-24  Justin Luth  <jluth@mail.com>  [446f9d77af4fe0cedf50e9cbd792cf1aee105675]

        tdf#155465 doc export: handle para last line - justify
        
        This was already OK for import in OOo 3.3,
        but never exported. DOCX export landed in 2019 (no bug report).
        
        No existing unit tests matched for DOC.
        
        make CppunitTest_sw_ww8export4 \
            CPPUNIT_TEST_NAME=testTdf155465_paraAdjustDistribute
        
        Change-Id: Iaea149c21259fe2a9002c8ce7c023327bbd13746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152199
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-24  Justin Luth  <jluth@mail.com>  [2cdb48eee93a3a93074184c5c8a82e571fb0bd04]

        tdf#141684 tdf#147740 notebookbar: fix disappearing icons in groupbar #2
        
        AFAICS, the code was non-sensical before.
        Hopefully now it is logical.
        
        Apparently returning the correct width doesn't mean much,
        but that is the only thing that should be changing in this patch.
        I would assume that returning an accurate width
        is the proper thing to do for this function...
        
        Change-Id: Iab26ac7fd8cd00127d2646f792fa552ec148dc74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152126
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-05-24  Caolán McNamara  <caolan.mcnamara@collabora.com>  [fd6cbd983a3021d22321854d0414bdc42c6cb1b7]

        upgrade to libxml2-2.11.4
        
        'checked' field removed with:
        https://gitlab.gnome.org/GNOME/libxml2/-/commit/ce76ebfd1312459951d555ad9d87fb9a89eede55
        
        win32 'run_debug' removed with:
        https://gitlab.gnome.org/GNOME/libxml2/-/commit/59f2f60e3eff07324f1c7cd861a444d714be750b
        
        add libxml2-XMLCALL-redefine.patch.0 to avoid:
        UnpackedTarball\libxml2\include\libxml/xmlexports.h(41): error C2220: the following warning is treated as an error
        UnpackedTarball\libxml2\include\libxml/xmlexports.h(41): warning C4005: 'XMLCALL': macro redefinition
        UnpackedTarball\expat\lib\expat_external.h(69): note: see previous definition of 'XMLCALL'
        
        Change-Id: Ia9b1540dc1b4eccf91662c8d995c036f71de6fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f128fc5dbb34c75cbd5fca326e1ad7cce1f485bd]

        Remove triplicated include
        
        Change-Id: I345a6e87ebf27188e9bdfe82ee364c2363b48efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152197
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-24  Stephan Bergmann  <sbergman@redhat.com>  [72b869d1c006f61bf78d8af4ce76b14489f477d4]

        Fix CppunitTest_configmgr_unit for --disable-report-builder
        
        ...after abd630e81bc150d05e4129cc22752ecf461777c7 "Allow all hierarchical path
        segments to be ['...'] quoted", which failed as the checked
        MimeTypeClassIDRelations group is conditional on install:module="reportbuilder".
        (See the comments at
        <https://gerrit.libreoffice.org/c/core/+/151673/2#message-f029dd1877f8a946647456ed73a7b60f6dfc0e8f>
        "Allow all hierarchical path segments to be ['...'] quoted".)
        
        It looks like there is no other, non-conditional property with a slash in its
        name, so the test now just tests the ['...'] syntax on an otherwise
        unproblematic property name.  (Alternatively, we could have extended the
        configuration data used by unit tests with such a problematicaly named
        property.)
        
        Change-Id: I820004a5b824326d86e67c158994f13e71ba135e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152184
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bcad9f53c8b421590beacbe1e65cb065db67d1a9]

        Remove duplicated include
        
        Change-Id: I01ff5b522433826f560c9adbe606393e449434ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152198
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [6c48e0b8e15c46b4c56a772065f3671d6bdba8e8]

        Related tdf#146518 Add Watch/Stack window commands to toolbar
        
        This patch adds the new commands WatchWindow and StackWindow to the Basic toolbar, together with the related ObjectCatalog command.
        
        Change-Id: Ia50d4a695271c6fae6446c18548930a3e9063489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151787
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fbaef1db1f63485f4cabe843c08ccf6f5ca92fd]

        remove obsolete comment
        
        Change-Id: I0b241b61f300fb3ed25b74595c3f8a7d018105b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152186
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-24  Miklos Vajna  <vmiklos@collabora.com>  [08fa2903df1a7cf9a1647fcf967e4c8b57dad793]

        sw floattable: add a DoNotBreakWrappedTables compat flag
        
        RTF doesn't break floating table across pages, and there is a matching
        DOCX compat flag to handle such documents.
        
        We can ignore floating table info on the model as a workaround, but that
        would mean the info is lost on save, so that's not ideal.
        
        Instead add a new compat flag that disables fly split at a layout level,
        which allows both not splitting tables & retaining the model-level info.
        This commit does the doc model, UNO API, layout & ODT filter, the Word
        filters are not yet updated.
        
        This compat flag is probably quite rare, so introduce a mechanism to
        only write the compat flag when it's true: this way the majority of the
        documents don't need to say anything about it and we can assume "false"
        for them. Also fix two missing xmlTextWriterEndElement() calls in the
        xml dumper.
        
        Change-Id: I32321ec204d7bfe011fcf024b97c906da0db8aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152190
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-24  Andras Timar  <andras.timar@collabora.com>  [0ce9c61f35151f115b42e24fabe6f7bae5ee8783]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 2404521a6c320ae5e307c6c0fed31d81de751a88
          - On Linux dictionaries are packaged separately
            
            Change-Id: I604a0f12bdbedc0f35a27ead0f995e9dd3a27d8b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/152191
            Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2023-05-24  Jean-Pierre Ledure  <jp@ledure.be>  [e7c4a883624745ef858d0e281e87c0483a66b791]

        ScripForge (SF_Dialog) new OrderTabs() method
        
        Set the tabulation index f a series of controls.
        The sequence of controls are given as an array
        of control names from the first to the last.
        
        Next controls will not be accessible (anymore ?)
        via the TAB key if >=1 of next conditions is met:
           - if they are not in the given list
           - if their type is FixedLine, GroupBox or ProgressBar
           - if the control is disabled
        
        Args:
           TabsList: an array of valid control names in the order of tabulation.
           Start: the tab index to be assigned to the 1st control in the list. Default = 1.
           Increment: the difference between 2 successive tab indexes. Default = 1.
        Returns:
           True when successful.
        
        The method is available from Basic and Python user scripts
        
        This change will require an update of the SF_Dialog help page.
        
        Change-Id: Ie854227691c4e182b49a521b1285deaa4de3d1ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152166
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e518624da1bdad5fcb24feb41349efa4301329e3]

        sw: fix crash in SwNode::GetFlyFormat()
        
        FindFlyFrame() might return nullptr
        See https://crashreport.libreoffice.org/stats/signature/SwNode::GetFlyFormat()
        
        Change-Id: Id99a806e62f03b8912747525c8b0235c1b23232b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152156
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-24  Stephan Bergmann  <sbergman@redhat.com>  [4f3a5acac5c1810d845e850f5199d9292c7fe1b6]

        Remove unused comphelper::adjustIndexToStartOfSurrogate
        
        ...introduced in 28cc0bff10f5dcec0c7b698ae7ba275845b2cad1 "Break
        comphelper::adjustIndexToStartOfSurrogate out of o3tl::iterateCodePoints" in
        preparation for bd5c3582581f37513f45b518e348f443d5d57334 "a11y: Fix returning
        unpaired surrogates when retrieving characters", but which never picked it up
        
        Change-Id: I5a10a3053d2f51333e27b74a808a41df7c1912ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152183
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-24  Miklos Vajna  <vmiklos@collabora.com>  [2c43b3f88d71e9bcf73d2b3ac52bad55aa5b9a7a]

        CppunitTest_sw_uiwriter4: restore part of testTdf107975 on Windows
        
        Just disable the part that in fact fails, as requested at
        <https://gerrit.libreoffice.org/c/core/+/152180/2#message-a9a5614df8b71f2b545ede872c5af9efa41a029b>.
        
        Change-Id: Ic856525505d25d7b443058e6e56151270c4c1244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152181
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2023-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [55cca83ca3544d3ae82d978b017899ced9833cc5]

        speedup drawing toolbars, cache min-width
        
        doing the style lookup for the minWidth is really very slow in gtk
        
        Change-Id: Ic7c44edada8d7205586fe569f30d92d4243642a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152182
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-24  Miklos Vajna  <vmiklos@collabora.com>  [50ab65a84ade5a14c2e48667ff6629e4907de35f]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfList
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: Id24ee8755afeed0393f7ebe164f1caf27a2e0ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152170
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-24  Baole Fang  <baole.fang@gmail.com>  [0a90b90048313fb43f8c5d7461f58dafec276600]

        tdf#148088: Fix master related UI in Draw
        
        Page/Master Page... -> Page/Change Master Page... (corresponds to Impress)
        In the above dialog:
        Available Master Slides -> Available Master Pages
        Select a Slide Design -> Select a Page Design
        After clickling load:
        Load Master Slide -> Load Master Page
        In Master mode, right click/Rename Master:
        Rename Master Slide -> Rename Master Page
        
        Change-Id: I6a8e987d6f3eaf91289ec061ec87cd76b3f90ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151489
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-24  Miklos Vajna  <vmiklos@collabora.com>  [a92965d51887b552d912304fbf9efd6d5015a82a]

        CppunitTest_sw_uiwriter4: disable testTdf107975 on Windows
        
        E.g. <https://gerrit.libreoffice.org/c/core/+/152138> failed 3 times in
        a row, always on this test, always on Windows.
        
        Also <https://gerrit.libreoffice.org/c/core/+/152170> failed 2 times in
        a row, again only on this test, only on Windows.
        
        At the same time, it doesn't fail reliably locally, so hard to debug the
        root cause.
        
        Change-Id: Iaf257d2b7ef5f46f6275b6ebcebc2156f4e58d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152180
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-24  Dr. David Alan Gilbert  <dave@treblig.org>  [69384d208a2c40c14de73d67d3620596678bf502]

        CloneList::CopyConnections: Replace duplicated code by loop
        
        There's a chunk of code copied for the two ends of the connection;
        replace it by a loop with the original code.
        
        Change-Id: I80d80f61879a08612dd8314963cccb35651c2091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152073
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f3aab159f1c1e00c25e6b4ca1e50813bc343f4f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2cbe21de3941407ffbd6957dfb88f142122ad057
          - Fix typo
            
            Change-Id: I68cced3d3101be527beea717e828da418834f117
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152134
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-23  Michael Meeks  <michael.meeks@collabora.com>  [b3768c69c20018febfe5161670fc44b19307bd0e]

        perf: surprising to see getenv on a profile.
        
        Change-Id: Id97c77d4c836e4f3c5a9eff6da07eb52d29248c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152105
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-05-23  Michael Meeks  <michael.meeks@collabora.com>  [2a1e7671795ee6c6350b7d799b9c4742ffb67e78]

        perf: surprising to see PDF being vsprintf'd during JSDialog rendering.
        
        Avoid some hundreds of these:
        
        _cairo_pdf_surface_show_page
        ...
        cairo_surface_destroy
        CairoTextRender::CairoTextRender
        
        via.
        
        SvpCairoTextRender: :SvpCairoTextRender(SvpSalGraphics&)
        SvpSalGraphics: :SvpSalGraphics()
        Change-Id: Ieefb65138f7e685f09dbf4c36a2fccd39b4b05cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [c43e39a7b7f4b0ed6165af966cce8057a93eb22f]

        tdf#155350 Do AutoCorrect of Input Method text
        
        for all of SvxAutoCorrect::IsAutoCorrectChar() chars not just
        quotes
        
        Change-Id: I368836ea3c2dcdcc7fbe6906d7ae886f312d73d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152172
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [010c05ca0eb66756b7f5db8b847e5a227d9e1ed4]

        don't InvalidateAll in online for a OuterResize case
        
        which is triggered on a new joiner to a shared document
        but doesn't seem useful in the online case at least
        
        https: //github.com/CollaboraOnline/online/issues/6379
        Change-Id: Ic5034658d9e8a7ca1dfab44ce3905b95a5705eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [e606d9336149a78eabd9440ccea2f6c2a29cd0d0]

        categorize the reasons writer calls "LockPaint"
        
        and bubble to a new InvalidateAll the collected
        reasons for that whole document Invalidate
        
        https: //github.com/CollaboraOnline/online/issues/6379
        Change-Id: Id71c59f9cafebe42085337ee1e9591eb9f1162d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152162
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  Colomban Wendling  <cwendling@hypra.fr>  [4dc2d5ec7a375f5543f3fba8c1e56988c0e8067f]

        gtk a11y: Return 0xFFFFFFFF for invalid characters
        
        Make get_character_at_offset() return 0xFFFFFFFF if fetching the
        character fails, including when querying an unpaired surrogate.
        
        https://docs.gtk.org/atspi2/method.Text.get_character_at_offset.html
        
        Change-Id: If5e2e3b6bbd4cbc86b2b8524f305f8f0d843019d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151591
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-05-23  Julien Nabet  <serval2412@yahoo.fr>  [980b5f2676c3a57022893c244617a61594c5f696]

        Revert "Related tdf#114286: put duplicates commands in GenericCommands..."
        
        This reverts commit 52a695d2ceb4231a9fcc419959e29023ecef037b.
        
        Reason: cause of tdf#155442
        Accelerator to delete row(s) conflicts with the one for adding row(s)
        
        Change-Id: If19d67a080e85d2a2716e4004db3335f0619c73f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152169
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a55299234da6df8bfba760223af30625ac32288]

        prevent some "index hint out of range" warnings
        
        Change-Id: Ib3d4dce2e535fb16a0f34c01c03c71927fa5cdd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Colomban Wendling  <cwendling@hypra.fr>  [bd5c3582581f37513f45b518e348f443d5d57334]

        a11y: Fix returning unpaired surrogates when retrieving characters
        
        Fix implementations of XAccessibleText's getTextAtIndex(),
        getTextBeforeIndex() and getTextBehindIndex() when called with
        AccessibleTextType::CHARACTER to return the whole code point rather
        than an unpaired surrogate.
        
        This is still not perfect because XAccessibleText::getCharacterCount()
        will return an incorrect value (code units rather than code points),
        but it fixes the most useful case of retrieving the character at e.g.
        the caret offset.
        
        This fixes the GTK3 and Windows backends as well without further
        changes.  Qt6 also mostly works according to Michael Weghorn, but for a
        bug on Qt's side (https://bugreports.qt.io/browse/QTBUG-113438).
        MacOS backend doesn't seem to be affected in the first place.
        
        Change-Id: I53f07bcba78c6b267939257542a521b106101e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151303
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-05-23  Justin Luth  <jluth@mail.com>  [dce8d2dbc48eb1c7597afec236dc51b4b8aede9c]

        tdf#140557 notebookbar: be smarter about hidden window size
        
        This fixes a 7.1 regression from 53d73d532281b6734a7d4614bb74fc6cc15510f0
        where notebookbar controls were being hidden (and then shown
        after a refresh of the toolbar), leaving big empty gaps.
        
        I don't know anything about vcl or window layout idiosyncracies,
        so I just read through this code looking for some way to fix
        the problem of the notebookbar not using all of its available space.
        
        The problem was that GetOutputSizePixel was returning zero.
        Why that would be I don't know. Perhaps because it had never
        actually been displayed on screen yet? (This was occurring
        on simply loading Calc.)
        
        Substituting a small DUMMY_WIDTH didn't give a very accurate
        reduction, so there was no space to add back in any items later on.
        
        When adding it back, it adds using a legitimate-seeming width,
        with an (unused this time) fallback to DUMMY_WIDTH.
        
        So, unless getLayoutRequisition cannot be depended upon for
        returning an accurate size, this should be a nice fix.
        It will no longer hide too many controls from the notebookbar.
        
        Change-Id: I1c39fe3532dad501c16f53612f8e26835b72638a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152125
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-05-23  Miklos Vajna  <vmiklos@collabora.com>  [807ad65661c122a33fccb4fd3453ef92c0e9129d]

        tdf#155002 sw floattable, split but not yet moved follow: fix GetNextFlyLeaf()
        
        Trying to open the bugdoc resulted in a layout loop since commit
        b47401e12d9c45386899df0aa26653bd26c9abd4 (sw floattable: fix assert fail
        when object formatter gets the wrong anchor, 2023-05-22), previously
        could not open due to an assertion failure.
        
        What happened is that the anchor hosted a fly frame with a table, but
        the anchor was inside a section. Instead of splitting the fly and moving
        part of it to a next page, we constantly created and deleted new pages,
        without moving anything, which is a layout loop.
        
        In fact crating a new page in SwFrame::GetNextFlyLeaf() is not correct:
        we should realize that we're inside a section and let GetNextSctLeaf()
        handle the page (and section) creation. Once the anchor code is improved
        to detect that we're in a section, GetNextSctLeaf() creates the follow
        section, and later in GetNextFlyLeaf() the call to GetNextLayoutLeaf()
        will find the new follow section. Which means we have a place for the
        follow anchor and don't create any new page, fixing the loop.
        
        The import result of the bugdoc is still not perfect, but at least we
        don't crash or hang while opening the document.
        
        Change-Id: Ic0717dddbcd0949df7d4ae766f3cc0dbbbcff27a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152163
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-23  Stephan Bergmann  <sbergman@redhat.com>  [e1819dfeb0f1436d8b957183758df0a3133c02c1]

        Avoid -Werror=unused-function when building against older GTK4
        
        ...as reported in the comment at
        <https://gerrit.libreoffice.org/c/core/+/151866/2#message-daf995784c18439280d3280877cfcf73d0bb5e9b>
        "Silence loplugin:external and lopluign:unreffun in (WIP?) a11y.cxx for now",
        
        > In file included from /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.cxx:17:
        > /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.hxx:19:24: error: ‘void* lo_accessible_get_instance_private(LoAccessible*)’ declared ‘static’ but never defined [-Werror=unused-function]
        >    19 | static inline gpointer lo_accessible_get_instance_private(LoAccessible*);
        >       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > /home/michi/development/git/libreoffice/vcl/unx/gtk4/a11y.hxx:21:24: error: ‘void* ooo_fixed_get_instance_private(OOoFixed*)’ declared ‘static’ but never defined [-Werror=unused-function]
        >    21 | static inline gpointer ooo_fixed_get_instance_private(OOoFixed*);
        >       |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I40811235a66e429e2472b50bcbaa3e6fefa6a593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152147
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ed765c818af2186e459c5ad0eff24dc39a20d34]

        tdf#155235 workaround gtk3 accessiblibility crashes on close
        
        we are still working around the problem here, which is that various bit
        are not firing accessibility events when their children change.
        
        So clear the static map in comphelper on shutdown, to prevent crashes
        resulting from objects being kept alive after vcl has shutdown
        
        Change-Id: I3ae216b345a1bb4cb4e3fde3527e4d4aa5968f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Gökay Şatır  <gokaysatir@collabora.com>  [d4bc98c5bf8d099ab1df32cc8ac30169ac537e62]

        [API CHANGE] Add createShortCutManager function to uiconfigurationmanager.
        
        We need to have different accelerator classes for differnt languages.
        This PR creates a new accelerator class for different languages.
        
        Since current code uses single instance for accelerators, i needed to add a create function.
        
        Also we now have an unordered map for different languages and modules.
        
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147157
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148680
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Change-Id: Ia646f20b3206f430ece614fc127e8b748044e4c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151798
        Tested-by: Jenkins

2023-05-23  Miklos Vajna  <vmiklos@collabora.com>  [ef76718e7146b9c7c878d598d2e9b5125b278d69]

        sd: fix crash in SdXImpressDocument::postMouseEvent()
        
        Crashreport signature:
        
        program/libsdlo.so
              SdXImpressDocument::postMouseEvent(int, int, int, int, int, int)
                      sd/source/ui/unoidl/unomodel.cxx:2615
        program/libmergedlo.so
              doc_postMouseEvent
                      desktop/source/lib/init.cxx:5007
        
        Change-Id: I321f39b284f5917048925bf45c9a6417ac9cb2ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152138
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [5719e0eb87fd8cfc072b7d5ea02b2c3cb9d3dbf7]

        in online do less whole document invalidation
        
        https://github.com/CollaboraOnline/online/issues/6379
        
        lets at least halve the num of invalidations on joining
        a session.
        
        Change-Id: I8ceb0a9ee23d632c9fb2c4a96250cc259b4a2f29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  Dr. David Alan Gilbert  <dave@treblig.org>  [26b0870f4e16a8ce53129045d6feea4f8139487f]

        tdf#120283 CopyObjects: Use CloneList to wire up connectors
        
        Remove the old connector wiring code and replace it by CloneList.
        The copy/paste code uses CloneList to do this work, and CloneList
        knows how to deal with groups; and not dealing with groups
        is the cause of
        
        tdf#120283
        
        Change-Id: I48476a93a89c1a14f55ba206e0c8354823d0e8c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Noel Grandin  <noelgrandin@gmail.com>  [8de6e211b760761f1f80b2a7371a5f6b640ab14e]

        tdf#155410 move some layer/object visibility computation inside SdrObject
        
        which has the nice effect of
        (a) removing some duplicated code
        (b) being more efficient with deeply nested complex objects
        
        Change-Id: Ifee10d40fca3faac0f5a7b79febdba756850f30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152124
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Stephan Bergmann  <sbergman@redhat.com>  [f1ac4376ffaee143ad24931744637aa0a4717016]

        Don't even bother to introduce unused variables
        
        With <https://gerrit.libreoffice.org/c/core/+/152157> "More conservative
        SAL_WARN_UNUSED to avoid -Werror,-Wunused-private-field", these two cases would
        have started to cause "unused variable declaration [loplugin:casttovoid]"
        (because the call to isWarnUnusedType in compilerplugins/clang/casttovoid.cxx
        would no longer return true).  Just avoid that by not introducing the variables
        in the first place.
        
        Change-Id: I3d2b085082555d1765fbd32045b5157deb0af67e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152158
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fac9a110961f19006c3041be0c4b920a5eafe7b]

        tdf#155410 speedup shutdown when document has lots of images
        
        prevent unnecessary broadcasting during teardown of draw model
        
        regression from
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            ref-count SdrObject
        
        The above patch seems to have changed the destruction ordering and now
        we do lots of unnecessary broadcasting.
        
        Change-Id: I90f4e560bc82834246a323275d13ef8ee8abeae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1167bfefe539417a24016f2c4e69f39ed10d2624]

        avoid some ref-counting traffic in SvxShape::Notify
        
        which is quite a hot method
        
        Change-Id: I7fe6557d48cff8c9312b4dbcd24c215f16b9fcfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [42d4143974d1e7ae991ae2301d34bc61b996e61a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b79b0b978cd10d8bd2ef7ecf15972bfd1d778f3f
          - Add missing file
            
            this must fix https://gerrit.libreoffice.org/c/help/+/152130
            
            Change-Id: Ic7c418c5993429cc622aa9a61023be3a58bb6f3e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152159
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [0916808ed8f39604bc105cd74200090a409e8618]

        sw: fix crash in DocumentLayoutManager::CopyLayoutFormat
        
        See https://crashreport.libreoffice.org/stats/signature/sw::DocumentLayoutManager::CopyLayoutFormat(SwFrameFormat%20const%20&,SwFormatAnchor%20const%20&,bool,bool)
        
        Change-Id: I1680bb79be4c1eb2ff18ed46dfa286da5e729e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152015
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-05-23  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [639519dc2bad058197b6ff73c9e3df622f979f97]

        tdf#100034: Fix to persistently remove print-range
        
        Don't save print range if the builtin index is unknow
        and sheet index is vaild (this is a deleted range).
        
        Change-Id: I10dfa98ad4f24d0f5958053974bd75cb19c85147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152081
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-23  Jussi Pakkanen  <jpakkane@gmail.com>  [0f6bf89b1f3fb7e089d928d3ac27bed59fd7d364]

        Add configure switch to enable building the installer with WiX.
        
        Change-Id: I5b1cf7a4a90c65b27fd3a9e2f33c9ffe044704e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151738
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-05-23  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2ab9d3ff3f16352c3b05dbe87d31d37654506e5]

        ofz#59210 Abrt
        
        Change-Id: I464f508324e66125a1578f162b5be31b00397075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152082
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-23  László Németh  <nemeth@numbertext.org>  [8b85bf77f461dfe095b09df5cfa4ec501fd1c199]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e868c6a2b11784ff728588ef15f310737dce2747
          - Update Hungarian dictionary
            
            Change-Id: I6627735ffefd6547deec31ece44faa57d3f4b3c4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/152089
            Tested-by: László Németh <nemeth@numbertext.org>
            Reviewed-by: László Németh <nemeth@numbertext.org>
            
2023-05-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [e6ad415037b0b0bc77cd742af8260d99c1610c11]

        MCGR: Check correctly for used FillTransparenceGradient
        
        To correctly check using UNO API if a FillTransparence-
        Gradient is used it is necessary to check if a Name for
        it is set. This corresponds to the IsEnabled() state
        of the XFillFloatTransparenceItem in the core.
        
        This was not consequently done that way and e.g. was
        done by checking if the FTG was 'default' in the sense
        that the StartColor was COL_BLACK. This was never
        sufficient and is not with MCGRs, too.
        
        Important in this case is the UnitTest checking for
        file fdo66688.docx - the re-export/roundtrip goes
        wrong when not doing this correctly.
        
        Change-Id: Iaf14c1e4481188124f044b4b3c8bcd6689c65aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152087
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-23  Heiko Tietze  <tietze.heiko@gmail.com>  [258686a58f909ab04c7281c05f15882eb400748e]

        Resolves tdf#145080 - Use accent color for focused cell
        
        Accent color added but effectively working only on macOS
        See inline comments for gtk, qt, and win
        
        Change-Id: I1e4a729331735683921f94b27bb2bb02555c0165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151887
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-23  Miklos Vajna  <vmiklos@collabora.com>  [dc11f5b151e1a2ea2623fc8cf806a400763955d9]

        tdf#143445 DOC import: limit the usage of the CONTINUOUS_ENDNOTES compat flag
        
        The bugdoc has 72 endnotes and not all of them were listed at the end
        of the document, since commit 4814e8caa5f06c4fe438dfd7d7315e4a2410ea18
        (tdf#124601 sw: add ContinuousEndnotes layout compat option,
        2019-09-30).
        
        The problem is that for simple documents the strategy to just place the
        endnotes (in the form of footnotes) on the last page works, but this
        approach breaks when the document is growing, since nobody moves the
        endnotes from the former last page to the new last page. Additionally,
        it's not trivial to know what the effective last page is, once you have
        enough endnotes that the end of the body text is not on the last page.
        
        Fix the problem by restricting when the DOC import sets this compat
        flag. The limit is picked to be 2 endnotes, just because that keeps the
        use-cases for continuous endnotes working.
        
        A future solution would be to create a layout-level section at the end
        of the document for such endnotes: that would allow them to be inline,
        and we know how to keep endnotes inside a section & know how to keep a
        section at the end of the document. But that would be a bit of a feature
        work, let's keep this regression fix simple.
        
        Change-Id: Ideea1c52f4e31ded3e28e9441aace2bc3857079e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152127
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e3ac3b79cd535e940495d911fcd9305356729369]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 017955e2322d86929802db5ebcbce65889345528
          - remove xml-lang, formatting clean-up, no i10n consequences
            
            Change-Id: I7ce3f3722c6a3f52f89623f39683d0a23daa8f36
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152101
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-05-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [13c4a7e1700b60e595e86b864d4feeb9cc383961]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26a379d7f2c21de638bbeb1e7d4032896ac326d4
          - tdf#153561 embed sections: <hyperlink>,<tab_options>,<headinginfo>,<eval>,<tab_relative>
            
                remove <xml-lang>
            
            Change-Id: Ia8aa894ffc112d7ec16991cbcc44ab963903fc52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152099
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-05-23  Maxim Monastirsky  <momonasmon@gmail.com>  [0a74b5fcfbfa68ad1cab228d74f08e8c35bc6820]

        sc drawstyles: Enable the clear DF command
        
        .uno:StandardTextAttributes works for shape formatting already
        (despite its name), but it's a different command than Format >
        Clear DF. So let's connect the regular Clear DF command to the
        same code.
        
        Also includes a workaround for comments to maintain their size.
        Changing the size (because of the "Fit height to text" setting)
        is probably confusing for other shapes as well, but for comments
        this requires an extra step to undo, as comments can't be resized
        unless they're shown permanently. And manually resizing each
        comment back will also result with inconsistency in their size.
        
        Change-Id: I7c158523ecc4be18d17479632eaf9fd2a51dca12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151161
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1497d5c8dd97df0559cf718b5a78678aa5788eb1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d37d30f9474ae437544ce04cfdcbc4ba4119303
          - tdf#153561 add <note> for heading info section
            
               remove <xml-lang> from bookmarks
            
            Change-Id: I75d1e5b2882816a66fc9859a881ae34381c969dd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152100
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-05-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6df5db55a78281e5a92441e6d125eb7f1d340800]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed9181c7a7b65f1de07c809b5ac515e4dfc73b7b
          - tdf#153561 add <section> to hyperlink, update hyperlink description
            
              remove <xml-lang> from bookmarks
            
            Change-Id: Ia29f026c9e40a58633c4428066ba9c8269cfe88c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152098
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-05-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [343fbe76d5122aed28c3ec6e72ff8629a4f95f1d]

        tdf#155065  change label for "Page Number" -> "Page Number Field"
        
        Change-Id: I80b646857311e9fa910f3384e49ea965a1a7fb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151284
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [23a41c919602828acb88a477f3f073154d9388ec]

        tdf#155065  hide .uno:PageOffsetDialog from Customize dialog
        
        Change-Id: Iad95d757ed09921403f41ed3c757b34149ec8c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151285
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-05-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [098e9426ad0b66b3da873a519c10047cb3955b0f]

        tdf#154186 change "OK" to "Apply" and rearrange button position
        
          Some buttons are sorted automatically. As a result, the "close"
          button appears in the desired position, after the label change.
        
        Change-Id: I67ce06825a642fa34086f97a99cde8ac2acb1ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151195
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c244e0a3017ede5e913420f6d57b51ce2d61dd4e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 033dc1a727a6cb48419a08990a2b737058afd99f
          - Calc Sheet Tab Navigator help page
            
            Change-Id: Ie79a7e1b6e3383d52660e48d145bec5ca7ca89af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152130
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [46a238dcf262a48c9c92f20cab30bf6590868f12]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f412e2dadeeba74aa71293d010d9a6d092d38e64
          - tdf#140091 Precisions for the (+) button in sheet tabs bar.
            
            Change-Id: I6c125b5fa230690f598399b68e1f310f4cbc25d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152129
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60489faa6c4dff83abcf63d615a16c71a412b856]

        Fix typo
        
        Change-Id: Ic3f79113f09be10f6ff33183b09f80e269f77f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152122
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fba847a7fc515b271b60c1a3fe54254cc4424423]

        Fix typo
        
        Change-Id: I6fab6b5c40eb9668df72ea01a2d158eabdc99f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152121
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-22  Regina Henschel  <rb.henschel@t-online.de>  [1d2830b936d02ed0882d9cc1234ddafb3bb7e8dd]

        tdf#155271 add drawooo:display to libreoffice-schema
        
        Commit 33ef17ed had introduced attribute drawooo:display at 2010-03-02.
        The entry in libreoffice-schema.rng was missing and therefore
        validation in unit tests fails, when this attribute occures.
        
        The attribute is written in case an object in Calc is hidden by hiding
        the cell to which it is anchored, for example. The attribute belongs to
        properties 'Visibile' and 'Printable' in 'Shape Service' in API.
        
        Change-Id: Id3d2e7984aed146fca9e2819eb183d7d7bfaf701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152119
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-22  Miklos Vajna  <vmiklos@collabora.com>  [b47401e12d9c45386899df0aa26653bd26c9abd4]

        sw floattable: fix assert fail when object formatter gets the wrong anchor
        
        A subset of the tdf#155002 bugdoc hit an assertion failure in
        SwObjectFormatterTextFrame::DoFormatObj() for multi-page floating
        tables.
        
        What happens is that a section frame wants to format its content, calls
        CalcContent(), which assumes that the text frame's all draw objects are
        also on the same page, as long as they are at-para anchored. This is
        true for at-para anchored images, but not for split flys.
        
        Fix the problem by using FindAnchorCharFrame() to know if the anchored
        object should be inside the master anchor or a follow anchor: that
        allows invoking SwObjectFormatter::FormatObj() with the correct anchor
        and page frames, so we don't hit the assertion failure.
        
        The hang with the original tdf#155002 bugdoc needs more work, still.
        
        Change-Id: I2b4d88ccb2ff251c0b0811c31d2aa85053143443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152116
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [e34bb6e67aefde2fa1e7e12635a016a2076a11bd]

        tdf#155368: sc_subsequent_export: Add unittest
        
        Change-Id: Ie177342720df50d160600cf133b87bdf3411203d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152114
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e7e9991fd06ba2e0484ae5e6b6acc323ab8bf66b]

        tdf#146547 Mark read-only docs as modified
        
        when an editable section is changed.
        
        Change-Id: I588b09f160974d3a3833bfa011fd07f2ee496616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151535
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4c220b56c25a5a78106b9d0fc06280968ccdb28]

        improve logging when we get an exception in copyProperties
        
        Change-Id: Id37ad92df93667536efaac86db3765da98847184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-22  Jean-Pierre Ledure  <jp@ledure.be>  [0a1022b04c90d36e16dee121923ca4111386585b]

        ScriptForge (SFDialogs: create dialogs on-the-fly
        
        A dialog service is returned by next statement
        
          dialog = CreateScriptService("newdialog", dialogname, place)
        
        All properties and methods applicable to predefined
        dialogs are available for such new dialogs.
        In particular the series of CreateXXX() methods for the addition
        of ne dialog controls.
        
        The functionality is available from Basic and Python user
        scripts.
        
        An update of the SFDialogs.SF_Dialog help page is required.
        
        A display rendering unstability (flickerings, delays, ..) has
        been observed when (all conditions must be met)
        - the user script is run from Python
        - from inside the LibreOffice process
        - the dialog is non-modal
        
        Change-Id: Id3f311cd04497fd79712ce712bdb2724b5caa861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152071
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-05-22  Tibor Nagy  <nagy.tibor2@nisz.hu>  [8af6c46a9c0e86bbbd908e96ff236ad1d6c4ddab]

        tdf#155319 sc: fix conditional format data bar after copying
        
        This is a follow up to commit I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6
        (tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color
         scale)
        
        Change-Id: Iacc1f5af762e1f6a40ecd13c33384e4a3340822a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151860
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4a162c4cdc9fd95bdbeb6a71b9b7689f242c2906]

        Update git submodules
        
        * Update translations from branch 'master'
          to b2e864f9b44f85777d7679cb3696a5a801b8ee97
          - update translations for master/7.6
            
            and force-fix errors using pocheck
            
            Change-Id: Iec9043ba6ba5c1520fd5906a7ebfc8c7ae94a2c5
            
2023-05-22  Miklos Vajna  <vmiklos@collabora.com>  [a97374fca86e4073c83a8e539d97462c23dd32b8]

        sw: prefix members of XMLGradientStyleExport, XMLGradientStyleImport, ...
        
        ... XMLHatchStyleExport and XMLHatchStyleImport
        
        See tdf#94879 for motivation.
        
        Change-Id: I2dd4c97c6e234447190e46bd6f6a6354e16911bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152077
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-22  Noel Grandin  <noelgrandin@gmail.com>  [8cc51cf9886a1e2f185c3824b71c960c08a9bf2e]

        tdf#155368 Can't toggle Wrap Text on all cells if cell already has
        
        The problem is not so much that we cannot toggle, it is that we
        cannot unset a toggle property.
        And the reason for that, is that the state of the toggle never
        goes off because the view state as computed by
        ScViewFunc::GetSelectionPattern is different
        from the state that is seen in ScViewFunc::ApplySelectionPattern
        where we apply the pattern.
        
        So make the same shrink-data-area adjustment in GetSelectionPattern.
        
        Change-Id: Ic56145ee98ead931278767851f74e0ce7422a150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f4c24da1e7f11664e0d2f688d2531f068e4a3bc0]

        Revert "tdf#63130 when getting the size, do not do a full paint"
        
        because it is triggering many CppunitTest_toolkit_a11y failures
        
        This reverts commit 67c3b3becab2aa2b9522e3a092d46bfe507c3101.
        
        ImplCallResize is not called on the same Window after that
        commit than it was originally called on.
        
        Change-Id: I0c3721d2674067ac7f0bf765e0fe1097b1d67dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152026
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-21  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bfc8221c9e903ffe843fceb502b054921a647035]

        tdf#155349 add a test case to catch if full invalidation ever returns
        
        Change-Id: Ifea1102fd27643ba950b4c9e8d42dd06c1ce71e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-21  Regina Henschel  <rb.henschel@t-online.de>  [58926cc60c7868785c8db126fc199f6731269b86]

        tdf#155412 ooxml export typeface attribute is mandatory
        
        The attribute 'typeface' is required for <a:ea>, <a:cs> and <a:latin>
        elements, see CT_TextFont in ISO/IEC 29500-1:2016. Its value may be
        the empty string.
        
        Change-Id: I7c9316fa40ad6d1aabccb4191fee11be553c453b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152024
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f0dbebc76b819adebf228fbdb0f25a6ee14187c9]

        oox: convert odp documents to fodp so it is easiert to change
        
        Mainly to change the non yet fixed theme ODF format.
        
        Change-Id: Iad51de7b4f9a721e566fe12266e633534c15bb54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152052
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f8cd1d5f0a6f515d8c06b8d4b189eade800d9b5d]

        xmloff: rename XMLThemeColorHandler to XMLComplexColorHandler
        
        Change-Id: Ib24c4b819c31cdc6a9626b09a5b2acd10389ad7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152051
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [66fff7efab4dd1ff08b43ed6d2d557ecad578509]

        xmloff: rename XMLThemeColorExport to XMLComplexColorExport
        
        Change-Id: I3d943f20e76b8f3e0409d307d11e3bf16489bf02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152050
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e1cc0f3e7adc9d4c930a1c37bbe45c69dd3725ab]

        xmloff: rename XMLThemeColorContext to XMLComplexColorContext
        
        Change-Id: I039aea6656cc8dedd74782f4fda8b0e1c25d3910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152029
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-21  Mike Kaganski  <mike.kaganski@collabora.com>  [8843e4c441b881a68b46bc08019ff994c9aa574d]

        Simplify a bit
        
        Change-Id: I4be66ff1ea2a15d3345134f4131bd0fabb5de9ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152028
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-20  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1fec168aff4569827d4822c9fcff7bc4ecd0d04b]

        ofz#59028 avoid config
        
        make this actually do nothing to test a point
        
        Change-Id: I353dc2bbbcd9229518f6527fe1589a901a9adfd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151833
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-20  Justin Luth  <jluth@mail.com>  [02c56a8d3ea86f28ffbdd645f83d1d4de2b56bea]

        tdf#90408 Revert #i79169# save/apply attributes of macrobutton text
        
        This reverts ancient commit a79a0101f114e0fcac40503220c5d34750124367.
        
        I'm not sure what problem it was trying to solve,
        but it doesn't seem necessary now.
        At least, I took my unit test and set some different
        font sizes to them, and they correctly got those attributes.
        
        This was the original file that needed to be fixed:
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf90408
        
        This is for the current bug report:
        make CppunitTest_sw_ww8export4 CPPUNIT_TEST_NAME=testTdf90408B
        
        Change-Id: I09fb3bd12d645318f1024ac78a9b3154a1fcd078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152025
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-20  Justin Luth  <jluth@mail.com>  [fc15f483988622b8e3ea2a97c9a8593f2beb18fb]

        tdf#139512: partial revert default row height on new sd tables
        
        Back in 5.0, a regression caused the cell height to ignore
        the font height for any empty rows. Well, of course all rows
        are empty for a new table, so the table was created with only
        a super tiny row height.
        
        That 5.0 regression was properly fixed in 7.4.2 with tdf#144092,
        so the height of new rows should automatically be appropriate
        for the current font size.
        (It was already somewhat fixed in 5.1.1 - enough for this bug.)
        
        Thus, we can revert back to the original default size (200),
        since there were complaints that my default size (2000)
        was too big.
        
        In practice, each row height will be approximately 750,
        since Draw/Impress always create tables with 18pt font size.
        200 is appropriate for 4pt font.
        
        Change-Id: Ic03d94ea3557581fd96613a408ab233b2c2c6a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152021
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-20  Dennis Francis  <dennis.francis@collabora.com>  [4536694edb7e564ea1f4ae871e9107f52ed0972f]

        tdf#155369 ScIndirect: handle names that resolve to...
        
        table structured references.
        
        Conflicts:
        	sc/qa/unit/subsequent_filters_test2.cxx
        
        Change-Id: I897feeeb49e63c1758cf64450799acb192e2d593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151888
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-05-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [01efc938229b03faf79555a04efc7526dd68d7e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8322f7d3b512cbd1a548a1b37d07d5614e3bb3c6
          - Comesmetic change for better user experience
            
            Change-Id: Ib7e442356c4e8f0deb796a009994da9785cc65e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152032
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [075ecc1c31199d0fd0f930cf1b803b04a3b17ce8]

        tdf#155407: fix the second replacement in FnChgToEnEmDash
        
        It was broken from the beginning. The second replacement could
        look into a wrong string when checking if the characters around
        the "--" are eligible; it could use obsolete indices in the
        document, ignoring the previous replacement that changed the
        lendth of the text.
        
        This also replaces a use of char* to hold Unicode codepoints to
        pass to lcl_IsInAsciiArr, with an array of sal_Unicode (because
        all the checked values fit into it).
        
        Change-Id: I949630abc564fc0875be0b92228846497bb1a022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152002
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-20  Jean-Pierre Ledure  <jp@ledure.be>  [f692b5c5e4e9c57fb69d0054c654486a737d19bd]

        ScriptForge New method dialog.CreateHyperlink()
        
        Method (Dialog service)
          CreateHyperlink(controlname, place, border, multiline,
                          align, verticalalign)
        
        completes the set of available methods for
        dynamic DialogControl creation.
        
        Cfr. https://gerrit.libreoffice.org/c/core/+/151896
        
        Change-Id: I162075ea39efdd2e1189fe8b16ac05316e6a13ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151954
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-05-20  Julien Nabet  <serval2412@yahoo.fr>  [82816547ccda994acfa6ec63a98f561f615efcfa]

        idl: they're not params but attributes
        
        Fix these warnings:
        /home/tdf/jenkins/workspace/gerrit_windows@2/offapi/com/sun/star/ui/dialogs/DialogClosedEvent.idl:33:
        warning: com::sun::star::ui::dialogs::DialogClosedEvent::DialogResult has @param documentation sections but no arguments
        
        /home/tdf/jenkins/workspace/gerrit_windows@2/offapi/com/sun/star/ui/dialogs/FilePickerEvent.idl:29:
        warning: com::sun::star::ui::dialogs::FilePickerEvent::ElementId has @param documentation sections but no arguments
        
        Change-Id: Ic2ae5f70f3f6aa744bd61044f80e9ab525407ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152020
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [8270eb5d5600cc84dbf5f0e339f90c4519ef88bb]

        loplugin:unusedmethods
        
        Change-Id: Ief95f111350808f010539bb733a553007d30a9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152006
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f3dd930324552aec40b333d750ec7b95ff03c26]

        loplugin:unusedfields
        
        Change-Id: I5036b484055e516fd808428238a044e12d34e089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a3d566165c0580ab41334cb3e031465df1f839ad]

        docmodel: add hash to ComplexColor and Transformation classes
        
        Change-Id: I206235162b057f184fbd413982c06f9bd9fa8a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152013
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c53a8284cf1740af7035b952fbc040a785117319]

        sw: prevent crash in TextContrastCheck
        
        Change-Id: Idc8740a275b9f49aca08d8a3add9a88f9d53a220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152012
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [028c974cf2fcb9494f42267edf1427cb45342f39]

        prefix SvxBorderLine aColor attribute
        
        Change-Id: I77f950a88e5875469a95c3ec37716b99328672f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151855
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-19  Julien Nabet  <serval2412@yahoo.fr>  [45826e60d5f1508d54b0f0a4d98b0e2ebe94a097]

        XML forms: remove duplicate addEventListener DOMAttrModified with capture true
        
        since commit b2a54aa2e4d215edc30cfecc397eeb3eeff1e5bc
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Wed Mar 23 10:34:34 2005 +0000
        
        Change-Id: I8f511d1efa0e2ee713d1e7c145cc60f4945aa8cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151983
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-19  Miklos Vajna  <vmiklos@collabora.com>  [632f36cc972116cd8da8245590f74014c22532db]

        sw floattable: fix legacy max height of split flys with negative vert offset
        
        A reduced bugdoc from tdf#155002 had 2 floating tables, the one on the
        2nd page was split to two fly frames, so the first and the second row
        overlapped.
        
        This is similar to what was fixed in commit
        4cb6e54a3dcdd771ef76bd98b58f0bf1c4be4c45 (sw floattable: fix missing
        table join when moving master fly to next page, 2023-05-18), but here we
        are in the legacy layout mode, which allows floating tables outside the
        body frame, somewhat. The exact detail here is that the vertical offset
        of the floating table is -179 twips, and Word also splits the table to 2
        floating frames in case there is no such vertical offset.
        
        Fix the problem by ignoring the part of the fly frame that is
        overlapping with the top margin area, this way the 2nd floating table
        fits the 2nd page and our layout matches Word.
        
        The crash with the original tdf#155002 bugdoc needs more work, still.
        
        Change-Id: I61ac54116480904320c7fa7cc557e0fcaf792739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152011
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [41e21afa59d8c7cfd5593bba1d384d80c561e12e]

        loplugin:unnecessaryvirtual
        
        Change-Id: I3a3d4debd83f1a6452721ce704b6b88622b38109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d07ee9a54e0b929ab116b08227e20f4a9c330e9]

        loplugin:virtualdead
        
        Change-Id: I089fd6b9281cc35768462e83a7e18588f357df4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [8dfceb4e0b05b9d531e27e38b954f18e33091f8a]

        sw: fix crash in GotoNextLayoutTextFrame/GotoPrevLayoutTextFrame
        
        See
        https://crashreport.libreoffice.org/stats/signature/sw::GotoPrevLayoutTextFrame(SwNodeIndex%20&,SwRootFrame%20const%20*)
        and
        https://crashreport.libreoffice.org/stats/signature/sw::GotoNextLayoutTextFrame(SwNodeIndex%20&,SwRootFrame%20const%20*)
        
        Change-Id: I2233078051bd653de5634f1e0dabab9c1f59acb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151994
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-05-19  László Németh  <nemeth@numbertext.org>  [5facae7614a1a82ed51241f50cec8e82bfb2cbda]

        tdf#155343 sw tracked table column: add tooltip
        
        Tooltip of a deleted table column shows "Column Deleted",
        an inserted table column (will) show "Column Inserted".
        
        Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column" and
        commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535
        "tdf#146144 sw: add tooltip to table rows with change tracking".
        
        Change-Id: I79fd2397410328b320bd2536285cc5cc835da9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151998
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-19  Miklos Vajna  <vmiklos@collabora.com>  [d0a91310d481f4219608dedf481bd9824da97b2c]

        CppunitTest_sc_dataprovider: fix sanitizers failure
        
        Type info for ScCondFormatItem is now needed, see
        <https://ci.libreoffice.org/job/lo_ubsan/2782/console>.
        
        Change-Id: I7cd7762bbd9f961e78d6f2fa98a808ff88a82269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151993
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a085af7dab7b6d69bd4bda9b7aa7963de688c40b]

        Fix typo
        
        Change-Id: Iae2332f088a5ed48f373f6f5389c4ea47f64f308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151986
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0a8648f6d334a5aee4e39e265acacb655ae1d5b1]

        Fix typo
        
        Change-Id: If39ff84ec74e29fdfcd21194ef371108b591caed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151996
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b4422a065959dced98dda109697ed1c322246d24]

        Fix typo
        
        Change-Id: I27c03c0312331b7f1050f5edb28fc5e658240b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151997
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-19  Tünde Tóth  <toth.tunde@nisz.hu>  [deb2512e5ea16ad8fa9f975569fbc5363cebf8dd]

        tdf#148142 chart: fix export of modified On/Between tick marks
        
        Reset the MajorOrigin property after import to avoid
        of the bad export of the modified document, which reset
        the original On tick marks/Between tick marks value.
        
        Follow-up to commit 40d83914d43f60a196dfabddea0b52e2046b333a
        "tdf#127792 implement UNO chart attribute MajorOrigin".
        
        Change-Id: I0e3915b7d1b601abd40fbd1ba9d01fc05a8fb7c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151885
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-19  Matti Tyrväinen  <matty@uef.fi>  [384a80fc56e75e3d1ee18ffc303db85490716829]

        tdf#81720 Don't expand Reference Marks
        
        Make Reference Marks behave like nesting attributes such as
        Hyperlinks. This is described as the ideal behavior in
        <https://bugs.documentfoundation.org/show_bug.cgi?id=81720#c24>
        
        Change-Id: I34ddfb3a6aa0147ba4bc281ebbb6342089b7bd08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146941
        Reviewed-by: Matti <matty@uef.fi>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-19  Michael Stahl  <michael.stahl@allotropia.de>  [595b42b686b33bbba0eeba1740277b5f6e0f5433]

        tdf#155346 sw: fix crash from changing modal mode
        
        When closing the dialog, UpdateCursor() creates a table cursor for
        ExtendedSelectedAll() because mbSelectAll isn't set.
        
        1  SwShellTableCursor::SwShellTableCursor
        2  SwCursorShell::UpdateCursor
        3  SwCursorShell::ShowCursor
        4  SwView::ShowCursor
        5  SfxViewFrame::Enable
        6  SfxViewFrame::Notify
        7  SfxBroadcaster::Broadcast
        8  SfxObjectShell::SetModalMode_Impl
        9  SfxViewFrame::SetModalMode
        
        (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
        
        Change-Id: Ie73f8e42f764f8041288eb0850721a530d106a0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151880
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-19  Miklos Vajna  <vmiklos@collabora.com>  [4f84b4c23f4634cd5b9f24a2fd61712dc85306a6]

        CppunitTest_sw_core_edit: add test for the FnChgToEnEmDash() fix
        
        Fails with commit 971c9945825db02a4809538d26fff3ae77d16866 (Fix
        "AddressSanitizer: heap-use-after-free", 2023-05-18) reverted in an ASan
        build.
        
        Change-Id: Ie87039c2c46abaf2f73cb1bbad48d2d1f7e59392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151991
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [428b8a8d23e473fecf2916591615ff38611b93c9]

        MCGR: Adaptions to WriteGradientFill and BGradient
        
        Added code to make WriteGradientFill directly use the
        available BGradient implementation. The goal is to
        never directly work on awt::Gradient2, but use
        BGradient & it's tooling methods.
        
        Added constructors and tooling to BGradient and
        BColorStops to make that easier (single line
        conversions between uno::Any, basesgfx classes
        and awt:: incarnations). Directly handle uno::Any
        and awt:: classes, changed stuff to make use of
        this.
        
        Change-Id: I083a323b9efee8ca4f3becb2966aac0a294b9a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151842
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [286a1c03fa10acf60f076a0af987112d24cb2ff5]

        sc: check excel::getDocShell
        
        There seems to be some crashes related. See
        https://crashreport.libreoffice.org/stats/signature/ScDocShell::GetDocument()
        or
        https://crashreport.libreoffice.org/stats/signature/ScDocShell::RegisterAutomationWorkbookObject(com::sun::star::uno::Reference%3Cooo::vba::excel::XWorkbook%3E%20const%20&)
        
        Change-Id: I9affce5a28cb1198eb472d369debf83fd7dd8c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151955
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [63707596eefa4f141a5c7146e69bb5684ed51cf6]

        svx: check SfxObjectShell::Current()
        
        See https://crashreport.libreoffice.org/stats/signature/static%20void%20%60anonymous%20namespace'::SvxStyleBox_Base::Select(bool)
        
        Change-Id: I6edce9c8bad1ee087ddf884ff47439cceee3f1de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151964
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [bd9430864240d3073333ce4e7461ae148b9226d3]

        bPaint is now always true here
        
        Change-Id: I9a9ef0b85140dd622c42983613464f76e29ee35e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-19  Caolán McNamara  <caolan.mcnamara@collabora.com>  [669b95e6c99f9fc0ade7c23322b7142ef497133b]

        Related: tdf#155349 drop SetEndActionByVirDev from the html import
        
        EndActionByVirDev only arises in the non-mainstream use html web document case and precedes the introduction of DoubleBuffer. It would be helpful to have one less corner case to consider.
        
        Change-Id: Ibb9064cf5b37b1806f90c24ad9fbf84a8e37c0c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-19  Miklos Vajna  <vmiklos@collabora.com>  [4cb6e54a3dcdd771ef76bd98b58f0bf1c4be4c45]

        sw floattable: fix missing table join when moving master fly to next page
        
        A reduced bugdoc from tdf#155002 has 2 floating tables: one table on the
        first page, second table on the second page. The second page had 2 fly
        frames: the first row of the 2nd table in the first fly and the
        remaining rows from the 2nd table in the second fly, and they were not
        joined, which lead to overlapping text.
        
        It seems what happens is that the fly is split: first row goes to the
        first page, rest goes to the second page. Later we move the master fly
        to the 2nd page as well, but we don't try to join the table, since the
        master fly has no additional space. It's a circular problem: once we
        split the fly, we limit the master fly size to what's necessary, so once
        the 2 flys are on the same page, we don't move content from the follow
        fly to the master fly because we believe it has no space... but it has
        no space because the content is not moved.
        
        Solve this problem similar to what the web view already does: in case a
        table frame has a follow and the table frame is in a split fly that can
        grow to host at least one follow, then try to grow it to host all
        follows. This prevents layout loops, since we don't move content from a
        follow fly to a master fly when it would not fit anyway, but allows
        large enough master flys so table joining happens.
        
        The crash with the original tdf#155002 bugdoc needs more work, still.
        
        Change-Id: I411b21d796be82ab5600d66b600cb50c116db4e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151956
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [9efbcce8b3f6f40a2687b9e4892527b6974227b7]

        prevent crash in mail merge
        
        seen reports in crashreporter
        
        Change-Id: I10ecac363eea0292f9dc257769da6d060dc350f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151962
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-19  Miklos Vajna  <vmiklos@collabora.com>  [85c0bf2e6d851ca53dc200c7c36c4419115636b9]

        sw layout xml dump: extract SwTabFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about table frames.
        
        Change-Id: I8d7902e1e80124aa7e09cebc823d9e2bb1425ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151982
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bc769e793865967d37ef86ffb764f0279ac515da]

        Fix typo
        
        Change-Id: I144687f794b4a6f80d5b8b20e0ce0618030aa0ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151985
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-19  Szymon Kłos  <szymon.klos@collabora.com>  [48d3e30748162f6e10dc27ada79dd14179ee5c3f]

        navigator: lok: hide global tree on construction to not flicker
        
        Change-Id: Icfb9b79b16dc46a722c46a08f647afaf9ad49b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151661
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151753
        Tested-by: Jenkins

2023-05-19  Mike Kaganski  <mike.kaganski@collabora.com>  [971c9945825db02a4809538d26fff3ae77d16866]

        Fix "AddressSanitizer: heap-use-after-free"
        
        https://github.com/CollaboraOnline/online/issues/6380
        
        Commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a (sw_redlinehide_4a:
        SwEditShell::AutoCorrect() etc., 2018-11-28) explicitly relied upon
        the reference to the node text being updated on editing operations.
        
        Commit 14f6700fefa945c4cf995c09af9326c2a022f886 (use more string_view
        in editeng, 2022-04-14) converted the argument of FnChgToEnEmDash to
        a string view, which means that any change in the underlying OUString
        frees the memory referenced by the view.
        
        But in this method, we really don't want to have the text updated;
        so use a local OUString copy for later reference.
        
        Partially revert commit 14f6700fefa945c4cf995c09af9326c2a022f886.
        
        And copy mst's commit 7481e8b5500e86626be5f8eae1e7f48b7f51e21a
        message to document the assumptions in SwEditShell::AutoCorrect.
        
        Change-Id: I0ff02958c8de9566d774f366d905aa9bb603055c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151970
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-19  Eike Rathke  <erack@redhat.com>  [261063e69e80193ad563e086c515fd6e22e48464]

        Eliminate 24h loops in DateTime::operator+=/-=(tools::Time&)
        
        ... and repeated Date::operator++/--() that each calculate
        lcl_DaysToDate( GetAsNormalizedDays() + 1 )
        where Date::AddDays() does it once.
        
        Also, that probably never worked correctly with negative time results >=24h
        
        Change-Id: Ic67aaa3d93e0d6533501d52671acf765e2d9bbdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151984
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e15f54ebe7eb53f9e5d5ae7de4449c7e27171daf]

        Fix typo
        
        Change-Id: I885b9e86b9078dc89ba0543103fd630a9ad3bc41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151963
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c7d4d0e92219ca16e85bc153efa3670ba870bfd7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccce5b9aa0c1d59f6e3d102eb48191ca7fdb0a0c
          - Fix typo
            
            Change-Id: I11c8cfde4e8a53b541cea2ae165044fac11dcae7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151919
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9055b11b82367653ef552505585846619ad7c85c]

        Fix typo
        
        Change-Id: I33ddd35cc09d0976ac64af80d597ba9d307041e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151960
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ba9908f2ecfaa51b3def099ac3b86ae6cfb714ea]

        Fix typo
        
        Change-Id: Ida74d3ff99c4e8c7e6c6402d580ae9d279217105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151961
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Patrick Luby  <plubius@neooffice.org>  [ff95984c8e3475b7ff7832683d621bd09896852e]

        Script that adds "com.apple.security.get-task-allow" entitlement to soffice
        
        To connect Xcode's Instruments application to profile LibreOffice, the
        "com.apple.security.get-task-allow" entitlement must be added to the
        soffice executable.
        
        This script will set the "com.apple.security.get-task-allow" entitlement
        instdir/LibreOfficeDev.app/Contents/MacOS/soffice executable so that
        profiling can be done using a local build.
        
        Credit for documenting this Xcode requirement goes to the following blog:
          https://cocoaphony.micro.blog/2022/10/29/solving-required-kernel.html
        
        Change-Id: I547edf7c1ad340267e9ed4c396fc723b7ea719be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151981
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-05-18  Noel Grandin  <noelgrandin@gmail.com>  [fdd06037e0cf902d71270c4bf7a867efc7c9c1f4]

        improved B2DHomMatrix
        
        since we know that this is a matrix only used for 2D transforms,
        we know that the last row of the matrix is always { 0, 0, 1 }.
        
        Therefore, we don't need to store that information, and
        we can simplify some of the computations.
        
        Also remove operations like operator+ which are not legal for
        such a matrix.
        
        Change-Id: I482de9a45ebbedf79e3b6033575aab590e61c2d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151909
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b9702920dc7a3c36b19bbcae81176b0ad1bb0cd]

        find-unused-data.sh: move script to bin and adapt it
        
        to check the whole repository
        
        Change-Id: Ic2df1248604e6e0053a8eeda50869eb5a3b1db0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151942
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-18  Justin Luth  <jluth@mail.com>  [00e2e3210da57c138bd998481a89760b8c7a0e47]

        tdf#86630 sw page number wizard: use '/' for page total
        
        '/' is a better default separator (1 / 5)
        than '-' (1 - 5)
        
        Change-Id: I94bc704fbb22e817dfc0008f47880c1d41578880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151965
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-18  Mike Kaganski  <mike.kaganski@collabora.com>  [78eedc1a1f73f06fca1384f848f2d6b7b89787cb]

        tdf#155387: fix list restart and opening/closing conditions
        
        1. List restart flag in the node does not yet mean that the restart
        would actually happen: it will be ignored, if the next node is more
        nested than the previous one.
        
        2. When writing nested list items, we should not write additional
        <li><ul> pairs for current level (previously, only level 0 was
        skipped); same for closing.
        
        Change-Id: I5f67e8fa9236e7e2e6dba2e0ec5dffbf0d7b7f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151958
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [3584fd0d110b4138ec32cf55ddd07e3fb8d81333]

        CppunitTest_vcl_filters_test: just pass the file name as parameter
        
        Otherwise these files would be flagged as unused
        
        Change-Id: I3203ef7820a6e5b31d48578d9184b5822836f27c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151940
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a4d78d9a9b45c7fa387b66f5e310447ec813034]

        tdf#63130 reduce large memory copies when reading from BinaryDataContainer
        
        rather than writing a bunch more code, extract the common part from
        comphelper::SequenceInputStream into a new base class
        
        Change-Id: I0d3561e3ca2e748b904128e3b5955e27196d7170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-18  Regina Henschel  <rb.henschel@t-online.de>  [800f9233513a45aa8f8950cf929fd44cb9381d72]

        tdf#154821 improve shape export with hidden row/col
        
        XML needs shape geometry so as if no rows/cols are hidden. This had
        been calculated by using the shape start and end cell. But that did
        not work in some cases. Now the snap rectangle of the shape is used.
        
        During testing I noticed, that the fix in tdf#154005 does not work
        correctly. The fix had provided only a workaround for controls. It did
        not address the root cause that a shape was size protected but has an
        anchor 'To Cell (resize with cell)' at the same time. Such combination
        is no longer needed as we have 'To Cell' anchor now, but shapes using
        it still exist. The current solution catches such cases now in general.
        
        As large parts of the method are changed anyway, I have put existance
        tests at the beginning. That allows shorter conditions and flattens
        if-constructions.
        
        Change-Id: I6bd1e15dbdafc43e309a6e12c1c5e3218bb12675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151717
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [60c00abc2e57351b265e97c635b331197eaa802e]

        CppunitTest_sc_vba_macro_test: don't concatenate the name file
        
        Otherwise these files will be flagged as unused
        
        Change-Id: I6ae0f8327bc81f57fb63e65dde66742177fc693d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151938
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7eeeebb26a7371219eb2196abb6b1b159e591f3c]

        CppunitTest_sc_subsequent_filters_test: re-enable test
        
        Commented out since it was introduced in
        731a9aab0fa42ed42b5470e2c6f7e9fc6b1e3a85
        "add first test for user defined functions"
        it no longer crashes
        
        Change-Id: I8a35dc2a737c946e9af1bafb4cc913bb9dc925fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151941
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-18  shehr  <shehr.bano@collabora.com>  [dd7776285d95b94c46a44645696522899d33f66d]

        JSDialog:  Validity message dialog is tunneled #6327
        
        Change-Id: I83b181b5b613fa8c973f673e1afdc6ee12422545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151886
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins

2023-05-18  Julien Nabet  <serval2412@yahoo.fr>  [0138745f0206f348644fd6d47c7316c8190d711b]

        tdf#155123: XML Form: Deleting parts of user defined data type impossible
        
        2 parts:
        1) in extensions/source/propctrlr/standardcontrol.cxx
        if value retrieved from the field is 0, let's return an empty Any var.
        
        2) forms/source/xforms/datatypes.cxx
        Allow to select 0 in the spinbox for String and URI ("hyperlink") datatypes
        to be homogeneous
        
        Change-Id: Ife9a94c279e8651623112c0bf8a64555cb9c556c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151740
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [24ba2cdaedb616c091f51cdec7e77c9930c83162]

        Fix typo
        
        Change-Id: Ia737462375311bb8642a9326a2980111e3ef7064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151953
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d00415949cceba2f712da8d311cf4f07b183c5cd]

        Fix typo
        
        Change-Id: I65b7269dc8717ac12f12bde2b59082cbb2faca53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151952
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9231531b3ed8554db89af7837b6e4860e4e5a332]

        Fix typo
        
        Change-Id: Ie097c4afad429ed23a616658502e3936afaea86a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151951
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3fdaed2ebbc6ada5c179b3d7eccd89fac8cde1e3]

        Fix typo
        
        Change-Id: I1a18149550cdfbaf7537213bdf41734751503598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151950
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [657cbc8c413683216fd6010c0b287d91e126508a]

        Fix typo
        
        Change-Id: I101861eaa810dc6e2f92a57ddc4e247a76a4b558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151949
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0b7bea7e27393469187c45eb98e2dc6904cac666]

        Fix typo
        
        Change-Id: I89d8b370cf95d43de33c35b788fc955adfb85a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151948
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4967fc20eb3120016d9017c1af6d8cf78fd6699f]

        Fix typo
        
        Change-Id: I372395970887c4201e973aa0583c288714fdbf6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151947
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6b43043dc0c7dbce786b6afc5813a189ecc59827]

        Fix typo
        
        Change-Id: I7a79c2a4d145d1d847d71e5b36ccdb42278b06cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151946
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7d7740aeca1aa50d8ecdffedee51365f3a9e3d4d]

        Fix typo
        
        Change-Id: I4a9abe0683f6dfd116fa15a6e1202d5a69328553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151945
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [13c3376b01770db981cdf2c63ef4072ebe0d4d21]

        Fix typo
        
        Change-Id: Ifbda8492c1b7c6cef1616a6183e2d04aee1b9bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151944
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [4b3d3354119b643ec20aaad187d0a6506ea307fb]

        cid#1530394 Uncaught exception
        
        and
        
        cid#1530396 Uncaught exception
        
        Change-Id: Ib484a788fc2defd4a337645526f410ee365f7209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-18  Caolán McNamara  <caolan.mcnamara@collabora.com>  [2d5bad1d0904ab0d5a205b15cd109caf8eba6717]

        cid#1524496 Uninitialized scalar field
        
        Change-Id: I63a201d6f5c51fa2426c44fb63d1e593d31a895b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-18  Jean-Pierre Ledure  <jp@ledure.be>  [66a3b09fc3b2927f1333f4fd54426fc5918d89cb]

        ScriptForge (SFDialogs) create controls dynamically
        
        The dialog service hosts now a bunch of methods
        to create new controls dynamically in an existing
        dialog predefined in the Basic IDE.
        
        In other words, a dialog is initialized with controls
        in the Basic IDE. New controls can be added at run-time
        before or after the Execute() statement.
        
        All the new methods have in common their first 2 arguments:
         ControlName
         Place: an (X, Y, Width, Height) array
                or a com.sun.star.awt.Rectangle
        
        New methods:
         CreateButton(..., toggle, push)
         CreateCheckBox(..., multiline)
         CreateComboBox(..., border, dropdown, linecount)
         CreateCurrencyField(..., border, spinbutton, minvalue,
                             maxvalue, increment, accuracy)
         CreateDateField(..., border, dropdown, mindate, maxdate)
         CreateFileControl(..., border)
         CreateFixedLine(..., orientation)
         CreateFixedText(..., border, multiline, align, verticalalign)
         CreateFormattedField(..., border, spinbutton, minvalue,
                              maxvalue)
         CreateGroupBox(...)
         CreateImageControl(..., border, scale)
         CreateListBox(..., border, dropdown, linecount, multiselect)
         CreateNumericField(..., border, spinbutton, minvalue,
                            maxvalue, increment, accuracy)
         CreatePatternField(..., border, editmask, literalmask)
         CreateProgressBar(..., border, minvalue, maxvalue)
         CreateRadioButton(..., multiline)
         CreateScrollBar(..., orientation, border, minvalue, maxvalue)
         CreateTableControl(..., border, rowheaders, columnheaders,
                            scrollbars, gridlines)
         CreateTextField(..., border, multiline, maximumlength,
                         passwordcharacter)
         CreateTimeField(..., border, mintime, maxtime)
         CreateTreeControl(..., border)
        
        All the methods return a SF_DialogControl instance.
        
        The arguments have bben chosen based on functionality
        rather than on layout. After the creatio of the control,
        most properties and methods relevant to SF_DialogControl
        objects are applicable. Also the XControlModel property
        might contribute to layout refinements.
        
        Other changes:
        - The SF_DialogControl class receives next updatable
          properties: Border and TabIndex
        - The dialogcontrol.SetTableData() receives an
          additional argument: rowheaderwidth
        - The dialogcontrol.Resize() method without arguments
          resizes the control to its "preferred size", a size
          adjusted depending on its actual content
        
        All the new functionalities are callable from both
        Basic and Python user scripts.
        
        Described changes will require a serios review of the
        Dialog and DialogControl help pages.
        
        Change-Id: I654eeae5456527bf14b1f4b43f04d176bbd830b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151896
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [8afcd6e74fd8f36a5599a852383ffdb59ed734e9]

        tdf#63130 improve the performance in librevenge
        
        we end up generating a ton of base64 encoded strings when loading a
        visio file, so reduce some copying here
        
        Change-Id: I2d56fda867032b23b03971731b2565f1edc2e1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7be8430702d433ce981d65fdf12e510c1cddda53]

        tdf#63130 reduce duplicated work when pixel snapping
        
        Cache the calculations so we don't repeat work unnecessarily. Shaves 5%
        off load time.
        
        Change-Id: Iffbdd08768fea5b25ac83926b812067f52cba3a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151883
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-18  Vojtěch Doležal  <dolezvo1@cvut.cz>  [9ffaf2cbfb855390954380eb40ebd7415b26e067]

        Removed remaining macro concatenations from xmloff/
        
        For PropertyMaps.cxx used:
        	(MAP_FULL\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_ENTRY\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_ENTRY_ODF12\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_ENTRY_ODF_EXT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_ENTRY_ODF_EXT_IMPORT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_CONTEXT\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_SPECIAL\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_SPECIAL_ODF12\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        	(MAP_SPECIAL_ODF13\( *[A-Za-z0-9_]+ *, *) => \1XML_NAMESPACE_
        
        For xmlexppr.cxx used:
        	ENTRY\( *([A-Za-z0-9_]+) *\) => { GET_PROP_TYPE(XML_TYPE_PROP_\1), XML_\1_PROPERTIES }
        
        For OOo2Oasis.cxx used:
        	(OOO_IMPORTER\( *)([A-Za-z]+) => \1xmloff_\2_get_implementation
        
        For xformsapi.cxx used:
        	TOKEN_MAP_ENTRY\( *([A-Za-z0-9"]+) *, *([A-Za-z0-9_]+) *\) => { XML_NAMESPACE_\1, xmloff::token::XML_\2, xmloff::token::XML_\2 }
        
        For xformsexport.cxx used:
        	TABLE_ENTRY\( *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *, *([A-Za-z0-9"_]+) *\) => { \1, XML_NAMESPACE_\2, xmloff::token::XML_\3, \4 }
        
        elementexport.cxx and property_meta_data.cxx done by hand.
        
        Change-Id: Ifb0c76a60f95e74ff1f9d596afdaff138c2228c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151867
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-18  Miklos Vajna  <vmiklos@collabora.com>  [f5b3f8d6d9d7c060e35b6da295c043576cd36a57]

        sw: fix undo comment of FN_DELETE_SECTIONS
        
        It's sections, not section. One has to dispatch .uno:DeleteSections to
        see this in action, which does something if the document already has
        existing sections.
        
        I think this was the last place where the relatively new biblio-related
        UNO commands had a wrong undo comment.
        
        Change-Id: I55074174a498f26ea7bda721988940a86ad2e458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151930
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-18  Justin Luth  <justin.luth@collabora.com>  [1c98c88a1208f47327ac2f3beaf593521ce9b394]

        tdf#86630 sw page number wizard: add to notebookbar insert menus #2
        
        Well, I wasn't very thorough in my previous patch.
        I guess chalk it up to my first realization that there
        even was a separate config for this side menu.
        
        In any case, all of these all have the nice little menus
        and all should have the same access to insert page wizard.
        
        Change-Id: Id2513b61e34aa5e3ed94f88a6af495ee02439455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151788
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4d030ec4a63c63eeb4fa958ffa377785478cf078]

        sd: remove unused document
        
        Added in 2704821c6b6e829b5ef5c32cdc8eb2a03b6114a9
        "smartart : test documents" without any code using it
        
        Change-Id: I5a31701466ff8cf97a23c9b034b2b33814cefde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151934
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0cca603636e74c164569e3ebea80e7006106fe52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2c3da66938bdb8802d1225bf25fbc2f7ad49493
          - Fix some D'oh! you found a bug ...
            
            Change-Id: Ifb98179340e64ddd4e9c672ec56ba886264bf02f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151935
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [edc7645cdbe04e20259c24cb34d1f8921d918294]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 500b29ddfcf067e5831c3ecef5bd386b725a463c
          - Exclude file from indexing
            
            This file is source for embeds and don't need to be indexed.
            
            Change-Id: I458da5804e7152bc5e684e356df5d62e8dbca9e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151908
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-17  Miklos Vajna  <vmiklos@collabora.com>  [7952477debb9b7f10ec1e10bd6aac66a2e739b94]

        vcl: fix crash in Window::GetOutDev()
        
        Crashreport signature:
        
        program/libmergedlo.so
                rtl::Reference<vcl::WindowOutputDevice>::get() const
                        include/rtl/ref.hxx:208
        program/libmergedlo.so
                vcl::Window::GetOutDev()
                        vcl/source/window/window.cxx:574
        program/libswlo.so
                SwViewShell::ImplEndAction(bool)
                        sw/source/core/view/viewsh.cxx:294
        program/libswlo.so
                SwViewShell::EndAction(bool)
                        sw/inc/viewsh.hxx:611
        
        i.e. GetOutDev() is called on a disposed vcl::Window.
        
        Change-Id: I5b17225fced85c6804fc93fd12021c92966d3aa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151857
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3c88dc039d447322b8c8c564ab6e2f0ce9c5b90]

        CppunitTest_sc_opencl-1: use CPPUNIT_TEST_FIXTURE()
        
        Avoiding the declaration/registration/definition of each
        test manually saves a lot of space.
        
        Change-Id: Ifd12aaa560be4aa69db87a3aa3f37e03940f68eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151878
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [7723e3f627175a09c074fd8bcb38ebbaa4867874]

        CppunitTest_sc_opencl-1: remove commented out tests
        
        These were commented out in 9247a100e3aa0c1ebd81254683eef2311a516a17
        "The test documents for these tests are not available."
        
        Change-Id: Icbaf29de91c7828efbca3c8e55a123b44591d308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151877
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [a28c31198d747e4abc020eb274b795c6207d3033]

        sw: remove unused document in test
        
        Added in e9b6e7f6b4e78bd098b3a32e9288253938a00881
        "ooxml: extend roundtrip test with w14:props3d" became unused in
        22d5d14d1aed73f36938b49d0ea1e9281e19dafd
        "ooxml: extend roundtrip test - ligatures, numForm, numSpacing"
        
        Change-Id: I123ac624a23e5e2a6b29b2730b6f1f0bb86c5305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151881
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [343f1910d40f6d89658cf6e30b9b8f4af51deb43]

        Simplify a bit
        
        Change-Id: I3d10e85a6141aae6c7741aebb1c0b1ac68ac4364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151785
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [67c3b3becab2aa2b9522e3a092d46bfe507c3101]

        tdf#63130 when getting the size, do not do a full paint
        
        otherwise we end up doing double work when called from
        ImplWindowFrameProc, which is the main driver of painting on the screen
        
        This reduces the load time by 10%
        
        Change-Id: I9eb82a180344875f707fbf3d8128351a35def6a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-17  László Németh  <nemeth@numbertext.org>  [ad7a84e41b50e6221634307112f00baf2b549dcd]

        tdf#92824 spell checking: limit suggestions only for the best ones
        
        Apply Hunspell fix to keep only the best suggestions, if they
        exist to avoid of overgenerating worse suggestions especially
        for short bad words.
        
        See Hunspell commit b88f9ea57bdb9b219f3c1d2c67f4f882f1f23194
        "Keep only REP, ph: or 2-word dictionary phrase suggestions
        
        These are the best suggestions, no need to search other
        ones to avoid annoying redundant and long list.
        
        For example to suggest only "a lot" to the bad form "alot",
        add the 2-word phrase "a lot" to the dic file.
        
        Or for a very typical spelling mistake, enough to specify the
        bad form with a ph: in the dictionary file to remove the other
        suggestions."
        
        Change-Id: I0272bb9ed2dd493aa372feb68d1937e359910e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151868
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [45229e679aead3c1b5f91069d2a87e9597eb93b5]

        tdf#153790: sc_uicalc: Add unittest
        
        Change-Id: Idf1628f3367fba3c196a63766ea298996bcbbb73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151875
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  László Németh  <nemeth@numbertext.org>  [aff269c18b9029fec992135a406dc5031927c401]

        tdf#155345 sw tracked table column: hide them in Hide Changes mode
        
        And if all columns are deleted, hide the table in Hide Changes mode.
        
        Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column" and
        commit f481c2c8e74bded11fac754e493560391229dbcd
        "tdf#144057 sw track changes: hide deleted table rows".
        
        Change-Id: Ic8f0254d607d629ed6386df94b16a939cde17506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151805
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [247738a9afeeb2f0644fa0307b7023fe115fae83]

        tdf#155324 sw: add unit test
        
        Change-Id: I0df173be99b8b9fa3920431a8386e14fd1d2260e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151876
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-17  Colomban Wendling  <cwendling@hypra.fr>  [1fe4d37caa983dea9815082e3e955337a03034e9]

        sw a11y: Replace some uses of magic numbers with proper constants
        
        Change-Id: I61b1924c22a66a08ac165546811daeaf20176954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151650
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [24b1631dfd1c0701f13a10378580836c8862cdc4]

        menus all black with SAL_RTL_ENABLED=1 and SAL_USE_VCLPLUGIN=gen
        
        export SAL_USE_VCLPLUGIN=gen
        export SAL_RTL_ENABLED=1
        run writer and the menus are all black
        
        a problem since:
        
        commit 622e8cd9e5c96d0fe0bb02e07d95efa93c156c44
        Date:   Wed Jan 11 11:00:43 2023 +0000
        
            reuse CairoCommon GetGraphicsWidth from X11CairoSalGraphicsImpl
        
        so restore the use of mrParent.m_pFrame as done in original
        implementation
        
        Change-Id: I21f76b2e57b7ea6d910552d3b07830811152bfe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151874
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-17  Henry Castro  <hcastro@collabora.com>  [604c27f7c382bdd6baea73e60eed6525b9bfbd3d]

        tdf#154477: sc: filter: html: fix missing color scale conditional format
        
        When copying a range cell to an external application that request
        html data, the color scale conditional format does not have an
        associate a set attribute.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I82b466a2100abc5070e92f844dc706d9b015c2e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151837
        Tested-by: Jenkins

2023-05-17  Henry Castro  <hcastro@collabora.com>  [c85255fd7a62bec9342fa6f2a79d1395979d54be]

        tdf#154477: sc: copy cache values when clone color conditional format
        
        When clone a conditional format list, also copy the cache
        values that hold the min and max values, otherwise if clone
        occurs when copying to the clipboard the values have wrong
        data due to limiting range cells copied.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Id9085a1488a3bde24842e0d2e062c9b425074157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151836
        Tested-by: Jenkins

2023-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e71891760093151bf094573dbf4ad1afe636262]

        fire less "index hint out of range, ignoring" warnings
        
        after
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 4 10:06:14 2023 +0200
            tdf#105404 [API CHANGE] add index to accessiblity change event
        
        Change-Id: I52d6b7b7368b780c1c9fdf60628311cb02429eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-17  Henry Castro  <hcastro@collabora.com>  [fcb348da642f7e5c41fe495cf6289f9992bfa1b9]

        tdf#154477: sc: add "updateValues" method to conditional format list
        
        When copying a range cells to a clipboard, if exists a
        color scale conditional format from different ranges,
        it should update the min and max values, otherwise
        the color scale conditional format could not calculate
        min and max values due to limiting range cell copied.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I660e18090a60b99ddf2b55ce1f713fd41121290e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151835
        Tested-by: Jenkins

2023-05-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5c0b66dc02de4ecd7937348c6af86354667b2b07]

        Update git submodules
        
        * Update translations from branch 'master'
          to ae42bcbf34f4674bcdb9eaee2117bea67b1dc5cd
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Id394cdfeec287ffc3faa0c1c738ae4d3f8587e69
            
2023-05-17  Stephan Bergmann  <sbergman@redhat.com>  [a4ccde0b12faad14836de9582f6f9afad95eaa6d]

        Silence loplugin:external and lopluign:unreffun in (WIP?) a11y.cxx for now
        
        Change-Id: Iea207bca4fee57e8c7dd5d307ccd42efc0dd2542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151866
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-17  Stephan Bergmann  <sbergman@redhat.com>  [1d40c4253ece649882b312139e47b65bdff8ab5a]

        Avoid loplugin:unreffun
        
        > vcl/unx/gtk4/a11y.cxx:295:1: error: redundant function redeclaration [loplugin:unreffun]
        > G_DEFINE_TYPE_WITH_CODE(LoAccessible, lo_accessible, G_TYPE_OBJECT,
        > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > /usr/include/glib-2.0/gobject/gtype.h:1730:56: note: expanded from macro 'G_DEFINE_TYPE_WITH_CODE'
        > #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)          _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
        >                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > /usr/include/glib-2.0/gobject/gtype.h:2213:3: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN'
        >   _G_DEFINE_TYPE_EXTENDED_BEGIN_PRE(TypeName, type_name, TYPE_PARENT) \
        >   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > /usr/include/glib-2.0/gobject/gtype.h:2160:17: note: expanded from macro '_G_DEFINE_TYPE_EXTENDED_BEGIN_PRE'
        > static void     type_name##_class_init        (TypeName##Class *klass); \
        > ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > <scratch space>:47:1: note: expanded from here
        > lo_accessible_class_init
        > ^
        > vcl/unx/gtk4/a11y.cxx:236:13: note: previous declaration is here [loplugin:unreffun]
        > static void lo_accessible_class_init(LoAccessibleClass* klass)
        > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I22bad5cf5e546d3a4dff4c1de3b3bb06638d1200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151865
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-17  Stephan Bergmann  <sbergman@redhat.com>  [37ca398665af12711769f825395376772f9e0f2d]

        loplugin:external
        
        "externally available entity '...' is not previously declared in an included
        file (if it is only used in this translation unit, make it static; otherwise,
        provide a declaration of it in an included file)"
        
        Change-Id: Id53a4fd0b01ea7a91735231750c32200ea1529b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151864
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-17  Stephan Bergmann  <sbergman@redhat.com>  [d5d40497112e13ca281573b4d7b3b3a350d29ea4]

        loplugin:reservedid
        
        Change-Id: Ia24f5214f44a5ef4f5ac4397b8adcd6d46a99676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151863
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-17  Julien Nabet  <serval2412@yahoo.fr>  [2811ffb4a5f6629101e851d0d57c9816404464ab]

        tdf#154628: XML Form Document: Sending data with GET fires very often
        
        See rationale here:
        https://bugs.documentfoundation.org/show_bug.cgi?id=154628#c5
        
        Change-Id: I26556baceec8823d2c3bed382d51731d18bd2ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151852
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [a78a9ea3a5f935bf364f59426b22e9039d2c1784]

        tdf#63130 use a simpler, SIMD-friendly algorithm for matrix invert
        
        which is 10% faster loading this document
        
        Algorithm copied from https://github.com/niswegmann/small-matrix-inverse/blob/master/invert3x3_c.h, which is CC0-1.0 licensed.
        
        Change-Id: I7aa272cae90b1aee30eb6b3e8e5acb260b92ceef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-17  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [118bc92cd1cf7714de61ba9af12ceb461431221b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c439137cdb1055ddd262b9169c7a59e138b9472d
          - Gradual Improvements
            
            get rid of xml-lang="en-US"
            improved code indentation and removed empty lines for better readability
            checked menu paths
            (leave 000000413.xhp mostly untouched for now,
            should be moved to Draw anyway, Impress doesn't have a Shape menu)
            added alt text to icon where missing.
            
            Change-Id: If4aaf69dd21544c073fbb42ea336e6da534866ea
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151621
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c38c6a12cc7e5c640d7dbc9f7374da3f5a0cc869]

        tdf#154114 Formatting active cell applies to entire cell range
        
        regression from
            commit ac859a4c6a7fce4efee9cdd45821a0c9e40e9e9a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Oct 17 16:36:23 2022 +0200
        tdf#147842 shrink selection to data area when applying to entire
        sheet
        
        Change-Id: I6fd8504d3995878fc9aedd461c0f374695d1f48e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [00ede35a5241925d7060dd44fb81b71f7b03091c]

        ofz#57493 reduce num_edges required to trigger
        
        Change-Id: Idb6127d8943dbf62d8cacb7f2f5382a1e8619aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-17  Szymon Kłos  <szymon.klos@collabora.com>  [52e8b4cae2ee5249e2c3dccecaba4802d0aa50a5]

        navigator: use toggle available for all apps
        
        Change-Id: I3136071ee943b120ebb2ad6491c91d8ebbcd6244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151573
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151752
        Tested-by: Jenkins

2023-05-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9aa16f3cb578a98e7febe4c77a822f087fc088df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 59f138dd11466e07ac0e615356f4ef36afee6ac2
          - Remove bad example
            
            Change-Id: Ic6307c884458c0303f88d42e19b8a4f1c924c05b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151777
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-17  László Németh  <nemeth@numbertext.org>  [85a47bbb8340e65a19dc1ceaac768902a771ee77]

        tdf#155328 sw tracked table column: add DOCX export/import
        
        Follow-up to commit ffd8d20d368a885d6d786749278fa438573227a7
        "tdf#150673 sw xmloff: import/export tracked table column" and
        commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06
        "tdf#79069 DOCX: support tracked table (row) deletion".
        
        Change-Id: Ifbe7b8b83e7071367104a09b4b559513227db786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151709
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-17  Stephan Bergmann  <sbergman@redhat.com>  [162cfe463ee29c2dbae9d50e39ca50336a77eea5]

        loplugin:fakebool
        
        Change-Id: I8c7fe59223dfda4c376e50bb4b6fedee341bd85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151862
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [d92a89afbdff4faddc869fde88bb6b52d300ea60]

        tdf#154118: ppt: use SetTextLeft instead of SetLeft
        
        and for that, call SetTextFirstLineOffsetValue first
        Also simplify the code a bit
        
        Regression from a0875d09d9eeb368e9e319f3f2f29ec3be71b56c
        "editeng: remove SvxLRSpaceItem::nTxtLeft"
        
        Change-Id: If45ded4602f2c9acc885439940db9741d16a5534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151827
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [88c4dd990ae158fbc9a0d122a9fcbedd88cc6ec2]

        Drop redundant condition
        
        Whenever (i != 0), this whole subcondition will be true; and (i != 0)
        can only be false when (nPrevDepth != 0) is also false.
        
        Change-Id: Icfd6dae3ecbbcd7307c42762d245d58725256c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151783
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c25f8f0468a830cfd855389261a7b7250ef712b1]

        sc: change (char, background) style colors when changing the theme
        
        This adds a Calc specific ThemeColorChanger, which changes the
        character and background colors in styles. In addition add the
        changes that make this possible - support in SvxBrushItem for
        the ComplexColor, making sure that ComplexColor is properly passed
        to other items (mainly from color picker),...
        
        Change-Id: Id2e98c42bbe195a0f75cc8951ff69f6d7eea6be0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151667
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-17  Miklos Vajna  <vmiklos@collabora.com>  [a13264fc7578cbd3267065f4992ded9f7558ec7a]

        sw floattable: disable chain UI if the frame is allowed to split already
        
        This is similar to d9cd177b9b08d454882dd77ffeb825a184a1b540 (sw
        floattable: disable UI if the frame is chained already, 2023-05-16), but
        here the fly is split and we disallow chaining, not the other way
        around.
        
        Change-Id: I637d594d41ba9a80d58bc0bef37627d8104293ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151856
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-17  Jean-Pierre Ledure  <jp@ledure.be>  [d07cc6706ef3b382fa16a104c97b69bc2d2365e5]

        ScriptForge - database.GetRows() tdf#155204 error when no data
        
        The complete expected bheviour is:
        when there is no data returned by the query,
        - either GetRows() returns an empty array, (Header := False)
        - or GetRows() returns an array with a single
        row containing the column names only (Header := True)
        
        In the example given in the bug report,
        GetRows() gives an unexpected error.
        
        Actually the "end-of-file" status is tested
        with the isAfterLast() indicator.
        It seems better to rely on the Boolean value
        returned by the first() and next() methods applied
        on the resultset.
        
        Change-Id: Ibe97dbbcb03d45ebb9184fab2733abe4e04963a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151844
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-05-17  Vojtěch Doležal  <dolezvo1@cvut.cz>  [24b15bc11b57aaeb3961b26ab636c3cf2d18fddc]

        Removed more constant concatenations
        
        Change-Id: I4fce6eeb6652914e1883037b41a2dc3c09a88ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151826
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-17  Miklos Vajna  <vmiklos@collabora.com>  [119190c5237f1e6eb3a8b3d87f1becf3bf39829f]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfTable2
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: Id55d735693be8d87cbc9b7048ef5533a5b7b41d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151849
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-17  Justin Luth  <jluth@mail.com>  [1349f140fcc49e5da78482ca3db09663ccdae0a9]

        tdf#138726 LRSpaceItem ooxmlexport12: don't test implementation
        
        To get the desired effect, properties were being spammed
        as direct formatting. Now that LRSpaceItem has been split,
        there is no/less need to spam like that.
        
        Allows https://gerrit.libreoffice.org/c/core/+/151821
        
        make CppunitTest_sw_ooxmlexport12 CPPUNIT_TEST_NAME=testTdf108493
        
        Change-Id: I7b7f109eacb79737d898da5bcf87162b9fa6529e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151850
        Tested-by: Jenkins
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-17  Eike Rathke  <erack@redhat.com>  [fcb66a74ae3af322b2829040bb84669d5c63e568]

        Resolves: tdf#153790 Suppress duplicated end part sheet reference, tdf#103890
        
        Also keep explicitly given sheet reference relative to the same
        sheet as user wished.
        
        Affected only when moving formula cell position like with
        cut&paste and drag&drop.
        
        Change-Id: I6b1da6aea58b88a24567189ef6aa212dab01de49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151845
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-17  Caolán McNamara  <caolan.mcnamara@collabora.com>  [dff1d54c2d6d84a852f9c2266fec6be1d343af36]

        dynamic_cast followed by static_cast
        
        Change-Id: I2b2105e577184f87723c85ed79533983fdd60405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151853
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-16  Julien Nabet  <serval2412@yahoo.fr>  [074c62b4e47c1e595f08d90e3811a8baab102dd5]

        Remove remnant commented code concerning recently dropped "XAccessibleStateSet"
        
        Change-Id: Ib11e37dbc6bf9bfc7ba8cdf3b5cb28d5a11f31a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151847
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Regina Henschel  <rb.henschel@t-online.de>  [04ae198019cf2c6593023f9ef630e4e99f65defe]

        tdf#155327 Detect default color in WordArt
        
        It is possible to not set the character color explicitely in a WordArt
        shape. In such case MS Office uses the scheme color 'tx1' from current
        active scheme. The import of the character properties does not set this
        color in the fill properties. The patch adds it, when the character fill
        properties are converted to shape fill properties.
        
        Change-Id: Ic72fd9f55bac1e2874cbf701ffa692ca4fbc9435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151851
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-16  Michael Stahl  <michael.stahl@allotropia.de>  [325fe7ab507fd8f2ca17a3db32181edf30169525]

        tdf#155324 sw: layout: try not to MoveFwd onto a page created by page break
        
        There is a ToX that is updated; it has about 4 pages worth of entries.
        
        When the old entries are deleted, 2 of the pages become empty, and since
        commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb these pages are deleted.
        
        While layouting the new entries, these are moved onto the page following
        the ToX, which starts with a page break and contains lots of footnotes.
        
        Now the footnotes reduce the space on the page available for the ToX
        entries, and thus after CalcLayout() there are 5 ToX pages instead of 4.
        
        Then the page numbers are inserted into the entries, and another layout
        action deletes one of the ToX pages; now all the page numbers are too
        large by 1.
        
        Some ideas to fix this:
        1) ignore a footnote when formatting a frame that is before the
           footnote anchor frame; similar to commit
           c79bf7865bff4e88cc201357370d8faeef8e6ad9
        2) invalidate the last content on the page when moving forward the
           footnote container, similar to commit
           eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf; this doesn't look easy to
           do because as it turns out the footnote container is moved in
           SwLayoutFrame::Cut() 5 function calls inside MoveFwd() while the frame
           on which MoveFwd() is called is still on the page, so would probably
           somehow need to be detected in MoveFwd() itself?
        3) don't move frames forward onto a page that was created by a page
           break - instead create a new frame.
        
        Let's try 3) for now, only in SwFrame::GetNextSctLeaf().
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: I641f586799a5ddb4e2a6ff8e9de784e422ecc214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151711
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-16  Eike Rathke  <erack@redhat.com>  [cda59e72ea7dbd904012ff377588d71ea8c4a2bc]

        Remove nonsense OSL_ENSURE()
        
        Apparently a legacy leftover; it's perfectly valid to remove
        EDITATTR along with CONTENTS, i.e. in Cut.
        
        Change-Id: I10010e1fc98b5e5863d041d72ddf78d499a0ec45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151846
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-16  Heiko Tietze  <tietze.heiko@gmail.com>  [7e3a9c7b82745f8765b5526f400243f0e8eff390]

        Resolves tdf#154787 - Ambiguous item on macOS quick start menu
        
        Change-Id: I3f414bfc15feff67eac3dddbe5e3cd7b557ea82d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151832
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d6b0594267e42945a87bc98105a2e820d2229f6]

        tdf#63130 flatten the extra ImplMatLine into ImplHomMatrixTemplate
        
        on modern CPUs, it is more efficient to just store the extra data, and
        lose the branching code and indirection.
        
        Change-Id: I9840c2f5c84f851293fb37466d09155dbef713f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151829
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a04fa4ad1dcfc6b7c2a13d9c5326757a1948ed4e]

        simplify ImplMatLine constructor
        
        Change-Id: I20998c99b46418f29c12cbf43787ccd17dfd75f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-16  Stephan Bergmann  <sbergman@redhat.com>  [511f4f785e6137dda2589e660dc2f1953c914dfd]

        Make --with-latest-c++ support future C++26
        
        ...as already supported by
        <https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31>
        "Add C++26 compile flags."
        
        Change-Id: I0e7b55138222c0f0a81d4aec9a20da7922c51df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3fa0f1e5320ff6c83a3eb9ecf8b2a5aeeec3f9f]

        xmlsecurity: do not run the test with HAVE_FEATURE_PDFIMPORT
        
        The test is meant to test PDFiumLibrary
        
        Change-Id: Ib99d1aef4857df09fa3e73a9cfdf130c7660619d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151761
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-16  Caolán McNamara  <caolan.mcnamara@collabora.com>  [1a3bfd3af113da246b0327e5cc816542682f90ba]

        tdf#155349 std::move of a std::optional leave behind a set std::optional
        
        unlike std::move of a std::unique_ptr which leaves behind an empty
        std::unique_ptr
        
        so if HasPaintRegion was true before TakePaintRegion it was
        still true after TakePaintRegion
        
        Change-Id: I6569f5ccd8081cbcec42190c474a98c4e28030a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151807
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-16  Hossein  <hossein@libreoffice.org>  [c01639c556276e496d9e762468cad6b27f9ed0f4]

        Simplify the code by introducing a new function
        
        There were a lot of repetitions in the code of the function
        SvxConnectionPage::Reset(). This patch Simplifies this function by
        introducing SvxConnectionPage::lcl_SetMetricValueAndSave() to do the
        repetetive instructions.
        
        Change-Id: I337ccf2281fd8d1bd9b1948beb6d31b2306eb339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151820
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-16  Bogdan B  <buzea.bogdan@libreoffice.org>  [8107a65b17e5eaab41027cfd69ae227fb2e26ee8]

        tdf#155179 Improve Solver symbols
        
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Change-Id: I608330f175ebf41f282d07752d593661138963b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151623
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-16  Vojtěch Doležal  <dolezvo1@cvut.cz>  [41d96a72fc0e0a9fa35b6ac88a389473f8baedaf]

        Removed constant concatenation macros from txtprmap.cxx
        
        Removed concatenation from the macros, because due to them I wasn't able to find anything relevant with grep when searching for them.
        
        Change-Id: Ic22d711d9e93bb89b402d141aa1ca3293bba866e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151819
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [535f8fde0c33c435e4a8e9f768003516ce933666]

        tdf#141440 - Do not delete notes when pasting contents
        
        Contents include cells with values, datetimes, strings, formulas, outlines, and sparklines.
        
        Change-Id: I9acf3a33c7723300d6b85f0abe468db28de6ebcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151759
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36eeb7a93174d17b08213eef7344952ae8e2e62e]

        Fix typo
        
        Change-Id: I006c882aacf316dda0ecb3302835ca021d45ecc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151812
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef1982d633ece640a54f6ee6dc2886964930cff9]

        Fix typo
        
        Change-Id: Ibbf9a267bbfba02c119fa1995c6b2ae90f391031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151813
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [68655b362f8129f6f3762bf7926690c1a40c9821]

        Fix typo
        
        Change-Id: Id590b13237bc148dac955d6f4d56092f86d1dd16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151817
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [92159c4b2eb4c588b4c2505bae2be036bafc0372]

        Fix typo
        
        Change-Id: Ibb3cbd37e04beed410c61f93f35be51a59bdc10b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151808
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e775824b63d61aa9c65560e42c1e4faf1a3fd3a8]

        Fix typo
        
        Change-Id: I77c647c513c4b605917888bd9054385b2f7f7bf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151814
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Miklos Vajna  <vmiklos@collabora.com>  [d9cd177b9b08d454882dd77ffeb825a184a1b540]

        sw floattable: disable UI if the frame is chained already
        
        TextFrames can be chained and we look at those fly frames as shapes. In
        this case, we should not offer the "split fly" functionality, which
        makes sense only when the fly frame is considered as a floating table.
        
        The combination of these two features have no use-case and it would just
        cause trouble when exporting to Word formats.
        
        Fix the problem by making SwFramePage::Reset() more strict: it already
        only allowed fly split for the case when the content was a single table,
        but now it also requires no chaining.
        
        The other way around (split fly -> no chain) still needs doing.
        
        Change-Id: I06c240209a3a26519a5df953e22c9ee1b54aed34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151822
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb0edd05b5595e8b795db6ce521491716661a09a]

        Fix typo
        
        Change-Id: I126f38c126c3f541d451cdafa074d2b8c0248d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151815
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8c76c0538d81a1425caca55c917367492b7cc631]

        Fix typo
        
        Change-Id: I5701a1fdfe9e4f139049ed6c0de1748ec7c06e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151816
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30984681f9019d267d5cf7c453ff482a2f5bc33c]

        Fix typo
        
        Change-Id: I77c5760a38b07541eaceae765cd0e14eaddb6d11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151818
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b4a64ea76a4e0d5dcdbb806ae7352d715226b494]

        Fix typo
        
        Change-Id: Idce8a85c80c21ee4667810ec6f397389077432d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151810
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Heiko Tietze  <tietze.heiko@gmail.com>  [90a8073fa5a6a724de498130476895dfaf4429b5]

        Related tdf#155070 - Tooltips moved from container to controls
        
        * Save log button disabled if Skia is off to prevent error message
        
        Change-Id: Iccd757fb15b347cf9d048115d4b048543814bd99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151764
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [64f4bc610ed3ba18f282f1a2b43bf59c87c1df68]

        Fix typo
        
        Change-Id: Ib9150f390574dc9467335451f42a10749bd915d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151811
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [645adce7c7294148f2729e648c37370e788575bf]

        Fix typo
        
        Change-Id: Id6f8a07f62e5861c4ad37b4537436632243b1a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151809
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-16  Miklos Vajna  <vmiklos@collabora.com>  [a396d0e373f3e62931f2660a1b149e88d2eaefec]

        sw: document SwFormatURL and SwTextINetFormat
        
        SwFormatURL is special, it has its won SwTextAttr subclass, instead of
        going via the usual SwFormatAutoFormat.
        
        Change-Id: Ibe06abcb486b6bf6037006e727be4ce750d489a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151806
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-16  Heiko Tietze  <tietze.heiko@gmail.com>  [3e602a74c8de7553ca2340e695ac6a6ec396e1b8]

        Resolves tdf#155278 - Adjust minimum statusbar height according icons
        
        Change-Id: I7dbcf35f338bfe87702afb45651cd99630efe875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151768
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [83650c82b56f496cd165981aa34edef9d5547697]

        tdf#63130 make B2DHomMatrix a flat object
        
        instead of using COW for its data.
        This takes the load time from 1m29 to 1m12
        
        Also fix a bug in
            ImplHomMatrixTemplate::operator=
        which never triggered before because the usage
        of o3tl::cow_wrapper means it very seldom gets used.
        
        Change-Id: Ib0a7bdddf6c014f583e06d15e8dce5025e67e4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151793
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-16  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1303d88047e21fd40c0d1cf056727efc7d690d9c]

        tdf#153789 sifr icons for Watched Expressions and Call Stack
        
        Change-Id: I9bd81878f931f78ed0b7d73a03cbc89d3d8347c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151797
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-05-16  Justin Luth  <jluth@mail.com>  [22950a9b008e1bb22fa9e54b5d45715e25fee764]

        tdf#154956 sw: delete bookmarks at end: fix crashtesting
        
        This fixes LO 7.6 commit 21b1dd42e9a817ae9b68e9e13ea57ce2491940c6
        
        wget https://bugs.documentfoundation.org/attachment.cgi?id=124859 \
            -O ~/tdf99692-1.odt
        ./instdir/program/soffice --headless --convert-to odt ~/tdf99692-1.odt
        
        sw/source/core/crsr/pam.cxx:268: void SwPosition::SetContent(sal_Int32):
        Assertion `nNode.GetNode().GetContentNode()
            && "only valid to call this if we point to an SwContentNode"' failed.
        
        Change-Id: Ic8280bf56f1e7f339fdff3e9591470bc74aa0d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151639
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-16  Justin Luth  <jluth@mail.com>  [25fed4ae027b9680597ea498c25acc3f854db4bf]

        tdf#79542 xls: applyGroupBox to radiobutton groups
        
        A group box control links radiobuttons together,
        and so does a sheet.
        
        No matching unit tests were found.
        
        make CppunitTest_sc_subsequent_filters_test4 \
            CPPUNIT_TEST_NAME=testLegacyOptionButtonGroupBox
        
        Change-Id: Ib5b03c68b5218649268f283d11981cc03fe4850a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137838
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-16  Justin Luth  <jluth@mail.com>  [67d4fe32713070be5688eef2da9377a91e2f6b81]

        tdf#144362 doc/x export: different columns mean new section
        
        The situation causing this may have become more likely in 7.4.0.
        I think that tdf#149313 might have caused a regression in the
        unit test that I found that exhibited the problem,
        so I am adding another one.
        
        make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf97648_relativeWidth
        make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf144362
        
        Change-Id: I8e668ac7bfb01a8704634a3e16243be7298bd1ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151731
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-15  MoazAlaa  <moazalaa4727@gmail.com>  [a9d60aba81305bf86024df707eb694d1cabc9a1d]

        tdf#140226: use StaticWhichCast
        
        Change-Id: If5eab003a732264522ff1b1fe55a6a2c876c22db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150794
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [26df8770efecb6f98f05ceffa5c81905582d1d3b]

        tdf#154782 Fix scrolling in a11y sidebar
        
        Doesn't need its own scroll handler anymore,
        Sidebar has a generic scroll handler.
        
        Change-Id: Ic56d1cfd7cde8ed81bf36f3302a128aa03ff6f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151769
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [01f9e76ed9c90244e161a7bfc30d702a5567f018]

        [API CHANGE] Drop unused ToolboxStyle config key
        
        Unused since 2020
        commit a0eab90bd1f7fc31978da3f7be0ec86781baf8bc
        
        Change-Id: Id03396022d7481ce85356207d468f5b1201df44c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151407
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [1ec0a53d6e07f24b3f186b5dc152b66a66af2ff1]

        [API CHANGE] Drop unused Dictionaries config group
        
        Its use was removed in 2020 by
        commit acb1c390539730957fb509f18f469fc7f6133082
        
        Change-Id: I48a10ab13de9fcdb1b1c5721a9be648250166f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151058
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [d948d183930ef9c5d062717c4d7f95f9453c50f6]

        [API CHANGE] Drop unused config key EmojiFont
        
        Its use was removed in 2022 by
        commit 5f1eb2a12b6e6ee646b5e9536822531ad0bd3259
        
        Change-Id: Ifc7e3f645422a478571aaa9dcbcd9ebe9a811b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151061
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [d5c033e4393395e8c7ef18115f00bdd835ba0bfb]

        [API CHANGE] Drop obsolete group PersonasEntry and set PersonasList
        
        Its use was removed in 2020 by
        commit e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1
        
        Change-Id: I1271c3a1d0dc9c1b294f9d93753196609a85a245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150988
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-15  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [172aa5d1ed851366f78375c297a5d458416f7d03]

        tdf#153789 Colibre icons for Watched Expressions and Call Stack
        
        Change-Id: I0cbe5df13e49a6bdbdcf7aa93472c24e331b5576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151804
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-05-15  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dc60f3b9f90ebd4d76bbc28cd2a1f1131e84a4d3]

        tdf#153789 Sukapura icons for Watched Expressions and Call Stack
        
        Change-Id: I0445f256680d5a88b99ac777ac7c65aaf507f232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151803
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c773bfd71d7eac7def4f8d7864a988fb160a6717]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 08e07a280483ca2db507cc9d06848d53f64f7d12
          - tdf#155309 - Base Form link to right Help page
            
            + Add bookmark to right Help page
            + refactor
            + pretty-fy table.
            
            Change-Id: I7832bb3732bb96232f8bd644311c1336e2e491bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151791
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [45cefedbc633fc315972a1fcfae43f79230703a0]

        tdf#142978 Grab focus to document when clicking "Go to" button
        
        Change-Id: Id671c0f2e31435a09f6945d5065384cae49c37c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151790
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [168528094262f59aa5862dfb396ee4d95a989394]

        tdf#142978 Automatic a11y is required for this sidebar panel
        
        So enable it while using the panel; and restore the original state afterwards.
        
        Change-Id: I15d1d266454d6bf7595956880b646bc047e8be0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151767
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-15  Stephan Bergmann  <sbergman@redhat.com>  [9b90463351919d05c6ce602e7788c4583c5f5534]

        Avoid unnecessary, wrong downcast
        
        ...in test code added with 61f3c796702f725f2c65b53b79ab7e190d39b6b8 "sw
        floattable: fix UI / property dialog for shape containing table", causing
        CppunitTest_sw_core_frmedt
        CPPUNIT_TEST_NAME=testTextBoxSelectCursorPos::TestBody to fail with
        
        > sw/qa/core/frmedt/frmedt.cxx:152:34: runtime error: downcast of address 0x506000892f40 which does not point to an object of type 'SwDrawContact'
        > 0x506000892f40: note: object is of type 'SwFlyDrawContact'
        >  00 00 00 00  90 6c 59 73 ce 7f 00 00  00 6d 59 73 ce 7f 00 00  00 00 00 00 00 00 00 00  50 2b 06 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwFlyDrawContact'
        >  #0 in testTextBoxSelectCursorPos::TestBody() at sw/qa/core/frmedt/frmedt.cxx:152:34
        
        Change-Id: I1c669d0ed3e2a4055db28c9fc4676b6e7c8520b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151795
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-15  Justin Luth  <jluth@mail.com>  [a4d011fb8ae24f90375744af5e98ba81716a22cb]

        related tdf#136536 sw: don't copy useless char escapement to next node on split
        
        This was clearing ANY single direct formatting attribute,
        not just char escapement.
        
        While that might be desireable in certain contexts,
        limit the hack to its intended subscript/superscript only.
        
        Change-Id: I0d503af826635c4325332cc985964957ee0b065d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151796
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-15  Julien Nabet  <serval2412@yahoo.fr>  [880165e9c0786d5c70d5bf5804c17772e5f22f61]

        tdf#155143: blacklist 3 Nvidia cards for Skia hardware rendering
        
        GeForce GTX 1660 SUPER (516.376.0)
        GeForce GTX 970 (531.272.0)
        Quadro P400 (516.376.0)
        
        Change-Id: I2ba3cc33dabcbd821459493ae94bdfbb130653de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151801
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-15  Julien Nabet  <serval2412@yahoo.fr>  [2c6e275120fd557ece84267deaa1019f347c0b82]

        tdf#154927: Crash when a11y toolbar is visible and try to insert a math object
        
        Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=403ea882af35337431e0f67aa973c5f046deb630
        tdf#142978 Add a11y check sidebar
        
        Change-Id: I5d3ba05ffd8089b7a9ab509ae248fc84da52f870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151802
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-15  Michael Stahl  <michael.stahl@allotropia.de>  [10abf111105537e1f400600edc2995ded23aed2d]

        sw: fix crashtesting assert on ooo34309-3.odt
        
        frmpaint.cxx:804: SwTextFrame::PaintSwFrame: Assertion `!oTaggedLabel' failed.
        
        This is even more special, the numbering contains a ' ' space followed
        by '\t' tab and the space becomes a hook-char and then somehow disappears
        completely, while the tab becomes a SwTabLeftPortion.
        
        So SwFieldPortion::Format() needs to predict that 2 of the
        SwNumberingPortion follows will be deleted by hook-char magic.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: Ica2b303f7f098c2b85720d7ae7c5c7bbf078e1b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151800
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-15  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [3df90fbc24a650cf6b0767d00821753ed3d4f5f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0c13b980b88e691ff48f69c1b65f0abb5246a208
          - Gradual Improvements
            
            All changes are tested with own builds on different builddirs (Windows)
            
            Main:
            - add alt text to icon(s)
            - moved paragraphs to where they belongs
            
            Further:
            - removed " xml-lang="en-US""
            - removed empty lines
            - new indentations for better readability
            - inline <tablecell> for better readability
            
            Change-Id: I0dde6eb6f23a77c215d26dd6129cac100029bc13
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147537
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-15  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [438f0752deaf7d6e6d9d1df381b64aca4628e944]

        MCGR: consolidations/cleanups for changes so far
        
        Change-Id: I85cf40e4803b0485bb40349d8e81adc8123666c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151706
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [efa965969c6d3dfe5745a535605a6b9a482a03bd]

        tdf#104005 Don't allow changing finalized properties
        
        Change-Id: Ic9e42ba6aed2fadd0f28dfc6be0a639cdd16bb34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151660
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [d2756dbd9b11bdfbf1d576381b8f9846a6fb7070]

        ofz#58991 Heap-buffer-overflow
        
        Change-Id: I44661cb2f9b2f44118140ae2fbcf86fe12cd282c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-15  Miklos Vajna  <vmiklos@collabora.com>  [d75f4673ac6e51ae341a3d87dc9b16c4ed0c1cdf]

        sw: prefix members of SvXMLAttrContainerData, XMLDashStyleExport, ...
        
        ... XMLDashStyleImport and XMLEventExport
        
        See tdf#94879 for motivation.
        
        Change-Id: I203cc1c789a1a33721b27754412da35c3ca8a56a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151755
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-15  Caolán McNamara  <caolan.mcnamara@collabora.com>  [f5a9b83cf9403594d9c37df8397fe01a103ae67e]

        ofz#58942 tweak so fuzzing uses the same defaults as real world writer
        
        I have a looping document which loops in layout in the fuzzer but
        not in writer but we want easy to reproduce findings rather than
        load document, ctrl+a, format paragraph and set widow control to 2
        
        Change-Id: I7739a5ebf4eaeac2152afcf8b431c42362374f2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

2023-05-15  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d1dce8d84ad9d19897007823d5af5b9e69f3f564]

        tdf#153789 elementary icons for Watched Expressions and Call Stack
        
        Change-Id: If83566c4aa0111c2fd2bd6ad6b216b7a2ca61b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151756
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-05-15  Miklos Vajna  <vmiklos@collabora.com>  [61f3c796702f725f2c65b53b79ab7e190d39b6b8]

        sw floattable: fix UI / property dialog for shape containing table
        
        The bugdoc contains a shape, containing a table (fly + draw format
        pair). Trying to open the shape properties (position & size) dialog in a
        debug build crashes.
        
        We hit an assertion failure in SwTextFrame::MapModelToView(), because
        the model position does not belong to the text node of the text frame.
        This happens because SwFEShell::CalcBoundRect() uses GetCurrFrame(),
        that normally points to the anchor frame for draw formats, but pointed
        to a text frame inside the table (inside the shape) instead in the
        problematic case.
        
        Fix the problem by improving SwFEShell::SelectObj(), so in case it
        selects a draw format instead of a fly format, then we don't use
        SwCursorShell::SetCursor() (which works with a coordinate, and will find
        the in-shape text nodes) but instead use SwCursorShell::SetSelection()
        to explicitly set the cursor to the anchor position.
        
        This went wrong in commit 7596e26fd259ce5445212949403e7cd32303b2bd (Add
        SwTextBoxHelper::findShapes, 2014-06-24).
        
        Change-Id: Ifa0d2a245b97fc2ada247849e3f22579730a62e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151757
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-15  Attila Szűcs  <attila.szucs@collabora.com>  [4ad89dd8166fac837d7ed6887c17f9255f06285e]

        LOK: Navi-1 open/close on sidebar
        
        Enabling Navigator sidebar in case of LOKit.
        
        Change-Id: I3a656fa12822e5866c2cd4fbf82627a88f26903a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151307
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151704
        Tested-by: Jenkins

2023-05-15  TokieSan  <eltokhy@aucegypt.edu>  [627a601d1fcea0b3198654756d351b0b81600b49]

        tdf#148979 Added option to update selected field
        
        Added Uno command UpdateSelectedField, FN_UPDATE_SEL_FIELD
        to support updating a single selected field
        
        Change-Id: Ia1a2387e137f8a672a24056b13234d4275a77ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150450
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-15  Heiko Tietze  <tietze.heiko@gmail.com>  [4356790bdf493c68ab609468603ec57e98dd2dae]

        Resolves tdf#155070 - Easy access to skia.log
        
        Change-Id: I2aac7a060bbb1d31510da67120728c8a24f0de88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151699
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c35e5ce3fc1de78762e03cf2b38fce1398841b20]

        Remove duplicated include
        
        Change-Id: I47741f157e54911687be9d0f39c8e67da902b528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151736
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d53540ffaf68d691061afcbc2ea55b47d5a81b69]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c6fa59fd44ba6926e42c0eb37f6d63cf837ca04
          - Fix typo
            
            Change-Id: I941edf7b6f860327d82f181a39b1c5784d6a73c1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151737
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-05-15  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [73b35219cc9ed42072506ed18a5767f072e1da02]

        tdf#153789 Breeze icons for Watched Expressions and Call Stack
        
        Change-Id: Iff094c8101a9d01fd1f73cf66c8672d0e8eb3938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151750
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-05-14  Martin Srebotnjak  <miles@filmsi.net>  [6f1534940ac12ff8e46f4782e18cfb6cf585da39]

        Update git submodules
        
        * Update translations from branch 'master'
          to bcbd9a46cf90c4fe2357c3b256e21e8f83f9a282
          - Updated Slovenian translation
            
            Change-Id: I2d179ae225ef2cd62640148098f48a472cc671c2
            
2023-05-14  Julien Nabet  <serval2412@yahoo.fr>  [aa0cbe2c82bbc2295b51357378a68da0d64a44a0]

        tdf#155121: XML Form Document: better take into account "not required"
        
        Change-Id: Ibebdbc52f2bd7d09ec7aa5f072efef364249a291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151733
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [777e188e7284e658a610dc5fa86e4d8f54fd2cb7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2535c6ff09e2afaa4c5db0a7fb6ee594a417732
          - tdf#139858 - Adapt documentation for paste special
            
            Change-Id: I35f43fca75427c77f320cb88fd5d164ef8fb67b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151622
            Tested-by: Jenkins
            Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
            
2023-05-14  Noel Grandin  <noelgrandin@gmail.com>  [35dca0ad624586c490bad612de0010c3bb228565]

        use more optional in i18npool
        
        Change-Id: If813a8bc339013c58f1b2d1f45f05b58d57f0abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-13  Caolán McNamara  <caolanm@redhat.com>  [975590e69edfa351ef20a0973a5005ca49d08edc]

        Related: ofz#58942 use the same flags as filterdetect.cxx
        
        Change-Id: Ifd53334bc17a77dbf37f06d043fe0a8038fa63b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-13  Caolán McNamara  <caolanm@redhat.com>  [16941a925c38022a8ab07088d2e42e0b9aa44b78]

        ofz#58928 Heap-buffer-overflow READ
        
        since:
        
        commit ba0bf0ab2c24d309e8a938cec26daa41eba9c8cf
        Date:   Mon Mar 21 20:20:02 2022 +0100
        
            tdf#142249 EMF Implement EMR_POLYDRAW record
        
        Change-Id: I9234a66d9f8691b9b051950b818884429b5f7277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3772a3d1ce574a60bef9b120509e444b4fa27e13]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to afa422b963d6b3677165dd8050286431652a815c
          - tdf#154210 Review Navigator Help page
            
            + Add F1 links from the context menu of the navigator elements
            + removed table describing individual context menu (redundant info)
            + break long paragraphs into smaller ones
            + precision on the hovering of navigator elements
            
            Change-Id: Ic2dd015490f07d9598362dff60d038b4f5124fb6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151727
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ef106661fcc40cfdd406064cbf73fd62477d0e79]

        prefix members and cleanup SvxBoxItem, SvxBoxInfoItem
        
        Change-Id: I9f3d36257175a5118a2b8ddca981815b24b8d243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151718
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [506f8fb7d541da856278fcbfbca6014417e990a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af81c959ae17b1036f3d0d9977efc50bb4befc59
          - Fix and embedvar issue
            
            Place a target at variable location but remove the target at embed
            position. This allows embedvar inside the same help file.
            
            + Remove cruft from very old OO help
            
            Change-Id: I2c6cb885fb5457b1a93ccd4d821f2baaa9ff3620
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151726
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8f39e946e694a4fb746058a0788d5f95697e6554]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 33d810532f97b4ac171d189c5118b4a3451a0df3
          - Refactor Help page - no contents change
            
            Change-Id: I56fa2979f540ee35392a899cc1ea8c65e5fd3382
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151725
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-13  Noel Grandin  <noelgrandin@gmail.com>  [07af6b1c386b90e50c1aae0f7dd67af3173ffadb]

        simplify
        
        no need to use a map here, a set will do
        
        Change-Id: I8e8b35f390ffba5b7da6caa52eb3e33d3b50d354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-13  Noel Grandin  <noelgrandin@gmail.com>  [5dc82f62d54fbd6299b4a1dc677e714e92f2f88c]

        use more optional for CharClass
        
        Change-Id: I67984321b8f38928bfab9fb0b624620e7d286a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-13  Noel Grandin  <noelgrandin@gmail.com>  [3168d1ab07239789cd36a5960cef2d13ae29c9de]

        use more optional for SdrObjListIter
        
        Change-Id: Iffd99d820889a1a5be514d46191ffaa2a6fa6910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [5351b8789805154219fe57b92b41b17c0e0cd765]

        related tdf#57423: make a11y checker accept image description too
        
        For LibreOffice, alt text and image description text are treated
        mostly the same during PDF export (and merged, if both are set), so
        having at least one of them set should make the checker happy enough.
        
        Change-Id: I9e54bcf52dee323fdbdd4a3015797a59efb7b42f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151695
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-13  Caolán McNamara  <caolanm@redhat.com>  [439a78496a9a45c6e412fa93edb537727ab7862a]

        cid#1530046 Unchecked dynamic_cast
        
        Change-Id: Iaeec0f90e6faae8f7c5ab8e1745c8bdb62925ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151714
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-13  Caolán McNamara  <caolanm@redhat.com>  [2ac8bf040be16eea79b1386a9466a058deee330f]

        cid#1529965 Uninitialized scalar variable
        
        Change-Id: I8a4ca8ad47086d19b6714d9846775afd5e81fda8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-13  Dr. David Alan Gilbert  <dave@treblig.org>  [fb41d0d2969726a00bcb5ac381ca77f4cb7230bd]

        tdf#148251 doccomp: Use std::swap instead of using temporary values
        
        Another swap case in LgstCommonSubseq::FindL
        
        Change-Id: Ida1e3f4f2a40bb4bc6da84e29d3fb969ff24fe6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151655
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a7ce722b476c4bb0c9a113ae0c2759181edfe48f]

        tdf#155232: drop m_aFlatParaList from SwXFlatParagraphIterator
        
        There is no need to keep those references. The set was there from
        the beginning, introduced in commits 677eba2322d2753951024c688d59553182bf2fbd
        (INTEGRATION: CWS gcframework_DEV300 (1.1.2); FILE ADDED, 2008-02-26) and
        ba76230f6f677774b0d333da946a7e487acbeb0b (INTEGRATION: CWS gcframework_DEV300
        (1.1.2); FILE ADDED, 2008-02-26).
        
        Change-Id: Iaf2482adb0aac063ad106c4198baf74577a75bf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151712
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-13  Dr. David Alan Gilbert  <dave@treblig.org>  [389b801cea9c9f3c311dcbe9d32df62a66e5ea4a]

        tdf#148251 qt: Use std::swap instead of using temporary values
        
        Another std::swap case in drawLine
        
        Change-Id: I207fe3c8c6c88532c23faf3aa3188acdcda3a5b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151654
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-05-13  Justin Luth  <jluth@mail.com>  [b5a22fceed57f05eb43a5fb0817afbc141610c5e]

        tdf#130363 sw layout: MS Word compatibility trailing blanks option part 4
        
        There are also margins to be considered.
        Granted, the previous approach DID seem to get the right width,
        since MS Word doesn't paint the left border spacing either.
        
        However, since the existing situation doesn't cover that case,
        just remove the excess amount.
        
        Although not perfect (and this whole thing is a total hack,
        so perfection can hardly be expected)
        it is better than before.
        
        Change-Id: I9dd1e801d8fe0000de020d59c7463138e2ad9f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151716
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-13  Justin Luth  <jluth@mail.com>  [06824845cc0a1b48d87554091bcac5aad8d60b4a]

        NFC tdf#130363 sw layout: cleanup MS Word compatibility trailing blanks
        
        Cleaning up the code separately so my change can be better understood.
        
        Change-Id: Ib756eb8c86f0c515056fba3e9af61cf645a19365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151715
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-13  Supriyo Paul  <paulsupriyo64nk@gmail.com>  [e08c910f9ee520ce00fe99d6dab9988138996ee3]

        tdf#145538: traditional for loops to range-based for loops
        
        changes traditional for to ranged based for in localizationmgr.cxx
        goal: better readability for programmers
        
        Change-Id: Ifde48037b27a794a9cdc3b1183f825651896cafb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148127
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-12  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [717bdd06a7ac1a2a266f36a43d7f1e695559d056]

        EMF Fix text aligning for EMR_SETTEXTALIGN for wrong values.
        
        Change-Id: I4d67eb7112d2295185905eac52ebab022a1beb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151670
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-05-12  Caolán McNamara  <caolanm@redhat.com>  [a9c14a3b2c1d14373b63cf0aff0eb92ab5d640d8]

        Related: ofz#58830 do Bezier point count check
        
        Change-Id: I1a7d7600563b57fb6dd9479b288d6fd3d4483059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151710
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-12  Patrick Luby  <plubius@neooffice.org>  [976cd8c1c146d6a733a53ac6a55aad84b9bbd406]

        Disable test that always fails with Apple Retina displays
        
        With a HiDPI display on macOS, each logical pixel is backed
        by 4 physical pixels. Turning off antialiasing and drawing a
        diagonal line causes many logical pixels on the edge of the
        diagonal line to have a mixture of white and blue physical
        pixels. Then, when such logical pixels are fetched via
        BitmapEx::GetPixelColor(), their underlying 4 white and blue
        physical pixels are combined into blended shades of white
        and blue.
        
        Change-Id: I1aca121f294ce2f4cb7b17a93b904425c8049f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151705
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-05-12  Caolán McNamara  <caolanm@redhat.com>  [c0fd5835c01e84d2351d60785e2e5fa33814e82e]

        ofz#58883 Out-of-memory
        
        Change-Id: I91de8f537ae237de814ed7e933fb6d0a3cc98466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-12  Attila Szűcs  <attila.szucs@collabora.com>  [6be76f54a4e94b952975dfded25afff60257c6dd]

        LOK: Navi-4 tree dblclick
        
        Removed sendUpdate that was called 1/sec, so selection dont revert 1/sec.
        Put sendUpdate into set_cursor(), that seems to be a better spot.
        
        Fixed set_cursor usage in executor, that caused slection to not work
        in dblclick at all.
        Because set_cursor(int) use not absolute position, but relative to parent
        And root was used as parent, so it picked SwContent from the 1. lvl,
        but the 1. lvl items are not real items, just SwContentTypes ..
        e.g.:Headings.. that cannot be activated.. so never happened anything.
        
        Change-Id: Iea373af3a0832a4f97202122bd36022eddf26efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151308
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151703
        Tested-by: Jenkins

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [59b0153d93d0cbc3dffd1e5d7df125c5f0360497]

        avoid some dynamic_cast in XTextRangeToSwPaM
        
        by re-arranging so we only do the dynamic_cast when we need it
        
        Change-Id: I7e37e3ab014032ba231dec03d470b45a4531ffcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [fdcce774409e47b452910d44fcb8a00b1131985c]

        use more concrete UNO types in sw/
        
        as preparation for getting rid of some dynamic_casts
        
        Change-Id: I78728325b916af3ec6303f7c8eaf3b8b94cfd74c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8be73da2284ffe963a464b4c65db4f2ff5d7f09f]

        avoid some OUString construction in SwASCWriter::WriteStream
        
        Change-Id: I53371dd53982660b82803d74ff97efa0f58479c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151696
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [58208b97b972d6ddca5122893b3084c67b0c5ecd]

        avoid some OUString construction in writerfilter/
        
        no need to repeatedly construct these
        
        Change-Id: Ie271c8adaf1cb558d3174c9f325de524c46e399b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Attila Szűcs  <attila.szucs@collabora.com>  [39b25518ce96a50f54459f681edcb95057507251]

        LOK: Navi-10 hide not needed controls
        
        Hide controls we dont need in navigator now.
        
        Change-Id: Ibf6843be2976bcd4d90e67130dd0cc08d0988c0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151397
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151702
        Tested-by: Jenkins

2023-05-12  Attila Szűcs  <attila.szucs@collabora.com>  [9c8e38ef8c69d519d72737b404d54d6413a98518]

        LOK: Navi-6 page selector SpinField
        
        Grab the focus back to the spinfield in sidebar, so the document will
        be able to scroll to the right page.
        It seems there is a condition check, on move to page, that focus must be
        not on document, or else it does not move.
        AFAIK in lok code we dont try to simulate the focus of the core,
        but maybe we should, for cases like this.
        
        Change-Id: Ie9a30e6bd944cfa1729861eb0ac1924b946f4185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151309
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151701
        Tested-by: Jenkins

2023-05-12  Michael Stahl  <michael.stahl@allotropia.de>  [0025190152a35e18c7847e91ad171df339657910]

        tdf#155228 vcl: PDF export: /Tabs needs PDF name, not string
        
        (regression from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9)
        
        Change-Id: I5ccc37cd538448b2cb9db594287b49869589b2db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151700
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-12  Szymon Kłos  <szymon.klos@collabora.com>  [8abce26253f3ba6bf74ba419775bf2b4a2f23546]

        lok: escape notifyWindow message
        
        File properties dialog contains problematic characters.
        In lok case and nl language it was constructing incorrect
        message so boost JSON parser was throwing an exception
        and dialog was not created correctly.
        
        Change-Id: I7e81c9407fcbf57355c0890c9540ce1f828904e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146900
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150042
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150389
        Tested-by: Jenkins

2023-05-12  Szymon Kłos  <szymon.klos@collabora.com>  [d01f432d283631cf99766ccbb315238f013b79d1]

        jsdialog: enable image properties dialogs
        
        Change-Id: Id3bf64e38093e7c068871029599a13f64891b6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151557
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151693
        Tested-by: Jenkins

2023-05-12  Szymon Kłos  <szymon.klos@collabora.com>  [77b2fd00eee43cac9defe55b9622d95c3cb21542]

        jsdialog: don't send full update on message dialog close
        
        this fixes regression introduced in:
        commit 09976bda9c196b2426b8826941f21384a58bf536
        jsdialog: don't close dialog on tab page destroy
        
        when enable macro warning was shown it required to
        close manually the dialog with 'x' button because
        after click on "enable' or 'disable' it wasn't closed
        
        Change-Id: I4741a874f93481ad03d043349520a1bf91a882be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151602
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151694
        Tested-by: Jenkins

2023-05-12  Szymon Kłos  <szymon.klos@collabora.com>  [29f6cea1bf55bc40d124fb0ca5cd8895c9053843]

        lok: Hide file name label
        
        this is followup for:
        commit 80c423520baa94cd3546e02cb383946a7d448ce9
        lok: Hide file linking in section
        
        Change-Id: I28f965766758d87f457e8471bf88b5db886fbba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151232
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151692
        Tested-by: Jenkins

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [334fcc3b98f6e047675651f673f8e970de3edc73]

        drop solarmutex guard from SwTextBoxHelper::isTextBox
        
        this path is very hot on some workloads, and AFAICT the SolarMutex is
        already taken on all paths leading here.
        But leave a DBG_TESTSOLARMUTEX just to be sure.
        
        Change-Id: Ida278360a8f740b2490574eea5411d952287b10c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b704b530c072c22dc4d66fdad407f3291fdd7e2]

        add a toAny variant that takes a && value
        
        to avoid some unnecessary construction - we hit this path when going
        through the comphelper makeProperty functions sometimes
        
        Change-Id: Idbc4550c9ca26d4a940397d6fe038db5c342867f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151689
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d23ec642e9eecd792da7a39b7871b384b9256e91]

        sd: remove unneeded includes in TextFittingTest
        
        Change-Id: Ifaf94f0e9cce1a54ddd592b480aa52bb1f6377e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151666
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [f6782ca20a5b0405beffdea4062a99cd043ffe9f]

        tdf#155179 Replace in Solver "=>" with ">="
        
        Change-Id: I4c20f755e042cee114cc81a8135b9801261c8451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151616
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-12  Miklos Vajna  <vmiklos@collabora.com>  [ee5c6039d73fee9201fa93ac7973728725422e53]

        sw layout xml dump: extract SwSectionFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about section frames.
        
        Change-Id: I713c4646815e681c377e18ae0e1e0b77c15cf5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151688
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [28bcb35b12f19858eca3d08559d7914e36ad1d2b]

        tdf#139858 - Do not delete existing cell contents when pasting notes
        
        Change-Id: I9befa9e28f70ba767bbd9c4694521964a40c4463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151603
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-12  László Németh  <nemeth@numbertext.org>  [f517c839f786c4fa3ad06b1cdcf86d7a4eb6eeb4]

        sw offapi: clean up com::sun::star::text::CellProperties::HasTextChangesOnly
        
        Reported by Stephan Bergmann.
        
        Change-Id: Ide8d17dcc7775f3a4f97088e2cbb00ddef271929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151676
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ca3bfa9bded6103d4d172ace486b697beeb191be]

        change ComplexColor to show more useful properties
        
        Change-Id: Ie19f080f2faf388f9b8ba3e9a4b3c0926d5ebdd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151674
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1df0565fb92972bd410e7db85eef1e4bec3fcc31]

        use ComplexColor instead of ThemeColor for better OOXML compat.
        
        In OOXML a color definition includes more represenations, one of
        which is scheme color (which is what is implemented in ThemeColor
        currently), but it supports other representations too (RGB, HSL,
        System,..). ComplexColor includes all the representations, so to
        have a better compatibility with OOXML, this changes all uses of
        ThemeColor to ComplexColor.
        In many cases the usage of ComplexColor isn't the same as the
        usage of ThemeColors, but this cases will need to be changed in a
        later commit.
        
        Change-Id: I9cc8acee2ac0a1998fe9b98247bcf4a96273149a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151492
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-12  Justin Luth  <jluth@mail.com>  [99a88c9e55872214ce01d89447d18708e47e956b]

        tdf#134901: update print statistics on PDF export
        
        From a modern point of view,
        a PDF export could be considered a print event.
        
        If one agrees with that point of view,
        then updating the print statistics whenever a PDF is generated
        makes sense.
        
        That is what the bug report requested, and what this patch does.
        That is what MS Word does also.
        
        Downsides:
        -there is no setting for a user to disagree with this bug's POV.
        -doesn't work for Send - Email a PDF
        -open a doc: export to PDF: close -> "Do you want to save changes?"
            -I tested on --headless --convert-to pdf -> no problems
            -a setting does exist to avoid modified status by printing.
                -that setting defaults to avoid modifying the status - YAY!
        -the print date is changed even if the export fails
            -NEEDS to be changed before export: time needed in PDF itself
            -didn't seem important enough to waste the time coding it.
                -for real printers the old print date is restored on failure.
        
        Change-Id: I0d1387c1c2c925f3be772c5bdad7187f9f6a4d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151682
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Tested-by: Justin Luth <jluth@mail.com>

2023-05-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6337348e9f51c6cf299ce0b9dc3eb221d8e07edb]

        bump product version to 7.6.0.0.alpha1+
        
        Change-Id: I4215440ecfc7509004837e436c2f947eba3f8148

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [12b9c296d9a233b1c02a356225354c056ff78b54]

        move xmlSetGenericErrorFunc into LLVMFuzzerInitialize
        
        and add xmlInitParser there
        
        Change-Id: Ifde0f8d9e8be413fd3dcf216ad33effa731fa549
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151684
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [279b21da6a4586915f889a4a835b252dae64b758]

        libxml2's fuzzers call xmlResetLastError so do that too
        
        Change-Id: I6a422be17569340865d8799a74dbc5a9867b7562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151683
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [85ccfd86e1bc3bbe2a9957cf3df069e2f7e85071]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9318da0af27a3b57a656027a30779585b40c795a
          - update tranlsations for master/7.6.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I1f2ca28d636d596f8a4eeb78bf53cc2468fd1de2
            
2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [4ae776b842a8b6f065206d3250113493fd688756]

        tdf#155241 keep current MetricSpinButton value if unparseable junk input
        
        Change-Id: I0f13c9ae25c1788924fd81ed77307e96400f6220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151677
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Michael Stahl  <michael.stahl@allotropia.de>  [c8cb7a658b33e296024044f3377378644a9a97ef]

        tdf#144494 sw: fix layout loop
        
        There is a pre-existing loop here, where page 1 is layouted, the text
        frame splits due to the fly taking up space, page 2 is layouted, the fly
        moves to page 2 (invalidating page 1) and thus the text frame splits
        again, page 1 is layouted, happy to see all the free space, and joins all
        its follows.
        
        Previously this was eventually terminated by layact.cxx:639 calling
        SwLayouter::LoopControl() and this force-validates page 1, resulting in
        page 1 having the fly (which is actually anchored at the end of the text
        frame, on page 2).
        
        Now the CheckPageDescs() discovers that page 3 doesn't have any content,
        and deletes it; this causes it to be re-created on every iteration of
        the loop and somehow the SwLayouter now doesn't detect the loop.
        
        But the call that deletes the page 3 is actually unnecessary: the text
        frame does have a SwPageDescItem - but it is itself a follow, where
        break items doesn't matter anyway - so just check for this to get back
        to the previous layout result.
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: If15c31278bd36e51c64090a288e8bd1ab6753dd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151680
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-11  Michael Stahl  <michael.stahl@allotropia.de>  [85d961200b674b8c8179f85aed752fb179350dbb]

        sw: move some loop control debug messages out of #if OSL_DEBUG_LEVEL > 1
        
        Also convert some obvious assert().
        
        Change-Id: I6ec56920df5b4aceff5e85b7e7e40ee8ce37f93a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151679
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-11  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [1fe8e130af0676409017df1fbe3341a1edf24b0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a38b476b7d71b7fb0afd96658dc131fbc682b18d
          - Gradual Improvements
            
            All changes are tested with own builds on different builddirs (Windows)
            
            Main:
            - switch to new syntax
            - check menu path(s)
            
            Further:
            - removed " xml-lang="en-US""
            - removed empty lines
            - new indentations for better readability
            
            Change-Id: Ib99e350c10d3325dd3f029fb9da6011f5fad3bb7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151385
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-11  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [c0cd1e38646de9d01bb6e0fdc7240e7849e0ae68]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d731bb61f0d39c23a4e0d4b838e442fa4df292ea
          - Gradual Improvements
            
            All changes are tested with own builds on different builddirs (Windows)
            
            Main:
            - add alt text to icon(s)
            - change 1x1 cm and other icon sizes to 6x6 mm
              - 1x1 cm looks TOO BIG in comparison to the text around
              - can easily be reverted if not wanted of course
            - added bookmark: text frame;insert
            - switch to new syntax
            - markup improvements
            - check menu paths for correctness
            
            Further:
            - removed " xml-lang="en-US""
            - removed empty lines
            - new indentations for better readability
            - inlining "listitems" for better readability
            
            Change-Id: Id167b8716d425863e347ca70e2a5d19400234223
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151384
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-11  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [234c5a581c2dbeb67aa61b6f1f9e80f25e3dd1ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4fe60582d3a64038754ebe1bf86eaee099c59e97
          - Gradual Improvements
            
            All changes are tested with own builds on different builddirs (Windows)
            
            Main:
            - add alt text to icon(s)
            - change 1x1 cm and other icon sizes to 6x6 mm
              - 1x1 cm looks TOO BIG in comparison to the text around
              - can easily be reverted if unwanted, of course
            - add some bookmarks
            - provide some additional text
            - improve some wording
            - switch to new syntax
            - improve markups
            
            Further:
            - removed " xml-lang="en-US""
            - removed empty lines
            - new indentations for better readability
            - Inlining "listitems" for better readability too
            
            Change-Id: Idef093c2e1fab8dde1a079a535ae60e85ab8bab7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151382
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-11  Maxim Monastirsky  <momonasmon@gmail.com>  [47fc6a5805592dc4e6b5339def60e2b0727a30eb]

        tdf#154933 Rename "Text Body" to "Body Text" in menus
        
        Change-Id: I012beaa6188ed6c53dd72e100109b496a6636993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151663
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-11  Justin Luth  <jluth@mail.com>  [3230d0e2a8b66634c7399764a9625b0b8e9bb307]

        tdf#143368 sw CHAR_DLG_FOR_PARAGRAPH: restore selection
        
        When the dialog was made asynchronous,
        as soon as the dialog launched, the artificial selection
        clean-up code was called.
        
        Instead, just pass on the intention that the paragraph
        should be selected.
        
        Note that we are still hoping that the cursor
        doesn't change position or anything strange like that.
        
        Change-Id: I6e618c92f2655ffcbf8b6f2029af893e7df30017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151678
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f46e701f25e8eef1572e94d092170e0d793dc87]

        sc: add ThemeDialog to the main menu
        
        Change-Id: I677aac5fdc8f493dcd8190c12e4e44ba09d3eb9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151450
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1a88efa8e02a6d765dab13c7110443bb9e6acecf]

        tdf#155238: Reimplement how ListAutoFormat is stored to ODF
        
        This reimplements commits 6249858a8972aef077e0249bd93cfe8f01bce4d6
        (sw: ODT import/export of DOCX's paragraph marker formatting,
        2022-12-19) and 209dce614c43f63f63f5b42a746665c0ec1cbfe3 (sw: fix
        ODT import of paragraph marker formatting, 2022-12-20).
        
        Instead of using an empty trailing span for the ListAutoFormat data,
        introduce a new loext:marker-style-name attribute for text:p element,
        referencing a text autostyle.
        
        The problems with the previous implementation were that (1) it was
        impossible (or very difficult) to disambiguate several empty trailing
        spans, in case it was needed; and (2) this was incompatible change,
        with other ODF implementations treating the trailing span normally.
        
        I couldn't manage to incorporate the attribute to paragraph autostyle,
        because of problems referencing different autostyles one from another,
        so put it directly to the paragraph attributes.
        
        Change-Id: I33473147f1f774c24cbbc57bf0c4f3a1d83ce5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151645
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-11  Stephan Bergmann  <sbergman@redhat.com>  [abd630e81bc150d05e4129cc22752ecf461777c7]

        Allow all hierarchical path segments to be ['...'] quoted
        
        ...and not just set elements.  <https://gerrit.libreoffice.org/c/core/+/151660>
        "tdf#104005 Don't allow changing finalized properties" found that some existing
        property names include "/", which makes them unusable with e.g.
        getPropertyByHierarchicalName.
        
        The most obvious solution is to allow ['...'] quoting (without a leading
        template name, though) for all kinds of hierarchical path segments.  (In theory,
        that would cause backwards incompatibility, as e.g. a property named ['foo']
        could no longer be referenced by a ['foo'] path segment (it would need to be
        referenced by a ['[&apos;foo&apos;]'] path segment instead).  But in practice,
        that path segment ['foo'] would have been rejected in the past anyway, as it did
        not reference a set element.)
        
        To make this work, the meaning of the setElement out-parameter of
        configmgr::Data::parseSegment is changed to only be true if the segment uses
        ['...'] notation including a leading (non-empty) template name.
        
        What this change does not (yet) address is writing out such quoted (group or
        set) names in the hierarchical paths written out in configmgr::writeModFile,
        where necessary.  (It never writes out names of properties as parts of
        hierarchical names, so this wouldn't be an issue for the existing problematic
        properties containing "/" in their names, anyway.)
        
        Change-Id: I635d823c7bbb6b8ac5869c7e0130ba8cfd329599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151673
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [dbacaf49ea7f1ed44c5e7a1ec5547d7a165a8c54]

        Save with Glade 3.40.0
        
        Change-Id: I2cbfa9344d61f5b864f29c49c9d8efe445f3e2db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151671
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [957ac2bd3e6be97179f87f96fb9b5f13c0635834]

        tdf#150732 ReportBuilder,Moving fields breaks connection of field to datasource
        
        regression from
            commit 09cb778b6eb7d3a5b9029965a1320b49c90e7295
            Author: Noel <noel.grandin@collabora.co.uk>
            Date:   Tue Feb 9 13:42:22 2021 +0200
            clean up SdrObject cloning
        
        The changed order of initialisation of the copied objects meant that
        they ended up with a missing servicename, which broke copying of
        properties
        
        Change-Id: I76a2a4721f1e3669684094a86cd501c03f80206d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [354cfa20af48207ac35ac14b832b7e44836726d7]

        ofz#57493 Timeout in _cairo_bo_event_queue_sort with > 200000 edges
        
        Change-Id: Id925da604647973977c25bbbfa57b1a69382e063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [39848b5f802c539e5d630bb7905d3d9b8d966c26]

        tdf#155231 CRASH: with embedded OLE chart
        
        regressions from commits like
            commit 70595c0291e4cc137158c77f6136025b10ce6728
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Mar 16 09:20:17 2023 +0200
            move setDimension/getDimension inside chart2::Diagram
        
        Change-Id: I535d8e74d621821bde7d31894fe7f0350e91c941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151664
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-11  László Németh  <nemeth@numbertext.org>  [1fdb056ef034109f330b79c85da39af44c3a8251]

        tdf#150673 sw tracked table column: color deletion
        
        Reset also HasTextChangesOnly property of the table cell
        at rejecting the deletion.
        
        Follow-up to commit f348440e17debacbcba9153e238e010e8c020bdc
        "tdf#146120 sw: show tracked table changes with different color".
        
        Change-Id: I7bc1643b13a54934d1538f39e0a0d4516c88fa31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151638
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-11  László Németh  <nemeth@numbertext.org>  [ffd8d20d368a885d6d786749278fa438573227a7]

        tdf#150673 sw xmloff: import/export tracked table column
        
        to OpenDocument format using
        
        <style:table-cell-properties loext:text-changes-only="false"/>
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion"
        and commit 48898a72066ff9982feafebb26708c4e779fd460
        "tdf#60382 sw xmloff: import/export tracked table/row deletion".
        
        Change-Id: I6fb37322056a42a6746db0e4144b0848b0754b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151606
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-11  László Németh  <nemeth@numbertext.org>  [d1004cdd6a445ae73673b0ca360ae034b0ec09f2]

        tdf#150673 sw offapi: add change tracking of table column deletion
        
        This is a minimal extension of the text range based change
        tracking to record and apply table column deletions with full
        Undo/Redo support.
        
        Add property HasTextChangesOnly to com::sun::star::text::CellProperties.
        
        During recording of track changes, deletion of table columns wasn't
        recorded: columns were removed completely with their text content.
        Now the deletion deletes the cell content with change tracking,
        setting also HasTextChangesOnly property of table cells to FALSE. If
        a tracked deletion is accepted in a deleted column, and the result
        is an empty cell, the column will be removed, if HasTextChangesOnly
        property of the deleted cell is FALSE.
        
        Note: Deletion of empty columns isn't recorded. Hiding deleted
        columns hasn't been supported yet in the Hide Changes mode.
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I36915d7a58f66b4a3bdaf90495cb998d29c36561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151593
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [2f4e74318a9485d5497478f8bf6b4a00f0e6c9d7]

        ofz#58830 Container-overflow READ 1
        
        Change-Id: I7786a63c4cad8e4538b108a06551ff274a0ddcc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [8fa788c393ed229ed065a3a26f316d02289dd0d3]

        cid#1529966 silence bogus Resource leak
        
        Bitmap::ReleaseAccess(foo) is just delete foo, so null is fine there
        anyway
        
        Change-Id: I18143c9cf0c63e985866276273b099f5d3b8d5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [ba63c4199d19b87d53bb167397180fc2d8686ff5]

        ofz#58818 Direct-leak
        
        Change-Id: I8974b998397aa521c9ee61651b5ce45d4189b303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151662
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [662840c33d7736a8d873b2c53f6d0cb6dd3b2998]

        ofz#58836 Out-of-memory
        
        Change-Id: I792bb179d2ac0133175e2690df6731fcb8bbbc15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Maxim Monastirsky  <momonasmon@gmail.com>  [c83d241effbd09491e9f96d3e435ab91700f58b0]

        tdf#154933 Rename "Text Body" para style to "Body Text"
        
        - Change only the UI name, leaving the programmatic name
        which used by ODF and UNO API unchanged.
        
        - DOCX shouldn't be affected either, as that style is
        mapped to Word's "Text Body".
        
        - RTF export used to use the UI name (at least in 7.5).
        Which means that files created in older LO will show 2
        styles for old and new names (same would happen also with
        files created with a different UI language). It seems to
        be no longer the case in current master.
        
        Change-Id: I8a4866d5db5f964a5d45071fb09a99ed4996fae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151653
        Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-11  Stephan Bergmann  <sbergman@redhat.com>  [1e885b09f99d5edb2d10c9ad32a9ab538141a661]

        Add missing file
        
        Change-Id: I9f78a248f0f4d1793bb7a292032b3282df26e4c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151656
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [7d6d1dee81470133df652bdbdb3b6a93e46da97c]

        cid#1529968 Dereference null return value
        
        Change-Id: Ib1d3f6229bf884b27b8e697b824e99ffa0af800a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151648
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d309298d1f70f4ffbf699b1aa1b2bfe08be8c4ef]

        tdf#155235 Draw crashes on close: SIGSEGV in SalInstance:GetYieldMutex()
        
        This is a regression from
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 4 10:06:14 2023 +0200
            tdf#105404 [API CHANGE] add index to accessiblity change event
        
        The list of children in DocumentFocusListener is getting out of sync
        because something is not sending add/remove events for accessible
        objects, a problem which was hidden before the commit above.
        
        I can't find the add/remove problem, so do the next best thing - fix the
        dispose methods of various accessible objects so that they clear
        references to other objects, which results in the relevant objects being
        destructed in an order which does not lead to crashes.
        
        Change-Id: Iac7f48d6e3f2bdf30edb5c7fd3c5de861aec4b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-11  anfanite396  <dipamt1729@gmail.com>  [35845a056e332c1d78d536b613aeb3183af09a91]

        tdf#97228 Move MenubarValue class to separate include file
        
        Change-Id: I5da4bb1765f91d1f9d78e27221d243d5c2ef92e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149076
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-11  Gabor Kelemen  <kelemeng@ubuntu.com>  [37232295b8800e6a5a82b5e8965dbb00e0c1417d]

        [API CHANGE] Drop unused config keys VCL/LFonts/ -> SubstFontsPS SubstFontsHTML
        
        Marked as unused since 2018
        commit 33e80611c46ffb8b324e1d445287f0957546de97
        
        Change-Id: I76cc62ca4911d1c130092a85f0b89e6078ad5d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151500
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-05-11  Miklos Vajna  <vmiklos@collabora.com>  [1b5bc2ae2f19a190bf588a5a26c4d125c3960991]

        tdf#154775 sw layout: fix unexpected large table print area left margin
        
        The bugdoc had 2 pages, but the second page's content was mostly a
        table. This table was rendered outside the page frame, so it was
        practically invisible.
        
        This started after commit fd7749fddc5a767461dfced55369af48e5a6d561 (sw:
        fix handling of table vs fly overlaps in the AddVerticalFlyOffsets case,
        2020-02-14), and that behavior is still wanted to have correct table
        borders, but that change introduced an inconsistent case: we started to
        always accept an invalid frame area definition of the fly, but we only
        shifted the content down in the text::HoriOrientation::NONE case.
        
        Fix the problem by limiting the "accept invalid frame area definition"
        based on the horizontal orientation, so we either both ignore the
        validity flag & shift down or do none of this. This keeps the original
        bug fixed, but addresses the new "no visible table" problem.
        
        Note that this only fixes the regression part; once the image from the
        header is removed and undo is invoked, a similar problem still happens.
        But that is a pre-existing, separate problem.
        
        Change-Id: Id752c169b7c7fb6b75e6603ad29aaafbb676b8a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151652
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-11  Caolán McNamara  <caolanm@redhat.com>  [7c6d409d252825b2407f3892f4eac35fc0c8c1ed]

        cid#1529964 Uninitialized scalar variable
        
        and
        
        cid#1529965 Uninitialized scalar variable
        cid#1529967 Uninitialized scalar variable
        
        Change-Id: Ib349b4a032484a1916f934008f5737f9815ba5b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151647
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Patrick Luby  <plubius@neooffice.org>  [bf2cf747303d1485fac44e0d7250541094fe9724]

        tdf#152173 Don't display tooltip windows when mousing over non-key windows
        
        Don't display tooltips when mousing over non-key windows even if the
        application is active as the tooltip window will pull the non-key
        window in front of the key window.
        
        Change-Id: I425b9af09de0272ebee84a218e2e5ae8c200a4e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151646
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-05-10  Caolán McNamara  <caolanm@redhat.com>  [a580a69a1e579755f726ffcd2a31a6f4f42c7100]

        reinforce the infobar warning when there are both external links...
        
        and WEBSERVICE present. This information is also shown in the
        "help" in the infobar
        
        Change-Id: I1412dc472afba353153b0c91aac1524cefa76aee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151641
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Caolán McNamara  <caolanm@redhat.com>  [d3c2ae1bb0913bcb2a28b2243e62f38016ddf7b0]

        attempt to select non-existing index -2 in combobox
        
        regression since:
        
        commit be1fe4418caa8c26ea53fe1f9acbe36096d5e3a9
        Date:   Mon Mar 27 14:28:45 2023 +0200
        
            tdf#150652 Column Type being disabled makes UX unintuitive
        
            Columntype is no longer disabled by default.
        
        Change-Id: I607fc6481dd1d81d8deb440317dbfeffc9ec30dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151640
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Caolán McNamara  <caolanm@redhat.com>  [9a8b367f5d34b59ccdba0cf9336fb1e59bc4a8e5]

        add a liststore4 to widgettestdialog.ui
        
        Change-Id: I241675dc236867e1efc2730e70e21568910f37b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Sarper Akdemir  <sarper.akdemir@collabora.com>  [eafc57233e90cafeee6f3c9e9ad655df5f1c3185]

        rename SDRATTR_TABLE_GRABBAG to SDRATTR_TABLE_CELL_GRABBAG
        
        Since SDRATTR_TABLE_GRABBAG was only used in the cell context, rename
        it to SDRATTR_TABLE_CELL_GRABBAG to reflect that.
        
        As per Miklos' suggestion in:
        https://gerrit.libreoffice.org/c/core/+/150521/3/svx/source/table/cell.cxx#99
        
        Change-Id: Id18e1ab077072d0d8ba45774ef6a3443bbea52e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150736
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-05-10  Julien Nabet  <serval2412@yahoo.fr>  [b70803101f454fce0461650d22d57a6adb5f5a87]

        tdf#155231: fix CRASH: with embedded OLE chart
        
        First bt:
        6  0x00007f19f96b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x55f40881f1f0) at include/rtl/ref.hxx:216
        7  0x00007f19f97b0a03 in chart::DialogModel::isCategoryDiagram() const (this=0x55f407cfffb0) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:656
        8  0x00007f19f983ab1a in chart::DataSourceTabPage::updateControlState() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:439
        9  0x00007f19f983a954 in chart::DataSourceTabPage::SeriesSelectionChangedHdl(weld::TreeView&) (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:469
        10 0x00007f19f98380e2 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x55f408bdd840) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:313
        see full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=187190
        
        Second part bt:
        6  0x00007fc66e0b29b2 in rtl::Reference<chart::Diagram>::operator->() const (this=0x7ffce5f5c9b0) at include/rtl/ref.hxx:216
        7  0x00007fc66e1b00d8 in chart::DialogModel::getCategories() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:601
        8  0x00007fc66e1b0474 in chart::DialogModel::getCategoriesRange() const (this=0x5590bff92f10) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/DialogModel.cxx:637
        9  0x00007fc66e238141 in chart::DataSourceTabPage::updateControlsFromDialogModel() (this=0x5590c00c4030) at /home/julien/lo/libreoffice/chart2/source/controller/dialogs/tp_DataSource.cxx:316
        
        Regression from:
        commit 5a4b75dcb5abc2e925870614a28e1c2876df8ed9 (patch)
        tree 5fe1f89c70f9c6d90d3eea8f9eb9a68e91f2dec0
        parent dab0d4e1f36faace21145a51733bd3a946992624 (diff)
        use more concrete types in chart2, Diagram
        
        Change-Id: I4332a237248c5acacab7180733d502f049aead96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151642
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-10  Justin Luth  <jluth@mail.com>  [24cc6f7e21844c078b8db4c505df5ca3983450b3]

        related tdf#138925 sw inputwin: get correct cell formula
        
        The problem was that repeatedly pressing F2,
        or any non-mouse movement between cells
        was getting a "random" formula returned.
        
        The only thing that worked was moving the mouse,
        because on every pixel change, it re-loads
        the RequestHelp tooltip that displays the formula,
        thus loading it as the most current formula.
        
        The example bug document easily crashes,
        and everything about this is terribly imprecise,
        so I'm not attempting to make any unit test here.
        
        The code is modeled from GetContentAtPos,
        which also does an unconditional const_cast.
        
        Change-Id: Iecaf2e9a56bccef9a1e05bc0667caad6c3aeb109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151550
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [21e6aea941d297545b1acd6592e0769af2b4d8a6]

        sw: fix crashtesting assert on moz386569-2.odt
        
        itrpaint.cxx:434: SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed.
        
        The list item has the soft hyphen as a bullet char.  Surprisingly this
        creates a SwSoftHyphPortion followed by an empty SwNumberPortion.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: Id58687c7e968a8a77ed5fab85d4c20d239174569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151608
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [ef692c98d43aeb861afb5b01f62e46344e835cb2]

        sw: fix crashtesting assert on fdo38226-1.odt
        
        frmpaint.cxx:804: SwTextFrame::PaintSwFrame: Assertion `!oTaggedLabel' failed.
        
        This is similar to what was fixed in commit
        0913da454e2dd88fb8fc83cddd20c735b79f73ca except that the last numbering
        portion is now in a subsequent line that isn't painted at all due to the
        "aLine.Y() <= nBottom" check in SwTextFrame::PaintSwFrame().
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I16cd8bd254457b81e74cb02a46ddf0e2167f11ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151607
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9d5d7b021db791b309469bc946d59502d47e6bef]

        ImplPrintTransparent is always called with an empty mask
        
        which we can use to simplify it
        
        Change-Id: I8fa38a9f414d8d720e31bd1f71fd722f6a95fdbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151635
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  gilssonn  <gilsonnyirimana@gmail.com>  [47b1e4fdb1d70c9812fe849e6007ca74f3e18787]

        tdf#143148 Use pragma once instead of include guards in chart2
        
        Change-Id: I6227accbaf35ea810828b018f0f7349f5404778f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151604
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-05-10  Caolán McNamara  <caolanm@redhat.com>  [f5febc2888a26cdd684c9a1590c6ca0b6ff26a4b]

        Related: ofz#58781 insist on presence of office:mimetype
        
        reject here what full office will reject to generate easily reproducible
        findings.
        
        Change-Id: Ia9a2f7fd3ae32b2623caa8eb9964a8fbd7ee09b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151636
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [444c598f53cdcd6230af01e279f5e74feab94597]

        sc: improve test a bit
        
        Change-Id: I26e06d76b6af1221fdfad1ae2c8dda4f10c70e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151632
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-10  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [ba0bf0ab2c24d309e8a938cec26daa41eba9c8cf]

        tdf#142249 EMF Implement EMR_POLYDRAW record
        
        The EMR_POLYDRAW record specifies a set of line segments and Bezier curves.
        
        Change-Id: I93d846d2fbb7a60b0565668a17ee092da30ef21c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151424
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-05-10  Juergen Funk  <juergen.funk_ml@cib.de>  [88bd66d258de5fee3d35aba80c61fec49eb2a969]

        Double name 'liststore1' fixed
        
        Change-Id: Idd4ab5d64ab58ddbe13c412f5684ab7db8af8224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [04f02cfecfae481f256b6c98a1940fc5235a921a]

        AlphaMask::BlendWith wants an AlphaMask parameter
        
        so make it so
        
        Change-Id: Ia5a91c78d2fd10f22eb19e4ebbd753151149190f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ec2d6461fe9c41025ce2bde13ddeb02acb01cb3]

        tdf#76258: sc: Add UITest
        
        Change-Id: I670950f499ebc268318913f3f3743e8d99d9ab84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151631
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-10  Juergen Funk  <juergen.funk_ml@cib.de>  [af1638985beaadb2254ca22e91de23f21690f74e]

        Revert duplicate shortcut definition
        
        This reverts the Accelerators.xcu part of b6af287527d42f8cf4bc43047fe0ed6130420d6b
        
        The key combination for Ctrl-F is already defined in the global section,
        it is not necessary to define it in other modules.
        
        Change-Id: I44047f998487b58185ceb19c19f06ee44797c5d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151503
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3e127217d8daa443b8eda52ac4810e375cc7d63]

        use comphelper::WeakComponentImplHelper in DocumentEventNotifier::Impl
        
        Change-Id: Ife4222b3f485969351565145554a51e4bed199df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151584
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  Paris Oplopoios  <paris.oplopoios@collabora.com>  [fc87b725d5e29f40d78f2ca7c20a2b516bcfa29a]

        Add view options class in Draw
        
        Add SdViewOptions class in Draw to hold the view state and
        manage view separation in tiled rendering mode
        
        Change-Id: I1546fa536555b3262217ff4be163a48b958b7a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150249
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit fa2fdc90d5fba9420cbb475f8c88423124c158ec)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151519
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6c9b0e2438802980ff31a67286afa453f1d3b4d0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4a35dde9e2066bb0f5fe9ebd14114282a6e3866b
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I002f6217ab064ef3895d3c7ca0ebf3a28a7c936e
            
2023-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a6db8c2d6fdf5cb2dfad9381f82f730021a9a9d]

        chart2: remove duplicated code
        
        Change-Id: I1bd92230e9fba8b562e57dbc3e269913dc3942e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151605
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-10  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [5582b8c6da7e9d8cbcf20b381a8b0f5344b4d743]

        desktop : remove useless using namespace
        
        Change-Id: I23a2932402120d9097ab6bd9793d4b4e92be03e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151538
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-05-10  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [ce9ed68fa63af229dceee32d1e512ac31b76e939]

        Revert "Resolves tdf#134941 - Fix size issue on start center"
        
        This reverts commit 77ed6380dda73a9716f48f73c3ff730380557a09.
        
        Reason for revert: Scolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens
        
        Change-Id: I2fb9759d55e28169508f33a822241efe955d5699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151525
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-10  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [6eb1a3de4d77c887502058e484aba44ba3024528]

        Revert "Resolves tdf#155167 - Start center app pane issue under gtk3"
        
        This reverts commit b7632b68c5398fce8a22ec09414e0075709fbc32.
        
        Reason for revert: Scrolled window looks ugly and does not solve the issue; we just cannot support +2x scaling on small screens
        
        Change-Id: I1c908dfc801a3867597feefa2a8852b871f7df3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151526
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-10  László Németh  <nemeth@numbertext.org>  [b1568a4cd8b439de19aab2bfe5f8f8465e4dc6af]

        tdf#154499 spell checking: allow phrases in custom dictionary
        
        Adding phrases, i.e. space separated word sequences is allowed
        in custom dictionaries and in replacement text of the negative
        custom dictionaries.
        
        Follow-up to commit 5619fc438273cd15e78539e78b8af751bca24b1a
        "tdf#154499 sw spell checking: add 2-word phrase checking".
        
        Change-Id: Id82dafcd5ca41842e78f2121579f5b46857bfca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151596
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-10  Miklos Vajna  <vmiklos@collabora.com>  [936ea5d2cc5267dc169a4dc5986d9ae604f14d81]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfTable
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I2edb1dfd8fa7d756ce34b747659d9cfbe18b49ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151600
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [71ea95ba55ba9e52318423041c4804771818e01f]

        re-enable typeid checking in exceptionToStringImpl
        
        now that we have valid RTTI tables for the UNO proxy objects generated
        by the bridge code. (We won't get a useful typeid for them, but for all
        other objects, we will, so this is still worth doing)
        
        Change-Id: I32bfa0099a242021f353fc4065e8660eb6c7cd93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151585
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [89e0a3e05dc00339b1d7b4e14443bdf26f9d09c1]

        use WeakComponentImplHelper2 in Bootstrap_MacroExpander
        
        Change-Id: I49f051d9c9da46ec877e4f611836c7a3548f9f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [8809b57da900c0fa8e7aa9d05021fe9a00114ecd]

        use WeakComponentImplHelper2 in ServiceManager
        
        Change-Id: I0f141398effbd2673c02f9d1f4378fd4e67af655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c84b37c0bbab3b386b22b87be52f965839b44a49]

        Remove duplicated include
        
        Change-Id: I324844e4ff628c6a72621a2b1511cc5b7f390901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151588
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6e7aaa954082acd432e8e02aee03e2c7d497c34b]

        Fix double word
        
        Change-Id: I72a951275fc0e3ff16be6c2f4cefae7949dea9be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151594
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [daf30c29be67b8b8fa361b0efd1a6cdbe087b6f8]

        CppunitTest_sc_opencl-2: use CPPUNIT_TEST_FIXTURE()
        
        Avoiding the declaration/registration/definition of each
        test manually saves a lot of space.
        
        Change-Id: I3a6253d259bac58f8d8ca78cd5d4f9e357a2c315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151589
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a936ebc2909f22143da3c7e03582afc5c673c22]

        comphelper/servicedecl.hxx is unused
        
        Change-Id: I3ddb06a31c746bfd7da72368a51266d688b1230b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [40f5a5be9fd228a5d33a3b1218864a38cb70dc1f]

        tdf#155210 FILESAVE ODT Default chart row labels disappear from Writer chart
        
        revert
            commit 6500106dff0f0cd86f509ffd01542aab77c21596
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Apr 19 13:48:55 2022 +0200
            tdf#148635 no need to init ChartDataWrapper more than once
        
        Change-Id: I28f078731bd8bfedbde63d0bb2e5fe40f0a4ff46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Julien Nabet  <serval2412@yahoo.fr>  [333f91b389a62bf4c21a963389a3a0bae27f110f]

        Typo: tapstoplabel->tabstoplabel in sd/optimpressgeneralpage.ui
        
        Change-Id: Ie271244eb971fc8180984b7a2723e2c780a9fb0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151486
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [c04d0570b6c8c78e35c2c9b58bf37bb1218021f5]

        Resolves: tdf#142176 under GNOME inhibit logout if there are modified docs
        
        and if we are forced to quit anyway, unset modifications on documents and
        terminate.
        
        Change-Id: If4a3aed48a4621950e2d630fdfef34b28ba1b089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [5c73c3aa6875b1e69b2d58a47ba823faf78b8aa2]

        drop unused ImplPrepareExitMsg
        
        Change-Id: I9254328829ac051524fbfdf6a3b5b2f72b12c427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151574
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [5e99e5d734f19fe7299a3e390b23a93db971e013]

        Resolves: tdf#138512 don't crash on removing already Disposed a11y context
        
        Change-Id: I2a8f3d10a1349de233e11d841f7f244e4e513b2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Mike Kaganski  <mike.kaganski@collabora.com>  [b7affedf9c281d6329ac87c5f3cd0fd0f617acbb]

        const -> constexpr
        
        Change-Id: Ibeeba1862d84e43fa659cb2a97ef3498674f0d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151590
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [14c12d7a0672148522f0773146f41bb0648f6caa]

        CppunitTest_sc_opencl: factor out common code
        
        Change-Id: I5da3d3a0e0f9f18033d8695081501a52aea5bd60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151586
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [efdbe4179d151899c8a9a9de8f5bc1660700b27d]

        tdf#95520: sc: Add UItest
        
        Change-Id: Ia4e30a1e4dea3dbd9eb40c29c96e5ab3d700e54e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151578
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [91bdd2fa1a8d602a2af26dfbc38cdd09f2e8394e]

        Fix typo
        
        Change-Id: I38877f928fd6943afa1a6c17d8225caef8411d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151338
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [94aba9289af06b3a18f143d1253467f32c4af2cd]

        use WeakComponentImplHelper2 in TypeManager
        
        Change-Id: I2358006a069ea4e8cdeeeafb8384ad8d47fba50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd52832249267a83f7207e6702a50af6e94c6654]

        move a toolkit header inside the module
        
        It is only used inside the module, no need to be public
        
        Change-Id: Ibd8445ecbb67624569ee7225f0bdf6d9c041dab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f520dc7e3badc0165ee3b13ddd514bb94b00265]

        inline GalleryStorageLocations allocation into GalleryFileStorageEntry
        
        no need to allocate this separately
        
        Change-Id: I01795ac459c5b65b5c143dc081e5b7cf74c2e6f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [9af57871fc153ca0145dd40e48f577564395ab73]

        tdf#154282: sw_uiwriter3: Add unittest
        
        Change-Id: I48b0dd636f50bf0b4d08ee0d43593f6142babd3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151566
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Dennis Francis  <dennis.francis@collabora.com>  [4adf6852cc3fd0eddf53c2ab4f66efed0668b699]

        sc: use the current cell's numfmt to format...
        
        to format the values in the validation list when the items are numbers.
        This is better than applying no formatting since we lost track of the
        source formatting when values are passed through a matrix.
        
        Change-Id: I06432bd93ef8d01181dd16d2f5ee99eb0477c094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151313
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        (cherry picked from commit 2f6d1cefc184fda3ba292f1718b034202989d7b3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151386
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [421d4fc533498d058a91f9686c47b35114e6a6c9]

        tdf#104487 - Function wizard: remember last used function category
        
        Change-Id: I978dd63553e3528e7b9b853dbb438304f1f680cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151565
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [600ad0a53e25beed8b418d477635d0c8513d5d07]

        sc: add theme colors to the color picker
        
        Change-Id: Iae8f502a24187f4d41f60fbb727066f214d1cf70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151449
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [4232b46b4a0f7b4ae0c6967778af437f59b90e14]

        increase max_len for fodt2pdffuzzer
        
        Change-Id: Ib8c3c0e35c6a7cc8b3b40fce4f89c038e819f088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151587
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [b189172dd639f79bdf6564c2b9fab532fdcfe8cd]

        tdf#154451 uitest: use more oneprocess mode
        
        Execution time changes:
        
        - UITest_autofilter: 4m39,519s -> 3m10,079s
        - UITest_autofilter2: 2m11,254s -> 1m32,543s
        
        Change-Id: Ibeb22b46a4ccaa1d560a4d82288ba9f2351b8f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151576
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b6dbbcb5a42bb51b3e84b54f9950f3f43e97c97]

        CppunitTest_sc_opencl-2: re-enable test
        
        Disable in 836abd393d126cfbba6b0bd1fdda5b03095516c9
        "GPU Calc: temporarily disable Kombin unit test"
        
        Change-Id: I311caae5450874c61a6bf5e40940513f614da965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151572
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Justin Luth  <jluth@mail.com>  [10c2e1f4a2158f629892356f569de01e7fea20f7]

        NFC sw edtab.cxx: remove do ... while (false) without break
        
        Since original import in 2000, the clause was while(false)
        (although at that point it still had a commented out condition).
        The next change to this function remove the commented out stuff,
        leaving only a pointless do while bracket
        that has no early exit uses.
        
        Change-Id: I4e0c083a52677c3116e6d008a860b1473418d1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151549
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-09  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [81e77bcc7c454d79b302df7ad545e7da16b64ae0]

        MCGR: Correct interpolate TextureMap due to possible zero value
        
        Change-Id: I5b2fe354077bea659f522e5b5c839be1f4cae1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151568
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [9585ce0e6a1075597943268ef72ccd859b6c8065]

        move include/svx/legacyitem.hxx inside svx
        
        it is only used from there
        
        Change-Id: I12065d4e2db142d50c403310ea4a7bb23412884e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [00f8f75f36dfb4394d43b10510ea08049752a1a7]

        copy some comphelper code down into cppuhelper
        
        Since I want to use them in the cppuhelper too, but comphelper is
        "above" cppuhelper in the dependency tree.
        
        And sharing the code between cppuhelper and the rest of LO
        across the URE boundary appears to be nigh impossible.
        
        Change-Id: I2ebf37746928dc820df43347dc1a2c158f00ec50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fa0a1f6462c050bdd14a4f75589eb324c6575a91]

        tdf#153543 - Add vba shell constants
        
        Change-Id: Ifa73050f6892ce8ce95d16dedc166e68d1809491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151567
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-09  Eike Rathke  <erack@redhat.com>  [f75b4eca9f9f81abbace8fdf192293feed90565c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 59861677cc4ca59020718033f675b54f49fc0b74
          - Size in characters, not bytes; tdf#153574 follow-up
            
            Change-Id: I67a23a18801d152579f521692550d22493e0cb24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151577
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c9b0a6010e96d22844cdab6c1e8e67fbf14ab142]

        merge GalleryFileStorage with GalleryBinaryEngine
        
        Change-Id: Id948627873db9c646d1a81784dd16f6aa1c2063b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151553
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [38a658f3f064e1f0dc28cd7f69d800f78115c8df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d0d854aabafc612def2622647c8e85b599fcc097
          - tdf#149223 (part) Missing Help page for database connection properties page
            
            Change-Id: If9a306f53abf031dfca58e5ce9a3f9bb0862dd70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151546
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b3aaf3f228a628e7c1dbc4903ee6160400c1cfb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8a10f51d66795e9fd8f49839d01e26c9cc4e2a2
          - tdf#149222 Missing Help page for database Relationship dialog
            
            Change-Id: Ieab2dd8906b2d368b054655e22c714076e0d96b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151545
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d94705113db12f3c9b31669a66693e171c6ca03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 429400018469d9925c4645fe7b2266bb275f407d
          - tdf#154687 Line & Filling toolbar hidden feature
            
            Change-Id: If751ae42947cfc3320ec4bbf273074ec25e59e5e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151543
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [60cc7b1fbe8e44f323016ce79a14c5c74c8b4cd0]

        sc: enable document themes in Calc
        
        Create and check that the SdrPage, that is associated with the
        current sheet, has a model::Theme available on creation.
        
        Change-Id: I1814d4a86452b1a15ef01e0b2349d435405f4b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150263
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [33d35a2181c9cebf77bc1aa9322a2d11892de5fd]

        sw: support Undo/Redo for theme colors
        
        Change-Id: Ic4166ec4836545467866a70b4160f1adba0bad96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151448
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [afccbe23cecc04a08281a91e02bb25dd7b0ffdcf]

        merge GalleryFileStorageEntry with GalleryBinaryEngineEntry
        
        Change-Id: I21b3f49cdf04b021931ab9e1171bfffa5cd76e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [3efb1714d7095898389f86258e805a62e7468a19]

        CppunitTest_sc_vba_macro_test: use CPPUNIT_TEST_FIXTURE()
        
        Avoid the declaration/registration/definition of each
        test manually saves a lot of space.
        
        Change-Id: Ifbefb1950f7fe547489f279c8b229c43dac57f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [332ac45c73952af7e2c2a868fc03e17d96a7de2c]

        tdf#120177: sc_subsequent_export_test4: Add unittest
        
        Change-Id: I71846e6e80674dc61126069d13ddd431560b071b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151563
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [796fb57d7b2e2ea05795dc49c4438c25adc26fd4]

        Related: tdf#142176 rearrange screensaver inhibiter to be more generic
        
        and for not-x11 I see gtk just uses 0 for xid (which is called
        window_system_id there now)
        
        Change-Id: I9248bcceaa2d21d34133dea80697776df0aa8c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151560
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [4a8a24be5a378308680a0b6e2e246d5d9df414c4]

        Related: tdf#142176 document what the other inhibit options are
        
        via an enum like the gtk one so it can be seen how to inhibit logging
        out due to unsaved changes
        
        Change-Id: I07609cfb7a97b5b6c1b94a09b7b79bcca308d5d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151559
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Caolán McNamara  <caolanm@redhat.com>  [b7ec54b7c6e85d507066442de3b7398f34bbb653]

        ofz#58756 Integer-overflow
        
        Change-Id: Ie2782c1d68f73e5e88cf868eb1ce106ec0c181b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151558
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-09  Michael Stahl  <michael.stahl@allotropia.de>  [d81379db730a163c5ff75d4f3a3cddbd7b5eddda]

        tdf#154877 sw: generalise ExtendedSelectAll()
        
        This used to work only in the body text; make it work in any text, so
        also text frame, header/footer, footnote, table cell.
        
        (fixes regression from commit 0590cd2857f68f48b8847071a9c1a7dbef135721)
        
        This is made much more difficult by table cells, which may contain
        nested tables; there is already some code to switch between text
        selection (via m_pCurrentCursor) and table cell selection (via
        m_pTableCursor).
        
        There were also a few things that looked kinda wrong, but i forgot
        where.
        
        One tricky case that can't be handled well is if there are multiple
        tables in a text but no paragraph (this is impossible in the body but
        possible in other texts by removing the paragraph via Ctrl+Shift+Delete)
        ... here the most we get is one table fully selected, because the
        SwTableCursor can't select cells from multiple tables.
        
        Change-Id: I0964baacecb8f10636792a27efa9ea6b18da4709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151544
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-09  Stephan Bergmann  <sbergman@redhat.com>  [edf471ba8b5a69ce26e68eff26283b304c4c9a9e]

        Reinstate external/libwpg/rpath.patch
        
        ...which 0c0c9a0dd8a7b102315ab1075f78a0f1f3397b67 "tdf#155057: Wrong colors in
        some WPG2 (well rendered in WPG1)" had dropped for no apparent reason, causing
        
        > [CHK] CustomTarget/postprocess/check_dynamic_objects/check.done
        > ~/lo/core/instdir/program/libwpg-0.3-lo.so.3 has unexpected RPATH  0x000000000000001d (RUNPATH)            Library runpath: [~/lo/core/workdir/UnpackedTarball/libwpd/src/lib/.libs:~/lo/core/workdir/UnpackedTarball/librevenge/src/lib/.libs:/usr/local/lib:$ORIGIN]
        
        to fail (in Linux builds that execute that test)
        
        Change-Id: Id9f87b14f571b328b98496625351bc1f87bf8c61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151555
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [440c23ee678442fc64aa9fcca13b137738e10a04]

        merge GalleryStorageLocations with GalleryBinaryStorageLocations
        
        Change-Id: Icf9a942047f212132d7b543cd1b1a857f8f95223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151551
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8bafae3656f7a0a6b74bb0985403a96f9a3f61be]

        change model::ColorSet to be stored in a shared_ptr in model::Theme
        
        Change-Id: Ic3067f1681c047cd944e64179c568f4e972e0c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151447
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-09  Miklos Vajna  <vmiklos@collabora.com>  [5c5d0c4858a123c6aa1dbadcdfd96641eb91283b]

        sw: document SwFormatMeta and sw::Meta
        
        A bit hidden, since there is no UI for this.
        
        Change-Id: I1167236a1a2f4745580cc85b0b1f3555622bf3be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151547
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [47378fcb3ca35bbe9fc27e9c062479dc5812138b]

        move some gallery header files inside svx
        
        They are not used outside svx.
        
        Change-Id: Ib9ef73ec19a12401ea808922aba49e0ce1625378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4f5c7e3bf9a791ce777d1027aa17c93ad8f28a3]

        tdf#155186 crash Inserting tables and switching slides (gtk3)
        
        regression from
        
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 4 10:06:14 2023 +0200
            tdf#105404 [API CHANGE] add index to accessiblity change event
        
        where something is forgetting to send events for some of the changes, so
        just ignore a bad indexhint here
        
        Change-Id: I9228b480be10b2f267c2a76cb30a9faf1476639e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-09  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [96965871f4cd2e4afbdf3bcae9dc0c43d1543e1d]

        tdf#152980 CSV import: Fix control character length in XLSX save
        
        Converting from CSV to XLSX corrupts text that looks like a control
        character. Only 4 numeric length escape character allowed, in _x000D_
        format, not _x0D_ for exampled.
        
        Change lcl_unEscapeUnicodeChars function to decodeXString. Delete not used functions and add multiple occurence for unit test.
        
        Change-Id: Id1d4bfcf7d27cf5005e7bea8e289303c5d9aca73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151494
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Eike Rathke <erack@redhat.com>

2023-05-08  Eike Rathke  <erack@redhat.com>  [c742ab96ccac05465d87e860838c92f1f370aea3]

        Do not copy decodeXString() string and analyse if there is nothing to decode
        
        ... which usually isn't.
        
        Change-Id: I1cadc5a4c0072d5152173ad41e54e25c224e96db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151509
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c4bfbf224aa5ced905bbe569ca56ecf5e00115f]

        tdf#144549: sc: Add UItest
        
        Change-Id: If0839d3f33e6fb7d5264b61d033b33e98f3ff44d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151504
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-08  Regina Henschel  <rb.henschel@t-online.de>  [43f72183ce12835f6a3a5185e708a00e968d27da]

        tdf#139083 Further unit tests for commit dfb0d118
        
        The tests cover bugs tdf#125938, tdf#155091, tdf#155094 and tdf#155095.
        
        Change-Id: Ifb5fdb2375656934822e7b705062c559f073aacd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151488
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-08  Julien Nabet  <serval2412@yahoo.fr>  [c825abdee67b6dc9fce2457a15f08ea9a506fc11]

        Revert "Simplify initialization in sw/unotxdoc + flatten a bit"
        
        This reverts commit 76a3c01c3abd01f404f8f5ac572e52b2f8a2927e.
        
        Reason for revert: I was wrong, see Mike’s comment
        
        Change-Id: I9c9501e4011f396a2fb726a17aa6f238413a9073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151517
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef950b8f42c0c6e501540ffc74ba193f1952b864]

        GalleryObject*Storage are unnecessary
        
        They are identical, and they contain no useful logic.
        Remove them and just store the underlying INetURL object directly.
        
        Change-Id: I73f46d13867ae3b6e738189c0dbaa3cb0ea40ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151539
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-08  Julien Nabet  <serval2412@yahoo.fr>  [76a3c01c3abd01f404f8f5ac572e52b2f8a2927e]

        Simplify initialization in sw/unotxdoc + flatten a bit
        
        static_cast<sal_Int32> could be removed since:
        - GetLeftSpace, GetRightSpace, etc. return a sal_Int32
        - convertTwipToMm100 is a template method defined like this:
        93  template <typename N> constexpr auto convertTwipToMm100(N n)
        94  {
        95      return o3tl::convert(n, o3tl::Length::twip, o3tl::Length::mm100);
        96  }
        (see https://opengrok.libreoffice.org/xref/core/include/tools/UnitConversion.hxx?r=bfed5882&mo=2801&fi=93#93)
        so will return sal_Int32 if its argument is a sal_Int32
        
        "comphelper::makePropertyValue" would have simplified even more but the handle here is -1 not 0.
        Now, I don't know what would be the impact.
        
        Change-Id: Ie39e6c5984930e53dff7de3584cb80f421f9288c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151540
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9d6653fc5579f60e5d93dd8ae767579fbeaecf51]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to baa3ad9698dfc80375109478ff88d7929dfb62ea
          - tdf#153574 Update error code Help page
            
            + add #N/A error
            + removed 526
            + updated 521, 504, 513, 514, 525, 538
            +
            
            Change-Id: Ie1bf57cd8f13fb60e64d89c14a20bb2d8a04fb4a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151078
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a988b59dfaf927d0653b8cee85c3ba1882e0d273]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 254accc37f7b37e29b0353376d7af557fe04ae03
          - tdf#98232 Add precisions on round cornering and slanting objects
            
            Change-Id: I7bb0e44b62de8341682a6925f6b29b99d0a13e04
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151334
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1a9d96d35afc7fd496434ead4311f872db5d6232]

        tdf#142978 Add menu entry for a11y check back
        
        And make it open the sidebar
        
        Makes the feature more discoverable and prevents empty menu slots
        when people customized their menubar.
        
        Change-Id: I03440d78d5cf1d31cad7412dc0988d8a837a92e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151537
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-08  László Németh  <nemeth@numbertext.org>  [5619fc438273cd15e78539e78b8af751bca24b1a]

        tdf#154499 sw spell checking: add 2-word phrase checking
        
        Hunspell dictionaries can contain phrases, i.e. space
        separated word sequences, which were used only to reject
        compounds and to give better suggestions. Now recognize
        2-word phrases in the text, no need to break the phrase
        into single words, e.g. "et" and "cetera", which resulted
        acceptance of typos (e.g. "et" without "cetera"), also
        bad suggestions (e.g. "et" and "cetera" independently from
        the context).
        
        More example:
        
        == old .dic file ==
        ...
        et
        cetera
        von
        Neumann
        veni
        vidi
        vici
        ...
        
        List the 2-word phrases, and break the 3 or more word
        into 2-word phrases:
        
        == new .dic file ==
        ...
        et cetera
        von Neumann
        veni vidi
        vidi vici
        ...
        
        Note: words of the phrase are separated by a space, but
        recognized also with punctuation, e.g. in the previous
        example, "Veni, vidi, vici."
        
        Note: during typing, the second word of the phrase
        will be accepted only at ending the paragraph, i.e.
        pressing Enter.
        
        Change-Id: I4a1487abc0e4ab31d09750ee8c817353e6325ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151487
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-08  Khaled Hosny  <khaled@aliftype.com>  [7ea34aa61f1c669710ed93e8e5cf2d19b452a371]

        tdf#155161: Always embed fonts with CFF2 table as PDF Type 3 fonts
        
        PDF doesn’t support CFF2 table and we currently don’t convert them to
        Type 1 (like we do with CFF table), so treat it like fonts with
        variations and embed as Type 3 fonts.
        
        Change-Id: I963b55d5d0ed1470eda157c7e10cae63195a0c91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151532
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d91383f831b8de36651fc390dab225aa7ca3c644]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd7a76d9bcf2222a0d1ce4ac5031069a7097ce0a
          - Remove duplicated Help page
            
            Line & Filling toolbar is the same for Draw and Impress
            
            Change-Id: I7cc62f6952aedce47be1cf7343ce0b04242c7e86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151542
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [006a4aecbf82a7fdbb4ff9d5a95cf870bb8d8c16]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d161830063f41642c5104629d355d40eeecc81e7
          - Refactor - no contents change
            
            Change-Id: I1021a36330a638bcd543f82dc96d1e1b21fc9584
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151541
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [44b2a04e3123054c1103be6c74742105dab32ee3]

        Fix typos
        
        Change-Id: I1d171c2177a83b0918c483e8c34399b0f70fd59b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151507
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [678858db53258a0e03497ca167556a2bfea50958]

        Fix typo
        
        Change-Id: Ie6383936bd199646b7b76937c6a2d5a1066536d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151508
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-08  Jim Raykowski  <raykowj@gmail.com>  [20bf9f2b31343e17c14a3091d59b40a71eeb3e26]

        tdf#154551 check pointer before use
        
        Change-Id: Ied215ea393760f246128610c5b7b4d50ab211f97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151300
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-05-08  Julien Nabet  <serval2412@yahoo.fr>  [23c9a5a2719c8ca6a7919db55989b0bb67f73f81]

        Row and Cols in sw preview page part should be sal_Int16 instead of sal_uInt8
        
        Following offapi/com/sun/star/text/PagePrintSettings.idl which defines
        [property] short PageRows;
        [property] short PageColumns;
        and "short" is defined as signed 16-bit integer type
        see https://wiki.documentfoundation.org/Documentation/DevGuide/Professional_UNO
        
        it allows to avoid some static_cast
        
        Change-Id: I5f497a27cd56f7d07c9440e9d6e6718a5e418345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151499
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-08  Mike Kaganski  <mike.kaganski@collabora.com>  [4a998c6c7325505d90780d18304267377a69225a]

        lok: also do not push the cursor in lok case
        
        Change-Id: Iaa70edd1fd8f196f487816a324ab0dbb0d363358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-08  Stephan Bergmann  <sbergman@redhat.com>  [93915c0be321c79821bbeca0b0af95ba452c5011]

        Avoid more division by zero
        
        Similar to <https://gerrit.libreoffice.org/c/core/+/151495> "Avoid division by
        zero", CppunitTest_sw_ooxmlexport7 CPPUNIT_TEST_NAME=testFdo78957::TestBody
        started to fail with
        
        > drawinglayer/source/texture/texture.cxx:470:71: runtime error: division by zero
        >  #0 in drawinglayer::texture::GeoTexSvxGradientRadial::appendTransformationsAndColors(std::function<void (basegfx::B2DHomMatrix const&, basegfx::BColor const&)>) at drawinglayer/source/texture/texture.cxx:470:71
        >  #1 in drawinglayer::primitive2d::FillGradientPrimitive2D::generateMatricesAndColors(std::function<void (basegfx::B2DHomMatrix const&, basegfx::BColor const&)>) const at drawinglayer/source/primitive2d/fillgradientprimitive2d.cxx:99:31
        >  #2 in drawinglayer::processor2d::VclPixelProcessor2D::processFillGradientPrimitive2D(drawinglayer::primitive2d::FillGradientPrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:1017:24
        >  #3 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:363:13
        >  #4 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #5 in drawinglayer::processor2d::VclProcessor2D::RenderMaskPrimitive2DPixel(drawinglayer::primitive2d::MaskPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:866:9
        >  #6 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:257:13
        >  #7 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #8 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #9 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >  #10 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #11 in drawinglayer::processor2d::VclPixelProcessor2D::processPolyPolygonGradientPrimitive2D(drawinglayer::primitive2d::PolyPolygonGradientPrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:490:9
        >  #12 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:232:13
        >  #13 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #14 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #15 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >  #16 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #17 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #18 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #19 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #20 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >  #21 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #22 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #23 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #24 in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >  #25 in drawinglayer::primitive2d::GroupPrimitive2D::getChildren(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&) const at include/drawinglayer/primitive2d/groupprimitive2d.hxx:76:90
        >  #26 in drawinglayer::primitive2d::GroupPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/groupprimitive2d.cxx:53:13
        >  #27 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >  #28 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:378:13
        >  #29 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #30 in drawinglayer::processor2d::VclProcessor2D::RenderTransformPrimitive2D(drawinglayer::primitive2d::TransformPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:1004:5
        >  #31 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:284:13
        >  #32 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #33 in drawinglayer::processor2d::VclProcessor2D::RenderTransformPrimitive2D(drawinglayer::primitive2d::TransformPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:1004:5
        >  #34 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:284:13
        >  #35 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #36 in drawinglayer::processor2d::VclProcessor2D::RenderTransformPrimitive2D(drawinglayer::primitive2d::TransformPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:1004:5
        >  #37 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:284:13
        >  #38 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >  #39 in drawinglayer::convertToBitmapEx(drawinglayer::primitive2d::Primitive2DContainer&&, drawinglayer::geometry::ViewInformation2D const&, unsigned int, unsigned int, unsigned int) at drawinglayer/source/tools/converters.cxx:217:24
        >  #40 in drawinglayer::convertPrimitive2DContainerToBitmapEx(drawinglayer::primitive2d::Primitive2DContainer&&, basegfx::B2DRange const&, unsigned int, o3tl::Length, std::optional<Size> const&) at drawinglayer/source/tools/converters.cxx:332:28
        >  #41 in SvxShape::GetBitmap(bool) const at svx/source/unodraw/unoshape.cxx:717:21
        >  #42 in SvxShape::getPropertyValueImpl(rtl::OUString const&, SfxItemPropertyMapEntry const*, com::sun::star::uno::Any&) at svx/source/unodraw/unoshape.cxx:2597:18
        >  #43 in SvxCustomShape::getPropertyValueImpl(rtl::OUString const&, SfxItemPropertyMapEntry const*, com::sun::star::uno::Any&) at svx/source/unodraw/unoshap2.cxx:1780:26
        >  #44 in SvxShape::_getPropertyValue(rtl::OUString const&) at svx/source/unodraw/unoshape.cxx:1638:14
        >  #45 in SvxShape::getPropertyValue(rtl::OUString const&) at svx/source/unodraw/unoshape.cxx:1622:16
        >  #46 in non-virtual thunk to SvxShape::getPropertyValue(rtl::OUString const&) at svx/source/unodraw/unoshape.cxx
        >  #47 in SwXShape::_getPropAtAggrObj(rtl::OUString const&) at sw/source/core/unocore/unodraw.cxx:1823:23
        >  #48 in SwXShape::getPropertyValue(rtl::OUString const&) at sw/source/core/unocore/unodraw.cxx:1753:20
        >  #49 in non-virtual thunk to SwXShape::getPropertyValue(rtl::OUString const&) at sw/source/core/unocore/unodraw.cxx
        >  #50 in writerfilter::TagLogger::unoPropertySet(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&) at writerfilter/source/dmapper/TagLogger.cxx:123:47
        >  #51 in writerfilter::dmapper::DomainMapper_Impl::PushShapeContext(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/DomainMapper_Impl.cxx:4204:38
        >  #52 in writerfilter::dmapper::DomainMapper::lcl_startShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/DomainMapper.cxx:3680:18
        >  #53 in writerfilter::LoggedStream::startShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) at writerfilter/source/dmapper/LoggedResources.cxx:139:5
        >  #54 in writerfilter::ooxml::OOXMLFastContextHandlerShape::sendShape(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1810:19
        >  #55 in writerfilter::ooxml::OOXMLFastContextHandlerShape::lcl_endFastElement(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1829:9
        >  #56 in writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:223:9
        >  #57 in (anonymous namespace)::Entity::endElement() at sax/source/fastparser/fastparser.cxx:515:27
        >  #58 in sax_fastparser::FastSaxParserImpl::callbackEndElement() at sax/source/fastparser/fastparser.cxx:1330:17
        >  #59 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) at sax/source/fastparser/fastparser.cxx:339:18
        >  #60 in xmlParseEndTag2 at workdir/UnpackedTarball/libxml2/parser.c:9742:2
        >  #61 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11642:14
        >  #62 in xmlParseChunk at workdir/UnpackedTarball/libxml2/parser.c:12351:13
        >  #63 in sax_fastparser::FastSaxParserImpl::parse() at sax/source/fastparser/fastparser.cxx:1111:25
        >  #64 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:891:9
        >  #65 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1469:13
        >  #66 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:515:18
        >  #67 in writerfilter::dmapper::DomainMapper_Impl::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&) at writerfilter/source/dmapper/DomainMapper_Impl.cxx:9143:14
        >  #68 in writerfilter::dmapper::DomainMapper::lcl_substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>>) at writerfilter/source/dmapper/DomainMapper.cxx:4390:14
        >  #69 in writerfilter::LoggedStream::substream(unsigned int, tools::SvRef<writerfilter::Reference<writerfilter::Stream>>) at writerfilter/source/dmapper/LoggedResources.cxx:272:5
        >  #70 in writerfilter::ooxml::OOXMLDocumentImpl::resolveFastSubStreamWithId(writerfilter::Stream&, tools::SvRef<writerfilter::Reference<writerfilter::Stream>> const&, unsigned int) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:126:13
        >  #71 in writerfilter::ooxml::OOXMLDocumentImpl::resolveHeader(writerfilter::Stream&, int, rtl::OUString const&) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:385:10
        >  #72 in writerfilter::ooxml::OOXMLFastContextHandler::resolveHeader(int, rtl::OUString const&) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:888:35
        >  #73 in writerfilter::ooxml::OOXMLHeaderHandler::finalize() at writerfilter/source/ooxml/Handler.cxx:214:20
        >  #74 in writerfilter::ooxml::OOXMLFastContextHandlerProperties::handleHdrFtr() at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1113:28
        >  #75 in writerfilter::ooxml::OOXMLFactory_wml::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) at workdir/CustomTarget/writerfilter/source/ooxml/OOXMLFactory_wml.cxx:7482:26
        >  #76 in writerfilter::ooxml::OOXMLFactory::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) at writerfilter/source/ooxml/OOXMLFactory.cxx:157:19
        >  #77 in writerfilter::ooxml::OOXMLFastContextHandler::endAction() at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:316:5
        >  #78 in writerfilter::ooxml::OOXMLFastContextHandlerProperties::lcl_endFastElement(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1034:9
        >  #79 in writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) at writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:223:9
        >  #80 in (anonymous namespace)::Entity::endElement() at sax/source/fastparser/fastparser.cxx:515:27
        >  #81 in sax_fastparser::FastSaxParserImpl::callbackEndElement() at sax/source/fastparser/fastparser.cxx:1330:17
        >  #82 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) at sax/source/fastparser/fastparser.cxx:339:18
        >  #83 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11493:8
        >  #84 in xmlParseChunk at workdir/UnpackedTarball/libxml2/parser.c:12351:13
        >  #85 in sax_fastparser::FastSaxParserImpl::parse() at sax/source/fastparser/fastparser.cxx:1086:21
        >  #86 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:891:9
        >  #87 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) at sax/source/fastparser/fastparser.cxx:1469:13
        >  #88 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) at writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:515:18
        >  #89 in (anonymous namespace)::WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at writerfilter/source/filter/WriterFilter.cxx:208:24
        >  #90 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sfx2/source/doc/objstor.cxx:2272:34
        >  #91 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:739:23
        >  #92 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sfx2/source/doc/sfxbasemodel.cxx:1940:36
        >  #93 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) at sfx2/source/view/frmload.cxx:720:28
        >  #94 in framework::LoadEnv::impl_loadContent() at framework/source/loadenv/loadenv.cxx:1176:37
        >  #95 in framework::LoadEnv::start() at framework/source/loadenv/loadenv.cxx:412:20
        >  #96 in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) at framework/source/loadenv/loadenv.cxx:308:5
        >  #97 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/loadenv/loadenv.cxx:168:14
        >  #98 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx:593:16
        >  #99 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at framework/source/services/desktop.cxx
        >  #100 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at unotest/source/cpp/macros_test.cxx:71:62
        >  #101 in UnoApiTest::load(rtl::OUString const&, char const*) at test/source/unoapi_test.cxx:115:11
        >  #102 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) at sw/qa/unit/swmodeltestbase.cxx:470:20
        >  #103 in SwModelTestBase::load(char const*, char const*) at sw/qa/inc/swmodeltestbase.hxx:353:16
        >  #104 in SwModelTestBase::loadAndSave(char const*) at sw/qa/unit/swmodeltestbase.cxx:523:5
        >  #105 in testFdo78957::TestBody() at sw/qa/extras/ooxmlexport/ooxmlexport7.cxx:783:5
        
        Change-Id: Ifbc7da0b6c971df61e9908cc02b10a9f50769fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151496
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-08  Stephan Bergmann  <sbergman@redhat.com>  [d7aaec3d11101183b14cb51fe6e444e45736059a]

        Avoid division by zero
        
        bb198176684c3d9377e26c04a29ec66deb811949 "MCGR: Make MCGR default for oox
        im/export, cleanup" started to cause CppunitTest_chart2_geometry
        CPPUNIT_TEST_NAME=Chart2GeometryTest::testTdf128345Legend_CS_TG_axial_import to
        fail with the below UBSan failure (even though the relevant code appears to be
        even older than that commit).
        
        At least for now, lets silence that by explicitly using +INF in case the divisor
        is zero (and the dividend is known non-negative).
        
        > /drawinglayer/source/texture/texture.cxx:246:71: runtime error: division by zero
        >     #0 0x7f2e61d80f7f in drawinglayer::texture::GeoTexSvxGradientLinear::appendTransformationsAndColors(std::function<void (basegfx::B2DHomMatrix const&, basegfx::BColor const&)>) /drawinglayer/source/texture/texture.cxx:246:71
        >     #1 0x7f2e616e187d in drawinglayer::primitive2d::FillGradientPrimitive2D::generateMatricesAndColors(std::function<void (basegfx::B2DHomMatrix const&, basegfx::BColor const&)>) const /drawinglayer/source/primitive2d/fillgradientprimitive2d.cxx:75:31
        >     #2 0x7f2e616e4f4f in drawinglayer::primitive2d::FillGradientPrimitive2D::createFill(drawinglayer::primitive2d::Primitive2DContainer&, bool) const /drawinglayer/source/primitive2d/fillgradientprimitive2d.cxx:172:17
        >     #3 0x7f2e616e66ca in drawinglayer::primitive2d::FillGradientPrimitive2D::create2DDecomposition(drawinglayer::primitive2d::Primitive2DContainer&, drawinglayer::geometry::ViewInformation2D const&) const /drawinglayer/source/primitive2d/fillgradientprimitive2d.cxx:269:17
        >     #4 0x7f2e76cecd04 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const /drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:36:9
        >     #5 0x7f2e619b9278 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >     #6 0x7f2e61a38a25 in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:917:13
        >     #7 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #8 0x7f2e61a5cc3e in drawinglayer::processor2d::VclMetafileProcessor2D::processMaskPrimitive2D(drawinglayer::primitive2d::MaskPrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:2139:13
        >     #9 0x7f2e61a3734a in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:833:13
        >     #10 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #11 0x7f2e619b952c in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >     #12 0x7f2e76ced03a in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const /drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >     #13 0x7f2e619b9278 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >     #14 0x7f2e61a595e3 in drawinglayer::processor2d::VclMetafileProcessor2D::processPolyPolygonGradientPrimitive2D(drawinglayer::primitive2d::PolyPolygonGradientPrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:2014:9
        >     #15 0x7f2e61a36fc0 in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:821:13
        >     #16 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #17 0x7f2e61a2e0da in drawinglayer::processor2d::VclMetafileProcessor2D::impDumpToMetaFile(drawinglayer::primitive2d::Primitive2DContainer const&, GDIMetaFile&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:244:5
        >     #18 0x7f2e61a60f4a in drawinglayer::processor2d::VclMetafileProcessor2D::processTransparencePrimitive2D(drawinglayer::primitive2d::TransparencePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:2292:52
        >     #19 0x7f2e61a378cb in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:851:13
        >     #20 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #21 0x7f2e619b952c in drawinglayer::processor2d::BaseProcessor2D::visit(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:56:13
        >     #22 0x7f2e76ced03a in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const /drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:41:14
        >     #23 0x7f2e619b9278 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:46:24
        >     #24 0x7f2e61a38a25 in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:917:13
        >     #25 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #26 0x7f2e61a68781 in drawinglayer::processor2d::VclMetafileProcessor2D::processObjectInfoPrimitive2D(drawinglayer::primitive2d::ObjectInfoPrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:965:5
        >     #27 0x7f2e61a38916 in drawinglayer::processor2d::VclMetafileProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) /drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx:910:13
        >     #28 0x7f2e619b9a5f in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) /drawinglayer/source/processor2d/baseprocessor2d.cxx:68:21
        >     #29 0x7f2df2676731 in sdr::contact::ObjectContactOfPageView::DoProcessDisplay(sdr::contact::DisplayInfo&) /svx/source/sdr/contact/objectcontactofpageview.cxx:277:31
        >     #30 0x7f2df26741be in sdr::contact::ObjectContactOfPageView::ProcessDisplay(sdr::contact::DisplayInfo&) /svx/source/sdr/contact/objectcontactofpageview.cxx:117:21
        >     #31 0x7f2df291809d in SdrPageWindow::RedrawAll(sdr::contact::ViewObjectContactRedirector*) /svx/source/svdraw/sdrpagewindow.cxx:357:28
        >     #32 0x7f2df363584c in SdrPageView::CompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) /svx/source/svdraw/svdpagv.cxx:239:18
        >     #33 0x7f2df36a80b0 in SdrPaintView::DoCompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) /svx/source/svdraw/svdpntv.cxx:609:21
        >     #34 0x7f2df36a7b61 in SdrPaintView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) /svx/source/svdraw/svdpntv.cxx:522:5
        >     #35 0x7f2df3ec0413 in (anonymous namespace)::GraphicExporter::GetGraphic((anonymous namespace)::ExportSettings const&, Graphic&, bool) /svx/source/unodraw/UnoGraphicExporter.cxx:740:24
        >     #36 0x7f2df3ec857b in (anonymous namespace)::GraphicExporter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /svx/source/unodraw/UnoGraphicExporter.cxx:1037:19
        >     #37 0x7f2db53f082a in chart::ChartView::getMetaFile(com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const&, bool) /chart2/source/view/main/ChartView.cxx:263:20
        >     #38 0x7f2db53f1d43 in chart::ChartView::getTransferData(com::sun::star::datatransfer::DataFlavor const&) /chart2/source/view/main/ChartView.cxx:285:11
        >     #39 0x7f2db53f28ae in non-virtual thunk to chart::ChartView::getTransferData(com::sun::star::datatransfer::DataFlavor const&) /chart2/source/view/main/ChartView.cxx
        >     #40 0x7f2db586547f in chart::ChartModel::getPreferredVisualRepresentation(long) /chart2/source/model/main/ChartModel.cxx:1054:44
        >     #41 0x7f2db586779e in non-virtual thunk to chart::ChartModel::getPreferredVisualRepresentation(long) /chart2/source/model/main/ChartModel.cxx
        >     #42 0x7f2db8401589 in OCommonEmbeddedObject::getPreferredVisualRepresentation(long) /embeddedobj/source/commonembedding/visobj.cxx:186:48
        >     #43 0x7f2e95742555 in comphelper::EmbeddedObjectContainer::GetGraphicReplacementStream(long, com::sun::star::uno::Reference<com::sun::star::embed::XEmbeddedObject> const&, rtl::OUString*) /comphelper/source/container/embeddedobjectcontainer.cxx:1428:54
        >     #44 0x7f2e9573f6b4 in comphelper::EmbeddedObjectContainer::StoreAsChildren(bool, bool, bool, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) /comphelper/source/container/embeddedobjectcontainer.cxx:1198:31
        >     #45 0x7f2e044c7a1f in SfxObjectShell::SaveAsChildren(SfxMedium&) /sfx2/source/doc/objstor.cxx:3316:38
        >     #46 0x7f2e044c6d0c in SfxObjectShell::SaveAs(SfxMedium&) /sfx2/source/doc/objstor.cxx:160:12
        >     #47 0x7f2e0c509471 in sd::DrawDocShell::SaveAs(SfxMedium&) /sd/source/ui/docshell/docshel4.cxx:602:33
        >     #48 0x7f2e0453a4ec in SfxObjectShell::SaveAsOwnFormat(SfxMedium&) /sfx2/source/doc/objstor.cxx:3256:16
        >     #49 0x7f2e0c513d7d in sd::DrawDocShell::SaveAsOwnFormat(SfxMedium&) /sd/source/ui/docshell/docshel4.cxx:924:28
        >     #50 0x7f2e044f8b0c in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) /sfx2/source/doc/objstor.cxx:1457:23
        >     #51 0x7f2e04534ef5 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2993:39
        >     #52 0x7f2e0452c40c in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objstor.cxx:2783:9
        >     #53 0x7f2e04486556 in SfxObjectShell::APISaveAs_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/objserv.cxx:319:19
        >     #54 0x7f2e046d7afe in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) /sfx2/source/doc/sfxbasemodel.cxx:3151:42
        >     #55 0x7f2e046de8db in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1785:13
        >     #56 0x7f2dff75b078 in UnoApiTest::save(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:174:16
        >     #57 0x7f2e63063d61 in Chart2GeometryTest::testTdf128345Legend_CS_TG_axial_import() /chart2/qa/extras/chart2geometry.cxx:322:5
        
        (<>https://ci.libreoffice.org//job/lo_ubsan/2766/)
        
        Change-Id: I72650fba2ee7ba339ec78d24dd690487c31e2600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151495
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [966496b51cbcfe8ab96a652ae2fd4c6dcbfa163c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to faee05bb8a7cbcfac6ee30647b8ae4ba346a0f2b
          - More updates on Drawing bars
            
            + some refactors
            
            Change-Id: Idf1b0c63a00abf65fad8774739b54d5dd33eec2c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151530
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Miklos Vajna  <vmiklos@collabora.com>  [1e75a434e349110990bcccd80b5c63c11080853e]

        writerfilter: fix crash in DomainMapper_Impl::handleIndex()
        
        Crashreport signature:
        
        program/libwriterfilterlo.so
              writerfilter::dmapper::DomainMapper_Impl::handleIndex(tools::SvRef<writerfilter::dmapper::FieldContext> const&, rtl::OUString const&)
                      writerfilter/source/dmapper/DomainMapper_Impl.cxx:6116
        program/libwriterfilterlo.so
              writerfilter::dmapper::DomainMapper_Impl::CloseFieldCommand()
                      include/rtl/ustring.hxx:527
        program/libwriterfilterlo.so
              writerfilter::dmapper::DomainMapper::lcl_text(unsigned char const*, unsigned long)
                      writerfilter/source/dmapper/DomainMapper.cxx:3735
        program/libwriterfilterlo.so
              writerfilter::rtftok::RTFDocumentImpl::singleChar(unsigned char, bool)
                      writerfilter/source/rtftok/rtfdocumentimpl.hxx:718
        
        Change-Id: I4e0f93ce50c8c9a1f9a1a0f9204bd4fee70cdde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151502
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-08  László Németh  <nemeth@numbertext.org>  [4d3d1527c4cf8ab6675d42d02cf313796398b220]

        tdf#147180 sw: fix lost change tracking of empty rows
        
        during partitionating the redline of a tracked text
        containing tables.
        
        Empty tracked table rows use a dummy redline to store
        tracking data. Insert this, when tracked tables in a
        single redline are partitionated after modifying its
        text content, deleting its rows, or using tabulator to
        move cursor in the next cell.
        
        Follow-up to commit a9cf949efcfdb9eb459cabe1b9e15f993e789c73
        "tdf#147180 sw: fix lost change tracking of modified tables".
        
        Tests:
        
        1) Load a tracked empty table, and insert a character
           in the first cell;
        
        2) Insert a tracked empty table with multiple rows, and insert
           two paragraphs in the first cell;
        
        3) Insert a tracked empty table with multiple rows, and delete
           the first row.
        
        4. Insert a tracked empty table with multiple rows, insert a
           character and press tabulator (which triggers partitionating
           as a new regression).
        
        Change-Id: I8bf0f6b201a892a4f54d0bcdde33de440e5be67b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151425
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-08  Heiko Tietze  <tietze.heiko@gmail.com>  [b7632b68c5398fce8a22ec09414e0075709fbc32]

        Resolves tdf#155167 - Start center app pane issue under gtk3
        
        Issue introduced with 77ed6380dda73a9716f48f73c3ff730380557a09
        
        Change-Id: I093808b87bca5f93e28239f22886f543a053e62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151493
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f31bda6971e6f69e2f0c170df4a0dd206aa2f720]

        tdf#154282 - Prevent crash for LeftParaMargin and RightParaMargin
        
        Prevent crash for LeftParaMargin and RightParaMargin by returning both
        values for the hardcoded 0 in SfxDispatchController_Impl::StateChanged.
        
        Change-Id: I7705bd5e22d6cd7fbbe702d7ddbf17e2899b851e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151472
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Caolán McNamara  <caolanm@redhat.com>  [63b8e8bda29efbdde0e0bd7f7d2b18d5a9b7b135]

        tdf#152974 revert change to ORichTextModel::getPropertyDefaultByHandle
        
        properties that match the default are not exported, so we're basically
        stuck with what is in there for compatibility with older versions, so
        revert
        
        commit ca46afebb7dc0ec4375e995fa90edccbed6c2530
        Date:   Tue Oct 4 16:22:51 2022 +0100
        
            default to 'flat' instead of '3D Look' for form controls
        
        and set m_nBorder to the desired new default in the ctor but
        leave getPropertyDefaultByHandle as it always was
        
        Change-Id: Ia862fc6851248fc9b16b3b4c505fdaf6fdb4b2ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [772ce2e0a98a7acc2b80bdf1143782849151e77b]

        unique_ptr->optional for Bitmap
        
        since Bitmap is really just a tiny wrapper around SalBmp
        
        Change-Id: Ie2c9be40f6abba72c600c6778ec42d0689c66558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-08  mostafa-elsharnoby  <mostafaelsharnobi@gmail.com>  [c5c83c8e6c4ddbb7f1fa88b9ab0a67ccbb2627c3]

        tdf#114441 Convert use of sal_uLong to sal_uInt32
        
        Replaced sal_uLong with sal_uInt32 because implementation of the
        GetValue() returns sal_uInt32.
        
        Change-Id: I6e4d9b3f4854da0c60d7ba32b688106639362adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146821
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [240c2410973e5eec1793656538619560a28a500f]

        tdf#144549 Consider number format colors when filtering/sorting by color
        
        Change-Id: Ie2e7aa42c15967c1ce04157163b37798522f7349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151091
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8cd29dac4046e38bcf14784accab94ad1b4ac4d7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36a8ea5fd6658cc2870ad518e8e84a752427bcb7
          - Update Draw/Impress Drawing Bars
            
            + refactor of images and links
            
            Change-Id: I6f97cb7d238e076b60342e0999f3aadeda1632e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151490
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [db4b960643832a52000523ca2eb3667e36af52cd]

        MCGR: Correct import for Gradient presets/templates
        
        Change-Id: I1424ad5deb65f6c72f414a51a40fbd1138c284d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151432
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-08  Svante Schubert  <svante.schubert@gmail.com>  [603934447c19033acc5590c37efffe208b65bbd8]

        XHTML export: Removing former 'ugly' - now redundant- fix added by
        
        tdf146264 as now made redundant by prior changes
        
        Change-Id: I6747e33d1ffd4812d8881e10cda2300e7d79e1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151468
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Svante Schubert  <svante.schubert@gmail.com>  [1f92ade0ae1e54f3220a62d17068f77d09e72e87]

        XHTML export: Removing bullet prefix, which is not viewed in LO - similar
        
        to tdf146264
        
        Change-Id: Iba9a3ca8591591300b4a432caf280935ef8d193a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151467
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Svante Schubert  <svante.schubert@gmail.com>  [5178ade8a12cc52c02cd6288932e5a85dfbaea1b]

        XHTML export: Removing bullet suffix, which is not viewed in LO - see tdf146264
        
        Change-Id: I017c0b6deb84f01f98beddf2b24c0b3500e23e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151466
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Svante Schubert  <svante.schubert@gmail.com>  [e857b12dada1468cb3bdb49ed5ea636df0b6d153]

        tdf#154989 filter: XHTML export: avoid duplicated frames
        
        Various updates on XSLT ODF2HTML triggered by TDF issue 154989 - esp. image/frame positioning by CSS position
        
        (regression from commit f680b6d74209fd78c547201b2f14c6547e55c81b)
        
        Change-Id: I4d08a67ebca7ae3808db07c828488bb9284623a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151094
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Michael Stahl  <michael.stahl@allotropia.de>  [ab85fd73a52256da6feb4fabd1b188f4f0fb7ce4]

        tdf#153839 XHTML export: do not add newlines to attribute values
        
        (regression from commit d2e8705c9cc503afdaed366b1f71ed012b0c568f)
        
        Change-Id: I5e841b1db195b0646c5a2244061f93b97344c3dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151465
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Michael Stahl  <michael.stahl@allotropia.de>  [63ac36893ad7f3b1c73cb46667fbfd5384a747dc]

        tdf#153839 XHTML export: fix syntax error in table.xsl
        
        Static error at xsl:param on line 67 column 40 of table.xsl:
          XTSE0010: xsl:param must not be preceded by other instructions
        
        (regression from commit ce4272c25426f0084e53735e80870b9339239078)
        
        Change-Id: I5bed9a8ad81edc5ec016618cb9fd5d75209a2809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151464
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-08  Hossein  <hossein@libreoffice.org>  [fdd7304485ce00177e4b61e6632d14d89d438756]

        Drop boost dependency for writerfilter
        
        The last usage of boost in writerfilter was <boost/lexical_cast.hpp>.
        This is now implemented using rtl::math::stringToDouble(). To avoid
        behavior change in case it does not find any suitable characters to
        convert, it is checked that the index of the last parsed character to
        be zero, as lexical_cast throwing bad_lexical_cast exception in this
        case but stringToDouble reports rtl_math_ConversionStatus_Ok.
        
        OUString::toDouble() is not enough here, as it does not provide suitable
        error handling mechanism beyond IEEE 754 special values and 0 as output.
        
        stringToDouble() should be able to handle 16-bit char strings, as it
        takes std::u16string_view type string as input, and also uses sal_Unicode
        as the data type for the separators.
        
        The boost library is no longer in use in writerfilter. But, right now it
        is not possible to remove the remainings from the makefiles and includes,
        because of the dependencies that still use boost.
        
        Change-Id: Iae4b83106fcbdded71e7d9e5f70376ab408e9b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139279
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-08  Miklos Vajna  <vmiklos@collabora.com>  [d9a276bc6aaf66241e3a0b5d53b1e8d2dd238d7e]

        sw: prefix members of ProgressBarHelper, SvI18NMapEntry_Key, ...
        
        ... XMLBase64ImportContext and XMLErrors
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic8d1b3515727981c50d8f3a64fe6bf030f0521fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151491
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [bb5e03681c576bc108c1e5c819957f1b34f80ca7]

        tdf#95520 Autofilter: Sort by color
        
        Change-Id: I2c1455cc2c741d16f09eccee0bf489f8990684f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151064
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [900c3a2a854436fdbacd488ef1da12ea99fbceb0]

        svx: use ComplexColor in SvxColorItem instead of the ThemeColor
        
        ComplexColor includes everything a ThemeColor has and in addition
        also can have various other representations that are supported by
        OOXML. This is important for compatibility reasons to preserve the
        color information.
        
        Change-Id: I677775a96511dc1742c75b1949e002eaa8c622e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151226
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7a10187042c1a2b402a9872f66108cfcd8080117]

        XComplexColor and UnoComplexColor - a wrapper for model:ComplexColor
        
        Change-Id: I40107fc38a4d080d969fee862595660d2f585e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151225
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [002ae41bb6088002ba3ed0188ac822fb823a23f9]

        Simplify some initializations in writerfilter
        
        Change-Id: Ib9f653c6add8713a9acf9f6b4605323bcb2c6db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151470
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [28502c1ddb838381b6202c7b066f6964400a5ef9]

        Simplify initialization in cui/source/options/optlingu.cxx
        
        Change-Id: Ie2d68ff2dc9cbc99a10fd3403a72737be4b991dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151478
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [5152841ad0c9e3307285b809b7432bee3df78471]

        framework/taskcreator: declare ARGUMENT_HIDDENFORCONVERSION and use it
        
        Change-Id: Ie4e8c24bf776d0ba0e1b7f986fd506521816d2e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-07  Mike Kaganski  <mike.kaganski@collabora.com>  [059892da740e4272477ad0d69183b0e9b77129d7]

        Simplify a bit
        
        Change-Id: Ibcf59feaa1631c06a393017d1b6342d4a646b9a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151387
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c7cbd685633d44eac554629572f3401c450f855]

        use AlphaMask for variables when calling GetAlphaMask
        
        Right now this doesn't make any difference, since Bitmap is the
        superclass of AlphaMask.
        But when I switch to using alpha instead of transparency, passing
        AlphaMask around is going to mean something different to passing plain
        Bitmap around.
        
        Change-Id: Ic1541e5f0a3b97331793cd23e23115faa7f382b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151463
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [918012d94cf9419318e66aaa489a75e56f81074f]

        simplify code
        
        The BitmapEx constructor already does this check, no need to do it here
        
        Change-Id: Iacd0e1b1d4aa3dfae120e0d4a60a6924ecd9f778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-07  Mike Kaganski  <mike.kaganski@collabora.com>  [4f93995f2262cde0b16bacc83f4ba3c6161ada7f]

        tdf#137972: when correcting PaMs, move them to the end
        
        The cursor position is pushed in SwView::ExecSpellPopup, and popped
        in the end, to restore the changed position e.g. when the action is
        cancelled.
        
        In the replacement, the PaM of the pushed cursor is updated in
        DocumentContentOperationsManager::ReplaceRangeImpl, likely to avoid
        several updates during the further processing. The stated goal is
        to move all PaMs out of the deleted range, but the direction is not
        stated explicitly.
        
        If this correction is removed, the cursor PaM gets corrected anyway,
        and arrives at the end of the replaced text. So, to fix the bug, and
        to be compliant with the default case, let's correct to the end of
        the range, instead of the random direction (GetPoint() may return a
        position at either end, depending how PaM was created).
        
        Change-Id: I83bcf01bcc0bf7277a9a34263b524b1212785814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151462
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f06b19e0f6d6861b0fcec56fb6de3b2dcaaed0c5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bcabd26061bf9740878cdbbbf09c2efb686d2b24
          - Put back string for related topics
            
            Change-Id: I63fecc145ddab0948931ffbd8898fd3d1096cff3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151485
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ece20eb780d116c891f3286163389006b716b010]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35f61fce142836d5bc2542d474e779532f7e68d7
          - Update Help page for Line and Filling toolbar
            
            + several updates and refactoring
            
            Change-Id: I218204d3c37def5acfc89a5eb5b36a19ed3b38be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151484
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5cbfb519aa68465dc4ad6a3fa5ad385e94b2f447]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8c81e75d9094cddd2b62f7835d67e6fe2070254
          - Update icon
            
            Change-Id: I2bf5920120d2c96a06cd17edef7666ca5c7c2901
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151483
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3f30e2e60683b83a93e9be918a69ad34b9631b06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9eff87dfdf14777f4a867c5f6614868a9f8bb631
          - Refactor - no change in contents
            
            Change-Id: Ib8d52fee2054790a97ce5fa57ba573884a96fecf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151482
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6776268604a1282bff26fa9827ac50aa5cd5cb0b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bb76d76debdcb5d63ac58da66723759b2af92eb
          - Refactor help file, no content change
            
            Change-Id: I7f8034e20776809112d86f9253d2980dd343de8c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151481
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [912b25d6bd93a00410592f5b8a8374e0df8bda45]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b3d7e6a7832b4c0dd6b489b9ca0f3229dfeb79b
          - Refactor - Visit help file for icon updates
            
            Change-Id: I69004353c7b6df30e3679900fa9bbe877983d1fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151480
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [96c866ffc77cad945a5efef9f2c4cf6c6a0d3414]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb88bf7fa8e5909ef7da5dde76545eb3b944279b
          - Refactor help page - no contents change
            
            Change-Id: Iecc4632f24421c5fd77636bb9489e298cb72428b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151479
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [4327ee4563d6458a578ebc8685ac7735f361168c]

        Simplify some initializations in framework/source/classes/taskcreator.cxx
        
        Change-Id: I56480780903a39534c3bab8e79e3864fcba10470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151473
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [9f878c69f3da944261989d59f46bd26cc61b0fe1]

        framework/inc/taskcreatordefs.hxx: these are bool and not sal_Bool (2)
        
        Thank you Mike for having spotted it! :-)
        
        Change-Id: I210edf2e05eb6ba02ac9cdd999c4f2233819cfa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151476
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [7acdb3c81f168321977e56995b27f0fe0c36dc1e]

        Simplify some initializations in sfx2/source/doc/printhelper.cxx
        
        Change-Id: Ia85598b6558f8f34187f40d6f5e5285bbc28abf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151471
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [45aa6f7ca99fff8388ade3484f5d5458a84af015]

        framework/inc/taskcreatordefs.hxx: these are bool and not sal_Bool since 2014
        
        See a6287e21f1dab6ae382c24ceeb4c0212b7cad2d7 "framework: sal_Bool->bool"
        
        + /opt/lo/bin/clang-format -i framework/inc/taskcreatordefs.hxx
        as requested when submitting patch with logerrit
        
        Change-Id: Icb21563590a4104f3cb678db44fc4b5f1d884764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151475
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Julien Nabet  <serval2412@yahoo.fr>  [12e0178d4a450386eac6864cb98bf006cef93b85]

        Typo: freature->feature
        
        Change-Id: Ia30740ce0422b2fe5a85e288f18de68a1dca9b33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151474
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-07  Caolán McNamara  <caolanm@redhat.com>  [863d7317a16bdc5a491a1284386abe3dd1f09469]

        crash seen with empty moLineColor on macOS with skia
        
        Change-Id: I260f6bd060b9f1ec3a782ff765b676f78d126d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151461
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a45cb6a037356b891bd13d3f633f83962df7abf]

        avoid unnecessary SAL_WARN
        
        Change-Id: I48db543231f0b7abb7e27173b9bbfd0b657dc716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-07  Caolán McNamara  <caolanm@redhat.com>  [2aabb00d573be097f9d2e9ae4950991035cdcfc4]

        ofz#57493 Timeout negative width/height is negated and mirrored by vcl
        
        Change-Id: I70c0a72d6bbbec7e809edc856976633fce3efa9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6f67eb36d035fa3fe4103e497207452602ff993b]

        tdf#96854 - Remember last used option in copy/move sheet dialog
        
        Change-Id: Iebfd224091c108bb5068b716c39da0979a7ab3ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151437
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-07  Mike Kaganski  <mike.kaganski@collabora.com>  [54d07afac60d68fae9910724c5f273658e9a82cc]

        tdf#155176: only use item's URL in case filesystem path failed
        
        I was daydreaming, when thought that we can rely on the system-provided
        file URL. Windows creates such URLs using current 8-bit codepage, and
        URL-encodes the octets from that string, which fails when the URL is
        treated as UTF-8 after URL-decode.
        
        Change-Id: I2703586d371c1254e693a5760c5b6b74101e299d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-07  Regina Henschel  <rb.henschel@t-online.de>  [dfb0d118f6b23730bc632885eb4703a37eeaec16]

        tdf#139083 Only resize if 'resize with cell' is set
        
        The copy&paste of ranges with shapes had the following further bugs:
        * For cell anchored shapes the position was taken from the source
        rectangle instead of the anchor.
        * Resizing was calculated from source and destination rectangle, but
        should only depend on size of object range.
        * tdf#125938 Shapes were moved without adapting the anchor.
        * tdf#155091 Source with filtered rows produced doubled objects in
        paste.
        * The CopyToClip method has a useless NbcMove(size(0,0)). NbcMove
        is a move 'by', not a move 'to'.
        * tdf#155093 Pasted object has same name as source object and thus
        is not accessible via Navigator.
        * tdf#155094 Transposed pasted objects have wrong position
        * tdf#155095 Objects over collapsed group are incorrectly resized
        * tdf#141437, tdf#141436 transposed objects have wrong size
        
        Only objects, which can really resize, are now resized. In case of
        transposing no objects are resized. Transposing would need to
        transpose the object geometry, but that is missing.
        The offset inside the start anchor cell is adapted to the size of
        the destination cell to keep the anchor in this cell.
        Object resizing considers that filtered rows are removed whereas
        collapsed or hidden rows are shown in pasted area.
        Object resizing does no longer use global factors but calculate the
        desired snap rectangle and fits the object into it.
        
        Change-Id: I42924b28a2d652d8b70cb8e1a1d7ca4324b09cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150161
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-05-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [a2066028ff6b1d0470968bfc064d54cb9d8cbd6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06878198a15d3f7777cde8d24d0c889bd0ff8ec1
          - Proofreading
            
            Change-Id: I314b97f7472ba5159ec7394e243991c2a3e08969
            
2023-05-07  Mike Kaganski  <mike.kaganski@collabora.com>  [4cec737a53c736bd38e81f7ba555c39117aaaf68]

        Revert a thinko from commit 876010cbc4584249e919c694b8b977fd4e83084e
        
        Indeed, the cDecSeparator and cGroupSeparator require that the buffer
        uses the proper character type, otherwise it won't be possible to use
        Unicode separators in rtl_math_doubleToUString.
        
        Change-Id: Id26bed72776475c1be5b092e3ffcff0e75ffe557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151451
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-07  Noel Grandin  <noelgrandin@gmail.com>  [31e2b4746a4a5d7661c4aa8f6a4489e50982aede]

        improve some usage of OInterfaceIteratorHelper4
        
        we can drop the lock immediately after construction (since
        the iterator holds a thread-safe COW link to the underlying listener
        container)
        
        Change-Id: I08f8fa9ed7393747938572097f3c25f5f3f847fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-07  Jim Raykowski  <raykowj@gmail.com>  [50deb478e97aa9cfd023c5fa2f9d567b0b5797c2]

        tdf#154211 SwNavigator: select range of content by shift + double-
        
        click or shift + enter key
        
        Enhancement to make a selection from the current cursor position in
        the document to the position in the document that is navigated to
        when a content entry in the Navigator tree is double clicked or the
        enter key is pressed.
        
        No selection is made when the current cursor position is in a table,
        header, footer, footnote, or frame.
        
        To make shift + double-click behavior for x11 and qt5 the same as
        gtk3, FunctionSet::SetCursorAtPoint is added to the Shift case for
        SelectionMode::Single in SelectionEngine::SelMouseButtonDown.
        
        Change-Id: Id845dad8011ff7777a24f9b2730f10c62271c368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151157
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-05-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [45646542a638ec452b00c0c36a8a65d7194defcc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b176d62d7cb328903699b6ccc0b30e0c91a0ff97
          - Color quick selector help page
            
            Change-Id: I479e0e00fa36035551c47139dda3c2491d3c4dc6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151444
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-06  Caolán McNamara  <caolanm@redhat.com>  [a82d8b489ca2c628dd51a16631dbcc57aa9836d4]

        not interested in what happens during LLVMFuzzerCustomMutator
        
        e.g.
        
        ==34359==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0xf83e3b4 in xmlParserPrintFileContextInternal /work/workdir/UnpackedTarball/libxml2/error.c:201:24
            #1 0xf848d44 in xmlReportError /work/workdir/UnpackedTarball/libxml2/error.c:406:9
            #2 0xf841166 in __xmlRaiseError /work/workdir/UnpackedTarball/libxml2/error.c:0
            #3 0xf8755e0 in xmlFatalErrMsg /work/workdir/UnpackedTarball/libxml2/parser.c:602:5
            #4 0xf8ed9a3 in xmlParseDocument /work/workdir/UnpackedTarball/libxml2/parser.c:10824:2
            #5 0xf915b0e in xmlDoRead /work/workdir/UnpackedTarball/libxml2/parser.c:15175:5
            #6 0xf9178fc in xmlCtxtReadMemory /work/workdir/UnpackedTarball/libxml2/parser.c:15452:13
            #7 0x8d849f in LLVMFuzzerCustomMutator /src/libreoffice/vcl/workben/fodt2pdffuzzer.cxx:68:21
            #8 0x83044a in MutateImpl /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMutate.cpp:550:22
        
        Change-Id: I95c00d8ba0e4f9886ea6a03828cb2f065c6eff1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151454
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-06  Caolán McNamara  <caolanm@redhat.com>  [31a95393e69dbf1b200e323d25182c8b381ddce8]

        cid#1529287 Explicit null dereferenced
        
        after
        
        commit c55d5586304f23f9d8acbaffefba68a3a11c6175
        Date:   Sat Apr 1 16:10:33 2023 +0100
        
            BinaryDataContainer: hand out shared_ptr's to SvStreams.
        
        and
        
        commit 0f2581204a70038ed7ca78089a9bd96d158e02c0
        Date:   Mon Apr 3 09:34:54 2023 +0100
        
            BinaryDataContainer swap out implementation.
        
        it is possible that a eLinkType of GfxLinkType::NativeGif and a
        nStreamLength of 0 could lead to BinaryDataContainer::getAsStream
        being called on a default ctored BinaryDataContainer which would
        mean an mpImpl of null and a null dereference here
        
        Change-Id: Id964e3ce97e5527c5357576131fe03440f1ea00c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151453
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-06  Caolán McNamara  <caolanm@redhat.com>  [7ef7bf9304414488ed7ceec71bb9c2400ebb99b8]

        cid#1529285 Uninitialized pointer field
        
        and
        
        cid#1529286 Explicit null dereferenced
        
        Change-Id: Ibe7832ddcfe0239aa71626075209ef6a052af914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151452
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c042848b688f64b3c56d65dd9dc5fe85412660a]

        Change text auto-fit alg. to also increase the scaling
        
        When in edit mode, the text can be deleted, so the text box size
        can become smaller, but the auto-fit algorithm didn't take into
        account.
        In this case we already have the font and spacing scaling already
        set to a specific value and we need to find a scaling value where
        the margin is the smallest.
        
        This change also adds a test for the issue.
        
        Change-Id: I6c52f06dfbf5a1e582f7b31aceabf4736498ee90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151412
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [6868a857fc8a5256b47da239b573b27d40002080]

        Use getXWeak in xmlscript
        
        Change-Id: I00f644392860162cf7294ff8119bf00a5ec69b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150889
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [af623298ca32543017672bb687e356bf5819b128]

        Use getXWeak in xmloff
        
        Change-Id: I3e40f0731c219cb40019d38a0a986a53776cce83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150888
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [31a5426172f4db94a3ae6d735bc79fc86140535e]

        Use getXWeak in xmlhelp
        
        Change-Id: Iaea6bf7c539d1ab5e0399e07531be08f2764f488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150887
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [325c571c22231978e5409902b514d2584186e0a0]

        update loplugin:stringview* for o3tl::iterateCodePoints
        
        And change o3tl::iterateCodePoints to use sal_Int32 for its
        second param, to integrate better with places where the parameter
        comes from an UNO API, which cannot use std::size_t
        
        Change-Id: I7b9dd2c9bc7f48e6c4a912f039f1b5dae7beae69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151421
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [6276e7c28ed53670fb911ec2bd97a6696583d36b]

        Use getXWeak in svtools
        
        Change-Id: Ia985e96eb441d03ace050f4f184a899fba897830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [d590454062cfef1b6ede8b75311610874f63e5fa]

        Use getXWeak in oox
        
        Change-Id: I8211a1fe19bbd900f866c46d5b7ec68a37bc38cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150859
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [ee3b2907eae61fb46fb6fe1511fafaa2a2b60bd3]

        Use getXWeak in linguistic
        
        Change-Id: I1202763917dab414e8bc540bd89d736e74fa1450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150858
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [4cedea47f9f97ec04e25e36cea38a2fb536bb1bc]

        Simplify rtl_(u)string_newReplace implementation
        
        and unify with *ToAscii(Lower/Upper)Case
        
        Change-Id: I06999b4f5f34abc8da2860b7f9e279608edb40dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151381
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [1db728a70cd2378bfd31c5ea76facd223175f823]

        Simplify a bit
        
        No need to use different temporary objects here
        
        Change-Id: I1b47cae8b80adea5426c780003bddf68310a0060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151380
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [e15e809e331e9fdb7a7ed46937f2ad5f83e27dc5]

        Simplify O(U)StringBuffer's append - delegate to insert
        
        This limits the number of places that know how to deal
        with a given type.
        
        O(U)StringNumber doesn't need an own overload, because
        it has operator basic_string_view.
        
        Change-Id: I6e82dc2cef103b578153fbc3ce16e96247ea9d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151379
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [73ede24746ce7d06487ca34e20af436c2a119cbf]

        Optimize O(U)StringBuffer's append/insert taking float/double
        
        rtl_(u)str_valueOf(Float/Double) are the most inefficient choice:
        their implementations call rtl_math_doubleTo(U)String, asking to
        allocate a new rtl_(u)String; then copy the string to the provided
        buffer on stack, and destroy the rtl_(u)String; and then copy the
        buffer into self. Even using O(U)String::number() would be more
        efficient, avoiding the intermediate stack buffer copy.
        
        But rtl_math_doubleTo(U)String can take also the O(U)StringBuffer's
        data directly, allowing to insert efficiently. Use that.
        
        Change-Id: I720ea7be6f4b2b92865a18eafcdb9ca9a089b854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151377
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [7dbc0e991f65b51f2033b8c8c60df055926d37b9]

        [API CHANGE] Fix O(U)StringBuffer::insert taking float
        
        It was broken from the start: it was introduced like this already
        in commit 9399c662f36c385b0c705eb34e636a9aec450282
        (initial import, 2000-09-18).
        
        Creating a temporary copy as a return value makes no sense.
        
        Change-Id: I6910d426c2437038ec4979be2c44cd72146dec9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151375
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-05-06  Heiko Tietze  <tietze.heiko@gmail.com>  [77ed6380dda73a9716f48f73c3ff730380557a09]

        Resolves tdf#134941 - Fix size issue on start center
        
        Very tiny screens or huge scaling may result in cut-off
        content at the app pane. The scrollbar should solve this.
        
        Change-Id: I33e6fa3b428c8643f8024bb1287d93dfe4f3b1bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151422
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-06  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [793cc7d2ef5967af90a6810e597e1e12bd42777c]

        tdf#154872 Add Poisson distribution to Random Number Generators
        
        Change-Id: I325a76423a98a405dfb0f69fbd89eb9253c36390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151439
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e594493d4fe1d623467eb9dbcd4e2fb1637b6e4b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2726113c1c969d43fbc7c4df996b24408868ec8
          - Refactor Help page - no contents change
            
            Change-Id: I97fd085d2c1a2e2c8a82034a1d15b7408535ffec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151443
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-06  Gabor Kelemen  <kelemeng@ubuntu.com>  [69d0be09ad81935f7da4b6f8d036c3562357d068]

        [API CHANGE] Drop unused config group AppWindow
        
        It was not used ever since added in 2002 by
        commit 72cbd26315bf935a0d6e2c9ffcdbea7d2ada07fb
        
        Change-Id: I3be8a020174677a6e876628307b2deb311874e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151059
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-06  Gabor Kelemen  <kelemeng@ubuntu.com>  [10d74fd12af9708b427afd927ce13a90b53b6588]

        [API CHANGE] Drop unused config keys ButtonLarge, ButtonFlat
        
        Do not seem to have been ever used since added in 2002 by
        commit 72cbd26315bf935a0d6e2c9ffcdbea7d2ada07fb
        
        Change-Id: I64a437111d3c2d54e205de944421b05552e9600d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151060
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-06  Gabor Kelemen  <kelemeng@ubuntu.com>  [5eb3ec6cbd74eafcf2a6c44da23cfba385c44c13]

        [API CHANGE] Drop obsolete TemplateRepositoryURL config key
        
        Its use was removed in 2020 by
        commit 9eaaf97ab32068a619b5c36772619b7e66268800
        
        Change-Id: I47b86a9b1bf528d611fa3a79054681bd85382bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150989
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-06  Gabor Kelemen  <kelemeng@ubuntu.com>  [0ca0cd7294e938fff6f0107803c27411cb367f63]

        [API CHANGE] Drop unused PropertyBrowser->ExperimentalProperties config key
        
        Seems to be unused ever since it was added in 2006 by
        commit a9d03e7895953a30790c09e0975dbbf116e05111
        
        Change-Id: I26fe886d48d066146b0f925925ae61c45539dfb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151406
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4f58329fa4db17df21cacc35b2f14acf21cc39e2]

        Fix typo
        
        Change-Id: I3a482c273498da94d5f3d8928cfd31fa63f9f6b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151438
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-05  Michael Meeks  <michael.meeks@collabora.com>  [0f2581204a70038ed7ca78089a9bd96d158e02c0]

        BinaryDataContainer swap out implementation.
        
        We can easily accumulate a large number of in-memory graphic
        objects, and swapping these as well as the un-compressed
        images can become important.
        
        For now we swap out the container when the image is swapped
        out, however it seems unlikely it will ever need to be swapped
        in again.
        
        Despite the shared pImpl, we retained the reference counting
        on the underling vector to keep this immutable while we hand
        out a MemoryStream reference to it.
        
        Change-Id: Ib7ca45afb8499460b1852461f7c11afca3f3cdfa
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151359
        Tested-by: Jenkins

2023-05-05  Miklos Vajna  <vmiklos@collabora.com>  [d1999f23caf47a36786182adbe071619fd60f999]

        sw doc model xml dump: restore lost spzFrameFormatTable section
        
        This was lost in commit b12ff94a771db17843f642a82820b2864bec4744
        (introduce sw::FrameFormats<>, 2023-04-11). It used to be handy that you
        can search for spzFrameFormatTable in a doc model xml dump to quickly
        see how many fly/draw formats the document has, so restore it.
        
        Change-Id: Ia5d83e2f71f589208a7ad5718d5705b17520db5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151433
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-05  Caolán McNamara  <caolanm@redhat.com>  [7e68e49667f58e741abeaa88bb934faaa2d46244]

        adjust some fuzzer max-lens
        
        Change-Id: Idf893faafac27d8a395bd39ca8297121e8ceffa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151435
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-05  Caolán McNamara  <caolanm@redhat.com>  [2d428c1b7d6221eb634cecb2ca7719bf4997ead4]

        experiment with LLVMFuzzerCustomMutator
        
        Change-Id: I3294c4e6cc5671927824cffaf03fd536a0a7dba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151403
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-05  Caolán McNamara  <caolanm@redhat.com>  [6dc61f97cbd8333632e87155a8deaa5b7d45b60d]

        build and use an odf fuzzing dictionary
        
        Change-Id: Ib6dabc636cd171151ce77e48a0e774e955ab7ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151434
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-05  Caolán McNamara  <caolanm@redhat.com>  [61c06d531171c079a032097e00b9602a192cbd1f]

        use the mathml dict for the mml fuzzer
        
        Change-Id: I5b238bfad2495b3354140a39366001186b3eb91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151426
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-05  Caolán McNamara  <caolanm@redhat.com>  [9e745192f19dda1328231c680ee17275c3c89932]

        Resolves: tdf#154337 allow submitting to file: if user agrees
        
        continue to allow submitting to http[s]: without further interaction.
        Don't allow for other protocols, except for file: where the user has to
        agree via dialog prompt.
        
        Change-Id: Ia915f4f33d5dba621971ce69a156c339da933b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151418
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [87cefcdce6a02044e61c3173777b4546f3ad39f6]

        chart2: move UItest to CppUnittest
        
        Change-Id: I4c9a2f9488a031b497c3ef87bcec9c1413002e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151423
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a86cbb0da80e0e05c041a8ddbd8e16df47638c73]

        tdf#131759 - Remember last used option in split table dialog
        
        Change-Id: Id7aaa300babff988f0244d822860d455d57c86c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151160
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [2361718a34ee4ef47901846cb35eea4552bca46b]

        tdf#155149 Crash when exiting cell edit mode
        
        regression from
            commit 2dc240a82646fc23c673a6fd5a29ade934dd5b67
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue May 2 14:47:43 2023 +0200
            improve AccessibleEventNotifier::addEvent
        and
            commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 4 10:06:14 2023 +0200
            tdf#105404 [API CHANGE] add index to accessiblity change event
        
        (*) Send better index hints
        (*) Error check the index hints better
        (*) Convert asserts to warnings and fall back to old code when
            index hint is wrong.
        
        Change-Id: I8e752fc26e729c9c8926beb2c7b196f5418a147e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [b10417eb1e5a4a6959e7fc1cdd9819e5b09d39a4]

        tdf#151974: sw_uiwriter3: Add unittest
        
        Change-Id: Ieb22d53a262a378539bf1bc576826f83797267f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151420
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-05  Maxim Monastirsky  <momonasmon@gmail.com>  [86b48c757906c3ef647f3d5e2579ac1fef1bf55b]

        tdf#155144 sd: Don't reset table styles on RTF pasting
        
        Regression of daab698b346e5e40b67f1e15c796c4e399ccaf8a
        ("sd: replace hardcoded table styles with xml file").
        
        The problem is with the temp SdDrawDocument reusing the
        document's DrawDocShell. Before the mentioned commit we used
        to insert the default table styles directly into the style
        sheets pool, and that didn't affect the dest document as each
        SdDrawDocument maintains its own pool. However, after that
        commit we go through ODF import which use the document model
        which happens to be the dest document. This results with all
        the default table styles being replaced, with all their
        formatting being reset, and all existing tables being reset
        to the default style following the disposal of the original
        styles. At the same time, this leaves the temp SdDrawDocument
        with no table styles in its pool, and so the newly inserted
        table ends up with no style assigned.
        
        Change-Id: I9bebae929ec3d54e0139dd212ad0ad1dfe815caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151417
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-05  Seth Chaiklin  <sdc.blanco@youmail.dk>  [abe1b3ff2e0f2fc0e9ccf8ac3f22fa34babc7155]

        tdf#153653  vertical centering of "Assign" button
        
        Change-Id: I55d14e419f008684fdd184ece79c2e50f37f9aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147981
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d532b15472f42bda831c5404f78f92725e66e83]

        tdf#101894: chart2: move UItest to CppUnittest
        
        Change-Id: I54d7376cb9b96164ed8c4526ef8f3a0502326f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-05  Szymon Kłos  <szymon.klos@collabora.com>  [edab3e4d2941a545b6f84df41003fa621c4471d3]

        lok: Hide file linking in section
        
        this is followup for 6f56317
        
        Change-Id: I87227b3e665a6d15378ee294556bcd2f95801e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151231
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit c7fffb9ff3a0d0636d86bf68086d5ae3fd3f8ae6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151272
        Tested-by: Jenkins

2023-05-05  Stephan Bergmann  <sbergman@redhat.com>  [28cc0bff10f5dcec0c7b698ae7ba275845b2cad1]

        Break comphelper::adjustIndexToStartOfSurrogate out of o3tl::iterateCodePoints
        
        ...as what they do is orthogonal (and it turned out that the use case that
        motivated the addition of o3tl::iterateCodePoints in the first place needs them
        independently, anyway)
        
        Change-Id: Id33901a2f7ac627253654ee6d883305dcf5a456f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151415
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-05  Stephan Bergmann  <sbergman@redhat.com>  [c1bd421eae5449a005f2ee0f01b3b4e72002296e]

        Add some o3tl::iterateCodePoints tests
        
        Change-Id: I00f7d8bbcf7588bb2d5df1bc6f68e2d5d224bd3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151414
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-05  Stephan Bergmann  <sbergman@redhat.com>  [f614e082055dd3cad9885d6e1968d71f1e1b5a05]

        Fix typo in assert
        
        I accidentally broke this in fa0c012d6c06e9a92093dacf997fe3151272648e "Provide
        std::u16string_view based o3tl::iterateCodePoints" when moving the body of code
        from rtl_uString_iterateCodePoints to here and then adapting it from sal_Int32-
        base OUString to std::size_t-based std::u16string_view.
        
        Change-Id: I5bd97413ac8c8482f409ad5be3797fef47191d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151409
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-05  Stephan Bergmann  <sbergman@redhat.com>  [9c6b7283e366788c629b237cb2a3045ce926fed6]

        loplugin:unnecessarygetstr
        
        The plugin in its current form is probably not intending to find these cases.
        But it happened to do so on macOS with libc++, where the std::basic_string ctors
        taking a final defaulted Allocator argument are instead implemented by a pair of
        overloaded ctors, one taking no Allocator at all (see
        671d1c6cd14b28b5960ad56086299bd69533dfd8 "Adapt loplugin:unnecessarygetstr to
        libc++").
        
        But these changes here are useful regardless, so lets leave it at that.
        
        Change-Id: I2776671e2953182bdcad36432951a75f82412ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151410
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-05  Miklos Vajna  <vmiklos@collabora.com>  [f7e1cdf951f7f9cbb5822c49b86ba8a77a2fa878]

        sw floattable: fix UI for turning fly split off
        
        Given a multi-page floating table of 2 pages, turning the "allow frame
        to split across pages" checkbox off in the frame properties dialog
        resulted in a 1 page document, but with 2 fly frames instead of just 1.
        
        There were 3 problems here:
        
        1) SwTabFrame::MakeAll() should join the follow table frames, similar to
        what happens then the split bit on the table itself is turned off.  Note
        that this is only safe if the frame is not chained, either.
        
        2) SwTabFrame::Cut() should mark the follow fly for deletion. The check
        here was broken, since we didn't do anything in case the split bit is
        off for the fly frame. This looks OK, but we still need to handle the
        case when it was on, but it's now off.
        
        3) Finally SwFlyFrame::Format() always increases the height of flys to
        at least MINFLY, so drop the HasArea() condition that prevented
        deletion. Checking if the fly has content is probably enough.
        
        With this, disabling the "split" checkbox on the frame dialog results in
        a single fly frame, as expected.
        
        For the testcase, improve Create1x2SplitFly() a bit, so it's closer to
        what floattable.docx import would create (to help debugging) and also
        improve SwFlyFrame::UpdateAttr_(), because previously that only worked
        by accident, due to some rounding error on the UI. (So the fly size
        changed even when that was not the intent.)
        
        Change-Id: I7b33e6557282032c5d8ed2c3aea21b78a33bd6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151408
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [140d09520cc92135093d61e8b6b0de9cc26a4edc]

        Fix typo
        
        Change-Id: If680acecd66a59f2fcd12aa8121bdf548404ca51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151405
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a7952962ace0ff0ab1dc5379b27fdabc82a64b5]

        Fix typo
        
        Change-Id: I4998d44daba0c3802e8d79a3bba4dff1b1e653e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151404
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-05  Miklos Vajna  <vmiklos@collabora.com>  [5d66979a58363e0362b13c637b7eade0fc28505d]

        sw layout xml dump: extract SwFlyFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about fly frames.
        
        Change-Id: Idc10a3c8130a961b01a0abbf6f52b093937fd0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151401
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-05  Vojtěch Doležal  <dolezvo1@cvut.cz>  [d543eb2d8e45999a3d8fa6134f0d98f08acb8037]

        Reworked bibliography mark link target to have user-selectable type
        
        Without this change, havign no link is not possible, if the bibliography entry has URL.
        This commit adds a select box for user to choose between target types (Entry URL, specific Target URL, None, bibliography table row)
        The main features are that it also makes it more obvious to the user and makes it possible to easily extend target types in the future.
        
        As for compatibility, files from before 7b99871635 are fully compatible without any hurdles, as missing property maps to the old behaviour.
        Bibliography marks saved after 7b99871635 will also revert to the old behaviour, however no actual data (such as target URLs) will be lost.
        
        Change-Id: Iad61dd8b4df337fa202f45d117313ee47ec20c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150708
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-05  Stephan Bergmann  <sbergman@redhat.com>  [671d1c6cd14b28b5960ad56086299bd69533dfd8]

        Adapt loplugin:unnecessarygetstr to libc++
        
        > [CPT] compilerplugins/clang/test/unnecessarygetstr.cxx
        > error: 'error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/unnecessarygetstr.cxx Line 119 (directive at compilerplugins/clang/test/unnecessarygetstr.cxx:118): unnecessary call to 'getStr' when passing to string constructor [loplugin:unnecessarygetstr]
        
        because libcxx's <string> declares
        
        > template <__enable_if_t<__is_allocator<_Allocator>::value, int> = 0>
        > _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string(const _CharT* __s)
        
        and
        
        > template <__enable_if_t<__is_allocator<_Allocator>::value, int> = 0>
        > _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string(const _CharT* __s, const _Allocator& __a)
        
        instead of single
        
        > basic_string(const charT* s, const Allocator& a = Allocator())
        
        Change-Id: I8d64b140618337adfba01c02d5d02fda093628f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151392
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-05  Aron Budea  <aron.budea@collabora.com>  [5e7327e9313e2d9fe2f0defb30d3e7dc28c0b2ce]

        cui, lok: Hide options irrelevant for online in Spelling Options dialog
        
        User-defined Dictionaries part and
        Get more dictionaries URL + icon.
        
        Change-Id: I73825a481e1981145abbf36b44485fb1628fbe13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151212
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-05-04  Patrick Luby  <plubius@@users.noreply.github.com>  [3bc7cc14706f47d740dfc5715970054922ca470c]

        tdf#152173 Don't display tooltip windows when application is inactive
        
        Starting with macOS 13 Ventura, inactive applications receive mouse
        move events so when LibreOffice is inactive, a mouse move event causes
        a tooltip to be displayed. Since the tooltip window is attached to its
        parent window (to ensure that the tooltip is above the parent window),
        displaying a tooltip pulls the parent window in front of the windows
        of all other inactive applications.
        
        Change-Id: I35caf480a8afb42694957a4a6c2bec20be591ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151394
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-05-04  Justin Luth  <justin.luth@collabora.com>  [794af70fa802c7f495d217b435991f5a7551edcc]

        Revert "tdf#86630 sw page number wizard: add contextLabel"
        
        This reverts 7.6 commit b89f65a5138fe74b7858c2817fae4204b021c1f5
        
        and also take the opportunity to add a tooltip.
        
        It was thought that the label would only be noticed
        in tools - customize. However, I have discovered that it
        also is shown in the notebookbar. Thus, it may very well
        be used in other user-visible places.
        
        Additionally, Heiko didn't like the term "wizard"
        since it is a single-step dialog.
        
        Change-Id: Ib11b68625eebf190d49ee8ce2b7b63378e248820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151400
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [b6e68913f7086a816483cdf6f5e548b1fcf1d41e]

        CppunitTest_sc_macros_test: inherit from ScModelTestBase
        
        so the code can be simplified
        
        Change-Id: Iedbb844e5f11b993d73fb32d6871d74779919e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151368
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-04  Caolán McNamara  <caolanm@redhat.com>  [a831886004fba93a4eb0e5675b1e3e8afbe3d3bb]

        Resolves: tdf#155140 gallery right click for context menu doesn't consume event
        
        Change-Id: I13b6d62561e3d9eed47f81c4268a6a32ff108b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151355
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f9c6fbfd4c96d53357bf63c1903087ad10707b0]

        remove some dead code in ImplWriteDIB
        
        which has been dead since
            commit 1ecdddcc32ce2b003fca43ac2c5ef0668afef8dd
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Oct 27 17:13:16 2017 +0200
            loplugin:constantparam in vcl
        
        Change-Id: I39c689b75231a6de1eb993c13e416df63f9a16db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [491866af90346c0af014f9d77300ca055b25af76]

        CppunitTest_sc_shapetest: use existing method to go to cell
        
        Change-Id: I96f8f676964920a9bf9c31d8fa81a17788f763af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151367
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [7df8b258d9ae2aa4217f38c81390523481f52520]

        CppunitTest_sw_uiwriter3: simplify code a bit
        
        Change-Id: Idd4c436164d874c803f9171587eae684c5f3f794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151395
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-04  Justin Luth  <justin.luth@collabora.com>  [639c01dcf9aabe587df0ff4f661cc4e38244e304]

        tdf#86630 sw page number wizard: add to notebookbar insert menus
        
        There are two places in the notebookbar where this
        Insert page number could fit - in insert and in layout.
        
        Both of these have "Title Page" in the menu at the right,
        so this patch adds the page number wizard underneath that.
        (Title pages should be setup first before page numbers are added.)
        
        This is pretty non-controversial I would hope.
        A follow-up patch will consider placing it on the main ribbon.
        
        Change-Id: I195ee5a134a581cb6570485f84e4030b63d7895c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151396
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-04  Stephan Bergmann  <sbergman@redhat.com>  [cd3f8acc4dc803fef4453ae31037eba15acfefa7]

        Adapt loplugin:randedforcopy to libc++ std::vector<bool>
        
        Seen unhelpful
        
        > sc/source/core/data/dpoutput.cxx:882:10: error: Loop variable passed by value, pass by reference instead, e.g. 'const const reference&' [loplugin:rangedforcopy]
        >     for (const auto bCompact: aRowCompactFlags)
        >          ^~~~~~~~~~~~~~~~~~~~
        
        on macOS
        
        Change-Id: I9854e2498950951efc640bf31741229631e00e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151393
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-04  Stephan Bergmann  <sbergman@redhat.com>  [fa0c012d6c06e9a92093dacf997fe3151272648e]

        Provide std::u16string_view based o3tl::iterateCodePoints
        
        ...as requested in the comments of
        <https://gerrit.libreoffice.org/c/core/+/151303> "a11y: Fix returning unpaired
        surrogates when retrieving characters" (incl. the additional preAdjustIndex
        parameter).
        
        The type of the indexUtf16 parameter obviously needed to be adapted to
        std::u16string_view's std::size_t.  But there is no obvious best choice for the
        type of the incrementCodePoints parameter (int? std::ssize_t?), so lets leave it
        as sal_Int32.
        
        For simplicity of avoiding a Library_o3tl, and to allow o3tl::iterateCodePoints
        to be used in the implementation of rtl_uString_iterateCodePoints now,
        o3tl::iterateCodePoints is provided as an inline function defined in the include
        file.
        
        Change-Id: I8280ca11d2a943bd2b7150a266807b358f321a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151366
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [2711b42088ad8e19c2bccd265f032b4acaba7b9e]

        tdf#154478: sw_ooxmlexport18: Add unittest
        
        Change-Id: I277d6fb8c1e9b8c46fed6bd07460513c11f089bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151357
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-04  Stephan Bergmann  <sbergman@redhat.com>  [3f39a7ada7b5cadf71da2fa5307dd456c7f8d735]

        external/libjpeg-turbo: Missing include (for FILE)
        
        Change-Id: Ifb80f4824ab7a89177171f7dc91a2c6bb6f954f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151369
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-04  Caolán McNamara  <caolanm@redhat.com>  [6990fd3e4199c71fd1490b895ff30ef18d387e52]

        Resolves: tdf#155076 set annotation cursor to Text on mouse enter
        
        Change-Id: Ib3b1f90dd055ddd3b343f83d3118f090ea449b71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-04  Caolán McNamara  <caolanm@redhat.com>  [96a403b9b12fbea4cd1d72c55597dd64023de465]

        Resolves: tdf#155029 set StandardStyles before updateFromModel
        
        otherwise it overrides custom settings set by the model properties
        
        Change-Id: If5898aba3f2701b6d6bdaed99f9cb01174e53613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-04  Hossein  <hossein@libreoffice.org>  [894bb1128ca0e80b96d48bfd94556f70af02ce41]

        tdf#150457 Port UITest to CppunitTest
        
        The UITest for tdf#150457 is now ported to CppunitTest. The new test can
        be run by:
        
         make CPPUNIT_TEST_NAME=testTdf150457 -sr CppunitTest_sw_uiwriter3
        
        Without the fix d05c176cc022f1b771f7c064f6ce74e9f8c27a1b in place,
        running the test leads to a segfault.
        
        Change-Id: I1d633cadf9f5579cdf3e1e59641108eadc7b7073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151330
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-04  Caolán McNamara  <caolanm@redhat.com>  [b50df5aa72fb1259734794222119c5ad3017ba26]

        Resolves: tdf#134308 if max undo is 0, treat as if no undo
        
        Change-Id: I7eaa71d80718a4350ba6a3d7ff19ce09e1ac3aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151354
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [cef0b4c187a669896706799967def4a9aecf2126]

        speed up dealing with large shape selections
        
        cuts the time spent waiting when changing large selections by 90%
        
        Change-Id: I558b5b28449d0cc6b1d3b5e9e4cf455a4b37016a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [724d21ec7383c7422efafc784ec21bad8b448569]

        Fix typo
        
        Change-Id: I95d5aff29a500ef171f198b28e8b5a4b43b61fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151361
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-04  Julien Nabet  <serval2412@yahoo.fr>  [24cf81f9bc1165d21657a710e717d1c967e2cef7]

        extensions: adjust max possible for reserve in eformspropertyhandler
        
        Change-Id: I9ff8e3afbf4dbc662a78d071a18a2f1f03da063a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151351
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d548d283f0ce369fa03d6f2c1ddf0f8e988bc65a]

        tdf#105404 lock model while updating
        
        to reduce broadcasting while we are doing a "break" operation on a
        vector shape, shaves 50% off the time here
        
        Change-Id: Ied77c81c892727b69481c23ea7c5eff0e7eeb830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b7db802731826b6cc3b55100470b0c61c1f2dfa]

        tdf#105404 [API CHANGE] add index to accessiblity change event
        
        Which shaves 80% off the time off breaking up a vector image on Linux.
        
        Change-Id: Id8e7daad001b6120d1fb98e382357da5b55e92ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd02cdd4b5ef0fc96225501ba8f6758af8b6c69e]

        tdf#155037: check source code name exists
        
        Otherwise, it crashes with
        terminate called after throwing an instance of 'com::sun::star::container::NoSuchElementException'
        
        Change-Id: Ic53bedcc19690d43aef20d4193e840e340e349d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151336
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4cae4a11642f0d8f0c8005141893e34e1c216fde]

        tdf#154818 - Find bar: remember and reuse last search string
        
        Changed remembered search string in the find bar from user
        configuration to session and added UI test.
        
        Change-Id: Idf211f1fadd87ba935fe3948c20c4e511aa8afdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151335
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-04  Regina Henschel  <rb.henschel@t-online.de>  [f2eac63dcca642efc80a171a986aecc482f9cbc6]

        WIP ODF import and export for MCGR
        
        Current state uses:
        Element loext:gradient-stop with the attributes svg:offset,
        loext:color-type with value 'rgb', and loext:color-value with
        values of kind #rrggbb.
        Element loext:opacity-stop with the attributes svg:offset and
        svg:stop-opacity, both with datatype double.
        
        With MCGR enabled testColorGradientWithTransparencyDOCX in
        CppunitTest_chart_export3 has the value 90000 instead of
        90196. That is same value as in original file. Thus I have
        adapted the test.
        
        Change-Id: I976934f9b8fb79be4f74adb180b3285486dce31f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150060
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-04  Justin Luth  <justin.luth@collabora.com>  [0f4a3823a6bab01723f2a958d44159d39d137b97]

        tdf#148956 sw: clear RES_TXTATR_LIST_AUTOFMT in FN_FORMAT_RESET
        
        This is a relatively new "character style"
        that comes form importing MS formats.
        
        Character properties that apply to the whole paragraph
        as direct formatting are stored in here.
        So when direct formatting is cleared,
        this property should also be reset.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf148956_directEndFormatting
        
        Change-Id: Ic843da464c69050e989ae9be53ae58dde9c80948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151329
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-04  Miklos Vajna  <vmiklos@collabora.com>  [8c34ed6e8d62c5fe558b11bb91c5405e5bf2798e]

        sw floattable, crashtesting: fix PDF export of ooo9470-1.doc
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        The immediate problem was a failing
        assert(GetPageFrame().GetPhyPageNum() == GetPgNumOfCollected(nIdx)) in
        SwObjectFormatterTextFrame::DoFormatObj(), becase the floating table was
        in a multi-column section and no code handled that correctly.
        
        Fix this by just disabling the split of floating tables in multi-column
        sections, seeing that Word does the same.
        
        Note how FindAnchorCharFrame() is not used to get the fly's anchor,
        because that would call IsFlySplitAllowed(), leading to an infinite
        recursion. Additionally, the first IsFlySplitAllowed() call is on a
        non-split fly, so GetAnchorFrame() gives us the correct frame in this
        specific case.
        
        Change-Id: Ibd163018d6d71ee613549ec835075653f7c20755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151347
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-04  Caolán McNamara  <caolanm@redhat.com>  [1efb16454f813dce9dffc124b43a31e46a1b9e3f]

        tdf#108889 ref count goes negative with 0 undo levels configured
        
        Change-Id: Ic28c3738f951af6e5371f88b4bb061a0aadf16e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-04  Rasenkai  <rasenkai99@gmail.com>  [e5402f1b1f5d44d5e40eede80ae05303036a4efe]

        tdf#119931 Fix accessibility warnings
        
        Signed-off-by: Rasenkai <rasenkai99@gmail.com>
        Change-Id: Id211c56f0090516ec0118110038be70f003ff80f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150706
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-05-04  Julien Nabet  <serval2412@yahoo.fr>  [5ed998cb2f6f7965f51c3d091048f83d454a5c5a]

        extensions: reserve the right nb of elements for vectors
        
        Change-Id: Ie89edc6be31f6c0349075a7ee190383814f57daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151343
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-05-04  Baole Fang  <baole.fang@gmail.com>  [1cff5c9db7e0d7cf7ae45b306deb963d95926d99]

        tdf#128192: Fix Tools/AutoCorrect/Apply
        
        AutoCorrect() is applied in GET_ALL_INFO and HAS_FMTCOLL stage.
        Also, UITest is added by examining whether "Replace dashes" is performed.
        
        Change-Id: Idcb34ad03c4fe8df27ed126bf39ce23ab4f02846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151008
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [e265a6e016e3ec8818ba49351ca5a4dcb8b67d72]

        tdf#150994 Rename Quotations to Block Quotation
        
        As discussed in the ticket, the paragraph style "Quotations" should be
        renamed to "Block Quotation" everywhere in the code.
        
        Change-Id: Id789f0777e7ef6c96714fbdb81c802185d9b4c86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150973
        Tested-by: Jenkins
        Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-05-04  Juergen Funk  <juergen.funk_ml@cib.de>  [b6af287527d42f8cf4bc43047fe0ed6130420d6b]

        tdf#153587 Display CTRL+F in the keyboard shortcuts list
        
        * Add the missing entry to Accelerators.xcu
        * Handle vnd.sun.star.findbar:-command the same as .uno commands
        
        Change-Id: I69d441d63a6b0478a07c9ef10665b7d59d3334b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151322
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-05-04  Miklos Vajna  <vmiklos@collabora.com>  [55f6141b65411f15a99d509ad5bd7bbab63cd129]

        sw: fix undo comment of FN_UPDATE_SECTIONS
        
        It's an update of sections, not insert of a section. One has to dispatch
        .uno:UpdateSections to see this in action, which does something if the
        document already has existing sections.
        
        Change-Id: Iaca5448feceea3fc2bc450586e5f67981550d8f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151339
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-04  Amin Irgaliev  <irgaliev01@mail.ru>  [8d8779808063aeedcf0d2b7efba3d2f82e0d7bef]

        tdf#154839 Add navigation buttons for slides
        
        Change-Id: Ie9a533acf94f5760c6233aa70259bec620f420fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150448
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-04  Justin Luth  <justin.luth@collabora.com>  [83b1f6b58a30bdb589e9ce73deef39f021aebde1]

        tdf#86630 sw page number wizard: avoid crash when no GetCurrFrame
        
        The steps to get the crash were:
        -create a header (and leave the cursor in the header)
        -use the wizard to create a non-mirrored footer
        
        I had seen this crash happening occassionally during development,
        but hadn't yet identified the exact steps to consistently reproduce.
        Thanks to QA who tracked that down.
        
        Although it looks/feels like a hack, it actually works amazingly well.
        The simple act of SetCursorInHdFt "fixes" GetCurrFrame/Get*PageNum,
        but we can't always use that because we don't know whether we
        are on an odd or even or first page when we start, so Goto*Text
        is the best when non-mirroring.
        
        Change-Id: I0e2f28d9c8fd2d1a10afede885b525c42ed08af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151345
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [a55af69baefd7965da3a7faf5af1c049fe99f9b4]

        [API CHANGE] Drop unused LogicalGraphicSize config group
        
        This was added in 2002
        commit d6da51a02d1804b691be5e2ff6d9318a240b6b05
        and last touched in 2010 by
        commit 9508a731824e7f8a692d462da763b2db95463875
        but was never used in code
        
        Change-Id: Ic18eb94470152bfd6e42b317923627b93256076b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151036
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [dc73651a9df268ac9ab76cb84cb6a662727160a7]

        [API CHANGE] Drop unused config key ShowOfficeUpdateDialog
        
        Its use was removed in 2011 by
        commit 83ee1bccf9899bb5c1913389b9a26a73a515ad82
        
        Change-Id: I995b994c47b2ea9b908867698fe72d7c13e37b0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150991
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [01ac5c55ec3583d5c1b26f10170a71fd988da6b9]

        [API CHANGE] Drop unused ProductVersionID group
        
        Its use was removed in 2009 by
        commit fb623aa0e73ed6fcd19f70fbe5a8d8aabe17aa65
        
        Change-Id: I5c08f8f84e1262b003dc22783c6b2ae47fa18f72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150987
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [ce8a5ea8dd4eb85c0b598ca9bdaf3207aa18f49f]

        [API CHANGE] Drop deprecated config group GraphicSize
        
        Deprecated in 2002 by
        commit d6da51a02d1804b691be5e2ff6d9318a240b6b05
        
        Change-Id: I265a1a03fdd9cfde4c1450f6cd0e799577ff0967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150990
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [a51e53fd211696df3a566b34986cc75d42361880]

        [API CHANGE] Drop empty config group Gallery
        
        Its last key was removed in 2013 by
        commit 8e7a1ad17cdcd677e40865daa9bbdbe69927360d
        
        Change-Id: Icd9f175ba0195227454a22f3c76ac4307ae90ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150992
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [f7a4a68fed76ff39449f4c07b5cd04d89d6e7a96]

        [API CHANGE] Drop deprecated config keys...
        
        Misc/Path/Current/Temp and Storage were deprecated by
        commit 8c895561f63ed7161947a04da8e6a3d3fb195fa7 (2009)
        commit 3cf21a8bb947ffdffbdcec36880bc16ea39d1335 (2004)
        
        Change-Id: Id37650557e5c9ac791dffc9569aa1f23e9bedc89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150996
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [1339324674673e4aa9f3943b4ccbd7c2b03fb156]

        [API CHANGE] Drop unused Excel_Lotus, W4W, Writer groups
        
        These seem to be unused ever since their 2002 addition in
        commit 72cbd26315bf935a0d6e2c9ffcdbea7d2ada07fb
        and some description in sw with:
        commit 7e30aa52adc691c6b468ec4e15089e32a418b919
        
        Change-Id: I8e5c76e8483aa5dbd0934f4eabc16538366b26a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150994
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [f111333b5586c743ea71386f057b2ed5e0cea1ca]

        [API CHANGE] Drop deprecated Java config keys
        
        Deprecated by
        commit 095c439703a861a65a17a34b59ce626a7491ac56 (2002)
        commit d8155fb911c85cfef2ed6f886797d2700f867e14 (2004)
        
        Change-Id: Id37fdbee40f6d411dc4416763a1c1e79ee9ac232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150997
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [4c65a29e7f35844e8c75b462cdf3a659c464b288]

        [API CHANGE] Drop empty config group ExternalApps
        
        Its last use was removed in 2004 by
        commit f5d946a558378b1b156dadae9b8dd588e0e1fbf5
        
        Change-Id: Ieb2ae9c16cf55adb173fa0b5260afc83722db117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150993
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [e4c59b7be32a305b4753acc466750b1ed3694913]

        [API CHANGE] Drop unused DialogSize group
        
        Added in commit 72cbd263 and changed in commit f0554890
        but not actually used even back then or ever since
        
        Change-Id: Ifbe780917b86fdc0cd78d08c92d44b51707c701b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151049
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [1b7c4394de4f5ddd381436289d00f5777d5152a3]

        [API CHANGE] Drop unused NameCounter template
        
        Its last use was removed in 2017 by
        commit 49b237c46efa1ba3513dfbe6c782c713296352d8
        
        Change-Id: I1ed0bdc9c01430ec432015bcbf3ec25f6920c5d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151050
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [009c594a65deadafe2953f27789070d4ee8c2e64]

        [API CHANGE] Drop deprecated config key CompressMode
        
        Deprecated in 2004 by
        commit 93e3a53e678ebcac85a20105a270b5a191b9279e
        
        Change-Id: I90d5447eef50de3a46e7ae7716ae440219812ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150995
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-04  Justin Luth  <justin.luth@collabora.com>  [08aefd5522e54059788d53ecf863d2deac78c029]

        tdf#86630 sw page number wizard: fix divergence from HIG
        
        Thanks to Seth for pointing this out in
        gerrit.libreoffice.org/c/core/+/151152
        
        Possible misses still?
        -24pt column (start of rightVBox)
        
        Also taking the opportunity to fix copy/paste error
        with the translation context.
        
        Change-Id: Ic542875331104c376d53b3fb195f2aa2a3e485df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151242
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-03  Justin Luth  <justin.luth@collabora.com>  [2f474d5690d0c9850ef82efa26f2f82580c09a8d]

        tdf#127322 svx: add back MID_GRAPHIC_URL to SvxBrush
        
        This fixes the problem where gallery images
        could not be set as page or paragraph backgrounds.
        
        This URL attribute was removed in LO 6.1 with
        author	Tomaž Vajngerl on 2018-03-09 09:41:44 +0100
        commit c7ff07b2dab639b901c80f1f62efee4dd3ad549b
            remove MID_GRAPHIC_URL and related mappings, implementation
        
        Most of this was restored shortly thereafter with
        author	Tomaž Vajngerl on 2018-05-07 16:30:35 +0200
        commit	7a8ed362eb163ac15a000ba1cfc74b58315800a1 (patch)
            [API CHANGE] revert and deprecate *BackGraphicURL add *BackGraphic
        
        However, this piece wasn't restored.
        
        Change-Id: Ia74d2562b61135f3294a7d6ebfa72cfadb4bdb5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151342
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-03  Caolán McNamara  <caolanm@redhat.com>  [8b865782d798a33f95ddedad2bde78cb8450708a]

        pass the std::vector instead of its data()
        
        Change-Id: I9319896eb4d0e7728a9ded77fa1bfd05e63fbbe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-03  Caolán McNamara  <caolanm@redhat.com>  [a7a008d055eecf540b5d20060754cc686508a895]

        tdf#147526 a macro case which results in a null Lower() result
        
        while deleting a table
        
        Change-Id: I5e80a654e668fbcd7086a904bbed853eacbfc08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cfe49a23bc3ac79117a120d0f661f98e384798e2]

        Fix typo
        
        Change-Id: Iaf3db11f667f46a421726fee10ace21581fc3853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151337
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-03  Pranam Lashkari  <lpranam@collabora.com>  [a4e8c663b613fcd2ec26211faedb6e703f27806b]

        jsdialog: enabled word count dialog (writer)
        
        set mobile fields visibility only with mobile phones
        
        Change-Id: I5680effe9df5de01221bcf52e339490aa5dd5a6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150024
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit e7bcf7aa95a31dcefc82f56b23a36424353016c3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151280
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1c706980a79812d4fb0930ff35217a4b776aafd7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 15ebd0257b457b87f4de43352d9b5d51272b5dba
          - Include Date add-in functions in Date&Time Help page
            
            Change-Id: Icf4b9bb113b778b059928eb117d88084551ba6ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151341
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2ef458f166eada06659d28fcca4e23723b75023]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 507bed7d6fe7ea2347648813008074e8fd1e90f8
          - Refactor help page - no contents change
            
            Change-Id: Ib45b27e20c047b9c1b65251729a54dcac40e48ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151340
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [d23da1892448669162781a6847c447b75b434f11]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f50afd07d060f8f67a4503d2d6bbe468bba747d8
          - Explicitly use the adjectival form here
            
            I wrote a rationale for this change in core commit 15ae7425b9fdc6e5f2613cd91bcad795eef5fc5e.
            
            Change-Id: I7600ab8fe8998cdc2fc9dbbc3701c3f99efe08af
            
2023-05-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [15ae7425b9fdc6e5f2613cd91bcad795eef5fc5e]

        Explicitly use the adjectival form here
        
        For the longest time, I had a gripe with commit 6efb46c6493d4c3c2208dcbea25471c0268fc10c
        but I couldn’t explain to myself why. And after I proofread some of my own translation
        work I finally understood why — the word “archive” is ambiguous in that it can refer to
        archival science (which is the intended meaning here, given the context of the ISO 19005-1
        standard) or to computer files that contain other files inside it (vd. Wikipedia article
        https://en.wikipedia.org/wiki/Archive_file). Me, and other translators, chose subpar
        wordings as a result of the ambiguity (in the case of Spanish, I used “archivador” for
        what should have been “archivística” all along). Mea culpa, yes, but the string could’ve
        been better.
        
        Change-Id: I96693fc4df1c45b19417ad1bdd4fffd2dc6dc5be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151316
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4ec4b875b952b05b8b1e0ba73dc31c1bcd27e43]

        Portion can use sal_Int32 for its key
        
        which makes it a little more cache-dense on 64-bit platforms
        
        Change-Id: I6a7d22d94a04baac623a23d4766d4d8b7bbbb570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151325
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e19c102e87002f953f2eb28c154da8f54b70068e]

        tdf#136991 speed up rtf load
        
        (*) since we are searching an ordered list, and we know that we want the
        "next" range, a linear search is faster than a binary search, especially
        when the list becomes large enough to exceed cache.
        (*) Since element "i" and element  "i+1", we can start the second
        search where the first search left off
        (*) Since we are moving forward through the list, we can limit
        subsequent searches by the results from the previous loop search.
        
        This reduces the load time by 15%
        
        Change-Id: I460339e3bc12e0a8bea39334173a34b2aa79515d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b779b948cc46461b9c7aaa0a01d719879dfe65e5]

        tdf#136991 speed up large rtf load
        
        We can limit the search when scanning the portion map, based on what the
        previous search returned.
        Reduces load time by 10%.
        
        Change-Id: I46ef6e80b4ef100318d911a636e28b166b053779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ebfd2f10b400ad215ccd2263267f48a79b1427ef]

        tdf#90496 - Remember last used view in hyperlink dialog
        
        Changed remembered last used view in hyperlink dialog from user
        configuration to session.
        
        Change-Id: Ifd04fc92d8ca8880d85c6cb52a7e364cff54a82e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151331
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0dd4cd98504124362524727c5f9eae731c1944f]

        tdf#136991 reorganise lcl_ExportHints loop
        
        to reduce some CPU cycles by avoid calling GetSortedByEnd multiple times
        for the same key.
        
        Change-Id: I2c77c1f70f3c7d3e2f5801edfacc2e511d7b375f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [feb2bec3c3f02881df3f447a72e4d9f214e1481b]

        Formula W.: tdf#78826 colons tdf#150045 sec. labels
        
        Change-Id: Ied39588884eed9d1602bac7e1bca9cf2dc7ac0c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151319
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d4348a0c3bd3cae35d84b87c0c026878b5d7334]

        sc: use commas instead of semicolons in test
        
        See https://gerrit.libreoffice.org/c/core/+/151262
        
        Change-Id: Iecfc019d4b1eb16b572a13e8d9ad34088bd7bbba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151328
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [78dc25539e820548aaa9e355ed03d9f7a54297b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b332f3fa1e24fe1ee5a5408bcf29f14b5af612a
          - Refactor - no change in contents
            
            Change-Id: Ib15fe46548cb481a52d2f374eb5b074c0ee6aa8f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151333
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-03  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [bb198176684c3d9377e26c04a29ec66deb811949]

        MCGR: Make MCGR default for oox im/export, cleanup
        
        Following an error in CppunitTest_chart2_export3 I updated
        the transparency definition at WriteGradientFill and
        corrected usages.
        
        Had to correct/adapt some Chart UnitTests. Some of these
        changes are temporary since this will/has to change when
        ODF MCGR im/export is integrated. I checked that all of
        these cases actually work, comparing im LO and MSO.
        
        Adapted some Chart2ImportTest to directly compare/check
        now for the fully imported tranparence gradient with
        available higher precision.
        
        Adapted OoxDrawingmlTest testGradientMultiStepTransparency
        to use new MCGR capabilities.
        
        Adapted testTextframeGradient and tested the turn-around
        with rtf gradients. These are a little bit limited and
        needed some extra care.
        
        Adapted testTextframeGradient.
        Adapted SdOOXMLExportTest1, testTdf94238
        Adapted SdOOXMLExportTest1, testTdf128345GradientAxial
        Adapted SdOOXMLExportTest2, testTdf105739
        Adapted SdOOXMLExportTest3, testTdf127372
        Adapted SdOOXMLExportTest3, testTdf127379
        Adapted SdMiscTest, testFillGradient
        Adapted testTextframeGradient
        Adapted ScFiltersTest3, testTdf129789
        Adapted SdUiImpressTest, testPageFillGradient
        
        Adapted SdOOXMLExportTest1, testTdf128345GradientLinear by
        using better double-to-integer rounding (basegfx::fround) in
        DrawingML::WriteGradientStop. After double calculations
        this makes the tansition to integer correct and stable. Also
        took back change at testTdf128345ChartArea_CG_TS_export
        which showed the same flaw before.
        
        2nd look @testTdf128345Legend_CS_TG_axial_export made me
        add that stuff again and adapt the axial ColorStop adding
        in the export to not export the middle enty twice. Extended
        test a little bit, too.
        Only do not add value if it starts at 0.0 aka StartColor,
        else adding it is corect.
        
        Adapted some tests CPPUNIT_ASSERT to CPPUNIT_ASSERT_EQUAL
        after being pointed to it from gerrit_linux_clang_dbgutil
        build.
        
        Change-Id: I4a993053da8960035671b655e67908f36e59b5fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150763
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-05-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f1fd3e32508ee3e8aca6f90724e7af8664652e41]

        update credits
        
        Change-Id: I3243e55b996f8a647fbe060f83a76d3ee416e6b9

2023-05-03  Justin Luth  <justin.luth@collabora.com>  [92fe70072d16922af41ab0fd3746172f3a58e489]

        tdf#148956 sw: clear nAttrStart == paraEnd hints in DOCX
        
        I don't think that native Writer will create a character
        property at the end of a paragraph. (I couldn't do it manually
        or by round-tripping a problematic DOCX file.)
        
        However, DOCX does need to do this. However, a Ctrl-M
        to clear direct formatting was not clearing out those
        attributes (that don't span any text, but just sit
        at the end of the node).
        
        This patch fixes that problem.
        
        Change-Id: I6bd93fc145d226f785287e6991b7ea6e3fcd1c9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151306
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-03  László Németh  <nemeth@numbertext.org>  [966e955ea09772ad1e3363f1813e5b26bfa41671]

        tdf#155134 DOCX export: fix crash with old table format
        
        Handle missing start nodes of boxes in old table format.
        
        Regression from commit dd5e5f3fab4b8f736baeda0f706c77a4ea9b6804
        "tdf#150824 sw DOCX: fix export of new tracked tables".
        
        Change-Id: Ib10afa52351c683c3d3407aff567d6a8e2c76306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151318
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-03  Julien Nabet  <serval2412@yahoo.fr>  [c4aa51f497db8b659cc66402dea7be88f57c2580]

        Related tdf#154769: XML Form add limits of length value for some datatype
        
        length value for:
        - year:4
        - month and day:2
        
        change ISO8601parseDate in unotools to return false when month or day length > 2
        
        Change-Id: I807a8a784c8924750ae2c821de4be667e514e91f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151238
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2dadde7cf6999ba64c3db8ecf477e1c752af98f0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 92dbd56ebbb21c475c13bda88db729dedd981b49
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Icbe8231ea11d0eb6a624d2b18a4e314fa8267a6a
            
2023-05-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [8828ff5015702bd520808ce46f2266c66ccd11fd]

        Proofread these recent strings before they go to translators
        
        Change-Id: Ia7e4131b8e05abcc74e38ee31a1a7a9eb634a71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151292
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d72f3d480eaffd8bd6d14fe60f01c995886cf317]

        tdf#137544 simplify SdrObjList destructor
        
        by allowing the maList to destruct naturally, it deletes the objects
        from first to last. This speeds up the search process when these objects
        remove themselves from broadcasters.
        
        Change-Id: I0534b39bc82b24d0e4245773e105a77bce735c9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151315
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-03  Jaume Pujantell  <jaume.pujantell@collabora.com>  [5431b756d45bebe74beaba2026704552ee6891f0]

        tdf#154478 fix comments empy after ToC
        
        TOC creation entered a malformed state where it interfered with
        the creation of other elements (e.g. annotations and textboxes).
        This change is also a fix to tdf#154481, so the patch from
        94de79e7d3c98 can be removed.
        
        Change-Id: I423f9d048b8c5b89fd38229c4f3ad41213d5ab67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151103
        Tested-by: Jenkins
        Reviewed-by: Ashod Nakashian <ash@collabora.com>

2023-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [6f8d649b8c0ae0849e5c1f279c0f24700ec3f0d2]

        tdf#143574: sw: move UItest to CppUnittest
        
        Change-Id: I7a259df2291ab34a99ab58c359965c5e4873f97e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151314
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9b8ae4df0ec765c5d65a27a6c3ef5daa7606e99f]

        Fix typo
        
        Change-Id: If92643e3e8aad5a3367b9ee20afa5a1fef7ee8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151317
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2b54a73118849a107f516c61c517f259f7d4530]

        tdf#155028: sw_uiwriter3: Add unittest
        
        Change-Id: Ida1de2645969394069066519ea18d546af3da96a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151269
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-03  Michael Stahl  <michael.stahl@allotropia.de>  [0913da454e2dd88fb8fc83cddd20c735b79f73ca]

        sw: fix crashtesting assert on tdf124604-1.docx
        
        frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `... || oTaggedParagraph || ...' failed.
        
        Here the problem is that the numbering label on the last paragraph is so
        indented that it ends up off the right end of the page, and so the loop
        in SwTextPainter::DrawTextLine() terminates before seeing it.
        
        Sigh, add another special case ...
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I6bb7385a10269d77d533c3b98462602e58a60317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151299
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-03  Michael Stahl  <michael.stahl@allotropia.de>  [336a3c3d5b5b8e502cb6edfecf4f5fa1780b13e3]

        sw: fix crashtesting assert on ooo95981-1.odt
        
        itrpaint.cxx:433: void SwTextPainter::DrawTextLine: Assertion `roTaggedLabel' failed
        
        The problem is that there are 2 SwNumberingPortions, and CalcPaintOfst()
        skips one of them.  So the portion that doesn't have a follow may never
        be iterated.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: If6618b183cf533f69091d4657d3a412f9d1cc4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151298
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-05-03  Miklos Vajna  <vmiklos@collabora.com>  [8c78361b05ba3cefe5b0f31f35113f7890fd2296]

        sw floattable: don't try to set various character properties as table property
        
        Cell UNO objects don't have such a property, and this generates a
        warning on importing sw/qa/core/layout/data/floattable.docx, silence it.
        
        Change-Id: Ie8e104ba9b028d0e1d9cf4893b4002b1b2a89f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151311
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-03  Seth Chaiklin  <sdc.blanco@youmail.dk>  [8426c38a23e5bcc4a8fc061113755de0f8dbc250]

        tdf#153897  "mark" to "entry" for index .unos
        
        Change-Id: I3e9b94e5e6d7073773b3d39276a7f708f34492ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151196
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-05-03  Miklos Vajna  <vmiklos@collabora.com>  [59d609c047dad12d2448f1686b379adc5575865c]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfJpgImg
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I0719e6d3e8338d2e61900b3b230489a10b62ee83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151296
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-03  Stephan Bergmann  <sbergman@redhat.com>  [46da86c845c871b8f28ed5dc92fcfd5dbac12ad4]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/c80b412af7ec1d15b49c64ec6590450e9bacd3f2>
        "fix missing user-installed fonts"
        
        Change-Id: I76f10959b37c2c1c41bfaed6f7b4199ba0e6f3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151294
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-03  Baole Fang  <baole.fang@gmail.com>  [e8d7bf954fe74ce85bdd084d6e12d27027a4c379]

        tdf#145925: Support AutoCapitalize in DOI recognition
        
        Sometimes, the first character of the doi string is auto capitalized, which isn't recognized as DOI.
        Now, the doi detection is able to recognize doi string with the first character capitalized,
        like what is done in url recognition.
        
        Change-Id: I95334941dc4cda3095f1750fea927640dea55e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-05-03  Heiko Tietze  <tietze.heiko@gmail.com>  [a21e151508918c39189a18d46fcba490100e5890]

        Resolves tdf#101876 - Resizing function wizard content
        
        GtkPane added
        Function entries expand now
        
        Change-Id: I3f900540fadb530a8c154ec1bdf3771daecb7acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151258
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7df67f4cd7d3e763e684041db6d63d17a3280d88]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18bf37d1dadbdd5631b8c3a60d3385038513f3df
          - tdf#155100 LibreOffice treats 1900 as a common year, not leap
            
            Change-Id: Id8ab89baa623f04a49a307856ea063a2301a2ce3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151302
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2023-05-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [47016a3374af6effb795ada4efa9fb682b566e25]

        Fix typo
        
        Change-Id: Ib3e60b4ab1ab61354294e8c41ea08906a4e47d4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151304
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-03  Justin Luth  <justin.luth@collabora.com>  [98f766004e29ea35eef6fcf3a4c28696b95f6c90]

        tdf#86630 sw page number wizard: try avoid copying bookmarks
        
        Each time the pagedesc is changed, it makes extra copies
        for undo purposes. That really messes up unique bookmark names.
        
        So, consolidate all the page description changes,
        and make the change in one big batch.
        
        I like this better anyway, because now it doesn't
        look like all kinds of magic incantations.
        This is now straight forward programming,
        and consolidates three separate calls to adjust the page style.
        
        Change-Id: Ib200a1f6ba810fdf0111c9909679e3f80d573230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151243
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-05-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [98726695af0e3a673618d16b981818155d43bc0c]

        simplify SwSortUndoElement
        
        No need for a union to save the minimal amount of memory. The code
        is much harder to read an more error prone. Just duplicate source
        and target - in one kace to be SwNodeOffset and other as OUString.
        
        The assumption that SwNodeOffset doesn't have a default constr. is
        also not true anymore, so we can just freely use that.
        
        Change-Id: Ia96182eb2f872d0ca8f2e71ef2258d4b929c2d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151263
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-03  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [2d0a87f97e2c9ac50cd6ce329ca8256daf94ead4]

        tdf#151974: writerfilter: apply props only to new document
        
        Properties applied to document shoudl be a case only for new doc,
        but DomainMapper can be called during pasing of RTF and cause
        modifications to props in already open document.
        
        Tested only for "NoNumberingShowFollowBy" but I assume this is
        a case for all compatibility props.
        
        Change-Id: I4558d809ca477918373b15fa05500ed985e170a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151069
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-03  Eike Rathke  <erack@redhat.com>  [95c10ff05c4036587302e03e903aa849cba828f3]

        More complete positive list for ScFormulaReferenceHelper::ShowReference()
        
        Various operators were omitted so for an expression using only
        such like '~' range "union"/concatenation the ranges weren't
        highlighted; also use indexOfAny() instead of repeated indexOf().
        
        Change-Id: I288bb8e0a2bf738bbc3a56025474a18ea18a4d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151297
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [581764d7781477deada108c7fa108c684983fbc8]

        [API CHANGE] Drop unused config group AddXMLToStorage
        
        Its use was removed in 2009 by
        commit f87ee64d502aec9365d98d53d5b913f6456eae6b
        
        Change-Id: Ie9f65ac548ce9eff53156f61df40dbff839a8d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150983
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Julien Nabet  <serval2412@yahoo.fr>  [0c0c9a0dd8a7b102315ab1075f78a0f1f3397b67]

        tdf#155057: Wrong colors in some WPG2 (well rendered in WPG1)
        
        Thank you Fridrich Strba for the quick fix in libwpg!
        
        Change-Id: Icb2a48cdd7846ac9f2b32ca65a479381d8c8bfed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151217
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-05-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cd3cbb40d52c1e8a17bdfe00ecc3609a67626c1a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8508046cdf9b54dfe73c4def579abe53db4f5211
          - Refactor page - no change in contents
            
            Change-Id: I8466c9b6441908d3ba01e78fa3317dd4ecd66f6b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151301
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [8decea689985c75cbe5b302c47687d0a998772ba]

        [API CHANGE] Drop unused keys from the Scripting group
        
        OfficeBasic, its use was removed in 2020 by
        commit fbc909364c9c3964c1354169527e68446905c39b
        
        ExecutePlugins, Warning, Confirmation, their use removed by
        commit f36433c10a4be39bd5e93621ee46766c587ad57c
        
        Change-Id: Ic2bca7b8652f84a1f81141325ae520f138dbeb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150986
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [4b6f64f55c8a763f348ff33cca3e5a7623e87b4f]

        [API CHANGE] Drop deprecated config keys of Window group
        
        Window -> Key, Version, State, Flag, UserData
        
        Deprecated in 2002 by
        commit 9f0aea44a8437d55d5d88cda7359fbbb5c5622a6
        
        Change-Id: I1b086c1b87542e954262d09e23debbefe6068e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150985
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [e161d39ccdd4dd90abffdc1abf09eb8179104c3f]

        [API CHANGE] Drop obsolete JobDescription and Startup config groups
        
        Obsoleted by 2004 commit 2f9e9552202bbc8314c44107fdddd2f34cdfe507
        and 2002 commit 3dcc79adb407499bd6ecd581c92efd84244d5bd1
        
        Change-Id: Ided71e52b05d99cd5b73694737cf4b4ed4c08bf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150982
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [e603786daac6a5ab62bb4c9edf837b1b1d46c5bf]

        [API CHANGE] Drop unused config group InputMethod
        
        Its use was removed in 2019
        commit 5bfa8b8d5e1cf3cb572dbd91bf3b0cfcf29fb65a
        
        Change-Id: Ibdf90d2bf65dc55e8bb535b7609c1e636f815850
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150984
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [8bcf321d549799e530c81f22ff90096668442a96]

        [API CHANGE] Drop TotalCacheSize ObjectCacheSize ObjectReleaseTime config keys
        
        Obsoleted by 2018 commit c6cf2320d2a464594e759289c34796538d31f02b
        
        Change-Id: Ifc83b8dae06ef84d2ae276c18a395185db330cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150964
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [5dc7f2f2c6bb1ab9ec29696adbfc9f0506b22e0b]

        [API CHANGE] Drop obsolete ObjectNames group
        
        Deprecated by 2004 commit f1e7d342bff9d58cc6aa1ab3878ef0d112cc26ed
        
        Change-Id: I9d3dcb47bdd4a9cc217e1a534a003e173a4aeda1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150965
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-05-02  Caolán McNamara  <caolanm@redhat.com>  [831ccb770f318a4be039431b14ce0cd247174e44]

        ofz#57493 Timeout
        
        Change-Id: I2a61016c771012f23415e753ca91bf254584131a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a2435b4ae52bbbe8bd7d0fd0cf6a32ee42aac98]

        fix mistake in commit "optimise ensureGeometry"
        
        In
            commit bfe32f3e50b5406810e740ac41368f101033e766
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jan 12 20:51:39 2022 +0200
            optimise ensureGeometry
        
        I got the return value wrong for the early exit case.
        I am quite surprised this did not mess up something
        in the drawinglayer line handling.
        
        Change-Id: I6788ef8898575c89344f25f6e66c4ae0a999f013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2dc240a82646fc23c673a6fd5a29ade934dd5b67]

        improve AccessibleEventNotifier::addEvent
        
        we use the OInterfaceContainerHelper4 notifyEach function to avoid
        copying a vector of listeners
        
        Change-Id: I96476bb6100630a5c5d0f5d0973f821de702db39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e63866ea343dea0d1c528c9f7069be44bc034c0]

        tdf#137544 use cheaper method to scan accessibility child list
        
        which shaves 2% off runtime here
        
        Change-Id: If574fad4ff756e03eac8e96cba3226bacb2828ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151267
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [0431264c2bfbc73c6b7aa832ad7ac458daaeddc6]

        tdf#137544 no need to broadcast in ~SdPage
        
        It's not clear to me that we ever needed to do this - originally we did
        not, and then we did, but only to avoid UserCall being triggered back
        into us. Then the UserCall was explicitly cleared before the listener
        were notified.
        So just remove the notification again.
        Which removes 10% of the overhead here.
        
        Change-Id: I51f508e86c9785742bb092b7b3ae18f62f1f10f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151266
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3c6c36e6fffeafa235e9230901e81b08866e6b2]

        tdf#137544 reduce cost of AccessibleEventNotifier
        
        the ListenerContainer can be a moveable type, which means we can store
        it in a node and avoid an indirection and an extra allocation.
        Also use unordered_map to speed up lookups.
        
        Change-Id: I888f0418b035e459cce3facd956ba51db97335a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151265
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Mike Kaganski  <mike.kaganski@collabora.com>  [d7823e0266d38dd83d7f824f6bafb3898ccbca75]

        tdf#155122: implement CtrlHandler on Windows
        
        Change-Id: Ia766db91030528c320a27a2d608bd0ec0a34f31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151261
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-02  Mike Kaganski  <mike.kaganski@collabora.com>  [da50aaff5324661cbc7b4513ba249d9ed58f3626]

        Avoid unneeded cast
        
        Change-Id: I8ab52af3b53e3da5f4dd006674c0392fcce46987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151291
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-02  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [1aaa884edb23612b9fa2cb3f78c6d7149c2b4de3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e506fc8bfa0170c98277320023e73c60b7c11a87
          - correct string for menu entry "Edit Formula"
            
            Was changed from "Text Formula" to "Edit Formula" back in 7.3
            
            Change-Id: Ie443bfc7ced17a5fc45ebaceb95e3fe06d59cd9a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151276
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-05-02  László Németh  <nemeth@numbertext.org>  [a9cf949efcfdb9eb459cabe1b9e15f993e789c73]

        tdf#147180 sw: fix lost change tracking of modified tables
        
        Tracked text insertion can contain tables in a single
        redline (i.e. change), e.g. in case of newly inserted
        or deleted tables. Editing this tracked table, e.g.
        typing new text in a cell, deleting rows or columns
        resulted loss of the change tracking of the table by
        replacing the single redline over the table with
        redlines within the cells. Now add tracked row changes
        to the (not empty) table rows to keep change tracking
        of the table.
        
        Follow-up to commit 1555ba4dd9e90f0dfd39df952c3d2fd5e755e2f5
        "tdf#150824 sw DOCX: fix export of new tracked tables" and
        commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I8eb46b240c3f5036b5b0966e2a523e369cb02e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151169
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-05-02  Miklos Vajna  <vmiklos@collabora.com>  [1c99616f86f7d5b83b91edc225fc95fec227d710]

        sw floattable, crashtesting: fix PDF export of forum-mso-en3-26783.docx
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        Inspecting what the layout does, the trouble was that the bugdoc has a
        floating table, immediately followed by a non-floating table. This
        breaks the invariant that floating tables are anchored in the next, text
        node. In practice we anchored the floating table in the first cell of
        the next table, which is not the same as a floating table followed by a
        normal table. (For comparison, the DOC import simply lost the floating
        table in this case.)
        
        Fix the problem by making sure there is a text node after a floating
        table, in case it's directly followed by a table (no text node
        in-between).
        
        Changed tests:
        
        - testFloatingTablesAnchor: this still asserts that the flys are all
          anchored in the body text
        
        - testTdf95755: the problematic table is still not as wide as it used to
          be in the bad case
        
        Change-Id: I30b9ae423914b0b2cb1ebc7c1dce7efcd4cc3cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151251
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-02  Caolán McNamara  <caolanm@redhat.com>  [46e40f2f7c742ffe01833551bb2843d156716be0]

        ofz#58550 Direct-leak in writer layout
        
        Change-Id: Id29138896a8da7a6badbeecfb0df24171c51f145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151264
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [30334be31f190b5da79f3ba2bec94b2ff35ad72c]

        tdf#119659: sc_uicalc: Add unittest
        
        Change-Id: I9c1851d4c0520345d632ceef202f9991d2e6d359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151262
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-02  Justin Luth  <justin.luth@collabora.com>  [751cb2cf874a2d017cae699a7983e4419dcbe6f6]

        tdf#86630 sw page number wizard: add page total
        
        1 - 3 is the format of the output.
        Not totally clear, but it is at least not in English,
        and I'm fairly certain I've seen this format used numerous times.
        
        At least everything is there, and all the user needs to do is
        modify the - to be whatever they want.
        
        I checked to see if by some miracle localedata had a specification
        for "X of Y" but it doesn't.
        
        Change-Id: Iae1e74e612ec449f72086b3f5a5e32713fee4d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151173
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-02  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [453af38f46ad4c2eb3125b8d2967c91b950b3c50]

        tdf#155049 Revert "tdf#115884 PDF signing should mention it only works with x509 certificates"
        
        This reverts commit a1146fd95022196636f8c41f7322a7257955cef4.
        
        Reason for revert: needs special case for PDFs as this dialog
        is also used when signing ODF files
        
        Change-Id: I8b9a007816732066746b790ee03654f4b5b2904d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151273
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-05-02  Vert D  <devoptmsoi@gmx.com>  [332b620732d4f78625c6547a988fa9860ab0d7bd]

        tdf#154884 fix isFavChar, updateFavCharacterList deletes the correct pair
        
        Change-Id: I98be8df93c5e3985e95f285e3cb9a2b600eb85c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151216
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0e5b5237d62422d152c4d54be5e5d2de2fa2f6e4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8526bfa2d6570e05906ab96b195dc1c773a734d7
          - tdf#147105 Fix inconsistencies in pdf param descriptions
            
            Change-Id: I30962fef0bf0ec88d24eb6df19207ba52ad51c15
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151234
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2023-05-02  Caolán McNamara  <caolanm@redhat.com>  [4ec8787b41fa366182cc97e165943d6af130f304]

        ofz#58551 Conditional jump or move depends on uninitialised value
        
        Change-Id: Iee5d82fff5edf14dd4f8adeabc305e96dd0ddd8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-02  Justin Luth  <justin.luth@collabora.com>  [6dfa1fc2fa9a7cdbbaf5ecd27528c95f744e0db4]

        tdf#86630 sw page number wizard: allow wizard to be re-run
        
        First delete what a previous run of the wizard inserted,
        then re-insert the page number.
        
        Change-Id: I1cbf1a7a40e71a13a06a174fd662eccfe8298e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151148
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [20b82690cdf58ae3ad9415d552fb924c51cdafd6]

        sc: extend conditional format range in test
        
        Change-Id: Ie857bc22f0340659612eb407975679953c538822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151259
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-05-02  Caolán McNamara  <caolanm@redhat.com>  [81e8cc7aa3d97ecc42f2592a2f6075f7f1ba74ff]

        ofz#58529 Null-dereference READ
        
        Change-Id: I9d8ea7d40429faee94889e4d2d9df7440b18e65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151255
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-02  Eike Rathke  <erack@redhat.com>  [d5565b70bc6d3d263e1cc50fa1f343f4e1a428fe]

        Resolves: tdf#154987 Add Santali {sat-IN} locale data
        
        Change-Id: I9da3003a4db91bfa432bb68edcf577b73df5ee2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150949
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-05-02  Aman Jha  <amanjha752001@gmail.com>  [53c641702a280be8b80976301f3427b41d2e0b74]

        tdf#114441 Convert sal_uLong to better integer types
        
        * Use tools::Long for nY as it stores calculations with result values
          that can be sometimes negative
        * Cast nLine to sal_uInt16 as rModulWindow.ToggleBreakPoint() takes
          parameter of type sal_uInt16
        
        Change-Id: Ibfdee40f37714406ee0f089c9a87f8b9a650e492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145210
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-05-02  Noel Grandin  <noelgrandin@gmail.com>  [dbcf188d39ff70ac87312dd28444df97e3cea993]

        remove unnecessary method
        
        the call to GetObjectItemSet() in
        OleProperties::ForceDefaultAttributes() is unnecessary, because
        it is always called before ForceDefaultAttributes is called, and
        having removed that, the rest of the method becomes unnecessary too.
        
        Change-Id: Ibb09020837d47cb9eb1fb8b5deca1defc1465108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151237
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Noel Grandin  <noelgrandin@gmail.com>  [7a1f2f0b9906228ce970d48fef29dd25cd4cc55b]

        use more specific class in sdr::table::Cell
        
        mpProperties always points at a CellProperties object.
        
        Change-Id: Ie78d015a23b48c5b40cbf3564974870e49a0b2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151239
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Miklos Vajna  <vmiklos@collabora.com>  [41e3d2c936f008d010a64c00904539eed2392551]

        sw: prefix members of SvXMLImport, SvXMLImportPropertyMapper, ...
        
        ... SvXMLNumFmtHelper and SvXMLNumFormatContext
        
        See tdf#94879 for motivation.
        
        Change-Id: I1942fae05f2df1f23e0b05f8cb0eaa1f6df73f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151252
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-05-02  Noel Grandin  <noelgrandin@collabora.co.uk>  [bcd233e45f1d793555e29522d1c30b67c574b628]

        improve windows backtrace_to_string
        
        I want to know the symbol address we actually capture, since
        we seem to getting duplicates in the output of SymFromAddr, I
        want to know if the fault is in SymFromAddr, or the backtrace
        capture call.
        
        Change-Id: Iece9c204abb780ae6b67a11e6ba77db816351e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151254
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Caolán McNamara  <caolanm@redhat.com>  [7e74f2260b7d093c1b3bb6e362de1c52b5068cc6]

        cid#1528432 Argument cannot be negative
        
        Change-Id: Ic55c524a9ec8ae9a4df7f96d284d822616fa3b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-05-02  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [24f938c016b62aa8f05e23e2be4f51e7ead51e65]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 03a891f1b00d9b1a14c6a72fb33cb682b549053a
          - Updated the English dictionaries: GB+ZA
            
            Change-Id: I82eb3829ab615d1b395effc8f149d1f0e5ccf12d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/151227
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2023-05-02  Paris Oplopoios  <paris.oplopoios@collabora.com>  [b42f3d450d861ecf7b8867ad2ad38537bf888888]

        Test tiled rendering view separation
        
        Make sure that changing the theme in one view doesn't change it in
        another view when doing tiled rendering
        
        Change-Id: I0a21dc36bfb825337fe74a11099ecc728b99c861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149324
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-05-02  Noel Grandin  <noelgrandin@gmail.com>  [ff307906ce794173e4f26dcad84518d010668ea3]

        elide temporary copy
        
        Change-Id: I3818767811ee92b39f475533144d0163a7e6931e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151236
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-05-02  Kohei Yoshida  <kohei@libreoffice.org>  [fb3a6b82b55a298eabf8f431f1451dc826642acd]

        Update mdds to 2.1.1
        
        Change-Id: I4f708faa5b0017e7852e3b085825b6637f6fa988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151244
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-05-01  Justin Luth  <justin.luth@collabora.com>  [b89f65a5138fe74b7858c2817fae4204b021c1f5]

        tdf#86630 sw page number wizard: add contextLabel
        
        What the user should see in the menu is "Page Number...",
        but the label itself is better named Page Number Wizard.
        This label is used to distinguish it from other Page Number
        items in Options - Customize.
        
        Thanks to Seth for pointing this out in comment 39.
        
        Change-Id: I9df14822f3fd69e4dec1d08a198da740479ab571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151240
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-05-01  Eike Rathke  <erack@redhat.com>  [595eda782296916ddfec5f6d15e9abc5c61667ee]

        Related: tdf#119659 Use ValidColRowOrReplicated() for matrix dimension check
        
        ... instead of only ValidColRowReplicated(), and check the return
        value. With this, the abort wouldn't had happened but an empty
        string returned for this case (which would had been wrong as well,
        but the caller has to check dimensions).
        
        Change-Id: I75218c479896893146b0e73d3c82215fe61cdf6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151235
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-05-01  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [1dc1595824509c58f86f819673719096f771f417]

        replace SwFrameFormats with sw::FrameFormats<SwFrameFormat*>
        
        - SwFrameFormats is now completely replaced by stronger typed
          sw::FrameFormats<>, thus remove it
        
        Change-Id: I7e655a83ba8cf01d1e68dccd1804c167e8daca9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150455
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a6aa71f6f3357f4fcd06c2307882733606af37ca]

        AutoName is only used as Any, no need to extract into intermediate string
        
        Change-Id: I00b0d647946e3943852098ff96cc09b7a2fd49ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151233
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-01  Mike Kaganski  <mike.kaganski@collabora.com>  [2059f242bd2d3e9cefa8cb38bcbef8cab120bab5]

        Simplify and unify a bit
        
        Change-Id: Ife4b4b3beb4d31948aebbb2028ef0683013a7b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151229
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-05-01  Hossein  <hossein@libreoffice.org>  [57f46a5a64f4e3bca2f0a52309ca7d201c1e2372]

        tdf#152246 Test position of RTL elements in PDF
        
        This test checks the position of RTL/LTR elements in the exported PDF
        files. Without the fix in place, the test fails because the RTL elements
        will position as LTR, and the "Rect" element will be something else:
        
        double equality assertion failed
        - Expected: 303.349
        - Actual  : 56.699
        - Delta   : 1e-06
        
        The Sample DOCX file contains both RTL and LTR content controls for testing.
        
        One may run the test with:
        
         make CPPUNIT_TEST_NAME=testTdf152246 -sr CppunitTest_vcl_pdfexport
        
        For an overview on PDF fill-in forms, please refer to:
        
        James C. King, Introduction to the Insides of PDF, pages 81-85
        https://www.adobe.com/technology/pdfs/presentations/KingPDFTutorial.pdf
        
        Change-Id: I6c15b49bffb1aef6f137f7bb518a291f4d88b888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151228
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [113c6d11afbfc97e17fe90d90dd55d149a33a191]

        docmodel: extract ColorDefinition into own file and rename
        
        ColorDefinition is renamed into ComplexColor.
        
        Change-Id: I81c2d97e6b7bf9de4ce703c02b6db40636b04961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151224
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a0a61ffc29cde98d32dcd3b8d71cc8c21cb6e493]

        docmodel: extract Transformation from ThemeColor into own file
        
        Change-Id: I45316e377cf895773037f500c521111f7e4d1ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151223
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-05-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [607b85b908d14f9907e12932bbc2298398f72ef0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e66412d1c72a51d6548c02baf8de9b4bbcfb92e
          - tdf#154940  update "Variable" label to "Custom"
            
            Change-Id: Ib03c304b6fca75a6e442c50f31accb697a1bd4ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151194
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-05-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7837c4c7bd25202fd010fbf7b7f5a13388d62007]

        tdf#154940 change label from "Variable" -> "Custom"
        
        Change-Id: I24db05dc26742513c1b6225d5c601ee19078ab87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151117
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d049a1439d7db9cc3c68bbec3b496a61e7a7b855]

        Use getXWeak in slideshow
        
        Change-Id: Ica0290ee46286ff6d82634c378e40b3605d48a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150869
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d4d994321464b1f0301c3cb86f55d851794d5f88]

        Use getXWeak in sax
        
        Change-Id: I24d61be2a1e1c21c08e50790b2d7bbb794c4fb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150862
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d74c010192a3d9605364bfb942f18c9199a75804]

        Use getXWeak in scripting
        
        Change-Id: I4370c0bfaa75b150bd05f03a5961e7152ac41e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150864
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0dcbf8a5a5048b30fce48081090a922d286a62e4]

        Use getXWeak in sot
        
        Change-Id: I68d6b7393b367b68206c92cd65705326c5aeda7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150870
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [bad7f6376f96a008c1b1a77d262953c13eb8442b]

        Use getXWeak in sfx2
        
        Change-Id: I364f13308adf8b3257e53da2bc6576088bb958f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150867
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [116adf5341c681e4044f9fe940d0d143eeabc457]

        Use getXWeak in sdext
        
        Change-Id: I24563de37b98cad57823fe936e5bfa7e10e8a2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150866
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Mike Kaganski  <mike.kaganski@collabora.com>  [f220acf3aad954e20f3b15b30910432fac97ed15]

        Use getXWeak in shell
        
        Change-Id: Ied9a244a0fdd5973f2c9cb3bdd46500f6be2e0cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150868
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-30  Julien Nabet  <serval2412@yahoo.fr>  [723a0a067daaefb8b082fc849713ee6502ec9231]

        Firebird: add info FDB/FBK use on README
        
        Thank you again Mike for this info!
        
        Change-Id: Iab02f486035de48636d84148a045e86b24307a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151218
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-30  Caolán McNamara  <caolanm@redhat.com>  [6377fe10964ebf1936e4a55f845e3f1eda5501ac]

        fix fuzzer build
        
        Change-Id: I9b980f3c81d468da4bcc33b6d27df9233f78c365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151219
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-30  Caolán McNamara  <caolanm@redhat.com>  [538956c32b867102b5174add3ea1990ae9d0b075]

        ofz#58400 Timeout
        
        Change-Id: I6ded0d0613b66f7ec075796e257d93cf25822d2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151189
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dd15364793401e41bae45cdeb410808c9f94fa93]

        adapt the new auto-fitting alg. to work for vertical text
        
        And remove the old auto-fitting algorithm now.
        
        Change-Id: I0bf26d57955018b6d43783d860a0aeae596439b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151183
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fd0515abfcd659610661dbf4375c51519b6fb157]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c02428dbc46618eb781bcbdeb816e20518a44e6c
          - tdf#152397 Fix Help page about Calc Input settings
            
            Change-Id: Ic7a92343279fb1321d4189cca32bad93e611c095
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151132
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [1df99a2155751a1874f45b57a637ee9ecc4dc110]

        Use getXWeak in avmedia
        
        Change-Id: I1dc1e597c50b0081375b9216ac4e6436b84aaa0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150832
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [32122e89310bd1d72aa796823965eadd766a84fc]

        Use getXWeak in accessibility
        
        Change-Id: Ifd6d57bb4087e6934075ff9f0931260cb8d09328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150830
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0a87d8fed89eacf74eec4dda9e7fb5ec19a32ed5]

        Introduce cppu::getXWeak and cppu::OWeakObject::getXWeak
        
        To avoid explicit static casts when XWeak or XInterface is needed
        
        Change-Id: I0496a5b8dcd48743bceeef9f90904811acd556cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150807
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [c97ddabb78b17fa8fb568fc7511aab82f0da63c4]

        Simplify a bit
        
        Change-Id: I201dc0c1b9438b53656802c20c181654ee758a5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [c395fc2ba51bf71bd70fcfa51c9fadb83ae24913]

        These are not applicable to FILEOPEN_SIMPLE
        
        Change-Id: Id2668a6b30f7062e42ec60b3664b9a7490feccd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151128
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [621a7ac49500a2f9e7381a6e4a79675bf8d1043d]

        Simplify a bit
        
        Change-Id: Idd17018c0fe452979f699d63f2166ae95241a3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151129
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Noel Grandin  <noelgrandin@gmail.com>  [6e0eb7da0601ab4bf828a0fa71bbad83b9e8f465]

        rename field in GroupProperties
        
        to distinguish it from the similarly named field in the
        DefaultProperties superclass.
        
        Change-Id: I8512c1a60e360a1e31ceaa86a8ff63ebe068d0cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-29  Caolán McNamara  <caolanm@redhat.com>  [2f1860199ace72973a0092493c5b1c6bc1a077be]

        reject fodt input that doesn't load and so doesn't exercise pdf export
        
        Change-Id: Ie8596618f62d245f35cb56e128c529464bc7cc25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-29  Caolán McNamara  <caolanm@redhat.com>  [6c3f27c794b90e2877edd72689d7d8284fecff00]

        add a fodt to pdf fuzzer
        
        Initially give it a fairly tiny input size limit.
        
        Change-Id: Iabc2611174e88f1f6050edb21da4f28694bac4a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151151
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-29  Eike Rathke  <erack@redhat.com>  [6b6b83b43fcae13e30a9ca67b421187a5e0d7142]

        Resolves: tdf#119659 Check found position for result vector
        
        Change-Id: Idc454462c47b6c7b7b7cb6c86b08650d059221c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151186
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0cda9cdba77bfe3c5f4b78f7538e2b6c96a01493]

        use XThemeColor instead of XInterface for *ThemeReference props
        
        Change-Id: I23b6a7429bbcf7901f3d817c970ee7ef4a453197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151184
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [5d56733bbc283f5927d83bc3151a05fc477c31b1]

        Simplify a bit
        
        Change-Id: I5b39a16479a69c0683d8e04497ad24421112751c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151126
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [90ac25f12cecd5850607096acf4d97f29baaa710]

        Simplify a bit
        
        Change-Id: Id768a3e10eb593af84bdea423ddfd090df33eef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151182
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [5f303eaaeac23813e9809c87bce406ea5c52ee14]

        tdf#155077: use the selected URL when writing languages
        
        Regression after commit 9a55b97e980bbf2a0ce12841f6168f1f7545ac96
        (tdf#40068 Remember last directory for basic/dialog import/export,
        2021-07-14).
        
        Change-Id: I6ddb88cbe8a08128c451169de7e9ed4597dc4356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151181
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [139e0fb7132cb7b943ea50930a8a7ede72ea5e47]

        tdf#45705 Define accelerators for zoom in/out
        
        This patch defines the shortcut Ctrl+Shift+PgUp/PgDown for zooming
        in and out.
        
        Change-Id: I2ba486de82952e3cc06b56e70a8cb157cdae0ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150212
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [876010cbc4584249e919c694b8b977fd4e83084e]

        Simplify strtmpl.hxx
        
        Replace bulky and difficult-to-read template argument names with
        clearer ones; remove excessive whitespaces; reorder to avoid forward
        declarations (these are remnants from the refactor from macros to
        templates, when I tried to keep the old structure as close to the
        original as possible).
        
        And also a small code simplification in doubleToString.
        
        Change-Id: I901cfb86daf410e85269538f36ebb6b553a4be76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151125
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fd99725abdeea92e8cd46bb3e8e6fdcad8180e8a]

        Prevent to get 0 font size in the auto-fitting algorithm
        
        When the text box is empty, the size of the box can be returned
        as (0,0) so the auto-fitting algorithm will calculate the scaling
        to 0%, which means the text is shrinked to very small size or is
        invisible.
        
        This change fixes the issue so that if the size is (0,0) we just
        return and leave the scaling at 100%.
        
        Change-Id: Ie359461f23a1f7a496eb03b5670f588ad48bbf49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151178
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a1acc2f46cc499631d66b1d7a923ed15ab4f28de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cac49fecf0b35af451fd0e043b21f86a8a46b38d
          - tdf#139027 More on INDEX() function
            
            + Review after erack comments
            
            Change-Id: Ibc294c35dd98cbd5c9f2b638db4e9cf31e768edd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151175
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2023-04-28  Michael Weghorn  <m.weghorn@posteo.de>  [4849c98eb44b62324293254c946de41668ecd494]

        qt a11y: Forward changes to active state
        
        Forwarding of a11y state change events had in general
        been implemented in
        
            commit 8c3e8af0e60865ec6d38e2117efdb4ed2f10a20c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Jun 17 17:29:19 2022 +0200
        
                qt a11y: Forward STATE_CHANGED event as such
        
        , but that commit explicitly did not yet enable forwarding
        of changes to the `active` state; quoting from the commit
        message:
        
        > For some reason, forwarding changes to state `AccessibleStateType::ACTIVE`
        > resulted in Orca becoming unresponsive (stop talking) quite quickly.
        > That needs further analysis, so that state change isn't forwarded
        > to Qt for now.
        
        I no longer see this problem on Debian testing with Orca 43.1-1,
        current LO master and qtbase dev branch as of commit
        589c6d066f84833a7c3dda1638037f4b2e91b7aa
        plus the pending Qt Gerrit change [1]
        ("a11y atspi: Implement TableCell methods Get{Column,Row}HeaderCells")
        in place. Without the latter qtbase change, I can observe
        Orca becoming unresponsive quite quickly when moving around in Calc
        after pressing Shift, which may be due to waiting for a timeout
        instead of receiving the proper reply to the AT-SPI methods
        that that Gerrit change implements. (S.a. QTBUG-113110 [2] for
        another scenario using a simple pyatspi script to trigger
        what is potentially the same underlying issue.)
        
        Therefore, drop the old workaround.
        
        With this LO and the Qt change in place, Orca announces the
        focused and selected cell(s) in Calc with the qt6 VCL
        plugin and these steps:
        
        1) start LO Calc with the qt6 VCL plugin
        2) press Shift and wait a few seconds
        3) move around using the arrow keys
        4) select cells using Shift + arrow keys
        
        Ideally, this should also work without step 2, but
        apparently that step currently somehow triggers something
        relevant (creation of relevant a11y objects and registration
        of their listeners?) that doesn't yet happen without step 2.
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/473907
        [2] https://bugreports.qt.io/browse/QTBUG-113110
        
        Change-Id: Icff8bbe7a6ee233407804c9098166945cdef4315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151176
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-28  Hossein  <hossein@libreoffice.org>  [8434b855434e17db99ebcd9c8c29f989677b3571]

        Add .cache (Qt Creator) and gdbtrace.log (gdb)
        
        Change-Id: I80ebe9270bcb895ea95d2fd679417dd4f2b22165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151047
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-28  Radhey Parekh  <radhey.parekh@gmail.com>  [f43c365fdddfaa6095c5392e3044914ad1054652]

        tdf#145538 Use range based for loops
        
        Change-Id: I6a393526d96fc5c7bee88fc03fc254dbdbe975cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138157
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-28  Caolán McNamara  <caolanm@redhat.com>  [2b7773ebb8e8e1662adc4f90ae90f4f746254169]

        survive exporting to pdf without config for fuzzing
        
        Change-Id: I229f25a8a15b21257756ecfa008b9e99681003c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f701edb6f72e50fae5857a81081d3503e5363b8f]

        fix type checks of raw SdrObject's in writer
        
        Which are no longer possible since SdrObject is abstract now.
        
        I assume the original code was gunning for the kind of objects that
        were being created before
        
            commit 24a374ebc9da56cc6721e8feaa1e15ba850bf41d
            tdf#154040 use a SdrObjKind::NewFrame for frame creation in writer
            Instead of (ab)using SdrObjKind::NONE for the temporary, empty
        
        Since that is only explanation that makes sense
        
        Change-Id: I0c3a26cc303ab7d54193beacb285c69aaf98a63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151170
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ab38a26bf4a6d37da6c03f7fdb999d0cacf2e63]

        Revert "remove dead code in SwDrawModellListener_Impl::Notify"
        
        This reverts commit e8c265d06a9f34fec382d67c65c38189f16ee323.
        
        Reason for revert: I misunderstood how the isType is working here
        
        Change-Id: Ic4fcedd02affa6df58b74b4cad231cfdf6288592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a9cea0ddeb5cd51db0720f96af75af75120908d9]

        tdf#90496 - Remember last used view in hyperlink dialog
        
        Change-Id: I500e9e58c84486307c50f4ccb878ad0340412246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151039
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [71a27a57898c578e6b27d7f4343736c393cef3cd]

        Fix typo
        
        Change-Id: I20d3d5120c35d34d52b463ff7d8de74a4b8b02f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151158
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-04-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c935e127a3b1a2d4cebec471b807126ad297ec5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8a6e326f6207982fd507161d48f7793cfe82c26
          - Refactor page - no change in contents
            
            Change-Id: I5686fda46a1e572a6156b125f6dc9d11416af4d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151174
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6523c7a6436f3a7ea189c4e77898d754bf703e49]

        Revert "remove dead code in SwDoc::CloneSdrObj"
        
        This reverts commit 23046111d01ab0ec5feb570d428aea5ed4ece5fc.
        
        Reason for revert: I misunderstood how sw::isType is working here
        
        Change-Id: Ib5eac520f4ed79dbe1d6088a44e17b2b2a129877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Mike Kaganski  <mike.kaganski@collabora.com>  [424bdeda9fea09f0b48b5551baf872656845c7c3]

        Move all handling of AA allowing from svt to drawinglayer
        
        Commit 444bf8710d5da7b584fbcb94693e4ed8d2e29297 (Update handling of
        AntiAliasing settings and processor2d, 2022-11-08) moved the actual
        variable holding the AA state to drawinglayer, which introduced a
        duplication of the information.
        
        This moves all the handling from svt to drawinglayer, so that svt
        functions only use respective drawinglayer functions. Well, almost:
        the IsAAPossibleOnThisSystem function needs vcl, so stays in svt.
        
        Change-Id: I887307fbca1ca0cff1f5f32446e3599817099c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151163
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-28  Heiko Tietze  <tietze.heiko@gmail.com>  [a2756bf71a304f2bb1bf49753dfd37a3402bc463]

        Resolves tdf#153499 - Hide newly introduced frame label
        
        Frame content is not shown for existing entries
        Follow-up to 4ec75d22eb916e3809e9e92f77fd25e33f6b21ee
        
        Change-Id: Ic2b40b19424245ede326a5ef5b53f684ca8a3f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151166
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-28  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [6fab79859ec97a9153e033fe00fd01e4e46620ce]

        Revert "Revert "introduce sw::SpzFrameFormat ...""
        
        apparently, in SwHistoryChangeFlyAnchor::SetInDoc, m_rFormat might
        actually reference a DrawFormat, not a FlyFormat, and that is likely
        fundamentally broken. But for now, lets just make m_rFormat a
        sw::SpzFrameFormat -- this already removes some pointless up and
        downcasting.
        
        This reverts commit 52acefd6024ec79f8333ba40eef83816eda3046f.
        
        Change-Id: I040d98548bf9ac1c25b93214224eb0812f8cb653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151150
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-04-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [10f289477971fe27a5062f02fbb07a44c79e2778]

        Capitalize "Display tracked changes" string to match others
        
        Change-Id: I012871296dcf8b3d27003c681b4fa2179bb0f943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151165
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e55c5dd7b72c7da54a38ea4dcfc17069f311b0f]

        tdf#155046: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: If0e64b6b4be769a485153465404370316d3f6587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151162
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dcb8f373d7bcd328e69e0bea85b76874923ce0dd]

        disable dbl-click in ThemeDialog in LOK, remove the dialog size
        
        The double click in THemeDialog exits the dialog automatically,
        but this causes a crash in online, so disable it there.
        
        No need to set the theme dialog size to a certain fixed value so
        we don't add white space.
        
        Change-Id: I555a631b7d0c515ec326c3654138982c59d3f021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151106
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-28  Justin Luth  <justin.luth@collabora.com>  [511505f0ca11632be19b5923791c39d65c994673]

        tdf#86630 sw page number wizard: mirror margins as well
        
        This is only done in a very specific situation,
        when no heading/footer is defined at all.
        If we turn on mirroring at this point,
        then be helpful and mirror the margins as well.
        
        By default, this is irrelevant because the margins are identical.
        
        It isn't necessary for page numbering,
        but I think it is a nice touch to add something
        that most people wouldn't find otherwise.
        If they really want mirrorred page numbers,
        then it is highly likely they also want mirrored margins.
        
        Helping out people is the whole point of wizards after all.
        
        Change-Id: I20cde65dc95ea3115951a4ea3a01534399f19f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151153
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [23046111d01ab0ec5feb570d428aea5ed4ece5fc]

        remove dead code in SwDoc::CloneSdrObj
        
        Dead because
            isType<SdrObject>(pObj.get()
        is unconditionally true, which renders the entire if statement dead.
        
        Ever since it was introduced in
        
            commit 68428bf17441dc0ec9dfcffd7cc6073660e552f0
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Fri Jul 4 12:19:41 2003 +0000
            INTEGRATION: CWS aig02 (1.12.32); FILE MERGED
        2003/07/03 13:29:21 od 1.12.32.4: #108784# further adjustments for
        support of drawing objects in header/footer
        <SwDoc::CopyLayoutFmt(..)> - do *not* connect draw frame
        format to
                     layout, if its corresponding <MakeFrms> will not be called.
        2003/07/02 16:04:01 od 1.12.32.3: #108784# - consider 'invisible'
        layer at drawing page for support of
                       drawing objects in header/footer
        2003/06/26 18:17:53 od 1.12.32.2: #108784# - further adjustments for
        support of drawing objects in header/footer
        2003/06/26 17:02:11 dvo 1.12.32.1: #108784# copy shapes (but not
        controls) into header/footers
        
        Change-Id: Idca3d73ac5b790f93e56214ce1aaa3e99a173a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [08c09017bfa5c72ba2b9614237fcf0c0f9738037]

        fix regression in "tdf#119388 add new UNO listener/broadcaster"
        
        Upon further inspection, I note that part
        of the the code I added in
        
            commit ec940941e0bd7db15c5cf7d43df82226e0d849dc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Aug 20 17:03:13 2019 +0200
            tdf#119388 add new UNO listener/broadcaster
        
        would never have been able to be hit. Re-arrange a little to fix that.
        
        Change-Id: I537102d768591e5fa0ec2fb4b52b05dad4d26f29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8c265d06a9f34fec382d67c65c38189f16ee323]

        remove dead code in SwDrawModellListener_Impl::Notify
        
        The
            isType<SdrObject>(pSdrHint->GetObject()) ) )
        code has always been unconditionally true, because SdrHint has always
        returned an SdrObject,
        
        ever since it was introduced in
        
            commit 12b8488b9cf659adcafd4b998227397c57cf51ba
            Author: Vladimir Glazounov <vg@openoffice.org>
            Date:   Wed Jul 9 08:16:20 2003 +0000
            INTEGRATION: CWS sw020 (1.44.80); FILE MERGED
        2003/07/01 11:50:20 od 1.44.80.1: #110554#
        <SwDrawModellListener_Impl::Notify(..)> - correction: no broadcast
        of notifications for writer fly frames and plane
        <SdrObject>-objects.
        
        Change-Id: I67e6576f0670856259edee35aaf001401e67d98d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [ca45f6efc2e9250daee8e94f8408fe4abba4a7ba]

        msicreator: fix hardcoded wix toolset path
        
        On a Windows Server, the following installation procedure has the
        toolset end up below the x86 program dir:
        
         * % powershell Install-WindowsFeature Net-Framework-Core
         * % choco install -y wixtoolset
        
        Change-Id: I5e416cd24f51ae84cb0e6ef99b8a962355fb2b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150828
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-04-28  Miklos Vajna  <vmiklos@collabora.com>  [1795d5183d5371a24e8dcb15f8671c78b2c94665]

        sw floattable, crashtesting: fix PDF export of tdf114111-3.docx
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        The stripped down document has 3 tables: a toplevel, a middle and an
        inner one. The middle one is floating. SwFrame::GetNextFlyLeaf() doesn't
        support nested tables, so we move an inner table frame to a next page,
        causing a frame to have the in-table flag, without a table frame parent,
        leading to a crash.
        
        Fix the problem by just disabling floating tables for nested tables for
        now.
        
        It can be enabled later, and not supporting inner floating tables was
        the intent of 8818dd359fbf0f37e1b318de89ab2ea7d735f58 (sw floattable:
        fix handling of nested non-floating tables at cell start, 2023-03-20)
        anyway.
        
        Change-Id: I75db01c6c0fdd803130fbb2a8f2f90c6180051ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151155
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea5c846fd5630acef26a3ee96d47c4a43fb5c24d]

        tdf#155028 Crash in: `anonymous namespace'::lcl_PasteFlyOrDrawFormat
        
        since
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        The CloneSdrObj() call needs to return a rtl::Reference or the
        created object might get destroyed before we return a (now stale)
        pointer to it.
        
        Change-Id: I3de46b025887e6d460860b37677d2b18b90fb3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Noel Grandin  <noelgrandin@gmail.com>  [601db233f5cc7ee8bcd948681345fa37d5bb1d84]

        remove dodgy code in OReadToolBoxDocumentHandler
        
        comparing hashcodes without doing an actual comparison
        is not safe.
        Code was like this since
            commit 6845330a228f7b516425e2dcb0aa5f2cdfaedc85
            Author: Carsten Driesner <cd@openoffice.org>
            Date:   Wed Oct 17 09:57:37 2001 +0000
            #87255# support toolbar item style and help id
        
        Change-Id: Ie49647da257e6199d9502c916da2dd3d39d52377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Noel Grandin  <noelgrandin@gmail.com>  [a33922e38b87db5b009986324c6543e90f18a752]

        optimise find/insert calls to maps
        
        Instead of doing two lookups, we can just call insert and
        then update the mapped-to value if the insert actually succeeded.
        
        Change-Id: I3df3b98f0debe6bf74c739dd5850e7714d9c2789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-28  Stephan Bergmann  <sbergman@redhat.com>  [2eb3922750b385dcadfd124d7baf686cec40eb5e]

        Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* impls
        
        Ever since 95823ae83c8c13c5c10c5084e2a90549ff2eb25e "#95565#add new phonetic
        entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
        (alphanumeric first)" was using the same implementation as
        "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
        by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
        (alphanumeric last)" was using the same implementation as
        "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped
        by syllable)".  But there appears to be no evidence that those implementation
        names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"
        and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic  (alphanumeric last)" are
        actually used anywhere (see also c9b6bf655e6de50c55629b4805399932c90a3b30 "Add
        some tests for (Japanese) i18n::IndexEntrySupplier behavior").
        
        And a problem with the current setup is that instantiation those two
        implementation names will return implementations whose getImplementationName()
        does not match those implementation names (but rather returns
        "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
        by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
        (alphanumeric last) (grouped by syllable)", resp.)---which is something that
        would create failures with an improved CppunitTest_services.
        
        Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-28  Justin Luth  <justin.luth@collabora.com>  [21fad629e72791f6cc1791fdba858bf52b9bfeff]

        tdf#86630 sw page number wizard: mirror right/left
        
        If the user puts the page numbers on the left or right
        side of the page, they usually want that mirrored
        on even and odd pages.
        
        This got rather tricky, but in the end
        I have enough safeguards that it seems
        to work logically and stablely.
        So I think it is ready to be submitted.
        
        Change-Id: I321e575cd9f6718579ffee99f1258bffe26581f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151152
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-28  Justin Luth  <justin.luth@collabora.com>  [d4cf5814146e375805df98eafba2baf321b9b005]

        tdf#86630 sw page number wizard: cleanup numbering type patch
        
        Much nicer to use things have have references
        for guaranteed items.
        
        I didn't notice the previous use of this
        as I was copy/pasting my patch together from various sources.
        
        Change-Id: I47f44a12fba4fc30db0597bcdcb339c062bc8b78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151149
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-28  Justin Luth  <justin.luth@collabora.com>  [a3a758350e92a3084d2cbef05ca6caef899746a4]

        tdf#86630 sw page number wizard: only turn on current page footer
        
        Without specifying the name of the page style,
        all in-use page styles were having the header or footer enabled.
        That was not the intent.
        
        Change-Id: I5eadd73cb2d7e11b6a003826b5698e22df3f13c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151133
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-28  Justin Luth  <jluth@mail.com>  [1770d3ba3313f2166153d39be6ae1212c00da6d8]

        tdf#155034 Revert "Update libxmlsec to 1.3.0"
        
        This reverts commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b.
        
        Reason for revert: compiled version fails open/create some documents
        on Ubuntu 20.04, which is still an Ubuntu-supported release.
        Also fails to compile on 20.04 with built-in system NSS
        
        The clinching reason is for running bibisects.
        There was no compelling reason to make the change,
        just routine maintenance. So if something breaks
        or is annoying when doing routine maintenance, then revert it.
        
        The previous version is still 1.2.37, released in Nov 2022.
        So this will likely come up again relatively soon
        if there is a security fix required.
        But at least at the end of the 7.6 development cycle,
        we can avoid the pain.
        
        Change-Id: Ife387d6e4058b017ba18cba1fbcb2b2d50f52c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151118
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-28  Miklos Vajna  <vmiklos@collabora.com>  [10cf767884de2c465304ef4b617d924e2d13630f]

        sw layout xml dump: extract SwBodyFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about body frames.
        
        Change-Id: Ieddbf592b8e7a5597b0de91a4acffa8abe2f2868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151143
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-28  Mike Kaganski  <mike.kaganski@collabora.com>  [1b85a555d3ee618b542dce414687c97f934b8b56]

        tdf#155048: forward AntiAliasing to drawinglayer also in temporary case
        
        Commit 444bf8710d5da7b584fbcb94693e4ed8d2e29297 (Update handling of
        AntiAliasing settings and processor2d, 2022-11-08) made respective
        changes so that SvtOptionsDrawinglayer::SetAntiAliasing forwards the
        setting to drawinglayer. However, it only happened in non-temporary
        case, which is fixed now.
        
        Change-Id: I66f5630dde759e3a3aa305ef38f60c8e24e6330e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151109
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-28  nirnay  <nirnaykorde@gmail.com>  [afe99617707c92460e66486c0057ef327e8aa017]

        tdf#43369: Specific UI for collecting PostgreSQL connection settings
        
        strings.hrc is used to add the text visible in the GUI and hence
        coressponding strings have been defined for postgres GUI.
        
        dsntypes.cxx since a new GUI page has been created for postgres
        a new page routing has been inserted instead of it going to default
        Since oracle jdbc and mysql jdbc have almost the same GUI the
        oracle jdbc was used as reference since there is no middle page between
        the target GUI page, unlike in mysql jdbc.
        
        dsntypes.hxx corressponding page id has been added for postgres
        for routing.
        
        dbadmin.cxx new default postgres port id has been added added just
        like MySQL and defined like all.
        dsitems.hxx contains the DSID used dbadmin.cxx
        
        dbwizsetup.cxx this where the GUI page is being called for generation
        dbwizsetup.hxx holds the title page string
        
        UIConfig_dbaccess.mk includes the new postgres page
        postgrespage.ui is the UI page where the GUI part has been refered from
        specialjdbcconnectionpage.ui and the connection string has been taken from
        dbwizconnectionpage.ui instead of adding a label and edit option
        so that connection string prefix is handled in the GUI with pre-existing
        curledit.cxx
        
        DBSetupConnectionPage.hxx holds the declaration of all the functions called
        in the coressponding cxx file. The declaration is a mix of OGeneralSpecialJDBCConnectionPageSetup
        class from where the GUI is being handled and since there is no test connection from postgres  the
        test driver has not been implemented, OConnectionTabPageSetup  from which commit page has been
        inspired and OConnectionHelper is used to handle the connectionstring just like in the original
        class minus the file based system implementation.
        
        DbAdminminImpl.cxx is where the data is retrevied from GUI and and pasted at the back of the connection
        string which is now a usual postgres connection string.
        
        dbaccess.suppr the supression has been added for gtklabel of postgres which have no corresponding
        entry widget.
        
        Change-Id: Id60fd02a56b10c1cb9b09c9302c6ddf170be8493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150546
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2e57755f72907e4bb604a8ba32edbd6c253ee57c]

        Update git submodules
        
        * Update translations from branch 'master'
          to bb3db75014e836ce6af4573bb8576c575a620efe
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I84abc5c49dc5bf2d198feb58356298e6fb2d1a96
            
2023-04-27  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [b79a5cdcf0b98fef4b5bfeb380efcea322e9a51a]

        EMF+ tdf#103859 Optimize EmfPlusFillRects and EmfPlusDrawRects
        
        Change-Id: Iac96cf2d4291646fb69cc87c471d2f68ed905d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151102
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-04-27  Caolán McNamara  <caolanm@redhat.com>  [bcccaf2322a7bd6ac4204ff48f623517a273922a]

        add something for fodt to pdf
        
        Change-Id: Ia2dd8a4d5c6e558ebea6c170a0b01b5f361e1d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151135
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-27  Caolán McNamara  <caolanm@redhat.com>  [dfd1a83a42791973ff8db36960089e2a00c36e99]

        avoid config when fuzzing
        
        Change-Id: If7778a7799db8d14c990a398166358b084da48d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151134
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-27  Julien Nabet  <serval2412@yahoo.fr>  [647747009aa5d48dd986334709425dfddbb7031f]

        Renumbering comments in include/svx/svddef.hxx
        
        + some reformating
        
        Change-Id: Ic72bbe5d0c714ebbeb14db54ebd0f0ab672b66b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151035
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-27  Julien Nabet  <serval2412@yahoo.fr>  [1f36f5dedf8d313e6f29bb1fcf8ac6744624952d]

        0 is ok for ParaTabStopDefaultDistance
        
        since introduction of ParaTabStopDefaultDistance cced51a1ed7c140276aabfe857510afb974fcef5
        tdf#102261: introduce editeng paragraph tab stop default distance
        
        Adds mnDefaultDistance to SvxTabStopItem that if defined
        will set a paragraph wide tab stop default distance and
        override the document wide setting.
        
        Also makes editeng consider mnDefaultDistance while getting
        tab stop default distance.
        
        The goal is to avoid:
        warn:xmloff:580503:580503:xmloff/source/core/xmlerror.cxx:163: An error or a warning has occurred during XML import/export!
        Error-Id: 0x20040001
            Flags: 2 ERROR
            Class: 4 API
            Number: 1
        Parameters:
            0: ParaTabStopDefaultDistance
        Exception-Message: at /home/julien/lo/libreoffice/svx/source/unodraw/unopool.cxx:190
        Position:
            Public Identifier:
            System Identifier:
            Row, Column: 2,12943
        
        To reproduce this:
        Open a new Writer document.
        Go to Form → Text Box.
        Draw a text box.
        Right mouse click on the box → Control properties.
        General → Border Color: Set to something like "Green" (not: Default).
        Save the file and close the file.
        Reopen the file
        
        (from https://bugs.documentfoundation.org/show_bug.cgi?id=155029
        Form control: Border color of Text controls won't be saved)
        
        Change-Id: I8252b1f0c4633a1588edbdc682c6faa48f6b25cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151070
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [233057d98258e9dee7cc50d86f26c1d681df5ba1]

        Fix typo
        
        Change-Id: If5a1b306db1a3abd49ed9a554fbff3f5dfa72771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151130
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-27  Tünde Tóth  <toth.tunde@nisz.hu>  [b88d11ba05085002cf847d4828ded52a3dfb3b09]

        tdf#152577 sc DBData: fix regression of database ranges
        
        Regression from commit 0c0444c44107f1a18f23dd0833d462d8dbf56569
        "tdf#126926 sc DBData: delete the database range".
        
        Change-Id: I04923decdc768770f98763e60cd295400d15c769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151065
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-27  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [fd79c5ed9b13516bdb0f2a29806296698ddda7b2]

        tdf#131722 DOCX import: fix lost first character in date selector
        
        Fix another date selector control bug, date picker first character
        goes out of the control. The first character of the date separator
        in the first row of the table is out of control. The fix takes into
        account the placement of the dummy paragraph in the first row of
        the table, which caused the date separator to be corrupted.
        
        Thanks to Gabor Kelemen for pointing out this error to me.
        
        Follow-up to commit e898f95bfab16ddd9b04e516293cb6eb7e0a3847
        "tdf#138093 DOCX import: fix broken date selector control in table".
        
        Change-Id: I91d272b786a3d3dc047334c2a4a039f987c94ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151087
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-27  Eike Rathke  <erack@redhat.com>  [e59fdc8b800aa3ab551b3f4fec4bc58366df582e]

        Resolves: tdf#155046 Accept true and false as 1 and 0 for OOXML boolean cells
        
        Encountered in the wild written by
        https://www.npmjs.com/package/excel4node
        https://github.com/advisr-io/excel4node/blob/c14213abb9a511ff786c574e473f53006a85e4f9/source/lib/cell/cell.js#L74
        
        Change-Id: Ib21242a55f0d8530fd9120b07a096a9908f451bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151101
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-27  Caolán McNamara  <caolanm@redhat.com>  [bb28a0e8b914edf1fe2aac0cd1a876b976f61300]

        cid#1528189 Uninitialized pointer field
        
        Change-Id: I9c66ee7d147cf9082b9f065601a87ef5d2fc01d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [40950c2f77e2baad49ef0ab4f4cb08cd81c457d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5695f2974d5cf32f9832502bd93602672cdc7eaf
          - Refactor Help page - no change in contents
            
            Change-Id: Idaa37fd11e570350a1ff27e8283ebfdf15c1a157
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151131
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-27  Caolán McNamara  <caolanm@redhat.com>  [0b35b7953507491fe1ebdead9ac6ce592bd9b674]

        cid#1528191 Uninitialized scalar field
        
        Change-Id: I0d57f541fb110af295db6b56c32e7ee32168b463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-27  Caolán McNamara  <caolanm@redhat.com>  [b9f78bec3558937d45b3a9d730c1c9d40a9c58d6]

        ofz#58380 Integer-overflow
        
        Change-Id: I88155f7f2abf42a11376d6f54aab28c233cf7e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [9c514228132096f297379172687b49a57b9f3058]

        Simplify DocumentLinksAdministrationManager
        
        And fix a case of string view pointing to a released string in SelectServerObj
        after commit 5200a73627d13e2997f81b53f61e143e77e328ee (use more string_view in
        various, 2022-05-01). The lowercase string is unused.
        
        Change-Id: I0ec29ba59b16c8970d69adcfefec1d6ba6537f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151113
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-27  Michael Stahl  <michael.stahl@allotropia.de>  [ed4d4d47ea322236199b1f8ff97ddd945b099cbe]

        tdf#151715 sfx2: do not use FORCERELOAD for document stored in /tmp
        
        This does not fix the actual bug, but is a workaround for a bug
        somewhere in the Notebookbar code that was exposed by commit
        5b5fb5e9c0580ecb70cf65882865bdaf16498fa5 "sfx2: do reload on SID_EDITDOC
        in SfxViewFrame::ExecReload_Impl()".
        
        For an ODF file, the Notebookbar is switched to editable by the call to
        SetReadOnlyUI() from ReadOnlyUIGuard, but the XLS file takes a different
        path and SetReadOnlyUI() is called in line 819.
        
        Here the SfxViewFrame is not yet connected to the SfxObjectShell so
        unsurprisingly it does not affect the UI; more surprising is that moving
        the call to around line 859 leads to the SfxHintId::ModeChanged event
        being handled in SfxViewFrame::Notify() with lots of things invalidated,
        but the NotebookBar is entirely unimpressed by that.
        
        Change-Id: I16f321bb3444eeae76348e20816af02938c3f46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151089
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-27  Baole Fang  <baole.fang@gmail.com>  [a772976f047882918d5386a3ef9226c4aa2aa118]

        tdf#145925: Add DOI recognition
        
        Detect DOI string in the form of "doi:10.*" and add hyperlink to it.
        It works the same way as url recognition.
        
        Change-Id: I3c4e78a110fd81ad7e727d5e9acee7e51127466a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150954
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-27  Heiko Tietze  <tietze.heiko@gmail.com>  [ec90dae4993b90e0c3a797ac9b43a076527e1a7d]

        Resolves tdf#155039 - Color name not displayed with GTK3
        
        Change-Id: I317a935c1e99c20f09cba8c24085d3a173d64dbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151090
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-27  Heiko Tietze  <tietze.heiko@gmail.com>  [d4d0921db42ef2cb0bf691b408da78f36ac4af88]

        Resolves tdf#155038 - Application Color is disabled with GTK3
        
        Change-Id: If820e765f3477f4b5ec8609f2781f8f0ed06cd09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151093
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [e5498d5323b2e9f1c4760d780a1a5542fbe9a4b9]

        tdf#151958: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I43413ecb2ddf49676e7e446c6cdd1d4bfea7d8e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151088
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-27  Miklos Vajna  <vmiklos@collabora.com>  [4b6b9411e4ac912817dd804782ad2054bc0d1660]

        sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 4
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        Part 1 already fixed the crash and parts 2-3 already improved the layout
        partially, towards avoiding a layout loop. The top problem now seems to
        be that page breaks before floating tables are ignored, which leads to a
        layout situation that loops. This problem was hidden before, since page
        breaks were not ignored.
        
        Fix the problem at DOCX import time: if there is a "break before" on the
        table, then transfer that to the anchor paragraph, which gives the
        correct layout, and also side-steps the above described layout loop.
        
        We should probably never call SwTextFrame::JoinFrame() when creating the
        initial layout for a document, that part is still unfixed, but that
        looks like a pre-existing problem.
        
        Change-Id: I1e2ecdbf0a3d4e2477cd4768a9b4a35a155e815b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151082
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-27  Jaume Pujantell  <jaume.pujantell@collabora.com>  [2fe581d916b76d613742c983731fb4a10b4ee95f]

        fix bug in json_writer
        
        Ruler stores null-terminated strings in fixed length char arrays, so when creating a JSON
        a string might end earlier that it's size sugsests.
        
        Change-Id: Icdcaf35f9ce54c24dcd36368dc49bb688a2a65ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150542
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2023-04-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f62b1e17def7bc3881c7426229eabbaeb4cb5037]

        Fix typo
        
        Change-Id: I8ae43a371b925773e02e23631f18b74fd7bf366f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151092
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [89afe2978500233dc7b58d39cc519ecb9c224e98]

        tdf#154818 - Find bar: remember and reuse last search string
        
        If there exists no last search string in the view options and there
        exists a search history, preselect the last search item.
        
        Change-Id: Ic6056e02eaf6c0ee7e266e47ba961dff11e9f9da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151072
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e4410284c9907c5c8938a4f54bdde22cf27bba56]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a53384ca39c4423a4562583373eaaabc20e6763e
          - tdf#154717  improve notes about number format; simplify "refer to"
            
               also move "Chapter" format to correspond to position in UI.
            
            Change-Id: Idf76a27c42dc8fa1ba9ee36f80faf2ef36769b51
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150512
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-27  Dennis Francis  <dennisfrancis.in@gmail.com>  [53279b8bc210485471f9550ebbc5ad09adefa4c0]

        add @since for COMPACT_LAYOUT
        
        Change-Id: I4b7f918e846ea1d220b9df2be5bc0b39d1f22f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151086
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0f83cbe27b95d991ce171a961950645a1ef67d7a]

        Avoid temporary OUString creation
        
        Change-Id: I1cebcc2cbd36ed83d4898e222929c872f46c08d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151028
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-27  Stephan Bergmann  <sbergman@redhat.com>  [52acefd6024ec79f8333ba40eef83816eda3046f]

        Revert "introduce sw::SpzFrameFormat ..."
        
        This reverts commit 09cdcb5f37bb4e42da7b28db6e757b9f2affed14.  It  broke at
        least CppunitTest_sw_uiwriter3
        (<https://ci.libreoffice.org//job/lo_ubsan/2756/>),
        
        > /sw/source/core/undo/rolbck.cxx:938:46: runtime error: downcast of address 0x61300041fd00 which does not point to an object of type 'SwFlyFrameFormat'
        > 0x61300041fd00: note: object is of type 'SwDrawFrameFormat'
        >  00 00 00 00  70 83 cf 09 25 7f 00 00  00 83 47 00 30 61 00 00  40 e5 43 00 30 61 00 00  80 66 5d 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwDrawFrameFormat'
        >     #0 0x7f24fca9c5b9 in SwHistoryChangeFlyAnchor::SetInDoc(SwDoc*, bool) /sw/source/core/undo/rolbck.cxx:938:46
        >     #1 0x7f24fca880f3 in SwHistory::Rollback(SwDoc*, unsigned short) /sw/source/core/undo/rolbck.cxx:1208:15
        >     #2 0x7f24fcb47832 in SwUndoDelete::UndoImpl(sw::UndoRedoContext&) /sw/source/core/undo/undel.cxx:1031:33
        >     #3 0x7f24fcb703c2 in SwUndo::UndoWithContext(SfxUndoContext&) /sw/source/core/undo/undobj.cxx:225:5
        >     #4 0x7f2543b8b57c in SfxUndoManager::ImplUndo(SfxUndoContext*) /svl/source/undo/undo.cxx:712:22
        >     #5 0x7f2543b8c4f8 in SfxUndoManager::UndoWithContext(SfxUndoContext&) /svl/source/undo/undo.cxx:664:12
        >     #6 0x7f24fca6a074 in sw::UndoManager::impl_DoUndoRedo(sw::UndoManager::UndoOrRedoType, unsigned long) /sw/source/core/undo/docundo.cxx:696:32
        >     #7 0x7f24fca6b38f in sw::UndoManager::UndoWithOffset(unsigned long) /sw/source/core/undo/docundo.cxx:731:16
        >     #8 0x7f24fa830b18 in SwEditShell::Undo(unsigned short, unsigned short) /sw/source/core/edit/edundo.cxx:141:57
        >     #9 0x7f250088f448 in SwWrtShell::Do(SwWrtShell::DoType, unsigned short, unsigned short) /sw/source/uibase/wrtsh/wrtundo.cxx:45:26
        >     #10 0x7f24ff7f16e2 in SwBaseShell::ExecUndo(SfxRequest&) /sw/source/uibase/shells/basesh.cxx:651:27
        >     #11 0x7f24ff7eea14 in SfxStubSwBaseShellExecUndo(SfxShell*, SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:2203:1
        >     #12 0x7f2523fbc059 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9
        >     #13 0x7f2523fd1ced in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
        >     #14 0x7f2523f61333 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1060:22
        >     #15 0x7f252437496b in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:688:53
        >     #16 0x7f2524377211 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:266:16
        >     #17 0x7f24cad28dd6 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:163:30
        >     #18 0x7f24cad27cb2 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:120:16
        >     #19 0x7f24cad29684 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
        >     #20 0x7f24e91d386d in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:94:33
        >     #21 0x7f25319b2012 in testTdf132321::TestBody() /sw/qa/extras/uiwriter/uiwriter3.cxx:982:5
        
        Change-Id: Ibeb181bc38cd6f88df76403cca8a15b45090633f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151027
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-27  Dennis Francis  <dennis.francis@collabora.com>  [2f8d10b0b9baa03b8a713e9fd1342fe6c8094fb4]

        sc: pivot table compact layout
        
        This implements compact layout for pivot tables. In ooxml each row field
        can have a compact layout setting. Support for any such "mixed" layout
        of tabular/outline/compact per field is also implemented. This also
        implements expand/collpse toggle buttons to field labels to make pivot
        tables with compact layout more usable. Such buttons are also available
        if other layouts are used.
        
        Conflicts:
        	sc/qa/unit/pivottable_filters_test.cxx
        	sc/source/ui/cctrl/checklistmenu.cxx
        	sc/source/ui/inc/checklistmenu.hxx
        
        Change-Id: Ieaa1f3bd282ebdec804d0b45a0af7b3d95a2027f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151057
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2023-04-27  Paris Oplopoios  <paris.oplopoios@collabora.com>  [292f422c421336c43bafe5ee048832137d617436]

        Extend tiled rendering test to account for dark mode
        
        Made testGetViewRenderState test for change from light mode to dark mode
        
        Change-Id: Ia02e7a462e595671492405733f25c0bbb3c24080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151046
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-27  Miklos Vajna  <vmiklos@collabora.com>  [014b481326f98ff9202f7c1fa9a9e2ee91c56355]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOleImg
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I5726642d932a495ff2158d3a0ed9c242a5c13278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151073
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [59036776b92c0f4ad2edd1bafd332f7a4ee87cdc]

        tdf#136749 no need to use maMutex in SwAccessibleMap
        
        we already need to be running under the SolarMutex, so just use that.
        
        Shaves some 5% off time here.
        
        Change-Id: Ife13f44d2e52171638bebcee946f5a1f07248cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-27  Jim Raykowski  <raykowj@gmail.com>  [2ff85183b959c05134a2737d6d14afd1882f2ba3]

        tdf#38194 Use a hashed string HSL color approach
        
        for style name color creation
        
        New magic for style name color creation.
        
        Change-Id: Ia6eec2dcf04fc2c3c38276bf6eaed73598505947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151079
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-27  Tor Lillqvist  <tml@collabora.com>  [0340cbbc34d2c97baa5b7ebc4a57650861907067]

        Bin the unused paintTileToCGContext special thing for iOS
        
        It was used by "LibreOfficeLight" which died years ago.
        
        Change-Id: I71a1315448baa4f1ec7a22b20cb3dd39c88cda78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151066
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-04-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [cb79692883e92de02d87b0662a431f6ff8fba9c8]

        Remove wrong "toolti-text" in notebookbar.ui
        
        This patch removes wrong "toolti-text" entries in Calc's notebookbar.ui
        file.
        
        Besides being wrong (the correct would be "tooltip-text"), these entries
        do not make sense since tooltips are not supported in this manner by the
        Tabbed UI.
        
        Moreover, "toolti-textp" is not used in any of the notebookbar files.
        
        Change-Id: I2f862cfe53a8de5fa1566fec7cc00c14d1bcc505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151022
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-27  Eike Rathke  <erack@redhat.com>  [9a555d79b3b00793edf1d51a8a7c76b723cc436d]

        Resolves: tdf#151958 Disable binary search on sorted cache for current releases
        
        Temporary measure until the actual cause is fixed.
        The by string query of binary search on sorted cache is broken for
        mixed types like here the numeric date cells and text cells.
        
        Change-Id: Icfe0b0c30987fcefdd6ed11066ea9113f3b4dabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151074
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f565658431d6841c9a551a4c160e49080b89a06b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a79a8d4a5ca9e76f0811ddc8fcf8d79b21728ac
          - Refactor page - no content change
            
            Change-Id: I0f97c79e69234b52147c0812066f50f952705bd9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151077
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-26  Julien Nabet  <serval2412@yahoo.fr>  [2930179b0c0bbb42a66fcf7628060bda74e6c6c8]

        Simplify aCurNode.children construction in sw/WriterInspectorTextPanel.cxx
        
        Change-Id: Ide294aadc8a0c0df1fa6ba24bae044a2592677f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151075
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f297cdffefc28443997de075aa1a9b617e0e66b4]

        Update git submodules
        
        * Update translations from branch 'master'
          to bd22a155b84999d3a2e75cca0e1c735993971064
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I8c546190ea25d29f985750ecb2461a126f0815ff
            
2023-04-26  Sarper Akdemir  <sarper.akdemir@collabora.com>  [7dd994f8303a2b9396ed3848104028ff724e3bab]

        pptx export: fix export of vertical table text
        
        The mapping (implemented in 77655fc3dca05d4bb2366e67ccea228e3886bfe2)
        used on export and the accompanying roundtrip test was incorrect. This
        patch fixes both.
        
        Rotation value of
        - 9000 maps to vert270
        - 27000 maps to vert
        
        Change-Id: I9a9f889a2bff0241e62ee685492034eec6d0cccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150955
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [af8cb1039fd0cce86d771f4765c7d73c9f39b5a7]

        tdf#136749 std::map -> unordered_map
        
        considerably faster when looking up pointers, shaves 10% of time off
        here
        
        Change-Id: I521f8d557a30e4f430caab6b0701ad8da65f99f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-26  Miklos Vajna  <vmiklos@collabora.com>  [400d970f27078a93eab97ead8a6934a32272f549]

        sw floattable: DOCX import: m_bConvertedTable is now unused
        
        This was added in commit 659c0227a50d298780d72902314e03df8824bc06
        (tdf#107889 DOCX import: consider page breaks for multi-page
        floattables, 2017-05-16), but is no longer used since commit
        c50bf5a5daaae3d40f89ea0784a75a8a571c208d (sw floattable: remove no
        longer needed DOCX import heuristics, 2023-04-12).
        
        Change-Id: Ieba43e1175ab59c29c0555299facb8fc0e865acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151067
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-26  Julien Nabet  <serval2412@yahoo.fr>  [281c121bb3119db28c164a7b1ec7fde87abeccbf]

        Typo UNO_NAME_EDIT_PARA_TAPSTOPS->UNO_NAME_EDIT_PARA_TABSTOPS
        
        Change-Id: I515557adc9363858ebda5230e8428e2b58d06d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151068
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a0c23043725dd044ae93d9033ee97d5e8663ea35]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77b1a5a7118478c2b3a86fd43cfc68e336ac913c
          - tdf#153547 Fix typo
            
            + Reference to comment #2
            + Refactor of whole file
            
            Change-Id: I1c167c9ca1a0cf8e6d3f10ecb9da02eac9060ba3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/151071
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-26  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [904dfc73d08ba51ed29f4009ba2290e6232c0489]

        Disable WiX-based MSI generation for the moment
        
        Right now, CI builders have no WiX toolset installed, breaking all
        daily builds (since commit 9aee0383c3ebc3f267c99e19764728ba09c12d3a)
        
        Change-Id: I92ba2590c5afa711d3079edc070fd904b01de6f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150823
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [f5dd0ffdae83d3e9a568d54719ca82cf53693c4a]

        cid#1401342 Uncaught exception
        
        Change-Id: I50a2a4b1763749ae6117e38c982808b514e876d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151037
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [e2279c73456cd54f0cc8290bb562e0226fa174dd]

        upgrade to more recent fuzzing dicts and use some additional ones
        
        that look a good fit for the formats we're already fuzzing
        
        Change-Id: Ie635d17d829858c0cb10f71ea936f8dc131db811
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151052
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [33775c5d052e52ca60e3bc75d57981191d7b8c3a]

        add a svg fuzzer
        
        Change-Id: I9662d91d2761b4f160858897f19f31f474dccbed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151051
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [6d6c39f27bad19db7ec60d822e73cdeac9f4d69f]

        assume IFrame script/macro support isn't needed
        
        seems undocumented at least
        
        Change-Id: I316e4f4f25ddb7cf6b7bac4d856a721b987207a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150710
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [42ab4f0de00e113ed31f038e0441c1075b881b8d]

        use skia's svg seed corpus
        
        Change-Id: Iee1e7a6bbc3e50b3e882465aafea4c9b0650dcbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151056
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [7d913c6ec16cab123bd261bca20c4aaeea6b0b38]

        expose parsing svgs for testing
        
        Change-Id: I4d59aa9a684bd3e05fca473d6c7567cd8258b242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151002
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [c163334ae8cdd202dd4060ef1f401a9e9b51ce3e]

        tdf#151624 Fix Insert Formula tool in the Tabbed UI
        
        As reported in the ticket the Insert Formula tool was misaligned in the
        Tabbed UI since the removal of the Emoji tool.
        
        This patch fixes that by making the tool use all the available vertical
        space.
        
        Change-Id: I26d36ba4fc6f38e80d8ab46bfdf88c08fbf2fd68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150701
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-26  Heiko Tietze  <tietze.heiko@gmail.com>  [95ae136380906c6d270fd47b2b9655b2c32f670e]

        Resolves tdf#153852 - Make sort dialog resizable
        
        Change-Id: Ie0db5c713bf16443962245900655736aeddce532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151042
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [3bd65f0e3ea9953c7f4b00f3d42171d9b3dc3fd0]

        tdf#108757 speed up PDF generation
        
        std::list->std::vector reduces output time by 10% because we search the
        m_aChildren often and vector is better at that
        
        Change-Id: I4d0d5f6248a9c36aa0085cb22315ad6e2f53738e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151041
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d2a340eb8a4b6f51e2a121caba3a0d3b47504f2]

        tdf#108757 avoid some OUString construction on a hot path
        
        Change-Id: I468bc9fac024dd9fa33286382264e2b84617481b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-26  Miklos Vajna  <vmiklos@collabora.com>  [73bada774ef37efd5a4498ccc083b1358314557d]

        sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 3
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        Part 1 already fixed the crash, but a layout loop remains. The current
        problem is that we could have a document of 3 pages where the last page
        had no anchor for the fly frame, so it took the anchor from the previous
        page, but this lead to negative frame heights and at the end an empty
        3rd page.
        
        To fix the problem:
        
        1) Make sure SwTextFrame::FormatAdjust() doesn't break the invariant
           that only the last frame of a floattable anchor has text content.
        
        2) Make sure SwTextFrame::AdjustFollow_() doesn't join a frame that
           still hosts non-last split flys.
        
        With this, we have exactly 3 anchor frames (in a flow frame chain) for
        the 3 pages and the 3rd page looks correct. The original document still
        needs more work to fix the layout loop, though.
        
        Change-Id: I2fc9c4728fdf191ac5b5b435a10d553a699bae75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151048
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-26  Tor Lillqvist  <tml@collabora.com>  [4348f878284b53fa4e8ca670a8461a30ad0cba70]

        Bin leftover dead code
        
        Change-Id: Ie0583d52b01bba92e6fc41f0fee3fd4732f1d479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151054
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-04-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [09834f2d6dca89f4ce9e529bfcf2783a402b1259]

        Fix typo
        
        Change-Id: I05e089a8d04d2b5527cf466510b182eeac355836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151044
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d558e6bd23014166c20981cf05b4f14d4d3239ca]

        Fix typo
        
        Change-Id: I13e43e0cd7f3f3e31b581c5b3cec12f5c0634cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151043
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b79a82886dd8431ff79f148bd8bde8b11e04863a]

        update credits
        
        Change-Id: I934d635e0d241b9884017e4a22ba99e9d1459783

2023-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [69093f896b7da2b3694eeb6ea8fc439b00ef8884]

        Revert "workaround compile failures in libxml, with clang-17"
        
        This reverts commit 4a828dde104551c1c3d935ed8b43ebc546fa77c3.
        
        Reason for revert: Caolan merged a better fix with aa87fe2562e7a55a18a1c757a49babfe74377bcd
        
        Change-Id: I3ae713555fc62782675dbc48ad51a36ff41bfcf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-26  Tibor Nagy  <nagy.tibor2@nisz.hu>  [3fa15dd614bd72ddb36dbe033abeef5609d31f38]

        tdf#154906 tdf#129813 tdf#129814 sc: fix conditional format color scale
        
        This is a follow up to commit 3f614f431475e1bf3bb3bbeac59b0681309628b7
        (tdf#95295: don't add duplicate conditional formats)
        The above commit clearly describes how this fix works.
        
        Change-Id: I064fb3fe0443705553c6bbfcc34f2d717e0f6bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150899
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f222ea7cac653bb2319bb1d3196dea6ce062026a]

        jsdialog: enable themedialog.ui and themecoloreditdialog.ui
        
        Change-Id: Ie6c6af3e3a98548cad8b5bfb067382a03296b278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151033
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [57a676cf951eaa65831b32b080cf3da013bf60fb]

        Related: tdf#155017 Stop after the first pop in case the shell was not on stack
        
        After commit 271f17a6022c64cbbe9befbc66a9eaaa0567d569 (tdf#155017: make
        sure that the correct shell is popped from SfxDispatcher, 2023-04-26).
        
        This restores the previous logic for a hypothetical case of a pop without
        POP_UNTIL scheduled for a shell, which was not on the stack (so that it
        wasn't removed in the code added in the commit mentioned above); I haven't
        a reproducer, but it definitely can happen, given how things work here. So
        I try to avoid breaking it even further :-)
        
        Change-Id: Ied0a1406881fbefe3cf069f816c50da03a41dcd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151034
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [36dd8de9a6a64a047fe1330ab838d3c2efc8224a]

        use our existing zipfuzzer_seed_corpus
        
        Change-Id: Ib0ea6ad80ff24d3b405051c22b4cdcc461ae2018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150999
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Hossein  <hossein@libreoffice.org>  [1466e2a58f40c869d8c2590a4479e85c093b3468]

        tdf#152246 Fix RTL content control field position
        
        With this patch, the horizonal position of the content control fields
        are corrected. Previously, they were calculated just like the fields in
        the LTR paragraphs. To implement this, I've used the
        GetTextFrame()->SwitchLTRtoRTL method.
        
        The remaining issue is that The exported fileds in the PDF are still LTR
        themselves. For example, the combo box will still be LTR.
        
        It should be pointed that handling vertical text is still an issue that
        should be addressed later. If you rotate the paragraph with content
        control field, the output does not obey, which is incorrect.
        
        Change-Id: I927d14f9ca90434b4397dcf175dbb9531dda0c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150515
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-26  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [e898f95bfab16ddd9b04e516293cb6eb7e0a3847]

        tdf#138093 DOCX import: fix broken date selector control in table
        
        In tables, first character of the text value of the date selector
        control left outside of the control during the import, resulting
        broken date selector, e.g. 2[023] instead of [2023]. (Clicking on
        the broken control, according to the year *023*, the selector listed
        the lowest possible value, year 1900, and selecting that, the result
        became 2[1900].)
        
        Note: the fix works well with nested tables, too, so likely the
        condition with tables is obsolete.
        
        Perhaps regression from commit b36ef83ea59eeaca239e58b95aa0b1acdcb99efc
        "tdf126701: MSForms: Fix import of date field at the end of the
        paragraph." and commit 68e1be4ccbb90ee9a788962219a88312c4ffbea2
        "MSForms: Rework text-based date form field's representation".
        
        Change-Id: Ib217a3a06522bfe7b3b0fbc884f98504f628fc59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150575
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-26  Caolán McNamara  <caolanm@redhat.com>  [5dc84674816e5f3cad9a45b9307723de3dd25b71]

        tdf#155006 don't show "InsertObjectFloatingFrame" by default in menus and toolbars
        
        still exists, just isn't presented by default.
        
        help describes this as
        
        "Inserts a floating frame into the current document. Floating frames are
        used in HTML documents to display the contents of another file."
        
        and
        
        "Changes the properties of the selected floating frame. Floating frames
        work best when they contain an html document, and when they are inserted
        in another html document."
        
        This is basically support for html IFrames and is a fairly obscure thing
        for an ordinary document.
        
        Change-Id: Iec8ff591393e4ee4ed8791094e1f15a225808c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150707
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2023-04-26  Miklos Vajna  <vmiklos@collabora.com>  [9c23f533d6749e94971f04e18f1537472cac6b86]

        sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 2
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        Part 1 already fixed a crash, but a layout loop remains. One problem
        there is that we move too many rows to a next page. Analyzing what Word
        does and how we behave, we handled the TABLE_ROW_KEEP flag even for
        floating tables, but Word only does this when table wrapping is "none".
        
        Fix the problem by following suit, which gives the correct 2.5 rows on
        the first page of a reduced bugdoc.
        
        The layout loop for the original document still needs more work, though.
        
        Change-Id: Ief79d4b4e984a9e46ee133ae3e7e7cf81e13a836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151009
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-26  Julien Nabet  <serval2412@yahoo.fr>  [263f8a84712ae68780fd84cf3e37b857d3075cc0]

        Renumbering comments in include/svx/xdef.hxx
        
        Change-Id: Ice9f69824a6127dd23ce9e760b06ce9f03403604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150960
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Julien Nabet  <serval2412@yahoo.fr>  [d0ecc80ca4ab5fd19bf26dff8dc748c87444c024]

        Related tdf#154769: XML forms add anyURI/hyperlink datatype
        
        See https://www.w3.org/TR/xmlschema11-2/#anyURI
        
        Since I copied-paste string datatype + add check url, I thought about deriving from string datatype
        but seeing https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/datatypes.html#built-in-datatypes
        anyURI doesn't derive from string
        
        TODO: contrary to "string" which uses "preserve" for "whitespace" "anyURI" uses "collapse"
        There's WhiteSpaceTreatment notion in datatypes.cxx and m_nWST associated,
        WhiteSpaceTreatment::Preserve seems to be the default but when searching about it, it's seems not used.
        
        Change-Id: Ifc2dc06072e40b9be168c2f40a9506fe7d267ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150822
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-26  Justin Luth  <justin.luth@collabora.com>  [f6f14b98b8be8319c810708e73cffdb189c467ca]

        tdf#86630 sw page number wizard: set page style numbering type
        
        Giving the user the opportunity to change the number type
        is rather important. Well, maybe not too critical since I
        assume that the default page number style is relatively accurate
        for each locale, and at least for English we always just
        use numbers for the page style.
        
        However, a wizard is the perfect place to expose such a setting,
        otherwise it is buried in page style settings - far from
        where anyone would look when inserting a page number.
        
        Change-Id: I9053504fa55d16ebf5424946b480cb044b79988c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151005
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-26  Miklos Vajna  <vmiklos@collabora.com>  [8d0acd88214180f93cd09730baa1ed9a8169e987]

        tdf#154855 DOCX export: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>
        
        The bugdoc has a table where shapes are anchored in cells. The wrap type
        is set to "none" ("in front of text" in Word UI terms) and the follow
        text flow ("layout in table ell" in Word UI terms) option is enabled.
        The import into Writer is fine, but saving back to DOCX and checking in
        Word is not: all shapes move to the left cells.
        
        What happens is that since commit
        e993638d5ecd33783f2eebdccfa87a81e5a8a2c5 (DOCX import: fix <wp:anchor
        layoutInCell="1"> with <wp:wrapNone>, 2022-01-24), we ignore
        layoutInCell in case wrapNone is used with a suitable horizontal
        relation orient, since Word doesn't capture anchored shapes inside the
        cells in practice in that case. This helps for the old bugdoc, but
        introduces the problem that we now lose the layoutInCell
        setting on export, which is not wanted.
        
        Fix the problem by leaving the import and the layout unchanged, but do
        the opposite mapping on export: if we have the relevant wrap and
        horizontal relation orient case, then enable layoutInCell, even if the
        doc model doesn't have it.
        
        Note that Word itself behaves inconsistently here: if you change the
        vertical offset of one of these shapes to position the shapes outside
        the cell, Word does it, even if "layout in cell" is enabled.
        
        Change-Id: I980a995d76afdee4716f7669081c688065427ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151000
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [271f17a6022c64cbbe9befbc66a9eaaa0567d569]

        tdf#155017: make sure that the correct shell is popped from SfxDispatcher
        
        Honestly, I don't quite understand the idea of using the stack of shells
        in SfxDispatcher, when the order of addition of shells there does not
        match the order of removal.
        
        After opening the bugdoc, SfxDispatcher has these shells in xImp->aStack
        (from top to bottom):
        
          [8] SwWebView
          [7] SwWebTableShell
          [6] SwWebTextShell
          [5] SwWebListShell
          [4] FmFormShell
          [3] SwWebDocShell
          [2] SfxViewFrame
          [1] SwModule
          [0] SfxApplication
        
        SfxViewFrame dtor calls ReleaseObjectShell_Impl.
         * First of all, it calls PopShellAndSubShells_Impl for SfxViewShell;
         * Then it calls SfxDispatcher::Pop for SfxObjectShell;
         * Then it calls SfxDispatcher::RemoveShell_Impl for SfxModule;
         * Then SfxObjectShell is destroyed;
         * And finally, SfxDispatcher::SetDisableFlags is called.
        
        PopShellAndSubShells_Impl (for SfxViewShell) finds the passed SwWebView
        at the top of the stack (pos. 8), and removes it.
        
        SfxDispatcher::Pop for SfxObjectShell queues removal of the passed
        SwWebDocShell *without* SfxDispatcherPopFlags::POP_UNTIL mode.
        
        SfxDispatcher::RemoveShell_Impl first calls Flush, which actually
        executes the queued actions. At this point, an SwWebTableShell (pos. 7)
        is the top of the stack; SfxDispatcher::FlushImpl will pop it, and stop
        (because there was no SfxDispatcherPopFlags::POP_UNTIL at the previous
        step), so the intended removal of SwWebDocShell (which is at pos. 3)
        will not happen. Then RemoveShell_Impl will proceed searching for the
        specific shell (SwModule), and removing specifically that (at pos. 1).
        
        At the moment of destruction of object shell, the dispatcher's stack
        looks like this:
        
          [5] SwWebTextShell
          [4] SwWebListShell
          [3] FmFormShell
          [2] SwWebDocShell <-- The problem is here
          [1] SfxViewFrame
          [0] SfxApplication
        
        and pos.2 points to a destructed object.
        
        Finally, SetDisableFlags iterates all the shells still in the stack,
        setting their flags - and obviously accessing already destroyed object.
        In debug builds, this crashes reliably; in release builds, where dtors
        do not fill memory, the access of the just-destroyed objects likely
        often goes unnoticed.
        
        In different documents, the order and the set of shells there is
        different, e.g. an empty Writer document would have view shell just
        above object shell, resulting in correct removal of the object shell.
        
        I don't know what strategy is intended here. I decided to implement a
        small change, that makes sure that without POP_UNTIL, popping a shell
        removes exactly that shell that was requested for removal.
        
        Change-Id: I670d024056a5b32d5485f00a4799a8b0bacb6485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151003
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [9ca317ff313958706c63b132113d3f706813587d]

        tdf#155011: Fix assert/check
        
        pFrameStartAfter may be a section frame itself, thus its FindSctFrame
        would not return this. Same for pSav.
        
        Change-Id: Ib592965b30eb47f37ba54fe7f39af0b8689b3175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150981
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d91dc9ffd57d749946dd6062a3d961fab47ec607]

        tdf#153789 KJ: icons for Watched Expressions and Call Stack
        
        Change-Id: I9a989e039ae726e413c0a54ab805a0ee7d09c94e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151007
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-26  Justin Luth  <jluth@mail.com>  [bc6c5356c5cfa5c09145b54b87ad7be4d8f40ca2]

        tdf#86630 sw page number wizard: default to center of page
        
        Defaulting to one side of the page only makes sense
        if the footer is mirrored.
        [Well, mirrored isn't the best word here
        because it only refers to margin spacing.]
        
        The only way to get mirrored footers is to have
        separate left and right pages.
        
        It would be nice to add mirroring to the wizard,
        but that can be done separately.
        
        First, lets just get a better default value in place.
        
        Change-Id: I314c6a34414a696c6f2e27bb2b0747fdb86f3b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150998
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-04-25  Eike Rathke  <erack@redhat.com>  [2ff1830207d69ddd8aa6637e8ccc586ecabf1567]

        Resolves: tdf#41304 Add percent operator % to reference delimiters
        
        Change-Id: I094fcb800a29de424db28e1b58f1239381a3b4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151001
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-25  Justin Luth  <justin.luth@collabora.com>  [293959d42c0eb19a5e953c6d2610b2c7b1908412]

        tdf#56258 i18npool en-US: re-arrange outline numbering suggestions
        
        This patch brings order out of chaos,
        organizing the outline choices into
        academic, modern, simple numeric, and misc columns.
        
        The very first suggestion should be the academic standard.
        Next comes a distinctly different modern alternative
        Simple numeric moves over to be above the other numeric,
        followed by a demo of the kind of mixture that can be designed in LO.
        
        Since the academic standard uses Roman numerals,
        it is offset on the next row by the other one containing Roman numerals
        followed by a modern classic,
        and the all-numeric ISO standard retains it current position.
        The bullet oddball logically remains as the last suggestion.
        
        In this patch there was no change made to the actual suggestions
        themselves. Earlier patches made changes to 3 definitions,
        which allowed for the nice correlations.
        
        I missed changing the descriptive "strings" in the earlier patches.
        I had assumed earlier that these monotonous descriptions
        were dynamically produced...
        
        Since the English description should not be translated,
        I added a comment that will be extracted to the PO as a comment.
        (Thanks Andras).
        
        I think it would be nice to use strings
        "Academic MLA/CMOS/Turabian/OWL compliant outline"
        "ISO 2145 outine"
        but that could be made in a separate patch.
        
        Let me just point out what happened with the strings
        in case this helps with translation
        NOTE: only languages that ultimately inherit from en_US need to re-translate:
        
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_0
          -no string change
          -moved to _3
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_1
          -string changed / list modified earlier
          -moved to _5
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_2
          -string changed / list modified earlier
          -moved to _1
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_3
          -no string change
          -moved to _2
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_4
          -string changed / list modified earlier
          -moved to _0
        old RID_SVXSTR_OUTLINENUM_DESCRIPTION_5
          -no string change
          -moved to _4
        RID_SVXSTR_OUTLINENUM_DESCRIPTION_6
          -no change
        RID_SVXSTR_OUTLINENUM_DESCRIPTION_7
          -no change
        
        Suggested translation order:
        -cut _3 and paste into _2
        -cut _0 and paste into _3
        -cut _4 and paste into _0 and fix definition
        -cut _5 and paste into _4
        -cut _1 and paste into _5 and re-define
        -re-define _1
        
        Change-Id: Ie4ec8423acddc24efefb270d9ed19ab77566e6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150805
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8e5df127d26e42c3535e66f1733730e32e12df4d]

        svx: rework the theme dialog to allow editing theme colors
        
        In addition to editing of theme colors, this also changes the
        way how theme colors are represented in the theme dialog and the
        behaviour when changing applying a theme color change.
        
        Previously a theme colors were applied with double-click, now a
        double-click still applies, but automatically exits the dialog.
        The selected theme is applied also when OK button is pressed.
        
        Change-Id: Ic0f8399ede180d6ab0001a7f8b5dda0e7c49fa3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150975
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5cde4f2781fc80ed32aac2ad9c81cadab80860e8]

        add "m" prefix to member variables - SfxTabPage
        
        Change-Id: I482c341518948bf92f81d4f89b7e307635220150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150974
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Eike Rathke  <erack@redhat.com>  [5f6d27711a297d1851dc6bc713fd16c44014cf5c]

        Resolves: tdf#144547 ScRangeFindList: handle references in multi-line formula
        
        Also fix a color attribution error if when dragging the reference
        the new reference string is longer (colored too short) or shorter
        (colored too much including the next characters/operator/...) than
        the old reference string.
        
        Change-Id: I1b39fd5778d75290a0233f51a4198753fa858f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150979
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-25  Jim Raykowski  <raykowj@gmail.com>  [a8493ee3d7dac611286a75516f24dd6e451f9718]

        tdf#154604 SdNavigator: Support listing in front-to-back z order
        
        Enhancement patch to provide the option to list objects in front-to-
        back or back-to-front z order
        
        Change-Id: I2194cace08736d948002548887661314834cef89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150893
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-04-25  Jim Raykowski  <raykowj@gmail.com>  [4bc86f6477c3ed5f0e97b0a530acf7e102b613b3]

        tdf#38194 tdf#106556 Enhancement to highlight direct formatting,
        
        paragraph style, and character style use in Writer documents
        
        Initial commit to realize direct formatting, paragraph style, and
        character style highlighting enhancement requests.
        
        Highlighting of character direct formatting is turned on/off using
        .uno:HighlightCharDF. Highlighting of paragraph styles and character
        styles is turned on/off using a check box in the Sidebar Styles panel.
        Closing the Sidebar also turns paragraph and character style
        highlighting off. Paragraph direct formatting is indicated by a hatch
        pattern over the paragraph style highlight bar and also by "+ Paragraph
        Direct Formatting" appended to the tooltip that appears showing the
        name of the paragraph style when the mouse pointer is over the style
        highlight bar.
        
        Colors used for styles highlighting are determined by a hash of the
        style name. Lightgray is used for character direct formatting.
        
        Known issue:
        
        Tooltip doesn't show for paragraph style highlighting in tables and in
        frames where the highlighting bar is drawn outside of the frame.
        
        Change-Id: I6e00ee38c1c169bc7c6542a1782c03b2593e1891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150451
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [fb76d7f454522c4e8982b8fe1e75d0eb6f37c12d]

        add a fuzzer to test zip recovery mode
        
        Change-Id: I25f82cd83afae0fb3b0cfc3f1586e28323369f8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [aa87fe2562e7a55a18a1c757a49babfe74377bcd]

        add --disable-pedantic to avoid warnings as error for xmlsec
        
        like...
        
         symkeys.c:621:30: error: no newline at end of file [-Werror,-Wnewline-eof]
         #endif /* XMLSEC_NO_PBKDF2 */
                                     ^
         1 error generated.
         make[5]: *** [Makefile:765: libxmlsec1_openssl_la-symkeys.lo] Error 1
        
        Change-Id: I1dcd0cb6b350f412c30fb5a8d3aa4976cd0afde5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Justin Luth  <justin.luth@collabora.com>  [21b1dd42e9a817ae9b68e9e13ea57ce2491940c6]

        tdf#154956 sw: delete bookmarks at end if whole node is selected
        
        Exposed by LO 7.2.2 commit 4bf04dea9afb30a9395e80b07a81d1908937ee8b
        Author: Michael Stahl on Fri Aug 27 14:38:18 2021 +0200
            tdf#128106 sw: copy bookmarks at start if whole node is copied
        
        Change-Id: I9205463f9beb3704eeb63fe7556103230ba7283d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150772
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-25  Heiko Tietze  <tietze.heiko@gmail.com>  [07f87f20c8af71faeda500b6b1d7775743bbf646]

        Resolves tdf#154080 - Allow customization of comment indicator color
        
        * New application color added
        * Border color depending on cell/sheet background
        * Comments color set to light magenta to align with similar tools
        
        Change-Id: I782e8359632c5a319e61f5d5ac3deb4614bd7e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150970
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-25  Michael Stahl  <michael.stahl@allotropia.de>  [bb0e041a237a1c4ad4f5c0bd092fc3da5c18b7f1]

        Fix tdf#155004: ucb: webdav-curl: carry over Class1 bit only if set
        
        With d6182cb6704c06f33d284874b9fe96c85cce5bf5 there are cases when a
        webdav server inadvertendly releases the lock. Lets apply the fix only
        if the Class1 flag is actually set.
        
        Change-Id: I85e5253c7df0980f373d2dea788c331b81ed4a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150552
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [5f0e276336bc130b15480a04ec1cc6a9a1c9e93b]

        Remove lock file fuzzer
        
        this found nothing in 12 months and exists to try and follow up
        on a confusing report which went nowhere in the end
        
        Change-Id: I7f3c6a5e2ccedad2e7b925b3c15b076cd22f1ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150972
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [d41b436058def4497240c54afc38b319ce388430]

        expose recovering zips for testing
        
        Change-Id: I4709a2fb0bbb0fcc4c7d57dad53c899e7ba79cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150971
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [e7c30e6c1ee8fbea7d44ab00e2721ff13dfa4da5]

        Resolves: tdf#155005 use of uninitialised value
        
        ==2515797== Conditional jump or move depends on uninitialised value(s)
        ==2515797==    at 0x33FAB399: ZipFile::recover() (ZipFile.cxx:1090)
        ==2515797==    by 0x33FA4D32: ZipFile::ZipFile(rtl::Reference<comphelper::RefCountedMutex>, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>, bool, bool) (ZipFile.cxx:111)
        ==2515797==    by 0x33FEF134: void std::_Construct<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(ZipFile*, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (stl_construct.h:119)
        ==2515797==    by 0x33FED528: void std::_Optional_payload_base<ZipFile>::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:278)
        ==2515797==    by 0x33FEB73B: void std::_Optional_base_impl<ZipFile, std::_Optional_base<ZipFile, false, false> >::_M_construct<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:457)
        ==2515797==    by 0x33FE77DB: std::enable_if<is_constructible_v<ZipFile, rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>, ZipFile&>::type std::optional<ZipFile>::emplace<rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, bool&>(rtl::Reference<comphelper::RefCountedMutex>&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream>&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool&&, bool&) (optional:918)
        ==2515797==    by 0x33FD61FD: ZipPackage::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (ZipPackage.cxx:760)
        ==2515797==    by 0x64DE1EC: cppuhelper::ServiceManager::Data::Implementation::doCreateInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:732)
        ==2515797==    by 0x64DDF19: cppuhelper::ServiceManager::Data::Implementation::createInstanceWithArguments(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (servicemanager.cxx:694)
        ==2515797==    by 0x64E0E8F: cppuhelper::ServiceManager::createInstanceWithArgumentsAndContext(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (servicemanager.cxx:1018)
        ==2515797==    by 0x34A3B25F: OStorage_Impl::OpenOwnPackage() (xstorage.cxx:435)
        ==2515797==    by 0x34A3C16C: OStorage_Impl::ReadContents() (xstorage.cxx:541)
        ==2515797==  Uninitialised value was created by a stack allocation
        ==2515797==    at 0x33FAB02C: ZipFile::recover() (ZipFile.cxx:1034)
        
        since:
        
            commit abda72eeac19b18c22f57d5443c3955a463605d7
            Date:   Mon Feb 20 00:32:22 2023 +0100
        
                tdf#82984 tdf#94915 zip64 support (import + export)
        
        where
        
        - aEntry.nCompressedSize = nCompressedSize;
        - aEntry.nSize = nSize;
        
        was removed before the subsequent use of aEntry.nCompressedSize/aEntry.nSize
        
        change things (git show -w for clarity) to check bounds first just for
        the range the extra fields might be in and read those, and then follow
        up with the original check that the newly discovered
        aEntry.nCompressedSize/aEntry.nSize are within the bounds of the overall
        file
        
        Change-Id: Iad4ce8297109b06bc5baf77df4f3e86659cbb4cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150969
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [80805716a409c34203b059f3e03cd934367186c3]

        tdf#155005 fail gracefully on encountering a negative compression value
        
        we are using sal_Int64 for this so a large enough value can be
        interpreted as negative here
        
        Change-Id: Id547a24591aca4b6ed7b7955621641a0666b0bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150968
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Tünde Tóth  <toth.tunde@nisz.hu>  [2ef83c8782ed947b47f9292a12355fc3bb078078]

        tdf#91332 XLSX export: fix missing solidFill
        
        Background color of shape inherited from theme
        lost after export.
        
        Regression from commit bc0a9076aa43a0782bcf81e55d3f84f6af0f68e8
        "ooxml: Preserve shape theme attribute for solid fill".
        
        Change-Id: I2d8298ac17332ba3ad6a627ce8b07c23087ac7b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150674
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-25  Tünde Tóth  <toth.tunde@nisz.hu>  [5ee52d401e2086f79f794a4ec1a1d7beec8aa582]

        tdf#119565 XLSX export: fix lost line properties inherited from theme
        
        Line properties (LineWidth and LineJoint) of shape
        inherited from theme lost after export.
        
        Perhaps regression from commit 5391d4872e71d1edba7acc4ad2d2e3b5b97e1723
        "ooxml: Preserve shape style and theme attributes for line".
        
        Change-Id: I9977bb20f16245f3c95ccbe2c5c8033b5b0c9cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150547
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-25  László Németh  <nemeth@numbertext.org>  [dd5e5f3fab4b8f736baeda0f706c77a4ea9b6804]

        tdf#150824 sw DOCX: fix export of new tracked tables
        
        New tracked tables handled by a single redline, which
        lost during the export: only the tracked text changes
        of the cells were exported, but not the table changes.
        This resulted also problems in MSO, e.g. rejecting text
        changes removed only single cells of the tables,
        modifying the table structure. To fix this, add missing
        tracking to the table rows, if needed.
        
        Follow-up to commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06
        "tdf#79069 DOCX: support tracked table (row) deletion".
        
        Change-Id: Ic900cafa7bea3c934d8d1bd585b3e95f56746db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150967
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6252959192c07973af698ce30fa67b1a29e4871e]

        oox: add support for theme import and export of blip effects
        
        This adds support for (most) blip effects import, export and
        the document model.
        
        Change-Id: Iec15f4de22c31268019fa1a60432e40ae8f03635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150262
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b09c377888e2e75859fff37fdf9408065eb522d6]

        oox: write graphic (blip) in ThemeExport - BlipFill
        
        Share the graphic writing from DrawingML class, which needed a
        bit of refactoring and use it when writing the BlipFill when
        exporting a theme with ThemeExport.
        
        Change-Id: I89bf3be98f607b7641d231982af2f7a5e2c3d3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150261
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [3fa2ba3b557f2415f94cc22cc4b3495d9226df72]

        tdf#154991: sc_uicalc: Add unittest
        
        Change-Id: I1aa8e56fdbf0b8903cd04b78f4bb640fb31bd56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150963
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a828dde104551c1c3d935ed8b43ebc546fa77c3]

        workaround compile failures in libxml, with clang-17
        
        ever since
            commit 26bf26272bf525b59b4a4ce18b3ce14c1febfd7b
            Author: Miklos Vajna <vmiklos@collabora.com>
            Date:   Mon Apr 24 14:27:47 2023 +0200
            Update libxmlsec to 1.3.0
        failures reported to https://github.com/lsh123/xmlsec/discussions/623
        
        Change-Id: I2952f0eda036f6ff69710b8a103bbfc846ed87d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150966
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-25  Eike Rathke  <erack@redhat.com>  [5265892378ded9336e24199fe8260dde6be99156]

        Group sort bo_IN.xml LC_FORMAT FormatElement for better comparability
        
        Change-Id: I6e17c01ce4d3a351a2cb49d214f73468d425b4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150952
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-25  Eike Rathke  <erack@redhat.com>  [805343aa483f864f9fb55e0000a5a1086667eee8]

        Inherit ml_IN formats and numberings from hi_IN
        
        Change-Id: Ied5f3f8e051d8d9292888d8831ae3e6a88270198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150953
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-25  Eike Rathke  <erack@redhat.com>  [a08e73d7ff477a4a0e3bce2a9e56a969d204203d]

        Group sort hi_IN.xml LC_FORMAT FormatElement for better comparability
        
        ... and eliminate doubled space.
        
        Change-Id: I84229145072283975ff17e2db661784205fa9af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150950
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-25  Stephan Bergmann  <sbergman@redhat.com>  [538e7a8a79dfde8a9e9b2339880f7a7b2df187b2]

        loplugin:unnecessarygetstr
        
        Change-Id: I120b2ef4b8a409dc63495829bec872ebad01c868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150962
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-25  Heiko Tietze  <tietze.heiko@gmail.com>  [1f7b725b55328f961fc9f124f22e3537e3cfed94]

        Resolves tdf#154991 - Fix crash with hidden columns
        
        Hidden columns do not have a background that can be taken
        into account for the text overflow indicator's frame
        
        Change-Id: I325873aede07fd890777624308a3f5a41f0f1795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150959
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-25  Stephan Bergmann  <sbergman@redhat.com>  [1dec9d7f1a421af0dc4534204f2af550850cb60d]

        loplugin:unnecessarygetstr
        
        Change-Id: I36eaac02a9779ee8e1f69930ffeafedc8641301f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150961
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [78cf9c05db01e2177d28eb08b3389e487d84060f]

        oox: refactor ThemeExport to use member FSHelperPtr instance
        
        This refactors ThemeExport to use the member variable FSHelperPtr
        instead of passign it through functions as a parameter. This also
        forces many functions that were in anonymous namespace to become
        members of the ThemeExport class. This is needed because in some
        instances we will need access to FSHelperPtr instance as well as
        access to XmlFilterBase.
        
        Change-Id: I9e4ead9cd87ec2157535106be28596c4282fe167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150260
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Gabor Kelemen  <kelemeng@ubuntu.com>  [b355c9b79e03307eda080c5ea6010632854fa801]

        Make bin/includebloat.awk script output prettier
        
        So instead of:
        sum total bytes included (excluding system headers): 21793372177
        1197253280 132910 9008 /home/gabor/src/core/include/rtl/ustring.hxx
        825845085 90207 9155 /home/gabor/src/core/include/rtl/ustring.h
        
        We can see something nicer:
        Sum total bytes included (excluding system headers): 21.795.559.123
        Total bytes	Size	   Occurrences	Filename
        1.197.253.280	132.910	   9.008	/home/gabor/src/core/include/rtl/ustring.hxx
          825.845.085	 90.207	   9.155	/home/gabor/src/core/include/rtl/ustring.h
        
        Change-Id: Iabcaadae964221ed532e7e7e97b10211e37d4857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150613
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [bff4282e1c0c7c1f32b93cf5175a721c8226d5de]

        Resolves: tdf#154958 add an empty spin button to use for the unused case
        
        instead of reusing the percentage one, which will set its min value
        under gtk
        
        Change-Id: I342f8f0588574c45c5752964b95232e419f752ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Caolán McNamara  <caolanm@redhat.com>  [b3d6c521c1e1fc6a1e84940c19cb2e18157e877f]

        ofz#57493 avoid Timeout
        
        Change-Id: I9fee1ad3467c18d2714ef211f2c95c6b4211415b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150946
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-25  Miklos Vajna  <vmiklos@collabora.com>  [3c2e4d454aaabcd61593e670a90638a185046539]

        sw floattable, crashtesting: fix PDF export of fdo72790-1.docx, part 1
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        What happens is that the DOCX file has a continuous section break, that
        is mapped to a Writer section, but then the fly splitting code didn't
        expect that the anchor might be inside a section frame.
        
        Fix this by explicitly checking for an in-section anchor in
        SwFrame::GetNextFlyLeaf(), which will give us a suitable insertion point
        on the next page.
        
        This does not fully fix the handling of the bugdoc, but at least now a
        reduced sample doesn't crash and is handled correctly.
        
        Change-Id: I52b5c901d899533bbb78131f443789d55db41000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150956
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-25  Stephan Bergmann  <sbergman@redhat.com>  [c9b6bf655e6de50c55629b4805399932c90a3b30]

        Add some tests for (Japanese) i18n::IndexEntrySupplier behavior
        
        ...in preparation for some upcoming i18npool/util/i18npool.component clean-up
        
        Change-Id: I8e93aa33759f2bdd6b9422b3833a608cfbed1df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150948
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-25  Gabor Kelemen  <kelemeng@ubuntu.com>  [75ed56689427f972ce58e395af8aaf951dda7581]

        Add script to find unused using declarations
        
        As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls"
        Pros:
        - simple, fast!
        - finds some more unused declarations, somehow
        - works on non-linux specific parts of the code
        - clang-tidy (for me) trips on files with external headers, this does not
        
        Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-25  Miklos Vajna  <vmiklos@collabora.com>  [26bf26272bf525b59b4a4ce18b3ce14c1febfd7b]

        Update libxmlsec to 1.3.0
        
        See <https://github.com/lsh123/xmlsec/releases/tag/xmlsec_1_3_0> for the
        upstream release notes, notably:
        
        > (ABI breaking change) Switched xmlSecSize to use size_t by default.
        
        Adapt xmlsec-wrapper.h accordingly.
        
        Change-Id: If910e44441be65794d4441558e2838d00b4b927c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150647
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [33c2443134cfd2110258d5424645ace9e1db127f]

        oox: extract image / graphic export into GraphicExport class
        
        Change-Id: Ib37aee6c5f664e80d45530dae0de9c172e0773a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150259
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2f48aae12ae949056654cb172873f4025104af67]

        oox: Harden the testTdf142605_CurveSize Test with extra checks
        
        Even if it is likely that we fail, it's important that we check
        that we are checking thr correct shape and not some other shape.
        
        As there is only one shape we could assume that in the case that
        something goes wrong and we wouldn't be able to read the shape,
        we would end up with 0 shapes, but in case of an empty page we
        inject placeholder shapes into the page, so we end up comparing
        the size of a placeholder shape. In this case the test assert
        gets confusing as we obviously get wrong sizes, which suggest that
        something is wrong with the shape and not that the shape we expect
        to assert against is missing and we compare against a different
        (placeholder) shape.
        
        This adds more asserts, which make sure we actually have the
        expected shape first and also preven crashes if something would
        go wrong.
        
        Change-Id: I435f87d7e634c5135a376ad084373f8d5053555e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150942
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [398d64e32c60871315ca31524d7a204fb0576ebe]

        tdf#154774 KJ & Sukapura: +/^ images for spacing preview in Math
        
        Change-Id: Ibafddc6e1db98448cc94e72d48c577e8c719ae8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150951
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0ee38e7e061f764b5e21487da090620ed93bb260]

        oox: combine graphic cache into GraphicExportCache class
        
        We cache graphics to not export the same graphic multiple times
        if this can be avoided. The cache was integrated into DrawingML
        but we need access to it in different places, so this change
        extracts it into its own class.
        
        Change-Id: I71e3b67906f2948ca00c2ef7ca857bf80ab6a737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150258
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c3f7720ff13c34b9cf2c90d9c9b6dcc3d8f4c7a5]

        oox: extend ThemeExport to export font and format scheme of a theme
        
        Also use the ThemeExport when exporting PPTX documents and remove
        all the hard-coded theme bits.
        
        Change-Id: I03791e23d6ac4023748b5a553e4824b72ed63a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149363
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-24  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [09cdcb5f37bb4e42da7b28db6e757b9f2affed14]

        introduce sw::SpzFrameFormat ...
        
        - ... as a base class of frame formats allowed into the
          spz frame format container
        - with a private ctor and friends SwDrawFrameFormat and SwFlyFrameFormat
          so only these two classes derive from it
        - with that, switch over the SpzFrameFormats to only ever allow these
          types into the container
        - in followups, likely quite a bit of stronger typing can be introduced.
        
        - ultimately, it would be nice to have each SwDrawFrameFormats and
          SwFlyFrameFormats in their own strongly typed container in the end.
        
        Change-Id: Ic30efc1220aded701533c9ca5003d2aaf8bbdaec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150452
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-04-24  Jim Raykowski  <raykowj@gmail.com>  [eebd13c97ecef1e39aa054701a6e6618227d7ae0]

        tdf#145359 related: Fix SdNavigator dnd z ordering
        
        Makes the object dnd z order follow the current behavior of bring
        forward and send back actions. Object placement top to bottom in the
        Navigator is wrt object z order back to front.
        
        Change-Id: I42e0902eabe7a2758a075a5f4357868994825a51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150810
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [4d6fcd7908f6db892e8d5fb3cabf7e0fe49328c4]

        Resolves: tdf#153441 use a TriStateEnabled helper
        
        Change-Id: I976e4271a072bfb53c676091509e1d4ef7dbcccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [26b7d00c24c4d85d004e3840fb9053e4c88c1fee]

        ofz#58241 Integer-overflow
        
        Change-Id: Ie5b82df4642c786e309022e3b5a436aef66d1137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150945
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c1561561a859c561fb2321420f1abb7f1cedde3]

        loplugin:unnecessarygetstr extend to more std::string checking
        
        suggested by mike kaganski
        
        Change-Id: I5f5f254142767aca45a6101abdd84a0163ca6a34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-24  László Németh  <nemeth@numbertext.org>  [5e6d8efbf3fb456ca370df04b21d2e340d9831ad]

        tdf#154859 sw: fix deletion of tracked row insertion
        
        Row deletion of tracked row insertions resulted an
        empty, not tracked row. To fix this, disable row
        deletion on tracked row insertions, allowing only to
        manage changes for removing the row, e.g. by clicking
        on Reject Change of the context menu of the table row,
        like MSO does.
        
        This also avoids of clicking again on the row deletion
        to create an empty tracked row deletion from the
        empty not tracked row, and originally, from the tracked
        row insertion.
        
        Regression from commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Follow-up to commit 0204c00f241313e1d292b4c3ea117d42af7dec69
        "tdf#147453 sw: disable Delete Table functions on tracked deletions".
        
        See also commit 95c003d75e0f8b255344715a35358072b5eba99d
        "tdf#146145 sw: 1-click Accept/Reject of table row changes".
        
        Change-Id: Ied38860939359caa52e09987cf968953399611ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150938
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [a1388417b217430de456868c440817459697c4a8]

        resave with latest glade
        
        Change-Id: I8db5ddfa271ab3729d069486f9f4b05263fbe9b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Miklos Vajna  <vmiklos@collabora.com>  [e0017ad2a5b008111b716c0814c5a0c5b0f1e05b]

        sw floattable, crashtesting: fix PDF export of fdo80989-1.docx
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        There were two problems here:
        
        1) We assumed that when we move content to a next page, that page is
        empty. This may not be true, and in case the next page has content,
        we should insert the content at the start of the page, not at the end.
        Specifying the sibling for MoveSubTree() fixes this.
        
        2) We also hoped that if we ask for the next layout leaf, that will be
        from the next page. Again, this may not be true,
        SwFrame::GetNextSctLeaf() has quite complex conditions to detect this.
        Split flys don't have to span over multiple columns, so just require
        that the candidate is inside a different body then our anchor.
        
        The bugdoc has to be loaded in hidden mode, otherwise we already calc
        the layout on load, and then the problem is not visible.
        
        Change-Id: I6e1533369db24c7c275ec1d7dceaddc4128c268a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150904
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-24  Mike Kaganski  <mike.kaganski@collabora.com>  [5a1d07a819bd0f14dd901b35ae245bcd681cb512]

        tdf#154884: do not stop if the first pair is not what we looked for
        
        The same character can be added later with a different font, so keep searching
        
        Change-Id: I7b83438ca476ffab23ca08268cf957045d75f6f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150937
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [a27e9e32ca9d67402706d1d970f3aaa04d746904]

        tdf#154698 allow "XML Form Document" to be localized
        
        like "Base: Relation Design" can be
        
        Change-Id: Ic4bebd0636da1eb598e667f7aa51b201ecf9cc27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [3e3a220a1516fae7a038aec63388c97c8cc5c694]

        cid#1524749 Copy into fixed size buffer
        
        Change-Id: I0a4d11fc15c9e7603f6c46c2075373722722b437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150905
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [33a4a934a230c551d053c30938ec802b2924182b]

        tdf#154774 Breeze & Sifr: Add image for spacing preview in Math
        
        Change-Id: I8a7aa14729b41311c86a9cbc57626c68c8d70ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150908
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [8060f1349169772653c9be42cf64f559418fab73]

        tdf#154941: sc_mathematical_functions_test: Add unittest
        
        Change-Id: I263b143c94773045fa9c20471b81a7555aff4ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150909
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-24  jucasaca  <jucasaca@gmail.com>  [9227fbabe0a33134f56aefdd8ec16024f006a659]

        tdf#117118 - Saves data automatically in Firebird embedded database
        
        Saves data when dispossing connection regardless of
        whether or not the save button is pressed
        
        Change-Id: I501fbc3d89ff52695f42196b2627e26c2011f75b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148368
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [5be0f62621a5ef66438cf2dc660be8e524588c15]

        tdf#147503 don't use SfxObjectShellLock for new xml forms document
        
        because in the hidden case the document is unexpectedly closed on
        leaving NewXForms
        
        Change-Id: I00ea0b8de6c10ff141584cefe3768b7071138393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150891
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Miklos Vajna  <vmiklos@collabora.com>  [5951e37eb24e09d3c24cb4cab4b0f3da41e3dfff]

        sw: fix crash in OutHTML_SwFormatField()
        
        Crashreport signature:
        
        program/libswlo.so
                SwDocShell::GetView()
                        sw/inc/docsh.hxx:222
        program/libswlo.so
                OutHTML_SwFormatField(Writer&, SfxPoolItem const&)
                        sw/source/filter/html/htmlfldw.cxx:549
        ...
        program/libswlo.so
                SwTransferable::WriteObject(tools::SvRef<SotTempStream>&, void*, unsigned int, com::sun::star::datatransfer::DataFlavor const&)
                        sw/source/uibase/dochdl/swdtflvr.cxx:?
        
        I.e. clipboard documents don't have a doc shell, handle that.
        
        Change-Id: I48b22087f759a11b4aa46b83b310f4a661e1fbc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150897
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-24  Caolán McNamara  <caolanm@redhat.com>  [9d77abfa4fd0f352a7a30f3140ab0adfed71bd85]

        cid#1401342 silence Uncaught exception
        
        Change-Id: I1ff8deeb07c13cc7dee6e5d86f004f840723f056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150903
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [dba55c304a330a355147a39e53ec4c7cf5c5c3f5]

        loplugin:unnecessarygetstr extend to createFromAscii
        
        idea from mike kaganski
        
        Change-Id: I0ecb9cad091d7a048d2ddae73165bf22748f3872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150907
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [8505d29d61a76ffa506be0dc86fe2ec7ed647483]

        tdf#154774 Breeze: Add images for spacing preview in Math
        
        Change-Id: I9cacdb4c1ae5de9a312b59fc07310ab1991a1105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150898
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-24  Arvind K  <khandelwalarvind26@gmail.com>  [b7dfed873d79417fff83410760fec84567b534e9]

        tdf#139544 change boundary columns to rows in sort dialog
        
        Change-Id: I7f525bea42e6efd3c7c4b62a21d2638b676cd836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150432
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-24  Miklos Vajna  <vmiklos@collabora.com>  [5c59d6f51f837639f1f0f24e154814136bbdfda9]

        sw floattable: remove no longer needed ImportFloatingTableAsSplitFly setting
        
        This was useful while developing the DOCX and DOC filters, but those are
        now enabled by default, so this can be removed.
        
        Change-Id: I0ebde6ec5e1a84f368d35b362bd1c3b1aabc9d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150895
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-24  Maxim Monastirsky  <momonasmon@gmail.com>  [732ca611a00068c5c77c1774ec893a2abccd6c1e]

        Missing CJK and CTL attributes in default cell styles
        
        Presumably after 516bc904e94971b61e4b13af632bf321b0a4a640
        ("Upgrade mdds and orcus to 2.1.0 and 0.18.0, respectively").
        It appears that we used to set them from the latin attributes
        specified in styles.xml, which isn't correct. So let's just
        add them explicitly.
        
        Change-Id: I3300f73b0376275147f89d2db0ac3ef4bf2da5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150892
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-24  Miklos Vajna  <vmiklos@collabora.com>  [95aa39749b4dcc9cf06350dcb8c9a96373de5999]

        sw: prefix members of XMLFontAutoStylePool, XMLPageExport, ...
        
        ... XMLStyleExport and XMLTextListAutoStylePool
        
        See tdf#94879 for motivation.
        
        Change-Id: If49190233b87bf86c83d56f02eedb1c010ef119c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150896
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-24  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [12e23067fd0acad3e06df50cefaa0a2cd73df3b5]

        EMF+ Minor optimization and clean up code of DrawBeziers
        
        Change-Id: Id560b3d3a6182270853fd05a6f2d1e44452c0013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150894
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-04-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [30df7198f96ef23b4925e60a1b35144668749ec4]

        tdf#154976 Fix VCL based asset's contrast in Colibre Dark & harmonize them with Light
        
        Now the Light and Dark variant will have opposite but complementary colors
        
        Change-Id: I71b01cd3933b2c76c6880430a6684ee5665fa653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150890
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-24  buldi  <dobrakowskirafal@gmail.com>  [c6755955aeaddb14bd3ad231f78cda47a0a5aeaa]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I47611e1bffed814294bd2c7b23b26e1878151464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149939
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [14a23ef47c8ceaa1fc6dc4a7a942fb8360ea4bfd]

        tdf#152625 Revise Colibre's tab_select* icons
        
        Change-Id: Ic5a92b98ddcbfa970643bf54fb406673c9108c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150829
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-24  Stephan Bergmann  <sbergman@redhat.com>  [898cf0b7d9e3198cb17f68ef6e6cf6d80ae03780]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries,
        
        > com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant)
        
        etc. rather than
        
        > com.sun.star.i18n.IndexEntrySupplier_"(alphanumeric first) (grouped by consonant)"
        
        etc.
        
        Change-Id: I7fa0f9c7615b5cb1b7c0c6a8908cad27f0ac5712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-23  Stephan Bergmann  <sbergman@redhat.com>  [503242381527d8d916ae705f240a10a0c291182d]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries
        
        Change-Id: I1f32d4533a49f0988a2d5c2b8d20198baab515a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150761
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5dc2b5277f4d18533c5fe4d43b016f12da52ed36]

        Translate remnant "Kalkulator" into "calculator"
        
        Change-Id: I3c72342d07eabb3b618cd0c36d0606d81baad423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150173
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b102852bd67fb08e08c02cc733d3682db3969ce1]

        Fix typo
        
        Change-Id: Ie8c702436d3efbaf2ca1573193100974a42f93a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150459
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d494b80b158bb3ead90f62072b7a50225e382f42]

        tdf#153892 Colibre Differentiate two Index icons
        
        Change-Id: Icafd532f4a5cc18d7bdfe9fe545d678286081b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150827
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-23  Nabeel Siddiqui  <nabeel.siddiqui.314@gmail.com>  [52522f4772806d9e74ab7df9cc3e8046f68c5809]

        tdf#148251 Use std::swap instead of using temporary values
        
        Change-Id: I7733ba595634f41ef0a0902ea37d694276417871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149087
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-23  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [ce008fa9d8f2752bdfeaeff763aafc774a4b4fb2]

        tdf#154789 EMF+ Performance boost of the EmfPlusRecordTypeDrawBeziers
        
        There is several benefits of such performance optimization:
         1. We are drawing single curve instead of hundreds of small curves.
            In the loop we are creating single Polygon and outside
            of the loop we are invoking EMFPPlusDrawPolygon drawing method only
            once. As https://bugs.documentfoundation.org/attachment.cgi?id=186725
            image is using single EmfPlusRecordTypeDrawBeziers EMF+ record with
            hundreds of curves, with using single EMFPPlusDrawPolygon call,
            there is no lnger need for individual line creation (e.g. line
            color, weight, line caps, line joints, line dashes, etc.)
        
            - The PDF export performance without optimizations of the https://bugs.documentfoundation.org/attachment.cgi?id=186725:
        
                time ./instdir/program/soffice --headless --convert-to "pdf:writer_pdf_Export" --outdir ~ ~/Pobrane/problem.docx
                real 24m18,471s
                user 2m56,004s
                sys 1m37,816
        
            - The PDF export performance with optimizations:
        
                real 0m37,527s
                user 0m37,004s
                sys 0m0,531s
        
            - With Libreoffice 7.5.2 from Ubuntu 22.04, the conversion was
            crashed.
        
         2. The PDF export for document: https://bugs.documentfoundation.org/attachment.cgi?id=186725
            was not working correctly for me. The original image is containing
            chart. Without optimization, the exported chart was empty.
            Current export is working correctly, and graph is visible.
        
         3. The standard opening of the document from https://bugs.documentfoundation.org/attachment.cgi?id=186725
            is now much faster. The zooming in, move image operations are also
            noticible faster.
        
        Change-Id: Ic77d4c20a462587bb5da4a4df757e30c5ca04fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150821
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-04-23  Julien Nabet  <serval2412@yahoo.fr>  [2b87376d7e8cc9d5973a8ccd4c9fdf398ebbd2a0]

        tdf#154886: fix Report builder mutex assertion
        
        Thank you Noel for the hint!
        
        Change-Id: Icb1f63deaffc454e0dcc3b736c9214d93b6871df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150826
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4ee01c29a3794e1e0dee300d0f2aa150ce07b3c0]

        tdf#154825 All icon themes: add/update section editor
        
        Change-Id: I9b59c4c99d623aab1a46898e732f45d5b22261ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150825
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-23  Jean-Pierre Ledure  <jp@ledure.be>  [a58017d99c3cea52fe7b37f2379c5306bfa59807]

        ScriptForge (SFDialogs) support hyperlink control types
        
        Controls designated in english as "Hyperlink controls"
        in the Basic IDE are from now on accepted as instances
        of the SF_DialogControl service.
        
        All generic properties are accepted.
        The supported specific properties are:
           - Caption (the text that appears in the dialog box)
           - URL (the URL to activate when clicked)
        
        The new control type is supported in Basic and Python
        user scripts.
        
        The SFDialogs.DialogControl help page needs to be updated.
        
        Change-Id: I4827834ad8ef336c084ee51b5285b85745ceb1b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150824
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [f7307c6366196940dcdbf6d2bfc23b69b18acb85]

        cid#1524746 silence Using a moved object
        
        Change-Id: I82728c481c721aeb0d70f6bbdf6f0f1b49ea7b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [e03603bcedf236c050173b921ab51db9aa8ce274]

        cid#1524676 try to convince coverity of the error of its ways
        
        and
        
        cid#1524745 Explicit null dereferenced
        
        Change-Id: Id2fb9cf6d0a71712533e14981a33490c578db597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150818
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [1597f3cf16aa6747c878a23f64669805d18e9c46]

        cid#1524747 Dereference null return value
        
        Change-Id: I08a3382287dd30a6cee84e93b3aa8a97db4c3a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150817
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [6ca3b441a9e32d80be8e6ebf3246b5e2de36e1ef]

        cid#1524750 Dereference null return value
        
        Change-Id: I2f0aa7c190e6f4c18340a75fcc2eb5b635d686e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150816
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [2281c182e181fcfccf526a4ca2364295c7eaa1ee]

        cid#1524751 Dereference after null check
        
        Change-Id: I3543b7e251fe6076ad1875bc49abfbe747f45999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150813
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [ed93d660953cb4d15321ee7529a07cd0c8af0ba9]

        cid#1401342 Uncaught exception
        
        Change-Id: I16dd5b9adf6f6e87c11bd1cfcbb823c4f683bedd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150812
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Caolán McNamara  <caolanm@redhat.com>  [8ce01e886db5c9968909eda0cab93b5f41634f34]

        cid#1524748 Uninitialized pointer field
        
        Change-Id: I50becae790146538b5996df15301456d83af2ffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150811
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6c617c3d69d6b2cf209bd7cfe4b9565b58e87c0]

        use more TOOLS_WARN_EXCEPTION
        
        so we get more complete information when something goes wrong
        
        Change-Id: Ia73623f748b0779cf80b0086bd8258791590e9ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [d7e0247ed43091172c2cc3827399bb111416d617]

        Run clang-tidy with misc-unused-using-decls on modules [s-t]*
        
        To remove unneeded using declarations.
        
        Via the simple script:
        
        for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
            clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
        done
        
        Change-Id: I596299084471b2904548d23875866f1583b00b2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150610
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [20c86bd1059b54915190ce2e3dd39206d293aced]

        tdf#153806 a11y Allow opening context menu of fav/recent char w/ keyboard
        
        This is similar to
        
            commit 1f437264084fd173116965fa4d856aeafdfe7a98
            Date:   Sun Apr 2 00:36:44 2023 +0300
        
                tdf#153806 a11y: Allow opening context menu in special char dlg using keyboard
        
        , but now for the character views in the "Recent Characters"
        and "Favorite Characters" sections in the special character dialog,
        and thus addresses this comment from the commit message of the
        above-mentioned commit:
        
        > Adding support for opening the context menu for the
        > recently used and favorite characters further down
        > in the special characters dialog is independent of this
        > and would have to be added separately.
        
        Turns out that the position returned by `CommandEvent::GetMousePosPixel`
        is good for the keyboard case as well, is right in the middle of the
        char view widget.
        
        Change-Id: I9f55b99398d557b19263bf531f6a857d274d3d9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150815
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-23  Michael Weghorn  <m.weghorn@posteo.de>  [da4c97968080707c91a15f53d07e6d062977b19a]

        sfx2: Pass SvxCharView context menu pos as param
        
        ... and drop the `maPosition` member that was used for that
        purpose only.
        
        Change-Id: If449a12e6e8e37c28d7b2b139e20c4c307d41eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150814
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-23  Justin Luth  <justin.luth@collabora.com>  [deb1a14adb115710b5e40dd305dc5da4a4e3b065]

        tdf#97128 tdf#154703 docx export framePr: export frame textDirection
        
        textDirection attributes were lost on framePr round-tripping
        
        No existing unit tests were affected by/matched the change.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf154703_framePrTextDirection
        
        Change-Id: I2184b9350391f510c7a2e77096b080e05d3d62da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150820
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-22  Caolán McNamara  <caolanm@redhat.com>  [0ad8d644722228759abce42b0c11024e7460f6eb]

        tdf#154957 Revert "use OutputDevice clipping if its just a set of rectangles"
        
        it was an attempt at an optimization, but if it doesn't work just revert it.
        
        The non-antialias case also doesn't work so the reverted commit
        wasn't itself the problem but the existing path has some flaw I'm not
        going to invest in figuring out.
        
        This reverts commit ee0d5e7bb8614c50e71dd074b8440f412eb62ff3.
        
        Change-Id: I8d4f126e3bfe135d39a085f28cea6708ae8f833f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150773
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a17ec91d4278afcc1e54ecd85652949c2ff79634]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c4c5275e8d0d3bf5e590b4093b8bcc67b4d521e
          - Fix typo
            
            Change-Id: Ib11ff464bc2ce261aeefaa632a6fc8d3f51e6cd6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150806
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [df4255c315f8061fbe7b3771122926589be7dfad]

        Simplify lcl_getURLFromShellItem
        
        And make the URL returned for the item by system to be the preferred result.
        
        Change-Id: Ifbe8acc0aef8d656526d1ae64010fb6bfa68eefc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150784
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [8de1bf3674b5f5391ff1be229d99115107514877]

        Introduce sal::systools::CoTaskMemAllocated to use RAII for CoTaskMemFree
        
        Change-Id: I5553138bfc8dd989e68b8bcc2be981746e8c1e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150783
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [31486f92f9ec0c2446ad96a4e8228a15797b23ba]

        Drop some defines in scaddins
        
        Change-Id: I6155ad1c9e4627aad65ae1884e03491902c5d8a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150780
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-22  Justin Luth  <justin.luth@collabora.com>  [95c31968efaaefad548d300b216598f51d7a0746]

        NFC flatten/clang-format SwTabFrame::CalcFlyOffsets
        
        No functional change intended
        
        Change-Id: I63a052ad39e7f90a744225d06cc4000ac6fdd602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149466
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [0f6ec3939df6b0e3263fc07a2067bbbfc6421ac7]

        Introduce o3tl::toU converting wstring_view to u16string_view
        
        Change-Id: I5be9aa767020c2516984e47fcd0f51d4661fdf17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150779
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [ab55c7bffddc1a4c8f3d971d24bae297a15f3346]

        clang-format char16_t2wchar_t.hxx
        
        Change-Id: I5b86fb372702e3a6fdb3e4aa6846c4bc2e754307
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150778
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8e89ca42f3748e31fb600e6d69f96a6451e8240e]

        Fix typo in code
        
        Change-Id: Iba5e188204fafa4cd88282d001eea31f277fcc4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150768
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [932e79a43fbf8aa3b5682b3b8c12248970a91cd1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c0b0a8e0aad857b7089883f7c4fabbe8d9d64de
          - tdf#147105 Document the various new PDF export options in command-line
            
            Change-Id: Id89e27738d34322e7bab870a5fd247f988be76a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150797
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1de3c32016ea5509fdab773c984e061c286452a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5dfb463b6d96f4c2077d9565628d5674ec340550
          - Improve links between pages classification
            
            Change-Id: Ica92e7a69556c15aaf1a77ac6979df214b41672a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150765
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-22  Michael Weghorn  <m.weghorn@posteo.de>  [84183c84d86456e3c311b35150b1fc9b63a85561]

        qt a11y: Implement QAccessibleSelectionInterface added in Qt 6.5
        
        This adds an implementation of the
        `QAccessibleSelectionInterface` that was added
        in Qt 6.5 in commit [1]
        
            commit 9d16d5e2245c26e5746fd7609300b84a2a983457
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Oct 11 15:23:54 2022 +0200
        
                a11y: Add new QAccessibleSelectionInterface
        
        , s.a. QTBUG-105909 [2].
        
        The `QAccessibleSelectionInterface` is currently still marked as
        preliminary in Qt, so changes to the API *might* still happen
        and require an update of the implementation here as well).
        
        Quoting from the commit message of the above commit:
        
        > This interface is marked \preliminary until:
        >
        > 1. There is a working a11y bridge for macOS/VoiceOver
        > 2. There is a working a11y bridge for Windows/UI Automation
        > 3. There is a working a11y bridge for linux/AT-SPI
        > 4. There is at least one implementation (e.g. QAccessibleTable)
        >    that implements it successfully (second candidate:
        >    Qt Quick TableView [...])
        
        The AT-SPI bridge (point 3 from above) has been implemented in [3]
        
            commit ece2feee0317b582a56a0bfc783f11fe67d3edee
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Oct 11 15:24:04 2022 +0200
        
                a11y atspi: Bridge newly introduced QAccessibleSelectionInterface
        
        , an implementation for `QAccessibleTable` (point 4 from above) was
        added in [4]
        
            commit 092bbc9ad30c6cd7389053dc4b332cc762693676
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Oct 12 07:07:48 2022 +0200
        
                a11y: Implement QAccessibleSelectionInterface for item views
        
        . The Qt Gerrit changes for the macOS implementation (point 1 from
        above) and the Windows/UIA implementation (point 2 from above)
        are currently still awaiting review: [5] [6]
        
        To avoid duplication, just call the newly added methods
        `QtAccessibleWidget::selectedItemCount` and
        `QtAccessibleWidget::selectedItem` from the
        `QAccessibleTableInterface` methods
        `QtAccessibleWidget::selectedCellCount` and
        and `QtAccessibleWidget::selectedCells`, and
        therefore implement the former also for Qt < 6.5.
        
        Sample use of the interface from Accerciser's IPython
        console (with 18 cells selected in Calc and the spreadsheet
        object selected in Accerciser's a11y object tree; screencast
        attached to QTBUG-105909 [2]):
        
            In [10]: acc.get_interfaces()
            Out[10]: ['Accessible', 'Component', 'Selection', 'Table']
            In [11]: sel = acc.querySelection()
            In [12]: sel.nSelectedChildren
            Out[12]: 18
            In [13]: sel.getSelectedChild(0).name
            Out[13]: 'B1'
            In [14]: sel.deselectSelectedChild(1)
            Out[14]: True
            In [15]: sel.deselectChild(1)
            Out[15]: True
            In [16]: sel.selectChild(0)
            Out[16]: True
            In [17]: sel.clearSelection()
            Out[17]: True
            In [18]: sel.selectAll()
            Out[18]: True
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=9d16d5e2245c26e5746fd7609300b84a2a983457
        [2] https://bugreports.qt.io/browse/QTBUG-105909
        [3] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=ece2feee0317b582a56a0bfc783f11fe67d3edee
        [4] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=092bbc9ad30c6cd7389053dc4b332cc762693676
        [5] https://codereview.qt-project.org/c/qt/qtbase/+/451353
        [6] https://codereview.qt-project.org/c/qt/qtbase/+/451646
        
        Change-Id: Iac3c050448183610af3bd3b10a56e82d7d52cb91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138750
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dabe502c362f528a529e14a90abcc79d95d393be]

        Fix typo
        
        Change-Id: I59aea5a7b71d6ddf14d4d7d22b61bdc8ab01ae3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150767
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5c47997694adbaedfed5c20f861e493b4e07c134]

        Fix typo
        
        Change-Id: I943dbf7dd8c6ac138ab9fc16638a06b07dcace93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150766
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-22  Julien Nabet  <serval2412@yahoo.fr>  [8359aebefe63397001ffcc1b8369d2db81af2f21]

        Remove namespace prefix in manifest.xml (extras/pt-PT)
        
        since other languages don't have it
        
        Change-Id: I02dead7abcae1409f756d4daebbd23d4a70efbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150762
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-22  Rakielle  <rakielledev@gmail.com>  [9aee0383c3ebc3f267c99e19764728ba09c12d3a]

        Integrate msicreator into LO and generate installer
        
        Co-authored-by: Ximena Alcaman <alcamanximena@gmail.com>
        
        Change-Id: Iea2ea3b4bddc975a032592403727a4ff00db4a5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146843
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-04-22  Sarthak Roy  <sarthakroy2002@gmail.com>  [35787e07b7e83f7dcaa0c67830fcb4eded49c71f]

        workflows: Update dessant/repo-lockdown to v3
        
        * Changelog: https://github.com/dessant/repo-lockdown/blob/master/CHANGELOG.md#300-2022-12-04
        
        Change-Id: I7c4f7dc8f97dc59b3d689cf82e23365740c8fd6c
        Signed-off-by: Sarthak Roy <sarthakroy2002@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147495
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-04-22  Justin Luth  <justin.luth@collabora.com>  [d3a121cecfa8fb3c6f81b05822ba3309d77ab85d]

        tdf#154703 sw framePr: export knowing import wrap spacing limitations
        
        I noticed that the wrap margin spacing was being cut in half each round-trip.
        That is because MS Word ignores the spacing on LEFT or RIGHT alignment,
        while LO doesn't. Rather than monkey with layout, import just ignored
        the spacing. Sounds like a good idea - but needed to do the same on export.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf154703_framePrWrapSpacing
        
        Change-Id: I3878d1bdb98cf027fe95137939caf6901c7188a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150796
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-21  Justin Luth  <justin.luth@collabora.com>  [006b35d50024b1932d84380b5d2fec1f7066bccd]

        tdf#154703 NFC sw framePr: flatten TextBoxIsFramePr and fix typo
        
        Change-Id: I0fd30cb62c3676a1c7088636798bd4e6d3a18c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150071
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-21  Justin Luth  <justin.luth@collabora.com>  [66465fe341a25652cf0eb06b8e4e24e18ea8ed3c]

        NFC rename: const table::BorderLine2* rStyleProps (is not a reference)
        
        Added with commit ae61569eea0719a882010cfbb260a1a0d690d974
        Author: Jacobo Aragunde Pérez on Thu Apr 3 16:27:37 2014 +0200
            oox: Do not overwrite table style properties
        
        Change-Id: I8140e3a084f3f1e2d304a4ffc62897afa6427c4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150771
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-21  Justin Luth  <justin.luth@collabora.com>  [981c5b5421b5fc728e2b8140d7d52d8c8eb465e7]

        NFC tdf#154703 docx export: optimize/reorder "if TextBoxIsFramePr"
        
        -there is no need to run the long TextBoxIsFramePr function first,
        so start by evaluating the simple boolean case to avoid unnecessary processing.
        
        -reorder if/else to logically start with the small section.
        By doing so, it highlights that really we are doing something special
        when TextBoxIsFramePr and the else is the normal for anything else.
        
        Change-Id: Ic06826c2b6dcd5d89a6873784eb58b2d7bedaba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150770
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-21  Gabor Kelemen  <kelemeng@ubuntu.com>  [36db242816099bdc3ed2573df1230313056c552c]

        Run clang-tidy with misc-unused-using-decls on module xmloff
        
        To remove unneeded using declarations.
        
        Via the simple script:
        
        for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
            clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
        done
        
        Change-Id: Iccae38de41c809b39345ec6b31c9f6346e620f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150611
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-04-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [f712c531336b2c44636a35ad682913550640e0d3]

        loplugin:unnecessarygetstr extend to checking std::string::c_str
        
        Change-Id: I17398e2a6a31a2c98ba8e54b5c8045f22aee8759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-21  Eike Rathke  <erack@redhat.com>  [90cbe03a0bd65151c197d3d4aeaf48a696f13fad]

        Resolves: tdf#154941 MROUND() use approxValue of division to round
        
        Change-Id: I75394b1bdffbdadf051157e84afa06f30126fe23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150764
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-21  Caolán McNamara  <caolanm@redhat.com>  [1d0fadfd218b872ee5d4b07b88320c8f37667218]

        Resolves: tdf#154535 create the OXFormsDescriptor on-demand
        
        so we don't cause an unwanted Binding to be created unless we are forced
        to.
        
        Change-Id: Id78cbbb72ebd4e78b82a1ba614bbcb6488d04ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150769
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-21  Patrick Luby  <patrick.luby@collabora.com>  [b3f3d1447477428669a6d96dc2d6421de61204ba]

        tdf#154546 skip dispatch when presenter controller is not set
        
        mpPresenterController is sometimes unset and this will cause a
        crash when pressing the presenter console's Exchange button.
        
        Change-Id: Ibfc866d573ce0c535df5c8fdbd6d358353784854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [53f72f72ab501bb12bd6fd8ff9788b9a278c16bf]

        Fix apparent copy/paste typo in implementation name
        
        ...introduced in 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36 "i18npool: create
        instances with uno constructors"
        
        Change-Id: Ie9094ec5c58aa98cdb379051ecbad80638aae02a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150759
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [29b3265a6eee7aada7cb6d8f478bfeb0a32c006e]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries
        
        Change-Id: I4c2a838b7a88e3d21e230310c1a4057b427a7c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150756
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [dccd82b5ac47f44ea0297d301dc894c70bc793a2]

        MCGR: Reduce diverse GradientStyle enums to single UNO API one
        
        Change-Id: Ie0cd26a308a75ddead9451c53e874a39cc6eeb63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150705
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0293724d05953be608287629ed6178a7c05383a6]

        tdf#154578 sc fix: fill square is reduced when pulling selection with CTRL
        
        Return from DestroyAnchor in case of fill mode, because we should not
        modify the refmode or blockmode in that case.
        
        Change-Id: Id5b4b2207ddd9e1b1d82afc773d2d1b3e97dbbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150645
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1d341738d0902e3f71635b16d2d0f9ff63feb79]

        related tdf#154946: check syntax in git pre-commit hook
        
        Change-Id: If685f69227f98b194c124af0e28307d31edabf9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150752
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-21  Julien Nabet  <serval2412@yahoo.fr>  [50837fdd60d3d20b5025d94e243b09d92a166fb4]

        tdf#116451: XML Form: adding 2 values of decimal-fields gives wrong result
        
        Since, depending of the localization decimal separator may be ",",
        replace "," by "." before calling ::rtl::math::stringToDouble
        
        Change-Id: I461f3bdf83019d066735e10b3b6b6784e006bc7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150750
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2023-04-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [89cbbbe7f11b941be27b81eb50cfac614d195c2e]

        SwXShape no longer needs to extend SvtListener
        
        after
            commit 40babcfa637957bf7b59caa3cd12a630189e3e63
            tdf#154827 and tdf#154428 graphics anchored in Writer as character.
        
        Change-Id: Iad3ad440690fa9b8530f32e17a113b8365656a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-21  Miklos Vajna  <vmiklos@collabora.com>  [a1c5f77d3ee7c9907c8247aa0e896e07fe9427b6]

        sw floattable, crashtesting: fix PDF export of forum-mso-de-117064.docx
        
        Converting the bugdoc to PDF crashed Writer layout since commit
        ce3308a926f036b87515b8cd97d2b197063dc77a (tdf#61594 sw floattable:
        import floating tables as split flys by default, 2023-04-12).
        
        What happened is that we hit a case in the SwTextFrameBreak ctor where
        the frame had the "is in section" bit set, but the frame wasn't actually
        in a section, so when looking up that parent section frame, we found
        nothing, and later code assumed that we always find something. This is
        fine, the root of the problem was that in the non-legacy case
        GetFlyAnchorBottom() assumed the upper of the anchor frame is the body
        frame, so in case you had a protected section in DOCX, we mapped that
        into a Writer section, resulting in a body -> section -> anchor frame
        hierarchy.
        
        Fix the problem by improving GetFlyAnchorBottom(), so it works with the
        body frame of the page (of the anchor), not with the anchor's upper,
        which breaks in the section case.
        
        This only happened in the compatibilityMode=15 case, i.e. DOCX files
        produced by Word >= 2013.
        
        Change-Id: I94ed22701d275e7a9048c6154652d40268850c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150741
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-21  Franklin Weng  <franklin@goodhorse.idv.tw>  [ce4272c25426f0084e53735e80870b9339239078]

        tdf#153839 : Further handling for adding newlines
        
        before and after some tags as described in comment 7
        
        Change-Id: I6e2a6559a888d259c6d1cc848fad7d39a1ab653b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149280
        Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-04-21  Julien Nabet  <serval2412@yahoo.fr>  [593130b0df424a40983b67ce3224dbb40a69556e]

        tdf#154946: Draw/Impress Standard toolbar missing many icons
        
        Regression from 4cd7489f5898394730b794bdecbc29800cf23627^!/
        "Resolves tdf#143055 - Make Snap-to-grid easier to access
        Added to page context menu, standard toolbar, and line & filling
        toolbar"
        
        Change-Id: I3d7040f59a3c422e7f596fcd96cde88466bc2a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150747
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-21  Jean-Pierre Ledure  <jp@ledure.be>  [37a68d6ae3b32aa3d3c864f67a8c55b6eeb6964d]

        ScriptForge (SFDialogs) dialogs and controls are sized in APPFONTs
        
        Dimensioning a dialog in the Basic IDE is done
        by using "Map AppFont" units.
        Map AppFont units are device and resolution independent.
        One Map AppFont unit is equal to one eighth of the average
        character (Systemfont) height and one quarter of the average
        character width.
        
        A dialog or control model also uses AppFont units.
        While their views use pixels.
        
        This is confusing. It also complicates size prototyping
        with the Basic IDE.
        
        In ScriptForge, sizing and positioning a dialog or a control
        is done from now on in AppFont units as well.
        
        Additionally, X and Y positions accept now negative values.
        
        Compatibility with past is ensured: dynamic change or
        position and size is a new feature in 7.6.
        
        The change is valid both for Basic and Python user scripts.
        It requires a small change in the actual documentation
        (pixels => AppFontunits)
        
        Change-Id: Id80b0ccf473eb012b0a8c85d66f5a8ada9b26be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150704
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-04-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dd0b469af4b1ab49faf4b1688932da2370368e70]

        Colibre tdf#154825 Section editor icons
        
        Change-Id: Ia5cb61074d519b68416801ba2268dd11c49284f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150748
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-21  Michael Stahl  <michael.stahl@allotropia.de>  [ed5adb367ed0070d06312bce3ec3f44ec87a2361]

        sw: fix crashtesting assert on fdo44018-2.doc
        
        itrpaint.cxx:435: void SwTextPainter::DrawTextLine(): Assertion `!roTaggedParagraph' failed.
        
        The problem is that there are in fact 3 lines with the numbering bullet,
        which is a problem that existed since LO 4.1, but that only changed the
        WW8 import so it really exists all the way back to OOo 3.0.1.
        
        The SwNumberingPortion is created, then it is cloned for the insertion
        of the tab, then the 2nd one is deleted (which is expected as it is
        empty), then due to some ChkFlyUnderflow() SwTextFormatter::FormatLine()
        resets the m_bNumDone flag and the next line gets another numbering.
        
        The m_bNumDone flag must be reset if the numbering portion was deleted,
        but not otherwise.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I575947fdfb8786ad6d0f9e83636c39eb929a1b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150709
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-21  László Németh  <nemeth@numbertext.org>  [77ce7aaa30d20abc1e6221a60ce5e69a52bfaf19]

        tdf#153016 sw DOC: don't export automatic redline comments
        
        DOC format doesn't support comments of change tracking, so DOC
        export converts them to annotations. But skip this conversion
        in case of automatic redline comments of tracked annotations
        ("Commend added" and "Comment deleted") to avoid of double
        annotations (the original tracked annotation and the newly
        added annotation of the comment of the change tracking).
        
        Regression from commit 3a14b2040ecd95a23acbc3e8d0f8087505135f11
        "tdf#148032 sw: add redline comment for tracked comments"
        
        Change-Id: I563859d203886a7f81f6a9e1f164ea5524d80d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150735
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-21  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [e6a08aa351815b7be3bd094320c589026582454b]

        tdf#133363 sw DOCX import: remove extra auto space in mixed list
        
        Remove extra auto space even for mixed list styles. For mixed
        style lists, it has not removed all the extra space needed.
        
        See also commit 9cca15204af9cc44a8a9528ccf2f36616fb70e69
        "tdf#133052: DOCX import: fix top auto margin of subitems".
        
        Change-Id: I15e58616d5810ea57ac9339bdd8e4b5859f09c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150313
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-21  Sarper Akdemir  <sarper.akdemir@collabora.com>  [4232907e0a8a5bd87c673afd9df0031dce74d798]

        related tdf#154501: pptx import: push cell's RotateAngle after text
        
        It appears to matter whether "RotateAngle" property is set
        before or after insertion of the text for cells.
        
        It only renders correctly when it is pushed after the text insertion.
        
        RotateAngle appears to end up in the property set either way with
        correct values, so I don't really know why this is the case.
        
        Adds a unit test that covers rendering of vertical text in table cells
        on import from an example pptx file.
        
        Change-Id: Ifb8caa0b74920758fea2815b16dae7fd60587cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150712
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-21  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [5c98966b8318d526bdfbefc77831c051e946231f]

        tdf#153195 sw RTF import: fix negative indent of table in footer
        
        Fix missing processing of TBLIND keyword, which puts the table in
        the footer in the correct orientation, applying also the following
        conversion between RTF and OpenDocument/Writer to avoid regression:
        
        Left spacing of the table has different meaning in MSO and Writer.
        In MSO, left spacing means the indent of the text content of the
        cells, i.e. if table spacing is 0, the text content of the cells
        is vertically adjusted to the text content of the table, not to
        the table border. In Writer, if left table spacing is 0, the table
        border is vertically adjusted to the page text content. So for
        the correct conversion, left spacing of the table decreased
        with the left padding of the table text content during the RTF
        import. (See table padding on the Borders pane of Table Properties.)
        
        Reported and created unit test document by Gábor Kelemen.
        
        Change-Id: Ia3a781044a11d012f204a8ac3b160ad4c5dc896a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150022
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-21  Baole Fang  <baole.fang@gmail.com>  [56d2939e1928ae06fa74cb4b4be36cc0eaf3e702]

        tdf#154731: Hide Zoom & View Layout dialog
        
        Change-Id: I49f86a858826da39f9dd08580d5ab7796bc397a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150667
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [4ad6228e0d1f153fda94104258709aa6a8ca570e]

        Fix some getImplementationName
        
        ...to match the corresponding .component entry
        
        Change-Id: I56ac64be65740450df92f03aac4d2f4f447f08a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150694
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Miklos Vajna  <vmiklos@collabora.com>  [f703ad86984bcc5e2271484cf45d36e1057b21ad]

        sw floatable: teach the RTF export about SwFormatFlySplit
        
        Write \nobrkwrptbl unconditionally till we have a layout mode where
        floating/wrapped tables don't split/break.
        
        Change-Id: I0a19d034651a276dde8df391a5f1ca8ae39ddfed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150739
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [76e80a567fe41f885224d01c7dd22de7ee90606d]

        Fix OrcusFormatDetect XServiceInfo
        
        Change-Id: I7c54ec6de8c6bd3a5ed67809404eee65aa5af695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Miklos Vajna  <vmiklos@collabora.com>  [05425f73bfa41d3f7591461e2ad0beb4fafc39b4]

        sw floatable: teach the RTF import about SwFormatFlySplit
        
        - if the document has no \nobrkwrptbl, then ignore all floating table
          control word for now
        
        - map the rest of the RTF control words to OOXML attributes under the
          NS_ooxml::LN_CT_TblPrBase_tblpPr sprm:
        
         - \tpv{para,mrg,pg} -> NS_ooxml::LN_CT_TblPPr_vertAnchor
        
         - \tph{col,mrg,pg} -> NS_ooxml::LN_CT_TblPPr_horzAnchor
        
         - \tposy -> NS_ooxml::LN_CT_TblPPr_tblpY
        
         - \tposy{c,b} -> NS_ooxml::LN_CT_TblPPr_tblpYSpec
        
         - \tposx -> NS_ooxml::LN_CT_TblPPr_tblpX
        
         - \tposx{c,r} -> NS_ooxml::LN_CT_TblPPr_tblpXSpec
        
         - \tdfrmtxtLeft -> NS_ooxml::LN_CT_TblPPr_leftFromText
        
         - \tdfrmtxtRight -> NS_ooxml::LN_CT_TblPPr_rightFromText
        
         - \tdfrmtxtTop -> NS_ooxml::LN_CT_TblPPr_topFromText
        
         - \tdfrmtxtBottom -> NS_ooxml::LN_CT_TblPPr_bottomFromText
        
        Change-Id: I0b30d0eba8c1b7b6d3497334c958146717d06552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150738
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-21  Miklos Vajna  <vmiklos@collabora.com>  [ac519af951541b7313a4c98e1bee463bf47356be]

        CppunitTest_desktop_lib: disable 3 useless doc sign tests
        
        These would test how LOK APIs for signing editable documents would work.
        In practice, this is already broken, because the tests are disabled in
        the MPL subset builds but binaries tuned for LOK API users at
        distro-configs/CPLinux-LOKit.conf already use --enable-mpl-subset.
        
        Additionally these tests pass with an upcoming libxmlsec-1.3 for me
        locally, but not in a RHEL7 environment.
        
        So just disable the 3 tests till we have the time to fix them up in MPL
        subset builds, where they would be useful.
        
        PDF signing is a different story, that still works to some extent.
        
        Change-Id: Idcfda4c8c72353e710a65c5b0ee68d28e30a351b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150700
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [901360967dde5d3948d4a28d156ad526b0802ca1]

        Combine com.sun.star.cui.[Asynchronous]ColorPicker implementation decls
        
        f54ccf09a5073b6e544c976da68de0c9fc0bdf6c "Make Custom Color Picker dialog async"
        had added the additional com.sun.star.cui.AsyncColorPicker implementation entry
        (later renamed to com.sun.star.cui.AsynchronousColorPicker) for the same actual
        C++ implementation, presumably out of confusion.  (The implementation name
        "com.sun.star.cui.AsynchronousColorPicker" appears to not be mentioned anywhere
        else than in this .component file, so it shouldn't matter to drop it.)
        
        Change-Id: I80cc4f474d71493fb5bc125d9137595184cc6e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150644
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [a5e002442cba22f6d0806197e5a155353593bcd0]

        Fix some getImplementationName
        
        ...to match the corresponding .component entry
        
        Change-Id: I718cf71482923eec25f8c965e1a246fc2194a991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [5e9cafa29bd74e4ed9ca30b3150fe8a59aa671a5]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries
        
        Change-Id: I58e9f3a137b31b5867817dc0f87190573c54c3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150698
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [61717b215bc5d012e427f268855642a8f281027a]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries
        
        Change-Id: I280619b9c5660910ecc5386b39aa2c8d2ba23f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-21  Stephan Bergmann  <sbergman@redhat.com>  [ac7be7e96d80ce46ad9e4f958826dc0c856d78b2]

        Fix some getImplementationName
        
        ...to match the corresponding .component entry
        
        Change-Id: Id08644bcb49928594220bd3e49dd8b8578473ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [5cd9de202765e243e41416802f3e4486b8a96f16]

        Add a bit of consistency
        
        Change-Id: Ib201a8cec7c7a4a0a5cbd3d7e7d6156f8e8e59a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150717
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [efb3c57851d29440ef086c68a6c1ddbb8bc8fc00]

        tdf#154113: do not forget to split the outermost section frame
        
        ... when the inserted section node is not the first one.
        
        The very first frame, where InsertCnt_ puts content to, may already have
        some content after the insertion position. When an inner section ends,
        the current section needs a new frame, and the rest of content must go
        to that new frame. Previously, the new empty frame was created without
        taking the content move into account.
        
        This moves the split into the single place inside InsertCnt_, to avoid
        special processing in MakeFrames.
        
        Change-Id: I1335ebbc620af0f2b064141e8267e5bd1af0b195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150675
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-20  Tor Lillqvist  <tml@collabora.com>  [153263957b22e2d5f76f951366d44c182c22c260]

        Fix compilation with latest Xcode with iOS SDK 16.4
        
        Alternatively we could just remove lots of stuff that we apparently
        don't actually need from this file, including the problematic typedef
        and its uses.
        
        _Unwind_Exception_Class now gets typedeffed in <unwind_itanium.h> as
        uint64_t which effectively is the same as the unsigned
        __attribute__((__mode__(__DI__))) that is used here.
        
        Change-Id: Id96d43eb481ee4ae97dd315aa2fd741e5f627916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150702
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2023-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [877dea227e44e52f789517471c21615ff2d95716]

        return this map by const&
        
        Change-Id: I471bdc5ceb85d19332d32abc8469f90f28947eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [d9eea89a53248744e6560958b6353176850a5d2a]

        Resolves: tdf#152625 add a border around the tab_select_* icons
        
        so they are visible against a black background
        
        used inkscape and kept the existing black arrows are they were but put a
        larger one behind them with the light fill color I see in the other
        cursor icons and cleaned the resulting svg to match our current ones.
        
        created the pngs with, e.g.:
        inkscape icon-themes/colibre_svg/vcl/res/tab_select_sw.svg -o icon-themes/colibre/vcl/res/tab_select_sw.png
        
        then copied the svgs and pngs over their duplicates in
        icon-themes/colibre_dark[_svg] icon-themes/karasa_jaga[_svg]
        
        I'm a graphic artist now.
        
        Change-Id: Ic32db3cd5604c263de83f26143ee778218a80bda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Baole Fang  <baole.fang@gmail.com>  [91148ed5d5ef3428a39676bec672ccb5918ff19a]

        tdf#154732: Fix zoom bar in Draw
        
        Oringally, the zoom bar in both Draw and Impress show
        "Fit slide to current window."
        Now, the zoom bar in Draw is modified into
        "Fit page to current window.", while Impress still uses "slide".
        
        Change-Id: Iba25215d437b128f581bc5a8e6767f6b1f382be4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150650
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-20  Miklos Vajna  <vmiklos@collabora.com>  [6e8a89b762d625adc10227402de506c7a632e073]

        sw floattable: remove no longer needed DOC import heuristics
        
        Now that IsFlySplitAllowed() is true, bNoFly and related code in can go
        in sw/source/filter/ww8/.
        
        Change-Id: I5c3eb4002151af3436c596ccca72d5de7ec690dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150679
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-20  Stephan Bergmann  <sbergman@redhat.com>  [ab5e812e381b85ddd8bc4a3456e9b7695f824c95]

        Missing test dependencies
        
        > warn:vcl.gtk:1737406:1737406:vcl/unx/gtk3/gtkinst.cxx:23545: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: Failed to open file “instdir/share/config/soffice.cfg/vcl/ui/screenshotparent.ui”: No such file or directory
        > cppunittester: vcl/unx/gtk3/gtkinst.cxx:23548: void {anonymous}::load_ui_file(GtkBuilder*, const rtl::OUString&): Assertion `rc && "could not load UI file"' failed.
        
        and then
        
        > warn:vcl.gtk:1738858:1738858:vcl/unx/gtk3/gtkinst.cxx:23545: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: Failed to open file “instdir/share/config/soffice.cfg/svt/ui/scrollbars.ui”: No such file or directory
        > cppunittester: vcl/unx/gtk3/gtkinst.cxx:23548: void {anonymous}::load_ui_file(GtkBuilder*, const rtl::OUString&): Assertion `rc && "could not load UI file"' failed.
        
        and then
        
        > warn:vcl.gtk:1739896:1739896:vcl/unx/gtk3/gtkinst.cxx:23545: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: Failed to open file “instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui”: No such file or directory
        > cppunittester: vcl/unx/gtk3/gtkinst.cxx:23548: void {anonymous}::load_ui_file(GtkBuilder*, const rtl::OUString&): Assertion `rc && "could not load UI file"' failed.
        
        and then
        
        > warn:vcl.gtk:1741504:1741504:vcl/unx/gtk3/gtkinst.cxx:23545: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: Failed to open file “instdir/share/config/soffice.cfg/svx/ui/sidebarstylespanel.ui”: No such file or directory
        > cppunittester: vcl/unx/gtk3/gtkinst.cxx:23548: void {anonymous}::load_ui_file(GtkBuilder*, const rtl::OUString&): Assertion `rc && "could not load UI file"' failed.
        
        Change-Id: I0ebdbbaadbf5cec7c86d24b2603537d93db3738b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150690
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-20  Stephan Bergmann  <sbergman@redhat.com>  [6413e3060be3646279a50342df64eafa626552e7]

        Fix some getImplementationName
        
        ...to match the corresponding .component entries
        
        Change-Id: Ic5286d4969635bee5e606dcf186fbc7b297263c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-20  Julien Nabet  <serval2412@yahoo.fr>  [bf770e860382ff8b6483b820a6dacb55f1cd5c68]

        Typo: nCurentPos->nCurrentPos (connectivity/sqliterator)
        
        Change-Id: I6580e81a8a792ff98e1b8594ed79bd77b684b719
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150684
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-20  Justin Luth  <justin.luth@collabora.com>  [06c61d3581d95354d627c7de1a7d97b62c8f61c6]

        tdf#154817 sw UI: no hatch/gradient name if not selected
        
        This fixes a LO 7.2.0 regression caused by
        commit 3f6797c29e9672eba354400f24a669244fd746c0.
        
        A unique name was being created for gradients and hatches
        every time the paragraph dialog box was OK'd,
        even if the Area tab was not selected or natigated to.
        
        Only create the name if the gradient or hatch is actually
        selected as the fill type.
        
        Change-Id: I088954db07d025570b0f5ecd5785020052c6f1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150669
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-20  Julien Nabet  <serval2412@yahoo.fr>  [04d7c46b0585a730452b8b5f2ed010096df9a3a8]

        Typo getCurentSfxFilter->getCurrentSfxFilter in sfx2/filedgimpl-helper
        
        Change-Id: Ia428e81e9ebefcac521354d1eccb39f891fa9656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150685
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [40babcfa637957bf7b59caa3cd12a630189e3e63]

        tdf#154827 and tdf#154428 graphics anchored in Writer as character..
        
        ..become anchored at paragraph when reopening the document
        
        regression from
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            ref-count SdrObject
        
        This used to work by accident, previously, the SwXGroupShape that we
        need would get created and destroyed and handful of times, and then
        properly created.
        
        Now, however, the first time we create it it sticks around, which means
        it does not get the m_pFormat field configured correctly.
        
        Fix this by removing the caching of m_pFormat from SwXShape, and just
        fetching it from the model when we need it.
        
        Change-Id: I10fe2ad0b877b3d928d5288e73cfed373b27a506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150687
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-20  Julien Nabet  <serval2412@yahoo.fr>  [54c30f2f9b30b2da5483f0a9dd98fbb41baa9bf5]

        Typo: GetCurentItemData->GetCurrentItemData (in cui)
        
        Change-Id: I5adaa6193482ef722396206269aaea57224502a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150686
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-20  Eike Rathke  <erack@redhat.com>  [df8ae4fddb77f5621f651f05e72f8c2bd4ae111b]

        Related: tdf#154915 #NULL! is not an "Internal syntactical error"
        
        ... but "Error: No code or intersection".
        
        Change-Id: I8c161e6553084fc849092f689273cbe181033e22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150654
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-20  Maxim Monastirsky  <momonasmon@gmail.com>  [0ed12710d743e12501292d688caf6e4a72f16376]

        sc drawstyles: Avoid styles for detective shapes
        
        Those are fixed shapes with fixed formatting, and not
        supposed to be changed by the user (with the exception of
        their color via Tools > Options... > LibreOffice > AC, but
        that is a user profile setting, not a document formatting).
        So we need to undo the setting of the default style, which
        happens by default for all created shapes.
        
        Change-Id: Id48b4e9fb9b84008f154a7277f17ec00156ccc76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150659
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [6c0ce7f7124ea7d91eada9a544c52235770fa255]

        MCGR: Correct creation for Gradient-Previews
        
        Change-Id: Iafadcaa93660317d65c8f45940653273b562f37e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150651
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-20  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [68912948e376ce0b080a0d2a76dd9d951f8bcdf6]

        WASM: don't run gfx tests on startup
        
        Change-Id: Ibc04b5c1bb3972544fa605447c635b4af84f7584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150668
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-04-20  Gabor Kelemen  <kelemeng@ubuntu.com>  [890bf59e0a3507b009284d81632a3381fbe9a70f]

        Run clang-tidy with misc-unused-using-decls on modules [d-o]*
        
        To remove unneeded using declarations.
        
        Via the simple script:
        
        for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
            clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
        done
        
        Change-Id: Idd8aa3d3cfec456c4babb65e89af712051b4deb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150609
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b167bc073b6b83110242bfbace107f6978e5bca7]

        tdf#153190 Compressing tool calculates compression rate wrong on large images
        
        calculation used sal_Int32, which overflowed on large values, rather use
        floating point to do the calculation
        
        Change-Id: I15974c5bf785a800a8f71711acfa9895361bad7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150683
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-20  Eike Rathke  <erack@redhat.com>  [110dedfa00336de45fcb7462940f41378a9809e1]

        Resolves: tdf#154915 Let empty intersection error be #NULL! instead of #REF!
        
        Change-Id: I51f0bca8af2b283bfc72dfe75b04507c1d717014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150653
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [a687441abedfc659abf1cf48fa34c2f080369a4c]

        Resolves: tdf#154623 KEY_DECIMAL == GDK_KEY_KP_Decimal or GDK_KEY_KP_Separator
        
        Change-Id: Iade6d3f93ff7f9dcc35c5a04e21617df06955527
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150676
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ccd6415902ab2fd35658cb28258e0a7ce935d376]

        tdf#142978 Add quick fix action for missing alt text
        
        Change-Id: I09234e50def6b52b9a70081f31bb45b8d7e2cdd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150003
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-04-20  Miklos Vajna  <vmiklos@collabora.com>  [61be351ac83acec75788d2f79a9038486163160f]

        sw floattable: import floating tables from DOC as split flys by default
        
        To get wider testing.
        
        Change-Id: Id9d21aeca3bb9c00a5b4adfd45934a242e7559bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150597
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [3109c2a04998dc144d936d62824c832eba47b165]

        gtk[3|4] massage focus in GtkToolbar .ui desc to work for both cases
        
        Change-Id: I31adbe57eb19905b8447c1a3008b3805cf9520b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [e7a57620c5f9d3ad5e13f0052310fa4e0eb05f89]

        add truncate-multiline as our usual property
        
        and remove input-purpose as we don't use that, esp for
        auto-conversion to gtk4
        
        Change-Id: Icf2f9127b189b9966aac3fcadb09c2a01bd671f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [81a664b8e5e8a95a06b562873305422e00d02d50]

        using mnemonic-widget is more idiomatic for a simple label for something
        
        Change-Id: I46f9f9fba894819a7efafcfe8c47229c2b3cf8ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150656
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Caolán McNamara  <caolanm@redhat.com>  [d9eb808d6155efa80a1b47f3f688eb23e023c294]

        resave with latest glade
        
        Change-Id: Idc41a5f3d88b6e0fb68a045c59536213e38f8b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-20  Vojtěch Doležal  <dolezvo1@cvut.cz>  [9ce48c5992ca7ae2b68edfc1f558ccfa3289264d]

        Allow Copy Hyperlink Location in protected fields
        
        This change aims to make it possible to copy hyperlinks from protected fields.
        That includes showing command and fixing it's broken behaviour, which wasn't detectable because it was hidden.
        
        Change-Id: I119e7617fcd7261e437411c86d4c920931e9fe84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150070
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-20  Gabor Kelemen  <kelemeng@ubuntu.com>  [b4b3a0d40707f9ec126d7238b2974ac6ff7ee359]

        Run clang-tidy with misc-unused-using-decls on modules [a-c]*
        
        To remove unneeded using declarations.
        
        Via the simple script:
        
        for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do
            clang-tidy-12  --checks="-*,misc-unused-using-decls" "$i";
        done
        
        Change-Id: I95871cc0ae6f22a9684bae9d14ef0475aea17abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150608
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-20  Julien Nabet  <serval2412@yahoo.fr>  [4d8a46b819fb65ff13e306ac2c1580f87974bb6d]

        Related tdf#154769: XML form, detect misformed year/month/day
        
        From https://www.w3.org/TR/xforms20/
        "Data Binding Restrictions: Binds only the following list of datatypes,
         or datatypes derived by restriction from those in the list:
         xsd:duration, xsd:date, xsd:time, xsd:dateTime, xsd:gYearMonth,
         xsd:gYear, xsd:gMonthDay, xsd:gDay, xsd:gMonth, xsd:float, xsd:double, and xsd:decimal.
        "
        
        gYear: a number between 0 and 10000
        From https://www.w3.org/TR/xmlschema11-2/#gYear + https://www.w3.org/TR/xmlschema11-2/#partial-implementation:
        "All ·minimally conforming· processors must support nonnegative ·year· values less than 10000"
        -> we could accept more but if other use this minimal requirement, they may wrongly consider LO as buggy here
        
        gMonth: a number between 1 and 12, not some string like 'May' (see https://www.w3.org/TR/xmlschema11-2/#gMonth)
        
        gDay: a number between 1 and 31, https://www.w3.org/TR/xmlschema11-2/#gDay
        
        The first test in lcl_getValueyear is due to the fact that a failing conversion with "o3tl::toInt32" also returns 0.
        So the goal is to consider this obvious case first.
        
        Change-Id: Ifd8106b55419093a0223cff6a0afb9ccd3aa5efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-20  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b12ff94a771db17843f642a82820b2864bec4744]

        introduce sw::FrameFormats<>
        
        - a drop-in replacement for SwFrameFormats
        - ... but strongly typed sw::FrameFormats<SwTableFormat*> returns
          SwTableFormats
        - replace in SwDoc for GetTableFormats
        
        - also: use tags to name indices, lose the references to them as members
        - add an explicit Rename() member to allow both SwFrameFormats and
          sw::FrameFormat<> to be updated if a format is rename. This should be
          removed once all SwFrameFormats have been moved to sw::FrameFormats<>.
        
        - Ultimately it seems like a few linear iterations of the table formats
          can be replaced with an index-based accesss by name (in a follow-up).
        
        Change-Id: I1c49d64621104c964c95c6da0c84e01ee7f97028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150243
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-04-19  Caolán McNamara  <caolanm@redhat.com>  [3ec73488e447a693a14a773a7fb96938036c0324]

        Resolves: tdf#154912 make double-click to expand rows the same as arrow expand
        
        the arrow case does the necessary removal of the "dummy" entry which is
        necessary to get the treeview to indicate it has children, while the
        double click case skipped that step, so rearrange so both behave the
        same.
        
        Change-Id: I6161d786cd58b0eea53152074dff2b035c621e7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150643
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [4409cd197dfb1fab05c0285f3ae17a107c99b77e]

        MCGR: 2nd corrections/adaptions to MCGR
        
        Adapted handling of 'border' argument from our gradients
        for oox export, so that it looks the same.
        
        Also added quite some cases to peserve in-between
        GradientStops for current UI implementations to be
        able to edit the gradients as usual without losing
        the in-between GradientStops.
        
        While we will not be able to modify these, we are
        at least able to modify all the other gradient
        attributes, including start/endColor.
        
        Done this for TransparencyGradients, too.
        
        Also moved more stuff to the gradient tooling in
        basegfx.
        
        Change-Id: I6e94011bbf3715baa1401ab97e5b59811298342f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150577
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-19  Julien Nabet  <serval2412@yahoo.fr>  [730b329b51797254aca58843ad7937ee7662cf7f]

        tdf#154909: Assertion dont select when frozen in sw/redlndlg.cxx
        
        relevant part of bt:
        6  0x00007f9968f0b3b0 in (anonymous namespace)::GtkInstanceTreeView::make_sorted() (this=0x55a0e2935d20) at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:15222
        7  0x00007f99438be35e in SwRedlineAcceptDlg::InsertParents(unsigned long, unsigned long) (this=0x55a0e2846f50, nStart=1, nEnd=1) at /home/julien/lo/libreoffice/sw/source/uibase/misc/redlndlg.cxx:932
        8  0x00007f99438bf72b in SwRedlineAcceptDlg::CalcDiff(unsigned long, bool) (this=0x55a0e2846f50, nStart=1, bChild=false) at /home/julien/lo/libreoffice/sw/source/uibase/misc/redlndlg.cxx:557
        9  0x00007f99438bab7a in SwRedlineAcceptDlg::Activate() (this=0x55a0e2846f50) at /home/julien/lo/libreoffice/sw/source/uibase/misc/redlndlg.cxx:416
        
        Full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=186793
        
        It seems there can be several levels of freeze since the caller of make_sorted() does:
         930     rTreeView.thaw();
         931     if (m_pTable->IsSorted())
         932         rTreeView.make_sorted();
        
        so I would have supposed it's not frozen.
        
        Change-Id: Ia1ce00aaa09efed05f614ca57cfe11cacf2da4b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150642
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2c7a6bd572644b928704f6cb3696b568ac0aba1]

        loplugin::unusedmethods
        
        Change-Id: I6a07860edb13588b83345babeb53675aedc43f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Sarper Akdemir  <sarper.akdemir@collabora.com>  [fcf776a09a2c5cd692480c8ec4a678e3d04739c9]

        tdf#150020: pass transform and scale matrix for the table shadow primitive
        
        Shadow scaling related bits in createEmbeddedShadowPrimitive, requires
        the ObjectMatrix with scale and translate.
        
        Pass these in for table shadow creation too.
        
        Change-Id: I28c30fe49d3c90e3ca03fb5294ca97eb5ba22773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150639
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [695f08911f40ab8d457c7c7e37bf87bb301ef98d]

        tdf#154818 - Find bar: remember and reuse last search string
        
        In addition, the search items are rearranged to their usage order.
        Change-Id: I4f4bdfd869a981726ef84060e93c178502eaefef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150485
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-19  TokieSan  <eltokhy@aucegypt.edu>  [be1fe4418caa8c26ea53fe1f9acbe36096d5e3a9]

        tdf#150652 Column Type being disabled makes UX unintuitive
        
        Columntype is no longer disabled by default.
        
        Change-Id: I173ec35363278b397a2727cff234c0b4d936ff99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149630
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [02794cc8c2054f4030c2e0b3dd31976cab53dfcf]

        Update git submodules
        
        * Update translations from branch 'master'
          to 1d2b3738b883c63406b69201713c4c702f4eae4f
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I24f01a149404b4ed23b7800e680e5f9d1798345c
            
2023-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ad6fb09ba98d19d0cc3385b34ac8565d8620341]

        loplugin:finalclasses
        
        Change-Id: Ic2599da33b698400b6e52a7f666508c8cd947321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150606
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd39a53cc745ac1b8f25f59df7328909c3da3132]

        loplugin:finalclasses in sw
        
        Change-Id: I0b68920bb82bb9c096f4ee2e3532e4588302dc8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150605
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8032624177c8ea8a10d0687b410ae9433fdf1481]

        loplugin:finalclasses in sd
        
        Change-Id: I0a8c94e86503a0a1006a4fc34ab0a293f59f3429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150604
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Miklos Vajna  <vmiklos@collabora.com>  [cfa463cc5446e72a06db5a457bf4d50d4173f31e]

        sw floattable: fix CppunitTest_sw_ww8export2's testTdf80635_pageRightRTL
        
        Assert that the fly is aligned to the right of the page instead of
        testing it's not floating (even if sprmPPc is present in the document).
        
        Change-Id: Ibf160d02ca6ee997edf6232e5569c90d9b570c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150603
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [a7e1924a694e3a8616aa2db41ab08e0d80a51e5b]

        sfx2: fix crash in StyleList::CustomRenderHdl
        
        GetFamilyItem() might return nullptr
        See https://crashreport.libreoffice.org/stats/signature/StyleList::CustomRenderHdl(std::tuple%3COutputDevice%20&,tools::Rectangle%20const%20&,bool,rtl::OUString%20const%20&%3E)
        
        Change-Id: I099f045232aac710c4f26148de5e798d00ecc7ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150602
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-19  Caolán McNamara  <caolanm@redhat.com>  [8550aff56cec3fbe3a4b8c753d6869d0ad94f702]

        Resolves: tdf#104011 add a default CellRange argument in dialog editor
        
        so the form combo box can be added without exception, likely either a problem
        from:
        
        commit 9cff030fa15f89fa1009fbb3827ab11c43c20b04
        Date:   Mon Dec 5 09:56:17 2011 +0000
        
            add some form control support for basic dialogs
        
        or:
        
        commit c0d6bc75b223e9e477ef3669f7dc4abec703ecf6
        Date:   Fri Jun 5 14:52:44 2015 +0100
        
            Resolves: tdf#90361 CellValueBinding/CellRangeListSource need WithArguments
        
        Change-Id: I80e670840195a6725a9fdedc024f9763ad12ffe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-19  Maxim Monastirsky  <momonasmon@gmail.com>  [0f6e6e82a4a693a6970540db6e98d0302f3fefa6]

        sc drawstyles: Fix export of transparency
        
        Change-Id: I1abf277223718ae2d650728e5bd141372a771a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150590
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [b28fd940ca46828be624679863364b4db89dd38c]

        libxml2: upgrade to release 2.10.4
        
        Fixes CVE-2023-29469 and CVE-2023-28484.
        
        Also: SAX2: Ignore namespaces in HTML documents
        
        which is probably the reason why one test fails, so switch it to parsing
        XML:
        
            HTML parser error : Tag reqif-xhtml:div invalid
            <reqif-xhtml:div>
            HTML parser error : Tag reqif-xhtml:table invalid
            <reqif-xhtml:table cellpadding="2" cellspacing="2">
            ...
            reqif-table.xhtml:
            C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/test/source/xmltesttools.cxx:195:testReqIfTable::Import_Export
            equality assertion failed
            - Expected: 1
            - Actual  : 0
            - In <file:///C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/tempdir/lu134607bxu8q.tmp>, XPath '/html/body/div/table/tr/th' number of nodes is incorrect
        
        Change-Id: Icc161b39515c996193366bc777a67eca79e4e892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150544
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [7ec4e29ec5d7063b9e9a9e9ea6c1e18579c48218]

        basctl: fix crash in EditorWindow::Command
        
        GetWheelData returns nullptr if  mnCommand != CommandEventId::Wheel
        
        Change-Id: I57b30cc137b2f56e4295d49d0163ad95323201ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150598
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-19  Miklos Vajna  <vmiklos@collabora.com>  [115a4eb944f6a49def1ba8e826c3258389aeab10]

        sw floattable: fix CppunitTest_sw_ww8export2's testTdf80635_pageLeft
        
        Assert that the left of the floating table is around the page edge, not
        some larger value from the left of the body frame.
        
        Change-Id: Ibb5ddf64706dc2296b0aaf2273d216ee63fae63f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150600
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1e273de12710eabf908495d341311da93701868f]

        win/aarch64: fix offset loading simple values into the registers
        
        the stack variable doesn't point to the beginning of the array with the
        values, instead the code creates a large general purpose register array (gpr)
        with the floating point register (fpr) and stack just being offsets in
        that one.
        bridge isn't fully working with that fix yet, still some wrong pointers
        ending up in the interface reference
        
        Change-Id: I6f1e5f84f84aff34663090c20fe70d65e0a7a334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150578
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-19  Noel Grandin  <noelgrandin@gmail.com>  [e5e4472e4ebe0f84087cfaa551e3fc28e94fd399]

        use more concrete UNO type in SwFieldType
        
        Change-Id: Iffb0ffad6daf102299fa7ce072bfc117cdf38b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Caolán McNamara  <caolanm@redhat.com>  [07179a5a5bd00f34acfa8a3f260dd834ae003c63]

        add a route to get calc Floating Frame links under 'manage links'
        
        much harder than writer because the organization and ordering
        of properties and object activation etc is different.
        
        This ended up ugly, but functions.
        
        We set FrameURL before AddShape, we have to do it again later because it
        gets cleared when the SdrOle2Obj is attached to the XShape.  But we want
        FrameURL to exist when AddShape triggers SetPersistName which itself
        triggers SdrOle2Obj::CheckFileLink_Impl and at that point we want to
        know what URL will end up being used. So bodge this by setting FrameURL
        to the temp pre-SdrOle2Obj attached properties and we can smuggle it
        eventually into SdrOle2Obj::SetPersistName at the right point after
        PersistName is set but before SdrOle2Obj::CheckFileLink_Impl is called
        in order to inform the link manager that this is an IFrame that links to
        a URL
        
        Change-Id: I67fc199fef9e67fa12ca7873f0fe12137aa16d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-19  Miklos Vajna  <vmiklos@collabora.com>  [eb65f881da9c63636bc07eca735fd2bc01854fd6]

        sw floattable: fix CppunitTest_sw_ww8export2's testTdf80635_marginRTL
        
        The rendering is unchanged, but now the fly is positioned, the inner
        table doesn't have an own orientation. Also, this way the exported
        result is correct, so assert that, too.
        
        Change-Id: I158a856fd1e3712749867e6882b36974c0dfc3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150592
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-19  Noel Grandin  <noelgrandin@gmail.com>  [55adcc8d5671c2710b22d25866b9ce90cc8bedc9]

        use more concrete UNO type in SwTableAutoFormat
        
        Change-Id: I5c36a268a76afcf7af5829dc7f873f4410f68298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Noel Grandin  <noelgrandin@gmail.com>  [7f3df1a07dd55ebff1c9c572d3ec93e06dfe854b]

        use more concrete UNO type in SwXTextTableStyle
        
        Change-Id: I19b556a5fc2ee9f475478b16e228aa3670146551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150587
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Miklos Vajna  <vmiklos@collabora.com>  [ecb76e447891fb35c599abf36415952ea700561f]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfOleData
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: I96ab2055c154ebd464b930fc4c6808ffbc12bda0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150585
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-19  Noel Grandin  <noelgrandin@gmail.com>  [6f6a31d3e3b2ff113d5cc3a1ea960059cf09ceae]

        use more concrete UNO type in SwBoxAutoFormat
        
        rather than hiding the relationship behind XInterface
        
        Change-Id: Ie5e6e527d39ab2b4a26ae7830a196b354d2a6f04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Julien Nabet  <serval2412@yahoo.fr>  [3b4982b9c702002072dc3a9f7755f820eada08e7]

        Related tdf#154769: XML form, detect misformed date/datetime/time
        
        Change-Id: Ied859703f906ef97c70be4518974ca6a0e482573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150582
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4396c1a2294d6904b5aa808a1f970a2586d63962]

        sw: rearrange ThemeTest - add checks for fill, line styles
        
        Change-Id: Ia3fd9b6d608e83dcada03244c7347725046fdbea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149362
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-19  Maxim Monastirsky  <momonasmon@gmail.com>  [61b41646c5a93ca24f2c9f143cdb0da2c9258989]

        tdf#154883 Set doc as modified on applying table style
        
        Change-Id: I2a20f35f8b6730f256216cea718ac9020347f119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150584
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Caolán McNamara  <caolanm@redhat.com>  [bafec47847a0b9697b3bbe9358e53f8118af3024]

        create the FloatingFrameShape in a separate step to inserting it
        
        this is derived from the path taken by the AddShape(const OUString&)
        function for this case. No change in behavior is intended.
        
        Change-Id: Id09ae0c65a55a37743ad7c184070fb8dd97d8a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Caolán McNamara  <caolanm@redhat.com>  [02379929bd0e1d1676635f0ca1920422702ebb7c]

        allow SvxOle2Shape::resetModifiedState to survive having no SdrObject
        
        Change-Id: Iea059262c124e3f44249e49b4189732310d28156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ebcd77c9ea2550d4082abf42d35a95bff72a40a7]

        This is redundant
        
        Change-Id: Ie01bc8f817022585939338d88f850b24ac4e9091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150565
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [90d6d7bb71a4961fc96d09833f5fefb77897f9f3]

        sw: these test should also check the export
        
        Change-Id: I4b6a42454c186b17bf35c204dae1e051bb401b84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150580
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [6f36e44f248c8e3705779d6692daaf79865a1378]

        sw: fix divide by 0 in SwFlyFrame::CalcRel
        
        https: //crashreport.libreoffice.org/stats/signature/SwFlyFrame::CalcRel(SwFormatFrameSize%20const%20&)
        Change-Id: If7a1919a2829bbec3292b3aa5f7f719c5ba0beef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150579
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Sarper Akdemir  <sarper.akdemir@collabora.com>  [c27946fb157fe46fbfaefbe93f2c6794b1af4411]

        tdf#150020 pptx import: handle algn for outerShdw
        
        Introduces RectangleAlignmentItem that holds a value of the enum
        model::RectangleAlignment.
        
        Introduces SDRATTR_SHADOWALIGNMENT that holds alignment for a shadow.
        
        Implements import of algn for outerShdw.
        
        Makes the alignment considered while the shadow is being scaled.
        Also adds a unit test that covers this.
        
        Change-Id: I8f4eaed5f0d9428a7f405c65f19237f9e70ca151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148934
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [be7ce49f33035fcd289a5ffc7a2307bd9a566780]

        sw: fix divide by 0
        
        See https://crashreport.libreoffice.org/stats/signature/operator/(Fraction%20const%20&,Fraction%20const%20&)
        
        Change-Id: Ia93e2969d6eb0bde71c8419f2aa90bb7aa231f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150553
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-18  Stephan Bergmann  <sbergman@redhat.com>  [4b3308a8c24d71c30145c93411fab12c66660b5e]

        Avoid NullPointerException
        
        ...when dispose is called without a preceding call to initialize (as would
        happen with an improved CppunitTest_services)
        
        Change-Id: Ic632d736ecb27509b092ef526cf0dfc964023663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150576
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-18  Mike Kaganski  <mike.kaganski@collabora.com>  [77441b237db98d6577c8799c0c636839855c5c52]

        bApres -> bAfter
        
        Change-Id: Iac6965fa7695e9123b7861add6e4425bb31b79ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150574
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d62a54d151f32007c1cb1c7f729b777dbdb73cc]

        formula: fix crash in FormulaDlg_Impl::UpdateSelection
        
        m_pFuncDesc can be nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/formula::FormulaDlg_Impl::UpdateSelection()
        
        Change-Id: If8a95bef8b0a8a03ffe63041409ee7c1cf322b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150550
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Chenxiong Qi  <qcxhome@gmail.com>  [10fac0f7f7cdc66d9d1ee5e5bffbeb82973b733a]

        tdf#143123 Port DevelopersGuide/FirstSteps/HelloTextTableShape to Python
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: Ifb5639369c4af1db27ccb5a93dfad093ce7403b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146819
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e39d4921bcd06836d5b28dc23628da41bcf463f7]

        vscode: add Cygwin terminal profile and config for VS debugger for Windows
        
        and also fix the gdb helper path for linux in one of the launch
        configurations, it used instdir for both the solenv as well as instdir
        paths.
        
        Change-Id: I2d2ad955e4c1d386071edc50af8fd0bdcffc66e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150051
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [11a25339abfb957ea51614b67bbff26cb606f3a2]

        tdf#154269 - Respect FindReplaceRememberedSearches: add unit test
        
        Change-Id: I72db7964b512a40c4b81b218b2cae60ab34d47c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150522
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [2c01d4448a8059b5f335d07347b9e85a0d0031d8]

        tdf#154773 Fix Symbols dialog in dark mode
        
        Change-Id: I92029f1d19c7545a4122b125ae69ab5964e562d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150209
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-18  Caolán McNamara  <caolanm@redhat.com>  [d68d1876216f7d69830fdc16d4a1dd9d9952c2df]

        reduce copy and paste a bit
        
        Change-Id: I65cb71d44828e0c0d738c4192c39a697513bc6e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Caolán McNamara  <caolanm@redhat.com>  [e535a2bd67b50cc529115e9ac9e346140ea164dc]

        Resolves: tdf#154870 label grayed out when it should not be
        
        Change-Id: I1d84434622f09e6e91bea550f5dc0321cb7d89ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150548
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-18  Miklos Vajna  <vmiklos@collabora.com>  [1ee5ae0eec2d1c673af6b8f18a2c36b4d1e7fb70]

        sw floattable: fix CppunitTest_sw_ww8export2's testTdf80635_marginLeft
        
        The rendering is unchanged, but now the fly is positioned, the inner
        table doesn't have an own offset.
        
        Change-Id: I6ffaeb2672e04b3b855cbcb63ceba6506b970399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150545
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [10f2e8363076fb9217b4fc8acf12b4d9c13328cc]

        tdf#154803 - Check if range is entirely merged
        
        Regression from commit b9411e587586750f36ba9009b5f1e29fe461d8b5 where I
        missinterpreted the check to get merged cells.
        
        Regression:
        tdf#147122 - Return cell object when a simple selection is merged
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145378
        
        Change-Id: I2e39599a206cf102b1da8c7fc4bb2d8c0a4b106c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150412
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-18  Heiko Tietze  <tietze.heiko@gmail.com>  [898b77b645cc8b3911bc0722f538ad61f12835c8]

        Solve or suppress accessibility warnings
        
        Change-Id: Ice45231375e659ea25907c1af0a48ca77d3cb63b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150421
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [aff9ea4c77e3cdcee6713c84aca26e5b195c4f3d]

        fix brain malfunction
        
        in
            commit 01a3cc1e55034f7703219d4bbb209de7c37bf07b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Nov 29 16:09:10 2022 +0200
            tdf#133343 collect autostyle prop names
            before scanning for autostyles. That way we can collect only the
            property state we are interested in, instead of all properties.
        
        where I apparently wrote the code at the beginning of the call-chain
        to collect autostyle prop names, and I wrote the code at the end of the
        call-chain to filter on those names, but I never hooked it up in
        the middle.
        
        (which just means that the initial commit had no effect at all)
        
        Unfortunately, fixing the middle part results in
        unit test failures, so for now, just revert it.
        
        Change-Id: Ia1d655f70d2f5a1656e910d45817c3c4627b85fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-18  Miklos Vajna  <vmiklos@collabora.com>  [2424fa9c601003a9778bbc3a9cf0f55d33ead6f1]

        sw floattable: fix CppunitTest_sw_ww8export's testTdf112346
        
        Assert the layout, not the doc model, then this still passes.
        
        Change-Id: I5172fbc97547310f26cdf364191f404d875b3ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150540
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-18  Michael Stahl  <michael.stahl@allotropia.de>  [5195530f3ac43f071bc5676fd7ad1a0adc63e9d8]

        xmlhelp: fix lots of deadlocks
        
        Not sure if any of this makes sense but it doesn't deadlock immediatly.
        
        (regression from comit 2c37a0ca31095165d05740a2ff4969f625b4a75b)
        
        Change-Id: I4a5e01acb06b56a78453900a143d36cad1156f21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150431
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [36213a2a0bcea9c9919218dedef854b199353aad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 289dce6420de9491969db0280e82bfac703dc5bd
          - Add data analysis Help page to Contents
            
            Change-Id: I5ea83e0bd4109fc703ad0941cc78b81ce3bb523f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150488
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [128c64fd110254577d31c5bd053aa98d8c0676ed]

        tdf#154754: sd_export_tests: Add unittest
        
        Change-Id: I0496bdb7893d944dc78b1038d64ec6c762ecceb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150517
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-18  Tünde Tóth  <toth.tunde@nisz.hu>  [23cb5a95e057060a47facad19ad150134aa0692b]

        tdf#147810 DOCX export: fix corrupt file with hyperlink and text box
        
        Remove m_startedHyperlink boolean, because the
        m_nHyperLinkCount is more precise in nested paragraphs,
        e.g. when exporting hyperlink combined with the export
        of the paragraph of a text box attached to the paragraph
        of the hyperlink, which caused corrupt DOCX file with data
        loss.
        
        Regression from commit 9835a5823e0f559aabbc0e15ea126c82229c4bc7
        "sw textboxes: reimplement ODF import/export".
        
        Change-Id: I94bcb64a756ba2c90360629640f667190fa45f3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149677
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-18  Miklos Vajna  <vmiklos@collabora.com>  [16b59cee44c7f728b2fe6d7b624c494f649ee79f]

        sw floattable, layout: don't split inside headers/footers
        
        CppunitTest_sw_ww8export2's testTdf128700_relativeTableWidth had a
        layout loop in the SW_FORCE_FLY_SPLIT=1 case.
        
        This seems to happen because the footer had a big floating table, which
        doesn't fit the anchor's upper, but adding more pages won't help the
        table to fit.
        
        Fix the problem by not trying to split floating tables in
        headers/footers.
        
        An alternative would be to filter this out at import time, but then we
        would loose the setting on DOCX/DOC roundtrip, which is not ideal.
        
        Change-Id: Ice97159563812acee823dbd00b364601db293ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150535
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-18  Noel Grandin  <noelgrandin@gmail.com>  [ac30e6bfb653490003d04f30bf2d5f8f857e572b]

        convert XmlShapeType to scoped enum
        
        Change-Id: I1fd3d995508eed507d07de11c4f60f05d075b84f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-18  Maxim Monastirsky  <momonasmon@gmail.com>  [a9a2ace53625a8fb3feb1c050648a875a98cb7a8]

        sc drawstyles: Comment shadow should depends on shadow attribute
        
        The shadow of comments differs from the shadow of normal callout
        shapes, as it shows only for the text rectangle. However the way
        it's implemented is weird: The shadow attribute is set to false,
        which turns off the "normal" shadow, and then the special shadow
        is drawn unconditionally. There is also a code that forces the
        shadow attribute to false on import, to handle some old files
        that used to have the shadow on.
        
        The confusion begins when one shows the comment, and looks at
        right click > Area... > Shadow, which (rightfully) shows the
        shadow as off, but doesn't align with what is visible on the
        document canvas. Moreover, the other shadow settings on this page
        do affect the comment shadow, but in order to change them it is
        needed to check the "Use shadow" checkbox first. But leaving that
        checkbox as checked will result with a double shadow being drawn
        for the text rectangle, and an unnecessary shadow drawn for the
        arrow part. The problem becomes now more visible, as there is
        a Note style listed in the sidebar.
        
        One possible approach could be to draw the special shadow only
        when the shadow attribute is on, and patch existing files on
        import to "shadow on" instead of "shadow off". But this will
        cause the "double shadow" problem when opened in older versions
        (unless the comment is hidden, in which case we used to override
        the shadow attribute).
        
        But now there's an opportunity for a better solution: As we
        assign the default comment style to imported comments, we can
        just clear the shadow attribute DF, instead of forcing it to
        some value. As a result, the "shadow on" attribute of the style
        will be in effect in newer versions, while in older versions it
        will fallback to the "shadow off" pool default.
        
        Change-Id: I4b35bc1e8e2e12ed35a82b0c2e9aabcf28b46270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150353
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Maxim Monastirsky  <momonasmon@gmail.com>  [90fbb14e517c95036a133697d7300fc662d1b8b5]

        sc drawstyles: Don't consider the default cell style formatting
        
        We no longer use the text formatting of the default cell style
        for new comments, nor we follow that style changes, so there
        is no reason to do that on import. And this formatting will
        be overwritten anyway in most cases with the imported formatting.
        
        (There is currently a bug in xlsx import that makes the author
        name appear with the default font in visible comments, and that
        case will look differently after this commit. However, the
        truth is that *both* old and new looks are wrong. The correct
        font can be seen in the temp popup when hovering the comment
        marker, or after copying & pasting the cell with the comment to
        somewhere else. But even if this wasn't a bug, it was *our*
        decision to use the cell style font, not something imported or
        done by Excel, so I believe we're free to change something like
        this.)
        
        Change-Id: I92b95d7dfcfb747144eb710c76ec5f755f70400f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150490
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Miklos Vajna  <vmiklos@collabora.com>  [68632a752ddac08d0bf0b3405fa767540afd7e80]

        sw: document SwFont
        
        Explain why it's not like SwFont would just derive from SvxFont
        directly.
        
        Change-Id: I78bd536654831836351029badcaa47e6cc81c7eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150529
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-18  Noel Grandin  <noelgrandin@gmail.com>  [94e505b9ffbeb1695393d5dea0da84a0bf887fba]

        no need to perform lookup twice in XMLShapeExport::seekShapes
        
        Change-Id: I833da530fdc43233e14482a17a60beadb6ef6043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1684730ccbbca83df4dcb07d4759eebebbc4d66]

        tdf#143200 assert when pasting a cell to a large-height range
        
        The values are unfortunately genuinely outside the range that our
        Fraction class can work with.
        So do the least-bad thing for now, and reduce the magnitude of the
        values until they fit.
        
        Change-Id: Iedc34e9767b3d4a502f5d84efcdebc96c6514cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-18  Stephan Bergmann  <sbergman@redhat.com>  [7c36c5fdfdfeab9d15ea733fe2a831cd4ff25d27]

        Some missing XServiceInfo implementations
        
        Change-Id: I1cf871b40f9f4020147dac0456ebeed3de0438e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150533
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-18  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [3c4f53bc19ab90a98edb75a2dc554c917e36ab11]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d7088d24df28bba2fdbab7d77a2e7151e3b4f0dd
          - These descriptions shouldn’t be imperatives with contractions
            
            Change-Id: I030e188834356511a64a243d5b38d413fd21667c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150534
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-18  Maxim Monastirsky  <momonasmon@gmail.com>  [0ee9501c0b7dc1a291715fff9c1934b1c08cb654]

        sc drawstyles: Assign the Note style to imported comments
        
        ... that don't have a style assignment. Typically in ods files
        created by older versions or by 3rd party.
        
        - For hidden comments this should make no difference, as we used
        to apply the default comment formatting as DF underneath their
        defined DF, just now we do that as a style assignment instead.
        
        - Same for comments from xlsx and xls files.
        
        - For visible comments from ods files created by OOo/LO, there
        should be no difference either, as such files typically include
        the shape formatting in them.
        
        - For visible comments from ods files created by Excel, there
        will be a difference, as Excel used to not include the full shape
        formatting (known to be the case with Excel 2007 and 2016; can't
        test any other version). This resulted with a weird look, e.g.
        a line instead of an arrow, a default blue fill color and too
        distant shadow, which clearly not how comments supposed to look.
        Moreover, the comment will turn to transparent after hiding or
        copying the cell, and will revert to the default look anyway
        with resaving. Given that we were already enforcing the default
        formatting for hidden comments and for foreign formats, I think
        it's reasonable to do that for visible comments too (and in
        general it's unclear to me why the ODF import treats visible
        comments differently than hidden ones).
        
        The main motivation of this change is to aid solving the shadow
        issue - see the next commits.
        
        Regarding the comment height change in the testCommentSize test:
        This does *not* mean there is a change in that comment's import.
        What this test does is to replace the existing comment with
        a new comment, and that use the default formatting instead of
        inheriting the formatting of the old one. But while the current
        default formatting is whatever defined in the Note style, the old
        default formatting was actually the draw pool defaults. This is
        because we used to apply the comment formatting as DF, and the
        relevant svx code (in SdrTextObj::NbcSetText) wasn't aware of the
        fact that part of the DF was considered as default in this case.
        Which means that this test was actually asserting a buggy behavior.
        
        Change-Id: I37723cce3c719ecaa9c57bef25bcb168e353c55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150489
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Maxim Monastirsky  <momonasmon@gmail.com>  [86cbbbccba19ba0433693e3e5c59c67e9dc6a003]

        sc drawstyles: Fix xlsx export for text attributes in comments
        
        Change-Id: Ic5b6099460bd5e978c04aff3233537059ce711b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150379
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Bayram Çiçek  <bayram.cicek@libreoffice.org>  [059f99991e8f291404addeba9341d2c4989976af]

        tdf#90253: Impress: make TextBox retain its height
        
        - [Impress] drawing a new Text Box and Vertical Text
        minimize itself to the height of one line.
        
        - This behavior has changed and inserting a
        new TextBox/VerticalText does not shrink itself to
        height of one line.
        
        - Unified some common Draw and Impress codes
        
        - removed unnecessary ImpSetAttributesFitCommon(pText)
        function, as ImpSetAttributesForNewTextObject(pText)
        takes care of the Text Box creations.
        
        - SID_ATTR_CHAR (.uno:Text)
        - SID_ATTR_CHAR_VERTICAL (.uno:VerticalText)
        
        Change-Id: Ia944c2b64d5b1fa6970f6afabf41d36bf1643efa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150377
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-18  Maxim Monastirsky  <momonasmon@gmail.com>  [3e4b8463f288d87f91cd5bc864d30ae02d4f5579]

        sc drawstyles: Maintain comment formatting with styles
        
        Up to now the look of comments was maintained with the comment
        shape's DF, with the default formatting being reapplied on
        import (for hidden comments), on changing Tools > Options... >
        LibreOffice > AC > Notes background, and on changing the
        default cell style, while keeping the user-applied DF to some
        extent. However, as we attempt to support drawing styles, this
        approach is no longer viable, as applying DF on top of styles
        at random times makes styles useless in the context of
        comments.
        
        (One might argue, that the look of comments should ideally be
        treated as an app view setting, and not as a formatting of an
        individual shape. This definitely makes sense, but has compat.
        implications, as both LO and Excel allow formatting individual
        comments (e.g. show a comment, right click > Area...). However
        we will probably do it anyway if we ever implement threaded
        comments like in recent Excel [1], as the callout shape based
        approach seems to not scale to it.)
        
        One way around it could be to explicitly disable any style
        interaction with comments. But this will be unfortunate, as
        styles have a clear advantage of being able to consistently
        maintain the same formatting for several elements, much more
        that the fragile approach of mixing the default formatting and
        user-applied formatting in the same formatting layer. Not to
        mention the possibility to define several custom styles. In
        addition there is a request in tdf#55682 to disconnect the
        formatting of comments from the default cell style, having a
        dedicated style instead, which I find reasonable.
        
        So this commit introduces a comment style, and uses it for new
        comments instead of DF, making it easy to format all comments at
        once. And a style based formatting is never overriden with DF,
        unless explicitly set by the user. Changing Tools > Options... >
        LibreOffice > AC > Notes background still has an effect in two
        ways: (1) Sets the default background of the comment style for new
        documents, and (2) if changed while a document is open, changes
        also the comment style of the current document. An undo action
        is also added, in case changing the current document wasn't
        deliberate. Changing the default cell style no longer has any
        effect on comment formatting.
        
        One unfortunate side effect of this change, is that newly
        created and permanently visible comments will lose their
        default look when opened in an older version. But there is not
        much I can do here, as older versions don't support styles, and
        I believe the advantage of using styles outweigh this concern.
        Hidden comments are not affected by this.
        
        [1] see https://support.microsoft.com/en-us/office/the-difference-between-threaded-comments-and-notes-75a51eec-4092-42ab-abf8-7669077b7be3
        
        Change-Id: I84215791b9e6ce393c6d979aa2b19ef70c76dff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150352
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-17  Balazs Varga  <balazs.varga.extern@allotropia.de>  [6feafa2c5a2c593b1852ac44e2ea88eb9375c01d]

        tdf#130199 sw Confirm deletion of hidden sections
        
        To enhance the existing discoverability of hidden sections
        via Navigator by a confirmation box when a hidden section
        is to be deleted.
        
        Also add an option to switch on/off this warning message named
        "ShowWarningHiddenSection". The default setting is on.
        
        Change-Id: I91a1a32524f8d8d8fd0f230c142654df4367e729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150231
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-04-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5713871497f81bd4b4196a217c9084f2db3e6614]

        Fix typos
        
        Change-Id: Idfb50721c4844de4354a4ab65d41b15529fe7c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [60022965ce3791e578468b366baf33c64338a388]

        Use move ctor here
        
        Change-Id: Ic20b91ee6d674c7fe5f08f07c3f29fc9fbaf5282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150524
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [c11463cdc5415707d05ab6da08736ff7212db4a0]

        tdf#154016: use ScopedVclPtr
        
        A regression crash from commit d79c527c2a599c7821d27cf03b95cb79e2abe685
        (Use IconView in SmElementsControl, 2022-06-01). Without disposeAndClear,
        the VirtualDevices leak; and on Windows this quickly leads to GDI handle
        10 000 limit killing the process (which is good, helping to track this
        kind of issues).
        
        Change-Id: I28e1ffbeb425fae3fdbd76b7873fef5c929b8e11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150523
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3de2980f198f4d592896f1bebae841ffbcc74c5e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c7b120a56135515df2a3f2a0ea74c2a5166de5b
          - Fix typo
            
            Change-Id: Ib52c112685d97f8cd684e42ba3b238ce39af81b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150509
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-17  Miklos Vajna  <vmiklos@collabora.com>  [3a759a0b0c9605732c95dfac6a3315ed48ec1076]

        Remove some unused includes
        
        Mostly com/sun/star/frame/Desktop.hpp is unused after inheriting from
        UnoApiTest.
        
        Change-Id: I71b75fa5c880337ff294583b96af09c90b5059c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150514
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [8daa8eef06fa485f5271503921585a3fbef26567]

        Upgrade external/boost to latest Boost 1.82.0
        
        <https://dev-www.libreoffice.org/src/boost_1_82_0.tar.xz> has been generated (on
        Fedora 38) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.82.0/source/boost_1_82_0.tar.bz2
        > $ printf 'a6e1ab9b0860e6a2881dd7b21fe9f737a095e5f33a3a874afc6a345228597ee6 boost_1_82_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_82_0.html>
        > boost_1_82_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_82_0.tar.bz2
        > Unpacking boost_1_82_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_82_0.tar.xz ...
        > Cleaning up ...
        > e48ab6953fbd68ba47234bea5173e62427e9f6a7894e152305142895cfe955de  boost_1_82_0.tar.xz
        > Done.
        
        * Updating StaticLibrary_boost_locale.mk is needed to avoid
        > workdir/UnpackedTarball/boost/libs/locale/src/boost/locale/util/locale_data.cpp:137: error: undefined reference to 'boost::locale::util::normalize_encoding(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
        
        Change-Id: Iff3f5249df0fcf75f5a50e7eb35ef64373af8184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150516
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [e7617af8b463e31faabde6e409cc347c0c648364]

        Silence clang-cl -Werror,-Wunused-but-set-parameter
        
        ...in work-in-progress code (see the comments starting at
        <https://gerrit.libreoffice.org/c/core/+/147023/7#message-b9f4dd2f674548b522d3d4e657ba4517af9ff333>
        "editeng: split SvxLRSpaceItem into 1 class per attribute")
        
        Change-Id: If0e85d20d9b9e5b3dee1445ee489227f57d214ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150476
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [a0c08ce6cf5e0cd88238fefb3b819305daf4005e]

        loplugin:stringadd
        
        Change-Id: I674655aa4bfe38675dd3c9d677a7d7c64b3eaac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150478
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [955b4aa7619206e2ae38127e3cfaecbf1d1d7e11]

        loplugin:nullptr
        
        Change-Id: Ibe555b1362e4a7a016d99449abca8354777c5bc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150479
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Caolán McNamara  <caolanm@redhat.com>  [13a2ca25e4b16a6ac310c03ec9b543c774a0df6c]

        Resolves: tdf#146068 don't crash when MA(central) lacks data
        
        Change-Id: I2c9b78f4d1a963bb71abb21068e61e6983ade777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Caolán McNamara  <caolanm@redhat.com>  [7773932ba7c4bafeed7fba0a5d87f75eed09f850]

        tdf#151560 don't crash on loading dubious fods
        
        Change-Id: Ib41b3a95dd3829e8d3eca61621257fdd416bd8dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Caolán McNamara  <caolanm@redhat.com>  [d405ddce1fca35e088d35805345571687c46ff5f]

        crashtesting: crash on export of forum-mso-de-102589.docx to odt
        
        recurses to death
        
        Change-Id: I4474de502df0924176cbe8d6c9244d0b73838458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [178832ef7139b9279a3ae0056eb11be9c476800e]

        oox: tcPr vert roundtrip, introduce interopability grab bag for table cell
        
        To properly roundtrip all possible values of <a:tcPr vert="...">
        
        + Introduce grab bag for table cell
        + on import: Store the unsupported values in the grab bag:
          + (e.g. wordArtVert, mongolianVert, wordArtVertRtl)
        + on export: if nothing is being exported from the doc
          model, export the value from the grabbag
        
        Also adds a unit test covering this behavior.
        
        Change-Id: I791ed2d992b0a554ef6da37200f027cffd8c5f2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149737
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [77655fc3dca05d4bb2366e67ccea228e3886bfe2]

        pptx export: consider RotateAngle for tcPr on export
        
        It appears the RotateAngle property is imported, even though
        it has no effect on how table cell is displayed right now.
        
        Let's export the property so that we are able to roundtrip
        the <a:tcPr vert="vert"> & <a:tcPr vert="vert270">
        
        Change-Id: Idc23f3b0677fdc5ed12fa5494f0f1823bb89683f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149545
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [1ccb5a63cd3f16f46c3d8cb7d86374805705804d]

        loplugin:stringadd
        
        Change-Id: I3bbb2df7b77ab971553b646690806385e5dea75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150482
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [dbbe5d0cd721a815df5e4cbf3215f291a423f2b1]

        MCGR: 1st corrections to gradient export, transparency
        
        Changed Alpha export from using Red component of
        used BColor too use luminance, that will be more
        safe if we evtl use same gradients for this in the
        future.
        
        Added evtl. needed inversion for gradient exports,
        also emulation of our 'axial' type.
        
        Change-Id: I245959bf1602174f978848e1a02444b4b105f896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150416
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [3b58e91c8a25917a2cf6c747f3d6ace27879f92a]

        loplugin:stringadd
        
        Change-Id: Ic44ff2f812fd74ae2cb1467ca0d420317b63a445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150480
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [1b7ced8e77910e7f44d726f48185f16bc2fb087d]

        loplugin:stringadd
        
        Change-Id: Id63306a86c955c1f00252c555a6c0faaed625c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150481
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [7b55e994338ab5e7d9056f84d1aa2989534f59fb]

        Normalize line endings
        
        Change-Id: I8daa44961ae7a92fc6bbc728e5387dc0b5e32f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150487
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [a2166dfd4175ed1da0b59e0b618b092d62ed3401]

        Avoid MSVC error C2039
        
        At least with VS 2022 Preview 17.6.0 Preview 3.0 and (if that makes a difference
        here) --with-latest-c++, the build started to fail now for me with
        
        > cli_ure/source/climaker/climaker_app.cxx(603): error C2039: '{dtor}': is not a member of 'System::IDisposable'
        
        Originally, in 4c937bbdbbfd954936fdc92c4b35d90c2233719e "#107130# new",
        TypeEmitter in cli_ure/source/climaker/climaker_share.h had been defined as
        
        > __gc class TypeEmitter : public ::System::IDisposable
        
        with an overriding Dispose member function (and no user-declared dtor), and the
        code in cli_ure/source/climaker/climaker_app.cxx had called
        
        >         type_emitter->Dispose();
        
        when done.  Then, in 6fa1a74ec4bb5820d1638ff3b872476f8652efe0 "convert climaker
        to new syntax", the definition of TypeEmitter had been changed to
        
        > ref class TypeEmitter : public ::System::IDisposable
        
        with a dtor instead of the overriding Dispose member function, and the code in
        cli_ure/source/climaker/climaker_app.cxx had been changed to call
        
        >         type_emitter->~TypeEmitter();
        
        instead.
        
        I have no deep understanding of the Managed C++/CLI stuff at play here, but it
        looks reasonable to avoid all this by not deriving from IDisposable (and relying
        on GC to clean up all instances) and introducing some explicit finish()
        protocol.
        
        Change-Id: I8ebfba9d9f9c32b65a50104d200306e06dc69f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150387
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [8978d12cbc475fa4c94a9a6b65d2e3f7219eb227]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 9a62e50d72bdcc786df4ea6094b349d1b3215b56
        "tdf#154771 sw: fix drag & drop moving of table columns".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ibd17de455af63211699e493de991f3a01e40f16f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150466
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [d88b2ec74c35cbf6adcd7bcd80243685a5a02344]

        loplugin:stringviewparam
        
        Change-Id: I4358852758782bc104f1af2c34ce4542e26e1edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150475
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [41741d0417a11ab3033e4dc6c899646d42871546]

        tdf#154473 remove assert
        
        so the commit that caused this:
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        did its job - we have far fewer crashes due to accessing dead SdrObjects
        - but the wide variety of other, smaller leaks, means that sometimes
        we have leaks of SdrObjects too.
        
        So just remove this assert for now (but leave the warning in DBG_UTIL
        mode in)
        
        Change-Id: I2123ba0f28a0cb4356eab3cbf34c8b67d785c516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150486
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-17  Miklos Vajna  <vmiklos@collabora.com>  [cbd7ce7ea647a2608e1d12035a634a1637482672]

        sw: improve naming of WW8_TablePos members
        
        - Sp26 -> TDxaAbs
        - Sp27 -> TDyaAbs
        - LeMgn -> LeftMargin
        - RiMgn -> RightMargin
        - UpMgn -> UpperMargin
        - LoMgn -> LowerMargin
        - Sp29 -> TPc
        - Sp37 -> PWr
        
        Change-Id: Icc92ea3180a05c65a8a41ff04d97a1217c7b51b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150472
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-17  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [846e9a202b450445ede565c4f6a9a70954134438]

        Resolves tdf#152184 - App color follow system colors
        
        Change-Id: I47d37a911baab57af832821bb66f8dd4818a8830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150283
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [1f8c3839dfc7e633c74da905593821f7681e2e66]

        loplugin:stringadd
        
        Change-Id: I10b450bccf27304530767cf80e0a6b04768cfc80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150468
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [1c8df0fd1ad896cbf7dfb08f2d70fa49e70c5106]

        loplugin:stringadd
        
        Change-Id: I04dad33cad121eba7189fc78cac762e31d7c4c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150477
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Pranam Lashkari  <lpranam@collabora.com>  [066b23115c2a360507e306a88da572554daefab7]

        jsdialog: enabled insert index entry dialog (writer)
        
        Change-Id: I2540620f7c4f9f640d943fb9e7b0e8661c706c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149170
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 062f0ff0a43a6d5ce610742a73d5b18562168a00)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150088
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-04-17  Pranam Lashkari  <lpranam@collabora.com>  [e82badd95d306c4e6c16a5858b3f1f7365a20df3]

        jsdialog: enabled bullets and numbering dialog (writer)
        
        Change-Id: I6d5ca75c7f2a91bd1716083fa9929fbeb3bd2e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149276
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 4bd57ffda77c884ea1104755af098730f04ef178)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150090
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-04-17  Pranam Lashkari  <lpranam@collabora.com>  [84d327698e5107de23bb0d342fb0c68604461790]

        jsdialog: enable table of content dialog (writer)
        
        Change-Id: I21af621a10e6d483af0174304e3457775068ab2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149169
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 6c204682d3b69bdcbb215fa10fbcd66253d0cdba)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150087
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [856fc80439c23d4473930b92e201ebd33b20fc8b]

        loplugin:stringadd: Adapt O[U]StringBuffer ctor detection for Windows
        
        ...where sal_Int32 is not int, so a literal argument like 16 actually calls the
        
          O[U]StringBuffer(T length, std::enable_if_t<std::is_integral_v<T>, int> = 0)
        
        overload
        
        Change-Id: I1d151efbc723cbfa76690e02491b05a9a4147e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150473
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Stephan Bergmann  <sbergman@redhat.com>  [5955a453165f6d8117b44e8ad37fb5ca0134add4]

        Adapt expected diagnostics to Windows
        
        ...where std::size_t is unsigned long long
        
        Change-Id: Icfe3927deaf4ffe57ac218ec109864852913cf31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150474
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-17  Caolán McNamara  <caolanm@redhat.com>  [5692a58cbfbd5da33b37415383f6eafb80d79177]

        tdf#137542 don't crash at least
        
        doesn't address the underlying issue though
        
        Change-Id: I7f5a5dba01c399ec78eceaab6ea85fc0b8897927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150446
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-17  Miklos Vajna  <vmiklos@collabora.com>  [17071b079dcae1bb20dc7af11852ac2ffd8525d5]

        xmloff: prefix members of SvXMLNumFmtExport
        
        See tdf#94879 for motivation.
        
        Change-Id: I8aa01371f310bf928cb78f149ea25bf0835cd6aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150465
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-17  Miklos Vajna  <vmiklos@collabora.com>  [3cd14725b6a16d7e6cc328aef3d1d9a9a6649634]

        sw floatable: teach the DOC export about SwFormatFlySplit
        
        Floating tables were always written back as a shape, containing a table,
        which can't split over pages, not even in Word.
        
        Now that we have split flys, we know that floating tables are mapped to
        split flys, so we can map split flys back to floating tables on export.
        
        The following SPRMs need writing, which are more or less the equivalent
        to DOCX's <w:tblpPr> attributes:
        
        - sprmTPc: relation orient for positioning the table
        - sprmTDyaFromText, sprmTDyaFromTextBottom: top/bottom margin
        - sprmTDxaFromText, sprmTDxaFromTextRight: left/right margin
        - sprmTDxaAbs: horizontal orientation
        - sprmTDyaAbs: vertical orientation
        
        With this, testTdf107773 passes in the SW_FORCE_FLY_SPLIT=1 case, while
        previously only the import side worked.
        
        Change-Id: Id534c1497eb56f9268bf49d2a19764051397bb18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150464
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-17  Noel Grandin  <noelgrandin@gmail.com>  [e870d996efb4a856f667c601032e02e5b21c5b82]

        use more string_view
        
        Change-Id: If4523dc2c89d1fb1c5e11665ee60044834fcecd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-16  Caolán McNamara  <caolanm@redhat.com>  [80a0d3b44cd6edb6419ab66588548ba169f2567b]

        Resolves: tdf#153958 Hyphenation crashes with -Alte...
        
        nPos2 is 0 due to the -, so aLeft is empty, nPos is set to 0
        then incremented to 1, aLeft.replaceFirst is run after its end pos
        so crashes/asserts. Presumably we can do nothing meaningful here
        so skip if nPos2 is 0
        
        Change-Id: I09754c4b2567fe5c1b4c36de0b36ee99f575244d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-16  Noel Grandin  <noelgrandin@gmail.com>  [abc09fe149ed971074eecb0cc1808c35add6ccfa]

        remove dead code
        
        it is easier to see that is dead if you look at the code
        prior to eec42f0dbcc79a4c9f456ce97fa1066b8031ea28, when we
        were using unique_ptr, which means that the pointer comparisons
        could never be true.
        
        Change-Id: I2e8608e468868a1f6b657a90b3db580334ec0490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-16  Eike Rathke  <erack@redhat.com>  [ea5f1533cb0ad95a03a0770e3e99fec356ee93e6]

        Document locale data ReservedWords
        
        Change-Id: Ie7085e437f6c80a7d13c9d01a7259f97ab05649c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150454
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-16  Eike Rathke  <erack@redhat.com>  [8a11d2e0b1ff09b3637a369eb468a15288dad7e8]

        Related: tdf#154832 Official name is Morisyen
        
        Change-Id: Ieae2d95318184e76cd8e533ba37d5a31eb9d2a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150453
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-16  Eike Rathke  <erack@redhat.com>  [5a3694a53bec61693d86aa0f6c175df6fff82137]

        Resolves: tdf#154832 Add Creole (Mauritius) {mfe-MU} [0x06B2] locale data
        
        Change-Id: Ia49e3dfb6ef7abc35f981712077018f98ef94297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150449
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-16  Julien Nabet  <serval2412@yahoo.fr>  [e542aa8c3ac78fc0f36dd06d6fa8dc3d5b0ac588]

        configure.ac: add error message if NET SDK not found
        
        + rename find_dotnetsdk46 to find_dotnetsdk
        
        Change-Id: I6354ed1a900bb3b86999bee4354f628e79318924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150440
        Tested-by: Jenkins
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-16  Justin Luth  <justin.luth@collabora.com>  [1d12d12598927ef8a74dd648632112ceb16bdf78]

        tdf#154703 DOCX {im,ex}port framePr: adjust framesize by para spacing
        
        The specified frame size does not seem to account for
        left and right paragraph border spacing.
        
        At first I assumed it was just RTF, but DOCX needed it as well.
        
        This is all VERY nasty. In practice, the paragraph border spacing
        normally matches the frame's border spacing, but not necessarily.
        Plus, the user might have interferred.
        
        MS Word must know that this is a special kind of frame. LO doesn't.
        To handle this properly, LO frame UI would need to adjust
        ALL of the paragraphs' border properties when any
        changes are made to the frame.
        
        For the present, we have to import the frame properly,
        and export as well as possible.
        
        RTF export is losing paragraph borders already,
        so it has been excluded from consideration.
        
        No other unit tests were found that had a significant border spacing.
        make CppunitTest_sw_ooxmlexport10 CPPUNIT_TEST_NAME=testLibreOfficeHang
        
        Change-Id: I03d801ff0ec3c2b93a77761da8ad1f43aeaacf42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150357
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-15  Caolán McNamara  <caolanm@redhat.com>  [96c4c0fcffc4f0a1f5a49be576646d15d613228e]

        ofz#58028 Abrt
        
        Change-Id: Iaf25521993ddf7269ca34bb3740d00432e615795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150444
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-15  Eike Rathke  <erack@redhat.com>  [a062bceb2509d227cec86845af680a4b69d42df3]

        Add ROUNDSIG samples to unit test, tdf#138220 tdf#105931
        
        Change-Id: I0bab920c78ff6d02382b9a314982a2f3d436b35a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150442
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-15  Eike Rathke  <erack@redhat.com>  [e68cd91651c53c5c228d84582b1062d8fb9a7077]

        Add ROUND(DOWN|UP) samples to unit test, tdf#154792 tdf#124286 tdf#138220
        
        Change-Id: I20efab10041cee570bd0685bbd4da6077a71f1e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150441
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-15  Caolán McNamara  <caolanm@redhat.com>  [7d6e1eccf742664fc7487f1b73ac233e1d2674d3]

        just use a reference instead of an always dereferenced pointer
        
        Change-Id: I105873fc890d67b39b796864f8eae4bd12aecd26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-15  Julien Nabet  <serval2412@yahoo.fr>  [33624fff2d66ad9cdab94df654c802acde42c0ba]

        Fix number decimal separator in text tags in ui several files
        
        Change-Id: I55b5fe4fdd89f9383c6ce646780cce846639736f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150420
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-04-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b8349ca053753bb0dc713933628a1575a70677d3]

        tdf#154269 - Respect FindReplaceRememberedSearches expert option in quick find
        
        Change-Id: I88c1bed647bf6f77953ccd9921e515c1246fa96f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150273
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [47064420eedd3fc567570e6843a041aca8831f10]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to de94ac52fd6aecff990f8dae6e69dc5c4363cb83
          - tdf#149155 Update Formatting Aids Option Help page with image anchoring option
            
            + refactor of some small help pages
            + remove wrong bookmark
            
            Change-Id: I3fcf441ad266d84e1ddd5e221a5749df34d913e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150427
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ffa6601469e2e16f96421cd01857bc06c7e875f2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 323f114ac39db557b5ac55c9bab9259d28b98228
          - Refactor Help page, no change in contents
            
            Change-Id: Ib32142a66bc662b5c0ddb79b0a0256c09550b0fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150426
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eb7cfce7bfe67b8b7024b2a3d9589d2f22513a29]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f4d872408d2e6b69807eb47f2a9d9e2d5f00548a
          - tdf#132465 "Trim input range..." option on Calc's Moving Average dialog
            
            Refers to tdf#99938
            
            Change-Id: Ia8bac690c0090c7fedf635cdf6987cfc1e3c8cb2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150424
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4283d11a18b1685ae191a0dec02b51e03165f095]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c811d25cb446be27fd99363c08b7e2e406082391
          - Refacter help file, no content change
            
            Trim xml-lang
            
            Change-Id: I86695d593cbd3d99dda1ad65ff13897cee5b3bd1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150423
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [07f4fa7119d28ce943405ee6e7cbdf260c730357]

        a11y: Send VALUE_CHANGED event for FormattedField
        
        `VCLXAccessibleEdit::ProcessWindowEvent` takes care
        of sending a `TEXT_CHANGED` event. In the case of
        `SVTXAccessibleNumericField`, numeric values are
        handled, so send a `VALUE_CHANGED` event in addition.
        
        This makes Orca with the qt6 VCL plugin announce
        the new value when e.g. changing the page width
        using the arrow up key in the "Format" -> "Page Style"
        dialog.
        
        For Accerciser, an additional fix is needed so the
        value gets updated there in the interface view when
        the a11y object is selected. Pending MR: [1]
        
        [1] https://gitlab.gnome.org/GNOME/accerciser/-/merge_requests/25
        
        Change-Id: Id911f50664df7220bc58204bc3477c5306a1da33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150422
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [86bbf9a4eca0e96b282f656c7dc0cf11ff80c9f9]

        a11y: Report focusable and focused state for ThumbnailViewItem
        
        Basically the same as
        Change-Id I3f14047fe721c4a2bc0c6acb2d32f185d0eed204
        "a11y: Report focusable and focused state for ValueSetItem",
        but for `ThumbnailViewItemAcc`.
        
        Makes Orca with the qt6 VCL plugin announce the selected/focused
        item in the recent documents view in the LO start center.
        
        Change-Id: I8ab259ce6649904b42367ac30e4efbd6ab62cb6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150419
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [0dc23570a033b69dfcaec64de18c3c0bbd2ad151]

        a11y: Report focusable and focused state for ValueSetItem
        
        With this in place, Orca now also announces the selected
        color when moving focus in the list of available colors
        in the Writer toolbar font color popup
        when using the qt6 VCL plugin.
        
        Change-Id: I3f14047fe721c4a2bc0c6acb2d32f185d0eed204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150418
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-15  Michael Weghorn  <m.weghorn@posteo.de>  [734d10ed3612d75edcee145475ddd0b0165efeac]

        qt a11y: Send QAccessible::ObjectCreated event for correct object
        
        When an `AccessibleEventId::CHILD` event with
        its s `NewValue` set is received, that means that
        this a11y child object has been created, so the
        `QAccessible::ObjectCreated` event needs to be
        sent for the newly created object, not the accessible
        interface of the listener (which is the parent).
        
        This makes announcement of (part of) the font color popup
        button in Writer's toolbar generally work with Orca and the
        qt6 VCL plugin e.g. the buttons in the popup are now announced
        (but the colors are not yet).
        
        Adapting this for the case where a child has
        been removed (bridged to Qt as `QAccessible::ObjectDestroyed`
        event) would currently results in crashes when closing the
        application e.g. after using the character font color popup in
        the Writer toolbar. This needs further investigation, so don't
        send the event for now, but add a `SAL_WARN`.
        
        Also warn when receiving a `CHILD` event with neither `OldValue`
        nore `NewValue` set, since that shouldn't happen,
        s.a. documentation in
        `offapi/com/sun/star/accessibility/AccessibleEventId.idl`.
        
        Change-Id: I183e71de061489fdc9751620820268f280f1949f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150417
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-15  Eike Rathke  <erack@redhat.com>  [8186a01f2a26f05645a2a3c9c93b453bd35b796f]

        Resolves: tdf#138220 tdf#154792 Avoid double rounding; tdf#124286 follow-up
        
        Change-Id: Ie4028b20f2d3087a54bbfafd35d59fa06ec7a061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150439
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-15  Eike Rathke  <erack@redhat.com>  [397d12997a604730ad11316faa34cefd470ee0ff]

        ROUNDSIG() Avoid inaccuracy of pow(10,negative) tdf#138220, tdf#105931 follow
        
        https://bugs.documentfoundation.org/show_bug.cgi?id=138220#c6
        (otherwise unrelated) has an example of
        =RAWSUBTRACT(ROUNDSIG(-999.13;12);-999.13)
        resulting in -0,00000000000011368684 instead of 0, due to these
        0.1 ... inexact negative power of 10 values.
        
        Change-Id: I82429f0871f1de35a7f2092708fc6b9c2e902999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150438
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-15  Mike Kaganski  <mike.kaganski@collabora.com>  [4578ded393f8e97ae781f63c9a1cf57669409635]

        Simplify initialized check
        
        The previous complexity did nothing useful; it allowed to have a single
        unguarded boolean value check, for the cost of releasing and acquiring
        the mutex again.
        
        Change-Id: I426304e9ef6f27ca371544951bf3cc029887019e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150437
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-15  Justin Luth  <justin.luth@collabora.com>  [e07d5c089ab2e8fe8a5cfa2a11cef3f1cf3afab3]

        tdf#154703 docx export framePr: export xAlign/yAlign
        
        This fixes a regression in LO 4.4
        from commit 1c876f5616522ab695de8c0316cdb0c601081815.
        
        The relative positions (left,right, center, inside, outside)
        (top, bottom...) were simply ignored on export.
        
        Change-Id: Ie12eb75483fbc3f05c77e45d40e4a18a7ead5b1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150430
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-14  Julien Nabet  <serval2412@yahoo.fr>  [4829a85d0753c93419bd46b1d50bcfa6f0f3f1da]

        tdf#154734: XML Form doc: all binded fields will be shown as fields...
        
        with wrong content - except fields, which have wrong content
        
        Regression of 14cfff500e93f0d6cbf8412065feea85c01ea81d (at 2021-08-05)
        Pass context and resource string down to boost::locale separately
        because this is often on a hot path, and we can avoid the splitting and
        joining of strings like this.
        
        Before the commit, it was:
        return ( _validate( sValue ) == nullptr );
        
        _validate methods return "TranslateId" variable which contain the reason why validity is wrong
        so if this variable contains no reason it means everything is OK.
        
        so just replace:
        return bool(_validate( sValue ));
        by:
        return bool(!_validate( sValue ));
        
        Change-Id: I76373d0825f86f9072217c96757252b6a891ecc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150433
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-04-14  Caolán McNamara  <caolanm@redhat.com>  [5bb3a7af2040dc11e424cb4f5bce7a4ee30df38d]

        Resolves: tdf#113286 make Crash report link clickable
        
        Change-Id: Ife9f152e7945d40307e1f8b974e08167981acc6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150414
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-14  Caolán McNamara  <caolanm@redhat.com>  [232fb7e4f22d2d0af1121fb3eb39be5afd4e8f07]

        resave with latest glade
        
        Change-Id: Id516d979c803a7a3631f95df220bd430fac0bb0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150413
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-14  Michael Stahl  <michael.stahl@allotropia.de>  [6edb6d2b34eb48d0db6d568fd22929eb1e5fa98e]

        sw: fix crashtesting assert on tdf56085-1.odt
        
        ustring.hxx:860: sal_Unicode rtl::OUString::operator[](sal_Int32)
        
        in SwTextFormatter::BuildPortions, itrform2.cxx:529
        
        The follow flag was erroneously not set, here the situation is that
        the current line is full and the field moves to the next line and that's
        why this SwFieldPortion is empty and will be deleted but it was a follow
        itself so its follow is a follow too.
        
        (regression from commit e006c6ce7502f47889034b98cb0795e78ea36094)
        
        Change-Id: I35350c7dc9a5aa249af53bac724cdd270d12b99b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150415
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-14  Michael Stahl  <michael.stahl@allotropia.de>  [7b3236a52f80ffc713fcdc61760c2c3e30fe8c39]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88f875a677dad35889ab2b6cda9ef750ee973809
          - add help for Common::Load::ViewPositionForAnyUser checkbox
            
            Change-Id: I49f0c83665955ae9db3ea9187418d0d093a88df9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150428
            Tested-by: Jenkins
            Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
            
2023-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [46cf6d3f899fbab7524085597483feeb6f5d6cd9]

        tdf#138124: do not reset IsFootnoteDone status in line layout
        
        Similar to IsNumDone
        
        Change-Id: I64c713148b613ca1db4a30cde13bec5a6744accc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150378
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [25d0ae95d6e7695a33cb67b1cb3626c338cf92a9]

        fix check in SvxUnoTextBase::insertTextContent
        
        looks like copy/paste error in
            commit aac15b638410f181133dc15343136b4e9a1675ba
            Author: Kohei Yoshida <kohei.yoshida@gmail.com>
            Date:   Mon May 7 15:22:54 2012 -0400
            Set anchor to XTextContent using UNO API.
        
        Change-Id: I516cf6e5ff23c2409585b57da34862f0ab6bdb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-14  Pranam Lashkari  <lpranam@collabora.com>  [d1c24db3f8329bd798d4f80a94f191e6b43678f6]

        jsdialog: enabled footnote endnote settings dialog(writer)
        
        Change-Id: I85c6eb0db6ad7123df1c8596951be5bb8ed5ef3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149171
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 451939ac9a8cf182ab563412d561562957a60499)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150089
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-04-14  Justin Luth  <justin.luth@collabora.com>  [a24d461d736de0a29bb8ef2a20b57db4836cda3e]

        tdf#154703 writerfilter framePr: RTF != INVERT_BORDER_SPACING
        
        Change-Id: I839b187f8e5822fb162255595aeeeac36427cb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150356
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-14  Julien Nabet  <serval2412@yahoo.fr>  [19ecb4a390bc0bc6dad6688cdc2b70a8d05bcde2]

        Fix number decimal separator in cui/editmodulesdialog.ui
        
        Change-Id: Ie10f061f5feb97ce5e251aba03c5a0d21d7c0f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150390
        Tested-by: Jenkins
        Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-04-14  Miklos Vajna  <vmiklos@collabora.com>  [69fe424e426957545a30e1b912c933e1e7693100]

        sw floattable: unconditionally map DOC table pos props to SwFormatFlySplit
        
        Previously we only mapped DOC floating tables to split fly frames when
        the heuristics asked for a fly frame, this goes further.
        
        Also add a testcase that shows that the import now works, but the export
        needs more work.
        
        In other words, this disables heuristics when the feature flag is on.
        
        Change-Id: I65018fef7994b283a60b0c38b22c16e2277cb80f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150410
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [597853903871325876b44fb523d323d2174874e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b4bda73615e8199f4f8ffae09bac344dea51c5d
          - Make text straight
            
            Change-Id: Ia98e8c8090bd8ddd93b3dc4b4194d968e8dee7be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150322
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-14  Caolán McNamara  <caolanm@redhat.com>  [f76ec0b61e19267d9a01946dee2979f53f182a46]

        add a way to resolve if dark mode (explicit or auto) is active
        
        Change-Id: Ie0d4e0c3cd5d19cf6337ec79d30ae7c877cffd82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150394
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4fffaa538e38d7e12553f204f61fdd45795efdcf]

        Fix typo
        
        Change-Id: I36ff6c3ccec07426b1a59b823f90882d817e6e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150399
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a389cbe404a25e18f004e216a1e04412c077df2e]

        Fix typo
        
        Change-Id: Ib27e0fa515eb69a56462f8571c37e314321924a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150298
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a47829dd9af35d31bb38a52e07a32a7e452d4ab3]

        Fix typo
        
        Change-Id: Ib001ad971640f6e76a8e58549edbe3fb4b248e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150400
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3e8a356f5ca00d875981b0f4279894c569bcc694]

        Fix typos
        
        Change-Id: I7f8fa704199865e67c0543f92f89f63765c8c2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150406
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2150414400400efe76fc103286bf2abafccd8fd7]

        Fix typo
        
        Change-Id: I9ff6b3a0720e9edec11edc0c81ba2995a3aad5e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150401
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d1e97808f54bef3e5e87647d82e37662580b607c]

        Fix typo
        
        Change-Id: Idb607f8d35163de55e29415efe8a3cfb029eb9e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150403
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4256a9cf6485f0c07b441687ddde1eeab2c94402]

        Fix typo
        
        Change-Id: I59de66225912c4a5ebf257ee47b29d20c23649af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150402
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f26d8531038e1b208450deec88c23678782db926]

        Fix typo
        
        Change-Id: I13fc79ab0fc9ede2a977424627fca0765ad90f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150398
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1f7b5e8fcefdacb268c49a6a9ad168e3610b293]

        Fix typos
        
        Change-Id: Id3dd5a8386906b0b17a0c5934381782ecb7cd25a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150404
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9fa1eb12d8a1b86a25dfb9aaa9734de522a00ada]

        Fix typo
        
        Change-Id: I9ba81b030e6ed0ebb6207a0124a52ec8a38de832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150405
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac9cdc995bc0f8f43ec2c4ad2e509b440f5b1b68]

        Fix typos
        
        Change-Id: I2b087d0f97c675cfedd4e2e78c7f827df4605fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150407
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fe65fdce9468c87767364a2a7d0ce4025cbdd093]

        Fix typo
        
        Change-Id: I6d2119f12d92572ec89db3773196896f28b35319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150396
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf2a30068915924ef0d1293fc33886e6268b45b0]

        Fix typo
        
        Change-Id: I99f24d3df72385ea650abb2224a724892146f220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150397
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-14  Mike Kaganski  <mike.kaganski@collabora.com>  [43b893f3a1812b1ca4380267e78ff1b846c41436]

        Another micro-optimization
        
        I was surprised to see that all three major compilers generate
        better code using the pointer arithmetics compared to indices.
        
        Change-Id: I934a840a43159babf51f337b4af7f972424ff4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [b1c88800c2e3e6a509ba08050c7e65ce7d0e693a]

        NamedValue needs to be a complete type here now
        
        ...at least with VS 2022 Preview 17.6.0 Preview 3.0 and --with-latest-c++,
        
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(78): error C2036: 'const com::sun::star::beans::NamedValue *': unknown size
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(73): note: while compiling class template member function 'std::_Span_iterator<_Ty> &std::_Span_iterator<_Ty>::operator --(void) noexcept'
        > with
        > [
        > _Ty=const com::sun::star::beans::NamedValue
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1414): note: see the first reference to 'std::_Span_iterator<_Ty>::operator --' in 'std::iter_move'
        > with
        > [
        > _Ty=const com::sun::star::beans::NamedValue
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(474): note: see the first reference to 'std::iter_move' in 'std::ranges::_Iter_move::_Cpo::operator ()'
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\__msvc_iter_core.hpp(392): note: see reference to class template instantiation 'std::_Span_iterator<_Ty>' being compiled
        > with
        > [
        > _Ty=const com::sun::star::beans::NamedValue
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(602): note: see reference to variable template 'bool input_or_output_iterator<std::_Span_iterator<com::sun::star::beans::NamedValue const > >' being compiled
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1778): note: see reference to variable template 'bool input_iterator<std::_Span_iterator<com::sun::star::beans::NamedValue const > >' being compiled
        > filter\source\config\cache\filtercache.hxx(368): note: see reference to class template instantiation 'std::span<const com::sun::star::beans::NamedValue,18446744073709551615>' being compiled
        
        Change-Id: Ibff530be810f56a1f33bf78f0d2e3b76c64b08cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150385
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  László Németh  <nemeth@numbertext.org>  [a36fda0d7c70ffd344f9636ca436e77e41dc01f1]

        tdf#150149 sw: fix table header in multi-column sections
        
        Disabling long repeating table header on pages resulted
        lost table header within multi-column sections. To fix this,
        revert commit f7e071a00542c414a7e9d7bcf4434d908f225e59
        for tables in sections.
        
        Regression from commit f7e071a00542c414a7e9d7bcf4434d908f225e59
        "tdf#88496 DOCX: disable long repeating table header".
        
        Change-Id: Idb7b9ea014be5430a185489cf449463f534c1916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150393
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-14  Miklos Vajna  <vmiklos@collabora.com>  [ab639ae344704cd22318938cfeafbe954abcd2c0]

        sw floattable: limit the unfloat button to legacy ODF files
        
        CppunitTest_sw_uiwriter2's testUnfloatButton and testUnfloating failed
        in the SW_FORCE_FLY_SPLIT=1 case, on unfloatable_floating_table.doc.
        
        The trouble was that it assumed that floating tables from DOC are
        imported as tables in non-split flys, which is no longer the case.
        
        Fix the problem by limiting the test to legacy ODT files.
        
        Change-Id: I0c82c04f3e44d9d0c936a5eb386cd2c0e68f8af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150395
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-14  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [70684ab604c5fb32a16614c708f986671dd2da3c]

        MCGR: Adaptions to oox export
        
        This is a 1st version and might need more fine-tuning,
        so it is still 'hidden' behind the MCGR_TEST env var
        being set (as the import is, too).
        Still, when used, it can now import a MCGR with
        transparence and export it again. I will now do extended
        testing/experimenting, fine-tuning where needed and
        prepare final change/drive forward.
        The current state in master should not be changed as
        long as the mentioned env var is not set, but this
        will need to be checked, too, due to changes to the
        export api in oox.
        Corrected an error in GetAlphaFromTransparenceGradient
        method(s), css::rendering::RGBColor is [0.0 .. 1.0]
        Corercted an error in WriteSolidFill where transparence
        gradient gets checked. This should really check if
        TrGr is used, but only checks for 'empty/unused'
        color instead (assuming COL_BLACK is 'unused').
        All usages of GetAlphaFromTransparenceGradient should
        be checked and adapted.
        Change-Id: If59d7a06b9207e2efe9e71f3f8ddeca4476408f3
        
        Change-Id: If97f8abdd0e1597aa1fd865b7e884e06a22b71f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150391
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-14  Caolán McNamara  <caolanm@redhat.com>  [8b8a2844addbd262befb1a2d193dfb590dfa20be]

        add a route to get writer Floating Frame links under 'manage links'
        
        Change-Id: If90ff71d6a96342574799312f764badaf97980eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-14  Heiko Tietze  <tietze.heiko@gmail.com>  [11bb9c14da13507adeeea8dce863fb4b96a92870]

        [API CHANGE] Related tdf#154080 - Allow customization of comment indicator color
        
        * Calc > View option replaced by a new application color
        * Border not only in highcontrast mode but always shown
        * Border color depending on cell/sheet background
        
        The previous option TextOverflow in Calc.xcs was replaced by
        CalcTextOverflow in UI.xcs in order to combine color and on/off
        with the accepted drawback of incompatibility.
        The alternative, keeping the color separate from the toggle, would
        separate the options and was rejected therefore.
        
        Change-Id: Ie3e469163485d8eb1cffc7022e1518ad20e8e54e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150340
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-14  Szymon Kłos  <szymon.klos@collabora.com>  [b9ad48f1939145105ee57470b5c9210bacc8ee45]

        jsdialog: enable area dialog
        
        Change-Id: I915414c55c0b008c018bc2376760eaa85f653384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150282
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150388

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [2416cae8ea94997ebea112c31624db79d0d6b91a]

        XMLPropertyState needs to be a complete type here now
        
        ...at least with VS 2022 Preview 17.6.0 Preview 3.0 and --with-latest-c++,
        
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(78): error C2036: 'const XMLPropertyState *': unknown size
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\span(73): note: while compiling class template member function 'std::_Span_iterator<_Ty> &std::_Span_iterator<_Ty>::operator --(void) noexcept'
        > with
        > [
        > _Ty=const XMLPropertyState
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1414): note: see the first reference to 'std::_Span_iterator<_Ty>::operator --' in 'std::iter_move'
        > with
        > [
        > _Ty=const XMLPropertyState
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(474): note: see the first reference to 'std::iter_move' in 'std::ranges::_Iter_move::_Cpo::operator ()'
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\__msvc_iter_core.hpp(392): note: see reference to class template instantiation 'std::_Span_iterator<_Ty>' being compiled
        > with
        > [
        > _Ty=const XMLPropertyState
        > ]
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(602): note: see reference to variable template 'bool input_or_output_iterator<std::_Span_iterator<XMLPropertyState const > >' being compiled
        > C:\PROGRA~1\MICROS~3\2022\Preview\VC\Tools\MSVC\1436~1.323\Include\xutility(1778): note: see reference to variable template 'bool input_iterator<std::_Span_iterator<XMLPropertyState const > >' being compiled
        > include\xmloff/txtparae.hxx(390): note: see reference to class template instantiation 'std::span<const XMLPropertyState,18446744073709551615>' being compiled
        
        Change-Id: Ib5f32df4a696dd1077c171662da48909dad09e33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150386
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [e5aeca2cf9ff9746f9af521c52b40360cd7f7bfc]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 62b337a3d6650b8b3045dd98f59a8c0188f0a6fa
        "Unit test for removeTextContext."
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Id80b031625134ea6b4d679bfb774fc253206ae18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150374
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [53ba2283c81ea7812538dc1c846a81fcb037fb10]

        Latest VS 2022 Preview is 17.6.0 now
        
        ...while latest proper VS 2022 is 17.5.4
        
        Change-Id: I7d3ff3dea730cf1490a0198922281792e524ed9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150382
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Miklos Vajna  <vmiklos@collabora.com>  [b0067dee80e8c33e5be9ca8acaafe7dab6cfc085]

        sw floatable: teach the DOC import about SwFormatFlySplit
        
        - add a new DOC/ImportFloatingTableAsSplitFly setting, replacing the old
          (enabled by default DOCX/ImportFloatingTableAsSplitFly) one
        
        - clean up old uses of SwModelTestBase::FlySplitGuard
        
        - if SwWW8ImplReader::StartApo has a table position, then map that to
          SwFormatFlySplit=true in the ImportFloatingTableAsSplitFly case
        
        - testcase for this
        
        Change-Id: Ibd798ea7eb79d7ec00620dd8921797232f4732d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150381
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-14  Szymon Kłos  <szymon.klos@collabora.com>  [5a4fa04d9b161cdfc6d77f942aa38b8a73d025e8]

        lok: draw textboxes under edit
        
        This fixes bug in impress:
        - open in 2 views
        - start editing textbox in 2. view on 2. slide
        - start editing textbox in 1. view on 1. slide
        Result: slide 2 textbox was dissapearing
        
        We need to allow drawing textboxes edited by other views
        so if we select non-editor for rendering we will see the
        full content.
        
        It was regression from
        commit e496b55a592caf0ca07f5477285a72d50cee6501
        lok: masterpage: don't render text edits from different mode
        
        Change-Id: I7645496aec77d11d16621129dd6644d3b54a6010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146999
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150096
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150348
        Tested-by: Jenkins

2023-04-14  Szymon Kłos  <szymon.klos@collabora.com>  [6c62b5a994b9045d1d7228fef655be1a8d3b5452]

        lok: setup LOK notifier for invalid range error
        
        Change-Id: I63fc6fcdec873a9d0c8d54dd6a6f3783f2c15251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147200
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150043
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150347

2023-04-14  Miklos Vajna  <vmiklos@collabora.com>  [9282e294c3f575e8346f6c6aae22530e700c1cec]

        sw layout xml dump: extract SwFootnoteFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about footnote frames.
        
        Change-Id: I3bfdc9d16a5940f6fa2af4b85ad4261d7d10c3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150375
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [99b33f387a8703a2a37a45554309ca6b8906a296]

        -Werror,-Wunused-variable
        
        Apparently left behind by 36e62098c8c541c4a3fb63eced591cf29ac56e4a "CppUnittest:
        sw: simplify code. use getShapes and getShape".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I17adb18fc8a054dd2f2c26181c5d1ab4273c5411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150365
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [c4a8458f49c9d6816c9a625cc62edd67a6b7af54]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in ea358f5d5b04a2a8e11a73d35643cd0afc5cb63b
        "CharBrd 8.2: Tests for UNO API and ODF filter".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Id30adc7bb05855316f59e7b0cba9c6e401dc9fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150367
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [81b8888b8184d28e0f6fe67d943f4cdda2e42794]

        -Werror,-Wunused-variable
        
        Unused ever since the two variables got introduced in
        a825e23a2980fcb3d970834c4ce1f8403fb93054 "DOCX export: fix not-well-formed XML
        when hyperlink end is a textbox anchor" and
        87e82f80e87bb4a216ea83383864d494f3e92eea "docx: export symbol characters
        correctly", respectively.
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I89b8324633d598b06c8aa206747f9213d4634cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150361
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [2c13cb94be4b601e55712512d52d8cc975ca2974]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc
        "tdf#139737 sw_fieldmarkhide: add unit test".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: If9281585d081c58bd1a32159a403989af7fec621
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150369
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [7cdbe504ff3b59d3aec1b1e86caf7f24223dce72]

        Fix what looks like copy/paste typos
        
        ...introduced in 398275ba9f4d65bebcc78864e70eee6212a84397 "tdf#115483 svl xmloff
        sc sw: verify all ODF 1.2 protection-key hashes".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly to report xSect2 and xSect3 as
        unused.)
        
        Change-Id: Ie0eb38e0011b2b457f640ade67c6e615731f165f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150368
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Stephan Bergmann  <sbergman@redhat.com>  [83617ef36a6e962d0f90a413950032781bba1cf9]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 0101c7918bb735d796bc1bc0d1705f995e41ee98
        "Add simple unit test for recent fix to take layoutInCell into consideration".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ibba11e910433769a72a7c1e8e1419d07cb8968a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150360
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc2101646bc6e63944c42500af5a15134b9b2d17]

        loplugin:stringviewparam improvements
        
        improve the check by checking for methods that exclude
        using string_view, rather than checking for methods that
        __can__ use string_view, which leads to exposing
        some holes in our o3tl/string_view.hxx coverage.
        
        Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-14  Noel Grandin  <noelgrandin@gmail.com>  [ad97694737c99889bc0eb21efccb83768d510361]

        tdf#154501 - Fileopen PPTX: Table with rotated text wrong
        
        regression from
        
            commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Aug 15 17:35:58 2021 +0200
            pass OutlinerParaObject around by value
        
        where some of code I converted needed to be mutating the
        OutlinerParaObject that something else held, rather than mutating
        a local copy.
        
        Change-Id: Ib91dddb3fc0d4190868f9fd59becb0d366af5e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4237a0b56306d8c9ac1e8391440fc02abdf1ceb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18bfaed6e90eb353d17fc837162e9ad9924bec04
          - tdf#153903 corrections to "caption" format descriptions
            
               remove <xml-lang> from <bookmarks>
            
            Change-Id: Ic8d18453ea14a1e0c482749c0713d7bb2ec61811
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150139
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-14  Justin Luth  <justin.luth@collabora.com>  [02c902bde09984a87f19ac0eb63942724056c982]

        tdf#154703 docx export framePr: merge para/frame FormatBox
        
        Now that export knows about both frame and para border spacing,
        we can remove an import hack.
        
        When exporting the paragraph properties, not only do the direct
        border settings and the paragraph styles settings apply,
        but also (uniquely for framePr) do the frame properties.
        
        The most significant property is the border spacing.
        On import only the paragraph keeps the spacing
        (with the purpose of keeping paragraph shading looking right)
        and the frames itself has no border spacing.
        [That is also good, because the frame size
         is specified as the size without border spacing,
         and LO does not expand the frame when borders spacing is added.]
        
        One exception of course is if the user adds spacing during editing.
        Another (theoretical) situation comes during an ODT->DOCX export.
        
        Fortunately, both of these situations should be handled by just
        adding the frame and paragraph properties together.
        It is emulation, but it seems to work pretty good.
        
        I modified the unit test from
        7.1 commit 49e2bd6103669ca94d4e308fc08beed57f85c7e2
        Author: Tibor Nagy on Mon Aug 10 10:51:20 2020 +0200
            tdf#131420 DOCX export: fix missing border of frame
        because we should _not_ have two pBdr entries,
        just one, non-empty entry.
        
        Table import and export are already a mess.
        See ooxmpexort5's fdo 60957-2.docx for a great example,
        and tdf104394_lostTextbox.docx is also fascinatingly complex.
        
        Change-Id: I011100ee2790de6b8573d6a8bc99b9455f65e76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150242
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-14  Justin Luth  <justin.luth@collabora.com>  [996d264dd4ca37c869e5109296de6ae306f740d9]

        tdf#154703 docx export framePr: export frame background
        
        [This bug report is about exploring when Writer can export
        in a way that imports as Writer frames instead of Draw objects.
        Exporting the background is one of the most crucial pre-requisites.]
        
        The framePr background always imports as fully transparent.
        In that case it should just be ignored on export.
        
        However, in the (theoretical) case of ODT->DOCX framePr,
        or in the (practical) case where a user modiifies
        a framePr's background colour, then that background should
        be transferred to the non-backgrounded paragraphs in the frame.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154703_framePr2
        
        Change-Id: I1f59267030810b56d2701822b7004069e02eb46d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150355
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [4e70952efbc97bef7bc108e738bee346bf5de605]

        -Werror,-Wunused-variable
        
        Apparently left behind by 36e62098c8c541c4a3fb63eced591cf29ac56e4a "CppUnittest:
        sw: simplify code. use getShapes and getShape".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ib8bb03116c2323e76321259f423b19af678e09f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150362
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [ba4762fa14aeca39929d7a6d33217f34f2218e58]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 912336f3c85d9a631fa0ac0f270bab04b204f619
        "tdf#154599 sw: fix crash at drag & drop table columns".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ic297b850eab488e22f0477f58c2c62523d58f299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150373
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [6888d414fd298a6d3da69e189398b38bbd1db7c0]

        -Werror,-Wunused-variable
        
        Unused ever since the two variables got introduced in
        19b0171bbb6c2bcdab998b74a212dc68b1884e84 "tdf#108494 fix regression".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Idb06de376cf5bed273f0ebb46c00b9f6f675b223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150372
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [5e86a3487f1ec5dd1c74b6b9ebb6a04550d39c04]

        -Werror,-Wunused-variable
        
        Looks like it got added by mistake in 8a776fecda43db0bebf5f0028adacce8c2c6afd2
        "sw_uiwriter2: Unify code and use createSwDoc everywhere".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I441dceeea14152a2c84c46ed2c349cf320e3d439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150371
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [ca1ecf8bf7bba63f046848840db9d1aee5501fc5]

        -Werror,-Wunused-variable
        
        Unused ever since the two variables got introduced in
        22a77cb83a3769a8b43d80565282988a74214866 "tdf#134436 sw: fix
        SwUndoDelete::RedoImpl() with section at end..."
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I53777c67da8e384d8f1ed2cd2840ce0c6abeeb5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150370
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [f98f1f1a5f6c9dc8ca32fd9eec8c2bc902f50c77]

        -Werror,-Wunused-variable
        
        Unused ever since the three variables got introduced in
        504d61697bac45236da27fba23c7189daf8c171e "tdf#149206: sd_import_tests2: Add
        unittest", 59cf9a433e1ea74ccdb1abe080511353a6c0af08 "tdf#149785:
        sd_import_tests2: Add unittest", and 93b07a377b93875b28464546f1292e4aa5f9e17d
        "tdf#149985: sd_import_tests2: Add unittest", respectively.
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I0f5520255cb400eee7a860212b42190c66cdb239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150359
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [03ad8bdc2a2d9f85aaeff692c9e89d8a66fa3e9b]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in e11c51eefe8c3210cef2b5850f401ba67a401d01
        "tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I00585e7aae5c869ccd32d8edfc319f027050e6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150366
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [f1ff6f9c72cf0e105e6e151a9fa3b7d395553d4b]

        -Werror,-Wunused-variable
        
        It apparently also wants to be "disabled temporarily, next commit enables it
        again" (whenever that will actually happen) since
        a9ba8e57a41c5ddf3597272bddab30e51fb3fd38 "Revert 'tdf#118947 sw tablestyle:
        manually scan parents for ::SET'".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ie280fda9948c3b1730e13b53db5e288d0a651f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150364
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [c4b561d64ef64a1cd578ea7a6e24bd78a3bce36e]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 84fefd7c295fc05499ca222dff50c2fe4e0fb27e
        "tdf#120145 ww8import: ignoreCols if section is inserted".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: Ifdf83006d244abe92025fed528f9b1546142ce82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150363
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Michael Meeks  <michael.meeks@collabora.com>  [c55d5586304f23f9d8acbaffefba68a3a11c6175]

        BinaryDataContainer: hand out shared_ptr's to SvStreams.
        
        Hide the SvMemoryStream implementation detail better - this
        could be served from a file in future. Also couple lifecycle
        of the SvMemoryStream to the vector backing it.
        
        Change-Id: Ia9b28b57b8df4ce57286effd4d1753bf345fc10e
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149917
        Tested-by: Jenkins

2023-04-13  Michael Meeks  <michael.meeks@collabora.com>  [689f0da67b063284991d758a4f0c66a305dcad37]

        BinaryDataContainer: pure re-factor - encapsulate cbegin/cend
        
        Change-Id: Ic8dbf0afdb96a0f1be210eedfbd12ef6467dd29f
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149916
        Tested-by: Jenkins

2023-04-13  Justin Luth  <justin.luth@collabora.com>  [499247966af565071542f1cdfa882d6b8e6c33f0]

        NFC tdf#154703 docx export framePr: cleanup prep before patch
        
        This sets up the building blocks for a series of patches.
        Lets get this formatting/renaming stuff out of the way first
        so that we can focus on the actual logic changes later on.
        
        Change-Id: I20aa333080d9f31af4f4b9e89a51eafba1d39530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150354
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [6cd14af780efb5704538622b6d95c2a1ba3dc7dc]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in ea331fa8b498c66ec687c6611c69ffc61e58bc79
        "tdf#131553: Add unittest".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I9841713baf718be5b19d25acb35f3b856a94e1cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150358
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [465e66be927fa186d1cc2ffaf25ebccdfd9862d9]

        sal_uInt16 is not a good choice to store SwTwips
        
        The latter is tools::Long, which is even 64-bit on most platforms.
        Just use auto here.
        
        Change-Id: I5b45220b79cd4798bafdb416ad7a44eb4d5d1f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150320
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [99be03fc96c481e2ffb5372d19f8e63932e679b7]

        add some debugging on failure to find impress_all
        
        Change-Id: I4d303f7f60bb0f086fad8f3883dee1393a5d6eb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [5464a1dad69c52d011b194baf7d543ce8dd27748]

        Resolves: tdf#152619 crash inspecting uninserted XFieldMaster
        
        Change-Id: I765dd5d7e1ed2c1749841491a50216a6afe903c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [c0d3b50213ffbed1cd58226a35e325fb7c769ec0]

        pointer is always dereferenced make it a reference
        
        Change-Id: I77c5dc3a4d4f290f5020019f3f455b1fec2497ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150350
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [5652ecbf8bf9bf8b3c15764c38d26fe4b449cb64]

        use more string_view in PrinterInfoManager
        
        Change-Id: Ib0173b1a33be7156c27c81b0804ac7c4d3373857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [041e0d0943dffc2002a21ba7a157200766ecd644]

        remove unnecessary exportStyleFamily method
        
        Change-Id: I59c75494ffd3f132a041beebb4336714c1e94143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [62541620ef1c8d3720e6e96b5d4eed7be8562db5]

        use more string_view in SwHTMLParser
        
        Change-Id: I49675277766146c948886b58c8eeaecb7e41b90b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Miklos Vajna  <vmiklos@collabora.com>  [8c8e4ae16472a1a234b02144bb075dc179dfd6df]

        tdf#154451 uitest: use more oneprocess mode
        
        Execution time changes:
        
        - UITest_writerperfect_epubexport: 20,023 -> 6,083s
        - UITest_svx_table: 15,214s -> 14,378s
        - UITest_cui_tabpages: 13,561s -> 12,503s
        - UITest_math_demo: 19,737s -> 13,578s
        
        Change-Id: Ide03d5d9cb884297291a5ed1351de5a7602fcba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150346
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-13  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [94de79e7d3c980b576192d2f264bee658716163a]

        tdf#154481 sw DOCX import: fix page loss and freezing at ODT export
        
        Disable TOC creation in case when field context stack
        is empty but TOC creation is in progress in textboxes.
        Before if TOC creation failed because it is already
        existed, the TOC creation member (mbStartTOC) kept
        true resulting in broken textbox handling.
        
        Textbox and TOC import use the same text append
        stack but the TOC was not removed from the stack
        so content have been written into the TOC instead
        of the textbox, resulting page loss, and because
        of the broken structure, freezing at further ODT export.
        
        Change-Id: If27aa477c49f276d4e538b6e125798d89f0ac423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150099
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [52aa46468531918eabfa2031dedf50377ae72cf7]

        query getUserAllowsLinkUpdate for the case of content in a floating frame
        
        similarly to how it works for the more common "normal" embedded objects
        
        Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [3a727d26fd9eb6fa140bc3f5cadf3db079d42206]

        adjust IFrameObject so it could reuse mxFrame for a reload of content
        
        Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [f93edf343658abd489bde3639d2ffaefd50c0f99]

        use parent window as dialog parent
        
        it makes no odds, but is more convenient for upcoming modification
        
        Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Caolán McNamara  <caolanm@redhat.com>  [183e34a3f8c429c0698951e24c17844e416a3825]

        extract a OCommonEmbeddedObject::SetInplaceActiveState for reuse
        
        no behaviour change intended
        
        Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-13  Szymon Kłos  <szymon.klos@collabora.com>  [f24b1ebec698fd1f956530d48a50985a99659172]

        Content Control Properties dialog alignment
        
        Make explicit that ok/cancel buttons should be the last row
        
        Change-Id: If22da5222fc9dc1c1c5f94fd08c945364284daee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146904
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150095
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e0ddf586eab00831b7c3755c0647d8fdfcec681]

        use more string_view in SwHTMLParser
        
        Change-Id: If1dcb2e4207b15eb71bd79469f89526c76f05772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [20daf957baea858e57630207896152e740a2fd59]

        fix SwHTMLParser::InsertCommentText
        
        which went wrong in
            commit 7a504c8752bf7c5accbb9bcc33a98f79b31b8bf2
            Author: Palenik Mihály <palenik.mihaly@gmail.com>
            Date:   Fri Aug 9 13:51:08 2013 +0200
            Change String to OUString in SwHTMLParser class
        
        Change-Id: I7623e5fe1f4ca07adff8de11d7c01b1cea3733d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150334
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [9470fca71139f9e439ce61b4c93dd33022c2cc6d]

        deduplicate o3tl::trim
        
        Change-Id: I5d4b3555b59b5abf622c389662e83cbd0f7d142d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150213
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-13  Michael Meeks  <michael.meeks@collabora.com>  [15f0fd06346618c772466993598df5fd25181202]

        lok: trim glibc allocator's pending heap when called.
        
        Change-Id: I8d1bda01a0e6ccff0fa868013c67c0fbbf78a836
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150299
        Tested-by: Jenkins

2023-04-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [209e859c3e78d5818df3e3f84669aaa2a3810c01]

        no need to allocate these separately
        
        Change-Id: Icc24e0aaf1762e5b318b8364dd9fdb496edfb77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Miklos Vajna  <vmiklos@collabora.com>  [17367a67cd39109006060176b04bc2b174a17e48]

        sw floattable: restrict selection of follow flys
        
        Select a follow flys that is at the top of the page, drag it towards the
        bottom of the page, release it, it'll jump back to its original
        position, which is frustrating.
        
        The reason for this is that the layout ignores the vertical offset for
        follow flys on purpose, but this is communicated to the user poorly.
        
        Fix the problem by selecting the master fly on fly selection (for split
        flys), this allows changing the horizontal position for all flys in the
        chain and changing the vertical position for the master flys. This is
        now less confusing, since the indicator of the new position is also
        drawn for the master fly.
        
        This is somewhat similar to what
        7596e26fd259ce5445212949403e7cd32303b2bd (Add
        SwTextBoxHelper::findShapes, 2014-06-24) did for textboxes, but there we
        selected the owning draw shape of the fly frame.
        
        Change-Id: Ie8171d32a306bfb5d28cc750db5bbae6021ef72f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150310
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [852af3af0dde3810e323afc3d42d7bd1cd4e67bc]

        Fix UBSan function-type-mismatch
        
        ...as seen with the additions to CppunitTest_i18npool_transliteration made here,
        
        > i18npool/source/transliteration/textToPronounce_zh.cxx:175:17: runtime error: call to function get_zh_zhuyin through pointer to incorrect function type 'unsigned short **(*)()'
        > workdir/CustomTarget/i18npool/indexentry/zh_zhuyin.cxx:1512: note: get_zh_zhuyin defined here
        >  #0 in i18npool::TextToPronounce_zh::TextToPronounce_zh(char const*) at i18npool/source/transliteration/textToPronounce_zh.cxx:175:17
        >  #1 in i18npool::TextToChuyin_zh_TW::TextToChuyin_zh_TW() at i18npool/source/transliteration/textToPronounce_zh.cxx:149:5
        >  #2 in TextToChuyin_zh_TW_CreateInstance(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) at i18npool/source/registerservices/registerservices.cxx:236:1
        >  #3 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceEveryTime(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:173:24
        >  #4 in cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx:230:12
        >  #5 in non-virtual thunk to cppu::(anonymous namespace)::OFactoryComponentHelper::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/factory.cxx
        >  #6 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:709:26
        >  #7 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) at cppuhelper/source/servicemanager.cxx:675:16
        >  #8 in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx:1006:36
        >  #9 in non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) at cppuhelper/source/servicemanager.cxx
        >  #10 in i18npool::TransliterationImpl::loadBody(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&) at i18npool/source/transliteration/transliterationImpl.cxx:619:45
        >  #11 in i18npool::TransliterationImpl::loadModuleByName(std::basic_string_view<char16_t, std::char_traits<char16_t>>, com::sun::star::uno::Reference<com::sun::star::i18n::XExtendedTransliteration>&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:630:5
        >  #12 in i18npool::TransliterationImpl::loadModuleByImplName(rtl::OUString const&, com::sun::star::lang::Locale const&) at i18npool/source/transliteration/transliterationImpl.cxx:278:9
        >  #13 in (anonymous namespace)::Transliteration::testTextToChuyin_zh_TW() at i18npool/qa/cppunit/transliteration.cxx:120:27
        
        For one, there had always been a mismatch between the return type `const
        sal_uInt16**` generated in i18npool/source/indexentry/genindex_data.cxx since
        d319c4611e932b286c0bef14387382da0f2e92d2 "INTEGRATION: CWS i18n24 (1.1.2); FILE
        ADDED" vs. `sal_uInt16**` used in
        i18npool/source/transliteration/textToPronounce_zh.cxx since
        f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE
        MERGED".
        
        And for another (and more severe, as it caused random writes), there had also
        been a mismatch between the parameters `(sal_Int16 &max_index)` newly generated
        in i18npool/source/indexentry/genindex_data.cxx since
        7696cd3902ca248951205f15930787488368ea26 "INTEGRATION: CWS i18n31 (1.4.60); FILE
        MERGED" (and correctly used in
        i18npool/source/indexentry/indexentrysupplier_asian.cxx since
        58dcf0ffaf8668827fc2f47445c9d8faf3d29555 "INTEGRATION: CWS i18n31 (1.9.60); FILE
        MERGED") vs. the original `()` used in
        i18npool/source/transliteration/textToPronounce_zh.cxx ever since
        f4705bf0a3efeebfe74568abb355ad60621300dd "INTEGRATION: CWS i18n24 (1.8.36); FILE
        MERGED".
        
        For DISABLE_DYNLOADING, the second (missing max_index parameter) issue appears
        to have been broken even further with 9db03b879b912d79060ab06f03a54d4a59e6ac65
        "i18npool: fix wrong static function symbols", replacing the wrong
        
            sal_uInt16** get_zh_zhuyin();
            sal_uInt16** get_zh_pinyin();
        
        declarations in i18npool/source/transliteration/textToPronounce_zh.cxx with the
        even worse declarations
        
            sal_uInt16** get_collator_data_zh_zhuyin();
            sal_uInt16** get_collator_data_zh_pinyin();
        
        corresponding to function definitions generated by
        i18npool/source/collator/gencoll_rule.cxx (which also happen to have zero
        parameters, but non-matching return types, and apparently completely different
        collation vs. transliteration semantics).
        
        Change-Id: Id91b17eeb7fcdd0c711d52a624375356dc47fc32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150302
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Justin Luth  <justin.luth@collabora.com>  [cbdd54e41a78e6a567d7ff97935721b07461cce5]

        tdf#105035 writerfilter framePr: don't allow overlap in extreme case
        
        I NEED to do something about preventing overlap
        because in certain cases MS Word (2010/2016 tested) does
        not overlap frames even though their vertical placement
        is identical.
        
        The previous commit just fixed mis-combining separate frames into one,
        but now those frames might overlap each other - which is worse
        than being combined into one IMHO.
        
        Unfortunately, Microsoft's decision to not overlap seems arbirary.
        In most cases it needs to be allowed,
        so I have developed a minimal set of specifications
        that prevent overlap for bug 105035's specific document,
        and it should be flexible enough to allow other cases to be added.
        I tested a number of cases when designing my formula.
        It doesn't seem to prevent overlap for page or margin position.
        It doesn't seem to prevent overlap when set to top/middle/bottom.
        It doesn't seem to prevent overlap if the frames are below the
        first line of text.
        
        I still have a problem: the order of the frames might
        layout wrong - as in this unit test. Sigh.
        
        Too bad this code is so ugly and long,
        but it should be relatively performant.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf105035_framePrB
        
        Change-Id: Iddaf36b9797a38b7906bb980e06cc73da7012eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150063
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-13  Miklos Vajna  <vmiklos@collabora.com>  [95eb99866b3ac1a1639d3399f42f82a0670eb23a]

        sw: fix undo comment of FN_DELETE_FIELDS
        
        It's fields, not field. One has to dispatch .uno:DeleteFields to see
        this in action, which does something if the document already has
        existing reference marks.
        
        Change-Id: I81e3be3f2b68bfee2ed85a2a060dd05c3eb56670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150300
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [00f73472c1342213b7eb48b9e48175db3c9041c2]

        try to fix CppunitTest_framework_dispatch on windows
        
        I see occasional failures here, possibly they are a threading
        issue since we are touching these fields from multiple threads.
        Add a mutex to see if it helps.
        
        Change-Id: I7277e96d07d292a6bc1d333dabec7a82fc607465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150281
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [d8249389f791177464b0b74fc873384433d08947]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 6de8d3109dffa7d4d0cc06f319cca70134f0a8f3
        "tdf#103474 handle edge cases in ARCANGLETO".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I40342955feedad25435c03f16a31b9585281c1f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150306
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [396f3fd0ab1cdabf0b4800b5c45a418534f83e5c]

        -Werror,-Wunused-variable
        
        Unused ever since the two variables got introduced in
        919a4ef592b6026a7533a93682f39118fef29ce8 "tdf#105461 PDF export of editeng fill
        color: restrict to logic map modes" and fddd956c0cf3b2c22a152bbb30554def1336b466
        "tdf#96892 vcl: add unit test for misplaced soft-hyphen ...", respectively.
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I538a8cf410355ca4b5230f89947587b58d67e205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150304
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Stephan Bergmann  <sbergman@redhat.com>  [8a4fdf8a18fac2829b5a95ce9e3f4323f5eec9b4]

        -Werror,-Wunused-variable
        
        Unused ever since it got introduced in 463178fef5c22f1a04d10e54491852d56e2038b0
        "xmloff, sw: ODF import/export of fieldmark separator".
        
        (Found with an experimental Clang build supporting __attribute__((warn_unused))
        on individual ctors rather than just whole class types, and the corresponding
        css::uno::Reference ctor marked accordingly.)
        
        Change-Id: I8d665d12f923725773f6a55f7edee70ebc72e3ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [fc893169d37ae78d34b6a127bc920bc5b887711a]

        tdf#153806 sw a11y test: Drop obsolete workaround
        
        This is no longer needed with
        
            commit d1f5b3c5cb226fd5f58fe2cdc8be9d1330fad6a2
            Date:   Sat Apr 1 23:35:50 2023 +0300
        
                tdf#153806 a11y: Improve keyboard interaction in special char dialog
        
        in place. The insert action is available right away now.
        
        Change-Id: Id47f306ba17ed428a4bfc978177e367991509eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150289
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-13  Patrick Luby  <patrick.luby@collabora.com>  [127eacf630e1712fd5addcabed404b2d33752311]

        Related: tdf#153374 Don't release autoreleased attributeNames
        
        Also, return an autoreleased empty array instead of a retained array.
        
        Change-Id: I5f494b301dbae859486d6bc4874112b714022b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150307
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [cf9f73ae78aa9654064abde8411ea2f921c38354]

        tdf#140730 a11y: Focus form control property dlg when it starts
        
        Make sure the dialog gets focus again when it
        starts after having been welded in
        
            commit 1efeb17837c22499f00299c033ae59ba3910f7d7
            Date:   Mon Nov 4 13:06:04 2019 +0000
        
                weld Property Browser
        
        (Tested with gen, kf5 and on Windows.)
        
        Change-Id: Ie5d28a60b459735d1f1fa4c2d5d679f3d5a27cec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150284
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-12  Mike Kaganski  <mike.kaganski@collabora.com>  [53a4b94d018820689e0b98d7fa0a92563e3971a1]

        Use more *string_view
        
        OUString::equalsIgnoreAsciiCaseAscii and compareToIgnoreAsciiCaseAscii
        taking string_view are added as overloads, rather than replacements to
        the variants taking const char*, because the latter have benefit when
        the passed C-style string's length is unknown, because these variants
        don't pre-calculate the length.
        
        Change-Id: I2def689d7b7784212dc6cd6b8ae9ab1d42604079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150272
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-12  Mike Kaganski  <mike.kaganski@collabora.com>  [d4257802159e672035fab164b0cabd9222f18515]

        Use o3tl::trim in strtmpl.hxx
        
        Change-Id: I4de8658c36c21fe07fa45f697cf3145c567a95c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150210
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-12  Michael Weghorn  <m.weghorn@posteo.de>  [d446be648385a451c60ba3bd1657906f72a63e75]

        qt: Don't show non-visible menu entries
        
        Take the visibility of the menu item
        (that e.g. gets set in `QtMenu::ShowItem`)
        into account when updating the menu in
        `QtMenu::DoFullMenuUpdate`.
        
        With this in place, only the relevant entry is shown
        in the context menu for items in the character table
        in the special characters dialog (Writer: "Insert" -> "Special
        Character") while previously, the "Add to favorites"
        and "Remove from favorites" entries would both be shown
        at the same time regardless of whether the character
        was present in the favorites or not.
        (Both entries would actually do the same: add the character
        if it was not present in the favorites, remove it if it
        was already there...).
        
        Change-Id: Ica5f07d6009d97db2df0540293b096565bf1dd52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150285
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [cdd8bb13d95d849eb1211f789896589d06bea564]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5eebbe317f7515c901355e1a14e5374169f0223c
          - tdf#154689 clarifications for "to" and "Horizontal
            
            Change-Id: I05fcbb9fe7628783a89807f91b215d397a7586d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150206
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-12  László Németh  <nemeth@numbertext.org>  [9a62e50d72bdcc786df4ea6094b349d1b3215b56]

        tdf#154771 sw: fix drag & drop moving of table columns
        
        Only first selected column was moved, the other ones
        were copied during drag & drop moving of table columns.
        
        Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2
        "tdf#146967 sw table: fix freezing in Hide Changes mode".
        
        Follow-up to commit 912336f3c85d9a631fa0ac0f270bab04b204f619
        "tdf#154599 sw: fix crash at drag & drop table columns".
        
        Change-Id: I31ca5b3d6004ed53c11a951fa184b9db48f21041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150280
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-12  Noel Grandin  <noelgrandin@collabora.co.uk>  [5944f8dc9a20c5c1cd450cd457bcc973f649b7ca]

        mpMouseLeaveTimer has been dead
        
        ever since it was added in
            commit 8229967979d96bd01e63e2954b7af35a57d9e08c
            Date:   Thu Sep 20 15:23:39 2007 +0000
            INTEGRATION: CWS os2port01 (1.2.2); FILE ADDED
            2006/11/29 14:34:20 ydario 1.2.2.1: Initial OS/2 import.
        
        Change-Id: Ic1bbf9f9167f9a7146f3c7d18b6fdb69c1f44e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Noel Grandin  <noelgrandin@collabora.co.uk>  [9cfa99594cc21ad42f3428c4e2c521dd87511fc2]

        use more unique_ptr in SalData
        
        Change-Id: Ib6e5131bff38b55b2dbf0805b63ca3554c5ee349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150278
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Sarper Akdemir  <sarper.akdemir@collabora.com>  [a925476352b3cb32f6384e7b0fb07e323bb6e64f]

        xmloff: ODF import/export for style:overflow-behavior "clip"
        
        Adds initial support for style:overflow-behavior
        
        According to OpenDocument-v1.3-part3 style:overflow-behavior can take
        values of:
        - "clip"
        - "auto-create-new-frame"
        
        This patch doesn't properly implement support "auto-create-new-frame",
        only "clip".
        
        If "clip" is set, TextClipVerticalOverflow is set to true, causing the
        vertical overflowing text to be clipped.
        
        "auto-create-new-frame" is treated the same as omitting the
        style:overflow-behavior attribute, setting TextClipVerticalOverflow to
        false.
        
        Change-Id: Iea298f41fbf0cf18dc07f41788ba0b665515db8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150122
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-12  Bayram Çiçek  <bayram.cicek@libreoffice.org>  [9bee4cec215e2694f6e6e1aa4a463b47b69cc1ff]

        tdf#39593: remove trim(), use o3tl::trim() instead
        
        trim(std::u16string_view in) and trim(std::string_view in)
        functions were removed and replaced with
        o3tl::trim(rString) function
        
        Change-Id: I29b2274422dbfe9dc26177c3e1dbf20786c811d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150245
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c5c1e831aaf139379134fee63797f02ca5a75e5]

        Revert "remove unnecessary UnoControlModel::setPropertyValues"
        
        This reverts commit 19c18c94085f7a70e536a914ed978fc54b5625b9.
        
        Because it breaks the MRI extension, I was wrong, it does not
        do quite the same thing as its superclass method.
        
        Change-Id: I65bfb4264615dea5f6d0f2fb7b989352e7e83ee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150274
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [81dc568ab3f504bca58810da0b0bd3c4c2737096]

        lok: capture and publish the modified status in save result
        
        This is necessary to flag to the storage whether or not
        the contents of the file being uploaded has any user
        modifications or not. This is typically used to optimize
        the versioning and storage utilization.
        
        We also add the time when saving started and the duration
        it took. The timestamp is to figure out if there has been
        subsequent activity/commands that could have modified
        the document. The duration is to help Online throttle
        saving if too frequent.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: Id6d8e629ef9b6e723d1d8b84d64fc7741b997bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149985
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ca9df86986e5cc5d60e74b9325cf0268dbacbfd4]

        Remove duplicated include
        
        Change-Id: Iff23fcd5d88ce33d66f5f7255d0967c695b91f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150247
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [6629bdff20602935f042838ede5e8986a120b5f0]

        use more unique_ptr in ImplSVWinData
        
        Change-Id: Id1d42e2de480e8ec248e5716ababc8bddfc905ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [00a9b9bcd12bacafa2d81a11233b9c88669da6f1]

        rename intern->internal
        
        where appropriate
        
        Change-Id: I440d277e7be242eeecb7767fa11d1c4dad937e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [669c7505358e0362d8829a79994946239c2cc7ce]

        tdf#153903 "Numbering" -> "Number" for "number range" cross-ref format
        
        Change-Id: I5857e7b42177b9b6db4903371e14a7d30822ce45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150137
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [c45bc08dc6e64352e11cf632b8ad868c312a62fe]

        loplugin:stringview whitelist getLength and isEmpty
        
        Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [08495e24e899c2fd52b9724d993598189e12fc7e]

        OUString::intern is a relic
        
        and a pessimisation. Remove usage thereof.
        
        Change-Id: I98f6197aa375349b909a7ef1403ec06ca37890d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Miklos Vajna  <vmiklos@collabora.com>  [8f9523b3ef464731afed61a253c958644fca6335]

        sw floattable: don't try to set left margin as cell property
        
        Cell UNO objects don't have such a property, and this generates a
        warning on importing sw/qa/core/layout/data/floattable.docx, silence it.
        
        Change-Id: I573c6f95edb8577e70518a9c21119a0e32b6a411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150271
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e8de03a18ed8684ed94d93b09aa1662ba799e877]

        tdf#116127 - Add EDITATTR to ALL flags to check for valid function inputs
        
        Otherwise, the function clearcontents does not accept the EDITATTR flag as a valid input.
        
        Change-Id: I8381014da7110d060167a814d9ea02e347d5a92b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150191
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [505647d63726ce526d9ecd544954f3ce3e1af95a]

        remove unnecessary method
        
        Change-Id: I9ef8f2cb2e3836c879532f690794df642c2449de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150255
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f463511fb8712312c94211e34a0fbcd70069108]

        loplugin:stringview and stringviewparam, whitelist equalsAsciiL
        
        since we have a o3tl::equalsAscii that can handle that
        
        Change-Id: I0ae3b81cd5b4d97a0aef92cb6586cf365ee042b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150239
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Miklos Vajna  <vmiklos@collabora.com>  [c50bf5a5daaae3d40f89ea0784a75a8a571c208d]

        sw floattable: remove no longer needed DOCX import heuristics
        
        Now that IsFlySplitAllowed() is true, m_aPendingFloatingTables and
        related code can go in writerfilter/.
        
        Change-Id: Id69e13e82fc447ad56b9f3926e353c203e600141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150257
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2a7ab2ab7786ab88b1bdbbe5e4b00ea8e93636f7]

        oox: add model::EffectStyle and import effect style elements of a theme
        
        Extends the SwCoreThemeTest with effect style use-cases-
        
        Change-Id: Ifcb96a860fcbc0aae65e8ec276e069f7f60fb950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149361
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-12  Vojtěch Doležal  <dolezvo1@cvut.cz>  [b8cc40c906d4838b028e332e9dabbacba7f7c033]

        Replaced ...ASSERT with ...ASSERT_GREATER in vwNBSP tests
        
        Change-Id: I3d1584de37873ead53d317b033f3611974183c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150025
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-12  Justin Luth  <justin.luth@collabora.com>  [e0e33aa622968bc2e182099670a024a1d00b8e5c]

        tdf#105035 tdf#127622 writerfilter framePr: compare using style info
        
        Prior to this patch, we were only comparing frame definitions
        based on direct formatting properties.
        
        Well, the definition can be spread throughout the paragraph styles,
        and only if the end result matches will they all be part of one frame.
        
        This patch fixes bug 127622 where three different styles all had
        the same framePr settings.
        
        It partially fixes bug 105035 - the frame is split in two - but
        now the frames overlap. There is no "overlap" tick box in MSO,
        although they do allow overlap - just not from other framePr text.
        So this could end up giving me a lot of grief, where two frames
        joined look OK, but split they will almost inevitably be stuck
        overtop of each other - like we previously saw in bug 127622.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf127622_framePr
        
        Change-Id: Ie9ce9076d06029b8789a95b46f4ed49190ab09f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150036
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [53692ac7b3d5171453a797998337a6269763f657]

        sw: remove debug leftover
        
        Introduced by ff4f2ba3242d303f7f238a7a142440f1f4b1f288
        "sw: DOCX: recognize TOC title during import"
        
        Change-Id: Ibaaf2071b903cdcfdd059cef8dde57f38a88e049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150103
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-12  Miklos Vajna  <vmiklos@collabora.com>  [ce3308a926f036b87515b8cd97d2b197063dc77a]

        tdf#61594 sw floattable: import floating tables as split flys by default
        
        To get wider testing.
        
        Change-Id: Ic05844c6ae48429feb9a0cd3217a7afce6c902dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150252
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-12  Miklos Vajna  <vmiklos@collabora.com>  [31b365d1fe49eb71409ff78ff3fbcc7fface4040]

        UITest_sw_{navigator,findBar,classification,chart}: enable oneprocess mode
        
        Execution time changes:
        
        - from 2m5,297s to 1m28,636s
        - from 20,711s to 14,122s
        - from 18,361s to 14,835s
        - from 15,874s to 14,810s
        
        for me.
        
        See tdf#154451 for motivation.
        
        Change-Id: I7d5735f9b900568c7f7aa61ce7be5e622bd9fc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150253
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c288a18e7052de2a42d25ca04c0cda7badf9f95]

        fix o3tl::equalsAsciiL
        
        after I got it wrong in both the original commit
            commit d15a6560bd445cd1931e9fded6ad8ecfdd54211b
            use more string_view
        and in the attempted fix
            commit dd41ea3ec1f579fabb9f674184b52c1be77e2fdb
            fix for o3tl::equalsAscii
        thanks to sberg for spotting that
        
        Change-Id: Iff12879de823553b2623db48979e9a720302f2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150240
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f69614d8115e9d62752f1c59c0fdcd697a9ded2c]

        oox: add model::LineStyle and import line style elements of a theme
        
        Also extend the SwCoreThemeTest with asserts for the LineStyles
        for the example theme.
        
        Change-Id: I72aa64345d39fea84544e39b0a37a22f3e6baa5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149360
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0ffa50031eb33500a3530ece76ea32d15864f345]

        oox: add model::BlipFilll and import blip (graphic) fill elements
        
        Change-Id: I610b732b1fd4eebcfcc55acb6f04a8acf84f92b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147954
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [17167dbede715de4792a48149b8603f384555f80]

        oox: add model::PatternFill and import pattern fill elements
        
        Change-Id: I49ef33fd81509599f4081e6a913b05dae1e4a642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147953
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-12  Patrick Luby  <patrick.luby@collabora.com>  [1b06f35de68a555b85bceb5fc29d1a5f426f4bb7]

        tdf#154708 Preserve selection for repeating Shift-arrow on Japanese keyboard
        
        Skip the posting of SalEvent::ExtTextInput and SalEvent::EndExtTextInput
        events for private use area characters.
        
        Change-Id: I6fa5dedacefc5d9dd671f607786deb999f5e4c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150248
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [436c280392ff22b53f10d8399f4e5ac0d99d0fd2]

        CppunitTest_sw_ooxmlexport10: split in two
        
        it already has 104 tests
        
        Change-Id: Ib3b4bf342af73aaf3c925d79bd0a06cee4853c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150234
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [9c933a9221639ade1814b2ee7b01dd927af7157e]

        tdf#154761: each dl needs a dd to actually indent
        
        Change-Id: Iaa75048b33ab82250d205cbf821e57425754ef5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150244
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-11  Stephan Bergmann  <sbergman@redhat.com>  [fe0fbb166233b53d43e1eab61d110c37bac2fb5a]

        loplugin:stringadd
        
        Change-Id: Ib35058e0e8d1708c29f4fe727eda05f5a6de4ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150232
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-11  Stephan Bergmann  <sbergman@redhat.com>  [5b6ed0abb8279a0b2858dad60435cb2494887014]

        loplugin:stringadd
        
        Change-Id: I8437b896feb54b3162fd846861d6de0879ed2690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150233
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-11  Caolán McNamara  <caolanm@redhat.com>  [658c2c98c98662eb06f22c1b743f10281e191c16]

        tdf#154753 if substituting with OpenSymbol check if there for a recode
        
        entry for that font->OpenSymbol conversion. It might make sense to drop
        the conditionals and just use the result of ConvertChar::GetRecodeData
        if there are any, but keep close to what has worked historically.
        
        Change-Id: Idf9ee0f8068f1ff8e7f179ba5087763e44ade268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-11  Michael Stahl  <michael.stahl@allotropia.de>  [d57abff54db6860c3e263c8874c6b606e1ba1088]

        officecfg,cui,sw: add Common::Load::ViewPositionForAnyUser
        
        Add setting Office::Common::Load::ViewPositionForAnyUser which if
        enabled skips the user name matching against meta.xml that sw does
        before restoring a view position stored as ViewTop/ViewLeft/etc. in
        settings.xml in an ODF file.
        
        This is particularly useful if the user disables the "ApplyUserData"
        in Document->Properties->General, which made restoring view position
        impossible.
        
        Change-Id: Ie3ced3c4ad20a35eb8453ad1521c787b0b0c8458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150113
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-11  Tünde Tóth  <toth.tunde@nisz.hu>  [7460e4f4a7b15cc7984adf65bc17e3d580413224]

        tdf#154469 DOCX export: fix hyperlink in group shape
        
        Hyperlink inserted to shape lost after export,
        if the shape was inside a group shape.
        
        Follow-up to commit 7f4f88b883f81fbce975f72aea0f66a54e269ead
        "tdf#145147 DOCX import: fix hyperlink in group shape".
        
        Change-Id: I48b582c04b6f779cb5393179f65a32d7a7eca5ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149716
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-11  Tibor Nagy  <nagy.tibor2@nisz.hu>  [b7c542b5085374f1d031183cb86ceeefcf24964d]

        tdf#154363 sd: fix line connectors regression of mirrored shapes
        
        caused by commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8
        (tdf#89449 PPTX import: fix line connectors).
        
        Note: partial revert of commit 9ab16e2738b4b9bd324c9aded8acb2ecba0fd2b0
        "oox: fix crash in lcl_GetGluePointId by removing unused code".
        
        Change-Id: Icc45c93c4fa3a22c0f34866ccb64ea6b9037d936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149676
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-04-11  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [b77775de1ab530912153a9fcc571efb300c2888e]

        sw : small code simplification in lcl_IsInSameTableBox
        
        Change-Id: Ic72a49deee17d907639e67ef31e0ca932bf66215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150188
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Jean-Pierre Ledure  <jp@ledure.be>  [9c60996fc2a536803d016d6f60f879f8a1e49a54]

        ScriptForge - (SF_FileSystem) tdf#154462 2nd call of PickFile() fails
        
        Error happens in gen and gtk3 modes.
        Does not happen in kf5 mode.
        
        Linux only. Windows OK.
        
        Change-Id: Ia5dd21f6879c1a732d291d15d6fb9f4bf20c76e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150238
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1ad6834e1c08ea59e85bfa8a1e47d81e2a92533]

        avoid some OString<->OUString back and forth conversion
        
        Change-Id: I20d2611ca88df7daca7c56e7475fb85f98fbf888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150226
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [38640d7cb4dd6c19cd9f0c944536dfc1ccec1bf8]

        use more string_view in filter
        
        Change-Id: Icbccd81fd0fa18fc15a32aa2729b1c5f9a3ee542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150220
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ac1dd864bc535a25caa91c44e7d94b8b8ab9024]

        use more string_view in o3tl::equalsAscii
        
        Change-Id: I1445a179e0007152b96436da4520c30a6fe6575c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Caolán McNamara  <caolanm@redhat.com>  [dde90d1d06ab5f660d8f2cc729587698361e6748]

        set Referer on loading IFrames
        
        so tools, options, security, options,
        "block any links from document not..."
        applies to their contents.
        
        Change-Id: I04839aea6b07a4a76ac147a85045939ccd9c3c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150221
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [34331280c89e51331303fd6f7d5b39aadf88b638]

        sw: remove duplicated code
        
        Change-Id: I200061d0624318abdc8f2850661a0b8c0005bfe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150227
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3ce1616ea371e0efd317290bb4f943f319404800]

        tdf#153923: In ReqIF case, avoid fake dl/dd used to emulate indentation
        
        Change-Id: Iac85350c8f52a39173a07131c67e7dc943aa140e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150229
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-11  Baole Fang  <baole.fang@gmail.com>  [487010ef62405a1a728ae9b3d838e934015b1719]

        tdf#150477: Change "Slide" to "Page" in Draw status bar
        
        Originally, Draw displays "Slide x of y".
        Now, a new string is added, so that it displays "Page x of y".
        
        Change-Id: I5857626b5a18decda4bf235b67a3c7d877556e94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149671
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa0d09541d451c14afa3de6e6173664827593f58]

        CppunitTest_sc_pivottable_filters_test: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I4e2786f11bc1c164a74d3f5a3795a2ddf289d65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150222
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee7746227645ea2307ed803cce7bb51f2d7678a7]

        CppunitTest_emfio_emf: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I476b58a1c45ed5c977ce71a92d172b7e2df93015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150224
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [886fb2fe7275469a7bd586b99705784a012c67f6]

        CppunitTest_vcl_outdev: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Icfbfede5663d93eca10d7585313b51c3e19303bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150223
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [de7ec4141d07d11330ffae8caafaa259fc8016b4]

        loplugin:unnecessarygetstr check for OUString::number facilities
        
        These were fixed by mike kaganski, but add to the plugin to prevent
        future mistakes
        
        Change-Id: I09b4b094a74e02399e017ccf5631c0d68052344a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Stephan Bergmann  <sbergman@redhat.com>  [dc80c92a1e63fd88560fd77261b96f6c5be97273]

        Fix heap-buffer-overflow
        
        ...during CppunitTest_sc_ucalc, after 40e3e9fd1c501cc1978d4370b6392701ccd42a71
        "tdf#113027 - Allow cycling cell reference types including whitespaces",
        
        > ==5140==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x604000cfba74 at pc 0x7f36cb07ef6e bp 0x7ffd061d34d0 sp 0x7ffd061d34c8
        > READ of size 2 at 0x604000cfba74 thread T0
        >     #0 0x7f36cb07ef6d in (anonymous namespace)::FindEndPosR1C1(char16_t const*, int, int) /sc/source/core/tool/reffind.cxx:91:13
        >     #1 0x7f36cb07cf0f in (anonymous namespace)::FindEndPos(char16_t const*, int, int, formula::FormulaGrammar::AddressConvention) /sc/source/core/tool/reffind.cxx:126:20
        >     #2 0x7f36cb07b029 in ScRefFinder::ToggleRel(int, int) /sc/source/core/tool/reffind.cxx:262:28
        >     #3 0x7f36c7b8482b in testTdf113027::TestBody() /sc/qa/unit/ucalc.cxx:467:13
        >
        > 0x604000cfba74 is located 0 bytes to the right of 36-byte region [0x604000cfba50,0x604000cfba74)
        > allocated by thread T0 here:
        >     #0 0x4b7c20 in malloc /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_malloc_linux.cpp:145
        >     #1 0x7f371b927c59 in _rtl_uString* rtl::str::Alloc<_rtl_uString>(int) /sal/rtl/strtmpl.hxx:833:46
        >     #2 0x7f371b92640f in void rtl::str::newFromStr_WithLength<_rtl_uString, char>(_rtl_uString**, char const*, int, int) /sal/rtl/strtmpl.hxx:947:15
        >     #3 0x7f371b9797f0 in rtl_uString_newFromLiteral /sal/rtl/ustring.cxx:1252:5
        >     #4 0x7f36c7dab771 in rtl::OUString::OUString<char const [14]>(char const (&) [14], rtl::libreoffice_internal::ConstCharArrayDetector<char const [14], rtl::libreoffice_internal::Dummy>::Type) /include/rtl/ustring.hxx:365:13
        >     #5 0x7f36c7b843e8 in testTdf113027::TestBody() /sc/qa/unit/ucalc.cxx:462:31
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2739/>)
        
        Change-Id: Ie8d053cdb56bdf00bf21663b05521eca632ddfbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150219
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2023-04-11  Stephan Bergmann  <sbergman@redhat.com>  [d1fec382c82f65d49008676525ad7935f8ad9098]

        Avoid UB converting from double to sal_Int16
        
        ...e.g. during CppunitTest_sd_import_tests,
        
        > /oox/source/drawingml/colorchoicecontext.cxx:280:78: runtime error: 35000 is outside the range of representable values of type 'short'
        >     #0 0x7f3b8abf6278 in oox::drawingml::ColorValueContext::onCreateContext(int, oox::AttributeList const&) /oox/source/drawingml/colorchoicecontext.cxx:280:78
        >     #1 0x7f3b8abf6534 in non-virtual thunk to oox::drawingml::ColorValueContext::onCreateContext(int, oox::AttributeList const&) /oox/source/drawingml/colorchoicecontext.cxx
        >     #2 0x7f3b8a94baff in oox::core::ContextHandler2Helper::implCreateChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx:100:34
        >     #3 0x7f3b8a94eabb in oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx:204:12
        >     #4 0x7f3b8a950484 in non-virtual thunk to oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx
        >     #5 0x7f3b43e81c45 in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:164:67
        >     #6 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #7 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #8 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #9 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #10 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #11 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #12 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #13 0x7f3b43e8299e in DOM::CElement::fastSaxify(DOM::Context&) /unoxml/source/dom/element.cxx:181:20
        >     #14 0x7f3b43df8a50 in DOM::CDocument::fastSaxify(DOM::Context&) /unoxml/source/dom/document.cxx:289:20
        >     #15 0x7f3b43e117af in DOM::CDocument::fastSerialize(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastDocumentHandler> const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastTokenHandler> const&, com::sun::star::uno::Sequence<com::sun::star::beans::StringPair> const&, com::sun::star::uno::Sequence<com::sun::star::beans::Pair<rtl::OUString, int> > const&) /unoxml/source/dom/document.cxx:1023:9
        >     #16 0x7f3b8aa55f81 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastSAXSerializable> const&) /oox/source/core/xmlfilterbase.cxx:470:23
        >     #17 0x7f3b8bd30d0f in oox::ppt::PresentationFragmentHandler::importSlide(unsigned int, bool, bool) /oox/source/ppt/presentationfragmenthandler.cxx:357:41
        >     #18 0x7f3b8bd3cd16 in oox::ppt::PresentationFragmentHandler::finalizeImport() /oox/source/ppt/presentationfragmenthandler.cxx:543:17
        >     #19 0x7f3b8a9f79ae in oox::core::FragmentHandler2::endDocument() /oox/source/core/fragmenthandler2.cxx:53:5
        >     #20 0x7f3b548344f0 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:897:36
        >     #21 0x7f3b54855150 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1469:13
        >     #22 0x7f3b8a97ff11 in oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) /oox/source/core/fastparser.cxx:121:15
        >     #23 0x7f3b8a9806a8 in oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) /oox/source/core/fastparser.cxx:129:5
        >     #24 0x7f3b8aa548a4 in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) /oox/source/core/xmlfilterbase.cxx:412:21
        >     #25 0x7f3b8aa531fd in oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&) /oox/source/core/xmlfilterbase.cxx:342:12
        >     #26 0x7f3b8bcbaf54 in oox::ppt::PowerPointImport::importDocument() /oox/source/ppt/pptimport.cxx:109:17
        >     #27 0x7f3b8a99493c in oox::core::FilterBase::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/core/filterbase.cxx:488:49
        >     #28 0x7f3b8bcbe067 in oox::ppt::PowerPointImport::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /oox/source/ppt/pptimport.cxx:192:24
        >     #29 0x7f3b7a89c1c6 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2272:34
        >     #30 0x7f3b82834e18 in sd::DrawDocShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sd/source/ui/docshell/docshel4.cxx:429:39
        >     #31 0x7f3b7a85bd64 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:739:23
        >     #32 0x7f3b7aa63c10 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1940:36
        >     #33 0x7f3b7b1c142c in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:720:28
        >     #34 0x7f3b4ff0f5fb in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1176:37
        >     #35 0x7f3b4ff059fb in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:412:20
        >     #36 0x7f3b4fefd8bc in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:308:5
        >     #37 0x7f3b4fef8c50 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:168:14
        >     #38 0x7f3b4ffc334d in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:593:16
        >     #39 0x7f3b4ffc3576 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
        >     #40 0x7f3b5feedd95 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:71:62
        >     #41 0x7f3b75b0aef9 in UnoApiTest::load(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:115:11
        >     #42 0x7f3b75b0baf4 in UnoApiTest::loadFromURL(std::basic_string_view<char16_t, std::char_traits<char16_t> >, char const*) /test/source/unoapi_test.cxx:127:5
        >     #43 0x7f3b95d2f402 in SdModelTestBase::createSdImpressDoc(char const*, char const*) /sd/qa/unit/sdmodeltestbase.hxx:54:13
        >     #44 0x7f3b95d025c8 in testBnc584721_1::TestBody() /sd/qa/unit/import-tests.cxx:1281:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2741/>).
        
        Presumably it was just a typo that f707834e8538c0a183716b26ebdf04381482ca6d
        "oox: write color transforms to model::ColorDefinition" used 10.0 rather than 10
        as divisor.
        
        Change-Id: I42de6daaa6db86bf4444243ec2c9173d6d514b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150216
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd41ea3ec1f579fabb9f674184b52c1be77e2fdb]

        fix for o3tl::equalsAscii
        
        from
            commit d15a6560bd445cd1931e9fded6ad8ecfdd54211b
            use more string_view
        where the new method was named incorrectly
        
        Change-Id: Ia4513fa67f5bda8b6cb56e3db22df48b5e3c7283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c0e82975c21d702f962784ee5ddb7435e6d7c922]

        add fetch to dependencies of gbuildtojson / Rdb target
        
        Change-Id: Icd3535a90fc0a13b1df8f412e8a1a50e9d5e5b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150052
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bdd96fb801627b0accd81ff33be034c19fe193ba]

        accept aarch64 JDK for win/aarch64
        
        the check is only done for windows & mac since the property can have
        arbitrary values - in OpenJDK it is hardcoded for windows, but for other
        platforms it can come from autoconf. For a more detailed explanation
        see f05a42ef8c8192186f91a169047742e5c3ae9b9e
        
        Change-Id: I8555ef3b7153a9b744b45cf07deae3c3a1d48ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150119
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [93f9a747e0603ff3c38f44c43153f88e89d178c8]

        fix dbgutil build on win/aarch64 (print stack from cppunittester)
        
        Change-Id: I632607599060e625bda3dabee627ae1ddd6bd709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150102
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d04f1cf9373e4fa7dd6d3db660393894916e41a8]

        allow native compile for windows aarch64
        
        using both --host=aarch64-pc-cygwin and --build=aarch64-pc-cygwin on a
        suitable system.
        
        Change-Id: Id11e25b03de8dd8dd52c63e7a06d57d44e3fce33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150053
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-11  Stephan Bergmann  <sbergman@redhat.com>  [8029a239cf294d06bb9f29aeb9b6897cb422a880]

        loplugin:stringadd
        
        Change-Id: I2dec226b3fb17f5ea361673139f2511ce7c3fe89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150214
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [1155def95bfe5b43f2b68e6c85632716df87bcf8]

        Drop Writer::OutLong
        
        ... and use SvStream::WriteNumberAsString, replacing Write[U]Int32AsString
        
        Change-Id: I10e56c532494239ed40ec01b6184dd06db463a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150193
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-11  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b614797a34d25b35c06e20153495795ecfe4e4fe]

        introduce SwFrameFormat::IsVisible()
        
        - as a replacement for RES_CONTENT_VISIBLE
        - broadly: if a FrameFormat has at least one Frame, it is visible
        - however, sections are special and need to recurse into their childs
        - SwFlyFrameFormat::GetInfo then does not need to override anymore
        
        Change-Id: I01c469e7330a7daaccd2be0541af1d83c7d1a424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150038
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-04-10  Eike Rathke  <erack@redhat.com>  [fc6806c4be8585ce0d35a6b581bf8b3dbf858500]

        Related: tdf#154218 Use proper locale in SwUserFieldType::PutValue()
        
        The cast to sal_uInt16 actually called the overloaded
        DoubleToString(...,sal_uInt32) with the LanguageType value used as
        format key number.
        
        Change-Id: I74415ff5504369d437df8caab02ecb61eb853143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150186
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-10  Mike Kaganski  <mike.kaganski@collabora.com>  [5fe96b6dcec8f0ccb7c606fa8e981112e6160e7e]

        Drop SvStream::WriteCharPtr
        
        WriteOString is a better replacement
        
        Change-Id: Ic431b9aeb98d19fe61cff71360eee555105cc2bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150192
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-10  Noel Grandin  <noelgrandin@gmail.com>  [5dba03b200564e2f891fc7e75e948f93ea769c10]

        pack the ImplPropertyInfo struct
        
        Change-Id: I08d163824ca0ed4fdba91d1e0d4d7f076c64a4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-10  Noel Grandin  <noelgrandin@gmail.com>  [9ff063eeabc38d9c1fd1a4beb0d0e4112559b0c1]

        use std::unordered_map for static properties in toolkit
        
        which is faster than binary lookup
        
        Change-Id: Ia810313af36c75fd9b5b241704f0cbd66afcb6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-10  Mike Kaganski  <mike.kaganski@collabora.com>  [f6fa9c455502e9a00e4a4cff6e19f3e17c5479c3]

        Use more *string_view
        
        Change-Id: I1172febd45da4dba006f8495427fe45c6d9b9fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150187
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-10  Mike Kaganski  <mike.kaganski@collabora.com>  [b454107b87ac78096d98fd7ceedcbfac71d247a0]

        Drop MzString
        
        Change-Id: Id0b0541e5069379ef387b3c9309cdda38929b97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150194
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-10  Mike Kaganski  <mike.kaganski@collabora.com>  [8b6d167608d74986e97d462fde8efcae4c28b564]

        Use of O(U)StringNumber for float/double is actually a pessimisation
        
        They use rtl_(u)str_valueOf(Float|Double), to fill the buffer, and
        the latter use doubleToString, which creates an rtl_(u)String, copies
        to the buffer, and releases the rtl_(u)String.
        
        So instead just use the rtl_(u)String from rtl_math_doubleTo(U)String
        directly. Even when the end result is not needed as O(U)String, this
        would avoid an extra copy step. Also, this avoids separate
        LIBO_INTERNAL_ONLY implementations.
        
        Change-Id: Ib1d9ecebd7876dfff7dc758f89ee4c1536647a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150150
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eb372cde829a667acb509ab9d55887ed934f7639]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6791d09b9d45918e4bacacb85f9edd530845650
          - Typo in Fontwork Help page
            
            + refactor
            + adjust in page layout
            
            Change-Id: Ib71fe788f4eca190be8204b4854644e773dd1d03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150185
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-10  Julien Nabet  <serval2412@yahoo.fr>  [3ebe2e7170b093bfd1c417b5907f713df591654a]

        tdf#154631: fix Export as gif ignores transparence of objects
        
        As noel indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=154631#c6
        "GIF does not (as far as I can tell) support partial transparency, it only has full or none transparency.
        See specs linked from https://en.wikipedia.org/wiki/GIF"
        
        Change-Id: Ib110f344a6b8f0fdfd1355e6521d979b33548709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150184
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-10  Eike Rathke  <erack@redhat.com>  [8761510ae5cef17a293f464dc3abc84f46516ff2]

        Clarify XSheetOperation::computeFunction() behaviour in description
        
        Change-Id: I097d5959f227769bbb0a082c5e0b51b245cf96ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150182
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [42cd2550cfb91f0aaeabf8ffe270bcbeee76e147]

        fix calls to OStringToOUString
        
        after commit d7910847fba1694c83dc57a1f27b8eaabb2a7d85.
        
        Thanks to mike kaganski for spotting this.
        
        Change-Id: Ie7272b6f97e3b292439aedb3a163bf00ca26f852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-10  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7a229155aa1f32a5974fd3ff58978f005ed8360d]

        Related: tdf#154684 Make this string more specific
        
        Change-Id: Id28083f1549c752555068dc715131c38f09adb23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150180
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-10  Caolán McNamara  <caolanm@redhat.com>  [c0400558ba9325bc19fd454bcb4b16498082842c]

        crashreporting: getUsedFontList() crash
        
        e.g.
        https://crashreport.libreoffice.org/stats/crash_details/3a3c07aa-0f96-4efa-b55b-c3fe4e4b6ed8
        
        ...
        Crash Reason  EXCEPTION_ACCESS_VIOLATION_READ
        Crash Address 0x0
        ...
        
          XMLFontAutoStylePool::getUsedFontList() xmloff\source\style\XMLFontAutoStylePool.cxx:334
          XMLFontAutoStylePool::exportXML()       xmloff\source\style\XMLFontAutoStylePool.cxx:408
        
        Change-Id: I5d057b8e639260f6d00e731c3af7bab7203a8814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-10  Eike Rathke  <erack@redhat.com>  [a5d955e2fc6e5eabeccf9875a50c85590f3f4768]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0de438c96e95ce7160947023253c3d32ec5f2166
          - SF_Calc DAvg, DCount, DMax, DMin and DSum are the status bar functions
            
            Change-Id: I7f905111e58f0997c6a249a38313853d6c26f725
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150178
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-04-10  Julien Nabet  <serval2412@yahoo.fr>  [2ff7d9696799f34f8a10a778cfcf7132a9e41713]

        Typo: plural lacking
        
        Change-Id: I941f3f468f21dfaa4c35ac6c0730bb955b8688e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150179
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [19223ca3ca6aeb530773af43929bd32fc9211282]

        Remove wrong comma
        
        Change-Id: Ib099dbae688d1f7d7f0609911bdc0428cd1b918e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150160
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-10  Julien Nabet  <serval2412@yahoo.fr>  [26012007e4d20f47697d1336b725e60541df794a]

        tdf#154658: XML Form Document: Fields doesnt calculate any more
        
        Regression from 73334560b2dd2d60ac58d2cc2b1a5295490b03e1
        author	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 15:40:37 +0100
        committer	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 21:58:53 +0100
        commit	73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch)
        tree	b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e
        parent	6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff)
        Replace some macros in forms part 16
        
        A big thank you to Raal for having spotted this!
        
        Change-Id: Ib6f1878897b16b43df287702f82835824c1f766d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150174
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-04-10  Julien Nabet  <serval2412@yahoo.fr>  [ccfd0c68611f2c28dabaab5ce485d1518b6438ec]

        tdf#154740: Assert: Changing Paper tray property
        
        Related to tdf#152950: Calc sort crashes after changing from default language to a different one
        
        In brief "don't set_active while frozen"
        
        bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=186560
        5  0x00007f9a75653df2 in __GI___assert_fail
            (assertion=0x7f9a6393ad87 "gtk_tree_view_get_model(m_pTreeView) && \"don't set_active when frozen, set_active after thaw. Note selection doesn't survive a freeze\"", file=0x7f9a639265f6 "/home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx", line=21759, function=0x7f9a63936b44 "void (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru(int, bool)") at ./assert/assert.c:101
        6  0x00007f9a63b026fa in (anonymous namespace)::GtkInstanceComboBox::set_active_including_mru(int, bool) (this=0x562278124580, pos=0, bInteractive=false)
            at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:21759
        7  0x00007f9a63af904c in (anonymous namespace)::GtkInstanceComboBox::set_active(int) (this=0x562278124580, pos=0) at /home/julien/lo/libreoffice/vcl/unx/gtk3/gtkinst.cxx:22173
        8  0x00007f9a357153ee in weld::ComboBox::set_active_text(rtl::OUString const&) (this=0x5622781249d8, rStr="[D'après les paramètres de l'imprimante]") at include/vcl/weld.hxx:786
        9  0x00007f9a35ad761f in SvxPageDescPage::PaperBinHdl_Impl(weld::Widget&) (this=0x5622774108e0) at /home/julien/lo/libreoffice/cui/source/tabpages/page.cxx:924
        
        Change-Id: Ib13c3e8e472fdcc8f285993f39a69775537bb238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150176
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-10  Caolán McNamara  <caolanm@redhat.com>  [ffdee63185d910f9c239ddf1686f72589eee0973]

        ofz#57800 Timeout
        
        Change-Id: I14b4906ce61b3d8a86cb9a766986c49e0b0e6abc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-10  Sarper Akdemir  <sarper.akdemir@collabora.com>  [60bce1af8aab2115d603781193bb659b35d1aedb]

        pptx import/export: consider TextClipVerticalOverflow for vertOverflow
        
        Also adds a unit test that tests TextClipVerticalOverflow on
        4 different scenarios.
        
        Change-Id: I6232935765641c796046d90fe2207d67ae4b3eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150107
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-10  Sarper Akdemir  <sarper.akdemir@collabora.com>  [1934698260222f6727ac43118933094fa84dcdea]

        editeng, svx: introduce ability to clip vertical text overflow
        
        Introduces editeng text property TextClipVerticalOverflow.
        
        Which when set causes vertical text that is overflown out of a
        frame/shape truncated. (Only when text isn't being edited)
        
        This is implemented as two steps:
        (if text overflows)
          1 - Vertical adjust is forced to top.
            (Forcing vert adjust to top isn't the desired behavior normally,
            but good enough for a first cut I'd say.)
               -> The desired behavior would be after the overflown text is
               truncated, doing a vertical adjust (of center/bottom/top) on
               that piece of text.
        
          2 - ClipRange is set to the height of the frame/shape.
        
        This appears to work with different text directions too (vertical
        etc.).
        
        Change-Id: I697715a7d28bde94a6650609b16505ffab92173f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150106
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-10  Eike Rathke  <erack@redhat.com>  [185cf4496d8750c9e4905c4e384252b01b85d130]

        Resolves: tdf#154217 Edit date+time User Field and Set Variable
        
        ... instead of the raw numeric value.
        
        Change-Id: I256cb4fde1e4ea6b0580b3208c5d4948e2573448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150169
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [eaf071397a1ff30536616f2ed76051f77fd38ed6]

        new loplugin:unnecessarygetstr
        
        which prevents constructing unnecessary temporaries via getStr()
        
        Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-09  Maxim Monastirsky  <momonasmon@gmail.com>  [1e79befa61a08de7a1ddaccb6c435dbb8015c063]

        sc drawstyles: Use display name to find comment styles
        
        Change-Id: I3f56fd4bdb914da336927385e6c0ca76f1c871ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150163
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7910847fba1694c83dc57a1f27b8eaabb2a7d85]

        use more OStringToOUString
        
        both because it is more obvious to read, and it takes a string_view,
        which is handy
        
        Change-Id: Ic201cfa0434446f51436d23c33d3f1a919ed65be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150167
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcf9c4dc32eccd33234511ccf3c2281bee3b0e60]

        elide temporary OString in TokenMap::TokenMap
        
        Change-Id: I6c5ae545d559f408a1ffd5f0132ab0c9a52de4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b3c45b710adcd6723167741e677695a265c5e98]

        elide temporaries in readEvents
        
        Change-Id: I4e2967f314113f78c0c054cb11fa39cf4749545b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150165
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-09  Caolán McNamara  <caolanm@redhat.com>  [ac8c1acbd1d908f506618c05d02c7cbebefa5077]

        cid#1524676 try to convince coverity of the error of its ways
        
        Change-Id: I098636732a3f704c9743cce93d7ba248455c9212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150168
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-09  Caolán McNamara  <caolanm@redhat.com>  [f0210c8f18956b9ff2c1a76661bc5190b1cf9061]

        cid#1524699 silence Uninitialized scalar variable
        
        Change-Id: I32fc2570e8553be356e5c5c059b92791f5e9106a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fbadf2801f4c13f086d76a3ed566180cc0693dc]

        use more OUStringToOString
        
        which makes it easier to pass around string_view in a few places.
        
        Change-Id: Icbbb7f56494986582f1c3272404775bd98031240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150129
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-09  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f707834e8538c0a183716b26ebdf04381482ca6d]

        oox: write color transforms to model::ColorDefinition
        
        Change-Id: I438c10b5181ffd20f2aa041479da2df62a92b156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147952
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [424ff8486b15de152225634a51e3048527e23f21]

        tdf#154694 All icons: Sidebar's A11y Checker
        
        Change-Id: Ifb91eb6d78ae1c6cb7050b89ab0ddc45fb029a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150159
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-04-09  Justin Luth  <justin.luth@collabora.com>  [e4b1be58db73f5a3c483b40b5615c1c764bbe1d3]

        tdf#154703 writerfilter framePr: don't duplicate top/bot spacing
        
        With framePr, all of the background/border settings
        are really just paragraph properties.
        
        BETTER would be to zero out the frame spacing
        and leave it on the paragraph.
        After all, there could be multiple paragraphs
        and each could have their own spacing.
        
        However, in this case we are getting the whole range as
        one propertySet, so that basically means it is treated as one.
        I presume.
        
        But the biggest reason for zeroing out the paragraph instead of the frame
        is because on export only the frame borders are being written out.
        So that really needs to be fixed first.
        
        make CppunitTest_sw_ooxmlexport10 CPPUNIT_TEST_NAME=testLibreOfficeHang
        
        Change-Id: I1faeef6bf12668fb28e2b3710053ff545a4c36e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150157
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-09  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [f22f7159ec1bd28d19f4a8b431893436419ecd64]

        tdf#154622: remove erroneous validity dropdown expand shortcut in extended tip
        
        We can't easily make keyboard shortcuts adapt to OS in extended tips, and
        it is already in the documentation with helpcontent2 commit 278e5201987892072da38033bba89b96af87e2af.
        
        Change-Id: I018af2043701ab46b479fffaa29ffa00f9f6b45f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149993
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-08  Justin Luth  <justin.luth@collabora.com>  [7e99d1010e90becb255d9f64fe2604e4d950e01e]

        itrform2 use GetTextFrame consistently
        
        It make code reading easier if you use the same term
        for the same item.
        
        Change-Id: Iaf64a374a87eeb0ed01869b7772ab671d4b0ef41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149896
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-08  Justin Luth  <justin.luth@collabora.com>  [31ea6305b6a763ee48f639562313d9bd109a2923]

        tdf#154703 writerfilter framePr: avoid exception with hasValue
        
        I'm assuming that because the range has multiple border definitions
        in the various paragraphs that the left border was considered
        undefined. Whatever the reason, a (void) uno::Any as a border
        was causing the conversion to fail.
        
        No matching existing unit tests found.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154703_framePr
        
        Change-Id: I02fabfd035cad0f2094b023936ff1d33ed7f3fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150156
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [02bf9a2e65042afc224f52680cbcfcf30e298ad1]

        Delete other special copy/move functions
        
        As suggested in
        https://gerrit.libreoffice.org/c/core/+/146098/2#message-c2f0d0c43d5315650136a10470785ea2ec4d6e58
        
        Change-Id: Ibf9ef1cf61fd2a8d05ce5e7a78c8bac793318485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150147
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-08  Julien Nabet  <serval2412@yahoo.fr>  [05e4b5bbe6da465ef6cf1b3a2d0da0a6ed6b825c]

        tdf#154677: fix crash when clicking on Tools-Options-Language Settings-DeepL
        
        Change-Id: Iaf24dae303edbeeaf8e19a4ca3d19232083a71bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150158
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [76a413aaf978cfa2b672299ea030ca96088ca786]

        Drop duplicated search
        
        Since commit f3909d4114ab54fd2ee3b71da0777fad9a4a3ee8
        (#90968# use SwStyleNameMapper methods which disambiguate
        user defined styles which clash with programmatic names,
        2001-08-16)
        
        Change-Id: Ic7708242d004af9e183147e044f93211b108ed91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150143
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [2c364d7564ee24d119c21d1738d78982303c4cdc]

        Simplify a bit
        
        Avoids creation of immediately destructed object in case of outline
        
        Change-Id: I72bfb4c5b4020619b61d432c3eee59304fce9795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150144
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-08  László Németh  <nemeth@numbertext.org>  [912336f3c85d9a631fa0ac0f270bab04b204f619]

        tdf#154599 sw: fix crash at drag & drop table columns
        
        New code path for (tracked) row deletion resulted broken
        column deletion, by deleting more columns at their
        drag & drop, than needed.
        
        Regression from commit 5e8aa259e48d5602b932353bb146ebb523982cf2
        "tdf#146967 sw table: fix freezing in Hide Changes mode".
        
        Change-Id: Ib649f5b534a588d192d27757e30c8f81087beb0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150132
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e11655bc0ff6047bdf1cc4ddc39af3a37a948782]

        Fix typo
        
        Change-Id: I1346a75f6341f01544102ffdb615f01f7332de62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150155
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4208d95a292674c80592a7b0b69e5417939b31c1]

        oox: add FormatScheme test case and make sure FillStyle is imorted
        
        Extends ThemeTest in sw with the use cases relevant for import of
        FormatScheme into the model::Theme (as much as it is implemented
        currently).
        
        Change-Id: I888f64c24ba455913d688be256f095d9c298dc2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147693
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dad60bd52a25c1997d3724361ea81c0fe99b1872]

        oox: add model::Theme to oox::Theme and remove createSvxTheme
        
        This is the start of the change where oox::Theme is only a holder
        of model::Theme and not a oox structure. This is probably the
        easiest way how to refactor that. In this commit only prepare that
        and make the code work the same as it did before.
        
        Change-Id: I926a35fd0db383ddb182dc83b36411b2d40b8530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147692
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4f347ebabad6355014889f0a81b107dc774590fe]

        use shared_ptr for model::Theme instead of unique_ptr
        
        Also change other cases to use the shared_ptr so there is no need
        to do copies and replace some of docmodel/theme/Theme.hxximports
        with forward declarations.
        
        Change-Id: I4588cb25e05e5f3e535011fffb68a8075b05aecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147691
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-08  Justin Luth  <justin.luth@collabora.com>  [ad5756f0529a80fbb537979bcfd9de7a83a69805]

        uno:TextAttributes - add to popupmenu draw.xml for textboxes
        
        Text Attributes includes margins for spacing the borders (lines)
        away from the text.
        
        I personally would like to see the order be Area, then lines,
        then textAttributes, but I suppose one could look at it as
        area margins instead of border margins.
        
        In any case, margins are a pretty critical piece of either
        lines or margins, and so should be a menu choice whenever
        either of these is available.
        
        Change-Id: Ifec5bbcd20dba6f42aba586bd0cd791bb9f3acae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150131
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-04-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6b2e928450ea55cc1667631b9d8a23146906d1da]

        Fix typo
        
        Change-Id: I16044e195878c4d51a2e4a92986a1b0baf8bc2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150127
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-08  Olivier Hallot  <olivier.hallot@libreoffice.org>  [197fc56a624714f284e3d9cb073589d79ce56ed0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 001bc6f839d99b51a79eb398fc9f4317ccc9c60a
          - Adjust table and refactor
            
            Change-Id: I477f9c35dcda50e2546c411b0a56f552e6e48ab9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150154
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [b6a5f16a9bf3227867bf46b88d012440138b6f24]

        tdf#154695: use Chapter Numbering Rules to confirm that ToC needs tabs
        
        Indeed, this still can't handle it per-element, like Word does: the latter
        would omit both the number and the tab for headings without numbering. But
        at least the most common case should be handled better now.
        
        Change-Id: I0be5d61a5d2cbbf778ee88a11129a6e7655593ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150133
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [2da7cb9462a98d37191132b6eec13a3ab0da147a]

        set an InteractionHandler with the embedded frame as dialog parent
        
        for any warning dialogs that may appear
        
        Change-Id: Ibb8f90b60cb1af625b0dc57d2f9fd01964fa9bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150128
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Michael Meeks  <michael.meeks@collabora.com>  [1ed50bb714b8ed657cd422df850a6852cd863f43]

        lok: avoid painting writer windows to a giant virtual-device.
        
        When layout changes, we don't want to immediately redraw lots of
        windows; we should be able to wait for tiles to be rendered
        instead. Certainly we don't want to allocate a giant virtual
        device.
        
        Unfortunately we also believe that full document invalidations
        are cheap - so warn about that.
        
        Change-Id: Ib56320d4860c4b6f4e100b30cc6d3e490a1c7a90
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149601
        Tested-by: Jenkins

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [7087e5b9be3a099743f60ba721305f6cc607eaef]

        Resolves: tdf#154680 don't mark an empty fontname as italic for "unknown"
        
        its used for 'ambigious' rather than 'unknown'
        
        Change-Id: I1aeb2f825c5e611e0a943a6ce5f3ab58658701bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150121
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [9e786320a7d2609a9f997b32e31347f2eab0489e]

        move using the vcl file dialog in headless mode to the point of creation
        
        instead of setting and unsetting the config option at start and exit
        because a document that crashes in headless mode leaves my config
        in an unwanted built-in file dialog state.
        
        Change-Id: Ib5fcc5994a08c78bffdf57cb5b252dc469167ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [105a9390e02856887ff5cfb6dbf6fe008738ffe1]

        drop unused eventtesting stuff
        
        eventtesting with input of fuzzed keystroke was a fairly nifty idea, but
        I never did anything with it beyond an initial experimental run and its
        cluttering up things so drop it now
        
        Change-Id: I44571e3e33124f522374d7c6772b7a7e7721aa1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150125
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Baole Fang  <baole.fang@gmail.com>  [04bf1d2385ed80e7aee8015dc69e868c2abe4142]

        tdf#154437: Check "Page" instead of "Slide" in Draw rename
        
        Change-Id: Iec1ee88f12895007240408c8411cc1638c2f0559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149672
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-07  Maxim Monastirsky  <momonasmon@gmail.com>  [1e442e2c6800cf38e42749ac6644502cb3717bc3]

        sc drawstyles: Keep style assignment for comments
        
        Need to handle 3 cases:
        
        - Import of hidden comments (not too much useful by itself,
        as we still force the default comment formatting as DF).
        
        - Copying cells with comments.
        
        - The comment popup that is shown when hovering over a
        comment marker.
        
        Change-Id: Ibf2e22f1432745fe46f89da624ed3586b5d9fb55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149943
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [94ec3df7733dfbc5f48bc1d1a5f0578572749400]

        set m_bSystemDialogs just once
        
        Change-Id: I4ae32628e79902e4ce5534797cacd9ba9e8a177a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d9c48d8e98a08cd31f6b18083a8cc7a927245413]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02f32becf3e2e4238027b4ec566ac8e07c9b81eb
          - refactor to remove <xml-lang> - no consequences for i10n translation
            
            Change-Id: I71e958bb46ed3a9a670b628e28f4d89bc201a176
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150138
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [40e3e9fd1c501cc1978d4370b6392701ccd42a71]

        tdf#113027 - Allow cycling cell reference types including whitespaces
        
        A formula containing a remote reference to a sheet including a
        whitespace in its name does not correctly handle switching from
        relative to absolute cell references using the EXCEL R1C1
        formular grammar.
        
        Change-Id: I3391f4e8f57993899b5e97f0a173b624b5ef0b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150109
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [8bec0ff56c53e80be81a9f463fd1fd21ade33151]

        tdf#154679 unable to scroll with mouse wheel with frozen rows
        
        which is a problem since:
        
        commit f2b97ecf340e1fd714c636060ae09382518a2b46
        Date:   Tue Mar 21 14:30:38 2023 +0000
        
            unmerge default and ScrollType::Drag cases for calc scrollbars
        
        which noted that in
        
        commit 8c4e8818fe9f5ac1f6cdf908299cc109d67f1e50
        Date:   Thu Aug 4 16:38:47 2022 +0100
        
            nDelta overwritten on all branches except default
        
        the default case was different to the Drag case
        
        and speculated that the right approach might be to restore
        that distinction.
        
        but in fact ScrollBar::DoScroll(tools::Long nNewPos)
        had an unconditional 'meScrollType = ScrollType::Drag' which
        ScrollAdaptor::DoScroll doesn't so it was originally the case
        that scroll wheels used to be reported to calc as "ScrollType::Drag"
        so the default handler never arose and such scrolls were handled
        by the drag handler after all, despite the unlikely looking scroll
        type.
        
        So restore the merge of ScrollType::Drag and default as the desired
        outcome, dropping the comment about "only for warnings" which is
        out of date now.
        
        Change-Id: Ibb396f053ae518a6ad5a9b4266ee879c84883953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [37bd2d209e9ee3ae773dec728b21910d69d0522b]

        tdf#153242 change tooltip/extended tip from label to GtkEntry box
        
        Change-Id: Ic3692a32bb3f26c4184d315eae2eb8b50dc7e09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150134
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-04-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7f12ea00177564342cef76c870c1b891ffb86a04]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 42455110e4a9b0777a8a42a676d75aa6f74a12ce
          - tdf#153847  "Index Entry" is now "Edit Index Entry" in context menu
            
              also refactor Edit menu (text/swriter/00/00000402.xhp)
                - remove <xml-lang>
                * improve icon table
            
            Change-Id: I68606d1320255532e4b0065c0a43c74a416eae14
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150135
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-07  Bogdan B  <buzea.bogdan@libreoffice.org>  [000c7fd6b8edf57b3ced14012994cb521901c360]

        tdf#154014 Improve Import Dialog sentence in Basic
        
        Change-Id: I3a3a2737d944f7360052284de1ff09efc493f571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149702
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-07  Caolán McNamara  <caolanm@redhat.com>  [70642bb7afd2cee6f7ae6eff2936a35978bd0597]

        tdf#154470 try moving the Show of the client to after the float positioning
        
        Change-Id: I785120bdad1a3c3311aeca0c8ec5b8b014999872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150108
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-07  Maxim Monastirsky  <momonasmon@gmail.com>  [3709d62860b07110a8420ff30c0150d81267b31d]

        crashtesting: crash on saving of fdo48916-1.ods
        
        That document has <style:style ... style:family="graphic">
        before <style:default-style style:family="graphic">. The
        problem was that only the default style was creating the
        draw layer (in ScDrawDefaultsObj::getModelPool), which
        means that the SdrItemPool didn't exist at the time the
        item set of the former style was created.
        
        The easiest solution seems to ensure the draw layer
        existence on each UNO style object creation, similar to
        the other draw layer related objects in this method.
        
        A similar fix was added recently for another scenario in
        commit aec0830f31c2fd258de711baaa7da24bd01488c9 ("Ensure
        valid SdrItemPool for drawing styles").
        
        Change-Id: I50d89fea6d419119cd47ab163c82d1470b04b4a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150115
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-06  Patrick Luby  <patrick.luby@collabora.com>  [375f85f8518f49ce4381b6663f1e94fc02bacf93]

        Fix iOS build failure in commit a5225ba82e94a549f44420f56a7cb9d7906561cc
        
        Change-Id: I5f4fe093c77f2faf91c6512ed5c294a4f2389757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150111
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-04-06  Mike Kaganski  <mike.kaganski@collabora.com>  [d856be879e0b94b36c8f87817de74189a8a04121]

        Use more *string_view
        
        Change-Id: Ic82bbb1b8d6b03066e66f5eb93e9a94b16b1a9f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150072
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a82a294f4681647fa4e11d8b02147d5881d80b0a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18e7e5c3bf1a43e591d00ab01afa651cae12fa27
          - tdf#153242 update label changes: "Numbering separator" and "Separator"
            
               "Numbering separator" -> "After number"
               "Separator" -> "After caption"
            
            Change-Id: Ib7110a73eaf9c7c48f2d47e92f8fc26b10f697d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150083
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e131cd4cde28531e088a16a9eba1b8bc2ed067a1]

        tdf#153242 update labels for "Numbering separator" and "Separator"
        
           These two changes bring AutoCaption in line with the changes made
           to the Insert Caption dialog.
        
           "Numbering separator" -> "After number"
                and tooltip added
           "Separator" -> "After caption"
        
        Change-Id: I60bedf0e4139f9492672071cf9703cf94fcde684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150082
        Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [037177d047bfc38b7555b8ec45ceb98f35e3551c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f36f1f9a460f33cb48e50aac6f3c24b82a8ae66
          - tdf#154184  clarify how "Apply to all occurrences" option works
            
            Change-Id: Ieed042b8b6d78257b77ef61e5ab56fbbcdba27cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149984
            Tested-by: Jenkins
            Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3b5bc5b4018ba94375ff66c381746e413af5b836]

        tdf#154184  modify/add tool/extended tip: "Apply to all other occurrences"
        
        It is possible to modify a text selection, but the "Apply to..." option
        will search only on the original selection, even while adding the
        modified entry as the index entry. The tooltip is adjusted to reflect
        that behavior, and an extended tip is added to explain more explicitly.
        
        Change-Id: Ic3a9279beb696948a3b30a05a76753905b58641a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149988
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-04-06  Eike Rathke  <erack@redhat.com>  [471e177658761a0c492a56d17de5ea40cfa741f2]

        Update ODFF link
        
        Change-Id: Ieb72077d175862bd459e85a1acc9ea3b0e49c25b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150110
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-06  Bogdan B  <buzea.bogdan@libreoffice.org>  [3a8f1069a9041c2a999d5287f474ac2dd703ecde]

        tdf#154164 Remove "Adobe" referring to PDF document
        
        Change-Id: Ib9676b01c288518f74c01b41300ebc427f5c3109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150086
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-06  Jim Raykowski  <raykowj@gmail.com>  [e27b936fe864cdd2753470e0fef1e3cb1f891555]

        tdf#154212 SwNavigator: Fix outline up/down handling
        
        Fixes incorrect move outline up results and crashes related to
        headings in frames being placed in order of document appearance in
        the Navigator content tree, commit
        c81f4a4ecbfa7dc97d8c28b5ec5f00d1d561b6bb.
        
        It appears a significant amount of the existing code for handling
        outline up/down movement isn't needed.
        
        Change-Id: I9701b6d74dfa06f526f206fc2d250c4183ce4b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149944
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-04-06  Laurent Balland  <laurent.balland@mailo.fr>  [dc9b8c31aaf72812dc205f610638098898a4cde7]

        tdf#153887 Fraction number format: avoid 0/0
        
        If round value is an integer and there is no integer part in the number
        format, then nDiv was wrongly forced to 0.
        Add corresponding unit tests.
        
        Change-Id: Ib69393eca8f6c2bdda0eacfc83637ab0c971ff2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149118
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-04-06  Eike Rathke  <erack@redhat.com>  [74d39f5cff324d76092268418028bd882d8a4d60]

        Resolves: tdf#154627 RANK() query value not in data must return error
        
        For all RANK(), RANK.EQ(), RANK.AVG().
        Also, use #N/A NotAvailable instead of #VALUE! NoValue.
        
        This made it necessary to adapt sc/qa/unit/data/ods/functions.ods and
        result check that had a totally senseless query value with arbitrary
        results.
        
        Change-Id: If835b5ed49caf16a813b4ea897e1d7dd1aa02954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150067
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-06  Caolán McNamara  <caolanm@redhat.com>  [91ff3a3ef603aa1f9eb2db7f34522f38be44dc38]

        there is no SwClient::SwClientModify
        
        presumbly we want SwClient::SwClientNotify here
        
        Change-Id: I826abcc3612246c65449f41cbd82d5cd330a5430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150105
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-06  Caolán McNamara  <caolanm@redhat.com>  [2940491e2670610ca68288dd55af65238306d947]

        cid#1524677 attempt to silence Explicit null dereferenced
        
        ctor iterator to point to start of container
        
        Change-Id: I37f55b572d76958cf0b8ea5139ccd291ef546c65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150104
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-06  Caolán McNamara  <caolanm@redhat.com>  [5402e881ea057ac2956dbcf9942015627601da87]

        tdf#154629 inspector sidebar panel use-after-free on switch to print preview
        
        Change-Id: I5489cd18213d82ae4174ca8d9d00f1da5aa1091d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a6d5b89274b01b94d1802c5457cd9b71f84d9e37]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0380b0919552e5409ec508aac3910a7422038311
          - tdf#153242 new labels for "Numbering separator" and "Separator"
            
                 "Numbering separator" -> "After number"
                 "Separator" -> "After caption"
                      plus correction in explanation about where it appears.
                 Also correction to explanation for AutoCaption
            
            Change-Id: Ibece5ddd4e6d1385a94d22a1d7022d2650176ad0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150081
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [88df20946c6d5b7ea3081f168dde13554ee47513]

        Fix typo
        
        Change-Id: I752f670346d42b8756f77f75ef8bcb0d1b9ae77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150101
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [feed4e7b75656f4dd8a55c0db8bc92e151c4027f]

        tdf#153242 "Numbering separator" -> "After number"
        
        The meaning of "Numbering separator" is opaque. The new label indicates
        where the optional text string will be placed. The added tooltip /
        extended tip helps to explain.
        
        Change-Id: Ia9da9d4d1d6bdf40ab7465cffe8d0d5faf42b27d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149992
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [681c08523cee2dfedb10130eb0120788e1656b2c]

        sd: fix crash in DrawViewShell::ExecCtrl
        
        See https://crashreport.libreoffice.org/stats/signature/sd::DrawViewShell::ExecCtrl(SfxRequest%20&)
        
        I believe this crash is triggered with some basic code while
        slideshow is running.
        Anyway, if I delete the previous SlideShow::IsRunning(GetViewShellBase())
        check, launch Impress and add a new slide, LibreOfice also crashes.
        
        Change-Id: Iba40f37485a4a6815729a1a26c380b6c3fdedfd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150097
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd17c9c9495f555ea27f7debfabeb2407ac2b9b6]

        loplugin:stringadd also check O[U]StringBuffers
        
        For similar code sequences that can be improved.
        
        Also move containsComment from collapseif plugin code to
        plugin.cxx so we can use it from stringadd.
        
        Change-Id: Ie07d9aedf2c31cb0b2080e1b8584294d7046a8e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-06  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [d5673ec3f8b17d57857c75916186c681d66cf243]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 278e5201987892072da38033bba89b96af87e2af
          - tdf#154622: correct validity dropdown expand shortcut to Alt + Down
            
            Change-Id: I44c8516ca808491187784dc5cf3e198b9facb843
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149991
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-06  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [e3ffc41cd02b3028231f41a20be5632468b64546]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f042658be3bb4621450b4155f0dd5c400f1b641a
          - tdf#154609: mention option to search by shortcut
            
            Change-Id: Ia772db91419cf3ed8bb73f8c5e3cbd5f01529028
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150074
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [79e60bb93f69370f23010adb078b5a5de5a1e7b2]

        poppler: upgrade to release 23.03.0
        
        * Upgrade poppler-data to 0.4.12
        * Update poppler-config.patch.1
        
        Change-Id: Ic2a3e8d4f801d52d1568210d0df064cacb51290f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148842
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-06  ektagoel12  <ektagoel12july@gmail.com>  [87f52dbf4faf8dcd6fcc1b070e070b9ca8584ac4]

        tdf#145538 Use range based for loops
        
        Change-Id: Ib74318a36898270c7b6e45e5e064ddd696a91be8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145905
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-04-06  WANG Xuerui  <xen0n@gentoo.org>  [477374d8f5e3acfc2727b009a95427ef05297ffc]

        m4: Bump Boost detection macros to latest autoconf-archive version
        
        Aside from general up-to-dateness, this also fixes build on some
        loongarch64 systems whose libdir is `lib64`.
        
        Change-Id: I78988c7d585be4e44b3388d8e1c7d60e2738de97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147185
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-04-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [00408d71e8db4b58bf350978d6ff6f032ae53e56]

        Make SvxNameDialog public
        
        Useful as a generic text input dialog
        
        Change-Id: Ibc6ff0c25a790da8f1226fff7244e50ed3a1cf04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150002
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-04-06  Szymon Kłos  <szymon.klos@collabora.com>  [c19f041f27c9a297ec20107acc89e9b1144ec070]

        jsdialog: implemented mouse events for drawingarea
        
        Change-Id: Ieab3d9fdbcee90ccd125e84f74c06cd1d6711a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149953
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150057
        Tested-by: Jenkins

2023-04-06  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a6cc4d851f1a061af71e03af4c886638d6a5f3b3]

        MCGR: Moved color compare in common computation part
        
        The colors of a ColorStopRange can be equal in case of
        hit *and* miss, so in both cases. I moved it to the
        common computation part. Prev version worked and did
        no harm, but unnecessary color interpolations for equal
        colors.
        
        Change-Id: I19031f1021ee5955b48da5c0d8e3a03cb9512ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150046
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-06  Michael Stahl  <michael.stahl@allotropia.de>  [5ef4d326a06f9fc0aff36bd5cdcba1b7af8e03db]

        tdf#152234 drawinglayer: PDF/UA export: fallback for unsupported forms
        
        veraPDF complains:
        
          Specification: ISO 14289-1:2014, Clause: 7.1, Test number: 3
          Content shall be marked as Artifact or tagged as real content
        
        Form element can only be used for those form controls for which
        PDFWriterImpl can produce a Widget annotation; see createDefaultWidget().
        
        For a label control, it's not editable so it's not a PDF widget.
        
        For an image button, it could be implemented in VCL but isn't currently.
        
        So a fallback is required in any case, "Figure" or "Div" can be used.
        
        Change-Id: I454030ff7c67a8a8101fcc59e945fe9dbc5f87a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150059
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ca70301a97172b04c170f5f2e486c33114243ff]

        oox: drop macros
        
        Change-Id: Ic8eeb34bef91807b54823a4114acc1200bec9de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150065
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ab16e2738b4b9bd324c9aded8acb2ecba0fd2b0]

        oox: fix crash in lcl_GetGluePointId by removing unused code
        
        See
        https://crashreport.libreoffice.org/stats/signature/oox::drawingml::lcl_GetGluePointId
        
        Change-Id: I7737568b12a18a2195f24f023917d30dd838ea12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-06  Stephan Bergmann  <sbergman@redhat.com>  [e489200756d08fd647d3c3ce5ae4f620c3f4baa7]

        Missing XServiceInfo
        
        Change-Id: I1ec148d239d6ea6ac72f820d5e5f41f1865f4b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150069
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-05  Stephan Bergmann  <sbergman@redhat.com>  [23bd3bd10e74b0c23c2654d02d7d830e7693adac]

        Add missing constructor attributes
        
        ...that were apparently forgotten by 155c056b1d4674d5ff73bbb5e1ad1dcd1e6aae36
        "i18npool: create instances with uno constructors" and
        d2140a6320cd1cf4dea29b174cdb3bcb5261056b "i18npool: create instances with uno
        constructors", respectively
        
        Change-Id: I3caedf9d2a941a8671fab554a2358776d95c4938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150066
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-05  Stephan Bergmann  <sbergman@redhat.com>  [7191ebc701074059bcfce01620c6035a299ffd78]

        Remove dead com.sun.star.i18n.Transliteration.ignoreKana service implementation
        
        In 2002, fc680b643030fc2c99dcfffe75e762ee35e5f292 "#97583# Modify for new
        services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA and
        com.sun.star.i18n.Transliteration.ignoreKana service implementations, both using
        the also added ignoreKana_CreateInstance factory function, to
        i18npool/source/registerservices/registerservices.cxx (back in a time when that
        still used active component registration via component_writeInfo).  Then in 2010
        a3c8a0ed0c5c6be1cb5c940750222f6381608bd7 "sb129: #i113189# change UNO components
        to use passive registration" (dropping the active component registration via
        component_writeInfo) faithfully listed both those service implementations in
        i18npool/util/i18npool.component.  And in 2014
        a4f17c00b16f5a983cd91ac5d2c43454f1775931 "i18npool: Constructor feature for few
        more implementations" switched the com.sun.star.i18n.Transliteration.IGNORE_KANA
        service implementation to use a constructor attribute in
        i18npool/util/i18npool.component.  But it also removed from
        i18npool/source/registerservices/registerservices.cxx the
        ignoreKana_createInstance factory function and the
        
        >     IMPL_TRANSLITERATION_ITEM (ignoreKana),
        
        aInstances element through which the other
        com.sun.star.i18n.Transliteration.ignoreKana service implementation was created
        via i18npool_component_getFactory.  (It presumably either intended to also
        change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor, but
        forgot to implement that, or accidentally broke that service implementation.)
        
        So the com.sun.star.i18n.Transliteration.ignoreKana service implementation has
        not been instantiatable ever since 2014.  But it appears that nobody missed it
        much, so maybe it had already been a mistake to add it (alongside the
        com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in 2002.
        So just remove it completely for good now.
        
        Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-05  Caolán McNamara  <caolanm@redhat.com>  [7f9b3a0214e0c5d69e2becf2084fbf6e3defa090]

        Resolves: tdf#154308 if start center frame exists, use it as dialog parent
        
        At least for the case the document is launched from the StartCenter, put
        that StartCenter as the parent for any dialogs that may appear during
        typedetection, this avoids such dialogs not getting associated with
        the start center and going behind the dialog if the start center is
        clicked while the dialog was appearing.
        
        The start center is always recycled to become the next document if
        it exists, so its window is the window the final document would
        appear in if successful.
        
        Change-Id: I75a92ff424aa0b9d5d6b808e2f7f1766a80fa50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c3e219a831719ebb40dd2af8a26b0a24ad7aba1]

        tdf#154549: vcl_pdfexport: Add unittest
        
        Change-Id: Ia2865346e966cdd4b64ed588a29cc1e760d36c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149969
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ae6f44235677f713e285e0d5342faca529d37557]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 470abc85b20e113506966df8883e287d25079517
          - tdf#154608 Add example of regex with \N{} to Help
            
            Change-Id: I7b6c847cc3fbcbb62d9590eea4050630933e85f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150062
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3ec614bf247fff5373de29b59553cd934b5fb826]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4f2e673eae5e1c3ffcc54d2253a35145aba7774
          - Refactor file (no content change)
            
            Remove xml-lang
            
            Change-Id: I88f54ed44b795f7a5731748eccbafbe5f926ff27
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150061
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b51bf9594384d822a2778bf6bf3ecdeed9ef3e7f]

        tdf#146312 - Chapter numbering dialog: adapt extended tooltip for [None]
        
        Change-Id: I71cddd45a336d6e201e23fdf1c93928ec2928a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149987
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-05  Noel Grandin  <noelgrandin@gmail.com>  [e57d5daaea734ade43e8251120afa031099a0840]

        fix leaks when using tools::JsonWriter
        
        Specifically in sd/source/core/annotations/Annotation.cxx
        
        We seem to end up fixing leaks here often.
        The current tools::JsonWriter API is just very hard to use correctly.
        
        So rather return an OString, which is cheap to copy,
        and push that down into the LOK code.
        
        AFAIK that seems to end up requiring less code and less adhoc copying
        of data (specifically the queueing code in init.cxx was creating
        copies when converting to std::string).
        
        Ideally, we could have some special API to avoid the new strdup()
        calls in init.cxx, but not sure how to prevent other people
        from accidentally using that.
        
        Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-05  Michael Stahl  <michael.stahl@allotropia.de>  [e4042da6e63ed2ac6e1687f696580d9a502bad83]

        sw: fix crashtesting assert on tdf90408-1.doc
        
        frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `... || oTaggedParagraph || ...' failed.
        
        The problem is that here the SwNumberingPortion is outside of the table
        cell and even outside of the page due to negative indent, hence
        CalcPaintOfst() skips it.
        
        Have to add another special case to open the LBody/P tags in this case.
        
        Let's not produce Lbl tag in this case since it's not visible.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: Ic048849c9f426ebfa59e05acece1ec995fd28247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150056
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-05  Michael Stahl  <michael.stahl@allotropia.de>  [e006c6ce7502f47889034b98cb0795e78ea36094]

        sw: fix the other stale SwNumberPortion follow flag
        
        This happens since commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd
        on abi13630-1.abw.
        
        itrpaint.cxx:419: void SwTextPainter::DrawTextLine: Assertion `roTaggedLabel' failed.
        
        The problem is very similar to the situation fixed with commit
        6c0105307efa15837e9e5287103995312f373b67; then it was the pField which
        ended up empty and deleted, while now it is "this" which ends up empty
        and deleted; in either case the DrawTextLine checks of the follow flags
        fail because some follow flag is erroneously set.
        
        This requires a further tweak because the length of the portion is set
        to 1, so Compress() returns the wrong result there but immediately after
        SwFieldPortion::Format() returns SwNumberPortion::Format() sets the
        length to 0 anyway, so simply set m_nFieldLen to 0 in ctor which is
        correct anyway as there's no dummy char for these.
        
        Change-Id: Ie99f67ee19a1f6019afe68764ec746cdc862984e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150055
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-05  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0a703b615b8fec592304d9060aab9c77d0ced02c]

        tdf#153847 add tooltip for Insert Index Entry
        
        According to
        officecfg/registry/schema/org/openoffice/Office/UI/Commands.xcs,
        TooltipLabel is supposed to default to Label if PopupLabel is empty,
        but in practice it seems TooltipLabel also defaults to ContextLabel
        when TooltipLabel is empty, so this patch adds back the original
        TooltipLabel, which is different from the ContextLabel, and is needed
        primarily for some toolbars.
        
        Change-Id: I538bb4d75ce9a5141c292408c3f670d4524f2069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149986
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-04-05  Szymon Kłos  <szymon.klos@collabora.com>  [c81306b7f5f2c12c3b4391dce4697276a0a3523b]

        jsdialog: dump menu for menubutton
        
        Change-Id: I449ae3f8cf294e2ab81a5b47862278e325f2cb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148937
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150041
        Tested-by: Jenkins

2023-04-05  Michael Stahl  <michael.stahl@allotropia.de>  [5cc69594e4382c258f0e3e3b1ef210567fce1bd8]

        vcl,sw,sd: PDF/UA export: produce better /CT for SdrMediaObj
        
          7.18.6.2 Media clip data
          In the media clip data dictionary, the optional CT and Alt keys
          (ISO 32000-1:2008, 13.2.4.2, Table 274) are required.
        
        Presumably writing a potentially wrong hard-coded mime type here isn't
        intended.
        
        Change-Id: Ifa8ee199a4cf9ce83f410860d59b6c30475f80e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150050
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-05  Michael Stahl  <michael.stahl@allotropia.de>  [a5225ba82e94a549f44420f56a7cb9d7906561cc]

        avmedia,*: guess the mime type of media files based on file name
        
        .. at least for the most popular types, and do it automatically in
        MediaItem::setURL().
        
        This should work in practice in most cases and is much simpler than
        adding some type detection or calling into platform dependent avmedia
        backends.
        
        Remove the parameter that was only ever set to
        "application/vnd.sun.star.media" anyway, the same value that would be
        used if it's missing.
        
        Stop using that silly type for everything, only use it when guessing
        fails.
        
        In case an ODF document is loaded, it will use the mime type loaded from
        the file (see setting of MediaMimeType in SdXMLPluginShapeContext) and
        not guess it because that would require updating the entry in
        manifest.xml as well.
        
        Change-Id: I8ce29cf7425678ae11dda1d8c875be818f8623af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150049
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-05  Stephan Bergmann  <sbergman@redhat.com>  [8b4af1eb0549b6832361da85ddaa1e13be34ec76]

        Adapt expected test output to recent Clang
        
        ...after 90c590812eecb3a0eb2748a132e304fa6c0ea0ad "Simplify O(U)String::number
        implementation"
        
        Change-Id: I3f5d7b1ff41a6d55293f15f15fd67bd5d2e69d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150045
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-05  Paris Oplopoios  <paris.oplopoios@collabora.com>  [d4240225d159db9912f565f954598052ab7a63b8]

        Notify LOK that application background color has been changed
        
        Notify LOK when the application background color changes in Writer
        
        Change-Id: Ibc900cc8b3253aaa5b53602a007566896f04d9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149906
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        (cherry picked from commit 0dca587be41718d2d88e80fc585829ad83da59ea)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149892
        Tested-by: Jenkins

2023-04-05  Julien Nabet  <serval2412@yahoo.fr>  [62b5dd31ffdad49f36aef2b7f6f1c54bcbf320ec]

        tdf#148906: Ukrainian letters miss in bullets and numbering dialog
        
        Change-Id: Ieef2b2a7052da342709baf298b618d2c29fa3e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149768
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d2de1cf7e5d7dcb3f7e8420b8fbfad718a41b5a3]

        Fix typo
        
        Change-Id: I1cf23442667a8ac6e9f8da2ea72bf60f5126236e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150047
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-05  Jani Saranpää  <jani.saranpaa@gmail.com>  [cccfc2e705b3708854dc2de8bcc602fa45fdb5a8]

        tdf#145614 Convert #define to enum in propctrlr/fontitemids.hxx
        
        - Removed fontitemids.hxx and moved new enum definition inside cxx file to
        optimize compiling.
        - Removed non-existing fontitemids.hxx from clang format excludelist.
        
        Change-Id: I67e782821d65241264de0926e445a58dc7307ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149736
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [90c590812eecb3a0eb2748a132e304fa6c0ea0ad]

        Simplify O(U)String::number implementation
        
        Change-Id: I059f0324597a90aee01c95170a48ac5578f3caee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150037
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-05  Caolán McNamara  <caolanm@redhat.com>  [53e24da3698ddb5f976cec0ae8eb8b2a2ab2c4c6]

        tdf#132112 excessive stretch of braces can trigger freetype into an error
        
        which propogates to cairo and once a cairo surface is in an error state,
        that cannot be cleared and all subsequent drawing fails, so bodge that
        with a high degree of stretch we draw the brace without stretch to a
        temp surface and stretch that to give a far poorer visual result, but
        one that can at least be rendered.
        
        Change-Id: I6b8bb079e82c3cf03a908de750c5c445ad230750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-05  Caolán McNamara  <caolanm@redhat.com>  [2510d4805482d2cec9059065174825b4260adf0f]

        split out a makeCacheId
        
        Change-Id: I89fbaca1fa7303904681f75ee4a7fc90aeb9ef8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150030
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-05  Szymon Kłos  <szymon.klos@collabora.com>  [591e96c29d15bd511645897e86ea3c9b4a20d9d7]

        jsdialog: enable table related dialogs
        
        Change-Id: Ibcbd175e9b7c04f30acd4c5d23998b00889e7b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149714
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150040

2023-04-05  Szymon Kłos  <szymon.klos@collabora.com>  [1389150fb1d72ca431139177e5f31088ebf985e8]

        jsdialog: enable pick color dialog
        
        Change-Id: I45c086ce652487017817fcdb2a3c5329a8f2a30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149689
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150039

2023-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [1e9f4de320f67d1218c710bcee1969a2324c6888]

        Make O(U)String::boolean also return an O(U)StringNumber
        
        Change-Id: I184fa0e4e45662e0fac86076d1c8733a0465bb56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149978
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-04  Caolán McNamara  <caolanm@redhat.com>  [c9c463af22d1c7ea75c8af2d7cf5e2c0a152e40f]

        split out the pieces that apply the font to the cairo context
        
        Change-Id: I0577832f57b15621d150da4cb50e134c9c06bae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150029
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1ca2edf4efaea9824613aaf02e854da6a2241f07]

        tdf#153847  update labels to disambiguate insert/edit index entry
        
            primary purpose is to differentiate the two .uno commands
            so that they do not have the same label in the Customize
            dialog. ContextLabel is needed for use in submenus.
            PopupLabel needed for Edit..., but not for Insert.
        
        Change-Id: I4dc452805ff47669218158711b874b04330d02ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149881
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-04  Caolán McNamara  <caolanm@redhat.com>  [e0e613ad27c29c35a982f34f1af84b1c342eb4e5]

        remove cairo_set_matrix calls that do nothing anymore
        
        in the past there was intermediate calls that these affected
        
        Change-Id: I5bb15046ff5869522dfafe72e16f9be4707c1f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-04  Caolán McNamara  <caolanm@redhat.com>  [3e1ee22e8ac6d2217547bf9a591e38af5c6da440]

        cairo_font_extents is unused
        
        since:
        
        commit 6c9948d80aaa1d4827ccf741d900093abe7a973e
        Date:   Mon May 3 06:51:50 2021 +0800
        
            vcl: adjust cairo text renderer for vertical writing
        
        Change-Id: I853b5f3b8c8979468d6c72617b7991f4c7d509d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150026
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [73d0723c466e63c247d37ec8b9fa0bd8db8766b5]

        Fix typo
        
        Change-Id: I4ff8556c954cae844fa35385535cf9b6e9477e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150033
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e1138db4e472e0d5de851c724e0048f1a834c08]

        Fix typo
        
        Change-Id: I09163a500caf66c6ac2921dca3128997574d20d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150032
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-04  Caolán McNamara  <caolanm@redhat.com>  [55d5648958f9d453688bba50706323c8deb30478]

        tdf#154565 ignore unwanted crossing event from search to treeview on "enter"
        
        i.e if the crossing was triggered ultimately by a key stroke which is
        likely from exiting the search box.
        
        This way we can avoid the problem that with hover-selection that after
        "enter" is used in the search box, selecting a matching row, then during
        teardown of the widget the box is hidden, and the generated crossing
        notification triggers unwanted selection of a different row under the
        mouse.
        
        If needs be this could be refined further to only happen for a specific
        key or other details of the triggering event
        
        Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150016
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [fcb4e31983515d2231957e894d54649eba5c62cf]

        Convert SvtLineListBox to WeldToolbarPopup
        
        Change-Id: I1849e40508a8754ec567da5913d3454571da5bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149063
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150015
        Tested-by: Jenkins

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [65752e649872edfd98915035b61aca510ae8f271]

        jsdialog: enable and make async chart line prop dialog
        
        Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2023-04-04  Balazs Varga  <balazs.varga.extern@allotropia.de>  [89e65e6afdfc942cf8232886d6703947167eaec3]

        tdf#153880 sc: Make Calc text hyperlinks stand out more
        
        Add underlining for links in Calc.
        
        TODO: unit test
        
        Change-Id: Idd5a7de7464d8ce443cdec756ac803491e73b0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149913
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-04-04  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [4b5203ebf4ca5894f4d7dd37a141832df26e8b9a]

        MCGR: Improve performance for texture-mapped MCGR processing
        
        Change-Id: I20b32e7c272112c6c3d9f7ee0ef59c6d4d006d94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150020
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [37928bef1c23f30df04bc7e95fcbc202c8cb4299]

        tdf#151206 - Sc Auto Filter: filter items after search edit timeout
        
        In addition, UI tests have been adapted to address the timeout of the search process.
        
        Change-Id: Id9d78896e45da43734346654762c3541b8c07ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149958
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-04  Stephan Bergmann  <sbergman@redhat.com>  [65710a8d0098752b1079680563a053c2770ec958]

        Fix typos in XML that broke three implementation elements
        
        The typos all originated with d2140a6320cd1cf4dea29b174cdb3bcb5261056b
        "i18npool: create instances with uno constructors", causing three intended
        constructor attributes to rather be plain character data.  Which apparently went
        unnoticed until recently (see the TODOs resolved here that had been introduced
        with 456a146b9eb643655ae2bd336740e8c5536913aa "tdf#151971: Fix used
        implementation names of transliteration services"), in part because the Parser
        class in cppuhelper/source/servicemanager.cxx silently ignores any unexpected
        character data via xmlreader::XmlReader::Text::NONE.)
        
        Change-Id: Ia8fdbc09c67d10530b4d86dbbbde2b6b84038e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150021
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [894ddf0251b1b8dcd44e588430215e35b91eb02e]

        tdf#151338 Rearrange table popup menu in Draw/Impress
        
        I also added the SplitCell command to the Draw popup menu, since there's no reason for it not to be there.
        
        Change-Id: Iec0d51559bf03c0f352aa631bedb794f18e02e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149700
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [a9cf7e8b23a0223eb2f5e0ed28bd012551836867]

        tdf#154476 Fix accelerators in Print preview
        
        As reported in the bug ticket, the +/- accelerators are inverted.
        
        Change-Id: Iafd648968ce8c3c2f461f31b65b1bd4bf85f1dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149701
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-04  Miklos Vajna  <vmiklos@collabora.com>  [18cab645488184f1d861fb4e67aebb383f6e3779]

        tdf#154451 UITest_impress_tests{,2}: enable oneprocess mode
        
        Execution time changes:
        
        - from 2m10,846s to 1m34,525s
        - from 1m37,723s to 1m7,339s
        
        for me.
        
        Change-Id: Id1bf511ec01694497b9fbc6b95aa7c4ac9bb4a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150019
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [2a87a59a52ae26db5106f7d1f4346225d032b550]

        tdf#152234 vcl,drawinglayer: PDF/UA export: produce Role for form controls
        
        veraPDF complains:
        
          Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 2
          If the Form element omits a Role attribute (Table 348), it shall have
          only one child: an object reference (14.7.4.3) identifying the widget
          annotation per ISO 32000-1:2008, 14.8.4.5, Table 340.
        
        LO forms produce both page content in an MCID and an /Annot, so Role is
        needed.
        
        Change-Id: Ic231931a7c35d8da37ca76e02d97501edb43347c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149626
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4047cb44b7a41115dafb7cffcebd2a02329283df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 562c29b9451c68b607d980b6011726bbf9de0247
          - tdf#153248 numbering is changed globally
            
               Add a sentence to note that changes to "Numbering" are
               applied retroactively to any existing captions.
               remove <xml-lang>
            
            Change-Id: I5279296cf27018d7f0f5a08a62e97689e6021339
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149879
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-04  Stephan Bergmann  <sbergman@redhat.com>  [456a146b9eb643655ae2bd336740e8c5536913aa]

        tdf#151971: Fix used implementation names of transliteration services
        
        ...after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad
        UNOIDL identifiers across offapi" had changed the spelling (character case) of
        some of the css.i18n.TransliterationModules[New] enum values involved here, so
        that the TmItem1 macro generated broken TMList::implName values now.  (Which in
        turn caused TransliterationImpl::loadBody to throw "unsatisfied query for
        interface of type com.sun.star.i18n.XExtendedTransliteration!"
        css::uno::RuntimeExceptions, which remained uncaught.)
        
        Also add a test verifying that loading all those transliteration services no
        longer fails throwing exceptions.  Which lead to two open TODOs:  For one, the
        value of maxCascade in i18npool/inc/transliterationImpl.hxx might come from a
        time when there were fewer TransliterationModules[New] enum values and might no
        longer be appropriate.  This would need some further investigation.  But for
        another, there are two transliteration services that cannot currently be
        instantiated.  That looks like a regression that should be fixed in a follow-up
        commit.
        
        Change-Id: Icfca3e841360d4b471013e2c96d6868a75a21a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150018
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [22fd7ccb913c55db14adf736859fc9e0e7f00630]

        vcl: PDF export: fix erroneous MCID produced for 1st page
        
        PDFWriterImpl::beginStructureElementMCSeq() emits a spurious MCID
        definition outside of any stream, before the 1st page:
        
          /Document<</MCID 1>>BDC
          % PDFPage::emit
          1 0 obj
          <</Type/Page/Parent...
        
        This is because SwPageFrame is translated to a Document StructElem in
        EnhancedPDFExportHelper, but PDFPage::emit is called at a later time
        than when the page content stream is produced, so this is just wrong; an
        MCID inside the page content stream is pointless because that's an
        object already anyway, so just suppress this.
        
        Looks like other applications don't produce Document currently.
        
        Change-Id: Ic2e30e4125c0e97c8e47330c7a247f74efc18f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150017
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [250b820a24640a33d73a6e690e04e36be01cda28]

        tdf#129726  make extended tips visible for 1st and 2nd key
        
          ce58da3240e508800bd3e6fd7d56fb5fbde3349d introduced extended tips,
          but the extended tips for "1st key" and "2nd key" should be the
          child of the GtkComboBoxText, and not GtkEntry.  
        
        Change-Id: Iaaa23c76debaa87c37f2fa8308e81c31cfb657cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149888
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-04-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9d298aa0c78855fd075e24ef542e0c8e176e729c]

        tdf#153242  "Separator" -> "Before caption"
        
        The "separator" option places an option text after the category
        name and number and before the caption text. This option is
        relabeled to "Before caption" to make its function more transparent
        and to reduce ambiguity with "separator" which is also used, with
        a different meaning, as part of Heading Numbering before Caption Number
        in the Caption Options. Also, add a tooltip for this option, and
        update extended tip to explain the option more precisely and fully.
        
        Change-Id: I3d1a53936ea68ac79c5f6a5ed41dd291826b0227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149878
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [660ba4b4a0e5ac3f5c517c3c21daf277bdae5bc0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e252239f3cd73b80f049fd1794338766fbd3fe6c
          - Change <embedvar> for <link>
            
            Change-Id: I233af09ea89c177c37ff4978107f626b749671a9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149975
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-04-04  Miklos Vajna  <vmiklos@collabora.com>  [96df0ad0da6e8972a828721dac6b4ba7c69eba85]

        sw floattable: fix removal of last follow fly with a start/middle one
        
        The bugdoc has 3 pages: each page has 1 row of a floating table.
        Deleting the last row deleted the last fly frame, but the text in the
        body didn't move from page 3 to page 2.
        
        It seems what happened was that the condition in
        SwTextFrame::HasNonLastSplitFlyDrawObj() was wrong, it always filtered
        for the master anchor, not for the relevant anchor. Once that's fixed,
        the other problem was that by the time SwRootFrame::DeleteEmptyFlys_()
        would invalidate the anchor, the follow/precede relationship is already
        unlinked for the to-be-deleted fly, so we can't find the correct anchor
        of the to-be-deleted fly.
        
        Fix the second problem by invalidating the anchor earlier, in
        SwFlyAtContentFrame::DelEmpty(), where the to-be-deleted fly is still
        part of the flow frame chain.
        
        With this, deleting the last row in the document results in deleting the
        entire page 3 and moving up the body text, as expected.
        
        Change-Id: I3303408cafabcc61abfffe6c355ec3874fff30a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150008
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-04  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [309469a3863c1ce7a2d463f3a62f5101c39ac89c]

        RES_REFMARKFLD_UPDATE no more (lots of zombie code)
        
        - RES_REFMARKFLD_UPDATE is only instantiated in SwEditShell::UpdateOneField
        - ... which passes it to DocumentFieldsManager::UpdateField, which
          * puts it in an SwUndoFieldFromDoc into the undo stack
          * and passes it to UpdateTextNode
        - SwUndoFieldFromDoc::UpdateField only uses it to pass it back again to
          DocumentFieldsManager::UpdateField
        - in UpdateTextNode RES_REFMARKFLD_UPDATE does not trigger any specific
          code
        
        thus:
        - replace UpdateTextNode with ForceUpdateTextNode
        - remove the message item from the SwUndoFieldFromDoc ctor
        - remove the message item as a parameter to
          DocumentFieldsManager::UpdateField as it was only ever used for
          RES_REFMARKFLD_UPDATE
        - remove the instantiation in SwEditShell::UpdateOneField
        - and finally: remove RES_REFMARKFLD_UPDATE itself
        
        Change-Id: I3f7e27a555a24630d6d5a2c1a40db9096195b826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150004
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-04  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [116a646a9f36ff07393186d5a001628023c6ded6]

        RES_TBLHEADINGCHG no more ...
        
        - replaced LegacyModifyHint by a proper SfxHint
        - Refactor SwTabFrame for table heading change:
          * split out Invalidate(SwTabFrameInvFlags)
          * split out HandleTableHeadlineChange()
        
        Change-Id: I374db7a3b16a3062d6ad54c32527ec1056cbc00b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149929
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [bd5efa2899a3db51c2b6d525d7e518a7a3fbf912]

        jsdialog: send full update when shown not when created
        
        Change-Id: I02cb63b57960c1d7425fe97c341eaf24f216c3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149496
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150013
        Tested-by: Jenkins

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [a9872f5ef0bef781df7fec99d0ce98746f01ae9e]

        jsdialog: dump label relation between widgets
        
        Change-Id: I625346049b866d9f231bba461f40b671f4959e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149717
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150012

2023-04-04  Heiko Tietze  <tietze.heiko@gmail.com>  [2039fd382af9d110bd68be8629ab757b3617926a]

        Resolves tdf#154446 - Remove redundant option for grid line color
        
        Change-Id: I41d39b763e651f90660f2a451ed0a9b473ead206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149715
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [f4a0b43d729fff169a2152a04aaa1369a4d4f9d6]

        jsdialog: enable missing chart related dialogs
        
        Change-Id: Ia33980d3536b3a52a24161e789f04ee4de75f2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149540
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149999

2023-04-04  Szymon Kłos  <szymon.klos@collabora.com>  [564d8594afc64cb5e227cedb872b7cf75c0cff07]

        jsdialog: update drawing area when resized
        
        Change-Id: I429a5d750fc84b42d0d399cf3833f22e7479cfe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149455
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149998
        Tested-by: Jenkins

2023-04-04  Caolán McNamara  <caolanm@redhat.com>  [6942c44120243de997ede145426ccf928bafaf9f]

        resave with latest glade
        
        Change-Id: Ida60773e87cc607de6763fb6676aad83c316e8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150000
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-04  Vojtěch Doležal  <dolezvo1@cvut.cz>  [28675af84ae8e2342bd78be3696dc09de6ce5cc5]

        tdf#41652: Variable width NBSP
        
        Adds a flag that when enabled (opt-in for both old and new documents) changes behaviour of NBSP to not be strictly fixed width.
        
        This commit also implements this behaviour such that NBSP has always the width of a standard space (0x20) on the given line. This change is only noticeable when the paragraph is justified.
        
        Lastly a tilde or a degree character is now shown in place of NBSP when nonprintable characters are enabled, since the gray field alone is not visible in many circumstances.
        
        Change-Id: Iabb30b5930ced62691cc4304f60c5e6dc886ed61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149576
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fb8e9b3e8ec9b03399e6cd0d47a9d08976b71ed7]

        Fix typo in code
        
        Change-Id: I9386ce811885e46ffedfc5bd8cc05007ddf75f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149968
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-04  Miklos Vajna  <vmiklos@collabora.com>  [54ae3b7ed03a513dc218c40196172c950380a450]

        sw: document at-char vs as-char layout frames
        
        "bound to a character" is a bit misleading for as-char.
        
        Change-Id: I0c322c88f81bf96c7b4818598cfbef4fc7f4baea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149996
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-04-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [1b52ec38dd338932255aa94411ad90f83ed02d9e]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to ff606081bb42acb96611ff232f5606dd76f411bf
          - tdf#154459 Improve grammar for hlp_ellipsis
            
            Change-Id: Ia488470069a9a4818dd3152250cc053842d161a2
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/150006
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-04-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5cc29848b78b6c5ab01aa7a66b1dd7caff5f9385]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 17ff420d14f2d7289bcee4ce7c652b4dfeb5a4d9
          - add missing < to embedvar 
            
            Change-Id: Ief1b8c7f78f6756d178c70d27020f6b483abfb24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149977
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [12ea66f132ae3894f336444ddf30a8f2579be503]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1964fcaee6441a576976a8730287ebd955f9128e
          - Proofread and add missing markup
            
            Change-Id: I1269d775307dcc5ad022d5d99f640bfb778386fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150001
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-04-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [c74117e400578348187113bcf191ccfd6deb2cce]

        Hyphenate this compound adjective
        
        Change-Id: I7e19c90fd0106f59398205579d7b5d60cbf4a07e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149945
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-04-03  Eike Rathke  <erack@redhat.com>  [632fdbb7fb9fd296aaa4c473070aecc3c0dd019c]

        Resolves: tdf#154582 Obtain English DisplayName before CompatibilityName
        
        ... for Add-Ins from configuration.
        
        Change-Id: If13d692ca7550e69d2f6e3ff72747d17aee3e7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149995
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-03  Szymon Kłos  <szymon.klos@collabora.com>  [055280fbd829a8ce51ade625d0f1cb7e1e631020]

        jsdialog: enable impress format dialogs
        
        Change-Id: If7bcdf7afdf6e272e47531c2b2b0b75046c561a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149425
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149965
        Tested-by: Jenkins

2023-04-03  Szymon Kłos  <szymon.klos@collabora.com>  [199af45c99e2e45a4a0236fdb5d0da135c205188]

        jsdialog: enable slide properties dialog
        
        Change-Id: I5c6b0c24a049a2368dbe084bcfffc4f777d88625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149423
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149964
        Tested-by: Jenkins

2023-04-03  Caolán McNamara  <caolanm@redhat.com>  [dd56b1c4980bea867286880bd0ac194b6106c968]

        set a parent for embedded object warning dialog
        
        calc does a lot of "CaptureMouse" which then leads to a lot of
        "ReleaseMouse", I'm somewhat unconvinced that there should be any
        CaptureMouse calls in there.
        
        Change-Id: I7c44d2c36c89a5c32c525d65939723da9be77a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149973
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-03  Caolán McNamara  <caolanm@redhat.com>  [e97c8ceb003488589bf14c7ea335eaa3e1a86975]

        tdf#152257 popup already launched, don't relaunch
        
        Change-Id: I2503803b756fed179f6aa62cee2c549b6bc7c3c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149972
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c2cc3e696e27f3ab218c56e90065f5c102ae50b6]

        Fix typo
        
        Change-Id: I49fe9dbdc11291c02be1dd5e41171a987d896008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149997
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8016f45ea6d43c8b7a981d364e0df26feec3eb1]

        Fix typo
        
        Change-Id: I5f5d819f5068869d78bd52f820a24d1d9702f6ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149967
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-04-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [994ecdc459ff99b5944ae289a51328d8093c422f]

        tdf#124525: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I16321c8e22a205d211536b189191db453ebf1ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149956
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-04-03  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [64007cb308ead90ba6ffa2963c5de8ef89cec5ce]

        MCGR: Unify Gradient intensity handling in tooling
        
        Moved the Gradient intensity handling to tooling since
        it is also needed for TransparencyGradients. Added
        missing use of GradientStepCount for transparency.
        
        Change-Id: I63ae6683fa0131be7faadc8572e19f5c43bf27e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149957
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-03  Maxim Monastirsky  <momonasmon@gmail.com>  [aec0830f31c2fd258de711baaa7da24bd01488c9]

        Ensure valid SdrItemPool for drawing styles
        
        ... when pasting cells as OLE object. Problem caught by UBSAN build with
        UITest_conditional_format UITEST_TEST_NAME=tdf117899.Tdf117899.test_tdf117899:
        
        /sc/source/core/data/stlsheet.cxx:238:53: runtime error: reference binding to null pointer of type 'SfxItemPool'
            #0 0x7f9cb1ef60ce in ScStyleSheet::GetItemSet() /sc/source/core/data/stlsheet.cxx:231:28
            #1 0x7f9cb1ed52e3 in ScStyleSheetPool::CopyStyleFrom(SfxStyleSheetBasePool*, rtl::OUString const&, SfxStyleFamily, bool) /sc/source/core/data/stlpool.cxx:144:40
            #2 0x7f9cb1ed9285 in ScStyleSheetPool::CopyStdStylesFrom(ScStyleSheetPool*) /sc/source/core/data/stlpool.cxx:223:5
            #3 0x7f9cb0e25d51 in ScDocument::CopyStdStylesFrom(ScDocument const&) /sc/source/core/data/documen8.cxx:292:35
            #4 0x7f9cb4602d7c in ScTransferObj::InitDocShell(bool) /sc/source/ui/app/transobj.cxx:683:14
        
        ScStyleSheetPool::CopyStdStylesFrom wants to create/update the default drawing style,
        but in case the source clipdoc didn't have shapes - without creating ScDrawLayer first,
        which means no SdrItemPool exists. Fix that by creating ScDrawLayer unconditionally,
        as we attempt to do this later on anyway.
        
        Regression of commit 685a864cfc40227559ed55f6273fd118174e8e6e
        ("sc drawstyles: Clipboard support").
        
        Change-Id: I3def9860ab4f11c70c120f5324a60adf63056a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149966
        Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [1f437264084fd173116965fa4d856aeafdfe7a98]

        tdf#153806 a11y: Allow opening context menu in special char dlg using keyboard
        
        Open the context menu for the `CommandEventId::ContextMenu`
        command for the character table that is used in the special
        characters dialog, so opening the context menu is not only
        possible by right mouse click, but also using the keyboard
        (by pressing the context menu button or Shift+F10).
        
        Move the handling for the case where the context menu is activated
        using the mouse from `SvxShowCharSet::MouseButtonDown`
        to `SvxShowCharSet::Command`.
        
        When the context menu is activated using the keyboard,
        use the centre of the currently selected item for the
        context menu position.
        
        Adding support for opening the context menu for the
        recently used and favorite characters further down
        in the special characters dialog is independent of this
        and would have to be added separately.
        
        Change-Id: I55ef43708b95f5a90b06777a8aeb32a64609160d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149927
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [bb4aaa4cfd6cf3fe0f43baae2622df1098047123]

        Pass special char dlg context menu pos as param, drop member
        
        The `maPosition` member was only used for the position
        of the context menu. It was set before calling
        `SvxShowCharSet::createContextMenu` and then only used
        in there.
        
        Pass the position directly as a parameter instead and
        drop the extra member.
        
        Change-Id: I7ba9ec60ffb993ca1269d86efeddbe0950ed7fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149926
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [fa7fc141e49bf1a5e1fc30645d559c19205d76a7]

        tdf#153806 a11y: Insert special char + close dialog on return key
        
        As discussed in tdf#153806, insert the currently selected
        character from the special characters dialog and close
        the dialog when the return key is pressed on the
        table of characters (either showing all characters
        or just the search result).
        
        Something similar should probably be done when the return
        key is pressed with one of the recent characters or
        favorite characters in the dialog having focus, but
        that needs to be handled separately, possibly along
        with the other remaining suggestions to improve keyboard
        handling in the special characters dialog as discussed in
        tdf#153806.
        
        Change-Id: Iccc19e4808ddf6f15c32710f9bea931e46b046bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149920
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [d1f5b3c5cb226fd5f58fe2cdc8be9d1330fad6a2]

        tdf#153806 a11y: Improve keyboard interaction in special char dialog
        
        Make interacting with the "Special Characters" dialog
        using the keyboard more intuitive and consistent:
        
        * Call the selection handler (that changes the "OK" button
          to be sensitive) when a new entry is selected, as happens
          e.g. when tabbing into the table of characters, at which
          point the currently focused character is already considered
          selected (as e.g. indicated by the fact that other UI elements
          in the dialog are already updated according to that selection).
          This previously required pressing the space key (or moving back
          and forth using the arrow keys) for no apparent reason.
        
        * When a character in the character table is selected,
          insert it into the document when pressing the space
          key, as happens when double-clicking the entry
          using the mouse. Insertion using the space key
          already works for the characters in the "Recent Characters"
          and "Favorite Characters" sections below the table, so this also
          makes the behavior more consistent within the dialog.
        
        Change-Id: I35072f565b26d1f6c12c7dc8b7c6592f6a985a03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147657
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-03  Michael Weghorn  <m.weghorn@posteo.de>  [cb29cd301d6a493870d8efc233965658ae532206]

        tdf#153806 cui: Deduplicate code for special char dialog handlers
        
        Various handlers for `m_xShowSet` and `m_xSearchSet` are
        the same, except that they operate on the different objects.
        
        However, since a pointer to the `SvxShowCharSet`/`SvxSearchCharSet`
        is passed as an argument to the handler, use that
        and reuse the existing handlers instead of duplicating them.
        
        Also extract a `SvxCharacterMap::insertSelectedCharacter` method
        from the `CharDoubleClickHdl`, since that will be reused elsewhere
        in a follow-up commit for tdf#153806.
        
        Change-Id: I14e8e7fd7add33f86fa0246c65927ceb88bb7899
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149919
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [be9919f4719aee2154fe2cbaef70b3537e49fe8b]

        Optimize a bit
        
        Change-Id: I5a2c37e4ff1e19cfbc29e1e61b025f44d067b95a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149893
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-03  Caolán McNamara  <caolanm@redhat.com>  [a8dbc875814e003a7a1eb733c0f5f7f0ab80b908]

        add CVE-2017-18013 test case
        
        Change-Id: I43324a4159a0562a87594662a634fae91b216055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-03  Caolán McNamara  <caolanm@redhat.com>  [ae9ef125e27758f1ae018aa2598dcafe3c29c9a8]

        move to libwebp 1.3.0 release
        
        Change-Id: I88205be86e15d9878040958b96dc30043d9eb0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [e8e244d93c02f4d5b58b9a29dd7fc0d69316888a]

        Simplify JsonWriter a bit
        
        Change-Id: I0ca4a0fcf4f19bc26ae931bae0b2ee53db47f12c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149951
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a7b79f7e1ac4aa1dc4744dced45903f9ecc7f351]

        tdf#146312 - Chapter numbering dialog: show paragraph style [None] in preview
        
        Change-Id: Icb576df2f0de255aba9fdfddad81b654a48c6c36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149948
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [8067c37e4197f8f07be87f4516a89b07b7462632]

        Fix rtl_(u)str_valueOfBoolean return value documentation
        
        The reported numbers are factually wrong. See rtl::str::valueOfBoolean,
        and back to commit cb6ab44fbef0a71984a15766d5ad7dcbe0a82a10 (template
        implementation for String/UString, 2001-03-16) that introduced the
        actual return values.
        
        Change-Id: Ib692ee7164be31bde3d884823a77e6452dbf9cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149890
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8fc316fb65e0d4b78ec881aa79f4184602b96f54]

        tdf#89920 - Handle embedded newline in Calc's search cell
        
        Update short-circuited boolean expression so the least expensive subexpressions will be executed first
        
        Change-Id: I8c924e00e8de809f3e6df2828f8537185e71c18c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149891
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-03  Szymon Kłos  <szymon.klos@collabora.com>  [735437b3b663f43dd7ef6bb2e8c8666673c14c49]

        jsdialog: keep button under content in SpellCheck Options
        
        Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149825
        Tested-by: Jenkins

2023-04-03  Szymon Kłos  <szymon.klos@collabora.com>  [778e034d89f1e8236cc5afdff902f165637ce9ca]

        jsdialog: enable spelling options dialog
        
        and make it async
        
        Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824
        Tested-by: Jenkins

2023-04-03  Stephan Bergmann  <sbergman@redhat.com>  [637d588ef3eaed3b9896d8aff3ccab6eb100ab29]

        Fix heap-use-after-free
        
        ...seen with CppunitTest_desktop_lib
        CPPUNIT_TEST_NAME=DesktopLOKTest::testControlState after
        116b9d6ddf2b61186b29f0370234eec9c1bbe306 "Avoid conversions between OUString and
        OString in VCL",
        
        > ==883385==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000937904 at pc 0x7fe40a2ef6ad bp 0x7fff0a077390 sp 0x7fff0a077388
        > READ of size 4 at 0x603000937904 thread T0
        >  #0 in rtl::OUString::equalsAsciiL(char const*, int) const at include/rtl/ustring.hxx:1279:21
        >  #1 in rtl::libreoffice_internal::ConstCharArrayDetector<char const [11], bool>::Type rtl::operator==<char const [11]>(rtl::OUString const&, char const (&) [11]) at include/rtl/ustring.hxx:1815:24
        >  #2 in JSDialogNotifyIdle::Invoke() at vcl/jsdialog/jsdialogbuilder.cxx:283:27
        >  #3 in JSDialogSender::flush() at vcl/inc/jsdialog/jsdialogbuilder.hxx:172:34
        >  #4 in JSDialogSender::sendClose() at vcl/jsdialog/jsdialogbuilder.cxx:345:5
        >  #5 in JSDialogSender::~JSDialogSender() at vcl/jsdialog/jsdialogbuilder.cxx:320:5
        >  #6 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1
        > 0x603000937904 is located 4 bytes inside of 24-byte region [0x603000937900,0x603000937918)
        > freed by thread T0 here:
        >  #0 in free at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:52:3 (workdir/LinkTarget/Executable/cppunittester +0x139452)
        >  #1 in void rtl::str::release<_rtl_uString>(_rtl_uString*) at sal/rtl/strtmpl.hxx:875:9
        >  #2 in rtl_uString_release at sal/rtl/ustring.cxx:1204:12
        >  #3 in rtl::OUString::~OUString() at include/rtl/ustring.hxx:546:13
        >  #4 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1
        
        Change-Id: Ib95b4d16c7a7d74ad989716e7829de775ed0de8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149954
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-03  jpuronah  <joel.puronaho@gmail.com>  [6201b6468f53338f833dd93809cb4a78458114aa]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I8369e0bdb6a01838d87e7cddc1cbaed911fe461a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149952
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-04-03  Miklos Vajna  <vmiklos@collabora.com>  [1006fd848ba7c67927472e53df7f3b6f682fadfb]

        sw floattable: fix removal of empty master flys on master table removal
        
        The bugdoc has 2 pages, a floating table covering both pages, row 1 on
        page 1, row 2 on page 2. Once row 1 was deleted, the text around row 2
        moved up to page 1, but row 2 remained on page 2, which is unexpected.
        
        What happened is that we correctly deleted the fly of row 1, even moved
        the text of the anchor on page 2 to page 1, but nobody moved the fly of
        row 2 to page 1, which is inconsistent.
        
        Fix the problem by invalidating the position of the follow in
        SwFlyAtContentFrame::DelEmpty(), since deleting a master fly potentially
        creates space for follows, so they can move up.
        
        This helps in the 2-page case, the case with more than 2 pages still
        needs work.
        
        Change-Id: Ida9cc1d586963867e8fc7ee92d4b3f5dfafd3579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149947
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-03  Miklos Vajna  <vmiklos@collabora.com>  [9996b7aba68b2e8a84701d7643c4376ed6c34554]

        xmloff: prefix members of XMLTextParagraphExport
        
        See tdf#94879 for motivation.
        
        Change-Id: I894665f1af47cf1e5f0f191bfdf3100e426fa6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149946
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-04-03  Michael Meeks  <michael.meeks@collabora.com>  [0bd949f4412249e5ecd63716efcc55d92d120da9]

        BinaryDataContainer: pure re-factor to encapsulate stream copying.
        
        Change-Id: Iab24e8d18bf7badbca672fbdbf455f78d08f41a0
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149905
        Tested-by: Jenkins

2023-04-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [56ae7d01505fdae421109cfc78449230ba589d79]

        tdf#89920 - Handle embedded newline in Calc's search cell
        
        If the replaced string contains a newline after find and replace,
        insert an edit cell in order to handle an embedded line correctly
        regardless of the content in the source cell.
        
        Change-Id: Ic8a5fc80b85546897572a228511b319cd5a8b9aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148752
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-04-03  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d36145d7cf6ca4d6072d4ab0a709bb8fe866336c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5041e95a2e3804ded772be4b6d6a3d6d7f9e5039
          - tdf#153499 add new section title and missing options; corrections to "Level" and navigation
            
              + add "Update entry from selection" option, with icon table
              + add icon table for "New User-defined Index"
              + add new "From Selected Entry" section title and explain
                the purpose of the section
              - remove "Selection" section title, and modify heading levels
              * update "Level" -> "Index level" and correction to explanation
              * corrections to navigation button labels, and icons
              * correction to description for "Next entry (same name)" and
                "Previous entry (same name)"
              * order options according to dialog
            
            Change-Id: I937eb727f303b3e4990de117f962eecc30bc0194
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149594
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-02  László Németh  <nemeth@numbertext.org>  [c4a58634753a84b09f20f7271d6525a6656522d3]

        tdf#154545 sw Navigator: select & track nested bookmarks
        
        After selecting a nested bookmark in the Navigator with
        double click or Enter, the selected item changed to the
        item of the main bookmark in the tree list. This jumping
        was very annoying especially with multiple nested bookmarks
        inside the same bookmark.
        
        Navigator didn't track nested bookmarks, i.e. it always
        showed the main bookmark instead of the actual nested one
        under the text cursor.
        
        Change-Id: Ic3f1e8321454d4ad892708e76c001da6eca30cf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149915
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-02  Noel Grandin  <noelgrandin@gmail.com>  [89170bc27196f9b5a27de7bf42a43b71235676c2]

        make some methods final in chart OPropertySet
        
        so that the subclasses use the right overrides to implement custom
        behaviour
        
        Change-Id: Ida9d1de51b5595c4d9532a5c98a220bf39d9a208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149940
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-02  Caolán McNamara  <caolanm@redhat.com>  [3a5ad705979e0928a2f96cafab7fc92aabfd2b75]

        cid#1524674 Uninitialized scalar field
        
        Change-Id: Ia32ed66c35f7d32b626e0bf719269ae8f45241c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149938
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-02  Noel Grandin  <noelgrandin@gmail.com>  [8f6dd1fde5d99418d2db4b547f9761f3449d3490]

        map->unordered_map in chart OPropertySet
        
        no need for ordering here
        
        Change-Id: I7e0928284c98aca297d4452e65efd8a4f3b1e56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-02  Noel Grandin  <noelgrandin@gmail.com>  [0b32750a8dcc8cec2922e93ce34151006d3517b0]

        remove IEventNotificationHook from comphelper::OPropertySet
        
        this class is a copy of cppuhelper::OPropertySet, and this
        feature is unused in that class too, so we are not likely to
        need it
        
        Change-Id: I9e3f0f7d786052f87f5a18c67e9b78409752fd99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-02  Mike Kaganski  <mike.kaganski@collabora.com>  [116b9d6ddf2b61186b29f0370234eec9c1bbe306]

        Avoid conversions between OUString and OString in VCL
        
        Standardize on OUString, which is the main internal string class.
        Convert from/to OUString only when communicating with respective
        external APIs.
        
        Removes about 200 conversions from the code.
        
        Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-02  Stephan Bergmann  <sbergman@redhat.com>  [d7ba78e9c7be835a1e2ecdacd25995663e96862f]

        New --with-coredumpctl to obtain core dumps of crashed tests from coredumpctl
        
        ...for (Linux) systems that don't store core.* files in the current working
        directory.  When enabled, this wraps test execution in `systemd-run --scope
        --user --unit=...` with unit values unique per individual test invocation, so
        that solenv/bin/gdb-core-bt.sh can query coredumpctl for matching core dumps.
        (See the mailing list thread starting at
        <https://lists.freedesktop.org/archives/systemd-devel/2023-March/048884.html>
        "[systemd-devel] coredumpctl: matching by e.g. env var?" for further details.)
        
        The used --unit=... scheme is a best effort to produce system-wide unique
        values, combining the target location path of the given test with a
        second-granularity date/time and the current PID.  (In case there would be
        multiple invocations of the same test per second, which then hopefully wouldn't
        reuse the same PID.  The date/time and PID could be replaced with a
        high-resolution system-wide monotonic clock/counter if one were easily
        available.  The advantage of the current scheme is that it only uses Posix
        features.)  The overall length of the unit value (incl. the appended ".scope"
        suffix) must not exceed 256 characters, or else systemd-run would fail with
        "Failed to mangle scope name: Invalid argument".
        
        It might look more natural to pass the unit value into gdb-core-bt.sh as a
        fourth positional argument rather than via a new LIBO_TEST_UNIT env var.  But
        for one, the unit value is most easily computed from within the recipe shell
        command lines, where an env var is the most natural fit.  And for another, this
        avoids having to tunnel yet another value through the tearDown method in
        unotest/source/java/org/openoffice/test/OfficeConnection.java to the given
        postprocesscommand.
        
        Change-Id: Idcb20cd1e1141d8ec7f10947e5edc70aa2aa7d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149690
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-04-02  Caolán McNamara  <caolanm@redhat.com>  [b05fb34d48da717447b9b86db9546df72b25e988]

        use the same max size that libtiff defaults to for its own utilities
        
        Change-Id: I67a769a6108fb8590d6304390a4f27ef95927c9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149922
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-02  Caolán McNamara  <caolanm@redhat.com>  [484fa53f43977e390bf79831cf7096983a440cff]

        ofz#57592 Null-dereference READ
        
        Change-Id: I6fc96bb0be6c5a872861987a195b0d628f574c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-02  Mike Kaganski  <mike.kaganski@collabora.com>  [ebf2cc4e9dacdc7afdeb4fcc91482678fa3edc4a]

        Simplify a bit
        
        Change-Id: Iae784d3ae40cd237c768413c067a2067c608238d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149885
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ce86e5b4a8d54eb55fdde7756ad6fde6e6967d55]

        MCGR: 1st additions to OOXML MCGR import
        
        This change provides 1st changes to get Gradients with
        muti color stops imported from MSO in the oox import
        filter. It supports currently multiple ColorStops and
        transparency. Also 'border'(s) should work, but
        -remember- this is work in progress.
        
        Since it is work in progress it is currently and
        temporaily secured by ENV VAR "MCGR_TEST=0", so when
        not using this the master version will not be touched
        at all.
        
        The number defines various ColorStop tests, 0 for none,
        but some changes are active, e.g. MSO import. You may
        try 1 or 16 to see all your Gradients hard replaced by
        something using that feature.
        I will take care fo cleaning this up again when the
        feature progresses/gets complete.
        
        Change-Id: I92e10d8cd5150733741a6def20a542abf97bd903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149682
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-02  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [389f338da025aa7bc26556a7167cd272b64b77fd]

        SDPR: Use currently added lambda to render Gradients
        
        Change-Id: I9fba920c60690f136cae956dae17e2f5e5081f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149839
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-04-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [24a374ebc9da56cc6721e8feaa1e15ba850bf41d]

        tdf#154040 use a SdrObjKind::NewFrame for frame creation in writer
        
        Instead of (ab)using SdrObjKind::NONE for the temporary, empty
        SdrObject instance in writer when creating a new frame, use a new
        SdrObjKind::NewFrame kind for the object and use a empty SdrObject
        instance EmptyObject - minimal implementation of SdrObject).
        
        Change-Id: I0277a8f0cf7bfd428e106258ae8710b77e62c41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-02  Eike Rathke  <erack@redhat.com>  [82ed010cd39351adcd4015e2bdd1591aa869cf18]

        Resolves: tdf#154218 Use the proper document's SwCalc locale for formula field
        
        ... instead of the format's locale to generate the expanded value
        string to be reinterpreted again. i.e. inherited by SwSetExpField
        used with Set variable.
        
        Change-Id: I0bb545282a50032f2d8d2965020a36e3c5c8914e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149911
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-02  Eike Rathke  <erack@redhat.com>  [8c8457526a11fd03ed63a86ecdeeb270d5551049]

        Related: tdf#154218 Actually use the top format selected
        
        Choosing a format of Additional Formats replaces the listbox
        content with the format's category so the assumption that Text
        would be the first entry does not hold. For such format still Text
        was assumed and the input used as literal string, which defeated
        the actual value formatting capabilities and a possible formula
        interpretation for SwUserFieldType.
        
        Change-Id: I199575469672a9f8bada2d2edde5036766977501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149910
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-02  Eike Rathke  <erack@redhat.com>  [ba6d84b854e1abd3e913423dbcfaf192f7ade7f2]

        Resolves: tdf#154218 Tie user field content value string to content locale
        
        ... instead of the format's locale.
        
        Change-Id: I83aeaa1433486241626fafc1ab9b4e2b3802d3eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149909
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-04-02  Maxim Monastirsky  <momonasmon@gmail.com>  [7fed5d046f1c7c9e8caa2e80c020ea8f8ff6df66]

        Related: tdf#152250 Copy also style hierarchy
        
        Change-Id: I134857c9a7749b0dd4a6fe6842dcc8c72d373f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149928
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-02  Maxim Monastirsky  <momonasmon@gmail.com>  [341900458578cb7d875efeee1ffdc9a0429e92b7]

        Explicitly check for cell styles
        
        Now that this method is used also for drawing styles.
        Overlooked this in 685a864cfc40227559ed55f6273fd118174e8e6e
        ("sc drawstyles: Clipboard support").
        
        Change-Id: I7218b735d743841106606739fbd72e45a1d4bf1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149923
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-02  Maxim Monastirsky  <momonasmon@gmail.com>  [ae1285a593173cddf002f9b9ca9a6f1003f49285]

        Try a different approach for cid#1524623
        
        I fail to see how pClipDoc could be nullptr, as all call sites of
        ScDrawLayer::CopyFromClip get a ScDocument-owned ScDrawLayer. But
        even in such case we can still get the style sheets pool from
        ScDrawLayer itself, which guaranteed to have one with or without
        ScDocument, as per ScDrawLayer's ctor.
        
        Change-Id: I6a3b7af7080b0a07ab3ec1fcfa7c6ca00e365162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149921
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-04-02  Khaled Hosny  <khaled@aliftype.com>  [96aad0d0497c8486f8affc8fed79e63a060c9a59]

        tdf#154549: Make combining marks inherit the script of their base
        
        ... regardless of the script of the mark itself.
        
        Change-Id: I15a5d8cb2e1d7b7a26316689ffa11c278d1f6365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149925
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-04-02  Michael Weghorn  <m.weghorn@posteo.de>  [574a5519e23e8ed50c54fb27587afb1b5b5c13c5]

        tdf#152979 qt: Re-add workaround for X11 modality change w/ hide/show
        
        Essentially add back the workaround originally added in
        
            commit e770bacc85a0eec96de77068d61b03f374b3cdec
            Date:   Sun Jun 2 21:01:33 2019 +0000
        
                Qt5 workaround modal change after show bug
        
        but then dropped again in
        
            commit 2dc6bdd1d5789ace0500cad90f5d2eb930888bb9
            Date:   Wed Jun 5 17:39:45 2019 +0000
        
                tdf#125692 SalObject always holds a SystemChildWindow
        
        , since it turns out that it is still needed for other
        use cases than the original one from tdf#125692, as the freeze
        of the basic IDE dialog dialog preview described in tdf#152979.
        
        The
        
            qt.qpa.xcb: internal error:  void QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window
        
        issue mentioned there is apparently also worked around in
        upstream Qt tests, s. this qtbase commit [1]:
        
            commit 3714e51436eebb64873c58dc36cf89ef8f139f09
            Author: Volker Hilsheimer <volker.hilsheimer@qt.io>
            Date:   Mon Sep 20 13:44:26 2021 +0200
        
                QWidgetWindow: Stabilize test on Xcb
        
                Showing, hiding, and showing a window can result in the Xcb QPA plugin
                warning about
        
                qt.qpa.xcb: internal error:  void QXcbWindow::setNetWmStateOnUnmappedWindow()
                called on mapped window
        
                The point of the test is to verify that we get a paint event on a window
                that is shown again after having been hidden, not to verify that async
                windowing systems can handle a show/hide/show sequence. So wait for the
                window being exposed before we hide it.
        
                Pick-to: 6.2 5.15
                Change-Id: If91a9926613645e78e332dacff34bd57e4034b6f
                Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
        
        Decrease the sleep from the original 250 ms to 100 ms,
        since tdf#152979 comment 14 mentions that this is enough.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=3714e51436eebb64873c58dc36cf89ef8f139f09
        
        Change-Id: I57ed520d0df85b7a3bcf47c2f9314754649482ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149912
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-04-01  Noel Grandin  <noelgrandin@gmail.com>  [84646117baa2ac3463a007207b6b5d1d3cf0e3ae]

        fix locking in chart::Diagram
        
        we can't return a reference to internal state that needs to be protected by a mutex
        
        Change-Id: I13c0128559546cc2078584fc0de818c568617b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149914
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-01  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [383f70fa9ed0ec7acd6fbc4e921bb5b91fde4689]

        RES_UPDATEDDETBL no more
        
        - SwDDETable doesnt handle the hint anymore (it used to do a
          ChangeContent triggered by it)
        - SwDDEFieldType::UpdateDDE doesnt create the hint anymore -- it used
          to send it via UpdateTextNode, which would call
          SwTextNode::TriggerNodeUpdate for some types, but not for SwFieldIds::Dde
        - ... so the hint sent is never received by anyone who cares
        
        - SwDDEFieldType::UpdateDDE calls ChangeContent on all DDETables
          directly in UpdateDDE anyway, so the dead code is likely just
          obsolete.
        
        Change-Id: I85301ef89998508031833f35c4a2c93e7acb112e
        
        Change-Id: Iaef54e27869947fb7f57d1575e9e0f59f903befd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149656
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-04-01  László Németh  <nemeth@numbertext.org>  [6eb1d540a1e599aa4fe0a321eddb9cc22e0546d3]

        tdf#154521 sw Navigator: fix selection change event of bookmark
        
        In Navigator, double click or enter on a bookmark name selects
        the bookmark in the text, but the triggered selectionChanged event
        didn't give access to the actual selection, but only to the start
        of the previous one.
        
        Note: newly enabled Navigator tree item "Bookmarks" is not stateless
        on some test platform, so adjust unit tests according to the (now)
        unknown index of the requested tree items.
        
        Change-Id: Iade4ea40c524a1eb14737669bb3d21f22b556c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149895
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-04-01  Noel Grandin  <noelgrandin@gmail.com>  [6726fef6910559000f6fb5dc17647c455b944adc]

        pack the UnoControlComponentInfos struct
        
        Change-Id: I18ab490074051831dd31b3953308e372ca2b469f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-01  Noel Grandin  <noelgrandin@gmail.com>  [bfdf5d290be3fccb631d50cfea52fbe43fff4dce]

        use more XVclWindowPeer
        
        Rather than using it's superclass XWindowPeer and implicitly relying on it being XVclWindowPeer and casting it everywhere.
        
        Change-Id: Icfb46f3b920d00f4a167a31803a71bbb0368d05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149894
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-04-01  Juergen Funk  <juergen.funk_ml@cib.de>  [cd013e66711c056c52ffd0839e782f6ee9c2dabd]

        git-hooks: remove hint in './g -z'
        
        In the patch 05ea4ac1952c546a81781ac0662747dbe6073616 the hint
        is too mutch and the elsewhere I think it makes no sense, remove.
        
        Change-Id: I1c13e593f673f2cab9a307f57f59efa1fbd903c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149761
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-01  Mike Kaganski  <mike.kaganski@collabora.com>  [166a16594eb4e7e78f3f5b00a1432637d109bf8d]

        Simplify logic in XOutBitmap::WriteGraphic a bit
        
        Change-Id: I8781a4e2cd0ab89dcd1ed3092bd2995be59abf82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149760
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-04-01  Caolán McNamara  <caolanm@redhat.com>  [a13d6e441d91a1a071ac57b20df6774cee2de0f6]

        cid#1524623 Dereference after null check
        
        Change-Id: I43de41c207d129013fa9c2003cccb12facf3f1da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149902
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-01  Paris Oplopoios  <paris.oplopoios@collabora.com>  [8d0cab477904091f3d663e6d90aca95a66d199b0]

        Add LoKit callback for application color change
        
        Change-Id: I9d0fe4ab878c9d3a4a6d842be5cd534b97bf77a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149822
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
        (cherry picked from commit 48650acef94147c2100eade8c583fddc770b94ef)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149876
        Tested-by: Jenkins

2023-04-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [33f9d8356bea13fd47497ee6337311e3e9ade2c2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4218a343f54af2dc10a9648a4e9b71bb346c16de
          - tdf#154214,tdf#153248 update/order sections; note global effect of numbering
            
               tdf#154214 reorganized the ordering of the options in the dialog,
               which also resulted in some changes in some section titles.
               This patch reorganizes the presentation on the help page to
               correspond to the dialog, and updates the two changed section titles. 
               tdf#153248 notes a lack of documentation about the retroactive
               change to existing captions if changes are made to the heading
               numbering options. This patch adds a <note> about that.
            
            Change-Id: I77cab25b7f0085d6b153546515897980b2a0de01
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149877
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-04-01  Caolán McNamara  <caolanm@redhat.com>  [e0344a7a3081154798ebf9eae65e364e63af958c]

        gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed
        
        Change-Id: Ia8070c3c8102bc6bfb72531be450abd9fe47a1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149841
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e03b053fcc2905f999598906fd37fda2c8c9a829]

        tdf#154040 writer still needs an "empty" object so create one
        
        For inserting frames writer still relies on an empty SdrObject, so
        create an instance of an empty object when requested to do so.
        
        Change-Id: I8b55318a7fb4b02c9c40de4ca845a804af3e781a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149899
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-04-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [32a11b50b2fc0b7a190a2197368958fa4e82b3e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 717e7ee5206afad534d358182d88c3244ac6635e
          - Update filter conversion help page
            
            Change-Id: Ieac78fad758e1b66932566d8928bbef53593b28a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149898
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d408e940630d131ab886a1d4619671fa0299c03e]

        Simplify a bit
        
        Change-Id: I56de67a7860263d40b4352e93927dfdb107eb4bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149875
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d893a40c81357a25a4a89a62f6cf6122046068d5]

        tdf#154486: Use known name when inserting the table into the document
        
        ... instead of assinging a unique name at insertion time, then changing
        to the final value.
        
        As discussed in commit 1dd71d79e15bd8098e7c17c8fcea3748592a902f (tdf#154486:
        use importer-local map to deduplicate table names, 2023-03-31), the lookup
        for a unique table name has an O(n^2) complexity, and can make loading of
        thousands tables impossible.
        
        This changes import time from 23 s to ~2.5 s, and the time now depends on the
        number of tables linearly (e.g., 200 000 tables load in ~45 s).
        
        Change-Id: I0f2b5e37db2d370bccbc8c3430f895c864d9a4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149840
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60bb7f3afe4fd8bb3ebb75a77f31f7ba5091eac4]

        Fix typo in code + add curly braces for "No assigment"
        
        Change-Id: I58f01ede2d568c73bca697674a625cb1b13e5684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149762
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-31  Szymon Kłos  <szymon.klos@collabora.com>  [bd3bc03ef82e77fbb577a69a92da2690a5ef384f]

        jsdialog: enable header and footer dialog in impress
        
        Change-Id: Iac64dea2811b8a784ff237d72eb02b36b29d042b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149422
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149837
        Tested-by: Jenkins

2023-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [96a47eeedfe4c8adcf2c2903d72fe6e4e12a65e3]

        simplify subclasses of comphelper::OPropertySetHelper
        
        they should deal in terms of the fast property IDS, they should not need
        to override setPropertyValueImpl, so just remove this, and standardise
        on the subclasses overriding setFastPropertyValueImpl
        
        Change-Id: I190955ccc4ae3e07dd481a1044f3c074dd1a40aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [589cd835436de8ada027280f927fa2ae28420317]

        CppunitTest_sc_macros_test: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I60792ef623f6db275bf5b1346debceaa38fd6539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149838
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [19c18c94085f7a70e536a914ed978fc54b5625b9]

        remove unnecessary UnoControlModel::setPropertyValues
        
        which does exactly the same thing as the method it overrides
        
        Change-Id: Ib227011795f0cf6336fb1e01c14636a9996bb164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [739da6657a665d38ef99032fe9756519a40ef2f6]

        make some method in comphelper::OPropertySetHelper final
        
        Change-Id: Ia745a0d7568cf8f9180ed2e28cfd11da94cd186a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149834
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dff8918050cd7210bd783c66eaa9bbf23571e22c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3b6c3b4f9c2a5834251afe1ced59be64321e23e
          - tdf#154475 Explain "Decorative" property in objects
            
            Change-Id: Ie00f6066453e9f7ab91ec86ee79ac1f949a0f43d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149765
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-31  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [992d86b1b67a6bd28bbf5e63b2d2406881f476b7]

        tdf#150542: DOCX import: support for document varibles
        
        Writer does insert document variables only if they are in
        document body as DOCVARIABLE fields. But ones given in
        settings.xml (w:docVars/w:docVar) were ignored.
        
        Moreover variables in settings should have priority and
        overwrite ones in fields. Word by default does show only
        field results, but refreshing field values will override
        values with ones from settings.
        
        Change-Id: I7103c90eef59ab18f8a25e616dcf8a8b1c6dcb08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149646
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-03-31  Szymon Kłos  <szymon.klos@collabora.com>  [42a432d0023bd0a2da7c3683e43575b0386e705c]

        jsdialog: enable Insert header footer
        
        Change-Id: Ib6f1cd1ffac5479ae9cdf1e47fe0cb69abfc8c91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148889
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149365

2023-03-31  Szymon Kłos  <szymon.klos@collabora.com>  [078d8ce4d4add3c11df524ff92b337a58a75b004]

        jsdialog: enable page format (calc)
        
        Change-Id: I2c40b1e6dbfcb8693afc27e65a75ef71e6a9b7e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148996
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149821
        Tested-by: Jenkins

2023-03-31  Szymon Kłos  <szymon.klos@collabora.com>  [e026ef65eed3c04df4d3dada09c4e1ef858d69a5]

        jsdialog: enable sort dialog
        
        Change-Id: I694bf3ea9982032b0202e408f8121a6407427cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148789
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149820
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-31  Julien Nabet  <serval2412@yahoo.fr>  [a135a182c38083511563009fc1c370e36c546d84]

        Revert "Related tdf#129547: add Excel shortcuts insert time/date in Calc for German UI"
        
        This reverts commit 6896c12ddeb00210629396046678bc1d83d45644.
        
        Reason for revert: it doesn't work according to https://bugs.documentfoundation.org/show_bug.cgi?id=129547#c48
        
        Change-Id: Ia65cd31b652d41ff15352479923c49e9b30ba822
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149797
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-31  Szymon Kłos  <szymon.klos@collabora.com>  [d34f1b24005b0b142ae3b5f6505852fcbd5abcac]

        jsdialog: enable Format cell dialog
        
        Change-Id: I19722ac3e8b3f58ba916aa21513ba7ee34ef0bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148990
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149366

2023-03-31  Caolán McNamara  <caolanm@redhat.com>  [09b00e959d587058a57be01abccf9873022c969b]

        crashtesting: XDataSeries OPropertySetHelper::getFastPropertyValue crash
        
        seen with
        
        gcc --version
        gcc (Debian 10.2.1-6) 10.2.1 20210110
        
        similar to
        
        commit ad59487053bcd267b53febde0cecbd64c7f94cc0
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Sun Mar 19 20:40:35 2023 +0000
        
            crashtesting: frequent XDiagram OPropertySetHelper::getFastPropertyValue crash
        
        Change-Id: If190e0c51a0b983165ff6f36bb2185456ea6bade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-31  Caolán McNamara  <caolanm@redhat.com>  [341ff232aec77c2b46325389da933315613b6f2d]

        gtk4: get a11y to say hello world
        
        role mappings are somewhat unsatisfactory, but can serve as placeholders
        for now
        
        Change-Id: I050fdc0e85fc57de6d79823b2432b521dcffcad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [1dd71d79e15bd8098e7c17c8fcea3748592a902f]

        tdf#154486: use importer-local map to deduplicate table names
        
        ... instead of SwDoc::GetUniqueTableName. The latter is expensive with
        many tables, has O(n^2) complexity with rather large O, and in corner
        cases of thousands tables with no or duplicate names, is unacceptably
        slow.
        
        Changes the test case import time from 39 s to 23 s on my system.
        
        Change-Id: Ia461c860d56cbbfdcb25bacbb9cca4961ced885e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149817
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-31  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [aceaab0839173051e4f6c7b15afe4fc90691abe6]

        fix poppler build
        
        * Update POPPLER_VERSION in poppler-config.patch.1
        
        Change-Id: Iba770e6a3036a091925997025d4528f1d855da5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148841
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-31  Miklos Vajna  <vmiklos@collabora.com>  [f6fbd9d5ff5b049112e6ca7a8943c156b3e4f411]

        sw floattable: remove empty follow flys on follow table removal
        
        - add a SwRootFrame::DeleteEmptyFlys_(), which can delete empty flys and
          invalidate the anchors, so the necessary text frame joins and page frame
          deletions happen
        
        - add a SwRootFrame::InsertEmptyFly(), which can build a to-delete list for
          DeleteEmptyFlys_()
        
        - add a SwFlyAtContentFrame::DelEmpty(), which can call InsertEmptyFly()
          for one empty fly frame
        
        - in SwTabFrame::Cut(), call DelEmpty() on the fly parent, similar to how we do
          it for sections
        
        - in SwLayAction::InternalAction(), call DeleteEmptyFlys() to actually delete
          the unnecessary fly frames
        
        Change-Id: I8d3b4ee2c07b60d6187059bb177c56a129810750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149815
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-31  Miklos Vajna  <vmiklos@collabora.com>  [ad811b4441f6f9f8f42114640fea39cf0f3156a5]

        sw layout xml dump: extract SwFootnoteContFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about footnote container
        frames.
        
        Change-Id: I2745cb74ff503288863439a15b37cec06766d208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149814
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [3db0ff0c49159f9856c259167256f6c5f89931e0]

        add some asserts in SwFormatAnchor
        
        Which flushes out some dodgy behaviour.
        
        Particularly in SwUndoFormatAttr, which was storing a sal_Int32 content offset in a sal_uInt16 page field.
        In this case, rather just store the value on SwUndoFormatAttr itself, the same way it does for other things.
        
        Change-Id: I5890353f5d51d82037bf7e0e77a16cf3b0dff565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149764
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Maxim Monastirsky  <momonasmon@gmail.com>  [1b463f697405e64a03378fb38a32172c4d3c25e6]

        sc drawstyles: Enable the UI
        
        I believe it's in a usable state now. But keep in
        mind that the work isn't finished yet. For example,
        there is only one base default style, and the work to
        support styles for comments wasn't merged yet.
        
        Change-Id: I1ad3a4803ad91773906743e19a35405d5cd3255d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149754
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-30  Maxim Monastirsky  <momonasmon@gmail.com>  [685a864cfc40227559ed55f6273fd118174e8e6e]

        sc drawstyles: Clipboard support
        
        - Paste as Calc's own format (default in Calc, results with an
          OLE object elsewhere), should preserve style assignment. This
          can be in one of two ways: Either copy the shape itself, or a
          cell range that includes a shape.
        
        - Similarly, copying or moving a whole sheet to another document
          should also preserve the style.
        
        - Paste as drawing format (default in other apps, also default
          in Calc when copying shapes from other apps), should preserve
          the formatting as direct formatting. Pasting into Calc will
          also assign the default style to that shape.
        
        Change-Id: Icb951dad1a77ba9ced706c33c928980d1ec7f8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149753
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-30  Maxim Monastirsky  <momonasmon@gmail.com>  [cb3b8b0aaa9d53bd4b4a74d22b87d46e77835206]

        sc drawstyles: Add a default style and make use of it
        
        The style is empty, similar to the default cell style,
        thus fall backs to the pool defaults for everything. This
        ensures compatibility with existing documents, despite the
        fact that the default style is applied to all shapes upon
        import. In addition, people who will ignore styles and just
        continue to use DF, will have their spreadsheets look the
        same in older versions that don't support styles. For this
        reason I also opted to not set a dedicated style for images
        and OLE objects via
        SdrModel::SetDefaultStyleSheetForSdrGrafObjAndSdrOle2Obj,
        unlike Impress/Draw, and continue setting the "no fill and
        no line" override as DF.
        
        Change-Id: I11554044a1aaf386dc6c4acdbab798fc5a231adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149359
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-30  Caolán McNamara  <caolanm@redhat.com>  [4ceb287c6d42940adf887f36c4f88abae44e0022]

        cid#1524600 Logically dead code
        
        since:
        
        commit 628275acb1b9652e65b8c5c013549dce5ad6f5bf
        Date:   Thu Mar 23 11:24:30 2023 +0900
        
            tdf#90407 Change the auto-fit alg. to match better with OOXML
        
        Change-Id: Ib315d7543229b6ddae0e3282be8cfdfb3f1bad13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-30  Caolán McNamara  <caolanm@redhat.com>  [5af55a4b4ce86c61cb227822c016f0d51e03c009]

        ofz#57483 Out-of-memory
        
        Change-Id: Id5e920c16f005512a14e41d453f435826a9e7053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-30  Caolán McNamara  <caolanm@redhat.com>  [df6bf128ae89d9b4a85fc8300ff7c5e0769e8055]

        ofz#57493 Timeout
        
        Change-Id: I7d4776d77385dc46f496b873c75e2be25840f86b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-30  Caolán McNamara  <caolanm@redhat.com>  [397e2d5118dcc5ebd8dedfe731de02fb4277960f]

        ofz#57529 Integer-overflow
        
        Change-Id: I93775299aa340e2e645a04be5d0bc36a9caea103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149773
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-30  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [1bdd92bceb5997d5d0ed27b59734c88f7546a4da]

        SwTableFormulaUpdate: SwMsgPoolItem no more
        
        - get rid of legacy call with unused WhichId (TABLEFML_UPDATE)
        - simplify and inlune ChangeSate, by now only handling TBL_CALC
        - simplify params for UpdateTableFields (explictly just one SwTable*)
        
        Change-Id: Ie356c2a17eab0b557efb54719d33e278b887eef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149591
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-03-30  Caolán McNamara  <caolanm@redhat.com>  [a1f6628e0b73556e0f9fa5f4110068ab7096af1a]

        ofz#57526 Abrt
        
        Change-Id: Ic165f012e6fc21e4be6833ccbfd6ad70e522cc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149772
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [db7f33af1438538bb51b376242294ecd3bfcb055]

        loplugin:stringadd in various
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I8cf6a47ad357ddc73e2c430d966be72d5efd1485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149767
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Bogdan B  <buzea.bogdan@libreoffice.org>  [7d8ffcc587dc54764e3fc67b8622b7b0c088297e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a882aaf39f3c8f80c40f460565c51e5265b2b58
          - related tdf#152011 Typo in Insert description
            
            Change-Id: I20fb5670621cb2a496fdf099d7f7c5599330fe5f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149703
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-30  Julien Nabet  <serval2412@yahoo.fr>  [6896c12ddeb00210629396046678bc1d83d45644]

        Related tdf#129547: add Excel shortcuts insert time/date in Calc for German UI
        
        For German UI and locale
        German layout keyboard (based from https://en.wikipedia.org/wiki/German_keyboard_layout)
        
        https://www.traens.com/tipps/microsoft/datum-uhrzeit-excel.html
        indicates:
        "
        Einfügen eines statischen Datums in Excel
        Drücken Sie STRG + . (Strg und Punkt)
        
        Einfügen der aktuellen Uhrzeit in eine Excel Tabelle
        Drücken Sie STRG+UMSCHALT+. (Strg, Umschalt, Punkt)
        "
        
        so I added (specifically for "de"):
        POINT_MOD1 for InsertCurrentDate
        COLON_SHIFT_MOD1 for InsertCurrentTime
        
        Change-Id: I2523dddf918f9680f87c82c174e20462620948ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [b26a65bb108e2c681e0721bfe590e68f2fe5a602]

        Simplify some calls to HtmlWriter::attribute
        
        Change-Id: I608efc6cf7ae05df5a0db3282e0a55315e286718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149759
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d00f6c851b7680f18f602b10ca19a1c9223d276]

        no need to make copies of the GrabBag map
        
        Change-Id: I5cd697d0cfaf65a9ad581d4d7571a69e6214cbb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [5988a3cf91e2cb5bf1628b88965e3652932e4eb6]

        loplugin:stringadd in xmloff
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: Id38d983e59386554c61e9bdcd9333554bbf4665c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149756
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5084d15e1b72e303e1628fbff84432036b014a9]

        loplugin:stringadd in vcl
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I44ce7183e4b292269fac1e3d2217286bf5abe823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149752
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ffdcbdd29f014fcce290dfdb969fb6ff66a95ed]

        loplugin:stringadd in ucb
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I2445a69dc46314c73f54c190a0c498c0309be06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [04ed7cbe53243a042ceeecc62212e73a910d7aef]

        tdf#150471 Remove duplicated Freeze commands from the Tabbed UI
        
        As discussed in the ticket, the commands "Freeze First Column" and "Freeze First Row" are duplicated in the Tabbed UI (under the View tab), since there's already a "Freeze Rows and Columns" command that already offers these 2 options.
        
        So this patch removes the "Freeze First Column" and "Freeze First Row" entries and keep the "Freeze Rows and Columns" comand.
        
        The label of the ".uno:FreezePanes" is also changed to "Freeze Panes" so that it doesn't occupy so much space in the tab. I set the ContextLabel to "Freeze Rows and Columns", so in the menu and context menus, the text shown remains "Freeze Rows and Columns".
        
        Change-Id: I57e6b22b103c2316ca0722878491b719e93b9bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149650
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ad0669955228b2da64ecce34ea71d761d066864]

        loplugin:stringadd in test..tools
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I8619fa3280338afdfe75bdbfda6cb118d396e1c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f24d38de3c23479e79768cd3fcfe37692cee27e4]

        loplugin:stringadd in sd/sdext
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: Ic95e72e1c857c6814d6e25b9820494cdfa535465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [db9912d824c1d621fdc409b9cdd6c79caefe1327]

        loplugin:stringadd in ucbhelper..uui
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I49549347c1c041cc9ce103aed1fe1cc3bc1a780f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Sarper Akdemir  <sarper.akdemir@collabora.com>  [6b19f32252f8ba5540ce3b1e38f8ac6112421906]

        add docstring for unclear default distance property in SvxTabStopItem
        
        Change-Id: I6c9eef0a2167f738cdab8171d082becfca401d25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149740
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [efbbc141b0db77510b41b452bf3931fc3c9ecc7e]

        use more concrete types in chart2
        
        Change-Id: Iaefad282d40c83f58758b41db9b14f6e95552354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c8d43d8a9062dbe2cff52b61414e8be6d3b646d]

        loplugin:stringadd in sfx2
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I72c2afa0b6bddfe00fe09f34eb1b1bf2177461d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [ab07ba6a9f89aedf4c33fbe911ed8a7d55ced1dd]

        Report correct mimetypes for TIF and EMF
        
        Change-Id: I2eeb07780e3581eea29a9ad98b493de4e78a5d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149745
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa8fb790e8d3f975c7ffadcb5a4fa390186c6d5d]

        loplugin:stringadd in starmath..svl
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: Id8f229c3a5223dee8d2710caf15d4612594fc763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-30  Arvind K  <khandelwalarvind26@gmail.com>  [2ca71b5c6e0374254e7c75c75e54fa6a8caebfde]

        tdf#146748 Change 'More Numbering/Bullets' options to 'Customize'
        
        Change-Id: Ia9ae20b8c73ddd762424c99eedbaf145fed81935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148142
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-30  Mike Kaganski  <mike.kaganski@collabora.com>  [8e97ef854fb225dac37185c1911894b7d206fa8d]

        sw reqif-xhtml export: fix export of transparent TIF
        
        Since commit 22b50f1937de67e4ad9e692d6964aa5b8d33af7a (use libtiff for
        tiff import, 2022-05-21), transparent TIFs are imported correctly.
        As the result, reqif export started to output the transparent TIF
        images as GIFs, because XOutFlags::UseGifIfSensible handles case of
        transparency, and XOutFlags::UseNativeIfPossible didn't handle TIF.
        Additionally, the resulting mediatype was reported incorrectly:
        
          <reqif-xhtml:object data="[...].gif" type="image/tiff" ... >
        
        1. Handle TIFs in XOutBitmap::WriteGraphic when XOutFlags::UseNativeIfPossible
           is specified.
        2. Return the corrected mediatype from XOutBitmap::WriteGraphic,
           to inform the caller about the possible change.
        3. Remove the XOutFlags::UseGifIfSensible flag when doing the
           reqif export, to avoid the format change at all.
        
        Change-Id: I99f7cfb8d12ef66d372700ec810bd8b269868ffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149744
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [0e536abc286b50de171ecb0b6a57dad37467a516]

        tdf#108188 - Use constant string for default page style
        
        Change-Id: I7c398c3dec044722e4552527de8553506cda54f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149730
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-30  Miklos Vajna  <vmiklos@collabora.com>  [3ec17b23098eed2934020995a890740e7f8581cc]

        UITest_{calc_tests6,chart,chart2,sort}: enable oneprocess mode
        
        Execution time changes:
        
        - from 1m27,535s to 0m55,724s
        
        - from 5m40,926s to 4m46,884s
        
        - from 1m54,886s to 1m31,400s
        
        - from 3m30,592s to 2m20,833s
        
        for me. Also add a simple script that lists what's remaining to be
        converted.
        
        Change-Id: I274f5a11a0f606964bdad5d5e5254b65b09fe497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149739
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-30  Miklos Vajna  <vmiklos@collabora.com>  [d3bfbcb5f42ca0ff3441ee14b179ca590e646b1f]

        sw: fix undo comment of FN_UPDATE_FIELDS
        
        It's updates, not insert. One has to dispatch .uno:UpdateFields to see
        this in action, which does something if the document already has exiting
        reference marks.
        
        Change-Id: If5a06d2a81aa2439977c9fc51c3af1ee241f9eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149738
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9c7d3ce813c761b116232bc291e2737c59d383da]

        Add extended tip to labelselectiondialog.ui
        
        Change-Id: I6b4d0a30c2a1a51694770ecd02eea3cf3677b5eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149732
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eebbe47a5e08fa5e8442c621f454d54484235ac8]

        Bump Glade release for labelselectiondialog.ui
        
        Change-Id: Id941b353e8d9f0df2de3816d47e03ec564351701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149731
        Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [383c7c44645b37a5c1a0e16d814d218581773ffa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a24e9d015c2747c37533c9edec8a081318d6e96
          - tdf#83283 link help page for Label Field Selection in Form design
            
            Change-Id: Id9abe070e03956c283b2f1c33fdb7737b7584f6a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149734
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [73629951f68a2958ec77a74a3a4b50bbf0f3ebea]

        use more concrete types in chart2
        
        Change-Id: I1ba60b690a0402d1a98f792c86ddd033e0c39ed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149726
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [67cf6e0463c7538ebdd1ea7ba1b98c5e8cf8b7f9]

        use more get/setFastPropertyValue in chart2
        
        Change-Id: I4979cf5dab8b35ba35a46808cef76dc3f81c59b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [99463a6f7f25d53e806fb475a6d5e2ced13b10e6]

        use more get/setFastPropertyValue in chart2
        
        Change-Id: I1471309e200c8eec21844658b873f817565f9604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [c6431ba1d041379c37292337337690c01f144fe2]

        Prevent accidental OUString(nullptr)
        
        Similar to commit f20162304d73bc01955e9ef6506c3bd1c7016c48
        (Rule out OString(std::nullptr_t), 2015-07-12); after that,
        OUString was changed to have only one ctor taking pointer
        in LIBO_INTERNAL_ONLY case, so became a similar issue.
        
        Change-Id: Iac851d1c24c0616ee52a112b81ba71877c28c493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149696
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8085a68be7604e7bd00004e0d9445be5e266ffbb]

        tdf#154445 - Export all page styles even if they are not in use
        
        Change-Id: If0ca5ea97ad545058c6a70d223158a87bf9207ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149729
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-29  Miklos Vajna  <vmiklos@collabora.com>  [10daade356692417e43faaa1909d3794e279054b]

        UITest_calc_tests{,2,3,4}: enable oneprocess mode
        
        Execution time changes:
        
        - from 5m6,456s to 3m26,832s
        - from 2m56,710s to 1m56,982s
        - from 1m37,645s to 1m9,388s
        - from 1m52,203s to 1m12,651s
        
        for me.
        
        Change-Id: Ie3860309c768dd3aaf8efe40a1e995874737b052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149728
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [98a23169bf761825d0e6ed432632d71dee5a691f]

        use more concrete types in chart2
        
        Change-Id: I932d8a45d525b1b629a0aaee96a1643b155069f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2714b18cbaefb13131ae63396297cd57b564a3af]

        fix bug in WrappedRegressionCurvesProperty::setValueToSeries
        
        ever since
            commit 1cd3e2038010cb37bda82d38dd058b793b7eec26
            Author: Tomaž Vajngerl <quikee@gmail.com>
            Date:   Sat Jun 29 18:43:16 2013 +0200
            Multiple trendline removing and changing type support.
        
        Change-Id: Ibd24d0831932f25e60c05a00450d611e15875102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Sabri Unal  <libreajans@gmail.com>  [501c0fd78316b18e09811dfcffb923d62c41c5dc]

        tdf#153705 officecfg: use more Title Case in GenericCommands.xcu
        
        Change-Id: Ief2ed6d86b5f65d354d4e47d9ef2999bef81d643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149723
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-29  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [4bf27aa3a12cf4013ec1884ada902e905f751af7]

        libjpeg-turbo: upgrade to release 2.1.5.1
        
        Fixes a serious regression that 2.1.5 had.[1]
        
        [1] "Release 2.1.5.1 · libjpeg-turbo/libjpeg-turbo"
        <https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/2.1.5.1>
        
        Change-Id: I0586d735e17789482e0e8e667aafd2b5613a1232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-29  Caolán McNamara  <caolanm@redhat.com>  [0bd23b624035f0796fb161feadf948fd730b7cf8]

        crashtesting: xSource seen as empty reference
        
         #17 0x00007f42f14f1662 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
         #18 0x00007f42ef64c68f in com::sun::star::uno::Reference<com::sun::star::embed::XStorage>::operator-> (this=<optimized out>) at core/include/com/sun/star/uno/Reference.h:385
                 __PRETTY_FUNCTION__ = {<optimized out> <repeats 151 times>}
         #19 SfxObjectShell::CopyStoragesOfUnknownMediaType (xSource=..., xTarget=uno::Reference to (OStorage *) 0x561536cddad8, rExceptions=empty uno::Sequence) at core/sfx2/source/doc/objstor.cxx:3566
                 aSubElementNames = uninitialized uno::SequencePython Exception <class 'TypeError'> 'NoneType' object is not iterable:
        
                 bResult = true
         #20 0x00007f42ef65551d in SfxObjectShell::SaveAsChildren (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:3328
                 xStorage = uno::Reference to (OStorage *) 0x561536cddad8
                 AutoSaveEvent = false
                 lArgs = {<comphelper::SequenceAsHashMap> = {m_aMap = std::__debug::unordered_map with 2 elements = {[{maString = "AutoSaveEvent", mnHashCode = 528032507}] = uno::Any(void), [{maString = "FilterName", mnHashCode = -1339490047}] = uno::Any("string": "draw8")}}, static PROP_ABORTED = {{str = Python Exception <class 'AttributeError'> 'NoneType' object has no attribute 'lazy_string':
         , more = {refCount = 1073741824, length = 7, buffer = u"Aborted"}}}, static PROP_ASTEMPLATE = <same as static member of an already seen type>, static PROP_COMPONENTDATA = <same as static member of an already seen type>, static PROP_DOCUMENTSERVICE = {{str = "DocumentService", more = {refCount = 1073741824, length = 15, buffer = u"DocumentService"}}}, static PROP_ENCRYPTIONDATA = <same as static member of an already seen type>, static PROP_FILENAME = <same as static member of an already seen type>, static PROP_FILTERNAME = <same as static member of an already seen type>, static PROP_FILTERPROVIDER = <same as static member of an already seen type>, static PROP_FILTEROPTIONS = <same as static member of an already seen type>, static PROP_FRAME = <same as static member of an already seen type>, static PROP_FRAMENAME = <same as static member of an already seen type>, static PROP_HIDDEN = <same as static member of an already seen type>, static PROP_INPUTSTREAM = <same as static member of an already seen type>, static PROP_INTERACTIONHANDLER = <same as static member of an already seen type>, static PROP_AUTHENTICATIONHANDLER = <same as static member of an already seen type>, static PROP_JUMPMARK = <same as static member of an already seen type>, static PROP_MACROEXECUTIONMODE = <same as static member of an already seen type>, static PROP_MEDIATYPE = <same as static member of an already seen type>, static PROP_MINIMIZED = <same as static member of an already seen type>, static PROP_NOAUTOSAVE = <same as static member of an already seen type>, static PROP_OPENNEWVIEW = <same as static member of an already seen type>, static PROP_OUTPUTSTREAM = <same as static member of an already seen type>, static PROP_PASSWORD = <same as static member of an already seen type>, static PROP_POSTDATA = <same as static member of an already seen type>, static PROP_PREVIEW = <same as static member of an already seen type>, static PROP_READONLY = <same as static member of an already seen type>, static PROP_REFERRER = <same as static member of an already seen type>, static PROP_REPLACEABLE = <same as static member of an already seen type>, static PROP_SALVAGEDFILE = <same as static member of an already seen type>, static PROP_SILENT = <same as static member of an already seen type>, static PROP_STATUSINDICATOR = <same as static member of an already seen type>, static PROP_STREAM = <same as static member of an already seen type>, static PROP_STREAMFOROUTPUT = <same as static member of an already seen type>, static PROP_TEMPLATENAME = <same as static member of an already seen type>, static PROP_TITLE = <same as static member of an already seen type>, static PROP_TYPENAME = <same as static member of an already seen type>, static PROP_UCBCONTENT = <same as static member of an already seen type>, static PROP_UPDATEDOCMODE = <same as static member of an already seen type>, static PROP_URL = <same as static member of an already seen type>, static PROP_VERSION = <same as static member of an already seen type>, static PROP_DOCUMENTTITLE = <same as static member of an already seen type>, static PROP_MODEL = <same as static member of an already seen type>, static PROP_VIEWONLY = <same as static member of an already seen type>, static PROP_DOCUMENTBASEURL = <same as static member of an already seen type>, static PROP_SUGGESTEDSAVEASNAME = <same as static member of an already seen type>, static PROP_AUTOSAVEEVENT = <same as static member of an already seen type>}
                 aExceptions = empty uno::Sequence
         #21 0x00007f42ef6555fd in SfxObjectShell::SaveAs (this=this@entry=0x561536dad540, rMedium=...) at core/sfx2/source/doc/objstor.cxx:160
        
        Change-Id: Ie9bb49a8ebff6d985e93c7738da241ff8d61ff2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-29  Jaume Pujantell  <jaume.pujantell@collabora.com>  [20132d64bbd448950bcbd2b0d31504d5025ac6c7]

        tdf#149064 ensure interaction handler is present when transfering with webDAV
        
        Change-Id: I7a31f708e6fe01f07c7187aacd4657b5c6156c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149722
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-03-29  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [8bf897186de81b39064340c44a54db344d6878f6]

        tdf#124472 DOCX import: fix broken field command by skipping delInstrText
        
        Process only inserted and not tracked parts of the (partially)
        tracked field commands to avoid of broken fields, e.g. hyperlinks
        with bad URLs.
        
        For example, instead of the previous bad URL
        'https://www.libreoffice.org/"HYPERLINK https://bugs.libreoffice.org/',
        now the hypertext field of the test document imported with the
        correct URL 'https://www.libreoffice.org/'.
        
        Field commands have change tracking in OOXML, but not in ODF/Writer.
        OOXML delInstrText, i.e. deleted part of the field commands was imported
        as part of the actual command, resulting broken fields, e.g. hyperlinks.
        
        FieldCommand was splitted into two parts, deleted and non-deleted
        elements. This way the commands do not get mixed up if the order
        is changed and no fragmentation of deleted items occurs (otherwise
        it could fail on the test of tdf#150086).
        
        Change-Id: I97d22e5ee1fe647715206f86c4160ebcc4b9cca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148528
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6213787202570f783458a2d00351851ad46150d7]

        use more concrete types in chart2
        
        Change-Id: Id665050f4f0763505e7f1ace6ade5bf9ab02edf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149686
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [23c2fb9dbfa5b3eca64ba8aef1a82f9c60d39397]

        use more get/setFastPropertyValue in pie charts
        
        Change-Id: I17bf8631b5934d6d112f17e4a05025802dcde2f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149685
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [856e6627c21b84a0b9ab2e3cb95a5a57864854e8]

        use more concrete types in chart2
        
        Change-Id: I938aa1d6d3c20b35d9e11818d4b641d8a03decaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149684
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Caolán McNamara  <caolanm@redhat.com>  [06b34d9f4b7967e87cd53e0effd98bfacfee2bb9]

        crashtesting: Null-deref on export of forum-mso-en4-274729.xls to ods
        
        and others, probably since:
        
        commit f02ec0d8489404966596cb0e949bf969e8e66fa2
        Date:   Wed Mar 22 08:50:15 2023 +0200
        
            move hasUnhiddenData inside chart2::DataSeries
        
        Change-Id: Icf59439f00a40ef036decaa36f3d5af68787c864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2e78d06df22e99f2dc82ee3245ddc4c5de56acf]

        fix concurrent access to fontcache
        
        Every now and then I see a crash in fontcache code.
        Add some DBG_SOLARMUTEX calls there, which spots a few issues.
        
        (*) In writer, SwDLL needs to be under the SolarMutex during
        init, and we can just move a method call to fix that.
        
        (*) in chart2, life is more complicated. Various of the static
        defaults we build want to call OutputDevice::getFontInstance.
        We can't just stick a SolarMutex somewhere in the call chain,
        because those maps are built on-demand, and then we end up
        with ABBA deadlocks between the SolarMutex and the mutex
        in the cppu::PropertySetHelper.
        So I picked a spot that is init'ed early on in chart2,
        and force the init of all the troublesome tables there.
        
        Change-Id: I832978bea35fd5fa681d144b8beff1af13ef3341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Mike Kaganski  <mike.kaganski@collabora.com>  [167b864fb1933d069293760e50e1f204a3d2e63d]

        Add an assert
        
        Change-Id: Iee190f27323202d5bb673aaba3116071f294a85b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149695
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [f51b220b953ec71fb742f799fbe645a93cf3d944]

        tdf#149805 tdf#151677 tdf#152217 tdf#154043 tdf#153458 tdf#153800 Revert "VCL expect
        
        ... correct frame size for native menubars"
        
        This reverts
        
            commit afc828b9833b7a612369e95606ba56d41ef2c369
            Date:   Sat May 28 23:47:21 2022 +0200
        
                VCL expect correct frame size for native menubars
        
                ... and renove the wrong framesize hack in the Qt backend
        
        because it caused several regressions and unfortunately
        the commit also doesn't fix all of the bugs mentioned
        in its commit message (while some previous patch sets of the
        change did address more, yet had other issues, s.a. the discussion
        in the commit's Gerrit change [1]).
        
        While e.g. the drag and drop issues reported in tdf#153458
        and tdf#153800 could be fixed by translating the event position
        using `mapToParent()` (as is done in
        `QtWidget::fillSalAbstractMouseEvent` with the above commit
        in place), I currently don't see how to address the other
        issues and the overall direction of the change is not fully
        clear to me at this point. (There are also other pending changes
        in the relation change still pending in Gerrit that would presumably
        need more work/analysis.)
        
        After all, it seems the best way forward to revert the
        commit for now.
        
        This also reverts the follow-up commit
        
            commit 25da92004038c03c0feedf373e8038e7ee3e0c37
            Date:   Thu Jul 21 11:33:02 2022 +0200
        
                Make JunitTest_toolkit_unoapi_1 succeed again on macOS
        
        that fixed a test failure introduced by the above commit.
        
        Luckily, there seem to be no follow-up commits that
        depend on this and the commits can be reverted cleanly
        without the need to resolve any conflicts manually.
        
        This reverts commit 25da92004038c03c0feedf373e8038e7ee3e0c37.
        This reverts commit afc828b9833b7a612369e95606ba56d41ef2c369.
        
        [1] https://gerrit.libreoffice.org/c/core/+/135082
        
        Change-Id: I4c099ad7de8cbbad10da391ede4770d8c748fbde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149495
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-29  Heiko Tietze  <tietze.heiko@gmail.com>  [5675937f7564fa5614f7be5aec0d7f20ba91d02c]

        Resolves tdf#152184 - Application color should follow system color
        
        This patch reverts the previously added "LibreOffice Dark" application color set and adds it to the automatic colors. Switching between light and dark changes the Automatic color accordingly instead switching to another color scheme. The added System Theme option makes Light/Dark follow the actual OS appearance.
        
        Reverts 6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06 (Introduce dark color set),
        546ad5d17d3e363b75337c336cfb2b2f8acc55e3 (color scheme translatable),
        9f0cf00d29298ed55737928ec4dddc50ac850cd8 (Update view options string based on theme)
        
        Change-Id: Ibf491f2e510fac5f1d27a7166560c4ec281d98d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149059
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d4917db0ec647561c3c02765765491e9ae2d8eb]

        expand out ChartModelHelper::findDiagram
        
        since it just calls findFirstChartDiagram
        
        Change-Id: I21eb9a747127ad54f3b5875074a7bf7ffbf79e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149681
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [0af8c811ccd297539c56f03af8353175671e189c]

        use more concrete types in chart2
        
        Change-Id: I286ad05252bb34f7a1b8f7c08190bddc601faf3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149680
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f93816dd5d75aca98f210017d0b58b7ef1d08da]

        loplugin:stringadd in sw
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I0999a0b04236c276d49c541bbbe3932ba3e5e05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [92c504b5bd9ec81474704f563b23a2fcd422d1d1]

        use more concrete types in chart2
        
        Change-Id: I818253350bd954d3a2a0f302493c896eb2e26994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149675
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [5e482317a0b140b11220554753e30ccfd53385ee]

        use more concrete types in chart2
        
        Change-Id: Ifd3bce5fc22371559203da673ca98913bc742c21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149674
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Stephan Bergmann  <sbergman@redhat.com>  [cfe339efd5f306452bc78ae4121867dc9b07b95a]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/85022d587be454efd482bcb9baf657d570cc7d06>
        "Update GVFS, Kerberos5, Apache Ant and OpenJDK Flathub Extension"
        
        Change-Id: I6b03adb5872958578b7b2e4bfe3e26bea8882213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149679
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-29  Caolán McNamara  <caolanm@redhat.com>  [1d2ad8e8823a8633534580d589270945f01f1ca1]

        tdf#154115 use correct column for search
        
        Change-Id: Iaa390e63d269221b7273fe15362cfbdf20f235da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a15329d53f20bf913fe63c05fc7c53e17bd68e97]

        loplugin:stringadd in svx
        
        when applying my upcoming patch to also consider O[U]StringBuffer
        
        Change-Id: I043885ed3120ff6f4262f339c69f15e2b2d4a85c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [5482a582db942fcb02aec57a904ab16d496006f2]

        use more concrete types in chart2
        
        Change-Id: I7ec6df57504b3515be09796016b6db02521e5d67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-29  Miklos Vajna  <vmiklos@collabora.com>  [a304bd8245f8078813014e90ada91c3332f63146]

        CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfParagraph
        
        Set the filter options explicitly, rather than inferring it from the
        test name.
        
        Change-Id: Ic1c13c7f63bb7c052ba4786a45ac02ea3e2b56ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149655
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-29  Yousef_Rabia  <yousef.mohamed.rabia@gmail.com>  [6700f7f5b4eae31bf020e7d073c496c6e67a2397]

        tdf#147906 Use Math.hypot() for Pythagorean addition
        
        Change-Id: I8823038bde51002ea8c02ca7e841aca99f928a58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149618
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-28  Eike Rathke  <erack@redhat.com>  [002f941ec20e594e9702c39fab9cf9f4cc392dab]

        Resolves: tdf#154433 Correct {uk-UA} quotation mark characters
        
        Change-Id: Id5c251ee632d2da134ffbbb352844152f12c1f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149654
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [90baab0f50bcf35ae29f1841509ecdace9be77db]

        use more concrete types in chart2
        
        Change-Id: I067e9424a77fb1d835f2847bba3c3f2cda3430f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef1f51571654d6449c6ce2872a4bc2bc2475585d]

        move switchRightAngledAxes from ThreeDHelper to Diagram
        
        so we can use the get/setFastPropertyValue methods
        
        Change-Id: Id17fa2466f75a3b4530306143ce50f66fc5593b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [983456a42dd2a5a08d7d053f8e3069fbd8c9777d]

        Removed executable bits on ods file
        
        Change-Id: I9a43b02caaad389d8f67a2d2d43ad555d131edf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149645
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8eb682f932d7feb1db2157e6d522126152de786c]

        move setDefaultRotation from ThreeDHelper to Diagram
        
        so we can use the get/setFastPropertyValue methods
        
        Change-Id: Id9470e5b878ed15e20ca285cacc36cd2e9511365
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b17a441912da448ca0c731a015f4221ae264d959]

        move get/setScheme from ThreeDHelper to Diagram
        
        so we can use the get/setFastPropertyValue methods
        
        Change-Id: I2b57212a1d3933cd2825e647f692e2ae3cb8b484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-28  Stephan Bergmann  <sbergman@redhat.com>  [7fcfc39232d2fea7078c15552ee092b973e9175b]

        Fix build for recent GCC
        
        ...after 58dd5870a77344754ea459d8423d1b3787a6a813 "Avoid dangling references to
        temporary O[U]StringConcatMarker instances" caused e.g.
        
        > In file included from /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/include/rtl/string.hxx:49,
        >                  from /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/include/rtl/ustring.hxx:43,
        >                  from /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/include/osl/module.hxx:31,
        >                  from /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/sal/osl/all/loadmodulerelative.cxx:26:
        > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/include/rtl/stringconcat.hxx:468:8: error: partial specialization ‘struct rtl::StringConcat<C, rtl::StringConcatMarker<C>, T2, Dummy>’ is not more specialized than [-fpermissive]
        >   468 | struct StringConcat<C, StringConcatMarker<C>, T2, Dummy>
        >       |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > /home/tdf/lode/jenkins/workspace/lo_callgrind_linux/include/rtl/stringconcat.hxx:190:8: note: primary template ‘template<class C, class T1, class T2, typename std::enable_if<(allowStringConcat<C, T1> && allowStringConcat<C, T2>), int>::type <anonymous> > struct rtl::StringConcat’
        >   190 | struct StringConcat
        >       |        ^~~~~~~~~~~~
        
        (<https://ci.libreoffice.org/job/lo_callgrind_linux/13174/>) with GCC 11.02.
        (But what fixes it for recent versions of GCC would start to fail with
        
        > In file included from sal/osl/all/loadmodulerelative.cxx:26:
        > In file included from include/osl/module.hxx:31:
        > In file included from include/rtl/ustring.hxx:43:
        > In file included from include/rtl/string.hxx:49:
        > include/rtl/stringconcat.hxx:468:8: error: non-type template argument specializes a template parameter with dependent type 'std::enable_if_t<allowStringConcat<C, T1> && allowStringConcat<C, T2>, int>' (aka 'typename enable_if<allowStringConcat<C, T1> && allowStringConcat<C, T2>, int>::type')
        > struct StringConcat<C, StringConcatMarker<C>, T2>
        >        ^
        > include/rtl/stringconcat.hxx:189:125: note: template parameter is declared here
        > template <typename C, typename T1, typename T2, std::enable_if_t<allowStringConcat<C, T1> && allowStringConcat<C, T2>, int> = 0 >
        >                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
        
        for e.g. Clang 17 trunk.)
        
        Change-Id: I6110d5a2813b561748654065e76bb4b6ab2f82d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149644
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [5bcc7e6abfd8a0838f6f2c13b9e7040748913e28]

        move get/setRotation from ThreeDHelper to Diagram
        
        so we can use the get/setFastPropertyValue methods
        
        Change-Id: I147ed5c092b44283bfbbf4ea5a3145736417b92c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149642
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-28  Mike Kaganski  <mike.kaganski@collabora.com>  [5f154a342583540a7bbac3a135d29114ef16aacb]

        Simplify OfaTreeOptionsDialog ctors by delegation
        
        Change-Id: Iea1487bde1c5a15934c5678a53648f3597df5cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149643
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-28  Miklos Vajna  <vmiklos@collabora.com>  [98cf5157d69d9f1692be7f2cac958b1dfb387ca9]

        editeng: document SvxOrphansItem and SvxWidowsItem
        
        Replace boilerplate with something that actually helps remembering which
        one is which.
        
        Change-Id: Ia74b69d756cd31006b6f56726aeb37dc86880238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149636
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-28  Caolán McNamara  <caolanm@redhat.com>  [6a9e5614fe88e7b9cd32adb3484cc8bba142246e]

        resave with latest glade
        
        Change-Id: Ib75edfa79a2beffcb1d5b4222901a7f2fd61d44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d622972dceba40d89852b1dc832c6e2a4612b2fa]

        tdf#142391 - Store method using 0x13 format only when actually needed
        
        Change-Id: I907d234b20be5e3c7bee0d44407f1bf4c4b49f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149175
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-28  László Németh  <nemeth@numbertext.org>  [bb97bfe3168916ec54404a35f1f0d66d8c06c50d]

        tdf#153628 sw: fix locked spell checking in spelling dialog
        
        Which resulted incomplete spell checking finished before
        checking the document.
        
        Regression from commit b484e5d9e0d22b794c2d1c73741191836158a4ad
        "use more SwPosition::Assign".
        
        Follow-up to commit 2780b026f912a103aea3f8dc19319b998d19a43a
        "tdf#152738 sw: fix lost SwPosition in spelling dialog" and
        commit 221d76260096b9e6b4c4479b1b89c95af8b05774 "simplify assignment".
        
        Change-Id: Ib66903596847016ddaf68da42813dd3a839adb59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149633
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f81b47eb98eee8a2b2c027b91b8d7cea1179fad4]

        move get/setCameraDistance from ThreeDHelper to Diagram
        
        so we can use the get/setFastPropertyValue methods
        
        Change-Id: Ibce7c93f067468f2e88f196158dfcb80686d01c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-27  Justin Luth  <justin.luth@collabora.com>  [4daeb21a5f533144fd6b3bc397a98f37e5b1dd4c]

        sw CopyBookmarks: ensure that Move copies can rename
        
        The problem was that a reference to the bookmark name
        was failing - since the move was adding a "Copy 1" at the end.
        
        That rename line is very deceptive because AFAICS it fails every time.
        I'm going to look at removing it in a followup commit.
        
        Two other unit tests also found with make sw.check
        -tdf149089.docx
        -tdf149507.docx
        but they also didn't have references to the bookmark to visually notice.
        
        make CppunitTest_sw_ooxmlexport10 CPPUNIT_TEST_NAME=testTdf92157
        
        Change-Id: Idd695ec4a89057b28a68bc051b73f17fd4c3de56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149574
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3a30f1a0fd555febd770b6097197d0d9e499afc6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c28ee643a415afa0953ece2df6873839febf495
          - tdf#153739 add "bookmark" to Glossary; make relevant cross-references
            
            Change-Id: I7ef8c33a39383a00c8c538694808b4383ad983b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149095
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [2001572a49afb3561219c36a7376b4c325dcbc07]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab10c28fab4226c0270c9870561094af4dbca01d
          - Related tdf#151309 Use t-test instead of T Test
            
            As discussed in the ticket, we should use "t-test" instead of "T Test".
            
            A previous patch fixed the occurrences in the UI. This patch fixes this only occurrence in the help files.
            
            Actually the entire text uses "t-test" but the page title uses "T Test". So here I made the page title better match the title used in the heading <h1>.
            
            Change-Id: I50d8814af5d4f93568aca7e5c299d95664bdb582
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149607
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-27  Laurent Balland  <laurent.balland@mailo.fr>  [c1c2a6acf936a9568d8abf7ccaaa85e3532a3a6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e24ed3bc78751e931c81a98a542af71aa4a0f5b4
          - tdf#154131 Import text in Calc: Scientific numbers
            
            Since LibO 3.6, numbers in scientific notation are always detected with or without the option "Detect special numbers".
            This change update help for this "new" behavior.
            
            Change-Id: I1fb033229f29f4cc850fe28ea51d89413e52ed58
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149467
            Tested-by: Jenkins
            Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
            Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5978039917f4e9c6e85c04ce0243a2b386e6f23a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68257fa557206cc11dfcad9fdb037eaceb131217
          - tdf#154364 (final) refactor "related topics" for share/guide
            
            + refactor
            + some changes in content display
            + few icon updates
            
            Change-Id: I1cc1823313d96667827a590b48eb4bcbe5419ba5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149632
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-27  Stephan Bergmann  <sbergman@redhat.com>  [58dd5870a77344754ea459d8423d1b3787a6a813]

        Avoid dangling references to temporary O[U]StringConcatMarker instances
        
        ...which were created in O[U]String::Concat and bound to O[U]StringConcat::left.
        Thanks to Mike Kaganski for finding this.
        
        Change-Id: Id7838bc55eec7cba8860c2ec21a247bf4abd3c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149629
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-27  Stephan Bergmann  <sbergman@redhat.com>  [4ca42f5d7c6b29814741f6df74dbc22ea45b47ca]

        -Werror=maybe-uninitialized
        
        Change-Id: I65f7583851dda2233a375a9f37a7e12a7fc29d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149625
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-27  Tünde Tóth  <toth.tunde@nisz.hu>  [7f4f88b883f81fbce975f72aea0f66a54e269ead]

        tdf#145147 DOCX import: fix hyperlink in group shape
        
        Hyperlink inserted to shape lost, if the shape was
        inside a group shape.
        
        Test: ungroup the grouped shape and move the mouse
        over the shapes, or use Edit Hyperlink... in their
        context menu.
        
        Change-Id: I45d816f18a1e1bc1c442943b31c9e0ae7de199e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148552
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-03-27  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [5f138e23f61b58857b0e90dc09642ee832af29d4]

        tdf#135786: DOCX import: remove dummy paragraph before tables with comment
        
        Section-starting tables were imported with a section-starting dummy
        paragraph, when the tables contain comments. Remove dummy paragraph
        by postponing the call of RemoveDummyParaForTableInSection() after
        the annotations are processed.
        
        Regression from commit 2e8aad6d45c53d554ccaf26de998ede708cfc289
        "fdo#39056 fdo#75431 Section Properties if section starts with table".
        
        Change-Id: I4c566d0adbe16e4f57018301a98db93b37bcd45f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149623
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-27  Mike Kaganski  <mike.kaganski@collabora.com>  [5ed8d20d5f846e916e8af6f58d55955d9657e749]

        Simplify EventDescription ctor
        
        Change-Id: Ie6a743e2a67394fc85014acd5acf7c53e86c31c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149606
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [13c37d2c0f0a172d2522b255c0416a4ade639b7a]

        MCGR: More corrections fo sortAndCorrectColorStops
        
        Handle cases where gradient snippets overlap Start/End-
        Color to preverve input information.
        Added more test cases to createNewSdrFillAttribute to
        check these cases.
        All 27 look good, so add this changes.
        
        Change-Id: I6b2ba190ac8cf5a00c5a27865cea6bb41efe5110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149624
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b653556f8dc5a65805a0ef091f654b95caa20a63]

        Better error msg for sheet insertNewByName() and copyByName()
        
        + Indicate where the error occurs,
        + What are the possible causes,
        + and what are the possible fixes.
        
        Change-Id: I42d4d35ba33a1f5a20a2f0b20724754d8c63a049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149589
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f51ea7a8ec9150006c0fa8d9a9cfccadb61c014b]

        tdf#153362 oox: remove dead link from ooxml-export-notes.txt
        
        Change-Id: Iccb91f586bdbd2533f7684a9ef0307d8e492a7a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149627
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-27  Miklos Vajna  <vmiklos@collabora.com>  [40b6224780284d0e7fa542698bd17586a525159b]

        xmloff: prefix members of NameSpaceEntry, SinglePropertySetInfoCache, ...
        
        ... SvXMLAutoStylePoolP and SvXMLNamespaceMap
        
        See tdf#94879 for motivation.
        
        Change-Id: I306ceadd6d3753b76188fed3707b4df63c10bb8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149621
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f91e4a982672969c80e6117d09ae816a8dc5f21]

        loplugin:stringadd in oox..pyuno
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: I5fdc0a33923fe00e7b588f4576607515a93e5c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-27  Michael Stahl  <michael.stahl@allotropia.de>  [d9031bd83ffe718a80da9ecbdbeb485e35fbabee]

        tdf#152234 vcl: PDF/UA export: StructElem<->Annot for form controls
        
        veraPDF complains:
        
          Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 1
          A Widget annotation shall be nested within a Form tag per
          ISO 32000-1:2008, 14.8.4.5, Table 340.
        
        This is a little simpler than for Link and Screen annotations, because
        the form control StructElem and Annot are exported at the same time
        from VclMetafileProcessor2D::processControlPrimitive2D().
        
        So PDFExtOutDevData can just make up the mapping on playback.
        
        Change-Id: Idacb84a3e414f45a2598ccb33b252205cb2bcde9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149556
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-27  Michael Stahl  <michael.stahl@allotropia.de>  [a9ba09b66feec19206b0b7c6b70c6d905a6dbfe2]

        sw: fix assert due to inconsistent ordering of MarkManager::m_vAllMarks
        
        In function:
            std::pair<_FIter, _FIter> std::equal_range(_FIter, _FIter, const _Tp&,
            _Compare) [with _FIter = gnu_debug::_Safe_iterator<gnu_cxx::
            normal_iterator<sw::mark::MarkBase**, vector<sw::mark::MarkBase*,
            allocator<sw::mark::MarkBase*> > >, debug::vector<sw::mark::MarkBase*>,
            random_access_iterator_tag>; _Tp = SwPosition; _Compare =
            {anonymous}::CompareIMarkStartsBefore]
        
        Error: elements in iterator range [first, last) are not partitioned by the
        predicate __comp and value __val.
        
        Change-Id: I2c78d64dc6e87ba1aae0dd08a0ece01b0c43e9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149553
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-27  Michael Stahl  <michael.stahl@allotropia.de>  [002a6fee2fbd07c3f0cd1f1ddba39c691130727e]

        tdf#152234 drawinglayer,svx: PDF/UA export: add Alt text to form controls
        
          Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 3
          A form field whose hidden flag is not set and whose rectangle is not outside the crop-box shall have a TU key present or all its Widget annotations shall have alternative descriptions (in the form of an Alt entry in the enclosing structure elements)
        
        Form controls are weird because they have an SdrObject with the usual
        name/title/description plus a property "HelpText" on the control itself
        which is already exported as "/TU" on the /Annot unless it's empty.
        
        Exporting the SdrObject properties via ObjectInfoPrimitive2D doesn't
        work as tragically that is only created for form controls when painting
        to the screen while PDF export takes a detour that needs special
        handling.
        
        Change-Id: Id96f7dd13f190ab439c099cd1f4acb70c1c9fdc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149554
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a41dbf0bd726613204d975fb4fc5e50c23d61410]

        tdf#153466 PPTX import: fix "Custom position/size" background image
        
        Custom sized background with the value "tile" was imported as
        "stretched", losing the preset size. Restore also the exported
        preset positions, and map the other values to the preset positions
        supported by OpenDocument/Impress.
        
        Follow-up to commit 11451781d4c562f506a3aae3732e35b92387b4db
        (tdf#153105 PPTX export: fix "Custom position/size" background image)
        
        Change-Id: Ibf9b487ecd31b3ad7b06bda668c51e6b7a98c4af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148482
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-27  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [31690100461d42fd93b9a1a6546b1e17a8d31720]

        refactor table split
        
        Change-Id: Ifd7e77b29205fa505ed2fe41d08b4253f50a99a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149185
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-03-27  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7c680a96122f7f90114932ef5fdb48328c327268]

        refactor table merge
        
        Change-Id: Ia4d5b3fc04cc032a182b4bf7f7570fc250ed8504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148739
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-03-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [998882138adf693b04a2061714fcc33646619912]

        tdf#151309 Fix the use of t-test in the UI
        
        As discussed in the ticket, we should use "t-test" instead of "T test".
        
        Change-Id: I0aeb122b0f9a9affd4c298915956396580cb4de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149598
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-26  Jim Raykowski  <raykowj@gmail.com>  [e0daa98a802cc1f84ceb0f306f5d15fecabd62c1]

        tdf#126632 tdf#152908 Resize the notebook bar on context change
        
        For other than gtk vcl backend the tabbed compact toolbar tabs do not
        repaint correctly when the 'Table' tab is active and the cursor is move
        outside of the table. This patch adds a Resize after the context is set
        to make the tabs always show as expected.
        
        Change-Id: Iedf8a6eea52c3c55e9c1266b7aa79bc0f34deb22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149593
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-03-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9917f1fa0e159b8d237639a99335b4cdb5e4fdc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 802dff23502b199e496847b3091a557e8e4c793b
          - tdf#154364 (part) refactor "related topics" for simpress
            
            Change-Id: I7838818dd88538b9ab797f132f140b8a11864b10
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149620
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [98d4732ff7e315f82767be47ea71716f904d6940]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7484a8aa5d9f1350d4272aa3a1ed894cc05e102e
          - tdf#154364 (part) refactor "related topics" for smath
            
            + refactor
            
            Change-Id: I7528998a4a1254b4c0af0092dfd73db896422a18
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149619
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [46bac65b3e2d8e22f161d3fa88507355cacb0cb1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9c5ba9aeebcfb261ea59f2a43e489884c04a2e88
          - tdf#154234 clarify meaning of A,B,C (a,b,c) and A,AA,AAA (a,aa,aaa)
            
               definitions are in text/shared/01/06050500.xhp
               then embedded in other relevant files
            
            Change-Id: Ibf23f6271d804e199a9606a4c18d10eae6a8c557
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149028
            Tested-by: Jenkins
            Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-03-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [69cc8bdd5f9109804d912b52d5ee1040d6e1868f]

        Related: tdf#154005 sc ods fileopen: fix dropdown form control size
        
        Fixing the crashtesting assert/crash after the original change.
        Also a little clean-up.
        
        Change-Id: I35453fbc55b3d5d4064179e84755334c2d3a01ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-03-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [628275acb1b9652e65b8c5c013549dce5ad6f5bf]

        tdf#90407 Change the auto-fit alg. to match better with OOXML
        
        The auto-fit algorithm has been tweaked to be more in-line with
        the expectations of OOXML. This means a couple of changes to what
        properties are scaled by the algorithm have been made:
        - most properties that influence the X axis position or size (for
        example indent) are not scaled down or changed by scaling.
        - properties that influence y axis position and size are scaled
        by a separate parameter (like in the OOXML). This is used in the
        auto-fit algorithm in a different way.
        - if line spacing is proportional, it is now scaled with the
        spacing parameter. Fixed line spacing doesn't get scaled.
        - the main scaling X,Y parameter only scales the fonts.
        - trying hard to scale the fonts to the nearest pt (point) value
        
        With this change the scaling is much more stable than it was
        before - for example it doesn't matter what the unscaled font
        size is, when it is scaled down to the text box size, it (should)
        always look the same (for example scaling from 32pt -> 10pt or
        64pt -> 10pt or even 999pt -> 10pt).
        
        The algorithm is also rewritten to be better at finding a fit and
        is also better at find a good fit, but it can take more iterations
        by doing so (there are ways to improve it however). Previous
        algorithm used a linear search to converge to the best fit in less
        iterations, but the issue with that was that it could in some cases
        miss a solution (especially since change to floating point scaling
        parameter). The new algorithm now uses a binary search - always
        trying the middle of the search space.
        
        OOXML export and import was also changed to take advantage of the
        font scaling and spacing scaling parameters. The additional
        scaling at export that was needed to have consistent OOXML support
        was removed.
        
        Change-Id: I8f3bb8d43a01931f18bd7ffdf8e0ba40caa73d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149207
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a5fde5d749d27b0da216da4412f8b750178b1b08]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e3d807ec068688bbca1c3c384fa6ecda196fc59
          - Fix XHP tag
            
            Change-Id: I90f3290ba28baa88d8d60808234a3ed510d81d19
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149596
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [86313f053315cd0ba896e494d7bac14d2279c9b4]

        loplugin:stringadd in sc
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: Ifa70db5be4719fe66d3043e5e49403246f6aa8bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149582
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-26  Julien Nabet  <serval2412@yahoo.fr>  [4938bbcd64e95c9b494bcc32e8a5be3706f00cfa]

        tdf#154378: blacklist GeForce RTX 3080 for Skia hardware rendering
        
        Change-Id: I0dc4e0fd34737613a45eb358449a7cfb12467bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149617
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-26  Maxim Monastirsky  <momonasmon@gmail.com>  [f0287aad967761d46cb6903fc0d985a536408176]

        svx: don't overwrite the first cell's style
        
        i.e. new Draw document, change the char formatting in the
        default drawing style (e.g. font size), insert a table and
        fill its cells with text. Save and reload. After reload the
        first cell inherits the formatting of the default DS,
        instead of its assigned cell style. But dragging the table
        around shows the correct formatting in the dragging overlay,
        and it's also correct when copy & pasting the table.
        
        This is caused by the order of things at import, as a table
        is created initially with a single cell at least, and it
        gets its cell style assignment too early. There is also
        similar code to what is changed here in SdrTextObj::
        BegTextEdit, and it's rightfully overridden by SdrTableObj.
        
        This appears to be a regression from 4-0, but I'm not sure
        which commit and what exactly changed there.
        
        Change-Id: Id096c7b5f330d6abd8f5b01c96448a9d8aac8001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149616
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8361cef32d54d2dec32e22c35c6d77ca792ae90a]

        Fix typos
        
        Change-Id: Ib2c8055cc3caae5bab476609f8097046f1981f11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149536
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-26  Mike Kaganski  <mike.kaganski@collabora.com>  [b6dc6712aef820c2d296101961b163d665633d9a]

        Simplify FbCreateStmtParser::compose
        
        Change-Id: I7b593cdfc4ee32897314d95d71c9dcecc8bb9a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149614
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-26  Khaled Hosny  <khaled@aliftype.com>  [ced4a9221329b88484f90ab6d00d797f024585bb]

        tdf#133089: Use proper Unicode code points for bullet style names
        
        The names introduced in:
        
        commit 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c
        Date:   Tue Apr 2 08:30:17 2019 +0100
        
            tdf#124471 Change bullet styles names in Style section of Sidebar
        
        Use Private Use Area code points from OpenSymbol font for the bullets,
        but the code in sw/source/core/doc/DocumentStylePoolManager.cxx uses
        proper non-PUA code points. PUA is problematic because they are
        “private” as in Unicode does not define how they are interpret, so they
        are font-specific and many systems will not do font fallback for them
        because of this.
        
        The names now use the non-PUA code points.
        
        Change-Id: I462c054cff1ffbdfe66ad8d8172901b23fb4810c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149588
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-25  Caolán McNamara  <caolanm@redhat.com>  [67bb7f71b785d3d831ffaa47262b6cbd84e71c42]

        ofz#57134 Timeout
        
        Change-Id: I81cded1dc765d4939a03d46f7df293dfebddcfbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-25  Caolán McNamara  <caolanm@redhat.com>  [c76c805472ff07695d1b1de5e5ed567162c5f227]

        ofz#57444 Integer-overflow
        
        Change-Id: I8e18854379c6ad71ebe316d60fbf586cbdc240ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149584
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [27b98e9e3b3d21fded40df1912292f381fae4ab0]

        loplugin:stringadd in registry..sal
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: I1658b960d44780f7d9c447246b1178cb70be5e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-25  Caolán McNamara  <caolanm@redhat.com>  [5607e88d5f2f2eb7a6b0c9c329728589761c3431]

        crashtesting: iterator range not partitioned by predicate
        
        i.e.
        
        Error: elements in iterator range [first, last) are not partitioned by the
        predicate __comp and value __val.
        
        with backtrace:
        
         #17 0x00007fa394097dd7 in std::upper_bound<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> > const*, std::__cxx1998::vector<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> >, std::allocator<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> > > > >, std::__debug::vector<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> >, std::allocator<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> > > >, std::random_access_iterator_tag>, std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> >, o3tl::less_uniqueptr_to<SetGetExpField> > (__first=std::unique_ptr<SetGetExpField> = {get() = 0x5623f9fa1ef0}, __last=std::unique_ptr<SetGetExpField> = {get() = 0x6666666666666666}, __val=std::unique_ptr<SetGetExpField> = {...}, __comp=...) at /usr/include/c++/10/bits/stl_algo.h:2125
                 __PRETTY_FUNCTION__ = "_FIter std::upper_bound(_FIter, _FIter, const _Tp&, _Compare) [with _FIter = __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<const std::unique_ptr<SetGetExpField>*, std::__cxx1998::vector<std"...
         #18 0x00007fa394089f6f in o3tl::sorted_vector<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> >, o3tl::less_uniqueptr_to<SetGetExpField>, o3tl::find_unique, true>::upper_bound (x=std::unique_ptr<SetGetExpField> = {...}, this=0x5623f8889220) at /home/buildslave/source/libo-core/include/o3tl/sorted_vector.hxx:202
         No locals.
         #19 o3tl::sorted_vector<std::unique_ptr<SetGetExpField, std::default_delete<SetGetExpField> >, o3tl::less_uniqueptr_to<SetGetExpField>, o3tl::find_unique, false>::upper_bound (x=0x7ffcf58ff6c8, this=0x5623f8889220) at /home/buildslave/source/libo-core/include/o3tl/sorted_vector.hxx:341
                 tmp = std::unique_ptr<SetGetExpField> = {get() = 0x7ffcf58ff8a0}
                 ret = Python Exception <class 'gdb.error'> value has been optimized out:
        
                 tmp = std::unique_ptr<SetGetExpField> = {get() = <optimized out>}
                 ret = Python Exception <class 'gdb.error'> value has been optimized out:
        
         #20 sw::DocumentFieldsManager::FieldsToCalc (this=this@entry=0x5623f7c46a40, rCalc=..., rToThisField=..., pLayout=pLayout@entry=0x5623f9ef5450) at /home/buildslave/source/libo-core/sw/source/core/doc/DocumentFieldsManager.cxx:1535
                 itLast = invalid iterator
                 pMgr = 0x5623f88b6d30
         #21 0x00007fa39408ba53 in sw::DocumentFieldsManager::UpdateTableFields (this=0x5623f7c46a40, pHt=0x0) at /usr/include/c++/10/optional:268
        
        from documents
        
        forums/docx/forum-mso-en-8069.docx
        forums/docx/forum-mso-en-8072.docx
        
        where the problem seems to begin with:
        
        commit 9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749
        Date:   Tue Apr 5 18:27:35 2022 +0200
        
            sw: fix expansion of SetGetExpField in headers with split table rows
        
            The problem is that a get field in a header on page N may calculate and
            show values that do not take into account a set field on page N-1.
        
        and in DocumentFieldsManager::UpdateTableFields for these documents I
        see if( pTableNd->GetIndex() < m_rDoc.GetNodes().GetEndOfExtras().GetIndex() )
        is false, and then FindNeighbourFrameForNode finds nothing, so a page
        number of 0 is used as fallback
        
        but the sort isn't consistent on comparing such a page 0 element with
        entries with a valid page number, it has to have some sort of ordering
        one way or the other.
        
        Here, try sorting entries with "invalid" pages to the end.
        
        alternatively in DocumentFieldsManager::UpdateTableFields maybe move
        
        Point aPt;      // return the first frame of the layout - Tab.Headline!!
        std::pair<Point, bool> const tmp(aPt, true);
        pFrame = rTextNd.getLayoutFrame(pLayout, nullptr, &tmp);
        
        before
        
        if( pTableNd->GetIndex() < m_rDoc.GetNodes().GetEndOfExtras().GetIndex() )
        
        which works to give it a non 0 page number in this case
        
        Change-Id: I8cc5a93c4e968f212473b46382650fb30950fd8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149551
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-25  Mike Kaganski  <mike.kaganski@collabora.com>  [71d4049dd0f37cbc23180d11f6bb65de4a59155d]

        Simplify DbgOutItem
        
        Use SfxPoolItem::StaticWhichCast instead of static_casts;
        have type-specific append overloads for the different item
        types to remove duplication and differentiate output for
        similar but distinct items, like EE_CHAR_LANGUAGE/CJK/CTL;
        and drop numeric type casts when calling OString::number.
        
        Change-Id: Ibce1f77f5cfd0eae02e31a6eac83dd9508bd5e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149577
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ce9c446def76a4f5f29d3777afaed2594942d447]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7062dbc3016bf22b8294a7d6998e0441523f1895
          - tdf#154364 (part) refactor "related topics" for swriter
            
            Change-Id: I49a7c8b7b22ed041d48949e63103ef6cd6aa8a23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149557
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-25  Caolán McNamara  <caolanm@redhat.com>  [873ec89d20f7a6a8d6d9003d159eb68053c626ff]

        Related: tdf#153628 too many "Activate" calls with gtk
        
        for container_focus_changed (as documented) we only want notifications
        for focus entering a child of the container and focus lost to some
        widget not in the container, not movement within the container
        
        has-toplevel-focus is sufficient for this for GtkWindow (GtkDialog) and
        we should omit the GtkContainer set-focus-child callback when using the
        GtkWindow has-toplevel-focus
        
        Change-Id: Id5e86b8035fd578b61c8869b91e6097b015ec411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [5d86cc81fef7d538440c630a503a5d94c6a3be4c]

        tdf#38948 Save solver settings to file
        
        This patch implements the mechanism to save solver settings in LO Calc as well as export/import them from XLSX files.
        
        In MS Excel solver settings are saved as hidden named ranges, so in this patch I used the same strategy to save solver settings in Calc, i.e. by creating named ranges to store the solver settings using the same terminology used in Excel.
        
        With this we gain the ability to save solver settings by tab, as well as export/import since we already have "named ranges/expressions" import/export implemented in LO.
        
        Change-Id: Id41bca261dc3cd8e6888643f0ed6a97b26097876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148112
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9a762f9ea38f7d8fa527a74af13579555e0fa61e]

        Fix typo
        
        Change-Id: I799bfd30406025dfc90bba7f941e14622ddfacb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149555
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-25  Jim Raykowski  <raykowj@gmail.com>  [48b7cf3182cc8fb0b728860f9cbb489390074101]

        tdf#154294 Fix customize notebook bar regression
        
        caused by commit e79741488cc740f49ebd4426c40b45e7139ff663
        
        Change-Id: I04fe66124af831c73834b7f695458e1667198ddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149470
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a0c5b782001fc398740b46f2adc9e07055505d6]

        loplugin:stringadd in editeng..framework
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-25  Noel Grandin  <noelgrandin@gmail.com>  [f2b027d5cdaf0e88d1fe47c4d89ef57c03b1f9b8]

        no need to call lock() here
        
        notifyEach was changed to lock the mutex before returning.
        
        Change-Id: I0dc0e11e51e28890e98035cf8356846f9b49c436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d638a512ac19fa68f7760ff110469337f061f481]

        loplugin:stringadd in d*
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: I625a0adf89f54ea25f0377a266c37acf9a37d723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149550
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-24  Justin Luth  <justin.luth@collabora.com>  [4ca4282517d02592966576fc642048b3d5ae5532]

        related tdf#76022 sw CalcFlyOffset: no ConsiderFly if THROUGH wrap
        
        A fly that has text wrap through it does not need to be considered
        for table offsets.
        
        Change-Id: I1b1e58bca3f59d8789581f978f15355c2d4d7ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149465
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-24  Caolán McNamara  <caolanm@redhat.com>  [45da2754222d1fd6ffb02636b8568b4ac6472979]

        tdf#151722 restore use of localized font name
        
        basically disabled back with:
        
        commit cc93f06f93eeaaee5811588d90929ebc72bf9724
        Date:   Fri Apr 23 12:28:26 2010 +0200
        
            #i111108# do not prefer fontconfig familyname because of i79878
        
        to avoid stuff like "DejaVu Condensed" getting reported as "DejaVu" with
        a "Condensed" style.
        
        Rather than reopen that problem, just tweak analyzeSfntFamilyName to
        use the UI lang instead of the system lang as the preferred lang.
        
        Change-Id: I41f128d1a21397ff7880f34985c1553b890b4747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-24  Caolán McNamara  <caolanm@redhat.com>  [2f8b40487cb02287f02ec93acb42f1442c9b4590]

        ofz#57376 Fuzzing build failure
        
        Change-Id: I03624956bebc7c6ce435482bc7cc5fc8b3fc31cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-24  Caolán McNamara  <caolanm@redhat.com>  [eba27d85c2c47ba8880ff257cddfe148ca987828]

        ofz#57232 Integer-overflow
        
        Change-Id: I352d66bf6926a1d839de538dd02d1f2f7c355da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149461
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-24  Michael Stahl  <michael.stahl@allotropia.de>  [48d5d19716b941a67492989ea30fb76f65696841]

        sw: fix crashtesting assert on ooo55147-1.doc
        
        frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `!isPDFTaggingEnabled || oTaggedParagraph || rRect.GetIntersection(getFrameArea()) != getFrameArea()' failed.
        
        This happens because the SwNumberPortion is outside of the
        SwTextFrame 16's area so it is not painted at all (table cell clipping).
        
        The first-line indent is incorrect 1233 instead of 2084
        because in SwTextMargin::CtorInitTextMargin() the mnLeft is incorrect
        2084 instead of 2935 because it erroneously took the branch to set
        mnLeft = m_pFrame->getFramePrintArea().Left() + m_pFrame->getFrameArea().Left()
        because the nLMWithNum check wasn't adapted to the change of including
        the text-left-margin in it.
        
        (regression from commit 92280ad0c65a3d1b5aa8ac77c87ec6a964389a01)
        
        Change-Id: Ic7cd2b272a79e70cb5e0313bb6bcf1e909c3a68a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149538
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4ec75d22eb916e3809e9e92f77fd25e33f6b21ee]

        tdf#153499  Add "For Selected Entry" label
        
           add frame to checkboxes under "For Selected Entry"
           add grid for navigation buttons
           add typographical quotes to extended tips
           add missing colons to three "Phonetic reading" labels
        
        Change-Id: Id630febb01165e4a0faf1a228e436457867748da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148695
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-24  Mike Kaganski  <mike.kaganski@collabora.com>  [2a145d8667196838bd5e1bf635234fce564faea6]

        Introduce query() and queryThrow() to css::uno::Any
        
        Similar to commit f3ffdc1a5fe965016550f20ada405ef638bf5f75
        (Introduce non-static query() and queryThrow() to css::uno::Reference,
        2023-03-23), this adds a syntactic sugar for css::uno::Reference ctors:
        
          css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(anAny, css::uno::UNO_QUERY);
        
        would become
        
          auto xSomeInterface(anAny.query<css::SomeNamespace::SomeInterface>());
        
        and
        
          css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(anAny, css::uno::UNO_QUERY_THROW);
        
        would become
        
          auto xSomeInterface(anAny.queryThrow<css::SomeNamespace::SomeInterface>());
        
        Change-Id: I06f8d97fe200a7dd03ecc965a431eb54b10a3c91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149549
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfcf76b67935bb91d7417e8be60ec2a6285652de]

        CppunitTest_sw_uiwriter3: move failing test to another file
        
        In order to see wether this test keeps failing in the new file
        or it's affected by another test
        
        Change-Id: I73ef0287a81d0ea8c2b26f466cd0d623a62933c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149543
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [be5b1b42c8b66c6614b6cc307112e02ac0f082d1]

        add 6px to Skia children options
        
        Change-Id: Ic7d3a63516aae263aaffec9fba9d9673469bede4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149445
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-24  Justin Luth  <justin.luth@collabora.com>  [afbe948d4c47391092c8fcf4130bd7501c3d5062]

        tdf#115625 tdf#76022 sw table: CalcFlyOffset: get correct surround for textbox
        
        The function thought it was dealing with a wrap-through shape,
        but actually it is wrap parallel.
        
        Attempts to syncProperty of RES_SURROUND meet with instant disaster,
        and likely this emulation works better if the doubled-up shape
        only has one wrap anyway.
        
        There is a helper function for this after all,
        so that highly suggests workarounds are necessary
        instead of just syncing the wrap property.
        
        There were two existing unit tests identified:
        -tdf123163-1.docx (doesn't even open in MS Word 2010/2003)
        -testCustomShapePresetExport.odt (on round-trip)
            -no differences noticed.
        
        Change-Id: I7b0828ce6406fa9cfb1debb68040ea02e8d6fe45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149463
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ae4e5e38b5ec99123ef478143501a9b0a3650171]

        Fix typo
        
        Change-Id: I8106dc197585b823b52d675698533e8a5167819b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149537
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [8bc0c3013089b291bd6c4cb65f944db64373dcb5]

        CppunitTest_sw_rtfexport: split in two
        
        it already has 109 tests
        
        Change-Id: I1e7adf3fa9c1cdb22fb1402306c2f9478d94038c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149546
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-24  Mike Kaganski  <mike.kaganski@collabora.com>  [7eedd76d93ef04d11ae2e1bfb1e7d264aab88f40]

        tdf#154360: use TOC(N) styles in DOCX as the source of ToC tab stop position
        
        Change-Id: Iab8001f8be8a8af437e8898079d55ff57dd6fa3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149494
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9469044db420f280bf60765e0d94bc7d94e6641e]

        update credits
        
        Change-Id: Iea1190aa7e0b9d81a8cf73ebbafd318e73fca757

2023-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [637cceeefba0b0e2e09ac734bb0327364e8ddd25]

        loplugin:stringadd in c*
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4d90e2696dd4358b3d02bbbae90160c92d36263f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed90b5c51e0cda59e30995bbfb26d9ea69123fe8
          - tdf#154364 (part) refactor "related topics" for swriter/guide/
            
            Change-Id: I16d60d69f8ab0e5c79079ad54ad58752673082c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149544
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [764f99dcac7a3e739762465bb2703b8f39252865]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cb08818a1cc6b2ea566316b7904dc77749028e1
          - Fix bad link for SUMIF
            
            Change-Id: I8f7bfe2a4427c5465d8bd428fd58510cf90cca57
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149473
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b6d0be98f5bef19d20f1ce65ef86e82285f55c9a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b91921b052201ce082d96fa3d9c8d85170808c5
          - Fix menu path for color bar in Impress
            
            +  PLus refactoring
            
            Change-Id: I4c6fe7d906fb63fa1a2b293ed7f7a161e9548634
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149471
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-24  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [722d30c1d84eee5ab0a452b1f38d342f1d0b9011]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 47a4762f1c5c7f208beaada82f71995ea084d923
          - fix dead link to Modify or Insert Layer
            
            Change-Id: Ib708c5314136143dc6c3b43e1e906b4d7c6d66ed
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149516
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [153055f27ba1ca1aca8bebba2b6836e52ac801a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 742aa91199f41ef96f1b47bbc163b7c3bb6e2a9d
          - tdf#154335 Deprecate layer_new.xhp in favour of insert_layer.xhp
            
            + refactoring for XML simplification
            + #2 replace layer_new by insert_layer
            
            Change-Id: I12e7bac9da6652d5b3d98e8a4cee0eb40aa9c627
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149474
            Tested-by: Jenkins
            Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [b09df066497fecc66b51af9094914e46e7a87176]

        tdf#149485: Revert "tdf#142450 add code to store showing whitespace"
        
        This reverts commit 5b07acbf3345918f450fccf7ee243ad5bcb3fd67.
        
        The reverted commit claims that
        "This option is stored at the document level like the other
        layout options."
        which is not true. The option is saved in the user profile,
        which makes other documents to look wrong.
        Reverting for now until it's implemented at document level
        as the commit suggests
        
        Change-Id: I2ae0daeb410090949f1b6cfc8245b711fe518216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149541
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fba19e93cca9a7cdfa1e4ac92291cd0b7f06d715]

        Fix typo
        
        Change-Id: I4cc8dbd5a315844f858bf60e3b5b949c4adb1f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149535
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-24  Michael Stahl  <michael.stahl@allotropia.de>  [d367afff67d166d292f461fccc6075cbf0997419]

        sw: fix crashtesting assert on ooo90040-2.doc
        
        itrpaint.cxx:421: void SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed
        
        because the first portion is a SwKernPortion due to some text grid.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I95b87871b7db3c7ced223b477b9f7522c1622d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149469
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-24  Michael Stahl  <michael.stahl@allotropia.de>  [1249706aeaaf60ccafa3675ca203de09f26aebc8]

        drawinglayer: remove obsolete comment
        
        The code is now in vcl/source/gdi/formpdfexport.cxx
        
        Change-Id: I07ca1d87eedadc9778e08a491a77adc88f393586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149468
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-24  Caolán McNamara  <caolanm@redhat.com>  [f2033b6623e13ad70f6648545571594a8cd848c7]

        ofz#57146 Integer-overflow
        
        Change-Id: Ic5a86254b5d969c8242c124fa0515e4f1537114f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c76fb95d45f0240ee00f831a88e8a52bf3faacbc]

        loplugin:stringadd in b*
        
        after my patch to merge the bufferadd loplugin into stringadd
        
        Change-Id: Ieb9b4f5154173738e26b429b55c7a3ea38733553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-24  Miklos Vajna  <vmiklos@collabora.com>  [3c3a47e911a7ee4d199fe96bd3003c7d9afa9deb]

        sw floattable: fix up/down cursor travel at fly boundary
        
        Pressing the "down" key in the middle of the last line of the A1 cell on
        page 1 went to the end of the paragraph instead of going to the A2 cell
        on page 2.
        
        The problem was that fly frames don't have a "next" pointer to the
        follow fly frame, so the cursor travel code thought there is no follow
        frame to jump to.
        
        Fix the problem similar to how explicitly chained frames do this in
        lcl_FindLayoutFrame().
        
        While at it, also fix the the "up" direction.
        
        Change-Id: I8dd0c2d011300520b126abf3ca8d17722ab5ff92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149476
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-24  Sarper Akdemir  <sarper.akdemir@collabora.com>  [fa5c01e67775c01b302fc08033a0eb78d3b87489]

        related tdf#102261: xmloff: ODF import/export for ParaTabStopDefaultDistance
        
        Introduces ODF import/export for ParaTabStopDefaultDistance
        (loext:tab-stop-distance).
        
        Also adds a unit test that covers import & export of the
        property.
        
        Change-Id: I8a69a9e2b73e8f1172f92dc35fada901f4b887f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148540
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-24  Miklos Vajna  <vmiklos@collabora.com>  [c586d7f1f8370c9e6334c6f38b5ed883212945c7]

        sw layout xml dump: extract SwFooterFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about footers.
        
        Change-Id: I5fe349b0a9bf11f84649d6f274c2620b7563174d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149472
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-24  Mike Kaganski  <mike.kaganski@collabora.com>  [53c39db4cfbeec29c0972df8ade4b12a23074f10]

        These must be const
        
        Change-Id: I6af7a8933662dc5b8585c14d1cb66e2aad883252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6e70d50db34afc9242b45172f456bb8221c4fa00]

        Delete temporary variable
        
        Change-Id: I5d0fc2a4b078e49be684b4a9b8a27f6059d9e5c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149475
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cae0daff1dd8bd60208892c792948c0cd2b0eeec]

        tdf#142978 Add shortcut to a11y check deck
        
        Change-Id: I3d356905fe8548dbf6a72169f72f1d4b741d63c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149454
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [61d961f3bc0d127f88d7d35eaf5eca4e34799731]

        tdf#142978 Remove a11y check dialog
        
        in favor of sidebar deck
        
        Change-Id: I2daf34edbe71341ebc44ca9b966c97f8e494d583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149433
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [53fc5fa0fed077b7d11e39b710280f0a84b631ff]

        tdf#142978 Show a11y sidebar when finding issues on PDF export
        
        Change-Id: I5234aca76153e1a781b7df1d3fbea8bb856af921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149430
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [e713d9be05b788d5da0fff59c6070cca95b73b37]

        cid#1524497 Uninitialized pointer field
        
        Change-Id: Ic3f347b9a588bda459411f917be47cbfa442d3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149459
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [68fe430723368bdb0be91b7eef0bc3e3d294caa5]

        rename mnAnimCount to gAnimationRendererCount
        
        to better distinguish it from nAnimCount
        
        Change-Id: I2fc5912964e8d48a991dfe0d755e5ce27d9e0905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [f70314c8d438efe6d26460cfbeb2e7fd955346cd]

        crashreporting: BitmapEx::operator=(BitmapEx const &) crashes
        
        e.g.
        https://crashreport.libreoffice.org/stats/crash_details/b68d5267-16b1-4ee9-bd42-bdcecdb7043c
        
        this went wrong with:
        
        commit 91bc1e6a8c92a7c895f0ba9dcad9ac4d35f3f791
        Date:   Sat Jun 25 10:21:17 2022 +1000
        
            vcl: extract function Animation::RenderNextFrameInAllRenderers()
        
            Change-Id: Iaccf12b251ffe06e24813c48ba3a169d0eaaa61c
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76416
        
        which substituted mnAnimCount with nAnimCount which is a subtle one char
        difference, but mnAnimCount is a different thing entirely than the (then
        local variable) nAnimCount. mnAnimCount is the count of animations
        active, not the number of animation frames in a specific animation.
        
        orig code was const size_t nAnimCount = maFrames.size();
        so replace mnAnimCount here with maFrames.size() to get back to the
        original logic
        
        Change-Id: I11d1797eb0b9ef61addb3769d12d8364872071df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149457
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [07fa6e041f0d6146fc34ade4dcea1be8d69f80e2]

        CppunitTest_sc_uicalc: split in two
        
        It already has 99 tests
        
        Change-Id: I672de980ce170b83ba84252170878731e1ce02f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-23  Michael Weghorn  <m.weghorn@posteo.de>  [d7f78d469870717cfc356ce12413031b9d86079b]

        tdf#135769 a11y: Set a11y name and tooltip for buttons in hyphenation dialog
        
        Set accessible name and tooltip "Left" and "Right" for the
        left and right arrow buttons, as suggested in tdf#135769 comment 6.
        
        Change-Id: I233d7f9028b2336130475ce50a4161df0629a835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149355
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-23  Michael Weghorn  <m.weghorn@posteo.de>  [db863e0aabfb9008bf7ca226e7da7c186d89e5ea]

        Resave cui/uiconfig/ui/hyphenate.ui with glade 3.40.0
        
        .. before doing any changes for tdf#135769
        
        Change-Id: If9ae28a979c4d4c12120711b90a9361b2e90b6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149421
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-23  Noel Grandin  <noelgrandin@gmail.com>  [e7dbef922a2fc73469f12c520bcc1af54fe038fb]

        rtl::Static to thread-safe-static
        
        Change-Id: Ife02e6d2be3ebfbb08522ab0183ef4aa31a99e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [462ebbd10bd537f42104fe991a0aeebcd563f178]

        MCGR: Speedup Gradient Paint for VCLPixelProcessor
        
        To do this, I re-organized FillGradientPrimitive2D and
        how it creates it's decompose. This provides the needed
        tooling to also do a more direct rendering in primitive
        processors if needed.
        
        The decompose no longer collects the matrices & colors
        as a 1st step in a helper data struecture (so I removed
        B2DHomMatrixAndBColor). It now uses a lambda function
        callback that hands over the matrix & color for each
        created step, so you can process it directly, in this
        case to create the needed primitives.
        
        NOTE: The decompositions are both tested. There was
        createNonOverlappingFill, but also createOverlappingFill
        that I am not sure is still used - and if in re-creating
        an old, strange XOR-using gradient paint mechanism in
        old metafiles (encapsulated with gradient info anyways),
        but I converted that and made sure it works.
        To do so I forced it to be used in paint. This is not
        really usable in paint since we need to paint using AA
        (else we would get staircase effects, esp. in new 'hard'
        color changes in multi-color gradients) and - as should
        be known - same edges painted in AA do *not* add up to
        full opacity, but leave behind awful 'jaggies' (e.g.
        opacity 0.5 and 0.5 create 0.75 and *not* 1.0). Still
        important to have the working geometry creation for this
        case.
        
        This already makes the decompose faster, but the main
        purpose is to use it as tooling for painting in own
        primitive renderers.
        
        Thus processFillGradientPrimitive2D now uses that
        instead of using the decomposition by default.
        This avoids one level of primitive creation, use
        that new FillGradientPrimitive2D tooling to directly
        create needed geoemtry & color for getting better
        performance (to partially compensate for potentially
        more expensive multi color gradients). It then paints
        directly using OutputDevice calls.
        
        NOTE: This can also be used in SDPRs as a 1st step
        to just directly and rapidly render filled single-
        color polygons, but of course there an implementation
        using the back-transformations (which are also
        adapted for MCGRs aleady and work) will be superior.
        
        Change-Id: I5079f76d6d8fe86007a098614c276447f2bfebce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149456
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-23  Noel Grandin  <noelgrandin@gmail.com>  [7ecc9925f3b0d1cea4ee7201473dd6fbbb95c271]

        mutex in OOXMLFactory_* is unused
        
        Change-Id: I55cf235919df3c19019ca5d280f10f6720cc4f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-23  Szymon Kłos  <szymon.klos@collabora.com>  [676602a1a4e53e88d9f4664579497d534f6ae9c2]

        jsdialog: enable standard filter dialog
        
        Change-Id: Id29ec01a9ffefeb7da0c4e61011fff966d9cf3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148787
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149364
        Tested-by: Jenkins

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [b2beab144096c1f4f33ce0d9cacedbb80cc83594]

        tdf#154322 select the first entry of the current page by default
        
        rather than default to nothing selected, if we switch pages and then
        back to page 1 this will be selected anyway, so start off that way
        
        Change-Id: Ia684a5e44b12c984df3920f18b34c99693a2702c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149426
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [0cdd0a6603626d7da9c331771c77b8a719f0592a]

        Resolves: tdf#154322 if entries are disabled while menu is active, update it
        
        Change-Id: Id5cad5f2f4ac21db8675de16f1bc0ceeff39fe6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149424
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3d1fbd81988c11ac7de54bbe718073422f5db71f]

        tdf#142978 Improve a11y check sidebar panel
        
        * Set minimum size
        * Wrap long texts
        
        Change-Id: I4c23ebd47d26fe628187143eeda43efe467b911a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149429
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [b80e0165affb81bcc6bf343b54c17b9a9b4c0d0e]

        Upgrade Harfbuzz to 7.1.0
        
        * Fixes CVE-2023-25193.
        * if Harfbuzz >= 7.0.0, uses hb_font_draw_glyph()
          instead of hb_font_get_glyph_shape().
        * Update URL in README.
        
        Change-Id: Id234c2b459c40ddac340731b44889b104e03a1e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148743
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-03-23  Arvind K  <khandelwalarvind26@gmail.com>  [e466b4a92f5f7c49c6aff01af994d59d13633529]

        tdf#114441 Convert sal_uLong to better integer types
        
        filter/ -> nFilePos in struct SvxMSDffBLIPInfo is assigned nBLIPPos
        which is defined as sal_uInt32.
        
        Change-Id: If2815449d12b17e8caadaff0324371c69a5a5ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148291
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f3ffdc1a5fe965016550f20ada405ef638bf5f75]

        Introduce non-static query() and queryThrow() to css::uno::Reference
        
        As a syntactic sugar for the respective ctors:
        
          css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(xAnotherInterface, css::uno::UNO_QUERY);
        
        would become
        
          auto xSomeInterface(xAnotherInterface.query<css::SomeNamespace::SomeInterface>());
        
        and
        
          css::uno::Reference<css::SomeNamespace::SomeInterface> xSomeInterface(xAnotherInterface, css::uno::UNO_QUERY_THROW);
        
        would become
        
          auto xSomeInterface(xAnotherInterface.queryThrow<css::SomeNamespace::SomeInterface>());
        
        Change-Id: Ic42da364562b702cd468cc708fbda70394c4f2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149368
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-23  Stephan Bergmann  <sbergman@redhat.com>  [fe3234718539ef65e384f1393cfd859cb81b8233]

        loplugin:stringview: Constructing O[U]String from O[U]StringLiteral is cheap
        
        ...so don't warn about those, as requested in the comment at
        <https://gerrit.libreoffice.org/c/core/+/149254/8#message-6430dc5397ab7b60bf4e78e6856b44ab6cd72c97>
        "tdf#154319: fix TOC field codes parsing"
        
        Change-Id: I25989cd4b42bc3fe9062a8a0d6896d32a18635d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149417
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-23  Bayram Çiçek  <bayram.cicek@libreoffice.org>  [71311f88f7d83d8669576a98d300780d3d8bd02a]

        tdf#146150: Use dispatch command in framectr.cxx
        
        - "slot:5503" changed to ".uno:CloseDoc"
        
        Change-Id: Ia2748cfe13191a9b93fd76f9f26fe6fadbd2d0b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148693
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-23  Miklos Vajna  <vmiklos@collabora.com>  [12a9009a1c19ee26c65fb44fc90f3432c88ab6a5]

        sw floattable: fix bad position of follow fly if anchor is positioned late
        
        The bugdoc has a split fly, the master is centered horizontally. That
        means the follow should be centered as well, but it was aligned to the
        left.
        
        The problem is that the follow fly was positioned when the anchor was
        not positioned at all (its top left was 0,0) and then there was no
        invalidation of the fly position to recalc it later when the anchor got
        positioned. The existing InvalidatePos() call is not enough because once
        a fly is formatted, its position gets locked and only
        unlockPositionOfObjects() at the end of the layout process will unlock
        it.
        
        Fix the problem similar to what lcl_InvalidateLowerObjs() for SwTabFrame
        does: if we know that the position of the anchor changed, then unlock
        the position before invalidating it.
        
        If this leads to unwanted re-positioning of flys, it would be perhaps
        possible to do this when the anchor position changes from 0,0 to a valid
        position, but for now just do this all time the anchor position changes.
        
        Change-Id: I811bdfa1eb6705ff3de6ec77111e9500617e8bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149367
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-23  Maxim Monastirsky  <momonasmon@gmail.com>  [b1393fd5ce847f40abab49f57c67929bb0087fae]

        sc drawstyles: ODF import and export
        
        Change-Id: Id92088a7d70c550682fe707d81e94157edc7caa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149330
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-23  Caolán McNamara  <caolanm@redhat.com>  [5d88965e7cca19205f5ef5ebd10ae8a8459ecb49]

        instdir/share/registry/res/registry_de.xcd is effectively empty
        
        I find with GNU Make 4.3 and find 4.9.0 I get a
        workdir/CustomTarget/postprocess/registry/registry_de.list with no
        entries, though my libreoffice-7.3 build has a populated one and this
        makefile is the same as in that version.
        
        Change-Id: I45ffb381c4c962cd80c3e07e7539d993f86101d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-23  Miklos Vajna  <vmiklos@collabora.com>  [457af772f52e447ef4d2dd22c1eb4624e50e6df7]

        sw: fix undo comment of FN_UPDATE_FIELD
        
        It's an update and the name was not set. One has to dispatch
        .uno:UpdateField to see this in action, which does something if the
        cursor is inside an exiting reference mark.
        
        Change-Id: I1701c7c3ab0a395c2346d41fb517d13c9d9c5a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149350
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-23  Szymon Kłos  <szymon.klos@collabora.com>  [ae71f11d2861f7c49f9f75435f85c01907a6029e]

        jsdialog: enable function wizard
        
        Change-Id: I534556e87cda3239bff51f1e7d83355922f8af7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148245
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149327
        Tested-by: Jenkins

2023-03-23  Szymon Kłos  <szymon.klos@collabora.com>  [83bde658dd538b8cb66df9bf0ce1e1c959052f59]

        jsdialog: enable data validation dialog
        
        Change-Id: Ide679ada03dff5e62432d77b8c804d667bf2435b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148781
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149219

2023-03-23  Szymon Kłos  <szymon.klos@collabora.com>  [584c9914fc4da76839ecdb3efed36381bee21954]

        jsdialog: render full edit engine content
        
        Change-Id: I43c2deb75619956b95cdc1d2693a7540d5c8f894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148888
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149326
        Tested-by: Jenkins

2023-03-23  Jani Saranpää  <jani.saranpaa@gmail.com>  [6dfa9c7c0db91a71f3787226636864161d5367ca]

        tdf#42982 Improve UNO API error reporting
        
        Change-Id: If8c8e96c2d8365f10a191868e76e75d6fc7c5db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149357
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-23  Noel Grandin  <noelgrandin@gmail.com>  [b2db6b7586b4e7b7e2c175dbc93fd0ace1cddd97]

        rtl::Static-> thread-safe-static in chart2
        
        Change-Id: Ie1379a1d40a6d65b28fd94ed114853e399fea5f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-23  Noel Grandin  <noelgrandin@gmail.com>  [1131b090ed9b68300c0b08366e6cb7d7fee453e5]

        rtl::Static-> thread-safe-static in chart2
        
        Change-Id: I5bd595d5251cd92904750d6e6830f1d95f41b177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-23  Noel Grandin  <noelgrandin@gmail.com>  [4e8f36fcd43c6ccc9d07211ebc8e7ee53d2e33d1]

        rtl::Static-> thread-safe-static in chart2
        
        Change-Id: Ie629e4e2d4e3a56894bc964b8bb50dac5823cf4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [edb2c2a9f128273486163e22f7a44117ac47ae84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35dca7d7e802b33da0f8c903f554f591eb239f03
          - Fix typo
            
            Change-Id: I53670595539d0c34ef6ce21f463cc19cd9c0f5ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149352
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-03-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [697c1ef9fe9c5065109e798df0eb7d2acfe0153f]

        Fix typo
        
        Change-Id: I48bca01a495c2df86b3868a420b11ce4ab860bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149354
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-23  Mike Kaganski  <mike.kaganski@collabora.com>  [76777c82fa4bb5080c135e2241c3f7122dcbb298]

        tdf#154319: fix TOC field codes parsing
        
        Change-Id: I734697f52df14ca5b316481df8a58fef72ab9571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149254
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0d18262789fbe95eafe32bd775a9827ed99685ef]

        oox: import gradient fill to model::FormatScheme
        
        Change-Id: I90bc7cf4239f08efbc7239928c34ccdbec20cb2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147575
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [27f9a9cfa76fa584477e89f13b33720b5edbd570]

        OUString::match -> OUString::startsWith
        
        (which reads better in combination with the following
        OUString::endsWithIgnoreAsciiCase)
        
        Change-Id: Ia80e3d205e5e3b48f9df43757fb267258ba3f8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149353
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [667f5f87dee072f6737ee6b6491ed53b7cf154a7]

        tdf#153664 Export correct Table of Figures paragraph style
        
        Change-Id: I892a0185a94aadd902e55ee9b719f855edbdfc89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149258
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-03-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [9b89ce887836742bb84bf57afa3b536b6c3bb1c1]

        tdf#153659 Import Table of Figures paragraph style correctly
        
        Change-Id: I5a995349c168bfbb5c8933dafa72e06eddb74ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149257
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f59baf135f42f9c281148184b1b1f16e3902442]

        use more concrete type in chart2
        
        Change-Id: If67a4f0fe75554e14c3030c68374607b76d5b840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6da444a9e2b239d8905d6cdb845c7be8d8ce66f]

        use more concrete type in chart2
        
        Change-Id: I33deb726da5a59093b1104696da7c80ce830b7e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5b0bd23ff80f5229371c6e289480b347f168524]

        use more concrete type in chart2
        
        Change-Id: I215bf2a6e2fbd4cdd57fd14c2d34fb11a0d2a862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149334
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c00cd73f15606d4e0fc942ddbb1ab734b83fc8c7]

        use more concrete type in chart2
        
        Change-Id: I92e0cb707b0fdd8e82ba350919294584904f2c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149333
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [88047257087350497009e418850a90f1cd34310a]

        simplify ViewLegendEntry
        
        we never have more than one FormattedString
        
        Change-Id: Id61a2a89a053f49da758a2bb888cef189515458f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [3a4b32c9e1dfc56d9b00e3720834d21c9095f629]

        tdf#153808 Fix numbering preview in dark mode
        
        This patch fixes the color used for numbers and bullets in the preview
        of the Bullets and Numbering dialog in Impress. Currently the
        implementation causes the bullets and numbers to be rendered in white
        over a white background when using dark mode.
        
        The fix uses DOCCOLOR and FONTCOLOR to create the preview, instead of
        FieldColor and FieldTextColor.
        
        Change-Id: Icf41c5be59c67a2d68e3c520744276492e9baa59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147664
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-22  Caolán McNamara  <caolanm@redhat.com>  [936f2e6924e405433770b98f32a615508fd0670d]

        fix crash seen when experimenting with tdf#129547
        
        Change-Id: I0b26a7f683f91d3307856f86c5a437fde1155451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-22  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [2252313a90b6561f2746e05dae99551701550201]

        bridges: drop unnecessary debug message
        
        Change-Id: I4c08ea2e464164351ba66a4c04ef2575e3f5f580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149157
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [c3ec6ac5df2954b24010868f1d40bff242bd1742]

        m_aBootsrapError will always be BE_OK here now
        
        ...since a1faf14f74a62ea76141115538d7d30d90c9eeb6 "rhbz#2171265 Report fatal
        InitApplicationServiceManager failures more reliably"
        
        Change-Id: I36771aeb8d13f08558f323e713de5cbe3972b82e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149329
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [feb8b04a0ee86b0146a17393da220ae188babda8]

        rhbz#2171265 Filter out all non *.rdb files
        
        In that rhbz issue ("Libreoffice cannot start"), it looks like some junk file
        named /usr/lib64/libreoffice/program/services/services.rdb;63ddcd86 caused
        soffice.bin to crash early, without any information (cf.
        a1faf14f74a62ea76141115538d7d30d90c9eeb6 "rhbz#2171265 Report fatal
        InitApplicationServiceManager failures more reliably").  So, following up on
        b8c7548527f5fc14fe8fcbe74a749c7e3c10d385 "ignore backup files in services/
        directory to avoid debugging grief", extend the set of ignored files to anything
        starting with "." or not ending in ".rdb" (in any case).
        
        Change-Id: I154750465d2128b3ff6493f4ab606072dda61503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149328
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8abe0c94e265fbf5fe5b90fd46dd01dec6a8d374]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35a7913f2075a9b73fd2c8d41473adface5711bb
          - tdf#139027 Help information for Calc's INDEX() function
            
            Change-Id: I23b4b923329ba6d2783d4a2f02d9e02d3786f708
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149179
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-22  Patrick Luby  <patrick.luby@collabora.com>  [49f36c83e4bb1c332028bc70606e96ebf31fbd74]

        Partial fix: iOS missing text direction listbox in Format > Page Style > Page
        
        Add the static libraries that are required by the LibreOffice's
        CTL and CJK text layout features to the iOS app add link list.
        
        libnumbertext.a is one of the missing static libraries that are required by the LibreOffice's CTL and CJK text layout features.
        
        The other missing static library (which was in the ios-all-static-libs list but was getting stripped by Xcode) is added back by listing the "lingucomponent_NumberText_get_implementation" C function.
        
        Without these static library changes, enabling CTL or CJK will cause a crash as the "lingucomponent_NumberText_get_implementation" symbol won't be in the binary and that function needs libnumbertext.a.
        
        Reference-to: https://github.com/CollaboraOnline/online/issues/6050
        Change-Id: I21fddbfd29a1d326b509840127bd136c327cd3d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149110
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [53a3d028e6931e4443cfe8cdf18909f6bfd8e2f4]

        use more concrete type in chart2
        
        Change-Id: I568530c1db0add697f7f257a4e5560a3e50919f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f02ec0d8489404966596cb0e949bf969e8e66fa2]

        move hasUnhiddenData inside chart2::DataSeries
        
        Change-Id: Id8a4daf046f2306a52948c7ed434854b25ee7936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4cde4406217dd61e8d803eb38e6f5fac84a1f6d]

        use more concrete type in chart2
        
        Change-Id: I0ed45cf9acd1c9bf702bbe335f8a07b6947fb946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Jaume Pujantell  <jaume.pujantell@collabora.com>  [826b20b049449c9c335ce00c781cdb52e4ee0512]

        Fix wrong layout of textbox in header
        
        In some cases the text box wasn't properly moved afeter it's position
        had been calculated. Also now when the shape and text element are
        brought together in the Z ordering, the one with higher Z moves down.
        
        Change-Id: I0512db4b6466532b5af4e3c091fd65bd0a416381
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149221
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-03-22  Caolán McNamara  <caolanm@redhat.com>  [fc9126c3cb84d6b53c1d6daa10814ae25f863056]

        tdf#154307 remove instead of hide these menu entries
        
        because on kf5 they are getting shown, which suggests a wider more
        generic bug on that variant, but use remove for this specific case
        because that's ok for this usage and works around the problem for now.
        
        Change-Id: Ib2bc316cc33894253a0b6335ae8643d0c8d78794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-22  Szymon Kłos  <szymon.klos@collabora.com>  [0ad9327f3f8d94da1e932fcba23437fb4c126704]

        jsdialog: enable insert special character dialog
        
        Change-Id: I535397ff7c5250989057dd8616ccc7c4eec6afad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148853
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149232
        Tested-by: Jenkins

2023-03-22  Caolán McNamara  <caolanm@redhat.com>  [76e3d55548279d4d50ac97ac70281e86772a37ce]

        cid#1524496 Uninitialized pointer field
        
        Change-Id: I5bdc9557851f1059f7adf310af0375ff02092b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [a1faf14f74a62ea76141115538d7d30d90c9eeb6]

        rhbz#2171265 Report fatal InitApplicationServiceManager failures more reliably
        
        For example, when initialization of the UNO type manager failed, any code run
        between this SetBootstrapError and the HandleBootstrapErrors in Desktop::Main
        which would need the type manager (e.g., to set a css::uno::Any) would have
        caused a crash, so would have failed to print to std::cerr the sought-after
        css::uno::Exception message.  The mis-initialized process would most definitely
        crash sooner or later anyway, so there's no harm in a controlled std::abort()
        here (if that is even reached, and the process doesn't already crash in
        HandleBootstrapErrors, after it has printed the relevant information to
        std::cerr).
        
        Change-Id: Ic5889aedec0908fa4b1e2966eb188508d0f92d26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149323
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [9331d2d333feb911e16f20ce899f2de220bee2f1]

        MCGR: Corrected error with Case16 wrong gradient shortcut
        
        Also simplified using the test cases, these now depend on
        an ENV VAR called MCGR_TEST. Fallback is no test. For
        seeing a multi-color gradient use 1, for Case16 use 16.
        If active, all gradients are replaced with the one active
        for the test, 2D and 3D. This is temporary but also for
        pro build to check for speed there.
        
        Change-Id: I90f3c7e59d9d0a3e070a849af3f9ea1c9e5462a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149316
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [3545c0c0b991e5b9438d890f48dd10c4a60f2090]

        vcl: PDF export: simplify version checks
        
        The constructor converts PDF_A_1 etc versions to the underlying PDF
        versions and a boolean flag, so almost all of the PDFWriterImpl code
        needs to check only the base PDF versions.
        
        Change-Id: I0a74f532f7ed2473acc73eabc8a59eff25396672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149260
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Heiko Tietze  <tietze.heiko@gmail.com>  [1ff8fa39d116c856dd2c0a6809a7f2f100b3439e]

        Related tdf#154182 - Recognize flat open document formats in MRU list
        
        Change-Id: I7e25cf98502db62e80f563af6a80dbf9a7ac8db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148845
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-22  Miklos Vajna  <vmiklos@collabora.com>  [015da04a8f3e1368c6b9668ca22d7e320e1ecae6]

        sw floattable: fix current page number when editing document with a split fly
        
        UITest_writer_tests6's
        tdf124675.tdf124675.test_tdf124675_crash_moving_SwTextFrame_previous_page
        failed in the SW_FORCE_FLY_SPLIT=1 case, since the current page after
        typing was 3, not 2.
        
        It seems this change is wanted, since the total page count increases by
        2, so it's consistent that the current page increases similarly with
        typing. Also, repeating the UITest in Word (after positioning the cursor
        at the top paragraph in the document) also produces page 3 as the
        current page.
        
        Fix the problem by locally enabling split flys for this test and then we
        can assert that we match Word. This requires a new context manager, but
        that set_config() is really similar to other context managers in the
        class that return no value.
        
        The original purpose of the test was to make sure we don't crash,
        anyway.
        
        Change-Id: Id0dfde23a8726c8799950a6e4fdd1d85f135eafc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149315
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [b1851d1afec70402a711e850f27c1c2521a7ba4d]

        Remove unused file
        
        ...that 9111536f1bbaed489ed3ed36315e05d4b3940f5b "Introduce css.reflection.Dump
        singleton" had added by mistake
        
        Change-Id: I15e273c3186312c45b7d435f983f17eb2f93a56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149292
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c888ac311734deaf07cbfe04b87aa7339ed6afb6]

        Fix typo
        
        Change-Id: I65261e7aaccb640eee4100fd53bc7e7e2cb229f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149318
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [74f398bb58510087cc4a11bb2253715771a2c6b2]

        sw: check GetActiveView()
        
        See https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell()
        
        Change-Id: I90ebbff5082f1f9cae7fa3b940cbb9796d6c6dd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149223
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [d41c3c820dad7c78bc57815e0f4a6999d125561d]

        vcl: PDF/UA export: produce UF and Desc for embedded files
        
          7.11 Embedded files
          The file specification dictionary for an embedded file shall contain
          the F and UF keys and should contain the Desc key (ISO 32000-1:2008,
          7.11.3, Table 44.).
        
        Also write Alt text as hex/unicode string, not literal string.
        
        Change-Id: Id83597cc5ea645bd57c110514bafede433aee572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149259
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [e84b310b59825fd572d79def98c3d21566aac603]

        vcl,drawinglayer,svx,sw,sd: PDF/UA export: Annot StructElem for SdrMediaObj
        
        veraPDF complains:
        
          Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 1
          An annotation, excluding annotations of subtype Widget, Popup or
          Link, shall be nested within an Annot tag
        
        This is very similar to Link annotations, that is to say, extremely
        complicated to get it thought the convoluted PDF export code, with
        additional complication that the StructElem is produced by drawinglayer
        and the page annotation by sw.
        
        Put another map into PDFExtOutDevData where sw code puts stuff for the
        SdrObject that drawinglayer can find.
        
        The test had the problem that PDFObjectParser::parse() could not handle:
        
        <</Nums[
        0 [ 6 0 R ]
        1 6 0 R
        ]>>
        
        Fix dropping the "1".
        
        Change-Id: If5bf7c552e26ebb7e631030b8aaecd4281e77acc
        (cherry picked from commit c78e90bd28cc4d6d3bde473535107784b12d9c0d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149008
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7f4b53b1c7c192ecfef35913133239b670070062]

        UpdateTableFields: stronger assertions
        
        - And use {Static,Dynamic}WhichCast where possible
        
        Change-Id: Ie5097d360ddb0a5cd9980392a9106b9586861001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149121
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Juergen Funk  <juergen.funk_ml@cib.de>  [05ea4ac1952c546a81781ac0662747dbe6073616]

        git-hooks: better handling in './g -z' with win-links
        
          and linux-links
        
        This patch improve patch
        9afc6b22e225e8a6ec50c1cbb4d966585d15dbfd git-hooks:
          overwrite the windows-links not with linux-links
        
        The main problem with the previous patch is that
        when an alias is set for git, this alias will not
        map in the Shell script passed, better you
        use a git-symlink.
        
        The other problem was the behavior of cygwin-bash
        and win-git-bash that is not always the same, e.g.
           - winlnk=$(cmd /C ... 2>&1) it hang infinity,
              line 123
           - the 'ln' made not link, it only copy the files
        
        Improving the FOR in ./git-hooks/README, when
        you have the copied files, need a other del command
        
        The patch can not set the windows-links, only output
        the ./git-hooks/README
        But in Win 11 should be possible, it is not needed
        admin-rights for the 'mklink' command
        
        Change-Id: Icecdb96e65fe2bba1270dfad2ac1af5af145925a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148462
        Tested-by: Jenkins
        Reviewed-by: Juergen Funk <juergen.funk_ml@cib.de>

2023-03-22  Justin Luth  <justin.luth@collabora.com>  [d68e428a2ab9f0027ff82d67ae2492d143364586]

        tdf#135581 sw UI: keep image in place when changing anchor
        
        Changing the anchor type should not move an image around.
        
        The only time we have a prosition to fix AFAICS is when
        the anchor changes and the RelationOrient is no longer appropriate.
        In that case we always get a new p*OrientItem.
        If GetPos changed, then that means the user (or earlier algorithm)
        already adjusted for the change. If there is no difference in GetPos
        even though the relation changed, then that is the only time we (likely)
        need to recalculate.
        
        So the typical example requiring an adjustment would be a change
        from "to paragraph" at text position 0 to a "to page" anchor.
        In this case "page" has no relationship to "text margins"
        and thus needs to base the absolute position 0 on page instead of text,
        meaning that the margins would need to be added to the absolute position.
        
        This code is basically unchanged since initial import.
        I have no idea why it could possibly be good to change
        the position when there is no new information given
        (no pHoriOrientItem/pVertOrientItem).
        
        [I checked and "from top" and "from bottom"
         are both == NONE, as well of course as "from left".]
        
        make CppunitTest_sw_uiwriter3 CPPUNIT_TEST_NAME=testTdf135581
        
        Change-Id: Ib89ad9ba26c8826ed43f6d4505a82502b9ad8af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149012
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [089b9e21c7210df3e5ee312a06131ce410989cf7]

        filter: PDF export dialog: always disable ReferenceXObject for PDF/UA
        
          7.20 XObjects
          Reference XObjects, as noted in ISO 32000-1:2008, 8.10.4, shall
          not be used in conforming PDF/UA files.
        
        Change-Id: I62a4b6b76a6cb1d14d4fd39fad90ec0323a481c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149261
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Miklos Vajna  <vmiklos@collabora.com>  [2b7b272e28bf95c4ed85cb118eacf065fb6dca3c]

        sw floattable: limit the unfloat button to non-DOCX files
        
        CppunitTest_sw_uiwriter2's testUnfloatButton and testUnfloating failed
        in the SW_FORCE_FLY_SPLIT=1 case.
        
        The trouble was that it assumed that floating tables from DOCX are
        imported as tables in non-split flys, which is no longer the case.
        
        Fix the problem by limiting the test to ODT and DOC files.
        
        Once the DOC filter is there for SwFormatFlySplit, this can be
        restricted further to ODT files only (or perhaps it should be removed
        completely).
        
        Change-Id: Ie1db9a66c862c196aa3bf5326dfb20c67b9b493a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149291
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-22  Maxim Monastirsky  <momonasmon@gmail.com>  [ca487e3f4c0f97c14bcff3a5372717d47f32ee94]

        sc drawstyles: Add a dialog for style editing
        
        Change-Id: I7e62251024df8f24bd6fe318f5c0262bbd6a1a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149279
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-22  Maxim Monastirsky  <momonasmon@gmail.com>  [debf3e06bc5330b227dc9dd55e49930cb3da522a]

        sc drawstyles: Add a style UNO property to shapes
        
        Change-Id: I5c8eb3c3e182d9efefc385020b97d768e615a20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149278
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-22  adityasingh22  <adityasingh22011997@gmail.com>  [a49019618be881520a454550454c3f2d078d17fa]

        tdf#147132: Simplify usage of StarBASIC::Error()
        
        Change-Id: Iedb499fa58798d40e7193c80c31dc9337a3a356b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148519
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [d54e5915da0778a0087f8b40c92d15d3c21f3de6]

        Demultiplex test code
        
        It is so much easier to work with if a test failure's line number unambiguously
        points at the code's sole execution.  (That is, test code is necessarily non-
        DRY.)
        
        Change-Id: Icb1753928521cdbafb129938559964f238d1dc4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149289
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [fb93cf7e3f70cf711742c5b492d520d9d49c3c5e]

        sd: PDF export: produce annotations for shapes before painting shapes
        
        This is the same order as sw SwEnhancedPDFExportHelper and required to
        connect media shape Annot to its StructElem.
        
        Change-Id: I1d421e5d353261e32b28a0429cd73f156c692260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149060
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ce47be6e5408835fdaeac184f05cc832c12186cd]

        tdf#154318 elementary: Fix 5 Quarters Conditional Formatting Icon Sets
        
        Change-Id: I60d57891d460f795efd7e0151dc434f427251fee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149288
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7a0cf6797bb53d1fec5101a8f7007d2287ae53b0]

        oox: introduce FormatScheme - use in Theme import
        
        Introduces model::FormatScheme as an member of model::Theme, which
        is used in the theme import.
        
        As an first step it imports FillStyleList, but only SolidFill
        and NoFill.
        
        Change-Id: I14a75782ebabcf7ff69b0872752d411183653a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147573
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-22  Stephan Bergmann  <sbergman@redhat.com>  [9111536f1bbaed489ed3ed36315e05d4b3940f5b]

        Introduce css.reflection.Dump singleton
        
        ...and revert e1c6f36d8bcc0799281e3a7e244175f682d97cb2 "Add a to_string()
        function to the code generated for UNO IDL constant groups".  (But keep the
        constants groups the latter had added to cppu/qa/cppumaker/types.idl, and use
        them in the newly added CppunitTest_stoc_dump, for better or worse.)
        
        Change-Id: I56e9eaeb1e45b83a72a25eceef13e719dc6f3a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149281
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2023-03-22  Szymon Kłos  <szymon.klos@collabora.com>  [464a3549ae228bcd70bae8ea519fc781c2cc9e45]

        jsdialog: double click for drawing area
        
        Change-Id: I280158b101f39d107090a2eebb2c06e64591cb94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148852
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149231
        Tested-by: Jenkins

2023-03-22  Miklos Vajna  <vmiklos@collabora.com>  [a1b935ca1bb6d48241e73e7206a367fe2b51f948]

        sw floattable: fix inner floating table inside normal outer table from DOCX
        
        The problem was that CppunitTest_sw_ooxmlexport9's testTdf79329 has a
        normal outer table and a floating inner table; the inner table was
        already not floating (so that's not a new problem), but
        SW_FORCE_FLY_SPLIT=1 even failed the text-to-table conversion for the
        outer table, so we just had 1 table, not 2 tables.
        
        The problem seems to be that the start/end positions for the outer table
        cell get invalidated by the inner table-to-frame conversion, so the
        outer table conversion will fail as well.
        
        Fix the problem by limiting the table-to-frame conversion for toplevel
        tables: this avoids the failing text-to-table conversion in the
        SW_FORCE_FLY_SPLIT=1 case.
        
        At some stage I should revisit this, since the DOC import has working
        floating tables for the inner case, for now just make sure that the DOCX
        import result has two tables, as before.
        
        Change-Id: I39aa00e46c12a32117c334cb97e1cc0270b77651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149284
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-22  Michael Stahl  <michael.stahl@allotropia.de>  [621143588b3cb438baf27fb6893ab02e7b06f9dd]

        Revert "avmedia : use std::mutex instead of osl::Mutex"
        
        This reverts commit 477fa6c3cb92f578032dee60482718efdb8f44f2.
        
        MissingPluginInstaller requires a recursive lock:
        
        Thread 2 (Thread 0x7f8e73d69700 (LWP 29931)):
        0  __lll_lock_wait () at /lib64/libpthread.so.0
        ...
        5  std::unique_lock<std::mutex>::lock() (this=0x7f8e73d65a88) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:267
        6  std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7f8e73d65a88, __m=...) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_mutex.h:197
        7  avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::detach(avmedia::gstreamer::Player const*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:187
        8  avmedia::gstreamer::Player::disposing() (this=0x75d2fa0) at avmedia/source/gstreamer/gstplayer.cxx:334
        9  cppu::WeakComponentImplHelperBase::dispose() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:104
        10 cppu::PartialWeakComponentImplHelper<com::sun::star::media::XPlayer, com::sun::star::lang::XServiceInfo>::dispose() (this=0x75d2fa0) at include/cppuhelper/compbase.hxx:90
        11 cppu::WeakComponentImplHelperBase::release() (this=0x75d2fa0) at cppuhelper/source/implbase.cxx:79
        13 rtl::Reference<avmedia::gstreamer::Player>::~Reference() (this=0x7f8e7c028f20) at include/rtl/ref.hxx:129
        ...
        21 std::__debug::set<rtl::Reference<avmedia::gstreamer::Player>, std::less<rtl::Reference<avmedia::gstreamer::Player> >, std::allocator<rtl::Reference<avmedia::gstreamer::Player> > >::clear() (this=0x7f8e644c6cd8 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance+248>) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/set.h:426
        22 avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller::report(rtl::Reference<avmedia::gstreamer::Player> const&, _GstMessage*) (this=0x7f8e644c6be0 <rtl::Static<avmedia::gstreamer::(anonymous namespace)::MissingPluginInstaller, avmedia::gstreamer::(anonymous namespace)::TheMissingPluginInstaller>::get()::instance>, source=..., message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:156
        23 avmedia::gstreamer::Player::processSyncMessage(_GstMessage*) (this=0x75abfe0, message=0x7cdb400) at avmedia/source/gstreamer/gstplayer.cxx:536
        24 avmedia::gstreamer::pipeline_bus_sync_handler(_GstBus*, _GstMessage*, void*) (message=0x7cdb400, data=0x75abfe0) at avmedia/source/gstreamer/gstplayer.cxx:382
        25 gst_bus_post () at /lib64/libgstreamer-1.0.so.0
        
        Change-Id: Ia8e7fef4d4cee2dde7189702af6dddf883b6cceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149233
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-22  Yousef_Rabia  <yousef.mohamed.rabia@gmail.com>  [a76ef6e4cb345d6aa70f48777708188fce0ceacb]

        tdf#130924 : replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: I94686f820e264867643bb30c83367ee702d3118d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149088
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-22  Pranam Lashkari  <lpranam@collabora.com>  [7e476a24d1f9d58617e3e94630c931dfa0ab3c84]

        jsdialog: enabled spelling dialog
        
        Change-Id: I36c35e82aa17d8e6cb76dbb24f33344870c49629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149172
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149275
        Tested-by: Jenkins

2023-03-22  Szymon Kłos  <szymon.klos@collabora.com>  [2dae66968750af7ec1337b8a0431c478f043f6e8]

        jsdialog: enable advanced filter dialog
        
        Change-Id: I629566eb3193bba1a56c058eca17a68ff1a84881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148788
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149230

2023-03-22  Szymon Kłos  <szymon.klos@collabora.com>  [5b30ce463476653d7ef6fc6dc88653d409544694]

        jsdialog: enable goal seek dialog
        
        Change-Id: If3ec1d166b39720fd1307e1cc5472b839bf776e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148791
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149220

2023-03-22  Szymon Kłos  <szymon.klos@collabora.com>  [ba15e267f092139d7362ec6867e147c2957bd068]

        jsdialog: enable chart related dialogs
        
        Change-Id: Icb98ce84518d0f43b832ea05d7045f43bc194990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148782
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149218

2023-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [7131530929d3670b8c2db7dc0c1a86c822e05660]

        tdf#154274: show "Unknown Author" when no name is set
        
        Same as in Writer
        
        Change-Id: I830ba9f34dc39424202110538ba4a7dbada1b06c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149206
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-22  Adoche Onaji  <dochieonaji@gmail.com>  [b1dc8d302f5a7c7b8f69261f86ff01377a910c68]

        tdf#38890 Remove hard-coded URLs in source Files
        
        Project URLs are extracted to the Common.xcu files
        and read in the source files.
        
        Change-Id: I0da72ff033af6c155195b2f91177e7bf7d554daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149115
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-03-22  Miklos Vajna  <vmiklos@collabora.com>  [1983695a64c27894fb76bc33bcdc4a2ed9813fc8]

        CppunitTest_sw_htmlexport: avoid XHTML magic
        
        Set the filter option explicitly, rather than inferring it from the test
        name.
        
        Change-Id: Idaf476756b477bf55a31598ce67028fcf1c9d4ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149256
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6fc0de7ce23f8faec052c744434006d40a33110a]

        Fix typos
        
        Change-Id: Iaf63fce5295f00e5d6fff020498a01a25fc0ee93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149262
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [02edbf7dc7cf1a3bcc1b943e79c027e3c144d544]

        tdf#154303 wina11y: Don't truncate 64-bit states
        
            commit 8d8e6c84e512c1a8b33aac75965b84481d1a1d13
            Date:   Sun Jul 3 20:29:28 2022 +0200
        
                [API CHANGE] Drop css::accessibility::XAccessibleStateSet
        
        had introduced the use of a 64-bit integer with
        bit flags for the accessible states.
        
        However, `AccObjectWinManager::DecreaseState` and
        `AccObjectWinManager::IncreaseState` were still using
        unsigned short, resulting in truncation.
        
        As one result, the `AccessibleEventId::STATE_CHANGED`
        event with state `AccessibleStateType::VISIBLE`
        from `OAccessibleMenuBaseComponent::SetVisible` would no
        longer result in the `STATE_SYSTEM_INVISIBLE` being unset
        and thus the the JAWS screen reader would no longer announce
        the focused (but considered invisible) menu item.
        
        Fix this by switching the param for those two methods to
        sal_Int64 as well.
        
        Change-Id: I714573e2691e82c6287a4b83f872f87568e46495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149255
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [949c73f9c35d640c841f03d505e905aa2e1b7a3f]

        use more concrete types in chart2
        
        Change-Id: I70042284e4549b3eef67866a35741b06305d720f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149229
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [30ab88edbbd60e62302a8d08a3cca39bfb0d45a5]

        Fix typo
        
        Change-Id: Ibad12225523e0cbfbd5b09abad8f1b31c7d7264e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149274
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd490103342900a1bab2138555803e53a49894dd]

        Remove executable bits from odt
        
        Change-Id: I719c1a156dea095d391f94b42f78f2a8c99b0673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148938
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-03-22  Mike Kaganski  <mike.kaganski@collabora.com>  [458f2b8f69fbf0a220f18fbf250e4369fd0491cd]

        Refactor and fix VBA StrConv
        
        This properly handles null bytes that are expected
        when converting between byte strings and Unicode.
        
        It properly handles TransliterationFlags, which are
        not a bitset.
        
        In vbProperCase, it uses the correct method to
        lowercase the string, working not only with ASCII.
        
        Change-Id: I04e8cdca66ef9863a6516b15205a2a543ed97680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149224
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-21  Maxim Monastirsky  <momonasmon@gmail.com>  [1cfeb4bd8ce7f7727a81136bd3e2d6ebea976895]

        sc drawstyles: Handle style commands and undo
        
        Change-Id: Ibd81f7aba9ef2efca89556c31cd9b09867419d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149203
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-21  Maxim Monastirsky  <momonasmon@gmail.com>  [f460bd163afb06dc2dccc877269106af38767484]

        sc drawstyles: Connect the styles pool to the draw layer
        
        Change-Id: Ie87bb028264b74fd3e15e23a3ad60ab3c48bb14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149202
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-21  Maxim Monastirsky  <momonasmon@gmail.com>  [6db5e15e5b91f34232e90225a723e0673ecfc2f0]

        sc drawstyles: Implement the styles family
        
        Change-Id: I2af6072685e4c79cfe2f177c0aae27044f86d840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149184
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-21  Pranam Lashkari  <lpranam@collabora.com>  [65758e25b16db552af7699facbe068e3d4aebc3a]

        jsdialog: enabled insert break(manual break) dialog(writer)
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I65213cd8822e574eff333b96a8718ebff2946f5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149166
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 41b7f70981cffb9a04b6b132317915ca51519eab)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149236
        Tested-by: Jenkins

2023-03-21  Pranam Lashkari  <lpranam@collabora.com>  [e8d56d600f16e137acf765842273feeca5d98b37]

        jsdialog: enable watermark dialog (writer)
        
        Change-Id: Ie1f5a299fd68bdfd21c04d1ef79514953a2ac5c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149168
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 8c358c1616a16beb10752f0a60bbacccba15d6ea)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149234
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [f2b97ecf340e1fd714c636060ae09382518a2b46]

        unmerge default and ScrollType::Drag cases for calc scrollbars
        
        before:
        
        commit 8c4e8818fe9f5ac1f6cdf908299cc109d67f1e50
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Aug 4 16:38:47 2022 +0100
        
            nDelta overwritten on all branches except default
        
        the default case was different to the Drag case, and tdf#152406
        uncovers a problem using the Drag case for scroll wheel, so undo
        the merge of default of Drag.
        
        Change-Id: I7471191d5e1f50f74563e8bcbcb82127d94edf2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [24d2e8ea7a17ded531d19cba3f1cb30b17833eea]

        Simplify a bit
        
        Also takes care of one place where dereferencing wasn't safe
        
        Change-Id: I4ed67ad709610bea9cbed8184710f53d18d76d11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149225
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f691fe670526c1c0ba5c9bab8dfe8209bfe698e]

        move getLabel inside chart2::DataSeries
        
        Change-Id: I38baff5980d8cae5f63ee9163d667385837d249b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149198
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [59361b4578d6bea5af618efd904b3243553d246b]

        move getAllRegressionCurvesNotMeanValueLine inside chart2::Diagram
        
        Change-Id: Ic01a886f575022fa106aa2e3b384e184683df6f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-21  Pranam Lashkari  <lpranam@collabora.com>  [11fc8254548d241a972a5f1483609497d8d93ea2]

        jsdialog: enabled thesaurus dialog
        
        Change-Id: I01059e7a4aaffd5c4a2f5ccff55f83ed3db9bf38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149173
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 2e75e849e85da86ea33b447350b0e2f7eaede69e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149237
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-21  Pranam Lashkari  <lpranam@collabora.com>  [6c4464a14ce324100df4cf3934c3ddeeac82ab08]

        jsdialog: enable column dialog (writer)
        
        Change-Id: I4b91d271d766d8efeaddc3c3775513184036c5f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149167
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit f50d009885c499e55db35571ace83f2ed7effbfe)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149235
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-21  László Németh  <nemeth@numbertext.org>  [ed0372bac123b402fe3cd694a455e8328117752d]

        tdf#153255 DOCX import: fix footnote order
        
        Simple unit test for tdf#152203 allowed to create
        bad ordering algorithm by accident without noticing
        the problem, which caused problem for most of the DOCX
        files, where serialization in footnotes.xml doesn't follow
        the order of the footnotes.
        
        Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
        "tdf#76260 DOCX import: fix slow footnote import".
        
        Follow-up to commit 09ae3c01940bbc25ffde51963683b04e3cb4bb6a
        "tdf#152203 DOCX import: fix mixed footnotes/endnotes".
        
        Change-Id: I0628d96e3b8ad4df38d26e9288b47d39b958c441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149176
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [808c5bf66370f78f36e98887db0848ee7e55bb3a]

        MCGR: Model data changes for ColorSteps (II)
        
        The biggest change here is to allow multiple ColorStops
        with the same Offset. That allows to define gradients
        with 'hard' color changes at any place using two
        ColorStops with the same Offset and different Colors.
        This required quite some adaptions, but works well.
        
        Also removed in this context checking for all Colors
        being the same to not mix up things. Also works well.
        
        Also changed the need for having Start/EndColors AKA
        ColorStops for 0.0 and 1.0 in place, instead 'imply'
        the 1st ColorStop to also define the StartColor and
        the last one the EndColor. This allows e.g. Gradient
        definitions with two GradientStops at the same
        Offset e.g. 0.5 with different colors to already
        define a full Gradient.
        
        Also added a tooling method to reverse ColorSteps,
        which changes the order and mirrors the Offsets
        (what even keeps an existing sort valid).
        This is useful e.g. for GradientAxial which is the
        only one where for decomposition the Gradient had
        to be interpreted 'reverse' since it's defined
        from center to edge, but for creating correct filled
        polygons to represent this the inverse order had to
        be used, creating polygons from edge to center.
        This led to 'wild' code for this one of six cases
        and prevented unifications with the other cases
        (also made your brain flip).
        Thus I adapted this now to use the reversed
        ColorSteps consequently, and the same principle
        loops than the other implementations to make things
        easier for the future and to use common tooling.
        
        Change-Id: If2943348d17d5b9cd165f4d78f22638a1dff5237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149208
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [5ccbdcf182851375486386c0df8bb3f04cf2f9cd]

        crashreporting: CreateEmbeddedObject might fail
        
        Change-Id: I0e1ccbea92343d18e5ff3a9af1f54ed5e0dd796b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [b46defbc331c3c91553bc8967cdf48eacea87afd]

        jsdialog: update Entry on replace_selection
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ie0c3586fbf4bda1a9d68dceec61e08ff9f75bb97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149201
        Tested-by: Jenkins

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [74e8476d23b72f06328dcbe183597847471771e1]

        jsdialog: add wrapper for ScrolledWindow
        
        Change-Id: I59489e4cf1e5fb492272108e3a19afb4212753f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148610
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149200

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [5f5e1a3204b98b9e74bded50ba0eddd4fb371301]

        gtk4: use PANEL a11y role for VclBox under gtk4
        
        Change-Id: I0cd6bb9578c177947741bb6d8d21237faf41679d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [f7e5c9bee73c9834312a78adb8d040ed78c6c0ef]

        typo: then->them
        
        Change-Id: Ieb864f70873f2baa1157114b99cfbec98fc84cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149213
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [cde0f27c84599d0d9894148e510254749f7e2784]

        move getTemplate inside chart2::Diagram
        
        Change-Id: I05da4e4a9acb2683633eda42cf18d740913c2e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-21  Patrick Luby  <patrick.luby@collabora.com>  [d82a734c07b85cbd7861699b7fa6d3ebbb3122f2]

        tdf#152406 Disable anti-jitter code for scroll wheel events
        
        After moving thousands of columns to the right via horizontal
        scroll wheel or trackpad swipe events, most vertical scroll
        wheel or trackpad swipe events will trigger the anti-jitter code
        because nScrollPos and nPrevDragPos will be equal and nDelta
        will be overriden and set to zero. So, only use the anti-jitter
        code for mouse drag events.
        
        Change-Id: I9a22b31e1e012a97a058ab36e040629a71f5d24f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149183
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Miklos Vajna  <vmiklos@collabora.com>  [28b16870553f436b8dd0f74894896136057402a3]

        sw floattable, CppunitTest_sw_ooxmlimport2: assert the layout in testTdf114217
        
        The point is that the table is multi-page, which is preserved. The
        detail that it's not in a fly is no longer true.
        
        Change-Id: I8fa61391eb26b434cd7e8b8adb5012c4909e5553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149209
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-21  Michael Stahl  <michael.stahl@allotropia.de>  [e5005c76bd60a004f6025728e794ba3e4d0dfff1]

        curl: upgrade to release 8.0.1
        
        Apparently 8.0.0 had a serious regression.
        
        Change-Id: Icc761f5e5e01b5d9bebecc13f7cba608f5834f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149204
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [33f97ddd549b4ebd72b5fea327378667d55796ff]

        jsdialog: set text for textview on every key press
        
        for that we need to set text without sending back notification
        to not disturb user in typing
        
        we need to keep the selection at the same place
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Ib5c4a53e61dbc2cf28d450fb44fc5a2957ff57b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149191
        Tested-by: Jenkins

2023-03-21  Miklos Vajna  <vmiklos@collabora.com>  [3911b23c89da02eca92a0069bf1035155b7fddae]

        sw floattable, CppunitTest_sw_ooxmlexport9: assert can-split in testTdf109063
        
        It should not be a problem if the table is in a frame, what matters is
        that the frame is marked to split.
        
        Change-Id: Ib289691dcdf78de494518a9afeac3ede9045ec1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149195
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [53946b0698d63849266f465c16386dd8e9319f19]

        CppunitTest_sc_subsequent_filters_test4: simplify code a bit
        
        Change-Id: I85f8a4859e741959f841b82e771d45e9a362cc20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149199
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [4fd7d1a9e64ed256d442ef997c80bce92afe839b]

        cid#1524485 'Constant' variable guards dead code
        
        Change-Id: I3a4dfb0e35db481c94a1f5cb56f078cc9e060a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [8f0a337afd8cf40a74e6668b4441903a1b49f4ae]

        jsdialog: dump properties of scrolled window
        
        Change-Id: Id6d072e951efec4c1de7641c94017c82840fa50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148609
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149190
        Tested-by: Jenkins

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [103e656e4f9e073354dc6a683889fd3fb922ecf2]

        jsdialog: don't send full updates on tab change
        
        All tabs are now sent with the first full message.
        So client can switch between tabs by showing another
        tabpage content. We don't need to send structure again.
        
        Change-Id: I0f3dfc8be4816fba5813a83b41722407631edb73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148421
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149189
        Tested-by: Jenkins

2023-03-21  Tor Lillqvist  <tml@collabora.com>  [660f73385562314e01abb4cef9d443b0c0f42b06]

        There is no XAccessibleStateType
        
        What is meant is surely AccessibleStateType.
        
        Change-Id: I57903dd7e1eb9b0a3cac42a96633093569f770eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149194
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [df12a23157f4515ba5e78c0bd293dfd1609de668]

        move getVertical/setVertical inside chart2::Diagram
        
        Change-Id: Ide512e20fea94b1d7d038290d1c833f1d8cf42ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-21  Caolán McNamara  <caolanm@redhat.com>  [fd32093df9fdf5d46ed4def9fd8dada7d0d5e361]

        tdf#154232 signal_drag_begin callback can delete current GtkTargetList
        
        so fetch the up to date one on calling gtk_drag_begin_with_coordinates
        
        ==3221972== Invalid read of size 8
        ==3221972==    at 0x23F281DA: gtk_drag_begin_internal (gtkdnd.c:1801)
        ==3221972==    by 0x23F2886F: gtk_drag_begin_with_coordinates (gtkdnd.c:1995)
        ==3221972==    by 0x23845075: (anonymous namespace)::GtkInstanceWidget::signal_motion(_GdkEventMotion const*) (gtkinst.cxx:3139)
        ==3221972==    by 0x23844F09: (anonymous namespace)::GtkInstanceWidget::signalMotion(_GtkWidget*, _GdkEventMotion*, void*) (gtkinst.cxx:3130)
        ==3221972==    by 0x23C0FC56: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:84)
        ==3221972==    by 0x1378C05F: g_closure_invoke (gclosure.c:832)
        ==3221972==    by 0x137B8F65: signal_emit_unlocked_R.isra.0 (gsignal.c:3796)
        ==3221972==    by 0x137A8ED5: g_signal_emit_valist (gsignal.c:3559)
        ==3221972==    by 0x137A96F2: g_signal_emit (gsignal.c:3606)
        ==3221972==    by 0x23EF1073: gtk_widget_event_internal.part.0.lto_priv.0 (gtkwidget.c:7812)
        ==3221972==    by 0x23D825AD: UnknownInlinedFun (gtkmain.c:2588)
        ==3221972==    by 0x23D825AD: propagate_event.lto_priv.0 (gtkmain.c:2691)
        ==3221972==    by 0x23D83320: UnknownInlinedFun (gtkmain.c:1921)
        ==3221972==    by 0x23D83320: gtk_main_do_event (gtkmain.c:1691)
        ==3221972==  Address 0x2c7d8070 is 0 bytes inside a block of size 16 free'd
        ==3221972==    at 0x48460E4: free (vg_replace_malloc.c:884)
        ==3221972==    by 0x1383388C: g_free (gmem.c:229)
        ==3221972==    by 0x1384E093: g_slice_free1 (gslice.c:1185)
        ==3221972==    by 0x23CD7A08: gtk_drag_source_set (gtkdragsource.c:162)
        ==3221972==    by 0x23ED1EAB: gtk_tree_view_enable_model_drag_source (gtktreeview.c:14303)
        ==3221972==    by 0x23877F41: (anonymous namespace)::GtkInstanceTreeView::drag_source_set(std::__debug::vector<_GtkTargetEntry, std::allocator<_GtkTargetEntry> > const&, GdkDragAction) (gtkinst.cxx:16279)
        ==3221972==    by 0x238440B3: (anonymous namespace)::GtkInstanceWidget::do_enable_drag_source(rtl::Reference<TransferDataContainer> const&, unsigned char) (gtkinst.cxx:2707)
        ==3221972==    by 0x23877E99: (anonymous namespace)::GtkInstanceTreeView::enable_drag_source(rtl::Reference<TransferDataContainer>&, unsigned char) (gtkinst.cxx:16270)
        ==3221972==    by 0x36AAE6D2: SwContentTree::DragBeginHdl(bool&) (content.cxx:1227)
        ==3221972==    by 0x36AAE2CE: SwContentTree::LinkStubDragBeginHdl(void*, bool&) (content.cxx:1180)
        ==3221972==    by 0x238D38DA: Link<bool&, bool>::Call(bool&) const (link.hxx:111)
        ==3221972==    by 0x23878D2D: (anonymous namespace)::GtkInstanceTreeView::do_signal_drag_begin(bool&) (gtkinst.cxx:16520)
        
        Change-Id: Idffa33c6a549bf17a92eb56760ddfb7d5424b7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-21  Miklos Vajna  <vmiklos@collabora.com>  [8bc607225e6bc9ba343e2292f9185b6491108e44]

        sw floattable, CppunitTest_sw_ooxmlexport9: assert the layout in testTdf107889
        
        The point is that the table is multi-page, which is preserved. The
        detail that it's not in a fly is no longer true.
        
        Change-Id: I63ee8182638a2f0118584f5e985abaf1c3d7e337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149188
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [b9484dfdc2545a1c8eb954b260b5e122d1ede56c]

        Move SalInstanceScrolledWindow declaration to header file
        
        Change-Id: I8848358cf04ad0298867903350476f1f3b38b7da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148608
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149160
        Tested-by: Jenkins

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [7e58604211085caffbbf5dfeefa29385f3267a01]

        jsdialog: textselection action for text view
        
        Change-Id: I11e41b5be897c4341ed0e2baf9fc6772ad0163b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148247
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149159

2023-03-21  Szymon Kłos  <szymon.klos@collabora.com>  [95e41f4a34262661e90736d9c50fb9ca683d5238]

        jsdialog: treeview selection should be an action
        
        Change-Id: Iaaff603b647c18eb566cece272b0e93563c960b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148463
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149158
        Tested-by: Jenkins

2023-03-21  Miklos Vajna  <vmiklos@collabora.com>  [f7ec6a19dca9619bce038dd0aee88765a93255f6]

        UITest_writer_tests{2,3,4,6}: enable oneprocess mode
        
        Execution time changes:
        
        - from 4m8,209s to 2m23,235s
        - from 4m0,718s to 2m35,536s
        - from 2m52,488s to 1m58,201s
        - from 2m40,288s to 1m48,718s
        
        for me.
        
        Change-Id: I9e345d4b97ff888daa9b72598523eb45eaeca648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149181
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-21  Jean-Pierre Ledure  <jp@ledure.be>  [3d94a43d28813b42c11a66fa88724aae53d5780e]

        ScriptForge - (SF_DialogControl) new Resize() method
        
        Addition of method
           control.Resize(X, Y, Width, Height)
        to selectively (arguments are applicable only when present)
        update the position and/or the size of any
        dialog control.
        
        Addition of updatable properties:
           Height
           Width
           X
           Y
        for the same purpose.
        
        All measures are expressed in PIXELS.
        
        The measures for dialogs are also as from now expressed
        in pixels.
        
        Changes are applicable to Basic and Python user scripts.
        
        Documentation should be updated.
        
        Change-Id: I03a6c819efa6a2a67c88403f1ae644d94eb7f2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149174
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-03-21  Baole Fang  <baole.fang@gmail.com>  [8cf73a9a8227f90217c595be04519f0c3692754c]

        tdf#153514: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: Idd4638b68be8400272c496eb61fd17f215f5693b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149078
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a542956c8c2f80f4dd660aa0eef3f1dbab340ba3]

        tdf#154242 and tdf#154143 Asset images for UI Chooser and ToTD
        
        Change-Id: I9397133c3a1fd939f2ef136dc4b914e9248234f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149186
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-20  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [64d1a735b2b371495bfd56faf7070fb3274533ad]

        DocumentFieldsManager::UpdateFields refactoring
        
        - flatten preconditions
        - flatten conditionals
        
        Change-Id: I477220d66ff9fb4e05980a978dda8a7fab85caa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148252
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-03-20  Michael Weghorn  <m.weghorn@posteo.de>  [4a93739e619fd4f4ec369932e923554d71297900]

        tdf#136760 sw a11y: Provide page-relative cursor pos via doc attr
        
        This introduce 2 new extended accessible attributes
        "cursor-position-in-page-horizontal" and
        "cursor-position-in-page-vertical" to expose
        the page-relative position of the cursor in Writer
        to assistive technology.
        
        This is similar to how the current page
        number is already exposed (attribute "page-number").
        
        Together with a corresponding pull request for the NVDA
        screen reader [1], this allows NVDA to announce the position
        similar to how it is done for Microsoft Word (where the information
        is not retrieved via the accessibility APIs but the
        MS Office COM API, s. discussion
        in the corresponding NVDA issue [2] for more details).
        
        (Side note: Currently there is no a11y object for a Writer
        page in the a11y tree, but "normal" paragraphs are direct
        children of the document object.)
        
        For performance reasons, introduce a new method
        `SwCursorShell::GetCursorPagePos` to get the position
        instead of passing the result from
        `SwCursorShell::GetCursorDocPos` to
        `SwFEShell::GetRelativePagePosition` to avoid
        iterating over the doc pages.
        
        [1] https://github.com/nvaccess/nvda/pull/14727
        [2] https://github.com/nvaccess/nvda/issues/11696
        
        Change-Id: I6fd56c5c7d051840bab836ce5fe525fdc061b376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149051
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [92b732ce29f734d91fb6c9350b9a8b6df7f9293e]

        tdf#154273: sw_htmlimport: Add unittest
        
        Change-Id: I9d65f514979bbd24380210dc9006b6ed2649b37a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149165
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-20  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [468fbbc0f5676ec5a630041f835940f673888d83]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7222dc792d578f9640d5d8760041569b29e7f0c1
          - tdf#147469 remove mouse "Positioning" from View options help
            
            Change-Id: I5593ae03960d11aba09d35887fa33692bd278846
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149182
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2023-03-20  Caolán McNamara  <caolanm@redhat.com>  [cc18f6cfed5281e1a47636d9d9df02613a51ff60]

        tdf#147469 remove mouse "Positioning" from options page
        
        Change-Id: I929c62189e3e31358fe95c804457fcbcba85e4b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149149
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [770dd89094a8e60e4d8d9f927fde742e9349fa5d]

        move getStackMode/setStackmode inside chart2::Diagram
        
        Change-Id: Ie359d2a21d288e989bf2bcdfab781938bc8fa26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [70595c0291e4cc137158c77f6136025b10ce6728]

        move setDimension/getDimension inside chart2::Diagram
        
        Change-Id: If52f92e152011ead81a1b25f30ba15124e6a8e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149151
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Michael Stahl  <michael.stahl@allotropia.de>  [e7d5e346677efeb7d7d14537a9151ea7a1a32809]

        vcl,sd,sw: PDF/UA export: add Alt text to SdrMediaObj media shapes
        
          7.18.6.2 Media clip data
          In the media clip data dictionary, the optional CT and Alt keys
          (ISO 32000-1:2008, 13.2.4.2, Table 274) are required.
        
        Change-Id: I147f1677f1bd0788c2269735688d329db15c0ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149007
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-20  Regina Henschel  <rb.henschel@t-online.de>  [790dc4d759c3a2f7f7fc513d358cc0e116e6f17a]

        tdf#154071 UI rename gradient back to 'Rectangular'...
        
        Commit e97e62a4707e09739f9c00f8fc4a943f0123a9cf had wrongly changed
        'Rectangular' to 'Square' (API RECT, ODF rectangle) and 'Square' to
        'Quadratic' (API SQUARE, ODF square).
        This patch reverts 'Square' to 'Rectangular' and 'Quadratic' to
        'Square (Quadratic)'. It uses 'Square (Quadratic)' instead of simple
        'Square' to help users to find the correct type.
        In addition, use of the wrong type names in comments is fixed.
        
        Change-Id: Ibbd90be2cceb65c9857e473cb74c39df1b9530f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149004
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-03-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [403ea882af35337431e0f67aa973c5f046deb630]

        tdf#142978 Add a11y check sidebar
        
        Change-Id: I6d9d6dca0118567f68db11b7c0cce60643211ab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149000
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-20  Michael Stahl  <michael.stahl@allotropia.de>  [bbe0d0534abe6480c4502ce8fb543a736d3399d8]

        curl: upgrade to release 8.0.0
        
        Fixes CVE-2023-27535.
        
        Also hopefully fixes excessive storage consumption during build:
        o build: drop the use of XC_AMEND_DISTCLEAN [62]
        
        Change-Id: I8792e95bc7634ee496488e80fec5a1310b24a31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149153
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-20  Stephan Bergmann  <sbergman@redhat.com>  [7cce1141c6d0fd3023a827021f818f1e96cf26f0]

        Missing includes (for std::exception_ptr)
        
        Change-Id: If93883ba9feb22e6da2d56af4ebb2f4eafe58de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149162
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-20  Stephan Bergmann  <sbergman@redhat.com>  [28fba1a4002cefb6d77f0b682f1d632e18c0967d]

        Don't let workaround for old GCC affect Clang
        
        (which defines __GNUC__ as 4)
        
        Change-Id: I5cf79ed9194150b13e480c91289c42e7bfeed31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149152
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-20  Damjan Jovanovic  <damjan@apache.org>  [28341f0b107b7bcd1377cec68c90eee9c4f27e1c]

        tdf#154273: Add the "&apos;" entity definition to our HTML parser...
        
        ... so that we can correctly read it and convert it a "'",
        but when writing to HTML write out the "'" directly for now.
        
        Fixes: https://bz.apache.org/ooo/show_bug.cgi?id=80657
        
        Patch by: me
        
        Cherry-picked from
        https://github.com/apache/openoffice/commit/3304210c5c53f441cdb2c462fbbf6d8351380b01
        "Add the "&apos;" entity definition to our HTML parser, so that we can…"
        
        Change-Id: I10d07af5f49d2432d99a79318d9d95b0bc976637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149150
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-20  Damjan Jovanovic  <damjan@apache.org>  [d0159892793860e53ddc068b4bdb707a521def19]

        Fix some errors in the scripting module's XInputStreamImpl:
        
        - Check the loop termination in readBytes() properly: currently it increments
        totalBytesRead while also decrementing nBytesToRead, so when compared to
        each other, the loop terminates when the buffer is half full. Only check
        for nBytesToRead instead.
        - Deal with the possibility of available() returning 0 in readSomeBytes().
        
        Patch by: me
        
        Cherry-picked from
        https://github.com/apache/openoffice/commit/7e29bacc90c4b1b9788c3b71dfacd17daecde7a7
        "Fix some errors in the scripting module's XInputStreamImpl:"
        
        Change-Id: I951dc10565afa3519b0ddf98de559a7b585b1627
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149156
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-03-20  MoazAlaa  <moazalaa4727@gmail.com>  [9b631efd012c94d099b0181c5d85aed321d031f5]

        tdf#145614 convert all #define into enum in hwpfilter/source/grammar.h
        
        Change-Id: I8496b95cc55732d72d36cfc4d2fadc5cbea53e6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148261
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [369b241a7dd30e5102306273263cc92f613e12b4]

        move replaceCoordinateSystem inside chart2::Diagram
        
        Change-Id: I49d70e40bd06bb1522ee98185fb0404aede1e7fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Pranam Lashkari  <lpranam@collabora.com>  [87210002a3ea9c785262166efbed59cdf44bb4a6]

        jsdialog: enabled page format dialog (writer)
        
        Change-Id: I352214af08e7f5f8470aeccc49932d0ea5b191a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149061
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit fcc6e504ff968923f0b17d9e59be56dc5f342711)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149103
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-20  Miklos Vajna  <vmiklos@collabora.com>  [f5d97d14a2169c23b801d5d09ea19c001d36bba1]

        uitest: add a way to optionally use the same soffice process for a testsuite
        
        A uitest suite may have several testcases and we spend a lot of time
        spinning up a new soffice process for each testcase, while we typically
        do such initialization only once for per testsuites in the cppunit case,
        slowing down uitests.
        
        The problem is that this way today's uitest cases don't really have to
        clean up after themselves, since they know that the next testcase will
        gets its own clean state (back to the start center).
        
        Fix the problem by adding an opt-in way, so that a uitest suite can
        declare that it's safe to run the entire suite with the same soffice
        process. To be more specific:
        - add a new --oneprocess for test_main.py, which will create a shared
          connection to a soffice process
        - UITest then closes the document (returning to the start center)
          instead of disposing the component in the oneprocess case
        - UITestCase won't create its own soffice connection in the oneprocess
          case
        - add a new gb_UITest_use_oneprocess method to gbuild, to request this
          new, faster behavior
        E.g. on my machine this means UITest_sw_styleInspector takes 26,345s
        instead of 40,652s, probably such a speedup is worth the added
        complexity.
        
        This works nicely when the testsuite is a list of simple/boring test
        cases, always loading one component/document at a time and always using
        close_doc() to close it. It may not be safe for testsuites that do
        something special (they may fail or hang), we'll see.
        
        Change-Id: Ib14439d48aa547c92652245ee1c0cf37d2d7b6e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149134
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-20  Miklos Vajna  <vmiklos@collabora.com>  [48818dd359fbf0f37e1b318de89ab2ea7d735f58]

        sw floattable: fix handling of nested non-floating tables at cell start
        
        CppunitTest_sw_ooxmlexport8's testN779642 failed in the
        SW_FORCE_FLY_SPLIT=1 case.
        
        The bugdoc has a floating table, then an inner, non-floating table. The
        conversion to floating tables was disabled by the
        c1eebcdac9f2b289fd363399130c485ca5ff444c (tdf#79329 DOCX import: fix
        missing outer table with floattable at cell start, 2016-11-08).
        
        Given that SwFormatFlySplit doesn't need the delayed text frame
        conversion, we can get rid of this workaround.
        
        Fix a similar problem on the export side as well, where the positioning
        properties of the outer table leaked into the inner table. Once both the
        import and export are fixed, the test passes.
        
        Change-Id: I884ad38cbc247c885991b0faf0d37221b70a6ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149154
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [564d0fa5b38bdd90d15b8e4b630e3d6ac6d10769]

        Update git submodules
        
        * Update translations from branch 'master'
          to 68c647361a152687bdc6f08222d479a7ad802513
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I7be920e9559128d8f94b8ccb787bb70719175c86
            
2023-03-20  Juergen Funk  <juergen.funk_ml@cib.de>  [038f0b06a2d7d90e7ea19f2233f2892d9c78a08c]

        little optimization in accelerators
        
        remove double calls
        
        Change-Id: I4242067bdc0fdcc5184d555bb293f17d66965fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147094
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-20  Juergen Funk  <juergen.funk_ml@cib.de>  [c6dffdf014127af23b0b20b1015a4b6fdf0e1ac9]

        tdf#153587 If one of the multiple shortcuts is deleted,
        
          the next one is not displayed
        
        This patch solve the part 2 of the bug, the problem was
        that it did not take into account whether a command was assigned
        multiple keys, it simply deleted the whole command
        
        Change-Id: I4e09096d3bc112ed49a4210dd294d1acf7a48159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147093
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-20  Caolán McNamara  <caolanm@redhat.com>  [770eea32b68a95e493a86a97eba5003c46ed736b]

        tdf#152898 remove "show context menu shortcuts" from options page
        
        Change-Id: I44acae51ca72ece735f264e826f8d254e85be8f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [0283512c49160aada159576c2fbb9b57c484b007]

        cid#1523442 Silence this Coverity diagnostic: the copy is intentional
        
        Change-Id: Ief116532a294edadf332edb758d3f2018f6249fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149098
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [514d2c7d20b3d63fc753918e4013eec71d2b342e]

        move attachSeriesToAxis inside chart2::Diagram
        
        Change-Id: I3559fe9b9f0830c32a44c23b0b4d1a3683bafbd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Stephan Bergmann  <sbergman@redhat.com>  [a44c9d023041c881f7858ddd9d93809dc1861313]

        rtl_allocateString takes a size_t parameter
        
        Change-Id: Ibfdc0e7e3af243f157d5d14e3fbe5ab204c0b8df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149140
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-20  Miklos Vajna  <vmiklos@collabora.com>  [75249d502e83c10ec38ef8cc8ee58c6c877c6ee9]

        sw floattable: fix CppunitTest_sw_ooxmlexport10's testTdf99140
        
        Assert this at a layout level, which still passes:
        
        - the table is split on two different pages
        
        - the width of the floating table is correct
        
        Change-Id: I580db33fc7c049d27c1b2c8da5aac4b37e989695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149137
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-20  Caolán McNamara  <caolanm@redhat.com>  [ad59487053bcd267b53febde0cecbd64c7f94cc0]

        crashtesting: frequent XDiagram OPropertySetHelper::getFastPropertyValue crash
        
        seen with
        
        gcc --version
        gcc (Debian 10.2.1-6) 10.2.1 20210110
        
        bt
        
         #1  0x00007ffff702fd36 in cppu::OPropertySetHelper::getFastPropertyValue (this=this@entry=0x55555991baa0,
             nHandle=nHandle@entry=0) at /home/buildslave/source/libo-core/cppuhelper/source/propshlp.cxx:550
         #2  0x00007fffd6e97b4d in chart::Diagram::getDiagramPositioningMode (this=0x55555991ba30)
             at /home/buildslave/source/libo-core/chart2/source/model/main/Diagram.cxx:720
         #3  0x00007fffd6dd9575 in chart::SeriesPlotterContainer::initializeCooSysAndSeriesPlotter (this=0x555559aa44a0,
             rChartModel=...) at /home/buildslave/source/libo-core/chart2/source/view/main/SeriesPlotterContainer.cxx:231
         #4  0x00007fffd6d96e02 in chart::ChartView::createShapes2D (this=this@entry=0x555558fb1fa0, rPageSize=...)
             at /usr/include/c++/10/bits/shared_ptr_base.h:1324
         #5  0x00007fffd6d98420 in chart::ChartView::createShapes (this=this@entry=0x555558fb1fa0)
             at /home/buildslave/source/libo-core/chart2/source/view/main/ChartView.cxx:1398
         #6  0x00007fffd6d98647 in chart::ChartView::impl_updateView (this=0x555558fb1fa0,
             bCheckLockedCtrler=bCheckLockedCtrler@entry=false)
             at /home/buildslave/source/libo-core/chart2/source/view/main/ChartView.cxx:1451
         #7  0x00007fffd6d9c5f0 in chart::ChartView::updateHard (this=<optimized out>)
        
        info vtbl this
        
        vtable for 'cppu::OPropertySetHelper' @ 0x7fffd71c7980 (subobject @ 0x55555991baa0):
        [0]: 0x7fffd6ea0529 <non-virtual thunk to chart::Diagram::queryInterface(com::sun::star::uno::Type const&)>
        [1]: 0x7fffd6e95434 <non-virtual thunk to chart::Diagram::acquire()>
        [2]: 0x7fffd6e953ba <non-virtual thunk to chart::Diagram::release()>
        [3]: 0x7fffd6e9ff43 <non-virtual thunk to chart::Diagram::setFastPropertyValue(int, com::sun::star::uno::Any const&)>
        [4]: 0x7ffff702ff0b <non-virtual thunk to cppu::OPropertySetHelper::getFastPropertyValue(int)>
        [5]: 0xffffffffffffff88
        [6]: 0x7fffd71c7008 <typeinfo for chart::Diagram>
        [7]: 0x7fffd6ea0520 <non-virtual thunk to chart::Diagram::queryInterface(com::sun::star::uno::Type const&)>
        [8]: 0x7fffd6e9542e <non-virtual thunk to chart::Diagram::acquire()>
        [9]: 0x7fffd6e953b4 <non-virtual thunk to chart::Diagram::release()>
        [10]: 0x7fffd6e9ae67 <non-virtual thunk to chart::Diagram::getPropertySetInfo()>
        [11]: 0x7ffff702de17 <non-virtual thunk to cppu::OPropertySetHelper::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&)>
        [12]: 0x7ffff702de89 <non-virtual thunk to cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&)>
        [13]: 0x7ffff702f6ec <non-virtual thunk to cppu::OPropertySetHelper::addPropertyChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> const&)>
        [14]: 0x7ffff702f8be <non-virtual thunk to cppu::OPropertySetHelper::removePropertyChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> const&)>
        [15]: 0x7ffff702fb24 <non-virtual thunk to cppu::OPropertySetHelper::addVetoableChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XVetoableChangeListener> const&)>
        [16]: 0x7ffff702fcf6 <non-virtual thunk to cppu::OPropertySetHelper::removeVetoableChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XVetoableChangeListener> const&)>
        [17]: 0xffffffffffffff28
        [18]: 0x7fffd71c7008 <typeinfo for chart::Diagram>
        [19]: 0x7fffd6ea0514 <non-virtual thunk to chart::Diagram::queryInterface(com::sun::star::uno::Type const&)>
        [20]: 0x7fffd6e95425 <non-virtual thunk to chart::Diagram::acquire()>
        
        but without "final" used
        
        info vtbl this (and this is what I also get with fedora's gcc 12.2.1
        with "final" used)
        
        vtable for 'cppu::OPropertySetHelper' @ 0x7fffd79c8850 (subobject @ 0x55555991cc98):
        [0]: 0x7fffd76a1370 <non-virtual thunk to chart::Diagram::queryInterface(com::sun::star::uno::Type const&)>
        [1]: 0x7fffd76962d2 <non-virtual thunk to chart::Diagram::acquire()>
        [2]: 0x7fffd7696258 <non-virtual thunk to chart::Diagram::release()>
        [3]: 0x7fffd769bcf7 <non-virtual thunk to chart::Diagram::getPropertySetInfo()>
        [4]: 0x7fffd77fcd5c <property::OPropertySet::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>
        [5]: 0x7ffff702e320 <cppu::OPropertySetHelper::getPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&)>
        [6]: 0x7ffff702f1ac <cppu::OPropertySetHelper::addPropertiesChangeListener(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener> const&)>
        [7]: 0x7ffff702f282 <cppu::OPropertySetHelper::removePropertiesChangeListener(com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener> const&)>
        [8]: 0x7ffff703085a <cppu::OPropertySetHelper::firePropertiesChangeEvent(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertiesChangeListener> const&)>
        [9]: 0x7ffff702dde2 <cppu::OPropertySetHelper::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&)>
        [10]: 0x7ffff702de1e <cppu::OPropertySetHelper::getPropertyValue(rtl::OUString const&)>
        [11]: 0x7ffff702f490 <cppu::OPropertySetHelper::addPropertyChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> const&)>
        [12]: 0x7ffff702f6f6 <cppu::OPropertySetHelper::removePropertyChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertyChangeListener> const&)>
        [13]: 0x7ffff702f8c8 <cppu::OPropertySetHelper::addVetoableChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XVetoableChangeListener> const&)>
        [14]: 0x7ffff702fb2e <cppu::OPropertySetHelper::removeVetoableChangeListener(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::beans::XVetoableChangeListener> const&)>
        [15]: 0x7fffd76a0dae <non-virtual thunk to chart::Diagram::setFastPropertyValue(int, com::sun::star::uno::Any const&)>
        [16]: 0x7ffff702fd00 <cppu::OPropertySetHelper::getFastPropertyValue(int)>
        [17]: 0x7fffd769bc26 <non-virtual thunk to chart::Diagram::getInfoHelper()>
        [18]: 0x7fffd77f78c0 <property::OPropertySet::convertFastPropertyValue(com::sun::star::uno::Any&, com::sun::star::uno::Any&, int, com::sun::star::uno::Any const&)>
        [19]: 0x7fffd77fcb46 <property::OPropertySet::setFastPropertyValue_NoBroadcast(int, com::sun::star::uno::Any const&)>
        [20]: 0x7fffd76a0f5f <non-virtual thunk to chart::Diagram::getFastPropertyValue(com::sun::star::uno::Any&, int) const>
        
        seen with exporting forum-de2-10559.odt to odt
        
        Change-Id: I18f7ddb90f9249eda5f5635fe4e9d185a2e092f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149117
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-20  Stephan Bergmann  <sbergman@redhat.com>  [0f6dfd5e6d3635ba56c320179a616405cd05d68a]

        Fix C++20 build
        
        ...after 40d717c7bea493a24b9fd888bc71647d8793323b "CppunitTest_starmath_export:
        inherit from UnoApiXmlTest",
        
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: overload resolution selected deleted operator '<<'
        >     ost << x;
        >     ~~~ ^  ~
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:42: note: in instantiation of function template specialization 'CppUnit::StringHelper::toString<char16_t>' requested here
        >         return CPPUNIT_NS::StringHelper::toString(x);
        >                                          ^
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:50: note: in instantiation of member function 'CppUnit::assertion_traits<char16_t>::toString' requested here
        >     Asserter::failNotEqual( assertion_traits<T>::toString(expected),
        >                                                  ^
        > starmath/qa/extras/mmlexport-test.cxx:76:5: note: in instantiation of function template specialization 'CppUnit::assertEquals<char16_t>' requested here
        >     CPPUNIT_ASSERT_EQUAL(u'\x222B', aContent[0]);
        >     ^
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:333:17: note: expanded from macro 'CPPUNIT_ASSERT_EQUAL'
        >   ( CPPUNIT_NS::assertEquals( (expected),              \
        >                 ^
        > ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.1/../../../../include/c++/13.0.1/ostream:605:5: note: candidate function [with _Traits = std::char_traits<char>] has been explicitly deleted
        >     operator<<(basic_ostream<char, _Traits>&, char16_t) = delete;
        >     ^
        
        Change-Id: I4602c6876d21dc17c6b8d5dfda08a17216087aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149119
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-20  Miklos Vajna  <vmiklos@collabora.com>  [28325983db2f7613b94bc70ef920ba13ebe6d817]

        sw floattable: fix CppunitTest_sw_ooxmlexport10's testTdf8255
        
        This asserted that the table is not floating, rather assert that the
        floating table is allowed to split.
        
        Change-Id: I1dec6027b0774a1fc5380e65c7221b3b9d289e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149133
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-20  Stephan Bergmann  <sbergman@redhat.com>  [926095df6b444866cd7e245b6a7befa6c2e29424]

        Shrink rtl_[u]String allocation size to what's actually needed
        
        Change-Id: Ib39caf31b5d2fb06cc81cdeb14578794b35d8ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149120
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-20  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [048d01ff0f0869be3b63ad62ea15e52f3727f617]

        cppuhelper : use BaseMutex instead of OFactoryComponentHelper_Mutex
        
        Change-Id: I49ed178310b6d8441d8cfdd208b26b8d13ef39ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [d4822aa45017349fcff36e9a61e1e5b0237b208f]

        cppuhelper : use constexpr OUStringLiteral instead of a function
        
        Change-Id: Icc25698e4213edbeaae1a997dccbee0ff529ce3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149092
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d4ac66e25427a71798ab720df8078a541d745da]

        move getAttachedAxis inside chart2::Diagram
        
        Change-Id: I520633863103a966f1836b4473bc6be32a134ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149093
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a4bcb83f6ac6d240f1358c7334f221a5b8a3d83]

        move getChartTypeOfSeries inside chart2::Diagram
        
        Change-Id: I496b180c1e7d6641760251186357d2b11f4434ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-19  adityasingh22  <adityasingh22011997@gmail.com>  [1f22d01b7ae96a7efa91c9285f3d2f8c37f05237]

        tdf#147906: Use python's math.hypot() for Pythagorean addition
        
        Change-Id: Iff40b4fcbfd0fce492aff4f10f7651899d36872d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148547
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-03-19  Maxim Monastirsky  <momonasmon@gmail.com>  [ba58d80a1a9c30e58b20184135e81cc1851bdd75]

        sc drawstyles: Delay the destruction of SdrItemPool
        
        Nowadays SfxItemPool_Impl::mpSecondary is ref counted, so
        there is no fear in destroying the draw layer before the doc
        pool.
        
        This kind of change is needed for drawing styles, as their
        item set references the SdrItemPool with a raw pointer, but
        they are destroyed as part of the styles pool, much later
        than the draw layer.
        
        Change-Id: I169bbacfbdbec2121217b13293b6f495898fe2e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149090
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [01d0019c851b9e942f9a3b94d6dd554fb1adb40c]

        MCGR: Model data changes for ColorSteps
        
        Added tooling replaceStart/EndColor to allow simple
        transition for code that does not immediately adapt
        to multi color gradients. Also added
        createColorStepsFromStartEndColor for the same
        purpose.
        
        Adapted XGradient to no longer have Start/EndColor
        at all, but only use ColorSteps.
        
        Adapted all usages of XGradient to no longer use
        Get/Set/Start/EndColor, but access the ColorSteps
        instead.
        
        Replaced quite some XGradient constructors that
        used XGradient() as Start/EndColor since this is
        already the default.
        
        Adapted ColorBlending to black AKA Start/EndIntens
        in XGradient to work now on all ColorSteps in the
        required linearly-scaled manner.
        
        UNO API changes:
        
        Added com::sun::star::awt::ColorStep as basic data
        element that holds a pair of Offset and Color.
        
        Added com::sun::star::awt::ColorStepSequence to
        handle an array of sorted entries.
        
        Added com::sun::star::awt::Gradient2 derived from
        com::sun::star::awt::Gradient, extended by the
        needed com::sun::star::awt::ColorStepSequence.
        
        Added MID_GRADIENT_COLORSTEPSEQUENCE to UNO API
        to provide access to ColorSteps directly.
        
        Adapted XFillGradientItem::QueryValue/PutValue to
        make use of new UNO API data structures. To do so,
        added tooling methods for data transition:
            - fillColorStepSequenceFromColorSteps
            - fillGradient2FromXGradient
            - fillColorStepsFromAny
            - fillXGradientFromAny
        and adapted
            - case '0' (all data)
            - MID_FILLGRADIENT
            - MID_GRADIENT_COLORSTEPSEQUENCE
            - MID_GRADIENT_START/ENDCOLOR
        to make use of these.
        
        Tested usage of these in the office.
        
        Renamed from GradientStep to GradientStop after
        discussions with members on the list to make this
        closer related to other norms/definitions.
        
        Also renamed classes and class members to better
        reflect to GradientStop, so grepping/finding will
        be easier (e.g. 'Color' just exists pretty often,
        but 'StopColor' is more precise).
        
        Changed the used UNO API class for reprsenting the
        Color to better reflect to ranges [0.0 .. 1.0] and
        usage of RGB.
        
        Change-Id: I1eeb3e97e81d6785967615d1ff256551fc3b882d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148849
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd299d209d82495eb6528fb444e0b68f41c8ae0d]

        move getDataSeries inside chart2::Diagram
        
        Change-Id: Ie60d288dba9c8d006de03c80d3cfc7bf8f108782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-19  Vinit Agarwal  <agarwalvinit5678@gmail.com>  [48b1fdf31f2fd4e9de47bda40e58cde7be9bc94d]

        tdf#114441 - Convert use of sal_uLong to better integer types.
        
        In reportdesign/source/ui/dlg/Navigator.cxx
        Updated type of nPos at Line number 574 to int as it would be either
        1 or 2 depending on the ternary evaluation
        
        Change-Id: If2bf75ddfb66b518fec109757f32dd6e4a8b77dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148600
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-18  Caolán McNamara  <caolanm@redhat.com>  [b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41]

        probably a good idea not to have two things called comphelper::UnoImplBase
        
        Change-Id: Ib2b4456c55bcb65fba1ec67739ba08b22a4fcae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149086
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-18  Caolán McNamara  <caolanm@redhat.com>  [3e6c7ac667511aaafd210b8e93cd54798c387acd]

        cid#1523394 Dereference after null check
        
        Change-Id: I1feeace608c11b653fce17020afe592de4317de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [61e6afb4d556f95d3cb7dc64262d834c627518f1]

        move getDataSeriesGroups inside chart2::Diagram
        
        Change-Id: I776e07ad6dce63df9891ab6823811ad20a37e77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [84352224e132c52bcc5ebff44c5a6f8383316f79]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ba7b847709a22714cb276d0bc9d12b7ea204d50
          - remove extra space
            
            Change-Id: Ief6c4fa6381c15ebca3843d22f083f567ba663e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149096
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-18  ektagoel12  <ektagoel12july@gmail.com>  [307b1cc494c51c802882ae23029e33a72d57f2a3]

        tdf#130924 replace debugging fprintf calls with SAL_INFO/SAL_WARN
        
        Change-Id: I1893e130af2584c1d57c3e37ee3f3ff18c07c077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148792
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8fc36154e1933bb3d9e2a549b7ab4d4e5e46c75]

        move isCategory inside chart2::Diagram
        
        Change-Id: I568a573004c20d7bbf60a947b34a6a8223217b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [183c3d58fbaf20a61b589d8f8f29bffc07fbe7dd]

        move getCategories/setCategories inside chart2::Diagram
        
        Change-Id: I7c6b4e92bb131cc3c6b5b4eedb3304128b8bd988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-18  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [60901415ef727622c4820cc30bf6324b0cc6b0a3]

        tdf#154242 Explanatory images of UI Chooser (.uno:ToolbarModeUI)
        
        Change-Id: I4068522a866843ed19bdd0c44d5e018e7a51cf2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149077
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0bb487ae390b29fd75258cae6fb3a7645fefcc86]

        move isSupportingDateAxis inside chart2::Diagram
        
        Change-Id: I6c0d6d68c08cc66bff6666c6ff8189d2e7e24c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149079
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-18  Caolán McNamara  <caolanm@redhat.com>  [dbeff4210d3e88751508fffc4df24368d4e6d37c]

        cid#1523393 Uninitialized scalar field
        
        Change-Id: If95378442e3be04abae3c9f6090d5b6904feee47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149073
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-18  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3e6c9ff68fafadc3d445720df2438d4e370cc816]

        bridges: add whitespace to SAL_INFO
        
        Missed in 7a8ec6cddc9f37ba6ff1a98ad39702521c8fb36b
        
        Change-Id: I70b73873f20814d25c34f326a6552e72f57b3e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149081
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3086565a02ec85ff43be641bd2b7b1a499bb4968]

        Fix typo
        
        Change-Id: Ibaed9abff12438789841e3560416198d52d7647f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149075
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b9acb48b1ea45c82dbd8df3faa35cabd3bb9b4d]

        loplugin:stringadd use more O[U]StringChar
        
        Change-Id: I196e4539ad430a39415eff9d7170b33df7228230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-18  Khaled Hosny  <khaled@aliftype.com>  [6f54b54ec3dc51fb8824adb08620fde4c70d10f2]

        tdf#154235: Ignore underline metrics for all Liberation fonts
        
        They all have bad metrics and we are better off synthesising metrics for
        them instead. Also simplify the exception list to only use family name.
        
        Change-Id: I9e13bc05bdf56a31e9805fcd348439d191ed3a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149072
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-03-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f30e9a6143128421c8fabd2ebb4eafcb43c1e16a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1950b38e185b4ced962e2bacde9ac4086b31257c
          - tdf#152605 revise "heading level"; update command names
            
                update command names for Edit Index, N#
                "heading level" -> "index level"
                refactor <h1>,<menuitem>,<relatedtopics>,remove <xml-lang>
            
            Change-Id: I3b4a00366bbfa7108716136ac5004c50aa9813e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149022
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ce15f7b5999d119b1c6ec726731c32c321f7dc92]

        tdf#154214 redesign of Caption Options dialog
        
        Change-Id: I7cb9c8a01b8ae2482b7dbce976288df1b878b87c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148964
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-17  Khaled Hosny  <khaled@aliftype.com>  [155028fa20d89713ec82168e5c7570333a47136d]

        tdf#154235: Fix underline position in PDF export
        
        Change-Id: I9a15646cc6a69ca7226f06ecc56a28fba3fa96db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149071
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-03-17  Eike Rathke  <erack@redhat.com>  [b8547e65e5807dce6bf66839548a4b8c20729515]

        Related: tdf#153842 {dsb-DE} remove confusing comment
        
        The format is needed, even if not used / offered as default.
        
        Change-Id: Ifd4e5114a1d763a9a7ef69046949dfb7cf96ef84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149055
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-03-17  Baole Fang  <baole.fang@gmail.com>  [70b8adb100499178ad52f23f7c0a1b7a31129921]

        tdf#153683: Refactor fix
        
        Change-Id: I3358c99425edae92bde120eda4fd905552444eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149034
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-17  Miklos Vajna  <vmiklos@collabora.com>  [9a9ee21ec237eda5df6ea70bfa3bec07b44b4d21]

        sw floattable: fix redline import from DOCX
        
        The problem was that sw/qa/extras/ooxmlexport/data/tdf149388.docx
        contained redlines but those were not imported for split flys.
        
        This happened because split flys get imported directly in
        DomainMapperTableHandler::endTable(), and the redling handling for
        floating tables was only implemented in
        SectionPropertyMap::CloseSectionGroup() (where delayed floating tables
        are imported).
        
        Fix this by extracting the redline import code for floating tables into
        2 functions and then calling those also from
        DomainMapperTableHandler::endTable().
        
        Note that the !isExported() branch of the testcase looks like dead code,
        since we always run this code after an export.
        
        Change-Id: I860ee0168807077eb5ed33d79888f4cc1de9a717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149057
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [32b2d00853d049bacb60cfb40e732602da048c89]

        tdf#148008: do not proceed after the marked range
        
        Implementation error in commit c008dc483f8c6840803983e7e351cec6fdd32070
        ("Switch to using multi_type_vector for cell storage.", 2013-06-24).
        
        Change-Id: I1e946b3b816db3d24f79a10fe8aa0dfc673b2e4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149026
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-17  Michael Stahl  <michael.stahl@allotropia.de>  [dd3c70518851b532f43a853d8e0c6189013844c4]

        sw: fix assert on tdf140219-2.odt
        
        itrpaint.cxx:421: void SwTextPainter::DrawTextLine: Assertion `!roTaggedParagraph' failed.
        
        The unexpected situation is that the SwTextFrame contains no numbering
        portions but only fly portions, and the follow SwTextFrame contains the
        numbering portion.
        
        Delay producing the numbering and paragraph structured elements until
        the numbering portions - it's the only way to create the list structure
        correctly.
        
        Unfortunately this means that the fly anchored on the paragraph won't be
        nested inside the paragraph structured element any more, because it's
        created later, but that seems rather difficult to do and the paint order
        in sw already prevents this from working for hell layer flys.
        
        (regression from commit 9b38beadf9eaf027b201cdf0ecb2bce5611014dd)
        
        Change-Id: I9b40b85edd6f4b9920beac5602a5d3a6d4de5dd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149058
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [db96cd9d410b34e235b5de772540d08537298669]

        Move the variable into the scope where it's used
        
        Change-Id: Ib49ba81686199eea045d9f4eca6c8978646694f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149027
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-17  Stephan Bergmann  <sbergman@redhat.com>  [d9f591bcd99f23d6dbf259107a9985f5e851a541]

        loplugin:rangedforcopy: Assume non-reference structured binding is intentional
        
        See pending <https://gerrit.libreoffice.org/c/core/+/149026> "tdf#148008: do not
        proceed after the marked range" for a use case.
        
        Change-Id: Ief7cbb215068b6f5428c16a72896ef5612204128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149056
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a519bc2afec54f1c4c78d30023415d7ae7dc6c4]

        move getChartTypeByIndex inside chart2::Diagram
        
        Change-Id: Idff60dbd7c1cdb8c60e7ac07ad3abe3c6b07e321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149050
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Heiko Tietze  <tietze.heiko@gmail.com>  [2327015285ef31430d8b6a1c18b45d3da1890306]

        Related tdf#97551 - Fixes XHierarchicalNameAccess warning
        
        Change-Id: I965568bfa57449d1227e7ed0967bc05a29edf85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148998
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-03-17  Pranam Lashkari  <lpranam@collabora.com>  [b12c6c938450dee5092378b543da8bd8e2f1227f]

        jsdialog: enabled paste special dialog
        
        Change-Id: I20833a2d138208ad139d0a4c673f87a0f7eb8f5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148920
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 8665bd300f60a3934d9991a877097112edda325f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149015
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-17  Eike Rathke  <erack@redhat.com>  [993e13768116dd3a1ac61b83520b3f6cdbb55e54]

        Related: tdf#153842 {hsb-DE} does not use AM/PM
        
        Switch defaults and remove from 47 date+time edit format code.
        
        Change-Id: I4832c26490adcc369a2d88e524fded724d01e996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149054
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-17  Stephan Bergmann  <sbergman@redhat.com>  [b8f131d4cc0454ffe4f809763ce6bccafeab3eb0]

        Towards literal O[U]String types in C++20
        
        ...(where destructors can be constexpr), making
        21584b304b21bfe6b99b6f29018c6b754ea28fc0 "make OUString(OUStringLiteral)
        constructor constexpr" and 983c1146ac80c038feae653e8e3752a72171d6cb "actually
        make OString(OStringLiteral) constructor constexpr" actually useful and
        eventually removing the need for O[U]StringConstExpr again
        
        Change-Id: I55520c1d928758f61e92336206e0f14b6f12a711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148978
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-17  Maxim Monastirsky  <momonasmon@gmail.com>  [796c9c5ac2196e62546bcef229dcd08a3b8724db]

        sc drawstyles: Move style commands to ScTabViewShell
        
        For them to be available also when shapes are selected.
        This commit alone shouldn't cause any change in behavior.
        
        Change-Id: Ic038618fe8b450ef2c93a19efb2e27c41f6de0f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149047
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-17  anfanite396  <dipamt1729@gmail.com>  [34f7c8cce9c16861940f403f9a633fe8b26ba4ad]

        tdf#145538 Use range based for loops
        
        Change-Id: I546bbcd6de02f9a31db6dcb34b4493bd165c0661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148527
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [928957ee04c57a20bab42223b81f55a714b62d9c]

        tdf#151741 - BASIC Organizer: fill various URLs for libraries
        
        Otherwise, libraries cannot be renamed in the BASIC organizer.
        
        Change-Id: I6c78cdee12f8d6128acf68e889fca463ed782477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148483
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-17  Uday Sharma  <itsudayy@gmail.com>  [f18b76cad2e27fe5167cd683916d592088c5bf99]

        tdf#132293 remove some unused imports from uitests
        
        Change-Id: I7a116345e479dd5344396e845ef840bc6b5a6c1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149003
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-17  Michael Stahl  <michael.stahl@allotropia.de>  [2f94534311e68d27c888628b4694a67a38bcfde5]

        sw: fix crash on exporting forum-en-3524.odt to PDF
        
        It turns out that the m_bFootnoteNum flag is no guarantee that there is
        a SwFootnoteNumPortion, because if it has no width, it will be deleted
        in SwLineLayout::CalcLine(); the flag indicates that this is the frame
        which would contain the SwFootnoteNumPortion, which appears to be
        checked in SwTextFrame::Prepare().
        
        (regression from commit 92f7d3bfedc71bb0a91cf77b0263633c9d0f8d14)
        
        Change-Id: I2f3ff70e6c2bb3379068b285cdd5fd52bc7cecf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-17  Miklos Vajna  <vmiklos@collabora.com>  [d477fa8ac1b0d3ee81427217bbb5950278ab16db]

        sw floattable: unconditionally map <w:tblpPr> to SwFormatFlySplit
        
        CppunitTest_sw_ooxmlexport8's testN816593 failed in the
        SW_FORCE_FLY_SPLIT=1 case because the re-import of the document merged
        two tables into one.
        
        The problem starts earlier, we didn't import the table with a <w:tblpPr>
        as a floating table, but we should.
        
        Fix the problem by never going via m_aPendingFloatingTables in the
        SW_FORCE_FLY_SPLIT=1 case, since that was only a workaround for layout
        limitations. This conditionally reverts commit
        78d1f1c2835b9fae0f91ed771fc1d594c7817502 (fdo#68607 bnc#816593
        DomainMapperTableHandler: don't always start a frame, 2013-09-03).
        
        Also add a SwModelTestBase::FlySplitGuard, so it's just a one-liner
        change to test the SW_FORCE_FLY_SPLIT=1 case from cppunit. The goal is
        to have this on by default once it's mature enough.
        
        Change-Id: I9d94a49f7a0c27dd43e8fd388867c65d6d25f2e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149044
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [57914a4084da9107ec6815b1916a4be117c400bf]

        move getChartTypes inside chart2::Diagram
        
        Change-Id: I43fd96feb1e3d34a5f3327b2e6398ca4b5e9f928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149049
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  DrGigioSan  <luigi.iucci@hotmail.it>  [dc6b93011cc5435f367666e43e354c6ab97bbc90]

        store last five most recently used currencies in the currency toolbar drop-down
        
        Refactory
         Cause
           Currency must be added in the MRU list in  SvxCurrencyToolBoxControl::execute
           method.
           Unfortunately in this point the only information available is the number format.
           It is not possibile to infer currency from number format  (e.g: both  USD and
           AUD use symbol $).
         Encapsulating currency data
           In order to solve the problem currency data is enacpsulated in a SvxCurrencyData
           struct. Added a vector of SvxCurrencyData to SvxCurrencyToolBoxControl.
         Static and non static call
           Former static SvxCurrencyToolBoxControl::GetCurrencySymbols has been
           preserved, as it is called by SvxNumberFormatShell.
           A new GetCurrencySymbols is used by the control.
           To avoid code duplication, both functions call a static private function
           inner_GetCurrencySymbols.
        MRU Currencies
           MRU currencies are stored in another member vector m_mru_curencies:
           During currencies vector population (inner_GetCurrencySymbols) a space is reserved
           on top of vector for mru currencies.
           A new method addMruCurrency updates m_currencies. This method is called in
           SvxCurrencyToolBoxControl::execute
        
        Change-Id: I6f86179efd1839e31b089e0086b6ddbdda358f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148896
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f0a3a20efd26f50efbe92643c95f09bd21dfc0f]

        use more concrete types in Diagram::moveSeries
        
        Change-Id: Ic5bb7f36137afe112d1a542bd642355d996cf68c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149048
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Tor Lillqvist  <tml@collabora.com>  [e1c6f36d8bcc0799281e3a7e244175f682d97cb2]

        Add a to_string() function to the code generated for UNO IDL constant groups
        
        If the inpt matches one of the constants exactly, the result is the
        name of that constant. If the input matches some combination of
        constant values that are single bits, the result is the sequence of
        the names of those constants joined with plus signs.
        
        For instance, if the IDL has:
        
        constants Constants {
            const byte BIT0 = 1;
            const byte BIT1 = 2;
            const byte BIT2 = 4;
            const byte BIT3 = 8;
        }
        
        The result of Constants::to_string(5) is "BIT0+BIT2", and the result
        of Constants::to_string(17) is "17".
        
        I am sure there are corner cases that aren't handled as would be
        intuitive, especially with types that include unsigned values.
        Correspondingly, the semantics of the generated to_string() functions
        is not formally defined.
        
        Also add a unit test for the new functionality.
        
        Change-Id: I14aa826d0989ac6dfe97dd5c09119b1601c65643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148995
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [f92721bf182952be88b0349a17e46b684d630c29]

        related tdf#102261: consider ParaTabStopDefaultDistance in SvxRuler
        
        If there's a paragraph scoped tab default distance defined,
        use that as the default tab distance in the SvxRuler instead
        of the document wide setting.
        
        Change-Id: I9b0e7d0db0b25aee08bd27948b2e462b4a4ee496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148060
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fc4f285b2578a68e30004baafc37ea189aa8c00]

        move isSeriesMoveable inside chart2::Diagram
        
        Change-Id: I119552a4f1300eafc8b060f567777a74dc11772f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Pranam Lashkari  <lpranam@collabora.com>  [529c5494c256138c32996d8d95cf7ef542af7900]

        jsdialog: enable style dialog (writer)
        
        Change-Id: Iaf664deeac5c5887f20c9579881cd921868b652f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148794
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit ae69dc05d3de876dade4fa8a9b6f6f693cc7c865)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148973
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-17  Stephan Bergmann  <sbergman@redhat.com>  [f0ff4243d45b11f372a2ed824fbb8806de9cb595]

        Avoid loplugin:unusedmember crash for templated offsetof
        
        Change-Id: I6cbac308d2911a502381067398d72136ca2b5ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149045
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5bfc127ddabf5f94d0cd1c1e4e6727b4dd3f73a]

        elide some temporary OUStrings
        
        where we are calling
          append(OUString::createFromAscii(
        and we can rather call
          appendAscii
        
        Change-Id: I2366b518fe6d8d2484b00bb831cb79fb49bc0293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [657743ec52c5706a88666afe554752ce0d160361]

        Colibre: tdf#126689 Jump Up & Jump Down This Level icons
        
        Change-Id: Iebfbeecf43e139f39a70ca58bd3b30076856c4d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149042
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-17  Miklos Vajna  <vmiklos@collabora.com>  [90523e10ec053347719309403a4d8566da1dfc4a]

        sw floattable, legacy: also consier fly position when deciding the bottom
        
        The bugdoc has 2 rows: the 2nd row was split and the master row went to
        page 1 and the follow row went to page 2. Word positioned the entire row
        to page 2.
        
        The problem seems to be that the layout code wants a "deadline" (so it
        can grow the frame to that bottom position), but the deadline depends on
        the height: split flys need to fit the body frame, then they can have a
        vertical offset (resulting in an overlap between the bottom margin area
        & the fly frame), in case the fly frame is still inside the page area.
        This means that this deadline depends on the body height, the fly top
        and the fly height at the same time. (Or in other words: the overlap is
        only allowed if the fly would fit the body frame, but an additional
        vertical offset pushes it to the bottom margin area, with an unchanged
        height.)
        
        Solve this fly height <-> deadline circular dependency by first checking
        against the page size, using the current fly height; and then against
        the body height, using the assumed / future fly height (assuming that
        the fly will grow so its new height will match the deadline). This
        results in a construct where usually you can't grow outside the body
        area, but in some limited cases you can (till you only use the bottom
        margin area), but only in case you grow your top position as well, which
        is Word-compatible, but quite unusual at other places in Writer.
        
        With this, the original tdf#61594 bugdoc gets rendered correctly, once
        you opt in with SW_FORCE_FLY_SPLIT=1.
        
        Change-Id: I016df1bad79f4b09abc7e2b4fe9ea613355e3794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149039
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [811e96ae89bf2172217b5cbfaa05f5ffd23b523f]

        move isSupportingFloorAndWall inside chart2::Diagram
        
        Change-Id: Ibc05961b60cabcd3d7421116245713c217b40999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149037
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b3b1bb06b0802735d72d49f6a0088c107b90309]

        move isPieOrDonutChart inside chart2::Diagram
        
        Change-Id: Ib0d8c2674bfa4aa38cdf3a6449642407c2373093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149036
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Miklos Vajna  <vmiklos@collabora.com>  [456b02476f2c8f101479db88087d93b2f57bc75e]

        sw layout xml dump: extract SwHeaderFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about headers.
        
        Change-Id: I96df0d14473564d39368b2af92794a796668676c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149006
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [dfcca2ff48384de1fb36c376a06decea97a1441e]

        move getGeometry3D inside chart2::Diagram
        
        Change-Id: I71f557016c0e107b97ad839b0514efbae4f3665b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148977
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c832bd2103a22c78a6790de9f10ab478ca657b23]

        tdf#126689 Breeze, elementary, KJ, Sifr, Sukapura: Jump + & Jump - This Level
        
        Change-Id: I5f361822048720a68ce2b6fc7246cb7cf7c87fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148983
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-17  Baole Fang  <baole.fang@gmail.com>  [d34a3c92eb68b7f0b2cef698639a2853e19a898f]

        tdf#152690: Refactor fix
        
        Change-Id: I170eba4968743afbab3cc6aa943706612b3e1a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149035
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [9f0cf00d29298ed55737928ec4dddc50ac850cd8]

        Update view options string based on theme
        
        Update the view options string based on the theme when tiled rendering,
        and make sure only the currently active view is updated
        
        Change-Id: Ib24111848f2926fe7ae858ca2e18e946d980e83f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148943
        Tested-by: Paris Oplopoios <parisoplop@gmail.com>
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-03-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [9310192a4a0af4e7e3e9ac6124cdd2a706dfedcb]

        Add uno command that changes the theme
        
        Add an uno command that changes the theme to the one specified in the
        first parameter
        
        Change-Id: Ia0fef2ca698415e07f1943cf80ab667fb5c37238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148942
        Tested-by: Jenkins
        Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>

2023-03-16  Baole Fang  <baole.fang@gmail.com>  [e12fff12b66561bc46a0e22f58919efa443e7e17]

        tdf#152690: Fix "!" behavior when it is not the first in a group
        
        Fix "!" behavior when it is not the first in a group.
        Add testcases for "!" and Like.
        
        Change-Id: Ia76fa26722b6546d08dd8842d83f55bb0c0ea5ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148720
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d426a9299adb5cfd4a38af33b66b7409f6b789d]

        Fix typo
        
        Change-Id: Ic43a5bb4d243b2c4081fcd56130e20ed1c3b43a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149009
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [9a123a6e63600ba3998d22bbc300ac4b65b3da2c]

        cid#1522030 Uninitialized scalar field
        
        Change-Id: Iaf8ad5edd483da25cad45d91afc27f9cc3aa9040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149002
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [aa252a2d019c350d90b7c4a090246451a6006b87]

        Resolves: tdf#152704 old image remains underneath when new image drawn
        
        in this dialog preview widget
        
        Change-Id: Id33995d9a9557d235178be0d12cc6b44e146ff4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148997
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c9fafe07df10d541251f494b28fcb89e5387cda]

        sw: fix null dereference
        
        See https://crashreport.libreoffice.org/stats/signature/SfxDispatcher::ExecuteList(unsigned%20short,SfxCallMode,std::initializer_list%3CSfxPoolItem%20const%20*%3E,std::initializer_list%3CSfxPoolItem%20const%20*%3E)
        
        Change-Id: I7f5471f003798f260d9d015782bd2a798baa22d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148999
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [fde1946074aaa3db23f7fcb5bdfe87f1e75ca7e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a0ef2acc2d24501a7373ab7ba03ddc9473814b54
          - one character is found without plus in regular expression
            
            reported by Kamil Landa
            
            Change-Id: I53f11b8ccd89340d2545e3c26edd8abee8cf5e9a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149005
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-16  Pranam Lashkari  <lpranam@collabora.com>  [ca12d483ba4c764cf5e9ba083c5376dba772547f]

        jsdialog: enabled insert section dialog (writer)
        
        Change-Id: I556973587c2c7f4baab4cf696afe980186e82f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148930
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit cd428e3e564b9bca0badb5e947f78a6fe3ea39ec)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149014
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b209507a57e4ff01c6a06a20d741083b3ddef69d]

        move setGeometry3D inside chart2::Diagram
        
        Change-Id: I3825349e3889c45bbb5cbc467dad2f100ccd2298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Noel Grandin  <noelgrandin@collabora.co.uk>  [2604dae5729018dcc0894179b032c463f941624b]

        osl::Mutex->std::mutex in CDOTransferable
        
        Change-Id: I44e9305ec4127f9567fb51ce7bf8c26f17727787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Noel Grandin  <noelgrandin@collabora.co.uk>  [45946d9465b197a20f12828815da6d9da3b2e3e7]

        osl::Mutex->std::mutex in CMtaOleClipboard
        
        Change-Id: If19fe618de0c316ffa6d74432b03c507b960a891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148953
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [40d717c7bea493a24b9fd888bc71647d8793323b]

        CppunitTest_starmath_export: inherit from UnoApiXmlTest
        
        Change-Id: Ib84525664ff8456b4eb8e100aaaea2783babaf30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148994
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-16  Stephan Bergmann  <sbergman@redhat.com>  [3a1fbb70a39cff9eea852f6709ecb63f45b29c40]

        Prepare compilerplugins for C++23 `if consteval`
        
        ...for which clang::IfStmt::getCond returns null
        
        Change-Id: I8b86a033d52de87dedbdf6d867f2b3d3f57c1b5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148979
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [9affc1f4eb591cd1bf0ca7d87041d1bdc4936f78]

        CppunitTest_starmath_import: inherit from UnoApiTest
        
        Change-Id: I77e48dc05c2bd6a36c42e1860a209ed563e71ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148988
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [8cf26e739797fdceddf5e805f02c63179d17b70e]

        CppunitTest_starmath_export: move code to method
        
        Change-Id: I460ffc51d82ff8b727813228e93a6e0c95c8569a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148993
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [f039fe0da31907a58a4c3b6717cf29caf2685101]

        tdf#102261: pptx export: implement defTabSz ParaTabStopDefaultDistance
        
        Adds export of ParaTabStopDefaultDistance property into defTabSz.
        
        Also adds a unit test that checks pptx roundtrip of the property.
        
        Change-Id: I5be9ea88b15e3e8cab25af79488983a71b96dae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148539
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-16  Khaled Hosny  <khaled@aliftype.com>  [a8725c24fa4d89ec2efddf6f341d403abf79865a]

        tdf#153704: Make sure the last script segment is also added
        
        Change-Id: Id6381d77cdf05c24a1b557206f530f4e004e8e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148986
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-03-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cea9c205cee53f3bcc72129ae00be5fa1835896f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4453c0b2edae4934f87594d5974783c4a1a5ea54
          - convert paragraphs with role="heading" & childelements to → h<level>
            
            and also drop the language that was changed to implied previously/defaults to
            en-US unless specified.
            
            This change doesn't affect translations, only the content of the
            paragraph/headings is extracted.
            
            done with:
            perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>.*?)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g'
            
            and manually undoing the one that uses <sup>in body that's not valid
            according to the dtd in the h tags.
            
            Change-Id: Ibd4aed3157ed168cd5005161575672a392e59202
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148797
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5c78600292d965af157967343a1a4559a086d39a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77cb682cd1b004e7247560e60f603a4bb0565b8d
          - convert plain paragraphs with role="heading" → h<level>
            
            i.e. without child elements and also drop the language that was changed
            to implied in the dtd previously/defaults to en-US unless specified.
            
            This change doesn't affect translations, only the content of the
            paragraph/headings is extracted.
            
            done with:
            perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g'
            
            (all permutations re order of attributes, and xml-lang="en-US" being
            optional / implied)
            
            Change-Id: I365a2bb983a3969af9390753fce7b7f3597c7b8b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148795
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f709f5d23d62752fcd406da35a65232f9883387f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00567a452bb1e270dd2438dcc865359edba56c19
          - convert plain paragraphs with role="heading" → h<level> (localize="false")
            
            done with
            perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")|localize="false"/;} s#<paragraph(((\s+($base)){4})|(\s+($base|xml-lang="en-US")){5})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id} localize="false">$+{body}</h$+{level}>#g'
            
            Change-Id: I5d2b1b6326801adb8d000b3353d314d2fc9f322d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148796
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [266f0d6e94bd83a5017c82c2d18f419377a46b62]

        update line controls dropdown valueset if style changed
        
        e.g. in page style dialog, footnote page, line menubutton, if theme
        changes from light<->dark while the line dropdown remains open.
        
        Use the application settings, and not the current rendercontext settings
        to get the up to date settings and not the settings at the time the
        virtual device rendered to was created.
        
        Change-Id: I674c94603f15c9035bbd07b4bd7247dcebc3124b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148982
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [bda036f0fe34cb8f20e1d4441f1514bae68df69f]

        update line controls preview if style changed
        
        e.g. in page style dialog, footnote page, line menubutton,
        if theme changes from light<->dark while the dialog remains open
        
        Change-Id: If8ca8b2cf9c4e4d620ce0ea1c92c50accbc8ebcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148981
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [44271f3997f2374d81a2336131fef7ac79499048]

        tdf#102261: pptx import: handle defTabSz
        
        Introduce import of defTabSz using ParaTabStopDefaultDistance.
        
        Change-Id: Ied59c2bc5d9dfffa6254ef87849c3dbad4c48d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148059
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [dffde8403e0bb81d7eb3b7853cece187e1d36c62]

        allow more than DrawingArea to report style updates
        
        Change-Id: I791e4ad45daeeb77ca25e36ae6520168b2ece044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85d23f8ce86a71c8d7d2cb34e8b790dcfc8df654]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d29743de6f11453152a00222fddf0e4dd12c2c05
          - Remove xml-lang from tags, since marked IMPLIED everywhere
            
            Change-Id: I899df40cbad5ac86d9a25c448cf9e7d6032c4401
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148987
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [2135706397d36aa7ea24650b65859be0b6860a65]

        tdf#154061 Make sure table column attributes size is correct
        
        Resize maTableColumnAttributes to match the amount of columns, fixes
        crash upon undoing a column insertion on a table
        
        Change-Id: Iad4b8ac5c38d5d1065d6ef1267ce3f5d3b28afa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148492
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [67d353ff50712a036d04b1c0ffab68f2a21b5008]

        Related: tdf#154205 skip Invalidating content a11y relations when closing doc
        
        Change-Id: If6dbc02f1ec22be9f020290572199f89548c76e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148939
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [12233f437e6299e6dcea3ee1490a80da2bef2372]

        Related: tdf#154205 avoid use of destroyed ViewShell
        
        Change-Id: Ife553269e0cdeb331931a885a3dd4f87c1c3d9bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148940
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Stephan Bergmann  <sbergman@redhat.com>  [251135b308fa7a9a5842c0abe7128311579d603b]

        Remove empty comment
        
        ...which I had added as part of 0025fa723afb9f6a0d94b9b3185ea14da18f1bd5 "Enable
        loplugin:unnecessaryparen for integer and Boolean literals", and where I
        apparently wanted to include a link but forgot to do so (and no longer know what
        link that would have been)
        
        Change-Id: I245725fea80ee0e13d76026656d433d5c42e4c19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148975
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-16  Caolán McNamara  <caolanm@redhat.com>  [89657b5309a276f6be59d74651a94132590be028]

        Resolves: tdf#153908 scrolling relationships moves the wrong direction
        
        Change-Id: Ic49e0c167a020269fa7de58ea9e1ece0b66d57ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-16  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f7475f4e14f43ba13078abef6b676be27af43e14]

        Relates tdf#154143 Add source image assets of Tips of The Day
        
        Change-Id: I6e1d881705282c7f7c219a345f61990a20c05cbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148951
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [cced51a1ed7c140276aabfe857510afb974fcef5]

        tdf#102261: introduce editeng paragraph tab stop default distance
        
        Adds mnDefaultDistance to SvxTabStopItem that if defined
        will set a paragraph wide tab stop default distance and
        override the document wide setting.
        
        Also makes editeng consider mnDefaultDistance while getting
        tab stop default distance.
        
        Change-Id: I0fa098f874d6b9c91ddbaa2634224ff55cafcc95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148058
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-16  Tor Lillqvist  <tml@collabora.com>  [910226f2916b271a496daa6920843bf8d82238a6]

        Remove false documentation
        
        There are no such duplicated constant labels in this file.
        
        Change-Id: I6352766834bf832667b5644d7507ec250932492a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148976
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [eecf80599e838a020f5e4b9bf857ccbd4ce8befd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 142696bd75353a8b1fa23c6aae08b0d18e807546
          - tdf#153560  adjust heading levels for "Up to level" and "Offset"
            
               One content change: A correction to the description of the
               "Heading" type. Other changes are neutral in relation to translation.
               * The options in the "Format" section are part of that section, so
                 they should be one level down (h2->h3) in the hierarchy.
               - remove <xml-lang>
            
            Change-Id: I1ee11c3e8c726c2a3ae2985456be40abc75813b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148962
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-16  Bayram Çiçek  <bayram.cicek@libreoffice.org>  [66d38ba8e9ccb7ba0ef5b3feb67b241a5b6b2e80]

        tdf#140226: use StaticWhichCast in htmlatr.cxx
        
        Change-Id: If7694d45827630ec690004d4fd2c5fbacbc46f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148541
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d14a83bf989d09e27ab3b787f4d3dcac087c9f0d]

        move getCorrectedMissingValueTreatment inside chart2::Diagram
        
        and also switch to using getFastPropertyValue
        
        Change-Id: I0c6617841a364ccb8e1c7b624e1ef6fde28426d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Uday Sharma  <itsudayy@gmail.com>  [0d8d0fb8932652f182c46805d5cf3ae7f6ebadd5]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I6898acbf7c6c9de45bbfa6a32202acf302f92caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146822
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-16  Stephan Bergmann  <sbergman@redhat.com>  [c7aee57724828c4b9d67deb930f09c494ff4d811]

        Adapt loplugin:implicitboolconversion to _G_STR_NONNULL
        
        ...from glib2-devel-2.76.0-1.fc38.x86_64, causing
        
        > libreofficekit/source/gtk/lokdocview.cxx:390:28: error: implicit conversion (IntegralCast) from 'bool' to 'int' [loplugin:implicitboolconversion]
        >     pLOEvent->m_pCommand = g_strdup(pCommand);
        >                            ^~~~~~~~~~~~~~~~~~
        > /usr/include/glib-2.0/glib/gstrfuncs.h:212:35: note: expanded from macro 'g_strdup'
        >         const char *const __str = _G_STR_NONNULL (___str);                    \
        >                                   ^~~~~~~~~~~~~~~~~~~~~~~
        > /usr/include/glib-2.0/glib/gstrfuncs.h:157:34: note: expanded from macro '_G_STR_NONNULL'
        > #define _G_STR_NONNULL(x) ((x) + !(x))
        >                                  ^~~~
        
        Change-Id: Iec20b20992a61fd48155f338a10dc313411448f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148948
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-16  Michael Stahl  <michael.stahl@allotropia.de>  [9070c1b0404fb72d2553f6fa8f702e70c0abb269]

        xmloff: ODF export: produce alt text and description for MediaShape
        
        ... and others where it was inexplicably missing (PluginShape,
        AppletShape, FrameShape).
        
        Change-Id: Idf1c44488370a81bc90fb316ab6056994d782a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148917
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-16  Michael Stahl  <michael.stahl@allotropia.de>  [529afed0ba3ca5e659cea661816e9164846630e8]

        tdf#39667 filter,officecfg: PDF export dialog: set initial view to...
        
        ... Outline for PDF/UA.
        
        * change the dialog to disable the radio buttons if PDF/UA is enabled
        * also change the configuration to make Outline the default
        
        Change-Id: Iea8c5e0f8560c972dc250859198bea1cb9fc3597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148883
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-16  Miklos Vajna  <vmiklos@collabora.com>  [7a7eb4aa21ca0c83db825fe8d5a5278611b391d8]

        sw: fix undo comment of FN_DELETE_BOOKMARKS
        
        It's bookmarks, not bookmark. One has to dispatch .uno:DeleteBookmarks
        to see this in action, which does something if the document already
        contains at least one bookmark.
        
        Change-Id: I7678f6bc6a00a95cfd4ecc87e97e8db6d469216d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148945
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [1916d161902bdd52b8cfa5b29153c8f8c39fce52]

        De-static-izing colors in SwViewOption
        
        The view colors in SwViewOption were static which means that two
        separate views couldn't have different colors
        
        Change-Id: Id595b00ba56bdb210ad1a784cf76e99ead0d6014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148481
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-16  Miklos Vajna  <vmiklos@collabora.com>  [ee8e9b993595e728f827a5fe6ab1ae5fb1f6aaae]

        sw floattable, legacy: restrict height when using bottom margin area
        
        The bugdoc was 1 page in Writer, but 2 pages in Word. There the entire
        3rd row went to the next page.
        
        The problem seems to be that the legacy mode in Word seems to allow
        going to the bottom margin only in case the height of the floating table
        still fits the body frame height, while we simply allowed the usage of
        the bottom margin area unconditionally.
        
        Fix this by extending GetFlyAnchorBottom() to explicitly check for the
        body frame height.
        
        Note that this doesn't solve cases where the current height fits the
        body frame, but the new bottom won't; that still needs fixing in a
        follow-up commit.
        
        Change-Id: Ic55b93e7b53fc45a837c3245c0091f2c93d028aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148944
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2867ac604937abf88c553341fcdd7e7abb7698c]

        XmlTestTools: factor out common code
        
        Change-Id: Ie212c86c6c0ac20878be88d88ade5eb1c989942d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148935
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-16  Michael Weghorn  <m.weghorn@posteo.de>  [c379f1b978c3ad4578c130675c1e0a82c70823c0]

        tdf#140762 tdf#152671 Make dock win visible before showing popup
        
        The fact that the docking window got hidden (in
        `ImplPreparePopupMode`) and only shown again
        after starting popup mode for the containing
        floating window meant that the docking window
        and its children were still invisible when
        starting popup mode.
        Therefore, they would also not be
        considered/returned as accessible children
        when listeners are registered for accessible
        children in winaccessibility's
        `AccTopWindowListener::AddAllListeners`.
        As a consequence, no a11y events would be
        sent when they receive keyboard focus and they
        would not be announced by the NVDA screen reader.
        
        Make them visible again *before* starting
        popup mode for the floating window.
        This e.g. makes NVDA announce popups in the toolbar
        or the Calc autofilter dropdown.
        
        Change-Id: I6953e4b491db4708ba30fb98173d13391d6e0461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148933
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-16  Baole Fang  <baole.fang@gmail.com>  [80d5d2eb70fd84e98cbe19cd4363d12d50ec31f6]

        tdf#153683: Show the used module in --convert-to
        
        Implements getName that returns the module name.
        When outputs the convert-to message, module name is included.
        
        Change-Id: Ic18d8899d160e9c1afa8801dc07120f5ef822d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [dcf65e4ce94840ea2072eb968a30c81ded0f21cf]

        use more OUStringLiteral in chart2::ObjectIdentifier
        
        Change-Id: I9387b6f5f65c030a6ddea47b34927b613533ff26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148913
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [61ed494b4acd7664c03a19577c67c9b2c2dec59a]

        convert DiagramPositioningMode to scoped enum
        
        Change-Id: I235a9e8bc4fa5406ff71f70c65038127716d58e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148907
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-15  Michael Weghorn  <m.weghorn@posteo.de>  [1aeacf54bf6c961d89678e961c747ff76d867c5f]

        tdf#153167 Re-add ImageMap Editor dialog title again
        
        Essentially reapply
        
            commit 66291d467be4bf0e841814111d57d1af76117f8e
            Date:   Mon Jan 23 12:15:50 2023 -0600
        
                tdf#153167 ImageMap Editor dialog had no title
        
        after it has been reverted in
        
            commit a90ef17809071b808a8c703e7e47e045ddabcd4a
            Date:   Tue Jan 24 08:36:48 2023 +0000
        
                Revert "tdf#153167 ImageMap Editor dialog had no title"
        
                This reverts commit 66291d467be4bf0e841814111d57d1af76117f8e.
        
                Reason for revert: didn't wait for jenkins and broke the build
                translatable strings need context attribute.
        
        , but this time add the required context attribute
        as well, as it used to be before
        
            commit 8a35ae3e6c5c45aa1426cfd81472b309d02a1b48
            Date:   Thu May 16 15:17:38 2019 +0100
        
                weld SvxIMapDlg
        
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Change-Id: Id777e457fe144b0f0746cfc19e7e13e6db7a89a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148914
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [5377a98c2cb78b0768d469ff379f9add9aaa7b68]

        Silence some false -Werror=dangling-reference
        
        ...seen at least with gcc-c++-13.0.1-0.7.fc38.x86_64,
        
        > connectivity/source/manager/mdrivermanager.cxx: In lambda function:
        > connectivity/source/manager/mdrivermanager.cxx:621:41: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
        >   621 |                     const DriverAccess& ensuredAccess = EnsureDriver(m_xContext)(driverAccess);
        >       |                                         ^~~~~~~~~~~~~
        > connectivity/source/manager/mdrivermanager.cxx:621:81: note: the temporary was destroyed at the end of the full expression ‘drivermanager::{anonymous}::EnsureDriver(this->drivermanager::OSDBCDriverManager::m_xContext).drivermanager::{anonymous}::EnsureDriver::operator()((* & driverAccess))’
        >   621 |                     const DriverAccess& ensuredAccess = EnsureDriver(m_xContext)(driverAccess);
        >       |                                                         ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
        
        and
        
        > vcl/source/window/layout.cxx: In function ‘array_type assembleGrid(const VclGrid&)’:
        > vcl/source/window/layout.cxx:952:30: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
        >   952 |             const GridEntry &rEntry = A[x][y];
        >       |                              ^~~~~~
        > vcl/source/window/layout.cxx:952:45: note: the temporary was destroyed at the end of the full expression ‘boost::multi_array_ref<T, NumDims>::operator[](index) [with T = {anonymous}::GridEntry; long unsigned int NumDims = 2; reference = boost::detail::multi_array::sub_array<{anonymous}::GridEntry, 1>; index = long int](((boost::multi_array_ref<{anonymous}::GridEntry, 2>::index)x)).boost::detail::multi_array::sub_array<{anonymous}::GridEntry, 1>::operator[](((boost::detail::multi_array::sub_array<{anonymous}::GridEntry, 1>::index)y))’
        >   952 |             const GridEntry &rEntry = A[x][y];
        >       |                                             ^
        > vcl/source/window/layout.cxx: In function ‘void calcMaxs(const array_type&, std::__debug::vector<VclGrid::Value>&, std::__debug::vector<VclGrid::Value>&)’:
        > vcl/source/window/layout.cxx:1075:30: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
        >  1075 |             const GridEntry &rEntry = A[x][y];
        >       |                              ^~~~~~
        > vcl/source/window/layout.cxx:1075:45: note: the temporary was destroyed at the end of the full expression ‘boost::multi_array_ref<T, NumDims>::operator[](index) const [with T = {anonymous}::GridEntry; long unsigned int NumDims = 2; const_reference = boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>; index = long int](((boost::multi_array_ref<{anonymous}::GridEntry, 2>::index)x)).boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>::operator[](((boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>::index)y))’
        >  1075 |             const GridEntry &rEntry = A[x][y];
        >       |                                             ^
        > vcl/source/window/layout.cxx:1106:30: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
        >  1106 |             const GridEntry &rEntry = A[x][y];
        >       |                              ^~~~~~
        > vcl/source/window/layout.cxx:1106:45: note: the temporary was destroyed at the end of the full expression ‘boost::multi_array_ref<T, NumDims>::operator[](index) const [with T = {anonymous}::GridEntry; long unsigned int NumDims = 2; const_reference = boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>; index = long int](((boost::multi_array_ref<{anonymous}::GridEntry, 2>::index)x)).boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>::operator[](((boost::detail::multi_array::const_sub_array<{anonymous}::GridEntry, 1, const {anonymous}::GridEntry*>::index)y))’
        >  1106 |             const GridEntry &rEntry = A[x][y];
        >       |                                             ^
        
        Change-Id: I498bb468ade52f83117c8cf57f8d64697978d9ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148921
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Eike Rathke  <erack@redhat.com>  [2fd915b7d2d2a9e25600a07587ab01d23bffbc58]

        Related: tdf#152943 Test that a quiet NaN payload is propagated
        
        Change-Id: Ib98b507db9305ed20e3000f7f457a135a3bb3836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148936
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [ebaccbd0acc41bfb6c1a1321656679b18026d983]

        avoid font replacement in test
        
        Change-Id: Id3ec97f0859cf7c702ad0a501c2431af1df997d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148923
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [edf9d231dd5dc197aeb627bb0712dbc0db37f42e]

        Resolves: tdf#154169 tree lines not visible in macOS dark mode
        
        or kf5, a collision in expectations between
        
        commit db6fbb0317fcb0a7babca9f71adbbb7c126b9e4e
        Date:   Tue Feb 14 08:56:13 2023 +0000
        
            base section Titles are invisible in dark mode
        
        and
        
        commit 5f9cd841a22fa7eb6f29ca8b9a35a8b016fb3d56
        Date:   Thu Oct 13 22:03:27 2022 +0200
        
            tdf#144587 Fix lines in treelists using dark mode
        
            As reported by the user, the lines in a treelist are dark over a dark background. This patch fixes that.
        
        where db6fbb0317fcb0a7babca9f71adbbb7c126b9e4e basically undid the
        work of 5f9cd841a22fa7eb6f29ca8b9a35a8b016fb3d56 making the tree
        lines indistinct again when making the base heading distinct
        
        I think "LightColor" and "ShadowColor" etc should be thought of from the
        perspective of the expectations of the original "Light Mode" and
        "LightColor" is basically close to the window/canvas background and
        "ShadowColor" basically close to the the text foreground color, so
        "LightColor" is something close to Black in "Dark Mode" and not
        typically suitable for drawing on the default background, while
        "ShadowColor" is something close to White in "Dark Mode" and suitable
        for use on the default background.
        
        also drop restoring the line color with
        rRenderContext.SetLineColor(aOldLineColor);
        because the Push(...LINECOLOR), Pop() does that automatically
        
        Change-Id: Ic08a8563f41f892c75a08195c04cd9b9c2abf4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [797938b7bb897617a078fc7e57de27759a00ed07]

        SwModelTestBase: factor out common code
        
        Change-Id: Iab415dadd3bc465d31bf14cbe2f384b9588466a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148929
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-15  Eike Rathke  <erack@redhat.com>  [48fac1585feaad3982c2bf4ec2f831d53def21b7]

        Resolves: tdf#154031 Add Rohingya Hanifi {rhg-Rohg-MM} [0x06B1] CTL, RTL
        
        Change-Id: Icb18349ceb4614e777bed15bbc2108e85a0db54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148911
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [7c66d037b09238709d78206431cf487443633787]

        cid#1522014 Dereference null return value
        
        Change-Id: I9c5b48ececd6be84d8f1a3c4a45b02d81641736e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [a84a15eadc4ff5b142811117f548170f4a9d81ee]

        cid#1521990 silence Unchecked return value
        
        Change-Id: I7833b6ab19334ea17f5210a0381109aa55d6efd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [97b84d31a1db2ec690d180effad307f331d62fb9]

        tdf#154129 tdf#78590 writerfilter framePr: deduplicate grabbag
        
        Well, not really deduplicate, because it only existed once.
        But I can't imagine why it would depend on a parent style.
        
        It was added with commit 1c876f5616522ab695de8c0316cdb0c601081815
        Author: Rohit Deshmukh on  Fri Jun 13 11:39:56 2014 +0530
        fdo#78590: Fix for Corruption of para with framePr & drawing object into para
        
        Typically only RTF files don't have a parent style,
        so the lack of it being there in the "else" clause
        likely wouldn't have been noticed.
        
        Change-Id: I36828863f9bc9b51fbd7c019d3865ac477662795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148816
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [b1194e42dde6e3749631a6510d9e7b969e5eae8e]

        tdf#154129 writerfilter framePr: deduplicate BackColorTransparency
        
        Well, not really deduplicate, because it only existed once.
        
        Added long ago with commit 4ac48167662c592c21025b89fe8f6925c680c6e0
        Author: Miklos Vajna on Mon Feb 20 15:46:08 2012 +0100
            n#695479 fix rtf/docx import of transparent frames
        
        However, it didn't handle the situation where
        {\stylesheet{\fs19\lang1033 \snext0 Normal;}}
        was missing. In that case there is no "Normal"
        paragraph style to inherit from, and thus his fix is also
        needed in the no-style case.
        
        make CppunitTest_sw_rtfexport3 \
            CPPUNIT_TEST_NAME=testTdf154129_transparentFrame
        
        Change-Id: Iaa5b92cd626192d44d11c1365b9b483bd46dff9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148815
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [d21ba804040bdb275234254fbbe742ce830420c2]

        tdf#154129 tdf#97128 writerfilter framePr: deduplicate PopFrameDirection
        
        Well, not really deduplicate, because it only existed once.
        But I can't imagine why it would depend on a parent style.
        
        Recently added with 7.1 commit af4e5ee0f93c1ff442d08caed5c875f2b2c1fd43
        Author: Daniel Arato (NISZ) on  Wed Sep 16 08:48:32 2020 +0200
            tdf#97128 DOCX import: fix frame direction
        
        Typically only RTF files don't have a parent style,
        so the lack of it being there in the "else" clause
        likely wouldn't have been noticed.
        
        Change-Id: I8e561dcfc5a1dfc6ac1979ad4226b6c5f35800d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148814
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [2386279c4f0d91dc0758157578ecf62ae9e1ceaa]

        tdf#117037: svl_qa_cppunit: Add unittest
        
        Change-Id: I707f1a5402189a2453f5d11beb4e1c493699e28b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148909
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [effc64f238bf0832229b7043dc8497a9cce5548a]

        Simplify AcceptsURL
        
        Change-Id: I14cd7d6bce2d5d5160e21b4fd12dcb77572925b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148922
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [949b2bbbaaa9bd21b6882dab49ea2018a08d2362]

        tdf#146984 writerfilter inline_inline: no break in shape
        
        Change-Id: I94efea80df1fee9ecd338bfec3430edfdf418e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148918
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  NirnayK  <nirnaykorde@gmail.com>  [158be75c71a2a22f108685bc03c64dbac77e9b73]

        tdf#114441: Convert use of sal_uLong to better integer types
        
        In tp_AxisPosition.cxx the sal_uLong has been changed to sal_uInt32 as the GetValue returns a 32 bit integer
        In outliner.cxx the sal_uLong is converted to sal_uInt64 as the the sum of 2 sal_uInt32 might exceed 32 bits
        
        
        Change-Id: I560faf952520078f6a0747dfdec8a3039927e5c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148335
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d024174dcb95c86400f47556738d092487ce429]

        move getDiagramPositioningMode inside chart2::Diagram
        
        and also switch to using getFastPropertyValue
        
        Change-Id: Idef712def160abb500770aceedf6d94d385e5da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [720c77bdb53a83a276f423c75ee163d7c1b191ca]

        Fix typo
        
        Change-Id: I0688bd287f09aa5d963436f8b934897c9368636d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148912
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [a777dab7544bd11c26ae26c40cce49ab976dab2d]

        tdf#154129 tdf#73546 writerfilter framePr: fix/deduplicate w:v/hSpace
        
        This is not quite a No Functional Change commit.
        
        Now, the difference between the two clauses that I am calling
        deduplicated is rather severe in this case.
        But that seems to be because only one half was fixed with
        4.3 commit 896714db527f39497aedee8946964e5acd73778c
        Author: umeshkadam on Fri Jan 17 19:00:29 2014 +0530
            fdo#73546 : faulty value of attribute value in <wp:anchor> tag
        
        So I expect that the "else" side is simply wrong.
        That side is generally only hit by RTF formatted files
        (or docx that are basically missing styles.xml).
        
        Change-Id: Id0fd4f4807c38f281d2fbf8f805a49d6ae9acc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148813
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [4237db7f43c08efbf166a2bfa8a0c99d1c5f04a4]

        NFC tdf#154129 writerfilter framePr: deduplicate lcl.. call
        
        Change-Id: Iedaea9d6d6f344ebd66bf83d1a9ee243cae5875b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148812
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [33ce22f080bbedfde78fdc907b0d4d5bd0f68f14]

        tdf#154129 writerfilter framePr: deduplicate w:wrap
        
        This is not quite a No Functional Change commit.
        
        Likely it was a mistake that this was different for no-parent style.
        Ahh, yes. commit 3eda8234acf09cd5a31cdcde76f04631a51fcc37
        Author: Caolán McNcNamara on Thu Apr 27 15:25:20 2017 +0100
            Resolves: tdf#107411 LibreOffice hangs at RTF import time
        made the change to only one half.
        
        Basically only RTF format ever has no "parent style",
        so this should be a rather safe change to make.
        
        MAKE_FIXED_SIZE is ENUM_MAX which would be
        define SAL_MAX_ENUM 0x7fffffff.
        
        Change-Id: I72ebfbdfbf656450068339326ad2a182d56b291f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148811
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [aa428c26b9476ab450f3987d95b3c1968b738dee]

        ofz#55729 Out-of-memory
        
        Change-Id: I16713a23093483041e9ac03a7fe6cc3e2960ac31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148915
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [7c954d09f70d262d44b2c63fff3376dc89722c60]

        Add SwTable::SwitchFormulasToInternalRepresentation
        
        - and get rid of most of the TBL_BOXPTR stuff it replaces
        - instead of using a TBL_BOXPTR on UpdateTableFields
          SwTable::SwitchFormulasToInternalRepresentation should
          be used
        - TBL_BOXPTR is not used via UpdateTableFields anymore and
          an assert assures it will never be
        
        Change-Id: I56eca0e339e0d87a60009ea4dd53f4fe96fe639a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148249
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [5c04c4474236cc50009aea6d89f7c443c861af19]

        tdf#40142 - Consider level settings of the various text nodes
        
        Consider level settings of the various text nodes when creating a TOC
        from custom styles.
        
        Change-Id: I70759f9bcf63e8591ce89bc71afabb1da0c2f29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148886
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-15  Yousef_Rabia  <yousef.mohamed.rabia@gmail.com>  [08c283d63fa648f3db1ab6dddf9edb73f0c7194e]

        tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctor
        
        Change-Id: I37b5056026f29d2619a4f9d3da9251924c7f5fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148898
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Julien Nabet  <serval2412@yahoo.fr>  [fcbf416dffdc8a9fbbbc41c07bfb4929a14c7099]

        tdf#129547: Ctrl-":" to insert time in Calc for French UI with azerty
        
        Change-Id: Icc6a73494ba350837779b4e3c9620fd389730e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148903
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-15  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [02c352d7fdb01e7b4899cbd3c5d62b81019ddb15]

        tdf#152959 sw: allow lowercase unicode literal for soft hyphen
        
        Change-Id: If0cd7a07badf9f518ca697beb065e26b48a64abf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145662
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7e678312f0832eed67595b7300047f60c6b1c253]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4be597da538b8cdb54f1f12fedfd940a1fa9c60e
          - tdf#82254 - Add UTF-8 BOM (Token 14) to CSV filter parameters
            
            Change-Id: I085e66ca6b46955110a4eaab7118c4a376f16b40
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148871
            Tested-by: Jenkins
            Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
            
2023-03-15  Caolán McNamara  <caolanm@redhat.com>  [ac442dc11247a9f794056cfb7d6cff5cd8400717]

        set the background color of the valueset during format
        
        so that it will change when the theme changes
        
        Change-Id: I20cc8434a75a1cfebef274d27a86cacc91b1e7d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [2d331e6bfe8c9ca31f1a4e092dbcffb8919b8655]

        tdf#154129 writerfilter framePr: deduplicate w:vAnchor
        
        This is not a No Functional Change commit.
        
        However, it seems that pretty much only RTF
        fails to typically have styles defined,
        since even an unspecified "Normal" style is checked.
        
        That means that in all but the most bizarre cases,
        the "no style" case would never be reached anyway.
        That really eliminates any worries about the deduplication going bad.
        
        In any case, I can't see any reason why the same qualification
        is not made if there is no parent style involved.
        
        make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287
        make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287B
        
        Change-Id: Ied79f83dcd18304ae0d86c0b7843cd36a532ae93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148810
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [070e62bad980cbe15dfbe9096a5e5d962a70f07c]

        tdf#154129 writerfilter framePr: deduplicate w:hAnchor
        
        This is not quite a No Functional Change commit.
        
        If there was no anchor specified, and no parent style,
        then no property was written at all.
        
        Basically only RTF format ever has no "parent style",
        so this should be a rather safe change to make.
        
        Change-Id: Ibeecd489deb876c64a2ba6ca2b700e4a03dbd316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148809
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [611288b64548762e0731ed6323e1653e4fca2317]

        tdf#154129 writerfilter framePr: deduplicate w:y
        
        This is not quite a No Functional Change commit.
        In the previous code, a zero value for Y was not added as a property
        if there was no parent style.
        
        Basically only RTF format ever has no "parent style",
        so this should be a rather safe change to make.
        
        I've done the same thing for others as well.
        
        Change-Id: I4a7ecb194ad8cbedf6d1b5c66cac7b10a1532b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148808
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [1188fa78d0e7b5fd8f4c7c207fd4ec9ced666c12]

        tdf#154129 writerfilter framePr: deduplicate w:x
        
        This is not quite a No Functional Change commit.
        In the previous code, a zero value for X was not added as a property
        if there was no parent style.
        
        Basically only RTF format ever has no "parent style",
        so this should be a rather safe change to make.
        
        I've done the same thing for others as well.
        
        Change-Id: Iaf4eb45b3adae88622fa9be16b5237db101a631e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148807
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [f2a10d9e751bdbc4ba981b6ca9d0dc127439a3c2]

        tdf#154129 writerfilter framePr: nhRule obey comment instructions
        
        The comment says
        "[MS-OE376] Word uses a default value of "atLeast" for
         this attribute when the value of the h attribute is not 0."
        
        But the code was setting MIN even when the attribute was 0.
        I think that was a mistake.
        
        Errata documentation confirms:
        "The standard states that 0 is a valid value of the h attribute.
        HOWEVER Word treats a value of 0 on this attribute as a value of auto."
        
        // The height of the object is determined by the content only.
            const short SizeType::VARIABLE = 0;
        
        Change-Id: I1a74da6c5cd25024aba82a68238580a7ca90c9c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148806
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [af8f05f859a1fb61d88dfe558d1bc7a8282c792a]

        tdf#154129 writerfilter framePr: deduplicate w:h
        
        This is not quite a No Functional Change commit.
        In the previous code, a zero value for H was not added as a property
        if there was no parent style.
        
        However, it seems that pretty much only RTF
        fails to typically have styles defined,
        since even an unspecified "Normal" style is checked.
        (fdo77890.docx also followed the "else" path
         because it basically had an empty styles.xml file.)
        
        That means that in all but the most bizarre cases,
        the "no style" case would never be reached anyway.
        That really eliminates any worries about the deduplication going bad.
        
        In any case, it makes it the same as width (and most DOCX files)
        which had been doing this in the first place.
        
        For consistency and code simplicity I'll go ahead with the change.
        
        Change-Id: I65eed50ba83397284f21bb20ef3bbf10e02cce04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148805
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [1a12246fc1deaaf1e2c723c0c541de85cf88101e]

        NFC tdf#154129 writerfilter framePr: deduplicate w:w
        
        This should be a No Functional Change.
        
        I had a unit test error deduplicating the combined patch
        (in combination with Hori/VertOrient) but not now.
        And I don't see any differences
        (even after a git reflog/git cherry-pick)
        and yet the unit test failure was consistent over three tries...
        
        Change-Id: I00f5290590fe51c68d1e3e65df1f172252655feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148804
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [fb8522e457b098b5ade98a4a4babbc8704d3fad4]

        NFC tdf#154129 writerfilter framePr: deduplicate Hori/VertOrient
        
        This patch should be a No Functional Change
        
        I had a unit test error in an earlier combined patch
        so it seemed better to split deduplication up into smaller chuncks
        and make the change incrementally.
        
        Change-Id: Ie6eeaca07fd5d4fd5bc312f131851ceda5cc3647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148803
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [6eb483d3f27e3ee8c56d422fb96f83844370d325]

        tdf#154129 writerfilter framePr: remove last use of pParaStyle
        
        Now that everything is using vProp, pParaStyle can be removed.
        
        Although there could conceivably be a minor logic flow difference
        (in case a specified style had no properties == early return)
        I'm pretty sure that that would actually cause errors,
        so this should be better.
        
        Change-Id: I5079732ebd2b822bea40929c5b4899b8551324e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148719
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [2ab9a2e4166264be83300e7ed038be1b803a5ac8]

        tdf#154129 writerfilter framePr: check whole style inheritance: v/hSpace
        
        This patch depends on HAnchor, which created vProps.
        
        A style can inherit its properties from another style,
        but the code was naively just checking the first paragraph style,
        and not any of the parents.
        
        There were no existing sw.check tests where the old and new method
        produced different values.
        
        Change-Id: I66ea366fae933c29587aa0fa9fff3abab6d8666b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148718
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-15  Noel Grandin  <noelgrandin@collabora.co.uk>  [5f661a23346858c6162356d92a9f026f288ce31d]

        BaseMutex->std::mutex in CWinClipboard
        
        Change-Id: Icabb28d58af5a1e2c5f44513fbbe18da3fd69b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [e149f038b6179ac94a613676fb0b1b475541313b]

        Bump dconf minimum version requirement
        
        At least building on Fedora 37 with dconf-devel-0.40.0-7.fc37.x86_64 against
        recent LLVM 17 trunk libc++ started to fail now with
        
        > In file included from configmgr/source/dconf.cxx:25:
        > In file included from /usr/include/dconf/dconf.h:23:
        > In file included from /usr/include/dconf/common/dconf-enums.h:23:
        > In file included from /usr/include/glib-2.0/glib.h:34:
        > In file included from /usr/include/glib-2.0/glib/gasyncqueue.h:34:
        > In file included from /usr/include/glib-2.0/glib/gthread.h:34:
        > In file included from /usr/include/glib-2.0/glib/gatomic.h:30:
        > In file included from /usr/include/glib-2.0/glib/glib-typeof.h:44:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/type_traits:430:
        > ~/llvm/inst/bin/../include/c++/v1/__type_traits/aligned_union.h:23:1: error: templates must have C++ linkage
        > template <size_t _I0, size_t ..._In>
        > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > configmgr/source/dconf.cxx:19:1: note: extern "C" language linkage specification begins here
        > extern "C" {
        > ^
        
        because the missing extern "C" has meanwhile been added to upstream dconf with
        <https://gitlab.gnome.org/GNOME/dconf/-/commit/f860ddcc6a501b982d82c5630c73936bd611ad8a>
        "common: Add missing G_BEGIN/END_DECLS" towards tag 0.40.0.
        
        So the easiest fix here appears to be to bump our requirements to that dconf
        version 0.40.0:  The one case I'm aware of that explicitly wants dconf support
        is downstream Fedora and RHEL builds, which already have dconf 0.40.0
        (cf. most recent
        <https://src.fedoraproject.org/rpms/dconf/blob/a9987b0abe15133d091bcd390fd33077881567ae/f/dconf.spec#_4>
        for f37 and most recent
        <https://gitlab.com/redhat/centos-stream/rpms/dconf/-/blob/1bb6b46da242b75e5e1864f5c97ab6e592ca60ba/dconf.spec#L4>
        for e9s).  On the other hand, the TDF Linux release builds are done with an
        explicit --disable-dconf in distro-configs/LibreOfficeLinux.conf (since
        ecc617e797aa5ed329668114e54ec7ffa5c0e87b "configmgr: support reading from a
        dconf layer (WIP)") and the Flatpak builds on Flathub are done against an
        org.freedesktop.Sdk//22.08 where no dconf support is detected at all (for the
        most recent LO 7.5.1 build on Flathub see
        
        > checking for DCONF... no
        > checking whether to enable dconf... no
        
        at <https://buildbot.flathub.org/#/builders/5/builds/3184/steps/8/logs/stdio>
        for aarch64 and at
        <https://buildbot.flathub.org/#/builders/5/builds/3184/steps/8/logs/stdio> for
        x86_64).
        
        Change-Id: I559d2ac8712dbe2b40c9b881314b88d1cc8eaf43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148887
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [7a21cba913fe99ea11e0b6a9d4b1e61cf677f2e1]

        Silence -Werror=deprecated-declarations for now
        
        ...as seen with gtk4-devel-4.10.0-3.fc38.x86_64,
        
        > avmedia/source/gtk/gtkplayer.cxx: In member function ‘virtual com::sun::star::uno::Reference<com::sun::star::media::XPlayerWindow> avmedia::gtk::GtkPlayer::createPlayerWindow(const com::sun::star::uno::Sequence<com::sun::star::uno::Any>&)’:
        > avmedia/source/gtk/gtkplayer.cxx:358:20: error: ‘void gtk_widget_show(GtkWidget*)’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead [-Werror=deprecated-declarations]
        >   358 |     gtk_widget_show(m_pVideo);
        >       |     ~~~~~~~~~~~~~~~^~~~~~~~~~
        > In file included from /usr/include/gtk-4.0/gtk/gtkapplication.h:27,
        >                  from /usr/include/gtk-4.0/gtk/gtkwindow.h:33,
        >                  from /usr/include/gtk-4.0/gtk/gtkaboutdialog.h:30,
        >                  from /usr/include/gtk-4.0/gtk/gtk.h:34,
        >                  from avmedia/source/gtk/gtkplayer.cxx:28:
        > /usr/include/gtk-4.0/gtk/gtkwidget.h:273:12: note: declared here
        >   273 | void       gtk_widget_show                (GtkWidget           *widget);
        >       |            ^~~~~~~~~~~~~~~
        > avmedia/source/gtk/gtkplayer.cxx:359:20: error: ‘void gtk_widget_show(GtkWidget*)’ is deprecated: Use 'gtk_widget_set_visible or gtk_window_present' instead [-Werror=deprecated-declarations]
        >   359 |     gtk_widget_show(pParent);
        >       |     ~~~~~~~~~~~~~~~^~~~~~~~~
        > /usr/include/gtk-4.0/gtk/gtkwidget.h:273:12: note: declared here
        >   273 | void       gtk_widget_show                (GtkWidget           *widget);
        >       |            ^~~~~~~~~~~~~~~
        
        Change-Id: I1cb2988cec6cda3dd3e43a3773647a3ddaf211e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148899
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b7be39c5f45f8268acd9e19c3abd731fee6dcca3]

        CppunitTest_sc_ucalc_formula: split in two
        
        it already has 118 tests
        
        Change-Id: I13d6fe65aca2fa01cf115c5873b9ca853cf5e77b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148891
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [633b9aebf8ac50f5e46e70f9f371fe7b936e0e1d]

        Silence a false -Werror=maybe-uninitialized
        
        ...seen at least with gcc-c++-13.0.1-0.7.fc38.x86_64,
        
        > In file included from include/test/bootstrapfixture.hxx:20,
        >                  from include/test/unoapi_test.hxx:18,
        >                  from include/test/unoapixml_test.hxx:15,
        >                  from sd/qa/unit/sdmodeltestbase.hxx:15,
        >                  from sd/qa/unit/import-tests2.cxx:12:
        > sd/qa/unit/import-tests2.cxx: In member function ‘void testTdf152186::TestBody()’:
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:274:33: error: ‘bHasShadow’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   274 |   ( CPPUNIT_NS::Asserter::failIf( !(condition),                                   \
        >       |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   275 |                                  CPPUNIT_NS::Message( "assertion failed",         \
        >       |                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   276 |                                                       "Expression: " #condition), \
        >       |                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   277 |                                  CPPUNIT_SOURCELINE() ) )
        >       |                                  ~~~~~~~~~~~~~~~~~~~~~~~~
        > sd/qa/unit/import-tests2.cxx:86:9: note: in expansion of macro ‘CPPUNIT_ASSERT’
        >    86 |         CPPUNIT_ASSERT(!bHasShadow);
        >       |         ^~~~~~~~~~~~~~
        > sd/qa/unit/import-tests2.cxx:80:10: note: ‘bHasShadow’ was declared here
        >    80 |     bool bHasShadow;
        >       |          ^~~~~~~~~~
        
        Change-Id: Ia6409c9558a6e76981a738fdf29fd6a23c440255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148900
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Stephan Bergmann  <sbergman@redhat.com>  [5d323ee3c765a8767f988d8a7cc26466d0019d20]

        Silence a false warning also for GCC 13
        
        ...as it still hits at least with gcc-c++-13.0.1-0.7.fc38.x86_64
        
        Change-Id: I25f48c241cec17d277c2ff6d4216ee63fdcfc6e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148901
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [69b0fa8a6267a1fa77e77405000f42e8aeba5fa0]

        Use officecfg instead of SvxDeeplOptions
        
        Change-Id: I977d9be45fa17b960cccb0915c5f2762bf11288f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c95bfc87ce4e229a93cb69325d815404a9883f20]

        Use officecfg instead of SvtTabAppearanceCfg
        
        but we need to keep a small chunk of logic which is used by two
        different classes
        
        Change-Id: I57390144eae2ecdb49b5b2ca3f4ce1fbc3d69420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-15  Eike Rathke  <erack@redhat.com>  [5dcb09deb81379235ad81d17e95efce3cd34143e]

        Use #REF! error in INDEX()
        
        Also PopError() in case of unexpected stack type before
        PushError() to propagate a possible earlier error.
        
        Change-Id: Ia97c1b807c4c1b6c2403fd608b45e22fa26b4843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148902
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-15  Baole Fang  <baole.fang@gmail.com>  [20c7df24b2df57f4bbd62d08cc759ad62d6512ce]

        Refactor InchesToPoints in Calc
        
        Change-Id: I379e41ce0a16e1e02b2e4426525657c751e945dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148890
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [44837a12d12be3e525fa48b37c3dd2553cc97d94]

        tdf#154129 writerfilter framePr: check whole style inheritance: wrap
        
        This patch depends on HAnchor, which created vProps.
        
        A style can inherit its properties from another style,
        but the code was naively just checking the first paragraph style,
        and not any of the parents.
        
        There were no existing sw.check tests where the old and new method
        produced different values.
        
        Change-Id: Ifdd4b5f9eefdc1f53e472c1bb5d19b526e00ee38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148717
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-15  Justin Luth  <justin.luth@collabora.com>  [828fde37632a5bb0542b6925454690a5287d6490]

        tdf#153613 tdf#146984 writerfilter: split para after anchors
        
        Even though the w:br occurs in the paragraph before the anchors,
        the anchors stay on the first page, and don't move to the second page
        (unless it is the last paragraph in the section/document,
        which is not yet handled.)
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak3
        
        Change-Id: Icfc7e2a5d7657f1eb8f94263a4bfc8dcca7e52de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148897
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5da513c1f34f657f910d2a9d1af7761cf649574f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 87ab9fc48e05a39caf563be8f171d0ed737c50f7
          - tdf#153890  "apply to all similar texts" -> "apply to all other occurrences"
            
                plus remove <xml-lang>
            
            Change-Id: Id2a01e490cbae4c7a378d0d7834a0c7edbac97d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148868
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-14  Justin Luth  <justin.luth@collabora.com>  [6f1052da8d145b1176186024dc4745cbd561fe36]

        tdf#154129 writerfilter framePr: check whole style inheritance: hRule
        
        This patch depends on HAnchor, which created vProps.
        
        A style can inherit its properties from another style,
        but the code was naively just checking the first paragraph style,
        and not any of the parents.
        
        There were no existing ooxmlexport tests where the old and new method
        produced different values.
        
        Change-Id: I8648ec7abce5943be4850ec0f2dd054cd9ce1a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148716
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fc389f6bfb524c6e7a3aedbe4c4ff1bb8ec1ec40]

        tdf#153890  "similar texts" -> "other occurrences" + tooltip
        
        Change-Id: I95e7fa7334093e5358d1191e42328367e7e8df74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148861
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-14  Patrick Luby  <patrick.luby@collabora.com>  [b0b8815fffcd1d3862a4784fe93bb7c9d66b7d1c]

        Handle pasting disallowed clipboard contents on iOS
        
        When another app owns the current clipboard contents, pasting
        will display a "allow or disallow" dialog. If the disallow
        option is selected, the data from the UIPasteboard will be
        garbage and GetLOKNotifier() will return a nullptr. Since calling
        SetLOKNotifier() with a nullptr aborts in an assert(), fix the
        crash by failing gracefully.
        
        Also, throw an exception if the -[UIPasteboard dataForPasteboardType:]
        returns nil. By throwing an exception,  the "allow or disallow"
        dialog will display again the next time the user tries to paste.
        
        Change-Id: I05d689b679a7643a8478e3ce0f416205fdf8ec23
        Reference-to: https://github.com/CollaboraOnline/online/issues/5908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148655
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 1dd68786a927a23e5465589025abd90b8c9f4e7b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148627
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-03-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [34510e6e57e58fb27071564f546bbd420404e66d]

        tdf#117037 - Support Unicode minus (0x2212) in the number scanner
        
        Change-Id: I5b2cd4f3d6ac23e10dc0745819c7955d0a8ff170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148432
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [411dbbe8117eefe4166dd5f75525b25fa58d3fb9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9309d69eab4f5bedc266b2286a9b0e5f0a06e295
          - Mute l10n or string.
            
            Change-Id: I1ecfc8a5bf6b64060a92be1a48cd0cf877671236
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148866
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-03-14  Patrick Luby  <patrick.luby@collabora.com>  [b355f4e88998cc953b135933f554d773964badc2]

        Improve scripts that codesign and create a .dmg from a Universal bundle
        
        This change adds the following:
        - The solenv/bin/macosx-codesign-app-bundle script now uses
          "--timestamp" wherever "--options runtime" is used in order to
          pass Apple's notarization process.
        - A second, required argument has been added to the
          bin/create-dmg-from-merged-app-bundle script that specifies one
          of the following types: "release", "dev", or "collabora". Only
          the .DS_Store is different for each as no product set a volume
          icon currently.
        - Upon success, the bin/create-dmg-from-merged-app-bundle script
          will print a warning that the .dmg is not notarized as well as
          the commands to use to manually notarize the .dmg.
        
        Change-Id: I7c3f2d60dbb16b25bd6088b7e0af8c82284702d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148490
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 86e612db56be2d1934275de021b3213875e9301d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148508
        Tested-by: Jenkins

2023-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [189bd2fee8d5cf0ae7189b3f1fb64471a42831d2]

        CppunitTest_sc_shapetest: pass parent path to ScModelTestBase
        
        So it can use other file formats
        
        Change-Id: Id8c3e3bd185f6e01d3e375c24c063a9f897c0b5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148851
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [0d2617214e7a1b49a5d7fdb4a5aa76011b84b149]

        CppunitTest_sc_shapetest: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I765b9de1ac2e527d29bd235063bbd20bfce64aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148850
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e6020d01cfc373c6117164d112f59fdbfe2463d]

        tdf#154167: sc_spreadsheet_functions_test: Add unittest
        
        Change-Id: Iec3de72c0742d0817aaec037ffd234ab05c090c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148840
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [899dfbca1755f730dc935ca0d929236f999b9879]

        elide some temporary OStrings
        
        where we can pass a string_view into OStringToOUString
        
        Change-Id: If7803ba49aa15f6e9c7bd386d32fb84003155390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148844
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-14  Julien Nabet  <serval2412@yahoo.fr>  [e056c1ce10779b42ae17866913cf4db06b86a491]

        Related tdf#129547 and tdf#154136: add COLON key
        
        Change-Id: I17978dbb100fbfa6f6ddbbbdf96872076bc2a289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86713
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-14  Justin Luth  <justin.luth@collabora.com>  [2571b39158c679a42a68bea5f219e29a42f4e6a6]

        tdf#154129 writerfilter framePr: check whole style inheritance: W/H
        
        This patch depends on HAnchor, which created vProps.
        
        This patch changes the logic a little bit from the previous code.
        Before, the paragraph has to specify something other than 0 (auto)
        in order to be acceptable. Well, I don't see any reason why
        direct formatting shouldn't be able to override a non-auto style value,
        so we'll make the change and see how it plays out.
        
        Errata says:
        "The standard states that 0 is a valid value of the h attribute.
         HOWEVER Word treats a value of 0 on this attribute as a value of auto."
        
        and:
        "The standard states that the values of the h attribute
         are defined by the ST_TwipsMeasure simple type.
         HOWEVER Word restricts the value of this attribute
         to be at least 1 and at most 31680."
        
        There were no existing ooxmlexport unit tests where the old and new method
        produced different values.
        
        Change-Id: I48934598c1bca8ffc99b97b114d77505f3341105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148715
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-14  Miklos Vajna  <vmiklos@collabora.com>  [34504d2496a32f64952ec434ce1ac30ee2d9fb66]

        CppunitTest_sot_test_sot: remove duplicated assert
        
        This was added in commit 29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
        (tdf#115574 sot: fix Excel -> Writer paste, 2018-03-29), where it was
        hard to consider 4 bugreports at the same time, so I wrote asserts for
        each bugreport. But at the end 1 bugreport is a superset of an other
        one, so just moving the 2 comments next to each other having 2 asserts
        instead of 3 leads to a simple removal of the duplication.
        
        Change-Id: Iaedccf5ac498dd6842c25b60b507e63332daddf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148847
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb739dbcfc4e9b6467d09fc624ab618a4279cffe]

        Fix typo
        
        Change-Id: Ie7b0692c5f79eb4e8022ac1bcedfe01b3f7b75f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148878
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bd4ae16a5417c0997993b64864d914fb01fdb165]

        Remove debug command
        
        Change-Id: I6cd82e83288724896987c591f308fb7ab0eb880a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148863
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-14  Mike Kaganski  <mike.kaganski@collabora.com>  [19aa70022b23745f52258b6db192b19ba8a531fa]

        tdf#154179: fix pre-selection of the current outline level
        
        This seems to always be the intention, and never worked. The pre-selection
        made in SwOutlineSettingsTabPage::SetWrtShell was overridden later in the
        SwOutlineSettingsTabPage::ActivatePage, because SwOutlineTabDialog::s_nNumLevel
        wasn't updated to the wanted value. Additionally, it only could potentially
        work when the dialog opened the SwOutlineSettingsTabPage, not the other
        page (which would happen when it was active the last time when the dialog
        closed).
        
        And the active document level value must be sanitized.
        
        Change-Id: Iefefcdcde9da0e54e3acaffb981e057367a27197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148837
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [64381df6fe236807c1793df11ce51537ea7e53f4]

        move "align right" checkbox to the left
        
        Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Change-Id: I4a3c42a6ea098f73c8467e003275e759c0f98882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148756
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [24382019a3f413cc328ee0adf8dfa8a5bc6f97ec]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36f71cb8d29fde0c8b42238ba59bc1d73b042cc6
          - Related tdf#145332 Fix sentence about TRUNC function
            
            As discussed in the original commit [1] the wording about the TRUNC function was incorrect. This patch fixes the sentence.
            
            [1] 6b1075e1e032be5bb6cba1dbdcc11de2a1824add
            
            Change-Id: Iec86eb4c881dbfbbb3e2020a7aedd6ff59bf0e61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148767
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b5310727be645e5b6d56fae84a30b349810482a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 87d52df5836c4fe06e186b289c937be47d9ded53
          - Improvement in refactoring XSLT
            
            Change-Id: I91f3dce118e4a66d697f844f7f78897748c17a95
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148880
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-14  Eike Rathke  <erack@redhat.com>  [9c5764d1edb154cbd235fffe3b778368f182a260]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5e8ed765cc8c502f1272c191c0a1a4f82d505e57
          - Related: tdf#154167 ERROR.TYPE() list both alias name and Err:... value
            
            Change-Id: Ice9252d0aba19719737d47090f426ee52a0eabc7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148882
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b695a28ff01a0ee27186dfc583da6facad06de8]

        tdf#139065: vcl_pdfexport: Add unittest
        
        Change-Id: Ic185f4e9bd26844b01cf3df61c9b4bcf3b637e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148798
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [92d3627b5b2b3cf9da1e0eea2a8724e6936d25e3]

        language list in SwTranslateLangSelectDlg can be static
        
        Change-Id: Ica911ec651e536e399491c0c28765aeb9e021548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8eed6f0bea900368e7e2468990504b8b3eaeb60c]

        Fix typo
        
        Change-Id: I3c7b644de7b6e6bf46161a33f56eb89df662777c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148876
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [048f08e7086f74883e83d24628085690c2305df9]

        Fix typo
        
        Change-Id: I9a46298fe53880cd84aa1cb9713e576eece3d2f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148877
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c673f0f04a2c1697e96c7fc228e1de33e112aa83]

        Fix typo
        
        Change-Id: Ie08c4c4b6997b13eea7b29f987f994d8a894a331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148875
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-14  Eike Rathke  <erack@redhat.com>  [248f63cee242bc21451bfa0b6c54f2c9da0b8e99]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c3a560d632327fea245b60b7a40e7950974f3cd7
          - Related: tdf#154167 ERROR.TYPE(#NULL) is for Err:521
            
            Change-Id: Id30b59e13feac935fb5307f67bd5a5423b1e9fb0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148881
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-03-14  Eike Rathke  <erack@redhat.com>  [8dc4bea8323783b4abbf8010c492bf8d8de76481]

        Resolves: tdf#154167 ERROR.TYPE(#NULL!) must return 1
        
        Error #NULL! is an alias of FormularError::NoCode Err:521 that is also
        mapped to import/export Excel docs. ParameterExpected Err:511 was wrong.
        
        Change-Id: I08dc4e5747cb6c6ab7c2b309b02b942340ed4484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148820
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-14  Justin Luth  <justin.luth@collabora.com>  [1bc004f67feb51beb00113cedd5f98a1e6e2bcdd]

        tdf#154129 writerfilter framePr: check whole style inheritance: X/XAlign
        
        This patch depends on HAnchor, which created vProps.
        
        XAlign is not like YAlign - which is invalid with a text anchor.
        XAlign is still valid with a text anchor,
        and so doesn't need to copy YAlign's special vAnchor default.
        A unit test was added just to pre-emptively assert that.
        
        There were no existing unit tests where the old and new method
        produced different values.
        
        Change-Id: Ib3066f3d67c01a1bca972c6a114bb726bccac5af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148714
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-14  Justin Luth  <justin.luth@collabora.com>  [630732bfd8ed531e9d412a36a083f33763def054]

        tdf#112287 tdf#154129 writerfilter framePr: fix vAnchor default
        
        This patch depends on previous patches for tdf#154129.
        
        yAlign takes precedence over w:y. HOWEVER, there is a clause
        in the documentation that complicates everything.
        
        "If [yAlign is] specified, the position for this attribute
        supersedes any value which is specified in the y attribute,
        and that value is ignored, UNLESS the vAnchor is set to 'text',
        in which case any relative positioning is not allowed,
        and [yAlign] is itself ignored"
        
        So if vAnchor is not defined, it defaults to text (FRAME),
        but if yAlign is defined then it should mean margin
        (or else yAlign has no meaning), unless of course w:y
        is also defined, in which case "text" anchor has meaning again
        and this unit test shows that w:y wins out in this case.
        
        The anchor is not affected by wrapping.
        
        [P.S. This was already set correctly in the code, but worth noting:
         "The standard states that the default value for the vAnchor attribute is page.
         Word uses a default value of 'text' for this attribute."]
        
        make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287
        make CppunitTest_sw_ooxmlexport5 CPPUNIT_TEST_NAME=testTdf112287B
        
        Change-Id: I953afa89e3c0974a16d43500ce590e1a481c2251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148691
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-14  Justin Luth  <justin.luth@collabora.com>  [b1696d2a3e2015b60fc04a785e6a9f7925f4232e]

        tdf#154129 writerfilter framePr: check whole style inheritance: Y/YAlign
        
        This patch depends on HAnchor, which created vProps.
        
        There were no existing unit tests where the old and new method
        produced different values.
        
        Change-Id: I1bf7dd6ee7a8c8d00f7c743657a32a86986e7a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148690
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-14  Jean-Pierre Ledure  <jp@ledure.be>  [0483b0a4bbd41f026a53ff35ab3162b57bee1a91]

        ScriptForge (SFDialogs) make On properties editable
        
        A dialog box and its controls may be associated
        with scripts triggered by events (mouse moved,
        key pressed, ...).
        
        The link is usually preset in the Basic IDE when
        the dialog is designed.
        
        So far, ScriptForge did not offer the setting of
        a link event-script by code.
        
        The actual commit removes this limitation: every
        On-property related to either a dialog or a dialog
        control is now editbale.
        With the important precision that such a property
        may be updated ONLY IF it was NOT PRESET in the
        Basic IDE.
        
        Static (IDE) and dynamic (by code) definition of
        a specific On property on a specific dialog or on
        a specific dialog control are mutually exclusive.
        
        The new capacity may be used both in Basic and Python scripts.
        
        A short update of the help texts (dialog and dialogcontrol)
        is needed with mention of above restriction.
        
        Change-Id: Ia078aaab317ced7ade7ce69694504013f8e768a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148800
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-03-14  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [8a3dc12a13a3b9e99dbd5000ca6a1d541cf472f7]

        remove support for TBL_BOXNAME TBL_RELBOXNAME in ChangeState
        
        * PtrToBoxNm and ToRelBoxNm are both public -- use just them directly
          instead.
        
        Change-Id: I7b0e377a13f00a3e0ab90e1cd12325672a83d16f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148213
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-14  Miklos Vajna  <vmiklos@collabora.com>  [a224948ef44eadfb32aee002d5f0e9f10c9e47de]

        sd: fix crash in ViewTabBar::dispose()
        
        Crashreport signature:
        
        program/libsdlo.so
            sd::ViewTabBar::disposing()
                    sd/source/ui/view/ViewTabBar.cxx:113 (discriminator 1)
        program/libuno_cppuhelpergcc3.so.3
            cppu::WeakComponentImplHelperBase::dispose()
                    cppuhelper/source/implbase.cxx:104
        program/libuno_cppuhelpergcc3.so.3
            cppu::WeakComponentImplHelperBase::release()
                    cppuhelper/source/implbase.cxx:84
        program/libsdlo.so
            sd::ViewTabBar::ViewTabBar(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) [clone .cold]
                    include/cppuhelper/compbase.hxx:65
        program/libsdlo.so
            sd::framework::BasicToolBarFactory::createResource(com::sun::star::uno::Reference<com::sun::star::drawing::framework::XResourceId> const&)
                    sd/source/ui/framework/factories/BasicToolBarFactory.cxx:129 (discriminator 2)
        
        I.e. the ViewTabBar got deleted by a smart pointer before its ctor
        finished, guard against this.
        
        Change-Id: I3d6ccc21167355047e3752316c8d0b9b02470f57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148838
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [67127e9a1340076d0c8f818b41cc6c44ddd575da]

        use more string_view in vcl::PDFObjectContainer
        
        which makes the call sites much less verbose
        
        Change-Id: I94eef7569e419f134ce574ecd9fb2ce8f50184b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [4a96f25ac3ef9f2ed940d6e56eca87bba387d451]

        filter: PDF export dialog: always enable Outlines for PDF/UA
        
        This is not a hard requirement, but why not prevent this pitfall
        at least in the dialog:
        
          7.17 Navigation
          A document should include a document outline that matches the reading
          order and level of navigational targets (ISO 32000-1:2008, 12.3.3).
        
        Change-Id: I06533123cdfe5fe1c79180d6ebd4e961b25a63b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148818
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [62f8bf1fd379387cafeb616189480976d026224c]

        filter: PDF export/PDF dialog: PDF/UA requires P bit 10 enabled
        
        Adapt dialog and export filter to ensure the bit is set:
        
          7.16 Security
          An encrypted conforming file shall contain a P key in its encryption
          dictionary (ISO 32000-1:2008, 7.6.3.2, Table 21). The 10th bit
          position of the P key shall be true.
        
        Change-Id: I2e8e4f5b0ef44efeabf3017f2e12b58914e93520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148802
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-14  Michael Stahl  <michael.stahl@allotropia.de>  [847f836c047152b6202b9ee28020df5e87eeba2f]

        tdf#154171 filter: PDF export dialog: don't show spurious error if PDF/UA toggled
        
        1. Security tab, set permission password
        2. General tab, disable PDF/UA
        3. General tab, enable PDF/UA
        4. spurious error dialog mentioning PDF/A, which is unrelated to PDF/UA
        
        (regression from commit 5a7cfe98e96489b7fa19d286ddd1e8c8e591d7dd)
        
        Change-Id: I742da1cd459919faeae53fc21e5f97ee6a7c6ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148801
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-14  Miklos Vajna  <vmiklos@collabora.com>  [baebe41647e4522a2d58f7a4eb392ceab66fc2c9]

        sw floattable: reject small(er than min height) row master at page bottom
        
        The problem was that the second row in the doc model was split between
        page 1 & page 2, but it was expected that row 2 is entirely on page 2.
        
        The underlying reason seems to be similar to what commit
        913b71dbe06c33773c4d779e00c6ec4b6a4af59f (sw floattable: ignore height
        of masters in lcl_CalcMinRowHeight(), 2023-03-10) fixed: again the
        minimum row height is meant to be enforced for each row frame of the
        row, so in case the remainings size on the page is 566 twips and the
        minimum row height is 1134, then we should not split the row, instead we
        should move the entire row to the next page.
        
        Fix the problem by checking for this (relatively) at the start of
        SwTabFrame::Split(), so we don't even try to split the row in this case.
        
        I assume that this would be correct to do in general, but have no such
        sample to confirm this in Word, so keep this specific to tables in split
        flys for now.
        
        Change-Id: Ic9171683ef7e14a70f7f8d5305198bbc16277d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148834
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-14  Regina Henschel  <rb.henschel@t-online.de>  [260735ff98631b94ae8737cf1cead3e20bade618]

        tdf#139618 Add WordArt fill types in pptx import
        
        This fix uses a similar approach as in WpsContext::onEndElement, only
        that here moTextOutlineProperties and maFillProperties are still
        available whereas in WpsContext the properties need to be collected
        from CharInteropGrabBag.
        I have adapted unit test testTdf125573_FontworkScaleX because now the
        gradient is imported, see comment in former version of the test.
        
        Change-Id: I989ee475867c97b9f93c7e65cd25483611eec7bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148687
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-14  Miklos Vajna  <vmiklos@collabora.com>  [599722cf77310429a9b9bd2a348486a08b60de0d]

        svl: fix CppunitTest_desktop_lib's DesktopLOKTest::testSignDocument_PEM_PDF
        
        The problem was that this test passed when the entire suite was running,
        but not as an individual test.
        
        Digging deeper, this didn't pass in isolation because the test loads a
        private key into memory (which is not in the NSS DB) and since commit
        5592ee094ca9f09bfcc16537d931518d4e6b2231 (svl: fix
        testSignDocument_PEM_PDF with "dbm:" NSS DB, 2022-04-28) we delete that
        in-memory key as a workaround for the NSS dbm -> sqlite transition.
        
        Fix the problem by not deleting the in-memory private key in the LOK
        case: this makes the test (operating in a stateless mode, with in-memory
        keys) pass again and keeps the desktop signing (working with the NSS DB)
        working.
        
        I noticed this test failure as a local test update of libxmlsec to 1.3
        RC started to fail here even when the whole suite was running, but looks
        like this was working by accident before anyway, and the fix doesn't
        hurt for libxmlsec 1.2, either.
        
        Change-Id: Id365ddc5c5d04d538609f444c0e3c4ab4b32a6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148817
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-14  Baole Fang  <baole.fang@gmail.com>  [16242898da50fbf680df558cb47d1978c3304572]

        tdf#150135: Fix OTextInputStream to throw runtime exception when uninitialized
        
        New method checkNull is added to the class to throw a runtime error if mxStream is uninitialized. It is run in the beginning of all methods that require an initialized mxStream.
        
        Change-Id: Ia1f15d90c79c71b2a2350d9b60ef1bf68fb9009c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148819
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [7121117d12ae87b394b6c6ed41a2d95aadedc5b7]

        Colibre & Sukapura: tdf#153772 Revise Navigator's Headings > Outline Lvl icons
        
        Change-Id: Ice9eeb2d2d9a5ef4bda2d373d007ba8850b0f052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148799
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [97a38dbfa998967c45efaf3303fedfa1a709a2bb]

        tdf#154005 sc ods fileopen: fix dropdown form control size
        
        Dropdown form control size was increased by the size of hidden
        rows or columns.
        
        Regression from commit: 1f0b3c7a40edfa81bbc7a58d123a6a2dfd83e4ca
        (Improve 'resize with cell' handling)
        
        Change-Id: Ic903a488cab22286f95cfdf4ee559013fd7bfa02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148738
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-03-14  Justin Luth  <justin.luth@collabora.com>  [c253fc3877fd91f4345feb60dacb6565f9a2509b]

        tdf#154129 writerfilter framePr: check whole style inheritance: VAnchor
        
        This patch depends on HAnchor, which created vProps.
        
        A style can inherit its properties from another style,
        but the code was naively just checking the first paragraph style,
        and not any of the parents.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154129_framePr1
        
        Change-Id: I72159321485aca18bc4bb8384221ff59cb685fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148689
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2023-03-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c132a1abd57c109331191c3b3fbd14e1c5e46631]

        Always update fields when loading document
        
        to make sure that table formulas are re-evaluated after loading.
        
        When a document has a wrong sum saved (which seems to happen sometimes),
        this sum is used until user clicks into the table or otherwise
        refreshes the formula.
        
        Change-Id: I5cc3f983524b395089c17aa35d8641847a388bad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148355
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-13  Stephan Bergmann  <sbergman@redhat.com>  [758050caa06bd742dddea55fb29b0eec1b2309e4]

        Use a more reasonable type for XDataPilotDescriptor::checkName nIndex parameter
        
        Change-Id: If9e6760a6b23c63d03d337d6b111493684d67c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148568
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [fff2b5d06c24bb36a498bdb869158ee09c487111]

        tdf#153935 sw: PDF/UA export: guess table headers based on autoformat
        
        This is a bit of a disaster area because in contrast to SdrTableObj
        (see commit 0bc96b8805f2cfa2278729a9f3e56a350ddd69ad)
        the SwTableAutoFormat application doesn't have flags which "special"
        formattings like "first-row" etc. should be applied to the table.
        
        So add a horrible heuristic to guess depending on the content of its
        formatting attributes.
        
        Change-Id: Ie09538d37de6118409b04a4cec6ab46b74c4194d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148793
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [49045e094960e06a59286a7fb6412e501b49cd27]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3a16adcb0187df5cf9c01ae6b4550785c03375b
          - tdf#141474 Incorrect parameter names for Basic functions in help
            
            Skipped items: Mid, MIRR, NPV, Shell:
            
            - MID statement is bugged, TDF#154166 refers, no need to change it yet.
              MID function operates fine
            - MIRR and NPV do not support named arguments in VBA despite MS documentation.
              No need to update those pages
            - Shell keyword arguments are correct
            
            Change-Id: I09dcc280edeec158eafaf87286966c36447ff71b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148316
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-03-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [5307ce6448a8aed3d91b6a250bc7af38b5a37e06]

        tdf#126689 elementary: Jump Up & Jump Down This Level icons
        
        Change-Id: Ia7726678521faa9cf90c3fcb06799c1eb420e399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148748
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [13d3ae64dbf2ac4bda8e831c1da890b09024a8bb]

        make more use of OUStringBuffer::append(OUStringConcat)
        
        where we can avoid constructing temporary OUStrings
        
        Change-Id: I0eacd68a8d1b450894c2ea769055f16886b78ad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148780
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [25ae332bbafd0cb416a6a5c0db467e501661c679]

        tdf#154125: sc_uicalc: Add unittest
        
        Change-Id: I85a87d9c7f23f6e2c914542a328174cca02d3491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148790
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-13  Galdam  <qmebic1975@gmail.com>  [da4f2ddc6ea7db9a55ad1d9baf3cf126e41d8af2]

        tdf#154106 Add Sukapura TipOfTheDay
        
        Added Sukapura Totd images
        
        Change-Id: I4093f53a338cc4ed08e30a07f713aa741635a31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148785
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6f54bbbea5949001c7171efa03bb3a5fbe32a067]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b119b55661646266f6432addfa59f3de24925315
          - tdf#153560 (tdf#153748)  update "up to level"
            
                need to indicate that the option selects the header.
                correction to left/right arrow icons for tdf#153748
                Problem arose because commit
                59b602dcdb445116dde3e50dce45974eec0e043b removed the
                relevant information from links.txt
                refactor <relatedtopics>, remove <xml-lang>
            
            Change-Id: I0462c55ff54777b4b4b3af9a0c6de53634aabc2d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148762
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-13  Baole Fang  <baole.fang@gmail.com>  [a6edfaaeb02169d90d8b414c480257b1ec0bcaad]

        tdf#150281: Fix CentimetersToPoints in Calc
        
        Originally, CentimetersToPoints was implemented as a base method for
        Writer and Calc. They are both using the same implementation,
        which is correct for Writer, but wrong for Calc.
        Since their behavior should be different,
        I remove the base method and implement a correct one for Calc.
        
        Change-Id: If957accdd9be86a96ca6fb711502e49a79bf3223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148745
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [9d829facd92d51c7eba8a8cc30bac4d5fbdea112]

        Fix build
        
        ... after commit 470a2c0692533f42d333b9416daf3f0871cd951a
        and commit 544d6d781b3c8aa108ced362d708693b5127f3d7
        landed, tested on CI independently.
        
        Change-Id: Ibc2ee083e9afde47c37af3c20a8fcb895b635861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148765
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-03-13  Mark Hung  <marklh9@gmail.com>  [f88bb22cc3cbbc35abf72ec0ce1a4c0bb60ee88c]

        tdf#115321, tdf#139065 render emphasismark for pdf export.
        
        Fix the logical mistake: it rendered emphasis mark only
        for spaces - that is excatly opposite to what we want.
        
        Change-Id: Id478af269c6cf8ab9a9e1413d19f9b3a3451d59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147916
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2023-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [2cb2e2b9c1d55bbbc639997ca30fd6b57a81bfb2]

        Introduce OUStringBuffer::insert taking OUStringConcat
        
        Avoids some (re)allocations, and aligns with already existing append
        
        Change-Id: I536ba50f56fc560c0f6e8c0a8b65bd4248896a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [cd50669485ebea3c45d4c555ad90ff484e22f429]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d23e853b52eab08b7f76ef92d875ffc5720f8e6
          - tdf#153551 correction to "caption" and "category"
            
                + indicate that category is also mentioned before "caption"
                + indicate that "category" position depends on Caption Option
                * clarification about paragraph style applied to the caption
            
            Change-Id: I85dcccf3dd454ec33480f71cf2a5bd6f9be425b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148766
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-13  Justin Luth  <justin.luth@collabora.com>  [b2d754c49b7351f7b2663bb249b4b2f663ef3786]

        tdf#154129 writerfilter framePr: address nit about nSafetyLimit
        
        I was going to change --nSafetyLimit to nSafetyLimit-- anyway,
        since that better matches "getting 16 tries" like a code-reader
        would first expect (instead of only 15).
        
        I had thought about putting an assert here,
        but that isn't logically impossible to have 16 inheritances,
        so an assert seemed a bit too strict.
        But as the reviewer noted, a SAL_WARN at least ought to be here.
        
        I thought perhaps using an unordered_set might let me
        automatically eliminate loops, but then according to the documentation
        it uses "random" sorting and isn't treated like an array,
        which is definitely needed here.
        
        Of course, I could add the logic to simply check if the new
        value already exists in the vector. However, I believe that a loop
        would be considered an "invalid document" and thus should never exist,
        so clean-reading code and a safety valve against a malicious document
        seems appropriate enough to me.
        
        Change-Id: Ie6132c1beb483a6bee9c9794934ba8de7cfd82bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148784
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [816c8551803fa15bbf78112a2f0679fd1b6dbcd8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09fd472db2c23c40da053606953449cc165d6ecf
          - Fix bad link
            
            Change-Id: I1943382ae49c3085e8619c1b2d99c7be3c76e35f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148786
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a4aeb2b0c474e0cd7a4c870865aa15462b6b6a3c]

        lok: introduce resetCompatFlag
        
        and reset logic of setCompatFlag/isCompatFlagSet changed in
        afb7b373c34bd6a1608a30eb8267fa6f8231e853
        "CppunitTest_sc_tiledrendering: reset CompatFlag in tearDown
        Otherwise, there are some tests setting it to scPrintTwipsMsgs,
        so depending on the order of execution, it might affect other
        tests"
        
        Change-Id: I306ac0b77b65f99879f4018cfbc57354a158f38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148783
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-13  Tor Lillqvist  <tml@collabora.com>  [42e94211ad6dc2125a411c1768d0b3a677dba34d]

        Improve documentation of lok::Document::getPartPageRectangles()
        
        Change-Id: Ic507749064ff27b36cac8e01a54fb58dd10cdda5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148779
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d3a44a3a4192247b4fa1ce559e3427a83dcb7d23]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f61c7de68a7ca48e2aea2827fcb8c081100d581
          - tdf#154121 Add hidden characters to index
            
            Change-Id: Ibcfc4cc2c2690bb98c60c5b63c4383cc2d636469
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148737
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [da17ea737cf64a3c6c4e28355e85f155e49fdb5f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 133ec76d6453eb8ce7b0a4007ddb01eb75aada8a
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Iac6e70066abbd24a44e9622a92fcbc5c21184aa3
            
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: If515aaa23247d33099acbfe94f83552c12e2f410
            
2023-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [a4e0e85f675ecb2282432503ab439e4445b487e3]

        sw: PDF/UA export: produce Lbl for footnotes/endnotes
        
        Extend the list item Lbl code that was added in commit
        9b38beadf9eaf027b201cdf0ecb2bce5611014dd a bit for footnotes.
        
        The FootnoteNum portion gets 2 SwTaggedPDFHelper, the outer one produces
        Lbl and the inner one Link.
        
        Change-Id: I836c83d6978ecc8c0a87fa6b0fe2fa17e31a0683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148648
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [4250f334de729360567ec9bd88aed06fbd823dc4]

        tdf#152218 vcl: PDF/UA export: produce ID for footnote/endnote
        
        There is this mysterious requirement:
        
          7.9 Notes and references
          Footnotes and endnotes shall be tagged with a Note tag. Each note
          tag shall have a unique entry in the ID key as described in ISO
          32000-1:2008, 14.7.2, Table 323.
        
        Then also an IDTree is required; PDF 1.7, 10.6.1 Structure Hierarchy:
        
          (Required if any structure elements have element identifiers)
        
        The point of this is entirely unclear to me, it looks like neither
        poppler nor pdfium even have code to read the IDTree, and structure
        elements already always have an object id by which they can be
        referenced, so why add a second ID?
        
        Alas veraPDF complains if it is missing:
        
          Specification: ISO 14289-1:2014, Clause: 7.9, Test number: 1
          Note tag shall have ID entry
        
        Change-Id: Ia8e52c46312c7dbb3bf7ef8635321200e5de24ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148645
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-13  Michael Stahl  <michael.stahl@allotropia.de>  [c105fbec07d0734b6b183ea8b4da15e8fe260f9b]

        tdf#152218 sw: PDF/UA export: produce Link from footnote to body
        
        There was already a Link StructElem from the reference in the body to
        the footnote but it was missing for the other direction, so veraPDF
        complains about a Link annotation without StructElem:
        
          Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 1
          Links shall be tagged according to ISO 32000-1:2008, 14.8.4.4.2, Link Element.
        
        Change-Id: I57aa153d5899bcfa505e274a01b0183978a2e995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148644
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-13  Caolán McNamara  <caolanm@redhat.com>  [2071538904ed37397767ebd4a9dc82827f75f374]

        tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/start
        
        Change-Id: I8d4366b6ad667f28ff35f18fef13f2e0f3e9b194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-13  Michael Weghorn  <m.weghorn@posteo.de>  [dd4f562cfdff35e99acc55f522f65f966fa7ee52]

        sc a11y: tdf#139322 Don't steal focus from "Manage Names" dialog
        
        When opening the "Manage Names" dialog from the name box,
        move setting the dialog to after calling `ReleaseFocus_Impl`,
        since that one sets focus to the active view, and may thus
        steal the focus from the dialog otherwise. (Observed
        with gtk3 on Linux and on Windows, while focus was still
        in the dialog with kf5 or gen.)
        
        Setting the dialog afterwards ensures that the dialog
        gets focus when it opens, while still ensuring that the
        focus is no longer in the name box when the dialog closes
        again.
        
        Change-Id: I47f12d115a747ecda1c11c04282bd848eb398d9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148775
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [544d6d781b3c8aa108ced362d708693b5127f3d7]

        tdf#39667 Enable tagged PDF by default
        
        And adjust some tests accordingly
        
        Change-Id: If81803ba48485273939f419ad589dc6dd2e9c531
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148303
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-13  Caolán McNamara  <caolanm@redhat.com>  [43e9582e01b63fb55a0e8cdea7b7f3bb209886ee]

        crashtesting: assert on loading forum-mso-en4-144513.xls
        
        the same case, though non-fatal in that instance, can be seen with
        sc/qa/unit/data/functions/spreadsheet/fods/hlookup.fods
        with a maParam.nCol2 of 27, nFoundCol of 23, nCol of 28 so a nColDiff
        of 5. rParam.nField was originally reduced from 27 to 22 with
        -= nColDiff, while with this approach of restoring the original
        position it is restored to the value of 23 it had before the
        last call to GetNext()
        
        Change-Id: Ia6ca73be03fe313c81a23f176a40a5e619a75d3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148415
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-13  Caolán McNamara  <caolanm@redhat.com>  [5fdd00dc26123850858564b079154765a01c83bf]

        ofz#56910 Timeout
        
        Change-Id: Ic820a984d9a714babe590c51fbb4120f12c14089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [143c48f3c3dd172c635e4535a0b0da741721f375]

        remove leftover #undef
        
        from back when some code did
            define css com::sun::star
        
        Change-Id: Ia88ef5e79abac67b90bfed17220ef5eba6043c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-13  Michael Weghorn  <m.weghorn@posteo.de>  [e0647aeaa4d3a2467c3cc12440df179d7a5853c2]

        android: Update Android Gradle Plugin to 7.4.2
        
        Change-Id: Idee4fddd7fd2b610fef194b86ace88469c3124da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148749
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-13  Miklos Vajna  <vmiklos@collabora.com>  [da2707a83f13cba98b22aba1ca6568dbbc4c5fd8]

        sw floattable: handle Word 2010 legacy mode in SwFlyFrame
        
        The tdf#61594 bugdoc has 3 non-header rows on the first page, while
        Writer splits the 3rd row, so the follow row goes to the 2nd page.
        
        It turns out that the 3rd row fits the first page in Word because >=
        2013 matches Writer, but <= 2010 used to behave differently, see
        <https://answers.microsoft.com/en-us/msoffice/forum/all/floating-tables-in-word-2013-will-not-extend/576962cc-392d-43e5-b603-654406e1969f>.
        (The spec doesn't seem to document this, sadly.)
        
        Fix the problem by using one of the existing compat flags that we only
        set in the Word <= 2010 case (triggered by <w:compatSetting
        w:name="compatibilityMode" w:val="14"> or lower values), that scenario
        wants to allow the fly frame to extend till the bottom of the page, not
        only till the bottom of the body frame print area.
        
        The bugdoc now doesn't split that 3rd row, but the layout of the 4th row
        is still bad with this.
        
        Change-Id: I547abb19df250e5fbe4d8e123593a645cdbdc6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148751
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-13  Justin Luth  <justin.luth@collabora.com>  [1519ae101abf32187db983c8a08f7bf1899d5d22]

        tdf#154129 writerfilter framePr: check whole style inheritance: HAnchor
        
        A style can inherit its properties from another style,
        but the code was naively just checking the first paragraph style,
        and not any of the parents.
        
        I'm going to onboard these one at a time.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf154129_framePr1
        
        Change-Id: I32eabc6c1090dbc2c467da74fe32c6377e9a3875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148686
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-13  Miklos Vajna  <vmiklos@collabora.com>  [47afcad0d599009c38b4597c27558ec2af58b7f8]

        Update pdfium to 5636
        
        Some changes in the bundled libtiff, but it seems that would be for XFA
        which we disable, so it doesn't affect us.
        
        Change-Id: Ibadeecf20daec342fbfef6d1e89bd17f5f0095e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148652
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [30784e55e484de2790c4b264a50a65acf450c000]

        convert UnoControlModel and friends to use std::mutex
        
        Which means creating a variant of the cppuhelper::OPropertySetHelper
        helper class which uses a std::mutex.
        Since we can do virtual base classes now (which the original could not), use that and a new helper
        class comphelper::UnoImplBase to share
            std::mutex m_aMutex;
            bool m_bDisposing;
        fields that the OPropertySetHelper wants to share with the parent class.
        
        Change-Id: I05ad465a3d3653ed4e109137e3e1c58190da8d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [982b550541cc68670cad222e921fd62a4c1f232c]

        elementary: tdf#153609 Update Book Preview in Page Preview
        
        Change-Id: Idc5710c576b6edcea21cfad715507df1e38267c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148746
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [98f35cf85ee66e995610fec92ea5224fbf28dff3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e87fd6170e4836d6fb426470a97d78c87659970a
          - tdf#153560  corrections to "up to level" and "Format"
            
              * Following decision in tdf#147004, comment 20, the actual rule
                used by "Up to level" is included in the documentation. Also
                needed to modify description, because level is not only
                referring to heading numbers.
            
              * Simplify "Format" description for type "Heading".
            
            Change-Id: I95a53b58b048a68df11706b5d5641746b5929e26
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148760
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-12  Caolán McNamara  <caolanm@redhat.com>  [668c44e841a10cec8932a446a941e6d7c386bf3b]

        ofz#56928 Integer-overflow
        
        Change-Id: Ia20a42e16b50ab320e44405e60403c1d3b971bb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148692
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [83eaf726ada716f5d16713d3f23d432f587754e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4dd6c878412fd650ab8db543ca45006b101933ca
          - tdf#153243;tdf#152873 update labels; corrections to "Heading Numbering" section
            
              The main change, for all three files, is to update
              "Numbering by Chapter" section.
                   "Numbering by Chapter" -> "Heading Number Before Caption Number",
                    (or "With Heading Number" for Variable dialog), and correction
                    to explanation.
                   "Outline level" -> "Up to level" and correction to explanation
                    correction to "Separator"
            
              shared/optionen/01041100.xhp (AutoCaption)
                 + added "Numbering Separator" and explanation
                 * corrections to explanations for
                    "Add captions automatically...", "Caption", "Separator", and
                    "Character Style"
                 remove some <xml-lang>
            
               swriter/01/04060100.xhp (Caption Options)
                 * corrections to introductory description
                  "Character Style", "Caption order"
                 remove some <xml-lang>
            
               swriter/01/04090005.xhp (Variable)
                 refactor <h2>,<tip>, remove some <xml-lang>
            
            Change-Id: Ifd70c13a7f21b8eb23ecf61dd264cc8b314c3d81
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147595
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f039e86e7ba51a9fe36937cfcadd4efd7c18c713]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f00818a17ab14315f2d6d937cab079f19c6251f9
          - tdf#153561  Untangle the "Format" options
            
              "Format" appears both as a section title and a label with a buddy
               control for the "Heading Info" element. This distinction does not
               appear in the different "entries" help pages.  This patch untangles
               the different embeddings that are used, so that the help pages
               for Entries for each index type will correspond to the dialog for
               that type.  This patch only changes the entries page for
               "Table of Contents" and "Alphabetical Index", where some new sections
               are created. The sections in these two pages are embedded in the
               Entries pages for the other index types. These other pages will be
               updated after the sections in this patch are available for embedding.
            
            Change-Id: I5ed12506666af2ac04009e833b8bef37fff9485e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148754
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-12  Mike Kaganski  <mike.kaganski@collabora.com>  [e11b63196ba6db33a6137382ba82bbcca2dd5bdc]

        Drop some const_cast
        
        Change-Id: I34458e6d16a5fddebf3673cc475204c914217a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148734
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-12  Eike Rathke  <erack@redhat.com>  [df706f47a2b62248d222911db12c674e6507e5c6]

        Resolves: tdf#154125 Fix INDEX() one-dimensional vector access
        
        For i62850 a (not documented by Excel in
        https://support.microsoft.com/en-us/office/index-function-a5dcf0dd-996d-40a4-a822-b56b061328bd?ui=en-us&rs=en-us&ad=us)
        one-dimensional vector's element access was implemented with
        non-sufficient conditions that prevented returning an entire
        vector. Later ODFF defined proper conditions for that, see
        https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#INDEX
        
        Also, that vector element case assumed vector replication to the
        other dimension as usual, which is not the case here, access to
        the other dimension's index >1 must return error.
        
        Change-Id: I604c2355f0aca2988cb13f0d4f54ccd2d74c3b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148736
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1042250055364e82c71631630942117cb6c14346]

        "None" -> "[None]"
        
           to be consistent with other dialogs
        
        Change-Id: I736c2017cafbb032e19fff609a1655bd8b415e46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148702
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [73f8c723100741543cca2cc0dbf0fc83264011c7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 453215e939e4b0b8247e694a96eb89f7e117afaf
          - Remove wrong reference to ODFF.
            
            Related to https://gerrit.libreoffice.org/c/help/+/127817
            
            Change-Id: I8a3dd1bcd0481acfdf8e0faa794f8e0214f49b89
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148735
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-12  Mike Kaganski  <mike.kaganski@collabora.com>  [2d9e35063c81e22ef681be0aa39eb3311f00784a]

        Assert that we only order nodes of the same array
        
        Change-Id: Id04aa8177552624078369d33c9e7bcdc783045bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148722
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c6569b4d58c45d573bffa557cb82cb4800e188cd]

        tdf#154143 Update image assets for Tips of The Day
        
        Change-Id: Id9b82404f7638eb2c70b6d3a079a91026b8cf484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148721
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-12  Noel Grandin  <noelgrandin@collabora.co.uk>  [be1c0c195166bb4d4056196599d88c864b42600b]

        osl::Mutex->std::mutex in dtrans::GenericClipboard
        
        Change-Id: I5a4bbb9a445ec73422bca167ca658550eac26b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148638
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-12  Noel Grandin  <noelgrandin@collabora.co.uk>  [5e05c18a44f9ae37d7119c7d9fd618a2e945dc72]

        osl::Mutex->std::mutex in dtrans::ClipboardManager
        
        Change-Id: I94cf2557c8b3ddac111a606361647697c8852b20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148639
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-12  Galdam  <qmebic1975@gmail.com>  [86ef24c5bdde4a283c1347ac385b1b537896db05]

        Update TipOfTheDay Images
        
        - Update app icon in Fraction
        - Update icon themes showcase
        - Adjust some screenshot
        
        Change-Id: I1af95c88093eb801b1b29fa9e542f75ed9d1d646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148491
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d887b6a6fa2a572f48498839c5a68791c3196634]

        Relates tdf#153344 - Sukapura: Sync outline color
        
        Change-Id: I710be3f227bf45740313f6ebd662b16653927a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148676
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5f20f4ff21f597e55d899f5ea4dfe1c1fa5824bc]

        cross-compiling on windows needs openssl to build internal python
        
        → add back OPENSSL as a permissable sub-build target and explicitly
        enable openssl when cross-compiling for windows_aarch64
        
        partially reverts 4132bd5477c25a505f7bfbee1e7dcf6602c927d3
        
        Change-Id: Ic162a2f0c6db377eadedb149fb428f0f015539f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148688
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f5c466502a302b8e56486119e5e318fb02b479fe]

        tdf#153344 KJ: Unify color and reduce cursor thickness
        
        Change-Id: I3911bf219e5663d5e314fe3703995c4880e0d99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148677
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Michael Meeks  <michael.meeks@collabora.com>  [4a4602ad7513262a6c0423f17b42791a852b7e23]

        lok: add trimMemory capability, and expand dumpState to caches.
        
        Being able to trigger some more aggressive memory saving is
        useful in for both online and mobile.
        
        Change-Id: I9b91c9fe9eecec06c75112595deac0bfeb94c144
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148624
        Tested-by: Jenkins

2023-03-11  Caolán McNamara  <caolanm@redhat.com>  [9dec458e40a8b6a180e5c1c6f93fd4277825b9a2]

        Resolves: tdf#132847 large scrolls that cause page up/down are still "scrolls"
        
        and should emit NotifyScrolled even if the scroll is large enough that
        the call to internal "scroll" optimization is omitted.
        
        (and like cursor up/down call NotifyScrolled after ShowCursor)
        
        Change-Id: Ie605bde8ce8312b2ff2be9fb471e2f7516b355d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b0b9e755d3b81ad453ebe8f800a1e7c005efc471]

        Simplify SwNodeIndex
        
        Change-Id: Ic3bb99d30445c2c355ec8634651bb308d198f714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148683
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1bd9f9b57ba4f40376ee9170e14ef2c31295c76e]

        tdf#154106 Breeze, elementary, KJ, Sifr: Add Bulb assets for ToTD
        
        Change-Id: I218d33b4c84b846e3c4c3d95e56662a019f70720
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148681
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Galdam  <qmebic1975@gmail.com>  [d147ca1543ef91c54bee203cf71745b216e3b257]

        tdf#152598 Update .ico files
        
        Added more images inside the app/mimetype .ico files to avoid bluriness in Windows
        
        Change-Id: Ie3ccc6f26ab21b2261a2964a70821473c413d86c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148485
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [2fccec4078f9cdcfa42447c2217d52035dc8fc3e]

        Revert "tdf#94079 sc_ucalc: Add unit test"
        
        This reverts commit e9697e315cd382ce14b5c8efc47a07aa06dea30c.
        
        Reason for revert: this is reliably failing on various jenkins bots
        
        Change-Id: Iac25f4c5bc7baff903e2e859e35d989fa52b55cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148697
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-11  Michael Meeks  <michael.meeks@collabora.com>  [950ad392c8e57a78a92450330a91b2f8233f038c]

        tilebench: allow save after rendering, and better load fail diagnostic.
        
        Change-Id: I24df1a42b1d3e991a430cf0ca25e9dc53b4bbff2
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148674

2023-03-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1f7a9434e4e890359b433702e55a04bd9c184ddb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9c97ba522ba4581f7ceed9cabc0d88d0a83098a4
          - tdf#153712  "Chapter Info" -> "Heading Info"
            
               updates to change "Chapter Info" to "Heading Info"
               and changes to the dialog for Chapter Info.
               New labels names included, and explanations revised.
               some refactoring to <h3>, remove <xml-lang>
            
            Change-Id: Ief4ebabe83b469576dfcb81f1b639f8219a46a71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148505
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-11  Shady Mohamed  <shadimabdrawy1999@gmail.com>  [7228fd770396885bcbee972dbf432f834de19fc5]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: I0cdd505833ab0f06ef37d7219df5e7e18f00591e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148654
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-11  Abdallah Elhdad  <abdallah31009448@f-eng.tanta.edu.eg>  [1927c6687ffc45a639aa5aaed1e6c7d2f9892b85]

        tdf#114441 Convert sal_uLong to sal_uInt32
        
        Change-Id: Iab17a199d15204a6944b415b170e813d4f9d7bfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148137
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1015770d87fb5287fd46921a94623fab07351c1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d9276a7ac8d9ecce1b0b1bce75a232e3b043a95
          - tdf#154132   add "Index (user-defined)" as "related topic"
            
                add variable to <h1> for Index (user-defined) and then
                embed as related topic to Index (table of contents).
                Also add variable to <h1> for Index (table of contents),
                along with a (table of contents) identifier.
            
            Change-Id: Ide3fe657093c00d0470dee0f55b67d80a25c9ed9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148696
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-11  gokulakrishnan-shankar  <gokullan1101@gmail.com>  [20a5e38ee279022b7e6fbc32d2d259738244c0fd]

        tdf#145538 Refactor to use range-based for-loops
        
        Replaced an existing for-loop (that used indexes to iterate over an array) with a range-based for-loop for better readability
        
        Change-Id: I0cb112e6a41d38158deb99fb27f2b8b7f8852339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147145
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60827355e483351886f7a96b5de12d810f35f0e6]

        Fix typo
        
        Change-Id: Id5fdd50fb17dc62281f986ddb79e417705b0c194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148546
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Noel Grandin  <noelgrandin@collabora.co.uk>  [770580ba8e9546aa7b960c8b622b936ba6cf9d37]

        osl::Mutex->std::mutex in avmedia::win::Window
        
        Change-Id: I4e6e7fd03c4aa7847edbc48bccac88ec361c8237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148637
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6977dad4535532d9bd897282f52806885862c83]

        osl::Mutex->std::mutex in OSQLParser
        
        Change-Id: Ibc56fee796914a6dd39970f7a7879d5b5b2c219f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148660
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [72c05eda32286703ec8315d05686d46ae824e194]

        osl::Mutex->std::mutex in OConnectionPool
        
        Change-Id: Icc0fc8162321296307f2b01e3fe39be3a69d5d10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148659
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5126c94cea90251f73b7b383e23ffa473ac5f5f0]

        osl::Mutex->std::mutex in OOfficeRestartManager
        
        Change-Id: I473d604346280cb24c299e0e6d6ca2621a2200a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [125287c157e1d0db199f5e14364948181c572c11]

        Fix typo
        
        Change-Id: I815a6871546a6010601054983560ecfb7ec21239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148544
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f69235a6f6578f3280a28560f6297c8ee6b797b8]

        Fix typo
        
        Change-Id: Iaee1ae3085caa5a416f2129e218658c4ad8e531b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148647
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb3f9cc58d9cbd896722cc1b2d6b4d5e0f0ec433]

        Fix typo
        
        Change-Id: I7508ed457b2aa17bb199b135c6dff89909d4729a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148543
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8013fce4c98e0e85e3fbc7d435d49217cf188258]

        Fix typo
        
        Change-Id: I37f1f41b93f1ec2a428e71fbbaa64437214d565e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148542
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bba20dfa2d69df6ae1e367022471c4eecf1079d6]

        Fix typo
        
        Change-Id: If59a564d6798e256bad8eaf16443bfe06b8ad265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148646
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0007966f8d333dcc9fcb0982859ed47dd6f41a2d]

        Fix typo
        
        Change-Id: Ia51621902ea8e1cff8c3813739b9d9c655477d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148663
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Caolán McNamara  <caolanm@redhat.com>  [e629abc924bd3589d98a85d361e94a55794861f1]

        Use sifr_dark for dark mode under gnome
        
        originally we only had one dark theme so in a dark theme there was only
        one option available, breeze_dark, but there's now a bunch to choose from,
        so we should make an explicit choice.
        
        https://pagure.io/fedora-workstation/issue/361
        
        suggests that
        
        "... the Sifr icon theme ... was designed to fit in with GNOME's icons."
        while
        "... the Breeze icons were designed for KDE Plasma, not GNOME"
        
        Change-Id: Ibdbf6dd624cbf607ba8e5632add430c2d8ff64d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148651
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Caolán McNamara  <caolanm@redhat.com>  [772328b386db4ab5a2b15e650610c31b34815c8c]

        Use a matching dark icon theme on auto picking icon theme from fallbacks
        
        explicitly use:
         breeze/breeze_dark for plasma
         sukapura/sukapura_dark for macOS
         colibre/colibre_dark for win
        
        originally we only had one dark theme so in a dark theme there was only
        one option available, but there's now a bunch to choose from.
        
        In practice nothing changes here because breeze_dark is the current (as
        originally only) dark mode fallback for gnome and win/osx name an
        explicit something"_dark" in their platform specific bits
        
        Change-Id: I13fdfe586cec30b5a9770dc80c9bdcc6a57d04a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148650
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [377d775d1f61245892dc61aa353246f985d83bae]

        Relates tdf#153344 - elementary: darken outline
        
        Change-Id: I2345da12a4dea6391ff607055124d5469dc536ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148675
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ee5dbd193fa24b46fb980ddd8a6c39ca349d0d01]

        tdf#153243 adjust label/tooltip/extended tip for "level" option
        
           3b995c0a73215b974437f63c1081daebf7ecec48 was created
           on the assumption that the current implementation was a bug
           and the UI should reflect the intended behavior. Subsequently,
           it was decided (e.g., tdf#147004, comment 20) to make UI reflect
           current behavior. Therefore, this patch changes "Outline level"
           to "Up to level" and the tooltip and extended tip are modified to
           reflect actual behavior. Also: simplify section heading because
           tooltip can indicate that the heading number is prepended.
        
        Change-Id: Ic4d308db5ca5abd02e70f8e61456c42e62ddcb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148504
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-10  Mike Kaganski  <mike.kaganski@collabora.com>  [8c519bd3a382f6a5e23624bb5e7bd0230f32ce01]

        Flatten FindPrvNxtFrameNode
        
        Change-Id: I3a3f6e1aec7efb988adf7ba76b130929736458a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148657
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-10  Justin Luth  <justin.luth@collabora.com>  [f4f91c9e7ad9ad669f03fc9a09cd20fdfb53805b]

        tdf#104394 writerfilter: no addDummyParaForTable when PrevFramed
        
        The dummy paragraph is only supposed to be added when the table
        starts the section. In this case, a framed paragraph was
        the first item in the section.
        
        Since it ends up being a floating item, it is probably not
        correct to turn off GetIsFirstParagraphInSection.
        
        In any case, this is a much more targetted fix,
        and thus much less likely to lead to regressions.
        
        Change-Id: I7fb2c6189ddbff5d46828b27d68667c9d4a31122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148656
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [85cdae23f1bb184d50500deb37f24d650f5e9230]

        Use officecfg instead of SvxChartOptions
        
        Change-Id: Ie7fddd86baa029890cd6874fdfae186098d00407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148604
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f74490877aae984d2991e18118baae797db04e92]

        simplify ConfigColorScheme
        
        there is only one property that we are interested in
        
        Change-Id: I5c2b80e7ade38c822f495b79bda7e541b191199a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [11c8a72b91cf2798610ca3eb3fa33efe1940233f]

        CppunitTest_sc_tiledrendering: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Ifc11d57662a9ef80e0cc2a1b35c8e5efaab44e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148636
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [afb7b373c34bd6a1608a30eb8267fa6f8231e853]

        CppunitTest_sc_tiledrendering: reset CompatFlag in tearDown
        
        Otherwise, there are some tests setting it to scPrintTwipsMsgs,
        so depending on the order of execution, it might affect other
        tests
        
        Change-Id: Ib0d08b1fe4e172bd5b03d63260e6b1c3fde26595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148635
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-10  Miklos Vajna  <vmiklos@collabora.com>  [c804c5354855188b5a37219cfe11dc079dc235f4]

        sw content control: fix lost properties on copy&paste
        
        E.g. a checkbox content control was turned into a rich text one on
        copy&paste, so toggling didn't work on the copied content control.
        
        Change-Id: Ia7262e0b88dff12a2f87acd7b0e6cc3fbde3c3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148613
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-10  Marco Cecchetti  <marco.cecchetti@collabora.com>  [4eae3fcae0bcc3aafa5b51d80ffca7e4d539f97a]

        lok: some tunneled dialog control was not invalidated correctly
        
        This patch fixes a regression for commit:
        "lok: form controls: rendering and mouse event forwarding"
        
        Change-Id: Iffb0757834a884a6c86206221660da2a24bdff17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148564
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 7ed760c4564834ec61ceb91f681dfc6daa1be4bd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148621
        Tested-by: Jenkins
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2023-03-10  Angelle Leger  <angelle.leger1@gmail.com>  [eaa5f54dd1d64f314379a34277a19503eb5b38df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b6d4faa7e677a53d4bd36c44778d87e51bd206c8
          - TDF#153108 Calc Zoom Help Page
            
            * New help page by Angelle Leger
            * Refactoring by ohallot.
            
            Change-Id: I8c0d47414ec257b21d0f0369912147038d440d47
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148530
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b3ffd089b2a3d8eb4f1b61b7f7ee645f34523be]

        Use officecfg instead of chart::ConfigurationAccess
        
        Change-Id: I078c53af6a261da2a618c1cc4e99f26bc03e65c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3191c67deefa13f8c664e0ea1ed27c218b1b6144]

        tdf#153801 fix transparency in About dialog on gen/kf5
        
        This reverts
            commit 6d404f9ccad3ac6a7ffb83876ae7a656bc2d4547
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Feb 5 11:29:27 2023 +0100
            make create_virtual_device not use a separate alpha layer
        
        I made the change to make the
          SalInstanceWidget::create_virtual_device
        and
          GtkInstanceWidget::create_virtual_device
        the same, to make my life easier in landing the transparency->alpha
        patch.
        But that cannot work - the only reason the gtk path works is because gtk
        uses combined alpha (ie. 32-bit) but that requires gtk doing some lying
        and general fudging to the upper vcl layers because they don't know
        about combined alpha.
        
        Change-Id: If0e5046b05302a8f41b87846123685ed8f8e86f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Caolán McNamara  <caolanm@redhat.com>  [e6230bbfc9526af65e6618390593c3a3c90743d0]

        Resolves: tdf#154087 update scrollbar range when search criteria change
        
        Change-Id: Iaf5f20c8952b15f3dcccb65277dadb171a705605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148606
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-10  Vojtěch Doležal  <dolezvo1@cvut.cz>  [531a462f3110b70a6ba56db336dffbb270276013]

        Make sure new bibliography actions work even with tab stops
        
        Change-Id: Ibe7fb7f3608eb734c670501b7d83fca0a5d68946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148486
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca4d4288197c3f3052eda9a914debbad6819d850]

        Use officecfg instead of MailMergeCfg_Impl
        
        Change-Id: I134bf9a0afc31e50629856416e0b52a7113f1e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148605
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b8a9af14d652115e1b17ecca79b647e94a63ef5]

        Use officecfg instead of chart::ConfigAccess
        
        Change-Id: I9bf7f05ab1d303bbf1de289b101989178f0421cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Mark Hung  <marklh9@gmail.com>  [9e6ff03454c2c554fc81b5f5d453a02edd5245d1]

        tdf#114556 fix vertical writing emphasis mark position.
        
        1. Calculate emphasis mark offset from base line using
        ascender + descender, so it won't be too close or even overlap
        with the glyph. It's an approximate for ideographic embox right
        or ideographic chraceter face right.
        
        2. CJK Ideographs have different drawing base positions.
        Besides, it seems that glyph bound rect isn't consistent among
        platforms, so use glyph advance information ( pGlyph->origWidth )
        to calculate proper position and center the emphasis mark along
        glyph advance axis.
        
        Change-Id: I93676656ed2a1b12a2237a9af94d772879eb7ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147748
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2023-03-10  Patrick Luby  <patrick.luby@collabora.com>  [57b88be1e10e131aea429e205fd426b7dab2ba2d]

        Reset dark mode colors in HITheme controls after printing
        
        In dark mode, after an NSPrintOperation has completed, macOS draws
        HITheme controls with light mode colors so reset all dark mode
        colors when an NSWindow gains focus.
        
        Change-Id: Ifdbb7d2eff8157ed0d711cf975c2ad1fdcf63495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-03-10  Miklos Vajna  <vmiklos@collabora.com>  [656850deda2bd478b828a761d2231c65b1fa771e]

        xmloff: fix -Wmaybe-uninitialized
        
        In case operator >>=() of uno::Any fails, it leaves nTabIndex
        uninitialized and it seems gcc notices this sometimes:
        
        In file included from include/com/sun/star/uno/Any.h:30,
                         from include/com/sun/star/uno/Any.hxx:35,
                         from include/o3tl/any.hxx:21,
                         from xmloff/source/text/txtparae.cxx:22:
        include/rtl/ustring.hxx: In member function ‘void XMLTextParagraphExport::ExportContentControl(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>&, bool, bool, bool&)’:
        include/rtl/ustring.hxx:3044:22: warning: ‘nTabIndex’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         3044 |         return number( static_cast< unsigned long long >( i ), radix );
              |                ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        xmloff/source/text/txtparae.cxx:3999:20: note: ‘nTabIndex’ was declared here
         3999 |         sal_uInt32 nTabIndex;
              |                    ^~~~~~~~~
        
        Change-Id: Ia39e85575bde4011247583265497ddf4d0d4c52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148598
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-10  Michael Stahl  <michael.stahl@allotropia.de>  [a20591e08d8996db02f3811b62b06f12a9f033e1]

        sw: PDF/UA export: produce ListNumbering
        
        As required by ISO 14289-1:2014:
        
          7.6 Lists
          — An explicit ListNumbering attribute shall be used for L tags in
            ordered lists as specified in ISO 32000-1:2008, 14.8.5.5, Table
            347.
        
        Change-Id: If3d1e4aa63f7bcfba1a28294fe9f59cf2e068070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148557
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-10  Tünde Tóth  <toth.tunde@nisz.hu>  [05df784c6febd1d77e95db8ef3dfdc03347a48a3]

        tdf#149996 DOCX export: fix hyperlinks in nested paragraphs
        
        Close all hyperlinks in the paragraph where they start.
        
        Regression from commit 20a3792502120d67b1a9fdea641e15ea504359d3
        "fdo#76316 : File gets corrupt after Roundtrip".
        
        Change-Id: Ied5be90601f5a494f927d43aa6ff7efd3545f993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148353
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [50b68c341f2543c4d841fce4d4b3e080f4491e1d]

        improve loplugin:unnecessarylocking
        
        to find more locking we can remove
        
        Change-Id: Ief7bc5ec2a1ff31f22a0ad366910b7fcc4725818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [8ceb85cafb0af066c5b8466da61a46eef2779dc6]

        tdf#153735 update tooltip because outline level "Text Body" -> "None"
        
        Change-Id: I2af0ba85bcd30c89e7948d6057ccbb6a1e64f449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148503
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-10  Michael Stahl  <michael.stahl@allotropia.de>  [9b38beadf9eaf027b201cdf0ecb2bce5611014dd]

        sw: PDF/UA export: produce Lbl tagged element
        
        Commit bd66a0201fb6d1a127139287cc8b5bd27e3a92c3 did this for editengine
        text in shapes, but it turns out it's a little more complicated in sw.
        
        The SwTaggedPDFHelper nicely lived stack allocated, but list labels are
        SwLinePortions inside a paragraph, and they can't be painted separately,
        so if there's a list label the creation of LBody has to be delayed until
        that is processed.
        
        The SwNumberPortion can't even generate the Lbl itself, because there
        can be multiple portions, they are broken across lines and at script
        boundaries, and checking their follow flags is also tricky (see previous
        commit).
        
        Change-Id: I0dd383089a7ca0edddf6f805e79615c611a446f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148556
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-10  Michael Stahl  <michael.stahl@allotropia.de>  [6c0105307efa15837e9e5287103995312f373b67]

        sw: fix stale SwNumberPortion follow flag
        
        Somehow a SwNumberPortion can be split into 2 SwNumberPortions and the
        2nd one ends up with a '\t' character that is then removed from the
        portion and via some HookChar thing converted to a SwTabLeftPortion.
        
        To add further insult, the SwTabLeftPortion is inserted between the
        first SwNumberPortion and the empty SwNumberPortion, and then
        SwLineLayout::CalcLine() deletes the empty one but the first one still
        has the m_bHasFollow flag set.
        
        Change-Id: Ic902ed7f35d7faf168bef636b869e5cd9e2435ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148555
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [76fcddcd955ba26655dcfc0d6261f4c00be375fe]

        Revert "Resolves: tdf#152411 clear before freeze to let gtk a11y ...
        
        ... drop reference"
        
        It's no longer needed, since the original problem is solved
        differently with Change-Id Id0c241d68ec4fbf933312008f7d0ee86bd3eab0c
        ("tdf#140659 gtk a11y: Don't unset model when freezing icon view")
        in place.
        
        This reverts commit 4e8331b77a2dcad2b10d3ca5b788711ea4e83a1b.
        
        Change-Id: I5c94a1c610a807a09ab62577477135cc14dbcfa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148558
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [1255e9b3c0ed82014a8c0832c40e4c7d8f9c5756]

        tdf#140659 gtk a11y: Don't unset model when freezing icon view
        
        As described in Change-Id I10249bbd8c684e89174ba91ce4690d37c24b5d5c
        ("tdf#153657 gtk3 a11y: Use IconView item tooltip as a11y desc"),
        freezing the gtk3 icon view previously resulted in the accessible
        child objects not being created at the time of insertion,
        so setting the accessible description on them doesn't work.
        
        As a result, e.g. the Orca screen reader would not properly
        announce the focused item in Math's elements dock window when using
        the gtk3 VCL plugin.
        
        This was caused by clearing the model in
        `GtkInstanceIconView::freeze` (and resetting it in
        `GtkInstanceIconView::thaw`).
        
        Stop doing that to fix the problem.
        
        Thanks to Caolán for this suggestion!
        
        This also allows to revert
        
            commit 4e8331b77a2dcad2b10d3ca5b788711ea4e83a1b
            Date:   Wed Dec 7 13:20:03 2022 +0000
        
                Resolves: tdf#152411 clear before freeze to let gtk a11y drop reference
        
        in a follow-up commit since the problem described in
        tdf#152411 also no longer happens with this in place.
        
        Also switch the previous check + SAL_WARN to an assert
        now that the underlying cause has been addressed.
        
        Change-Id: Id0c241d68ec4fbf933312008f7d0ee86bd3eab0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148535
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [ba0e36e607d1c380fd09b6725a4ebcb69ff399de]

        tdf#153657 tdf#140659 gtk3 a11y: Use IconView item tooltip as a11y desc
        
        Similar to how the non-gtk SalInstanceIconView does since
        
                commit 2a28ebeef5ea3e2b01d836a7233d2316b765bf38
                Date:   Wed Jun 1 11:18:26 2022 +0300
        
                    Accessibility for IconView
        
        , use the tooltip as accessible description for
        the gtk3's IconView implementation as well.
        
        (Another alternative might be to always require passing
        a text/name in weld::IconView::insert, e.g. by turning the
        `const OUString* pStr` param into a `const OUString&`
        and adding a bool param to indicate whether the text
        should be shown on screen or only used for the accessible
        *name*. Might make sense to reconsider that when looking into
        the remaining aspects from the IconView a11y discussions in [1]
        and [2].)
        
        Together with Change-Id Ic77cf485ed4b2b413d3d3368c15b788d693111cd
        "tdf#153657 a11y: Set tooltip/a11y desc for fontwork styles",
        this makes Orca announce the items in the fontwork
        gallery by their title when using the gtk3 VCL plugin as well.
        
        Setting the accessible description for the items in Math's
        elements side bar still doesn't work with this change by
        itself, since the fact that the IconView is frozen
        (s. the call to `freeze()` in `SmElementsControl::addElements`)
        apparently prevents the creation of the accessible child objects
        on insertion (s. upcoming Change-Id Id0c241d68ec4fbf933312008f7d0ee86bd3eab0c,
        "tdf#140659 gtk a11y: Don't unset model when freezing icon view").
        
        [1] https://gerrit.libreoffice.org/c/core/+/135226
        [2] https://gerrit.libreoffice.org/c/core/+/135593
        
        Change-Id: I10249bbd8c684e89174ba91ce4690d37c24b5d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148534
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-10  Michael Weghorn  <m.weghorn@posteo.de>  [1fbf95190ea0b3f14060193c51ff31ae178a992a]

        tdf#153657 a11y: Set tooltip/a11y desc for fontwork styles
        
        Add a map between ID and title and use that in a newly
        introduced tooltip query handler to return the item's title
        so it is shown as a tooltip.
        
        This also implies that the title is used as the accessible
        description for the items for the non-gtk case, see
        `SalInstanceIconView::EntryAccessibleDescriptionHdl`,
        introduced in
        
            commit 2a28ebeef5ea3e2b01d836a7233d2316b765bf38
            Date:   Wed Jun 1 11:18:26 2022 +0300
        
                Accessibility for IconView
        
        Therefore, the NVDA screen reader on Windows now
        announces the items using their title when they
        receive focus.
        
        Change-Id: Ic77cf485ed4b2b413d3d3368c15b788d693111cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148523
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [66b0bc55854ba13b92b6c39b95f3f2d4ef76bf20]

        simplify initialisation in *DatabaseMetaData
        
        Change-Id: I1d7e107e22a98489e4d1013e14bb780e20d87c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148594
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Miklos Vajna  <vmiklos@collabora.com>  [913b71dbe06c33773c4d779e00c6ec4b6a4af59f]

        sw floattable: ignore height of masters in lcl_CalcMinRowHeight()
        
        The problem was that the bugdoc has a split row and the minimum row
        height was only enforced for the master row, not the follow one.
        
        It seems this behavior started with commit
        6f5024de2e1a5cc533527e45b33d9a415467c48d (tdf#104425 sw: split rows
        w/large min height (fix layout loop), 2016-12-08), because that had a
        case where the minimum row height didn't fit a page, but moving to the
        next page didn't help, so we hit a loop. The trouble is that when we do
        have enough space in the body frame, then not enforcing a minimal row
        height for each part of a split row leads to bad layout, since the row
        height will be smaller, so content after the table moves up.
        
        Fix this by checking if the body frame has enough space
        and not consider the height of the master + previous follows in that
        case.
        
        This is just for floating tables at the moment, doing this in general
        may need more work. With this, orig-nocompat.docx from tdf#61594 renders
        correctly with SW_FORCE_FLY_SPLIT=1.
        
        Change-Id: I922434db8455aba03ebeab9eae845003935f1d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148595
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5e937a3d1ee335eebb327af0bbb8687c68169f42]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f9538fa1e908f7a8ecbd5f0d27c4ff72a53ad294
          - tdf#153735 changes because outline level Text Body -> "None"
            
            Change-Id: I9e37dc4033133a29862837c46ba1dc7890db559d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148614
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-10  Pranam Lashkari  <lpranam@collabora.com>  [f973d0259de40e77709f487e87db5f29437d60db]

        jsdialog: enabled Format Paragraph dialog (writer)
        
        can be found from:
        Tabbed view > Format > Paragraph
        sidebar > Paragraph
        Compact view > Format > Paragraph
        
        Change-Id: I5b0e59c88017cb039f9e441be76c350bf39f9614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148398
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-10  Heiko Tietze  <tietze.heiko@gmail.com>  [dc238d75ba2ed49d76c1782043817f57f0a560b3]

        Resolves tdf#153735 - No outline level should not be called Text Body
        
        Changed to [None]
        
        Change-Id: I841664f432d9235ac5486af7d27ba141ce35cd48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148562
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-10  Vojtěch Doležal  <dolezvo1@cvut.cz>  [61d55b67b02a74456a407b84fcba82d8c39bc697]

        Moved target-url and use-target-url into loext namespace
        
        Change-Id: I4307a20f34543d4a187b5e59f117b43371f6f6fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148559
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-10  Paris Oplopoios  <paris.oplopoios@collabora.com>  [c1d6af3e9a8937cef192e2764ad4afb572743d86]

        sw lok: notify clients about view option changes
        
        Send a string of the view options to the kit when the view changes
        
        Change-Id: I89f65ff1d22a83a54dde35e39eb487edda0b58e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148078
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f5b7967b01e68a16ff2f9bc94afec7d405d03dbd]

        tdf#153243 Make "level" label and tooltip correspond to actual behavior
        
           Decided (e.g., in tdf#147004, comment 20) to make UI reflect current
           actual behavior. Therefore, this patch changes "Outline level"
           to "Up to level" and its tooltip and extended tip are modified to
           reflect actual behavior.
        
        Change-Id: I6d7d14d6b6bc8f0000e748ddf15690474374e360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148511
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-10  Miklos Vajna  <vmiklos@collabora.com>  [9c75a7c950c6315b5f839d2711fb9ec0890739b8]

        sw layout xml dump: extract SwColumnFrame::dumpAsXml() from SwFrame
        
        Ideally SwFrame should not really know anything about columns.
        
        Change-Id: I0672dc685e846caa08ec9fe329ef45ec34aff04a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148563
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [13a9d32cd1d6f8f95efbea5f6a85d50159d3baaa]

        simplify initialisation of some pool defaults
        
        Change-Id: I794e528a08a5a76cef1955f5c4f3e594f1e90f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148537
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-10  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [83ea56910ca0829ad48e5fa15099f0dca5e73ee7]

        tdf#154106 Colibre: Add Bulb assets for ToTD
        
        Change-Id: I074cf1dc2d5f439b1e896767209519fb2b0ad01c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148569
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [688f73c06e154018489b1ae36eabcd12b0d872a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bf58601f847370be00b3e600a7a3fdac9e6b315
          - tdf#153549 more "chapter" to "heading" adjustments
            
               Possibly this is the final patch needed to change
               "Tools - Chapter Numbering" to "Tools - Heading Numbering".
               Also, "chapter" is changed to "heading" where appropriate.
               Where appropriate or necessary, corrections or command
               updates were made.
            
            Change-Id: I00a72a3c09909f2cf0a0ebe1320f5744c4ae4b68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148506
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [28e16dfab5b134b2f8dbc3804677329d3db98ae3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0affdd29956c531bf624da7c69c780e8ee2f14a6
          - tdf#153561 add <widget> to N#
            
            Change-Id: I1d8b36b06741a303b6e4a67e863b531a9b7dc55d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148512
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-09  Regina Henschel  <rb.henschel@t-online.de>  [be7455813557f4289b31d5bb1b68ce1a44a86669]

        rename struct gradientStopColor to GradientStopColor
        
        This is a follow-up to commit d95a09c1fca70d658207b8c48761af32dd2df213.
        The change has been requested by reviewer Miklos Vajna.
        
        Change-Id: If59cee0b757ef0afe0b48c5bce9d9e3024e81e4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148566
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [b6d1cb887438733da2465f107da5088f9826435e]

        cid#1521901 Pointer to local outside scope
        
        Change-Id: I38e76440606afb65a8c1ce419c446e234a513659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148550
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Vinit Agarwal  <agarwalvinit5678@gmail.com>  [d898620cb47e0d794d4033fdfa13b049f972a9ff]

        tdf#147021 - Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Modified updatecheck.cxx where SAL_N_ELEMENTS (nRetryInterval) was used
        to get the size of the array. Now it is replaced with std::size().
        
        Change-Id: Ib43ff3ecaeb8e853f14d5b0be45654596a817ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148367
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [9aca8e1333393af69972450d5e7e924cdfed4269]

        Use officecfg instead of SvxLanguageToolOptions
        
        Change-Id: Ia9add4ff3ebe20ba491e33de1e9a2644a48ef7a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148548
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [92598f5a5eed932048e060ab2ca17ffcbcca56dc]

        CppunitTest_sw_layoutwriter: split in two
        
        it already has 110 tests
        
        Change-Id: I4f218c873b5771e46cd2037249f0bb9db5f6b808
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [560a6307a1407176c1cfce77daaba38f5cc24798]

        tdf#153465 & tdf#153344 Sukapura Dark with 16px status bar icons
        
        Change-Id: If255495c43f4606b7931b86901449453189e9994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148551
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-09  Miklos Vajna  <vmiklos@collabora.com>  [ff1640fd59560a2a9c9a5685fb349b1d4c936845]

        sw layout xml dump: allow invoking this from out sw/ in a debugger
        
        This is similar to SwDoc::s_pLast, but for the layout.
        
        Change-Id: I48bb53a7595a4cec3fe47c563e91db671643d6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148529
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [785bd2af80704a032e185853ad6d9327e1a78fc7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d1b4263237f2cb02929156ff556cc12f6460380f
          - tdf#153561  adjustments for "Format" because of widget name change
            
            Change-Id: Iaead2cc332a8889f8c174f1ccf84e9cdfbfc154c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148507
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b87bcf08cedd444ba8b4de87a6c2b81e1d5fb0d]

        remove some unnecessary locking in TypeDetection
        
        the FilterCache class is already internally thread-safe
        
        Change-Id: Ic869bda1257cc61fc69557624c8d6e169645b23a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148538
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-09  Heiko Tietze  <tietze.heiko@gmail.com>  [49379a0b3fc7b263a7e5be2ecbb018e9248d01f2]

        Resolves tdf#131177 - Replace Hard-Coded TotD bulb by themeable icon
        
        Change-Id: I25006f64436a72f554450929b1b649478b02cbc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148536
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-09  Tünde Tóth  <toth.tunde@nisz.hu>  [ed77023797985e62e8f0af29326a61f55a65ae0a]

        tdf#148026 DOCX export: fix link with target frame and anchor
        
        Hyperlink with target frame and anchor didn't work after export.
        
        Change-Id: I84980e30d2e1d6d53cfe201cf4cac60354151aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148041
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [153313dd195004fc735f92a0623cde4493e10358]

        cid#1521899 Dereference after null check
        
        Change-Id: I6cbdabfe794e37f7e00fa730f672bf8318b86b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [369f65d4aac9f75bec8c5527c8d08d9eda73d13e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a25d11512dc078fc47c546585c9663b5804a3eb
          - tdf#153561  "Chapter No." -> "Numbering" because of widget name change
            
                also corrections to "Numbering" and "Entry text" descriptions
                refactor <h2>,<h3> and remove <xml-lang>
            
            Change-Id: I19fe8d8ecf74f3526a4d10b18a76ad1da47ad5c3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147370
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-09  Julien Nabet  <serval2412@yahoo.fr>  [ee19ca22866c99be6422abd7c6ad2ffe51020b5e]

        Wrong value for VT_UI4 (sd/propread)
        
        9 instead of 19
        see https://learn.microsoft.com/en-us/windows/win32/api/wtypes/ne-wtypes-varenum
        
        Change-Id: I00283e117a2a2fd2d5165047bf7dcad82ffc18ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148446
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [3579343ec00adcbf54938e59d27cc52d11ddb920]

        Some refactoring and deduplication
        
        Change-Id: I443bd562bc9df6636bf71a230a05a12e443c6614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148532
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [33153adfc26e256e3cba27ae8de0ddbbd9f7ce78]

        ofz#56819 Null-dereference
        
        since:
        
        commit d062f097cc48bd53247b7fb0c677d90fcc430ab7
        Date:   Wed Mar 8 02:14:11 2023 +0300
        
            Simplify usage of BinaryDataContainer
        
            It is always used to store data read from streams
        
        Change-Id: I33d237a801b1cdf47b85b3fd3522c398ba08068b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Arvind K  <khandelwalarvind26@gmail.com>  [013fbfb592f71c1f0a60b6a7ec08aded375515ac]

        tdf#114441 Convert sal_uLong to better integer types
        
        This patch replaces sal_uLong usages in cui directory.
        changed m_nOldCount in cui/source/inc/dbregister.hxx to size_t.
        m_nOldCount has been used in dbregister.cxx where it is initially
        assigned a value 0, later on it has been assigned the value
        returned by registration.size() which returns type size_t.
        Line 272 in cuigaldlg.cxx mrTakenList with type TokenList_impl
        is pushed back with variable nPos of type sal_Int32 hence
        changed TokenList_impl to store sal_Int32 types.
        
        Change-Id: Ie0ba284dc4592cc69a1ded2fe232d18aaec3c92a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148237
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [bef33a6c59df9943a0453b20237e53d4794e9304]

        ofz#56818 Integer-overflow
        
        Change-Id: I4be620619e407be132b92f4ce82b7a26dbc34406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148531
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab8ebc65af13873cccb89f56d1027521f6d0f87e]

        remove dead code in SwNodes::FindPrvNxtFrameNode
        
        ever since
            commit af4e20426ad24c6f2c0164b37472f2b7b54ecd30
            Author: Michael Stahl <michael.stahl@allotropia.de>
            Date:   Tue Dec 21 15:19:33 2021 +0100
            tdf#135061 sw_redlinehide: create frames following hidden table
        
        Specifically, remove the line
           pFrameNd = &aIdx.GetNode();
        because the pFrameNd is then immediately overwritten with nullptr.
        
        Also re-indent the resulting code and removing an unnecessary block scope.
        
        Change-Id: Ic4d40ee7835ed73038eba9da7ec72670cf0b97b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148384
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [59b0f676758dd752457c84fb4159f6446d74e8a4]

        ofz#56826 Heap-use-after-free
        
        since:
        
        commit abda72eeac19b18c22f57d5443c3955a463605d7
        Date:   Mon Feb 20 00:32:22 2023 +0100
        
            tdf#82984 tdf#94915 zip64 support (import + export)
        
        Change-Id: Iffc1c54b3ccc5464e217d7f94ecc34b57ec1afb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Yousef_Rabia  <yousef.mohamed.rabia@gmail.com>  [ddd2e00278eb489576eb4c63f44a1a034e7b9d8e]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I1c175753242783d83b5b1edc9b8b4cee2a5bd277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148449
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-09  Stephan Bergmann  <sbergman@redhat.com>  [b48371ba614d300ab5906bbc723c87095cfcd8f2]

        Silence false -Werror=dangling-pointer=
        
        ...that hit at least with GCC 13 trunk and --enable-optimized,
        
        > In file included from sw/inc/tox.hxx:35,
        >                  from sw/inc/doc.hxx:35,
        >                  from sw/source/core/inc/AccessibilityCheck.hxx:14,
        >                  from sw/source/core/access/AccessibilityCheck.cxx:11:
        > In constructor ‘sw::ClientIteratorBase::ClientIteratorBase(const SwModify&)’,
        >     inlined from ‘SwIterator<E, S, <anonymous> >::SwIterator(const TSource&) [with TElementType = SwTextFrame; TSource = SwTextNode; sw::IteratorMode eMode = sw::IteratorMode::UnwrapMulti]’ at sw/inc/calbck.hxx:364:68,
        >     inlined from ‘virtual void sw::{anonymous}::FakeCaptionCheck::check(SwNode*)’ at sw/source/core/access/AccessibilityCheck.cxx:937:99:
        > sw/inc/calbck.hxx:295:32: error: storing the address of local variable ‘aIter’ in ‘sw::ClientIteratorBase::s_pClientIters’ [-Werror=dangling-pointer=]
        >   295 |                 s_pClientIters = this;
        >       |                 ~~~~~~~~~~~~~~~^~~~~~
        > sw/source/core/access/AccessibilityCheck.cxx: In member function ‘virtual void sw::{anonymous}::FakeCaptionCheck::check(SwNode*)’:
        > sw/source/core/access/AccessibilityCheck.cxx:937:14: note: ‘aIter’ declared here
        >   937 |         auto aIter = SwIterator<SwTextFrame, SwTextNode, sw::IteratorMode::UnwrapMulti>(*pTextNode);
        >       |              ^~~~~
        > sw/inc/calbck.hxx:289:53: note: ‘sw::ClientIteratorBase::s_pClientIters’ declared here
        >   289 |             static SW_DLLPUBLIC ClientIteratorBase* s_pClientIters;
        >       |                                                     ^~~~~~~~~~~~~~
        
        (And -Wdangling-pointer is unknown to older GCC versions, so would cause
        -Werror=pragmas there.)
        
        Change-Id: I64e53b52e04ab34da42c7adc54b8d8cb46123dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148515
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4322248194c2b019c20f593ad9971a1014a7e7bc]

        add a missing space in formatting
        
        Change-Id: I17263a1a29ba0bb0821d11234d05b55f0697e34c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148496
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-09  Miklos Vajna  <vmiklos@collabora.com>  [ab61be6ed502349152b165bc3db4c61f04c2f20d]

        sw doc model dump: allow invoking this from outside sw/ in a debugger
        
        There is only a single SwDoc instance in many cases, having an easy
        to access pointer to that is helpful when the backtrace doesn't include
        a frame in sw/ code.
        
        This allows something like 'print SwDoc::s_pLast->dumpAsXml(0)' in gdb,
        even if e.g. the current frame is xmloff/, without hunting for a parent
        that is in sw/.
        
        Change-Id: Id70baf7919ef6fde7b834704741dab70531e7e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148522
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [db06ae5475bfd64c8acf3073c72193babbd4b822]

        tdf#149144 Icons for sm Formula Editor in Sidebar Deck
        
        Change-Id: I851e0e45df3331012eddcaa3240c6ffb27054e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148520
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-09  Caolán McNamara  <caolanm@redhat.com>  [45d335e388566565ed53f7f7628f7351f88fd242]

        crashtesting: assert seen on load of moz1297206-1.svg
        
        Change-Id: Ide16b0086ef81bb9580b93f63c2c5220459d74d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-09  Regina Henschel  <rb.henschel@t-online.de>  [d95a09c1fca70d658207b8c48761af32dd2df213]

        tdf#51195 add docx export of gradient fill of Fontwork shapes
        
        FillGradient, which is a awt::Gradient, has many features which cannot
        be represented in the <w14:textFill> element in docx. Therefore often
        only workarounds are possible.
        
        ELLIPTICAL and RADIAL are exported to 'circle', SQUARE and RECT to
        'rect'. 'Angle' is ignored. A focus point is used instead of a focus
        line.
        LINEAR and AXIAL are exported to 'lin'. AXIAL is done be compress and
        mirroring the color stops. Using Words feature of reflecting a gradient
        would prevent detecting 'axial' in the current import filter.
        
        'Border' is exported by introducing additional color stops.
        
        'StepCount' is ignored. A workaround using additional color stops is
        possible, but would require a simultaneous change of the import filter.
        
        'StartIntensity' and 'EndIntensity' are exported as 'lumMod'.
        Theme colors are considered where they can currently occur. But
        tdf#151882 is yet not fixed, so Word will not render them because of
        missing Theme folder.
        To allow 'lumMod' and theme color and RGB color as well, the color of
        a color stop is hold in a struct.
        
        In case of two color stops, the color stop at position 0% is doubled.
        That way Word uses the same linear color transition as LO and not its
        quadratic one. AXIAL too introduces two color stops at position 50%.
        Emulating 'StepCount' would produce two color stops at same position
        too. Therefore a std::multimap is used for the color stops.
        
        The implementation has a lot local parts. If they should be useful
        for Fontwork shapes in Impress/Draw, they can be moved and adapted
        later. The implementation separates the calculation of the required
        color stops from the generation of the markup, so using parts in
        Impress/Draw is likely possible.
        
        Change-Id: I1032ab8d37b6f112d66f85a30210ebda3ae54486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148354
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-09  Miklos Vajna  <vmiklos@collabora.com>  [78b1631e9649402e29c906c7023f55ed2cbe84f9]

        sw floattable: enable widow / orphan control in split rows
        
        The bugdoc has a single table cell, and widow control is meant to move
        the last 2 lines to the second page, but only one page was moved there.
        
        The problem is that widow / orphan control was completely disabled
        inside split table rows, but Word does this.
        
        We know when a table comes from a Word document, so in that case enable
        widow / orphan control inside split rows as well.
        
        Do this only for in-fly tables for now, doing this in general would need
        more work, as pointed out by CppunitTest_sw_layoutwriter's
        testForcepoint76. It is an RTF file that doesn't open in Word, but we
        would layout-loop on it if this would be enabled in general right now.
        
        Change-Id: Ie37be61443a274f408e1124983d1d495de5636c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148521
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-09  Franklin Weng  <franklin@goodhorse.idv.tw>  [d2e8705c9cc503afdaed366b1f71ed012b0c568f]

        tdf#153839: add newline after certain tags
        
        Add newline after certain tags in head section and paragraphs, to make generated xhtml easier to read.
        
        Change-Id: I9562ef48d9dd1283110be4a45527616dce186681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148026
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-09  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [bc8b153da74b0961cc3c48691d41b4e16c6d4f5b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d399273cdb7cfb2b90260d40e49e81ac75398718
          - Update more references to the Extensions dialog
            
            Change-Id: I478df514a784bac03c4acdca935df184accd6b6b
            
2023-03-09  Maxim Monastirsky  <momonasmon@gmail.com>  [37b2bb1f6c18b915286264682bf0b3c25f0d552a]

        tdf#154050 Unset external pointer before destroying
        
        Regression of 48ca2336251d62ac2e90300cd9945fb84b1cddd8
        ("tdf#125040 Avoid flickering on context change").
        Before that commit the state of toolbar commands was
        updating async, which is how it managed to not crash.
        
        Change-Id: I07e2ce25faf848c7db33dd029b54a98bafcf8fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148518
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2023-03-09  Stephan Bergmann  <sbergman@redhat.com>  [a5c83673ba987bd6ed1a36fe5b8c4b1f600f9626]

        Demultiplex test code
        
        It is so much easier to work with if a test failure's line number unambiguously
        points at the code's sole execution.  (That is, test code is necessarily non-
        DRY.)
        
        Change-Id: I75919c55671348f6190e9e108e72e24ec18ce986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148514
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-09  Stephan Bergmann  <sbergman@redhat.com>  [f194f9dba0aee30de9d5701f2ff0ce60c785131d]

        Re-enable CppunitTest_emfio_wmf for --enable-mergelibs
        
        It had originally been disabled by a037f6338c19e16bcbc0674214666a786872c59d
        "Disable CppunitTest_vcl_wmf_test under --enable-merglibs for now" because "the
        problems caused by that test having the vcl objects linked into both the test's
        library and the mergedlib (which the test's library links against) are just not
        manageable", which is no longer an issue at least since
        29cdfa3fc337381e2529eaac2a551137ee8a1aaa "no need to statically link against the
        emfio library in the tests".
        
        But the test code apparently uses WinMtfFontStyle, which can thus no longer be
        hidden under --enable-mergelibs.
        
        Change-Id: Ie807b19f0cb44408c69d03faca01fabe88239ca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148493
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-09  Miklos Vajna  <vmiklos@collabora.com>  [db73d73c4031c20cede546e00b2fc34d673f3069]

        sw: fix undo comment of FN_UPDATE_BOOKMARKS
        
        It's updates, not insert. One has to dispatch .uno:UpdateBookmarks to see
        this in action, which does something if the document already contains at
        least one bookmark.
        
        Change-Id: I32d259b0b5c18cbbec2969cd189ca7ba4dd0dde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148487
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a7952b339e73d203ba7d2b4f701d3279bb581d16]

        Fix typo
        
        Change-Id: Ie69dd2bacbd1f1680d82ad113b707cca24950d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148471
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5eae429d026b3f502e40265376772e2188239fb5]

        Fix typo
        
        Change-Id: I4c48c988667ffd9221a0e226ab9c35e1e857e9d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148489
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [082d009b6a156faa74c9966b0dffc5fa6ce22287]

        Sukapura: tdf#152887 Add status bar icons for Accessibility Check
        
        Change-Id: If5b556fe8263740f26b80961add87398e8b3eefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148517
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-09  Justin Luth  <justin.luth@collabora.com>  [80e8763036f36afd482a06fbf0f3ffe1ebbe2b46]

        tdf#153964 writerfilter: column break split should inherit most properties
        
        When a column break or page break split occurs,
        the split off paragraph should keep (most of) the properties
        of the original paragraph. This already happened for page breaks.
        
        Exceptions are first line indents, and numbering
        if there was a run to apply them to already.
        
        This commit:
        -tells lcl_startParagraph when column breaks are m_bIsParaSplit,
         resulting in the paragraph properties being copied over
        -clears the para properties that shouldn't apply twice.
        
        [Top Margin was more complicated and handled separately.]
        
        make CppunitTest_sw_ooxmlexport18 \
        CPPUNIT_TEST_NAME=testTdf153964_firstIndentAfterBreak14
        
        make CppunitTest_sw_ooxmlexport18 \
        CPPUNIT_TEST_NAME=testTdf153964_numberingAfterBreak14
        
        Change-Id: I5ecd25da831894536044c6dbffbb0a262f8b6828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148452
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6002b5ff598ed63ad8de259b04fc7a17789a1751]

        tdf#152887 Add status bar icons for Accessibility Check
        
        Change-Id: Ied2b876938824c3504231988943851bd97265e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148466
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-08  László Németh  <nemeth@numbertext.org>  [8f26482986fd9af5eac4efd44ec56fd994ec69f1]

        tdf#136904 tdf#116084 tdf#121176 sw: fix Undo & anonymized w:del in w:ins
        
        Undo/Redo crash resulted by the workaround for anonymized
        w:del in w:ins. Anonymized (no time stamp) redlines
        are loaded with Epoch time (1970-01-01) since
        commit 2c51746997478ad5d0e7cc64aa6489769c473d43
        "tdf#146171 DOCX: fix loss of change tracking, if no date",
        so it's possible to fix the original DOCX import problem
        using this value: don't combine anonymized deletion
        inside/over anonymized insertion, and remove all the
        workaround, keeping only their adjusted unit tests,
        and add new tests for the export fixed finally, which
        keeps anonymized w:del in anonymized w:ins.
        
        Revert commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1
        "tdf#125187 DOCX track changes: fix w:del within w:ins",
        commit df4f405a153603551f67e289bbaccf9ac39b923c
        "tdf#121176 DOCX track changes: same size w:del in w:ins" and
        commit 7a810d6a9fb79a24d00e5dbd8e1223e6f8b09677
        "tdf#116084 DOCX track changes: fix w:del within w:ins".
        
        Regression from commit 2de1fd7d8b8bd42c66190140cc4506df0c3367f1
        "tdf#125187 DOCX track changes: fix w:del within w:ins".
        
        See also commit 64dcedcf7c073d1819794d68a33651b14877e1b5
        "tdf#147760 tdf#142902 DOCX export: anonymize date and moveFromRangeStart".
        
        Change-Id: Id6e41187e7f94154389f24dd525067ac47ec7e58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148479
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f5cceefde86bcc7d563469c7aba0009a5611adb0]

        MSVC: use the newer conformant preprocessor
        
        As explained in the /Zc:preprocessor documentation [1], it enables "a token-based
        preprocessor that conforms to C99 and C++11 and later standards", available since
        Visual Studio 2019 version 16.5.
        
        It helps to workaround an IntelliSense bug [2], which disables highlighting and
        code completion in the IDE integration when certain Boost libraries are included;
        but using a better preprocessor can't hurt in general, right?
        
        [1] https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor
        [2] https://developercommunity.visualstudio.com/t/IntelliSense-reports-many-errors-for-the/10287480#T-ND10303205
        
        Change-Id: I5268f2dd4acf01cc1da23cfe76653c2f6c688c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148484
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-08  Caolán McNamara  <caolanm@redhat.com>  [ee5f8b0bb59f974293a1810b5163ecc0cab6cc09]

        cid#1521854 Unchecked return value
        
        Change-Id: I2636790165b2fc0d535d4b8648e16751a0b69e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148470
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-08  Caolán McNamara  <caolanm@redhat.com>  [fa0f8dd9d3dcbbee2d8c23341981635f9c55e55f]

        cid#1521852 Unchecked dynamic_cast
        
        Change-Id: Iec5f58101ca65665d6782e769a5a58765c9e6d37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148469
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c1af1b9c555480305862336954ceefe14865e27d]

        tdf#66613 - Transfer tab: preserve print ranges and col/row repetitions
        
        Change-Id: Ib0e6f9942c2bae1f1fdfa2d0ead0868e9b790b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148284
        Tested-by: Jenkins
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e78e3b2de19f8a2f9b5d6f256bd3b1c147fee780]

        tdf#153712 revise labels for Chapter Info and its related options
        
            "Chapter Info" -> "Heading Info" (in Entries tab)
               add tooltip; revise extended tip
            "CI" -> "HI"  (on Structure widget)
               and its tooltip
            "Chapter entry" -> "Heading info"
                add accelerator
             change labels in dropdown box to number and contents
              (consistent with 'Heading' type field variable)
                add tooltip; revise extended tip
        
        Change-Id: Ic937d0db6af28c9fc416e6a960c0f22a69bfbadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148406
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [b8ef33f1a2037bae927461dc2becdcecdea4d9b0]

        BaseMutex->std::mutex in MutableTreeDataModel
        
        Change-Id: I9028c0ac35b2f375ef0d72201ca4b9f8eb99c7b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Attila Szűcs  <attila.szucs@collabora.com>  [abda72eeac19b18c22f57d5443c3955a463605d7]

        tdf#82984 tdf#94915 zip64 support (import + export)
        
        Implemented import + export for "Zip64 Extended Information Extra Field",
        (in "Local file header" and "Central directory file header")
        and for Data descriptor.
        Focused only to be able to handle files with over 4GB uncompressed size,
        in the zip archive.
        The 64k filecount, and the 4GB compressed size limit is probably still present
        
        Tried to follow pkware .ZIP File Format Specification,
        Some cases were not clear to me and/or some zip compressing tool may not
        perfectly follow the standard, like 'extra field' should be 28 bytes long,
        but its reader now can read shorter (or longer) 'extra field'.
        
        Replaced some 32bit codes with 64bit codes, in stream handling, in deflater.
        
        Tested with an ods file that contained a content.xml that bigger then 4BG+
        (import + export + reimport) on windows.
        I think 4GB+ files import/export would be too slow fot unittest.
        So, for unit test, used the small but zip64 format files,
        that was attached to the bugzilla tickets
        
        Note: It helps with Bug 128244 too (1 of the unittest tests it),
        but that ods file missing manifest.xml, so LO won't be able to import it.
        
        Change-Id: Idfeb90594388fd34ae719677f5d268ca9a484fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147306
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-03-08  Heiko Tietze  <tietze.heiko@gmail.com>  [f1306e1d0f52716cf44a9052654af4133fa2c6eb]

        Fix to SC_VIEWSETTINGS_COUNT
        
        Missed in I8f3e368d4fdad362b819b4ce2fd6b0c32b5c1c0f
        
        Change-Id: Ibb744c0c853813e379eca8558fa114d403a4f494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148468
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [470a2c0692533f42d333b9416daf3f0871cd951a]

        sw: PDF/UA export: produce more headings H7..H10
        
        ISO 14289-1:2014 adds a new feature:
        
          7.4.3 Additional headings
          If a PDF that contains the tags H1, H2, H3, H4, H5, and H6 (in any
          permissible sequence) requires more headings, tags numbered from
          H7 upward (without limit) may be defined and used.
        
        Do not add new enum values H7..H10 to StructElement, because this
        approach results in veraPDF complaining:
        
          Specification: ISO 14289-1:2014, Clause: 7.1, Test number: 5
          All non-standard structure types shall be mapped to the nearest
          functionally equivalent standard type, as defined in ISO
          32000-1:2008, 14.8.4, in the role map dictionary of the structure
          tree root.
        
        Change-Id: Icf39667dee3847f6b755bfa592a9d30ce872c26e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148431
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [255dd20d2f0d6d740a3bcb356ad1e347fe95e33e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 717e288c98b181fe9a49e86f7fa6d4f594df4ab5
          - tdf#153637 update "use level..." option label and explanation
            
               correction to description about what appears in Type box when new
               user-defined index is created, and adding link to relevant help page.
            
               refactor <h1>,<h2>,<h3>,<relatedtopics>
            
            Change-Id: I35ccb871f6da435fac2cdf95f0a47e77baf75476
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148413
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-08  Heiko Tietze  <tietze.heiko@gmail.com>  [0f9226287fec770c4c9c0fe49b1d7046d995a3e9]

        Related tdf#153499 - Index Entry UI
        
        Misleading label "Selection" and associated frame removed
        Nested grids cleaned-up
        
        Change-Id: Ib144d91d6c03a4ae0324c18ad27cde6f25594be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148467
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Mike Kaganski  <mike.kaganski@collabora.com>  [6b6d59d04e0398d67e789db05b6071faf2255ec1]

        Add some SAL_WARNs and SAL_INFOs
        
        These help when debugging the LanguageTool issues.
        
        Change-Id: I04bb84dbffc8e4c4e0b353f8e830fe66d8dff576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148199
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c405820c8e7195e331539e11c5a1ea14596f62a1]

        deduplicate MutexAndBroadcastHelper
        
        there are two very similar classes, standardise on the one in
        include/comphelper
        
        Change-Id: If85729dcea01e65a2d095bb211fe643c783ebf1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Justin Luth  <justin.luth@collabora.com>  [96a502b3756a1c100b40235f50ef2122d5b543f9]

        tdf#153964 writerfilter compat15: top margin after break split
        
        The problem was that the top margin was being applied
        to the new paragraph after the split.
        
        This is absolutely attrocious in MS Word before 2013.
        If I am going to be in error, I want to error on the side
        of being compliant with compat15, since all other versions
        of MS Word are now unsupported.
        
        I think I have the logic of it mostly figured out.
        In compat15, the top margin never applies after the break.
        
        In compat14, if the paragraph properties are not applied
        to a run before the break, then they can be applied after the break.
        
        make CppunitTest_sw_ooxmlexport18 \
        CPPUNIT_TEST_NAME=testTdf153964_topMarginAfterBreak14
        
        make CppunitTest_sw_ooxmlexport18 \
        CPPUNIT_TEST_NAME=testTdf153964_topMarginAfterBreak15
        
        Change-Id: I8816b391e898cfea58c2e0dbf01c881f87bbc4c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148451
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-08  Tor Lillqvist  <tml@collabora.com>  [bcf0f2b6d87f6be18c417e3537f5cf9b320c4348]

        Make error message more useful
        
        Change-Id: I3c6efcbd2a2759385912aa352d0c250963e5f004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148464
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [366812f72f73c12e5be83d27409272769e9337f2]

        UnoApiXmlTest: remove workaround to handle chart file names in tests
        
        No longer needed after 269585d6b461b565fe75f77b6dbf219749edc5ab
        "oox, sd: fix ever-increasing chart IDs when exporting to PPTX"
        and b27b250f70f4651d387ef0646a9668950371e779
        "sc: fix ever-increasing chart IDs when exporting to XLSX"
        Also restored the documents modified in d913584909c2e0a235546a5f800baf45c3446d8b
        "UnoApiXmlTest: merge parseExport from ChartTest" to ensure
        only one chart was possible per document. Sample documents in unittests
        can have more than one chart now, since the chart file name wouldn't
        change
        
        Kudos to Miklos Vajna for fixing the chart file names when exporting them
        
        Change-Id: I10e2c44e41953a2d0d08bbb2a813134861e74660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148461
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d2cdc92d4a2664ead411a5e848dafaf559ba47ce]

        tdf#153637 "Use level from source chapter" -> "Use outline level"
        
            Rename option label; add tooltip; revise extended tip
        
        Change-Id: Idf705bc51d2311e331ab2b7c35bff2963cf20376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148330
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Caolán McNamara  <caolanm@redhat.com>  [842c2f1d4725b654f141b2b1695a174afc9b02b4]

        Related: tdf#152278 distinguish likely-invalid vs unimplemented in warning
        
        Change-Id: Iafe54afcc16e255e7fb82e14710485fa22e2e491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [806e8f0232b9761e2d1896f0e4cda1d6ce0e258c]

        vcl: PDF export: remove versions PDF_1_2, PDF_1_3
        
        These cannot be selected by any means, so this is all dead code.
        
        Change-Id: Ia24dddb4c36d0a3fef60a1dbf02562a8e6dbfce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148389
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-08  Grigory A. Mozhaev  <zcrendel@gmail.com>  [3fcf9f864f9d12fdb0ade4741127c81cec74378a]

        tdf#97551 Added marker and hint for formula to Calc
        
        Added option "Formula indicator and hint" to LibreOffice Calc > View section (near to "Comment indicator"). This option turned off by default to avoid interfere existing UX.
        
        Indicator displays in the bottom-left corner as blue triangle marker if cells contains formula (correctly reacts on cells merging and different sizing).
        
        Hint displays when user hover cursor over the cell that contains the formula (uses already built-in mechanics for help tooltip).
        
        More details about request and discussion of the feature in Bugzilla.
        
        Change-Id: I8f3e368d4fdad362b819b4ce2fd6b0c32b5c1c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147914
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [e624e07cc54c408bb86bd2e52cfed3c7ec59fb4a]

        vcl: PDF export: default to PDF 1.7
        
        Released by Adobe in 2006, and standardized as ISO 32000-1:2008.
        
        Change-Id: I22c89019905c90e10fefb752c210ec7ea81b725b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148388
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [7a907965cc6246ab644be92811e35d9f73a90e86]

        vcl,sw: PDF/UA export: tag headers and footers as required
        
        ISO 14289-1:2014 has one requirement for specific tagging of artifacts:
        
          7.8 Page headers and footers
          Running headers and footers shall be identified as Pagination
          artifacts and shall be classified as either Header or Footer
          subtypes as per ISO 32000-1:2008, 14.8.2.2.2, Table 330.
        
        It was not immediately obvious how to implement this but the functions
        used for tunnelling structure element attributes through MetaFile can
        be used for this purpose as well with a few tweaks.
        
        Change-Id: I19a3192b1b56b82ed11972c4bbe8d20ab13567be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148387
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-08  Michael Stahl  <michael.stahl@allotropia.de>  [4e5489297cb5cfb8d2387d57da7cd92ae1a3ebb1]

        vcl,filter,officecfg: PDF export: add PDFVersion::PDF_1_7
        
        Also, PDF_A_2 and PDF_A_3 are based on PDF 1.7, claims Wikipedia.
        
        Change-Id: Ia0afd9a38859953db945a5d1568f171f3d500b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148386
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-08  Stephan Bergmann  <sbergman@redhat.com>  [ff5d23638b198438906fa3f91cee38a8b1dbc82e]

        Restore .git-hooks/commit-msg
        
        ...that 729ae5135042427b62a856d792f51afad1026622 "Update Sifr Mimetype Icons"
        had modified, presumably in error
        
        Change-Id: I077eeb2d304d145a68edceae7196417b329adaee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148458
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-08  Heiko Tietze  <tietze.heiko@gmail.com>  [68b6d507342a440b5441882e74587054d530687b]

        Vertically center statusbar images
        
        Change-Id: Iecdeeda5c10b2322bdf71e84864ed8104581589f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148424
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb9713daa1a2ce0d5551fa10d6cc12084730fa58]

        osl::Mutex->std::mutex in ExtMgrDialog
        
        Change-Id: I6e0997b1f4fb49459637ce82178c33460eed1188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [8521c5b4d61df2339e656c052853fce8d6b9c536]

        osl::Mutex->std::mutex in PackageManagerImpl
        
        Change-Id: I613a8846270f4b42125f24d9a7b99ecc12e2edb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [32cf9f7f0ba674217b809674eb9a951ea1b0c9c3]

        new loplugin:unique2optional
        
        I used this plugin to find places where we could inline a small child
        object into a parent object, saving allocation overhead.
        
        Moving it directly into store/ because it is not intended
        to be run under normal circumstances, needs hand-holding.
        
        Change-Id: I7245eef3dba187988bb9d4a39fd80624f46355d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Miklos Vajna  <vmiklos@collabora.com>  [b27b250f70f4651d387ef0646a9668950371e779]

        sc: fix ever-increasing chart IDs when exporting to XLSX
        
        Similar to what PPTX already did.
        
        Change-Id: I17d8ccf3fb7111e1cbf9dc019d1032ed7ed530fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148460
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-08  Vinit Agarwal  <agarwalvinit5678@gmail.com>  [df28c5ac2d4883706556772462933f70151fa379]

        tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors
        
        modified: oox/qa/unit/drawingml.cxx
        
        Line number 168
        Changed from sal_Int32 to Color which was declared on Line 162
        
        Line number 290
        Changed from sal_Int32 to Color which was declared on Line 288
        
        Change-Id: If19b31c54639f1796d5e6375350bec91ec3f79d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148296
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-08  Miklos Vajna  <vmiklos@collabora.com>  [65dd1525e826006f78f86688032459dbd7ab4bb4]

        sw floattable: partially re-enable widow / orphan control in tables
        
        Widow / orphan control in DOCX tables were disabled in commit
        8b13da71aedd094de0d351a4bd5ad43fdb4bddde (tdf#128959 DOCX import: fix
        missing text lines in tables, 2020-01-28).
        
        That workaround helped with the particular bugdoc, but it also disabled
        widow / orphan handling in general, and breaks e.g. orig-nocompat.docx
        from tdf#61594, because the second page's last row is meant to contain 6
        lines with widow control enabled, but the model has widow control
        disabled, so the layout can't work properly.
        
        Fix the problem by improving the layout's WidowsAndOrphans::FindWidows()
        to handle conflicting widow / orphan control requirements in a fixed table
        row height context, so the writerfilter/ change from the above commit
        can be reverted without re-introducing tdf#128959.
        
        An alternative would be to keep the layout unchanged and limit the
        writerfilter/ change to fixed height rows, but that still feels like a
        (more specific) workaround.
        
        Change-Id: I8378d356e116774275dff337d17b19bd79c84c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148456
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-08  Miklos Vajna  <vmiklos@collabora.com>  [269585d6b461b565fe75f77b6dbf219749edc5ab]

        oox, sd: fix ever-increasing chart IDs when exporting to PPTX
        
        Bring the static counter under the control of
        DrawingML::ResetMlCounters(), so the first chart is always chart1.xml,
        even if the same process already exported a chart previously.
        
        XLSX is a separate codepath, this fix doesn't help with that yet.
        
        Change-Id: Idf6e576ba94e254ae9782ef86e85542efd80127f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148457
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-08  Vojtěch Doležal  <dolezvo1@cvut.cz>  [d704f57a3dc87302ba75ae0c2904ad46e734d027]

        Bibliography Marks: Added tests for target-url and use-target-url
        
        Change-Id: Iaebc9224beac1705bc2399358e414f526ad46e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148392
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [5caa11ea3b3ddf98db729ad79f0ce97d13c1414e]

        osl::Mutex->std::mutex in ParameterWrapperContainer
        
        Change-Id: I5beb5981d40e970e8bdc68d7bd61f1adb502246d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a0b41e0556de8eba093e0823f0845652c033960]

        osl::Mutex->std::mutex in SimpleCanvasImpl
        
        Change-Id: I6fc1db00360e87f1bb99fb0e77c3c82a53642d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148439
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Miklos Vajna  <vmiklos@collabora.com>  [d4c991b7ae534d207c583590cce93fd86d1b25e9]

        CppunitTest_sw_htmlexport: avoid XHTML magic in testXHTML
        
        Set the filter option explicitly, rather than inferring it from the test
        name. Also remove the now unused EmbedImages handling in preTest().
        
        Change-Id: I9d6689c116aa2e2969c70460aefbdde0828dd624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148444
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-08  Heiko Tietze  <tietze.heiko@gmail.com>  [8dc8ffff443c3b13e8782fdbaf61594056df8126]

        Relates tdf#153344 - Resize statusbar icons to 16px
        
        Adjustment of StatusSelectionMode size
        Also move the ModifiedStatus on top to comply with Writer
        
        Change-Id: I0d79161651ea841ab4aa496dd5b2edc3fca43ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148427
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7d6f437ad81cc51d78cffb413dd90a7a8dd960d]

        osl::Mutex->std::mutex in ExtensionManager
        
        Change-Id: I33c39076093dc0c23b5e7c85cbdf0a88e6231d2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [838036c304d474fc4c19e2fc59cadc6ba457c9ee]

        osl::Mutex->std::mutex in UpdateRequiredDialog
        
        Change-Id: Ic4161d946190f74d016dd81aca44a7623a4e2dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [474f68e38b88ca6495cb7c5cc4038100c2786063]

        osl::Mutex->std::mutex in SQLEditView
        
        Change-Id: I5110342b54a3674a521d3f9b8452711650b70d0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148438
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [429d53316223809591cb4427b517f0e4266888ed]

        BaseMutex->std::mutex in BibDataManager
        
        Change-Id: Ieb341b37e9643474cfcbed0c0fb0d44e9f079157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-08  Mike Kaganski  <mike.kaganski@collabora.com>  [e385534e1fcbb626e50076d69e91bd31f537527f]

        Fix no-PCH build
        
        Change-Id: Ie3a60558c9a459d2809883590649bee75244a8df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148453
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-08  Michael Weghorn  <m.weghorn@posteo.de>  [65f672b27f84682764f924a3da3cecbafc88b278]

        tdf#153918 svx a11y: Drop old items when switching FontCharMap
        
        Calling `rRenderContext.GetFontCharMap(mxFontCharMap)`
        in `SvxShowCharSet::RecalculateFont` means that a new
        `FontCharMapRef` gets assigned to `mxFontCharMap`.
        
        Therefore, clear the old items based on the previous
        one from the map, so that new ones will be created
        based on the new font char map in `SvxShowCharSet::ImplGetItem`
        as needed instead of still returning the old ones.
        
        Adapt the a11y UI test to check again that the "!" character
        now has the proper accessible name. The incorrect
        accessible name in the special characters dialog had
        actually been uncovered by the initial version of the
        test that failed on Windows due to this, and the test was adapted
        to workaround that, s. tdf#153918 and the discussion in the
        Gerrit change adding the test [1] for more details.
        
        [1] https://gerrit.libreoffice.org/c/core/+/142260/24..26/sw/qa/extras/accessibility/dialogs.cxx#b85
        
        Change-Id: I0ac578750b1fa0a7e63e62a6937a125c7ceab510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148423
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-08  Michael Weghorn  <m.weghorn@posteo.de>  [224286b32587fe9a5db4a7f18b93956a0865d42d]

        svx: Stop manually counting map entries
        
        The `nCount` member counts the number of elements
        in `m_aItemList`, but `std::unordered_map::size()`
        also returns that, so just use that instead.
        
        Use `SvxSearchCharSet::getMaxCharCount` in most places
        and simplify to use `std::min` in `SvxSearchCharSet::LastInView`.
        
        Change-Id: I8b66b1d83c0327026b13147f201995c7d1df1238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148422
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-08  Julien Nabet  <serval2412@yahoo.fr>  [c0ed486d96fca70704a7f7e24199de9c663003cc]

        tdf#153538: blacklist GeForce GTX 1070 Ti for Skia hardware rendering
        
        Change-Id: I4ec53d9bcde229f3df3f19e952536ba64e1dc3d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148447
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d062f097cc48bd53247b7fb0c677d90fcc430ab7]

        Simplify usage of BinaryDataContainer
        
        It is always used to store data read from streams
        
        Change-Id: I613bc446eaadf98d2b1c012002d38f23d79a40ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148450
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a179f6c91692076e7e17babf4890638caa398384]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 82b298d6f35e25961a026d848238d29d6b373709
          - tdf#154034  remove xml-lang and use lc_ for icon
            
            Change-Id: I368077b40ed9924ed715a43072d064385b7ae5c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148408
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1bede0887faa1eec94cff66cf0daa0eed66750ab]

        tdf#153560 "up to level" also selects field contents
        
            revise tooltip and extended tip for "level" spinbox to
            indicate that the "level" setting applies both to
            numbers and contents
        
        Change-Id: Ib54e4d6db59de346ed678f1fa7a5174f8e7d84ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148407
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-07  Galdam  <qmebic1975@gmail.com>  [729ae5135042427b62a856d792f51afad1026622]

        Update Sifr Mimetype Icons
        
        Updated Sifr mimetype icons to match new app/mimetype icons
        
        Change-Id: I4dda9bd4f342ed068bf1a10f9ffb23246685cc94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148429
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [22069151cdf12729ef675f2f5a8d7a069e1c5378]

        tdf#104315: sw_uiwriter3: Add unittest
        
        Change-Id: Id789db24b570242928a650f6e9dedd5691f0625c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148420
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [d899cc680b7a0a21d863a1e1746262bf958de882]

        tdf#114773: sw_uiwriter3: Add unittest
        
        Change-Id: Idb5edf4c3d7179eca0d1e66801aedd07712c2da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148419
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-07  Caolán McNamara  <caolanm@redhat.com>  [cc6fe41b051722ab73a44c7aa00b9101ae0284ca]

        tdf#154042 Use an initial height of one row for toolbar layout
        
        so the Toolbar positions this in the same place regardless of how many
        rows it eventually shows
        
        Change-Id: I7ec31e50557a099962fb051a1948781ef9abdfb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [1dd68c0eab53c5747dac89ef21723be6831b0ada]

        tdf#153423: sw_uiwriter6: Add unittest
        
        Change-Id: I585d5ea5ac4d704ef1b303a1bf304c29023c2fba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148416
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-07  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7adfecb0f5947ae258226c8d1652546f81577026]

        lok: form controls: rendering and mouse event forwarding
        
        What we got
        - Most controls rendered on Writer and Impress (on Calc already
        implemented by Tomaž Vajngerl)
        - Text labels rendered correctly
        - Mouse events forwarded to controls
        - Control state changed on click for Writer and Calc
        - Control invalidation for all apps
        - Fixed broken LOK_CALLBACK_MOUSE_POINTER msg
        - Correct pointer style when mouse is hovering over a control
        
        Need to be improved
        - in impress click method for a control is not executed even if the
        mouse event is forwarded correctly
        - avoid not needed control invalidations (as the one occurring on
        document autosaving)
        
        Change-Id: I4d5012af7f90a2c726b6b6b5b068e2be1ed5568a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146569
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147320
        Tested-by: Jenkins
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [c596fd59dc75823002bdfd3676d600a56e3bfb5e]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I86611e14a32dda3ae2226bbfa775ad0234513888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148425
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Stephan Bergmann  <sbergman@redhat.com>  [e096fbc3e06d2c2b55ef8706c954efb6555ca0e6]

        Depend on ExternalPackage_fontconfig, not just ExternalProject_fontconfig
        
        ...so that e.g. a from-scratch `make CppunitTest_sw_core_layout` doesn't fail
        with
        
        > warn:sal.osl:3973661:3973661:sal/osl/unx/module.cxx:103: dlopen(workdir/LinkTarget/Library/libvclbootstrapprotector.so, 257): libfontconfig-lo.so.1.12.0: cannot open shared object file: No such file or directory
        > Failure instantiating protector "workdir/LinkTarget/Library/libvclbootstrapprotector.so", "vclbootstrapprotector"
        
        (This is LINUX-only, as ExternalPackage_fontconfig has been introduced as
        LINUX-only by d552b4a549d614a03aa9328e017dec27bd3ff41e "Enable opening of
        downloaded fonts only in ForKit in Online":  "All this is relevant for Linux
        only, as Collabora Online runs on Linux.")
        
        Change-Id: I8976726ee8080f91a0fa97d60b8f345c48cae686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148381
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-07  Supriyo Paul  <paulsupriyo64nk@gmail.com>  [e9697e315cd382ce14b5c8efc47a07aa06dea30c]

        tdf#94079 sc_ucalc: Add unit test
        
        Change-Id: I2254d924acd05d2322068b7b8df229328dcf21f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148385
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [d5574dad104e9e39c647c41dd4ddcc1f665d31f4]

        improve variable name
        
        until
           commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Aug 15 17:35:58 2021 +0200
            pass OutlinerParaObject around by value
        it served two purposes, now it serves only one, so rename it
        to reflect that.
        
        Change-Id: Ifc4f9361fd562cc6c572cdc3ad90151d87f41501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Miklos Vajna  <vmiklos@collabora.com>  [364a8e7462948b83f3ad7aec64f86fa4386889c1]

        sw: fix crash in GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid()
        
        Crashreport signature:
        
        program/libswlo.so
              SwFlowFrame::GetUpperSpaceAmountConsideredForPrevFrameAndPageGrid() const
                      sw/source/core/layout/flowfrm.cxx:1741
        program/libswlo.so
              objectpositioning::SwAnchoredObjectPosition::GetTopForObjPos(SwFrame const&, SwRectFnCollection* const&, bool) const
                      include/svl/itemset.hxx:101
        program/libswlo.so
              objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition()
                      sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx:1020
        program/libswlo.so
              SwAnchoredDrawObject::MakeObjPosAnchoredAtPara()
                      sw/source/core/layout/anchoreddrawobject.cxx:424
        
        Change-Id: If162602f6a1cc2108c0de385652e93e23be920be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148391
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-07  Caolán McNamara  <caolanm@redhat.com>  [4b16ed30c345bbce7f579acf556db29a4d95b80a]

        tdf#152278 a YoavKtav Black font reported as claiming its name is in 0x4800 encoding
        
        Change-Id: Ie1f190cd4e550a21b5614d565b03422332594ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148417
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [48fad5ddb1d65568ba1cb6539a19821fd1fbc6d1]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I56f00947c92c7b092dee534a6eecf6caedbafa2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Caolán McNamara  <caolanm@redhat.com>  [6231b4b2a8bcfdcb80c5b4555f6a9d2c9946b9c6]

        tdf#153699 workaround cairo 1.17.8 problem
        
        Change-Id: I5290dd93d06a6812acf97fe0eeec581a233a898c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-07  Michael Weghorn  <m.weghorn@posteo.de>  [38e2dde00da0207c5f7157bb427a006d32dfeb5b]

        tdf#154039 wina11y: Increase refcount for returned COM interface
        
        The reference counter for the IUnknown interface
        of the COM object needs to be increased in
        `CMAccessible::get_accSelection` as well,
        not just in the called `CEnumVariant::Next`,
        because calling VariantClear` on the temporary
        variant afterwards decreases the ref count again.
        
        Regression from
        
            commit 00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jan 31 07:41:14 2022 +0000
        
                tdf#147083 wina11y: Return a11y object instead of child ID
        
        Change-Id: Id968c3d80b38961b836fbb1a9bd6dfeefdff813f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148393
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-07  Tor Lillqvist  <tml@collabora.com>  [1f4e9eacc36413bba92f119ebed931cfdb975e80]

        Drop the LibreOfficeKit paintThumbnail() API
        
        It turns out that Mert's original idea is actually the simplest and it
        is known to work. And in that, the separate paintThumbnail() is rather
        pointless, as all paintThumbnail() did was to call paintTile(). The
        caller (in Collabora Online) knows when a file is opened specifically
        for thumbnailing, and can call paintTile() itself with the appropriate
        parameters.
        
        My misguided idea would have had paintThumbnail() somehow figure out
        the physical Twip coordinates of the current location (for text
        documents, the insertion caret location) in the document. (Or, as
        LibreOfficeKit for some reason calls them, "logical" coordinates, even
        if a Twip is a very physical length unit.) Then it would have called
        paintTile() with those coordinates. But it turned out to be rather
        hard to figure out the Twip coordinates of the current location in
        the document.
        
        Mert's idea was that when a document is opened for thumbnailing, only
        Online actually needs to know that. From LibreOfficeKit's and core's
        point of view it is a normal document load operation. Then Online
        performs the .uno:OpenHyperlink magic, which makes core move the
        current position to the requested "target" or "mark" (the terminology
        varies) location. And then a "cursor" callback is used by Online to
        get the Twip coordinates of the target. It is a bit unclear to me
        whether .uno:HyperLink causes the document to be opened an extra time,
        but whatever, this way is said to work. So let's do it like that.
        
        This reverts the paintThumbnail part of
        1aa37ca99112c0760552600d7774ba7224581c5b.
        
        Change-Id: I8f3d9917ee362c1518834fc10a57c57ebc4a6edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148390
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [311edc37b202f5463a86eddc1f9b476dbe5b47fa]

        tdf#154034  correction to tooltips  "outline" -> "index"
        
        Change-Id: Ic8024be1615103c2b367ff0b90cae42e38c4654f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148328
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-07  Heiko Tietze  <tietze.heiko@gmail.com>  [e85aa0f9c9ab58b81b333fabbed1604a36b68747]

        Resolves tdf#153344 - Resize Save icon in statusbar to 16px
        
        16px instead 18px to comply with the other icons
        
        Change-Id: Ic7e3531c30f1af75b38416a94acc2e7ea16c3ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148350
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [7fe6677dfae8f89da53351fd86adffe6c7d59dc9]

        Improve flow of logic in SwAnnotationWin::ToggleHdl
        
        and rename the IsProtected method to more accurately reflect
        what it returns.
        Certainly the initial flow of logic in this method was very
        confusing.
        
        Change-Id: I4a01c00160a896961fcce97831605d3a6e15cd1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [40661d3fcec5f50abcd79975e565cd61cba67f0c]

        clang-tidy dead-store
        
        Change-Id: Iad8dd9081966193090b0929169da199b47f949a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Heiko Tietze  <tietze.heiko@gmail.com>  [dc025586351206f5369eeed1d9203e659d87ed04]

        Typo in comment
        
        Change-Id: Iadf080cfae051116add064f8ac3e7d13079effb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148351
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [db0175bf3a4da8aec0e3607731b464c1ce91ee1d]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I44d60e9fca03ce6709551a660661dd2a6778fd7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Tor Lillqvist  <tml@collabora.com>  [f3a0ed5d63823a1a111de7330d4ddbaf4e0b6d41]

        Fix Doxygen comment thinko: dumpState() is in lok::Office, not in lok::Document
        
        Change-Id: I87626370fdd8cbe906ed31d1b8c92234696e9708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148414
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [176d9c13271b26cd6df7fcc4f387ded9161baf97]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: Ibfa1bc474a2dfc9bf117f8963b52ffbd74b91dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed6c132cfd3166045adca544939f8ad32979745d]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: Iebbe17f114b098337305d4f8f5c3835be4744c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Szymon Kłos  <szymon.klos@collabora.com>  [09976bda9c196b2426b8826941f21384a58bf536]

        jsdialog: don't close dialog on tab page destroy
        
        was closing the whole dialog on tab switch in
        Format -> Characters -> Highlight when switching to
        "None"
        
        also avoid sending multiple "full updates" by using the same
        builder for sending message
        
        Change-Id: I4540c9c857acf2b9f40482678a30335edc24e7cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148314
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [928fdf82a5a0e6bc70aac11b5a03690dcaf0c8c0]

        tdf#153243 amend labels for Heading Numbering; polish tooltips/extended tips
        
            also, change "chapter" -> "heading" in tooltip for
            Separator in AutoCaption, and add tooltip for
            Separator in Caption Options
        
        Change-Id: I45bdc5381d6a5459ba64565b3064a7642bdbc0cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147594
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-07  Pranam Lashkari  <lpranam@collabora.com>  [0ba5a856fc8c24d9612bd9a78e9a4f11365571e7]

        jsdialog: enabled format Character dialog (calc)
        
        can be found from:
        Tabbed view > Format > Character
        Compact view > Format > Character
        
        Change-Id: I80c15237a29ef19303c71101965df9a18791cb4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148243
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-07  Jaume Pujantell  <jaume.pujantell@collabora.com>  [574e89ccda1b389faca9f3e44d909a71b5599473]

        Fix a bug parsing pdf arrays
        
        The parser ignored number elements in some situations, like before
        a reference element. This manifested in creating an invalid pdf
        file when exporting as pdf a document that contains a pdf.
        
        Change-Id: I98625c8da8631056079814f7e824f36177cf41c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148198
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-03-07  Michael Meeks  <michael.meeks@collabora.com>  [5a41b0a42acac80d7c601f0899c82b9f390bff3d]

        Avoid running graphics tests when in lok mode.
        
        Best to avoid allocating and freeing 64Mb of RAM, and
        burning lots of CPU doing CPU rendering on an invisible
        for each document loaded through lok API.
        
        Change-Id: I656b400159b9d6a7a9f2c79d188e3aec9b3dd0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148258
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2023-03-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [925c7ca82711e65e457f96bc167f04d49cc974a5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f205cf12787f7a601a75a8acd4ddd13b064f686e
          - tdf#154034  add icons and update procedure
            
                refactor to <h1>,<h2>
            
            Change-Id: I89df34df481a5438bcc90e12534790f2ef78f3ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148329
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a31f61e233a08025c0acaeabd02c12981258c83d]

        Drop VectorGraphicDataArray
        
        Change-Id: If444317edf35d0627c6bc3a8c36ba973a8a0af8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148371
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2023-03-07  Heiko Tietze  <tietze.heiko@gmail.com>  [d9ba2fbdc81705d387f932700289b2dda8ea81dc]

        Resolves tdf#153933 - Minor adjustments to EntryMessageType
        
        Red adjusted to follow the standard palette and yellow to
        have the same saturation
        
        Change-Id: Ic40a37c77862471066a8575d4b22cc18dc6edac4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148348
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-07  Miklos Vajna  <vmiklos@collabora.com>  [5d5dca66e17c90e20197d0d76113254b13ff0bb7]

        sw floattable: grow the print area as well in SwFlyFrame::Grow_()
        
        The bugdoc should be of 3 pages, but the last for of the floating table
        went to the 3rd page.
        
        The reason for this was that SwTabFrame::MakeAll() calculated
        nDistanceToUpperPrtBottom, then determined that the upper has to grow,
        and called GetUpper()->Grow(LONG_MAX, /*bTest=*/true).
        
        Now this growth was less than what would be possible, because a previous
        invocation of SwFlyFrame::Grow_() increased the frame area (with
        margins) but not the print area (with margins). This meant that the
        frame can't grow too much because its frame height is already 7044 twips
        but its print height is only 548. This combination of "not enough inner
        space" and "can't grow too much, either" resulted in moving the last row
        to an unwanted 3rd page.
        
        Fix the problem by not only increasing the frame height but also the
        print height in SwFlyFrame::Grow_(), this keeps the last row on the 2nd
        page, like Word does.
        
        Change-Id: I7850b54b030c42034e0a117d52d2148fa6ba2f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148373
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-07  Andras Timar  <andras.timar@collabora.com>  [503b14eee1f05e987fb415d25da1086defe8c772]

        Remove mention of apr and apr-util from NOTICE cause we don't use them...
        
            since
        
        commit f45b7871e7d31dfc6ed31d1b79928990bba0d0dd
        Author: Michael Stahl <michael.stahl@allotropia.de>
        Date:   Tue Dec 14 16:03:46 2021 +0100
        
            ucb: remove --with-webdav=serf
        
            Remove code in ucb/source/ucp/webdav, and now unused externals
            apr, apr-util, serf.
        
        Change-Id: Idfb1f921c0d048f18f23263c04ac718ca1c95ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147886
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-03-07  Miklos Vajna  <vmiklos@collabora.com>  [aa55c773ee1f8e756de6959781a293bcfc243952]

        sw: document SwFrame::MakePos()
        
        I.e. the simplest SwLayoutFrame::MakeAll() mostly just calls MakePos()
        and Format().
        
        Change-Id: I13d37c2bddfdd57503c1de974e34acd004e57195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148360
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-07  Vojtěch Doležal  <dolezvo1@cvut.cz>  [7b99871635cd48c2a8a1d0afbd7afc60a45cc2ff]

        tdf#153396 - Bibliography marks improvements
        
        Adds option to separate function of "URL" into (listed) "URL" and "Target URL" to allow for more flexibility (in that case if target URL is empty, bibliography mark hyperlink leads to bibliography table row if possible)
        When writing tests also found and fixed bug where exporting new file with anchor link bibliography mark crashes LO.
        
        Change-Id: Ic1b5c8c9590c0338dcfc4fa3a981142bddae0113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147868
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-07  Caolán McNamara  <caolanm@redhat.com>  [cc45d748e241ea96fd0c81154e3dd49f9fc58357]

        eFormat modified inside GetDateArea, but change not propogated to the caller
        
        regression from:
        
        commit 6e7e19d9c300dbdd279789b09f94781e946fad52
        Date:   Wed Jul 15 12:10:32 2020 +0100
        
            weld DateControl
        
        Change-Id: I74bc01383f04fd4e54a45058fbbc3bc082eef0e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148359
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [25c19f896b327cac4fa4ed248fcc0410a9fe55ab]

        remove dead code in X11SalFrame::SetIcon
        
        ever since
            commit a11cabb47249257d8b6510fe91063ade03d0c636
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Wed Jan 11 12:22:17 2023 +0000
            rely on support for NET_WM_ICON
        
        found by clang-tidy dead-code
        
        Change-Id: I4b762361a7937d087dab8c5cb0f57131ce3650d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148346
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [0b92356a6c1844aef9ed49927fa4da310ee5bb2e]

        clang-tidy dead-store
        
        Change-Id: Id7c48e995b4f92f081fbd4d1af257e1b81e6a421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148347
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [20ab6da2ce6ed5728683b6cfc1dbe11a2f676ae0]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I701be7fd8bd4402af9c7b1473c9f4b3c8a9c0e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f4ccccc6b2256450b49ba9c8871fb5fc967b199]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I9a0f971d72c998c26e567c6abc2f9fe2a734207e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [01a8b743f69b6718ccf5bbbda23734fa38020e19]

        clang-tidy dead-store
        
        Change-Id: I40574713beaf1799cbc177a679e3485b4dc4eb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148349
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-07  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0397906df28669e6a9db58b852c357b8caacb182]

        tdf#153465 Sukapura Dark: Fix Impress Presenter Console & Floating Insertion
        
        Change-Id: Ia284cdf9a01f754f23ff23b6c1bdedd0e1316282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148288
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-06  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0484a9a3f5e2ecb678f6fb41bbb251529e89c00d]

        tdf#150045 Spotted another secondary label
        
        Change-Id: Ic39bb5c61f01d340a1ce59ad320d94efdb341f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148369
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-06  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0a45150c3da431bf0764b82fb109596880f4dbcb]

        The word “fake” is ambiguous
        
        Change-Id: I051c42904ff20d9d12f8821fcb7eedb3642276ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148366
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-06  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [f48d238ce8d5e22642324c456c83b424b3dcb446]

        The quotation marks aren’t needed here
        
        Change-Id: Id89b5e161d1d02da66138b16bc8ea34417c554c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148365
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [55360ba58f33f3f45c83decce092c43d25c4e48c]

        tdf#151605: sw_uiwriter7: Add unittest
        
        Change-Id: I629a531d5ee34a0ab3ef888254bf987df716d4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148357
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-06  Caolán McNamara  <caolanm@redhat.com>  [593037e37d0db08138c5ef32041007b65052a55f]

        ofz#56734 Abrt
        
        Change-Id: I0426c0d3a56789b2f2d24fc87ed9e88653700ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148358
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3b995c0a73215b974437f63c1081daebf7ecec48]

        tdf#153243 update dialog for Insert/Edit number range type field
        
              - "Numbering by Chapter" -> "With Heading Number Before"
              - change "Level" to "Outline level"
              - revise tooltip and extended tip for "Outline Level"
              - add tooltip and revise extended tip for "Separator"
        
        Change-Id: Ifda841fc8cd05660a4a2aed1e2c7037224f858ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147637
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8655fe6b9e19411f109c0dd75bfae0c734380e31]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: If233dfb315c4acc63849f92e5340d5e6561b5b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb92647934cd4c925e0db13c7ab78fdd8eec69ec]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: Idc76cb87d1dae7ef245f327dc4afebaf71190f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f101a514827d0bc57c6626eeed99ecf26658aa9]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I09a0392f8d0b067a3a8e4105568b578ef4795c58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Michael Weghorn  <m.weghorn@posteo.de>  [02266202e5e5a97d3c97a3d502c59db884a99901]

        qt a11y: Handle all QAccessible::Relation flags
        
        The bits/flags in `QAccessible::Relation` can be set in
        any combination, while the previous code would only properly
        handle the case that `QAccessible::AllRelations` is set.
        
        This would e.g. mean that
        
            QtAccessibleWidget::relations(QAccessible::FlowsTo | QAccessible::FlowsFrom)
        
        would not return both relations as it should.
        
        The previous handling of the case that just a single flag is set
        also looks odd, since it would use the sal_Int16 value of the
        UNO relation as an index into the set of relations...
        
        Fix this by always iterating over all relations and
        applying the filter in `lcl_appendRelation` (only
        append those that match the filter).
        
        (At least for AT-SPI, the previous handling should not have
        caused any issues in practice, since Qt's AT-SPI bridge always
        passes `QAccessible::AllRelations` from what I can see.)
        
        Change-Id: Icc21ac252db026f607fe8d6041252916b1d9e3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148352
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-06  Eike Rathke  <erack@redhat.com>  [79aed20c3d48b2be5cdee5de42559649db0eb5fa]

        For LARGE() the rank is to be rounded up, not down
        
        See
        https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#LARGE
        vs
        https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#SMALL
        
        Change-Id: Ib2c9aa11c41da5ce7f9872a949017035a7b70758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148289
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-03-06  László Németh  <nemeth@numbertext.org>  [317ed3e81a5aa7826176a5122c2d8ea76aa0fb37]

        tdf#153819 sw: fix crashing MakeFramesForAdjacentContentNode()
        
        In Hide Changes mode, copying cells before a tracked deleted
        table crashed in SwTableNode::MakeFramesForAdjacentContentNode().
        
        Regression from commit 794fd10af7361d5a64a0f8bfbe5c8b5f308617a5
        "tdf#147347 sw: hide deleted table at deletion in Hide Changes".
        
        Change-Id: I3ac070d35006e61b01a065359431e302e6974e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148344
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-06  Caolán McNamara  <caolanm@redhat.com>  [4a88c5840e022ca896ce26ce1dfde2db7fb7df29]

        tdf#148776 for scrolling set step size as height of a row
        
        similar to FontFeaturesDialog.
        
        FWIW gtk's viewport implementation automatically overwrites the step
        size to be 10% of the visible height (and page size of 90% of the
        visible height)
        
        Change-Id: If356724a47b0a10069f129bed4a40cfdee57bfa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148138
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-06  Caolán McNamara  <caolanm@redhat.com>  [f60a48af7df68c8704154297eca5b7159f839ffc]

        these can be const
        
        Change-Id: I8601beb007f1e0b043e2217e5dfe8b40925335ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [363512d39ba1543b7e91af1d59dadb5378da7649]

        clang-tidy dead-store
        
        Change-Id: I842114880c43dfcc342b6255b7d17befb905bccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0f69aa125081c31ca2b79e9e29e13bc91a21be7]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: I9bbe80a1be4d138f00d864352896d61d0df6366d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c2542306bcc7caaab947664f252265058964fc2]

        no need to allocate these separately
        
        they are all one or two words in size
        
        Change-Id: Iec508d917d05b3ca762723bdc99be8c68b974aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [d951f9cafbc4674e4bf6fc174f5fd28e451c59ae]

        tdf#153924: sc_subsequent_filters_test4: Add unittest
        
        Change-Id: I32e07ab36b2ee3873cf6fc6d9831be9b772a29e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148300
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [a78d1b359966a2ab829fe13eaac7821894a96d91]

        CppunitTest_sd_tiledrendering: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Icd7b2bfc98a5d27146ff8025d03e4c33a0c3abfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148306
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-06  Stephan Bergmann  <sbergman@redhat.com>  [7e2d269bad64694c33cb3bc693c7df9917a4fac0]

        external/fontconfig: Silence UBSan nullptr-with-offset
        
        ...during CppunitTest_cppcanvas_test,
        
        > fcserialize.c:166:54: runtime error: applying zero offset to null pointer
        >  #0 in FcSerializeResize at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:166:54
        >  #1 in FcSerializeSet at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:204:7
        >  #2 in FcSerializeAlloc at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:228:10
        >  #3 in FcStrSerializeAlloc at workdir/UnpackedTarball/fontconfig/src/fcserialize.c:274:12
        >  #4 in FcDirCacheBuild at workdir/UnpackedTarball/fontconfig/src/fccache.c:1255:10
        >  #5 in FcDirCacheScan at workdir/UnpackedTarball/fontconfig/src/fcdir.c:360:13
        >  #6 in FcDirCacheRead at workdir/UnpackedTarball/fontconfig/src/fcdir.c:462:10
        >  #7 in FcConfigAddDirList at workdir/UnpackedTarball/fontconfig/src/fccfg.c:516:10
        >  #8 in FcConfigAppFontAddDir at workdir/UnpackedTarball/fontconfig/src/fccfg.c:2891:10
        >  #9 in psp::PrintFontManager::addFontconfigDir(rtl::OString const&) at vcl/unx/generic/fontmanager/fontconfig.cxx:745:20
        >  #10 in psp::PrintFontManager::initialize() at vcl/unx/generic/fontmanager/fontmanager.cxx:683:17
        >  #11 in GenericUnixSalData::InitPrintFontManager() at vcl/unx/generic/app/gendata.cxx:65:26
        >  #12 in GenericUnixSalData::GetPrintFontManager() at vcl/inc/unx/gendata.hxx:100:13
        >  #13 in psp::PrintFontManager::get() at vcl/unx/generic/fontmanager/fontmanager.cxx:105:23
        >  #14 in GenPspGraphics::GetDevFontListHelper(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/print/genpspgraphics.cxx:248:35
        >  #15 in FreeTypeTextRenderImpl::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/gdi/freetypetextrender.cxx:110:5
        >  #16 in SvpSalGraphics::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/headless/svptext.cxx:51:23
        >  #17 in OutputDevice::ImplInitFontList() const at vcl/source/outdev/font.cxx:643:17
        >  #18 in OutputDevice::ImplNewFont() const at vcl/source/outdev/font.cxx:700:5
        >  #19 in OutputDevice::InitFont() const at vcl/source/outdev/font.cxx:660:10
        >  #20 in OutputDevice::GetTextHeight() const at vcl/source/outdev/text.cxx:899:10
        >  #21 in vcl::Window::GetTextHeight() const at vcl/source/window/window3.cxx:65:65
        >  #22 in vcl::Window::ImplInitAppFontData(vcl::Window const*) at vcl/source/window/window.cxx:1188:40
        >  #23 in vcl::Window::ImplInit(vcl::Window*, long, SystemParentData*) at vcl/source/window/window.cxx:1182:9
        >  #24 in ImplBorderWindow::ImplInit(vcl::Window*, long, BorderWindowStyle, SystemParentData*) at vcl/source/window/brdwin.cxx:1557:13
        >  #25 in ImplBorderWindow::ImplBorderWindow(vcl::Window*, SystemParentData*, long, BorderWindowStyle) at vcl/source/window/brdwin.cxx:1586:5
        >  #26 in VclPtrInstance<ImplBorderWindow>::VclPtrInstance<vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&>(vcl::Window*&, SystemParentData*&, long&, BorderWindowStyle&) at include/vcl/vclptr.hxx:280:39
        >  #27 in WorkWindow::ImplInit(vcl::Window*, long, SystemParentData*) at vcl/source/window/wrkwin.cxx:51:38
        >  #28 in WorkWindow::WorkWindow(vcl::Window*, long) at vcl/source/window/wrkwin.cxx:95:5
        >  #29 in ScopedVclPtrInstance<WorkWindow>::ScopedVclPtrInstance<std::nullptr_t, long const&>(std::nullptr_t&&, long const&) at include/vcl/vclptr.hxx:412:45
        >  #30 in CanvasTest::testComposite() at cppcanvas/qa/unit/test.cxx:38:38
        
        Change-Id: I90c86931ae5d4dfb32a1a95a5eb660484b54f09a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148287
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5d4749b5c29cdbfb9ea87db3402d9ada8df7c1c1]

        Remove trailing blanks
        
        Change-Id: Iaf04b6bd650801c05f83e664d71f26a3d306873e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148302
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [27d4e27a6ab317cbc7eb1fb5d73cebdc36ffbb34]

        CppunitTest_sc_tiledrendering: remove commented out code
        
        This was added with 235136c17868627412db8dda148d3c4103907c0c
        "sc lok: Don't interact with the user during .uno:SortAscending or
        Descending."
        and never needed since then
        
        Change-Id: I7c6822d1f187632f608821cbcd208624deca103a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148305
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-06  Supriyo Paul  <paulsupriyo64nk@gmail.com>  [9ba89c54076990b21b8e052fdd8d43bf8688edbe]

        tdf#148251 Use std::swap instead of using temporary values
        
        Part of the code uses a temporary variable for swapping variables.
        This is hard to read, so we are now using std::swap which improves
        readability. We also remove the temporary local variable.
        
        Change-Id: If6e97f7d464aa21cf4b9c64e630769949cfaa6af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148197
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-03-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [de236de7fded4b6d1eb5f4623d411e674125ebb9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f339f367d1ee6aa8d13b41eaf3ca19bca9926e6
          - tdf#141474 Incorrect parameter names for Basic functions in help
            
            Remaining pages up to included Join function
            
            Change-Id: Id6aad2fbdf3ace72fdaa33136fc71a6107abeadd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147986
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-06  Michael Weghorn  <m.weghorn@posteo.de>  [46a03cb528860c7571c2ff046bef307bb7b04ac2]

        qt a11y: Add mapping for relations added in Qt 6.6
        
        Map `AccessibleRelationType::CONTENT_FLOWS_FROM`,
        `AccessibleRelationType::CONTENT_FLOWS_TO` and
        `AccessibleRelationType::DESCRIBED_BY` to the
        Qt equivalents added in Qt 6.6 and vice versa.
        
        As described in more detail in
        
            commit e55713dffbe8d8eba18068f6c2af14c10b787220
            Date:   Fri Feb 17 15:25:37 2023 +0100
        
                qt a11y: Invert relation type to match Qt's semantic
        
        , the "inverse" relation needs to be used when
        mapping to/from the Qt relation.
        
        For example the Orca screen reader on Linux makes
        use of the FlOWS_FROM and FLOWS_TO relations.
        So far, when using the qt6 VCL plugin with Orca
        running, moving focus to a Writer paragraph resulted
        in these warnings being emitted:
        
            warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 1
            warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 2
        
        and thus Orca not being able to make use of those relations.
        
        Sample use in Accerciser's Python console, with a Writer document
        having three paragraphs with texts "First", "second", and "third"
        and the a11y object of the second paragraph's a11y object selected
        in Accerciser's a11y tree view:
        
            In [1]: acc.queryText().getStringAtOffset(0, pyatspi.TEXT_GRANULARITY_PARAGRAPH)
            Out[1]: ('second', 0, 6)
            In [2]: acc.get_relation_set()
            Out[2]:
            [<Atspi.Relation object at 0x7fccc36862c0 (AtspiRelation at 0x421e100)>,
             <Atspi.Relation object at 0x7fccc358c280 (AtspiRelation at 0x4493c60)>]
            In [3]: first_relation = acc.get_relation_set()[0]
            In [4]: first_relation.get_n_targets()
            Out[4]: 1
            In [5]: first_relation.get_relation_type()
            Out[5]: <enum ATSPI_RELATION_FLOWS_FROM of type Atspi.RelationType>
            In [6]: first_relation.get_target(0)
            Out[6]: <Atspi.Accessible object at 0x7fccc35aa4c0 (AtspiAccessible at 0x4479820)>
            In [7]: first_relation.get_target(0).queryText().getStringAtOffset(0, 1)
            Out[7]: ('First', 0, 5)
            In [8]: second_relation = acc.get_relation_set()[1]
            In [9]: second_relation.get_n_targets()
            Out[9]: 1
            In [10]: second_relation.get_relation_type()
            Out[10]: <enum ATSPI_RELATION_FLOWS_TO of type Atspi.RelationType>
            In [11]: second_relation.get_target(0).queryText().getStringAtOffset(0,1)
            Out[11]: ('third', 0, 5)
        
        (QTBUG-105864 [1] also has a sample doc and pyatspi script that can be used
        for testing.)
        
        Qt commit adding the relations [2]:
        
            commit f5358e5932bc8701621389c265c4ea86c92c536c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Feb 17 13:48:38 2023 +0100
        
                a11y: Add new relations DescriptionFor, Described, Flows{From,To}
        
                This is equivalent to the corresponding relation types defined
                in the IAccessible2 spec [1] (IA2_RELATION_DESCRIPTION_FOR,
                IA2_RELATION_DESCRIBED_BY, IA2_RELATION_FLOWS_FROM,
                IA2_RELATION_FLOWS_TO) and for AT-SPI on Linux [2]
                (relation types ATSPI_RELATION_DESCRIPTION_FOR,
                ATSPI_RELATION_DESCRIBED_BY, ATSPI_RELATION_FLOWS_FROM,
                ATSPI_RELATION_FLOWS_TO).
        
                User Interface Automation (UIA) on Windows also has corresponding
                properties for 3 of them [3]: UIA_DescribedByPropertyId,
                UIA_FlowsFromPropertyId, UIA_FlowsToPropertyId.
        
                This commit adds the new flags and implements the mapping for
                the AT-SPI case.
                Note that the relation type is conceptually always "inverted"
                when comparing Qt and AT-SPI (or Qt and UIA)
                as clarified in afbfe30093d49eff0ec4c28c220d33c233b9f807.
        
                "QAccessible::Description" instead of "QAccessible::DescriptionFor"
                would align better with the naming scheme of the other relations, but
                that is already used in the Text enum.
        
                [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/group__grp_relations.html
                [2] https://lazka.github.io/pgi-docs/Atspi-2.0/enums.html#Atspi.RelationType
                [3] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids
        
                [ChangeLog][QtGui][QAccessible::RelationFlag] Added new relation
                flags DescriptionFor, Described, FlowsFrom and FlowsTo.
        
                Fixes: QTBUG-105864
                Change-Id: If2d46099eeea75e177358c821d1ae833a553bd0e
                Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
        
        [1] https://bugreports.qt.io/browse/QTBUG-105864
        [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=f5358e5932bc8701621389c265c4ea86c92c536c
        
        Change-Id: I6e5d78fb26f62a6f1745d4f94647e8dc0fe2abfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138687
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-06  Miklos Vajna  <vmiklos@collabora.com>  [078f5064dd09e5228f1a54b4f45ae90fc06bd99f]

        writerfilter: prefix members of OOXMLStarMathValue
        
        See tdf#94879 for motivation. With this, writerfilter/ is done, I think.
        
        Change-Id: Ia2ae5394e41688049b0a639aa5ad922980928cf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148293
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3a1f86eb7cc5b3eaaec74501f472dfd0358b463c]

        sw/qa/extras/README: update test suite name
        
        Change-Id: If4e944bd325b0c271f91792bf24a854669d3ffd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148309
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-06  Miklos Vajna  <vmiklos@collabora.com>  [aac624d1e3cd6fc023e25fedbfe48ed330a308ec]

        sw floattable: clean up not needed scope in SwTextFormatter::FormatLine()
        
        Leftover from commit 25a16e7543965565a4227506003adc916deea500 (sw
        floattable: fix cid#1520804, 2023-02-09).
        
        Change-Id: Iecf4d8708c6acc3a49a0a987370911f32e6ac3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148295
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-06  Pranam Lashkari  <lpranam@collabora.com>  [f3aca61de33b396bad10d08ddbb6f83e1a29ac13]

        jsdialog: enabled format Character dialog (writer)
        
        can be found from:
        Tabbed view > Format > Character
        Sidebar > Character
        Compact view > Format > Character
        
        Change-Id: I43f9dc63a1941345a7ef55bfecd8bb38f652208e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148242
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-06  Szymon Kłos  <szymon.klos@collabora.com>  [26486cd12f47090fbd505b4b51828ee9e79bf3b7]

        jsdialog: send full update when showing BuilderPage
        
        BuilderPage when created welds only container.
        Detect that case when full update wasn't sent
        in weld_dialog or weld_assistant so we show new
        tab pages.
        
        Fixes problem in Characters -> Higlight -> Color
        
        Change-Id: Iab38493a12feb4fc5e8b258125987856485275a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148221
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-06  László Németh  <nemeth@numbertext.org>  [13e34393e4564ef67d990c6dbe1991a0a6b288dd]

        tdf#154000 tdf#70423 sw: fix crash/freezing with huge text files
        
        It was not possible to load or edit text files with very long
        lines any more, because removed wrapping of the lines resulted
        freezing and crash.
        
        This reverts commit 745898eb2af2686ffbdfdc0e44984db67b172a59
        "tdf#70423 Remove txtimport break in 10k chars line",
        keeping only its unit test.
        
        Fix also tdf#70423 by increasing the wrap limit from 10000
        to 250000 characters, which still permit to load e.g. 50 MB
        character or longer text lines, and to edit 5 MB or longer
        text lines without crash or freezing.
        
        Details: trying to load a relatively short 76 MB character
        length text line shows a non-linear slowing down during the
        load, resulting program crash after freezing 10 minutes.
        
        Now this file is opened within seconds again, allowing to modify,
        select and copy of the text before the full load of the document
        (with linear speed). Loading a much shorter 5 MB character
        length text line resulted an unusably slow editing previously:
        waiting half minutes for changing, selecting or copying text
        parts.
        
        Manual test
        
        Create a text file with a 76 MB character long line, and
        open it:
        
        $ seq 10000000 | tr '\n' ' '  >numbers.txt
        $ soffice numbers.txt
        
        Note: the reverted commit had also a paragraph limit exceeded
        error using unlimited paragraph length, because that is limited
        in 4 GiB characters since version 4.3, see tdf#30668 and commit
        ba27366f3d6bc6b209ecd5c5cb79a9ee5315316a "Resolves: #i17171#
        Writer paragraph cannot be longer than 65534 characters".
        
        Change-Id: If91e340a8aac4d4ebc4097b19cfa854b5659da3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148169
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [bf2ba1f2f2ad1c5e3897de879dc932967a0c588f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c76109de27348a1b751ac398b978ebfa3a8825dc
          - tdf#153653 general update of Styles  correct icon for Assign command
            
               * simplifications and corrections in the existing descriptions
               * add icon table for Assign icon 
               * refactor <h1>,<h2>,<h3>
               * rename German ID
            
            Change-Id: Iabedafe2b73e9540dda22464b504e953efee4388
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147115
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-06  Stephan Bergmann  <sbergman@redhat.com>  [c9b0dcb767343865fc374c712b2fe768cd8aca32]

        The mentioned bug is fixed in Clang 17 trunk now
        
        Change-Id: Idb62b1b71a9f6fefc9225706655ca016304f1c42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148191
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [288c0920a8475f9f2c537212e04aa7649192ad8c]

        Check iframe target for allowed document URLs
        
        Change-Id: I00e4192becbc160282a43ab89dcd269f3d1012d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147919
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [09aca4a8bff06a719fa85d7287969e484fcb5e3f]

        tdf#153561 rename Heading No. and widget, update tool/extended tips
        
           "Chapter No." was changed to "Heading No." in
           e5a744851cb58da1ceeef623799274d73b60b030 to indicate the broader
           scope of the option in the entry structure. But the option is even
           broader, because it can also include list numbers of entry
           texts. This patch updates the "Heading No." widget to "Numbering"
           and changes its abbreviation from "E#" to "N#" to reflect this
           broader function. The associated tooltips and extended tips for
           these widgets are also updated to indicate this fact.
        
        Change-Id: I5505b09998cd3cccf61002213c1938a2afc2c607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148104
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-03-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3203cf9df2f295771515e5a38b597bbb9a17e6a4]

        oox: import font scheme structure directly into model::FontScheme
        
        Change-Id: Ic9084cbbf451ca406133f07476b8b4e7c234a650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147572
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9980022ef82526f4f76c963ec07fcc72f3ad0eaa]

        Fix typo
        
        Change-Id: Ic37731697ff15a4936cc8da580905484ebcca74e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148292
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [617f392a0adfc07afca87eea9ec75d7852658de5]

        remove unused BaseMutex from ColorPicker
        
        Change-Id: Ife43fad692d2c5651ae75fc675345ae3dd64aecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148274
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c5ebd807cafbb978b74f99eb937f8956ad880c6a]

        BaseMutex->std::mutex in PDFIRawAdaptor
        
        Change-Id: I3aae98e20ce20845835e1e5b7366a3f286e57ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [db02d2e1a74973cfb467c2f5bb12845bfdf37302]

        BaseMutex->std::mutex in DNDListenerContainer
        
        Change-Id: I0e7bb629eb4d52ddd43774a2c1a5133d6f265d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148278
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [974b837030185e71bb5c817cf0faf409682a432d]

        BaseMutex->std::mutex in OEmbedObjectHolder
        
        Change-Id: I0c05556e1d2585b48068094627be3e58a2640340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0244ef9e44c5c1dc9faf9705f2ae1dba499d62c]

        BaseMutex->std::mutex in OPropertyForward
        
        Change-Id: I9918bd4fbedb2f6517278c010b6ee66ba7f9c851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [43860c10b7d776a7767ef81b1cc833c35feea3c2]

        BaseMutex->std::mutex in PDFDetector
        
        Change-Id: I353a376b6e6e3e9e1c1a8e1fcbf6aefa273e26d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [928db79c823a55c1d2b2b7d7a64d5fbc8055a2af]

        remove icons causing troubles from sukapura_dark{_svg}
        
        These cause trouble when building - seems they were added by mistake
        as the icons don't match other spacing icons.
        
        Change-Id: I93538eed3fc913a5da0566d77bf2e6bc44031744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148290
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Justin Luth  <jluth@mail.com>  [57835f3e2524060fcb021ea5dfb31f81c089d4f1]

        tdf#153548 sc: don't disable all state when IsFormulaMode
        
        This allows "Cycle Cell Reference Types" (aka F4) to remain
        active when switching between unfrozen and frozen sheets
        in order to build a formula.
        
        workdir/SdiTarget/sc/sdi/scslots.hxx is a good place to
        find the linkages between slot names and numbers.
        I also added the slots I saw on my machine that tested
        as usable during formula-building.
        
        I considered the following (which were in the set when I tested):
        SID_INSERT_FIELD_DATE_VAR
        SID_INSERT_FIELD_TITLE
        SID_INSERT_FIELD_SHEET
        FID_INSERT_NAME
        SID_CELL_FORMAT_RESET
        FN_INSERT_HARDHYPHEN
        FN_INSERT_SOFT_HYPHEN
        SID_TRANSLITERATE_SENTENCE_CASE
        SID_TRANSLITERATE_TITLE_CASE
        SID_TRANSLITERATE_TOGGLE_CASE
        SID_TRANSLITERATE_*
        SID_INSERT_WJ
        SID_INSERT_ZWSP
        SID_INSERT_LRM
        SID_INSERT_RLM
        SID_CHAR_DLG
        SID_ATTR_INSERT
        SID_SELECTALL # didn't actually select everything
        SID_DELETE
        SID_PASTE # seems to work magically, probably b/c FastCall = TRUE
        SID_COPY
        SID_CUT # didn't actually cut everything
        
        Change-Id: I8b7f678a2f37a79474796a568a589b83abdde4de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148144
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-03-05  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6271aff7dcd530a7e8c5452200267960e27a7513]

        tdf#153465 Add Sukapura's dark variant
        
        Change-Id: I9f97c3990064db88fccf9269deb62414bfb6c3b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148011
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-05  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [27da754092a1260ad05e3e2c471e4e1f98b12bee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad78ad1596eecb0adead6fac10058e2ae1b7ba77
          - Impress: Rework of help files /02/ 15
            
            Change-Id: I90becc99c5a5f6563faaa198c538105554e67c12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147652
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-05  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [24b40175e264d1d66da3f9b951e693ae6d3e74ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4febb20b98aa9c063051122fffe6e481ccf90f4a
          - Impress: Rework of help files /02/ 13
            
            Change-Id: I0988c4cde3642c56b1ad56ef917886ed33547ef4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147650
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-05  Caolán McNamara  <caolanm@redhat.com>  [c0cf5df84dfa5363410898d433c01dfd511aee5d]

        ofz#56551 Timeout
        
        Change-Id: I491ef30362a56bf954233c3bc1e58549f9d2d5f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148286
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-05  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [a7c0764cc7a0f123e96d5b821b4ce86ffff144cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aeedc1df4170eadf458120ea1e94411f233102c6
          - Impress: Rework of help files /02/ 12
            
            Change-Id: Iba48d2a069ee7a3d491316f5f3fe1d12797c46e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147649
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b6709e27069bc933eb38d45234c07e3ac369158b]

        Fix typo in code
        
        Change-Id: I30f66cf9c5c9c0073565e61f96cd4677649d5a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148269
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-03-05  Stephan Bergmann  <sbergman@redhat.com>  [a45f25bdfb6166d754ebb8c7224c2e6bdc2e8527]

        Fix rtl::createUriCharClass argument (C++20)
        
        Change-Id: Ifb4d8a430adc19d51d07af3ca2aff66a7983224a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148283
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-05  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e7780530b92ed898f32fb8bca9a0c150096592d6]

        tdf#153465 Simplify Sukapura's light variant to make easier for generating dark variant
        
        Change-Id: I7d4d961b970be3ccdc261505b5ad4ab7ae982a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148017
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f0d51ef3e939c85995c0cb828e8cc94f98bd516b]

        Reword extended tips for caption heading numbering
        
        Change-Id: I15e0e0e069218d0f123639768b4fb80f23b4b7c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148181
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [e7ae5b4793fb74309d5d1f32c3c696d07071d676]

        tdf#152459: fallback to language-only when looking for grammar checker
        
        LanguageTool registers itself for languages like "en-US", "es-AR", "de-DE";
        but also for generic "en", "es", "de". When the requested language, like
        "fr-CH" or "es-PH", is not found in the registered grammar checkers, the
        fallback strings will be attempted.
        
        Change-Id: Id460db8d378f246ea98191d22bdb3537fd1aee1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148201
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8400b7d05dafadca2eec85c620f5955ab353eaaf]

        Bump Glade release for captionoptions.ui
        
        No change in contents, just internal Glade refactoring
        
        Change-Id: I3d84cd581240bb87a21d1ff42c5dc127d982364b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148180
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-05  Juan C Sanz  <jcsanz@libreoffice.org>  [2e6084dc61040ea113540146ef0709da5e9aa337]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cac1b0946ef184d11028d3f4f6e767f3e454ffd2
          - tdf#153940 New Help page for Firebird external connection
            
            * New help page by Juan C. Sanz
            * Connection Help pages refactoring by ohallot.
            
            Change-Id: I344644473985df809d2bc31be42b8a21467771f9
            Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148203
            Tested-by: Jenkins
            
2023-03-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ff666e2ee9bd5871693262558deb6b95c2af43a]

        remove unused BaseMutex in SwMailTransferable
        
        Change-Id: Ib079e354433905b25aa44a64779e0c54701858ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148253
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-05  Sarper Akdemir  <sarper.akdemir@collabora.com>  [c010b8cc712d1336ed79fb220764f1a850dc22e5]

        tdf#153180: PngImageWriter add support for gray alpha colortype
        
        8 bit grayscale images can have alpha accompanying it, and
        PNG supports 2 channel gray-alpha images.
        
        libpng supports this with the use of colortype
        PNG_COLOR_TYPE_GRAY_ALPHA.
        
        This patch adds support for writing GRAY_ALPHA colorType PNG
        images.
        
        This is done by expanding what was in place for
        ScanlineFormat::N24BitTcRgb with alpha PNG_COLOR_TYPE_RGBA.
        
        Change-Id: I80d462d784f91529eb9371c6bdb029c78f32f81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146138
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [ef6bf01f1b1d9b93bb306295f4723b52e4e1e5b4]

        No need to use a clearable guard here
        
        Change-Id: I34a3aba881ae3591130fb3a0d7ae9eb768f615bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148267
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [c084a8f30d1a5b9416340ee4a557da896d069882]

        Swap instead of copy-assignment
        
        Change-Id: I5f54dad94cde60dd299f3db22c19a3565a2524a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148268
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9f844b8917414345db4b599c7da9219532e31429]

        Fix typo
        
        Change-Id: I511583f0b8ce586fe9e6c3096597f0410c55b9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148263
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e540da2caadf4da228ddcc8c704f1f90a147493a]

        Fix typo
        
        Change-Id: Iddc3e2a28eb638f52a0560925bdeffddb20d3a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148264
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [abe7425d44a2f367440da2d5d552d781e5511958]

        Fix typo
        
        Change-Id: I5b58180d4d048155b927156be1fb6fb22f0e657c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148265
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [08ae7b4cc0fa7eef178a6c2bb9a70e998701de82]

        Fix typo
        
        Change-Id: I1392e8e20e42b13a28b13bd611eedccf7b9c088f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148262
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-05  Stanislav Horacek  <stanislav.horacek@gmail.com>  [b5e8d9ae9b1e8c16a2d53851191d7c6c63422916]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 793e57c7e3ee1d20e7fcd199dc35af133539b6fa
          - line break is actually CR+LF, not LF+CR
            
            Change-Id: I22aa8c3f50b4ea35c6f48d8e1baed1df73c46d69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148212
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-03-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b33468fa2b5dadddd7ce27afd40979aafff61285]

        make NbcRotate abstract as it's implementation is noop
        
        During testing the NbcRotate function on SdrObject it turned out
        the the function is essentially a noop, because it uses normal
        equality to test the values of a double, which are a product of
        sin and cos functions (to determine the 90 degree angles). So
        because of this the input rectangle was never modified - noop.
        
        Because of this we can just remove the impl. of the function and
        declare it abstract, so that the actual implementations define
        a valid function to rotate.
        
        There were some subclasses that didn't override the NbcRotate so
        they used the one implementation in SdrObject. These subclasses
        now override the function and in the implementation we call
        assert(false), which is never called during a test run. It seems
        we never rotate those objects.
        
        Change-Id: I1b1a45a8e96ed2d061f9b9f80c5fdaa5a84d4c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148266
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Heiko Tietze  <tietze.heiko@gmail.com>  [62a0eb0a604a91b84d346fb50a12f868dbf7147f]

        Resolves tdf#153344 - Resize View Mode icon in statusbar to 16px
        
        Also removed the "_10x22/24" from the icons
        Space between icons now generated per code
        
        Change-Id: I061ccc9d46f3a6c8c6d2cbc6acedfa9fc33e472a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148163
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b53b01a050bbb43cd571c428e86fc23a2fa5773c]

        svx: make SdrObject abstract by making CloneSdrObject pure virtual
        
        This change makes SdrObject an abstract class that can't be as
        we don't want it to be instantiated. With this the ClonseSdrObject
        became a pure virtual function.
        
        With this change also the SwFlyDrawObj needs a implementation of
        the CloneSdrFunction, which was previously provided by SdrObject.
        
        Change-Id: I2efb8c1e6fac12b17ce497285067029d7da1c1fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148239
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [89d19cf6e721652eaa19eee2e4700eb4e4fdb540]

        svx: add test for RotatePoint
        
        Change-Id: I62182fa02843d428d1b745c55ab695450ec4940a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148235
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e74c6e8550ae2644e30752e1fa91005c2a412ec7]

        svx: SdrRectObj move, rotate tests
        
        Change-Id: I448f82d87be34c58d0abf4f6a0c1e6192567b807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148234
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d2e757b9c6fbf7c205a7229f06e559e85bd8ead9]

        svx: remove unneeded rectangle inits
        
        Change-Id: If430eace7e82ff52bb10c83b5f66148e2d9ade13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148248
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-04  Eike Rathke  <erack@redhat.com>  [811b28aca2e46491081f6cb60e6a26f411c375ec]

        Rename to GetRankNumberArray() because that is what it does
        
        Change-Id: Iee170972769ea8366a7dfa3edd098a9342a2268f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148260
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-04  Eike Rathke  <erack@redhat.com>  [08b4ff03606540f8366217be8096e147f47dee49]

        Comment that LARGE()/SMALL() rank svDoubleRef can not be hit in array mode
        
        Change-Id: I8df18b3164941cbf7f58317c2effec05ac0cb492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148255
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e6d8db305d6ba63b6a4a4c5046177a0d607678f6]

        A bit more of refactoring
        
        Change-Id: I43dde0375674c4078658a2179108edb5187d2cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148257
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-04  Caolán McNamara  <caolanm@redhat.com>  [1e98b383f517ebc8c6b07aaa0cba5390a7b935d4]

        crashtesting: frequent assert on export to docx
        
        this is the same problem for docx as fixed for rtf
        with
        
        commit 811dfd7f2706f56119a1943e08d9bce73b0d2203
        Date:   Tue Feb 28 15:48:30 2023 +0100
        
            sw: RTF export: fix assert on fdo37077-1.rtf
        
        so merge this duplicate code together and use the fixed
        version.
        
        Change-Id: I6a97d94a6cdaf488228a0a89088a3e14ca7e1749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148256
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [9eb083ab732512c3ab64007c3be1c54be97172f6]

        check GetShell
        
        it might return nullptr
        
        Change-Id: I65b43d69f4757b6c331582ca2e256cdea01377af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148194
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-04  Pranam Lashkari  <lpranam@collabora.com>  [95ee8a692cbc3f8ead72e61eb36b9015f1c57605]

        jsdialog: sort enabled UI files by name
        
        this helps avoid repeating them
        
        Change-Id: Iaa1d73ca1e396c18a0486ca89cb3b0a26571569d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148241
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-04  Pranam Lashkari  <lpranam@collabora.com>  [542cef171ceed4577c1c71735726b1e7c7c9c8c9]

        JSDialog: implemented jsdialog support for the toggle buttons
        
        Change-Id: I21408f7344f7e100373c368036f81503302b93ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148240
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-04  Galdam  <qmebic1975@gmail.com>  [e1fb2dd31dd17752c1573f341876bde7c7f12142]

        tdf#153606 - Add MacOS Icon Shadow
        
        Added a shadow to the new MacOS icon
        
        Change-Id: I644ae1e63055bbc5fd8f6ade6f5aaed7290831c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148238
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [e35905c1b295ff4f1f03e845e8849bc8400cd952]

        Set useragent for requests to LanguageTool server
        
        Use the same string that is used in CurlSession
        
        Change-Id: Ia383f2490cf484715f429df09ec80603ca3f9387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148251
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [5a87ff41ef784d6390da0df49b60186c21047112]

        Restructure and deduplicate the code
        
        Change-Id: Ib8701cbfbe0a025e19c34f0b52e0f67bf728f636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148250
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-04  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ecae66c41d82fecddd630cfdc144055a069134b0]

        MCGR: ColorSteps handling moved to tooling
        
        Due to the fact that handling of a vector GradientSteps
        will get used more often with ongoing changes I moved
        some handling to tooling, see sortAndCorrectColorSteps.
        That method sorts and corrects a vector of ColorSteps
        so that only valid entreis remain in a sorted order,
        for details please refer to the docu at function
        definition. I took the occasion to rearrange that to
        work on the single provided vector which is better for
        speed & ressources.
        
        Also changed the ColorStep constructor to not
        automatically correct constructed entries: While that
        is formally correct, it moves an invalid entry to 0.0
        or 1.0, thus creating additional wrong Start/EndColor
        entries. Those may then 'overlay' the correct entry
        when corrections are applied to the vector of entries
        which leads to getting the wanted Start/EndColor to be
        factically deleted, what is an error.
        
        Also rearranged FillGradientAttribute to now work
        initially with ColorSteps, no longer requires the
        Start/EndColor, also adapted all usages. This securely
        allows start/end and in-between single-color sections
        in gradients.
        
        Also needed to re-formulate GradientRect &
        GradientElliptical ::appendTransformationsAndColors
        method for correct 2D mapping(s) - always incrementing
        from the start to end conflicts with the adaption of
        the start value for the inner loop mainly because
        increment is at start of inner loop (pre-increment).
        
        Corrected errors from clang plugin, but also some
        wrong initialiations for basegfx::ColorSteps.
        
        Change-Id: I292592ed9abcfa591f68a680479f4fcdda46cbeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148196
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [43dcdfae40c9c37032ed5e92cd0634feb53b706d]

        tdf#153617: percent-encode the text sent to LanguageTool API.
        
        Change-Id: I0bb55c70f5602444440fca6e3c13b3d75418e49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [bbfb49433a04f7ce882c2614f460f0f07860532c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 29aa6b53e0e674e5ccb75515ed7a45a4be8324d3
          - tdf#153549  Chapter -> Heading
            
              swriter/guide/indices_enter.xhp
            
              swriter/guide/indices_userdef.xhp
              - refactor <h1>,<h2>,<relatedtopics>
              - remove irrelevant paragraph
            
            Change-Id: I2f6961ee8afebc681e4722dc4755c4bf76cdd6d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148220
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-03-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1d289a745e40cb47c14dfd42111c47f1d5c6cc84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a84febe0937a59a893cf3c08c310233c1339bfa
          - tdf#137281, tdf#153549  clarify use of heading and chapter
            
            Change-Id: If022346a4c705cedaf2d50c9efb9e46f5b3ea620
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148219
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-03-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [abb2151dc915defbc12dcf78bd01ae69f2f1f292]

        tdf#141319 - Special Characters Dialog: mark empty/unused cells
        
        Change-Id: I123aef9f9763b2ae88c4b4f6748b69f9d9c394af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148051
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fa8a60c76117cdd0f4290fb5afbe7f5c1463d801]

        svx: change Poly2Rect to return a rectangle, also clean-up the code
        
        There is no need to pass the rectangle by reference and to change
        it inside the function, better to return a new instance.
        
        Also clean-up the code of Poly2Rect and rename the function to
        svx::polygonToRectangle.
        
        Change-Id: I25e77c8abd12e2075939f55e06f40343ac23ca97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148211
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bb4a052a768d5936e0e241b15d3c08a56284eeb4]

        svx: SdrTextObj maRect - use getter and add funcs. for manipulation
        
        Change-Id: I0a416fa2ac470650c2ef430dbb91bf8d5a8013cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148210
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-04  Heiko Tietze  <tietze.heiko@gmail.com>  [f763e453263a8acfdcdf553a7c3a46ddaf476c13]

        Related tdf#153344 - Resize Selection Mode icon in statusbar to 16px
        
        Also removed the "_10x22" from the icons
        
        Change-Id: Iccdd5b784f43f1588aa1b5e72d01dd220209cc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148120
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [0e0054dfd7dbf382325696cefb24a6bc48474293]

        tdf#153803 qt: Let Qt style draw combobox popup borders
        
        ... and listbox popup borders as well.
        
        Declare suppport for native drawing of focus for
        pushbuttons, since the Qt-based
        VCL plugins take care of drawing focus for controls.
        As far as I can see, there is no need to actually
        implement drawing of focus separately for the Qt-based
        VCL plugins, though, since that is already handled by the
        `ControlState::FOCUSED` state when drawing the entire control.
        
        Support for this is what `ComboBox::ImplInit` and `ListBox::ImplInit`
        check and if it's not supported, they enable double
        buffering for the window (which would have the result that
        the `pWin` in `ImplDrawFrame` in
        vcl/source/window/decoview.cxx would be nullptr and thus
        no native drawing of the frame would happen), s.a.
        
            commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e
            Date:   Mon Jun 17 17:02:54 2019 +0200
        
                tdf#101978 vcl combobox/listbox floating window: avoid flicker
        
        With this in place, the border in the popup windows
        for listboxes and comboboxes are drawn by the Qt style.
        
        Yet another way to achieve this would be to support drawing
        `ControlPart::ListboxWindow` for `ControlType::Listbox`,
        so that the other rendering path in
        `ImplSmallBorderWindowView::DrawWindow` is taken, but that is currently
        complicated by the fact that bounding and content rect are
        not really used consequently there, so that would have to be cleaned
        up first, s.a. the commit message in
        
            commit 5c96e813bed3293605f8d746f188cc051d1e5949
            Date:   Thu Feb 2 15:27:37 2023 +0000
        
                tdf#150451 Fix borders in Editbox controls (kf5)
        
        for more details.
        
        Change-Id: I8cd2396e7075a475e53e016acbb16d6fb54bad2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148160
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [5b9089a23757805ffdc852944d6483cf0db15121]

        tdf#153948: LanguageTool: cache the prepared request
        
        So that when the same text is re-checked using different
        settings (e.g., language), the cached result is not used.
        
        Change-Id: Ic4ed63c6835f9d3935f1b9541c80822bb52313c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-04  Szymon Kłos  <szymon.klos@collabora.com>  [92e93f25e5db2f6a2a6368c131ae83244b0c5a7f]

        jsdialog: enable chart wizard
        
        Change-Id: I7d6f4b4e6022507a57224ad40785f5f4f4537ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148215
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-04  Szymon Kłos  <szymon.klos@collabora.com>  [8128a6a8e2c59a2ac6aafe96a69b6dd5c4a32ceb]

        jsdialog: handle weld_widget_for_response
        
        Change-Id: I3b8d3911ff93bd26f8bdfb498b547fd335c3db8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148113
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-04  Szymon Kłos  <szymon.klos@collabora.com>  [a5e2201643392d0509cb970faf1c1e7038d14f4e]

        jsdialog: correct structure for RoadmapWizard
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Id9837c208653311608bf39d6066cbf1345efc565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148214
        Tested-by: Jenkins

2023-03-04  Pranam Lashkari  <lpranam@collabora.com>  [feda414f8b70f50a9f6745d2ce8828316d4711cd]

        sc: remove protect cell tab from cell format dialog
        
        Change-Id: I33a32ca756263426abb4dcb733139baf58221554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147897
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2023-03-04  Eike Rathke  <erack@redhat.com>  [019e751c71dcb2d34c6fd8bb9dda267c6ba2b48e]

        Resolves: tdf#153924 handle non-numeric and error values in rank array
        
        ... of LARGE()/SMALL() instead of yielding error value for all result
        elements.
        
        Fallout from
        
            commit e4c2d0bb57ab8ea8f5c400d103d01376b8140f22
            CommitDate: Fri Nov 30 22:14:17 2018 +0100
        
                i#32345 Support a matrix of rank argument for LARGE()/SMALL()
        
        that in ScInterpreter::GetTopNumberArray() required the entire
        rank array would have to be numeric, which with an empty cell or
        string it isn't.
        
        Change-Id: Ieaa1a68bb8f98614119550b1442665b6fbb4817a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148178
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [db5b7400aec082dacdc09f8b741c70aa5852f25c]

        Reword extended tips for optcaptionpage.ui
        
        Change-Id: I455cb963d6e6aa0107f70492c175e5cbc449f445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148193
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d7c609dbb1bd08865b43719d2fb7c316d30bcde5]

        Bump glade version for optcaptiopage.ui
        
        Change-Id: I00b6c1e8b4628ec8fa643b9e9b9c03d403a3b576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148192
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-03  Szymon Kłos  <szymon.klos@collabora.com>  [60938693aa41df5319bc4d73e4c65c09beda19e6]

        jsdialog: add wrapper for weld:Assistant
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I82d045cbcc7fc4682c251ac51b19b3bd33f813f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148190
        Tested-by: Jenkins

2023-03-03  Marco Cecchetti  <marco.cecchetti@collabora.com>  [00ac4d375922b96d94e42846c9555d22470fb2f6]

        lok: macro: VBA message dialogs was causing assertion failure
        
        Get VBA MsgBox and VBA Runtime Script Error dialogs to be displayed
        correctly without causing an assertion failure.
        Provided a solution that allows VBA MsgBox to be executed in a
        not-async way so that the VBA script is paused until the message box
        is closed.
        
        Change-Id: Ica7d0d343a0ea4b6a163c1c43572f18a5779a0ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147243
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147321
        Tested-by: Jenkins

2023-03-03  Szymon Kłos  <szymon.klos@collabora.com>  [3fce5f707789fe623672e2eebd731756c826dadc]

        jsdialog: hide not-used tabpage in the wizard
        
        In the wizard initially we show only the first page.
        
        Change-Id: I18ff5362f9ceb9989bfba2d9fddebf95230331e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148108
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-03  Caolán McNamara  <caolanm@redhat.com>  [4f45d7bb863a991e70adcea4848377a3c65f7194]

        Related: tdf#94319 object pasted in draw/impress is always centered
        
        this is a recent problem since:
        
        commit d60722e29a0dde6282915188e5ff7e24890a14d3
        Date:   Thu Jan 12 16:25:40 2023 +0200
        
            XUnoTunnel->dynamic_cast in TransferableHelper
        
        Change-Id: I764b62d7a395d01f8e86174ce8e4d30dfeb80ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7545f47eb93373324eed35a7253e55448bbbdfbd]

        update credits
        
        Change-Id: I6d5a9f661041361e7c516887a298c84ac71e14ff

2023-03-03  Michael Stahl  <michael.stahl@allotropia.de>  [7391942099d4a76639c1aa8e559643b2702da2b7]

        tdf#137883 filter: use en-dash instead of hyphen in UINames
        
        (regression from commit ed0476b0625c4361df5ff040a6661a9634588cea)
        
        Change-Id: I7c380a9871cf16623031751bd735f456a7ea200f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148167
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [164f4b4a106ddbe6c112c8696f510e72d7da6959]

        Simplify a bit
        
        Change-Id: I71ec9be6b2003971cdf3c4c1a2a7c21092a316ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148184
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [23325d1f20876938ed9d6a6cc3769d5ebbd880a8]

        Update git submodules
        
        * Update translations from branch 'master'
          to 381ab7a2ca3677aa759e77e5dfd7e8cbde87b4d7
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I569b418ab52bf1703326225f0b341c580ccdf55e
            
2023-03-03  Kohei Yoshida  <kohei@libreoffice.org>  [c4187189060a104cf36d8a8c9b2958b8c28cde0b]

        tdf#148143: Reset the position hint when flat_segment_tree gets copied
        
        std::optional stores the wrapped object as part of its memory footprint,
        and when it gets copied, it copy-constructs the wrapped object too.  We
        need to be aware of this when using std::optional inside std::vector
        which may reallocate its internal buffer and copy the stored elements.
        
        Change-Id: Ib8fab1295388ae2ee9ef3d044943ac3c2bc8e529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148152
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-03-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c791a4d32fa971554ef192d1e61ee56e705710d5]

        Reword extended tip for field heading numbering
        
        Change-Id: I22ad2251d9d889966bae8bcd2505d15f13f48b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148183
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [43da51e9f6dbd9a90e7cd9f67d7dae6116b6a14f]

        flatten SvxForbiddenChars_Impl and associated map
        
        std::map is a node-based datastructure, and ForbiddenCharacters only
        contains two ref-counted string data types. No need for all this
        indirection.
        
        Change-Id: Ib4fa49e60557c7e5c41bb73ebeb23c4db6d33406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cdfc95ab0e298cce13c0baef907001a0c43159de]

        Bump Glade release for fldvarpage.ui
        
        No change in contents, just internal Glade refactoring
        
        Change-Id: I0e68abc7176e50b4e36fdb3443192f363d90843b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148182
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-03-03  Szymon Kłos  <szymon.klos@collabora.com>  [8c5c9e943d1b754136cc1a76222fa7f84bbfd710]

        Move SalInstanceLinkButton declaration to header file
        
        Change-Id: Icd5b79f31e1839303e81c1914c9e30e078661d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148111
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-03  Justin Luth  <justin.luth@collabora.com>  [620d1dc63b652db97b05eb21685dad70e6b2ab0d]

        tdf#153613 writerfilter: handle defered break before SDT start
        
        If there are deferred column or page breaks before an SDT,
        then before starting the SDT we need to determine if the
        existing run needs to split - same as everywhere else.
        
        There was only one existing unit test that had any defered
        page or column breaks, so only two example documents to work from.
        That was tdf125778_lostPageBreakTOX.docx.
        
        Change-Id: I02d71577af13399d8aaf3ba0ce40fc6bed5e6e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148148
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-03  Caolán McNamara  <caolanm@redhat.com>  [f87ea14edfe3053e3091731deb90fc87c17ddad4]

        Related: tdf#94319 Revert "tdf#63956 clip 19km long line to some sane limit"
        
        This reverts commit d1046e7c3f66e5f3384ee1ef534ef28346702fc6.
        
        and all its associated follow up fixes. Doesn't actually have any effect
        on the issue which isolated it as a source of the problem which has
        mutated in the meantime
        
        Revert "tdf#126184 Use max paper dimensions to calculate clip region"
        
        This reverts commit 1dccd6814f1fe7a06f3168d01d18d347269cd3c1.
        
        and:
        
        Revert "Resolves: tdf#101187 colossal page width wraps around if doubled"
        
        This reverts commit 2fd88ab1cbb4690a770ca2ca5d66157ec4906a2e.
        
        and:
        
        Revert "Resolves: tdf#98366 paste document has 10x10 sized SdPages..."
        
        This reverts commit 93efd7ebbad293d3729b8ea4b9726aff498f607f.
        
        and:
        
        Revert "Resolves: tdf#97276 don't clip out line if the underlying page size is unknown"
        
        This reverts commit ad99c633908f7c70d06812ebfb4e0696666f0158.
        
        Change-Id: I22d3e1592c172f137fcec8085ff3240428f0d248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148170
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [df182c7e4235513916204a4dc4aec6ec6e4c746b]

        flatten OGenericUnoController
        
        rather than having a confusing mix of pimpl pattern and inline fields
        
        Change-Id: I2953df1893f49efb43f387d0d6348c6b17de83f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [37a4d67d6885860c279476c2504e35c3190ffc6c]

        flatten DocumentUndoGuard
        
        which is a small object, and doesn't need a pimpl pattern
        
        Change-Id: Ib76f6e5ad0347be61fe29b22f57e1211ce3337cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Szymon Kłos  <szymon.klos@collabora.com>  [e55096a07a450782c4ab919b7ba60852841004c7]

        Move SalInstanceAssistant declaration to header file
        
        Change-Id: I3407893c878fd37fe0968c2990c92d5d16213ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148107
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-03-03  Michael Stahl  <michael.stahl@allotropia.de>  [2721520ca37654056c3d509657c50ee42e3dcae4]

        tdf#153925 xmloff,sw: decorative flag on frame styles
        
        * sw API SwXStyle property "Decorative"
        * UI checkbox "Decorative" - split up the GtkFrame to always show it
        * ODF import/export as loext:decorative on style:graphic-properties
        * test for ODF filters
        
        Change-Id: If124cb50ee7776b5807720e65f41a07e7b9f4cf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148143
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e1c5960450a5cb8ba93490bbd99533b6070d558e]

        Fix typo
        
        Change-Id: Ic3b7dc043e13717e13ec19184f8771acdae0e5f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148141
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [ebee2930a3558c5eb8921e1b5f3e275702f8a64f]

        Fix SAL_INFO dereferencing optionals
        
        Change-Id: I6d8ec4cd481284a42db33bf85ec7770fbb89cf83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1c257c862df04d69486170bbfc7a17e6367dc950]

        Fix typo
        
        Change-Id: I2cc214d4e4443f199b9b8160560a392302654ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148165
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [d1589ade91cfadf860c31ca30c97a60f95afa928]

        Disable test::AccessibleTestBase::awaitDialog() on macos altogether
        
        The API doesn't actually work there yet because we don't get any event,
        so there's no point in exposing it there, and it makes it clear it
        isn't available there, avoiding future user to wonder why their tests
        do not behave there.
        
        Change-Id: I38dcc98ad3bc3b669df64bc1c53c91ef48a0d717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147574
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [8a449f2de0d926967331436adfd3d5dd0b9e2db8]

        test: Use css::awt::XExtentdedToolkit::addTopWindowListener()
        
        Use awt::XExtentdedToolkit::addTopWindowListener() instead of
        Application::AddEventListener() for lower dependency on vcl::Window.
        
        We however still require some vcl::Window for EventPosterHelper to work
        without which we cannot post events to the dialog.  It however doesn't
        really have to be the top-level window itself, any vcl::Window high
        enough the event tree would probably work.
        
        Change-Id: I40b56a6c9e45f4e2ef2cab27a735856baef7e3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146634
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [655f6164e38c2f675beb5272fc6a9780f4767429]

        test: Run user dialog callback in idle time
        
        On e.g. Windows we need to let the dialogs fully finish starting up
        before we can properly interact with them, and especially close them
        again.
        
        We notice new dialogs with the WindowActivate event, but this will
        happen before the dialog is fully set up internally, leading to
        failures on Windows.  In practice, the WindowActivate event might be
        dispatched before the dialog setup function finishes, leading to an
        intermediate state at WindowActivate time.
        
        Work around this by running the user code in an idle timer in response
        to the WindowActivate event, so that the setup code can return before
        the callback is dispatched.
        
        Based on findings by Michael Weghorn, thanks!
        
        Change-Id: Ieecee09d84144570fe1943ca12dc1db6d9f64524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146378
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [1791b26d75bd50971fe58627c6554f1711890817]

        test: Add debug print support for XAccessibleAction
        
        Change-Id: Ic511f2abc62703ead40a585989c54345cf3c17ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142261
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Miklos Vajna  <vmiklos@collabora.com>  [27b8c67bb154d2e09c2377a5f73621b72167a226]

        lingucomponent: don't get locales from the server when this is disabled
        
        Do it like LanguageToolGrammarChecker::doProofreading(), which already
        checked for this setting.
        
        Helps when soffice starts up in an environment without network access
        and also is pointless. Avoids this warning:
        
        warn:languagetool:13511:13511:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:508: CURL request returned with error: 28
        
        Which looked odd, given that LT was disabled already.
        
        Change-Id: Ideb0c59ad79bdbd7d22acef22e31a43377d30ec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148166
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [7801b5f7562a8d1660053a2745b4f6e97b555bb2]

        test: Add helpers to get a specific object and tab to it
        
        Add a tabTo() variant that accepts a target object that should gain
        focus. This is useful to work around focus issues in the implementation
        (although they should be reported and fixed), and it's a simpler and
        more efficient API if the caller happens to already have a reference to
        the target object.
        
        This also adds AccessibilityTools::getAccessibleObjectForName() as a
        usually more useful alternative to
        AccessibilityTools::getAccessibleObjectForRole() as it allows to easily
        match both role and name. There is also a template version accepting
        multiple role and name pairs to further refine the selected object.
        
        Together, it makes it easy to obtain the target object and tab to it,
        in situations where the other tabTo() variant either doesn't work for
        some reason (as mentioned above), or is not the slickest solution.
        
        Change-Id: I6a41b147331132711ac84776bb43ad24a091ba24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142260
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [be86c74bb5bf04347846261243c8eb21dc8d7200]

        test: Add a few basic dialog tests and helpers
        
        This adds basic tests for a few dialogues, showcasing and exercising
        the dialog handling code.  Those tests are extremely basic but show
        that it is trivial enough to interact with a dialog.
        
        This adds a few helpers to navigate the UI using keyboard events as
        well, because it's one of the best methods to verify the actual
        interaction works for a user of assistive technologies.
        
        Change-Id: Idc1f279f35ff01769138c3addb10ef851ca0dbb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Colomban Wendling  <cwendling@hypra.fr>  [ab0681dadc15b569027c5ce637441ea95eae1631]

        test: Fail earlier if we don't get WindowActivate events
        
        Instead of waiting for the CI itself to timeout after 45 minutes, or
        for an interactive caller to kill us sometime, don't wait more than 60
        seconds for a WindowActivate event to show up.
        
        This should not happen in the working code paths, but can help when
        something's going wrong.  Currently, this could help macos jobs to fail
        sooner.
        
        Change-Id: Iabce82b31440c14fd16478f1e574ce376027441c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146099
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-03  Miklos Vajna  <vmiklos@collabora.com>  [70d0281bbd36c25b5251f4e1c99507084659db90]

        sw layout xml dump: extract SwPageFrame::dumpAsXml() from SwFrame
        
        Avoids an ugly static downcast.
        
        Change-Id: I66f59409788f04e03c8c36bb12dc4ba7d3446663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148159
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-03  Miklos Vajna  <vmiklos@collabora.com>  [e66632b023ee1cf25a381536f53458f631964bb8]

        sw floattable: try to grow fly parent when trying section/table
        
        The bugdoc is meant to be of 2 pages, but the last row of the table went
        to a 3rd page, even if there was still space in page 2.
        
        SwTabFrame::MakeAll() had a case where it tried to grow section or table
        parents, that's how a similar case worked for multi-page tables in
        section frames.
        
        Extend this to also consider split fly parents, which avoids the
        unwanted 3rd page.
        
        This broke the rendering floattable-3pages.docx (it had 2 pages), which
        pointed out that SwFrame::ImplGetNextLayoutLeaf() was buggy for split
        flys. That function is meant to find the next layout frame which is not
        a lower of the current frame, but it had to be extended to handle the
        split anchor frame of split flys. Also, if we're here, remove the other
        split fly check in SwTabFrame::MakeAll(), which now looks redundant and
        is odd (there is no similar check for sections).
        
        Change-Id: I83090ac04ca27b71f62315e3b9755c8196057b5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148162
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-03  Miklos Vajna  <vmiklos@collabora.com>  [edaf6155496d452c67aa191c1d45a0328ef079e0]

        sw floattable: undefined behavior in SwFlyFrame::UpdateAttr_()
        
        The switch-case handled RES_FRM_SIZE and RES_FMT_CHG together, so when I
        added RES_FLY_SPLIT as a 3rd case for the same block, it started to
        handle RES_FLY_SPLIT as RES_FMT_CHG.
        
        For multi-page floating tables only the shared code is interesting, so
        just make the condition in the else branch more strict to avoid the
        unwanted downcast.
        
        Change-Id: I5015b06059f05fee400f427514d950d95a49df94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148158
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c4d4b370d2f6645c797c626d407013702f474c7]

        tdf#153926 crash when trying to change language for selection
        
        regression from
            commit 5032262fccd0ef7f274323ae481b3230ffd42d3a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Feb 21 15:05:37 2023 +0200
            BaseMutex->std::mutex in PopupMenuControllerBase
        
        Change-Id: I46b6458a809659845de26059fcab4772e5089ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cd6cba3edcba6497220924acc6716ea6027e559]

        Revert "BaseMutex->std::mutex in AccessibleSlideSorterView"
        
        This reverts commit 64c19da4c924c45df037c075ef88d1f01a5abbe9, which
        is causing deadlock when loading
             https://bugs.documentfoundation.org/attachment.cgi?id=180272
        in gtk3
        
        Change-Id: I346fa576cbbb7355e65483ff5aba1f67cf21469a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [60d9e89f5a18b437016cead0c5fb688d202bc90e]

        reduce casting in writer html export filter
        
        Change-Id: I8e690eea423a60a5009376a222d18ac214c77bc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-03  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b9716112219469fa4e0af33a6edb7eec0ff33026]

        Refactor TBL_{REL,}BOXNAME to SwTable
        
        - because those only modify the fields of that one table
        - also add lots of const_cast unfortunately, but not because it makes
          things worse:
          * this was modifying the table before (thus non-const)
          * at least now this is a bit more explicit
        
        Change-Id: I0174daecabcc6de9b7c9867b24c94659c0dbcafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-03-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5d7687c62a7f8d60267ce45ad27befc7d6567c24]

        Remove duplicated include
        
        Change-Id: I89652d205efa508f2f9ccd2c449d4c54fa8b325a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148140
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-03-02  Kohei Yoshida  <kohei@libreoffice.org>  [687b950702c49c90cff9a43655ea97a0343799a0]

        Add a means to query the internal broadcaster state ...
        
        ... and use it in one unit test case.  Also, remove the code inside
        DEBUG_AREA_BROADCASTER macro since it no longer builds & has been
        superceded by this new state query method.
        
        Change-Id: I38691a76df5c63034ff488522936dd566bf8b4e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148079
        Tested-by: Kohei Yoshida <kohei@libreoffice.org>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-03-02  László Németh  <nemeth@numbertext.org>  [e34074feeb1b918ab9f26a18c5fdb0b1f2e35f94]

        tdf#153891 DOCX import: crash fix at missing cell properties
        
        Regression from commit 81ce88aa80f8e7cde4fdc5b211e9500a3599643c
        "tdf#132514 DOCX import: fix lost table style with footer".
        
        Note: no crash without this fix by removing styles.xml from
        the test document.
        
        Change-Id: I7fd7edfc8f62e6b17c0c8f7a3bdec7d986ba57eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148053
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-03-02  Patrick Luby  <patrick.luby@collabora.com>  [4637080c28ac082ca44ee37e05e1b0c0a6183ba6]

        Enable building non-Mac App Store Universal .dmg from merged and signed .app
        
        Add a new bin/create-dmg-from-merged-app-bundle script which is used to
        package a merged and signed .app folder (created with the
        bin/merge-app-bundles and manually signed) into a distributable .dmg.
        
        Also, add .jnilib files to the lipo list in bin/merge-app-bundles since
        these are really .dylib files for Java.
        
        Change-Id: I1da4105b0820251580401f975f499b8d59a20499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148101
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-03-02  Caolán McNamara  <caolanm@redhat.com>  [ba42b8b95b2166f9bd578cd90c54e9826a755a6e]

        tdf#153672 Use RelativeMapMode so text in gdis are scaled/offset correctly
        
        otherwise it overrides the outer GdiMetaFiles efforts to position the
        origin and the text is rendered off-canvas in this scenario
        
        Change-Id: If81692dce81fb6f00d5051228e1de13cdcae1770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-02  Caolán McNamara  <caolanm@redhat.com>  [caa1d1ccf39ff8a60b7d89dd53afbf73d3cafeca]

        Resolves: tdf#153787 highlighted entry text overdraws selected entry text
        
        Change-Id: Iabf1d4a672aa508c5143f12169678278186ddd47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [846302d212ec2a88b7d83d7cde4e2dd0cf930fbb]

        CppunitTest_sc_subsequent_export_test2: split in two
        
        it already has 123 tests
        
        Change-Id: If9630e89b17cb68b23a0567b5a6cca33f4f32f92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148135
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Justin Luth  <jluth@mail.com>  [f2c581c7b603eb7c3d93af2e685e300d5aec5ae6]

        tdf#62032 sw List Level UI: don't require old value
        
        I added the qualification at the last minute,
        in imitation of other properties which according
        to coverity scans could actually hit the qualifier.
        
        Well, as Seth's testing shows, very often there is no
        such oldvalue (for example on the default paragraph style),
        and so this should not prevent us from setting something.
        
        I can imagine that editEng paragraphs could issue an exception
        if we try to set this property. However, in the testing I did
        (against a comment's paragraph) this tab page did
        not come up.
        
        Change-Id: I0fcc45d100b01716b87316c1bbb9f69eb7c577f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148129
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-02  Stephan Bergmann  <sbergman@redhat.com>  [bd6dad1bbc8a0707202fe67ce9db502692f7098e]

        Missing test dependency
        
        > warn:vcl.builder:3976130:3976130:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at /home/sbergman/lo/core/xmlreader/source/xmlreader.cxx:67"
        > warn:sfx.view:3976130:3976130:sfx2/source/view/frmload.cxx:495: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:67"
        
        Change-Id: Ie46f6c39f5d6cc4942d71c61bb5349ffe8f6a695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-02  Caolán McNamara  <caolanm@redhat.com>  [e61d12f815f825fef24f0260ccfcaa9248ccbd89]

        drop TooLargeScaleForMapMode import check
        
        revert this part of:
        
        commit 32dc2d14287a4210589c33dbd62c6e36e095aa6e
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Fri Mar 18 19:50:12 2022 +0000
        
            ofz#45583 detect some invalid scale cases at import time
        
        Change-Id: Ib80eda465d5b9d975a5b30974241d9f824c6741d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148130
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-02  Michael Weghorn  <m.weghorn@posteo.de>  [699a1745f30cc0e89d59c6fc6ea742da5ff0ccea]

        tdf#152073 tdf#153895 basicide: Set bg color for border win
        
        As described in the original commit to address tdf#152073
        ("Glitch rendering line numbers in Basic IDE editor (kf5 only)"),
        the fact that the KDE Breeze style's frame border is partly
        transparent was causing artifacts in the Basic IDE:
        
            commit 6f4b8b7cfe2907b7da46eec6951a0e09b836a6de
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jan 31 16:08:53 2023 +0100
        
                tdf#152073 qt: Draw background when drawing frame
        
                For native drawing of a frame (border), use
                the window background color as default color.
        
                As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06
                ("tdf#138010 (IV) VclScrolledWindow: Use actual border width"),
                the Qt/KDE Breeze style uses a frame width of 2, with the
                actual 1 pixel border being surrounded by a 1 pixel
                padding/margin.
        
                Transparent background did not ensure that the 1 pixel
                padding/margin is repainted and could thus result
                in artifacts from what was painted to that location
                previously (s. the Basic IDE editor example from
                tdf#152073).
        
                [...]
        
        However, there are cases when a transparent background
        is actually wanted, like in the print dialog (tdf#153895).
        
        Therefore, revert the original commit mentioned above
        and explicitly set a background color for the border windows
        of the involved windows in the Basic IDE instead, which is
        in line with the alternative already mentioned in the above commit
        ("An alternative might be to explicitly draw the
        background further up the call stack, [...]."), but enables
        transparency in the qt5/qt6/kf5-specific drawing for
        the frame again.
        
        Change-Id: Ifb4deb80c6ae245ec630a4fdc23f675e5587836c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148117
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [dacbc0fccc8faa29cb8dd0688a6ec1d496df7bdd]

        qa: simplify code
        
        Change-Id: I79328b4f26eeb01bfda0502657bf0d47f3699fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148123
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [c0ded57e60200725dfa11e8b9b3ec766145e7719]

        CppunitTest_chart2_export: re-enable and adapt test
        
        Disable since 7bb87abc0cc7b "fix upDown bar export to OOXML
        We should not really export it as this leads to wrong import into MSO."
        
        Change-Id: Ifcbb1200177b3cbd4966971c67d692c41e26827f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148128
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [74cd34d54d16cb68fbaf1e8cb9844b1048491965]

        tdf#153923: close 'dd' tag properly
        
        Change-Id: I4ae3b23c616fc2ea40a5fdf8640bf5db0bb371ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Abdallah Elhdad  <abdallah31009448@f-eng.tanta.edu.eg>  [83cd42f8e3f88e5161c5164c3494a01b2ff9f08c]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Iddda2d30dce37fd90ce8c1834666f2baf8bd7fb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148116
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa98b310d7dc4838aa45583a2dc9758442b06183]

        CppunitTest_chart2_export2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I43d896e1bd9c70198fc43185da2e1016fc7586c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148119
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Arnaud Versini  <arnaud.versini@libreoffice.org>  [4825d1f15585211a942ed711d1b372b77b718ce7]

        bridge linux x86-64 : remove useless includes
        
        Change-Id: Ibd3b9a76b700a5efbf7855454714646daf612d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147675
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [0f3a63f48cad499267f0e88f60fa42971d02fceb]

        CppunitTest_sc_subsequent_export_test2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: If59a6843dccad1e0cebbdbab05fdddbfdf778584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147468
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [d913584909c2e0a235546a5f800baf45c3446d8b]

        UnoApiXmlTest: merge parseExport from ChartTest
        
        Reuse existing mechanism to handle chart file names in tests.
        See https://lists.freedesktop.org/archives/libreoffice/2023-February/089995.html
        and 5f7861e6ce212f47420533aed302fa4b5510557d
        "fix chart export tests correctly
        we have a static counter that increments chart export file names. So
        only the first exported file gets the file name chart1.xml and all the
        following charts are incremented by one even if they are in a different
        file."
        
        Also add an assert to warn developers only 1 chart is allow per sample
        document when parsing them.
        Adapt a few tests to follow this rule and change file document
        from testMultipleChart.docx to testExternalData.docx because
        the name was misleading
        
        Change-Id: Id7282049796f2b05492ab70b50c80065a99439be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148065
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [add155dc2377a853b5281db8afb8818cb175c71a]

        tdf#72520: fix test
        
        This test should fail if oox/source/export/chartexport.cxx:970
        is commented out
        The reason is that the assert should have been
        CPPUNIT_ASSERT(xmlXPathNodeSetGetLength(pXmlNodes));
        instead.
        Anyway, simplify it and just use assertXPath
        
        Change-Id: Ie7ec10a70f7b447f92735d5c5b28d1074a9e4f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148118
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-02  Shady Mohamed  <shadimabdrawy1999@gmail.com>  [350f51569c8d8498eabcbeef4323083c8e13371e]

        tdf#114441 Convert sal_uLong to better data type sal_uInt32
        
        In this patch, all the instances of sal_uLong in sw/source/ui/fldui/
        folder are changed to better types.
        
        The variable m_nOldFormat is changed to the type sal_uInt32 in fldfunc.hxx
        as we have m_nOldFormat = GetCurField()->GetFormat() in fldfunc.cxx file
        and GetFormat() return sal_uInt32. Also, the data type of variable nFormat
        is changed from to sal_uInt32 as there is a conditional operation with the
        sal_uInt32 output. This is also the case for other changed files.
        
        The variable nFormat is changed to sal_uInt32 in files fldref.cxx and
        fldvar.cxx.
        
        Change-Id: I57ac03e48d4f0eecc96cfdbc19e92e00148f07d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147881
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d0d98238b427b98310b6d0624e21bbec6d553f8]

        flatten some classes in sc
        
        no need to allocate separately where the contained class is only one
        pointer big
        
        Change-Id: Ibd31ff94c6fae6683d2784173057290dd547954e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f5797e0c0cc0425e29b7a945485ac146fec0085]

        flatten some classes in basic
        
        no need to allocate separately where the contained class is only one
        pointer big
        
        Change-Id: If5fac0b0e20f80bffebc8611791d07888cbec1e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  mostafa-elsharnoby  <mostafaelsharnobi@gmail.com>  [5d2be45a788c450e6f914eea8c3b74d214edaccd]

        tdf#145538 Use range based for loops
        
        Change-Id: Iabbb29877c8dd2f7115b7466e9560e6296a894e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146046
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-02  Caolán McNamara  <caolanm@redhat.com>  [11a5ddbb17ddb06c12464f9e961aa9eb42cbf9f9]

        Resolves: tdf#153885 keep popovers with application window parent inside that
        
        for wayland.  If the popover window is the application window, contrain
        it within the application window so it won't be cut off off screen,
        because gtk under wayland just puts it when it wants to be regardless of
        screen bounds.
        
        Leave dialog hosted ones alone, like format, watermark, which are likely
        presented in the middle of the screen and are too small to constrain the
        popover inside.
        
        Change-Id: Ibdc0749613a3b587414e88be7d0aea81c637f31a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b47ac2b1e828afe9bbe98650bc701b940ef5920a]

        flatten some classes in sw
        
        no need to allocate separately where the contained class is only one
        pointer big
        
        Change-Id: Iae64ad45ccd9b6f2cf3f463c4c17ae7f70db6a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b7829f671e94b87b0f72f079596fcce39a06d8c1]

        Fix typo
        
        Change-Id: I8b0083203daf7ae5b6c0e769d052f29c7294584f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148114
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [8774f286e8613717c620b635c93cfd7e7dffd76f]

        no need to allocate mpPortName separately
        
        it is only one pointer big
        
        Change-Id: I7c8c99c4dad4289e2f073d73e8b3703ee5c8e64e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Justin Luth  <jluth@mail.com>  [9e365b05e7ca986f6ee4a4a58d0bb20947975864]

        tdf#131386 ApplyParagraphMarkFormatToNumbering remove RTF fallback
        
        This stops run-time evaluation of the last char-run properties
        on the paragraph - which were then applied to the numbering
        character itself. This was done to imitate MS Word's ability
        to format the CR itself - which similarly affected the numbering.
        
        This awful hack has been slowly evicted as RES_PARATR_LIST_AUTOFMT
        was created and rolled out to DOCX in 6.4, DOC in 7.5,
        and now RTF in 7.5.1.
        
        A change made in 7.2 (also made temporarily in 6.4 development)
        looked not only at the start == end char run,
        but also any run going past it/up to the end.
        
        Although the 7.2 change helped some documents, it hurt others.
        It can now be eliminated completely since RES_PARATR_LIST_AUTOFMT
        handles that situation at import time.
        
        Since this is a run-time layout adjustment, removing it should
        have no impact on export. Any effect made to MS Format -> ODT
        is likely incorrect as seen by various bug reports
        like tdf#146168 and tdf#150613.
        
        In the worst case, it would only be a few recent (7.2 - 7.5)
        DOC -> ODT or RTF -> ODT migrations that will "look different".
        Chalk those up to implementation errors that need to be corrected.
        
        Change-Id: I4ae76008ffcbc5f19580b6ddca08197b7074e12c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148014
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-02  Yomnasalama  <yomnasalama2000@gmail.com>  [badb7b6934182149c878d0917a81c0e414a9d922]

        tdf#114441: replace sal_uLong with sal_uInt8 as all of them are small constants
        
        The constants are now of type sal_uInt8 as all of them are small and
        will not exceed the limit. Also, they are not going to change after that
        in the code.
        
        Change-Id: I81d144bffe5c381f9280a4c364462e33b3a9a8b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146721
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-03-02  Miklos Vajna  <vmiklos@collabora.com>  [b9bf9bf9d1d1e0fb9eb765cd5060d611af7176df]

        sw floattable: fix vertical position of follow flys with rel orient = page
        
        The problem was that the follow frame's top was the 2nd page's top,
        because we ignore the vertical offset for follow fly frames.
        
        Ignoring the original offset is fine, but follow frames are still inside
        the body frame in Word, so their offset is effectively the header / top
        margin area.
        
        Fix the problem by improving how nRelPosY is tweaked for follow fly
        frames: an additional positive offset is wanted when the rel orient is
        page.
        
        With this, this bugdoc now renders perfectly.
        
        Change-Id: Iec4b85339a7b4b69944d25eb2e06a6e3f977f093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148086
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [bbc473ce49a3a15d2696327d5ca66f3fe85a0671]

        allocate ShapeHelper inline
        
        it is only one pointer big
        
        Change-Id: I116bd3713dab8568de56bb32c1ddbb83a1827f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b68315b5e76423e2206f3306596f8cf6e4c16a4]

        allocate DocumentInfo inline
        
        it is only one word big
        
        Change-Id: I8b5fec4f44fcdeb2c22c00db2323e7427b11d209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [4547cc9428649af54480d4471154bd44c8480f5c]

        no need to allocate TargetsTable separately
        
        Change-Id: Ifc16a5c7137776c8375d83afb031999023a7424a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [31a503a0a10aea0489ac2ebe5abd745f37e6402b]

        Fix viewsettings count
        
        Was missed in d0cacf09a1105d89bf3df84b18623d790e3aeb82
        
        Change-Id: I43c1c9b595a8fc8e2982027093695556e182074e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148081
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-03-02  Miklos Vajna  <vmiklos@collabora.com>  [34794e122fb4570376e712a7a356fc41620a46c7]

        sw floattable: don't leave body in SwFrame::GetNextFlyLeaf()
        
        - assert IsFlySplitAllowed() in SwFrame::GetNextFlyLeaf(), since the
          only caller is SwFrame::GetLeaf(), and it only checks this
        
        - extend the conditions where we reject a candidate, make sure that a
          master fly anchored in the body can't have a follow fly anchored in a
          footer
        
        - with this, the bugdoc is now of 2 pages, but still the position of the
          follow is incorrect
        
        Change-Id: Ibb02fe9cf741eecd60103179abcb44cee14e924d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148082
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-02  Stephan Bergmann  <sbergman@redhat.com>  [53ad80f72fb1067b975be5ff597f869f05ac97f6]

        Record loplugin:unreffun false positive caused by a Clang bug
        
        (see the comments at
        <https://gerrit.libreoffice.org/c/core/+/146634/7#message-5164bcbdb4efa4711f001ce05b670b592392d853>
        "test: Use css::awt::XExtentdedToolkit::addTopWindowListener()" for how this
        caused an issue in the wild)
        
        Change-Id: Id5ec77885db45d039aedc7e13d714aaa96572e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148076
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-02  Miklos Vajna  <vmiklos@collabora.com>  [0449583616bf1a73936229ec2aa333b5ecf5e882]

        sw: fix undo comment of FN_UPDATE_BOOKMARK
        
        It's an update and the name was not set. One has to dispatch
        .uno:UpdateBookmark to see this in action, which does something if the
        cursor is inside an exiting bookmark.
        
        Change-Id: Ib9c54a28c5410cc001468952cfd8577a9412d664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148073
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4029ccb6ab58d955c773e8452ce064b869b1740]

        BaseMutex->std::mutex in SlideShowListenerProxy
        
        Change-Id: Iab518e2cb994372b5d601c5cd569f07531499804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [64c19da4c924c45df037c075ef88d1f01a5abbe9]

        BaseMutex->std::mutex in AccessibleSlideSorterView
        
        Change-Id: I8aeb0d5ec44a938e58475368a3bf4ae60034042d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e16fab2b140f29f32e0628efb84d55f2c3ba693e]

        BaseMutex->std::mutex in DrawSubControllerInterfaceBase
        
        Change-Id: Iba2bee0feeea7cd176c178ae20e6dfce1fe4af19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-01  Justin Luth  <jluth@mail.com>  [46e74a8bf03c06776cb144418206db7c4b843b41]

        tdf#62032 sw: make List Level UI experimental
        
        I think the UI is working fine, but now LO is doing
        things that it never used to do, so not all interactions
        are working properly - so hide the ability for now.
        
        Specifically, when changing the list level in a style,
        it is not being applied to the existing paragraphs.
        It only applies when the style is removed and re-added.
        
        Change-Id: I092ac0e5ec7bf296d1f3b62b75d4f7209db00045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148066
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-01  Justin Luth  <jluth@mail.com>  [d6851533713850b311c5c8121d91dc96ab94286c]

        tdf#62032 sw: let paragraph UI set List Level
        
        In order for this to be at all useful,
        we need to be slightly confusing to the user
        by equating both of Outline Level's "Body Text" and "1"
        with List Level 1.
        
        So, while outline levels can be "turned off" with "Body Text",
        a user cannot "turn off" a list level,
        even though the listbox has the choice "same as outline level".
        
        The way to turn off the list is to pick "No List"
        in the other list box.
        
        That situation (Outline = Body Text, ListLevel = 1)
        is the default situation, and so if we don't make that
        connection, then the whole intention of STRONGLY
        advocating for keeping the two values in sync will be lost.
        
        Note that both selecting "No list" or changing list level
        in a style does not have immediate effect. It only applies
        when the style is assigned, not modified.
        (I assume this is because of internal auto-styles
        which are not being updated when the underlying style changes?)
        [Because of this "strangeness" a follow-up commit
         will make this an experimental feature.]
        
        Change-Id: Ib6a47b3265ccf71f45a43ce6f10b780b995c231d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148027
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [a42a80bd9658577a16ca3ac4ee7ba1f9b62ae5d1]

        CppunitTest_sw_rtfexport5: split in two
        
        it already has 121 tests
        
        Change-Id: I7d7726b9f1c65d3f719517ab1a568cd888b2833b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148042
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Caolán McNamara  <caolanm@redhat.com>  [2e2578732588d3f4b9dd10fef91ff3087836f11d]

        cid#1521560 Division or modulo by float zero
        
        and
        
        cid#1521558 Division or modulo by float zero
        
        Change-Id: I42a82f294950ea22a2557f76d4589b06b50d9d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148071
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-01  Caolán McNamara  <caolanm@redhat.com>  [9a0710bb05b6b9bc0873dbc2d2dc5eb40ce02eba]

        tdf#153784 account for initial vertical offset when toggled into multiline
        
        Initially there is 1 line and the edit is vertically centered in the
        toolbar
        
        Later, if expanded then the vertical position of the edit will remain at
        that initial position, so when calculating the overall size of the
        expanded toolbar we have to include that initial offset in order to not
        make the edit overlap the RESIZE_HOTSPOT_HEIGHT area so that dragging to
        resize is still possible.
        
        Change-Id: Ic99e1cf4f3b1ca53c5d6feaa50d8bfac030f8124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148069
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-01  Caolán McNamara  <caolanm@redhat.com>  [1ec54b38f1fad81d8e456c6c7d2e4a1d665f25b9]

        assert that Mutex exists at ctor time
        
        and drop the never can be hit throw
        
        Change-Id: I74c92f1ff50ef0f3f6f78a53057f121a3665ec3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-01  Caolán McNamara  <caolanm@redhat.com>  [f6633ad610173d6e22a29124d1903f9e5032ea29]

        cid#1521559 pass arg as ref to prove no Dereference before null check
        
        and
        
        cid#1521561 Dereference before null check
        
        and drop pointless null check
        
        Change-Id: I2e99733eb5f1861bb02f6d8ec7a44ace4ded16cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-01  Heiko Tietze  <tietze.heiko@gmail.com>  [3e8862b98cbeac6b23a8fd08ead3386f91a4529f]

        Related tdf#153344 - Resize Save icon in statusbar to 18px
        
        Also removed the "_14" from the yes/no icons
        
        Change-Id: Ic43219fe0e4555416b78831d45f9edc8060f73cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148063
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-03-01  Michael Stahl  <michael.stahl@allotropia.de>  [21bb933f381321a58bffee8d3d392dee0e8b0c87]

        ofz#56382 sw: HTML import: init items with WhichId
        
        (regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
        
        Change-Id: Ib4865ad1423f0dafb20b376a9d00eaf450b8f271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148049
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-03-01  Stephan Bergmann  <sbergman@redhat.com>  [96537cd4654df65bcde3f2ccde053800210a9d33]

        Teach INetURLObject about RFC 7230 URLs with no path but query
        
        While RFC 2616 "Hypertext Transfer Protocol -- HTTP/1.1" defined
        
        > http_URL = "http:" "//" host [ ":" port ] [ abs_path [ "?" query ]]
        
        RFC 7230 "Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing"
        defines
        
        > http-URI = "http:" "//" authority path-abempty [ "?" query ]
        >            [ "#" fragment ]
        
        Change-Id: I83b1baa404d28bf3b28b1db812f8930bbc1aaf90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148064
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fe04156def447076e56a78fe1722c64ca7fcda4f]

        Remove duplicated include
        
        Change-Id: I267f3655dcc41613db9de4952beceb34dffefbac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148061
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [3fa61383b51180c17154a9d5762c22b7d436df65]

        tdf#153669: sc_uicalc: Add unittest
        
        Change-Id: I2bf478ea4f0d1a35def2455ec1e6480170c9f1ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148047
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Stephan Bergmann  <sbergman@redhat.com>  [6a4015b636f99adb58ad91e0caa3add0ef73a936]

        Re-enable Skia in Flatpak builds
        
        ...as requested at
        <https://github.com/flathub/org.libreoffice.LibreOffice/issues/213> "Can Skia be
        reenabled in the Flatpak build?" and implemented on Flathub for now with
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/372d036e9113b6080780669ad44fc11a172356ed>
        "Re-enable Skia".  (This partially reverts
        9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4 "Flatpak: Upgrade to 21.08 runtime,
        disable Skia".)
        
        Change-Id: I50039d431fd3e6ba4c0d859d71e42e744433806b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148054
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [bccd3f299f3e29578d1a0f041aeeba3bf28f778f]

        sc: move import tests where they belong
        
        and remove CppunitTest_sc_bugfix_test, which is no longer needed
        
        Change-Id: Idb1cff6580c621e325ce0b836695190d25467a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148035
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [00a602ca8e75ab5cf050e092289ef7165b343165]

        tdf#153869 qt: Unminimize window when requested
        
        Remove the `Qt::WindowMinimized` state from the widget's
        window states if the `SalFrameToTop::RestoreWhenMin`
        flag is set to request restoring the minimized window.
        
        Change-Id: I0cb67f28c1e9c3f48a9a234702a4aaa7e3ffec8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148036
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [4def1399b17792e14882152c58b7f1f8d46aedfd]

        allocate cached values inline in VDataSeries
        
        to reduce pointer chasing - these values are all small
        
        Change-Id: I96782494f26666657bf35c06136b4b87f29fdd2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148039
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ca077ee7156123ec38a6cfdde7168749589d0ff]

        no need to allocate Gradient separately
        
        it is only one pointer big
        
        Change-Id: I21afdeb8015c658c7b9d5db24bceeb8e43694272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6e8c67580974484c790f52991de26298ce8e7e1c]

        oox: import directly into docmodel's Theme and ColorSet
        
        This changes the import to directly fill values of a model::Theme
        and model::ColorSet, without filling the oox structs first. The
        goal is to get rid of the oox in the long run, but for now it is
        necessary to keep reading into both, which is a duplication.
        
        The next step is to also fill the FontScheme and FormatScheme
        structures.
        
        Change-Id: I488ec096cbc184bc70d24510ac9091a488540422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147571
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [855f7c08d1feab7669670bfbc4ed2b3b3225db16]

        send theme info when changing color (in the picker) via UNO command
        
        Change-Id: I288f8fb3375e152b5ee746fab2c05d08150d6c99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146817
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [79434c321597790de6cb8db18f4b9fb6dc8c60bb]

        CppunitTest_sc_subsequent_filters_test: split in two
        
        it already has 109 tests
        
        Change-Id: I2261fbf036862c8005db5a8bc15a1fd55a819319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f5a352f560d2cd2cdb4f23456ca2be0f728ee8ad]

        Fix typo
        
        Change-Id: I6bc3777231bada3a1abf2a1e57645d9ceb93acb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148048
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb1d1aa2fee82004c18682fd3b24246491f0cb13]

        no need to allocate ucbhelper::Content separately in SmartContent
        
        it is only one pointer big
        
        Change-Id: Ic7653a59ceebcc4cd7911fabdfc49537c244f960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148037
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b466c1ad267e821dbda0a879ab31a2ea00e54b5c]

        tdf#109214 - Highlight the favorites in the grid of special characters
        
        Remove visual artifacts around the corners by using horizontal and
        vertical round.
        
        Change-Id: I9821103c43dfbd93e6f295034b05da8b74e802e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148040
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-03-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7aea297d371de4f8384f819e570bd3280a50b7bf]

        fontconfig: upgrade to release 2.14.2
        
        Change-Id: I5347580318c752517c9ef7a37d4175a2c6db36bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145134
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-03-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [ed6eeb2496a1989856de312152b64401bb600300]

        curl: upgrade to release 7.88.1
        
        Fixes CVE-2023-23916, 2 CVEs that probably don't affect LO.
        
        Reference: https://curl.se/docs/security.html
        
        Change-Id: If9b3fc7c5ce66bfe1027caff39ea2c1cf55df7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147673
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [1a980e7ac8c70b7c057c930c46689460202bc45f]

        postgresql: upgrade to release 13.10
        
        Fixes CVE-2022-41862
        
        Reference: https://www.postgresql.org/support/security/CVE-2022-41862/
        
        Change-Id: I6075838972fec1c091f3150b19c5da4dc80ad6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147674
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-03-01  Juergen Funk  <juergen.funk_ml@cib.de>  [9afc6b22e225e8a6ec50c1cbb4d966585d15dbfd]

        git-hooks: overwrite the windows-links not with linux-links
        
        Always when you call build or logerrit, then the windows-links
        overwrite with linux-links, but when you using GIT for Windows
        you need the windows-links.
        This patch made a check it is using GIT for Windows, and check what
        for link it is, when wrong link, it output the .git-hooks/README
        
        Improve the check for links, when a link is set not need to set
        the link anymore
        
        In .git-hooks/README improve the FOR with delete of the wrong link
        
        look here for GIT for Windows:
        https://wiki.documentfoundation.org/Development/BuildingOnWindows/de#Cygwin_and_git
        
        Change-Id: I9f6ef9aca316058ef74cb2b2d107236f03a2e2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147458
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-03-01  Miklos Vajna  <vmiklos@collabora.com>  [e32dfaf15563372ffae6e0da53998e20068ebf81]

        sw floattable: teach the UI about SwFormatFlySplit
        
        - in SwFramePage, add a new m_xFlySplitCB and bind it to the flysplit
          from the UI description
        
        - map RES_FLY_SPLIT from the doc model to this new weld::CheckButton
        
        - disable the widget for anchor types other than to-para, also
          completely hide it, unless a frame contains a single table, which
          simplifies Word filters
        
        - add UITest for this
        
        Change-Id: I9ef44b5c66679b04c4818dc343870b92f1b6386d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148030
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7c132fd14f7955e2bfbb600b78e939b9eae6a870]

        MCGR: support ColorSteps in emf export
        
        Change-Id: I7a784587dd86efee0934fdead26f615ba7f396e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147960
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa189d601146ce8c44127e98e87935c90cec98cb]

        merge SfxDocTplService and SfxDocTplService_Impl
        
        no need for the pimpl pattern here
        
        Change-Id: I8b18df1dc4769bc6f3cc49c1d59910a0cd61d471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-03-01  Tor Lillqvist  <tml@collabora.com>  [91afabee6bece4cbf61a8f32a6e6a69becd857ae]

        Improve the LibreOfficeKit Document::paintThumbnail() API
        
        No implementation yet.
        
        Change-Id: Ie1dc955bc8b589bd336af0545a2270cbe84a8b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148028
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-03-01  Miklos Vajna  <vmiklos@collabora.com>  [25a01778f998618d9a4d0de9da5784e0e60e3259]

        sw floattable: update layout when enabling fly split via UNO
        
        Changing e.g. the HoriOrientPosition property resulted in a layout
        update, but setting IsSplitAllowed to true had no effect on the layout.
        
        The problem seems to be that the new RES_FLY_SPLIT is not handled in any
        update notification.
        
        Fix the problem by initially handling this the same way as RES_FRM_SIZE
        is already done, that triggers a 2nd page when a large fly frame is
        newly allowed to split, for existing fly frames as well.
        
        Disabling needs more work, still.
        
        Change-Id: I2cba04213286e72384a56a28f2b321f7fd577639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148029
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e7bc46cb9512bae40e30fd4e51cd531c27b0bb79]

        sc: move export tests where they belong
        
        Change-Id: If2bc32cabcb0d1272b871e8b2676a8c2de05fc00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148015
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [36cd611e6ff709b3e3645b67ea67ee26cf3d92fc]

        CppunitTest_sc_subsequent_export_test: split in two
        
        it already has 101 tests
        
        Change-Id: I2fb88e41313049fec649e3592d811a36e10440fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148013
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-03-01  Miklos Vajna  <vmiklos@collabora.com>  [5f19b56886db4a99155336f4c467e6ff75339c34]

        CppunitTest_sw_htmlexport: avoid EmbedImages magic in testEmbedImagesEnabled
        
        Set the filter option explicitly, rather than inferring it from the test
        name.
        
        Change-Id: I4af0edce4316b7717512db70e8ad970126e2b3e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148018
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f474418bc195f34fd3729406ebaf94234afd4260]

        Fix typo
        
        Change-Id: I46f400646bc7d2b7456d294290dc2e159ba14874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147966
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8efe70aa2799622c12e27dbff70c7f12fe4b3e7]

        Fix typo
        
        Change-Id: I53e2a2f57ca1f00a07c62918e6e34c57a53fdcf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148022
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f0ad08ab845d87f04f7b6c0b48e872252810435f]

        Fix typo
        
        Change-Id: I7a1302f472473171b31a4c2b21c9bfbfe1517904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148020
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [78670b9dcb64e515712c6b1d411ad30478f9abb4]

        Fix typo
        
        Change-Id: Ib620227c38d27d3de1a774f9c3aebfbcc5edd0a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148021
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-03-01  Eike Rathke  <erack@redhat.com>  [86942a85b32efeb0b7fee25f00991e69f4446ddc]

        Related: tdf#153842 {dsb-DE} group separator is '.' dot instead of NBSP
        
        See also
        https://icu4c-demos.unicode.org/icu-bin/locexp?d_=en&_=dsb_DE
        
        Change-Id: I1f6797829812893aaab711ab670a722673a86a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148025
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-03-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4a7a89b97b0b6464f8375926d98044634d06b4ee]

        create a default theme when SdrPage and SdrModel are created
        
        For a document it is expected that it always has a theme available
        so we need to create a theme with some default attributes set (a
        default color scheme for now) when we create a SdrModel and SdrPage
        (only for Writer currently).
        
        This also changes some ColorSets, SdrPage, SdrModel methods, to use
        better return types (cost& instead of raw pointers and vice versa
        depending on the use case).
        
        Change-Id: I874247784b845109e42567e3f45647dda46ccf3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146816
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-28  Eike Rathke  <erack@redhat.com>  [1309e6332d7ff2bd1f9b6bf87385b8b570e59158]

        Resolves: tdf#153842 {hsb-DE} currency symbol follows amount with blank
        
        Change-Id: Id8a86541d1f8299763274e048f36af95eee03d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148023
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7ff3759d039b45fbbf3c117edebf577a273504bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3af327e7465f97c6c9fe0c91253ea64fec6f4153
          - tdf#151063  "index mark" -> "index entry"
            
            Change-Id: I967a2c309ca956e8e75e1a9510574310f4e2a35b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147907
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c6c26611093c3861d8a5e9a794fd67503d49a9a2]

        tdf#151063   "Index marks" -> "Index entries"
        
            add tooltip for this label, and revise extended tip
        
        Change-Id: Ibff5bac33193df749d7a4117a205f58c0592aefb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147852
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fd58af1a2d6fdf14ae4be2190114e73d8daaabc2]

        tdf#153589 expand combobox for main entry character style
        
        Change-Id: Ic1cd023d23be3fdc97b604da0ed51a4f93b2b4c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147849
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [78eeb30220b478a5040c60d2c8eee8b1f3d1c7dd]

        CppunitTest_sc_subsequent_filters_test2: split into two
        
        it already has 115 tests
        
        Change-Id: I043d000b8782bae66bdd958c0273f8c5ea622a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148009
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e930c607cb9d0ba73912896d375f795df6c8c196]

        CppunitTest_sc_bugfix_test: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I842b45e14e1d05de8d8bfd7c1e2baa6da6e1c6f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147996
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [8f599983b8ed04c9e0ee73da65e70168be8ca443]

        CppunitTest_sc_bugfix_test: remove commented out test
        
        This was added in d15f4fc67dfcae492c7acfbe815f5d9ba10ae4d4
        "add disabled test code for tdf#40110" already commented out
        if the test is enabled, it will fail because fdo40110test.ods
        and fdo40110test.csv were not included in the commit
        
        Change-Id: I11e7860bdfa710a78da1a04f72e9eea5bc00d037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147967
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Stephan Bergmann  <sbergman@redhat.com>  [a7affc26f3ee2c1449c41d88a0b18fd640577b39]

        Remove compilerplugins/clang/test/cppunitassertequals.hxx
        
        ...which isn't needed anymore to suppress warnings from other plugins like
        loplugin:external ever since 45c06838e95c94445359536d84c6328fa8b17a66 "only
        unit-test one loplugin at a time".  Also, the declaration of the function test
        in cppunitassertequals.hxx had already started to deviate from its definition in
        cppunitassertequals.cxx.
        
        Change-Id: I3fbc8a9a805bd5bc4d8afbf958edff04b89add3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148010
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-28  Michael Stahl  <michael.stahl@allotropia.de>  [d4355f14d1483a57fa08579b143a762f0aad4631]

        tdf#143311 writerfilter: import decorative flag on as-char flys too
        
        Change-Id: I9704d35a8286b92169dffd8de7e57e286884f607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148016
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [b7a5ac03e03066d36e05da786669a9243ad0116f]

        tdf#114773: only add space between entry number and text
        
        Modify the hack from commit ce95e39f8e952159844e9dc04a1df402bb103634
        (tdf#44282 fix missing space for numbered lists in TOC, 2016-08-16),
        which added the space after entry numbers unconditionally.
        
        There are other possibilities, like custom separators between the entry
        number and text (e.g., [E#][T][E][T][#]); or the entry number (maybe
        with limited depth) used with page number (like in [E#][E][T][E#]-[#]).
        Generally, when entry number is not immediately followed by entry text,
        the space is not needed.
        
        Additionally, the space is not needed when the number text already ends
        with a space character.
        
        Change-Id: Ifa6c474574bfb74466ab721eca49f421a3750942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147997
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [261ea82f11b10a8d1ab8175f66e72077a7b3350d]

        no need to allocate XMLTextColumnsArray_Impl separately
        
        an empty vector is only 2 words big
        
        Change-Id: I3e4a9d42b9ecb44c57ce11c400a17a4c8b053eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d01769af5f79988ae4263586b623df501b37ed26]

        no need to allocate tabstops vector separately
        
        an empty vector is only 2 words big
        
        Change-Id: Ib8309d0819c88fe6a4f7cd322c37dd52190bd060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Patrick Luby  <patrick.luby@collabora.com>  [68f33bcc41cd3895e91578e9e2990a919748cc2b]

        Fix iOS build breakage
        
        There were a few remaining DeviceFormat::DEFAULTS in remaining in
        IOS blocks after commit  00659bcdbbb167596e6fd18e283a54819dd6fe91
        
        Change-Id: I29e1f2bd6d4ce20dea7a45ce17bc6f3b929859c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148008
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-02-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a344f152873e3b2f33411c391c3f57f604ae8bfa]

        add ipv6 enabled maven repository
        
        maven central so far doesn't support ipv6 on the primary URL (see
        https://issues.sonatype.org/browse/MVNCENTRAL-658 ), it is only enabled
        on a dedicated ipv6.repo1.maven.org URL currently.
        Add that one to the list of repositories so that ipv6-only hosts can also
        fetch the dependencies.
        (when using internal ipv4 as well, you'll also need to export
        JAVA_OPTS="-Djava.net.preferIPv6Addresses=true"
        since otherwise the gradle wrapper fails to download gradle)
        
        Change-Id: I22f0e07fd4e6bb518396f76db20c174e45588372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147917
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-02-28  Michael Stahl  <michael.stahl@allotropia.de>  [811dfd7f2706f56119a1943e08d9bce73b0d2203]

        sw: RTF export: fix assert on fdo37077-1.rtf
        
        soffice.bin: /home/ms/lo/master/svl/source/items/itempool.cxx:822: const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const: Assertion `!"unknown which - don't ask me for defaults"' failed.
        
        Because editeng doesnt have RES_MARGIN_TEXTLEFT yet and it's mapped to a
        slot id so the dialog works...
        
        Looks like this TABS_RELATIVE_TO_INDENT doesn't exist in editeng anyway.
        
        (regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
        
        Change-Id: I64169a4d6f4663adaa2a17786836c2dcc7e1f394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148006
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [ba92c78296b0b157a06074b19627d1a1c681f14b]

        Fix typo in XComponent doc: "there" -> "their"
        
        Change-Id: I1e7be83bffc17d6887ecb9ac43afe82aae6d661e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147973
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ed206ccb9e24bd4bf0040c42d26f73363baf3d20]

        Fix typo
        
        Change-Id: I1c66185917844bb9b5ee2478a8bae90bb292408d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148007
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-28  Czeber László Ádám  <czeber.laszloadam@nisz.hu>  [6ddffa9841a20b7fddd3f742c88dba7d51cf9114]

        tdf#153681 RTF export: fix extra cell regression at nested tables
        
        Table rows exported with an extra empty cell, if there was a
        nested table in them (and not in the last cell).
        
        Partial revert of commit 1f77a5e8d5bf8a7f1b7bd7206996d2b2efc59462
        "n#203704 fix RTF export table output for subtables".
        
        Note: the partially reverted code was for the old table format
        (used before OOo 2.3). This old format is partially converted to the
        new table format since commit e366c928819c44b5c253c45dca6dae40b71c9808
        "sw: ODF import: convert the simplest sub-tables to rowspan tables".
        
        Change-Id: I63ebefbb99e1a95cd60ce8d8dc34c307573d4b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147887
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-02-28  niket1322git  <niket78766@gmail.com>  [a38fbfbf2f2d63d01444f0a0382b72de3e0af578]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I0f531280f4d85de3eae6de36bfba975e96d8e7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147661
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [c026b936404bd052fc74283d3cc2e0727ec4edb9]

        no need to allocate SfxDdeDocTopics_Impl separately
        
        it is just a vector, only 2 words big
        
        Change-Id: I88ca1befea1fc3dba05f7628e4319aedb3250751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7182c36be4b606a02cddeacb44c1b63387bd368]

        no need for pimpl in TableName
        
        Change-Id: I23ec068c5e4297a3e7451ccaa2e43ae5572f9050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Caolán McNamara  <caolanm@redhat.com>  [8a180b663323be2cd36a17562d7052d9549ae89e]

        upgrade to libjpeg-turbo 2.1.5
        
        Change-Id: Ia6355beaf19765e6255f9388d60e2179206ddc5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147951
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-28  Stephan Bergmann  <sbergman@redhat.com>  [cc460f5b8f67470d1c3b2fc069466191a0773d2a]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/0b06d2638bf0a1f1707229e7b15e73fbe4c96537>
        "Update gvfs to the current master"
        
        Change-Id: I23cbf8aec7771eda59f66733bcde6cdbed3d0ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147994
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-28  Michael Stahl  <michael.stahl@allotropia.de>  [043c349f144b615836091707147e57616a1261e7]

        tdf#153874 writerfilter: fix anchoring of decorative shapes
        
        Turns out as-char flys can be decorative too.
        
        The confusing GraphicImport takes a GraphicImportType by value but
        everything else is a reference to a DomainMapper_Impl member.
        
        The latter appears to work better so handle GraphicImportType the same
        way and remove the function parameter.
        
        (regression from commit 31084ebb59093be7dfe5ab53a20fdb3bcfde34b6)
        
        Change-Id: I18c1d47d39751e8ddcaa52498077d89c43a934e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147998
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-28  Michael Stahl  <michael.stahl@allotropia.de>  [ade0a153f453500f15343380ac937252992733e0]

        tdf#114287 xmloff: ODF import: fix text:list override of list style
        
        The problem is that the list element applies a list style, which should
        override the list style that's set in the common style
        "myStyleWithNumbering" of the paragraph, but these happend to be the
        same list styles and so the override was skipped, resulting in bad text
        formatting.
        
        <text:list xml:id="list3425910577850" text:continue-numbering="true" text:style-name="Numbering_20_123">
        
        The same problem exists if the list-item element has a style-override.
        
        This is similar to bug i#101349 which fixed it for an automatic
        paragraph style applying the same list style as its parent style.
        
        Change-Id: Idc6f10f93976de7e7bdceccbe3012c4157f61ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147930
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-28  Jean-Pierre Ledure  <jp@ledure.be>  [f36265ed0e0229dc9dacd18cc16867b22d655dbe]

        ScriptForge (SFWidgets) new Toolbar and ToolbarButton services
        
        Each component has its own set of toolbars, depending
        on the component type (Calc, Writer, Basic IDE, ...).
        In the context of the actual class, a toolbar
        is presumed defined statically:
          - either by the application
          - or by a customization done by the user.
        The definition of a toolbar can be stored
        in the application configuration files
        or in the current document.
        
        Changes made by scripts to toolbars stored
        in the application are persistent. They are valid
        for all documents of the same type.
        
        Note that the menubar and the statusbar
        are not considered toolbars in this context.
        
        A toolbar consists in a series of graphical
        controls to trigger actions.
          The "Toolbar" service gives access to the "ToolbarButton" service to manage
          the individual buttons belonging to the toolbar.
        
        The "Toolbar" service is triggered from next
        services: Document, Calc, Writer, Base, FormDocument
        and Datasheet. All those components might host toolbars.
        
        Proposed properties in the Toolbar service:
          BuiltIn
          Docked
          HasGlobalScope
          Name
          ResourceURL
          Visible (r/w)
          XUIElement
        Proposed method:
          ToolbarButtons()
        
        Proposed properties in the ToolbarButton service:
          Caption
          Height
          Index
          OnClick (r/w)
          Parent
          TipText (r/w)
          Visible (r/w)
          X
          Y
        (The Height, Width, X, Y properties allow for
        easy hook of a popup menu to tye button)
        Proposed method:
          Execute()
        
        Both services are available both from Basic and Python user scripts.
        An update of the dcumentation help is required.
        
        Change-Id: I43cb523b52e3d6362994557d74c4ef9faa220507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147925
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-02-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f633d07a0b6993c8c13e63fa9d5259f0161cd6b2]

        tdf#153848 Update Sukapura icons in Start Center to match new branding
        
        Change-Id: I6be2739b551f1dd26265a26d4476658e5a85b3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147965
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-02-28  Justin Luth  <jluth@mail.com>  [27df5ef405826875340645b9b979bd5c2c0b92cc]

        tdf#146168 tdf#150613 list attributes: limit hack to RTF
        
        This fixes an ODT regression from LO 7.2's
        commit 0a32371cc2f93fad7954e0fe9c48976aae6c5b9f.
        
        The hack applies the last character formatting in the paragraph
        to the numbering characters. This was a hack that existed for
        DOC and DOCX and RTF in various troublesome modes for quite a while.
        However, recently since 6.4ish era there have been some
        improvements for DOC and DOCX, so these have been excluded and
        now only RTF remains.
        
        Most of the time an RTF file also looks like a DOC
        (from a compat settings point of view),
        so even RTF files usually don't have this clause apply.
        In fact, I looked for the RTF files that this hack still applies to,
        but couldn't find a single example. Really? Did something change?
        
        I also looked for examples of files I will be excluding (!isOnlyRTF)
        and only found tdf135973.odt and tdf146955.odt. Neither one has
        character formatting on their numbered lists, so they can't
        be used effectively for a unit test.
        
        It is somewhat pointless to make a test. I don't even think we
        can round-trip an RTF that has these characteristics.
        Likely the best thing is to just drop the hack altogether,
        especially since it would pass the unit tests now.
        (I'm sure it was failing before.)
        
        If we can't round-trip it, is there any point in having this
        non-import hack in place?
        
        Change-Id: I2f95c10e1d0a9dc53b01027e9c97e5ded29c6750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147939
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [bbe8dd159213db374a6d5ca03d9040d479bbe36e]

        CppunitTest_chart2_export3: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I8f0017eccadf2ca5ea57ea3c1f8bea357b0c05f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147961
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ee7245960837b6376b49f7c33eef966770022f4]

        CppunitTest_sw_uiwriter*: use uno commands for copy/cut/paste
        
        In order to unify the code and to make sure
        Scheduler::ProcessEventsToIdle() is always called afterwards
        See 9027920783dd04db925c41b559abe6442cedf39e
        "improve reliability of CppunitTest_sw_uiwriter3
        something in the paste stuff seems to need UI events to be
        processed"
        
        Initially, these uno commands were replaced in
        9d08a0cea018226ce155104d8df146dc2a412aac
        "avoid uno:Paste in tests
        clipboard is a shared resource (except for svp) so interleaved
        tests are not guaranteed to get out what they put in"
        
        However, this is no longer a problem since
        e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3
        "use a dummy clipboard when running unit tests
        so the multiple unit tests don't stomp on each other.
        
        This fixes a couple of things in my earlier attempt
        (*) actually set the env variable on Windows
        (*) don't use a global variable to test the env var, because that
        variable might be initialised BEFORE the env var is actually set"
        
        Change-Id: Ifae66e522b0a1e57fa1fa6d16980c6491b397f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147957
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7996c451d001613e1b1511ca7a0b23e79a94581]

        BaseMutex->std::mutex in oglcanvas::TextLayout
        
        Change-Id: I76b95eb8444c057d94f5653769e23047c019b139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147964
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [b7c509570857e1d1e8b8d722abd95a1ed5598145]

        CppunitTest_chart2_export: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I29efb96151d06fe19ec50a8c6cd363ae052d421f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147962
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [08a7f95d68343e260e9b5faace55c0d4caaba5b4]

        no need to allocate SvgUnits separately
        
        it is only one pointer big
        
        Change-Id: Iad5444ed6783abc2916510fd83c5b5a11d17e8f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147950
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e0db1771a10f694857bedc0f1750532e4f41e7c]

        flatten OWriteStream
        
        no need to use pimpl pattern here
        
        Change-Id: Iebc412aaad83c2f1fc149cc320729ce25030cbc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [69794d012fa640d60fd808e1d576cb919129ade4]

        no need to allocate OTypeCollection separately in OStorage
        
        it is only one pointer big
        
        Change-Id: I4af56814be106026515aee6c09caa14e0f3eb09a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [efc5cbdad54fc2aa968af572dd5f135123217f8f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfd3deea6691715db33c13bdc639bac22dbf88f3
          - Fix broken links in help
            
            Change-Id: I77413b0a66d7851d7c79e5f83ed72dd5f42f1c00
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147975
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [822cc9e941bf4fcf99ad1214096deea5d0997802]

        flatten basctl::docs::DocumentEnumeration
        
        no need to use pimpl pattern here
        
        Change-Id: I289f545ff237b9770f3a193460a943e91b86fadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147955
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Sarper Akdemir  <sarper.akdemir@collabora.com>  [0bb169dcfa14e6db44bc0eaeabe12d0d3b62ffd8]

        tdf#148966: pptx: workaround for multiline fields followed by linebreaks
        
        In Impress after fields that span multiple lines, a
        linebreak is already forced. (PowerPoint doesn't have such
        behaviour)
        
        Therefore if the imported pptx file has a line break after
        the multiline field - Impress ends up displaying an extra
        line break.
        
        This patch implements ignoring of a linebreak that follows
        after a multiline field during paint (when not in EditMode),
        using a compatibility flag. (IgnoreBreakAfterMultilineField)
        
        Change-Id: I1e6772424cc0eead06b53d104b06820038a81ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147408
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-28  Tibor Nagy  <nagy.tibor2@nisz.hu>  [11451781d4c562f506a3aae3732e35b92387b4db]

        tdf#153105 PPTX export: fix "Custom position/size" background image
        
        Map size and the 9 preset positions of the ODF background image
        style "Custom position/size" to the OOXML a:stretch/a:fillRect
        with the appropriate left/top/right/bottom arguments.
        
        Note: it seems, applying a:stretch or a:tile was not mandatory,
        but missing a:stretch resulted non-editable document in Office 365.
        
        Note: the import of the PPTX mapping hasn't been implemented, yet.
        
        Follow-up to commit e8335bac5690b6beccb5ca9b36281c89fb2f28f5
        "tdf#153107 OOXML export: fix scale of tile of shape background".
        
        Change-Id: Ie940ebc2610c5b75126da05678a04ed1552cacb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147337
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [01867b3625562ad291e3fe05be5c8a4a270a3d3f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7498da277dcf8545fd2a96720ca56921589c3041
          - Remove duplicate reference to wiki pages
            
            Change-Id: I645d4c5195e28ef54535bd70bb65277397fb5b77
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147963
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-28  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [ed989d6b79ae2d6dbd9d4b17567497d228259a58]

        Drop 'using namespace ::std' in Windows-specific files
        
        Change-Id: Id66d42f2139fbcac0fed56fe534107f65d198f02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147877
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-02-28  Damjan Jovanovic  <damjan@apache.org>  [f4d147ef956de834a7402bea88a1aec296c38ef7]

        InputStreamToXInputStreamAdapter.readBytes() should read...
        
        until the buffer is full, or the file ends. It shouldn't care about
        available().
        
        (cherry-picked from f04910427d25ede98b84b90df7cc5a12d1adc695)
        
        Change-Id: I4ad17c614ba336ff21883248715861f6af1fbc2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147934
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-02-28  Caolán McNamara  <caolanm@redhat.com>  [4f743219e85e61f622a8dadc028c144010eecd4d]

        cid#1521506 silence Thread deadlock
        
        and
        
        cid#1521510 Thread deadlock
        
        annotation is getting a bit spamy
        
        Change-Id: I3120562c0f7ca996f53d14965efe7af506be6d19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [173ba4dedd16785506a635949fe6aef3424a3b64]

        Sukapura: Add initial preparation for dark mode support
        
        Change-Id: Ida7c68864c0ecb3bbd00cb6b87e4657b29447ec0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147870
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0e310bd80317ac5c63f90976e26d8ee1118c752]

        no need to allocate OTypeCollection separately in WSInternalData_Impl
        
        it is only one pointer big
        
        Change-Id: I291b1c0aaba2f46aebabefa0341a9e24cf20eeff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [94b18584e1332bc4bb529fc3a7d13ab5ce15f8fb]

        no need to allocate Date separately in ImpSvNumberInputScan
        
        it is only one pointer big
        
        Change-Id: I8b0b7ea0cf69cecabc2ddfb7e5d134037221057c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6ae28fe07497d217a53ee9062ddbf82766121a7]

        no need to allocate ucbhelper::Content separately in UCBStorage_Impl
        
        it is only one pointer big
        
        Change-Id: Id60710eca9a170733ebba4120359e03f384f9962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0b71f167cd4c03d574decb7b78ed1ecdab1c424]

        flatten some vba classes
        
        no need to allocate ShapeHelper separately, it is only one pointer big
        
        Change-Id: Ie4981ca81ac1dd430f22ba32357fcabbbd47bd09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147944
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [44e1f09f7e658b87c3e2eda9e4929cdf6967d2f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9ce008461498f499ea8d524bfa7faf66ee194f14
          - tdf#153747 correction about what tips are shown in a document
            
               also, refactor to <h1>,<h2>,<tip>
            
            Change-Id: I6698ebc60ff40046267db7ffcbaa6ad8cb77e713
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147911
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-28  Damjan Jovanovic  <damjan@apache.org>  [618e8e30a21efea41b9a4e63219de20e38987f4a]

        Fix the java.lang.NullPointerException in readBytes() and readSomeBytes()...
        
        methods in InputStreamToXInputStreamAdapter when called from the inter-process UNO bridge.
        
        XInputStream::readBytes() documents how the buffer is an "out" parameter, and isn't passed
        to the implementing end, which is why we get the buffer as a "byte[][] b" and b[0] == null.
        Its role is to box a byte[] array to be returned the client. Thus, allocate the buffer if
        it is missing or too small.
        
        Additionally, virtually all other readBytes() and readSomeBytes() implementations trim this
        sequence to the actual number of bytes read. This presumably reduces the inter-process
        traffic, but some callers even rely on the sequence to be trimmed, eg.
        main/sax/source/expatwrap/xml2utf.cxx. Thus trim our returned array too.
        
        (cherry-picked from 6cb06142790376a2c58e6392182eb071420a4221)
        
        Change-Id: I42eb209b68f7c13a34670d03c2ca61d76672385b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147933
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-02-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4e6ab75c1a907398d24768d19cf097a4892d374c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d94ca17c8d62af3286d84ceb8166cad1f8cd8446
          - Fix "D'oh! you found a bug" in Help page
            
            Change-Id: I15d47f59bb75d6c4f31450d227b78d88a8b9b384
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147956
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-28  Caolán McNamara  <caolanm@redhat.com>  [c6052ce76a25408e2a8b6221d9cc0098365dc22d]

        fix up misleading mismatching indent and add mode lines
        
        Change-Id: Id0abfc6d2962223bd0f7f0864a53e94bb7ec5052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-28  Stephan Bergmann  <sbergman@redhat.com>  [569977cfe1c3be4f66665306372d0253924ba6c0]

        Extend loplugin:cppunitassertequals to CPPUNIT_ASSERT_LESS etc.
        
        (Just in case, even though this doesn't find any actual issues in the code for
        now.)
        
        Change-Id: I80b8b0a647e89fdb6a4f0f4363fa1c3df8e5ddeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147942
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-28  Miklos Vajna  <vmiklos@collabora.com>  [f13eb476ea6620bc444d9533959fea78afe720c5]

        sw floattable: fix fly pos invalidation in follow anchor frames
        
        The problem was that in case a row split moved the 2nd half of the row
        to a new page, the follow fly frame had a wrong position (top left
        corner of the page).
        
        What happened was that the follow anchor (text frame) was not yet
        positioned by the time the follow fly was positioned, and there was no
        invalidation once the follow anchor got its position.
        
        Fix the problem by improving SwTextFrame::MakePos(): it already had code
        to invalidate the position of follow flys when the position of the
        anchor changes, but it assumed that the flys of a follow anchor are in
        the follow anchor, while in fact flys are always nominally anchored in
        the master, so we didn't find the relevant fly frame and no invalidation
        happened.
        
        Once we use FindMaster() to look up the master and filter based on
        FindAnchorCharFrame(), we find the relevant fly to invalidate and the
        position is correct.
        
        Change-Id: Ic485527bb9dd05b3d5aed383eb5fa1c4f9f6a76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147943
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d7b0a6ebbf5154933bc4a450613362052167791]

        move sanitizing of Size inside GenericTypeSerializer
        
        I cannot see a useful application of a Size that is negative
        (at least not in a file format).
        
        Change-Id: I0c5bd8c7d3987a5c7803af2a6ae0543c4a6d7754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [eae92409e7aefb0837a0408563bd3787406aab8c]

        Avoid extra newlines in HTML
        
        SwHTMLWrtTable adds SAL_NEWLINE_STRING itself calling SwHTMLWriter::OutNewLine
        explicitly, so the LFs inserted by HtmlWriter::end() just add noise.
        
        Change-Id: I67f3ef6b315185e9df33e3a21f3ea4a4d045e296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147941
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [5993c41c75974c507683cdd1f19db45dd0c03dbf]

        flatten some internal classes in dbaccess
        
        no need for the pimpl pattern here
        
        Change-Id: I6e15dd7b68104b2848871c338d5560cb70c9c88d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147869
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9da3d052b9048e9139b6943621f4eb6777422078]

        tdf#109214 - Highlight the favorites in the grid of special characters
        
        Change-Id: I3b19aa833be4c7b9b0499ad051a240f131eba7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147926
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [dbd96e1c9a066979cb80ced6268edb148a8fc73b]

        tdf#153798 - Basic IDE: align line numbers to the right
        
        Change-Id: I6a8335b51aa7d4b50577aeefb188e3d81ddfee03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Miklos Vajna  <vmiklos@collabora.com>  [d25567e7e2fb96242b9bd4aca44df6f0287c2aa3]

        sw: document SwFrame::Format()
        
        I'm still looking for a clear description of what SwFrame::MakeAll()
        does.
        
        Change-Id: I945f17ca0367329220cfa01b6ccfda1c3472ab28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147927
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-28  Noel Grandin  <noelgrandin@gmail.com>  [604c464e35807c7e4fa700726a338a9682010a15]

        osl::Mutex->std::mutex in xmlscript::DocumentHandlerImpl
        
        Change-Id: If956c1e09e0185e7966edc17e2941b3f5d86c98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147681
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Henry Castro  <hcastro@collabora.com>  [d4f6202c3ad6f5c970093c7df7c89bba1ba22c3f]

        tdf#150925 sd: templates: fix missing attribute "style:display-name"
        
        The function GetSelectedMasterPage() search by name, the
        missing attributes and it defaults name to "Title", it
        contains duplicates and it selects wrong Master Page.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ia02d66693f33a96cb46fb45b6f435e5cd040ed76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147350
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit e9231535570da032b80cba355cd93c68911b2dbd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147602
        Tested-by: Jenkins

2023-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [394dcb830c9d7bfe3a454589847be0fd5024dc86]

        tdf#153857 Writer hangs right-clicking on form field
        
        regression from
            commit 5032262fccd0ef7f274323ae481b3230ffd42d3a
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Feb 21 15:05:37 2023 +0200
            BaseMutex->std::mutex in PopupMenuControllerBase
        
        Change-Id: I01bdab09ac0ce1d9b35ed45ad36d1c5179702c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-28  Kohei Yoshida  <kohei@libreoffice.org>  [e83c243018c1c7f6662f9a8ecdc731c5c071ea31]

        tdf#153669: Track formulas that stopped listening ...
        
        ... then have them start listening again after the copy from
        clipboard is complete.  Note that in case the pasted cells
        are formula cells, those will be handled together as well.
        
        Change-Id: Ia4be814b888734267a39f7c89435011968570b7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147940
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [acc819f6f40e43775d9f5d76971a9ba72e690dbc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e037f2dbf9c7d93ce020ca1709c581624c75fbd
          - tdf#150164  improve general description; mention hyperlink export
            
                  "outlines" -> "bookmarks", and add "document structure" to the
                  general description for this dialog. Add a sentence to mention
                  that hyperlinks are automatically exported.
            
            Change-Id: I423571a332ecb34e7243c6ba47eb92d3ae1e3ba0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147906
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [b73f10e28126eeee349c78de0a8cd487d4315736]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d94705d5baaed4be8d2521d9caf7510ff5d9d76
          - tdf#104804 - clarify explanation for "export outlines"
            
            Change-Id: Ic81cda7b6d639e8cd06989f94d7378281a99a13e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147905
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-27  Eike Rathke  <erack@redhat.com>  [4f7e8f0d819383a6953ccbb53f704d2265577a2f]

        Underflow assert also in already calculated path
        
        Change-Id: I7bd1c4960280a6526bb82e5b95c5253775df1e1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147937
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-27  Eike Rathke  <erack@redhat.com>  [1db24b1798b80062a1d06104828d1ec6f32ae8ec]

        ConvertMatrixParameters() worth some asserts instead of OSL_ENSURE/OSL_FAIL
        
        Change-Id: I91e7e8d66b88912b05ff273a5eb948bb6edc504d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147928
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-27  László Németh  <nemeth@numbertext.org>  [e706698353a7187f46ddbf0faf1f6f7772753df6]

        tdf#153859 sw: crash fix for setting chart with deleted data table
        
        Opening Data Ranges dialog window of a chart with
        deleted data table crashed Writer immediately.
        
        Follow-up to commit 5b9855acc7fa6d1e4a5f53ff0bc47e1dd4729827
        "tdf#132714 sw: fix crash at table row deletion associated
        to a chart".
        
        Change-Id: I96e901db75d40ae234f58827a957204bca13aa92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147893
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [3ffd375ffee648cdb67b1f3062f84a4b2f3af9df]

        tdf#146463: rework unittest to be DPI independent
        
        Otherwise, it fails when scaling is 125% with
        
        Test name: Chart2ImportTest2::testTdf146463
        double equality assertion failed
        - Expected: 4256
        - Actual  : 4330
        - Delta   : 30
        
        Change-Id: I6cce69a00806208cbf168dfffc06ffb60f8a51bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147891
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [49f9879ae8d30a99f9926738ea007a04d2ec1be8]

        CppunitTest_chart2_import2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I72b88eb4c369f45daa31c984b9e1021e66faafcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147880
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-27  Caolán McNamara  <caolanm@redhat.com>  [3b279889daa9c37fe91663d16dd2d8c5938cc0d5]

        Related: tdf#153784 margin_bottom is a cnp nonsense, should be margin_end
        
        Change-Id: Id14f63a8bfb64622e505903820b7f081c368389c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147924
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-27  Eike Rathke  <erack@redhat.com>  [3cbaf50877e15ccdbc15e2bf11bbed6d3f3cc8ca]

        Output numeric cell position in SAL_WARN() as well
        
        ... to ease conditional breakpoints.
        
        Change-Id: If1ec85e56ab3db5319eae8659b46d31ad621cf61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147923
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-27  Stephan Bergmann  <sbergman@redhat.com>  [788dd3e7fb24c681716608a8bf0339df8c78e4e5]

        Note that Clang consteval bugs are meanwhile fixed
        
        Change-Id: I90b2765bdad5fe753288420b01a5395bcf22f44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-27  Eike Rathke  <erack@redhat.com>  [64914560e279c71ff1233f4bab851e2a292797e6]

        Always push a result, even if it's only an error
        
        PERCENTILE() and QUARTILE() if an error was passed as argument (or
        an error encountered during obtaining arguments) omitted to push
        an error result, only setting the error.
        
        Fallout from
        
            commit f336f63da900d76c2bf6e5690f1c8a7bd15a0aa2
            CommitDate: Thu Mar 3 16:28:59 2016 +0000
        
                tdf#94635 Add FORECAST.ETS functions to Calc
        
        Change-Id: I23e276fb0ce735cfd6383cc963446499dcf819f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147922
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [16e728a8a88a7a04acec069512a5268ae89cf420]

        MCGR: Adapted other Gradient* to make use of MCGR
        
        Added to make
          GeoTexSvxGradientElliptical
          GeoTexSvxGradientSquare
          GeoTexSvxGradientRect
        work using the MCGR. It is still 100%
        backward-compatible, so as long as there is no
        source using this it will stay invisible - by
        purpose.
        
        Tests look good with all three, see the static
        variable nUseGradientSteps.
        
        NOTE: GeoTexSvxGradientElliptical still looks not
        optimal due to texture back-mapping method
        getEllipticalGradientAlpha, see notes in
        commit "MCGR: Adapted GradientRadial to make use
        of MCGR" ac824594c577ab4880177b3411a25297b1d08074
        
        Change-Id: I56b82b867af88fe532f840dde15e0f5c299ed6a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147662
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-27  Noel Grandin  <noelgrandin@collabora.co.uk>  [9027920783dd04db925c41b559abe6442cedf39e]

        improve reliability of CppunitTest_sw_uiwriter3
        
        something in the paste stuff seems to need UI events to be
        processed
        
        Change-Id: Idf10a240ff049bd52873296619f8f820142fda7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147918
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [f4092d4ebd500538cfd8bc64b5dfee95c66c8ec2]

        CppunitTest_chart2_import: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I6e9c18fa0195b2e8ae44ba2782c725f6cec8d471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147879
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [f744a17e6d1f7267eb159bc771790fa44398290f]

        CppunitTest_chart2_import: re-enable test and adapt it
        
        Since f281d2d24c2a368c58d32b1b50acf83e0f056d90
        "Actually we shouldn't always set Overlap flag on for all xlsx
        charts..."
        
        Change-Id: I3e68ff99b18033879d85e3b9d40afa5a3d25b14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147878
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-27  László Németh  <nemeth@numbertext.org>  [4f2dcc4bc70c3602e2612dab611b610410637920]

        tdf#153858 sw: crash fix for chart with deleted data table
        
        Using mouse, e.g. simply moving the mouse pointer
        during editing a chart with a deleted data table
        crashed Writer immediately.
        
        Follow-up to commit 5b9855acc7fa6d1e4a5f53ff0bc47e1dd4729827
        "tdf#132714 sw: fix crash at table row deletion associated
        to a chart".
        
        Change-Id: I6d89eabc84565c548e2d9ded922789d623367ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147882
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [c23c071f38978f51a03dc352058c34448d314e03]

        tdf#153855: Crash on opening Fontwork dialog
        
        it was removed in 2b0907967f0b44bae505045651ae393e89d5172a
        "Bump Glade release for fontworkgallerydialog"
        
        Change-Id: I495144904fcb712a83b6d62b7e72e7cfb68e4805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147915
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [c46582de06f8d39cc4fc955578c221a29d57cc1a]

        return by ref from SdrGlobalData
        
        return values are never nullptr
        
        Change-Id: Id84fc6c8c63cdb34bdd8c07d8ff5b45f1bff2e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [da68460e03dc9857a24f2afeeb34f191f20f29ac]

        fix small leak in SdrGlobalData
        
        Change-Id: I2b651aad847cf083659df34c94653c73460ddfd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Michael Stahl  <michael.stahl@allotropia.de>  [bc72cbf2e481fe04f610f3bf799ba606d9387ffa]

        sw: disable testTdf78510 on Mac
        
        on tb93:
        
        /Volumes/tdf_builds/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/test/source/xmltesttools.cxx:165:testTdf78510::Load_Verify_Reload_Verify
        equality assertion failed
        - Expected: 2306
        - Actual  : 3110
        - In <>, attribute 'x' of '//textarray[1]' incorrect value.
        
        Change-Id: I5c01766de48da7e2367f80512aef81f5a327e870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147883
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [0292570e63d51f222d9776e0c8714af4cb365b52]

        osl::Mutex->std::mutex in CProgressHandlerHelper
        
        Change-Id: I86ddf381e0d52fe50739d5378ea36059a4d1e521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147863
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ce02008ae8b61a6a489e65bd32b5e8bdc47e99e]

        osl::Mutex->std::mutex in frm::OComponentEventThread
        
        Change-Id: I419a96fce0d5dbdd438dda32217ced39ba598446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147864
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Andras Timar  <andras.timar@collabora.com>  [62d3da841b402f7cc9421d87f3f1db714b278d40]

        OpenSSL 3 is covered by Apache License v2
        
        Change-Id: I20b30ce01b08787f560cd00cd87db9cec1699240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147746
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6e4acdbca3c269681ea387ec35dd4ce80cfbcdee]

        Fix typo
        
        Change-Id: I7e61bb401191ab533eef2f8d191e618b24c15e0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147888
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [146ed50caded37f6084c404e8af6985996a17cd3]

        Fix typo
        
        Change-Id: I570f2ec9894ff83a5378e5c09838527804a1f943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147889
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [222a54b90562662841f1e74f486731a5d2c22ab3]

        Fix typo
        
        Change-Id: Ic46012d64456a85255bfd91a98b642c59df210e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147890
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce0cf8301f1452f3bdc00992b7fde5e97a007337]

        osl::Mutex->std::mutex in DefaultComponentInspectorModel
        
        Change-Id: I1f76a062f75d1779ae86ae931ff3e2ac4f1ba831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147859
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [93f9ce7b644c0887423891e0d645b88eb39bc457]

        osl::Mutex->std::mutex in rptxml::ImportDocumentHandler
        
        Change-Id: I2e7c2c5642de4e234a551a1b02c8fd69fdcb65c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147860
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ee84725f59e880d38ab7adb43b2a8126f2dfd65]

        mpLocSymbolData is unused
        
        and SmLocalizedSymbolData cannot even be instantiated. It is better off
        as a namespace, rather than a class.
        
        Change-Id: I4d6daace649e3529cefe67cf18eed85f2cbfc980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Caolán McNamara  <caolanm@redhat.com>  [e48120a033daba70b4113d12b1e6745283963e39]

        ofz#56293 Timeout
        
        Change-Id: I8c6385b879d517b3f40a33d139295aeafb1c6354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147874
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-27  Heiko Tietze  <tietze.heiko@gmail.com>  [084fae866b108938e58e1d2d279ac17263c8794b]

        Resolves tdf#153580 - Calc's sort dialog too large
        
        Rearranged the content so the size is now defined
        by the longest strins only
        
        Change-Id: I2fd6f8bd0838c13f2e7f7c370ac7aa547b7e6a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147505
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [6db64ffb8430d40475721662c77bbc18ac6255fb]

        inline StreamData into SvFileStream
        
        Change-Id: Ib2bfaa903b5c57b7d802afe7928720e6007d54ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [e43606a5a5c7ef44d4bab2f9bf526a8656775bd4]

        osl::Mutex->std::mutex in rptxml::ExportDocumentHandler
        
        Change-Id: Ida7fbf7a619f4a6beb9f05107110e9c9a0b60813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [450d195bb8c09866c6988a3b3ac82dbe349f7849]

        UITest does not need to be a class
        
        Change-Id: I0d9b67076abe0acc20406f594b1724a909504a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147866
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Tor Lillqvist  <tml@collabora.com>  [a62cb6db8210771c487dd934158e01c3d2db77af]

        It seems to work to compile also the MMX code for WASM
        
        Change-Id: I27b56297a07e248102cae1bee4074b7be422ce23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147875
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [f52dfc6fff0fa5f94aed433b22a87764c13e8e53]

        Simplify a bit
        
        Change-Id: I2b4dc36e102f47b7fe61cd7c32bb2810cb35ea7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [b3b18f8606131fc9998e872de84aab475acabf1a]

        Related: tdf#151429 Move fix for tdf#152717 to ScByteSequenceToString
        
        The GetString method is only used in DDE context; and allowing it to
        handle Anys with OUStrings generalizes the fix, simplifying its use.
        
        Change-Id: I50952c25fa736a9ca73515801cc1b1903c62453e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147753
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [edf8047e854f78d5b90a601eda598d19a40301bf]

        osl::Mutex->std::mutex in FileViewContentEnumerator
        
        Change-Id: Ib9f0b7ba39f5acbfbdbd664f74a4a91f645c8192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147862
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Miklos Vajna  <vmiklos@collabora.com>  [09ada9cf6e15f3a735d2c94737b045c5e0f001ef]

        sw: prefix members of OOXMLDocumentImpl, OOXMLFastContextHandler, ...
        
        ... OOXMLFastContextHandlerLinear and OOXMLParserState
        
        See tdf#94879 for motivation.
        
        Change-Id: I65f1b98918da40d9e3dbc27af54dadd38aaba8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147854
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [4805a1348bb3749d468656a4e648064dabe1fd04]

        Optional may be avoided here, too
        
        Change-Id: I6320f8b745ead030cb7ae304bdf85e0064a57380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147751
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [59bc90c9d60b5f425f29ce42d1db9381eb2c1f4d]

        Use SAL_NEWLINE_STRING to avoid some wheel re-invention
        
        Change-Id: Ib60ddf2b1111fb2d6caf22ac6e0848bd27373b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147750
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-27  Laurent Balland  <laurent.balland@mailo.fr>  [41b991ea0cf3f8ce36cbdbf16b9c2c6d2bb16b5d]

        tdf#153709 Adapt message for Delete Sheet
        
        When deleting sheets, the message is adapted to the count of selected
        sheets (singular or plural).
        The confirmation message is skipped if selected sheets are empty
        The message for pivot table data losing is replaced by regular
        confirmation message if both pivot table and data are selected
        
        Update UItests when there is no more confirmation
        
        Change-Id: I5cbd6d7cbe271ad86c5c68820b23df5a2307f3bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147309
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2023-02-27  Caolán McNamara  <caolanm@redhat.com>  [9a930ef9ea45277109c9acd6e7e1ccfe47fe136c]

        can use a reference instead of a pointer
        
        Change-Id: I770983c2a46c2181db80243efa7c926e356d5e6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-27  Miklos Vajna  <vmiklos@collabora.com>  [7677e16217349a0a0e94edb6a90b00089432c6ce]

        sw floattable: allow extra space on top of child content in SwFlyFrame::Grow_()
        
        Once a floating table with a single cell wanted to span over two pages
        ("split row"), SwTextFrame::SplitFrame() was called, but then the table
        split failed because everything moved to the next page.
        
        The reason for this was that we tried to grow the text frame (and all of
        its parents: cell, row, table, fly), but a non-test growing a fly
        normally just works by recalculating its size based on the content,
        ignoring what growth is wanted.
        
        This is fine in the non-split fly case, but we do want to increase the
        size of a split fly to control what content remains in the current fly
        frame and what goes to a follow fly frame.
        
        Fix this by extending SwFlyFrame::Grow_() so it grows more than just its
        own content in the split fly case if the request wanted that.  Now a
        single row can split, but the position of the follow fly frame is still
        bad.
        
        Change-Id: I1c6aa61996dab058c291331a795627d3fae1bca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147858
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [81d0b3569fc49525feba61fb2f81c90e152cbb30]

        Simplify a bit
        
        Change-Id: I78f5dd63a70d52e7e0b257eed1c668bead2039d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147856
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-27  Justin Luth  <justin.luth@collabora.com>  [0d2a962c363632a890a994e7e143099c53ac4283]

        tdf#151548 sw content controls: add UI for Id and TabIndex
        
        This is my first go at adding anything to the UI.
        (I've done some fixing of other people's design,
        but never created anything new myself.)
        
        I took all my inspiration from Miklos'
        add110bad816fadeb96e7af0d4689389c04c263e.
        
        In the first iteration I did a fancy "same as id"
        scenario. But ID-as-unsigned, securing unique IDs,
        and English-only number recognition
        sadly made me decide to drop the fancy features.
        
        Now, both are simple, stand-alone spinbuttons
        that depend on tooltips to guide user input, not fancy comboboxes.
        
        It is important for the ID to display as unsigned,
        since that is how it is used as a "name" in VBA.
        It should be copy-pasteable for use in VBA programming.
        
        It is useful for the TABINDEX to display as signed,
        since it allows entering a -1 to disable tab navigation to the control.
        
        make UITest_sw_ui_misc
        
        Change-Id: Ia7c99888e60c33ac39616b24c7c1715604c3ec69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147591
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-27  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [99bb5a7843469a0c8a23215a2a72bb34a3c47d0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a2868f03eda97185d96cf661624e3c8668876294
          - This sentence is missing a subject
            
            Change-Id: I2eb66e5ced49809b86a3cdb48103381646b965a2
            
2023-02-27  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [82637d7cba204eea626af8b76f67a389001bc680]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 976284c63182811da8da66144f22ff0502c880df
          - Impress: Rework of help files (main 01)
            
            Change-Id: I8daa90ed8b82d3b8775a613c47491f69f7be575a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147700
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-27  Noel Grandin  <noelgrandin@gmail.com>  [09680fadbcd85da3405cefeed66712bc0ba2be9c]

        no need to hold CollatorWrapper by std::unique_ptr
        
        allocate it inline, it is only one pointer in size
        
        Change-Id: Idb6217e6c9c37da92427aa6c497223a84015c553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [44a3085f9aaf0dfc62b1a8f34d3b8889d69c4e62]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 19fc476019704c84f0a4aad9846b2dac579d19a3
          - Clarify that it's "character key"
            
            See e.g. https://ask.libreoffice.org/t/88505, where people expect
            capital letter in mnemonics to mean "exactly capital", i.e. with Shift.
            
            Change-Id: Id42c3aeaad6d04a4df58780f5ce5aca71532366b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147835
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2023-02-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [85e86bc9c50eae4831286c467c6a583a5f9caf28]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 22b85af46f3eacc6abd45be4e78d13079851e55c
          - tdf#153722  "Chapter Styles" -> "Document Structure"
            
            Change-Id: I722631402b093ee29174e4ed029f543525f46951
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147596
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-26  Caolán McNamara  <caolanm@redhat.com>  [03f58d6af52bab05545833980cca835a3df0949a]

        cid#1521198 Untrusted loop bound
        
        move sanity check inside CountTTCFonts so it applies
        to the fd smuggle in via filename mechanism
        
        Change-Id: Id2fee5801d71720747a8736859681e7c9a324bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-26  Stephan Bergmann  <sbergman@redhat.com>  [5a0ee146834fec1661051d1ad708bc3e96163af9]

        Fix Library_jpipe__staticsalhack
        
        ...after e7bad15bc13292defd99cb561f867d8b77692e97 "Unify
        osl_{g,s}etThreadTextEncoding implementation across platforms" caused
        
        > /etc/alternatives/java_sdk_11/bin/java: symbol lookup error: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libjpipe.so: undefined symbol: osl_getThreadTextEncoding
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2694/>)
        
        Change-Id: I0e309da4bc88668e4ba57b53e2a60d6074d4c124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147744
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-26  خالد حسني  <khaled@aliftype.com>  [5a235634ca5761aa4b330ebf7e3a2083b7db1606]

        Revert "Mark ssXX and cvXX off by default in font features dialog"
        
        This reverts commit 3f9a8a3b7656470cfcf04c18a46a7b7bbeca8950.
        
        Reason for revert: Needs more work, currently causes all ssXX and cvXX to be added to font string when the dialog is used.
        
        Change-Id: I07eff710a2813e60fa4de3c23eb0a3c31d40e41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147810
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-26  Noel Grandin  <noelgrandin@gmail.com>  [bee4402c7ed97f3373f93eb7939940557bd59912]

        no need to hold SvtSysLocale by std::unique_ptr
        
        allocate it inline, it is only one pointer in size
        
        Change-Id: I736f3322784897054993fbddd423f36357f817c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147741
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [639d72e13e57cfffc857af1b9b7034c97f1f355d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to afa78ade65147468ca4f0b4ad168c4288e8a79b2
          - Impress: Rework of help files /02/ 20
            
            Change-Id: I898a05cd1b79e69e36cb1d65174fdd8733f7bd88
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147697
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [4600de7529e209061617584eb532e5dba1e748db]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 42a2c3690f7991cc6c854bc9454e361cf309a03f
          - Impress: Rework of help files /02/ 19
            
            Change-Id: I864134d17d8a5b4d28a38a011b52099fcb01b9c6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147696
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [fc7ea9c3c68e519e29545514e6eb2edd6a345790]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a80b1487e881fa471425e91f8682aaa2eea4381
          - Impress: Rework of help files /02/ 11
            
            Change-Id: I90cb7ddb3e21d3a0f7dbd92a189d0e594d529e7c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147648
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [8e82fb04adc77610b8d3582c6c9125cbd86bd9bc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c1273a6d37db796f3d1c4de2e029d54fb310f73
          - Impress: Rework of help files /02/ 08
            
            Change-Id: I90d6d661dcbae087408c711be24eb3940147886a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147645
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [68e675ec8e85581e9c0b2372cc63b8986a19e989]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 32c3be6bcab10a181cfc6b10eef3d110b23f8b1a
          - Impress: Rework of help files /02/ 09
            
            Change-Id: I1f3ff833ddf2e25b8cfc703c341c77119f72490c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147646
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [27d5ee4cf69dc42e07dc3d540738aa3ad1210c9d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 614abe4a78bc3b03a15e5c67d035ae1c9d4d16fa
          - Impress: Rework of help files /02/ 02
            
            Change-Id: I37cfeec8472e51edc427de5b796db94dbf21b18c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147638
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [019fc14397b2ef659feb67cbc4a837abc155a7e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1bb9993d63ad88d8cb4879fa248ec6f355c7b41d
          - Impress: Rework of help files /02/ 01
            
            Change-Id: Ib41b18357c354df2ce164e62adf989bb8cab73d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147635
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [333ce52b5a99000d520a87ba875426de92f1103f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 953737d3aa31c0acda9adf3dfc4514fd2d8e8b58
          - Impress: Rework of help files /02/ 04
            
            Change-Id: I8facd25cb9f2fdc9c511f1564ba136d6ca9302cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147641
            Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [76634c937ac55a9ea535f78b8683f679222f1e78]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1574b3f4a3c2d5e2d0402a200a79c77fd14cf015
          - Impress: Rework of help files /02/ 07
            
            Change-Id: I481815f6e4abea6f6d35e1b5174c4ace3ae47ef6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147644
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [6e354c3369591afd97dfa8a8c1e922827abd797a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 912f37e81e65829c80c5f388b60330be7eb7f496
          - Impress: Rework of help files /02/ 03
            
            Change-Id: Ibe8472e3787af74f440ccd483dfa956ba8a24fb9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147640
            Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [d6d06863ecfa4fb30a495a8c18f27a1c540df887]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7fe2c828d9888663387fba17611d380be48da1b1
          - Rework of fontwork.xhp
            
            Change-Id: I42e36ebbd830ccaa12a8fc5b06fb8792ddaac018
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147449
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-26  Alain Romedenne  <alain.romedenne@libreoffice.org>  [fd19bc83cfd49937da8585b9ab938b2086ecf74a]

        tdf#141474 tdf#151901 BASIC functions argument names do not match that of VBA
        
        Basic function argument names can be used either by position either by name, keyword arguments ae called 'named arguments' in VBA
        - VBA doc:
        https://learn.microsoft.com/en-us/office/vba/language/concepts/getting-started/understanding-named-arguments-and-optional-arguments
        - libO Basic function signatures:
        https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03090401.html?DbPAR=BASIC#bm_id3154422
        
        This patch attempts to correct - all in one - malformed keyword names in BASIC function signatures.
        
        It reflects keyword arguments usage inside QA BASIC unit tests.
        
        In the end Online help pages may incorporate such practice.
        
        Change-Id: Iab0c92b2c152d2564662e51e68f1f736b8deefd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145720
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [05079016e97d0b41c45cc71695d922fce9ae1e6c]

        Cleanup general options tab a bit
        
        The crashreporter feature (and thus, the whole frame visibility) depends
        not on OS, but on the HAVE_FEATURE_BREAKPAD define. No need to control
        the checkbox visibility separate from the label, when we can show the
        whole frame selectively.
        
        The quickstarter feature is only available on Windows, since the systray
        support was removed in commit 3e9c908b73f0fe0978c9980750a06bbc9e02295e
        (remove Linux ("UNX") systray "Quickstarter", 2018-05-23).
        
        Change-Id: Id990b53a6bbfa6b42defec0cc196e7fe817a1924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147738
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [cbf7c0da0f7cd24b2f0da3261dd419be115e57b9]

        zxing: fix build after upgrade to v.2.0
        
        Change-Id: If1b85a1f9f1b562aed8f357fd34434c8fe97e2f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-26  Caolán McNamara  <caolanm@redhat.com>  [323a1a5ba9eb676095d33ecae0717b325189caf4]

        cid#1521508 Dereference after null check
        
        Change-Id: Ica9039a9aea7e1247ea957a8e25aaaafc944a97a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-26  Caolán McNamara  <caolanm@redhat.com>  [ee03f6453e6f11f3db0742b08c53ad2c6b4ebb63]

        cid#1521509 Logically dead code
        
        and
        
        cid#1521507 Logically dead code
        
        Change-Id: I1d2c9ee4a4099fadb5da7a6850b4124488e2ebe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-26  Caolán McNamara  <caolanm@redhat.com>  [1b7ebea25fb94efa08160792c4eb6ae9e8a9147f]

        ofz#56345 Heap-buffer-overflow
        
        happening since:
        
        commit db115bec9254417ef7a3faf687478fe5424ab378
        Date:   Tue Feb 14 18:03:55 2023 +0100
        
            tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl
        
        but due to
        
        commit 29dfcc7521311e547fc069466cc3edc9fcbdbe03
        Date:   Mon Nov 23 16:17:37 2015 +0100
        
            tdf#94088 add import of HTML inline graphics
        
        splitting the condition that used to fall through to default handling
        with an unrelated RES_BACKGROUND case instead
        
        Change-Id: I26a077c755f214cf35582ec146fcf34f87cc4494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-26  Julien Nabet  <serval2412@yahoo.fr>  [4abe76d3774132ce6a6b04dfc22371a885621d98]

        Missing ":" for "Background color" option in Area/Hatch
        
        Change-Id: I021c983337500adb0dce348e8b7e3f42a2316e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147736
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [bc9e978a5df5f2ee84b32d1a4a67d5e6eadb4e86]

        Hide Quickstarter from General options in Windows store apps
        
        In that environment, the shell:Startup shortcut created by us points to the
        quickstart.exe under Program Files\WindowsApps\<StoreSpecificAppDir>\program.
        The resulting shortcut can't launch, because of an inaccessible part in the
        path (the protected WindowsApps directory). So the feature does not work in
        the dialog.
        
        Windows store apps should advertise the Windows startup task in the manifest.
        Let's just hide the dialog entry in this case. A possible TODO would be to
        provide a button instead, which would open the Startup Apps system applet,
        similar to what we do for Default apps for file associations.
        
        Change-Id: Ieafdf6d23ced96506b01c6b3cf9fb12904696df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147735
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [beb1479b9b2957d63d1bdadc3cc6839a92bf0144]

        tdf#152595 Colibre: Update icons in Start Center to match new branding
        
        Change-Id: I2991bd9b68e2148b8852b95544f3e187148540d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147734
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2023-02-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [c2de9708f1041d230b4688151116ff9c3c9e5184]

        tdf#153802: make it possible to change the UI with read-only docs
        
        Change-Id: I392ae68ef086a8c857e0d9d9e6117e27a85c9ba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147655
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-25  Sophia Schröder  <sophia.schroeder@libreoffice.org>  [508a610808631bc292a8daf4f78bd8726b2d56be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e08030ec02875d4903bf22cfc7054f27822e7266
          - Impress: Rework of help files /02/ 10
            
            Change-Id: Ia95572f48e9502528895545a7edfa48507ef983c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147647
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4fa801489ea44427e1e8c397e77b66d25a0c5f96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b4f3d78786ba6b1d014dfb6075b3245cd5f7bf2
          - tdf#153560 update changes "Chapter"->"Heading"; "Level"->"Up to level"
            
               corrections to command descriptions
            
            Change-Id: Iebc4e664d8b0e2df2dd9640b30f5ab13b7729705
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147639
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-25  Justin Luth  <justin.luth@collabora.com>  [e88aa18972de17f5307356933e29d20026077042]

        word vba: tie "Word" to VBAGlobals
        
        This allows Word. to prefix global commands.
        While this is superfluous to use this profix in a DOC/X,
        the purpose is to allow the spreadsheet to call
        Word.<whatever> macro calls that execute in a word processor.
        
        At this point, it is simply added to SwVbaGlobals
        to allow macro calls to run without raising an error.
        
        make CppunitTest_sw_macros_test
        
        Change-Id: Ibeda67d458d4757be809d8669a4e424c4e6c3458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147682
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-25  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [0f959ba9e8feef69ac0435795defd5f092147182]

        refactor DocPosUpdate, part 2
        
        - separate the message send from the field manager to the fields
          containing no start index from those send from the field to the
          frames containing an index
        - use member functions where possible: SwFieldType, SwFormatField,
          SwTextNode
        
        Change-Id: I488e4003b75bf7b0ae700f39e2364d6e34a8bbfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147490
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a885d4839800f03759c5c22b513b5ffdc8478848]

        Remove duplicated include
        
        Change-Id: I3848788410525b36a1ece56b125e75a2281fafe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147474
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-25  NirnayK  <nirnaykorde@gmail.com>  [925796b3e2b45e04712fb647f0dfcf805a9b4ec2]

        tdf#143148 Use pragma once in vcl
        
        Change-Id: I99317552a32f0cb70333f542d54c86dbdd9d1746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147676
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5cc761b5d0852d0f5d7954692b2a152a28dcd425]

        Fix typos
        
        Change-Id: I7e3d78e6cf80afb72be61942ac95c474dae0424d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147669
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [86eb8f694634623b30eabf4e02ef769a7aba4937]

        Fix typo
        
        Change-Id: I17a06f2cce87f6f6edb3517750e9869de9cdd5b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147668
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4acb3227215bdd5c4aae25e1589e6d0fac3faebb]

        Fix typo
        
        Change-Id: I235929b467799d82001a266d607ddb6f4dc8e2c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147671
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-25  Heiko Tietze  <tietze.heiko@gmail.com>  [895527e3a5af6b57ff8d4ef2a0198d9dd6707746]

        Resolves tdf#153578 - Duplicate mnemonics
        
        Removed the hard-coded accelerators
        
        Change-Id: I27dd96dba01f8d4d1d73d75cf5cac1a6dc34720f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147504
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-25  Bogdan B  <buzea.bogdan@libreoffice.org>  [8bea9073303add3a554377eadc5f72ac5e48e734]

        tdf#152880 Remove repeated terms from Content Controls
        
        Change-Id: I23fc832bf120612ed4486786c071a26f9f538652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145003
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-24  Hossein  <hossein@libreoffice.org>  [573863d78ae55cdb8dfc9747aee47804a0b6f84c]

        tdf#153533 Fix chart2_import test failure on HiDPI display
        
        The test checks that the text shape width is smaller than the chart
        wall. This test fails on HiDPI displays. For example:
        
        --------------------
        lode/dev/core/chart2/qa/extras/chart2import.cxx(2207) : error : Assertion
        Test name: Chart2ImportTest::testFixedSizeBarChartVeryLongLabel
        double equality assertion failed
        - Expected: 4800
        - Actual  : 4632
        - Delta   : 100
        
        Failures !!!
        Run: 85   Failure total: 1   Failures: 1   Errors: 0
        --------------------
        
        Now, instead of testing the
        exact value of the text shape width, I have used CPPUNIT_ASSERT_LESS()
        to make sure that the above condition holds:
        
         CPPUNIT_ASSERT_LESS(xChartWall->getSize().Width, xXAxis->getSize().Width)
        
        This is done in two different tests:
        
        * Chart2ImportTest::testFixedSizeBarChartVeryLongLabel()
        * Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel()
        
        Both tests are among those that can be invoked with:
        
          cd chart2 && make CppunitTest_chart2_import
        
        Change-Id: Ifb28fcf91da451aecdadff7a95aa810ef16fc510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146815
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-02-24  Justin Luth  <justin.luth@collabora.com>  [ffa403e539bea44ce46fe7d976e7a00b319808f5]

        word vba: add ShowAll to XView
        
        This allows ActiveDocument.ActiveWindow.View.ShowAll = true
        
        ShowAll affects "View -> Formatting Marks"
        
        make CppunitTest_sw_macros_test
        
        Change-Id: I735eb42b0d53c34a4c4770c148f6ab7ac597fd84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147667
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-24  Justin Luth  <justin.luth@collabora.com>  [0d1d6ca553992fa53e98f749c325d8de39847f17]

        vba content controls: cleanup unnecessary SAL_CALL in cxx
        
        Change-Id: Ied80c4f46d6e2f16764448d5aab89cc9fc5f2b92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147666
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [790730a9b7651a1883d887f5b628f8f2b1e5e3a0]

        a11y: Fix focused state for special char dialog item
        
        As mentioned/worked around in Colomban's pending Gerrit change
        to implement an a11y test for the "Special Characters" dialog [1],
        the selected item in the character table was incorrectly still
        reporting the "focused" state even if keyboard focus already
        moved on from the parent widget to another one.
        
        Fix this by checking the item is not only selected, but its
        parent also has child focus.
        
        Tested by running this pyatspi script after a sleep and using
        the time before the script actually runs to interact with the
        dialog to test the different scenarios for the focused state,
        using the "!" character in the dialog):
        
            #!/usr/bin/python3
            import pyatspi
            def get_soffice_app():
                registry = pyatspi.registry.Registry()
                apps = list(registry.getDesktop(0))
                for app in apps:
                    if app.name == 'soffice' or app.name == 'soffice.bin':
                        return app
                print("soffice app not found")
                exit(1)
            def get_exclamation_mark_button(acc):
                i = 0
                while i < acc.get_child_count():
                    child = acc.get_child_at_index(i)
                    try:
                        if child.name == '!':
                            return child
                    except NotImplementedError:
                        pass
                    recursive_child = get_exclamation_mark_button(child)
                    if recursive_child:
                        return recursive_child
                    i = i + 1
                return None
            app = get_soffice_app()
            obj = get_exclamation_mark_button(app)
            assert obj
            states = obj.get_state_set().get_states()
            print("states:")
            print(states)
        
        [1] https://gerrit.libreoffice.org/c/core/+/142260/22/sw/qa/extras/accessibility/dialogs.cxx
        
        Change-Id: I277890105e3ff84ed35100b7cd7dc2ff40510921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147660
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-24  Justin Luth  <justin.luth@collabora.com>  [d6f3715190494b55e2ecc105cbd6e5ddeff47f0c]

        word vba: Add activeWindow to XDocument
        
        This allows ActiveDocument.ActiveWindow.*
        
        It already works as a global, and as Aplication.ActiveWindow
        
        Unit test will follow when some of the * items are added.
        
        Change-Id: I7fb18df9f6259ec4b9d60516b2da704098831dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147665
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a39f5da6f621fc60df0dbdd6c5a08cae5a18763f]

        BaseMutex->std::mutex in SdStyleSheet
        
        Change-Id: I9700622ac805a9e74df1701c4ece97ef960388ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Caolán McNamara  <caolanm@redhat.com>  [b16f5e374eb7e7199d4506eb04a3c3223dd52257]

        upgrade zxing-cpp to 2.0.0
        
        Change-Id: I3dc00f34359ec56a22cf7d8ba8e565ccb755c755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce472616b93a3fe1945c6f3ecd058af92782b215]

        BaseMutex->std::mutex in SfxLibrary
        
        Change-Id: If059f38bb394844ba72156854eed84de51bbbfac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [3470c58be9c0361f9656ccdf36f7855ea46e5c69]

        BaseMutex->std::mutex in vclcanvas::TextLayout
        
        Change-Id: I66970331312f30f42f16299ce6f38b2a13316e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c55d7540efdd33618950c93cabcb680e8e26c894]

        BaseMutex->std::mutex in oglcanvas::CanvasFont
        
        Change-Id: I74c3132bae4076915e1e41525d7cd7e709195197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [db295ca04a6a7ffa9525c43af80609801d22fb62]

        BaseMutex->std::mutex in CanvasFont
        
        Change-Id: I4f10e5d33b1067adbe3987c9a103951ea175fde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147631
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [e7bad15bc13292defd99cb561f867d8b77692e97]

        Unify osl_{g,s}etThreadTextEncoding implementation across platforms
        
        ... using a static thread_local variable, as already was used on Windows;
        this replaces the non-Windows implementation based on pthread_setspecific
        and friends.
        
        Change-Id: Iba42510dea90a9e7d1983ba4af674667055f6dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147624
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [d7fd46b5155bda021b09faecdefba26f6a59e997]

        Simplify osl_getTextEncodingFromLocale on Windows
        
        Drop all the complexity of thread-local storage used only to make
        EnumSystemLocalesW thread-safe. Just create a BCP47 tag, and use
        GetLocaleInfoEx to get the codepage.
        
        Also use locale name API in imp_getProcessLocale, and avoid the
        deprecated LCID API.
        
        Change-Id: I223564cc6d2cc919b0e5aadda1c12beee21e49f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147625
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [e403bf00af7767060f624077840921ceab04895d]

        Fix build in a specific VS2022 environment
        
        Building libraries in setup_native using VS2022 failed for me reproducibly
        for some time, with
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/reg_dlls.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_reg_dlls.mk:10: C:/lo/src/build/instdir/program/reg_dlls.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/reg4allmsdoc.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_reg4allmsdoc.mk:10: C:/lo/src/build/instdir/program/reg4allmsdoc.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/regactivex.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_regactivex.mk:10: C:/lo/src/build/instdir/program/regactivex.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/sdqsmsi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_sdqsmsi.mk:10: C:/lo/src/build/instdir/program/sdqsmsi.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/sellangmsi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_sellangmsi.mk:10: C:/lo/src/build/instdir/program/sellangmsi.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/shlxtmsi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_shlxtmsi.mk:10: C:/lo/src/build/instdir/program/shlxtmsi.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/sn_tools.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_sn_tools.mk:10: C:/lo/src/build/instdir/program/sn_tools.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/odbcconfig.exe". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/dbaccess/Executable_odbcconfig.mk:10: C:/lo/src/build/instdir/program/odbcconfig.exe] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/instooofiltmsi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_instooofiltmsi.mk:10: C:/lo/src/build/instdir/program/instooofiltmsi.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/qslnkmsi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_qslnkmsi.mk:10: C:/lo/src/build/instdir/program/qslnkmsi.dll] Error 139
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/inst_msu_msi.dll". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/setup_native/Library_inst_msu_msi.mk:10: C:/lo/src/build/instdir/program/inst_msu_msi.dll] Error 139
        
        It is caused by the -U_DLL and the first entries in gb_Library_use_system_win32_libs:
        libcmt, libcpmt, libucrt, libvcruntime. They are needed to make the denerated DLLs
        standalone, not dependent on presence of VCRT on the target system (they are called
        from installer, when VCRT may not yet be present).
        
        It seems to work OK for others, but somehow, this conflicts with the fastlink option
        on my system, so just avoid it selectively for these DLLs.
        
        Change-Id: I61f829682eb051944202bc7ef3578d6f43733030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147628
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [3fc2c054c505b8c99c3f8e64561de242bcd7d3b3]

        Fix build in a specific VS2022 environment
        
        Building Executable_odbcconfig using VS2022 failed for me reproducibly
        for some time, with
        
          mt.exe : general error c101008d: Failed to write the updated manifest to the resource of file "C:/lo/src/build/instdir/program/odbcconfig.exe". The file or directory is corrupted and unreadable.
          make[1]: *** [C:/lo/src/core/dbaccess/Executable_odbcconfig.mk:10: C:/lo/src/build/instdir/program/odbcconfig.exe] Error 139
        
        It is caused by linking odbccp32, and legacy_stdio_definitions required
        by the latter with current versions of UCRT.
        
        It seems to work OK for others; but being unable to find what's different
        on my system, I have this workaround, using run-time loading instead.
        
        Change-Id: Iab1fe7747ca6e677d89a120778ca805465a05611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147627
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [1786ddbde4b44575321aa6b9d9d367a964969063]

        Fix build in a specific VS2022 environment
        
        Building CppunitTest_basic_macros using VS2022 failed for me reproducibly
        for some time, with
        
          make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:841: C:/lo/src/build/workdir/LinkTarget/CppunitTest/test_basic_macros.dll] Error 139
        
        It is caused by linking odbccp32, and legacy_stdio_definitions required
        by the latter with current versions of UCRT.
        
        It seems to work OK for others; but being unable to find what's different
        on my system, I have this workaround, using run-time loading instead.
        
        Change-Id: Ic4094398f7510bc281dfa96f980f29f12f09d7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147626
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ae51dfb2379a9e9183afa9a1e5ee4fe4f4f0f7ef]

        MCGR: Adapted GradientRadial to make use of MCGR
        
        Added to make GradientRadial work using the MCGR.
        It is still 100% backward-compatible, so as long
        as there is no source using this it will stay
        invisible - by purpose.
        
        Tests look good with this one, see the static
        variable nUseGradientSteps.
        
        Change-Id: Ie7134fe2995b23ceb180c7daf3f5b2310c8a8a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147617
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-24  Colomban Wendling  <cwendling@hypra.fr>  [0ccea0dd6e50199af4a7aae75d691b32c853b177]

        test: Add accessibility test dialog infrastructure
        
        Interacting with dialogues in tests is non-trivial, so introduce
        helpers to make it simpler and less error-prone.
        
        Add tests for the infrastructure itself as well.
        
        Change-Id: I8ea6087a61380194eb2b5ec9f25091db00f5a550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142258
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2023-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [c15412eb96bda1037c12811f5818ed8ce1e603bd]

        tdf#153791: paragraph's/character's shd overrides shape style's fontRef
        
        I couldn't find any references to this in documentation (ECMA-376, MS-OE376)
        regarding this, but Word ignores the font properties (including color) defined
        in the shape style's fontRef for txbxContent's paragraphs / runs that have shd
        elements with non-auto fill color.
        
        Change-Id: Ice634a5eed7b51379649462303300f55358a566f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147630
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [78ae57d02c2a7e39c452b44855874bb8ad1dbc35]

        Fix typo
        
        Change-Id: I99c8b63055685f1ff024a4385690ac3e7cf23760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147658
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c7c7e6333983f62cb115113d25946b7c064db197]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 85516b6afb26f8f214184fc5ce223bc9e2064448
          - tdf#153552 corrections to "Options" description
            
            Change-Id: I73c71557766cde26d3c01898eb8327b9785d3218
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147636
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [d31442848197678939144779e04d2510f049874a]

        CppunitTest_sd_import_tests: use CPPUNIT_TEST_FIXTURE()
        
        These suites are large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I95614603e96e8d4132391c7b0e1bd5f0a36a6b30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147623
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [89f98a2a9ae48ac79d65db5956522e754930f5b6]

        use comphelper::WeakComponentImplHelper for UIObjectUnoObj
        
        Change-Id: I5aa340e9bc8abc498f37636f191c47c738fa1c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147585
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [3900f16e6939ba40f41b3ccd56a28f8275de318d]

        improved fix for CppunitTest_sc_uicalc
        
        Revert the previous fix
        (commit 0714dfe7fdb0cd3a49d4eb0e771da8eb4aa84d7a)
        and implement a better fix, was just a stale pointer
        
        Change-Id: I34006c2f387e2a16bcecef56ac9fb46a9669ebbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Adoche Onaji  <dochieonaji@gmail.com>  [8429f5ca376196f1f26c6729cd2559a8a246b9da]

        tdf#114441 Convert sal_uLong to a better type
        
        In slot.cxx, GetAttrCount() return a size_t type and same type can
        be assigned directly to nSCount. In hash.hxx, sal_uLong was declared
        in SvStringHashEntry, the only default parameter it the class takes
        is aName (type OString) while nValue was directly initialized as 0
        in the constructor. The interface to change nValue is through a method
        setValue of same type.Also In idl/inc/hash.hxx SetValue() and GetValue functionsb are used in idl/source/prj/database.cxx with sal_uInt32 parameter and return type and thus, sal_uInt32  is suitable here.The instances of sal_uLong in source/objects/object.cxx are replaced with sal_uInt32. In object.cxx an iterator was declared using std::find
        to find nId in rSuperList (originally declared as std::vector<sal_uLong>),
        therefore if nId is sal_uInt32, the parent vector, rSuperList
        should be sal_uInt32. This change is now applicable to the void method
        InsertSlot's parameter rSuperList in object.hxx and also variables n,
        nId, iter, rSuperList in InsertSlot definition block in the file
        object.cxx. Variable aSuperList in obect.cxx is also changed to
        sal_uInt32 because its an argument for rSuperList parameter.
        nC1 and nC2 in idl/source/prj/svidl.cxx are chnaged from sal_uLong to size_t as this is suitable here.
        
        Change-Id: Ie075875229a676ea32dbf9e3049881a479773703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147220
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [0629ebb23e8848b7b99913cac9ad07ac9e3fe670]

        CppunitTest_chart2_export: re-enable test
        
        It passes for me
        Disabled in b4668f2c48db7 "disable the test" without giving
        any reason why
        
        Change-Id: I6a38e5e6f5da78df88ac805de058c3528bc1251c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147616
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [f12e547c42103a3b934b393b6b63c2b096bbd06e]

        CppunitTest_sc_subsequent_filters_test: use CPPUNIT_TEST_FIXTURE()
        
        These suites are large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I3c9447b805ff5d0516bfef6b107de474cadeadc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147615
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c3178e3ad6a6faf1ea66898672e173b0008bce5c]

        BaseMutex->std::mutex in PDFErrorRequest
        
        Change-Id: Iae9c6fa3da9547d233470168aff3cda6270739cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Rasenkai  <rasenkai99@gmail.com>  [e66940a8d147c1dff14e34c8e9421dcf2429cb4f]

        tdf#114441 vcl: source: Convert sal_uLong to a better type
        
        * GetRed() , GetGreen()  and GetBlue() member functions return sal_uInt8,
          so the static_cast s are redundant, thus remove them and use sal_uInt8 instead of sal_uLong.
        
        * Simplified the code and made it more readable
        
        Change-Id: Ia6ac34762f16400c3db6681d6a0cc0469116bb9b
        Signed-off-by: Rasenkai <rasenkai99@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146778
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd70713132fa92abcf7255ff151ffe8666948b40]

        BaseMutex->std::mutex in UpDownBarWrapper
        
        Change-Id: I24a4400b3d223be76af135bd3da710490f029194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [803e3a63d879d8095b53b020cb648522fcb2af99]

        freetype: upgrade to release 2.13.0
        
        As the issue has been fixed upstream[1], removed some codes from "external/freetype/ubsan.patch".
        
        [1]"[truetype] Fix undefined pointer arithmetic."
        <https://gitlab.freedesktop.org/freetype/freetype/-/commit/905270925dd0492ba557e58938e5513f062e6fc5>
        
        Change-Id: I66c11e414cd9ecdad8678487d0c3f645a352ad92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147464
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2023-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [6acf3ded0ee17e4cb2c839b5f11f4bbeee2e13b6]

        CppunitTest_sc_subsequent_export_test: use CPPUNIT_TEST_FIXTURE()
        
        These suites are large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I8d6f6f2be2f76343c6d646603c0b0920c798c14a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147614
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f72de90f8a27b06aae0bf9ede93ed640764498b]

        osl::Mutex->std::mutex in OLESimpleStorage
        
        Change-Id: I3ff011fa4829bd7230ddaa8fc2d34ade47f09b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  László Németh  <nemeth@numbertext.org>  [d6182cb6704c06f33d284874b9fe96c85cce5bf5]

        tdf#153642 ucb: fix broken save with cached DAVOptions
        
        Trying to save a document within the lifetime of the
        cached connection, e.g. re-save within a few seconds after
        the first and successful save failed with an error message
        in the case of Vibe 4.0.6 WebDAV server. Waiting 5-10 seconds
        after the last try was the only workaround to re-save the
        document.
        
        Details: aDAVOptionsException in Content::getPropertyValues()
        removed the isClass1 bit of the cached DAVOptions of the
        same TargetURL (note: of the folder of the WebDAV document).
        This disabled the DAV detection part of Content::getResourceType(),
        and later the correct HTTP redirect for the DAV connection.
        Fix this by keeping the cached bit in that case, too, when the
        added connection has a different lifetime, than the cached one.
        
        Follow-up to commit 30ca48f4dc0e65a3798e6b21574bc80f6d4953fa
        "tdf#152493 ucb WebDAV: fix upload using HTTP 1.0 fallback".
        
        Change-Id: I5d4578232581a4df654f76198fdddf096cba5267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147570
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-24  Miklos Vajna  <vmiklos@collabora.com>  [6068ae5df9da179e1d187e27117a9d761116f968]

        sw floattable: don't promise infinite growth in SwFlyFrame::Grow_()
        
        In case the document has a single cell in the floating table with
        multiple lines, we may need to split the cell, but currently we don't.
        
        One problem is that SwTabFrame::MakeAll() for the master table gets an
        error from Split(). Digging deeper, SwTextFrame::SplitFrame() is not
        called at all, because SwTextFrame::FormatAdjust() thinks that the
        content will fit, because SwTextFrameBreak::IsInside() says so. This
        happens because it tries to do a test grow on the fly frame, and
        that promises to grow as much as wanted.
        
        Infinite grow for fly frames is reasonable by default, but we want to
        limit the size for split flys, so a follow fly will be created. Fix the
        problem by improving SwFlyFrame::Grow_() to handle the
        IsFlySplitAllowed() case explicitly. Now we split the text frame, which
        is needed but not enough to split the entire fly -> table -> row -> cell
        -> text frame hierarchy.
        
        SwSectionFrame::Grow_() has a similar limit in place already.
        
        Change-Id: Ie07362a8dc3aa8c4fbb69eaf7e35717ba79b99a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147593
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [818e98eed2ecf76b5ddcd17667d80fa935b7a91a]

        CppunitTest_sc_ucalc*: use CPPUNIT_TEST_FIXTURE()
        
        These suites are large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Ib24643438ecf52da1ba700522435f70e7ba2aa95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147590
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-24  Caolán McNamara  <caolanm@redhat.com>  [9ac308b99e37c228f2ef1cfa3e2b847ff7361f9a]

        crashtesting: null-deref seen on loading forum-mso-en4-399427.xlsx
        
        and others. A problem since:
        
        commit 8c9a6abf30e9ff1ebd5647f7c271e0d64643860a
        Date:   Thu Feb 2 20:16:04 2023 +0100
        
            tdf#138601 XLSX import: fix priority of conditional formatting rules
        
        Change-Id: I663b193c5bd7c5c92d3c423e70b0f7a24e3e5d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b9cc680162d441d6d99d726792d5f902f46e879]

        use comphelper::WeakComponentImplHelper for UITestUnoObj
        
        Change-Id: I4a3d75507791b1a313722adbdd9cd7cc7505ada6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147584
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [1909c23d669676e8411143eb2cc0bf0c2b22f7ca]

        BaseMutex->std::mutex in cairocanvas::TextLayout
        
        Change-Id: If45308a943104ed5a7f3ec2713bce5d68ee73485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0f05df76177174fce1d662b211b3047237debae]

        BaseMutex->std::mutex in sd::tools::PropertySet
        
        Change-Id: Iab6d9f3cb1c198f9f3ffd8ac556985cafb821787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147587
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b4b3f281443fc64b420156eed11af773f80a4e2a]

        Use just plain straight-forward params for UpdatePageFields
        
        - dont wrap parameters in a useless hint as superfluous indirection
        - note: SwDocPosUpdate receives a special kind of abuse here:
          * it is used as pNew with pOld being nullptr when send to the
            document field manager
          * it is sneakily modified to be the pOld when it is forwarded by
            the field to the frame via the node
        - full path of the message before this change:
          -> passed to the UpdatePageFields as parameter
          -> wrapped as the pNew there and send to the field types
          -> passed by the fieldtypes to the fields
          -> tweaked to be the pOld with pNew being the field itselfby the
             fields when passed from the field to the node
          -> passed from the node to the frames
        
        Change-Id: I084c3a1abe6871abdb82655cc413902dd16071cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147302
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-24  Michael Stahl  <michael.stahl@allotropia.de>  [0168e1eb65103afde24d4a2a62175946b1c0d33e]

        tdf#78510 sw: combine items from SwTextNode and SwNumFormat
        
        Tweak SwTextFormatColl::AreListLevelIndentsApplicable() and
        SwTextNode::AreListLevelIndentsApplicable() to return a bitmask
        so that SvxFirstLineIndentItem and SvxTextLeftMarginItem from paragraph
        or numbering can be freely combined.
        
        Particularly confusing was SwTextNode::GetLeftMarginWithNum()
        and its baffling usage in SwTextMargin::CtorInitTextMargin(); it
        appears easiest (if unintuitive) to interpret its return value as a
        delta to be added to the paragraph's items.
        
        This fixes the ODF interop problem.
        
        It looks like no compat setting is needed because every OOo/LO generated
        document should have either both fo:text-indent and fo:margin-left on a
        paragraph style/list level, or neither.
        
        Change-Id: If20b2556bb5ab5d915a2aa6633525bb44a9be33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147166
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-24  Michael Stahl  <michael.stahl@allotropia.de>  [db115bec9254417ef7a3faf687478fe5424ab378]

        tdf#78510 sw,cui: split SvxLRSpaceItem for SwTextNode, SwTextFormatColl
        
        Leave editengine and non-paragraph usages of SvxLRSpaceItem as-is for now.
        
        Add new items RES_MARGIN_LEFT etc., order them so that paragraphs can
        have 3 consecutive items RES_MARGIN_FIRSTLINE..RES_MARGIN_RIGHT and
        non-paragraphs also have 2-4 consecutive items
        RES_MARGIN_RIGHT..RES_MARGIN_LEFT (only the 3 paragraph ones are
        actually used now).
        
        The HTML import filter is particularly annoying because it parses CSS
        stuff into SfxItemSets without knowing where the items will be applied,
        so it can't know whether to create SvxLeftMarginItem or
        SvxTextLeftMarginItem... the split items are created in ParseCSS1_*
        functions and then converted later if necessary.
        
        WW8 import has some weird code as well, SwWW8ImplReader::Read_LR()
        creates 3 items and then something wants to set every item on its own
        so SwWW8FltControlStack::SetAttrInDoc() turned out rather weird.
        
        Convert the paragraph dialog to handle the split items (by mapping them
        to SID_ATTR_PARA_FIRSTLINESPACE/SID_ATTR_PARA_LEFTSPACE/
        SID_ATTR_PARA_RIGHTSPACE), but the SvxRuler looks a bit more confusing
        so convert in sw shells for now and leave that for later (also unclear if
        changing these slot items like SID_ATTR_PARA_LRSPACE breaks any ABIs?).
        
        Change-Id: I40431821868fd3e1cceba121b5539ff9ae6befbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147024
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-24  Michael Stahl  <michael.stahl@allotropia.de>  [7e7b69829db63e64b8aed8d03c6eaed6d8f1a27c]

        editeng: split SvxLRSpaceItem into 1 class per attribute
        
        The tricky part is that there are actually 2 different kinds of left
        margins:
        
        Those on entities that aren't paragraphs are simple, so class
        SvxLeftMarginItem is simple.
        
        Those on paragraphs are entangled with the first-line-offset,
        because there is a left margin value (same as for everything else)
        and a text-left-margin value, which includes a negative
        first-line-offset; the text-left-margin value is exported as API
        property so stored as-is in the item, and the left-margin is computed on
        demand (based on corresponding first-line-offset) in
        SvxTextLeftMarginItem::GetLeft().
        
        Separate classes for these is a better separation than what commit
        a0875d09d9eeb368e9e319f3f2f29ec3be71b56c did.
        
        (some functions aren't implemented because the SvxLRSpaceItem did
        nothing for these cases; not sure if that's intended.)
        
        Change-Id: Iae5cd4bf8167754eec65d2585430f5fe3d00839f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147023
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [afdee56418182b7250eb61269dd26cbacc56f87f]

        BaseMutex in AccessibleTableHeaderShape is unused
        
        Change-Id: I1ec01aa72446891aaacd9309ea6c67cc323b0d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [336cebd61de9d2b0f07d246a772098d01c305c60]

        BaseMutex->std::mutex in slideshow::EventMultiplexerListener
        
        Change-Id: Icdb38eb85a93cc285489372bbd80605bfcd36249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147582
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b31341d9382b62d99a4c1f801d63d031a47ffc3]

        BaseMutex->std::mutex in MinMaxLineWrapper
        
        Change-Id: Ibd03c7f736e9b2fdf97a7b3177d7d12fd85394fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce32856bfe51ee844f6374ba2161eae821f9df61]

        drop OComponentHelper in XMLFilterDialogComponent
        
        nothing seems to be using the aggregation here - as expected, this is
        not the kind of thing that is aggregated
        
        Change-Id: I8abc4f4db0dc9447e4018330bba86f3579bb21c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-24  Miklos Vajna  <vmiklos@collabora.com>  [78a158211b68a020512cd63a1f357f901f879e53]

        sw layout xml dump: extract SwRootFrame::dumpAsXml() from SwFrame
        
        Avoids an ugly static downcast.
        
        Change-Id: I6c6d3bc224d584b3102da1ba3980c83b67521ce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147578
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6d9b9d1228cdee69e767833202442a1fed6174a6]

        tdf#153499   revise tooltip; correct extended tip for "Index level"
        
        Change-Id: If7541390c8ee42ab3bf177e12670c9f983fd3e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147553
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1750cc99ccdca1ee9e5e25cc6ad9891d08f1e758]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a7c1500a74c7f5e136da4a70656d19c54f758092
          - tdf#153795  "Illustration Index" -> "Table of Figures"
            
               also some corrections in menu names in the Type tab
               and updating of example to refer to "Figure".
            
            Change-Id: I4529eeb8000021051a669ec0bfaeeadaa2c69f74
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147551
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab20dba30769a5a52830220daa347772485db6a2]

        CppunitTest_sd_export_tests: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I5b7ef05e16ec0d81acfc7288296849ab3b3973ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147576
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [9937d7cdde7de5ec7588c79f92a7508a3893c31e]

        SwModelTestBase: add selectShape helper
        
        See discussion in https://gerrit.libreoffice.org/c/core/+/147506
        
        Change-Id: If3f3b471d5053dbc1bf34383e64e9672d026aaae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147515
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [cacd5a0cd263dbf072d5ad36dc651ad1e7df5826]

        attempted fix for CppunitTest_sc_uicalc
        
        SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior include/svl/setitem.hxx:47:51 in
        =================================================================
        ==357324==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c001c9c340 at pc 0x7fa4bb883389 bp 0x7ffc2482f5f0 sp 0x7ffc2482f5e8
        READ of size 2 at 0x60c001c9c340 thread T0
            #1 in SfxItemSet::Get(unsigned short, bool) const svl/source/items/itemset.cxx:801:26
            #2 in SfxUInt32Item const& SfxItemSet::Get<SfxUInt32Item>(TypedWhichId<SfxUInt32Item>, bool) const include/svl/itemset.hxx:102:38
            #3 in (anonymous namespace)::getNumberFormatKey(SfxItemSet const&) sc/source/core/data/patattr.cxx:1291:17
            #4 in ScPatternAttr::GetNumberFormat(SvNumberFormatter*, SfxItemSet const*) const sc/source/core/data/patattr.cxx:1335:19
            #5 in ScColumn::UpdateScriptType() sc/source/core/data/column3.cxx:871:36
            #6 in ScColumn::GetRangeScriptType(...) sc/source/core/data/column2.cxx:2338:17
            #7 in ScTable::GetRangeScriptType(sc::ColumnBlockPosition&, short, int, int) sc/source/core/data/table1.cxx:2487:23
            #8 in ScDocument::GetRangeScriptType(sc::ColumnBlockPosition&, ScAddress const&, int) sc/source/core/data/documen6.cxx:189:32
            #9 in (anonymous namespace)::ScriptTypeAggregator::execute(ScAddress const&, int, bool) sc/source/core/data/documen6.cxx:175:31
            #10 in sc::ColumnSpanSet::executeAction(ScDocument&, sc::ColumnSpanSet::Action&) const sc/source/core/data/columnspanset.cxx:176:20
            #11 in ScDocument::GetRangeScriptType(ScRangeList const&) sc/source/core/data/documen6.cxx:206:10
            #12 in ScViewFunc::GetSelectionScriptType() sc/source/ui/view/viewfunc.cxx:898:24
            #13 in ScFormatShell::GetAttrState(SfxItemSet&) sc/source/ui/view/formatsh.cxx:2001:34
            ...
            #61 in main2() sal/cppunittester/cppunittester.cxx:483:16
        
        0x60c001c9c340 is located 64 bytes inside of 120-byte region [0x60c001c9c300,0x60c001c9c378)
        freed by thread T0 here:
            #0 in operator delete(void*, unsigned long) /home/noel/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
            #1 in ScPatternAttr::~ScPatternAttr() sc/inc/patattr.hxx:53:20
            #2 in SfxItemPool::Remove(SfxPoolItem const&) svl/source/items/itempool.cxx:805:13
            #3 in ScAttrArray::SetPatternAreaImpl(int, int, ScPatternAttr const*, bool, ScEditDataArray*, bool) sc/source/core/data/attarray.cxx:574:31
            #4 in ScAttrArray::SetPattern(int, ScPatternAttr const*, bool) sc/inc/attarray.hxx:148:7
            #5 in ScColumn::ApplyAttr(int, SfxPoolItem const&) sc/source/core/data/column.cxx:633:21
            #6 in ScColumn::SetNumberFormat(int, unsigned int) sc/source/core/data/column2.cxx:3282:5
            #7 in ScTable::SetNumberFormat(short, int, unsigned int) sc/source/core/data/table2.cxx:2278:35
            #8 in ScDocument::SetNumberFormat(ScAddress const&, unsigned int) sc/source/core/data/document.cxx:3739:19
            #9 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) sc/source/core/data/formulacell.cxx:2157:31
            #10 in ScFormulaCell::Interpret(int, int) sc/source/core/data/formulacell.cxx:1619:13
            #11 in ScFormulaCell::MaybeInterpret() sc/inc/formulacell.hxx:468:17
            #12 in ScFormulaCell::IsValue() sc/source/core/data/formulacell.cxx:2760:5
            #13 in lcl_GetCellContent(ScRefCellValue&, bool, double&, rtl::OUString&, ScDocument const*) sc/source/core/data/conditio.cxx:744:40
            #14 in ScConditionEntry::IsCellValid(ScRefCellValue&, ScAddress const&) const sc/source/core/data/conditio.cxx:1243:17
            #15 in ScConditionalFormat::GetCellStyle(ScRefCellValue&, ScAddress const&) const sc/source/core/data/conditio.cxx:1812:24
            #16 in ScDocument::GetCondResult(ScRefCellValue&, ScAddress const&, ScConditionalFormatList const&, o3tl::sorted_vector<unsigned int, std::less<unsigned int>, o3tl::find_unique, true> const&) const sc/source/core/data/documen4.cxx:828:41
            #17 in ScColumn::UpdateScriptType(sc::CellTextAttr&, int, mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::iterator_trait>&) sc/source/core/data/column3.cxx:865:30
            #18 in ScColumn::GetRangeScriptType(int, mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::iterator_trait> const&) sc/source/core/data/column2.cxx:2338:17
            #19 in ScTable::GetRangeScriptType(sc::ColumnBlockPosition&, short, int, int)
                sc/source/core/data/table1.cxx:2487:23
        
        previously allocated by thread T60 here:
            #0 in operator new(unsigned long) /home/noel/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3
            #1 in ScAttrArray::AddCondFormat(int, int, unsigned int)
               sc/source/core/data/attarray.cxx:296:32
            #2 in ScColumn::AddCondFormat(int, int, unsigned int)
               sc/inc/column.hxx:974:17
            #3 in ScTable::AddCondFormatData(ScRangeList const&, unsigned int)
               sc/source/core/data/table2.cxx:2967:43
            #4 in ScDocument::AddCondFormatData(ScRangeList const&, short, unsigned int)
               sc/source/core/data/document.cxx:4893:19
            #5 in oox::xls::CondFormat::finalizeImport()
               sc/source/filter/oox/condformatbuffer.cxx:1065:10
            #6 in oox::xls::CondFormatBuffer::finalizeImport()
               sc/source/filter/oox/condformatbuffer.cxx:1189:27
            #7 in oox::xls::WorksheetGlobals::finalizeWorksheetImport()
               sc/source/filter/oox/worksheethelper.cxx:942:22
            #8 in oox::xls::WorksheetHelper::finalizeWorksheetImport()
               sc/source/filter/oox/worksheethelper.cxx:1622:17
            #9 in oox::xls::WorksheetFragment::finalizeImport()
               sc/source/filter/oox/worksheetfragment.cxx:632:5
            #10 0x7fa4511cbf2a in oox::core::FragmentHandler2::endDocument()
               oox/source/core/fragmenthandler2.cxx:53:5
        
        Change-Id: I8d806fd410d1d3a9c06ab141b035153649cf7062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147513
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [d9865bd5276542ebeea8df79cc1724ae7fbbc2e8]

        Revert "Resolves tdf#146579 - Accessibility for statusbar icons"
        
        This reverts commit 3fffe54bb19e387b6b56ac897a7e9cf8ebcc18d6.
        
        Reason for revert: Rectangle makes the small icons even more tiny. Looking for a better solution.
        
        Change-Id: Iec2c5f03ec6ea14546b27eb530c43ad511b2ee19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147450
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-23  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [ea9a69c68670a4305fdf931e42bc20d008b393fa]

        Revert "Resolves tdf#152947 - Accessibility for save status icon"
        
        This reverts commit 9844064f252e8ec383d3c5bf24830acd868bb764.
        
        Reason for revert: Rectangle makes the small icons even more tiny. Looking for a better solution.
        
        Change-Id: I3161d488346305ee814884758f1d8679d64db07b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147451
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-23  Rico Tzschichholz  <ricotz@ubuntu.com>  [258f3412213954448e6af0fdc252b10ff76c7d50]

        Refer directly to static library files for Graphite2 and HarfBuzz on Linux
        
        Just using "-L... -l..." will cause dynamic linking if a matching system
        library is found.
        
        Change-Id: I9bc3ee1fb1351336f73c3c9219526749dffe546e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146907
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [46d489ccd6f8e24fefba25118de9a72b2602b656]

        CppunitTest_sd_export_tests-ooxml1: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I4b76afd0483957b0061326e584ccbb0d22650c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147509
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Tor Lillqvist  <tml@collabora.com>  [6f29310fe83873c7d6844cf5e3089ca981e147db]

        Don't call CuiResId() in a global static variable initialiser
        
        Instead, have a function that returns a reference to a local static
        variable. That local static is then initialised only when the function
        is called for the first time. Calling CuiResId() in a global
        initialiser is a bit questionable, and causes an uncaught exception
        when LO core is used in a WASM app. Possibly it would also have been
        problematic on other uncommon platforms.
        
        Change-Id: I4fd799ba3aa8d63fd3db1eb8cf6211aeed904ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147512
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-23  Miklos Vajna  <vmiklos@collabora.com>  [b352c9a79ce12daf8e38246993bc821944779b0a]

        CppunitTest_sw_uiwriter8: fix sometimes failing testTdf133490
        
        This usually passes, but if I have an other build ongoing, then
        sometimes fails with:
        
        equality assertion failed
        - Expected: -139
        - Actual  : 1528
        
        Fix this by doing a sync UNO call instead of async dispatch of an UNO
        command. Now this test passed for me 10 times in a row under load.
        
        Change-Id: I4f81d036c0edd3ec9467cd483238a1f32876dc50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147506
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [fce77173646392847055745c6342704eb6e500a9]

        tdf#153767: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I66f45e54249f48440c4145ff0e877abbac073a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147507
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [94cdbfb9316ab3b04327f960fa40aee07abbba91]

        MCGR: Adapted GradientAxial to make use of MCGR
        
        Added to make GradientAxial work using the MCGR
        as 2nd of six types. This one was complicated
        since it uses the gradient(s) 'reversed' when you
        look at it, from outside to inside. Had to do
        quite some tickeling to get it all work, but
        looks good now.
        
        For modifyBColor I Could re-use the started
        tooling as planned.
        
        To get the reverse usage working I ended up in
        1st adapting the previous usage to make more use
        of std::iterator and reverse_iterator to be able
        to use the reversed state of the ColorSteps more
        'controlled' as if trying to adapt the numerical
        indices to the vector (that ended in chaos).
        
        It is still 100% backward-compatible, so as long
        as there is no source using this it will stay
        invisible - by purpose.
        
        Tests look good with this one, see the static
        variable nUseGradientSteps.
        
        Change-Id: I0117ec9a24b5e55869b3e2741c67fb87b549db97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147510
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [bddc275d1e25b4d528e884179bac1b712f6c45a2]

        osl::Mutex->std::mutex in OleNameOverrideContainer
        
        Change-Id: Ieeeb8f51f4970cbe1214aea493409739a64ac561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147502
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [29d795b772cb75ee1d12cc6bcd4d905f1c520a79]

        avoid div/0 in getCutPointForGivenY
        
        Change-Id: I8e5e5689ee11777938ca7d0268b8e04e77466734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147496
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [11c69c57f045f364dd7466f49d9de5408b6a02b4]

        tdf#146518 Implement commands to toggle Watch/Stack windows
        
        This patch implements the new .uno:WatchWindow and .uno:StackWindow commands in the Basic IDE to allow the user to toggle the Watch/Stack windows.
        
        Change-Id: I0778b9fe8efcafbbf57da3cc437e6b156306021d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147305
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-23  Sarper Akdemir  <sarper.akdemir@collabora.com>  [9da4a2518eea880a2c80515d1346effa7c8c8c11]

        related tdf#148966: rework sdr compatibility flags
        
        Rework access/set methods for sdr compatibility flags so it
        is possible to address a compatibility flag without directly
        interfacing with SdrModel.
        
        (preliminary work for exposing compatibility flags to
        editeng)
        
        Change-Id: I2fab219f9e125151916228300be2d9d88156d8a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147407
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [37751d878b87765a4d2cfb50d0a39280c585ece1]

        blind fix for crashes in RegressionCurveCalculator
        
        if mPeriod is < 0, then we could crash in calculateValuesCentral
        
        Change-Id: I554b46ed7bf5b5b0a32fcf69829aa1c2c75833f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147508
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [12c00caa3d017116ba29801578f1bd42b111824a]

        unlock during dispose in configmgr::configuration_provider::Service
        
        Since the code that can run during flushModifications might manage to
        call back into Service..
        
        regression from
            commit a61951a3a21c6457334f78f657806c1167dbf339
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 20 20:08:30 2023 +0200
            BaseMutex->std::mutex in configmgr::configuration_provider::Service
        
        Change-Id: I0070e7589cdea38905de6c68adefd8081b122152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [e176e7a5eafa11df9ad5a9948724a4b6102798d0]

        CppunitTest_sd_import_tests2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I14d1ace4ffbcb888e30a51b24116ed8c7e90fcba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147479
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [208a5511d786036ef4428586e441e17f280a9f11]

        tdf#153499   "Level" -> "Index level"; add/revise tool/extended tip
        
        Change-Id: I854a6514fb78288b62816170624676e4017b73a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146988
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a9425af92bef565f162d362c94433cc0d053789]

        make B2DPolyPolygonTest deterministic
        
        Change-Id: Ia8071285d70b39b21b1312d461dc8d502d5cb305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Noel Grandin  <noelgrandin@collabora.co.uk>  [0e123c297ac3a6b4ea98af6834ddf847ce0a4fc5]

        fix test for non-default DPI
        
        Change-Id: Id3b39535ae18a5b38e57d9cacb7e3662a9c3468c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5de206e549e4b2f8905b14ff0939055cfa2fac1e]

        ignore bidi-chars warning in callgrind config
        
        gcc from devtoolset-11 would complain about
        svx/source/tbxctrls/layctrl.cxx:        aText = u"\u202D" + aText;
        
        See also https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585777.html
        
        Change-Id: I040371673dd8d5e023092c53791e9b666bace7a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147511
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-02-23  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [a10d0ce37be8a9f7fe4270d8b4d61567a9418c24]

        refactor SwFormatField again
        
        - strip out some helper functions
        - split of the "forced update" special case
        - extract ensuring user fields to be valid
        
        Change-Id: Iee9aa5b25ab7d8e7c102f0c0950c47a46966bb19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147269
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-23  Heiko Tietze  <tietze.heiko@gmail.com>  [80a0d8a727da6c6f524debc416b3e2e8d37feffe]

        Related tdf#152880 - Rename DatePickerFormField
        
        Distinguish this 2nd generation control from all "content control"
        from 3rd generation
        
        Change-Id: I29c9087e1042fc7c7c920235866fd25f9522538c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147501
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-23  Miklos Vajna  <vmiklos@collabora.com>  [2da16ff9f018fae68c53a801e5a234dafc2ebcec]

        sw floattable: teach the ODT filter about SwFormatFlySplit
        
        Map the IsSplitAllowed text frame property to <draw:frame
        loext:may-break-between-pages="...">. This is meant to be always a
        direct formatting, so doesn't go to the style / autostyle.
        
        Change-Id: I439fe372271e4b7db511b5e2150e2a3c2e0acf25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147499
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [988cdcc18610300dd389e0efc25553e6c1bcb19e]

        CppunitTest_sd_export_tests-ooxml3: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I44dd326d2fa9d306bb187148121e5c50718650d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147480
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f9300c3521206ab9591788a96dc97f60586d03b2]

        CppunitTest_sd_export_tests-ooxml2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Icc071e2bd1e6c0867d0e7dd22b7dbb3b7921f12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147483
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-23  Miklos Vajna  <vmiklos@collabora.com>  [7897143a7313c57aed262826b736619bf9432b48]

        sw: fix undo comment of FN_DELETE_TEXT_FORMFIELDS
        
        It's deletes, not an insert. One has to dispatch
        .uno:DeleteTextFormFields to see this in action.
        
        Change-Id: I7c5afa6acc633e0d0a750d97ff6477b9511e816c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147489
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [228caa2bafe214a0b502db4ac288dd70169ac2b8]

        tdf#151745 Fix input line redraw issue after resizing calc window
        
        Change-Id: Ia8a7e1ab6b68f10f19733d8ce7f36d9ea02d4785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147352
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a2732de4bd080e3ed8894ba3618f48bc4c6d9abe]

        tdf#153640 Fix changing chart background color back to None
        
        Change-Id: I653028d6016ca0caa72cb2a877cd23592c322a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147351
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-23  Stephan Bergmann  <sbergman@redhat.com>  [dc96de7c62e1e6f37ec485f3f0f564a00f3d01f4]

        Extend loplugin:cppunitassertequals to more argument types
        
        Change-Id: Ic2990ebc2e4a9a36dcd3f90c5f634ca7dd225d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147491
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-23  Noel Grandin  <noelgrandin@gmail.com>  [6d404f9ccad3ac6a7ffb83876ae7a656bc2d4547]

        make create_virtual_device not use a separate alpha layer
        
        so that the gtk and the normal path do the same thing
        
        Change-Id: I69bb7be98e5834b0f20db66a67b3c37cc9d09676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-23  niket1322git  <niket78766@gmail.com>  [e4fb37353e2f9f998c028319c5fa083bf3eaa4cc]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I3d3c34f5f131578c7208c12462f03efac357fa05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147484
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-23  Eike Rathke  <erack@redhat.com>  [05ac57f85eb622b798719db03bbdd07b79e1703a]

        Resolves: tdf#153767 Try harder to import OOXML bool shared formula result
        
        ... by setting the result value or if necessary recalculating even if
        AutoCalc is turned off for the document. Similar for other implicitly
        recalculating formula types.
        Also set a boolean number format if none.
        
        Change-Id: I2f75735707180eccf4b2c525738ac0b763901230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147425
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e5a744851cb58da1ceeef623799274d73b60b030]

        tdf#153561 rename "chapter" to "heading"; update/add tool/extended tip
        
        Change-Id: I84cde8117d7eafa4b8656b5b17347a4bd255409e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147369
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e54838a5f8629226dce0498a5ec178ca5e03b886]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac82657672e6d9867e4d8560536e241ca4814da6
          - tdf#153485   Update "Outline level" -> "Show up to outline level"
            
               also improve command description
            
            Change-Id: I5ce25e704688c0af4c659066d4ffb339a01bce7e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147443
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-22  Justin Luth  <jluth@mail.com>  [dbbfcb7e098c1c16f932785ef62ef7d3d819ad1a]

        tdf#153526 writerfilter: catch exception from no NumberingRules
        
        This fixes a LO 7.5 regression (well, exposed some other flaws) from
        commit cf02b94bc513ee1b742b4c5d7174632b568e8b72.
        
        I first tried testing if hasPropertyByName,
        but that returns true(????), even though this is an editeng component.
        
        Well, ignoring the fundamental issues at play here
        (and there are many - like having a comment
        take over m_xPreviousParagraph)
        the issue is easily solved with a try/catch
        instead of a redundant if clause.
        
        Change-Id: I4f27fce3e2984235df19dc3ed4be558891b28a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147486
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [681f8e6e97ec45de3305e2056ccd8415582ba705]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c9e84e0aa79ec1ddeae1e53d1bf70920bb85d896
          - tdf#152977 correction to description for "Individual Words" attribute
            
            Change-Id: I277b6dbce5eb2d8812a5fb51693cf2574704a47c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147442
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7df725eda3330d62da204a95a177df1ae5b11f73]

        (related tdf#153417) rename "Back" to "Reset"
        
        Change-Id: I70c79f7a40889bcca3aed3d2309779091967a2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146532
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-22  Khaled Hosny  <khaled@aliftype.com>  [5899b27e71430e490c2d3a6b87ae52c10f383ba7]

        tdf#151968: Fix vertical position of RTL spelling wavy line
        
        The code was guessing orientation based on the start and end points and
        mistakenly considered Arabic text to be 180° rotated which ended up
        raising the wavy line above baseline and covering the RTL text.
        
        Use font orientation instead of guessing it. Caching wavy line seems
        broken with RTL text as well (it was skipped for RTL before because of
        the wrong guessed orientation, so probably never worked), so we skip it
        explicitly as well for now.
        
        Change-Id: I4b0f5c4d6be2c6e3d33ea79b917b14927374acfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147488
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [131da4cce6e0ede110f7276e0f67c8742a69c380]

        CppunitTest_sd_import_tests-smartart: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: Ifa52525ffd75328282182f0515fb142c7e1b4918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147478
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1e12a4cc980ebabadde592d3159b93cc12e733a7]

        update credits
        
        Change-Id: Ic974dbd48cb9b1b2e417430325e4611a66d1aa7c

2023-02-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [76f34550503b841f7adc1f9ba94ee27ae102d409]

        Update git submodules
        
        * Update translations from branch 'master'
          to 70a23c0afa2982325334d4c9975a501e4b9a13ce
          - update translations for 7.5.1 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I275b498852041a5f928c0df95c2ad50fc2256013
            
2023-02-22  Tor Lillqvist  <tml@collabora.com>  [d24b80c783746041b1ab838b2038aebc0c68a470]

        Fix --disable-scripting build (for example for WASM)
        
        Was broken by ccd0ef98f76011f108f8ea1d282b96386dba0a6a.
        
        Change-Id: I37f3cf14e14ca32919d54f3d0cddbc042c2a7056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147463
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-22  Julien Nabet  <serval2412@yahoo.fr>  [e4e2c842b7a9c2112e4ac2769efae16eaba45d8c]

        Typo: interpets->interprets
        
        Change-Id: I9644a90a4dcbf1d207d7a7994eb9e79733eff0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147485
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Colomban Wendling  <cwendling@hypra.fr>  [c75e975a20258650baa6c906ac8cc1bc4e8f6244]

        toolkit: Port AccessibleStatusBarTest to test::AccessibleTestBase
        
        Now we have test::AccessibleTestBase we can use it instead of
        performing some setup operations manually.
        
        The only actual change is that we don't pass OpenFlags=S when creating
        an Impress document, but it never seemed useful (it was only ported
        from Java out of zeal), and I can't even find what the S option is for.
        In all cases, this doesn't affect the tests themselves.
        
        Change-Id: Ic8d56dd9bc3ec957891868b23bb241ba3bf33049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147003
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [27a454359a0d57de872bc110d6e88d5e51f26202]

        tdf#134862: sd_export_tests-ooxml1: Add unittest
        
        Change-Id: I72c293c6d1a5337a6460bfbd8846c6be9a33626a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147465
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-22  Julien Nabet  <serval2412@yahoo.fr>  [94a1d9a4c17e5d578e10eee1a7f14a604305209e]

        Revert "Fix typo"
        
        This reverts commit 2ef3c9bd49262f8e3875d0b829674d5487e5bea1.
        
        Reason for revert: inset is correct (see Regina's comment in https://gerrit.libreoffice.org/c/core/+/147476)
        
        Change-Id: I378422918c621c43f74260f244843a3246464103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147439
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [f07b4c242c8768b8a361d0aa551ba2e0c2d8eed2]

        CppunitTest_sc_subsequent_filters_test2: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I95b689d9f4af2d7865009c7313df294b143ce4af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147469
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eb02804b621cd51922fa3a3bd812fc40e47c1951]

        Fix typo
        
        Change-Id: I0c674d1da4f3e6a9c13b28843fceb0e9bfff93c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147473
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [894b1a8b226e562a7aa38032cf56b1600f011805]

        Fix typo
        
        Change-Id: Ibb51b7ea2a404156459fb7454e5260d0375fc842
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147472
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b2eb17829a8da7828cdc60f262991aafda84f3ea]

        Fix typo
        
        Change-Id: I17aa944a68ac80f67034cc92fca3f7531e0d5385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147475
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2ef3c9bd49262f8e3875d0b829674d5487e5bea1]

        Fix typo
        
        Change-Id: Ib6c9ed0f7a0f2ed65c0c27a4959bb7bf317e162b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147476
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4e2cc5ff38470719ebfca6acd527e399f1148628]

        Fix typo
        
        Change-Id: I3e8fcc5135fb5adfa9f043233ca628f244ea35f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147477
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a2d61d9ff7cb7e0e0a0cb97d606a3b43a518704e]

        Fix typo
        
        Change-Id: I9bfdabcb7ba99c9e64dfc36aadfea8f6de02058b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147471
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3d95141d6350a63c09f190639c435136b20a8936]

        Fix typo
        
        Change-Id: Ib61d53a7f48057a7b63d9c0f2e473ea763badaf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147470
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f80e93a4241091ef1686e3850cd11c2b25d99b71]

        BaseMutex->std::mutex in ConfigFlush
        
        Change-Id: Ia8c5d5cc6ea52ed385ae4ea3e860f2cc88d06377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [28e7502be32f76ff20a38b644e29f1d6c40bbe24]

        Related tdf#129905 Add new .uno:SectionBoundaries to the Notebookbar
        
        This patch adds the new command .uno:SectionBoundaries to the notebookbar interfaces.
        
        Change-Id: Ib01b8221e3015c460f6b7cc0cdac3c7ddd4aab1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146785
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [943b8b45d80e295b1333fdc28bc8cf7ca8f95902]

        tdf#153572 Implement .uno:ZoomPlus and .uno:ZoomMinus in the Basic IDE
        
        This patch implements the commands .uno:ZoomPlus and .uno:ZoomMinus in the Basic IDE to allow the user to zoom in/out of the code editor. With these commands it is possible to create a keyboard shortcut for zooming in/out.
        
        Notice that this patch only implements the commands, but it does not create a default shortcut, since defining which shortcut should be used needs to be discussed first.
        
        Change-Id: I02866b9e731bf23181d0ecfc32f978ec110e33f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146841
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-22  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [5b7e54ce8fb57203068f1c2e610758523687ef9a]

        tdf#63965 Hide one extra Rename Sheet command from Customize dialog
        
        from sc/source/ui/view/tabvwshf.cxx:
                        //  FID_TAB_MENU_RENAME - "rename" in menu
                        //  FID_TAB_RENAME      - "name"-property for basic
        FID_TAB_RENAME is not meant for the menu - it also just showed
        the sheet name when added as .uno:Name
        
        Change-Id: I2ed7b51bece688e50260e639012b9b1b68cf5df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147222
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [5032262fccd0ef7f274323ae481b3230ffd42d3a]

        BaseMutex->std::mutex in PopupMenuControllerBase
        
        Change-Id: I26877ac7b6e5e39f511418d978199189c62cca6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [47cd9b65efa662719950866ab9c45fb3f130e1b4]

        fix deadlock in xmlhelper::Databases
        
        after
            commit 2c37a0ca31095165d05740a2ff4969f625b4a75b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Feb 21 15:35:20 2023 +0200
            osl::Mutex->std::mutex in xmlhelp::Databases
        
        Change-Id: I3cce9bcd9c6c9d55c5162fdfd351048d16574477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cfe7f23efb97f6b42dcb1589b3d66d4b881092d]

        create new OPropertyChangeListener2 and use it in FmFieldWin
        
        create OPropertyChangeListener2 as a modified copy of
        OPropertyChangeListener which uses std::mutex instead of osl::Mutex
        
        Change-Id: Ic6be1c62992749e4f0dd23a8c95de63dc45eba3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147430
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f49d8ad7a520975f611023f77f3fc9c0e32ed77]

        BaseMutex->std::mutex in ListenerMultiplexerBase
        
        Change-Id: Icd565c83ca3b4afb1a846a637b7943b0498487e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fce44263b6b59a720dfebb1643430339dc3959f6]

        (partial) tdf#153722  "Chapter Styles" -> "Document structure"
        
        Change-Id: I1cb7e1bcf0d6ea6fc3906b51c6e844d39889a2ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147371
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5f6f7ed874f1c8ee655875e0ea3880940fc68bfc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 48e0b7962fdcfd46f8754ffa6c15dc149719f523
          - tdf#153204 Draw reserved layer names
            
            Change-Id: I04c428952d347cd584d283d64d4853e97f975889
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147428
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5979d758722eadc05f456da7024e4b116c770f6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5639f320e16619cd9f5b099752317eee10973125
          - Add links to wiki for Calc Functions (part)
            
            Change-Id: I454e60818fb30d154653d7ba2d343f72dc2f8581
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147427
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [96e27b13436b7796b838a7317de3de9e07333497]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36d7838ecf321f5053559878d0b922cb384af1ad
          - Refactor headings of calc functions files
            
            * Adjust headings
            * reduce clutter of embeds (WIP)
            * Note: this patch should not trigger retranslation
            
            Change-Id: I4c87f59ebc1377ea4f487bcf0efc98f83caf64cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147409
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [bdeda4385df297cd6cbd90497d9cd6ce95103ae4]

        OPropertyChangeListener::setAdapter can be private
        
        Change-Id: I5b849babe365300d1b6443caaacce45f4c7bf7c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [abdb918f146ceb6ea7d310968a96cdeb6f801a8f]

        tdf#142942 Drop unused checkbox col in sw AutoCorrect opts dialog
        
        While the extra checkbox column enabled by
        
            weld::TreeView::enable_toggle_buttons(weld::ColumnToggleType::Check)
        
        is used for the non-Writer case in the "Options" and
        "Localized Options" tabs in the AutoCorrect options
        dialog, they are not used in the case of Writer,
        where there are two columns of checkboxes handled
        separately ("[M]: Replace while modifying existing text"
        and "[T]: AutoCorrect while typing").
        
        Before
        
            commit 714b2b617e9baef02510c482c6fd028e6e72acd8
            Date:   Tue Jun 30 15:03:31 2020 +0100
        
                tdf#134270 rearrange so we know the final treeview width
        
        , setting column widths manually by calling
        `weld::TreeView::set_column_fixed_widths` would disable
        the extra space for the (unused) checkboxes (by setting
        `m_bDisableCheckBoxAutoWidth`).
        
        Since that commit, it no longer does, causing the
        separately handled real checkbox in the first visible
        column to be unnecessarily positioned further to the right
        in this dialog for Writer for the non-gtk case.
        
        Fix this by dropping the use of the unused
        checkbox column for the Writer case, i.e. the `bShowSWOptions`
        case in `OfaQuoteTabPage::OfaQuoteTabPage` and
        in `OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage`.
        The handling for the non-Writer modules (i.e. `!bShowSWOptions`
        case in `OfaQuoteTabPage::OfaQuoteTabPage` and
        `OfaAutocorrOptionsPage`) remains unchanged.
        
        Change-Id: If7bd216fc4efda506817cffb55230722bb2ac89b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147454
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-22  Miklos Vajna  <vmiklos@collabora.com>  [3a8ecbc70320151cb7dde7d8f89dee67a7c6e3e5]

        DOCX export: move the bulk of the table export code to a new file
        
        docxattributeoutput.cxx was already more than 10k lines long, which
        means it's really slow to recompile it, compared to other files in the
        same directory.
        
        Split out some of the table handling functionality into a new
        docxtableexport.cxx, so touching that (floating) table code has much
        improved rebuild time when developing.
        
        Change-Id: I4fe94a572ae8f684c78799dedbaa346d9a1bdae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147455
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1d3a0f8ec2107da739f50ae0606d176c28a32d0]

        BaseMutex->std::mutex in canvas::CachedPrimitiveBase
        
        Change-Id: I9f7c23a4880ea09f3c9a98ad7d27b27bf35483ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147421
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [24b3e4a5ba91d604ab68f49347ab065edaf48218]

        BaseMutex->std::mutex in ChartDataWrapper
        
        Change-Id: Ieee3fc918a5a3acdb19a1d95c475d225e6d90355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Miklos Vajna  <vmiklos@collabora.com>  [e7be3b821cd42fdc9d8e51772b8202030d76497e]

        sw floatable: teach the DOCX filter about SwFormatFlySplit
        
        - stop creating a grab-bag for floating tables in the DOCX import if
          split flys are allowed, which gives the exporter an opportunity to
          actually read the doc model
        
        - extract that code that writes a <w:tblpPr> from a ww8::Frame to a new
          CollectFloatingTableAttributes()
        
        - in case a fly frame has a table and the fly has SwFormatFlySplit=true,
          then call CollectFloatingTableAttributes() even without grab-bags
        
        - in the unlikely case that we would have both a split fly and a
          grab-bag, ignore the grab-bag
        
        With this, we get a working DOCX export for multi-page floating tables.
        The import is still disabled by default.
        
        Change-Id: I601833c49f49f94e1ff3cdc994e3027ee0542b94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147429
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a60fcb15046a60fa35fc4ea07d1411bf3563fe2e]

        osl::Mutex->std::mutex in OSQLParseNodesContainer
        
        Change-Id: Ie47589a454799494bc150eec1e135c8948eb7fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147420
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c37a0ca31095165d05740a2ff4969f625b4a75b]

        osl::Mutex->std::mutex in xmlhelp::Databases
        
        Change-Id: Icaf279275c35abbfd6408807729030f82fc5d753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c4f252035cd71f9a1b226e69095cc9f4e8f19f3e]

        MCGR: Adapted GradientLinear to make use of MCGR
        
        Added to make GradientLinear work using the MCGR
        as 1st of six types. Had to do quite some tickeling
        to get it all work, but looks good.
        
        Five more to go, already started to put some things
        to tooling to make re-usable for the other types.
        
        Besides adapting this the main change is that the
        adaption of defined step-count (versus automatic)
        has to be done in modifyBColor now instead of the
        back-mapping methods (e.g. getLinearGradientAlpha).
        
        It is still 100% backward-compatible, so as long
        as there is no source using this it will stay
        invisible - by purpose.
        
        I started to do quite some tests (and fixes/
        adaptions in consequence), see the static variable
        nUseGradientSteps. If you want to play with this,
        you might set it to '1' instead of '0' and use a
        linear gradient on an object.
        
        Change-Id: I9d61934defb0674456247f2879f0a89b6a5e50f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147413
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c14b1ba0d560c1de120d2562da6b24db9802149]

        LOAD_IMPLICIT has been active
        
        since
            commit c847b9430e26f98664f42c8fd4c28dc0433174b2
            Author: Oliver Bolte <obo@openoffice.org>
            Date:   Thu Apr 29 12:38:50 2004 +0000
        
        Change-Id: I496e5d52fae29274e4782f700dc391a86a50eb72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Khaled Hosny  <khaled@aliftype.com>  [a881850d5828dba3a19f2d53c995e9610d6d87b1]

        vcl: Avoid the need to patch HarfBuzz
        
        Reverts parts of d552b4a549d614a03aa9328e017dec27bd3ff41e and
        97e2e73e87479a742b798f362eda4baafb89497c.
        
        Instead of patching HarfBuzz, lets make use of the already mmap’ed file
        we use with FreeType.
        
        Change-Id: Ia81222118162a30cadb8c988bc477ad3ce36166d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147410
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-22  Tor Lillqvist  <tml@collabora.com>  [1aa37ca99112c0760552600d7774ba7224581c5b]

        Extend LOKit API with functionality to extract a request and paint thumbnails
        
        Original author was Mert Tümer.
        
        Change-Id: I181a9955bcce1d5ee4c81e2a52445ef318dc4823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147396
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [bdc4dc93a9edd5f46bdede12514ac5f66bf43167]

        BaseMutex->std::mutex in CommandDispatch
        
        Change-Id: Ic73a84eb793d45e1041698e45e2c844a1e2f2f66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c060e7851bd6238ad6f4bdf0997c958c561cf8cf]

        osl::Mutex->std::mutex in BaseContainer
        
        Change-Id: I66fcebb897446a5839ebde03e8e0a91d75a5e57c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc0654cab158b73124cb9e079753482693f0bd5a]

        BaseMutex is unused in ErrorBar
        
        Change-Id: I5e0890fcefedeaef4a8276c187d1604f8f96d23b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147414
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1c3a54c03764b87048e1ebff758b20be132378f]

        simplify ScAccessibleContextBase
        
        no need to use two different UNO base helper classes here
        
        Change-Id: I3aa89bf64fbd1b1d12f6c2a125ae36483899e82c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Regina Henschel  <rb.henschel@t-online.de>  [b94336ac3d29180504e4bd7ada4d29ed5b6d3fda]

        tdf#51195 Improve DML export of Fontwork shapes for docx
        
        Fontwork in Writer has fill and outline as shape properties. The 'abc
        transform' in Word uses character properties. Output of character
        properties happens in DocxAttributeOutput methods in LO.
        
        The patch modifies the character properties of the Fontwork shape,
        in particular the contents of the CharInteropGrabBag, so that
        DocxAttributeOutput produces a reasonably suitable markup.
        
        Change-Id: Ic9285d9a4d6dc21cd256e448ace058f1026a2780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146964
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-22  Miklos Vajna  <vmiklos@collabora.com>  [63784053ccd321c8f3fc7fe60f4e50fda597f553]

        CppunitTest_sw_htmlexport: remove magic SkipImages name handling
        
        Now we call setFilterOptions("SkipImages") everywhere explicitly, so
        preTest() can be simplified.
        
        Change-Id: I4c01f93bae2d9a4a31f3fff82911df4c683b862b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147422
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [3950df2b87f4657f196d56828a782e66c86ff790]

        osl::Mutex->std::mutex in SfxDocTemplate_Impl
        
        Change-Id: Iaf1530a34841ca1140599cea6d941aa2200ade66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147326
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [e171af99c0ed9c0e680c9fb95340f6d8535978e9]

        osl::Mutex->std::mutex in ResultSetBase
        
        Change-Id: I6f0afa46ad84782c3f7219bcb1b28d5627063bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c41e872ed248f804249ecf4d65c4afc2e426e329]

        tdf#105628 change "Evaluate" to "Show" for Chapter Number
        
        Change-Id: I64ac9d8957fe3ca8cbb50a0d4728ed9e127b2301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147365
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [026d49e3ccd1c002fc81e44631175d0191f61561]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9cbd8e356084c3d4b384315b6687b94080dd79b
          - tdf#105628  "Evaluate" -> "Show" in option label and update description
            
                Update "Evaluate up to level" and its description in
                Alphabetical index (swriter/01/04120222.xhp).
                This change gets embedded into the "format" section in
                swriter/01/04120221.xhp, and the "format" section gets
                embedded into other relevant "entries" pages.
            
                some refactoring in swriter/01/04120221.xhp
                refactor swriter/01/04120223.xhp
            
            Change-Id: I48c45f3ebd969f02ee73ef3b3a5c9e590660496c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147366
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [d52b97175b02745c1d9afab03256419bbebdf48d]

        qa: call ProcessEventsToIdle inside dispatchCommand
        
        Change-Id: I909e6f334f4a659282141a97ccb3ffdea6ecc364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147397
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-21  Jim Raykowski  <raykowj@gmail.com>  [88e29df0c216c300b9388ee2822003da2bee8679]

        tdf#152921 add uitest
        
        Change-Id: I6d3e6d8503c23549b04f5aaace6a90de9f3ced5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145522
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-21  Caolán McNamara  <caolanm@redhat.com>  [b05104facac18f40f34043be304f616530fc3a22]

        Resolves: tdf#148047 don't move focus if dropdown is active
        
        a bit of a corner case, for the popover gtk sets the focus in two
        steps, one to null, then to the final widget, not in just one step.
        On seeing the interim null case we assume that focus was lost and
        set it to the parent, which causes the popover to be dismissed
        while it's still appearing. Workaround this by ignoring the grab
        to parent while the popover is active.
        
        Change-Id: I1bdef51731bf714de2df93fbe6694e9ed3e366d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-21  Caolán McNamara  <caolanm@redhat.com>  [87d756f3f5dfb55ee9edbcd5349f8107ee5945eb]

        tdf#142783 consider the Calendar Edit and DropDown as one compound control
        
        for the purpose of notification of loss of focus from the control
        
        Change-Id: I9191b413978549c6f8e1775dc96a696059150e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [53bcb6c42fcb6f9ca6bf568a965c99d6c2b5ffb5]

        tdf#153352 Use Promote/Demote in Tabbed UI instead of Increase/Decrease indent
        
        As discussed in the ticket, the Tabbed UI of Impress/Draw uses the "Increase/Decrease indent" commands (.uno:DecrementIndent and .uno:IncrementIndent) which is confusing for the user.
        
        When the user clicks this command, they want actually to Promote/Demote the list level, so instead we should use the commands .uno:OutlineLeft and .uno:OutlineRight here instead. This patch makes the Tabbed UI more coherent with the sidebar, which uses the correct commands.
        
        Change-Id: I070b52e6fb31d348b1dd97c0ba28911f6e73590a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146705
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d020dfe1439e963f0b2367ba984c2eb6eb153a5]

        tdf#153728 Can't assign macro to autotext
        
        regression from
            commit b8f932e1df1efb230230ab1f1b9c8cfc822a0f4c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jan 9 12:01:55 2020 +0200
            convert XMLAutoTextEventImport to FastParser APIs
        
        Change-Id: I924c2c95a258917b0003171b71c23a65a6b623d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f158508a4bea01ff47dacbcdd21ad1bca026721]

        BaseMutex is unused in LabeledDataSequence
        
        Change-Id: If6f5a6e2954e28008c8c690557f15124452c05d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [02b3a672cf954f7e001e309aa2f182da58c503c6]

        sw: simplify test a bit
        
        Change-Id: Ib565e304b1067a8bca04efa323bb8d1789b1cd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147406
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a1a303291ef5500932cac4981d910f9aebfb606]

        osl::Mutex->std::mutex in PresenterTimer
        
        Change-Id: Icd6b6268792119541761a5e94600d8bc9e183ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [546ad5d17d3e363b75337c336cfb2b2f8acc55e3]

        tdf#143660 Make color scheme names translatable
        
        The color scheme names defined in UI.xcu are currently not translatable.
        
        This patch makes them translatable by mapping the names in the UI.xcu file to a translated string.
        
        Change-Id: I10ab3bbcc9b028955c3c179558f8040b3b1d6c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145732
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f9f45936cf99e787ab7558abc1ddea832cf05253]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f7b5afe0b04aabf7d1fb26b9c825def3123506e
          - tdf#150164  corrections to "Export bookmarks as named destinations"
            
               Thanks to gabriel.crabbe for technical guidance.
            
            Change-Id: I026dd2311134e69c6320a4bbb99c91defd1a1b53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147274
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0020562f55401bde7a497be8dbfdefdf138a06ca]

        tdf#150164  PDF exports bookmarks as named destinations
        
           partial revert of c42dc1be0c3161e621ed0a667ae6b047f8bb23d4
        
        Change-Id: I01fa72faf6365d0f999872562aaaa6139ed61d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147133
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-21  Michael Stahl  <michael.stahl@allotropia.de>  [538975a0e511ad79a7dd3c71300b993d1554cd03]

        nss: upgrade to release 3.88.1
        
        Fixes CVE-2023-0767 CVE-2022-3479
        
        Change-Id: I688dc7d0785ed3344c33e331c7e9ef37baa720ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147387
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [6cb076f6b08668cf2a0490fe17ce34e74969702a]

        sw: check GetWrtShellPtr()
        
        Change-Id: I8d99e9108f6163eafb7576603826f8d02a0ff416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147336
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-21  Caolán McNamara  <caolanm@redhat.com>  [b428a97d88b08fadd63039482c09c17a5fbac3be]

        Related: tdf#152508 and tdf#132110 use initial child size as size request
        
        tdf#132110 works with this, and might be a better solution for tdf#152508
        which doesn't have an explicit reproducer, but describes a similar
        problem.
        
        Change-Id: Ib9c39489fe37b77d6b905b891b975d2ab0d77289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [b767398f33f91f53f65ab2822ee667b59589e162]

        qa: use dispatchCommand from macroTest
        
        Change-Id: I135bdcf6b93a38d7ee746234462736b0868c9017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147395
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-21  Stephan Bergmann  <sbergman@redhat.com>  [e0228eb8a15127af0bc6eed3b60333265dc4d697]

        Mark recently added external/cppunit/*.patch.0 as upstreamed
        
        Change-Id: I62c62ee6fbd8ec6bf1846cea305ab97d4e567ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147385
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-21  DowwdyJ  <joeldowdy12@gmail.com>  [ac0e3e11d14d31b66e0f9a08f96d0233ec55951d]

        tdf#152850: Fix bad scoping of MathML frac command
        
        Change-Id: I4f5d0290e522fa6f3faccd26f74540abf848629b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [00194781efcafa231ac53ba26c84e2df847cf5e7]

        fix locking in configmgr::configuration_provider::Service
        
        a mistake from
            commit a61951a3a21c6457334f78f657806c1167dbf339
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 20 20:08:30 2023 +0200
            BaseMutex->std::mutex in configmgr::configuration_provider::Service
        
        Change-Id: I59c670ea7bffacb9dcd1f073b5da2439c2102a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Caolán McNamara  <caolanm@redhat.com>  [9c978e4c75e342b2345ff4fcbd1b5751627d8baf]

        Related: tdf#132110 use the container child size as default size
        
        if the container size wasn't changed
        
        Change-Id: I0bd4843768b727b8b75cbcb7ec92bd2b501b550d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147382
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-21  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [9dd29fce292fbcfee9c5cc93d9b1de5b14aa85db]

        replace RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED with SfxHints
        
        Change-Id: I8342722dc4235508c86683fd292bd525247a9910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147134
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [36aa1dce8068ae18a130cbe25e906e891b318447]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8ef7f32823c288de63b2b1b8bc9dd151dfa78217
          - tdf#98153 Clarify command line filter names (--convert-to)
            
            Change-Id: I0e6fa1872f2701527ac2875f6ccbadc0fc071fbb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147394
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0ae05219804be34dd6b3a12e7c5c179fb3564462]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c8071abcee17fda8cbea1c94353cbb9ce9b4a3a
          - Small formatting issue.
            
            Change-Id: Ib2cd61334953d9302cb431a1a6af96eb394bd696
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147358
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb11a07c4891412b48de00105d13d18241916506]

        osl::Mutex->std::mutex in FmSearchConfigItem
        
        Change-Id: Ic7d805f05f906a1f61ad958d33de0102d6835a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2c22a8ca6e04779c4daada73003b03c963b4cfd]

        osl::Mutex->std::mutex in FmXGridPeer
        
        Change-Id: Ib0796a86f864ab0a1a1b99183668f486a8a8f198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147381
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d56b6e0904c276e9a9ea63eb226e6324422c21c8]

        BaseMutex->std::mutex in JobExecutor
        
        Change-Id: I7be392f3023cf188bd6115053dcb1691b32b3e4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a61951a3a21c6457334f78f657806c1167dbf339]

        BaseMutex->std::mutex in configmgr::configuration_provider::Service
        
        Change-Id: Ie8f7cb4cd91ac0089365a691f07962a26d51a72a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [bf9f9f1fbda73ea65d455d520954e2d38bbccb1d]

        BaseMutex->std::mutex in chart::WrappedPropertySet
        
        Change-Id: Iaf3a31542d09426ced9e15dab1abd9aa3e04a8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc1755038a6cb293748114cd5d40c03aa44124bb]

        osl::Mutex->std::mutex in SvxShapeCollection
        
        Change-Id: I246c44b9e7ccf9eeadd4516eed9f6e4866d15736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147374
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-21  Hannah Meeks  <hmeeks4135@gmail.com>  [d6617bf6f6cebc68018f72ac38bb3dd7a43c766c]

        jsdialog: enable line numbering
        
        Change-Id: I3d188abe79605f88739b0ee17a77c6c7f8ab7754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147328
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-21  Michael Weghorn  <m.weghorn@posteo.de>  [db6ed07f4c1a086e4962ff16d3ede9aea9e60952]

        tdf#144302 tdf#153333 qt: Load cursor from icon theme
        
        Load cursor from the icon theme similar to how the
        gtk VCL plugins do it.
        
        This not only allows using the themed cursor icons,
        but also helps avoid QTBUG-95434 [1]
        ("Bitmap cursors not supported on QtWayland")
        that would result in no cursor being shown on Wayland at all
        when our custom bitmap cursors are used.
        
        [1] https://bugreports.qt.io/browse/QTBUG-95434
        
        Change-Id: Id65db4e7d71b8cee8a514c06c21c59dcc2afa889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147379
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-21  Miklos Vajna  <vmiklos@collabora.com>  [b697ee5dc3c38806fc6f096364590e9e60256aeb]

        sw floattable: fix locking in SwTextFrame::Prepare()
        
        Once a floating table is split across 2 pages, we currently emit this
        warning:
        
        warn:legacy.osl:23427:23427:sw/source/core/text/txtfrm.cxx:2808: SwTextFrame::Prepare: three of a perfect pair
        
        Which suggests that we want to invalidate the size of a frame that is
        already locked.
        
        The way normal frame split doesn't hit this warning is that the master
        has some content, then once SwContentFrame::Paste() on the follow calls
        SwTextFrame::Prepare() on the master, the !HasPara() condition is not
        hit, so it's not a problem that the frame is locked.
        
        Fix this for the split fly case by assuming that in case our offset and
        our follow's offset is both 0, then this frame will have some fly
        content, so don't return early (similar to what happens when the frame
        has some text content).
        
        We may want to revisit this later so that at least an SwParaPortion is
        generated for non-last anchors for split flys, but this is good enough
        for now, since the point is to not invalidate the size of a locked
        frame.
        
        Change-Id: I7c78472653bb6818f0d5880d21f468286be547e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147378
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3ae7bd3345e2f356b52ba7b8160dbcbdc4967e89]

        tdf#153485  align command names to show headings by outline level
        
           There are three different places where a command can be given
           to select the maximum allowed outline level for a displayed heading
           in Navigator. This patch changes all these command labels to be
           identical, so that users can recognize them as identical.
        
           "Outline Level" -> "Show to Outline Level" in Navigator context menu
           "Heading Levels Shown" -> "Show to Outline Level" in Navigator panel
           "Show Outline Content to Level" -> "Show to Outline Level" in
                .uno:OutlineLevelsShown and its popup dialog box.
        
        Change-Id: I7b1eac8067251a0e2faf38f2747dcfcf1993cebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147247
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0fa6932e26ca197cb1134c1edf8e026536f87ec8]

        tdf#153243  change "Numbering by Chapter" and "Outline Level" labels
        
            Changes are made both for Insert - Caption - Caption Options
            and AutoCaption.
        
            "Chapter" was incorrect, because the option uses the number
            of the immediately prior heading. Now the label is
            "Heading Number Prefix" (because the number is always
            prepended to the caption number). Also, the label
            "Outline Level" is renamed "Up to level" because its
            function is to specify how many levels in the heading
            number are displayed. There is a tooltip and extended tip
            for "Up to level" that makes it clear that outline levels
            are involved.
        
        
        Change-Id: I1ca8c881c8ce07870efc226b075fc8ba7f27b7e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147280
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-21  Miklos Vajna  <vmiklos@collabora.com>  [0bcce236059ae68c6dcc7bce8ceaec5d39c28f1c]

        sw: document SwGluePortion
        
        This is typically subclassed, but there is a single case for footnotes
        where created as-is.
        
        Change-Id: I36649d6fa25761a76469dd0c328b54c156be4f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147348
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-21  Mike Kaganski  <mike.kaganski@collabora.com>  [527741d528ef347b28917976efffd366c62341b1]

        Related: tdf#153752 Use virtual method to avoid dynamic casts
        
        Change-Id: I97c09d82699621d5a43a525b5f2cf75ff5d131c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147353
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-21  Mike Kaganski  <mike.kaganski@collabora.com>  [ccd0ef98f76011f108f8ea1d282b96386dba0a6a]

        tdf#153752: SbxObject::Execute: extra characters in Option Compatible mode
        
        Change-Id: Ib3e4bd9eb9a249123a686f2434ded7b529fb050f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147345
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1a022fcbc8bf256eccccb04319aa3ecfc4a3c1b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e75f5c367876eb7c983ea5e94eda777c4e0f247b
          - tdf#152605 update "chapter heading" to "numbered heading"
            
            Change-Id: I9afe6af9e039e2e40f9d19558fffd5caa1eeb645
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147281
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [842ed5e6b02939ca57db90f08ce5877836ae45ed]

        tdf#153560 "chapter" -> "heading" for Type and Format and adjust "level" label
        
           * also change "name" to "contents" for Format
           * change "Outline Level" to "Up to level" and add colon, because it
             is a buddy control. The new label gives a better indication of the
             function of the control.
           * update tooltip and extended tip for the "Up to level" option.
           
           Needed to modify unit test: sw/qa/uitest/fieldDialog/tdf143483.py
        
        Change-Id: Idafd693fe4ce161d4fa069da59a78a6111be8e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147276
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [74dc2ac66f0130bcd77cf1bbe417b22865beb067]

        tdf#153549 update extended tips for load/save numbering formats
        
           There was only an extended tip for the first item in the
           dropdown list, so extended tips were added to the 8 other
           items in the list.
        
        Change-Id: I29188637068ca683da0272b798d665cf5f8f22aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147275
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [71a67048f5eafcf668d1ee6d70c66c04cb323b0f]

        Fix typo
        
        Change-Id: I0247eec84ea4c7dc5386bd8bcb9792601758e8c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147317
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [389c6267974a90b9b0e1eaf2a7434ca4aea38f76]

        Fix typo
        
        Change-Id: I34f84c957ba9480a1e8aa17a394e139a7f736050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147318
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [abb42c396d84df49b511b8f3c73783dc56982c14]

        Related tdf#153090 Move dropdown next to checkbox
        
        Avoid extra row just for the dropdown
        
        Change-Id: Ic75fec82875576a644ab09e1d6a4af8bed48dba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147332
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23bad2bbd3add5eed49f09ebb3bc32b2cae8d8ba]

        Remove executable bits on csv file
        
        Change-Id: Id589b7e361e1c34b5e4ec4cdc7ff55d6493787e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147272
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [58e392cb149f7e3760bd421ec663133e82f3764b]

        Remove exec bits on xls file
        
        Change-Id: I2082eb3d09ce5f85432807124a80d591e33574d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147344
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [13047e72b7f074519f81e7542a0ed572376d4df2]

        tdf#153090 Fix widget display in non-gtk backends
        
        Two problems:
        * Two GtkFrames at the same position -> reorder
        * LO expects GtkFrame to have a label -> Remove GtkFrame
        
        Change-Id: Ice16c51facedaf449507a338e821b92ff28e44ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147331
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8630cbed84ac6418f85289649ed511269f8ccf4f]

        Save with Glade 3.40.0
        
        Change-Id: I40c2c3b1329a098f832f2fc286e6370be39f2a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147330
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-20  Caolán McNamara  <caolanm@redhat.com>  [cdf7b51229f2353376fb4e9de309fb9ee5580b3a]

        tdf#132110 page ids might not be state ids
        
        Change-Id: I9f8946acbcf593e9adf6d31631b82cdafcd3f472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-20  Caolán McNamara  <caolanm@redhat.com>  [816b3607dd9676a343e8ee544b615e75393566d3]

        Resolves: tdf#153763 first/last buttons in tabbar not responding
        
        Change-Id: Id6e70eca7c2d523643d9e38e8c7402879464bf5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147343
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-20  Caolán McNamara  <caolanm@redhat.com>  [961089cba5123ce535fe859044ff4e93c257391a]

        cid#1521192 Argument cannot be negative
        
        Change-Id: Ifd1b8c3391ed3576dfa61311c8bd46d1b284771e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [b1814b7cc851c4346f6cfa81c5be74c46f42e90f]

        tdf#114973 sw: don't allow every body SwTextFrame to be hidden
        
        Check this in SwTextFrame::IsHiddenNow() for the first one in the body.
        
        Also fix a bad entry in SwScriptInfo::m_HiddenChg that is then possible
        because it wasn't called on empty frames before.
        
        Change-Id: If57f8d1a30229cfbf97225b386365ae384c5083c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147347
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0452b8d6b793ac22308bc4e67e5bd54a54656568]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 336d8e277daa429fe5c271d7e5169e179dd4aaf9
          - tdf#137883 Rename docx filter to be less confusing - Help part
            
            After
            https://git.libreoffice.org/core/+/ed0476b0625c4361df5ff040a6661a9634588cea
            
            Change-Id: Id4b098e97ef0491c46fb735544c26cec40a09c76
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147329
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-20  Stephan Bergmann  <sbergman@redhat.com>  [9a23239b710e44754e4a28643420c9ba91552645]

        external/cppunit: Don't mis-apply GCC < 4.6 workaround for Clang
        
        ...which happens to define __GNUC__=4, __GNUC_MINOR__=2
        
        Change-Id: I128547d0bd375ffec9deb6abd744eeb2667ba666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147257
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-20  Eike Rathke  <erack@redhat.com>  [bd0a5bc4296b49da817151654b3fcc850403c614]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a82dd1e5fd73e2cfa8331f79f69fd8761720b9e
          - Correct --convert-to example, OutputFileExtension is mandatory
            
            Change-Id: Ibcb0ac148c60e53cf539529b911a4b47c0dc4202
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147346
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f80d489af599e72632a65d3e6213ec2959341ba0]

        BaseMutex in FrameStatusListener is unused
        
        Change-Id: I8b71d56eee9603db0cc7132994cff51ec79b5981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d359bd6720d7867564dbc408e892843ec178945]

        osl::Mutex->std::mutex in OfficeInstallationDirectories
        
        Change-Id: Ic5209df42786451b58d20f58d4d8e88c0f22b07e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9c147e20a90ab91376ea8f2d086d89197b38a75]

        BaseMutex in oox::core::FilterBase is unused
        
        Change-Id: Ie101a45c435ce10136761dd210d927a4b271507c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4a5e6f025973b5a4ba8210168569fc1a5a34254]

        osl::Mutex->std::mutex in ucbhelper::FdInputStream
        
        Change-Id: I10482c3a5f9848f45463837d5d8982476b3910a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [15405dc68b2e88b53585578567da13e3e99962db]

        osl::Mutex->std::mutex in FilterCache
        
        Change-Id: I5cdfe5397235eef276fdf77a4bf83bebdc96438b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Hannah Meeks  <hmeeks4135@gmail.com>  [0548269ca03f093c41f6292e783cc6c77328808e]

        VBA: Remove conversions in writer from OORGBTOXLRGB (XLRGB is actually BGR!)
        
        Enum to store if document is Writer or Calc because font colors are treated
        differently depending on this:
        
        In writer the colors come in as RGB but in calc they are in BGR and both palettes
        are in RBG so we only need this conversion for calc.
        
        Includes testdoc for calc - to show this still works
        
        Change-Id: I79d9d585dbfc527c0781543ce1f1095c4db190b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144788
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ba251fb3e7d3b76c8ce730e4b3a3a7859bc119b]

        cui: rework uitest to work with --without-java
        
        Change-Id: I6ed187f515b47b7e54ed85c08ee9523f1b777575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147335
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-20  Stephan Bergmann  <sbergman@redhat.com>  [bd8a213c8ceccf66ab296ef0aea0fa4c451047e5]

        external/cppunit: Use snprintf instead of sprintf
        
        ...to avoid
        
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:115:8: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
        >        sprintf(buffer, "%.*g", precision, x);
        >        ^
        > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
        > __deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
        > ^
        > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        >         #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
        >                                                       ^
        
        on macOS after the upcoming <https://gerrit.libreoffice.org/c/core/+/147257>
        "Don't mis-apply GCC < 4.6 workaround for Clang"
        
        Change-Id: I213de1d112cb56fba220006842e611c56ccc7331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147333
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [00867a1833899d70581d4e35b0feb4b8fc66e5b7]

        osl::Mutex->std::mutex in SdXCustomPresentation
        
        Change-Id: I114c2b4be39eb9a40871b7f4eb073a548191a876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [227ea92266c03adb5faba869c64fa316ebff89f6]

        tdf#153756 Unable to open form wizard (GTK3)
        
        Revert "osl::Mutex->std::mutex in GtkSalData"
        This reverts commit acf37c3a0b54a46de29bafd27ec9b0618bd2d84a.
        
        Change-Id: Ifb03dfcab966cdc69fea8c6fc2ba15eedb57d8f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Caolán McNamara  <caolanm@redhat.com>  [97ceff5bb949063f118835d67334aedf6d57420c]

        cid#1521188 Uninitialized scalar variable
        
        Change-Id: I926bfa8167bbc94643587400825364f46db43063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147319
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1131cdab3eb21a14822409c05697a91b4beda3e]

        tdf#153754 "Insert" - "Chart" in Writer hangs
        
          Revert "osl::Mutex->std::mutex in SwAccessibleMap"
          This reverts commit 2442fc19400e0e82b0375d3772a2e0b34a511600.
        
        We have a recursive call stack that does not look easy to fix
        
         #7  0x00007fffc2214c18 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7fffffff1c28, __m=...)
            at /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_lock.h:69
         #8  0x00007fffc22b6c06 in SwAccessibleMap::AppendEvent(SwAccessibleEvent_Impl const&) (this=0x55555b7e3aa0, rEvent=...) at sw/source/core/access/accmap.cxx:980
         #9  0x00007fffc22b7f8c in SwAccessibleMap::InvalidateCursorPosition(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&)
            (this=0x55555b7e3aa0, rAcc=uno::Reference to (SwAccessibleParagraph *) 0x55555b7cff00) at sw/source/core/access/accmap.cxx:1117
         #10 0x00007fffc22bd595 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x55555b7e3aa0, pFrame=0x55555b6e68a0, bCreate=true)
            at sw/source/core/access/accmap.cxx:1924
         #11 0x00007fffc22bd83f in SwAccessibleMap::GetContextImpl(SwFrame const*, bool) (this=0x55555b7e3aa0, pFrame=0x55555b6e68a0, bCreate=true)
            at sw/source/core/access/accmap.cxx:1935
         #12 0x00007fffc228c8e8 in SwAccessibleContext::InvalidateChildPosOrSize(sw::access::SwAccessibleChild const&, SwRect const&)
            (this=0x55555b7e0630, rChildFrameOrObj=..., rOldFrame=SwRect = {...}) at sw/source/core/access/acccontext.cxx:1227
         #13 0x00007fffc22b5540 in SwAccessibleMap::FireEvent(SwAccessibleEvent_Impl const&) (this=0x55555b7e3aa0, rEvent=...) at sw/source/core/access/accmap.cxx:936
         #14 0x00007fffc22b8216 in SwAccessibleMap::FireEvents() (this=0x55555b7e3aa0) at sw/source/core/access/accmap.cxx:3019
        
        Change-Id: If058cecf7bc7503d0767526c07c0ca2840b3638a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [690733f6a78e9f5bcccc2e3fbb6761257cf24014]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b4ec3df2220ce3cb5e112a202c034a32ba16bab
          - Add entry for Calc Moving cells in Contents tree
            
            Change-Id: Iacd170fd94a19fd90879cecf8c88db5ce25ffade
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147294
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [a44380768059e4efe7b29f5b57b54a20540faa0c]

        tdf#137883 officecfg: ModuleDependendFilterOrder move Word 2010 ...
        
        ... filter above Word 2007 one, and also move RTF above binary DOC
        WW8 formats while at it.
        
        Change-Id: Ia7a303ace7a9d5782348c90b0ccd95a47ffd7ac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147211
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [ed0476b0625c4361df5ff040a6661a9634588cea]

        tdf#137883 filter: rename DOCX filters to be less confusing
        
        Rename misleading "Word 2007–365" filter which corresponds to the sightly
        incompatible first pre-ISO version of OOXML (ECMA-376 1st edition) and
        is actually very specifically for Word 2007.
        
        Stop confusing users with standardese like "Office Open XML Text
        Document (Transitional)" and instead use the name of the application
        that the format is intended for, "Word 2010-365".
        
        Hopefully users will now pick the latter filter over the former.
        
        Also, the OOXML_Text_Template.xcu was missing EXPORT flag so didn't show
        up in Save dialog.
        
        Also, the OOXML_Text.xcu was missing SUPPORTSSIGNING flag which vmiklos
        said was by accident.
        
        Change-Id: I3aa88ac0fee51c906f11e75558a5d6de4f36a402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147210
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-20  Michael Stahl  <michael.stahl@allotropia.de>  [e66ddcd4b66923bc835bd7c5f5c784a809a420a2]

        tdf#137883 sw: DOCX export: compatibilityMode=12 for ECMA 376 1st ed.
        
        Commit f25985c55541cbbc9a4fc79e660592d3d0485196 changed the default to
        15, but it appears that if we want an export filter "MS Word 2007 XML"
        that writes the ECMA 376 1st edition markup that's not 100% compatible
        with later versions, we should default to the corresponding
        compatibilityMode 12 (Word 2007) if that filter is used.
        
        Change-Id: Idd6e9be2c621aac954f313364249aae186318436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147209
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-20  Caolán McNamara  <caolanm@redhat.com>  [97e2e73e87479a742b798f362eda4baafb89497c]

        with-system-libs doesn't seem to mean that anymore for harfbuzz
        
        since:
        
        commit d552b4a549d614a03aa9328e017dec27bd3ff41e
        Date:   Tue Sep 20 16:07:14 2022 +0300
        
            Enable opening of downloaded fonts only in ForKit in Online
        
        which silently disabled that from working for harfbuzz and graphite,
        but just for Linux.
        
        Change-Id: I13a67e3ad53a8d4c1833df19dd9f96b0b7366774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147316
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [14844d835cc5d6dfde499a0b1074aea5dcff4fc7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b72f41bed5b9bdffebaa85e23503a39027eba97d
          - remove unnecessary sentence
            
            Change-Id: I5168f58bfb24832a74e347a996bfa3f6d375a318
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147282
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-20  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [123f415b83470eef15a839dfedacd2b7b57f9531]

        tdf#96039 Add extra labels to help recognize View menus items
        
        when searching in the Customize - Keyboard tab
        
        Change-Id: I53346bb4be3009a6d6f6251b70ad7ed93824b403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147176
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-02-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ac824594c577ab4880177b3411a25297b1d08074]

        MCGR: Correct GradientElliptical & GradientRect
        
        The visualizations when using the texturing methods
        modifyBColor/get*GradientAlpha were both not correct
        since they did not apply the aspect ratio.
        
        I corrected both where GradientRect is correct, but
        GradientElliptical is close and may have small
        divergencies.
        
        Change-Id: I6bcc07ec7cd4cdeb7863b51b20db3a7dd5afc41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147218
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-20  Miklos Vajna  <vmiklos@collabora.com>  [7c9acfe5baef275f07c185c6fedf8b6d62d88637]

        sw floattable: fix handling of multiple splits, i.e. table over 3 or more pages
        
        - fix SwAnchoredObject::FindAnchorCharFrame() and
          SwToContentAnchoredObjectPosition::CalcPosition() to not assume that the
          precede of a follow fly is the master fly, which is not true when the table
          is split to 3 pages. In this case we have a master, then a normal follow
          and finally a last follow
        
        - fix SwFrame::GetNextFlyLeaf() to split the right anchor, which may be
          a follow text frame now, and register the new fly in master text
          frame, not at the split position
        
        - improve SwTextFrame::HasNonLastSplitFlyDrawObj() to look at flys in
          the master, but only consider the ones which will be positioned
          relative to the current anchor. Previously this was easier, as a
          "non-last split fly" happened to be always a master text frame, but
          now we han have split flys which are neither a master nor a last follow
        
        - finally improve SwTextFrame::MakePos(), because the anchor on the 2nd
          page is calculated after the 2nd fly is positioned, so it was only
          positioned inside the 2nd page, but not at the correct position
        
        Change-Id: Ibecaf5fcf0b8c56c5109461a16dcca058231b660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147308
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-20  Miklos Vajna  <vmiklos@collabora.com>  [9d280061b094918b049278fb70b1ad99fef7dc84]

        writerfilter: prefix members of DomainMapper_Impl, EmbeddedFontHandler, ...
        
        ...  GraphicImport_Impl and StyleSheetEntry
        
        See tdf#94879 for motivation.
        
        Change-Id: I83639c40fb8c32c1d205a9b53d24409f9a5a5a15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147307
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [e55713dffbe8d8eba18068f6c2af14c10b787220]

        qt a11y: Invert relation type to match Qt's semantic
        
        As Jan Arve Sæther pointed out in a review comment [1]
        for a pending Qt change to add more a11y relation
        types to Qt, Qt's semantic for relations is basically
        the other way around (i.e. inversed) as compared
        to the semantic used by AT-SPI or LO.
        
        For example, if an a11y interface `interfaceA` is the label
        for another a11y interface `interfaceB`,
        
            interfaceA->relations()
        
        will contain a pair
        
            { interfaceB, QAccessible::Labelled }
        
        since the target `interfaceB` is labelled by `interfaceA`.
        
        On the other hand in LO, the `XAccessibleRelationSet`
        for an `XAccessibleContext` has the role that the
        a11y object itself has *for* the targets, i.e.
        in that case the
        
            interfaceA->getAccessibleRelationSet()
        
        would contain an item of type
        `AccessibleRelationType::LABEL_FOR` because
        `interfaceA` is a label for the relation target
        `interfaceB`.
        
        Therefore, adapt the mapping between the relation
        types accordingly.
        
        AT-SPI's semantic/handling matches the one that LO has
        again, which is taken care of by the fact that
        Qt maps the relation types the other way around in
        it's AT-SPI bridge again. [2]
        
        There's also a pending Qt change [3] to clarify the
        Qt doc.
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/428174/comment/eef0cf38_e6ff7dea/
        [2] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/qspi_constant_mappings.cpp?id=e8322a4cc043e1a150cc4c6b86ee2f9cf858cd24#n98
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/460414
        
        Change-Id: Ic30d878afc477ad3c6a188d22f35078034f8123c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147223
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [b845ba1900387b8ea44a27a1f7d045ca0091adf2]

        tdf#153614 qt: Set keyboard focus state when focused, too
        
        For example the Breeze theme only draws a light blue
        focus rectangle for list boxes when the
        `QStyle::State_KeyboardFocusChange` state is set in addition
        to `QStyle::State_HasFocus`.
        Therefore, set that state in addition to ensure that the focused
        control actually gets a focus indicator when moving there
        using the keyboard.
        
        Change-Id: Ib4b85f9140629e6b69c80b85e85913392a6c000f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147019
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-20  Michael Weghorn  <m.weghorn@posteo.de>  [d5ace6bf0f1e48ee02e5eb22ce0f9f8953517f60]

        tdf#153520 vcl: Align listbox invalidation with mouseover check
        
        Before
        
            commit 4cb11d8a6682fecd661b926a417ae7f26f76e7db
            Date:   Fri Oct 7 16:40:23 2022 +0100
        
                Related: tdf#98067 do RollOver for Edit as well as SpinButton
        
        , the check whether the mouse is over a control
        was only checking the control's child windows.
        The above commit introduced a check for the control's
        window as well in `ImplSmallBorderWindowView::DrawWindow`.
        
        When moving the mouse inside or outside a `ListBox` control,
        the invalidation of the corresponding border window happened
        when the mouse cursor would enter or leave the `ListBox`'s
        `ImplWin` child (in `ImplWin::PreNotify`).
        
        The `ImplWin` only covers a part of the `ListBox` area. As
        a consequence, when moving the mouse out of the `ImplWin`
        area, the mouse would still be over the parent `ListBox` area,
        so the `ControlState::ROLLOVER` state would still be set
        in `ImplSmallBorderWindowView::DrawWindow` from the above
        commit on.
        
        Since there was no additional invalidation when the mouse
        moved out of the `ListBox` area, the `ROLLOVER` state would
        remain set even when the mouse left the `ListBox` area as well.
        
        Move the invalidation from `ImplWin` to `ListBox` so
        this gets processed when the mouse cursor actually enters or
        leaves the `ListBox`, not just the `ImplWin` child.
        
        Also align the mouse over check in
        `ImplWin::ImplDraw` with the one in
        `ImplSmallBorderWindowView::DrawWindow` again.
        (Take the parent into account there as well.)
        
        Change-Id: I8974e370819719489e3d9f091d96b3353888d26b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147018
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-02-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [16a35542aa07ed69c6c699d1c17f076d87708958]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8e13d56e2b4bce9e04778c8b0f5b42353ff9e98
          - remove incorrect bookmarks
            
            Change-Id: If5e074bda421fb10e131e8e676bc0a43dbc1fe2f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147279
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-19  Caolán McNamara  <caolanm@redhat.com>  [0eab1adad76919cbe3243ffd92df088f5259f074]

        downgrade assert to warning
        
        list of documents that assert here from crashtesting is known, so
        turn into a warning for now
        
        Change-Id: I45da002f00f92d65778e69f27040c8e09b7c8501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-19  Caolán McNamara  <caolanm@redhat.com>  [35e3c499cb64ed647fc8cc0a42a2d83948abcbdf]

        crashtesting: crash on import of forum-mso-en4-702161.xlsx
        
        vConditions is empty at this point for row 5
        
        git show -w
        
        Change-Id: I05d984d73d4dd5a0ece894f854263528c9c00be9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac8963b688b3ce787455a1c7e1506aec10838ff6]

        osl::Mutex->std::mutex in BasePrimitive3D
        
        Change-Id: I49e196885845f352c6c4cda6e3890b749d4eb0fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [414172d7fafc2d2c6b1e698aeb67fdb5797b118d]

        fix locking in OMultiTypeInterfaceContainerHelperVar4::diposeAndCloear
        
        where I forgot to relock at the end of the method
        
        And sprinkle some asserts around to catch mistakes like this in future
        
        Change-Id: I4908ac0ffdfe33b1b5cf1b02e6765f20973af841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147296
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-19  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [0b44a7760dc2093564bbded0afce6c749dd307ae]

        SwAutoCompleteClient: SwClient no more
        
        Change-Id: Id6e13fdf037bd1a910ecd127344b46393a190d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147138
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-19  Andras Timar  <andras.timar@collabora.com>  [a2b8295f428478ba7fd9be2a8dd26c7b948b77f8]

        Fix error compiler error with VS2019 C2487
        
        e.g. 'GetLibCount': member of dll interface class
        may not be declared with dll interface
        
        Change-Id: I4856d0848447ca04747015015af4147b28c2f188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147278
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-19  Caolán McNamara  <caolanm@redhat.com>  [0ef4ce9b93118d18b579ae27919e304b2a4a478c]

        ofz#56123 Null-dereference
        
        Change-Id: Id1d8c157814564dc31a7b439354fd8662d19fc07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147301
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-19  Mike Kaganski  <mike.kaganski@collabora.com>  [fd6a0cf1eb8441acb23f22e9e9fafc477bf4e57e]

        tdf#153724: make sure to retrieve the variable value before checking the type
        
        Commit 5760c94b8847164f9a7a181f031c7c86643944af tried to avoid all cases
        which could set an error in SbiRuntime::PushForEach. To do that, it checked
        the type of xObjVar before trying to get an object from it, which otherwise
        could set an error.
        
        But the type of the contained value can be not known until it is retrieved
        (which can happen inside SbxValue::Get in a call to SbxValue::Broadcast with
        SfxHintId::BasicDataWanted). This happens e.g. when the container passed to
        'for each' is a call to some special function, like VBA's 'Selection'. Then
        SbxValue::GetFullType would return SbxEMPTY prior to SbxValue::Get.
        
        Let's make sure to call SbxValue::Get first (asking for a Variant, to avoid
        errors on type mismatch), and only then, check the actual result data type.
        
        Change-Id: Iaa697f38285505e50504ae09f9307fbd29e09a53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147273
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [405d0bc007b8d90bf0880035c5d69e1fc4b951b1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 03cb59d0517e87076c76521c77cd88dd9f16dc4e
          - inform about clicking on status bar
            
            Change-Id: I3ac867df051295c3b5095fbfe1c1a17fa275cb59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147277
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [23d46176d6f206e62126e0b7c2afdc46456e50ad]

        osl::Mutex->std::mutex in DefaultGridDataModel
        
        Change-Id: Ib62f9e7040c8d7171a50ccfe937e35f060f94f95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147265
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [454f141406e379d60e57c3e9fdd06641b49c00c1]

        grammatical/typographical corrections to one tip of the day
        
        Change-Id: If2de87c859ca4cd59cfb92fd64648be400df187f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147252
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Tested-by: Jenkins

2023-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [2767caa7958a0c98117494bf09ce5333af679c14]

        osl::Mutex->std::mutex in OWeakEventListenerAdapter
        
        Change-Id: I3ebd6cfdb8ff76b2d1988c3c481ef4effa5c2964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147262
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [801cbe5410d44805945c2be616b284888a1e1b80]

        osl::Mutex->std::mutex in BitmapCache
        
        Change-Id: I4ca8ac53e0d37aaf015e96963299acb5eb10f3b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147267
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [044aefc0231d0d066a67600ca5419da51194858b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bdf9af4c8847ac03d1a836f6cfc9f49053ddd95d
          - tdf#144493  (related) command name changes require updating
            
               also icons for "Move Chapter Up" and "Move Chapter Down" corrected
            
            Change-Id: I09671ba5431ce969757f64c5d1892f6f6f0f399d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147253
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [76bdc40cc3157a8ac98332047f8edbc4008f5392]

        osl::Mutex->std::mutex in DefaultGridColumnModel
        
        Change-Id: Ie3df092b013f10b36c85028fe3b9966d58b22005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [a979535eeb1630334b60eea98be2c2fabec56c23]

        osl::Mutex->std::mutex in OGenericUnoController
        
        Change-Id: If49864f3127b185bb0212be02abd0f92e14c3908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147261
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a4223f924d4ec49b023a85ce37f3788bc699723]

        osl::Mutex->std::mutex in SdGlobalResourceContainer
        
        Change-Id: I521ec7397e9ac54547bc82be6579cbb4fb4fc5a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147266
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [509ab788baf54285b4e38f2560326657d97510fd]

        tdf#82254 - Don't remove UTF-8 BOM from CSV when saving file
        
        Don't remove the byte-order-mark in the resulting CSV file
        when it was present in the CSV source file.
        
        Change-Id: Id26abad2686917f320f2ace85441621bcf57ea9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145879
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-02-18  Balazs Varga  <balazs.varga.extern@allotropia.de>  [0a27403bbc36c89efa321fb3c5061fe4ee7095fb]

        Related tdf#149786: add better unit test for vba pdf export macro
        
        Better unit test for vba pdf export.
        
        Change-Id: Ifa3dff79c457e21ca24b8d99c024bd59917bc990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147171
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-02-18  Stephan Bergmann  <sbergman@redhat.com>  [02512bbfe9bc8f21b82eaf0cbf7135693ea12ced]

        Remove redundant (and wrong!) explicit template arguments
        
        At least the last one, for css::table::BorderLine2::LineWidth, should have been
        sal_uInt32 instead of sal_Int32.
        
        Change-Id: Iab375988432b6a69172625af86cc25b813f60446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147268
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e676c585f316b649c06c73711013abe32fce72e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 72dcc8952e242a86c3e328ca285cd17424008c77
          - tdf#149286 Missing Help links for Customize toolbars
            
            Change-Id: I702b2ab1759decee9c283e2f2abb09b1a282ab52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147090
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-18  László Németh  <nemeth@numbertext.org>  [5b9855acc7fa6d1e4a5f53ff0bc47e1dd4729827]

        tdf#132714 sw: fix crash at table row deletion associated to a chart
        
        Using the table toolbar, deletion of the row of a text table
        resulted crashing in ActualizeSelection(), if the text table
        is associated to a chart, and the deleted row was the first
        data row of the chart. Fix this by emptying the outdated table
        selection cache m_SelectedBoxes in GetCellRangeName().
        
        Note: since commit eea37aa26932d06ed8e93d001862bf45175c4446
        "tdf#122995 Trigger Chart refresh directly in UpdateCharts for SW",
        the crash occurred immediately, i.e. without double clicking on
        the chart after the row deletion.
        
        Note: uitest needed to get the crash, not uiwriter.
        
        Change-Id: I78d126f245839ec1d8a8cc01257fe96d94ac0a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147224
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa4d174103f5422168a29b83f596953098e4794c]

        osl::Mutex->std::mutex in dbaui::OAsynchronousLink
        
        Change-Id: Ida29c113db891b260ebc2b6d0d4638cb5224eac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147231
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb9492ce8a54848b5418a0efdf2beeb7999f3e54]

        osl::Mutex->std::mutex in SysCredentialsConfigItem
        
        Change-Id: If1e938381917bf2d538ca663961782430e7cbf77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147230
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [63976f2b6dcf034d5cf119e1218606a117a7bb5e]

        osl::Mutex->std::mutex in SysCredentialsConfig
        
        Change-Id: I5072236c14ce57ecb9fda552b7539a640d2d8836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147229
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [93dd88bd538db825b35c0feaab96dfa073229dfc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02ca13ee438eac0be0a811f86ffd43c2366eecfa
          - tdf#153549 update because Chapter Numbering -> Heading Numbering
            
               First of multipart patch to update help pages because of
               name change to the dialog that assigns numbering schemes
               to headings. Patch focuses on pages that describe the
               Tools - Heading Numbering dialog. Where possible, German
               Ids were renamed.
            
               For "Numbering" page, controls were reordered to correspond
               to the current order in the dialog.
            
            Change-Id: I15f65e6f95dc2b2830f7acf6afd03d4896e22b57
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147127
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6504514ecb8ceede450ec16c1ea1fcf79bdb5b04]

        tdf#153485  UI guideline corrections to outline level popup box
        
                  - revise grammar of help message and add mention of headings
                  - add missing colon to label with buddy control
                  - use en-dash (U+2013) for number range
        
        Change-Id: I6a3e20ca319153c7384d8a50802222dcefcbe561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147248
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [87b6c7c2a41e3908be0e4d3f2fed79b8a0065e94]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 19870562065899332b16070b6724d628f8d1cb80
          - tdf#152605, tdf#137281 change "heading level" to "outline level"
            
                 swriter/01/04120211.xhp (Insert/Edit Index)
                   *put Title and Type in same order as dialog (no text changes)
                   *corrections to "Outline"
                   *move embedded "tip" to after Outline (no text changes)
                   *corrections to "Additional Style" tip
                   *corrections to "Assign Styles"
                   
                 swriter/04/01020000.xhp  (Shortcut keys)
                   *corrections on how to change outline levels with "Tab" and
                   "Shift+Tab"
            
                 swriter/guide/arrange_chapters.xhp
                   +change heading level to outline level
                   +update command names
                   +change icon size to 1cm
                   +refactor <menuitem>,<keycode>
            
            Change-Id: I27ce871e4c14608066183c9d1c5433abc59bd1a9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146799
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-18  Eike Rathke  <erack@redhat.com>  [296c42cdb8e9dee5ac912d9777afdf3bab63efb9]

        Proper error is UnknownStackVariable
        
        Change-Id: I79b27c279449022144c50300da3f96522c42f438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147260
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Eike Rathke  <erack@redhat.com>  [9042340ef99e099a87630eea089b4cae7e38649e]

        Add Saraiki {skr-PK} [0x06B0] to language list, CTL, RTL
        
        Change-Id: I2bc1462acbcc69023586333a4c6b10ba415e5ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147233
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Khaled Hosny  <khaled@aliftype.com>  [0c9448bb31a32a3bf4004d45c4b1305debf1b5e2]

        tdf#147739: Medium is not a synonym of normal
        
        For some reason, medium was thought to be a synonym of normal, but that
        is not the case. Seems to be from:
        
        commit b05701988492b051b3bb07bb46ae0397e23f032f
        Author: th <th@openoffice.org>
        Date:   Fri Mar 9 14:44:26 2001 +0000
        
            #83090# - Extensions for localized sytle names
            #77189# - FontAlias should now also work
            Extensions for Chinese fontsize numbers
        
        Change-Id: Ic5e463b6e77c0fa88701108597c99c9fa0c6bf4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147258
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ead66494deda4590d9202a96d4aa9589751412a1]

        tdf#153596 "outline" -> "headings"
        
            TOC displays "headings" if this option is checked.
            The tooltip/extended tip explains the relation to outline level.
        
        Change-Id: I28a7bc4da7da45398c859fa71be019bd127f53b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147240
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2023-02-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d2a6687bf6a7c49e851bf686cdd6afd0db7ac0a2]

        tdf#153549 change tip-of-day about chapter numbering
        
            - rewritten in form of a question
            - generalized to refer to headings, because not limited to chapters
            - added additional detail about relevant location in dialog, but
              did not attempt detailed explanation, because....
            - added link to relevant help page
            - added missing period.
        
        Change-Id: Ie16c116b8e51e6b24de2c4060fee9617c6ef1e7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147121
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-17  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a2c32afcae257e797ad69ab2346bbe3b6a2fa8ae]

        tdf#149756 tdf#152545 PPTX import: position of standard connector - part2
        
        and add new compatibility option "ConnectorUseSnapRect".
        
        Standard connectors (bentConnector3, bentConnector4, bentConnector5)
        are improved. MSO calculates the edge track differently, so have
        to add "ConnectorUseSnapRect" compatibility option:
        
        - For PPTX file format, it is set to true and use the snap rectangle
        
        - For ODP format, it is set to false by default and use the bounding
          rectangle.
        
        Follow-up to commit eec48130271188cab63665acedbabf1ff5e850a2
        "tdf#148926 tdf#151678 PPTX import: position of standard
        connector - part1" (bentConnector2)
        
        Change-Id: Icca84708d6e10d44ebf7262415d055ce9cfc157d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146162
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [fc1c9d7ce98a5405785907d8d18db9354b32b824]

        use a reference here to flag its never null
        
        Change-Id: I92b3c71458b2d65711ea30a3e14b9e387c973a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Stephan Bergmann  <sbergman@redhat.com>  [302a22cd19e6f6963fc8eb0b9a581c7eff5e5430]

        Verify that zh-Hant-TW locale works in configmgr as intended
        
        ...after b52117c0be97c45824d2897657084f8ac7e9bf42 "Try an override locale as
        first fallback"
        
        Change-Id: I23d8459fff4d76fd9d542d098953bf97cf5397a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [a7fd1e067eb2af0ef329719c4c7dbb32cc5926b2]

        check SmGetActiveView()
        
        it might be null
        
        See https://crashreport.libreoffice.org/stats/signature/SmPrintOptionsTabPage::~SmPrintOptionsTabPage()
        
        Change-Id: I7bc17da230784e6e3fc9c0b33848423ac113ab29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147221
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-17  Eike Rathke  <erack@redhat.com>  [9d91fbba6f374fa1c10b38eae003da89bd4e6d4b]

        Stack check safety belt before fishing in muddy waters
        
        Have it hit hard in debug builds.
        
        Change-Id: I9ea54844a0661fd7a75616a2876983a74b2d5bad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147205
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [49dd32a88d90097a1c50dc64dc42dc35645780b8]

        osl::Mutex->std::mutex in PasswordContainer
        
        Change-Id: I94113d714417447d5664a08d45fe1ad8dc0fb5e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147198
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [25b38765d6e500af196ce312a3e1d819c6a7d09c]

        check GetActiveWrtShell() and CheckAndGetWrtShell()
        
        See https://crashreport.libreoffice.org/stats/signature/SwModule::ApplyItemSet(unsigned%20short,SfxItemSet%20const%20&)
        Change-Id: I7c719c5fe4cda9f6571592c30f39bd440053dbe9
        
        Change-Id: Iaa4448dccd1a0ec1aefa539e476b5046ed50f7b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Michael Stahl  <michael.stahl@allotropia.de>  [08b0443e0f50f79ee26fad4eada0190623b9b30a]

        sw: adapt aCSS1AttrFnTab to hintids.hxx
        
        static_assert there is worthless because SwAttrFnTab is fixed size.
        
        Change-Id: I9781027081c28a1c725bed510a768103dc53ccc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147208
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-17  Alain Romedenne  <alain.romedenne@libreoffice.org>  [0ffa1607c57600930fb6494ab6642f5da0d5447e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff28b2273c769b7085c031f135131724af25d2c7
          - typo
            
            Change-Id: I67540e5f1feec3baa6d585a508fc5b270c0981ae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147241
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [2d3b13d6b803f4a58c0302f7d9b58ba9766836d8]

        use a reference here to flag its never null
        
        Change-Id: Ib57be7f076f4ec720d9d153034d00915a82e9ae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [5ed00392ee3b2ba7babeb88527ceaafc3da3f443]

        use a reference here to flag its never null
        
        Change-Id: Ic38d95d7c50d5807c9c94cc0851422bb1c60912a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [8bc365b8dd33feefd33fe4d64a80b9753401cba1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aeb4e62cc9ffe7406cbe976c0dc59215c45b4bba
          - Minor: Fix for small whitespace issue
            
            Change-Id: Icc5bd2dc4323da23867b4cfdce8284a936ee8e7b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147066
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [2c0d444f4ec8729a14a68a4441bcd74a22cf7f59]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fbc1e41ad4961b502ca658e2f19e74450c93c76c
          - tdf#153547 (related: tdf#137281) add "heading" to General Glossary
            
            Change-Id: I69150a42764bf30cbe547e3273f0005219706723
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146796
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-17  Stephan Bergmann  <sbergman@redhat.com>  [2a5105cd0f4025b8ee4cecbd8cef864f72b0f659]

        Quote some Windows shell settings
        
        ...or else, at least with the Windows 11 cmd.exe, when setsdkenv_windows.bat has
        already been run before (and generated the
        %APPDATA%\libreofficeX.Y_sdk\setsdkenv_windows.bat script), and is run again
        (and thus reads that generated script), it failed with something like
        "\Microsoft was unexpected at this time."
        
        Change-Id: I1bfaf375e52a3ee2debe48a7dd736808790346ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147217
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [83ca2ace843eda40fc83270c7b068e68e2a0519c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 180d21fe3e76731303703a5885f5ee99591f8d7b
          - tdf#149056 Bad Help link for Address book wizard
            
            Change-Id: I3093fb88733b444b9a074d43d9971ad92ce384e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147086
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-17  Stephan Bergmann  <sbergman@redhat.com>  [6c08211a2a37c6b1841a78d5a99d720ec385cb6b]

        Remove remaining STL_INCLUDES
        
        ...that 1628005298923ad15cc78dbad63669b701f5fd04 "Trying to remove the stlport
        mention from the code" didn't catch
        
        Change-Id: I271d7760d2b2dd25c0fa27489a8ddf455963d970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147213
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [6ef32deaff0d5cc271098aebf89b82be72420d9b]

        use a reference here to flag its always dereferenced
        
        Change-Id: Ic157ec89e6e47560612924a9f70e6669235a9a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147212
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Stephan Bergmann  <sbergman@redhat.com>  [c5d11033044cb7418ba3f8a78d5598721bb2a6c1]

        Verify that es-419 locale works in configmgr as intended
        
        ...after a9b97301ba75a74e6671a6b9829f7044e85db6af "Do not add empty language tag
        to fallback strings"
        
        Change-Id: Ie42929c2ce6331012358f72026ae774b9dd0e369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147207
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [6d9091197b311321543ea0f0dac30825bf8cc2b8]

        sc: fix divide by zero in ScGridWindow::DrawPagePreview
        
        Seen in https://crashreport.libreoffice.org/stats/signature/ScGridWindow::DrawPagePreview(short,long,short,long,OutputDevice%20&)
        
        Change-Id: Iff64d0fe84c7d53b18db38598709ac47475a6715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147206
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2442fc19400e0e82b0375d3772a2e0b34a511600]

        osl::Mutex->std::mutex in SwAccessibleMap
        
        Change-Id: If7499b3fb165c904d32c9404161a7cdb2e29e5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147187
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [d07796880aa1ac7dcd90df54c8bb4f57d2d4a612]

        CppunitTest_sc_mathematical_functions_test: Add unittest
        
        it would have crashed without the fix in place
        
        Change-Id: I4b7e2c7b72ff0d2a6532b4b7945fb9a0dabe28a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147202
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [44c803f1481a31f54771fc681b0772a613e0bf83]

        tdf#153549 update extended tip because of command name change
        
        Change-Id: I469b3852b406f209ed70e19a75f64cd67583c643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147123
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [f205403ff4efae613e87b07e7345ec20e96f68f1]

        crashtesting: crash on export of forum-mso-en4-568138.xlsx to xls
        
        recurses to death
        
        warn:legacy.osl:186588:186588:sc/source/filter/excel/xeformula.cxx:518:
        XclExpFmlaCompImpl::CreateFormula - unknown garbage behind formula
        warn:legacy.osl:186588:186588:sc/source/filter/excel/xeformula.cxx:518:
        XclExpFmlaCompImpl::CreateFormula - unknown garbage behind formula
        warn:legacy.osl:186588:186588:sc/source/filter/excel/xeformula.cxx:2235:
        XclExpFmlaCompImpl::PopOperandPos - token stack broken
        Segmentation fault (core dumped)
        
        Change-Id: I17172be42c9992ceb3a90c5a92344a58328dc483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147204
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a07de1a335f1a25f13c992c937d21c2f16fba496]

        tdf#153549 update extended tips in Chapter Numbering dialog
        
        Change-Id: Ic5d13c6f7e000f5b568e3efa175bdf19935a0a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Michael Weghorn  <m.weghorn@posteo.de>  [9fe3b3b09002188be4691e11eaa36113be0d80c1]

        android: Update com.google.android.material to 1.8.0
        
        Change-Id: I2e2049c5d832aa9ea82feaabf3a86fd8c87a9668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147197
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-17  Michael Weghorn  <m.weghorn@posteo.de>  [60e804f31cf2a9a3a36a4eb6551b7924253c479a]

        android: Drop unused TextureView
        
        It's unused since
        
            commit 3860bff1013f9608b934c4cdb9ddb8d2dbbc3e52
            Date:   Fri Dec 19 16:25:23 2014 +0900
        
                android: never use TextureView for now (for performance reasons)
        
                Get align with latest Fennec code which also has this disabled.
        
                Change-Id: Ie4c27935bacd29218207e47593f073bdce0cf7e3
        
        Change-Id: I808ce73928120c10f4e3721a11b1e74bac3a413c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147196
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-17  Michael Weghorn  <m.weghorn@posteo.de>  [b60fc720d789602c6b5420365f4dcaa6cb17bf40]

        android: Drop unused LayerView#isIMEEEnabled
        
        ... that always returns false anyway.
        
        (And the `InputConnectionHandler#isIMEEnabled`
        that would be called in the commented out code
        doesn't exist either.)
        
        Change-Id: I6031672ee2835c64a1efcab946574ca2ce94b6a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147195
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [a1ef5ac4008b0b2625aed9641f0047b84921af7a]

        use accessibility description in menus for extended tips
        
        like we do for generic widgets
        
        Change-Id: Ib7fbab3e8551e91f43607732a15a556fd4a76856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147199
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Miklos Vajna  <vmiklos@collabora.com>  [e11e1d48abedf17db40c069d9f37b4edcbcc09c4]

        sw floattable: it's fine to recalc the table in SwTabFrame::MakeAll()
        
        Avoids this warning:
        
        warn:legacy.osl:22791:22791:sw/source/core/layout/tabfrm.cxx:2751: debug assertion: <SwTabFrame::MakeAll()> - format of table lowers suppressed by fix i44910
        
        I assume that the intention is that flys first format their content and
        then grow as necessary, so there is no risk to call lcl_RecalcTable() in
        the floattable case. (Parent will grow, then split if necessary.)
        
        Change-Id: Ib15d2d56066b695010c76f2052114082678c2e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147194
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c749fb1766263638a7a87575b84ab31ebdd5cde]

        osl::Mutex->std::mutex in FormScriptingEnvironment
        
        Change-Id: I6c6fbe6126d9431f4a252aadf31c9733a41a73b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147193
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Miklos Vajna  <vmiklos@collabora.com>  [3282508f8deeafd50f5af45ca0adf760efb114a3]

        sw floattable: add ImportFloatingTableAsSplitFly expert setting
        
        Mapping DOCX floating tables to Writer split flys is still disabled by
        default, but now the environment variable affects the DOCX import
        instead of affecting the Writer item pool's default.
        
        This allows mixing ImportFloatingTableAsSplitFly=true and =false tests
        in the same suite, so the sw/CppunitTest_sw_core_layout_flycnt.mk
        boilerplate can be dropped.
        
        It also allows overwriting this default from an xcu file (expert config,
        or the XCU file in online.git) for testing / demo purposes.
        
        Also extend the layout representation comment / doc a bit.
        
        Change-Id: I239e9c6e9d9c8748ed0846ae336c9c818d59f180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147191
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fb3a4468ab7ce0409d4cd5a7e263fa4c0c3eac38]

        Fix typo
        
        Change-Id: I5d71f98cafd644dc79df06e67fc400aa8ea4d8b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147164
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [72cf5b4b8c99e969eb36b0910e2954d220b8850c]

        crashreporting: divide by zero, aPrefSize.Width() must have been 0 here
        
        Change-Id: I5ee2c1f4386c95c12fb821a3514cb732b220bb86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Caolán McNamara  <caolanm@redhat.com>  [7183d259d0d8bf8020da1aa06c963581d2bf779f]

        SfxViewFrame* arg of SfxRequest ctor always dereferenced
        
        change it to take a reference
        
        Change-Id: Ib9349f4c2660d297d93ee81256e7fa9873728ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [eefa8e8110c432be36e1cd5d166b5f5676a7e5ca]

        osl::Mutex->std::mutex in SortedDynamicResultSetListener
        
        Change-Id: I70b20a616cb84c5c066431be50359def5d041b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147188
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [130602ad8cdb45235dd99c60876fc8a091b9bc89]

        osl::Mutex->std::mutex in UndoManagerHelper_Impl
        
        Change-Id: I57973db459633a4672c0d59c23bd3a682834ace8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147186
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf4e1e0bb8145ed1feccc7c916b60cb394a2ee92]

        osl::Mutex->std::mutex in OHierarchyElement_Impl
        
        Change-Id: I458cab160f337019402659b5fb738ba85f73ea1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8dc080dd021e352054d41b3c3f34e46028ecf5a]

        osl::Mutex->std::mutex in SortedDynamicResultSet
        
        Change-Id: I21b98831645e2d7942bdf630225c136f9af3dca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-17  Miklos Vajna  <vmiklos@collabora.com>  [c19ef6d5edc0cf0a26e82752a71e1d1e01f08db7]

        sw doc model xml dump: show a table format only once
        
        Table frame formats owned by SwDoc::mpTableFrameFormatTable, so show it
        only there and mention only the address in SwTable.
        
        With this, we show one table format only once, which decreases my
        confusion.
        
        Change-Id: I543153589375c3ac5f7c8307bfb2cd7a75e2d359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147172
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-17  Eike Rathke  <erack@redhat.com>  [b52117c0be97c45824d2897657084f8ac7e9bf42]

        Try an override locale as first fallback
        
        Change-Id: I4ca6db43fef2706c4c1bab020e2170f6cf45a441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147184
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Eike Rathke  <erack@redhat.com>  [66719bbdf9d433be8208fac5dbad9e1e9ecebdd5]

        Unit test for {es-419} and fallbacks
        
        Change-Id: I3ced70df064cfd331974da7c6713c950a509168c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147183
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Eike Rathke  <erack@redhat.com>  [e7ce9bddadb2db222eaa5f594ef1de2e36d57e5c]

        Obtain actual 0-parameter count for OR(), AND() and 1-parameter functions
        
        OR and AND for legacy infix notation are classified as binary
        operators but in fact are functions with parameter count. In case
        no argument is supplied, GetByte() returns 0 and for that case the
        implicit binary operator 2 parameters were wrongly assumed.
        Similar for functions expecting 1 parameter, without argument 1
        was assumed. For "real" unary and binary operators the compiler
        already checks parameters. Omit OR and AND and 1-parameter
        functions from this implicit assumption and return the actual 0
        count.
        
        Change-Id: Ie05398c112a98021ac2875cf7b6de994aee9d882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147173
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Eike Rathke  <erack@redhat.com>  [0382e86830daa3255feaa0561c678e58ad714126]

        Handle 3-digits UN M.49 region codes in simpleExtract()
        
        Necessary for {es-419} and the like that are predefined language
        tags with known LCID mappings.
        
        Change-Id: I46491842fc11836a55cd56327d4f955952c026f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147182
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-17  Justin Luth  <justin.luth@collabora.com>  [e55a5db74cc51ad5cba24d3872948becc4205d81]

        Revert "assert commit looking for example document to test theory."
        
        This reverts commit a942e6e5ecfdd9ff83fc7febb8234c8f0e2813db.
        
        I downloaded the crashtest URL results with wget -r,
        and then gathered the identified documents with
        
        grep writerfilter/source/dmapper/DomainMapper_Impl.cxx:303 * -l \
            | xargs grep aRealURL
        
        Change-Id: I0a4736af9c1f9be0e4897806538695d7a4b2c170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147181
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [620bad283446c635febcdf0b4b1c60f17c2abdf8]

        tdf#153653 add tooltip and correct extended tip for Assign icon
        
           also some adjustments or corrections to existing extended tips
        
        Change-Id: I04f385bb6948131bade3995488aec51b55d9a5a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147116
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [14a065a812c8c2176b56b2baaf08ba25a2f9fa60]

        tdf#141869  update extended tip to reflect UI label change
        
          - also add tooltip
          - change to correct typography
        
        Change-Id: Ie953f871eb8ed5d6213f8b4de55794837f103492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147122
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-16  Justin Luth  <justin.luth@collabora.com>  [6515f66372afb4d2e3ec57f9c99be4c3ffb2de84]

        tdf#153613 DOCX: DID YOU FIX ME? unit test
        
        So once we have a page break, we need to know the rest
        of the paragraph's contents before the decision can
        be made to split the paragraph or not.
        
        In order to do this properly, the shape processing would need
        to be delayed until some "normal" character run is seen
        before a carriage return.
        
        That's too complicated for me,
        and probably not worth doing anyway.
        
        make CppunitTest_sw_ooxmlexport18 \
            CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak6
        
        Change-Id: Ie79574f2e1656a230da8df1b95fe61ea96c2802a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147175
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Eike Rathke  <erack@redhat.com>  [a9b97301ba75a74e6671a6b9829f7044e85db6af]

        Do not add empty language tag to fallback strings
        
        This happened for known tags like es-419 but unhandled in
        simpleExtract(), which actually should be implemented as now a few
        are mapped as known tags. Prevent adding such empty string.
        
        For that, adjust configmgr/qa/unit/test.cxx to test for the
        expected "en-US" instead of "default".
        
        Change-Id: I05f8e35a9d88b42d45e1f2a90aecec5f4470cc79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147135
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-16  Tor Lillqvist  <tml@collabora.com>  [49445ccb891c6eb85b1d644c975c1b092ef00e43]

        Use -O3 for Emscripten, seems to work
        
        Change-Id: I7effd75355ff81e6d4f85b1c6047c7656bfbb915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147006
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-16  Stephan Bergmann  <sbergman@redhat.com>  [df5995b0bf9db2a68dc64f0dda1cc74ab222a1f2]

        Only specialize CppUnit::assetion_traits<T>::toString member functions
        
        ...not the whole CppUnit::assetion_traits<T> classes (where applicable).  That
        avoids spelling out the (identical) equals member functions, and also leaves
        around the less and lessEqual member functions, in case they want to be used
        after all.
        
        Change-Id: I18f8d6cff0353921ced4952b33a0c85ff8292923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147165
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-16  Justin Luth  <justin.luth@collabora.com>  [5884a122dc2a2c73865efdbdd861c281475a681e]

        tdf#153613 writerfilter: split para for inline too if not FirstRun
        
        If we have some stuff in a character run (i.e some text usually)
        and then a page break
        and then an inline image,
        then the inline image should start a new paragraph
        and move to the following page.
        Only anchored images don't necessarily move to the next page.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak2
        make CppunitTest_sw_rtfexport5 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak2
        
        Change-Id: I756f756d836b29eedc776a35b7667ba33e6cdebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147170
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Justin Luth  <justin.luth@collabora.com>  [a9bc19c2d4a35606668aa2dcc53355651b71ee78]

        tdf#153613 writerfilter: don't always split para for shape w/ pagebreak
        
        The problem was that an extra paragraph was added,
        and the shape was anchored to the wrong page.
        
        There are lots of places that handle deferred breaks,
        and they typically do this only for FirstParagraph or non-first
        character properties run.
        
        This is needed here too.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_textboxAfterPgBreak2
        
        Of course, RTF is goofy, so handle that as an exception
        to just leave it alone as it has been.
        To solve it properly is likely very tricky - as are all things RTF,
        because we can't trust IsFirstRun in general and especially not for RTF.
        make CppunitTest_sw_rtfexport5 CPPUNIT_TEST_NAME=testN818997B
        
        Change-Id: Iad06f3ea9684a2860ae6ba724887bdf0b5850f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147169
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Justin Luth  <justin.luth@collabora.com>  [537da891fe42f432ea5d9f5e44579ae9a11722e3]

        remove redundant mbWasShapeInPara = false
        
        This is already reset in lcl_startParagraphGroup,
        so no need to do it explicitly here.
        
        It is not used by finishParagraph either, so safe to remove.
        
        Change-Id: I62781dd797566dd554be1f18cca1f4659fd606fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147168
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Justin Luth  <justin.luth@collabora.com>  [d0bd19dadbe9d3d676e6ab62f8e9755d060939fe]

        tdf#153613 writerfilter: RTF pre-emptive tests
        
        Anchored tests 1 and 5 were fixed by the previous commit.
        
        make CppunitTest_sw_rtfexport5 \
            CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak
        make CppunitTest_sw_rtfexport5 \
            CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak2
        make CppunitTest_sw_rtfexport5 \
            CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak4
        make CppunitTest_sw_rtfexport5 \
            CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak5
        
        make CppunitTest_sw_rtfexport5 \
            CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak
        
        Change-Id: I5e92330ed95c5c6409d2e4743ccdb7a0a331b4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147167
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [1cc1565a7032bbd33aa8d098662e2bf620f80df6]

        Update Android baseline in README.md
        
        * minimum NDK is 23 since
          Change-Id I9ea714255faf29d50bb5f8e206f13495637da867
          ("android: Require NDK 23 and use default linker lld");
          TDF Jenkins uses NDK 25.
        
        * Gradle plugin 7.4.0 used since
          commit 20989728c78008f29c7f7bf72b3d0e5189835dc4
          ("android: Update Android Gradle Plugin to 7.4.0")
          has minimum and default SDK version 30.0.3 [1].
        
        [1] https://developer.android.com/studio/releases/gradle-plugin#7-4-0
        
        Change-Id: I9d8f09b21f5ffbee4f3cc9dd7bcc7770031cec65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146243
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [a6b369c59a97dbbde40233d3ce5467a09131d079]

        android: Support NDK 24.x and 25.x, use NDK 25 for Jenkins
        
        NDK 24 dropped support for API versions < 19,
        quoting [1]:
        
        > * Jelly Bean (APIs 16, 17, and 18) is no longer supported. The minimum OS
        >   supported by the NDK is KitKat (API level 19).
        
        Therefore, use API level 19 for these (and unknown) NDKs unless
        anything greater has explicitly been specified using the
        `--with-android-api-level=<VERSION>` autogen switch
        (or is default for the architecture, s. above).
        
        Update the Jenkins config to use NDK 25 for the Android
        builds as discussed in the ESC meeting on 2023-01-26 [2].
        
        [1] https://developer.android.com/ndk/downloads/revision_history
        [2] https://lists.freedesktop.org/archives/libreoffice/2023-January/089878.html
        
        Change-Id: Ib8e65f433ee89ff1bc12432722570bf8f9f7ed85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146135
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [7fe6f298131386d80349f2fe46b1f69d31fd4af9]

        android: Move android API level check up in configure.ac
        
        No logical change intended. This is in preparation of
        using `ANDROID_API_LEVEL` in the NDK check in a follow-up commit.
        
        Change-Id: I746cae640a57a49efbdefd8ba00dcc1c4edc4ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146134
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [7e4ffea3187534326232588860e335989602e90b]

        android: Use libc++_shared path that works for NDK 25, too
        
        While e.g. NDK 23.0.7599858 has both,
        `$HOME/Android/Sdk/ndk/23.0.7599858/sources/cxx-stl/llvm-libc++/libs/x86/libc++_shared.so`
        and
        `$HOME/Android/Sdk/ndk/23.0.7599858/toolchains/llvm/prebuilt/linux-x86_64/sysroot/usr/lib/i686-linux-android/libc++_shared.so`
        (with the same content), NDK 25.1.8937393 no longer
        ships that under the former path scheme, just the latter.
        
        Therefore, use that one when copying the library,
        in preparation to add support for NDK 24 and 25.
        
        Change-Id: I20894701f4f436f41781467b57ec4f5311a8317f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146133
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [d07962c0b1395aa5edf21ba2ddbbc0574bf464b7]

        android: Use actual Android API level for minSdkVersion, nss
        
        When an Android API level is explicitly set with the
        `--with-android-api-level` switch introduced in
        
            commit 4c0bccbb21ba022fd9d630eb1d9ae34673b4dc11
            Date:   Thu Jul 4 09:06:49 2019 +0200
        
                android: Allow specification of the API level.
        
        , use that for the minSdkVersion for the Android Viewer app
        and the API level for the NSS build, rather than leaving
        that hard-coded at API level 16.
        Building with a newer API level means that the
        app won't run on devices with older API levels.
        With this in place, this will be recognized at
        install time (installation will fail: INSTALL_FAILED_OLDER_SDK)
        rather than crashing at run time.
        
        Change-Id: Id6047b768d265b965696f3a3161d7828e5f3696e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146127
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [8c1a3422dbce3236ca310e0541ca9d1ead2fc166]

        SfxRequest::GetMacroRecorder arg is always derefed before passed
        
        so null can never be seen in the function
        
        Change-Id: Iebe25ca26aa3f2105e4e20a0742c6cccbbf8b182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147150
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [7bdc09ffa44e85544d38131702c4264f006c039d]

        android: Require NDK 23 and use default linker lld
        
        Using lld instead of hard-coding ld.gold speeds up
        linking liblo-native-code.so from about 40 seconds
        to about 10 seconds for my x86 debug Android build with
        NDK 23.2.8568313.
        
        lld was added in NDK 21, made default in NDK 22 [1].
        
        lld doesn't know the `--no-keep-files-mapped` option,
        so drop that as well.
        
        ld.gold had previously been hard-coded in
        
            commit c6dadf5035c8e1c31dbd3fccec167bd4a906bf54
            Date:   Fri Nov 1 17:57:17 2019 +0100
        
                android: Fix linking of liblo-native-code.so on aarch64.
        
        , but lld wasn't available yet back then.
        
        To make sure that lld is used by default, NDK >= 22
        has to be used.
        
        In addition, due to a clang bug in NDK 22.1.7171670 [2]
        ("Misspelled -fnostack-clash-protection"), building for
        aarch64 Android with that NDK version would fail as follows:
        
            clang++: error: unknown argument '-fno-stack-clash-protection'; did you mean '-fnostack-clash-protection'?
        
        clang++ version:
        
            $ /home/michael.weghorn/Android/Sdk/ndk/22.1.7171670//toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ --version
            Android (7155654, based on r399163b1) clang version 11.0.5 (https://android.googlesource.com/toolchain/llvm-project 87f1315dfbea7c137aa2e6d362dbb457e388158d)
            Target: x86_64-unknown-linux-gnu
            Thread model: posix
            InstalledDir: /home/michael.weghorn/Android/Sdk/ndk/22.1.7171670//toolchains/llvm/prebuilt/linux-x86_64/bin
        
        Rather than work around that bug on LO side, require
        NDK 23.x right away, since that provides a clang where this is
        fixed.
        
        Both, non-debug as well as `--enable-dbgutil` builds
        with NDK version 23.2.8568313 were successfully tested
        for all 4 supported architectures and these devices:
        
        * aarch64: Fairphone 3 Plus, LineageOS 19 (Android 12), API 31
        * arm32: Samsung Galaxy S4 I9505, LineageOS 17.1 (Android 10), API 29
        * x86:
            * AVD: Nexus 4, API 16
            * AVD: Pixel 2, API 30
        * x86_64: AVD: Pixel 2, API 33
        
        [1] https://developer.android.com/ndk/downloads/revision_history
        [2] https://bugs.llvm.org/show_bug.cgi?id=47139
        
        Change-Id: I9ea714255faf29d50bb5f8e206f13495637da867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146119
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [c11701c2126da47af7e7044d83443d3d6a9f58cc]

        android: Switch from GNU binutils to support NDK 23.x, require 21.x
        
        Relevant announcement from revision history for NDK 23 [1]:
        
        > * GNU binutils, excluding the GNU Assembler (GAS), has been removed. GAS
        >   will be removed in the next release. If you are building with
        >   -fno-integrated-as, file bugs if anything is preventing you from
        >   removing that flag.
        
        Therefore, switch from uses of GNU binutils to the
        corresponding LLVM tools instead.
        
        NDK 20.x doesn't provide `llvm-ranlib` yet, so bump the minimum
        version to 21.x.
        
        Also drop the previous uses of `ANDROID_BINUTILS_PREBUILT_ROOT`,
        which appear to no longer be relevant by now.
        
            commit 4082a18406c18af7b4fcef7bd501c3679c3be56b
            Date:   Wed Nov 22 23:08:06 2017 +0100
        
                android: use unified headers and llvm-c++ STL (x86) with NDK 16
        
                gnustl (and others) are to be removed in future versions of the ndk
                also bump gradle and build-tools to current versions along with it
        
                arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix
                that later
        
        that introduced one of those uses mentions issues on ARM, but building
        and running the app at least on my 32-bit ARM device (Samsung Galaxy S4 I9505,
        LineageOS 17.1/Android 10) didn't show any issues in a quick test
        with this change in place.
        
        Update the Jenkins config to switch from the now no longer
        supported NDK 20.1.5948944 to 23.2.8568313 for which building and
        running the app has been tested on devices for all of the four
        supported architectures with upcoming change
        Change-Id I9ea714255faf29d50bb5f8e206f13495637da867
        "android: Require NDK 23 and use default linker lld" in place
        on top, s. that one's commit message for more details.
        Note however that the NDK version will be further updated to use
        NDK 25 in upcoming change
        Change-Id Ib8e65f433ee89ff1bc12432722570bf8f9f7ed85
        ("android: Support NDK 24.x and 25.x, use NDK 25 for Jenkins").
        
        [1] https://developer.android.com/ndk/downloads/revision_history
        [2] https://lists.freedesktop.org/archives/libreoffice/2023-January/089878.html
        
        Change-Id: I7645f8025d42f0fa384b5bceb31bb4b1c0a44cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146118
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [6bd2da49262c94649bcba8c5760078c4a689acb2]

        osl::Mutex->std::mutex in LifeTimeManager
        
        Change-Id: I847b2718bbc9a80146e3685805faeca48203299b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [46d2d1b9ffe53f5a7a82b62179ee4d725b13f8d0]

        osl::Mutex->std::mutex in TaskManager
        
        Change-Id: I1ab5183cff5eaed9e3c0821115c7f89850d3b482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [3e36caa1ec24a465a0918dd63976dfd970a41c1d]

        HasMacroRecorder can take a reference, never passed null
        
        Change-Id: I213f2d93e49f03e88a5357af8fead32b97b2c37b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147149
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [55a5e9baa5a707b04aeda7b1ea4dc983483d5ce3]

        Resolves: tdf#151395 need to track tiff offset from start of stream
        
        when importing them from EPS
        
        Change-Id: Ia3ba2aa188f8dcee0ede6d43311c5dcdccb1eb25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147162
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [9301f4d486b13dac2a66b797d5e24eb6dc9f7582]

        osl::Mutex->std::mutex in ResultSetDataSupplier
        
        Change-Id: I75cbf133e2e632c41759515fdf8894faed599c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0d3361aa989bbdb334cc13690a5fe1698bbf0db5]

        tdf#153549 rename "Chapter Numbering" to "Heading Numbering"
        
            First patch in multipart patch to change labeling in UI.
            Additional changes probably needed in strings.hrc
        
        Change-Id: I39066fd6af81fdf1bd4aa13b1fcce12f73ab1b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147120
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [f90d45790df4d1ceda866277d8d603e3528392e8]

        ofz#56020 Null-dereference READ
        
        Change-Id: Id80522c807ac58144b1ec978251a13012e1c8ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147158
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [b63bffc2bb5a68d1f21e4035dde9a60429c9173c]

        tdf#152506 "titles" -> "headings" in tips of the day
        
           - one tip is generalised from "Heading 1" to all headings.
           - another tip has its formatting improved and a tab name corrected.
           - for both tips, link added to relevant help page.
        
        Change-Id: I394773d2b7af5434f708fe188f86d7f8a2b16e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146914
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [0908c7c1184ab7acb7b6f6740a82c2f12c296fae]

        SfxViewShell::GetViewFrame never returns null, change to a reference
        
        various null checks can be seen to be redundant and removed
        
        Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [e71080e19365aa074c56d1136dad2b09783949a2]

        Avoid storing a redundant reference that may become dangling
        
        It would be dangling after ScPoolHelper::SourceDocumentGone.
        The pointer to the document is stored in the pool, anyway.
        
        Change-Id: I10f8f2808b8dc895f85a92f7bcf4dc44516c44a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147148
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-16  Tor Lillqvist  <tml@collabora.com>  [21e9ebb75b284b140b892f6f69a779d5277044d8]

        Add comment about using WASM exceptions
        
        Change-Id: I402bf56b89b3a18f854331915f827f7512fb05e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147152
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9b8f3eebc62f1dd20d473b9977d025a908febccf]

        Fix typo
        
        Change-Id: I120fe327539bad62cc2489a73af7ccd343ceca8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147140
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-16  Stephan Bergmann  <sbergman@redhat.com>  [e2cd6fca2f94885e308e9454a2fc986b0ae5afe8]

        Improve testLocalizedProperty
        
        c3bd52f81bf733a0b9b0560794a54b2ac1e0f444 "Use the (first segment of the)
        original locale value for the workaround again" had stated:  "The added test
        code unfortunately doesn't actually test this piece of code, and somewhat
        unexpectedly receives the "default" value from the empty string locale default,
        rather than the "en-US" value from the higher precedence "en-US" locale default,
        because `aFallbacks` happens to contain an empty string, so we already leave
        Access::getChild early in the 'Find the best match using the LanguageTag
        fallback mechanism, excluding the original tag' block."  But, of course, the
        relevant code can well be tested after all, using a localized property that
        does not have a default no-xml:lang value.
        
        (And add a TODO comment about the unexpected "default" vs. "en-US" in the
        original test code, in case the LanguageTag::getFallbackStrings behavior ever
        changes and the test starts to fail.)
        
        Change-Id: I526a830a5929b6b5ad17ba57af5943954b07b86a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147137
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-16  Andras Timar  <andras.timar@collabora.com>  [cc584681cae755c6de07f343093259bbe034392a]

        set visibility of classes in mergelib+asan case
        
        Change-Id: I2eb80d0b3002f174deea0d8657cb0cdbdec5be8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147144
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [6b0e2272e6da895ae709271af01268984bb91cd4]

        This bool is redundant
        
        Change-Id: I4bc59f88cff3d28b44735b75058c4619b90e8b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147139
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-16  Caolán McNamara  <caolanm@redhat.com>  [dc214bcff335024f21c208e239cc36232d611145]

        SfxViewShell never takes a null SfxViewFrame*
        
        Change-Id: I36f3a5c77a7fb2d3cf267184e403e6cd24dbd70b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147112
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-16  Miklos Vajna  <vmiklos@collabora.com>  [2f0b16a6a9bfff1646b14412e5918b6d483b9cdc]

        sw floattable: limit vertical position for the follows of split flys
        
        The bugdoc has 2 pages and the 2nd page had a fly frame with an
        unexpected vertical shift towards the bottom.
        
        The problem is that the floattable has a vertical offset defined, but
        Word only handles that on the first page of the split table, not on
        later pages. This makes sense: we split the table to multiple pages so
        that the content fits, an additional offset on follow pages would result
        in a lot of additional pages.
        
        Fix the problem by adjusting
        SwToContentAnchoredObjectPosition::CalcPosition(), so that the vertical
        offset is only applied on master flys, not on follow flys.
        
        This implicitly means that the behavior is unchanged for non-split flys,
        since those always have a first page, which is nicely consistent.
        
        Change-Id: I8c86cd2df6868cc5c1a10dfec359f3e02f5c1102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147141
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [65efe0e2783660780da7dc126e5f34422f312814]

        use std::condition_variable for oslCondition
        
        which is both faster (because we don't need to allocate a pthread
        condition) and simpler
        
        Change-Id: I0a98432b5106c1c2b8e8ed97cbd779ef2b0c9e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146996
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b96a0a214ba98701ff56a0b531d652c6905d6c1e]

        osl::Mutex->std::mutex in ChartView
        
        Change-Id: I74974a8e11885e0bb4773b56858a69816fd1ac41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Vojtěch Doležal  <dolezvo1@cvut.cz>  [2db9105add49d2d5918717d423e91b60ceb5e838]

        tdf#72955 - Modified Bibliography entry dialog to work inside bibl. table
        
        Change-Id: I5d4072e136eb321f92973ca8e3cd749e4ce06bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147001
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-16  Paris Oplopoios  <paris.oplopoios@collabora.com>  [f2428c21c635b142b27adf020518d9b13b3baf0e]

        Fix issue where comment replies would not get a para id on roundtrip
        
        Also adjusted the test file to account for this
        
        Change-Id: I34f1d9d3a77f91396dd733785eb5b7853289508a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147034
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [bdfd8d5ab2c30b2c85bbf4354678d60811ae3998]

        no need to lock when accessing m_pInstance here
        
        as noted by mkaganski, this field is valid until the object destructs,
        so no need to take a lock
        
        Change-Id: Id0b9a1a26391d4e971bd0b37b9d6e1b1a20e163a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [857b74041aa339e56ee8b2a05a910172753ed783]

        Drop 'using namespace ::std' in dirs [u-x]*
        
        Change-Id: I8c044369826b00241496cfc7ba2463e507c0d1a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147077
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-02-16  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [79176694ddc7bce40ce2b82d3f332be8642a5167]

        Drop 'using namespace ::std' in dirs s*
        
        Change-Id: If3119a1f2274aac0bf70576458e3adb4505a2a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147076
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a38f13e364f9416a1a6d1163eba431eb1c6d5908]

        osl::Mutex->std::mutex in FSStorage
        
        Change-Id: I62980bec76425980804368ba009ffaeb6bef800a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [17827ea4974fce0a52d9986679223c670d9889ae]

        osl::Mutex->std::mutex in UcbLockBytes
        
        Change-Id: Ia84af116b705299ff4b9070f145e149c1a8a2c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147101
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8bb6e555cb4579ece3a9627d19a0a324620568a]

        osl::Mutex->std::mutex in SwDrawModellListener_Impl
        
        Change-Id: I150ac67a3f053046a6d6a7cd79323fa4595078c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147105
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Miklos Vajna  <vmiklos@collabora.com>  [5543faac1b4a92455c9c8e9f081688411f4a0cc5]

        sw: fix undo comment of FN_UPDATE_TEXT_FORMFIELDS
        
        It's updates, not an insert. One has to dispatch .uno:TextFormFields to
        see this in action.
        
        Change-Id: I3049fa34110731e15082a0163de4b08e83c76098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147109
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [46ceb1ccb792b1a9ee12b73c499c4763502ef1e3]

        osl::Mutex->std::mutex in ucb::ucp::ext::DataSupplier
        
        Change-Id: Id195c7cb676d4c7e0741adeb31f4b1a9854e8230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae5fda223143bb7a2cddf90d741e7376046da0b6]

        osl::Mutex->std::mutex in SwXDocumentIndex::Impl
        
        Change-Id: Iaaa57af9bb298f4495b4a51d3553c55a63c5b069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ca80266b730d7557dc41568b62cc29f932706b4]

        osl::Mutex->std::mutex in ChartView
        
        Change-Id: Iebb2d1352b76108e803605dc856407ce2484e5a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [acf37c3a0b54a46de29bafd27ec9b0618bd2d84a]

        osl::Mutex->std::mutex in GtkSalData
        
        Change-Id: I86fdee3310715256a76f2b6560d27d3302402ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147102
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Stephan Bergmann  <sbergman@redhat.com>  [c3bd52f81bf733a0b9b0560794a54b2ac1e0f444]

        Use the (first segment of the) original locale value for the workaround again
        
        cf7c9599e776eba8e14614cecb528d3da5778190 "Make comphelper/configuration.hxx work
        for localized properties", which had originally introduced this code, had been
        careful to ensure that the
        
        >             assert(
        >                 !locale.isEmpty() && locale.indexOf('-') == -1 &&
        >                 locale.indexOf('_') == -1);
        
        would always hold here (it had already removed all trailing "-..." and "_..."
        segments, but had made sure to stop before `locale`, which is known to initially
        be no non-empty, would have become empty, by treating a leading "-" or "_" not
        as a segment delimiter, but rather as a first segment).
        
        dfc28be2487c13be36a90efd778b8d8f179c589d "configmgr: Use a proper
        LanguageTag-based locale fallback mechanism" had changed that, instead setting
        `locale` to some value obtained from `LanguageTag::getFallbackStrings`, which
        might or might not satisfy the assert.
        
        But there was no good reason for that part of
        dfc28be2487c13be36a90efd778b8d8f179c589d in the first place:  The workaround (as
        explained in the leading code comment) was meant to be carried out with the
        first segment of the original `locale` value, not with some fallback value.  So
        put back here the computation of that first segment of the original `locale`
        value.  (And drop the misleading empty line that
        dfc28be2487c13be36a90efd778b8d8f179c589d had, for no good reason, introduced
        between the workaround's leading code comment and its actual code.)
        
        However, it turns out that there was one flaw in
        cf7c9599e776eba8e14614cecb528d3da5778190:  When the original `locale` starts
        with "-" or "_", the resulting `locale` representing the first segment will be
        "-" or "_", so the `locale.indexOf('-') == -1 && locale.indexOf('_') == -1` part
        of the assert would be false.  But that wouldn't be an issue for the following
        code (the only issue would be if `locale` had become empty, in which case the
        `name2.startsWiht(locale)` check would trivially become true, and that for loop
        would erroneously pick the child with the empty `name2`), and that part of the
        assert had merely been there to reinforce that `locale` had indeed been stripped
        down to the first segment.  A correct version of the assert would have used
        `locale.indexOf('-', 1) == -1 && locale.indexOf('_', 1) == -1` instead, but as
        the code now makes it obvious anyway that `locale` has been cut down here to the
        first segment, we can just as well simplify the assert to just the
        `!locale.isEmpty()` part.
        
        (The added test code unfortunately doesn't actually test this piece of code, and
        somewhat unexpectedly receives the "default" value from the empty string locale
        default, rather than the "en-US" value from the higher precedence "en-US" locale
        default, because `aFallbacks` happens to contain an empty string, so we already
        leave Access::getChild early in the "Find the best match using the LanguageTag
        fallback mechanism, excluding the original tag" block.)
        
        Change-Id: Ib92e714c9db4879be058529ec905e631df975424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147113
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-15  Eike Rathke  <erack@redhat.com>  [88d0559134103fdcc8bdbf77a6dbd5b93de41249]

        Add unit tests for zh-Hans and zh-Hant mapping and fallbacks
        
        Change-Id: I99db25676e38a85639f4f2fb09b7fc42cc6f8755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147111
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [94eea5aed7b3a0bea2b41e4a9e0b677cf495d2c8]

        dont use RES_MSG_{BEGIN,END} outside hintids.hxx
        
        Change-Id: Iee08120ec4ebfd39f03a949f4a759eaa415ca894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147029
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [34cc3cccb42d8f289be33d5c43181429adba8771]

        check GetFEShell()
        
        Similar to 24889135773204c6e3002dcb417c75ff1a99ccd0
        "check GetEditShell()"
        
        These two crash reports might be related:
        - https://crashreport.libreoffice.org/stats/signature/SwView::GetDocShell()
        - https://crashreport.libreoffice.org/stats/signature/SwFEShell::UpdateTableStyleFormatting(SwTableNode%20*,bool,rtl::OUString%20const%20*)
        
        Change-Id: I7ce286f7be933b34af270abd11a4c9c4c58fe4a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eb61e6980c1df0b8e8ec41d2f82ba3d3a7d00c98]

        Add extended tip to fontwork dialog
        
        * Extracted from help page shared/guide/fontwork.xhp
        The <ahelp visibility="hidden"> tag is actually content for
        extended tips in ui dialogs. Contents is not displayed in
        Help page (honoring visibility).
        
        Change-Id: Iaf97c16bf8dfd8d9a08825f551cb0ea9e59f71bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147107
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-02-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b0907967f0b44bae505045651ae393e89d5172a]

        Bump Glade release for fontworkgallerydialog
        
        Change-Id: I2ad31d3f232c7060469edced1cc7e9ea70a0d583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147106
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-02-15  Stephan Bergmann  <sbergman@redhat.com>  [847f9b446f6d87e9de0b438d07a3b2cc8a0ad88c]

        Add a rudimentary test for localized properties
        
        Change-Id: I9abe06e6f1f2b6b39cbbf07043dd9c5062ff0460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147108
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-15  Stephan Bergmann  <sbergman@redhat.com>  [c8003c409f8ea307ad66b6b3607b4864f41cfd78]

        Remove unused configmgr/qa/unit/urebootstrap.ini
        
        ...left behind by 6a370f580aaf060004536dfc8ca877c9a2114c66 "configmgr: remove
        unused old dmake file"
        
        Change-Id: I9209b672f0b3242f6801935722b3108ef692787a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147096
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-15  Justin Luth  <justin.luth@collabora.com>  [02444789bb5e59e2582fdb92a5852db9c6471eac]

        tdf#153613 writerfilter: anchors ignore prior run with page break
        
        Although an image that is INLINE with the text DOES move
        to the following page when it is preceded by a w:br,
        an anchored image does not (when it is the last property
        in the paragraph).
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_inlineAfterPgBreak
        
        I also tested with <w:t>x<</w:t> following the anchor
        and it already works correctly.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak2
        
        I also tested with <w:splitPgBreakAndParaMark/>
        and it already works correctly.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153613_anchoredAfterPgBreak3
        
        Change-Id: Ibf9c0d38c4dfe56db4e05416a40e3b7881693b17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147032
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [4f4f2f0502881fc1a26c600e84c94c62808169eb]

        clean up SwRefMarkFieldUpdate a bit
        
        - remove SwRefMarkFieldUpdate:
          * it has only one unused field
          * replace with a plain SwPtrMsgPoolItem
        - hint constness:
          * SwUndoFieldFromDoc: make ctor arg hint const
          * DocumentFieldsManager: make UpdateField arg hint const
          * however, seeing this hint is:
            a/ constructed on the stack, but
            b/ stored as pointer in undo
            likely it would be best to remove it altogether. For now, make it at
            least static, so that there is no use after free.
        
        Change-Id: Ica51a2a2ce19e1938c3a367e9b4a9e01bbb75374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147030
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2023-02-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [259ae22056b34f3477fc7ac0f31666dec41bf8ea]

        Drop 'using namespace ::std' in dirs [e-p]*
        
        Change-Id: Ibe6a2f662f5721c594d28a8e0d7340d0f3cffe95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147075
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2023-02-15  Gabor Kelemen  <gabor.kelemen.extern@allotropia.de>  [c95597ac428f6515df232a07e82af75f4e0e242a]

        Drop 'using namespace ::std' in dirs b* c*
        
        Change-Id: I59392ee7aa71c219e475a09da67a868cfdd14b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147074
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2023-02-15  Sophia Schroeder  <sophia.schroeder@libreoffice.org>  [cf7004df41333db4828d1e3f18a6c322d7f9cb1a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb05d16166e7bdaf119b434c9d613d3d88676762
          - Emphasize "OK"
            
            Change-Id: I598f51cded8f8687de89898f89489835abcddca0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147068
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [53b06ea4c1a368d9a2cf898a090aa78306e166d7]

        move image into the .ui file
        
        Change-Id: I5dad1bd0bcdbedf20d27109ca08109a1a2a6234b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147085
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [0c9f93e9079a60725e6ff62bfc4a6a8a7254680e]

        tdf#153633 color description in chart colors options always black
        
        even in dark mode. There are some other visual glitches here, just
        erase the rendercontext before drawing to it.
        
        Change-Id: I487375614c654124e116c3e9f28d78bf7f87da4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147087
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Miklos Vajna  <vmiklos@collabora.com>  [1c45e1971cdd88f54a3cfb89622fdfa6fa8fcf31]

        tdf#147258 DOCX import: fix bad char format w/ inline <w:sdt> and data binding
        
        The bugdoc had an inline SDT in placeholder mode, where the placeholder
        had a char style to define a red text color. This red color is not in
        Word, but it was in Writer.
        
        This went wrong with commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw
        content controls, plain text: enable DOCX filter with data binding,
        2022-09-19), because previously we didn't map <w:sdt> to Writer content
        controls for plain text with data binding.
        
        Fix the problem by resetting the char style back to default when the
        value of the content control comes from data binding.
        
        Interestingly office.com renders the document the way Writer did
        previously, but let's try to match what desktop Word does, that's
        probably the reference for DOCX files.
        
        Change-Id: I7eccdb843d5ab63ccf573644c61832e2ef7dae14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147088
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [23c77c80d80b46911344f2dd440f98848a1bec50]

        Resolves: tdf#30920 don't terminate app on closing license frame
        
        when there is a backing window (start center) also open
        
        Change-Id: I64051467ac90ee321b7fc54cb96775c5a1e8d3a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [cbb24a0316deaaaac3d333c468247fc5fd73a5fb]

        resave with latest glade
        
        Change-Id: Ib1cbf1869fd7b1633178e56a47977050457640f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147084
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [483166b3d05d7c8e973c2e7f1a4fbb797ca5c745]

        list icons in .hlst files otherwise they might not get packed into iconset
        
        Change-Id: I64cb4b4f12189f402334fff185d8fdf0db4e4536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147083
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [67446d9bf896f7196d796c62d29a1f7cc815d765]

        move the sc_additionsdialog.png into the .ui
        
        the mechanism for determining that an image is in use in order
        to not pack unused icons only scans .ui and .hlst files, not all
        source code, so this was fragile
        
        Change-Id: Ic06c6a451cff3def8547b3ab085be70f6870054e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147080
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [657c1a388dfcc638fd39cbd761b4f82d047a29e9]

        resave with latest glade
        
        Change-Id: I7c581b16b819b623dab667abab56fc1559129651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ea1d3d11ca113042a99effc168da834894005370]

        MCGR: Add GradientSteps to GeoTexSvxGradient
        
        Move GradientSteps data to GeoTexSvxGradient and adapt
        interfaces. Also move tooling to more isolated place
        in gradienttools in basegfx.
        
        Keep everything still compatible, the work will be now
        to adapt all six different derivations of
        GeoTexSvxGradient to make use of the evtl. given
        GradientSteps.
        
        Change-Id: Iaa212763c603d46de0a94b1b203b979bb7ce359d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147050
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-15  Tor Lillqvist  <tml@collabora.com>  [d88fa033f02b70e28dbef6b42a4e73abc24c3a60]

        Make a few warning messages a bit more useful
        
        Change-Id: Ie533e76532f2ee6477cce8042d958d36bf9ebb9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147082
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-15  Paris Oplopoios  <paris.oplopoios@collabora.com>  [a36be102d6e94fd4b2a379a1bbfe2aefd0614d6b]

        Add paraIdParent to LOK notification attributes
        
        paraIdParent has to do with which comments are replies to other comments
        which differs from the parent attribute which has to do with
        which comments are in the same thread with other comments
        
        Change-Id: I27feba55eadeeff22d409f69d8df976ad85e0ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147021
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3914491f0717a1842bf9a29a399bb5ef0c2f2db4]

        tdf#153444: sc_subsequent_filters_test: Add unittest
        
        Change-Id: I9b58c396f18764e1821f7d5063bba5559bfbf021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147043
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [db54b5e778828279394bbe310358e40dac27bf13]

        tdf#146260: sc: Add UItest
        
        Change-Id: I1ff644745344cb847fd0b4c7b20551ad189cb383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147081
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [83fffbbd5eda463c4e344016bfec74fa5b2020c2]

        new comphelper::SingletonRef
        
        to replace salhelper::SingletonRef, but using a std::mutex instead of an
        osl::Mutex
        
        Change-Id: Ibf88a3778f47300c08b8ec9ee58ed24eb83aed7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f43a0dd760ad832ab6963d670ba13f0f43900fe]

        simplify s_getCalendarWrapper
        
        it is not really using the SingletonRef, since it never allows it to be
        destroyed.
        
        Change-Id: I17226fd9766e8dcc53eb515cdd9c276ca5174d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [aaeea11b622f96ac5d107d4b09162499f5061a38]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 691b11f75851d7d3d9c386e8316adf68d0c020ff
          - add link to Using sections in related topics
            
               refactor <h1>,<h2>,<h3>,<relatedtopics>
               rename German id
            
            Change-Id: I741b76916b8467bb704e499e66ca0f802337679c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146798
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8d0f4b849a8930ea592063f0f321564f1a87df2b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 42aea4d1f012d72a583289d2dc11f21d500f3f65
          - tdf#147910 Update template manager Help page
            
            Change-Id: I526941543e3113f7196a855f61a2d3d715d3d73f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147028
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [199a34194d354f8d05d5a1cea680d63cb3303996]

        ofz: Use-of-uninitialized-value
        
        since:
        
        commit bbdbe8ea2ef176ef6f08b30b3c18876c2c4f0c22
        Date:   Fri Feb 3 22:55:54 2023 +0100
        
            tdf#142018 Properly create Pen width if style is COSMETIC
        
        Change-Id: I739932e7bbf427a72bf16a771c20b6bd5596da5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147041
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c18849cc682a88c4d341fe4c12a69332140a367]

        tdf#79571, tdf#151794, tdf#153622: sc: Add UItest
        
        Change-Id: Ie0633b02eab63892f95201d34899f4f9b9d06a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147053
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [944d855f2fb4eb2a50c0e678c4fe51eb93e4e567]

        tdf#153611 Opening dialog via macro no longer works
        
        regression from
            commit ba4191ff0de05334ba32b53a09ad992710f03f9d
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jan 30 21:48:53 2023 +0200
            osl::Mutex->std::mutex in ImplEventAttacherManager
        
        Change-Id: I4022c1e6b9c00d975eaa9e095994d7635aeb64b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147047
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [9d6c5f13ff031c18d3c117e4de212e2550d24e8c]

        tdf#153172 Options > Charts > Default Colors no longer persistent
        
        regression from
            commit b95142c11e80c58b70dff68bfd7f3792657b9ee2
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jun 20 19:17:00 2022 +0200
            tdf#58134 Reset Button in Options Dialogs
        
        Change-Id: Idef9880e29c322ae2d11641354baf8a241fc7fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147049
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Miklos Vajna  <vmiklos@collabora.com>  [dab3de66e057f8d6794c427fb38cb2e333dfc93f]

        sw: fix crash in SwView::AttrChangedNotify()
        
        Crashreport signature:
        
        program/../program/libswlo.so
                SwView::AttrChangedNotify(LinkParamNone*)
                        sw/source/uibase/uiview/view.cxx:507
        program/../program/libswlo.so
                SwWrtShell::DrawSelChanged()
                        sw/source/uibase/wrtsh/wrtsh3.cxx:261
        program/../program/libswlo.so
                SwDrawView::MarkListHasChanged()
                        sw/source/core/draw/dview.cxx:767
        program/libmergedlo.so
                SdrMarkView::MarkObj(SdrObject*, SdrPageView*, bool, bool, std::vector<basegfx::B2DRange, std::allocator<basegfx::B2DRange> >&&)
                        svx/source/svdraw/svdmrkv.cxx:2196
        program/../program/libswlo.so
                SwDrawContact::DisconnectFromLayout(bool)
                        /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/stl_vector.h:336
        
        This seems to happen when the SwDrawContent delete is in progress, so
        we no longer have the shells at hand that are usually present.
        
        Change-Id: Iba0601654c946b85e7c2de33fe76d99b26a20eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147052
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [af35aac915019d0199c8628211e709b395e88735]

        crashreporter: apparent null dereference
        
        Change-Id: I83f0765311ffdb34a0c08aaf616fdbde4e5110a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147048
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [2df61f1ea0cf85adf4c134ff98348e348e8c3d9a]

        ofz#55981 Integer-overflow
        
        Change-Id: Id854f455f684c3eb11351da63dc173c1be8677bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147044
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [0723238a88ae16af061f0a050b704d2299a28a9a]

        replace RES_GRAPHIC_PIECE_ARRIVED and RES_LINKED_GRAPHIC_STREAM_ARRIVED
        
        - also use SfxHintIds and get rid of some dynamic_casts
        
        Change-Id: Id12d72fb726c1d747008f72defd6ba9eba3ba253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146820
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-15  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [ef0d23e6b7a8330e070c93a59c33b0ce4a8896d5]

        SwContentNode: assert on dead code
        
        Change-Id: Id094b0c244a55581fe3db1773788b4dd31698a24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146963
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-15  Julien Nabet  <serval2412@yahoo.fr>  [a16c64ad808c3ef79fb9b8954c4f33e9e0ff855a]

        tdf#153559: Untranslatable string in safemodedialog.cxx
        
        Change-Id: I35bccb70bef74b6438c2744f693aff6d1842e894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146830
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f6704cb9145e69c4216d6ddf097f35183bbc4005]

        Fix typo
        
        Change-Id: I35eea3bd994dc4fca71c51c2a78a4f83988201fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146898
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [123f0fe12159cc33d4b882f5b847d78ff258e2a3]

        Fix typo
        
        Change-Id: I738be032f9300c556a0643c0ab04b54bd5ad8ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147042
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-15  Tibor Nagy  <nagy.tibor2@nisz.hu>  [8c9a6abf30e9ff1ebd5647f7c271e0d64643860a]

        tdf#138601 XLSX import: fix priority of conditional formatting rules
        
        Multiple conditional formattings can intersect or have the same
        range of cell with different rules. Without sorting the rules
        by their priority, the cells got bad formatting, e.g. different
        colors than what was set in MSO.
        
        Change-Id: I619359877f1a3e55fc8f895d5ba6f0f4f30e07f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146513
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfbbdab13f16adf66f1afb9e2a2a103162927ba3]

        osl::Mutex->std::mutex in LockFileCommon
        
        Change-Id: I729b7ecf8280c67e4698b174a6151d1eda41be60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [ddf4f82443254d88d9b984c68ed05fa16bb4607a]

        use upstream suggested fix
        
        Change-Id: Ibe61144ea45211aa1b68e51d267ce5b7e1764839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Stephan Bergmann  <sbergman@redhat.com>  [b4c8775526d701cfe0230ca34bfbbb9be00a71e7]

        tdf#153519 Another TreeListEntryUIObject heap-use-after-free
        
        ...similar to the one addressed with the commits leading up to
        9a23ded27470a4c57015e9e5d686259a60d464f2 "Fix thinko when to sleep"
        
        Change-Id: I13d974600275554fb3c66f836a07b96b5d6a2639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147039
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-15  Caolán McNamara  <caolanm@redhat.com>  [c9ab5237afa7bb106e97a9afa036df723f0238e8]

        Resolves: tdf#153622 crash in SvListView::SelectListEntry
        
        probably since:
        
        commit 4c8b1fa44d4f49510d3910981e649dcb08bceb36
        Date:   Fri Oct 28 13:15:00 2022 -0400
        
            tdf#151794 sc validate: honor NO_BLANK in Cell range dropdown
        
        Change-Id: Id6752126c0c8df8d813bc862e5533d05bba1b622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147027
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-15  Stephan Bergmann  <sbergman@redhat.com>  [d22f3b8c787b93c38925adf92af542362dbda3e6]

        Remove css.xml.xslt.XSLT2Transformer not implemented by LO
        
        (see f4238ed900cdfa65d447fbef81b2e8ae95095a4e "Revert 'XSLT2Transformer::create
        should always succeed'": "LO does not ship this service, it's only provided by
        Saxon extension")
        
        Change-Id: I8ff8c9e4bd0eae7055dcb4fc83a04ea41310b9a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147038
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-15  Tünde Tóth  <toth.tunde@nisz.hu>  [da725dfe07f2cf10349772d1667591c4d6a6fe8a]

        tdf#153179 ODP export regression: fix lost shape at missing object
        
        If the object is missing, it's still possible to keep its shape
        by exporting its preview graphic, as before the regression.
        
        Regression from commit adc042f95d3dbd65b778260025d59283146916e5
        "tdf#124333 PPTX import: fix Z-order of embedded OLE objects".
        
        See also commit 907da02bf8b33c080538731864225b3c44251328
        "tdf#152436 PPTX export regression: fix lost shape at missing object"
        
        Change-Id: I614730435a857c6cdf01d4cdfc525fc452dffa29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146247
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-15  Miklos Vajna  <vmiklos@collabora.com>  [7fb8b73ad320e32af130ceddec80a9ff08407eab]

        DOCX filter: fix horizontal pos of floattables with compat mode >= 15
        
        The floating table in the bugdoc has a small negative horizontal indent,
        which carefully aligns it so that the contained paragraph lines up with
        the text above the table.
        
        It turns out that compatibilityMode >= 15 doesn't do this anymore in
        Word, so we should at least avoid this tweak on import/export when we
        know the compat mode.
        
        Fix the problem by avoiding the <w:tblpPr w:tblpX="..."> decrease during
        import and the matching increase on export. This is similar to what
        commit 9a31d1c83e08600507689dc18f6f0973bc7e4389 (tdf#106742: OOXML
        import/export: treat "tblInd" properly., 2017-04-04) did for
        non-floating tables.
        
        I discovered this while working on multi-page sw floattables, but this
        is relevant for single-page sw floattables as well. Next to the modified
        testcase, sw/qa/core/layout/data/floattable.docx is also a good test
        file, which shows how the left border now lines up with the body frame,
        and there used to be a noticeable gap there. Now
        sw/qa/core/layout/data/floattable.docx gets rendered ~perfectly (with
        SW_FORCE_FLY_SPLIT=1).
        
        Change-Id: Ia52202f1bc3274f4ce2b7ee02c85d07589454ae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147037
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [95f69903640f8b6d3c0c5798b74339d0ae62bd05]

        osl::Mutex->std::mutex in SvxShape
        
        Change-Id: I4b2d13dcd87f49cb73e7239102498629239005d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147036
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Vojtěch Doležal  <dolezvo1@cvut.cz>  [a3a151ccfbb7560f7e96523efa350b174888f359]

        Refactored SwAuthorityField::GetAuthority
        
        The current version takes pointer to too complex of a structure, does some insane (and completely pointless) const_casting with it, and isn't very practically usable due to only supporting calculation for format of a default TOX. This refactor solves all these issues.
        
        Change-Id: I582be2ecdbd83650c0c30ee9df786feffdc6cb99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147000
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-15  Miklos Vajna  <vmiklos@collabora.com>  [ffff0aea3629fde375ee888c255c75a5857364ec]

        CppunitTest_sw_htmlexport: avoid preTest() in testSkipImagesEmbedded
        
        Set the filter option explicitly, rather than inferring it from the test
        name.
        
        Change-Id: I943a33ff71ac957db8abd0748397330fe61e60e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147025
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e8f06979902e5dbd6acf7ac8290ba5ece9da667]

        no need to use unique_ptr for OMultiTypeInterfaceContainerHelperVar4
        
        it has an empty size of two words, so it saves very little memory to use
        unique_ptr.
        
        Change-Id: I2958a83c41929dec3d33db27f084dafec385d74d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fd76d69adab591789e551b30324183df2874961a]

        tdf#153499 missing colon in subdialog to Insert Index Entry
        
        Change-Id: I50236c71835fb03ab243417252e5f54075a4b0be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146989
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-15  Kohei Yoshida  <kohei@libreoffice.org>  [99bad52f534b0f9e5aebcf0a65e1787ac9f09d94]

        Switch to static rules table and add a few more entries
        
        Hopefully it's easier to add new rules.
        
        Change-Id: I893ea5de5bcc5535f2f49a682de33ff2fcfffd48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147035
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-02-15  Kohei Yoshida  <kohei@libreoffice.org>  [e5b55f8e05f0f3172340ee377c7dabfb714dd66c]

        tdf#153444: map iso-8859-* encoding range
        
        Change-Id: I6eed711e788955f17c7b8a40db77370e0dc57213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147033
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-02-15  Justin Luth  <justin.luth@collabora.com>  [387240968cd89e294be5a7a1bec533df464f0943]

        writerfilter: don't clear breaks when IsInComments
        
        A few lines earlier we avoided applying deferred breaks
        when IsInComments (and shapes), so why would we avoid
        clearing all breaks only for shapes? That doesn't make sense.
        
        Rearranged the code slightly to put all related items
        together.
        
        Change-Id: Ifbe911624b8190813fe2a57362e4ad7ccf1e712e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147031
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d0bb675cbf7582cd153ead7806b15d4c22117bb0]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I460e5cd984d410e4b937cb42be55864fc6b97db7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147012
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-14  Andras Timar  <andras.timar@collabora.com>  [eca098746604b6a6032cce2aa20394fca782123c]

        fix error: macro UNIX_DESKTOP_DETECT is not used [-Werror=unused-macros]
        
        ... when HAVE_FEATURE_UI is 0
        
        Change-Id: I353189a9cfd9eeb3d96008c440ff403d3634f14c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146980
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [0f5218d04b17c256dd04c99b1c2ed1d9e685856f]

        tdf#153541 update icons in notebookbar when theme changes
        
        not just when the config changes
        
        Change-Id: If935160e93d96d7ccb4b425346e0440fc4420dd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [ab07248af6fd7c6af631875cecb759ecf1ad1e7a]

        tdf#153541 NotebookBar not getting settings change notifications
        
        NotebookBar is a child of a BorderWindow, which is an unusual parent
        for a widget, special handling is needed in that case to get updated
        when Settings change
        
        Change-Id: I1eca5188cb3aca974281987b7b3619b77bb5f26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147008
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [e2d8474857e8b39efcdf21441c95ad51a8aef6e8]

        Let +TIMESTAMP and +RELATIVETIMER use the same osl_getSystemTime
        
        ...so that the reported numbers add up if you specify both in SAL_LOG.  Also
        make the code look more symmetric.
        
        Change-Id: I8b24dbe7cfa4d7aaebd2069db87a4e9d5fe6e3f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147017
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e6e0270d25c4181ed15bd04123e20672f1e3a0b]

        no need to use unique_ptr for OInterfaceContainerHelper4
        
        it has an empty size of one pointer, so it saves no memory to use
        unique_ptr.
        
        Need to fix the const-ness of some methods in OInterfaceContainerHelper4
        
        Change-Id: I0c0c28a228ccfe0e97174fbc83555059fc351b3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [b429ca9b45b897da4c47a261ff582b536f27acd6]

        no need to use unique_ptr for LinesType
        
        it is already a moveable type
        
        Change-Id: If149c051365453ea9fe77c030438f3dfc799428a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ba547ae90991547ab46e5c9b871078c39f51174]

        osl::Mutex->std::mutex in SortedResultSet
        
        Change-Id: Id55c139cfcc55e18811fd79e402a78b123f37394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [fd92b09db497a7dfd594a5418f87856dc3886bf9]

        tdf#153541 notify listeners when any of the icon sizes change
        
        not just the "normal" toolbar, but also the "notebookbar" and
        "sidebar" ones. Existing listeners have assume that this is the
        case, so match their expectations to get the notebookbar to
        track the config when it changes.
        
        Change-Id: Ia6024217ad97374f753e1db6305eda011e42b85d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b8170c885c14e46d6bc3e2a3686f80d52f021d3]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I4bf752ed3a77f6e81c81bd3bca66957c6ec44e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147011
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [c83516b378a1587fd099b550d046c89841e8add9]

        tdf#153604: sc: Add UItest
        
        Change-Id: I3edcb60c793354b4471052e428ef6ac1b93cbdd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147005
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [93059e2b164bd5eea4898519e45f1001f299c4ae]

        osl::Mutex->std::mutex in ScCellFieldsObj
        
        Change-Id: I7e9a95d093573d786b97f79f9f3b1f18c424fd8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Justin Luth  <justin.luth@collabora.com>  [ce0b9f3eb3f57f57a2315e099a0093c33987e6ca]

        tdf#153602 writerfilter: clear isDummyPara after processing table.
        
        Once the table is processed, the fact that we had a dummy paragraph
        is no longer relevant to the section. So, after carefully figuring
        out that we have had some other paragraph in the main text body,
        clear the dummy status used to control bRemove.
        
        This fixes the problem of adding an empty paragraph each round-trip.
        
        Unfortunately, this would still fail if for example there was only
        another table following the first one. Well, it wouldn't fail that
        badly because the first save would add an empty paragraph,
        and then following saves would use that single empty paragraph
        as the one that resets things. So we always have at least one CR
        following a table, but at least they aren't multiplying.
        
        Unfortunately this isn't at all clean, because as soon as
        the table starts, we no longer know that it is the first
        paragraph in the section. (The other table paragraphs
        and potentially header, comment, footnote, shape etc
        can all set IsFirstParagraphInSection to off.
        Basically, most flags are completely useless since
        they are not stacked in any way. So we are left with
        a multitude of conditions to check for everything.
        
        Change-Id: Ic6a9795a6c529f8b5dd4f5d1cccc89db01b03d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146955
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [6190a8210e089195aca9b5091fcc7166fca3beaf]

        disable script dump
        
        Change-Id: I04d740cc0fcf87daa192a0a6af34138278043a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146905
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [f4238ed900cdfa65d447fbef81b2e8ae95095a4e]

        Revert "XSLT2Transformer::create should always succeed"
        
        This reverts commit 304ebfad5193c857e4edf18cb05d61b6ccc1f7d0.  As mst pointed
        out on IRC, "LO does not ship this service, it's only provided by Saxon
        extension".
        
        Change-Id: Iafb416f3a3385345fd74cf76af4e9f600ff8eb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146975
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ee1b714c13db308c199172ffa0199405ca3d9c3]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: If1d0226860f4befe7f531fda7260c8b4147f2079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146606
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d05f115518615d957bf8cfde15fc61facd28cec]

        osl::Mutex->std::mutex in datastreams::ReaderThread
        
        Change-Id: I4851fca7e9f4433bda79b86a0d5cc7842ff45bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146994
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [7becce20b54973337d9803527fad0b957a56ab31]

        osl::Mutex->std::mutex in ScHeaderFieldsObj
        
        Change-Id: I9e308eee9534297b7257185d6b5f244d4fa86178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f59cbe6f0d879275ddd82dd0eaf224cbd1dec21]

        osl::Mutex->std::atomic in DispatchWatcher
        
        Change-Id: I7cad64f9031dd05e08321110ec670d3c744f03c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [41c3c2dfaeee7fbd410fd76d4254ae9696a173a2]

        tdf#150045 A few more supplemental labels
        
        Change-Id: Ifc0afe5c04145378b5fe32b12791c774d96f8a9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146903
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [db6fbb0317fcb0a7babca9f71adbbb7c126b9e4e]

        base section Titles are invisible in dark mode
        
        Change-Id: I46848169f9376588e91d9684e47f388074c41493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146997
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [1b180c444d0c7d8b2df66c88f0bdadfec4896b00]

        Resolves: tdf#149482 don't insert if the mouse is not still pressed
        
        In repeat callback, if we didn't see a mouse up, but find that the mouse
        is no longer pressed at this point, then bail
        
        Change-Id: I6e5d1d7201065fadcc2242fd52323ffb56766383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [20f3339834bedd4a62731f69c954dc6e6607bec5]

        fix locking in PersistentPropertySet
        
        after
            commit 756185b5795c95180d32d02abfbd65951779b40e
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 13 09:06:02 2023 +0200
            osl::Mutex->std::mutex in PersistentPropertySet
        
        Change-Id: Ie52432ea1566b840bd88692f00f4753eea7896f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146998
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [85d1ead3f9f23f78db0eee161eb0fc199d4b766c]

        tdf#149786 sc: add VBA function: ExportAsFixedFormat
        
        Add ExportAsFixedFormat VBA function for calc.
        
        Works fine with Workbook/Worksheet/Range objects
        
        Optional parameters:
        - Type: works but only with xlTypePDF. (xlTypeXPS not supperted by LO)
        - FileName: works but not clear the xlQualityStandard or xlQualityMinimum real value,
        so just used the lossless export in case of xlQualityStandard and 70% JPEG compression quality
        for xlQualityMinimum.
        - IncludeDocProperties: works
        - IgnorePrintAreas: TODO
        - From: works
        - To: works
        - OpenAfterPublish: works
        - FixedFormatExtClassPtr: TODO?
        
        Change-Id: I128fd880a82a5dd315897496c6f21bb9a7c2270b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146512
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-02-14  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [75a863ee7fea133ae6bcd010d1aac46815fa49e2]

        tdf#134283: MakeSetList should iterate Setters, not Getters
        
        Change-Id: I811a3b562ead942c98705da29774b77c593eabc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146828
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [085466ae72ec5da60a850a7c8cc97fea10992996]

        osl::Mutex->std::mutex in OpCodeMapData
        
        Change-Id: I0b92e2a94060549c39df7d08a6409518252fc757
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Miklos Vajna  <vmiklos@collabora.com>  [1cf13b8b11e7c122631394e308b66b46ffaae718]

        sw floattable: improve handling of split flys in SwTextFrame::FormatEmpty()
        
        The bugdoc had a non-empty paragraph after the floating table, we
        painted that text on both page 1 and page 2, while only page 2 is
        expected.
        
        We want that paragraph to be on both pages, but we want to split it
        before the first char, so apart from providing a place to serve as an
        anchor, it should be invisible on page 1.
        
        Fix the problem by extending SwTextFrame::FormatEmpty() to consider the
        master anchor text frame as empty in case it has no text, just
        intersects with a fly frame.
        
        Also improve SwTextFrame::HasNonLastSplitFlyDrawObj() a bit, so it
        returns early when the own and the follow offset is not the same. These
        are cheap checks and some callers already did it before iterating over
        all the draw objects of the text frame, but other callers didn't do
        this. Now we check for this consistently, everywhere.
        
        Change-Id: I4b399ae3f9e9f364c61d977359f6c9b16c648629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146969
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-14  Caolán McNamara  <caolanm@redhat.com>  [c4de5f1f40f7392306daaae8c05481ea346bbeb0]

        tdf#153332 reset background to default if new preview has no bg
        
        but the old did
        
        Change-Id: I59ebd4d5974c5d67c4ac572b091febed879fc290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [3900b3b4cdef25287f0dcff130cc36a8aa81b47c]

        UBSan needs SwFlowFrame RTTI to be public now
        
        ...for CppunitTest_sw_core_layout_flycnt newly introduced in
        995198bfff4ae8abaf2129fe99d9f8ef899a4f25 "sw floattable: handle table-in-fly in
        SwFrame::GetNextFlyLeaf()"
        
        Change-Id: If006a912d365642181b0bc80dc21c55d42214e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146967
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Miklos Vajna  <vmiklos@collabora.com>  [2771f01965d9a9542ecc645a2a708a17f541df07]

        sw: document SwAuthorityField
        
        Its invariant was already documented, but it wasn't mentioned that the
        UI's bibliography entry is called an authority field internally.
        
        Change-Id: I55a946a5bdb59e8d6e1def54b16d0c986e531c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146942
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [89fa0a42ecd71ee9e4f80d127ced396c79d5e650]

        osl::Mutex->std::mutex in LoadEnvListener
        
        Change-Id: If76feb51f0d2f187603fb1af7c27bbe3391b645b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146944
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [7da5639531303c7de34382c5030b67a489a6e3d5]

        osl::Mutex->std::mutex in ConfigurationAccess_UICommand
        
        Change-Id: Id92161815cd1f336c030aa4491e67a84aaddeb87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [862eda5f187d77f8d1f6e2a45fa33f8dd1ad5d5b]

        --enable-qt6 constexpr template point of instantiation issue
        
        ...with --with-latest-c++,
        
        > In file included from vcl/qt6/QtMenu.cxx:10:
        > In file included from vcl/qt6/../qt5/QtMenu.cxx:10:
        > In file included from vcl/inc/qt6/QtMenu.hxx:10:
        > In file included from vcl/inc/qt6/../qt5/QtMenu.hxx:12:
        > In file included from vcl/inc/salmenu.hxx:24:
        > In file included from include/vcl/menu.hxx:23:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:898:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:31:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'QMenu'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<QMenu>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<QMenu>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/inc/qt6/../qt5/QtMenu.hxx:40:7: note: in instantiation of member function 'std::unique_ptr<QMenu>::~unique_ptr' requested here
        > class QtMenu : public QObject, public SalMenu
        >       ^
        > /usr/include/qt6/QtCore/qmetatype.h:2331:47: note: in implicit destructor for 'QtMenu' first required here
        >                 reinterpret_cast<S *>(addr)->~S();
        >                                               ^
        > /usr/include/qt6/QtCore/qmetatype.h:2370:41: note: in instantiation of member function 'QtPrivate::QMetaTypeForType<QtMenu>::getDtor' requested here
        >         /*.dtor=*/ QMetaTypeForType<T>::getDtor(),
        >                                         ^
        > /usr/include/qt6/QtCore/qmetatype.h:2480:48: note: in instantiation of static data member 'QtPrivate::QMetaTypeInterfaceWrapper<QtMenu>::metaType' requested here
        >         return &QMetaTypeInterfaceWrapper<Ty>::metaType;
        >                                                ^
        > /usr/include/qt6/QtCore/qmetatype.h:2537:16: note: in instantiation of function template specialization 'QtPrivate::qTryMetaTypeInterfaceForType<(anonymous namespace)::qt_meta_stringdata_QtMenu_t, QtPrivate::TypeAndForceComplete<QtMenu, std::integral_constant<bool, true>>>' requested here
        >     QtPrivate::qTryMetaTypeInterfaceForType<Unique, T>()...
        >                ^
        > workdir/CustomTarget/vcl/qt6/QtMenu.moc:106:5: note: in instantiation of variable template specialization 'qt_incomplete_metaTypeArray<(anonymous namespace)::qt_meta_stringdata_QtMenu_t, QtPrivate::TypeAndForceComplete<QtMenu, std::integral_constant<bool, true>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QtMenuItem *, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<void, std::integral_constant<bool, false>>, QtPrivate::TypeAndForceComplete<QAbstractButton *, std::integral_constant<bool, false>>>' requested here
        >     qt_incomplete_metaTypeArray<qt_meta_stringdata_QtMenu_t,
        >     ^
        > vcl/inc/qt6/../qt5/QtMenu.hxx:23:7: note: forward declaration of 'QMenu'
        > class QMenu;
        >       ^
        
        Change-Id: I4b4a227411c380e97d4c357708009c5905cef44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146949
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [9a466b75e373396cf8e9d21481b79ef3fd97c066]

        Simplify code a bit
        
        ("instantiation of XSLT 2.0 transformer service failed" would mean that it
        throws an exception, not that xTransformer would be null)
        
        Change-Id: I8994c4b8d1c7ade8d5c7ef93569315d45fc7265d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146950
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Stephan Bergmann  <sbergman@redhat.com>  [a2db1a1a4a1655034c27a64c1d67751752575856]

        Remove an unhelpful try/catch
        
        The theMacroExpander operations should never throw, so better leave uncaught any
        exceptions that would happen after all, rather than silently swallowing them.
        
        Change-Id: Ic5160a69e7cd7412c91ae3589b3dc89f6fe4c43b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146951
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-14  Kohei Yoshida  <kohei@libreoffice.org>  [4d9a8f07b77917b0756dc2d8d8082c6e63e560a2]

        tdf#153604: include the root element when traversing the tree
        
        Change-Id: I35098e687eea832c075f68861e04be7b492ed25e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146966
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-02-14  Justin Luth  <justin.luth@collabora.com>  [80f9ad23282e0d8c4ba3441797d4899b9555eee3]

        tdf#153592 writerfilter: don't defer breaks into shapes/comments
        
        When starting a pargraph, we already had a clause to avoid
        deferring page and column breaks when we were in a shape
        or a comment. These clauses are also necessary
        in the other sections of the code where we defer these breaks.
        
        The provided test proves the two shape cases in lcl_utext.
        I just took IsInComments along for the ride,
        as it certainly would apply in that case as well.
        
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153592_columnBreaks
        
        ooxmlexport4's testTdf81345_045Original proves that it is
        also needed in lcl_text. However, it is such a complex document
        that I wasn't confident that a unit test would be stable enough.
        
        Change-Id: I2de15341d3e756bf47fcd85b868a849c8a2419cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146939
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [befcb86946c049c1a430c95f93ab47ba6ffcdf4e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd49917023bc58662fa1c6be7294f66955f04525
          - Rename Extension Manager to Extensions
            
            Follow-up to core commit ef3c81d0fca9c8f80fd0d4e4025c37a114528344
            
            Change-Id: I904f88bd184fb4ea10eb050c21d40041494e2e33
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146952
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [155dd761e85600445e95f1f2a844d44544446a64]

        osl::Mutex->std::mutex in ContentResultSetWrapper
        
        Change-Id: I8d015bf1435c6b3becd40ffd9056b9906a6dd19b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [45d9d71c3acdde55743bc8c08fc36d44a5bdd5b4]

        osl::Mutex->std::mutex in DynamicResultSetWrapper
        
        Change-Id: I218460fac22e65f583a545d41720b0301b67c502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [af63914153074b127fe3bc7aa90bebe5fbee23d6]

        Fix typo
        
        Change-Id: I587c742957da0bb40ff858180f27b62549ebadbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146912
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [382e5a506e8c12e5c7af86d2fa018d00064f89d3]

        tdf#152605 (tdf#137968) "heading level" -> "outline level"
        
          Reformulate error messages for headings whose outline levels
          are not in sequence.  
          
          UX cleanup: Add missing periods to error messages.
        
        Change-Id: I62b8f7af79460b644fae20dd521a160907605b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146807
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [bc65001a161f898809248eb899c36341ad2d550b]

        Fix the build
        
        ...after 756185b5795c95180d32d02abfbd65951779b40e "osl::Mutex->std::mutex in
        PersistentPropertySet" caused
        
        > ucb/source/core/ucbstore.cxx:1913:75: error: too few arguments to function call, expected 2, have 1
        >             m_pPropertyChangeListeners->getContainer( rEvent.PropertyName );
        >             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                      ^
        > include/comphelper/multiinterfacecontainer4.hxx:71:50: note: 'getContainer' declared here
        >     inline OInterfaceContainerHelper4<listener>* getContainer(std::unique_lock<std::mutex>& rGuard,
        >                                                  ^
        > ucb/source/core/ucbstore.cxx:1921:66: error: too few arguments to function call, expected 2, have 1
        >             m_pPropertyChangeListeners->getContainer( OUString() );
        >             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~             ^
        > include/comphelper/multiinterfacecontainer4.hxx:71:50: note: 'getContainer' declared here
        >     inline OInterfaceContainerHelper4<listener>* getContainer(std::unique_lock<std::mutex>& rGuard,
                                                         ^
        
        Change-Id: Ie13c7bf17d066607ec7095b3e45ab7d6ecea1cb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146940
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [63a320d9b42ae6729b144b4d1be376d1efe9e3c7]

        Adapt to renamed libcairo-lo.so.2
        
        ...following up on d552b4a549d614a03aa9328e017dec27bd3ff41e "Enable opening of
        downloaded fonts only in ForKit in Online" and
        9eaa1325a014ff76acd3290752f842ed6bad89ac "Only package the external/cairo
        library that is named the same as the SONAME"
        
        Change-Id: Ifec89813140dcca5eea13943a12883febb6c5cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146934
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [8589cfab808935fbcade39866145074bdfeaae81]

        Assume that only vnd.sun.star.expand URLs shall be macro-expanded here
        
        ...even though XSLTFilter::expandUrl did that unconditionally ever since the
        function's introduction in 3218e6592694da70760c1a42b7c562c6864799b2
        "INTEGRATION: CWS xsltfilter09".
        
        Change-Id: I08022091bc15048478c08e3f0f5cfffbb954df5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146911
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [304ebfad5193c857e4edf18cb05d61b6ccc1f7d0]

        XSLT2Transformer::create should always succeed
        
        Change-Id: Ie2aa4fe48da2362ff1a88fa44a51bed498a4f432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146935
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [6b2e8bb614ee4cc755766c8b7590df0c10f89a27]

        Fix CustomTarget_postprocess/check_dynamic_objects for --enable-qt6
        
        Change-Id: Id1e76a7ed728beb359e0944b51de84bf720490ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146910
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Caolán McNamara  <caolanm@redhat.com>  [0d2ef5bd553942b1307a0a69462ae980368b2076]

        ofz#55872 fix oss-fuzz build wrt fontconfig not getting built static
        
        change from static to dynamic was hidden away in commit:
        
        commit d552b4a549d614a03aa9328e017dec27bd3ff41e
        Date:   Tue Sep 20 16:07:14 2022 +0300
        
            Enable opening of downloaded fonts only in ForKit in Online
        
        Change-Id: Ia6e636fdbdac31f6cf746fc70c892d71462a9619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fbaff8f022a5d1a09a22dbfc6395c458bfc5bfd]

        enforce proper locking when calling OInterfaceContainerHelper4
        
        Change-Id: Ic86305f3d16148925c7753200a687f36f08a6516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [39a956dcf5c40c95a97768346046366c93abc60f]

        tdf#153499 Add missing colons to labels with buddy controls
        
        Change-Id: I1260503e12516b3b29d34a317ca3a58cc314b608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146920
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Tested-by: Jenkins

2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fdee9f9864f7f119e0503e1d9e1b7ff7250025e]

        osl::Mutex->std::mutex in DynamicResultSetWrapperListener
        
        Change-Id: Ie8673462fac30132f4e6b3cf7792d8554bf4f14a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146901
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcd2650598dbe7c2c6bcaa693f5ba3880e08c4ad]

        osl::Mutex->std::mutex in PropertySetRegistry
        
        Change-Id: I08a059998cb13f12ad6183ee54754525386dfcd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [756185b5795c95180d32d02abfbd65951779b40e]

        osl::Mutex->std::mutex in PersistentPropertySet
        
        Change-Id: If88ac207083a928e2315e2ec1c7ac40951fb2a6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [47b7e11fd7345fcaaf186706319636c135cdb5e8]

        Preserve nullptr between gtk_assistant_get/set_page_title
        
        ...in case that might make any difference.  Even though
        <https://docs.gtk.org/gtk3/method.Assistant.get_page_title.html> and
        <https://docs.gtk.org/gtk3/method.Assistant.set_page_title.html> claim that this
        must be "a NUL terminated UTF-8 string", it can apparently also be null.  This
        is a follow-up to 6ed7a3cc51e560c6b2a6894f6829c0ac9f991ef2 "tdf#153501 Fix
        OString construction from nullptr", and at least the recipe in the comment at
        <https://bugs.documentfoundation.org/show_bug.cgi?id=153501#c0> "Crash when
        trying to do WollMux mail merge" still works with this change.
        
        Change-Id: I9851bbf31cfa5a85ef5d8c7d19a790d004984d0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146909
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Stephan Bergmann  <sbergman@redhat.com>  [9eaa1325a014ff76acd3290752f842ed6bad89ac]

        Only package the external/cairo library that is named the same as the SONAME
        
        Change-Id: Id97fe380c3e3976e56a6962eaebfbd696bab7332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146908
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-13  Miklos Vajna  <vmiklos@collabora.com>  [995198bfff4ae8abaf2129fe99d9f8ef899a4f25]

        sw floattable: handle table-in-fly in SwFrame::GetNextFlyLeaf()
        
        Trying to lay out a split fly that contains a table resulted in a stack
        overflow.
        
        The reason for this was that SwObjectFormatter::FormatObjsAtFrame_() has
        a loop that will format all objects of the current fly frame, but we
        managed to anchor the follow fly into itself.
        
        Fix the problem by improving SwFrame::GetNextFlyLeaf(), somewhat based
        on how SwFrame::GetNextSctLeaf() has special cases for tables. This way
        once we split the fly frame, we'll try to move the follow anchor frame
        to the next page's body frame, and not to a child of the follow fly
        itself.
        
        Also add a first floattable testcase, we can already assert that the
        table is split correctly. Do this in a separate suite for now, since the
        pool's default SwFormatFlySplit is only created once, so
        SwFormatFlySplit::SetForce(false) doesn't have the wanted effect. The
        anchor's text is still on both pages, should be on page 2 only.
        
        Change-Id: Ie2ce75dbace5d9716008351aedb6a8989036badb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146854
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [6732191ebf8a559b272238c03af679263abf86ef]

        tdf#152964: sw: move UItest to CppUnittest
        
        Change-Id: I9470bce1350a87d5773674b55148b64b02997210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146902
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  buldi  <dobrakowskirafal@gmail.com>  [4e822d22e11e241113e392a1475a479e052df909]

        tdf#143148 Use pragma once instead of include guard
        
        Change-Id: I6fa77335ced02442eec69b0dbb088505eb4b1aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146818
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ef3c81d0fca9c8f80fd0d4e4025c37a114528344]

        Rename: Extension Manager -> Extensions
        
        simplify dialog title, should be clear what this is about.
        
        Change-Id: I65d8ca89e32cc225a07483703cd27b0fdc630b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146715
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [32267c54d7430886e643b297b5e03f5fbf08cf19]

        sw: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I16b818edc0f4414937f28b8459d06712c7db9eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146896
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4beaa92bc2c91e7ff84b044469d376216efec2fe]

        sw: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: Iee4ee4964640114126c2ec404df567598668ed99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146894
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [22850e8d281d17575c01321cfff9e1ad2201ffb5]

        sw: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I987d5b4493d599a7ad21c916464efca52f24f548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146897
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [835f87280ab228f59801c28c288472f2941ea222]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: Iee86221cc7b4bd66fc19dc63b162d72aacec5016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146874
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  Mike Kaganski  <mike.kaganski@collabora.com>  [00f6c36b603416b73e1327ac4c862b1eaca2d277]

        Fix/simplify some vnd.sun.star.expand: handling
        
        The vnd.sun.star.expand: payload must be URL-decoded prior to passing
        it to expandMacros; the protocol must be checked case-insensitively.
        Use startsWithIgnoreAsciiCase for that.
        
        Change-Id: I2be993a0400a27cb7dc57207cd0824b4505afd2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b926ba60d11cb78b4e042e2abb2d00dde128a1f8]

        Fix typo
        
        Change-Id: I58611c416b2fe198dc847336a592be6683e9b3bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146899
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-13  buldi  <dobrakowskirafal@gmail.com>  [8ca611b2125a74cfdb273cfedfa3b94de14f628b]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I5a88b699425a37b914a71400e918965a9f6116eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146730
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a047583f76cd5e9d6ba73ec1ed0ede6cfc3dd541]

        sc: avoid divide by zero in ScEEImport::GraphicSize
        
        See https://crashreport.libreoffice.org/stats/signature/ScEEImport::GraphicSize(short,long,ScEEParseEntry%20*)
        
        Change-Id: Ia5acccb1118aff2486d23eabd536053e67f346ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [821f4d6f0987450233e4f63e01f89484ec737258]

        fix openssl build on aarch64  - _umul128 is not available on non x64
        
        adding upstream patch that uses __umulh as a fallback
        
        Change-Id: Ib95de30d3f7208c38421df0c63eb1ceafccd9354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146839
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-02-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ac746702df3762d76e20042199f6531acf59123b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a295ef1fa2462d9a828341e7b947eae05ba14154
          - tdf#153417 Edit module options  Help page
            
            Change-Id: Iadc6b9b9be76d0f4c57336e43872d4ab3aa3f7f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146823
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [e411eeffad98f2344b9796aa80ba8d3f054a3d3a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5b8658e58d02f8f3ec6a613f7c4edd32ca2e5d76
          - FormatPercent New Basic function / VBA
            
            Change-Id: I0ad4022394632f0d49417bb56ecda641af3b0b42
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146519
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2023-02-13  buldi  <dobrakowskirafal@gmail.com>  [4f6d506e79884b5febb50e61f58bfdba4deef323]

        tdf#143148 Use pragma once instead of include guard in sw
        
        Change-Id: I9b4d2ccb608ceaafb3ee71a34831ce9cb69db6f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146729
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-13  Laurent Balland  <laurent.balland@mailo.fr>  [69b9f50ee8c76fa6193165369ab8235cd125247e]

        tdf#152722 tdf#153023 Add UITest
        
        Test increment decimal places and negative in red for NatNum12 number
        format
        Test disable thousand separator and enable leading zeroes
        
        Change-Id: Iff16be62cc7c52af91e04ed018f8cacc40e35568
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146550
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-13  Tor Lillqvist  <tml@collabora.com>  [297c71c82bf6766c7fdeec0ab90e693c4fe39675]

        Mention that Emscripten 3.1.30 is known to work for COWASM
        
        Change-Id: Id01004121a306dea953b908c32acc7f2c0e6841c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146857
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-13  Tor Lillqvist  <tml@collabora.com>  [4277e37e65a9a788cd787df54c4788c99225846c]

        Don't overload the word 'module' unnecessarily
        
        Change-Id: I10fb7d16192ddfb0802c976419c00302d4688c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146856
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-13  Miklos Vajna  <vmiklos@collabora.com>  [24f0e121b06252b323e237d9e7f47fcb28bff41e]

        writerfilter: prefix members of DomainMapper, GraphicZOrderHelper, ...
        
        ... RTFSprms_compare and TagLogger
        
        See tdf#94879 for motivation.
        
        Change-Id: I94c432a3aa592f2deb32175938e19047cc65fa44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146852
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-13  Paris Oplopoios  <paris.oplopoios@collabora.com>  [ce3d8f7e082afbc4a3139c723cb4533579523fe2]

        Fix typo, improve code readability, fix comment
        
        Change-Id: I7221222e8c84ee40e4edaec5325565dae4193aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145825
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-13  deepanshuraj099  <deepanshuraj099@gmail.com>  [74501c5da13634632259f738d59b0273e2417147]

        tdf#143148 Use pragma once in vcl
        
        Change-Id: Ib27eb3612f6c072d5c1b7a3588c9524920f86e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146831
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-13  Michael Weghorn  <m.weghorn@posteo.de>  [429cf15472b6900852c618a0e90879554562f69a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to bcf7f049315dee2001cc2f7c7eabfbcb0b8ef21a
          - Add .gitreview used by git-review tool
            
            Change-Id: I9b4415acbf0ec6de90280a259a1af7e33529f2c4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/138340
            Tested-by: Michael Weghorn <m.weghorn@posteo.de>
            Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
            
2023-02-13  Mike Kaganski  <mike.kaganski@collabora.com>  [9fa9a510f9a391979a1f5f25ae1b5f4392db7692]

        Use startsWithIgnoreAsciiCase with last argument to simplify
        
        Change-Id: Ifa1261ed76ec078a60fcdbd4ce806abe23e4c056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146850
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-13  Mike Kaganski  <mike.kaganski@collabora.com>  [30a215f3cee1acdb4df3285512603abede8d3ff1]

        These const_casts are unneeded
        
        Change-Id: I4b1d81665f9bfeb040530bac6bafa3ee2c85782f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146849
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [14a36ad49518bcb5b606b0f1640e3ca56b636e89]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 12f4174031afc80e9d6ac387336e0185646f6977
          - tdf#152605 update UI label changes
            
              - also adding missing control "Caption Order" in Autocaption
            
            Change-Id: I79f3a3416a465693be7bee98d6bdfa0a82f828da
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146806
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-02-12  Mike Kaganski  <mike.kaganski@collabora.com>  [12896c9ed652a239cb1fd05bbd9a32f040e3381f]

        tdf#153571: properly unquote (URL-decode) vnd.sun.star.expand payload
        
        Similar to what is done in bootstrap_expandUri, expandUnoRcUrl,
        UrlReference::expand, JavaLoader.expand_url, and is documented
        in XVndSunStarExpandUrl interface.
        
        Change-Id: I65349b52734f212e6a04e615d39fa2563f62d472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146840
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-12  buldi  <dobrakowskirafal@gmail.com>  [1af3cb6cf2f635e1d5431942a787d52a2ec3fa70]

        .gitignore: /.vscode*
        
        Some VS Code extensions create directories with this prefix.
        
        Change-Id: Ie4a96a276970327d8da39bffd51eaf137e4163bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146728
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-12  Caolán McNamara  <caolanm@redhat.com>  [2dded7d07ac818da920644a595b7e9331458e70d]

        Resolves: tdf#153566 set darkmode menubar background color
        
        because we use it for custom menu titles backgrounds
        
        Change-Id: I1ae679bc032d29c4901befc2f1b0cbb53d0a5d1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7e1a4a518ef6a8a32f4acf4fe3cc634c3573f778]

        Fix typos
        
        Change-Id: I7c755b2099c3607fece3442269ff3a806b196f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146836
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4cea7d8f5645cc8c8b7deb78a1bcc0c925f4bb7d]

        Fix typo
        
        Change-Id: I8ab5346e38b6eac508018aced86339d6342224a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146832
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60d7056184e558ab27c67a1500f705db5dfb9d02]

        Fix typo
        
        Change-Id: Ia21de983bd4295f399e9753c29bc2a3cace2f250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146835
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1fddf82234c3925d98a01e52a9ecfb5093a0e60]

        Fix typo
        
        Change-Id: I28253e80065c690dca45658111a2cd54857b186a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146833
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [393b55e4428bb5e6f5df69be4cdea371a12ce67e]

        Fix typo
        
        Change-Id: I51b5c88e1d82c596b926e7074ee3a7e1395a21a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146834
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-12  Tor Lillqvist  <tml@iki.fi>  [33ec31c24053a96f167d11c734d72ec960246e04]

        Avoid LOKClipboard harder on iOS
        
        Change-Id: I2710a7537594c486878a68c630f762a24ac81c49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133017
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146739
        (cherry picked from commit 069aae6be68d67b45222740de01467d11f15adfb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146800
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-12  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [43de98fb59ef3cd1c6eabd3174d57634b7d501a9]

        MCGR: Add/Provide GradientSteps to FillGradientAttribute
        
        MCGR stands for MultiColorGRadient. This change allows/
        prepares adding multiple color steps to gradient rendering.
        
        This is preparation work to allow rendering MCGRs in the
        future. All places are adapted in a way that currently
        no change of behaviour will happen. It will be the base
        to get MCGR rendering/decompose for Primitives and our
        internal/existing gradients working.
        
        Change-Id: I28bbd7d10b8670042343ada2a66b5909d3d31bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146748
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-02-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [496b1b3179ca096dea1fd91ab2408c02f16b06cf]

        tdf#152605 "heading level"->"outline level" and other tip corrections
        
        Change-Id: I3751b8586ffe47233f3cd27602bcb5cad4d9ecb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146797
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6f15382790e2e758ef7328a62341b30c655aced1]

        tdf#152605  change "heading level" to "outline level" in UI
        
            This patch addresses extended tips in the UI that refer to a heading
            or chapter level, with the aim to remove this kind of terminology.
            In many cases, tooltips are added, and extended tips are corrected.
            Also, add "Outline" in front of "level" in the UI for Caption
            Options and AutoCaption.
        
        Change-Id: Idcf16892599913af31372b89d180251c86945d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146622
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-02-11  Justin Luth  <jluth@mail.com>  [d8b72d2d841d35f3dfdd38aa9adcedae7550279b]

        sw wrtsh1: cleanup unused pointer
        
        Having a separate pCurRule was made useless by
        commit 3234a9deaa8db760bbd7dbb6414aa3e8f9993c34
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Mon Feb 21 15:07:41 2005 +0000
        
            INTEGRATION: CWS swqcore05 (1.40.82); FILE MERGED
        
        Change-Id: I5fe0c7b09245acd9376d46b448708f29594a7266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146824
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-11  Kohei Yoshida  <kohei@libreoffice.org>  [3c988ef450b809767ca7f897c59041758af53f4b]

        Update liborcus to 0.18.1
        
        Change-Id: I0439640789e59e4dd6e92d7f2975538de2f42f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146826
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-02-11  Sebastian Andrzej Siewior  <sebastian@breakpoint.cc>  [a0165bb7900f6d03a49076d755568ac33ee8e9c9]

        lo-pack-sources: Add support for pbzip2.
        
        Use pbzip for compression if possible. Otherwise fallback to bzip2.
        
        Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
        Change-Id: I9091c5dfe25ee00854b6938464af23b56cdcb31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146814
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-02-11  Sebastian Andrzej Siewior  <sebastian@breakpoint.cc>  [cb9883b1e9fb620f280e950de2bb50f9ec3a4c5e]

        lo-pack-sources: Use threaded compression for xz.
        
        The xz utility can compress in parallel by using more CPU cores. The
        more CPUs are available the quicker it gets.
        The option -T0 automatically detects the number of available CPUs and
        uses all of them.
        Additional benefit is that xz starting with v5.4 can decompress the
        archive using multiple CPUs as well.
        
        The parallel compression works by splitting the input in multiple blocks
        of equal size which are compressed in parallel. Since the state is not
        preserved / reuse across blocks, the compression gets a little worse:
        
        	-6 	255M (current default)
        	-T0	261M
        	-eT0	259M
        	-7T0	251M
        	-7eT0	249M
        
        -7 uses larger blocks and dictionary which requires more memory on the
        compressing and decompressing side vs the current default -6.
        The -e option spends some extra cycles and improves the compression a
        bit.
        
        Use parallel compression and spend some extra cycles.
        
        Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
        Change-Id: Ib69c4bc1996ddd52153b8ac27b653c21e3998a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146793
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-02-11  Sebastian Andrzej Siewior  <sebastian@breakpoint.cc>  [30f49b56ba6712fb8fb3dd8febb870a1157e1516]

        lo-pack-sources: Split archiver invocation away from tar.
        
        Instead of passing --bzip2 or --xz invoke the compression program via a
        pipe. This make the replacement of compressor as well its options
        easier.
        
        Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
        Change-Id: Ib69c4bc1996ddd52153b8ac27b653c21e3998a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146105
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-02-11  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [bbdbe8ea2ef176ef6f08b30b3c18876c2c4f0c22]

        tdf#142018 Properly create Pen width if style is COSMETIC
        
        Change-Id: I6453058c4af352a3b0e14cbccbc1a67c73cd1426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146551
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2023-02-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [c96e1ec61835bc01e2969ec97fce9a1674fbf6d7]

        tdf#45705 Make SID_ZOOM_IN and SID_ZOOM_OUT smoother in Impress
        
        As reported in the bug ticket, the commands SID_ZOOM_IN and SID_ZOOM_OUT are not smooth and increase/decrease zoom at too big steps.
        
        This patch uses basegfx::zoomtools to zoom in and out, making it smoother.
        
        Change-Id: I801fa6123bf0696046e5d45c7a6b309e7cc3312e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146825
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-02-11  László Németh  <nemeth@numbertext.org>  [382892341a63e400f221e1a533fd5a5d6b4d9d70]

        tdf#147892 DOCX: fix corrupt export at para marker revision history
        
        OOXML export of tracked deletion of tracked paragraph insertion
        resulted invalid document.xml, because change tracking history of
        paragraph markers isn't supported by OOXML. Export the tracked deletion
        of the last run of paragraphs without history (tracked insertion).
        This way w:p/w:pPr/w:rPr contains only w:del or w:ins, not both of them
        (with broken tag order).
        
        Note: it's possible to optimize the fix to keep the change
        tracking history of the characters of the last run of the paragraph,
        except the paragraph marker.
        
        Regression from commit eeee19b3fcf8b0374c361c7f6c285fd5c89b5a2f
        "tdf#142387 DOCX track changes: export w:del in w:ins".
        
        Minimal unit test document was created by Miklós Vajna.
        
        Change-Id: I425f4d63c8c6ac29ccd807c1574748c7b9b39e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146782
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-02-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1f1a1f3786a0f7b2efb7739ad227358561112e80]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7266a58cba3c89fdf9cd7100c00ef360e8d45e08
          - tdf#153122: Add missing controls to Caption and Caption Options help
            
              swriter/01/04060000.xhp
                + add Numbering Separator control and description
                * move position of "Caption" to correspond to order in dialog
                * refactor <h1>,<h2>,<h3>,<relatedtopics>
            
               swriter/01/04060100.xhp
                + add Caption section title
                + add Caption Ordering control and description
                * refactor <h1>,<h2>,<h3>,<relatedtopics>
            
            Change-Id: I0d97dfcc0ca9083e5eec20f679d5634764764872
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146208
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-11  Justin Luth  <justin.luth@collabora.com>  [a942e6e5ecfdd9ff83fc7febb8234c8f0e2813db]

        assert commit looking for example document to test theory.
        
        related tdf#125038 FORMTEXT/REF:fix spurious text outside IF field
        speculated that this should always return false,
        since the IF statement is not processed at all.
        However, there are no documents that match this condition in the
        existing unit tests, so a wider net is needed.
        
        Change-Id: I8a5a0fd077cc141abc5438cacd0de77fcfe7c476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145931
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-11  Justin Luth  <justin.luth@collabora.com>  [f7afed99a807a9ce42edf84cab36a4710ddcd58e]

        sw: rename getFieldmarkFor() to getInnerFieldmarkFor()
        
        The same change was made for getBookmarkFor()
        in https://gerrit.libreoffice.org/c/core/+/145412
        
        Because otherwise it's quite confusing
        that we have a For() and an At()
        which could only be differentiated by a code read.
        
        Also improve getInnerFieldmarkFor() a tiny bit,
        so we process the first hit only once.
        
        Suggested at
        <https://gerrit.libreoffice.org/c/core/+/145348/1#message-286262286f234823b390e8f962e3ba11f5fa71b2>.
        
        Change-Id: I47e815eea0b8ac0df4957ac0d224acb6c5975b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145486
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-11  Caolán McNamara  <caolanm@redhat.com>  [c217359b7b3583ae4156e4c2322fe7d867eb3306]

        set the image in the .ui instead of the .cxx
        
        Change-Id: Id6c30fa9cad6bbfbfb4e5c1363f637868884b345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-11  Caolán McNamara  <caolanm@redhat.com>  [83eceff8e5136504106c2fd9de26543c37000085]

        Related: tdf#153229 use 'System' instead of 'Automatic'
        
        in the macOS desktop settings "Automatic" is used
        to indicate that the theme changes automatically from
        light to dark over time, "System" does seem a little
        less ambigious as to its meaning here.
        
        Change-Id: I38f6007cca1e8942d77066db200208ca463368d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146743
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-11  Caolán McNamara  <caolanm@redhat.com>  [d6b590feda1c61fd5ed14c0be66379b8e5de0c6a]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I033fab3ea016d3b57891a35602920b7de811ccb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-10  Jim Raykowski  <raykowj@gmail.com>  [9788a565b3241d1bd62394b9e29c322361d05f80]

        tdf#153205 related: Improve selection mode control icon update
        
        This patch makes the status bar selection mode control icon change to
        adding selection when the mouse is used to select text while the ctrl
        key is pressed and the mouse is moving, which is the behaviour when
        the mouse is not moving and selection begins. It also makes the icon
        show the correct mode when doing DnD.
        
        Change-Id: I9aeb47301ab3c8b9be2159186bcc8c8ede7bf3de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146726
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [44801e26e098cc1cf7f96e3b233c2b9e5084c9fd]

        qt6 configure: Search for Qt 6 moc in more locations
        
        This e.g. makes this find the correct moc on Arch Linux,
        where the Qt 6 moc is provided under `/usr/lib/qt6/moc`
        by package `qt6-base`.
        
        Change-Id: Iefca23e6391a952eb79108260ae1417fc75ad0ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146781
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-10  Michael Weghorn  <m.weghorn@posteo.de>  [9fbcf60c51f9bc553c6e6e0204fac975a87ebf13]

        qt6 configure: Add moc version check
        
        This way, it is determined at configure time
        if the moc meant to be used for Qt 6 is actually a Qt 5
        one, as happened e.g. on Arch Linux without
        upcoming Change-Id Iefca23e6391a952eb79108260ae1417fc75ad0ef
        ("qt6 configure: Search for Qt 6 moc in more locations").
        
        Fail at configure rather than build time in such cases.
        
        Change-Id: I2ada2045f41f08bf339920d043226f9b36c335b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146780
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [d367cefb0281767762b1671c03b3852cf3d1b7ab]

        tdf#139934: sc_subsequent_filters_test: Add unittest
        
        Change-Id: Ib1540bb7058606c7629ce0459fd18bd463e99998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146786
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-10  Caolán McNamara  <caolanm@redhat.com>  [88cee07ee023899ffd482bbe52bf0c02c58890d0]

        Resolves: tdf#153497 update automatic icon-theme name on dark mode change
        
        Change-Id: I6b41d04ad902d5b123a110b52426ea2c2de79e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-10  Caolán McNamara  <caolanm@redhat.com>  [e43062523b53f7c472f4c0183d333b34cf7adbdf]

        operator [] out of range assert
        
        presumably since:
        
        commit 0e45f8318ee73361fecb049b33b0662fabe295d3
        Date:   Sat Nov 5 15:59:27 2022 +0100
        
            -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): hwpfilter
        
        Change-Id: I1e93526d46d1357a8f11f7ff7ed4c3f2274b9c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146783
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-10  Jim Raykowski  <raykowj@gmail.com>  [5bc7cb77df839f7dd3cc7d444490aaf50ebccdc6]

        tdf#153205 related: Fix selection problems caused by cursor shell
        
        push pop during insert state update
        
        This patch renames the SelectHiddenRange function to IsInHiddenRange
        and modifies it to take a bool argument that when true selects the
        hidden range if the current cursor position is in a hidden range.
        When the argument is false, the hidden range is not selected if the
        current cursor position is in a hidden range. This makes using cursor
        push pop unnecessary when all that is wanted to know is if the
        current cursor position is in a hidden range.
        
        Change-Id: I622dfaf8e73c5b432bb74a48d36433ff755542b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146725
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [208a4ecafafa97ea7fcc5a135fa8160e91ea0a74]

        tdf#153510: STYLE: try harder to detect when there's nothing to do
        
        1. Find the real style names early, to avoid re-triggering style
        application when STYLE arguments use wrong case;
        2. Also check a (rare) case when both immediate and delayed styles
        are the same as currently applied.
        
        Change-Id: Id8ab2e321ede6d0f8f05ac5d1e63ade0212e5865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146775
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [2844670d2a47c606cbebb99f73389f30154a3c5e]

        Flatten ScInterpreter::ScStyle
        
        Change-Id: I64c622d2c2cacccc7eda02e8739657fe345f9be8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [2a984c77ccb1aa77d9bbd02218d4dc76aaff4a9e]

        tdf#153514: try to find exact match, even when searching case-insensitively
        
        Change-Id: Ib3bec382ef80a9078ffde8612c395cb0154fd476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146747
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [cc685e16b5325384268ddd52f24293b6e4bf3502]

        tdf#153341: sw_htmlimport: Add unittest
        
        Change-Id: I048a95a3bb36981f5f2d3d243021952b34529075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146753
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-10  Tor Lillqvist  <tml@collabora.com>  [6d0a0e09ce0daac06bbad0c0cef3057196dbf6e0]

        Avoid implicit function declaration warnings
        
        Noticed when compiling with Emscripten for WASM, but might well happen
        in other cases, too.
        
        Change-Id: I37ae326af21204d81a6a3267831d7a0198d1d501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146744
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [797757ac567071f25c1bc30ec7e90d2773a18c67]

        tdf#153244: sw: Add UItest
        
        Change-Id: I8e992d84171aa4ee10f24b754214965ffb70645e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146749
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [70b0c2d84bf5b3b2e94c8da18845c4210a87b7a8]

        Fix typo
        
        Change-Id: I14c04884eab36560c96dbc59b809a5871d87b75f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146750
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-10  Tor Lillqvist  <tml@collabora.com>  [8d90e02b4cecdc7fd74b05b122f074a5f36ca965]

        Get the shared object of a bundled fontconfig into rpm and deb packages
        
        Change-Id: I9630fa25178637bba189c263605a2198ef5c6064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141550
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146720
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146740
        Tested-by: Jenkins

2023-02-10  Caolán McNamara  <caolanm@redhat.com>  [72959cc2b36749a779b56522f27e290731187043]

        gtk4: occasional crash at exit
        
        Change-Id: I2008d44f5dae0f22e9213f46a740146d6eb85666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146727
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-10  Stephan Bergmann  <sbergman@redhat.com>  [86cfb4da4fdca63d92060bcfa65e808f579260f4]

        loplugin:staticaccess
        
        Change-Id: If0a2032bede27af3176951dabaab4a165efb144d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146738
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-10  Tor Lillqvist  <tml@iki.fi>  [5025a56db91bb3cf337659c0f8a77d36f49974ad]

        Guard against no HAVE_FEATURE_AVMEDIA in one more place
        
        This was said to fix build of the iOS app some years ago in a vendor
        branch, but unclear about that now, it seems to build from master at
        the moment anyway? Anyway, this still probably makes sense.
        
        Change-Id: I4a9e6f18e7b17664e5aed36233d5ccde44cf1194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141796
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146742
        Tested-by: Jenkins

2023-02-10  Tor Lillqvist  <tml@collabora.com>  [cbac6b9d8f1319fffc66b397dfa20588e35c24fb]

        Pass product name and not hardcoded "LibreOffice" to make_installer.pl -p
        
        Change-Id: I9b2d84bcc18e21b325960f7057e259daa37234a5
        Reviewed-on: https://gerrit.libreoffice.org/55640
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 12d1b08aac8cc8c3176040efc7290377e380f0c4)
        Reviewed-on: https://gerrit.libreoffice.org/79128
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>
        (cherry picked from commit 0069417b55c99166aec5489ccef803eba25d2b4f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136842
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146741
        Tested-by: Jenkins

2023-02-10  Stephan Bergmann  <sbergman@redhat.com>  [b8a3d1b7577adce9e4844f6f8915820b98b6d2d8]

        loplugin:external
        
        Change-Id: Idde40e44254a6c545185470a1db36ab684504bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146737
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-10  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [0fcc2f933e588f5a9fa19f3decf91874d935ecfa]

        Revert "check-last-commit: more detailed advice on using clang-format"
        
        This reverts commit f59d449ecfc078765dfaa2e150a21a7e4b330932.
        
        Reason for revert: confusing
        
        Change-Id: If5924ff3952f344f7a418e80d4ceb774dea94430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146707
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [5c96e813bed3293605f8d746f188cc051d1e5949]

        tdf#150451 Fix borders in Editbox controls (kf5)
        
        The bounding rectangle calculated for an Editbox in
        QtGraphics_Controls::getNativeControlRegion was not
        always enough to accommodate content and the borders.
        
        The KDE Breeze does not draw any borders if the total
        height of the bounding rectangle is smaller than the
        minimum size needed for content + frame at top and bottom,
        s. Style::drawFrameLineEditPrimitive in the Breeze
        style [1].
        
        Therefore, ensure a minimum height of that size.
        The Breeze style also considers the type of the
        passed widget when retrieving the frame width using
        QStyle::pixelMetric [2], so pass a dummy `QLineEdit`
        in order to get the actual frame width of 6
        that the Breeze style uses for line edits, rather
        than the default value of 2 that is returned when not
        passing any widget.
        
        Just do that for the minimum size calculation for now
        and not everywhere, because the handling for edit boxes
        here in the qt VCL plugins and in the calling code
        currently does all kinds of "interesting" things like doing
        extra size adjustments or passing the content rect where the
        bounding rect would be expected,...
        
        Ideally this should be cleaned up in the callers and all
        platform integrations in a follow-up commit
        to adhere to what the doc in vcl/inc/WidgetDrawInterface.hxx
        says, but this here keeps it working with existing code for now.
        
        (s.a. discussion in the Gerrit change for more details)
        
        Tested using various scaling factors: 1, 1.25, 1.5, 1.75 and 2.0.
        
        [1] https://invent.kde.org/plasma/breeze/-/blob/144ea45018d28758db07afd987d97318d56c4981/kstyle/breezestyle.cpp#L3527
        [2] https://invent.kde.org/plasma/breeze/-/blob/144ea45018d28758db07afd987d97318d56c4981/kstyle/breezestyle.cpp#L555
        
        Co-authored-by: Michael Weghorn <m.weghorn@posteo.de>
        
        Change-Id: If8cb4794c7f3ce1be4d1ee421c9c27ad5adf5da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146516
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [a80630b6ee6e7636d2c93c42724ce815c991311c]

        Related: tdf#153510 Avoid modification of iterated container
        
        A crash is seen when resizing a document locally; the problem is
        range-based for loop, which indirectly modifies its range:
        
          sclo.dll!ScAutoStyleList::AddInitial(const ScRange & rRange, const rtl::OUString & rStyle1, unsigned __int64 nTimeout, const rtl::OUString & rStyle2) Line 81	C++
          sclo.dll!ScDocShell::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 685	C++
          svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 41	C++
          sclo.dll!ScInterpreter::ScStyle() Line 2628	C++
          sclo.dll!ScInterpreter::Interpret() Line 4441	C++
          sclo.dll!ScFormulaCell::InterpretTail(ScInterpreterContext & rContext, ScFormulaCell::ScInterpretTailParameter eTailParam) Line 1947	C++
          sclo.dll!ScFormulaCell::Interpret(long nStartOffset, long nEndOffset) Line 1619	C++
          sclo.dll!ScFormulaCell::MaybeInterpret() Line 470	C++
          sclo.dll!ScFormulaCell::IsValue() Line 2763	C++
          sclo.dll!ScConditionEntry::Interpret(const ScAddress & rPos) Line 670	C++
          sclo.dll!ScConditionEntry::IsCellValid(ScRefCellValue & rCell, const ScAddress & rPos) Line 1238	C++
          sclo.dll!ScConditionalFormat::GetData(ScRefCellValue & rCell, const ScAddress & rPos) Line 1836	C++
          sclo.dll!`anonymous namespace'::handleConditionalFormat(ScConditionalFormatList & rCondFormList, const o3tl::sorted_vector<unsigned long,std::less<unsigned long>,o3tl::find_unique,1> & rCondFormats, ScCellInfo * pInfo, ScTableInfo * pTableInfo, ScStyleSheetPool * pStlPool, const ScAddress & rAddr, bool & bHidden, bool & bHideFormula, bool bTabProtect) Line 297	C++
          sclo.dll!ScDocument::FillInfo(ScTableInfo & rTabInfo, short nCol1, long nRow1, short nCol2, long nRow2, short nTab, double fColScale, double fRowScale, bool bPageMode, bool bFormulaMode, const ScMarkData * pMarkData) Line 569	C++
          sclo.dll!ScGridWindow::Draw(short nX1, long nY1, short nX2, long nY2, ScUpdateMode eMode) Line 556	C++
          sclo.dll!ScGridWindow::Paint(OutputDevice & __formal, const tools::Rectangle & rRect) Line 458	C++
          vcllo.dll!PaintHelper::DoPaint(const vcl::Region * pRegion) Line 313	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 617	C++
          vcllo.dll!PaintHelper::~PaintHelper() Line 553	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623	C++
          vcllo.dll!PaintHelper::~PaintHelper() Line 553	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623	C++
          vcllo.dll!PaintHelper::~PaintHelper() Line 553	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623	C++
          vcllo.dll!PaintHelper::~PaintHelper() Line 553	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623	C++
          vcllo.dll!PaintHelper::~PaintHelper() Line 553	C++
          vcllo.dll!vcl::Window::ImplCallPaint(const vcl::Region * pRegion, ImplPaintFlags nPaintFlags) Line 623	C++
          vcllo.dll!vcl::Window::ImplCallOverlapPaint() Line 646	C++
          vcllo.dll!vcl::Window::ImplHandlePaintHdl(Timer * __formal) Line 668	C++
          vcllo.dll!vcl::Window::LinkStubImplHandlePaintHdl(void * instance, Timer * data) Line 648	C++
          vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111	C++
          vcllo.dll!Timer::Invoke(Timer * arg) Line 81	C++
          vcllo.dll!vcl::Window::ImplHandleResizeTimerHdl(Timer * __formal) Line 684	C++
          vcllo.dll!vcl::Window::LinkStubImplHandleResizeTimerHdl(void * instance, Timer * data) Line 674	C++
          vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111	C++
          vcllo.dll!Timer::Invoke(Timer * arg) Line 81	C++
          vcllo.dll!vcl::Window::GetSizePixel() Line 2420	C++
          sclo.dll!ScTabView::GetGridWidth(ScHSplitPos eWhich) Line 3032	C++
          sclo.dll!ScViewData::CellsAtX(short nPosX, short nDir, ScHSplitPos eWhichX, unsigned short nScrSizeX) Line 2634	C++
          sclo.dll!ScViewData::VisibleCellsX(ScHSplitPos eWhichX) Line 2710	C++
          sclo.dll!ScTabView::PaintArea(short nStartCol, long nStartRow, short nEndCol, long nEndRow, ScUpdateMode eMode) Line 2386	C++
          sclo.dll!ScTabViewShell::Notify(SfxBroadcaster & rBC, const SfxHint & rHint) Line 63	C++
          svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 41	C++
          sclo.dll!ScDocShell::PostPaint(const ScRangeList & rRanges, PaintPartFlags nPart, unsigned short nExtFlags) Line 172	C++
          sclo.dll!ScDocShell::PostPaint(short nStartCol, long nStartRow, short nStartTab, short nEndCol, long nEndRow, short nEndTab, PaintPartFlags nPart, unsigned short nExtFlags) Line 106	C++
          sclo.dll!ScDocShell::DoAutoStyle(const ScRange & rRange, const rtl::OUString & rStyle) Line 1580	C++
          sclo.dll!ScAutoStyleList::InitHdl(Timer * __formal) Line 92	C++
          sclo.dll!ScAutoStyleList::LinkStubInitHdl(void * instance, Timer * data) Line 84	C++
          vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111	C++
          vcllo.dll!Timer::Invoke() Line 76	C++
          vcllo.dll!Scheduler::CallbackTaskScheduling() Line 481	C++
          vcllo.dll!SalTimer::CallCallback() Line 55	C++
          vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 166	C++
          vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525	C++
          vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581	C++
          vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 475	C++
          vcllo.dll!Application::Yield() Line 560	C++
          vcllo.dll!Application::Execute() Line 453	C++
          sofficeapp.dll!desktop::Desktop::Main() Line 1604	C++
          vcllo.dll!ImplSVMain() Line 203	C++
          vcllo.dll!SVMain() Line 236	C++
          sofficeapp.dll!soffice_main() Line 94	C++
          soffice.bin!sal_main() Line 51	C
          soffice.bin!main(int argc, char * * argv) Line 49	C
        
        ScAutoStyleList::InitHdl iterated over aInitials, and called
        pDocSh->DoAutoStyle, which eventually called ScAutoStyleList::AddInitial,
        which modified aInitials, resulting in dangling reference rInitial back
        in the ScAutoStyleList::InitHdl.
        
        Change-Id: Id4e2aac2f5b0b27a7a57f22c0c9cdf8a1e950f30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146690
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-09  Justin Luth  <jluth@mail.com>  [ff3440535e786c73237176670372c565ca3421b4]

        tdf#153042 doc/x/rtf: pre-emptive unit tests for numbering tabstop
        
        These existing unit tests need to have a tabstop in the front.
        Although different versions of MS Word can handle similar situations
        differently (regardless of compatibility settings - i.e. buggy)
        in these cases they are all rendered the same way by Word 2003/2010/2019.
        
        make CppunitTest_sw_rtfimport CPPUNIT_TEST_NAME=testTdf78506
        make CppunitTest_sw_rtfimport CPPUNIT_TEST_NAME=testTdf116265
        
        In this one, LO's chapter numbering defaults to none-numbering
        followed by a tabstop. The tabstop should not be there/never become visible.
        make CppunitTest_sw_ww8export3 CPPUNIT_TEST_NAME=testPresetDash
        
        For this added test, older versions of Word 2010/2003 don't show a tabstop.
        According to MS Word 2019 however, this should have a tabstop in the front.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153042_largeTab
        
        ... but this nearly identical file does not display with any tabstop,
        and looks the same in all versions of Word.
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf153042_noTab
        
        Change-Id: I59d904ef7dd37b694b02f57d6743ee5b232b42a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146731
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [10ed0b5c09eefc53c8e8a6f606faf29dac5f4d80]

        sw: fix crash in SwModule::InsertLab
        
        Seen in https://crashreport.libreoffice.org/stats/crash_details/e17357e9-d5e2-4eee-868e-ecf72e04dc41
        
        Change-Id: I32f239249e72b6644b3a38d4dd9bbae65f7bede0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146692
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-09  Stephan Bergmann  <sbergman@redhat.com>  [6ed7a3cc51e560c6b2a6894f6829c0ac9f991ef2]

        tdf#153501 Fix OString construction from nullptr
        
        (see recent 6028e9fda96d0ed5da266b1c54a7755f7ba3408c "Finally drop undocumented
        rtl_[u]String_newFromStr null argument support")
        
        Change-Id: Ib47d2d674487baf0414b4a02b27b2359f809df97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146719
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-09  Mert Tumer  <mert.tumer@collabora.com>  [8620b204b51a9e0552a0002f7f06292bdfad37a7]

        make default selected table style to Default Table Style for only online
        
        unfortunately when the table has a style sw/qa/uitest/writer_tests4/tdf115573.py fails
        because tables that have pre-applied style resets the style of the elements in their cells
        when a new row is inserted and the ui test above relies on that. For now this is LOK only
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I2f60376fc2d929498aef45259a5ef291922ccdcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132124
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146723
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-09  Mert Tumer  <mert.tumer@collabora.com>  [ef46afe71751929b8b17d278d83c8e3ceefc862f]

        sw: change inserttable style option default to 1
        
        Right now it is default to NONE in the list
        if the user explicitly choses otherwise but that
        does not align with inserttable option on the toolbar
        there it is defaulted to "Default Table Style"
        1 means "Default Table Style"
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I1db19f0292ac6775653b0db3f2860fea9e3b0adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131971
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146722
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-09  Khaled Hosny  <khaled@aliftype.com>  [182e85aef036f30e8c6f32de5516a0286aaf0320]

        vcl: GetGlyphOutlineUntransformed() always returns true now
        
        Change-Id: I98eff6f138b57e249d8ce951c1b3747c773330ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146718
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-09  Khaled Hosny  <khaled@aliftype.com>  [cbdcc18778f9736ca6f186e2bbb9f0db456b1cee]

        Require HarfBuzz 5.1.0
        
        This is the minimal version to provide the functionality we currently
        check for. Some important LO functionality currently depend on idfdef'd
        HarfBuzz code, and some distributions build against old system HarfBuzz
        leading to user bug reports that are tricky to track down, e.g:
        tdf#153048 and tdf#153470.
        
        Change-Id: I7d58ec46f8fd340d2592887c0088876d71351771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146674
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-09  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [f59d449ecfc078765dfaa2e150a21a7e4b330932]

        check-last-commit: more detailed advice on using clang-format
        
        Change-Id: I7e25acd02573c3e173eccefe9326dc42e2940f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146688
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-09  Henry Castro  <hcastro@collabora.com>  [665964c2d36791df4a6586f54167bbd1563cb4e0]

        lok:sc: do not generate extra mouseup events
        
        In tiled rendering case, the client side always will
        send the pair mousedown/mouseup events to server side,
        it is not necessary to generate extra mouseup events
        when the mouse tracking has ended, otherwise the selection
        engine will receive two mouseup events and wrong selection
        states.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I99983de9591e26f6e5327fff63c45e682cbf1999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144168
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145611
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 78568d4baac8b84b5d9cb50704b3e62b67ab1178)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146633
        Tested-by: Jenkins

2023-02-09  Juergen Funk  <juergen.funk_ml@cib.de>  [7a851c5b2da723ca618061c12a14f11479748dfd]

        tdf#95936: Tooltip not updated in Toolbars after change Shortcut
        
        The update of all toobars after change the shortcut was missing,
        this patch update the toolbars now
        
        Change-Id: Ibc896dc48c9143307b028a3c271476482111c2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146678
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8d8d01140c299e49afd188a9b7e1ac2860099e8c]

        Remove unused field
        
        Change-Id: I6eda3b236c5b270c75947ca3313987e467d05982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146693
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cd559b38043c5572465b130cd8c9a5e9da563cbf]

        Remove trailing whitespace
        
        Change-Id: Iec7704a23bb9397bca1e0ee610707803c4b836b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146714
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-09  Tor Lillqvist  <tml@collabora.com>  [d5f5f0984510d6c1b453e31c1ad58fb29fed278b]

        Use SIMD in pixman for WASM
        
        Emscripten and WASM do have some support for SSSE3, so let's try to
        use it, with -msimd128. See
        https://emscripten.org/docs/porting/simd.html.
        
        WASM is not x86, though, so avoid use of inline x86 assembly, like the
        CPUID instruction.
        
        Emscripten does not have <mmintrin.h> but does have <xmmintrin.h>,
        <emmintrin.h>, and <tmmintrin.h>.
        
        Change-Id: Ic3a47291f6c6dee6843e93ccecc92a643b269cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146691
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-09  Caolán McNamara  <caolanm@redhat.com>  [c440d1ef3d31d41c94a6d59372bbec16d9f5dc5d]

        use new baseclass member instead
        
        Change-Id: I8a1855f24370c250d0d9aecd583fa47ffaa03afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-09  Tor Lillqvist  <tml@collabora.com>  [d552b4a549d614a03aa9328e017dec27bd3ff41e]

        Enable opening of downloaded fonts only in ForKit in Online
        
        We want that only the ForKit process needs to have access to new font
        files added to a Collabora Online instance dynamically by downloading
        from a server. There are however many locations in the Kit process, in
        core and in external libraries like harfbuzz, where the code wants to
        open a font file.
        
        Handle this so that the ForKit process opens such a downloaded font
        file and doesn't close it. The file descriptor is thus inherited by
        Kit processes.  The font file pathname passed on to other code is a
        fake on in the format "/:FD:/%d" where the %d is the file descriptor
        of the opened font file. Add checks in all places where font files are
        opened, look for this special pathname format, and modify the code to
        just dup() the already open file descriptor in that case.
        
        All this is relevant for Linux only, as Collabora Online runs on
        Linux.
        
        Do the above for harfbuzz, cairo, fontconfig, and freetype.
        
        In addition make sure that these libraries (except harfbuzz which
        needs to be a static library and freetype) when bundled, on Linux, are
        built as shared libraries, and won't be confused with the
        corresponding system libraries by making sure their sonames are
        different.
        
        Change-Id: Ib059cb27e1637d07bb709249abd0d984f948caa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140714
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146341
        Tested-by: Jenkins

2023-02-09  Henry Castro  <hcastro@collabora.com>  [1854f8ae2cf5966db1b51968dafc27785d3b7a11]

        lok: sc: avoid the shared spreadsheet dialog
        
        It is not needed the LO core shared spreadsheet
        because the online has collaborative functionality turns on
        by default.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I57ab83eae2913522d55704ae5a115e30c9d10034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145091
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145613
        Tested-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 7137fa5158530c0f6adb1f80f82203b43213187f)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146632
        Tested-by: Jenkins

2023-02-09  Stephan Bergmann  <sbergman@redhat.com>  [6031935412efbd610486af11561b8818d3e4d1bf]

        loplugin:staticaccess
        
        Change-Id: I24aa6b773f13b5d9924fbc867090ab9bf8c42045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146681
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-09  Caolán McNamara  <caolanm@redhat.com>  [ead9ff420989c7991108428a21eef5c3f0e9c362]

        ofz#55798 Timeout
        
        Change-Id: Ifbff597d02da9b870ef936bdcca31e31d49cbf58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-09  Andras Timar  <andras.timar@collabora.com>  [86c53eb59a6ada104358c9dbe3b50dac71af2dcc]

        fix internal python build on powerpc64le-unknown-linux-gnu
        
        Change-Id: I49c1368542a1af5dbbf377dbd8cb0cad8c6e2a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135174
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146689
        Tested-by: Jenkins

2023-02-09  Dennis Francis  <dennis.francis@collabora.com>  [b9516ea478b7df97cd97c48d5462f0e544b6b584]

        lok: do not recreate lok-drawview for every tile paint
        
        This lets the ScLOKDrawView live long enough for non-tile painting
        related invocation of its methods and hopefully those of its member objects.
        
        This is a blind fix for the following crash:
        
        /opt/collaboraoffice/program/../program/libsclo.so
        	(anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact(basegfx::B2DVector&, sdr::contact::ViewObjectContact const&) const
        ...
        /opt/collaboraoffice/program/libmergedlo.so
        	SdrTextObj::NbcSetOutlinerParaObjectForText(std::unique_ptr<OutlinerParaObject, std::default_delete<OutlinerParaObject> >, SdrText*)
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/svdraw/svdotext.cxx:1379
        /opt/collaboraoffice/program/libmergedlo.so
        	sdr::properties::TextProperties::ItemSetChanged(SfxItemSet const&)
        		/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:360
        /opt/collaboraoffice/program/libmergedlo.so
        	sdr::properties::RectangleProperties::ItemSetChanged(SfxItemSet const&)
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/sdr/properties/rectangleproperties.cxx:54
        /opt/collaboraoffice/program/libmergedlo.so
        	sdr::properties::DefaultProperties::SetObjectItem(SfxPoolItem const&)
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/svx/source/sdr/properties/defaultproperties.cxx:120
        /opt/collaboraoffice/program/libscfiltlo.so
        	XclTxo::XclTxo(XclExpRoot const&, EditTextObject const&, SdrObject*)
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/include/svl/cenumitm.hxx:26
        /opt/collaboraoffice/program/libscfiltlo.so
        	XclObjComment::XclObjComment(XclExpObjectManager&, tools::Rectangle const&, EditTextObject const&, SdrCaptionObj*, bool, ScAddress const&, tools::Rectangle const&, tools::Rectangle const&)
        		/opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:179
        /opt/collaboraoffice/program/libscfiltlo.so
        	XclExpNote::XclExpNote(XclExpRoot const&, ScAddress const&, ScPostIt const*, rtl::OUString const&)
        		/opt/rh/devtoolset-10/root/usr/include/c++/10/tuple:137
        /opt/collaboraoffice/program/libscfiltlo.so
        	ExcTable::FillAsTableXml()
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/include/rtl/ref.hxx:65
        /opt/collaboraoffice/program/libscfiltlo.so
        	ExcDocument::ReadDoc()
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/sc/source/filter/excel/excdoc.cxx:747
        /opt/collaboraoffice/program/libscfiltlo.so
        	XclExpXmlStream::exportDocument()
        		/home/collabora/jenkins/workspace/build_linux_co-2021_online_snapshot/sc/source/filter/excel/xestream.cxx:1107
        /opt/collaboraoffice/program/libooxlo.so
        
        Change-Id: I248395cca1e2da37208fc449aca731175a5aa368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133914
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit c17c410706eab6e4d449b2a20a51bf3702329341)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143583
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146683
        Tested-by: Jenkins

2023-02-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8c3a48700d02f3977e855062358bd04f2ffbecf7]

        Update git submodules
        
        * Update translations from branch 'master'
          to 579a868ba956eb78425da0c2510df67a12654c7e
          - update translations for 7.5.1 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: Ic13a9cd6a7a1e31a54af71cca958781b6b663f86
            
2023-02-09  Michael Weghorn  <m.weghorn@posteo.de>  [4aa73a298f4849e222aa3c6111d8b5c57e417e4b]

        android: Update Android Gradle Plugin to 7.4.1
        
        Change-Id: I2a709e27d3ba42f0d1c2ae9510d2cbf1f38c484d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146682
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-02-09  Caolán McNamara  <caolanm@redhat.com>  [f121b890f8f70fe2a0e633d3b4ad59c27ebba9b3]

        tdf#153229 add an extended tip for this new widget
        
        and fix mnemonic target
        
        Change-Id: Iad68048a6f0f824b774306033fdbbfe65b152804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-09  Caolán McNamara  <caolanm@redhat.com>  [9850aed84b8aa0a47eb89c7b547f1b90420db9a3]

        cid#1401328 suppress Uncaught exception
        
        Change-Id: I20d7e1777b94d9e1d81e8e5b1640b8e912a981d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146676
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-09  Miklos Vajna  <vmiklos@collabora.com>  [00b9b33334791079c2dc26b1ed4c123450cabf7d]

        sw: call FormatEmpty() in SwTextFrame::Format() for split fly masters
        
        The problem was that the text in the anchor frame of a split fly frame
        was duplicated on the old page and the new page as well. The reason for
        this seems to be that the master has no content and the follow has all
        the content (this is wanted), but then there is no code to explicitly
        clear the master.
        
        In other cases the master always gets some new content where portion
        building for that new content starts by throwing away the old portions.
        
        Once SwTextFrame::Format() and SwTextFrame::FormatEmpty() explicitly
        checks for these master anchors, the unwanted text in the master anchor
        disappears.
        
        An extra tweak is needed in SwTextFrame::PaintEmpty() to even hide the
        paragraph marker: this frame is empty but has a follow frame, so we
        should not show a paragraph marker there.
        
        Finally introduce a SwTextFrame::HasNonLastSplitFlyDrawObj() to be able
        to check for this "empty master anchor for split fly" case at a single
        place.
        
        With this <https://bugs.documentfoundation.org/attachment.cgi?id=185144>
        from <https://bugs.documentfoundation.org/show_bug.cgi?id=61594> gets
        laid out reasonably: the position is not perfect but we detect that only
        1 para of the text frame fits page 1, we create a 2nd page and we
        correctly move exactly the text frame's 2nd para to page 2.
        
        Change-Id: I871bba2de5b829e667d5cfb1cbe0ba4cc2274edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146680
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-09  Miklos Vajna  <vmiklos@collabora.com>  [25a16e7543965565a4227506003adc916deea500]

        sw floattable: fix cid#1520804
        
        GetFrameRstHeight() already assumes the m_pFrame is non-nullptr, so no
        need to check for this.
        
        The logic in the block will be necessary elsewhere as well, I'll extract
        that to a function in a follow-up change, so let's just do a minimal fix
        here.
        
        Change-Id: I6cb2a44e629c273f473278d61607705a2b9a7a4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146679
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-09  Miklos Vajna  <vmiklos@collabora.com>  [85a64197f86b77e295b9ddfc81abf1aca4aad47d]

        sw: fix undo comment of FN_UPDATE_TEXT_FORMFIELD
        
        It's an update, not an insert. One has to dispatch .uno:TextFormField,
        then move inside the formfield with the cursor finally dispatch
        .uno:UpdateTextFormField to see this in action.
        
        Change-Id: Id9e3c7b9d08582cbf83f64ff04c97dff5cbb88f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146671
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-09  Hossein  <hossein@libreoffice.org>  [b1f0c23720cbb7a30128c066d54f7dcf1fdc6178]

        tdf#153476 Disable MS telemetry in VsDevCmd.bat
        
        MS telemetry inside VsDevCmd.bat causes problems for the autogen.sh
        script which uses it to find the Visual Studio C/C++ standard library
        via the environment variables that show the UCRT path and version.
        
        VsDevCmd.bat is the "Developer Command Prompt for Visual Studio".
        
        The telemtry is disabled by:
        
          set VSCMD_SKIP_SENDTELEMETRY=1
        
        This change resolves the problems described in tdf#153476.
        
        Change-Id: I8b77a2ca0c3577b3ba490723ab7901f463562578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a4a00a51acca8f9b5e775547abff0c4dc9144d7]

        re-apply "optimize ConfigurationProperty::get()"
        
        This reverts commit 05b2bfc289df8712097cc1e640bf7d3bc6b86a84,
        but adds clearing of some more members, which were holding onto
        references to bits of config data after the config service was
        disposed.
        
        Change-Id: I9969ee2472445e4e1dbe8ea15e081401845ad29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146605
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-09  Devansh Jain  <d.jain.182002@gmail.com>  [81fa02eedbda2afa34c82420a02cd3b3f825be06]

        tdf#143148 Use pragma once instead of include guards in hwpfilter
        
        Change-Id: I010b6c76c1f859340f544409bbaab946cf2a6aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146554
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-08  Justin Luth  <jluth@mail.com>  [6bc6da1d03327450571b6811e192787ad90ecea2]

        tdf#153423 tdf#150197: use getToken in proper order
        
        This fixes a LO 7.5 regression from my commit
        727c5ed30f68abc28bb04531b25a1df30810760f
        
        getToken steps along the string and consumes it,
        so these needed to remain in the same order as
        they had been originally. Dumb thing to overlook.
        
        Change-Id: I483980eafb7deb0c224063ad41616bb21ddb2191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146672
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-08  Stephan Bergmann  <sbergman@redhat.com>  [a82c783a28b147963486c492184768be6be37da0]

        Adapt to macOS Resources vs. share naming
        
        On macOS, "Tools - Macros - Organize Macros - Basic... - Macro From:"
        erroneously listed all the per-application modules ("Access2Base", "Depot",
        "Euro", ...) under "My Macros" instead of "Application Macros".
        
        Change-Id: Ic997ab30d9205d8402136ea381745c08ce555623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146673
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [b9399259b2cc612e38b178667e08d444a7e2fc1e]

        tdf#153229 use bestMatchFromAppearancesWithNames to take user pref into account
        
        so user's override of system is taken into account for the icon theme.
        
        Change-Id: I02a9bf67eb6a3406f0e60bea58387e2e7457c995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [102e15d6f3960b0ea357b89243b6fe85df34bfec]

        Related: tdf#152486 infobar is white text on light button in light mode
        
        background isn't "bright" or "dark" enough to be considered one or the
        other. This is only used for the infobars, so black text is good enough
        for the current bg colors in use.
        
        Change-Id: I4c2c4fadac72cc35aebeadec417186c6358c0a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Justin Luth  <jluth@mail.com>  [7b3e0639962bab6e757381ad2b3e4868c61ed3b7]

        Revert "tdf#148360 doc import: add NO_NUMBERING_SHOW_FOLLOWBY(true)"
        
        This reverts commit 2405a36f3bcd43f80371ccaed47f7523ff0d8757
        which was backported to 7.4.1.
        
        This solves the regression report for DOC in tdf#153042.
        
        The problem is that the tab-without-numbering is displaying in
        cases where it shouldn't (i.e. when the tabstop position matches
        the first line indent).
        
        Although the patch itself is fine (DOC should do the same thing as DOCX)
        the feature is incomplete, even for DOCX/RTF. So just remove DOC
        from this mix - especially since there seem to be a LOT more instances
        of DOC files that need the incomplete aspect.
        
        Once it is proven to work OK for DOCX, we can add DOC back in.
        
        Change-Id: I3c550fc2ca29cf1490ec0a5e3979a6acbd102385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146670
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f1dd12d808a41ca70d4a33787f1bdff9d44a5ac]

        osl::Mutex->std::mutex in ScExternalRefCache
        
        Change-Id: I3736683d0a7d20694ac2375016c722b4233fdcae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146555
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [f7c03364e24da285ea95cea0cc688a7a120fc163]

        tdf#153229 add a switch to override honoring system dark mode
        
        Change-Id: Iafb6182e05dc65d20d0809476ee58908f7426d39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [68ab2e109edf8b81c48e953f7c8d43841e07365a]

        SetAlternatingRowColors is gone now
        
        Change-Id: I59a17b45c34902d3b692c5a6bd70f4286bcae609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Stephan Bergmann  <sbergman@redhat.com>  [d7100211be8c79d00f6044e76e2102206dad9432]

        Fix bogus uses of OUString::createFromAscii
        
        We got a report on IRC of builds failing with
        
        > svidl: /home/dolezvo1/Downloads/libreoffice/sal/rtl/ustring.cxx:278: void rtl_uString_newFromAscii(rtl_uString**, const char*): Assertion `static_cast<unsigned char>(*pCharStr) < 0x80' failed.
        
        when the "l" in "Downloads" was some non-ASCII character (whose exact identity
        was apparently obscured by the used pastebin service, though).
        
        Change-Id: Ib460793b0f8aa5e8f8822fa224d67e5a622a234d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146664
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [52d070f753228cf99e76cb5656f12181fc0a397c]

        remove SvTreeListEntry background color
        
        and don't overwrite the rendercontext background, which has the side
        effect that switching dark/light mode or other theme changes gives
        immediate change in visible treeviews. So tools, options, view,
        switching Light/Dark, Apply doesn't show a treeview with the old
        modes background
        
        Change-Id: I9c403beba53f1f1a28464ad8c1c70018be1cf43f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [4e4717a27ceae2252befd9b3c49cc545fdb82c37]

        SetAlternatingRowColors is unused
        
        Change-Id: I0f214bccb28c9894b5c23600ca19b16dd3257cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Michael Stahl  <michael.stahl@allotropia.de>  [80dd2ce29413809ca337618e313795bd9610cf80]

        openssl: upgrade to release 3.0.8
        
        Fixes CVE-2023-0401 CVE-2023-0286 CVE-2023-0217 CVE-2023-0216
        CVE-2023-0215 CVE-2022-4450 CVE-2022-4304 CVE-2022-4203 CVE-2022-3996
        
        Remove the patch that fixed CVE-2022-3996.
        
        Change-Id: I8587d780ea7dc07637278643dc1c49b577e3ae56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146657
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [9ebba1d99457a1049c2f61ba15cd4c99a68d74e7]

        tdf#147488 BASIC: Create empty module when an empty library is selected
        
        If the Standard library is empty (has no modules), when the Basic IDE is opened it shows only a black screen with nothing.
        
        This patch makes it so that when the Standard library has no modules, a generic module is created and shown.
        
        Change-Id: I26dbe41b4244492a21649ab08c5fc2df24ca12a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145309
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-02-08  Szymon Kłos  <szymon.klos@collabora.com>  [54298f7f23e699e99e979bdf945c6ae2bee1a12f]

        htmlexport: close li mark not only in xhtml
        
        As commented in sw/source/filter/html/htmlatr.cxx:766
        "// OutHTML_NumberBulletListEnd() will end a list item"
        
        We have to do it also in HTML not only XHTML so node will be
        closed and we get correct structure.
        
        This is followup for:
        commit 2466b9fcf20ee61f6fc621298011c0efaa55e7c6
        Author: Miklos Vajna <vmiklos@collabora.com>
        Date:   Mon Feb 21 16:38:51 2022 +0100
        
            sw HTML export, XHTML mode: fix lost </li> when last list item is not numbered
        
        Change-Id: I99baa59b437572b157df8057445cf6c741f936b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143508
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146651
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-08  Michael Stahl  <michael.stahl@allotropia.de>  [a0875d09d9eeb368e9e319f3f2f29ec3be71b56c]

        editeng: remove SvxLRSpaceItem::nTxtLeft
        
        Several parts of SvxLRSpaceItem appear to maintain an invariant of the
        3 members nTxtLeft/nLeftMargin/nFirstLineOffset: nLeftMargin is either
        equal to nTxtLeft if nFirstLineOffset is positive, otherwise equal to
        nTxtLeft + nFirstLineOffset.
        
        But not every part maintains it: there are functions SetLeftValue() and
        SetLeft() which simply write into nLeftMargin regardless, and a
        constructor that takes 3 separate numbers without any checks.
        
        The constructor calls violate the invariant in 2 ways: nTxtLeft is
        simply set to 0 (many cases), and one case in OutlineView::OutlineView()
        that sets nTxtLeft to 2000 but the other 2 at 0.
        
        Another odd thing is that the UNO services that expose SvxLRSpaceItem
        either expose a property for MID_L_MARGIN or for MID_TXT_LMARGIN but
        never both.
        
        It looks like there are 2 distinct usages of SvxLRSpaceItem:
        for anything that's applied to paragraphs, all 3 members are used;
        for anything else, nTxtLeft is unused.
        
        Try to simplify this by removing the nTxtLeft member, instead
        GetTextLeft() simply calculates it.
        
        Also assert in SetLeftValue()/SetLeft() that nFirstLineOffset is 0.
        
        Change-Id: Ida900c6ff04ef78e92e8914beda1cc731a695b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146643
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-08  Michael Stahl  <michael.stahl@allotropia.de>  [9bf7092aa05b47e6290d894edaf00f21038a636a]

        editeng: SvxLRSpaceItem uninline some functions
        
        Change-Id: I719ec54ef0e4540c8dbacb783b335ccb69b08e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146642
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-08  Szymon Kłos  <szymon.klos@collabora.com>  [1e23e26d48eabb829c39304a78fad26b10f76d7f]

        tdf#147740 fix disappearing icons in groupbar
        
        Change-Id: Ia67b90d05bccbd4d2c2553109ea7372574ee21d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146584
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-08  Stephan Bergmann  <sbergman@redhat.com>  [6f91ab6de9ce169ca489f4574b119e06ef6db9dc]

        Avoid SolarMutexReleaser
        
        UITest_writer_macro_tests occasionally failed with
        
        > ==3730889==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d00057d080 at pc 0x7f75353d933c bp 0x7ffcedf8de90 sp 0x7ffcedf8de88
        > READ of size 8 at 0x60d00057d080 thread T0
        >  #0 in basctl::ModulWindow::GetState(SfxItemSet&) at basctl/source/basicide/baside2.cxx:1088:22
        >  #1 in basctl::Shell::GetState(SfxItemSet&) at basctl/source/basicide/basides1.cxx:1160:18
        >  #2 in SfxStubbasctl_ShellGetState(SfxShell*, SfxItemSet&) at workdir/SdiTarget/basctl/sdi/basslots.hxx:164:1
        >  #3 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*) at sfx2/source/control/dispatch.cxx:1658:9
        >  #4 in SfxBindings::Update_Impl(SfxStateCache&) at sfx2/source/control/bindings.cxx:260:22
        >  #5 in SfxBindings::NextJob_Impl(Timer const*) at sfx2/source/control/bindings.cxx:1275:17
        >  #6 in SfxBindings::NextJob(Timer*) at sfx2/source/control/bindings.cxx:1220:5
        >  #7 in SfxBindings::LinkStubNextJob(void*, Timer*) at sfx2/source/control/bindings.cxx:1218:1
        >  #8 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:111:45
        >  #9 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21
        >  #10 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:481:20
        >  #11 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13
        >  #12 in SvpSalInstance::CheckTimeout(bool) at vcl/headless/svpinst.cxx:161:53
        >  #13 in SvpSalInstance::ImplYield(bool, bool) at vcl/headless/svpinst.cxx:399:17
        >  #14 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:471:21
        >  #15 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:475:48
        >  #16 in Application::Yield() at vcl/source/app/svapp.cxx:559:5
        >  #17 in Application::Execute() at vcl/source/app/svapp.cxx:453:13
        >  #18 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1604:13
        >  #19 in ImplSVMain() at vcl/source/app/svmain.cxx:203:35
        >  #20 in SVMain() at vcl/source/app/svmain.cxx:235:12
        >  #21 in soffice_main at desktop/source/app/sofficemain.cxx:94:12
        >  #22 in sal_main at desktop/source/app/main.c:51:15
        >  #23 in main at desktop/source/app/main.c:49:1
        >
        > 0x60d00057d080 is located 0 bytes inside of 144-byte region [0x60d00057d080,0x60d00057d110)
        > freed by thread T20 here:
        >  #0 in operator delete(void*, unsigned long) at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
        >  #1 in basctl::ModulWindow::~ModulWindow() at basctl/source/basicide/baside2.cxx:235:1
        >  #2 in VclReferenceBase::release() const at include/vcl/vclreferencebase.hxx:43:13
        >  #3 in rtl::Reference<basctl::BaseWindow>::~Reference() at include/rtl/ref.hxx:129:22
        >  #4 in VclPtr<basctl::BaseWindow>::disposeAndClear() at include/vcl/vclptr.hxx:209:5
        >  #5 in basctl::Shell::~Shell() at basctl/source/basicide/basidesh.cxx:246:23
        >  #6 in basctl::Shell::~Shell() at basctl/source/basicide/basidesh.cxx:228:1
        >  #7 in SfxViewFrame::ReleaseObjectShell_Impl() at sfx2/source/view/viewfrm.cxx:1114:9
        >  #8 in SfxViewFrame::~SfxViewFrame() at sfx2/source/view/viewfrm.cxx:1905:5
        >  #9 in SfxViewFrame::Close() at sfx2/source/view/viewfrm.cxx:1166:5
        >  #10 in SfxFrame::DoClose_Impl() at sfx2/source/view/frame.cxx:138:37
        >  #11 in SfxBaseController::dispose() at sfx2/source/view/sfxbasecontroller.cxx:931:28
        >  #12 in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1493:33
        >  #13 in (anonymous namespace)::XFrameImpl::close(unsigned char) at framework/source/services/frame.cxx:1704:12
        >  #14 in SfxFrame::DoClose() at sfx2/source/view/frame.cxx:104:29
        >  #15 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) at sfx2/source/view/viewfrm.cxx:1703:28
        >  #16 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:40:24
        >  #17 in (anonymous namespace)::SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) at sfx2/source/doc/objxtor.cxx:145:12
        >  #18 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1487:76
        >  #19 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:725:13
        >  #20 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
        >  #21 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
        >  #22 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
        >  #23 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny>>*) const at binaryurp/source/incomingrequest.cxx:236:13
        >  #24 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26
        >  #25 in request at binaryurp/source/reader.cxx:86:9
        >  #26 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100:17
        >  #27 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31
        >  #28 in threadFunc at include/osl/thread.hxx:189:15
        >  #29 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:265:9
        
        where the ModulWindow apparently happens to get deleted by the UNO worker thread
        in the window of time when ModuleWindow::IsPasteAllowed temporarily dropped the
        SolarMutex on the main thread.
        
        Temporarily dropping the SolarMutex around the xClipboard->getContents() call
        had been there ever since the code got introduced in
        c29c7a86c8cb18d0e0602cddb3f24373e2424098 "#92173# Reimplement Basic password
        protection UI in Basic IDE", and at least theoretically it is of course the
        right thing to do to not call that UNO API with the SolarMutex locked.  But it
        is of course also not a good idea to use SolarMutexReleaser, and that
        xClipboard->getContents() call doesn't look like it leads to deadlock.
        
        Change-Id: I3660065508d37801125f675440071d61e41906d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146650
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [e1e6ff49a244039bc2c2c09026ab9ca3ef96e859]

        tdf#153434 crash on "new" macro with no cursor
        
        probably good in trunk since:
        
        commit 6e2bd11251afbe64f9889ede36b28b00f47aaff5
        Date:   Sun Aug 7 12:49:11 2022 +0100
        
            tdf#150291 Revert "Fix crash when no valid EntryDescriptor found"
        
        but still visible in 7-4
        
        Change-Id: I63898ed3e33f73f8a93528872449539c5df6574f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Caolán McNamara  <caolanm@redhat.com>  [bad7bb439461ab0d50b44260c7274b05758d8e1f]

        Related: tdf#153438 this toplevel needs to be a GtkBox
        
        Change-Id: I04a503f77dcbfb03cfcfce26f0a94d3cb7f54b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-08  Miklos Vajna  <vmiklos@collabora.com>  [58b7b180297116997df6bfab7cbcf90d38d25f06]

        sw layout xml dump: show offset of text frames
        
        This can be non-zero for follows in case a text frame is split into a
        master and follows.
        
        Also handle offset/follow of text frames when showing frame text, so
        only the relevant substring is shown in split frames.
        
        Change-Id: Ic3cb6daacf3a1771652afc9b64312585a8258a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146648
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-08  Mike Kaganski  <mike.kaganski@collabora.com>  [dcc52933cac1bf08c3e487bd3a12fb035d96eac2]

        Simplify a bit
        
        Change-Id: I77482a2e1d382663ca31991130526feb7ce85504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146647
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-08  Miklos Vajna  <vmiklos@collabora.com>  [d18096aeafa9ad5924f730cd39138fdf4f7d9609]

        CppunitTest_sw_htmlexport: avoid preTest() magic in ...
        
        ... testExportOfImagesWithSkipImagesEnabled.
        
        Set the filter option explicitly, rather than inferring it from the test
        name.
        
        Change-Id: I931711f394b41916a640bd3be974337d61491928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146640
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4a0d671706306661c4a5072ce4769dc47bc65f71]

        svx: don't access m_aOutRect directly - go through methods
        
        Change-Id: If37d6fd7108d1289f838bd3f81ae9b500c8ddb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146601
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c97950cdb22fd9135ebb127a78f8497da7478ebd]

        basegfx: restructure B1DRange and B2DRange tests and add use cases
        
        Change-Id: I423171e886e56a0fa107c58edee7bf8a2259a6fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146600
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-07  Khaled Hosny  <khaled@aliftype.com>  [9d44236a62bf59d120dda89924d0d1407b2bd52b]

        tdf#153436: Improve handling of Arabic system spell dictionary on macOS
        
        The system has only a generic “ar” spell dictionary, but LibreOffice
        wants country code as well. Since it is the same dictionary for all
        Arabic locales, we now add entries to all Arabic country codes we know
        about.
        
        Change-Id: Iaf5a8f495b3d1023d7fe40654afa0cce3fe9fbdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146641
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [ded56141c44971aa4b279bf232f0383b5b679694]

        ofz#55771 Timeout
        
        Change-Id: If10047bc9da297c70c6f0457680e84e788b7c438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146644
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [91fa7cc3dc124877f810599fe3c315cda6d03df6]

        cid#1520798 Use after free
        
        since:
        
        commit 441d0b0fb2eef890a465c061a3d68a07c4a51832
        Date:   Fri Jan 27 19:03:35 2023 -0500
        
            tdf#151548 sw content controls: actually gotoFormatContentControl
        
        Change-Id: I0460023c2f89a3a151c01a8f844513df39a35855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146638
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [58732c0760478d00dbf34c8d631e75a0262a2b75]

        cid#1520802 Dereference null return value
        
        Change-Id: Iba193386d1ee82c8f47ece2445cfb2ecaeeed998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146636
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [93cd7e878ac03232aaebb14e9425d80fc97f8846]

        cid#1520799 Unchecked dynamic_cast
        
        and
        
        cid#1520801 Unchecked dynamic_cast
        
        Change-Id: I03a0fdde1da3a9f10699b35455fa2f79ff00a494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [6285297c6933fa9121d7dd412b1f1daaa8b072a5]

        cid#1520803 silence Unchecked return value from library
        
        Change-Id: I47bfb2b64526d47c2a064e3bb3d93474420825af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146613
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Khaled Hosny  <khaled@aliftype.com>  [ad5005c3bfb6105e92e52111c3093312a6cb8ff2]

        tdf#153376: Fix reading USE_TYPO_METRICS flag
        
        Font data is big endian while SvStream defaults to little endian.
        
        Regression from:
        
        commit fb417ee082afdd2e80a1f48aa420bb8d5cb97686
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Fri Sep 30 12:35:10 2022 +0200
        
            vcl: Apply variations to font metrics
        
        Change-Id: I474ec2a76057baca93f350e23c3779985abdf9da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146611
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2023-02-07  Michael Stahl  <michael.stahl@allotropia.de>  [345f23474845da0defa4a9276228f54b5ded5736]

        tdf#153083 writerfilter,sw: DOCX locale-dependent TOC \t style names, 3
        
        The import crashed on fdo85740-1.docx with an unhandled exception.
        
        This is because it mapped the TOC style "Table of Figures" from "table
        of figures", but the ApplyStyleSheetsImpl() actually uses the converted
        name "Drawing" instead, so "Table of Figures" didn't exist.
        
        (regression from commit ca71482237d31703454062b8b2f544a8bacd2831)
        
        It turns out that once that is fixed, the DOCX export needs to convert
        "Drawing" back to "Table of Figures" in the TOC field.
        
        Change-Id: I4858c79dd74154b229b7568610c0b8ba7b3e2b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146610
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-07  Miklos Vajna  <vmiklos@collabora.com>  [d6b9529c4f63d1dd5c57db4f4912471cce2507d9]

        sw floattable: fix cid#1520800
        
        Only SwFrame::GetLeaf() calls this, but it only does so when we're in
        an at-para anchored fly frame, so we can require that this succeeds.
        
        Change-Id: I6c99bc2ea1ab4f338a536272ccce13fd22b30246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Michael Stahl  <michael.stahl@allotropia.de>  [0fafc03c24996ccd53dbf76eaab372779cfbca90]

        tdf#153083 writerfilter,sw: consolidate StyleName->StyleId in msfilter
        
        Turns out there was already a function MSWordStyles::CreateStyleId()
        doing the same thing as FilterChars(), presumably better.
        
        Change-Id: Idd0129c753841b86bd026e1300aa57a56721c89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146609
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-07  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [74590b782dfef65c612bb1577cdcb0a5f29df82a]

        Resolves tdf#153127 - Separate book from other modes in print preview
        
        Change-Id: I1573034b9df0f199f2b71e640051cad19fa6d220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146587
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-02-07  Heiko Tietze  <tietze.heiko@gmail.com>  [0b9aef0aaa7c17cc7da722002e27996a01ffc7fa]

        Resolves tdf#148441 - Hide viewlayout in statusbar in preview mode
        
        Change-Id: I255ad3b952d7b424e9ff0475798bbe0cfc57ef9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146004
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2023-02-07  Miklos Vajna  <vmiklos@collabora.com>  [ddfb800e60d98340c99c8013f6df3f2060687dd0]

        sw: fix anchoring in SwFrame::GetNextFlyLeaf()
        
        The core of this change is in SwFrame::GetNextFlyLeaf(), which used to
        assume that there is a next frame after the fly's anchor, but it's
        perfectly valid to not have such a frame. Instead if a fly is split,
        then also split its anchor, so effectively only the last follow of such
        anchor hosts content, all the others are empty and only serve as an
        anchor of a non-last member of a split fly frame chain.
        
        Once this anchoring is changed, adjustments are needed at other places,
        so a sample split fly frame (2 paragraphs, 1st para on first page, 2nd
        para on second page) is still layout out correctly:
        
        - SwAnchoredObject::FindAnchorCharFrame(): return the right follow text
          frame for follow flys. This is needed because flys have to be anchored
          to masters, and then this function can find the frame that's used for
          positioning.
        
        - SwFlyFrame::Format(): get the rectangle of the correct body frame,
          otherwise we would get the bottom of the 1st body frame instead of the
          2nd body frame for the follow fly, leading to a negative height of the
          follow fly frame.
        
        - SwToContentAnchoredObjectPosition::CalcPosition(): position against
          the right follow text frame, similar to
          SwAnchoredObject::FindAnchorCharFrame().
        
        - SwTextFrame::AdjustFollow_(): don't join a master with its follow if
          there is a split fly frame anchored in the master. The assumption is
          that first the fly has to be moved away, then we can do such a join.
        
        - Introduce a SwTextFrame::GetSplitFlyDrawObjs() to avoid copy&paste in
          SwTextFrame::AdjustFollow_() & SwTextFormatter::FormatLine().
        
        With this, a sample split fly frame is split to two pages with correct
        anchors if SW_FORCE_FLY_SPLIT=1 is set. The anchor frame has duplicated
        text on the 1st and 2nd page still, though.
        
        Towards an initial working layout for multi-page fly frames.
        
        Change-Id: Ie99b13c2e318ec63f69c8a47bbc604771509e24a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146607
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-07  Eike Rathke  <erack@redhat.com>  [909a25d30b09ebd3a023105a9c3cc4d20add094a]

        Resolves: tdf#139934 always apply cellXfs xf explicits (tdf#123139 related)
        
        Change-Id: Id1e12ee8677a25a645bfd53b4968a17c9a1eabe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146599
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [fba2d6a1026020164c80d65037ec3aae33a3f774]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I49c2b854d19a83ac32f78be32a77ad6e771b73ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146593
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [621d4b0afc34646cec59b53e192be47eefe6062d]

        sw: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: Ic8e35f6f9f029ea6ae4620946edb69ca7a6618bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146591
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-07  Szymon Kłos  <szymon.klos@collabora.com>  [3f794ed02d588d71b2503d2e558c2e168f034fdf]

        lok: don't pretty print html for online
        
        followup for "lok: don't limit line length in HTMLWriter"
        
        Pretty printing makes html more readable for human but introduces
        lots of new line marks which are later interpreted in the client
        as a valid new lines in the document content.
        
        This was causing multiplying the line breaks when inserting hyperlinks
        where we read current selection's content and then we pass it back
        to the core as link's content (with added new lines).
        
        This change needs cypress change to not contain "\n" at the beginning
        of some content read from the document.
        
        This also afects copying from the online document to clipboard.
        
        Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136893
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141479
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-07  Szymon Kłos  <szymon.klos@collabora.com>  [6a7b3d59d790cb8ea55353fe4173d71a13931d50]

        tdf#153244 apply caption options
        
        Change-Id: I2aa53a85ab9f38ddf74caac85047235ea85a40af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146590
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [e7897ce47e415e46eb36687f911a9a4b09ca6b8a]

        crashtesting: crash in ScInterpreter::ScCountIfs
        
        seen on importing forum-mso-en4-253817.xls and others
        
        Error: attempt to advance a dereferenceable (start-of-sequence) iterator
        which falls outside its valid range.
        
        presumably since:
        
        commit 7674399aac661eb503d7badc53b9a4d68bd9839d
        Date:   Fri May 27 19:51:40 2022 +0200
        
            try to range-reduce even COUNTIFS if not matching empty cells
        
        bodge this to fill in 0 for missing ranges
        
        Change-Id: If77d8ab887859f11b240975bb837a27785f500a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146604
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Miklos Vajna  <vmiklos@collabora.com>  [6275bd9db475cb984ac153d06ed1ddadfa2fadb7]

        sw: handle split flys in SwTextFormatter::FormatLine()
        
        One workaround in SwFrame::GetNextFlyLeaf() is to assume that there is
        always a next frame after the fly's anchor when we split the fly. An
        alternative to this is to split the fly's anchor as well, so we always
        have a next such frame.
        
        When this happens, we hit various problems, the first is that once we
        have 2 flys after the split, we try to move the first fly to page 2 as
        well.
        
        The reason for this appears to be that SwTextFormatter::FormatLine()
        sets the height of the line in the fly's anchor to 1 twip larger than
        the available space. Disable this tweak when the only reason that text
        frame is on the page to serve as an anchor. We definitely don't want to
        move it to the next page, arguing it's too large.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: Ia7b7a93ff78af640366fb49e30e910e5f4e0e0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146602
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-07  Jean-Pierre Ledure  <jp@ledure.be>  [077ff26b682b7d31ea85e8adf66fc80432c876e8]

        Fix links in DispatchCommands wiki page
        
        The modified python script generates the
          https://wiki.documentfoundation.org/Development/DispatchCommands
        wiki page.
        
        The https://gerrit.libreoffice.org/c/core/+/142723
        commit has broken the links to OpenGrok in the last
        column ("Source files") of the tables and also the
        list of files at the bottom of the page.
        
        The actual page in the wiki, after upgrade to LO 7.5
        has been generated with the modified version of the script.
        
        Change-Id: I2ec674f4257229e543a7797fddd2f7a142a743f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146553
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [00659bcdbbb167596e6fd18e283a54819dd6fe91]

        improve readability of VirtualDevice constructor
        
        (a) It is not obvious what DeviceFormat::DEFAULT means
        (b) There are two parameters (each with two states), but only really 2
        possible overall states
        
        So
        (1) use more useful names
        (2) combine the two parameters into one enum
        
        Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [545ddfbaa98cfeaa35c95d7db7b16cd241cedc89]

        tdf#153321 use SeparatorColor for FixedLine
        
        so the separators as seen in NotebookBar, etc are drawn the same as the
        separators seen in the normal toolbar
        
        Change-Id: I22f4f5e5506e325f78951011f0574653ff5758e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [400e4b1866cbf7ab4b703e31f6c0e9b4040a58e0]

        sc: use try/finally to reset the changes in OptionsTreeDialog
        
        Otherwise it might affect other tests if it hits an assert
        
        Change-Id: I2d2fe1c2dfb931c8c9d95e61d8fdb31236b96c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146592
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [df2ad816288a4729c9cea8d14b7d590ac271d18b]

        Related: tdf#153319 don't destroy frame with IsDeleteForbidden set
        
        not sufficient on its own to fix this crash.
        
        Change-Id: Ibd8b68d7e007d8a22770b3d73f0d17a1869cf279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [4163bfc3c75a39a686083d566e6ed1b6c8c9908a]

        GtkPaned properties applied to children not in a GtkPaned anymore
        
        since
        
        commit 280e55bf440b32ec87ce79271276c24f55172663
        Date:   Thu Jun 23 16:25:11 2022 +0200
        
            Remove not necessary container in Animation Panel in Impress Sidebar
        
            It was causing layouting issues in LOK.
        
        Change-Id: I67bdb0283bd01397f59d9d4b4fbacd0610b606cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146567
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [7355c2ee8a9f0811d1cd3d37fc9dac2ad5f95774]

        uitest: reset value when changing the measurement unit
        
        Otherwise, changing it in one test might affect other tests
        Use @contextmanager decorator to change it back to default 'Inch'
        at the end of the test even if the test hits an assert
        
        Change-Id: I1e7b35019cd19b490aa619c0a866bb9f93820950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-07  Caolán McNamara  <caolanm@redhat.com>  [ca57cee2ae5718378193a9c7050248c63b5fa47e]

        ofz#55751 check that level is valid
        
        Change-Id: I971bdcc62fd3775f8f75bf69db41182afc4baefc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-07  Miklos Vajna  <vmiklos@collabora.com>  [9259f79517bec3e7ebbc423eca098694fbf2a079]

        sw: document SwFootnoteFrame
        
        Similar to the doc model, "footnote" actually means "footnote or
        endnote" in practice.
        
        Change-Id: I89a38ed91bbfb2e1948b5f4393d4929ecfd20e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146594
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-06  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c8e62c3dd1c66d2e5e7b598cd434df61cdc34801]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b1149d14e24a6611d00ca13d0942d17d617c2620
          - (Related tdf#153243) Update help page because of UI label change
            
              - update UI label
              - refactor page
              - rename German ID
            
            Change-Id: I9245d4f297cb3b6c890302b32419010a966c2646
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146209
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2023-02-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [05b2bfc289df8712097cc1e640bf7d3bc6b86a84]

        Revert "optimize ConfigurationProperty::get()"
        
        This reverts commit 7df433cdc33b4d6ba38eafad9282d015571433ef
        and its follow-ups:
        
        * b4b63d0c46979ad6b6aae5d6a4ea6672ea248e10 "try to fix some shutdown
        crashes"
        * 203ad037ccb9fdebffea4f622229ded90635eb8b "try to fix shutdown crashes in
        ConfigurationWrapper"
        
        since it introduced a crash starting with LibreOffice 7.4
        See https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*)
        Later, it was reverted in libreoffice-7-4 branch with
        df79a29ea20fb698d650be45a48c607f54476dea "Revert "optimize
        ConfigurationProperty::get()" (7.4 only)" so the crash
        is no longer reported in that branch.
        OTOH, Noel tried to fix it in master/libreoffice-7-5 branches
        with the two commits mentioned above but the crash is still being
        reported in LibreOffice 7.5
        After talking to him, he suggested to revert it all
        
        Finally, adapt code to make loplugin:stringviewparam happy
        with getPropertyValue
        Change-Id: Id9fa97d2a81a590e53abd027e978d2d6179222b8
        
        Change-Id: Id2e3475c342770be5705a74b9c0b45f45d6be5ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-06  Caolán McNamara  <caolanm@redhat.com>  [36aa8b43daccff63ab9b2f2c3df064abd2517a28]

        ofz: bump sc-rtf and html max lengths
        
        Change-Id: Id2b97538dcc2919b2fb993e8494478a7a444a9a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146568
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-06  Stephan Bergmann  <sbergman@redhat.com>  [9a23ded27470a4c57015e9e5d686259a60d464f2]

        Fix thinko when to sleep
        
        <https://ci.libreoffice.org/job/lo_ubsan/2672/> still failed with the same
        symptoms that 09c3a0aa13e7c4719a73728c2f9ba1f66cea7572 "A better fix for the
        stale TreeListEntryUIObject issue" had been supposed to fix.  And of course, it
        is the
        
        >                 xInsert.executeAction("CLICK", tuple())
        
        calls that actually trigger m_aUpdateTimer.Start() in
        SwChildWinWrapper::ReInitDlg, while the upfront m_aUpdateTimer.SetTimeout(200)
        in the SwChildWinWrapper ctor by itself is not relevant for the point in time
        where the timer actually starts (and where the Python code thus has to start
        waiting, too).
        
        Change-Id: I2b4fe7dadd470c62e7d63594a76d258faeac5906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146588
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-06  Yomnasalama  <yomnasalama2000@gmail.com>  [08cfcea7fef6cde9eddcfa461fe1edff99dadafe]

        tdf#147906 Use Math.hypot() for Pythagorean addition
        
        Change-Id: I644947ca22f493bbc805c45334450db8d4b4808b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146137
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-02-06  Szymon Kłos  <szymon.klos@collabora.com>  [52eba7937154a49e07360b297d5d7c396ca91903]

        Make LOKClipboard available to other modules
        
        LOKClipboard has higher level dependencies (sfx2) so it cannot be
        moved to the vcl where SystemClibpoard instance is created.
        
        - introduce new interface LokClipboard to differentiate
          from SystemClipboard so we can have vcl's and lok's implementations
          at the same time
        - publish LOKClipboard using new interface for other modules by adding
          component file in desktop module
        
        Thanks to that when code calls GetClipboard and we cannot get clipboard
        assigned to the vcl::Window* (for welded widgets) in GetSystemClipboard
        correct instance is returned (shared clipboard for current view) so we
        can access content which was copied before. Previously always a new
        instance was created (with empty content).
        
        test ScTiledRenderingTest::testPasteIntoWrapTextCell was broken
        add some content to clipboard to simulate more real case
        and test the content copied
        
        Change-Id: I23c0298960a710c498646493f33122b908864cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126310
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131644
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135198
        Tested-by: Jenkins

2023-02-06  Szymon Kłos  <szymon.klos@collabora.com>  [f16f69f719b7efa99a2b3a4d73dffc2777d5d425]

        lok: send status for file export dialogs
        
        Change-Id: I21530abc89808beb4c794f912e9453d8552c3b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146006
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146573
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-06  Miklos Vajna  <vmiklos@collabora.com>  [1f373260cf25ca2f36a929e1a27fde00641e5c09]

        tdf#152669 sw: fix missing table borders in the non-Word-table-cell case
        
        A 4x4 table had partially missing inner borders when the page's writing
        mode was set to vertical, for a newly created document.
        
        This went wrong with commit 526c8bdb54eff942d5213030d1455f97720a1ba7
        (sw: fix too long inner borders intersecting with outer borders for Word
        cells, 2022-01-06), which forgot to make changes in
        SwTabFramePainter::Insert() conditional on bWordTableCell.
        
        Fix the problem by making the SwTabFramePainter::Insert() changes
        conditional, similar to how SwTabFramePainter::FindStylesForLine()
        already did this.
        
        Note how the DocumentSettingId::TABLE_ROW_KEEP compat setting is off for
        new documents.
        
        Change-Id: Ie29d1613251d869e7ae78ea7dab3e75f0e6de229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146585
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-06  Szymon Kłos  <szymon.klos@collabora.com>  [ec93446f703746ec45a16846b291e5a002a788e7]

        lok: formulabar: fix URL fields selection
        
        field is calculated as 1 character by selection getter
        let's unfold fields and send real length
        
        Change-Id: I557f8785a4d2ee6a41c6c95f4551f5e104a58c02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146350
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146574
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-06  Szymon Kłos  <szymon.klos@collabora.com>  [887b2eb4583549d104c03747405e1f925ab6168a]

        jsdialog: weld all message boxes
        
        This fixes regression from:
        commit 9785cebe4cfdc296143757da6098a74b0252c618
        jsdialog: fix validation error dialog in Calc
        
        When inserting autofilter without header data
        - message box should appear
        
        Change-Id: Id5d26604a67f43700310cc0f51954b886c9de0f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146495
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146575
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-06  Miklos Vajna  <vmiklos@collabora.com>  [27fbab13557a75b5402c11a1697541edc124116a]

        sw: implement SwFrame::GetPrevFlyLeaf()
        
        This is much easier than the "next" case, since here we can nullptr when
        there is no previous leaf instead of creating one.
        
        With this, if the MoveBwd() call in SwContentFrame::MakeAll() is
        disabled, some simple fly frame can be split across 2 pages if it's
        positioned in a way that the rectangle of the fly would not fit into the
        body frame without changing the position, in SW_FORCE_FLY_SPLIT=1 mode.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I3b6ba85ad66117b5595a113d688e2fcb97bcf745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146571
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-06  Miklos Vajna  <vmiklos@collabora.com>  [6966957aa42dea54eff933665b49e3976b32eff0]

        sw: prefix members of RangeBorderEnumWrapper
        
        Seems this was the last unprefixed class in sw/.
        
        See tdf#94879 for motivation.
        
        Change-Id: I2adac7932b8a45f2b07f844e5c7bd06eb08a8618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146570
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-06  Tor Lillqvist  <tml@collabora.com>  [187d3b6e8fa0f763b3e9a2e185c61697e9dae7d5]

        Minor typo fixes and some additional information
        
        Change-Id: Ic0b76ca37dce37f88df62d80495e111c4d50818e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146572
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-05  Balazs Varga  <balazs.varga.extern@allotropia.de>  [d8ae6d1388f28c405c4de2dfe93dbfe2d8acd470]

        Related: tdf#150098 sc validation: allowing formulas for validity test
        
        Clean-up and a little optimization.
        
        Change-Id: Ib56d959188912f4b18acb5466ce55bc7b5b4ee4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146391
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [90a043f2589a70f6e035ba350ff7f673ae677f2e]

        osl::Mutex->std::mutex in sd::framework::FrameworkHelper
        
        Change-Id: I84d5eb29413b3242386f1ffb1beafa9622985ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146558
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [18f14b9e50407e4c0b97024c122f8ce7c0efaad4]

        osl::Mutex->std::atomic in sc::CSVFetchThread
        
        Change-Id: I615be595b73f4d55f13f7245b06783f6af03d58a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146557
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [640202f5248de274b83356e963b0e1a2e405aa18]

        osl::Mutex->std::atomic in sc::ReaderThread
        
        Change-Id: I10296bb29fc59475f0e3b13c06da97e703485792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146556
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-05  Greg Kelesidis  <greg.kelesidis@gmail.com>  [1e2f6e7b27fafd6c579dfb09ccd2012151b4ab7e]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Iaeabe4e21ffe407684a57e1988a836e7cf85b2a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146560
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-04  Caolán McNamara  <caolanm@redhat.com>  [f71ce9b35598d6aa64f3b095e0b3c7683948c280]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I97fb4edcad3a014b622f1a936adecd634121ad3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-04  Julien Nabet  <serval2412@yahoo.fr>  [a21aad5e084e3901a1e216ef9006b0f8b6132c39]

        tdf#153341: try to parse alpha value when copying HTML text
        
        Change-Id: Ic7240358be19e73f3c3f021e0de9414e3e988aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-04  Caolán McNamara  <caolanm@redhat.com>  [964486f514049de4dd77edbec3c090f5e84a3979]

        ofz#55620 Timeout
        
        Change-Id: I3d18e67a39523e508475b5f8586d92373be4f8b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146552
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-04  Caolán McNamara  <caolanm@redhat.com>  [462bbf692e41897552b4f4e1f9e4f033e5f76643]

        Resolves: tdf#153353 formula bar border area bg didn't change on theme change
        
        Change-Id: I720054d540a6352b8248aa59e231878c1832d998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-04  Aron Budea  <aron.budea@collabora.com>  [d4c99f07ed4a795519797f56be29c24a242f4db2]

        vcl: fix online crash in vcl::Window::IsTracking()
        
        Crashreport signature:
        
        program/libmergedlo.so
        	vcl::Window::IsTracking() const
        		vcl/source/window/window2.cxx:340
        program/libmergedlo.so
        	(anonymous namespace)::LOKPostAsyncEvent(void*, void*)
        		sfx2/source/view/lokhelper.cxx:812
        program/libmergedlo.so
        	LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double)
        		include/rtl/ref.hxx:128
        program/libmergedlo.so
        	SfxLokHelper::testInPlaceComponentMouseEventHit(SfxViewShell*, int, int, int, int, int, int, double, double, bool)
        		sfx2/source/view/lokhelper.cxx:980
        /program/libswlo.so
        	SwXTextDocument::postMouseEvent(int, int, int, int, int, int)
        		sw/source/uibase/uno/unotxdoc.cxx:3663
        program/libmergedlo.so
        	doc_postMouseEvent
        		desktop/source/lib/init.cxx:4831
        
        Change-Id: Iab7d24a901e57dc8af3fb2c77fbea3b4fdad9fb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146483
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146549
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb44dab0784476a2be0708e801696f47486aa3a2]

        fix online crash in WIndow::IsTracking
        
        /opt/collaboraoffice/program/libmergedlo.so
          vcl::Window::IsTracking() const
          /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/vcl/source/window/window2.cxx:340
        /opt/collaboraoffice/program/libmergedlo.so
          (anonymous namespace)::LOKPostAsyncEvent(void*, void*)
          /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/sfx2/source/view/lokhelper.cxx:812
        /opt/collaboraoffice/program/libmergedlo.so
          LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double)
          /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/include/rtl/ref.hxx:128
        
        Change-Id: I204bac7d8f595054abe9b6e8e631c02b26e20361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146231
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146548
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-02-03  Laurent Balland  <laurent.balland@mailo.fr>  [bbd487dc26c7e37982f64f6e6159c65ac77a89f1]

        tdf#153023 Disable Thousand separator for NatNum12
        
        Add some helper to get NatNum12 state
        Modify both Number format dialog and Sidebar
        Transform CAT_ defines in enum
        
        Change-Id: Iaa3127bf07223caac60e409306a1bee2edc37428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145513
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-02-03  Colomban Wendling  <cwendling@hypra.fr>  [fb42b73d50eb3856a96c8c6f269e37d9da2181f2]

        test/a11y: Remove declaration for undefined method
        
        getStateName() has been removed and superseded by
        debugAccessibleStateSet() in 8d8e6c84e512c1a8b33aac75965b84481d1a1d13
        but its declaration was still there.
        
        Change-Id: I3c7a9dc74b7230cde2fc61a86ca7659e35ba2bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [274587f634e57b59b34f352409453b394064cadd]

        Avoid UB
        
        as seen in https://ci.libreoffice.org/job/lo_ubsan/2671/ after commit
        333183d9a72d1e2b7ae65145092efec5e357ad14 ("tdf#153304: Add undo entries
        and set modified in SwXFrame::setProperty*", 2023-02-02):
        
          [_RUN_____] testImagePropsCreateUndoAndModifyDoc::TestBody
          warn:sal.file:4195:4195:sal/osl/unx/file_misc.cxx:401: Invalid directory URL
          warn:basic:4195:4195:basic/source/uno/namecont.cxx:953: Cannot access extensions!
          warn:sal.file:4195:4195:sal/osl/unx/file_misc.cxx:401: Invalid directory URL
          warn:basic:4195:4195:basic/source/uno/namecont.cxx:953: Cannot access extensions!
          warn:legacy.osl:4195:4195:sw/source/core/text/porfly.cxx:198: CalcFlyPos: Not Found!
          warn:legacy.osl:4195:4195:sw/source/core/text/txtfrm.cxx:3092: Prepare: Why me?
          /include/o3tl/strong_int.hxx:143:40: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
              #0 0x7f79b14fee7a in o3tl::strong_int<int, Tag_TextFrameIndex> o3tl::operator+<int, Tag_TextFrameIndex>(o3tl::strong_int<int, Tag_TextFrameIndex> const&, o3tl::strong_int<int, Tag_TextFrameIndex> const&) /include/o3tl/strong_int.hxx:143:40
              #1 0x7f79b553f7a5 in SwTextFrame::IsIdxInside(o3tl::strong_int<int, Tag_TextFrameIndex>, o3tl::strong_int<int, Tag_TextFrameIndex>) const /sw/source/core/text/txtfrm.cxx:1665:71
              #2 0x7f79b559be6a in SwTextFrame::InvalidateRange(SwCharRange const&, long) /sw/source/core/text/txtfrm.cxx:1689:10
              #3 0x7f79b5566a79 in SwTextFrame::Prepare(PrepareHint, void const*, bool) /sw/source/core/text/txtfrm.cxx:3093:17
              #4 0x7f79b438c1b5 in SwFlyInContentFrame::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/flyincnt.cxx:137:28
              #5 0x7f79b17c06e2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:322:18
              #6 0x7f79b17c09e5 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:327:15
              #7 0x7f79b17be1ef in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:313:5
              #8 0x7f79b1801e06 in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:314:19
              #9 0x7f79b414fa7c in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2713:15
              #10 0x7f79b17c0f13 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:336:13
              #11 0x7f79b18090b5 in SwFormat::SetFormatAttr(SfxPoolItem const&) /sw/source/core/attr/format.cxx:520:13
              #12 0x7f79b23c2e54 in SwDoc::SetFlyFrameAnchor(SwFrameFormat&, SfxItemSet&, bool) /sw/source/core/doc/docfly.cxx:326:13
              #13 0x7f79b23cac22 in lcl_SetFlyFrameAttr(SwDoc&, signed char (SwDoc::*)(SwFrameFormat&, SfxItemSet&, bool), SwFrameFormat&, SfxItemSet&) /sw/source/core/doc/docfly.cxx:451:17
              #14 0x7f79b23ca43d in SwDoc::SetFlyFrameAttr(SwFrameFormat&, SfxItemSet&) /sw/source/core/doc/docfly.cxx:560:23
              #15 0x7f79b64818d2 in SwXFrame::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) /sw/source/core/unocore/unoframe.cxx:1921:36
              #16 0x7f79d562de12 in testImagePropsCreateUndoAndModifyDoc::TestBody() /sw/qa/core/undo/undo.cxx:136:13
                  ...
        
        See https://gerrit.libreoffice.org/c/core/+/146484/7#message-8ce5de47f17cc701fc58b932e80b1de8469053bf
        Hope it makes sense.
        
        Change-Id: Id5c86ed4c093993557a24e00b3288ccdfa4de2ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146542
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-03  Stephan Bergmann  <sbergman@redhat.com>  [17cf2c278d9545dd6c9a9f132e52eae0ae482279]

        Fix misuse of TagDecl::hasDefinition
        
        ...that started to cause false
        
        > In file included from svl/source/items/itemiter.cxx:20:
        > include/svl/itemiter.hxx:25:1: error: SfxPoolItem subclass SfxPoolItem declares new fields, but does not override operator== [loplugin:sfxpoolitem]
        > class SfxPoolItem;
        > ^~~~~~~~~~~~~~~~~
        
        etc. now as a side effect of
        <https://github.com/llvm/llvm-project/commit/b6121432da79c4b3d21f191864ff6c583e2e62eb>
        "[C++20] Fix a crash with modules."
        
        Change-Id: Ibbf7a7c840ecea2605d6ea76afd04a2c2720e54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146544
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-03  Stephan Bergmann  <sbergman@redhat.com>  [5e0748d5bc12f789f9228d514294f8dcb0484b09]

        Avoid clang-cl -Werror,-Wparentheses
        
        (assuming 9274d41bd72c5310491d81c6d8d938e44ed9d223 "tdf#148085 get a more
        readable hyperlink color under windows dark mode" didn't introduce a = vs. ==
        typo)
        
        Change-Id: Ifd72029836726a804bcb0e3b5441aa7943705a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146543
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-03  Henry Castro  <hcastro@collabora.com>  [967c56f7d4c46240a37b2d4dd0a2f577b621f75d]

        lok: fix query language status
        
        The Calc and Impress return language status
        as a SfxStringItem, but Writer is a SfxListStringItem.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I88f77288e422a8f80473f0e33257078cfaa704b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145675
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146479
        Tested-by: Jenkins

2023-02-03  Henry Castro  <hcastro@collabora.com>  [f74031d4eaeb289f062f77209da10d464c09c2a6]

        lok: add function getDocLanguages
        
        If the spell checker is disabled to use a remote
        spelling feature, the getLanguages function is obsolete.
        
        In order to not break stable functions, introduce the
        getDocLanguages for the remote spelling feature.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ic210f31eddd3208b29d073ff35ba4fa2d98ea772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145363
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit bb0c63cc73998a0f67ae4c3e59acea3827a6e11c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146399
        Tested-by: Jenkins

2023-02-03  Julien Nabet  <serval2412@yahoo.fr>  [52ebc632b3cfa122dcb178cf28d8dbc7c7c57007]

        Related tdf#153272: add some missing properties in SwSearchProperties
        
        RES_PARATR_ORPHANS
        RES_PARATR_WIDOWS
        
        Change-Id: Ied760289e1ef8d60602991e5cdc0c743a31fd236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146435
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f29c8ae9943668f8890459301373a0f183ea264]

        Fix typo
        
        Change-Id: I4b12b8a82ef88947e3ed27298dbbd3305a60717c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146541
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d4b3b96359c3fcbe23073333149edee799b34837]

        Fix typo
        
        Change-Id: I48064f95fec07b414bd2addf0d65e2066aa1b42b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146540
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6836776fa295293c114c267bca38d18603993a54]

        tdf#56696 - Sort recent document list according to current LibO module
        
        Change-Id: I246dc9538e011b8981bea04963995559d2b43cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146456
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-02-03  Miklos Vajna  <vmiklos@collabora.com>  [8855813f8147f430348a32703b89dfb7b0793fee]

        sw: avoid unwanted initial content in split/follow fly frames
        
        If the fly on the first gets split, SwFrame::GetNextFlyLeaf() will
        create a follow fly frame. Don't fill this one with content, we'll
        instead want to move some of the content of the master here. (Which is
        not yet working.)
        
        InsertCnt() is called *really* early, so we can't check if this frame
        has a master -- just pass a bool around instead.
        
        This fixes the unwanted first paragraph in the follow fly frame at
        least. (The one that fits the master already.)
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: If364fdaf7595fbc5addbc6b3b3b0092e958c5380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146539
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [bcf9e47791d5b3e1d6a75c73f3b8c9940abda8eb]

        tdf#153078: Revert "tdf#141684 fix disappearance of icons in Groupedbar and Groupedbar compact UI"
        
        This reverts commit 801e6272dc299d4468ec094ce11b66494eb5018b.
        
        Revert it for now, until a better solution for tdf#141684
        is found
        
        Change-Id: I6c9fd7fb12149b67fe572d64cf00e6a3ec98611f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146504
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-02-03  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [c544f9ea78eab46c4f5230273a5a8571b28ea84d]

        Use raw string literal in opencl to keep PMD static analyser happy
        
        Change-Id: Ibf2bd12b79c6e7c7eae59fc516e75c1bda971a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146502
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-02-03  Miklos Vajna  <vmiklos@collabora.com>  [2422e1b0418d057e08ef08251e8638d1478631fe]

        sw layout xml dump: extract SwTable::dumpAsXml() from SwTableNode
        
        The idea is that each class only dumps itself & what it owns, otherwise
        the same info is dumped multiple times.
        
        Change-Id: Ib21bd2d31aa0d70d58b2b8aa453e0ede788c7144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146511
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-03  Regina Henschel  <rb.henschel@t-online.de>  [a834bbad8295cba0ca88a91a524aad48640271ec]

        tdf#153246 VML export write adj attribute for Fontwork
        
        The fix for tdf#153296 has introduced correct shapetype markup for
        Fontwork shapes so that handles are moveable in Word. But the actual
        adjustment value of the handle was not exported. This patch adds the
        missing 'adj' attribute to the <v:shape> element.
        The fix is restricted to the preset Fontwork types because for other
        shapetypes the VML export is not yet suitable in regard to handles.
        
        Change-Id: I7ecda9e63d50ab7d8c1fda3e09f7383546ddaf5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146537
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-02-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f2a2dab47dfae5c0c0bd68132e1446d571767eb8]

        capture output of package command and add to log on error
        
        creating packages failed here and the logs aren't all that helpful
        without the output of the command that failed.
        Reason it failed was that macOS thought that a volume with the same name
        was already mounted (but that didn't show up in Finder). With the output
        of the command easy to solve by just rebooting to fix that bogus state,
        but with only "command failed" you question what is different about that
        specific language, why would packaging that single language fail, …
        
        Change-Id: I1f46263f9ec9c9374da5afaa58f6c9939b6a1488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145239
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-02-02  Stephan Bergmann  <sbergman@redhat.com>  [2c961e4dc2290bb726d42047205623bcd102f046]

        Update the reference rdbs to libreoffice-7.5.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.5.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.5.0.3/instdir/program/types.rdb \
         .../libreoffice-7.5.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        * plus manual fixup by re-applying offapi/type_reference/offapi.idl part of
          b706b04110d9305b319689a5577746fac3e0e4c3 "[API CHANGE] offapi: clean up these
          index services IDL files"
        
        Change-Id: I5ac92f36f3952d335822c487d81efd3e9f38cd8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146510
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-02  Stephan Bergmann  <sbergman@redhat.com>  [537a8de72b935a406e6154a8cc55040ed521741e]

        Remove redundant attributes that were added to published XLinguProperties
        
        ...by 57d79744c77eef96b4c2bd3b16e0a04317ffcf9e "tdf#136306 offapi linguistic:
        add options to disable rule-based compounding".  See
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089784.html>
        "Re: Request for [API CHANGE] in spell checking: add new options to disable
        rule-based compounding" for details.  (And I want to get
        offapi/type_reference/offapi.idl back into a clean state before updating the
        reference rdbs, which I want to do now that LO 7.5.0 has been released, so I'm
        taking over here.)
        
        Change-Id: I75d0ccdfdf644421e22c95de5db3267e8872a09d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146505
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-02  Stephan Bergmann  <sbergman@redhat.com>  [09c3a0aa13e7c4719a73728c2f9ba1f66cea7572]

        A better fix for the stale TreeListEntryUIObject issue
        
        ...that hits UITest_writer_tests7
        UITEST_TEST_NAME=tdf135938.tdf135938.test_tdf135938_cross_reference_update as
        discussed in the commit message of 51a2e1a3963aae3228c9ddf78d0039c7c063393c "Let
        executeAction always ProcessEventsToIdle".  And while that ProcessEventsToIdle
        may be a general UITest stability improvement, it turned out that it did not
        actually fix this test_tdf135938_cross_reference_update issue, which I still
        kept seeing occasionally with my local ASan/UBSan build.  On closer inspection,
        it was the m_aUpdateTimer timer used by SwChildWinWrapper causing the issue,
        whose expiration is not forced by the added ProcessEventsToIdle.  So lets add a
        hacky sleep to the Python test code, to hopefully make sure that the timer has
        expired, and any SvTreeListEntries are stable, by the time the Python code
        initiates the creation of any TreeListEntryUIObjects that reference those
        SvTreeListEntries.
        
        Change-Id: I9f3c7293d55dffdc910879142d471a299f60a8e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146508
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-02  Michael Stahl  <michael.stahl@allotropia.de>  [fa1f2b7f5c65d66eaa5887acc9da5eb526570b18]

        tdf#130782 tdf#153203 writerfilter,sw: DOCX import/export of a11y
        
        ... related attributes name/title/description on Chart embedded objects.
        
        DomainMapper first needs to apply the properties to an SdrOLE2Obj, then
        later copy it to SwXEmbeddedObject.
        
        Change-Id: Id766be1eedf348caf22640ab6c177d81a0971749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146494
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-02  Regina Henschel  <rb.henschel@t-online.de>  [2598f40521c6a8dee6d59ca41c3e58e65a98b17f]

        tdf#153258 VML import improve WordArt detection
        
        There exists WordArt types whose internal name do not start with
        'fontwork', e.g. mso_sptTextDeflateInflateDeflate has 'mso-spt167'.
        The fix uses the MSO_SPT enum directly.
        
        Change-Id: Idb32b3ef9957bef5d948e1d86507d71fef006e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146503
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [333183d9a72d1e2b7ae65145092efec5e357ad14]

        tdf#153304: Add undo entries and set modified in SwXFrame::setProperty*
        
        Similar to SwDoc::SetFlyFrameAttr; the latter should only set modified
        state on actual changes.
        
        Change-Id: I66982e68fa9132fda132d811f7a48b4461645df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146484
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [8db390be9b2280c05f2c8943fc80be07aa8df811]

        use mnemonic-widget instead of label-for+labelled-by
        
        then the a11y relation is implied without the need for explicit
        extra annotation
        
        use more standard spacing values and spacing pattern too
        
        Change-Id: Ifeea7fbe89bc093aac1b9f16e49b80bfa6a9af9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146493
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [7b0606b6c0449c5f3f266295f7a5521fe6a05493]

        Related: tdf#152642 match spacing and layout of other option pages
        
        Change-Id: I289303ec071e4bc48388ab34f5327b7648121338
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146491
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Tor Lillqvist  <tml@collabora.com>  [6f6b879e8ddc689b5ffc245d641963557e3f3bca]

        Add instructions for when building headless LO core for WASM
        
        Change-Id: Ic5fb943f8c26d21d94bafb815963960bdd2f26b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146497
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [debd4cfa377f6895ecfe337216240bb7c581e84a]

        add missing mnemonic-widget
        
        Change-Id: Ib0b53fe8fed8ca1d53b7691a8609ce1e14bcce89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [48cd8c6ba8ea5bae7f5fce481f9c01bc4aa92dce]

        match spacing and layout of other option pages
        
        Change-Id: I18c398762f92a28d72dae3ae76991553e9ebb04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146489
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Miklos Vajna  <vmiklos@collabora.com>  [4c6c317e1743166ee772ab03413f0fa59c59f859]

        sw: call GetNextFlyLeaf() in SwFrame::GetLeaf()
        
        - improve SwFrame::GetLeaf() so that in case we are in a fly frame and
          that is allowed to split, then we call GetNextFlyLeaf()
        
        - GetNextFlyLeaf() uses GetNextLayoutLeaf(), if that finds nothing then
          calls InsertPage() and then tries again. The second
          GetNextLayoutLeaf() is meant to find the follow frame's parent, but fly
          frames don't in general have uppers, so teach it about split fly frames
        
        - finally improve SwFrame::GetNextFlyLeaf() a bit, so that it does fly
          insertion similar to AppendObj(): first move the anchor to the next
          page then append the just created fly there
        
        With this, a fly frame with 2 paragraphs crossing the bottom of the body
        frame is split, although the second fly frame contains both paragraphs,
        which still needs fixing.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: Iec038e9fed462b1f8ee0b48fbb3fd76641c96d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146485
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9f698ac2d8d4db274793678efdfbcdde15347e31]

        Fix interchanged strings for macros disabled
        
        Change-Id: Ie53b455506a55cf07ecade84f484c3f4c1925f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146487
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [d92530e4e0d9960f1ab4322297fadadfc9d0d41b]

        resave with latest glade
        
        Change-Id: I747aabe874474151b52127840cf6235448c82a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146482
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [5761443d0e63c22a3c397fe6a1dacb3b28b7615d]

        use more standard spacing values and pattern
        
        Change-Id: I6e7b0f442c8551c1c989473f892c41dde7b55565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [7d14d475b25aeb28ad7956e5c45b9e120a442b44]

        resave with latest glade
        
        Change-Id: If8035f18e676e19ba9053accf8997a3fe297a4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [f32a2b4e63277e74cda200b5778e2eb9b8c34183]

        use mnemonic-widget instead of label-for+labelled-by
        
        then the a11y relation is implied without the need for explicit
        extra annotation, and there is a mnemonic auto generated.
        
        use more standard spacing values and spacing pattern too
        
        Change-Id: I87b4ceb74a09b0203ffcd70196ffab50a7820354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [1fe3769060f31e66a63f4f5fdc5bbfb916c449f6]

        gtk4: remove max-length property
        
        width-chars remains
        
        Change-Id: Ifef71355b12c797bafe67b5e58316a182b63eceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146477
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [b7f182217606b6b51de4c081acf1671c104094cb]

        leader of group should default to active
        
        Change-Id: I1c49b227e63f01ffdd1c3b427ef780ea38a6d1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Caolán McNamara  <caolanm@redhat.com>  [2f1c6b8aab6976208ca755a707a1915a60c15353]

        add truncate-multiline for consistency
        
        Change-Id: I62de1820479f658076621ec0a62df967055adc4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2d5e0e038f4e04ff7aa330e72d7358d5335a6f3a]

        Add missing macro infobar to isInfobarEnabled
        
        Change-Id: I7b9ddc0adfed2b7c27150d2d126f83e6a5ecf19d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146360
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [dccc056490a3d62e2a906a33862b09047ade925e]

        osl::Mutex->std::mutex in SystemQueueInfo
        
        Change-Id: I4d81cee0c9bd02010399fc6670e1391b7acd50be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Miklos Vajna  <vmiklos@collabora.com>  [94c670f030fc63afe84ecfdfffc75d4764218754]

        sw, FN_UPDATE_TEXT_FORMFIELD: remove unused StateMethod
        
        This was added in 337416dafb66ed8f930d2d69e83fae438fc85f3c (sw: add a
        new .uno:UpdateTextFormField UNO command, 2023-01-06), but only
        SwTextShell::ExecField() handles FN_UPDATE_TEXT_FORMFIELD, so the
        StateMethod is not needed.
        
        Change-Id: I237f82f7f3b5efa7e619576880d973d144c77b25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146474
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-02  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4fa56b89cd1d306068a7ec8298b7ba1869e612a9]

        Own title for macro infobars
        
        Change-Id: If6ac6bb2379dfdc6080c768103e3d174c7bdc59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146355
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [58738b92255a2508d28c89088658fd21807e5826]

        osl::Mutex->std::mutex in JavaComponentLoader::getJavaLoader
        
        Change-Id: Iecde82fcd1c637d4447b2bca491308a2becc38cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146467
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [02950f16926564317cee90dffd8cda526bf096f2]

        osl::Mutex->std::mutex in ConfigurationAccess_UICategory
        
        Change-Id: I55da051ad9368920224f2c762c9f95b3ea85098a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [17523906a875f84e3c435127700bcd9ae932997b]

        osl::Mutex->std::mutex in configmgr::read_write_access::Service
        
        Change-Id: Ic8f688d3ad66c1be33a147e05b0e9145593214f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146471
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [90ff8cc432fd043ed662d478f7ace49438d00ff3]

        osl::Mutex->std::mutex in configmgr::read_only_access::Service
        
        Change-Id: Ia92bb76cedb45d2c28482d34869e239cfdd32ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146470
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [63b4126116ee0c92f8dbf2b54a2afacf8eed74cf]

        osl::Mutex->std::mutex in sd::RandomAnimationNode
        
        Change-Id: Idebeff57bc5149a3b6ea43fdac0ccafe4a8597dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146468
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5233bc74ea6c66795b5e5299e6ce554de877ef8a]

        osl::Mutex->std::mutex in JniUnoEnvironmentData
        
        Change-Id: Iab6d430af7afc0d21e118b05d64a15664fc2f677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146469
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8d2a9ffc0d96418dbec94cdbba14aac1c09adf5]

        osl::Mutex->std::mutex in ConfigurationAccess_WindowState
        
        Change-Id: I399bb434da3e2c92c6df64dd6048121ad030bfb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-01  Aron Budea  <aron.budea@collabora.com>  [b2bd60b8c1937502857e12b0eea42323fd2353c8]

        sfx2: fix crash in SfxLokHelper::notifyAllViews(...)
        
        Crashreport signature:
        
        program/libmergedlo.so
        	SfxLokHelper::notifyAllViews(int, rtl::OString const&)
        		sfx2/source/view/lokhelper.cxx:682
        program/libmergedlo.so
        	SfxClipboardChangeListener::ChangedContents()
        		include/rtl/string.hxx:413
        program/libmergedlo.so
        	SfxClipboardChangeListener::LinkStubAsyncExecuteHdl_Impl(void*, void*)
        		include/rtl/ref.hxx:128
        program/libmergedlo.so
        	ImplWindowFrameProc(vcl::Window*, SalEvent, void const*)
        		include/rtl/ref.hxx:128
        program/libmergedlo.so
        	SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent)
        
        Change-Id: Ibf70f42292d67a3d6cc68f579ee02f671da85acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146150
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit dc17158c99c8a15fbca57a9a0b0ea7178dcc5a34)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146400
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-02-01  Henry Castro  <hcastro@collabora.com>  [56cb2b78dbd355c74d3454721b8d37ad24292f85]

        lok: disable spell if remote language tool enabled
        
        .
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I73158c3feaa84af4d713d3f1b1fc9a60dcf95463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144785
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145601
        Tested-by: Jenkins

2023-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [05472ebc3fd9c89080cfb28c26951164139b632a]

        UITest_textToColumns: fix indent and simplify code
        
        The wrong indent made those tests not to be executed
        OTOH, do not change the option replwarncb so it's
        enabled by default. This tests are not about testing that
        
        Change-Id: Ib73305f43dd8285f1042f9e399efb034d872d895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146462
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [0eaad910442a1bbb0c6a89a8887322ea3d6906e0]

        Resolves: tdf#152845 AutoText preview not readable in high contrast mode
        
        if its a high contrast mode with white text on black background.  Reuse
        isOutputToWindow to distinguish between the case we are outputting to
        screen but not using a vcl::Window (and want to use the appropiate color
        for autocolor) vs the cases we are printing or exporting to pdf and not
        using a vcl::Window where the color should be black.
        
        Change-Id: Ib688892a6315fe88ba585613539088611d3995ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145234
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [9274d41bd72c5310491d81c6d8d938e44ed9d223]

        tdf#148085 get a more readable hyperlink color under windows dark mode
        
        Change-Id: I392206eb9fcff7fca39c6efee747486f4dfa925e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  László Németh  <nemeth@numbertext.org>  [2780b026f912a103aea3f8dc19319b998d19a43a]

        tdf#152738 sw: fix lost SwPosition in spelling dialog
        
        Which resulted broken spell checking.
        
        Regression from commit b484e5d9e0d22b794c2d1c73741191836158a4ad
        "use more SwPosition::Assign".
        
        Change-Id: I7be215f629ed73a3009f8358172ee3a7e2e72ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146465
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-02-01  anfanite396  <dipamt1729@gmail.com>  [31605a4f46cbe5a231122da9bfb07c859522ec3d]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I49ee5a87b2a0fb093095de74ab039ebdd91762fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146461
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-01  Regina Henschel  <rb.henschel@t-online.de>  [b1fda9b2c4986ad44245020b98ddcc2e81c299bf]

        tdf#153296 improved markup for VML shapetype of Fontwork
        
        In the current version of 'vml-shape-types' file the markup for the
        Fontwork shapes is missing or is so, that Word does not accept it as
        WordArt markup. So Word treats it as custom geometry and saves it that
        way. But LO cannot import custom geometry for WordArt.
        
        The patch changes it so, that for Fontwork shapes a dedicated markup
        map is used with markup, that Word accepts as WordArt. Non-Fontwork
        shapes still use the 'vml-shape-types' file for VML export.
        
        I have added two unit tests. But a true test is not possible, because
        for that you would need to open and save the files with MS Word.
        
        This patch solves at the same time some of the handle problems for the
        special case of Fontwork shapes, see tdf#152913.
        
        Change-Id: Icc5afb88c58b644d25b3cf8d415e5aa2d6a7b19e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146311
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-02-01  Noel Grandin  <noelgrandin@collabora.co.uk>  [7c035ff67993707cfd09c575a97028dab9683557]

        osl::Mutex->std::mutex in ExceptionInfos
        
        Change-Id: Ic947b58b9aba121c605b6795c7cd9aa0b16b180e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-01  Stephan Bergmann  <sbergman@redhat.com>  [2798430c8a711861fdcdfbf9ac00a0527abd3bfc]

        Mark the uses of TreeListEntryUIObject as dubious
        
        See the commit message of 51a2e1a3963aae3228c9ddf78d0039c7c063393c "Let
        executeAction always ProcessEventsToIdle" for details.
        
        Change-Id: I25fa825c059f8e8e58018f5487557d0ffcee6aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146454
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [db4690fa7a7365effab47f454283d1b860bd72a9]

        fix invalid cast from 'GtkImage' to 'GtkLabel'
        
        since:
        
        commit 660b7ed484efcac1e5b841e0b04f3c9628578448
        Date:   Fri Jan 6 11:08:36 2023 +0100
        
            Resolves tdf#101731 - Rename Border/Midpoint
        
        Change-Id: Ie226e768ce902a8fff30f2883e0ea22b94e96949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [acee80fc5612fa8aad5f7f9c80273bba27bb3219]

        add missing id-column
        
        Change-Id: Ia6b1a4daa2a3327faa33d60289c4dd4c12deefbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146441
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1d88f59103d931aa680cd77690b83e773771729c]

        schema: properly extend office-styles instead of style-style "hack"
        
        With the 32a8095eb2c22f7de4bce14f1b5c08dc701deaea I extended the
        schema in an odd way, which worked by luck. This change fixes this
        by properly extending the loext schema in a conventional way.
        
        Change-Id: I4229145dc2a6ce2f0d5d115b3972121ed2379b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146453
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [6652768ef832f4e1555a01a2962c087fa8937e30]

        crashtesting: threaded import crash seen in forum-mso-en4-802501.xlsx
        
        sporadically reproducible with tsan and
        ./instdir/program/soffice.bin --headless --convert-to pdf ~/forum-mso-en4-802501.xlsx
        
        move getTables().applyAutoFilters(), which wants to query tab 1 while
        tab 1 is still getting imported, until after the threaded import has
        completed.
        
        This call was moved before in:
        
        commit edd51b813005c2159426d8f2917eede5b14a4577
        Date:   Thu Aug 15 16:23:46 2013 +0100
        
            fix for bnc#834705 missing drop downs for autofilter
        
        ==================
        WARNING: ThreadSanitizer: data race (pid=3791886)
          Read of size 8 at 0x7b5000040f20 by thread T7 (mutexes: write M0, write M1):
            #0 __gnu_cxx::__normal_iterator<unsigned long const*, std::vector<unsigned long, std::allocator<unsigned long>>>::__normal_iterator(unsigned long const* const&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_iterator.h:1073:20 (libsclo.so+0x3d31c4) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #1 std::vector<unsigned long, std::allocator<unsigned long>>::cend() const /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_vector.h:960:16 (libsclo.so+0x3d31c4)
            #2 mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::cbegin() const core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:3771:34 (libsclo.so+0x3d31c4)
            #3 mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::begin() const core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:3753:12 (libsclo.so+0x3d31c4)
            #4 ScColumn::InitBlockPosition(sc::ColumnBlockConstPosition&) const core/sc/source/core/data/column3.cxx:1135:35 (libsclo.so+0x3d31c4)
            #5 ScTable::GetDataArea(short&, int&, short&, int&, bool, bool) const core/sc/source/core/data/table1.cxx:908:19 (libsclo.so+0x637b39) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #6 ScDocument::GetDataArea(short, short&, int&, short&, int&, bool, bool) const core/sc/source/core/data/document.cxx:1104:23 (libsclo.so+0x49b696) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #7 ScDBData::ExtendDataArea(ScDocument const&) core/sc/source/core/tool/dbdata.cxx:654:10 (libsclo.so+0x741e77) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #8 ScDocument::GetFilterEntries(short, int, short, ScFilterEntries&) core/sc/source/core/data/documen3.cxx:1577:14 (libsclo.so+0x46e7a6) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #9 (anonymous namespace)::fillQueryParam(ScQueryParam&, ScDocument*, com::sun::star::uno::Sequence<com::sun::star::sheet::TableFilterField3> const&) core/sc/source/ui/unoobj/datauno.cxx:1164:27 (libsclo.so+0xf7dd72) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #10 ScFilterDescriptorBase::setFilterFields3(com::sun::star::uno::Sequence<com::sun::star::sheet::TableFilterField3> const&) core/sc/source/ui/unoobj/datauno.cxx:1380:5 (libsclo.so+0xf7dd72)
            #11 non-virtual thunk to ScFilterDescriptorBase::setFilterFields3(com::sun::star::uno::Sequence<com::sun::star::sheet::TableFilterField3> const&) core/sc/source/ui/unoobj/datauno.cxx (libsclo.so+0xf7e2c2) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #12 oox::xls::AutoFilter::finalizeImport(com::sun::star::uno::Reference<com::sun::star::sheet::XDatabaseRange> const&, short) core/sc/source/filter/oox/autofilterbuffer.cxx:803:22 (libscfiltlo.so+0x3cca2c) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #13 oox::xls::AutoFilterBuffer::finalizeImport(com::sun::star::uno::Reference<com::sun::star::sheet::XDatabaseRange> const&, short) core/sc/source/filter/oox/autofilterbuffer.cxx:950:22 (libscfiltlo.so+0x3cdc0b) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #14 oox::xls::Table::applyAutoFilters() core/sc/source/filter/oox/tablebuffer.cxx:143:23 (libscfiltlo.so+0x4b9268) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #15 void std::__invoke_impl<void, void (oox::xls::Table::*&)(), oox::xls::Table&>(std::__invoke_memfun_ref, void (oox::xls::Table::*&)(), oox::xls::Table&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/invoke.h:67:14 (libscfiltlo.so+0x4b9d96) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #16 std::__invoke_result<void (oox::xls::Table::*&)(), oox::xls::Table&>::type std::__invoke<void (oox::xls::Table::*&)(), oox::xls::Table&>(void (oox::xls::Table::*&)(), oox::xls::Table&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/invoke.h:96:14 (libscfiltlo.so+0x4b9d96)
            #17 void std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>::__call<void, oox::xls::Table&, 0ul>(std::tuple<oox::xls::Table&>&&, std::_Index_tuple<0ul>) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/functional:495:11 (libscfiltlo.so+0x4b9d96)
            #18 void std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>::operator()<oox::xls::Table&, void>(oox::xls::Table&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/functional:580:17 (libscfiltlo.so+0x4b9d96)
            #19 oox::RefMap<int, oox::xls::Table, std::less<int>>::ForEachFunctor<std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>>::operator()(std::pair<int const, std::shared_ptr<oox::xls::Table>> const&) core/include/oox/helper/refmap.hxx:122:89 (libscfiltlo.so+0x4b9d96)
            #20 oox::RefMap<int, oox::xls::Table, std::less<int>>::ForEachFunctor<std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>> std::for_each<std::_Rb_tree_const_iterator<std::pair<int const, std::shared_ptr<oox::xls::Table>>>, oox::RefMap<int, oox::xls::Table, std::less<int>>::ForEachFunctor<std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>>>(std::_Rb_tree_const_iterator<std::pair<int const, std::shared_ptr<oox::xls::Table>>>, std::_Rb_tree_const_iterator<std::pair<int const, std::shared_ptr<oox::xls::Table>>>, oox::RefMap<int, oox::xls::Table, std::less<int>>::ForEachFunctor<std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>>) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_algo.h:3787:2 (libscfiltlo.so+0x4b9d96)
            #21 void oox::RefMap<int, oox::xls::Table, std::less<int>>::forEach<std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()>>(std::_Bind<void (oox::xls::Table::* (std::_Placeholder<1>))()> const&) const core/include/oox/helper/refmap.hxx:71:29 (libscfiltlo.so+0x4b9d96)
            #22 void oox::RefMap<int, oox::xls::Table, std::less<int>>::forEachMem<void (oox::xls::Table::*)()>(void (oox::xls::Table::*)()) const core/include/oox/helper/refmap.hxx:79:29 (libscfiltlo.so+0x4b9d96)
            #23 oox::xls::TableBuffer::applyAutoFilters() core/sc/source/filter/oox/tablebuffer.cxx:179:16 (libscfiltlo.so+0x4b9d96)
            #24 oox::xls::WorksheetGlobals::finalizeWorksheetImport() core/sc/source/filter/oox/worksheethelper.cxx:943:17 (libscfiltlo.so+0x4ee58e) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #25 oox::xls::WorksheetHelper::finalizeWorksheetImport() core/sc/source/filter/oox/worksheethelper.cxx:1625:17 (libscfiltlo.so+0x4f2cff) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #26 oox::xls::WorksheetFragment::finalizeImport() core/sc/source/filter/oox/worksheetfragment.cxx:632:5 (libscfiltlo.so+0x4e91cc) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #27 oox::core::FragmentHandler2::endDocument() core/oox/source/core/fragmenthandler2.cxx:53:5 (libooxlo.so+0x1c20d9) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #28 non-virtual thunk to oox::core::FragmentHandler2::endDocument() core/oox/source/core/fragmenthandler2.cxx (libooxlo.so+0x1c20d9)
            #29 sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) core/sax/source/fastparser/fastparser.cxx:910:36 (libexpwraplo.so+0x2a06a) (BuildId: 4c8d8739ce3b93f891afa1e160f975a2892a4af4)
            #30 sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) core/sax/source/fastparser/fastparser.cxx:1482:13 (libexpwraplo.so+0x31738) (BuildId: 4c8d8739ce3b93f891afa1e160f975a2892a4af4)
            #31 oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) core/oox/source/core/fastparser.cxx:121:15 (libooxlo.so+0x1ae980) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #32 oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) core/oox/source/core/fastparser.cxx:129:5 (libooxlo.so+0x1aebdf) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #33 oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) core/oox/source/core/xmlfilterbase.cxx:412:21 (libooxlo.so+0x1d01ac) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #34 oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) core/sc/source/filter/oox/workbookhelper.cxx:1024:27 (libscfiltlo.so+0x4dbbd2) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #35 oox::xls::(anonymous namespace)::WorkerThread::doWork() core/sc/source/filter/oox/workbookfragment.cxx:249:27 (libscfiltlo.so+0x4d3347) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #36 comphelper::ThreadTask::exec() core/comphelper/source/misc/threadpool.cxx:319:9 (libcomphelper.so+0x17dbc1) (BuildId: 30a9bf106ea764f860a55d99b75dd87a0f268335)
            #37 comphelper::ThreadPool::ThreadWorker::execute() core/comphelper/source/misc/threadpool.cxx:85:24 (libcomphelper.so+0x17dbc1)
            #38 salhelper::Thread::run() core/salhelper/source/thread.cxx:39:5 (libuno_salhelpergcc3.so.3+0x5267) (BuildId: d146f721ac5d8da923b02df0d671788655b81eb6)
            #39 non-virtual thunk to salhelper::Thread::run() core/salhelper/source/thread.cxx (libuno_salhelpergcc3.so.3+0x5267)
            #40 threadFunc core/include/osl/thread.hxx:189:15 (libuno_salhelpergcc3.so.3+0x551e) (BuildId: d146f721ac5d8da923b02df0d671788655b81eb6)
            #41 osl_thread_start_Impl(void*) core/sal/osl/unx/thread.cxx:265:9 (libuno_sal.so.3+0x6a9d5) (BuildId: 767a6cd7c58bf820064a10cf0ab0f15b30c2f4ac)
        
          Previous write of size 8 at 0x7b5000040f20 by thread T6 (mutexes: write M2):
            #0 std::vector<unsigned long, std::allocator<unsigned long>>::_M_fill_insert(__gnu_cxx::__normal_iterator<unsigned long*, std::vector<unsigned long, std::allocator<unsigned long>>>, unsigned long, unsigned long const&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/vector.tcc:556:29 (libsclo.so+0x2f6766) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #1 std::vector<unsigned long, std::allocator<unsigned long>>::insert(__gnu_cxx::__normal_iterator<unsigned long const*, std::vector<unsigned long, std::allocator<unsigned long>>>, unsigned long, unsigned long const&) /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_vector.h:1435:2 (libsclo.so+0x2ffd3a) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #2 mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::blocks_type::insert(unsigned long, unsigned long) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:99:15 (libsclo.so+0x2ffd3a)
            #3 mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::set_new_block_to_middle(unsigned long, unsigned long, unsigned long, bool) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:4326:19 (libsclo.so+0x2ffd3a)
            #4 mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::iterator_trait> mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::set_cell_to_middle_of_block<double>(unsigned long, unsigned long, double const&) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:3999:19 (libsclo.so+0x3259fe) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #5 mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::iterator_trait> mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::set_cell_to_empty_block<double>(unsigned long, unsigned long, double const&) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:3313:12 (libsclo.so+0x3259fe)
            #6 mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::iterator_trait> mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::set_impl<double>(unsigned long, unsigned long, double const&) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:1260:16 (libsclo.so+0x32492f) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #7 mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::iterator_trait> mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::set<double>(mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell>>, sc::CellStoreTrait>::iterator_trait> const&, unsigned long, double const&) core/workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:754:20 (libsclo.so+0x4cc138) (BuildId: 4582437348063bd1c461478348ce37a0dbd28def)
            #8 ScDocumentImport::setNumericCell(ScAddress const&, double) core/sc/source/core/data/documentimport.cxx:259:35 (libsclo.so+0x4cc138)
            #9 oox::xls::SheetDataBuffer::setValueCell(oox::xls::CellModel const&, double) core/sc/source/filter/oox/sheetdatabuffer.cxx:107:20 (libscfiltlo.so+0x4833c0) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #10 oox::xls::SheetDataContext::onEndElement() core/sc/source/filter/oox/sheetdatacontext.cxx:185:25 (libscfiltlo.so+0x48fed2) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #11 non-virtual thunk to oox::xls::SheetDataContext::onEndElement() core/sc/source/filter/oox/sheetdatacontext.cxx (libscfiltlo.so+0x48fff9) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #12 oox::core::ContextHandler2Helper::implEndElement(int) core/oox/source/core/contexthandler2.cxx:125:9 (libooxlo.so+0x1ac82b) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #13 oox::core::ContextHandler2::endFastElement(int) core/oox/source/core/contexthandler2.cxx:220:5 (libooxlo.so+0x1ac82b)
            #14 non-virtual thunk to oox::core::ContextHandler2::endFastElement(int) core/oox/source/core/contexthandler2.cxx (libooxlo.so+0x1ac82b)
            #15 (anonymous namespace)::Entity::endElement() core/sax/source/fastparser/fastparser.cxx:515:27 (libexpwraplo.so+0x3042f) (BuildId: 4c8d8739ce3b93f891afa1e160f975a2892a4af4)
            #16 sax_fastparser::FastSaxParserImpl::consume((anonymous namespace)::EventList&) core/sax/source/fastparser/fastparser.cxx:1029:25 (libexpwraplo.so+0x29d37) (BuildId: 4c8d8739ce3b93f891afa1e160f975a2892a4af4)
            #17 sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) core/sax/source/fastparser/fastparser.cxx:869:22 (libexpwraplo.so+0x29d37)
            #18 sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) core/sax/source/fastparser/fastparser.cxx:1482:13 (libexpwraplo.so+0x31738) (BuildId: 4c8d8739ce3b93f891afa1e160f975a2892a4af4)
            #19 oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource const&, bool) core/oox/source/core/fastparser.cxx:121:15 (libooxlo.so+0x1ae980) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #20 oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, rtl::OUString const&) core/oox/source/core/fastparser.cxx:129:5 (libooxlo.so+0x1aebdf) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #21 oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) core/oox/source/core/xmlfilterbase.cxx:412:21 (libooxlo.so+0x1d01ac) (BuildId: eba40a8f6e1e986eafb2008b5a61a9060f9b6c0b)
            #22 oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler> const&, oox::core::FastParser&) core/sc/source/filter/oox/workbookhelper.cxx:1024:27 (libscfiltlo.so+0x4dbbd2) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #23 oox::xls::(anonymous namespace)::WorkerThread::doWork() core/sc/source/filter/oox/workbookfragment.cxx:249:27 (libscfiltlo.so+0x4d3347) (BuildId: 798032f9cb60957d86e47827d9e882b8931326ba)
            #24 comphelper::ThreadTask::exec() core/comphelper/source/misc/threadpool.cxx:319:9 (libcomphelper.so+0x17dbc1) (BuildId: 30a9bf106ea764f860a55d99b75dd87a0f268335)
            #25 comphelper::ThreadPool::ThreadWorker::execute() core/comphelper/source/misc/threadpool.cxx:85:24 (libcomphelper.so+0x17dbc1)
            #26 salhelper::Thread::run() core/salhelper/source/thread.cxx:39:5 (libuno_salhelpergcc3.so.3+0x5267) (BuildId: d146f721ac5d8da923b02df0d671788655b81eb6)
            #27 non-virtual thunk to salhelper::Thread::run() core/salhelper/source/thread.cxx (libuno_salhelpergcc3.so.3+0x5267)
            #28 threadFunc core/include/osl/thread.hxx:189:15 (libuno_salhelpergcc3.so.3+0x551e) (BuildId: d146f721ac5d8da923b02df0d671788655b81eb6)
            #29 osl_thread_start_Impl(void*) core/sal/osl/unx/thread.cxx:265:9 (libuno_sal.so.3+0x6a9d5) (BuildId: 767a6cd7c58bf820064a10cf0ab0f15b30c2f4ac)
        
        Change-Id: I7542432749fded8ab5e35f79cb221ad712f7802d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146430
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b68c5ed1ca7936d97c581f1a9fd3c07708bf3d6]

        sw: restructure tests a bit
        
        Follow-up to 3ac5bfec2f73c55e99c4410f7559db86b875a269
        "uitest: Always change doc info setting back to false"
        it seems it fails sometimes when using .uno:CloseDoc
        Seen in https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132728/consoleFull#-45932801048ce9c26-9d0a-43a8-83d8-c44f54920d59
        
        Change-Id: I384e40a31735738c622277ccdbdb75babb185d85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146448
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [d09996a0d66c51908103afef9c56679b891570d8]

        tdf#148952 sw: DOCX export: ECMA-376 1st ed does not allow title
        
        ... attribute, so fallback to merge the value with the description
        into the descr attribute.
        
        Change-Id: I4e83a67788d0c82dd762c075f06db358a7884675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146444
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [15974445d753141788e9f65a17edde1b7ea5c955]

        gtk[3|4] drop can-focus so it takes the default state
        
        Change-Id: Ifd39ee1d72e0592638e0f5d0ed4e1b6b2ea82a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146439
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [a5c1593d7001382d43ea548166aa303aef899993]

        add truncate-multiline for consistency
        
        Change-Id: I21263263ec9fc9d9e39e7b2ec32b54a7a75323a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146438
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Caolán McNamara  <caolanm@redhat.com>  [f9a6d9548270cf702fc5bfb392dec3f55819a835]

        reformat to the same indent as everything else
        
        git show -w is no change
        
        Change-Id: If9ed97301c6c6bb9a025bf61c747d0adf0a17762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146440
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-02-01  Stephan Bergmann  <sbergman@redhat.com>  [51a2e1a3963aae3228c9ddf78d0039c7c063393c]

        Let executeAction always ProcessEventsToIdle
        
        An ASan UITest_writer_tests7
        UITEST_TEST_NAME=tdf135938.tdf135938.test_tdf135938_cross_reference_update
        occasionally failed for me with
        
        > ==1994973==ERROR: AddressSanitizer: heap-use-after-free on address 0x60f00014d718 at pc 0x7f95f4946ffa bp 0x7f95907fd720 sp 0x7f95907fd718
        > READ of size 8 at 0x60f00014d718 thread T33
        >  #0 in std::__cxx1998::vector<std::unique_ptr<SvLBoxItem, std::default_delete<SvLBoxItem>>, std::allocator<std::unique_ptr<SvLBoxItem, std::default_delete<SvLBoxItem>>>>::size() const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_vector.h:988:40
        >  #1 in SvTreeListEntry::ItemCount() const at vcl/source/treelist/treelistentry.cxx:110:20
        >  #2 in SvTabListBox::GetEntryText(SvTreeListEntry const*, unsigned short) at vcl/source/treelist/svtabbx.cxx:289:37
        >  #3 in SvTabListBox::GetEntryText(SvTreeListEntry*) const at vcl/source/treelist/svtabbx.cxx:280:12
        >  #4 in TreeListEntryUIObject::get_state() at vcl/source/treelist/uiobject.cxx:119:32
        >  #5 in UIObjectUnoObj::getState() at vcl/source/uitest/uno/uiobject_uno.cxx:164:29
        >  #6 in non-virtual thunk to UIObjectUnoObj::getState() at vcl/source/uitest/uno/uiobject_uno.cxx
        >  #7 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
        >  #8 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
        >  #9 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
        >  #10 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny>>*) const at binaryurp/source/incomingrequest.cxx:236:13
        >  #11 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:79:26
        >  #12 in request at binaryurp/source/reader.cxx:86:9
        >  #13 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100:17
        >  #14 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:165:31
        >
        > 0x60f00014d718 is located 120 bytes inside of 168-byte region [0x60f00014d6a0,0x60f00014d748)
        > freed by thread T0 here:
        >  #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
        >  #1 in SvTreeListEntry::~SvTreeListEntry() at vcl/source/treelist/treelistentry.cxx:62:1
        >  #2 in std::default_delete<SvTreeListEntry>::operator()(SvTreeListEntry*) const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/unique_ptr.h:102:2
        >  #3 in std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>::~unique_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/unique_ptr.h:407:4
        >  #4 in void std::destroy_at<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_construct.h:88:15
        >  #5 in void std::_Destroy<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_construct.h:149:7
        >  #6 in void std::_Destroy_aux<false>::__destroy<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*>(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*, std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_construct.h:163:6
        >  #7 in void std::_Destroy<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*>(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*, std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_construct.h:195:7
        >  #8 in void std::_Destroy<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*, std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*, std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*, std::allocator<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/alloc_traits.h:947:7
        >  #9 in std::__cxx1998::vector<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>, std::allocator<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>>::_M_erase_at_end(std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_vector.h:1932:6
        >  #10 in std::__cxx1998::vector<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>, std::allocator<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>>::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/stl_vector.h:1601:9
        >  #11 in std::__debug::vector<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>, std::allocator<std::unique_ptr<SvTreeListEntry, std::default_delete<SvTreeListEntry>>>>::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/debug/vector:729:9
        >  #12 in SvTreeListEntry::ClearChildren() at vcl/source/treelist/treelistentry.cxx:28:16
        >  #13 in SvTreeList::Clear() at vcl/source/treelist/treelist.cxx:123:16
        >  #14 in SvTreeListBox::Clear() at vcl/source/treelist/treelistbox.cxx:422:17
        >  #15 in SalInstanceTreeView::clear() at vcl/source/app/salvtables.cxx:4240:18
        >  #16 in SwFieldRefPage::Reset(SfxItemSet const*) at sw/source/ui/fldui/fldref.cxx:175:16
        >  #17 in SwFieldPage::EditNewField(bool) at sw/source/ui/fldui/fldpage.cxx:111:5
        >  #18 in SwFieldDlg::ReInitTabPage(std::basic_string_view<char, std::char_traits<char>>, bool) at sw/source/ui/fldui/fldtdlg.cxx:218:16
        >  #19 in SwFieldDlg::Activate() at sw/source/ui/fldui/fldtdlg.cxx:239:9
        >  #20 in SwChildWinWrapper::UpdateHdl(Timer*) at sw/source/uibase/fldui/fldwrap.cxx:42:26
        >  #21 in SwChildWinWrapper::LinkStubUpdateHdl(void*, Timer*) at sw/source/uibase/fldui/fldwrap.cxx:39:1
        >  #22 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:111:45
        >  #23 in Timer::Invoke() at vcl/source/app/timer.cxx:75:21
        >  #24 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:481:20
        >  #25 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54:13
        >  #26 in SvpSalInstance::CheckTimeout(bool) at vcl/headless/svpinst.cxx:161:53
        >  #27 in SvpSalInstance::ImplYield(bool, bool) at vcl/headless/svpinst.cxx:399:17
        >  #28 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:471:21
        >  #29 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:475:48
        >  #30 in Application::Yield() at vcl/source/app/svapp.cxx:559:5
        >  #31 in Application::Execute() at vcl/source/app/svapp.cxx:453:13
        >  #32 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1604:13
        
        causing
        
        > ERROR: test_tdf135938_cross_reference_update (tdf135938.tdf135938)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "uitest/uitest/test.py", line 125, in execute_dialog_through_command
        >     yield xDialog
        >   File "uitest/uitest/test.py", line 140, in execute_modeless_dialog_through_command
        >     yield xDialog
        >   File "sw/qa/uitest/writer_tests7/tdf135938.py", line 40, in test_tdf135938_cross_reference_update
        >     self.assertEqual("ABC", get_state_as_dict(xSelect.getChild(0))["Text"])
        >   File "uitest/uitest/uihelper/common.py", line 13, in get_state_as_dict
        >     return convert_property_values_to_dict(ui_object.getState())
        > uitest.uihelper.common.com.sun.star.lang.DisposedException: Binary URP bridge disposed during call at binaryurp/source/bridge.cxx:613
        
        The issue apparently is that TreeListEntryUIObject UNO objects, introduced in
        71f562f8f77f14b76fde4329f7238fe2e7d6a054 "uitest: support tree lists", reference
        SvTreeListEntry instances by pointers that can apparently go stale while those
        UNO objects are still alive.  I'm not sure there would be an easy fix for this,
        short of making those SvTreeListEntry instances ref-counted, or ripping out
        UITest support for those TreeListEntryUIObjects again.
        
        However, that underlying issue would presumably not be of practical concern if
        the test_tdf135938_cross_reference_update Python code would have waited for
        processEventsToIdle between its
        
        >                 xInsert.executeAction("CLICK", tuple())
        
        and the following block
        
        >                 self.assertEqual("2", get_state_as_dict(xSelect)["Children"])
        >                 self.assertEqual("ABC", get_state_as_dict(xSelect.getChild(0))["Text"])
        >                 self.assertEqual("DEF", get_state_as_dict(xSelect.getChild(1))["Text"])
        
        That way, there should be no more opportunity for the pointers in the passed-out
        TreeListEntryUIObjects to become stale while the Python code accesses them.
        
        And in Python UITest code, having to follow a call to executeAction by a call to
        processEventsToIdle appears to be a common and recurring requirement, just look
        at the most recent af1ca684bb12ff62e3df995ad44aefdb57a51af7 "another stab at
        making this test reliable", d183daea1abbd7b564d083298874dd7c40d5a5b3
        "tdf#153161: (Ab)use a call to XTextRange::getString to flush edits",
        3cc6b870c48b23418f65d2c3cd6eab72ef0680de "make an effort to fix the
        UITest_inputLine intermittent failure", f4668540ff7256bb0ddd382dfaf9f3499e99128a
        "tdf#150443 sw: fix crash of rejecting table row deletion".
        
        So make executeAction always call ProcessEventsToIdle, to simplify this and
        hopefully make UITests more robust.  (Removing any now-redundant calls to
        processEventsToIdle, following calls to executeAction, from Python test code is
        left as follow-up clean up for now.)
        
        (I /think/ that the implementation of UIObjectUnoObj::executeAction could be
        simplified now, as waiting for Scheduler::ProcessEventsToIdle() should already
        make sure that aIdle has been processed, removing the need for the Notifier.
        But lets leave that as a follow-up TODO for now.)
        
        Change-Id: I41a5d51515dedaae44fb810b0ad3b0264c90abf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146434
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-01  Henry Castro  <hcastro@collabora.com>  [60bc7d7acd9c6656b3124b2015ab26f26b47cb32]

        linguistic: add REST API protocol unit test
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I4768f8bb5bfa572d222fa5610f95c99169e6e390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143249
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145600
        Tested-by: Jenkins

2023-02-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8a25eb9fd8783bb41a9d1d9df55c0697a6dbb7c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36367761a21809320eb5e01875f5734c0cf59727
          - Update 7.5 release video
            
            Change-Id: I046063162992e71c60d0c3f6fba9265e172cedeb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146446
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [2c0c95af13662f37e7f217e0bd0fc87ebde36f1b]

        tdf#107841 oox: rename ambiguous and confusing ECMA_DIALECT
        
        Change-Id: I731b3808896347332f938811715597ac814ae1d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146433
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [8431cbbed5b5665571cbb27d1330abd3dd0868f4]

        uitest: sw: remove duplicated tests
        
        These are already covered by CppUnittests
        
        Change-Id: If41e73557566304e9e2d44ecccbf0e30b77d2807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146432
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [62797844fed93d5e33505d544606e4d4e2530f8c]

        Throw early on invalid state
        
        The result of GetFrameFormat call was dereferenced unconditionally
        in the unit conversion code, despite it can obviously return NULL.
        
        Change-Id: I30117f1db942a8ff108a959891d8763c4d44fb39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146429
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2f3072bdf419492ad20cbfb1da14e2d53acf83b]

        tdf#107427: sw: move UItest to CppUnittest
        
        Change-Id: I13b8757c384c3ecd23c0b06b93e2db03ce0b364e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146431
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-02-01  Miklos Vajna  <vmiklos@collabora.com>  [b052ec2f2fbe0f3044ba824c064a280a5ee9cd7f]

        sw: introduce SwFlyFrame::IsFlySplitAllowed()
        
        And use it in SwFrame::IsMoveable(). With this,
        SwContentFrame::MakeAll() calls into SwFlowFrame::MoveFwd() for a
        paragraph that's inside a fly frame that doesn't fit is body frame in
        fly split mode.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I5a1d5ca499c08dd32432cfacf49d01f393e5d324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146427
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-02-01  Stephan Bergmann  <sbergman@redhat.com>  [6028e9fda96d0ed5da266b1c54a7755f7ba3408c]

        Finally drop undocumented rtl_[u]String_newFromStr null argument support
        
        ...executing on the TODO left by 4f0c70fb5554325e0cc2129741175bf07de22029 "Avoid
        calling OString ctor with null pointer" in late 2020.
        
        Change-Id: I3db6e2df61ca290948affc5e02ae74757441471d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146428
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d8de2dc3c55a9013a71167c8058a333e7221a6a0]

        xmloff: import of theme structure + import/export/round-trip tests
        
        Change-Id: I50e8c53c534895098613e81fd97b346fd3d7d05f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146287
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7ab51def766ad6bfdcf5111e7b751bbc2bbf1d73]

        sw: implement "Theme" property for the XDrawPage in Writer
        
        Change-Id: I8eed04f0ccb2e626a648abcaecd957b6f62c39d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146226
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-02-01  Miklos Vajna  <vmiklos@collabora.com>  [a262ee4c4a682f844ef380d5e843be1b3ec78c98]

        CppunitTest_sw_rtfexport5: fold preTest() into its only user
        
        Avoid magic in preTest() based on the bugdoc name.
        
        Change-Id: I7642828480bb4f636956b966275d8c3e26919a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146421
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-02-01  Julien Nabet  <serval2412@yahoo.fr>  [2d9570523b16dd157eeee384040642e3c2e0ed05]

        tdf#153272: add some missing properties in SwSearchProperties
        
        RES_CHRATR_RELIEF
        RES_CHRATR_ROTATE
        RES_CHRATR_SCALEW
        RES_PARATR_VERTALIGN
        
        Change-Id: Ic4a3323a4b4b4231dee083016a6112a9e2674c86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-02-01  Michael Weghorn  <m.weghorn@posteo.de>  [6f4b8b7cfe2907b7da46eec6951a0e09b836a6de]

        tdf#152073 qt: Draw background when drawing frame
        
        For native drawing of a frame (border), use
        the window background color as default color.
        
        As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06
        ("tdf#138010 (IV) VclScrolledWindow: Use actual border width"),
        the Qt/KDE Breeze style uses a frame width of 2, with the
        actual 1 pixel border being surrounded by a 1 pixel
        padding/margin.
        
        Transparent background did not ensure that the 1 pixel
        padding/margin is repainted and could thus result
        in artifacts from what was painted to that location
        previously (s. the Basic IDE editor example from
        tdf#152073).
        
        Use the window background for the default image color
        when drawing a frame to avoid this.
        
        The gtk3 VCL plugin also explicitly draws a background
        for the corresponding code path, using
        `gtk_render_background`.
        
        An alternative might be to explicitly draw the
        background further up the call stack, or pass
        an explicit background color from
        `DecorationView::DrawFrame` and only apply
        a default color in `QtGraphics_Controls::drawNativeControl`
        when a background color (other than `COL_DEFAULT`)
        is passed to that method.
        
        Sample bt for gtk3:
        
            1   GtkSalGraphics::drawNativeControl     salnativewidgets-gtk.cxx 1835 0x7fffe6271f92
            2   SalGraphics::DrawNativeControl        salgdilayout.cxx         807  0x7fffee887739
            3   OutputDevice::DrawNativeControl       nativecontrols.cxx       287  0x7fffee58906e
            4   (anonymous namespace)::ImplDrawFrame  decoview.cxx             600  0x7fffee1b2055
            5   DecorationView::DrawFrame             decoview.cxx             886  0x7fffee1b32c8
            6   ImplSmallBorderWindowView::DrawWindow brdwin.cxx               742  0x7fffee0ea3ea
            7   ImplBorderWindow::Paint               brdwin.cxx               1630 0x7fffee0ee99a
            8   PaintHelper::DoPaint                  paint.cxx                313  0x7fffee0c9f1c
            9   vcl::Window::ImplCallPaint            paint.cxx                617  0x7fffee0cb4b3
            10  PaintHelper::~PaintHelper             paint.cxx                552  0x7fffee0cae14
            11  vcl::Window::ImplCallPaint            paint.cxx                623  0x7fffee0cb513
        
        Many thanks to Rafael Lima for the
        very helpful analysis in [1] and [2].
        
        [1] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c2
        [2] https://bugs.documentfoundation.org/show_bug.cgi?id=152073#c3
        
        Change-Id: I08e6d05d0fc3d0e54952a65cd28dee92615df0a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146419
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Tested-by: Jenkins

2023-02-01  Hannah Meeks  <hmeeks4135@gmail.com>  [36343165c251e30c700360cc5c4266f576d4ac00]

        cui: Make SimilaritySearch dialog async and enable use for jsdialog
        
        Change-Id: I89c6665138c94aa355efbbc4aa0947226c68af5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146130
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-02-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bed16c5e9df1eea4187b2b47a357414b3940bc91]

        Remove duplicated include
        
        Change-Id: I84dc37baac93f946bd66b6d709a43529d023dac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146381
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9740331d8bc56a9b6fbe3e4c1b26fb97f6639cc6]

        tdf#66580 write more metadata to embedded and attached files
        
        Change-Id: I6f40fd98b48893d01d29a806877821c561688897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146288
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d8e6b488ceaff7c88856ebcfcfec14d2d8cd7652]

        Remove duplicated include
        
        Change-Id: Ia5f606fd64737aed372afb2ee4762f9eb3e21a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146380
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [1af03aaa35dc9758a9702cddf48d9aad02ec7a94]

        language tool warnings in console on start up with language tool not configured
        
        warn: languagetool:3333070:3333070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372: CURL request returned with error: 3
        warn: languagetool:3333070:3333070:lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx:372: CURL request returned with error: 3
        Change-Id: I67de3351c6f01ed8274b4a282b45ded9f5cea5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146418
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [da27102aaa488d982164c54f8c7f8f3bc6181481]

        add default mode lines
        
        Change-Id: Ie0485f52f81f31f821f8a6ebc4720528da33fa48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146417
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [fa7d25625fa327ebc49ec8d0f96c192f4ed0c17b]

        tdf#152770 undo move warning about ppd with no resolution to use of resolution
        
        and downgrade to SAL_INFO
        
        Change-Id: I9a565aa12f83e7ed8dd6b0f903f7b18d62c16c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146416
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [ca71482237d31703454062b8b2f544a8bacd2831]

        tdf#153083 writerfilter: import locale-dependent TOC \t style names, 2
        
        There was a problem with commit ecbad22fdf81c6f072b6c9f9c16dbba47fe4748c
        while it now worked in Writer, the roundtripped DOCX with the en-US
        built-in style name in the TOC field no longer worked in Word in the
        original locale (but started to work in en-US locale).
        
        Let's try a slightly different approach: use the same style name as-is
        from the TOC field, and if it doesn't exist as a style, then clone the
        en-US built-in style with that name, and at the end of the import,
        iterate all paragraphs in the document and replace any application of the
        en-US style with the localised style.
        
        So both the en-US style and the localised style exist, and for
        references that aren't fields (e.g. basedOn in other styles) it should
        hopefully not matter which one is referenced.
        
        The DOCX exported from Writer now has a TOC field that works in Word in
        the original locale.
        
        Change-Id: Ibcc3c5899e31295b5704ebefb548f40b67eda9bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146414
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [4332c58eca7df7a30e8f11b9193d7d0727c2a36c]

        tdf#153273 bodge dark scrollbar into drop downs
        
        Change-Id: I9c53b931feb7f720f86edfbb6ae88ff5ee436cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146386
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9c53b55a8fed37bb6ce27d49146f015dde881fdc]

        Restore changes accidentally overwritten in 1fb964276c184b0fb052503fe7dbc05bf0331211
        
        Change-Id: I3630a1fe1365593103b1670926d4e7aa318d9a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146374
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-31  Henry Castro  <hcastro@collabora.com>  [5cd9ca5d4232c725661131137975549c06231d5c]

        lok: add Rest Protocol property
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I7353e16dbf835684e5ce5963387359924352937b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145599
        Tested-by: Jenkins

2023-01-31  Henry Castro  <hcastro@collabora.com>  [1d89f4835384e6379177e1607bb648b567e3fdab]

        lingucomponent: implement custom parse response rest protocol
        
        Response:
        
        HTTP/1.1 200 OK
        Transfer encoding: chunked
        Content-Type: application/json
        {
        "hyphenation-positions":[
        {"offset":15,"quality":0},
        {"offset":20,"quality":1}
        ],
        }, "check-positions":[
        {"offset":15,"length":6,"errorcode":4711,"type":"orth","severity":1,"propos
        als":["Entwurf","Entw\u00fcrfe"]},
        {"offset":22,"length":3,"errorcode":8221,"type":"orth","severity":1}
        ]
        }
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I87228237f23306fb367edab1e21ce002aaf13f2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145598
        Tested-by: Jenkins

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [64b8057a6cd2fbaed6167e2be912914e9569796c]

        tdf#153287 rollover in dark mode with "Explorer" is incongruous
        
        Using "CFD" gives a brighter border with rollover, but no notable
        focus state when focused. Try a combination here to get something
        decent.
        
        Change-Id: If7844cb0f1e88410959aa622b0271c3f3954230e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f841e9a28a6f5d7ae9d5226cbc98db3cb992eb1]

        uitest: remove wait_until_file_is_available
        
        Introduced in 33a49a99c76ca1879dbb0202384aa939a6d44a75
        "uitest: introduce wait_until_file_is_available" as a blind
        fix for https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91
        It turned out the root problem was caused by another test
        and the fix is addressed in https://gerrit.libreoffice.org/c/core/+/146385
        "uitest: Always change doc info setting back to false"
        
        Change-Id: I4b3d5e24e35a33de6c128dcbf2f144b4cf48a48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146389
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [3ac5bfec2f73c55e99c4410f7559db86b875a269]

        uitest: Always change doc info setting back to false
        
        otherwise it won't be changed if an exception is raised
        affering other tests as seen in
        https://gerrit.libreoffice.org/c/core/+/130530/2/sw/qa/uitest/writer_tests6/save_readonly_with_password.py#50
        
        Change-Id: Ife443cc6627025a05a0a33ba1c86140f087dd70c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146385
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [87f03db116f7f36c929f5cdbfe38f19ae57d34ac]

        tdf#153289: remove problematic assertion
        
        It is unclear what it should guarantee; but at least when ungrouping,
        SwDoc::UnGroupSelection copy-constructs a shared pointer (increasing
        the refcount), then a copy-constructed argument passed to
        lcl_CollectTextBoxesForSubGroupObj increases it once again, and then
        the assertion expectedly fails.
        
        Change-Id: I0cb5f303c67b2dc67d5583a9eb03fe405af3573d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146377
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-31  Henry Castro  <hcastro@collabora.com>  [e295f060f25f3a731a93cea23a1662091f4c9763]

        lingucomponent: implement custom request http rest protocol
        
        Request:
        
        POST /api/check HTTP/1.1
        Host: localhost:8099
        Content-Type: application/json
        Cache-Control: no-cache
        
        {
        "dictionaries": [
        "daily",
        "jungblutt"
        ],
        "text-language": "en-DE",
        "property-sets": [
        "base", "daily",
        "culture"
        ],
        "hyphenation": true,
        "spellchecking-level": 1,
        "correction-proposals": true,
        "single-word-mode": false,
        "message-language": "fr-LU",
        "message-level": 1,
        "text": "This is a final throw for the interface to the Duden server."
        }
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I2a288a7c573014d42df03f7cc12c57a7f788750e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143107
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145597
        Tested-by: Jenkins

2023-01-31  ektagoel12  <ektagoel12july@gmail.com>  [eb5c14f305f9c6355bd49bd65ab9175831453cb3]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Also change some range based for
        
        Change-Id: I2e17feaba7a6b219aa0c9126c5046cf3bdf855d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145988
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbfe06dcbda005ed35747ca5ba30b3891c2717d1]

        loplugin:unusedfields
        
        Change-Id: I6acce1578d21da0ac014410289def3dd500b4de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-31  Chenxiong Qi  <qcxhome@gmail.com>  [6f112bd40fe78141de865934145d81b1258b36de]

        tdf#97362 Convert comphelper SequenceOutputStreamUnitTest to Python
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I72826fc8180fcb147ff84b10b88c16a4084799ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145690
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-31  Caolán McNamara  <caolanm@redhat.com>  [af1ca684bb12ff62e3df995ad44aefdb57a51af7]

        another stab at making this test reliable
        
        Change-Id: If044ae7906f3e98ea558dc90d9580052874e97bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-31  Rasenkai  <rasenkai99@gmail.com>  [a345952daf3238066ecb1a9c67bb6a3640a6299a]

        tdf#143148 sw: inc: Use pragma once instead of include guards
        
        Change-Id: I7a491038d1b8532385e70294872d209dcdc63ce9
        Signed-off-by: Rasenkai <rasenkai99@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146300
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-01-31  Heiko Tietze  <tietze.heiko@gmail.com>  [41a911fa54d3814d81d4ed603babf375c405900f]

        Resolves tdf#137269 - Disable ToC preview by default
        
        Dialog is too large with the preview for small screens
        Setting is stored so users who enable it will have the preview next time
        
        Change-Id: Iecf63fe10ce35d2132fc3578cd2c239a6b214e40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144003
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [f4804a8fb60cc999c9b08bf451732749b44eb355]

        Some simplification after 743dd1d3c1142c1c99b0844cc26dd0be91a1de40
        
        MapMode ctor taking origin and scales sets mbSimple to false, so
        avoid calling it when these are the defaults.
        
        Some calculations become unneeded when the fraction is (1, 1).
        
        Change-Id: I19a98ad2cac0a66b9bd7b72620180addb3f7fec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146375
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [75c0d7827625c683d52a9e2f3a7c514df890107b]

        sd: use XTheme to transport the theme to xmloff import/export
        
        Refactor the existing places and tests in Impress code (sd) to
        use it instead.
        
        Also keep the old property of construction and view of the theme
        with a sequence of property values, but  under the new property
        named "ThemeUnoRepresentation". This is needed by the UI tests
        currently.
        
        Change-Id: I484567f4a603f1a5e2e03955fdd2b63132dcc66e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146225
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-31  Miklos Vajna  <vmiklos@collabora.com>  [ed9d987e2ad8f6af554a5fc1f858ca48c6970446]

        sw: if the fly is to be split, then limit its growth in SwFlyFrame::Format()
        
        It seems the first direct cause why flys are not split is because flys
        can grow forever, so an inner paragraph's SwContentFrame::MakeAll() will
        never hit the nBottomDist < 0 condition, which is necessary to call into
        SwFlowFrame::MoveFwd().
        
        With this, at least nBottomDist is negative when a fly with two
        paragraphs is at the bottom of a page and only one of them fits the body
        frame.
        
        Also add a debug environment variable, so I can debug the "fly split"
        case till we don't have import/export filters for this.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I43114b5795dd42e518a1d776ccd2e7ab607ad859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146376
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-31  Noel Grandin  <noelgrandin@gmail.com>  [07699b6e7847c141c0bdec2e5345f2d00cb219dd]

        osl::Mutex->std::mutex in AnimationNode
        
        Change-Id: I9a07afcdf17ca464e6a1083fbd7ec1e1f7186a30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-31  Stephan Bergmann  <sbergman@redhat.com>  [061d3bc359b6b94a874c10e96ad9cc8189494e21]

        Fix locking order
        
        JunitTest_sfx2_complex occasionally deadlocked when the main thread at
        
        > framework::UndoManagerHelper::isUndoPossible
        > chart::UndoCommandDispatch::fireStatusEvent
        > chart::CommandDispatch::addStatusListener
        > svt::ToolboxController::bindListener
        > framework::ToolBarManager::UpdateControllers
        > framework::ToolBarManager::AsyncUpdateControllersHdl
        > Scheduler::CallbackTaskScheduling
        > SalTimer::CallCallback
        > SvpSalInstance::CheckTimeout
        > SvpSalInstance::ImplYield
        > SvpSalInstance::DoYield
        > ImplYield
        > Application::Execute
        > desktop::Desktop::Main
        
        has acquired the SolarMutex in
        framework::ToolBarManager::AsyncUpdateControllersHdl and is now trying to
        acquire framework::UndoManagerHelper_Impl::m_aMutex, while a cppu_threadpool at
        
        > framework::UndoManagerHelper_Impl::impl_clear
        > std::function<void ()>::operator()
        > framework::(anonymous namespace)::UndoManagerRequest::execute
        > framework::UndoManagerHelper_Impl::impl_processRequest
        > framework::UndoManagerHelper_Impl::clear
        > framework::UndoManagerHelper::clear
        > gcc3::callVirtualMethod
        
        first acquired framework::UndoManagerHelper_Impl::m_aMutex and then tries to
        acquire the SolarMutex.  That additional acquiring of the SolarMutex had been
        added to framework::UndoManagerHelper_Impl::impl_clear in
        8611f6e259b807b4f19c8dc0eab86ca648891ce3 "ref-count SdrObject".
        
        Change-Id: Ifcb8765b29b65f773be6bbe54092346c5ae3a33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146371
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1e92059fe95cc1ba31aab4a66926d55bc00d0684]

        svx: Refactor (sdr) views to access the SdrModel by reference
        
        In SdrPaintView (and subclasses) the mpModel variable is always
        the same as the input (reference) model, so there is no need for
        that extra variable.
        
        Change the strange and confusing var. name mrSdrModelFromSdrView
        (the input reference to SdrModel) to just mrModel and use that in
        GetModel(). Change the GetModel() to return a reference instead
        of a pointer and reactor the code to accomodate the change.
        
        This gets rid of many nullptr checks for the pointer that the
        GetModel() returns and makes the code more simple is some cases.
        
        Change-Id: I18351a417fd82f49262a83de036ec1420a65399c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146373
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-31  Miklos Vajna  <vmiklos@collabora.com>  [d9ebb2e76bf7ec068ebfceccf7f477471012d157]

        sw: document SwTextFootnote
        
        It's a bit confusing that "footnote" may mean "footnote" or "footnote or
        endnote", depending on context.
        
        Change-Id: Ibe19dc29f68d1409feb052296e9a3537b160882e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146366
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-31  Noel Grandin  <noelgrandin@gmail.com>  [ba4191ff0de05334ba32b53a09ad992710f03f9d]

        osl::Mutex->std::mutex in ImplEventAttacherManager
        
        Change-Id: Id8a4d2d75b1be8f23f6b1260a7a7727ab6bbd27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146368
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [743dd1d3c1142c1c99b0844cc26dd0be91a1de40]

        SdrModel: we never set scale fraction to anything else than 1/1
        
        This removes the scale fraction on SdrModel - SetScaleFraction and
        the m_aObjUnit instance variable, as it is never set to anything
        else than 1/1 (and don't see it usefult to set it to anything else
        than this).
        
        Change-Id: I990d20f110b3be00e6770b68e39df212f9c576be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146348
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-30  Henry Castro  <hcastro@collabora.com>  [326dec315c29028ad1c163020d518e1236f37b6b]

        cui: add entry "RestProtocol" to language tool dialog
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I6511fc2b353c47b1ff537c42d3484b3a42c1b121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143106
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145596
        Tested-by: Jenkins

2023-01-30  Henry Castro  <hcastro@collabora.com>  [9d4ac7d73c036d8e8bdf5418919c1bfd2062ed6d]

        svtools: add new entry "RestProtocol"
        
        Custom Rest API protocol
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If2f72330f2ed9768f230dc88296df7f757be263a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143105
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145595
        Tested-by: Jenkins

2023-01-30  Mert Tumer  <mert.tumer@collabora.com>  [1fb964276c184b0fb052503fe7dbc05bf0331211]

        Added option to disable ssl verification for languagetool
        
        This will allow to use self-signed certificates with local run
        languagetool APIs
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145594
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2023-01-30  Stephan Bergmann  <sbergman@redhat.com>  [ed68634db25103cd7d2adc29f3973f80fbaec324]

        external/skia: Still missing include
        
        9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111" had removed the
        whole external/skia/missing-include.patch.0, including the part added by
        5877c6b118c99c9ec807a111471bfd67720a5086 "external/skia: Missing include" (for
        snprintf in
        workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h),
        even though at least my GCC 13 trunk build still requires that.  However, the
        comment at
        <https://gerrit.libreoffice.org/c/core/+/145552/2#message-7fad3bfd39568500aa66b1c03dfd1670dad636f2>
        "external/skia: Missing include" pointed out that this "landed upstream at
        https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/commit/29d492b60c84ca784ea0943efc7d2e6e0f3bdaac",
        so switch to using a git-format-patch of that (slightly hand-edited to fix up
        the path of that project's vk_mem_alloc.h as included in the Skia tarball, and
        to cater for that file's usage of CRLF line endings).
        
        Change-Id: I31192b6e0aaf355d5cfee96badc59903ab592aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146365
        Reviewed-by: Sam James <sam@gentoo.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [82ee2d6184a59ef4470c12bddeff03cd68d946e4]

        Fix typos
        
        Change-Id: Iaed6f8d3316200f8c5e0c96766a84d59b1066928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146367
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-30  Stephan Bergmann  <sbergman@redhat.com>  [1cba80e9224de8c7318aa8fddba3db6ec9915d51]

        external/skia: Another constexpr template point of instantiation issue
        
        ...with --with-latest-c++ after 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update
        skia to m111",
        
        > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.cpp:8:
        > In file included from workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.h:11:
        > In file included from workdir/UnpackedTarball/skia/include/core/SkBitmap.h:12:
        > In file included from workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:14:
        > In file included from workdir/UnpackedTarball/skia/include/core/SkRect.h:19:
        > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/algorithm:1747:
        > In file included from /Users/stephan/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:28:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: invalid application of 'sizeof' to an incomplete type 'SkStrikePinner'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in instantiation of member function 'std::default_delete<SkStrikePinner>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:46:47: note: in instantiation of member function 'std::unique_ptr<SkStrikePinner>::~unique_ptr' requested here
        >             std::unique_ptr<SkStrikePinner> = nullptr) SK_EXCLUDES(fLock);
        >                                               ^
        > workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:20:7: note: forward declaration of 'SkStrikePinner'
        > class SkStrikePinner;
        >       ^
        
        Change-Id: I367323706d047da18fd8d4230a47a78fbb32b677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146349
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-30  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [887de466a689323d4c4a607fdbd74939af98d14b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c6cea6707879ad1c8f5bd11ff26b774f2e59b013
          - tdf#142380 Use CSS variable for background color
            
            Change-Id: Ia70389ced5e8b698c034f9eec8cb4f030d27dd81
            
2023-01-30  Regina Henschel  <rb.henschel@t-online.de>  [fc5ab71bd2b4af535c2bdd2c9ea48be378b66a19]

        tdf#153260 VML export write trim value true in any case
        
        LO renders Fontwork shapes always so as if trim=true is set. But the
        default value for trim attribute is 'false'. Therefore always write out
        'true'. Otherwise the import will treat it as 'false' and apply the
        shape height reducing workaround.
        
        Change-Id: I626c5a84627f16011198a9a4e35d8fedf1fd1b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146361
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4a24366dd111c7c7434f4a887d7097ced6b5f55]

        tdf#150380 Calc crash clicking on the title of the Border Color toolbar popdown
        
        There is probably a better fix for this, but we have a popup inside a
        popup here, so some weirdness is to be expected.
        
        At least it doesn't crash now.
        
        Change-Id: Ifaa928c47c3cbfaec8379f01f007b0c1daf4e5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146359
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [72f3df889a950218c9e801aa93bb2e755d26f3e1]

        sw: blind fix for uitest hang
        
        Seen in https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132028/consoleFull#101810144248ce9c26-9d0a-43a8-83d8-c44f54920d59
        
        Change-Id: I67312b3f7e6c6192e14a6bb3236ba4ff959002f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146353
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [86558061332e9828d5a69fe97b439bf49560f552]

        sw: blind fix for uitest hang
        
        in sw/qa/uitest/writer_tests6/ there is another test document called
        edit_file_properties_before_saving.py that changes the option
        "Edit document properties before saving" to True.
        My theory is that it might affect save_readonly_with_password.py so let's move it to another folder to make sure this is not affecting the test
        
        Change-Id: Ib75361be31aceeec33df76ae31a9ee8c261a2c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146357
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-30  Stephan Bergmann  <sbergman@redhat.com>  [440230f1802ce03f83aa92d1b56806e068ce4800]

        Silence two GCC warnings in Skia include files
        
        Since 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111", various
        versions of GCC produce
        
        > In file included from workdir/UnpackedTarball/skia/include/gpu/GrRecordingContext.h:13,
        >                  from workdir/UnpackedTarball/skia/include/gpu/GrDirectContext.h:11,
        >                  from workdir/UnpackedTarball/skia/tools/sk_app/WindowContext.h:14,
        >                  from vcl/inc/skia/utils.hxx:35,
        >                  from vcl/skia/SkiaHelper.cxx:34:
        > workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:520:33: error: ‘cfi’ attribute directive ignored [-Werror=attributes]
        >   520 |     static T* TCast(void* buffer) {
        >       |                                 ^
        > workdir/UnpackedTarball/skia/include/private/base/SkTArray.h: In constructor ‘SkSTArray<N, T, MEM_MOVE>::SkSTArray(std::initializer_list<_Up>)’:
        > workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:654:40: error: declaration of ‘data’ shadows a member of ‘SkSTArray<N, T, MEM_MOVE>’ [-Werror=shadow]
        >   654 |     SkSTArray(std::initializer_list<T> data) : SkSTArray(data.begin(), SkToInt(data.size())) {}
        >       |               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
        > workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:684:22: note: shadowed declaration is here
        >   684 |     using INHERITED::data;
        >       |                      ^~~~
        
        The -Werror=attributes is because GCC __attribute__((no_sanitize("...")))
        accepts the same values as -fsanitize, but GCC doesn't support Clang's
        -fsanitize=cfi.
        
        The -Werror=shadow is because GCC is somewhat picky about uses of a name for a
        variable when that name is also brought in by a using declaration from a
        dependent base, as it /could/ be brought in as a variable (and not just as a
        function, in which case there would normally be no such shadowing warning):
        
        > $ cat test.cc
        > template<typename> struct SkTArray { void data(); };
        > template<typename T> struct SkSTArray: SkTArray<T> {
        >     SkSTArray(int data) { (void) data; }
        >     using SkTArray<T>::data;
        > };
        > $ g++ -Wshadow -fsyntax-only test.cc
        > test.cc: In constructor ‘SkSTArray<T>::SkSTArray(int)’:
        > test.cc:3:19: warning: declaration of ‘data’ shadows a member of ‘SkSTArray<T>’ [-Wshadow]
        >     3 |     SkSTArray(int data) { (void) data; }
        >       |               ~~~~^~~~
        > test.cc:4:24: note: shadowed declaration is here
        >     4 |     using SkTArray<T>::data;
        >       |                        ^~~~
        
        It feels more natural to silence these warnings at the site including the
        relevant Skia include files, rather than as a patch to external/skia, as, at
        least theoretically, we should also be able to build against a system's Skia
        include files.
        
        Change-Id: I0860b6a84e61da656038da8c77f3947d97ad8cf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146364
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c99e7737ef2b536a4d9f28c3ddd37fe6afa9ceb]

        tdf#148810: sd: move UItest to CppUnittest
        
        Change-Id: I11c0ecfb628792ed0ce62916e01fe3b69cb0fc78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146363
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ba513361df3cdde639f80757a299721023d46a1]

        loplugin:virtualdead
        
        GetPDFAnchorStructureElementId was added in commit 6e5d59c2ca696, but
        was unused even there
        
        Change-Id: Id0624cac2854f5406ca93a4c495632fc3c1d0e74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a362c0145731031834bc3a73c8e3577bf6c12720]

        tdf#45147 - CSV Import: Remove special handling for mixed script types
        
        In the CSV import dialog, remove the special handling for mixed script types. Otherwise, right-to-left words appear in the wrong order.
        
        The special handling of mixed script types was introduced in https://bz.apache.org/ooo/show_bug.cgi?id=60296 which is handled in the edit engine now.
        
        Change-Id: Ic6dc3f2051ea41f79db5398a8442f78116da52de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146096
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-30  Mert Tumer  <mert.tumer@collabora.com>  [080d39e6832b0ebbf588b6d02ad00bba968d1360]

        lok: set LanguageTool config parameters from environment
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: Ic7343439536abee626c269d2a824bb36f9abc40f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135583
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145573
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2023-01-30  Laurent Balland  <laurent.balland@mailo.fr>  [46b7fd59f9d0dfb5544df99494d3a3d3a372ae8b]

        tdf#118324 Treat blank ? in integer
        
        Restore and update change 56352
        Test of https://cgit.freedesktop.org/libreoffice/core/commit/?id=8ca6468f0f4900d4d3bb45e0e938fe35c308512c is now ok
        
        Add disambiguation between '0' and '?' in integer part
        XML_MAX_BLANK_INTEGER_DIGITS is added for the number of '?'
        XML_MIN_INTEGER_DIGITS is the number of '?' and '0'
        This preserve compatibility with previous versions:
        in previous versions '?' will be transformed in '0'
        It also applies to scientific and fraction numbers.
        Integer part for number, scientific and fraction are
        treated the same way
        
        Include QA unit test
        
        Change-Id: Iab3127bf07223caac60e409306a1bee2edc37428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145932
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-30  Caolán McNamara  <caolanm@redhat.com>  [e783208906611238a9a6ce9d14029eb732fc611d]

        ofz#55520 check level is < MAX_OUTLINE_LEVEL
        
        Change-Id: I61ac10f40cd754a1ea3186ab89e9bfd1e99dc563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146340
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-30  Caolán McNamara  <caolanm@redhat.com>  [fb4c953cac6eeb3b0c7b3832facfe3a82092e69f]

        ofz#55466 Out-of-memory
        
        Change-Id: I457525056082e97550f2c78e1cc7d2084515b71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-30  Laurent Balland  <laurent.balland@mailo.fr>  [8ba7657a9653f8ae5d1b865356d11138df7b2093]

        tdf#152722 Number Format: keep NatNum modifiers
        
        When modifying number format with UI (decimal places, negative in red...) NatNum modifiers must be preserved
        Implement an helper to get NatNum string
        As NatNum12 already inserts currency unit, do not treat it
        
        Change-Id: I38be1da08a44d75ef663eaf50fccb3820ff9ed5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144963
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-30  Stephan Bergmann  <sbergman@redhat.com>  [5d22865a140ebdc307d39226f1eedb955a7dafee]

        Missing include for llvm::Optional
        
        ...with recent Clang 17 trunk after
        <https://github.com/llvm/llvm-project/commit/125f4457a54a550846732763ee36b1447ec8d66e>
        "[clang] Remove clang::Optional"
        
        Change-Id: If33406604a614a65dd17e269a0a5c167ea263328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146347
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-30  Miklos Vajna  <vmiklos@collabora.com>  [1f474cbb8acdf6855db1f835fe58d198bdbabcbc]

        sw: prefix members of PanesEnumWrapper, RangeBorderEnumWrapper, ...
        
        ... StyleCollectionHelper and StylesEnumWrapper
        
        See tdf#94879 for motivation.
        
        Change-Id: Ibbce6f1d068ace5374fdc14e50e079a01872773f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146336
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-30  PL  <pluby@guibomacbookpro.local>  [5473f185eab53e4389859473f104e697db3ae879]

        Fix iOS build errors
        
        Recent code reorganization and macOS changes caused the iOS build to fail. This change fixes the build errors and updates the iOS code to use the same headless data structures as other headless builds.
        
        Change-Id: I9c5329eb6376120d6789447f991c93eb9839d595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146265
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0072d0a31760d6e94a7319dbb4d3e3a18cd50c1]

        update TSAN suppressions
        
        add some more deadlock suppressions
        
        Change-Id: I457e66275921080f9f12c3ab2f2fbbb6168ad108
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146345
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fde49387eeecc35d1ead6305b1fe1e30e09cccc]

        tdf#152726 Pasting Selection to Sheet as BMP Image, button test is larger
        
        regression from
        
            commit 720e4258ab5f00287098ff945a184bfb43911841
            Author: Noel Grandin <noel@peralex.com>
            Date:   Fri Aug 20 11:30:35 2021 +0200
        use Primitive2DDecompositionVisitor in ViewObjectContact
        (tdf#105575)
        
        Revert the relevant piece, no idea what the underlying problem is. I
        suspect something is being tricksy and using settings from the current
        OutputDevice even though the point of the drawinglayer
        getPrimitive2DSequenceHierarchy is supposedly to be independant of that.
        
        Change-Id: I3026ff2ba5ce3751a4e4ebdf15954aae548493c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [41043667d759a2ed60fd013ef94d6723ea13e134]

        sc: blind fix for uitest hang
        
        Seen in https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132439/consoleFull#42154025848ce9c26-9d0a-43a8-83d8-c44f54920d59
        
        Change-Id: I688e796ff09a6df86eda6409b16150a8684bff7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146351
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7db0f22dcff0b08acccf326b62d72a12b6e28f6]

        fix data-race in ScMatrix
        
        when doing threaded load of spreadsheets, we touch these fields from
        multiple threads
        
        Change-Id: Ia9d4dba79cfe7870a3a252a35a23acf71a3971e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146346
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-01-30  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [829f898f0076082c039494bc0fffe00e2dd4ac26]

        Show infobar instead of dialog when unsigned content is found
        
        Follow up to f41627ab60372345be646c53d967b65be43b562f
        
        Change-Id: I67dadad0fe69e29199c5bc160af1a46cc8aafac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146338
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-01-30  Tünde Tóth  <toth.tunde@nisz.hu>  [f589d7e769bee4b82826a944fed3cf2382d84fb2]

        tdf#153185 PPTX: fix export of linked OLE objects
        
        Linked OLE objects were not exported.
        
        Change-Id: If6e8c6e0d0c9917e8ec476ad14dcaa1602c74b29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146073
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150]

        Update skia to m111
        
        (*) Remove patches already upstream
        
        (*) Remove the skia_sk_cpu_sse_level_0_by_default.patch.1 patch and rather set
        that define via -D parameter, because that is how the skia BUILD.gn
        seems to do it.
        
        (*) I hand edited the PCH file, because running the update_pch script failed for me.
        
        Change-Id: I1fd175b9f63f8d2792a1876e4ece03fe92fb5374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146251
        Tested-by: Jenkins
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2c811e6f9c0b2de47153a70a783f4d808eab3ab]

        tdf#150534 reduce allocation in SdrFrameBorderPrimitive2D
        
        Change-Id: Ib55ce7882e87823cca95e00cb5ae990213d1e766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [db88842170a041267b55dda64f8280a1394202b8]

        tdf#150534 use unordered_set for checking of lines already crossed
        
        Change-Id: Ib864f9e8b7a3a2e6c4db5f2eec5333dc74bf9f6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146334
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Miklos Vajna  <vmiklos@collabora.com>  [66d235012c0c02db3b25f91a0fc981c66ed7388e]

        sw: add an initial SwFrame::GetNextFlyLeaf()
        
        To be called by SwFrame::GetLeaf() in the future.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I62f895c2db89513fe124113c81c9f14bfb8ed697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146337
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-30  Caolán McNamara  <caolanm@redhat.com>  [ea093514e4fc3a66f57e07486863c22e32db4245]

        crashtesting: crash in ReadQsiforum-mso-en4-30276.xls
        
        on duplicate names where during import an existing ScRangeData using the
        name is deleted on inserting a new one, leaving a XclImpName behind that
        still references the deleted ScRangeData. Reverse the order of lookup
        of XclImpName so we find the duplicate that references the valid
        ScRangeData first.
        
        likely also
        
        forums/xls/forum-mso-en4-69844.xls
        forums/xls/forum-mso-en4-69589.xls
        forums/xls/forum-mso-en4-69308.xls
        
        see also:
        
        commit 657b3c889ae107d9ccaaab569929a3a1abde3200
        Date:   Sat Jan 21 00:08:29 2012 -0500
        
            fdo#44831: Named range should overwrite existing name.
        
            When inserting a new named range, it should overwrite any existing
            name if one exists.
        
        Change-Id: I275663cacc34a2b85080c038dc5a199563f3547c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146310
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-30  Justin Luth  <justin.luth@collabora.com>  [441d0b0fb2eef890a465c061a3d68a07c4a51832]

        tdf#151548 sw content controls: actually gotoFormatContentControl
        
        The cursor kindof needs to change when going to a content control,
        so don't return early just because there will be no selection.
        Instead, set the cursor at the beginning of the control,
        and simply skip the selection part.
        
        Without this, it was not possible for the keyboard navigation
        to jump to rich/plain text or comboboxes that were no longer
        showing placeholder content.
        
        Change-Id: I055ece1d296c6cdf70d6bc7c1df7797bf09532c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146266
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-30  Justin Luth  <justin.luth@collabora.com>  [745650e2227bdf27fc322b357780a1aa3dc5fa73]

        tdf#151548 sw content controls: keyboard navigation with tab key
        
        Combine content controls with legacy formfield controls
        in keyboard tab navigation.
        
        MS Word (I tested 2010) is extremely irrational and inconsistent
        in its behaviour, so I modeled my implementation on the specification
        and general logic, and not at all on "compatible misbehaviour".
        
        There is a third category of form control (activeX rich content),
        but these are mapped to internal LO controls that are only exposed
        at VCL level, and don't pass the keystrokes back to SW.
        Plus, they are not inline, but fly controls.
        
        However, it is still a TODO to handle these if reasonably possible.
        
        Change-Id: I1fef34d05a779e9d4f549987238435acb6c043d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146219
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-30  Paris Oplopoios  <paris.oplopoios@collabora.com>  [70ff425141e3569bf09a6768ded3b8a7b0002bab]

        tdf#119229 docx: Set paraIdParent upon FN_REPLY
        
        Set the paraIdParent SwPostItField attribute when replying on an
        existing comment in Writer
        
        Change-Id: I33d89688d5a36a91b26a64cf4b0f605d7bf33b1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145750
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-30  László Németh  <nemeth@numbertext.org>  [30ca48f4dc0e65a3798e6b21574bc80f6d4953fa]

        tdf#152493 ucb WebDAV: fix upload using HTTP 1.0 fallback
        
        Fix broken libcurl upload to Vibe 4.0.6 WebDAV server
        using HTTP 1.0 fallback.
        
        Regression from commit 023ebf17898db4bca63129f079fd90b5cf76c1a9
        "ucb: remove --with-webdav=neon" (Neon had no such upload
        problem).
        
        HTTP 1.0 fallback found by Pál Zoltán Kochis.
        Fallback for CURLE_UNSUPPORTED_PROTOCOL
        suggested by Michael Stahl. Thanks for their and
        Attila Bakos' help.
        
        Michael Stahl's comment: "'HTTP/0.9' in the [curl] error
        message is very misleading: it simply means that a header
        was expected but there was no header, so what is received
        is interpreted as body.
        
        Note: the HTTP/1.0 works because it does not use the
        'Expect: 100-continue' so there should be no intermediate
        100 Continue response from the server at all - instead
        libcurl directly sends the XML document for the PROPFIND
        and the server sends the response, and the problem does
        not occur."
        
        Co-authored-by: Michael Stahl <michael.stahl@allotropia.de>
        
        Change-Id: I8bd79154de14b6425e0324f4d8f6e64512c08264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146067
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-30  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f41627ab60372345be646c53d967b65be43b562f]

        Show infobar instead of blocking dialog when macros are not allowed
        
        Change-Id: I45f898aaf15cb3540abff32954881186015cc6e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146250
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-01-30  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [43737fd5ddfad4c5e52f5244aef7a468d7aa8d15]

        Macro Infobar: Make it clear that macros are disabled and why
        
        Change-Id: I073d2eee84a571ded98cea492420eea74dcee747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146249
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-01-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [050ff677a4888ac039a913fedbe950bda2dc037d]

        tdf#150534 re-arrange Style class fields
        
        to eliminate hole, since we allocate a lot of them here
        
        Change-Id: I33181686287405592d3f93340601def10eaa3d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Noel Grandin  <noelgrandin@gmail.com>  [d33dbd8d3bee4dfd614ae0153ebca3db3948e9f8]

        no need to take SolarMutex when calling Idle::Start
        
        but it is wise to hold our own mutex while accessing our own field
        
        Change-Id: Ic66ab8dde5711e0a91b6c31cebf42a6066e638b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-30  Adoche Onaji  <dochieonaji@gmail.com>  [fea79733c5b98554b4b092a82c30137437db1d7a]

        tdf#143148 Use pragma once instead of include guards
        
        The headers in include/avmedia are changed to pragma once
        
        Change-Id: Id32159a291cbe2f18199e0e5b7e63b4feb2e591f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146312
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-01-29  Noel Grandin  <noelgrandin@gmail.com>  [ec4babad021218b75dfe8534985d7db525edde69]

        no need to lock SolarMutex over the whole method here
        
        Change-Id: Ifcac67c0f4e149fe7e1d923d7efede9552b034a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-29  Noel Grandin  <noelgrandin@gmail.com>  [6a26d47a79615c6b91b298937cdfee2f5294a58b]

        use std:mutex in PropertySetContainer
        
        instead of SolarMutex, we don't need to lock SolarMutex here,
        we are not touching any UI stuff
        
        Change-Id: I09f2dfd2c5e6e082066a726f8c6d64b4b136a78d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146307
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-29  Caolán McNamara  <caolanm@redhat.com>  [5583d5c71495402eeba568b36588cba345f4a623]

        ofz#55499 output buffer has to at least be the same size as input buffer
        
        Change-Id: Ie80b058673c47db11334554189ad878a884e26db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146306
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eff28a8a170759867916d7455b14e6a66a37daff]

        tools: rearrange Rectangle test, add construction test case
        
        Change-Id: I735600181665100e8540b6f5f14ffebfe6f33371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146305
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0119d00daa9713ada2b92e38adeb083c0bdcba64]

        svx: add prefix m to aPgOrg and rename to aPageOrigin
        
        Change-Id: I1df0c61aca724748680017472cde64832742eb97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146304
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-29  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [e2d646665c4cb4c7eeb0a73cb5f460838589bef0]

        lok: support per-user timezone
        
        This adds support for user-specific timezone.
        
        When none is provided during loading, the
        system default is used.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: Ie863450687eb82bc475268a09c9112e9fd50020f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144816
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        (cherry picked from commit abaf8c0af1c6c7fe01276fdf2ae62419c7b0f654)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146211
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-29  Stephan Bergmann  <sbergman@redhat.com>  [e3e259d551c0c8b7c106191f2c258e5929db1b29]

        UNO fn FormObjEventListenerImpl::documentEventOccured must lock SolarMutex
        
        When trying to address a deadlock issue involving NotifySingleListenerIgnoreRE
        (sfx2/source/doc/sfxbasemodel.cxx), I hit the DBG_TESTSOLARMUTEX at
        
        > DbgTestSolarMutex
        > SfxBroadcaster::RemoveListener
        > SfxListener::EndListening
        > CheckParentsOnDelete
        > SbxObject::~SbxObject
        > SbUnoObject::~SbUnoObject
        > SvRefBase::ReleaseRef
        > tools::SvRef<SbxObject>::operator=
        > SbUserFormModule::ResetApiObj
        > FormObjEventListenerImpl::documentEventOccured
        > (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator
        > comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>>
        > SfxBaseModel::postEvent_Impl
        > SfxBaseModel::Notify
        > ScModelObj::Notify
        > SfxBroadcaster::Broadcast
        > SfxApplication::NotifyEvent
        > SfxBaseController::dispose
        > (anonymous namespace)::XFrameImpl::setComponent
        > (anonymous namespace)::XFrameImpl::close
        > SfxFrame::DoClose
        > SfxViewFrame::Notify
        > SfxBroadcaster::Broadcast
        > (anonymous namespace)::SfxModelListener_Impl::notifyClosing
        > SfxBaseModel::close
        > SfxBaseModel::dispose
        > UnoApiTest::load
        > UnoApiTest::loadFromURL
        > VBAMacroTest::testVba
        
        during CppunitTest_sc_vba_macro_test, which this commit fixes.  (I commit this
        independently of any commit addressing that deadlock, as that involves some
        SolarMutexReleaser hackery and might eventually get reverted, while this change
        here looks correct and worthwhile even on its own.)
        
        Change-Id: I4217098c33114653cd69f4bef61c9f8089ce8b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146302
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [32f76ba4dc73586fa5c8237a71eddd2460d0fbe8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7fc1be9c61cf8d19c7982dc6a407b7eca2ad5b93
          - Update Autofilter help page
            
            + Autofilter options were changed, the patch synchs with current menu
            + Missing bookmarks for filtering by color
            
            Change-Id: I96d5af98dd9c70bfd4e8c376891b67dbd5853767
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146299
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-29  Gökay Şatır  <gokaysatir@collabora.com>  [5f489f84935b4f92415998bb7ba2d9ccd550b82d]

        Add dropdownfielddialog.ui to JSON dialogues.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I4cfc792f0b1269936723285cc5ff1324bc22c161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145871
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 23e6f05a8ee80c33dd624dd6582f26b3dcf8f490)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146212
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-29  Mark Hung  <marklh9@gmail.com>  [4e6601cf1b99c1aa52934388e9cefd527389cf80]

        tdf#124230 export subTnLst for event triggered nodes.
        
        LibreOffice export all the child nodes of a timenode
        to childTnLst. It seems that PowerPoint anticipate there
        being fixed starting-time timenodes on childTnLst.
        This patch export event-triggered audio time nodes to
        subTnLst to make audio playback work. Other node types can
        be added in the future once more test cases are found.
        
        Change-Id: Ic96ec50876f568145bdde122d01dec10c1ac7c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146295
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-29  Mark Hung  <marklh9@gmail.com>  [f640a0c5d295368e5c0e3247b3039054cccad7da]

        sd/filter/pptx-animations: store condition in NodeContext.
        
        Change-Id: I80cc7209f5347562560590554a8aa9a61e410179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146294
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-29  Seth Chaiklin  <sdc.blanco@youmail.dk>  [16559f0b79ccb0386bbc5ae2a761a0e16a32c325]

        tdf#153243 simplify "Numbering Captions by Chapter" label
        
            Remove "Captions" because not needed in context.
        
            For:
               - Insert - Caption - Options dialog
               - Tools / Options / Writer / Autocaption dialog
        
        Change-Id: I97e64887026dd798cdec58cbca93d73c21515ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146207
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-28  PL  <pluby@guibomacbookpro.local>  [620ad1b7ae06d6f053fb2c9b57af96b736c04e57]

        Related: tdf#145988 Reset layer's pixel format to MTLPixelFormatBGRA8Unorm
        
        Skia initally sets the layer's pixel format to be BGRA8888 but macOS
        may change the layer's pixel format when a window has moved to a screen
        with 30-bit color depth so reset it back to BGRA8888.
        
        Change-Id: I1ad47a31e41aaa197e3052146243882e0b4ef673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146301
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-28  Rasenkai  <rasenkai99@gmail.com>  [0e09fff5f89b38245b108edb67d5e75e57774874]

        tdf#145614 chart2: controller: Convert #define to enum
        
        Rename CommandID to DrawCommandID
        
        Change-Id: I4bef2cc030e5b326589b08e22f3dd427772fc79f
        Signed-off-by: Rasenkai <rasenkai99@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146268
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-01-28  Tor Lillqvist  <tml@collabora.com>  [18d2c7e82dbbe708925588d101e7c59a5b9327a1]

        Avoid compiler warning
        
        Change-Id: I322b2c0ea14bbf8ed2fe1a306c0ed28f5e5ae258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136875
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        (cherry picked from commit ece304df9ad2aa0f974927320a1324c06b89f337)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146076
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-28  Andras Timar  <andras.timar@collabora.com>  [d95ac1c608caba9cabaa503f1a5589285547aed5]

        LOK: Allow image upload from WOPI-like host with self-signed cert
        
        Change-Id: I28a7de489b06fd5a993b82bb39274eb6f0c373ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146298
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-28  Andras Timar  <andras.timar@collabora.com>  [fa29398e98f01001c24e7d6856179dbf8124e5b6]

        Fix 'Architecture' string on ppc64le platform, Debian uses 'ppc64el'
        
        Change-Id: Idb678ac2669914575d3ddb813d35212df26e3d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146297
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-28  Mark Hung  <marklh9@gmail.com>  [55d4dc3a6b955e54ee73bc81807552a3b4d4a279]

        sd/pptx-anmiations refactor NodeContext.
        
        Change-Id: I6439882884b3808dec91eaaede50856b0afdd278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [000d88c53a60da1a12ff7c5feae9f21b940b72c5]

        Use ImplInheritanceHelper in SvxRectCtlChildAccessibleContext
        
        Change-Id: I1e8fd8a9457925af7278e8006e7ad331f612b3ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146285
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Mark Hung  <marklh9@gmail.com>  [0a55335ef3b91bbf573f6e5eaa4241d14a15a4ee]

        sd/filter/pptx-anmiation refactor Cond class.
        
        Change-Id: Iffb0eeb1454a858987680d402add3f5122f7b6db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [a434653fd46828d152d0256738c24adb63530330]

        Use ImplInheritanceHelper in SvxRectCtlAccessibleContext
        
        Change-Id: I864a1c2571ce8642626d77b726f2fa6dfbdadf2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146284
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [71b797dda8ea5cd579b8402c2f3ad3c803fb8986]

        Use ImplInheritanceHelper in SvxPixelCtlAccessibleChild
        
        Change-Id: I09d7004d6cf268831725435c5e634dedfa385a7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146283
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [c6dcbf93577632fdd6ecc1d94ab1642143c6bbca]

        Use ImplInheritanceHelper in SvxPixelCtlAccessible
        
        Change-Id: I9509bfcbcc015876cba1c17e84e4de5e28de3cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146282
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [64716d41e2e6c74dea1762bb59ea5485c265557b]

        OAccessibleHelper_Base_2 is unused
        
        ...ever since 374599f8c26713905a310673d2b429083321186a "weld SvxCharacterMap
        dialog"
        
        Change-Id: I955a399756c2802295168e07dfdfe30f1515a64c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [c2f14c9a0aa07c36446ea308b9192248e4c6213d]

        Use ImplInheritanceHelper in SvxShowCharSetItemAcc
        
        Change-Id: I0baaac510afcbae5a8a9fa5886daa8b4f83145e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146280
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Mark Hung  <marklh9@gmail.com>  [28f3aeff99fa635f7d59ab88f1f41ff6a036bebb]

        sd/source/filter refactor pptx animation export.
        
        Refactor "Any NodeContext::getCondition(bool bBegin) const" to
        "const Reference<XAnimationNode>& NodeContext::getNodeForCondition()
        const", to get rid of the bool arguement of getCondition.
        
        Change-Id: Ic61d2caecaad2d3ada38556346f66aedb258e554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [131904c23ab539a3eb2aba5467cbbeee0650632b]

        Use ImplInheritanceHelper in SvxShowCharSetAcc
        
        Change-Id: I9009b6168c66a1b340a34aaf804e097bfe614d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146279
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [e71c718426e4f5694df04c91d391c7d064573b34]

        Use ImplInheritanceHelper in AccFrameSelectorChild
        
        Change-Id: Idab295d97650b158c34f0a11be79c932540e7526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146278
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [5b77e5fa5a1b63b76fe82f4b8e96bad7a7af51ab]

        Use ImplInheritanceHelper in AccFrameSelector
        
        Change-Id: Iff6dc76c4fdc105127cde23ae478011da6ff6483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146277
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [28b7b783202d251f43658b2ff1d8df3f10d6d1b8]

        Use ImplInheritanceHelper in ScAccessibleCsvCell
        
        Change-Id: I46e9985fe3bb05dc677b4046b3cad18dea1086b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146276
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [ec68d4bb894882835aed28cee8537481afd0e302]

        Use ImplInheritanceHelper in ScAccessibleCsvGrid
        
        Change-Id: I1713fb24ed16ef9db6d2815a286d4182f19a5e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146275
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [154035563590181d096d8eccf0f549f314ddecde]

        Use ImplInheritanceHelper in ScAccessibleCsvRuler
        
        Change-Id: I24b64a97e5431d1d25d2894c6e2ae41ec13245c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146274
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [bbe63da41a2e6cd877fccf76bd57c66ab81cf3e9]

        Use ImplInheritanceHelper in OTableWindowAccess
        
        Change-Id: I4677b9f5e3fe21c6ff80e20bbb7b6befca9f99ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146273
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [5a704330ae63edf60bd33900abe71c4ea6a7eb3d]

        Use ImplInheritanceHelper in AccessibleDialogControlShape
        
        Change-Id: Icc6ebfc0f2285f8f281abe2240f56300d4ed7f2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146272
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [8bf1ba09408d42dbc0798aedb96ab387353f9eed]

        Use ImplInheritanceHelper in OJoinDesignViewAccess
        
        Change-Id: Ib67e03aeea4df67fc7a7b5db5d8cfdd9e57f87f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146271
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [03ac752ca513305cb7504f5bfda701d93e2179f0]

        Use ImplInheritanceHelper in OConnectionLineAccess
        
        Change-Id: Ib9b1f2c4dc9a8b6190ccfcffbf25e270d5322050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146270
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [713faaa6519b7f6099eb97cfa458215c379192e7]

        Fix typo
        
        Change-Id: I45f5252291875b8e3dbf8f39f304e3a3f77a9f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146289
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-28  Stephan Bergmann  <sbergman@redhat.com>  [c527721a031fdbb16e2978dd6c5c41dd2d70f9d6]

        Use ImplInheritanceHelper in AccessibleDialogWindow
        
        Change-Id: I3f453f49ff2c2bde6bbedf44bf934c5016d655d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146269
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-28  Hossein  <hossein@libreoffice.org>  [5fa078413ede313aed2ba41c3c57e8e13e4eb847]

        Make minvcl and svdemo VCL examples build on Windows
        
        Previously, minvcl and svdemo VCL examples were not built on Windows.
        With this patch, both of the minvcl.exe and svdemo.exe are built on
        Windows. To run, one can invoke:
        
          ./bin/run minvcl
        and:
          ./bin/run svdemo
        
        Change-Id: I43bfb314b41c662250615486a3ca783fc6d82600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146264
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [312f83bcf52d2f681eb9fa1bbdbb98bfd063a3b4]

        introduce XTheme and UnoTheme implementation
        
        Needed to transprt model::Theme around using throught UNO API as
        xmloff can't access SdrPage directly.
        
        Change-Id: I5931e42352186d62e7f09b112d8e8c9e4fb79440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146224
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-28  Hossein  <hossein@libreoffice.org>  [10c340c2b59dd677d6f598901506b08ff2cbd49c]

        Add exception handling to minvcl, minify code
        
        Improve minvcl example:
        
        * Add exception handling
        * Minify code by removing custom Window
        
        Change-Id: I1f1dc10c05812b4cfad7d38e09d7ecd26bec35b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143650
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5e193d854596db714ca786c2a676b5ac9684d5eb]

        JobURL does not need to use the SolarMutex
        
        it is only used and accessed as a local stack variable inside two
        methods
        
        Change-Id: I651dad0912dd47d3670e7b341d444d17e200efc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146260
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbb8e0f40771154796bca5277cbd494a689599de]

        JobResult does not need to use the SolarMutex
        
        it is literally only used inside a single method
        
        Change-Id: I01082270208b9e6c9bbaae0e7edf66f5e171a280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146259
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-27  Michael Stahl  <michael.stahl@allotropia.de>  [bb733957dd39e6f0b9d80bb59eb0177188794797]

        tdf#114973 sw: enable SelectAll with hidden para at start/end
        
        If there's a hidden para the shell cursor can't be positioned in it
        ordinarily, so SelectAll will exclude these at the start or end of the
        document.
        
        There is already special code to handle a table at the start of the
        document body, and it's relatively simple to adapt it to handle hidden
        paragraphs as well.
        
        This appears to work surprisingly well, the point is at the start of the
        first node of the document, and moving it right immediately puts it to
        the first non-hidden paragraph.
        
        But it only works for paragraphs hidden by character formatting or
        hidden paragraph field, not if there's a hidden section - there are no
        (not even 0-height) SwTextFrames in hidden sections.
        
        Change-Id: Ifd3c11f4169a037fdae2c2b376d0138bec46774f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146257
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-27  Michael Stahl  <michael.stahl@allotropia.de>  [5aeee226479427062ac885be407671981d6940ef]

        tdf#114973 sw: IsSelOvr() should not leave the text
        
        Jumping from body to header is certainly unexpected, call FindNextCnt()
        which does additional checks to stay in the same text environment.
        
        Change-Id: If54bff62cac420dc0990b6be070b81fa56365c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146256
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-27  Jean-Pierre Ledure  <jp@ledure.be>  [96302e0bbadfe3ed33af4a14a33a44bab3f5f0d4]

        ScriptForge (SF_Document) Echo() method freezes screen updates
        
        While a script is executed any display update
        resulting from that execution is done immediately.
        
        For performance reasons it might be an advantage
        to differ the display updates up to the end of the script.
        This is where pairs of Echo() methods to set
        and reset the removal of the immediate updates
        may be beneficial.
        
        Optionally the actual mouse pointer can be
        modified to the image of an hourglass.
        
        Arguments:
          EchoOn: when False, the display updates are suspended.
                  Default = True.
                  Multiple calls with EchoOn = False are harmless.
          Hourglass: when True, the mouse pointer is changed
                  to an hourglass. Default = False.
                  The mouse pointer needs to be inside the actual
                  document's window.
                  Note that it is very likely that at the least
                  manual movement of the mouse, the operating system
                  or the LibreOffice process will take back
                  the control of the mouse icon and its usual behaviour.
        
        The method may be called from any document, including Calc and
        Writer, or form document.
        
        It may be invoked from Basic and Python user scripts.
        
        Echo() should be documented in the sfdocument.xhp help page.
        
        Change-Id: I4d669f5e332131bd1b2efcd33b7a98b304796ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146258
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [46becac127859a742e1f702bcde718304efcde69]

        AcceleratorCache does not need to lock the SolarMutex
        
        it is only used by the *AccelerationConfiguration classes, and they lock
        the SolarMutex around all accesses to this data.
        
        Change-Id: I07de415bae9e0aff679f693022b9181971f19bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146254
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [943b58c9577c4e43c04fb2df81203af3fd0da433]

        Remove SolarMutex usage from framework::JobData
        
        the data in question is only touched from one thread, so it does not
        need any locking.
        This seems have been since this class was first introduced.
        
        Change-Id: Ife9f9ea015e2ae263e699a38d504a49aaf21c803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146253
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [98f9b51d5878e7a426c1244177d16f49ce639ae4]

        Split long-running CppunitTest_sc_opencl_test in two
        
        At least the unrelated
        <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132372/> was killed
        after 20 minutes of no stdout/-err activity, with CppunitTest_sc_opencl_test
        still running.  From its captured state, it looks like it was indeed still
        making progress rather than being stuck:  During
        ScOpenCLTest::testLogicalFormulaXor, the main thread was waiting at
        ScFormulaCell::InterpretFormulaGroupThreading ->
        comphelper::ThreadPool::waitUntilDone, while four
        comphelper::ThreadPool::ThreadWorker threads were each at
        
        > #4  0x00007f70652f9234 in __gnu_debug::_Safe_iterator_base::_M_detach() () at /lib64/libstdc++.so.6
        > #5  0x00007f7048d3e8e5 in __gnu_debug::_Safe_iterator_base::~_Safe_iterator_base() (this=0x7f703daa9f20) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_base.h:100
        > #6  0x00007f7048d5d709 in __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<mdds::mtv::base_element_block* const*, std::__cxx1998::vector<mdds::mtv::base_element_block*, std::allocator<mdds::mtv::base_element_block*> > >, std::__debug::vector<mdds::mtv::base_element_block*, std::allocator<mdds::mtv::base_element_block*> > >::~_Safe_iterator() (this=0x7f703daa9f18) at /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_iterator.h:86
        > #7  0x00007f7048d5d6cd in mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait>::grouped_iterator_type::~grouped_iterator_type() (this=0x7f703daa9ec8) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:74
        > #8  0x00007f7048d5d69d in mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait>::~iterator_updater() (this=0x7f703daa9e98) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:55
        > #9  0x00007f7048d5d665 in mdds::mtv::soa::detail::const_iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::const_iterator_trait, mdds::mtv::soa::detail::iterator_base<mdds::mtv::soa::multi_type_vector<sc::CellStoreTraits>::iterator_trait> >::~const_iterator_base() (this=0x7f703daa9e98) at workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/./iterator.hpp:309
        > #10 0x00007f704900b9bd in ScValueIterator::GetThis(double&, FormulaError&) (this=0x7f703daaa078, rValue=@0x7f703daaa1f8: -18.819375178914722, rErr=@0x7f703daaa1f6: NONE) at sc/source/core/data/dociter.cxx:141
        > #11 0x00007f704900c652 in ScValueIterator::GetNext(double&, FormulaError&) (this=0x7f703daaa078, rValue=@0x7f703daaa1f8: -18.819375178914722, rErr=@0x7f703daaa1f6: NONE) at sc/source/core/data/dociter.cxx:297
        > #12 0x00007f70496c3619 in ScInterpreter::ScXor() (this=0x48b93a0) at sc/source/core/tool/interpr1.cxx:1525
        
        with three of them apparently waiting in pthread_mutex_lock but one in
        pthread_mutex_unlock (and thus presumably making progress).  It looks like with
        a debug-mode libstdc++ these worker threads can easily compete for these
        listdc++-internal debug-mode mutices.  And execution of --enable-dbgutil
        CppunitTest_sc_opencl_test on my Linux laptop under load easily took 35 minutes,
        so it looks plausible that that unit test was just too big.
        
        While splitting it in two (arbitrarily taking the first and second half of the
        CPPUNIT_TEST list), use the opportunity to drop the redundant "_test" from the
        two new target names CppunitTest_sc_opencl-1 and CppunitTest_sc_opencl-2.
        
        Change-Id: I9b8f148db667ff9bbf1aacdcaf150e5cb9b8ae87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146252
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Miklos Vajna  <vmiklos@collabora.com>  [a6b64d02843d186485ff5c82106e6f9268a539c7]

        sw: add an SwFlyAtContentFrame ctor that creates a follow fly frame
        
        This is meant to be a called by a future SwFrame::GetNextFlyLeaf()
        (similar to the existing SwFrame::GetNextSctLeaf()), which still has to
        be added.
        
        What an anchor should be for a follow fly frame is a bit unclear to me,
        let's go with an explicit nullptr for now and we can clarify that later.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I2429f47aef90dfe61340bfe244353dcefeb4ef1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146244
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [5d4adec9e0c3edca15867aac19ff6d2c0983959f]

        Move a UNO service creation outside a guarded area
        
        When trying to address a deadlock issue involving NotifySingleListenerIgnoreRE
        (sfx2/source/doc/sfxbasemodel.cxx), I ran into another deadlock between a
        cppu_threadpool thread at
        
        > comphelper::SolarMutex::acquire
        > osl::ClearableGuard<comphelper::SolarMutex>::ClearableGuard
        > SolarMutexClearableGuard::SolarMutexClearableGuard
        > SfxModelGuard::SfxModelGuard
        > SfxBaseModel::getIdentifier
        > (anonymous namespace)::ModuleManager::implts_identify
        > (anonymous namespace)::ModuleManager::identify
        > (anonymous namespace)::JobExecutor::notifyEvent
        > (anonymous namespace)::SfxGlobalEvents_Impl::implts_notifyJobExecution
        > (anonymous namespace)::SfxGlobalEvents_Impl::documentEventOccured
        > (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator()
        > comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >
        > SfxBaseModel::postEvent_Impl
        > SfxBaseModel::Notify
        > ScModelObj::Notify
        > SfxBroadcaster::Broadcast
        > SfxApplication::NotifyEvent
        > SfxObjectShell::SetInitialized_Impl
        > SfxObjectShell::FinishedLoading
        > ScDocShell::Load
        > SfxObjectShell::LoadOwnFormat
        > SfxObjectShell::DoLoad
        > SfxBaseModel::load
        > (anonymous namespace)::SfxFrameLoader_Impl::load
        > framework::LoadEnv::impl_loadContent
        > framework::LoadEnv::start
        > framework::LoadEnv::startLoading
        > framework::LoadEnv::loadComponentFromURL
        > framework::Desktop::loadComponentFromURL
        > gcc3::callVirtualMethod
        
        and the main thread at
        
        > osl::Mutex::acquire
        > osl::Guard
        > (anonymous namespace)::JobExecutor::trigger
        > desktop::Desktop::AsyncInitFirstRun
        > desktop::Desktop::LinkStubAsyncInitFirstRun
        > Link<Timer*, void>::Call
        > Timer::Invoke
        > Scheduler::CallbackTaskScheduling
        > SalTimer::CallCallback
        > SvpSalInstance::CheckTimeout
        > SvpSalInstance::ImplYield
        > SvpSalInstance::DoYield
        > ImplYield
        > Application::Yield
        > Application::Execute
        > desktop::Desktop::Main
        
        which this commit fixes.  (I commit this independently of any commit addressing
        that other deadlock, as that involves some SolarMutexReleaser hackery and might
        eventually get reverted, while this change here looks correct and worthwhile
        even on its own.)
        
        Change-Id: I2530569c6661e440126db04fa19a655d52e20094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146242
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Caolán McNamara  <caolanm@redhat.com>  [1371ba2bcbcce57ba5cbd7a199ae8feceb22d0d0]

        crashtesting: crash on forum-mso-en4-719754.xlsx with fPercentile ~== 1
        
        input is fPercentile of near 1 where approxFloor would give nIndex of
        nSize-1 resulting in a non-zero tiny negative fDiff, when the assumption
        is fDiff will be 0 or some positive value.
        
        Change-Id: I8fe5520f2b3c68f3204d435337df527185dcb0d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146218
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [4499db6b901a0c4eaad652a3efb5ad2857523c02]

        Use ImplInheritanceHelper in VCLXAccessibleToolBoxItem
        
        Change-Id: I380d8ae6dd237c0d09209c71dfdcf7b1ad995fb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146241
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [3f39e4b674089a9243064e1204e1d9c67f7b2bd8]

        Use ImplInheritanceHelper in VCLXAccessibleToolBox
        
        Change-Id: I3b37cd67d6d32001ae6ac72f01ce156aeb93ca7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146240
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [148caa36121ddc37b18226308cec0e7f535477de]

        Use ImplInheritanceHelper in VCLXAccessibleTextField
        
        Change-Id: Ie6b9fd7d825940d090f76b23597c40d8cbbca7c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146239
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [cf38f560d0e5a46edd79f28db5284e32a3679dbc]

        Use ImplInheritanceHelper in VCLXAccessibleTabPage
        
        Change-Id: Ia1b4df33d426265d5eb6f0b77c531ab3b53ea3d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146238
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [b1883a0ff9f8e62a83bdcc94f4ff0dd01b2a56d6]

        Use ImplInheritanceHelper in VCLXAccessibleTabControl
        
        Change-Id: I9426bac6b26feaa555842142dd3ce62bbe5f4a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146237
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [90a64d3ca1fdf75df1dcebebbd250e09b21cc7bf]

        Use ImplInheritanceHelper in VCLXAccessibleStatusBarItem
        
        Change-Id: I7ec38650b0ef44b59b57bd64ba74fcac918f8b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146236
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [c1b17b0e9191901e8110ef14acce86c810a11491]

        Use ImplInheritanceHelper in VCLXAccessibleScrollBar
        
        Change-Id: I8702abb22d14eb88655a1a133ecce8140b0cd4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146235
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [d3080dc586b2cdaaf56d9fa1172488b4901fb7db]

        Use ImplInheritanceHelper in VCLXAccessibleRadioButton
        
        Change-Id: If07a07cf4e6fa465d1d6d3e52abe550922edeb6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146234
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [435cc6f4b2d61df932a1006222b699e367e4fed7]

        Fix typo
        
        Change-Id: I9c643c7d0ffe4b8b3360313d6d937a94d4d78d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146245
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-27  Caolán McNamara  <caolanm@redhat.com>  [502b26b8f9a3d6e1252ff142fd00a3096ce95962]

        crashtesting: assert seen in forum-mso-en4-192558.xlsx
        
        assert is assert(rRange.aStart.Tab() == rRange.aEnd.Tab());
        
        sheel 1 cell E6 contains =IFERROR(VLOOKUP(D6,a6:'sheet1'!b495,3,FALSE()),"")
        note: sheel 1 E7 is      =IFERROR(VLOOKUP(D7,$Sheet1.A7:Search.B499,3,FALSE()),"")
        
        aRef.Ref1.Tab() and aRef.Ref2.Tab() are the same, but IsTabRel differs,
        so the input address with a tab 1 results in an output range with start
        and end of different tabs.
        
        do the comparison with the result range, by analogy do the same
        adjustment in ScGroupTokenConverter where the comparison was introduced
        for
        
        commit ca1f051972946b24cb6658143fb0d0ac3587a988
        Date:   Fri Mar 10 18:32:27 2017 +0100
        
            Resolves: tdf#106459 3D reference can't be handled as vector reference
        
        and basically copied and pasted here.
        
        FWIW in forum-mso-en4-192558.xlsx the original formulas in xlsx are:
        IFERROR(VLOOKUP(D6,A6:'Sheet1'!B495,3,FALSE),"")
        IFERROR(VLOOKUP(D7,A7:B499:'Sheet1'!B496,3,FALSE),"")
        
        Change-Id: I69e3ca2f89008b81500789b1bca39b35685de8d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [2f7dee3a2dd6c8696fc2929275fb6ab05b44a30d]

        Use ImplInheritanceHelper in VCLXAccessibleMenu
        
        Change-Id: Ia086713b06cd9525e5bb03e74a1908bdd6058b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146233
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [969b3f1e5416bfbec8d8bf2871a8176393ddaa22]

        Use ImplInheritanceHelper in VCLXAccessibleMenuItem
        
        Change-Id: I0eca36225c2a43e2ba90253c013fefe43b2f29a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146232
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0b1d6220c6ece62653963ef782ee32efb639016e]

        tdf#153235: Optimize Application::Reschedule calls in SbiRuntime::Step
        
        Setup the "last reschedule time" counter at the first pass,
        to avoid useless immediate reschedule.
        Update the counter when running "when blocked" reschedules.
        
        This seems to avoid the problem with the bugdoc.
        
        Change-Id: Ib5958a1a2b048f5ec654c69ee9e977e8a26de6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146215
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6de8eac453b11d5fcfd823ac926521a5e398f9d]

        fix online crash in SpellDialog
        
        program/libmergedlo.so
           EditEngine::GetUndoManager()
           /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
        program/libcuilo.so
           svx::SpellDialog::InitHdl(void*)
           cui/source/dialogs/SpellDialog.cxx:2016
        program/libmergedlo.so
           ImplWindowFrameProc(vcl::Window*, SalEvent, void const*)
           include/rtl/ref.hxx:128
        program/libmergedlo.so
           SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent)
           vcl/headless/svpinst.cxx:317
        
        Change-Id: Icd79faea8b066e0725c5d96f5d9b64445578f3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146091
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-27  Justin Luth  <justin.luth@collabora.com>  [52d5f2e247e6b0a638fc0ec83f5dbc1cca30d1cd]

        tdf#151548 sw content controls: preserve tabIndex val="-1"
        
        Either we have to read sal_uInt32
        (which I can't figure out how to do)
        or else we have to write it out as sal_Int32.
        
        Microsoft isn't much help here because their documentation
        does not give any example of a non-tabsltop,
        and one errata document indicates that MS Word
        simply ignores tabIndex altogether for Sdt (and ffData).
        
        According to the documentation,
        tabIndex is a CT_UnsignedDecimalNumber
        which we do not have in our model.xml
        so it was defined as being a CT_DecimalNumber
        which works fine for reading something human sensible like -1.
        
        However, in our exporting we were exporting a sal_uInt32
        which creates large, all positive numbers
        which were not being read on import.
        Nothing I tried worked to read these large numbers.
        Perhaps it is even illegal to do so in MS formats?
        
        Since it doesn't seem to matter to MS Word,
        and for a human it is easier to understand -1,
        and it is easier to solve in export than import,
        I'm taking the easy road.
        
        Change-Id: I6b296703c9a37149d9e11f29901e6db32bd041b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146149
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-27  Kohei Yoshida  <kohei@libreoffice.org>  [edcfb4632a514c5595540d69f7b217b4a12bac5c]

        tdf#146260: Add more mapping rules on character encoding
        
        Change-Id: I0f6f3abf96312132fbb1cfaaf1ee53a60710cdd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [f43e882629b8027b13370514b3a0b277707a3c2c]

        Remove Solaris 32-bit SPARC and x86 C++ UNO bridge implementations
        
        As discussed in the mailing list thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html>
        "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)",
        the bridge implementations at bridges/source/cpp_uno/gcc3_solaris_intel and
        bridges/source/cpp_uno/gcc3_solaris_sparc are apparently dead and should thus be
        removed.  Those were the only bridge implementations for Solaris, but the
        referenced thread mentions that there are recent builds for OpenIndiana x86-64
        (however they are done; presumably using
        bridges/source/cpp_uno/gcc3_linux_x86-64), so keep general support for Solaris
        intact for now.
        
        Change-Id: I09ec098f5509f25a126342536745509bbe9faaac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146059
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [8ef01413f6522fe47494b3c1d46d633f1d34e297]

        Remove support for 32-bit S390
        
        As discussed in the mailing list thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html>
        "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)",
        the bridge implementation at bridges/source/cpp_uno/gcc3_linux_s390 is
        apparently dead and should thus be removed.  However, that was the only bridge
        implementation for 32-bit S390, which implies that support for the 32-bit S390
        architecture as a whole is dead and should thus be removed.
        
        Change-Id: I18b3b4fa11df4ce693107bad6bbea2fab1c19f26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146058
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [c5224a49fde004e36454da459c7d91a6905c1110]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3f1a7bccd67dbefd2135aca2426f52523673832
          - Remove support for AIX
            
            This is a companion to <https://gerrit.libreoffice.org/c/core/+/146057> "Remove
            support for AIX".
            
            Change-Id: I705f7bf702e9080dd850518b492c8a7be7e325d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146063
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2023-01-27  Stephan Bergmann  <sbergman@redhat.com>  [70bcf9e8bea1fee9cca44437730324ba7805b633]

        Remove support for AIX
        
        As discussed in the mailing list thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089808.html>
        "Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)",
        the bridge implementation at bridges/source/cpp_uno/gcc3_aix_powerpc is
        apparently dead and should thus be removed.  However, that was the only bridge
        implementation for AIX, which implies that support for the AIX platform as a
        whole is dead and should thus be removed.
        
        Change-Id: I96de3f7f97d4fd770ff78256f0ea435383688be9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-27  Miklos Vajna  <vmiklos@collabora.com>  [12a5e9bd92c0969051e035a4f2b7c18f0e3e79b5]

        sw: avoid copy&paste in SwFieldPortion::dumpAsXml()
        
        Improve SwFont::dumpAsXml() a little, then we can just call it.
        
        Change-Id: I581445230cd0732819e1bbb45727cf59231c5f47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146191
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f7544650cc4e31da67873898e2d587afa846b9b4]

        tdf#151682 Fix gap above input bar
        
        Remove vertical offset, looks like it's not needed anymore.
        
        Change-Id: If0f7f7dce7a7e4249036930b60fe353890b495fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146179
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2023-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c9fb441c55d03f55877ed3bb2f5c39310d1ec44b]

        move Theme class to own file inside docmodel
        
        Also move Theme from svx to model namespace so it is consistent
        with other classes in docmodel.
        
        Theme header also includes ThemeSupplementalFont, ThemeFont,
        FontScheme classes that are used by the Theme and were also moved
        to docmodel. These may be moved to its own file in the future when
        they are used in more places.
        
        Change-Id: Ic409bea8e5298adc2b039b529c4f7b01cf64f03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146221
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [69c6f7bccec838b7288a25a29a83b7f782ba7586]

        move ColorSet class to own file inside docmodel
        
        Also move ColorSet from svx to model namespace so it is consistent
        with other classes in docmodel.
        
        Change-Id: Iacbdbdf5ece4015c628a0e45adf6a732b2d27777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146220
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9cbc3a64492e0670427f17b753d0908657c8c5bd]

        use ThemeColorChanger also in svx, when changing theme for SdrPage
        
        This refactors the code in the Theme class to remove code that is
        responsible for changing the color for the SdrPage and adds an
        implementation of IThemeColorChanger - svx::ThemeColorChanger,
        that is performing the same task from now on.
        
        The svx::ThemeColorChanger is also partially used in Writer by
        sw::ThemeColorChanger, when it needs to change the colors in the
        common (Sdr) objects.
        
        Change-Id: I39cfa278d31bdd802a5bf36eeaf6d472c8013dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146173
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6d1413da02602992b42b62bda9a26ffeb774b603]

        xmloff: export Theme for ODT (Writer) documents
        
        Exports the Theme set on the one and only SdrPage for ODT (Writer)
        documents. The theme is exported as a sub-element of "style".
        This differs to ODP (Impress) documents, which export the Theme
        as part of the master-page element.
        
        Currently the code is duplicated, because the theme can't yet be
        accessed inside xmloff in a non-conflicting way (creating conflicts
        between modules), which will be fixed in the future.
        
        Change-Id: I0e440d14724b49e7d86e9deabc6615a91e8cd31a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146172
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-27  Kohei Yoshida  <kohei@libreoffice.org>  [14c0efccba84a002050d081c961bb0b6e90b009f]

        tdf#147620: Pick up wrap-text and shrink-to-fit flags in Excel 2003 XML
        
        Change-Id: I8afd0522b441a90b431ff433ff87e0c095c8cb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146222
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-01-26  Mike Kaganski  <mike.kaganski@collabora.com>  [7c3ea0abeff6e0cb9e2893cec8ed63025a274117]

        Simplify SbiRuntime ctor
        
        Change-Id: I18309ed4ed8ebb31b3bf9ffc676a2d501e2593b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146214
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-26  Mike Kaganski  <mike.kaganski@collabora.com>  [6128d8379a29bb8ce50e34bfb4c7627459c2d796]

        Simplify a bit
        
        Change-Id: I970feb9897018c69173b899392484a2818c184f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146193
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-26  Mike Kaganski  <mike.kaganski@collabora.com>  [e6120153b7fc455ac7979f17236dcb877ad8929c]

        Simplify a bit
        
        Change-Id: Ib3507d5083116fc621def9c8168c95267a914bed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146192
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [d690ae975f33f48ed66d6aacc6d1aba8fad86eb8]

        ofz#54906 Timeout
        
        Change-Id: I87a59723566c561cf84f5b5fb74bd8cf30801d16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146217
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [4986d195c3100655ec2770e8f9d2e2c642d9b371]

        Use ImplInheritanceHelper in VCLXAccessibleList
        
        Change-Id: I2412ef089b5b299b131916d21afa5c5d4fd74c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146190
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [57f103f15895ecd6e1882652206add0c1ed6a3c9]

        Use ImplInheritanceHelper in VCLXAccessibleHeaderBarItem
        
        Change-Id: I18b54a3cd689aaf4870c073db8d76d41661a05c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146189
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [df4f438e74c444539dcb6dea2ab6c286af155fbf]

        Use ImplInheritanceHelper in VCLXAccessibleCheckBox
        
        Change-Id: I6cb7926db61590a356db7c55eeda94053dbf189f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146188
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [7c63d968bb0c4e1df25bc39e64574326cf83d4ec]

        Use ImplInheritanceHelper in VCLXAccessibleButton
        
        Change-Id: Ia5c384e7ae4b78e008836fafc5433accd8489f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146187
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Tibor Nagy  <nagy.tibor2@nisz.hu>  [e8335bac5690b6beccb5ca9b36281c89fb2f28f5]

        tdf#153107 OOXML export: fix scale of tile of shape background
        
        Relative scale values were exported as absolute values,
        resulting broken shape background.
        
        Change-Id: Ia38e125862e7f8ceff5d41754340723c3a9eb028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145996
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b0b6e5232585c3756c94ae15ae695eaa1f4fbe1]

        UITest_writer_tests7: improve test a bit
        
        To see where the problem might be
        
        Change-Id: I0baed63408c96eddffbaa39e172bc922c0a78241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146180
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [1bc2be265c528cebc0f3bf33b217edc46af56ff0]

        Use ImplInheritanceHelper in VCLXAccessibleBox
        
        Change-Id: I8763463a2fd85a528870d140051dd9fb49aea608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146186
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [e547fb841d242ed3bd33623c4a1dc4cdb0e239a8]

        Use ImplInheritanceHelper in SVTXAccessibleNumericField
        
        Change-Id: I9d9b6a6d7cbd89983cbe803511b59226330ae9e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146185
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [fd92a175b5bbb5cb1e0a5188630d9872276a545a]

        Use ImplInheritanceHelper in VCLXAccessibleEdit
        
        Change-Id: Ia81117c1819b4d3b5791a0d8ca66d79a26a3c9a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146184
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [b50d9685e8bbb9549e68e3ff0a1b625fa44e6907]

        Use ImplInheritanceHelper in VCLXAccessibleTextComponent
        
        Change-Id: Iad1ae727e31908949d61d32b3828a67ac74398e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146183
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [fc2f4eb5ca457860605d0d93baa0d2198800bcbf]

        Use ImplInheritanceHelper in OAccessibleMenuComponent
        
        Change-Id: I7399a7e707d4a5915925d2e1b606ed7f6a364337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146182
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Stephan Bergmann  <sbergman@redhat.com>  [ce1fbb09746bbc007c6286ead29e351ec5c06c0e]

        Use ImplInheritanceHelper in OAccessibleMenuBaseComponent
        
        Change-Id: I9527ea68c3fbb1637ea08cea6340b49bab9eac6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146181
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-26  Ling Yang  <gnaygnil@gmail.com>  [a03dbcf786481d7b9294354399c83b46972ac85a]

        add "LOONGARCH64" to the JAVAINTERPRETER 64bit check
        
        Change-Id: Ia0d15eb3e235fbd750b818009b5168c61c6ff0ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139549
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [481c740ff04bc119fe1822f1a773a10a46d5d3a2]

        tdf#153220 exit header/footer edit mode, if active, on undo header/footer
        
        Change-Id: Ibe97a9239bff03b7bcffc11c02b6bdff840c4481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146178
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [abe13104486d9c360c5624c4710c06c19482f410]

        cid#1520593 Uncaught exception
        
        Change-Id: I14f412e9dda71863036cd99bc29f86d31b947163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [f8a5e416ea7713c7936b1533b43e16e2b711bea1]

        tdf#146248: sw: move UItest to CppUnittest
        
        Change-Id: Ibb198808d124457f6676cdf642b75289948514d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146174
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [2a40505d00fcd79bfa433c301ddc05a35287bfb1]

        remove option to toggle IsPDFAsStandardPrintJobFormat from UI
        
        to deprecate it. Still possible to toggle from expert config for now,
        but we should push on and remove this and all the postscript printing at
        this point.
        
        Change-Id: If8869a62616b336764720f5dc56d86b94f16ffbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146169
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [b9249d7c4db6e20dcc1bcca88b350e9ee547c992]

        cid#1520592 Logically dead code
        
        Change-Id: If0e52b474369657e0ed602f859d180f829865f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [49b616608d59de485faa01fa6d5989e1876e8de2]

        sw: no need to create the document twice
        
        Change-Id: I566fde00f414b9b983770256697ff2a6f3cf1781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146175
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-26  Patrick Luby  <plubius@neooffice.org>  [a0d825133656c6329c0e7e3b0b6bafbd51e87271]

        tdf#147342 Notify Skia that the window's backing properties changed
        
        Change-Id: I4185a240a2ca6df1c92e86ff9950f86234d4ace8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146142
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [f12ea381d52e2c26e966d15d281b41eafaddb5bb]

        resave with latest glade
        
        Change-Id: I6e2b3d33bb5388659761b89632d883ddc986de1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146168
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Kohei Yoshida  <kohei@libreoffice.org>  [27653feb30911d0f1dfe14ff0cb5373d4c87bcdd]

        Just use std::variant and std::get
        
        Change-Id: If467225fae07a9d33e324cac9ff32300d6c56534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146151
        Tested-by: Kohei Yoshida <kohei@libreoffice.org>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-01-26  Regina Henschel  <rb.henschel@t-online.de>  [a6bbf5db743583e21a2af3ef5b5a608f7bd46502]

        tdf#128568 more font properties in VML Fontwork export
        
        When export a Fontwork shape to VML then currently only font name and
        size is exported. The patch adds style 'italic', weight 'bold' and
        the special properties 'Character spacing' and 'SameLetterHeights' of
        Fontwork shapes.
        
        Change-Id: Ifb7b42ab6c63e12f5f672e670a3bde5bcf20b1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146148
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-26  Miklos Vajna  <vmiklos@collabora.com>  [bef6c5ca4edf55e64284d9dd264ba9a76476adab]

        sw: inherit SwFlyAtContentFrame from SwFlowFrame
        
        Checking how e.g. section frames are split in SwFrame::GetNextLeaf(), we
        call into SwFrame::GetNextSctLeaf() which then calls a dedicated
        SwSectionFrame ctor that connects the master with its follow.
        
        Add infrastructure to be able to do the same for fly at-content frames.
        (At-fly anchored and as-char anchored frames are not relevant for the
        broader multi-page floating table picture. Also, SwFrame::GetLeaf()
        wants to work with a non-abstract type, so allocating SwFlyFrame there
        would make no sense, so inherit SwFlyAtContentFrame and not SwFlyFrame
        from SwFlowFrame.)
        
        This is meant to be a minimal change, that can be unconditional, seeing
        that the only dynamic_cast to SwFlowFrame in RestoreContent() only does
        something if the frame has a follow, which is never the case at the
        moment.
        
        Towards an initial layout for multi-page fly frames.
        
        Change-Id: I8ea930bed4bbddb96b181796ab893e810ba9dcd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146160
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-26  Jean-Pierre Ledure  <jp@ledure.be>  [9079d15ec54928e1e7d5596e148d0f9aefe81bd6]

        ScriptForge (SF_Calc) more accurate comments
        
        Impact only on comments, code left unchanged
        
        Change-Id: I5549f2549d2b9ff351ad6174b9dba458525db210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146139
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6f8734963b883798ca4bf6854fa90e7dd7b9131]

        improve comment about SKIA_DEBUG
        
        Change-Id: I1101b0cc51a8c1f4302f479c3dcd3db002c1be88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Caolán McNamara  <caolanm@redhat.com>  [070292c719b7378202d6fd0c270828a75cd23554]

        include filename if the test fails
        
        which it does for me with fedora 38 s390x
        
        Change-Id: I32ad30061717287e785a395afc893db1a5764bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [40d76def20bc3ae5ab7db88fef2688ce1664fa15]

        tdf#153161: sd: move UItest to CppUnittest
        
        Change-Id: I14c1bc76b6cf19e287ef57a0aa5f34d842c69309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146163
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b1d750f9cf953f6483f13e0a4d1901800d417ce]

        use more concrete types in sd console
        
        Change-Id: I5ac9d084616563ba3ae67ee040b4f52156baea67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [622cf1dfe5b4b0e8a5d97b397d44a7bc66a4d7e7]

        use more concrete types in sd
        
        Change-Id: Ia2903695ddb451e21b0ed4e8d0a149d912558a4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146158
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4237bfb17101c6158ff98a6930e03aec94df314]

        GetDrawController should return pointer
        
        since it may be nullptr
        
        Change-Id: Id618ef6a25a8432024a67170a7d1402cb0fa6b8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b1f83880372868fb61c84dbe3230910cdbb386f]

        use more concrete types in sd
        
        Change-Id: I545858fe18e8a436fd2dda7402c825eac28fb2fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [263c15ee238e04c7b25d36cdbb9ab21c0bdf518d]

        Delete extra whitespaces inserted by the editor
        
        Change-Id: I89ef4d04e27e52f5ee6168f368e23f96e112a8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146085
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-26  Miklos Vajna  <vmiklos@collabora.com>  [cba2fda9ce2a82d874b86e585b576cb7d551d64d]

        sw, FN_DELETE_TEXT_FORMFIELDS: remove unused StateMethod
        
        FN_DELETE_TEXT_FORMFIELDS is only handled in SwTextShell::ExecField()
        and SwTextShell::StateField() doesn't seem to have a default handler for
        slots not mentioned explicitly, so this is not needed.
        
        Change-Id: I00bc3c543c44d541d352748c721be43b76965e32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146144
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfb8706466b52298def33d47d31b6efffc3ed531]

        no need for sd::ModuleController to load these factories via UNO
        
        Change-Id: I2ac1d29ff9cbd5c8676dc1957a62ea02454d052e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [fec0b1e444c416feaa416e79f0b8ece8069951e0]

        use more concrete types in sd
        
        Change-Id: I754847ac759fb7c946f2c021e898fc0139ca5226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-26  Jim Raykowski  <raykowj@gmail.com>  [60035ea9b46f10351ef0bd56d4999bc43558dd33]

        tdf#146178 Allow navigate by field to advance from last field
        
        of document to the first field in the stack, and reverse
        
        Change-Id: Ie0ef1eee0c556644f0b87a65b4bde1a7d9cdf337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145775
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-26  Kohei Yoshida  <kohei@libreoffice.org>  [516bc904e94971b61e4b13af632bf321b0a4a640]

        Upgrade mdds and orcus to 2.1.0 and 0.18.0, respectively
        
        Change-Id: I288b5b54bd07d951bcc68afda7514bde730193dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146107
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2023-01-25  Caolán McNamara  <caolanm@redhat.com>  [df470d9658c202a990b9c75e2a8d6e3fd7a06dfd]

        ofz#54437 Timeout
        
        Change-Id: Ib9b581a5e8b2385300923b2dc5bfaf7cee9c6bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146146
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-25  Caolán McNamara  <caolanm@redhat.com>  [647163e60446300745c9787e582a35898d308c70]

        ofz#55392 Out-of-memory
        
        Change-Id: Id1a351e25c3dcbff513357bb3ff4370e1430ff68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146147
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-25  Caolán McNamara  <caolanm@redhat.com>  [71a04c248411988697727cfe1ee6717f707422e6]

        ofz#55389 Integer-overflow
        
        Change-Id: I98bd62634ca054a668513df426fca408c78e7c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146145
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-25  Justin Luth  <justin.luth@collabora.com>  [72b69aa86c69f4d40720d62ecc24a2b004e0d1b8]

        sw: check for control before cursor pos on WrtShell ctor
        
        It may be entirely possible that WrtShell always starts
        with the current cursor at the beginning,
        but it certainly shouldn't hurt to at least attempt to
        look prior to whatever the cursor is when it starts up.
        
        I just created the ability for getFieldmarkAfter
        to loop around to the beginning, but I kept this
        code the same initially to avoid sullying the basic patch
        in case these particular lines somehow do bad things.
        
        But /*bloop=*/true seem more appropriate to the intent
        of this function than a false would. If we are in form
        mode, do anything possible to get into a fieldmark.
        
        Of course, we also have activeX controls
        and content controls, so perhaps this needs a bit
        of expansion to handle those as well...
        
        Change-Id: I8a6ec499e3d88203e036baa9b4eada5592fcd815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146047
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-25  Michael Stahl  <michael.stahl@allotropia.de>  [43744a9004e0fa59a525855c7e97ca153a839c42]

        tdf#153090 sw: add UI to SwTOXSelectTabPage
        
        Add a checkbox, label and a combobox, for Table of Figures/Table of
        Tables/Table of Objects - annoyingly the latter is sort of disjoint in
        the .ui file.
        
        Another annoyance is that the tab page sometimes reads its own state
        while initialising itself, overwriting its source.
        
        This is perhaps not ideal, but it appears to work if you don't look at
        it too closely.
        
        Change-Id: I3d3d79f37a75bf6570149d794a2363a53de2f59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146143
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-25  Caolán McNamara  <caolanm@redhat.com>  [9d60497954ed25bd802e66b5de0f375b301c79eb]

        tdf#153092 text appears missing with font sizes < 1
        
        where the size is scaled up, so restore use of scaling up when necessary.
        But continue to use unscaled supplied values when provided integer sizes
        to avoid scaling down.
        
        Change-Id: I8de268d1c9ac8f0a75aa84e231812b12310db76a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [4e0858dd9e1b4831eb117640d5d42f7e1e92fdb8]

        Use ImplInheritanceHelper in AccessibleTabBarPageList
        
        Change-Id: I1f03912046d94bd0e14f65310d93ec4f539fa304
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146115
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [02fbe937dc85772c463e40589a179d4a01770562]

        Use ImplInheritanceHelper in AccessibleTabBarPage
        
        Change-Id: I25092aa7307d9f1d69fbb29eb9a2db74071f760f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146114
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [5db518df93aa5ed8c87bdd20cf911d584c06ddeb]

        Use ImplInheritanceHelper in AccessibleTabBar
        
        Change-Id: I709b18500f417f3f7019118bc2a298e73bbedcea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146113
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [7af63ddd93265f6d66aeaa103ba0c5810ea1b158]

        Use ImplInheritanceHelper in AccessibleListBox
        
        Change-Id: I7fd3c43a991300a6180094ef9ac44e0dc3c56764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146112
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [4bde82182c82bdc3d6bc0f4851a5e100fba47c30]

        Use ImplInheritanceHelper in AccessibleIconChoiceCtrl
        
        Change-Id: Id5dec3b807509a073fcd2383ec37d2712cf24e9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146111
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [bbe70a7e3ddd0ebe92635afc842ec3c01294a5b7]

        Use ImplInheritanceHelper in OAccessibleControlContext
        
        Change-Id: I11d8f487df0c9e707be6a2aa98a32135643552f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146110
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [9fd65d8f9485f44e8f18b4e68d0e70ba154ae636]

        Revert "Update skia to m110"
        
        This reverts commit aef70869b0fae3001648ec2a2651ffc9c507678f plus follow-up
        4172fcb7514ff8a9e9740ff0939e9a2f611edbce "Fix no-pch Windows build: missing
        include".  It caused my Windows build `instdir/program/soffice` to immediatley
        fail with
        
        > skia\include/core/SkRefCnt.h(62): fatal error: "assert(this->getRefCnt() > 0)"
        > warn:skia:10572:7804:external/skia/source/SkMemory_malloc.cxx:32: sk_abort_no_print
        
        on start.
        
        Change-Id: I751f83eda28d9a5a8f9dd4b2429389906ffce983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146132
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Heiko Tietze  <tietze.heiko@gmail.com>  [9844064f252e8ec383d3c5bf24830acd868bb764]

        Resolves tdf#152947 - Accessibility for save status icon
        
        Added a rectangle around the *yes variants
        
        Change-Id: Ia60a5e4f6f7b0e04d0f0e7e8c5fd7bd0f8fa5492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146136
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-25  Heiko Tietze  <tietze.heiko@gmail.com>  [3fffe54bb19e387b6b56ac897a7e9cf8ebcc18d6]

        Resolves tdf#146579 - Accessibility for statusbar icons
        
        Added a rectangle around the active versions
        
        Change-Id: I473bb77a624c260db946e1718bff90eae9a4f805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146131
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [b61da415b78026ec56e51732adb505f3bc23a0cf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc89de95c0858af3e6116f2d2b736787c30fe213
          - Recipe has no dependency on target dir
            
            Seen this fail once at
            <https://buildbot.flathub.org/#/builders/31/builds/1623>,
            
            > cp: cannot create regular file '/run/build/libreoffice/workdir/CustomTarget/helpcontent2/help3xsl/online_transform.xsl': No such file or directory
            > make[1]: *** [/run/build/libreoffice/helpcontent2/CustomTarget_html.mk:186: /run/build/libreoffice/workdir/CustomTarget/helpcontent2/help3xsl/online_transform.xsl] Error 1
            
            Change-Id: I8cfa387d1bb2ef488f5f34ff20b9dc975d424751
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146141
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [63ef3cf5bfa8b58e5ac9a645aea2f043599dc6d4]

        Use ImplInheritanceHelper in OAccessibleTextHelper
        
        (Explicitly deleting the special member functions is needed to avoid MSVC
        
        > include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper(comphelper::OAccessibleExtendedComponentHelper &&)': attempting to reference a deleted function
        > include\comphelper/accessiblecomponenthelper.hxx(220): note: see declaration of 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper'
        > include\comphelper/accessiblecomponenthelper.hxx(220): note: 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper(comphelper::OAccessibleExtendedComponentHelper &&)': function was explicitly deleted
        > include\comphelper/accessibletexthelper.hxx(133): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText> &&)' being compiled
        > include\comphelper/accessibletexthelper.hxx(133): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::star::accessibility::XAccessibleText> &&)' being compiled
        
        )
        
        Change-Id: I00377be4a5fb44b2ef2b5001823ca0d89ead026b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146109
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [cbfbf11952374c49274938600c350d2f1f27bb32]

        Use ImplInheritanceHelper in OAccessibleSelectionHelper
        
        (Explicitly deleting the special member functions is needed to avoid MSVC
        
        > include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper(comphelper::OAccessibleComponentHelper &&)': attempting to reference a deleted function
        > include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper'
        > include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection> &&)' being compiled
        > include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::star::accessibility::XAccessibleSelection> &&)' being compiled
        > include\cppuhelper/implbase.hxx(151): error C2248: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper': cannot access private member declared in class 'comphelper::OAccessibleComponentHelper'
        > include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper'
        > include\comphelper/accessiblecomponenthelper.hxx(185): note: see declaration of 'comphelper::OAccessibleComponentHelper'
        
        )
        
        Change-Id: I2414d9f777de42b62c33492a90299aa9a9d53699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146108
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [784ee6e9fad22560add4a0767828ef07b8567bc2]

        sw: change or create the selected theme in SdrPage on theme change
        
        When the theme color changes (from the UI), also the theme that
        is set to the SdrPage needs to change. If there is no theme set
        yet, a new theme needs to be created (from a set of defaults).
        
        Change-Id: I5e3d6d9f973712ddb875a41adba1aff04395ca7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146129
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cae93bc7a401cb6ddaf33b7a23e2ff3c3bfada40]

        sw: support theme colors in color picker in writer
        
        Implements SfxDocumentShell::GetThemeColors, which allows the
        color picker to use the theme colors and change them in Writer.
        
        Change-Id: Ic13d2086d4ff037b377b475630b02ed1509fdf3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146120
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8640e24b12c7df3170c9f3e7ff3edced81fd0838]

        tdf#66580 added hybrid PDF test cases
        
        Change-Id: I2a58e6cd5b40266b3c55729febb7006c7a7b4170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146068
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [5dfa9433d238e11eb60c2d5e56beece3ed7531da]

        Fix typo
        
        ...which was pointed out in
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089867.html>
        "Re: Question re the uno-skeletonmaker'-t' CLI qualifier"
        
        Change-Id: I5f03de657bc93dace104bdd307e8f6938742b61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146126
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [79811c27f34d3e752de1bc3959605c5d58ac2365]

        tdf#129905 Create toggle for Section boundaries
        
        Currently in Writer it is not possible to enable/disable Section Boundaries independently from Text Boundaries (which are toggleable via View - Text Boundaries). Hence its only possible to enable/disable them together.
        
        This patch creates a new command that allows to enable/disable Section Boundaries (now in View - Section Boundaries) indepentently from Text Boundaries.
        
        Change-Id: I76981ed1a055ce8d1e0f83c3055fef75df37f019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146077
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-25  Miklos Vajna  <vmiklos@collabora.com>  [fd3d4d894d96f16a28d5b58c5bcf5a44fb83617f]

        sw: add UNO API for multi-page fly frames
        
        This exposes the internal property added in
        0bb90afaeb193181d7b98b79e962549d8a1dd85a (sw: add document model for
        multi-page fly frames, 2023-01-24) on the UNO API.
        
        Change-Id: If9acd2d2130f727bc9481980445c0da01be04729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146124
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-25  Andras Timar  <andras.timar@collabora.com>  [6053df3ecdf89886a4573a47aac789cacf4df008]

        NSS initialization guard
        
        Change-Id: I61a5886d0d13eaef6a61479e35d52a85937075ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142385
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146042
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bb391230db5387d708b6f4fbeec0442fb29d44be]

        Update git submodules
        
        * Update translations from branch 'master'
          to b4907d3a23fe5b27877fbf12fcc39c18790524a9
          - update translations for master/7.5.0 rc3 (macOS version bump)
            
            and force fix errors using pocheck
            
            Change-Id: Ib5123ee34e691b4869b489d23a644c1791807b03
            
2023-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [4172fcb7514ff8a9e9740ff0939e9a2f611edbce]

        Fix no-pch Windows build: missing include
        
        > In file included from C:/lo/src/build/workdir/UnpackedTarball/skia/tools/sk_app/win/VulkanWindowContext_win.cpp:9:
        > C:/lo/src/build/workdir/UnpackedTarball/skia\tools/sk_app/win/WindowContextFactory_win.h(23,1): error: unknown type name 'SK_API'
        > SK_API std::unique_ptr<WindowContext> MakeVulkanForWin(HWND, const DisplayParams&);
        > ...
        
        Change-Id: I7f88cbb005310dd586e53b262ce31a71d49faedc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146121
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-25  Balazs Varga  <balazs.varga.extern@allotropia.de>  [5f2d7db094fc0f4e7ae40987c3c6762b11184419]

        tdf#150098 sc validation: allowing formulas for validity test
        
        Calculate the formula results, before checking the validity test.
        
        Change-Id: I7420982a8cbcd2df6ab0adea6e3cf61aaccb1600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146011
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2023-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15b4f96ddc31cf1659a78fd0ef40b91124b5809d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60b9c9da98f43ba0048cadac79bb683f82c2c30d
          - Fix typos
            
            Change-Id: I63a7a69b053b3ddca65a0bd41ac903ce425815a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146128
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2023-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [9e10d4cc278805738a0816b60fd076529f85e1a3]

        android: Don't warn about NDK 21 and 22
        
        At least for these 2 configurations, building the app with
        NDK 22.1.7171670 worked fine:
        
        x86 dbgutil build:
        
            --build=x86_64-unknown-linux-gnu
            --with-android-ndk=/home/michi/Android/Sdk/ndk/22.1.7171670/
            --with-android-sdk=/home/michi/Android/Sdk
            --with-distro=LibreOfficeAndroidX86
            --enable-sal-log
            --with-external-tar=/home/michi/development/libreoffice-external
            --enable-ccache
            --enable-dbgutil
            --with-jdk-home=/usr/lib/jvm/java-17-openjdk-amd64/
        
        32-bit ARM release build:
        
            --build=x86_64-unknown-linux-gnu
            --with-android-ndk=/home/michi/Android/Sdk/ndk/22.1.7171670/
            --with-android-sdk=/home/michi/Android/Sdk
            --with-distro=LibreOfficeAndroid
            --with-external-tar=/home/michi/development/libreoffice-external
            --enable-ccache
            --with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/
            --enable-release-build
        
        Change-Id: I6c4d47b7e96232f44cb310badb18a8a30b585de8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146117
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-25  Pranam Lashkari  <lpranam@collabora.com>  [7595f39230ab7fada9fb15aca08cbdef81fe79e1]

        sw: lok: avoid creating callback json if kit is not active
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I60ae5a37acdbe4ea01b730702cc499833ce5b77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146036
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146102
        Tested-by: Jenkins

2023-01-25  Andras Timar  <andras.timar@collabora.com>  [15397a10585e223733c651287c9f84a719180128]

        more detailed NSS error report
        
        Change-Id: I1b005a331aeed1c00d6bf18a6dff0ffa844ba6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142286
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146041
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-25  Pranam Lashkari  <lpranam@collabora.com>  [b03790dac08f97594b2cdc8a4ab0394d62fb851f]

        sw: send LOK call back on section deletion
        
        this helps with zotero when user deletes or undo a bibliography stored as a section
        without this online will be unaware of any such changes made by user
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I6a8ae3924d548e97299a8d74f8c93c3345d1a430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146007
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146101
        Tested-by: Jenkins

2023-01-25  Pranam Lashkari  <lpranam@collabora.com>  [c8e49e7a49a99fd76a25ea825319d2243fed5c22]

        sw: send LOK call back on bookmark deletion
        
        this helps with zotero when user deletes a bookmark or use undo
        without this online will be unaware of any such changes made by user
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: Id5ea4ee0ee1d16c399460cd177ec8e33256ce3dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145777
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit ea112b6d85a6914e1df40e064cd5df6d46248d68)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146022
        Tested-by: Jenkins

2023-01-25  Miklos Vajna  <vmiklos@collabora.com>  [843bca8989322c37e2e58904cf8db1bbeea9c35b]

        CppunitTest_sw_rtfexport2: clean up no longer needed preTest()
        
        Avoid magic in preTest() based on the bugdoc name.
        
        Change-Id: I31d19f8f200b45ae791b998a173f3b520e6f01d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146100
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-25  Colomban Wendling  <cwendling@hypra.fr>  [293db294e3408eda3f3133925fd307011b13c8d8]

        test: Add AccessibilityTools::nameEquals()
        
        Some accessible names contain a suffix when OSL_DEBUG_LEVEL > 0, which
        makes it tricky to compare to a known value.  To fix that, introduce a
        helper that knows how and when to deal with the suffix properly that
        can then be used to easily check accessible names.
        
        As we already have a similar, yet private, helper for menu items on
        Windows (that include the keybinding label as a suffix), merge the two
        together in a unified solution for comparing names.
        
        Change-Id: I7e67edbc7817218ef3e097062d25888172056c21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142257
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [d183daea1abbd7b564d083298874dd7c40d5a5b3]

        tdf#153161: (Ab)use a call to XTextRange::getString to flush edits
        
        Restore the call (without checking its returned value), removed in commit
        d194474aabd699806cb3631bc8641dd0548b8026 ("tdf#151100: xText->getString()
        may be empty for content needing export", 2022-09-22), side effects of
        which obviously allow some object's changes to get flushed and saved.
        
        Change-Id: I62f27cd056c32ad76f79a4862e2f4a0964eaadef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146106
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-25  Stephan Bergmann  <sbergman@redhat.com>  [5c312c986eac570af1c8c3210bdcbde213aae6dc]

        Use ImplInheritanceHelper in VCLXAccessibleComponent
        
        Change-Id: I300f033054bddc2c0ee1973dbafc108c477bf09a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146103
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [aef70869b0fae3001648ec2a2651ffc9c507678f]

        Update skia to m110
        
        Removing those bits of the patches that appear to have been
        upstreamed.
        
        Change-Id: Ia7683c26af4c622ca4fccb828df023ae30e724a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146069
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81ced283de2d0da377225afeb589b793716238bd]

        Fix typo
        
        Change-Id: I4f60a62492b8e0b92c805dd5f4db43193a5d2288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146104
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-24  Justin Luth  <justin.luth@collabora.com>  [e125e6623fa1c0f39d927bb37547ca6d1e299cb1]

        related tdf#151548 formfield navigation: loop to beginning/end
        
        When reaching the end of the form using keyboard navigation,
        the next tabstop should return the user to the beginning of
        the form.
        
        This patch adds that to the existing legacy formfield navigation.
        I'll wait with a unit test until I have added
        activeX/contentControls into the mix.
        
        Change-Id: I24a15a60f5a0a2721f512cca50397efddcbf7e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146035
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-24  Caolán McNamara  <caolanm@redhat.com>  [d8b60e66bf1847989f6ff3c06ea214cef059ecaf]

        tdf#152404 crash with ibus-mozc with ctrl+alt+c during ExtTextInput
        
        Change-Id: I86e19387d93a57c3ad263f0c2dc9222a5f3480be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-24  Mike Kaganski  <mike.kaganski@collabora.com>  [639d092bc258f079f0c1655265347c94d0c51ab1]

        Fix build
        
        ... failed locally with
        
          C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'SvXMLImportPropertyMapper'
          C:\lo\src\core\include\xmloff/shapeimport.hxx(46): note: see declaration of 'SvXMLImportPropertyMapper'
          C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)'
          C:\lo\src\core\include\xmloff/xmlprcon.hxx(64): note: see reference to function template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)' being compiled
          C:\lo\src\core\include\xmloff/xmlprcon.hxx(37): note: see reference to class template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>' being compiled
        
        Change-Id: I08211c58ca61d2bc81062d0b104d8ce47ffccd91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146098
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-24  Stephan Bergmann  <sbergman@redhat.com>  [880117f74343087ff6a162426683378c9510ede6]

        Missing include
        
        > include\rtl/ref.hxx(129): error C2027: use of undefined type 'SvXMLImportPropertyMapper'
        > include\xmloff/shapeimport.hxx(46): note: see declaration of 'SvXMLImportPropertyMapper'
        > include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)'
        > include\xmloff/xmlprcon.hxx(64): note: see reference to function template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)' being compiled
        > include\xmloff/xmlprcon.hxx(37): note: see reference to class template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>' being compiled
        
        Change-Id: I77083e021ae16bce8b2f749b96b6c6607c22ff87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146072
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [74d3d85dc523dbb37326db7146d195e3b9b95fce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 366cd93675b556c330ca6f1146f6bd67e09e8647
          - tdf#118008 (part) Format menu update
            
            * Include align and number format menu entries
            * collected default number formats in one help file
            
            Change-Id: I01db0099ec0b4c421a717656ff3957f190501f53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146094
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [882a39e9099bf555c42da313e5127c5f31433701]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0b9ab742651f4014540723356720507edc2ec3ac
          - Document new RemoveDuplicates method in SF Calc service
            
            This patch also updates the method SortRange to remove the original limit of 3 row/column as keys (see commit 40bc1b275324f9a730960fe5d4d8982cdfbc7b03)
            
            Change-Id: If2f3e6cc97f3effdde34ee44330335ae85fef226
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146028
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [a53825419aa23297f19d1ff436e771f19177824d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40d7045493a707ba164779fc506e2825b8c0909d
          - Improve ScriptForge TOC help page
            
            This patch also fixes the Basic service help page by classifying ThisComponent and ThisDatabaseDocument as properties instead of methods.
            
            Change-Id: Ia3937b0ea3fb057dacfc31ead1db512ddd951d64
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146023
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-24  Stephan Bergmann  <sbergman@redhat.com>  [5747634948fcb0f3430a2ce7647e128712cbba66]

        Use ImplInheritanceHelper in OAccessibleExtendedComponentHelper
        
        (Explicitly deleting the special member functions is needed to avoid MSVC
        
        > include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': attempting to reference a deleted function
        > include\comphelper/accessiblecomponenthelper.hxx(176): note: compiler has generated 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent' here
        > include\comphelper/accessiblecomponenthelper.hxx(176): note: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)'
        > include\cppuhelper/basemutex.hxx(43): note: 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)': function was implicitly deleted because a data member invokes a deleted or inaccessible function 'osl::Mutex::Mutex(const osl::Mutex &)'
        > include\osl/mutex.hxx(107): note: 'osl::Mutex::Mutex(const osl::Mutex &)': function was explicitly deleted
        > include\comphelper/accessiblecomponenthelper.hxx(228): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent> &&)' being compiled
        > include\comphelper/accessiblecomponenthelper.hxx(228): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleExtendedComponent> &&)' being compiled
        
        )
        
        Change-Id: Ia5a7b244dd018c1a63cc2940dba197c43827d563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146062
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-24  ektagoel12  <ektagoel12july@gmail.com>  [21fbb4b952c7ba5d580c71150ffe9423aaf57f9e]

        tdf#141908 Replace usage of sal_Int32 with Color
        
        Change-Id: Id2849140ba1302d59918eb30458984aef2b5c6ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145964
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e011ac1c14656df67dbb46e54402afa64ff47303]

        [API CHANGE] remove service sd::framework::ModuleController
        
        It makes no sense to be constructed externally.
        
        Change-Id: I7e756e225e7b6e1785194b2f73edd5a7d65ec0e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-24  Miklos Vajna  <vmiklos@collabora.com>  [0bb90afaeb193181d7b98b79e962549d8a1dd85a]

        sw: add document model for multi-page fly frames
        
        Currently we can have multi-page tables and fly frames (where the
        content wraps around the fly frame), but not both at the same time.
        
        Allowing multi-page fly frames in general would probably go too far, but
        handling this in case the fly frame only contains a table would make
        sense to support Word's multi-page floating tables.
        
        Fix this by adding a new SwFormatFlySplit property on fly frames: this
        is meant to be enabled when the fly frame is part of a multi-page
        floating table.
        
        Unlike table split, this is off by default. Some logic will be needed
        later to enable this in case the fly frame originates from a Word
        floating table. (And obvously this is just the doc model, everything
        else still needs doing.)
        
        Change-Id: Id92130c684016cd7e7153e15b0ec6821e4471879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146095
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [413bd0a96b010feb10dc3d76efa266ea082de006]

        tdf#153076 Make Basic editor background color independent from document color
        
        This patch creates a separate color configuration entry for the background of the Basic Editor (svtools::BASICEDITOR). This allows the user to set the color of the Basic Editor independently from the color used as document background.
        
        Currently the color used is DOCCOLOR, which means that if the user wants to use a different color in the Basic Editor, they must change the document color as well. However, the user may want to use f.i. a dark background in the Basic editor while maintaining a white color for documents, which is currently not possible.
        
        By default, both color schemes "LibreOffice" and "LibreOffice Dark" use the same color for DOCCOLOR and BASICEDITOR to replicate the existing behavior. But now, if the user wants to use a different color for the Basic Editor, than it's possible to change it without affecting the color of documents.
        
        Change-Id: I2f33b1ccb497d7e22faab7fa48cb96841785ce99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145590
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-24  Tor Lillqvist  <tml@collabora.com>  [6e2d28934e273386e2f56a4eef0a9f03fa5d5c7d]

        Clarify comment
        
        Change-Id: I33d10ea4f3ca35619d6f857d18b5c53a22d822a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146097
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-24  Tor Lillqvist  <tml@collabora.com>  [d514097753a5971f2d5616319238a1a9eb6d8f9a]

        Surround recently added code that breaks on COWASM with ifdef
        
        After 7a6324ea0d81bbe2bba09f8a7f5230342a4f4e85 I started getting UNO
        exceptions with the message "component context fails to supply service
        com.sun.star.xml.crypto.SEInitializer of type
        com.sun.star.xml.crypto.XSEInitializer".
        
        It is likely that it breaks in the iOS and Android apps, too, so
        bypass for those, too.
        
        Change-Id: Id08afbf6bea071c8b0b6564342716e0b064cb712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146071
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-24  Tor Lillqvist  <tml@collabora.com>  [e37a4598bbfcc4359fb13e362888b5fe29a997ef]

        Use PYTHONWARNINGS=ignore instead of 'default' for Emscripten
        
        The Emscripten compiler, emcc is a Python script that wraps the actual
        compiler. It outputs annoying warnings like
        
            .../emscripten/tools/building.py:638: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/emscripten_temp_0fvvg__1/conftest.js.jso.js' mode='w' encoding='utf-8'>
        
        to stderr. (Ditto for em++.) Some steps in typical configure script
        think that a non-empty stderr means there was a problem in compiling a
        test program. This happens even for a microscopic test program with an
        option like -Werror which surely *is* supported.  Avoid this by
        setting PYTHONWARNINGS=ignore.
        
        Change-Id: I11927fc7dccaa65a239ba65dfc7c6bb7487bf12d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146070
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-24  Jean-Pierre Ledure  <jp@ledure.be>  [bc8c1d45ac91a1b3855eec8358260a8720d4c081]

        ScriptForge (SF_Dialog) define constants as properties
        
        OKBUTTON and CANCELBUTTON are defined in the help
        as properties, both for Basic and Python user scripts.
        
        To make
          dialog.OKBUTTON
        valid in Basic, OKBUTTON should be defined either as (1)
          Public Const OKBUTTON = 1
        or (2)
          Property Get OKBUTTON()
        
        Actually, it if a Private constant. <= wrong
        
        Choice is made to make it a full property (2).
        
        Python equivalent is OK, no change required.
        
        No impact on help documentation.
        
        Change-Id: Id4cf7dfbaff68fc8cc48a5c4779374ce1e7cc88b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146008
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-01-24  Tor Lillqvist  <tml@collabora.com>  [a771945f982a228e9076195bae5bdd0c8aaf60b3]

        Be consistent in checks for LIBO_INTERNAL_ONLY
        
        Only check whether LIBO_INTERNAL_ONLY is defined or not. Don't check its value.
        
        If undefined, its value will default to 0, but checking the value will
        cause a warning that will be treated as an error if you compile with
        -Werror, as you should.
        
        Change-Id: I1d9e4569a016d2e6dbaa9d612071a5528ff1902e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146066
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-24  Michael Stahl  <michael.stahl@allotropia.de>  [90e1698dab3d286c10136719aa85fee2f56ad9fd]

        tdf#153090 xmloff: ODF import/export of source style on ToX
        
        For Table of Figures/Objects/Tables.
        
        Make this similar to DOCX: only one source style is possible, so omit
        the intermediate text:index-source-styles element.
        
        Also a boolean attribute like text:use-index-source-styles appears as
        unnecessary complexity, so try to do without.
        
        Change-Id: I7cb599c7ec1261ddedc196a25c3eafe35f35fbe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146013
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-24  Caolán McNamara  <caolanm@redhat.com>  [668f55b65849012b359d7d6b9386113facbadc57]

        tdf#152404 crash in Windows with ctrl+alt+c during ExtTextInput
        
        Change-Id: I73ed19eeae49ef737aae372b8f4c053f67a169c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146064
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6d3aafc3aa70d63aa8f61bf86b39cdad25172e73]

        sw: disable theme dialog if the theme is not set to the draw page
        
        Change-Id: I3d60e9b82dfd59b5afc7769a7895acfcc5c3417c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146061
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9b324f97b55f37ef9f8dc6c9974c2fbbb2e984d5]

        sw: remove tab pages from theme dialog - crashes online
        
        Remove the tab pages for now, as they crash the dialog in online,
        and the tab pages aren't used currently anyway.
        
        Change-Id: I35a2875510fd74b6a3060edf83c7190ba80a4eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146060
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-24  Jan Holesovsky  <kendy@collabora.com>  [4132bd5477c25a505f7bfbee1e7dcf6602c927d3]

        No need for openssl in the cross build's instdir_for_build
        
        So disable it from the configure & make sure it is not brought in by the
        non-iOS check.
        
        Change-Id: I9bbf1c593d1d48197951002e04e7f925d35ecba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146034
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2023-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e052f6e1d49a5289411b31561d6e310bf414d896]

        tdf#66580 write ODF document as an attachment in hybrid mode
        
        This changes the hybrid mode so that the ODF document is written
        as an PDF compatible file attachment into the PDF document. It also
        keeps writing the /AdditionalStreams element into the trailer to
        keep backwards compatibility for now.
        
        Change-Id: Ica31159cfbd591c6741e3da62c42d1fefd085696
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146053
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [217ef2ed9b8a757b7b02feac799621d20d0f312e]

        pdfimport: refactor pdf and hybrid format detection code
        
        Change-Id: I3421fbcc717a75377db887f567ce3bb9631a4f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146052
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5d135edd8843471f582a88f4e1a9a9b9fc0fd89b]

        xmloff: extract XMLThemeContext into own class
        
        Change-Id: Iee30a84915148297ad5c105d29fdf48098261a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146051
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-24  Pranam Lashkari  <lpranam@collabora.com>  [06f98f94448fdf7b5dc3a55f45da8a27e5b212a8]

        sw: send LOK call back on refmark deletion
        
        this helps with zotero when user deletes a refmark or use undo
        without this online will be unaware of any such changes made by user
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: Ia4326fd03f6b7d27fdb59ccc25d60331ba7923d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145774
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146005
        Tested-by: Jenkins

2023-01-24  Pranam Lashkari  <lpranam@collabora.com>  [e88f53eb87238489349ae81b7834f97dd554d805]

        sw: send field mark delete call back only on deletion
        
        previously command call back was also sent when field was selected
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: If0768180e81c47a738225e693b07441cf25906b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145884
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit c3a53e0c2503d277fbfeb60d4c2499c2e377f9df)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146021
        Tested-by: Jenkins

2023-01-24  Michael Stahl  <michael.stahl@allotropia.de>  [53fe1f0880bc7e8a467404cddabb27daecfc37cb]

        tdf#45854 sysui: replace wrong ODB mime type
        
        https://issues.oasis-open.org/browse/OFFICE-3745 was resolved.
        
        Replace all wrong:
        application/vnd.oasis.opendocument.database
        with:
        application/vnd.oasis.opendocument.base
        
        There is an identifier "org.oasis-open.opendocument.database"
        being used in some MacOSX Info.plist files - there is no indication that
        it needs to "match" the mime-type so leave it as is.
        
        Change-Id: Ic8e0d24e3aa74743801a670846daf2d322c33d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146040
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-24  Stephan Bergmann  <sbergman@redhat.com>  [bb0192b332d02dc6a94963992cf65cb5cfdb517b]

        Use ImplInheritanceHelper in OAccessibleComponentHelper
        
        (Explicitly deleting the special member functions is needed to avoid MSVC
        
        > include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': attempting to reference a deleted function
        > include\comphelper/accessiblecomponenthelper.hxx(177): note: compiler has generated 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent' here
        > include\comphelper/accessiblecomponenthelper.hxx(177): note: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)'
        > include\cppuhelper/basemutex.hxx(43): note: 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)': function was implicitly deleted because a data member invokes a deleted or inaccessible function 'osl::Mutex::Mutex(const osl::Mutex &)'
        > include\osl/mutex.hxx(107): note: 'osl::Mutex::Mutex(const osl::Mutex &)': function was explicitly deleted
        > include\comphelper/accessiblecomponenthelper.hxx(200): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent> &&)' being compiled
        > include\comphelper/accessiblecomponenthelper.hxx(200): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::star::accessibility::XAccessibleComponent> &&)' being compiled
        
        )
        
        Change-Id: Ide07c6a7c3660e469f16973d866c949d17fdf419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146010
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-24  Mike Kaganski  <mike.kaganski@collabora.com>  [da8d369a1fb06dfe6ef47d6e0da4402bb12ede27]

        AddAttribute may take 'namespace:full:uri^attribute_name'
        
        ... e.g., created in SaxNamespaceFilter::startElement, which calls
        XMLNamespaces::applyNSToAttributeName to make such a name.
        
        See https://gerrit.libreoffice.org/c/core/+/145526/comments/26536db2_d8fb1e1b,
        which notified that the assert from f2f008c52aaa88329c07f441de60d6fdfce9f0b3
        ("Merge SvXMLAttributeList to comphelper::AttributeList", 2023-01-15) started
        to fail on some input.
        
        Change-Id: Ia0afc167aefac463bcd354dc009bff6e14a64dfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146054
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-24  Mike Kaganski  <mike.kaganski@collabora.com>  [22c292a2a9f4f459539d042ad902441a3583c804]

        The resolved style name *can* be empty in redlines
        
        I assumed otherwise in commit 20adf4683c7d38ad41edac586b897757393c8029
        ("tdf#152425 related: don't generate style ids in DocxAttributeOutput::Redline",
        2023-01-13). But the string that we try to resolve may come from original file,
        and so must be treated as arbitrary user input, which may not resolve to a
        known style.
        
        This basically reverts commit 20adf4683c7d38ad41edac586b897757393c8029.
        
        Change-Id: Ia6cbce1b9601df2c15edbab653b9b629d52d5ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146055
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a90ef17809071b808a8c703e7e47e045ddabcd4a]

        Revert "tdf#153167 ImageMap Editor dialog had no title"
        
        This reverts commit 66291d467be4bf0e841814111d57d1af76117f8e.
        
        Reason for revert: didn't wait for jenkins and broke the build
        translatable strings need context attribute.
        
        Change-Id: Ie72f30def24b5489925d0f972e8581d3fc636e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146031
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2023-01-24  László Németh  <nemeth@numbertext.org>  [9bec4732915ef408d9a442ccbeb9b582a204b1ca]

        tdf#152541 sw: don't show hidden __RefHeading__ bookmarks
        
        In visible bookmark mode, don't show __RefHeading__ bookmarks,
        which are hidden in Navigator, too. Note: they are inserted
        automatically e.g. with the ToC at the beginning of the headings.
        
        Follow-up to commit 4ce8120f1e53f7b81e653b01d141643013bc69ab
        "tdf#45589 sw: create and paint text portions for bookmarks".
        
        Change-Id: Id337613342fa74f5edef59d01349810f9737b62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146044
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [be86c8f2432623fdb8ed4f22ca08c35121fd8bec]

        tdf#100584 - Arrange sheets in the tab bar depending on the RTL settings
        
        Change-Id: Id10bfd18029651790be943b74745016f6ad637ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145765
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-24  Miklos Vajna  <vmiklos@collabora.com>  [713493c107e6a210ef9b87d033efd0614271483a]

        tdf#150806 ODT export: fix fallback svg:width/height for zero layout size
        
        The reported problem was that once tracked changes is enabled and an
        image is deleted, its aspect ratio changes on save.
        
        What happens here is that the image's frame is marked as a redline
        deletion, so when the ODT export writes the file, it'll have a zero
        size. But this zero size is nothing we should take into account on save,
        XMLTextParagraphExport::addTextFrameAttributes() expected to always have
        a valid layout size if the LayoutSize property is available.
        
        Fix the problem by adding one more condition where we ignore the layout
        size, which was already there since commit
        80550ade305b9e68c6281a258d162bc2c413713a (tdf#150990 ODT export: fix
        zero layout size of scale/scale images, 2022-09-20).
        
        Note that this way the written side will be the original one, so only
        the aspect ratio will be correct, but that was accepted as a compromise
        earlier.
        
        Change-Id: I108dc2428ce0cb07a044bfef216575fdba19267b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146043
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [31a5db6f28cd006adf5630b2c5d683accb9eeadb]

        [API CHANGE] remove service sd::framework::ConfigurationController
        
        It makes no sense to be constructed externally.
        
        Change-Id: I6fb8f58ff8594c58d190f78e6f26b2703046a95b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-24  Justin Luth  <jluth@mail.com>  [7f23dae00fedc9d7119b44b6c44d9eca4f8c87b8]

        tdf#135987 xlsx vml export: retain checkbox link to cell
        
        The checkbox can be linked to a cell, so that the cell's value
        is toggled between true and false.
        This was lost on a round-trip.
        
        Change-Id: I4f2d44a594a92caedb29ded9b2c292006c803115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145962
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-24  Justin Luth  <jluth@mail.com>  [245912dc42bfc13cbf0db3f04f2411f3dede9615]

        tdf#117266 tdf#120374 sc oox: export correct vml button name #2
        
        So the actual name is more important than I knew.
        For example, VBA maps click macros based on the button name.
        So use the MS-provided name and use the SPID to connect to the shape id.
        
        Of the existing unit tests that were affected by this:
        -macro-button-form-control.xlsm: button now launches hello macro
        -tdf117266_macroButton.xlsm - same file as ^^^
        -button-form-control.xls nearly same file as ^^^
        -tdf134769.xlsx - checkbox still exists on round-trip
        -tdf106181.ods - checkbox still exists, but link to cell still lost.
        -checkbox-form-control.xlsx - nearly same as ^^^
        
        All looks good.
        
        Change-Id: If83cf17d60b73c46d55a21b1a46ed320513044cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145961
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-23  Tor Lillqvist  <tml@collabora.com>  [5cd3a8ec6d36a389eb0be4d59f4570e3bda92dc5]

        Enforce compiling cairo and pixman for WASM with -O3
        
        Earlier, no -O flag at all got used in the cairo and pixman
        builds. Which was sad, as these two libraries are performance-critical.
        
        Yes, this change is quick-and-dirty. The proper way would be to modify
        things in solenv/gbuild. But that is somewhat complicated.
        
        In general it seems fairly hard to make sure the same compiler flags
        get used for every external bundled library. Each external library is
        a special snowflake, more or less, with a differently structured
        ExternalProject makefile.
        
        For instance for the libwpd library (just picked randomly as an
        example), even -O2 gets used. (Which as such is OK.) This despite
        solenv/gbuild/platform/EMSCRIPTEN_INTEL_GCC.mk apparently trying to
        enforce use of -O1 for Emscripten.
        
        This change has a visible impact on the performance of COWASM.
        
        Change-Id: I99d74db2da733134fde16661881856f9a81100f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146009
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-23  Henry Castro  <hcastro@collabora.com>  [7a6324ea0d81bbe2bba09f8a7f5230342a4f4e85]

        lok: ensure to initialize the security context
        
        if the backend NSS is used, before load the document
        ensure the NSS is initialized otherwise NSS next functions
        calls will fail.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I7ac1d7eeee681995e6c284e2dd4595a33d044af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142213
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142289
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-23  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [66291d467be4bf0e841814111d57d1af76117f8e]

        tdf#153167 ImageMap Editor dialog had no title
        
        Change-Id: I90048520d250d086b7b0ef4af675c9e1bcff93f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146039
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-23  Tor Lillqvist  <tml@collabora.com>  [36c492bb01f48435b714fc85b203c1e8a2fa8d07]

        Bin line that was commented-out in December 2021
        
        Change-Id: Ie6c6891d1a682d57e4606454fb6b295072e57644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146038
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-23  Michael Stahl  <michael.stahl@allotropia.de>  [09e3aaa2d22b8fe2887ae973b55f3ad274a960ee]

        xmloff: ODF export: missing extension check in XMLStyleExport
        
        (regression from commit 05f863844d9a5613250e8d787e32752b270ec4d3)
        
        Change-Id: Iae891ecec26599c9016be17e4db8eaf99783baa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146012
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [5994aedd44bcf3fba93cdc33e33844231929afa8]

        [API CHANGE] sd::frame::Configuration does not need to be an UNO service
        
        It does not ever appear to have been used as such, and it makes
        no sense to be constructed externally.
        
        Change-Id: Ia1a0cccdaeb19ded1197ad8aae701ac86dd3bb48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145989
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Rene Engelhard  <rene@debian.org>  [f8604f08ed5e07e50a65b5d35f3c0c18bf19044a]

        update hardcoded dragonbox include to 1.1.3
        
        since dragonbox now installs to that one, and 1.1.3 is default for the
        internal case anyway since dd1610146528cba8642caad3bf72e27b9ca6c153.
        
        Change-Id: Ibd0449b1bd1191a1872c233bfe9810af1d1215cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145985
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2023-01-23  Mike Kaganski  <mike.kaganski@collabora.com>  [23555ec4058521262860d48d976eba8563d9ba98]

        tdf#153136: fix IgnoreTabsAndBlanksForLineCalculation compat flag
        
        It should handle SPACE, EN SPACE, EM SPACE, FOUR-PER-EM SPACE ,and
        IDEOGRAPHIC SPACE, but not SIX-PER-EM SPACE. The latter was mistakenly
        added in commit 9ee96273a2090b63e0f579a1e9c9cef780756e6d "tdf#123703
        strip six-em-space (U+2006) at line break" (2019-08-24).
        
        Change-Id: I857f303eb19e19f067ad47933fa4b7eb96ce5ca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145995
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [6543eb9a5cda3cbd2cd46f35c7f0bc940cd69a45]

        Mark external/zxing/missing-include.patch.0 as upstreamed
        
        Change-Id: Ia4c251c952889b4ae174b172839a946302d41c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145524
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [3f7b67a2aedf9af22dd5d7f3a706427ff910f2dd]

        Mark external/zxing/android_include.patch.0 as upstreamed
        
        Change-Id: I05f51e0ee83f43614dc85e0b1ca5854f8aed21a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145523
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6bfd22b65fc5eb6539108887ea6242223f3e9655]

        update credits
        
        Change-Id: Icbf6bd2aba36baccb5e4046f02c6c5c69cb5f7e1

2023-01-23  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [cae35d6354084073db033c320f2f21b62a4868f6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a892431e8d42b0488af3e9bffd4924cd3e06ad1
          - tdf#152666: explain how the paragraph style combobox is populated
            
            Change-Id: I4f983153115afe7787f445ed471f14a29d798268
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145311
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-23  Pranam Lashkari  <lpranam@collabora.com>  [4ca01e91d72df3f69d8b5c7a4d6fddd863a396fc]

        sw: send LOK call back on fieldmark deletion
        
        this helps with zotero when user deletes a fieldmark or use undo
        without this online will be unaware of any such changes made by user
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I93cf102c20b3861140508aee5d81e65f5b9207ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145753
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3a6b7e2c07566f22f33189ad4e8393767df5b9f8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146014
        Tested-by: Jenkins

2023-01-23  Miklos Vajna  <vmiklos@collabora.com>  [938f2754d67173ceae8db043e0aac1315210850e]

        sw doc model xml dump: show endnote info about footnote formats
        
        The text-attr doesn't know if this is a footnote or endnote, so let's
        show its format, which has this info.
        
        Change-Id: Ib36621f3206188f48e87fbc7f7899cbe2c8b4326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146002
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-23  Caolán McNamara  <caolanm@redhat.com>  [fe2031e0f278e0a51d851e257f10a3fd3e58313f]

        gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL' failed
        
        Change-Id: Ie02dbee2e21fd5092f8be5f01383f2ce3b60c0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146000
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [77fbe2f41af7a64a14fe62a280d816890d9bc8d9]

        Update git submodules
        
        * Update translations from branch 'master'
          to 20c957e0ff773293fe7c10fb588f6674998a3087
          - update translations for 7.5.0 rc3/master
            
            and force-fix errors using pocheck
            
            Change-Id: I25323301c1346e04623e76a166218efb34a9e034
            
2023-01-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [adb82d978498186ea2389fc1e48a9170db62c18e]

        tdf#153154: m_xDataTypeLB is still in use
        
        Regression from 2e7f77d3fe01e36222d5ad84c18d7d7537092972
        "loplugin:unusedfields"
        
        Change-Id: Ic9435ee9417f812281ad75039d4ef88f508bad62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145999
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0da2d347a8de0e7480aba900961a1464c753c087]

        XUnoTunnel->dynamic_cast in vcl::Graphic
        
        Change-Id: Iecbae3570851784f0da75fd2899daf620c8e4c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145994
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Miklos Vajna  <vmiklos@collabora.com>  [319a466ad2a20d3170511a96ad16f4386ed0216b]

        sw: prefix members of SwVbaReadFieldParams, TabStopsEnumWrapper, ...
        
        ... TableCollectionHelper and TablesOfContentsEnumWrapper
        
        See tdf#94879 for motivation.
        
        Change-Id: I444cee4e834f08f422d5006022c4db552942ad35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145997
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-23  Michael Stahl  <michael.stahl@allotropia.de>  [b706b04110d9305b319689a5577746fac3e0e4c3]

        [API CHANGE] offapi: clean up these index services IDL files
        
        CreateFromStarImage isn't implemented, having been removed in 2000.
        
        Change-Id: Ic0e90eaf760374df69f8d8779c37819d4943a063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145911
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-23  Michael Stahl  <michael.stahl@allotropia.de>  [5ef8d07fe04717dc4a5b8846a3b324381b2c8efd]

        tdf#153090 writerfilter,sw: DOCX/RTF import/export of TOC \c \t
        
        This is for Table of Figures/Objects/Tables.
        
        The core will happily generate entries from paragraph styles by simply
        setting the Template flag and adding the style name.
        
        In Word, this feature differs from ToC in that only a single paragraph
        style is allowed, and there is only one level to assign to so that is
        omitted and \t is simply the style name (presumably suffering the usual
        i18n disaster, see tdf#153083).
        
        So implement it with the same limitations, not reusing the
        CreateFromLevelParagraphStyles property on SwXDocumentIndex but instead
        add new property CreateFromParagraphStyle.
        
        Change-Id: Ic8ab1fa9e81bdc85cc932f6bba8724d560e0fbc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145904
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f11b3c466565432e45f19f1cc30171075b9af8d]

        XUnoTunnel->dynamic_cast in configmgr::ChildAccess
        
        Change-Id: Iadfdbb68ad7876801bf79352bdec26da7da63325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee284e65d2b1cad231d316efe0ef31232dfa8d02]

        XUnoTunnel->dynamic_cast in AnimationNode
        
        Change-Id: I9684ac5987c087797e1ca7a8ddb0f9c5b731faed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145992
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Michael Stahl  <michael.stahl@allotropia.de>  [97cd92f3dee199d50856f24d51d7d7a236ae7bbe]

        sw: Word export: hyperlinks for ToX Figures/Objects/Tables
        
        This was missing, and lcl_IsHyperlinked() has a wrong termination check,
        which is noticable here because these have only 1 level (+ title at 0).
        
        Change-Id: I56a8622ee2c9df2167e26863cb3797b01434553c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145903
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [cd20a17ab703e97191b4e3421527267ef82a704f]

        tdf#152622 Fix color of Object Boundaries in dark mode
        
        In the "LibreOffice" color scheme (the light one) the color used for Text Boundaries and Object Boundaries is the same.
        
        This patch makes it so that in the "LibreOffice Dark" scheme these colors are the same as well.
        
        This is important to better highlight objects over a dark background, which was the case reported in the bug ticket. In Impress the object boundaries were not visible because the color used is too dark.
        
        Change-Id: I31e2876b14bca10fcf2c077da46e4541bb9f3ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145800
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-23  Heiko Tietze  <tietze.heiko@gmail.com>  [9b9159aa9073318c6892787d721b8cd732525972]

        Resolves tdf#113439 - Show/Hide menu item in Draw's layer menu
        
        Introduces .uno:ToggleLayerVisibility duplicating the existing
        LayerTabBar::MouseButtonDown() function
        
        Change-Id: I726d9a620afe22c84e5f20e76fabdfeccbcfb083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145558
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-23  Miklos Vajna  <vmiklos@collabora.com>  [e316524d9fe7720ed0a5eaf94999e54d211a8395]

        tdf#153046 RTF import: fix lost paragraph alignment after page break
        
        The bugdoc had a page break, and the paragraph after the page break is
        meant to be centered, but it was aligned to the left.
        
        This went wrong with 3c610336a58f644525d5e4d2566c35eee6f7a618
        (tdf#148214 RTF import: avoid fake paragraph for \page when possible,
        2022-09-08), previously we emitted fake paragraphs in most cases, which
        allowed simpler handling of pending paragraph properties. Now we have to
        be careful to call checkNeedPap() exactly when parBreak() in called,
        otherwise checkNeedPap() sends paragraph properties, and paragraph
        properties noticed later will be lost.
        
        Fix the problem by not sending paragraph properties unconditionally,
        only in case we send the fake paragraph break as well. This continues to
        allow the unwanted fake paragraphs in some cases, but it restores the
        lost paragraph properties, since m_bNeedPap will be still true after we
        hit the first character in the last paragraph, so \qc is sent to
        dmapper.
        
        Note that we don't have to check m_bNeedPap before checkNeedPap(), as it
        returns early already when m_bNeedPap is false.
        
        Change-Id: I683d42208072a84fe578e397ac3e29585da5aa89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145990
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-23  Stephan Bergmann  <sbergman@redhat.com>  [597efeb3aca71183b15a8465390c836614f01436]

        Fix --with-package-format=... builds
        
        after 02c4386a09c7364d58c50a388ff77db14810a218 "move presenter console from
        sdext/ to sd/" removed the PresenterScreen library
        
        Change-Id: Iaca64d340a9e2eb1faacf68c988c46a4a5ab3f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145991
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [b127033bf40fb912c35bfb8a659227b749a40ac2]

        XUnoTunnel->dynamic_cast in ScStyleObj
        
        Change-Id: I1021cddc87546635b147bbdf5f48948565815873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145983
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e7ff2a908c577b52ee0707435fb409765c37545]

        XUnoTunnel->dynamic_cast in ScCellRangesBase
        
        Change-Id: Iac62a8ed51d21cc2ef957b3e4811554b62cdb0d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145982
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [c04434a58407f76ab378b6a991b23f1aaf534f86]

        XUnoTunnel->dynamic_cast in ScAutoFormatObj
        
        Change-Id: Id0910149f89e77de8b50b3892fccee789dd7aa2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145981
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f141c05a7205db660e79673ad2676e19d50583d]

        XUnoTunnel->dynamic_cast in ScSubTotalDescriptorBase
        
        Change-Id: I45b15bf9a9be2de82b86701cd3af5c4f8c6fff13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145980
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc270b8e046d277606255018f6fc165d65beef8a]

        XUnoTunnel->dynamic_cast in ScEditFieldObj
        
        Change-Id: I6bf89f1a6dc3f7bd1c1934e651e235ba572e83c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145979
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6339b4a281675164034e10a05ca1b62aad89c67]

        use more concrete SmModel type
        
        Change-Id: I7804e7201e64f419383e37b916b212ac9c129ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145984
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [d47c23cb1a4448a16283555e4d7034c7e1fcd1a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b4b815af4b5e86eec0fa69b2260ec9d8aa558bae
          - A bit of proofreading
            
            Change-Id: Ibab2714b04f3051266d4e1b4101b517bd669db28
            
2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7ad863764052b8d5334a20b56c7d415d81b82db]

        XUnoTunnel->dynamic_cast in ScTableConditionalFormat
        
        Change-Id: Ice24bb4e6258b40228213b82436ea6d1d50d0e8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145975
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a32675a5fef9cc8a32234ba7ba1eacb53265e735]

        XUnoTunnel->dynamic_cast in ScTableValidationObj
        
        Change-Id: I7b42ed7b7d7332c24908d0011a216e9617e6c80d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f94dc655ec37ec8f40de70f9105a8427a362f266]

        XUnoTunnel->dynamic_cast in ScCellSearchObj
        
        Change-Id: I6f2eda6daf92959973d97a4be38f58a11415776f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f647691a55554f1a3a02aa4e997246ff7c16bcaa]

        XUnoTunnel->dynamic_cast in ScTabViewObj
        
        Change-Id: I8400b56dd656fe2a1144696db8578869b2d26cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc83e664fc119bf3d8a5a0bcc4d15a8e788d57fb]

        XUnoTunnel->dynamic_cast in SdXCustomPresentation
        
        Change-Id: I4841e93b9e15b3406f588bbbc6da9d91a2143350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b7c9d40cb15d3c2bc2ec047edc1592a767f5f23]

        XUnoTunnel->dynamic_cast in SdLayer
        
        Change-Id: Id61d38dd9f3066d07ec325494753cd9096152e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [89ee1addd06d913ab65d61e01cf05d688bdc9904]

        XUnoTunnel->dynamic_cast in SdLayerManager
        
        Change-Id: Ibea94a8168538e59eea6312fd49b162534df8d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0a1227d2fa7812bd1e6cffc2bb4e4213185c99f]

        XUnoTunnel->dynamic_cast in SdUnoPageBackground
        
        Change-Id: I67e911eba5333770b83a3b5e7e2c1a7bc96ef1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Jean-Pierre Ledure  <jp@ledure.be>  [4525c47fa150bfc13b93763a3bce910623158810]

        ScriptForge (SF_Calc) fix typo
        
        Change-Id: I086d4f9f6490ecce773aef598049af07b5f852d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145978
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-22  Jean-Pierre Ledure  <jp@ledure.be>  [3563f2064ab4b4772dd805a4acff9e541a723431]

        ScriptForge Upgrade version number to 7.6
        
        Change-Id: Ifbf5ba5b28b7afff64ed36965eadfa68a750cfd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145976
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff496c663904d97567f1876b2d9b758131f71be8]

        XUnoTunnel->dynamic_cast in SdUnoSearchReplaceDescriptor
        
        Change-Id: I26038e7d57f30b8cca661a5b4d56b8bb685eedd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [bddbc496942948f94f4c9665ac6eea4b1b28da61]

        AsyncFunc header is dead
        
        since
            commit 688489959e69994d455f36f3e9bb4c0ba3ee87aa
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Tue Nov 2 14:25:24 2021 +0000
            Revert "tdf#117895: "Edit document properties before saving"..."
        
        Change-Id: I65239b4d9ca96075701121edc32d07c91631c629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145966
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [78bef23cc49a3a328f9e9ef38f7c0d0cd05f2ef8]

        XUnoTunnel->dynamic_cast in SwXAutoTextGroup
        
        we can store the underlying type here, which does away with the need for
        dynamic_cast
        
        Change-Id: I9b545f7eb6cbd1d2a81773bc1d80127422a0ed3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145926
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Rene Engelhard  <rene@debian.org>  [a180a99e2d53a2ca04e8fe31a38f6994e42bf69b]

        check for harfbuzz >= 2.6.8
        
        because of hb_ot_layout_lookup_get_glyph_alternates() usage, see
        https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/commit/?h=wip/lunar-7.5&id=97d1a9d48f30394d86db0ce948c4fb8986afc701
        and
        https://harfbuzz.github.io/harfbuzz-hb-ot-layout.html#hb-ot-layout-lookup-get-glyph-alternates:
        "Since: 2.6.8"
        
        Change-Id: I755c42745f3bdd647fcd7c101ea7e5fde24c5a6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145965
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: René Engelhard <rene@debian.org>

2023-01-22  Regina Henschel  <rb.henschel@t-online.de>  [7eac3e78abcdece849b8bac61545b0d3ddf5800c]

        tdf#128568 Improve export to docx of Fontwork with bitmap fill
        
        The modern 'abc transform' in Word is not able to use bitmap fill, but
        it is possible in legacy VML. Thus use VML in such cases.
        
        A WordArt shape in VML has the text not in a <txbxContent> element but
        as string='...' attribute in the <v:textpath> element. To detect
        whether a custom shape is a Fontwork in an easy way without cast, I
        have added the already for custom shapes existing method IsTextPath()
        to the basis class SdrObject.
        
        Using VML for Fontwork with bitmap fill, errors in the VML code become
        visible:
        * Using <v:imagedata> element results in Word in a picture of the shape.
        The shape itself was lost. A bitmap fill of a shape has to be written
        with the <v:fill> element.
        * Mode 'stretched' in LO UI becomes type='frame' attribute in VML.
        
        I have adapted the unit test NoFillAttrInImagedata in ooxmlexport2.cxx
        in sw. The source file has the background image in a v:fill element.
        If you replace the 'wps' namespace with a 'my' namespace in the file
        generated by LO and so force Word to use the Fallback, you will see
        that with v:imagedata Word does not show a background image. Thus the
        assumption in the test was wrong, that there has to be a v:imagedata
        element.
        
        Change-Id: I6b2b5b8bb19adcee3b41e536419556465e85d135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145823
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [a00556ada3214d7584bebd4d6ac33bf5c25a3467]

        tdf#153094: Fix default character style index, and document it
        
        Thanks Caolán for catching it, and providing the relevant
        documentation pointers! See
        https://gerrit.libreoffice.org/c/core/+/145806/1#message-c4a9649a8381bd1885d39923fe278b86bc07a228
        
        Change-Id: I6379579befda583f609f87d973fcfaacf9f1fed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145963
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b228565546176b459eb610e11c026d9493771280]

        avoid some casting in SwView_Impl
        
        by just storing the underlying type
        
        Change-Id: I5d811b64145003fd3df349a6375b7f44cf125623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8aaa1778bb7b65b6e498c26fb03fd8757a3329ae]

        XUnoTunnel->dynamic_cast in SwXDispatchProviderInterceptor
        
        just store the underlying type, elides the need for dynamic_cast
        
        Change-Id: I974bf72f71a37b8dae25750c8f29648bb67adc09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ebf6bf0e32d3b937be2d950591d3abffde135b14]

        Fix typos
        
        Change-Id: Ie6dcedee4a1202f43feee99169172e2a3b1523b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145959
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-21  Caolán McNamara  <caolanm@redhat.com>  [d2a7eb1f15013cd06942a47e83eaa4a3298b12f7]

        rhbz#2162862 null pFrame during teardown
        
        Change-Id: Iad2de93f0400b0ec49dae4c3d6979957784114f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [858ce89ab7c32f586f03cce41bd3a406eb01b490]

        Fix typo
        
        Change-Id: I276af93573a6b56a810265ba84b83c56c96b251d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145933
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b09954a06a2e45417ed503165ff05f49d49395a2]

        XUnoTunnel->dynamic_cast in SwXAutoTextEntry
        
        just store the concrete type in the vector, which avoids all the
        dynamic_cast anyway
        
        Change-Id: Id8f37ee1c630e6e94e1b23f780f88d56f980a118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145925
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fd3fd36302f33fa0dda8ade3f99e40d2db138bc]

        fix ZipPackageHelper::addFile
        
        after
            commit a04bf69bccfbc266643b418ef57030a42bbb5c05
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jan 16 10:36:59 2023 +0200
            XUnoTunnel->dynamic_cast in ZipPackageEntry
        it no longer implements XUnoTunnel.
        
        And add an assert, the createInstance call should never fail.
        
        Change-Id: I9a0698862ba783057a299b9c52ebc2b828cc2ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c08e71af3629bc653f9eca8e570a3be9eaabac8]

        XUnoTunnel->dynamic_cast in SvUnoImageMapObject/SvUnoImageMap
        
        Change-Id: Ia8b862e5bfe4ade3f70521874e8549f939de810e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3e9f296e34a0d6bba7f13b57286087755a4bf03]

        XUnoTunnel->dynamic_cast in SwXTextSection
        
        Change-Id: I135469fa06c5037e03e25d3b6c0ab660c4a34995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0166dc67168a6ac95d527099610d5756d062c0fe]

        XUnoTunnel->dynamic_cast in SwXReferenceMark
        
        Change-Id: Idc187ac62fe1c8cba8bdce55d7c699f01dac52f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145923
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Jean-Pierre Ledure  <jp@ledure.be>  [ac21a5ee9b51ab771736a2695426196f2f663c34]

        ScriptForge (SF_Calc) new RemoveDuplicates() method
        
        Remove duplicate values from a range of values.
        
        The comparison between rows is done on a subset
        of the columns in the range.
        The resulting range replaces the input range,
        in which, either:
          all duplicate rows are cleared from their content
          all duplicate rows are suppressed
            and rows below are pushed upwards.
        
        Anyway, the first copy of each set of duplicates
        is kept and the initial sequence is preserved.
        
        Arguments of the method:
          Range: the range, as a string,
                 from which the duplicate rows should be removed
          Columns: an array of column numbers to compare;
                   items are in the interval [1 .. range width]
                   Default = the first column in the range
          Header: when True, the first row is a header row.
                   Default = False.
          CaseSensitive: for string comparisons.
                         Default = False.
          Mode: either "CLEAR" or "COMPACT" (Default)
                For large ranges, the "COMPACT" mode
                is probably significantly slower.
        
        The method has been implemented for Basic
        and Python user scripts.
        
        The calc.xhp help page should be updated accordingly.
        
        Change-Id: I352b2f3da98974d9482575850550cec4e27d2e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145954
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [c97441a5ee8a86a37fac0b506d0af0c2ae6d51fb]

        XUnoTunnel->dynamic_cast in SwXTextPortion
        
        Change-Id: I2994fc3197de34ef756fcba27d111c7597af6aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4d1c60fbbbfe2bc1cee13c7f794c47d25bb0dbd]

        XUnoTunnel->dynamic_cast in SwXTextPortionEnumeration
        
        Change-Id: I85deec68e8ed99eb9fe266ac90da04087ab1e075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Noel Grandin  <noelgrandin@gmail.com>  [02c4386a09c7364d58c50a388ff77db14810a218]

        move presenter console from sdext/ to sd/
        
        It really wants to part of the main sd UI where it can interact
        nicely with the existing logic, instead of using awkward UNO
        APIs.
        
        Change-Id: I6e0d486275515d48abe3438b88d4f58d4bee58fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-21  Caolán McNamara  <caolanm@redhat.com>  [bd0b3aac25b5163ae21fff613131cb3ff068e816]

        tdf#144915 effectively remove limit on number of words in dictionary
        
        this was 2000 entries in the initial checkin, then changed to 30000
        (in 2008). Lets makes it effectively unlimited.
        
        Change-Id: Ia757e3283f1ff41d62e6738af9d1f6674ba2fd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145916
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-21  Mike Kaganski  <mike.kaganski@collabora.com>  [c31267e23603c77e3a3335fa431bb9b74448d5b2]

        tdf#153128: do not increase line height, when ignoring whitespace
        
        Since 2006, there is IgnoreTabsAndBlanksForLineCalculation compat flag,
        that handles whitespace-only text portions like in Word, not affecting
        resulting line height.
        
        The implementation, however, did not check if the corrected value is
        no larger than the old one. In the bugdoc, this increased the resulting
        line height.
        
        Change-Id: If855af3e87fd1458d92a36fdbcfa2c681a1075ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145919
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-21  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [6b6d1dc7bc402d1d966e506b91729c1c1cafb8d1]

        SDPR: Unified some stuff & moved to tooling
        
        Added and unified usage of a helper to create primitive
        sub content easily, also for visibility checking of
        primitives. Some smaller cleanups, too.
        
        Change-Id: I3c4cd3e98e62b8cf7984351dbb0b154470fd8e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145908
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-21  Caolán McNamara  <caolanm@redhat.com>  [25e1c1ee09a09f3c84088b233112a8ec4545f9c0]

        don't crash with --disable-pdfium
        
        Change-Id: If754b2323f877379523115d6dca73c97ae539a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145917
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [7c15ffd4e3bf002c3d4edd758bb3af27b1f6a34e]

        Related: rhbz#2136459 use a value which is exactly representable as a float
        
        20 builds in a row with the old value all succeeded for me on F38 anyway,
        so if the problem still exists this almost certainly doesn't do anything.
        But it's nice for debugging to use something that is printed the same by a debugger as seen in the source.
        
        also see: tdf#125978
        
        Change-Id: I42dc5f18c22acc006bffb57578bacb65dbc16013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143116
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [0f98e004706439057bfeef23514598c40cfef11b]

        cid#1520426 Unchecked dynamic_cast
        
        and
        
        cid#1520427 Unchecked dynamic_cast
        cid#1520428 Unchecked dynamic_cast
        cid#1520429 Unchecked dynamic_cast
        
        Change-Id: I618308e02910faf8999e89981f7a396314fa751a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [114d41a0a8ffd6801896d04e01dd6cd0f13f7e34]

        don't crash with --disable-pdfium
        
        Change-Id: I194e5624344aa4f6699e855624ce8c5286c8cd25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [022085ece4149a31d22cc85028e71cd2340409ed]

        New loplugin:unoaggregation
        
        "Find classes that derive from css::uno::XAggregation, but which implement
        queryInterface in violation of the protocol laid out in the documentation at
        udkapi/com/sun/star/uno/XAggregation.idl (which implies that such a class either
        doesn't actually make use of the deprecated XAggregation mechanism, which should
        thus be removed from that class hierarchy, or that its implementation of
        queryInterface needs to be fixed)." (compilerplugins/clang/unoaggregation.cxx)
        
        The basesHaveOnlyPureQueryInterface check in
        compilerplugins/clang/unoaggregation.cxx is "a crude approximation (but which
        appears to work OK)" to filter out any queryInterface base implementations of
        class hierarchies supporting XAggregation (i.e.,
        cppu::OWeakAggObject::queryInterface).  It only fails for the odd
        ChartDocumentWrapper::queryInterface, which manually implements the XAggregation
        functionality rather than (indirectly) deriving from OWeakAggObject.  But
        changing that manual implementation looks tricky, so leave that alone for now
        and add a loplugin warning suppression there, and leave proper clean up for
        later.
        
        Change-Id: Ib16e26237bd703e60b0d9cb7134cb39840842d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145912
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Justin Luth  <justin.luth@collabora.com>  [c6cf80af60d23fc52502f88f24dc23ad85462e77]

        related tdf#125038 FORMTEXT/REF:fix spurious text outside IF field
        
        This builds on top of commit d09336fbdceaafd9320466b660a2b32a07dcc16a
        (tdf#125038 DOCX import: fix lost MERGEFIELD result inside an IF field,
        2019-10-31), and extends it for FORMTEXT and REF.
        
        With this, all unexpected content is gone from the paragraph.
        
        Actually this is all somewhat irrelevant since DOCX doesn't import
        IF fields at all anyway - they are just left blank.
        So AFAICS, we should ALWAYS return false at this point.
        
        I also took the opportunity to be able to remove multiple
        spaces from the front of the command.
        
        Change-Id: Ib7e7971bce86bdda545166e398fbb620ca515b91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145832
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-20  Patrick Luby  <plubius@neooffice.org>  [de1d75a0cd25f239cdc751dec75c9019fbcabd8e]

        tdf#148453 Fix crash by turning off optimization for Objective-C selector
        
        The default attributes sequence sometimes crashes when it is released but
        only when compiler optimization is enabled, so disable optimization for the
        +[AquaA11yTextAttributesWrapper createAttributedStringForElement] selector.
        
        Also, disabling optimization by itself is apparently not enough to stop
        the crashing. Acquiring the solar mutex during native accessibility calls
        is also needed. Native accessibility calls are called from native input
        sources in [NSApp nextEventMatchingMask:untilDate:inMode:dequeue:]. Since
        AquaSalInstance::DoYield() releases the solar mutex before calling
        [NSApp nextEventMatchingMask:untilDate:inMode:dequeue:], we need to
        always acquire the solar mutex during all NSAccessibility selectors (both
        the old informal protocol and the newer formal protocol) that we implement.
        
        Change-Id: I9b715e17e9c5a32b7ce28815e288b2af236c3cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145742
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb32938d572777c9a5d75007cc76ba50c5a698eb]

        [API CHANGE] remove unused SlideSorterService
        
        which was introduced in
        
            commit 8c4d7aa42dd4b3b08c3b4a9e4ba772737b7bd0c4
            Author: Kurt Zenker <kz@openoffice.org>
            Date:   Thu Apr 3 13:42:43 2008 +0000
            INTEGRATION: CWS presenterview (1.1.2); FILE ADDED
        
        but does not appear to have ever been actually used.
        
        Change-Id: Icd33f81cfee246fe72a4b9e584f7a6ca96d6e38b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145907
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4a72caaae9534cd229186fd952603a4ef736ef45]

        [API CHANGE] PresenterTextView UNO service is dead
        
        Nothing constructs it, and it looks like it was never fully hooked up, various bits of it have been removed, starting with
            commit a38cbc58bbe3b385830a5287ea272e28a8ae3652
            Author: Felix Zhang <fezhang@suse.com>
            Date:   Mon Oct 24 17:50:01 2011 +0800
            remove unused methods from sdext:presenter
        
        Change-Id: I61080fa589ab6b886b841d7be5eed892c4bd829a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145898
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2d093c06d047e9efe41c90e7269d0dd2293e9c8]

        no need to load the list of impress/draw modules from config
        
        this is not something that changes
        
        Change-Id: Ie382665690a8baa31c916029de567cccdfdd0425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145897
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [bf1bf0bcd57fdc53bbc0ea97cc83275545398916]

        Base ScAccessibleContextBase on WeakComponentImplHelper
        
        ...rather than on the deprecated WeakAggComponentImplHelper5.
        
        Various classes like ScAccessibleCellBase, ScAccessiblePreviewHeaderCell, and
        ScAccessiblePreviewTable, all deriving from ScAccessibleContextBase, had been
        found to implement their respective queryInterface in a way that is incompatible
        with the XAggregation protocol inherited via WeakAggComponentImplHelper5.  It
        looks like no code actually made use of the XAggregation offered by this class
        hierarchy, so the easiest fix for those queryInterface implementations appears
        to switch from WeakAggComponentImplHelper5 to WeakComponentImplHelper (thereby
        dropping XAggregation, and thus rendering the existing queryInterface
        implementations OK).
        
        Change-Id: Icfd07f0606b7a56d75c32681408384dd3ff51238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145901
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3fc2a2f9170b8dcd1bf21c00f7629a24757a159f]

        Fix typo
        
        Change-Id: I97309a5cf314b08547ac535a2d1baa6e8b7d064c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145910
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [c92060d20c30c7a90c2c2e63fd98cb4d185bb402]

        PresentationFactoryProvider can just be a static method
        
        Change-Id: Ie46d784b10e01e394235b31d986868d72c4dbd10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [99ac0876bd2e9307c6edd4872a130d10436b0452]

        Base BaseControl on WeakComponentImplHelper
        
        ...rather than on the deprecated OComponentHelper.
        
        Various classes like BaseContainerControl, FrameControl, and ProgressBar, all
        deriving from BaseControl, had been found to implement their respective
        queryInterface in a way that is incompatible with the XAggregation protocol
        inherited via OComponentHelper.  It looks like no code actually made use of the
        XAggregation offered by this class hierarchy, so the easiest fix for those
        queryInterface implementations appears to switch from OComponentHelper to
        WeakComponentImplHelper.
        
        Ideally, BaseControl would derive from WeakComponentImplHelper<XServiceInfo,
        XPaintListener, XWindowListener, ...> covering all the UNO interface classes
        from which it currently derives manually.  But changing that manual
        implementation across the BaseControl class Hierarchy looks tricky, so merely
        introduce an "empty" WeakComponentImplHelper<> for now and keep all the manual
        stuff, and leave proper clean up for later.
        
        Change-Id: I1aa8b06f78700008f844415818f4a5801daa89b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145902
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [46f64f6df4a7e545114c4ec92598f6634d38b04b]

        Base OCellListSource on WeakComponentImplHelper
        
        ...rather than on the deprecated WeakAggComponentImplHelper4.
        
        It was found that that class was implementing queryInterface in a way that is
        incompatible with the XAggregation protocol inherited via
        WeakAggComponentImplHelper4.  It looks like no code actually made use of the
        XAggregation offered by this class, so the easiest fix for this queryInterface
        implementation appears to switch from WeakAggComponentImplHelper4 to
        WeakComponentImplHelper (thereby dropping XAggregation, and thus rendering the
        existing queryInterface implementation OK).
        
        Change-Id: I91d7feb28da3fd65ce1e213b59feb4f8dd6fc6b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145899
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [aaa30075e1a5e362ee8610e11ad1739947c06ebd]

        Base OCellValueBinding on WeakComponentImplHelper
        
        ...rather than on the deprecated WeakAggComponentImplHelper5.
        
        It was found that that class was implementing queryInterface in a way that is
        incompatible with the XAggregation protocol inherited via
        WeakAggComponentImplHelper5.  It looks like no code actually made use of the
        XAggregation offered by this class, so the easiest fix for this queryInterface
        implementation appears to switch from WeakAggComponentImplHelper5 to
        WeakComponentImplHelper (thereby dropping XAggregation, and thus rendering the
        existing queryInterface implementation OK).
        
        Change-Id: I43661bd66927f2f605eb1c63e2370838cd03597c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145900
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Radhey Parekh  <radhey.parekh@gmail.com>  [d0700f45c510385a95a181f646d6bb99d085fcaa]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: Icd7610a3b7415838f632579deb2cd2cc505b44a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139001
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f14640a60344452d31edfe246aaad73f91116e57]

        XUnoTunnel->dynamic_cast in SwXMeta
        
        Change-Id: I0111fb210b65d102304708729af4cf543c2eb2ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145883
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [00e38f77443253f574be66bfa696400353995155]

        XUnoTunnel->dynamic_cast in SwXLineBreak
        
        Change-Id: Ic9d3683d33436658ff2360ca259c1e26d522122c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [13b2bd1006182637b189bcfa77acfaf03ae028f0]

        rhbz#2162658 backtrace showing endlessly recursive ScInputWindow::Resize
        
        Change-Id: I2d10fd1ebfb1c25cf213ebb68e7d34e39fadde13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [e280cf69d54048cf8f8d78158f55846980ad2cad]

        don't crash with --disable-pdfium
        
        Change-Id: I946e62d70b937d27b2f1258acc643fdaa5bee23d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145890
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [3816e7b85716db56617667789ae67fab96b3a349]

        Base SwXBodyText on WeakImplHepler
        
        ...rather than on the deprecated WeakAggImplHelper2.
        
        It was found that that class was implementing queryInterface in a way that is
        incompatible with the XAggregation protocol inherited via WeakAggImplHelper2.
        It looks like no code actually made use of the XAggregation offered by this
        class, so the easiest fix for this queryInterface implementation appears to
        switch from WeakAggImplHelper2 to WeakImplHelper (thereby dropping XAggregation,
        and thus rendering the existing queryInterface implementation OK).
        
        Change-Id: Ia66e1d8f89740752d8ed69f0e17b75fa2c470f41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145893
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [30af50006fd31076ea2fccd1a842038e203f15c6]

        Base SwXShapeBaseClass on WeakImplHelper
        
        ...rather than on the deprecated WeakAggImplHelper6.
        
        The two classes SwXShape and SwXGroupShape, both deriving from
        SwXShapeBaseClass, had been found to implement their respective queryInterface
        in a way that is incompatible with the XAggregation protocol inherited via
        WeakAggImplHelper6.  It looks like no code actually made use of the XAggregation
        offered by this class hierarchy, so the easiest fix for those queryInterface
        implementations appears to switch from WeakAggImplHelper6 to WeakImplHelper
        (thereby dropping XAggregation, and thus rendering the existing queryInterface
        implementations OK).
        
        Change-Id: I47dd177db7f3ddbd53482c3b4c194b6e7f15f69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145892
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [8be6e5dcba0fd262421c59364a463e87ef85fe74]

        Base GraphicDescriptor on OWeakObject
        
        ...rather than on the legacy OWeakAggObject.
        
        It was found that e.g. Graphic, deriving from GraphicDescriptor, was
        implementing queryInterface in a way that is incompatible with XAggregation
        protocol inherited via OWeakAggObject.  It looks like no code actually made use
        of the XAggregation offered by this class hierarchy, so the easiest fix for that
        queryInterface implementation appears to switch from OWeakAggObject to
        OWeakObject.
        
        Change-Id: I54514db32b731b9fa83831a1071da6f665fdf25e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145891
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Miklos Vajna  <vmiklos@collabora.com>  [44c75d56cd441ad3d174db75a6e5ae672b7d2a08]

        sw HTML import: initial CSS support on tables
        
        This is the import side of commit
        6ce374140f3bd1cede959ccc8da69fdacecff191 (sw XHTML export: use CSS
        instead of <center> for tables, 2023-01-19), otherwise the import would
        not handle the new markup of the export.
        
        Change-Id: I7d18b06e10adff877dbbf1745861c65a07f807cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145863
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [349844128c876041311d30ba0e7740e73fc89261]

        XUnoTunnel->dynamic_cast in SwXDocumentIndex
        
        Change-Id: Ie1196623d345e20eaaaadf8bb8b4a4db72bf77e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145881
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [730ce18b6a25172a0a7a120b0aa3fd3e4f41319b]

        XUnoTunnel->dynamic_cast in SwXDocumentIndexMark
        
        Change-Id: I8453d08e0fc77019481b08fd508aa97790a06d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145880
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [32c8b03f6172acf3a19c5d1938b9935369f536f1]

        improve loplugin:refcounting
        
        to catch places where we are converting a weak reference to a strong
        reference, and then using a pointer to store the result
        
        Change-Id: I69b132907b574e5c6974fadf18bd9658107d3a0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145877
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Miklos Vajna  <vmiklos@collabora.com>  [a5a1ea2f7d784c5c6c33f332ba61aceb7af3eca4]

        sw: add a new .uno:DeleteSections UNO command
        
        This is similiar to commit 1d6593dd799ff4eb931ffbb5338e4856fb87f77f (sw:
        add a new .uno:DeleteFields UNO command, 2023-01-16), but that deleted
        refmarks (used for e.g. Zotero citations), while this deletes sections
        (used for e.g. Zotero bibliography).
        
        Implement the section "unlinking" (delete the section, but not its data)
        by deleting the section format: that will remove the matching section
        node as well, but not the content nodes.
        
        Change-Id: Ib00a8f592ddbb77c5e8e08ff94bb0eebfcf7cea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145870
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [675a3e3d545c5811c35bbd189ff0a241a83443d0]

        std::abort() during CppunitTest_sw_layoutwriter
        
        seen in fedora distro build. Probably since:
        
        commit 4170b94c443b3bd68b4cc75b8c344ecca3c249b0
        Date:   Tue Nov 8 18:27:05 2022 +0100
        
            SwModelTestBase: inherit from UnoApiXmlTest
        
        See original discussion in https://gerrit.libreoffice.org/c/core/+/142465
        
        use an alternative approach to solve this
        
        [_RUN_____] testTdf143239::TestBody
        Fatal exception: Signal 6
        Stack:
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libuno_sal.so.3(+0x48bd8)[0xffff95428bd8]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libuno_sal.so.3(+0x4fd8c)[0xffff9542fd8c]
        linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffff955247fc]
        /lib64/libc.so.6(+0x8d568)[0xffff94f2d568]
        /lib64/libc.so.6(gsignal+0x20)[0xffff94ee3e80]
        /lib64/libc.so.6(abort+0xf4)[0xffff94ed0284]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN3psp16PrintFontManager10SubstituteERN3vcl4font17FontSelectPatternERN3rtl8OUStringE+0xbc4)[0xffff91980de4]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(+0x891ea8)[0xffff91981ea8]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK3vcl4font22PhysicalFontCollection20GetGlyphFallbackFontERNS0_17FontSelectPatternEP19LogicalFontInstanceRN3rtl8OUStringEi+0xd0)[0xffff9186a7c0]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK12OutputDevice10ImplLayoutERKN3rtl8OUStringEiiRK5Pointl13KernArraySpanN4o3tl4spanIKhEE14SalLayoutFlagsPKN3vcl4text15TextLayoutCacheEPK15SalLayoutGlyphs+0x112c)[0xffff915be0c0]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK12OutputDevice12GetTextArrayERKN3rtl8OUStringEP9KernArrayiibPKN3vcl4text15TextLayoutCacheEPK15SalLayoutGlyphs+0x2c4)[0xffff915bf2b8]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN18ImplFontMetricData20ImplInitTextLineSizeEPK12OutputDevice+0x74)[0xffff91873da4]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK12OutputDevice11ImplNewFontEv+0x1c8)[0xffff915b7318]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(+0x4c5f70)[0xffff915b5f70]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK12OutputDevice14GetFontCharMapERN5tools5SvRefI11FontCharMapEE+0x34)[0xffff915b9004]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZNK12OutputDevice9HasGlyphsERKN3vcl4FontESt17basic_string_viewIDsSt11char_traitsIDsEEii+0x90)[0xffff915b9300]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libsvtlo.so(+0xff560)[0xffff8cadf560]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libsvtlo.so(_ZN11FontNameBox12CachePreviewEmP5Point+0x288)[0xffff8cae0168]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libsvtlo.so(+0x100448)[0xffff8cae0448]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN9Scheduler22CallbackTaskSchedulingEv+0x30c)[0xffff917b050c]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN14SvpSalInstance12CheckTimeoutEb+0x140)[0xffff919790a0]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN14SvpSalInstance9ImplYieldEbb+0x98)[0xffff91979818]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN14SvpSalInstance7DoYieldEbb+0xe0)[0xffff91979b70]
        /builddir/build/BUILD/libreoffice-7.5.0.2/instdir/program/libvcllo.so(_ZN9Scheduler19ProcessEventsToIdleEv+0x40)[0xffff917bac84]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/CppunitTest/libtest_sw_layoutwriter.so(+0x5520c)[0xffff8d87520c]
        /lib64/libcppunit-1.15.so.1(+0x1e4dc)[0xffff9549e4dc]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/Library/unoexceptionprotector.so(+0x107ec)[0xffff94e107ec]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit16DefaultProtector7protectERKNS_7FunctorERKNS_16ProtectorContextE+0x3c)[0xffff9549e1cc]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit14ProtectorChain7protectERKNS_7FunctorERKNS_16ProtectorContextE+0x320)[0xffff954969f4]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit10TestResult7protectERKNS_7FunctorEPNS_4TestERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x80)[0xffff954a06d0]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit8TestCase3runEPNS_10TestResultE+0x11c)[0xffff954a993c]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit13TestComposite15doRunChildTestsEPNS_10TestResultE+0xe0)[0xffff9549e980]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit13TestComposite3runEPNS_10TestResultE+0x58)[0xffff9549e6a8]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit13TestComposite15doRunChildTestsEPNS_10TestResultE+0xe0)[0xffff9549e980]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit13TestComposite3runEPNS_10TestResultE+0x58)[0xffff9549e6a8]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit10TestResult7runTestEPNS_4TestE+0x38)[0xffff9549f5a8]
        /lib64/libcppunit-1.15.so.1(_ZN7CppUnit10TestRunner3runERNS_10TestResultERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x70)[0xffff954a6b70]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/Executable/cppunittester(+0x1443c)[0xaaaac255443c]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/Executable/cppunittester(+0x15390)[0xaaaac2555390]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/Executable/cppunittester(+0x10a38)[0xaaaac2550a38]
        /lib64/libc.so.6(+0x30588)[0xffff94ed0588]
        /lib64/libc.so.6(__libc_start_main+0x9c)[0xffff94ed0660]
        /builddir/build/BUILD/libreoffice-7.5.0.2/workdir/LinkTarget/Executable/cppunittester(+0x10ab0)[0xaaaac2550ab0]
        which: no gdb in (/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/usr/lib/jvm/java-17-openjdk-17.0.6.0.9-0.2.ea.fc38.aarch64/bin)
        You need gdb in your path to show backtraces
        Error: a unit test failed, please do one of:
        make CppunitTest_sw_layoutwriter CPPUNITTRACE="gdb --args"
            # for interactive debugging on Linux
        make CppunitTest_sw_layoutwriter VALGRIND=memcheck
            # for memory checking
        make CppunitTest_sw_layoutwriter DEBUGCPPUNIT=TRUE
            # for exception catching
        You can limit the execution to just one particular test by:
        
        Change-Id: Ife968c5d1d49081b1d28d50a557bc90d59980fc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145874
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [20b64cf1512572b7a57aa78920c025ff05a36964]

        ofz#54685 Timeout
        
        Change-Id: I2f71f61c371055521c884a00dde48a811d204df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145875
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [6e19fdb771ada47a2e90e2e80ba31e2a6aa8e72e]

        Resolves: tdf#153116 null-ptr-deref in get-surrounding-text
        
         #0  SwFrame::IsTextFrame() const (this=0x0) at sw/source/core/inc/frame.hxx:1236
         #1  0x00007fffa8dcb865 in sw::FrameContainsNode(SwContentFrame const&, o3tl::strong_int<int, Tag_SwNodeOffset>) (rFrame=..., nNodeIndex=...) at sw/source/core/text/txtfrm.cxx:292
         #2  0x00007fffa82c9fd4 in SwCursorShell::GetSelText() const (this=0x5509470) at sw/source/core/crsr/crsrsh.cxx:2565
         #3  0x00007fffa89017f0 in SwEditShell::GetSelectedText(rtl::OUString&, ParaBreakType) (this=0x5509470, rBuf="", nHndlParaBrk=ParaBreakType::ToOnlyCR)
             at sw/source/core/edit/edglss.cxx:264
         #4  0x00007fffa97e19a7 in SwEditWin::GetSurroundingText() const (this=0x4f1a9f0) at sw/source/uibase/docvw/edtwin.cxx:6628
         #5  0x00007fffee27cf02 in ImplHandleSurroundingTextRequest(vcl::Window*, rtl::OUString&, Selection&) (pWindow=0x1fe43f0, rText="", rSelRange=...) at vcl/source/window/winproc.cxx:2544
         #6  0x00007fffee27adf7 in ImplHandleSalSurroundingTextRequest(vcl::Window*, SalSurroundingTextRequestEvent*) (pWindow=0x1fe43f0, pEvt=0x7fffffffb970)
             at vcl/source/window/winproc.cxx:2555
         #7  0x00007fffee276ed6 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x1fe43f0, nEvent=SalEvent::SurroundingTextRequest, pEvent=0x7fffffffb970)
             at vcl/source/window/winproc.cxx:2884
         #8  0x00007fffe6ee3080 in SalFrame::CallCallback(SalEvent, void const*) const (this=0x1898310, nEvent=SalEvent::SurroundingTextRequest, pEvent=0x7fffffffb970) at vcl/inc/salframe.hxx:306
        
        Change-Id: I7330865b5dda7766a6da08f57a7dd8dd1a09d198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145872
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [6d8b48d63ca46306e5d4e6e9e5e7da67760e1736]

        ofz#54895 Out-of-memory
        
        Change-Id: I2faf68d8ed56e7d2b44bc7cae953716ea6dd7172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145878
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  ektagoel12  <ektagoel12july@gmail.com>  [841ab19fb3f68dbab6295459ef11a257f0f022e8]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I4b16fc7daff2f85ae60666e512636634f7d6eb19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145822
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [bb3ddcf7ae63879f50c9e88fcc01003e66c7288b]

        change test to use Calibri instead of Cambria
        
        because of the Caladea problem
        
        There are sadly now two Caladea fonts with different metrics, see:
         https://bugzilla.redhat.com/show_bug.cgi?id=2162532
         https://github.com/huertatipografica/Caladea/issues/4
        
        Change-Id: I7080d16ec8aae2bbe60717aea85b980a33340e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145830
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Mike Kaganski  <mike.kaganski@collabora.com>  [dc2ad435cd148a492aba3f2b18bbba0c769f463e]

        tdf#153094: it seems that DOC requires WW8_RESERVED_SLOTS = 15
        
        Regression from commit a2a08463e0299d514e6e555ae61c68bb0e4348d0,
        where I mistakenly assumed that the value is just to accommodate
        enough entries. I don't know where it's documented, but this
        fixes the bug.
        
        Change-Id: Ifecf5d294222e3a40cb23f7c147694dbdf35e405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145869
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [16f59f4b2b50dbca353aa468512e7f704fa903ad]

        Fix SbaXGridControl queryAggregation
        
        The base UnoControl uses WeakAggImplHelper9, so (for better or worse) derives
        from XAggregation, but SbaXGridControl failed to properly implement the
        XAggregation protocol.
        
        Change-Id: I26c825b9b64b4e886e69f95bc3d4d5d42120bd8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145865
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [53a809ac9caca22062d33ce97c25d0a8a9b84c47]

        Fix TableColumn/-Row queryAggregation
        
        The base FastPropertySet uses WeakAggImplHelper3, so (for better or worse)
        derives from XAggregation, but SbaXGridControl failed to properly implement the
        XAggregation protocol.
        
        Change-Id: I31378f13256b1fa20775890b206f455d782ea864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145868
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [f2cff6567b47f7898eb5e90a0abbcc1ded7568ef]

        Base Im-/ExportDocumentHandler on WeakImplHelper
        
        ...rather than on the deprecated WeakAggImplHelper3.
        
        It was found that those two classes were implementing queryInterface in a way
        that is incompatible with the XAggregation protocol inherited via
        WeakAggImplHelper3.  It looks like no code actually made use of the XAggregation
        offered by these classes, so the easiest fix for those queryInterface
        implementations appears to switch from WeakAggImplHelper3 to WeakImplHelper
        (thereby dropping XAggregation, and thus rendering the existing queryInterface
        implementations OK).
        
        Change-Id: I8f841ca959838d9a87943091b76f3ce1cf8c9303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145866
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Stephan Bergmann  <sbergman@redhat.com>  [f05061f91260262e149e2777ac8062f1619758d8]

        Base CellRange on WeakImplHelper
        
        ...rather than on the deprecated WeakAggImplHelper1.
        
        It was found that that class was implementing queryInterface in a way that is
        incompatible with the XAggregation protocol inherited via WeakAggImplHelper1.
        It looks like no code actually made use of the XAggregation offered by this
        class, so the easiest fix for this queryInterface implementation appears to
        switch from WeakAggImplHelper1 to WeakImplHelper (thereby dropping XAggregation,
        and thus rendering the existing queryInterface implementation OK).
        
        Change-Id: I2352f5a57f2e23e6c7d512ef4d850844149269c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145867
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-20  Gülşah Köse  <gulsah.kose@collabora.com>  [48e84907845daaf633991f88efb85d93c058a88d]

        Hide fill Attribute widget if fill style is none
        
        When Fill style is none we can not use fill attribute element. So It is
        better to hide.
        
        Change-Id: I88d5e49448040b3afa18fbf66377d254716e7415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145817
        Tested-by: Jenkins
        Tested-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b70eee2d394dd7249c2de0cb41ccc47f80a05f8f]

        tdf#150819 crash after a few paste and undo
        
        regression from
            commit 3a02b5f8aae803b7b5a232c724135594483627a4
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Aug 16 18:44:31 2022 +0200
            convert more nNode to SwPosition::GetNode
        
        Change-Id: I636590ec5eb28f0db3640464a49f0ab5582ff853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145864
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [231ad90b597410cab7f4f2e9a7b4547d97fb9972]

        tdf#149412 gtk3: show all selected rows in dnd icon
        
        otherwise it looks like only one row is getting moved
        
        Change-Id: Ie0b63a9c3cea377c3753785d9c6f7958cbc7ac1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145818
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Caolán McNamara  <caolanm@redhat.com>  [bf052b03d2258ea101a0a3ae4b5e72cc85a9f856]

        add a warning about Caladea versions/variants with different metrics
        
        Change-Id: Id8c2679b2b9984f1fa7a133c40e8536cded12c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145829
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [500a3b85a621cda94ea1502b58a4e2cacf58261e]

        XUnoTunnel->dynamic_cast in SwXFlatParagraph
        
        Change-Id: I6bbe75ae26d5411d2d032311e8877632b1e4d850
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145862
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [468a50db510f2d001e656cbfb285445e265af47c]

        XUnoTunnel->dynamic_cast in SwXTextField
        
        Change-Id: I31dcd7a498e2742c49d98e5626f10aa7dcafa8f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [54d12f7b1fef71ca47682fc7dc2764512bd23946]

        XUnoTunnel->dynamic_cast in SwXFieldMaster
        
        Change-Id: I85f4ffab71b8321cc592e3b70fec63111bbd78ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145860
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [080b78ea0c27659468ae084c0416017d91e4392d]

        XUnoTunnel->dynamic_cast in SwXContentControl
        
        Change-Id: I4513cc38b31062327a773afd91dd3b4ee98c1bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145859
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [048dd914c251ef62d7cebf4d35ded3549bf42110]

        XUnoTunnel->dynamic_cast in SwXBookmark
        
        Change-Id: Iaf544314d0c47209b254c3bb40d35c03e6556f5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [635448a996714a81cb15b41ac4bb0c73cabfb74f]

        XUnoTunnel->dynamic_cast in SwXTextRange
        
        Change-Id: I87e635f371278132be9da4e6a60ba90180d25522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Attila Szűcs  <attila.szucs@collabora.com>  [f9d6dd788e82a1964dab9cc0d0436c8c54b775c0]

        tdf#148000 impress: Handle linebreaks on fontwork.
        
        Split text lines in a paragraph, right before polygons are created
        for rendering, so eol will brake line in fontwork just like eop.
        
        Change-Id: Ie9e6764f9f91c2e19afd43dc9a212bd18c41c99d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145425
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-20  Miklos Vajna  <vmiklos@collabora.com>  [14da39fcfffe8006a79971ac0b670e12d0d7a0ea]

        tdf#153047 sw: fix PDF export of content controls in placeholder mode
        
        Importing an inline content control from DOCX used to be just plain text
        in Writer, so the PDF export of that was also just plain text.
        
        Now that content controls are actually supported, we used to not emit
        them as plain text in the PDF export, since
        82d90529dc2b3cb8359dec78852cbd910a66d275 (sw content controls, rich
        text: add initial PDF export, 2022-09-12). Part of this was to write the
        string value of the content control as the /V (value) key of the form,
        when it's not in placeholder mode. This made sure that once the form is
        filled in, no overlap between the plain text and the filled in text
        happens.
        
        Try to support both use-cases at the same time by also mapping the value
        of the content control to /V, even if it's in placeholder mode. This
        keeps avoiding the unwanted overlap, but this way the placeholder text
        is no longer lost on PDF export.
        
        An alternative would have been to map the placeholder text to
        description when the alias/title is empty, but that would show up only
        as a mouse tooltip, so won't change the behavior when the PDF is
        printed.
        
        Change-Id: I9408b5abe36af28cd00845a74a3dfff13973b83a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145828
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c06cfcd13195e9e996bc09dbee2dcac1c5e8ed2]

        [API CHANGE] no need to load PresentationFactoryProvider via UNO and/or config
        
        there is no benefit to having this constructed in such a convoluted
        manner
        
        Change-Id: Ib02b4bfe689326784bd8233003d10960700811d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-20  Justin Luth  <justin.luth@collabora.com>  [d2cd7097ab8d8fe1a69b9f6e4a11c978b667951a]

        NFC writerfilter: avoid unnecessary code processing
        
        Early return on useless parameter,
        and conditional processing on missing ID.
        
        Change-Id: Iecf2d7522bd0c1e958f826214368966399be311c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145831
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-20  Jim Raykowski  <raykowj@gmail.com>  [1c638b7ac46d8077994c8483e6becc4a33efd12b]

        tdf#149073 SwNavigator: provide an indication for linked images
        
        Sets an image for image content entries that are of linked type
        
        Function 'InsertContent' added to replace duplicated code that
        inserts content.
        
        Change-Id: I25dec3f5765fa3dffe505743cd9c5fe044349ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145530
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-19  Justin Luth  <jluth@mail.com>  [85ae3d1513d4be3eb102bf3065ddfba27cb1f1c3]

        tdf#141649 doc import: do not duplicate conditional text
        
        This patch is a mixed blessing.
        It will be a regression if an IF FIELD was bogus,
        and the user only wanted to see the modified, unrefreshed text.
        
        That is because in MS Word, most fields do not update automatically,
        but require the user to press F9 to refresh the contents.
        The contents are also editable, so the result might not match
        either the true or false result-string.
        
        However, in LO the IF FIELD is always refreshed, and thus will
        never display any bogus hand-modifications.
        
        The import of these IF fields started in DOC in LO 6.1,
        but it was never correct and immediately duplicated content.
        Additionally, DOC format didn't export at all, so anything
        to do with IF FIELDS was lost - meaning that after a round-trip
        the result was the same as what MS Word last saw with the field gone.
        
        So in the eyes of the user, the fixing of import and export
        might be causing a regression of changed text.
        So be it.
        
        I can only assume that in most cases the use of an IF FIELD
        is intentional and that it would be desirsable to have it working.
        
        Change-Id: If90f6f4cddcefebf379352aac6519595c1bf2b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145821
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a29ec09f7c2a01f131095fd9b2ecafa0812e8325]

        tdf#135938 - Search for "insert reference" tree entry
        
        Instead of assuming that the "insert reference" entry is always the second item of the menu tree, search for the correct child in the tree list. This commit addresses the failing build from https://gerrit.libreoffice.org/c/core/+/140985.
        
        Change-Id: I6f0d7021ab6f632784cab85656823c69f90baf60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145816
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-19  Chenxiong Qi  <qcxhome@gmail.com>  [9753aa4a776af24c1bfb9cd41867ee2078438934]

        tdf#143123 Port some Spreadsheet Java examples to Python
        
        Some examples inside odk/examples/java/Spreadsheet are ported to
        Python:
        
        ChartTypeChange.java    -> ChartTypeChange.py
        EuroAdaption.java       -> EuroAdaption.py
        SCalc.java              -> SCalc.py
        
        Code format is checked with 'pycodestyle':
        
            pycodestyle --ignore=E501,E722 odk/examples/python/Spreadsheet/*.py
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: If0631b5970faab6499cfea3eef559e003fad24d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143810
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d68c4e24ecf117f89d6af81cfbebc0cf6a6c039]

        XUnoTunnel->dynamic_cast in SwXTextRanges
        
        Change-Id: I12565dcdd1437c461762688ed3bf0e1adad828ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Caolán McNamara  <caolanm@redhat.com>  [6ef1b38885b748d8d48e0628acdf4491f4d8803f]

        Resolves: tdf#153091 support text/plain without encoding from nedit
        
        Change-Id: I56dfc6dfec21b8c57b6f402c53b0229a2a2e7778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145824
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [959f64dbb85d1785dbea5a4d2a41519c98769a7c]

        sw: crashtesting forum-mso-en-12641.docx, fix assert in FindFieldSep
        
        The fieldmark may overlap a section; at the start was considered here,
        but at the end was not and so the assertion wrongly fired.
        
        Change-Id: I118bc36c2d9c4ca7028a583278d0f193537c4cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145826
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [c83ec45d7d36d8371ec3fab843fdace6b23ac153]

        Base AccessibleGridControlBase on WeakComponentImplHelper
        
        ...rather than on the deprecated WeakAggComponentImplHelper4.
        
        It was found that e.g. GridControlAccessibleElement, deriving from
        AccessibleGridControlBase, was implementing queryInterface in a way that is
        incompatible with the XAggregation protocol inherited via
        WeakAggComponentImplHelper4.  It looks like no code actually made use of the
        XAggregation offered by this class hierarchy, so the easiest fix for that
        queryInterface implementation appears to switch from
        WeakAggComponentImplHelper4 to WeakComponentImplHelper (thereby dropping
        XAggregation, and thus rendering the existing queryInterface implementation OK).
        
        Change-Id: Ia7f033d0a93e78a48573cb489dc5542603c35b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145793
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d2bee35c46018e9699d76f117f9a80f71cb4597]

        XUnoTunnel->dynamic_cast in SwXTextTable
        
        Change-Id: I18c229f31738707e4a379c9379425141ba4dc690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145787
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c25ccbd0e6e08750aff9efff5b579b21651d3b6]

        XUnoTunnel->dynamic_cast in SwXCellRange
        
        Change-Id: Ib2ffd8a58eb696dfa845a08f6d05fd9898ff7db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145785
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc87e206f4201cbd3d4df8f14355fb29643768f7]

        XUnoTunnel->dynamic_cast in SwXTextSearch
        
        Change-Id: Id9d80bac06377018eaf768bdbd68e98b1de0666b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ebf0023e663b18f06631dbd4fd5782a626c2458]

        XUnoTunnel->dynamic_cast in SwXNumberingRules
        
        Change-Id: If22cf501522115ebd87dee8580831750ea8bbbd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [70eb1c9838bf9ab7650318381e7d48f811e761d4]

        XUnoTunnel->dynamic_cast in SwXParagraph
        
        Change-Id: Ib39e51900826b13824906c33775a8aa375955fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145780
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [bbe9d53fab5212040867adaa0cd6341d50ae244d]

        storing WeakReference in std::set is a bad idea
        
        because if we allocate two things in the same location, we can subtlely
        lose the second one.
        
        Change-Id: I4dda5c738802da8544d280c020e059da63b5d71c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [b09c70ec15b4f94688a19f72782c3dc627590c8c]

        Fix SwFmDrawPage queryAggregation
        
        The base SvxDrawPage uses WeakAggImplHelper7, so (for better or worse) derives
        from XAggregation, but SwFmDrawPage failed to properly implement the
        XAggregation protocol.
        
        Change-Id: Idf2c2d27cd5fb443e574cfd770091600a23c6e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145771
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Szymon Kłos  <szymon.klos@collabora.com>  [280e55bf440b32ec87ce79271276c24f55172663]

        Remove not necessary container in Animation Panel in Impress Sidebar
        
        It was causing layouting issues in LOK.
        
        Change-Id: Ic7520f46efa764d2d6b50b021b44e0a5dd07d837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136343
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145791
        Tested-by: Jenkins

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [41f659b49250dd62abc141afaa3c73cc63a425e3]

        Base SfxLibrary on WeakComponentImplHelper
        
        ...rather than on the deprecated OComponentHelper.
        
        The two classes SfxDialogLibrary and SfxScriptLibrary, both deriving from
        SfxLibrary, had been found to implement their respective queryInterface in a way
        that is incompatible with the XAggregation protocol inherited via
        OComponentHelper.  It looks like no code actually made use of the XAggregation
        offered by these Sfx*Library classes, so the easiest fix for those
        queryInterface implementations appears to switch from OComponentHelper to
        WeakComponentImplHelper (thereby dropping XAggregation, and thus rendering the
        existing queryInterface implementations OK).
        
        Ideally, SfxLibrary would derive from WeakComponentImplHelper<XInitialization,
        XStorageBasedLibraryContainer, XLibraryContainerPassword, ...> covering all the
        UNO interface classes from which it currently derives manually.  But changing
        that manual implementation across SfxLibrary and its SfxDialogLibrary and
        SfxScriptLibrary derived classes looks tricky, so merely introduce an "empty"
        WeakComponentImplHelper<> for now and keep all the manual stuff, and leave
        proper clean up for later.
        
        Change-Id: I12dc5bad2c017b8d76ce28ac189e95cf2e3810e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145792
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [52b465e271961a65f356c9a5b354acead3c0a849]

        Fix typo
        
        Change-Id: Iba92ac9d7093b7fd8d6d61be2496333ad1d8b59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145815
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-19  Miklos Vajna  <vmiklos@collabora.com>  [6ce374140f3bd1cede959ccc8da69fdacecff191]

        sw XHTML export: use CSS instead of <center> for tables
        
        <center> is not valid XHTML, have to use CSS styling instead.
        
        HTML export uses <center> by default around tables where the alignment
        is center.
        
        Fix the problem by avoiding <center> in the XHTML case and set the left
        and right margin to auto, which means:
        
        	If the values of margin-left and margin-right are both auto, the
        	calculated space is evenly distributed.
        
        according to
        <https://developer.mozilla.org/en-US/docs/Web/CSS/margin-left>.
        
        The import will be adjusted to recognize the new markup in a follow-up
        change.
        
        Change-Id: I51e3507e9cde713f961b783378d66db59194a6ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145814
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [261b1237532f431963358a7b4ac5fd1ad6e5d223]

        tdf#153039 ucb: webdav-curl: fix POST, which was actually doing PUT
        
        The problem is that first CURLOPT_POST was set and later CURLOPT_UPLOAD,
        which overrides the HTTP method to PUT.  Move this out to the 4
        functions that need it.
        
        Change-Id: Ibd555dcc00a03baa1bb300a9ab9905f383179c67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145786
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [925dfcb507c4054e00e5aa9acdbfa095b6a32d05]

        Base OPropertyBag on WeakImplHelper
        
        ...rather than on the deprecated WeakAggImplHellper5
        
        Change-Id: Id9e61341cba10c4a497500d41479629ff3af30ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145790
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [1786cd0687c5223821e673fe4d2f7b2ff65deb00]

        Base IdlReflectionServiceImpl on WeakComponentImplHelper
        
        ...rather than on the deprecated OComponentHelper
        
        Change-Id: Icb83d3cc0a0588a703a9041c00730b2a8d8bb90b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145789
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [8e4740e7a93a03ca0faab40b163a1ec7da806a72]

        tdf#153096: sc: Add UItest
        
        Also add a test for checking the right behaviour when
        changing the content of a cell
        
        Change-Id: I33dda97a467355273d49ddbcab56886a9b1950d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145776
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-19  Mike Kaganski  <mike.kaganski@collabora.com>  [a93cb8acdb1b5986c9fffffdb11f4d33c92925bd]

        tdf#153104: fix the "dummy" levels when overriding lower numbering levels
        
        The problem was that Word treats empty w:num/w:lvlOverride elements
        for higher levels as defining corresponding w:startOverride equal
        to 0. This only shows when the first list element has a lower level
        and resets numbering; in this case, implicit higher levels get zero
        value, and the following higher level items start from 1.
        
        This writes the correct w:startOverride values (from the respective
        rule) to the gap-filling levels.
        
        Change-Id: I18db1c6011bf09826ba586aaec16e7939ecb0c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145770
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-19  Caolán McNamara  <caolanm@redhat.com>  [2f901e483b5ab029a2f809acb68b49aafa2c77c3]

        save last mouse press location even if no handlers set
        
        Change-Id: I24ce412fd3b62843ee3fabc7a3fca36ae91c0222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-19  Caolán McNamara  <caolanm@redhat.com>  [a7a842f4a437216cba8cd623306506aa30db7d8e]

        use cairo_surface_destroy after gtk_drag_set_icon_surface
        
        Change-Id: Iac543121a809eeabae630d4a426e72d5f9d47057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145783
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-19  Szymon Kłos  <szymon.klos@collabora.com>  [24c9373409dda957ad6e1f1b4e3ec6c7135ecf1a]

        jsdialog: add TreeView to TestWidgetDialog
        
        Change-Id: I5c4f70d98dd8ea03c137cd368a2c097cd866609d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144222
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145067
        Tested-by: Jenkins

2023-01-19  NickWingate  <nick.wingate@collabora.com>  [7ebe5e19fb379c88b8e455693a23fd9036c1b517]

        Make PDFExport Password Subdialog Async
        
        Dialog in File>Export As PDF>Security>Set Password
        Close subdialog when parent dialog is closed
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: I9db8459309f2806ed47f9f932e0bde246400b2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144854
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145759
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [ee8aa3dbaf6c02c9ea1bd7781e5e71847b4e614b]

        Fix SvxFmDrawPage et al getTypes
        
        The implementation of SxvFmDrawPage::getTypes was presumably forgotten when
        e97beb270fd1a5121cdb69ffafd12ea04100e290 "NTEGRATION: CWS xmlperf02" changed
        SvxFmDrawPage from supporting XFormsSupplier to supporting XFormsSupplier2
        (which derives from XFormsSupplier).
        
        And SwFmDrawPage uses ImplInheritanceHelper to derivefrom SvxFmDrawPage, so
        there should be no need to implement SwFmDrawPage::getTypes manually (and
        wrongly, at that, in that it included the types of SvxFmDrawPage twice, once
        directly via SvxFmDrawPage::getTypes(), and once indirectly via
        SwFmDrawPage_Base::getTypes()).
        
        Change-Id: I8c467f5a20e1f44396378abe9199851e646f6947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145772
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [9b9bc7461e0513e2bb493e7f00f800b2463751e1]

        tdf#153039 unoxml: replace root element of CDocument throws
        
        XForms replace doesn't work because:
        
        CDocument::IsChildTypeAllowed() tests that the document node does not
        already have an element child, because only one is allowed - but when
        called from CNode::replaceChild(), the existing child will be removed,
        so that needs to be allowed to proceed (check that removed child is
        also element).
        
        (regression from commit c5db3b93ee1058bd20ebcde2e757b52b9a67b74a)
        
        Change-Id: I167de3462f4d1934dbf8404ad395349897cfd981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Szymon Kłos  <szymon.klos@collabora.com>  [451ed0f27716906f2015f0c063f6c4ab3704ee66]

        lok: adjust paint rect for in-place editing
        
        This allows to send correct cursor position (at the very end
        of the cell) when typing numbers in LOK mode.
        
        This fixes regression from:
        commit	9257486636dfe95b73e5690462ba6e8408a12166
        lok: sc: render expanded EditEngine when editing in-place
        
        Change-Id: I1f6c7ce3de7a2ba7ccbd4f9f9becd49e352cf05e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145260
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145769
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dac12efdce4f5cd83fd78a901186c68f020b7fa]

        XUnoTunnel->dynamic_cast for SwXFrame
        
        Change-Id: I48fd10781e7f09b37b6b0000f68456e8194e6d7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145761
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-19  Caolán McNamara  <caolanm@redhat.com>  [c6668bf7f87bb50ee5d795f17a67666018931b9a]

        cid#1520418 Unchecked dynamic_cast
        
        and
        
        cid#1520419 Unchecked dynamic_cast
        cid#1520420 Unchecked dynamic_cast
        
        Change-Id: Ia5ef238677bd5eadcdb7fc3fcf982d8a1507133c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [579d144290c1617fdb38d09b30900a6bbe390b8d]

        Fix some toolkit UnoControlBase derivates' queryAggregation
        
        The base UnoControl uses WeakAggImplHelper9, so (for better or worse) derives
        from XAggregation, but UnoGridControl, UnoRoadmapControl, and UnoTreeControl all
        failed to properly implement the XAggregation protocol.
        
        Change-Id: Ia1676782e616216f645dc86ba978c2f5887dc508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145767
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Stephan Bergmann  <sbergman@redhat.com>  [ede696562a38a8ffe5c27b397108ee1f59716ae3]

        Fix SdGenericDrawPage et al queryAggregation
        
        The base SvxDrawPage uses WeakAggImplHelper7, so (for better or worse) derives
        from XAggregation, but SdGenericDrawPage and its derived classes (SdDrawPage,
        SdMasterPage) failed to properly implement the XAggregation protocol.
        
        When fixing this, it became apparent that SdGenericDrawPage::queryInterface had
        erroneously delegated to SvxDrawPage::queryInterface rather than to the
        intermediary SvxFmDrawPage::queryInterface, so that querying for e.g.
        XFormsSupplier had only worked by accident:  SdGenericDrawPage::queryInterface
        didn't support it, so delegated to SvxDrawPage::queryInterface, which didn't
        support it, so delegated to WeakAggImplHelper7::queryInterface, which didn't
        support it, so delegated to OWeakAggObject::queryInterface, which (as there was
        no delegator set) delegated to the most derived SvxFmDrawPage::queryAggregation,
        which supports it.
        
        Change-Id: Ia7154d62e493238738e6d15dea2f01a437a70bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-19  Miklos Vajna  <vmiklos@collabora.com>  [04d988d3c368fe07ae3c44c536a4513e424f104e]

        sw, .uno:InsertField: handle Endnote as a value for the Wrapper parameter
        
        This is similar to commit 43d80906c8693ca27c5b3077fbaa259df4004924 (sw:
        .uno:TextFormField: handle Endnote as a value for the Wrapper parameter,
        2023-01-17), but that was for fieldmarks & endnotes, this is for
        refmarks & endnotes.
        
        Change-Id: I46512dd973508f51f7093521c40ad4100dd39ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145762
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-19  Attila Szűcs  <attila.szucs@collabora.com>  [17c68fad2aef917adfdd3d4d651da786e620699c]

        tdf#153036 PPTX import resized connector broken
        
        Fixed the EdgeLine1Delta calculation in case of bentConnector2.
        (when L shape imported as a special Z shape)
        
        Co-authored-by: Tibor Nagy (NISZ)
        Change-Id: I08c92e63adc744322061e4e433bfdc512745eda1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145548
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-19  Miklos Vajna  <vmiklos@collabora.com>  [6819b7eb6ca5187b82833965c8198f3ca868b27a]

        tdf#153045 sw: fix incorrect height of row in table
        
        The bugdoc DOCX had a shape anchored in a table cell, and the cell had
        large enough height so the shape could fit into the cell, while the
        expected cell height was independent (smaller) from the shape.
        
        The problem is around the follow-text-flow feature, which is called
        "keep inside cell boundaries" in Word. This setting would normally
        increase the size of the cell, so the shape remains inside the cell. An
        exception from this increase request is the wrap-through wrap mode,
        which leaves the cell size unchanged.
        
        Fix the problem by considering two previous use-cases:
        1d9221ebc86f2696a65c12287ea19eea44d680cf (tdf#145688 sw: fix misplaced
        images in table cells, 2022-11-29) and
        489eef894e7034873ad262f9dfca554022db1b09 (tdf#124601 sw FollowTextFlow:
        fix vert pos of objects outside the current cell, 2019-10-01):
        
        - tdf#145688 is a legacy ODF document: do require the the "in
          background" wrapping, otherwise make the cells big
        
        - tdf#124601 & tdf#153045 are Word documents: here don't require the "in
          background" wrapping and go with small cells when the wrap type is
          through
        
        This requires adjusting the tdf#145688 testcase that minimized the
        original bugdoc incorrectly.
        
        Change-Id: Ieaf3d9c1c4477e5e57e5e1e825775648840ab32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145756
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c55f9e327ddcede8ebb8235c97a83436a87b5be]

        XUnoTunnel->dynamic_cast in OTextCursorHelper
        
        Change-Id: I9b0101b4f0b96c59ddbde01c7cf7f286aac2a8e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145703
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [cf734427550f1a42f8ac669378719a1cad617bbb]

        tdf#153088 format cells example text black on dark background
        
        with application colors, scheme: LibreOffice Dark enabled
        
        Change-Id: I465c97bf21b66c0122b59296d0c114bf115910ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145758
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [6bf8ffbf90e701073a65e88ce4de26e40a24a07a]

        tdf#152710: sw_odfexport: Add unittest
        
        Change-Id: Ib5ca4aa64f9cfd7e221620ab1d571f7f1e012033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145747
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-18  Justin Luth  <jluth@mail.com>  [c2bcaaeab0787c6658eeda0f570bb6aa59d4d64e]

        tdf#114537 doc/rtf export: move DOCX impl so all formats use it
        
        The DOC import keeps duplicating the content part,
        so I haven't added a separate unit test to this patch,
        but manual testing shows this works for DOC and RTF.
        The unit test for DOCX already handles the correctness
        of the code, so no real need for another test anyway.
        
        Change-Id: Iceb41a647b8408150ae8558b10b581d3a6c49e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145755
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-18  Eike Rathke  <erack@redhat.com>  [fc441f3886330c4ae2abeb67c0758b935ba23f47]

        Resolves: tdf#153096 Split change track content action into columns again
        
        Old SvTreeList did split a string on embedded \t Tab characters,
        the new weld::TreeView does not but needs column text set
        explicitly.
        
        Regression from
        
            commit 56dd851cfc77c362c3db5c0aae4a490c7f6782cc
            CommitDate: Sat Apr 27 12:41:14 2019 +0200
        
                weld cluster of change tracking dialogs
        
        that did the necessary changes for
        ScAcceptChgDlg::AppendFilteredAction() but not for
        ScAcceptChgDlg::AppendChangeAction() and
        ScAcceptChgDlg::InsertChangeActionContent().
        
        Odd that no one reported this in all the time..
        
        Additionally, the "Changed contents" label being used instead of
        "Row inserted"/"Column inserted"/"Row deleted"/"Column deleted" as
        soon as cell content change is present depending on such action,
        was a copypasta fallout from
        
            commit e7c76b30bd2ef802ce08f8739eac186253c79696
            CommitDate: Mon Aug 29 17:21:12 2011 -0400
        
                String to rtl::OUString.
        
        Change-Id: I855c527da61723c104c743e3b3f159fb026917df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145749
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [25c16d260999487284b54cf2794b29b868d05f58]

        don't crash with --disable-pdfium
        
        Change-Id: Ibc88d9f32ae86f7137c24e2fe1d581ff1cd64497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [f93d4062c92e0508dc6a5272350ad98b9f0bfd72]

        tdf#152770 move warning about ppd with no resolution to use of resolution
        
        so bizarro ppds with no resolutions don't trigger a warning unless it
        gets queried about the resolution
        
        Change-Id: I4828ddf80d011265aefb271d964f6362842b3014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [aff603e10b412740d7a1bcbffb533e7675103f6f]

        thaw before set_active
        
        Change-Id: Ib588bb9df147b5db4e0cb526e5a20ef1a3636686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [90e666baa16e167c733d0a0846ca6281daf1b099]

        sw: remove questionable assert that fires on tdf119224-1.docx
        
        Change-Id: Ib928838523270a3e2d5a89eed60315919be2861d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145752
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [7b62d09090e5172e26141694fb97bc27562a81ce]

        tdf#153082 writerfilter,sw: import/export locale-dependent TOC ...
        
        ... \t style name separators.
        
        OOXML says in 17.16.5.68 TOC:
        
          \t field-argument
          Uses paragraphs formatted with styles other than the built-in
          heading styles. text in this switch's field-argument specifies those
          styles as a set of comma-separated doublets, with each doublet
          being a comma-separated set of style name and table of content
          level.
        
        The reality is documented in Word online help:
        https://support.microsoft.com/en-us/office/field-codes-toc-table-of-contents-field-1f538bc4-60e6-4854-9f64-67754d78d05c?ui=en-US&rs=en-US&ad=US
        
          Note: Syntax shown here uses a comma (,) between the Style and Level
          parameters. A semicolon (;) is also valid, depending on which
          character is specified as the list separator in your operating
          system's regional and language settings. Because of language-specific
          dependencies, we recommend not using the \t switch in templates or
          documents that are intended for users across multiple language
          configurations.
        
        It's easy enough to recognize both ',' and ';' as separators on import,
        and unlikely that anybody would use these characters inside a style
        name; for export, both can't be written and a decision must be made.
        
        So do the same thing on export as Word does, assuming most document
        exchange is between users in the same locale; currently only for "de"
        locales but more can be added.
        
        Interestingly WW8 used to write ';' before 2009 when CWS hb32bugs01
        changed it to ','.
        
        Change-Id: I2dcfdd009f448f6fae37cbd28929d0bbe504acf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145744
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [ecbad22fdf81c6f072b6c9f9c16dbba47fe4748c]

        tdf#153082 writerfilter: import locale-dependent TOC \t style names
        
        The bugdoc contains this style:
        
          <w:style w:type="paragraph" w:styleId="IntensivesZitat">
            <w:name w:val="Intense Quote"/>
            <w:basedOn w:val="Standard"/>
            <w:next w:val="Standard"/>
            <w:link w:val="IntensivesZitatZchn"/>
            ...
        
        which is referred to by:
        
          TOC \o "1-3" \h \z \t "Intensives Zitat;3;Custom1;3;_MyStyle0;3"
        
        Word in an "en" locale is unable to match the "Intensives Zitat" in the
        TOC field with the style "Intense Quote", which is a built-in style
        in Word (no equivalent in Writer).
        
        At first glance nothing in styles.xml matches the localised built-in
        style name in the TOC field.
        
        But it looks like the w:styleId value is somehow generated from the
        localised style name by omitting certain characters like SPACE and
        non-ASCII letters.
        
        Change-Id: I2050f7cf7f8d80bee1f667ee53b7f9981bbf7b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145745
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9f9921af3a522ee76a46db156f6730ca3c7a20d0]

        missing colons in Character - Position dialog
        
        Change-Id: I78634677fff9b1a2f4955e7a1483662fc6b231c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145717
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9a7af8b1d26447b69fe060ec5261da0c581db9c9]

        missing colons in Edit Fields interface
        
        Change-Id: I7c364fb042661fb133fad460778c27896a714e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145716
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [827f4af430cbeb74ee03537e7a9c4dfcfff51c0f]

        remove XUnoTunnel in SwChartDataSequence
        
        we can just use the concrete type, instead of casting
        
        Change-Id: I947b45eb454328390e077654bbf677f6a0fe8a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [dc79c5086b7f7fb24df8d24397c65a4d6af97793]

        sw: DOCX export: remove extraneous comma in lcl_guessQFormat()
        
        Added like this in commit be515af4d9e86c8bc13a47413676bda80cee6a3e.
        
        Change-Id: I4a9190b18c80930c2c7ba31c9e657280527c3ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145743
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [888ab228d8839ea5c52907da726e560687e257b0]

        tdf#151886: sc_uicalc: Add unittest
        
        Jenkins fails on mac and windows with
        
        sc/qa/unit/uicalc/uicalc.cxx:297: Assertion
        Test name: testTdf151886::TestBody
        equality assertion failed
        - Expected: 1,1
        - Actual  : Err:509
        
        Change-Id: Iaa51174ef246bc4ac9096b345e2a33370a5ab967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145403
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-18  László Németh  <nemeth@numbertext.org>  [4e72e646255624eda698da750383a5725e8f6c4c]

        tdf#152964 sw: fix crash of Undo of tracked deletion of empty table rows
        
        In Hide Changes mode, Undo of insertion of CH_TXT_TRACKED_DUMMY_CHAR
        (workaround of the deletion of empty table rows), resulted a crash
        because of inconsistency of table and redline nodes. As a workaround,
        skip that insertion from the Undo.
        
        Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes".
        
        Change-Id: I0666d7bcbbf08d84386cea64c1807f69f751479d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145737
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-18  Paris Oplopoios  <paris.oplopoios@collabora.com>  [0c2ed51a775871c91ac8f01c8982f23c34e8248d]

        tdf#119229 docx: Preserve w15:paraIdParent attribute in commentsExtended
        
        w15:paraIdParent attribute indicates that the comment is a reply to the
        value id
        
        Change-Id: I9e6eca6a656594c956629c1434b8e5c3aa573c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145314
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [53d927cd674d85092f40d1195693ddd8d78d318e]

        SDPR: Add support for InvertPrimitive2D
        
        We urgently should get rid of XOR paint, modern
        graphic systems allow no read access to the pixel
        targets, but that's naturally a precondition for
        XOR.
        While we can do that for the office's
        visualization, we can in principle *not* fully
        avoid getting stuff that needs/defines XOR paint,
        e.g. EMF/WMF imports, so we *have* to support
        it (for now - sigh)...
        
        This makes this renderer complete from the minimal
        to-be-supported primitives, too.
        
        Change-Id: Ie8fa98b777de764af0babe969296a671ca5cc7ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145739
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ce805e052a4d0278190603021103dfe53439b463]

        Simplify a bit
        
        Change-Id: I3e3d13f468192967056af5c5c21709352a7acf8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145741
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-18  Jean-Pierre Ledure  <jp@ledure.be>  [40bc1b275324f9a730960fe5d4d8982cdfbc7b03]

        ScriptForge - (SF_Calc) sort ranges on more than 3 keys
        
        The Calc.SortRange() method sorts
        the given range on any number of columns/rows.
        The sorting order may vary by column/row.
        
        The sorting algorithm allows for maximum 3 keys.
        
        When the number of sort keys is > 3 then the range
        is sorted several times, by groups of 3 keys,
        starting from the last key.
        
        In this context the algorithm used by Calc
        to sort ranges is presumed STABLE,
        i.e. it maintains the relative order of records
        with equal keys.
        
        Change-Id: If7f4920f7ab8f8ffb71edf648ed9accc8eb62dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145681
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-18  Justin Luth  <justin.luth@collabora.com>  [ec6d1156b70b0abeb60d2c481392e538328eabac]

        document svx.sdi with link to SDI slot config details
        
        UI stuff is a total black box,
        so most of the config is just copy/pasted from a similar function,
        with nothing to indicate what any of it means or does.
        
        Miklos pointed me to this documentation,
        so I've dumped it here so that there are a few breadcrumbs
        pointing to the specs for what this stuff means.
        
        Change-Id: Iccbc0ff5b400328af8ae683fdcf42203e4029d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145624
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Justin Luth  <jluth@mail.com>  [f610082534745e88fd1fbfd8059948c38fb88fb6]

        tdf#114537 doc import: trim switches before evaluating FIELD_IF
        
        Although this function is only used for ww8 import (and qa tests),
        it is documented as being more generic. So I decided to just trim
        at the source and not try to introduce any MS-isms into the parse function.
        Something similar will be needed for DOCX,
        but DOCX import for FIELD_IF is completely missing.
        
        Change-Id: I822b400e3e53abd953f4c382947f0e80ae62b234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145691
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [eb760387efbc804c8a8b0c1cc630d6dba2699284]

        Use std::clamp
        
        Change-Id: I754ec67601b45542553e1070c0eb5489ed23a722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145714
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [81d333990474615ba1474e4e4229588b3869424f]

        Use dynamic_cast result instead of following static_cast
        
        And make the dynamic_cast more specific, matching the now-removed
        unconditional static_cast.
        
        Change-Id: I322312eb8675b28af79b7cca552d6347f74c5faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145593
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-18  Michael Weghorn  <m.weghorn@posteo.de>  [f5e4a54f8c2d5b6ba570219322b08be6815ff31a]

        android: Hide UI to creat new files for SDK version < 19
        
        Just like for the the case where editing is disabled
        (s. Change-Id I2f8c86f5db96a5135ff8a66a7a7078b664d05a5e,
        "android: Only offer creating docs when editing enabled"),
        just hide the UI to create new files when running on devices
        that don't support `Intent.ACTION_CREATE_DOCUMENT`, rather
        than showing the button, but then showing a message that
        creating files is not supported once the button is clicked.
        
        Change-Id: Ifedf40e22dc8906557d5364ecf9ec3a9db2315e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145736
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-18  Michael Weghorn  <m.weghorn@posteo.de>  [5e4bcb501f2cefaa495e59de7decbdf5a1f69d51]

        android: Only offer creating docs when editing enabled
        
        Hide the UI to create new documents unless the
        experimental editing mode is enabled. There is
        little use in creating new empty documents when there
        is no way to edit them...
        
        Change-Id: I2f8c86f5db96a5135ff8a66a7a7078b664d05a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145735
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-18  Michael Weghorn  <m.weghorn@posteo.de>  [20989728c78008f29c7f7bf72b3d0e5189835dc4]

        android: Update Android Gradle Plugin to 7.4.0
        
        ... and gradle to 7.5.
        
        Change-Id: If5156ab18dc500dafdfa4f8a0f6e6c2563acc4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145711
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [1f1d75feef48633e488df56880f422d83cba8cd9]

        cid#1519050 silence Unchecked dynamic_cast
        
        Change-Id: I024094717141eb3c545ee0491a0d34f03a74c8c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145707
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [ae76a67623a3d4063de4d2be7dc94ec5b977b7b2]

        Related: tdf#152770 we don't use the font list, so don't warn if its empty
        
        this is a left over from unused code removal
        
        Change-Id: I6f6451561ae644a41d402f4de0d805a00945a66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145712
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [90ffbbdcd3ad050b07d2acdbef4d325f73901e0f]

        cid#1519129 Improper use of negative value
        
        Change-Id: Ib74c0734801e9f4b5cbeb9b1b19c12d5ad5eadbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145708
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cad5c39e3d1652e2aaa95dbe032e58369bdaed3]

        XUnoTunnel->dynamic_cast in FmXFilterCell
        
        Change-Id: I7e875a9445fd24370d491315cb6a8aa42951f642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [02fc71edd607a5eec722841c0e2b0f1ce820c85e]

        XUnoTunnel->dynamic_cast in ValueSetAcc
        
        Change-Id: I0ae633a29eda0658dfb92e92f498dc5fe1673219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [5afc1bcbda535aca71a54cf5067f19e9df5aea49]

        XUnoTunnel->dynamic_cast in ValueItemAcc
        
        Change-Id: I51450d2bc611b888b5b2f77293eed7ea3f5cbce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [031f7527f477e0e5561b2de26725d6e45f344c93]

        Fix typo
        
        Change-Id: Ifc9748fc33c72ad6e0cb334ca22ebb8b488164c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145710
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [e6b2761cb7299d2e93ce5cfc5b53309c6588f2ee]

        give message dialog a suitable parent
        
        Change-Id: I2eb21cbc9e89189ab0fa4090c04fec98f654a542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [7ed2ddbb5c19451e65595becf9b25e6d583fc48b]

        set a parent for this warning dialog
        
        Change-Id: Ia15a3cf7cc5136d2db7463f7486bcc14f4f6a6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145686
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Caolán McNamara  <caolanm@redhat.com>  [7e342018492689e6de0de145a5d28346e210dfe2]

        only need ooo_fixed for gtk3
        
        Change-Id: I2ddc54d013dbeeb75fd07bd5c4ec413306472167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145680
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-18  Stephan Bergmann  <sbergman@redhat.com>  [2eeda7e20b14357e22e5948186d613a15bbf6e81]

        Fix use-after-free
        
        ...introduced with 18f1e7ae9d57e888e316e9134ea321be98bf705a "sc: Use
        FormulaGrammarSwitch" (which gets partially reverted here),
        
        > ==7079==ERROR: AddressSanitizer: heap-use-after-free on address 0x61d0002d6cac at pc 0x7f3635905f9e bp 0x7ffdd2107b60 sp 0x7ffdd2107b58
        > WRITE of size 4 at 0x61d0002d6cac thread T0
        >     #0 0x7f3635905f9d in ScDocument::SetGrammar(formula::FormulaGrammar::Grammar) /sc/source/core/data/documen3.cxx:507:14
        >     #1 0x7f362ce3da0c in FormulaGrammarSwitch::~FormulaGrammarSwitch() /sc/qa/unit/helper/qahelper.cxx:56:12
        >     #2 0x7f36529ad332 in ScExportTest2::testRefStringUnspecified() /sc/qa/unit/subsequent_export_test2.cxx:436:1
        >
        > 0x61d0002d6cac is located 2092 bytes inside of 2280-byte region [0x61d0002d6480,0x61d0002d6d68)
        > freed by thread T0 here:
        >     #0 0x4fe180 in operator delete(void*) /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_new_delete.cpp:160
        >     #1 0x7f36398e1b9e in __gnu_cxx::new_allocator<std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2> >::deallocate(std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/ext/new_allocator.h:125:2
        >     #2 0x7f36398e1b4e in std::allocator_traits<std::allocator<std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2> > >::deallocate(std::allocator<std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2> >&, std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/alloc_traits.h:462:13
        >     #3 0x7f36398e0691 in std::__allocated_ptr<std::allocator<std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2> > >::~__allocated_ptr() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/allocated_ptr.h:73:4
        >     #4 0x7f36398e12b3 in std::_Sp_counted_ptr_inplace<ScDocument, std::allocator<ScDocument>, (__gnu_cxx::_Lock_policy)2>::_M_destroy() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:545:7
        >     #5 0x7f3635077f59 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:170:10
        >     #6 0x7f3635077bf9 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684:11
        >     #7 0x7f36388ea06c in std::__shared_ptr<ScDocument, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123:31
        >     #8 0x7f36388e02b8 in std::shared_ptr<ScDocument>::~shared_ptr() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr.h:93:11
        >     #9 0x7f36398a45c7 in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2941:1
        >     #10 0x7f36398a475f in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2910:1
        >     #11 0x7f36398a4908 in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2910:1
        >     #12 0x7f3627bd3f11 in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29
        >     #13 0x7f3627bd350c in tools::SvRef<SfxObjectShell>::~SvRef() /include/tools/ref.hxx:56:36
        >     #14 0x7f3629662ce1 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() /sfx2/source/doc/sfxbasemodel.cxx:249:5
        >     #15 0x7f362966598a in void __gnu_cxx::new_allocator<IMPL_SfxBaseModel_DataContainer>::destroy<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/ext/new_allocator.h:140:28
        >     #16 0x7f3629665746 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/alloc_traits.h:487:8
        >     #17 0x7f3629660583 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:535:2
        >     #18 0x7f3627b7b1fc in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:154:6
        >     #19 0x7f3627b7b029 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:684:11
        >     #20 0x7f362966a9cc in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1123:31
        >     #21 0x7f362962f893 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/shared_ptr_base.h:1235:9
        >     #22 0x7f3629572b96 in SfxBaseModel::dispose() /sfx2/source/doc/sfxbasemodel.cxx:765:13
        >     #23 0x7f3629591550 in SfxBaseModel::close(unsigned char) /sfx2/source/doc/sfxbasemodel.cxx:1496:5
        >     #24 0x7f36295702fd in SfxBaseModel::dispose() /sfx2/source/doc/sfxbasemodel.cxx:722:13
        >     #25 0x7f36247062aa in UnoApiTest::load(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:87:22
        >     #26 0x7f362470bb09 in UnoApiTest::saveAndReload(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:207:5
        >     #27 0x7f36529ad04f in ScExportTest2::testRefStringUnspecified() /sc/qa/unit/subsequent_export_test2.cxx:428:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2653/>)
        
        Change-Id: I34adf135a4ec79935295a21b34277324c531291b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145706
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-18  Miklos Vajna  <vmiklos@collabora.com>  [1f8c02353d653a6d4a72d918aaf6be5f367137c9]

        sc: fix crash in ScViewData::GetCurXForTab()
        
        Crashreport signature:
        
        program/libsclo.so
                ScViewData::GetCurXForTab(short) const
                        sc/source/ui/view/viewdata.cxx:1431
        program/libsclo.so
                ScViewFunc::OnLOKInsertDeleteColumn(short, long)
                        sc/source/ui/view/viewfunc.cxx:1552
        program/libsclo.so
                ScDocFunc::InsertCells(ScRange const&, ScMarkData const*, InsCellCmd, bool, bool, bool)
                        source/ui/docshell/docfunc.cxx:2256
        program/libsclo.so
                ScViewFunc::InsertCells(InsCellCmd, bool, bool)
                        sc/source/ui/view/viewfunc.cxx:1658
        
        Seeing that e.g. ScViewData::WriteUserDataSequence() already checks if
        the pointer in maTabData is a nullptr, do the same here.
        
        Change-Id: I0ebdba8c8a5bedd3c3c57c36bdf0632e2fee45c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145697
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Miklos Vajna  <vmiklos@collabora.com>  [e9d5ccd5a0822969412dbddf0191e28703e72e82]

        sw, .uno:InsertField: add a new Wrapper parameter
        
        This is similar to ceea8f3924f26d5f10adc41b9ea587c77c2fda74 (sw:
        .uno:TextFormField: add new Wrapper parameter, 2023-01-16), but that was
        for fieldmarks & footnotes, while this is for refmarks & footnotes.
        
        Also start a new test file as the one for the entire directory starts to
        grow too long.
        
        Change-Id: Ib7c0e03d6686a8a52a5691a4e2dbf97dcc2facba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145698
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Aron Budea  <aron.budea@collabora.com>  [305e5fe1ba3df1dbe1f961509fe2c691b5193a6f]

        tdf#153080 RTL UI was misbehaving
        
        Regression from
        6f43f00279252265fe4892b46fe0b4686ff721ed
        
        Change-Id: I472381252641bdcd1416bad0893c416a041cc49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145704
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2023-01-18  Miklos Vajna  <vmiklos@collabora.com>  [91c0e64c2f4d67c6a1073a73b1e467a3b28f0e85]

        sw: rename getBookmarkFor() further to getOneInnermostBookmarkFor()
        
        One additional complexity I missed is that there can be only one
        innermost fieldmark for a position, but there can be multiple bookmarks,
        because bookmarks don't have a starting dummy character.
        
        See
        <https://gerrit.libreoffice.org/c/core/+/145412/2#message-85a4780c8140038a9cc2bd4b9af64ecf97ee5e60>.
        
        Change-Id: Ia5d3bebddd42be7c44b8df2d5db3c5312285a5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145699
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [90d658d6d1054ac352e1b074a37b8963514a05f8]

        XUnoTunnel->dynamic_cast in ExplicitValueProvider
        
        Change-Id: I72b85a18d0a754f81a136fd79e56789aa926f425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Heiko Tietze  <tietze.heiko@gmail.com>  [d395b42cdf3ef517d215dee905e5ccf2ae73b2b8]

        Resolves tdf#91415 - Scale Calc's comment indicator with zoom level
        
        Avoids covering of content when zoomed out
        Shows the indicatior as a triangle now
        
        Change-Id: Icb613e0e728852dd2dfb6d52ad657a986d0c1a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145677
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-18  Stephan Bergmann  <sbergman@redhat.com>  [b63afb3c74d4285a7d46917354eafc0087a73f8f]

        Fix typo
        
        ...which happened to go largely unnoticed (the would-be additional overload, as
        seen when including drawinglayer/processor2d/SDPRProcessor2dTools.hxx first
        thing in drawinglayer/source/processor2d/SDPRProcessor2dTools.cxx, was just
        never defined nor used), but caused
        
        > drawinglayer/source/processor2d/SDPRProcessor2dTools.cxx(140,6): error: externally available entity 'prepareBitmapForDirectRender' is not previously declared in an included file (if it is only used in this translation unit, make it static; otherwise, provide a declaration of it in an included file) [loplugin:external]
        > bool prepareBitmapForDirectRender(
        > ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        with clang-cl
        
        Change-Id: I9f338dd998b66fe3223af045206a423b016b93f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-18  Miklos Vajna  <vmiklos@collabora.com>  [02f286271d4b44d995f8f2f8f30fbc10ed764b49]

        CppunitTest_sw_rtfexport2: make testFdo48023() more self-contained
        
        Avoid magic in preTest() based on the bugdoc name.
        
        Change-Id: I40e3d58230e8e815bcea067cfc0ecca4ebeca98e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145683
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-18  Noel Grandin  <noelgrandin@gmail.com>  [7195e2740eb1c71f5bbc4322b3535d56b39e2817]

        cleanup commit for Submission
        
        The following commit missed some stuff:
            commit fc41f4d58c7c0e60025c1b43127ef1b3c87fa1ac
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Jan 14 12:41:58 2023 +0200
            XUnoTunnel->dynamic_cast in Submission
        
        Change-Id: Ic27a813e360ae39227cd68213d2899ab64f0dee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-18  Justin Luth  <jluth@mail.com>  [29f23c0e71437303982a094040373b509afc7010]

        tdf#114537 docx export: export conditional text with " as '
        
        I couldn't find any way  in MS Word to escape a double-quote
        that is inside of a conditonal text result.
        So just "emulate" that with a single-quote,
        which is a common substitute at least in the English world.
        
        Hmm, Google says that { QUOTE 34 } would do the trick,
        but it didn't work for me in Word 2010.
        
        Change-Id: Ib9833e482911809c86b4e300533ea0aedbeed71c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145685
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-17  Patrick Luby  <plubius@neooffice.org>  [ef558d0aab44421ad5cd8362724ff1410af1b480]

        Related: tdf#42437 Skip special press-and-hold handling for action keys
        
        Pressing and holding action keys such as arrow keys must not be handled
        like pressing and holding a character key as it will insert unexpected
        text.
        
        Change-Id: I6beaff265e6cae30337b025791692ff67b760ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145689
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-17  Justin Luth  <jluth@mail.com>  [98550980e414ca6d611e6c3779eed2e5e66f5641]

        tdf#114537 docx export: export conditional text in quotes
        
        DOCX is very much dependent on the true and false text
        being in quotes. Likely any inside quotes need to be escaped,
        but I haven't looked at that yet.
        
        Change-Id: I9f1976a92ea21d9d444ab2e405a0678daa8f939c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145684
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [db28a0cc2e11e1319509e13172fadf4b54d50ecf]

        tdf#153006 ordering of date/time formats in report builder
        
        regression from
            commit 17d2247a66b6a9e3105b0a8b8e6d6b5bea5e3ed4
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Aug 13 19:03:23 2021 +0200
            formatter maps can use unordered_map
        
        Change-Id: Ibc4bc71776a48c61fb9b651672404f9507c1f082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [b5480ea6c55ff550390ac8d146a2996f7234712e]

        gtk4: some basis for experimenting on a11y support
        
        4.10 makes GtkAccessible public
        
        Change-Id: Ib6ec27f9db9c9b87ff775fdc5a075b5b26a16b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145679
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [a21258c86e7fd1c64b11216a809f430627a06476]

        Resolves: tdf#153059 after ChangeHeaderOrFooter the control can be disposed
        
        If the cursor is still on page one then when a header, via a control on
        another page, is added it jumps back to that page, so the widget on the
        now hidden page is removed, but the click handler hasn't completed so
        the follow up action to change it from a "plus" button to a dropdown
        menubutton was on a disposed widget.
        
        Change-Id: I981126412a0ee6a667d77fb97a3db2f2b0a0363c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [a04bf69bccfbc266643b418ef57030a42bbb5c05]

        XUnoTunnel->dynamic_cast in ZipPackageEntry
        
        Change-Id: I0c49ebcb0ed16ab5b90c0cfa1417f002b5dad7b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c4341c95a2be2e0210d5f8f15d4dd80d9077c4af]

        Fix typo
        
        Change-Id: I4f2cf13ce7b9dd7cd4d579bee1ad411459687c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145668
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [74600e794903daf0e9be5ba20df1680c715f63c9]

        XUnoTunnel->dynamic_cast in ThumbnailViewItemAcc
        
        Change-Id: Iba0a4a002b261e7b75e20e25d676a6a846b73647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145669
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Fred Kruse  <fred.kruse@gmx.de>  [924005b06732d6d7aea2437a9edf2550878f9324]

        ParagraphProperties.idl: SortedTextId: Changed 7.5 -> 7.6
        
        Change-Id: Iebfae0952f0c2d7219cb00bf1af73e1a75f4f256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145674
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [bbf1d7faca7912016855b51a10c93a064675e213]

        tdf#152637 format cells example text black on dark background
        
        with application colors, scheme: LibreOffice Dark enabled
        
        Change-Id: I56ac48ec2e6afd77f20a8581c6d872942618d802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Jean-Pierre Ledure  <jp@ledure.be>  [c7ac513a8217179c5fae774363e8b0b1f41cea5c]

        ScriptForge - (SF_Calc) fix CompactUp/CompactLeft methods
        
        When
          - WholeRow/WholeColumn = False
          - no row or column matches the FilterFormula
        the cells below or at the right were erroneously
        shifted down or right.
        
        Future behaviour:
        - when nothing to compact,
           the initial range is left unchanged
           the return value = the initial range
        - when all rows/columns are impacted,
           the initial range is cleared
           the return value = zero-length string
        - otherwise
           the initial range is compacted
           the return value is the compacted range
        In either case, the surrounding cells are unchanged.
        
        Change-Id: I27288878dcadeb4ded297b7bb1e6897947ed5e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145622
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2023-01-17  Stephan Bergmann  <sbergman@redhat.com>  [ea70cf3ca06a5b101d51ca1f4d4a106747a884ae]

        loplugin:casttovoid ("unnecessary cast to void")
        
        Change-Id: Ic891e3ea72e7946a9088ab77ba561d0f1c9b77e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145673
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fdfee3268aeae5c9a06527c0f973d258c2188c6]

        XUnoTunnel->dynamic_cast in SfxOfficeDispatch
        
        Change-Id: Ie1aa51a873d1e80a15cddf6220f23a6cf4d090c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [23e6c378b6d3045d295ad665ae32de65f7f8a47f]

        XUnoTunnel->dynamic_cast in ThumbnailViewAcc
        
        Change-Id: I0d7e98c45ff4b15c646ba90f7bd1f363300dcdb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e0d5afa233484e36e323e8466829ec573d11cbd]

        XUnoTUnnel->dynamic_cast in sd::ViewTabBar
        
        Change-Id: I0aae59685986f07e74a15ef7e7261de808b20c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145639
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc41f4d58c7c0e60025c1b43127ef1b3c87fa1ac]

        XUnoTunnel->dynamic_cast in Submission
        
        Change-Id: I2bafbecdd1b3f16375880e49708fe932db060812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145626
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [873a695b64269a6b92766f65930786314351e83f]

        tdf#153049 UpdateScrollBars on mouse release
        
        which is what the old code effectively did
        
        Change-Id: I19b6de0a0015420d1802969064b3338ce6ae1638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145663
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [6c8b6fa6c6d4a1a20d8ebaf36b16c1d20cf109e0]

        SDPR: use correct Viewport for sub renderer
        
        Change-Id: Ia10731fbe44c812120ed6594959ddee909568187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145666
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8446cac7d39d3f09f9dd0d5b513ceb96184b0da8]

        XUnoTunnel->dynamic_cast in ScDataPilotDescriptorBase
        
        Change-Id: I493d3fbd5eabb70804bd44affefdd705118f8185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Miklos Vajna  <vmiklos@collabora.com>  [43d80906c8693ca27c5b3077fbaa259df4004924]

        sw: .uno:TextFormField: handle Endnote as a value for the Wrapper parameter
        
        This is similar to the fieldmark-in-footnote case, but here we need to
        make sure that the layout is calculated before the cursor attempts to
        jump to the endnote, otherwise the fieldmark will be inserted before the
        endnote anchor, not in the endnote body.
        
        The move of StartAction() / EndAction() calls can be done
        unconditionally, it's not a problem for the existing footnote case.
        
        Change-Id: I772d27937456978ca6aa01148eff3163d8877208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145660
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [18f1e7ae9d57e888e316e9134ea321be98bf705a]

        sc: Use FormulaGrammarSwitch
        
        Change-Id: Ia4d21886a5a8536f20fed87bfea9676ac8603d86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145481
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [5355f52b14d7237ba0f9fdd910eca579292242bd]

        XUnoTunnel->dynamic_cast in sd::DrawController
        
        Just past the concrete type down through a couple of layers, rather than
        using a generic type and then casting
        
        Change-Id: I7ba6c83463f3db7176b72cb7e764d3659706ae78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145638
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1d50d738fd9fcae5e621efcd687121ef5219f1f]

        XUnoTunnel->dynamic_cast in ODatabaseContext
        
        Change-Id: I5e20afd203c07d371599634b2b3239b38a4ecce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145625
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [87d0f136dede84f694240f55a958d94e3d0fe9ce]

        XUnoTunnel->dynamic_cast in ScNamedRangeObj
        
        Change-Id: Ib298d8ba676f5a6ddf3fe9b7a49dc45c46d7adbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145636
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [377a8c8ed7dd997d1ac96918b69f805880d208af]

        tdf#153058 android: Use "fit page" for min zoom level
        
        So far, Android Viewer was using "fit page width"
        as minimum zoom level, meaning that it was impossible
        to zoom out to see the full page, e.g. when opening
        a doc with page size A4 portrait and using
        the device in landscape mode.
        
        Change the minimum zoom level to take the page
        height into account as well, i.e. adapt the minimum
        zoom level to be "fit whole page" to allow doing that.
        
        However, keep applying "fit page width" as
        zoom level when double-tapping, by using
        the "fit page width" zoom level as new
        default zoom level and applying the default
        instead of the minimum zoom level on
        double-tap.
        ("Fit page width" is probably more desirable
        than "fit whole page" at least when used on small
        devices, at least in all cases where
        writing is in horizontal direction, so the user
        can see the current portion of text and scroll
        down to continue reading/writing.)
        
        Use on double-tap is currently the only use for the
        default zoom level, the only previous occurence
        was effectively unused since
        
                commit 9ab43aebad67383057d2cc3f754ce2193fa78b4e
                Date:   Wed Dec 4 17:18:20 2019 +0100
        
                    android: Allow zooming for Calc as well
        
        and finally dropped with
        Change-Id I702874f1d9161e5cef660bb4c4a0b7864d6e3c09
        ("android: Drop superfluous ZoomConstraints#mAllow{,DoubleTap}Zoom").
        
        Change-Id: Ica5d8207bc19a81173143fcb5c3747dc89f9fa81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145658
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [7c399767053b1cc6f68beccfbbb084c2891fe05e]

        android: Drop superfluous ZoomConstraints#mAllow{,DoubleTap}Zoom
        
        Both members are always set to true since
        
            commit 9ab43aebad67383057d2cc3f754ce2193fa78b4e
            Date:   Wed Dec 4 17:18:20 2019 +0100
        
                android: Allow zooming for Calc as well
        
        , so drop the two now superfluous members and
        getters.
        
        Change-Id: I702874f1d9161e5cef660bb4c4a0b7864d6e3c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145657
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-17  Tünde Tóth  <toth.tunde@nisz.hu>  [a1f16b4603bffddb2f6380874d63f928289de85a]

        tdf#152989 sc: fix oversized rectangle of edited embedded object
        
        Editing resulted unusably oversized OLE objects. Keep
        its original size to fix the UX problem.
        
        Note: lost zoom is still a problem.
        
        See also commit fdf95de18ef1891862bdce26669d1ce2c6f24764
        "tdf#152991 sd: fix oversized rectangle of edited embedded object"
        
        Change-Id: I6b73d1aea76ea4addc24ff978403893c3cbd3dac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145432
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-17  Fred Kruse  <fred.kruse@gmx.de>  [04f15c8a8c733f159f77bd58905e4136a32b1be9]

        Properties SortedTextId and DocumentElementsCount added for grammar check
        
        The LanguageTool extension (LT extension) runs not only a grammar check on the level of sentences and paragraphs, some rules work on the level of many paragraphs or full text. The LT extension uses a complex caching mechanism to support this feature. A mapping from a check request to the cached to the (flat)paragraphs is necessary. Until now, this is done by a time-consuming and error-prone mechanism.  The adding of the SortedTextId introduce a feature, a paragraph to be checked can be fast and easy identified. The flatparagraphs also can easily be mapped to cursors to get additional information of the paragraph, used for further features of LT extension.
        The added Property DocumentElementsCount to flatparagraphs and doProofreading gives the extension the hint to recreate the cache.
        
        Change-Id: I4b6b58bba4dfb3e870fe7b71fd8537ee9ffd6476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142251
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [79541a4808561fbe400cb4e0d33c8ddc23cf9d84]

        tdf#153049 use ScrollType::DontKnow for a mouse wheel spin
        
        use has_grab() to try and distinguish these
        
        Change-Id: I09e0f2219458e9ca0e6f0c0093aea5d5920acef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Michael Stahl  <michael.stahl@allotropia.de>  [ee73d14e06180d8a60fc4fc34ab71f23095e7621]

        tdf#152872 sw: fix crash on ooo27109-1.sxw
        
        Has a redline that ends on the body end node.
        
        (regression from commit 2bcfb7231b5ca74f02274cfb74ca8463f78905d6)
        
        Change-Id: I9dc89a496791935b9d28e1874f947b70fdf0b85a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145569
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [ebac691388ed71aafd0aaa78efc5810a68486b7f]

        Reset BitmapWriteAccess before further bitmap use
        
        It started failing an assertion recently (maybe after the 1-bit images
        support drop in commit 21734247d58a6e915b058d8fa55ece949d049613), when
        opening Styles sidebar, with this call stack:
        
          ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444	C++
          vcllo.dll!SkiaSalBitmap::AcquireBuffer(BitmapAccessMode nMode) Line 230	C++
          vcllo.dll!BitmapInfoAccess::BitmapInfoAccess(Bitmap & rBitmap, BitmapAccessMode nMode) Line 47	C++
          vcllo.dll!Bitmap::AcquireInfoAccess() Line 368	C++
          vcllo.dll!vcl::ScopedBitmapAccess<BitmapInfoAccess,Bitmap,&Bitmap::AcquireInfoAccess>::ScopedBitmapAccess<BitmapInfoAccess,Bitmap,&Bitmap::AcquireInfoAccess>(Bitmap & rBitmap) Line 55	C++
          vcllo.dll!Bitmap::HasGreyPalette8Bit() Line 291	C++
          vcllo.dll!Bitmap::Convert(BmpConversion eConversion) Line 868	C++
          vcllo.dll!AlphaMask::AlphaMask(const Bitmap & rBitmap) Line 35	C++
          vcllo.dll!BitmapEx::BitmapEx(const Bitmap & rBmp, const AlphaMask & rAlphaMask) Line 142	C++
          vcllo.dll!vcl::bitmap::CreateFromData(const unsigned char * pData, long nWidth, long nHeight, long nStride, char nBitCount, bool bReversColors, bool bReverseAlpha) Line 216	C++
          ...
        
        The comment at the assert in SkiaSalBitmap::AcquireBuffer (that is called
        from BitmapInfoAccess ctor) tells:
        
          BitmapWriteAccess stores also a copy of the palette and it can
          be modified, so concurrent reading of it might result in inconsistencies
        
        Change-Id: I364060cf3c2073cfd8bf3288140a7ab3604cd2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145659
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-17  Tünde Tóth  <toth.tunde@nisz.hu>  [fdf95de18ef1891862bdce26669d1ce2c6f24764]

        tdf#152991 sd: fix oversized rectangle of edited embedded object
        
        The embedded object became unusably oversized after editing,
        because it was not possible to minimize it by the mouse. Now
        the object keeps its original size to avoid of the UX problem.
        
        Note: losing the original zoom of the OLE content is still a problem.
        
        Change-Id: I8b7a2f2a84324bf4de2358ecb5fec5c1f7349155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145454
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2023-01-17  Radhey Parekh  <radhey.parekh@gmail.com>  [f7d4efc02118a92a3f3cb17ea131674e88907a7b]

        tdf#146638 In a titlebar, separator is changed from a hyphen to an emdash
        
        Change-Id: Ibf79dfd4c3e2f44ba4564567cd5e3f3650095719
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145542
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ed9bb8bdcb1bee63d89909eed82110da31edfe5]

        XUnoTunnel->dynamic_cast in RootItemContainer
        
        Change-Id: I79a44f69dd7233a7e885698d29b929d9831025c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  DowdyJ  <joeldowdy12@gmail.com>  [b8cda1fe1c87af9f378b49bbd3beee25f3c4a942]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ibaa1f275cd4ef5a56b8014bf99013aa511a2c413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145648
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-01-17  Caolán McNamara  <caolanm@redhat.com>  [0b471dc61b60180508d071a26e45b217ea65d13f]

        docmodel appears twice in Library_oox.mk
        
        Change-Id: I771c64309b2fd00965e032a4c9025d657806d298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-17  Miklos Vajna  <vmiklos@collabora.com>  [ceea8f3924f26d5f10adc41b9ea587c77c2fda74]

        sw: .uno:TextFormField: add new Wrapper parameter
        
        Currently all fieldmarks are inserted into the document body
        unconditionally when this UNO command is dispatched.
        
        Inserting at the current cursor position makes sense, but some citation
        styles want to insert the actual citation as footnotes, and only have
        the footnote anchor at the cursor position.
        
        Fix the problem by adding a new Wrapper parameter to this UNO command:
        currently the only interesting value it may have is Footnote, if this is
        specified then first we insert a footnote and the footnote content will
        host the fieldmark, not the original body text.
        
        The same will be wanted for endnotes as well, but that's not yet done in
        this commit.
        
        Change-Id: I5c96c7dc9ddaace09b1dbc21b8f12005a2934d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145602
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [55eabf68ff48762d620b69daefd4116c2023cb0c]

        assert/SAL_WARN in BlendWith
        
        instead of just silently doing nothing, so we get some indication of
        error
        
        Change-Id: Iac7e21d42b45ebc97cfb95552d98c186b9eb05ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Tor Lillqvist  <tml@collabora.com>  [d648f2ae3a16d0613d1b75848789b9742eb20b19]

        Adapt for --enable-wasm-exceptions
        
        Actually, it seems that to build core with --fwasm-exceptions for use
        in a LibreOffice Technology -using WASM executable, you need to
        compile *everything* with that (i.e. *all* of core's externals). Just
        these gbuild things are not enough to ensure that. You have to put
        
          CC=emcc -pthread -fwasm-exceptions -s SUPPORT_LONGJMP=wasm
          CXX=em++ -pthread -fwasm-exceptions -s SUPPORT_LONGJMP=wasm
        
        into your autogen.input.
        
        Change-Id: I10d21ad0f73e7e5d72864864d595077bd770f4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145646
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2023-01-17  Tor Lillqvist  <tml@collabora.com>  [5c355dbae859d2ac0b0e8fedca86b64797aec081]

        Don't bother building the liborcus benchmark
        
        It causes a problem when building with Emscripten and
        --enable-wasm-exceptions. Instead of fixing that problem, just don't
        bother building executables we won't run anyway. (Ideally liborcus
        should have some --disable-benchmark configure options, ping Kohei.)
        
        Change-Id: Ic8c1d51513793bba85dc2833cc8fd9ec5b97ce76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145645
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb004bdefb495f151d8a69953774582cf470f6e6]

        XUnoTunnel->dynamic_cast in ZipPackage
        
        Change-Id: I4ecfbb0e90cca7e81556fb27fd552669bed0405c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145631
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [81fd038c81e5ebbb8a52d9b2fbdca1fd48f445e3]

        XUnoTunnel->dynamic_cast in ConstItemContainer
        
        Change-Id: I0b3bf3e2c30a150aa3986e05951e0978fc16f1bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145629
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Gülşah Köse  <gulsah.kose@collabora.com>  [959fbfc000d2e3167b2b57b6d11bea231993b4f0]

        tdf#91265 Use same plot area distance as used in MSO
        
        Changes the postion calculation for pie charts, where the margin
        min distance is now constant for pie charts, but unchanged for
        other chart types.
        
        This changes the positions of various pie charts used in tests,
        which have been changed to the new value after the cases have been
        checked.
        
        Added a new test with all 3 use cases (chart area width equals
        height, width is greater than height, width is less than height).
        
        Change-Id: I51f98f336a7c64a3e6762144fc7dc8d9df80f696
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143179
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-17  Miklos Vajna  <vmiklos@collabora.com>  [92931e1162134cb88a5f413b1a317fc9fdd3579c]

        sw: document SwSectionNode
        
        Note how all the table cells, sections, flys etc have low-level
        sections, but only the UI-level section's start node is called a
        section node.
        
        Change-Id: I730f17b3a63c9e49ee099f82aa39f7a55b2da3fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145634
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2dd86a1a062973ef3b1a3c312b98e9b9dcbaeeb1]

        XUnoTunnel->dynamic_cast in ViewShellWrapper
        
        Change-Id: I204bbfc67a6c60723d8ebb21424ac5c184f9b2cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe48df2684aa2877b26a112b738f3756db10fa6d]

        XUnoTunnel->dynamic_cast in sd::framework::Pane
        
        Change-Id: I3e6408af0b57bd3b714551c42a31b5b0aabaf3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145640
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd881e48f7860596096a45816c559ac100b0bf59]

        XUnoTunnel->dynamic_cast in ScHeaderFooterContentObj
        
        Change-Id: I3edc648a4a0afbfd2922befc9e1962df0a22b54f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145637
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e1ebb43abf2882f48d3cae92a3ce33ce2c437de]

        XUnoTunnel->dynamic_cast in RootActionTriggerContainer
        
        Change-Id: Ie07b02b2011e4edb23793f6209cc35ccd7607c41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145628
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [68a8d0e7507840e2b599e0f075dbd85ea5819ba9]

        XUnoTunnel->dynamic_cast in forms::Model
        
        Change-Id: I60525e6c4f2d2400cdc47538e9d704b10b7c87ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145627
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-17  Chenxiong Qi  <qcxhome@gmail.com>  [be7f3df701e4d94b64af6626d53e03d9336a09cf]

        tdf#97362 Convert unotools tempfile tests to Python
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I43d0881bbd2a99e018e027e166dcb7b0bffa5ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144395
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [bcce2205313b6c3a427d0ab12b65526a577fe996]

        tdf#153009 android: Include more doc layout related XML files
        
        instdir/share/config/soffice.cfg/simpress/objectlist.xml
        contains default positions for elements that are used
        in new Impress presentations, but that file wasn't
        included in the Android app/APK previously, so
        couldn't be read from in `SdDrawDocument::InitObjectVector`.
        As a result, the title and text were misplaced when creating a
        new presentation in Android Viewer.
        
        Include all of the related Impress XML files into the app to
        make this work as expected.
        
        (At least a failed attempt to read from `layoutlist.xml`
        was also observed while debugging the issue mentioned
        above.)
        
        Change-Id: Iba1ac68c0b983d3e465515f07b3fc67162a0ee3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145621
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [48916eb11bea29ac2f7963d779b18491d6015737]

        tdf#153009 Use recursive mutex in CDocumentBuilder
        
        This was changed from `osl::Mutex` to `std::mutex`
        in
        
            commit e66fdb597b30fc701bb068824d0ae4d89fecd55f
            Date:   Sat Jul 31 20:12:30 2021 +0200
        
                osl::Mutex->std::mutex in CDocumentBuilder
        
        , but `DOM::CDocumentBuilder::parseURI` locks the mutex and
        then calls `DOM::CDocumentBuilder::parse` for the
        
                // if we failed to parse the URI as a simple file, lets try via a ucb stream.
                // For Android file:///assets/ URLs which must go via the osl/ file API.
        
        case, which would result in a deadlock because
        `DOM::CDocumentBuilder::parse` wants to lock the mutex
        again.
        
        This happens once that code path is executed
        on Android Viewer when creating a new Impress presentation
        with Change-Id Iba1ac68c0b983d3e465515f07b3fc67162a0ee3f
        ("tdf#153009 android: Include more doc layout related XML files")
        in place.
        
        Fix the deadlock by using a "std::recursive_mutex` instead.
        
        Part of the backtrace:
        
            DOM::CDocumentBuilder::parse(const com::sun::star::uno::Reference<…> &) documentbuilder.cxx:331
            DOM::CDocumentBuilder::parseURI(const rtl::OUString &) documentbuilder.cxx:387
            non-virtual thunk to DOM::CDocumentBuilder::parseURI(rtl::OUString const&) documentbuilder.cxx:0
            SdDrawDocument::InitLayoutVector() drawdoc.cxx:1130
            SdDrawDocument::SdDrawDocument(DocumentType, SfxObjectShell *) drawdoc.cxx:147
            sd::DrawDocShell::Construct(bool) docshell.cxx:94
            sd::DrawDocShell::DrawDocShell(SfxModelFlags, bool, DocumentType) docshell.cxx:140
            sd_PresentationDocument_get_implementation::$_1::operator()(SfxModelFlags) const unodoc.cxx:65
            std::__ndk1::__invoke<…>(sd_PresentationDocument_get_implementation::$_1 &, SfxModelFlags &&) type_traits:4353
            std::__ndk1::__invoke_void_return_wrapper::__call<…>(sd_PresentationDocument_get_implementation::$_1 &, SfxModelFlags &&) __functional_base:318
            std::__ndk1::__function::__alloc_func::operator()(SfxModelFlags &&) functional:1527
            std::__ndk1::__function::__func::operator()(SfxModelFlags &&) functional:1651
            std::__ndk1::__function::__value_func::operator()(SfxModelFlags &&) const functional:1799
            std::__ndk1::function::operator()(SfxModelFlags) const functional:2347
            sfx2::createSfxModelInstance(const com::sun::star::uno::Sequence<…> &, std::__ndk1::function<…>) sfxmodelfactory.cxx:82
            sd_PresentationDocument_get_implementation(com::sun::star::uno::XComponentContext *, const com::sun::star::uno::Sequence<…> &) unodoc.cxx:61
            std::__ndk1::__invoke<…>(com::sun::star::uno::XInterface *(*&)(com::sun::star::uno::XComponentContext *, const com::sun::star::uno::Sequence<…> &), com::sun::star::uno::XComponentContext *&&, const com::sun::star::uno::Sequence<…> &) type_traits:4353
            std::__ndk1::__invoke_void_return_wrapper::__call<…>(com::sun::star::uno::XInterface *(*&)(com::sun::star::uno::XComponentContext *, const com::sun::star::uno::Sequence<…> &), com::sun::star::uno::XComponentContext *&&, const com::sun::star::uno::Sequence<…> &) __functional_base:318
            std::__ndk1::__function::__alloc_func::operator()(com::sun::star::uno::XComponentContext *&&, const com::sun::star::uno::Sequence<…> &) functional:1527
            std::__ndk1::__function::__func::operator()(com::sun::star::uno::XComponentContext *&&, const com::sun::star::uno::Sequence<…> &) functional:1651
            std::__ndk1::__function::__value_func::operator()(com::sun::star::uno::XComponentContext *&&, const com::sun::star::uno::Sequence<…> &) const functional:1799
            std::__ndk1::function::operator()(com::sun::star::uno::XComponentContext *, const com::sun::star::uno::Sequence<…> &) const functional:2347
            cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(const com::sun::star::uno::Reference<…> &) servicemanager.cxx:706
            cppuhelper::ServiceManager::Data::Implementation::createInstance(const com::sun::star::uno::Reference<…> &, bool) servicemanager.cxx:675
            cppuhelper::ServiceManager::createInstanceWithContext(const rtl::OUString &, const com::sun::star::uno::Reference<…> &) servicemanager.cxx:1006
            non-virtual thunk to cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) servicemanager.cxx:0
            SfxFrameLoader_Impl::load(const com::sun::star::uno::Sequence<…> &, const com::sun::star::uno::Reference<…> &) frmload.cxx:707
            non-virtual thunk to (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) frmload.cxx:0
            framework::LoadEnv::impl_loadContent() loadenv.cxx:1167
            framework::LoadEnv::start() loadenv.cxx:403
            framework::LoadEnv::startLoading(const rtl::OUString &, const com::sun::star::uno::Sequence<…> &, const com::sun::star::uno::Reference<…> &, const rtl::OUString &, long, LoadEnvFeatures) loadenv.cxx:308
            framework::LoadEnv::loadComponentFromURL(const com::sun::star::uno::Reference<…> &, const com::sun::star::uno::Reference<…> &, const rtl::OUString &, const rtl::OUString &, long, const com::sun::star::uno::Sequence<…> &) loadenv.cxx:168
            framework::Desktop::loadComponentFromURL(const rtl::OUString &, const rtl::OUString &, long, const com::sun::star::uno::Sequence<…> &) desktop.cxx:594
            non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, long, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) desktop.cxx:0
            lo_documentLoadWithOptions(_LibreOfficeKit *, const char *, const char *) init.cxx:2666
            lo_documentLoad(_LibreOfficeKit *, const char *) init.cxx:2532
            Java_org_libreoffice_kit_Office_documentLoadNative(JNIEnv *, jobject, jstring) lokandroid.cxx:134
            [...]
        
        Change-Id: I63bc7b6f682dab2e94f4e932429c513c5129428e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145620
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-17  Michael Weghorn  <m.weghorn@posteo.de>  [3cecdaeab10d4fcb0f478035fa3831c2e255b10c]

        tdf#153009 android: Set BRAND_SHARE_SUBDIR for more default structure
        
        Set `BRAND_SHARE_SUBDIR=share` in the `fundamentalrc`
        shipped with Android Viewer, as is the case for the
        desktop variant as well. This implies that
        the .ui files will be expected underneath the "config/share"
        directory in the app's assets from now on instead of just
        "config", since `BRAND_SHARE_SUBDIR` will be expanded accordingly
        in the paths.
        Therefore, put the .ui files there. Merge the block responsible
        for copying UI files into into the existing block already copying to
        that dir in the `copyTask` gradle task.
        
        There seems to be no particular reason for omitting
        the "share" subdirectory just for the .ui files in the Android
        assets.
        
        This is also in preparation of fixing tdf#153009:
        Not having `BRAND_SHARE_SUBDIR` set on Android resulted
        in
        
            "vnd.sun.star.expand:$BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR/config/soffice.cfg/simpress/objectlist.xml"
        
        previously getting expanded to
        
            file:///assets//config/soffice.cfg/simpress/objectlist.xml
        
        in `SdDrawDocument::InitObjectVector`, and that would cause
        failure to read object property settings (e.g. for the placeholder
        text in a new Impress presentation) from that file, even
        when `objectlist.xml` was put into the app's assets
        (s. Change-Id Iba1ac68c0b983d3e465515f07b3fc67162a0ee3f,
        "tdf#153009 android: Include more doc layout related XML files")
        at "config/soffice.cfg/simpress/objectlist.xml" due to the
        double-slash after "assets" not being treated the same way
        as a single slash at that place.
        
        Change-Id: Ia9d86e1f59daf8a41951cefb3a1e9f82f0e9f184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145619
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [f1830bff71847a9c17715cff52383956719847fe]

        ofz#55090 fuzzers need docmodel now
        
        Change-Id: I89ffdca9a6d497cd57788e125cbfc7bb1cfde672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145643
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [45a2d738c498feed80bc04e7bdf800cb0bf63fd3]

        XUnoTunnel->dynamic_cast in OContentHelper
        
        Change-Id: I3788af96cc8664d8afda2bd5eeaf85e9cd0cf374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [654f972a97c374fa90eb3984a44c7f54ddba9c61]

        sw lok: make sure author name change doesn't mark the doc as modified
        
        This was added in commit d4760b5d4b49fef1c832357059c7e184b3cc0bc4 (sw:
        lok: use redline author for saved author fields, 2023-01-09), but it
        makes online.git unit-wopi-save-on-exit fail.
        
        Try to get up to date author names + passing tests at the same time by
        still updating the fields but not marking the doc as modified right
        after load.
        
        Change-Id: Ic07fcc4464058e778f07d5a88b1d8479dbd8c144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145623
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [0045c49cf4389efe6cb369759fa2b9e6de938bd8]

        XUnoTunnel->dynamic_cast in ORowSetBase
        
        Change-Id: I685d15982f56b336862da57ecfcbd9ac2d14838b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [805a634ccc5c2e0bccdbb9c4820c70cd40db5510]

        XUnoTunnel->dynamic_cast in OQueryDescriptor
        
        Change-Id: Ide46f159674ce84f6ecd8b9b0045a66a3b4ddd98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [27d76f145a9668999cc31c02b6f2712903e427db]

        tdf#153039 submitting XML from XForms document
        
        regression from
            commit 5fd2f0b93bd7d38a277823bfc251c71da7a6f490
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Jan 12 09:19:03 2023 +0200
            use concrete class in Submission
        
        Change-Id: I99bc069b5243e994da71287960e29be6ab3338ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0857ba551bdb1a9db450682eba07f59849a7eddb]

        Fix typo
        
        Change-Id: I01c9a76fd9abca9611748e4e9f575eeb5a45f0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145570
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [d5c11b12dbfab8151cf0d7d233f13b062a62721b]

        CppunitTest_sw_layoutwriter2: fix testTdf152952_compat with en-only hyph dict
        
        The bugdoc had German text, but the test was only checking for an English
        hyphenation dictionary, so adapt the bugdoc.
        
        Also, now that the text is English, it's hyphenated a little bit
        differently, so adapt the asserts. The point is that it's still
        hyphenated.
        
        Change-Id: Iaaf45843ad37ca7e7ee87c60ec59f41cc10efb6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145565
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [531cfd9ebd27edce524c3c80688d66153644f6fa]

        readme.xrm: update for macOS
        
        Change-Id: I93793b689271dbc15b1670979061e0c34128289d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145563
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2023-01-16  Mike Kaganski  <mike.kaganski@collabora.com>  [15fe7346ade34f09f9be016ff847421ce0fa56f4]

        Simplify FastAttributeList
        
        Change-Id: Id89edb25e35527e8603c32e44fb2940721aeda58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145562
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [f41d42491528905594b9a36a3bf16998f309c702]

        sw: disable AutoUpdate for many new recent field/book/refmark UNO commands
        
        As noted in
        <https://gerrit.libreoffice.org/c/core/+/145470/1#message-afe4d72912e02c6bacc63392305c3f910a354c6a>,
        these only make sense for commands which have a GetState()
        implementation (AutoUpdate will call GetState() automatically for you
        after an exec), and none of these commands have an explicit GetState(),
        so AutoUpdate=TRUE doesn't make sense for them.
        
        Change-Id: I9899c297a7b0f8c447c66b50a228bc7e1896e146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145557
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [1520708cd976ffd39a60bb9d167b6d3c0dbb9c57]

        The third "depth argument is unused
        
        as far as I can determine. We do query the 2nd arg in "gen"
        when there is an opengl slide transition.
        
        Change-Id: I180c91fa193ee6e7e3d5a415e4278aded9fbbba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145544
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [0dbc1bd6b7806f9d7a5c12daf57a8099c54d25a5]

        XUnoTunnel->dynamic_cast in file::OResultSet
        
        Change-Id: Icfb3760b05e80925833f2ecaa294a81c85b6c672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [d466df5bc220eb80b8a51ff64507de881b938ed3]

        tdf#106731 Warn user that a module/dialog is read-only in Basic IDE
        
        As discussed in the ticket the Basic IDE does not make it clear that the currently opened module is read-only, which can cause confusion to the user, since they may be pressing keys and seeing no result.
        
        With this patch the IDE clarifies that the module/dialog is read-only in two ways:
        1) In the status bar the string "(Read-only)" is added after the module/dialog name
        2) When a module/dialog is opened an infobar is shown warning that it is read-only.
        3) In a module, if the user closed the infobar and tries to edit the code, the infobar is shown again.
        
        Change-Id: I15197c4316bb2ed19e54be0c33f4fb61b5bbd862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145307
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [465ec8b275f2685a31ee42ca1447a5d44d18a227]

        getFormat() is always DeviceFormat::DEFAULT
        
        Change-Id: I93139a6c2ce28f28f615b7399e37fcb06fac0997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145543
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [17dc855c6f4a4023393d7006e77a40f89a86fcda]

        cid#1519051 silence Unchecked dynamic_cast
        
        and
        
        cid#1519050 Unchecked dynamic_cast
        cid#1519049 Unchecked dynamic_cast
        cid#1519047 Unchecked dynamic_cast
        
        Change-Id: I3feb25cda71c459c549f0e64558935d1030ed309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145541
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [be3b99f12fa145f26b5ad4821b47d42776dae4c2]

        cid#1519048 silence Unchecked return value
        
        Change-Id: Ia4763684d84b671e4fb2523b6d5bc222fb5e71e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145540
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [b03cc1dd65908a40e804c48f52f42fc6ece63ab2]

        cid#1474008 silence Unchecked return value from library
        
        Change-Id: I23228ae5d61654e2c2d401453bc741a2a6074278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [093a7f422c1184fb8043740cfb6a4f03ed328fa6]

        cid#1519046 Uninitialized scalar variable
        
        bogus, but earlier return makes things easier anyway
        
        Change-Id: Id6c0a72b0ec9bbae061cc1f883b383fbef88e771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Caolán McNamara  <caolanm@redhat.com>  [8003a7b117f822a03b661db86534cc6b4787475a]

        cid#1412875 Uninitialized pointer field
        
        Change-Id: I551a18eddb5a2f436ecb947411faef09ac74d016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145537
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-16  Mike Kaganski  <mike.kaganski@collabora.com>  [e5b86ec34da98d92a749885a06e9093c0f64af80]

        Use o3tl::toInt32 in oox/source/drawingml/textfield.cxx
        
        rtl_ustr_toInt32 was incorrectly used, relying on null-terminated
        content of string views.
        
        Change-Id: Ia3e4bb04a029149e5945274f592252704c34f3eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145549
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2023-01-16  Noel Grandin  <noelgrandin@collabora.co.uk>  [f025dcc44cffc38720ea1b39c456cf562f1d144d]

        XUnoTunnel->dynamic_cast in connectivityy
        
        Change-Id: Ibe5e87a1ef1bdc11451e8fe240d017f1ef60dfe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145556
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [0250d6c643f2866c4de7e3c943248ffda9205d05]

        sw, UpdateFieldContent: address a minor performance nit
        
        See
        <https://gerrit.libreoffice.org/c/core/+/145459/1#message-fa0ede3525e35014c1f6c99455a96a69bc2a3601>,
        it's enough to start grouping undo/redo after we know that there is a
        relevant refmark under the cursor.
        
        Change-Id: I53e7e371768480d6b7e968c90bf8c5d9901013b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145555
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [2cf59dee9637dcb741806ce61e50b6be427dd7b8]

        sw, UpdateBookmark: address some minor performance nits
        
        See
        <https://gerrit.libreoffice.org/c/core/+/145413/2#message-6fda3c30e7b8cdab1137e2397a5f3f00b97d5acc>:
        
        - can start undo later, after making sure that we have a bookmark under
          the cursor
        
        - can look up the bookmark text later, after we managed to insert the
          marks (which may fail in some protected cursor position)
        
        Change-Id: I8ee183974fcc503a5c9a3964e86168888db13586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145554
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-16  Stephan Bergmann  <sbergman@redhat.com>  [5877c6b118c99c9ec807a111471bfd67720a5086]

        external/skia: Missing include
        
        > In file included from workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator.cpp:27:
        > In file included from workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/GrVulkanMemoryAllocator.h:35:
        > workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h:2817:9: error: use of undeclared identifier 'snprintf'
        >         snprintf(outStr, strLen, "%u", static_cast<unsigned int>(num));
        >         ^
        
        etc.
        
        Change-Id: I4f13c8a137f23ef62d67c3b4dfa8f1c0ddfc5ec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145552
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d21260708b67c18cde3531ae565af833688d6f6a]

        XUnoTunnel->dynamic_cast in VCLXGraphics
        
        Change-Id: Ia401542ec8249809ad16dadd79c51aa025044b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145534
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [8081533f7c35939b64f11894470c3e033057a887]

        XUnoTunnel->dynamic_cast in VCLXBitmap
        
        Change-Id: I2cf42ac720184bc2b8b89ced5564dbb95e7dc1ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b9411e587586750f36ba9009b5f1e29fe461d8b5]

        tdf#147122 - Return cell object when a simple selection is merged
        
        Change-Id: I4ddd3b3a804f8300a5ec15526f4c9c77aaf45fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145378
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [1d6593dd799ff4eb931ffbb5338e4856fb87f77f]

        sw: add a new .uno:DeleteFields UNO command
        
        This is similar to 40753de837b9776dd8b33e830be0cceef83f024a (sw: add a
        new .uno:DeleteBookmarks UNO command, 2023-01-13), but that was about
        deleting bookmarks matching a given prefix with their name, and this one
        is about reference marks (fields in general), matching a certain type &
        prefix with their name.
        
        Change-Id: Iec953034cd0e6875f173712b0fb10bfddf16ed3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145551
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-16  Radhey Parekh  <radhey.parekh@gmail.com>  [4114218584bca3267aff474a7b55a9d5891fcce6]

        tdf#112417 Insert Sheet called when clicking anywhere on the footer
        
        Change-Id: I7524ac11729d1c80254c84c27211de3efaa622c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145102
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2023-01-16  Miklos Vajna  <vmiklos@collabora.com>  [77e0c4b5d255c34ccf6cd3977a90ee3575abc081]

        sw: prefix members of BookmarkCollectionHelper, ...
        
        ... HeadersFootersEnumWrapper, RowsEnumWrapper and UnderLineMapper
        
        See tdf#94879 for motivation.
        
        Change-Id: Id4c63d3ebf83dc358747143dabe3b66edea94749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145550
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-16  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [67c6e66c5b0da351ef48bad0ddced17340df33ab]

        external/python3: fix line offsets in internal-zlib.patch.0
        
        "@@ -11607,13 +11607,13 @@" -> "@@ -12333,13 +12333,13 @@"
        
        Change-Id: I03542ad3171814f6869bccab4dde77673eaa90f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144982
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [0160109aae49189f5cc9bed60db3c7084003e471]

        XUnoTunnel->dynamic_cast in GridColumn
        
        And use the concrete type in DefaultGridColumnModel, which already makes
        such an assumption
        
        Change-Id: I4c91d46f1889ebe22b6c031a8aabe4e8957addec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a1108a0c7bf8e531d9771a5ca29a81a2aeea167]

        XUnoTunnel->dynamic_cast in OToolBoxWindowItem
        
        Change-Id: I65e535d9f9a81a3712b14b50cc4906b534533e86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [96cd6623662b719f09596cb700a1f828c75228fd]

        XUnoTunnel->dynamic_cast in VCLXPointer
        
        Change-Id: I322115c214de5d476f84650eb53dae8452d5d1a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5092fdf2420c81887a7e845af8e00bcedee156e]

        XUnoTunnel->dynamic_cast in VCLXRegion
        
        Change-Id: I75956a2c713d52c01dcfd47fc0b8506ba526523e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [d04c197b436094844abfa5fb7c12e095165d2bca]

        XUnoTunnel->dynamic_cast in CNode
        
        Change-Id: Ifcedcb6fc4e20da6351e4ccf035a3fe06d607961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145507
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-15  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [bf432958c1d6d204511a6bb32e2c06161d811676]

        tdf#152774 Fix incorrect result with HLOOKUP and VLOOKUP.
        
        Use case now complies with ODF 6.9.5 (HLOOKUP) and 6.9.12 (VLOOKUP).
        Added use case to unit test.
        
        Change-Id: I19df718b6446098f614136f462662c753a515036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145514
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [f2f008c52aaa88329c07f441de60d6fdfce9f0b3]

        Merge SvXMLAttributeList to comphelper::AttributeList
        
        And simplify the latter, to always use "CDATA" type (as the former did).
        "CDATA" was used in all cases but one, where an empty string was used.
        
        Change-Id: I1b3bfae40e29628e4094d9a6e58a69a66865874c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145526
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-15  Julien Nabet  <serval2412@yahoo.fr>  [9d2355b674d103fe8a73d2db716389980bb69e55]

        tdf#153004: error when copying content to a table without autovalue primary key
        
        In fact, hsql is well managed without extra code.
        
        Change-Id: I93e2b02f3ec78e263cd0f9fab6e33b708dbd3f11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145525
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2023-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f0012b73cfabc039da4c78dc993abb42c9cf987]

        XUnoTunnel->dynamic_cast in UnoBinaryDataContainer
        
        Change-Id: Ifdef69448558f4c5d6902188208d3eea1a080334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145506
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5e40c0bf56806540850d440ad10a26f33e3387c]

        XUnoTunnel->dynamic_cast in StyleMap
        
        Change-Id: Ib4070fbff0c919cdc2be12f5a2bed1b1ac9e03c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [68c6133e4d52c581bb0b98ee4ed8f183eeb4f242]

        XUnoTunnel->dynamic_cast in XMLMutableAttributeList
        
        Change-Id: Ia36576da1f287c9b687042eba5d429366b3db0a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145504
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [92e6cd75a3599d3d411d123bd1e691ec447fa563]

        Typo in "code"
        
        Not sure about this...
        
        Change-Id: I8aebfdf48dc7dc2bdbce180fa2f1bd3305489a24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145516
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [28edd79792a4b0ae7665a23bfbebb9499416daef]

        vcl: add more device independent checks for bitmaps in svmtest
        
        Adds writing of "contentchecksum" to MetafileXmlDump, which sums
        the content of all the colors in an device independent way, by
        reading the each pixel color from the bitmap and summing each
        component always in RGBA order.
        
        In addition add some others bitmap attributes not checked before,
        like bitmap width, height and pixel format.
        
        Change-Id: I3bb5f7f6342766df235af71a4682a5d3ce17ab44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145500
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-15  Justin Luth  <justin.luth@collabora.com>  [5b92a7f211adb229a45c7dedf1ce63e15fcfe5d9]

        tdf#117266 sc oox: macro button unit test
        
        Change-Id: I50b8b5a2d29a5892490a7dbd4cc428786147d500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145519
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-15  Justin Luth  <justin.luth@collabora.com>  [d50eca2a30bdabdc1735c590d6ec1913c6dd22fd]

        tdf#117266 sc oox: export vml button with a correct name
        
        Without a correctly formatted ID, LO was unable to import
        the shape into the spreadsheet. Now at least the button
        shows up and can be pressed.
        
        MS Word already showed the button before the patch,
        so nothing there has changed. That suggests that our
        problem may be more during import.
        
        This code path is also followed by DOC and DOCX formats,
        but they do completely different things with the results.
        This is super nasty code...
        
        Change-Id: I383736a7de9c3e94b427d5747e5949c0348dcecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145509
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [37e3455a13ab5741104bf41d05a80e60a4612682]

        Fix typos
        
        Change-Id: Ib698f8cde8b332487deaae459ba5ed3d3c66692b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145517
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ef5afbbd1856b7d8e4f06fe43c214d785d5d235]

        Removed executable bits on source file
        
        Change-Id: I0becfd79fe71557e7b538e7d4122374c2164fcda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145518
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8e8353c717629e049aa15cda86bcd9a3ea205e84]

        Fix typos and exec bits
        
        Change-Id: Ia23a7b507a8254a5d9143de055c28da9656425fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145515
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-14  Caolán McNamara  <caolanm@redhat.com>  [307206ba04e7ac3882b3bfd433f7f0a4d66c8738]

        ooo_vba_VBAToOOEventDesc_get_implementation appears twice
        
        Change-Id: Ic11d112b92d0942a4246e80e4da8ca1065fd12c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-14  Caolán McNamara  <caolanm@redhat.com>  [8f1c4f341deccead80dd7d0528e6fd4993428601]

        com_sun_star_comp_chart2_ChartDocumentWrapper_get_implementation appears twice
        
        Change-Id: If413be43e68af71ce4f2d1f8e43e4c0d0a5bdc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145520
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-14  Justin Luth  <justin.luth@collabora.com>  [516a3382a774565d4708766ec796c54196563f5a]

        tdf#117266 sc oox: import local macro without reference id
        
        This is what LO exports - a macro without a local ([0]!)
        or remote ([2]!) reference.
        
        It must be at least somewhat valid because MS Word imports
        these just fine. So why don't import what we export...
        
        Change-Id: I8f69c373552b559efcfe7cbb06ea3a706d8ad0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145511
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [93b042f488db7d036821efdb967747a1f9c838e0]

        svx: avoid divide by zero in SvxRuler::UpdateTabs()
        
        Prevent lDefTabDist from ending up in a zero state.
        
        See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs()
        
        Change-Id: I9335f3be12de5db4f4f0c3f434057d91f96733ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [79c7620c5e6f38959356ebf547c367bbc8a245ae]

        XUnoTunnel->dynamic_cast in SecurityEnvironmentGpg
        
        Change-Id: I8535b32de2c7cb71a5108211af0e896029ff5608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [79752f9a37a002871806a8ca85488b9eda0302af]

        XUnoTunnel->dynamic_cast in Transformer
        
        Change-Id: Ief186ab88bfe6f952e2e09351fdaa8e0e8a2b6be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [7666648ab2f420caafa6739cc5bb41d5cc04bf91]

        XUnoTunnel->dynamic_cast in CertificateImpl
        
        Change-Id: I31c03fd894691681401e2ea104ba0d45c95a3c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145502
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [47ff51eabb58c7aca82968dc31c0ca54e3da2661]

        Fix non-PCH build
        
        Change-Id: I70c82cece35585b7021c8adef835cc76112c68a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145512
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-01-14  Justin Luth  <justin.luth@collabora.com>  [73714e30d144a0d01bc2550ca7a6884a0a92af22]

        tdf#117266 sc oox: export vml button with a correct label
        
        This might also be an import problem with LO,
        but at least by exporting this inside of a font
        like it is supposed to be, LO then imports the caption OK.
        
        Identified by trial and error and repetition.
        
        Change-Id: I4b403a3c8392654fabbf00574cb837c92c7f6230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145510
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [83f774d1f6a8405832be48326eca1c6e69ac7cc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c93a82fedbeb00f6913bb8a459d8db425e2cf21
          - Fix bad link in sdatabase
            
            Change-Id: Ia33bd7e02f1b73860f5efee1b86751c3301b249f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145445
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-14  Regina Henschel  <rb.henschel@t-online.de>  [e21053ef1113eb32d6d364b6c69470570a6846fe]

        tdf#153000 Unittest file types MSO_SPT=25 to 31
        
        Unit test for commit 11319f419988443af85cf3c60dbed12d67fc183f
        
        Change-Id: Idac7205a98599b765fdfc25a6fd29460f0ee430d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145508
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d4e4a2b96a787b4f99d68d7a417c37c97b47c170]

        ThemeDialog added which allows to change the theme used by the doc.
        
        ThemeDialog is a common dialog that can be used to select the
        theme used by the document. Currently it only implements colors
        but in the future also the fonts and formats (for shapes) will
        be adde.
        
        The IThemeColorChanger interface is used by the dialog to change
        the actual color values inside the document. For the writer the
        existing ThemeColorChanger is now implementing the interface.
        
        The dialog is accessible in Writer at Format -> Theme... in the
        main menu.
        
        Change-Id: I23c7dc9668cdc5427f36d604a76c433d6dbef497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145264
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-14  Tor Lillqvist  <tml@collabora.com>  [ef3c34596ebc6e6e3b85c4093a28d48fe328c1a7]

        EXCEPTIONS_ON has no meaning
        
        Change-Id: I0ca0dcb76d342b451879788b57da03fb7d79e699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145456
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-14  Sam James  <sam@gentoo.org>  [d532040f3e9f11e4f364e0313e426cdb708e6568]

        configure.ac: Fix build with --with-system-zxing and < Clang 16
        
        Clang 15 and older default to -std=c++14, not -std=c++17 (unlike Clang 16 onwards).
        
        This doesn't show up with GCC because GCC 11 onwards defaults to -std=c++17.
        
        The new version of libzxing requires C++ 17, per its release notes. Adapt
        the configure check accordingly to pass -std=c++17 when checking for its
        headers and save accordingly if successful.
        
        (Do this via ${CXXFLAGS_CXX11} which has the appropriate switch
        for our compiler, despite its name.)
        
        Bug: https://bugs.gentoo.org/890324
        Change-Id: Iaaa8fdc05eea0e26416b605bfda8f2d831f8729c
        Signed-off-by: Sam James <sam@gentoo.org>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145479
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-14  Stephan Bergmann  <sbergman@redhat.com>  [192b0ab41e87f3c4aaf78f22b96b030243c991d5]

        AccessibleBrowseBoxBase's XAggregation is apparently unused
        
        It had been using WeakAggComponentImplHelper5 ever since at least
        f5d6acb1aa368ce50045b949bc12deb4d4bc0c41 "INTEGRATION: CWS a11ysep (1.1.2); FILE
        ADDED", but e.g. AccessibleTabListBoxTable deriving from it implements
        queryInterface in a way that is incompatible with XAggregation (it should only
        have forwarded to AccessibleBrowseBoxTable::queryInterface, and rather
        implemented its logic in an AccessibleTabListBoxTable::queryAggregation
        override).
        
        Also, without this commit but instead with a local
        
        > diff --git a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
        > index d8bcd169ac2e..45797b838167 100644
        > --- a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
        > +++ b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
        > @@ -63,6 +63,7 @@ class AccessibleBrowseBoxBase :
        >      public ::cppu::BaseMutex,
        >      public AccessibleBrowseBoxImplHelper
        >  {
        > +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        >  public:
        >      /** Constructor sets specified name and description. If the constant of a
        >          text is BBTEXT_NONE, the derived class has to set the text via
        
        on all of Linux, macOS, and Windows `make check` still succeeded, and running
        the resulting LibreOffice on macOS with the system's VoiceOver enabled, and
        doing "LibreOffice - Preferences... - LibreOffice - Advanced" and clicking
        around in the "Java runtime environments (JRE) already installed:" table (which
        actually uses AccessibleBrowseBoxBase via SvHeaderTabListBox::CreateAccessible
        in vcl/source/treelist/svtabbx.cxx) also still succeeded and produced audio, all
        without hitting that injected assert that should have fired if the XAggregation
        mechanism had been used after all.
        
        Change-Id: Ic213a03adf31bb1754443c1951b9b267f805115b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145477
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-14  Caolán McNamara  <caolanm@redhat.com>  [b008831a5545e5a777d77547ef96b9798d795f30]

        tdf#152990 set the font after the MapMode is (potentially) set
        
        Change-Id: I64617a5c85e7e6b444aac705ebbfdd777b4ea55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d97a90564abba49dcc072d33ddd12c93f4992fe]

        XUnoTunnel->dynamic_cast in VCLXMenu
        
        Change-Id: Iee992e2e09647a7678fd05321e601a4c5bf0c430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145469
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f812b7ac60c1c4fbc8ccba234c19ccf3871dee4]

        XUnoTunnel->dynamic_cast in XMLElementWrapper_XmlSecImpl
        
        Change-Id: Ie0654c8ba6367b575c289b63ac02668ae38066c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145495
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [97db783599148e7829a898f7e46764e777500ecc]

        XUnoTunnel->dynamic_cast in SecurityEnvironment_NssImpl
        
        Change-Id: I65b109f8f45c57633ca3983bacf496a65ea02ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1af58b5acec4a2de095d86feef05ac4aed3edb8f]

        sw: add ThemeColorChanger that sweeps the model and changes colors
        
        The ThemeColorChanger responisiblity is to recalculate and change
        all the theme colors in the model. This includes styles and direct
        formatting changes. It uses ModelTraverser for direct formatting
        changes as it already implements traversing through nodes.
        
        The ThemeColorChanger replaces the code to change the colors in
        ThemePanel.
        
        Also modify undo/redo for changing of attributes to not move
        the cursor and selection when undoing and redoing (new flag
        NO_CURSOR_CHANGE), as in this case it is very distrcting.
        
        Change-Id: Ida1912bd0697307daad9244d474862830ab2686f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145263
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8bc22ed6899bcbafc3020f0af6c939019506a5fd]

        sw: rework ThemePanel, theme color ValueSet drawing as custom draw
        
        Rework the ThemePanel to only work with theme colors, as fonts
        are uing an old mock implemntation of themes. To do this properly
        it is needed to remove the implementation for now.
        
        The theme colors entries were rendered as a bitmap and then shown
        in the ValueSet. This has the problem that it doesn't look sharp
        on a HiDPI screen, so replace that with a ThemeColorValueSet, which
        uses custom draw to render the theme color entries directly.
        
        The ThemeColorValueSet was added to th svx component as it will be
        used in other components as well.
        
        Change-Id: I1a727ef4cf4be4e215db57ac33f571f43aaddc15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145087
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [08cae41f6f8cb8f9f592c0735d1285c0575d6e49]

        XUnoTunnel->dynamic_cast in X509Certificate_NssImpl
        
        Change-Id: I027e8bcee4f9e2b7bafd2ddf9070b6a28bcded37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [d66d1f6fd47b02076945c09c0d6f8f019d0501d5]

        XUnoTunnel->dynamic_cast in SvXMLExport
        
        Change-Id: I68e4691ac0a58e2320b534d15934ff177feb124d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd6df89dbc26cda08c54e76644b43219d8b75236]

        use more concrete types in chart
        
        Change-Id: I23888f636e36f6163405603a542a2f2f12eefa1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145488
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0e0a74d72af09c01e0c6e1324b42fcc2ef55451]

        use more concrete types in chart
        
        Change-Id: I87a7aed6f0168e92f3de7e188a1858b93b44a9cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145489
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e07d4c03ac08bc1139420210214e69115cf08586]

        XUnoTunnel->dynamic_cast in SvXMLImport
        
        Change-Id: I070bc1a8136e5b492c0ea56774a274b9a3d2ec2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145494
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [e4e2c7a63217c797802045d326f732296e0af918]

        comphelper: check for nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/comphelper::OSelectionChangeMultiplexer::dispose()
        
        Regression from 9931d6b1fb0406e16d56e186812884511738dcfa
        "tdf#150575: REPORTBUILDER: Crash when closing report when used report
        navigator"
        
        Change-Id: I6e4ada368254879d983f80026e9b42ddb4186c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [678747f95083be6f3e4d184e6258e49086952f45]

        XUnoTunnel->dynamic_cast in UnoControlModel
        
        Change-Id: I0d8a65aa16583fcb6c8201589b2d356da0be5cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [793904ff3a7d8cceafab3d83a562261c4c17fd14]

        use more VCLXPopupMenu instead of XPopupMenu
        
        which avoids a bunch of casting and makes the dependency explicit
        instead of implicit
        
        Change-Id: I754da72916fbbc51e7edc3c806155da34d347bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2ec4a66b6d049f5d11f4ceb993ed907c790ed592]

        svx: add UX defined theme color sets
        
        Change-Id: I82cbe16fcfaa8367dacda7ff977e18b0ed39ec2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145086
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4d17d06279d3bceee8d4b92f444b5e425412c576]

        svx: add resolveColor that resolves the color for input theme
        
        resolveColor added to ColorSet resolves the color for the input
        ThemeColor, which contains the index for the color in the ColorSet
        and applies all the additional tranformations defined in the
        ThemeColor.
        
        Change-Id: I5c6d53d5e1d2c61bdb22b0e58c034ec91fbeb2d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145085
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0b35b239c0ff1adad2c4544d8692b5b13a0d363b]

        svx: change ColorSet add method to use ThemeColorTyp enum
        
        Change-Id: I2034a7e915d41c6b55c8344d44be4f6a60e8287e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145072
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [af8fdba1194e657237f9abc460381a1c4bc49982]

        support theme color for lines + oox support + tests
        
        Extended XLineColor to handle model::ThemeColor which then maps
        to the newly added LineColorThemeData property.
        
        Extended oox import and export to map the scheme color elements
        to and from ThemeColor. Added a new test to check the theme line
        color in impress shapes.
        
        Change-Id: I23ecc18c88b5b47608c9110f5681f189d02e2f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145071
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-13  Julien Nabet  <serval2412@yahoo.fr>  [c9b0eacae71f111209cb77f14f2693d73e5e8d90]

        Related tdf#153003: Copying a query and pasting as table in same DB impossible
        
        It might be a regression from ca82061c2cad00aeddb17b766063776fee0ee41a
        "make ValueTransfer easier to understand
        
        storing references to local variables makes it harder to figure out what
        the control flow is doing.
        "
        in peculiar:
        -            sal_Int32 nDestColumn( 0 );
        -            sal_Int32 nSourceColumn( 1 );
        -            ValueTransfer aTransfer( nSourceColumn, nDestColumn, std::vector(aSourceColTypes), xRow, xStatementParams );
        +            sal_Int32 nSourceColumn( 0 );
        +            ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams );
        
        Change-Id: Iaa27c4f46fcc51ec12fff08f8e99f862c8b4ac2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145499
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [32911b8fe99f5205bda08a31b22bfbd991db20f7]

        Fix typo
        
        Change-Id: I4d6b70095259b179f8ac3fc210899ffa84b87fa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145492
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-13  Julien Nabet  <serval2412@yahoo.fr>  [11319f419988443af85cf3c60dbed12d67fc183f]

        tdf#153000: file types MSO_SPT=25 to 31 are wrongly rendered
        
        Description and analysis with MS ref + code pointer + solution here:
        https://bugs.documentfoundation.org/show_bug.cgi?id=153000#c0
        all this thanks to Regina.
        
        Change-Id: I63a66e075bc67e3c7d833756026933b3447d0cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145491
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-13  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [9455aae461685809191a3051cf86a208fa5946b4]

        SDPR: Direct support for FillGraphicPrimitive2D
        
        Added support to directly paint FillGraphicPrimitive2D, that
        means object fill with multiple tiles/tiled fill. Note: This
        may use not only bitmap data, but also metafile or svg.
        
        The standard decompose creates one transformed bitmap/vector
        data primitive per tile what is correct, but has some limits
        (a) These may get many when tiles are small compared to
            mask polyPolygon (performance/ressources)
        (b) Correctness: when rendering in AA the common edges of
            tiles will *not* sum up perfectly, but due to AA
            multiplying when blending will leave ugly 'traces'
        
        This direct rendering avoids both. It can use the D2D Brush
        functionality to repeat. Additionally to the current
        office it can also do that when content is rotated/sheared.
        This may not be well known since for those fills the office
        always keeps the fill unrotated (for historical reasons,
        primitives can do that, but not vcl). To see it you may
        convert a SdrObject to metafile and rotate that, so the
        content gets rotated and shows that ugly gaps.
        
        Also added a square-pixel step value for vector fills where
        the default gets used starting from some size. The argument
        is better quality for vector data fills while only a
        limited number of tiles will be rendered.
        
        Also added a buffered handling of the (old and ugly)
        OffsetX/OffsetY to make that work, we will not get rid of
        that soon.
        
        Packed all of this into tooling (so started a tooling
        collection for SDPRs target-system independent) to be able
        to easily re-use all these preparations/tests in other
        SDPR implementations in the future.
        
        Change-Id: Iafacf4181e7c9e2d2b2e3b5cf1f7e4cdd0a43f0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145466
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-13  Michael Stahl  <michael.stahl@allotropia.de>  [a25eda715591cfa96136bcfd95360156516239d1]

        tdf#131386 writerfilter: RTF import paragraph mark formatting
        
        One obstacle was remove in commit 02f53bd61222d7999b847a22fd24d65195f129e5
        
        To fix it, when \par is handled, runProps() just has to be called
        unconditionally.
        
        Now one test fails with:
        
        rtfexport5.cxx:438:Assertion
        Test name: testTdf107413::Load_Verify_Reload_Verify
        equality assertion failed
        - Expected: 14578
        - Actual  : 14698
        
        The spacing above the first paragraph in the table in the footer
        is not imported - because this is recorded in a buffer, and when replaying,
        getProperties() is called with Id 0, and not LN_Value_ST_StyleType_character
        as when it's called immediately without buffering.
        
        Change-Id: If86ed2fa88eb2ac0eafd7a8be411bbfa341619b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145490
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2918ed9add416e16396965a4b6c7a5e8865a07f]

        XUnoTunnel->dynamic_cast in SvUnoAttributeContainer
        
        Change-Id: Ief76f12dd98e3455667b70d09605c82c0cedc4b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145485
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ca22b602154dfab8f45a98259e5365b0a5e7bc4]

        XUnoTunnel->dynamic_cast in SvXMLAttributeList
        
        Change-Id: I68806bf4b59f76c49f733283d9db21c68342c071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145484
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [d60722e29a0dde6282915188e5ff7e24890a14d3]

        XUnoTunnel->dynamic_cast in TransferableHelper
        
        which leads us to find that we can skip all the dynamic_cast'ing
        altogether in SwView_Impl
        
        Change-Id: I8914f78df6bfdd743df370c0017d5b8521863594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [d4d046bb9c5d17cdd432b362c38914cc7b0a75f1]

        tdf#39650: move UItest to CppUnittest
        
        Change-Id: I2ff89c53309d7e3a4da11d652aafeb38cbc41205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145480
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a5e092b53f91d314fd79b48ceaca88030865ac3b]

        Fix typo to complete commit 613baf157375
        
        See https://gerrit.libreoffice.org/c/core/+/145241
        
        Change-Id: Ic9c229fc891ce81c52c7886055a0a3474020f233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145392
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-13  Caolán McNamara  <caolanm@redhat.com>  [820da3fbcc2e0e2c176ec7e202bb77ea1d5c435d]

        tdf#150708 downgrade a11y SAL_WARN to SAL_INFO
        
        Change-Id: I4e0a082bfe130bf2a4031f9559ddbdf9bb04c00a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-13  Stephan Bergmann  <sbergman@redhat.com>  [4aa8f40f666b87038c6399c8cd2782e7d8e9c527]

        Base OSubComponent on cppu::WeakComponentImplHelper
        
        ...rather than on cppu::OComponentHelper (which derives from XAggregation) and
        then manually suppressing support for XAggregation in
        OSubComponent::queryInterface
        
        Change-Id: I6718d36f20579806b508c4bf5048b734643ad716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145476
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [1fd4e669a99225459fc3b5bf082487c2644ce691]

        XUnoTunnel->dynamic_cast in X509Certificate_MSCryptImpl
        
        Change-Id: If61114df98f4096798281a28ffcdf58168ff7fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noelgrandin@collabora.co.uk>  [817dc69bb6c96f7494510cd45262aae677323a47]

        XUnoTunnel->dynamic_cast in SecurityEnvironment_MSCryptImpl
        
        Change-Id: Idb013bd71b2a90cd6fb8927b199eb36e9bfd9c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e301586113ea693d5133527678866be4be3f62e]

        XUnoTunnel->dynamic_cast in SfxUnoStyleSheet
        
        Change-Id: I22ad42fd0de3de3bddc1b6d3a99f09883e523340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145464
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Michael Stahl  <michael.stahl@allotropia.de>  [de2b1a3a22a0a3bf5dfdd44c57c09e1fd0ba39d2]

        tdf#152952 sw: don't hyphenate URLs by default
        
        New compatibility flag HyphenateURLs, disabled by default for Word
        interop and enabled for old ODT documents.
        
        Change-Id: I1496819599deb5ed0fd736698d269ab9a22167fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145415
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [425fa089778c4a2f59bdabdc6917296b55dcef16]

        tdf#102525: move UItest to CppUnittest
        
        Change-Id: If7881b49cc006157e177559308048a0f2d2c10b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145473
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8138eaa3934c1797422ff28cae31100c02b376c]

        tdf#95306: move UItest to CppUnittest
        
        Change-Id: Ic999c9d10d9a3ae16de0df70b435a5d822035193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145471
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-13  Caolán McNamara  <caolanm@redhat.com>  [8c60271459c4ff61bd0c3a4df0274cefe942362d]

        tdf#150708 if the old is CARET_OR_STATES then try updating it
        
        with the additional states. Hard to know if this is a sensible approach.
        
        Change-Id: I0d55d41c4dd9cbb17fb736e5145671cd6a8b25ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [79ad3e73907d15c4e234e2a32de8173273f5ac16]

        oox: also allow tint and shade for fill color
        
        This was an obsolete limitation that is not needed anymore.
        
        Change-Id: Ie9610516996fc16197f8611843ff621b8a83ebdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145084
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-13  Patrick Luby  <plubius@neooffice.org>  [fed429e4f6f437997aa6a88e2d071f58aa00ee34]

        Related: tdf#152703 Eliminate potential blocking during live resize
        
        Some events and timers call Application::Reschedule() or
        Application::Yield() so don't block and wait for events when a
        window is in live resize.
        
        Also, only native events and timers need to be dispatched to redraw
        the window so skip dispatching user events when a window is in
        live resize.
        
        Lastly, only higher priority tasks need to be fired to redraw the
        window so skip firing potentially long-running tasks, such as the
        Writer idle layout timer, when a window is in live resize.
        
        Change-Id: I5d449caa432399e836b8e59781e5cc53af718873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145211
        Tested-by: Jenkins
        Reviewed-by: Patrick Luby <plubius@neooffice.org>

2023-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1a79594a27f41ad369e7c387c51e00afb1352872]

        ooxml: fix theme color type mapping: bg -> light, text -> dark
        
        Change-Id: I19ad3ef7c911943075d7ddc01626047cdf11d5db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145070
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3eb53d327fb5d9689b799ff991a6c53c05eff496]

        xmloff: use XThemeColor in ODF, change the format for themes
        
        Change the xmloff filter to use XThemeColor and the associated
        proprties (CharColorThemeReference and FillColorThemeReference).
        
        Change the ODF format for referencing a theme color - make it an
        element instead a series of attributes on the *-properties style
        element.
        
        Change-Id: I0fa7d8ebffecc02897b7fe9824d6f1776ef36380
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144923
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6d44c4684f9b037e5c762430df78af2fc85cf34]

        XUnoTunnel->dynamic_cast in VCLXFont
        
        Change-Id: I4afa34805e64f3ff37b76fe8ca4676c1f4eb3e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145468
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [172aedbc51e4bd972bef3f94d562e09ee7bc8355]

        XUnoTunnel->dynamic_cast in VCLXDevice
        
        Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce4193e3398e30c25ec28310a8034b4ca5513d7a]

        XUnoTunnel->dynamic_cast in SvxUnoNumberingRules
        
        Change-Id: I492a951f1d686e1507232e6688c2dc75e8a41cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145463
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [25d5e2041fb13aee61acb6ced579e884ce9a21b5]

        tdf#152860 Fix tooltip for .uno:SearchLabel command
        
        This patch makes the following changes:
        1) Silence the string "[placeholder for message]" for translation, since it is never actually used in the UI.
        2) Add a generic tooltip for the command.
        
        Change-Id: If46d7476638c72d35af2a4c8f242542aae2eafca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145294
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [c89f9fe8fa0c0985af1997d3b65089a6ed0fd35e]

        remove XUnoTunnel from SvxUnoTextField
        
        nothing seems to be using it
        
        Change-Id: Ib986d2906ac10df3743a30d912bb8ec356838e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145462
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [40753de837b9776dd8b33e830be0cceef83f024a]

        sw: add a new .uno:DeleteBookmarks UNO command
        
        This is similar to commit c68d06dfa1498f862923eaddf3e5d247650a53d5 (sw:
        add a new .uno:DeleteTextFormFields UNO command, 2023-01-10), but that
        was for fieldmarks and this is for bookmarks.
        
        The primary use-case is to specify a prefix for the name, so e.g. all
        Zotero-related bookmarks can be removed, but it can be also used to
        remove all bookmarks when no prefix is specified.
        
        Change-Id: Ifc1f666f66d9fc3f6cd055f9263f0e4f949c191d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145458
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [18b6406439a93294d65a001a83311ab175d9bf49]

        Fix typos
        
        Change-Id: I173920a96524f991f2965af99e8d95f11d1b3c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145455
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-13  Caolán McNamara  <caolanm@redhat.com>  [65596d7062ac4edadeef84cc335a585ffa942fe0]

        tdf#152994 actually return in this case
        
        Change-Id: I40cb4dc4ce1fd3caa2464f92803124c3d2107afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-13  Tor Lillqvist  <tml@collabora.com>  [22cb88b25ba9a52ca0e0eaa3fd116f5fbcc9422f]

        Fix Emscripten version check to still work with older SDK versions
        
        Change-Id: I051b5edd5936bcb94521f88ec7a7a762c66c9283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145419
        Tested-by: Jenkins
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [402ab3d145a1e8e123caabf4567aef7b6631fc3c]

        sw: add a new .uno:UpdateField UNO command
        
        This is similar to commit ea208f6004770eb4b81d28e6930cd0c7bd5d8f12 (sw:
        add a new .uno:UpdateBookmark UNO command, 2023-01-11, but that was for
        the bookmark under cursor, and this is for fields (refmarks as a start).
        
        Change-Id: I3e547b668361898b7ed734ea325fdf1d74e5dbb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145427
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-13  Stephan Bergmann  <sbergman@redhat.com>  [55b534660e3fc99a4e4e07cf05df7798e9ba0726]

        OFactoryComponentHelper's XAggregation is apparently unused
        
        It had been using cppu::OComponentHelper (which derives from XAggregation) ever
        since b525a3115f54576017a576ff842dede5e2e3545d "initial import", bug e.g.
        ORegistryFactoryHelper deriving from it implements queryInterface in a way that
        is incompatible with XAggregation (it should only have forwarded to
        OFactoryComponentHelper::queryInterface, and rather implemented its logic in an
        ORegistryFactoryHelper::queryAggregation override).
        
        Also, without this commit but instead with a local
        
        > diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
        > index c8efcab0e604..9011264b3f3a 100644
        > --- a/cppuhelper/source/factory.cxx
        > +++ b/cppuhelper/source/factory.cxx
        > @@ -241,6 +241,7 @@ class OFactoryComponentHelper
        >      , public OComponentHelper
        >      , public OSingleFactoryHelper
        >  {
        > +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        >  public:
        >      OFactoryComponentHelper(
        >          const Reference<XMultiServiceFactory > & rServiceManager,
        
        `make check` still succeeded for me on Linux, without hitting that injected
        assert that should have fired if that XAggregation mechanism had been used after
        all.
        
        So switch from OComponentHelper to WeakComponentImplHelper here (which is the
        simplest implementation helper to use, even if it still needs the non-standard
        OFactoryComponentHelper::getTypes overriding the non-fitting
        WeakComponentImplHelper default implementation).
        
        Change-Id: I9fc2f4f2ef36bd016f9a943a8efd5e4ac5f3baaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145428
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [3de6b42235aa25f621ae293ad6bad1ee03298358]

        Simplify a bit
        
        Change-Id: Ie2435701078b0e111c1b04b77c857fd1923f2d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145430
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [8bdd832d2088af4f81402e2c0cb2ee36788238da]

        sfx2 lok: conditionally revert CreateBackup changes
        
        This was enabled by default in commit
        5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22 (tdf#152463 Turn on AutoSave
        and Backup by default, 2022-12-12), and it makes sense on the desktop,
        but this breaks LOK clients, e.g. online.git unit-wopi-save-on-exit.
        
        Keep the desktop case unchanged, but disable it again for the LOK case
        to make the failing test pass again.
        
        Change-Id: I3a7eed8fdd6d394e9c7e75a477cbc11a6f40f7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145426
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-13  Heiko Tietze  <tietze.heiko@gmail.com>  [f2a2ca8a9d4bf0314b2012cc1d066c65044bd5e0]

        Resolves tdf#119919 - Show hidden children in Stylist when in tree mode
        
        To avoid styles appearing on root if their parent is hidden
        (eg. Heading hidden, Heading 1 moves under root), the Stylist
        shows all styles but with disabled color for the hidden styles
        
        Change-Id: Iec73a3010ab05d01e9b7209d81f1f03c1355ef49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145324
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-13  Stephan Bergmann  <sbergman@redhat.com>  [e001703df46d601a9ba21512a259c1caf266edac]

        Merge OSingleFactoryHelper into OFactoryComponentHelper
        
        Change-Id: I7faf7a3ad54c80bd3c53525c92c26c0f980110f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145423
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [04fd7d0f53faa08c608034707ca4a459a162712d]

        Update pdfium to 5522
        
        The internal libpng 1.6 is now dropped, but that doesn't really affect
        us.
        
        Change-Id: I777c024c76c17689c20bbe6453467ba5fb22baba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145417
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [04d50fa627faabb9211bd9fa9eb134599fb01982]

        sw: rename getBookmarkFor() to getInnerBookmarkFor()
        
        Because otherwise it's quite confusing that we have a For() and an At()
        variant as well, and it would be less clear what happens in For() when
        there are multiple matches.
        
        Also improve getInnerBookmarkFor() a tiny little, so we process the
        first hit only once.
        
        Suggested at
        <https://gerrit.libreoffice.org/c/core/+/145348/1#message-286262286f234823b390e8f962e3ba11f5fa71b2>.
        
        Change-Id: If068f93e6934c9fc042760c03aac866fe5b50bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145412
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [60be9811555b935d6860157ebf26fac6b48327ac]

        sw, FN_DELETE_TEXT_FORMFIELDS: allow deleting all fieldmarks
        
        As suggested at
        <https://gerrit.libreoffice.org/c/core/+/145347/1#message-d2e88d8a1923f0fa5d2869b8d92e1d25d15ac645>,
        in case the provided prefix is empty, then don't try to look up
        ODF_CODE_PARAM and don't compare it with the provided prefix.
        
        This allows deleting all fieldmarks in the document, which is probably
        intended with an empty prefix.
        
        Change-Id: Ic3015925165a9abc13a30889c36c667b10996c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145409
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-13  Miklos Vajna  <vmiklos@collabora.com>  [81f690ec0cb2a6dc0d6ca0f6de3adcc07eb7bc12]

        sw lok: expose name of refmark under cursor
        
        This is similar to commit 4bcb66ec7b417fbe113267f2615e78fe47eb55ca (sw
        lok: expose name of bookmark under cursor, 2023-01-11), but that was for
        the bookmark under the cursor and this is for refmarks.
        
        Change-Id: I0acf0181d0acfdc087e1ed737b3c18ab3736031a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145405
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [14df26ac57696c11fd344bb16ec22738e42377fc]

        XUnoTunnel->dynamic_cast in comphelper::ByteReader and comphelper::ByteWriter
        
        Change-Id: I1f8c864a939dff1252ba15f517f63b62d1a1e1fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [20adf4683c7d38ad41edac586b897757393c8029]

        tdf#152425 related: don't generate style ids in DocxAttributeOutput::Redline
        
        If the style id is unavailable from MSWordStyles::GetStyleId at this point,
        it is a bug (meaning that we failed to output the style to styles.xml).
        Local style generation here would skip the "make it unique" step anyway,
        so the id would be unreliable / useless.
        
        Change-Id: I32c3c6a2581a7aaa6c5b1bb3d48f09b90fb65f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145401
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [197e5f81213d14fdcbff40edf73385ecd4cd9815]

        introduce {Char,Fill}ColorThemeReference which uses XThemeColor
        
        Adds a unified UNO property for theme colors *ColorTheme
        (CharColorTheme and FillColorTheme) which uses XThemeColor, that
        replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod.
        The properties are still present for backwards compatibility and
        to keep ODF support working in tests as that needs a bigger change.
        
        Reactor the code and tests to accomodate for this change.
        
        Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [c82fa434dab8744c548db166cd24ee82e8759e1f]

        sc: move different UItests to CppUnittest
        
        it seems Jenkins fails sometimes with this test
        https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/131248/
        this commit might help
        
        TODO: convert the remaining test
        Change-Id: Ib3fb48e2e457a9168fa16c8f9f2ac9f98beabcf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145422
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bd0f526f2d3e1ffe43a74672485815768eee6e9e]

        introduce docmodel comp., model::ThemeColor, use it in SvxColorItem
        
        Added a new component docmodel, that has the document model types,
        which only depend on other basic components. This is needed so the
        types can be used in every relevant component - xmloff, oox, svx,
        editeng,...
        
        Introduces model::ThemeColor, which is a class used to store the
        theme color data, including transformations (svx::Transformation).
        For UNO use XThemeColor is added, and the implementation UnoThemeColor
        which wraps svx::ThemeColor, so it can be tranported around.
        
        Reactor all the code and tests to accomodate for this change.
        
        Change-Id: I7ce6752cdfaf5e4d3b8e4d90314afa469dd65cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144847
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [c945eafc99856f0bcd0a99195e2c5164c2a6d24a]

        Don't let OSingleFactoryHelper delegate to derived classes' virtual overrides
        
        ...as it doesn't make sense that e.g. OFactoryComponentHelper::createInstance
        checked for bOneInstance, called OSingleFactoryHelper::createInstance, which
        called [OFactoryComponentHelper::]createInstanceWithContext, which checked for
        bOneInstance again
        
        Change-Id: I53f54079a2ac1af18a6e95f0cb9d7b75c1e46ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145418
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [ca3ba86fe17227089d797f4f46cf228af97de3b3]

        Fix aggregating OFactoryComponentHelper::queryInterface
        
        4bfc00aca2441082842f91dfba15886258674227 "#67468# factories support
        XUnloadingPreference now" had added the check for XUnloadingPreference there,
        but that's already covered by OFactoryComponentHelper::queryAggregation
        delegating to OSingleFactoryHelper::queryInterface.  (And as
        OFactoryComponentHelper is inheriting XAggregation via OComponentHelper, the
        only thing that OFactoryComponentHelper::queryInterface shall do is delegate to
        OComponentHelper::queryInterface.)
        
        Change-Id: Iebe507e88791d1e2390d042a8a9c152512ce212a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145420
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [c925ad4b1be66bf9cb94fbda0873c1da26f28aa1]

        CppunitTest_sc_uicalc: remove leftover
        
        from commit 3756e3145c39ace4454d2569709c2c0d64ad389a
        "CppunitTest_sc_uicalc: combine external reference tests"
        
        Change-Id: I0c34ae8bd1668aa6ecc02d420aa767f7d631bef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145404
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-12  Jim Raykowski  <raykowj@gmail.com>  [d784da48de7c9ecccf39cea55f49d8d4758cab58]

        SwNavigator: Improve mouse move handler for bringing objects to
        
        attention in the document view
        
        Fixes crash that happens in SalInstanceTreeView iter_compare when the
        mouse enters the content tree at a point that has no tree entry and
        is then moved over an entry.
        
        Moves code to bring entry content to attention in the document view
        from the mouse move handler to it's own function.
        
        Renames the overlay timer handler function and moves it to the area
        of the code having related functions.
        
        Checks added for visible content and if the type has any content to
        bring to attention.
        
        Change-Id: I381eed6ffcf7ddb095c4c09650578a7f7fd874b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145168
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [8ab24f26626a65e1ce9e1ff8c4eb75a20e4b7629]

        tdf#152994 only query dark mode in Windows >= 10.0.18362
        
        Change-Id: I8d8bd368d9d1ee38dac96dd369484ec74ce4835a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145414
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [019c49ec96afc3ea0c50e99881f5a6324b4ec732]

        draw selection bounds without using RasterOp::Invert
        
        Change-Id: I65fa68bbd8ff40c0e324851376dd8a8a1614ac99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145396
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [af27dabe816666945b02cd31bb6d6f9d84f732c0]

        mbDragDrawn is always false when queried
        
        Change-Id: Ie8eda3465381eeed62d3271040c1697ef8f6559a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [13cd316bc733fbe37db105dc705b9d172aec8809]

        ofz#55034 Stack-buffer-overflow in vcl::bitmap::CreateFromData
        
        since:
        
        commit 21734247d58a6e915b058d8fa55ece949d049613
        Date:   Tue Jan 10 12:56:58 2023 +0200
        
            drop internal support for 1-bit images
        
        the input data is still 1 bit here, even if the output will be 8 bit
        
        Change-Id: Ib7eb301b2e62ebc61ee61ebb99e6de92c1f4931b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145410
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Jim Raykowski  <raykowj@gmail.com>  [dc3deffb15f6c924375b38f606eb640fe065089f]

        tdf#152921 Fix sidebar tabbar tab highlighting
        
        Makes the highlight state of the tabbar tab behave as expected when
        the sidebar is in the collapsed or expanded state. When collapsed, the
        tabbar should never have a highlighted tab. When expanded, the tab in
        the tabbar corrosponding to the open deck should be highlighted.
        
        Change-Id: I0e6c54aff95b1f1e417f147070742e900fd51513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145251
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [933519505aee0e91ca99af0ed860e4a0f148f922]

        Fix VclTextTest with colorized antialiasing
        
        The Flathub build for
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/d5ac1d2bd680970ba992c8c6836683262f067592>
        "Merge pull request #206 from flathub/lo-7.4.4" on 2023-01-12 at
        <https://buildbot.flathub.org/#/builders/6/builds/16778> consistently failed for
        both aarch64 and x86_64 builds with
        
        > text.cxx:260:Assertion
        > Test name: VclTextTest::testSimpleText
        > double equality assertion failed
        > - Expected: 28
        > - Actual  : -1
        > - Delta   : 2
        
        during CppunitTest_vcl_text.  The reason (as seen with a temporary build setting
        mbExportBitmap = true and looking at the resulting
        workdir/CppunitTest/vcl_text.test.core/simple-text-36-50pct.png) is that the
        stem of the "L" doesn't contain any COL_BLACK pixels, so
        getCharacterLeftSideHeight returns early with -1.  The stem is drawn as three
        vertical lines of pixels, a yellow (RGB 255/195/111), a black-ish (RGB 23/0/0),
        and a blue (RGB 31/155/199) one.  In comparison, when running the same test on
        Fedora 37, the three vertical lines use gray-scale instead of colors,
        RGB 195/195/195, then true black (RGB 0/0/0), and RGB 115/115/115.
        
        An earlier test build of
        <https://github.com/flathub/org.libreoffice.LibreOffice/pull/206> "Update to
        LibreOffice 7.4.4" for the same libreoffice-7.4.4.2 tag on 2023-01-02 at
        <https://buildbot.flathub.org/#/builders/6/builds/14712> succeeded, so I assume
        that it must be some change in the meantime to the underlying
        org.fedoraproject.sdk//22.08 that started to cause colorized antialiasing here.
        
        Change-Id: I7059268eabcfe8e501d0be4f38746707def7bb35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145411
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Miklos Vajna  <vmiklos@collabora.com>  [a2fb3a135425bbc14375e1edfcc1e09a41d760f9]

        sw HTML export: fix invalid HTML when all cells of a row have the same rowspan
        
        The bugdoc has a table with 2 columns and 2 rows, but both the A1 and
        the A2 cell has rowspan=2, so there are only covered cells in the second
        row. It seems there is no valid HTML markup to express this Writer doc
        model.
        
        What HTML seems to suggest instead is to simply decrease the amount of
        rowspan attribute values and then the empty <tr> elements can be simply
        skipped.
        
        This fixes the
        
        	Row 2 of a row group established by a tbody element has no cells beginning on it.
        
        from the w3c HTML validator.
        
        Note that you can't create such problematic tables on the UI: the UI
        will delete the row only containing covered cells for you when the last
        cell gets merged. Such documents can be created by importers, though.
        
        Change-Id: Ice4fa3636e8b780d374f3d319b198aaaada9f5e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145402
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-12  Tor Lillqvist  <tml@collabora.com>  [044cf67f1362088723908747d576aff81cdf4e61]

        Adapt to newer Emscripten SDK
        
        The check for platform in raptor's sort_r.h no longer worked with
        Emscripten 3.1.30. Looking for __EMSCRIPTEN__ explicitly helps.
        
        Change-Id: Ieccf723d809b4e90d44a8a510f71e12bd1d2e529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145408
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-12  Tor Lillqvist  <tml@collabora.com>  [57eae105cdd6faeb7640f06cf4706fde9bf73fbf]

        Adapt to newer Emscripten SDK
        
        The __EMSCRIPTEN_major__, minor, and tiny macros are no longer
        predefined but only defined in <emscripten/version.h>. So grep that
        instead of running emcc -dM -E.
        
        Change-Id: I2383a906f9c746784449cd4606f653ab722b54de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145407
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-12  Miklos Vajna  <vmiklos@collabora.com>  [b3a15589915e8b60eae5878e53f90d706c79c106]

        vcl: handle VCL_DUMP_BMP_PATH in BitmapEx::DumpAsPng()
        
        As requested at
        <https://gerrit.libreoffice.org/c/core/+/145361/2#message-e00b755a1a0cdc5cec9b8e2213226e56ec87c038>.
        
        Change-Id: I8868969a2061f0447b101d978acc5027d1bdd545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145400
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9f0e7db8475f35ec8c5081771dc00f0cda651e7b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 31b3190fb111c82e95e8322e860c4371407c4bd9
          - update translations for 7.5.0 rc2/master
            
            and force-fix errors using pocheck
            
            Change-Id: I47591b005b12917245c4be7214d6bd986780044d
            
2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [b4aa526d9ad0e8cc8975b2f18676486d1cf7c508]

        loplugin:passparamsbyref (clang-cl)
        
        Change-Id: I6d1cdd3f420e146ecad38bd3b1181eb654481440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145394
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d6f726ff5d33ca0d2450aebc04b3efd490fb5314]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b23e481175ae62e827075f333d303fa393fd65e0
          - tdf#152589 Add warning on experimental mode
            
            Change-Id: Ia3e85594b88ec9e38c1e3efb84cf02dbd69fba42
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145406
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-12  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [0ce4c1e6898ba83d487f1b225dc9ee0bbc00d9fc]

        tdf#152774 Fix incorrect result with MATCH.
        
        Use case now complies with ODF 6.9.14 (MATCH).
        Added use case to unit test.
        
        Change-Id: I749a979135fbc01a3bb1583092fb6d6a100e2d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144883
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ef626f2ff72c62ee42e74e2b58174c047e384cd]

        override GetModel in ScDocShell
        
        so we can avoid dynamic_cast and XUnoTunnel in various places
        
        Change-Id: I1f524270a8030106a2058691c3d89b90d46ed26f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145391
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fd2f0b93bd7d38a277823bfc251c71da7a6f490]

        use concrete class in Submission
        
        the code already relies on the underlying type of mxModel being Model
        rather than XModel
        
        Change-Id: I5b78482d37024a5bc274b0208fa56e4328f3f5f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [d85a6fd228b3eaeb9214e73cdec0c6ef88e058e3]

        add a warning that this enum is streamed to the svm file format
        
        Change-Id: I5a16b5ac64189ade77f6378d8cc88eee41ee188b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145357
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [052e77bdd2b74ff068b89ecb6229e31d1854624c]

        document that LineJoint_MIDDLE is treated the same as MITER
        
        Change-Id: I3d82d1dd3b5f66d76622103ec7b9b76acd857f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145356
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [3be24f151076def167c3a551c0e1811d457d2691]

        move drawTransformedBitmap to CairoCommon and reuse for X11CairoSalGraphicsImpl
        
        Change-Id: I9b03d2ec973e2dab28358d7e8041b9d26705e700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145352
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [a11cabb47249257d8b6510fe91063ade03d0c636]

        rely on support for NET_WM_ICON
        
        I can't find anything where that doesn't work, so can drop
        IconPixmapHint/IconMaskHint.
        
        Change-Id: Ifa9f6a548a92006450335037836fbb7dd3039ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [099413f4f113fd697afcb0b96cb0dd95ab5d32c6]

        drop some unneeded includes
        
        Change-Id: Ibde845b19bc5993251fb2118b3daeafb63871aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145338
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [f22a9447c58f2026bc765286a626b3b746977f19]

        Simplify a bit
        
        Change-Id: I8e86aa5a43f7c0bc234331def1b4440dbe2cefa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145389
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [171f6e048c171cbf6a00cdf95a447ce6f074b6a0]

        make SupportsCairo always return true now
        
        Change-Id: I818c63aadd23256c183b89a69b77ac8cdcc081f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [9d1e4cbf481c643e1674a493e4911e17d12a98f7]

        remove newly unused X11SalGraphicsImpl
        
        Change-Id: I91d5c75f38a6798e6c4a3ce10d21fede558d27db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145337
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [bb9594a3b6d9c71fb2d817291ca7e02470cccd11]

        drop X11SalGraphicsImpl middleman now
        
        Change-Id: Ifccf6016403503a5abe34d0c1796ee43d14143de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145336
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [622e8cd9e5c96d0fe0bb02e07d95efa93c156c44]

        reuse CairoCommon GetGraphicsWidth from X11CairoSalGraphicsImpl
        
        Change-Id: I925f67469b2821b85b86260be22bc111cd97d452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145333
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [e28eee5b04391ab7b38e336747f3d2462f602785]

        move X11SalGraphicsImpl::GetBitCount to X11CairoSalGraphicsImpl
        
        Change-Id: I7ccd95539ee8e9368deb42f6c72f2ef0efe49d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145329
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [9107b3789c2d01a219632e646ea04cf6776e703b]

        X11SalGraphicsImpl::GetGraphicsHeight is newly unused
        
        Change-Id: Iab08e42aa7c734072faab5b5b48eb77f646b0eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [c3712f26582e5b89eb73866686d4ee857531ea4f]

        mpClipRegion is newly unused
        
        Change-Id: I52d1848faf7821385bb0d87f9bb512e51365c4f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145327
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [d19c1a92317a962d9ff0d682ef99284a8afe9179]

        X11SalGraphics::SetClipRegion is newly unused
        
        Change-Id: I920294975905c3ff3f3cc3d89411b4d0349d746d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145326
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [4557bd79fe323af6b192e40ba6a035fe06d6adcf]

        merge duplicate CairoTextRender impls
        
        drop getSurfaceOffset because both impls just set these to 0, so its
        a no opt
        
        Change-Id: Ie4f28d57fb8a170c7a46d3cafceef3e049c26e2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [4160be791daaef1a0c059a248f678cbad6408a69]

        no more X11SalBitmap
        
        Change-Id: I2c721c6058ab17717350742dd4390db0ad74b1f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145293
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Dennis Francis  <dennis.francis@collabora.com>  [d4760b5d4b49fef1c832357059c7e184b3cc0bc4]

        sw: lok: use redline author for saved author fields
        
        Without the fix author fields will expand to "Unknown author" when
        loading files which have author fields in them. But only update the
        fields when the first view joins and not for later view joins.
        
        Change-Id: I4ac3b25349b8057812c45dc8148f8b3fc3b7ca1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145317
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [6c5c33a8279c2281cd5008b25d966aee98aaf021]

        loplugin:fakebool (clang-cl)
        
        Change-Id: I8b1aa39ef008e1865e3fd529a49b10b95db1f046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145383
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5e0caf8972a2855d0458931233a00783cfb0f3f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f1c42932246dacd75345a130baee7fb6f07d9f07
          - tdf#152589 Add Transtate command & settings Help page
            
            + Also add Help page for LanguageTool options
            + Note: DeepL service not available in Southern Hemisphere, therefore
              I've not tested it.
            
            Change-Id: I8a4bb01462e40113b40210b10024c59db0da293c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145366
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [db2b43065f53f3e620cade5c2bc2d492c0f7fc34]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b6ed464e1709685a0c20a7254d169c5553aa13a
          - tdf#129726 Insert Index and Edit Index Help pages
            
            + Merged Insert and Edit Index help pages
            + Deletd Edit Index help page
            + Refactor
            + Adjust links
            
            Change-Id: I01eab63177e0a2f9962878398c86ee5ec2418dcd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145269
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ce58da3240e508800bd3e6fd7d56fb5fbde3349d]

        tdf#129726 Add extended tips to Index Entry dialog
        
        Change-Id: I2fe583ccac6aef7ef024b6a31cfb2cc892b8af88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145282
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-01-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2dd49de5cae2ce3896fb9a611610d130a216ed1d]

        Add Help button to Translate dialog
        
        Change-Id: If7dbbd2fa58094a0b58250887a00dba364940ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145367
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-01-12  Julien Nabet  <serval2412@yahoo.fr>  [e78859005b632860c9464335fdf6836c4fd41807]

        Curl:CURLOPT_REDIR_PROTOCOLS(_STR): use only "https", not "http"
        
        Change-Id: If615503b598f6823d7978f12e666832c82b63ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145334
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-12  Miklos Vajna  <vmiklos@collabora.com>  [432aefa738ed0b3a6215629569a5bcffdeb504d5]

        tdf#152961 sw: fix layout loop on removing fly from page
        
        Loading the document resulted in a layout loop.
        
        This is a problem since commit cf2c070de2bafeec3b476c6bff7bb4ac87ba46db
        (sw layout: invalidate margins of body content when moving a fly from
        page, 2022-12-09), which started invalidating the content of an old page
        in case we remove a fly from it, because some frames calculate their
        margins based on the flys of the page.
        
        Fix the problem by invalidating only the table frames of those page
        lowers: the direct need for this invalidation comes from
        SwTabFrame::CalcFlyOffsets(), which is not relevant for other frames.
        Also, in case non-table lowers are not invalidated, then the new bugdoc
        loads fine, which means this fixes the new problem while keeping the old
        problem fixed.
        
        This assumes that non-table frames have their equivalent of
        SwTabFrame::CalcFlyOffsets(), which do their own invalidation, so
        SwPageFrame::MoveFly() doesn't have to do it.
        
        Change-Id: I807d55d077bb0e023beb66775ab68bbca2680eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145384
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [7b398af091c2d130becc21d38381751830398140]

        loplugin:external (clang-cl)
        
        Change-Id: I09e30d3e250bad9c328688b78cf387fcdb12c2a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145382
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [0727e4ca62f40a32926a716fd3fe62343cc76b83]

        loplugin:unnecessaryoverride (clang-cl)
        
        Change-Id: Ib0f721cb0bb7ebfd3b422cfb9e93804a70e1270b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145381
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [d66a97d5622bfc7c8d68452eb5a3c2378b0b1820]

        loplugin:crosscast (clang-cl)
        
        > winaccessibility/source/service/AccTopWindowListener.cxx(47,36): error: suspicious dynamic cross cast from 'css::accessibility::XAccessible *' to 'VCLXAccessibleComponent *' [loplugin:crosscast]
        >     else if (auto pvclxcomponent = dynamic_cast<VCLXAccessibleComponent*>(pAccessible))
        >                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: Iee7585dd2fa0d92af3be6b89d7d08326de3d1e7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145380
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [1f9317e341e1636c869c465e152f41f5c4037386]

        loplugin:reservedid (clang-cl)
        
        ...after ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for
        dynamic_cast on UNO proxy objects" added those
        
        > extern "C" IMAGE_DOS_HEADER const __ImageBase;
        
        Change-Id: I4d9cf2b7617180d66a8527e0e36631f81e0fb18d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145379
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [1e96a295024b6a200afff2065786885ea3b131b4]

        this is never a X11SalBitmap anymore
        
        Change-Id: I9f645128709bce93be1c8548614b5e72e6667844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145292
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Caolán McNamara  <caolanm@redhat.com>  [0f348ba55db9eabe990b5bbeb42d1d94b3b70e79]

        Resolves: tdf#107625 make ctrl+tab act like tab when tab is an input char
        
        Change-Id: Ic3d698920fc94df1adf142e4cbab9725ae45273c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145193
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-12  Tor Lillqvist  <tml@collabora.com>  [743713648e1abc124fc5783f3ea6a20b7d73701d]

        Don't bother building the vcldemo executable for WASM unless using Qt5
        
        Reduces build time a bit.
        
        Sadly, we do need to build soffice.wasm also when not using Qt5,
        because wasm/Makefile.am in online uses its .linkdeps file.
        
        Change-Id: I48f67598050208220e63e3a0ff627f6420ff837f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145353
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-12  Stephan Bergmann  <sbergman@redhat.com>  [941ab8acf0765131fb9d0af560846293f3768d13]

        comphelper::OCommonAccessibleComponent's XAggregation is apparently unused
        
        It had been using WeakAggComponentImplHelper2 ever since
        2f79d5f4794ec7f076bb290702b4c9c0afb2a6c8 "initial checkin - helper for
        implementing an XAccessibleContext", but all the classes that derive from it
        (comphelper::OAccessibleComponentHelper,
        comphelper::OAccessibleExtendedComponentHelper, and classes that in turn derive
        from those) implement queryInterface (in a way not just forwarding to the base
        class queryInterface, as would be required for classes implementing
        XAggregation) rather than queryAggregation, so aggregation was broken and any
        delegator would be ignored when calling queryInterface on one of the derived
        classes.
        
        Also, without this commit but instead with a local
        
        > --- a/include/comphelper/accessiblecomponenthelper.hxx
        > +++ b/include/comphelper/accessiblecomponenthelper.hxx
        > @@ -49,6 +49,7 @@ namespace comphelper
        >                  :public ::cppu::BaseMutex
        >                  ,public OCommonAccessibleComponent_Base
        >      {
        > +        void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
        >          friend class OContextEntryGuard;
        >      private:
        >          css::uno::WeakReference< css::accessibility::XAccessible > m_aCreator;         // the XAccessible which created our XAccessibleContext
        
        on all of Linux, macOS, and Windows: `make check` still succeeded, and running
        the resulting LibreOffice with the system in some assistive technology narration
        mode produced audio, all without hitting that injected assert that should have
        fired if the XAggregation mechanism had been used after all.
        
        Change-Id: I47045824d0762a5f3de150a11576694621b163b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145330
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-12  Miklos Vajna  <vmiklos@collabora.com>  [200e2a3c28bdeec785ac389473f5fca6576071a0]

        sw, UpdateSections: remove not needed StateMethod
        
        SwTextShell::GetState() doesn't handle FN_UPDATE_SECTIONS at the moment,
        so this is unused.
        
        Noticed by Justin at
        <https://gerrit.libreoffice.org/c/core/+/145281/2#message-6b432c5700d3c28284c59e507be378e59859bba2>.
        
        Change-Id: If1a95aa0f1cbe83b42f720421d345a3e12f0b97b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145346
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f65d7fb18c5b850a381727a67c97fc94128082d2]

        tdf#152717: sc: Add UItest
        
        I tried to implement this as a CppUnittest but =DDE formula
        returns nothing
        
        Change-Id: I4649a7842de516fc1867ddd214b323ff77f66317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-12  Miklos Vajna  <vmiklos@collabora.com>  [53603317af854a352e75fd2c5f0f0eeaacc5293c]

        vcl: introduce a BitmapEx::DumpAsPng()
        
        This is mostly useful for ad-hoc debugging, so you don't need to
        manually create an SvFileStream, a vcl::PngImageWriter & connect them,
        but you can step through code in the debugger and call DumpAsPng() at
        random code locations.
        
        The filename type is intentionally a 'const char*', so you can call
        DumpAsPng(0) from gdb; that would not be possible for a 'const
        OUString&' parameter type.
        
        Change-Id: I7e6c9bfe8410892969a1cbd1f827e2d62f409400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [244803ee2bcdfd4c4244f0c8a0654dab25fbc34d]

        tsan:lock-order-inversion in MasterPageObserver
        
        simply the initialisation using a function local static
        
        Change-Id: Ib5b42dccd69e79822b10ab357c357003b35f9d0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [a54172be5a8ec756586fbb5c463364e084aac079]

        tsan:lock-order-inversion in FrameworkHelper
        
        simplify initialisation using a regular mutex, which avoids the global
        mutex and thus a potential lock ordering issue
        
        Change-Id: Ic32afb827aa0b6aae41b8680d7f7329fbe6bc1ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [91c954f53f223bcdcfb33fc3625082f05234e16d]

        tsan:lock-order-inversion in AnimationNode
        
        make -j 24 -rs -f /home/noel/libo-tsan/Makefile.gbuild
        CppunitTest_filter_svg
        [build CUT] filter_svg
        ==================
        WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
        (pid=1138169)
        Cycle in lock order graph: M0 (0x7b0c0043c8c0) => M1 (0x7b0c00459090)
        => M0
        
          Mutex M1 acquired here while holding mutex M0 in main thread:
        /home/noel/llvm-project/compiler-rt/lib/tsan/rtl/../../sanitizer_common/sanitizer_common_interceptors.inc:4481
        (cppunittester+0x9b4c2)
            #1 osl_acquireMutex ??:? (libuno_sal.so.3+0x783ca)
        namespace)::AnimationNode::setParent(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&) animcore.cxx:? (libanimcorelo.so+0x1d34f)
                M1 try to lock
        namespace)::AnimationNode::setParent(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&) animcore.cxx:? (libanimcorelo.so+0x33bf2)
        namespace)::AnimationNode::appendChild(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&) animcore.cxx:? (libanimcorelo.so+0x27312)
                M0 locked
        namespace)::AnimationNode::appendChild(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&) animcore.cxx:? (libanimcorelo.so+0x34d29)
        xmloff::AnimationNodeContext::AnimationNodeContext(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&, SvXMLImport&, int,
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&, std::shared_ptr<xmloff::AnimationsImportHelperImpl> const&)
        animationimport.cxx:? (libxolo.so+0x338060)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) animationimport.cxx:? (libxolo.so+0x33e010)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) ??:? (libxolo.so+0x2ca188)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) ??:? (libxolo.so+0x2cb106)
        namespace)::Event const*) fastparser.cxx:? (libexpwraplo.so+0x4731a)
        sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
        const&) fastparser.cxx:? (libexpwraplo.so+0x407fa)
        sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
        const&) ??:? (libexpwraplo.so+0x48d08)
        const&) ??:? (libxolo.so+0x2c7296)
        SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&)
        ??:? (libxolo.so+0x2c74e2)
        namespace)::ReadThroughComponent(com::sun::star::uno::Reference<com::sun::star::embed::XStorage>
        const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent>
        const&, char const*,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, char const*,
        com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&,
        rtl::OUString const&, bool) sdxmlwrp.cxx:? (libsdlo.so+0x4f2088)
        (libsdlo.so+0x4ef8ed)
            #17 sd::DrawDocShell::Load(SfxMedium&) ??:? (libsdlo.so+0x5bdbeb)
        (libsfxlo.so+0x596b65)
            #19 SfxObjectShell::DoLoad(SfxMedium*) ??:? (libsfxlo.so+0x598732)
        SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libsfxlo.so+0x5e5222)
        SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libsfxlo.so+0x5e6135)
        namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) frmload.cxx:? (libsfxlo.so+0x6ca8fb)
        namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) frmload.cxx:? (libsfxlo.so+0x6cd749)
        (libfwklo.so+0x30000f)
            #25 framework::LoadEnv::start() loadenv.cxx:? (libfwklo.so+0x2fb828)
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&, rtl::OUString const&, int, LoadEnvFeatures) loadenv.cxx:?
        (libfwklo.so+0x2f98d0)
        framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader>
        const&,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, rtl::OUString const&, rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) loadenv.cxx:? (libfwklo.so+0x2f8905)
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libfwklo.so+0x322cbf)
        framework::Desktop::loadComponentFromURL(rtl::OUString const&,
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libfwklo.so+0x322f11)
        rtl::OUString const&,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libunotest.so+0x13f41)
        (libsubsequenttest.so+0x5fc93)
        std::char_traits<char16_t> >, char const*) ??:?
        (libsubsequenttest.so+0x60570)
        (libtest_filter_svg.so+0x161bd)
        
          Mutex M0 acquired here while holding mutex M1 in main thread:
        /home/noel/llvm-project/compiler-rt/lib/tsan/rtl/../../sanitizer_common/sanitizer_common_interceptors.inc:4481
        (cppunittester+0x9b4c2)
            #1 osl_acquireMutex ??:? (libuno_sal.so.3+0x783ca)
        namespace)::AnimationNode::fireChangeListener() animcore.cxx:?
        (libanimcorelo.so+0x3832f)
                M0 try to lock
        namespace)::AnimationNode::fireChangeListener() animcore.cxx:?
        (libanimcorelo.so+0x38814)
        namespace)::AnimationNode::fireChangeListener() animcore.cxx:?
        (libanimcorelo.so+0x38814)
        namespace)::AnimationNode::setParent(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&) animcore.cxx:? (libanimcorelo.so+0x1d514)
        namespace)::AnimationNode::setParent(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>
        const&) animcore.cxx:? (libanimcorelo.so+0x33bf2)
        namespace)::AnimationNode::appendChild(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&) animcore.cxx:? (libanimcorelo.so+0x27312)
                M1 locked
        namespace)::AnimationNode::appendChild(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&) animcore.cxx:? (libanimcorelo.so+0x34d29)
        xmloff::AnimationNodeContext::AnimationNodeContext(com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode>
        const&, SvXMLImport&, int,
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&, std::shared_ptr<xmloff::AnimationsImportHelperImpl> const&)
        animationimport.cxx:? (libxolo.so+0x338060)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) animationimport.cxx:? (libxolo.so+0x33e010)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) ??:? (libxolo.so+0x2ca188)
        com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList>
        const&) ??:? (libxolo.so+0x2cb106)
        namespace)::Event const*) fastparser.cxx:? (libexpwraplo.so+0x4731a)
        sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
        const&) fastparser.cxx:? (libexpwraplo.so+0x407fa)
        sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
        const&) ??:? (libexpwraplo.so+0x48d08)
        const&) ??:? (libxolo.so+0x2c7296)
        SvXMLImport::parseStream(com::sun::star::xml::sax::InputSource const&)
        ??:? (libxolo.so+0x2c74e2)
        namespace)::ReadThroughComponent(com::sun::star::uno::Reference<com::sun::star::embed::XStorage>
        const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent>
        const&, char const*,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, char const*,
        com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&,
        rtl::OUString const&, bool) sdxmlwrp.cxx:? (libsdlo.so+0x4f2088)
        (libsdlo.so+0x4ef8ed)
            #20 sd::DrawDocShell::Load(SfxMedium&) ??:? (libsdlo.so+0x5bdbeb)
        (libsfxlo.so+0x596b65)
            #22 SfxObjectShell::DoLoad(SfxMedium*) ??:? (libsfxlo.so+0x598732)
        SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libsfxlo.so+0x5e5222)
        SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libsfxlo.so+0x5e6135)
        namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) frmload.cxx:? (libsfxlo.so+0x6ca8fb)
        namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&) frmload.cxx:? (libsfxlo.so+0x6cd749)
        (libfwklo.so+0x30000f)
            #28 framework::LoadEnv::start() loadenv.cxx:? (libfwklo.so+0x2fb828)
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&, rtl::OUString const&, int, LoadEnvFeatures) loadenv.cxx:?
        (libfwklo.so+0x2f98d0)
        framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader>
        const&,
        com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>
        const&, rtl::OUString const&, rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) loadenv.cxx:? (libfwklo.so+0x2f8905)
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libfwklo.so+0x322cbf)
        framework::Desktop::loadComponentFromURL(rtl::OUString const&,
        rtl::OUString const&, int,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libfwklo.so+0x322f11)
        rtl::OUString const&,
        com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
        const&) ??:? (libunotest.so+0x13f41)
        
        Change-Id: Iecb3f5c1e553d8f4278c7caf7e81f6cb1f589e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noelgrandin@gmail.com>  [c68606ca09d22caea7c37417d97c076524fecb38]

        maAlphaMask in BitmapEx should be AlphaMask
        
        Change-Id: I12dd1881c2896ab2970a0d149048a36d1aee9c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145243
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [21734247d58a6e915b058d8fa55ece949d049613]

        drop internal support for 1-bit images
        
        on modern hardware, these are less efficient than regular alpha
        channels.
        
        Also, this greatly simplies the range of stuff that vcl needs to deal
        with, which will make the upcoming transparency->alpha patch easier to
        deal with.
        
        Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit
        image.
        
        Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-12  Shulhan  <ms@kilabit.info>  [7f0b6db955ee52f4216416566e108245f2b3a821]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 40580c5dbb5b06fbf402b5864e736527b05cd2f5
          - id: sync dictionaries to version v2.3.0 (2022.09.21)
            
            In the dictionary file we add 15773 new root words, sort them out to
            simplify search and update in the future.
            
            In the affix file we fix some format for Lucene.
            
            The README updated to match with upstream [1].
            
            [1] https://github.com/shuLhan/hunspell-id
            
            Change-Id: Ie96776aba2399b90cfbc113782c720a157458bc3
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/140263
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2023-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [13d30067370353ae5a43c2f2cbd69bb824363815]

        tdf#152425 Synchronize import and export style names mapping
        
        1. Make the mapping in StyleSheetTable::ConvertStyleName match the
           opposite direction mapping happening in MSWordStyles::GetWWId and
           ww::GetEnglishNameFromSti. Add missing styles, provide comments to
           clarify the process and find respective pool format ids.
        2. Instead of appending " (user)" to conflicting style names, which
           is the method used by SwStyleNameMapper to disambiguate API names,
           append " (WW)", which allows to avoid unwanted merging conflicting
           styles.
        
        Change-Id: I47b1c7f570da6e6e21155669fdd1b77de5cc17da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145349
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [319e2e0cbc6a1d25abd01fb27d6250cee825c072]

        tdf#152425 Make Word names unique, and use them for style ids generation
        
        Before, a style id was generated from LibreOffice name, and then the
        name was replaced with Word name. Given that Writer's List N maps to
        Word's List Bullet N, and Word's List N doesn't map to anything in
        Writer, this led to styles.xml having after roundtrip:
        
            <w:style w:type="paragraph" w:styleId="List5">
                <w:name w:val="List Bullet 5"/>
            ...
            <w:style w:type="paragraph" w:styleId="ListBullet5">
                <w:name w:val="List Bullet 5"/>
        
        So the idea is to do the following steps:
        
        1. Collect all the exported styles (unchanged);
        2. Build unique Word names for collected styles (new):
           a. Process all the styles that map to special Word styles first,
              so that their Word names don't get changed when made unique;
           b. Process the rest of the styles, making sure to append a sequential
              number after the Writer name, if a clash happens.
        3. Build Style Ids from the Word names (previously Writer name could be
           used), also making sure they are unique.
        
        Change-Id: I9f8f254aa6ae713671234f0109b94cc72a588150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143905
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-12  Mike Kaganski  <mike.kaganski@collabora.com>  [4ac0a27c7cb0e8d09e701aaf150414d136e58310]

        tdf#152425 Fix order in stiName array
        
        Since their introduction in commit 552d05f57175ecdd0736dc257319bc30aa88d696
        (INTEGRATION: CWS portlaoisefilterteam16 (1.1.2); FILE ADDED, 2003-12-09)
        and commit 9ba054a180fe1fcd410a2887351c2ff1fcb30847 (INTEGRATION: CWS
        portlaoisefilterteam16 (1.1.2); FILE ADDED, 2003-12-09), the enum sti
        and GetStiNames were accidentally not matching each other.
        
        commit 78284714b73a8307174c596295894e8f3951e09a (tdf#76817: fix missing
        heading styles assigned to outline levels in ooxml, 2016-02-04) introduced
        a use of ww::GetEnglishNameFromSti, and since then, the unmatched elements
        started to get written to DOCX styles with wrong names, like
        
            <w:style w:type="paragraph" w:styleId="List5">
                <w:name w:val="List Number"/>
        
        instead of original name "List 5".
        
        Change-Id: I8888b3f117e0b7f57c2dbb90565475d529416c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143828
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-12  Pranam Lashkari  <lpranam@collabora.com>  [92deea6301a02f5530f17263f58402344f82013c]

        sw: rename .uno:UpdateSections command fields
        
        renamed fields name in JSON to be consistent with section insertion and getter
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: Icca0be155542b7dc6df1b29e6c7d4191db8659ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145315
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit cc4f876d05837679caa8c86ffd8be8598b8f429e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145308

2023-01-12  Justin Luth  <justin.luth@collabora.com>  [d07b1cc8148140bd3a78103da668d002b9d266ab]

        Revert "tdf#56258 svx SetOutline: convert to toggle"
        
        This reverts 7.6 commit a9b666b6b839735919923d8911f7e1efe0eb87b0.
        
        This causes too many unexpected things for the user.
        The biggest problem is that it does not join
        the previous list like the other numbering does.
        
        I suppose I could fix that by first calling a UNO
        command that joins/turns on numbering.
        
        However, that is a bit more dangerous with outline,
        since it modifies spacing / numbering on all levels,
        and joining can unexpected skip empty paragraphs etc.
        
        So best to just always treat the button as a dropdown
        to indicate to the user that they are applying an outline change.
        
        For the present I decided to leave the lighted-up
        aspect in place, so show that the outline is in effect.
        
        In terms of removing the list,
        which was the main reason for the change in the first place,
        there are several workarounds. The user has the option
        to go to "more choices" and remove, or select an all-1s choice
        and then remove that. Using the bullets button also is
        an easy option since it seems less restricted than numbering.
        
        The overall risk is no different from before,
        except that it is easier to make those kinds of levels
        now that the outline button is always available on the toolbar.
        
        Change-Id: I64e13f203ae65b2d2b28560ba747ca99d1456578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145240
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-11  Justin Luth  <justin.luth@collabora.com>  [613baf1573757f8af594eda2460076b4eaad7c64]

        svx typo: RelplaceNumRule -> ReplaceNumRule
        
        Change-Id: Ic11fcf35a7b1a6fb15a4046300639622095ed823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145241
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-11  Miklos Vajna  <vmiklos@collabora.com>  [ea208f6004770eb4b81d28e6930cd0c7bd5d8f12]

        sw: add a new .uno:UpdateBookmark UNO command
        
        It is possible to update all bookmarks (having a certain name prefix)
        and their contet, but one can't update the bookmark under the cursor,
        which is needed for Zotero citation clusters.
        
        Fix the problem by adding a new .uno:UpdateBookmark UNO command that can
        update the (innermost) bookmark under the current cursor.
        
        This can be implemented on top of the recently added
        IDocumentMarkAccess::getBookmarkFor().
        
        The UNO command is intentionally hidden from the customize dialog since
        it only makes sense to invoke it from a macro / API with parameters, not
        interactively.
        
        Change-Id: I3e750dfb637f50716be1155a94bc986131b84f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145351
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-11  Tor Lillqvist  <tml@collabora.com>  [67471b3a7fb33884e70e29163b4eddf47fa85115]

        Use gb_EMSCRIPTEN_QTDEFS only when building with Qt5
        
        Move -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE to gb_EMSCRIPTEN_CPPFLAGS.
        
        Change-Id: I435a8482e9d04d9c8218926865738397e2897109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145354
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-11  Eike Rathke  <erack@redhat.com>  [c4cdc2cb3323cbbff42e4410e4b3d0a1d4957504]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f36d8f6aea8b08f63e62a98f8ef76294e7cf7cec
          - Adjust End and Shift+End shortcut description to reality
            
            It's the last column with data in any row, not the last cell with
            data in the current row.
            
            Change-Id: Ib5e719ed6b50c2c5f2b48a8d4cad8bd9f52a3cac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145355
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2023-01-11  Tor Lillqvist  <tml@collabora.com>  [e91663d7a7345eea45c56be99667afae6fa6a0ef]

        Make the "custom widgets" for the notebookbar work in COWASM
        
        Because building for WASM for some reason doesn't use the
        native-code.py approach, we need to duplicate part of what that script
        would produce.
        
        Change-Id: Iecb200b4b0d693914f57f6f73d5025626f15dcf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145283
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-11  Miklos Vajna  <vmiklos@collabora.com>  [4bcb66ec7b417fbe113267f2615e78fe47eb55ca]

        sw lok: expose name of bookmark under cursor
        
        It was possible to get the names of all bookmarks, but you could not get
        the name of the (innermost) bookmark under the current cursor.
        
        Getting the name of the current bookmark is useful for Zotero: if we
        already have a citation and want to insert one more, then we should turn
        the current citation into a citation cluster.
        
        Fix the problem by adding an API similar to what commit
        bb20dee2ef1b0804065e1cda2c834d257fdd90ed (sw lok: expose field type &
        command of fieldmark under cursor, 2023-01-05) did, but here we deal
        with bookmarks, not fieldmarks.
        
        Handle the actual bookmark lookup in MarkManager, such functionality
        looks useful outside LOK as well.
        
        Change-Id: Ic5b9b36fda243c5d7d360fa03745b3e121b67b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145323
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [92d9888e79b768996db5526eb3965259b38ced76]

        fix deadlock observed on jenkins
        
        where we are locking SolarMutex and UndoManagerHelper_Impl::m_aMutex in
        different orders in different code-paths, which is deadly when we call
        into the same class recursively.
        
        Thread 2 (Thread 0x7f5cf303b700 (LWP 22637)):
        (this=0x7f5cf3037cd8) at include/vcl/svapp.hxx:1373
        framework::UndoManagerHelper_Impl::impl_clear() (this=0x5f90d50) at
        framework/source/fwe/helper/undomanagerhelper.cxx:691
          holds UndoManagerHelper_Impl::m_aMutex
          tries to acquire SolarMutex
        framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)::$_3::operator()()
        const (this=0x5519040) at
        framework/source/fwe/helper/undomanagerhelper.cxx:403
        framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)::$_3>::_M_invoke(std::_Any_data
        const&) (__functor=...) at
        /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_function.h:316
        (this=0x5519040) at
        /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_function.h:706
        namespace)::UndoManagerRequest::execute() (this=0x5519030) at
        framework/source/fwe/helper/undomanagerhelper.cxx:160
        framework::UndoManagerHelper_Impl::impl_processRequest(std::function<void
        ()> const&, framework::IMutexGuard&) (this=0x5f90d50, i_request=...,
        i_instanceLock=...) at
        framework/source/fwe/helper/undomanagerhelper.cxx:490
        framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)
        (this=0x5f90d50, i_instanceLock=...) at
        framework/source/fwe/helper/undomanagerhelper.cxx:402
        framework::UndoManagerHelper::clear(framework::IMutexGuard&)
        (this=0x5f90c38, i_instanceLock=...) at
        framework/source/fwe/helper/undomanagerhelper.cxx:999
        at chart2/source/model/main/UndoManager.cxx:278
        void*, _typelib_TypeDescriptionReference*, bool, unsigned long*,
        unsigned int, unsigned long*, double*) (pThis=0x5f90bc8,
        nVtableIndex=18, pRegisterReturn=0x0, pReturnTypeRef=0xa2dac0,
        bSimpleReturn=true, pStack=0x7f5cf30380e0, nStack=0,
        pGPR=0x7f5cf30383e0, pFPR=0x7f5cf30383a0) at
        bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
        cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*,
        bridges::cpp_uno::shared::VtableSlot,
        _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*,
        void*, void**, _uno_Any**) (pThis=0x5e40ac0, aVtableSlot=...,
        pReturnTypeRef=0xa2dac0, nParams=0, pParams=0x0, pUnoReturn=0x0,
        pUnoArgs=0x0, ppUnoExc=0x7f5cf30388e0) at
        bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
        pMemberDescr=0x551dd30, pReturn=0x0, pArgs=0x0,
        ppException=0x7f5cf30388e0) at
        bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
        binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*,
        std::__debug::vector<binaryurp::BinaryAny,
        std::allocator<binaryurp::BinaryAny> >*) const (this=0x28a3cc0,
        returnValue=0x7f5cf3039040, outArguments=0x7f5cf3039008) at
        binaryurp/source/incomingrequest.cxx:236
        (this=0x28a3cc0) at binaryurp/source/incomingrequest.cxx:79
        
        Thread 1 (Thread 0x7f5cfd03eec0 (LWP 22302)):
        (this=0x7ffcdf1b1720, t=...) at include/osl/mutex.hxx:144
        comphelper::OInterfaceContainerHelper3<com::sun::star::util::XModifyListener>::addInterface(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>
        const&) (this=0x5f90da0, rListener=...) at
        include/comphelper/interfacecontainer3.hxx:313
            trying to acquire UndoManagerHelper_Impl::m_aMutex
        framework::UndoManagerHelper_Impl::addModifyListener(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>
        const&) (this=0x5f90d50, i_listener=...) at
        framework/source/fwe/helper/undomanagerhelper.cxx:286
        framework::UndoManagerHelper::addModifyListener(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>
        const&) (this=0x5f90c38, i_listener=...) at
        framework/source/fwe/helper/undomanagerhelper.cxx:1047
        chart::UndoManager::addModifyListener(com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>
        const&) (this=0x5f90bc0, i_listener=...) at
        chart2/source/model/main/UndoManager.cxx:338
        (this=0x1d470d0) at
        chart2/source/controller/main/UndoCommandDispatch.cxx:57
        chart::CommandDispatchContainer::getDispatchForURL(com::sun::star::util::URL
        const&) (this=0x5f66e58, rURL=...) at
        chart2/source/controller/main/CommandDispatchContainer.cxx:93
        chart::ChartController::queryDispatch(com::sun::star::util::URL const&,
        rtl::OUString const&, int) (this=0x5f66c50, rURL=...,
        rTargetFrameName=...) at
        chart2/source/controller/main/ChartController.cxx:1055
            locks SolarMutex
        chart::ChartController::queryDispatch(com::sun::star::util::URL const&,
        rtl::OUString const&, int) () at
        /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/instdir/program/../program/libchartcontrollerlo.so
        framework::DispatchProvider::implts_queryFrameDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XFrame>
        const&, com::sun::star::util::URL const&, rtl::OUString const&, int)
        (this=0x5f5e6c0, xFrame=..., aURL=..., sTargetFrameName=...,
        nSearchFlags=0) at framework/source/dispatch/dispatchprovider.cxx:352
        framework::DispatchProvider::queryDispatch(com::sun::star::util::URL
        const&, rtl::OUString const&, int) (this=0x5f5e6c0, aURL=...,
        sTargetFrameName=..., nSearchFlags=0) at
        framework/source/dispatch/dispatchprovider.cxx:106
        framework::DispatchProvider::queryDispatch(com::sun::star::util::URL
        const&, rtl::OUString const&, int) () at
        /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/instdir/program/libfwklo.so
        framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL
        const&, rtl::OUString const&, int) (this=0x5f59ce0, aURL=...,
        sTargetFrameName=..., nSearchFlags=0) at
        framework/source/dispatch/interceptionhelper.cxx:87
        framework::InterceptionHelper::queryDispatch(com::sun::star::util::URL
        const&, rtl::OUString const&, int) () at
        /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/instdir/program/libfwklo.so
        namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&,
        rtl::OUString const&, int) (this=0x5f599c0, aURL=...,
        sTargetFrameName=..., nSearchFlags=0) at
        framework/source/services/frame.cxx:2329
        namespace)::XFrameImpl::queryDispatch(com::sun::star::util::URL const&,
        rtl::OUString const&, int) () at
        /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/instdir/program/libfwklo.so
        (this=0x5fe8b00) at svtools/source/uno/toolboxcontroller.cxx:520
        (this=0x5fe8b00) at svtools/source/uno/toolboxcontroller.cxx:242
        (this=0x5fdd060) at framework/source/uielement/toolbarmanager.cxx:731
        framework::ToolBarManager::AsyncUpdateControllersHdl(Timer*)
        (this=0x5fdd060) at framework/source/uielement/toolbarmanager.cxx:2298
        framework::ToolBarManager::LinkStubAsyncUpdateControllersHdl(void*,
        Timer*) (instance=0x5fdd060, data=0x5fdd258) at
        framework/source/uielement/toolbarmanager.cxx:2285
        (this=0x5fdd278, data=0x5fdd258) at include/tools/link.hxx:111
        vcl/source/app/timer.cxx:75
        vcl/source/app/scheduler.cxx:474
        vcl/inc/saltimer.hxx:54
        (this=0xa1ab10, bExecuteTimers=true) at vcl/headless/svpinst.cxx:161
        
        Change-Id: I1971d094513cc747eff44db8e2a131ad0aae1506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [e713d1e08345f28d390a1a025768c6a36a1cc59e]

        drop unused X11SalGraphics::GetDitherPixmap
        
        Change-Id: Ib3374242e5edd58ca5a1fa49017a1948e970e144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145291
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [62a8b202782e38b766304b882b14ace80c0d8a8d]

        remove defunct pXRenderFormat field
        
        Change-Id: Id48feeb0738bc89e9ba8580871db6e5fb307bfd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145290
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [99bc5f777cb0af87366aa066a2559582bb9bd7ad]

        drop newly unused code
        
        Change-Id: Ida062a08b656d516cededc9307bccfe8d6e16195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145289
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [158f77b7015fce8a327297736dc11b6a78b9b4d2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e933fe90675132335452d25f4ddb01d0798f3553
          - Fix typo
            
            Change-Id: I437e33f36455f4f9340051fe9d8a74d0f6d88d3e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145332
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-01-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fc6e85d6b7ce1cff3d9ca54173b0f759c61fc4cb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c2c2305d0e47c043696be9a9130b8f585968f764
          - Fix typo
            
            Change-Id: I63f80ef205f901313d4b2c5ec54d7d4864b3cddd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145331
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [6d1ba1877ac1e8d77748b238a7706e3a4f8d9ed4]

        use SvpSalBitmap for X11/gen also
        
        and move bitmap draw/get into CairoCommon and reuse from
        X11CairoSalGraphicsImpl
        
        Change-Id: Ic1faf85b78a298e603279e6d318bab9240d67e77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [cc4c5299c0b2c1b9d92f9cdf88140735519f32f8]

        consider only CAIRO_CONTENT_ALPHA to be 1bit
        
        Change-Id: I0d09207c8131297e9c95c4e146ae62d5dac77be3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145287
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Julien Nabet  <serval2412@yahoo.fr>  [071c66521c6db7136ea7f4606d48ab9fbcc4c71d]

        Fix types for Curl elements (update part)
        
        "CURLOPT_REDIR_PROTOCOLS_STR" has been added with Curl 7.85
        so check if Curl version is 7.85 min or use the previous version "CURLOPT_REDIR_PROTOCOLS"
        
        Change-Id: Iacf6a3c37aba63d615eaa93352b098b1c9183533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145208
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2023-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [0bd3600d9415c10891ea1d90dd598d827d1a9c48]

        tdf#152905 Use "Edit Style" instead of "Modify" for consistency
        
        As discussed in the bug report, the context menu in the "Styles" sidebar is the only place where the string "Modify..." is used to edit a style, whereas other places use "Edit Style...". Hence, let's use it here as well for consistency.
        
        Change-Id: I3244da70873dc62c302baacd614f9ada2cfe5cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145233
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [ef5eed8e85490c2f45700bbc31bff3f729966ab2]

        move GetBitCount into CairoCommon
        
        Change-Id: I1afc900ec10a9a8f5db29400666fcc78d7bc8f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145286
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [6314c6b33dbe29fcba9d92157eaed42772d9c1fc]

        move more unimplemented stubs to X11CairoSalGraphicsImpl
        
        Change-Id: Ic1b4cf481e48e609c9448523e381bd1f304087a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145274
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Miklos Vajna  <vmiklos@collabora.com>  [4a105e03f584b106fa392079dc0573c1806fdaa7]

        CppunitTest_sw_ooxmlexport5: remove unused preTest()
        
        This was added by accident in commit
        a2a2e07996a0e49164663eaec5d79481bf7bb3e0 (sw: split
        CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5, 2022-03-02).
        
        Change-Id: I674e19fb454a82f0232ee828722a556197928d87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145285
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cfb2a587bc59d2a0ff520dd09393f898506055d6]

        rename BitmapEx::GetAlpha to GetAlphaMask
        
        to ease the reading of code related to an upcoming patch to convert
        transparency to alpha, since there is already a GetAlpha in Color.
        
        Change-Id: I1af0f8f6dd94acfe4673c8556c7aff6c20da3f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [b8c66c7f9b25ff88994aef92f56f61f176dc8a6f]

        move getRenderBackendName to X11CairoSalGraphicsImpl
        
        Change-Id: I8f1ff3891623cc8759a9a6146c627c3f14b87a70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [1293656284893209ca174f42d19b2fa72a40117a]

        drop recently unused code
        
        Change-Id: I93e8afc026bf0b12027d70bb0daf81385fb7d99d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145271
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [99240ec736524d1888fc12029851852a21fe2147]

        move unimplemented stubs to X11CairoSalGraphicsImpl
        
        Change-Id: I8fac17a28cd6c399eeb6d80b4d67356b5bd5358e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145270
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Caolán McNamara  <caolanm@redhat.com>  [f4b8dbe9c2d54494f2666df7eaeae19198158b9c]

        reuse CairoCommon copyArea from X11CairoSalGraphicsImpl
        
        Change-Id: I7a238add5daac622219fdfce253d97f30a844e9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145267
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-11  Heiko Tietze  <tietze.heiko@gmail.com>  [95756934cf56e4a9ff58464bc0ed6881c15fe411]

        Resolves tdf#152666 - Hide default styles for large lists
        
        Show the default styles only if the number of items
        are low and hide successively otherwise
        
        Change-Id: Iefafa0cfee7629fb034b9583d7aed7501475a54a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145268
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-11  Miklos Vajna  <vmiklos@collabora.com>  [30f6793baa5529b0594407cd0caaf3a3cde3289c]

        sw: fix FN_UPDATE_TEXT_FORMFIELD typo
        
        A single fieldmark should not be plural.
        
        Change-Id: I5fc1d9fd3a19937c312a25e36bada0c5c4e70e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145277
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-11  wjh-la  <wujiahuan@loongson.cn>  [d3152ea3ae0d6d1bdbc6379c3505812434da6466]

        bridges:Fixed test fail caused by bridges on the loongarch64
        
        Some failed test are caused by the bridges when testing on the
        loongarch64 machine. After adjust the function parameters and return
        value processing according to the characteristics of the loongarch64
        architercture. I tested in version 7.4.3 on the loongarch64 machine, and
        all tests passed.
        
        Change-Id: I9c67287cd7cc89fd79a907afdbffa507bb6052e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144986
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-11  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fbabd959060655a77188447c9fc0112e0ab8474c]

        tdf#124088 - Propose AutoText and shortcut name based on selected text
        
        Change-Id: I55ab9b41a32d7a4e41465f375179997a5c8dd06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145175
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-11  Pranam Lashkari  <lpranam@collabora.com>  [5dd5011eabc755d4ea8d282c32dd4854d532849a]

        sw: return field under cursor inside field node
        
        Having values inside field node makes it easier to detect which commands value
        is being returned in online. otherwise its impossible to predict the command from "type" and "command"
        as "command" can be anything and "type" is very generic
        
        this also makes output more consistent with "GetTextFormFields"
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I1b8b39bfd0de6d7b19c2944bd42f7031d60518af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145295
        Tested-by: Jenkins

2023-01-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d2a27ceece84998c686477ffd2073f3516b568a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6bf263e06de175a10e35bd6ba7ca51a1529812c
          - tdf#152910 Add help page for page numbering wizard
            
            Change-Id: I467f3e49146c9ee4ec133dfb2360bb1d132f18dd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145179
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0afde4cca4046c9478a1c9751ee104495ef18688]

        tdf#152910 (part) add Help button to pagenumberdlg.ui
        
        Core part
        + Added extended tips
        + need HIG review
        
        Change-Id: I15363041041cc771db3ffe89540cfd6c0321bd85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145178
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-01-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [5b3fd1af1247d4096451e5a768c3438fbccec2b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 20d4c17ca1fb161bf5fccf3d94db93b0a4d322f2
          - tdf#152412 Improve the STYLE function help page
            
            This patch creates a separate help page for the STYLE function and improves its text and examples.
            
            Change-Id: I3630fbc99ac822ea138f08283e92d88ffa4acaf8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145299
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [c68d06dfa1498f862923eaddf3e5d247650a53d5]

        sw: add a new .uno:DeleteTextFormFields UNO command
        
        Users sometimes want to "unlink" their citations, which means deleting
        the fieldmarks (if fieldmarks are used to represent citations, e.g.
        with Zotero), which means keeping the field result as-is, but removing
        the field metadata and the actual field start/seprator/end characters.
        
        Do this similar to .uno:TextFormFields, which can do an update of such
        fieldmarks, i.e. add the ability to filter for a certain type and field
        command prefix. This is meant to allow removal af all fieldmark that
        belongs to one one feature, e.g. Zotero.
        
        This is similar to 7765b442e13048f857fd7ee49ced1731caee297e (sw: add a
        new .uno:TextFormFields UNO command, 2022-11-28), but this is about
        deleting (the field commands, not the result), while that was about
        updating.
        
        The same for bookmarks & refmarks are not yet supported.
        
        Change-Id: I02548b030b1822f7b36d3bc5ff9553d728f065c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145272
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-10  László Németh  <nemeth@numbertext.org>  [cec3c719303decd3b811a328fabd71d8c4e5ba3b]

        tdf#146248 sw: fix crash at Undo of hiding page header/footer
        
        When Same content on first page is enabled, Undo could result
        crashing after hiding header/footer with its local menu.
        
        Note: the problem could occur in DOCX more frequently,
        because of special handling of its header/footer,
        see commit f5dc6b11d2218d94c9effe7a1ab418d0133da5e3
        "tdf#140117 sw UI: keep headers/footers when inactive".
        
        Manual test: load the unit test document, delete
        the header with its blue local menu (not with the Page
        Style dialog window!), and press Undo. (The Python
        UITest does the same, but with dispatcher calls).
        
        Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104
        "tdf#141613 sw: fix crash at header/footer undo".
        
        Change-Id: If89d5af2e0d123d6913dfc6a4bea1ddbaf3bd80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145244
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [2ee09316dcd09caf5dd13894de484804d3464172]

        Related: tdf#152950 assert if this arises anywhere else
        
        Change-Id: I29ff145c84fdd784c3b2fbd6e5860dcac42b597d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145262
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [13810281fe1297833a849bf5adea0be8ea77ca88]

        Resolves: tdf#152950 don't set_active while frozen
        
        Change-Id: I7db73e37ed426aae2282a6bf1564e5d3843442cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [4a050ed9e8f5fc0a6df35adfcda5698af1e81d47]

        mpMonoGC is unused
        
        since:
        
        commit 837f171810a95a1d87907dd08d67e969276f0559
        Date:   Thu Oct 1 14:20:31 2015 +0200
        
            loplugin:unusedmethods in vcl
        
        mpMaskGC is also unused.
        
        Change-Id: I4885dacfa1caf31d9943e36881900291ef3e5560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145257
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [cb4cdde132839a232d152b701a147188de8ffc76]

        move invert into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I4fb52ed1a9d6d9405a76f5d06ca0770bf9b750e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145256
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [4a652c4b75c1cde920cd7d13d63b38c5c155be07]

        reuse ROP and XOR solutions
        
        Change-Id: I52ba669921a4145f02c69ff90e0d8668c4698ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145255
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [0774025e1a280d3833e340f6a368a3692cdca2c5]

        cairo_surface_map_to_image giving poor results under gen
        
        for some unknown reason
        
        Change-Id: I6a44b739b7126465e9cf54e31ad4b362badea85d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145254
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [129d4ee902cdc9890c172eb7b91d52b7300ad1e0]

        reorg to share more code more simply
        
        Change-Id: If598a94397a2a04ecd4121d7a532c81ef66b5d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4440f321fcf0157ef52e988dd519d79efd49565b]

        tdf#151846: sw_macros: Add unittest
        
        For that I used the test document from tdf#152732
        
        Change-Id: I19257f4e20a509e6adaf49dd5ea8f180c3feaef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145266
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-10  Eike Rathke  <erack@redhat.com>  [f98d04571c99b70ff753d322b1f43adc8e0433ba]

        Related: tdf#152948 Align AddInMap English names to Add-In implementation
        
        ... of scaddins/source/analysis/analysishelper.cxx for the few (4)
        functions with the _EXCEL2003 suffix. The compiler's symbol map
        for English contained both, but the reverse map contained only the
        (first added) ..._ADD name, so GCD_EXCEL2003() was displayed as
        GCD_ADD(), that still worked but was unexpected.
        
        Change-Id: I8c866dc73d0146d75b29f8212a7e561a3f38fce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145247
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-10  Michael Stahl  <michael.stahl@allotropia.de>  [2bcfb7231b5ca74f02274cfb74ca8463f78905d6]

        tdf#152872 sw: conditionally hide paragraph breaks
        
        Add a 3rd kind of hiding to SwRootFrame and CheckParaRedlineMerge().
        
        This is quite simple as only consecutive paragraphs are merged.
        
        There is an existing similar feature described in
        http://www.openoffice.org/specs/writer/hidden_text/hidden_text.sxw
        which results in 0-height text frames if all text is hidden
        - but that is unconditional, while Word shows the paragraph when
        control chars are shown, and hides it otherwise *iff* its paragraph
        marker is hidden (and there's no page break on it).
        
        Change-Id: I8290962ea58278e17b8f84bf6b2ca4bb2325aa8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145162
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [5b49927760fc4b5f5563a39646e3e5fe23c7fbc5]

        sw doc model xml dump: show section names
        
        The one in SwSectionData seems to the section name visible on the UI.
        SwSectionFormat also has a name, but it looks like even the UI doesn't
        bother with maintaining that on section rename, so that's not really
        used anywhere, and only that was visible in the dump previously.
        
        Change-Id: I9a7444561cee0e42d23eaf06cb4d53171603c0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145259
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-10  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [9be2c049db01233e521e93fb3d09651204447b74]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 08418f863745757cc8074db7addf4812170dc21b
          - tdf#101731: change "Border" to "Transition start" in gradient settings
            
            Change-Id: Ib9803e291e331e7989d904ecc8ebb793bc840baf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145127
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [d8bccf8cbeebe8d5cf9354f3818da795a072899d]

        reorg to make use of X11SalFrame/X11SalVirtualDevice surface
        
        Change-Id: I56ac5181a51aef8f6ae698c14551925847a9f400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145252
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Caolán McNamara  <caolanm@redhat.com>  [c4243e71a59013a5532ae945ffd80f9b13485721]

        move surface into X11SalFrame/X11SalVirtualDevice
        
        Change-Id: I58b97ab074fbd094e931d0bc4a346ba55ee58dd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-10  Aron Budea  <aron.budea@collabora.com>  [0a2b048482e079e4e83307ad00ba7704a4cc815e]

        Make DeepL translator experimental for now
        
        Needs documentation.
        
        Change-Id: If77436a37b5ec40f3eb08a32f0315c1696428c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145184
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b00c1ea3c41aabd47f4965620e60462627f8ed26]

        rename setAlphaFrom->ChangeColorAlpha and fix parameter
        
        The nAlphaTo parameter was actually transparency. Change the
        implementation and the call sites to actually use alpha.
        
        Also remove one of the calls in Graphic::colorChange, because if the
        BitmapEx has no alpha channel, the call was going to do nothing anyway.
        
        Change-Id: I0bf27835b62596ac7c497c8606ceba04fcf859a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-10  Stephan Bergmann  <sbergman@redhat.com>  [f1d00da1bb16330bef9316a3e4f04506f9bb862f]

        OAccessibleImplementationAccess was apparently effectively unused by now
        
        ...as there were no calls to its OAccessibleImplementationAccess::getUnoTunnelId
        so no code apparently made use of that XUnoTunnel
        
        Change-Id: I35d392999f1c28e81f7ff4bf395f63642eb17bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [71a479afb7e9762de930361e6089e23ab8d4af74]

        sw: add a new .uno:UpdateSections command
        
        There was LOK API to insert a new section with provided HTML content and
        to query it, but there was no LOK API to update such created section
        with new names/contents.
        
        This is needed in case Zotero wants to store citations with refmarks, in
        which case it wants to store the bibliography with sections.
        
        Introduce a .uno:UpdateSections UNO command that can do this: the
        sections will be renamed if necessary & the content will be updated. The
        content update is reasonably straightforward, because the section always
        contains at least one empty paragraph, so there is no danger in simply
        deleting the old content before inserting the new one.
        
        This is similar to babba472391d26aed68d7ac31c7a918c08e65256 (sw,
        UpdateFields: add new TypeName, NamePrefix and Fields parameters,
        2023-01-04), but that was for refmarks / citations, this is for sections
        / bibliography.
        
        Change-Id: Idde6d5ed1b0f25f40df502bb6b7e7ca590ef9151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145249
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-10  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [26d74a57d54327b9fd562065d04d867852ce8e8a]

        tdf#103956: RTF import: fix for \cellx0 or no params.
        
        If cell width is not given or zero lets not confuse it with too
        narrow cell. Lets keep zero to allow domain mapper define some
        width.
        
        This patch does not solves autofit issue completely, but finally
        tables with autofit are visible somehow and do not contain cells
        with minimal almost invisible width (41).
        
        Change-Id: I640228ed117f1d65dde9753a00b8403dda45dd40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145148
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [d2318503d559c3797965da777627e4ee45143043]

        sw, UpdateBookmarks: support renaming bookmarks
        
        The problem was that the LOK API client wanted to change the name of the
        bookmark, but nothing happened, because we had a sanity check that made
        sure the provided vs existing bookmark names match.
        
        The intention was that the bookmark name is just an ID (you can store
        additional properties in per-doc custom properties, those can change),
        so we can require that bookmarks never get renamed when using this
        command.
        
        Fix the problem by dropping this requirement and rather use renameMark()
        to adjust the in-doc bookmark name if needed.
        
        This also handles undo/redo for us.
        
        Change-Id: I7a426c865ddf24f13741c0369fb3991da2e881b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145235
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [913b399a73c4d6dfd2c9f5983f56f612f3262fa7]

        vcl ITiledRenderable: rename supportsCommandValues() to supportsCommand()
        
        It gets a single command (to determine if using it with
        getCommandValues() is OK or not), so the plural was confusing, as
        mentioned at
        <https://gerrit.libreoffice.org/c/core/+/145082/5#message-802b1be9194440a3dcee0cad5e54795cbbdea584>.
        
        Change-Id: Idf3c81aadeaeb3d42a50aba2ac58d5ed4278651f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145212
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [2ddd41b420cea7f1b988f0b8acbca564b2811382]

        sw, lok: implement a getCommandValues(Sections)
        
        There was no LOK API to get a list of all sections where the name
        matches a certain prefix.
        
        This is useful in case the API client wants to know what previously
        inserted sections were deleted by the user as part of deleting text
        content.
        
        Add a new getCommandValues(".uno:Sections") that returns the names of
        matching sections. Do not return the section text, assuming that would
        be updated by the API client anyway.
        
        In practice this is needed by Zotero in case it wants to model its
        bibliography items with sections.
        
        Change-Id: If4f02d2a27f2328020934b319d30561aeaaf6612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145207
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-10  Miklos Vajna  <vmiklos@collabora.com>  [42238045c24f51fa1013f4bfe444c31455edda3e]

        sw: document SwGrfExtPage
        
        It's created by SwFrameDlg and this is one of the tabpages which are
        only there for images, not for frames.
        
        Change-Id: I1f3740e683413a2dad2bb124c843b170b45c90e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145242
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-10  Patrick Luby  <plubius@neooffice.org>  [d96c98647511b6c1f1d1d9a969df39f859cc0696]

        tdf#152648 Handle overflow when multiplying rows and columns
        
        Change-Id: I1f3b4853fb6e6a66e74e798d6594342c84d5a695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-10  Justin Luth  <justin.luth@collabora.com>  [894efac210a3871214d95a52c322b0bee40f00ba]

        tdf#56258 i18npool en-US: partial revert 5th outline level
        
        This reverts the change of A.I.a.i. -> A.I.a.i.1.
        made by commit dd8ed1fdbc63499ac958d28536c3c5540455358b.
        
        While it wasn't necessarily a bad change, it no longer has
        any justification, since the complementary change in the
        other outline definition was modified to become MLA compliant.
        
        Rather than make any change at all, just revert back to the
        original definition, and leave the level definition to the
        normal 4 levels of numbering before the bullets start.
        
        Change-Id: I88d792a6dd20bd519755349905975cf9028f9fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145236
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-10  Justin Luth  <justin.luth@collabora.com>  [9993ccab05dd95dd0de0dc74fc72e5aee8a8cb61]

        tdf#56258 i18npool en-US: extend outline 1.a) to 4 levels
        
        Change 1. a) -> 1) a) 1) A)
        
        This is intended as a clean, modern style of outline
        that has good visual spacing in LibreOffice.
        
        This differentiates it a bit more from the first option,
        and extends the numbered level to the typical depth of 4,
        while still keeping a logical suffix pattern
        and maintaining the general "theme" of the previous definition.
        
        Yes, it is a bit odd to have a capital A following
        a smaller case a. However, this is at the fourth
        level, which isn't reached very often,
        and I wanted to keep a choice that focuses on a small a.
        
        Surprisingly, with the default 12pt/Liberation font, a
        10) still fits in the allotted space before the tabstop,
        so in most cases this outline will have proper visual spacing
        all the way up to 99).
        
        There are plenty of choices that start with 1 followed by a dot,
        so I used this opportunity to create the only list
        that starts with a ")" suffix. Google docs for example has a
        1) a) i) choice, but for modern lists I don't think
        we want to use roman numerals.
        
        Change-Id: I34725d6aa113831eaeaa88c295b3b3f1294f8998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145155
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-10  Eike Rathke  <erack@redhat.com>  [b5cca905c6f3e090dae6e649381664925474a04a]

        Resolves: tdf#152948 Do not use GetExcelName() to obtain English function name
        
        As the function name says, it's the Excel compatibility name and
        not the Calc UI visible name and thus does not have the _ADD or
        _EXCEL2003 suffixes. Theoretically the names may even be
        completely different.
        
        Change-Id: I5f52dee77009123ebc3762defe08c937a3a59a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145246
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-09  Miklos Vajna  <vmiklos@collabora.com>  [d24fc94281458b57368ff4fef1fe1182dadbea72]

        sw: prefix members of ListLevelsEnumWrapper, ListTemplatesEnumWrapper, ...
        
        ... SwVbaListLevel and SwVbaListLevels
        
        See tdf#94879 for motivation.
        
        Change-Id: I8f3b88b71ba2696179e2f48c9c6e66f5fc947553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145187
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [3c7cba927bb5d234d6d72f65e063754590a7b584]

        tdf#152917: basic_macros: Add unittest
        
        Change-Id: I69050ae0e6607ed4a1d1da0e89b45125e2c06e3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145190
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2023-01-09  Stephan Bergmann  <sbergman@redhat.com>  [9cc91e17172709c65742c092d3f312bce48ac6d9]

        loplugin:fakebool
        
        Change-Id: Idf69f13c3e8ab94ac04d83c9a0d171cddc399a10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145213
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-09  Miklos Vajna  <vmiklos@collabora.com>  [8336c61ba059551cb74df5ec53d2b45a3cf41814]

        sw: document FN_UPDATE_TEXT_FORMFIELD and FN_UPDATE_TEXT_FORMFIELDS
        
        If you don't read the commit message or the code, it wasn't really
        obvious that FN_UPDATE_TEXT_FORMFIELD works based on the current cursor.
        
        Change-Id: Icd8bc856e5d50b995fa92559c873a50b48b98ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145189
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-09  Stephan Bergmann  <sbergman@redhat.com>  [a58abb4296c50228ebd5510e50363072e9a96774]

        Clean up VCLXAccessibleComponent::getAccessibleParent
        
        ...after 21e0d8162a0e683558c4d042ce688fc9a6833809 "loplugin:unusedfields" had
        dropped the base class
        OAccessibleImplementationAccess::implGetForeignControlledParent
        
        Change-Id: I753aad41baaa0ac1d1f7eb0a6084993df5a58d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145197
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-09  Justin Luth  <justin.luth@collabora.com>  [2570eb7265fbae840bf9f2d83463b0bee09beaef]

        tdf#56258 i18npool en-US: document ISO 2145 compliant outline list format
        
        Change-Id: I2cccc7c2c3621434a4dbbcdd032672c668632494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145158
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-09  Justin Luth  <justin.luth@collabora.com>  [5297528b85652d3f5a85e75ff6bcb406ba9b34d3]

        tdf#56258 i18npool en-US: replace illogical outline 1.(a).i.A
        
        Change 1.(a).i.A. -> A.1.a.1.
        
        This is intended as a clean, modern style of outline
        that has good visual spacing in LibreOffice.
        
        It provides a simple alternative to the second style,
        reversing the order while still keeping a logical suffix pattern.
        
        This design will easily allow large/long lists
        to fit in the allotted space before the tabstop.
        
        There was no attempt to match the theme of the
        previous definition, since it neither looked
        good in LO's default spacing, nor was it consistent/logical.
        
        Change-Id: If7de1302110a3c97922bd2eeba7a917444110b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145156
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2023-01-09  Justin Luth  <justin.luth@collabora.com>  [c3964de14cb14099b49e1c55370a5f98e773e03d]

        tdf#56258 i18npool en-US: change outline order to match MLA style
        
        Changed I.A.i.a) -> I.A.1.a.i.
        
        The overwhelming result of a google search for
        "official/correct outline list format"
        indicates that the third level should be a 1, not an i.
        
        MLA Handbook (according to wikipedia) uses the order
        I.A.1.a.i. (a) (1) i)
        
        Chicago Mode of Style is usually interpreted as
        I.A.1.a) or I.A.1.a. with varying lower sublevels/suffixes.
        
        Wikipedia also suggest the logical order of
        I.A.1.a.i.I) A) 1) a) i) (I) (A) (1) (a) (i)
        
        Change-Id: I7fcc8a1ee727d6cddca4bf0c6a8461538769cf5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145147
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-09  Szymon Kłos  <szymon.klos@collabora.com>  [aff880740311e37740b8b0231bb7a7947ad922d7]

        jsdialog: don't export collapsed/expanded icons when empty
        
        Change-Id: Iec56c11fdba066f9b62b2d5d56ad011a821e4087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145040
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145066
        Tested-by: Jenkins

2023-01-09  Miklos Vajna  <vmiklos@collabora.com>  [dd775cd630c907bc7d8bcd6f57ffd3f66115a5ba]

        sw, .uno:InsertSection: add a new Content parameter and accept HTML there
        
        When Zotero uses refmarks to represent citations, then a section is used
        for the bibliography. While it was possible to insert refmarks with a
        given name & content, inserting a section with a provided HTML content
        was not possible.
        
        A section (and not a refmark) is needed for the bibliography, as a
        refmark is a text attribute, so it must start and end in the same
        paragraph.
        
        Fix this by adding a new, optional Content parameter to
        .uno:InsertSection, which allows providing multi-paragraph, formatted
        text.
        
        This is somewhat similar to what commit
        fa82e151d80d15eeb6dfae434f1dbb3b68907188 (sw, .uno:InsertBookmark: add a
        new BookmarkText parameter and accept HTML there, 2022-12-06) did for
        the bookmark case.
        
        Change-Id: I0ccbc8a765fed4e019783d0b743c1cd2d0596093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145188
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-09  Szymon Kłos  <szymon.klos@collabora.com>  [60f6b0e363a4bb38f249a26609a4fc219b001c87]

        jsdialog: dump stock images id in TreeView
        
        Change-Id: I11342e1d7963a7e4d1ef139f504fc44dd6c89d90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144223
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145065
        Tested-by: Jenkins

2023-01-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [9c6aa7f2918819af670c6d6ed25645c725c91667]

        tdf#152531 Fix background color of Dialog Editor in dark mode
        
        Change-Id: I7006ff472dae5ce8d4b52c108f742c3c6d9b0b61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144603
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [522b3ce2eefa3401a857bcd8076d7cd57faee801]

        Update git submodules
        
        * Update translations from branch 'master'
          to fd1416ef15091d8b08ea7dbad77148e68e4d89f9
          - update translations for 7.5.0 rc2 / master
            
            and force-fix errors using pocheck
            
            Change-Id: Ia0f91e00129cb802164fd4323b3072cf8a76cb5c
            
2023-01-09  Julien Nabet  <serval2412@yahoo.fr>  [6410fafc6f4d58062d82f86549303f4ae2eec32a]

        Fix deprecated Curl elements for update part
        
        Change-Id: Ide008c8a80800b33c8104ec3d697e836fae73827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145186
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-09  Pranam Lashkari  <lpranam@collabora.com>  [e65b27e79f177d27131479c46d089cad33df557b]

        sw, UpdateFields: update in sorted order
        
        This was using the order used by GetItemSurrogates() which can be hard to predict
        
        So it used to update field in uncertain ways
        
        Now it updates field in order of the fields in file
        
        Change-Id: I7fc39b476cae6ed6a7fb7186803d4205832d7a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145167
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 83f5340538d8aa8c469de3fee6012e83f8b56317)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145129
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [71cd508c068e662f06b984810d68868787223ab1]

        Fix typo
        
        Change-Id: Iccacf0e31153f31d2f61de27e28db6074a9d3eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145191
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-09  Bogdan B  <buzea.bogdan@libreoffice.org>  [3dbaeb2edffa7147fde02643f527c5d71465af37]

        tdf#143977 Consistent hide/show in Toolbars
        
        Change-Id: I022699498480a0d1bb3eb2a7fb0a972779feef03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142194
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-09  Leonid Ryzhov  <leoryzhov@gmail.com>  [1b44a4c558fdf597bf66c1c671248ca58e145e9e]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: Ia325af8d9a23e617eb62e6cecab0aa68f1d206f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145089
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-09  offtkp  <parisoplop@gmail.com>  [2dd45d5d81afdd5c550b9929dde42ac04d9dd176]

        Fix wrong version in comment
        
        Change-Id: I4185b019b8dbce7de9bf853c0416fd43201b1f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144987
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-09  offtkp  <parisoplop@gmail.com>  [5e5631a8f6a9b14ab7f088f61f4780948c41761d]

        Add comment for new class
        
        Change-Id: Icb20bfc68183bd22d1d83985bf3932fd2918b074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145166
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-09  Caolán McNamara  <caolanm@redhat.com>  [72a08a55791a1c17c0ec15b2ab5c7294c23e2831]

        tdf#152931 deref of moPenColor std::optional on launching writer
        
        Change-Id: I13cb7aade5b4a0142e23bd62e62d2160c73d8740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145180
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-09  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [555f4333182abd0ca4aa06b354763f6dfbc3eb20]

        use std::this_thread::sleep_for instead of osl equivalent
        
        Change-Id: I5b4edc5417e5bb5e082688df616e1d5735717d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142357
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-09  Stephan Bergmann  <sbergman@redhat.com>  [42d9077fc4ffc35d769412a979d91e836adb2536]

        Missing include
        
        ...as reported at
        <https://lists.freedesktop.org/archives/libreoffice/2023-January/089788.html>
        "boost 1.81 breaks libetonyek and gtv-calc-header-bar.cxx",
        
        > /home/etna/Tmpbuild/libreoffice/libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx:36:25: error: implicit instantiation of undefined template 'std::vector<(anonymous namespace)::GtvCalcHeaderBarPrivateImpl::Header>'
        >     std::vector<Header> m_aHeaders;
        >                         ^
        > /home/etna/Runtime/BuildSystem/LLVM13WithWASM/bin/../include/c++/v1/iosfwd:251:28: note: template is declared here
        > class _LIBCPP_TEMPLATE_VIS vector;
        >                            ^
        
        Change-Id: I6cc93195147979a5bf2785faf4bb0e71a9fd4a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145185
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-09  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [788cc6ff3b186ceb8f265e53b5482f808f6536f4]

        tdf#148578: Do not apply table shift for RTF
        
        Table shift based on cell lect margin should be applied
        for DOCX (earlier compat options) but not actual for RTF.
        
        Maybe earlier RTF version did behave this way, but nowadays
        this behavior does not match MS Word 365.
        
        Change-Id: Icdc4fa6298167fe5f263c85164d7c4c4176be25f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145088
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-01-09  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [8ae84bb5566e12df64236a116b9d1889d6f5f052]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3b49a858d147035096a9e1cbc4967c87db9f42c
          - Typo grab bag
            
            Change-Id: I705b56ac8fd84227aaa6a81e57d182dfd797bd62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145183
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-01-08  Julien Nabet  <serval2412@yahoo.fr>  [5c4fa7ddb0b12d30304bbc6119a0aa1d3d65b55d]

        Fix deprecated Curl elements for minidump part
        
        Change-Id: I43df411eed24e86f5d72982b5d24188e0cb7e507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145177
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a9a90f92eec3375f85b3c4dcadc44e3dc2fe7dac]

        Fix typo
        
        Change-Id: I5dd29c8b3d899f8a889c364dc5c20026e6495259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145176
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-08  Stanislav Horacek  <stanislav.horacek@gmail.com>  [b4dc43b6d01d85802d5674c3a27789d6354e39a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc494d3f21dd9aeb475a2cec95948b058c4696c5
          - remove redundant tag
            
            Change-Id: I9f0838ad3b230d454abc2810ce83033945339805
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145174
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-08  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [3babbc31bf4bba35924c25c5fbd59e1c314d3627]

        Revert "Resolves tdf#143100 - Disable cell style commands when sheet is protected"
        
        This reverts commit a3cb71ac80c0c2971e97c033d212cf4e464fa8f0.
        
        Reason for revert: tdf#149857
        
        Change-Id: I5ea780b986073a8db16d5dc2ea503aa30da7ef27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145118
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-08  Heiko Tietze  <tietze.heiko@gmail.com>  [e37f06f534ac864f9fe8cd20b07a85c36e697d41]

        Resolves tdf#139141 - Make variable date/time field the default
        
        Switched the fixed and variable/current field
        See also I18136feebed225f7645b6869d3600ee78f945bfb and
        I56f42b4ce104dbb96d8fda1bc71af727fa46d536
        
        Change-Id: Id885c09410dc9aecc9570c8d3b7750e9d69e9c9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145170
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-08  Stanislav Horacek  <stanislav.horacek@gmail.com>  [9b5c342121e8cc2d05569f7339bd32e9c8133938]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 34e1fdb87700f1541ca5b15e3e3cfcd0dc5c2e98
          - do not localize source code
            
            Change-Id: I00c8b6014be077f78485e43cbe0f86f2c2f29c6c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145173
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2023-01-07  Eike Rathke  <erack@redhat.com>  [e06198e1544f33419be4ce303458da8b5160bc1a]

        Resolves: tdf#152917 Add ConvertFromUrl() put result back, tdf#147132 follow-up
        
        Regression from
        
            commit 6b3e66cd7a355061bf1dec76bbc4f389b6b60f2d
            CommitDate: Mon Sep 5 16:04:25 2022 +0200
        
                tdf147132 basic : flaten some functions
        
        Change-Id: I20e6b00ed613b98a5e58623a010d894b1bcb4c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145172
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-07  Jim Raykowski  <raykowj@gmail.com>  [156fd06dbca2fcca3246dba964a58a7ef698cf21]

        Outline folding: Fix cursor position after undo redo
        
        This patch makes the cursor position to be the same after undo redo as
        when outline folding is not active.
        
        Change-Id: I9e1f827455afb2675f3085c1560b1e2a246f4524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144873
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2023-01-07  Caolán McNamara  <caolanm@redhat.com>  [34791b203fdf5f571189f82510fd4a2d02008bd4]

        cid#1518911 Uninitialized scalar variable
        
        Change-Id: Ieef6bf8cd20907531301ab8cf6d81d2dcd5397a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-07  Noel Grandin  <noelgrandin@gmail.com>  [4ddfdeefe78e725b8d28fd60dbe32e7f4f054724]

        remove dead code
        
        we already know the IsAlpha is true from the outer if condition
        
        Change-Id: I627a9b952cb63154baf773b6162b422de4f253bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-07  Caolán McNamara  <caolanm@redhat.com>  [2a8660c6d36a2015c37c65b6bc21c6decd96cf8e]

        Related: rhbz#2158548 allow longer words for hunspell-ko
        
        https://github.com/hunspell/hunspell/issues/903
        
        A problem since the sanity check added in:
        
        commit 05e44e069e4cfaa9ce1264bf13f23fc9abd7ed05
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Sep 1 13:46:40 2022 +0100
        
            Check word limit (#813)
        
            * check against hentry blen max
        
        Change-Id: Iab2c062584da076260c3262537690435eae7f396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145154
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-07  Caolán McNamara  <caolanm@redhat.com>  [ab2a44f81bf5035fe85f3fb7494a910a75055041]

        ofz#54567 Out-of-memory
        
        Change-Id: If7a3f75aea614bf136049efc9d04ff404acbb170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-07  Caolán McNamara  <caolanm@redhat.com>  [8ddb962846020d1534454fdeea628bb72d92ba40]

        ofz#54707 Integer-overflow
        
        Change-Id: I3b448ed2752bfbffa2f38db3fe0d4099b9f83b2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145164
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-07  Caolán McNamara  <caolanm@redhat.com>  [b3566864db77effddb243717dd0d9a1c791383e6]

        move drawRect into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I1d9f1dc96788530eb6a226a53a67764918348100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b348b9467111d47b0e995dcbec4951cd1c249e4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2154d8b47552c60c458e78f806a241dce721cbc5
          - Highlight cursor position on opening text documents
            
            (after a facebook LO support group query).
            
            Change-Id: I5d3f25e4190d3d26cb08cb697b65922df617034e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145143
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eafe84de3788e8d5c063c429ac9ace35f4cd7b74]

        Add content control dialogs to screenshot list
        
        Change-Id: I9469bd17a1db3443b1241a47989c8fa6892974e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145163
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2023-01-07  Eike Rathke  <erack@redhat.com>  [54d25b36c0bf3dcc715f2098ad658bb113e868ec]

        Related: tdf#152781 Pin some known on-the-fly langtags to user-defined LCIDs
        
        These are pulled in by either our own bundled extension
        dictionaries (es-*, ca-*), or hunspell dictionary (en-AG), but
        have no language listbox entry (and don't need one until someone
        insists) thus are generated.
        
        So if selected and in case stored in binary MS file formats ensure
        a stable back-and-forth conversion. The on-the-fly 0x7e1, 0x7e2,
        ... are generated arbitrarily in order as encountered.
        
        Change-Id: I0dc72bf1301b26d5b82e1b271c58fc77c82eea0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145161
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [5a1ddc1a92a7883597ab7d825408a1f0adc2ec6e]

        curl: upgrade to release 7.87.0
        
        Fixes CVE-2022-43551 and CVE-2022-43552.
        
        https://curl.se/docs/CVE-2022-43551.html
        https://curl.se/docs/CVE-2022-43552.html
        
        Change-Id: I979ed11c212aef226ad9f26420462e5f9dbe15e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144885
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [f41966222f05ab327550dc7a5cf9ad40052124b3]

        openssl3: add patch for CVE-2022-3996
        
        Severity: Low
        
        backport <https://github.com/openssl/openssl/commit/7725e7bfe6f2ce8146b6552b44e0d226be7638e7>.
        
        OpenSSL 1.1.1 series are not affected by this vulnerability.
        
        Security Advisary: https://www.openssl.org/news/secadv/20221213.txt
        
        Change-Id: I42caba9c51291445fa96fc6f2280c681d6d6e582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Stephan Bergmann  <sbergman@redhat.com>  [ec98e7769048d44c6d274e3edcac19d5cbc74348]

        Merge comphelper::OAccessibleContextHelper into comphelper::OCommonAccessibleComponent
        
        Change-Id: I586ae8fe2842fd879ae2ae506c659d06dda16843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145160
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-06  Stephan Bergmann  <sbergman@redhat.com>  [a2e0d46ec556382140069fe473d6e0018e1d2881]

        Fix copy/paste typos
        
        ...apparently introduced in 4883fd31141c3598b25a123033297f847cd18552 "weld
        ScTabBgColorDlg" and 3e078e17ee2144fb976a7e6b9227152113cea0d4 "weld
        SfxTemplateManagerDlg", resp.
        
        Change-Id: I08dd6df262d12bc844a992d6e13b9732860e74bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145159
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-06  Regina Henschel  <rb.henschel@t-online.de>  [81e6d47635656297cdddc9030f4422c0bcc203f9]

        tdf#152896 do not apply color shading twice
        
        If a character theme color is shaded, Word writes this as w:themeShade
        attribute of the w:color element. If the character also has
        transparency, Word writes an additional w14:textFill element with
        a w14:lumMod child element. In such cases the w14:textFill element
        supersedes the w:color element.
        
        The initial implementation of Fontwork import in commit
        cbf30153a5c776e6d1ee26f2f83c8f77503eceb9 does it wrong. It replaces the
        color itself but not the color transformation, so that the shading was
        applied twice, once from w:themeShade attribute and the other time from
        w14:lumMod.
        
        The solution here is to reverse the order so that w:color is only
        evaluated if w14:textFill is not present. Another solution would have
        been to clear the color transformation vector before adding the values
        from w14:textFill. I use reverse order here because it more clearly
        reflects that w14:textFill supersedes w:color.
        
        Change-Id: I3e700795167a34238ea619b9c4a691c10da357f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145150
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2eefb695c0bfd00abd22e17e64ab2a1692fe2af4]

        Fix typos
        
        Change-Id: Ia565446bab6436940954bc1af10f612cb9a9ad9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145152
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fba845287d1734dd0d4ce2e4a69800441a973b05]

        Fix typo
        
        Change-Id: I403ff69c912abb2d62290b4b2067655763e0823c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145153
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-06  Julien Nabet  <serval2412@yahoo.fr>  [5effc24969e5f326ef094419631d14d4d3030ed6]

        tdf#152900: "Create new field as primary key" disabled...
        
        when pasting data as new table
        
        Regression from 3f8e50f9b2fb35db190ce0204981f3f02d1d5ae6 (05/2021)
        "merge handlers into single toggle handler"
        
        Change-Id: I05376f288c1687978225bd98da21a5e21810292a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145151
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [a6fe91f6e3ddbad65e534907d29243b138258f6c]

        move drawPolygon into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: Ifb7514a72f7bc3a65f7f1ad51707405b1a2bd127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145137
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [7e07225a1b48f3f987a818213256d3cbb9266d87]

        SDPR: Overhauled D2DRenderer to use sal::systools::COMReference
        
        All stuff used from MS with names starting with ID2D1* is COM
        API stuff, so referenced and interface-based. I thought about
        making this more safe since a while (shared/unique_ptr, ...)
        but found no good way to do it.
        Also did not want to use CComPtr from MS and expand the devenv
        we need on win, so was short before doing an own small smartptr
        class. Luckily I asked sberg and he pointed me to the already
        existing sal::systools::COMReference which exactly does what
        I need here - thanks!
        Unluckily I now had to change a lot of code - sigh. I wish
        I had known earlier :-/
        This change contains the renderer completely adapted to using
        that much safer and better ressource control.
        Plus I added (even more) comments to try to make more clear
        in many plasces what's going on, what is done and why.
        
        Change-Id: Ia2aa3223d0e5f7ec6569cde176cec1fadcd921dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145142
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [6cabd7d9bfed37799a344f872d5f8fcf3214116a]

        tdf#56258 i18npool: add "adjust" to locale.dtd for outline numbering
        
        Although Adjust was already defined in all of the code structures,
        it was not defined in the dtd file.
        Thanks to Eike for pointing out this requirement.
        
        Change-Id: I43ed0c26ed5bccb2309a255db79f5afa32f78c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145146
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [498f0208f55a5b9ce8a130c940ddfcb9c36d6ff9]

        move drawPolyLine into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I141b12c99825c67e4698d53633a1fa720cc487be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e8d18b471ea5063bc0b2c94afc1b94017e8e66bc]

        tdf#152784: RTF import: more default paragraph params
        
        If numbering is not explicitly mentioned in para properties
        it should not be used from referred paragraph style. So
        default value of 0 (no numbering) is used by default.
        
        Change-Id: If8e8f2aaf19190f64a557444188f67b24a699b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144839
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-06  Miklos Vajna  <vmiklos@collabora.com>  [5a2ee5ba893b6b8f4e7fd6623b7f10faf0bda509]

        sw lok: get all refmarks: sort the refmarks array
        
        This was using the order used by GetItemSurrogates(), which is mostly by
        pointer address.
        
        We know that these pool items have a text attribute, which have a node
        and a content index, sort by that.
        
        In theory two refmark may start at the same doc model position, but
        that's never the case when using Zotero, so don't worry about that for
        now.
        
        For a document with 5 refmarks, the original order I got was 2-3-5-4-1,
        now it's property 1-2-3-4-5.
        
        Change-Id: I2768845414bd36afca91ec02a0f3364c246ddfd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145145
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-06  Heiko Tietze  <tietze.heiko@gmail.com>  [660b7ed484efcac1e5b841e0b04f3c9628578448]

        Resolves tdf#101731 - Rename Border/Midpoint
        
        Follow up to Icda875d3c6f03ffd29395ac5ce932475cc629361
        changing "Midpoint" (formerly "Border") to "Transition start".
        Using the same name for transparency.
        
        Change-Id: I1f1c53ee357a9ead94100156598f43a0ac021d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145141
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [89b1d41e0d2cd16a4088e095de0f673807c4adac]

        use std::optional for SALCOLOR_NONE
        
        instead of re-using an actual real color value, because it will totally
        not work when I convert vcl to use alpha instead of transparency
        
        Change-Id: I01f043e0b65ffd852989dfe28f2b9d5a43c9c3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-06  Miklos Vajna  <vmiklos@collabora.com>  [337416dafb66ed8f930d2d69e83fae438fc85f3c]

        sw: add a new .uno:UpdateTextFormField UNO command
        
        It is possible to update all fieldsmarks (of a certion type, of a
        certain field command prefix), but one can't update the fieldmark under
        the cursor, which is needed for Zotero citation clusters.
        
        To make this more complex, insertion inside an existing fieldmark is
        explicitly not wanted, see commit
        a178a2ac6df8dc63a7ab8d4a19b90ae8a17baca4 (sw UI: fix crash on inserting
        a fieldmark inside a fieldmark, 2023-01-02).
        
        Fix the problem by adding a new .uno:UpdateTextFormField UNO command
        that can update the (innermost) fieldmark under the current cursor.
        
        The uno command is intentionally hidden from the customize dialog since
        it only makes sense to invoke it from a macro / API with parameters, not
        interactively.
        
        Change-Id: I46fc4f701a20839945d765eb13aec7362ab83788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145135
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-06  László Németh  <nemeth@numbertext.org>  [cfcd5aa6898654ad3b469ee23f2b27eef5e4a565]

        tdf#65535 sw spellDialog.py: fix lo-upsan build
        
        Lo-upsan build didn't replace the bad word in the test,
        maybe because of dictionary or timer problems. Skip
        testing the (here: sometimes missing) text changes,
        keep only testing of the remaining comment, which was
        the target of the original fix.
        
        This reverts commit d2614337e8291b9b6d114fda5ae914f6940c353a
        "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build"
        and commit 81163c384364e4b5c99392b76f027f8c2b87c259
        "tdf#65535 sw spellDialog.py: fix lo-upsan build better".
        
        Change-Id: Ib5faa4e02bf6dd085d6666748ae76f67b4e07497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145138
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [d6c54b3d4ee757958f9040a84dfbde0ab25f59bf]

        android: Enable checksum verification for gradle download
        
        Follow the F-Droid Bot suggestion in [1] and set the checksum
        from [2] in gradle-wrapper.properties, so a downloaded gradle
        distribution will be verified against that, s. doc at [3].
        
        Command used from within the `android/source` directory:
        
            ./gradlew wrapper --distribution-type all --gradle-distribution-sha256-sum cd5c2958a107ee7f0722004a12d0f8559b4564c34daad7df06cffd4d12a426d0
        
        Note that this is the checksum for the gradle distribution,
        not the gradle wrapper (which is mentioned in
        Change-Id I3f466061aba55c5704fe251eee7e8c73f7d316aa instead.)
        
        Also note that Android Studio does not fully support
        the "distributionSha256Sum" attribute and requires
        confirming in a message saying so that the checksum is correct
        before syncing the project, s. [4].
        
        [1] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12380#note_1229239229
        [2] https://downloads.gradle-dn.com/distributions/gradle-7.4-all.zip.sha256
        [3] https://docs.gradle.org/current/userguide/gradle_wrapper.html#configuring_checksum_verification
        [4] https://issuetracker.google.com/issues/129261435#comment11
        
        Change-Id: I39902be79e7dad2ad006262efe3b6c6ab3b5de5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145105
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [4a0dc0d63a204f7ed03b48debd439e0e81f1dfac]

        android: Update gradle wrapper to 7.4
        
        Commit the result of running
        
            ./gradlew wrapper --distribution-type all --gradle-version 7.4
        
        from within the `android/source` directory as described at [1].
        
        Double-check that the sha256sum of the jar file matches what is listed on the
        website [2] for v7.4:
        
            $ sha256sum gradle/wrapper/gradle-wrapper.jar
            575098db54a998ff1c6770b352c3b16766c09848bee7555dab09afc34e8cf590  gradle/wrapper/gradle-wrapper.jar
        
        (Interestingly, the sha256sum of the gradle-wrapper.jar
        used so far, e2b82129ab64751fd40437007bd2f7f2afb3c6e41a9198e628650b22d5824a14,
        is not the one of any listed versions there, which is what
        the F-Droid bot marked as error in a MR to update LibreOffice Viewer [3]).
        
        [1] https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper
        [2] https://gradle.org/release-checksums/
        [3] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/12380#note_1229239229
        
        Change-Id: I3f466061aba55c5704fe251eee7e8c73f7d316aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145098
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [1bac4efd7c468179e7530546e1e4ee2ae1e4de54]

        move drawPolyPolygon into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I8eee16f10f4241ced467e2bf73e518d066f9508d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145111
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [9eeacdd6cd5fa4ad0d29b530a627f398be763cc2]

        adjust bodge to be only for CAIRO_CONTENT_ALPHA
        
        rather than specifically !CAIRO_CONTENT_COLOR_ALPHA
        
        Change-Id: I2b86feb8499b98e750e954c4b246d4c8bc3ef7cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145110
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [ded5e68a58ae4837918e1a381d0c46cd69f7a06a]

        move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        2nd attempt. This reverts commit 8d0b7bdb8c9ae8254e5b77b533a158734affc4f5.
        
        Change-Id: I8901a1258e0b0d89170f4e056516c5211801456a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145109
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [1fd19c798243ee46606331ad96b9803b96581a2e]

        use current known geometry for surface size instead of SAL_MAX_INT16
        
        which appears to be why getPixel failed
        
        Change-Id: I088ed0c01bdd0e9971ff52a1f70a030f0921e497
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145108
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  Caolán McNamara  <caolanm@redhat.com>  [e8effd1c4c0a4dd389054d311f432c42f26a3a6b]

        Revert "move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImpl"
        
        This reverts commit 00b62877fa2f900d1c2dcf7b721f7a956408f8a0.
        
        XIOError seen with vcldemo
        
        Change-Id: Id75497f8148964372beaed9432ee6097ec8afc47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145076
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-06  offtkp  <parisoplop@gmail.com>  [c010b5d2b2cdb22f48ef9d2b9d1fdc6125e1fec2]

        tdf#86630 sw: Add one-step page number insertion wizard
        
        Add a one-step wizard for easy insertion of the page number to the
        header/footer.
        
        Change-Id: Idb33c92d594e04d9256460fe414e4b10e5166af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144683
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-06  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [d7514d34b67626ba0b7d1dc0e9acbdfc635fe0ac]

        Revert "Relates tdf#139141 - Make variable date/time field the default"
        
        This reverts commit b2c81dad3a0b72d305f1c6967ee4a8069ae11b45.
        
        Reason for revert: tdf#152871
        
        Change-Id: I56f42b4ce104dbb96d8fda1bc71af727fa46d536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145007
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2023-01-06  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [f011a13b3e9d3edf85fa8cb17d612934e589e672]

        writerfilter: removed remains of GAP_HALF define and its usage
        
        Change-Id: I8dee16f923686f557c8213d9a7870392bd5fe9bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145090
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2023-01-06  Miklos Vajna  <vmiklos@collabora.com>  [72fc34cdf8e2a3d4fa3a2de9a8a96f33aa19dbc4]

        sw doc model xml dump: show name of refmarks
        
        Unlike bookmarks, these are not tracked in the mark manager.
        
        Change-Id: I17b10dac6b74a738fd47cf25b84a7156031f01da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145103
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8538fec8e87bf6aa08a4b4e192d7d97dc7faf482]

        Removed executable permission on source file
        
        Change-Id: Ida56746e5f2442ceff86e19cf52467dc766a95ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145113
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eefc323cd592c7958b13062e3f08e105d24055b1]

        Fix typo
        
        Change-Id: Ie90862c12a441ddf0b325baee920b91704b05e77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145112
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [710017981194c33ac1ba1acc439f92b87869f532]

        tdf#56258: allow i18npool to define SvxAdjust for outline
        
        Deciding whether the numbering should be Left, Right, or Center
        is a rather important setting. Specifically for Roman numerals
        (which grow very wide as they increment to 7 and 8)
        the numbering styles set these to right aligned.
        This really helps for keeping the text nicely aligned.
        
        The numbering styles are built-in LO defaults,
        but locale files can define numbering and outline
        choices. This patch add the setting for "adjust" on
        the outline levels.
        
        For en_US, it makes sense to right-align roman numeral levels.
        [The only other highly likely candidate for this that I could find
         was old Hungarian (SZEKELY_ROVAS),  but it doesn't seem
         to be used in any locale definitions.]
        
        I only changed en_US for now, but of course many other
        locales are also using NumType="3" and NumType="4".
        
        This only applies to the toolbar/sidebar SVX code path.
        The Bullets and Numbering dialog does not currently
        modify any spacing, so I didn't apply the adjustment either.
        
        It also doesn't make sense to do this on single numbering changes
        (aka ContinuousNumberingLevels or LC_NumberingLevel)
        because we don't know or control the first line indent there either.
        
        But at least for toolbar Outlines, we do change every level,
        and so can set a (somewhat) appropriate spacing.
        [Setting SvxAdjust without adjusting the spacing
         is pointless. Don't make any changes at all if
         the spacing ends up causing problems.]
        
        The Numbering IVX/ivx styles set the firstLineIndent to -174,
        so I did the same here. This is the scariest part of this change.
        
        AFAICS SvxAdjust::Left is a non-locale aDefNumStyle default,
        so hardcoding that for undefined LC_OutlineNumberingLevel
        shouldn't be too scary.
        
        Change-Id: I52deefe88aa55c55c9531b651411f64accb86f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144978
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-06  Regina Henschel  <rb.henschel@t-online.de>  [585f65738270ba8ab2fdc4c49063c3b5663fe768]

        tdf#152884 import alpha too for schemeClr
        
        Without fix the alpha child element was only read for w14:srgbClr but
        no for w14:schemeClr. Thus character colored by theme color had no
        transparency.
        
        Change-Id: I73c01b7142d3eab83400d2e5eb9dce01ff8d4a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145099
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [3fd0b4053763aa91b0004c523e96e7d390c7b58e]

        tdf#56258 sw toolbar: show SetOutline by default
        
        Because I am making improvements to SetOutline,
        it should be in good enough shape to display it to the general public.
        
        If the improvements don't land, or are not considered good enough,
        then this patch can simply be reverted.
        I have no intention of backporting this.
        
        Change-Id: If2a4926d136086b3ae2d17d157b5a4642d88561e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145097
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [a9b666b6b839735919923d8911f7e1efe0eb87b0]

        tdf#56258 svx SetOutline: convert to toggle
        
        The "Outline Format" toolbar button is normally hidden.
        It didn't check state like the bullet and toggle numbering do.
        This patch adds that - so it lights up when the text
        contains a numbering list that matches a valid outline choice.
        
        I also added a toggle aspect to the button.
        
        Toggling ON is not great. It works fine if there is no
        numbering yet, but if you are in an outline and toggle off,
        it won't toggle back on to the same list - it starts a new one.
        I don't think there is much that can be done about that,
        since the removal delete the level information too,
        and outlines are all about multiple levels of numbering.
        The proper response to an errant
        toggle off is (multiple) undo(s), not toggle back on.
        (In the ideal world, it would popup the dropdown choices).
        
        Toggling ON does nothing when there are already bullets
        or numbering. The proper response is to use the dropdown
        if the desire is to change to an outline format.
        
        Toggling OFF is only possible when we are on a valid outline.
        This is extremely important because otherwise it isn't clear
        how to remove Outline Numbering's mix of bullets and numbers.
        (When the selection contains one list
        with both bullet and number levels,
        the number and bullet buttons do nothing.)
        
        Although not perfect, this is not a bad user experience,
        so I'm going to push the full patch to gerrit.
        
        There is one known obscure case that troubles all methods.
        If the selection spans multiple list definitions and ends
        on an un-numbered paragraph, then the toggle-on will happen.
        
        It is possible to just not do any toggling
        and ALWAYS show the dropdown action,
        but that isn't very consistent with the other related buttons.
        
        Change-Id: I6d927604e49711f1da8549be9f3dbf8b8133a06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145061
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [c0eb37dfd00311518926bd602ccc8776f89b397c]

        tdf#115965 tdf#148790 sw toolbar: no need for RemoveBullet
        
        The existing buttons for bullets and number lists are already
        toggles. Having a separate button to remove them is almost
        completely pointless.
        
        Change-Id: I11314a152848a9ff32eb01e2eb36bd145f890622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145096
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-06  Justin Luth  <justin.luth@collabora.com>  [9a16cef6f40e59d92d1bb297f40d78dfb2bb6345]

        tdf#115965 sw RemoveBullet: do not light-up button when NumRule
        
        Sure, most of the time it was "off" when there was either a
        bullet or a number list. However, when the selection had
        both a bullet and a number list/level, then it would light up.
        So just make it simple. If there is a numrule in the selection,
        then it shouldn't be "on".
        
        There is still one obscure case it lights up funny.
        If more than one list is selected, and the selection ends
        on a non-numbered paragraph, then RemoveBullet
        will still light up - as if there is no numbering in the selection.
        
        Change-Id: I5c37d53206918068b2994fde9774541ea988a623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145095
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-05  Justin Luth  <justin.luth@collabora.com>  [dd8ed1fdbc63499ac958d28536c3c5540455358b]

        tdf#56258 en_US: increase outline levels definitions to 6
        
        There are 10 levels in numbering,
        so it only makes sense to allow
        outline definitions for all 10 levels.
        
        Note that DOC/X formats only allow 9 levels,
        
        There are two code paths that read these definitions.
        The SVX toolbar code to allow 10 levels (SVX_MAX_NUM)
        was already completed in the previous patch.
        This commit allows 10 levels for the
        Bullets and Numbering menu dialog.
        
        Since all choices MUST define the same number of levels,
        I only added one more. I hope that there isn't some secret
        kind of requirement that ALL LOCALE's must also use
        the same number of definitions - it doesn't seem to.
        [Although not a direct comparison, bg_BG defines 10
         single number levels, compared to en_US's 8,
         and some Chinese locales also do more than 8.]
        
        Change-Id: Ibe00d54cfa4577db83eba368b92be11055b076ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144976
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-05  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [3ab8349a37215d8e355e79b93d66f631144e7c57]

        sc : use std::mutex for CharClass initialisation
        
        Change-Id: I0427109da1bfed1d3d467455ab1ab3c68569f60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144886
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-05  offtkp  <parisoplop@gmail.com>  [9817a03e03988b86050c0fe0e4cd4cca476f172f]

        Change variable name from rData to pData
        
        Change-Id: Ied27e34b35a22b1f2a7521fb58035170651b1ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144001
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2023-01-05  Eike Rathke  <erack@redhat.com>  [375630ae76f46c096421dfadee8d37b406bc10c5]

        Related: tdf#152781 Stab the 0xE40A {es} vs Latin America quirk
        
        First, the LANGUAGE_SPANISH_LATIN_AMERICA 0xE40A is not a MS
        system LCID, it is Spanish 0x00a with sublanguage 0x39 => user
        defined (in the range 0x20 to 0x3f). Meanwhile MS reserved 0x580A
        for {es-419}, so obsolete the legacy 0xE40A definition and replace
        with 0x580A when encountered.
        
        Second, due to the legacy plain {es} mapping being present, an
        encountered 'es' (from our bundled dictionary extension) got
        mapped to 0xE40A instead of 0xA and thus was added to the
        character language listbox (that otherwise suppresses LCIDs
        without sublanguage), resulting in a "Spanish {es}" entry.
        
        Besides, it's currently not clear how to actually proceed with
        such dictionary situation when, for example, both 'es-ES' and 'es'
        dictionaries are present and the 'es' dictionary apparently is
        meant as base and contains entries the 'es-ES' does not or 'es-ES'
        overrides entries. It might be it's handled half-way in
        linguistics, but maybe not even that, I didn't investigate.
        
        Change-Id: Id859731ba5efa65d4a6de429b7f52027aa69327c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145093
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-05  Patrick Luby  <plubius@neooffice.org>  [2d1a0d86d2d0c00fcfee61c39f2221e786e4245b]

        Related: tdf#152703 Prevent possible hang when live resizing a window
        
        Application::Reschedule() can potentially display a modal dialog which
        will cause a hang so temporarily disable live resize by clampiing the
        window's minimum and maximum sizes to the current frame size which in
        Application::Reschedule().
        
        Also, eliminate flickering during live resizing of a window when using
        Skia/Metal. When in live resize, the SkiaSalGraphicsImpl class does not
        detect that the window size has changed until after the flush has been
        called so call checkSurface() to recreate the SkSurface if needed before
        flushing. Flushing had to be moved during [self windowDidResize:] to eliminate
        flicker. Flushing in [self displayIfNeeded] does not eliminate flicker so
        apparently [self windowDidResize:] is called earlier.
        
        Change-Id: Id3de838d2e17fee85cb583b6c4e862b571d47142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145053
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-05  Michael Stahl  <michael.stahl@allotropia.de>  [e5b5d9c8d33b1dd87e5a50856ad02f21df59dc5b]

        tdf#152710 xmloff: ignore exception in XMLChangedRegionImportContext
        
        The xOldCursor must be restored in all cases.
        
        Also XMLParaContext triggers an exception which ends up aborting the
        import.
        
        Change-Id: I8f4785e0e9bde4c8c484954a4d66f3b82d6ca28c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145094
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-05  Michael Stahl  <michael.stahl@allotropia.de>  [475e59d29b7a6cc7f058af8ff863b3bb1a2a84a5]

        tdf#152710 sw: call and fix DeleteSection() instead
        
        Turns out there's a function to delete a complete nodes array section -
        and it has the same problem?  Why does it move indexes only from
        startnode + 1?  Let's try to fix it to be more consistent.
        
        Change-Id: Iedacc10e29c1646c4ccc85e53a479b0351f5cfcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145078
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-05  Michael Stahl  <michael.stahl@allotropia.de>  [8e05bdd26f21fc304978ff3b454cf355841ec75f]

        tdf#152710 sw: invalidate SwUnoCursors properly in DeleteRangeImpl()
        
        This crashes with:
        
         list.cxx:44: corrupt document structure, bailing out of infinite loop
         ndtxt.cxx:5437: void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint&): Assertion `dynamic_cast<SwTextFormatColl const*>(static_cast<const SwFormatChg*>(pOldValue)->pChangedFormat)' failed.
        
        Because the redline from 7 to 9 is deleted, but then some cursor ends up
        on node 10 which is invalid as it is an end node.
        
        [   6] 0x60666a0            StartNode ,
        [   7]  0x61195e0           StartNode ,
        [   8]   0x61197a8           TextNode "tainment",
        [   9]  0x6119670             EndNode ,
        [  10] 0x6066730              EndNode ,
        
        The first problem is that DeleteRangeImpl() uses the point node as the
        target position for PaMCorrAbs(), but in this case the point node will
        be deleted.
        
        PaMCorrAbs() has a check to invalidate SwUnoCursors that would be moved
        out of their parent sections, but due to the first problem it can't
        check it, and the second problem is that lcl_FindUnoCursorSection()
        doesn't work on redline sections, as those have node type
        SwNormalStartNode.
        
        After fixing the invalidation, subsequent access to the SwXTextCursor
        throws exceptions and importing the file fails.
        
        (regression from commit 477e489e71b4a96ff10d9f2d2b802d91dec3e319)
        
        Thanks to Dave Gilbert for identifying the problematic DeleteRange()
        call.
        
        Change-Id: I48a373cc122073b82bc47513fdae684f45b0efb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145077
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2023-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d6dcc749f2dafe6a66f43524bb0bfe7491546ad]

        Fix typos
        
        Change-Id: I49ca0e4e05420a4992acc348a3dc6e3533f4d30e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144618
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [22b7f83edd8a4aa4702b63e7183b371175d3810a]

        Removed executable bits from source files
        
        Change-Id: Ib9fbfc8d52bfddc6af65bf62af3c49767868e032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144952
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [77108bf6a6a5e59eb8cf972e614edd90d24d1bdc]

        Fix typo
        
        Change-Id: I963f340e0da9a0e7bc50bd1ee8c73f28c8edb6de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145101
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [083b9c5a0c4c426d472fd319e179757145f4e46e]

        Fix typo
        
        Change-Id: I6a15118c9e0b686c7157a162990b7776362865f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145100
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-05  Miklos Vajna  <vmiklos@collabora.com>  [f83c1353b94fc7dec79d05ac45c11f40f497261d]

        sw: UpdateFieldContents: fix typos
        
        - The function name itself had a typo, spotted at
          <https://gerrit.libreoffice.org/c/core/+/145036/2#message-d8cb4de7de483866e0c86c8919cdf47f84b6037e>.
        
        - Also, if the # of provided fields and # of fields we find in the
          document don't match, we can give up, so no need to continue, the same
          condition would fail again, anyway.
        
        Change-Id: Ifbf7f60c86f469697056975752efc9d130287099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145083
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-05  Noel Grandin  <noelgrandin@gmail.com>  [0461eb7564236b8a427fe677658705e9955a8d13]

        flatten some code in vcl
        
        Change-Id: I29638408d60bfa02609ed58839829ed51d319e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a8d3b8985a79c216c3c132fb2e6bb0f85a27831a]

        tdf#56973 - Copy/paste (single) sheet is checked but not enabled
        
        Enable the "copy" radio button in the move/copy sheet dialog, if there is just a single sheet in a spreadsheet document. Otherwise, users get the impression that a single sheet cannot be copied because the "copy" radio button is selected but not enabled, i.e., greyed out.
        
        Change-Id: Icf98973585491b0c8c9a74aad3900f6cc2895d11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145064
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2023-01-05  Jean-Pierre Ledure  <jp@ledure.be>  [88a67c50af61fa9ee5fa677589ce5db2039d6f2e]

        ScriptForge - (SFDocuments) new FormDocument service
        
        The SF_FormDocument service is focused on :
        - The orchestration of Base form documents
          (aka Base Forms, but this is confusing)
          and the identification of and the access to their controls.
        - Form documents are always contained in a Base document.
        
        A form document may be opened either:
        - via code or user interface from the Base file welcome page
        - via code only, without having its Base container opened first
        In any mode, a form document can be opened only in 1 single copy.
        
        The FormDocument service is triggered either by
            base.OpenFormDocument(...)
            database.OpenFormDocument(...)
                ' Base file may be closed
            ui.GetDocument(...)
        
        Specific methods:
            CloseDocument()
            Forms()
            GetDatabase()
            PrintOut()
        Next methods are inherited from the Document superclass:
            Activate()
            CreateMenu(), RemoveMenu()
            ExportAsPdf()
            RunCommand()
            SaveCopyAs()
            SetPrinter()
        
        As a consequence, next methods remain available
        but should be declared as deprecated in the help:
            base.CloseFormDocument()
            base.Forms()
            base.PrintOut()
            base.SetPrinter()
        
        Above changes have several more minor impacts :
        - beside IsCalc, IsWriter, ... , a new IsFormDocument property
        - the UI service identifies open form documents
        - a new service means a new entry to register
          in the Services catalog
        - management of form events has been reviewed
        - the connection between Base, FormDocument, Form
          and Database services is reinforced
        - menus were available on components, now also on sub-components
        
        The new service is available for both Basic and Python user scripts.
        It requires in the help
            - a new sf_formdocument page
            - a review of the sf_base, sf_database, sf_form, sf_ui pages
        
        Change-Id: Ib06d1c4565ca093af2f068fa5b8082082641752e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145080
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2023-01-05  Miklos Vajna  <vmiklos@collabora.com>  [b4c3291630610d38270d7d8ccda5f810b3e05d63]

        sw XHTML export: avoid sdnum and sdval attributes on table cells
        
        These are not valid in XHTML, as the reqif validator points it out:
        
        ERROR at 239: [XSD] cvc-complex-type.3.2.2: Attribute 'sdval' is not allowed to appear in element 'td'.
        ERROR at 239: [XSD] cvc-complex-type.3.2.2: Attribute 'sdnum' is not allowed to appear in element 'td'.
        
        The actual cell contents is already there, so just omit this unwanted
        metadata in the XHTML case.
        
        Change-Id: I68804dd2ce45b0579287aeccbb550b174859f7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145081
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-05  László Németh  <nemeth@numbertext.org>  [81163c384364e4b5c99392b76f027f8c2b87c259]

        tdf#65535 sw spellDialog.py: fix lo-upsan build better
        
        Follow-up to commit d2614337e8291b9b6d114fda5ae914f6940c353a
        "tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build".
        
        Change-Id: Ibb7e5e4afe1cab99fc24342afb94458f612ec3f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145073
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-05  László Németh  <nemeth@numbertext.org>  [e17b4df3fe5441ca66e4203c725a578eb1797eb2]

        tdf#131203 DOCX import: fix lost table when w:tblGrid is missing
        
        Load tables in case of incomplete text table definition, i.e.
        missing w:tblGrid and its w:gridCol elements, like MSO does.
        
        Note: Apache POI, and maybe old MSO versions generated such DOCX documents.
        
        divide_by_zero() was thrown from 975884fbbc3f80a634258ee562037688a42027a9
        "ofz#7110 ensure join is called on std::exceptions as well as uno::Exception".
        
        See also commit 9279b0bb5397d0520b727ab0d271f328807c8749
        "writerfilter: avoid divide by zero" and
        commit 116cadb5d2582532c69677a2f8499e8e9b7b9b80
        "tdf#59274 DOCX import: fix tables with incomplete grid".
        
        Change-Id: I991807da13e22e551f81c3fb60580be7a9c0fb50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145069
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5eda5ef2530e0e2d4f9e7f33f1ab1a8fa933fe7f]

        Fix typo
        
        Change-Id: Icde32c862bb498af0908399b388973db4d7f8b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145074
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-05  Miklos Vajna  <vmiklos@collabora.com>  [471804e251b4e15b37a10920bd4b88b40f97b227]

        sw update of refmarks: fix handling of ignored refmarks
        
        As pointed out at
        <https://gerrit.libreoffice.org/c/core/+/145036/1#message-165c0282ace92160592c896c6867095d3558ee96>,
        it's not correct that UpdateFieldConents() uses a single index into both
        the provided fields/refmarks array and into the document's all refmarks
        array.
        
        We need a new index that counts the input fields/refmarks we got and
        which is not incremented for ignored refmarks.
        
        Extend the testcase to have 2 paragraphs in the document: the first
        paragraph has a refmark that is to be ignored and the second para has a
        refmark that is interesting to us. This makes the test fail.
        
        Then fix up UpdateFieldConents() to properly count how we iterate
        through all refmarks and the provided refmarks in parallel.
        
        Change-Id: I1fabf5b29beeabe9e8a126f1662ca8830e5c4e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145068
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-05  Stephan Bergmann  <sbergman@redhat.com>  [19691c3b6878c1ea09f8bcd53224341c40c9847b]

        Revert all the recent loplugin:unocast changes
        
        ...as obsoleted by ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support
        for dynamic_cast on UNO proxy objects".
        
        This reverts all of:
        4cfcc9ac37b90ce64c8402a41eb4638adb185b5c "loplugin:unocast (framework::Desktop)"
        03efbf72f4ddf7a84aa8aabef348331bd4b75e8a "loplugin:unocast
         (vclcanvas::TextLayout)"
        80099fdd51a69eaa6c36ca88ef772810e4a777fa "loplugin:unocast (SalGtkXWindow)"
        cc147f576d8687fb79c77d47d41dc4ba1678a469 "loplugin:unocast
         (sdext::presenter::CachablePresenterView)"
        40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2 "loplugin:unocast
         (vclcanvas::CanvasFont)"
        2d1e7995eae29e2826449eb5179f5fae181794a5 "loplugin:unocast (CairoColorSpace)"
        4c0bbe4bd97636207cf71a6aa120c67698891da9 "loplugin:unocast
         (canvas::ParametricPolyPolygon)"
        89803666621c07d1b1ac9d3bd883f0ca192a91a0 "loplugin:unocast
         (vclcanas::CanvasBitmap)"
        d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04 "loplugin:unocast
         (sfx2::DigitalSignatures)"
        c0c4519e0d5b555f59bbc04cc616454edfd1f4ce "loplugin:unocast
         (VCLXAccessibleComponent)"
        feb8b833a6245d42400f42a0bc789dc84594ee6f "loplugin:unocast (VCLXDialog)"
        1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66 "loplugin:unocast (VCLXMultiPage)"
        f481f036deb1b1b46f3038074c4659f3a91b9c6c "loplugin:unocast
         (DocumentSettingsSerializer)"
        73df933f5fa5932f94e5a1b338a3eda00a9ce354 "loplugin:unocast
         (css::embed::EmbeddedUpdate)"
        420165ab0ef03c0467f9d17f504de2d2fc78f0e6 "loplugin:unocast
         (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)"
        9abe8ee067e6c00f19d8a13346d53c4641c27166 "loplugin:unocast (MutableTreeNode)"
        9f3022ceb036f23b4b0994c3e2fbd1001bff225a "loplugin:unocast (VCLXTabPage)"
        1be70dda02c12a60778b7607cff2520ae1aa611e "loplugin:unocast
         (vcl::unotools::VclCanvasBitmap)"
        d6a70bb641b96e8e5616448c2378131ed62658b4 "loplugin:unocast
         (basegfx::unotools::UnoPolyPolygon)"
        5a14f009e6782c077463c8cbb8e9cea3d7950107 "loplugin:unocast
         (xmlsecurity::Certificate)"
        99009c9535dfa3e0d838989ccc7d84bfa2320ff4 "loplugin:unocast (sd::Annotation)"
        0c7585c5fa78887e5459885ed744e8044fd76137 "loplugin:unocast (sd::TextApiObject)"
        24e14afd1bfcaed6c200ab081973fba7e47267ca "loplugin:unocast
         (SignatureVerifierImpl)"
        1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4 "loplugin:unocast
         (pcr::PropertyEventTranslation)"
        a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b "loplugin:unocast (RangePageBreaks)"
        19dfdf86ad1f5b08041d8b7a9f196caf881231ab "iloplugin:unocast
         (pcr::OFormattedNumericControl)"
        f9785ea595fd8e911f6370e836fa579225b9e571 "loplugin:unocast
         (frm::OInterfaceContainer)"
        5e5f40a4a92a31b0932c690219d002fcf18598cf "loplugin:unocast (ScVbaShapes)"
        27b35b2c215b4832d4378ec3a7ecbba926552d06 "loplugin:unocast (ScVbaShapeRange)"
        cb3108f860065928552a86cf8acc4b3a95718ecf "cid#1517812 Dereference null return
         value"
        feba0ddb1521d1142560fe54b7d7696ee910237f "loplugin:unocast
         (weld::TransportAsXWindow)"
        4d6c23216559eb48f9943bb49d6e475a6d64ba15 "loplugin:unocast
         (oox::ForumlaImExportBase)"
        4844c096a8ab6a9a620c410a0949d4499f12a504 "loplugin:unocast
         (cairocanvas::SurfaceProvider)"
        9a0b523e0a84d403b9092176ccec4b3e3efe42d0 "loplugin:unocast
         (cairocanvas::CanvasBitmap)"
        8a5648d8e59b4b007dbbf3824777c19a21efc61e "loplugin:unocast
         (cairocanvas::TextLayout)"
        28c27a0623bc78a0590858f97d03b620985bc84c "loplugin:unocast
         (cairocanvas::CanvasFont)"
        53bc223cb3288e32a417696ee61c29e5f01f209d "loplugin:unocast
         (cairocanvas::RepaintTarget)"
        5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec "loplugin:unocast (SvXMLImport)"
        068187a898cdd2e26e9b16c348ecc1ed2dee3f29 "loplugin:unocast (VCLXWindow)"
        88b4f966202717cd4ad38a30a8eda22c3e69ed35 "loplugin:unocast
         (sfx2::sidebar::SidebarController)"
        f1b7a69b280aefe2f1b3b0f32193494fd765f2bd "loplugin:unocast
         (SvxLineStyleToolBoxControl)"
        ba76f0ba7e8de4d2953739c952004b7d9af47197 "loplugin:unocast
         (i18npool::Calendar_gregorian)"
        840154daf934d8df52ead1cb7acd798c4d30f007 "loplugin:unocast
         (framework::AddonsToolBarWrapper)"
        b0e9c4c5f063cefa9557810e3349bdb9c7493091 "loplugin:unocast
         (GrammarCheckingIterator)"
        8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac "loplugin:unocast
         (ucb::ucp::ext::Content)"
        5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a "loplugin:unocast
         (basic::SfxScriptLibraryContainer)"
        9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad "loplugin:unocast
         (sdext::presenter::PresenterNotesView)"
        a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d "loplugin:unocast
         (SelectionChangeHandler)"
        c0b59ad6e35b0cb0dea0821e95f95569739078c1 "Consistently use
         comphelper::getSomethingImpl<I>(aIdentifier, this)"
        276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c "loplugin:unocast
         (vclcanvas::RepaintTarget)"
        
        Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [00b62877fa2f900d1c2dcf7b721f7a956408f8a0]

        move getPixel into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I5401cc87ec228d52d98fc65840f875cfb55e30c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145052
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [39038ed8dac3d896d261a76e11f9004f7d68f989]

        move drawPixel into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I0638403ab54039793e851583937b09674f05c36d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145051
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [d6ded494dbb781d5539ab44fa8765eaf16275688]

        move drawLine into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I6c667b4aa64c49ad18b7e9a2cd6cc43228369bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145050
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [4818e7d8d5b99cc9f74985572c113a10f0bbae3b]

        move hasFastDrawTransformedBitmap into CairoCommon and reuse
        
        Change-Id: I5c70f657fe885da54caf9514bdddf868e9cf8c1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145029
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [6effda72259243dab5d3bbe619b2f10244b55164]

        move drawAlphaRect into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: Ic9155117dd8586db5738cd7a620818af8bb28f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145028
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [fa0ecf2a61c24c6485693d81ff820693f21a5ec8]

        move drawGradient into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I249afbc4cf6318fd9ed42fef0a2aa71d1a76d9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145024
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Caolán McNamara  <caolanm@redhat.com>  [8549d6e26f5116b1fcf5e066252cc987a3f2574f]

        Related: tdf#150687 check autocorr DocumentList.xml at build time
        
        to ensure no noopt entries exist
        
        Change-Id: I9fb95e211d6030e1f551558fd5a0a3ca700c8fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-05  Michael Weghorn  <m.weghorn@posteo.de>  [8ecc8ebf2b94615928449f431884525b605fbfa5]

        external/icu: Fix intermittent cross build failure
        
        The ICU build for Android sometimes failed
        as follows:
        
        > ICU for C/C++ 72.1 is ready to be built.
        > === Important Notes: ===
        > Data Packaging: static
        >  This means: ICU data will be stored in a static library.
        >  To locate data: ICU will use the linked data library. If linked with the stub library located in stubdata/, the application can use udata_setCommonData() or set a data path to override.
        > Building ICU: Use a GNU make such as /usr/bin/gmake to build ICU.
        > checking the version of "/usr/bin/gmake"... gmake[2]: Entering directory '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/UnpackedTarball/icu/source'
        > 4.3 (we wanted at least 3.80)
        > gmake[2]: Leaving directory '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/UnpackedTarball/icu/source'
        > ok
        > ## Note: you have disabled ICU's tools. This ICU cannot build its own data or tests.
        > ## Expect build failures in the 'data', 'test', and other directories.
        > icudefs.mk:328: @cross_mixed_buildroot@/config/icucross.mk: No such file or directory
        > make[2]: *** No rule to make target '@cross_mixed_buildroot@/config/icucross.mk'.  Stop.
        > make[1]: *** [/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/external/icu/ExternalProject_icu.mk:68: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/workdir/ExternalProject/icu/build] Error 1
        > make: *** [Makefile:289: build] Error 2
        
        config.log showed that instead of the
        `cross_mixed_buildroot` and `cross_unix_buildroot`
        configure variables introduced instead of
        `cross_buildroot` in
        
            commit 7f16cabf00daa30e9284d2fb2494bd341352c25e
            Date:   Thu Oct 1 11:20:50 2020 +0200
        
                icu: fix Windows Cygwin cross build
        
        , only the latter was set.
        
        While that commit also added a call to autoconf
        to update `configure` from the patched `configure.ac`,
        autoconf would leave the old version in place if
        the timestamp of `configure` was newer than that of
        `configure.ac` after unpacking the tarball.
        
        Call autoconf with the `-f` param to force the update.
        
        Do the same for another autoconf invocation that was
        added in
        
            commit 6c94958e56fcbacb8e1f689550a60034b074857c
            Date:   Fri Jul 17 22:25:01 2020 +0200
        
                icu: fix Windows Arm64 build
        
        Change-Id: I5685ebce13e2950a4dc8f1dec75c4aed18d584f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145043
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-05  Regina Henschel  <rb.henschel@t-online.de>  [f4a568fc0553603fbf05477e0942af4e8466fba0]

        tdf#152840 add ST_ThemeColor values to ClrScheme::getColor
        
        ... and Color::getSchemeColorIndex().
        
        Without the fix it was not in all cases detected, that a theme color
        was used, so the FillColorTheme or the CharColorTheme property had got
        value '-1'. In case of WordArt in docx import, the color could not be
        determined and the text was black.
        
        Change-Id: I81cdb22d6b3c30bf9923b9069ba2e384ac5b3a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145021
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2023-01-05  Miklos Vajna  <vmiklos@collabora.com>  [bb20dee2ef1b0804065e1cda2c834d257fdd90ed]

        sw lok: expose field type & command of fieldmark under cursor
        
        It was possible to get the properties of all fieldmarks, but you could
        not get the properties of the fieldmark under the current cursor.
        
        Getting the properties of the current fieldmark is useful for Zotero: if
        we already have a citation and want to insert one more, then we should
        turn the current citation into a citation cluster.
        
        Fix the problem by adding API similar to what commit
        24219cc1e9829f82a533667aef0f51b6a7df6fc2 (sw lok, .uno:TextFormFields:
        expose field code of fieldmarks, 2022-11-25), did: but here we return
        properties of the innermost fieldmark, not all fieldmarks.
        
        Also introduce a ITiledRenderable::supportsCommandValues(), this way
        next time a command value getter is added in sw/sc/sd, no need to touch
        desktop/ anymore.
        
        Change-Id: I7f1a7064307034a18527ab5e985d2eac56807cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145062
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-05  Stephan Bergmann  <sbergman@redhat.com>  [ed259e5efe432386b54c553cbc644b3b64976852]

        Upgrade external/boost to latest Boost 1.81.0
        
        <https://dev-www.libreoffice.org/src/boost_1_81_0.tar.xz> has been generated (on
        Fedora 37) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.81.0/source/boost_1_81_0.tar.bz2
        > $ printf '71feeed900fbccca04a3b4f2f84a7c217186f28a940ed8b7ed4725986baf99fa boost_1_81_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_81_0.html>
        > boost_1_81_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_81_0.tar.bz2
        > Unpacking boost_1_81_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_81_0.tar.xz ...
        > Cleaning up ...
        > 1deb0a5a9e33a6626fcaa1d2efd4c0e74ca2b0eea87c1559e3917f3066b633d6  boost_1_81_0.tar.xz
        > Done.
        
        * external/boost/windows-no-utf8-locales.patch.0, introduced with
          f046fed2782f0d4244aff719ba70a56399a2583a "Don't ever attempt to initialise a
          std::locale with a UTF-8 locale on Windows", was presumably obsoleted by
          <https://github.com/boostorg/locale/commit/f45adfc9b963feacc827c3754e2549dd0cffaecb>
          "Use UTF-16 <-> UTF-8 codecvt on Windows".
        
        * external/boost/libc++.patch.0 was obsoleted by
          <https://github.com/boostorg/config/commit/f0af4a9184457939b89110795ae2d293582c5f66>
          "The std lib unary/binary_function base classes are deprecated/removed from
          libcpp15."
        
        * external/boost/0001-Change-mpl-integral_c-to-boost-integral_constant-to-.patch.2
          was obsoleted by
          <https://github.com/boostorg/numeric_conversion/commit/50a1eae942effb0a9b90724323ef8f2a67e7984a>
          "Change mpl::integral_c to boost::integral_constant to avoid Clang 16 errors
          when constructing out of range enums (refs #24, boostorg/mpl#69)".
        
        * external/boost/0001-Avoid-boost-phoenix-placeholders-uarg1.10-ODR-violat.patch.2
          is needed to e.g. avoid
        > ./.libs/libetonyek_internal.a(libetonyek_internal_la-KEY1DivElement.o):(.bss+0x3e): multiple definition of `boost::phoenix::placeholders::uarg1'; ./.libs/libetonyek_internal.a(libetonyek_internal_la-IWORKFormula.o):(.bss+0x3e): first defined here
          etc. while building ExternalProject_libetonyek, caused by
          <https://github.com/boostorg/phoenix/commit/8b6a9c26c115bc2cefea300b5c0abf7edf6dd9b7>
          "std::tuple support (Resolving #103) (#104)".
        
        Change-Id: I48773166d0c50f2850d8bb37fa6215d9e5c0d51d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145044
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2023-01-05  Miklos Vajna  <vmiklos@collabora.com>  [795a02b719a86dd128b10a867036a26450536c95]

        sw doc model xml dump: extract part of SwTextAttr::dumpAsXml() ...
        
        ... into SwFormatCharFormat().
        
        This allows searching for a style name like Emphasis and search for all
        uses, even if you're not confident wrt the name due to style name
        collisions.
        
        This also means that the impl details of SwFormatCharFormat now leak
        less into SwTextAttr.
        
        Change-Id: Ifb208d04c938b7070ec94ebe727309bab96266dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145046
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7c10e3b120ba75a2db75342fdc68040a179404b8]

        sw: add the ColorSet from SdrPage into ColorSets in ThemePanel
        
        Change-Id: I7c4ef103b2be65a8adbad5d4f00304ee22be668f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143997
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-05  Eike Rathke  <erack@redhat.com>  [cb4c33ef88a0ef252383e7a12678f28c4432347e]

        Related: tdf#152781 Add also non-on-the-fly IDs to language list
        
        Generating names more than once is unnecessary.
        This may happen for defined mappings that have no explicitly
        predefined language list entry.
        
        Change-Id: I278e6d77181b661a90d0fb133cb3ca30c2a9b721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145049
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-04  Eike Rathke  <erack@redhat.com>  [8343376c10eef50a022f600e0bd03f1384e9a288]

        Related: tdf#152781 s/lang-tag of/generated/ in SAL_WARN
        
        Only cosmetical to clarify, if possible a complete UI name is
        generated, not just the language tag as before.
        
        Change-Id: Id38e397793807762c2698948c325e6eeda989cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145048
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8d65f85fe61778ebc5ec82eba19990c502a0066e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 555355c795f9333735ae897b2eaace4b2ca88534
          - Refactor help page
            
            Change-Id: I21f37ec313acf91a6e20ae9f1dd828556150a635
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/145019
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0935d75a863d3ae3689a3c314b7f82bcbe2d7368]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fa2f89b91f8f06c44c50b800762ee47006402ddd
          - tdf#152296 Content Controls Help Pages reviewed
            
            - Added content control user guide
            - Merged control properties pages
            - New menu commands
            - Entry in Contents tree
            
            Change-Id: If4b550317c1d4cae3a06d8363058a7f3214621a9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144992
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-04  Attila Szűcs  <attila.szucs@collabora.com>  [0cc9aaae5dc6655490513e8e4a93967f6248e23c]

        tdf#149588 pptx import: transparency at SolidFill
        
        When copied color (RGB) property from text content to shape,
        copy alpha component as well. (If text color have alpha component)
        
        Change-Id: Ib86c48ab7b2d3c5f9491a2211b05e90b2c2ea10f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145031
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2023-01-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e2c3f00b37ec2d4e9bd36058b3cc5e0e5b5b0e02]

        Fix typo
        
        Change-Id: Ic5e25545aecc6630da18d4b61217dab11f48470e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145047
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [dcde0b2e640c0fe36dceb49bfed5426842a6fa0a]

        move implDrawGradient into CairoCommon and reuse from X11CairoSalGraphicsImpl
        
        Change-Id: I341e0b1e3cccd18193c3f9798b875a709fe4871f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144975
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [06c0b13cbbd1672861ebd898e0e11981c5bb82a8]

        move supportsOperation to CairoCommon
        
        Change-Id: I754080c322ec76ec8e218f8c97b1649eaf922c74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [0ec1a28b4d43fc78cb5cc4c23dd0e76fd62d5e69]

        move supportsOperation to X11CairoSalGraphicsImpl
        
        Change-Id: Ic5a8652857d0104310d1aead8a55d0f053852c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [b62e3e164ef6af83e03e106e188c06eb5b91f51d]

        sync drawPolyLine impls early returns
        
        Change-Id: I9b7c49d0e4286245979043e1cb21f8b577676f87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144972
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [ae8c40abd2e1af063a4d199e4f198b3d78964f34]

        always use X11CairoSalGraphicsImpl
        
        Change-Id: I7971e17eb7eb9778fcc2d3e7c98028c6cd438004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144971
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Julien Nabet  <serval2412@yahoo.fr>  [d804a251026ec435626226c54b7af172b37314f1]

        Remove "tr" autocorr entries that correct to itself
        
        Change-Id: I969026e5847852a59e429ce5b0bbf491452302c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144921
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Muhammet Kara <kara@libreoffice.org>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-04  Patrick Luby  <plubius@neooffice.org>  [3f7406bc4df3c7d6cc618312607bff1ec36a12f7]

        tdf#152703 Force relayout during live resizing of window
        
        During a live resize, macOS floods the application with windowDidResize:
        notifications so sending a paint event does not trigger redrawing with
        the new size. Instead, force relayout by dispatching all pending internal
        events and firing any pending timers.
        
        Also, force a repaint of the window after live resizing ends by reposting
        this notification so that [self windowDidResize:] will be called at least
        once after live resizing ends.
        
        Change-Id: I9d93108c989418bab6d80c7f6afaccc1daaa746e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145042
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [5cc0b3adf6c1550105b2137dd182168a9231bd7a]

        enable SAL_ENABLE_USE_CAIRO_FOR_POLYGONS path
        
        Change-Id: Id2c8f94986aea0dd7e50b7b3aeaae7770b3e5bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [9124e9d2381ac7b039ef00b70f21b23b60735bb9]

        drop SAL_DISABLE_USE_CAIRO_FOR_FATLINES
        
        Change-Id: Ic55a117ff1f2b971f2f075d706fd1b182f16ace5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144969
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [e9749cf0e9a4110fe47ba2f3693b2f7dbf2dd7a3]

        make applyColor static
        
        Change-Id: I69cdc922488351d8bd7c0facf9c7209f56f24291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145027
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Noel Grandin  <noelgrandin@gmail.com>  [5de1d0472b319e9d48972eb067fd8189507fa640]

        use sal_uInt8 for maMatFlag
        
        which is way more cache-dense than double
        
        Change-Id: I04503eb3a4054cce5312a7a0048c9b6679a8fd16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-04  Noel Grandin  <noelgrandin@gmail.com>  [a76a135c9e9bdecd38970e293e72eeeeca000d27]

        flatten some vcl code
        
        Change-Id: I3747c9ccc97ac59a2e41c1fe4427d1a2f458352a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [23d8f732cbc40f008e3ae673cbb3cacacb105420]

        is/DocumentList.xml missing from Makefile but file exists
        
        Change-Id: Ie1cf1f928369a02ed15912afe70482224a23c626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Andras Timar  <andras.timar@collabora.com>  [dd13717076e412d7b1079a12adaff01efebf0f80]

        import colors with transparency from html
        
        The support is limited, but better than before.
        Before: the color was not imported.
        After: the color is imported as RGB, as if the background color was white.
        It is pretty much common in Writer that the background is white. On the
        other hand, transparency is not supported in many use cases, such as
        character background in this example green-highlight.html.
        
        Change-Id: Ia9449e2535ddfd8cd8c2672cb3bd32987083fdbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145039
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [c938767fc2b3a7334eff1bb192c2f2403c3f9ee8]

        SDPR: sync with "Corrected some transformations in Direct2D renderer"
        
        Change-Id: I19a652390e803f4c60466ce7796ddfeda2ef27c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145023
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Caolán McNamara  <caolanm@redhat.com>  [bd5cc6a50f2acdabc1c93bd49ce52c79a70c2144]

        Related: tdf#150339 remove SID_ATTR_COLOR_STR
        
        re: https://gerrit.libreoffice.org/c/core/+/144866
        "ColorString is not needed anymore (we used that in LOK previously)."
        
        Change-Id: I50a2f0e2ad254afb8ede33b05c89ae40bfeb4d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144967
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-04  Stephan Bergmann  <sbergman@redhat.com>  [ef533553559fe09b4afab651fc692885d1acf4ed]

        Rudimentary support for dynamic_cast on UNO proxy objects
        
        <https://gerrit.libreoffice.org/c/core/+/144139> "New loplugin:unocast" had
        argued that uses of dynamic_cast from a UNO interface type are broken in general
        (because if the source object is a proxy from the C*+ UNO bridge, its vtable's
        RTTI slot will normally not be set up, which can cause a crash), and should be
        replaced with uses of XUnoTunnel.  Which the various recent "loplugin:unocast
        (...)" commits started to do.  However, it became clear that that is not the
        most ideal way forward:  For one, getting more and more implementations of
        XUnoTunnel::getSomething into existing class hierarchies is error prone, as each
        such implementation must manually delegate to all its base class
        implementations.  For another, uses of comphelper::getFromUnoTunnel (which often
        needs to do a queryInterface to XUnoTunnel first) are easily more expensive than
        uses of dynamic_cast.
        
        Thanks to Noel, the insight here is that for the use case of a dynamic_cast from
        a UNO interface type to a local C++ class type, and if the source object is a
        proxy, it is sufficient that the dynamic_cast will not crash.  It will
        necessarily always return null (as the proxy will never be the implementation of
        a local C++ class type), so it is sufficient to fill the RTTI slots of the
        proxies' vtables with dummy values.  That avoids having to set up proper RTTI
        for those potentially multiple-inheritance proxy types.  (And with this in
        place, all those recent "loplugin:unocast (...)" commits can be reverted again
        in a next step.)
        
        I verified the changes for the gcc3_linux_aarch64 (on macOS), gcc3_linux_intel,
        gcc3_linux_x86-64, gcc3_macosx_x86-64, msvc_win32_intel, and msvc_win32_x86-64
        bridges.  The changes for all the other bridges were done blindly.
        
        (For gcc3_linux_x86-64, which already conditionally supported proper RTTI for
        UBSan, setting the offset-to-top slot to non-zero had to be made conditional
        too, as the dummy ProxyRtti will always pretend to be a full class rather than a
        potential base class that could have a non-zero offset-to-top value.  For
        msvc_win32_*, it turned out that the existing code to set up dummy XInterface
        RTTI (which was there for reasons lost to history) was broken.)
        
        Change-Id: Iec4b8067d26b14b6fb02c2fdd15e1eee20919590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145038
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-04  Stephan Bergmann  <sbergman@redhat.com>  [146eb1aa750a7612deb9d3e1825a7a2e1256bd4d]

        Fix Itanium vtable construction
        
        Our use of bridges::cpp_uno::shared::VtableFactory::Slot to model all the
        elements of a vtable is an abstraction that doesn't quite match the reality of
        <https://itanium-cxx-abi.github.io/cxx-abi/abi.html>, as vtables are not
        homogenous sequences of function pointers, but are rather a mix of offsets, data
        pointers, and function pointers.
        
        The data preceding the virtual table address point is the offset to top (an
        offset) followed by the typeinfo pointer (a data pointer).  On other platforms
        where offsets, data pointers, and function pointers are all of the same size, we
        model those as two additional Slots at index -2 and -1, resp.  On Itanium, where
        function pointers (and thus Slots) are twice the offset and data pointer size,
        we should model those as one additional Slot at index -1.
        
        The code has been this way ever since its introduction in
        0c25631972809c752624b4883c71671c8e83e797 "INTEGRATION: CWS ia64port01_DEV300
        (1.1.2); FILE ADDED".  It should never have caused any issues as the existence
        of the excess Slot at index -2 should never have gotten in the way.  But it is
        probably better to clean this up anyway.  (This is a blind fix, as I don't have
        an Itanium build environment available.  And this Itanium bridge may well be
        dead code by now, anyway.)
        
        Change-Id: I98d58785c054e1cdc621e5968c41b06d8788998f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145035
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-04  Miklos Vajna  <vmiklos@collabora.com>  [3fd787428f5e16c74018f5aa3399cb469c97587a]

        sw doc model xml dump: handle the RES_TXTATR_CHARFMT text attribute
        
        Avoids this warning on doc model xml dump when the document text uses a char style:
        
        warn:sw.core:12723:12723:sw/source/core/txtnode/txatbase.cxx:177: Unhandled TXTATR
        
        Change-Id: Iafadcdaff63d8bfcdea488a4c89496c7cd467636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145020
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-04  Miklos Vajna  <vmiklos@collabora.com>  [babba472391d26aed68d7ac31c7a918c08e65256]

        sw, UpdateFields: add new TypeName, NamePrefix and Fields parameters
        
        Currently the .uno:InsertField command allows inserting a refmark with a
        provided name & content, but existing refmarks can't be updated
        similarly. This is a problem in case Zotero citations are to be modeled
        with refmarks.
        
        Another trouble is that refmarks don't have dummy characters and have to
        stay inside a single paragraph, so we need to be careful to replace the
        content in a way that keeps the refmark alive, a naive delete + insert
        will delete the refmark as well.
        
        Fix the problem by extending the existing .uno:UpdateFields command with
        3 new optional parameters, somewhat similar to what commit
        724180ec495a696c79332653cb6fb52ecfbccc29 (sw: add a new
        .uno:UpdateBookmarks UNO command, 2022-12-14) did.
        
        As usual, the provided new text is meant to be HTML, which allows
        formatted content.
        
        Change-Id: Ib0951aa1a39e1b47bcf8b47bc9d65c89e0853e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145033
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-04  Stephan Bergmann  <sbergman@redhat.com>  [2eab74ab78b0b2a7a9c846251e2b79f595bc0878]

        Missing test dependencies
        
        Change-Id: I048e5bf58c98c7597c229996a29eb7d53451c495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144990
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-04  Martin Srebotnjak  <miles@filmsi.net>  [c8c5fce90170905280cec9c81f3ffd8ad905e6a0]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to f191df059976deba5f60983bb4a87ab184835fd4
          - Updated Slovenian thesaurus
            
            Change-Id: Id3b452928405a90e9a9fb9b3759030c7d3122a72
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/145032
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2023-01-04  Justin Luth  <justin.luth@collabora.com>  [ec2f1d73936c9d8cee83c0887170e9ecb8f044ba]

        tdf#56258 svx: use last defined locale-outline for remaining levels
        
        When applying an outline numbering choice
        (one of the 8 predefined per-locale definitions)
        the toolbar/sidebar would only affect the spacing
        of 0 - 5 of the defined locale-levels,
        and only changed the num type of the remainder.
        
        Well, that can easily look bad if the indenting and spacing
        is only partially modified.
        [The Bullets and Numbering dialog outline grid
         does not affect spacing at all.
         That can be better or much worse, depending on the situation.]
        
        This "Outline Format" button is normally turned off
        on Writer's Formatting toolbar. You need to go to
        Tools - Customize - Toolbars to turn it on.
        It only seems to work for Writer - it was grayed out/disabled
        in Draw even when I had it show up in the toolbar.
        
        So almost nobody has ever seen or used this I expect.
        However, I think it is important to get this working,
        because I want to use this grid-choice code path
        to be usable for the B&N dialog as well,
        although that could upset people who already have
        their spacing right and just want to change the digits.
        
        In any case, this nbdtimg DOES already change some
        spacing, so it should be either all or none.
        
        Change-Id: Ib54b6ffe3497f09f0c57ff2db1ec2a946f692fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145022
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-03  Andrea Rosetti  <andreamassimo03@gmail.com>  [d3a5a97f77378421f17b1fa43d0b88dde8bc686a]

        tdf#114441 Convert sal_uLong to a better type
        
        Used sal_Int32 instead of sal_uLong
        
        Change-Id: I229c4e59054b3aa1885698d1cd5332ebd9d162d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143513
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-03  Julien Nabet  <serval2412@yahoo.fr>  [c95f7c6bf705ea84e1f8da40042b382189e7179a]

        Add script to check DocumentList.xml in autocorrect
        
        Change-Id: I4c2d356c900ce7bde43d8e06af2fdda4f66c15ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-03  Stéphane Guillou  <stephane.guillou@libreoffice.org>  [601a2d3b09fdf4332b257f2c0ebd01e19e47887f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 068fa934185da6e9e6f93a7abddd02b6f22572d7
          - fix section title to match Safe Mode dialog
            
            Change-Id: Ic2d7def17bf007780dcf336e4ecbd2847d819116
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144911
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [675250baf91b5733a3a409edbb9bf17d26e0d1c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cedd7a3550c09bef1e1b5d496431c7326e1bd1ec
          - mark Basic code as not localizable
            
            Change-Id: Ic9ddc042c33c98fc5e73c2beb7ad65801adf9d38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144966
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2023-01-03  Justin Luth  <justin.luth@collabora.com>  [87a4185fff1f9294fcdc6117761b1298632c95e5]

        NFC tdf#56258 i18npool OutLineNumberingLevel: use ref="en_US"
        
        In preparing to see what improvements can be made to
        list defaults, it is helpful to see what customizations
        have been made to the US defaults. Those that match
        identically were changed to simple refs.
        
        Thanks to https://www.linuxtopia.org/online_books/
        linux_tool_guides/the_sed_faq/sedfaq4_013.html
        
        The script there helped to generate sed expressions.
        
        sed -f ref.sed *.xml
        ----- ref.sed -----
        \#<LC_OutLineNumberingLevel>#,\#</LC_OutLineNumberingLevel># {
            :ack
            N;
            \#</LC_OutLineNumberingLevel>#! b ack
            s#<LC_OutLineNumberingLevel>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix="(" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix="." \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix=")" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="0" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="2" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="1" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="3" \+Suffix="." \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="1" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="2" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="3" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="4" \+Suffix=" *" \+BulletChar="0020" \+BulletFontName="" \+ParentNumbering="4" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
            <OutlineStyle>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="27A2" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="0" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="E006" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="50" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=")" \+BulletChar="E004" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="100" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="150" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
              <OutLineNumberingLevel Prefix=" *" \+NumType="6" \+Suffix=" *" \+BulletChar="2022" \+BulletFontName="StarSymbol" \+ParentNumbering="0" \+LeftMargin="200" \+SymbolTextDistance="50" \+FirstLineOffset="0"/>\
            </OutlineStyle>\
          </LC_OutLineNumberingLevel>#<LC_OutLineNumberingLevel ref="en_US"/>#;
        }
        -------------------
        
        Change-Id: I6853c09ed10a9d71b39e79fb665f7d056e945864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144945
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-03  Justin Luth  <justin.luth@collabora.com>  [b1226e1f225de4fa67a0d4f5a6aa4017284c7deb]

        tdf#56258 i18npool: should be a SvxAdjust, not a HoriOrient
        
        Although this is unused AFAICS, lets at least use the correct
        enum, because these two do not match up.
        HoriOrient::LEFT = 3, while SvxAdjust::Left = 0 (3 is Center)
        
        Change-Id: I1cd8cce6d4e223ac272d8d4ba5e22c52c7657499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144977
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-03  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2a4d722c5c8d416bcacb9befd939709f1736b83c]

        SDPR: Corrected some transformations in Direct2D renderer
        
        Change-Id: Icd478d61e0941edb6f3420267fe425ba1d5b8dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144988
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2023-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [87e82f80e87bb4a216ea83383864d494f3e92eea]

        docx: export symbol characters correctly
        
        Previously we had:
        after save: <w:t></w:t>
        original content: <w:sym w:font="Wingdings" w:char="F0E0"/>
        
        This patch checks if paragraph has symbol font used and exports
        content using w:sym mark in that case
        
        Change-Id: I74f4bb0d249cbf5dfc930e931f7d91bd0d2e9821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143455
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144949
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-01-03  Douglas Guptill  <dguptill@accesswave.ca>  [8a96d90a890812d49ee4f3c45b99aa0110b94d69]

        tdf#143148  Use pragma once instead of include guards
        
        Change-Id: Id4b84b13bf6a467d07ba11ca6bd65495b172e606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144928
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2023-01-03  Miklos Vajna  <vmiklos@collabora.com>  [3585d0414ffe08890856e5c09f453b9f566323df]

        sw, lok: implement a getCommandValues(Fields)
        
        There was no LOK API to get a list of all fields of a given type where
        the name matches a certain prefix.
        
        This is useful in case the API cilent wants to know what previously
        inserted refmarks were deleted by the user as part of deleting text
        content.
        
        Add a new getCommandValues(".uno:Fields") that returns the names of
        matching refmarks. Do not return the refmark text, assuming that would
        be updated by the API client anyway.
        
        In practice this is needed by Zotero in case it wants to model its
        citations with refmarks.
        
        Change-Id: Ie469253891896aa8ab00d434c9ab116adbe3864b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144985
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-03  Stephan Bergmann  <sbergman@redhat.com>  [32c845cb4389aba9430ce471b04f2891f5ff630d]

        Move manual bridgetest_inprocess_java to automatic CustomTarget_uno_test check
        
        Change-Id: I38ae06444adba4eb924a19291f466548ec11b024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144984
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-03  László Németh  <nemeth@numbertext.org>  [d2614337e8291b9b6d114fda5ae914f6940c353a]

        tdf#65535 sw spellDialog.py: add same latency to fix lo-upsan build
        
        The problem reported by Stephan Bergmann:
        
         FAIL: test_tdf65535 (spellDialog.SpellingAndGrammarDialog)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests4/spellDialog.py", line 237, in test_tdf65535
              self.assertEqual("Bad baad", output_text)
          AssertionError: 'Bad baad' != 'Baad baad'
          - Bad baad
          + Baad baad
          ?   +
        
        Change-Id: Icd656544946f3d6b67fefd9980872bbee6608fab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144964
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-03  László Németh  <nemeth@numbertext.org>  [c9129bd97a9514e5679ed65bdf5879718f1b476d]

        tdf#152245 sw change tracking: fix copy from Calc to Writer tables
        
        Pasting Calc tables into Writer tables uses temporary table
        deletion, which never occured if change tracking was enabled,
        resulting freezing. Fix this by disabling change tracking
        during temporarily, also add a limit for other potential cases,
        where it's not possible to delete the table.
        
        Regression from commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I57874fa658652b30fc78b267ab49a52d7277a838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144946
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2023-01-03  Stephan Bergmann  <sbergman@redhat.com>  [88ebc324a51f16df0248d6a0d53d2169b1995dda]

        loplugin:fakebool
        
        Change-Id: I0d03e29e6290a0e7945b80538efa6b0467d37fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144981
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-03  offtkp  <parisoplop@gmail.com>  [a3d79543e0221ee810e0b2dd871d2afbf5ee198b]

        docx: Preserve w15:appearance SdtPr attribute
        
        Now roundtrips the w15:appearance value which dictates whether there's
        an effect when hovering a placeholder.
        
        Change-Id: I3c911a0cfe31e235b9d981bbff0c1bb5827a85ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144845
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-03  Dennis Francis  <dennis.francis@collabora.com>  [cf9e91f4082a9b01014e99e112e14a12246ce5f2]

        sw: prefer view's redline author name...
        
        to expand SwAuthorFieldType. Redline author name is set in
        SwXTextDocument::initializeForTiledRendering each time a new view is
        created.
        
        Change-Id: I316e0cae4399796682949de14b6d4b924833eb04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134608
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143649
        (cherry picked from commit 8be4a713e9f44bf05aebc0a3054654a18b4de065)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143585
        Tested-by: Jenkins

2023-01-03  Dennis Francis  <dennis.francis@collabora.com>  [68540314ecc801ddff06b843ac2e332b02bd7a3b]

        vcl: Copy the resource kind object itself if...
        
        some of the items in that resource are themselves dictionaries instead
        of references.
        
        Change-Id: I427386b14fe5507dfdfc9745dad27a8fceefd929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143564
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 4cb521b28e8582eda1a63bc4d92061fd111a2e3d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144438
        Tested-by: Jenkins

2023-01-03  Dennis Francis  <dennis.francis@collabora.com>  [c060f449371cebc9e447568ae1e0aa0860137e2d]

        vcl: copy /Pattern resources too
        
        Change-Id: I3d99f9083fb67c68ddee24d2d285350230533fda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143563
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit cf923b7f892ee8d5c5122c7bd88cb40a2e390a56)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144437
        Tested-by: Jenkins

2023-01-03  Dennis Francis  <dennis.francis@collabora.com>  [e72f77b8164820569834f5459514c18d2bfd911b]

        vcl: use /MediaBox origin in the ctm...
        
        of the inner XObject, else the clip polypolygon may clip out partly or
        whole contents. Adjusting the clip polypolygon is not straightforward.
        
        Change-Id: If3b208ba850c3579c9e16c15e4fb2f947dad4406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143561
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit a67dcc248a103098de883a4dd2fa9ff2e1cc1f90)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144436
        Tested-by: Jenkins

2023-01-03  Stephan Bergmann  <sbergman@redhat.com>  [9fdf6b4d8317df2a6ccc866fad93292b41c97274]

        More verbose unoidl-check errors
        
        Change-Id: Ie9aa57c5fca730c7874a527cbe5a0d463a67a0e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144930
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-03  Stephan Bergmann  <sbergman@redhat.com>  [1ce6ae04f7faa84d98b10b67f2ef5f24ac1b0129]

        -Werror=maybe-uninitialized
        
        (Adding just CPPUNIT_ASSERT wasn't enough to silence the warnings at least for
        my GCC 13 trunk build, so also added the redundant initializations.)
        
        Change-Id: I8ec9e097d4725d22dd90e9278a37768a749e292d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144943
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2023-01-03  Patrick Luby  <plubius@neooffice.org>  [d118be7ed4dd6596a8b4d766e8507b6dcaf2b7f7]

        Related: tdf#152703 Eliminate empty window with Skia/Metal while resizing
        
        The window will clear its background in [SalFrameWindow displayIfNeeded]
        so when Skia/Metal is enabled, explicitly flush the Skia graphics to the
        window during live resizing or else nothing will be drawn until after live
        resizing has ended.
        
        Also, when Skia/Metal is enabled, rapidly resizing a window has a noticeable
        amount of flicker so don't send any paint events during live resizing. Also,
        it appears that most of the LibreOffice layouts do not change their layout
        much during live resizing so apply this change when Skia is not enabled to
        ensure consistent behavior whether Skia is enabled or not.
        
        Change-Id: If6423faa72529b9de8735e04e69c9511aceb2276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144979
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-03  Ilhan Yesil  <ilhanyesil@gmx.de>  [ff7e00e12ff80bd708f31a1d886d000907ceb31a]

        tdf#148109 Paint background color in listbox
        
        The combobox described in 148109 is indeed a listbox.
        If drop down list is not open and only the selected item
        is shown without having the focus, the background color
        will be paint either it's defined as native control
        or not.
        
        Change-Id: I210916fbe07f74aaa5835bf2c88e764b010c6d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131904
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2023-01-03  Miklos Vajna  <vmiklos@collabora.com>  [3d72e1f014637e0c1f690014f3f1d4dff32de3d6]

        sw: document SwUndoInsTable
        
        Table autoformat & redlining causes most complications here.
        
        Change-Id: I2639d119bf4cb0baf05919c6de3ce44108b52db1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144965
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [ac738382d63203965e13d3fe6f7745cdea95ea38]

        jsdialog: fix validation error dialog in Calc
        
        Change-Id: Ie6551e386cd53f6b4bf4cceb6d7bd6170a2072ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143599
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144951
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [cc487218ae05fd05265191253d44b098ea6ace5f]

        deepl: don't introduce new bullets
        
        Used HTML should be free from new line characters and also <ul>
        marks so we don't generate new lines.
        
        Change-Id: I02b8f9a9af9f93e8d90a7f4a22ea02c8e1f47651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143507
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144948
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-01-03  Szymon Kłos  <szymon.klos@collabora.com>  [36de236836ee01f971744540688daad603583998]

        jsdialogs: fix generic color label name
        
        update event was triggering other widget change:
        when opened calc and selected shape first time
        we saw color text next to other color label
        
        Change-Id: I71670ac1273ce96fafc8d20126d9f32151e96d89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143471
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144950
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2023-01-02  Justin Luth  <justin.luth@collabora.com>  [ef3b7b7118c854d8ca67cc2249b6c08ddc1885eb]

        NFC tdf#56258 i18npool NumberingLevel: use ref="en_US"
        
        In preparing to see what improvements can be made to
        list defaults, it is helpful to see what customizations
        have been made to the US defaults. Those that match
        identically were changed to simple refs.
        
        Thanks to https://www.linuxtopia.org/online_books/
        linux_tool_guides/the_sed_faq/sedfaq4_013.html
        The script there helped to generate sed expressions.
        
        sed -f ref.sed *.xml
        ----- ref.sed -----
        \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># {
            :ack
            N;
            \#</LC_NumberingLevel>#! b ack
            s#<LC_NumberingLevel>\
            <NumberingLevel NumType="4" Prefix=" *" \+Suffix=")" */>\
            <NumberingLevel NumType="4" Prefix=" *" \+Suffix="." */>\
            <NumberingLevel NumType="4" Prefix="(" \+Suffix=")" */>\
            <NumberingLevel NumType="2" Prefix=" *" \+Suffix="." */>\
            <NumberingLevel NumType="0" Prefix=" *" \+Suffix=")" */>\
            <NumberingLevel NumType="1" Prefix=" *" \+Suffix=")" */>\
            <NumberingLevel NumType="1" Prefix="(" \+Suffix=")" */>\
            <NumberingLevel NumType="3" Prefix=" *" \+Suffix="." */>\
          </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#;
        }
        -------------------
        
        ----- ref2.sed -----
        \#<LC_NumberingLevel>#,\#</LC_NumberingLevel># {
            :ack
            N;
            \#</LC_NumberingLevel>#! b ack
            s#<LC_NumberingLevel>\
            <NumberingLevel Prefix=" " \+NumType="4" Suffix=")" */>\
            <NumberingLevel Prefix=" " \+NumType="4" Suffix="." */>\
            <NumberingLevel Prefix="(" \+NumType="4" Suffix=")" */>\
            <NumberingLevel Prefix=" " \+NumType="2" Suffix="." */>\
            <NumberingLevel Prefix=" " \+NumType="0" Suffix=")" */>\
            <NumberingLevel Prefix=" " \+NumType="1" Suffix=")" */>\
            <NumberingLevel Prefix="(" \+NumType="1" Suffix=")" */>\
            <NumberingLevel Prefix=" " \+NumType="3" Suffix="." */>\
          </LC_NumberingLevel>#<LC_NumberingLevel ref="en_US"/>#;
        }
        --------------------
        
        
        Change-Id: I85d8a8ed095f19d08b035d7f2c4e2cd94ff08c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144890
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2023-01-02  Noel Grandin  <noelgrandin@gmail.com>  [5244e7cab70a3c1f567e2e3cda41bd753e5cb530]

        split OutputDevice::CreateMask method
        
        to make it easier to understand, very little of the code is shared
        between the nTol == 0 and the nTol != 0 cases.
        
        Also flatten the code structure a little.
        
        Change-Id: I601b9046a6678a5dcf2176dbfe565a9a4e7299d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144962
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-02  Caolán McNamara  <caolanm@redhat.com>  [cc4ead451cb3b6ce6994370b3a9263756ea284d1]

        Resolves: tdf#150339 two arguments called "Color"
        
        from around:
        
        commit 780d83771af89e6b27b3618d9c033c3fb29ba803
        Date:   Mon Nov 4 17:17:58 2019 +0100
        
            jsdialogs: .uno:Color with string argument
        
        and:
        
        commit 1144712bb99cfb699e73b473ee44351c50a35613
        Date:   Mon Oct 28 10:19:50 2019 +0100
        
            jsdialogs: make possible to set .uno:BackgroundColor in Writer
        
        SvxColorItem Color SID_ATTR_CHAR_COLOR
        (SfxStringItem Color SID_ATTR_COLOR_STR, SvxColorItem Color SID_ATTR_CHAR_COLOR,...
                       ^^^^^                                  ^^^^^
        
        rename the most recently added to "ColorString"
        
        Change-Id: I9e00be60c768af124be7df800df4b26df83b5267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2023-01-02  Miklos Vajna  <vmiklos@collabora.com>  [a178a2ac6df8dc63a7ab8d4a19b90ae8a17baca4]

        sw UI: fix crash on inserting a fieldmark inside a fieldmark
        
        Inserting a fieldmark using .uno:TextFormField, then entering into that
        fieldmark using the cursor, finally doing in insertion again using
        .uno:TextFormField resulted in a crash.
        
        The problem is that lcl_SetFieldMarks() uses 3
        IDocumentContentOperations().InsertString() calls to insert the field
        start/separator/end, but right after inserting the field start we
        already create an sw::InsertText hint, which works with an inconsistent
        string (the start is already inserted but not the separator / end).
        
        Fix the problem by just not allowing the insertion of fieldmarks inside
        fieldmarks on the UI: these are meant to be read-only for the user, so
        fieldmark insertion is OK to be not working, as long as a clear error
        message is provided.
        
        An alternative approach would be to insert the inner fieldmark in a way
        similar to how import filters can do it, but that would be more work.
        
        Change-Id: I7d1a7c638b179fd9149ccdc47215329e3433b6e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144947
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-02  Tor Lillqvist  <tml@collabora.com>  [91526a2f53d5c7a703b9fc5fbc1728ee50854cc1]

        Use std synchronisation APIs instead of a pipe
        
        The immediate reason for this is that pipes are broken in the
        Emscripten runtime, see
        https://github.com/emscripten-core/emscripten/issues/13214. But if we
        can drop the use of a pipe for other platforms, too, why not.
        
        Without this, when attemting to run Collabora Online as WASM, I get:
        Aborted(Assertion failed: nRet == 1, at: .../vcl/headless/svpinst.cxx,538,DoYield)
        
        It is quite possible that the code could be simplified drastically. I
        only replaced the use of a pipe with hopefully equivalent use of a
        queue, a condition variable, and a mutex.
        
        Change-Id: I9259ba36afeabce6474a1aec827d01bcbbd4412b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144944
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2023-01-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [777df29e306be375c48c586855376bc25f4b85f4]

        Fix typo
        
        Change-Id: Ieae98c993d8e67d07e03c5ed13d8e11a0541f30d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144955
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b7c9049c6887c0004edb9da9fd4a68d4c8ab951]

        Fix typo
        
        Change-Id: I670b264e19de78064b8a590c309820013a032479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144954
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [75b8f7693ceb2d78acc066c4ea92a9d085a9d7d6]

        Fix typo
        
        Change-Id: I06b51dc7435c1c534c9f9d9b67ea2c54c7f5f1c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144953
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-02  Justin Luth  <justin.luth@collabora.com>  [cd7f8d895abae28533ec43ed43b2d90947e92b42]

        tdf#151704 sw: don't give random height to text frame
        
        This was introduced forever ago with
        commit 6c3ae34e32539f8493a940666dbe16b23a8ba7b0
        Author: Frank Meies on Tue Nov 20 15:24:54 2001 +0000
            Chg: Vertical Formatting - Growing frames
        
        But why?
        Assuming that anything that NEEDED to set a proper height
        has done so by now. The commit suggests it was added to
        handle vertical layouts.
        
        If this exploratory patch causes problems
        (and it very well might since this is a really generic spot)
        then perhaps it can be limited to verical layout situations?
        
        Change-Id: Ib6e4a45379e670fd343a2e2d87879e6bb52afebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144787
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [958d4667e361a1d8461889117ca830a5da85d0ee]

        oox: add ThemeExport that exports a svx::Theme into theme.xml file
        
        Adds ThemeExport that takes a svx::Theme as input and exports that
        into a theme.xml file in the OOXML document. Currently supports
        exporting of color schemes and font schemes. Format schemes are
        hard-coded for now. The ThemeExport isn't yet used in any actual
        export functionality.
        
        Change-Id: I5ca9c256da65be77e7192be7d66c73d26d78ebd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143996
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-02  Mike Kaganski  <mike.kaganski@collabora.com>  [86373552318c4858b8a050d08c57dcb35cdb2193]

        Only call getDocumentLocation once
        
        Change-Id: I0d611e5170b392a6f2b78fda51e48cd1a3287fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144909
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-02  Miklos Vajna  <vmiklos@collabora.com>  [773baa53608c4fd36de469c92b39f54672889f88]

        sw: prefix members of FormFieldsEnumWrapper, FramesEnumeration, ...
        
        ... ListGalleriesEnumWrapper and SwVbaListTemplate
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib7fd42f4cc1f1ee6ade2d81c379deb571b40e128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144929
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2023-01-02  Mike Kaganski  <mike.kaganski@collabora.com>  [672e519556c72cc376a1bdf1c2e6788509c6f348]

        Avoid reinterpret_cast
        
        Change-Id: I52b1f3d9fb0a3476ac1649ebc05c71aa8f2ce99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144908
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-02  Bogdan B  <buzea.bogdan@libreoffice.org>  [de419b94b3f7870e7ad962b1e7c8bf43b27f3d81]

        Remove unused imports from pyuno/demo and pyuno/qa
        
        Change-Id: I777eb19059030d2c1ce870b5839b541cbc7e90d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142520
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-02  Regina Henschel  <rb.henschel@t-online.de>  [cbf30153a5c776e6d1ee26f2f83c8f77503eceb9]

        tdf#125885 Conversion WordArt to Fontwork in docx import
        
        docx has the information, that a shape is a WordArt shape, after the
        text content. So in import of such file there is already a frame
        attached to the shape, which makes it impossible to set it into text
        path mode.
        
        The patch detects that it should be a WordArt shape. It transfers the
        text from frame to shape, removes the frame and then sets the shape
        into text path mode.
        
        WordArt in OOXML has the same closed set of types as we have for MS
        binary import. But MS Word can combine them with arbitrary shapes. The
        patch does only convert rectangles.
        
        The text is copied from frame to the shape as string. Thus it looses
        all styles. But our Fontwork cannot use different styles for
        portions of text, so I think that is acceptable.
        
        Fontwork uses not the styles of the text but styles set at the shape.
        The patch copies the styles from the first not empty run. That should
        give sufficient results in most cases. These text styles are set at
        the shape, which will result in a paragraph style referenced by the
        draw:text-style-name attribute of the draw:custom-shape element in ODF.
        
        The patch does not yet include export to docx. The current 'restore
        old shape' on resave to docx is lost. ToDo: Patch for export.
        
        Change-Id: I880ee7c7616db50524032e4b1443730a2d0a7361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143615
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-02  Caolán McNamara  <caolanm@redhat.com>  [54cb5990e694385dd269dc2e946c58d64390986a]

        tdf#150707 xmloff/source/style/xmlexppr.cxx:907: no prop type specified
        
        warning seen on saving very simple writer document.
        
        maybe since:
        
        commit 91f649a119d4b7ece26f9737a38663664953a57a
        Date:   Thu Dec 9 08:43:27 2021 +0100
        
            ODP import/export: refer to theme from shape text color
        
            Refer to the 12 pre-defined colors by name + don't write the attribute
            for the case when there is no theme.
        
        Change-Id: I4a7d21a7bab1ee77336ed6a5de8862fbab9be177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144870
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2023-01-02  Radhey Parekh  <radhey.parekh@gmail.com>  [745898eb2af2686ffbdfdc0e44984db67b172a59]

        tdf#70423 Remove txtimport break in 10k chars line
        
        This patch fixes the tdf#70423 which is an unexpected line break for
        ~10k characters. The fix consists of removing part of the code that
        creates a new paragraph when reaching ~10k characters. The limit was
        not exactly 10k characters, because the code tried to break at space
        character when reaching around 10k-100 characters.
        
        A test is also created, which can be checked by invoking:
        
            make CPPUNIT_TEST_NAME="testTdf70423" -sr CppunitTest_sw_txtimport
        
        The test checks that there should be exactly 1 paragraph with 30k
        characters inside it.
        
        Change-Id: Ic37c2b6eb89b52b533e34dd117b9635b9608bab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121548
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-02  Julien Nabet  <serval2412@yahoo.fr>  [44ed45cc674820433478ceda2d6b9564020d15ce]

        Remove "sl" autocorr entries that correct to itself
        
        Change-Id: I6b501a1159c7c022cf8da7bd5310fb97efe55093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144920
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-02  Bogdan B  <buzea.bogdan@libreoffice.org>  [06468a15d5d53b932e65f0ba044d15387be68904]

        Remove unused imports from compilerplugins/clang
        
        Change-Id: I923ace7bedf022d49222e71c96c7e4c20f90e6cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142521
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2023-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [312100003fc7cae358038aaec853584782c698f8]

        sw: read theme from OOXML file and set it to the draw page
        
        This change extends writerfilter to use oox::ThemeFragmentHandler
        to read the theme properties, and sets that to the one and only
        draw page of a Writer document.
        
        This change also removes ThemeTable and replaces it with the
        ThemeHandler, which takes theme font data from svx::Theme
        instead.
        
        In addition, a test has been writen, which loads a document with
        a theme, and asserts the draw page has the theme and the theme
        properties currently supported.
        
        Change-Id: Iff0048cd21ea030ac55287707852acc463ec3cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143699
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d5a71bc6a28f8a3d726b2ac4688c7cef9d77ddf0]

        oox: add support for importing font scheme into a svx::Theme
        
        Change-Id: I862256a17ce84c85174678f3fd03c8ef6661f2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143995
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [ec1acb45021fee2259028e4ee830c11b61c25fac]

        tdf#152785: typo "disabte" instead of "dissabte" for Saturday in occitan
        
        Refs:
        1) https://locongres.org/oc/aplicacions/dicodoc-oc/dicodoc-recerca?option=com_dicodoc&view=search&Itemid=168&type=fr-oc&dic%5B%5D=BASIC&dic%5B%5D=LAUS&dic%5B%5D=LAGA&q=samedi&q2=&submit=Cercar
        2) https://en.wiktionary.org/wiki/Appendix:Days_of_the_week
        
        like this since the beginning 5b7b4e81144619c8350b5c59d9d17ba7f75aeccb
        "
        INTEGRATION: CWS locales23 (1.1.2); FILE ADDED
        2007/04/25 19:14:54 er 1.1.2.1: #i76044# add Occitan_France (oc_FR) locale data; contributed by Bruno Gallart <bgallart@ooo>
        "
        
        Thank you to quentinantonin@free.fr for having spotted this + provided refs!
        
        Change-Id: I8b81e561885bc2e1eea6c5f88a3924ea58141791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144926
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2023-01-01  Eike Rathke  <erack@redhat.com>  [cf8cfee9d4e64dba6a14dde16f08a7699fdff863]

        Resolves: tdf#151886 Use default locale with English function names again
        
        Automatically switching to en-US locale when using English
        function names caused too much confusion. There also might be the
        possibility that the '.' dot decimal separator clashes with the
        inline array column separator in some locales.
        
        A proper solution would make this user-specified and if set also
        adjust the separators to the common English ones. For now keep the
        default locale again as it previously was the case.
        
        Change-Id: Ic4712c6609c14f35cf0d1d842ac7443806a6e115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144924
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2023-01-01  Noel Grandin  <noelgrandin@gmail.com>  [efda8aa8ee0e8ec7afe5ad56937ae2e3c5570c32]

        remove dead code
        
        this code has been dead for some time, no need to keep it anymore.
        
        Change-Id: I9c553fa7460bda5331f5908311783207bf88be17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2023-01-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ab81b5e097eef3d154f5150d1f747937439b5c37]

        Fix no-pch build on Windows
        
        Change-Id: If4eadc1987bb7015d2a7d3a6fb3c25a57158b248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144899
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-01  Mike Kaganski  <mike.kaganski@collabora.com>  [f1151648b3df1b76e3308c288f12b4dd1414e92e]

        Avoid unneeded initialization, and use URLZONE ids
        
        Change-Id: I8c6f31865b992fab0739fbefed5d39f21d0fa664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144904
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [7b7e3392069716539a1a3a9d453e57f681b6e7d5]

        Remove "vi" autocorr entries that correct to itself
        
        Change-Id: I684bdb18209f2f3fa75adb77bdbe27a4645e5b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144922
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [bdaf40b10c2602e09cd6ce20ba68206bcbfdfe3e]

        Remove "pt" autocorr entries that correct to itself
        
        Change-Id: I6c08829a71deb5fae1d986946efd91aec28fe342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144919
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [3151cb3f2cb40470f7cff95c48d3ab61cc46b4b2]

        Remove "pt-PT" autocorr entries that correct to itself
        
        Change-Id: I3702ce12cd62c0b4c2d7ee4a4af2640e3db76bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144918
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [36b41e69f6ace9a9ccaa8642b7167752c55881d4]

        Remove "nl-BE" autocorr entries that correct to itself
        
        Change-Id: Iad59d47f3b34a7d7e16fd7c5ecb02b2bd7d3fab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144917
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [1f1559229e26e32e51193e8f25f963afcb200105]

        Remove "mn" autocorr entries that correct to itself
        
        Change-Id: Ib5a3ef8066517ac79101a409aedc78a764979a2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144916
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [4ffcf43a4ba8b576815dc1ef5aa15d7da1cb03f1]

        Remove "fa" autocorr entries that correct to itself
        
        Change-Id: Ie493f9342fb1b66779a3ffebae03eeabe7a2b704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144915
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Julien Nabet  <serval2412@yahoo.fr>  [adcb1831e81df050fea2c9fadeb671c8748aada6]

        Remove "cs" autocorr entries that correct to itself
        
        Change-Id: I16acb568ebb2d4426782df4c745d4de9408c0f01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144914
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2023-01-01  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [56cc13e854abb9d9257abda6d67cd5d0ee8b8140]

        Bump copyright year to 2023
        
        Change-Id: I699112a3e554013bab75b82d1eae00098216c886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144893
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-31  Caolán McNamara  <caolanm@redhat.com>  [44355a90b3450111ad87ad4b6607a564e41d7b54]

        Resolves: tdf#150687 remove Romanian autocorr entries that correct to itself
        
        Change-Id: Ib776477588f887fb82c95632ccda92a9f1f32541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-31  Caolán McNamara  <caolanm@redhat.com>  [5bd1fec8db76a608f05d95dfeb92e49940864697]

        Related: tdf#150687 pretty-print Romanian autocorrect file
        
        for human readability
        
        Change-Id: I371a23ebdd3ab19e9d3092fca4c811068294a256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-31  Caolán McNamara  <caolanm@redhat.com>  [00d2d9145b530cac605206a6220c5e8175ad9382]

        Related: tdf#150687 add info to warning as to what is not found
        
        Change-Id: Ie6cb8214c1e4801bc6a548a158dfec4420df38d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144887
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-31  Noel Grandin  <noelgrandin@gmail.com>  [5230836875cc193469ada218d7934ca8c6d5f45e]

        use more GetAnchorContentOffset
        
        Change-Id: I0c5f1bbe04a1888bb20a0aaba207d3787bff250b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-31  Khaled Hosny  <khaled@aliftype.com>  [5d42f4403d4e51f33ad8f2ce9efbed542978b521]

        tdf#136604: Remove Source Sans Pro fonts
        
        Templates using the fonts are left unchanged.
        
        Change-Id: I5ed21155ddd5038eb91f6ad6bcbd7f27f2478638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143665
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-31  Caolán McNamara  <caolanm@redhat.com>  [eefa5cb64f97845e80ab23984bb7b516174fa817]

        Related: ofz Use-of-uninitialized-value
        
        Change-Id: I2f6e726f713836295603bf7112371aa4aff2c7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-31  Caolán McNamara  <caolanm@redhat.com>  [305c8365b4066a042cd9cbb42a10f1081b5abb2f]

        Resolves: tdf#150676 silence SvxColumnItem::QueryValue with 0 arg warning
        
        which is commonly seen and not unexpected
        
        Change-Id: I3dde49f8cee206985187e9317a354536f18f4e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-31  Bogdan B  <buzea.bogdan@libreoffice.org>  [74e675aa81f6a21e15c240807ef7fab3576461ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 191a9d96b89735575cf352f7e8356c6bb6716ad6
          - tdf#151065 Improve Help about bibliography
            
            Change-Id: Ie7af821b5e064978da8ffbed5894a928e55ba765
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144902
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-12-31  Noel Grandin  <noelgrandin@gmail.com>  [c6f756e968bbb72522bd01dea283288a61a286a7]

        tdf#152676 Writer: Compatibility options no longer saved as default
        
        regression from
            commit 78adf246d5e99d0f5d91d2e03c1379b154289d8d
            Date:   Mon Jul 26 10:54:36 2021 +0200
            return SvtCompatibilityEntry from SvtCompatibilityOptions::GetList
        
        where I mistakenly assumed that the bIsDefault flag in
        SvtCompatibilityEntry was being set by the SvtCompatibilityOptions
        code. Rather remove this field if it is not going to be maintained
        properly.
        
        Change-Id: I23963ae885563d5abc8a99cfd144d7fe00c6f192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-31  Jim Raykowski  <raykowj@gmail.com>  [5a06b3b789063e77afe7395226359c6ce8aad156]

        tdf#151051 Fix promote/demote outline-level promotes/demotes both
        
        outline nodes for outline nodes with table content as last content
        followed immediately by an outline node
        
        SwCursorShell::MakeOutlineSel function, currently used to select the
        range of outline nodes for outline-level promote/demote, makes a
        cursor selection of outline nodes to the start of the next outline
        node past the outline nodes to be promoted/demoted. The selection is
        then adjusted to the end content of the previous node. When the
        previous node is a table, the selection does not move into the table,
        but remains at the start of outline node that is one node after the
        wanted range. This patch avoids use of the MakeOutlineSel function
        for outline-level promote/demote.
        
        Change-Id: Ida505df6ec172681868e86570ae523494ed7929e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141128
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-30  Stephan Bergmann  <sbergman@redhat.com>  [12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae]

        -Werror=maybe-uninitialized
        
        Change-Id: I6e25dd666bf091e1d3cfc22792a319fd34af3523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144865
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-30  Bogdan B  <buzea.bogdan@libreoffice.org>  [7e6b8359b6f8833608a0574bd2931b6a62d92847]

        tdf#151065 Improve extended tip about bibliography
        
        Change-Id: Ib712e9fed6ee81f3afdffbabcb3e05bd0ef72bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144808
        Tested-by: Jenkins
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-30  Khaled Hosny  <khaled@aliftype.com>  [3344de28f6ddb559281d0b2c28f475a3e54fe7af]

        vcl: Simplify this code and remove the funny comment
        
        Change-Id: Ia57f79ccb656eb570c4e481154eb6e74e2a32bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144879
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9713a4aae980a52d08d38f5b12424aa5e33f9a75]

        optimise SUMPRODUCT(IF..) where we have entire column/row ranges
        
        following the same pattern as for SUM, set those ranges to shrink to
        available data.
        
        Takes it from 3s to <500ms on my test spreadsheet.
        
        Change-Id: I53ada996393a063b12ef7dd0f9bff40c90ecc8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144850
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [96f162d02adee9b4edbb440896be90a64523c119]

        optimise SUMPRODUCT(IF..) a little
        
        Move the AddSub calculation inside ScMatrix so we
        can use an iterator to walk the matrix and avoid lookup
        cost for each element.
        Shaves 50% off the time spent here in my test sheet.
        
        Change-Id: I171d7dd4ae86419a563342a4120d14106e8d71db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144826
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-30  Khaled Hosny  <khaled@aliftype.com>  [95f0dc2dc74401a097105fcfe745aba3e571d9c4]

        tdf#152737: Fix off-by-one errors
        
        Regressions from:
        
        commit 718af940435ae9d2ac90374e5880ecb38e96252c
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Fri Dec 16 00:10:34 2022 +0200
        
            tdf#152533: Improve script handling in font preview
        
        and:
        
        commit bfecacb2487ba9470600e6f64056d9b1816ee96b
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Thu Dec 15 22:51:54 2022 +0200
        
            tdf#152460: Improve script handling in style previews
        
        Change-Id: I7b12f5accbd65459d724676efb7bec947a7faaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144880
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-30  Khaled Hosny  <khaled@aliftype.com>  [a838f92bb4b1bdc84f49c61f669b1f32ee1f83c3]

        tdf#152734: Calculate correctly the kashida glyph X position
        
        Change-Id: I4c76aed58acd0598b9d09d147ed86e76ef468c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144878
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6743a97c1f6668724eb7c6234a4e736497328957]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5a8bd9f693106c8aeaa97f922e531680ef35899e
          - tdf#152259 Clear (and correct) syntax of address in Calc
            
            Change-Id: I3ed8bd00867677134c18b223de30b3c719e83110
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144825
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2022-12-30  László Németh  <nemeth@numbertext.org>  [247e161cf1dca6811998b67d1138062fa4e14381]

        upgrade to hunspell 1.7.2
        
        Change-Id: If969eccc73926911a4a09440623adf83b8e2c520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144869
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-30  Caolán McNamara  <caolanm@redhat.com>  [49e5a9d4c49a290eb64399e983ca7810ef4ed8f3]

        SID_ATTR_CHAR_COLOR is a SvxColorItem
        
        Change-Id: I24daf6ce37a09ef2b8fa33f1d28e43e1470d5014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144867
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-30  Brett T. Warden  <brett.t.warden@intel.com>  [15e5d86cc55ad94ac946e04d5e25b84be5810970]

        Remove dependency on BitArray.h from zxing-1.2.0
        
        In zxing-1.4.0, numerous headers are no longer public. Rework the
        ConvertToSVGFormat method so it uses bitmatrix.get instead of
        bitmatrix.getRow, similar to the ToSVG method in zxing itself.
        
        See https://github.com/zxing-cpp/zxing-cpp/issues/361
        
        Change-Id: Ie25eb8f782e8799fbd57c24ef79bba92acf0f9ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144874
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-30  Tor Lillqvist  <tml@collabora.com>  [af560f84efc5e48f122a468450f51dfff8359c8e]

        I get "warning: unsupported syscall: __sys_prlimit64" in WASM so avoid that
        
        Change-Id: I8a9a19d3c7757e1b7e1d194c439280a9d4824c3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144876
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-30  Michael Weghorn  <m.weghorn@posteo.de>  [d993327eab0a2c9c8820c6528075b01de68b0ec6]

        android: Offer "Save" entry independent of edit actions
        
        Move the "Save" menu entry out of "group_edit_actions",
        which gets hidden when switching from edit to view
        mode when the experimental editing feature is enabled
        in Android Viewer.
        
        This e.g. makes sure that the "Save" entry is offered
        for the following scenario (just as the "Save as" entry
        is as well):
        
        * ensure experimental editing feature is enabled
        * open existing doc
        * edit the document
        * switch back to view mode by tapping the left-most
          item in the editing toolbar
        
        Since the doc was modified, the "Save" entry should
        be present then.
        
        Explicitly hide the entry when the experimental
        editing feature is disabled, since that no longer
        happens through "group_edit_actions" now.
        
        Change-Id: Ibe7736932021d7516e2fd3a09ae9276015fe0d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144872
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-30  László Németh  <nemeth@numbertext.org>  [57d79744c77eef96b4c2bd3b16e0a04317ffcf9e]

        tdf#136306 offapi linguistic: add options to disable rule-based compounding
        
        Add two new spell checking options to disable rule-based closed
        and hyphenated compound word recognition with Hunspell dictionaries:
        
        com::sun::star::linguistic2::XLinguProperties::IsSpellClosedCompound
        com::sun::star::linguistic2::XLinguProperties::IsSpellHyphenatedCompound
        
        For professional proofreaders, it can be more important to avoid
        of the mistakes of the rule-based compound word recognition, than
        to speed up proofreading. Disabling the following two new options
        will report all rule-based closed compound words (default in
        Dutch, German, Hungarian etc. dictionaries) and rule-based
        hyphenated compound words (all languages with BREAK usage in
        their Hunspell dictionaries):
        
        - "Accept possible closed compound words"
        
        - "Accept possible hyphenated compound words"
        
        For example, disabling the second one, dictionary word "scot-free"
        will be still correct word in English spell checking, but not
        the previously accepted compound "arbitrary-word-with-hyphen".
        
        Note: the second option works with the update to Hunspell 1.7.2.
        
        Change-Id: Id879610927d5e8269fda5ad207c1c2fe1f57a0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144875
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-30  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b22bbfa25ab1f0b9cfa1dedc85b8f9874f0a5e5b]

        Related: tdf#125093 Check Windows Security Zones for macros
        
        In Windows, files get assigned security zones (local, from intranet,
        from internet, etc) after download via browser or email client. This
        is used by MS Word to decide in which mode it is safe to open file.
        
        This patch implements basic support for similar feature: by default
        there are no changes in macro behavior. But it is possible to use
        expert configuration options to tweak default behavior, and for
        example disable macros automatically, if a file is downloaded from
        Internet or other unsafe locations.
        
        Change-Id: I0bf1ae4e54d75dd5d07cab309124a67a85ef2d4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143680
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [d5a9722874871576b864feb7bd815f9f8bfaac48]

        ms format import: better handling for invalid styles
        
        If referred paragraph style is not found or it is not a paragraph
        style, this can lead to exceptions in writer core and thus current
        paragraph can be not corretly initialized. For example, numbering
        can be not applied because of exception of not found style earlier.
        This is not a critical error, we should just not apply a style
        we could not resolve.
        
        Of course such documents are invalid but bit more tolerance to errors
        will not harm.
        
        Change-Id: I9150786e6357a7d6098440bac29ec501fc6aa802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144852
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-29  Mike Kaganski  <mike.kaganski@collabora.com>  [37723413115baafdc7d13ad26d11aa5f917c2036]

        tdf#152717: ScDdeLink::DataChanged may get OUString directly
        
        ... after commit 94df17f58fe6269452b7252b712a89978c444bec
        (tdf#151429: don't convert OUStrings to system encoding, 2022-10-08)
        
        Change-Id: Ie9d6eb2a4465a576eefe0840a30636e898fa9028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144810
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-29  Caolán McNamara  <caolanm@redhat.com>  [f0ff9162950487f1e7ccc01e01160d60bf102488]

        cid#1518241 Improper use of negative value
        
        and
        
        cid#1518243 Improper use of negative value
        cid#1518244 Improper use of negative value
        
        Change-Id: I82de403d833d931703d52a368aa0b467abffa54b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-29  Patrick Luby  <plubius@neooffice.org>  [b99464ef2ff58670aacee2fb5f0ea4398420ad47]

        Related: tdf#146842 Eliminate temporary copies of SkiaSalBitmap when printing
        
        Commit 9eb732a32023e74c44ac8c3b5af9f5424273bb6c fixed crashing when
        printing SkiaSalBitmaps to a non-Skia SalGraphics. However, the fix
        almost always makes two copies of the SkiaSalBitmap's bitmap data: the
        first copy is made in SkiaSalBitmap::AcquireBuffer() and then
        QuartzSalBitmap makes a copy of the first copy.
        
        By making QuartzSalBitmap's methods that return a CGImageRef pure
        virtual, a non-Skia SalGraphics can now create a CGImageRef directly
        from a SkiaSalBitmap's Skia bitmap data without copying to any
        intermediate buffers.
        
        Change-Id: If6ab7f175889cb4839d8a2461b7be7671e575c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144856
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-29  Ilhan Yesil  <ilhanyesil@gmx.de>  [aef2ee893c7b76794bc9db869f08bbbea60606a8]

        tdf#152508 Initiate container request size after call of createPage
        
        As the container's request size of wizard pages can't be changed
        directly by the UNO call setPosSize, the UNO caller can set the size
        in the callback function createPage, this size will then taken as
        request size. This doesn't solve the problem entirely as descriped
        in tdf#152508, but the most important is, that the wizard page can
        be initialized with an appropriate size at startup.
        
        Change-Id: I1899da9c018681291559eb7c0de25a3e2e8af14e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-29  Tor Lillqvist  <tml@collabora.com>  [3998ccfe14dab2e0a9b31cebe08534aa41177ce5]

        Make two TOOLS_WARN_EXCEPTION messages a bit more informative
        
        Change-Id: I614f44cfb94a214baace420f94f18991f368b953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144859
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-29  Caolán McNamara  <caolanm@redhat.com>  [eeaee6726c803cf18c84cd90fca381eb11e9d21f]

        cid#1518242 Logically dead code
        
        Change-Id: Ie0a426c207746cca19b652a51b6f567e4b9a0752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144860
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-29  Noel Grandin  <noelgrandin@gmail.com>  [62ed082ee026023d332b2b4bbbc8a7b49580fa2e]

        tdf#152683 LO Draw ignoring Undo:Resize Grouped Object
        
        regression from
          commit 4e24efb563cbe6fec4185b4f7ec3755b2fc05b6b
          tdf#54857 elide more dynamic_cast
        
        Change-Id: I4fbabe64649ee47a9360dd939b5f39d35bd29c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-29  Noel Grandin  <noelgrandin@gmail.com>  [98448a25219166d4775a81a01b1deb029d7d7efd]

        merge SwapFile into ImpSwapFile
        
        no need for this
        
        Change-Id: I0367582adb616a00f260b5d78b63d288068b7d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-29  Noel Grandin  <noelgrandin@gmail.com>  [9645e4003c1787a32aa13a261fb94accf6770138]

        use TempFileFast for vcl graphics swapout
        
        which is considerably faster on Windows when there is lots of
        system RAM available.
        
        Change-Id: I6ebde79af06f4e969231089783f1d4109f70ea94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-29  Stephan Bergmann  <sbergman@redhat.com>  [6522d0f44a92f8102f50f94e26c6d7140fd7fd44]

        Properly print floats
        
        ...avoiding
        
        > /writerfilter/source/dmapper/PropertyMap.cxx:324:71: runtime error: -2539 is outside the range of representable values of type 'unsigned int'
        >     #0 0x7f80e9a3b6c3 in writerfilter::dmapper::PropertyMap::dumpXml() const /writerfilter/source/dmapper/PropertyMap.cxx:324:71
        >     #1 0x7f80e928eccb in writerfilter::dmapper::DomainMapperTableHandler::endTableGetTableStyle(writerfilter::dmapper::TableInfo&, std::__debug::vector<com::sun::star::beans::PropertyValue, std::allocator<com::sun::star::beans::PropertyValue> >&, bool) /writerfilter/source/dmapper/DomainMapperTableHandler.cxx:434:40
        >     #2 0x7f80e92b4b8f in writerfilter::dmapper::DomainMapperTableHandler::endTable(unsigned int, bool) /writerfilter/source/dmapper/DomainMapperTableHandler.cxx:1377:30
        >     #3 0x7f80e9c289de in writerfilter::dmapper::TableManager::resolveCurrentTable() /writerfilter/source/dmapper/TableManager.cxx:409:33
        >     #4 0x7f80e9c297a1 in writerfilter::dmapper::TableManager::endLevel() /writerfilter/source/dmapper/TableManager.cxx:427:9
        >     #5 0x7f80e936a997 in writerfilter::dmapper::DomainMapperTableManager::endLevel() /writerfilter/source/dmapper/DomainMapperTableManager.cxx:497:19
        >     #6 0x7f80e9c256d1 in writerfilter::dmapper::TableManager::endParagraphGroup() /writerfilter/source/dmapper/TableManager.cxx:338:9
        >     #7 0x7f80e9205974 in writerfilter::dmapper::DomainMapper::lcl_endParagraphGroup() /writerfilter/source/dmapper/DomainMapper.cxx:3511:35
        >     #8 0x7f80e984598e in writerfilter::LoggedStream::endParagraphGroup() /writerfilter/source/dmapper/LoggedResources.cxx:108:5
        >     #9 0x7f80e9d9addf in writerfilter::ooxml::OOXMLFastContextHandler::endParagraphGroup() /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:452:23
        >     #10 0x7f80ea042658 in writerfilter::ooxml::OOXMLFactory_wml::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) /workdir/CustomTarget/writerfilter/source/ooxml/OOXMLFactory_wml.cxx:7574:19
        >     #11 0x7f80e9d8822a in writerfilter::ooxml::OOXMLFactory::endAction(writerfilter::ooxml::OOXMLFastContextHandler*) /writerfilter/source/ooxml/OOXMLFactory.cxx:157:19
        >     #12 0x7f80e9d944eb in writerfilter::ooxml::OOXMLFastContextHandler::lcl_endFastElement(int) /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:242:5
        >     #13 0x7f80e9d941da in writerfilter::ooxml::OOXMLFastContextHandler::endFastElement(int) /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:225:9
        >     #14 0x7f80f44ffe2a in (anonymous namespace)::Entity::endElement() /sax/source/fastparser/fastparser.cxx:515:27
        >     #15 0x7f80f44ff818 in sax_fastparser::FastSaxParserImpl::callbackEndElement() /sax/source/fastparser/fastparser.cxx:1343:17
        >     #16 0x7f80f44ef554 in (anonymous namespace)::call_callbackEndElement(void*, unsigned char const*, unsigned char const*, unsigned char const*) /sax/source/fastparser/fastparser.cxx:339:18
        >     #17 0x7f8179cde54a in xmlParseEndTag2 /workdir/UnpackedTarball/libxml2/parser.c:9742:2
        >     #18 0x7f8179c8ced0 in xmlParseTryOrFinish /workdir/UnpackedTarball/libxml2/parser.c:11642:14
        >     #19 0x7f8179c7acc9 in xmlParseChunk /workdir/UnpackedTarball/libxml2/parser.c:12351:13
        >     #20 0x7f80f44ea4f1 in sax_fastparser::FastSaxParserImpl::parse() /sax/source/fastparser/fastparser.cxx:1099:21
        >     #21 0x7f80f44e4146 in sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:904:9
        >     #22 0x7f80f4505300 in sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource const&) /sax/source/fastparser/fastparser.cxx:1482:13
        >     #23 0x7f80e9d46e98 in writerfilter::ooxml::OOXMLDocumentImpl::resolve(writerfilter::Stream&) /writerfilter/source/ooxml/OOXMLDocumentImpl.cxx:508:18
        >     #24 0x7f80e9cfed05 in (anonymous namespace)::WriterFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /writerfilter/source/filter/WriterFilter.cxx:208:24
        >     #25 0x7f8149202866 in SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) /sfx2/source/doc/objstor.cxx:2272:34
        >     #26 0x7f81491c2434 in SfxObjectShell::DoLoad(SfxMedium*) /sfx2/source/doc/objstor.cxx:739:23
        >     #27 0x7f81493c9870 in SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/doc/sfxbasemodel.cxx:1937:36
        >     #28 0x7f8149b20d71 in (anonymous namespace)::SfxFrameLoader_Impl::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&) /sfx2/source/view/frmload.cxx:720:28
        >     #29 0x7f810e00256b in framework::LoadEnv::impl_loadContent() /framework/source/loadenv/loadenv.cxx:1167:37
        >     #30 0x7f810dff896b in framework::LoadEnv::start() /framework/source/loadenv/loadenv.cxx:403:20
        >     #31 0x7f810dff0dec in framework::LoadEnv::startLoading(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, int, LoadEnvFeatures) /framework/source/loadenv/loadenv.cxx:308:5
        >     #32 0x7f810dfec180 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/loadenv/loadenv.cxx:168:14
        >     #33 0x7f810e0b541d in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx:604:16
        >     #34 0x7f810e0b5646 in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/desktop.cxx
        >     #35 0x7f812a050c25 in unotest::MacrosTest::loadFromDesktop(rtl::OUString const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:70:62
        >     #36 0x7f81444fcad9 in UnoApiTest::load(rtl::OUString const&, char const*) /test/source/unoapi_test.cxx:115:11
        >     #37 0x7f812a8ae042 in SwModelTestBase::loadURL(rtl::OUString const&, char const*, char const*) /sw/qa/unit/swmodeltestbase.cxx:449:20
        >     #38 0x7f812a8b9452 in SwModelTestBase::load(char const*, char const*) /sw/qa/inc/swmodeltestbase.hxx:351:16
        >     #39 0x7f812a8af516 in SwModelTestBase::loadAndSave(char const*) /sw/qa/unit/swmodeltestbase.cxx:502:5
        >     #40 0x7f814fcfe242 in testTableThemePreservation::TestBody() /sw/qa/extras/ooxmlexport/ooxmlexport3.cxx:888:5
        
        during CppunitTest_sw_ooxmlexport3
        (<https://ci.libreoffice.org//job/lo_ubsan/2629/>).
        
        (The overload for is_integral parameters is needed now to avoid ambiguity errors
        when integer types other than sal_uInt32 could also match the newly added float
        overload.)
        
        Change-Id: I6482bccef2442655359c71e13f0c9bfe7e4d9dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144855
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-29  Justin Luth  <justin.luth@collabora.com>  [64318c884eac13baa3012c8da3e5feb3c1369933]

        tdf#56258 tdf#106988 sw numbering ivx: make style useable
        
        In the current state, the style was basically unusable.
        The first two levels had numbering at the same indent,
        the third level started with a c),
        and the fourth level started earlier than the 3rd level.
        
        I took my formatting queues from Numbering IVX.
        These right-aligned roman-numerals can grow very wide
        when getting to number 7 and 8, so I designed the
        style with a wide indent theme.
        
        Now the first two levels have the same width as
        ROMAN_UPPER. Since this style is a mixed bag,
        I changed the second level to use ROMAN_UPPER,
        which keeps the roman theme, but fits better with
        the following character and bullet sublevels.
        The third level switches back to left-aligned
        with similar indents to CHAR_LOWER_LETTER,
        (and starts with letter "a" - good grief)
        while the bullet levels are a nice, breezy half-indent width
        (which is 50%-100% wider than the bullet styles).
        
        Change-Id: Ie3ac386c360e804dde6c295dd39a3c02d3ba9b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144841
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org>

2022-12-28  Khaled Hosny  <khaled@aliftype.com>  [b3132822524a73eef4f705e3ace9e3c5fb27368f]

        Reference the correct bug number
        
        Typo from 96a856f87f16cca2e039c973c18d57c8b9dca362
        
        Change-Id: Ie10c879c5ca471a5ab5f0a661d810b4ff6ae3332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144853
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-28  Hossein  <hossein@libreoffice.org>  [196930bae2577a73a0201bda943e8cccaa839e2b]

        Revert "tdf#114441 Convert use of sal_uLong to better integer types"
        
        This partially reverts 3cc818c38e11c0882bc3ad32ffd0019a9ad38643. In this
        patch sal_uLong was converted to better data types. In part of the patch
        the order of the calls, GetVisibleSize() ~> SetLineSize ~> SetPageSize()
        was changed so that the GetVisibleSize() is invoked inside the parameter
        passing to SetPageSize() to avoid creating a temporary variable.
        
        As sberg mentioned, it was needed that the call to SetLineSize() did
        not have side effects that changes the result of the GetVisibleSize().
        But it was hard to prove so, even if it seemed logically sound. Thus,
        I am reverting the above commit partially.
        
        In the revert, I've used tools::Long for nVisSize instead of sal_uLong.
        
        Change-Id: Iba8d2da2675c237e9ab1c30918defce13ea71d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144617
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-28  Justin Luth  <justin.luth@collabora.com>  [028aa1058340803eb8dca5ad8f39ca253ad18fb3]

        tdf#56258 tdf#106988 sw numbering IVX: fix bad indent/tab value
        
        The comment (and the previous code) indicates a progressive
        increment by 1.3cm for each level. Well, the third level
        was some mid-way-between-level1-and-level2 anomaly.
        So just drop it and add the proper indent for the last level.
        
        The tenth level should be 10 times larger than the first indent.
        Previously it was 283 and 2835, so the current values
        of 754 and 7541 sound perfect.
        
        This was a LO 6.0 regression by
        commit 3d6fca942063fe5e398c3a09f9336dc5aa549138
        
        Change-Id: I41623424ab5c768bdc3914ae9b95d02631bb1a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144827
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-28  Tor Lillqvist  <tml@collabora.com>  [de3b4b02008d708a66f8d6a8a365974eac7de3b3]

        Introduce lo_get_app_data_dir() for Emscripten, too
        
        And not just Android. Hardcoded to return "/instdir" to match what is
        in the emscripten_fs_image.
        
        Change-Id: I26d4ec5e02ec9900e35ca47f1565a13ad2b723b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144849
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [a510543a466aca0d152f82af24d16563f28455f0]

        android: Use PNG icons instead of vector image for compatibility
        
        Convert the drawable resources added in
        
            commit cfc73f3373f49770b859bc68cbf6bd987342f9ad
            Date:   Fri Dec 23 23:20:26 2022 +0100
        
                android: Add buttons to increase/decrease indent
        
        to use PNG images (PNG export of the SVG images used previously, using
        Inkscape) instead of vector drawables, since devices with old API
        versions apparently don't support these vector drawables.
        
        Trying to open any doc in an x86 AVD with API version 16
        would result in LO crashing with this exception in ADB log:
        
            E/AndroidRuntime( 2948): java.lang.RuntimeException: Unable to start activity ComponentInfo{org.libreoffice/org.libreoffice.LibreOfficeMainActivity}: android.view.InflateException: Binary XML file line #281: Error inflating class ImageButton
            E/AndroidRuntime( 2948):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2059)
            E/AndroidRuntime( 2948):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
            E/AndroidRuntime( 2948):        at android.app.ActivityThread.access$600(ActivityThread.java:130)
            E/AndroidRuntime( 2948):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
            E/AndroidRuntime( 2948):        at android.os.Handler.dispatchMessage(Handler.java:99)
            E/AndroidRuntime( 2948):        at android.os.Looper.loop(Looper.java:137)
            E/AndroidRuntime( 2948):        at android.app.ActivityThread.main(ActivityThread.java:4745)
            E/AndroidRuntime( 2948):        at java.lang.reflect.Method.invokeNative(Native Method)
            E/AndroidRuntime( 2948):        at java.lang.reflect.Method.invoke(Method.java:511)
            E/AndroidRuntime( 2948):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
            E/AndroidRuntime( 2948):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
            E/AndroidRuntime( 2948):        at dalvik.system.NativeStart.main(Native Method)
            E/AndroidRuntime( 2948): Caused by: android.view.InflateException: Binary XML file line #281: Error inflating class ImageButton
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:704)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:746)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.parseInclude(LayoutInflater.java:830)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:736)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.inflate(LayoutInflater.java:489)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.inflate(LayoutInflater.java:396)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.inflate(LayoutInflater.java:352)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:710)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:195)
            E/AndroidRuntime( 2948):        at org.libreoffice.LibreOfficeMainActivity.onCreate(LibreOfficeMainActivity.java:131)
            E/AndroidRuntime( 2948):        at android.app.Activity.performCreate(Activity.java:5008)
            E/AndroidRuntime( 2948):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
            E/AndroidRuntime( 2948):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
            E/AndroidRuntime( 2948):        ... 11 more
            E/AndroidRuntime( 2948): Caused by: android.content.res.Resources$NotFoundException: File res/drawable/ic_incrementindent.xml from drawable resource ID #0x7f0800b4
            E/AndroidRuntime( 2948):        at android.content.res.Resources.loadDrawable(Resources.java:1923)
            E/AndroidRuntime( 2948):        at android.content.res.TypedArray.getDrawable(TypedArray.java:601)
            E/AndroidRuntime( 2948):        at android.widget.ImageView.<init>(ImageView.java:120)
            E/AndroidRuntime( 2948):        at android.widget.ImageButton.<init>(ImageButton.java:87)
            E/AndroidRuntime( 2948):        at androidx.appcompat.widget.AppCompatImageButton.<init>(AppCompatImageButton.java:78)
            E/AndroidRuntime( 2948):        at androidx.appcompat.widget.AppCompatImageButton.<init>(AppCompatImageButton.java:73)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatViewInflater.createImageButton(AppCompatViewInflater.java:226)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatViewInflater.createView(AppCompatViewInflater.java:141)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatDelegateImpl.createView(AppCompatDelegateImpl.java:1569)
            E/AndroidRuntime( 2948):        at androidx.appcompat.app.AppCompatDelegateImpl.onCreateView(AppCompatDelegateImpl.java:1620)
            E/AndroidRuntime( 2948):        at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:675)
            E/AndroidRuntime( 2948):        ... 32 more
            E/AndroidRuntime( 2948): Caused by: org.xmlpull.v1.XmlPullParserException: Binary XML file line #5: invalid drawable tag vector
            E/AndroidRuntime( 2948):        at android.graphics.drawable.Drawable.createFromXmlInner(Drawable.java:877)
            E/AndroidRuntime( 2948):        at android.graphics.drawable.Drawable.createFromXml(Drawable.java:818)
            E/AndroidRuntime( 2948):        at android.content.res.Resources.loadDrawable(Resources.java:1920)
            E/AndroidRuntime( 2948):        ... 42 more
            W/ActivityManager( 1423):   Force finishing activity org.libreoffice/.LibreOfficeMainActivity
            W/ActivityManager( 1423):   Force finishing activity org.libreoffice/.ui.LibreOfficeUIActivity
        
        Change-Id: I3580faf5e4b1f55acdc3d32caa8a233bb09a14aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144848
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfaee17c0e41cc04056adb946fe45332cc8b0e27]

        update credits
        
        Change-Id: I043250075037de2b8d56a0708f26c5c2120b2afc

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [037680488b56aa2c4eb21900168aa88ef35d5b07]

        android: Enable multidex, update com.google.android.material to 1.7.0
        
        Release notes:
        https://github.com/material-components/material-components-android/releases/tag/1.7.0
        
        With the material update in place, multidex needs to be enabled since the
        app has minSdkVersion 16 (i.e. smaller than 21) and now references
        more then 65,536 methods, see [1] for more background.
        
        Therefore, carry out the changes to support multidex
        as mentioned in [2].
        
        Without enabling multidex, the build would fail like this:
        
            > Task :mergeExtDexStrippedUIDebug FAILED
            ERROR:D8: Cannot fit requested classes in a single dex file (# methods: 68864 > 65536)
            com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
            The number of method references in a .dex file cannot exceed 64K.
            Learn how to resolve this issue at https://developer.android.com/tools/building/multidex.html
                    at com.android.builder.dexing.D8DexArchiveMerger.getExceptionToRethrow(D8DexArchiveMerger.java:151)
                    at com.android.builder.dexing.D8DexArchiveMerger.mergeDexArchives(D8DexArchiveMerger.java:138)
                    at com.android.build.gradle.internal.tasks.DexMergingWorkAction.merge(DexMergingTask.kt:859)
                    at com.android.build.gradle.internal.tasks.DexMergingWorkAction.run(DexMergingTask.kt:805)
                    at com.android.build.gradle.internal.profile.ProfileAwareWorkAction.execute(ProfileAwareWorkAction.kt:74)
                    at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
                    at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:66)
                    at org.gradle.workers.internal.NoIsolationWorkerFactory$1$1.create(NoIsolationWorkerFactory.java:62)
                    at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:97)
                    at org.gradle.workers.internal.NoIsolationWorkerFactory$1.lambda$execute$0(NoIsolationWorkerFactory.java:62)
                    at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:44)
                    at org.gradle.workers.internal.AbstractWorker$1.call(AbstractWorker.java:41)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
                    at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
                    at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
                    at org.gradle.workers.internal.AbstractWorker.executeWrappedInBuildOperation(AbstractWorker.java:41)
                    at org.gradle.workers.internal.NoIsolationWorkerFactory$1.execute(NoIsolationWorkerFactory.java:59)
                    at org.gradle.workers.internal.DefaultWorkerExecutor.lambda$submitWork$2(DefaultWorkerExecutor.java:205)
                    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
                    at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runExecution(DefaultConditionalExecutionQueue.java:187)
                    at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.access$700(DefaultConditionalExecutionQueue.java:120)
                    at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner$1.run(DefaultConditionalExecutionQueue.java:162)
                    at org.gradle.internal.Factories$1.create(Factories.java:31)
                    at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:270)
                    at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:119)
                    at org.gradle.internal.work.DefaultWorkerLeaseService.runAsWorkerThread(DefaultWorkerLeaseService.java:124)
                    at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.runBatch(DefaultConditionalExecutionQueue.java:157)
                    at org.gradle.internal.work.DefaultConditionalExecutionQueue$ExecutionRunner.run(DefaultConditionalExecutionQueue.java:126)
                    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
                    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        
        [1] https://developer.android.com/studio/build/multidex
        [2] https://developer.android.com/studio/build/multidex#mdex-gradle
        
        Change-Id: Ie5d78a54e7f69b55586d80718c04e71526ebad6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144838
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [e690752d5643ffaf4da8778768e5e080476b2427]

        android: Update compileSdkVersion/targetSdkVersion to 33
        
        API version 33 refers to Android 13.
        
        I didn't notice anything requiring changes
        when quickly going over the release notes for all apps running on
        Android 13 [1] and apps targeting Android 13 [2].
        
        [1] https://developer.android.com/about/versions/13/behavior-changes-all
        [2] https://developer.android.com/about/versions/13/behavior-changes-13
        
        Change-Id: I8b68f3bf0afc4c00ecd3412a8fdf0581f2d6bbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144837
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [afcdd294b3cbca93810ad1a94df18770d0a09bba]

        android: Set namespace in build.gradle instead of manifest
        
        Switch from the now deprecated way, as mentioned in
        
            commit 7347d911fa295c31262a0f576c5b2f3f14ce017d
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Dec 23 18:29:44 2022 +0100
        
                android: Update  Android Gradle Plugin to 7.3.1
        
                ... and gradle to 7.4.
        
                Relevant entry from the release notes [1] that will be
                addressed in a follow-up commit:
        
                > # Package attribute in manifest file is deprecated
                >
                > Starting with AGP 7.3.0-alpha04, if you use Gradle to build your
                > project, AGP generates a warning if you use the package attribute in the
                > manifest file. To set the namespace for your app, use the namespace
                > property in the module-level build.gradle file. To learn more, see Set a
                > namespace
                > [https://developer.android.com/studio/build/configure-app-module#set-namespace].
                >
                > To get help moving to the new namespace DSL, use the AGP Upgrade
                > Assistant (Tools > AGP Upgrade Assistant).
        
                [1] https://developer.android.com/studio/releases/gradle-plugin#7-3-0
        
                Change-Id: I8b196e53fb9b3fb7e9314719fdb7e0f2254abd10
        
        Note that this is unrelated to the Android application ID [1]
        that can be set with autogen param `--with-android-package-name`.
        
        [1] https://developer.android.com/studio/build/configure-app-module#set-application-id
        
        Change-Id: I146dab19228d83b1beb6408743c0232e1ba1d060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144836
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [d23671de498d5531f1f84fa7f0ee21773551ef8a]

        android: Include Impress's layout.xml into app
        
        It's needed since
        
            commit daab698b346e5e40b67f1e15c796c4e399ccaf8a
            Date:   Tue Nov 22 14:07:12 2022 +0200
        
                sd: replace hardcoded table styles with xml file
        
        Without it being included into the app/APK, opening
        any presentation in Android Viewer file would fail, with
        this in ADB log:
        
            12-27 10:22:45.329  9811  9862 E libo:sal/osl/unx/file: failed to open /assets/share/config/soffice.cfg/simpress/styles.xml
            12-27 10:22:45.332  9811  9862 W svl.items: 1:svl/source/items/itempool.cxx:442: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty.
            12-27 10:22:45.337  9811  9862 I LOKitTileProvider: ====> mOffice.documentLoad() returned null, trying to restart 'Office' and loading again
        
        Change-Id: I677476bda146be2cd3ebe18da91bcb8f2a796fd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144835
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-28  Michael Weghorn  <m.weghorn@posteo.de>  [3826a7df9aa447bec08a3b056180778ad8c953af]

        android: Update  Android Gradle Plugin to 7.3.1
        
        ... and gradle to 7.4.
        
        Relevant entry from the release notes [1] that will be
        addressed in a follow-up commit:
        
        > # Package attribute in manifest file is deprecated
        >
        > Starting with AGP 7.3.0-alpha04, if you use Gradle to build your
        > project, AGP generates a warning if you use the package attribute in the
        > manifest file. To set the namespace for your app, use the namespace
        > property in the module-level build.gradle file. To learn more, see Set a
        > namespace
        > [https://developer.android.com/studio/build/configure-app-module#set-namespace].
        >
        > To get help moving to the new namespace DSL, use the AGP Upgrade
        > Assistant (Tools > AGP Upgrade Assistant).
        
        [1] https://developer.android.com/studio/releases/gradle-plugin#7-3-0
        
        Change-Id: I8b196e53fb9b3fb7e9314719fdb7e0f2254abd10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144834
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-27  Eike Rathke  <erack@redhat.com>  [b9e3e20bfd102880d12384892eaeca094c38a519]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9db68c8ce0b3f2ed588345a5d3fb33c4af545bb7
          - Correct INDEX() syntax and adapt to reality, clarify semantics
            
            Row and Column arguments are not only optional but can also be
            omitted / given as empty argument.
            
            Reword the multiple ranges explanation.
            
            Remove a decade old source comment.
            
            Change-Id: Ie34e4731b88d4b3adc4a6d0cc98c9e4a02b3c669
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144846
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-12-27  Noel Grandin  <noelgrandin@gmail.com>  [1b9ca3689dab4deaea20be511eb942674bbbc481]

        try to fix shutdown crashes in ConfigurationWrapper
        
        associated with
            commit 7df433cdc33b4d6ba38eafad9282d015571433ef
            optimize ConfigurationProperty::get()
        
        it seems it introduced
        https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*)
        which, at the moment, is the most reported crash in
        https://crashreport.libreoffice.org/stats/version/7.4.3.2
        
        We need to tie the lifetime of ConfigurationWrapper and the cache
        objects together, so they die as one unit, otherwise the
        unpredicatable ordering of destruction of static objects is a
        problem.
        
        Change-Id: I80db5a4c28510a68f40b919902b01f3981e32bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [63dcb9b5ee055f3812c86c3b0553426db524c906]

        Update git submodules
        
        * Update translations from branch 'master'
          to 642fe8324e026e226c7e8e06e9d332d4f6181726
          - update translations for master/7.5
            
            and force-fix errors using pocheck
            
            Change-Id: Ic3c6df26db8a38ad0e87e34b3c4a2c420b84c41e
            
2022-12-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [0439823bd328d65973861805c8aec8e6ce1176ff]

        git pre-commit hook: check .mm files
        
        Change-Id: I3e0e0845dab52ffa23ff7a072802da5c0374d200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144833
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-27  Jim Raykowski  <raykowj@gmail.com>  [9d387cc1e7848848c41f29ad91fee44ade79f678]

        tdf#140666 Make delete reference possible from the Navigator
        
        This patch makes it possible to delete a reference without having to do
        the steps given in the help.
        
        "References are fields. To remove a reference, delete the field. If you
        set a longer text as a reference and you do not want to re-enter it
        after deleting the reference, select the text and copy it to the
        clipboard. You can then reinsert it as "unformatted text" at the same
        position using the command Edit - Paste special. The text remains
        intact while the reference is deleted."
        
        Change-Id: If363340288de25aacbc28acd5858ce275f309af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144406
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-27  Bogdan B  <buzea.bogdan@libreoffice.org>  [033b22412ceccfac1150f9acd1758952d3cabf44]

        tdf#150700 Update command name in the File - Send menu
        
        Change-Id: I33b9b20f2cf6e1c1aa2e9ace4ce8a4c60cb1ac24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144802
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [29c2bba1f3ef216d226c97197185066880fc1ab5]

        svx: use array for colors in ColorSet, add consts, rename vars
        
        Use std::array for colors in ColorSet as there are always only 12
        colors for a color scheme.
        Add "const" to getters where appropriate.
        Rename maColorSetName to maName in ColorSet - long variable name
        is not needed.
        
        Change-Id: Iacb976a22af2d2585d627b0ba65d98cbe1b825c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143994
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cffe7884342f249e82780a46f9aba4213e9dd378]

        oox: rename name variables that are imported into oox::Theme
        
        Rename names for font scheme and format scheme in oox::Theme so
        it is easier to know for what they are used for.
        
        Change-Id: I83e2978c407ab7f264de4a161575b086bc5efc03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143993
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-26  ahsmha  <ahmed.5wna0@aleeas.com>  [46c8dacd3bd01b0453796d1eb729f81f175837f2]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I3f0a7b8619ac229cb0326f281c4ded608055b7ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144820
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-12-26  Justin Luth  <justin.luth@collabora.com>  [6a46845839f0d7e6ca2b1586e3ab268dcdbb2dea]

        tdf#151548 ww8export: export formfield names
        
        This should have been looking for ODF_FORMCHECKBOX_NAME
        for checkboxes instead of a never-created grabbag "name".
        
        In any case, since LO 7.5 all the three true formfields
        preserve their name in the name property, so no grabbags
        are necessary any more.
        
        Unforunately the unit test is not very good.
        I copied it from the DOCX case, but I just can't
        get it to fail - even without any patching.
        Yet I know it is broken b/c it is broken in MS Word 2010,
        but now it isn't broken after the patch round-trips it.
        
        Change-Id: I88e92d4c6d0b0e26ba80c428e06e63859941a3ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144815
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [68c4dbcebed057084083b968f244b8c430a4dc60]

        tdf#127588 - extend selection to the entire field if nothing is selected
        
        If a user pastes a string to an input field that has a maximum length restriction and no text is selected in the input field, extend the selection to the respective length of the pasted string or the maximum text length of the input field in order to prevent a text truncation warning. If the user selects some text in the input field, just replace the currently selected text and show the text truncation warning as before.
        
        Change-Id: I2115f8c6672c9c66770abfa6918cf327a7eece17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144784
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a6253e13e0f3f866ab47e4271db9a80d8cbce708]

        oox: set svx::Theme directly to a SdrPage when importing
        
        Bypass the need to set the theme data (svx::Theme) throught UNO
        as multiple nested properties. Much more properties will be added
        to the svx::Theme and this will simplify handling a lot.
        
        Change-Id: I0b54628ff22c7c823a999de257fd5bb45e736bdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143992
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4ee7e71d850315f5ae4c3b763b0e80e8d83a6454]

        svx: rename mnPitch to mnPitchFamily, add resolvePitchFamily
        
        Rename mnPitch to mnPitchFamily as it contains both. Extract the
        code to resolve what is pitch and what is family into its own
        (static) function.
        
        Change-Id: I0c17351ea690a85decefb8d73dd07644ce5c78d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143991
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1386e26b2d7fc5173266ffbfb94bc82b1d3f7bb9]

        svx: rename ThemeColorType enum values, use enum instead of index
        
        Change-Id: I81c1553205365c4076562474078b3b0aa834b249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143990
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-25  Khaled Hosny  <khaled@aliftype.com>  [18b39c8c9b35528c8fb172339126b613827d09aa]

        tdf#88484: Show sample text for Abyssinica SIL font
        
        The font sets Arabic Presentation Forms-B bit, probably because it
        includes U+FEFF (Zero Width Space) which happens to be in that block but
        it isn’t an Arabic code point. Filter this bit out if we already decided
        it isn’t an Arabic font.
        
        Change-Id: I9935c793b8a7592eb92db59bc75de65b81ab99fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144819
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e431417aa67d4b31f57e9d751b63e8e8cf002567]

        Fixed a copy paste error in a comment
        
        Change-Id: Ibcd4c2f0cccb233647f3b079f02d01f156d30138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144818
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6fb682487e355933d79a8ef74560ecf318b4f705]

        editeng: move "tint or shade" variable into SvxThemeColor
        
        Change-Id: Ia2094854a8275082cf7444307e17fe5449c43b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143698
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-25  Mike Kaganski  <mike.kaganski@collabora.com>  [5bd5dd4c3ebbb4258fe7c17df1da6b81b016a0e2]

        Simplify a bit
        
        Change-Id: I2c4df04cc7c57649077f61bfd0bc9fb0e9b42a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144795
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-25  Justin Luth  <justin.luth@collabora.com>  [24b969d10cd81e6f5eb438ded075dd330a1cde29]

        tdf#151548 DOCX formfield: export checkbox name
        
        The two other fields are exporting the name,
        (although it is getting somewhat lost in excess bookmarks),
        because they are just using the Fieldmark name property.
        
        See LO 7.5 8ad39b6f2aff3ca37aeaaaaff5373991e853c329
        for tdf#151548 sw: use provided name for formfields
        which saved the name for checkboxes and dropdowns.
        
        ODF_FORMCHECKBOX_NAME was simply used as a grabbag
        for ww8import. Since that is obsolete, get rid of it.
        
        mostly introduced with ---
        commit b547c0c2aa901667fef85233282ec84f34b7e5f4
        Author: Noel Power on Thu Feb 10 16:18:40 2011 +0000
            some form field import/export improvements
        
        ODF_FORMDROPDOWN_NAME was dropped early on. ---
        commit 79770ff55bd8c3bc5948c51373e8cb7867ce43d3
        Author: Noel Power on Tue Mar 1 12:30:23 2011 +0000
            partial revert of 803409125f4ed896b391acb99266d50691c6fd4a
        
            remove currently unnecessary ( but possibly future )
            odf attributes for form field controls to prevent those
            attributes from being written to odf
        
        Change-Id: I133028dce65361314e663bb5238f99c607f0ab14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144792
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-25  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [df9f3f3fd81d4f81ee2ff984d1e19999abea2963]

        sw: support for reading back theme color from OOXML
        
        OOXML supports theme colors and tint/shade value that additionally
        changed the theme color. Read back which theme color + tint/shade
        value was applied in the resulting color and add this attributes
        as properties to be used by writer.
        In sidebar theme panel the changing the theme colors now doesn't
        takes this into account and changes the colors correctly.
        
        Change-Id: I3a2d49d485fd37a1611483ee0bb5e6034ac5f88e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143697
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-24  Justin Luth  <justin.luth@collabora.com>  [376152fbd110cdc0a2cde1fa9758f36c016d9352]

        tdf#152636 writerfilter: no w:br in DMLShapes
        
        Don't write postponed column and page breaks into DML shape
        paragraphs.
        
        No existing unit tests found that match this criteria.
        The example file I have is not appropriate as a unit test,
        and it too easily fails to match when any random change
        is made to minimize/scrub it.
        
        Change-Id: Iced1399f76caf97362a5ba47a325233b9f009fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144779
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-23  Michael Weghorn  <m.weghorn@posteo.de>  [cfc73f3373f49770b859bc68cbf6bd987342f9ad]

        android: Add buttons to increase/decrease indent
        
        This adds two buttons to the formatting toolbar to
        increase/decrease the indent, using the corresponding
        UNO commands. These can be used when the experimental
        editing mode for Android Viewer is enabled.
        
        The drawable resources were created using the
        corresponding sifr_svg icons (incrementindent.svg,
        decrementindent.svg).
        
        Change-Id: Id8f0fc9a5ea686b474ec9a4b4dcdf23407e9ac98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144789
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [4cfcc9ac37b90ce64c8402a41eb4638adb185b5c]

        loplugin:unocast (framework::Desktop)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ifcf713b0543e78a124f613bcbda496069a280dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144762
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [03efbf72f4ddf7a84aa8aabef348331bd4b75e8a]

        loplugin:unocast (vclcanvas::TextLayout)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I4ee48fe50c6c579952478e6d3f6c2aac168d095c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144769
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [80099fdd51a69eaa6c36ca88ef772810e4a777fa]

        loplugin:unocast (SalGtkXWindow)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I139c4006c385019d7332b1594ff24e2ab314e5ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144766
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [cc147f576d8687fb79c77d47d41dc4ba1678a469]

        loplugin:unocast (sdext::presenter::CachablePresenterView)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ib158190fe9059d1c6b0b002cd37f83593a494e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144764
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [40db42be1d8fd0f9c6c8c5ba3767ddb9ee2034c2]

        loplugin:unocast (vclcanvas::CanvasFont)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Id92c7e4367aae8e22d77772986d85288cdb73f2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144770
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [2d1e7995eae29e2826449eb5179f5fae181794a5]

        loplugin:unocast (CairoColorSpace)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ie04db15daff4a44758019aab690ff8e822ddae45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144771
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [4c0bbe4bd97636207cf71a6aa120c67698891da9]

        loplugin:unocast (canvas::ParametricPolyPolygon)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I965d6ba17decda1fa055fb548aa9085d2e786bc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144768
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [89803666621c07d1b1ac9d3bd883f0ca192a91a0]

        loplugin:unocast (vclcanas::CanvasBitmap)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: If79f69507e939a25a5bbf82f818c44f26077dfce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144767
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [d5e0c2c8db71878d21c2a7255af08cf5f9a6dd04]

        loplugin:unocast (sfx2::DigitalSignatures)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I74c76452cf7921da55462581ef48aea86f58ea18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Stephan Bergmann  <sbergman@redhat.com>  [c0c4519e0d5b555f59bbc04cc616454edfd1f4ce]

        loplugin:unocast (VCLXAccessibleComponent)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I11496cc1d37e89ce8f11991f86c7b60bb1b93106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144748
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-23  Patrick Luby  <plubius@neooffice.org>  [1b6acdc60bc284c3e78bb05f70c24a2e36b2ccc7]

        tdf#150177 Limit minimum blink cursor rate
        
        This bug occurs when the values for NSTextInsertionPointBlinkPeriodOn or
        NSTextInsertionPointBlinkPeriodOff are set to zero or close to zero.
        LibreOffice becomes very sluggish opening documents when either is set
        at 100 milliseconds or less so set the blink rate to the maximum of
        500 milliseconds, NSTextInsertionPointBlinkPeriodOn, and
        NSTextInsertionPointBlinkPeriodOff.
        
        Change-Id: I953bddda757f8514221ac5cd9c04bd749a994fda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144775
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-23  Justin Luth  <justin.luth@collabora.com>  [36db0b44905a7c4cf4ceccf47948d2785e79935f]

        tdf#152636 writerfilter: handle breakcode on table page break
        
        We always have to handle two situations when dealing with
        page breaks - paragraphs and tables.
        
        Change-Id: Ie0347d70f9529ca2e846c4a5041e76da9bd03e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144778
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-23  Tor Lillqvist  <tml@collabora.com>  [53e2f8906fa067efdbb9ef90aa1ebaac4ab0ed2a]

        Don't use symlinks for the Emscripten soffice.data and soffice.data.js.metadata
        
        Symlinks just complicate things. Disk space is cheap. soffice.data is
        under 100 megs even with Qt5.
        
        Note that after this you will need to clean out the existing
        soffice.data and soffice.data.js.metadata symlinks before you run
        make, otherwise you will get errors.
        
        As such, it is a bit weird that we unconditionally play around with
        soffice.data for *all* (non-CppunitTest) Executable targets. (Thus,
        for instance also for vcldemo and unoidl-read.) We should do this
        dance only for the soffice executable. And we should reduce the number
        of executables we build for Emscripten. Probably none other than
        soffice itself makes sense?
        
        Change-Id: I75f6719b92d83e88bf59d65c38aeeab47e0b29e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144781
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-23  Tor Lillqvist  <tml@collabora.com>  [1f39fd25469f299e5da54f5eef0d127dd2daf5b6]

        Un-confuse Emscripten and Qt5 conditionals
        
        The embedded file system that we construct when building for
        Emscripten is not related to whether we use Qt5 or not.
        
        Change-Id: Ibf65cae06093d9130a19780c1116f8b9997c664b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144780
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2022-12-23  Caolán McNamara  <caolanm@redhat.com>  [7c3a255e42f17c312af26684c2aed567c1c5a5a3]

        SDPR: Add rendering of BitmapPrimitive2D for Cairo
        
        pretty nasty copy of bitmap data for split alpha and so on, head
        scratching for a while to figure out to scale the pattern matrix, but it
        seems to render ok
        
        Change-Id: I6c82953e3646556ece6b1a5a6b12b7f76b0d41c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-23  Caolán McNamara  <caolanm@redhat.com>  [376c561922875df5712742c8cbd19a8c39495a21]

        can improve scope
        
        Change-Id: Ied189c410b21272b5fad47c3d4b11e85a534cc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144773
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1e9f6f57f506a171b1b4a0bbd46bb43ccad1f954]

        Fix typo
        
        Thanks a lot Julien!
        
        Change-Id: I987a37519228ad0771565fa59d55d6e50a0d3c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144743
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d56d76a4204aad18f75463b0c9aa6130d558e0ef]

        Fix typo
        
        Change-Id: Ie67ae711e6fe0348ddde1fb5d3ac8798fc37c8aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144776
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-23  Justin Luth  <justin.luth@collabora.com>  [3963c693895779d4fba6c94b4ab1df70f9830207]

        tdf#152636 writerfilter: correctly detect first para in doc
        
        This fixes LO 7.5 regression c37f62b71fa59917ef85ff98480dff18aa936e41.
        
        It could be triggered if the second paragraph or table already
        had a new page style assigned to it.
        
        Change-Id: I5ad78c37ad6a388f7321e021250e11d22fc6e3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144777
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [780d55199e54fafc3784691d5cf716c1bb92b0aa]

        gb_LTOFLAGS: use -flto=jobserver instead of fixed $(PARALLELISM)
        
        fixed PARALLELISM causes explosion of jobs, especially when machines
        wtih many cores/threads. A make wtih PARALLELISM=16 would launch up to
        16 linker invocations that by themselves would also do their linking
        with a parallelism of 16, causing load of over 100 and very likely
        exhausting all memory bringing the system to a crawl or cause OOM kills.
        
        for a command to be able to communicate with make's jobserver, it must
        be part of a submake called with $(MAKE) or the command from the rule
        needs to be prefixed with the + character.
        While our gbuild stuff is a submake call, it only is that submake that
        uses the PARALLELISM flags determined by configure, so that is not
        sufficient for jobserver usage by the the lto linker.
        
        Change-Id: I46ec4760c1a8623195700b8cb16f7deafeb1111e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144593
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-22  Caolán McNamara  <caolanm@redhat.com>  [24889135773204c6e3002dcb417c75ff1a99ccd0]

        check GetEditShell()
        
        Change-Id: I975c7dca9ea569e326fc5d8670a078959ab9f093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-22  Michael Weghorn  <m.weghorn@posteo.de>  [2d0ff08f8724c6fd2b7801c7eb8fa0a41a90f883]

        tdf#152532 vcl: Don't convert negative entry count to unsigned
        
        In particular for empty output sizes (as is the case for
        the observed cases from tdf#152532, where
        `SvImpLBox::AdjustScrollBars` gets called before the
        resize to the final size happens),
        
            (aOSize.Height() - m_nHorSBarHeight) / nEntryHeight
        
        can become negative, and that was silently converted
        into a large positive integer when assigned to `m_nVisibleCount`
        which is of type `sal_uLong`. As a result, `SvImpLBox::FillView`
        later moved the view to the very top of the scroll area and did
        not make sure that the selected entry would remain inside of the view.
        
        Prevent that by using 0 as minimum value.
        
        Also explicitly convert to unsigned using `o3tl::make_unsigned`
        at another place that should be fine (but will trigger an assert
        now if it isn't, rather than silently converting a negative
        value to unsigned).
        
        Change-Id: Iab1402603adb7b7c93927ecbfd10336049bfd71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144744
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-12-22  Patrick Luby  <plubius@neooffice.org>  [1e4ef6d69b22f6674aefb415edf2e8e7ca78ff2d]

        tdf#42437 Enable press-and-hold special character input method
        
        The first step to enable this input method is to always return a valid selected
        range location. -[NSResponder interpretKeyEvents:] will not call
        [self firstRectForCharacterRange:actualRange:] if the selected range location
        is NSNotFound so that is what was disabling display of the press-and-hold
        input method popup.
        
        Once [self firstRectForCharacterRange:actualRange:] is called, emulate the
        press-and-hold behavior of the TextEdit application by setting the marked text
        to the last key down event's characters. The characters will already have been
        committed by the special character input method so set the
        mbTextInputWantsNonRepeatKeyDown flag to indicate that the characters need to
        be deleted if the input method replaces the committed characters.
        
        Also, emulate the press-and-hold behavior of the TextEdit application by
        committing any uncommitted text when either the escape or the return key is
        pressed while the press-and-hold input method popup is displayed.
        
        Lastly, handle repeat key events by explicitly inserting the text if there is
        no uncommitted text before -[NSResponder interpretKeyEvents:] is called.
        
        Change-Id: I104b3d64a8c66fef3a5a1cec0fba1daa553cd9a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf3562cf38c2dd7776a160ee8259a6fb97c0e7ba]

        Fix typo
        
        "an other" -> "another"
        
        Change-Id: Id0a2b8f99fd4f87e94e65570ebc75bfdf0d205ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143597
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c8517e7d89f7b87eeb36b2758a01d9dac515d5a]

        sw: check for nullptr
        
        GetEditShell() in sw/source/core/doc/doccorr.cxx
        might return nullptr
        
        Introduced in 7cb6be3e866bad39a37844802d49b1f5c7031910
        "tdf#151190 sw content controls: make them read-write in protected
        sections"
        
        See https://crashreport.libreoffice.org/stats/crash_details/5d1da2eb-b0e9-4974-b726-c7837c47cc63
        
        Change-Id: Ia133c5d7a680c3bdfabe1c43c538cb5f54e7df73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144756
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [253b681bec1e1142f4fcfcebe41fd5d4418d37e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 70c46432b1cb4e994de45ca8a1f6bda6e286b1a9
          - janitor - the announce is not meant to be part of the dependencies
            
            quirk introduced with the change making the xsltproc one an order-only
            dependency. The line-continuation wasn't removed with that change
            causing the annouce to fire when make is parsing the makefile. Doesn't
            hurt anything or affected the build result in any way, but certainly not
            as intended :-)
            
            Change-Id: I82069208fff1ff0c01efba00caa2d8fa5279efaf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144760
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [feb8b833a6245d42400f42a0bc789dc84594ee6f]

        loplugin:unocast (VCLXDialog)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ia3bf3f52845884e68094b966ad3bd49ad82688a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144749
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [37ca1154f392dd9eefad8250509652b845434793]

        sw: check for nullptr in WriterInspectorTextPanel
        
        GetEditShell() in sw/source/core/doc/doccorr.cxx
        might return nullptr
        
        See https://crashreport.libreoffice.org/stats/crash_details/75a28cf5-cf45-4d36-a1aa-471a0ad9251a
        
        Change-Id: I3de2dec461d590841d4ea3b7d98f384ee27ad4ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144757
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [1fa58cc6cc9c3849753342a5d9a6ddfa461b5e66]

        loplugin:unocast (VCLXMultiPage)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I7f755ce1483c5e2eca3066d12d90c5916d2f9087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144751
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [f481f036deb1b1b46f3038074c4659f3a91b9c6c]

        loplugin:unocast (DocumentSettingsSerializer)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I803f62085264511976ed9bb0744ee301de2a7dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144754
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [73df933f5fa5932f94e5a1b338a3eda00a9ce354]

        loplugin:unocast (css::embed::EmbeddedUpdate)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ia0f628be9adf749ffdd9ad36ca9b1e8c98e29936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144755
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [420165ab0ef03c0467f9d17f504de2d2fc78f0e6]

        loplugin:unocast (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I472e09870b51b89b89c643675ab46c38b4a0c6de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144753
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [37d3f34d11c9322058e302bd98b333bd1f9e37f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9871dc3b0f8eb24793fc797d478db534d92ec5d7
          - make html.text target make more robust on windows re CR at EOL
            
            some cygwin setups still treat the final CR as part of the filename, so
            avoid that problem alltogether by simply appending a dummy entry to each
            line on the responsefile to catch any stray EOL/EOF characters
            
            Change-Id: I624eeeca033f72b2845394b44f27b6e32d01eb70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144758
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [9abe8ee067e6c00f19d8a13346d53c4641c27166]

        loplugin:unocast (MutableTreeNode)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I33fc079e2128c678ecc36567c2c5ed75481694c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144752
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [9f3022ceb036f23b4b0994c3e2fbd1001bff225a]

        loplugin:unocast (VCLXTabPage)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I90754509513cafd04fa560d76a669a47d587f353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144750
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [1be70dda02c12a60778b7607cff2520ae1aa611e]

        loplugin:unocast (vcl::unotools::VclCanvasBitmap)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I78b54e0806d5c3a157b4bed94bd89933a0921052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144747
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [d6a70bb641b96e8e5616448c2378131ed62658b4]

        loplugin:unocast (basegfx::unotools::UnoPolyPolygon)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I166d8f31a13a98caf0bb7a3b5025a9d942808096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144746
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [1c17356958b07aa7e202d3f9242c807c5dc447ac]

        -Wc++11-narrowing (clang-cl)
        
        ("non-constant-expression cannot be narrowed from type 'double' to 'FLOAT' (aka
        'float') in initializer list")
        
        Change-Id: I079ec4b6cc5e757e4082ebc6b9ae6d06065542eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144738
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Caolán McNamara  <caolanm@redhat.com>  [70406ea7627e4bd5cf7ec590afc8a09db6c1a0eb]

        Related: tdf#152637 Erase after changing background color
        
        Change-Id: Ic63714304c32f066347a2654510e1fa1fbd16184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [b844605b101bd752c8a0c07117b5d3faf2b2aebb]

        loplugin:redundantstatic (clang-cl)
        
        ("salhelper::SimpleReferenceObject subclass being directly stack managed, should
        be managed via rtl::Reference, const primitive2d::PolyPolygonColorPrimitive2D")
        
        Change-Id: I53246ac9f1af1eb1d1ad91ef4d5f59dc19fd2825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144742
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [e8996124b443d416eafedc68dc25a5ec66dd84db]

        loplugin:redundantstatic (clang-cl)
        
        Change-Id: I2bc5a6231c78e8a38dd65ec0310b0b2b68f6fb22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144741
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [e816ca42f9f5d21ae50939559900c1aede994d0e]

        -Werror,-Wmicrosoft-extra-qualification (clang-cl)
        
        Change-Id: I7f0f551110d1df4e27d89ac1016fb5ff3f71151d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144736
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [28f248a3397b50ae6047a7a907f5a159b1b1d310]

        Make namespace checks look through LinkageSpecs
        
        My clang-cl --with-visual-studio=2022preview build against VS 2022 Preview
        17.5.0 Preview 2.0 had started to fail with
        
        > [build CPT] compilerplugins/clang/test/getstr.cxx
        > error: 'error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/getstr.cxx Line 42: directly use object of type '{{(rtl::)?}}OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
        >   File compilerplugins/clang/test/getstr.cxx Line 48: directly use object of type 'S' (aka 'rtl::OString') in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
        >   File compilerplugins/clang/test/getstr.cxx Line 49: directly use object of type 'rtl::OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
        >   File compilerplugins/clang/test/getstr.cxx Line 55: directly use object of type 'rtl::OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
        >   File compilerplugins/clang/test/getstr.cxx Line 57: directly use object of type '{{(rtl::)?}}OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
        > 5 errors generated.
        
        apparently because
        C:/Program Files/Microsoft Visual Studio/2022/Preview/VC/Tools/MSVC/14.35.32124/include/ostream
        now contains
        
        [...]
        > _EXPORT_STD extern "C++" template <class _Elem, class _Traits>
        > class basic_ostream : virtual public basic_ios<_Elem, _Traits> { // control insertions into a stream buffer
        [...]
        
        with a wrapping extern "C++", so the call to StdNamespace() in
        
        >         if (!loplugin::TypeCheck(expr->getArg(0)->getType())
        >                  .ClassOrStruct("basic_ostream")
        >                  .StdNamespace()) //TODO: check template args
        
        in compilerplugins/clang/getstr.cxx no longer matched
        
        Change-Id: Iaeb461d5aa855a8602c5c6f791407c08a1c5d309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144735
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [00b2c42a838a95861cbba50bfeedc7afb10ff31c]

        -Werror,-Wshadow (clang-cl)
        
        Change-Id: Ib73b837ea23c2292877e77772ac80ea88f99a713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144737
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [2c6e919854e5a3f9873669d96ac735d1ec670c0d]

        loplugin:redundantfcast (clang-cl)
        
        Change-Id: Ie8fab41974392ddd3774b95ddee6c28e41cb5c36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7207e46264b464711874fb6da0f9249cb4cf334c]

        Added names for new Primitives to idToString (II)
        
        Change-Id: I43aa64afdd6b92beddc8484daa97babf4d6a6745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144690
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a31dd1e645b1b330e79291218e8ee0fbdd5b99eb]

        Corrected errors when Blur effect was re-used in shadow
        
        For GlowPrimitive2D and SoftEdgePrimitive2D I had to correct
        the view-dependent decomposition in the case where shadow
        was activated for the shape that was used. That creates an
        extra transformation, e.g. shadow offset, that needs to be
        taken into account, here by operating in discrete view-
        coordinates to solve the problem.
        
        NOTE: This is not needed for ShadowPrimitive2D itself when
        ShadowBlur is used due to the primitives this is based on
        are already handled with the needed offset.
        
        Change-Id: I87dd8db9467fbd27008d6154b78599f28057ce45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144693
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [482d86c493fd01b4c559436030738480792f6d47]

        Latest VS 2022 Preview is 17.5.0 now
        
        ...while latest proper VS 2022 is 17.4.3, so my Windows
        --with-visual-studio=2022preview build inconsistently picked up non-preview
        standard library headers, and failed
        
        Change-Id: I0c198d0f2e848b45afd5ffd09443d9643831f15a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144734
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [070d655e3fc127da3f2428b3f85f751ce9b8bdd1]

        Fix typo
        
        Change-Id: I996d18f76a04f822712687755b0ad51aa287d354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144713
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dcc6d0936460a4ad42062ab91fa0f0b30575ef97]

        Fix typo
        
        Change-Id: I50fc85e0ae8d75275fd1746c5e4aebe7e186cac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144035
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [5a14f009e6782c077463c8cbb8e9cea3d7950107]

        loplugin:unocast (xmlsecurity::Certificate)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I3d9bd77093d2e6376717d27f105e72ff5a919fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [f5b3bfbded8ea8d4a0b854a62c82b66747b45833]

        tdf#152535 Provide better localization for "Grand" subtotal strings
        
        As discussed in the bug report, having the word "Grand" hardcoded first in subtotals is not great for translation, since for some languages the translation of "grand" would come second.
        
        This patch creates separate strings for each case of Grand, f.i. "Grand Count", "Grand Sum" and so on. Now each of them will have their own translation.
        
        Change-Id: Ib875bc1a7b2fcc8934ad85bfe09374f8d9d9a179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144666
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [99009c9535dfa3e0d838989ccc7d84bfa2320ff4]

        loplugin:unocast (sd::Annotation)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Id600e83ae94409914b20a2a2620031ce340a9390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144698
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [0c7585c5fa78887e5459885ed744e8044fd76137]

        loplugin:unocast (sd::TextApiObject)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        The odd implementation of TextApiObject::getImplementation had been effectively
        like that ever since the code's introduction in
        5d431414afa79d392fe6a885940c559236c25aa2 "CWS-TOOLING: integrate CWS
        impressnotes01", for no obvious reason.  And as it can be reduced to a single
        comphelper::getFromUnoTunnel call, drop the function and directly call that at
        the (single) call site.
        
        Change-Id: If50a81cf8bee0dddbdfb5e6b5516c24a03e858e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144699
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [24e14afd1bfcaed6c200ab081973fba7e47267ca]

        loplugin:unocast (SignatureVerifierImpl)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I3c2f1eae3d9b2b5ecb6a05c9e7149946b63bb11f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Stephan Bergmann  <sbergman@redhat.com>  [1a7ad0c10d286ce9ae2700ceb2fd50eed1fb43a4]

        loplugin:unocast (pcr::PropertyEventTranslation)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I0800465df08a8caa4d48e205f181d3eb35611dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-22  Andras Timar  <andras.timar@collabora.com>  [17a8cb1573c5b75e5b7a6c480e09c681edcc26c0]

        check for null pointer
        
        Change-Id: I106b3de160ea70520aa98ad48d5f1005de6c6be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144700
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-12-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7db40989c530254b1a95a83e30e89e004f92e29d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 08d0004b7aa823bedc51c521919faf0d82fe24f2
          - update translations for 7.5.0 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: If01e073a30643a65862a5a7ec1b304448654566f
            
2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [2ce749a428d1df2c659ecfdaf2e151dd07d3f1b3]

        cid#1517814 Calling risky function
        
        Change-Id: I0451ac0375ad5a29a5bf65ebcc028ae44c43d934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [cb3108f860065928552a86cf8acc4b3a95718ecf]

        cid#1517812 Dereference null return value
        
        Change-Id: Ia9cf34f03a18e499f83e495c0f3714b7476c3973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Jim Raykowski  <raykowj@gmail.com>  [c73354b9f66ba436d933cc6558a38470e00c6ba8]

        tdf#152029 Headings can also use BringTypesWithFlowFramesToAttention
        
        Change-Id: If4c094471bda4e01151680dc1f356eefa48aa4f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144689
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [3ff4194a8acff9da2cad7776cfd57f82bc71ce25]

        ofz#54461 Null-dereference
        
        seen since:
        
        commit 96a856f87f16cca2e039c973c18d57c8b9dca362
        Date:   Fri Dec 16 13:20:25 2022 +0100
        
            tdf#152206 DOCX import: fix mixed first footnote
        
        Note: tdf#152506 is the correct issue identifier.
        
        Change-Id: I6e66db1a6a87cfce444346f193a418880750e03c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144692
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [f2e8422f2fc5753745ef272c621b24b0614c0ec7]

        sync with latest additions to d2dpixelprocessor2d
        
        commit 7d948d5c7edbbfd29a77b97a5101aa43917e5ec2
        Date:   Tue Dec 20 18:42:42 2022 +0100
        
            SDPR: Add handling/direct rendering of some simple Primitives
        
        Change-Id: If5432ac02f51f4b9194ec5df347f93e11f58959b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [3c70cfc93bf196503a59188ac0d7b93f8c1fe4af]

        tdf#152617 Fix color of controls in the Dialog Editor
        
        While editing dialogs in the Basic IDE the background of controls as labels, radio buttons and checkboxes is wrong. They're black in dark themes and white in light themes.
        
        The correct color should be FaceColor to make it have the same backround as the window.
        
        Change-Id: If436b0034dd7a665fc779e0df793703562adb5a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144363
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [ff46c8bf598481ae37022414f3495c1e9385eb7c]

        initial Experimental System-Dependent PrimitiveRenderer for Cairo
        
        just some partial pieces
        
        export TEST_SYSTEM_PRIMITIVE_RENDERER=1
        
        and the simple drawing shapes work
        
        Change-Id: I3e01501a1cb21ec86d6fe8f5637a23e7358ffc86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144632
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [179f50f810dfa1779de5c1f212f3887031e5567d]

        qa: hint about tolerance in names
        
        As suggested by Mike in https://gerrit.libreoffice.org/c/core/+/144171
        
        Change-Id: I653118985b781ebb1eed71587ae19efe45e1c800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144691
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-21  Miklos Vajna  <vmiklos@collabora.com>  [16075474819696f920979969474aa8300f4af530]

        sw, field insert: handle the Content param for refmarks and accept HTML there
        
        Creating a bookmark just to refer to it is a bit hacky, refmarks are the
        proper solution to that.
        
        But while .uno:InsertBookmark allows specifying custom HTML for the
        content of the created bookmark, there is no matching UNO command that
        would do the same for refmarks.
        
        Fix the problem by extending .uno:InsertField:
        
        - add a TypeName parameter, so TypeName=SetRef can be used in macros,
          which is more readable than Type=12
        
        - handle the previously ignored Content parameter when creating a
          refmark and accept HTML there to allow rich formatting
        
        Note that unlike bookmarks, refmarks are text attributes in a text node,
        so in case multi-paragraph HTML would be provided, the created refmark
        will only cover the content till the end of the first paragraph. Also
        not that unlike fieldmarks and bookmarks, a refmark can only represent a
        reference, not a bibliography, we'll need sections for that.
        
        Change-Id: I4d95f0a6e5618f1b611f7431e9189a63ee75d349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144646
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [47f66915f8d8f2418811417ad4b1109f31dee492]

        tdf#152606: sd_export_tests: Add unittest
        
        Change-Id: Ib34a5d312228570b05a84884189f7bd0b45af522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144650
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3fd53a92a6b94defe41704cd6b8ff15b81f5b089]

        Update git submodules
        
        * Update translations from branch 'master'
          to bd369936bec0c2cc1934026a09e4ceb361b7de7f
          - update Slovenian files for change in ulf structure
            
            see https://gerrit.libreoffice.org/c/core/+/144672 for details
            
            Change-Id: Ic59e538acd2736b7c7ea81a4936ff9cd27e2d882
            
          - update translations for 7.5.0 rc1 / master
            
            and force-fix errors using pocheck
            
            Change-Id: I374cdb4f45e7f52d049acd45bbcd728dbf9b6d9a
            
2022-12-21  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [fe8eb2c01e6f4c30eb593eb526892829dbba1804]

        tdf#140215 Simplify the handling of .ulf files
        
        Now the headings in the ulf files for .desktop files are
        in the form [filename_Key]
        
        Gallery names are also adjusted to fit the new scheme, where there is
        no longer a need to pass a --key argument to desktop-translate.py
        
        Sync comments with .desktop files and the remaining .ulf and remove
        obsolete Mandriva Linux meta data while at it.
        
        Script to mass-replace relevant names in translations will be
        provided to infra.
        
        Change-Id: I87e8028aa5b66f5f5560efa62ddd9b1e5b61c49c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138455
        Tested-by: Jenkins
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [87e7a2f60ec823aed6738fb081ad358b5d0536e6]

        cid#1517813 Uninitialized scalar field
        
        Change-Id: I119e6af448d80cf47dfe3f5bd7983ebf57221790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad3a1ed90fc5a19c0191ec572f12f359f98a0958]

        oox: fix crash in oox::drawingml::Transform2DContext::onCreateContext
        
        Similar to 68a259f5af8757923be8a226631f38366fe8e37b
        "tdf#152606: fix crash when opening specific pptx"
        
        See https://crashreport.libreoffice.org/stats/signature/oox::drawingml::Transform2DContext::onCreateContext(long,oox::AttributeList%20const%20&)
        
        Change-Id: Iac769edadb72590d8aef1ea3fc3845fce7a0bd86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144648
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [8efbc3e7f667bc1f04db4bcf908df905a1f34e06]

        sc: fix null deref in ScInputHandler::InputChanged
        
        See
        https://crashreport.libreoffice.org/stats/signature/EditView::ShowCursor(bool,bool,bool)
        and
        https://crashreport.libreoffice.org/stats/signature/EditEngine::GetText(LineEnd)
        
        Change-Id: Ib1486161c722c213ccc64809010f54e9ab4dc52e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144684
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [57d91a1ba839fde0f2826583ad9740f5ca1e246e]

        Use ScCellRangesBase's existing XUnoTunnel
        
        Change-Id: I1323a0aad06118397f39eec0f42494491df93f23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144680
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [5940427063f7a6ef914b65cf9e2396eb2cc828ca]

        Use ScModelObj's existing XUnoTunnel
        
        Change-Id: I2f0a6bbc5fe382a64d0a32ba955a28f44dad388c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144681
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [adb426d297503adc168e791036b5006185b911e7]

        Use ScNameRangeObj's existing XUnoTunnel
        
        Change-Id: I968484d9c140dd9407732c07b2bbc042f0342725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144679
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Caolán McNamara  <caolanm@redhat.com>  [701ec65fff1cc532f7ee7b8be3883c6a536e2c85]

        Resolves: tdf#152593 reuse Line Style preview code for Line Width preview
        
        Change-Id: I842b3bfaeb63978377ebb3edaef4dfd94ec296a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144651
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-21  galjit  <qmebic1975@gmail.com>  [b0331b9839888028c44f3139e32043f0550b9450]

        tdf#152598 Add more assets into .ico files
        
        Added 24x24 and 48x48 images into the .ico files
        
        Change-Id: I1a35428805643dc8d08ab36d3430769f143c75fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144677
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2022-12-21  offtkp  <parisoplop@gmail.com>  [be405c3f1843a381e951fcc63e4cc9d76002e73d]

        tdf#152378 a11y: Don't trigger check for empty highlighted text
        
        Do not trigger accessibility check test for empty highlighted text
        Also added an empty line in the test document to check that it's no
        longer detected after this patch
        
        Change-Id: I173a61fc25c0ea4cf81642a7ea37a762b3b583f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143673
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [a97e2d2702d9a6f37775ccee2c08c4f3b2479c4b]

        loplugin:unocast (RangePageBreaks)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I16297c96e60d76a15b59aedc4e88164bb782c61e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144652
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [19dfdf86ad1f5b08041d8b7a9f196caf881231ab]

        iloplugin:unocast (pcr::OFormattedNumericControl)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        (Making the base class pcr::CommonBehaviourControl TControlInterface template
        parameter variadic required swapping it with the other TControlWindow template
        parameter.)
        
        Change-Id: Iadc9dc7eb8fbe882b63b5db49d8a39ae5c4c05c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Roman Kuznetsov  <antilibreoffice@gmail.com>  [01249238dd9711aeec88721b9b24a390d2d0ac3f]

        tdf#152612 Add Duplicate page item to Pagepane context menu
        
        Change-Id: I49a889202c5a291b0da9eb970b838b657af2313a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144596
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9b1c218c9a4f09cac33fba24712bb9af029f2ea9]

        tdf#90641 - Insert bibliography dialog: sort entries by identifier
        
        Change-Id: I77210c1dff237deeb93df0102cd96685cb36d4f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144645
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-21  Michael Stahl  <michael.stahl@allotropia.de>  [abef9ea8aa99561e6f84451acf387abde4ec14ab]

        tdf#146875 sw: move also at-frame flys off SwPageFrame
        
        The bugdoc contains an at-frame anchored fly on page 77, which is
        anchored to an at-page anchored fly.
        
        While layouting page 74, the fly is moved to page 77, and the content on
        page 74 invalidated.
        
        Unexpectedly, calling RegisterAtPage on a SwFlyLayFrame does absolutely
        nothing, as it calls the base class SwFlyFrame, so the fly stays on page
        74.
        
        Thus, page 74 never actually becomes valid, and later pages are never
        layouted.
        
        (regression from commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf)
        
        Change-Id: I4fcbed4daf83f9e554de5a877a40b2c2419c0f2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144631
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-21  Jim Raykowski  <raykowj@gmail.com>  [5930f928e777ab95ed26619c43fa5ae334685deb]

        tdf#152029 follow up: Handle content that extends to following pages
        
        Brings section and table content to attention in the document view that
        extend to following pages. Previously only the frame area on the page
        these content types begin is brought to attention.
        
        Change-Id: Ia023e85cc7c14e0c50a0a0f9765a17fb207a95da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-21  Justin Luth  <justin.luth@collabora.com>  [8389048cb41291917449e87b2901d6133bce3373]

        tdf#151548 sw ContentControls: use ResetAttrs with undo.
        
        My initial commit adding SwTextContentControls::Delete
        didn't put it into the undo stack. But this slightly obscure
        ResetAttrs function can take this one argument and do the
        same thing, but with undo.
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testModernVBADelete
        
        Change-Id: Ibfcb278186b17aa3c3d9f1970e55ceb0ec00ddc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144238
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-21  Dennis Francis  <dennis.francis@collabora.com>  [db2757e110c1d99bc6128d80a0c6b9fd63982b89]

        vcl: /Filter [/FlatDecode] not properly read
        
        Change-Id: I156e153ae1a123cf9cf54eb23e6d3abe8962f677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143560
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit f5ad4f9dfac27d5675fa5c397f66b8cc45cc31a1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144435
        Tested-by: Jenkins

2022-12-21  Dennis Francis  <dennis.francis@collabora.com>  [9a45d2779ceaa1938feddf820d826922ed17854b]

        vcl: read references to /Kids array...
        
        if the argument of /Kids is not an array.
        
        Conflicts:
        	vcl/qa/cppunit/pdfexport/pdfexport.cxx
        
        Change-Id: Ib73962d3a27aa7e1ce5ddbe6845a1dd73bd7a343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143559
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 10185a6aec5d3b74a51e4b9474645e12bf794df8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144434
        Tested-by: Jenkins

2022-12-21  Julien Nabet  <serval2412@yahoo.fr>  [68a259f5af8757923be8a226631f38366fe8e37b]

        tdf#152606: fix crash when opening specific pptx
        
        bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=184264
        
        Related with 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0
        tdf#149551 separate TextRotateAngle from TextPreRotateAngle
        
        Change-Id: Idab19bee37c7a6fe1dc3818b6ff111389d290e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144588
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-21  Miklos Vajna  <vmiklos@collabora.com>  [85ec392132fa57025f7d70a5ccede912f1eb35e0]

        CppunitTest_sw_uiwriter2: simplify testRTLparaStyle_LocaleArabic
        
        Use comphelper::ScopeGuard the avoid the need for a separate preTest().
        
        Change-Id: I89cb89f86baf5da1671b05ddb368335d0b3d2ff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144628
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f43f00279252265fe4892b46fe0b4686ff721ed]

        No need for bool return value here
        
        all of the implementations of this method return true.
        
        Change-Id: I6dc02499af1809110edd482a48d9f6d5d42ead19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [f9785ea595fd8e911f6370e836fa579225b9e571]

        loplugin:unocast (frm::OInterfaceContainer)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ie8f6fbe25dfffc082033a4bc967d738143746506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144635
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [bc661b966fd82808a94e8684d62007c3f254d778]

        Use rtl::Reference to avoid some dynamic_casts
        
        (And some of those dynamic_casts could apparently never evaluate to null, and
        the corresponding checks have thus been dropped as being redundant.)
        
        Change-Id: I351d1c9f2894c5a88429ce3c7495f12145664743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144636
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [5e5f40a4a92a31b0932c690219d002fcf18598cf]

        loplugin:unocast (ScVbaShapes)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I913565ccd93472f2a8893c4251e80d0309827c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144633
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Stephan Bergmann  <sbergman@redhat.com>  [27b35b2c215b4832d4378ec3a7ecbba926552d06]

        loplugin:unocast (ScVbaShapeRange)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I4a66df07f2e768ee3203b730b50be4b9ec6a01a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144634
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-21  Justin Luth  <justin.luth@collabora.com>  [2e8776c181d0e38a8d25481ac0eb33389940bf95]

        tdf#151548: second cleanup "Add basic word::XFormField support" etc.
        
        Change-Id: I0647f29aa23959cbf9809cd745473e7b048901eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143079
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7d948d5c7edbbfd29a77b97a5101aa43917e5ec2]

        SDPR: Add handling/direct rendering of some simple Primitives
        
        (SDPR == SystemDependentPrimitiveRenderer)
        Make D2DPixelProcessor2D directly render the added simple
        Primitives
          LineRectanglePrimitive2D
          FilledRectanglePrimitive2D
          SingleLinePrimitive2D
        to use less ressources & get faster since no conversion to
        Polygons is done. These are Primitives that *may* be handled
        directly, but do not have to - I checked that the decomposes
        do work before adding direct handling.
        
        Change-Id: Ifa97c595c262d84a9889f92571b2c9909bcef0e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144626
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [a8c7e5ea607fbc5451a167ada35c6dff9c89abf6]

        sw: ODF import: fix assert in SwTable::ConvertSubtableBox()
        
        Assert in swnewtable.cxx:2179 fires:
        
        For ooo98643-1.odt the conversion is not possible, the default for row
        height is "variable" which wasn't handled.
        
        For ooo27428-1.sxw the conversion is possible so remove the assert;
        the sum of the inner row fixed height is just smaller than the outer
        row's but unsurprisingly the subtables is layouted such that the last
        row gets the extra space, same as the conversion does.
        
        (regression from commit 4757dfc2a520f63fba0b27cc161fe732231dbd0e)
        
        Change-Id: I2635179f350c8b5b84016dc82625b73364df92a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144622
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [45ece6e7fc4a1736dc5bbc5bd9b74b839ec81253]

        Fix no-pch build
        
        Change-Id: I913760fe4cb479ae1396512beed3b04e9275825f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144607
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [5cd8ea4d8a4fa8c5ac8e28be8fbc240caf070ff4]

        tdf#150823 sw: merge delete redlines in same paragraph
        
        The problematic merge was with a redline that spanned multiple nodes.
        
        (regression from commit 7d730cd580e957ab06b0c7f020ac37dd0c337aa2)
        
        Change-Id: Ie3fd23d102056b45833314143ec6381c1e9ef373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144615
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-20  Miklos Vajna  <vmiklos@collabora.com>  [21a2de9b5e5ae9be260456a10a7ba25a77e73b43]

        writerfilter: fix crash in DomainMapper_Impl::convertFieldFormula()
        
        Crashreport signature:
        
        program/libwriterfilterlo.so
                writerfilter::dmapper::SettingsTable::GetListSeparator() const
                        writerfilter/source/dmapper/SettingsTable.cxx:489
        program/libwriterfilterlo.so
                writerfilter::dmapper::DomainMapper_Impl::convertFieldFormula(rtl::OUString const&)
                        include/rtl/ustring.hxx:226
        program/libwriterfilterlo.so
                writerfilter::dmapper::DomainMapper_Impl::handleFieldFormula(tools::SvRef<writerfilter::dmapper::FieldContext> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&)
                        include/rtl/ustring.hxx:527
        program/libwriterfilterlo.so
                writerfilter::dmapper::DomainMapper_Impl::CloseFieldCommand()
                        writerfilter/source/dmapper/DomainMapper_Impl.cxx:6458
        
        Change-Id: I7f48f76cacffa00d633d92f0a51b2d82f96d1e74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144592
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-20  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [826b1f36bd96328e198452e0f8d5c87b2f3fb203]

        tdf#146781 sc: update extended tip for function description search
        
        Change-Id: Ifa8f5c2be8e848e6fe2f9cf863d4a5a66787d2d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144153
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-20  Aurimas Fišeras  <aurimas@members.fsf.org>  [a207cbfb0606f9c487c10fedbfe0a4b3e6fd2933]

        Rename function to match what it does and remove obsolete comment
        
        Change-Id: I6807dddc6dbe54ec582d839e5eebd2a6375bfe6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143841
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-20  Caolán McNamara  <caolanm@redhat.com>  [102b338d4d97b1f07c75c76d56027d976a0ca28d]

        crashtesting: assert on import of forum-mso-en4-253564.xlsx
        
        source document contains a timestamp formatted as:
        
        2011-010-31T00: 00:00Z
             ^^^
        Change-Id: I604ffa69189280faf9d7f55dae472cf9fe1b6763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-20  Justin Luth  <justin.luth@collabora.com>  [29386030a96f2c8b1c636f4d4bb283109e01de8b]

        tdf#142147 saveas: encrypted docs should default to use password
        
        If a document is currently encrypted (pOldEncryptionDataItem),
        when the user saves as a different name, the save dialog should
        BY DEFAULT have the "Save with password" option enabled.
        
        That makes sense, right? If the document was secure enough
        to require a password, then any copies of it should
        AT MINIMUM suggest a password.
        
        Anyway, it worked that way prior to LO 7.0's
        e0cced9d4c94324e834e46d807469a0cd6c1f738.
        
        The concern was that the same password would be applied
        silently. That might have been true with 7.0.
        However, in my current testing that never happened.
        It always prompted the user to create a new password.
        And that is exactly what I would want on a SAVE-AS,
        whether it be from a template or a file I was copying.
        
        I would hope that this has no bad implications for headless RT.
        After all, this is just a "suggestion" passed to guisaveas.cxx.
        I did not find any parameters to provide a password
        via commandline anyway.
        
        Change-Id: Id3535d883cd5d2d1427055f7a21f6ae87e0d5324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143250
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-20  offtkp  <parisoplop@gmail.com>  [cbca5617387aaa39c9ee86272166bb3df7874b25]

        tdf#125338 Do not export macros when saving as .docx
        
        Docx files that have macros should be saved as .docm. Now displays a
        warning that macros won't be saved if exporting a .docm as a .docx and
        doesn't export them.
        
        Change-Id: I178855baa6c0a7d32fd9b00c83a817230b33a1a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144197
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-20  Patrick Luby  <plubius@neooffice.org>  [5c98d8e79b4b35d30f1198f8c7b4beef44e421f4]

        tdf#151341 Use lzfse compression instead of bzip2
        
        Several users reported that copying the LibreOffice.app package
        in the Finder from a .dmg file compressed with lzfse compression
        copies the package several times faster than from a .dmg compressed
        with bzip2 compression.
        
        On a mid-2015 Intel MacBook Pro running macOS, copying in the Finder
        was at least 5 times faster with lzfse than with bzip2. Also, the
        hdiutil man page as of macOS Monterey 12.6.2 has marked bzip2 as
        deprecated. lzfse is marked as supported since macOS El Capitan 10.11
        so this change appears safe.
        
        The one thing that bzip2 has is better compression so a .dmg with
        bzip2 should be smaller than with lzfse. A .dmg built from a debug
        build was 262M with bzip2 and 273MB for lzfse. So it appears that
        lzfse creates .dmg files that are only 4% or 5% larger than bzip2.
        
        Change-Id: I61e2a08cede19a5bb8c257d4fa4762168a3a9dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144342
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4b67515418ee4f10071b3f0f2275ba37f32b0ae5]

        gbuild trace: make it work nicer on macOS (seconds-only accuracy)
        
        the finish-gbuild-trace.py matches a nanoseconds timestamp and truncates
        it to milliseconds, so could also adjust that and look for the unchanged
        %N for mac in the tracefile and handle it that way, but since there is
        another conditional needed for the lack of flock on macOS doing it in
        the makefile seemd like the more natural choice. (well, not trictly
        needed unless you mind the thousands of command not found messages :-))
        
        Change-Id: I768bc9dd8be232567644ae000b6419bb87f58509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144590
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0904f6ccc1a378743d1db56d330a691d90ba9720]

        gbuild trace: fix mismatching start/end category in Extension.mk
        
        Change-Id: Ia4320ae7d4d7345f280bdb29f938a338970238f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144589
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fbd89e8723bf989aa817ad6724dcf60a93c3b5dc]

        fix gbuild trace when building with translations
        
        the gb_Trace_StartRange expands to
          echo "…" >> logfile
        if tracing is enabled, so when using line-continuation it needs to be
        terminated with a ; to not cause syntax errors when making the target
        (or as in this patch moved to a location where it can be a recipe line
        by itself)
        Furthermore the startRange and endRange calls were split across the two
        different branches of the $(if ..) function, so tracing never worked,
        even when not building with translations - there it just didn't break
        the build…
        
        Change-Id: I601f516872cb9a099eae642bbd8629e75e8250cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144542
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-20  Christian Lohmaier  <cloph@documentfoundation.org>  [b332f036acc64ef71acab07bb2cfab589500b7ed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77757ab8b2e4f6f8df04d5c6eafe73a3d8844ed9
          - add gbuild trace annotations for targets in CustomTarget_html.mk
            
            at least for those that are not a simple cat, echo/printf or sed call
            
            Change-Id: I81e7682890a011aaea2603ef4c0a2e71d82a8511
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144591
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-20  Attila Szűcs  <attila.szucs@collabora.com>  [b66e35c721742d2ad1c8c2cc3251661b6ce81952]

        tdf#152581 SC: fix export of conditional border color
        
        Call XclExpDxf::mpBorder->SetFinalColors(..) during export, before SaveXml().
        It will calculate the prepered colors from mnLeftColorId to mnLeftColor,
        so saveXml() will be able to save it.
        
        Change-Id: I1a1eccccd621c6d0e883cb9016e60ae0b344bf90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144576
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f09c5f925dbfc32829b2c6a81f43290b4d3512e]

        basic: remove tabs from test file
        
        Introduced in c6dc676306d2e507bf57369d02dcaf2408d43eb0
        "tdf#152520: basic_macros: Add unittest"
        
        Change-Id: Ieef7177b3eb1c7c4ab1aaa11cc343ace3f26601f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-20  Miklos Vajna  <vmiklos@collabora.com>  [1feb1aa08421f9d0934ab65ce94cf6054818c0f3]

        sw: fix ODT import of paragraph marker formatting
        
        The DOCX bugdoc had a numbering portion which was not bold, even if all
        characters in the paragrpah was bold. This was rendered fine, but once
        it was saved to ODT + reloaded, the numbering portion became bold as
        well, which is buggy.
        
        What happens here is that there is one span that covers the entire
        paragraph (and is bold) and there is an empty span at paragraph end
        (which is not bold), so the ODT export is fine. But once we import it
        back, the first span gets "upgraded" to paragraph-level formatting
        (because SetAttrMode::NOFORMATATTR is not used when inserting the hints)
        and the second span is not mapped back to the original
        RES_PARATR_LIST_AUTOFMT in the text node.
        
        Fix the problem by 1) improving SwXTextCursor::setPropertyValue() to
        work with SetAttrMode::NOFORMATATTR when multiple spans are inserted and
        by 2) extending SwUnoCursorHelper::SetCursorPropertyValue() to create
        RES_PARATR_LIST_AUTOFMT for empty spans at paragraph end. This way the
        original doc model and the one created after ODT export + import is much
        closer to each other.
        
        This builds on top of 6249858a8972aef077e0249bd93cfe8f01bce4d6 (sw: ODT
        import/export of DOCX's paragraph marker formatting, 2022-12-19),
        previously the ODT export and import of paragraph marker formatting was
        completely missing.
        
        Change-Id: I139e11217dcbc18744aeeb80638090781aa74933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144587
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [a179da299a7daaa13f7d6fa3612f82eeb186f0d1]

        basic: add missing license statement in .vb test files
        
        Change-Id: I304615540edad3d3486bcdb17d7d6ae12fc084b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144584
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [fe589d8e5465320f49feeb41d493f84e630bced3]

        Added two simple tooling Primitives for easy/common cases
        
        Added three simple tooling Primitives:
        
        (1) SingleLinePrimitive2D:
        Just a Line from Point A to B with a BColor, decomposes
        to a PolygonHairlinePrimitive2D (and to a PointArrayPrimitive2D
        if only a single point aka A == B)
        
        (2) LineRectanglePrimitive2D:
        (3) FilledRectanglePrimitive2D:
        Rectangles that support fill or line, gets decomposed
        to maybe PolyPolygonColorPrimitive2D (if filled) and a
        PolygonHairlinePrimitive2D (if line) or nothing if the
        B2DRange is empty
        
        NOTE: If using these despite being hor/ver aligned due to
        their nature as B2DRange(s) (aka 'non rotated/sheared')
        these may have to be transformed if the current
        transformation context you are working in is rotated
        or sheared, so *ensure* to handle these correctly if
        you do handle them yourself. This is not needed with
        the Polygon-based ones - that's why these are - and
        stay - the common case(s).
        
        Both are hairline primitives themselves, so are potentially
        *view-dependent* (see comment in *.cxx and *.hxx). They will be
        useful as very simple primitives for small renderers, e.g. to
        avoid conversion from rectangles or just lines to polygons.
        
        The more general Primitives are always the polygon-based ones,
        so these new ones get decomposed to these (decomposition direction,
        complex -> simpler). This assures that a processor/renderer has
        minimally to support the polygon-based ones, but *can* use these
        simple tooling ones directly if he wants to.
        
        This will come in handy for future System-Dependent PrimitiveRenderers,
        which I am currently working on one to offer as example - this leads
        to identifying helpful upstream things that will come in handy in that
        regard - like these ones.
        
        Change-Id: Ie5039e6cfad6c9914c165cae6f8b59abecc38302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144543
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-20  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [74f51d5ecd0bbeedff7b52d28294828c0726def4]

        Added BColorModifier_randomize for visualization testing
        
        This BColorModifier is able to blend a color against a
        randomized one, by the given amount. This is useful for
        testing purposes in th eliving office when making
        interactive tests with it.
        
        Change-Id: I96d8b83397783201080682cd4bd75779ef77b238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144541
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [5f29cb2fad3481889adec0c2dd242f7288ad169d]

        Example System-Dependent PrimitiveRenderer for Direct2D (Win)
        
        As promised at LiBoCon'22 I have finished an example
        implementation of a System-Dependent PrimitiveRenderer.
        
        It renders on Direct2D, so Win only. I chose this with
        no special thoughts, did not even know too much about
        Direct2D, so had to read quite some docu. Still managed
        to do this in a view days.
        
        NOTE: To make it run you need to switch off skia on Win
        probably due to some global extra stuff done there (?)
        
        The Renderer is in a new file (ca. 1000 lines) in the
        drawinglayer libary. It implements all of the needed
        primitives, so capable of rendering EditViews (Draw/
        Impress complete, Writer/Calc in parts, interactions,
        overlay, selection(s), etc.). It is used completely
        as replacement of the VclPixelProcessor2D which is
        not used in the patched version *at all*.
        
        Just one primitive is missing:
        - InvertPrimitive2D: Not needed much (hopefully will
          vanish), could also be added
        
        It is not in production state, mostly intended as a
        demonstration how Primitives are intended: Render
        *without* using an OutputDevice at all, directly to
        the traget GraphicsSystem. It can (and should) be
        used as pattern for other implementations.
        
        NOTE: Inside the implementation you can do whatever
        you want, all is allowed. Only rule is to visualize
        the geometry defined by the Primitives.
        
        This version does not need any buffer allocations to
        render and is thus pretty fast (uses ID2D1Layer). It
        also has no buffering, but that could easily be
        added. The needed classes/implementations to buffer
        system-dependent representations of data exist,
        so doable fast for Bitmaps, Polygons and PolyPolygons.
        
        It runs stable and fast, but still has errors, so
        it is sometimes missing to render some stuff. I
        would have to debug/finetune it further, but I see
        this all as doable. It's far enough to be seen as
        POC and example.
        
        I also added a not-urgently-need-to-be-implemented
        primitive, the UnifiedTransparencePrimitive2D, to
        demonstrate how to do that: Add a handler for it
        and render the defined geometry if you can do that
        more direct/better than the decomposition.
        
        The rough to-do list would be:
        - add missing Primitives
          - InvertPrimitive2D
        - add buffering of
          - Bitmaps
          - Polygons
          - PolyPolygons
        - add TextRendering
          - using decompose to PolyPolygons currently, but
            looks reasonably good with PolyPolygon AA
        - general
          - polishing
          - bug fixing
          - stabilization(s)
          - speedups by adding PrimitiveHandlers
        - solve problem with TransparencePrimitive2D
          - had to use drawinglayer::createAlphaMask
            there, see comments
        
        Made handling of TransparencePrimitive2D work, some fixes
        and changes, too.
        Still not happy with processTransparencePrimitive2D, it
        uses drawinglayer tooling (createAlphaMask) to do it's
        job. It works, but there must be a better way. It's
        okay for demonstration/POV though
        
        Tried hard in processTransparencePrimitive2D to directly
        render the alpha channel to a Direct2D
        ID2D1BitmapRenderTarget using DXGI_FORMAT_A8_UNORM.
        It does work theoretically as it should, but I found
        no way to directly paingt to the AlphaChannel. It
        seems as if Direct2D *is* hard-wired to always
        alpha-blend, there seems to be no control or mode
        to *select* the BlendMode to be used. Since only that
        small step is missing I keep that code in (see
        bTryDirectPreparationOfAlphaAsBitmap).
        NOTE: No idea yet, but testing shows that the direct
        but not yet complete way is ca. 7 times faster.
        
        I have now added PointArrayPrimitive2D, so only that
        InvertPrimitive2D is missing.
        I also added MarkerArrayPrimitive2D to make it more
        efficient (marker bitmap gets converted only once)
        and better looking (not AAed anymore).
        With both added, grid visualization looks good and is
        fast.
        
        Added support for BackgroundColorPrimitive2D
        
        Added BitmapBuffering for Direct2D. This is a little
        bit more complicated, theoretically all ID2D1Bitmaps
        are specific to the ID2D1RenderTarget they get created
        for, so theoretically they have to be (re)created
        every time the ID2D1RenderTarget aka OutputDevice
        changes - argh.
        There is CreateSharedBitmap though that
        allows re-usage of already created bitmaps for a new
        RenderTaget, but this leads to needing a LO-livetime
        RenderTarget to create all the Bitmaps for.
        So I implemented that and it works and is fast.
        
        Added buffering for GeometryData, ID2D1PathGeometry.
        I prepared this already using the
        CreateTransformedGeometry functionality of Direct2D,
        so the B2DPolygon/B2DPolyPolygon can get buffered
        in an unchanged form, re-used as source for
        creating a ID2D1PathGeometry by calling
        CreateTransformedGeometry. This could also be done by
        manipulating the current transformation, but is not
        necessary.
        
        Simplified buffering by directly using derivated
        helper classes (from basegfx::SystemDependentData)
        as data holders, thus they can reliably call
        Release() at incarnated Direct2D instances without
        the need to keep record of this outside.
        
        Completely removed OutputDevice from the
        D2DPixelProcessor2D, it was anyways only used in
        the constructor.
        
        Removed the need to hand over the pixel size of the
        pixel target when constructing a D2DPixelProcessor2D,
        instead get that values from HDC directly. Also made
        D2DPixelProcessor2D exported from drawinglayer for
        further experiments.
        
        Checked if I can use higher-level Direct2D versions
        by using MS's QueryInterface to see if involved
        classes are higher-level ones. This worked and
        allows to paint the alpha channel for
        TransparencePrimitive2D now indeed using the
        BlendMode that is missing in the initial D2D stuff,
        so activated that (much faster).
        
        Aded the environment variable (for Windows only)
        TEST_SYSTEM_PRIMITIVE_RENDERER to allow easy tesing
        of SystemPrimitiveRenderer. Since Skia enabled
        does collide in quite some places (see above) I
        added hat this also disables Skia in it's central
        isVCLSkiaEnabled() method. That way it is easy to
        compare/quickly change between versions.
        
        Removed maCurrentTransformation, this is just not
        needed for a pixel-only renderer, see comment in
        VclProcessor2D's header regarding that.
        
        Added snap-to-pixel functionality.
        
        Added direct support for PolygonStrokePrimitive2D,
        so all lines which
        - are fat or thin
        - have LineCap
        - have LineJoin
        - use dash
        can be directly rendered by Direct2D. This is especially
        good for dash since no decompositions will be created
        for these cases.
        There is an exception for our own rarely used style
        B2DLineJoin::NONE, that still needs to be decomposed,
        but could also be added to the impl if needed.
        There were also quite some 'conditions' for supporting
        B2DLineJoin::Miter in Direct2D, but I managed to solve
        them all, so Miter is fully done in Direct2D in this
        example.
        I also added example debug code to demonstrate how
        it is possible to simply add decompose paint and the
        system-specific implementation to optically compare
        and play around in a running office to identify
        possible problems/differences.
        
        Improved handling of TransparencePrimitive2D massively
        to a more future-proof and more common methodology by
        using the Direct2D mechanism ID2D1Effect and the
        CLSID_D2D1LuminanceToAlpha effect. For details, see
        comment in comitted code at implCreateAlpha_Direct.
        
        As explained in refs/changes/87/141087/22 I did add
        now a tooling derivate of D2DPixelProcessor2D that can
        be used to render sub-content without having to deal
        with patching the current internal state of the running
        instance, called D2DBitmapPixelProcessor2D. It resides
        in the cxx file (so being safe from other usages), has
        and creates an own ID2D1BitmapRenderTarget to work on
        and will come in handy for other occasions that need
        to prepare a in-between result.
        
        Made stuff in the renderer itself more private and
        added access methods to protected section, use
        those in tooling.
        
        Change-Id: Ie5803f9afa3f62dbaa8fd2f1bac8fd30a23066b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141087
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-20  Caolán McNamara  <caolanm@redhat.com>  [bbc5bd1a5fca98e952177e0514c7c17f95ed2083]

        make inclusion of config_host.mk unconditional
        
        to get make vcl.build not to error with
        
        core/solenv/gbuild/LinkTarget.mk:932: *** used LinkTarget StaticLibrary/libzlib.a not defined.  Stop.
        make: *** [Makefile:121: vcl.build] Error 2
        
        since:
        
        commit b688b779ba20a4bec653808a42fe88cfac851029
        Date:   Fri Dec 16 18:41:13 2022 +0100
        
            keep environment clear of SYSTEM_FOO vars
        
        Change-Id: I14c3b09ad8e2ce97066995ed63d67243b8ca4a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144586
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [d35d01937ac77a12b06c1884dae2ec53998cf088]

        editeng: avoid divide by zero
        
        Prevent mnColumns from ending up in a zero state.
        
        See
        https://crashreport.libreoffice.org/stats/signature/ImpEditEngine::CreateAndInsertEmptyLine(ParaPortion%20*)
        
        Change-Id: I9137a0de33743ba514526cc28f4afef018de3614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [383c309baac455f23ca78df031996cf2b56385d6]

        git pre-commit hook: check .bas and .vb files as well
        
        Those are used in basic/qa
        
        Change-Id: Idf444bbd540d3f23450db1586489f27df64e09a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144582
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-20  Stanislav Horacek  <stanislav.horacek@gmail.com>  [c4e732c27f552da59681045413288988b3425688]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e68b5fe156bd211439793e0c8ed8b290a7c39ae
          - fix links to Put command page
            
            reported by Kamil Landa
            
            Change-Id: I415526d6bfcd6aec300fcacfd74ff101ac610969
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144577
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-20  Stephan Bergmann  <sbergman@redhat.com>  [1bd8f26a914c4d5811fd063618aff8e8bf72e023]

        Revert "fix compile error in compilerplugins"
        
        This reverts commit 99b5e216f107259d6e402896800282948997c4fa.  It should only
        have been necessary after
        <https://github.com/llvm/llvm-project/commit/205c0589f918f95d2f2c586a01bea2716d73d603>
        "Revert '[clang] Convert OptionalFileEntryRefDegradesToFileEntryPtr to
        std::optional'" dropped the #include <optional> from
        clang/include/clang/Lex/PPCallbacks.h, and has been obsoleted by
        3d7181caf3444d086be910545047550bac618968 "Adapt to
        PPCallbacks::InclusionDirective change in Clang 16 trunk".
        
        Change-Id: I89238a779fdda4c3ba15de93a4e647051e5844b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144594
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-20  Leonid Ryzhov  <leoryzhov@gmail.com>  [3cc818c38e11c0882bc3ad32ffd0019a9ad38643]

        tdf#114441 Convert use of sal_uLong to better integer types
        
        sw/source/filter/html/parcss1.cxx: all variables are temporary storage for values of type sal_uInt32;
        sw/source/uibase/uiview/scroll.cxx: nVisSize removed, GetVisibleSize() used as parameter in the setPageSize();
        sw/source/uibase/utlui/glbltree.cxx:int is used for nSelCount; int is used for nSource, nDest and nEntryCount;
        
        Change-Id: Ifdf4de276306bc3b89f6e1198fe03ec94aefd18e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143746
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-12-20  Michael Meeks  <michael.meeks@collabora.com>  [50a08d1eb47f8faeb511cec43d1f8ba12b8f27f7]

        tdf#148434 - avoid strange OS/X deadlock around AnyInput.
        
        Apparently calling AnyInput on Mac and filtering for just input, gives
        you window creation / re-sizing events which then trigger idle paint
        events which then deadlock if called with the scheduler lock.
        
        Try having a little more inefficiency and a different race for
        this case to handle the Mac world.
        
        Change-Id: I9985eaf18f8d0ba4d44e83c03746510a6ba6d664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f0cf6e7aa75e8724e13e731be09271c7e536e93]

        basic: add missing license statement in test files
        
        While at it, convert test_optional_paramter_type.bas
        to Unix format
        
        Change-Id: I141fa0a00d6b6784c3a84c8b3041086d51e5cdbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144540
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-20  Stephan Bergmann  <sbergman@redhat.com>  [feba0ddb1521d1142560fe54b7d7696ee910237f]

        loplugin:unocast (weld::TransportAsXWindow)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        On macOS, where we implicitly use -fvisibility-inlines-hidden-static-local-var
        since
        <https://github.com/llvm/llvm-project/commit/d46f2c51e4c849683434bb5a0fb6164957474b8f>
        "Make -fvisibility-inlines-hidden apply to static local variables in inline
        functions on Darwin", the static id local var in
        weld::TransportAsXWindow::getUnoTunnelId cannot be in an inline function
        implicitly hidden via -fvisibility-inlines-hidden.  Explicitly marking the
        function as VCL_DLLPUBLIC would help, but would in turn cause MSVC error 2487
        ("member of a dll interface class may not be declared with dll interface").  So
        just make the function non-inline in a new vcl/source/window/weldutils.cxx
        (which would arguably be the best approach for the whole class, anyway).
        
        Change-Id: Ib5615f6aae19346ea05b8b85ff77c0e5ea860994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144331
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-20  Caolán McNamara  <caolanm@redhat.com>  [f6b4c3fb68f9b36e1e64fc4a4c680ab1bb7fb013]

        cid#1517796 Out-of-bounds read
        
        Change-Id: I930e3888cfa3363b9183619225f0d4cdca197cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-20  Stephan Bergmann  <sbergman@redhat.com>  [bb692dd15d3c32e85f193c3f60c7917f2b1e13d2]

        Use SecurityEnvironmentGpg's XUnoTunnel instead of dynamic_cast
        
        ...where 88ac77c0bc21accfd6f5c404217c3c2aaef2d674 "gpg4libre: List and view GPG
        keys" had introduced SecurityEnvironmentGpg complete with (apparently unused)
        XUnoTunnel, but then cae5f2a543b31552ccd9765aca5eb514fa694e07 "gpg4libre:
        initial GPG signature generation" and 0e226d4c193824d79f71d6918038de48afffaf26
        "gpg4libre: initial GPG signature validation" had failed to make use of it.
        (See the upcoming commit introducing loplugin:unocast on why such dynamic_casts
        from UNO types are dangerous.)
        
        Change-Id: I29cc5c1cec9c2e98528c7257993f300d131bf41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144509
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fe55893af1f62219f9ebb1da9527ce8aa0fbd81]

        Adapt to PPCallbacks::InclusionDirective change in Clang 16 trunk
        
        Attempt to follow the unfolding debate here, it was std::optional
        briefly, but then that was reverted with
        
            commit 205c0589f918f95d2f2c586a01bea2716d73d603
        Revert "[clang] Convert OptionalFileEntryRefDegradesToFileEntryPtr
        to std::optional"
        
        and then a different changed landed with
        
            commit 854c10f8d185286d941307e1033eb492e085c203
            Date:   Tue Dec 20 00:15:11 2022 +0100
            [Clang] Prepare for llvm::Optional becoming std::optional.
        
        Change-Id: I0068960a45695014405437206d8d4565562b0af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Miklos Vajna  <vmiklos@collabora.com>  [6d5262209a89127880c888c2ef0dc4e0da7f6ea1]

        sw: document SwFormatColl
        
        I.e. first what's confusing is that SwCharFormat doesn't derive from
        SwFormatColl, and the answer is that in practice it doesn't matter too
        much, as long as in practice user-visible char styles are SwCharFormats
        where SetAuto(false) is called in some other way.
        
        Change-Id: Ie85f9bf947348b5ef7051f055c5b931a8a2b932a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144544
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6dc676306d2e507bf57369d02dcaf2408d43eb0]

        tdf#152520: basic_macros: Add unittest
        
        Change-Id: I30f6badc620f3932cacff07bd37ef4da96f1bafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144539
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [99b5e216f107259d6e402896800282948997c4fa]

        fix compile error in compilerplugins
        
        home/noel/libo2/compilerplugins/clang/includeform.cxx:33:9: error: no
        template named 'optional' in namespace 'std'; did you mean 'Optional'?
                std::optional<FileEntryRef> File,
        
        after
            commit b5023fa9abea248831271df99df0810351bd8c21
            Date:   Mon Dec 19 13:16:29 2022 +0100
        Adapt to clang::PPCallbacks::InclusionDirective change in Clang 16
        trunk
        
        Change-Id: I7acbfeac4fd138a1f6ae89f8b4b8cf918da04e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Stephan Bergmann  <sbergman@redhat.com>  [5c7accf3e1d7bd550611af42d2eea07e590fde2f]

        Use XUnoTunnel instead of dynamic_cast here too
        
        ...like in other code accessing X509Certificate_NssImpl. (See the upcoming
        commit introducing loplugin:unocast on why such dynamic_casts from UNO types are
        dangerous.
        
        Change-Id: I65c8380ef0c3ab34a41142639e0e6fbfb4154b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144510
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-20  Andras Timar  <andras.timar@collabora.com>  [241cd824fdd4bf02f393633c1e19d24f2f35f1c0]

        lok: hide 'View PDF after export' checkbox in PDF export dialog
        
        Change-Id: I866e4765ba88ca6c93375c9fecd51f22b79ce72e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144535
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [35d8b4c36299df39de36f2c7ade5727fc525eaab]

        lok: hide customization in EPUB export dialog
        
        Change-Id: I531aba2eb52e74904b6cba82add769d35a8a28c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144150
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144534
        Tested-by: Jenkins

2022-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [63eed8ff31311fc266791df48cc03a644f665b11]

        lok: hide signatures in PDF export dialog
        
        Change-Id: Idd67e7ffe4dffc89555d75773501908165cbdd7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144149
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144513
        Tested-by: Jenkins

2022-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a5d85e76f12d1819b0ed1d5b531e731e57c201c]

        new loplugin:implinheritancehelper
        
        Look for places we should be using ImplInheritanceHelper, which handles
        various boilerplate for us
        
        Change-Id: Icff6babf682c95b60aca86e6d6c2e2181eefc2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144444
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5465a60ec2637707479487f839341da5dc8fd2cd]

        loplugin:implinheritancehelper in xmlhelp
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: Ie8104d40dd13b02f19bcaf1806255446d17b25a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144443
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-20  Bogdan B  <buzea.bogdan@libreoffice.org>  [5cb7fed2a5a02ff1cb4551752a0bd8d3001a1f22]

        tdf#152463 Turn on AutoSave and Backup by default
        
        Change-Id: Icc29bfa8a752be75c4ffa9eb8b939008297105bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144020
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [fd839a7f7a0480df0c4bef3029dea0f97c0dd406]

        lok: remove undefined behaviour warning
        
        Change-Id: I74d015bdf2c30b85c8e9eb8271780c9999ea1f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144169
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144536
        Tested-by: Jenkins

2022-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [d3d76fe4138f0a27306480e4e71394cda6078ee5]

        lok: export PDF/EPUB with extension
        
        Change-Id: Ib266814d88a4f121959cb21f40293d671f242448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143989
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144512
        Tested-by: Jenkins

2022-12-20  NickWingate  <nick.wingate@collabora.com>  [89f5912ad2eee786508414791653a017206a7c04]

        Async PDFExport dialog and parent methods
        
        Filter dialogs are all called generically from
        guisaveas.cxx in GUIStoreModel()
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: Idfbe85c09f84d4a7cf3f00b9704d5af94868a051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140403
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144511
        Tested-by: Jenkins

2022-12-20  Szymon Kłos  <szymon.klos@collabora.com>  [34709aa3f4f166879004670e60ff3b37ad3eacd5]

        Make EPUB Export dialog async
        
        (cherry picked from commit 9461b0e1385b87d2490bf9402729fb9e912395e9)
        
        Change-Id: Iead5b4ff6064395fd5abbcdea73db38415dbb37c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144514
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-12-20  Justin Luth  <jluth@mail.com>  [70d9e7eadb1069b5e7a1909c671b9348b740cca1]

        tdf#85592 android: .uno:BackColor deprecated, use .uno:CharBackColor
        
        Follow-up. I didn't want to include it in the main deprecation patch.
        No good reason - android is just too different and untestable by me.
        
        Change-Id: I661211aea619af256e38dc685fdd0662e5aa7272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140284
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2022-12-19  Caolán McNamara  <caolanm@redhat.com>  [ee767c14530ad1fb8b7660e9352199f185fe61dc]

        Resolves: tdf#146933 wire up keypress events for table control widgets
        
        Change-Id: Idc8cc3c24d061537a76a37f4fa84951a41a42657
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144470
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [d7ada1052f9c237755e7b199274b52842861da40]

        -Werror=maybe-uninitialized
        
        Change-Id: Id243f28f267a5ea22625e277d6272f8514d33ad9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144469
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [652202f0ee2fe2891f09ac9a1c6a87e944e7bb22]

        Use XUnoTunnel instead of dynamic_cast here too
        
        ...like in other code accessing XMLElementWrapper_XmlSecImpl. (See the upcoming
        commit introducing loplugin:unocast on why such dynamic_casts from UNO types are
        dangerous.)
        
        Change-Id: Ib67332dd2d6a1aa31f5515940fdd6f4a9f638bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144508
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [7dd0b4c06d380637570e1edbefab5d40a246edf1]

        Use XUnoTunnel instead of dynamic_cast here too
        
        ...like in similar code introduced in the initial
        88ac77c0bc21accfd6f5c404217c3c2aaef2d674 "gpg4libre: List and view GPG keys",
        but which was then apparently forgotten in this code later introduced in
        06929219aeb0cb3550bf0cf8b5de7f1164c00a8d "gpg4libre: Show whether pgp keys are
        trusted or not".  (See the upcoming commit introducing loplugin:unocast on why
        such dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I6606d0fa0be515a45a190d2da7e16d5b712bfc4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144507
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [6c63fca23fdf0072f7455cb42157cc3cb6187466]

        Avoid -Werror,-Wdeprecated-declarations
        
        ...when building against recent Clang 16 trunk,
        
        > In file included from compilerplugins/clang/sharedvisitor/sharedvisitor.cxx:30:
        > In file included from compilerplugins/clang/cppunitassertequals.cxx:13:
        > compilerplugins/clang/compat.hxx:40:14: error: 'value' is deprecated: std::optional::value is throwing. Use *X instead [-Werror,-Wdeprecated-declarations]
        >     return o.value();
        >              ^~~~~
        >              *X
        > compilerplugins/clang/pointerbool.cxx:118:52: note: in instantiation of function template specialization 'compat::value<llvm::APSInt>' requested here
        >             if (compat::has_value(ret) && (compat::value(ret) == 1 || compat::value(ret) == 0))
        >                                                    ^
        > ~/llvm/inst/include/llvm/ADT/Optional.h:273:3: note: 'value' has been explicitly marked deprecated here
        >   LLVM_DEPRECATED("std::optional::value is throwing. Use *X instead", "*X")
        >   ^
        > ~/llvm/inst/include/llvm/Support/Compiler.h:143:50: note: expanded from macro 'LLVM_DEPRECATED'
        > #define LLVM_DEPRECATED(MSG, FIX) __attribute__((deprecated(MSG, FIX)))
        >                                                  ^
        
        Change-Id: I4320c279a464e52ad608df2a340f62795558a7b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144472
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [b5023fa9abea248831271df99df0810351bd8c21]

        Adapt to clang::PPCallbacks::InclusionDirective change in Clang 16 trunk
        
        <https://github.com/llvm/llvm-project/commit/8f0df9f3bbc6d7f3d5cbfd955c5ee4404c53a75d>
        "[clang] Convert OptionalFileEntryRefDegradesToFileEntryPtr to std::optional"
        
        Change-Id: I60bf4a770d6037edcfe0129591fd46941c8903db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144471
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Justin Luth  <justin.luth@collabora.com>  [8b39cdfa8d725d65bbcb372b7cbf8ee0d7afa106]

        Typo in variable name: ContentCnotrol -> ContentControl
        
        Plus some bonus cleanup.
        I want these files to be clean of junk.
        How I missed these SAL_CALLs in my previous clean attempts,
        I don't even dare to speculate.
        
        Change-Id: I6056b61bbbdb088fe83752496df00d0fa319e637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144137
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-19  Miklos Vajna  <vmiklos@collabora.com>  [de235fe13a2e5a4db043f44e6d5636e308f2b979]

        sw layout xml dump: show numbering portion weight
        
        Similar to font size & font color.
        
        Change-Id: I0987c50235dc317dd4b778a5b9946a0415558eeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144502
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-19  Justin Luth  <jluth@mail.com>  [be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928]

        [API CHANGE] tdf#85592: deprecate .uno:BackColor, use .uno:CharBackColor
        
        EditEngine stuff uses CharBackColor, while SW used BackColor.
        Deprecate the SW-only SID.
        
        What does this do?
        It allows the toolbar "Character Highlighting Color"
        to work with both body text (previously BackColor)
        and comment text(CharBackColor).
        Otherwise, the toolbar item was disabled when moving into
        a comment. (Shapes/Textboxes got their own formatting toolbar,
        so those are unaffected.)
        
        AFAIK, after this commit, SID_ATTR_CHAR_COLOR_BACKGROUND
        should still work fine for API calls, or for customized toolbars.
        That's why I didn't try to remove it completely - just deprecate.
        
        Do I know what I am doing here?
        No, although I'm fairly confident nontheless,
        and I've had some good help from reviewers.
        
        Change-Id: I0afcbdb1b91c872f6d47f3c82c573f3b9fea6dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137334
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [97e93861dd5ed52d742355f043e9cd628c1bc8f8]

        sc: check ScDocShell::GetViewData()
        
        ScDocShell: :GetViewData() can return nullptr
        Change-Id: I39bb2dce1ab233f39b0ec687ed71089b35537f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144467
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b0913c0e3cd42561d01b5d4dfb27a82915b91919]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e2388e894212c7be710371c589263c45e994a304
          - set id attribute from paragraphs as type ID for uniqueness constraint
            
            so that the xmllint job on jenkins can detect those
            
            Change-Id: I45058e114fbce907cb4fc26ec5a8d06974eb8145
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144465
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7a0900a265ae0d21ad04b03f26ea34c725ba152]

        loplugin:implinheritancehelper in ucb
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I3ecc79ac5a1ae7a005845a7f1460e3b5037e6d53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef503472251127d32a349f1647a83aad9ba04a78]

        loplugin:implinheritancehelper in toolkit
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I209e013f84a83339d0f4a6dfd90b462a47b6beeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b3738ba2b39daf5dbad00a705d04a12e5530a1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b91a0a30115e414982bd4b3f710e0218661b4e18
          - Fix typo
            
            Change-Id: Iede879decee335d13e50df7244326dbc44728145
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144503
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-12-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [856ed683934e7b178b19dd82fce3dd619203b8b3]

        Fix typo
        
        Change-Id: Ibd4381e8e1f38588706a9cb093a63a9673776d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144504
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-19  Leonid Ryzhov  <leoryzhov@gmail.com>  [ed9eef72e0f616b9c626629c4233b725ca5506ce]

        tdf#145538 Use range based for loops
        
        Change-Id: I6d04185f14c3ec72b40426bd881cac80528cc736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143244
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-12-19  Caolán McNamara  <caolanm@redhat.com>  [d968061f008b954f55ab9a4dd51efd5d0844b543]

        crashtesting: asserts with outsized object positions
        
        seen during import of:
        forums/forum-mso-en4-187408.xls
        forums/forum-mso-en4-187900.xls
        forums/forum-mso-en4-187890.xls
        
        Change-Id: Id15e9c1ea98d761225d41850b9b2aa58d9c9e407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144466
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3debc5161ef52afe822552caa6e288348f06928c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1445fa8fda93a2f0ffab873c926390adb4937397
          - Fix duplicate IDs in non-localized content
            
            Change-Id: I759b05a2ba10671700c9222f54e61edf39f5baff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144538
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [eee24950954a0359ca1625f26f08a7af7a252878]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7d5ae8c4582675a8e102e4d330658a588ef015cf
          - update translations for 7.5.0 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: I3c9458097e8ea70e7931e1646095b0da3f5a04eb
            
2022-12-19  Justin Luth  <justin.luth@collabora.com>  [61604ecfcfe2a9fbe3057a9fc38bfc6cc3b22b08]

        tdf#151548 vba ContentControls: don't always return a filtered value
        
        Searching for content controls can be filtered by tag, title, or Id.
        The function was erroneously returning the last control in the
        list if the specified control did not exist.
        
        Change-Id: I0cfbccadc134b64456d703f1e19db6e142f162fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144346
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-19  Caolán McNamara  <caolanm@redhat.com>  [ea7db3b0828f16d424910892f10a3b979dbf2ed3]

        ofz#54240 Integer-overflow
        
        Change-Id: I50c8f9579a9fb07431ad0d6eebc5f0df8e40ebd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-19  Caolán McNamara  <caolanm@redhat.com>  [24c48fbcb845844aa93799a0e536e4b6d1ea9b8b]

        ofz: bad-casts at shutdown
        
        Change-Id: Ia8cdf5d446647e0f3d60c14e1aae315db63769c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144462
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-19  Justin Luth  <justin.luth@collabora.com>  [ea9938b0a63b25cbfdd575c1745f208d27660f20]

        tdf#151548 vba ContentControls: fix fundamental error
        
        The problem was that the SwTextControl could be deleted
        by the user or in VBA and my references (or pointers
        for that matter) to m_rCC would be invalid.
        
        Instead, use the shared_ptr, which will always be valid,
        from the SwContentControl. Thankfully, there is
        backwards access to the Format and Text controls.
        
        This is nicer anyways. It has reduced code lines,
        and simpler access to the most used aspect.
        
        Change-Id: Ie382b33ecda5c3d0024f0eabcb8ff158db942f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144345
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [a0c6bc75628513f3c501321eea1458d77bacc36c]

        -Werror=maybe-uninitialized
        
        Change-Id: Ib467fa5eec2560943e10adc2c440fdbf8f853a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144446
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b3a8d41fa93574dd62db156f90b3f707f8afeff3]

        build baseline is macOS 12 and XCode 14 (macOS 13 for m1)
        
        (and would also be macOS 13 for the intel builds if the old macMini
        would be on the officially supported list)
        
        Change-Id: I4205f30274bdd43d80d02d6cda863ec83bdda63e

2022-12-19  Stephan Bergmann  <sbergman@redhat.com>  [4d6c23216559eb48f9943bb49d6e475a6d64ba15]

        loplugin:unocast (oox::ForumlaImExportBase)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I11bc363447c44319bc47f7eebb7084f64ea85511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144400
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-19  László Németh  <nemeth@numbertext.org>  [1e4709f47dec87d5d2b66f3de222588c3babaf18]

        tdf#65535 sw: fix lost comment at fixing spelling with context menu
        
        Also fix the bad Undo label, where the invisible IAA character
        became visible.
        
        Choosing one of the spelling suggestions of the context menu
        of a bad word fixed the spelling of the original word, but
        also deleted its inword comment. Keep the comment at the end
        of the fixed word.
        
        Fix also the bad Undo label, which contained the original
        word with the Interlinear Annotation Anchor (IAA) character.
        Now it shows only the word, but not the Unicode replacement
        glyph of IAA.
        
        Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8
        "0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002".
        
        Change-Id: I5bfa214a060c446e9897e806832bedfe54241e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144397
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4a4f58f06f802e7bc057e0a6e7180b595bd4a379]

        tdf#152295 sw sd UI: don't reset tiled image size by Area tab
        
        The background tiling images become larger when
        opening and closing Area tab: reopening the image
        properties in the Area tab shows that the Width
        and Height got reset to the original values of the
        image.
        
        Regression from commit 686349476e03f951f4a9ff9755b9f71951b64ea5
        "[GSoC] Move all fill style tabs inside area tab".
        
        Change-Id: Ibc4dfd73dedd81b1b7fe17574198dd4999aab967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143819
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [b12e38c1ccb388e62e35d856d4a575e1724a10e9]

        tdf#152070 PPTX import: fix offset of tile background image
        
        by using bitmap image sizes instead of the original ones.
        
        Change-Id: Id6f2777bf6803bca7252878203a12ab796ac33dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143766
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Tünde Tóth  <toth.tunde@nisz.hu>  [907da02bf8b33c080538731864225b3c44251328]

        tdf#152436 PPTX export regression: fix lost shape at missing object
        
        If the object is missing, it's still possible to keep its shape
        by exporting its preview graphic, as before the regression.
        
        Regression from commit adc042f95d3dbd65b778260025d59283146916e5
        "tdf#124333 PPTX import: fix Z-order of embedded OLE objects".
        
        Change-Id: Ib2fd00f53a80572cfc9acaefea55015780c57da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144040
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Miklos Vajna  <vmiklos@collabora.com>  [6249858a8972aef077e0249bd93cfe8f01bce4d6]

        sw: ODT import/export of DOCX's paragraph marker formatting
        
        The bugdoc had a numbering, where the paragraph marker was explicitly
        formatted to a custom sans font, and this font is also used for the numbering
        portion's font. This was imported from DOCX correctly, but once you save
        to ODT and reload, the font used in the numbering portion changed from
        sans to serif, which is incorrect.
        
        The reason for this seems to be that earlier
        5ba30f588d6e41a13d68b1461345fca7a7ca61ac (tdf#64222 sw: better DOCX
        import/export of paragraph marker formatting, 2019-09-06) introduced
        support for storing this paragraph marker formatting in
        RES_PARATR_LIST_AUTOFMT, but this was lost on ODT export / import.
        
        Fix the problem by 1) adding the autostyle to the autostyle pool, so the
        font gets written when writing automatic char styles 2) extending
        SwXTextPortion to have a mode where it exposes the
        RES_PARATR_LIST_AUTOFMT of the current text node and 3) improving
        lcl_CreatePortions() to expose a trailing empty text portion that works
        with these properties.
        
        This also required adjusting CppunitTest_sw_ooxmlexport2's
        testFdo64238_b, which explicitly asserted that the format of the
        paragraph marker is not exposed in the UNO API text portion enumeration.
        An additional improvement would be to go with a more explicit markup in
        the ODT output for RES_PARATR_LIST_AUTOFMT, but we would need to decide
        what name to use there, since currently we call this paragraph marker
        formatting RES_PARATR_LIST_AUTOFMT / ListAutoFormat, and somewhat
        confusingly this is primarily about paragraph marker formatting, not
        lists / numberings (that is just a consequence).
        
        Change-Id: I19c7eed19c6fc85c251ef87a5181c0719a0a382c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144447
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [c3f1ec60569727d8aba50b2f59882e13a8443880]

        tdf#152434 PPTX import: fix lost shapes with connectors
        
        Regression from commit eec48130271188cab63665acedbabf1ff5e850a2
        "tdf#148926 tdf#151678 PPTX import: position of standard connector
         - part1".
        
        Change-Id: Ib9381403f7c0edf9a06e3d98965067a51b4797d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144000
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Miklos Vajna  <vmiklos@collabora.com>  [4b909c61ccf76f437d98000838d3791a495cc68c]

        sw: prefix members of ContentControlListEntriesEnumWrapper, ...
        
        ... ContentControlsEnumWrapper, ListEntriesEnumWrapper and
        SwHTMLTextFootnote
        
        See tdf#94879 for motivation.
        
        Change-Id: I1efbf1d7e3def37868ef0e36aeb4ec184d31eb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144445
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0f70bc3fabccc02705f84acb398e44495418a40f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 318ec1f0e6248eac2536256bf26e1a183fc59541
          - janitor: update comment for the bookmarks.part rule
            
            the remarks about the indicator files are obsolete after the rule has
            been rewritten to work in batch and not on single files
            
            Change-Id: I8a2509aed7a38b9cff0dacec3d4161bc020fde31
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144468
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-19  László Németh  <nemeth@numbertext.org>  [5ecb61c81238b5bc802dd5afcab18e8331ed3d9d]

        tdf#65535 sw: fix lost comments using spelling dialog
        
        Choosing one of the spelling suggestions in the spelling
        dialog, or rewriting the bad word removed also its
        inword comment. Keep the comment at the end of the fixed word.
        
        Regression from commit b0f170d7df9cff12535d2ecfd146b32b745a8ef8
        "0xFFF9 is a better choice for CH_TXTATR_INWORD than 0x0002".
        
        Change-Id: Iaf083453fad4e0ca99e254f53b20ead86b3ba15e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144458
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Tünde Tóth  <toth.tunde@nisz.hu>  [2298087db28ee1b4251cac6e12c1d4806b395a1e]

        tdf#151152 sc filter: fix string entry checking
        
        When a column was filtered for values that included 0,
        the all string entries were always checked in the Autofilter
        dropdown (because their conversion to number, i.e. value 0
        was used to check their existence in the filtered values
        instead of their string value).
        
        Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
        "tdf#142910 sc filter: fix "greater than" or "smaller than" etc".
        
        Change-Id: Ib659aba9d6f3d6bc3557547b1a27963f51e3eca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143777
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Tünde Tóth  <toth.tunde@nisz.hu>  [1f30f9cf012cee6823029ef5a96a1d91a0e16cdc]

        tdf#152082 ODS: fix import of Empty filter operator
        
        Bad import of the Empty filter operator resulted shifted
        filter settings, e.g. selected "A" and "B" instead of
        "empty" and "A" from the range "empty", "A" and "B".
        
        Regression from commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
        "tdf#142910 sc filter: fix "greater than" or "smaller than" etc".
        
        Change-Id: I33082d77fb9e707aa474fb22753a001960341d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143776
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b688b779ba20a4bec653808a42fe88cfac851029]

        keep environment clear of SYSTEM_FOO vars
        
        those are only meant to be used by the build system (primarily
        RepositoryExternal.mk) - of course no rule without exception:
        concat-deps reads SYSTEM_BOOST from env, so set it in the corresponding
        recipe lines
        
        Change-Id: I83c88fc6ad4467b429771c43650fe7fc0ccde407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144343
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6600552f80064d548fab86e2e18ca649c6dc3cf0]

        loplugin:implinheritancehelper in stoc
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I2b4937ebee2e8cc16759df0eacdeb160343a7001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [40ea23ecdb46dfe4f4677ddbe5cb82d7f71ee592]

        tdf#152335 PPTX export: fix 3D shape properties of the shape in theme
        
        The shapes got extra 3D shape properties by the default template,
        which caused visible difference in MSO.
        
        Follow-up to commit I02f1edea84b50dbb9b0e0a59b6062a29894afde4
        (tdf#152186 PPTX export: fix shadow of the shape in theme)
        
        Follow-up to commit 25e9766e9b87342b6f1b29dc146d5f33e12157a7
        (tdf#92222 PPTX export: fix line width of the shape in theme)
        
        Change-Id: I84f931e45e7656c456fe910cbb5e09aabeb8924f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143516
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-12-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [8cc14b57d0a0583c48c22231ede9af9932fb9e0a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e739da903b92597316aeac26ec190a8d7c7bec28
          - convertfilters.py: Don't add name attribute to links
            
            Change-Id: I556ee26594fada9722ef898ef9e36df4644e4f37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144461
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-12-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [feac23289bc28799b7cac9954aef1062098b3eca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8611c6e320bf5db95a6d1fa54d3ff6e13f9eaa7
          - Remove name attribute from links
            
            Change-Id: I999712c68026ddd40578c1f5e92a994c24a11eae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144460
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-12-19  Hossein  <hossein@libreoffice.org>  [c6837f8ebe611f3a0ae144ffe4d4ac4bc98f6b96]

        Fix title for nlpsolver/README.md
        
        The nlpsolver module is "Solver for Nonlinear Programming", which was
        mistakenly called "New Linear Programming", and this is now fixed.
        
        The change will appear within a week in:
        
        https://docs.libreoffice.org/nlpsolver.html
        
        Change-Id: I05b14d1e4056d8d0797728905886edef867f29e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144408
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-19  László Németh  <nemeth@numbertext.org>  [96a856f87f16cca2e039c973c18d57c8b9dca362]

        tdf#152206 DOCX import: fix mixed first footnote
        
        Also the first footnote can be at arbitrary
        place in footnote.xml.
        
        Follow-up to commit 09ae3c01940bbc25ffde51963683b04e3cb4bb6a
        "tdf#152203 DOCX import: fix mixed footnotes/endnotes".
        
        Change-Id: Iab356f7373483d812f0e802a994357fdad831d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144380
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-19  Noel Grandin  <noelgrandin@gmail.com>  [d640bfe7767292c8a89de57d378dd752a8ec8342]

        remove dependency from drawinglayer to framework
        
        to try and untangle the dependency mess a little.
        
        This means
        
        (*) tunneling a piece of information from VCLXWindow via
        the XWindowPeer::getProperty method, so
        we do not need to directly call VCLXWindow.
        
        (*) moving some formpdf code from framework "down" to vcl,
        where the drawinglayer code can use it
        
        Change-Id: I2c1ff3e34941b3147e66cf0a2d0fdb13293e3aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-19  Attila Szűcs  <attila.szucs@collabora.com>  [c57d113e9ef8608f5690e8707a97879cb4f6a185]

        tdf#151755 fix export of borders of contentless cells
        
        Change-Id: I650aeebb4d021911c1f14d4867c5beee84020155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143880
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [ad387d5b984c6666906505d25685065f710ed55d]

        crashtesting: failure on load of forum-en-7529.odt
        
        ==324198== Invalid read of size 8
        ==324198==    at 0x2D840D75: std::__uniq_ptr_impl<SwField, std::default_delete<SwField> >::_M_ptr() const (unique_ptr.h:191)
        ==324198==    by 0x2D840D54: std::unique_ptr<SwField, std::default_delete<SwField> >::get() const (unique_ptr.h:462)
        ==324198==    by 0x2D932B9B: SwFormatField::GetField() (fmtfld.hxx:122)
        ==324198==    by 0x2E740E7B: SwXTextField::Impl::GetField() const (unofield.cxx:2634)
        ==324198==    by 0x2E7487EB: SwXTextField::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (unofield.cxx:2150)
        ==324198==    by 0x1100C123: XMLPropertyBackpatcher<short>::ResolveId(rtl::OUString const&, short) (XMLPropertyBackpatcher.cxx:73)
        ==324198==    by 0x1100BB0F: XMLTextImportHelper::InsertFootnoteID(rtl::OUString const&, short) (XMLPropertyBackpatcher.cxx:180)
        ==324198==    by 0x10FF7E71: XMLFootnoteImportContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (XMLFootnoteImportContext.cxx:99)
        ==324198==    by 0x10C40361: SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (xmlimp.cxx:812)
        ==324198==    by 0x28FBFE71: (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) (fastparser.cxx:470)
        ==324198==    by 0x28FBED4E: sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) (fastparser.cxx:1304)
        ==324198==    by 0x28FBCCAF: (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) (fastparser.cxx:333)
        ==324198==  Address 0x259e2b68 is 328 bytes inside a block of size 344 free'd
        ==324198==    at 0x4848669: operator delete(void*) (vg_replace_malloc.c:923)
        ==324198==    by 0x2E4EC2B1: SwFormatField::~SwFormatField() (atrfld.cxx:132)
        ==324198==    by 0x8635DA2: SfxItemPool::Remove(SfxPoolItem const&) (itempool.cxx:802)
        ==324198==    by 0x2E5BB014: SwTextAttr::Destroy(SwTextAttr*, SfxItemPool&) (txatbase.cxx:63)
        ==324198==    by 0x2E594EE2: SwTextNode::DestroyAttr(SwTextAttr*) (thints.cxx:1302)
        ==324198==    by 0x2E55C4EC: SwTextNode::~SwTextNode() (ndtxt.cxx:238)
        ==324198==    by 0x2E55CB38: SwTextNode::~SwTextNode() (ndtxt.cxx:227)
        ==324198==    by 0x2DEE048F: SwNodes::RemoveNode(o3tl::strong_int<int, Tag_SwNodeOffset>, o3tl::strong_int<int, Tag_SwNodeOffset>, bool) (nodes.cxx:2325)
        ==324198==    by 0x2DEE50C2: SwNodes::DelNodes(SwNodeIndex const&, o3tl::strong_int<int, Tag_SwNodeOffset>) (nodes.cxx:1384)
        ==324198==    by 0x2DC87B02: sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (DocumentContentOperationsManager.cxx:2118)
        ==324198==    by 0x2DD2BB66: sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat*) (DocumentLayoutManager.cxx:285)
        ==324198==    by 0x2DB0900E: DelFlyInRange(SwNodeIndex const&, SwNodeIndex const&, SwIndex const*, SwIndex const*) (docedt.cxx:254)
        
        maybe this is a problem since the various changes associated with:
        
        commit 2c9298e4f667a5dd7606d79890fcedfff0f66e26
        Date:   Fri Apr 5 23:14:47 2019 +0200
        
            SwXTextField::Impl FieldTypeClient: SwClient no more
        
        commit e18359445fabad9ba1a704600e9ee327112cc6ae
        Date:   Sun Apr 14 13:33:35 2019 +0200
        
            [API CHANGE] SwXTextField: no more SwModify/SwClient
        
        Change-Id: I52aa0a70604ea5ce96d2b55a9a2ad363a889f58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [487e1d73393ae9e6fe7961c8a95dd77a3598b510]

        crashtesting: related to failure on load of forum-en-7529.odt
        
        save SwDoc* before calling DeleteAndJoin, so SetFormatField doesn't
        use m_pImpl->m_pDoc potentially cleared by it
        
        Change-Id: Ia130f224fcccd35e1dfafbbaf5c461c9bd032f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144407
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Christian Lohmaier  <cloph@documentfoundation.org>  [c4bd6991ac8e579ad4d61b14ba9cb725f9289a90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 534e501e3ad4fef3ebee8788b45c063e96d50346
          - janitorial cleanup/minor optimizations
            
            mostly making xstlproc and python order-only dependencies, simplifying
            some of the print statements/remove sed or grep calls that can be
            handled by make's own text functions
            
            Change-Id: If4f8ef145d7721384e914ae79494c500bbf244dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144410
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-18  Christian Lohmaier  <cloph@documentfoundation.org>  [a89a6026a3139f0d49905203c35518fbf8548aae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a83788dd6205cd600327ead7388bc5ad26fc7f7
          - process files for bookmarks.part in bulk
            
            instead of running xsltproc for each file, pass multiple files at once,
            greatly reducing the overhead of the processing, especially on
            Windows/cygwin. since it not only removes the need for the xsltproc
            invocations, but also for the surrounding workarounds with the rm,
            touch, rm of the indicator file.
            
            Change-Id: I4588bfc869c668a41da29b5d4080a600ed02223b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144409
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [c3386ba37747b9fd49dc83ad2a682713aa353f4e]

        cid#1517772 more Logically dead code
        
        Change-Id: Iecbf15486b319bf2d04c451ceea94844a567fe02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [f18ca0794874d3bbdb570c803f3d190c8f34df37]

        ofz#54402 check bounds
        
        git show -w
        
        Change-Id: I8e7c719a9f1c38f151eb7e59ec222849eb2e28f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144402
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [00c90e648c0bf5033ad51dc5cb495e788ecdd418]

        add some SAL_WARN_UNUSED_RESULT
        
        commit 817dfb74d9ec9f46ba32be6d5066d534f81072a5
        Date:   Tue Jul 17 09:45:37 2001 +0000
        
            #89783#: NULL-Ptr possible
        
        probably intended
        
        pViewFrame = SfxViewFrame::GetFirst()
        
        but at this distance in time, just accept the current state
        of things
        
        Change-Id: I8779fef1041843e9f2e6c879cfb475d8ac8251fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144401
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Stephan Bergmann  <sbergman@redhat.com>  [4844c096a8ab6a9a620c410a0949d4499f12a504]

        loplugin:unocast (cairocanvas::SurfaceProvider)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        There are implementation classes whose getSomething already delegates to
        RepaintTarget, so they can't also delegate to SurfaceProvider.  So introduce the
        concept of comphelper::getSomethingImpl additionally delegating to a sequence of
        mixin classes before delegating to the base.
        
        Change-Id: I9230f3dc06abbdd1ad92514a11473dae2624f7c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144404
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-18  Stephan Bergmann  <sbergman@redhat.com>  [9a0b523e0a84d403b9092176ccec4b3e3efe42d0]

        loplugin:unocast (cairocanvas::CanvasBitmap)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I6044567e4027fe1fdc361917d5233157d4ce98d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144399
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-18  Jim Raykowski  <raykowj@gmail.com>  [51be46640a4987d839aace354ee8b5e85bdce684]

        tdf#138587 Preserve doc view x position on go to content
        
        from the Writer Navigator.
        
        Change-Id: I55b05be037b4ce010fb0476f584921c7ecae79bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-18  Stephan Bergmann  <sbergman@redhat.com>  [8a5648d8e59b4b007dbbf3824777c19a21efc61e]

        loplugin:unocast (cairocanvas::TextLayout)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I900d37ee0053e3fbfc8c21b02087a6eaa92cf942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144352
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-18  Stephan Bergmann  <sbergman@redhat.com>  [28c27a0623bc78a0590858f97d03b620985bc84c]

        loplugin:unocast (cairocanvas::CanvasFont)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I2d5c330bb542dc74ea572f1667a24be8107fb87c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144351
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-18  Stephan Bergmann  <sbergman@redhat.com>  [c3497353cabdef735dcebd66a8818ea117623dac]

        Combine oox::FormulaIm-/ExportBase
        
        The original classes were both only used as base classes of SmModel, and
        combining them will make it easier to replace the existing dynamic_casts to
        those classes with XUnoTunnel.  (And see the upcoming commit introducing
        loplugin:unocast on why those dynamic_casts are dangerous.)
        
        Change-Id: I4b1e0594fb202e3423d57db6457aa0e1b1b0b612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144353
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-18  Jim Raykowski  <raykowj@gmail.com>  [50a5b5580729d6d537a696f7c91f212c8f3b995d]

        tdf#152029 Bring tox sections to attention in the document view
        
        when the mouse pointer is over index content type and content entries
        in the Navigator content tree
        
        Change-Id: Ia9ec89ed55da7b62b00b016a6e1dbda5fab54a7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-18  Bogdan B  <buzea.bogdan@libreoffice.org>  [34496e47b72906842136c13ac0093a206f74531d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e092fa52ec29ae38cbe77092356c21543377977
          - tdf#152551 Correct template usage for new files
            
            Change-Id: I5cc1678733fee8e4e5f97c1a1ba8391fb85692f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144362
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-18  Caolán McNamara  <caolanm@redhat.com>  [68809ffde7d50a5f47afa5a1235025513762df8c]

        crashtesting: assert seen with forum-mso-en4-747641.xlsx with LCID F6E0B
        
        see on export to ods
        
        input .xlsx contains a LCID of F6E0B
        
        <numFmt numFmtId="169" formatCode="_-[$£-F6E0B]* #,##0.00_-;\-[$£-F6E0B]* #,##0.00_-;_-[$£-F6E0B]* &quot;-&quot;??_-;_-@_-"/>
        
        Change-Id: I543164dba4cc8b1c86508a3e3e39b43900c06484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144321
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [8bd1caba57f266ca11f89315fa9cce16041b5239]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58669bdec287e34bdd7384498c5b137d84170163
          - Minor fixes in the SF_Datasheet documentation
            
            In commit bd899b607eed60487a75905a398b751cf5332352 I accidedntally ended up reverting a few fixes that had already been done to sf_datasheet.xhp.
            
            This patch reapplies these fixes.
            
            Change-Id: Ie2c7f65f4363aa788afa2315514ce8a348dc68c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144364
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4a4c0c8001d6d1357ef664a274032c795babd826]

        Fix typo
        
        Change-Id: Id469267ff57f8013accf2371b54174bee07016ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144396
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-17  Khaled Hosny  <khaled@aliftype.com>  [e272fd31b115e6ea128b593087aeaf4f55119a36]

        Update HarfBuzz to 6.0.0
        
        Change-Id: Id371a53a126f2b95b17e642a9c63adafd5aa3d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144394
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-17  Caolán McNamara  <caolanm@redhat.com>  [4e0970bebd06ba988a59213b827a1c0a44c76ac2]

        cid#1517773 silence Wrapper object use after free
        
        Change-Id: I6652bfd32eb604ebb2a5b7deb573d9c979ec6d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144391
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-17  Caolán McNamara  <caolanm@redhat.com>  [f52118159e1e958177aa8080d9b43962d31bbdfd]

        crashtesting: assert on export of forum-mso-en4-212378.xlsx back to xlsx
        
        input xml contains:
        
        <cellStyle name="ck-In_xdc80_.."
        
        resulting in a bare low surrogate that asserts on export's OUString::toUtf8()
        Sanitize it at the original import
        
        Change-Id: Ib1259ed55090efb16e1c5b4b488bf3050e473324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-17  Caolán McNamara  <caolanm@redhat.com>  [2b6d04b8493a6b05c8ed0afb0c1e96d441ba876b]

        move and rename sanitizeString for reuse
        
        Change-Id: I8378f3df79e511cf2d385ace1cd7964ab1c76e7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144388
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-17  Christian Lohmaier  <cloph@documentfoundation.org>  [f7b30ab0141e2038b0e5e882d634065878c24c3f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88c2d7943241daed9cc850e9518555ef9056634b
          - reduce number of process calls when building html help
            
            For each language times the 2500+ xhp files the build did run
            dirname, mkdir, and pwd (twice, and on windows also with additional
            cygpath) - replacing those by static values provided my make saves
            4-5 minutes on a fast m1 machine and over 25 on windows with
            cygwin (despite building with 32 threads...)
            
            Change-Id: Ib3ca9e2ffdea622a4b5f578f2580152eb0b3b674
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144393
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3a9deb71551f7fb2379655a80fff27796176f16c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 751b27f39c4673e8e65370ceabadd1b0db086133
          - Fix typo
            
            Change-Id: I48aff9f91ddf1870efe97adc2629f6ef872437e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144382
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-12-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [147c7f489a461bb6a46d7f3361eb07bc6d5de4ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 712519472c76f29f9529f02cea24e8b1756d8bf7
          - Fix typo
            
            Change-Id: I3fd93d0db40bc0159853a5c40b5027545533d4ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144383
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-12-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [febbd2eff4af54d6c3e9dd6d4b2939e233f545f5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06e3b8bdf09d260ca00f3197d3aab7706e6f7455
          - Fix typo
            
            Change-Id: I22ef89aba9bf496d12911caabe79eff4a1340fe9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144384
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-12-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f150f3f903a23f7dbe1ca8b35f40cc4375b74236]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5d2bf6e060c0fe1034f29947590471693b3ac8f
          - Fix typo
            
            Change-Id: I5e525f8125d5383d1bb4cf49ce3233d49eeec3c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144381
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-12-17  Julien Nabet  <serval2412@yahoo.fr>  [2dd1259fcdbe94b64ffa9ffebccffd38c7dfdf28]

        cid#1517772 Logically dead code
        
        Change-Id: I632d60cad78fd721684cba92a58e9a7698b5d48d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144378
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-12-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d518d0c4cd364f254f5510ab0105ceaf6d765671]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05b3bc39b778168e923ee1cec49fa17c6b0f92ab
          - Mute l10n in embedvars
            
            Change-Id: I41ec8a772aeba62a8a981895db074e8be475900f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144379
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-17  László Németh  <nemeth@numbertext.org>  [62f0707f6ff1c0dfca67c8e3d7f6d74d1a43db87]

        tdf#124603 sw: test only if spelling dictionary is available
        
        Unit test failed on some test platforms. Disable the test,
        if the spelling dictionary is not available, like spellDialog.py
        does.
        
        Follow-up to commit e3ae86a38d6282db0f54d3545015ed22ee868ae5
        "tdf#124603 sw: pressing Up/Down triggers pending spell checking".
        
        "Building using --with-external-dict-dir=/usr/share/myspell
        and having en-US dictionary in there passes, but using
        --with-external-dict-dir=/usr/share/hunspell which doesn't
        exist breaks.", as reported by Christian Lohmaier.
        
        Change-Id: I53e92befe0ed35423c4c13ef3bf52f2ab3735cf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144157
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-17  Julien Nabet  <serval2412@yahoo.fr>  [f7b94d7ffd785470962e73408f6fd7f7728f8ec5]

        tdf#151627 + tdf#152559: blacklist Nvidia device id="0x1402"
        
        Change-Id: I37430b38cd8d5daaca39b783c59bc10cd571c552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144377
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-17  Julien Nabet  <serval2412@yahoo.fr>  [6f7bc75dc1d0fe8227f30afc5eccdd7a9a9c4006]

        tdf#152520: Crash when using TITLE_CASE/SENTENCE_CASE in Transliteration module
        
        relevant part of bt:
        7  0x00007f50c85b3796 in com::sun::star::uno::Sequence<int>::realloc(int) (this=0x0, nSize=11) at include/com/sun/star/uno/Sequence.hxx:215
        8  0x00007f50c85d9240 in i18npool::transliterate_titlecase_Impl(std::basic_string_view<char16_t, std::char_traits<char16_t> >, int, int, com::sun::star::lang::Locale const&, com::sun::star::uno::Sequence<int>*) (inStr=u"AB cd. eF. ", startPos=0, nCount=11, rLocale=..., pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:267
        9  0x00007f50c85d955b in i18npool::Transliteration_sentencecase::transliterateImpl(rtl::OUString const&, int, int, com::sun::star::uno::Sequence<int>*)
            (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11, pOffset=0x0) at i18npool/source/transliteration/transliteration_body.cxx:298
        10 0x00007f50c85dcc10 in i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834ea0bb0, inStr="AB cd. eF. ", startPos=0, nCount=11)
            at i18npool/source/transliteration/transliteration_commonclass.cxx:109
        11 0x00007f50c85dcc5d in non-virtual thunk to i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) ()
            at i18npool/source/transliteration/transliteration_commonclass.cxx:109
        12 0x00007f50c85e0d89 in i18npool::TransliterationImpl::transliterateString2String(rtl::OUString const&, int, int) (this=0x557834854dc0, inStr="AB cd. eF. ", startPos=0, nCount=11)
            at i18npool/source/transliteration/transliterationImpl.cxx:395
        
        full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=184205
        
        Regression from:
        c7551e8a46e2f9f8142aa7921a0494221ae096e8 (speedup CharacterClassificationImpl::toUpper)
        
        Change-Id: I40e383fc87213d88fbde50876f61947b04190a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [3915f26544563cb4913eb450b57f73fba2e806a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd899b607eed60487a75905a398b751cf5332352
          - Create TOC with all ScriptForge methods and properties
            
            Change-Id: I32be401689efce0cba70216458bc7c8ba4a405c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144309
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [98f0dd5e15733ac7f1d929d06ab230b5f04121d5]

        Improve extended tip for Impress page print
        
        Change-Id: Id8b695b189acdbc300b1119df12e9924cc9f18f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143920
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-12-17  Stephan Bergmann  <sbergman@redhat.com>  [53bc223cb3288e32a417696ee61c29e5f01f209d]

        loplugin:unocast (cairocanvas::RepaintTarget)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ida4ccf961301cf50396e80d9bbdc4b9925bd81f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144350
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-17  Jim Raykowski  <raykowj@gmail.com>  [3cb601245676a67f5cd523e4f400f777b3e53dc6]

        SwNavigator: Fix delete field content deletes one character extra
        
        PostIt fields are no longer included in the fields content
        type since commit bf28e1df0a04cf6a06d9c4cf591e238a45a34ec1 so there is
        no need to check to delete them from the field content type, if ever
        this was needed, and fall through to the PostIt content handling which
        is where the extra character delete happens that is the cause of this
        bug.
        
        Change-Id: I61ded30fd89d87c536f0c050117d5b61fe3a9aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144201
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-17  Jim Raykowski  <raykowj@gmail.com>  [1c6410fc51a89464898622ae3859931f81178a01]

        tdf#152029 cleanup: Bring content to attention in document view
        
        when the mouse pointer is over content type and content entries in the
        Navigator content tree
        
        Changes made:
          * check for content visibility
          * use m_aActiveContentArray for content types where possible
          * consolidate repeated code
          * check pointers before use
          * stop and clear overlay when hidden shell is shown
        
        Change-Id: I2ec41b2508e3f37ea11bfbeb695fc95e0dcca0ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143904
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-17  Jim Raykowski  <raykowj@gmail.com>  [eef94d7b4360e17ba21577fe52bd60214bd5280c]

        tdf#152517 Fix gen backend treeview ctrl+minus behavior
        
        For gen type backends, makes the cursor node and all sub nodes
        collapsed on ctrl+minus key input.
        
        Change-Id: I53730aca29dd47766cfe8b4cdc81539633ebd8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144286
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-16  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [8635c9aa8c6f1078a9e220076d5a08daf30077e8]

        Use xKeepAlive instead of m_pData
        
        There is already an instance to keep the incarnation
        alive, but it was not used. Instead m_pData can indeed
        get deleted (nullptr), so better use the alive one.
        
        Change-Id: Icdb6c841408254142561db408f876618adbc0b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144340
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec]

        loplugin:unocast (SvXMLImport)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I773095e51958a0a050bcece6f44fe3847f962eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144333
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d6d15a2a4fd05af0cb66a69a789fcb1e81b59c05]

        Fix typo
        
        Change-Id: I06d3c1be277efd0bfff3e3389f9f42ba6538e4c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144349
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [1726c27e0d633ab04843834d2bf987bc7645807f]

        check SfxObjectShell::Current()
        
        SfxObjectShell::Current() can return null, it's based on the equally
        vile SfxViewFrame::Current()
        
        Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [1ae71d8f09771ba7180be6ebdf89d36a31eb8625]

        Revert "fix math export/import in docx/rtf"
        
        This reverts commit 2b5953a19e36a02040f2ff08bc87efe4785f80bd.  Whatever that
        "gcc4.4 (and 4.3 and possibly older) have a problem with dynamic_cast directly
        to the target class" issue actually was:  For one, our GCC 7 baseline presumably
        would no longer have such an issue.  And for another, the added asserts that the
        results of the dynamic_casts must be non-null were presumably all bogus (and
        have in part been reverted again in the meantime), as all the sources are UNO
        interface types that can presumably point at implementation objects of other
        than the expected C++ class types.  (Those dynamic_casts from UNO interface
        types will be addressed in a follow-up commit.  See the upcoming commit
        introducing loplugin:unocast on why such dynamic_casts are dangerous.)
        
        Conflicts:
        	sw/qa/extras/ooxmlexport/ooxmlexport.cxx
        	sw/qa/extras/rtfexport/rtfexport.cxx
        	sw/source/filter/ww8/docxattributeoutput.cxx
        	sw/source/filter/ww8/rtfattributeoutput.cxx
        	writerfilter/Library_writerfilter.mk
        	writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
        	writerfilter/source/rtftok/rtfdocumentimpl.cxx
        
        Change-Id: I0c330a3541e64ce08bfe30ff15d51a2fd8a243b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144336
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [068187a898cdd2e26e9b16c348ecc1ed2dee3f29]

        loplugin:unocast (VCLXWindow)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ic151fd657cb780291009ee4c9db51a35dfa7f357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [88b4f966202717cd4ad38a30a8eda22c3e69ed35]

        loplugin:unocast (sfx2::sidebar::SidebarController)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ib681b4eaa44c65b9da5988c74c03f1829e3a1507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [f1b7a69b280aefe2f1b3b0f32193494fd765f2bd]

        loplugin:unocast (SvxLineStyleToolBoxControl)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I13f71f717a8661e0889ab7acf6fe7c7ebbe3dbe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144332
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [32ba2102526a663440957a16e0ebee89bea9f603]

        Use unotoosl::WeakReference to avoid a dynamic_cast
        
        Change-Id: I46c122e800c63038cf7fd650ebb6f0115c6e8c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144330
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Szymon Kłos  <szymon.klos@collabora.com>  [cc067789ab7fd67bdd6f6ba8ce53a6580a56d7ff]

        jsdialog: enter/leave tab page handlers
        
        (cherry picked from commit 1257c288a0ba03fc69e7bc29fcf05642eb91d150)
        
        Change-Id: I2cbc0fc18f716bf214db61f0729d666a1d2d172c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144344
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [ae438bda3d5a0c9c9f2ed0e71104698bd2d8793d]

        pSh cannot be null here, checked at the start of method
        
        Change-Id: Ia6b8599c7ff185d5beecf6572c0df353320d8ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144338
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [1aed92da7f41dffbc675102c8f7d6b7705329554]

        provide a parent for potential message dialog
        
        Change-Id: I7b417c64ce08cddc2c413dae3bcab3b9fe083bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Michael Meeks  <michael.meeks@collabora.com>  [39ffd246450cbf5feb68d7f5ab058b92a951066a]

        lok: protect sc from null ScViewData.
        
        Working hypothesis is this happens after a failed spreadsheet
        load, or from a race during load.
        
        <crash>
        ScModelObj::getPartInfo(int) sc/source/ui/unoobj/docuno.cxx:602
        doc_getPartInfo desktop/source/lib/init.cxx:3531
        ...
        KitSocketPoll::kitPoll(int)   coolforkit
        SvpSalInstance::DoYield(bool, bool) vcl/headless/svpinst.cxx:492
        
        Change-Id: I06870336d4e64ebfc69bce64e280821c25e1b1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144308
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-12-16  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d792eb7ba7b1b65964a950fd7b309b40ae8b8ad5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 55f43cd2900eb670bce537a939ea0f435439d926
          - tdf#134377 Help page not found when clicking 'Help' button
            
            targeting File/Open help page - on 'Help' button click - for the time being although this is far
            from a perfect solution, and while @@widget@@ bookmark does not operate properly.
            
            Change-Id: Id35bb8a6b707cb8376bac7c036aa47ba31aa8f58
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144356
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-16  Patrick Luby  <plubius@neooffice.org>  [07f9f22e68a3caebe67d89c0b209059ba40be482]

        tdf#146765 Fix infinite recursion in -[NSView visibleRect]
        
        HACK: Adding a subview to an NSView that is not attached
        to an NSWindow leads to infinite recursion in the native
        NSViewGetVisibleRect() function. This seems to be a new
        behavior starting with macOS 12.6.2.
        
        In the case of tdf#146765, we end up here because
        -[AquaA11yWrapper childrenAttribute] is called by a
        wrapper that is already attached to an NSWindow. That is
        normal. What isn't normal is that the child wrapper's
        unignored accessible parent is a differnt wrapper than
        the caller and that different wrapper is not yet
        attached to an NSWindow.
        
        TODO: switch the AquaA11yWrapper class to inherit the
        lightweight NSAccessibilityElement class instead of the
        NSView class to possibly avoid the need for this hack.
        
        Change-Id: Ic6c2a60e90a154786dd7f5935582ef7d3f57584c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-16  Đoàn Trần Công Danh  <congdanhqx@gmail.com>  [23dcd4339428e4080029ec5ae658e75f01e79a62]

        i18n: fix build with Boost 1.81.0
        
        Boost.Locale since 1.81.0 switch to enum classes for facet type [1].
        Switch our resource manager accordingly.
        
        1: https://github.com/boostorg/locale/commit/e5ed439ea39a4de915e9fb939cca95cae7d9d8d1
        
        Change-Id: Ief215363ceb79b2019606b20a7cde55c8df6a042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143343
        Reviewed-by: Heiko Becker <heirecka@exherbo.org>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [557615d97473dd4faea0914a8064d8525963fe5c]

        Use rtl::Reference to avoid a dynamic_cast
        
        Change-Id: I3b9781cf00df7b740c8b29c6834e54035b255269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144327
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ef52648227557461bcc1224a5af6eaebce2faae7]

        sc: fix null deref in ScDocShell::Execute
        
        See https://crashreport.libreoffice.org/stats/signature/ScViewData::GetDispatcher()
        
        Change-Id: I3271738b3c7f456adad1309c52195d98646f1acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144291
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [c782cc8961fa514b636547dbd0a23dab3f90146b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 63011fa12038ecc796a66fb4fae4851f5b2647c3
          - Document the new SF_Datasheet service
            
            This patch creates the help page for the new ScriptForge service named Datasheet. It also updates associated methods that were added to the Base and Database services.
            
            Change-Id: I6611653b77e1ee41f6afacccb2094f19d7178434
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144183
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [f5e25d077acf6a1b8b28e0c7bfc3201d2bc1ef23]

        likely fix for frequent pShell->GetStyleSheetPool crash
        
        SfxObjectShell: :Current can return null, it's based on the equally vile
        SfxViewFrame: :Current
        Change-Id: I1d937b92188deb06eef36af5d0835e173d588d2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144322
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [a4af2ba1996d2e8441ff52971f90ccdeaa44b2eb]

        svx: check SfxViewFrame::Current()
        
        these ones look potentially worth backporting
        
        Change-Id: Ie7325cd5548c0c10c6b6df9c1a771d24b029b635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [db7b9d1dbfe647c0b859ef0e0fa26e7132ab758b]

        ofz#54334 Timeout on 8192 width/height font and underline
        
        Change-Id: Ib746c28804b0181fe306d53f3f16f70cc36520b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144318
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [e9203786165181badfc96dc121b0abc54778e8d5]

        ofz#54318 Timeout
        
        Change-Id: I76fbf51841f2d5bae38c264af38377f109a8a849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [dca6880983174b97bef60a570f0412a1753c79e8]

        Fix deadlock
        
        ...introduced with 73e062be1ff10e2dd889d9ec9c2d07b692077f62 "blind fix for some
        7.4.3.2 crashes in UpdateCheckJob" (and wreaking havoc during
        --enable-online-update `make check`)
        
        Change-Id: Idde4e4fa8ab94dafa141eb740aba1d874de4717d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144320
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d4222dddfc57688421d7521b693d095075658a56]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e90036912468f58be544b2f12dec0adc7ae8036e
          - tdf#134377 Refactoring more help pages for 'built-in' file dialogs …
            
            Change-Id: Ic128cc9d5d59bd80caa369257000b956bad9f437
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144182
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [a0133459ada8bdc03fd6ae7e509a908ff9581793]

        Merge sdr::table::TableDesignUser into sdr::table::SdrTableObjImpl
        
        Change-Id: Ia7841447df4a7db1b5dd9fad93cab66fbca48981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144316
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Stephan Bergmann  <sbergman@redhat.com>  [60a96f41f0d050ec05bfcb337edf3717689adacb]

        Use rtl::Reference to avoid a dynamic_cast
        
        Change-Id: I1a439df62a33c7edccbbe62e373690b17b2f6161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144315
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [6091603e3c8794c2959f96309286ed782414bb41]

        ofz#54365 Integer-overflow
        
        Change-Id: Id7202e35bd381e36aa8d36a4ae2c9b987f8e9e79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Miklos Vajna  <vmiklos@collabora.com>  [99ed51bcad4008a4006dcec24aa33fd7f757a433]

        sw, numbering portion format: ignore char formats covering the entire paragraph
        
        The bugdoc has a single paragraph, where the numbering portion is bold
        in Writer but not in Word.
        
        The reason for this appears to be that Writer considers text node hints
        for the formatting of the numbering portion where the hint covers the
        entire paragraph, but Word doesn't do this. This behavior was added in
        commits cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion
        format: consider full-para char formats as well, 2022-10-20) and DOCX
        export was also adjusted in commit
        f546f7573158e52359bbeae6194a83a1ff8ac52c (DOCX export, numbering portion
        format: consider full-para char formats as well, 2022-10-28).
        
        Fix the problem by partially reverting the above two commits and instead
        only consider hints that both start and end at the paragraph end. The
        revert of the first commit fixes the new bugdoc (its numbering portion
        is no longer bold) and the old bugdoc keeps working if the sw UNO API's
        text portion enumeration is extended to expose such empty autoformats at
        paragraph end.
        
        Related testcases:
        
        - CppunitTest_sw_ooxmlexport13's testTdf123460 explicitly tested that we
          don't expose the paragraph marker's formatting on the UNO API.
        
        - CppunitTest_sw_core_text's testNumberPortionFormat now uses the new
          ODT markup for these explicit paragraph marker char props (empty text
          span at para end).
        
        - CppunitTest_sw_uiwriter2's testTdfChangeNumberingListAutoFormat failed
          when only the above first commit (layout) was reverted, so revert the
          matching DOCX export commit as well, which is also good for consistency.
        
        - CppunitTest_sw_ooxmlexport18's testNumberPortionFormatFromODT also
          used the old ODT markup, updated.
        
        Change-Id: Iee8acf72dabcd10b3f4d3d68b83ed248bf50c324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144292
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-16  Jean-Pierre Ledure  <jp@ledure.be>  [56ab74cdf90880dbf756c6ee32135a02a98a6ec7]

        ScriptForge - (SF_Datasheet) default values in GetText() and GetValue()
        
        Before this commit, the 'column' argument was manadatory.
        Now the argument becomes optional and designates
        the current column, i.e. the column containing the cursor.
        
        Additionally, when a datasheet is closed by code,
        any filter is better removed to avoid eventual
        user misunderstandings when the datasheet is reopened
        manually during the same session.
        
        Change-Id: I904cfa56a9407539a89b7d2451dcf6b45292f660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144242
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [4a9c9488ee918879e89751a15f3ef0fcbbcd2070]

        sd: check SfxViewFrame::Current()
        
        SfxViewFrame::Current() is a festering wound, these ones look like they
        were safe anyway, so no need to backport. But with enough checked static
        analysis will kick in to flag new unchecked ones.
        
        Change-Id: Ife81c0e5fc508d8eb30808884c61b8e8c6723890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144279
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [70e2383eaad96c8a6079613d9924063f41880724]

        misc: check SfxViewFrame::Current()
        
        these ones look potentially worth backporting
        
        Change-Id: Ie01c0b598c3408f4766318267de8438e997dd1a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144278
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [56e0b27d39e266be49fac93361944878ff763acd]

        misc: check SfxViewFrame::Current()
        
        SfxViewFrame::Current() is a festering wound, these ones look like they
        were safe anyway, so no need to backport. But with enough checked static
        analysis will kick in to flag new unchecked ones.
        
        Change-Id: I2925c4fa4e2d48c1e676ffe7951e65120192517e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144277
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [4a998d9eea012896d4a5d256048407a766fc0bbd]

        sfx2: check SfxViewFrame::Current()
        
        these ones look potentially worth backporting
        
        Change-Id: I9391f266b08e3842f9686db6113b61fa814f3fbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144276
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [b07703963cad433e22fbe9c27f3bee5dc7a7ca63]

        sfx2: check SfxViewFrame::Current()
        
        SfxViewFrame::Current() is a festering wound, these ones look like they
        were safe anyway, so no need to backport. But with enough checked static
        analysis will kick in to flag new unchecked ones.
        
        Change-Id: I28a803be0429b97592d83d88d6c1db077fe31355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144275
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [f9d106a8ecd58f94e48140f8516bc250c1b5e248]

        likely fix for frequent mpGradientItem->GetName() crash
        
        crash report id: ec5a64d7-b354-457e-92a3-1bd51208e7c7
        
        Change-Id: Ie64993190baa5e3ea9228214bea1ee4d82044c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144282
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [b1e38819eaeeb259ede09f8d886d037ae7675f04]

        svx: check SfxViewFrame::Current()
        
        SfxViewFrame::Current() is a festering wound, these ones look like they
        were safe anyway, so no need to backport. But with enough checked static
        analysis will kick in to flag new unchecked ones.
        
        Change-Id: I846a67ca7392182fee6afead8d066fc061ce00be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [1f59a2abcd68aab710e9502b1e00f172f569cb67]

        BP_CHECKBOX should be teamed with some CBS_* part
        
        noticed by Julien at https://gerrit.libreoffice.org/c/core/+/143999
        
        Change-Id: Ic17834d503f174f91200614cd48e6771835cc08d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144252
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Caolán McNamara  <caolanm@redhat.com>  [e717f3a49f700e2e8fdc3c2ba239619e2e1ba2bc]

        sd: check SfxViewFrame::Current()
        
        these ones look potentially worth backporting
        
        Change-Id: I6153b0f9ead7caef9f228a5724f51823bcf87c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144280
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-16  Christian Lohmaier  <cloph@documentfoundation.org>  [4e4a31ac7d920c71e26ca4acd18c11ec2bd015bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53871c4cf5a7703275a2e425b08a4199e9989c46
          - fix missing ) in the if statement.
            
            Change-Id: I6b2a45aeda8969778e902ae71e3fa5e46b82875a
            
2022-12-16  Mike Kaganski  <mike.kaganski@collabora.com>  [76eea55daf6b2b540dfcd2dbee5d578d5bd12e3b]

        Simplify a bit
        
        Change-Id: I45e3cc3f4ef9c4e25ffe07e23b39c1e1fe6fdce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144273
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-16  Michael Stahl  <michael.stahl@allotropia.de>  [4cc101bfc362d4aea1ecc9136b20b73910fa0041]

        tdf#149548 sw: add unit test
        
        Change-Id: Ibb4eadc15f539ee2d4f030c6366c9abd92bc3823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144249
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-16  Justin Luth  <justin.luth@collabora.com>  [88d4e7416921d4c3c71d9effa04ff56a541b169d]

        tdf#151548 vba FormFields: implement Range
        
        Msgbox (FormFields("text1").Range.Text)
        
        Change-Id: Iac195e09bd3f9619890b336a0cb537a1acd00049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144136
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-16  Justin Luth  <justin.luth@collabora.com>  [54599383a2f86b83c237a10f7d9fce492e798487]

        sw content controls: enhance preserve id
        
        Follow-up to 100c914d44ae8f362924fe567d7d41d0033ae8ad
        which added the initial id preservation for DOCX.
        
        adding DOCX block SDT grabbaging, ODF import/export
        [content controls can't exist in DOC format]
        
        The ID field is CRITICAL to preserve for VBA purposes.
        This patch adjusts BlockSDT to also round-trip the id
        instead of just creating a random one.
        
        m_nRunSdtPrToken <never equals> FSNS(XML_w, XML_id) since 2021
        with 5f3af56b2c0ef6c628a7cfe5ce6e86f8e1765f5f,
        so I removed that part of the clause.
        
        I had thought about changing the ID to use a string instead of an int,
        but then the integer version was adopted to fix a regression
        in the commit mentioned earlier.
        
        I think it is AWFUL to have a number as the identifier
        when it will be used in StarBASIC. The VBA guys have to deal
        with it, but it would be nice to do something reasonable
        for LO native access to content controls.
        
        However, the concern would be if we allow VBA macro content created in LO
        to be exported to DOCX format - that would cause problems converting
        from a string ID to a number ID. VBA editing already is happening to
        some extent, and mmeeks seems interested in enabling it.
        So over-all it seems best to just stick with an integer ID.
        
        I used the commits for <w:alias> and <w:tag> to compose this patch.
        XML_ID already existed in include/xmloff/xmltoken.hxx
        and "id" already exists in xmloff/source/token/tokens.txt
        
        The ID can be used in VBA to select a specific control.
        The id (which is a positive or negative integer in DOCX)
        specifies a unique control - either by passing the number as a string
        (of the UNSIGNED value) or by passing as a float (specified with #).
        
        For example:
        msgbox ActiveDocument.ContentControls(2587720202#).ID
        msgbox ActiveDocument.ContentControls("2587720202").ID
        but not as an integer since that is used for index access.
        dim index as integer
        index = 1
        msgbox ActiveDocument.ContentControls(index).ID
        
        make CppunitTest_writerfilter_dmapper CPPUNIT_TEST_NAME=testSdtRunRichText
        make CppunitTest_sw_ooxmlexport17 CPPUNIT_TEST_NAME=testDateContentControlExport
        make CppunitTest_sw_ooxmlexport18 CPPUNIT_TEST_NAME=testTdf151912
        make CppunitTest_sw_core_unocore CPPUNIT_TEST_NAME=testContentControlDate
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlExport
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlImport
        
        Change-Id: I5c4022dc932d941fad9da6d75ce899ee1ff66ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142818
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-16  Noel Grandin  <noelgrandin@gmail.com>  [73e062be1ff10e2dd889d9ec9c2d07b692077f62]

        blind fix for some 7.4.3.2 crashes in UpdateCheckJob
        
        I am guessing that state in this object is being touched from
        multiple threads (since it is an UNO service object), and one or
        more of the threads are consequently seeing inconsistent state.
        
        Change-Id: Ib925740d3b8db2713c4f132d0367b794a412a269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-16  Khaled Hosny  <khaled@aliftype.com>  [718af940435ae9d2ac90374e5880ecb38e96252c]

        tdf#152533: Improve script handling in font preview
        
        Use Edit Engine to get the script types instead of trying to duplicate
        (poorly) its behaviour. This has the advantage of handling weak
        characters and digits properly and is closer to what would happen in the
        document itself.
        
        We probably should go further and render the preview entirely using Edit
        Engine (since the current code fails short of proper bidi handling), but
        this is a bigger change.
        
        Change-Id: I975cb2d96a4a18dbd8110686ca09649cab0ec2f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144284
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-16  Khaled Hosny  <khaled@aliftype.com>  [bfecacb2487ba9470600e6f64056d9b1816ee96b]

        tdf#152460: Improve script handling in style previews
        
        Use Edit Engine to get the script types instead of trying to duplicate
        (poorly) its behaviour. This has the advantage of handling weak
        characters and digits properly and is closer to what would happen in the
        document itself.
        
        We probably should go further and render the preview entirely using Edit
        Engine (since the current code fails short of proper bidi handling), but
        this is a bigger change.
        
        Change-Id: I79b28067d80f66087e1d5e9399ba1a513de96c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144283
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-16  Justin Luth  <jluth@mail.com>  [ba8eb90925aa31be4029b5486a6f5dcd2e9573fd]

        [API CHANGE] related tdf#85592: drop duplicate use of .uno:CharBackgroundExt
        
        The primary purpose of CharBackgroundExt is a bool flag to
        indicate that the watering-can for text background coloring
        is active.
        It could also function as a synonym for BackColor in the "execute"
        state. A prior (NFC) commit removed internal LO use in this way,
        so lets drop the ability to do this altogether.
        
        I'm not sure why anyone would have selected to use CharBackgroundExt
        instead of .uno:BackColor in API calls. Perhaps they discovered it via
        LO_COLLECT_UIINFO. A google search didn't indicate any significant
        use or suggestion to use CharBackgroundExt.
        
        P.S. I'm also trying to deprecate BackColor and replace it with
        .uno:CharBackColor - which is what this bug report is actually about.
        
        Change-Id: I8d8a2aedb1af18e4a10ff09ad0dabc58e90514a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138167
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [37530317f35ad59091cf1fb0850055612fe0d529]

        add three static lines beween tarballs to ease cherry-picking
        
        since otherwise merge-conflicts are likely to occur
        
        Change-Id: I46d507763a4d4287a7450bb81d28aed4279aae1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144247
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-15  Eike Rathke  <erack@redhat.com>  [8e392437fdb8e8d3f2bb3d41a2f06693dc733229]

        crashtesting: assert seen on loading forum-mso-en4-573860.xlsx
        
        While resolving named expression Pinnacle3
        IF(AND(Pinnacle1+Pinnacle2<>11,Pinnacle1+Pinnacle2<>22,Pinnacle1+Pinnacle2>9),SUM(MID(Pinnacle1+Pinnacle2,1,1),MID(Pinnacle1+Pinnacle2,2,1)),Pinnacle1+Pinnacle2)
        
        where resolving and inserting named expressions Pinnacle1
        IF(AND(SUM($Sheet1.$D$3:$E$3)<>11;SUM($Sheet1.$D$3:$E$3)<>22;SUM($Sheet1.$D$3:$E$3)>9);SUM(MID(SUM($Sheet1.$D$3:$E$3);1;1);MID(SUM($Sheet1.$D$3:$E$3);2;1));SUM($Sheet1.$D$3:$E$3))
        
        and Pinnacle2
        IF(AND(Logic1<>11;Logic1<>22;Logic1>9);SUM(MID(Logic1;1;1);MID(Logic1;2;1));Logic1)
        
        with Logic1
        IF($Sheet1.$E$3+NilaiTahun>10;SUM(MID($Sheet1.$E$3+NilaiTahun;1;1);MID($Sheet1.$E$3+NilaiTahun;2;1));$Sheet1.$E$3+NilaiTahun)
        
        with NilaiTahun
        IF(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1))<10;SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));1;1);SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));2;1))))
        
        overall exceeds FORMULA_MAXTOKENS (8192) in the generated RPN
        code, hence an ocStop is encountered as factor token.
        
        (this cries for generating subroutine call token arrays where each
        named expression could have their own RPN code and interim results
        could be remembered for each while interpreting within one formula
        cell; just dreaming..).
        
        Change-Id: I744c4915a00849b107c7c25d7029aa19d976aa86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144048
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [057a5f56a11a47da9cc7015b6d0718e57c442034]

        svx: fix null deref in ParaLineSpacingControl::ExecuteLineSpacing
        
        See https://crashreport.libreoffice.org/stats/signature/svx::ParaLineSpacingControl::ExecuteLineSpacing(long)
        
        Change-Id: Ide29a7e78bf1114f0ebc104fa8c245e52d590eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144239
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ec4409a911fd4a67eb1bc74aae33081ae8510339]

        don't export entries from download.lst - only used by make
        
        no need to plant that into the environment of every recipe. some Jenkins
        Windows builders already run into "environment is too large for exec"
        issue just by attempting a "xargs --show-limits </dev/null" from a dummy
        rule within the make environment
        
        Change-Id: I321fa9075532eef62a7d4e33a08c272276de717e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144217
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d117e3a45e662ac45b96c940459101376445a811]

        create pocheck convenience target
        
        it's usually run bypassing all the dependencies & make parsing using
        
        LD_LIBRARY_PATH=instdir/program make cmd cmd='ALL_LANGS="$(ALL_LANGS)" workdir/LinkTarget/Executable/pocheck'
        
        but it doesn't hurt to also have it as a dedicated target
        
        Change-Id: I742373eb0e4d87ea22c80da0dcaaba7116cd2937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144250
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [3867cb55ddf1bfdefdb7d7a198b275793efb9ed1]

        sw: check SfxViewFrame::Current()
        
        these ones looks potentially worth backporting
        
        Change-Id: I294fa029b53fa9d43cb738f07278301e2a06c210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144245
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [54aa8993baba2a9463a5b412c6c7575efa89bb67]

        sw: check SfxViewFrame::Current()
        
        SfxViewFrame::Current() is a festering wound, these ones look like they
        were safe anyway, so no need to backport. But with enough checked static
        analysis will kick in to flag new unchecked ones.
        
        Change-Id: I359d71bda2ad1f8f720fae1f87a13eae94bb763c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144244
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [183f5e38ee775f2e8c57bd061db80baf7da3b4c7]

        don't export the various language lists and consolidate them
        
        this further frees the environment for Windows builders, to reduce the
        risk of running into "environment is too large for exec" errors when
        attempting to use xargs in a recipe.
        
        Change-Id: I7e0b97163372018edb12329f24bb1dfafeefc526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144235
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [33e26da304922d5e6f46350492324dfce0afb3ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5daaa3e440b17505d644273a7305f073d6d5834d
          - cd to helpcontent2/source/text & drop it from filenames for larger batches
            
            On the Jenkins Windows builder only 40~45 of the ~2500 helpfiles can be
            processed at once when not stripping that prefix. With the shortened
            filenames the build needs less than half of the xsltproc invocations.
            
            Also prevent a trailing carriage return to be interpreted as part of the
            filename on windows and drop the abbreviate_dir wrapper around the
            command since there's nothing left to shorten anymore.
            
            Change-Id: Ifaff26f73f262bd1d7cb4f813bf081782661ba17
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144236
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [f9c857563f2a8837c6ec83851369badbcfa22185]

        sd: fix null deref in ModifyPageUndoAction::Undo/Redo
        
        See https://crashreport.libreoffice.org/stats/signature/SfxViewFrame::GetDispatcher()
        
        Change-Id: Iaf14ad8fd5dab878ea5e3d6997371c2d8a4beac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144241
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [a0c24199e4905c8220fb4254dfd0b263a44626a7]

        likely fix for frequent SfxViewFrame::GetChildWindow() crash
        
        crash report id: 58e9a91e-9feb-4eb4-a28e-27921d3e1b99
        
        Change-Id: I110d96f1c73f95025918ccc4043dac40c5e1dc4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144240
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1e3b7b9ca960e3cfec626bb4b155a791487f810c]

        Fix typo
        
        Change-Id: I5858e828b50972bc31848a9a1d9e76705ffa785c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144214
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [f26248a3ed8a089f15520d200a246ca6d5f3c50c]

        Resolves: tdf#147640 default optional grids hidden
        
        they are always explicitly toggled on/off by the owner, but this
        way they will be no-show-all and not make visible on relocating to
        a new parent
        
        Change-Id: If17cb15988118875a680e4d1a04c148f47c7a7b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144219
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Jean-Pierre Ledure  <jp@ledure.be>  [8a67d717099179bf77bf75d9e7437280e335439e]

        ScriptForge - (SF_Datasheet) minor changes in comments
        
        No effect on code execution.
        Hence no cherry-picks to previous release(s).
        
        Change-Id: I724c05ee2807e2783655cbb8889a721a5a5e1b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144224
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-12-15  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [1c5c31b006f8515bfea440bbcf286f8b4b840aac]

        gpgme: upgrade to release 1.18.0
        
        Remove gpgme.git-4b64774b6d13ffa4f59dddf947a97d61bcfa2f2e.patch.1 as it has applied in 1.18.0.
        
        * 0001-cpp-Fix-building-with-C-11.patch.1: fixed error "no matching function for call to object of type "(lambda at importresult.cpp:154:71)"".
        * w32-include.patch: add missing #include <string> (for std::string).
        * macos-include.patch: add missing #include <algorithm> (for std::any_of).
        
        Change-Id: I45f2ef415d80e6ee848699803e971f154812c9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143039
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [c88dda7e89a0774b203def3d90475c7b668187c2]

        resave with latest glade
        
        Change-Id: I00d1a4e727e411ea91d2a95b081d2a68f2b90ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144218
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [8980a7e8d48eeed0d1550c9efecd7f7300d9f0d7]

        fix BigInt gdb pretty-printer
        
        since
        
        commit 9536098ff107f1096e7f710c6f1e76c5659a5482
        Date:   Tue Nov 17 10:15:11 2020 +0200
        
            simplify BigInt, remove isSet
        
        and
        
        commit 33b8f7c10baead5fdd24d9b68caab54052bd00ba
        Date:   Wed Jan 6 10:41:22 2021 +0200
        
            bIsBig member is redundant
        
        Change-Id: I877364d4b5ed11812c34f2b5d51ec60dd6cca9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [abdad61f123820ed72893a9c2a0d5305ea8386d5]

        Resolves: tdf#95138 add tooltips to calc tabbar
        
        Change-Id: I870c5dc1b81c642c4c7b70de10ecb927758ae29a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Stephan Bergmann  <sbergman@redhat.com>  [c0b59ad6e35b0cb0dea0821e95f95569739078c1]

        Consistently use comphelper::getSomethingImpl<I>(aIdentifier, this)
        
        ...rather than comphelper::getSomethingImpl(aIdentifier, static_cast<I *>(this))
        to delegate to an inherited class I
        
        Change-Id: I85d5b4923428e7082e3dbcea4846eef118f5f201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144211
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-15  Tor Lillqvist  <tml@iki.fi>  [c526b4a58ea6eabf7454566d5e399dbaa3d5d261]

        Simplify selection of iOS SDK, like we now do for macOS
        
        Change-Id: I850a0214d12ef6b5b9a289b34a1467dfe9d35d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144213
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [a13b53e780f541ebd5ca1bf95c8b5c14df30516f]

        crashtesting: relax assert seen in forum-mso-en4-503384.xlsx
        
        maModels.size() is 1 while maPriorities.size() is 2 with this
        offending xml
        
        <x14:conditionalFormatting xmlns:xm="http://schemas.microsoft.com/office/excel/2006/main">
         <x14:cfRule type="iconSet" priority="6" id="{8347056A-0193-48CE-A1F2-602B0108EE9E}">
          <x14:iconSet iconSet="3Symbols2" showValue="0" custom="1">
           <x14:cfvo type="percent">
            <xm:f>0</xm:f>
           </x14:cfvo>
           <x14:cfvo type="num" gte="0">
            <xm:f>0</xm:f>
           </x14:cfvo>
           <x14:cfvo type="num" gte="0">
            <xm:f>0</xm:f>
           </x14:cfvo>
           <x14:cfIcon iconSet="3Triangles" iconId="1"/>
           <x14:cfIcon iconSet="NoIcons" iconId="0"/>
           <x14:cfIcon iconSet="3Symbols2" iconId="2"/>
          </x14:iconSet>
         </x14:cfRule>
         <x14:cfRule type="expression" priority="1" id="{89F2044D-AD8D-477D-AFD2-3E2B711FFBCA}">
          <xm:f>AND($A3&gt;INDEX(Sheet2!$B$2:$B$50,MATCH(C$2,Sheet2!$A$2:$A$50,0)),C3=1)</xm:f>
          <x14:dxf>
           <fill>
            <patternFill>
             <bgColor rgb="FF92D050"/>
            </patternFill>
           </fill>
          </x14:dxf>
         </x14:cfRule>
         <xm:sqref>C3:Q28</xm:sqref>
        </x14:conditionalFormatting>
        
        Change-Id: I3b530be9adaf8a9e98488e8dc25891721ff36244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144212
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a365b4850299778992350c690b064728be6b74ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71788fbef6a5e57e3c902c7e5b33d672a8846abc
          - Mute L10n in BASIC code
            
            Change-Id: I0e6a85285548385935eadd00e69bf2671af3d4c6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144178
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-15  Caolán McNamara  <caolanm@redhat.com>  [ade49eb1b9f99595f4c8864e7c13acebf9fac030]

        Resolves: tdf#92051 add tooltips to section/table statusbar
        
        Change-Id: I649eabbe266085fdbc0ca9c4a5506c0c2a270721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144199
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [6d8b5629d3728aa48751e0a1b690f756b9d546f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 958bceabc62ee570a389d1b18a18b82cc95c9e85
          - Update documentation of SF_Basic service
            
            This patch adds the new CreateUnoStruct method and fixes a few minor issues in the file.
            
            Change-Id: I1369e801d4e86f3413ccd7e13dcae8255e4ff5b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144122
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-12-15  Stephan Bergmann  <sbergman@redhat.com>  [102846d45cb9660805e209b6954c7b8d707b8288]

        Fix another use of gtk_gesture_zoom_new for GTK 4
        
        ...introduced with 7d5841b435a6794e30f02b62db15660ffe4ee39e "vcl: Implement
        touchpad zoom gesture support in GtkInstanceDrawingArea", and fixing it along
        the lines of 903b8f8524b8c84eced3ccbf7cfec9c5b9015f4b "gtk: Fix gtk4 build after
        f2bd19f672023 and e6bed4293814d" and b37e6d2cbd2cfbd5c6eeba81415182c1c766de8f
        "gtk4: connect the zoom and rotate gestures for gtk4"
        
        Change-Id: I7a4521766e537d33ee3bf1787c317095a2e54af8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144208
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-15  Justin Luth  <justin.luth@collabora.com>  [9c1927df9c266834b5a2da4b7f23af0b8e8b8c6e]

        tdf#151548 vba ContentControls: implement Range
        
        This is critical for accessing content control text
        via VBA.
        
        Msgbox (ActiveDocument.ContentControls(1).Range.Text)
        
        Change-Id: I77885909d82e209d909e3bddff08894c1989286f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144135
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-15  Tünde Tóth  <toth.tunde@nisz.hu>  [fd831c28bfc29d9d5fe2b3074324d4cbc4a70689]

        tdf#152310 DOCX shape import: fix lost text color regression
        
        Don't apply COL_AUTO as color of the run.
        
        Regression from commit 49a40e3ed200e7c6d728f36d0b4be22dd85c51be
        "tdf#135923 DOCX shape import: set text color".
        
        Change-Id: I9c2088b4c531f09c80715bffdae225ac0987be79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143533
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-15  Miklos Vajna  <vmiklos@collabora.com>  [fb7f214032c3455a9e7213a5067ac31585413e0d]

        sw doc model xml dump: a text node doesn't own its numbering rule
        
        Just remove this from the dump: SwNumRuleTable already provides the same
        info (it owns the numbering rule) and the text node already shows the
        numbering ID in its SwNumRuleItem.
        
        Change-Id: Id55db5e41d5923073d04c2a1f9e996766d7484e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144195
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [15df8e5422010e0806eb9e93bd8822519c1ab989]

        UnoApiTest: introduce CPPUNIT_ASSERT_RECTANGLE_EQUAL
        
        and get rid of duplicated code
        
        Change-Id: Iccbd3147fab71b43b1725af308df8ed37c807b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144173
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [99fc50c4facbe87642717faa0d780889168eabfd]

        sc: introduce CPPUNIT_ASSERT_POINT_EQUAL
        
        and factor out code
        
        Change-Id: I80df957410d1ff4de0cd0f6833790e14714859f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144171
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-15  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [7ef97c19491a407828a200968139540e51604118]

        sw: Fix uiwriter6 unit test
        
        From "tdf#124603 sw: pressing Up/Down triggers pending spell
        checking", only assert GetWrong() after moving cursor out of bad word.
        
        Change-Id: I0e722e5c56713fe1a2a7c672d7aab76438d1727f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144202
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-15  Tor Lillqvist  <tml@collabora.com>  [bc05ac6ea8f53954e363ec3bfde8308710258b10]

        Need to mention libxml2 here, too, when building for Emscripten
        
        Forgot this in 563c28b6508ac836fbe46369a4d2d300cda650cf.
        
        Change-Id: I8675273c461f1b83b4dbe8bb7f9f58130a1d77fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144200
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-15  Patrick Luby  <plubius@neooffice.org>  [9ec57a3dc7925d6f86a19d0e179e065df53e542f]

        tdf#145843 Do not use CGBitmapContextCreate() to create a bitmap context
        
        As described in the comment in the above code, CGBitmapContextCreate()
        and CGBitmapContextCreateWithData() will try to access pixels up to
        mDirtyRect.x() + pixmap.bounds.width() for each row. When reading the
        last line in the SkPixmap, the buffer allocated for the SkPixmap ends at
        mDirtyRect.x() + mDirtyRect.width() and mDirtyRect.width() is clamped to
        pixmap.bounds.width() - mDirtyRect.x().
        
        This behavior looks like an optimization within CGBitmapContextCreate()
        to draw with a single memcpy() so fix this bug by chaining the
        CGDataProvider(), CGImageCreate(), and CGImageCreateWithImageInRect()
        functions to create the screen image.
        
        Change-Id: Ic83f6162f8eb63de22693c0c40015da3b88aee65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144194
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-15  Mark Hung  <marklm9@gmail.com>  [ae6e57d99cfdeac69cc42cd82904c24edc866310]

        tdf#152031,tdf#152085 minimize impact to table layout.
        
        Revert two commits[1][2] that are related to fixing tdf#135991
        ( but keep the unit tests) and rework the solution.
        
        Cases related to IsNeighborFrame() imply either IsCellFrame()
        ( a table cell ), or IsColumnFrame() ( a column inside a
        section ).  Original patch[2] affected both of tables and
        sections.  Try to limit the affected case to the section
        so it does not affect table layout for tdf#152031.
        
        [1]
        1bf82b26aea3a403920a64cdfcb4671c947c7a01
        Author: Mark Hung <marklm9@gmail.com>
        Date:   Fri Sep 9 16:09:47 2022 +0800
        
            tdf#150642 fix table layout with vertical writing.
        
        [2]
        1e21902106cbe57658bed03ed24d4d0863685cfd
        Author: Mark Hung <marklm9@gmail.com>
        Date:   Sun Aug 14 15:23:14 2022 +0800
        
            tdf#135991 fix unexpected hidden RTL sections.
        
        Change-Id: If50e2b50b47352dad8eafebd6cce0af0530abefa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143317
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-12-15  Justin Luth  <justin.luth@collabora.com>  [28ff4647e9dac8eebe3a169e828bacc8dc78e363]

        tdf#151548 vba ContentControls: showingPlaceholder improvements
        
        I reviewed the effect of the recent change to how showingPlaceholder
        status was reset. It really didn't have any effect that I could find,
        but the code review resulted in these minor improvements.
        
        Change-Id: I4ba8da694c1dd4a4e7c77fe0cf20e5a5082564df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144134
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-15  Jim Raykowski  <raykowj@gmail.com>  [bef199febca711c9aa3fd199e8ca525b7d97a04f]

        tdf#152029 Bring comment fields to attention in the document view
        
        when the mouse pointer is over comment content type and content entries
        in the Navigator content tree
        
        Change-Id: I81f8667231fe0e94f0b81c4c2d4955ba17aaa3da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143979
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-14  Tor Lillqvist  <tml@collabora.com>  [52c3744d0669eafadb8e30f500edb9dff0bd7e3d]

        Update Qt5 build instructions to use Allotropia's pre-patched repo
        
        Change-Id: I4b739e36a008940705b32a2c83757520e2ae1add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144196
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [c6a8af20c82e3be1c1cc48ef16fb8c323e2fda95]

        Revert "Add oox to build side, for cross compilation"
        
        This reverts commit 599f9836a674ec525e56fa787a800d7ed4be3383.
        
        Reason for revert: It doesn't do anything, see 144170 for next attempt.
        
        Change-Id: Ibccf022c574e4fe527c8435eeaa6196c36ca1c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144176
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [5450f0a2417ab50ed41dd5b6e3265d9a8e534df9]

        add oox to WITH_GALLERY_BUILD build side
        
        This is needed for WNT/ARM cross build since commit
        ce4c154e8b254f3bcd59ea46b3db4bd3d5a26058.
        
        Change-Id: I03cf9a2bb3bc505772b1bd2a2d96cd2b29cf14c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144170
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [e5d68c4a4ad953d4d7d99103ee2181be38cd025b]

        Resolves: tdf#152495 crash on dismissing ruby dialog with ESC
        
        Change-Id: I26af008a7ee7b105255a1aaacff7ff30813172a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [040867fce9a992b34813dab3a4d7ab93ebccbe11]

        table cel->table cell
        
        Change-Id: Id817e6da3c445d827584d1ece9aba195f641d506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Miklos Vajna  <vmiklos@collabora.com>  [724180ec495a696c79332653cb6fb52ecfbccc29]

        sw: add a new .uno:UpdateBookmarks UNO command
        
        Current the .uno:InsertBookmark command allows inserting a bookmark with
        a provided content into the document, but an existing bookmark can't be
        updated similarly. This is a problem in case Zotero citations are to be
        modeled with bookmarks.
        
        Another trouble is that bookmarks don't have dummy characters, so we
        need to be careful to replace the content in a way that maintains these
        bookmarks, a naive delete + insert will collapse them.
        
        Fix the problem by introducing a new .uno:UpdateBookmarks command,
        somewhat similar to what commit 7765b442e13048f857fd7ee49ced1731caee297e
        (sw: add a new .uno:TextFormFields UNO command, 2022-11-28) did.
        
        As usual, the provided new text is meant to be HTML, which allows
        multi-paragraph, formatted content.
        
        Change-Id: Id5bb3fd2fd9e147d98709b5a7e0c322e73c6d283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144167
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [705594fc805012b5bf6167d7f9fee63bb1b90a1b]

        loplugin:implinheritancehelper in sw
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I0bf96b2e3d897d19d4883c2958c72fbfe3b61080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ddbce1ef9e5b27b7d6576a30936722b5c5232eb]

        loplugin:implinheritancehelper in svx
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I8c966d372b94c2ab1296bc7ed6613da8dae818d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144163
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [3c2effa9057ab51c2cfff72673e1e4512d025b23]

        Restructure the code more logically
        
        Change-Id: I50bc16a0158e26ffc2ae121697ed23ccf3ca7f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144123
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6fd64a87add9958b603b6851e0d477c4f596c22f]

        loplugin:implinheritancehelper in framework
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: I47eefb8edc2041fa89e64f930b1997566562d51a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [c43a4b0ffd96caaba64b228b059ee5c26049f399]

        loplugin:implinheritancehelper in dbaccess
        
        use more ImplInheritanceHelper to reduce boilerplate
        
        Change-Id: Iefeccd009ae03d0dda8b9ff436408d747052b8af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [c7b93e2687af1bf26b0843e3d815effd129752f6]

        Bump minimum macOS to 10.15
        
        This gives us support for filesystem library
        (after GCC is bumped to >7)
        
        Change-Id: I5e497ee818de883e63e1288acfc400ebadf0cdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144156
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-12-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [a2ceb003eff5a886638758a96834466e750cf314]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 07a7f0f505d659779dfe7d344e65fd47d38f111e
          - Document new FilterFormula and FilterScope arguments in SF_Calc service
            
            This patch updates the ScriptForge's Calc service to document the FilterFormula and FilterScope arguments that were added to the following methods:
            - ClearAll
            - ClearFormats
            - ClearValues
            - SetCellStyle
            
            Change-Id: Ice17a37ca49576f07be7f57800b11050054d90b3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144057
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [80f4abfea971cf66259b65fe09366d31ed41809d]

        tdf#149595 sw: fix showing of fly at start/end of single-para delete
        
        ... with change tracking enabled.
        
        Corner case where there are no extents for the node but the deletion is
        in a single node (i.e. delete from node start to node end).
        
        Make this consistent with what happens without change tracking.
        
        (regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5)
        
        Change-Id: Ib63c4108c86c36508e1a378824ab3511dc46ae47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144109
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [c684301352bcca709bc8d1c99e0f08e7096e9716]

        (related: tdf#149595) sw: also re-sort SwSortedObjs on SwPageFrame
        
        ... if SwTextNode content changes; for the unit test here we get:
        
          Error: elements in iterator range [first, last) are not partitioned by
          the predicate __comp and value __val.
        
        Also, the SwTextNode may have multiple text frames on multiple pages.
        
        Change-Id: I05d4276e4b4b94fe3cd2cdfda3418ad51fa08f5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144108
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [5d713d110e37451d87f620793304f0f1c9b8dfcc]

        Simplify lcl_SuffixIsUser
        
        Change-Id: Ia8fbfd509541586ac7ae1f4a79230eda34f27956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144027
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [002d3a9474d92929df8089ee03f6277f45a5ef77]

        cid#1212509 Logically dead code
        
        accept the original logic then and drop the dead path instead of
        the attempt to "fix it" of
        
        commit 0d6f45377592a62ff4ee510d5fbd3bdd9e20160a
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Wed Oct 15 09:52:01 2014 +0100
        
            coverity#1212509 Logically dead code
        
        Change-Id: I373a85f53ceb395e27f85cc44cd17f650088b5f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144160
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [6880d32d851783a56c977872df5fbf11b507876a]

        Resolves: tdf#151753 'revert coverity#1212509 Logically dead code'
        
        revert 0d6f45377592a62ff4ee510d5fbd3bdd9e20160a:
        
            coverity#1212509 Logically dead code
        
        Change-Id: I8eb7355a94ce2c93faa18c77be63de41bccd3a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144159
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [4368c4bf80b2751705c500f2574d9cc3d0ee13a1]

        starmath: React to touchpad zoom gestures in SmGraphicWidget
        
        Change-Id: Id158d7778ec0c375c143cf9ce492af21b9625c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143759
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [7d5841b435a6794e30f02b62db15660ffe4ee39e]

        vcl: Implement touchpad zoom gesture support in GtkInstanceDrawingArea
        
        Change-Id: I5ad68ee424fbcc45a3e56045f00ac41cf6c80195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143758
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [ccfb36da48a938c7d95b3d6af5862b14721208ef]

        sc: React to touchpad zoom gestures in ScGridWindow
        
        Change-Id: I21f0e6a820149abe4457950e7382bbc7752eeb6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143757
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [90f5ecbbdb202ec4fbee9e1416f9268aa1dc56ba]

        sc: React to touchpad zoom gestures in ScTabView
        
        Change-Id: I9a946c0caf3aab03a2055740a4f467210dc07b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143756
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [f87a0480af5b15d673490a5b1736133148ec7333]

        sc: Extract ScTabView::SetZoomPercentFromCommand()
        
        Change-Id: I06ece9a99886d94bf0b3396730951760cb199e97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143755
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [cedf0458966b6e7e4398b45ee77f77053d43e79c]

        sw: React to touchpad zoom gestures in SwEditWin
        
        Change-Id: I45a3525f3db47b2ea002a592df144a83ee39fc68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143754
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [9807fbfb56edd9998d3e8757b11f50cfa6887535]

        sw: React to touchpad zoom gestures in SwView
        
        Change-Id: I337e5d6873f9cf6d78cb53b2ffdb59a33a9465f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143753
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [0280538af13617145987663ad6407190939794f2]

        sw: Extract SwView::{MIN,MAX}_ZOOM_PERCENT constants
        
        Change-Id: Id593752274121ad41dcdeb215be410a3577d890a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143752
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Povilas Kanapickas  <povilas@radix.lt>  [45d861a38d7cd3031bd577fd954b11e5d7a99f8d]

        sd: Improve reaction to slow zoom gestures in ViewShell
        
        The current implementation will ignore slow zoom gestures because each
        event may result in zoom change of less than 1% which will be truncated
        to zero during floating-point -> integer conversion.
        
        Storing accumulated amount and changing the zoom level once a whole
        integer quantity is accumulated solves this problem.
        
        Change-Id: If27a88d7695d0eed241dada5a09b25b2cb577841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143751
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d39c37b61fb2e4d03f5f58a38ba2265064db50b]

        Fix typo
        
        Change-Id: I1d50f4b47ba32ee6dfd76d3165f15903746de46c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144112
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [56e17186ffcda7e93530bef3a06120584bb7d579]

        [API CHANGE] Merge sfx2::XmlDump into css::qa::XDumper
        
        Both sfx2::XmlDump and css::qa::XDumper were (only) used to dump various data
        from ChartModel and ChartView instances in debugging (e.g., F12 and Shift-F12 in
        an SW_DEBUG=1 Writer) and testing scenarios.  The problem with XmlDump was that
        it was used as the target of a dynamic_cast from a UNO type, which is dangerous
        (see the upcoming commit introducing loplugin:unocast for details).  One fix
        would have been to replace that dynamic_cast with a use of XUnoTunnel, and make
        ChartModel and ChartView implement that.  But those classes already implement
        XDumper, so it looks more natural to use XDumper for that purpose too.
        
        However, the information that was obtained via XDumper was rather different from
        the information that was obtained via XmlDump.  So make an incompatible change
        to the (unpublished) XDumper, adding a kind parameter distinguishing the
        original behavior of XDumper (kind == "shapes") from the original behavior of
        XmlDump (kind == "").
        
        Change-Id: Ia7379bedfc45ab62a298fdc2f030cebaf21c4885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144145
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [8bdb85f8c7f31e51328afa51a584c3cfdea1c06f]

        upgrade to libtiff 4.5.0
        
        Change-Id: Ic54ecba50862860a67f92a2fc6e45fd275fa9a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Gülşah Köse  <gulsah.kose@collabora.com>  [e9356f9ced3167cd927e98617bab54048cc63073]

        tdf#152483 Fix the insert hyperlink behaviour on Calc
        
        Cursor invalidation message shouldn't carry a hyperlink info to online
        side if there is no hyperlink under the cursor
        
        Change-Id: Ibdb6e32d029e101212d03bc117a5a14a712822ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143986
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [8faeb46a5d4bb7301968281a1edf5fc0b6278e53]

        Resolves: tdf#152501 forward replacement ComboBox query-tooltip to original
        
        Change-Id: I7c56ce58a00d87ce1699bffdf36c9842ac579161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144158
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [ba76f0ba7e8de4d2953739c952004b7d9af47197]

        loplugin:unocast (i18npool::Calendar_gregorian)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I1b0e544145c364cb9ee669b913132f41c1a8a66a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144147
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [840154daf934d8df52ead1cb7acd798c4d30f007]

        loplugin:unocast (framework::AddonsToolBarWrapper)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I8014f683b939da9d638545c77dbddb3e478a385e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144143
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ff598ae2d2d356c1c7b1e3e9190eb1f02a74c1da]

        Fix typo
        
        Change-Id: I6d85db36bb94215b912827746b220a21a1b472a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144111
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [c9de64e92cac1f4b9907399d7f51f70021f7e39c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 970907045a2400da7ed6e3d14ef76f7ad3b2d783
          - Fix prepending xargs to gb_ExternalExecutable_get_command, help part
            
            ...as was done in f048f02f505704a76c4f01b4ff3f369e8ed928b5 "hid2file.js
            generation: process in batch, not each file one-by-one", causing my build to
            fail with
            
            > [XSL] CustomTarget/helpcontent2/help3xsl/hid2file.js
            > xargs: LD_LIBRARY_PATH=/home/sbergman/gcc/trunk/inst/lib64:/home/sbergman/lo/core/instdir/program:/home/sbergman/lo/core/instdir/program: No such file or directory
            
            Change-Id: I94ea42878de55a887e6955b350997425438bb90e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144154
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [3d117dcc4a705f477c8223978200756ac9f83fe3]

        Fix prepending xargs to gb_ExternalExecutable_get_command, core part
        
        ...as was done in
        <https://git.libreoffice.org/help/+/f048f02f505704a76c4f01b4ff3f369e8ed928b5%5E!>
        "hid2file.js generation: process in batch, not each file one-by-one", causing my
        build to fail with
        
        > [XSL] CustomTarget/helpcontent2/help3xsl/hid2file.js
        > xargs: LD_LIBRARY_PATH=/home/sbergman/gcc/trunk/inst/lib64:/home/sbergman/lo/core/instdir/program:/home/sbergman/lo/core/instdir/program: No such file or directory
        
        Change-Id: I5a58874aa746de13cfc86b691c11349196092dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144151
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [fde7a73e5fa733cde679d6c9ac42e5c1f7cc9a94]

        upgrade tag names with new version of glade
        
        Change-Id: Idcbf12c72eea8f7c8b4c7e787eeb2719f29cc69a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144152
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [b0e9c4c5f063cefa9557810e3349bdb9c7493091]

        loplugin:unocast (GrammarCheckingIterator)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I4ecaa3cfafbb2e01ede956e4f3f6d58f40bdbb57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144146
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [8ee6cfc9655ce9de4617cea1a0d9cb9d7a4fbfac]

        loplugin:unocast (ucb::ucp::ext::Content)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: If35b179b83383d8252a356c5bf43ae6ebb1d63f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144148
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [269e1588ced9de990aeb50ed8aedf9117699a99b]

        Add precisions in extended tip
        
        Change-Id: Ic339db77ba4064f7a4cf7533740e7a0f98955453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143922
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [5b8cd77c112bc8c0e92b8fec215c3c8e802bbc0a]

        loplugin:unocast (basic::SfxScriptLibraryContainer)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: I962b2a11a6407a543fb8b4ad972128d59f62a8a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [9e73ff9fce12e102bb3c3cea8d8bb96c88f2c9ad]

        loplugin:unocast (sdext::presenter::PresenterNotesView)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Iee184c75fb5d4a8f00b932c001df023de795c469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [a98acca8fbc38d3fd5600ae5056a8e42b6d8a40d]

        loplugin:unocast (SelectionChangeHandler)
        
        (See the upcoming commit introducing that loplugin:unocast on why such
        dynamic_casts from UNO types are dangerous.)
        
        Change-Id: Ibc2511c8521923c854e4b450649ea616581af2fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144141
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [276e3ccbdd3259ec3daf8a1a98fa7f406b14e21c]

        loplugin:unocast (vclcanvas::RepaintTarget)
        
        (The overall inheritance hierarchies of the classes deriving from RepaintTarget
        are so over-engineered that it looks easier to make each of those classes derive
        from css::uno::XUnoTunnel individually, rather than deriving RepaintTarget from
        something like cppu::WeakImplHelper<css::uno::XUnoTunnel>.  And see the upcoming
        commit introducing that loplugin:unocast on why such dynamic_casts from UNO
        types are dangerous.)
        
        Change-Id: I4bcfad4049a2fb366768602a432c1282c2bf477e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144140
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Caolán McNamara  <caolanm@redhat.com>  [cbb3f697245d7d57439cb5019e9f9834cb9cd35f]

        tdf#152486 unreadable infobar buttons in macOS dark mode
        
        These are the buttons in infobars where the infobar has a custom
        background color and on these platforms the buttons blend with their
        background. On other platforms the buttons typically are opaque
        and the issue doesn't arise.
        
        Change-Id: Idfc4bbf291953bbf27e73cd5dd7654fd1ce4b051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-14  Justin Luth  <justin.luth@collabora.com>  [908d058c67c4efb3dc142ea8d6ad59badf01c9c6]

        tdf#151548 sw content controls: preserve tabIndex
        
        This has to be vital to keyboard navigation.
        Certainly it is good to have it imported
        before we start to consider tab-movements
        for form controls.
        
        All tabIndex 1's are processed (in placement order)
        and then the 2's etc. 0's are to be done last.
        
        XML_TAB_INDEX already existed in include/xmloff/xmltoken.hxx
        and "tab-index" already exists in xmloff/source/token/tokens.txt
        
        make CppunitTest_writerfilter_dmapper CPPUNIT_TEST_NAME=testSdtRunRichText
        make CppunitTest_sw_ooxmlexport17 CPPUNIT_TEST_NAME=testDateContentControlExport
        make CppunitTest_sw_core_unocore CPPUNIT_TEST_NAME=testContentControlDate
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlExport
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlImport
        
        No existing unit test found containing blockSDT with tabIndex.
        
        Change-Id: I8a958844e6192b079a2b22a62dedfd8739021f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143603
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-14  Miklos Vajna  <vmiklos@collabora.com>  [e15658a7576c8160c9f1b861201e206f9cf34df9]

        CppunitTest_sw_core_layout: clean up testFollowTextFlowWrapInBackground
        
        Use SwFEShell::Insert() to insert a graphic instead of duplicating it.
        
        Change-Id: I99b6ebda4d8e4d0c7ec9d8dc34348b66b56951ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144105
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-14  Stephan Bergmann  <sbergman@redhat.com>  [71085deec7a24ed6650a1e6a07dcbb822ab4334d]

        CppunitTest_sw_globalfilter also needs the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so" now, presumably since
        31084ebb59093be7dfe5ab53a20fdb3bcfde34b6 "tdf#143311
        offapi,oox,writerfilter,xmloff,sw: decorative flag on flys"
        
        Change-Id: Ic8a29c0fea8b34d95745a4e7d1c8e4b74da64653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144106
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-14  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [5816474c37293cc791fdb9cb042d11be7d809d0b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3b1cce7dde7e964c7670dd24a167e750654685a
          - tdf#132398 Update icons for Online help navigation
            
            Change-Id: Id6c5bb5d486cd045238205318a6f99339716c117
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144138
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-12-14  Eike Rathke  <erack@redhat.com>  [0517ef1669dba0e055b8ef3cf09a4b40378e476f]

        It's unnecessary to obtain what's not being used
        
        Change-Id: I3b5a2a8a2b095e77f71629910628ca7fe54aac25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144113
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-13  Eike Rathke  <erack@redhat.com>  [d5986b163276008d2a15a10f7de529d924b60d2f]

        crashtesting: (assert) fix treatment of "#FMT" input line value
        
        For "#FMT" test the original format type for not being NUMBER, the current
        format type may be different from finding an edit format.
        
        This constellation did not matter until
        
            commit 4fd1333ba4bb4f2311e9098291154772bd310429
            CommitDate: Thu Mar 25 15:00:31 2021 +0100
        
                tdf#140968 tdf#140978 XLSX import: fix lost rounded filters
        
        introduced the bFiltering parameter in which case the edit format is not
        used (and bFiltering is also set when collecting the filter entries for
        .xls export). In fact the logic should be changed such that obtaining
        the edit format isn't even executed in that case. For now just fix the
        "#FMT" case to be backported.
        
        Also, the bool return of
        SvNumberformat::GetOutputString(double,OUString&,Color**) does not indicate
        success or failure, but whether the "star" asterisk spreading was inserted or
        not. Contrary to SvNumberformat::GetOutputString(double,sal_uInt16,OUString&)
        ... cough.
        
        Change-Id: Ic8cbbd283a80c654a9ff22ea36897c9b72b8837d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144110
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-13  Jim Raykowski  <raykowj@gmail.com>  [a2d211359b082db33153e9bc22c2184f2de1131e]

        tdf#152029 Bring footnotes and endnotes to attention in the document
        
        view when mouse pointer is over footnote and endnote content type and
        content entries in the Navigator content tree
        
        Change-Id: Iec1c2112aa934e21340fd2a21ea4b3bf8d1ce9cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143900
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-13  Tor Lillqvist  <tml@collabora.com>  [563c28b6508ac836fbe46369a4d2d300cda650cf]

        Use libxml2 instead of expat in bundled fontconfig in the Emscripten case
        
        For just running LO itdelf as WASM it presumably does not matter. But,
        when building Collabora Online as WASM, using expat in fontconfig
        turns out to be problematic.
        
        The Poco library that Online uses includes a bundled expat
        library. For some reason the function signatures in that expat are
        different from those in the bundled expat library from LO core. Thus
        you get "RuntimeError: null function or function signature mismatch"
        as only the Poco copy of expat gets linked in in the WASM binary and
        when code in fontconfig tries to call expat code the signatures don't
        match.
        
        Change-Id: Ic035bb7aab06564ad0050519a2d7a0975ad3a14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144049
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-13  Stephan Bergmann  <sbergman@redhat.com>  [45003656f41858de86de38c9ef4441fb227d7bc8]

        Mark external/cppunit/propagate-exceptions.patch.0 as upstreamed
        
        Change-Id: I847b682c2823dcaf523f361044105e91462fbc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144075
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-13  Miklos Vajna  <vmiklos@collabora.com>  [9a0e31fcb7fa871fa63abe106d83a04df2f4c74e]

        sw: rename SwFormat::m_bAutoUpdateFormat to m_bAutoUpdateOnDirectFormat
        
        To make it more obvious that this flag describes the relatively obscure
        feature where a direct format on one paragraph automatically makes it
        into its style and all other paragraphs with the same style are updated
        accordingly, kind of preventing real direct formatting.
        
        Change-Id: Ia97929cd65f1aa0ff7f11425ec6d00f234053921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144051
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [55e2d3f45dbd404f20021a4b1d5d5184d24a3cbf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd924ae6a0bd8fbaad2ee4bcac7d4ccd7c689a59
          - Update documentation of SF_Dialog and SF_Dialog control services
            
            This patch does the following changes:
            1) Explain how to handle exceptions in dialog and control event handlers (both in Python and Basic)
            2) Document the new SetPageManager method
            3) Plus a few minor fixes in the text
            
            Change-Id: I4f7b3bfae025b45214b90dd036ecdbf4977d47e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144018
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-12-13  Christian Lohmaier  <cloph@documentfoundation.org>  [2a9de94ced1d40e16e5e74bd9733eed895234ca3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f048f02f505704a76c4f01b4ff3f369e8ed928b5
          - hid2file.js generation: process in batch, not each file one-by-one
            
            xsltproc can happily process many files at once, no need to process them
            individually and also no need to surround them with the rm, touch, rm
            triplet each time to catch a possible error.
            When letting xargs actually run the command, then xargs will report
            error if any invocation failed. It will not stop execution commands for
            remaining input unless the command exists with status 255 explicitly,
            but this doesn't matter, processing the whole batch regardless is still
            much faster than processing each file separately.
            To maximize the number of files that can be processed in a single
            command, don't prefix each file with $(SRCDIR)/, but instead cd to
            $(SRCRDIR) before running the command.
            
            Change-Id: I532a54f7298d7011900af5e618d75b37649b0477
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/144050
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [15cce9806cff49d54a80b047dec33b021080d5cb]

        Fix the "Found char > 127" warning to check the correct characters
        
        Change-Id: Ia4a713c8a5ddda11e9802cbc317dde9ff48b8fd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144026
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-13  Christian Lohmaier  <cloph@documentfoundation.org>  [dc3b41f1d08479b9732b065b88f8a02512a96e47]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5b99afe8ba3afe1a4673f8b7628011ced5583570
          - avoid needless rebuilds of helpimages
            
            also the create_ilist.pl doesn't really do much anymore, was easily
            replaced by a plain $(file …) call
            
            Change-Id: I63a41ef8ed289feb4ab210961d2200032adaac28
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143936
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0cae68768e92b1d735baa2e02602b4f6fe17d13e]

        don't rebuild Gallery themes if nothing changed
        
        Change-Id: I49fe9d36550a3f712be57fd4e67f0606ee8feea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143909
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0ff4b4a08deace66567d6248af9e41fc7336a1c1]

        don't rebuild icon-themes if nothing changed
        
        Change-Id: I99ab68852d1f6e915a4cd92a4be2d28209e546ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143934
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8b87e29c987c599058a70f6a2e0259a2a4100f04]

        use $(file …) directly instead of gb_var2file when not used as intermediate
        
        i.e. when the temporary file is not uses as a responsefile for another
        command, but instead the point of running gb_var2file is to have that
        file as a result in the end.
        
        also move the helper into the main gbuild.mk and remove Tempfile.mk
        
        Change-Id: I79382bef5d7e8a155ba6a8e0750c6a17da42eb37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143912
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  Christian Lohmaier  <cloph@documentfoundation.org>  [dad5becaca9e5ee97a0cfbf3336461d752d6064c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e1cf5179765728ac70b100352ffb09bc1ec3fde5
          - gb_var2file: remove now unused chunk-size parameter (help repo)
            
            Change-Id: Ie0a310b004d969b62c9ee886fee3e8e50d6e5184
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143935
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f127fa685dfe4999a2aab24e7b26dca5ab9919fb]

        gb_var2file: remove now unused chunk-size parameter
        
        that parameter did specify how many entries of the list the workaround
        method could use to not exceed commandline length limits, so it was a
        guess of sorts and many places didn't actually bother with tweaking that
        value anyway and just used 100. the $(file …) function doesn't care
        about that, so the parameter was always ignored in that case.
        
        Change-Id: If89ec3a1968be297c0fe7c65336c5a965598f0c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143911
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [57c5d044dc16f488788584851e8b9cc0cf98e8e0]

        bump minimum make version to 4.0 (for $(file …) function)
        
        This already was a requirement for Windows for a few years now, and make
        4.0 was released nearly 9 years ago, and it has been used in LO's build
        system since it has been added 11 years ago while it was only available
        in prerelease versions of make, providing an alternative workaround for
        systems that didn't have make built from cvs… I guess it is finally time
        to get rid of those workarounds and just require make 4.0 for everyone.
        
        NOTE: reading files with the $(file …) function was only added with
        version 4.2 of GNU make, and just using it without contents was added in
        4.1, so those usages aren't supported
        
        Change-Id: Ia1c2c86cfdbbd81f349bb9f7188299e16bdd155f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143910
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  László Németh  <nemeth@numbertext.org>  [71dc8a291ecc5bdae541fce41c8895d6b3302082]

        tdf#45949 sw: add spell checking to hyperlinked text
        
        Recognize plain words within hyperlinks and
        check their spelling.
        
        Not only URLs and e-mail addresses, but plain
        text of hyperlinks were removed from spell checking,
        which didn't conform to the specification:
        
        "URLs are skipped during spell checking
        
        Spelling of URLs in document doesn't make sense, because the words
        are not separated and often they aren't natural words at all.
        Since we can only decide what we know, we will only except URLs
        from spelling already recognized/formatted as URLs and if the URL
        and the text representation are equal."
        
        http://specs.openoffice.org/appwide/linguistic/Spellcheckdialog.sxw,
        see also https://bz.apache.org/ooo/show_bug.cgi?id=40133.
        
        Follow-up to commit ec8fdffec29de7c80da0c2a440e467c35a297119
        "tdf#152492 sw: fix unwanted spell checking of parts of URLs"
        and commit 2cca160f8bfc4597cf0ad3aaaf0017a5210ea0ec
        "tdf#126657, tdf#145104: Don’t set language to none on defined
        styles".
        
        Change-Id: If2698c54bcdee0de635abd324173c909d9161a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144044
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-13  László Németh  <nemeth@numbertext.org>  [ec8fdffec29de7c80da0c2a440e467c35a297119]

        tdf#152492 sw: fix unwanted spell checking of parts of URLs
        
        In new documents, spell checking started to report
        spelling mistakes within the recognized URLs.
        
        Regression from commit 2cca160f8bfc4597cf0ad3aaaf0017a5210ea0ec
        "tdf#126657, tdf#145104: Don’t set language to none on defined
        styles".
        
        Note: skipping spell checking of recognized URLs was specified by
        http://specs.openoffice.org/appwide/linguistic/Spellcheckdialog.sxw,
        see also https://bz.apache.org/ooo/show_bug.cgi?id=40133.
        Unfortunately, the original implementation caused possible
        regressions in text layout, so it was reverted in the
        previous commit.
        
        Change-Id: Ic5f84c8ec195677640a8870f2c484f3b6ef8b9db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143946
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-13  Jean-Pierre Ledure  <jp@ledure.be>  [57e2245abf50cbd207d5c9c57ed67c055f8afcd6]

        SF_Dictionary: tdf#152351 Fix ReplaceItem does not accept array as value
        
        Next basic code
           Dim myDict as Variant
           myDict = CreateScriptService("Dictionary")
           myDict.Add("key", Array())
           myDict.ReplaceItem("key", Array(1, 2, 3))
        produces an error message incriminating the user code.
        
        While it should run normally ...
        
        Fixed by enlarging the validation rules.
        
        Change-Id: I667abc81cb712308764c342d0e74b95821e46a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144041
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-12-13  Justin Luth  <justin.luth@collabora.com>  [65fa248f9a9504747a63698746350db139ae53ce]

        tdf#151548 sw content controls: preserve lock
        
        DOCX SdtControls can be locked in two ways:
        -Content Control cannot be deleted (sdtLocked)
        -Contents cannot be edited (contentLocked)
        or both (sdtContentLocked)
        
        make CppunitTest_writerfilter_dmapper CPPUNIT_TEST_NAME=testSdtRunRichText
        make CppunitTest_sw_ooxmlexport4 CPPUNIT_TEST_NAME=testSimpleSdts
        make CppunitTest_sw_ooxmlexport17 CPPUNIT_TEST_NAME=testDateContentControlExport
        make CppunitTest_sw_core_unocore CPPUNIT_TEST_NAME=testContentControlDate
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlExport
        make CppunitTest_xmloff_text CPPUNIT_TEST_NAME=testAliasContentControlImport
        
        Change-Id: I5a82d9f6b5103a4902f59af66cd8a99addd4e690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143542
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [39c35de607f86d3d512c34e2dbc4622c579ce926]

        Related: tdf#152454 don't use Button to render dark mode Tabs
        
        on Windows. I can't find anything obviously suitable, so fall back to
        drawing simple rectangles with ActiveTabColor/InactiveTabColor
        
        Change-Id: Ic9e67baeb9e86c80787aa935d8f266e4a7db4489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144046
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [34e017c406809f13764844ba101f1fe2e2e77516]

        Related: tdf#152454 pick something suitable for dark mode Inactive tab color
        
        on Windows
        
        Change-Id: I400ca7d8c0c541977b574ae08f08aa5f28a2e3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144045
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [29d4bbd8e9e18222ddb65bf86f647eece49dcfd3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 551e891308a664f5c17613d381044381e2d92bb0
          - tdf#134377 Refactoring a few help pages for 'built-in' file dialogs …
            
            for the following use cases:
            
            -  (Writer, Impress, Forms) Insert ▶ Image
            -  (Impress) Insert ▶ Audio or Video
            -  (Base Report) Insert ▶ Media ▶ Image
            
            Change-Id: I44c15e13d5fad60f30889d396b829784c09938d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143973
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-13  Justin Luth  <justin.luth@collabora.com>  [136ee63e37358e94c28b5d8c56f2b244a7a740de]

        tdf#148035 sw content controls: cursor-move for runSdt only
        
        For normal documents, just doing a Push/PopSdt on a block SDT
        seems to work out-of-the-box for checkbox/dropdown/date content controls.
        Apparently that is not the right way to do it though.
        
        When I was trying it, the first control was always "lost".
        This patch takes care of that. At the moment it does nothing
        since only runSdt's even call push/pop, but at least
        it might save some trouble later on when block SDTs are
        turned into content controls.
        
        Change-Id: I6bf68f296ca919dc09dec660c052ddbdb59d56bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144007
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [a2969884af71e88d2541bd2bfdebea222876fef4]

        nss: upgrade to release 3.86.0
        
        Change-Id: Ia236c7124d920785f7a2856db5ee1ccbef7a2d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143038
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Miklos Vajna  <vmiklos@collabora.com>  [41071f58415927b257eab66b2674d521607bdee5]

        sw, createTextRangeByPixelPosition(): fix crash with at-page anchored images
        
        When createTextRangeByPixelPosition() was called with a position that is
        inside an at-page anchored image, we crashed.
        
        The problem is that in general we can't create an XTextRange for a
        graphic node. We already tried to return the anchor position for graphic
        nodes since 2302ebefb2e25878e8fe1e64d208f265f87d5b9b (sw,
        createTextRangeByPixelPosition(): fix crash when the position is an
        image, 2022-11-22), but that fixed the problem only in case
        GetContentAnchor() gave us a doc model position.
        
        Fix the problem by returning an empty reference in the "graphic node but
        no content anchor" case, that is still better for at-page and at-frame
        anchored images than a crash.
        
        A follow-up change could be to add a new API that has a more generic
        return type (similar to how getSelection() returns `any`) and then
        return the image itself, not its anchor in the image case. That approach
        would work for at-page and at-frame anchored images as well.
        
        Change-Id: If850ec945c24052568230a83da2ae2aa004b4265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144043
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [96198cbf9cca1090d5bb3dc2a5f85885d4262b4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77d02e65e9acae649867fe67cdba46f30e58a7e0
          - tdf#152491 Update CSS coloring to match new icons
            
            https://wiki.documentfoundation.org/Design/Branding#LibreOffice_application_colors
            
            Change-Id: I914ddfd14f0ca351f4eed5eb14ed8ea6ed904422
            
2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [36898ea11bb4b51c54429648bd45f5c5b7f020d6]

        MBI_NORMAL should be PBS_NORMAL
        
        Change-Id: I263d96e50699fe878ce153dc88ebfd00cd92415b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143999
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Tor Lillqvist  <tml@collabora.com>  [9d3c6d56cee179ac01b2ff57a4129fc4c0a3da83]

        Add Emscripten ifdef to bootstrap_getExecutableFile()
        
        Change-Id: I15d31873a27ace544a76a64fe354edb97b144424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144039
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [b6832a939623ad3b0ad61016344a432f47d1e97d]

        Related: tdf#150007 add destructive-action to file overwrite message dialog
        
        Change-Id: Ic522555a2d9d100a13f1d1dc35cfd6a57675447e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144038
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [1ec7f8b5b21bf74f684095b97a2b9900a71a0979]

        poppler: upgrade to release 22.12.0
        
        Change-Id: Ic0544fa378705b97b437132fc8860a65692634da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143977
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [9fb776f508a676d4c7255b5cfc6dfdc00d620a8c]

        libpng: upgrade to release 1.6.39
        
        Change-Id: I46ad0c9426a115ba19620814397a834923e03ca6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143976
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [d7f542a979d009398c933240d35d646296675397]

        resave with latest glade
        
        Change-Id: I2d65cdcd5f8e2050173fa90365239c6d68f02e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144037
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fa5cc6c6e7ce89d6d9972d8ad2f9469b9bd5bf9a]

        remove bogus icon file ".svg"
        
        Change-Id: Ie5a6758bed4529af27d237ed6f99fb6b8de23946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144034
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-13  Caolán McNamara  <caolanm@redhat.com>  [b49904f92d1df12311330cf7e40163349d0e82e9]

        ofz#54240 Integer-overflow
        
        Change-Id: I78058fa65c496ae537942222cff242943e6114ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-13  Tor Lillqvist  <tml@collabora.com>  [1e421b30e2440f8a6e82ba4df1be3fb7c63e6996]

        Attempt to add ifdefs for WASM (Emscripten) for LOKit-based code
        
        Change-Id: I5b2556d1be61fa3a1d7996ce8d61958fbe7984c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144002
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-13  Paris Oplopoios  <parisoplop@gmail.com>  [75093a9f7fbde760a3034f41694739c7454cb7eb]

        tdf#152435 Revert "Make EMR_SAVEDC not UpdateClipRegion"
        
        This reverts commit 1230b88055c7389d2c376c316f91549e4aaef8aa.
        
        Reason for revert:
        The reverted commit breaks the files documented in tdf#152435 (some
        text is not shown in those .EMF files). The reverted commit would solve
        an issue where some text was not clipped correctly, albeit in a naive
        way. As it is more important that text is shown rather than some text
        having correct clipping, that patch is reverted and I will look for one
        that fixes both cases.
        
        Change-Id: I42e85b802b8bf1e77e96f0016cd1d83201047032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143970
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-13  Miklos Vajna  <vmiklos@collabora.com>  [dabb07a77df33cc1b9732f7276f3d29b8e7e7810]

        sw: document SwDPage
        
        That shared draw page means explicit clipping is needed at many places,
        e.g. this is the reason SdrPageView::DrawLayer() has a page frame
        parameter.
        
        Change-Id: I6b36c977a30d44e449b8b3a46ac4368f34210887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144009
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-13  offtkp  <parisoplop@gmail.com>  [618cef756b87f9816d0dcbe04af163ccd06a986e]

        docx: Do not remove showingPlcHdr until edit
        
        When a placeholder has the showingPlcHdr attribute, the entire text is
        selected upon click. This is no longer removed by selecting it once but
        once the text has been edited.
        
        Change-Id: I9a4d68289c8b95ab0098e55a5fa6edb1606c7df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143985
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-13  Patrick Luby  <plubius@neooffice.org>  [229b0ce8d8453960c213da59770b8bb7b6dca895]

        tdf#151700 Display native print panel even if there are no printers
        
        Prevent the non-native LibreOffice PrintDialog from displaying by creating a fake printer if there are no printers. This will allow the LibreOffice printing code to proceed with native NSPrintOperation which will display the native print panel.
        
        Change-Id: Iee13305520360b0165464889f0ee51b1207dd5ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143794
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-13  Patrick Luby  <plubius@neooffice.org>  [d491791dad8c3a946dac8c4dfd28ef0c4cb65ce5]

        Fix infinite loop in sw_ooxmlexport17 unit test on macOS Intel
        
        When running the sw_ooxmlexport17 unit test on slower macOS Intel
        machines, This loop will never end even after 1M+ loops so set a
        maximum number of loops like is done in the nested while loops.
        
        Change-Id: If3a6140e03f21f4a16f6d90be7988c28c8f36753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-12  Miklos Vajna  <vmiklos@collabora.com>  [4bcf6d9c905e7b5558ee8d9f7f616ce61eadb8f8]

        tdf#151376 framework: fix calling in-document macros with reused frames
        
        The bugdoc has a macro in it, and after closing the document -> start
        center -> opening it again, you could no longer trigger the macro by
        clicking on the URL field in the Calc cell.
        
        The problem is that we cache protocol handler instances since
        3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4 (framework: avoid re-creating
        protocol handler instances all the time, 2022-05-02) in frames, but we
        failed to invalidate this cache when the component of the frame changes.
        
        Fix the problem by clearing the cache in XFrameImpl::setComponent(),
        which gets called in this somewhat rare case when a frame gets reused to
        host a different component.
        
        [ No testcase, I'm not sure how to close a document without disposing
        its XFrame from code. ]
        
        Change-Id: I73ee83ec017f476803010cbf9e514315fc797371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143998
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ef1439ae90b3621198728b4e1e67b2e72fc376c]

        SdModelTestBase: remove duplicated template
        
        this is already defined in include/tools/gen.hxx
        
        Change-Id: I6d837298491e92f942dad5cd49d8ef723a19356d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144008
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e5d89a149e86975e103270a0ff4e65776ff8f85]

        tdf#98690: move UItest to CppUnittest
        
        Change-Id: Icb1ccc4b3d5fc16264d7700201d3884cc935e5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144004
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [5b2aa621ec501f580c359a79bfcb8893594ef288]

        resave with latest glade
        
        Change-Id: I612ebb175344db3fe233d3e35a9cf6d98883f585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144005
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  galjit  <qmebic1975@gmail.com>  [31a953c7edb22f5fac1e81d92db24e1915b9b317]

        Related tdf#132398 - Update .ico files - Dec 2022
        
        Updated .ico files based on the new hicolor icons
        Also deleted those that were not listed in any WinResTarget file
        
        Change-Id: If536ea51518d531918b4dda2d2330d7cc7487c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143885
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cb415ed64a647fe736599bb6c4f2136aa5ec5d1b]

        Make extended tip more precise (after translator review)
        
        Thanks to Tuomas Hietala.
        
        Change-Id: I99d630d7e7086270ca76173c254cd282cbe81a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143915
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [d4a1d4b266a74a9adeaa84a8caab9b8b33dbb302]

        Resolves: tdf#139749 set initial focus to combobox
        
        Change-Id: Ib8fd0dd4a4b5d4c137794c4538e61bfbf33b9a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144006
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [8f2e33c1e57aec67fbab456cd3aeeaa7ed60f67e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0743da9a51f1d7733f436d0144e35e8536e56583
          - tdf#152022 Improve Select Text and Edit Mode
            
            Select Text was wrongly linking to Edit mode page. The hyperlink is now removed. Also is impossible to be in Edit mode and active Edit mode, so it can't be activate or deactivate edit mode.
            
            Change-Id: I1d759b3962692c2dcec181267045d15f934325ec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143728
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [5ebce5bb1b741c50926407d7ee036827f0ad8aa6]

        crashtesting: relax assert seen on loading forum-mso-en4-151836.xlsx
        
        Change-Id: Ib21ab9747219589bb5b1ce13eb0feacbff89efb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143987
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2958e1686452764e58e8e7257eccb4b633094b4b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0c9f3d0b57a3ced617fca89de6a87b38efdf8d94
          - update translations for master/7.5
            
            and force-fix errors using pocheck
            
            Change-Id: I8fdffa156100c7583eec271a33632534cb8629b3
            
2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [92e7bc1769c0cf0a0bca4e68a17cd52211e07414]

        crashtesting: null deref see on loading forum-mso-en4-531817.xlsx
        
        Change-Id: I8fb92edc32cabecd0f1ff5090f1b102e090aa840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143983
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [6691816fe86ef7d193fee3632c2d56debfff3fa9]

        tdf#152266 add an infobar with indicators for macro-like content in doc
        
        Show "macros" and "events" for now if we know that are present so
        they can be investigated by the user. There are other things which
        could potentially be added in the future.
        
        Change-Id: I981ee7a8e22791cd15405894f30fee659ba0b7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143897
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [4ea9061d54ee6d2c1ce2460162a1ea5f32de1ae7]

        Update config.guess & .sub to latest
        
        General updates & streamlining, plus addition of loongarch32 and
        managarm as probably most relevant additions here.
        
        Change-Id: Iff94f05c5e9240204eb3f844a05a7cad519522a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143988
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-12  Jim Raykowski  <raykowj@gmail.com>  [b7a51a7cd46e155ad78ac0f9301863d5a1eabd52]

        tdf#152029 Bring sections to attention in the document view
        
        when mouse pointer is over section content type and content entries in
        the Navigator content tree
        
        Change-Id: Icdfb680752a698ad076eaaabc237b1b6facb1704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143845
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d8db6a072968f58bd6178dbfd5ac695976171b6e]

        remove erroneously added icons with space in filename
        
        Change-Id: I8e1a5ed47af74e8b26e542c7df7757368446f87a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143913
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [7bd768846aa13dfa98fc0fb480d1818eacb47bf4]

        get-forum-attachment: Add optional get-file argument
        
        to help to download a specific file
        e.g: --get-file forum-mso-en4-93354.xls
        
        Change-Id: Id6a2388a3388d7a332a0a7e1bd8042094d835ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143984
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [c0f61ec33be9b76116495907e4874aaae5990088]

        crashtesting: assert seen on loading forum-mso-en4-497867.xlsx
        
        Change-Id: Ifa5e2711981097a648d7127d2dc777bc96b04edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143982
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Stephan Bergmann  <sbergman@redhat.com>  [baddc742c3fe260d20d7924ab134f0fbf179fd85]

        lld 16 trunk defaults to --no-undefined-version now
        
        ...since
        <https://github.com/llvm/llvm-project/commit/241dbd310599e3c1a0f1b0c9ced14c8b8760539e>
        "[ELF] Enable --no-undefined-version by default", causing e.g.
        
        > ld.lld: error: version script assignment of 'PRIVATE_1.4' to symbol '_ZN3sal13backtrace_getEm' failed: symbol not defined
        > ld.lld: error: version script assignment of 'GLIBCXX_3.4' to symbol '_ZNSs4_Rep20_S_empty_rep_storageE' failed: symbol not defined
        
        while building Library_sal and
        
        > ld.lld: error: version script assignment of 'LIBXML2_2.4.30' to symbol 'xmlXPtrBuildNodeList' failed: symbol not defined
        > ld.lld: error: version script assignment of 'LIBXML2_2.4.30' to symbol 'xmlXPtrEvalRangePredicate' failed: symbol not defined
        > ld.lld: error: version script assignment of 'LIBXML2_2.4.30' to symbol 'xmlXPtrFreeLocationSet' failed: symbol not defined
        [...]
        
        while building ExternalProject_libxml2 (and the latter is the reason to add to
        USE_LD rather than gb_LinkTarget_LDFLAGS, so that this also goes into
        gb_ExternalProject_get_link_flags).
        
        This is only relevant for ELF targets, so at least for now add it to linux.mk
        rather than the general com_GCC_defs.mk.
        
        Change-Id: I2ea227bd9392c406e6c41de61df37ad7fe155c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143981
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [90dc1ce8a1976b3c2e26791bdbabb2651ba45224]

        crashtesting: assert on import of forum-mso-en4-85437.xls
        
        aParam.nCol1 of 180
        aParam.nRow1 of 0
        aParam.nCol2 of 0
        aParam.nRow2 of 0
        
        so a negative nColCnt
        
        Change-Id: Ifa58287190389b61c36f4ace864516631b025548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [c9f84e636107b1fa29493b3841799d8d8f49fda1]

        crashtesting: assert see on loading forum-mso-en4-489894.xlsx
        
        Change-Id: I402705ea911ca248afb812b63a897c1df9884a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Julien Nabet  <serval2412@yahoo.fr>  [1f77a3c5d4d71d868cad47bf0d16d6177753b79e]

        PRODUCTNAME -> %PRODUCTNAME
        
        Spotted thanks to:
        grep -nR PRODUCTNAME *|grep -v \%PRODUCTNAME|grep -v '${PRODUCTNAME}'|grep -v '\[PRODUCTNAME\]'|grep -v '\[FULLPRODUCTNAME\]'
        suggested in tdf#152265 UI: "tip of the day: placeholder "PRODUCTNAME" in text of the tip"
        
        Change-Id: I5292eeb1767404f2aa31f4b51b410a29afafcd6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143851
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-12  Michael Stahl  <michael.stahl@allotropia.de>  [7757e5844a6e9f6e039f4a28e7803319bb094d94]

        schema: add link for decorative proposal
        
        Change-Id: Ib655795cf407bc833964c43dae6017364e5d6fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143883
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-12  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [599f9836a674ec525e56fa787a800d7ed4be3383]

        Add oox to build side, for cross compilation
        
        With ce4c154e8b254f3bcd59ea46b3db4bd3d5a26058, cui now depends on oox
        generated headers, so we need to build oox too, for cross builds.
        
        Change-Id: I1af3116ab35c5094c23db3ed3dccd90c80080cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143975
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-12  Caolán McNamara  <caolanm@redhat.com>  [177b346c9ea4177386a26c69533bee1d9219b261]

        ofz#54202 Timeout
        
        Change-Id: I37edadb77c534a3bf62b210af6472ddcd33ece57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-12  Miklos Vajna  <vmiklos@collabora.com>  [dc3b969b25f897f5cdf5e824865b187b973b3f82]

        sw: prefix members of CellsEnumWrapper, ColumnsEnumWrapper, ...
        
        ... SwSendQueryBox_Impl and SwVbaTableHelper
        
        See tdf#94879 for motivation.
        
        Change-Id: I5cb6ffe8604ba473c93318058c7955d8caa4bbea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143978
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [01c9c971e43782800ebf63acc763a7e7fba096c1]

        Fix typo
        
        Change-Id: Ifd46201254b8a5db1d21d99d469d331688e8731c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143952
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [d0f12a16145b6831a6cecc017a1d9879efb576cc]

        crashtesting: use of uninitialized data in forum-mso-en4-93354.xls
        
        Change-Id: I678a22289827e0a9c305ac49f7f046ae2a91184c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [eba5cfe961d3b6e429ee88d452001e689268f3ff]

        ofz#54221 Out-of-memory
        
        Change-Id: I4b4da37dfa0a961f77bc3bccdf2d25321f7d2447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143951
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  jsala  <javier.salamanca.munoz@gmail.com>  [c6fcdc2a4a354f284ddb5f000572e2146a706715]

        tdf#91367 Remove ApiTokenSequence uses.
        
        Remove unneeded empty ApiTokenSequence parameters.
        They go throught some calls and then are converted to ScTokenArray.
        A call to ConvertToTokenArray can be removed.
        
        Change-Id: Ic22845e0e06e3af3a91dab966538e59c3e21d470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143886
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [06089485040a13afc5945d31d59e0959e2412f27]

        ofz#54221 drop unassigned bits
        
        Change-Id: I3e4303629aa5502dc35bf562b5f4e5aed183234a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [0f3b1feeea75a3e7c5fd83fc38d318338d702348]

        ofz#54339 skip config for fuzzing
        
        Change-Id: I0d5191d2d4ed8ba76d2549701da5e00ca92a9ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143949
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Patrick Luby  <plubius@neooffice.org>  [9eb732a32023e74c44ac8c3b5af9f5424273bb6c]

        Related: tdf#146842 Convert SkiaSalBitmap to QuartzSalBitmap
        
        Commit de3f13e2175564316eb5a62dee65e9ff8f31b460 disabled Skia for printing.
        However, since all SalBitmaps created are either all QuartzSalBitmaps or all
        SkiaSalBitmaps, a crash occurs whenever a SkiaSalBitmap is passed to a
        printer's SalGraphics instance which is now always non-Skia.
        
        Change-Id: I7c1b0e1a9993e21db18ba5695a106cb10cc4088a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143939
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [d7f969a133d4eb8258b5d90ed88532cfcdbc9b28]

        crashtesting: accept timestamp with Z suffix as valid
        
        seen with forum-mso-en4-652977.xlsx
        
        Change-Id: I5ca7be851c279d28e225cba1ba401a4f7fa99e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [3d9e4c5995d582f4a15120e84adc36efa7b4a49e]

        crashtesting: null deref seen with forum-mso-en4-763051.xlsx
        
        Change-Id: I721ab5fc78efafac9bcb7594e881773863d867f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Caolán McNamara  <caolanm@redhat.com>  [4af3a2998dd36a940f741b335e8327da2a4dead9]

        reuse RID_SECURITY_WARNING_TITLE for update links infobar
        
        Change-Id: Ifbfb10ee373b8eca8e1019f999ac8e545f180c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f7b9956e07b32b3ceccf24fa118015abdefbb315]

        Fix typo
        
        Change-Id: Iac459eb04dda615a37631ed370907b50277a9c7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143941
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: خالد حسني <khaled@aliftype.com>

2022-12-11  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [b60dfc2928ef9763452c57f06073185456310609]

        Replace backslashes in config params before usage in cxx files
        
        With cbfac11330882c7d0a817b6c37a08b2ace2b66f4, LOKit tries to pass
        full configure line on via JSON - which, on Windows, might contain
        backslashes and other nasties, so we better try to clean that up here.
        
        Change-Id: I8314783fc6f49e9b2b374d94448ed735de39bf81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143940
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9b46020c262045aed0beace4708565235c2523cc]

        Fix English on extended tip
        
        Change-Id: I3aad959d3d309b4ee4a1095edc16d68c86a3ed0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143921
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-10  Khaled Hosny  <khaled@aliftype.com>  [840904c05f4799986d78033f05b4d38f58a59994]

        tdf#152267: Strike out changed to underline in small zoom
        
        The font has bogus value in the regular style. Add configuration
        support for ignoring metrics of such fonts, similar to what we do with
        line metrics.
        
        Change-Id: Ia7cfb44400601e89b8425c9a1144f630f67569f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143648
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a3ecdd0ab66d516bd8934a7cd32654b85fef312]

        Fix typo in code
        
        Change-Id: Ic0a54ef30bd8e4350b6a47ddf9f67ae608a7e122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143938
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-12-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [748e5234c561799f876a821d1a022cfc5770411e]

        Fix typo
        
        Change-Id: I9bded67c9e044ed4e96f8520a3a5486b8d3ecf0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143937
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-10  Julien Nabet  <serval2412@yahoo.fr>  [a12cf7902d8139e8a7a9d30dd9a9360a05411b8c]

        tdf#152455: Strings not translatable in paste special dialog
        
        Change-Id: I0c8834813af22f3de2da1f80a8895d518f66dada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143908
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-10  László Németh  <nemeth@numbertext.org>  [09ae3c01940bbc25ffde51963683b04e3cb4bb6a]

        tdf#152203 DOCX import: fix mixed footnotes/endnotes
        
        Footnotes (like endnotes) were imported in the order
        of their w:footnote elements in footnotes.xml, resulting
        mixed footnote text content during loading documents
        exported from Google Docs. Import them in the order
        of their w:id attributes.
        
        Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
        "tdf#76260 DOCX import: fix slow footnote import".
        
        Change-Id: I7d9ed36fe96b2b90c4d62fb1ca7201318581775d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143824
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-10  Jim Raykowski  <raykowj@gmail.com>  [080d2d21cb59fd6e81375f15cf17c6cbfc605a77]

        tdf#152029 related: Prevent crash on nullptr iter_compare
        
        Fixes crash that happens with x11 and qt5 backends when iter_compare is
        given a nullptr iterator to compare.
        
        Change-Id: I80995071dbc5b9e9807fc8b5cf10b0868b851ee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143907
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2b2901bb24405c9b4778e6a34387b9826297b897]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f394267138498a70430a44dcbc4cff8727ce367
          - Mute L10n in code instructions
            
            Change-Id: I92f719fbd4b646809fb385360541b285a41fd3d9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143919
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9270a93b013851f25399bbae9e4fd19251b4c38d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 232f60bed77834ad7d1624bc88e08305fe1ba016
          - More typo fixes
            
            after https://gerrit.libreoffice.org/c/help/+/143716
            
            Change-Id: I9b550a68674b2e8ec31b3b8111186d58542686d9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143918
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-10  Stephan Bergmann  <sbergman@redhat.com>  [81719351c67385dece9dc6656530de31f5778f03]

        Introduce CPPUNIT_PROPAGATE_EXCEPTIONS environment variable
        
        Often a developer debugging a failing CppUnit test wants a core dump with the
        place where an uncaught exception is thrown.  So if the newly introduced
        CPPUNIT_PROPAGATE_EXCEPTIONS environment variable is set (to any value), disable
        all the protectors that would otherwise catch such exceptions (and just report
        some limited information about them).
        
        Change-Id: I3052f71c0787583c496279a6f5b35a0299c357b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-10  Khaled Hosny  <khaled@aliftype.com>  [4e5032fe8ae6e2d9e59eebb8708b004b5cf3136b]

        vcl: Add /Name key to Type 3 font dictionary
        
        Even though the spec says it is deprecated and Acrobat ignores it,
        several tools including Acrobat readers won’t show font name for Type 3
        fonts unless there is one in the font dictionary.
        
        Change-Id: I8e65a1cf1d89744e9d89542d3540c7f3ba938369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143903
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-10  Khaled Hosny  <khaled@aliftype.com>  [ff6e3635c1f82db401309e95cb90f0b78554ae6e]

        vcl: Add subset ID to Type 3 fonts embedded in PDF
        
        This was overlooked before and can lead to duplicate font names in PDF.
        
        Change-Id: I16bd0e64663b5f62f90b91576644439079213e64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143901
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-10  Caolán McNamara  <caolanm@redhat.com>  [99860a1fbf7017cc5efdebdf5901ef57e7c021f0]

        Related: tdf#152266 open 'event' page by default for SID_CONFIGEVENT
        
        Change-Id: I7a3f6def8bda00588ef2846e5d3b5ed5d1da04de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-10  Caolán McNamara  <caolanm@redhat.com>  [c86f1315ea3203e8557843d02c222969524a9ca7]

        be a little more explicit that we want the Accel config here
        
        its all handled the same way at the moment, but this is page we want
        here
        
        Change-Id: I8ff3e671d67d3f273fa5eb747411eab226e20fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-10  Caolán McNamara  <caolanm@redhat.com>  [f68e3a8a2eb807ab2727ca724d5a4fa1e37fa567]

        switch to the 'keyboard' tab if a SID_MACROINFO is set
        
        Change-Id: Ie615ab2598309b0324daa11732e5345d1a927437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5844bad90dd056ca533ba86443e179ee4611f2c]

        tdf#120190: sc_pdf_export: Add unittest
        
        Exporting to pdf is the only way I could find to test this issue
        
        Change-Id: I1f75d841b09d13807fb1e9e4418a58638d985870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143890
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-10  Julien Nabet  <serval2412@yahoo.fr>  [0390479ccf454cd87997fe97d640caf9f8c45a13]

        Related tdf#152381: fix "lengths do not match"
        
        On console, I noticed these:
        warn:dbaccess:111457:111457:dbaccess/source/ui/browser/unodatbr.cxx:754: DBG_UNHANDLED_EXCEPTION in InitializeGridModel exception: com.sun.star.lang.IllegalArgumentException message: "lengths do not match at /home/julien/lo/libreoffice/cppuhelper/source/propshlp.cxx:872" ArgumentPosition: -1
        
        0  cppu::OPropertySetHelper::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
            (this=0x55eca23d3b90, rPropertyNames=uno::Sequence of length 6 = {...}, rValues=uno::Sequence of length 7 = {...}) at cppuhelper/source/propshlp.cxx:872
        1  0x00007f39c7a7ecb6 in comphelper::OPropertySetAggregationHelper::setPropertyValues(com::sun::star::uno::Sequence<rtl::OUString> const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
            (this=0x55eca23d3b90, _rPropertyNames=uno::Sequence of length 6 = {...}, _rValues=uno::Sequence of length 7 = {...}) at comphelper/source/property/propagg.cxx:589
        2  0x00007f39ac81f057 in dbaui::SbaTableQueryBrowser::InitializeGridModel(com::sun::star::uno::Reference<com::sun::star::form::XFormComponent> const&)
             (this=0x55eca23b1960, xGrid=uno::Reference to (frm::OGridControlModel *) 0x55eca23d3c30) at dbaccess/source/ui/browser/unodatbr.cxx:594
        3  0x00007f39ac834d46 in dbaui::SbaTableQueryBrowser::implLoadAnything(rtl::OUString const&, rtl::OUString const&, int, bool, utl::SharedUNOComponent<com::sun::star::sdbc::XConnection, utl::DisposableComponent> const&) (this=0x55eca23b1960, _rDataSourceName="file:///tmp/Table_Default_Firebird.odb", _rCommand="Table2", nCommandType=0, _bEscapeProcessing=true, _rxConnection=...)
            at dbaccess/source/ui/browser/unodatbr.cxx:2384
        4  0x00007f39ac8312ee in dbaui::SbaTableQueryBrowser::implSelect(weld::TreeIter const*) (this=0x55eca23b1960, pEntry=0x55eca243bd90) at dbaccess/source/ui/browser/unodatbr.cxx:2678
        5  0x00007f39ac8343e2 in dbaui::SbaTableQueryBrowser::implSelect(rtl::OUString const&, rtl::OUString const&, int, bool, utl::SharedUNOComponent<com::sun::star::sdbc::XConnection, utl::DisposableComponent> const&, bool) (this=0x55eca23b1960, _rDataSourceName="file:///tmp/Table_Default_Firebird.odb", _rCommand="Table2", nCommandType=0, _bEscapeProcessing=true, _rxConnection=..., _bSelectDirect=true)
            at dbaccess/source/ui/browser/unodatbr.cxx:2445
        6  0x00007f39ac8398c5 in dbaui::SbaTableQueryBrowser::impl_initialize() (this=0x55eca23b1960) at dbaccess/source/ui/browser/unodatbr.cxx:3251
        7  0x00007f39ac7a3eee in dbaui::OGenericUnoController::initialize(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (this=0x55eca23b1960, aArguments=uno::Sequence of length 17 = {...})
            at dbaccess/source/ui/browser/genericcontroller.cxx:259
        8  0x00007f39ac718dd7 in (anonymous namespace)::DBContentLoader::load(com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XLoadEventListener> const&)
             (this=0x55eca23aacf0, rFrame=uno::Reference to ((anonymous namespace)::XFrameImpl *) 0x55eca1f13750, rURL=".component:DB/DataSourceBrowser", rArgs=uno::Sequence of length 16 = {...}, rListener=uno::Reference to (framework::(anonymous namespace)::LoadEnvListener *) 0x55eca23b0828) at dbaccess/source/ui/browser/dbloader.cxx:230
        9  0x00007f39c65f5f13 in framework::LoadEnv::impl_loadContent() (this=0x7fff7788a6e8) at framework/source/loadenv/loadenv.cxx:1154
        
        At least from 59bc10eb4609c "INTEGRATION: CWS insight01 (1.152.38); FILE MERGED" (2004-08-02)
        this part seems the root pb:
        -                Sequence< ::rtl::OUString> aProperties(6);
        -                Sequence< Any> aValues(6);
        +                Sequence< ::rtl::OUString> aProperties(6 + ( m_bPreview ? 5 : 0 ));
        +                Sequence< Any> aValues(7 + ( m_bPreview ? 5 : 0 ));
        if m_bPreview is false, there are only 6 attributes:
        - PROPERTY_FONT
        - PROPERTY_TEXTEMPHASIS
        - PROPERTY_TEXTRELIEF
        - PROPERTY_ROW_HEIGHT
        - PROPERTY_TEXTCOLOR
        - PROPERTY_TEXTLINECOLOR
        
        Change-Id: I91cd81f87ae0685123e273fa6d106fdd22003147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143889
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>

2022-12-09  Aurimas Fišeras  <aurimas@members.fsf.org>  [53f117492db82285b190a40dd432e2bb10899457]

        configure.ac: update links to avoid redirects, fix broken links.
        
        Change-Id: I7269205ecaac450123e153ea549036abd9a567d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143884
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [26554db35487ac7a9d7c15e09653e4b842c775be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5dc5a9dc64efa25a9553a0bcc4f1c94b775a15a
          - Fix typo
            
            Change-Id: I859153f912a952e105e6d124fa85e7f81a702d83
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143891
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-12-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [01fc8ceef1946ca84d7cfef3801ad7f00e36042a]

        Fix typo
        
        Change-Id: I96297815043ea213f67d0ccc4224b12d7bcf7d36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143887
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-09  Miklos Vajna  <vmiklos@collabora.com>  [cf2c070de2bafeec3b476c6bff7bb4ac87ba46db]

        sw layout: invalidate margins of body content when moving a fly from page
        
        The (simplified) bugdoc has 9 pages, and once the ToC is updated, the
        two tables below the (only) bookmark in the document has a 5879 twips
        gap between them for no reason. Adding a new paragraph to the second
        table "fixes" the incremental layout.
        
        What seems to happen is that there is an anchored image on page 8, but
        the layout decides that it doesn't fit there so it gets moved to page 9.
        Before this move happens, SwTabFrame::Format() handles the outer of the
        nested table below the unwanted gap and its CalcFlyOffsets() notices
        that a large upper margin is wanted so that the table wraps around the
        anchored image. Later the image gets moved to the next page, but the
        removal doesn't invalidate the print area of the table with the large
        top margin, so the unwanted gap appears.
        
        Fix the problem by looking at the old page in SwPageFrame::MoveFly() and
        walking through the immediate children of the body frame: if the frame
        print area is invalidated, then SetYMargins() is called from
        SwTabFrame::Format(), which also invalidates the size of the outer table
        frame, so it will use Shrink() to have a correct size.
        
        This appears to be a regression from commit
        b9ef71476fd70bc13f50ebe80390e0730d1b7afb (tdf#134298 sw: layout: remove
        left-over page frame without content, 2020-11-13).
        
        Change-Id: I0424d9eea4d8a030959f8534985950c7efad4686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143881
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-09  Michael Stahl  <michael.stahl@allotropia.de>  [31084ebb59093be7dfe5ab53a20fdb3bcfde34b6]

        tdf#143311 offapi,oox,writerfilter,xmloff,sw: decorative flag on flys
        
        * sw core RES_DECORATIVE as a FRMATR
        * sw API SwXFrame property "Decorative"
        * UI checkbox "Decorative"
        * ODF import/export as loext:decorative on draw:frame
        * DOCX export
        * DOCX import - very non-obvious how to get it from model.xml to dmapper
        * PDF/UA export: tag flys with this flag as Artifact
        * test for DOCX filters, ODF filters, PDF export
        
        Change-Id: I1ceb67fdd4e1cfa212aafdeb1c5f4ccd873d433e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143815
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-09  László Németh  <nemeth@numbertext.org>  [e5986baa983e1c7b5e07c45299fd84be2c230fbe]

        tdf#150578 sw track changes: fix table toolbar at row deletion
        
        In Hide Changes mode with enabled change tracking, table row
        deletion disabled the table toolbar, so it wasn't possible
        to repeat the click on the toolbar deleting multiple rows
        row by row.
        
        Follow-up to commit 16c705ec0d1ab4b4428577ccb0ea3fc14ee0fc88
        "tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes".
        
        Change-Id: I297bae405cb24f7090144344947c01a1dadf9261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143876
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [6683010b1a856c3894cc0a7172ac14fda0b76aa8]

        Related: tdf#146395 drop default text
        
        Change-Id: Iaeedf11df5f1d5739ec247222cc4fc1f10abe1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143875
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Mike Kaganski  <mike.kaganski@collabora.com>  [960207c72aedaf8569b880a7c000c10d0baabb70]

        Related: tdf#152425 Use ww::sti enum instead of respective number literals
        
        Simplifies reading and checking its correctness greatly.
        
        Change-Id: I16253f324cbafac6cb526ab195a7257530abe0a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143827
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-09  Stephan Bergmann  <sbergman@redhat.com>  [e2d3baf0db4dec6b7b00192c41700611bd1d147c]

        external/zxing: Silence MSVC 2022 error C3781
        
        > workdir\UnpackedTarball\zxing\core\src\Generator.h(20): error C3781: Generator<ZXing::DetectorResult>::promise_type: a coroutine's promise must declare either 'return_value' or 'return_void'
        
        seen at least when building with --with-latest-c++ against VS 2022 17.5.0
        Preview 1.0
        
        Change-Id: Ie69100d87e6cb85526d772e8f0f5d11e1f9d6704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143853
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [e1de95f72b1e6467510f7c3b32b25d7528c93a75]

        Related: tdf#152266 add a remove all button
        
        Change-Id: Ibf6b749089d2d6da71a9ce00779bce8886453856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143833
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [45449e2fd20b45f9e3e04538c77b9e245a4170d4]

        resave with latest glade
        
        Change-Id: Ia9dc0446c2dc69c0e04d67b0d4da30319807a6cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143852
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Justin Luth  <justin.luth@collabora.com>  [a5098b222c9406af858fd6d94d0ceb2c3c2066a8]

        tdf#151548 sw content controls: preserve tag for block SDTs
        
        The tag is critical for VBA access.
        Although we do not yet import blockSdts as content controls,
        losing this would break any VBA macros for MS Word.
        So make sure it round-trips.
        
        I can't imagine why it wasn't treated the same as alias.
        I guess because Alias is seen, while tag appears to have
        no valuable function (until VBA, where it becomes the most
        likely ID field.)
        
        Change-Id: I05a04faa9d2314c7b37c5b86f107bd1a16019509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143830
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [754b6ef15b8a93f73db4b293ee853668768c91e6]

        tdf#152413: sw_layoutwriter: Add unittest
        
        Change-Id: Ic485c1521969b126d66b0e33b72ca966d02d0ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143846
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [83eb2796d1f4a6778d40a5e2e94c4b536163fecb]

        Related: tdf#152266 give feedback which events are assigned
        
        where assigned is means an event is assigned to a non-empty url, now the
        delete button is only enabled when there is something to delete,
        bringing the customizie event page into line with the sheet event page
        and the writer frame event assignment page
        
        Change-Id: I7e016bf578dff24b7d47312fd5f7cc63883d1e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [4702910165dff6d5cef0d1bc707ff66b0b0d95bd]

        drop unnecessary pThis indirection
        
        Change-Id: I28c338a4f09036c9365937af99cb85fd4be95901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Michael Stahl  <michael.stahl@allotropia.de>  [05f55b3898407828bb24347be56247f58803f7bb]

        python3: upgrade to release 3.8.16
        
        Fixes CVE-2022-37454 and a few other ones that look less relevant
        including CVE-2022-45061 and CVE-2015-20107.
        
        Change-Id: I10fd254f7f0801d47119234bb3436874e98d8c91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143849
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-09  Michael Stahl  <michael.stahl@allotropia.de>  [ce4c154e8b254f3bcd59ea46b3db4bd3d5a26058]

        svx: fix unmaintainable TypeConstant definition
        
        Add one new token and every test in CppunitTest_sd_import_tests-smartart
        fails.
        
        Change-Id: I0d79a5000fc2ef9b699ffca3d75199e9479cf561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143834
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-09  Patrick Luby  <plubius@neooffice.org>  [de3f13e2175564316eb5a62dee65e9ff8f31b460]

        tdf#146842 Do not use Skia for printing
        
        Skia does not work with a native print graphics contexts. I am not sure why but from what I can see, the Skia implementation drawing to a bitmap buffer. However, in an NSPrintOperation, the print view's backing buffer is CGPDFContext so even if this bug could be solved by blitting the Skia bitmap buffer, the printed PDF would not have selectable text so always disable Skia for print graphics contexts.
        
        Change-Id: I214ba83b6e368af3ef51ea770b093612d04047a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143798
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Stephan Bergmann  <sbergman@redhat.com>  [e624621089886f52e9606c4f5058f5f5a890261c]

        Fix hang during JunitTest_framework_complex on macOS
        
        ...when [NSSpellChecker init] is called on a non-main thread, leading to
        deadlock (see below).  The fix is noticing that the first half of
        SfxFrameLoader_Impl::load and the call to SwGlobals::ensure from
        Writer_SwTextDocument_getImplementation both don't need to be covered by
        SolarMutex.  Which in turn showed that the call to StartListening from the
        constructor of SwModule needs to be covered by the SolarMutex (which it no
        longer was now).
        
        The deadlock was at
        
        > thread #7, name = 'cppu_threadpool::ORequestThread'
        >  #1: libsystem_pthread.dylib`_pthread_cond_wait
        >  #2: Foundation`-[NSOperation waitUntilFinished]
        >  #3: CoreFoundation`_CFXNotificationPost
        >  #4: Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:]
        >  #5: AppKit`-[NSMenu insertItem:atIndex:]
        >  #6: AppKit`-[NSApplication(NSServicesMenuPrivate) _fillSpellCheckerPopupButton:]
        >  #7: AppKit`-[NSSpellChecker _fillSpellCheckerPopupButton:]
        >  #8: AppKit`-[NSSpellChecker init]
        >  #9: AppKit`__36+[NSSpellChecker sharedSpellChecker]_block_invoke
        >  #10: libdispatch.dylib`_dispatch_client_callout
        >  #11: libdispatch.dylib`_dispatch_once_callout
        >  #12: AppKit`+[NSSpellChecker sharedSpellChecker]
        >  #13: libMacOSXSpelllo.dylib`MacSpellChecker::getLocales at lingucomponent/source/spellcheck/macosxspell/macspellimp.mm:117:42
        >  #14: liblnglo.dylib`LngSvcMgr::GetAvailableSpellSvcs_Impl at linguistic/source/lngsvcmgr.cxx:969:63
        >  #15: liblnglo.dylib`LngSvcMgr::getAvailableServices at linguistic/source/lngsvcmgr.cxx:1395:9
        >  #16: liblnglo.dylib`LngSvcMgr::getAvailableLocales at linguistic/source/lngsvcmgr.cxx:1459:42
        >  #17: liblnglo.dylib`LngSvcMgr::UpdateAll at linguistic/source/lngsvcmgr.cxx:654:49
        >  #18: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:411:5
        >  #19: liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:399:1
        >  #20: liblnglo.dylib`::linguistic_LngSvcMgr_get_implementation at linguistic/source/lngsvcmgr.cxx:1840:30
        >  #21: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #22: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #23: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #24: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #25: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const
        >  #26: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const
        >  #27: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13
        >  #28: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:667:30
        >  #29: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36
        >  #30: libswlo.dylib`com::sun::star::linguistic2::LinguServiceManager::create at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38:129
        >  #31: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:53:22
        >  #32: libswlo.dylib`SwLinguServiceEventListener::SwLinguServiceEventListener at sw/source/uibase/uno/dlelstnr.cxx:46:1
        >  #33: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:161:44
        >  #34: libswlo.dylib`SwModule::SwModule at sw/source/uibase/app/swmodule.cxx:137:1
        >  #35: libswlo.dylib`std::__1::__unique_if<SwModule>::__unique_single std::__1::make_unique<SwModule, SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&>
        >  #36: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:98:26
        >  #37: libswlo.dylib`SwDLL::SwDLL at sw/source/uibase/app/swdll.cxx:81:1
        >  #38: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:57:212
        >  #39: libswlo.dylib`(anonymous namespace)::SwDLLInstance::SwDLLInstance at sw/source/uibase/app/swdll.cxx:58:9
        >  #40: libswlo.dylib`rtl::Static<(anonymous namespace)::SwDLLInstance, (anonymous namespace)::theSwDLLInstance>::get at include/rtl/instance.hxx:399:18
        >  #41: libswlo.dylib`SwGlobals::ensure at sw/source/uibase/app/swdll.cxx:70:9
        >  #42: libswlo.dylib`::Writer_SwTextDocument_get_implementation((null)=0x000000011fde9130, args=0x000000028bb087b0) at sw/source/uibase/uno/unodoc.cxx:40:5
        >  #43: libuno_cppuhelpergcc3.dylib.3`decltype(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>(fp)(std::__1::forward<com::sun::star::uno::XComponentContext*>(fp0), std::__1::forward<com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(fp0))) std::__1::__invoke<com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #44: libuno_cppuhelpergcc3.dylib.3`com::sun::star::uno::XInterface* std::__1::__invoke_void_return_wrapper<com::sun::star::uno::XInterface*, false>::__call<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #45: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__alloc_func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #46: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__func<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), std::__1::allocator<com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)
        >  #47: libuno_cppuhelpergcc3.dylib.3`std::__1::__function::__value_func<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const
        >  #48: libuno_cppuhelpergcc3.dylib.3`std::__1::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const
        >  #49: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::doCreateInstance at cppuhelper/source/servicemanager.cxx:702:13
        >  #50: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::Data::Implementation::createInstance at cppuhelper/source/servicemanager.cxx:671:16
        >  #51: libuno_cppuhelpergcc3.dylib.3`cppuhelper::ServiceManager::createInstanceWithContext at cppuhelper/source/servicemanager.cxx:1002:36
        >  #52: libsfxlo.dylib`(anonymous namespace)::SfxFrameLoader_Impl::load at sfx2/source/view/frmload.cxx:668:58
        >  #53: libfwklo.dylib`framework::LoadEnv::impl_loadContent at framework/source/loadenv/loadenv.cxx:1160:37
        >  #54: libfwklo.dylib`framework::LoadEnv::start at framework/source/loadenv/loadenv.cxx:395:20
        >  #55: libfwklo.dylib`framework::LoadEnv::startLoading at framework/source/loadenv/loadenv.cxx:300:5
        >  #56: libfwklo.dylib`framework::LoadEnv::loadComponentFromURL at framework/source/loadenv/loadenv.cxx:168:14
        >  #57: libfwklo.dylib`framework::Desktop::loadComponentFromURL at framework/source/services/desktop.cxx:605:16
        >  #58: libgcc3_uno.dylib`callVirtualFunction at bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:38:5
        >  #59: libgcc3_uno.dylib`(anonymous namespace)::call at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:293:13
        >  #60: libgcc3_uno.dylib`::unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_aarch64/uno2cpp.cxx:505:17
        >  #61: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute_throw const at binaryurp/source/incomingrequest.cxx:235:13
        >  #62: libbinaryurplo.dylib`binaryurp::IncomingRequest::execute const at binaryurp/source/incomingrequest.cxx:78:26
        >  #63: libbinaryurplo.dylib`::request at binaryurp/source/reader.cxx:85:9
        >  #64: libuno_cppu.dylib.3`cppu_threadpool::JobQueue::enter at cppu/source/threadpool/jobqueue.cxx:100:17
        >  #65: libuno_cppu.dylib.3`cppu_threadpool::ORequestThread::run at cppu/source/threadpool/thread.cxx:164:31
        >  #66: libuno_cppu.dylib.3`::threadFunc at include/osl/thread.hxx:189:15
        >  #67: libuno_sal.dylib.3`osl_thread_start_Impl at sal/osl/unx/thread.cxx:264:9
        
        vs.
        
        > thread #1, queue = 'com.apple.main-thread'
        >  #1: libsystem_pthread.dylib`_pthread_cond_wait
        >  #2: libc++.1.0.dylib`std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&) [inlined] std::__1::__libcpp_condvar_wait
        >  #3: libc++.1.0.dylib`std::__1::condition_variable::wait
        >  #4: libvclplug_osxlo.dylib`void std::__1::condition_variable::wait<SalYieldMutex::doAcquire(unsigned int)::$_0>
        >  #5: libvclplug_osxlo.dylib`SalYieldMutex::doAcquire at vcl/osx/salinst.cxx:215:36
        >  #6: libvclplug_osxlo.dylib`comphelper::SolarMutex::acquire at include/comphelper/solarmutex.hxx:86:5
        >  #7: libvclplug_osxlo.dylib`osl::Guard<comphelper::SolarMutex>::Guard at include/osl/mutex.hxx:142:17
        >  #8: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:11
        >  #9: libvclplug_osxlo.dylib`SolarMutexGuard::SolarMutexGuard at include/vcl/svapp.hxx:1348:78
        >  #10: libvclplug_osxlo.dylib`AquaSalTimer::callTimerCallback at vcl/osx/saltimer.cxx:140:21
        >  #11: libvclplug_osxlo.dylib`AquaSalTimer::handleDispatchTimerEvent at vcl/osx/saltimer.cxx:162:9
        >  #12: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:406:47
        >  #13: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9
        >  #14: libvclplug_osxlo.dylib`AquaSalInstance::DoYield at vcl/osx/salinst.cxx:567:17
        >  #15: libvcllo.dylib`ImplYield at vcl/source/app/svapp.cxx:465:48
        >  #16: libvcllo.dylib`Application::Yield at vcl/source/app/svapp.cxx:532:5
        >  #17: libvcllo.dylib`Application::Execute at vcl/source/app/svapp.cxx:444:9
        >  #18: libsofficeapp.dylib`desktop::Desktop::Main at desktop/source/app/app.cxx:1587:13
        >  #19: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:198:35
        >  #20: libvclplug_osxlo.dylib`AquaSalInstance::handleAppDefinedEvent at vcl/osx/salinst.cxx:396:20
        >  #21: libvclplug_osxlo.dylib`-[VCL_NSApplication sendEvent:] at vcl/osx/vclnsapp.mm:101:9
        >  #22: AppKit`-[NSApplication _handleEvent:]
        >  #23: AppKit`-[NSApplication run]
        >  #24: AppKit`NSApplicationMain
        >  #25: libvclplug_osxlo.dylib`AquaSalInstance::SVMainHook at vcl/osx/salinst.cxx:971:5
        >  #26: libvcllo.dylib`ImplSVMain at vcl/source/app/svmain.cxx:191:54
        >  #27: libvcllo.dylib`SVMain at vcl/source/app/svmain.cxx:230:12
        >  #28: libsofficeapp.dylib`soffice_main at desktop/source/app/sofficemain.cxx:98:12
        >  #29: soffice`sal_main at desktop/source/app/main.c:49:15
        >  #30: soffice`main at desktop/source/app/main.c:47:1
        
        Change-Id: Ic5681f21a153e42a27680a9a6a179aff38f77fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143565
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [e7f62648f01ba776357e9fcbb9f49c2fb3490ab1]

        make Notebookbar customize page match indent with the others
        
        remove intermediate grids with just one child, name the containers
        of the groups of widgets to be hidden and hide the container rather
        than the individual members so the container space doesn't push
        this page out of alignment with the others.
        
        Change-Id: Ie3fb291da49a6b43ca4516e5fe55b828543631e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143838
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Caolán McNamara  <caolanm@redhat.com>  [7938f3f84dec59e0714b4b4c97eb35fc26ba7054]

        resave with latest glade
        
        Change-Id: I548fac08a9b4d62d6e71bf5fa687d5c1ff2e11b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-09  Justin Luth  <justin.luth@collabora.com>  [78b5195d8add0679263a5e08ba34be9b27637a65]

        tdf#149240 docx content controls: round-trip showingPlcHdr better
        
        ShowingPlaceHolder causes all the text in the control to be
        selected when the control gains the focus. Otherwise, just a
        cursor is placed at the click point.
        
        While round-tripping this attribute worked for inline SDTs,
        it was lost for block SDTs. But BlockSDTs are very easy
        to create. The MS templates are full of them.
        
        Also, these are boolean, but it could have a val=0 specified,
        in which case it is off, but we were importing it as on.
        
        
        Change-Id: I167afa935311a63bba408ecd489ae819485a5cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143818
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-09  Miklos Vajna  <vmiklos@collabora.com>  [2d9a3f8137e82af4a419441b58f80c027eee51b1]

        sw: remove unused DocumentContentOperationsManager::InsertGraphicObject()
        
        Only tests called it, migrate those to
        DocumentContentOperationsManager::InsertGraphic() instead, which is what
        SwFEShell::Insert() and SwXFrame::attachToRange() use.
        
        Change-Id: Ie05b501507f8722bc0a312c2e729ecd76154ce98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143836
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [24eabdbebcbc3b9189bbb9809205ead9f903a0cb]

        Fix typo
        
        Change-Id: Iaa550d83da5823fe52c25afb8e403c998ce68b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143842
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-12-09  Jim Raykowski  <raykowj@gmail.com>  [11b87e7601fd24eb290854e9642bf01d0b4592ff]

        tdf#152029 Bring drawing objects to attention in the document view
        
        when mouse pointer is over drawing object entry in the Navigator
        content tree
        
        Change-Id: Idfeeb3854ffe76745f2f30a6ffac8528b2dda725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143844
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2022-12-09  Maxim Monastirsky  <momonasmon@gmail.com>  [95a3d7733c5b48c99b2b74b06c7eeee718fdcd03]

        Deduplicate table styles insertion
        
        (Not adding a test here, as this should already be covered
        by several tests in sw/qa/extras/odfexport/odfexport.cxx.)
        
        Change-Id: Ic3cae9f38efc55d3d9055a45bc642d7b15fa382a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143840
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-09  Maxim Monastirsky  <momonasmon@gmail.com>  [8bd31225d79f10993d0e0727ee7d27c729874b51]

        Fix sd encoded table style name handling
        
        Found this while looking into improving insertion of pages
        with tables, as SdDrawDocument::InsertBookmarkAsPage uses "_"
        as the rename suffix for styles with identical names but a
        different content.
        
        This commit fixes two issues:
        
        - For import, cell styles with encoded names couldn't be found
        by table styles. The reason is that styles are referenced in
        ODF by encoded names, but at runtime by display names. Yet we
        were searching the cell style family by encoded names. This was
        already handled for sw in insertTabletemplate(), and now do the
        same for sd.
        
        - For export, table template names were encoded, but then
        referenced by tables using their non-encoded names. This is
        unlike the sw code that doesn't encode them, and therefore
        doesn't have this problem. Looking at the schema, both
        table:name attribute of a table template, and table:template-name
        attribute of a table are of type "string", which suggests that
        there is indeed no need to encode those names. This aligns with
        the fact that table templates don't have a display-name attribute.
        
        Change-Id: Ie61b6a1c95b033404ee98f3fc40d8e82434a6a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143839
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-08  Bogdan B  <buzea.bogdan@libreoffice.org>  [15e94efb87118b0ceb4aa926181a8906259f369b]

        tdf#132293 remove unused imports from uitest
        
        Change-Id: I6f5b5d97dab27986a6b0046c42c20ec4d0527980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142531
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-12-08  Nalini Prasad Dash  <nnnalinidash@protonmail.com>  [855bf4d68865ef046c8f527bf19e3ec78c7b033a]

        tdf#114441 - Convert use of sal_uLong to better integer types
        
        The variable type of nHeight was changed as the return type of
        pFontHeightItem->GetHeight() is sal_uInt32.Also nBit was assigned
        the underlying datatype of LB(int) as it was checked against
        LB::LAST(Value converted to underlying datatype of LB) in the for loop .
        
        Change-Id: I657d545ac7af1786edd61569ba43b42e55d1f47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143145
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-08  Bogdan B  <buzea.bogdan@libreoffice.org>  [0569a84c16e6ee6ed6f4fb52c23ed6dfe4225cdf]

        tdf#152299 - Remove unused define(s) from C/C++ files
        
        Change-Id: I22185ee21af426974cf57bda288320413bd119a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143434
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-12-08  Stephan Bergmann  <sbergman@redhat.com>  [3f564769446032825b20ca6414caa1c196076ddc]

        external/zxing: Avoid MSVC 2022 error C2326
        
        > workdir/UnpackedTarball/zxing/core/src/qrcode/QRDetector.cpp(431): error C2326: 'auto ZXing::QRCode::SampleMQR::<lambda_1>::operator ()(int,bool) const': function cannot access 'FORMAT_INFO_COORDS'
        
        seen at least with VS 2022 17.4.2 and VS 2022 17.5.0 Preview 1.0, but not with
        VS 2019 16.11.21.  It looks to me like a bug in MSVC, but then again it doesn't
        hurt to make that variable static, anyway.
        
        Change-Id: I48fa22f9495791e60953f9f717ffc8333314de1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143826
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [20d3af853d327ab66cf55ccdfc5991a13993c47d]

        Related: tdf#152266 remove office:scripts from wizard letter templates
        
        all the assignments are blank anyway, but its not desirable to have
        these.
        
        Change-Id: I5d7bd7bbdc65b286daad37cd6c368f86e0bb2785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143821
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [8a33bde5288a4a652de35846aa34354044b872c3]

        tdf#152266 only warn about script:event-listener with non-empty targets
        
        Change-Id: I19518c4872b522686b3df1881ccee02d840c3db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143829
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [c2c7c378ff8c1e3ba12420aa75189b9b1fe8515b]

        update assign/delete state after positioning cursor in treeview
        
        Change-Id: I9fe2d9d4a3575e0b67c8421d215f65f46c2ac1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [9fc0e4fa50e22c464dde702fcaa25420fa5ce5a4]

        resave with latest glade
        
        Change-Id: I089e6c872b52ef530d0e6279fa8fd10576ccc6dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143831
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [af6f87e66bc7f6257524df68ca9d90e6072558f6]

        bump product version to 7.6.0.0.alpha0+
        
        Change-Id: I4cc88c54d42dd141f03c46377cd5c2f2fa56ad7b

2022-12-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1c629ca0048670db4bed5e7d8d76bcf8e81f2158]

        Update git submodules
        
        * Update translations from branch 'master'
          to f201069fb109d5c24dd18d03f393de1169056956
          - remove name attribute from links for sl from last update
            
            Change-Id: Iddcea1018599043d5db47afd7fc7207c1a388a96
            
          - update translations for 7.5.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Id9f87177a20fe0832571d86c1802926b960ec1e8
            
2022-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [da798460e370a97597ecc9a06634f400c4b2e0cc]

        crashtesting ooo84576-1.odt
        
        prevent the OOM by detecting cycles in SwList::SwList and throwing an
        exception.
        
        (1) However, that means we need to catch the exception in
            XMLTextListBlockContext::XMLTextListBlockContext
        and undo some registration, otherwise we will get a use-after-free.
        
        The need to catch it is why I'm using an UNO exception here,
        it seemed like a bad idea to throw and then catch and std::foo
        exception.
        
        (2) this is still not the end of the story, a further exception
        is thrown during SwDoc destruction, for which I don't have a
        solution.
        
        Change-Id: I48be3d8acbdc0f9ca948a958f1124b158ba77ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Miklos Vajna  <vmiklos@collabora.com>  [243131397a5b626c2d8442dc716193e27b13ef9f]

        sw: introduce a .uno:GotoMark command
        
        This is meant to be used from macros, it does the same as manually
        opening the navigator, selecting a given bookmark and pressing enter.
        
        It also helps debugging when you want to jump somewhere, but the
        surrounding document content changes, so jumping to a certain page won't
        work due to the changing page number.
        
        Change-Id: I3bc08ae8023997bab89cf4732fb67233a6a1e134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143825
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-08  Michael Stahl  <michael.stahl@allotropia.de>  [515df96a85878f10dae3c9d1274ef4575d2e3215]

        sw: DOCX export: avoid writing duplicate w:b to w:pPr
        
        This prevents validation of documents in unit tests, only one w:b is
        allowed.
        
        The problem is that Writer has 3 different bold attributes, but Word
        apparently has only 2 of them, so Western and CJK are now both mapped to
        w:b.
        
        But RTF export oddly maps CJK and CTL to \ab, in contrast to DOC/DOCX.
        
        Change-Id: Icb9ece988de29e54dc320c483c74a4d4b8b70141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143814
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [9284baf914f7136d7302d57cbf1f25672197de9c]

        unused suppression
        
        Change-Id: I1478636970349e56e2a28211bf8c3015da90db00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [78da075e1b9d3b3a5c0b1302f5536678f0c04923]

        Resolves: tdf#152421 'GTK_IS_LABEL (label)' assertion failure
        
        Change-Id: I33d76f4a84d7ef1cd14cb5f2597f38385eff2e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [a2a08463e0299d514e6e555ae61c68bb0e4348d0]

        Simplify management of id-to-style-to-string-id mapping
        
        Instead of having three container objects for that, use one vector of
        appropriate structures. Slots are in sync and unique automatically.
        
        Change-Id: Ibb2c48ce42bf98f84df8230439ca98cb5b75051a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143807
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-08  Alain Romedenne  <alain.romedenne@libreoffice.org>  [1cafff12c38b2568e213a51d8061de7b4d8f15ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9cd78ba1f7b77ed8a062906f2e553a4dbfca6ea4
          - tdf#134377 fix faulty embed tags in help
            
            Change-Id: I4895c9d9b05f05ffeeb6206fbe39d0ce4332d5f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143726
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-08  Alain Romedenne  <alain.romedenne@libreoffice.org>  [42987658c4164a099dbeab50b8e2e42f3eda02bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ae4510ed1ad0cdaf9ec52ff6bd4423c436dceae
          - Fix to python script sample
            
            Change-Id: I9e79c85aecde08225212fd7985d32bd55a5f7bf1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143724
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [417f6fde55a7fa59f27aa9a79132e5b2cc615270]

        Resolves: tdf#152325 initial "select" may not set the cursor to that pos
        
        but setting the cursor will 'select' for the default "single" selection
        mode.
        
        Change-Id: Ib7c3dfcce72bad69741b5bc3eb159a6ed3bc8142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [ebc7e13c0a79dbc5f21e78bcd9bb63a58c585f4a]

        Resolves: tdf#146395 allow newlines in QR Codes
        
        Change-Id: Ib390d97866ab013770e4f1cbdfb529296d64c140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143811
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Caolán McNamara  <caolanm@redhat.com>  [00e5509f07e1e53d506fc824df32e38a266952b1]

        ofz#53824 Out-of-memory
        
        Change-Id: I348da7f237146dfa690b974dcabdf26369997eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Stephan Bergmann  <sbergman@redhat.com>  [3e1c606185dc8480a8e9a43e23a6596551570510]

        external/zxing: Missing includes
        
        ...at least when building with --with-latest-c++ against recent LLVM 16 trunk
        Clang and libc++,
        
        > In file included from workdir/UnpackedTarball/zxing/core/src/datamatrix/DMDetector.cpp:8:
        > In file included from workdir/UnpackedTarball/zxing/core/src/datamatrix/DMDetector.h:10:
        > workdir/UnpackedTarball/zxing/core/src/Generator.h:15:16: error: no type named 'movable' in namespace 'std'
        > template <std::movable T>
        >           ~~~~~^
        > workdir/UnpackedTarball/zxing/core/src/Generator.h:70:24: error: no type named 'default_sentinel_t' in namespace 'std'
        >                 bool operator==(std::default_sentinel_t) const { return !_coroutine || _coroutine.done(); }
        >                                 ~~~~~^
        
        Change-Id: I26720e4d07498b277ec879129634064f1d45362a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143809
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-08  Eike Rathke  <erack@redhat.com>  [17b302b092b5c90552720097fe87c8eedc8f83df]

        Related: tdf#120190 Factor out ScDocument::CreateSharedStringTextObject()
        
        Change-Id: I51c1244406e30f5a3893eac42aed65fc92ab1d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143805
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [44db6349aa9f6155c1b0a7c6d3c1041b85f4c746]

        fix build
        
        mid-air collision between
            commit 7243f7c706ceb49d6b3e4dfb8ff72ab43c65dd86
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Dec 7 14:08:45 2022 +0200
            loplugin:unusedmethods
        and
            commit be6024a2d4fc11c908aeb29b58ce33f851dab6bc
            Author: Rafael Lima <rafael.palma.lima@gmail.com>
            Date:   Mon Dec 5 11:33:32 2022 +0000
            tdf#152078 Enable Ctrl+Wheel zoom in Basic code editor
        
        Change-Id: I155fc7fc5977f7346a44e93237f9b09f6fa86464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143808
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-08  Tarcísio Ladeia de Oliveira  <wyrquill@gmail.com>  [8f6dd15dce1e6116947b512c89d802fccc0bd6f1]

        vcl: check for null device
        
        The xmloff/draw test series was crashing soon after "testTextBoxLoss"
        finished. Even though it finished successfully, CppUnitTest was crashing
        when popping the protector. From the backtrace, the crash resulted from
        attempts to access null pointers.
        
        I do not know what caused those pointers to be null, but I added the
        checks so that it could at least proceed to the other tests.
        
        Change-Id: Ia0014a273142442a791a43fb9e3f75c2452bbd45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Patrick Luby  <plubius@neooffice.org>  [9ee57f36e26373ee7144d076c93c3462c4fc7110]

        tdf#82115 Commit uncommitted text when a popup menu is opened
        
        The Windows implementation of the SalFrame::EndExtTextInput() method commits or discards the native input method session. It appears that most macOS applications discard the uncommitted text when cancelling a session so always commit the uncommitted text. This change also commits any uncommitted text and cancels the native input method session whenever a window loses focus like in Safari, Firefox, and Excel.
        
        Note: if there is any marked text, SalEvent::EndExtTextInput may leave the cursor hidden so commit the marked range to force the cursor to be visible.
        
        Dispatching SalEvent::EndExtTextInput in SalFrame::EndExtTextInput() creates some other related native input method handling bugs that have also been fixed in this patch:
        
        - Whenever a SalEvent::EndExtTextInput event is dispatched, cancel the native input method session so that the native input context's state is in sync with LibreOffice's internal state. The only exceptions are in [SalFrameView insertText:replacementRange:] or [SalFrameView setMarkedText:selectedRange:replacementRange:] because when these two selectors commit text, the native input method session has already been cancelled and calling [SalFrameView endExtTextInput] will cause repeated text insertions from the native macOS Character Viewer dialog to overwrite previous insertions.
        
        - Highlight all characters in the selected range. Normally uncommitted text is underlined but when an item is selected in the native input method popup or selecting a subblock of uncommitted text using the left or right arrow keys, the selection range is set and the selected range is either highlighted like in Excel or is bold underlined like in Safari. Highlighting the selected range was chosen because highlighting was used in LibreOffice 7.4.x and using bold and double underlines can get clipped making the selection range indistinguishable from the rest of the uncommitted text.
        
        - The fix for ooo#106901 always returns a zero length range if [self markedRange] called outside of mbInKeyInput. If a zero length range is returned, macOS won't call [self firstRectForCharacterRange:actualRange:] for any newly appended uncommitted text and the native input method popup will appear in the bottom left corner of the screen. So, [self markedRange] now returns the marked range if is valid.
        
        - Commit uncommitted text before dispatching menu item selections and key shortcuts. In certain cases such as selecting the Insert > Comment menu item or pressing Command-Option-C in a Writer document while there is uncommitted text will call AquaSalFrame::EndExtTextInput() which will dispatch a SalEvent::EndExtTextInput event. Writer's handler for that event will delete the uncommitted text and then insert the committed text but LibreOffice will crash when deleting the uncommitted text because deletion of the text also removes and deletes the newly inserted comment.
        
        Change-Id: I4ff4682aeef7d42ce26059aa76f971a68128833c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Patrick Luby  <plubius@neooffice.org>  [60d2dd11a73bf7a1269896f15b1ec7c98507571e]

        Related: tdf#82115 Fix crash when handling input method events
        
        The nodes in mpIMEInfos may be deleted in ImpEditEngine::Clear() which causes a crash in the CommandEventId::ExtTextInput and CommandEventId::EndExtTextInput event handlers.
        
        This crash occurs on Windows or macOS using the following steps:
        - Enter uncommitted text (enter "aaa" with a Japanese Hiragana input method) in a comment in a Writer document
        - Switch to another empty Writer document without committing the text in the first Writer document
        - Switch back to the first Writer document
        
        The above steps may need to be repeated a few times but it will eventually crash with the following stack trace:
        
        (lldb) bt 25
        * thread #1, queue = 'com.apple.main-thread', stop reason = hit program assert
            frame #0: 0x00000001b928ad98 libsystem_kernel.dylib`__pthread_kill + 8
            frame #1: 0x00000001b92bfee0 libsystem_pthread.dylib`pthread_kill + 288
            frame #2: 0x00000001b91fa340 libsystem_c.dylib`abort + 168
          * frame #3: 0x00000001b91f9754 libsystem_c.dylib`__assert_rtn + 272
            frame #4: 0x000000010374a09c libeditenglo.dylib`ImpEditEngine::ImpRemoveParagraph(this=0x000000011a684e00, nPara=-2147483648) at impedit2.cxx:2512:5
            frame #5: 0x0000000103739658 libeditenglo.dylib`ImpEditEngine::ImpDeleteSelection(this=0x000000011a684e00, rCurSel=0x000000016fdf7250) at impedit2.cxx:2473:9
            frame #6: 0x0000000103739328 libeditenglo.dylib`ImpEditEngine::DeleteSelected(this=0x000000011a684e00, rSel=0x000000016fdf7250) at impedit2.cxx:259:19
            frame #7: 0x000000010373aac4 libeditenglo.dylib`ImpEditEngine::Command(this=0x000000011a684e00, rCEvt=0x000000016fdf7698, pView=0x0000600000169e10) at impedit2.cxx:408:24
            frame #8: 0x0000000103721744 libeditenglo.dylib`ImpEditView::Command(this=0x00000002e3f8b7b0, rCEvt=0x000000016fdf7698) at impedit.cxx:1757:41
            frame #9: 0x00000001036d7df4 libeditenglo.dylib`EditView::Command(this=0x0000600000169e10, rCEvt=0x000000016fdf7698) at editview.cxx:495:26
            frame #10: 0x000000010b1d2420 libsvxlo.dylib`WeldEditView::Command(this=0x0000600002b11e30, rCEvt=0x000000016fdf7698) at weldeditview.cxx:312:23
            frame #11: 0x00000002ea78dd50 libswlo.dylib`sw::sidebarwindows::SidebarTextControl::Command(this=0x0000600002b11e30, rCEvt=0x000000016fdf7698) at SidebarTxtControl.cxx:461:26
            frame #12: 0x000000011656f3d4 libvcllo.dylib`weld::CustomWeld::DoCommand(this=0x000060000016a740, rPos=0x000000016fdf7698) at customweld.cxx:93:32
            frame #13: 0x000000011656ee7c libvcllo.dylib`weld::CustomWeld::LinkStubDoCommand(instance=0x000060000016a740, data=0x000000016fdf7698) at customweld.cxx:91:1
            frame #14: 0x0000000115ca1dd4 libvcllo.dylib`Link<CommandEvent const&, bool>::Call(this=0x00000002e3f8bc48, data=0x000000016fdf7698) const at link.hxx:111:45
            frame #15: 0x00000001165b1658 libvcllo.dylib`SalInstanceDrawingArea::CommandHdl(this=0x00000002e3f8bb50, rEvent=0x000000016fdf7698) at salvtables.cxx:6473:26
            frame #16: 0x00000001165af588 libvcllo.dylib`SalInstanceDrawingArea::LinkStubCommandHdl(instance=0x00000002e3f8bb50, data=0x000000016fdf7698) at salvtables.cxx:6471:1
            frame #17: 0x0000000115ca1dd4 libvcllo.dylib`Link<CommandEvent const&, bool>::Call(this=0x00000002e3f90208, data=0x000000016fdf7698) const at link.hxx:111:45
            frame #18: 0x0000000115d047d0 libvcllo.dylib`VclDrawingArea::Command(this=0x00000002e3f90080, rEvent=0x000000016fdf7698) at layout.hxx:685:27
            frame #19: 0x0000000115e2e2bc libvcllo.dylib`ImplCallCommand(pChild=0x000000016fdf77c8, nEvt=ExtTextInput, pData=0x000000016fdf77d8, bMouse=false, pPos=0x0000000000000000) at winproc.cxx:229:17
            frame #20: 0x0000000115e34458 libvcllo.dylib`ImplHandleExtTextInput(pWindow=0x0000600002aa8930, rText=0x000000016fdf8290, pTextAttr=0x0000600000018710, nCursorPos=4, nCursorFlags=1) at winproc.cxx:1424:13
            frame #21: 0x0000000115e30dc8 libvcllo.dylib`ImplWindowFrameProc(_pWindow=0x0000600002aa8930, nEvent=ExtTextInput, pEvent=0x000000016fdf8290) at winproc.cxx:2863:20
            frame #22: 0x000000011b0424e0 libvclplug_osxlo.dylib`SalFrame::CallCallback(this=0x00000001378ffb40, nEvent=ExtTextInput, pEvent=0x000000016fdf8290) const at salframe.hxx:306:29
            frame #23: 0x000000011b0ef8f4 libvclplug_osxlo.dylib`-[SalFrameView setMarkedText:selectedRange:replacementRange:](self=0x00000002c4b0d980, _cmd="setMarkedText:selectedRange:replacementRange:", aString="嗚呼嗚呼", selRange=location=4, length=0, replacementRange=location=9223372036854775807, length=0) at salframeview.mm:1595:18
            frame #24: 0x00000001bc8d6a2c AppKit`-[NSTextInputContext(NSInputContext_WithCompletion) setMarkedText:selectedRange:replacementRange:completionHandler:] + 168
        
        Change-Id: I500824967d56232272041f8a2b972cdb2c9fe05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143806
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-08  Stephan Bergmann  <sbergman@redhat.com>  [8cfffbc67ad25510d194e611871950979dc82253]

        Stick to three-letter build step prefixes
        
        (it makes the output so much nicer to look at :)
        
        Change-Id: Ib4844e264fd950082b19994156661f460331a2d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143784
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b8d5e8affe256b80a28cba67db56d2666ec31cc]

        tdf#62057: move UItest to CppUnittest
        
        Change-Id: I5be16135c563ed15acf45b93c59189531b832b37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143782
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [e8ff90d35ef69af5f80f4d05c1fe8e79447057a0]

        CppunitTest_chart2_uichart: factor out common code
        
        Change-Id: I36c5356953208f6e92ac4a96aa4fa9473f655ab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143779
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-08  Tor Lillqvist  <tml@collabora.com>  [bd8f2af5bb48e23689719a056e829bcb38d5d14b]

        Fix Emscripten build
        
        Change-Id: Ia379886ff843f72a761c64e4bdfe023b23efd586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143786
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [be6024a2d4fc11c908aeb29b58ce33f851dab6bc]

        tdf#152078 Enable Ctrl+Wheel zoom in Basic code editor
        
        Change-Id: Ic68ae67c311a83e4003da2ca7486fcbf6698bdc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143584
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [705b2924a14841883b4a8cac549f7af326d7a185]

        Removed useless semicolon
        
        Change-Id: I0c931d5f856bda5b6ec91d813fe92fbc72ff1aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Jim Raykowski  <raykowj@gmail.com>  [26b64750ea15812de172985b50e6f22c2c71a60d]

        tdf#152029 Bring tables, frames, images, and ole objects to
        
        attention in the document view when the mouse pointer is over these
        content type and content entries in the Navigator content tree
        
        Change-Id: I9493203c2011a2f02fb6ddb6741992d43eaf4ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143763
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Jim Raykowski  <raykowj@gmail.com>  [8dbb69bcee477886fab752f9bd158cf54951b827]

        tdf#152029 Bring headings to attention in document view
        
        when the mouse pointer is over headings content type and content
        entries in the Navigator content tree
        
        Change-Id: Id99515b03615b93227495c24ebff45bf9f479bdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Jim Raykowski  <raykowj@gmail.com>  [329c32d1e9e316f3ba75d38dd4565ea14599ec9a]

        tdf#152029 Bring refmarks and textfields to attention in document view
        
        when the mouse pointer is over these content types and content entries
        in the Navigator content tree
        
        Change-Id: I07754d79597d1df4baa696dd86c58ff601576e5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143695
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Jim Raykowski  <raykowj@gmail.com>  [7ed2502b7f67d2f349c5fb58703557cf310e7e14]

        tdf#152029 Bring hyperlinks to attention in document view
        
        when mouse pointer is over hyperlink entry in the Navigator content
        tree
        
        Change-Id: I84693426277f2394f2c4b6f7bae5143bd1909285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143636
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-08  Martin Srebotnjak  <miles@filmsi.net>  [dff93e6387172b208355bc5f1b82344ecce4d25d]

        Update git submodules
        
        * Update translations from branch 'master'
          to ced285e64bd6856c29ff97baeedf638999617b6d
          - Updated Slovenian translation
            
            Change-Id: Ie51bf4dc89ebff4ea2b91eed934892f09f8029d2
            
2022-12-08  Miklos Vajna  <vmiklos@collabora.com>  [33da0909986aad344a956d2a710b3b8687da1a11]

        CppunitTest_svgio: use CPPUNIT_TEST_FIXTURE()
        
        This suite is large enough so that avoiding the
        declaration/registration/definition of each test manually saves a lot of
        space.
        
        Change-Id: I08359c52cfbbd2ff17ec61722479cda26f308590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143800
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [52c75986adc2b370eb55ce918ab1db0a95831c83]

        Simplify uses of FastAttributeList::add
        
        Change-Id: I91a73bad3d12e06bb5ee1d62965b62ba50262183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-08  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9c7b3bded56aba4c6c2fb02c358f2d1ab1bc72fd]

        Tweak recently introduced strings according to typography guidelines…
        
        ... and to solve a long-standing typo that went unnoticed
        
        Change-Id: Ic129550627267300f689fd2fc9f55749b355a6f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143797
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-08  offtkp  <parisoplop@gmail.com>  [ad085990b8073a122ac5222e5220f8f1d6826dcf]

        xlsx: Don't add cell data to chart data sequence if in totalsRow
        
        When importing data from a cell range to use in a chart, if a cell is in
        the totalsRow it is now ignored if it's the last row in the range.
        
        Change-Id: Ie8c79b995c4d46b361492e8f7687894e2640392f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143488
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-07  Eike Rathke  <erack@redhat.com>  [40a59e3e58de1c3f60ae52d09fbc386399f8f122]

        Resolves: tdf#120190 Handle multiline string in Formula to Value conversion
        
        ... as usual as EditTextObject.
        
        Change-Id: Iddb52593851dcf371318f29318902ae8d4b483d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143801
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-07  Khaled Hosny  <khaled@aliftype.com>  [f6935ce552ed625281104a10695de977a131b477]

        tdf#152413: Revert "tdf#67669 - Make narrow no-break space visible by drawing
        
        ... a gray background"
        
        This is breaking text layout involving Narrow No-Break Space because now
        it goes into a portion of its own and gets laid out independent of the
        surrounding text.
        
        Lets revert this until we have a way to highlight text without breaking
        text layout (e.g. tdf#61444).
        
        This reverts:
        
        commit bbb57e8198863ee7bdadd3f2aac4420c08da94a3
        Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Date:   Wed Jul 27 08:53:11 2022 +0200
        
            tdf#67669 - Make narrow no-break space visible by drawing a gray background
        
        and its followup commit:
        
        commit 01e3c998e63fbf456e7f624adb1cae3d89ed7bb2
        Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Date:   Mon Aug 22 23:02:48 2022 +0200
        
            tdf#67669 - Make narrow no-break space visible by drawing a gray background
        
        Change-Id: I040a4f17d51cfea4f1e9bdcd3bc14a3bfc56b245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143802
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [d327a3bf45808fc7575b7fffa681314e50b0adf8]

        Resolves: tdf#152301 allow using an existing ColorListBox to speed init
        
        Change-Id: I31fb350fd69831e68ca7c60ec758126aab086895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [62ae7be5aa20499c45e6f1b3f1dd2729483625b0]

        Related: tdf#152301 cache color widget width
        
        Change-Id: I0030980e2259715aa1fa624eb0ee82d5dfc51810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143778
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [5d77fe6e7a386efda32a19d3bca587b1ad12715d]

        ofz#53824 Out-of-memory
        
        Change-Id: Ia90527f97a4febf3bbdf1919e8db3d8ab5375ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143803
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Eike Rathke  <erack@redhat.com>  [fa962506073ff273881978c2a0bb7b5fb199f94f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18924c3c7275e794703997e315910d99395dcd69
          - Add a note to the STYLE() function to not use it without reason..
            
            Change-Id: I74b30b58bdfbc5a4392f344a2de8a600b2eca030
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143804
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [01b30c701d065fc9a4582b9bbac221d1edffb45b]

        Allow hyphen-minus in style ids
        
        These are used in OOXML; and hyphens are allowed there (at least
        Word uses ids like "E-mailSignature" for "E-mail Signature").
        
        Change-Id: I399e84def504a716553fcfc2b624e58aa7d9ba70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143795
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4d83725981e46c62efb5ce6a68ae7c345465b448]

        tdf#53023 - Revert hanging unit test
        
        Change-Id: I7975ec874c4d636f0747417b138ffe64fb89e2cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143719
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [920e3246df9bb95f504adf9496be32a8ecdda1be]

        Update git submodules
        
        * Update translations from branch 'master'
          to cdfaa521c1ae3d7e579b0a8004ccd4878fa4411d
          - update translations for master/7.5.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Icd98b0989374eb876ff12151843b981dc723dba5
            
2022-12-07  Bogdan B  <buzea.bogdan@libreoffice.org>  [8d33561c638c7a5da2fb5ebebbb0943fd0b33ac3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8961270e4ca006146883b00c3847d88eaa5a91f9
          - tdf#152022 Improve comments description in Help
            
            Option to reply to comments is inactive until we have comments from other users.
            
            Change-Id: If105cd50bed65371be47b426318ddd71ba650f5c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143792
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-07  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [52f200919298f3ca1d2abd3c7af9b5fb9c04fc1e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0369e1b2008d9af7b917a8348bec867d2f9334a0
          - remove name attribute from links for sl translation
            
            see https://gerrit.libreoffice.org/c/help/+/143713
            
            Change-Id: I31e5c008ded5f77685bee84a7a27474ca1d8a1e8
            
2022-12-07  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [e724de2e2e2a4ab98aef4c26945dd0ddf33e39da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7e42394ecbf921ee53160b495aa12c1cba158604
          - tdf#152323 drop name attribute from <link> elements
            
            Replacement done with
            
            find . -name \*.xhp -print0 |xargs -0 -P 0 perl -CS -pi -e \
                    's#(<link[^>]*?) +name *="[^"]*" *( [^>]+|) *>#$1$2>#g'
            
            (note some inconsistencies with space between name and = and also having
            empty value, and some more complicated expression to also clear up
            double space before/after the attribute)
            
            translation files will be prepped with:
            
            find */helpcontent2 -name \*.po -print0 |xargs -0 -P 0 perl -CS -pi -e \
                $'s#(<link[^>]*?) +name=(?:\\\\"[^"]*\\\\"|\'[^\']*\') *( [^>]+|) *(/?>)#$1$2$3#g unless /^#/'
            
            (note that not all languages use the " as quote character for the
            attributes, but that also single quotes appera in the po file. Hence
            the use of the shell $'string' syntax to be able to quote ' as \'
            It also requires to quote the backslash, so that it needs to be escaped
            once for the shell, then another time for perl. Also don't work on
            obsolete strings (those are prefixed with #~ in the po files)
            Also note that <link..></link> gets turned into <link ../> during
            translation extraction (along with removal of the space between the
            attribute name and the value), so the pattern needs to be slightly
            different here)
            
            Change-Id: I95e53a08e6b0095cd894109ea0de154cc4859d8f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143713
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2022-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [7243f7c706ceb49d6b3e4dfb8ff72ab43c65dd86]

        loplugin:unusedmethods
        
        Change-Id: I5497d5b39620ff9fde09af923d3e41dedbab3326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143774
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-07  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [368116fb55eb83c9f8c7eb180044f848294638bb]

        zxing-cpp: upgrade to release 1.4.0
        
        == list of removed patches ==
        * 0001-Use-a-patch-file-to-document-changes-from-upstream-s.patch: fixed upstream[1].
        * 0002-Update-stb_image_write-from-1.14-to-1.16.patch: fixed upstream.
        * 0003-Update-stb_image-from-2.25-to-2.27.patch: fixed upstream
        * 0004-Apply-stb-PR-1223-to-stb_image.patch: "stb_image.h" and "stb_image.patch" were removed upstream[1][2].
        * include.patch.0: fixed upstream (added #include <cstdint>)[3].
        * zxing_newline.patch: this issue has been fixed since gcc 11.2/12 or later[4].
        
        == list of added patches ==
        * android_include.patch.0: added missing #include <cmath>(for std::abs)
        * assume.__cpp_lib_string_view.patch.0 (by Caolán McNamara): fixed "error: no member named 'asString' in 'ZXing::ByteArray'"
        
        [1] https://github.com/zxing-cpp/zxing-cpp/commit/b208f4bd9052527b7a499d178d81d55b30a27c2d
        [2] https://github.com/zxing-cpp/zxing-cpp/commit/d2603139c57e2bbca770656a683abb124adc1591
        [3] https://github.com/zxing-cpp/zxing-cpp/commit/53da58625dcd519b7c10e2349a83c9bd10105cf7
        [4] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100392
        
        Change-Id: I6266fd6609f0d4235a8d2bcb6571817ef2135101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142553
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [e58ad604df2022450bec0d83d496037c799ae969]

        Resolves: tdf#152411 clear before freeze to let gtk a11y drop reference
        
        Change-Id: I2c0f852a0432e7319644b0ea11533b6d153b4ac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143780
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [8e3258f7d62ec154f2d80af2f39028a4c40fa12f]

        tdf#136011: move UItest to CppUnittest
        
        Change-Id: Id8ea0fcfef8598f163febe2aa2564b0ce9d0657f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143769
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3772f18266c3347e8fd60eb8f058d65328c400b4]

        tdf#53023 - Remove last empty paragraph from auto text
        
        Remove the last empty paragraph before inserting an auto text.
        The carriage return at the end of it is appended in
        SwXMLTextBlockParContext::~SwXMLTextBlockParContext()
        which can't be removed without introducing side effects.
        
        In order to compensate for the change, a paragraph has been
        added to the existing only text auto texts.
        
        Patch was reverted due to a hang of the ui test. It seems that
        selecting an entire text using mkPropertyValues({"KEYCODE":"CTRL+A"}))
        does not work anymore.
        
        Change-Id: I08f612d50f496c8d7f891c773ddedf27c3d80864
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143781
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [39bb374ad949ed10b71d7f5327607df5bcdd05a6]

        loplugin:unusedfields
        
        Change-Id: I4c9c27e5fd8193b87ac46318671f787939f2d64e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [1545e3a5ba940e2bd8d1f8a29a22e29e1e326f6d]

        Related: tdf#152301 fix gtk warnings
        
        Change-Id: I5d9354d1cf53be68a63a53b21f75cb5070df406c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [364b63ff4ed9410524fa2785c73bb58108fd6c06]

        ofz#54093 Null-dereference
        
        Change-Id: I00b3762d9f8a17ed51db397a5d2ccc88c3c7fcf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [82afcf2d945f5e2465c82bc846440bc12909e9f8]

        stray fprintf
        
        Change-Id: I6b74eeac5cc881ffe6b1676941b3ae462a284f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143744
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f0794e69ec0f8fdcf6a152bfed77b1f18f1b918]

        chart2: pass chart number to getChartCompFromSheet
        
        will be used in the following commit
        
        Change-Id: I9d0925d0ef2bf93c01499a62b8eeb4153aceb9cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143768
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [6e502de67a7a19d33dcb69cbd35366c4dd0850f9]

        ofz#54088 Use a DeleteListener rather than try to predict what gets deleted
        
        Change-Id: I5e49e0904422ed513f302f05583ef8140b58ef72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Mike Kaganski  <mike.kaganski@collabora.com>  [9a3adb8c3a8782c4dfacb5ed383c33ef1a1deeec]

        Natvis: improve O(U)String visualizers
        
        ... and unify them.
        Makes sure to show non-printing/special characters in the strings
        (like \n, which didn't show properly); expands buffer to show all
        its elements, not only the first one.
        
        Change-Id: Iab12bbb51f9e39b066866649b297f51837c7c0f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143767
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c140c01748a30da1f83254b28ca7ab7a620197e]

        loplugin:singlevalfields
        
        Change-Id: Ic7dd2cb433add02ecc72eee0c85dd7f0efe1d47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143771
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-07  Stephan Bergmann  <sbergman@redhat.com>  [cb26710b6b40df59f34dd6a65988cd55e32153b0]

        Check for failed malloc
        
        ...thereby silencing
        
        > In file included from /usr/include/features.h:490,
        >                  from /usr/include/bits/libc-header-start.h:33,
        >                  from /usr/include/stdio.h:27,
        >                  from soltools/mkdepend/def.h:40,
        >                  from soltools/mkdepend/main.c:58:
        > In function ‘read’,
        >     inlined from ‘main’ at soltools/mkdepend/main.c:197:28:
        > /usr/include/bits/unistd.h:38:10: error: ‘__read_alias’ specified size 18446744073709551614 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
        >    38 |   return __glibc_fortify (read, __nbytes, sizeof (char),
        >       |          ^~~~~~~~~~~~~~~
        > /usr/include/bits/unistd.h: In function ‘main’:
        > /usr/include/bits/unistd.h:26:16: note: in a call to function ‘__read_alias’ declared with attribute ‘access (write_only, 2, 3)’
        >    26 | extern ssize_t __REDIRECT (__read_alias, (int __fd, void *__buf,
        >       |                ^~~~~~~~~~
        
        seen at least with -Wp,-D_FORTIFY_SOURCE=3 manually added to gb_COMPILEROPTFLAGS
        in an --enable-optimized build against recent GCC 13 trunk
        
        Change-Id: I9ca3c0ea8c579fffbdad52d7d39a4ce82085ddcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-07  Miklos Vajna  <vmiklos@collabora.com>  [e0bf2712aa9e240748534e3a7498d41c8eeeb9d7]

        sw, lok: implement a getCommandValues(Bookmarks)
        
        There was no LOK API to get a list of all bookmarks where the name
        matches a certain prefix.
        
        This is useful in case the API client wants to know what previously
        inserted bookmarks were deleted by the user as part of deleting text
        content.
        
        Add a new getCommandValues(".uno:Bookmarks") that returns the names of
        matching bookmarks. Do not return the bookmark text, assuming that would
        be updated by the API client anyway.
        
        In practice this is needed by Zotero in case it wants to model its
        citations with bookmarks.
        
        Change-Id: I42a544c3c64496519eec6826b58a310ec86dee74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143764
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [36a554e1f1c4e924a2cbc2df5a4f164fa31e3d6b]

        Revert "tdf#53023 - Remove last empty paragraph from auto text"
        
        This reverts commit ce64398653a896c8a48dd6cabe2b75d9c025873d.
        
        Reason for revert: UI-Tests hang
        
        Change-Id: Ib4b576e66da8642f3ffe8774e92a7e7c2c527b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143717
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-07  Stephan Bergmann  <sbergman@redhat.com>  [d193d65635de197efe32d97a99540a31a5455c41]

        tdf#151894 Pre-init NSSpellCHecker to avoid SolarMutex deadlock
        
        Besides the deadlock scenario documented at
        <https://bugs.documentfoundation.org/show_bug.cgi?id=151894> "FILEOPEN a Base
        Document with customized event for open a startform by 'open document' LO stuck"
        there is at least one other known scenario documented at
        <https://gerrit.libreoffice.org/c/core/+/143565/> "Fix hang during
        JunitTest_framework_complex on macOS" (which even carries a true fix, for just
        that one scenario, which wouldn't require this hack).
        
        Change-Id: Iafcb39607e71cc3abe46ce762f9c1785a62acfd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139702
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [e0e51cc5441669f6297383d8d50bfde2854be874]

        tdf#151185 Make Table Design button toggle-able
        
        Change-Id: I86dfc7a6567b24cc6e9a20203625eeb09c17536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143574
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-07  Maxim Monastirsky  <momonasmon@gmail.com>  [441ecdc951211cc1e8453434d26ae40c121cb153]

        sd: improve handling of table styles on page pasting
        
        - Remove table styles that were copied from the source
        document, but not actually used in the pasted pages.
        Same as we were doing already for graphic/cell styles.
        
        - Disable the undo record of inserted cell styles, as
        long as we don't have undo actions also for the table
        style. This prevents data loss, as otherwise the table
        style will be exported, but not the cell styles it uses.
        
        The difficulty with having an undo action for table
        styles is that once a style is removed from its family
        it is disposed, so we no longer able to use that style
        for a redo action. This was "solved" in i#120015 for
        graphic/cell styles, by not disposing them at all.
        However table styles maintain cyclic references with
        their cell styles, so we can't give up on disposing.
        
        I'll take the time to think on a proper solution for
        this (e.g. making copies of styles instead of dealing
        with the original ones might be an option). For now,
        let's just remove this unfinished undo attempt.
        
        Change-Id: Iae06273217b2d695401921a84e7edf096556530e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143749
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-07  Caolán McNamara  <caolanm@redhat.com>  [dab143489838c0b91eadc8bf7f9d7e2537336751]

        Resolves: tdf#152392 use sidebar text color for COL_AUTO in examples
        
        Change-Id: I5f5c1a6c79c65bd1d4bf2de4af02bef5d60ee5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143745
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-07  Miklos Vajna  <vmiklos@collabora.com>  [c2bcbd36d1913dc1d5ca4bb64fa30740f17bf326]

        sw: split out some of the LOK parts of SwXTextDocument into a separate file
        
        Because this has little to do with UNO.
        
        Change-Id: I683832d0704086f259a29bc1eefae77fd62f26e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143761
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-07  Kevin Suo  <suokunlong@126.com>  [83e58fc9f19a8da751cabdc0440aded62dc67fea]

        sdext: move the include of XComponentContext.hpp to where it is used
        
        ... and remove unsed include.
        
        XComponentContext.hpp is used in pdfiprocessor.hxx but not in drawtreevisiting.hxx.
        XMultiServiceFactory.hpp is not used drawtreevisiting.hxx.
        
        Change-Id: Ic98cbcdcacd07cf2163e02ac569781f70edd953c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143570
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-07  Miklos Vajna  <vmiklos@collabora.com>  [1e8c2068ec9d1551b84152d6cf66042dc2949594]

        sw layout xml dump: avoid confusing content of SwParaPortion
        
        The problem is that the SwParaPortion is also the first line layout, so
        the string it presents is not the content of the paragraph but of the
        first line.
        
        Just remove it as we have better replacements:
        
        - in case really the whole paragraph is wanted, the (text) content of
          the parent SwTextFrame can be used
        
        - in case in fact the first line is wanted, then the first child
          SwLineLayout still has a portion attribute the provides the unchanged
          substring
        
        Change-Id: Ic4a0f64ecc40e9a74adc79c5205d5d92c882256b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143743
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-06  Eike Rathke  <erack@redhat.com>  [da3dd48eaf9086f8ab28d6a6655f9a638e51433a]

        Resolves: tdf#152381 Treat 0-0-0 invalid date as 0 relative days
        
        Change-Id: I70cf18395e26ababa854299a58f8839f5bdf8e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143748
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-12-06  Jim Raykowski  <raykowj@gmail.com>  [3cb654972ba204efb5dd35a44f95c7d509414400]

        tdf#152029 Visually draw attention to in-view bookmark
        
        when mouse pointer is over bookmark entry in the Navigator content tree
        
        This patch brings attention to in-view bookmarks when the mouse pointer
        is positioned over bookmark content entries in the Navigator content
        tree. All in-view bookmarks are brought to attention by placing the
        mouse pointer over the bookmark content type (category) entry.
        
        The patch adds a parameter to the weld::get_dest_row_at_pos function to
        give the option not to auto scroll. It is needed to prevent auto
        scrolling when used in the the mouse move handler. Additional use can
        be made in the content tree CommandHdl to make the tree not jump when
        the context popup menu is activated for entries near the top and bottom
        of the the visible tree.
        
        Change-Id: I04e306286ca58ab6c8ae7e5c02b25a0592c4a9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143628
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-12-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [968242fe3220bc3df8104c163bc3a17eee5916c1]

        Fix typo
        
        Change-Id: I30f6c0d9a3d373078cffc46a243cdde99e707b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143742
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-12-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [94f51512bef4fecf4121ad79cfd8e3d2aa9ecca9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 490d42493e8dbec31ad58978df5084b080a36fcb
          - Fix typo
            
            Change-Id: Ie6f0171043ce7f0efc3db60e1b9aab7f4c3a75c2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143716
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-06  Caolán McNamara  <caolanm@redhat.com>  [54f74923644c427f5d5c1aaf307be866d1991816]

        weld InformationDialog info dialog
        
        Change-Id: I6a3631fe06a1b46164f01d706ecefd7252509382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  Caolán McNamara  <caolanm@redhat.com>  [1710de70aa6d6522e009b7ac00b1fa5dfe4d7705]

        InformationDialog is a misleading name
        
        It's not the Minimizer dialog, it's the document frame that the dialog is
        associated with.
        
        Change-Id: Ifb7de8dc3fa5ffa5180dab17f9b327fe7296dd0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143738
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  Caolán McNamara  <caolanm@redhat.com>  [353ede41b97729a98ac090f89889a055051db98c]

        add Assistant::set_page_side_image
        
        Change-Id: I70685a74ebed465771473ce885f4f29af209cda6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143737
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  Caolán McNamara  <caolanm@redhat.com>  [a70ad1568ea0fb5b4d7f888fb56fcee130afc433]

        Resolves: tdf#121297 weld Presentation Minimizer
        
        Change-Id: Ifdf1746bc9f6567a1aded233a4350f6828604c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143678
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  Henry Castro  <hcastro@collabora.com>  [8254bd826d6d415e80ef8dcfb39e8b5c67cf2aab]

        sw:qa:  add mailmerge export directly pdf unit test
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I53570149a6e05f05f9ebff7d4931d7f1a02a27f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143490
        Tested-by: Jenkins

2022-12-06  Henry Castro  <hcastro@collabora.com>  [7a6445eedde28675c575f74c09ff236963525d20]

        sfx2: rename FN_PARAM_1 to FN_NOUPDATE
        
        The parameter is intended to not update the fields
        from data source otherwise it will reset to the first
        record.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I204cd20b8eb0b3f26c204e139c72b479c83bbf0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142276
        Tested-by: Jenkins

2022-12-06  Miklos Vajna  <vmiklos@collabora.com>  [fa82e151d80d15eeb6dfae434f1dbb3b68907188]

        sw, .uno:InsertBookmark: add a new BookmarkText parameter and accept HTML there
        
        There was already an UNO command to insert a new bookmark with the
        provided name, in a non-interactive way.
        
        What was missing is to allow specifying the bookmark text, which is to
        some extent not part of the bookmark, but e.g. the bookmark dialog
        allows editing that still.
        
        Add a new BookmarkText parameter to .uno:InsertBookmark, in case it's
        specified then we interpret this as HTML and we create the bookmark on
        the imported content, not simply at the current cursor position.
        
        This is similar to commit 1c2ef850db29beb369dcc89a58fc73416ecd9c5c (sw,
        .uno:TextFormField command: accept HTML in the FieldResult parameter,
        2022-11-16), but that was for the field mode, while this is for the
        bookmark mode of Zotero.
        
        Change-Id: I4928d173e197796d40fdb53f81e84b6bfd77cdc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143736
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-06  Henry Castro  <hcastro@collabora.com>  [2fd5440c9766fa2833a3fc4dcb8a0d57a089121b]

        sfx2: add log information to catch the exception
        
        Add log information for data analysis if the ExportTo
        fails due to an exception.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I888545da14f413a970faf50b3ce60d12966f3f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142239
        Tested-by: Jenkins

2022-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd90f9d0dcf0b6fc71161417deefb501929f67ce]

        crashtesting forum-en-4598.ods
        
        the pattern object may be replaced inside the IsValue() call
        because it might trigger interpreter logic
        
        Change-Id: I99cee16333f3ab0585d94de98946ea77938e14ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9aa52f918f6246c685ac593cb3e7fcfa0e41b2c]

        get-forum-attachment: Add one more mso forum
        
        Change-Id: Ie8549b8f965197f1afeb1886db0bf7f70464377c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143739
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  Caolán McNamara  <caolanm@redhat.com>  [645f8038df617275e65e05bba0b165a1c52ce59b]

        Resolves: tdf#151722 use UI Language for localized font names
        
        instead of system locale
        
        Change-Id: Ie1f33644fcb8529b237db372b7d8daea19af8ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-06  galjit  <qmebic1975@gmail.com>  [b24dfa7ef93bc31ed9ccfb3e3472109bbd384b15]

        Resolves tdf#132398 - New hicolor/macOS icons
        
        - Replaced old with new hicolor icons
        - Added files wherever were gaps
        - Changed non-oasis mimetype files to symlinks
        - Removed "draw.svg" and put "drawing.svg" in scalable
        - Added "macos" directory for special MacOS icons
        
        Change-Id: Id10a386f6144db4f0a1a7a118c44687fffbe0568
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139754
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b14c1066356e76412aac8bb1ee17cf02bfbd182a]

        build installer packages with make parallelism instead of GNU parallel
        
        6204336cc7242ff1b0fdc26ccb7f8dd4f362fb78 added support for building installsets
        in parrallel using the GNU parallel tool, this patch changes that to use make's
        own parallelism, dropping the need for the external tool.
        
        By not creating huge commandline for all packages at once/sequentially, the
        workarounds to modify the PATH variable can also be dropped.
        
        Since : is a special character in makefiles separating a target from
        prerequisites delimiter in the installer-tuples has been changed to the
        hyphenation point.
        
        The dependencies on the install.phony target have been moved to the actual
        installset targets (and those are .PHONY targets as well since the target file
        isn't actually generatead).
        
        Also unify the tuples for the different platforms, even if the first element is
        only used for Windows.
        
        Move the msi templates to a separate directory for the different types, so that
        packaging can also be done in parallel on Windows. Move the setup back to the
        makefile so it can be setup prior to running the script.
        
        Previoulsy the script used grep to remove comments from the msi template files,
        and had to use "|| true" since grep would also return error when not finding a
        match/on empty files. Switch that to awk so it can run without that workaround.
        
        Change-Id: I2f8b73e04d0f601cb0b4e2d8352a38ef9957bc17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143679
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-06  Mike Kaganski  <mike.kaganski@collabora.com>  [834f49b7e30ec9cc9bd050079b23995ad514b40c]

        tdf#150940: Store frame reference in the panel
        
        It is needed to properly dispatch the commands in case of embedded
        objects, otherwise they are dispatched to the top-level frame.
        
        Change-Id: Ia5fadf7c35bded75f1ca20a682dc6c9f14548990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0066326f76e734e7b9a0f344afcadb40ef9ed64]

        tdf#152058 THEMES: Not possible to change back to default look
        
        Revert "dont keep writing to config when persona is set to 'no'"
        This reverts commit e0c424ba729e4659ce1007254adbbceafbeaef5b.
        
        Change-Id: Ia2724c075c7a5fc8deaaedc5cd4356f93b9a6f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-06  Tor Lillqvist  <tml@collabora.com>  [27746ff5d5dfeef6192743d19659537b574b25ca]

        Need --disable-gen for the Qt5-based WASM LibreOffice now
        
        Otherwise we get the slightly mysterious "Can't select gen VCL plugin,
        if --without-x is used!" error from configure.ac.
        
        Change-Id: I3ffda8f7306ff48a619052df25186f0989370d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143707
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [a8b21abb09ab514206dc564f7b63016e5b6fac0b]

        Move cppu::BaseMutex up to the base class OPropertySet
        
        Change-Id: I0e51987714e32ece19609c7a6d500995e6fc3601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143674
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da08e55175c2f12c742b1fd9b249b11c7f6b56e9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2201e80bead1e137a96775b2b6081752caeed77f
          - Fix grammar
            
            Change-Id: Idae562b619b8cacde07eeae62d995782f5c2b7ed
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143590
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ce64398653a896c8a48dd6cabe2b75d9c025873d]

        tdf#53023 - Remove last empty paragraph from auto text
        
        Remove the last empty paragraph before inserting an auto text.
        The carriage return at the end of it is appended in
        SwXMLTextBlockParContext::~SwXMLTextBlockParContext()
        which can't be removed without introducing side effects.
        
        In order to compensate for the change, a paragraph has been
        added to the existing only text auto texts.
        
        Change-Id: Ie098f23d7bdc70798197e5714e041c8fd79f0439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143353
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-12-06  Andras Timar  <andras.timar@collabora.com>  [71e96374f0111360ed7da1df0f3323b09d920381]

        Disallow linking files as Writer sections in Online
        
        Change-Id: I9e4971c72db44ca8216ac468240dd52d46e0b680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143225
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143672
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [80ef2a46f4ac2ac6f3b14561a195262156fe4b85]

        tdf#152134 Customize: assign user macro to menu hangs
        
        regression from
            commit d4257daba1155ebccbfebea99bad0e4152ca9b08
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Dec 24 20:58:28 2021 +0200
            use comphelper::WeakComponentImplHelper in MenuBarManager
        
        We should not hold the mutex while firing events, since the mutex is now
        non-recursive.
        
        Change-Id: I6ee45df0bf27df3ca1fd31857285ceb820161d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-06  Mike Kaganski  <mike.kaganski@collabora.com>  [76141ec7db4c26a112f0e9815d333cd70e1c4258]

        Simplify a bit
        
        Change-Id: Ieeb7f66e224283ac41b98cc184207a4da6d231ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143688
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-06  Miklos Vajna  <vmiklos@collabora.com>  [136cff8909576bc7f50c4e91fb3916218fbb4f83]

        Update libxmlsec to 1.2.37
        
        Fixes two regressions, see <https://github.com/lsh123/xmlsec/discussions/452>.
        
        Change-Id: I81317d81e61d1a0d113ebf46d7813b2db7e0aea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143684
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8035df9dae15cea92ea105135fe86e87467f8ed9]

        tdf#151847 Some chart UNO objects were not advertising their types property
        
        which means that accessin them from python and trying to use the
        XPropertySet and related interfaces doesn't work nicely
        
        Change-Id: I873f6a6fcb048e7f8244313cd737c04b003259a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143675
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-06  Mike Kaganski  <mike.kaganski@collabora.com>  [b15eb164a8e44c02c196cef9f3de5e5478eb78de]

        tdf#152380: add checks for names and values sequences length equality
        
        Change-Id: Ibeef551126874bcfffb4e7736588e2e1873f5768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143681
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-06  Khaled Hosny  <khaled@aliftype.com>  [d3f9b3029a1b5f6b389978509fdf8de7e128a4b3]

        Shuffle code around
        
        Change-Id: I3b3a88c91634fb19a39d21cdd0095d34badea1e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143687
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-06  Khaled Hosny  <khaled@aliftype.com>  [1d5a02d12eacadb708c18e70db747e80ab8817a9]

        Simplify PhysicalFontFace::CreateFontSubset() a bit
        
        Hide the logic inside fontsubset and don’t leak it to the caller.
        
        Change-Id: Ibc845e0051eaeb64e8de42f80d4d404fd6a3880e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143686
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-06  Khaled Hosny  <khaled@aliftype.com>  [7415ce2b9795a78f836bc5e5bffb4b56eee26b21]

        tdf#113048: Fix PDF ascender and descender of some fonts
        
        Use the same ascender and descender calculation for fonts with CFF
        table as fonts without CFF table.
        
        This also provides a better fix for tdf#138325 and tdf#151039.
        
        Change-Id: I416a123199e94401fa557fce95013eb8b0590e33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143683
        Tested-by: خالد حسني <khaled@aliftype.com>
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-06  Kevin Suo  <suokunlong@126.com>  [c9e961e6803a70587bd4686d05abdd4ac11de434]

        "using namespace com::sun::star" -> css in header file
        
        See Stephan Bergmann's comment the following change (thanks!):
        https://gerrit.libreoffice.org/c/core/+/143598
        
        Change-Id: I409b823439979c64cadcb582d8fb4dec4ff412b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143664
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2022-12-05  Stephan Bergmann  <sbergman@redhat.com>  [c08e5db055c9d34d3f0b0b9d2a192d7ebdcd9576]

        Make check for complete type more explicit
        
        When 485c9d4f0e59e13e772da8f8a7975f0ddd77c33e "Clarify the use of
        untools::WeakReference" introduced cppu::detail::isUnoInterfaceType and its use
        in the requires-clause of unotools::WeakReference::get, its commit message
        argued that while isUnoInterfaceType only works if the given type is complete,
        that would already be taken care of via the use of std::is_convertible_v in the
        implementation of unotools::WeakReference::get.  But while std::is_convertible_v
        nominally requires its argument types to be complete (unless they are void, or
        arrays of unknown bound), typical implementations like recent libc++ or
        libstdc++ do not seem to enforce that (and just return false in such a case).
        
        So better make isUnoInterfaceType explicitly require that the given type is
        complete.  Which turned up one case where it isn't at the point where
        unotools::WeakReference<SdrTextObj>::get is called.  (And while the resulting
        call to dynamic_cast<SdrTextObj*>(...) in the implementation of that function
        would cause an error when SdrTextObj is not complete, compilers happened to
        instantiate that template specialization only at the end of the TU, by which
        time SdrTextObj happened to be a complete type in the TUs including that
        sd/source/ui/inc/futext.hxx.  So all happened to work out OK.)
        
        Change-Id: I704b8b437fa836e290245d1727e4d356128ef63c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143667
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-05  Khaled Hosny  <khaled@aliftype.com>  [05b7e6039da5fda18205798d00e335b2c8126872]

        Drop dummy function
        
        Type 1 support is long and this was always dead code anyway.
        
        Change-Id: Ia00626e7d44419af333feb59d4dc52e624ffd263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143682
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-05  Caolán McNamara  <caolanm@redhat.com>  [db7f8b960ef44726b8a468eeaa9edd2eba4e6544]

        cid#1517256 Dereference null return value
        
        Change-Id: I20bcd522526d5da3dcb9f24f7ae07ad6f9465459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143677
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-05  Justin Luth  <justin.luth@collabora.com>  [fd14dd0e4c6a7ea0866a686f653db90301d664b6]

        NFC cleanup docxattributeoutput: use existing function to clear
        
        The function already clears these things,
        so use it - which should also prevent bugs
        where a clear is put in one place and not the other.
        
        A dead giveaway was that m_bHasId = false
        is also done in the function.
        
        Change-Id: Ibb97b8da246404841afa5a03d11514dbcc7157b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143604
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-05  Stephan Bergmann  <sbergman@redhat.com>  [9d93e57613fc5e9f67400a166dcce5344c238348]

        Make sure bHasShadow has a value
        
        Change-Id: Ic955e31619799918f26d6db2d6e688decfbce6c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143676
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-05  László Németh  <nemeth@numbertext.org>  [fe5cca63c2a15dfc49cd251a6be4ab3925ab1dab]

        LibreLogo: fix SVG export of font features and text portions
        
        Text portions of rotated text was exported with bad positions.
        
        Text using font features was exported with non-portable font
        names with colon, working only in LibreOffice correctly.
        
        Fix these by converting the text to curve during the SVG export.
        
        Change-Id: I3707aaa4143f583b988bbbe37b5eb741530cccba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143668
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  László Németh  <nemeth@numbertext.org>  [37d8678d7266fd517953d3db39e30ff8775ade7f]

        LibreLogo: fix parsing argument of default Logo commands
        
        Functions didn't work in arguments of several default
        Logo commands (mostly turtle moving and setting).
        A simple example, which resulted an error message:
        
        FORWARD RANDOM 100
        
        Regression from commit 740b99783b5480fcd1e5fce7c1beb5967d015041
        "tdf#120413 LibreLogo: handle complex Logo expressions".
        
        Change-Id: Icb4aece1a5b0343384ce179c27f170eef7d8938c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143642
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  László Németh  <nemeth@numbertext.org>  [81ce66ab5d77b0171245e05ed609f2305ce89600]

        tdf#105575 LibreLogo: hide turtle during locking
        
        It seems painting of the selection around
        the turtle is not locked completely, so
        hide the turtle to lock that, too, for 20%
        or more speed up.
        
        Note: the turtle is still visible, because it is
        hidden after locking (until unlocking), but there
        is no nore jiggering selection around it.
        
        Change-Id: If6720f1e5b553b47b1b0352a5b9e70c73975c373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143641
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  László Németh  <nemeth@numbertext.org>  [e50f0f7342c5618196507771e5f4eb79147477b9]

        tdf#105575 LibreLogo: speed up by lock (re)paint
        
        Speed up program execution by default partial
        locking of repaint and custom locking of paint,
        using UNO lockControllers().
        
        – Default: speed up LABEL and TEXT by locking their repaint
          during the various text operations, i.e. setting size and
          text portion formatting changes were visible, and slow.
          Locking while manipulating a shape was suggested by Noel Grandin.
        
        – Custom: SLEEP command with negative argument calls lockControllers(),
          SLEEP command with not negative argument (and program termination)
          call unlockControllers(), so it's possible to lock program parts to
          speed up program execution e.g. 3-4 times or more. For example:
        
          ; lock paint until program termination
          SLEEP -1
          program
        
          or
        
          ; lock until SLEEP 0
          SLEEP -1
          commands_without_paint
          SLEEP 0 ; unlock a single level and paint/repaint everything
        
        – Add __get_time__() command to get the elapsed time from
          program start for profiling.
        
        Add unit tests.
        
        Note: custom locking with SLEEP has known problems: not connected
        lines, bad position of arc/pie, non-working CLEARSCREEN.
        
        Note: The reported code is more than 32 times faster (4 sec vs 2.2 min)
        with custom locking, also using the commented line to show not only
        the result with 400 circle shapes, but the partial result with 100,
        200 and 300 shapes, too:
        
        SLEEP -1
        REPEAT 400 [ CIRCLE 10 + REPCOUNT/10 FORWARD 5 + REPCOUNT/10 LEFT 10 ]
        ; IF REPCOUNT % 100 == 0 [ SLEEP 0 SLEEP -1 ] ; to show partial result
        SLEEP 0
        PRINT __get_time__()
        
        Change-Id: I51f71b0143178e6d35ecced92a59525184392d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143640
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  László Németh  <nemeth@numbertext.org>  [43570f5752b31e11a7f21d5e694737e9fcb3bf19]

        LibreLogo: LABEL/TEXT: add more character formatting
        
        – strike out: <s> or <del>
        
        – superscript and subscript: <sup> and <sub> (using character formatting)
        
        – text color:
        
          – localized names, e.g. <red> (in English documents), <rouge> (in French documents)
        
          – hexa or decimal codes: <FONTCOLOR 0x000000>, <FONTCOLOR 0> (localized "FONTCOLOR" is allowed)
        
          – verbose form of the localized names: <FONTCOLOR RED>
        
        – highlight color: <FILLCOLOR RED>, <FILLCOLOR 0xFF0000>, <FILLCOLOR 0> (localized "FILLCOLOR" is allowed)
        
        – font name: e.g. <FONTFAMILY Linux Libertine G> (localized "FONTFAMILY" is allowed)
        
        – font size: e.g. <FONTSIZE 12> (localized "FONTSIZE" is allowed)
        
        – OpenType and Linux Libertine G/Biolinum G font features: <smcp>: small capitals,
          <pnum>: proportional numbers, <sups: true superior, <sinf>: true subscript (scientific inferior) etc.,
        
           – with arguments: <pnum=1>
        
           – verbose form: <FONTFEATURE pnum=1>
        
        Alternative names for bold and italic character formatting
        
        – bold text: HTML: <b> or <strong>; localized LibreLogo: e.g. <bold>, <lihavointi> (in Finnish documents)
        
        – italic: HTML: <i> or <em>; localized LibreLogo: e.g. <italic>, <kurzíva> (in Czech documents)
        
        Add unit tests for the previous and new tags.
        
        Follow-up to commit 89c34706331984d12af8ce99444d53f19b40b496
        "LibreLogo: add basic HTML formatting support to LABEL".
        
        Change-Id: Ie14024cae62ec09de714af5db46132375b6101d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143639
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  Szymon Kłos  <szymon.klos@collabora.com>  [eb5879f190a773a28148de8eaa6e4afa2f375eda]

        jsdialog: sort enabled .ui list
        
        and exclude form clang format to not break that
        
        Change-Id: I85a7843d564c6d2ff7397870c36c3ad0c0767eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143557
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-12-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [df092b591a7d107263f3fad817404f92b3cd7c03]

        create compile_commands.json in builddir
        
        assuming that nothing breaks for existing users of the
        compile_commands.json file, since they assume BUILDDIR=SRCDIR, so
        nothing will change in those cases.
        
        For building in a different directory than the source, the
        compile_commands.json file is the only thing that regularly clobbers my
        otherwise pristine SRCROOT
        
        Change-Id: I344afa0bc7bb3eaa1eb888cd3558d3602090af5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143571
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [59d868b9eddebb19b0c40d7c1ca70265fc9df137]

        gb_LinkTarget_use_clang: only use flto=thin with clang, not with gcc
        
        The code always used flto=thin, but gcc doesn't know that switch and
        fails. The gb_Library_use_clang used by Skia is actually a prefer clang
        option, and the corresponding gb_LinkTarget_use_clang macro accounts for
        that by using "$(or clangvalue,gccvalue)" to define variables.
        
        This is OK for stuff that defaults to empty value when no clang is found
        on the system, but gb_CLANG_LTOFLAGS is defined unconditionally (in
        com_GCC_defs.mk), so using the $(or..) function is completly bypassed,
        always using the flto=thin switch.
        
        Change-Id: I903e5e4818b8ecbe63ed85952b8741140972e8d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143572
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-12-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [042bf6f00c5e01b44ec1d95371ad809db4c5269f]

        Revert: "split sw_filters unit test"
        
        This commit reverts 1c2ea35b983c1159fe4633e449f8302ac9a7a024
        
        it shouldn't be needed anymore after
        cdac145768488dc11b32b744bc753ab16aa08c6e "reduce cost of
        SwpHints::Check"
        
        Change-Id: I32a1d963f7bf90838c68db3bfefc8c8750e94128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143417
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-05  Tünde Tóth  <toth.tunde@nisz.hu>  [57db9a4fdbee6db24b381f3ea48b3df089c555fc]

        tdf#126477 DOCX export: fix lost charts in embedded documents
        
        The charts of the embedded documents were not exported.
        
        Follow-up to commit a41cf57c1eb4cabe5afc1a45d6fe535dbb935217
        "tdf#134987 convert DOCX to ODT: fix lost charts".
        
        Change-Id: I20f1cdfa68687043d0822c4bbf59793a208e83d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143495
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  Tibor Nagy  <nagy.tibor2@nisz.hu>  [400e44cebd993f4b9b3d878fb9264f99e005c9fb]

        tdf#152211 PPTX import: fix connector position based on line width
        
        Thick shape line changed the connector, e.g. direction of
        its arrow head.
        
        Follow-up to commit d8c89fb920af747ec51ce966b5d7b65e9340afbd
        "tdf#151891 PPTX import: fix regression of connector position"
        
        Regression from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8
        "tdf#89449 PPTX import: fix line connectors".
        
        Change-Id: I99d22409ec65e10609b1e371cc4d301fd73c7c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143467
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-12-05  Rafael Lima  <rafael.palma.lima@gmail.com>  [12732eb7c34baa3f846ec6d0c10f8987051ace34]

        tdf#148505 Fix COL_AUTO in embedded Math formulas
        
        Change-Id: I8be0289100cbd0921bcb05ffec186155abba8743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143575
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-05  Rafael Lima  <rafael.palma.lima@gmail.com>  [affd2a9511fc0af7cad7e9679c17607540065d7e]

        tdf#86568 Move the scrollbar to the EditWindow in Basic IDE
        
        Currently, the Basic IDE has a shared horizontal scrollbar used both for the code editor window and the dialog editor window.
        
        However, the problem is that this causes the horizontal scrollbar to be placed at an unintuitive place when the code editor is being used. To avoid this problem the code editor already has its own vertical scrollbar.
        
        This patch creates a separate horizontal scrollbar for the code editor window and places it underneath the editor window to make it clearer what this scrollbar is meant to scroll.
        
        Change-Id: Ib873c004db902f0f729fd512c51effd8f5e38a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143580
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-12-05  Caolán McNamara  <caolanm@redhat.com>  [83596187cdf75f29472bd800dc4e16df3f185299]

        ofz#53680 drop workarounds
        
        and add original test-cases which nowadays function without workaround.
        
        Change-Id: Ie2366737f9eb82774260b2a57bbf177f2712f485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-05  Khaled Hosny  <khaled@aliftype.com>  [50329087b9a46e5dade8f924abf68cbd982be494]

        Improve the layout of font features dialog
        
        Make sure all sections have the same column alignments.
        
        Change-Id: I25bdc0ecf8f971f23d188999167df33476bea1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143662
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-05  Khaled Hosny  <khaled@aliftype.com>  [6d6a2343b1d45695f3ea02818d317a022a7b259f]

        tdf#152376: Remove Kacst Book and Kacst Office fonts
        
        Change-Id: I979e01ee6cab26431a6e54094c59ea28e886019a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143647
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-05  Bogdan B  <buzea.bogdan@libreoffice.org>  [476ad3e5a8d4a8545043ffd7c8e16ead6ba1966b]

        tdf#136077 Change OS context menu for new file
        
        Right click on Windows for a new file is 'OpenDocument Text'.
        With this change would be 'LibreOffice Writer Document', and similar changes for each module.
        Change-Id: I34634d1f1d26c6a8c2146d03a2ecba357b58e4d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143637
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-05  Khaled Hosny  <khaled@aliftype.com>  [3f9a8a3b7656470cfcf04c18a46a7b7bbeca8950]

        Mark ssXX and cvXX off by default in font features dialog
        
        We know they are off by default.
        
        Change-Id: I77c8ecb0d65d46ec77ccc2570ecf5c05e6e577e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143660
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-05  Miklos Vajna  <vmiklos@collabora.com>  [fd4f5c46a58adf136d86d6e9544c06e229161584]

        sw: prefix members of SwFootNotePage, SwFormatTablePage, ...
        
        ... SwOutlineTabDialog and SwTextFlowPage
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie863c244d0fa5b885e1be1949f997410e27f80d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143661
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-12-05  Maxim Monastirsky  <momonasmon@gmail.com>  [86c50d7d7de2e5c4be5f7c6931d87d1b17bcaf82]

        sd: Don't replace table styles on page pasting
        
        i.e. insert a table, and set its style to anything except
        default. Then right click on the page in the page pane =>
        Copy. Right click again => Paste. The table on the first
        page will reset to the default table style.
        
        The problem is in SdStyleSheetPool::CopyTableStyles which
        attempts to replace existing styles with the pasted ones,
        causing the old ones to be destroyed. But in fact there's
        absolutely no case where we want to do anything like this.
        All we want is to keep the formatting of the pasted page,
        not to change existing styles which might be used in the
        rest of the document. (And if the pasted style has indeed
        a different formatting, it can be inserted under a
        different name. To be handled in a follow-up commit.)
        
        Change-Id: I7caaffc72265bb045bf21c831f2da27012e41845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143644
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-05  Maxim Monastirsky  <momonasmon@gmail.com>  [1c3dc6cdc53a2463af12688918d222d44039a96c]

        Simplify SdStyleSheetPool::CopyTableStyles a bit
        
        Change-Id: Ib8bbc8f71b310c1b968f36a94e99cce6019dd6cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143643
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-05  Khaled Hosny  <khaled@aliftype.com>  [05eb5e487455dfaa0947c704c2ae06544d1f9253]

        tdf#136604: Remove Source Serif Pro and Source Code Pro fonts
        
        Kept Source Sans Pro for now because it is used in some styles and using
        also weights that not supported by other fonts we bundle (e.g. light).
        
        Change-Id: I2eb9c6a2951e0c39e7021a5c90ed549d03f4a4e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143645
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [6ddbc0b67a75ff7e0267649cef61fd0af7085884]

        cid#1517258 Dereference null return value
        
        Change-Id: Id8318fa1ae327f53fab61c2d3f5a73fa084771bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [3d22f241708fc0bb97faf7cb45ee0b338c93fd52]

        cid#1517253 Dereference null return value
        
        Change-Id: I222dd5c220de7f0775aa2966bc36c73952605ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143633
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [836e001c8632702c2eda7b5bac799ef5f1a24cdf]

        cid#1517255 Dereference null return value
        
        Change-Id: Idb1a7790851a3416f84e99c7fd95e12e18b449f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143632
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Kevin Suo  <suokunlong@126.com>  [616c4c6bcb5ddeb932cf1e154f0a1a79c6a8bd45]

        tdf#152083: sdext Pre-reverse the text for RTL in Writer pdfimport as well
        
        Follow up to:
        commit 3a2f0e4772e7b4646dd518b33aeafb6fd7025179
        Author: Kevin Suo
        Date:   Sun Nov 20 00:10:14 2022 +0800
            Resolves tdf#152083: Ligatures are incorrectly reversed in Draw pdf import
        
        The unit test is adjusted accordingly to reflect this change.
        
        Change-Id: I051a76ed38f76ff92197e1dc87cbfa7151b8ac35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143606
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [b51ad42a3baa2af580cebe8b11be6f2b347830ba]

        cid#708627 Uninitialized scalar field
        
        since:
        
        commit 19e3bab1a8def52d9a60f67bd87697e828e37773
        Date:   Thu Nov 24 15:19:17 2022 +0100
        
            tdf#77650 Add option to place comments in margin (PDF Export)
        
        Change-Id: Ifcdd6caca199cada83c653d835ebce8964a77354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [60dbf73c1f42f09d52dc8ef9fcf7d902cf2b1dd4]

        ofz#53842 Timeout
        
        Change-Id: I24e5bf30c93bfe2ebb27c2b01232dbc8a42964a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Kevin Suo  <suokunlong@126.com>  [00bf67a99dcdb1549401f0b656e872e5c9762dc5]

        tdf#147246 sdext: font name returned by font descriptor may be...
        
        ... e.g. "NotoSerifCJKjp-Regular-VKana".
        
        Change-Id: I9818579c7678b0dad5ec2d2217ae59d573de88b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143609
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-04  Kevin Suo  <suokunlong@126.com>  [842e3b988aca27d7c9f71ce1efc6653271cc3430]

        tdf#152083 related: make the isComplex check block as a separate function
        
        This is used to check whether a TextElement is rtl. We will need this
        in WriterXmlOptimizer::optimizeTextElements() as well, in a separate commit.
        
        Change-Id: Iee2ff5990450421153bb7c5afe9526c555f2d0ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-04  Martin Srebotnjak  <miles@filmsi.net>  [23abfa53368b1fdad054db0c902a645b411ee736]

        Update git submodules
        
        * Update translations from branch 'master'
          to 935a5546788045d700b9b1b8ce2eed833e25699c
          - Updated Slovenian translation
            
            Change-Id: I4ce7e14713be2452dea2e2ace5047ee0a5c917fe
            
2022-12-04  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [4e81e3b6c0acad2f3e59564184f8bf70d166557d]

        rtl bootsratp : use enum class
        
        Change-Id: Iea433a2a7be9b62f04b57883dbefaf25586f21d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-04  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [d64aed0b44f3070b4a7ec2fecd6ea80a0b8c4bc8]

        osl : remove useless includes
        
        Change-Id: Ic350a924d3e5b58e8f1a60621edc701553d8cbab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-04  Andras Timar  <andras.timar@collabora.com>  [17caf28907ae14ecd84f270cf11e984f5bc553c1]

        it is not possible to install color palette extensions in Online or mobile apps
        
        Change-Id: Ibb2e9bfcf4b8e8681f96e6863fd900181c278adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143309
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit d3f3be20599e66d4d6eacc0fa73b5ab3fa6c2dee)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143581
        Tested-by: Jenkins

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [adcedbea71024470783406a187516be4b7bfb4d6]

        Resolves: tdf#152196 visible gaps with glyph fallback in Arabic/Persian text
        
        Change-Id: I0bf5a10940782f4507e7d632ec37bc4eaa710b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143624
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [9935fdbcb45ef021c4a25aaced19bcefce5301d7]

        Related: tdf#152196 adjustLinearPosX takes a double
        
        Change-Id: I5e32c82b37af3900642199e0af74bf8b48218c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143623
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Caolán McNamara  <caolanm@redhat.com>  [815fd0084aaa6b8c536a13a415cb8cdaf6124ba7]

        Related: tdf#152196 adjustLinearPosX takes a double
        
        Change-Id: I9566904b03b3856dc4092c5d1c15beb35ba7c840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143622
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [382520b436f66ffde850bc215e8d04fe1d93e80e]

        Some define-to-OUStringLiteral conversion in sw
        
        Change-Id: Ib2b0b0b9774b3804db50b4af164c4fcf10b48d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143629
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-12-04  Khaled Hosny  <khaled@aliftype.com>  [b997eb78c392c1e9c89c24644cf86d4bca041d54]

        Use better variable names
        
        Change-Id: I99462a1f598affca1fe69908d3091af5fa219829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143618
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-04  Khaled Hosny  <khaled@aliftype.com>  [fcba85d2ebb54692e0730610026b9b51feb67716]

        Check for trailing numeric part in isCharacterVariant/isStylisticSet
        
        We want to mach features like “ss01” but not, say, “ssty”.
        
        Change-Id: Idc4fdf78c577afe66cf76d7f722dc2009863654e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143614
        Tested-by: خالد حسني <khaled@aliftype.com>
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-04  Khaled Hosny  <khaled@aliftype.com>  [b6e338fe746028f82c973987eaf04280715110e4]

        Add and use Feature::isCharacterVariant/isStylisticSet
        
        Change-Id: Ifd772da1f4b81aa08440025a5c960fb226281194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143613
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-04  Khaled Hosny  <khaled@aliftype.com>  [df57f192c03b38b834a8283b80fc9cd9610b1583]

        Seperate Stylistic Sets and Character Variants in Font Features Dialog
        
        Makes clear what these features are when we use feature names provided
        by the font.
        
        Change-Id: I98a7294d3e1e7fef5293d0444c0fbbfcc131ed44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143611
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-04  Khaled Hosny  <khaled@aliftype.com>  [402d331a0e75a340a3b01cf12b5a61a3266c50fe]

        more_fonts: Update Amiri to version 1.000
        
        Change-Id: I98961ed79cdf98449048e8d83e17e97222e71660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143620
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: خالد حسني <khaled@aliftype.com>

2022-12-03  Caolán McNamara  <caolanm@redhat.com>  [c50cf1883af26daebdfc9d796ced3c20c222f43b]

        Related: tdf#152196 these should be at least DeviceCoordinate
        
        Change-Id: I50404aaf522d5361fb2110258020564cb888f44d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143621
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [3a9f7d5aa91f2eb5756727639aae2ac84cafe018]

        tdf#132650 Improve applause.wav sound
        
        Change-Id: Id362378ccb179db7f9ce54bcc6769ad9fd816c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143450
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-12-03  Khaled Hosny  <khaled@aliftype.com>  [477d87009155630b85b88aa5d997d237e5daeb01]

        Save with newer glade
        
        Change-Id: I23ba9ed200c1336f35f470e2709b153daa0b0aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143610
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-03  Kevin Suo  <suokunlong@126.com>  [d423e18de7c48df359d2d2d1b5b8f5cceac4d96a]

        tdf#147246 sdext.pdfimport: "font-family-asia" -> "font-family-asian"
        
        This was a typo which causes the asian font in pdf (e.g. Chinese)
        always shown as the system default font on pdfimport.
        
        Change-Id: Ic118f8585fb40dfc4bc5bc12651da95bc7961ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-03  Caolán McNamara  <caolanm@redhat.com>  [bbe530a238e68d7338c51532f0f7991ccae8ba17]

        ofz#53868 Integer-overflow
        
        Change-Id: I5d6da712d5db9e0b8b19fca2101626a2a7e2907e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-03  Julien Nabet  <serval2412@yahoo.fr>  [4bd0292094a5fae34dce4b37bb629cb1be6195cb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a222befecb3808d06b6ae208cff9a055892051e4
          - tdf#131075: LibreLogo Help Incorrect ~ Function Calls
            
            Change-Id: I1244cb1068bd86fad989f5b16554ddd63c923ffd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143577
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [80bc18527404d26c4a0bb6f842cf43c28bf0ce6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e57b9b4bddcca46e96018ab242fee40ed011bd53
          - tdf#152113 Improve Labels - Format page
            
            Change-Id: I7c82ecc95878130e8c8bbad54437f8482ac34b48
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142919
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-12-03  Andras Timar  <andras.timar@collabora.com>  [e28b6a9e672e397259a07862cd42d604990f7a05]

        add license of Thai hyphenation patterns
        
        Change-Id: Ifbe30b6a2643b6724374d2fbc2f5b59f789c1acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143313
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2022-12-03  Stephan Bergmann  <sbergman@redhat.com>  [485c9d4f0e59e13e772da8f8a7975f0ddd77c33e]

        Clarify the use of untools::WeakReference
        
        ...which had been introduced in 78040af9acea0ab681aa54ff23844b647bc9b4f3
        "loplugin:refcounting in sc" as a variation on css::uno::WeakReference from
        include/cppuhelper/weakref.hxx, but without giving much of a rationale.
        
        And, at least for --with-latest-c++ builds using a capable C++20 compiler,
        ensure that the given interface_type is such that the static_cast and
        dynamic_cast in the implementation of unotools::WeakReference::get are actually
        sound:  If interface_type could be a UNO interface type, that would imply that
        the xInterface obtained from the underlying WeakReferenceHelper::get() could be
        a proxy from the C++ UNO bridge, which could (a) be a proxy for only a subtype
        of interface_type (e.g., just for XInterface), so that the static_cast would be
        broken, and (b) be a proxy for which the vtable's RTTI slot is not set up (see
        e.g. the ENABLE_RUNTIME_OPTIMIZATIONS code in
        bridges::cpp_uno::shared::VtableFactory::initializeBlock in
        bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx), so that the dynamic_cast
        could crash.  (These issues can even happen when the given interface_type is a
        C++ implementation class type, but the given object has been bridged over some
        C++ to C++ UNO ("purpose") bridge, but lets leave it at that...)
        
        This required adding some cppu::detail::isUnoInterfaceType predicate to the
        include files generated by cppumaker, which can be useful in other places too.
        (For the call to isUnoInterfaceType in the requires-clause of
        unotools::WeakReference<interface_type>::get to give the correct answer, it is
        important that interface_type is a complete type---i.e., the corresponding
        codemaker-generated .hpp having been included if interface_type actually were a
        UNO include type.  But that is already nicely required by the call to
        std::is_convertible_v in the implementation of that function, anyway.)
        
        Change-Id: Ia5efd70085d2d6d45fa0995d00dc8def564bbe5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143601
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-03  Chenxiong Qi  <qcxhome@gmail.com>  [8f34b0d40e149b7274a1aa4ce0b33ddbf825ee52]

        tdf#143123 Port Text Java examples to Python
        
        The examples inside odk/examples/java/Text are ported to Python:
        
        BookmarkInsertion.java     -> BookmarkInsertion.py
        GraphicsInserter.java      -> GraphicsInserter.py
        HardFormatting.java        -> HardFormatting.py
        StyleCreation.java         -> StyleCreation.py
        SWriter.java               -> SWriter.py
        StyleInitialization.java   -> StyleInitialization.py
        TextDocumentStructure.java -> TextDocumentStructure.py
        TextReplace.java           -> TextReplace.py
        WriterSelector.java        -> WriterSelector.py
        
        Code format is checked with 'pycodestyle':
        
            pycodestyle --ignore=E501,E722 odk/examples/python/Text/*.py
        
        Some Java methods are merged when ported to Python.
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: Ic903cfa24ef32f8edaafd7e6e2e0c757b4b1be0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141425
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-12-03  Khaled Hosny  <khaled@aliftype.com>  [f1eaad31122024034d8e7299780eeb123204b20a]

        vcl: simplify ImplFontMetricData::ImplInitTextLineSizeHarfBuzz() a bit
        
        Change-Id: I844b4fc39784ac093a3339b8912efd236ae152ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143605
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-12-03  Justin Luth  <justin.luth@collabora.com>  [567c9066933b4c02377368e17a3b32f7ab7c5451]

        tdf#151548 ContentControls vba: allow search by name/float
        
        This so-called modern content control is rather terrible for
        VBA programmers. It has no modifiable ID!
        Instead, there is a random _signed-integer_ as a unique id.
        How descriptive...
        
        Since it is an integer, it can't be passed to Item(),
        because then it would be an index lookup.
        Instead, you can pass it as a float (indicated by a #)
        or as a _unsigned-integer_ string.
        
        Recently the ID was preserved for content control import/export,
        so we can now round out our VBA to find content controls by name.
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        Change-Id: I387a287505e17d3768bad5ed954136e532ca70e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143196
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-03  Caolán McNamara  <caolanm@redhat.com>  [8d17ad0bb36b5c330e839fdd7517b37fa72002ae]

        Resolves: tdf#146610 don't reformat MetricSpinButtons if unit didn't change
        
        Change-Id: I58f36b18b456e6d3ccd7482b681e5273ca132499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-02  Caolán McNamara  <caolanm@redhat.com>  [a611f2fc149153aabea8948f74ee004944acf681]

        intended to use floating point for the division
        
        Change-Id: I7922d835e94ea06e519a7ff9fd212dc509e49e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143602
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [8293fc346a7332fe66d78a918659376e494b7778]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d700f1fe9e6e265d0f0125a0fb734fb2c201ce1a
          - tdf#134377 Refactoring built-in file dialogs
            
            Following use cases are covered:
               File - Save A Copy
               File - Export
            
            Change-Id: Id32418e944dc968cbd16100083cb2b9835084fd5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143576
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-12-02  Caolán McNamara  <caolanm@redhat.com>  [8d66d1f270b1f3fdb76d749fa92189d669ea436d]

        Resolves: tdf#152284 pull Shadow and DarkShadow from theme
        
        Change-Id: Idd5031aa2744d5b04f9f656fcab9fe6f21e2ddcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143594
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-12-02  Caolán McNamara  <caolanm@redhat.com>  [f9395a123e8c85134bdd6e471bc93b2745e22a9d]

        tdf#152094 retain more accuracy from RefDevMode::MSO1
        
        do it like this to avoid adding another mapmode and to keep things
        "the same" as much as possible
        
        Change-Id: I1965aa545646f2d27b950d6335b2f608c3e4e04b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143475
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-02  Caolán McNamara  <caolanm@redhat.com>  [1e222575a3b637398b5b2d8e3172f12538ff34e3]

        Related: tdf#152284 use a different macOS DarkShadow
        
        Change-Id: Ibea0f567e4007eda007f8f606cd0bbe5b9c6d0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [47d549c015d53b84b4f98c144c1b49378d027a4d]

        tdf#151842: starmath_import: Add unittest
        
        Change-Id: Iaae4880324872786f956d112a71c4f0870853f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143568
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b093d27b7e6f231512920f20089fcac291b021f]

        crashtesting ooo84576-1.odt
        
        fixes the SEGV crash, but not the massive memory leak
        
        Change-Id: I9d995bb9ba29b2e60386eb61e4a3b05b586c922c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [9939ffb9b87e536b3217232b732218e82126ad6c]

        tdf#151842: Revert "Connect new import / export to starmath"
        
        Will create a unittest in a follow-up commit
        
        This reverts commit 9b7600f547cec9ed1bacca3a1b995b3c33fd5723.
        
        Change-Id: I10b28c3ae15f60da41a16136f3969ed6917d8a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143534
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-02  Stephan Bergmann  <sbergman@redhat.com>  [9c6fa5fc984cbfc1a2aa3ece8411cc61263390e6]

        Replace some uses of static_type with UnoType
        
        (which is what that static_type scaffolding calls internally, anyway)
        
        Change-Id: Ibd8097de0d6a9cd0040c34e5070dafa8db256b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143566
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-02  Caolán McNamara  <caolanm@redhat.com>  [cf551bf23d6527419bc09d8719e5ce7d5e45fb3a]

        cairo_surface_t shouldn't appear in outdev.hxx
        
        Change-Id: I906fb6525e20933f4611b3e2d81bf3524fbaf0a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143544
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-02  rash419  <rashesh.padia@collabora.com>  [c88d891cead135731a18d025698c1213de98b573]

        svx: extended SvxHyperlinkItem to have a new property sReplacementText
        
        this property is use to pass text that needs to be replaced when
        executing uno:SetHyperlink command in online for inserting the mention
        
        Signed-off-by: rash419 <rashesh.padia@collabora.com>
        Change-Id: I48fba347bda0652f7b657524f23c2dd837cd8186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140015
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143556
        Tested-by: Jenkins

2022-12-02  Szymon Kłos  <szymon.klos@collabora.com>  [4affd6a5472c71d9070402d3b84b9b3d2865f9a7]

        jsdialogs: enable row/column dialogs in calc
        
        Change-Id: I920c29b3f5afef8f37224165e6b18335b3dd50d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142974
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143554
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-12-02  Szymon Kłos  <szymon.klos@collabora.com>  [c3919d7ab8bd65ce8f6bed16c9e8058da31cd34f]

        jsdialogs: make Content Control List Item Dialog async
        
        Change-Id: I9801fb1cbcfed6b38a94a567e66f1a3f275454c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143148
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143555
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-12-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [864e4e8c7d1586a86c6268854c513fdce8e2080c]

        loplugin:unusedfields make some fields private
        
        Change-Id: I1dfa1818f607fbc35a17bf13590fae47994df89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-01  Justin Luth  <justin.luth@collabora.com>  [982f9ec1e07364e317fbcd25f1ef06f984cc0ce8]

        tdf#151548 ContentControls: Add Delete()
        
        Needed a function to delete a control,
        so it seemed to make sense to include it here.
        
        [I saw a nice bExact flag, but it doesn't work because
         RES_TXTATTR_CONTENTCONTROLS is outside of a certain
         range. Oh well.]
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        Change-Id: If7da3d4d614d9dfd20f539f651477cbd18d25e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143195
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [224fc966096e9fc52d8e41fbae211e3999edd945]

        loplugin:unusedfields make some fields private
        
        Change-Id: Ia30e3b7f10ae11c7a74e6860ac0a6115caaa439f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e33793d72a0561ebcf19ca22df814bb347813b7]

        loplugin:unusedfields make some fields private
        
        Change-Id: I7eea4baf65c0b49d0edf2516d84914f94c5194d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6aae3f4035f0a2dceba94b1956f5fc0ace3b3ee]

        tdf#145599 Charts gets corrupted when you draw a line inside them
        
        This reverts
            commit 2ed8c34bca56c1a30d727b21d9096cb77e88197a
            use a single global item pool for chart2 draw model
        
        Change-Id: I640a981a2cbbed1cb9e6c0b0c239c78bb481e12e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [88397d5cce34bf24fdb90f60befcc48dd4616187]

        sc: remove unused includes
        
        Change-Id: I1c108815d3f4e2de51edfd799f8c1e710fe7b1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143532
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Justin Luth  <jluth@mail.com>  [64ad923652a11dc68a93f41044df9719c15dec86]

        tdf#151548 ContentControls: improve GetSelectedListItem
        
        Before there was only an option to get the temporarily
        selected list item that had not yet been committed to text.
        
        Add a function that checks whether there is a valid
        selected item, regardless of whether it has been
        written out or not.
        
        Change-Id: I1199bdccd2e665089750eefa5c3a445d56935556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143420
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [d7e80e272a83f960b06521595bd494f2dc84038a]

        drawinglayer: add StructureTagPrimitive to XML dump
        
        Turned out to be unnecessary but why not add it.
        
        Change-Id: I8dac0f0d6ec47f98d540eb4f8c42830cd652f344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143536
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-01  Stephan Bergmann  <sbergman@redhat.com>  [ddf8e2c9c366eb7b8757a589fd7b8e30849d2824]

        Avoid dynamic cross casts to WinSalGraphicsImplBase
        
        Change-Id: I1102c5525f47d3e07cadc602dd55f7b78118a709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143535
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-01  Caolán McNamara  <caolanm@redhat.com>  [5c28d80e766795b9e998f72f60abdfee01d5fe54]

        ofz#53873 Abrt
        
        Change-Id: Iff720fb92f6b385003d328b73e8ebe09da3650f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143531
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [81ef84648515965bf67afaced946227d0f63a71e]

        (related: tdf#135192) svx: PDF/UA export: tag background as Artifact
        
         ISO 14289-1:2014, Clause: 7.1, Test number: 3
         Content shall be marked as Artifact or tagged as real content
        
        This needs to have an effect on ViewObjectContactOfSdrPage etc.
        but let's put it in ViewObjectContact and hope anything that's not
        SdrObject can be tagged as Artifact.
        
        Also VclMetafileProcessor2D::processStructureTagPrimitive2D() has a very
        peculiar habit of ignoring any obvious way to create an Artifact,
        which should perhaps be fixed?
        
        Change-Id: I8d22c36a8e31692d3ee24af692026e02b8faa70a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143502
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [4bfa3edaeea444d46f9470d415667fb8df54c32d]

        tdf#135192 svx: PDF/UA export: table tag primitives only if necessary
        
        Introduce a ViewObjectContactOfTableObj which is able to check that a
        tagged PDF export is in progress.
        
        For the non-PDF case, for performance, fall back to calling
        ViewContact::createViewIndependentPrimitive2DSequence().
        
        Change-Id: I87c86cc862c96868858f9f8617efeeab3846020f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143522
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [0bc96b8805f2cfa2278729a9f3e56a350ddd69ad]

        tdf#135192 drawinglayer,svx: PDF/UA export: also tag TH for SdrTableObj
        
        There isn't really an indication of anything being a header row, but the
        table template application has a flag to apply special formatting to the
        first row, so let's use that as indication that it's a header row
        
        Change-Id: Ic361c84d9a1a4e91109d6f9d2cd626c9633b311f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143500
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [56ff8262d8ace8fd99326e290597cb901654ea11]

        tdf#135192 svx: PDF/UA export: implement tags for SdrTableObj
        
        There seems to be no way to check for isExportTaggedPDF() in
        ViewContactOfTableObj::createViewIndependentPrimitive2DSequence()
        so simply always add the tags.
        
        Change-Id: I816ed1f3811c4efad6ca28366591d135bf823c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143499
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [336602a15d481c4502e66778aec8d37727922152]

        CppunitTest_xmlsecurity_signing2: inherit from UnoApiXmlTest
        
        for some reason, if xmlsecurity/qa/unit/signing/signing2.cxx
        is executed with CppunitTest_xmlsecurity_signing, it makes
        testPreserveMacroTemplateSignature10::TestBody to crash,
        which is weird. Split them in two
        
        Change-Id: If43085dac60f197205d70294ec22ddfc86990784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143527
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Stephan Bergmann  <sbergman@redhat.com>  [4e26dbf214df8a9f76791dd3fc3b52f146e5f12e]

        Use cppuhelper::ImplInheritanceHelper for toolkit VCLX window classes
        
        Change-Id: I102b49608b62b351d6a458b3fd56167b136b24e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143525
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3291a3c0e64fd759184c29848d4323e1384965e]

        sd: check files are loaded without any warning error
        
        Change-Id: I76b4d657ab3c5606b137ab745f789156dfb9af44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143523
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Caolán McNamara  <caolanm@redhat.com>  [2b1d0d7b3d8df805abefdb4b4a80f8f17d6924cc]

        OutputDevice::GetTextArray will always set the size of the vector anyway
        
        Change-Id: I52f24e50455c0d480f8976ee63e442008c05c192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143520
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [4a3964c904388c433066f7d1ab6f457374618182]

        tdf#149221 Handle HID on Database Wizard dialog
        
        This patch sets a help ID (HID) for the Wizard roadmap, so that when the focus is not on any specific page the general dialog help page is called.
        
        To finish this patch I'll create an additional patch in the "help" repo to define the target HID. 
        
        Change-Id: I0fdce25f3b1a92836190e5a03d70a0832e0f1feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140332
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2022-12-01  Caolán McNamara  <caolanm@redhat.com>  [5d4321803007e683968b5622a1685d8aef1e932c]

        we only need aOffsets if maLogicalAdvancements.hasElements() is true
        
        Change-Id: I79a1d406ed4f066e26bd9b2b090ce9b444e66a7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-01  Caolán McNamara  <caolanm@redhat.com>  [c27280c512683a52a19af6448f84f0533655d8fa]

        ofz#53904 Indirect-leak
        
        Change-Id: Idc688c5afc14d2ba83b6af30ee6bb30c90f53ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-01  offtkp  <parisoplop@gmail.com>  [2942fdc8dbda375622d0add8c36df2d6679e321a]

        tdf#144786 Implement XML_hiddenButton functionality
        
        Now hides autofilter button when there's an XML_hiddenButton=true
        or a XML_showButton=false attribute
        
        Change-Id: I911ef23fb5e4feff8c7de0ec154bff871a29f2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143300
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [85fc28d328d7e53e6f263ac6d4ccbbf19d4db3c0]

        sw: check files are loaded without any warning error
        
        Change-Id: Ie48b33a93b7c2201c73418c625b63fdb2f1aec7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143519
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [145dc0c5a00f7ee81cc839c2b506ecbe0f634ea7]

        sc: check files are loaded without any warning error
        
        Change-Id: I9163171d76e684835aff17d4777f8df88c848724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143517
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [29dad1e4545c877bcf8e9bb23359d4eb39251938]

        sc: move test back where it belongs
        
        This test was moved from sc/qa/unit/subsequent_filters_test2.cxx
        to sc/qa/unit/filters-test.cxx in ad40ad91c5400391a0848832e91c596be8fbd811
        "CppunitTest_sc_subsequent_filters_test2: inherit from UnoApiXmlTest".
        As the commit message says:
        
        I couldn't find a way to test testTooManyColsRows,
        move it to sc/qa/unit/filters-test.cxx for the
        time being
        
        The problem is that using loadFromDestkop resets the Error in
        sfx2/source/doc/sfxbasemodel.cxx:2005 - m_pData->m_pObjectShell->ResetError();
        so add a way to log the WarningError in SfxMedium
        
        Change-Id: Ieda9bdc9de856b75d4b162248da41d637305e28d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143506
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-12-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [0d9231f2133def9254e0220b8033a46e5fc17658]

        tdf#152078 Add a Zoom slider to the Basic IDE
        
        This patch adds a ZoomSlider to thee Basic IDE. It has the following characteristics:
        - The Zoom varies from 50% to 400% considering that 100% is the font size defined in Tools - Options - Fonts dialog.
        - All open editor windows use the same Zoom factor
        - The zoom level is saved and restored across sessions
        
        Change-Id: I63df02d0dc828fca4360d61b8aa2c7af6610d4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143159
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-12-01  Caolán McNamara  <caolanm@redhat.com>  [d45d65559f11ecb34b14e3b5c838391c62c8c694]

        Resolves: tdf#152329 Caption preview font is black when using OS dark mode
        
        Change-Id: I2ed9ae77ecb9a5a83d88dce5a2834e6c882cfec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-12-01  Maxim Monastirsky  <momonasmon@gmail.com>  [6d77d826c15807e80ccfff749908332e09c9f6f6]

        sd: sensible naming for created cell styles
        
        Instead of "user1", "user2" etc. now we have
        <table-style-name>-<cell-role> e.g. magenta-dark-first-row,
        which makes them a lot easier to identify.
        
        Change-Id: I2db5e20f5f1d46d14034acb15b0f95c58a3f7611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143514
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-12-01  Daniel Lohmann  <LibreOfficeContribution@dldld.de>  [9db4f60bfc5aa90a9062e429a07889b60ae99e9c]

        tdf#92717 Presenter screen on one monitor
        
        If the presenter screen should be shown as normal window (not a
        full screen window) the presenter screen can also be shown on one
        monitor, as then the presenter screen can be minimized.
        
        This is a follow up to a15bcda0e21be04bec424172192f2416b7f52422
        
        Change-Id: I6fd19aa120a0b0e894b156b4bd10059741f91dc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143355
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-12-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [082f0b250a04e16d608ce67e08e702874f390b15]

        Handle PolyPolygonGraphicPrimitive2D with used DefinitionRange correctly
        
        If the range which defines the bitmap fill is defined and different from
        the range of the defining geometry (e.g. used for FillStyle
        UseSlideBackground) this cannot be expressed in a SvtGraphicFill data
        package. Thus, just use decomposition here directly. See also
        tdf#149754 in drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
        and the comment there for more info.
        
        Change-Id: I8e1b26fb2bf523e6fd7af1040166f8197747e7ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143503
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-12-01  Chris Sherlock  <chris.sherlock79@gmail.com>  [1a5d548b96d86ad7ca04c2b23dc18517a538a998]

        vcl: remove unnecessary includes
        
        Change-Id: I41cb0b38857ddeef7cb7f82c1b523a9c7fcf2413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143324
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-30  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [ce60a3dd4dbff0dcb5b82c9053ae5d90f8ac929d]

        Add LOKit functions and whitelist export for it to WASM
        
        For calling into LOWA from native JS, make lokit functions available
        
        Change-Id: I6458806f33131e48692f35f2a2438b35efb1f06c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143497
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-30  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [baf7b40445f1ef681d9e64a825dd34f7a8117076]

        WASM: need sw/../translatehelper.cxx back
        
        ..since that now contains helper methods like PasteHTMLToPaM
        
        Change-Id: Ib8752e93ca52b17c173d0e18dd727a426fde893e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143483
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-30  Stephan Bergmann  <sbergman@redhat.com>  [0ae1a8cd12187b1b7197782d30d91c6a0d56f608]

        Avoid a dynamic cross cast on macOS
        
        ...now causing
        
        > In file included from vcl/osx/a11ytextattributeswrapper.mm:23:
        > vcl/inc/quartz/salgdi.h:283:22: error: suspicious dynamic cross cast from 'AquaGraphicsBackendBase *' to 'SalGraphicsImpl *' [loplugin:crosscast]
        >             mpImpl = dynamic_cast<SalGraphicsImpl*>(this);
        >                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I0c9a4af0690c195c693f986e02284a48fe753a07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143505
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-30  Caolán McNamara  <caolanm@redhat.com>  [9d7c622a9159ae17eb80bd4f0f9a865bd29deae1]

        Resolves: tdf#152317 macOS Calc highlighted sheet name unreadable
        
        Change-Id: Ib6af275b055dbfdcce615df5de61cb2233b8797c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143509
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-30  Justin Luth  <justin.luth@collabora.com>  [61b5835fc81f1dec9c9e334a9f886f35997d1b56]

        related tdf#152305 writerfilter: avoid comment-related exceptions
        
        a comment anchored in a table sees m_nTableDepth,
        but while in the comment it shouldn't affect
        the table itself.
        
        I did a search for m_nTableDepth and added !m_bIsInComments
        everywhere that looked reasonable.
        
        Change-Id: Iaaaf2f2b5a9f409146111b2e8546573c264e75ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143510
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-30  Michael Stahl  <michael.stahl@allotropia.de>  [a71ce24626caf62680446145384e399fbdf2172c]

        flat-odf-cleanup.py: remove some presentation related styles
        
        Change-Id: I385941f83237464eb02e4e543a67e24f22bddac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143498
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [750393ef151fed5eceb9d482975f4819d449666e]

        tdf#151702 Improve contrast of down arrow of AutoFilter in dark mode
        
        When using dark mode, the down arrow of the Autofilter has a hardcoded black line color.
        
        This patch tests whether the button is dark and uses a lighter color to improve the contrast with the dark background.
        
        Change-Id: I48d99262f8df34f2cc90f39e5aafa5c6cf83e2b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142150
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-30  Julien Nabet  <serval2412@yahoo.fr>  [83485052e6cac574754191c59371dbc41383b810]

        Typo: appropiate->appropriate
        
        Change-Id: Ia088878838b63442295a968c19e303b2a826591c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143504
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-30  Caolán McNamara  <caolanm@redhat.com>  [885092535ce812d08227d46edd2e86387510b3ef]

        Resolves: tdf#152311 inform EditEngine what the bg color is
        
        so it can pick an appropiate color for "auto"
        
        Change-Id: I6dba73a72ccb3106baf4b12ff8052b372e749a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-30  Miklos Vajna  <vmiklos@collabora.com>  [afb362c60a18243621834dcf2b30672be6eed76f]

        sfx2: extend .uno:SetDocumentProperties to update custom doc props
        
        Scripting clients (like the LOK API) had a way to get all custom
        properties where the name matches a certain prefix, but setting such
        properties was not possible.
        
        .uno:SetDocumentProperties can already show a dialog to edit properties
        interactively and had a parameter to set some properties in a
        non-interactive way, but there doesn't seem to be a way to influence
        custom properties there without using the internal API.
        
        Fix the problem by adding a new UpdatedProperties parameter that allows
        removing all old custom properties matching the prefix and adding new
        ones with a single UNO command dispatch.
        
        This is meant to be the write side of the reading commit
        5e8f6dcb8ce00d2d5e35b3cf5654187b3068276c (sw lok,
        .uno:SetDocumentProperties: expose value of custom document properties,
        2022-11-29).
        
        Change-Id: Ib7450d4d21285d9a73758e1c172543521fc07cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143491
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-30  Stephan Bergmann  <sbergman@redhat.com>  [12d8dc31b003f6a4d466d3547ab342b85ac84bf0]

        Add some more failure information
        
        ...which will hopefully give more of a clue than when
        <https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/40847/> recently failed
        JunitTest_starmath_unoapi with just
        
        > checking: [sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent] is iface: [com.sun.star.accessibility.XAccessibleComponent] testcode:
        [...]
        > LOG> Execute: getAccessibleAtPoint()
        > LOG> Checking child with bounds (0,0),(2,18): 41,(Paragraph: 0 ):
        > LOG> 	StateType containsPoint SHOWING: true
        > LOG> finding the point which lies on the component
        > LOG> Child found at point (1,9) - OK
        > LOG> The children found is not the same
        > LOG> Expected:
        > LOG> Description:  Paragraph: 0 sum hat a
        > LOG> Found:
        > LOG> Description:  Paragraph: 0 sum hat a
        > LOG> ... FAILED
        > LOG> No children found at point (-1,-1) - OK
        > Method getAccessibleAtPoint() finished with state FAILED
        > LOG> getAccessibleAtPoint(): COMPLETED.FAILED
        [...]
        > ***** State for sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent ******
        > [sm.SmEditAccessible::com::sun::star::accessibility::XAccessibleComponent::getAccessibleAtPoint()] is testcode: [getAccessibleAtPoint()] - COMPLETED.FAILED
        >
        > Whole interface: COMPLETED.FAILED
        
        Change-Id: I5015e7a9d94bb838c6331ff9e74a6aec858d148a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143496
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-30  Alain Romedenne  <alain.romedenne@libreoffice.org>  [6c804273e9e72f5d0a52ea053b878dac11ec90ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23d4609281bf48afe6b343897900ae0c5b3d3ff7
          - tdf134377 Refactoring a few help pages for 'built-in' file dialogs …
            
            for the following use cases:
            -  File - Open
            -  File - Save As
            -  (Writer) Insert - Text from file
            
            Change-Id: Ib838a88b367abbde13194e8f2f91f471e860de82
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143260
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [925f9a9111eb8c856869e9b2b9eeb220ab21430d]

        CppunitTest_sd_uiimpress: fix asserts
        
        we want to check the number of shapes, not the number
        of pages
        
        Change-Id: If83a9be71bc796ae0cb5fe005780a78428ade9f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143485
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-30  Tor Lillqvist  <tml@collabora.com>  [85b9961c93446e7088d3be97b5977f1deaa16daf]

        Make it possible build for WASM with --disable-gui, without Qt5
        
        The various configury options here are a bit confusing, but this works
        at least for me.
        
        Change-Id: Ic9b04d40414d7d630d5a854295ce23b6e72a724a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143486
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-30  Tor Lillqvist  <tml@collabora.com>  [044e6583eb2e70c5a0c106b47b73d9d8df910689]

        We won't need Executable_osl_process_child for WASM in the foreseeable future
        
        Change-Id: I479b694cd1d02b39ad54deab8ba69b4eec64d7d4
        Signed-off-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143489
        Tested-by: Jenkins

2022-11-30  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [62967366c3b7d8fdf44393af834145a628b18147]

        WASM: conditionalize one more Deepl usage in sw
        
        Change-Id: I7aa6bb5a2bc1f64ed17911d777921fbc8be92ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143484
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2022-11-30  offtkp  <parisoplop@gmail.com>  [8b9e182f90c681d55848f08605470d2bff39078c]

        xlsx: Add test for totalsRowFunction roundtrip
        
        Change-Id: I3b7539a88abbe2f9bab3331d8550c1050c52059a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143137
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-30  offtkp  <parisoplop@gmail.com>  [933e045422957e15cad47ef925d4f9a852c826b1]

        xlsx: Import table column attribute XML_totalsRowFunction
        
        Import table column attribute totalsRowFunction and also export it,
        which fixes a warning when roundtripped on a different office suite.
        
        Change-Id: Icc76fc310aef3bd51bcefebece57f962a56b7cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142843
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-30  Kevin Suo  <suokunlong@126.com>  [e788317bb58f4e4ad3bf57ee7b0e995cb4407ede]

        tdf#104597 related: restore the mirroring of Bidi_Mirrored characters
        
        The method PDFIProcessor::mirrorString() was removed, and
        ::comphelper::string::reverseString was used, by Kevin Suo in commit
        69e9925ded584113e52f84ef0ed7c224079fa061.
        
        The old PDFIProcessor::mirrorString() did two things:
        1) Reverse the code points in the string. However, due to its use of iterateCodePoints(&i)
        rather than iterateCodePoints(&i, -1) (i.e. iterating in forward rather than reversed order),
        the reverse was not functioning at all.
        2) Use GetMirroredChar (i.e. the icu unicode u_charMirror() which was dropped in
        commit 720a093461aadff044ac0b1b7b45cf3d416b3785) to get the mirrored-image of
        characters with the Bidi_Mirrored properties.
        
        Stephan Bergmann restored the #1 in commit 50d73574b6c3d71f9a539c895a15d6fcda22390b
        (by introducing comphelper::string::reverseCodePoints). However, the #2 was not restored.
        
        I do not see a clear reason to drop #2 (at least this is an area I don't quite familiar
        with), so it's better to restore it as well, in *this* commit, named as SubstituteBidiMirrored.
        
        Change-Id: Ic263097938310e6e04f3b95bb12e4f4e834198f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143041
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2022-11-30  Tor Lillqvist  <tml@collabora.com>  [11e72e61b64bcabf5c599bc24e0b2f6b62c91b5c]

        Move Qt5 and scripting options for Emscripten to the distro-configs file
        
        The resulting config_host.mk from running autogen.sh with just
        --with-distro=LibreOfficeWASM32 is identical, so this should be safe.
        
        Change-Id: I68ab81ba4e48c18d135a824c6158d725eb3f94da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143395
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-30  Caolán McNamara  <caolanm@redhat.com>  [bfe18cbb5eebe975bd469bb884b4c86f03fc48c0]

        Related: tdf#152094 experiment with snapping to a subpixel
        
        Change-Id: Ieb4fbd135f618d7e46762b0ac297446308c75755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-30  Caolán McNamara  <caolanm@redhat.com>  [3f6677e9b610acf506e2d2d452f2e9252a1d3803]

        turn cairo_font_options_set_hint_metrics back off again
        
        Change-Id: Ibe6a2682d1fc2eed379cb2d61cd9b3137bf11234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143473
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-30  Caolán McNamara  <caolanm@redhat.com>  [fc7068d648a98619827c2f94374549e3ae2fad65]

        if we --disable-arm-neon then also use the new --disable-arm-a64-neon
        
        alternatively -fno-integrated-as is a suggestion at
        https://gitlab.freedesktop.org/pixman/pixman/-/issues/45
        
        Change-Id: I9b16d235d24f3d0a87507bdd0c6d5d397ac45d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-30  Miklos Vajna  <vmiklos@collabora.com>  [2c149dc9983317bce9116649270c3513adc35514]

        libreofficekit: add a way to invoke getCommandValues()
        
        - add a new button to the toolbar to invoke the getCommandValues() LOK
          API with user-provided command name (and parameters)
        
        - log the result using g_info(), which is visible on the console if
          gtktiledviewer is started with G_MESSAGES_DEBUG=all
        
        - change some labels to tooltip texts that actually show up on mouse
          hover so you can understand what button does what
        
        - tweak the icons, so the question mark icon is the getter and the info
          icon is the setter
        
        Change-Id: If6984d2dde3d669b42aafcc3f58a0ca757ccaaff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143477
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [01a3cc1e55034f7703219d4bbb209de7c37bf07b]

        tdf#133343 collect autostyle prop names
        
        before scanning for autostyles. That way we can collect only the
        property state we are interested in, instead of all properties.
        
        Change-Id: I8da4d61401d904631cbf9dc1828266950fe98421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-30  Justin Luth  <justin.luth@collabora.com>  [79553e784c6d4587814bc2a577d7251c458df8d4]

        tdf#151548 ContentControls: improve Invalidation
        
        This addresses some hack concerns that Miklos raised
        in his review.
        
        Change-Id: Ic6d906e9eb1d23700fb743e179ba87899ce2f4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143412
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-30  Miklos Vajna  <vmiklos@collabora.com>  [5e8f6dcb8ce00d2d5e35b3cf5654187b3068276c]

        sw lok, .uno:SetDocumentProperties: expose value of custom document properties
        
        LOK API clients currently have no knowledge about document properties.
        
        Clients like Zotero that want to store custom properties on documents
        need a way to read and write such properties. This commit focuses on the
        reading side.
        
        Add a getter for .uno:SetDocumentProperties that allows filtering for a
        certain prefix, this way the returned value can contain only the
        relevant information.
        
        Rework doc_getCommandValues() and SwXTextDocument::getCommandValues() a
        bit, so adding new getters require less duplication.
        
        Change-Id: I0c52cd2efcc8b1ea7307763c8252dd1e8ffdea2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143468
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-30  Miklos Vajna  <vmiklos@collabora.com>  [1d9221ebc86f2696a65c12287ea19eea44d680cf]

        tdf#124601 sw: fix misplaced images in table cells
        
        The bugdoc had a table with anchored images which were
        FollowTextFlow=true and WrapThrough=true. This used to still make the
        table cell larger, but instead the images were overlapping due to the
        not increased cell height.
        
        The problem happens since commit
        489eef894e7034873ad262f9dfca554022db1b09 (tdf#124601 sw FollowTextFlow:
        fix vert pos of objects outside the current cell, 2019-10-01), which
        wanted to ignore anchored images in a similar situation.
        
        Fix the problem by making the "ignore image for cell height calculation"
        condition more strict: if we also require wrapping in background, then
        the old bugdoc keeps working but this fixes the new bugdoc.
        
        Also change the font name in lcl_PaintReplacement() to a font that we
        bundle, otherwise the testcase would abort in
        psp::PrintFontManager::Substitute() for a document that doesn't specify
        any font name explicitly.
        
        Change-Id: Ie512aa4ffd368774825c5243ecd6bce7f09e1442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143472
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [dda4867a0b5a2d29d8a01a3656e0c8dac7626d2f]

        tdf#152289: implement external glossary relations roundtrip
        
        Change-Id: I20f4439abfbf73485734fd8373fffb2916d390f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143470
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-30  Eike Rathke  <erack@redhat.com>  [98d8adc5b377039d5dee0d5046ece721010a960c]

        Unnecessary to convert to locale, tdf#67866 follow-up
        
        ScGlobal::GetEditDefaultLanguage() obtains the application
        language tag to return the LanguageType, that was converted
        back to obtain the locale.. just obtain the locale from the
        application language tag.
        
        Change-Id: I0c2028ad6162780b657db39b78f6e9006aaa2660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143469
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [bfe33d42a2381bce194cc6fe15b830902f7c8443]

        tdf#152186 PPTX export: fix shadow of the shape in theme
        
        Placeholder line styles defined extra effectStyle, resulting
        bad export with shadows.
        
        Follow-up to commit 25e9766e9b87342b6f1b29dc146d5f33e12157a7
        (tdf#92222 PPTX export: fix line width of the shape in theme)
        
        Change-Id: I02f1edea84b50dbb9b0e0a59b6062a29894afde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143233
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-29  Stephan Bergmann  <sbergman@redhat.com>  [160689897cd5d46be0b4b1bdf67242d42bb72598]

        New loplugin:crosscast
        
        ...inspired by 2fa426da15a12e2a63554247e3c1c3f8c0ec5c24 "Fix dynamic_cast after
        splitting OutputDevice and vcl::Window class hierarchies":
        
        "Find uses of dynamic_cast that cast between unrelated classes, which is
        suspicious and might indicate a bug.  The heuristic used to consider two classes
        unrelated is that neither derives from the other (directly or indirectly) and
        they do not both virtually derive (directly or indirectly) from a common third
        class.  Additionally, class definitions can be attributed with
        SAL_LOPLUGIN_ANNOTATE("crosscast") (from sal/types.h) to suppress false warnings
        about known-good cases casting from or to such a class."
        (quoting compilerplugins/clang/crosscast.cxx)
        
        This found two additional errors, 7a82ea5c79adee70eddf74ac53347544766a91b0 "Fix
        presumed typo" and fc6aa9e49973c845915754caf765ff57e5b0cd59 "fix assert", and
        one still-open case that looks like an error, see the TODO comment in
        sw/source/core/unocore/unodraw.cxx.
        
        In addition to that it flagged another 102 uses of dynamic_cast as suspicious,
        which have all been addressed, at least for now, by marking certain classes as
        SAL_LOPLUGIN_ANNOTATE("crosscast"), see below.  (Where this commit also adds
        that generic SAL_LOPLUGIN_ANNOTATE mechanism to include/sal/types.h.)  However,
        some of those annotations might benefit from further inspection and clean up
        similar to recent 8858962ec09478c203d43feb58f550bb36af37bb "Introduce
        ParagraphProeprtiesPropertyMap", 8467aa93e2038b3030e1add94e0ca6cc4ad44032
        "Replace a dynamic_cast with UNO_QUERY",
        a534361141d69096d896e6e0552d19f3138eeeb3 "Fold OldBasicPassword into
        basic::SfxScriptLibraryContainer", and 589e03fb4c3b05bf3742c0cb8b366322ffdf1fa9
        "[PATCH] Replace some dynamic_cast with UNO_QUERY".
        
        * canvas/source/cairo/cairo_repainttarget.hxx RepaintTarget:
        > canvas/source/cairo/cairo_cachedbitmap.cxx:62:34: error: suspicious dynamic cross cast from 'com::sun::star::rendering::XCanvas *' to 'RepaintTarget *' [loplugin:crosscast]
        >         RepaintTarget* pTarget = dynamic_cast< RepaintTarget* >(rTargetCanvas.get());
        * canvas/source/cairo/cairo_surfaceprovider.hxx SurfaceProvider:
        > canvas/source/cairo/cairo_canvashelper.cxx:301:45: error: suspicious dynamic cross cast from 'com::sun::star::rendering::XBitmap *' to 'SurfaceProvider *' [loplugin:crosscast]
        >         SurfaceProvider* pSurfaceProvider = dynamic_cast<SurfaceProvider*>( xBitmap.get() );
        * canvas/source/vcl/repainttarget.hxx RepaintTarget:
        > canvas/source/vcl/cachedbitmap.cxx:73:34: error: suspicious dynamic cross cast from 'com::sun::star::rendering::XCanvas *' to 'RepaintTarget *' [loplugin:crosscast]
        >         RepaintTarget* pTarget = dynamic_cast< RepaintTarget* >(rTargetCanvas.get());
        * chart2/inc/ChartModel.hxx ChartModel:
        > chart2/source/controller/dialogs/dlg_ChartType_UNO.cxx:82:31: error: suspicious dynamic cross cast from 'com::sun::star::awt::XWindow *' to 'ChartModel *' [loplugin:crosscast]
        >     ChartModel* pChartModel = dynamic_cast<ChartModel*>(rParent.get());
        * chart2/source/controller/inc/TabPageNotifiable.hxx TabPageNotifiable:
        > chart2/source/controller/dialogs/tp_RangeChooser.cxx:70:28: error: suspicious dynamic cross cast from 'weld::DialogController *' to 'TabPageNotifiable *' [loplugin:crosscast]
        >     , m_pTabPageNotifiable(dynamic_cast<TabPageNotifiable*>(pController))
        > chart2/source/controller/dialogs/tp_DataSource.cxx:171:28: error: suspicious dynamic cross cast from 'weld::DialogController *' to 'TabPageNotifiable *' [loplugin:crosscast]
        >     , m_pTabPageNotifiable(dynamic_cast<TabPageNotifiable*>(pController))
        * include/drawinglayer/primitive2d/svggradientprimitive2d.hxx SvgGradientHelper:
        > drawinglayer/source/primitive2d/svggradientprimitive2d.cxx:582:59: error: suspicious dynamic cross cast from 'const BasePrimitive2D *' to 'const SvgGradientHelper *' [loplugin:crosscast]
        >             const SvgGradientHelper* pSvgGradientHelper = dynamic_cast< const SvgGradientHelper* >(&rPrimitive);
        > drawinglayer/source/primitive2d/svggradientprimitive2d.cxx:819:59: error: suspicious dynamic cross cast from 'const BasePrimitive2D *' to 'const SvgGradientHelper *' [loplugin:crosscast]
        >             const SvgGradientHelper* pSvgGradientHelper = dynamic_cast< const SvgGradientHelper* >(&rPrimitive);
        * include/editeng/unotext.hxx SvxUnoTextRangeBase:
        > writerfilter/source/dmapper/DomainMapper_Impl.cxx:7645:62: error: suspicious dynamic cross cast from 'com::sun::star::text::XTextCursor *' to 'SvxUnoTextRangeBase *' [loplugin:crosscast]
        >                             SvxUnoTextRangeBase* pDrawText = dynamic_cast<SvxUnoTextRangeBase*>(xCrsr.get());
        * include/embeddedobj/embeddedupdate.hxx EmbeddedUpdate:
        > svtools/source/misc/embedhlp.cxx:932:35: error: suspicious dynamic cross cast from 'com::sun::star::embed::XEmbeddedObject *' to 'embed::EmbeddedUpdate *' [loplugin:crosscast]
        >     embed::EmbeddedUpdate* pObj = dynamic_cast<embed::EmbeddedUpdate*> (GetObject().get());
        * include/oox/core/contexthandler2.hxx ContextHandler2Helper:
        > oox/source/core/contexthandler2.cxx:183:21: error: suspicious dynamic cross cast from 'const ContextHandler2Helper' to 'const ContextHandler &' [loplugin:crosscast]
        >     ContextHandler( dynamic_cast< ContextHandler const & >( rParent ) ),
        * include/oox/mathml/export.hxx FormulaExportBase:
        > oox/source/export/shapes.cxx:2475:42: error: suspicious dynamic cross cast from 'com::sun::star::frame::XModel *' to 'oox::FormulaExportBase *' [loplugin:crosscast]
        >     oox::FormulaExportBase *const pMagic(dynamic_cast<oox::FormulaExportBase*>(xMathModel.get()));
        * include/oox/mathml/import.hxx FormulaImportBase:
        > oox/source/drawingml/shape.cxx:1298:25: error: suspicious dynamic cross cast from 'com::sun::star::uno::XInterface *' to 'oox::FormulaImportBase *' [loplugin:crosscast]
        >                         dynamic_cast<oox::FormulaImportBase*>(xMathModel.get()));
        > writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:2287:38: error: suspicious dynamic cross cast from 'SfxBaseModel' to 'oox::FormulaImportBase &' [loplugin:crosscast]
        >     oox::FormulaImportBase& import = dynamic_cast<oox::FormulaImportBase&>(dynamic_cast<SfxBaseModel&>(*component));
        > writerfilter/source/rtftok/rtfdocumentimpl.cxx:2973:33: error: suspicious dynamic cross cast from 'SfxBaseModel' to 'oox::FormulaImportBase &' [loplugin:crosscast]
        >                 auto& rImport = dynamic_cast<oox::FormulaImportBase&>(
        > writerfilter/source/dmapper/DomainMapper_Impl.cxx:3000:53: error: suspicious dynamic cross cast from 'com::sun::star::uno::XInterface *' to 'oox::FormulaImportBase *' [loplugin:crosscast]
        >         if( oox::FormulaImportBase* formulaimport = dynamic_cast< oox::FormulaImportBase* >( xInterface.get()))
        * include/sfx2/Metadatable.hxx Metadatable:
        > sw/source/core/doc/docbm.cxx:1837:17: error: suspicious dynamic cross cast from 'const IBookmark *const' to 'const ::sfx2::Metadatable *' [loplugin:crosscast]
        >                 dynamic_cast< ::sfx2::Metadatable const* >(pBookmark));
        > sw/source/core/doc/docbm.cxx:1924:13: error: suspicious dynamic cross cast from '::sw::mark::IBookmark *const' to '::sfx2::Metadatable *' [loplugin:crosscast]
        >             dynamic_cast< ::sfx2::Metadatable* >(pBookmark));
        > sw/source/core/doc/DocumentContentOperationsManager.cxx:342:21: error: suspicious dynamic cross cast from 'const sw::mark::IMark *const' to 'const ::sfx2::Metadatable *' [loplugin:crosscast]
        >                     dynamic_cast< ::sfx2::Metadatable const* >(pMark));
        > sw/source/core/doc/DocumentContentOperationsManager.cxx:344:21: error: suspicious dynamic cross cast from '::sw::mark::IMark *const' to '::sfx2::Metadatable *' [loplugin:crosscast]
        >                     dynamic_cast< ::sfx2::Metadatable      * >(pNewMark));
        > sw/source/core/unocore/unobkm.cxx:381:12: error: suspicious dynamic cross cast from '::sw::mark::IMark *' to '::sfx2::Metadatable *' [loplugin:crosscast]
        >     return dynamic_cast< ::sfx2::Metadatable* >(m_pImpl->m_pRegisteredBookmark);
        > sw/source/core/undo/rolbck.cxx:635:13: error: suspicious dynamic cross cast from 'const ::sw::mark::IBookmark *const' to 'const ::sfx2::Metadatable *' [loplugin:crosscast]
        >             dynamic_cast< ::sfx2::Metadatable const* >(pBookmark));
        > sw/source/core/undo/rolbck.cxx:713:13: error: suspicious dynamic cross cast from '::sw::mark::IBookmark *const' to '::sfx2::Metadatable *' [loplugin:crosscast]
        >             dynamic_cast< ::sfx2::Metadatable* >(pBookmark));
        * include/sfx2/digitalsignatures.hxx DigitalSignatures:
        > sfx2/source/doc/docfile.cxx:3999:25: error: suspicious dynamic cross cast from 'com::sun::star::security::XDocumentDigitalSignatures *' to 'sfx2::DigitalSignatures *' [loplugin:crosscast]
        >     auto xModelSigner = dynamic_cast<sfx2::DigitalSignatures*>(xSigner.get());
        * include/sfx2/sidebar/IContextChangeReceiver.hxx IContextChangeReceiver:
        > sfx2/source/sidebar/SidebarPanelBase.cxx:105:11: error: suspicious dynamic cross cast from 'pointer' (aka 'PanelLayout *') to 'IContextChangeReceiver *' [loplugin:crosscast]
        >         = dynamic_cast<IContextChangeReceiver*>(mxControl.get());
        * include/sfx2/sidebar/ILayoutableWindow.hxx ILayoutableWindow:
        > sfx2/source/sidebar/SidebarPanelBase.cxx:164:44: error: suspicious dynamic cross cast from 'pointer' (aka 'PanelLayout *') to 'ILayoutableWindow *' [loplugin:crosscast]
        >     ILayoutableWindow* pLayoutableWindow = dynamic_cast<ILayoutableWindow*>(mxControl.get());
        * include/sfx2/sidebar/SidebarModelUpdate.hxx SidebarModelUpdate:
        > sfx2/source/sidebar/SidebarPanelBase.cxx:189:40: error: suspicious dynamic cross cast from 'pointer' (aka 'PanelLayout *') to 'SidebarModelUpdate *' [loplugin:crosscast]
        >     SidebarModelUpdate* pModelUpdate = dynamic_cast<SidebarModelUpdate*>(mxControl.get());
        * include/sfx2/xmldump.hxx XmlDump:
        > svtools/source/misc/embedhlp.cxx:290:27: error: suspicious dynamic cross cast from 'com::sun::star::util::XCloseable *' to 'sfx2::XmlDump *' [loplugin:crosscast]
        >         auto pComponent = dynamic_cast<sfx2::XmlDump*>(mxObj->getComponent().get());
        * include/svl/stylesheetuser.hxx StyleSheetUser:
        > sd/source/core/stlsheet.cxx:294:48: error: suspicious dynamic cross cast from 'SfxListener *' to 'svl::StyleSheetUser *' [loplugin:crosscast]
        >         const svl::StyleSheetUser* const pUser(dynamic_cast<svl::StyleSheetUser*>(pListener));
        * include/svl/undo.hxx SfxRepeatTarget:
        > starmath/source/action.cxx:45:5: error: suspicious dynamic cross cast from 'SfxRepeatTarget' to 'SmDocShell &' [loplugin:crosscast]
        >     dynamic_cast< SmDocShell & >(rDocSh).SetFormat(aNewFormat);
        * include/svx/ipolypolygoneditorcontroller.hxx IPolyPolygonEditorController:
        > sd/source/ui/view/drbezob.cxx:127:22: error: suspicious dynamic cross cast from 'sd::SmartTag *' to 'IPolyPolygonEditorController *' [loplugin:crosscast]
        >             pIPPEC = dynamic_cast< IPolyPolygonEditorController* >( mpView->getSmartTags().getSelected().get() );
        > sd/source/ui/view/drbezob.cxx:216:26: error: suspicious dynamic cross cast from 'sd::SmartTag *' to 'IPolyPolygonEditorController *' [loplugin:crosscast]
        >                 pIPPEC = dynamic_cast< IPolyPolygonEditorController* >( mpView->getSmartTags().getSelected().get() );
        * include/vcl/IContext.hxx IContext:
        > vcl/source/window/builder.cxx:3650:54: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IContext *' [loplugin:crosscast]
        >                     vcl::IContext* pContextControl = dynamic_cast<vcl::IContext*>(pCurrentChild.get());
        * include/vcl/ITiledRenderable.hxx ITiledRenderable:
        > In file included from test/source/a11y/swaccessibletestbase.cxx:10:
        > In file included from include/test/a11y/swaccessibletestbase.hxx:22:
        > include/test/a11y/accessibletestbase.hxx:54:15: error: suspicious dynamic cross cast from 'com::sun::star::lang::XComponent *' to 'vcl::ITiledRenderable *' [loplugin:crosscast]
        >             = dynamic_cast<vcl::ITiledRenderable*>(mxDocument.get());
        * include/vcl/NotebookbarContextControl.hxx NotebookbarContextControl:
        > vcl/source/control/notebookbar.cxx:113:33: error: suspicious dynamic cross cast from 'vcl::Window *' to 'NotebookbarContextControl *' [loplugin:crosscast]
        >             pContextContainer = dynamic_cast<NotebookbarContextControl*>(m_pUIBuilder->get<Window>(OUStringToOString(aName, RTL_TEXTENCODING_UTF8)));
        * include/vcl/gdimetafiletools.hxx MetafileAccessor:
        > vcl/source/gdi/impgraph.cxx:716:61: error: suspicious dynamic cross cast from 'drawinglayer::primitive2d::BasePrimitive2D *' to 'const MetafileAccessor *' [loplugin:crosscast]
        >                 const MetafileAccessor* pMetafileAccessor = dynamic_cast< const MetafileAccessor* >(pUnoPrimitive->getBasePrimitive2D().get());
        * include/vcl/syswin.hxx VclBuilderContainer:
        > vcl/source/app/salvtables.cxx:7465:11: error: suspicious dynamic cross cast from 'vcl::Window *' to 'VclBuilderContainer *' [loplugin:crosscast]
        >         = dynamic_cast<VclBuilderContainer*>(m_aOwnedToplevel.get()))
        * include/vcl/toolkit/field.hxx NumericFormatter:
        > vcl/source/window/builder.cxx:583:37: error: suspicious dynamic cross cast from 'vcl::Window *' to 'NumericFormatter *' [loplugin:crosscast]
        >         NumericFormatter *pTarget = dynamic_cast<NumericFormatter*>(get(elem.m_sID));
        * include/vcl/transfer.hxx DragSourceHelper:
        > svx/source/sdr/contact/sdrmediawindow.cxx:163:47: error: suspicious dynamic cross cast from 'vcl::Window *' to 'DragSourceHelper *' [loplugin:crosscast]
        >         DragSourceHelper* pDragSourceHelper = dynamic_cast< DragSourceHelper* >( pWindow );
        * include/vcl/transfer.hxx DropTargetHelper:
        > svx/source/sdr/contact/sdrmediawindow.cxx:126:47: error: suspicious dynamic cross cast from 'vcl::Window *' to 'DropTargetHelper *' [loplugin:crosscast]
        >         DropTargetHelper* pDropTargetHelper = dynamic_cast< DropTargetHelper* >( pWindow );
        > svx/source/sdr/contact/sdrmediawindow.cxx:145:47: error: suspicious dynamic cross cast from 'vcl::Window *' to 'DropTargetHelper *' [loplugin:crosscast]
        >         DropTargetHelper* pDropTargetHelper = dynamic_cast< DropTargetHelper* >( pWindow );
        * include/vcl/wizardmachine.hxx IWizardPageController:
        > vcl/source/control/wizardmachine.cxx:1274:46: error: suspicious dynamic cross cast from 'BuilderPage *' to 'IWizardPageController *' [loplugin:crosscast]
        >         IWizardPageController* pController = dynamic_cast<IWizardPageController*>(pCurrentPage);
        * include/xmloff/settingsstore.hxx DocumentSettingsSerializer:
        > xmloff/source/draw/sdxmlimp.cxx:540:15: error: suspicious dynamic cross cast from 'com::sun::star::beans::XPropertySet *' to 'DocumentSettingsSerializer *' [loplugin:crosscast]
        >     pFilter = dynamic_cast<DocumentSettingsSerializer *>(xProps.get());
        > xmloff/source/draw/sdxmlexp.cxx:2474:41: error: suspicious dynamic cross cast from 'com::sun::star::beans::XPropertySet *' to 'DocumentSettingsSerializer *' [loplugin:crosscast]
        >     DocumentSettingsSerializer *pFilter(dynamic_cast<DocumentSettingsSerializer *>(xProps.get()));
        * include/xmloff/xmlimp.hxx SvXMLImport:
        > sdext/source/pdfimport/sax/emitcontext.cxx:45:37: error: suspicious dynamic cross cast from 'com::sun::star::xml::sax::XDocumentHandler *' to 'SvXMLImport *' [loplugin:crosscast]
        >     if (SvXMLImport *pFastHandler = dynamic_cast<SvXMLImport*>(m_xDocHdl.get()))
        > writerperfect/source/common/DocumentHandler.cxx:118:37: error: suspicious dynamic cross cast from 'com::sun::star::xml::sax::XDocumentHandler *' to 'SvXMLImport *' [loplugin:crosscast]
        >     if (SvXMLImport* pFastHandler = dynamic_cast<SvXMLImport*>(mxHandler.get()))
        * reportdesign/inc/RptObject.hxx OObjectBase:
        > reportdesign/source/ui/report/ViewsWindow.cxx:843:53: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >                             OObjectBase* pObjBase = dynamic_cast<OObjectBase*>(pObj);
        > reportdesign/source/core/sdr/ReportUndoFactory.cxx:30:25: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >     OObjectBase* pObj = dynamic_cast<OObjectBase*>(&rObject);
        > reportdesign/source/core/sdr/RptPage.cxx:62:29: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >         OObjectBase* pObj = dynamic_cast<OObjectBase*>(GetObj(i));
        > reportdesign/source/core/sdr/RptPage.cxx:77:30: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >         OObjectBase* pBase = dynamic_cast<OObjectBase*>(GetObj(nPos));
        > reportdesign/source/core/sdr/RptPage.cxx:116:28: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >     OObjectBase* pObject = dynamic_cast< OObjectBase* >(SdrObject::getSdrObjectFromXShape( _xObject ));
        > reportdesign/source/core/sdr/RptPage.cxx:184:32: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >     OObjectBase* pObjectBase = dynamic_cast< OObjectBase* >( pObj );
        > reportdesign/source/core/sdr/ReportDrawPage.cxx:60:29: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >     OObjectBase* pBaseObj = dynamic_cast<OObjectBase*>(pObj);
        > reportdesign/source/ui/report/dlgedfunc.cxx:455:25: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >     OObjectBase* pObj = dynamic_cast<OObjectBase*>(_pOverlappedObj);
        > reportdesign/source/ui/report/SectionView.cxx:177:37: error: suspicious dynamic cross cast from 'SdrObject' to 'OObjectBase &' [loplugin:crosscast]
        >             OObjectBase& rBaseObj = dynamic_cast<OObjectBase&>(*pObj);
        > reportdesign/source/ui/report/ReportSection.cxx:338:29: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >         OObjectBase* pObj = dynamic_cast<OObjectBase*>(pSdrObject);
        > reportdesign/source/ui/report/ReportSection.cxx:513:38: error: suspicious dynamic cross cast from 'SdrObject' to 'OObjectBase &' [loplugin:crosscast]
        >                 OObjectBase& rBase = dynamic_cast<OObjectBase&>(*pObject);
        > reportdesign/source/ui/report/ReportSection.cxx:644:33: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >             OObjectBase* pObj = dynamic_cast<OObjectBase*>(pDlgEdObj);
        > reportdesign/source/ui/report/ReportSection.cxx:663:35: error: suspicious dynamic cross cast from 'const SdrObject *' to 'const OObjectBase *' [loplugin:crosscast]
        >         const OObjectBase* pObj = dynamic_cast<const OObjectBase*>(pDlgEdObj);
        > reportdesign/source/ui/report/propbrw.cxx:286:33: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >             OObjectBase* pObj = dynamic_cast<OObjectBase*>(pCurrent);
        > reportdesign/source/ui/report/ViewsWindow.cxx:843:53: error: suspicious dynamic cross cast from 'SdrObject *' to 'OObjectBase *' [loplugin:crosscast]
        >                             OObjectBase* pObjBase = dynamic_cast<OObjectBase*>(pObj);
        * sc/source/ui/inc/IAnyRefDialog.hxx IAnyRefDialog:
        > sc/source/ui/app/scmod.cxx:1607:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/app/scmod.cxx:1646:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/app/scmod.cxx:1697:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/app/scmod.cxx:1766:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/app/scmod.cxx:1813:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/app/scmod.cxx:1853:38: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >             IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/view/tabview3.cxx:470:30: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >     IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(xDlgController.get());
        > sc/source/ui/view/tabview3.cxx:2053:42: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                 IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pChildWnd->GetController().get());
        > sc/source/ui/view/tabvwsh4.cxx:210:46: error: suspicious dynamic cross cast from 'element_type *' (aka 'SfxDialogController *') to 'IAnyRefDialog *' [loplugin:crosscast]
        >                     IAnyRefDialog* pRefDlg = dynamic_cast<IAnyRefDialog*>(pController.get());
        * sd/source/filter/eppt/epptbase.hxx PPTExBulletProvider:
        > sd/source/filter/eppt/pptx-epptbase.cxx:497:74: error: suspicious dynamic cross cast from 'PPTWriterBase *' to 'PPTExBulletProvider *' [loplugin:crosscast]
        >         maStyleSheetList.emplace_back( new PPTExStyleSheet( nDefaultTab, dynamic_cast<PPTExBulletProvider*>(this) ) );
        * sdext/source/presenter/PresenterViewFactory.hxx CachablePresenterView:
        > sdext/source/presenter/PresenterViewFactory.cxx:218:36: error: suspicious dynamic cross cast from 'com::sun::star::drawing::framework::XResource *' to 'CachablePresenterView *' [loplugin:crosscast]
        >     CachablePresenterView* pView = dynamic_cast<CachablePresenterView*>(rxView.get());
        > sdext/source/presenter/PresenterViewFactory.cxx:274:23: error: suspicious dynamic cross cast from 'com::sun::star::drawing::framework::XView *' to 'CachablePresenterView *' [loplugin:crosscast]
        >                     = dynamic_cast<CachablePresenterView*>(iView->second.first.get());
        > sdext/source/presenter/PresenterViewFactory.cxx:325:40: error: suspicious dynamic cross cast from 'com::sun::star::drawing::framework::XView *' to 'CachablePresenterView *' [loplugin:crosscast]
        >         CachablePresenterView* pView = dynamic_cast<CachablePresenterView*>(xView.get());
        * slideshow/source/inc/cursormanager.hxx CursorManager:
        > slideshow/source/engine/slide/userpaintoverlay.cxx:449:49: error: suspicious dynamic cross cast from 'CursorManager' to 'Slide &' [loplugin:crosscast]
        >                                                 dynamic_cast<Slide&>(rContext.mrCursorManager),
        * svx/source/inc/celltypes.hxx TableDesignUser:
        > svx/source/table/tabledesign.cxx:267:38: error: suspicious dynamic cross cast from 'com::sun::star::util::XModifyListener *' to 'TableDesignUser *' [loplugin:crosscast]
        >             TableDesignUser* pUser = dynamic_cast< TableDesignUser* >( it.next().get() );
        * svx/source/inc/tablemodel.hxx ICellRange:
        > svx/source/table/tablemodel.cxx:285:26: error: suspicious dynamic cross cast from 'com::sun::star::table::XCellRange *' to 'ICellRange *' [loplugin:crosscast]
        >     ICellRange* pRange = dynamic_cast< ICellRange* >( rRange.get() );
        * sw/inc/IDocumentUndoRedo.hxx IDocumentUndoRedo:
        > sw/source/uibase/shells/drwtxtsh.cxx:585:38: error: suspicious dynamic cross cast from 'SfxUndoManager *' to 'IDocumentUndoRedo *' [loplugin:crosscast]
        >                 auto* pUndoManager = dynamic_cast<IDocumentUndoRedo*>(GetUndoManager());
        * sw/inc/IMark.hxx IFieldmark:
        > sw/source/core/doc/docbm.cxx:1415:15: error: suspicious dynamic cross cast from 'sw::mark::MarkBase *const' to 'IFieldmark *' [loplugin:crosscast]
        >             : dynamic_cast<IFieldmark*>(*pFieldmark);
        > sw/source/core/doc/docbm.cxx:1437:16: error: suspicious dynamic cross cast from 'sw::mark::MarkBase *' to 'IFieldmark *' [loplugin:crosscast]
        >         return dynamic_cast<IFieldmark*>(pFieldmark);
        > sw/source/core/doc/docbm.cxx:1570:37: error: suspicious dynamic cross cast from 'sw::mark::MarkBase *' to 'IFieldmark *' [loplugin:crosscast]
        >                 IFieldmark *pMark = dynamic_cast<IFieldmark*>(*aIter);
        * sw/inc/calbck.hxx BroadcastingModify:
        > sw/source/core/attr/swatrset.cxx:228:29: error: suspicious dynamic cross cast from 'const sw::BroadcastingModify *' to 'const sw::FormatDropDefiner *' [loplugin:crosscast]
        >         auto pDropDefiner = dynamic_cast<const sw::FormatDropDefiner*>(pModify);
        > sw/source/core/txtnode/OnlineAccessibilityCheck.cxx:38:28: error: suspicious dynamic cross cast from 'SwNode *' to 'sw::BroadcastingModify *' [loplugin:crosscast]
        >         auto* pBroadcast = dynamic_cast<sw::BroadcastingModify*>(m_pNode);
        * sw/inc/contentindex.hxx SwContentIndexReg:
        > sw/source/core/doc/DocumentRedlineManager.cxx:56:20: error: suspicious dynamic cross cast from 'SwNode *' to 'SwContentIndexReg *' [loplugin:crosscast]
        >             assert(dynamic_cast<SwContentIndexReg*>(&pPos->GetNode())
        * sw/source/core/inc/flowfrm.hxx SwFlowFrame:
        > sw/source/core/layout/frmtool.cxx:3044:35: error: suspicious dynamic cross cast from 'SwFrame *' to 'SwFlowFrame *' [loplugin:crosscast]
        >         SwFlowFrame *pFlowFrame = dynamic_cast<SwFlowFrame*>(pSibling);
        * sw/source/uibase/inc/FrameControl.hxx ISwFrameControl:
        > sw/source/uibase/docvw/FrameControlsManager.cxx:283:15: error: suspicious dynamic cross cast from 'vcl::Window *' to 'ISwFrameControl *' [loplugin:crosscast]
        >     mpIFace = dynamic_cast<ISwFrameControl *>( pWindow.get() );
        * vcl/inc/IPrioritable.hxx IPrioritable:
        > vcl/source/control/NotebookbarPopup.cxx:40:37: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IPrioritable *' [loplugin:crosscast]
        >         vcl::IPrioritable* pChild = dynamic_cast<vcl::IPrioritable*>(GetChild(0));
        > vcl/source/control/PriorityHBox.cxx:89:43: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IPrioritable *' [loplugin:crosscast]
        >         vcl::IPrioritable* pPrioritable = dynamic_cast<vcl::IPrioritable*>(pChild);
        > vcl/source/control/PriorityHBox.cxx:127:32: error: suspicious dynamic cross cast from 'vcl::IPrioritable *' to 'vcl::Window *' [loplugin:crosscast]
        >         vcl::Window* pWindow = dynamic_cast<vcl::Window*>(pPrioritable);
        > vcl/source/control/PriorityHBox.cxx:142:32: error: suspicious dynamic cross cast from 'vcl::IPrioritable *' to 'vcl::Window *' [loplugin:crosscast]
        >         vcl::Window* pWindow = dynamic_cast<vcl::Window*>(*pChildR);
        > vcl/source/control/PriorityHBox.cxx:186:43: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IPrioritable *' [loplugin:crosscast]
        >         vcl::IPrioritable* pPrioritable = dynamic_cast<vcl::IPrioritable*>(pChild);
        > vcl/source/window/NotebookBarAddonsMerger.cxx:128:19: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IPrioritable *' [loplugin:crosscast]
        >                 = dynamic_cast<vcl::IPrioritable*>(pOptionalParent.get());
        > ovcl/source/window/builder.cxx:3643:55: error: suspicious dynamic cross cast from 'vcl::Window *' to 'vcl::IPrioritable *' [loplugin:crosscast]
        >                     vcl::IPrioritable* pPrioritable = dynamic_cast<vcl::IPrioritable*>(pCurrentChild.get());
        * vcl/inc/jsdialog/jsdialogbuilder.hxx BaseJSWidget:
        > vcl/jsdialog/executor.cxx:41:26: error: suspicious dynamic cross cast from 'weld::Widget *' to 'BaseJSWidget *' [loplugin:crosscast]
        >     if (auto pJSWidget = dynamic_cast<BaseJSWidget*>(pWidget))
        > vcl/jsdialog/executor.cxx:49:26: error: suspicious dynamic cross cast from 'weld::Widget *' to 'BaseJSWidget *' [loplugin:crosscast]
        >     if (auto pJSWidget = dynamic_cast<BaseJSWidget*>(pWidget))
        > vcl/jsdialog/executor.cxx:155:49: error: suspicious dynamic cross cast from 'weld::MenuButton *' to 'BaseJSWidget *' [loplugin:crosscast]
        >                     BaseJSWidget* pMenuButton = dynamic_cast<BaseJSWidget*>(pButton);
        * vcl/inc/unx/x11/x11gdiimpl.h X11GraphicsImpl:
        > vcl/unx/generic/gdi/salgdi.cxx:387:36: error: suspicious dynamic cross cast from 'pointer' (aka 'SalGraphicsImpl *') to 'X11GraphicsImpl *' [loplugin:crosscast]
        >     if( X11GraphicsImpl* x11Impl = dynamic_cast< X11GraphicsImpl* >( mxImpl.get()))
        * xmlsecurity/inc/certificate.hxx Certificate:
        > xmlsecurity/source/helper/documentsignaturemanager.cxx:334:33: error: suspicious dynamic cross cast from 'com::sun::star::security::XCertificate *' to 'xmlsecurity::Certificate *' [loplugin:crosscast]
        >         if (auto pCertificate = dynamic_cast<xmlsecurity::Certificate*>(xCert.get()))
        > xmlsecurity/source/helper/documentsignaturemanager.cxx:381:33: error: suspicious dynamic cross cast from 'com::sun::star::security::XCertificate *' to 'xmlsecurity::Certificate *' [loplugin:crosscast]
        >         if (auto pCertificate = dynamic_cast<xmlsecurity::Certificate*>(xCert.get()))
        > xmlsecurity/source/component/documentdigitalsignatures.cxx:688:28: error: suspicious dynamic cross cast from 'com::sun::star::security::XCertificate *' to 'xmlsecurity::Certificate *' [loplugin:crosscast]
        >             auto pAuthor = dynamic_cast<xmlsecurity::Certificate*>(xAuthor.get());
        > xmlsecurity/source/component/documentdigitalsignatures.cxx:689:26: error: suspicious dynamic cross cast from 'com::sun::star::security::XCertificate *' to 'xmlsecurity::Certificate *' [loplugin:crosscast]
        >             auto pCert = dynamic_cast<xmlsecurity::Certificate*>(xCert.get());
        > xmlsecurity/qa/unit/signing/signing.cxx:130:29: error: suspicious dynamic cross cast from 'com::sun::star::security::XCertificate *' to 'xmlsecurity::Certificate *' [loplugin:crosscast]
        >         auto pCertificate = dynamic_cast<xmlsecurity::Certificate*>(xCertificate.get());
        
        Change-Id: If4f9efd8c012d0f650fe670450cf7ac0c8978036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143458
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-29  Tünde Tóth  <toth.tunde@nisz.hu>  [01246f06cfeeb6a1070e82351e2559def4f5d820]

        tdf#152152 DOCX export: fix lost WDP images in artistic effects
        
        Handling of WDP image counter was incorrect if the
        document contains embedded documents, overwriting
        WDP images with the other ones.
        
        See also commit 55b1d635350cb76ee3e19e90c938eedd38ac3342
        "tdf#152153 DOCX export: fix lost images at embedded documents"
        and commit cf2dc247ff5f726238856e9b46a4926a30430e14
        "DOCX export: image deduplication and clean up"
        and commit b5f6a5cfc517ecd8aa6ba96471d854b07b92ebaa
        "ooxml: Do not repeat wdp files in artistic effects".
        
        Change-Id: Ia26784519f6d514ee8c90c7a91a367feeba140b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143235
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-29  Michael Stahl  <michael.stahl@allotropia.de>  [ae132145ff42a95dc24fb124847c04af4b8c8dab]

        tdf#141386 svx,sw: fix setting name/title/description on SwVirtFlyDrawObj
        
        The problem is that setting the title via the dialog in Writer calls
        SwFlyFrameFormat::SetObjTitle() which sets SwFrameFormat::msTitle and
        SdrObject::m_pPlusData::aObjTitle on the master SwFlyDrawObj.
        
        Now ViewContactOfSdrObj::embedToObjectSpecificInformation() is called
        for the SwVirtFlyDrawObj, not the SwFlyDrawObj, because that one is not
        on the SdrPage.
        
        However, SwFlyFrameFormat::GetObjTitle() will return
        SwFrameFormat::msTitle as a fallback.
        
        So what's missing here is SwVirtFlyDrawObj must forward calls that
        get/set model properties to its associated SwFlyDrawObj - implement that
        in base class SdrVirtObj.
        
        But note that this does not fix the reported PDF export bug - that was
        already fixed by commit 122b4264d23df8b11419839ba700b88c4f936a6c in sw
        and this fix is for other users of ObjectInfoPrimitive2D.
        
        Change-Id: Id306c44c67c069777373e5e4d55415176b513afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143465
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [e180a37b663d9bc1a5219e2cb3a00ae167827325]

        dbaccess: remove unused includes
        
        Change-Id: I633040297d73ecb851ea71a516b4308f6809d939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143463
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [93651bd3a20f7f4174b1324c8a6b6b33450ead81]

        sd: remove unused includes
        
        Change-Id: Iecf41f8b09c9b0e5d411af6a4fdf84a1288e4043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143464
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [90a37bbaec71d2b551d98f630fc61b9ccfe714ad]

        sd: test exporting to odg with password protection
        
        Change-Id: I45da629f86a965dae016d4860720174b8bb7f183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143462
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Stephan Bergmann  <sbergman@redhat.com>  [5ce9bf3ff3b7453fe792ce71547b991423d6280f]

        Fix Linux --without-system-cairo build
        
        ...(as I e.g. use for a max-coverage ASan build) after
        e5658b209a23a17b3f89fe3eabd1e065513622f1 "WASM cairo: link static lib directly",
        causing
        
        > [LNK] Library/libvcllo.so
        > clang-16: error: no such file or directory: '.../workdir/UnpackedTarball/cairo/src/.libs/libcairo.a'
        > clang-16: error: no such file or directory: '.../workdir/UnpackedTarball/pixman/pixman/.libs/libpixman-1.a'
        > make[1]: *** [.../vcl/Library_vcl.mk:20: .../instdir/program/libvcllo.so] Error 1
        
        because at least on Linux external/cairo only provides dynamic libraries
        
        Change-Id: I7a35d7f28d99664ea749be23c76e74cd5a760f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143422
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-29  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [93a69d37c1dbcc7365dc0cf2493d1ca27babef2b]

        pixman: upgrade to release 0.42.2
        
        Fixes CVE-2022-44638
        
        Remove Wincompatible-function-pointer-types.patch.0, fixed upstream.
        
        Change-Id: If6589a701a252f71da145264ee3a6f0e333492ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143423
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ce31e09a6d40295cec4be9da8f4cec886d6c92c1]

        accept Apple's patch utility - pickier than GNU patch, but should be OK
        
        macOS Ventura replaced the patch utility by Apple's version:
        patch 2.0-12u11-Apple (as of macOS 13.0.1)
        
        It is picker/less robust when it comes to locating matches, and absolutely
        refuses to apply when the hunks are out of order. Only one patch needed
        rework in the current codebase (master an 7-4 branch), and being more correct
        about the locations in the files to be patched is not a bad thing either, so
        accept Apple's version of patch (with a warning for now)
        
        Change-Id: I707d00958b814307b13caf9923f1de7f3919442c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143461
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [958c08ad86d56839faf28a02097500bad7b1eb76]

        sd: test exporting to odp/pptx with password protection
        
        exporting to ppt with password protection is not supported
        
        Change-Id: Ic04c0046b91b76688c947bb4ae3b3cf90046080c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143459
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [9022e69b4ceb3c8986a3b8637a661baeebef587a]

        SdModelTestBase: introduce createSdImpressDoc and createSdDrawDoc
        
        it turned out shadow-blur.odg is instead a presentation file
        
        Change-Id: Ifcf3f7a76dd823bea4937927888648008ef6206d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143457
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Miklos Vajna  <vmiklos@collabora.com>  [12f434277bc424f01597be83020a569c84bbee5a]

        sw: hide TextFormFields from the customization dialog like
        
        Addresses
        <https://gerrit.libreoffice.org/c/core/+/143361/2#message-ab38e28cbdbbfe57d48bec1ce3026bb4fded60f6>,
        this command is meant to be invoked from macros and the LOK API, not
        from the UI, so hide these instead of adding a label.
        
        Change-Id: Icc17aa10db49fd2937453b3a5ceddfb368787574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143430
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-29  Caolán McNamara  <caolanm@redhat.com>  [e231cf313d8b3be672d32b9201b37fb20e646758]

        SalLayout::mnUnitsPerPixel is always 1
        
        since
        
        commit 368de904974b18dc5a8d237e046c0ed005f7c85d
        Date:   Thu Nov 24 09:21:56 2016 +0200
        
            Kill PspFontLayout
        
        removed the last SetUnitsPerPixel
        
        Change-Id: I60db3d9eb4c42f3f0372b5f063a912b7addfde90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [208f69acb5a09286cec6b49bd963fc894ffc2f81]

        sw, sc: UNO_QUERY -> UNO_QUERY_THROW in a few places
        
        see https://gerrit.libreoffice.org/c/core/+/142581
        
        Change-Id: Idcfba338718bf583739f4469299663e782dbe57c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143433
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Miklos Vajna  <vmiklos@collabora.com>  [d34036e60c4e7d13feccd089f7749d35d956b358]

        SVG import: add support for semi-transparent text
        
        <tspan fill-opacity="..."> from SVG was ignored so far, only taking RGB
        colors from the 'fill' attribute, but ignoring transparency.
        
        The problem is that an SVG file is imported by mapping it to
        drawinglayer primitives, but TextSimplePortionPrimitive2D takes a
        basegfx::BColor as the font color, which doesn't handle transparency.
        
        Fix the problem by rendering SVG similar to how commit
        81b0d5393ca4cf2ff0954e53b05928cde047c2e0 (svx: add rendering for
        semi-transparent shape text, 2019-11-20) did it for shape text: wrap the
        text primitive in a UnifiedTransparencePrimitive2D when opacity is not
        1.
        
        Note that the drawinglayer primitive works with transparency and SVG
        works with opacity, which is the opposite of each other, but both are
        0..1 ranges.
        
        Change-Id: If5c48613b70eac662b54b8c9da835cd0a966ba89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143429
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [236a96c7cff4cbf8a4ee2499739e7a938b6bae64]

        sc: test exporting to xls/xlsx with password protection
        
        Change-Id: I79ebc0d4f65c26aab8c04399a47ce1cbc631cf76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143432
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-29  Caolán McNamara  <caolanm@redhat.com>  [7d11bbb906f3fe49b243c3acca1cffbb28915a6a]

        Resolves: tdf#152128 consider input engine events as well as keystrokes
        
        Change-Id: I2884c6feb388050dd962fba5ef85117da2a039d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-29  Maxim Monastirsky  <momonasmon@gmail.com>  [daab698b346e5e40b67f1e15c796c4e399ccaf8a]

        sd: replace hardcoded table styles with xml file
        
        Including a new set of default styles, provided by Rafael Lima.
        Some ui tests had to be modified, because the new borders are
        thicker.
        
        If you intend to edit the xml file, please keep in mind the
        following requirements:
        
        1) There should be a table template called "default". It's
        applied to newly inserted tables.
        
        2) There should be a cell style called "default". It's used for
        new table styles.
        
        3) Please make all cell styles inherit from "default" (directly
        or indirectly), unless you intend to specify font names in them.
        "default" has its font names filled programmatically based on
        officecfg/registry/data/org/openoffice/VCL.xcu.
        
        4) Whenever possible please use <style:table-cell-properties>
        for cell properties, instead of the incorrect
        <style:paragraph-properties> and <loext:graphic-properties>
        we currently use for export. See tdf#72238 and tdf#72239.
        
        Change-Id: I73dd4492fefb65b1870238aec7dc64f8076f6e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141825
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-29  Miklos Vajna  <vmiklos@collabora.com>  [7830ecc2e4e5dd264517c6554078fa807ff1fceb]

        sw: document SwUndoReRead
        
        I.e. the primary use-case is not to re-read the same image, but to read
        a different Graphic and set it on an existing SwGrfNode.
        
        Change-Id: I0947e714fc1b3de870b77aaa2b6682707ccec4e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143414
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9d5060d8953ae426197ca002e4b46f508f74d2a8]

        tdf#152287 Move lonely control next to its friends
        
        It was in two separate columns for no reason whatsoever.
        The dialog is more compact now, and there is no longer a
        bunch of <placeholder> elements as a result of dropping the
        excess of grid slots.
        
        Change-Id: I521bc37e485163c07c56140fc0409c7b066798b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143425
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2be29ee28d06110961775fe05253a949611deed6]

        use more SwFormatAnchor::GetAnchorContentOffset
        
        Change-Id: I44406ddeb765088d86c0484f7097b80f362fd4a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [b487550e829dee77de6fc202848e6de88e583e6c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 339b994703189f93a1b4a1f861b2bfd71bf2afa7
          - tdf#152136 Update label to signify we only support SMTP
            
            Change-Id: I087f6fa3a50069a799baa70d81b471cff0cd1bf0
            
2022-11-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [c45d38dc996eedddbd26b15df7642ac71b19d59a]

        tdf#152136 Improve SMTP settings page
        
        Improve layout and section title so that there is a clear implication
        that we only support email servers of the SMTP kind.
        
        Change-Id: I28ba1dad6b00728b8a5af8c0b7c679558cb6d240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143418
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-29  Tor Lillqvist  <tml@collabora.com>  [fe845e40ab23a3fa9fd401498edf925b7b00776f]

        Don't build the Qt5 Mandelbrot demos unless we have Qt5
        
        Change-Id: I968f9d9a94e3db219c7dd900db1b0261cd8f09cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143397
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-29  Tor Lillqvist  <tml@collabora.com>  [8aef8c3a1451b2fce37a21870a004855822ee335]

        Make it possible to run either Writer or Calc in the same Emscripten thing
        
        If no --with-main-module option is used, don't strip either.
        
        To switch, you need to edit the instdir/program/soffice.js . (Or
        static/emscripten/soffice_args.js and re-make.)
        
        Change-Id: I572a777134e7b29fc4896e7b094ceca521874ae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143396
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-29  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [dff1d7526f8b9d98c864a32654820cf92196ccbf]

        Don't use pthread for cairo
        
        For cross builds, odd cases of cairo configure picking up wrong librt
        and then missing pthread functions - so lets just disable it, we're
        not using cairo multi-threaded anyway.
        
        Change-Id: Id8b6426203859e7bf082d71ad8cf4548928d6acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143390
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-28  Justin Luth  <jluth@mail.com>  [330194d164be6f5ac33a3d7a229f9ace8d54d68d]

        tdf#151548 ContentControls: improve ListEntry::setValue
        
        The LO implementation pulls the display text from the value
        in case there is no display text provided.
        
        This is the opposite from VBA. So when we set the Value,
        make sure that we aren't unintentionally
        changing the display as well.
        
        Change-Id: I699bfc1c2e9fbab6574a3c1363fe1dc21c7354e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143416
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-28  Stephan Bergmann  <sbergman@redhat.com>  [589e03fb4c3b05bf3742c0cb8b366322ffdf1fa9]

        [PATCH] Replace some dynamic_cast with UNO_QUERY
        
        Change-Id: I59ad7246cee84bd63784477e1fefda708ac35dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143413
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [0e4ff2261f3c2c9dada5816f11095652e028c3dd]

        tdf#67866 sc,sd: PDF/UA export: set language in Catalog
        
        sw already does this, and it's recommended in
        https://www.w3.org/WAI/GL/WCAG20-TECHS/PDF16.html
        
        Change-Id: I0ce36442ec1b223c40f53fac3683ad7bb0e2bc6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143307
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff41bc546edb4f28ac0852fc8a95fe5dbde40a10]

        use more GetAnchorContentOffset
        
        Change-Id: Iacc88f4057d2ece698d76a9ebaaf7de276ab0450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8307321e6c56e153a6198f54ef3f9d555c96920b]

        loplugin:unusedfields make some protected fields private
        
        Change-Id: I61d1bc59dce1ff53f48be66e6fdcd92b47004871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [acc08fb5d3427f882d55e43167e9cca0eb344c24]

        Add some more utility methods to SwFormatAnchor
        
        Change-Id: I3ad607428470b95d32891cc18e8e82f0cf113626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [24cc33655c7d54741c8b8d80244a285471558f0f]

        Make entry visible after scroll_to_row in Macro Organizer dialog
        
        Change-Id: I46b0f14a909e6c1813acfd9190459b5c87246682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143263
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c7b1fbff3673284d829606e5e07f9deb4258a5f5]

        f'up to the tdf#152172 fix re Safari as default browser on Ventura
        
        Previous patch did only adjust the check in the rarely used version of
        the function, not in the primarily used signature. D'oh!
        
        Change-Id: I019a74651d3ee8bab43a8c3997b8cd05040b7ba4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143410
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-11-28  Jim Raykowski  <raykowj@gmail.com>  [361ba08c62d91026b555130dc9b9b73ce71d1289]

        SwContentTree: add comment about m_nActiveBlock
        
        Change-Id: I1b623bf04fad40233848081e65ecce1c7ec7f0dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143334
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-28  Jim Raykowski  <raykowj@gmail.com>  [0da5631e08c17d1cb183b2249b0dfa0b6832ff9f]

        tdf#152116 SwNavigator: Restore outline headings expand state
        
        when the Navigator is reopened
        
        This patch restores the outline headings expand state to what it was
        when the Navigator was last closed. Effort here is a one session
        solution that works for all documents opened in the session. The
        expand state is not restored when a document is close and then
        reopened.
        
        Change-Id: I28e8e01694d72dee2cc3705ff69f8726c28bdecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143326
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-28  Bogdan B  <buzea.bogdan@libreoffice.org>  [0c2d485edece9078629842a0e1202bfb75f6d0d6]

        tdf#132293 remove unused imports from uitest
        
        Change-Id: I7690db426741fdc46cd2632f2db98ad75361261f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142617
        Tested-by: Jenkins
        Reviewed-by: Kevin Suo <suokunlong@126.com>

2022-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e16daa6079f703c87e19904e7bb85e5fd9beac7c]

        tdf#107097: move UItest to CppUniTest
        
        Change-Id: I81834b8316b19baad55122cc06a481d55fb6244a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143401
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-28  Eike Rathke  <erack@redhat.com>  [730e7a9194a58613a47867839cef0870d52d8d6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77ac257cd73c3420134ac68abd53da5d389286f6
          - Adjust using label names to reality
            
            Escaping a single quote with a backslash (\') was always wrong,
            and meanwhile the finding labels automatically feature was
            deactivated per default long time ago.
            
            Change-Id: I58057c36d1b7a23c60670e1972608a6b86ca7a07
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143415
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-11-28  Stephan Bergmann  <sbergman@redhat.com>  [5cf1cc2343aaad47eb4c79972c29e1d97f43c418]

        Silence -Werror,-Wdeprecated-declarations for now
        
        ...that got introduced with e10e5981ca020af11d25d5756964c95d51dd1535 "tdf#152183
        update settings when dark/light system mode toggled",
        
        > vcl/osx/salframe.cxx:1269:19: error: 'setCurrentAppearance:' is deprecated: first deprecated in macOS 12.0 - Use -performAsCurrentDrawingAppearance: to temporarily set the drawing appearance, or +currentDrawingAppearance to access the currently drawing appearance. [-Werror,-Wdeprecated-declarations]
        >     [NSAppearance setCurrentAppearance: mpNSView.effectiveAppearance];
        >                   ^
        > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAppearance.h:28:58: note: property 'currentAppearance' is declared deprecated here
        > @property (class, null_resettable, strong) NSAppearance *currentAppearance API_DEPRECATED("Use -performAsCurrentDrawingAppearance: to temporarily set the drawing appearance, or +currentDrawingAppearance to access the currently drawing appearance.", macos(10.9, 12.0));
        >                                                          ^
        > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSAppearance.h:28:58: note: 'setCurrentAppearance:' has been explicitly marked deprecated here
        
        Change-Id: If4aa9a30fda2977fa3cc23f2cb0d056a8dcde311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143402
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [af826c85c2eb519b9a3f76099c0e70604d9679e2]

        tdf#133343 improve perf of OUString::operator=(&&)
        
        shaves 4% off the save time here.
        
        We don't need to do this - either the old rtl_uString will be
        overwritten in the source object, or it will be destructed, either way,
        re-initialising it is a waste of time.
        
        Change-Id: I47becb17de1e47f2a26c2ac4497e769e13523115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [ccd6a95eaaa8c8c4af1f2efa388a25aca2877cc1]

        WASM LibreOfficeKit add EMSCRIPTEN to ifdef
        
        Change-Id: Ib6f3a6bd6b8703cd9eb24707531c01153cd2f8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143391
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  László Németh  <nemeth@numbertext.org>  [48e1375045a9170a5a377ede2f062803eafedf63]

        tdf#152214 vcl: add unit test for double lines in small zoom
        
        To avoid of losing them completely or showing
        them as single lines on small zoom levels.
        
        This was a regression of visualization of tracked
        text moving, where green double strike out and
        double underline character formatting are associated
        to the removed and inserted text.
        
        Regression from commit ba03e033d1be4bc49f2a8d6afbeecd381507b242
        "vcl: Use font’s underline/strike position and size", which
        was fixed in <https://gerrit.libreoffice.org/c/core/+/143321>
        and commit 55858a50cfb12cb6a4207bf906df676e799c1213
        "tdf#152214: make sure underlines are shown on small zoom levels".
        
        Change-Id: Iffa9e92ef472e95ff27c89473bcbe2ffafa4525e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143384
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-28  Eike Rathke  <erack@redhat.com>  [eb7bbb761fd34f76cbfd89b45846c6cb9083d24e]

        Resolves: tdf#148792 Add Portuguese (Mozambique) {pt-MZ} locale and data
        
        Basically copies pt_PT.xml but replaces translated with
        untranslated keywords (AA,AAAA => YY,YYYY), hence no ref="pt_PT"
        for LC_FORMAT (and LC_CTYPE).
        
        Also use sort-formats.awk -v group=1 to sort FormatElement by usage
        group and formatIndex as those went quite wild over time..
        
        Change-Id: Iececac0ebdd0317fd14ab65f32c08501f3ce32c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143398
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [61f42c31b02c569ad22cad5e71b20cb0df8fd1f8]

        Resolves: tdf#147203 allow dnd between autotext categories
        
        restores various methods removed as unused since original
        regression at
        
        commit 4830a1bae89a8ed60696503e315ffd42c70dff74
        Date:   Thu May 30 16:12:23 2019 +0100
        
            weld SwGlossaryDlg
        
        Change-Id: I5c6186b9f45f3c0957926de2861eb6bc76dda73d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [b40f46548fee555b89626e6b17177a1d600b82c1]

        Disable languagetool for WASM build
        
        Change-Id: Icd0face05c33bbb1b56230a59015402d5f565422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143385
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-11-28  Alain Romedenne  <alain.romedenne@libreoffice.org>  [625909a3eb9f48d2202773ac3df4cd14a3ef6a40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 39cb68fb4d89fa5c4ee68ac5a5a0aade7e8421aa
          - help not found on 'File Services' dialog
            
            Change-Id: Ide8dfdea19f13d6978197bece825f70407fbb65b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143272
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [e5658b209a23a17b3f89fe3eabd1e065513622f1]

        WASM cairo: link static lib directly
        
        Because bundled cairo is only used on Android currently, and that does
        static linking, this doesn't make a difference for LO build.
        
        But it does improve the situation when linking the bundled cairo via
        libtool, because libtool unhelpfully finds libcairo.la via -lcairo,
        which contains an unhelpful dependency_libs that includes "-lz", which
        does not exist anywhere (LO's bundled one is called libzlib.a).
        
        Ideally GNU libtool could be told to ignore .la files, but i don't know
        how.
        
        Change-Id: Icaaa0b441e1410a297f6d61afd81e31425138955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143392
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [7a80b68cb0b279a1b43f769169aaf2a2659dc150]

        WASM gbuild: write link dependencies into a file $@.linkdeps
        
        The static build was added in commit
        dc9ccf3d8f294cd7ae9d5bece7b6c16c3b22f6a5 and commit
        b04be559ddf4a7f0a5cdc0b9abc2bcfc4aae25cc and there are several files
        written to workdir/LinkTarget/*/*.d.{libraries,externals,statics}
        that list all the (recursive) dependencies of a LinkTarget.
        
        Unfortunately the content of these files requires gbuild to interpret,
        because it's using the Library names which may not map 1:1 to file
        names, not to mention "externals"; this is all resolved by calls to
        gb_LinkTarget_use_* anyway.
        
        To get a command line that's usable outside of gbuild, write another
        file $@.linkdeps as a side effect of gb_LinkTarget__command_dynamiclink.
        
        Change-Id: I94f31142413561dcdb56fa722a4517f84fcd7d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143393
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [98700f59bb72a2c67b48656eacbac7ebdd4ead7b]

        unused ERR_SWG_OLD_GLOSSARY define
        
        since
        
        commit cae829e9c1394851fc88829d5197460929c2792a
        Date:   Tue Jun 11 14:05:02 2019 +0200
        
            loplugin:unusedmethods
        
        Change-Id: I6e3c27fab44d70e3a2462cf348436b5669c07136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [988d719cfbe097f674abfd04fdc4f9c2874b21b3]

        WASM gbuild: avoid annoying python warnings from emscripten
        
        /home/builder/emsdk/upstream/emscripten/tools/building.py:1228: ResourceWarning: unclosed file <_io.BufferedReader name='/data/lo/build_feature_wasm/workdir/LinkTarget/StaticLibrary/libdtoa.a'>
          header = open(filename, 'rb').read(8)
        ResourceWarning: Enable tracemalloc to get the object allocation traceback
        
        Change-Id: I5cd052cd47af92e18cb6ccce31d4503a322d815b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143389
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [ab01462192ac5b11c91e898e4af475ea088042f3]

        WASM linguistic,sw: disable curl-using deepl code
        
        Curl is currently not built - not sure if possible at all.
        
        So disable new feature added in commit
        e20d2de7836da52dbf9e528d1043b1e188097bfd
        
        Change-Id: Idb5d97792d59c850bc1d38a08b79d1be8cb92cdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143388
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  Michael Stahl  <michael.stahl@allotropia.de>  [7ea19dd9086c9afe1a044716ca7f9643442a846c]

        openssl: patch out another call to IPC::Cmd
        
        ... which is used when cross-compiling.
        
        Change-Id: I08f5ccd5d9418a81c9b1273667133065552325dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143387
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-28  Aron Budea  <aron.budea@collabora.com>  [bfdaa3f59bcf87f341138202c047dd4b28acb28a]

        DeepL: Only enable Translate menu if it's set up
        
        Both the API URL and Authentication key have to be set.
        
        Plus:
        - align widgets in DeepL settings dialog,
        - rename .ui file to conform to other dialog names in Options.
        
        Change-Id: I8cfeaa64b05747b0113a6075b6fd241ca9ab3a70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143359
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [f97556dc0bdf9b4593fab78ef205972bf89b4af3]

        CppunitTest_chart2_uichart: simplify test a bit
        
        Change-Id: I9d25adb68dac446c7e2e013684ceff48eaf23e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143383
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f4e1180b3a616c234d0de7db8cea7c682777243]

        tdf#151091: chart2_uichart: Add unittest
        
        Change-Id: I6d162307a32d18711908c1681c63c945574ba904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143381
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [912ac41182b7fc6dbc52c3e699ce5a720998c565]

        re-order methods a little in SwFormatAnchor
        
        group them more logically
        
        Change-Id: I3b3d4bdbe7d4f38d03503928c1c1c054844c51cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [035bdbab49bb15a88d1c653dbf098ec3c17e0bde]

        stray left over debugging fprintfs
        
        Change-Id: Ic7c192dba1934c874326bee9c859b3818fb5d7a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [6b2018fe67bafa7e84239eac83d48da4dcbaaa7a]

        fix can't add a new category to autotext
        
        since:
        
        commit 4b95451f859bac8e05956ce12df17f1ee410032d
        Date:   Wed Sep 21 20:54:00 2022 +0200
        
            split utl::TempFile into fast and named variants
        
        Change-Id: I78002ac0309c6e74d5169aeecdc9c660d0aa9279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [254acd7c1d8fef437985c9b428a0edddede9d5a9]

        Resolves: tdf#152253 Text in calc Input Box unreadable in dark mode
        
        Change-Id: I60bfde908ac2d107d14aa7387d569d575622f962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff0315d7c000bee784b97c385fccaa300210172a]

        tdf#151484: sc_subsequent_export_test2: Add unittest
        
        Change-Id: Ic2518a6ed00678b83e0b497610eb86a5e99464c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143375
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [03b5ef45ae3485e055bbbf44532835a5f8868b8e]

        tdf#152015: sw_odfimport: Add unittest
        
        Change-Id: If7682b93973a8801a81ce9a887bf7bd1b9ac5594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143374
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [19e3bab1a8def52d9a60f67bd87697e828e37773]

        tdf#77650 Add option to place comments in margin (PDF Export)
        
        This was somehow possible already when the document was printed with
        comments in margin before - but it was not possible to set this option
        when exporting a PDF via dialog or API.
        
        To use this setting via API, set the "ExportNotesInMargin" property.
        
        Change-Id: I97a80c5b3b3b2cde669496fd881a41ea0acc5c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143234
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-28  Miklos Vajna  <vmiklos@collabora.com>  [7765b442e13048f857fd7ee49ced1731caee297e]

        sw: add a new .uno:TextFormFields UNO command
        
        Currently .uno:TextFormField can be used to insert a new fieldmark, but
        then there is no way to update it. Also, there is no way to update
        several fieldmarks at the same time.
        
        Given that the "ADDON" field type in a field mark can be used by
        extensions like Zotero, it's useful in case these fieldmarks can be not
        only inserted, but they can be also updated. This works by (in the LOK
        case) calling getCommandValues() with .uno:TextFormFields, and then once
        the client generates the new expanded values, there is no way to insert
        these updated expanded values into the document currently.
        
        Fix this by adding a new .uno:TextFormFields UNO command that can update
        all fieldmarks matching a certain prefix (looking at their field
        command).  This allows e.g. updating all Zotero citations or the
        bibliography, but the API is generic to support any kind of ADDON
        fields. Similar to insertion, the content can be multi-paragraph,
        formatted HTML.
        
        This required adjusting SfxUnoAnyItem::CreateDefault(), this way an UNO
        command parameter can be an array of beans::PropertyValues, which is how
        the client can provide details of multiple fieldmarks.
        
        Change-Id: I44a1b1495ead79b92ccd0c9f6412a34cbec5d68b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143361
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [b1b77b4005ceaeb2b9bc11d8a405bb5a467e1d86]

        ofz#53820 Direct-leak
        
        cairo_get_source leaks if cairo is in an error state
        
        Change-Id: I1ddcf801d5a3fc0944f14001cbc7d152b2071c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143364
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [845dd688e5032c83db889cbf2ca033144dd1de32]

        tdf#123419 vcl: remove unneeded ImplMakeFraction() in map.cxx
        
        Change-Id: Iedb33bca9ee1119baafb92a3191960be41ccaffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-28  Justin Luth  <justin.luth@collabora.com>  [c74ff490903ee04725e9dfee6fdc3598a3a61190]

        tdf#151548 ContentControls: Add Invalidate()
        
        Up until now, all changes made to a content control
        have been triggered by the UI.
        However, VBA makes changes by code,
        and those property changes were just being ignored
        until the control received the focus.
        
        Change-Id: Ife865dd493f7eae4d4e95096071f05b8c27d51db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143194
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-28  Miklos Vajna  <vmiklos@collabora.com>  [a57b12fdf3787def3a3cd5658118420959b4ad7f]

        sw: prefix members of SwAuthorMarkPane, SwEndNoteOptionPage, ...
        
        ... SwGlossaryGroupDlg and SwTOXWidget
        
        See tdf#94879 for motivation.
        
        Change-Id: If95a6f86683d686343d1b58589b41dabfedb968e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143360
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-28  Daniel Lohmann  <LibreOfficeContribution@dldld.de>  [54681a12b38db29b4d65e3c4f4c52a12436965d0]

        Presenter screen wrong position of pointer
        
        The pointer is drawn on the presenting screen and the presenter
        console. In the presenter console the position of the pointer
        is not matching the position on the slide or position in the impress
        remote app. This fixed by this commit.
        
        Change-Id: I5650f62304934d2acb558e32a8e9de78a9f0a12a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143341
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-28  Daniel Lohmann  <LibreOfficeContribution@dldld.de>  [176f77607ed1001efca402d1807e12b93d914847]

        Do not draw pointer on paused mode screen
        
        If the pointer is drawn on the paused mode screen, around the pointer
        the slide will be visible. Everywhere where the pointer was will the
        slide is visible. Preventing to draw the pointer in the paused mode will
        fix this issue.
        
        Change-Id: Ica8fedca5710adfc79ed78a30485bd755e3b3b31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143340
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [1fd42472e2b1a2169d56e62ef11aa7ee1f7815e7]

        Avoid refreshing all hooks in secondary worktrees
        
        This avoids "ln: failed to access '.git/hooks/foo': Not a directory"
        console noise. The primary worktree's hooks are used in secondary
        worktrees anyway.
        
        Possibly using 'git rev-parse --git-dir', and putting hooks there
        would be a better fix? No idea.
        
        Change-Id: I846e065d017744e9d8dcee847d48bc1adc66d761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143358
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-28  Caolán McNamara  <caolanm@redhat.com>  [360b5861fb46353e7a6b9f5abf13339cd719a8df]

        resave with latest glade
        
        Change-Id: Ie8e640365eb2882f07a485f27b777383c5982a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [cb7e6003ad06d71a27baeb435366b91f87bdeb2f]

        cid#1517054 Logically dead code
        
        Change-Id: I0ea48d79d32920cf5f5ab2b11a5b4f53ddae0dc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [31d4db12d91d26f245ac40fc0adbb27ff1f93d6f]

        cid#1517059 disentangle Improper use of negative value
        
        Change-Id: I907f54cd93d78fe3638e407c70253b94f849eac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [026d6e08fada78f095cd32a580f3debe20708982]

        cid#1517060 Unchecked return value
        
        Change-Id: Ic11f632270c65d5c4446771336e39999bc509617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [cf636728b6bfbd8f5992e5a4393496fb411c5b8c]

        cid#1517056 Dereference after null check
        
        Change-Id: I9615e8a762b646d9b9567db56c0d59c61daa010f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [cea9ca3b77ef7f8f11c3eae0786986028161301c]

        cid#982469 Unchecked dynamic_cast
        
        Change-Id: I48904acdd34d7b546a8099f265693e2d46c5d2aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143347
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Eike Rathke  <erack@redhat.com>  [0deb57a1e8d5e85a364fdb5678b46f6fdd7d345b]

        {pt-AO} change to untranslated YY,YYYY keywords, translated AA never worked
        
        Apparently copied from {pt-PT} year AA and AAAA format codes
        should not had made it across but also never worked as
        LANGUAGE_USER_PORTUGUESE_ANGOLA was missing in
        ImpSvNumberformatScan::SetDependentKeywords() so date codes
        displayed literal AA instead. Seems no one is using that locale
        with dates..
        
        Since
        
            commit 5d833d37851597c1fb9076710d9eb03e4c94ca07
            CommitDate: Fri Apr 8 20:51:13 2011 +0200
        
                add pt_AO locale data (edited version of Mandrake's patch)
        
        Change-Id: Icd5f81d0a49462ad2514655742d6c05f069f55fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143354
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-27  Eike Rathke  <erack@redhat.com>  [c58bc31ece80ccdfc88bd043787869c5e460dbd8]

        Resolves: tdf#150011 Switch default currency HRK Croatian Kuna to EUR Euro
        
        HR will join Euro area on 2023-01-01.
        
        Change-Id: I3836804ff68419550091826ea2414bc0edd55a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143346
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [8c6a9daaf99830e1a2a560a9dd0abf3c1e4cfa48]

        cid#1517055 Dereference before null check
        
        Change-Id: Ibd26ac2bce15dced107f6aaf34d12a7819623f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [546945ad789d75b624b67f55130bd90f046e4f7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4227d37acf1e07b49eea7ef7c955d919b18eabf
          - tdf#152162: link from Conditional Formatting help to (Cell) Styles help
            
            Change-Id: Ieaf4f4026ab29de490373946ff5a4428242b5dba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143160
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-27  Caolán McNamara  <caolanm@redhat.com>  [9a01dbc8683e9114d8fd0250cac0cbc33600458a]

        crashtesting: null deref
        
        on exporting fdo45102-1.ods to xlsx
        
        presumably since
        
        commit c4d7b9c3ec6e44b96134fdfb036be7f9fcf39f9d
        Date:   Wed Nov 23 12:14:31 2022 +0100
        
            tdf#70293 XLSX export: fix lost grouping of shapes
        
        Change-Id: I54ec34e1979d3aba5b4e2a6a64870e8f186b21cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-27  Khaled Hosny  <khaled@aliftype.com>  [55858a50cfb12cb6a4207bf906df676e799c1213]

        tdf#152214: make sure underlines are shown on small zoom levels
        
        On small zoom levels we were ending up with underline sizes of zero, so
        use ceil() instead of round() to prevent this. Also make sure double
        lines don’t end up collapsing into each other by changing how the second
        offset is calculated so that they is always a minimum distance between
        the two.
        
        Change-Id: I526685cebce3dddc9df6110e7ffad2729af2be93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143333
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [a22047f148c45d34c5ce08d2d9011237287b673f]

        vcl: test getting glyph boundary rect from LogicalFontInstance
        
        MacOS produces a slightly different glyph height.
        
        Quoting from Khaled in dev IRC:
        
        "Currently GetGlyphBoundRect() calls different platform-specific
        implementations on each platform, so even with the same font it is
        possible to get some difference. So my suggestion is to use a large font
        size and allow for some fuzziness".
        
        Consequently I'm using a 110pt font, and taking into account some
        fuzziness.
        
        Change-Id: I0dace6bfa0d1f4e6f3b8852e957d2d518d37795b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143322
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-27  Khaled Hosny  <khaled@aliftype.com>  [ae2d1315766581259756c819f0227270d344f4d4]

        tdf#102914: keep font attributes for the substituted fallback font
        
        Setting italic to that of the found font seems to prevent artificial
        italic in PDF export. We want to keep the original select pattern
        attributes so that we know we asked for italic font but got a non-italic
        one.
        
        Change-Id: I0cf400e86d802028dffdabbb98e35e3ee584626e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143339
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-27  Khaled Hosny  <khaled@aliftype.com>  [521ba0f495919022a77a189c52f632baef02a05c]

        tdf#102914: fix artificial italic of fallback fonts in PDF export
        
        Check the LogicalFontInstance that the glyphs actually use when
        deciding whether to do artificial italic or not.
        
        Change-Id: Iefb60cf512285b94ff56d48923c3c33c6a6fbc40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143338
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-26  Bogdan B  <buzea.bogdan@libreoffice.org>  [5b18eebc2c95321ce7e6edf10f4df81557382a48]

        tdf#147906 used std::hypot for Pythagorean addition
        
        Change-Id: I28f3996b777c99b771f1cbcde236b5a1a1c0f18f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143168
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-26  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c9807faad6a154b57a99adfdf9b02bd9e588250f]

        Related: tdf#46444 tdf#152081 sc: add unit test for note hiding
        
        Add unit test for column hiding with notes and undo that.
        
        Change-Id: I880ca1565dbefea5e8776b0d137da409ce816ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143299
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-11-26  Caolán McNamara  <caolanm@redhat.com>  [21b88575af9e11115a6b124d8d9cb4e0a95e9fea]

        ofz#53764 Integer-overflow
        
        Change-Id: I0d0ec07801fd612fde3028d4aad2f154c27bc551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [bc5856c5c77a7ee18377cd274960950d8943178f]

        Related tdf#145978 Fix workaround in kf5
        
        In commit 792e41314f321f54b3b2fc4d01c8b62a3b704e9e (about saving the last used macro) I used a workaround to make scroll_to_row work in kf5.
        
        However, this workaround based on hide() / show() calls was causing an error: qt.qpa.xcb: internal error:  void QXcbWindow::setNetWmStateOnUnmappedWindow() called on mapped window.
        
        As pointed out by Jim in the original patch, using resize_to_request has the same effect and does not cause the aforementioned error.
        
        Change-Id: Ie61e8529fccfdae88d56f223573eb0fd6a82b8b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143261
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-26  Caolán McNamara  <caolanm@redhat.com>  [9bef99518e910db078149bef08e300afc8b4aaf2]

        crashtesting: failure to export various docs to xlsx/docx
        
        e.g. ooo74880-2.ods since:
        
        commit 3f70375cf160841b6140f5f1b2b79af3652897f8
        Date:   Fri Nov 18 12:06:59 2022 +0100
        
            tdf#152069 tdf#108356 PPTX export: fix missing tile properties
        
        bodge a workaround to not crash at least
        
        Change-Id: I23e0fc4e0f7a2c6d0b182945e252470f2338da09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7d86a6db7a64219e599abfbd28464e3f93022929]

        Fix typo
        
        Change-Id: Ief6a37b977f464c50888291ec9764c7b05cba297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143320
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9ac9a510d8162cff3fded1d3d8312d21a677618a]

        Fix typo
        
        Change-Id: I63136468d4c5b5680cf3d7b240943b6029c4f29b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143319
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [79ed78dc85bb28a179a3c38760fa5b9c1158987e]

        Fix typo
        
        Change-Id: I2f93357f2291312e91002fe3b104261a6aee8734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143318
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-26  Bogdan B  <buzea.bogdan@libreoffice.org>  [6bf5dd8faea420aa0dbc7c429952c9868bcadb9e]

        tdf#147906 used std::hypot for Pythagorean addition
        
        Change-Id: I530174e97d9e90318a770b2611354c07dcc9be58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143169
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-26  Jim Raykowski  <raykowj@gmail.com>  [ff1c7080086191a5a7670d20b59936fcb79a91dc]

        tdf#152115 related: Make selected entry stay selected (gtk3 only)
        
        For unknown reason the selected entry loses selection here only for
        gtk3. Swapping the order of the select and scroll_to_row functions
        makes the selection remain selected for gtk3. This patch replaces the
        select and scroll_to_row functions with the set_cursor function which
        makes the focused entry selected and shown in the visible range as
        expected for gtk3 as well as x11 and qt5.
        
        Change-Id: If003afa73851573e61704cc847d7152db90a0d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143207
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a2d15d3358816043016af79588e0eb3bb2fa5ef]

        use more SwFormatAnchor::GetAnchorNode method
        
        as a step towards switching away from using SwPosition inside
        SwFormatAnchor (because SwFormatAnchor wants to do weird stuff with the
        internals of SwPosition)
        
        Change-Id: I1cdbe2fc6623d8fe2bb0c1bc629b570ca4d0cb0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143298
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [cb7153403a55a0e565584aedd8a4dc8da149b08c]

        Unneeded const_cast
        
        Change-Id: I135498592857a624b72db519724e8f189e60e9a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143310
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-26  Mike Kaganski  <mike.kaganski@collabora.com>  [e52cf954a1dcd0f26096fcdb89f068e76c3fa9f2]

        Use reference instead of pointer
        
        Change-Id: I2d15ee96373d21b6501fa956601378d7f698a099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143311
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e76b1faa3326e5cffed4472fcd410b5abf273067]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4630d4825d9cf21dad5e8a491402d91ea1e3c1f
          - Fix path fpr "XML Settings"
            
            Change-Id: I5c27abea351d3fe007da9f83fa323e74a7dee9bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143165
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-25  Theppitak Karoonboonyanan  <theppitak@gmail.com>  [3b0b9fcb80242abcedc01eb388a57b1016916353]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 2b234ba64f43d16b9393fb0cfdc794814065e838
          - tdf#148876 Adding Thai hyphenation patterns
            
            Change-Id: Ib9e6fe6350c6b8a4e9644315717fd744714a271a
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/141961
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2022-11-25  Michael Meeks  <michael.meeks@collabora.com>  [254e56c0c05015db1cbfd20c1e5a48703d3bd136]

        jsdialog: white-list calc group/un-group & row/col metric dialogs.
        
        They're simple dialogs, and are testd.
        
        Change-Id: I5a34314f57e058bc66a718c1e85ed52b265752e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143262
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e9b99ffe0083060176dc782986d3b441b7e48ec]

        tdf#120348: move UItest to CppUnittest
        
        for that, create a new CppunitTest_chart2_uichart
        in chart2
        
        Change-Id: Ie4cdaff4a1dd623c7788ed7acdd5ef135f403e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143305
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [c802c5f390a30a66118f56a01e47772a54743a6a]

        Require valid attribute in getXPath
        
        The reason for accepting empty attribute was eliminated in commit
        2f91ab025de850fe5af8114565755a8deed55911 (Merge two assertXPath
        overloads that both check number of nodes, Nov 25 16:36:57 2022)
        
        Change-Id: I6cd77eb0f73650dfdafd55946b5269ffe3f0bde5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [66e93c7a74af4d7078762ef4f2071e2f8ae15c27]

        Simplification
        
        Change-Id: Ib72d4eb95879f94efad3834b1334099990e76f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143303
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [cdac145768488dc11b32b744bc753ab16aa08c6e]

        reduce cost of SwpHints::Check
        
        Takes it from 20m to 2m on some tests.
        
        Change-Id: Idc02a299ebdffaf4bcd99612e92190f6b9619021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143296
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [debe76298a7d8f24870d176d33d453a3b0d3f3de]

        use more SwFormatAnchor::GetAnchorNode method
        
        as a step towards switching away from using SwPosition inside
        SwFormatAnchor (because SwFormatAnchor wants to do weird stuff with the
        internals of SwPosition)
        
        Change-Id: Ie6d4f45c959f87599d1cd0890ca8a693dd147be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143294
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-25  Justin Luth  <justin.luth@collabora.com>  [432e5e6e33c3687cdb67ee0a64d57169a82e641d]

        tdf#151548 vba ContentControls: Add word::XContentControlListEntry
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        This now allows MS Word's modern content control list boxes
        (combobox and dropbox) to be controlled by VBA basic.
        -allows getting and setting the selected list entry
        -allows adding/deleting/renaming/moving list entries
        
          If .DropdownListEntries.Count <> 3 Then GoTo errorhandler:
          .DropdownListEntries.Item(2).Select
          .DropdownListEntries.Item(2).Delete
        
          If .DropdownListEntries.Item(2).Text <> "infinity"
          If .DropdownListEntries.Item(2).Value <> "infinity and beyond"
        
          'With .DropdownListEntries.Add("third", "3rd", 2)
          Dim LE As ContentControlListEntry
          Set LE = .DropdownListEntries.Add("third", "3rd", 2)
          With LE
            If LE.Index <> 2 Then GoTo errorhandler:
            If LE.Value <> "3rd" Then GoTo errorhandler:
            .MoveUp
            .MoveUp
            .MoveUp
            If .Index <> 1 Then GoTo errorhandler:
            .MoveDown
            .MoveDown
            If .Index <> 3 Then GoTo errorhandler:
            End With 'LE
          If .DropdownListEntries.Item(3).Text <> "third" Then GoTo errorhandler:
          End With 'Item 1
        runOnceDropDown:
        
        With ActiveDocument.ContentControls.Item(4)
          If .Type <> wdContentControlComboBox Then GoTo errorhandler:
          .DropdownListEntries.Clear
        End With
        
        Change-Id: Iffebb2bd69abec1cbcfaed05b58f940664852eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143082
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-25  Miklos Vajna  <vmiklos@collabora.com>  [1e83197fdd4263ca4817a6ac16f274aaee3e66fd]

        comphelper: support property values arrays in JsonToPropertyValues()
        
        Needed for an uncoming .uno:TextFormFields uno command where one of the
        parameters has the []com.sun.star.beans.PropertyValues type at an UNO
        level, and we can't provide JSON at the moment that would express that.
        
        Change-Id: I288a540b2fcac0e5a4a82bca235199c559ba2d0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143302
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd05a0f9ccebaee6f0175281fdeb6fe3f3168fd2]

        CppunitTest_sdext_pdfimport: move it to 'qa' folder
        
        like the rest of folders in the project
        
        Change-Id: Ifb833aa8acedc8549c74383b2d76737d4f425c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143277
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2f91ab025de850fe5af8114565755a8deed55911]

        Merge two assertXPath overloads that both check number of nodes
        
        Change-Id: I67eec623b90ab20330fa0c268152211b6bbdbe1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143301
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-25  Mike Kaganski  <mike.kaganski@collabora.com>  [ec345c02d8fa5a7c7d4ea4ad08ae7be5303d9b20]

        tdf#152200: Make sure to not write objects into field character runs
        
        Similar how it's done for preceding objects immediately after calculating
        'ofs', we also need to make sure to create a separate run for the objects
        that may be anchored after the last character; otherwise, the field that
        was just processed (and is waiting in the attributes) would be put out of
        place, inside an inner run (e.g., in a text box inside the object).
        
        Change-Id: I2702693595acf4befdbd25ef07a9f7c444926aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143297
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [75eb99cec153e720407b44c376285a0c543018b2]

        bump product verion to 7.5.0.0.alpha1+
        
        Change-Id: I565f3fc512b39af5c3b2e65a5cc3109794ca25ba

2022-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [a7a974fda5d8635b5d67c8e7fe71f4c7d83c5797]

        freetype: don't build yet another copy of zlib
        
        Since commit e515267602d9049bc15739a215f43f1379141d81 the zlib that's
        statically linked into freetype conflicts with the zlib that's
        statically linked into Qt5 because both appear to rename the symbols via
        Z_PREFIX to the same names and thus the linker complains about duplicate
        symbols.
        
        Apparently --without-zlib doesn't disable the feature but instead causes
        freetype to use its own copy; just use --with-zlib instead and rely on
        the ZLIB_CFLAGS/ZLIB_LIBS to find LO's bundled zlib.
        
        Change-Id: I0b5684ca6556c3da7874c17ff2da97b2753b0262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143289
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [654bd3a0ec480b3aab6571fbf1a607fc0bf6b11c]

        Revert "external/freetype: Avoid duplicate zlib symbols"
        
        This reverts commit e515267602d9049bc15739a215f43f1379141d81.
        
        Reason for revert: freetype should not build its own copy
        of zlib in the first place. See follow-up patch.
        
        Change-Id: Iab9205144bcd261701350fe088a3da187ab0aadd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143258
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Miklos Vajna  <vmiklos@collabora.com>  [24219cc1e9829f82a533667aef0f51b6a7df6fc2]

        sw lok, .uno:TextFormFields: expose field code of fieldmarks
        
        The fieldmarks in a document were kind of invisible for LOK clients
        previously.
        
        The Zotero use-case requires a way to fetch certain types of fieldmarks
        from a document, to be able to update them and then write back those
        updated versions to the document later.
        
        Fix this by introducing a new .uno:TextFormFields, you can get its value
        using the getCommandValues() LOK API. This allows filtering for a
        certain field command prefix, which is generic, but e.g. in the Zotero
        case allows getting the citations or the bibliography. The returned JSON
        is an array of matching fieldmarks, containing their type and field
        command. It seems there is no way to return the field result, till the
        motivation is to just update that field result. (If there will be need,
        the field result can be added.)
        
        Do this in a way that next time we add a Writer-specific command (to be
        able to return its values), there will be no need to touch
        include/vcl/ITiledRenderable.hxx, causing a large rebuild.
        
        Change-Id: I2ef1159bec4034bbdd6b4ba00715a69423106edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143275
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-25  Caolán McNamara  <caolanm@redhat.com>  [534d43ac5b51c57c01f275d6ecb320ee9e51000a]

        ofz#53349 Timeout
        
        Change-Id: I9381aa819dadd823b9e71212f7dd14ea0047ef5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-25  Caolán McNamara  <caolanm@redhat.com>  [e10e5981ca020af11d25d5756964c95d51dd1535]

        tdf#152183 update settings when dark/light system mode toggled
        
        Change-Id: I2273d79d2703ebd7a021bdca1737f5fb9fa9bc32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143284
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [9206895999f36a8199862912afe0ca91462e914a]

        sdext: remove unused document
        
        it was added in bc48dbe08db537f41e42839a0493317298606413
        "sdext.pdfimport: Use string() in xpath for testTdf104597_textrun"
        for no reason
        
        Change-Id: I58abed336cb4c8ca5cfe488f81fbf2332ff43c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143278
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-25  Maxim Monastirsky  <momonasmon@gmail.com>  [423c2a6ac74cd30c6576e6794f67fda4fb685c11]

        sd: better detection of user defined cell styles
        
        Cell style might be used for several table roles
        at once, or even in several table styles (esp.
        after new/clone actions). But when we're editing a
        style, we want just a single place to be changed.
        
        The initial solution was to check if the style is
        user defined. The problem is that if we change the
        built-in styles set, then documents created with
        the old styles will have their once built-in styles
        turned into user defined. In such case we might
        still attempt to edit a shared style, which is
        unintended.
        
        So try harder, and check also that the style isn't
        used twice and that there is no other styles
        inheriting from it.
        
        Change-Id: I67d8c61b15161c9d839e97f7a31a1349a7e2613c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143288
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [18d1ab257376dfce02558a0a06136b0db33a6b06]

        Update git submodules
        
        * Update translations from branch 'master'
          to f1680ed534269a7a9a4f7ca2b389901a64f0bb4a
          - update translations for master/7.5.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: Ia3be119e9ae888412428f3c9eb6db2ad3f928414
            
2022-11-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [42da7674685c1a82fd655f19c2665030f41d5929]

        vcl: list the glyphs and bound rects of a specified font
        
        Change-Id: Ia635d83a5d3dd257948777e9f6976fecfeb4ee98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141526
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Tibor Nagy  <nagy.tibor2@nisz.hu>  [c4d7b9c3ec6e44b96134fdfb036be7f9fcf39f9d]

        tdf#70293 XLSX export: fix lost grouping of shapes
        
        SaveDrawingMLObjects() needs to skip all
        the grouped objects, including subgroups
        of a group to avoid of broken export. Fixing
        this and reverting the old workaround
        commit c323e60157422ae264e798b9a279a532fe9997af
        "ignore the (unsupported ) group customshape when exporting xlsx",
        Calc keeps the grouped state of the objects now.
        
        Change-Id: Ic320248a1c646d8adb9ce55bb2e5dcd880c1df6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143142
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-25  Caolán McNamara  <caolanm@redhat.com>  [e92d0ec198bc81858604dca2b73ead82bfac6cec]

        hb_draw_funcs_t needs harfbuzz >= 4.0.0
        
        Change-Id: Ic84fcee9034865de42f1018d2358c19c5bd9b463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143276
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd4b54bb4e73e4c0af3b2efb25d0ee929d7dfe28]

        Fix typos
        
        Change-Id: I9d22e4a2140f5195d3829e6289ddf3d2f79b632e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143281
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [0b3ef02e8b5bbf7ca76ec4c46c0bd5b5651723bb]

        SwModelTestBase: use createSwDoc
        
        in order to unify the code
        
        Change-Id: Iedeff59cc45775c80844e8e030f61354325399da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143282
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-25  Bogdan B  <buzea.bogdan@libreoffice.org>  [d96d1b380d3c626522407397e56d68030a73e02a]

        tdf#141438 Clean old comments //FEATURE::CONDCOLL
        
        Change-Id: I350a9c0a033edddf805170534561b6dca0bf5ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143172
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [7fffb4b80c7279e96385086f068e9426579c916b]

        vcl,sw: PDF/UA export: add BBox to text frames too
        
        Change-Id: I6d6663520c3946eabb9bbb184899b0c4420732d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143248
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [122b4264d23df8b11419839ba700b88c4f936a6c]

        tdf#57423 sw: PDF/UA export: Alt texts for SwNoTextNode
        
        * Specification: ISO 14289-1:2014, Clause: 7.3, Test number: 1
        Figure tags shall include an alternative representation or replacement
        text that represents the contents marked with the Figure tag as noted in
        ISO 32000-1:2008, 14.7.2, Table 323
        
        This was broken by the previous commit, which tied ObjectInfoPrimitive2D
        evaluation to StructureTagPrimitive2D, and is restored now, perhaps
        less elegantly.
        
        * Specification: ISO 14289-1:2014, Clause: 7.7, Test number: 1
        All mathematical expressions shall be enclosed within a Formula tag as
        detailed in ISO 32000-1:2008, 14.8.4.5 and shall have Alt or ActualText
        attributes
        
        Haven't checked but it's possible that this worked before commit
        2840352ba56a212d191cc16e08378c87672d7b73 - for SwOLENode embedded
        objects, no ObjectInfoPrimitive2D is created apparently.
        
        Change-Id: Ia0077199601f39f666012d31883f63cff115716f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143247
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [78681cd0829dcb6a73690e1a63ae3808d297677a]

        tdf#57423 drawinglayer: PDF/UA export: more Alt texts for SdrObjects
        
        Currently /Alt texts are generated from ObjectInfoPrimitive2D, but this
        is only evaluated in VclMetafileProcessor2D::processGraphicPrimitive2D()
        so while it's created for every SdrObject, it's ignored in most cases.
        
        There doesn't appear to be a reason why this is done in
        processGraphicPrimitive2D() and not a more generic location, the special
        conditions that are checked there don't have anything to do with Alt
        texts, they effectively guard some optimisation done to bitmaps in
        PageSyncData::PlaySyncPageAct().
        
        There is another issue in that not every SdrObject gets a
        StructureTagPrimitive2D, and even if there is a StructureTagPrimitive2D
        it may be ignored if it's in the background.
        
        The Alt text must only be produced if there is a structure element for
        the same SdrObject, else it would end up on some unrelated structure
        element.
        
        Fix all this by moving processing to a new function which checks that
        there is a current StructureTagPrimitive2D for a SdrObject in effect.
        
        The only problem with this is that previously Writer images produced Alt
        text, and now they don't - but Writer needs some fixing anyway.
        
        Change-Id: I2a362e8a9cd93e5bc817c6eed546c46b46e14980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143189
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-25  Fred Kruse  <fred.kruse@gmx.de>  [5f249506ff2eddeaac47d521509bf1dde0b58d01]

        tdf#151801 solves bug for autocorrect non default quotes
        
        Regards German and some other languages. A bug in the mechanism to distingish between apostroph and single end quote is solved.
        Now, it works also for user defined quotes, like a single angle quote ('French' quote).
        
        Change-Id: Ib4beca7a4304d57d7fdf977c20cf62410be3d2c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142662
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc6aa9e49973c845915754caf765ff57e5b0cd59]

        fix assert
        
        finger trouble in
            commit c757117afb398277a46e79ba22066c5bbf2c9f72
            tdf#81765 slow loading of .ods with >1000 of conditional formats
        Spotted by sberg.
        
        Turns out my original idea idea with the assert was too restrictive,
        so make the check a little smarter.
        
        Change-Id: Ie735d00c87a05a70e8a71f03e75043dcd8dfc88f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-25  Stephan Bergmann  <sbergman@redhat.com>  [090fafaaaa1d8ccf5f7b17b7b6f2a85b3fafa0c5]

        -Werror,-Wunused-private-field
        
        ...introduced in 24d7431876e87eba700a9f141dc8e030143a92ad "tdf#151548 vba
        ContentControls: Add basic word::XContentControl", presumably in error
        
        Change-Id: I734b8046de7127f68d43b805e2faa6c0106c0cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143274
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-25  Stephan Bergmann  <sbergman@redhat.com>  [a534361141d69096d896e6e0552d19f3138eeeb3]

        Fold OldBasicPassword into basic::SfxScriptLibraryContainer
        
        Change-Id: Iaeaf30f63760185a2b1dd72feb980b94d9931d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143253
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-25  Caolán McNamara  <caolanm@redhat.com>  [da4a0d1520c501b5f8a4c3385cdc5f76653213f4]

        add in latest harfbuzz effort
        
        the document still fails for me, but in a new way which suggests
        a possible problem on our side.
        
        Change-Id: Ic38259653a43b39f9330adc503d085a896c15d2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143246
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-25  Kevin Suo  <suokunlong@126.com>  [3a2f0e4772e7b4646dd518b33aeafb6fd7025179]

        Resolves tdf#152083: Ligatures are incorrectly reversed in Draw pdf import
        
        For the string "بسم الله الرحمن الرحیم", the xpdfimport generates the following drawChar tokens:
        drawChar 438.500000 723.300000 446.744000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 م
        drawChar 446.696000 723.300000 450.908000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ی
        drawChar 450.896000 723.300000 458.804000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ح
        drawChar 458.792000 723.300000 463.784000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ر
        drawChar 463.688000 723.300000 467.048000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ل
        drawChar 467.072000 723.300000 469.964000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ا
        drawChar 469.964000 723.300000 473.708000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000
        drawChar 473.756000 723.300000 482.780000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ن
        drawChar 482.756000 723.300000 490.028000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 م
        drawChar 490.040000 723.300000 497.948000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ح
        drawChar 497.936000 723.300000 502.928000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ر
        drawChar 502.928000 723.300000 506.288000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ل
        drawChar 506.312000 723.300000 509.204000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ا
        drawChar 509.108000 723.300000 512.852000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000
        drawChar 512.900000 723.300000 527.216000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 الله
        drawChar 527.204000 723.300000 530.948000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000
        drawChar 530.996000 723.300000 539.240000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 م
        drawChar 539.288000 723.300000 552.020000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 س
        drawChar 551.888000 723.300000 555.236000 723.300000 1.000000 0.000000 0.000000 1.000000 12.000000 ب
        
        Previously, all the above are combined to a single text frame in DrawXmlOptimizer::optimizeTextElements,
        and then the text in the text frame is reversed (commit 69e9925ded584113e52f84ef0ed7c224079fa061, and
        further improved by commit 50d73574b6c3d71f9a539c895a15d6fcda22390b).
        
        The problem is that, the single token "الله" was already in correct order. Thus when it is reversed
        together with others, the order for itself would be wrong. Fix this by doing a pre-reverse.
        
        The space char needs special treatment, as observed in tdf104597_textrun.pdf.
        
        Change-Id: If0bd716cc2d68820436d0e3f0f161ffb9cb4397a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-25  Miklos Vajna  <vmiklos@collabora.com>  [bfee63e502f341f0bd039189f2d7492529c4340a]

        sw: document SwFramePage
        
        Which has nothing to with SwPageFrame. SwPageFrame is a page in the
        layout, SwFramePage is a tab page in a dialog.
        
        Change-Id: I4a88bcfb9e1aab541f099c4f6d84501610105f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143245
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-25  Szymon Kłos  <szymon.klos@collabora.com>  [a5c1cbcbb506e1c33c7e80673bfc01a34c834ed5]

        pdfium: reduce size if cannot create bitmap
        
        In files with large pages it was rendering white, empty
        content. That was because bitmap creation in the PDFium
        failed. This reduces the size to possible value.
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I093a6aff94104cdc8223d7b8cbc00ff9217021b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143037
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143243
        Tested-by: Jenkins

2022-11-24  Justin Luth  <justin.luth@collabora.com>  [24d7431876e87eba700a9f141dc8e030143a92ad]

        tdf#151548 vba ContentControls: Add basic word::XContentControl
        
        This adds basic VBA macro support for accessing
        the modern content controls used for creating forms.
        
        I ran out of time to make it fully functional.
        
        TODO
        -Invalidation: the screen isn't updating the modified results until
         interaction from the user (mouse click, etc.)
        -Unlike FormFields, content controls really depend on having
         Range working. I didn't have time to look into that.
        -I was hoping to check that my approach could accommodate the other
        methods that create a filtered ContentControls object:
         * Document.SelectLinkedControls,
         * Document.SelectUnlinkedControls
         * Range.ContentControls.
         I guess it will be left up to whoever needs these to add the bits
         that will create an appropriate collection for these limited sets.
        -setType: changing one type to another - both LO and Word allow
         limited use of this - depending on the text contents fitting
         the new type.
        
        What works:
        -getByIndex - which probably is the "normal" way to do it,
         since the UI doesn't provide a name/ID; just got via msgbox .ID.
        -full checkbox support (minus the visual invalidation)
        -VBA accepts almost all properties/methods that are requested.
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        If Not ActiveDocument.ContentControls(1).Checked
        If ActiveDocument.ContentControls(2).Checked
        'If ActiveDocument.ContentControls(2).Range.Text <> "$"
        ActiveDocument.SelectContentControlsByTag("checkboxes").Item(1).Checked
         = ActiveDocument.SelectContentControlsByTag("checkboxes").Item(2).Checked
        ActiveDocument.SelectContentControlsByTag("checkboxes")
         .Item(2).SetUncheckedSymbol (8364) '€
        
        With ActiveDocument.SelectContentControlsByTitle("listbox").Item(1)
          If Not .ShowingPlaceholderText
          'If .Range.Text <> "Choose an item."
          If .Type <> wdContentControlDropdownList
        End With
        
        With ActiveDocument.ContentControls.Item(5)
            'If Not .Temporary Then GoTo errorhandler:
            If .Temporary <> False Then GoTo errorhandler:
            If .Tag <> "" Then GoTo errorhandler:
            If .Title <> "" Then GoTo errorhandler:
        End With
        
        With ActiveDocument.ContentControls.Item(6)
            If .Type <> wdContentControlText
            If .MultiLine Then GoTo errorhandler:
            If ActiveDocument.ContentControls.Count <> 7
            .Delete 'Doesn't actually Delete in LO yet - unsafe
           ' If ActiveDocument.ContentControls.Count <> 6
        End With
        
        ' Change to 6 when delete is working safely
        With ActiveDocument.ContentControls.Item(7)
            If .Type <> wdContentControlDate Then GoTo errorhandler:
            .Color = wdColorBlueGray 'unknown to Word 2010
            If .Color <> wdColorBlueGray Then GoTo errorhandler:
            If .DateDisplayFormat <> "mm/yy/dd" Then GoTo errorhandler:
            If .DateCalendarType <> wdCalendarWestern Then GoTo errorhandler:
            If .LockContents <> False Then GoTo errorhandler:
        End With
        
        Change-Id: I1c636f671de81e0283c040a578838a0433ef1f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143080
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [b789f54cb0bb2ae2f1d2cba3b3e5920085c8696d]

        external/poppler: Fix use of std::char_trait<unsigned short>
        
        ...now that it is gone from libc++ 16 trunk since
        <https://github.com/llvm/llvm-project/commit/aeecef08c385b1e4955155dd649a2d3724463849>
        "[libc++] Remove default definition of std::char_traits", causing
        
        > In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
        > In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24:
        > In file included from sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36:
        > In file included from workdir/UnpackedTarball/poppler/poppler/GfxState.h:41:
        > In file included from workdir/UnpackedTarball/poppler/poppler/Object.h:43:
        > In file included from workdir/UnpackedTarball/poppler/goo/GooString.h:46:
        > ~/llvm/inst/bin/../include/c++/v1/string:676:46: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
        >     static_assert(( is_same<_CharT, typename traits_type::char_type>::value),
        >                                              ^
        > workdir/UnpackedTarball/poppler/cpp/poppler-global.h:101:43: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
        > class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short>
        >                                           ^
        > ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is declared here
        > struct _LIBCPP_TEMPLATE_VIS char_traits;
        >                             ^
        > In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.cxx:20:
        > In file included from sdext/source/pdfimport/xpdfwrapper/pnghelper.hxx:24:
        > In file included from sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:36:
        > In file included from workdir/UnpackedTarball/poppler/poppler/GfxState.h:41:
        > In file included from workdir/UnpackedTarball/poppler/poppler/Object.h:43:
        > In file included from workdir/UnpackedTarball/poppler/goo/GooString.h:46:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/string:576:
        > ~/llvm/inst/bin/../include/c++/v1/string_view:279:45: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
        >     static_assert((is_same<_CharT, typename traits_type::char_type>::value),
        >                                             ^
        > ~/llvm/inst/bin/../include/c++/v1/__type_traits/is_convertible.h:30:66: note: in instantiation of template class 'std::basic_string_view<unsigned short>' requested here
        >     : public integral_constant<bool, __is_convertible_to(_T1, _T2)> {};
        >                                                                  ^
        > ~/llvm/inst/bin/../include/c++/v1/string:650:7: note: in instantiation of template class 'std::is_convertible<const std::basic_string<unsigned short> &, std::basic_string_view<unsigned short>>' requested here
        >       is_convertible<const _Tp&, basic_string_view<_CharT, _Traits> >::value &&
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/string:967:35: note: in instantiation of template class 'std::__can_be_converted_to_string_view<unsigned short, std::char_traits<unsigned short>, std::basic_string<unsigned short>>' requested here
        >             class = __enable_if_t<__can_be_converted_to_string_view<_CharT, _Traits, _Tp>::value &&
        >                                   ^
        > ~/llvm/inst/bin/../include/c++/v1/string:969:93: note: in instantiation of default argument for 'basic_string<std::basic_string<unsigned short>>' required here
        >   _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS _LIBCPP_CONSTEXPR_SINCE_CXX20 explicit basic_string(
        >                                                                                             ^~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/string:657:7: note: while substituting deduced template arguments into function template 'basic_string' [with _Tp = std::basic_string<unsigned short>, $1 = (no value)]
        > class basic_string
        >       ^
        > workdir/UnpackedTarball/poppler/cpp/poppler-global.h:101:26: note: while declaring the implicit copy constructor for 'ustring'
        > class POPPLER_CPP_EXPORT ustring : public std::basic_string<unsigned short>
        >                          ^
        > ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is declared here
        > struct _LIBCPP_TEMPLATE_VIS char_traits;
        >                             ^
        
        Change-Id: Ia1dfda1866ffac22b1c8c99eb11412c095bcc4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143237
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [9a7945f36ce95a48e0d525bc444e722b9ec5c452]

        tdf#152200: tolerate begin/end fldChar context mismatch
        
        We generate such files currently. Fixing that will be another commit.
        
        Change-Id: I788501e346cba63c08a767c0e05e063bc1172089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143223
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-24  Jan Holesovsky  <kendy@collabora.com>  [ab080ab1ab3100d9702a745287566b78b8d59e54]

        tdf#152199: Don't crop twice
        
        We have a "GraphicCrop" property that is supposed to roundtrip the
        cropping in OOXML, but there is no core feature backing it (ie. the
        image is not shown cropped when this is imported and set).
        
        Instead, to show the image "cropped", we crop the image physically on
        import (throw away pixels that are 'outside' of the cropped area).
        
        But - the "GraphicCrop" is then saved on export, together with the image
        already physically cropped, which leads to garbled DOCX on re-import.
        
        Given that the core feature to show image cropped when the "GraphicCrop"
        is set, let's avoid setting it when we physically crop the image.
        
        Change-Id: Ia1090ea9c6d22e60c77d52bf65281f6588d07d4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143216
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2022-11-24  Bogdan B  <buzea.bogdan@libreoffice.org>  [1e9ace4c35e4206c24ded230433915850a1f04d1]

        tdf#147906 used std::hypot for Pythagorean addition
        
        Change-Id: Ie835faef0d66a9a34b007fdea847eb0f54da9068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143167
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [f1d5143c2f66936104f8236cc83417853d39f873]

        Resolves: tdf#152157 show update icon on all menubars
        
        and not just the active one, so they are of a consistent height with
        eachother. BubbleWindow is only shown for the active one.
        
        Change-Id: I157c8c8b0e2a219c20ffde01ec4a04ba93b7f0e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [ebe151d919a454f98c36013245bca9eb41d92707]

        ScSimpleBootstrapFixture -> ScUcalcTestBase
        
        Change-Id: I69def1dccf4f1f35ef1ab14436fc71493b75eb6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143242
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e8c78c9d636a1ac26a146bdf37469477f62e71f9]

        qahelper: drop getTokens and toString
        
        Change-Id: I15f6af9fc6e7f90a1a404e90d5f6ceba4c78626f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143240
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [111ec417d2289b6231216650ccacbb1b7a35268e]

        sc: fix todo
        
        When I change CppunitTest_sc_subsequent_export_test to
        inherit from UnoApiXmlTest in
        a865d042eff3cdd4d78badcc55c9d8fdf9ef52aa
        this test started to fail with
        
        * testTdf90299 fails now with
        - Expected: 'file:///tmp/lu23738863wthph.tmp/dummy.xls'#$Sheet1.A1
        - Actual  : 'file:///tmp/lu23738863wthph.tmp/lu23738863wthpg.tmp/dummy.xls'#$Sheet1.A1
        
        For now, move it to filters-test.cxx to use the old way
        to load and save the documents so the test doesn't fail.
        
        Change-Id: Ibccbc4a422a7374be7c4b09fbec3985b52b8b140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143239
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a6697313d2bcecc4f45626a66c85825a4430cc7]

        qahelper: remove unused namespace
        
        Change-Id: I4488119471009e15887567fb485834efc4abdb45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143236
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [28b06bb7236f8c6e17423dc3df446306900355f1]

        tdf#149140 vcl: PDF/UA export: Scope attribute exists since PDF 1.5
        
        (regression from commit dfffe710d07f84f4152cf61ccd4a69279a26ff7c)
        
        Change-Id: I12e077d857d25db9636f2a06f953616ae2d907bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143209
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-24  Leonid Ryzhov  <leoryzhov@gmail.com>  [6379414ca34527fbe69df2035d49d651655317cd]

        tdf#146479 Use basegfx fTools for converting the angle unit
        
        Change-Id: I6128262cb0572b267e232f7a647e1c68f5144e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143047
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [493a714d4a62f78a4726d09d3258c425939c94c3]

        pass SwFormatAnchor to SwFEShell::CalcBoundRect
        
        part of the process of making SwFormatAnchor not use an SwPosition
        (because SwFormatAnchor does weird does with the internals of an
        SwPosition)
        
        Change-Id: I1694ae83070082f10699aa7b3bd2a043c518d0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143227
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [46eb2fa586b683858dc35cc535e0f30108b1cdbe]

        hwpfilter: Fix use of std::char_trait<unsigned short>
        
        ...now that it is gone from libc++ 16 trunk since
        <https://github.com/llvm/llvm-project/commit/aeecef08c385b1e4955155dd649a2d3724463849>
        "[libc++] Remove default definition of std::char_traits", causing
        
        > In file included from hwpfilter/source/formula.cxx:20:
        > In file included from hwpfilter/source/formula.h:23:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/xml/sax/XDocumentHandler.hpp:6:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/xml/sax/XDocumentHandler.hdl:6:
        > In file included from workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:6:
        > In file included from include/com/sun/star/uno/Any.h:30:
        > In file included from include/rtl/ustring.hxx:34:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:170:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/bitset:131:
        > ~/llvm/inst/bin/../include/c++/v1/string:676:46: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
        >     static_assert(( is_same<_CharT, typename traits_type::char_type>::value),
        >                                              ^
        > hwpfilter/source/hwplib.h:47:10: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
        >     if (s.length() > o3tl::make_unsigned(std::numeric_limits<sal_Int32>::max())) {
        >          ^
        > ~/llvm/inst/bin/../include/c++/v1/__fwd/string.h:22:29: note: template is declared here
        > struct _LIBCPP_TEMPLATE_VIS char_traits;
        >                             ^
        
        Change-Id: Ied437a079cb66c8b49f9980ab29b59ec5e2097d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143238
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e328476c6c8793733ce87635d38869d99a7149da]

        ScBootstrapFixture: move to their own file and rename class
        
        Change-Id: Ib3222f119f67b77b9c67269a6040301a44c7c5b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143232
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [5dbb85ca6abfbc2b5353da1e3eb36c426fb62305]

        split RemoveBubbleWindow
        
        Change-Id: I635bb587b7306bc5f5756a0c24260f10587cc4c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [cc72616cb689f8d40d7b40458e481c9fe7b8c051]

        -Werror,-Wunused-private-field
        
        ...after a80239ede3236c84d7a05d0fbc0f299811fee6c0 "vcl: move creating DWFontFace
        to WinFontFace"
        
        Change-Id: Idb913ff524d9a2f462e521eeb7bcfad57d388455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143230
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  László Németh  <nemeth@numbertext.org>  [386402ded6db4614c943c94f6e68bc1de1a38fe6]

        tdf#151954 DOCX import: fix text moving before paragraph end
        
        Tracked text moving before paragraph end was extended
        to the paragraph end, too.
        
        Follow-up to commit 11071d95f4f3cbe578c3393729c42b7cce011b45
        "tdf#149711 sw_redlinenum DOCX: import moveTo paragraph mark"
        and commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be
        "tdf#123460 DOCX track changes: moveFrom completely".
        
        Change-Id: I668a3ef83482bded9ab94dcd0111f8ed05e8471c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143231
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-24  Tibor Nagy  <nagy.tibor2@nisz.hu>  [3f70375cf160841b6140f5f1b2b79af3652897f8]

        tdf#152069 tdf#108356 PPTX export: fix missing tile properties
        
        of background image patterns defined by a:tile.
        
        Note: factor "3.6" comes from EMU.
        
        Change-Id: I5da532ff9ad63fd6c236a58933a31dcd96cf5156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142913
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-24  Miklos Vajna  <vmiklos@collabora.com>  [574db5efa9a2ab6d70faedf538be77a1eb8c597b]

        Related: tdf#54053 PDF export: add UNO API to customize the watermark rotation
        
        The watermark direction is currently either 0 degrees for landscape
        pages or 270 degrees for portrait pages.
        
        The problem is many people expect 45 degrees rotation angle or some
        custom angle in general, and we provide no way to control it.
        
        Fix the problem by adding a new "WatermarkRotateAngle" PDF export filter
        option to specify the rotation angle explicitly. Note that the watermark
        text is still centered, and the text size is decreased to still fit the page
        boundaries. To keep things simple, do this shrinking by going with a
        size that matches the shorter dimension of the page, instead of some
        more complex iterative approach.
        
        Example cmdline usage:
        
        soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkRotateAngle":{"type":"long","value":"450"}}' test.odt
        
        Change-Id: I1fee14c333e68c92cf4c65ec100e04dcf024f907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143229
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [e09823b549699a9f32b1b0d7621301117306cdc3]

        ScBootstrapFixture: no need to pass basestring anymore
        
        Change-Id: I58ce96af149eb2b7f4d357383b73ec4b1d1b51bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143224
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [f150727f5df4afdaec13ffb9e80dfc8add9e268c]

        ScBootstrapFixture: drop loadDoc and FileFormat
        
        also move createFileURL where is used
        Change-Id: I803706885a1efcb7239f7918fe6a94ccb394bcfe
        
        Change-Id: I2477cecf9ce93d104bd026a2e1d5d503bf6acf9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143220
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [96aa8a8f1c4ec2b038f0eb486c7e5c240c0092a2]

        relax glyph assert wrt layout equivalency
        
        as per: https://github.com/harfbuzz/harfbuzz/issues/3888
        
        Change-Id: I6e5a36fd0a5f4a3ceb979372d0f5d53ee5f65b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143218
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [c84ffb6114ddb30f474cc87bbd6ad9b591173353]

        add some notes on how to debug online update from a dev version
        
        Change-Id: I7b4547bfee4ff0bd3bbe7366b6294e925852ce65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143221
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a2abff1b0167ce2380e538562755da666c6753b]

        return SwNode from SwContact::GetContentAnchor
        
        part of the process of making SwFormatAnchor not use an SwPosition
        (because SwFormatAnchor does weird does with the internals of an
        SwPosition)
        
        Change-Id: I662f977214b70fa7eb37e460e4535e14e8a3fe28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143222
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [3de6d4d3c7b733fde0feef3d77aeb7c4c48724d0]

        loplugin:unusedfields make some fields private
        
        this is one of the secondary analyses this plugin performs
        
        Change-Id: I022b9eda994acbd25714025b666194266e896640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [da5377c88a26b167e94c030e8c8ac5251497e43b]

        CppunitTest_sc_opencl_test: inherit from ScModelTestBase
        
        Change-Id: I53b8564a8fa7ebdc6ec4214a2cecd2917105a777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143186
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [ae72d9cc7b9d70df06172a916ec35a5282ef2447]

        backport recent libreoffice-related harfbuzz fixes
        
        Change-Id: I1ff1b6291e9799d95477334f2726132ddc99442f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143208
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [32720b4744c24df08a45fca19784331c79bb3848]

        Add missing enum value to config
        
        Option was added in eb1c0480050a1328287c4a85468afbec50b0e29d
        
        Change-Id: I2b6f7573d00d9fa5c6066ad762b6fa3262a9a8d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143204
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [49fa5640f4ef262141594c4d7d86127afa4ff6a7]

        sc: drop testEqualsWithTolerance
        
        Change-Id: I588bf862a21559f84b58e3af854f43e73dccfe7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143212
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd90710a0acd58ac76bdbe9809382fa266733167]

        add SwFormatAnchor::GetAnchorNode method
        
        as a step towards switching away from using SwPosition inside
        SwFormatAnchor (because SwFormatAnchor wants to do weird stuff with the
        internals of SwPosition)
        
        Change-Id: I1527b6585d1e130b46e1e51b1e40eea043339d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [febf6795f68efcdc05a4bcb19a2b6636226b026d]

        Make some date functions inline constexpr
        
        Change-Id: Ibef0f650ce66030f28b59e4818f549d86415e2d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143198
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [4dc372c87b194c32597eda6a7f99ddcee3108fa6]

        Expansion of $(dir ...) always ends in a slash, no need for an additional one
        
        Change-Id: I06172beeeccffd54feb1e1083f0ceef203423ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143206
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [8467aa93e2038b3030e1add94e0ca6cc4ad44032]

        Replace a dynamic_cast with UNO_QUERY
        
        Change-Id: Id50f09150fc2c235787c51361d00416119e11937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143201
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [8858962ec09478c203d43feb58f550bb36af37bb]

        Introduce ParagraphProeprtiesPropertyMap
        
        StylePropertyMap and ParagraphPropertyMap should be has-a, not is-a
        ParagraphProperties.  (I came across this with a tentative new loplugin flagging
        uses of dynamic_cast that implement cross casts between unrelated classes.  This
        would silence that plugin, but also IMO makes intent more explicit here.)
        
        (And PropertyMap and ParagraphProperties no longer need their base classes to be
        virtual now.)
        
        Change-Id: Id89547f7824262b80e8a23c9c1d5ea6406dfcc9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143203
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [4521cb0c409036036f1340e3ffc4e8f113091ecc]

        Drop redundant -Wnon-virtual-dtor
        
        Inspired by
        <https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607102.html> "[PATCH]
        doc: -Wdelete-non-virtual-dtor supersedes -Wnon-virtual-dtor", drop explicitly
        enabling -Wnon-virtual-dtor in favor of -Wdelete-non-virtual-dtor, which is
        already enabled by -Wall.
        
        (-Wdelete-non-virtual-dtor first appeared in Clang 3.0,
        <https://github.com/llvm/llvm-project/commit/8bd428574c717e68a8274739d2ba0f6dc16fd0fb>
        "Add new warning that warns when invoking 'delete' on a polymorphic, non-final,
        class without a virtual destructor", and GCC 4.7,
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=014ab419efc12a59efebd2720d79e1c055675c85>
        "invoke.texi: Document -Wdelete-non-virtual-dtor. [...]")
        
        Dropping the explicit setting of -Wnon-virtual-dtor (and nowhere setting it
        implicitly via -Weffc++) means we can get rid of lots of places that either set
        -Wno-non-virtual-dtor or use some pragma to ignore -Wnon-virtual-dtor.
        
        (In various places across extensions/source/activex/ and winaccessibility/, the
        commits f26996bd3398afa789a5491968244563ccf70908 "Silence
        -Werror,-Wnon-virtual-dtor in generated so_activex.h (clang-cl)" and
        c6086ca6535692496fbd718d174d8eb5a5dea7c7 "Silence -Werror,-Wnon-virtual-dtor in
        generated UAccCOM.h (clang-cl)" had singled out some includes to wrap them in
        pragmas.  Now that those pragmas are gone again, move those includes back to
        where they had been prior to being singled out.  And the -Wno-non-virtual-dtor
        in external/firebird/macos-arm64.patch.0 appeared first in
        ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 "Make firebird build for macOS on
        arm64", which, though it doesn't state it explicitly, apparently created that
        patch's builds/posix/prefix.darwin_arm64 as a copy of firebird's already
        existing builds/posix/prefix.* files, which routinely include that warning
        option too, so keep it there too even if it is probably irrelevant throughout.)
        
        Change-Id: I7e4fa9f2c07e267b2ed15607905027f6b78142f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143182
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Stephan Bergmann  <sbergman@redhat.com>  [6571ab41ec5ce496f151bc4c5eaa8c4a52087e7f]

        No need for the base class to virtual here
        
        Change-Id: Ie8078340ece235c52529770bf393b264d8ca31db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143202
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b442d7fae17660b3665da2c1f7a084341987693]

        tdf#148435 - avoid strange OS/X deadlock around AnyInput.
        
        Apparently calling AnyInput on Mac and filtering for just input, gives
        you window creation / re-sizing events which then trigger idle paint
        events which then deadlock if called with the scheduler lock.
        
        So just don't do this optimisation.
        
        Change-Id: I2b518fba607815241d3bd60407cdf51a4357aef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Miklos Vajna  <vmiklos@collabora.com>  [c130063895c7a733ad121db1bf5fbceac38f6ad5]

        Remove some unused includes
        
        Mostly com/sun/star/frame/Desktop.hpp is unused after inheriting from
        UnoApiTest.
        
        Change-Id: Ifba307353a11a14e033a230a291314bee86b51c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143190
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-24  Jim Raykowski  <raykowj@gmail.com>  [8ba1c4e27376cbd73892768d1e741067918eb897]

        tdf#152165 Improve the 'Read-only Content' dialog message
        
        This patch implements user j.a.swami's suggested improvement of the
        messages shown in the 'Read-only Content' dialog when trying to
        delete a selection in the document that has folded content. In doing
        so, repeated code to create and run the dialog at each place it is
        used is replaced by a single function call.
        
        Change-Id: If79298e0ee920e60620934f1eacc98c776e5d33e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143132
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1fad7043a7286d5d9bb33c9ed9235f044d92aed]

        loplugin:unusedfields make some fields private
        
        this is one of the secondary analyses this plugin performs
        
        Change-Id: I6fac8c926b53f1d909c5b183304744126549f2bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4504d6ddf1b466ae069e7fa0c97f93b74ed0f724]

        loplugin:unusedfields make some fields private
        
        this is one of the secondary analyses this plugin performs
        
        Change-Id: I1c496e234513362338600180e51f7e71e605a7cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-24  Caolán McNamara  <caolanm@redhat.com>  [651658d37bcb3f493942dd5d0b9a0d65c96f105c]

        ofz#53673 Integer-overflow LogicWidthToDeviceCoordinate takes Long anyway
        
        Change-Id: I840ad3242ce434e841cd4159c2e7f0b146168138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143193
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Khaled Hosny  <khaled@aliftype.com>  [164d717530aff8d2581d0a2ff249f83aabb27502]

        tdf#108497: instantiate variable fonts in PDF
        
        Draw the outlines as PDF Type 3 glyphs until we can use HarfBuzz
        subsetter to instantiate the fonts before embedding.
        
        Change-Id: I811eaa8f7e5875db2eeb3755d69616242e263ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142028
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-23  Julien Nabet  <serval2412@yahoo.fr>  [ab09eceb3f5eae6a3e6eeb39d99739684e20363b]

        tdf#152187: CRASH when opening Properties tab of Text Portion in UNO Inspector
        
        relevant part of bt:
        5  0x00007fa6fa5cdc0b in std::_Optional_base_impl<com::sun::star::uno::Any, std::_Optional_base<com::sun::star::uno::Any, false, false> >::_M_get() const (this=0x558f064c4508)
            at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/optional:484
        6  0x00007fa6fa5ccf95 in std::optional<com::sun::star::uno::Any>::operator*() const & (this=0x558f064c4508) at /usr/bin/../lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/optional:970
        7  0x00007fa6fa5c8c3c in SwXTextPortion::GetPropertyValue(com::sun::star::uno::Any&, SfxItemPropertyMapEntry const&, SwUnoCursor*, std::unique_ptr<SfxItemSet, std::default_delete<SfxItemSet> >&)
            (this=0x558f064c43d0, rVal=uno::Any(void), rEntry=..., pUnoCursor=0x558f06515600, pSet=std::unique_ptr<SfxItemSet> = {...}) at sw/source/core/unocore/unoport.cxx:373
        8  0x00007fa6fa5c90e8 in SwXTextPortion::GetPropertyValues_Impl(com::sun::star::uno::Sequence<rtl::OUString> const&) (this=0x558f064c43d0, rPropertyNames=uno::Sequence of length 1 = {...})
            at sw/source/core/unocore/unoport.cxx:414
        9  0x00007fa6fa5c925f in SwXTextPortion::getPropertyValue(rtl::OUString const&) (this=0x558f064c43d0, rPropertyName="RubyAdjust") at sw/source/core/unocore/unoport.cxx:425
        10 0x00007fa6fa5c940f in non-virtual thunk to SwXTextPortion::getPropertyValue(rtl::OUString const&) () at /home/julien/lo/libreoffice/instdir/program/../program/libswlo.so
        
        Regression from d57ad60d8ed5279a3366386553c5cefb7ae8b5bf
        "unique_ptr->optional in SwXTextPortion"
        (in August 2022)
        
        Change-Id: I9c4c5bbbcb439cb3105654044dd8a571d39ff513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143191
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-23  Caolán McNamara  <caolanm@redhat.com>  [96880f5af713a55d87556af30a08b5f09f00ba48]

        tdf#152094 don't attempt scroll paint optimization for devices with a mapmode
        
        Change-Id: I446cf9ee62faf564143d25db60643c9b6cd8e3d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143188
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c2e77152c3b824153ef5451ababe58dc5ce981c]

        loplugin:unusedfields make some fields private
        
        this is one of the secondary analyses this plugin performs
        
        Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-23  Caolán McNamara  <caolanm@redhat.com>  [bf059cd63fe01094b3eb469b2f4529820d692f32]

        rename SetFocusedPageFromCurrentPage instead SetFocusedPageToCurrentPage
        
        which is a bit misleading
        
        Change-Id: Ifd986c0bda8311453b17ed08d2aeab5b09665a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143185
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Caolán McNamara  <caolanm@redhat.com>  [27c44ebd3c93c2a37f50bfa7e42caa9ecf825cc9]

        Resolves: tdf#145491 make sure focused page is selected after undo/redo
        
        Change-Id: I269315556624c48373815640605a93c91a4c9819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143184
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Caolán McNamara  <caolanm@redhat.com>  [5b3b13ceed474873776464269c5d71544252a928]

        rename ImplScroll to ImplScrollCalendar
        
        to avoid collision with Window::ImplScroll
        
        Change-Id: I16e72ff842054979733b5149cd220a7a77f79351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143187
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [aba9b0a359aa47e6c9b05e2aeea3de4b30495dd2]

        CppunitTest_sc_opencl_test: fix the way the tests work
        
        As I see it, every test compare the same file with and without
        OpenCL. However detectOpenCLDevice calls
        sc::FormulaGroupInterpreter::enableOpenCL_UnitTestsOnly()
        so OpenCL is always enabled
        
        Change-Id: Ib6f896e246558de7439f2fe8601c446e4447def1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143183
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e5d9db623882c7a9d88d40d5bf2bce0dbdb11365]

        tdf#152172 fix help workaround re Safari as default browser on Ventura
        
        the "Rapid Security Response" feature added with macOS 13 (Ventura)
        makes Safari a stub in a different location. Instead of the traditional
        /Application/Safari.app/ the call to query the default app will return
        /System/Volumes/Preboot/Cryptexes/App/System/Applications/Safari.app/
        So instead of a full match, just check for the suffix.
        
        Change-Id: Ic4abfe33c118827bc0e089e9966e57a0fd8c0526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143178
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-11-23  Tünde Tóth  <toth.tunde@nisz.hu>  [55b1d635350cb76ee3e19e90c938eedd38ac3342]

        tdf#152153 DOCX export: fix lost images at embedded documents
        
        Handling of image counter was incorrect if the
        document contains embedded documents, overwriting
        images with the other ones.
        
        See also commit cf2dc247ff5f726238856e9b46a4926a30430e14
        "DOCX export: image deduplication and clean up" and
         commit 3f6df3835fec71ea61894f9a3bbfe5e4a06a5495
        "DOCX export: fix image counters for multiple documents".
        
        Change-Id: I3ce3e370f96fa8b9feca3bc73f06ddca933215d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143036
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-23  Miklos Vajna  <vmiklos@collabora.com>  [d1dd9b9733511ff451e264169537c08fa14c574f]

        Related: tdf#54053 PDF export: add UNO API to customize the watermark font name
        
        The font name of the watermark text is currently hardwired to Helvetica,
        a sans-serif font.
        
        The problem is that this looks bad in case your document uses serif or
        monospace fonts. Or perhaps your document uses a single font and you
        want to make sure that the watermark uses exactly the same font.
        
        Fix the problem by adding a new "WatermarkFontName" PDF export filter
        option to specify the font name explicitly.
        
        Example cmdline usage:
        
        soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontName":{"type":"string","value":"Times"}}' test.odt
        
        Change-Id: I2f065e1517236695b0a95369bdcd803125018587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143143
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6c3cebd5aaec641807f5efed814fc5d1c64df149]

        UnoApiTest: factor out createTempFile
        
        Change-Id: I8d7bb4593839d3660b6609d836b09d50b68f5712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143141
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [139d1aa610d19ab200deff1e3cd2c787f5c87d89]

        Update git submodules
        
        * Update translations from branch 'master'
          to eee3cf83384a758f9cc80d11885e1fcaa06b0fc3
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I87cd0e8ca6efc815adbc6b60971fd376e8da0818
            
2022-11-23  Tarcísio Ladeia de Oliveira  <wyrquill@gmail.com>  [a468c06f384b8ad2fb1260d375844accb18db2dc]

        svx/qa: add checks for PDFiumDocument pointer
        
        When compiled without PDFium, two tests in svx were causing segmentation
        faults, as they were trying to access null pointers. Add a check for the
        pointer returned and end test if it is a nullptr (based on how it is done
        in other tests).
        
        Change-Id: Iab3c341a20f002adc92fac22ef76ed022aa49422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [9b3729d63cbed7c343f6c68983a40d9fbf329958]

        Avoid memory leak on PostMessageW failure
        
        In addition to leaking memory, the struct holds a couple of VclPtr,
        so would prevent destroying referenced windows.
        
        Change-Id: I258b5f32aca033a602d7b2805b33bd08ba637309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143154
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [2925425f02c7730343da48dbbf6501b907a21b6b]

        CppunitTest_xmlsecurity_signing: inherit from UnoApiXmlTest
        
        Modify testPreserveMacroTemplateSignature10 and
        testPreserveMacroTemplateSignature12 to test:
        
        OTT -> OTT -> OTT
        OTT -> ODT -> OTT
        
        before it was:
        
        OTT -> OTT
        OTT -> ODT -> OTT
        
        Change-Id: I1a0b7f1607202e994bf5847660b5abdc715106eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143140
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f4b6ff46aea6d260eab191daf5d437dada39f4d0]

        lok: take borders into account in in-place Math cursor/selection
        
        The offset is defined by formula's top/left borders (in UI under
        Format->Spacing).
        
        Change-Id: Ic17356f8c6e4db3cbe0df765d133ee240f5b088d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143136
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-23  Tibor Nagy  <nagy.tibor2@nisz.hu>  [25e9766e9b87342b6f1b29dc146d5f33e12157a7]

        tdf#92222 PPTX export: fix line width of the shape in theme
        
        Change shape line width values of minimal office theme
        to the correct 0.5, 1, 1.5 pt (from  0.7, 2, 3 pt).
        
        Change-Id: Ied7ad2e29daed9130df8b8c8d8baf5342f1c75da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142427
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-23  Miklos Vajna  <vmiklos@collabora.com>  [175e514c93b3696faa8c331c8b8f56e832ceb4c1]

        Related: tdf#54053 PDF export: add UNO API to customize the watermark font size
        
        The font height of the watermark text is currently automatic: we start
        with a value based on the page size and then decrease it till the text
        fits.
        
        The problem is that sometimes you want a smaller value, but specifying
        this was not possible.
        
        Fix the problem by adding a new "WatermarkFontHeight" PDF export filter
        option to specify the font size explicitly.
        
        Example cmdline usage:
        
        soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkFontHeight":{"type":"long","value":"100"}}' test.odt
        
        Change-Id: Iceab943b7a995badfcdc6b12ecc9264e39e4a3a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143135
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-23  Caolán McNamara  <caolanm@redhat.com>  [875a7a3351488ac18b6576793ffe5d54b57fdfe0]

        ofz#53628 Use a progress monitor to avoid Timeout
        
        LJT-01-003 of https://libjpeg-turbo.org/pmwiki/uploads/About/TwoIssueswiththeJPEGStandard.pdf
        
        Change-Id: I834e0891c4bb91907750282a26b8b803f94b8fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143131
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-23  Miklos Vajna  <vmiklos@collabora.com>  [5c85fc8552e8ce811833351b68b3d70b9bb6bf4f]

        exteral/freetype: improve -fsanitize=non-null-attribute fix
        
        Quoting <https://gerrit.libreoffice.org/c/core/+/143098/2#message-62ac4499370dd88eeb3181f52d817e831150c94d>:
        
        > What we do in other such cases is not make it conditional on the
        > pointer argument being non-null, but rather make it conditional on the
        > length argument not being zero.  That way, it only catches the
        > "harmless" case of an "irrelevant" null pointer in combination with a
        > zero length, and doesn't hide bugs where the pointer is erroneously null
        > while the length is non-zero.
        
        So check for the length and not for the pointer argument.
        
        Change-Id: I1894eb67d49a9ae40cdce29de865172400a271dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143134
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-23  Stephan Bergmann  <sbergman@redhat.com>  [7255d21f812b7333c83b4548e2b5b102adb606a9]

        Fix loplugin:redundantcast check for same-type dynamic_cast
        
        ...when the target type is a reference type and the source and target type have
        different cv qualifiers.  (And fix the fallout.  And make the tests cover that
        somewhat more exhaustively; and while at it also test that the plugin can cope
        with dynamic_cast to void pointers, which is the only legitimate case where a
        dynamic_cast can involve types that are not (pointers or references to)
        non-class types.)
        
        Change-Id: Ia568ddb5dbc4a84c275db172791c345d95964857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143133
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-23  Stephan Bergmann  <sbergman@redhat.com>  [27eb23369f9e250e71cfea8524a71f962e93b8fd]

        Work around system(3) dropping DYLD_LIBRARY_PATH on macOS
        
        ...which caused `make translations` fail for me with
        
        > [POT] pot.done
        > dyld[96290]: Library not loaded: @__VIA_LIBRARY_PATH__/libuno_sal.dylib.3
        >   Referenced from: <CD4F28D6-E3BE-3126-B861-C90BF3E14492> .../workdir/LinkTarget/Executable/cfgex
        >   Reason: tried: '/System/Volumes/Preboot/Cryptexes/OS@__VIA_LIBRARY_PATH__/libuno_sal.dylib.3' (no such file), '/usr/local/lib/libuno_sal.dylib.3' (no such file), '/usr/lib/libuno_sal.dylib.3' (no such file, not in dyld cache)
        > Error: Failed to execute .../workdir/LinkTarget/Executable/cfgex -i .../connectivity/registry/ado/org/openoffice/Office/DataAccess/Drivers.xcu -o .../workdir//pot/connectivity/registry/ado/org/openoffice/Office/DataAccess.pot
        
        (This is the opposite case to 17cfd43e28c45626b1e0990bd0e51fdc97409ebe "Avoid
        external processes picking up instdir/program/libxml2.so.2".  Here, the
        executables called from Executable_localize are LO-internal executables that
        need the libraries in instdir/.  There, the scripts called from
        Executable_localize in turn only call external tools that shall not accidentally
        pick up LO-internal libraries from instdir/.)
        
        Change-Id: Ib1aa240ee47a21d14ec0463fee85bebe82453cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143118
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-23  Miklos Vajna  <vmiklos@collabora.com>  [59e25927f4babdc142cdcbd81b5ceb7afe798d02]

        CppunitTest_sw_uiwriter: use more SwParaPortion::dumpAsXml()
        
        Which means XmlPortionDumper can be finally removed.
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I50e6c49a50c5ccbec9e426ad796d85865dcc93e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143128
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-23  Justin Luth  <jluth@mail.com>  [1435c5b12646269e2b5b58ec7d51626dce6505db]

        cleanup SdtControlType::plainText - same as the other controls.
        
        For a while, plainText needed special handling
        added in commit 9700c1b2170ad04453a361ed5647937833ac3c18
        Date:   Mon Jul 25 09:13:03 2022 +0200
            sw content controls, plain text: add DOCX import
        
        But now it is treated the same as all the others
        and so can be lumped together with the other case statements
        since commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a
        Date:   Mon Sep 19 10:01:36 2022 +0200
            sw content controls, plain text: enable DOCX filter with data binding
        
        Change-Id: Ie1ebe3873e8f49ae9747f1a77d08bfc0dec2d9f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142953
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-22  Jim Raykowski  <raykowj@gmail.com>  [ff5bf008a3737c68c899da667456f8995b064869]

        tdf#151828 fix table name changes on cut and paste
        
        Change-Id: Ibd9fc78d88732b63d418404fa23e1560bf531fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142984
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [ede2b2e70c33754df6643b7eb505b4db1e7e872d]

        crashtesting: restore workaround
        
        for tdf119074-1.odt, while I have a strong memory of testing that it
        solved the problem, I know find that it doesn't.
        
        Change-Id: Id7fc800702c6a417810cba22f180d933d9fcd9b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [81235a45035dca34c8cc0f713be21b6c12259d15]

        ofz#53648 Abrt
        
        Change-Id: I070b7a8ea599f1faddb009c68aeb4b8536cc52e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143130
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [7d49a2afc504b8988d0405dfa582758de92c35a3]

        upgrade to libjpeg-turbo-2.1.4
        
        Change-Id: Ia0060f20a8851e0431efaef0dc04fb36ae2c41a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d19816350dba8daffa2deb495d4e697062579456]

        lok: draw Math in-place widget in sd
        
        Change-Id: If874c0227ec724fa5b1517080db252e64f9597c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143121
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-22  Eike Rathke  <erack@redhat.com>  [8cc4e6c8f572d84dc004d97fa25d17fe85505dc6]

        Calculate null-date days to assert only once
        
        Massively called it is really unnecessary to do that each and
        every time. The debug build is slow enough..
        
        Change-Id: I06525e4ca1fa23a1d49dd735370eb157157800e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143127
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [00ee70be17c1c466674552b59737e39fb785e907]

        Fix typo
        
        Change-Id: Ifd1d5baa6e304d370b82e93781abf47da437c766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143123
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9f1b157122b0c0dfd2e8f97f4a98d342a8a1d423]

        Fix typo
        
        Change-Id: Ia666ef09e60f1d52e813adb392a99b68008d1f21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143091
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-22  Eike Rathke  <erack@redhat.com>  [c4d169eb7f0b2abb96e6a210fbaae506eb354b4b]

        Avoid second null-date check of convertDateToDaysNormalizing()
        
        This is micro-optimization, but..
        
        Change-Id: Ic5d43bc0ce9343cf194e189777109636d3b587c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143126
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-22  Miklos Vajna  <vmiklos@collabora.com>  [100c914d44ae8f362924fe567d7d41d0033ae8ad]

        DOCX filter: fix <w:id> creating both grab-bag and content control for <w:sdt>
        
        Exporting the DOCX bugdoc back to DOCX resulted in a document that can't
        be opened in Word.
        
        Examining the output, the problem is that the document had 2 inline
        <w:sdt> elements with <w:id>, and we mapped such <w:sdt> elements to
        both grab-bags and content controls, leading to duplicate <w:sdt>
        elements on export. This is schema-valid, but it goes against the
        intention of the spec and Word can't open it.
        
        The initial fix was just a writerfilter/ tweak to avoid grab-bagging
        <w:id> for inline <w:sdt>, but CppunitTest_sw_ooxmlexport4's
        testSimpleSdts points out that in other cases we already require
        preserving <w:id>. Fix the problem by storing <w:id> in the content
        control, which is essentially a subset of
        <https://gerrit.libreoffice.org/c/core/+/142818>.
        
        Thanks to Justin Luth! - he prototyped the DOCX filter for <w:id>.
        
        Change-Id: I9f002b770049ce8be30253d0b39410d9a58981dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143117
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b71303fe1b06c1711ad80e5a0269d41ccaaad8e1]

        tdf#46444 tdf#152081 sc: hide notes in hidden rows or columns
        
        Hide notes in hidden rows or columns just like we do
        in case of other sdrobjects.
        
        TODO: unit test
        
        Change-Id: Ib136324d5d0dd8777fc0912af6d8b9ac39935ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143024
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [9571986f72a3b0acb85eade721d09dad11affeab]

        tdf#135638 svx: PDF/UA export: also tag *all* text shapes
        
        For unkown reasons only TitleText and OutlineText were tagged when this
        code was added in 2004 commit 489cf28b88e174db4dffc55d9aa245e7d7c90a2c.
        
        Tag as Div, like Writer in SwTaggedPDFHelper::BeginBlockStructureElements().
        
        Change-Id: I55ccf26bceac4f89383f1ec1de6c00d0a1353615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143120
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-22  Stephan Bergmann  <sbergman@redhat.com>  [7a82ea5c79adee70eddf74ac53347544766a91b0]

        Fix presumed typo
        
        ...introduced in 6cb400f41df0dd108cdb4b4d3ec6656844814147 "store the SfxItemSet
        inside SfxSetItem by value".  It appears to make more sense here to check that
        an SfxItemSet is not an SfxAllItemSet, than to check that an SfxSetItem is not
        an SfxAllItemSet.
        
        Change-Id: I292c2a88910db9852cf8ba7c61999c5f281ed14a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Eike Rathke  <erack@redhat.com>  [52ff16771ac160d27fd7beb78a4cfba22ad84f06]

        Resolves: tdf#152114 Use comphelper::date algorithms
        
        ... that can actually cope with negative (BCE) proleptic Gregorian
        calendar dates, which already for Julian calendar dates 0001-01-01
        and 0001-01-02 they are.
        
        Change-Id: I38481007e705f95da0f4f73a6bb298ce42494f72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143115
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-22  Eike Rathke  <erack@redhat.com>  [0e2781bb5fbf7035278e311f8b50a2955048b14c]

        Related: tdf#152114 Move some tools' Date class algorithms to comphelper::date
        
        So they can be reused, specifically in
        connectivity/source/commontools/dbconversion.cxx
        
        Change-Id: I8b2b59e3cb078a73d5f670f0756404471009cf9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143114
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [457165e949151159e4e37879d86d92cc259abe2c]

        ReduceInaccurate(32) makes no sense for Fraction based on sal_Int32
        
        Change-Id: Ia265f9f5e1151efae6d2b4cbb3c06f4ddbcc06e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143068
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [15cdee0d846854b50dd04626b73499bef9305e00]

        Resolves: tdf#152155 use gtk's knowledge of relative widget positions
        
        rather than effectively emulate it poorly
        
        Change-Id: If1c215892645d83937d97158a2d3f8ddac10364e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc3993c6794e2749400755ecd032165a61d5d959]

        tdf#152014: sc_uicalc: Add unittest
        
        Change-Id: I7be721d9409890fe1f26125f06561e85cb1ddb27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143113
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [937cb97e66b61fa1b9d7f667925f8acae6293922]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e7f48e5e03d5588b00d341c5a82fa1a74b2bdd9
          - tdf#151827 Improve the ODBC connection help page
            
            As requested by the OP this page clarifies that we're actually connecting to a ODBC data source.
            
            I also made other improvements to the text and fixed the case when the user presses F1 in the Data Source selection dialog.
            
            Change-Id: I89817df62e5dadaa4e1258768f442bbc4bb08fe7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142916
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-22  Leonid Ryzhov  <leoryzhov@gmail.com>  [49737dff4b7b46c44f8c8e1c4de0291309eef78e]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Iec561daa71b17cedf0ea4cd2b473df9591a7bf3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142900
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [41bc8bb0cd4a5b92c7e7fc0080c6e3fa5650aa01]

        sc: drop ASSERT_FORMULA_EQUAL
        
        Unify the code and use GetFormula everywhere.
        No need to define a specific assertion when
        we can use OUString comparison instead
        
        Change-Id: I7cd6f16bb32d6a659cac4e656bd4465393533cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143094
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [792e41314f321f54b3b2fc4d01c8b62a3b704e9e]

        tdf#145978 Remember last run macro in Macro Selector dialog
        
        This patch saves the last run macro using the Macro Selector dialog
        (via Tools - Macros - Run Macro).
        
        Change-Id: I9da9262daffec402fc5f76691473263f9319664e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142632
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2022-11-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [5d07b7cdc9acca37d33f0f3a97cab3a9a2731812]

        tdf#151827 Improves strings about ODBC connection
        
        As requested by the OP, this patch improves the strings used in the Database Wizard for ODBC connections, clarifying that we're actually connecting to a data source.
        
        Change-Id: I8752204759ea03481542c20d0626ad27d1c3959d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142917
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6f8bd9785c3f01ac711bfe0647dc7d02a68d45a8]

        sw: use WeakNodeContainer for m_pPreviousNode in OnlineA11yCheck
        
        Change-Id: Iae2158ff4de0cab4307379c48011d5b6ca844b13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142821
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bada1fc45d6ec65c12cf9ed36e15927b27d6d49c]

        sw: rename WeakContentNodeContainer to WeakNodeContainer
        
        Change-Id: Ic80c0753b600ff6e846f2f38a1c46cb67763e2fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142820
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f8b990aaac155f0b45de3a4452bc300dcf2bb49b]

        sw: change statusbar to use an icon, fix statusbar updating
        
        Change-Id: I98e862c4c1124b1db8eb3e0ea7ff96effd629185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142721
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e7f78c3123c7bb7b8c830fa11241c357d89bad6a]

        sw: test online a11y check - splitting and joining nodes
        
        Change-Id: I9be3df3a4c00e7f1bbfc4f2462c8cf9a0f813f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142656
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-22  Kevin Suo  <suokunlong@126.com>  [f078937179c4490df273b95cc8c29a216f9184ba]

        tdf#138111: Fix apparent copy-paste error in ApiNameMap for sd style "A0"
        
        As introduced in commit 99102d4263189d347c7a7d0df8fd782e8c4c8ad5.
        
        Change-Id: Iece8595a401df7bd5a514244d4a4fc825a49f9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142819
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [70a84bc0ee414a67b1dfb5f4055b337ca777b2b6]

        CppunitTest_framework_services: inherit from UnoApiTest
        
        Change-Id: I8963f0dbf5e70347ee98e639dc6eeecc0f43b821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143099
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [86545868163667d7de4c7d1ef38f16d6d47f2b45]

        CppunitTest_framework_loadenv: inherit from UnoApiTest
        
        Change-Id: I9c997691d6b7f0c46089eec86b614bcd1a0d71a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143102
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Miklos Vajna  <vmiklos@collabora.com>  [9d4627322f5e2753b29cc310f1da9e433d986ae7]

        exteral/freetype: -fsanitize=non-null-attribute
        
        Crashreport log:
        
        workdir/UnpackedTarball/freetype/src/psaux/psobjs.c:204:5: runtime error: null pointer passed as argument 1, which is declared to never be null
        /usr/include/string.h:44:28: note: nonnull attribute specified here
        SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
                       workdir/UnpackedTarball/freetype/src/psaux/psobjs.c:204:5 in
        
        Change-Id: Ib2ae396ba640129a8bc1c937ce41a38b6279a2ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143098
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f46b6d847e8dc9f3bea44d0bd76f517c1e54163]

        tdf#152077 Calc freeze when you draw a line inside the chart
        
        Change-Id: Ia047352033780c658aa7244cb8568392cf23baac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [056611229bea357e2d75619d8b5b7cd715742f3d]

        CppunitTest_vcl_filter_ipdf: inherit from UnoApiTest
        
        Change-Id: I326ba676730268808f60e0593a5e7f813b503977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143097
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [5d9b8c367e70ac0a11f368ea702967ee4e0d5f06]

        tdf#152150 make AccessibilityCheckDialog modal when child of modal pdf dialog
        
        Change-Id: If6ff13d17a5ead40d9694ea861dc8946c201147e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143044
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Maxim Monastirsky  <momonasmon@gmail.com>  [24ea3f7b0ed23e8ed1b8e42db440aaf54084e1ac]

        End text edit mode before changing a table style
        
        Because we now support text attributes in styles,
        and their visualization will not update when in
        edit mode.
        
        Change-Id: I117812442b07476a84b9bd887fa2380ec4581283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143101
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [49cd099df436f85be9abf97db299f54e580c5236]

        CppunitTest_framework_dispatch: inherit from UnoApiTest
        
        Change-Id: I9a839ffe01e1d5da49268bd8ad78dbedd8dadc25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143100
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [91436c281b6cbd7ca3678370afe2f9d874a4e422]

        loplugin:unusedfields update the post-process script
        
        (*) ignore temporary fields in lambdas
        (*) don't ignore the vcl/weld stuff anymore
        
        Change-Id: I4cda18f779588409891a2b2f8b1371e60f9b9ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [822375143bc8529dbbb6ec66d616aecbe94135b5]

        loplugin:unusedfields
        
        Change-Id: I63f4ffc1645821af78fa32d59e19799e890d4cd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [6e5d59c2ca6969e9491f97cd7a00d094fc62cfb3]

        tdf#135638 drawinglayer,svx,sw: PDF/UA export: put SdrObjects on anchor
        
        ... frame in the structure tree.
        
        The problem is that in sw, the anchored objects are painted
        outside of the call to paint the page frame, which is what generates the
        /Document structure element.
        
        For Writer fly frames, this is handled via their SwFlyDrawObj painting,
        where SwTaggedPDFHelper::CheckReopenTag() finds the anchor frame and
        temporarily sets it as the structure parent, even if it's on a previous
        page.
        
        But all the SdrObjects on a page are painted by 2 calls to PaintLayer()
        and there isn't a call back into Writer now.
        
        Somehow this even causes a spurious line like "/Document<</MCID 7>>BDC"
        to be emitted outside any PDF object, which looks clearly wrong.
        
        Try to extend the SdrObjUserCall to get a way to retrieve the anchor
        frame's structure element index.
        
        Another option would be to extend ViewObjectContactRedirector to return
        the PDF Id in its subclass SwViewObjectContactRedirector, and it seems
        possible since its only one caller is
        ViewObjectContact::getPrimitive2DSequence(), but Armin adivses that the
        ViewObjectContactRedirector might go away in the future so it's better
        to use SdrObjUserCall.
        
        It's annoying that the mapping is a static members of
        SwEnhancedPDFExportHelper; possibly it could be in OutputDevice's
        PDFExtOutDevData instead?
        
        Change-Id: Id61faae469aba4f0bd278ab2324aae06c1fdde64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143027
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [3d5e3cb4c033cc7b03c18851d56ca529f025038b]

        tdf#135638 drawinglayer: PDF/UA export: add BBox to Figures
        
        PAC3 complains: "Figure" element on a single page without bounding box
        
        Also add Placement while at it.
        
        Change-Id: I3db11f5b38c46bc274e496c7ce6f0cde9dd11b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142902
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-22  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [87383b341a6bf515a209ad2e7a2a1289059b781e]

        tdf#135638 svx,sd: PDF/UA export: tag SdrObject shapes as Figure etc.
        
        Move the code that already exists in sd class ImplRenderPaintProc
        to ViewObjectContact::getPrimitive2DSequence(), where it is used by all
        applications, and take into account the caching there, which matters for
        performance.
        
        Change-Id: Iabc00b7c894f042673c7217199236a05a5d67959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142901
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [81791adc414adcaa9f43b5f449ad0f6752e01df7]

        CppunitTest_slideshow_engine: inherit from UnoApiTest
        
        Change-Id: Id945ba8b9c7943c07063cb9456981ce542f61347
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-22  Szymon Kłos  <szymon.klos@collabora.com>  [25245dba23def7391f3c0c82f7e804674a89a876]

        Revert "lok: respect zoom in calc tile rendering of EditView"
        
        This reverts commit 7260b8724fafd41294761382f69ece7fe09588c4.
        lok: respect zoom in calc tile rendering of EditView
        
        Which was causing chart artifacts. Original issue which was
        fixed by above change is no longer valid. Probably different
        fix was made.
        
        Change-Id: I855be90b2736a2d1e95dc1cabef54a438644aa7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142570
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142996
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [7dd9790b89da12b1eeb635ee590fec04c4f20e0b]

        svg export filter: text fields not handled correctly
        
        New solution for fixing text field issues:
        
        - small text field are not substituted with the right content because
        the placeholder text span several lines
        - copy of standard text fields embedded in the default master page are
        not substitute with the right content.
        
        Change-Id: Ifc8773f1ba41f9d0fe6f6ef3982cb64a514fcec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143045
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143051
        Tested-by: Jenkins

2022-11-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [bbe4161818e2ec6652ec443a67951b318c9f0e21]

        svg export filter: when a text field is too small, its content is wrong
        
        When the text field width is too small, the placeholder text spans
        several lines.
        That stopped the js engine to substitute the text field placeholder
        with the right content.
        This is a workaround but it should work in the majority of cases.
        A complete solution needs to support svg text wrapping.
        
        Change-Id: Ide52e08acd35b3764b8abc600e4b467acea0a248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142760
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143050
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-11-22  Marco Cecchetti  <marco.cecchetti@collabora.com>  [0abbef139f3147a9728fb22133bc2350d28b555e]

        svg export filter: footer was not replaced with the right content
        
        When a user create a copy of the footer text field which can be
        included in a master page, the copy content was kept to the text
        placeholder instead of being substituted with the right content.
        
        Change-Id: I411349026e41d49b606cdae5d13d990d0fa0b07c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142759
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143049
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [c5396467030ebb47d3d0d649b28aed2cf2554a66]

        use an alternative macOS themeing approach to support dark-mode
        
        checkboxes, radiobuttons and pushbuttons look decent, focus ring works
        
        editboxes work, focus ring doesn't for some reason, so faked that in
        
        spinbuttons work
        
        list and combo boxes work
        
        scrollbars work, though with some degree of overly complicated fakery
        
        tabpanes and tabcontrols work
        
        sliders work
        
        progress bars work
        
        disclosure butttons in listtrees work
        
        a dark mode icon theme is automatically selected under dark mode
        
        Change-Id: I4835c7639f725a0154288440fcad400f618438e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141435
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [aa0c9eb6bd91126eebe1eb2444b024572b740a6a]

        tokens.gperf: Use LF line endings also on Windows
        
        This fixes the warnings during the build:
        
          C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/filter/source/svg/tokens.gperf:9: warning: junk after %% is ignored
          unsupported language option C++
          , defaulting to ANSI-C
          C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/filter/source/svg/tokens.gperf:2: junk after declaration
        
        This is https://savannah.gnu.org/bugs/?53732, and is expected to be fixed in
        http://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=13c9383b10872525688ef2b4daab090037ea3576
        However, the last gperf release is still 3.1 from 2017, and has not that fix
        included. Since we use Python 3.x, it is OK to just use 'newline' argument
        in the open call.
        
        Change-Id: I33585d1cc698eb55e353adbc684a83c1e0156507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143095
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [5b41abc85d0a74fb3c047fe723d5b55abb6499ae]

        move workaround out of GtkInstanceExpander ctor
        
        and into the builder so get the same result if there was an explicit
        expander instantiated or not
        
        Change-Id: Ia5af8de81d6fa0780cf507f565c6819e16cde43c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143093
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [55d87b3a3fc87dca3114744f4a4e676ec51a9aa1]

        ofz#53586 Out-of-memory
        
        Change-Id: I4442f6b6cd010706ccfded454e4c56b4ff001dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7674cc127c9987622cb69d7a23468df3f10ff21]

        loplugin:unusedfields
        
        Change-Id: I4487f1b3bb051e1eb48226eb52a6706b22493fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [57fcfc5a5071ffdb955ce341538263d92ee1eaa5]

        loplugin:unusedfields
        
        Change-Id: Icf6e7e116a087e7f68b86bdb645850a2edaa2f78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a55d9d57e5bfe40a6d97c78b35646372f599c840]

        loplugin:unusedfields
        
        Change-Id: I726b8b9dee3a424f731078cd6b10027423454bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [abe269d3f9ca01bb1151d3ef8c20bcfa6530c65c]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Id18265f8d6470870730ffdc9ad879ef99f120aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143056
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [1cd62f8cc6d47d1d3ba695e00fc36d650084fede]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: If460dd5bfcab290e41513a47257c0de37757eb2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143059
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [c2d1cfd346f7546adbe1cbe8df797adcafcc4acf]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I7ec467f46e0fac2655990a67bc4e78e39fdb489a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142931
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [f2daf6c28fea2b8a1c7c8638ed14f3c0e6c5a034]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I7ff944967188567ae00e09357fe83b8c3e639dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143060
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Miklos Vajna  <vmiklos@collabora.com>  [2302ebefb2e25878e8fe1e64d208f265f87d5b9b]

        sw, createTextRangeByPixelPosition(): fix crash when the position is an image
        
        Using createTextRangeByPixelPosition() with a pixel position that leads
        to a graphic node resulted in a crash.
        
        The direct reason for this is that the makeMark() call in
        SwXTextRange::SetPositions() returns nullptr in case rPaM points to a
        graphic node, but later we dereference that result unconditionally. This
        also uncovers that the XTextRange returned by
        createTextRangeByPixelPosition() is meant to point to a text node, but a
        pixel position may be closest to a graphic node.
        
        Fix the problem by explicitly checking for graphic nodes; and try to
        look up the anchor position of such graphics, which will be definitely a
        text node.
        
        In practice this will mean that in case the image's anchor type is
        as-char, then we'll return a cursor position which will be on the left
        hand side of the image.
        
        Change-Id: Ief58148247fe3cd4371ed245b4eff5b45ca2aa15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143092
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-22  Stephan Bergmann  <sbergman@redhat.com>  [4c8411a55aa10bafdda35b8e60b6a1a5e1600329]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2bec94db3019501780538dd7143ec90eab55ed92
          - Revert "Fix duplicate ID"
            
            This reverts commit bcc251fddf6f5be88dc43fba34573d5e3b51a6dd:  The issue had
            already been fixed, minutes earlier and in a slightly different way, by
            58d932b2c300b44b2c1807478626a4b3060371b4 "Error: Duplicated entry.
            ID = par_id3150441  LANG = en-US".
            
            Change-Id: I41a41864586a551f4690af8d81e6a914cc843677
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143066
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [be7bdc54069214f29829f19947292f004eb0e873]

        drop newly unused FreetypeFontInfo::IsMicrosoftSymbolEncoded
        
        Change-Id: I88098a212aa43a0942b3f5d1ad1ac985c4d4a1a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Caolán McNamara  <caolanm@redhat.com>  [ee3d15ef630c5875a573318bad5cbd0a81ef71db]

        ofz#53401 Timeout
        
        Change-Id: I929006b2b993fde110fb4d7d72fd6b1e6c146066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143075
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [70987cc656f0cded915be5aa148f265a257ec791]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I2651182be3f06666686930996834559001e114c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143057
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [66e48719c0a58508d75c0204531513541ae6db09]

        tdf#120405 - Use previously selected file, if selection is aborted
        
        If a user aborts the selection of a concordance file, use the previously selected one, if it exists.
        
        Change-Id: I55547ca98034269e897d6bc86ccc4dcfd63be9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142997
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-11-22  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [b8758f3919f99c454cf957b93e6f5394b61d0478]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 758a4b21158ff828a95de8d3b441fee792ee6cb6
          - replace "Function" string with correct button name "Formula"
            
            Change-Id: I1abb41a4677e570b2224a2841b699220d3dc7f03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142929
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-11-22  Stephan Bergmann  <sbergman@redhat.com>  [337691db0e3f928ed6dff489fc6305a9a5e0b493]

        Simplify previous fix
        
        ...e735de2051143347b7283c85ad80b0e2412522dc "Avoid some unnecessary, wrong
        downcasts during `make translations"
        
        Change-Id: If6110e16698302b3d43b2192cf0f0e0d0fddb57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143026
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-22  Miklos Vajna  <vmiklos@collabora.com>  [017c38a9702da0566ac1ce5d758444e5ff25df9d]

        tdf#152045 DOCX export: fix empty display text for content control list items
        
        Regression from commit f726fbc2699b05199a8dec3055710a7131e0aad6
        (tdf#151261 DOCX import: fix dropdown SDT when the item display text is
        missing, 2022-10-10), the problem was that the correct way to represent
        "no display value" is not an attribute with empty value but a missing
        attribute.
        
        Change-Id: I25b2bb564444f43d1ca1bf95d1c59b208cb24530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143048
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [e1562ac3d7821cee90db383db5734b86691a3887]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I894e3a67b9312b99ac2fd7290dfa73a0dafb28a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142932
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [b43d4e1d220b333b7eb17e8a7d914e2cab72985f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I1e542a5fce00e1c07019a828a7f45f1b7d2fe7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143054
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [39490a5a07db543f681fcd6e59083d5c72dc9927]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I20add5a23520c54425174959b4757720639413e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143055
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [08e163864fb48c5299518e98ddff57f192a1ba2a]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I64a379e62e63e92fb7093df71f3ccd99a8cd69b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143058
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Bogdan B  <buzea.bogdan@libreoffice.org>  [b813326ac01b8c8773b499afc9c5ec7dafcbf44f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ifa8ad8539ad2fb828b45b9242b9e8196c48f5a74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143061
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-22  Julien Nabet  <serval2412@yahoo.fr>  [aa29d9f8b141cbb513769dd8b14435f9164a5654]

        tdf#152154: Crash when Object Catalog undocked and BASIC IDE closed
        
        Change-Id: Ice01e253c135cf1c694afad092aabe46b3150e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143078
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8288d2e3061327fd91e241c0b514cd973e3fcea8]

        loplugin:unusedfields
        
        Change-Id: Ief45ea5a1457e0beb2159f0471a33e1da708cb01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c91ec113a24ecc2bf883b1620f4e900f713dc996]

        loplugin:unusedfields
        
        Change-Id: I4a7276ffc36b4f954fe1fa39fb5666fa184e66e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e7f77d3fe01e36222d5ad84c18d7d7537092972]

        loplugin:unusedfields
        
        Change-Id: I37207c3610c25d9e37e77bdae16b613dd8410525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef6684337a3a99d6a1620e6cdb569888a77cacf8]

        loplugin:unusedfields
        
        Change-Id: Idaf9742358bcd485d6ac96593844b05bf0972fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-22  Eike Rathke  <erack@redhat.com>  [a41c82407bbb73a4d87070326485ec4b4e954a65]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7fa50f5c2f7280129f856f3f9fab85ac047a3e2c
          - Regex: precede every metacharacter or operator with "\"
            
            ... not every character.
            
            Change-Id: I2c09f164c8b48c5ac4f39203319411aa5c73b490
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143032
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-11-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5116d6ad85d804e7b7897bc57a4a4bf9d5bed4f1]

        Fix typo
        
        Change-Id: I4fadd8781881dffb9f012da29e241b8d189eff85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143053
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a7a766aa4119bf9616223d0de6587a3f30549eac]

        macOS (janitor): remove workarounds for no longer supported SDKs
        
        since we won't accept anything lower than 10.14 on master (and 10.13 on
        libreoffice-7-4 branch), we don't need those quirks anymore.
        
        Change-Id: Ibc71a2ce7a0dc60769d03d477991b48fc99d534d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143040
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-11-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [97d6185ef18b97ce30206720567fab2994ef2b3d]

        macOS: simplify SDK handling, remove the upper limit of SDK
        
        …both for building as well as for min-required version
        The newer versions of XCode/the corresponding SDK it comes with didn't cause
        any problems in the last years, and checking for a max-sdk version just causes
        more work when working on a newer system, either forcing to have multiple
        versions of Xcode around and switching between those for no reason, or always
        patching configure to accept the currently used version when bisecting stuff.
        
        Change-Id: I0dac9f90afe7d4490d44a1036fa8d358d29da57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143035
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2022-11-21  Stephan Bergmann  <sbergman@redhat.com>  [c84655bf796fe3600f2ee5671b37e4844b129d0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bcc251fddf6f5be88dc43fba34573d5e3b51a6dd
          - Fix duplicate ID
            
            ...introduced by 175750251cc83397e714586617681414316adf57 "tdf#152127
            Change order for Country/State", causing
            
            > [HPX] de/helpcontent2/source/text/shared/optionen
            > Error: Duplicated entry. ID = par_id3150441  LANG = en-US in File lo/core/helpcontent2/source/text/shared/optionen/01010100.xhp
            
            Change-Id: I28fdbda5b90f235381998c80664c4eb74fcadf7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143074
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [009e67a1579771e9bb711a2620a4ca71cdba79da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58d932b2c300b44b2c1807478626a4b3060371b4
          - Error: Duplicated entry. ID = par_id3150441  LANG = en-US
            
            in File helpcontent2/source/text/shared/optionen/01010100.xhp
            
            Change-Id: I9a2ecd372885cb09707e6e55e2ec2ab5527181e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/143076
            Tested-by: Caolán McNamara <caolanm@redhat.com>
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2022-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb6e1d160d946aeb4693b24236e5b83d8fcf0c3c]

        CppunitTest_sc_ucalc_copypaste: use GetFormula directly
        
        Change-Id: Id23a07d3d7442119676f8628d1e394914461b678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [780bc10c439aad5bbcbd2434f16719ba0cd65b35]

        sc: remove duplicated code
        
        Change-Id: Ice7d74263954c49a341f427c470f992225a40762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143033
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-21  Bogdan B  <buzea.bogdan@libreoffice.org>  [2183dd48aa018a79b00c60f463f68acd7d8761d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd779009d25f499ae7e8af70ac4b110e43efec83
          - tdf#152112 Include "labels grid" in Info description
            
            Change-Id: I4978961d3373753754438a5b383fd6af293dc530
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142918
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-21  Bogdan B  <buzea.bogdan@libreoffice.org>  [15a4b25ab7c2e49bf468df7582043a5c1ed6d24f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef74e307a6dfc74571727c42ee3b9f1e901451b9
          - tdf#152121 Improve row and column description for label options
            
            Change-Id: I8604f7d40a7a06c6a6da9314c52321b74194c3a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142920
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-21  Bogdan B  <buzea.bogdan@libreoffice.org>  [26ad69b87ea705d634595899df983001a26b2399]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 175750251cc83397e714586617681414316adf57
          - tdf#152127 Change order for Country/State
            
            The country was not included into location in shared/optionen/01010100.xhp, just the state.
            It is possible that there are files where country need to be removed, being now included in shared/optionen/01010100.xhp. I will take care of that in the next commits, when I will found them.
            
            Change-Id: Ie7ac4deb9a7c0e1d3c4a03dda2e2b348a3aeb585
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142923
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [ff0d0d0797701e38afb4f6d48486c5cd45f142cf]

        add some checks for OpenSymbol
        
        Change-Id: I98e1ee9f854d144cea3a305be6d53f8e86f6a7a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [dcb13565119faa3bfecfb487230bac02d73509b2]

        fix a comment typo
        
        Change-Id: I6497222d5fcb29d51fb3ac70a57d09593b27fd26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143043
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Bogdan B  <buzea.bogdan@libreoffice.org>  [2420ef3c349fb323cc5b28a0d00b2234098f34b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9a51c0944dd694febb2c007f497c22ec57d159aa
          - tdf#152057 Complete revision of shared/01/01010000.xhp
            
            Change-Id: Ib3bbc1c9660e7102bdcd4eb2d0573903bf4cf195
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142689
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-21  Khaled Hosny  <khaled@aliftype.com>  [ab5c60f2fd3e24f24fd82d7756d45a5fd4d19f1d]

        vcl: fix accessing color font colors
        
        Don’t unconditionally access palette 0.
        
        Change-Id: I3de3f005371fcb9360ee0cf245a1d0a7434ffbd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143042
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-21  خالد حسني  <khaled@aliftype.com>  [1ff2f5fa2d8c353b0cad28317a696c2ba9a4aab5]

        Revert "vcl: test getting glyph boundary rect from LogicalFontInstance"
        
        This reverts commit 0cef06f0a2c0963e8c1579b78975710e6af4471c.
        
        Reason for revert: 
        
        https://gerrit.libreoffice.org/c/core/+/141234/comments/89325e55_2271cfe8
        
        > Stephan Bergmann:
        >
        > I saw the unrelated <https://gerrit.libreoffice.org/c/core/+/143026/1> fail its Jenkins <https://ci.libreoffice.org/job/gerrit_windows/140750/> build on tb88-win with
        >
        >   C:/cygwin64/home/tdf/jenkins/workspace/gerrit_windows/vcl/qa/cppunit/logicalfontinstance.cxx(53) : error : Assertion
        >   Test name: VclLogicalFontInstanceTest::testglyphboundrect
        >   equality assertion failed
        >   - Expected: 51x82@(7,-80)
        >   - Actual  : 50x82@(7,-80)
        
        Change-Id: Idc4132adbaf0b051dcf955f3f1e7c44841c60117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142928
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-21  Stephan Bergmann  <sbergman@redhat.com>  [4beea25b0797fe9c9acf05e9e4ef926d0726582a]

        Drop comphelper::OWeakTypeObject, use cppu::WeakImplHelper<> instead
        
        Change-Id: Ie4152d7736ae3f2ffdd3489cd7a444e5035d2422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143030
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-21  Jim Raykowski  <raykowj@gmail.com>  [fd0f6a4e83cb4a99839c73d7f545b4b80ef4657a]

        tdf#151828 related: Make cut shape have the same name after paste
        
        when possible
        
        Fixes shape names without a number at the end of the name, having the
        number 1 appended to the end of the name after cut and paste in the
        same document.
        
        When possible - because it might happen that a shape is inserted
        after the cut operation and is given the same name as the cut shape
        name. If so, when the shape is pasted into the same document it will
        not have the same name as before it was cut.
        
        Change-Id: I1d1ebc76d07d81da0286d1f0bb7d34ad973a43b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142983
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-21  Jonas Eyov  <jeyov@proton.me>  [fe21365c5a9083ae1f086ea48614263b3a75ab3e]

        tdf#143209 vcl: track partial scroll deltas
        
        this makes scrolling in calc smoother and makes left/up scrolling
        the same speed as right/down scrolling, which was previously not the
        case.
        
        prior to this change, Window::HandleScrollCommand only checked each
        event for being a large enough scroll to advance one unit. this
        happened in lcl_HandleScrollHelper by way of o3tl::saturating_cast,
        which meant that nonzero upward/leftward scrolls were always worth at
        least one unit, while downward/rightward scrolls needed to be larger
        than 1 to count.
        
        now, we accumulate partial scroll offsets in WindowImpl and perform a
        saturating cast on the absolute value, so behavior is symmetric and
        sensitive to accumulated small scroll values. this feels smoother
        and is more correct.
        
        Change-Id: Id3692d14edd45ed26f2952e3418e4d82806e1fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142948
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Stephan Bergmann  <sbergman@redhat.com>  [17cfd43e28c45626b1e0990bd0e51fdc97409ebe]

        Avoid external processes picking up instdir/program/libxml2.so.2
        
        ...which is a problem in ASan builds, as seen with a failing `make check`:
        
        > xgettext: symbol lookup error: .../instdir/program/libxml2.so.2: undefined symbol: __asan_init
        > xgettext: symbol lookup error: .../instdir/program/libxml2.so.2: undefined symbol: __asan_init
        > xgettext: symbol lookup error: .../instdir/program/libxml2.so.2: undefined symbol: __asan_init
        > xgettext: symbol lookup error: .../instdir/program/libxml2.so.2: undefined symbol: __asan_init
        > xgettext: symbol lookup error: .../instdir/program/libxml2.so.2: undefined symbol: __asan_init
        > Traceback (most recent call last):
        >   File ".../solenv/bin/uiex", line 25, in <module>
        >     input = check_output(["xgettext", "--add-comments", "--no-wrap", ifile, "-o", "-"], encoding="UTF-8")
        >             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/usr/lib64/python3.11/subprocess.py", line 465, in check_output
        >     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
        >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        >   File "/usr/lib64/python3.11/subprocess.py", line 569, in run
        >     raise CalledProcessError(retcode, process.args,
        > subprocess.CalledProcessError: Command '['xgettext', '--add-comments', '--no-wrap', '.../basctl/uiconfig/basicide/ui/basicmacrodialog.ui', '-o', '-']' returned non-zero exit status 127.
        > Error: Failed to execute .../solenv/bin/uiex -i .../basctl/uiconfig/basicide/ui/basicmacrodialog.ui -o .../workdir//pot/basctl/messages.pot
        
        The solution is similar to e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid
        external processes picking up instdir/program/libnspr4.so" used in various
        tests.  And as Executable_localize appears to only be called in that one place
        in the recipe of `make translations`, for simplicity make the library path
        override a required fourth argument for that executable.
        
        Change-Id: Ia6326ac0bb12ea75a8b3df51f7fbf12b88aca634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142999
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [fd1b475143572655db18d2f1bc12309e3f5ab8d6]

        drop FT_Select_Charmap
        
        khaled: "I think this is probably a no-op now as we don’t call FT_Get_Char_Index
        anywhere (since mapping characters to glyphs is handled by HarfBuzz
        now). I think the whole symbol font concept might be no-op as HarfBuzz
        will internally use the symbol cmap subtable if the font has one and we
        don’t need to (or can) influence this."
        
        last use of FT_Get_Char_Index was removed with
        
        commit 23c5125148a8110d88385b29570bf0b7d4400458
        Date:   Thu May 10 15:46:06 2018 +0200
        
            Use HarfBuzz to get Kashida width
        
        Change-Id: I0c0b008fa8b8b1e10125cc2aa10b9f079df795d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143018
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [538ebbd4fa4241d59e49e33d3cedd04e02ca9287]

        remove FontAttributes::meCharSet
        
        its baked in that Symbol means RTL_TEXTENCODING_SYMBOL, so accept
        that status quo and make it explicit
        
        Change-Id: I78d90965e3d6b4543cd74a7847e13246485380d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Miklos Vajna  <vmiklos@collabora.com>  [7bf26fa8c848a15dde1c7c6b94edbee759a523d1]

        sw doc model xml dump: show the frame format of as-char images
        
        Old:
        
        <SwTextAttr ptr="0x63e5db0" symbol="12SwTextFlyCnt" start="0" dont-expand="false" whichId="58" m_pAttr="0x63e57f0" which="fly content"/>
        
        New:
        
        <SwTextAttr ptr="0x5af3d70" symbol="12SwTextFlyCnt" start="0" dont-expand="false" whichId="58" m_pAttr="0x5a44ae0" which="fly content">
          <SwFormatFlyCnt ptr="0x5a44ae0" text-attr="0x5af3d70" format="0x5af3bd0">
            <SfxPoolItem whichId="58" typeName="14SwFormatFlyCnt"/>
          </SwFormatFlyCnt>
        </SwTextAttr>
        
        Change-Id: Ie4f50d5ee065af920ac21a416f854ef7c7234707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143031
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [19b586543b08325897278ef8b4a65ac81615978d]

        qa: remove duplicated operators
        
        it's already defined in include/tools/color.hxx
        
        Change-Id: I26eaba4a1279fadd8669e9702b695e02871052d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142512
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-21  Maxim Monastirsky  <momonasmon@gmail.com>  [f23d3661ab04601650db95f846081317fc06801d]

        sd: table design editing
        
        Change-Id: I75559c80da015a13ee078bdda06f6f4975fe5946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140943
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-21  Maxim Monastirsky  <momonasmon@gmail.com>  [5d683e8f6c9e677d7b6bc829a4ce9ee384f4fbd8]

        Export modified table styles
        
        In addition to actually used styles, we want to
        export user defined styles, as well as built in
        styles that were modified.
        
        Detecting the real modification state might be
        challenging in some cases, e.g. when importing
        the style from an existing document. So for
        simplicity, we consider a style as "modified"
        if at least one of its child cell styles is user
        defined. The UI for modifying cell styles will be
        implemented in such a way that built in styles
        will never be modified themselves. Instead, a
        user defined style will be created on the fly,
        with the corresponding built in style set as its
        parent, and only that new style will be modified.
        
        It is still possible to modify built in cell
        styles via the UNO API, but such styles won't be
        exported unless actually used in the document.
        
        Change-Id: Ic73eb460fd024f23016553e134397e07259f5c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143011
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e4b47190eb762f3aea80920846fe5135b7d76fc]

        tdf#152053: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: If0de645a0ca0901862ef4e084e14ff60cbc3800b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143028
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-21  Szymon Kłos  <szymon.klos@collabora.com>  [0a55aa8ba38aea56a2bce1504fd687e510f66b9d]

        calc: cache GetCellArea results
        
        This will avoid repeated lookup in the ScTable::GetCellArea.
        Which is used for vcl::ITiledRenderable::getDataArea().
        
        Tested in CppunitTest_sc_ucalc
        
        Change-Id: Ied58cfe447e1b924af9b401e95e127c784b80355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142279
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142995
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-21  Szymon Kłos  <szymon.klos@collabora.com>  [d29349a3f8808e650a9432bd087e352845e8b0d3]

        lok: Notify about last used row and column in Calc
        
        We use HelperNotifyChanges::NotifyIfChangesListeners
        notifier so we know which cell was modified and we
        can correctly target only affected users.
        
        Change-Id: Iaeb68e350e85e4ed1492a7d350a790e68f2d63af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139473
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142994
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-21  Szymon Kłos  <szymon.klos@collabora.com>  [5762aa5c0efb75e8b7713b4c2ee8bd9300fc06cf]

        jsdialog: enable Delete content dialog
        
        Dialog had unused m_xBtnOk which has defined standard
        response in .ui file - no need to bind anything in the code.
        
        Change-Id: Ie743485bb30a03b82a87dc69015a704e14c39384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142903
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142993
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-21  Szymon Kłos  <szymon.klos@collabora.com>  [58ae6705deccb614f33d20bfa4b2ab0923d426e1]

        lok: allow password reset in properties>change password
        
        Change-Id: I92a3c658e96f602549ff5282b6ed5bc9ee780bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141372
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142992
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [be12f60b1055292ac655e53f4fb56567b5c15970]

        Fix typo
        
        Change-Id: Ie1ed42bed5ff91dd39136be11bf365e737853c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143021
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-21  Mert Tumer  <mert.tumer@collabora.com>  [67eb60672936a10fba840078e6aca918c3331f52]

        lok: make properties>change password dialog async
        
        * We now can set a password through properties->change password
          without having to have a password initially only for online
          because it needs a created file already, online works with files
          that are created before loading but the desktop does not need this.
        * The same dialog is still used as non-async for desktop version
          because it goes through an InteractionHandler and the result is
          expected not from the dialog but from the interaction handler.
          Therefore, making it async there did not make sense.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I3d02822be0b71836b1592abca191b3b1c5f6374e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139884
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142991
        Tested-by: Jenkins

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [2adaac8bf01a6caffd0eedb9f456eeadc43f1759]

        be more specific on what "Symbol" is
        
        Change-Id: Icd08628848cce74407552f57660d75b1ac9816bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Michael Stahl  <michael.stahl@allotropia.de>  [0f8262d34ba7130a8bd8907bc85e9f42fecafd51]

        vcl: GCC 12.2.1 -Werror=maybe-uninitialized
        
        Change-Id: I54ff61456682a312d5507aa6d740c0a72ea33ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142981
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-21  Balázs Varga (allotropia)  <balazs.varga.extern@allotropia.de>  [6edd93671c491938e52fce75a64f48f8a63d08a1]

        Revert "use uname for detecting WSL"
        
        Since this patch breaks WSL2 builds on windows.
        
        This reverts commit 5a8a1c4a86938b65c5ea7807f60e721946d7d8de.
        
        Change-Id: Idd68a2609b81881af87ae777b5c4bf9cc2d8ef88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142580
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-11-21  Skyler Grey  <skyler3665@gmail.com>  [19d02a1267cfa1e7a950af31a77d4a7888594630]

        Make the number format dialog an async jsdialog
        
        - The dialog needs to be async in order for multiple people to be able
          to use it at once
        - If we don't make the item set a shared pointer, we will crash out with
          an error when we try to copy it after the OK button is pressed
        - As the dialog is tabbed, we need to enable the dialog for all UI files
          that the dialog uses rather than just the main dialog UI file
        
        Change-Id: I8d684e9e9ad49b8a85ee940864d7219b4115a6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138270
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142990
        Tested-by: Jenkins

2022-11-21  Skyler Grey  <skyler3665@gmail.com>  [4b4e7ac74e2b72833de6b464b25b077b7541f43a]

        Make the insert caption options an async jsdialog
        
        - In https://gerrit.libreoffice.org/c/core/+/138313, the insert caption
          dialog was converted to an async jsdialog. It has 2 subdialogs which
          it opens when you press the 'options' and 'auto' buttons
        - This review converts the first of these (the options dialog) to an
          async jsdialog as well, bringing it up to parity with the parent
          dialog
        
        Change-Id: I703b66d8c786d8cbb0b1285014247b38d8d70605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138442
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142989
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [727141098b7d7bfed65e64d2062042269a8f6088]

        loplugin:unusedfields start removing unused weld fields
        
        Change-Id: If736ff669ffe24c3dd111c26285c19fc65806a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-21  Tibor Nagy  <nagy.tibor2@nisz.hu>  [ab10008ecaa33228838115a0b714e4f118c07ac1]

        tdf#149803 tdf#128150 PPTX: export UseBgFill of custom shapes
        
        Fixing tdf#128150 the UseBgFill property of shapes can
        be saved to PPTX, but not in the case of custom shapes.
        
        Follow-up to commits c4cf2e82e8d0aaef9b1daedc033d6edf647e5284
        (tdf#128150 Add OOXML import/export for "use background fill"),
        commit 50394abcc36a73c0205e6cb69d925c66c25f81f2,
        (tdf#128150 Implement/add SlideBackgroundFill visualization") and
        commit	9c2c48f14535e58cad0453fef584400ee703aecc
        "tdf#128150 xmloff: ODF import/export of fill-use-slide-background".
        
        Change-Id: Ib88f236d2533ef71ea66718d380e83d9a0685c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142489
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [e3245247421fc30c37a8b7321e2815e2507b5a1f]

        clarify IsSymbolFont means Microsoft Symbol encoding
        
        https: //freetype.org/freetype2/docs/reference/ft2-base_interface.html#ft_encoding_ms_symbol
        https: //learn.microsoft.com/en-us/typography/opentype/spec/recom#non-standard-symbol-fonts
        Change-Id: I77732fff67a145bd8fa347c3d0c8e4deb2083143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143008
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [8a93dbd60109a46b167bdc656bfb9a802ffe8f69]

        drop unused ImplFont::IsSymbolFont
        
        Change-Id: I7dfe4ef4a4b457a4f0ec0075e65a8397663ef99b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143007
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [b98e2979af71d1f415a856be98839f321371804a]

        drop effectively unused Font::IsSymbolFont
        
        Change-Id: I717319dd3843aa7d73d0722967e80f7d07e98143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143006
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [468277a0aec9a40f5d5f3db600088ae04a45e2c9]

        clarify what 'IsSymbolFont' in this external facing idl means
        
        Change-Id: I2cb2aab6797e55449e5e771192f48915baedc221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143005
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [7017ae2fd7161ee9ed07095f56dd3da9eb9e6b10]

        IsSymbolFont means that its a Windows Symbol Encoding
        
        so kCTFontSymbolicClass doesn't fulfil that meaning, if we want
        something more generic to indicate that a font is only useful
        for "icons, dingbats, technical symbols, and so on." then we need
        a different thing. Its baked in everywhere else that a "SymbolFont"
        uses RTL_TEXTENCODING_SYMBOL.
        
        Change-Id: Ie99b5068077dd385dec26f62e2e991e8381128d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142961
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [5a35ca12d98d7ad0bfc012d75d00f9eefb4ec078]

        drop ImplFont::SetSymbolFlag
        
        Change-Id: I8da977c3464e82e8a159143f9d1c73446ceee159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142960
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Caolán McNamara  <caolanm@redhat.com>  [2df9b7cd3fa03077c9809dab9b94a20dd89002fb]

        stop setting OpenSymbol as a "Symbol" font
        
        which has a specific meaning of a Windows Symbol encoding
        
        Change-Id: I6e5d079303fccfabc8204fc0dbae0870efb839a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142947
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-21  Jim Raykowski  <raykowj@gmail.com>  [1b031eb1ba6c529ce67ff8f471afee414d64a098]

        tdf#145359 related: SdNavigator dnd
        
        This is an enhancement patch that provides drag and drop capability
        within the Navigator page object tree to allow arranging object
        navigation order and grouping of objects.
        
        Change-Id: I76996cd909765fb3503cf077566bec267b7705e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142640
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-21  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [d5f29872f5a149fc7905cdf340215c07af0d4da8]

        sal/osl win32 : use non recursive mutexes in file and thread
        
        Change-Id: I7e0e7f7a8bdc3fa92beca10935bb3c62d57f92fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-21  Miklos Vajna  <vmiklos@collabora.com>  [3dc7aa719006aaf62be93ae92311c1859c2c7e19]

        sw: prefix members of BookmarkTable, SwCreateAuthEntryDlg_Impl, ...
        
        ... SwTOXButton and SwTOXEdit
        
        See tdf#94879 for motivation.
        
        Change-Id: I0fa3d1c6023ce42f3a1c23cc6b873ffa75516455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143013
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-21  László Németh  <nemeth@numbertext.org>  [d687d74a4e3ba70a4e21fcd7db532c3cffc7d4d2]

        tdf#113592 LibreLogo: update fallback localization
        
        Follow up to commit d4c92c836c42d8fa7e31657d0534bef3979a03e2
        "LibreLogo: add command FONTTRANSPARENCY".
        
        See also commit 5948e2e9f032916e3278f904097eff6b47b869d6
        "LibreLogo: fix ast, gug, hsb and sid language support".
        
        Change-Id: I6464091ce66ae302b1f6207f954bf06788bc1e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143004
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-21  László Németh  <nemeth@numbertext.org>  [07711c8482714f970c57688629c591f8f3aa135f]

        tdf#149800 SVG export: remove extra white line of semi-transparent shape
        
        A shape is exported using two svg:paths, first one is for the
        fill, and the second one is for the line. Semi-transparency of
        shapes enabled the disabled stroke of the first path, resulting
        an ~1 pt width extra white line behind the normal line of the
        shape. It was visible only, if the normal shape line was thinner
        than 1 pt, or if the normal line was semi-transparent or disabled.
        The extra line got the same transparency value, as the fill,
        so its visibility depended on that, too.
        
        Change-Id: Idc40971cc73ec9e4f241974ae29c876d06cc0658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143003
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-20  Martin Srebotnjak  <miles@filmsi.net>  [deb7bc82de19ea8e20c767fdf21f9ba4feb5e9f0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 5e9d458209fb3ee168e61c74388f3a0b64f2c12c
          - Updated Slovenian translation
            
            Change-Id: Iaaf4affe6172da08385569d4d158f3e073eb4297
            
2022-11-20  Stephan Bergmann  <sbergman@redhat.com>  [cb24017c84efdc91a73d91655664d9ae01a1d6d6]

        Clean up CfgParser::aStack
        
        This is apparently some very old, very poor XML parsing code full of
        questionable design decisions.  The silliness of pushing onto the opened-element
        stack also entities that don't have a closing tag (but which cannot easily be
        changed, see the added comment about CfgStack::GetAccessPath) caused consistent
        memory leaks when Executable_cfgex is executed during the build.  While those
        leaks are harmless, they might cause people to nevertheless try to clean them up
        in various ways (see the abandoned
        <https://gerrit.libreoffice.org/c/core/+/142718> "asan: fix leak in
        ExecuteAnalyzedToken/Push"), so just clean up those broken-by-design excess
        aStack elements.
        
        Change-Id: I849109906c6b102d9aa90300c2bada360c727d4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143001
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-20  Stephan Bergmann  <sbergman@redhat.com>  [e735de2051143347b7283c85ad80b0e2412522dc]

        Avoid some unnecessary, wrong downcasts during `make translations`
        
        > l10ntools/source/xmlparse.cxx:491:51: runtime error: downcast of address 0x603000000610 which does not point to an object of type 'XMLParentNode'
        > 0x603000000610: note: object is of type 'XMLDefault'
        >  00 00 00 00  30 44 a7 dd a0 55 00 00  00 05 10 6e a4 7f 00 00  80 00 00 00 60 60 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'XMLDefault'
        >  #0 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:491:51
        >  #1 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:481:9
        >  #2 in HelpParser::CreatePO(rtl::OString const&, rtl::OString const&, XMLFile*, std::basic_string_view<char, std::char_traits<char>>) at l10ntools/source/helpmerge.cxx:91:20
        >  #3 in sal_main_with_args(int, char**) at l10ntools/source/helpex.cxx:124:17
        >  #4 in main at l10ntools/source/helpex.cxx:47:1
        
        and
        
        > l10ntools/source/xmlparse.cxx:523:44: runtime error: downcast of address 0x6030000007c0 which does not point to an object of type 'XMLParentNode'
        > 0x6030000007c0: note: object is of type 'XMLData'
        >  00 00 00 00  e0 53 d5 c0 46 56 00 00  d0 00 00 00 40 60 00 00  f0 07 00 00 30 60 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'XMLData'
        >  #0 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:523:44
        >  #1 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:492:80
        >  #2 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:481:9
        >  #3 in HelpParser::CreatePO(rtl::OString const&, rtl::OString const&, XMLFile*, std::basic_string_view<char, std::char_traits<char>>) at l10ntools/source/helpmerge.cxx:91:20
        >  #4 in sal_main_with_args(int, char**) at l10ntools/source/helpex.cxx:124:17
        >  #5 in main at l10ntools/source/helpex.cxx:47:1
        
        and
        
        > l10ntools/source/xmlparse.cxx:526:48: runtime error: downcast of address 0x603000000820 which does not point to an object of type 'XMLParentNode'
        > 0x603000000820: note: object is of type 'XMLComment'
        >  00 00 00 00  28 06 92 a9 17 56 00 00  d0 00 00 00 40 60 00 00  40 00 00 00 20 61 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'XMLComment'
        >  #0 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:523:44
        >  #1 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:492:80
        >  #2 in XMLFile::CheckExportStatus(XMLParentNode*) at l10ntools/source/xmlparse.cxx:481:9
        >  #3 in HelpParser::CreatePO(rtl::OString const&, rtl::OString const&, XMLFile*, std::basic_string_view<char, std::char_traits<char>>) at l10ntools/source/helpmerge.cxx:91:20
        >  #4 in sal_main_with_args(int, char**) at l10ntools/source/helpex.cxx:124:17
        >  #5 in main at l10ntools/source/helpex.cxx:47:1
        
        Change-Id: I1e2c6bf802aa03b5b1eb21532e98fa22d966e683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143000
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-20  Khaled Hosny  <khaled@aliftype.com>  [1f9b2a7057a519e0ea750875ac439129f1d3df87]

        vcl: fix glyph positioning for artificial italic
        
        Let HarfBuzz transform the glyph positions as well, so that e.g.
        combining marks get shifted relative to their slanted base glyphs.
        
        Change-Id: Ib399ab462b36effdc21c4bbeba79d65214792f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142979
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-20  Khaled Hosny  <khaled@aliftype.com>  [d4005521e4fe4379381605b63af1950c5aecd798]

        vcl: add NeedsArtificialBold/Italic() to LogicalFontInstance
        
        Change-Id: Ie8bab5d7653a22d0f56b4c859fb2260d96e655c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142998
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-20  Khaled Hosny  <khaled@aliftype.com>  [f88e7632b745a9b18af36cd901399c40e8b7378f]

        vcl: unify skew for artificial italic
        
        Cairo, Skia, Core Text, and PDF all were using slightly different skew
        for artificial italic.
        
        On Windows, we don’t even apply the skew ourselves and let DirectWrite
        apply it.
        
        The value chosen here should be the same as the one applied by
        DirectWrite for consistency (measured manually, and confirmed against:
        https://source.winehq.org/git/wine.git/blob/5d1820c40bd93e6810f072a39745ee739ba99b81:/dlls/dwrite/freetype.c#l467)
        
        Change-Id: I3ab017b4cd7a3b4dba097cd302333a88e4c16350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142980
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [e535da3b6d72c0aca312dcf1ca38a3fcc3532a38]

        vcl: add unit tests for OutputDevice::GetTextRect()
        
        Change-Id: Ic36d42b0b38083c6a9ce3b6af4d80d5acf3e96e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140906
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-20  Skyler Grey  <skyler.grey@collabora.com>  [9a0a7ae8f62cc8233b71057caa6bc88c69ee94a1]

        Make the insert caption dialog an async jsdialog
        
        - Using StartExecuteAsync instead of Execute to execute the dialog makes
          it run asyncly
        - We need to add a handler for the OK button, otherwise the event won't
          be fired when it's clicked. There seem to be varying names for this
          throughout the codebase, I've chosen OKHdl as it's short, appears to
          be relatively common and fits well with the existing OptionHdl and
          CaptionHdl that the other buttons on the dialog use
        - Lastly, we need to enable the JSDialog builder in
          vcl/jsdialog/enabled.cxx so that the dialog becomes a JSDialog
        
        Still TODO:
        - Convert the dialogs that open when you press "auto" or "options"
          buttons (will be in a followup review)
        
        Change-Id: Ieabbc4e69c4aa065506f7dc6c823d83e4d784c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138313
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142988
        Tested-by: Jenkins

2022-11-20  NickWingate  <nick.wingate@collabora.com>  [930b96dee6250eb8d51f25e2e1020bd1e028db03]

        Enable File Properties for JSDialogs
        
        - Disable security tab as protect/password subdialog
        not fully async-ed
        - Disable custom property tab as still unstable
        - Hide Digital signatures button
        - Make duration dialog async
        - Set location as file name
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: I5843bb7737af8dd6b7d3af273ddd8997f2e35e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138010
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142987
        Tested-by: Jenkins

2022-11-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [deb0bb9f2635a8dfec90b42e3727f4224548a8e9]

        tdf#126457 - Add URL and workbook name to window titles
        
        The Windows object allows to activate a window using its caption. The window caption is the text shown in the title bar at the top of the window. It can be changed which does not affect the name of the workbook. In MS these captions are unique, i.e., a file with the same file name stored in a different directory can't be open.
        
        However, LibreOffice allows to open files with the same name. So in order to make it as closely to the functionality of MS, the windows activate method now works with URLs and changed window captions.
        
        It has still to be clarified what happens if two workbooks have the same caption.
        
        Change-Id: I77a8680bc64b5992191df2fa1a7d475f9a48f518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140627
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-11-20  Kevin Suo  <suokunlong@126.com>  [bc48dbe08db537f41e42839a0493317298606413]

        sdext.pdfimport: Use string() in xpath for testTdf104597_textrun
        
        ...and remove the TODO comments.
        
        Also, comment out the test for string ٱلسََّل which is related to tdf#152083 and will be fixed in a separate commit.
        
        Change-Id: I075145be1ff58c16e976c710fbf8f55fc6752af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142962
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-20  NickWingate  <nick.wingate@collabora.com>  [346cda683763aa352cf67a035340e48133790f7f]

        Fix opening duration custom property shows text
        
        Before saving a duration custom property and
        then closing and opening file props wouldn't
        show the duration type and value and instead
        blank text
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: Ie6536dd75151db40f335985c1ce92236ce77ddc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138180
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142986
        Tested-by: Jenkins

2022-11-20  NickWingate  <nick.wingate@collabora.com>  [d7f00522a2dd84b05371920ebbcf6f81323a666f]

        Fix sending empty tab pages to online
        
        Previously this assumed page ids were sequential
        if a page is removed then its id returns an empty
        page. Fetching window child also worked based on
        iterations and not comparing actual ids so another
        possibility for empty pages.
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: I908f58665a9429ca4b66f346108030926a599d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138181
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142976
        Tested-by: Jenkins

2022-11-20  Skyler Grey  <skyler3665@gmail.com>  [6179026d162a4281ae158ccca7897f6059f1338c]

        Add a title to the widget test dialog
        
        - Previously the widget test dialog didn't have a title, however most of
          the other dialogs do. This commit adds a title to the dialog
        
        Signed-off-by: Skyler Grey <skyler3665@gmail.com>
        Change-Id: I8b61e00e93cd71a6a7bf068537d9cbcdc735753d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137534
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142975
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-20  Skyler Grey  <skyler3665@gmail.com>  [318d6175f2cf4328bbd6e88f4f64adfe314d759b]

        Enable JSDialogs on the split cells dialog
        
        - This dialog works properly when JSDialog rendering is enabled for it
        - This dialog is already async, so there aren't multi-user issues like
          there are on some other dialogs
        
        Signed-off-by: Skyler Grey <skyler3665@gmail.com>
        Change-Id: I036ca7ab15e0ab472ff961ef643053f8f6771c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137791
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142973
        Tested-by: Jenkins

2022-11-20  Skyler Grey  <skyler3665@gmail.com>  [b5d3a3ac031d055e433eb2b79b48f6d00fb0e0d6]

        Turn the split table dialog into an async JSDialog
        
        - Previously the split table dialog was not an async dialog, and it
          wasn't a JSDialog either
        - A non-async dialog has issues when multiple people try to change
          something using the dialog at the same time. Generally the changes
          from one person will not be applied until all people who opened the
          dialog later than them have submitted
        - This PR makes the dialog async, fixing multi-user issues with it
        - This PR makes the dialog into a JSDialog, rendering it on the client
          with native HTML elements
        
        Signed-off-by: Skyler Grey <skyler3665@gmail.com>
        Change-Id: I9254bc1b635531c8b38d1ade76f99ffdda145b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137741
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142972
        Tested-by: Jenkins

2022-11-20  rash419  <rashesh.padia@collabora.com>  [67160035d65f9b43b8483e5900d2a2812e1bbecc]

        sw: jsdialog: enable contentcontrol and contentcontrollistitem dialogs
        
        contentcontrol: fix: modify, remove, move up/down buttons doesnot work even if item is selected in jsdialog
        
        Signed-off-by: rash419 <rashesh.padia@collabora.com>
        Change-Id: Ib038ce2a3ff6f92ab7314b18f36a038991a35f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135902
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142971
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-20  rash419  <rashesh.padia@collabora.com>  [ba5e0013e74f072300e808e4d8d679b6f42bff92]

        jsdialogs: added WidgetTestDialog to test different vcl widgets in online side
        
        Signed-off-by: rash419 <rashesh.padia@collabora.com>
        Change-Id: I27cbb72b4ccd486b58934503b1d3d5d7ff47cbfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132865
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142970
        Tested-by: Jenkins

2022-11-20  Khaled Hosny  <khaled@aliftype.com>  [64d4275b60d50a87fb2bf4dd45be3c28902cec52]

        vcl: fix artificial bold and italic on Windows
        
        Move creating DWFontFace to WinFontInstance so that it get proper font
        synthesis settings.
        
        Regression from:
        
        commit a80239ede3236c84d7a05d0fbc0f299811fee6c0
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Sat Nov 19 03:03:15 2022 +0200
        
            vcl: move creating DWFontFace to WinFontFace
        
        Change-Id: Ifba947d8908a37972d723028258500b10ec24cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142982
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [16a7e944ab1b318fafb7dd48d48379168403d2e8]

        Fix typo
        
        Change-Id: Iaa40db0f7799c70f39bb74d9768f84ff236502ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142977
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-19  Siddharth  <skhattar111@gmail.com>  [9cac01b4f19c8fc3adb1a19a71b2f214a1586d8f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I50c2c0f202780d06b556ae82b51bab5c3f79d72e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142498
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [931e3d204e59ccb2e9c479477e6e66b2c098924f]

        lok: masterpage: Introduce mode property to tile rendering
        
        This is needed for Impress which can have slides in
        two Edit Modes: Master Page and Page.
        
        Change-Id: I3eca0f51ba7970e793026d1ac6aa09b19b7a904b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137869
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142969
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Maxim Monastirsky  <momonasmon@gmail.com>  [553cfbfc9e74a03fe02a58e9aa6076fc1dddeb7b]

        Prepare the dialog for cell style editing
        
        Change-Id: I54ec1486f49f240e1ab88662b9d1b0b741cf8878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142905
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [bac26f91ae930902c336b1e5ceb08e1ae5de8d8a]

        lok: masterpage: disable callbacks on painting
        
        We did that only for original view, but we need to disable
        callbacks for used view - so when we switch mode or part it
        will not send the notification to the client.
        
        Bug fixed by this patch:
        1. open impress in two LOK sessions
        2. A enters MasterPage mode
        3. B switched slide
        4. A exits MasterPage mode
        
        result: A was switched to the slide selected by B
        
        Change-Id: I7dde8bb4c73862813d064319922aba4c4b727db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142716
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142966
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [325bab6a92921a0356cc3e1c66f14ad0c6200d85]

        Dont use equal name for label and widget
        
        Change-Id: I71b052aff4317b416f0c02bde549461b64f1a6f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142181
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142968
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [2dd51938908b9856bd1ad4b252cd60805262baa5]

        lok: masterpage: don't switch page on mode change
        
        Go back to the last used page when closing MasterPage.
        There was a bug when one user was in MasterPage mode and
        other switched page - then on close we opened other user
        page.
        
        Change-Id: I02f3b36429a62b855b215803d6684b3382228326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142740
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142967
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [fc656a56b283ec0eb308faf78fa171fd69b1e807]

        jsdialogs: correctly detect button's handler
        
        Change-Id: I5bb3e60d52813fddfc9a5eb7a0e87d5f5e3853f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142904
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142964
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Szymon Kłos  <szymon.klos@collabora.com>  [71c88cf9d5f5dffa86e5a111e19468a5a2a2b6c0]

        lok: masterpage: don't remove old cache
        
        In multi user view when switching between MasterPage and Page
        mode it was failing to find cache because it was removed by other
        views. We need that to allow invalidation after master page changed
        something.
        
        Change-Id: I070345b0fe6942965aece5bf729ceb37b7d99397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142697
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142965
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec6502a1f61fcbd4bf05b62f172650fe442c3a1d]

        tdf#151846 Restore XChartTypeTemplate
        
        Which I removed in commit 58766f997d59e4684f2887fd8cdeb12d2f8a9366.
        
        Turns out it does have some usefulness for extensions. So restore most
        of it. The exception is the getDataInterpreter method, for which I have
        added a placeholder, so that the restored class has the same vtable
        layout as the original.
        
        Change-Id: Ief9b48ef2c408580bc24b5a8a0e11131edb3b943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [a38bb773bb568ef942293f23d0701da933817e8f]

        vcl: use std::optional in PhysicalFontFace
        
        Otherwise when a font does not, say, support variations or color
        palettes, we keep querying the font each time they are requested.
        
        Change-Id: I3a41bc73dd814b25af3a8b5b009632ecf7ef27ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142963
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [e65b0bf83b8225fde81ee7b10c1fa4b9f32b6ed1]

        vcl: add WinFontFace::GetVariations()
        
        This makes font variation settings to be applied to glyph advances and
        text layout, not only glyph shapes.
        
        The sw-extra.h file is needed because we target Windows 7 and the
        interfaces we want to use are only exposed for Windows 10. File copied
        from:
        
        https://hg.mozilla.org/mozilla-central/file/704f09a557a4dfc9057f1672b711789f64f74a82/gfx/2d/dw-extra.h
        
        Change-Id: I7bbb4c3f2b70274754f844fedb0c4329c8f649a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142347
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [d00ed8359c082f460e5f318ddf180513ca429e46]

        vcl: make WinFontFace final
        
        Change-Id: Ie64c155c8dc4d2a4819d4f60999cbb8355687d86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142958
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [a80239ede3236c84d7a05d0fbc0f299811fee6c0]

        vcl: move creating DWFontFace to WinFontFace
        
        Change-Id: Ie0e94787d962eaec7753ae50d548ad8655dbc209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142957
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [042473d4b162c87a27a55e9b9f076b5fc479a55a]

        vcl: move creating DWriteFactory to a centeral place
        
        We already have code in two places to create it, and I will need it in
        yet another place.
        
        Change-Id: I12dee85347a3894045c345b0ec9d5e02c493c218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142956
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  Khaled Hosny  <khaled@aliftype.com>  [0cf71ca47b463c0b944e31aa7bd66fdaf9097f8e]

        vcl: remove unused D2DWriteTextOutRenderer code
        
        Change-Id: I873d13e3a230c2679daea2080a102d89003c90c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142955
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-19  László Németh  <nemeth@numbertext.org>  [6f0736c2981042f90e83cdd71b3f9c91dbe77661]

        tdf#152106 sw layout: fix freezing of multicol sections with flys
        
        Loading documents with multicol sections with flys could
        freeze Writer. Add loop control for multicol sections to fix it.
        
        Regression from commit 8feac9601cfe35ee0966776bab15d122206f154e
        "tdf#138518 sw: layout: avoid moving flys forward prematurely".
        
        Follow-up to ed12269c42f75f553bb8a8770923406f7824e473
        "tdf#142080 sw: layout: fix infinite loop in CalcContent()".
        
        Change-Id: I06eb3f5a26b2d2ac3999b98a9661112b8bf7738f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142950
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-19  Caolán McNamara  <caolanm@redhat.com>  [b72cf572bbf330bee411806c65c5bc2ff093a938]

        ofz#53547 integer-overflow in poly is a lost cause I feel
        
        Change-Id: I3a8f67244ec8cf3d6c6abe9641c1d70f385567e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142959
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-19  Caolán McNamara  <caolanm@redhat.com>  [4e4ca58abbbcbf03e69434062cdbfebe17113430]

        ofz#53525 Abrt
        
        Change-Id: Ia99d6aff1e7e9b90167fc535c1fc7951e7f4b2b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-19  Julien Nabet  <serval2412@yahoo.fr>  [37c1ad25be11d3b2256b1dce577abc426f6a73f6]

        deepL: Dutch is "NL" and use "LV" for Latvian
        
        Change-Id: I18d56ac373594abca2d994c709fa4579bdfe4d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142838
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f0030353b38dfec4ceedc72d32884dbdde583d1b]

        loplugin:unusedmethods
        
        Change-Id: I5dcba14a9b0dfcc5267760410f6d135fcd3b1bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142944
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [cfe88f4ab51c9330c0418cbd8b7093db515f9bd5]

        Simplify a bit
        
        Change-Id: I776259d8a79464b536fe90da8b25801d73ced9a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142952
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-19  OmkarAcharekar  <omkaracharekar12@gmail.com>  [bcf333309f9a9bde21aac1302cbead2b23822458]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I19ecfe80e9a927c14db2680188baa54cb4911d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142535
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [f4b5ecb54dbe216677b3eeb9a03f63da7df8223f]

        use OpenSymbol as bullet font instead of StarSymbol
        
        Change-Id: Id9ec305c3d43c3a811cb95794eaa5349bc3e4b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142938
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [66fbd32b8cc60d350f02812d3a04f8714c0d77e0]

        add documentation that this means Windows Symbol encoding
        
        Change-Id: Ib2bbba8a21b6c82ca83c067a99dcd9bb41537e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142939
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4714b371809fb0e65073cbc95b4aafedb2c6a9ca]

        sc: move isFormulaWithoutError where is used
        
        Change-Id: I846e1621b0ab82a921a12a0f1440ccb0e6c75215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142951
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [785aa638acb920316fe78bedab3a512fb384535a]

        Turn around usage of TextHierarchyEditPrimitive2D
        
        This primitive is created if a text edit is active
        and contains it's current content, not from model
        data itself.
        Pixel renderers need to suppress that content, it
        gets displayed by the active TextEdit in the EditView.
        Suppression is done by decomposing to nothing by
        default.
        MetaFile renderers have to show it, so that the
        edited text is part of the MetaFile, e.g. needed
        for presentation previews and exports.
        So take action here and process it's content.
        Note: Former error was #i97628#
        
        Change-Id: I32c83c0ad7883a79fc40f5a21ac6ed7b1055b7df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142910
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-18  Stephan Bergmann  <sbergman@redhat.com>  [50d73574b6c3d71f9a539c895a15d6fcda22390b]

        Related tdf#104597, tdf#151546: Introduce comphelper::string::reverseCodePoints
        
        69e9925ded584113e52f84ef0ed7c224079fa061 "sdext.pdfimport: resolves tdf#104597:
        RTL script text runs are reversed" and f6004e1c457ddab5e0c91e6159875d25130b108a
        "tdf#151546: RTL text is reversed (Writer pdfimport)" had introduced two calls
        to comphelper::string::reverseString into sdext.  That function reverts on the
        basis of individual UTF-16 code units, not on the basis of Unicode code points.
        And while at least some pre-existing callers of that function want the former
        semantics (see below), these two new callers in sdext apparently want the latter
        semantics.  Therefore, introduce an additional function
        comphelper::string::reverseCodePoints with the latter semantics.
        
        I identified three other places that call comphelper::string::reverseString:
        * SbRtl_StrReverse in basic/source/runtime/methods1.cxx apparently implements
          some StrReverse Basic function, where a (presumably non-existing) Basic spec
          would need to decide which of the two semantics is called for.  So leave it
          alone for now.
        * SvtFileDialog::IsolateFilterFromPath_Impl in fpicker/source/office/iodlg.cxx
          reverts a string, operates on it, then reverts (parts of) it back.  Whether or
          not that is the most elegant code, using the latter semantics here would
          apparently be wrong, as double invocation of
          comphelper::string::reverseCodePoints is not idempotent when the input is a
          malformed sequence of UTF-16 code units containing a low surrogate followed by
          a high surrogate.
        * AccessibleCell::getCellName in svx/source/table/accessiblecell.cxx apparently
          always operates on a string consisting only of Latin uppercase letters A--Z,
          for which both semantics are equivalent.  (So we can just as well stick with
          the simpler comphelper::string::reverseString here.)
        
        (Extending the tests in comphelper/qa/string/test_string.cxx ran into an issue
        where loplugin:stringliteralvar warns about deliberate uses of sal_Unicode
        arrays rather than UTF-16 string literals wrapped in OUStringLiteral, as those
        arrays deliberately contain malformed UTF-16 code unit sequences and thus
        converting them into UTF-16 string literals might be considered inappropriate,
        see the newly added comment at
        StringLiteralVar::isPotentiallyInitializedWithMalformedUtf16 in
        compilerplugins/clang/stringliteralvar.cxx for details.  So that loplugin had to
        be improved here, too.)
        
        Change-Id: I641cc32c76b0c5f6339ae44d8aa85df0022ffb05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142949
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f49fc7b2a56e0d806ab8aab6e32fd1cd55c5c93]

        sc: these methods are only used in ScSimpleBootstrapFixture
        
        reduce the scope
        
        Change-Id: Ie9e36a6d1b48ca87ce0fd8e29cafd76adf9caaaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142834
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7341392c9450ca14db7ed7b36ef2d21aad289495]

        CppunitTest_sc_ucalc_sparkline: inherit from ScSimpleBootstrapFixture
        
        tests in here don't deal with import/export of documents
        
        Change-Id: I93cacb79bd75577d44fb42a1f87dc60e6bfcc13b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142912
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [077931c77e095f789eb62b60e66b0bc87535b57c]

        sc: split CppunitTest_sc_sparkline_test into two
        
        rename SparklineTest.cxx to ucalc_sparkline.cxx
        for a follow-up refactoring
        
        Change-Id: I2a8aeec5ffbd994c27102461a71cf0c0ec13dfed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142911
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [5cc9ab736aa61c7395be0f6960064de36063f677]

        sc: rename these tests to ucalc_*
        
        All inherit from the same class, just to be consistent.
        this is part of a follow-up refactoring
        
        Change-Id: I9f69ae16c9363996a95a684183d6c0e981594405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142907
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [952b876d5190781e2051bbb6ffcd835d108daf87]

        mustTestImportOf is dead
        
        since
            commit a5e416712e9477c496ce5fd4d935133083330ddf
            CppunitTest_sw_ww8export4: remove not needed mustTestImportOf()
        
        Change-Id: I00721babc7cd1a66a5220e33567ad46b62acc681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [e68476242571ea434098fb66bef87820bef9b599]

        AddWindowToPaintView -> AddDeviceToPaintView
        
        ... and likewise DeleteWindowFromPaintView -> DeleteDeviceFromPaintView
        because they add/delete output devices, not windows, ever since commit
        53fd4bb47c53cbb62a542c847ed38238e7b3e148 (INTEGRATION: CWS sdwarningsbegone
        (1.42.34); FILE MERGED, Dec 12 18:19:15 2006)
        
        And use references instead of pointers, because they are dereferenced
        unconditionally.
        
        Change-Id: I67d5841babaec040aa5308e95f333948eb0dde2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142945
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [2fa426da15a12e2a63554247e3c1c3f8c0ec5c24]

        Fix dynamic_cast after splitting OutputDevice and vcl::Window class hierarchies
        
        ... in commit 9090dc1f3b27195f5defd35586ac79357992be21 (split OutputDevice
        from Window, May 17, 2021), which I desribed in tdf#152103.
        
        Change-Id: I07d2be9a74939ad6a65bb9537bf7390ed4fca6a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142942
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [9072d06f6507899aaaab5e6171b994a113f14214]

        ScBootstrapFixture: simplify code a bit
        
        Change-Id: I856b0f332a91b570d583d6a4146c6ac353c5e672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142937
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [e2dc54a9016a03aa94c54836e67250454cf2bf68]

        remove unused Font::SetSymbolFlag
        
        not used outside cppunit tests and it's not something to encourage
        to toggle
        
        Change-Id: I6519de48dfaa20293afc0874702653439e142285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142940
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [085c179b9e146ef27d98aed72d5b681c585cabfc]

        Simplify a bit
        
        Change-Id: Ie2cdb0a361376b488d9829c892c9f4c6e9711503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142941
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [7b23c53232245a1f61c3e8ddff59d049a49fe975]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b60b4ebbd1289522a96a0ad6e344a9f6a77d78c3
          - Related tdf#149221 Create an entry for the Help button in Frequently-Used Buttons page
            
            The help page "Frequently-Used Buttons" (text/shared/00/00000001.xhp) lacks an entry for the Help buttons in dialogs. This patch creates such entry.
            
            This patch also adds a HID target so that when the user presses F1 and the Help button has focus in the Database Wizard, this page is then shown.
            
            Other wizard dialogs should use a similar strategy when F1 is pressed and the Help button is focused.
            
            Change-Id: I1295a7711c30e9cf47dbb18c784541e75eb90b71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142915
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [003c837e9d029a671ea95f76da45573bbc260eea]

        rename IsStarSymbol to IsOpenSymbol
        
        Change-Id: If525ba9826f5bc2d860233cbabf58d1d290be054
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142936
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [a4a865a85cfc922e75ed2ad5188e45a76bca92aa]

        tdf#47679 explicitly don't write fcharset2 for text in OpenSymbol
        
        we don't convert to the charsets we claim the fonts are in when
        we write our text so rtf imports mangle this dubious output.
        
        cheapest thing is to just write default fcharset0 for OpenSymbol
        
        Change-Id: Iea0e0d3a9bda5b5c7bcffba8499195f50e214aa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Caolán McNamara  <caolanm@redhat.com>  [f017eaf5d615faaf36f784b65005329ec29d16fb]

        ofz#53450 Integer-overflow
        
        Change-Id: Iccabfb8991a4dca6ec05565f01f6cff82c642d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142934
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-18  Justin Luth  <justin.luth@collabora.com>  [e960d3fea28fe4c180dc5612ce00682e432e9772]

        sw content controls: fix SdtHelper missing clear() items
        
        Found during a code read, while attempting to add another property.
        
        Change-Id: I342c51c81f23e1e3178e7d412f9af685f3fd4ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142839
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a85aeafdcf32c0452f2148aaa2b4e71d12154ec3]

        Fix typo
        
        Change-Id: Id63d9cbd5c224904c852249cb5aee7509136166b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142909
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-18  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [5eb669d9afbd7ec54e00950fa4832c7756cdf132]

        Improve English in recent translatable strings
        
        Change-Id: I5d2b035ebb35c9bc32fc6cbe96685148e9c155a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142832
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-11-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5e9ba2e6bc08493b10268abdec0c22c1d7c307f6]

        sw: handle joining and splitting nodes for online a11y check
        
        Change-Id: I706bf56209beebbe2987bce436536c3d9ade51f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142655
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [950bd818eb37e79c2276ce919f90d177255d5520]

        tdf#148999 Add rescan button to PDF a11y check dialog
        
        Change-Id: I772f529ea4bd225701b9864ad9156c573f41484c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142715
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [0cef06f0a2c0963e8c1579b78975710e6af4471c]

        vcl: test getting glyph boundary rect from LogicalFontInstance
        
        MacOS produces a slightly different glyph height.
        
        Quoting from Khaled in dev IRC:
        
        "Currently GetGlyphBoundRect() calls different platform-specific
        implementations on each platform, so even with the same font it is
        possible to get some difference. So my suggestion is to use a large font
        size and allow for some fuzziness".
        
        Consequently I'm using a 110pt font.
        
        Change-Id: I939e633eb1e45a16171ad0675216246b31966454
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141234
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [45d1fca81991f0d6837c98d6be6fe0d21d566fa5]

        sw: run document properties a11y checks on a loaded document
        
        Change-Id: Iba98a91a61955af52651348409f88244d1eed2c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142216
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [00128f14c400b661444676410b2088aca357291c]

        sw: add a menu option to enable/disable online a11y check
        
        Change-Id: I656037ef4e40e7c79daef5dd73f8f10c9818ac25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142215
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [0eec6d44c65f895c6fe2172792717418627db05d]

        sc: move CppunitTest_sc_parallelism to check
        
        like the other classes inheriting from ScSimpleBootstrapFixture
        
        Change-Id: Ia067bd506274f8526e6567c3f6dc395dd87c480c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142899
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [a709c5233a18af2c799f73a81d99b740cd89b191]

        Gtk-WARNING: 'label' is not a valid child type of 'GtkGrid'
        
        probably since:
        
        commit 0f0fd9c6e35a86f03606361211067c7887c3e0fc
        Date:   Thu Oct 27 23:03:08 2022 +0200
        
            tdf#148017 harmonize sidebar .ui files for chart2
        
        Change-Id: Idd2f485443f5b186f2a0d8e2539ed76e41c62e3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142897
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [e29418c582f15595d804fb499b9635e8545f1506]

        Resolves: tdf#152087 strip any newlines from the entry
        
        Change-Id: I965ecd89c7edaf1a02d3f94df23f09c9e9490d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e296065c6c12ed13b28d0e21445d1fe75b54a3c]

        sc: move CppunitTest_sc_sparkline_test to slowcheck
        
        so it's executed in all platforms
        
        Change-Id: I53c04cd9623e0d50b8216a135ede67f72d5d6b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142842
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9174e784f8bbd802c8a8719a0a59bec5ad1af90c]

        sc: these methods are only used in ScModelTestBase
        
        reduce the scope
        
        Change-Id: I2c02579e981de218d1f8ec6034b541ee2fdd8870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142841
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [432f94c9453c21d888556eec96f9904efe142f90]

        CppunitTest_sc_parallelism: remove duplicated code
        
        those methods are already in ScSimpleBootstrapFixture
        
        Change-Id: I06f3c9f8a45d8d801759cba2812e96b34065065b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142895
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [0aa61812a87ac466bea4b35cba75a4e986be8c7f]

        tdf#151904 Make grammar mistake color configurable
        
        This patch creates a new color entry in Tools - Options - Application Colors for "Grammar mistakes". Default values are also set for the "LibreOffice" and "LibreOffice dark" schemes.
        
        This patch also applies the selected color to the document, as well as in the SpellChecker dialog.
        
        Change-Id: I07f79da9858b675b330540cf08cf389dce39228d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142294
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2022-11-17  Rene Engelhard  <rene@debian.org>  [50582d73c61165f17c38ce28f216739a3a34664b]

        fix system-libfixmath build without  mergelibs
        
        missing -llibfixmath do it doesn't get it while it seems to get it via
        tools/libtl (which has it) in the mergelibs case
        
        Change-Id: Idb6a0079a63ffb1cff0fc1cafb2c11dfa3bec5b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142817
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [3b6316f25e6679aeaf70740acbaf8bb4a68bbece]

        ofz#53452 Out-of-memory
        
        Change-Id: I12e9a87f675d2e625a49d9736bca331a1d3879c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [f44f5f12605f32d92c2c1689e3e6888337eca2d9]

        ofz#53457 sanity check the form field range
        
        Change-Id: I2a1c82bb0590acf8f2399f2ea4b6b477600c7908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142840
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Stephan Bergmann  <sbergman@redhat.com>  [d6a3510ebc04dd5f24366f5b6426060cb149c3ff]

        Revert "TempFile: clear handle on close"
        
        This reverts commit 0d9613b77fc653c6144b5e4f0136c0536300c0db:  As discussed in
        the comments at
        <https://gerrit.libreoffice.org/c/core/+/142344/2#message-c52fe7b2037e717525e89dd20a8f320142654ae0>
        "TempFile: clear handle on close", that change was intended to reset *pHandle to
        null in cases where osl_createTempFile returns an error and has already set
        *pHandle.  But that is obviously not what the change actually does, it rather
        sets *pHandle to null in (only some of the) cases where osl_createTempFile
        returns an error and has not modified *pHandle.  Given that there may
        potentially be clients that rely on osl_createTempFile not modifying the passed
        in *pHandle when it returns an error, and given that the
        sal/osl/unx/tempfile.cxx implementation of osl_createTempFile now inconsistently
        set *pHandle to null in only some of the cases where it returns an error while
        the sal/osl/w32/tempfile.cxx implementation of osl_createTempFile never sets
        *pHandle to null when it returns an error, it appears best to just revert that
        change.
        
        Change-Id: Ia68353d04a488b024573ad03de0c5e5bd6e2a2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142798
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8c56abfa64be106c44b2d878968b9b019e126c40]

        sw: convert ViewOptFlags1 from bitflags to struct of bools
        
        Much easier to deal with - let compiler do the bit setting.
        
        Change-Id: I9412e1a2f15e41c9ebf502af57b127c283fc1fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142214
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-17  Miklos Vajna  <vmiklos@collabora.com>  [21c4749d0205d1ba90494edc2527ff9d11f86f87]

        Related: tdf#54053 PDF export: add UNO API to customize the watermark color
        
        PDF export has a watermark feature, but its color is hardcoded to light
        green, which won't fit all documents.
        
        On the other hand, the input from Heiko in
        <https://bugs.documentfoundation.org/show_bug.cgi?id=54053#c12> is to
        keep the dialog clean, so adding one more UI option is not great.
        
        Fix the problem by only adding the option at an UNO API level for now,
        this relaxes the hardcoded color without cluttering the UI.
        
        Also available on the cmdline for e.g. 0xff0000 / red color:
        
        soffice --convert-to pdf:writer_pdf_Export:'{"Watermark":{"type":"string","value":"draft"}, "WatermarkColor":{"type":"long","value":"16711680"}}' test.odt
        
        Change-Id: I38a3650df86fd34dfc09e3a5643511baa371aa83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142835
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-17  Bogdan B  <buzea.bogdan@libreoffice.org>  [5dee0f895bd5650db974be0c24c7b8d78035fd0b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c075b1fefe6b5220c1b4cdddbb5ed6b6331d4f5
          - tdf152013 Remove "imports one" when opening a file
            
            Change-Id: I6d3c7a6f00b8cc704c94d48be9a82a353c4824d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142686
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-17  Mike Kaganski  <mike.kaganski@collabora.com>  [b062c2f3e61fc0b449c07c5ca2f1f6a956dfc41f]

        Take in-place widget scaling into account
        
        This is relevant when the Math OLE object is scaled in parent document
        (e.g., using Position and Size dialog, disabling its size protection);
        then the in-place editing widget uses own map mode reverting the OLE
        scaling; without taking that into account, mouse clicks get misplaced.
        
        Change-Id: I961fa8f3993c1b7992857c9f18d79650d078a684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142822
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ead38cad91f2d790369d959cc66cb8fc687588e]

        ScBootstrapFixture: drop newly unused code
        
        Change-Id: I0a0c825d552fe20b16102fb2382e9bee598e879d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142792
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [63db958d674375876951fdddc7958e9866bdba8f]

        sc: xpath is unused now
        
        Change-Id: I7ae93b5d64991f0fcbd656ddb6f2413bf425cfd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142782
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Stephan Bergmann  <sbergman@redhat.com>  [0e4c7a8061a4a35d09a1d64e136a0203f12da1a2]

        external/boost: Replace constexpr.patch.0 with alternative upstream fix
        
        Change-Id: I168c3bfbf5a194f7f5565ba2dc6086f3b4053d12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142828
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [f1ead6a3c032e2d395ea100906c3dc5ae8834460]

        sc: remove blank document, just create it on the fly
        
        Change-Id: I6b4dc26da120f95cfae4582d23f68554801334aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142825
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [552e3ea44f857d7ce9326fac08a390c1190ba3bc]

        CppunitTest_sc_subsequent_export_test2: inherit from UnoApiXmlTest
        
        Note: testTdf143979 and testWholeRowBold crash sometimes.
        It seems the problem is when using GetPool and save.
        Reducing the scope seems to fix it
        
        Change-Id: Icc0f75bdb2ea493b7989a4521add63657528475a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142791
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-17  Aron Budea  <aron.budea@collabora.com>  [ed50187de545d44c55351736f62c5bdf06f2b3de]

        DeepL: add Spanish to list of languages for translation
        
        Change-Id: I7c7505fb1afee750c1742a64f4b8f345a6140c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142823
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 0c2e24594ed202f9c3dd2b3ee6646410b4eb2326)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142797
        Tested-by: Jenkins

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [783bc24136929f1dc7b3d49b01794df627cc0bdb]

        ofz#53434 Out-of-memory
        
        Change-Id: Ia148869905cb54f57136fe0e0c2572434a7d37cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [b7badb551990addaa10960a3557c8f83732a560e]

        use harfbuzz upstream fix instead of workaround
        
        drop temp workaround for problem seen with tdf119074-1.odt
        
        i.e. apply https://github.com/harfbuzz/harfbuzz/pull/3874
        for https://github.com/harfbuzz/harfbuzz/issues/3824
        
        Change-Id: I42373f2282d30d7e45ee88b654d3df40f3a6384b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142815
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Caolán McNamara  <caolanm@redhat.com>  [c2fc5d4fc042460eaac1d6407f45d2f0073bf6a7]

        ofz#53450 Integer-overflow
        
        Change-Id: I106e703714083631c67d7b8a84180c3c485953d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142814
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e96dd14288172187372b3a4f82de870b1d660020]

        sw: improve a11y check statusbar
        
        Change-Id: I86f589d6618ae80f26542cf83b6b5e3695ca35f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142193
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1dfb746b8ca5d5d4ef21feb67d3921ab342d782f]

        sw: Change online a11y checker again from SwContentNode to SwNode
        
        This is needed because SwTableNode is not a content node, so we
        need to work with the most generic SwNode and ask if the node
        derives from sw::BroadcastingModify, which is required for node
        tracking (SwTableNode and SwContentNode support that).
        
        Change-Id: Idc28a5a9f1f8a250e2a28bb955ed320d02b6c1b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141787
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [acc083480abf506c9ff620ddbc722da467db9e3e]

        split the paint method a little more
        
        it has to be smaller to fit into my mental working-RAM
        
        Change-Id: If2225359591a070373e3a9ca0459e5c64bef7526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142776
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1ecbe9335161accdea440d6b6e72c85cb032341]

        flatten the ImplPaint* methods a little
        
        Change-Id: Ibcb4268697a6dd95da841dc29f7012c0801abdd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [4359008cca47bf61e3bf0bbbcf7b766cbde99ad0]

        split the paintGraphicUsingPrimitivesHelper method
        
        to make it easier to comprehend
        
        Change-Id: Ib1c8a36eea036584220636f330c4df76afcd27e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142774
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-17  Miklos Vajna  <vmiklos@collabora.com>  [251ba77f9aac0f1eacb0e1f02d34e9302024f1a9]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I3c5d53dc33112f7d8c46cf2baf35ba03ff7fa3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142790
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-17  Daniel Lohmann  <LibreOfficeContribution@dldld.de>  [a15bcda0e21be04bec424172192f2416b7f52422]

        tdf#33495: Allow presenter console in windowed mode
        
        Added an option in the Impress settings window to set the presenter
        console into fullscreen/windowed mode. This will then be used the
        next time a presentation is started.
        
        Two pictures of how the result looks are given in the bug tracker.
        
        Change-Id: I231f9180301301a9eccf9984ea4dcd529bd7dfce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142359
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ef0858071faf93ce48237ea3948f50e288eb702b]

        sw: initial a11y check - first run when the document is opened
        
        When the document is opened we first need to run the a11y check
        on the whole document so we can report the a11y state in the
        statusbar and set the a11y issues to the nodes.
        
        Change-Id: I0573e8fd695e3b0560fa0554f4702c88e7980a13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141786
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ca03ea5c1ce7f1fa0702c004068a2592a723e669]

        sw: track content node with a11y issues, so the number is correct
        
        Track all content node with a11y issues and handle when they are
        deleted (with WeakContentNodeContainer). At update, recount the
        number of a11y issues that are contained in the content nodes and
        update the overall number.
        
        Change-Id: I254c62aba0d73a365f011b1609bcddec4dd71615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141785
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-16  Mike Kaganski  <mike.kaganski@collabora.com>  [a81e957f5026373f3935390c786c21416fc74fcc]

        lok: handle mouse/keyboard events in Math embedded in Calc
        
        And extract the identical code used in all components into
        static SfxLokHelper methods.
        
        Change-Id: I6556b1b996936835ecfc0d59e2c1dd1ef6380db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142793
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-16  Caolán McNamara  <caolanm@redhat.com>  [7060192b6facd92cadb5bb084052903f2695d67d]

        tdf#149322 apparent distortion of glyphs on scrolling
        
        sometimes there's a 1 pixel difference here vs to the amount seen in
        Window::Scroll. The little misplaced tails of glyphs are actually in the
        right place, and it is the large rectangle of copied text above those
        that is in the wrong place.
        
        Subtract these origins while in logic space, before turning that
        result back to pixels to get consistent results for equal distances.
        
        Change-Id: I37e77f38b95456cee32ff44cde2893986d52cde3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142789
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [b61ca6f7bf4e5b5b1980ad03f2a5f2d01e8c22fe]

        CppunitTest_sc_uicalc: inherit from ScModelTestBase
        
        so createScDoc handles the dispose of new documents
        saveAndClose can go now
        
        Change-Id: I7f88ef6ff9aaece72461489a31b0ef456ce5e170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142781
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Stephan Bergmann  <sbergman@redhat.com>  [e515267602d9049bc15739a215f43f1379141d81]

        external/freetype: Avoid duplicate zlib symbols
        
        After 7229a380d3d607dc896e1d48b1a13f7b301aef80 "Update freetype to 2.12.0", my
        --without-system-freetype --without-system-zlib Linux build started to fail to
        link Library_skia with
        
        > ld.lld: error: duplicate symbol: zlibVersion
        > >>> defined at zutil.c:28 (workdir/UnpackedTarball/zlib/zutil.c:28)
        > >>>            zutil.o:(zlibVersion) in archive core/workdir/LinkTarget/StaticLibrary/libzlib.a
        > >>> defined at zutil.c:28 (src/gzip/zutil.c:28)
        > >>>            ftgzip.o:(.text+0x0) in archive workdir/UnpackedTarball/freetype/instdir/lib/libfreetype.a
        
        etc. because both those non-system libraries are provided as static archives.
        
        There is also provisioning for symbol renaming in
        workdir/UnpackedTarball/freetype/src/gzip/ftzconf.h via -DZ_PREFIX, so enable
        that.  But three symbols were missing and would still produce linker failures,
        so add them with external/freetype/zlib-duplicates.patch.
        
        Change-Id: Ibe876d4e38e3e44ce00c64fb70c88fb0b1e3a910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c81d66e96c2410c6a2c2955ead3b7d3d441e092a]

        Fix typo
        
        Change-Id: I64295144d0fb0bd1b07d06dd7a51a670deb0a7df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142732
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cb2133e765ebd44fb005b9d1497de65ac28f1f1a]

        update credits
        
        Change-Id: I5fb81432975d0a0c83cfbed6f4335ca54d574c37

2022-11-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2d4cde2f75d4aaa3a69fdd65ee7584eb15d20275]

        lok: handle mouse/keyboard events in Math embedded in Impress/Draw
        
        Since Impress/Draw use mm100, we need to convert object area that
        SfxInPlaceClient provides, which is in parent units, into twips.
        TODO: how would taking the units from object shell with Calc, given
        that it does not call SetMapUnit in ScDocShell ctor?
        
        Change-Id: I8de2088a3e0e7f9070d6c3c234b40038b6e00f15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142777
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [6eb9529abef9d7588899f9b241f31baa0b2beee2]

        sc: move filter tests where they belong. (part 2)
        
        Change-Id: I548d81dd7a7aa276d6936ab8d7bcc53a6cc91483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142772
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6ed1e058975f94aa0b79428f4d735095a68c74a]

        sc: move filter tests where they belong. (part 1)
        
        it reduces duplicated code
        
        Change-Id: Iba4898e414b87c962b3e923c8c0cf8ca12434167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142765
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [7c43a3ad40d394ac60d269c12c3d84f588442c83]

        tdf#151820 Fix arrow in AutoFilter menu when using dark mode
        
        If you're using a dark theme and create an AutoFilter, the arrows in the AutoFilter menu such as "Filter by Color" and "Filter by Condition" will appear in black over a dark background.
        
        This patch ensures the arrows use LabelTextColor instead.
        
        Change-Id: Ia41757b801354bbc14f66c293a17f3935734788d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141921
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4b778a626843d50ea85065dbcc2ed80bef9a977e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 7050fcc7a3b1e899f3d93b6550d96f982809c9b0
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: If9f7c2893435b30626bc7fbd2ea1f0d50345a598
            
2022-11-16  Bogdan B  <buzea.bogdan@libreoffice.org>  [d32bb77e5b36a2186febc69751209196ccad93a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 98d79c65383a3cf1b9966a46896b36d404235c08
          - tdf#152022 Replace "Links to External Files" to "External Links" (Help)
            
            Change-Id: I6a83b183b849e1159e0266cbe4039ed20d413f19
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142685
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [2bf461c88da82b82377afd8effb0aa9c40a03cbf]

        sc: move export tests where they belong
        
        Change-Id: I76d56a3e565ad448ca8690bbcb2966ec4e3fbd7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142764
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [0667b629559031cfe0b415d56b160d238514c9af]

        CppunitTest_sc_dataprovider: inherit from UnoApiXmlTest
        
        Change-Id: I713af988ad97652492178ae73703c24bc078b86b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142763
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Miklos Vajna  <vmiklos@collabora.com>  [7229a380d3d607dc896e1d48b1a13f7b301aef80]

        Update freetype to 2.12.0
        
        - fixes CVE-2022-27404
        - dropped the no longer applying parts of ubsan.patch
        
        Change-Id: Ia8a496d53b62f68a27dbd9be08c89273b6bd01cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142768
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-16  Caolán McNamara  <caolanm@redhat.com>  [9d997a6f03677b00ae7402fa7f5314db450a3a7e]

        ImplDbgTestSolarMutex assert from a11y
        
         #5  0x00007fffee606a72 in ImplDbgTestSolarMutex() () at vcl/source/app/dbggui.cxx:35
         #6  0x00007ffff71186f0 in DbgTestSolarMutex() () at tools/source/debug/debug.cxx:54
         #7  0x00007ffff3273e39 in SfxBroadcaster::RemoveListener(SfxListener&) (this=0x1a38230, rListener=...) at svl/source/notify/SfxBroadcaster.cxx:105
         #8  0x00007ffff3296eb8 in SfxListener::~SfxListener() (this=0x33abce0) at svl/source/notify/lstner.cxx:53
         #9  0x00007fffaaa0a0a4 in ScAccessibleContextBase::~ScAccessibleContextBase() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleContextBase.cxx:59
         #10 0x00007fffaaaa6379 in ScAccessibleTableBase::~ScAccessibleTableBase() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleTableBase.cxx:52
         #11 0x00007fffaaa831da in ScAccessibleSpreadsheet::~ScAccessibleSpreadsheet() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx:274
         #12 0x00007fffaaa83229 in ScAccessibleSpreadsheet::~ScAccessibleSpreadsheet() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx:270
         #13 0x00007ffff5f87fc0 in cppu::OWeakObject::release() (this=0x33abc40) at cppuhelper/source/weak.cxx:230
         #14 0x00007ffff5f88690 in cppu::OWeakAggObject::release() (this=0x33abc40) at cppuhelper/source/weak.cxx:296
         #15 0x00007ffff5e7e4d5 in cppu::WeakAggComponentImplHelperBase::release() (this=0x33abc40) at cppuhelper/source/implbase.cxx:211
         #16 0x00007fffaaa0d875 in cppu::WeakAggComponentImplHelper5<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::lang::XServiceInfo>::release() (this=0x33abc40)
             at include/cppuhelper/compbase5.hxx:142
         #17 0x00007fffaaa0ab15 in ScAccessibleContextBase::release() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleContextBase.cxx:119
         #18 0x00007fffaaaa6b75 in ScAccessibleTableBase::release() (this=0x33abc40) at sc/source/ui/Accessibility/AccessibleTableBase.cxx:86
         #19 0x00007fffd8f4f11a in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::clear()
             (this=<error reading variable: Unhandled DWARF expression opcode 0x0>) at include/com/sun/star/uno/Reference.hxx:231
         #20 0x00007fffd8f4c41d in atk_object_wrapper_finalize(_GObject*) (obj=0x7f71930) at vcl/unx/gtk3/a11y/atkwrapper.cxx:662
         #21 0x00007ffff3538d32 in g_object_unref (_object=<optimized out>) at ../gobject/gobject.c:3678
         #22 g_object_unref (_object=0x7f71930) at ../gobject/gobject.c:3553
         #23 0x00007fffd9571fc5 in expiry_func () at /lib64/libatk-bridge-2.0.so.0
         #24 0x00007fffea7197b1 in g_timeout_dispatch (source=0x313d360, callback=0x7fffd9571f60 <expiry_func>, user_data=0x7fffbc01bec0) at ../glib/gmain.c:4971
         #25 0x00007fffea718faf in g_main_dispatch (context=0x5f8230) at ../glib/gmain.c:3417
        
        Change-Id: If527f1cf1bfc59bb8df586afaf5da62bbcb08eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-16  Miklos Vajna  <vmiklos@collabora.com>  [1c2ef850db29beb369dcc89a58fc73416ecd9c5c]

        sw, .uno:TextFormField command: accept HTML in the FieldResult parameter
        
        - improve the calculation of the SwPaM that decides the start/end of the
          fieldmark: with HTML import the length of the content is not the
          length of the input string anymore
        
        - use SwTranslateHelper::PasteHTMLToPaM() to accept formatted content
          inside a single paragraph
        
        - avoid unwanted last empty paragraph from the HTML import
        
        - this builds on top of commit 6870c0c3385bf5d19e9c80bf973fca255ae38c08
          (sw: add new FieldCode parameter for the .uno:TextFormField command,
          2022-11-15), which introduced plain text support for FieldResult
        
        Change-Id: I8332f6ee532ab1e844a4b94f22b1f72d2406eb3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142756
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-16  Bogdan B  <buzea.bogdan@libreoffice.org>  [d3cd7295c9a0ac50ce0315061bcc00cdafb69456]

        tdf#150703 Replace Axes with Axis
        
        Change-Id: I6c040ca00ccf08bcef664c6de3f5294838b22f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142523
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-16  Bogdan B  <buzea.bogdan@libreoffice.org>  [458dac8b76cafe8559b80bf9b36a2ac012b9c52f]

        tdf#149305 Add indent button in text toolbar and change buttons order
        
        Add indent button in text formatting toolbar in Draw and Impress (like in Writer). Move 'bullets buttons' in the same position in toolbar like in Writer.
        
        Change-Id: Ic27d8d499abdf1070bc0bff627d9d2023e005c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142530
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [2af48226d7224b83fb77fe81a8d7d58886395b88]

        CppunitTest_sc_chart2dataprovider: inherit from UnoApiXmlTest
        
        Change-Id: I65e833ca307dec186c4a455fdb068b4242873cba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142762
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea9c2c4edbc38bd4bde20a88f81ed8b258208407]

        CppunitTest_sc_shapetest: inherit from ScModelTestBase
        
        which inherits from UnoApiXmlTest.
        In order to get rid of duplicated code
        
        Change-Id: I36b1edf21fd58eecce482331f5cca577ac7f7b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142758
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [59b62978c738b1d44c18278709cc1c26d4249d3e]

        CppunitTest_sc_bugfix_test: inherit from UnoApiXmlTest
        
        Note: testTdf31231 and testTdf141914 had to be adapted a bit.
        the documents are modified after a hard recalc. Reported in
        tdf#152065
        
        Change-Id: Ib9093d766b17de78f8a547c285a0e0082eb01171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142757
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-16  Hossein  <hossein@libreoffice.org>  [31d510389928c8f8a495a85cdab4c12d1bbbd3ce]

        tdf#152061 Fix bitmap image scaling
        
        In the regression introduced by c2c37eadf32c80bcd8f168b9fc67f32002b3cb07
        the bitmap image scale was calculated incorrectly. Upon resizing the
        image a bit, this problem went away, and the image was shown with much
        better quality compared to what it was before the above commit. It
        turned out that the problem happened when the scale was less than 1, and
        it was happening inside "if ( nScaleX < 1.0 || nScaleY < 1.0 ) {...}".
        
        The part that was calculating aPosAry.mnSrcWidth and aPosAry.mnSrcHeight
        was wrong, because it was setting the same height and width without
        considering the fScale. The bitmap was scaled using Bitmap::Scale()
        parameter which was newly multipled by fScale in the above commit. To
        fix the problem, these two values are now multipled by fScale.
        
        Change-Id: I8c77d2db3b05da54f1999d3915a70e3b7cc8106f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142754
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-16  Justin Luth  <justin.luth@collabora.com>  [383eaa656cf19f40f5b98533afb020c27ae09bc9]

        tdf#151548: cleanup "Add basic word::XFormField support" etc.
        
        Thanks to those who reviewed the first patch in my series.
        I thought I had done so well, and yet...
        
        -typo: 3df534a5ba01ec32590adb6c05ee6621e136b55e
        -unused/std::move: 0232d4d19858f76fd63b8e525a835bd6fbcd3b8a
        -const&: d9c708f78de6f6ef6621b47123a0ff164ddfee93
        
        Kendy pointed out there are different license headers,
        and new code should just use MPL. I had just copy/pasted
        the header from nearby code. All the work done in these
        new files was mine (composed by copy/paste as a template). Fixed.
        
        I noticed a few stray css:: in .cxx files that I missed.
        Those are unnecessary and I don't like them. Fixed
        
        In the second round of reviews
        -no need to specify virtual when override
            -cleaning up ALL of them in bookmark.hxx to be internally
             consistent - nothing worse than half and half in one file.
        -use #pragma once for new files
        -only use official documentation (but I don't like the layout
         of the official documentation and didn't use it,
         so the value of providing a web link seems dubious - removed.
        
        Change-Id: I3c7aa7d647bfa91b69848258aca6d79d8e7b0edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142556
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-16  Stephan Bergmann  <sbergman@redhat.com>  [d0a8c957be6dbc91cc05939468ce99947656481c]

        configure: Allow to override CXXFLAGS_CXX11
        
        (My Clang --with-latest-c++ build against GCC 13 trunk libstdc++ needs to use
        -std=c++20 instead of -std=c++2b to work around
        <https://discourse.llvm.org/t/pack-expansion-bug/64910> for now.)
        
        Change-Id: Ib66375fe6e5c3b6b1a24b32fcce051d78390f962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142752
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-16  Miklos Vajna  <vmiklos@collabora.com>  [cd8e8685454c92c38f17ddcf8b4f49b9068635ec]

        sw content controls, date: improve PDF export test
        
        Assert not only that the widget is a text one, but also that it has the
        correct date format.
        
        Change-Id: If2bb8dcdfca0a8b76b5ed179ff558d351137bc06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142747
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-16  Noel Grandin  <noelgrandin@gmail.com>  [8011b16e05c97a92efee2debb23f5eae60f1236b]

        Use BitmapEx in BitmapPrimitive2D
        
        we no longer need to wrap it in the framework XBitmap
        implemenation
        
        Change-Id: I0dc56ad63364e2c5a4cedd5e70d4ae7ea7eae563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b0a6621858b141022743dd8d500558895dedb1f]

        bugfix-test.cxx: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: I55971610f075c635e992cd308fac14eec2a558aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142750
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [16433bb162e060256f3ac47dd09630590f9e4ce0]

        CppunitTest_sc_subsequent_filters_test: inherit from UnoApiXmlTest
        
        Change-Id: I8968035d5113ab3f259be43a4a73105d22755f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142745
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [d873aa4ddf617fb7c3440763efa71c97389ce738]

        subsequent_filters_test.cxx: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: I03b1749b8c50aaf073cec9e8b25891bd9414b546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142749
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e1890ca6f66ccf675092f2841a1b99da0d85ec2]

        CppunitTest_sc_pivottable_filters_test: inherit from UnoApiXmlTest
        
        This fixes the TODO in testPivotCacheExportXLSX
        
        Change-Id: I904fd97754a7facd9c8896154965ff7d16cada9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142743
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Michael Stahl  <michael.stahl@allotropia.de>  [dfffe710d07f84f4152cf61ccd4a69279a26ff7c]

        tdf#149140 vcl,sw: PDF/UA export: add Scope attribute to table headers
        
        Change-Id: If2402c824e637016e3c10860810501ec60732bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142000
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-11-15  Caolán McNamara  <caolanm@redhat.com>  [701e8d06484fb8781e43017ccf4ac1a3d64ac9e8]

        Resolves: tdf#147802 don't create a header/footer control for every page
        
        just create a cheaper SwHeaderFooterDashedLine and only create the
        "expensive" control on-demand if it becomes visible on-screen and
        destroy it immediately if it goes off-screen.
        
        Change-Id: Id876145130d394f55f54790d5e8399dca4f8c03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142742
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Mert Tumer  <mert.tumer@collabora.com>  [2550835bde036a2809d693d9633b8b736c035ecb]

        android: Fix tab name on CSV still becomes tempfile name
        
        Unfortunately, in order for isLOKMObilePhone to work we need
        to send deviceFormFactor on document load but at this stage
        the document is still not loaded and the control does not work here
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I5388cf4a049dbf007a1fd79abefb64bed580eea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131900
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142607
        Tested-by: Jenkins

2022-11-15  Eike Rathke  <erack@redhat.com>  [8309f94001ec29faff288cb8f920ee00978bb85a]

        Resolves: tdf#152053 GetOptimalColWidth() obtain number format from next row
        
        ... if 1st or 2nd row doesn't have one applied, i.e. is header.
        
        Change-Id: I4b33fa4abcbe74b02d416cfa494c0813a8f0086e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142744
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-15  Julien Nabet  <serval2412@yahoo.fr>  [bf9ce4e056b521db8e8c997a56317ab15963dce9]

        asan: fix leak in lcl_MergeLevel
        
        Direct leak of 2000 byte(s) in 2 object(s) allocated from:
        0 0x55906afe399e in malloc (/home/julien/lo/libo_perf/workdir/LinkTarget/Executable/treex+0xff99e) (BuildId: 5b19224d0ca2120a)
        1 0x7fd51a4abfd7 in xmlEncodeSpecialChars (/lib/x86_64-linux-gnu/libxml2.so.2+0x31fd7) (BuildId: 008b52a46ddf3013589362f7f678f7a6c8dd1e56)
        2 0x55906b023403 in (anonymous namespace)::lcl_MergeLevel(_xmlDoc*, _xmlNode*, unsigned char const*, MergeDataFile*, rtl::OString const&, rtl::OString const&) treemerge.cxx
        3 0x55906b0232d4 in (anonymous namespace)::lcl_MergeLevel(_xmlDoc*, _xmlNode*, unsigned char const*, MergeDataFile*, rtl::OString const&, rtl::OString const&) treemerge.cxx
        4 0x55906b0232d4 in (anonymous namespace)::lcl_MergeLevel(_xmlDoc*, _xmlNode*, unsigned char const*, MergeDataFile*, rtl::OString const&, rtl::OString const&) treemerge.cxx
        5 0x55906b0226ef in TreeParser::Merge(rtl::OString const&, rtl::OString const&, rtl::OString const&) treemerge.cxx
        6 0x55906b02c0dd in sal_main_with_args(int, char**) treex.cxx
        7 0x55906b02baad in main (/home/julien/lo/libo_perf/workdir/LinkTarget/Executable/treex+0x147aad) (BuildId: 5b19224d0ca2120a)
        8 0x7fd519e46189 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
        
        Change-Id: I9882cd63b91967d9b8998ba25545c11a3168e739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142717
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [ad40ad91c5400391a0848832e91c596be8fbd811]

        CppunitTest_sc_subsequent_filters_test2: inherit from UnoApiXmlTest
        
        I couldn't find a way to test testTooManyColsRows,
        move it to sc/qa/unit/filters-test.cxx for the
        time being
        
        Change-Id: Ie841dea8aeebcbeff8c9a75ddb91d134c2b52c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142741
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Bogdan B  <buzea.bogdan@libreoffice.org>  [eedb077f8860e02838b37d75c230e51cd290a283]

        tdf#132293 remove unused imports from uitest
        
        Change-Id: I5943ec84a0b5ed6f44af9e3f972626813987a1cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142615
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3aadb8a87449c9a3141bef1e41353ec57b03ad79]

        Prepare createAlphaMask to produce mask and alpha as needed
        
        Change-Id: Ica799419ed628f94f134433ca5b37518c5698909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142730
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [37983b994472a11663b1c3d17181dde22ac3ec85]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a443db63229d6e46eacae7c14d7c668ca2f54ea3
          - Fix contents after translation review
            
            Thanks to @lyzbet
            
            Change-Id: I8fc33fbe954e1467dac010cb6b7a253d92513568
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142682
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-15  Caolán McNamara  <caolanm@redhat.com>  [09df29aed07223fa2cdb0913b6e8ddf4da347706]

        Resolves: tdf#152043 line wrap the label
        
        Change-Id: I5e267a6e00b2f20aa3a74aa5288c8e183fd74e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Caolán McNamara  <caolanm@redhat.com>  [5214e06f76842fea5e73a4618137adc11c9c5ce3]

        sync with dbwizconnection page wrt the expansion of 'browseurl'
        
        Change-Id: I1134464f541a1d7f131ecf0d359fbfd7725735fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [3dc257119dc235f3d74a6a6e95daf63317e4af95]

        CppunitTest_sc_subsequent_export_test: remove unneeded saveAndReload
        
        follow-up by a save
        
        Change-Id: Ic6297213b25f8726038687ec690a3bfabaf09a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142736
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7f6a8395bda1cfb29faef8cfddbdf3c8775da450]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d2259c8401ccc4d9ead41f6aff4903601e5e8564
          - silence make translations warning (emtpy string flagged for translation)
            
            Change-Id: Ie8d188eca6b04a1e264ebe4f1abfeaa79bcba37d
            
2022-11-15  Caolán McNamara  <caolanm@redhat.com>  [8fd86685dc48a4f381886785256dcb1fcce18fc4]

        resave with latest glade
        
        Change-Id: I9eea94ab0962666baa6225017c30940ff26a4c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Caolán McNamara  <caolanm@redhat.com>  [8359e28ff1ef3c2bf2c0e6da0813343022d54516]

        ofz#53416 Abrt
        
        Change-Id: I5adb6a1a3987b74212b8606aef3826e7d2f77aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142727
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a865d042eff3cdd4d78badcc55c9d8fdf9ef52aa]

        CppunitTest_sc_subsequent_export_test: inherit from UnoApiXmlTest
        
        Some notes:
        * testLinkedGraphicRT needed to be adapted. Saving to
        Calc Office Open XML doesn't keep IsLinkedGraphic.
        Reported in tdf#152036. No idea why it didn't fail before
        
        * Some tests used "generic_HTML" as export filter format, which
        is wrong. Instead, "HTML (StarCalc)" should have been used.
        But then, the test would have failed with
        - unsatisfied query for interface of type com.sun.star.sheet.XSpreadsheetDocument!
        So trying to export to html in those tests is not expected.
        No idea why it didn't fail before
        
        * testTdf90299 fails now with
        - Expected: 'file:///tmp/lu23738863wthph.tmp/dummy.xls'#$Sheet1.A1
        - Actual  : 'file:///tmp/lu23738863wthph.tmp/lu23738863wthpg.tmp/dummy.xls'#$Sheet1.A1
        I added a TODO to check it later
        
        * testNamedRangeBugfdo62729 fails on mac with an infinite loop
        
        Change-Id: I63168583a47f510d1ac22971a274e28d085de61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142576
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-15  Miklos Vajna  <vmiklos@collabora.com>  [6870c0c3385bf5d19e9c80bf973fca255ae38c08]

        sw: add new FieldCode parameter for the .uno:TextFormField command
        
        The field code/command is the input of the field expand.
        
        Also allow setting a field result, given that the entire point of
        "unhandled" fieldmarks is that Writer itself doesn't know how to compute
        the field result / expanded string.
        
        Note that a field result can be a multi-paragraph and formatted content,
        so far we only allow single-paragraph plain text.
        
        Change-Id: I1739cb985d1d4ed8e45068f15a4e0d82fd118d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142726
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-15  Rene Engelhard  <rene@debian.org>  [1caf3f2554ffac3624d43defb4252a5b40945bbc]

        actually don't compile tools/source/misc/fix16.cxx with system-libfixmath
        
        90babff28406d5366df153e2d3c6d4206f06d614 missed the config_host.mk.in
        part
        
        Change-Id: Ic18964f02fc80b0f9b3de6518e069038f03932af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-15  Justin Luth  <justin.luth@collabora.com>  [b8fa94b28a2fbf75edc0d31fbf776d40a227e794]

        tdf#151548 vba FormFields: Add basic word::XDropDown support
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        This now allows MS Word Basic legacy list box form fields
        to be controlled by VBA basic.
        -allows getting and setting the text string/list entry
        -allows adding and deleting list entries
        
        Change-Id: Ia772c62395c40a6aa0afae2549f15f4ea3304dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142396
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-15  Mike Kaganski  <mike.kaganski@collabora.com>  [55c2e9e7e24a4bc2016fc54a5ffaf22aa094eb58]

        Allow using bin/list-dispatch-commands.py with separate builddir
        
        Change-Id: Ide1c43c603b4a82534cc116133852f5f05858a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142723
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-15  Mike Kaganski  <mike.kaganski@collabora.com>  [32aa6697c0b9f0ef490f42165a6b777c2b800da4]

        gtktiledviewer: Don't call updateClientZoom until zoom is initialized
        
        Avoids some console noise
        
        Change-Id: I521e430eeabe8fcf5012834dc7be7af8c0ce418b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142724
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-15  Miklos Vajna  <vmiklos@collabora.com>  [94df17d2fcdb72bc529097d77b174d934a25cc24]

        tdf#145416 canvas: fix rotated, not zero-sized bitmap, which is not rendered
        
        The presentation had a rotated bitmap, which is not zero size, but we
        still decided to just not render it. The bug is specific to the "cairo
        canvas", which is the default on Linux, but not elsewhere.
        
        The trouble is that CanvasHelper::implDrawBitmapSurface() accessed the
        transform matrix directly, assuming that the (0,0) and (1,1) members
        represent scaling as-is. This is only true in case there are no other
        transforms in the matrix (rotation, sharing).
        
        Fix the problem by getting the scale info via
        cairo_matrix_transform_distance(), which correctly determines if the
        scaling is 0 or not.
        
        This went wrong in commit 78036f74fa74ee2552e79064660634e1342692ff
        (tdf#135094 cairo canvas: fix black slide containing a very small image,
        2020-08-14).  No testcase, our tests are typically headless and
        currently SvpSalGraphics::SupportsCairo() reports false, so this would
        be tricky to test.
        
        Change-Id: I0af18e89a3fbc76805053ba2f2f8ce509716f678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142722
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-15  Jim Raykowski  <raykowj@gmail.com>  [8a2f32a74794c6ee736c5015c920651c9eb6fead]

        Replace do while with all_foreach
        
        Change-Id: Ibe2d34a02628476ab2e2e1ad0b7c9236429e7e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142641
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-15  Miklos Vajna  <vmiklos@collabora.com>  [086f715f9db0acd02941423bfc523e6c58aa818a]

        sw: document SwShellCursor
        
        I.e. SwShellCursor is a cursor, while SwCursorShell is a base class of
        the edit shell/UI.
        
        Change-Id: I28e10360b2ef67ad599ec696a57f7bb30eabd33c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142719
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fad326833699293e5f4e3254881cb56889a220c0]

        sw: Run a11y check for all content nodes
        
        Change-Id: Icc3ff1be31a01b22242c48dec6d830e645ecb310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141784
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-15  rash419  <rashesh.padia@collabora.com>  [057eca05f23d9d15465e591bd0da671735d62d50]

        sc: convert optimal width/height and normal width/height dialog to async
        
        Signed-off-by: rash419 <rashesh.padia@collabora.com>
        Change-Id: I96f6d90692d7767bdc276f753897bdc392c90411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132919
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133127
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142633
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-11-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e340b81d9d75d3aacfa941df4b531c6a9f5aaffa]

        sw: add accessibility check statusbar control
        
        A11y check statusbar control, which reports the current status of
        the online a11y check.
        
        Change-Id: I07528f39ed84136f99bc1ce07c10aa6163649305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141605
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0b96a1747fc3f96ca70fd159594fe1a478369da0]

        sw: add online accessibility check implementation
        
        Change-Id: Ic68aa91b1cbf23ac305ad4e361c56b91556757ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141604
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d750720b667a178b273db4e1f280a756583d74f]

        CppunitTest_sd_svg_export_tests: remove duplicated code
        
        This class is already in macros_test.hxx
        
        Change-Id: I1c5705fd6feceabe3cc29527af10c7f4e9e1f39f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142720
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [022eafa4d69bc8290aa304b69af2c325fe3d2a02]

        Fix typo
        
        Change-Id: Ib625049e93949b247ca20a83dcca16fecda29216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142703
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb943222e6592402c4ca35bbf50094c7491330c9]

        bump required cairo version to 1.12.0
        
        Change-Id: I7fbfb21f2facdd6371fba821fd30e625115dc72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142710
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ad1411746a581357920a1ad6366935700719010]

        use cairo_surface_map_to_image if available
        
        which is considerably faster than emulating it
        
        Change-Id: I9159072caf3142684f8489d291fa0438dce2e4b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [17476f1c9912b5ce31276a947d6a34ec8b9a3ed2]

        cairo_fill is cheaper than cairo_paint
        
        when we are only interested in copying a small chunk of the image.
        Shaves 25% off the cost of rendering here
        
        Change-Id: I3df726a08fad3ab3c330da74d09ee5e735e1bc60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-14  Mike Kaganski  <mike.kaganski@collabora.com>  [dbc307ef7c2351cd72e60ef46e647c908379db86]

        gtktiledviewer: Fix getting tiles on Windows
        
        The "CanvasSize + 1" hack was implemented by myself in commit
        ebb3a72ba0c4f070c9c254c439147beea8b2d93d (Paint tiles on Windows;
        Oct 24 09:01:32 2022 +0200) to workaround a rounding error, where
        converting pixels to logic and back resulted in 1 pixel smaller
        size (when I worked in Writer). This hack breaks in Calc, because
        the size then is 1 pixel larger than expected, failing the assert
        below.
        
        This fixes the problem by disabling the map mode, as everywhere
        else in such cases.
        
        Change-Id: I37f0f03ae4cb19f2de0e7995064843d17b0c7189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142714
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9c33b6772022333ca6651a400064154f8705788d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 3322d894ee938182ff6d5dec818deadd4fbf9010
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I7b8d6fb47b4c093ef48a731d629ed5c0d0ac29eb
            
2022-11-14  Justin Luth  <justin.luth@collabora.com>  [0ded9060376a2bec9ad9e252882bf5b3e0efc466]

        ww8import: 0 is a valid ODF_FORMDROPDOWN_RESULT
        
        The correct response when there are no choices
        is to erase ODF_FORMDROPDOWN_RESULT.
        0 points to the first entry in the list,
        so it is invalid to suggest that such an
        entry exists when it doesn't.
        
        Change-Id: I4cb20428c7448a24ae8801e15407d478286a96e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142409
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2022-11-14  Stephan Bergmann  <sbergman@redhat.com>  [04a8f3a42c0cefa67aeff00c6dea256f5be67449]

        Destruction of Registry and RegitsryKey isn't MT-safe
        
        ...as the underlying ORegistry and ORegKey modify their ref counts outside any
        locked mutexes.  For example, <https://ci.libreoffice.org/job/lo_ubsan/2572/>
        had failed during CustomTarget_odk/build-examples_java with
        
        > ==402==ERROR: AddressSanitizer: heap-use-after-free on address 0x60d00035d920 at pc 0x7f379ce963d9 bp 0x7ffe74b1ac60 sp 0x7ffe74b1ac58
        > READ of size 4 at 0x60d00035d920 thread T0
        >     #0 0x7f379ce963d8 in ORegistry::acquire() /registry/source/regimpl.hxx:49:18
        >     #1 0x7f379ce947a3 in acquire(void*) /registry/source/registry.cxx:38:15
        >     #2 0x7f375ee9287e in Registry::operator=(Registry const&) /include/registry/registry.hxx:961:9
        >     #3 0x7f375ee92654 in RegistryKey::setRegistry(Registry const&) /include/registry/registry.hxx:647:20
        >     #4 0x7f375ee91d66 in Registry::openRootKey(RegistryKey&) /include/registry/registry.hxx:979:18
        >     #5 0x7f375ee725da in (anonymous namespace)::SimpleRegistry::getRootKey() /stoc/source/simpleregistry/simpleregistry.cxx:889:30
        >     #6 0x7f375ee73a56 in non-virtual thunk to (anonymous namespace)::SimpleRegistry::getRootKey() /stoc/source/simpleregistry/simpleregistry.cxx
        >     #7 0x7f37828e142c in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
        >     #8 0x7f37828db812 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
        >     #9 0x7f37828d8668 in unoInterfaceProxyDispatch /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
        >     #10 0x7f375cfebc05 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const /binaryurp/source/incomingrequest.cxx:236:13
        >     #11 0x7f375cfe5a46 in binaryurp::IncomingRequest::execute() const /binaryurp/source/incomingrequest.cxx:79:26
        >     #12 0x7f375d0ae662 in request /binaryurp/source/reader.cxx:86:9
        >     #13 0x7f37b5cf5a2b in cppu_threadpool::JobQueue::enter(void const*, bool) /cppu/source/threadpool/jobqueue.cxx:100:17
        >     #14 0x7f37b5d44637 in cppu_threadpool::ThreadPool::enter(rtl::ByteSequence const&, void const*) /cppu/source/threadpool/threadpool.cxx:304:33
        >     #15 0x7f37b5d468d4 in uno_threadpool_enter /cppu/source/threadpool/threadpool.cxx:408:33
        >     #16 0x7f375cf144fa in binaryurp::Bridge::makeCall(rtl::OUString const&, com::sun::star::uno::TypeDescription const&, bool, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >&&, binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) /binaryurp/source/bridge.cxx:606:9
        >     #17 0x7f375d0aa130 in binaryurp::Proxy::do_dispatch_throw(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const /binaryurp/source/proxy.cxx:169:18
        >     #18 0x7f375d0a82f4 in binaryurp::Proxy::do_dispatch(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const /binaryurp/source/proxy.cxx:102:13
        >     #19 0x7f375d0a80cf in proxy_dispatchInterface /binaryurp/source/proxy.cxx:61:36
        >     #20 0x7f3782881fff in cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, _typelib_TypeDescription const*, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void**, void**, void**, unsigned long*) /bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191:5
        >     #21 0x7f378287ef40 in cpp_vtable_call /bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389:28
        >     #22 0x7f378292d60d in privateSnippetExecutor (/instdir/program/libgcc3_uno.so+0x13960d)
        >     #23 0x7f3774fd11c7 in dp_registry::backend::component::(anonymous namespace)::BackendImpl::ComponentPackageImpl::processPackage_(osl::ResettableGuard<osl::Mutex>&, bool, bool, rtl::Reference<dp_misc::AbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/component/dp_component.cxx:1376:17
        >     #24 0x7f37750f1c11 in dp_registry::backend::Package::processPackage_impl(bool, bool, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/dp_backend.cxx:631:17
        >     #25 0x7f37750f3f4b in dp_registry::backend::Package::registerPackage(unsigned char, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/dp_backend.cxx:688:5
        >     #26 0x7f3775206b47 in dp_registry::backend::bundle::(anonymous namespace)::BackendImpl::PackageImpl::processPackage_(osl::ResettableGuard<osl::Mutex>&, bool, bool, rtl::Reference<dp_misc::AbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/package/dp_package.cxx:805:27
        >     #27 0x7f37750f1c11 in dp_registry::backend::Package::processPackage_impl(bool, bool, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/dp_backend.cxx:631:17
        >     #28 0x7f37750f3f4b in dp_registry::backend::Package::registerPackage(unsigned char, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/registry/dp_backend.cxx:688:5
        >     #29 0x7f3774e55b17 in dp_manager::ExtensionManager::activateExtension(com::sun::star::uno::Sequence<com::sun::star::uno::Reference<com::sun::star::deployment::XPackage> > const&, bool, bool, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/manager/dp_extensionmanager.cxx:473:23
        >     #30 0x7f3774e54ab4 in dp_manager::ExtensionManager::activateExtension(rtl::OUString const&, rtl::OUString const&, bool, bool, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/manager/dp_extensionmanager.cxx:423:5
        >     #31 0x7f3774e5fa40 in dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/manager/dp_extensionmanager.cxx:723:21
        >     #32 0x7f3774e62b64 in non-virtual thunk to dp_manager::ExtensionManager::addExtension(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::task::XAbortChannel> const&, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) /desktop/source/deployment/manager/dp_extensionmanager.cxx
        >     #33 0x7f37ba706dcf in unopkg_main /desktop/source/pkgchk/unopkg/unopkg_app.cxx:429:40
        >     #34 0x501298 in sal_main /desktop/source/pkgchk/unopkg/unopkg_main.c:24:31
        >     #35 0x501276 in main /desktop/source/pkgchk/unopkg/unopkg_main.c:24:1
        >
        > 0x60d00035d920 is located 0 bytes inside of 136-byte region [0x60d00035d920,0x60d00035d9a8)
        > freed by thread T6 (cppu_threadpool) here:
        >     #0 0x4fe928 in operator delete(void*, unsigned long) /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_new_delete.cpp:172
        >     #1 0x7f379ce94875 in release(void*) /registry/source/registry.cxx:47:9
        >     #2 0x7f375ee8e6b5 in Registry::~Registry() /include/registry/registry.hxx:955:13
        >     #3 0x7f375ee92582 in RegistryKey::~RegistryKey() /include/registry/registry.hxx:655:5
        >     #4 0x7f375ee744e6 in (anonymous namespace)::Key::~Key() /stoc/source/simpleregistry/simpleregistry.cxx:101:7
        >     #5 0x7f375ee74558 in (anonymous namespace)::Key::~Key() /stoc/source/simpleregistry/simpleregistry.cxx:101:7
        >     #6 0x7f37b53a682a in cppu::OWeakObject::release() /cppuhelper/source/weak.cxx:230:9
        >     #7 0x7f375ec5c009 in cppu::WeakImplHelper<com::sun::star::registry::XRegistryKey>::release() /include/cppuhelper/implbase.hxx:115:66
        >     #8 0x7f37828f0054 in freeUnoInterfaceProxy /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:42:19
        >     #9 0x7f37b5ee924d in (anonymous namespace)::s_stub_defenv_revokeInterface(__va_list_tag (*) [1]) /cppu/source/uno/lbenv.cxx:372:17
        >     #10 0x7f37b5e8fcbc in s_environment_invoke_v(_uno_Environment*, _uno_Environment*, void (*)(__va_list_tag (*) [1]), __va_list_tag (*) [1]) /cppu/source/uno/EnvStack.cxx:293:9
        >     #11 0x7f37b5e8fa04 in uno_Environment_invoke_v /cppu/source/uno/EnvStack.cxx:312:5
        >     #12 0x7f37b5e9016a in uno_Environment_invoke /cppu/source/uno/EnvStack.cxx:321:5
        >     #13 0x7f37b5ec2dc5 in (anonymous namespace)::defenv_revokeInterface(_uno_ExtEnvironment*, void*) /cppu/source/uno/lbenv.cxx:426:5
        >     #14 0x7f37828f0f08 in releaseProxy /bridges/source/cpp_uno/shared/unointerfaceproxy.cxx:78:9
        >     #15 0x7f375cf305c5 in com::sun::star::uno::UnoInterfaceReference::~UnoInterfaceReference() /include/uno/dispatcher.hxx:107:9
        >     #16 0x7f375cf0f387 in binaryurp::Bridge::releaseStub(rtl::OUString const&, com::sun::star::uno::TypeDescription const&) /binaryurp/source/bridge.cxx:514:1
        >     #17 0x7f375cfe8b9b in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const /binaryurp/source/incomingrequest.cxx:138:18
        >     #18 0x7f375cfe5a46 in binaryurp::IncomingRequest::execute() const /binaryurp/source/incomingrequest.cxx:79:26
        >     #19 0x7f375d0ae662 in request /binaryurp/source/reader.cxx:86:9
        >     #20 0x7f37b5cf5a2b in cppu_threadpool::JobQueue::enter(void const*, bool) /cppu/source/threadpool/jobqueue.cxx:100:17
        >     #21 0x7f37b5d161c4 in cppu_threadpool::ORequestThread::run() /cppu/source/threadpool/thread.cxx:165:31
        >     #22 0x7f37b5d20fc4 in threadFunc /include/osl/thread.hxx:189:15
        >     #23 0x7f37bb9d9f0f in osl_thread_start_Impl(void*) /sal/osl/unx/thread.cxx:265:9
        >     #24 0x7f37b9e35ea4 in start_thread /usr/src/debug/glibc-2.17-c758a686/nptl/pthread_create.c:307
        
        The SimpleRegistry UNO implementation appears to be the only one of the few
        remaining uses of the legacy registry functionality that suffers from this
        issue, so address things there and keep the registry functionality itself non-
        MT-safe.
        
        Change-Id: I5a87f1c66d838603672f6dfd19e6d1b617fbe691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142713
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-14  Miklos Vajna  <vmiklos@collabora.com>  [1ff360c29c99a570bfe59c69d8f589d4f2b59135]

        sw: add new FieldType parameter for the .uno:TextFormField command
        
        Currently LOK clients can't insert fieldmarks which are comparable to
        the ones Zotero's Word extension inserts into DOCX files.
        
        There is already a .uno:TextFormField UNO command to insert fieldmarks,
        but it has a hardcoded field type set to ODF_FORMTEXT, which is not what
        we need.
        
        Fix this by adding a new, optional FieldType parameter to the existing
        UNO command.
        
        The field code/command and the result is not yet possible to customize.
        
        Change-Id: I5625858af950f718220eebeef8fb90267693db7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142709
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-14  Caolán McNamara  <caolanm@redhat.com>  [b8850fe1d7dc86009516352c796619b33856141c]

        tdf#147802 don't trigger fade timer already shown/hidden
        
        once they widgets are created and hidden, they are getting triggered to
        update contents on pretty much all layout/draw events even though they
        are already in the visibility state they are asked to enter.
        
        Change-Id: I6078a5f322c88f0380ac42537b4921af1c56add5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [95dceefe207da45bd955d07a88bf7a956b274081]

        split CairoCommon XOR code into its own method
        
        Change-Id: If615f08a44a083d53c75f58af3578e59634f9a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [c3ca46945aa498907a938e33b2df7937f45199db]

        sc: factor out common code in makefiles
        
        Change-Id: I46cce6cb332fb060a9e8f691d8f70808398b85ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142707
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [1409159d6117d49e61fe5369f858239ff259fc1e]

        tdf#148971 Make a11y check dlg non-modal
        
        Change-Id: I56dcb3b09bd00a438a6fb5c442caa11d90723195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142706
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [161655080723717e91ec21e3f8015459d4180911]

        Save with latest glade
        
        Change-Id: I2dee470598695252c3e8f3ae17788571c62dc534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142705
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-14  Bogdan B  <buzea.bogdan@libreoffice.org>  [ed0f427f037582569700d2e43ba72a2fc1b771fd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to edc4b1fe0d17deebe719bca6eeb0a9fe316d1500
          - tdf#152022 Improve Edit page for Help Online
            
            Change-Id: If10520d16ec070da9ce2e527e0fe47ab49e814e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142674
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-14  Bogdan B  <buzea.bogdan@libreoffice.org>  [c70bdb80a753aaf04a87647194e3aacbb758ff98]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06746717a526ff5a0b0e807c06c321e8b66ae154
          - tdf#152022 Correct a link for a Edit submenu
            
            Change-Id: I861b76648760bf2f82b1d067fd74481787e62fbb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142675
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d17308bb77351b49d3a9ebb96cd703208911f33]

        sd: fix build
        
        After 1b167f3e0b1afec7c257f458db7505d8d8f177b3
        "tdf#142291 PPTX export: fix table border styles"
        
        and
        
        0b224cc5f3c896d8b0064d5cbadc6fce66c8beb9
        "Revert "Revert "tdf#151622 PPTX: fix export of show as icon option"""
        
        Change-Id: Iadd296f1bb804f91f50d4d0a056153586a06ebe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142699
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-14  Stephan Bergmann  <sbergman@redhat.com>  [d1faa8f62621221e85b8f7d42b766a6a4e76923f]

        Add some missing member operator== const qualifiers
        
        ...that were only detected now by GCC 13 trunk after
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=431be04b8b6e31d950ddab340ed866d197d23d4d>
        "c++: implement P2468R2, the equality operator you are looking for",
        
        > sc/source/core/tool/interpr4.cxx: In member function ‘void ScInterpreter::ScTableOp()’:
        > sc/source/core/tool/interpr4.cxx:3608:58: error: C++20 says that these are ambiguous, even though the second is reversed: [-Werror]
        >  3608 |     bool bReuseLastParams = (mrDoc.aLastTableOpParams == aTableOp);
        >       |                                                          ^~~~~~~~
        > In file included from sc/inc/document.hxx:32,
        >                  from sc/inc/externalrefmgr.hxx:23,
        >                  from sc/source/core/inc/interpre.hxx:28,
        >                  from sc/source/core/tool/interpr4.cxx:22:
        > sc/inc/tabopparams.hxx:76:10: note: candidate 1: ‘bool ScInterpreterTableOpParams::operator==(const ScInterpreterTableOpParams&)’
        >    76 |     bool operator ==( const ScInterpreterTableOpParams& r )
        >       |          ^~~~~~~~
        > sc/inc/tabopparams.hxx:76:10: note: candidate 2: ‘bool ScInterpreterTableOpParams::operator==(const ScInterpreterTableOpParams&)’ (reversed)
        > sc/inc/tabopparams.hxx:76:10: note: try making the operator a ‘const’ member function
        
        etc.
        
        Change-Id: I0c55daabbce61aefd762862f3b0e2e5d235c34b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142698
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-14  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d8c89fb920af747ec51ce966b5d7b65e9340afbd]

        tdf#151891 PPTX import: fix regression of connector position
        
        If the connector shape is connected to the glue point which there
        is inside the bounding box, then the position of connector appear
        incorrectly, for example different direction of the arrow head.
        
        Regression likely from commit cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8
        "tdf#89449 PPTX import: fix line connectors", as tdf#148926.
        
        Follow-up to commit eec48130271188cab63665acedbabf1ff5e850a2
        "tdf#148926 tdf#151678 PPTX import: position of standard connector
         - part1".
        
        Change-Id: I5671bc70e663a979c43bad1b786118a6a9e92972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142293
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-11-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [0b224cc5f3c896d8b0064d5cbadc6fce66c8beb9]

        Revert "Revert "tdf#151622 PPTX: fix export of show as icon option""
        
        This reverts commit b652ebda7fa4e6c8db2f934bf4c8d2927f5c2332.
        
        Adapt unittest to UnoApiTest
        
        Change-Id: I6a1e42d4b445efdb48dab35f0bd5110aa52b0d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142156
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-14  Miklos Vajna  <vmiklos@collabora.com>  [223d0eccaceb1208c5b51d83b4df431a9bed2bbe]

        sw: prefix members of SwAddStylesDlg_Impl, SwAutoMarkDlg_Impl, ...
        
        ... SwFramePage and SwWrapTabPage
        
        See tdf#94879 for motivation.
        
        Change-Id: I6f15fee117b9c05aeae7dfbb0b49c30d49018d49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142667
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-14  Tibor Nagy  <nagy.tibor2@nisz.hu>  [1b167f3e0b1afec7c257f458db7505d8d8f177b3]

        tdf#142291 PPTX export: fix table border styles
        
        Export border style subset used by the PPTX
        import, ::table::BorderLineStyle::SOLID, DOTTED,
        DASHED, DASH_DOT and DASH_DOT_DOT.
        
        See also tablecell.cxx:applyLineAttributes().
        
        Change-Id: I5e4d631f7ca410beb76155579ea5b21a6eb66350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142240
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-14  Hossein  <hossein@libreoffice.org>  [2d7db6981e5087507c02bde6c0841c388cfaad0f]

        tdf#152012 Fix assert fail on opening date picker
        
        This patch fixes tdf#152012 which caused an assertion failure on opening
        date picker field in a DOCX file
        
        The assertion was:
        
        include/o3tl/span.hxx:83: constexpr o3tl::span<T>::value_type& o3tl::
        span<T>::operator[](o3tl::span<T>::size_type) const [with T = const
        int; o3tl::span<T>::reference = const int&; o3tl::span<T>::size_type
        = long unsigned int]: Assertion `pos < size()' failed.
        
        And the backtrace was:
        
        1  __pthread_kill_implementation           pthread_kill.c:44
        2  __pthread_kill_internal                 pthread_kill.c:78
        3  __GI___pthread_kill                     pthread_kill.c:89
        4  __GI_raise                              raise.c:26
        5  __GI_abort                              abort.c:79
        6  __assert_fail_base                      assert.c:92
        7  __GI___assert_fail                      assert.c:101
        8  o3tl::span<int const>::operator[]       span.hxx:83
        9  OutputDevice::ImplLayout                text.cxx:1396
        10 OutputDevice::DrawTextArray             text.cxx:948
        11 Calendar::ImplDraw                      calendar.cxx:71
        12 Calendar::Paint                         calendar.cxx:1133
        
        The problem was caused by an out of bound access to a vector of integers
        which was created for rendering calendar header consisting of the first
        letters of 7 days of week, when you clicked on the down arrow on the
        date field.
        
        The function OutputDevice::DrawTextArray() takes an 'rStr' string to
        draw, and 'pDXAry' array for the exact position of the the individual
        characters. It also takes 'nIndex' as the first index, and 'nLen' as the
        length of the array. 'nLen' has the default value of -1. In this case,
        the length is calculated from the size of the string passed to the
        function. This works well if the one who uses the function makes sure
        that the size of the array and the length of string are equal.
        
        Previously, for the 7 days of the week, a 7 letter string "smtwtfs"
        (depending on the week start day this can be different, but length is
        always 7) was sent to this method without providing the length, thus
        the string length: 7 was used. In this case, positions of the letters
        were calculated and used from other array named mnDayOfWeekAry[7].
        mnDayOfWeekAry[k+1] was used as the position of letter k (k=0..5).
        In this case, there was 7 letters for 7 days, and only 6 positions
        provided by the array. This caused assertion failure in span.hxx:83
        when trying to accesss mnDayOfWeekAry[7] via o3tl::span<T>::operator[].
        
        Value of mnDayOfWeekAry[0] was used in other calculations, therefore to
        fix this problem, mnDayOfWeekAry was extended from 7 to 8, and the last
        position was set to the end of drawing rectangle.
        
        The other thing that is done in this patch to avoid this problem in the
        future is removing the default value from the function prototype, so
        that the use should always be done by providing the length of array and
        starting index. After removing these defaults, it became necessary to
        provide empty arrays for 'pKashidaAry' which provides the kashida
        positions, if needed.
        
        With this fix in place, the assertion failure no longer happens.
        
        A UI test is added to make sure the crash will not happen again. The
        test can be run by invoking:
        
         cd sw && make -srj1 UITest_writer_tests5 \
          UITEST_TEST_NAME="DateFormFieldPropertiesDialog.dateFormFieldDialog.test_date_picker_drop_down" \
          SAL_USE_VCLPLUGIN=gen
        
        Change-Id: I347afb358fbc4956524f7f0a0abc3a221bf42992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142642
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-14  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9e134c17400f5c19f3dc2b93b1a76b3f3e56503d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 17faaf70b750aec109ffa3bd069731bf37fc06e5
          - DoEvents extra indications
            
            Change-Id: I04da53ff9a7426a1698c880e26b4cdf01b7daf90
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142677
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-14  Alain Romedenne  <alain.romedenne@libreoffice.org>  [ba468f030e450511bcfd0c407506e023d7f512b7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b87a0e224b4a9150aeedc548de8c50d0276071b8
          - CreateUnoServiceWithArguments supplemental method identification pattern
            
            Change-Id: I38e3938e9392558951c1cd64b2a669bd5e5c9093
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142676
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-14  Justin Luth  <justin.luth@collabora.com>  [98d322d6c0e935a24f46bef014824084b6fcfdfd]

        tdf#151548 vba FormFields: Add basic word::XTextInput support
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        This now allows MS Word Basic legacy text form fields
        to be controlled by VBA basic.
        -allows getting and setting the text string
        
        Change-Id: Ib4601d4e087233a3db257728374b362bb34d1ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142262
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-14  Maxim Monastirsky  <momonasmon@gmail.com>  [b257b4f247bc2a1fa4d469ec82e37bdbb268951b]

        svx: On table style removal, revert to the default style
        
        Change-Id: Ie299634c93640a89d9c98b2cd517c5cb83434ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142666
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-14  Maxim Monastirsky  <momonasmon@gmail.com>  [f06353aadfc1a9329da0d5fe0cb5878d124b01aa]

        svx: Update tables on style changes
        
        After modifying a cell style, it is required to broadcast
        the SfxHintId::DataChanged hint on that style, to update
        the table appearance. However, it doesn't work when only
        text attributes (e.g. font name or color) were changed,
        unless the table is also moved around a bit.
        
        It seems to be the same problem as i#101556, whose fix
        didn't handle the table case. The problem here is that
        the change hint is handled by the individual cells
        properties objects, and nothing updates the table's
        properties object.
        
        Change-Id: I30ebc85c16b20c5354f02a309e6fa3dd4b31f669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142665
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-11-14  László Németh  <nemeth@numbertext.org>  [c6688def010fcb6854c6d896efe7186ff6c63475]

        tdf#151993 DOCX import: convert decimal comma only if needed
        
        E.g. convert en_US document with decimal comma, but not
        de_DE document with decimal comma.
        
        Regression from commit 94bf4908a6661101c270ef647e33dde09f16ac08
        "tdf#148799 DOCX import: fix invalid formulas with comma".
        
        DOCX allows to set decimal symbol independently from the locale
        of the document, so if the DOCX document uses comma, but
        its locale ("language") has got a default decimal point in Writer,
        Writer formulas must contain decimal points instead of commas,
        otherwise automatic update of the formulas, e.g. moving text
        cursor in the table, results ** Expression is faulty ** instead
        of the recalculated value. The only way to get standard
        Writer formulas is to replace the commas with points in numbers
        in writerfilter, if document language has a default
        decimal point in Writer.
        
        Note: not only document language, but area setting of
        LibreOffice installation modifies formula handling. I.e.
        plain numbers recognized with comma only if area setting
        is modified to a language, which uses decimal comma
        (but formulas still need decimal points, if the language
        of the document is a locale with default decimal point).
        E.g. an en_US DOCX document with decimal comma, or a
        de_DE document with decimal comma loaded correctly now,
        but recognizing cell content with a single number with comma
        needs to set also the correct area setting.
        
        Change-Id: I16dba1e10bf4271a44c435b5b09345d8d698b91d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142611
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-14  László Németh  <nemeth@numbertext.org>  [099d5d22b38bb0ea91faaed14ecc0edfa010ff11]

        tdf#115007 i18npool: add NatNum12 support to Persian, fix Hebrew
        
        Add NatNum12 cardinal support for new Persian (Farsi) module
        of libnumbertext 1.0.11.
        
        Hebrew has no uppercase letters, also currency support is broken yet,
        so remove bad number formats.
        
        Follow-up to commit b7d53247eb2fab04f5f6d82d405f1ac0c73542b2
        "tdf#115007 i18npool: add NatNum12 formats to locale" and
        commit 6064b3382102bcbc153156f5874fbc8dfde97b98
        "tdf#115007 tdf#148672 bump libnumbertext 1.0.11".
        
        Change-Id: I9a2a40e7485d4d4ff150d9946e58aed0d7526678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142658
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [31c5b3f10b3e1d1d86d9fc3553c6f55599b080ce]

        tdf#151605 Add option to not include hidden text in ASCII filter
        
        When setting this option, hidden text will not get exported/copied to clipboard.
        
        Change-Id: Id31aafc28ffb61a81bdc1412892f9e7997512f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141551
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-14  László Németh  <nemeth@numbertext.org>  [6064b3382102bcbc153156f5874fbc8dfde97b98]

        tdf#115007 tdf#148672 bump libnumbertext 1.0.11
        
        tdf#115007 fix missing currency of en-BZ, en-DK, en-IL, en-LK,
        en-ZM, en-ZW; es-PA, es-SV, es-VE; and ga (Irish).
        
        tdf#148672 fix of transliteration of parenthesized words of hu-Hung.
        
        – remove EmptyString.patch1 wich was merged up-stream;
        
        – add test for hu_Hung transliteration of parenthesized words;
        
        – add new Persian (Farsi) module;
        
        – fixes for Czech, English, Irish, Romanian, Russian, Slovenian,
          Spanish and Ukrainian.
        
        Follow-up to commit 2a1d2d42af7f365330479f4032ddfdd9eeba7c1d
        "tdf#115007 add NatNum12 number format list items, fix title case".
        
        Change-Id: I24aa32ad28c853e4c97a10dc8039ca6232eaed4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142657
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-11-14  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b15c82e02c0a97d3523b6e46cb4ba4c958ea38d0]

        tdf#151912: sw: suppress exceptions during SDT evluation
        
        Failure in XPath processing during retrieving fresh value from
        data source is not a critical problem and should not cancel
        document loading.
        
        Just put warning in log and continue to eval further.
        
        Change-Id: I76ecf0e0e227f46a270db3e77d86c19f7e9ad21a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142428
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-11-14  Julien Nabet  <serval2412@yahoo.fr>  [c871d797ce8675f97ef4789304bf85048cd2c8c4]

        tdf#151962: Math Shortcut to open documents in Spanish version
        
        Change-Id: I9802703257f64c9bcb7bc2be77c2f85ef1dec5e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142557
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-11-14  Balázs Varga (allotropia)  <balazs.varga.extern@allotropia.de>  [fe8c8ec112e1442828da49a81d8588e6a145458c]

        WASM: fix loading writer docs after rebase
        
        Add missing UI elements to emscripten fs image.
        
        Change-Id: I1165fd227674656b818247e58b0a24e815c63392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142579
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-11-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6e66b5d75b4cda0314b64f4d12ef9e4350751470]

        sw: refactor to make a11y check for nodes independent
        
        Add checkNodes, which will only check the current node for a11y
        issues. This prepares for online a11y check.
        
        Change-Id: I069cd200ceb58223b05baaafb7d796148e28398b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141603
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [517d05dbfd1e25e51d4b813f5a4c53b89464aa43]

        Fix typos
        
        Change-Id: Ic1fb0ea483954f2994a87e05f33b320da3795227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142661
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-13  Caolán McNamara  <caolanm@redhat.com>  [66d5ab895b75f0b81742d9c7806837cdd1acec74]

        ofz#53182 Timeout
        
        Change-Id: Ied736c72f08a97de142bb781e01283330db6b3b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-13  Caolán McNamara  <caolanm@redhat.com>  [e56479ee8a88f538c2163ddd58c5dc49a8744500]

        ofz#53338 Abrt
        
        we're turning "false" to indicate nothing was drawn, but nothing was
        drawn because the entire output would have been clipped out, so there's
        no point drawing anyway, so return true instead to indicate the draw
        was successfully short-circuited to give a correct no-op result
        
        probably went wrong with:
        
        commit 9153a36b59f2efc2bfb2c9256c39eb5687808deb
        Date:   Fri Mar 28 23:30:02 2014 +1100
        
            fdo#74702 Refactor OutputDevice::DrawTransparent()
        
        Change-Id: I989ebffff267f57c036560cda59eb7abe14d405a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-13  Eike Rathke  <erack@redhat.com>  [dffeb48f25123b16e60aed5aa4abaeefa92f83a1]

        Clear only lookup caches of calling document
        
        It is the same for always reused interpreter context slots but
        does not hurt and prepares for when more than one document is to
        be cached.
        
        Change-Id: Icc8532080f618b9a50627a6e551dfb28803d3c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142643
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [5ccba00d2007d664b9ffd0f956323a8180cb8e66]

        vcl: extract functions AllRenderersPaused() and PruneMarkedRenderers()
        
        Change-Id: I0fc55e829e22b81a076f2b66d78bb2b90abdfc41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136413
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [d773da0c083b4ee1cf1cccc2bd7846cbdbe37ed8]

        vcl: small optimization determining if any renderers are active
        
        Currently we look at every renderer to see if it is paused. However, you
        can think of this differently - instead of using a universal quantifier
        we can actually use an existential quantifier - if even one renderer is
        not paused, then we can say that not every renderer is paused - thus no
        global pause. Hence switch to any_of(), which stops the loop at the
        first instance of a non-paused renderer.
        
        Change-Id: I3b35bc41e86432374e4bc5fae0a2927ec8cc2309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136412
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-13  Harshita Nag  <nagharshita16@gmail.com>  [75b569890a6630bb2a5b727c8567f7ea59ccb62e]

        tdf#114441: Convert use of sal_uLong to better integer types
        
        The above change was possible because GetPos() returns value of type sal_Int32
        
        Change-Id: I9fa4389531813eb3c866a355d2f55ddfb32233a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142634
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-13  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [651142cbc6305b182a22efbdc4524e614483cf88]

        Adapted convertToBitmapEx to simpler BitmapEx creation
        
        As long as not all our mechanisms are changed to RGBA
        completely, mixing OutDev with Alpha (2x VDev) and RGB
        target rendering is just too dangerous and expensive
        and may to wrong or deliver bad quality results (see
        comments in code for details).
        
        Nonetheless we need a RGBA result for convert to
        BitmapEx. Luckily we are able to create a copmplete
        and valid AlphaChannel using 'createAlphaMask'.
        
        Based n that we know the content (RGB result from
        renderer), alpha (result from createAlphaMask) and
        the start condition (content rendered usually
        against COL_WHITE). Tht makes it possible to
        calculate back the content, quasi 'remove' that
        initial blending against COL_WHITE.
        
        That is what the helper Bitmap::RemoveBlendedStartColor
        does. Luckily we only need it for convert To BitmapEx,
        not in any other rendering.
        
        This gives good results, it is in principle comparable
        with the results using pre-multiplied alpha tooling,
        also slightly reducing the range of color values where
        high alpha vlaues are used, but in areas that are
        highly transparent anyways.
        
        Also important is that this will work with RGB-based
        system-dependent renderers, too. The method before
        could only work with the VCL-based primitive renderers
        by principle (only there - by coincidence - OutputDevice
        with Alpha worked).
        
        NOTE: Had to re-add usage of *unused* alpha channel
        in convertToBitmapEx due to test SdPNGExportTest. It
        somehow creates an Alpha in Bitmap size when I *remove*
        Alpha in convertToBitmapEx, so I just keep it for now,
        it is created anyways, just wanted to make it sleeker.
        
        Change-Id: I12e47327f5793d6ed87e217a2355c608f528246f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142547
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-12  Caolán McNamara  <caolanm@redhat.com>  [55cd20e6228a06836285c14ca6726adb1bb4ffcb]

        cid#1516789 Division or modulo by float zero
        
        Change-Id: I191d475df5d1937e80fe6844de618a9ce315aee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a73c593e8e31080db7be5103b29bfe468652dc73]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b64fc6ca64e2096615dc3f85f079c9e00798060
          - Fix typo
            
            Change-Id: I9c89564838a5d8c944c16849b2a2979ef4aa4298
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142582
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-12  Eike Rathke  <erack@redhat.com>  [f86a0666ac337363b470c9c67fa0970a330b26a2]

        Resolves: tdf#152014 When reusing interpreter context slot clear lookup cache
        
        ... if different doc
        
        As is, unthreaded the same slot gets reused for every calculation.
        That could benefit from keeping 2-3 documents cached to not throw
        away the lookup cache each time when alternating between
        documents.
        
        Change-Id: Id024333f72bcdcd6109042dec1104f3029955d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142639
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-12  Khaled Hosny  <khaled@aliftype.com>  [755e6939adc9b8b1322f739c8143ae1a7e2995a3]

        vcl: remove unused WinFontFace() private members
        
        Change-Id: I0f7f9f03064a63f7c27346fd679e4cb436633cd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142638
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [841cf269f0ebd4966814e187bf7e2e52bd4a6e28]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c3e7ddee14953d56f7672fcbcc3b81bd34b455e8
          - Add screenshot for index entry in swriter
            
            Change-Id: Id8db451f9305d22a27d72452e92e80cdc369ff42
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142636
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [79f8af579d1d24d1f3c990723eafe0194aeb35ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3a41dd6f1d61dc8ddc95075cb692e63c862be5bd
          - tdf#151347 Improve Slide/Page pane references
            
            + Added pane entries in Index
            + refactor xml
            
            Change-Id: If4e4db9664a2fef301a742b2d34127fecf585ed1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142612
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [9f5e2a888a41aa458ba5401e51c01ca6c0bd1963]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35e127cada4630c096b91126d07fe43f70a85b8f
          - tdf#152011 Improve View menu description
            
            Change-Id: I36e11dde9ca5398f9f9bb5c6600cb300380ac114
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142626
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [0c1962a47d1eb22e458001d9454ca27142607f98]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6301f83f2a36ea78ba8cfefbc39f710aff717ef8
          - tdf#152011 Improve Form menu description
            
            Change-Id: Ic0c58c611fe2fb9260eeef235aac39cc85c9f4f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142627
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [1d79fc94bec46ca3f378126901e542a39791639f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c9bc4ba19109f877e9fa71ecaa071887943d3c3
          - tdf#152011 Improve Tools menu description
            
            Change-Id: I4afb4edebc98e692d10ba7c83588886245303a79
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142628
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [516cb55e111db116033012338ed0ef5917f9938b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 55781399fdda75511fbc1e96bef79ace02ced37b
          - tdf#152013 Improve File submenus description
            
            Change-Id: I67ec0201c521c3d4fea3eaaa0f359da5bb760d46
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142629
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [121d20a17cde65ddd577f48bda4c2679670878bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f934ad3e896be59c76e35cf0033be0c7abe1e41c
          - tdf#152011 Change "open" to "create" for a new document
            
            Change-Id: If5e5476465baa225a54448a6bccfebef30fd3f05
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142624
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Regina Henschel  <rb.henschel@t-online.de>  [bd7f1270cf58eba7600d1b4c6c8ca9a901a04f66]

        tdf#125085 PPTX WordArt import: get shape font from run
        
        PPTX uses the settings at the run for the text in a WordArt shape. LO
        uses the settings of the shape. The patch copies the run font and
        language properties to the shape.
        
        In addition I have split the old method lcl_createPresetShape and
        renamed the parts.
        
        Now the method lcl_putCustomShapeIntoTextPathMode contains the geometry
        changes to put a CustomShape into text path mode and to adapt the OOXML
        values to the values needed for our preset Fontwork shapes, which are
        based on binary MS Office.
        
        MS Office has the style of the characters of a WordArt as properties
        of the run. LibreOffice ignores most of the properties specified in
        the style of a span element, when the text is displayed as Fontwork.
        Instead LO uses the properties defined for the shape for styling the
        text. Copying the text properties to the shape is now done in
        method lcl_copyCharPropsToShape.
        
        The values in testTdf125573_FontWorkScaleX depend on the used Font.
        Since on creation time wrong Fonts were used and now correct Fonts
        are imported, the values have to be updated.
        
        Import of fill and stroke of the characters is still missing, only a
        rudimentary import of color for solid fill exists.
        
        Change-Id: I6f31fe07fb0656b2ce8581e7123265fa598ac9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142421
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-11-12  Caolán McNamara  <caolanm@redhat.com>  [34a90a7f56b7009bc95cf1b0a0e258fa0af2d52a]

        Resolves: tdf#145648 use the same reference device for comments as document
        
        so we get the same text measurements and so positioning matches.
        
        Change-Id: I7b3211cbd8eba41269688316d74a8f72ac734f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142603
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-12  Caolán McNamara  <caolanm@redhat.com>  [659164be6f4b8f2f26eed42367142333c9ae6200]

        ImplDbgTestSolarMutex assert from a11y
        
         #5  0x00007fffee605ea2 in ImplDbgTestSolarMutex() () at vcl/source/app/dbggui.cxx:35
         #6  0x00007ffff71186f0 in DbgTestSolarMutex() () at tools/source/debug/debug.cxx:54
         #7  0x00007fffa95614d8 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x895a9c0, pFrame=0x5358800, bCreate=false) at sw/source/core/access/accmap.cxx:1788
         #8  0x00007fffa961ac0e in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() (this=0xb90f800)
             at sw/source/uibase/docvw/SidebarWinAcc.cxx:65
         #9  0x00007fffa961ae27 in non-virtual thunk to sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleParent() ()
             at /home/caolan/LibreOffice/core/instdir/program/../program/libswlo.so
         #10 0x00007fffd8f4ae7d in atk_object_wrapper_new(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, AtkObject*, AtkObject*)
             (rxAccessible=uno::Reference to (sw::sidebarwindows::SidebarWinAccessible *) 0xba7f450, parent=0x0, orig=0x0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:970
         #11 0x00007fffd8f4a820 in atk_object_wrapper_ref(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, bool)
             (rxAccessible=uno::Reference to (sw::sidebarwindows::SidebarWinAccessible *) 0xba7f450, create=true) at vcl/unx/gtk3/a11y/atkwrapper.cxx:925
         #12 0x00007fffd8f4d246 in wrapper_ref_child(_AtkObject*, int) (atk_obj=0xb9d06f0, i=0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:500
         #13 0x00007fffd95700c3 in add_pending_items () at /lib64/libatk-bridge-2.0.so.0
         #14 0x00007fffea7154cb in g_idle_dispatch (source=0x21d40e0, callback=0x7fffd956fec0 <add_pending_items>, user_data=0x21d5890) at ../glib/gmain.c:5935
        
        and...
        
         #5  0x00007fffee605ea2 in ImplDbgTestSolarMutex() () at vcl/source/app/dbggui.cxx:35
         #6  0x00007ffff71186f0 in DbgTestSolarMutex() () at tools/source/debug/debug.cxx:54
         #7  0x00007fffa95614d8 in SwAccessibleMap::GetContext(SwFrame const*, bool) (this=0x894ce20, pFrame=0x53390f0, bCreate=false) at sw/source/core/access/accmap.cxx:1788
         #8  0x00007fffa956285f in SwAccessibleMap::GetContextImpl(SwFrame const*, bool) (this=0x894ce20, pFrame=0x53390f0, bCreate=false) at sw/source/core/access/accmap.cxx:1917
         #9  0x00007fffa9550a91 in SwAccessibleChildSList_const_iterator::SwAccessibleChildSList_const_iterator(SwAccessibleChildSList const&, SwAccessibleMap&)
             (this=0x7fffffffbb58, rLst=..., rAccMap=...) at sw/source/core/access/accfrmobjslist.cxx:65
         #10 0x00007fffa951c507 in SwAccessibleChildSList::begin() const (this=0x7fffffffbb80) at sw/source/core/access/accfrmobjslist.hxx:100
         #11 0x00007fffa95421c2 in SwAccessibleFrame::GetChildIndex(SwAccessibleMap&, SwRect const&, SwFrame const&, sw::access::SwAccessibleChild const&, int&, bool)
             (rAccMap=..., rVisArea=SwRect = {...}, rFrame=..., rChild=..., rPos=@0x7fffffffbcc4: 0, bInPagePreview=false) at sw/source/core/access/accframe.cxx:179
         #12 0x00007fffa9543be5 in SwAccessibleFrame::GetChildIndex(SwAccessibleMap&, sw::access::SwAccessibleChild const&) const (this=0xb7bd6e0, rAccMap=..., rChild=...)
             at sw/source/core/access/accframe.cxx:455
         #13 0x00007fffa9569721 in SwAccessibleMap::GetChildIndex(SwFrame const&, vcl::Window&) const (this=0x894ce20, rParentFrame=..., rChild=...)
             at sw/source/core/access/accmap.cxx:2905
         #14 0x00007fffa961ad89 in sw::sidebarwindows::(anonymous namespace)::SidebarWinAccessibleContext::getAccessibleIndexInParent() (this=0xb9ead70)
             at sw/source/uibase/docvw/SidebarWinAcc.cxx:80
         #15 0x00007fffd8f4d781 in wrapper_get_index_in_parent(_AtkObject*) (atk_obj=0xc517810) at vcl/unx/gtk3/a11y/atkwrapper.cxx:529
         #16 0x00007fffd957298c in append_cache_item () at /lib64/libatk-bridge-2.0.so.0
        
        Change-Id: I852f40f30be7c10223ccfd570cb8ca30f1a67f47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [57d279c81b8f57e1072e1b74809de23729208e3f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d26dc8bf2215097db8092428cc05a991aa03f8a4
          - tdf#89358 Example of implicit intersection for array formulas
            
            Change-Id: I6cb1b66a34f8bd95472e78dac03f8860c2cdd375
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142605
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [fbbf3901550afc176d7d2fac8dc7dd9500e57d6d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 52bd59d3f0ab56d1e105e28c3c458640819e8af9
          - tdf#152011 Change order of menus like in Writer Menu
            
            Change-Id: I4c7f531939825bf31f5fcc760568d878fff3cb79
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142622
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Bogdan B  <buzea.bogdan@libreoffice.org>  [005644df0b60a8e1140f55c031f9bf61fe813255]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c80376a16c26407a6209dd4e5b3aa6639d599f4c
          - tdf#152013 Change order of menus like in File menu
            
            Change-Id: I3d77b293d36ebc60aad5fc75f7fa33277743b50b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142623
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c5be3e2e7818367af6a67a2913c61c7456eba69]

        Fix typo
        
        Change-Id: Icec4f84ba52578588512fa6cccd1d0d62b02ef06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142602
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-12  Kevin Suo  <suokunlong@126.com>  [1bfb323801b9c88879b5948b16d47cdbbee87ab9]

        tdf#151988: Enable "Characters per line" and "Character width" when switch...
        
        ... back to grid type "lines and characters".
        
        Also enable "Snap to characters" for grid type "lines and characters" and disbale it
        for grid types "lines only" and "no grid".
        
        Change-Id: I101c8d80a79798fc6c992da766c658c3ba8802dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142513
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [ab4e40941e9ebae83f98ba918440b03eac5bdcaa]

        Fix VS2022 MSMs detection
        
        After commits 42da199753515584e615cdcdd8601d2ffc27245b (more VS2022 integration,
        Oct 14 10:58:25 2021 +0200) and 9ea17a6331ca9491e7012dca837d3815cd4309ac (Adapt
        to latest VS 2022 MSM versions, Apr 08 09:15:19 2022 +0200), the new 143 version
        of MSMs gets detected and passed to SCP, but not used there, so MSIs lack CRT.
        
        Additionally, it may happen that a redist is configured that does not match the
        actual CRT used in the build, because it picked a latest available version, and
        then an error happens when building MSI, because it expects MSMs in wrong source
        directory.
        
        This simplifies the checks, makes sure to look for the correct MSM version, and
        adds an error message in SCP in case when the passed version is not handled, to
        detect the incomplete support early.
        
        Change-Id: I47d45472309c584314730e7f5f46a9596fc8d21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142587
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-11  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [dd1610146528cba8642caad3bf72e27b9ca6c153]

        dragonbox: upgrade to release 1.1.3
        
        Change-Id: I0d240c50c311269c10d53ba3e4bc3dc09273a600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-11  Caolán McNamara  <caolanm@redhat.com>  [c3da84a10260b3260ee42df900e2ff01119e4f7c]

        Resolves: tdf#151898 get hidpi font/highlight color icons
        
        Most of this wouldn't be necessary if we could solve the split alpha
        problem. In the meantime, let Image take a MetaFile as an arg, record
        what we want to do in the metafile, and play it back when we need to
        generate the bitmap for to render the image. That way we don't have
        alpha to worry about during the recording, and we only have one alpha in
        the final rendering, as opposed to having two alphas in a source and in
        destination VirtualDevice, which is problematic in most backends.
        
        Change-Id: I5b0d7c498473271f4ab2743f75614b1b93a0e9c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142593
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-11  Caolán McNamara  <caolanm@redhat.com>  [c2c37eadf32c80bcd8f168b9fc67f32002b3cb07]

        Related: tdf#151898 consider surface scaling if prescale with Bitmap::Scale
        
        whose introduction dates back to:
        
        commit c0ce7ca4884f7f6d1016bd1dbcc22066cb4a7797
        Date:   Sat Jul 7 13:07:03 2012 +0200
        
            Prescale image with Bitmap::Scale to improve quality.
        
        don't prescale past the level of detail that the surface could retain
        
        Change-Id: I1022688d45d2bb7b692f4ba619198fccea8eab36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [7986d35eee84fdf391c563602fb348758e1cd254]

        move password handling from SwModelTestBase to UnoApiTest
        
        so other places inheriting from UnoApiTest can also import/export
        protected documents
        
        Change-Id: I0e2716204dbb171c9e17e3939b266977e1b96dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142592
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [4c9093c95445c154c4ce7db1756ca936ea0752ca]

        New loplugin:constmove
        
        "Find occurrences of std::move on const-qualified types.  While there might
        theoretically be legitimate uses for such (for which this plugin would generate
        false positives and would need to be updated), in practice they tend to point at
        suspicious code that should be cleaned up in some way."
        
        (All issues found for a Linux build have already been addressed with eleven
        recent commits mentioning in their commit messages:  "I came across this code
        with an upcoming loplugin:constmove that flags suspicious uses of std::move
        involving const-qualified types.")
        
        Change-Id: I891a66eb0ec5f9b7d93536bbccea0359893383df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142589
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Miklos Vajna  <vmiklos@collabora.com>  [c725028f15c36fc626d9ad8cdc288eb73c3e2643]

        SVG export: fix handling of semi-transparent, multi-para shape text
        
        The bugdoc had a shape with two paragraphs. The export of the second paragraph
        went wrong: the position & size of the text was larger than expected.
        
        This problem was specific to semi-transparent text.
        SVGTextWriter::setTextPosition() is recursive in this case. The non-transparent
        case left nCurAction unchanged in the outer setTextPosition() and it returned 1
        ("text is found"). The semi-transparent case changed nCurAction by +2 and
        returned 0 ("text is not found"). This led to all sorts of trouble, including
        mismatching Push() and Pop() calls on the output device when replaying the
        metafile.
        
        Fix the problem by routing the empty state from the inner setTextPosition() to
        the outer one: if we return 1 ("text is found"), then we know that the state is
        non-empty. Once the empty state is correct in the outer setTextPosition(), then
        even the transparent case also leaves nCurAction unchanged and the whole shape
        text has the correct position and size.
        
        I forgot to update this empty state in ther outer setTextPosition() in commit
        666f252457bdb4371d15380a0289e107b2dfbe84 (SVG export: fix lost semi-transparent
        text on shapes, 2020-07-17).
        
        Change-Id: I7dc93fe13c4510220bf09a388e742799ed042510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142590
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [c819aa06069ec3ea4f2f51d26a77f455740b828f]

        .git-hook: Emit some warning about clang-format and renamed files
        
        ...to avoid misguided clang-format'ing of previously excluded files, as
        discussed in the comment at
        <https://gerrit.libreoffice.org/c/core/+/142387/4#message-ce27921261661fe7488ef0564657dbb5b42fb5fa>
        "sc: factor out common code in make files".
        
        (Though this still doesn't warn about cases where some excluded file got renamed
        and the excludelist wasn't updated and the user already erroneously
        clang-format'ed the renamed file before this commit attempt.   Also, I don't
        know how best to integrate this with libreoffice.autostyle, so just ignore
        libreoffice.autostyle for now when any suspicious renames are detected.)
        
        Change-Id: I8d176ce536548b67f5b2af100f579f362764b06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142394
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [0443d6d253eb2b8aaab6fd37af4b08c7e21e37c9]

        SwModelTestBase: get rid of getSwXTextDocument
        
        no much value in having it around
        
        Change-Id: I864f039c0129a922c8d86b5db0a18158f2155add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142588
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a6b56a5a1cd8756ff6d0335554fe78bf9988c27]

        SwModelTestBase: use createSwDoc everywhere
        
        In order to unify the code
        Also call getSwDoc only when it's needed so move it outside
        createSwDoc
        
        Change-Id: I082d46108581e8f2e2e430e854980035f471ceac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142586
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Caolán McNamara  <caolanm@redhat.com>  [69efabc0ce798b86b6971f5a9adca11e98bec4d1]

        cid#1516788 Uninitialized pointer field
        
        Change-Id: I9565a995aa400fd391de70606b59c16e68a042c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142584
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [6d37a3e40bd08ccb1edb778088c8a627e728ccc5]

        SwModelTestBase: Check supportsService
        
        Also simplify code a bit
        
        Change-Id: I93b277116cd21f9e7e058fdf31e0defab8247f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [b74d50003145f3805e3316a51c8be0222e680152]

        Drop useless std::move of const object
        
        ...introduced with d8b60f77f389a248f98aa45592e6e1045baafbe1 "rtl_String->OString
        in DirectoryItem_Impl".
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I3df2e6fb9dbf97adba6fbeda51d24cf025f5b207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142565
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Caolán McNamara  <caolanm@redhat.com>  [be89fcabd3da94a6441d0e2d07e0980a66d72e98]

        ofz#53196 Out-of-memory
        
        Change-Id: I8cb6df1f109a1c10fb025b8ecd229487b73e900d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142578
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [0b3337c7f4773f84e8cfc2682ee5b1fbde0d51ae]

        uiwriter7: simplify code
        
        kudos to Mike Kaganski
        
        Change-Id: Ic10f794d09b882da95958ad42f3a02aaabbbe1f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [d9c708f78de6f6ef6621b47123a0ff164ddfee93]

        Clean up some seeming copy/paste mistakes
        
        ...all introduced with 2a26f136a36791c06caa895d5a25f4633fd10651 "tdf#151548 vba
        FormFields: Add basic word::XFormField support":
        
        For the SwVbaFormField ctor, std::move of a const lvalue has no effect here.
        (And I just don't bother applying the move-from-pass-by-value-param optimization
        here.)
        
        For FormFieldCollectionHelper, consistently make the data members non-const (a
        const css::uno::Reference wouldn't make that much sense anyway, as it doesn't
        transitively apply const'ness also to the referenced object) and non-reference,
        and make the FormFieldCollectionHelper params non-const (and non-reference) to
        make the move-from-pass-by-value-param optimization actually work here.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: Ib41d4671b33871eddff41bc20ea38de02d616046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142568
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Eike Rathke  <erack@redhat.com>  [5db9d8356c8fdc732942357cd2171ba27eda8647]

        Resolves: tdf#151947 Merging separators must not scan for field end
        
        Regression introduced with
        
            commit cf777cfcb22647b1f2d6ace307fbcc4f6d2cca30
            CommitDate: Sun Oct 2 17:07:06 2022 +0200
        
                Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip import
        
        a copy-paste replacement logic error.
        
        Change-Id: Ibd699a4edfa9f88da26d888afa8567ee34e78a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142572
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [37e95b4d6754d2c77a76a84ce51a0b18df93927f]

        Drop a counterproductive top-level const
        
        ...that was apparently left by accident by
        caa10a1f80da856debf4f397503f27c86199208f "vcl: Use a hb_face_t wrapper in
        TrueTypeFace", thwarting the use of std::move here.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I460b11738b0f480a91c1212632cb428cb1331cd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142560
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [15abaa8a35ddca43cebf884ec728350f9ae8fb08]

        Drop counterproductive const'ness of a member function
        
        ...introduced in c8d2fa176a15a7ae76d6a4b76aea5f108313c2ec "reduce copying in
        drawinglayer", but thwarting the use of std::move on a data member.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I9b32d8762b4cc57875343664642494c7098ffb4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142563
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Miklos Vajna  <vmiklos@collabora.com>  [e716ed8687a4eb99d9e8e1480dd7bfb2c872df7f]

        tdf#151980 sw content controls: fix RTL render of dropdowns
        
        - check if this widget is meant to be RTL in
          SwSelPaintRects::HighlightContentControl()
        
        - route RTLness to the underlying tree view / drop-down in
          SwDropDownContentControlButton::InitDropdown()
        
        - fix up SwContentControlButton (positioning, rendering, hit testing) to
          assume the button on the left of the first text portion in the RTL
          case
        
        Change-Id: I637ee8f08311e1273f8b19ddf3ab572af839760b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142577
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [ecb6ba6fb677a711afd515139cc7cf9cce771003]

        Drop useless std::move of const object
        
        ...introduced with 6c8dffc19e2a570d5665344dcba6afedd3dc2e15 "compute subset of glyphs in SalLayoutGlyphsCache (tdf#139604)".
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: Iaa356eb090cebabbed140906f0e0cee9a8039f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142567
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [ed38659127ac801666de1bc423855d2b666f7150]

        Drop counterproductive top-level const
        
        ...that was apparently left by accident by
        24c709655e5c1ca51c6c6da7ef0cb733354f6d20 "clang-tidy modernize-pass-by-value in
        comphelper", thwarting the use of std::move here.
        
        And clean up the declarations in the include file, too.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I8178ad09bc4e7d4f57c5dfd9b0e2103e6d4fa72a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142566
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [dbbfcfed6f877ad2446daefe1083f42994f28a1f]

        Drop counterproductive top-level consts
        
        ...that were apparently left by accident by
        b4b4c129e9f00189978cd7b71fd74d0dca4c9ebc "clang-tidy modernize-pass-by-value in
        ucb", thwarting the use of std::move here.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I95867aea623913ed37d57cb7d9593654ec57487d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142564
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Miklos Vajna  <vmiklos@collabora.com>  [c222722619ffcdcff17cfad8b932d5108eb54617]

        CppunitTest_sw_ooxmlexport10: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I3b33e6db9dca96cdeee3a569f7c5054132c4e02e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142569
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [59226be8dcf1bd374d4c16dbff8a382bbfeb6d1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0a4258b67775ee61f6d2f0b9b45b6437c508d338
          - tdf#151665 Track changes in margins
            
            These track changes show options are not in the track changes
            menu but are available in the track changes toolbar.
            
            They apply to Writer only, Calc does not have a track change toolbar.
            
            Change-Id: Iaf9ea40a87470d172cedf3fdf2f87c65fcc6a87d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142571
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [4d8907a7d5be6c81f68ab36353c231ad23681780]

        Revert useless std::move of const object
        
        ...added with f71606c920a3f78294da745cd9ef1eacde010224 "new loplugin:moveit".
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: If9c79d9a838fab5efbb55cb89b27b87f7e7ccd76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142562
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [54d6e292fbc25d296aabf879915afc1ea69a34f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f4fe6532ba4c65ee5baecfb4dc5167fd9111b97a
          - tdf#149221 More fixes to the Database Wizard dialog
            
            This patch create necessary HIDs for the Database Wizard dialog. It also creates a new help page named Connection Settings to serve as target for the widgets in dbwizconnectionpage.ui.
            
            Change-Id: I9b518ff65729bd8f24c9b0f6960ccd8015b66b80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142441
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [7079cf51a95c8efb1ba250e829bddfcaf6bbc132]

        Revert useless std::move of const objects
        
        ...added with 8a843f7e98dfe6bfb04e91e5b16e3a1df18fbf58 "loplugin:moveit".
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I099130acd67de7379992ce394226a7e233d6ca55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142561
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Justin Luth  <justin.luth@collabora.com>  [7444c8c87a228e4259f5dd34edfcf4c92ed02504]

        tdf#151548 vba FormFields: Add basic word::XCheckBox support
        
        make CppunitTest_sw_macros_test CPPUNIT_TEST_NAME=testVba
        
        This now allows MS Word Basic legacy checkbox form fields
        to be controlled by VBA basic.
        -allows getting and setting the checkbox value
        
        TODO:
        -wire up entry and exit macros
        -wire up StarBASIC support (hmm, how would that be different?)
           -probably completely ignore this. formfields hidden from
            normal writer - only activeX and content controls shown.
        -setup tri-state for checkboxes: with a separate default value
        
        Change-Id: Ied47a507dd9acc2c8dfd1472e6704e9dd571b480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142253
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-11  Bogdan B  <buzea.bogdan@libreoffice.org>  [1b5c7bad0f332b6923aa820301fc1ff6d00bd0ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff13d5c7d7014dde45a7712d96596accdb2209e1
          - tdf#148727 Correct sum example
            
            Change-Id: I117d3dccbda28ad6a851f537e00ed2aafb697c22
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142438
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [d5f53a97c9468a0dbe31212053c5686afd8450d4]

        Drop a counterproductive const&
        
        ...that was apparently left by accident by
        c7f8a54e05dab430cf2f5b3e1fa90e729c7a5601 "loplugin:moveparam in dbaccess",
        thwarting the use of std::move here.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I58cb6fc938efc470d6be6417d2dadd77989f1241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142559
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Alain Romedenne  <alain.romedenne@libreoffice.org>  [23807af596937f32cd67c54557a0800759ad7a37]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ddd19fff68342bc96ebdc88df7be56e4ec64a859
          - Basic typo
            
            Change-Id: I6890eea2de0b2e6e7d95c0289ef8810434a89df6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142517
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-11  Bogdan B  <buzea.bogdan@libreoffice.org>  [cbb83463513431907317bd1b5ab9d1849a4c96af]

        tdf#150607 Change Truncate to Round
        
        Change-Id: I660597ff977e10a80747927b73d0013527a2bab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142524
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-11-11  Stephan Bergmann  <sbergman@redhat.com>  [e962819af8b9e19c651103dd288e60658dfd76e5]

        Drop a counterproductive top-level const
        
        ...that was apparently left by accident by
        11c4ec15f13bbcc1b7a85e966519d75e64f62c4a "use more concrete types in chart2,
        Axis", thwarting the use of std::move here.
        
        (I came across this code with an upcoming loplugin:constmove that flags
        suspicious uses of std::move involving const-qualified types.)
        
        Change-Id: I75ebadf96044ceb247f232ad9f2d27fe643a7af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142558
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [e9f78eda01172c7f100d6e7695aaafe2b961d565]

        SwModelTestBase: remove duplicated method
        
        Change-Id: I343fe2711e232ffbdec13f0072ee31a7549f7da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142546
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [699251315aeba9620310410c0576c8b9c052c8b2]

        CppunitTest_embeddedobj_general: inherit from UnoApiTest
        
        Change-Id: Id4c056734b6cd3cd1b699a473c32bd69cc949e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-11  Kevin Suo  <suokunlong@126.com>  [1c11bfc0420245ee19ff9ef1f09eaac79bae53e1]

        Fix code block indent in SwTextGridPage::PutGridItem
        
        Use 4 spaces rather than 8.
        
        Change-Id: Ifdd72168c8ee7ec9b861f2e0ff24961f92747136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142509
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-11-11  Kevin Suo  <suokunlong@126.com>  [9b80b2d6140d1aad240f10755105e49d678b98f1]

        tdf#151979: fix crash in Text Grid dialog when switching active view
        
        GetActiveView() may return a nullptr when previously we are in Calc
        window and then click the controls on the writer dialog.
        
        Change-Id: Ia4dcd58b19c40a3e6cd0a791b7645d5fd2dcb9f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142508
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-11-11  Bogdan B  <buzea.bogdan@libreoffice.org>  [079adbadf57a1c31384aa676aa514522b0fa58b1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e98ce658dee0b8b8d017d97da4a817b84156de0
          - tdf#150607 Change Truncate to Round
            
            Change-Id: If37b518f0aebc8b5d7fb6eb4cd889c86f1ba14d2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142525
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-11-11  Emanuele Goldoni  <emanuele.goldoni@gmail.com>  [a0fac43e25bd0d7aa6215440e66136083c4de88d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 43a746e2dcbdea7b89172024a14e6c6f1738c95c
          - Update Italian hyphenation and dictionary
            
            Change-Id: Iad6cf43961c19c9aa9971abddf7f609b57b511d2
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/135435
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-11-11  Batmunkh Dorjgotov  <bataak@gmail.com>  [5b3604b3c971433fd431457a56e8200e60af3fe0]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 25477fbcf311ca3a6383a0ebcc99e0e4ada25b85
          - Update Mongolian dictionary
            
            Change-Id: Id3c5ec7bef29cf50d5381525960fdce392251391
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/137567
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-11-10  Szymon Kłos  <szymon.klos@collabora.com>  [61d716901def607f01ab272996bf40b55642d650]

        lok: sc: render expanded EditEngine when editing in-place
        
        It's regression from:
        commit 5a0839e60ac75869ad49685ca74ad6c6b49ef925
        sc: lok: fix offset edit output area
        
        When we use two views and one is editing multiline cell
        after pressing F2 (in in-place mode) by adding new lines
        (ctrl + enter) - we need to expand rendering area and
        show additional content (which covers next cells).
        
        This patch makes possible to render expanded are in all the
        views, not only for one used for rendering.
        
        Change-Id: Ief2cd391a23e65b3eb7eaf89f2a9f6471b87299f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139924
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142502
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e5e65715cf053deb7d52e62dd598ac51cea5ee6]

        Revert "tdf#126788 remove weak m_wThis reference"
        
        Causes race condition
        
        And add comment so I don't have think through this again.
        
        This reverts commit 2ae53eb5dcbe0a3c5b4dc5323639a11878a38101.
        
        Change-Id: Id18a7313e363a4ce4930b01fc760a3746b35a711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142548
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c365bedfda7f195bba2addbdaf84f3e471c26070]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05ca41502856e01755d7de748789cdfefd5e6d16
          - tdf#150909 Fix regression: HTML entities badly rendered
            
            The "branding" XSL template is applied to every text in the Help to
            replace %PRODUCTNAME or [$officename] by the correct product name.
            It must not escape HTML entities such as &lt; or other.
            
            Reverted previous workaround in xhp page.
            
            Change-Id: I1f7da19ca2899d92917504f162ba497bd9c787bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142555
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [56666fa48d4f9bc4e991126b4111130ee6c64b7c]

        Simplify and deduplicate SfxBaseController::queryDispatch
        
        Change-Id: Iffc67ff7e0840bd2402c4ba357f45a1493ff78ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142543
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [eb41a16530b6a37e2120a1a14975f024893a2ace]

        SwModelTestBase: use exisiting createSwDoc
        
        Change-Id: Ic55c245482d93f5ec26c90ca41fac29332bd807a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142549
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-10  Caolán McNamara  <caolanm@redhat.com>  [758163bf5a754160e692dfff511f0a8a750b6bba]

        Related: tdf#151898 use more of the code path that can use scaled svgs
        
        for hidpi
        
        Change-Id: I1dfb072e294fd30ce027eb3c69781f1450709dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142540
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [0232d4d19858f76fd63b8e525a835bd6fbcd3b8a]

        private field 'm_xModel' is not used [-Werror,-Wunused-private-field]
        
        ever since
            commit 2a26f136a36791c06caa895d5a25f4633fd10651
            Author: Justin Luth <justin.luth@collabora.com>
            Date:   Wed Nov 9 17:02:03 2022 -0500
            tdf#151548 vba FormFields: Add basic word::XFormField support
        
        Plus, this code is std::move'ing a value into a "&" field, which is
        very wrong
        
        Change-Id: Ia8bbf6e0eaa524ca0f5bbf7624f4b9555920f993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142545
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3df534a5ba01ec32590adb6c05ee6621e136b55e]

        Fix typos
        
        Change-Id: Id924e4747d6a3d81b69da28910c8e096565b9b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142538
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6ed5b6e566f8ce03253f60e816c4524440cd5851]

        Fix typo
        
        Change-Id: Ie5d81113eaf4b5103d685f4273f4b4942468f067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142506
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-10  Stephan Bergmann  <sbergman@redhat.com>  [707449adc90c80e68176c8df873803ff2f6f70f2]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): soltools
        
        These occurrences of sprintf in C code don't normally trigger the deprecation
        warning at least with recent macOS, because macOS by default now enables
        _FORTIFY_SOURCE (see the code setting it in
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/_types.h
        when originally unset), which for C code hides the declaration of sprintf (along
        with its deprecation annotation) in
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/stdio.h
        with a macro (expanding to __builtin___sprintf_chk) in
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/secure/_stdio.h.
        But they started to trigger when I did an experimental -fsanitize=address build,
        because
        <https://github.com/llvm/llvm-project/commit/b4f819086a61b5a843f0171a7467c5184ba1b086>
        "Disable source fortification on Darwin with AddressSanitizer" predefines
        -D_FORTIFY_SOURCE=0 in that case.
        
        While there might be ways to clean this code up to use something better than the
        deprecated sprintf, don't bother too much with this 3rd-party, build-time--only
        code and just silence any potential deprecation warnings.
        
        Change-Id: I9f223a0ad50b2729b5d9af2db588fe9f82d0b07f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142534
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [69eeb034b3722c91af2f39bd00874689906c0612]

        Simplify this a bit
        
        Change-Id: I6162b8f54eb685267aeebe48daa419933b6528a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142542
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [35be7c81987bd0b2a89fcfd2ee37d687a0b27bfd]

        Simplify the method and fix its description
        
        The description had the copy-paste error since commit
        648106f879fdf6609db1e0d4c8acb43b3a997833 (Fri Apr 04 16:12:43 2003 +0000)
        when impl_searchMatchingInterceptor was replaced with findByPattern.
        
        Change-Id: I84d8c867b6606ef8adb74df823046b58cf6d9b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142541
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-10  Sakura286  <sakura286@outlook.com>  [bc9487f745befde6534fd46058e119256952323d]

        Add riscv64 support
        
            1. Configure gbuild
            2. Add UNO Bridge for riscv64
        
        Till now base function works well on riscv64. The bridgetest has passed.
        Test on Debian, Gentoo and openEuler.
        
        Credits:
        
            - Heiher <r@hev.cc> and Stephan Bergmann <sbergman@redhat.com>
                The riscv64 bridge implementation refers to mips64 and
                AArch64 bridges.
            - Bo Yu <tsu.yubo@gmail.com> configures gbuild for riscv64.
            - WANG Xuerui <xen0n@gentoo.org> provides lots of guiding tips.
        
        Change-Id: Ifad3b0de8b2c9e7328627ed03396bbd45a9c71e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137445
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7ac572437ac972ef37aed8003f5a476f49b27b89]

        Fix typo
        
        Change-Id: Iaadab3d52a47deff3c1d2539068d197bbddd2852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142505
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81e3d731bee5ccc2a35c20943485f827d9f48d1f]

        Fix typo
        
        Change-Id: I368c1cf881da5fbccdf90ffdfba9714b8ecd776b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142539
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-10  Gökay Şatır  <gokaysatir@collabora.com>  [05a779e667b08b1b1d2622a56cb76702153d2454]

        Send unique window id along with other data to COOL.
        
        Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
        Change-Id: I9021c8218890906c0239f32503057262d7326fd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142485
        Tested-by: Jenkins

2022-11-10  Stephan Bergmann  <sbergman@redhat.com>  [bde11b3b1362a9451ef830bf14d0f8842818a922]

        Executable_cpp: Drop unused -Xa "EBCDIC to ANSI conversion" option
        
        ...which nicely gets rid of a bunch of sprintf calls that otherwise could have
        caused -Werror,-Wdeprecated-declarations with macOS 13 SDK now).
        
        (That executable is only used during the build to process the .scp files.)
        
        Change-Id: I3b087b11f6d3d1bce9e595322a21e67986f5d1c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142537
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-10  Szymon Kłos  <szymon.klos@collabora.com>  [ff9b9944401a594ec4a67bca953b312f3a54e3f8]

        lok: Introudce getDataArea for Calc
        
        It will share information about real size of a data inside
        spreadsheet so we can easily check where data ends in online
        side.
        
        Change-Id: I376187a33c5c82d409f559d5cc826a4f36d4252e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139472
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142503
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-10  Szymon Kłos  <szymon.klos@collabora.com>  [3f4e11bd40f60510272df7a285d8a78181af0ccb]

        lok: masterpage: use EditMode as parameter in invalidation callback
        
        Change-Id: I3905fc9e6376ca1cef3e438e7a5f229d3720b1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138961
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142501
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-10  Miklos Vajna  <vmiklos@collabora.com>  [652df8c733f381cac4e22286acd12a2ec72d41ae]

        sw content controls: drop not needed XServiceInfo impl
        
        As noted in
        <https://gerrit.libreoffice.org/c/core/+/142454/3#message-18fe8bb36fc24d317ad16dd25e236ed51c88a910>,
        introducing a dedicated css.text.ContentControls service is actually not
        needed and client code should be fine with just an "anonymous" object
        returned by getContentControls() + implementing XIndexAccess.
        
        Remove it before somebody starts to depend on it. Let's rather have a
        bit of inconsistency (e.g. SwXFootnotes implements XServiceInfo, while
        SwXContentControls not) than an XServiceInfo implementation that we'll
        have to support from now on, without a user.
        
        Change-Id: Ifde4fb6bcafdffabb189447415b89b01c9675296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142511
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-10  Caolán McNamara  <caolanm@redhat.com>  [397f5daa850e59f0f4d3881cb99d110b50e34e3d]

        tdf#151898 if svgs are used in hidpi get a high quality GtkImage
        
        this gets nice sidebar icons in this case
        
        as far as I can see only gtk_image_new_from_file (or
        gtk_image_new_from_resource) can support the use of a scaleable input
        format to create a hidpi GtkImage, rather than an upscaled lodpi one so
        forced to go via a file here
        
        Change-Id: I665cd5be2c87f6fe8e264640be228263cdfc1fba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-10  Justin Luth  <justin.luth@collabora.com>  [2a26f136a36791c06caa895d5a25f4633fd10651]

        tdf#151548 vba FormFields: Add basic word::XFormField support
        
        Unit tests will come in the following commits that represent
        actual FormFields that have content/results.
        
        This lays the foundation for adding
        Checkboxes, Textinputs, and Dropdowns.
        
        Change-Id: If85ae25f881198d5a0699b3350a7eb20b1735c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142507
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [e2f8558324091bddba0637942f4f000a24e673a7]

        Avoid double conversion
        
        The division of twips by 56.7, that produces ~millimeters, appeared in commit
        8fd87a90a5ebcc9d8c4ddc7ece6d20debd58e801 (cjk-character-units-imp.diff: add a
        new unit 'character unit', Mon Sep 13 14:37:51 2010 +0200).
        committer	Cédric Bosdonnat <cedricbosdo@openoffice.org>	Mon Sep 13 15:40:35 2010 +0200
        tree	96c24aabf9ef9aeed4af9920b4283ce2b6edba4c
        parent	1f578e21a92b3532ddfd8e0fd007a7ec6b2ee240 [diff]
        
        Change-Id: I1f311d979613c3f4e06110739e6c1823891e7e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142510
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-10  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7f4f536ca9195c7d53463527f00897b65d062486]

        tdf#107405 Allow kerning less than -2
        
        Fallout from 9a745d54a5c7470180f41494283983a3b8b84a51
        
        Change-Id: Ied4d83eb614830718cf304e7010f17516e4a9429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142388
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-10  Miklos Vajna  <vmiklos@collabora.com>  [5a69fd3052bb638857f30a4cfd5913634275d23d]

        Update pdfium to 5408
        
        - drop cg-instead-of-carbon.patch.1, no longer needed after
          https://pdfium-review.googlesource.com/c/pdfium/+/99753
        
        - drop AndroidNDK19.patch.1, no longer needed after
          https://pdfium-review.googlesource.com/c/pdfium/+/96530
        
        - drop gcc-c++20-comparison.patch, no longer needed after
          <https://pdfium.googlesource.com/pdfium/+/065698acf82962a3168a0d56bb1d5964bc593d00>
          "Fix interaction between RetainPtr<T> and transparent comparisons" since
          chromium/5321
        
        Change-Id: I1f861dd8a3d490400bb39c108bd4e767a2f45d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142474
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-10  insanetree  <treebian@tutanota.com>  [0cf5141b2233611286a27930d8030c562eb0d84b]

        tdf#147201 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I38fa927d9964b7212b84d42d5b1bc5f60386139c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141484
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-09  Paris Oplopoios  <paris.oplopoios@collabora.com>  [3c0be5564afe1b9cc843a49aba88b72af74c43ab]

        a11y: Add check for tabs used for formatting
        
        Add accessibility check and relevant test for a document that uses
        tabs for formatting
        
        Useful to detect fake tables made of tabs
        
        Change-Id: Ief765f25c8dc67405d0671e257cf0ba7aec9f16c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141732
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e55962e5d07e425560592b016baff4964436be0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f452d1d8432a93eb41d5d0f90c2e0b5947e0e53
          - tdf#146950 Clarify slide format "screen" and "on-screen show"
            
            + refactor page/slide format Help pages for slides and drawings
            + drop 2 now useless pages
            
            Change-Id: If98458246f106da509d72a4087f365dbefd08607
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142493
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [4c0e5d0be02ba25be0e8b4748fbf0060491de93c]

        lok: masterpage: introduce EditMode setter and getter for ViewShell
        
        Change-Id: I74d3307aab8fc038bd2409b5f10a2d08db885223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138957
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142472
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-09  Kevin Suo  <suokunlong@126.com>  [875c27dc7975de9b007a215fe1d6f171b4ef090e]

        tdf#151544: Page grid: ruby height should be zero when not in square page mode
        
        Ruby height is used to show the ruby line in square page mode only (e.g. to show the
        Pinyin etc above or below base line). When not in square page mode (i.e., when in
        normal mode), the ruby height should be zero.
        
        The code was trying to set the ruby height to zero by using the following:
            m_xRubySizeMF->set_value(0, FieldUnit::TWIP);
        and then pass this to aGridItem.SetRubyHeight in SwTextGridPage::PutGridItem.
        However, there seems to be always a conversion loss, thus each line will have a tiny
        ruby height, which makes the vertical space not enough to hold the desired number
        of lines on the page.
        
        Fix this by setting ruby height to zero directly in SwTextGridPage::PutGridItem if
        we are not in square page mode.
        
        Change-Id: I24a74b96c12eb58e46e163e2a9c73b540023ab39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142243
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [789872ad1b5916cc5b5abebe5221e80f77725445]

        CppunitTest_vcl_pdfexport: inherit from UnoApiTest
        
        Change-Id: I165295609a95e6dd03ae5e35f987b2defa18ff18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142496
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [87dce617eb1cbbb650dda3e5dc557fa0a058e505]

        UnoApiTest: factor out common code
        
        Change-Id: I1d84d8c1e371016a4f4f068af1e9c76635f28cf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142490
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-09  Alain Romedenne  <alain.romedenne@libreoffice.org>  [7f8b79c21c3af20e443d487af0d40a36e611bda0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b13eb126bfcc3ec1ececf01d5196d26fcc14e1c2
          - Basic typo
            
            Change-Id: I8fb221c1af3a3be26cb30f85fcb9732b2e03bcd8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142446
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-09  Alain Romedenne  <alain.romedenne@libreoffice.org>  [05f0dc93252b060fe5334ed6aa64f1f110336793]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cf59121b3e70ffcc53436cb4d1071428d4daa391
          - tdf114263 DoEvents new help page
            
            Change-Id: I4a031759aa48df9230e4019740a94ca167519792
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141920
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-09  Julien Nabet  <serval2412@yahoo.fr>  [a0dec4bc9a48b263be182ad7bbe4ba3f8cbb27e1]

        tdf#151929: crash if video card changed (Win nVidia GTX 670)
        
        Change-Id: I9566487ed8353674d623cd270c85edcdbfa263b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142486
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-09  Miklos Vajna  <vmiklos@collabora.com>  [a828e6adbb334282b8405a42f20826f5924c58a2]

        sfx2: fix user-after-free in SfxObjectShell::ExecFile_Impl()
        
        This happened even with an empty Writer document, on File -> Export As
        -> Export Directly as PDF, since commit
        1e007e8f1703851b01c68884e87c906f6bae5a5e (sw: fix merge mail to direct
        export as pdf, 2022-10-18).
        
        The problem is that SfxObjectShell::ExecFile_Impl() gets a SfxBoolItem*
        returned by GetSlotState(), and then uses it before and after calling
        SfxStoringHelper::GUIStoreModel(). But as part of opening the file
        picker for save, ModelData_Impl::OutputFileDialog() indirectly calls
        Dialog::Execute(), which starts to process user events on the main loop,
        which leads to SfxItemDisruptor_Impl::Delete(), which deletes that
        SfxBoolItem*.
        
        Fix the problem by storing the bool value on the stack in
        SfxObjectShell::ExecFile_Impl(), and work with that after our
        SfxBoolItem* is gone.
        
        The "freed by" backtrace from asan is cut quite early in the gtk3 case.
        The "gen" case is more helpful, though it's still cut at frame 29.
        
        Change-Id: Ib97c7df7c1289730dec478eede3d620f3a33ace8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142492
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-09  Miklos Vajna  <vmiklos@collabora.com>  [56db6406b0b63a2d2d99024e7c311ebd874f3893]

        sw content controls: allow no list items in a dropdown
        
        - Replace SwContentControl::HasListItems(), which assumed that the type
          is dropdown if we have list items. This is not valid, it's OK to have
          a dropdown with no list items. Add a GetDropDown() instead to check
          for the type, explicitly.
        
        - UNO API sets the dropdown bit when list items are set and the type is
          not expilcitly combo box or drop down, to keep backwards
          compatibility with existing documents.
        
        - No change to the edit shell, SwDropDownContentControlButton already
          checked if items are empty and used STR_DROP_DOWN_EMPTY_LIST in that
          case, but that was dead code previously.
        
        - ODT & DOCX filters are now updated, ODF has a new
          <loext:content-control loext:dropdown="..."> attribute to specify that
          the type is a dropdown, explicitly.
        
        Change-Id: Id577ba9639151549a8f953aab31685a73a898504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142491
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-09  Caolán McNamara  <caolanm@redhat.com>  [cb8a05bfccf77d5217f4f2e20b5898d6a24f990d]

        Related: tdf#151898 set origin for implLoadRepositoryImage XGraphics
        
        like we do when we get one from Image so we can treat these with the
        same shortcuts we do for Image to have the option to pass the
        underlying svg data to the final widget it ends up in
        
        Change-Id: I13a5aecc73821e88f1958e1e1e9e7322628cce6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  Caolán McNamara  <caolanm@redhat.com>  [b2cde58886c8a08fe240f74af6c4f257c15d2835]

        don't need to ctor and assign, just ctor
        
        Change-Id: I0ad410205350c7d035c8e645f00344d3e5641def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  László Németh  <nemeth@numbertext.org>  [94bf4908a6661101c270ef647e33dde09f16ac08]

        tdf#148799 DOCX import: fix invalid formulas with comma
        
        Writer formulas must contain decimal points instead of commas,
        otherwise automatic update of the formulas, e.g. moving text
        cursor in the table, results ** Expression is faulty ** instead
        of the recalculated value. The only way to get standard
        Writer formulas is to replace the commas with points in numbers
        in writerfilter.
        
        Note: only formula cells support comma localization,
        but not formula fields yet, so the recalculated values show
        decimal point instead of decimal comma.
        
        Follow-up to commit 1abf4e6d07ca0ac31bc54f812df84efc82d2af1b
        "DOCX import: don't throw away cached value of SwHiddenTextField ...",
        see also tdf#136106.
        
        Change-Id: Id5e6dc2b87afc4e8fda0d5c4347ba7942a8989b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142488
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [aa8a8b36b73304431bacd7ed0f8803de8dfffe3e]

        tdf#151519 Make ticks in ruler visible again
        
        As reported by the user, the ticks in the ruler are no longer visible. This patch draws them using the shadow color.
        
        Tested with: gen, gtk3 and kf5
        
        Change-Id: Ie80255544b88adfc331fac1365ce381dd90187cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141407
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [2c8a760a18501acaa6e4ff2a2dee76b0bad275f1]

        tdf#150494 LanguageTool: Add placeholder text with default value info
        
        With this patch, the Language Tool dialog works as follows:
        
        - The first time the tool is enabled, a default URL is entered as text
        
        - If the URL is left empty, a placeholder text is shown saying that leaving this entry empty will cause the default URL to be used
        
        - If another URL is defined by the user, than this is the one used
        
        Change-Id: Id31fca0e44091aff3c77a9be8b639a20437b1b7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142197
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-09  Paris Oplopoios  <paris.oplopoios@collabora.com>  [95cb9a01bfacf7d9f03194b0710ca3c249bb62fb]

        Get ScViewData through the current doc shell in headless mode
        
        When using --convert-to, ScDocShell::GetViewData() would return nullptr
        so we now get the ScViewData through an alternative route.
        
        Change-Id: Ie71a4a1077b3c63c0aadd394fc0d966e679e8803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142480
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2022-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f6fd2bc9157c1f72ff04507986aee75ff6a1969]

        CppunitTest_filter_pdf: inherit from UnoApiTest
        
        Change-Id: I9c1565a68393ed775c42e2e972f9c54475e6bd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142487
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [ef7afe7859af21f3e851fefa4448de4c8df77805]

        jsdialog: send edit  widget's type information
        
        Change-Id: I878603e18c2c0ac8b1e9a9ff7995b6c640e455b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141619
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142471
        Tested-by: Jenkins

2022-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [2c700bfaa646fea37f55d7873bce9e35940b1abc]

        lok: masterpage: don't render text edits from different mode
        
        In Impress we can have 2 different EditMode : Page and MasterPage.
        Don't render text edits from other views in Page mode on Master Page.
        
        Change-Id: I62341941215165281d2663af3d3b7cca034762a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138803
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142470
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-11-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8d8d2017de6b2de503ff1e386740d940cd29ee5a]

        Remove duplicated include
        
        Change-Id: Ie7fbf28b70bfaa8ca45eb5cdc57db183f3217858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142479
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-09  Jan Holesovsky  <kendy@collabora.com>  [e50cffea75456551382445c28fdd4cabd9c2e81b]

        Clarify the cairo warning in ./configure
        
        To know what to expect.
        
        Change-Id: Ia660a1ebdbb76c04aa96934cabc16e1cbfc4cfd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142478
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2022-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ff2ee082c5de428d3426005023e7362cb75200d]

        give main thread on Windows a name
        
        to make it easier to find in profilers and debuggers
        
        Change-Id: I8ce3ee0b89ca8498683367c2b39176edc571137b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-09  Caolán McNamara  <caolanm@redhat.com>  [6da092245a0c61223c8fd0d4b2bd183ae3342a55]

        ofz#53154 Timeout
        
        Change-Id: Ibfd62447eb544f243b9917e20049ca1d06fbb0f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  Caolán McNamara  <caolanm@redhat.com>  [d39303f7ea696d36c4ab65286d4b7d8d1bb9069a]

        Resolves: tdf#148884 impress slideshow uses white text on white in dark mode
        
        In dark mode impress's auto text color assumes it will render against
        the DOCCOLOR by default, so leaving this as white gives white on white,
        this looks the simplest approach, propogate DOCCOLOR as the default
        slideshow background instead of reformatting to render onto a white
        slideshow
        
        Change-Id: Id484e14ce96fd05cb16a35586d83e37b36933c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142464
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [4170b94c443b3bd68b4cc75b8c344ecca3c249b0]

        SwModelTestBase: inherit from UnoApiXmlTest
        
        it seems setUp/tearDown can also go as well.
        See the discussion in gerrit.
        
        Change-Id: I5e81dcdcb2e070eb4beb737f3cb25c86cb9d042b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142465
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-09  Caolán McNamara  <caolanm@redhat.com>  [d1e02f58a211111dd745a54ae93114a56cfdda0c]

        ofz#53151 Abrt
        
        Change-Id: I2ccc6cbee28da9f91698b470449fb76b7729f634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-09  xuenhua  <xuenhua2008@sina.com>  [a5f5846fcfe6c9b1f39e753a9d3bad49f34c22a9]

        Keep support for iOS SDK version 15.6
        
        Change-Id: Ia58c9525a3e00cf9dab53b90128e72026a17679e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142469
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2022-11-09  Miklos Vajna  <vmiklos@collabora.com>  [3df3488014dc5f80756c24f584bb554845f4a2df]

        vcl: fix crash in Window::LeaveWait()
        
        Crashreport signature:
        
        SIG   Fatal signal received: SIGSEGV code: 128 for address: 0x0
        program/libmergedlo.so
                vcl::Window::LeaveWait()
                        vcl/source/window/mouse.cxx:640
        program/../program/libsclo.so
                ScSpellingEngine::ShowTableWrapDialog()
                        sc/source/ui/view/spelleng.cxx:315
        program/libsclo.so
                ScConversionEngineBase::FindNextConversionCell()
                        sc/source/ui/view/spelleng.cxx:168
        program/../program/libsclo.so
                ScSpellDialogChildWindow::GetNextWrongSentence(bool)
                        /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
        
        Seeing that e.g. Window::GetDropTarget() also handles a disposed
        vcl::Window, let's do the same here.
        
        Change-Id: Ia4ad312ae91dfef24266c5bd45751778acbee367
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142473
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [dd18bd455d5aa3cbfbf794c718ef60c1cf02a4e7]

        SwModelTestBase: remove more duplicated code
        
        Change-Id: Idf29e7202e777c1fe673f6fdc4f70ff1c2b3b469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142466
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-09  Jim Raykowski  <raykowj@gmail.com>  [ace75043781b5fe36546ec75574a14617f4feb30]

        tdf#139633 SdNavigator: Enhancement to rename pages and objects
        
        This enhancement adds a context popup menu to the Navigator tree that
        has menu entry 'Rename...'. Renaming is done by direct editing in the
        tree.
        
        Change-Id: I392ea839110b942e1a336748c896d33ee5ece9b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141801
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-09  Miklos Vajna  <vmiklos@collabora.com>  [a5e416712e9477c496ce5fd4d935133083330ddf]

        CppunitTest_sw_ww8export4: remove not needed mustTestImportOf()
        
        Input was always DOC, so no need to filter out non-DOC. And if there
        will be a non-DOC, we can use CPPUNIT_TEST_FIXTURE().
        
        Change-Id: I74d20b750e1ebe3449f1454b8772fae691bf78e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142467
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-08  Harshita Nag  <nagharshita16@gmail.com>  [ddb8a1a282aae74c1cee3a5e1f446abd0c00b116]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I8a91edb86edd76b70648507f12b18d9e923ab16e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141774
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [0c79a2df8bf3e07933e9dd399bd88e0f0428dee3]

        swmodeltestbase: Do not use a default parameter in parseExport
        
        For better readibility and to help to remove duplicated code
        in following commits
        
        Change-Id: I90745c54492544757e2174412bbb2f16d422a89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142463
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [2e97f7596c2d933e87391a5648341f885975c51b]

        tdf#122188 border colors should be the same regardless of the desktop theme
        
        Change-Id: Ifc0297135981b315ce8646e0ca2fe8a899d49f32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142423
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-11-08  Miklos Vajna  <vmiklos@collabora.com>  [a8448ded5555947925b0e9ddb4aeea7043f03933]

        sw: introduce an UNO manager for content controls
        
        This builds on top of commit ad950f10dc382ea169f94a0c301ca8c424e7103e
        (sw: introduce a manager for content controls, 2022-11-08) and exposes
        it on the UNO API:
        
        - add a new css.text.ContentControls service, backed by SwContentControlManager
        
        - add a new css.text.XContentControlsSupplier interface, implemented by
          SwXTextDocument
        
        - implement XIndexAccess in ContentControls
        
        This allows UNO (and later VBA) clients to have random access to the
        content controls in a document, which is much easier than the relatively
        complex traversal of the whole doc model.
        
        Change-Id: I26240c9ddbd06f4f57f5f65460ef75a2ace94825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142454
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [46875d83476942ca215429c837a3457f55c3ccb0]

        A better fix for C++23 P2266R1
        
        After 6d6a143913603b040c10a5db83c2103557899011 "Address some of the sprintf in
        vcl/source/fontsubset/cff.cxx", --with-latest-c++ builds that pick up a C++23
        compiler that implements
        <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1:
        Simpler implicit move" started to fail with something like
        
        > vcl/source/fontsubset/cff.cxx:2061:16: error: no viable conversion from returned value of type 'char[64]' to function return type 'OString'
        >         return aDefaultGlyphName;
        >                ^~~~~~~~~~~~~~~~~
        [...]
        > include/rtl/string.hxx:313:5: note: candidate constructor [with T = char[64]] not viable: expects an lvalue for 1st argument
        >     OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() )
        >     ^
        
        etc.  So I figured there should be something better than
        433ab39b2175bdadb4916373cd2dc8e1aabc08a5 "Adapt implicit OString return value
        construction to C++23 P2266R1" (which this commit reverts, modulo its conflicts
        in comphelper/source/xml/xmltools.cxx and
        sc/source/filter/xcl97/XclExpChangeTrack.cxx) to address the underlying issue in
        a way that keeps code that works up to C++20 also working in C++23.
        
        (The fix is only relevant for non-explicit constructors that involve
        NonConstCharArrayDetector and non-const lvalue references, not for other
        functions involving those.  OUString has a similar constructor but which is
        explicit, and OUStringBuffer doesn't have any similar constructors at all, so
        this only affects OString and OStringBuffer constructors.)
        
        Change-Id: I31cf16b9507899f5999243f8467dfa24bc94c5ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142455
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d26b851f27a55cd8cb34973b0ad8d7a3801af7e]

        swmodeltestbase: remove duplicated code
        
        Change-Id: Icc577cc50248cc8310262a09af5769faea1662b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142460
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [5f9cd841a22fa7eb6f29ca8b9a35a8b016fb3d56]

        tdf#144587 Fix lines in treelists using dark mode
        
        As reported by the user, the lines in a treelist are dark over a dark background. This patch fixes that.
        
        Tested with kf5, gen and gtk3.
        
        Change-Id: I7f1a206f4adba496d312b25a9db121df317c7c84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141315
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [a6ec150a2ef80697aa724555ed1227fb0da382ca]

        ofz#47699 avoid Timeout
        
        Change-Id: I15d490cb6beb585cf6d38abca8ffe6736315a3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142459
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [012875da5bb23e2c90e9cb6132c4b36a7f56648a]

        Add missing dependency
        
        Without this, running `make CppunitTest_sw_core_draw` after
        `make clean` will stop at "GpgME not installed correctly" dialog,
        because DocumentSignatureManager::init will try to initialize GPG
        security context, which requires gpgme-w32spawn.exe to be present
        in workdir/LinkTarget/Executable.
        
        Interestingly, in case of this specific test, it passes OK after
        dismissing the dialog; so arguably a better fix would be to change
        a test document to avoid DocumentSignatureManager initialization;
        but I opted for a simpler workaround.
        
        See also commit 0de0b8c9d80d68619b6f3c0e8d9429d8b08553fb.
        
        Change-Id: If1e326733568d6b262d28308bc9bc04078084170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142458
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [20724e2cf2d1b1456fcc583f722ee553767a1840]

        Related: ofz#47699 ludicrous font height
        
        Change-Id: Ief06eda35445d403c163a59038c694138465f698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Paris Oplopoios  <paris.oplopoios@collabora.com>  [1230b88055c7389d2c376c316f91549e4aaef8aa]

        Make EMR_SAVEDC not UpdateClipRegion
        
        EMR_SAVEDC would call UpdateClipRegion which would break the clip region
        sometimes before drawing the text causing it to not be clipped
        
        This line was introduced in a i#964 related patch
        (https://bz.apache.org/ooo/show_bug.cgi?id=964)
        The document in that test seems to render the same and the test file
        from the changed test renders the same also before and after this patch
        
        Change-Id: Id515b90efc9e533e18a35030a9a677de4d4ea02d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142272
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-08  xuenhua  <xuenhua2008@sina.com>  [363d45244b2ba3f666e50255f77900d3849e51d2]

        Update iOS SDK Current Version to 16.1
        
        Change-Id: I118095b706077fd95b81e0cd1278559417805355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142316
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [8953fe0aaebcc5e6aea8eafcf7612f49b4479911]

        SwModelTestBase: make clear parseExport only works when exporting
        
        Change-Id: I04d8b170b68479fb5c48e1cdd078baffaee604ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142432
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [000a05339b4d7d25aea063a16b7a01ca9080978f]

        Resolves: tdf#148140 get text auto color right in impress edit mode
        
        Change-Id: I2695c86e9b749a4c38920af6d33e8e89f8ea3c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142426
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [a879fd3c9c0aa3d5414fcac99431b2681959c7ba]

        CppunitTest_writerperfect_epubexport: inherit from UnoApiXmlTest
        
        Change-Id: Id5e78e15155807100771e2e578c028729d3b4fb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142413
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [a08ae2b5d06a49fa69f1282d1dddc45d1d5bd919]

        Combine o3tl::RestoreGuard into comphelper::ValueRestorationGuard
        
        Change-Id: Iec42b3bf348ba82a98d4ad8236a9e8b95fdfe5f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142422
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [f295af7dfe6c91e00e7fb64f82de7dbba4bb0dc1]

        Simplify some Python version comparisons a bit
        
        Change-Id: Ic1b475f4bc443a9f6e79c7c5ef36496dcf602a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142418
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [248be1fe7d31499fe7e237bb15ec67b55962c1a7]

        UnoApiTest: simplify code by using tempfile member
        
        SwModelTestBase does the same. this will help to make
        SwModelTestBase inherit from UnoApiTest
        
        Change-Id: If1c824cf92f0e8b70253e4d5fdeddcaa521d4632
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142287
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [444bf8710d5da7b584fbcb94693e4ed8d2e29297]

        Update handling of AntiAliasing settings and processor2d
        
        Currently SvtOptionsDrawinglayer::IsAntiAliasing() is used
        in the constructor of the VCL based processor2Ds to decide
        if AA is to be used or not. Using this inside the
        constructors makes it currently impossible to use a
        primitive renderer independent from these settings,
        except when changing these settings temporarily what
        may influence other renderings and is a hack.
        
        The setting SvtOptionsDrawinglayer::IsAntiAliasing() is
        intended to decide if LO shall use AA mode from user's
        perspective, this means for the EditViews of the Apps
        and some other occasions (previews, exports, conversions
        to bitmap, ...).
        
        This works currently since all visualizations for these
        purposes use newly constructed primitive renderers. But
        there is no way to use primitive renderers independent
        from that setting. For future renderers which might be
        used for other purposes this is not sufficient, there
        has to be a method to create a renderer using e.g. AA
        independent of the global setting.
        
        To allow that, move the deciding flag to the already
        used geometry::ViewInformation2D. To not change anything
        initially, use the global flag for now to init that
        default value at ViewInformation2D.
        
        I took the opportunity to adapt ViewInformation2D to
        no longer being read-only and not changeable, it uses
        internally an impl class based on cow_wrapper already
        anyways. Extending this would lead to the constructors
        getting even bigger, when usually only 1-3 values
        need to be changed and many usages want to copy an
        existing instance and modify it. Adapted that usages
        to a much smaller footprint.
        
        Up to this point this does not change anything, but
        move the usage of the SvtOptionsDrawinglayer to the
        defaults (constructors) of the involved class
        ViewInformation2D. Using this then in the primitive
        rederers should be safe and will allow to use a
        primitive renderer with or without AntiAliasing
        independent of the user setting, so also for non-
        EditView usages.
        
        Also already added the PixelSnapHairline setting, this
        will also be needed independent of user settings to
        have full freedom of usage.
        
        Unfortunately I cannot use SvtOptionsDrawinglayer
        methods
            ::IsAntiAliasing() or
            ::IsSnapHorVerLinesToDiscrete
        inside ViewInformation2D where I would need it. It's
        now in drawinglayercore and thus not linked against
        svtools (svt) anymore.
        Thus I have to do some forwarding mechanisms to get
        the correct values available in ViewInformation2D.
        Not nice, caused by creating drawinglayercore...
        
        Change-Id: I9f572ce67e5d86a242188bdc6d4ba7c9a12f6a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142393
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-08  Paris Oplopoios  <paris.oplopoios@collabora.com>  [b9eaed7a4c484dde0b5c61b34b4beb60a101f661]

        tdf#151844 Make EMR_EXTSELECTCLIPRGN factor in WinOrg coordinates
        
        EMR_EXTSELECTCLIPRGN would not factor in WinOrg coordinates which would
        give the clip box wrong coordinates causing some graphics to look
        chopped in the wrong way.
        
        Change-Id: I4f9a1b1c27fc276d188d0d865991795dab48dce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142110
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-08  Bogdan B  <buzea.bogdan@libreoffice.org>  [3c4ee1f180aed4bc09cf8dab2a1101feb0d95fa6]

        tdf#131688 Improve one tip of the day
        
        Change-Id: I5f8796bd1cae65a2259a9695321f94cd24188eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142301
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [2cda8f1bdcfdc5f47b9ad429588ad36bd2661eaf]

        Address some of the sprintf in vcl/source/fontsubset/cff.cxx
        
        ...(which cause -Werror,-Wdeprecated-declarations with macOS 13 SDK), by turning
        Type1Emitter::maBuffer into an OStringBuffer
        
        Change-Id: I4207290c103f8aa99644d23d04a072f5241360bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142416
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Julien Nabet  <serval2412@yahoo.fr>  [f627ac6a579b56876ba6b2cc2325e6166a25d07d]

        tdf#151944: error colour export in bmp
        
        4 bits bmp support has been dropped in March 2021 with:
        a6c6f35ccc78e74cfa76397d649c1b6fc4baad29
        "drop 4bpp image formats
        
        on a path to simplifying our internal bitmap stuff, aiming to
        support a smaller set of image formats, but support them
        in an accelerated fashion.
        "
        
        1 bit dithered bmp support last remnant has been dropped in April 2020 with:
        e3cc7b94b13d6cc4e044cfd688e0fcc9dca63987
        "loplugin:unusedenumconstants BmpConversion"
        
        Change-Id: I958bea6baabb9ef21c5fa71bfc7ff96cba201245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142375
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-08  andreas kainz  <kainz.a@gmail.com>  [0f0fd9c6e35a86f03606361211067c7887c3e0fc]

        tdf#148017 harmonize sidebar .ui files for chart2
        
        Change-Id: Iaacee42c23878b9f03623eec36a5f3a10051f926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141949
        Tested-by: Jenkins
        Reviewed-by: Pedro Silva <pedro.silva@collabora.com>

2022-11-08  Miklos Vajna  <vmiklos@collabora.com>  [ad950f10dc382ea169f94a0c301ca8c424e7103e]

        sw: introduce a manager for content controls
        
        The VBA API for content controls can access e.g. the 3rd content control
        in the document, see
        <https://learn.microsoft.com/en-us/office/vba/api/word.contentcontrols>.
        To support something similar, first we need to track the content
        controls in the document, otherwise getting the Nth element of that list
        would require scanning the entire document, which would be slow.
        
        SwContentControlManager::m_aContentControls is a plain vector, because
        an o3tl::sorted_vector would require sorting at insert time, but our
        content controls are typically first created and only later inserted,
        and we want to use the insert position as the comparison key when
        sorting.
        
        This just keeps track of content controls (visible in the doc model XML
        dump), somewhat similar to sw::MetaFieldManager or SwFootnoteIdxs.
        
        UNO API to actually expose this is not yet added.
        
        Change-Id: I3f75334ffef684afc2c05a1bbdb7f247876d27ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142391
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [6d6a143913603b040c10a5db83c2103557899011]

        Address some of the sprintf in vcl/source/fontsubset/cff.cxx
        
        ...(which cause -Werror,-Wdeprecated-declarations with macOS 13 SDK), by making
        CffSubsetterContext::getString, and in turn CffSubsetterContext::getGlyphName,
        return OString.  Which in turn required adding rtl::OStringConstExpr and
        OString::unacquired counterparts of rtl/ustring.hxx functionality to
        rtl/string.hxx.
        
        (It's not quite clear to me whether the nMaxLen clipping in
        CffSubsetterContext::getString was only there to avoid overflow of the--
        somewhat arbitrarily sized?---static aNameBuf, so could go now, or rather served
        as a more general safety measure to not read past the mpReadPtr buffer end and
        should thus remain.  Hence, I added a TODO comment for now.)
        
        Change-Id: I473d5a54a4be5b02917e197391e4f0982dcf690c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142412
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [c4fc1dda75fe7aefce50d77ad05319cd143e6e25]

        Resolves: tdf#150273 use same bg as valueset
        
        Change-Id: Idbe4bf6eaad64fdd0865a2734b4c9d0221801df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142401
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [1ebb9355a5ffcefdb14dfd54258aeda97d0369c1]

        Related: tdf#150273 maPaintCol is unused now
        
        Change-Id: I823a2ec24aea47b4b3d005107c8a18fec223e6df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [1e0b50c17b80146e4840994703369bae904b2207]

        Related: tdf#150273 just take the color direct from the current entry
        
        no need for the indirection, which is out by one anyway, perhaps
        from some time that the "none" entry was in the list vs a separate
        widget as it is now
        
        Change-Id: I028e03260f500473b42847ee748d7af8a4791ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142397
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [a4c8f05c760328177bb6056750aab53432a3a506]

        Resolves: tdf#150007 add suggested-action to "find next"
        
        Change-Id: I0a9a37891319d11958859c43b2121283d2ca8b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [f0109f8f8cbdedd01849ac2f7eeb61056a8f57ea]

        clang-format: clean up exclude list
        
        Change-Id: Id3ba36a18cf9ced58568021545bb74c92e0238e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Kevin Suo  <suokunlong@126.com>  [c2e2997f452b93b400d541c2d0b2ee396a889007]

        sdext.pdfimport - Wirter: add handling for continuous space characters
        
        This was done for Draw in sdext/source/pdfimport/tree/drawtreevisiting.cxx,
        but was not done for Writer. Without this, continuous spaces in PDF will
        show only one space on pdfimport using the Writer pdfimport filter.
        
        Change-Id: I2279d9b1750e07f5743aeba80a3fd553bc037d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-08  Miklos Vajna  <vmiklos@collabora.com>  [34c7d169a248578d953661217144f2dda9831cb4]

        Update libxmlsec to 1.2.36
        
        - remove the fix-size_max-412.patch.1 and
          remove-unnecessary-macro-417.patch.1 backports
        - drop old-nss.patch.1, which is now upstream
        
        Change-Id: I4b668d4949d8831cffbe87ac6b16a20ba8698128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142395
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [24c49a6e2b9f2609b060d87a4a3253803c62cc5a]

        swmodeltestbase: make mbExported private
        
        Change-Id: Idff0960c05f2330ce746147f0b3a2e0aa3b7c6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142410
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [cf1cd2659f08f7c16a6f32142d424b8df9fab393]

        swmodeltestbase: remove duplicated method
        
        save needs to set mbExported to true, otherwise
        parseExport returns nullptr
        Change-Id: I1ba779e0ac0f20663fb722df16210ca144717479
        
        Change-Id: I330abdc72226d5ac7b4d6747bdcc48cedfc9e90f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142400
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [c8eaebecd3af29c031c26142c9d3f7d7abf75b0d]

        Avoid an explicit static_cast
        
        ...when shoehorning a std::size_t value into sal_Int32, to not suppress
        potential warnings from tools like -fsanitize=implicit-signed-integer-truncation
        and -fsanitize=implicit-integer-sign-change
        
        Change-Id: I610410f7cd69769c3721b2019e16b4c9f214ad81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142407
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [1ec337b100755f7ad8cd5cb2c8acb072c6f18964]

        Remove some trailing whitespace noise
        
        ...from ustring.hxx, in preparation of using its OUStringConstExpr as a
        blueprint for a corresponding OStringConstExpr in string.hxx
        
        Change-Id: I3bf89133e9308dd56e2041a2a5ebb68145fdd0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142406
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [e0dca3d96cdbbc265f5014b4b9344740c6a72cf3]

        Fix string comparisons
        
        As discussed in the comments at
        <https://gerrit.libreoffice.org/c/core/+/139908/4#message-cf9911a7e4464d53d8ef852ad0c03e609dd4ac88>
        "tdf#123234: Fix subsetting CFF deprecated endchar", this probably happened to
        work most of the time "because pGlyphName presumably /does/ point at elements of
        the pStringIds array (or the ".notdef" literal near the top of
        CffSubsetterContext:getGlyphName body), and compilers generally /do/ deduplicate
        string literals at least per TU."  But at least the "sterling" literal in
        pStandardEncoding does not have a matching literal in pStringIds, so that could
        never have matched pGlyphName via ==.
        
        Change-Id: I7e82cf709f02d426da9c6097e596bbd92b5d4d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142405
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [2469c623d7985e9e5db54ed8f96df02219def74d]

        Introduce o3tl::RestoreGuard
        
        Change-Id: Ic0c1a73668e990c91ef6e90e8c01e669761fe356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142403
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [7f8bca6b9144cf820aaeae0fe9a15c6becfd1ddc]

        Revert "give main thread a name"
        
        This reverts commit 4668bfe4f64acfb17da5efbb759407664b407d81.  As it called
        osl_setThreadName on the main thread, it caused tools like pstree on Linux to
        confusingly report soffice.bin as VCL Main instead.
        
        Change-Id: I19447059d2ce105acb0b6fd487c7b2234172b988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142402
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Stephan Bergmann  <sbergman@redhat.com>  [bd63364abe775d1e71ad93fb69b577f019c3a257]

        CffSubsetterContext::getString never returns null
        
        Change-Id: I57e59b7659a9da2b291e8d6876617990f9e3a530
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142404
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-08  Balazs Varga  <balazs.varga.extern@allotropia.de>  [b57307e8f3553fcb292c9c11fcf58bcef3a6cb3c]

        Related: tdf#124098: sc import, more optimization for row heights
        
        follow-up for: e8fae4d0fb2994a7b4ac00e9da35e1deccb296dd
        (tdf#124098: sc, ods import: do not recalculate row heights)
        
        Change-Id: Id80c0c6bfbc437f8b2a480c590e407e84b5d7b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142376
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-11-08  Caolán McNamara  <caolanm@redhat.com>  [f8ad054de38a6592b60ab850e938e6e81ec4cc0d]

        tdf#151610 chart colors should be the same regardless of the desktop theme
        
        Change-Id: I47ae80f744401bd13452ec8879cb8f420e35b9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142383
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-11-07  Justin Luth  <jluth@mail.com>  [e6bc90aa8a959e08abf4b5c10d793ff9a549efe4]

        tdf#112641 sc: always allow freezing at cell A1
        
        For some good reasons, freezing rows and columns
        doesn't work unless that cell is currently visible,
        and that is almost guaranteed anyway since the
        hisorical way of doing it was at the cursor.
        
        However, since LO 5.2 there are menu and UNO commands
        to freeze the first row and the first column.
        It would be nice if these would work regardless
        of where you are in the spreadsheet
        (and keep you at that position too).
        
        [If there is already a SPLIT (not freeze),
         then the bottom right quadrant is still
         the "position" that is maintained.]
        
        [This "works" if the first row/column is hidden.
         When unhidden, the freeze will be in effect.
         I assume that is reasonable and doesn't need
         to be avoided for any reason.]
        
        Change-Id: Iddc5d63adaad7ecfe6b5fb9b60ff3ec6274b0756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142128
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-11-07  Andras Timar  <andras.timar@collabora.com>  [cbfac11330882c7d0a817b6c37a08b2ace2b66f4]

        Send build config (configure options) in LOKit version info JSON
        
        Change-Id: I29a6cca467e5f1e9ba59528edefbb397ceb81780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141197
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141494
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-11-07  Bogdan B  <buzea.bogdan@libreoffice.org>  [ff5783bf669c1ee0832e3b6f57b96f015d029ae9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e8131128326f9a2f8476bf3b72f9a7b45476750
          - tdf#150369 IsMissing Function explanation
            
            Change-Id: I10a25151109d4048fdbf8eca596f0f1e334092a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142300
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-07  Caolán McNamara  <caolanm@redhat.com>  [495922fd4ac07d4b7c16127b222f1d06a2718399]

        use ResolutionIndependentLayout if there is any MapMode set on the device
        
        Change-Id: Ib9b0589d244c087e08638597692d679e9194c4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142292
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f25551df39c0272f19250e41969e819d9941cdb]

        sc: factor out common code in make files
        
        I had to rename some .cxx files to follow the same patterns.
        The renaming cause clang-format to be triggered for
        those files
        
        CppunitTest_sc_functionlistobj fails with
        
        xindexaccess.cxx:26:Assertion
        Test name: sc_apitest::ScFunctionListObj::testGetCount
        equality assertion failed
        - Expected: 395
        - Actual  : 508
        
        if it doesn't use gb_CppunitTest_use_components
        Change-Id: I7c929512bbf05293118bc54b343a59c8bbee5538
        
        Change-Id: I21971773f1e2d4bc7a6f33e4c392b20abf8d54de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142387
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ae372725fedcd688aa3535b243a0c93af33d4689]

        Removed duplicated include
        
        Change-Id: I1b015e76112e5587bf0a349d3034adc6a2118754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142381
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-11-07  László Németh  <nemeth@numbertext.org>  [0d295ee0c34ed505a9673580b40ade3ce6947d99]

        tdf#151658 sw: accept of row deletions with nested tables
        
        Accepting tracked row deletion didn't delete the table row,
        only its row content, if the table row contained cell
        starting nested tables.
        
        Extend SwTableBox::IsEmpty() to detect a table cell as empty,
        if it contains only a cell starting empty table.
        
        Note: Without change tracking, deleting content of a selected
        table cell leaves the cell starting nested table in
        the cell, but deleting row removed the row with nested table,
        too.
        
        Follow-up to commit 6383362999b72160eab6abdfc6ea6bdbd231b100
        "tdf#151657 sw: delete row with nested table in Hide Changes" and
        commit c809867f3ee92a8eb36cbab840bd6d6c5b3b1c26
        "tdf#150976 sw: fix tracked deletion of row with nested table".
        
        Change-Id: I9c9bc3b97653b63e797e1e9dd545809b77a02c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142384
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-07  Caolán McNamara  <caolanm@redhat.com>  [e8d9e0cf6bff43d07749d98e5922ecc8b3cf3ef6]

        cid#1516751 Improper use of negative value
        
        Change-Id: Iab7585018d1c172299fdb78a731f92c75bd2af7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-07  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [429f3d8e3eddedb7ab183b6530220bc7491302e7]

        tdf#144399 Don't allow editing in r/o mode
        
        Fallout from ea9fff260129ccfa4755e96c08432252efbe5621
        
        Change-Id: I0c73d13b79389db13bb04046731bdf18b4cf6005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142382
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-07  Henner Drewes  <henner.drewes@gmail.com>  [801e6272dc299d4468ec094ce11b66494eb5018b]

        tdf#141684 fix disappearance of icons in Groupedbar and Groupedbar compact UI
        
        Change-Id: I3f0e5edd196420c8c51b19cd1ceee8caba7f7fd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141612
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cfd49dc149896925c641181b8d710a32d8ebc2da]

        Fix typos
        
        Change-Id: Ie5df0153446e6af1c717c74dba722ac2aea2b738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142379
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-07  Miklos Vajna  <vmiklos@collabora.com>  [deba3bdc70bae4297b26f67a2d5581a9f822debf]

        sw: make fmtmeta.hxx self-contained
        
        sw/inc/fmtmeta.hxx:134:5: error: use of undeclared identifier 'unotools'
            unotools::WeakReference<SwXMeta> m_wXMeta;
            ^
        
        Change-Id: Ia022e96789edcc8b9e589175dc32c6fcea83b119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142369
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [57777d94ca60781342fd8335d152a59c0fff89f0]

        Fix typo
        
        Change-Id: I60b186f26db8f36ea815161e6b450c16377e537b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142380
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-07  László Németh  <nemeth@numbertext.org>  [0a93f33a2ec5bdbda446d35dfbeca1b7b8a3b8cb]

        xmloff: write transliteration-spellout only in extended ODF
        
        Follow-up to commit 7c20c3c2a9fc85c66dad9d09908b257beeedd78d
        "xmloff: ODF export: adapt all checks of ODFSVER_012 etc.".
        
        Reported by Eike Rathke.
        
        See also b7d53247eb2fab04f5f6d82d405f1ac0c73542b2
        "tdf#115007 i18npool: add NatNum12 formats to locales" and
        2a1d2d42af7f365330479f4032ddfdd9eeba7c1d
        "tdf#115007 add NatNum12 number format list items, fix title case".
        
        Change-Id: Idb25a37ffcad0a0fb05276b972561abf929cd81b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142373
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [24122c202149761121ffde6788d1b28b6f3ca8f1]

        tdf#148719 Moving caption frame & undoing is shrinking caption frame
        
        So the problem here is that when we call SwDoc::FindFormatByName we can
        have the situation that there are two formats with the same name.
        
        Those formats appear to have which ids
           159   RES_DRAWFRMFMT
           156   RES_FLYFRMFMT
        
        Previously, the index was sorted by
           ... which ... name
        
        which meant that the lower-valued which was always been returned.
        
        After my path, the index is sorted by
           ...name....which
        
        The problem is call path is
           sw/source/core/undo/unattr.cxx:252 in SwUndoFormatAttr::GetFormat
        where it calls
           rDoc.GetSpzFrameFormats()->FindFormatByName()
        
        To fix it, use the findByTypeAndName method to explicitly specify which
        which-id we are interested in.
        
        Change-Id: I8941f7c277785afb1940bcf5d2b5153c291b6f97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [548bb942ca1aded0e5fd95230556a67639cad7d7]

        tdf#151061 Fix string inconsistencies in privateuserpage.ui
        
        This patch fixes string inconsistencies pointed out by translators in the bug report.
        
        Change-Id: I6d053f0aa9d6c45477598f8f5903cf0fc40f69f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140168
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [de387e611df7668fb86a409255de6d49eeef3e90]

        tdf#147386 Fix text color in CSV import dialog (dark mode)
        
        If FONTCOLOR is set to Automatic, then check the background color and adjust the font color to Black or White depending whether the background is dark.
        
        Change-Id: I3c277291f8aa3a3e63a050c28c8f17b05f4dbf2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141177
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-07  Caolán McNamara  <caolanm@redhat.com>  [628efead20066f5ec4e3d2bf2bcc9e9513c6d04b]

        Revert recalcuting m_nTextCol when setting a cell editable
        
        Revert: "vcl: allow editing a column other than the first one in GtkInstanceTreeView"
        
        This reverts commit be11a3573a21e83dfb6a473d98bc8ba9bf57057c.
        
        both basctl watchwindow and writer insert bookmark work as expected
        without this.
        
        .git/COMMIT_EDITMSG.save
        
        Revert "vcl: allow editing a column other than the first one in GtkInstanceTreeView"
        
        This reverts commit be11a3573a21e83dfb6a473d98bc8ba9bf57057c.
        
        Change-Id: I3384164ef5634b6695cc7edad7c03a3242195003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142366
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-07  Nalini Prasad Dash  <nnnalinidash@protonmail.com>  [aa5e2b24ebca3b36becf77e466eb1702e1f97301]

        tdf#141908 - CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: Icdf2a5e7c0bd738f2cffbc0b7e99b1bd90a6dcce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141685
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-07  Dr. David Alan Gilbert  <dave@treblig.org>  [503195ad4df320da568fe089b4d0de2f761be660]

        file: Use calloc
        
        Current code does, malloc->memset,  that's what calloc is for.
        
        Change-Id: Ie3a4872249f78442b96f98c9dad9d7170afe784c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142345
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-07  Dr. David Alan Gilbert  <dave@treblig.org>  [0d9613b77fc653c6144b5e4f0136c0536300c0db]

        TempFile: clear handle on close
        
        If we close the file on error, then clear the handle we returned to
        the caller so it doesn't try and close it again or do anything else
        with it.
        
        Change-Id: Idd054f92f4f3cbc3427896ec9795e588471292d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142344
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-07  Dr. David Alan Gilbert  <dave@treblig.org>  [fa40ea19dbea5f0618d86da8626c35e734bb5220]

        TempFile: Initialise handle
        
        If the tempfile creation fails, the handle is left uninitialised
        but we still try and close it, and we explode with various
        pthread locking corruptions.
        
        I think this could be the cause of a bunch of the:
        https://crashreport.libreoffice.org/stats/signature/osl_closeFile
        
        I can trigger it on Linux by setting TMPDIR to a bogus value,
        but I don't think that's all the cases that we see in the crash reports.
        
        Initialising it to null makes the close take a safe path.
        
        Change-Id: If66c5629b6bce62e6c4b18a97ecb901abedd4ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142343
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-07  Miklos Vajna  <vmiklos@collabora.com>  [f18ef67d7ce02ead53a6dc3c2a985d8b51b7afda]

        sw: prefix members of SwCaptionDialog, SwColumnPage, SwFrameAddPage and ...
        
        ... SwGrfExtPage
        
        See tdf#94879 for motivation.
        
        Change-Id: I9ac362d2399db4ec92816bb4e34e4c2740b16eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142365
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-07  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c3549e7857d53af25857ae50ea881cd22737d907]

        tdf#151605 Don't include hidden text by default in HTML filter
        
        Exclude hidden text from HTML filter (and add an option to change the behavior).
        
        Change-Id: I232fda1a283090229b8716532c646bcc6824a7f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141606
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-07  Hossein  <hossein@libreoffice.org>  [acf7a851e87ec993ae828ccbf1bfb25448e88423]

        Revert "tdf#145538 Use range based for loops"
        
        This reverts commit 64469bb1a7383da6e7ff1150d693b3e08f54bc91.
        
        To keep the compatibility with C++98, we need to revert the previous patch.
        
        Quoting sberg:
        "This code happens to not normally be processed (see ure/source/uretest/README)
        and is meant to be compilable with the 3rd-party UNO compiler baselines (i.e.,
        just C++98, which implies no range base for loops)."
        
        Change-Id: I1355a29af24299a99a23dfcd1dd473894d7c9e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142302
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-07  Stephan Bergmann  <sbergman@redhat.com>  [08bb758b150d6d52258b2a4f783e37298bb42373]

        Adapt to llvm-config --src-root dropped from LLVM 16 trunk
        
        ...with
        <https://github.com/llvm/llvm-project/commit/c061892fcdbdfe46884c54a7a7bfe6df54d1df12>
        "[llvm-config] Remove --src-root option", causing
        
        > checking for llvm-config... .../llvm-config
        > usage: llvm-config <OPTION>... [<COMPONENT>...]
        [...]
        > dirname: missing operand
        > Try 'dirname --help' for more information.
        
        noise during configure
        
        Change-Id: I0051dd523a3f4cebfdd8b14d8f2e83ba9e5e959b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142362
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-07  Jim Raykowski  <raykowj@gmail.com>  [b60705c95bda49b656188d6a75557f32cf8a5f14]

        SdNavigator: Make the page objects tree stand still when the entry
        
        selected is already visible (affects tdf#138868 and tdf#129610)
        
        This patch replaces the use of TreeView::scroll_to_row with
        TreeView::set_cursor in SdPageObjsTLV::SelectEntry because the GtkInst
        scroll_to_row always scrolls the entry to the top, when possible, even
        if the entry is already in the visible entries range. SalInst only
        scrolls the entry to the top when it is not in the visible range.
        Commit 3c8e81669f2311dd35aa6787cbf3e5a6a0520433 'tdf#149279 related:
        make gtk treeview scroll_to_row more sal like' made the gtk behavior
        similiar to the sal behavior.
        
        Change-Id: I95aa3555699eb8c8d88bb00ca39d7c3a6589353a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142363
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-07  Mike Kaganski  <mike.kaganski@collabora.com>  [75395e0ccaeae2761a6b58bc36c8a5e32d49566f]

        Use o3tl::convert instead of temporary Fractions
        
        Change-Id: I7e1f68e579e6520d17e0a058e6e0a8056e082c2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142360
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-07  dldld  <LibreOfficeContribution@dldld.de>  [6bc0576f8150ab1cc513c2b37347da43128dcb1c]

        tdf#151608: Follow up comments
        
        added comment about when the informListenerDestroyed method is called.
        
        Which was requested to be done in the following change review: https://gerrit.libreoffice.org/c/core/+/141468
        
        Change-Id: I34558a5c673ff0e392b91a620b9effc00a8b1376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142086
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [c3d2c5056aeaa57ed0254e3ea1faa86ed0cb58c9]

        No point in abbreviating like that in the middle of the sentence
        
        Change-Id: Id2144df2d5a714acc0a1022dccd802ec0a89a559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142364
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-07  Emanuele Goldoni  <emanuele.goldoni@gmail.com>  [09cd68a0a72c1b1f2a75793d7d8bfe2f765fc6e9]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 2ee18117fc1d481e7cc58ebf0d498d761357be82
          - Fix typos in Thesaurus
            
            Change-Id: Id54a4f32468d525e96b66b9d5cd8de9313cb64c7
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/136876
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-11-07  Bogdan B  <buzea.bogdan@libreoffice.org>  [d23adc80fa652a611bc0360408f562adcace739f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b310c2a8fb3c21429a755b318a1b4be31a5496d0
          - tdf#149991 Replace Page with Page Style
            
            Change-Id: I4d7a5178180aa49ca16c569b1c2a90bd248bedc5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142299
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-07  Alain Romedenne  <alain.romedenne@libreoffice.org>  [ad8b0ed7c004dd3b93545904f9081f69ae4ab738]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3568ffd245094b1ee98eab3cb2e0be18646a7aa5
          - tdf141474 Typename, Vartype functions accept keyword arguments
            
            - argument names updated to comply with VBA conventions
            
            Change-Id: I2166e62d6df4e0f72aaa494e96f9a515b03e3ac7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141919
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-07  Tor Lillqvist  <tml@collabora.com>  [07d303b74108debc9e2b9855a49d69bf156a91a9]

        Match conditionals in dictionaries/Module_dictionaries.mk
        
        Change-Id: Ia80af0e949c160718cf815630d383bf7c36e5b00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142071
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [a807a1222f2dbe177b9de8420fb95f71291b92af]

        ofz#46864 Stack-overflow
        
        an artifact of the fuzzing mode itself from ofz#3004 Timeout rather than
        a real world issue, undo that
        
        Change-Id: I2a31b8fe62e5b5a3cf90d8bb22f84e473026d161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142361
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [1a47dff65bb94274c03543958b06e8a654a44d4a]

        ofz#51431 Timeout
        
        Change-Id: Ibcaefe2f12d2cad41eb8c7e6cd2924cf2c0c8e3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142353
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Bogdan B  <buzea.bogdan@libreoffice.org>  [6d1118245fed414114f66d2a27a5b5d022ecb3e4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f1d8245e409f5df7ca88c83a573cb07f181d0a5
          - tdf#126574 Macro security high level description
            
            Change-Id: I20dd1a567dbea2a2ef364dfa8de52d6f21178f3a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142298
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [26edb7447e9f90d3cace16e31316a71148db80fe]

        ofz#52723 Out-of-memory
        
        Change-Id: Id563d2d7629c88d443360ec6a1086b1079f7f48b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [45de27c2c8e0081bcb31e0f1dd0bb72d9636b684]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c337f9b3a91c47180ae479f9e847d55f0847e7f0
          - tdf#147862 Writer toolbars help page overview improvement
            
            Change-Id: I7e17eda019a92c1b1b0ed783b3f4b0bd1d2c2b64
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142358
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-06  Jean-Pierre Ledure  <jp@ledure.be>  [26511a8961bc229c5685a913cc846398a97a5489]

        ScriptForge - (SF_Datasheet) Filter, OrderBy properties
        
        For homogeneity with the Form service,
        the
          ApplyFilter()
          OrderBy()
        methods are replaced by the
          Filter
          OrderBy
        updatable properties respectively.
        
        Functionally there is no change.
        
        This substitution is valid both for Basic and
        Python user scripts.
        
        Change-Id: I63a1d5c4554437b6a2cd634677e6eee246cb59ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142355
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [9d42a2c29d195cdd4cb48acc8a65f5ca7df896c1]

        sync mscrypt impl with nss impl
        
        Change-Id: I4960f4b8fa1124f98ee2004ffcfc0994916c297e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142335
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Khaled Hosny  <khaled@aliftype.com>  [35eaff1ad0490b0a1133a594041a6726e5844bd4]

        vcl: cleanup CoreTextFontFace() a bit
        
        Change-Id: Idcef772802636efab7e7b92415a6d31fec0ba979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142348
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3792b1b7708b6e28107fc29d772a806b6f4a2fad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37a143c8e41209ae1836215e83313250de5a2fb4
          - Fix missing link and refactr
            
            Option "printeroptions" no more available
            
            Change-Id: I4aa67acaf2c24db196b14904e781679425bf8baa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142314
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [f3133b803b0c0eabe4566a9a8589c1459a44cd03]

        Document that .clang-format would benefit from StatementMacros
        
        (see the commit message of 4280a3257948e57cdf194a6e23718b46d907bbd6
        "-Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): tools" about the
        recent need of some "clang-format off" in tools/source/misc/json_writer.cxx), in
        case we would ever bump our clang-format version
        
        Change-Id: I4ee9385f84db415903790332c81161c5dbc7614f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142350
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [64f42fe944cff92353c6900f813114ae41d132aa]

        ofz#52490 Timeout
        
        Change-Id: I0aa462bea2975e6532dc3cd4b2f088d5dde8852f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142352
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [b53a0e3dc206b4cec57f142080573d8d165c4035]

        ofz: bump sc-rtf and html max lengths
        
        Change-Id: I5a9f8ec669a211898989e5f4f7a11c4c33a8a665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142351
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Kevin Suo  <suokunlong@126.com>  [9ea9d3ccc0f8e4833e745d9655b61d42d6d8fe83]

        sdext.pdfimport Writer: Do not visit DrawElement twice in WriterXmlEmitter
        
        Discovered when working on commit f6004e1c457ddab5e0c91e6159875d25130b108a.
        
        To reproduce, you can print the content of aOutput2 above the line:
        https://opengrok.libreoffice.org/xref/core/sdext/source/pdfimport/test/tests.cxx?r=f6004e1c#836,
        and then you get the xml content as shown in:
        https://bugs.documentfoundation.org/attachment.cgi?id=183217,
        in which you can see that there are duplicated draw:frame(s) with identical draw:z-index.
        
        To dig into the problem, you may take a look at the following code block:
        
        1    for( const auto& rxChild : elem.Children )
        2    {
        3        PageElement* pPage = dynamic_cast<PageElement*>(rxChild.get());
        4        if( pPage )
        5        {
        6            for( auto child_it = pPage->Children.begin(); child_it != pPage->Children.end(); ++child_it )
        7            {
        8                if( dynamic_cast<DrawElement*>(child_it->get()) != nullptr )
        9                    (*child_it)->visitedBy( *this, child_it );
        10           }
        11       }
        12   }
        13
        14   for( auto it = elem.Children.begin(); it != elem.Children.end(); ++it )
        15   {
        16       if( dynamic_cast<DrawElement*>(it->get()) != nullptr )
        17           (*it)->visitedBy( *this, it );
        18   }
        
        In the for loop in lines 1:12:
        * "elem" is a "DocumentElement" which is derived from "Element". It's childen are PageElement(s).
        * "pPage" is a "PageElement" which is also derived from "Element". It's childen are DrawElement(s).
        * "child_it", as in the for loop in lines 6:10, is a "DrawElement" which is derived from
        "GraphicalElement", whereas "GraphicalElement" is derived from "Element".
        In this block, the code goes through each of the pages and visit the DrawElements there.
        
        The code in lines 14:18 seems to assume that, a DrawElement, in addition to be a child of
        PageElement, may also be a child of DocumentElement. See the comment in souce code.
        Yes, it may be. For such DrawElement(s), the visiting is done in lines 14:18 separately.
        
        Note that The above code uses dynamic_cast to determine whether a node is a DrawElement or not.
        
        The problem is that, in determining whether the node during the 2nd visiting is a DrawElement,
        it accidently used "== nullptr". This may be an inadvertent error. If the dynamic_cast is a nullprt,
        then it is not a DrawElement and the visiting should not be done there.
        
        Resolve this by using "!= nullptr" in the second dynamic_cast checking.
        
        Change-Id: I066100e98039d505d8b10c390954e014b78cff4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141680
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-06  Caolán McNamara  <caolanm@redhat.com>  [7351bf23f5f92b1e59436b3f7b99ed52ab03bf4e]

        ofz#52685 Timeout
        
        only allow a short read after reading the preamble of the tiff
        
        Change-Id: Idd4b8892457566daa028c68125fe3beeb7499803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142346
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [1b2fa783af31cf3ae030dd9dc55cbcb7dd4c7220]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): xmlsecurity
        
        Change-Id: I58b01510fd41256660f703a3b62901fe286ffb93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142337
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a28f89581c0395f4af76161e1c99302d9f665a8f]

        Remove double functionality
        
        There was processorfromoutputdevice.cxx|hxx containing
        createBaseProcessor2DFromOutputDevice that does exactly
        the same thing as createProcessor2DFromOutputDevice in
        processor2dtools.cxx|hxx, so I removed one onf them
        to make handling of future changes easier.
        
        Change-Id: Id8d49d1572a1bc39f1d330a742d4697c8c030e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142320
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-06  jsala  <javier.salamanca.munoz@gmail.com>  [64469bb1a7383da6e7ff1150d693b3e08f54bc91]

        tdf#145538 Use range based for loops
        
        Change-Id: Ic27ef946b8b878770446bd975b836d7c6c29dd4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141668
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-06  jsala  <javier.salamanca.munoz@gmail.com>  [04a58d7eae2b26559efd48ff7cdd23cec1c2187c]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Also change some range based for.
        
        Change-Id: I32c5cbe0033c40cde3f1fc86ec8af90e558f2652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141666
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [804f21e42bdc9328ab0f17b983411657e1f6215d]

        loplugin:unusedvariablecheck
        
        apparently a leftover from 643fec7cf7a81bf8c89a8efd47c0310b38f9076c "vcl: add
        PhysicalFontFace::GetVariations()"
        
        Change-Id: I78141d5de4c3f63096552eb25b70da3e5de36df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142284
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [ccce14bcceea0978764f720e1de1b2a9f90fbcb4]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): desktop
        
        Change-Id: I438acf8e63a5d855bb19daee07af0f92b4b609a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142323
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [34cecc1f9c5dd41473a84be051d56b37118698aa]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): lotuswordpro
        
        Change-Id: I6b9707c1f416eb1ab890ff0d783151066cf695d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142329
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [b6fbcac6f6933858db53a54e7505ff3a83465960]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): i18npool
        
        Change-Id: Id5c9892df6dd3f4e66098a312a79e91bd6b9e8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142328
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [7533d93cdcf3b6076275167b53450a1cbde045a7]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): compilerplugins
        
        Change-Id: I9a4d20cd42d6c836aa74837688a272f849d9d373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142322
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [4280a3257948e57cdf194a6e23718b46d907bbd6]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): tools
        
        (The "clang-format off" in tools/source/misc/json_writer.cxx is necessary
        because otherwise the code between the SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP
        macros would be ill-formatted in a way that would trigger loplugin:indentation.)
        
        Change-Id: Ic96787865d4c96be07c41f4939893420dfa04046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142339
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [5cbc2052815f6640a118d64202872a082ad558b3]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): sw
        
        Change-Id: I64ff2d2c78e09b4fdeaeef7cc82c96572f049ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142336
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-06  Stephan Bergmann  <sbergman@redhat.com>  [be2dd1746b021a99e99396adab71a0b0e5864825]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): sc
        
        Change-Id: I26a36662f23c814cc95c8d6e1270892d068f6c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142333
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [1b1a066b935158dc029939520c8fe70b029cb311]

        lok: show Math selection
        
        Change-Id: I950ae3e5fb000d6acec4c26ff143b918a4e48a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142342
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-05  Caolán McNamara  <caolanm@redhat.com>  [d90bf6f8c19d7c43ec83656a3a6f85a81aee573c]

        ofz#53028 Integer-overflow
        
        Change-Id: I35c2731b8b6afe1d75f71e4c4b7bb12c07807faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142340
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-05  Caolán McNamara  <caolanm@redhat.com>  [12e468a6066894e7ff01d622343d23fccbceeb09]

        cid#1516651 Dereference after null check
        
        Change-Id: I0f4586538a672426cbfe60d1e589778741b08dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142338
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-05  Caolán McNamara  <caolanm@redhat.com>  [3635f65a65da6198d770d5148b68a81c271b9169]

        fix a potential mem leak
        
        Change-Id: Ibc5f978b0db17e9e3fc633e843f476052570edfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-05  Caolán McNamara  <caolanm@redhat.com>  [5336952fc7fa6f8e1ae9652f59c87e29693694d4]

        cid#1516654 Unchecked return value
        
        Change-Id: I19fcac7f1c4dff3bd18fe0cee0188e207edd4251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142330
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [1c216f5291e09ccca430551f5bc2677def3842cb]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): emfio
        
        Change-Id: Id69f3639cb957570c4165150b288397c6e06727e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142324
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [edc271017fc823d600fce1b94bf65cc1ce4777fe]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): sal
        
        Change-Id: I668a8b4c6ce3458baa6975161be7ed0cb160968f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142331
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [3eee720ce275d7fad195ac6bfa44dd596eb87b64]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): svl
        
        Change-Id: Ia7e9ce9f93fbc48db412678da541fda4f1f7717f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Julien Nabet  <serval2412@yahoo.fr>  [8fe04bc08cb3007fa4fe07b0a6a189aa4eb37092]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 32cbfd80a9053d4f62961edcae6a8b33f5d0bf03
          - tdf#151908: An error has crept into the documentation of SUMIF()
            
            Change-Id: Ifbaab9ecc270db4f70c6b4937c30c7d88f0547d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142296
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [47ef2aa3709b248475e9c462667434f59f4cf2cd]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): extensions
        
        Change-Id: I5ff1ad95c452c9e4b902ab547d84e6c2064db8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142325
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [0e45f8318ee73361fecb049b33b0662fabe295d3]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): hwpfilter
        
        Change-Id: I91aa4dc3cedccf341a5b7a936c171323a3e58630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142327
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [d45d1e14d75b58323e3486c3ca3dfd2866e08bdb]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): filter
        
        Change-Id: Ia69631701e2f1f5d61fda8ce6a7f7fc76ecc6e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142326
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Martin Srebotnjak  <miles@filmsi.net>  [8f7d9b7037d6fcf124048c3baa97a3465383b853]

        Update git submodules
        
        * Update translations from branch 'master'
          to b03d019e0d04ae68a632bc052fc1ce7801736d7f
          - Updated Slovenian translation
            
            Change-Id: Ia30e0189ad3da9c69c21a39327341a3c4dcdb4cd
            
2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [e88cb2d41fa8cbd4513285d0b2521f91561dd971]

        -Werror,-Wdeprecated-declarations (sprintf, macOS 13 SDK): basic
        
        Change-Id: If70c3bf8d7d6c855baf23b02cccb3f3b5ccb9f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142321
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [90e1bf18aa33af9de8be8e489be8b5a3a8f8e940]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 717e1f64d70967254ec2379eb97c7f52c0c2ac3c
          - tdf#126917 help: correct menu path for XML Filter Settings
            
            Change-Id: I9cdb5cd15984d910bd710b123431acfea34b81c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142341
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-11-05  Jean-Pierre Ledure  <jp@ledure.be>  [18638efa3973bf919a2502866773c02b7c24f7d7]

        ScriptForge - (SF_Datasheet) new menu methods
        
        Next 2 methods are added:
          CreateMenu()
          RemoveMenu()
        
        They allow the addition of a menu entry in the menubar
        of datasheets in the same way as in documents.
        
        The implementation required to make the
          SFWidgets.SF_Menu
          SFWidgets.SF_MenuListener
          SFWidgets.SF_Register
        classes and modules more generic to be applicable
        in several contexts.
        
        In addition, 2 properties are added:
          DatabaseFileName
          ParentDatabase
        to better identify the database from which the datasheet
        is derived.
        
        New properties and methods are applicable both
        for Basic and Python user scripts.
        
        Change-Id: Iac6318287e89b18810a53ec5928a68e921ea96db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142285
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [e0a5a201d4170f4dac23a0e1aa8df18918549991]

        loplugin:stringconcatauto: There's no dangling-ref issue with O[U]StringNumber
        
        ...so it's unclear why 2f5f45921b05904a4be1ff633be09c62cb44ff08 "support
        O(U)String::number() for fast string concatenation" added that here.
        
        On the contrary, variables of type OStringNumber can be useful replacements for
        calls to std::sprintf (which started to emit deprecation warnings with
        macOS 13 SDK now), so this is in preparation for follow-up commits that will
        replace many uses of that across the code base with various alternatives.
        
        Change-Id: I6f8508d49dc84773c50f4c33dba38fe08c4c8969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142318
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Stephan Bergmann  <sbergman@redhat.com>  [327d1b012f1c3d33fc4160576d25bb57488fca7b]

        Introduce o3tl::sprintf
        
        ...in preparation for follow-up commits that will replace many uses of
        std::sprintf (which started to emit deprecation warnings with macOS 13 SDK now)
        across the code base with various alternatives
        
        Change-Id: I9602f1cb0e28d1b70c2356edb52d78dd165f1118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142317
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [f0a88a6d214ebdcc3617d24beb4bb5148f72c3a4]

        lok: properly treat zoom in LokStarMathHelper::postMouseEvent
        
        Previous naive implementation was dropped in commit
        033a342a630dbb6329962156727e621866b77b48 (lok: use twips in Math,
        Wed Nov 02 11:03:08 2022 +0300). Unlike chart, Math expects twips,
        so PPT (pixel per twip) factor must be converted into percentage.
        
        Change-Id: Icd936e004d961c0abc25c241391d4e24c44e8c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142319
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [14ed342dd3f4cae607f7785905787f73c7b1fde2]

        lok: show Math cursor
        
        Change-Id: I17a449f0a0662f0433de9cad1522a090434c1e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142178
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [d8856123f72d243b45fe52b7d3dbb87aa35ce0ba]

        Resolves: tdf#151509 don't overwrite geometry for system childs
        
        Change-Id: I5ad73d0bd138b2ba1b99d63bca97773f43e39606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [8c4490d4980087cfe1735984d6e41130a6560524]

        ofz#53011 Timeout: drop categorized tokens we don't have handlers for
        
        since
        
        commit 3514ad82c4200be292ef6eaa1e94c5c6a41884e4
        Date:   Mon Dec 10 10:02:46 2012 +0100
        
            sw: unused SwRTFParser
        
            Change-Id: Iaabd3d992f5e8cd8166afd3520fa8552b6219e27
        
        we only had writer handlers back then so misplacement of these "private"
        tags in unexpected context was always a hang, but with no consumers of
        them we can drop them entirely and avoid the problem.
        
        Change-Id: I6a914e5adcbebba52171d8327414f1c71ada7f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Kevin Suo  <suokunlong@126.com>  [5da75fcb400579d11430ec3d4c29b4646797fc5c]

        Templates: tdf#86483: Add "Localization" category and add a template for zh_CN
        
        This patch adds a new template category named "Localization", to be used for
        templates created by our l10n team for each locale, so that languages which
        requires special layout or formatting (such as CJK or CTL) can have their own
        templates bundled by default.
        
        This patch aslo adds a (general purpose) Writer template for the Simplified
        Chinese language. Chinese language, by convention, need to format the
        document to have the first line of the paragraph be indented by 2 characters.
        The font size, line spacing, paragraph margin etc also need special treatment.
        If the Chinese users start writing using the current default Writer template,
        they need to adjust the style formatting every time to meet their needs.
        Although this template can be provided as an "extension" on the extension
        website, in practice very few people will go to the extension website and
        look for such templates.
        
        Such bundled templates can also be added by other l10n teams. The
        extras/README.md will be updated in a separate patch to include documentation
        on how to add such templates and have their template names translatable on
        weblate.
        
        This does not completely resolve the issue in tdf#86483, which requests to
        "Implement different default templates per locale". However, with this patch,
        we are a step closer to set a choosen template when the user switch to a
        certain UI.
        
        Change-Id: Ic295482354f343e981eb20908907bd6a945b7120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140802
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2022-11-04  Miklos Vajna  <vmiklos@collabora.com>  [c400c36018e8d89bbf8e551258a480c8f6571efe]

        sw: fix heap-use-after-free in SwDBManager::MergeMailFiles()
        
        This went wrong in commit b1d13c48b57633c156e7d76fe81fc5828d1e3e20 (sw:
        fix merge mail multiple files, 2022-10-18).
        
        There were 3 problems here:
        
        1) SwDBManager::MergeMailFiles() called SetDBManager() on an SwDoc, but
        that SwDoc has been already deleted by
        SfxObjectShellLock::operator=() that owns it. Fix the problem by
        switching our reference of that SwDoc to rtl::Reference<SwDoc> and then
        clearing that reference before the owning SwDocShell would be deleted.
        
        2) Now that the SwDoc is either alive or is properly a nullptr, need to
        check if our SwDoc is nullptr before calling SetDBManager() on it.
        
        3) Now that the doc shell is a SfxObjectShellRef and the doc is a
        rtl::Reference<SwDoc>, need to make sure that the doc is declared
        after the doc shell, since the SwDoc dtor will access its doc shell, but
        not the other way around.
        
        Change-Id: Ie10bac422a6d39b4401c90ecd67637b511e5b705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142282
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e4336bcd26911fdb20051b58050d24c141ce372]

        CppunitTest_sw_globalfilter: remove duplicated code
        
        Change-Id: I02abfebd643859ed40917117fc4ed67a9ba7c496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142290
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [4d493db529600c3ae39b39da0c708c36d679a76b]

        lok: use twips in Math
        
        Change-Id: I11acd281da64b0023d74b3bc02e0f54864b94da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142275
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [e126c98bf8ca4be6f4f8018446ab0d6060d731d5]

        ofz#53016 Undefined-shift
        
        before commit 4b95451f859bac8e05956ce12df17f1ee410032d
        Date:   Wed Sep 21 20:54:00 2022 +0200
        
            split utl::TempFile into fast and named variants
        
            which makes it easier to know what each variant requires
            to stay on it's happy path
        
        we closed the writable stream and got another readonly stream, after
        that commit we have a read-write stream. With the "true" arg to
        Storage it will Commit back to the underlying storage its contents
        in its dtor. With a ReadOnly stream this failed and nothing happened,
        with a read-write stream there is a write which didn't happen with a
        read-only one.
        
        Lets just use false here, we're not interested in keeping the contents.
        
        "Direct" in this context is presumably analogous to the Compound
        File Format "Direct mode":
        
        "The mode in which files are accessed, either transacted or direct,
        determines when changes are committed.
        
            Transacted mode uses a two-phase commit operation to make changes to
        objects in a compound file, thereby keeping both the old and the new
        copies of the document available until the user chooses to either save
        or undo the changes.
        
            Direct mode incorporates changes to the document as they are made,
        without the ability to later undo them.
        
        For more information about access modes, see the OLE Programmer's Reference."
        
        Change-Id: I1f710de227807073a6aff11a86d7cfaf6d380509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142283
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [09b452c2e174aa1be3b826198cd3b495b7ede454]

        ofz#53028 Integer-overflow
        
        Change-Id: I08f072e28e182dd8b606a93b5509e7cb38e173e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142281
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [e77beab92dfe1136a59c99af6571de6eae9f7e12]

        ofz#53034 Null-dereference
        
        Change-Id: I3be4f2b976b64a2f592eeef9802e6cf8dd15341b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142278
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [c44f64621fe11d6a46c79b9793c7c67c60bb66e8]

        SwModelTestBase: make mpTestDocumentPath private
        
        in preparation for future inheritance from UnoApiTest
        
        Change-Id: Ie5dee5af3609d8490d7d7bad0d6dbc4c8fc17bb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142280
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [20d5763b2b56b4e3d7569fe9e5cdad87657f6808]

        Related: tdf#151509 factor out common block as UpdateGeometryFromEvent
        
        Change-Id: Iec2d4d1dcc2c38e264079024e25a8a3b8ea351c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [14175b130ff97c5576ff872dcf3163954c6f80f8]

        add a test for "fit to frame" text rendering
        
        Change-Id: If304f12e1f1fbe3afea4885975302b77b428567f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142187
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-04  László Németh  <nemeth@numbertext.org>  [21c6547302580c3fd77b85fda68bb0239b8c560a]

        tdf#115007 svl: clean-up "add NatNum12 number format list items"
        
        As suggested by Eike Rathke:
        
        – call getCurrBankSymbol() via rLoc();
        
        - remove CCC support with NatNum12:
        
        "This old CCC automatic format code never was used with
        NatNum12 and shouldn't be introduced, it also isn't
        offered in the number format dialog if a legacy document
        doesn't already use it."
        
        Follow-up to commit 2a1d2d42af7f365330479f4032ddfdd9eeba7c1d
        "tdf#115007 add NatNum12 number format list items, fix title case".
        
        Change-Id: Ia298d62221b1ce220724bdd7cfe627913ee1afc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142269
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [00f7fae71f95bdbe9fc44a00a0f93924c04948cb]

        sw: remove duplicated code
        
        Change-Id: Ief47e4d6eeea916c555d28fefca837ef978cb4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142267
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [30fba094c428199e1dd81fc5dd768c544897a190]

        upgrade Expat to 2.5.0
        
        Fixes CVE-2022-43680
        
        Change-Id: I5bf8d1ab0ac352833c76a7edfc1d8eb78dd03e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142042
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a2e81d4da10cde111cc82c1378ca4a18cb4eff4]

        CppunitTest_sw_indexingexport: remove duplicated method
        
        Change-Id: Iffbcd8ae699e8d09933cd9ef3c51a9b1a9e6dd7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142268
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fdf20eac1e071e68d4eea7d9f15bd8b3e7046d1]

        address review comments in unotools::WeakReference
        
        from commit 4e0856fa11674e386c9b84dd40a702c83450166f
        
        Change-Id: I0dbd6a115b36be8030120a8006959e611f637f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142266
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [493c88ab4e597c55e920dbec2262058ecc6b6922]

        calling getCaughtException twice in one catch block is not allowed
        
        It seems to work, but it's not guaranteed to do so, and violates the
        documented contract.
        
        Regression from
            commit 85a5233275ab83fe0d6b943b298695387d97accd
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Oct 31 12:08:50 2022 +0200
        error when copying table and the copy table wizard creates the
        primary key
        
        Change-Id: Ib8422017e627e825865c96dd9fbacbe0e518e96b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [b1671feb791178f9c498b0d00a5aad486bccfa03]

        Related: tdf#151509 trust the crossing position provided by gtk
        
        don't attempt to recalculate it from root window position with an
        offset of our belief as to our position
        
        Change-Id: Ia08cfd2aa5de73139ec7444b4576fe0c00240009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142271
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [63e1f94c121a5153c2b9012a7fbc2da3a493a8be]

        Related: tdf#151509 make what the x/y values are more clear
        
        we're re-deriving in a more complicated way values we already have
        available.
        
        no change of logic intended.
        
        Change-Id: I14232558312e5457dce7a949cdafe0518214894d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142270
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [dbd5667793f2b333e7e00e720bb09d917a3468db]

        external/openssl: fix and remove some patches
        
        * openssl-no-multilib.patch.0: fix patch coverage
        * opensslios.patch: remove this patch as it is not used.
        
        Change-Id: I4651fc4107992bdaaefc2af3d0ff04c7bf26fa87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142190
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Caolán McNamara  <caolanm@redhat.com>  [f633ca7fcdc64a2d30f1682a7dda51fd9f693879]

        ofz#52830 skip slow path for fuzzing
        
        Change-Id: Ic19f71200b862469978e55789ef879d680440a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-04  Stephan Bergmann  <sbergman@redhat.com>  [20926c0a7559ea9c4f82c662f11a395fa1eb79a3]

        Reinstate removal of lcl_GuessPaperSize
        
        ...originally done with 1d7964c5ff579ff93067dc1c3e45b522e3cb2b4e "CWS-TOOLING:
        integrate CWS unifypaper01" on 2009-06-12.  However, the removed
        lcl_GuessPaperSize then reappeared, apparently with the merge commit
        4563270cfd37f1a08e0315a5624affa3a7680771 "CWS-TOOLING: integrate CWS
        printerpullpages" on 2010-01-15, presumably due to a mis-merge somewhere along
        the way.
        
        SmModel::getRenderer and SmModel::render are e.g. called when doing "Export as
        PDF..." of a Math Formula, but it seems a bit hard to get into the "no real
        printer" branches there that would actually have called lcl_GuessPaperSize.  But
        anyway, it looks reasonable to replace that function with the more elaborate
        SvxPaperInfo::GetDefaultPaperSize.
        
        (I stumbled over this when the code in lcl_GuessPaperSize caused a newly
        introduced -Werror=dangling-reference with GCC 13 trunk, similar to
        e0121b2478526d803681d57d59af0cbf9cf602b4 "-Werror=dangling-reference".  So I
        figured I'd remove that code as apparently intended back in 2009 rather than try
        to fix it now.)
        
        Change-Id: Ia73d9ece8429bbeccd4f65a9efc156c0dee52c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142246
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-04  Amarjargal Gundjalam  <amarjargal16@gmail.com>  [670fa33edd7c9da77d5cbed5c7978ef24df59f15]

        tdf#143641 Fix UNO Object Inspector window title
        
        When detaching the "UNO Object Inspector" window, the title is "LibreOfficeDev 7.x",
        and not anything related to the window. This change fixes the window title.
        
        Change-Id: I3b7c3b547e59acd108b62a537ce7ff24162d745b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142053
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-11-04  László Németh  <nemeth@numbertext.org>  [733bfd9597fc42c569c6855bb71c56429e009fa6]

        tdf#148672 Old Hungarian transliteration: fix "word]"
        
        Words ending with closing bracket weren't transliterated,
        because NatNum12 parameters couldn't contain closing bracket.
        Transliterate without the bracket, and append it to the
        result.
        
        Note: "[word]", "(word)" etc. forms will be handled
        by the next libnumbertext release.
        
        Change-Id: Id0d34267575782487819e3a3f76d1b547866e362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142254
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [f62e6496521af8d1f2b612123c664bcf3223946a]

        CppunitTest_embeddedobj_msole: inherit from UnoApiXmlTest
        
        Change-Id: I26e0a4db8484c8e91f3ebff9828d76270ddc5f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142256
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Henry Castro  <hcastro@collabora.com>  [1e007e8f1703851b01c68884e87c906f6bae5a5e]

        sw: fix merge mail to direct export as pdf
        
        In order to export directly to PDF, the document
        must remove the hidden sections (if format condition),
        the data source should stay on current selected
        record finally restore the hidden sections.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Idf8e2a26d5c9cbe61ddac6c35cc2e1df1175da27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141520
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-04  Henry Castro  <hcastro@collabora.com>  [fb8d94e77f16e0f9d3af42d64756bd771de9d17c]

        sw: add FN_PARA_1 to MAILPREPAREEXPORT slot
        
        Reuse the code to use the functionality without
        the UpdateFields calls, otherwise it will reset
        the data source on the first record and export
        to pdf will have wrong data.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Iec3b44b91c06861cb22d0a7a7234bee6f6f817a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141519
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-04  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [f994f4312d8e166e79b36f7bf0f8c41c3f1082f4]

        svg: export embedded video
        
        Change-Id: Ie5dcd1fb4abbaf53f48107e7def0f42daad24596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142145
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [2cfd5a875231cc9ae59cc495ba82efc54de2016d]

        Fix ARM64 build after postgres upgrade to 13.8
        
        Partially revert 096e2ba8e4fce64c04a7d7e842dd1dbab8699801
        "postgresql: upgrade to release 13.8"
        
        Change-Id: I3fa2a96f9765788ab6193133c4f420eed7eb99bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142255
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-04  Tor Lillqvist  <tml@collabora.com>  [10e81ff3e3aa0f0b6b6cf392e62606ef4629ebec]

        No need to accept macOS SDK 10.13 surely
        
        We require at least 10.14 at run-time anyway.
        
        Change-Id: Iaffdb403696733583ac66e31139c3b427aae0b69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142233
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e0856fa11674e386c9b84dd40a702c83450166f]

        tdf#54857 use more static_cast in WeakReference::get
        
        which shaves 3% off the load time here.
        
        Change-Id: I514dedc765ad12da2ad08e115c1ebf86c653c433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142237
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d2ee5d46ee0146a4990dfe3b3246371fece0826]

        SplineLine and SplineFill have never been implemented
        
        Change-Id: I75e01bc8831a9d8e6e1f52fc3a89cd9827e1d6b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Miklos Vajna  <vmiklos@collabora.com>  [af9b08ed62e0fa9925bccab9ddf6f078fb1b7c70]

        CppunitTest_sw_uiwriter3: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I2105da00f5e89409b29dbf8f99339955485bd69f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142252
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e14a3ebf801848236bd9559f64c134412e498a32]

        tdf#54857 use OUStringConstExpr in XMLPropertyMapEntry
        
        which means we don't need to allocate a bunch of strings
        when building the property maps in xmloff
        
        Change-Id: I83cb013f816d9b7bcb0dd55c59e5151b33b91c9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142192
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ae53eb5dcbe0a3c5b4dc5323639a11878a38101]

        tdf#126788 remove weak m_wThis reference
        
        weak references are surprsingly expensive in bulk.
        
        To make sure we don't get revive an object, we need to stop listening
        before we destroy the Impl object
        
        Change-Id: I8a3d99e29681e1f844598bc7ac792a659e1104f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142092
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a37a979107a8643136ff3733b5b350b6b1be2bb7]

        Use o3tl::convert in Math
        
        ... and use our standard definition of pt.
        
        Change-Id: I5a162b137360210335b84de33606dc7404cfc2de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142204
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-04  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [5efb023c27e693654b09c45894a6f4a50f3d950e]

        tdf#150045 Supplemental label in Validity dialog
        
        In a type ramp, this label has secondary importance. This
        change gives texture to the dialog and makes it easier to parse.
        
        Change-Id: If1dbb01ff2fb0a103a7f534b9ca4cc4681e923ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142227
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-11-04  Eike Rathke  <erack@redhat.com>  [94c64c0c999eeaa91ebdc335186289046eacdc4f]

        Related: tdf#151863 Set #REF! error if reference list is not convertible
        
        i.e. to array/matrix that a function or operator may expect.
        
        That indicates the actual problem better than #VALUE! and also
        seems to be what Excel does.
        
        Change-Id: I9c3857613e330f9a93d4a0595e740106addc6e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142250
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2640796d90ad4c69f5093e7b3353d43b647901e1]

        UnoApiTest: make mbSkipValidation private
        
        Change-Id: Icc292b40b3295e7890f81d448bb4907725f46970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142245
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5e872e06a070ff8e90f644036981fa202c2b1e0]

        swmodeltestbase: remove duplicated method
        
        Change-Id: I16b785c31f0e235b6a71b6ea86b17b72e063e95d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142247
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee1154d7fe84d507ce977b851c4044cafe0b9da9]

        swmodeltestbase: use maTempFile everywhere
        
        Change-Id: Ifd840984e4144599f2527702a57688863854b7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142235
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  László Németh  <nemeth@numbertext.org>  [b7d53247eb2fab04f5f6d82d405f1ac0c73542b2]

        tdf#115007 i18npool: add NatNum12 formats to locales
        
        supported by libnumbertext.
        
        Note: English currency formats got title case and
        upper case items, the other one lower case and upper
        case items. English standard numbers got title case,
        sentence case, lower and upper case items, while
        the other one got all cases except title case.
        
        Note: libnumbertext update will fix missing
        currency names of en_DK, en_IS etc.; Irish;
        es_SV, es_VE etc.
        
        Change-Id: I1621d1256e06e9fd843f5b66fd39b16f12cf1b96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142126
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-03  László Németh  <nemeth@numbertext.org>  [2a1d2d42af7f365330479f4032ddfdd9eeba7c1d]

        tdf#115007 add NatNum12 number format list items, fix title case
        
        Add NumberText NatNum12 number formats, e.g. "One Hundred",
        and currency formats, e.g. "One U.S. Dollar and Twenty Cents"
        to number formatting dialog windows, i.e. Format Cells->Numbers
        in Calc and Format Numbers in Writer (Edit Fields->Format->
        Additional formats...).
        
        Fix also bad English title case:
        
        "One Euro *and* *Twenty-Two* cents" (not *And* and *Twenty-two*)
        
        Details:
        
        – svl: list NatNum12 NumberText currency codes in Currency
          formats (i.e. after choosing Currency category).
        
        – svx: Recognize bank symbol "CURRENCY" in NatNum12 parameters
          defined in locale resource files. For example,
          "[NatNum12 CURRENCY]" is converted to "[NatNum12 USD]" in
          the number format dialog windows, using bank symbol of
          the current locale settings.
        
          Recognize compatible (old) bank symbol "CCC" in NatNum12
          parameters defined in locale resource files. For example,
          "[NatNum12 CCC]" is converted to "[NatNum12 DEM]" in
          the number format dialog windows, using bank symbol of
          the compatible currency of the German locale settings.
        
          User-defined formats with arbitrary bank codes are
          recognized as currency formats, e.g. modifying
          "[NatNum12 USD]" to "[NatNum12 EUR]" in the dialog window
          results a new currency format item.
        
        – i18npool/*en_US.xml: define four Standard NatNum12 formats
          (lower case, sentence case, title case, upper case) and
          four Currency NatNum12 formats (title case, title case with
          digits, upper case, upper case with digits).
        
        – cui: use lower sample numbers for spell out formats:
        
          – 100 for Standard:
        
          One Hundred
          one hundred
          One hundred
          ONE HUNDRED
        
          – 1.2 for Currency:
        
          One U.S. Dollar
          ONE U.S. DOLLAR
          One U.S. Dollar and Twenty Cents
          ONE U.S. DOLLAR AND TWENTY CENTS
        
        – i18npool: fix English title casing of NatNum12 conversions:
        
          – Don't apply casing on "and", according to the title
            case rules, for example:
        
            "One Euro and One Cent" instead of
            "One Euro And One Cent".
        
          – Apply casing on the second element of the hyphenated
            compound words:
        
            "Twenty-One" instead of the bad "Twenty-one".
        
        – add unit test for extended Number and Currency categories.
        
        Note: according to the changes, update user-defined number format id in
        chart2/qa/extras/chart2dump/reference/chartdatatest/simple_chart.txt
        
        Change-Id: Ieaf9a8f75a4f197b858eaf67f83484df70295834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141994
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-03  Jan Holesovsky  <kendy@collabora.com>  [142d3e15916afd1c38bcccf0d23cac292ea357fc]

        sc lok: Double-click should behave more like on desktop
        
        When editing was introduced in Calc LibreOfficeKit, there were lots of
        limitations.  Particularly the thinking was that it would be good if a
        double-click into any text (even if spanning over more cells)
        actually started editing that text.
        
        These days, the LOK behaves much more consistently, so it is better to
        behave as the LibreOffice on desktop (or other tools, like gdocs) do:
        
        If the cell:
        
        * Is empty
        
            -> single click places the cell cursor
            -> double click places the cell cursor & shows the text caret
        
        * Is empty, but covered by text bleeding from other cell
        
            -> same as if it was empty
        
        * Isn't empty
        
            -> single click places the cell cursor
            -> double click places the cell cursor & places the text caret
               inside the text where the user clicked
        
                + this is actually different in gdocs - there the caret is
        	  placed at the end of the text; in LO it is where the user has
        	  double-clicked
        
        Change-Id: Ib5884f887c98f803b06d8bed5057ec435be480ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142196
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2022-11-03  Caolán McNamara  <caolanm@redhat.com>  [6c0ac70a512c1789d26721bd1f7d01a8b24fa718]

        Related: tdf#149932 map NSUnderlineStyleDouble to new DoubleUnderline
        
        and NSUnderlineStyleThick to ExtTextInputAttr::BoldUnderline
        
        Change-Id: I66696cfd24ccd2cf02a2af63290419ac584079e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-03  Caolán McNamara  <caolanm@redhat.com>  [d1cd19b56d5fefaa6f41a4d70e748331525820a4]

        Related: tdf#149932 honour PANGO_UNDERLINE_DOUBLE for preedit underline
        
        we already have support for double underline so that's an easy add
        
        Change-Id: I1bba5620038e396765bd79050ff6a520096f9476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-03  Jim Raykowski  <raykowj@gmail.com>  [be2cd4bcc4e55b9fe6e5fcd6276511d37f3f8e4c]

        tdf#142446 Improve show outline content to level
        
        by reworking the MakeOutlineLevelsVisible function
        
        Change-Id: I0a102420475ed97e35b8f92315eaa4cca2958599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142226
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dc9ebcbfd28b417189c94ad6d7492928e2cfd43e]

        Fix typo
        
        Change-Id: I73fec7b8634704a8ceedf7a1be6eacd4dafc06e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142249
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [46f00c710f6deb59f369dd6736693e133e51f05f]

        Fix typo
        
        Change-Id: If6bfabcfb1f9bc653b72c3775cdeaa91e0058fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142248
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-03  Noel Grandin  <noelgrandin@collabora.co.uk>  [e96be4156d50f9c1756cd5ff324a10a7a3487968]

        fix warning C4701: potentially uninitialized local variable 'bBool' used
        
        seen on jenkins
        
        Change-Id: I9d514580a80534eff45578c9b6cfdaf45fb7285f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [be63419810cd6f418d33ef1b7724ba32e867e52b]

        qa: remove duplicated code
        
        Change-Id: I13da5ca9d07131a340dcf95ca0b980d75ca6e9d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142229
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Caolán McNamara  <caolanm@redhat.com>  [57e0b4344111431e0a26622920b35dfc7d9e8ff8]

        Related: tdf#149932 honour PANGO_UNDERLINE_NONE for preedit underline
        
        at least don't show an underline for PANGO_UNDERLINE_NONE
        
        Change-Id: I190f44e1dfb7da1c663ce588973278d0da591c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142222
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [6f77eda1f4de7f2835a32dd597442a29fe59291c]

        CppunitTest_sc_html_export_test: inherit from UnoApiXmlTest
        
        Change-Id: Iee06f883704484bf62bf1d9988580d72ba40db22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142232
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [1cfa0f49922aa49597bac341393c8f38309a3bae]

        Do not merge filesarrayref and unixlinksarrayref when filtering out directories
        
        In commit 8c6467a785037309d2a2cec56c8e38cf52da0aee, the code
        filtering out the directories was creating a new array, that
        was assigned to the function's inout filesarrayref argument;
        and that code merged non-directories from both filesarrayref
        and unixlinksarrayref.
        
        This fixes the logic to only filter filesarrayref.
        
        Change-Id: Ia00dcd3f645ba2a6c2d8ea0559627ccfe0eb232b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142195
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-03  Caolán McNamara  <caolanm@redhat.com>  [4865ad2365a25d89e61d382613a1f35c78800f4d]

        Resolves: tdf#151112 move focus into container widget hierarchy
        
        Change-Id: I5e5ca5a377f8e4c79ec8b2e4c2674be7ed0c10a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142230
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-03  Henry Castro  <hcastro@collabora.com>  [b1d13c48b57633c156e7d76fe81fc5828d1e3e20]

        sw: fix merge mail multiple files
        
        If the document contains a section with a
        hidden condition, and the user merges into several
        files, the section has to be deleted in the same
        way as the single file.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: If5483aaf635a6515482f245c286132a365d72762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141518
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [15e899ccadf1d1096c54330205207f162a7b3a0b]

        CppunitTest_sd_shape_import_export_tests: fix build
        
        mid-air conflict between 933768ffcd8617942f45481de77e656ded9dcfe2
        "tdf#150966 oox export avoid bottom above top for text area"
        and
        d40d64da771427423786dc62a2f4ad08cab53179
        "swmodeltestbase: remove duplicated code"
        
        Change-Id: I248066f2dc3940b39a6727fbb7d070cb527a625a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142242
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Henry Castro  <hcastro@collabora.com>  [7bd657b5dac270dae09cd0fe2b22d23fd2fc7245]

        sw: fix Content Node assertion
        
        assert(nNode.GetNode().GetContentNode() && "only valid to call this if we point to an SwContentNode");
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I31664decd83a1db92858c6d5efac90949eddb3ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141517
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-11-03  Regina Henschel  <rb.henschel@t-online.de>  [933768ffcd8617942f45481de77e656ded9dcfe2]

        tdf#150966 oox export avoid bottom above top for text area
        
        If bottom and top insets set so that the bottom edge of the resulting
        text area is above the top edge, then LO and MS Office behave different
        in how this is rendered. With commit e2169886 insets are converted on
        import to make rendering in LO similar to MS Office, but the
        implemented export has some problems, see analysis in bug report.
        
        LibreOffice normalizes the resulting text area in case bottom edge is
        above top edge. So this patch exports the insets so, that MS Office
        gets a normalized resulting text area and will not apply its special
        rules.
        
        A roundtrip starting with pptx will not regenerate the old values but
        will produce inset values, which give same rendering in MS Office than
        in LO. Because the method is different now, the inset values have
        changed and test testTextDistancesOOXML_Export is adapted. When you
        compare the result with the screenshot on slide 2, you see that the
        new method works as well.
        
        The old method did not work for exporting an odp file. That is covered
        by the new unit test. The docx unit test file covers the case, that
        the export tweak was erroneously triggered.
        
        Change-Id: I0091f284d9bdd635dd87ddb9e9b0e415cc0cc51e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142185
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [2dd592f0836184e3f275e8ff3248639f08a3f647]

        UnoApiXmlTest: add new wrapper for XmlTestTools tests
        
        Change-Id: I767f464ec666330a2e8e832b6d6f5736a6bef54d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142228
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [1de8308d40fad8e9281d2b491f8c5c919fda82f4]

        tdf#116566 Make Spellcheck dialog respect dark background
        
        This patch makes the sentence in the spellcheck dialog respect the colors in the selected color scheme. More specifically, it uses the AutoSpellcheck color and the Font Color in the Edit Engine.
        
        Change-Id: I0f8e842417645250c9145d1e37d8cf52c290379e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142147
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-03  Alain Romedenne  <alain.romedenne@libreoffice.org>  [bc456bac0ffdefd37164ca5d5b123ed8df72f4f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 638ca29e5446bd2f330f8a66bcadfced725597ec
          - Corrections to UNO objects, function & services help page
            
            Change-Id: Ia72f062c5d0ec07e61aa6b45caea31139acf561e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142199
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-11-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [490c2fc6080aa652b9b31385517aaf536f5bbd57]

        tdf#151174 Hide transparency widgets when not needed
        
        Regression from adc536e9efc77690df62177aa722f9252bdbf96b
        
        Change-Id: I42d64fafe170d08e14bb4fe087a3e628ac862e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142221
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-11-03  Tor Lillqvist  <tml@collabora.com>  [029e4e8a614a86f22bcafc0e2db55449d2b07a52]

        Accept macOS SDK 13.0
        
        Change-Id: Ieb4fac4e909482b477fd228b86cfd458ff00def5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142219
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-03  Stephan Bergmann  <sbergman@redhat.com>  [e0121b2478526d803681d57d59af0cbf9cf602b4]

        -Werror=dangling-reference
        
        In
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=d2249cd9adf5ae638577139177a50f7e62d8abd9>
        "c++: Implement -Wdangling-reference [PR106393]" grew a new warning, included in
        -Wall, and based on some more-or-less shaky heuristics, that warns about
        "possibly dangling reference to a temporary".  It produces quite a number of
        false positives, but for these uses of SfxItemSet::Get it does look plausible
        that the returned item references could, at least in theory, point at data that
        is destroyed along with the temporary SfxItemSet.
        
        Change-Id: I11afc4512db488f73170c6cfa706e9e094209550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142217
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d40d64da771427423786dc62a2f4ad08cab53179]

        swmodeltestbase: remove duplicated code
        
        parseExportStream is already in MacrosTest
        
        Change-Id: Ibde88b176db1521966b6877bda90e06c278c397d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142218
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [beceac5e0a2075696bbb267830ee952ade18da89]

        Fix typo in code
        
        Change-Id: I30dc89340942c1fc21a889e611b8a4510553476a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142169
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b27906ac8d246734d274a1624cc231f240e8b97b]

        Fix typo in code
        
        Change-Id: I3df6a2b0b6600d4d9e37723c902e03310aab22c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142171
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6f6ca6de08ab71bf02fa5fbc7364605ea5bb8117]

        Fix typo in code
        
        Change-Id: I3e4e076e8fc71d3999d5c58f05d34a866da3aa5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142168
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-11-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f73a779e33dd91fad0111629c6b3420c2c9aea0]

        optimize text fitting algorithm to correctly calculate the fit
        
        As we converted the chart stretching variable from int to double
        this can cause the text fitting algorithm to calculate the fit
        wrong. This commit changes the text fitting algorithm a bit so
        that it produces similar result as before the change.
        
        Change test testAutofittedTextboxIndent from 691200 to 712800 as
        the fitting algorithm changed a bit. Visually the document still
        looks correct.
        
        Change-Id: Ib75733360039d80a5aed836f757c3f8e8ec56d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142186
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-03  Miklos Vajna  <vmiklos@collabora.com>  [3b37482bf1fecd9e28bef454bc6a49a5c66c716d]

        sw: prefix members of BmpWindow, SwFieldRefPage, SwFieldVarPage and ...
        
        ... SwFootNotePage
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie665eca504a7092db68591942a527c671a151c3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142191
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-11-03  Paris Oplopoios  <paris.oplopoios@collabora.com>  [5c8934809ac60488d6160e27ff5962350c612a09]

        a11y: Add check for table used for text formatting
        
        Add accessibility check and relevant test for a document that uses a
        table for text formatting
        
        Change-Id: I20290a3ec89cd5333f3c66867b50aa7b80ed494f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142188
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [54ca50536e1c98f0bfe3b32d2a8c72668289e183]

        tdf#142888 Changing Tracked Changes accelerator
        
        Change-Id: Iba55f1aec8a4b3e5fe56a5dd0b3e4dc3e8a0c7b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142151
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [5beddf4c66c63cac050b4f32d2756c733c842d6f]

        tdf#148777 Improvement to Tip of the day 106
        
        Change-Id: Iea1304d314f6070999f5e3a778e4ea10d92c0688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142153
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [e272afb703ce3009f9c3edc43653771abd04c8fb]

        tdf#150605 Change "Measure unit" to "Unit of measurement"
        
        ... "Measure unit" is not proper English and should be changed to "Unit of measurement".
        
        Change-Id: Ic2bf24859fbf3b9b8f468d909afc99da643a026b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142149
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-03  Paris Oplopoios  <paris.oplopoios@collabora.com>  [766151ff6ec759563583abfa43f5bb3755ee2603]

        a11y: Add check for fake captions
        
        Add accessibility check and relevant test for a document that has
        fake captions
        
        Change-Id: If22999378fd7467151c1d400662858fe1cb0319d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141964
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-03  Bogdan B  <buzea.bogdan@libreoffice.org>  [3765f547cd701dfc69fa61b4948f9522140d457a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f129a53a423805628f95cf72469f48f5279147a6
          - tdf#134882 Improve help about changing label from 'fit' to 'shrink'
            
            Change-Id: Ie7759eea6991defbbb785b7426cddde7f1cebdc2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142146
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Tested-by: Jenkins
            
2022-11-03  Paris Oplopoios  <paris.oplopoios@collabora.com>  [a1ae31bd248ab62a0614f3a25f1abfcc214ff431]

        a11y: Add check for fake footnotes
        
        Add accessibility check and relevant test for a document that has
        fake footnotes
        
        Change-Id: I22682a161a858f45c956660a51849bd18fcee0e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141832
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-03  zonnebloempje  <alcamanximena@gmail.com>  [e519b121e3e43e4fd9e8e11c2ead4076ccda422f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Idf0a645bee9b2fc80bdf152c0703c3d25e3b330f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142189
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4c349be1d74c669e5804c3c43f3f0a3960c88bc5]

        fix rendering of text when "fit to frame" is enabled
        
        This changes the nStretchX and nStretchY from sal_uInt16 to double
        so the text in text boxes is rendered correctly (text should be
        resized to the same size as the textbox).
        
        Change-Id: Ic92d03043af0abe86f1b67ae15522d0176ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142064
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-02  Khaled Hosny  <khaled@aliftype.com>  [643fec7cf7a81bf8c89a8efd47c0310b38f9076c]

        vcl: add PhysicalFontFace::GetVariations()
        
        Use it to set the variations on hb_font_t, and we will use it for other
        things in later commits.
        
        Change-Id: Iae1861f74b38af4921ac97c1facecf0d4815c201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142024
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [29f318f90d2ed72a807d803094734d5ee7322a2d]

        Fix typo
        
        Change-Id: Ic658024df51bd53cb704af7c006ee5300c0922cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142170
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df62f6f32c1b4b3377e54cd0d2236b992c5398ce]

        Fix typo
        
        Change-Id: I7d9496020811edd0f86aaeb0c57e707b75c89fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142172
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [26fef1f99185c9ec4f0278e3aa6079011a164cba]

        Fix typos
        
        Change-Id: I097aec3699f668c60a7cb18e2ad412a45ce43ad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142182
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d60d9be3a01dac4a0758f251173d8c657c2a7b64]

        Fix typo
        
        Change-Id: If820dbb3d9232d84b0a830cbe950581190781547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142173
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c6dbb99dc629957b7276773c3c92b8721135d64e]

        Fix typo
        
        Change-Id: Icdd19c1165134867ed532c82a2663d1545c64739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142174
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [89022d5b6dc51e592e22bb8ff94c430ec14de17c]

        Try to fix "ERROR: Directory with flag ISINSTALLLOCATION not set!"
        
        This is a regression after my recent changes to Perl code in installer,
        most likely commit 8c6467a785037309d2a2cec56c8e38cf52da0aee, like seen
        at https://ci.libreoffice.org/job/lo_daily_tb_win/1213/consoleFull:
        
        > ERROR: Failure in installer.pm
        > ERROR: ERROR: Directory with flag ISINSTALLLOCATION not set! at C:/cygwin/home/tdf/jenkins/daily_workspace/tb/src_master/solenv/bin/modules/installer/windows/directory.pm line 334.
        
        I can't repro this problem locally; but as Stephan Bergmann noted,
        the mentioned commit changed logic so that a piece of code started
        to only execute for CREATE style, where previously it run always.
        
        This tries to re-create the logic prior to the mentioned commit.
        
        Change-Id: I01af06d58b26222bee6220cb9be61cf71940930f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142152
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-02  Caolán McNamara  <caolanm@redhat.com>  [698e56cf1fd453c4e175c762c3d427c52e68920a]

        also apply PaintTransparent to a widget's SubEdit if it has one
        
        Change-Id: If56e54929dd2ba988c2fa012370100378c2b2c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142175
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-02  Noel Grandin  <noelgrandin@gmail.com>  [4d863fd8e38748607636d0033262baa62a3e9eb2]

        tdf#54857 elide more dynamic_cast
        
        Change-Id: I42bef355eeef15e3733a5ee57b0569887cfa5e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-02  Noel Grandin  <noelgrandin@collabora.co.uk>  [1a4151dcdf45a0fa946b6ddf5e1b5cca37d24619]

        tdf#54857 elide more dynamic_cast
        
        re-arrange so we do the cheap checks before the expensive dynamic_cast
        
        Change-Id: Ief10b42894d15ab948e64c1189e0e7abf2c5a107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142177
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-02  Noel Grandin  <noelgrandin@collabora.co.uk>  [69910b540ae5140123fd2d4d67a9d338f980db53]

        tdf#54857 improve resizing of columns
        
        repeated calls to resize() means we bypass the normal doubling behaviour
        of the vector, so rather let it do it's own thing.
        
        Change-Id: I7b4273d20b6cdcac6aeddd61395fbe64de004c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142176
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-02  sahilbutoal08  <sahilbutola1@gmail.com>  [ac90933dde68c6daf1eeebabb55de6e361eb4995]

        tdf#143148 Use of #pragma once instead of include guards.
        
        Change-Id: I975ad0a41dbcf39121b266e99b466193386d6b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142046
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2022-11-02  Caolán McNamara  <caolanm@redhat.com>  [fc29f11d6e1737b26eb89efababc89cf700e0f05]

        upgrade to openssl 3.0.7
        
        Change-Id: I92eb4f6ce4c7eb38651ed94b9704ce10804e5224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-02  Justin Luth  <jluth@mail.com>  [ef4f3b565aa312a57dd75a6334c460d9a7df2650]

        NFC related tdf#112641: fix off-by-one-space formatting
        
        Change-Id: Id2cb33bf786e027f7f96dfddf330b83e47b0b1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142165
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-11-02  Stephan Bergmann  <sbergman@redhat.com>  [76560e670a36b1acc9429d1ea183422382c8bbe3]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e9da500c6d377d251368ee77b245a760e4ec0543>
        "Update to Freedesktop SDK 22.08" and
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e1eb85cfcdffa0dbba02c1d2e53c8f09e249b5d8>
        "Adapt build of gvfs to org.freedesktop.Platform//22.08"
        
        Change-Id: I7f3b228a5a15539e07555d6625d1eabff83a5f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142166
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [71703f3792e90c7ec6ed116cd734e23b0666afd1]

        SdUnoApiTestXml: simplify code a bit
        
        Change-Id: Ib213da0eed266e1b1f48284c71251d4c8c4da499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142167
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-02  Michael Meeks  <michael.meeks@collabora.com>  [d4b5689c18f9bc10e6b552ba7f20b0af2b36d170]

        sc: make InsertCell and DeleteCell async.
        
        Also enable them for use with jsdialogs.
        
        Change-Id: I378f228e86959edb98ad691089af919330dcdcec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142144
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-11-02  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [8304f44ce161f14094f724098004a1b4289685c4]

        Improved code for PolygonStrokePrimitive2D::getB2DRange
        
        For extended discussion & background information please refer
        to the comments added to the code there.
        
        Had to handle view-dependent parts like the hairline
        different, do not buffer that case. It could be, but it's not
        expensive and would require to remember and check against
        the view-dependent part which was used to create the
        B2DRange initially.
        
        Change-Id: I10df46207990865c667d41f56aedb8f0956a1706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142114
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-02  Noel Grandin  <noelgrandin@gmail.com>  [a6cf6ac1f6df02c9fe733858f2aae866ffd38569]

        tdf#54857 elide more dynamic_cast
        
        Change-Id: I0cbdb2ee46600559d9a37f09b574d484e72a0e0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-02  Caolán McNamara  <caolanm@redhat.com>  [965ffbf0c22a1ad780ad92e2e7c54522d9e6a7d0]

        use a narrower cursor, the wide one feels out of place
        
        Change-Id: I2816dc162986cd426654673fefd4e0e0171aeb01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142162
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-02  Caolán McNamara  <caolanm@redhat.com>  [9762f8d30e30b6e79d18517a14d844aac34b02a0]

        color is meant to be the same as the popups color
        
        which is FaceColor and not FaceGradientColor as far as I can see
        
        Change-Id: Icc3b874ac2e31845df2f017446dc85efd9aaed59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142161
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [5c5a2377038901204ec23e588f11e3592b1bea08]

        Simplify LokStarMathHelper
        
        SfxInPlaceClient seems to have everything needed to check the OLE
        bounds; OTOH, the embedded Math windows/widgets lack that info.
        
        Set SmGraphicWidget MapMode to pixels when lok is active, as other
        windows do.
        
        Change-Id: Ib9b76a51a2d9253c20b782e8c53fbfa5dc776eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142130
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-11-02  Jean-Pierre Ledure  <jp@ledure.be>  [985c77b570807dcc558ccff4a51430fe489b68fd]

        ScriptForge = (SFDatabases) New Datasheet service
        
        A datasheet is the visual representation
        of tabular data produced by a database.
        In the user interface of LibreOffice
        it is the result of the opening of a table or a query.
        In this case the concerned Base document must be open.
        
        In the context of ScriptForge, a datasheet
        may be opened automatically by script code :
        - either by reproducing the behaviour of the user interface
        - or at any moment.
          In this case the Base document does not need to be open.
        Additionally, any SELECT SQL statement
        may define the datasheet display.
        
        The proposed API allows for either datasheets
        (opened manually of by code) in particular
        to know which cell is selected and its content.
        
        Properties:
          ColumnHeaders
          CurrentColumn
          CurrentRow
          LastRow
          Source
          SourceType
          XComponent
          XControlModel
          XTabControllerModel
        
        Methods
          Activate
          ApplyFilter
          CloseDatasheet
          GetValue
          GetText
          GoToCell
          OrderBy
        
        The Base and Database services are enriched with the
          OpenTable
          OpenQuery
        methods. The Database service gets also a new
          OpenSql
        method.
        
        The whole set of properties and methods is available
        both for Basic and Python scripts.
        
        This new service requires a new help page dedicated
        to this service, as well as an update of the
        pages about the Base and Database services.
        
        Change-Id: Ib409ce74d95de78f2792ba53e7ae554eab0867ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142118
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-11-02  Tor Lillqvist  <tml@collabora.com>  [4f88a1d624a97f53b58d3cdf36b2f5cfc237da59]

        Use o3tl::to_underlying() instead of static_cast<int>()
        
        sberg says it is better, and I trust him.
        
        Change-Id: I32b343cd899f807c0eb803e74e856b0eb9610074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142132
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-02  Bogdan B  <buzea.bogdan@libreoffice.org>  [c4f5d456e5801843f00a43afd9c0fa43c412d265]

        tdf#134882 Change label in the dialog: 'fit' is replaced with 'shrink'
        
        ...because shrink is the only effect of this option to the text.
        
        Change-Id: I63783c05ac92803a6de6581d858590904a9e8275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142138
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-11-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [7ebe087187f781bc260869ac5b7c59a2a19f21cd]

        update credits
        
        Change-Id: I33892b5bee2d043704c69b088bcc84217ca28099

2022-11-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [cd6139a8e4e379bc169870c94f1ce0179428a901]

        Update git submodules
        
        * Update translations from branch 'master'
          to f6436b0f3e3f70746ee67f123d0b381a46c693de
          - update translations for master
            
            and force-fix erorrs using pocheck
            
            Change-Id: I422740bec6c2dcb24e97e9c32328ee37d2c2cc7e
            
2022-11-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [6410b6f1251d52cc3d6eea7c7c49a009a7ec7025]

        CppunitTest_sfx2_view: inherit from UnoApiTest
        
        Change-Id: I5a2d62fde3e14bdd47b4d7d3511a30cbd1629b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142125
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-02  László Németh  <nemeth@numbertext.org>  [b652ebda7fa4e6c8db2f934bf4c8d2927f5c2332]

        Revert "tdf#151622 PPTX: fix export of show as icon option"
        
        This reverts commit ea62cacd129f03813d7d3d214bf9aa2ae60bbef4.
        
        Reason for revert: not declared macros ODP & PPTX in unit test
        
        Change-Id: Ic2c3a39ff36401f49f3d759eb60645ed239b1d4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142142
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-02  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [f397ebce379861987b7be28cc8371cdefef7ebdc]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 81c820ae2e0f447d3bd71855c3bc7e8912740d11
          - Updated the English dictionaries: GB+ZA
            
            Change-Id: I0926be0ea79af8d4f4a592f694792c3d7733693c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/142008
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-11-02  Tünde Tóth  <toth.tunde@nisz.hu>  [ea62cacd129f03813d7d3d214bf9aa2ae60bbef4]

        tdf#151622 PPTX: fix export of show as icon option
        
        Embedded OLE object wasn't look like an icon after its opening
        because of missing showAsIcon="1" of p:oleObj.
        
        Change-Id: I21dbd1e31f7e1de78d8bf548ca6f3619eb3e4a10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141505
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-11-02  Eike Rathke  <erack@redhat.com>  [71081a2a79a7b5a1eefec60fc687c533a95d190d]

        Resolves: tdf#147141 style:header-first/footer-first only ODF 1.3|1.2-extended
        
        For ODF 1.2-extended write with loext namespace, for ODF 1.2 and
        earlier do not write them at all.
        
        LO versions <7.2.5 not having the fix for tdf#144940 need ODF 1.2
        written (without header-first and footer-first) to not lose the
        header/footer.
        
        Change-Id: Id856459eac487ddd8ba0c6963db5d4e227d82093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142127
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [65b33494e5de6bf77c9511af95f811410cbb3d4e]

        CppunitTest_sfx2_misc: inherit from UnoApiTest
        
        Change-Id: Ib3eff92f9e9e84afb3953991bd453ec5e9a4cef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142124
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e76cc516135736d2ae1cfe3c178cacd05a7abbcc]

        CppunitTest_sfx2_classification: inherit from UnoApiTest
        
        Change-Id: Iab05ead4aecc619c41cac7cfcfa8e3f57ef21601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142123
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [94437397f544a0ffaed52b2def13870881138ce9]

        CppunitTest_sfx2_doc: inherit from UnoApiTest
        
        Change-Id: Ic28ffe09bfc79ca3b254bd060f43eae289e7b488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142122
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Laurent Balland  <laurent.balland@mailo.fr>  [b4b4c53cf95142e450363ad241d7c65c62381b87]

        Update extras/README
        
        Follow-up of simplifications of makefiles by Christian
        and new merge makefiles for all templates
        
        Change-Id: I37b81f1371c306c26dd2009835a616dab37ee726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140537
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2022-11-01  Noel Grandin  <noelgrandin@gmail.com>  [4e24efb563cbe6fec4185b4f7ec3755b2fc05b6b]

        tdf#54857 elide more dynamic_cast
        
        add a helper, following the same style as the ones in sw/
        
        Change-Id: I13c673bba5ff47df6beef9d90c200e5801030cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d2a6bcd6a9430cbd5522c1a0e367e422b679cfd3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4de3a5df9563bb86b7295664b579efd79169d92e
          - Add Insert Slide/Page dialog in Help page
            
            Change-Id: I6704035838bb0017530723b2953c794cc7160d18
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142121
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-01  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [296a8ef5cab17e576de7aa0d89bf5f7c7de3070f]

        Add support for .NET Framework 4.8.1
        
        Change-Id: I9d719c1c5ad36579638882cf09dabaee812c015e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142113
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a2e8bdd9760fd5a5b4b714fa65e0ec78217d4942]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2679c2fbbcc92a6c95bf41316dfa64426e31e195
          - Add Duplicate dialog screenhsot to Help page
            
            Change-Id: Ifeca493a77b8d01a18d203ce7b385bde38079e7b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142120
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-01  Stephan Bergmann  <sbergman@redhat.com>  [c8fd1fb5535f2d8260d593631f77f1d2ed01b237]

        -Werror,-Wunused-macros (clang-cl)
        
        ...which started to hit me now either due to building against a recent Visual
        Studio 2022 Preview 17.4 (which would presumably no longer define those macros
        in some system headers, so that the #ifndef's started to kick in now), or due to
        building against a more recent Windows SDK (see below), no idea which.
        
        But just dropping the seemingly unused macro definitions from the various .cxx
        caused builds against old Windows SDK versions like Jenkins
        <https://ci.libreoffice.org/job/gerrit_windows/139228/> to fail like
        
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(479): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(480): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(481): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(482): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(503): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(504): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(505): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(506): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(667): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(668): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(669): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(670): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(691): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(692): error C3861: 'max': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(693): error C3861: 'min': identifier not found
        > C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\GdiplusTypes.h(694): error C3861: 'min': identifier not found
        [...]
        > make[1]: *** [C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/solenv/gbuild/LinkTarget.mk:334: C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/workdir/CxxObject/vcl/win/app/salinst.o] Error 2
        
        so move those macro definitions to prewin.h (where they don't trigger clang-cl's
        -Werror,-Wunused-macros from within an include file, even if they happen to be
        unused in a translation unit).  (For simplicity, see whether it works in
        practice to drop those #ifndef wrappers.  If they turn out to be relevant for
        some build scenarios after all, they can be added back.)
        
        Change-Id: I76d8794ae2de310bdca420e5488db2bc19de23ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142090
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e27d4016f0c0987c44641302b975dcdf8413cd6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bb39fe1f9558948f5b3bea3e6bf2841dd475fad6
          - Fix missing link
            
            Change-Id: I8d6d6df9807b69a1e27c77e4e420b4c5245d433c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142117
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eaf9b9ee9e40f12dc1b541d54f2f9f051ca3dff2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b723a911f7c94bf5bc3711100e1454341d6559ab
          - Refactor Bezier toolbar help page
            
            1) Convert icons to svg, increase size to 1cm
            2) refactor headind
            3) improve alt text
            
            Change-Id: I739b4c7bc7d33567461411913242bae3e53282a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142116
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3fddd85377ed3ab2d0830a42b8667cd843b9d4d]

        upload_symbols: Clarify parameters
        
        Change-Id: Ia9034e18753541f15f29ea7d48f2334b0e50d538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141221
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Noel Grandin  <noelgrandin@collabora.co.uk>  [e9920a67886a930c327776ad8f7736e214ea0e98]

        tdf#54857 elide dynamic_cast
        
        shaves 2% off load time of this ppt
        
        Change-Id: I025bae9dbc6a01cd193e2a4721f50cf60ac08dc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142112
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [4bf4e9600c5e723db299817e549b6d3f7b6572f1]

        CppunitTest_writerfilter_dmapper: inherit from UnoApiTest
        
        Change-Id: I342085e3c0e31794e0ec08f3b26ccf17caa8d2d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142097
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c44760ee609e23b830b3e91d930518ce3289a4a0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fe027ad1a10e233c540c6e873c737b5bb2a9039c
          - Add To Polygon screenshot to Help page
            
            + refactor relevant pages
            
            Change-Id: I3759f2d86df0cd66913d11a7d2711614315e24a1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142115
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-11-01  Caolán McNamara  <caolanm@redhat.com>  [b057e97e910b2ee211d3c4fe74dc2a6f37296ba7]

        use https instead of http
        
        Change-Id: I41f48fd806d56f62d5e16d8f2530e63385eadddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2f7f551dcc9aa9e8e4d0b5f004962340c01e4c8]

        CppunitTest_svx_styles: inherit from UnoApiTest
        
        Change-Id: I3edd6e41e12efb4876f632edc66ae198d26ac944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142095
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Stephan Bergmann  <sbergman@redhat.com>  [1fcf4d0565d83498183bd778b8fd76612d680466]

        Fix ambiguous member lookup (clang-cl)
        
        > vcl/win/gdi/salbmp.cxx(179,9): error: member 'getSystemDependentData' found in multiple base classes of different types
        >         getSystemDependentData<SystemDependentData_GdiPlusBitmap>());
        >         ^
        > vcl/inc\salbmp.hxx(138,24): note: member found by ambiguous name lookup
        >     std::shared_ptr<T> getSystemDependentData() const
        >                        ^
        > include\basegfx/utils/systemdependentdata.hxx(107,39): note: member found by ambiguous name lookup
        >         SystemDependentData_SharedPtr getSystemDependentData(size_t hash_code) const;
        >                                       ^
        > vcl/win/gdi/salbmp.cxx(217,9): error: member 'addOrReplaceSystemDependentData' found in multiple base classes of different types
        >         addOrReplaceSystemDependentData<SystemDependentData_GdiPlusBitmap>(
        >         ^
        > vcl/inc\salbmp.hxx(147,24): note: member found by ambiguous name lookup
        >     std::shared_ptr<T> addOrReplaceSystemDependentData(Args&&... args) const
        >                        ^
        > include\basegfx/utils/systemdependentdata.hxx(106,14): note: member found by ambiguous name lookup
        >         void addOrReplaceSystemDependentData(SystemDependentData_SharedPtr& rData);
        >              ^
        
        Change-Id: I8b8d034e4e3a0bcd4462f3b28246b219632960ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142089
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-01  Tor Lillqvist  <tml@collabora.com>  [e99a09f857b1aa4a98052dc9dd79eba70186bcff]

        Make exception message a bit more informative
        
        Change-Id: I61141eab37f07d012ff2c5033efdfa1e0126786f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142075
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-11-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [a73f3b2df5ccb307609cf15db58251a859495f6e]

        tdf#142172 Use darker document background color
        
        As discussed in the ticket, this patch switches the AppBackground and DocColor in the "LibreOffice Dark" color scheme, so that the document has better contrast with the text.
        
        Change-Id: Ic15788acba423cf2fda48b6a70df41844c98d46d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141850
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c018651a0667ecdb0f9b31d2b0c53c646f990cd]

        CppunitTest_lotuswordpro_import_test: inherit from UnoApiTest
        
        Change-Id: I6287ea3b0ed24a8dca002b95d59120ce302fc2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142100
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [39ed6101c95368697bfaedf73f070129b24d03c9]

        CppunitTest_emfio_emf: inherit from UnoApiTest
        
        Change-Id: If1278f336aaff56a4378dcc1f0f95e0a749b629d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142099
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [4e5df4c2777df3dcddffe0efdfceca55b3101bdf]

        tdf#143377 Handle nAttrRotate and Skew more backward safe
        
        Change-Id: I51aad9d1dc1f792bc86ac6793308bd5be1aecfee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142098
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-11-01  Stephan Bergmann  <sbergman@redhat.com>  [f312256a93b282e041a45c9dfef836220f996432]

        -Werror,-Wunused-variable (clang-cl)
        
        Change-Id: I8887a8c151f628c65bb24e63b03893c7b27c0c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142088
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [85a5233275ab83fe0d6b943b298695387d97accd]

        error when copying table and the copy table wizard creates the primary key
        
        then the primary key will not be IDENTITY column, and the
           ALTER TABLE...RESTART WITH
        will product an error
        
        Change-Id: If17bd0cbfe3519f9074aebb819b7d85ccea63e1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae86dfdc05545ca4ec67f0434737baa92892b79f]

        tdf#126788 inline the SwXTextRange into this call site
        
        Change-Id: If91b5e952152fdb829ff936f2f82b4c5e6aa7bea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6c89e04f569a9d9bda8cbf1d4af4c06e0c16147]

        CppunitTest_writerfilter_rtftok: inherit from UnoApiTest
        
        Change-Id: I24dce2b743a2c2d1a7cc96b8d7833bde0ab385d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfc8a8f5d841b3f84d207196153be67da7f60652]

        CppunitTest_svx_core: inherit from UnoApiTest
        
        Change-Id: I4e7cdd1507232d48eba7c4afc599adf8da7a3df7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142094
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc770e44c1e8c9686f0eb7eac49dd42717fb494f]

        CppunitTest_svx_unit: inherit from UnoApiTest
        
        Change-Id: I12e6032c178039eb7b87a1ef063a69c63a0f814b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142093
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-11-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8ec62a84c84d818d01cd3e6dcb874e1a801512c7]

        editeng: rename aBuf to aCharPositionArray
        
        Change-Id: Ie7614ee9eefe1160f6d1e6105cc5bf7b92a35cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142063
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-11-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [746f710d693a10daf48b5cb5a4f6082d2dafa49a]

        tdf#126788 elide OUString construction SwTextNode::InsertText
        
        if the node is empty, we can avoid the cost of constructing a new string
        
        Change-Id: I5792fc0a80019008c4e7f458d4472405123cdeb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142083
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-11-01  Jim Raykowski  <raykowj@gmail.com>  [f8bed5288656575e6f23923bfbd648bfd00c39a6]

        tdf#142446 follow up: Fix missing ui file crash and a11y ui errors
        
        I somehow missed adding the locally changed .mk files to commit
        5f72a041c0160e4067ca931a9cec711b84b558f4. This patch also fixes gla11y
        reported a11y errors in the UI file and adds a help message to the
        dialog.
        
        Change-Id: Ib095b59f12571d53888916b26914fa99dd82979a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142087
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-31  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [f7f0f39968e7b5630364d16d01c13ee015633be7]

        Translatable string fixes
        
        Change-Id: I8dd8f70dd7c522d60dbd69cea8c78773d6dc2ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142085
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a30c5d278a0785bf7a8d19ff9e5e86ad97566ea0]

        Fix typo
        
        Change-Id: Id77aa9674c4a7461ed4adbbeb70778d3800c113a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142068
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9119dc8eaba96553037739650079e7def298e15b]

        Fix typo
        
        Change-Id: I5090a74ff98240821555ce749316df3721da4a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142067
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [a4da4dc147df0f753a08a6bd302c86d3bc591229]

        sd: Simplify code
        
        Change-Id: I507064c9543729473fed41f1463e09146e31a715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142074
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [753d1aa82b0c76e7f5e160c935ba2ca84b1c9e2c]

        sdmodeltestbase.hxx: use clang-format
        
        Now that the file has shrunk in size
        
        Change-Id: I6e9e245cd332c225eacc7ceca1be6d533bf58187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [95075e5296776f5d1b528d6d3c26f5337ad8e9a8]

        SdModelTestBase is now unused
        
        Change-Id: I34eee3f0159d7779161ecacdd6cf0aa69a670ca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142079
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [f48c2fd1cf4a9fbc8e861803119ba7376201f71f]

        CppunitTest_sd_import_tests2: inherit from UnoApiTest
        
        Change-Id: I64e810a67a394ee6daa555567a741d037b66db60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142078
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae323dfc4c031289d341a4152fc756c1433ea2e1]

        tdf#126788 inline createTextCursorByRange into this call site
        
        Change-Id: I1ee91ff56f4c5e0c0182f67a9c321e914ec6cd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142039
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c1ed3d4396400e2be30c74a6c9af89cf4cc80b7]

        tdf#126788 inline CreateParentXText into this call site
        
        Change-Id: Ib2defa8789180924405f29432736f7e03f80b9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fc92f32d8b96d046f5da15adb1f669e5777c372c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04549b13ac062594e2204a8f8da7bf92ec290995
          - Improve Help on Draw layers dialog
            
            Remove modify_layer.xhp and merge with insert_layer.xhp
            
            Change-Id: I6500aae19a7f4745ee94f7dffc664df724b568db
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142084
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [21f8a8e42395171ab33c5b84642b7f2f4e0ce71e]

        CppunitTest_sd_import_tests: inherit from UnoApiTest
        
        No need to have compareWithShapesDump in a different place,
        it's only use in one place
        
        Change-Id: I539950ce0749f1f0231f5770cd63549a0299341a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142076
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [621a53cc24a613e75814a78905df49c12bb32856]

        ofz#52898 bad cast to SwXMLImport
        
        fallout from
            commit 2c4aabb220ad1e8f1cbc75f2361fe17893d7cc29
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat Oct 29 11:11:36 2022 +0200
            tdf#126788 speed up GetDocFromXMLImport
        where the prior UNO_QUERY code was hiding this problem
        
        Change-Id: I21efc27f4b04acb38138d2d44e207d5a6b9cb9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [78c66e1aaf353a6a30d53c071f9313b6b2d1b9d4]

        CppunitTest_sc_macros_test: simplify code a bit
        
        Change-Id: I419f5a0c09643455be992f68b72f4903cfe98a9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142080
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [07f8666254e459bcd880b5bc4314b1af404d0a6e]

        fix regression from "editeng: don't use GetSize to set the size"
        
        Params are swapped since
        
            commit 190cd40e01bd36e99b265ef5da36a382199f18b9 (HEAD, master)
            Date:   Tue Oct 18 21:14:41 2022 +0200
            editeng: don't use GetSize to set the size
        
        Change-Id: I0a3fce0c8325fa59c385fa2e45a53215853e351a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142077
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2022-10-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [bed4d8f1eb32a39bfce5c7fa8546dbab155706a7]

        tdf#150465 Improve description of RANDBETWEEN in function wizard
        
        As requested by the user, this patch makes it clearer that both Bottom and Top values may be returned by the RANDBETWEEN and RANDBETWEEN.NV functions, making the Function Wizard and the online Help descriptions more similar.
        
        Change-Id: I730a9a5e42525f890c85c2489ef03797b812917a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141922
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-10-31  Emmanuel Peter  <awinspeters@gmail.com>  [d5736c124223e77d5a8d67c8c95bf141ee74ab5b]

        tdf#141339 Use pragma once instead of include guards
        
        Change-Id: Icea246369ca215745e4b1ca1764bedb83123409e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141339
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [73e04e9435da6cf0c809ef00ec7f70a0ad734852]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ace4c64188685b2fb3abed212ddb134ceddb885
          - Add screenshot for Help on Snap dialog
            
            Change-Id: Ie960428b391f71b354ccb97d643978cbf6d42e67
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142049
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fbc735eafd524c97c9ad5c1e1b2399b6838d8673]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3962eff25dac38ed1422845c47a0ace437a3772a
          - Add Insert Layer screenshot in Help
            
            Change-Id: I8ac8024ff5f2dad893248fe75566ab152e72a762
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/142048
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [645fb4b6bd982b7d0f1a6a6becdb8c5d2049eeb7]

        Add  Properties area in insertlayer.ui dialog
        
        Help pages for Insert Layer mentions a Properties area in the
        insertlayer.ui dialog.
        
        This patch adds (back?) the Properties area in the dialog.
        
        Change-Id: I502b1aa055519a32c7747c11b813b3727421e28e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142045
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [abd4902dfa55d743cc9878bfcab12beb12e83400]

        CppunitTest_sd_import_tests: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: Ia668d371637e23ceba19984ca622f4e57a74aeca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142073
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f8d457073f371592e57945ced6922ceab6036ce]

        tdf#126788 inline CreateXTextRange into this call site
        
        Change-Id: Iba3c0a35ebd9e1c6e639cde79225c3ab896bc97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142037
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [61d907f808702850fe169de8eaf7421bb3951169]

        CppunitTest_sd_export_tests: fix build
        
        6f32f1a12be06c4da92b807d8a35cb079984e26a
        "tdf#72238 xmloff,sd: Import of <style:table-cell-properties>"
        and
        c66def668e43bb40eee54fe91e752ba1330cb911
        "CppunitTest_sd_export_tests: inherit from UnoApiTest"
        were merged at the same time, breaking the build
        
        Change-Id: If856edab62c2ef31a2dbfe6c5315f51fde0bd031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142072
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5a487832820cd1f82d3f5dd73aa22045e805917]

        CppunitTest_sd_tiledrendering: inherit from UnoApiTest (part2)
        
        Change-Id: I541eb1f119c37c263814a9a5c7944461220b11e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142070
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [a4c8658964c129a00aea151da00db6b447b7ffb3]

        CppunitTest_sd_import_tests-smartart: inherit from UnoApiTest
        
        Change-Id: I4ef95f3899cc67aaba0d9d657341890b3cb73fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142069
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [190cd40e01bd36e99b265ef5da36a382199f18b9]

        editeng: don't use GetSize to set the size
        
        Change-Id: I80a2701d7c125dbe6c80f8c32b125c7b176a8bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142062
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9f02ccb4b4fa891e9e74e320d9ca0da40b1a626a]

        editeng: prefix the instance variable aDefFont-> maDefFont
        
        Change-Id: Ie9d18c19792962159e4e2ff4ddf91560323e42e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142061
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-31  Henry Castro  <hcastro@collabora.com>  [f43a5ec28d36422c105da3d640bf94ad9c8a2ba6]

        lok: fix convert-to batch mode, quiet interaction
        
        If it is a batch mode to convert *.csv to *.ods,
        use the quiet interaction to avoid unwanted filter dialogs.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I4ef82c1079888ae099084072c146b5db4cc0f2a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141950
        Tested-by: Jenkins
        Reviewed-by: Ashod Nakashian <ash@collabora.com>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [291783343073bb726ea0292ee6f0fa0cc09abc5b]

        CppunitTest_sd_activex_controls_tests: inherit from UnoApiTest
        
        Change-Id: I6c1e25f235e8a5c67b0e098660a29dc154fe9962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142065
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f57a02c5aabbc09cfd6c912d211d21a748abc88]

        tdf#126788 return concrete type from CreateXTextRange
        
        to make it easier to optimise call sites unnecessarily creates tons of
        these
        
        Change-Id: I39bced82ae03fe33dbf0592f384332ab49f914fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142036
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [6baffb816eb2b5b4223059c3bfadb8d3d8cac7d0]

        SdModelTestBaseXML is now unused
        
        Change-Id: I2bd3cced5a7dd96840190f42c1ce2cbd94533206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142060
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [c66def668e43bb40eee54fe91e752ba1330cb911]

        CppunitTest_sd_export_tests: inherit from UnoApiTest
        
        Change-Id: I08bc56eeb4e5e67da1c79c489ffc002b6a1e2fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142059
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-31  Regina Henschel  <rb.henschel@t-online.de>  [cf972fb9856957f4444199eb97464b83d8dc2698]

        tdf#113187 exclude angle conversion from count of maGuideList
        
        The ooxml import uses the special viewBox value '0 0 0 0' to indicate
        that the point coordinates are relative to shape size and not to
        viewBox and need special treatment. To detect this case the number of
        guides in maGuideList was used. But that number might be larger than
        the guides in ooxml because each arcTo command introduces two
        additional guides for the conversion from 1/60000 degree in ooxml to
        degree in LibreOffice.
        
        The patch excludes these guides from count. Thus now a path which has
        no references in its points will get a viewBox with non-zero width
        and height in all cases and is rendered now.
        
        Change-Id: I410638a1fe02f692fd46313c88b5ea518f1d094f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142050
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-10-31  Maxim Monastirsky  <momonasmon@gmail.com>  [6f32f1a12be06c4da92b807d8a35cb079984e26a]

        tdf#72238 xmloff,sd: Import of <style:table-cell-properties>
        
        Handles fo:border*, fo:padding*, fo:background-color and
        style:vertical-align attributes.
        
        Export is unchanged for now, as older versions still
        can't read this, and on the other hand we probably want
        to keep the import of the wrong attributes for the long
        term, to not break existing documents. Also, we can't
        fully export fill properties anyway because of tdf#103602.
        
        Change-Id: I8687507b98602ffcd05adb2087c894bb45aa3c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142058
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-10-31  Noel Grandin  <noelgrandin@gmail.com>  [1dc8b2b9ce4c5cee03c5fec49658fa363a00341b]

        simplify logic
        
        we know bSearchUsed is already false here. It has been this way since initial commit.
        
        Change-Id: I598b02fedaa71f07d6f24928c5b9d56761970e3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142055
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [604f6fc8fe7438f7cfbcfc8a3107ace59e950627]

        tdf#143377 Correct maximum Skew for TextOrientation in Calc
        
        For zero or 180 degree text orinentation errors can happen
        in the Border visualization, theoretically also in the
        Text rendering. Ths has to do with sin(0) and sin(180)
        being zero and lead internal to numerical problems, e.g.
        a very huge Skew that when applied show the reported
        'errors'.
        
        I limit this mechanism now to +/- 1/2 degree from the
        critical mentioned places, for Border and Text - to
        not risk to have different points of corrections. The
        UI only allows angles of 1 degree steps, but UNO API
        and pdf import may allow more.
        
        Change-Id: Idbc68f6a7beab84df0672165c2a813d96eeff84e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141999
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d3caee0a7af6d184e950414d880be29cbab60498]

        Revert "tdf#126788 replace dynamic_cast with static_cast"
        
        This reverts commit 32b0b79c3f71e4aca995aa92ee519d93a3ca2b3b.
        
        Reason for revert: apparently sometimes we can have a regular SwPaM here?
        
        Change-Id: Ib09028a8ca565cea35defba5783ca4f869c59c55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [92cd851c924486829aa7592ee41a62d2d97b755d]

        tdf#126788 only call TotalCount() if we need the result
        
        Change-Id: Idcacc67f005204ac499f8cdff2792e97636ae85c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [7fc2aefc09956bee0353575d2bacca2d5b556b04]

        tdf#151654 related: dereference after nullptr check
        
        pPV nullptr has appeared in commit 6fcee31ed5e1dadcbf9614967592ff188a250007
          Date Thu Jul 02 14:28:15 2009 +0000
          CWS-TOOLING: integrate CWS aw065
        
        but it was still dereferenced unconditionally after that.
        
        Change-Id: I4a9ec2345e4093673eed092f6ddb16ee21b9d00f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142054
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-31  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [66940d33b7098d6709ff83917ae1575c691c54ab]

        tdf#151071 Sifr follow upstream: Form Control, Record, Cell Styles, Shadow
        
        Change-Id: Id939ddaefc435778fcd8ae17112875b698903b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142051
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-31  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f6710ac0f1444a8d399fbcef9ca853e727606658]

        tdf#151837 Sifr: Icons in Left Area of XML Document
        
        Change-Id: I6ca99b08145c0bb7f1151e11203dc0edba788f26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142052
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [060c529c9c450ddc22912ee88af5305c1fd063f3]

        tdf#129610 SdNavigator: Realize multiple selection of objects
        
        This enhancement patch makes possible, mutiple selection of objects
        in the draw view using the Navigator page/objects tree. Standard
        multi-select mouse and keyboard methods, Ctrl/Shift + mouse button/
        keyboard navigation keys, seem to work as expected with gtk3,
        x11, and qt vcl backends. Double mouse click and the Enter key, moves
        keyboard focus to the selected objects selection frame. Single mouse
        click and keyboard navigation keys select the object in the view
        while keeping the keyboard focus in the Navigator tree. Patch code
        done to make navigation to empty name objects, commit
        f0878173e1963cf8db5f60ced6d19da24e18bc41, is moved to the
        SdNavigatorWin selection object handler, ClickObjectHdl, by this
        patch.
        
        UITesting:
        TreeListEntryUIObject "DOUBLECLICK" action change:
        Multiple selection as implemented in this patch, requires the tree
        list entry to become the cursor entry when selected.
        
        Change-Id: I58a36117242e40ce2811488c1fa8ef2aa72b28e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141440
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [824b70fc473f96fca480f3d0d64f63234666db2b]

        'use strict' and 'use warnings' in all installer Perl
        
        Change-Id: I6068b795a7dfac24651c8e4a100f78dbee11f98b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142044
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4179e78290bec9b72688e069547350968e76c9c5]

        Bump glade release for sd/.../insertlayer.ui
        
        Change-Id: Iccc52cefcd8de0586dc3c20a8da04ff68b54b7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142043
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [814cc6e8a30bde58adfb9f114c435dcb11c1e013]

        tdf#126788 reduce number of comparisons to query XUnoTunnel
        
        Change-Id: I581fa6944f9da9195651bacd2f11fd7f35967ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142041
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c11acfa916302e2af9ecc4c1657ac7461148bfcf]

        tdf#126788 avoid temporary Sequence
        
        Change-Id: Id2cc39529aa26429e929704271db450abe6bd1e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Alain Romedenne  <alain.romedenne@libreoffice.org>  [86dc2ad184e9eb1a3b69f90ad41f257efd727ec9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 021a444733a8022967b374642057d2032318634b
          - tdf141474 CreateUnoService accepts keyword arguments
            tdf114263 CreateUnoServiceWithArguments new help page
            
            Change-Id: I217746d0817cefcaab7ecb07d30b2c3f2ad8bfff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141916
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-30  Regina Henschel  <rb.henschel@t-online.de>  [4d15adebcc492112ca88e36aa7e8799b62d86466]

        tdf#151818 xlsx SmartArt import, apply theme text color
        
        Similar as patch 2406ba67 for tdf#54095 but now for import of
        SmartArt objects in xlsx files.
        
        Change-Id: I12ca8c476fb9d141cef991e8e98ad13b53c70613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142027
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [347fa47507fce9758b60d9126a1beed04c45dc35]

        Fix errors in scriptitems.pm found by 'use strict'
        
        Besides some stylistic changes (adding 'my' in due places), this
        fixes two errors:
        
        1. An omission from commit cb02ea85db6f38b792c17f5f971f81a28b595b4e
          Date Fri Oct 13 09:36:29 2006 +0000
          INTEGRATION: CWS native62 (1.28.42); FILE MERGED
        
        not passing '$allvariableshashref' to 'replace_userdir_variable',
        and so using a local empty variable instead, ignoring custom value
        of LOCALUSERDIR in *.lst;
        
        2. Use of wrong scalar variable '$alldirectoryhash' instead of hash
        '%alldirectoryhash' in 'collect_directories_from_filesarray', from
        commit 8c6467a785037309d2a2cec56c8e38cf52da0aee
          Date Sat Oct 29 23:38:12 2022 +0300
          MSI: fix handling empty directories
        
        which resulted in the loss of empty directories found by that call.
        
        Change-Id: I126575a51044186bc6c7fdf898942abf71ddb4b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142034
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd14cd07b9252cab0f23949043ae93b9fe85b5c0]

        tdf#126788 avoid temporary vector
        
        Change-Id: I9b87ed48fc03ca8d2de862568b560eade788514d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [e97e3ea3a2545a1b1d962eca95045b6da232f204]

        tdf#126788 fetch node index once here
        
        Change-Id: I5991dda00879b55090a8353001ce341a2360fab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142031
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7bb0a1fd6896df5b13b91f63f05296174764394]

        tdf#126788 no need to dynamic_cast twice here
        
        Change-Id: I78ce9bb7a56d99fcfdb2e705898991995368a079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [24a2c65e7ea15166061d96352164b51c5ffd9fa8]

        tdf#126788 use singleton to avoid initial allocation
        
        Change-Id: I55011cdd3e6c457c6ab91d90579ace3524a9889d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142029
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3329c10cca25eb393430d9d9f10ebd9e3c1240b]

        tdf#126788 check for listeners first
        
        cheaper than the WeakReference check
        
        Change-Id: I2caaa80ed1f68c840758db2ad1fb97237606bbf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [8c6467a785037309d2a2cec56c8e38cf52da0aee]

        MSI: fix handling empty directories
        
        Such empty directories are added e.g. by setup_native/Package_packinfo.mk
        when using these configuration:
        
          ./autogen.sh --with-external-tar=/cygdrive/c/sources/lo-externalsrc --with-junit=/cygdrive/c/sources/junit-4.10.jar --with-ant-home=/cygdrive/c/sources/apache-ant-1.9.5 --enable-pch --disable-ccache --with-visual-studio=2019 --with-jdk-home="C:\Program Files\Microsoft\jdk-17.0.4.101-hotspot" --with-package-format=msi --with-ucrt-dir=/cygdrive/c/cygwin64/opt/ucrt/
        
        Making after that produced this error:
        
        : *****************************************************************
        : ERROR: Reading from filehandle failed at C:/sources/core/solenv/bin/modules/installer/windows/file.pm line 967.
        : *****************************************************************
        
        because it tried to create MD5 hash of a directory.
        
        Change-Id: I7d2a6dc989f823fabaca1bef07a68ba964ffe34b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142026
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [9f0103b3a1ca6dcffcf064736b57d4bf7bbd887b]

        SdNavigator: Update selections on shape filter callback
        
        Entry selections in the tree are cleared when the shape filter is
        changed. This patch updates the tree selections when this happens.
        
        Change-Id: I9b365e6898b1d5c7f45870541ccb479ac33477b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141951
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [79fe1c3252f685ce2f90a2243bcd1ac52d67c5bf]

        tdf#138868 related: Update Navigator on Esc key unmarking
        
        of all marked objects
        
        Change-Id: Icd3e96bc6abfc1d23511553752565a12dc568b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141954
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [5f5f3173e5e51d4bf55fc043a153e20630fde4cc]

        tdf#138868 related: Update Navigator tree selections on UNO SelectAll
        
        Change-Id: I1b893940614e08843efe5dc46f81e88635512888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141952
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [14337ca8fe3ebc4fefbbf74b018f9b81fc5d9dfd]

        tdf#151124 Make outline folding state change set doc modified state
        
        true
        
        Change-Id: I70408e768d2214b2c0a5c736f9e6fd8da36d3611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140855
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-30  Jim Raykowski  <raykowj@gmail.com>  [96bb91de5b00e08b42352dcf34195f92029f01b6]

        Outline folding: Use ToggleOutlineContentVisibility function here
        
        and add comments to explain the bSubs parameter
        
        Change-Id: I4a6874363d7355af2709607496a8eb6197eb164b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142003
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [9cd0f4c2d25462feba0ffcbd906c199273821243]

        tdf#126788 no need to allocate an SwContentIndex when calling RstTextAttr
        
        Change-Id: I541ff3c68b9d6edee536bb9f9d45b13c7f314242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  insanetree  <treebian@tutanota.com>  [07b6e34397037722d40b2013eef21085eca4f235]

        tdf#147021: SAL_N_ELEMENTS changed to std::size
        
        Change-Id: I5633e4bb3658864abde49df1c65b93a2b4592631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141437
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [29de154fdfd5ce69ec906e04823c7d1cbbbbcdf9]

        tdf#126788 reduce cost of OInterfaceContainerHelper4::disposeAndClear
        
        use the empty singleton to avoid allocating an empty vector
        
        Change-Id: I2eb80228a870414fd253cdbe8d281610d2d3115d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c4aabb220ad1e8f1cbc75f2361fe17893d7cc29]

        tdf#126788 speed up GetDocFromXMLImport
        
        we can just static_cast to SwXMLImport, no need to use XUnoTunnel
        
        Change-Id: I5ca1a1e2d63ae632578261630f67c9d164727cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2ec354bf4f535132d34b206382cceb22ec7f43c]

        tdf#126788 dynamic_cast -> virtual call
        
        use a virtual method to speed up dynamic_cast to SwTable node
        
        Change-Id: I0e8eb8d671ac7aa1d15f1f4b37fb4c17220fafca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [32b0b79c3f71e4aca995aa92ee519d93a3ca2b3b]

        tdf#126788 replace dynamic_cast with static_cast
        
        no need to dynamic_cast here
        
        Change-Id: I36b2c20c0f8743c39a8b8b0f14a9eb2ee6effee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebe2a3e948df1622f3532afeeaeb31d1066d40c2]

        tdf#126788 check if we need to fire an event
        
        before calling the rather expensive weak->reference conversion
        
        Change-Id: I83f22ae3a016f4d44bf1589339d6dc31579cc9e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-29  Rene Engelhard  <rene@debian.org>  [75e16fdc9d111aad9663b7de1b229fbd2a61b51e]

        require xmlsec1-nss >= 1.2.35
        
        1.2.34 apparently doesn't have xmlSecBase64Decode_ex (needed since
        19e998aa98d966cffca98bed9408d5758d91d9be):
        
        [build CXX] xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
        /home/rene/LibreOffice/git/master/xmlsecurity/source/gpg/SecurityEnvironment.cxx: In member function 'virtual com::sun::star::uno::Reference<com::sun::star::security::XCertificate> SecurityEnvironmentGpg::getCertificate(const rtl::OUString&, const com::sun::star::uno::Sequence<signed char>&)':
        /home/rene/LibreOffice/git/master/xmlsecurity/source/gpg/SecurityEnvironment.cxx:166:16: error: 'xmlSecBase64Decode_ex' was not declared in this scope; did you mean 'xmlSecBase64Decode'?
          166 |     int nRet = xmlSecBase64Decode_ex(strKeyId, const_cast<xmlSecByte*>(strKeyId), xmlStrlen(strKeyId), &nWritten);
              |                ^~~~~~~~~~~~~~~~~~~~~
              |                xmlSecBase64Decode
        make[3]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:337: /home/rene/LibreOffice/git/master/workdir/CxxObject/xmlsecurity/source/gpg/SecurityEnvironment.o] Error 1
        
        and is neither in a grep -r on the header directory
        
        Change-Id: Ie7948ed9b796cc9823e44982824d3c3c61c9a46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142023
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [e7676fda295279470b5f28fa03a915ead467a51b]

        vcl: fix memory leak in CoreTextFontFace::GetHbTable()
        
        If the !nTag case, we created a CTFontRef but never released it.
        
        Change-Id: Iaf06d62f03b7cbcb2b2eda87db598ef983c55994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142022
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [26bac421905b53580154c9cf3d567a5f13786c67]

        vcl: fold CoreTextFontFace::GetFonTtable into its only user
        
        Change-Id: I3201add2e10d9cf01fc48b8d934822fc7b1941d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142012
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [8ca507a619313ead970ad03a71416dcebea91405]

        vcl: simplify how CoreTextFont stores CTFontRef
        
        We create CFMutableDictionaryRef, store two items in it and only even
        access one of them. Simplify the whole thing and skip the middleman.
        
        Change-Id: Iefc6b2c2664b0ea92e231195390ce8cd0d8d9778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142011
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [37d6dbd1b8f90604d58a782f7af0af1d5c8c1f89]

        vcl: rename CoreTextStyle to CoreTextFont
        
        Everywhere else we call them fonts.
        
        Change-Id: I70ef5957e9fb4fd03588cf23a255480ad021e083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142010
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [31b5c24d6ddc4e53259d99709a0d77d19d3f35e5]

        vcl: consistently cam PhysicalFontFace a face
        
        Change-Id: I8c0f445d001957c2ca23667c32f508cf43734843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142009
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Khaled Hosny  <khaled@aliftype.com>  [506d969193822f396bb2203718124e3516ad75d1]

        vcl: check the correct face for color glyphs
        
        We were checking the presence of color glyphs on the base face which can
        potentially different from the actual face the glyphs are using (e.g. in
        case of glyph fallback). Also rename the functions so we don’t need
        overloading.
        
        Change-Id: I6f278ac7fa32182a7d8fb1cd2ef00f392ced1b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142007
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-29  Caolán McNamara  <caolanm@redhat.com>  [05f9fb98bb64f15e0df6a7ca88b5391e051c2ebf]

        use WindowColor instead of White for highlighted toolbox items
        
        White doesn't work well for a dark theme
        
        Change-Id: I841f5df1fee95e9974e312ee058c54f47763fb0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-29  Justin Luth  <jluth@mail.com>  [4c8b1fa44d4f49510d3910981e649dcb08bceb36]

        tdf#151794 sc validate: honor NO_BLANK in Cell range dropdown
        
        This fixes LO 6.0 regression 3567d00b5e1168affd067330037e062e10b05b2d
        
        Not really a regression - it never let any blanks before then,
        regardless of the "Allow empty cells" setting in the
        Data - Validity rule.
        
        The default in LO is to allow empty cells.
        
        Change-Id: I2d6fb4d7be3622c81b28f5d30985cdb5e6b2fe11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142002
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [57b88487295bfbae056361d3614e477491c34055]

        CppunitTest_sd_export_tests: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: I3457c9483cb01fede7382b69a45ce83bb911f43c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141997
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [615d7d5b98e972c985f0db786a161250b23a4cee]

        CppunitTest_sd_export_tests-ooxml3: inherit from UnoApiTest
        
        Adapt code in testTdf115005_FallBack_Images to ignore
        Thumbnails/thumbnail.png. Now they are generated when saving
        
        Change-Id: I231ea9057129880e6ebf9774a8adb813b8cc716c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141996
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [be9c80322db80d7cd59145bf77541ab3361022cc]

        macos: set tooltext colors from something from the theme
        
        e.g. the "Find All" label in the find toolbar
        
        Change-Id: I8d766962bb6eda49cbcc39728fe4e5bb4b700fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Regina Henschel  <rb.henschel@t-online.de>  [2406ba67c8c03b0d6a4adb81f1efc1609c8dfe8c]

        tdf#54095 docx SmartArt import, apply theme text color
        
        PPTShapeGroupContext uses method applyFontRefColor in importExtDrawings
        to bring the theme text color to the shape text. The patch copies this
        way to ShapeContextHandler, which is used for SmartArt in docx.
        
        Change-Id: Ie0c0453d6a1fd73fbd4b65246aed9570646dc6f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141992
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-10-28  Miklos Vajna  <vmiklos@collabora.com>  [f546f7573158e52359bbeae6194a83a1ff8ac52c]

        DOCX export, numbering portion format: consider full-para char formats as well
        
        The bugdoc had a single paragraph with direct formatting (24pt font
        size), numbering enabled and a bookmark covering half of the paragraph.
        The numbering had default font size in the DOCX export result, not
        inheriting from the paragraph.
        
        In case the bookmark is removed, then the custom font size is not an
        autoformat set on the whole text of the paragraph but rather a format on
        the paragraph level, which does influence the formatting of the
        numbering portion via the paragraph marker formatting, as expected.
        
        Fix the problem in a way similar to what was done in commit
        cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f (sw, numbering portion format:
        consider full-para char formats as well, 2022-10-20), except that was
        for the rendering and this is for the DOCX export.
        
        This also required filtering out grab-bags in
        lcl_writeParagraphMarkerProperties(), otherwise citation SDTs show up in
        the export result at unexpected places, as shown by
        CppunitTest_sw_ooxmlexport14's testTdf129353.
        
        Change-Id: I7bb88e290f2a370d78ecc894f306bcb0a403545f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141995
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab24b70ca0ea80a4655c71762f628e86a76fefa0]

        CppunitTest_sd_misc_tests: inherit from UnoApiTest
        
        also simplify CppunitTest_sd_misc_tests.mk a bit
        
        Change-Id: I111045ebcc241664208ddcf917c9edba0ac50edf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141976
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [3c83a90f5873cc046d5b73c9fa8c968641f19325]

        CppunitTest_sd_shape_import_export_tests: inherit from UnoApiTest
        
        Change-Id: I7b5599574553e87345bf4ab09aeb2003d071eced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141977
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c0117a5abd03026d8ea2a06fc4f6fc534e04f48]

        sd: get rid of duplicated code...
        
        ... by moving a couple of tests to a place with
        similar tests
        Surprisingly, testTdf96708 fails now with
        
        sd/qa/unit/uiimpress.cxx:372:testTdf96708::TestBody
        equality assertion failed
        - Expected: 4
        - Actual  : 5
        
        which also fails when tested manually, so it seems
        the tests didn't work properly before.
        Issue reported in tdf#151802
        
        Change-Id: Id4fb1be5325793ca08f40c1360986a342608fc05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141975
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Miklos Vajna  <vmiklos@collabora.com>  [fc4c0722095f7fd2232997fae6a8f61c4a482edc]

        xmlsec: blind fix to lower the possibly pointless NSS requirement
        
        this was changed upstream for
        https://github.com/lsh123/xmlsec/issues/308
        and the hope is that only the test suite requires newer NSS
        
        Change-Id: Ibb4128ed98476f129470fac1f9b8cde181bb7bb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141962
        Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org>
        Tested-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [2c0997900d35e54466d479c9c5437d447ba9b165]

        ofz: build-failure use with-tls result for curl
        
        otherwise with (default due to --disable-dynamic-loading) --disable-nss
        
        we get:
        
        configure: error: select TLS backend(s) or disable TLS with --without-ssl.
        
        Select from these:
        
          --with-amissl
          --with-bearssl
          --with-gnutls
          --with-mbedtls
          --with-nss
          --with-openssl (also works for BoringSSL and libressl)
          --with-rustls
          --with-schannel
          --with-secure-transport
          --with-wolfssl
        
        alternative we could --without-ssl entirely without nss
        
        Change-Id: Iea25b918c135664dffacfb74089d7c7c0818695e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141956
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [2fce155c8939c83d80cacc4ead8110ff75ce1b4c]

        CppunitTest_sd_misc_tests: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: Id2976c5ebdd23997c90589f6770cca57a5fa1a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141974
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-28  Julien Nabet  <serval2412@yahoo.fr>  [f02701d55d81961161c686e433c4980b0072e939]

        Typo: SERVICE_SDB_PREPAREDSTATMENT->SERVICE_SDB_PREPAREDSTATEMENT (dbaccess)
        
        Change-Id: Ifea148d85236fee8aa29146f07bb3d57e634a246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141973
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0325be6f3de622be6af9b2f686e3c7afae0405b1]

        Fix bug in copying table where we need to create a primary key
        
        The problem seems to be that
        
            commit fa177231cd20bf3c3f4bb9b50f6646da139c6766
            Author: Tamas Bunth <tamas.bunth@collabora.co.uk>
            Date:   Fri Aug 30 14:57:31 2019 +0200
            tdf#127093, tdf#127092 Fix pasting autoincremented
        
        was reverted in commit d783017c1ccb4e62e99f26b42250ac4e15780cff.
        
        But the follow-on commit
            commit 376cc3ea0fc2e0f209763a2a27c5852136332c86
            Author: Tamas Bunth <tamas.bunth@collabora.co.uk>
            Date:   Sat Aug 31 18:27:44 2019 +0200
            dbaccess: delete old paste autoincrement logic
        
        was not reverted.
        
        This is not a straight revert of the second commit, because
        autoincrement has since been improved with
        
            commit 2a8e120db1c3175ff937cdbe6d0ade23dc380c01
            Author: Oleksii Makhotin <alex@bitprox.com>
            Date:   Tue Apr 6 16:03:41 2021 +0300
            tdf#119962 Fix autoincrement for copied table
        
        Change-Id: Ia9657d88b3e77ba72399ad9afeece3bda3f57038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f27bf3e888c6e98c4a723eb0a00c57f0197f1ed2]

        add TOOLS_WARN
        
        to make future debugging easier
        
        Change-Id: Ib8d268a350489d976c67504af171df5bd34579ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141966
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca82061c2cad00aeddb17b766063776fee0ee41a]

        make ValueTransfer easier to understand
        
        storing references to local variables makes it harder to figure out what
        the control flow is doing.
        
        Change-Id: Ifa7fedd6e4be19a0aa8180aa4f754f1811ca44a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141965
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [616e95c7044e8ea4fe3396dfa22c4ef7e9d4cd32]

        lok: You can't assume that destroyView would only destroy one view
        
        In case you have some in-place clients (e.g., Math in-place editing
        is active), destroying the parent view would also destroy children,
        and then both numberOfViewsChanged (called from doc_destroyView)
        must tolerate 0 as a valid input, and lok_doc_view_destroy must
        make sure to destroy the document after the last views had gone.
        
        Change-Id: I32370fea49da0969e1fbbf971a397c4d657ec8f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141963
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2022-10-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8db9337f35829d8592545055d03718ba0a204950]

        Removed duplicated include
        
        Change-Id: Ia4e519ae7f86135617c6af27bde99738f84df2ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141960
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [6f00aef4fe3242a1ff3a7f9fa31e8a6663162ca3]

        remove configure arguments to curl that no longer exist
        
        Change-Id: Ic6995dfcc11c872092c5e1a53c84dfed5d254eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [50ce65655d8ed834971f7b8d727ac966a841ea12]

        invalidate slider on gaining/losing focus so could show a macOS focus ring
        
        Change-Id: Ief8d3f8152ccc23bd65afb4e9e92cf4190f6bb37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c754a226e63415a4f95be47ba30bde5029fee21]

        rename createPreparedStatment->createPreparedStatement
        
        Change-Id: Ic45610116bd607da018a811f07aebce0f1b8ef85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141959
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [1e1f739f649a9a36c18425209a6d47c5f7b23eac]

        It's Frame-Controller-Model, not Model-View-Controller
        
        Change-Id: I23a867623f77502baed6639ad3e255c06673d67f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141957
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [91bc1e6a8c92a7c895f0ba9dcad9ac4d35f3f791]

        vcl: extract function Animation::RenderNextFrameInAllRenderers()
        
        Change-Id: Iaccf12b251ffe06e24813c48ba3a169d0eaaa61c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76416
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-28  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [470201f392a019ef6f2b9e70377e66e47e839494]

        tdf#145240 add flexibility to receiving PolyPolygons over UNO API
        
        Make XMLShapeExport aware and use that PolyPolygons can be not
        only in Bezier format, but also a sequence of Points
        
        Change-Id: Ie00e87d35d4f8aa9d481b2800585c5a770bbbc0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141935
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [fb53e83372f139bceb5ebfaaae633875efeec240]

        Small simplification
        
        Change-Id: I9aed483fd21b040c486526488917398aaafbe3a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141953
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [a19177768ce4b57d8b11f50785cf4ba6faf093a5]

        macos: set tooltip colors from something from the theme
        
        Change-Id: I35d3dc602e568c954da23bc91ea695c4b95dd932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Caolán McNamara  <caolanm@redhat.com>  [90c1a0ca864a686ca1d0846d9656415e94baf410]

        macos: use system linkColor for hyperlinks
        
        so there is something readable under dark mode, use purpleColor like
        gecko does for visited links as there isn't something available
        
        Change-Id: I36e1b56d505bc8add36f2828fca60b898f9f2d37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141945
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-28  Miklos Vajna  <vmiklos@collabora.com>  [50ecf0f53aabb204df00b052a442def33dd16028]

        CppunitTest_sw_ooxmlexport: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ie0fdfb333ecb14ce8c015d3bd1750f9b16ce4d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141944
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [876d9d6d333cafc0649abebc757f397faf86fc4d]

        Implement css::frame::XController2 in ChartController
        
        ... and use utl::ConnectModelViewController in ChartFrameLoader::load
        
        Change-Id: I9f0dae1b530c05aefdbeeb6a3b3f28d85b0eb14c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141947
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [16e98d669f2d1dd36c39007daab05a8696b08ebb]

        Introduce utl::ConnectModelViewController
        
        And use it to avoid code duplication
        
        Change-Id: I18447bc1a0388d57a273b310977a0f0fb54152b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141946
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-28  Jim Raykowski  <raykowj@gmail.com>  [5f72a041c0160e4067ca931a9cec711b84b558f4]

        tdf#142446 Show outline content up to a given outline level
        
        This enhancement provides means to hide outline paragraphs and their
        so called outline content for outline levels greater than a given
        outline level. This can be done whether or not outline folding is
        enabled.
        
        Change-Id: I2769b8f39ef2bc11e03cae07c234cf345104567e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141678
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [02db1642c9ce4394f4f85755c4a0a831e547e4fb]

        CppunitTest_sd_export_tests-ooxml2: inherit from UnoApiTest
        
        Change-Id: Icb690580bf0632f700df52b7dc2620a860bdf9ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141942
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ba994b6ce2af211cdb89f8f7d91b3ae64ecfb5cd]

        CppunitTest_sd_export_tests-ooxml2: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: Ic2f94977cb8d777023c88612b337e6a060bea422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141941
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Noel Grandin  <noelgrandin@gmail.com>  [b4b63d0c46979ad6b6aae5d6a4ea6672ea248e10]

        try to fix some shutdown crashes
        
        seen in 7.4 crash reports
        
        Change-Id: I4c88d485e2e1925895f23861232823ebe97c0c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d63176bcfbc80fc4045a0f0580c5bf9ccea7a89]

        tdf#151736 writer direct formatting crash
        
        regression from
            commit 9a44807ff3a11afa8f7ce9857ae6a6144a61d481
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Mar 2 17:58:31 2022 +0200
            use SfxItemSet::GetItemIfSet in sw/source/core/txt
        
        Change-Id: I9db016d608300c603d0b1386962b188dddc85125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d83a016823dceaeb48f34d4e94f9a230bebd9169]

        tdf#151767 PPTX import: fix table border width
        
        There is a "Clear Table" function in PP. In this case,
        the table uses the default border value of MSO, which
        was imported as missing table border.
        
        (Note: commit ff0387e726b59e374029d2f635ce00308d99eff6
        "tdf#135843: sd_export_tests-ooxml3: Add unittest for the
        export part" If attachment from tdf#106011 is opened in
        PowerPoint, the table is visible it, but was not in LO.
        This patch fixed that. Therefore the borders of table are
        not missing after export.)
        
        Change-Id: I92dfe2e42f5f58b15af23cc24e931fb12d7c2794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141880
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-27  Caolán McNamara  <caolanm@redhat.com>  [ca482cf39f25941040596e50d0e1ab7fa25dc1dd]

        calculate the header bounds even for !bPaneWithHeader case
        
        so we can pass in the required area for the macOS case
        
        Change-Id: Ibb170e773a57ad0d5d0a591810e4039591337303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141911
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [eec48130271188cab63665acedbabf1ff5e850a2]

        tdf#148926 tdf#151678 PPTX import: position of standard connector - part1
        
        Connectors are typically connected to connection dots,
        which exist on shapes. If both or one of the two shapes
        are missing, it will be drawn the default type of a
        standard connector in LO. In this case, there is an
        adjustment point which is used to modify positions and
        shapes of the connectors. This patch fixes the position of
        the connector by calculating and setting the adjustment
        value.
        
        Change-Id: Iee384d2a92a22ff95d7b17ba0b4f09698176bc84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141723
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-27  Tünde Tóth  <toth.tunde@nisz.hu>  [6e378b5beee473edc54c50550eff9e7d9eec57b5]

        tdf#151621 sd UI: use correct zoom in embedded PPTX
        
        Embedded PPTX object opened at 3000% zoom in a new window.
        
        Change-Id: I7b353b607a1cef84eceaac5fbff96f2fbeb18500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141528
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [293e3fcf6fef554bdc8a54c0452ca20f01effbf0]

        CppunitTest_sd_export_tests-ooxml1: inherit from UnoApiTest
        
        for that create the intermediate SdUnoApiTest and SdUnoApiTestXml
        classes. Later they will be merged with SdModelTestBase and
        SdModelTestBaseXML
        
        Change-Id: Ibb59109658c37f9573ab3dc5642cd19e3f6cd86a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141934
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [58220942d65b81c8586f1c2984a0faf84ed9172c]

        CppunitTest_sd_export_tests-ooxml1: use clang-format
        
        Do it before changing the inheritance
        
        Change-Id: I2346d7d6a7433134edf082d50d4782893b43013f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141937
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Noel Grandin  <noelgrandin@gmail.com>  [65368d40bea28bd2d7abfae61056c68d3613c54c]

        add a comment
        
        Change-Id: Iefaf4124327f89277605b1092da2db8b28ef05e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [097a2de6428f834d28fa78af203d3c0b6577656e]

        tdf#151492 PPTX export: fix connection points regression
        
        caused by commit 4d153517183193f468dee9148c94fe9d874bacb3
        (tdf#149697 PPTX export: fix changing place of connection points).
        
        Change-Id: I6134f18f3c32182a2f5d7295e2511da192dd20c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141427
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6eea95aac86c0e56043222af2b34c80f9aca8b3c]

        Removed executable bits on odt file
        
        Change-Id: I88234a1bf889a89fac6385f60a4810c55258a813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-27  Tünde Tóth  <toth.tunde@nisz.hu>  [2dfd9e3e00f6e57ab1b307cf57c01a0830da4b17]

        tdf#151384 DOCX export: lost hyperlink format in localized UI
        
        Fix losing color and underline of hyperlinks in localized
        builds, at least with Russian UI.
        
        Regression from commit d57b4480903f700ad7c95e885b9dd0ace5883cfc
        "tdf#127579 DOCX export: fix losing color and underline of ODT hyperlinks".
        
        Change-Id: I1eebcf58a7071226e80df3f84ed1264c5a8baf31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141761
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-27  Stephan Bergmann  <sbergman@redhat.com>  [54b6536b1936f8bff43285ed43f51430ab30b4a2]

        Remove leftover INCLUDED_POSTWIN_H macro
        
        ...that had been added in 48b1c8898d2f5a54435d23c412a0c65b553ef46d "clang-cl
        loplugin: vcl", apparently to avoid redeclaration warnings for some extern "C"
        function, and had been left behind when that function declaration was removed in
        3c443852d25a61b61353d630d8dc8753bad6ab30 "vcl: remove no longer needed
        WIN_Rectangle()"
        
        Change-Id: I2744122e8fefc56c75dbcb921e96b22025b6b766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141909
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-27  Miklos Vajna  <vmiklos@collabora.com>  [bd892f3ba96fae1f0a151734053da0b39ca69c86]

        crashtesting: fix PDF export of tdf98567-1.docx
        
        Importing tdf98567-1.docx crashed with debug STL since commit
        47bc36c0f87ec2d0329260bcb98d62c7667a5dd1 (sw: make sure mark container
        is sorted before calling equal_range(), 2022-10-24).
        
        The problem is that sw::mark::MarkManager::deleteMark() calls
        DeregisterFromDoc(), which can call selection change listeners, which
        may mutate the container.
        
        Fix the problem by delaying the DeregisterFromDoc call using
        an ILazyDeleter for DDE bookmarks.
        
        Change-Id: Ia4e8ec379dc0c597db8fe5d91d55af09363350c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141907
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9ec72ff4d2fb89002ab81e363712fbfd4cbfd98]

        add some more asserts in Fraction::MakeFraction
        
        which I missed when inlining code in
        
            commit 8ac4dd510bd5f41882db0b647797674b06339f4e
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Oct 27 08:48:25 2022 +0200
            tdf#123419 optimise ImplMakeFraction
        
        Change-Id: Ifd271ce89cea29a22d41b8e143e27df118f8df3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Sarper Akdemir  <sarper.akdemir@collabora.com>  [e6a1586ff90125245cf0f898af37bf568abdcddf]

        related tdf#149961 pptx export: scale indents for autofitted textboxes
        
        For autofitted textboxes, Impress scales the indents with
        the text size while PowerPoint doesn't.
        
        Try to compensate for this by scaling exported indents
        proportionally to the font scale on autofitted textboxes.
        
        Change-Id: Ib0f967e923d23553b4cdbd1bbe2e137d97b1b2e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141758
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-27  Sarper Akdemir  <sarper.akdemir@collabora.com>  [08d0c2cd6b6bdf37d6fc5c16359bafc6dddc9d09]

        tdf#149961 pptx import: fix indents for autofitted texboxes
        
        For autofitted textboxes, Impress scales the indents with the
        text size while PowerPoint doesn't.
        
        Scale the indents inversely propotional to autofit font
        scale so that the visual appearance on import is similar to
        PowerPoint.
        
        Change-Id: I7876b35a1f4221789564fcf23ccbe3fe21db3d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141717
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [eeaac9cfdea6d8660ac72e63df3c9a1b8623db7c]

        rational_ReduceInaccurate unnecessary here
        
        as pointed out by mike kaganski, since we are already dealing with
        32-bit values
        
        Change-Id: Ic621757f2d9a689e54c47f36cc6ba85a322c500e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe13e1a4e6350c9a1f79bab4cb5845e7864df7e1]

        chart2: remove leftover
        
        since 51d366712c55c61bea5169c238098d7007e4ce20
        "ChartTest: inherit from UnoApiTest"
        
        Change-Id: Ie4c3c25a3a854df6c7ac27e01c93ffb8f41f469c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141903
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [483afea3a99b928d0e1cb1df0415a06269067559]

        tdf#151462 - Search for outline node containing the current node
        
        Added unit test
        
        Change-Id: I9fcc26527ec2f7e036ee32a709f023fcc50d9e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141892
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [885fb902ce7765f04c98cebedf96959007cef05b]

        tdf#146360 use correct data source to access object properties
        
        For more and detailed info see comment in diff please.
        
        Change-Id: I33d6d4fc46af7f6f854a2708e3ab932bbe6712f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141886
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5f25f2f78d3852967a6919e215308d129880cf1]

        update credits
        
        Change-Id: I4862f568d9025e321a14291aae5617ab2a474862

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [97ae965fa6f11078a48dc5a58455a024367fbc9e]

        CppunitTest_sc_sparkline_test: inherit from UnoApiTest
        
        Change-Id: I456165940ed2719cb854008f1450b7e97e334c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141900
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a542389d35ab8bde735b25d430e2e832bd418df]

        sc: move test to a better place
        
        it's not an export test. Besides, we can get rid of
        loadDocAndSetupModelViewController now
        
        Change-Id: Id6499ff8f0513453eb11eb0054cebd6423e9ae78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141899
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [447321aab480abae3097ce2bce1693d05e7fe1a8]

        CppunitTest_sc_copypaste: inherit from UnoApiTest
        
        Clean CppunitTest_sc_copypaste.mk a bit as well
        
        Change-Id: I0100bcba556fa09a82349c417d34a33789e760e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141898
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [551e5943d4bec10c31077f38ccf5d8149c05265c]

        tdf#123419 optimise ImplMakeFraction
        
        which is very hot here. Push it down into Fraction, where we can skip
        the construction of boost::rational intermediate values
        
        Change-Id: I7e5f18456a252a159d3a50e9297168e5ba9e1588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab83d7d57d0fae106037b12651adb397b48354e4]

        tdf#123419 using glyph cache for drawinglayer rendering
        
        speeds up rendering by 5% or so
        
        Change-Id: I9feaae75cf2779adf06fcc2429be35ac88193ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141893
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [97cd814ce88cac93f28408e983f3cfc0f94bb6bf]

        RstMBDownFlags -> ResetMouseButtonDownFlags
        
        Change-Id: I2488422d2de8a67c69ec4e60c0f289bc0b784f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141897
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-27  Caolán McNamara  <caolanm@redhat.com>  [fb1bf9f1fda915b30864e9ad23545930ea6d25fd]

        cid#1242675 Untrusted value as argument
        
        Change-Id: If8ecad4501d6c555791eae0ae113a34e05f9436f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141670
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-27  Miklos Vajna  <vmiklos@collabora.com>  [19e998aa98d966cffca98bed9408d5758d91d9be]

        Update libxmlsec to 1.2.35
        
        - backport 2 patches to fix the build
        
        - replace calls to the now deprecated xmlSecBase64Decode()
        
        Change-Id: Ib3254002fff5e49bb6dd4eb1bf62e7d2ee7be83e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141865
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-27  Stephan Bergmann  <sbergman@redhat.com>  [dc85be45c7e2efc0512e823d08e2edba0d4c0e76]

        More CppunitTests need the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", after Xisco's recent CppunitTest clean-
        up
        
        Change-Id: Iad4df2bc00e503118e3ad32f25f4ca63ba5d8561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141891
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-27  Dennis Francis  <dennis.francis@collabora.com>  [3f9e8ac6172f5b1dfd2869ee1c6aea4f24d3f480]

        vcl: re-exporting broken pdfs -> empty pages
        
        Certain pdf documents when loaded in LO_IMPORT_USE_PDFIUM=1 mode even if
        pdf-version < v1.6 sometimes has missing objects referred by other
        objects for determing its stream length for instance.  As a result
        parsing fails and results in a pdf with empty pages.  A round trip
        through pdfium and exporting to v1.6 seems to cure the issue. Possibly
        it does some repairing work to determine the length of the stream in a
        independent pass through the file.
        
        Conflicts:
        	vcl/source/filter/ipdf/pdfread.cxx
        
        Change-Id: Id09f67eddab4163ed12a3a3f3a73baf92e2912aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141856
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [bdb76c9ff1832041fa7a9bda30e8d4d7d937ff94]

        CppunitTest_sc_jumbosheets_test: inherit from UnoApiTest
        
        Split a couple of tests into 2, one for ods and the other for xlsx
        Change-Id: I9f6f908b150c435933739335f6618d335ce8f9a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141889
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Stephan Bergmann  <sbergman@redhat.com>  [5e43ccb27584d98699e2b2e06658d5b52ebcdff7]

        More CppunitTests need the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", after Xisco's recent CppunitTest clean-
        up
        
        Change-Id: Ia47e770a439af3476f81f8c28f2527bbf144baa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141890
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-26  Caolán McNamara  <caolanm@redhat.com>  [aad5baa3836087032658a5db3673decd9e242e75]

        tab items not exactly centered
        
        Change-Id: I98938855876f8f7d821bacd8ba135053c92683a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141887
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [b45ab31f2b5eb93773608f06b947cd9c5a169150]

        UnoApiTest: do not dispose on save
        
        Change-Id: Id100591517da48ec8e5cfd38f5c44ac0d7b16198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141888
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [4a8fa1ba2fa5b4e3c95a255c0cb2d45df54aea38]

        gtktiledviewer: don't crash on sidebar creation
        
        There's no dialog parent for the sidebar child window.
        Just ignore the signal for now.
        
        Change-Id: Iadfae9174780b10b94e8dd3e6c9efc8c4e8b4b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141878
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-26  Michael Stahl  <michael.stahl@allotropia.de>  [a76a88203d8508f38b10d9bbb94c3bba2485fcaf]

        curl: upgrade to release 7.86.0
        
        Fixes CVE-2022-32221 which could affect libcmis, CVE-2022-42915,
        and 2 more CVEs that probably don't affect LO.
        
        * remove --without-ssl:
          On the one hand, on GNU/Linux this now results in:
        
            configure: error: --without-ssl has been set together with an explicit option to use an ssl library
        
          On the other hand, using the more obvious --without-openssl yields a link
          failure on Android on the nss check in configure:
        
          configure:28220: checking for SSL_VersionRangeSet in -lnss
          /home/cl/Android/Sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin/ld: warning: liblog.so, needed by /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnss3.so, not found (try using -rpath or -rpath-link)
          /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_write'
          /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_assert'
        
          ... so add the -llog for android in curl-nss.patch.1
        
        Change-Id: I3931a1eec2d681c2ce0e5695039492772e9fcc81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141866
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-26  Michael Stahl  <michael.stahl@allotropia.de>  [022e476af44c0dfc97403dc0f3a3b63e731903e6]

        ucb: FTP UCP: report CURLE_URL_MALFORMAT as IllegalIdentifierException
        
        With curl 7.86, the test JunitTest_ucb_complex starts to fail:
        
        .ftp://noname:nopasswd@*nohost.invalid
        now executing open
        com.sun.star.ucb.InteractiveAugmentedIOException:
        	at com.sun.proxy.$Proxy15.execute(Unknown Source)
        	at complex.ucb.UCB.executeCommand(UCB.java:63)
        	at complex.ucb.UCB.checkWrongFtpConnection(UCB.java:119)
        
        because curl_easy_perform() now returns CURLE_URL_MALFORMAT where
        previously it was CURLE_COULDNT_RESOLVE_HOST.
        
        Map this to an exception the test expects.
        
        Change-Id: Ifdb672946726ddb4cb4d9426b7e70eefac63f040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141877
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [d86a5a44d12daf0ea3d4865613679ca97fe7739a]

        CppunitTest_sd_layout_tests: inherit from UnoApiTest and XmlTestTools
        
        Change-Id: I60015f363fd4c026240da641ee99ba7185dfbb1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141876
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Stephan Bergmann  <sbergman@redhat.com>  [5baeba69bf448a60068d3bbbcf88dbdf491e41ea]

        Adapt compilerplugins to recent Clang 16 trunk change
        
        <https://github.com/llvm/llvm-project/commit/1acffe81ee9117691812b9bf8747c03354177d15>
        "NFC: [clang] Template argument cleanups."
        
        Change-Id: I84bc276c21efcc11643ae7003e0fee6c7592130f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141860
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [932423b8f3ac5e15809c3234d589c0098a00a52c]

        CppunitTest_sd_png_export_tests: inherit from UnoApiTest
        
        Change-Id: I0dfc7e10250e2690fa34821f8f73cfe6306d2417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141874
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [ffe9dfbbc64c7ce873f3a83c046ec417d07eaa4e]

        CppunitTest_sd_html_export_tests: inherit from UnoApiTest
        
        Change-Id: Ia51a023102f83406d83f5bfa92bb7dda31ee9dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141872
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [0dfe66b1d3b6b55cd8fcf76a8290dcd6f6a1a329]

        CppunitTest_sc_tiledrendering: inherit from UnoApiTest
        
        Change-Id: Ie1574d2a84700a1f5c6adf4436ed6f6394dfbe6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141871
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [faff1af1a1506825b930428bdd126cf1a2c2b2d1]

        CppunitTest_sd_tiledrendering: inherit from UnoApiTest
        
        Before it was inheriting from SdModelTestBase for no real
        reason
        
        Change-Id: I51ecb82a5e867808c5fd39d2a0aa093ad097cb1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141868
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d8c751008a0997ab9a171675b27b238ba503986a]

        Enable gtktiledviewer on Windows
        
        A new configure argument is introduced:
        
          --with-gtk3-build=<absolute path to GTK3 build>
        
        When provided, libreofficekit_selectionhandles package, libreofficekitgtk
        library and gtktiledviewer executable would be built on Windows using the
        GTK3 libraries in the passed directory, that must contain lib/pkgconfig
        subdirectory with correct pkg-config data.
        
        Change-Id: I6504af6eec0fc73cceb26a1ce923337abe14b5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141624
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-26  Stephan Bergmann  <sbergman@redhat.com>  [ffb9dcce397f5b13b675b5849457bb98ca9c8e8e]

        UBSan needs SwWrongList RTTI now
        
        ...during CppunitTest_sw_uiwriter6,
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter6.so
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter6.so: undefined symbol: _ZTI11SwWrongList"
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2564/>), apparently since
        e3ae86a38d6282db0f54d3545015ed22ee868ae5 "tdf#124603 sw: pressing Up/Down
        triggers pending spell checking"
        
        Change-Id: I52dfe490bd8862e109a1c2f78a95a7e3022a1352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141870
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-26  Caolán McNamara  <caolanm@redhat.com>  [bef36eed84bbc1663b174a082d0d3e6544aaab88]

        crashreporting: crash in thesaurus dialog PostUserEvent
        
        not reproducible, but a common error to post an event that
        outlives the owner
        
        Change-Id: Ic2633c504d853116d03e3322f552ae66e7e7e14e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-26  Caolán McNamara  <caolanm@redhat.com>  [ad2310fec997c73e7546c27aa2aaf2dfd6dbbdf6]

        crashreporting: crash in area tab page with insert, envelope
        
        insert, envelope, format, addressee: format: edit: paragraph, area,
        click on gradient, bitmap, etc.
        
        Change-Id: I121674776662b31dc4e3cf96fbeb2c1d234ae00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c21bc69406407988f50479ad7b00afee7e4113d]

        CppunitTest_sd_uiimpress: inherit from UnoApiTest
        
        Change-Id: I31c941677b45c0a82e3fe688d40b63796a46d26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141863
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c0a5cd891a32676050092411c4a302e6982d716]

        CppunitTest_oox_vml: Inherit from UnoApiTest
        
        Change-Id: I8c9fe639c448f1fb84449e065dfa05bd1c37ea34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141861
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [160473c1f171f1d3fae4f798338e14eb8ccfdd0e]

        CppunitTest_sd_pdf_import_test: inherit from UnoApiTest
        
        Change-Id: I8bd1c930896935770cdf7453550340cbc8b79f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141862
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Miklos Vajna  <vmiklos@collabora.com>  [58002ab85d992c7ac44d8bb4d135246b67aa5cc7]

        sw content controls: enable data binding for date
        
        The document had a 2022 date in document.xml, but had a 2012 date in
        data binding. Writer used to show 2022, while Word picks 2012.
        
        Data binding for dates were disabled in commit
        de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw content controls, plain
        text: enable DOCX filter with data binding, 2022-09-19), because the
        formatting of those date timestamps were missing, so it was better to
        just not update them from data binding, temporarily.
        
        Fix the problem by adding a new read-only DateString property on
        SwXContentControl, this way the import filter can set not only the
        timestamp but the formatted date as well.
        
        This shares the SwContentControl::GetDateString() code with the UI,
        which already had the need in the past to turn a timestamp into a
        date string, based on a provided language and date format.
        
        Change-Id: I842a9483a675f895129a9854caec347be6b6b84e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141859
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-26  Alain Romedenne  <alain.romedenne@libreoffice.org>  [8c44dadafe1c3bc4adf4cf78246730a90710dd58]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ca05a2e1e9569618449d87fcba196ba21c711363
          - index correction
            
            Change-Id: I9580f8bef5138364667df66eb950f1d205b5e9a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141837
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [580776cdc5b6a6cc73771e0875ead0ab87a6c69b]

        CppunitTest_oox_mathml: inherit from UnoApiTest
        
        Change-Id: I163fd8d635a18c1dd03eaa50720d10d4fe78d4cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141857
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f795bb8bbb77a1c06260768e8d515b58dac8bce]

        CppunitTest_oox_shape: inherit from UnoApiTest
        
        Change-Id: I2f8465713c3a2b57faea62d6022e4735d50eb950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141858
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-26  Stephan Bergmann  <sbergman@redhat.com>  [b92c822be84f2a82625e2ece3a91e7f95015d186]

        Support --with-visual-studio=2022preview
        
        ...for recent Visual Studio 2022 Preview 17.4.0 (which can be installed
        alongside a Visual Studio 2022 17.3.x release)
        
        Change-Id: I104363ac0007a84617486dd798d6c4fb9c0a5ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141855
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-26  Stephan Bergmann  <sbergman@redhat.com>  [3e009159cd1801507f6e965444a7dade5497f89a]

        external/skia: Missing include
        
        ...at least when building with Visual Studio 2022 Preview 17.4.0,
        
        > In file included from workdir/UnpackedTarball/skia/src/core/SkKeyHelpers.cpp:14:
        > workdir/UnpackedTarball/skia\src/core/SkShaderCodeDictionary.h(45,43): error: no type named 'string' in namespace 'std'
        >     using GenerateGlueCodeForEntry = std::string (*)(const std::string& resultName,
        >                                      ~~~~~^
        
        etc.
        
        Change-Id: Idd8dafb4e57e04088ee60954ecfa601cc7588e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141833
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-26  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [038c4a42834014b421a2e8a99ae436eb2dc8f8c5]

        lok: support embedded media
        
        Change-Id: Ie8f3ed188cec0050a10a5d49325756931b902ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141807
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-26  Miklos Vajna  <vmiklos@collabora.com>  [110370baa621f33a095e1da908f89bdfb5a68ce6]

        CppunitTest_sw_ww8export3: remove not needed mustTestImportOf()
        
        If the input format is not DOC, we can use the plain
        CPPUNIT_TEST_FIXTURE().
        
        Change-Id: Id73b6ed4218b4fa7883ca4e39fb3df01f7525428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141831
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-26  Regina Henschel  <rb.henschel@t-online.de>  [17dfc9a9da009cc23d2222e3fb4e2cef9c97d581]

        tdf#83671 SmartArt: preserve pos and size for metafile
        
        Import of a SmartArt creates a group with a background shape and then
        the SmartArt shapes. The background shape determines the position and
        size of the group.
        
        The method Shape::convertSmartArtToMetafile() replaces the existing
        SmartArt shapes with a metafile object and thereby throws away the
        background shape. Thus the group takes it size from the metafile object,
        which has default size 100x100 (Hmm) and position 0|0.
        The patch remembers the original size and position from the background
        shape and applies it then to the metafile shape.
        
        Change-Id: Id7b1ccd20b2597c5e2adca7294a994fd2e0e066f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141830
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-10-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb07b2e2dba871d8b5c5fb99ea3dbf176c756025]

        Fix typo
        
        Change-Id: If5476a32e780870725247aba6be50ba50bd54915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141828
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [dc8fc774c35cc935331e04ddb8ab7646ffca775e]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from sfx2/source/dialog/templdlg.cxx:20:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'ToolbarDropTarget'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<ToolbarDropTarget>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<ToolbarDropTarget>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > sfx2/source/dialog/templdlg.cxx:665:25: note: in instantiation of member function 'std::unique_ptr<ToolbarDropTarget>::~unique_ptr' requested here
        > SfxTemplateDialog_Impl::SfxTemplateDialog_Impl(SfxBindings* pB, SfxTemplatePanelControl* pDlgWindow)
        >                         ^
        > sfx2/source/inc/templdgi.hxx:198:7: note: forward declaration of 'ToolbarDropTarget'
        > class ToolbarDropTarget;
        >       ^
        
        Change-Id: I360f35e01e301bca6fa801a889b6d107f67faf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141818
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Michael Stahl  <michael.stahl@allotropia.de>  [fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9]

        tdf#148934 PDF/UA export: add Contents entry to Link annotations
        
        * Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 2
        Links shall contain an alternate description via their Contents key as described in ISO 32000-1:2008, 14.9.3.
        
        These links are created all over the code, in some cases it's a bit
        dubious what the content/alt-text should be, but let's try to use the
        most suitable looking bit of text in whatever the context is.
        
        * Specification: ISO 14289-1:2014, Clause: 7.18.3, Test number: 1
        Every page on which there is an annotation shall contain in its page dictionary the key Tabs, and its value shall be S.
        
        Change-Id: I7b63feb759f0c75047f854ed9997918f829a537e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141826
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee912e56d85345489234196266216e660a5dee46]

        CppunitTest_filter_textfilterdetect: inherit from UnoApiTest
        
        Change-Id: I146bd1a032b53b4f0457a0fd9c58c5770f98a308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141829
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Miklos Vajna  <vmiklos@collabora.com>  [b38730ae0ae92ca49b84a45853c2ed098ee9064f]

        sw html import: fix handling of CDATA
        
        In case the HTML contained markup like <![CDATA[...]]>, we simply
        ignored it during import, even if e.g. the ODT import handles that
        correctly.
        
        The reason for this is that the svtools/ HTMLParser had code to parse
        <!-- ... ---> style comments, but not for CDATA.
        
        Fix the problem by introducing a new HtmlTokenId::CDATA, producing a
        matching token content in HTMLParser::GetNextToken_(), and finally map
        it to normal text on the Writer side.
        
        Note that HtmlTokenId doesn't allow non-on-off tokens past ONOFF_START,
        neither allows inserting a single token before ONOFF_START (it breaks
        getOnToken()), so for now just add a second, dummy token to avoid
        breakage.
        
        Change-Id: I605c3c21dc11986fda5d93d36148788a638e97b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141813
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [d55358c7c31e2e9f124ee90d78eba2db3f1af756]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from sw/source/core/access/acccell.cxx:20:
        > In file included from include/sal/log.hxx:20:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/sstream:186:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/istream:165:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:168:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'FndLine_'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<FndLine_>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<FndLine_>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:64:13: note: in instantiation of member function 'std::unique_ptr<FndLine_>::~unique_ptr' requested here
        >     __loc->~_Tp();
        >             ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:89:12: note: in instantiation of function template specialization 'std::__destroy_at<std::unique_ptr<FndLine_>, 0>' requested here
        >     _VSTD::__destroy_at(__loc);
        >            ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/allocator_traits.h:317:16: note: in instantiation of function template specialization 'std::destroy_at<std::unique_ptr<FndLine_>, 0>' requested here
        >         _VSTD::destroy_at(__p);
        >                ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:834:25: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<FndLine_>>>::destroy<std::unique_ptr<FndLine_>, void, void>' requested here
        >         __alloc_traits::destroy(__alloc(), std::__to_address(--__soon_to_be_end));
        >                         ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:828:29: note: in instantiation of member function 'std::vector<std::unique_ptr<FndLine_>>::__base_destruct_at_end' requested here
        >   void __clear() _NOEXCEPT {__base_destruct_at_end(this->__begin_);}
        >                             ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:433:9: note: in instantiation of member function 'std::vector<std::unique_ptr<FndLine_>>::__clear' requested here
        >         __clear();
        >         ^
        > sw/inc/tblsel.hxx:170:5: note: in instantiation of member function 'std::vector<std::unique_ptr<FndLine_>>::~vector' requested here
        >     FndBox_( SwTableBox* pB, FndLine_* pFL ) :
        >     ^
        > sw/inc/tblsel.hxx:152:7: note: forward declaration of 'FndLine_'
        > class FndLine_;
        >       ^
        
        Change-Id: Ia088547c6463a55f48bb4c4ca5107b3bf9472ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141820
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [4458cf6930fdbda44345fcd1bd9b5c0664cffb9f]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:43:
        > In file included from vcl/inc/unx/gtk/gtkdata.hxx:34:
        > In file included from vcl/inc/unx/gendata.hxx:15:
        > In file included from vcl/inc/svdata.hxx:26:
        > In file included from include/o3tl/hash_combine.hxx:13:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/functional:515:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__functional/boyer_moore_searcher.h:26:
        > ~/llvm/inst/bin/../include/c++/v1/vector:538:52: error: arithmetic on a pointer to an incomplete type 'FilterEntry'
        >         {return static_cast<size_type>(__end_cap() - this->__begin_);}
        >                                        ~~~~~~~~~~~ ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:761:56: note: in instantiation of member function 'std::vector<FilterEntry>::capacity' requested here
        >       __annotate_contiguous_container(data(), data() + capacity(),
        >                                                        ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:428:7: note: in instantiation of member function 'std::vector<FilterEntry>::__annotate_delete' requested here
        >       __annotate_delete();
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:49:5: note: in instantiation of member function 'std::vector<FilterEntry>::~vector' requested here
        >     delete __ptr;
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<std::vector<FilterEntry>>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:86:19: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::~unique_ptr' requested here
        > SalGtkFilePicker::SalGtkFilePicker( const uno::Reference< uno::XComponentContext >& xContext ) :
        >                   ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.hxx:38:8: note: forward declaration of 'FilterEntry'
        > struct FilterEntry;
        >        ^
        > In file included from vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:43:
        > In file included from vcl/inc/unx/gtk/gtkdata.hxx:34:
        > In file included from vcl/inc/unx/gendata.hxx:15:
        > In file included from vcl/inc/svdata.hxx:26:
        > In file included from include/o3tl/hash_combine.hxx:13:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/functional:515:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__functional/boyer_moore_searcher.h:26:
        > ~/llvm/inst/bin/../include/c++/v1/vector:761:54: error: arithmetic on a pointer to an incomplete type 'const value_type' (aka 'const FilterEntry')
        >       __annotate_contiguous_container(data(), data() + capacity(),
        >                                               ~~~~~~ ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:428:7: note: in instantiation of member function 'std::vector<FilterEntry>::__annotate_delete' requested here
        >       __annotate_delete();
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:49:5: note: in instantiation of member function 'std::vector<FilterEntry>::~vector' requested here
        >     delete __ptr;
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<std::vector<FilterEntry>>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:86:19: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::~unique_ptr' requested here
        > SalGtkFilePicker::SalGtkFilePicker( const uno::Reference< uno::XComponentContext >& xContext ) :
        >                   ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.hxx:38:8: note: forward declaration of 'FilterEntry'
        > struct FilterEntry;
        >        ^
        > In file included from vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:43:
        > In file included from vcl/inc/unx/gtk/gtkdata.hxx:34:
        > In file included from vcl/inc/unx/gendata.hxx:15:
        > In file included from vcl/inc/svdata.hxx:26:
        > In file included from include/o3tl/hash_combine.hxx:13:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/functional:515:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__functional/boyer_moore_searcher.h:26:
        > ~/llvm/inst/bin/../include/c++/v1/vector:834:62: error: arithmetic on a pointer to an incomplete type 'FilterEntry'
        >         __alloc_traits::destroy(__alloc(), std::__to_address(--__soon_to_be_end));
        >                                                              ^ ~~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/vector:828:29: note: in instantiation of member function 'std::vector<FilterEntry>::__base_destruct_at_end' requested here
        >   void __clear() _NOEXCEPT {__base_destruct_at_end(this->__begin_);}
        >                             ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:433:9: note: in instantiation of member function 'std::vector<FilterEntry>::__clear' requested here
        >         __clear();
        >         ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:49:5: note: in instantiation of member function 'std::vector<FilterEntry>::~vector' requested here
        >     delete __ptr;
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<std::vector<FilterEntry>>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:86:19: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::~unique_ptr' requested here
        > SalGtkFilePicker::SalGtkFilePicker( const uno::Reference< uno::XComponentContext >& xContext ) :
        >                   ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.hxx:38:8: note: forward declaration of 'FilterEntry'
        > struct FilterEntry;
        >        ^
        > In file included from vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:28:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/awt/SystemDependentXWindow.hpp:8:
        > In file included from include/com/sun/star/uno/Type.hxx:29:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:169:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/bitset:129:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/string:548:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/allocator.h:128:58: error: invalid application of 'sizeof' to an incomplete type 'FilterEntry'
        >             _VSTD::__libcpp_deallocate((void*)__p, __n * sizeof(_Tp), _LIBCPP_ALIGNOF(_Tp));
        >                                                          ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/allocator_traits.h:282:13: note: in instantiation of member function 'std::allocator<FilterEntry>::deallocate' requested here
        >         __a.deallocate(__p, __n);
        >             ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:434:25: note: in instantiation of member function 'std::allocator_traits<std::allocator<FilterEntry>>::deallocate' requested here
        >         __alloc_traits::deallocate(__alloc(), this->__begin_, capacity());
        >                         ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:49:5: note: in instantiation of member function 'std::vector<FilterEntry>::~vector' requested here
        >     delete __ptr;
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<std::vector<FilterEntry>>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:86:19: note: in instantiation of member function 'std::unique_ptr<std::vector<FilterEntry>>::~unique_ptr' requested here
        > SalGtkFilePicker::SalGtkFilePicker( const uno::Reference< uno::XComponentContext >& xContext ) :
        >                   ^
        > vcl/unx/gtk3/fpicker/SalGtkFilePicker.hxx:38:8: note: forward declaration of 'FilterEntry'
        > struct FilterEntry;
        >        ^
        
        Change-Id: I6f76dc24b12214eda75d3a5bb91a0fe120e38880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141822
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [2c05c6ead206659b1cbd7b794aa81e87694a251a]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from vcl/unx/gtk3/gtkinst.cxx:12:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/deque:181:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type '(anonymous namespace)::IMHandler'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<(anonymous namespace)::IMHandler>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::IMHandler>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/unx/gtk3/gtkinst.cxx:18108:5: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::IMHandler>::~unique_ptr' requested here
        >     GtkInstanceDrawingArea(GtkDrawingArea* pDrawingArea, GtkInstanceBuilder* pBuilder, a11yref xA11y, bool bTakeOwnership)
        >     ^
        > vcl/unx/gtk3/gtkinst.cxx:17947:7: note: forward declaration of '(anonymous namespace)::IMHandler'
        > class IMHandler;
        >       ^
        
        Change-Id: I555fc974762ba75f28705a3c4673956db275009f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141823
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [51d366712c55c61bea5169c238098d7007e4ce20]

        ChartTest: inherit from UnoApiTest
        
        Change-Id: Ie826b66364f61bdab555228ca3a348f86b34847f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141824
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [4b0f51efbcb9e71034089f431117e6bac92a26b2]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from vcl/source/app/salvtables.cxx:26:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/awt/XWindow.hpp:6:
        > In file included from workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/awt/XWindow.hdl:13:
        > In file included from workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XComponent.hdl:7:
        > In file included from workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:6:
        > In file included from include/com/sun/star/uno/Any.h:30:
        > In file included from include/rtl/ustring.hxx:34:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:168:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'SalFlashAttention'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<SalFlashAttention>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<SalFlashAttention>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > vcl/source/app/salvtables.cxx:292:20: note: in instantiation of member function 'std::unique_ptr<SalFlashAttention>::~unique_ptr' requested here
        > SalInstanceWidget::SalInstanceWidget(vcl::Window* pWidget, SalInstanceBuilder* pBuilder,
        >                    ^
        > vcl/inc/salvtables.hxx:172:7: note: forward declaration of 'SalFlashAttention'
        > class SalFlashAttention;
        >       ^
        
        Change-Id: I49523c8db5b3fdd4dc5614fdb5c6f8ced73f5eca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c3bf75187741d19beb4698f13a11cd3c951fb08]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d195123be4e11c5eeca6d5eace878fecbf8380a8
          - Fix typo
            
            Change-Id: I3b533183d82a707ee837cd584d3e9ed3862c2ed5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141827
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [ec27f2e5e39034ac4b38323149df72be28cba274]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from starmath/source/ElementsDockingWindow.cxx:20:
        > In file included from starmath/inc/ElementsDockingWindow.hxx:22:
        > In file included from include/sfx2/dockwin.hxx:22:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'ElementData'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<ElementData>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<ElementData>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:64:13: note: in instantiation of member function 'std::unique_ptr<ElementData>::~unique_ptr' requested here
        >     __loc->~_Tp();
        >             ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:89:12: note: in instantiation of function template specialization 'std::__destroy_at<std::unique_ptr<ElementData>, 0>' requested here
        >     _VSTD::__destroy_at(__loc);
        >            ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/allocator_traits.h:317:16: note: in instantiation of function template specialization 'std::destroy_at<std::unique_ptr<ElementData>, 0>' requested here
        >         _VSTD::destroy_at(__p);
        >                ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:834:25: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<ElementData>>>::destroy<std::unique_ptr<ElementData>, void, void>' requested here
        >         __alloc_traits::destroy(__alloc(), std::__to_address(--__soon_to_be_end));
        >                         ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:828:29: note: in instantiation of member function 'std::vector<std::unique_ptr<ElementData>>::__base_destruct_at_end' requested here
        >   void __clear() _NOEXCEPT {__base_destruct_at_end(this->__begin_);}
        >                             ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:433:9: note: in instantiation of member function 'std::vector<std::unique_ptr<ElementData>>::__clear' requested here
        >         __clear();
        >         ^
        > starmath/source/ElementsDockingWindow.cxx:455:20: note: in instantiation of member function 'std::vector<std::unique_ptr<ElementData>>::~vector' requested here
        > SmElementsControl::SmElementsControl(std::unique_ptr<weld::IconView> pIconView)
        >                    ^
        > starmath/inc/ElementsDockingWindow.hxx:35:8: note: forward declaration of 'ElementData'
        > struct ElementData;
        >        ^
        
        Change-Id: Iaae76ed5e59d04da32b468a69052ef305ca8005a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141819
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9fffd745a755c1459911ac8369c7a25d5f9bac5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b122dcc35b2015c8ffd0f826dd99edfeeebb39d1
          - tdf141474 CreateUnoListener function accepts keyword arguments
            
            -  literals and links added to improve page legibility
            -  'related to' items added
            -  Multiple text clarifications and additionss
            Change-Id: I0d7515783cb53f382ff2246a4a377ffb871a8284
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141578
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-10-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2e34b2f32586947ca1e93dee9ab482372d604d10]

        Consistently set document view also for zoom event
        
        And extract this code to a dedicated function.
        
        The problem was, that creating a new view sets the document's current
        view shell (in SwViewGlueDocShell); upon destruction, document's view
        shell is set to nullptr. In desktop case, document view shell is then
        reset to another active shell e.g. inside "grab focus" event, which
        makes all following operations safe. But in gtktiledviewer case, the
        "grab focus" event is not handled, so setClientZoomInThread resulted
        in eventual nullptr dereference.
        
        It was workarounded in commit 25de85bc3ce2d2f9b7736f65492f42579048da27
          Date   Fri Oct 21 21:14:04 2022 +0200
            nullptr check
        
        but that was not the proper fix.
        
        Possibly it could also be reasonable to start handling "focus-in-event"
        [1] in gtktiledviewer; but since just setting the view consistently in
        setClientZoomInThread solves the problem, it looks excessive.
        
        This reverts commit 25de85bc3ce2d2f9b7736f65492f42579048da27.
        
        [1] https://docs.gtk.org/gtk3/signal.Widget.focus-in-event.html
        
        Change-Id: Iac4ff4e9b043aec0e0af6ed811c0e7f018378271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141753
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [d5bb58460edf45c3f7806e0772b9859837879bf8]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from sc/source/ui/dbgui/dbnamdlg.cxx:20:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type '(anonymous namespace)::DBSaveData'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<(anonymous namespace)::DBSaveData>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::DBSaveData>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > sc/source/ui/dbgui/dbnamdlg.cxx:46:36: note: in instantiation of member function 'std::unique_ptr<(anonymous namespace)::DBSaveData>::~unique_ptr' requested here
        > static std::unique_ptr<DBSaveData> xSaveObj;
        >                                    ^
        > sc/source/ui/dbgui/dbnamdlg.cxx:42:7: note: forward declaration of '(anonymous namespace)::DBSaveData'
        > class DBSaveData;
        >       ^
        
        Change-Id: I65850c11a42886484dfbfbd4566ad71486337bc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141816
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [ef862ba4b1b0b4799ec9afd294cf1b2c84f7ef1f]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from sfx2/source/dialog/StyleList.cxx:20:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'TreeViewDropTarget'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<TreeViewDropTarget>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<TreeViewDropTarget>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > sfx2/source/dialog/StyleList.cxx:72:12: note: in instantiation of member function 'std::unique_ptr<TreeViewDropTarget>::~unique_ptr' requested here
        > StyleList::StyleList(weld::Builder* pBuilder, SfxBindings* pBindings,
        >            ^
        > sfx2/source/inc/StyleList.hxx:53:7: note: forward declaration of 'TreeViewDropTarget'
        > class TreeViewDropTarget;
        >       ^
        
        Change-Id: I30c0c21a7366a9f45d8b4ce7c61270dac804c0b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141817
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [3307e4ae55d5286c37853a58ffaf582c7e16a2ba]

        external/skia: Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from workdir/UnpackedTarball/skia/src/sksl/dsl/DSLFunction.cpp:8:
        > In file included from workdir/UnpackedTarball/skia/include/sksl/DSLFunction.h:11:
        > In file included from workdir/UnpackedTarball/skia/include/private/SkSLDefines.h:14:
        > In file included from workdir/UnpackedTarball/skia/include/private/SkTArray.h:16:
        > In file included from workdir/UnpackedTarball/skia/include/private/SkTemplates.h:18:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'SkSL::Expression'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<SkSL::Expression>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<SkSL::Expression>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > workdir/UnpackedTarball/skia/include/sksl/DSLFunction.h:100:43: note: in instantiation of member function 'std::unique_ptr<SkSL::Expression>::~unique_ptr' requested here
        >         args.push_back(DSLExpression(var).release());
        >                                           ^
        > workdir/UnpackedTarball/skia/include/private/SkSLDefines.h:21:7: note: forward declaration of 'SkSL::Expression'
        > class Expression;
        >       ^
        
        and
        
        > In file included from workdir/UnpackedTarball/skia/src/sksl/dsl/DSLVar.cpp:8:
        > In file included from workdir/UnpackedTarball/skia/include/sksl/DSLVar.h:11:
        > In file included from workdir/UnpackedTarball/skia/include/sksl/DSLExpression.h:11:
        > In file included from workdir/UnpackedTarball/skia/include/private/SkTArray.h:16:
        > In file included from workdir/UnpackedTarball/skia/include/private/SkTemplates.h:18:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'SkSL::Statement'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<SkSL::Statement>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<SkSL::Statement>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > workdir/UnpackedTarball/skia/include/sksl/DSLVar.h:38:5: note: in instantiation of member function 'std::unique_ptr<SkSL::Statement>::~unique_ptr' requested here
        >     DSLVarBase() : fType(kVoid_Type), fDeclared(true) {}
        >     ^
        > workdir/UnpackedTarball/skia/include/private/SkSLDefines.h:22:7: note: forward declaration of 'SkSL::Statement'
        > class Statement;
        >       ^
        
        and
        
        > In file included from workdir/UnpackedTarball/skia/src/gpu/ganesh/effects/GrBlendFragmentProcessor.cpp:8:
        > In file included from workdir/UnpackedTarball/skia/src/gpu/ganesh/effects/GrBlendFragmentProcessor.h:12:
        > In file included from workdir/UnpackedTarball/skia/include/core/SkRefCnt.h:16:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'GrFragmentProcessor'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<GrFragmentProcessor>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<GrFragmentProcessor>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > workdir/UnpackedTarball/skia/src/gpu/ganesh/effects/GrBlendFragmentProcessor.h:36:17: note: in instantiation of member function 'std::unique_ptr<GrFragmentProcessor>::~unique_ptr' requested here
        >     return Make(std::move(src), std::move(dst), mode, /*shareBlendLogic=*/false);
        >                 ^
        > workdir/UnpackedTarball/skia/src/gpu/ganesh/effects/GrBlendFragmentProcessor.h:14:7: note: forward declaration of 'GrFragmentProcessor'
        > class GrFragmentProcessor;
        >       ^
        
        Change-Id: I47f7280af3de7ed7b1915d4e5d2f7b52e4f26a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141815
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [d1b867e42e0097cdbc7097e7c8eb83da8885ec4f]

        external/pdfium: Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from workdir/UnpackedTarball/pdfium/core/fxcodec/jbig2/JBig2_SymbolDict.cpp:7:
        > In file included from workdir/UnpackedTarball/pdfium/core/fxcodec/jbig2/JBig2_SymbolDict.h:10:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/memory:881:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__memory/shared_ptr.h:30:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'CJBig2_Image'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<CJBig2_Image>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<CJBig2_Image>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:64:13: note: in instantiation of member function 'std::unique_ptr<CJBig2_Image>::~unique_ptr' requested here
        >     __loc->~_Tp();
        >             ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/construct_at.h:89:12: note: in instantiation of function template specialization 'std::__destroy_at<std::unique_ptr<CJBig2_Image>, 0>' requested here
        >     _VSTD::__destroy_at(__loc);
        >            ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/allocator_traits.h:317:16: note: in instantiation of function template specialization 'std::destroy_at<std::unique_ptr<CJBig2_Image>, 0>' requested here
        >         _VSTD::destroy_at(__p);
        >                ^
        > ~/llvm/inst/bin/../include/c++/v1/__split_buffer:304:25: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::unique_ptr<CJBig2_Image>>>::destroy<std::unique_ptr<CJBig2_Image>, void, void>' requested here
        >         __alloc_traits::destroy(__alloc(), _VSTD::__to_address(--__end_));
        >                         ^
        > ~/llvm/inst/bin/../include/c++/v1/__split_buffer:145:10: note: in instantiation of member function 'std::__split_buffer<std::unique_ptr<CJBig2_Image>, std::allocator<std::unique_ptr<CJBig2_Image>> &>::__destruct_at_end' requested here
        >         {__destruct_at_end(__new_last, false_type());}
        >          ^
        > ~/llvm/inst/bin/../include/c++/v1/__split_buffer:103:10: note: in instantiation of member function 'std::__split_buffer<std::unique_ptr<CJBig2_Image>, std::allocator<std::unique_ptr<CJBig2_Image>> &>::__destruct_at_end' requested here
        >         {__destruct_at_end(__begin_);}
        >          ^
        > ~/llvm/inst/bin/../include/c++/v1/__split_buffer:361:5: note: in instantiation of member function 'std::__split_buffer<std::unique_ptr<CJBig2_Image>, std::allocator<std::unique_ptr<CJBig2_Image>> &>::clear' requested here
        >     clear();
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:1536:49: note: in instantiation of member function 'std::__split_buffer<std::unique_ptr<CJBig2_Image>, std::allocator<std::unique_ptr<CJBig2_Image>> &>::~__split_buffer' requested here
        >     __split_buffer<value_type, allocator_type&> __v(__recommend(size() + 1), size(), __a);
        >                                                 ^
        > ~/llvm/inst/bin/../include/c++/v1/vector:1568:9: note: in instantiation of function template specialization 'std::vector<std::unique_ptr<CJBig2_Image>>::__push_back_slow_path<std::unique_ptr<CJBig2_Image>>' requested here
        >         __push_back_slow_path(std::move(__x));
        >         ^
        > workdir/UnpackedTarball/pdfium/core/fxcodec/jbig2/JBig2_SymbolDict.h:26:16: note: in instantiation of member function 'std::vector<std::unique_ptr<CJBig2_Image>>::push_back' requested here
        >     m_SDEXSYMS.push_back(std::move(image));
        >                ^
        > workdir/UnpackedTarball/pdfium/core/fxcodec/jbig2/JBig2_SymbolDict.h:16:7: note: forward declaration of 'CJBig2_Image'
        > class CJBig2_Image;
        >       ^
        
        Change-Id: Ibaeb72eefdd58ca39ffa6bb8f6c5d7088ce51ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141812
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [3c5a98135fe55bf48cfd11b4e163906fbfe0d115]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from cui/source/dialogs/cuihyperdlg.cxx:23:
        > In file included from include/comphelper/lok.hxx:14:
        > In file included from include/rtl/ustring.hxx:34:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:168:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'IconChoicePage'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<IconChoicePage>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<IconChoicePage>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > cui/source/inc/iconcdlg.hxx:43:5: note: in instantiation of member function 'std::unique_ptr<IconChoicePage>::~unique_ptr' requested here
        >     IconChoicePageData(OString aId, std::unique_ptr<IconChoicePage> xInPage)
        >     ^
        > cui/source/inc/iconcdlg.hxx:28:7: note: forward declaration of 'IconChoicePage'
        > class IconChoicePage;
        >       ^
        
        Change-Id: I789c85e0661969679c88fea1dfc7a65475fb3037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141811
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [16045087e6541925be340d585e68a35147489b59]

        Address a constexpr template point of instantiation issue
        
        ...that hits at least when building with Clang and --with-latest-c++ against
        recent libc++ or MSVC standard library (where C++20 and esp. C++23 made more and
        more class template member functions constexpr).  My understanding is that there
        is some leeway at what point a compiler should instantiate such function
        specializations, and Clang decides to instantiate constexpr ones early (cf.
        <https://github.com/llvm/llvm-project/commit/242ad89a15d5466d166d47978bfff983d40ab511>
        "C++11 half of r147023: In C++11, additionally eagerly instantiate:" and its "Do
        not defer instantiations of constexpr functions" comment, and the discussion at
        <https://discourse.llvm.org/t/point-of-instantiation-of-constexpr-function-template/65129>).
        
        > In file included from basic/source/comp/codegen.cxx:21:
        > In file included from include/basic/sberrors.hxx:23:
        > In file included from include/vcl/errcode.hxx:23:
        > In file included from include/rtl/ustring.hxx:34:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/ostream:168:
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:47:19: error: invalid application of 'sizeof' to an incomplete type 'SbiExprList'
        >     static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
        >                   ^~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:281:7: note: in instantiation of member function 'std::default_delete<SbiExprList>::operator()' requested here
        >       __ptr_.second()(__tmp);
        >       ^
        > ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:247:75: note: in instantiation of member function 'std::unique_ptr<SbiExprList>::reset' requested here
        >   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
        >                                                                           ^
        > basic/source/inc/expr.hxx:118:66: note: in instantiation of member function 'std::unique_ptr<SbiExprList>::~unique_ptr' requested here
        >     SbiExprNode( const SbiSymDef&, SbxDataType, SbiExprListPtr = nullptr );
        >                                                                  ^
        > basic/source/inc/expr.hxx:30:7: note: forward declaration of 'SbiExprList'
        > class SbiExprList;
        >       ^
        
        Change-Id: I3bde85164ae6b829b7c24d9645fd412ed3fd815d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141810
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ff56812741029ad17204cff53357751687d9b6c]

        tdf#151484 Data Validity list looses separation when saving as XLS
        
        regression from
            commit fbb41798b86c5ed35eb80aa07a5ee7c9866ac4e8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Mar 18 09:46:52 2022 +0200
            tdf#133603 remove some string copying
        
        Change-Id: Ie241a7d5e54673b35c643c7c20dc100ba7925647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1b7d7a8d16d222536534ccf92576ed1eb05e1a8]

        tdf#126788 speed up export to pdf of complex table document
        
        Shaves another 20% off the export time, bringing us to roughly the same
        time as before commit
            commit 4fc3466d23010d9553c31c662650072483b81588
            Date:   Thu Apr 14 09:19:35 2022 +0200
            do not cache layout glyphs if fallback is involved
        
        Change-Id: Ic595d4be7b05d857f3328ec28d1ef1232203cb03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141798
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-25  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [ac0e74209c4f7a7eb7702468cecd3b996227c278]

        tdf#149189 detect and handle graphic change on Sw OLE
        
        If in any way a used SW OLE Chart gets changed
        (example in task uses a script and UNO API), detect
        this and react accordingly. Use getGraphicVersion()
        from EmbeddedObjectRef to decide when to reset bufferd
        graphic data. It gets incremented at all occasions
        where the graphic changes due to being used for a
        similar case already.
        An alternative would be to extend SwOLEListener_Impl
        with a XModifyListener as it is done in
        EmbedEventListener_Impl, that would require all the
        (add|remove)ModifyListener calls and/ managing these,
        plus having a 2nd listener to these when
        EmbeddedObjectRef already provides that. Tried that
        this works also if an alternative would be needed.
        
        Change-Id: Ic27088b0241aa4b5ecfc3c2b6e64994d720b3546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141803
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e993ae7ef6d564a5ab8e2b9c04182a218472d106]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fa05882a59d44d7de39868cd0a77701a4ac61d78
          - tdf#139270 Remove Font dialog screenshot
            
            Remove font dialog screenshot.
            
            * The screenshot command "make screenshot" does not produce
            a valid and usefull screenshot of the Font dialog.
            
            * Manual addition of any localized screenshot is not practical at the
            current state of the screeshooting development (~40 languages)
            
            * For the moment, removal of the bad screenshot is advised until the
            screenshooting get fixed or improved for this kind of dialog.
            
            Change-Id: Idcb0ffb7cc6f222a84bf09f3ef91ca379c05adc2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141809
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c49e352ec8a5840943cadf6382db8fd812b7250]

        CppunitTest_sw_macros_test: inherit from UnoApiTest
        
        Change-Id: I2ce2c55bd718d153f038736e5474d6ead4f8c5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141806
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Caolán McNamara  <caolanm@redhat.com>  [9c4b2231eeb358858b9da573511e1f7ff1e85fbc]

        cid#1516423 Uninitialized scalar field
        
        Change-Id: If60dfb726ba42bcb96a2d218bb81cb700f4c71f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141805
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-25  dldld  <LibreOfficeContribution@dldld.de>  [e5aa82b259e35e3976734af38fff643ea28767df]

        tdf#151608: Fix crash in disposing remotecontrol listener
        
        Clearing the listener twice seems to be the problem here, because the WeakComponentImplHelperBase::dispose() tries to access the cleared listener when it was already cleared, causing the crash.
        
        The problem which is fixed by this commit appears when the Impress Remote App is closed, which is connected to a running presentation. So closing the app "kills" the presentation. I think I have seen this also happening, when the connection was closed due to bad wifi. Which also makes sense as the communication thread is getting stopped and the listener will be destroyed.
        
        Change-Id: I3c8fa535cfd4d82c846494f76ffb9ce43ebd606a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141468
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [0d2606e30abf3d335abc349165b016077a0c0793]

        CppunitTest_oox_export: inherit from UnoApiTest
        
        Change-Id: I46ae3ce5b1fdf6ef5c9d9a22cd589ed04d08ca2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141802
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [be3ac27bc83e4b27f55446dde42c45e4d5cc788e]

        Simplify recently added code a bit
        
        Change-Id: If4e3eec9f3a32cc94ffe0f148704a949328b4e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141800
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [73d7335e46a48e684107e226a2dfa0a3e76575de]

        CppunitTest_oox_drawingml: inherit from UnoApiTest
        
        Change-Id: I1bfea3ac8f07cd5a13ee78ce94fb04bfe55fa5b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141799
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe1681b902caed0aaf9157ec31062d7627a1e1b9]

        no need to call GetGlyphs() again
        
        removes a copy from a hot path
        
        Change-Id: I28c7b49643448232b6a6a4ab409dd3e36c751aeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff97d047393c955af2f3173a9c7e2534a059a058]

        UnoApiTest: use validate when saving files
        
        Change-Id: I0f04fae8b4ff922f5e14ae413cd63cc92a66077e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141797
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [42a7b48065977d11bc99ab32dadbfde5f1209438]

        tdf#126788 speed up export to pdf of complex table document
        
        We can avoid an allocation in the common case, shaves 10% off the
           --convert-to pdf
        time.
        
        Change-Id: I9263d3dc8fd6a1d74cd063ba13e2e0160f7a9dd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-25  Stephan Bergmann  <sbergman@redhat.com>  [8e108264fee9e945d7f9fc007d11dfb4b180e775]

        Add missing semicolon
        
        ...in code recently introduced in 0bf8a781ffec13b4fbcb96a2e9349b423a92cb1d
        "related tdf#151548 sw: KEY_DOWN access to FieldmarkWithDropDownButton", which
        at least GCC 12 and recent GCC 13 trunk in an --enable-dbgutil
        --enable-optimized --enable-werror build diagnosed as
        
        > sw/source/core/crsr/bookmark.cxx: In member function ‘void sw::mark::FieldmarkWithDropDownButton::LaunchPopup()’:
        > sw/source/core/crsr/bookmark.cxx:669:30: error: ‘this’ pointer is null [-Werror=nonnull]
        >   669 |         m_pButton->Invalidate();
        >       |         ~~~~~~~~~~~~~~~~~~~~~^~
        > cc1plus: all warnings being treated as errors
        
        Change-Id: I1e6d7e7e0244259674d41edff4c07a2de2b74bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141791
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  László Németh  <nemeth@numbertext.org>  [e3ae86a38d6282db0f54d3545015ed22ee868ae5]

        tdf#124603 sw: pressing Up/Down triggers pending spell checking
        
        Modified text wasn't checked until the next edit operation,
        so spelling mistake of the last edited word could go unnoticed.
        Leaving the edited line by pressing Up/Down triggers
        pending spell checking to fix the problem in most cases.
        
        Regression from commit 4c91e94e892943ef5e031d65f6f42864233cb4cd
        "tdf#92036: sw: fix idle spelling loop",
        
        Note: add unit test to tdf#92036, too.
        
        Change-Id: I865eb7b5d8f872421230d457989e24c3b489690d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141728
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-25  Miklos Vajna  <vmiklos@collabora.com>  [2486d99c6053af1414117faac2c0db18c0d344c4]

        sw: document SwFormatVertOrient
        
        Mostly because both orientation and relation are sal_Int16, so it's easy
        to get these wrong.
        
        Change-Id: I0647276822c1281382055ec7cf528efb70e6797a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141781
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-25  OmkarAcharekar  <omkaracharekar12@gmail.com>  [4cec1ec1d575ff0328f014de57abb591e3c7ae11]

        tdf#145759 Use symbolic constants instead of magic numerical constants
        
        Change-Id: I68f9dd0bbe5a98de35253220dc33382139b4950e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141657
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-25  Martin Srebotnjak  <miles@filmsi.net>  [0d47b49c93283d4e5cf4372dd0e981180b995972]

        Update git submodules
        
        * Update translations from branch 'master'
          to 424bbc087c04b18a71d824513087f3094efb6385
          - Updated Slovenian translation
            
            Change-Id: I13e652d30802c4434eeb476744fb8095901a2c91
            
2022-10-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [7cda0032806c214ecb998df3a777fd10403fd246]

        tdf#151742 Sifr Fix Border Lines Placeholder in Calc's Sidebar
        
        Change-Id: I369164a55636a86192cdf3df0d070c90af96a7c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141789
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c32785992106de61569f0df470aaa7e6b70ebb7d]

        Add SparkLines dialogs for screenshopts
        
        Change-Id: Id63100dc0b74183c70ed5de278b6b06b53fed57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141783
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-10-25  Eike Rathke  <erack@redhat.com>  [20ebccd6b349a1d9d3e057de55933c2805ff5d1a]

        Update to ICU 72.1
        
        https://icu.unicode.org/download/72
        
        Unicode 15
        https://blog.unicode.org/2022/09/announcing-unicode-standard-version-150.html
        
        CLDR 42
        https://blog.unicode.org/2022/10/unicode-cldr-v42-available.html
        
        New scripts:
        USCRIPT_KAWI
        USCRIPT_NAG_MUNDARI
        
        New Unicode blocks:
        UBLOCK_ARABIC_EXTENDED_C
        UBLOCK_CJK_UNIFIED_IDEOGRAPHS_EXTENSION_H
        UBLOCK_CYRILLIC_EXTENDED_D
        UBLOCK_DEVANAGARI_EXTENDED_A
        UBLOCK_KAKTOVIK_NUMERALS
        UBLOCK_KAWI
        UBLOCK_NAG_MUNDARI
        
        Change-Id: I8822791e914e6700358b817a1af94b7dcd16b26d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141788
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [0692cd8d199c31f761a4c7b0c16a94d3e195b2dc]

        CppunitTest_sd_svg_export_tests: inherit from UnoApiTest
        
        Change-Id: Ib630949127d7087cddbb92737528690cafe9be26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141782
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [b1e7f74fa9b351a132e90f78dece51124c3646cf]

        WB_BEVELBUTTON and PushButtonValue::mbBevelButton are unused
        
        Change-Id: Ibc2605261de84337f4880f07a5ecb25e934c0251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141759
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [dd1069d77a261ceb06b4fa6c1e564a056f8b122c]

        CppunitTest_xmloff_draw: inherit from UnoApiTest
        
        Change-Id: Ia6e083df4dfb6a6354f3bbe2f5eabaca559281b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141771
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [b2d6ad64473527f88dfb7088376ccf1242d97666]

        zlib: upgrade to release 1.2.13
        
        Fixes CVE-2022-37434
        
        Removed two patches as fixed upstream.
        
        Change-Id: I10465b7eafc4952cf8dc64e6d7a77f5e5255a386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141757
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [ea5843b67f1c2006aa1f68f2d00a991e1d463262]

        Python3: update to 3.8.15
        
        * Fixes CVE-2022-40674
        * Removed 0001-3.6-bpo-17239-Disable-external-entities-in-SAX-parse.patch.1 as fixed upstream
        
        Change-Id: I8e71f9a6b013ca4c45bf8774b284be98eee71bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141691
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Eike Rathke  <erack@redhat.com>  [c3247f0380b4ffe90672a0442687593531c5774b]

        Use constexpr kTimeSignificantRound for all occurrences
        
        Change-Id: I3d55c5ee0d0e7a803f95c0fe9f67ee15fe814b65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141773
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-24  Eike Rathke  <erack@redhat.com>  [6d4e290bfd38664eebb1a394563e89a845a85078]

        Related: tdf#140554 Function Wizard, FIXED() second parameter default is 2
        
        Change-Id: Ibf01670874f753a3b7a8ad79e46175f103a11619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141767
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [9cb1b33a4afacdb5b5c10542d1d0626a531a769d]

        CppunitTest_xmloff_style: inherit from UnoApiTest
        
        Change-Id: If0f956336581438927ab3e01a50374c15b43bcd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141763
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [d10c2d772fbf376772f836933f85c548cb66cac8]

        CppunitTest_filter_svg: inherit from UnoApiTest
        
        Change-Id: I6edf5254a8ec0caae317526cf9d6bac21aaed6f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141731
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8e2deed1457e3ab712df2820331136d531927522]

        sw: Move getGrammarContact function into GrammarContact and rename
        
        Change-Id: Id89d7eabb465f047188f8f74bd823cfb3b2f2aff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141433
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [56b5046e03d2db684fe35239acfea553ff7d9b7f]

        _MSC_VER is more appropriate to guard MSVC-specific #pragma
        
        Thanks to sberg for noticing this
        
        Change-Id: I37a3031cbfa3f8a0751bab126bd742dcec36664f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141743
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [910bbd320f0019737add834a54aff7ab56247681]

        CppunitTest_xmloff_text: inherit from UnoApiTest
        
        Change-Id: Ic876ff8d67a7da22e381510bebf3ddb80139a81b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141760
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [ca44f2d25b3f79d2d3f1867be540e335b9044b5b]

        Revert "CppunitTest_sc_anchor_test: inherit from ScBootstrapFixture"
        
        This reverts commit 4d9b83a417bbde8148b67d2ab0abe9f4ae285276.
        
        I was wrong in my previous commit. Eventually, we should get
        rid of ScBootstrapFixture instead
        
        Change-Id: I005bb95b543ad1b66330e3173ab2ea1793a4bd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141733
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Paris Oplopoios  <paris.oplopoios@collabora.com>  [a03a47bb0791d88fedb2650bca412c28469b0b27]

        tdf#150888 Scale down PPI if it would result in a tiny image
        
        The reason for the blurry document in tdf#150888 is that the image is
        tiny. PPI is 2540 in that image but when using the window bounding box
        (96, 81) this results in a very small image that the .odt then scales up
        which makes it blurry.
        
        Apart from that, when opening the extracted .wmf in Draw it's also very
        small, around 0.04" squared.
        
        Because MM_ANISOTROPICs definition allows for arbritrary scaling, when
        an image would be smaller than an inch squared the PPI is scaled down to
        either the images width or height. This makes the extracted WMF match
        the size of competitor office suites and fix the blur bug without
        breaking past tests.
        
        Change-Id: I11eab879848d9308f818708a91fd9eb91fc65200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141533
        Tested-by: Jenkins
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-24  Stephan Bergmann  <sbergman@redhat.com>  [76601f1e935ec7cebbfec26c988bf6f77c638052]

        Always include target CPU architecture in About dialog Version Information
        
        ...not just for Windows.  This information is occasionally useful also on other
        platforms that can run executables targeting different CPU architectures (like
        Linux x86 and x86-64, or macOS Aarch64 and x86-64), e.g. when trying to track
        down why a bug reporter's system doesn't find a JRE matching the architecture of
        their LibreOffice installation.
        
        For simplicity, use the existing _ARCH bootstrap variable, even if its values
        differ from the hardcoded "x64" and "x86" that have been used here so far.
        
        Change-Id: I76b40dd044397bf19e014d8a56d0314f455bc8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141768
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [341a048611a0314374bd8f051eb04378ee41f9b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ef3d1a4631cdbd4c3a592b5dfa57bb82df239fb8
          - Removed executable bits on PNG files
            
            Change-Id: I2bcfc009f9b48c8625b702aa613aa6bc0247609f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141719
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8507f63a7f8bd188d45424c4b0a2a043fd93e308]

        Fix typos
        
        Change-Id: Id7912ef0ac140688dea773143381de1cc1ed5ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141721
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bd237b826f096d6b84257c1b09ce140ed3f54e25]

        Fix typo
        
        Change-Id: Id974647a7e08298aa6ebd19dcc674fd4f4066b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141720
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e45aaa991a7e783397d13179dfd450b43cbcae80]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b282e0ba57c7de06d042decddc0ff48927dc80bf
          - Removed executable bits on xhp file
            
            Change-Id: I8a02cb2e1a39ebbf177bfc3336bff4331714a0b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141727
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-10-24  Eike Rathke  <erack@redhat.com>  [633db8a099e3041bc10fb1709311bd6055ab61a2]

        Resolves: tdf#140554 Function Wizard, FIXED() second parameter is optional
        
        Change-Id: I1d559601f0cace4719aa6f8adc4e4230494e905d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141766
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0b665c5389e6100ca4be200a4a2f6fdd35b12f52]

        Fix typo
        
        Change-Id: I71e47a53d31b4d5c7e5a4baf85d49b798602865b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141722
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [331a013ee3dffd39c1999ab56f3a18160e76f50a]

        UnoApiTest: factor out common code
        
        Change-Id: Ia8874d65ea8d7eb26d10b18e37ba2bac1a7d756b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141730
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [60b9008d20641b4e454431c148fa8d77c98a75c8]

        Avoid "deprecated" warning on Windows, too
        
        Change-Id: I199adcb3e8b7fabc625b3ac1735326934cc84088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141739
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Miklos Vajna  <vmiklos@collabora.com>  [47bc36c0f87ec2d0329260bcb98d62c7667a5dd1]

        sw: make sure mark container is sorted before calling equal_range()
        
        ooo89390-1.doc from crashtesting failed to export to ODT due to this.
        
        The trouble is that equal_range() needs a sorted container, but a
        listener may make the container unsorted.
        
        Fix the problem by re-sorting the container after calling the listener.
        
        A full ODT export is not needed to trigger the crash, it's enough to
        hide deletions.
        
        Change-Id: Id5601d7659d534c0bbfa84845abf0e6bb8e94c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141765
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [3875cc3056a0955293042cd4eaaaef7d8f7e2ee8]

        make all the color menubuttons the same layout
        
        Change-Id: Id4c3a3ae0b9bf7cfe10b0f455e334638bcddbffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Eike Rathke  <erack@redhat.com>  [5ce6de864380f1eabbd78656ff6cc31920c534d2]

        Related: tdf#136615 Do not round a DateTime clock format into the next day
        
        =TEXT(44858+86399.99/86400;"yyyy-mm-dd hh:mm:ss")
        gave  2022-10-25 00:00:00  instead of  2022-10-24 23:59:59
        whereas
        =TEXT(44858+86399.99/86400;"yyyy-mm-dd hh:mm:ss.000")
        correctly results in  2022-10-24 23:59:59.990
        
        Change-Id: Ib2ec5281eeb8590023e5137e816a8ad8fde2a8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141764
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [fe0795c52f783a0cfb9e90aab4ae6fac4eac68df]

        lok: Undefine DELETE after including Windows headers
        
        This identifier is used e.g. in offapi/com/sun/star/awt/Key.idl,
        include/vcl/keycod.hxx, and that silly define in Windows headers
        conflicts when building gtktiledviewer on Windows.
        
        This is similar to include/postwin.h.
        
        Change-Id: I177ab720864468e36b4f4b437a304cfe6ee09e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141737
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [262f65a306a8ae206f39a5ebb69ff9e967b24f48]

        T602ImportFilterDialog doesn't need to implement XLocalizable
        
        Change-Id: Iae2cb4d068a0fc1cdc3431fe8f736f1f45cc3d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [e70243e309bf5fd2f352c9de39f18108ea17a713]

        drop newly unused std::locale maResLocale
        
        Change-Id: I3d10189968d15dc7e7465cbbd6e19d42041c0a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141754
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b6082a657c111626f6b053489ad097fd02cef6f]

        add bisect configs
        
        Change-Id: I1588bd8c1ea844bfe997941554f0b8ed2cf21909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141532
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-24  Sarper Akdemir  <sarper.akdemir@collabora.com>  [adfdd2bee4d1d59bf1ee372d9c242cf0b691e423]

        tdf#151547 pptx import: workaround for COL_AUTO collision
        
        In the current implementation of ::Color, it is not possible
        to have fully transparent white text (since it collides with
        COL_AUTO and gets interpreted as Automatic Color).
        
        Implement a workaround for import of fully transparent white
        text color so that it isn't interpreted as the magic value
        COL_AUTO (i.e. instead of fully transparent #FFFFFF import
        as fully transparent #FFFFFE).
        
        Change-Id: Ide750093ef8a89f1424ddd8f4e9ee1e18209f2ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141439
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-24  Regina Henschel  <rb.henschel@t-online.de>  [9ad7df41572d67687221cb43d53cde27a45fff0f]

        tdf#83671 make SmartArt visible in import of xlsx
        
        Problem is, that Excel writes a zero size in xdr:xfrm for the SmartArt.
        With that the import generates a background size with zero width and
        height and no shapes at all in the SmartArt group. The diagram DOM is
        imported correctly. The actual size is not known until the row and column
        values of the anchor are evaluated.
        The idea of this patch is to correct the background size directly and to
        repeat the import of drawing.xml when the actual size is known.
        
        I noticed that in import of SmartArt in docx there is a similar problem
        that the SmartArt shapes are missing at some point, as can be seen in
        ShapeContextHandler::getShape(), about line 428. It uses
        ShapeDrawingFragmentHandler to import the shapes. To be able to use that
        handler too, I have moved its header file to include.
        The solution for docx uses a loop over the vector getExtDrawings(). But I
        have not seen a SmartArt case, where more then one element exists in it.
        
        Whether the shape is a diagram, is indirectly tested currently. The
        shape has yet no direct method for it.
        
        Change-Id: I9d705ed5bfb2894e9ce740ebf8589e06b4870bed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141571
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dba424efc15aa2915c38721c27edf0cc1d716bd1]

        sw: rename IGrammarContact*, SwGrammarContact* to GrammarContact*
        
        Change-Id: Ifa9effa5aa8eb014ebf120768893bc982ce73fd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141432
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [ebb3a72ba0c4f070c9c254c439147beea8b2d93d]

        Paint tiles on Windows
        
        A step toward enabling gtktiledviewer on Windows
        Not the nicest solution, but it does the job initially.
        
        Change-Id: I9144c2b899eb122e918123a70279cd50a4a02df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141710
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Tor Lillqvist  <tml@collabora.com>  [d4b33bda7363eaabc4ba77f3ff4bc47fc01418f6]

        Add distro-configs/CPLinux-LOKit from the co-22.05 vendor branch
        
        For now, just comment out those lines that don't match the configury
        options here in master.
        
        Change-Id: I38819e54e2f4ff3851c167603a1084072ef62700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141756
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [635a0b426e0ab47ec136af7d110354db862c59fa]

        Fix MulDivSaturate to avoid overflow
        
        Thanks to Caolan
        https://gerrit.libreoffice.org/c/core/+/110839/comments/5c47cab2_b0523546
        
        > oss-fuzz has come up with a case of n 9223372036854775807 m 72 d 127
        >
        > include/o3tl/unit_conversion.hxx:105:28: runtime error: signed integer
        > overflow: 9223372036854775807 + 63 cannot be represented in type 'long'
        
        Change-Id: I0fe26f6c854a90cf577a60528d15f3da5471b914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141711
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [87aef8ff9fa55dc8b51c6eb8ae07ab34236503c1]

        for windows HighContrast use COLOR_HOTLIGHT for hyperlink color
        
        use the same thing for both unvisited and visited
        
        Change-Id: Icce13ccb88c7ca35e655f01e8ebb8ac92869753c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bc919965d7709c676f7ad7ec6f133fa2e906e75e]

        Update git submodules
        
        * Update translations from branch 'master'
          to fd24cfed1fc78997d1b7366cb64fa8e57bc4e3f9
          - update translations for master
            
            and force-fix erorrs using pocheck
            
            Change-Id: I77de715af2955f9d540db10963cae833ecac2440
            
2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [09dc6fbcd8c441cb7706857ed66d197db9f26254]

        Related: tdf#151641 set windows WorkspaceColor similiar to other platforms
        
        from the same bg as the dialog/face, so we get a good "application background"
        color in dark mode
        
        Change-Id: Ieeb29ed1df177a91691b7b83d056af4068d0e170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141725
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [faca390c57841fa15616abdd8a679855971bc6d3]

        Drop Window::LogicMouse*
        
        As mentioned in commit 510bca3d3ab0b2fd21f0083b4e0fe14ff8c903c3,
        over the time these functions were changed; now they don't take
        logical coordinates, but pixels, so became true duplicates of
        corresponding Mouse* functions.
        
        The calls to SetLastMousePos are now made from LOKPostAsyncEvent
        uniformly.
        
        Change-Id: I2c8a9095719c0c8e21cf81342a286b00c1d1a41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-24  Kevin Suo  <suokunlong@126.com>  [5e3e507b1a68f5b9883337f1e55c54c2fc9de9fc]

        Drop {PDFFilterResId, getResStr, XsltResId} and use FilterResId in "filter"
        
        This is a followup to commit a97bae545d72d8b19f39aa9280c0f284c79d0f6c.
        
        Previously different areas within the "filter" module used their own "*ResId" code
        to get the translated string. They did the same thing without any difference in
        purpose and implementation.
        
        Unify this to use FilterResId instead.
        
        Change-Id: Idccf74601a89b5786e1f61a04631436147710bb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [0c4aa1157bb1b992fa5f887920194d67f52df752]

        cid#1516141 Dereference after null check
        
        Change-Id: Id779ae022269906a17f4f7637d7f634d5d7102d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141669
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-24  Miklos Vajna  <vmiklos@collabora.com>  [122419be4f7bf576f7db5456b8b6b1f6f700487f]

        sw content controls, alias: add PDF export
        
        Now that content controls have aliases, map that to PDF's description
        and then map the content to PDF's text when the content control is not
        in placeholder mode.
        
        This way the widget will have a description even if it's already filled
        in, which helps a11y.
        
        Change-Id: Ia66455eba26300c5dbb2d62b5858bac82546acf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141716
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-24  Noel Grandin  <noelgrandin@collabora.co.uk>  [1ea0ea19f1dc13c4191ab9d4222adfd2579b802c]

        tdf#133768 speed up temp file creation
        
        Use DELETE_ON_CLOSE attribute, so we can avoid calling osl_removeFile.
        Shaves 5% off the export time.
        
        Change-Id: I4fef8f181ef7a92c4805cc5996c3a17800a22602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141718
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-24  Caolán McNamara  <caolanm@redhat.com>  [83334df9cfc34a2f740fe30db0f3359105cede83]

        Resolves: tdf#151711 don't use an intermediate Color to pass data around
        
        just pass the desired value directly
        
        Change-Id: Ib2a6d4c24a18e4a4d735d408e8179e3e204eff13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-24  Kevin Suo  <suokunlong@126.com>  [8ae0ce1bfa9fe6fa7fa54bafb5541c3f78d9e9b5]

        sdext.pdfimport: refactor this unit test and active it for Windows
        
        This unit test was disabled for Windows build in commit fc45e54be6ba5d4685ae4ef3c3ea696fc99cccd4,
        due to the "crashes on the windows jenkins boxes".
        
        In this patch, I:
        1. Rename the test name to show its purpose for easier reading;
        2. Test the whole string all at once using xpath, rather than use indexOf().
           This way we can not only test the existance of the characters, but also
           the order they appear.
        3. Activate it for Windows build and hope it passes on Jenkins.
        4. Remove the std::cout debug code, and use CPPUNIT_ASSERT_EQUAL_MESSAGE
           instead, so that the xml content (i.e. aOutput) is only shown when the
           assertion fails.
        5. Move the test document to testdocs directory.
        
        Change-Id: I39084eb4ddc451ecac5183213b7e6166facf617b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-24  Miklos Vajna  <vmiklos@collabora.com>  [cd5acf308552ee878215e71251eb57dc5108b92a]

        sw: prefix members of SwFieldDokInfPage, SwFieldDokPage, SwFieldFuncPage ...
        
        ... and SwTranslateLangSelectDlg
        
        See tdf#94879 for motivation.
        
        Change-Id: I8a01e86594cc019815f5fa1e9b13c101a4cda6c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141714
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-24  Eike Rathke  <erack@redhat.com>  [6d2363a553c9e275f9430510d70bc4b84e02aad8]

        Related: tdf#147817 validateDatePatterns() also when (re-)setting/initializing
        
        ... so a bad pattern possibly stored in configuration gives a
        visual indicator already on first view.
        
        Also reset the edit indicator to normal when initializing from a
        locale's default patterns.
        
        Change-Id: Ib87b01e057bc1409eba6ccb4d2717a731d0773d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141689
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-23  Eike Rathke  <erack@redhat.com>  [648c70ac2caf2646ee8ff49bd8d846016d289b38]

        Related: tdf#147817 Extract validateDatePatterns() from DatePatternsHdl()
        
        To be able to reuse it.
        
        Change-Id: I11932708a3f1d04180f806f8de12ff42e3d13954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141688
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b32e1cd0496c36c4f6cb783bf8bd21b4ad234738]

        tdf#151071 Revise Sifr to follow upstream (Navigator)
        
        Change-Id: I87c204687ab4eca67df0def5cc31dbe06d74eec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141681
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [5af26c9ecdcfe70f5954c4acc340e8f9846aacfe]

        Avoid nesting using 'else conditional-directive'
        
        See https://www.gnu.org/software/make/manual/make.html#Conditional-Syntax
        
        Change-Id: Iddd4ee2d42c83e6d661ef7d91c93a06caf307001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141708
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-23  Caolán McNamara  <caolanm@redhat.com>  [ac99dd03dbc8455ef16760c0608799dddce804b6]

        tdf#151311 don't show editing visualization frame for tables
        
        continue to show it for cases like tdf#94223 but not for table cells
        like tdf#151311
        
        Change-Id: I73f69b9dc203af86293043743a1101ab129139a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141683
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-23  Eike Rathke  <erack@redhat.com>  [cdded98b23698e5e2a5cfffd5638e395098fcc4a]

        Related: tdf#147817 prevent date acceptance pattern with numeric ambiguity
        
        i.e. matching input with numeric decinmal separator, like M.D
        
        Change-Id: Ice977b3e92373829cd2f5df7c065d55bc49fc23e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141686
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [825242b48843d7d8e03e3dd41a58d6d93afb443e]

        Simplify SwEditWin::LogicMouse* and sd::Window::LogicMouse*
        
        These are intended to be called in LibreOfficeKit case. Setting pointer
        position appeared in commits b780822f5afbf8cd6c2a8c756251a7edf248f55e
          Author Miklos Vajna <vmiklos@collabora.co.uk>
          Date    Tue Feb 24 14:30:41 2015 +0100
            Introduce SdXImpressDocument::postMouseEvent() override
        
        and cc7d10c04fe3047f18b6d5271a5f46a31b80d360
          Author Miklos Vajna <vmiklos@collabora.co.uk>
          Date   Tue Mar 03 12:09:04 2015 +0100
            SwEditWin: disable map mode in LogicMouseButtonUp/Down
        
        The only effect of Window::SetPointerPosPixel is realized by a call
        to SalFrame::SetPointerPos; and in SVP case, which is used in case of
        LibreOfficeKit on Linux, it is a noop (see SvpSalFrame::SetPointerPos
        in vcl/headless/svpframe.cxx). But e.g. when running gtktiledviewer
        on Windows, WinSalFrame::SetPointerPos is called, which actually sets
        system cursor position, causing unexpected jumps.
        
        And it is unclear why the mouse actions should restore previous mouse
        positions after executing their functions in the first place. The other
        overrides (vcl/source/control/ctrl.cxx, sc/source/ui/view/gridwin.cxx,
        chart2/source/controller/main/ChartWindow.cxx) don't do that.
        
        So remove these SetPointerPosPixel calls altogether.
        The question remains: if these LogicMouse* are still needed, or if they
        may be replaced with respective Window::Mouse* calls.
        
        Change-Id: Id6103f8eaaddafc72fe5e4264532dbc8a658d240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141696
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-23  Eike Rathke  <erack@redhat.com>  [cf429e79367775a03c2ca89ed57d3de88bd2c6dc]

        Resolves: tdf#147817 ignore date acceptance pattern with numeric ambiguity
        
        i.e. if it matches numeric with decimal separator; may had been
        added as user-defined pattern to configuration or resulted from
        locale merge of default locale and format's locale.
        
        Change-Id: Ie42a65fac26e8ddc6898a53ee3bec8695ace9a70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141684
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-23  Kevin Suo  <suokunlong@126.com>  [a97bae545d72d8b19f39aa9280c0f284c79d0f6c]

        tdf#151697: Use localized string for "Loading" and "Saving" in status bar
        
        Change-Id: I51967950839e7384e8f31178a70bd944d6f9059c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141662
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e87990f4a317ac1958f88fafb85a93b5f85a3ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60d1bfb6194ad0cf1cbcb9958088d631a9f5fad8
          - Update Writer watermark dialog screenshot
            
            Change-Id: I452e93ae7a2d5a024176b209605b1a8386a22e4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141682
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-23  Caolán McNamara  <caolanm@redhat.com>  [5edb3c0b866a3c0169ed492e3807af5bad90b486]

        tdf#104278 have separate treeviews for expander and no-expander cases
        
        have two tree views, one with expander and one without, the one with is
        only used when there are custom properties which use the expander, so
        the common case of no custom properties doesn't have an 'unexplained'
        expander margin
        
        Change-Id: I6d0c97beeaf8a361ae264cdd1dacf4b06f251a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-23  Caolán McNamara  <caolanm@redhat.com>  [698ba5fcd9f01f8f6e9f300d914d8538ad527219]

        tdf#151674 rotate text starting point
        
        Change-Id: Ibcfb4b102a58cad53c1ce5f569721e4557844b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-23  Caolán McNamara  <caolanm@redhat.com>  [f024738e2218ed67c1948a9aa6149084939a2a52]

        resave with latest glade
        
        Change-Id: I5f4ae5c3fab267059c858aac0d6e7a64921abd7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ee7e5aff70e2aefe49e781eb74d3f61d99d857a8]

        tdf#151071 Revise Sifr to follow upstream
        
        - Shape's Group
        - About
        - Column Break
        - Wrap Text
        - Certificates
        
        Change-Id: I00b6598458aecd7ed0b44d2152a76cfdf39fc3f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141679
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [93cf1bc5e7495e0e2741451f7b564a6386e9b64d]

        tdf#151071 Revise Sifr to follow upstream (Track Change, Capitalization)
        
        Change-Id: I593ae9030d5855d4f408d05fa8f2328cb30be098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141677
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d0a20b67ae7ee1691409b4a1665853a182c46b7b]

        tdf#151073 - enable firebird for appstore build w/o experimental mode
        
        also don't default to hsqldb as embedded database when a build is done
        without java support. Mainly to hide an UI bug - apparently the dialog
        should show a non-supported message for known embedded drivers
        at least that is what 04d1e80ac7091ec2bf31c8617e832d5fe15350be suggests
        "
          // this indicates it's really a type which is known in general, but not supported on the current platform
          // show a message saying so
          //  eSpecialMessage = smUnsupportedType;
          insertDatasourceTypeEntryData( m_eCurrentSelection, sDisplayName );
          // remember this type so we can show the special message again if the user selects this
          // type again (without changing the data source)
          m_eNotSupportedKnownType = m_pCollection->determineType( m_eCurrentSelection );
        "
        but that doesn't work, at least not anymore. m_eNotSupportedKnownType was
        since removed, no attempts are made in showing an error/warning message
        returning the hsqldb driver results in an empty (no display string)
        entry as the default element in the dropdown in the dialog, that still
        allows to create a database file (but of course one that you cannot add
        any actual database tables to) without any error message. At the very
        least it is inconsistent with the rest of the dialog's code that clears
        the input name for stuff that shouldn't be shown.
        
        Change-Id: I8419888018be2a556c49d32e40f02c0ac1801930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141631
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5c11ddae9e54668f5d8997f4c37dd542e656d4f]

        build appstore packages with symbols/add targets to merge into universal build
        
        while there is no builtin support to create a fat binary during the
        actual build phase, we have a post-processing script that can merge two
        separately built architectures into an universal binary one.
        Thus enhance the makefile to support a more convenient way to build the
        two archs without the need to manually move the package out of the way
        to build the other arch.
        
        1) assemble one architecture's package via
           "make mac-app-store-package.prepare"
        2) make clean and change targets in autogen.input to build for the other
           architecture
        3) build the other architecture and combine into universal binary and
           also package into the final deliverable via
           make mac-app-store-package.universal
        
        (of course you can also use the .prepare target separately also in the
        second build, and just mac-app-store-package will build the deliverable
        for the current architecture like it did before)
        
        Change-Id: I02c14e9b8c4f6e39d0d50cd3b4ffdd060b2d69bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141557
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6e6c6f697b019348161648d9d26398bf64de83ef]

        macOS sandbox: only use com.apple.application-identifier for main package
        
        when multiple files are signed with that entitlement, the build will
        just be listed with "Not Available for Testing" via Testflight
        
        Change-Id: I92957f24513ab419ddbc4289b53175932111c198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141497
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-10-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3336cb1b3d12e9cd5c2f560c82129dc8ed7527da]

        macOS: add XCode and SDK buildversions to Info.plist
        
        without those submitting a build for external testing via testflight is
        not possible because appstore thinks you were using a beta version of XCode
        
        Change-Id: I6979a9d290c3e67dd9969d6e535625760b639c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141496
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-10-23  Jim Raykowski  <raykowj@gmail.com>  [158014e9aecbec6afb0ebf3aceb8b09e4a64b8e0]

        tdf#138868 SdNavigator: Select in the objects tree all marked objects
        
        in the draw view
        
        This patch makes all marked objects on a Draw/Impress page be
        selected in the Navigator. Previous to this patch, only the first
        marked object is selected in the Navigator.
        
        Change-Id: I430d0aa83297d0bf89cc90d341267b5d70dac534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141426
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-23  Eike Rathke  <erack@redhat.com>  [9d1d668a608cc5b406601c2f7f3d8581e8f47d1c]

        Resolves: tdf#150780 Overtyping is not editing
        
        Change-Id: Ie83245479e4f356cf120dae1da39d35a9bb1a2e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141676
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-22  Caolán McNamara  <caolanm@redhat.com>  [96d7d4d16cfae09085d0baa41d5d70b5d33da726]

        ofz#52514 OOM
        
        Change-Id: Id4f3b3cef27a299e5496276e274406d0720a27fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-22  Caolán McNamara  <caolanm@redhat.com>  [9a2f193706278eef4c59df4b7028531a599dff8b]

        crashtesting: various ScChart2DataSequence::getTextualData crashes
        
        since:
        
        commit 03ef97c7605f4d3f537d5a1f31c2f131a439578d
        Date:   Tue Oct 18 14:16:08 2022 +0200
        
            tdf#131910 speed up chart display
        
        e.g.
        
        bugtrackers/ods/ooo49870-1.ods
        
        Change-Id: I14f8a03374d1c1d2b6e35b471c5d415b7590829e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141671
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-22  Caolán McNamara  <caolanm@redhat.com>  [c2f2317494adbf2055d43ad585c44eb8408f4ebd]

        ofz#52600 stop after first failed image in a multi-image tiff
        
        Change-Id: Ibd0a8fd5720fef0801e00a6dd4d52c018471e24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [7b04e44d4e909e4a6e48a894ec5ad00cacbbcbf5]

        Set InstallLOKNotifier handler for CrashReportDialog
        
        This prevents assertion failure in Window::SetLOKNotifier
        called from Dialog::ImplStartExecute in gtktiledviewer.
        
        Change-Id: I5c67d85728a34e47c36c73dafa616df45afa8092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141589
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-22  Caolán McNamara  <caolanm@redhat.com>  [14a84557331ae9d65d40b820c82027529a6de6fe]

        Resolves: tdf#151699 show/hide the overlay along with the edit
        
        if its present
        
        Change-Id: I9f167117329b9fa33a79271c1f97fcb10ab9de32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [afca4871bf31b10d7528d4a365920abb4a2c071a]

        tdf#151694 Sifr: Update Mime Types
        
        Change-Id: Ic23008fbe23ba991173db0dbf7d6b7093ec7629c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141660
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d2e1b090657a4be3edbad74b8f8620a65f772857]

        Update git submodules
        
        * Update translations from branch 'master'
          to 251391e6b9b2036e8ab2e4f3079c9152954c4a63
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I9b084737aef30bc65308a263b5fdcd68316197ba
            
2022-10-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0c73c5a2a8fd65f8dffb11bf0090b8b0fd6a43ce]

        Add Watermark dialog to list of screenshots
        
        WatermarkDialog.png was not in the list of screenshots for writer
        
        Change-Id: I17add344870463ee6bd0b54c0d53fa261cb5e43a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141661
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [b5acaa1cf36c30ab3cb1a2796ead850598ed233f]

        g_get_real_name is a proper match for passwd::pw_gecos
        
        This fixes 66fcc9db0f7eacd0ebda06d9ee634af2d0e73d04. Also nullptr check
        is added (passing nullptr to std::string ctor taking null-terminated
        string is UB).
        
        GLib implementation:
        
        * https://gitlab.gnome.org/GNOME/glib/-/blob/476e33c3f3632bd32370fadc67b10d61da9a4098/glib/gutils.c#L743
        * https://gitlab.gnome.org/GNOME/glib/-/blob/476e33c3f3632bd32370fadc67b10d61da9a4098/glib/gutils.c#L577
        
        Change-Id: I4e36cf836f2889f9aa03167c5ade81c69d9b1dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141586
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-22  Caolán McNamara  <caolanm@redhat.com>  [66ac4d9171fee9d425d3301933c1eb8e85c25933]

        macos: set Dialog and DialogText color explicitly from theme
        
        noticeable in start center wrt dark/light logo variant
        if experimentally enabling dark mode
        
        Change-Id: I181399861878d797f207da903c3c21d7f8ed7576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-22  Noel Grandin  <noelgrandin@gmail.com>  [9fd78b7421b5acefc8d0bde7cc103a045d79bd04]

        tdf#133767 speed up temp file creation
        
        Use a GUID so we can avoid needing to check if the filename
        already exists.
        Shaves 2% off the export time.
        
        Change-Id: Id08104b187365eb35c84639254263329a8218a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [e7be4bb5a3a388e844b718fa843c7a66b5c286d1]

        Fix StartWritingUnicodeText
        
        Its comment in include/tools/stream.hxx tells:
          Switch to no endian swapping and write 0xfeff
        
        It was introduced in commit 3c2105e07d29b2069349e1a54e08463d359f988f
          Author Eike Rathke <er@openoffice.org>
          Date   Fri Dec 22 00:19:05 2000 +0000
            new: read/write Unicode or Bytecode
        
        and included a call to SetEndianSwap( FALSE ). That call was dropped
        in commit 8130714148d58dd2bf1ef12dcc6dd6d5838be0d1
          Author Noel Grandin <noel@peralex.com>
          Date   Mon Jan 05 08:47:31 2015 +0200
            fdo#84938: replace NUMBERFORMAT_INT_ constants with 'enum class'
        
        (likely by accident).
        
        To simplify the fix, drop redundant m_nEndian: m_isSwap is enough.
        
        Change-Id: Ia9a0fe2d55563e7ba21bd4cf17c4ca999c6feaf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141521
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-22  Noel Grandin  <noelgrandin@gmail.com>  [8cbc179acedb1fdb07ccafbd60a271acad90a3bc]

        use more TempFileFastService in scripting
        
        Change-Id: Ic04abad55e655fa0e0434bd09f797c6f1b2cc245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Noel Grandin  <noelgrandin@gmail.com>  [0df36d45b601e93b067c22d0b09ef1ae55168263]

        use more TempFileFastService in xmlsecurity
        
        Change-Id: I905e1e126e96195212887feb190e87f7f4da5adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3c7d78f3dc5ccce60dc198d2466ec7470f7fe9c]

        loplugin:unusedmethods
        
        Change-Id: I3c94d68cb85adc2005a5a5e3b03a311732f782c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Noel Grandin  <noelgrandin@gmail.com>  [db8f0528eb71252b4af9c3f7ec213ea7fb29591a]

        use more TempFileFastService in svl
        
        Change-Id: I798a7bb773028aba059f058d4e65e7b2e845c015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Noel Grandin  <noelgrandin@gmail.com>  [ac5f11d86cd290deaed3565c558aced9f5eb6fca]

        use more TempFileFastService in chart2
        
        Change-Id: I064246a8b649bdd6a7751c456ec935c819505057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-22  Mike Kaganski  <mike.kaganski@collabora.com>  [66fcc9db0f7eacd0ebda06d9ee634af2d0e73d04]

        Use g_get_user_name instead of access through getpwuid
        
        It is more portable - available also on Windows
        
        Change-Id: I424e1993ad9621ca42b6f48896d5025832ac681e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141584
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-21  Michael Stahl  <michael.stahl@allotropia.de>  [8dcf53b3d2c0e30317c1e247f01d07ab448ec1ae]

        sw: fix my MSVC build
        
        It barfs up an inscrutable 10 line error message apparently because
        of the parentheses around the parameter names.
        
        Change-Id: I350d4973a016e824e46d147ffad93a1ad36895a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141652
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-21  Stephan Bergmann  <sbergman@redhat.com>  [2aca16119654c6ce1898ec2eca0d9d7f2eb031ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ee668393aaea0357f582223f50af63e2d2df727
          - Fix helpcontent2 build failure
            
            > [PKG] helpcontent2_html_media_lang_en-US
            > /usr/bin/cp: cannot stat '/.../helpcontent2/source/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png': No such file or directory
            > make[1]: *** [/.../solenv/gbuild/Package.mk:35: /.../instdir/help/media/screenshots/modules/swriter/ui/watermarkdialog/WatermarkDialog.png] Error 1
            
            by putting back a file (erroneously?) removed by
            4f5ecc07647d1c01858b24f96683e6061ef49c02 "Reduce Writer screenshots to
            valid Help locales"
            
            Change-Id: Ib32426d14ff0bdd74885b8d78f3af271afc25d21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141654
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-10-21  Stephan Bergmann  <sbergman@redhat.com>  [a1411f0fb19981d3c156d34ace5db10bd5d22aec]

        Improve SwRedlineData::CanCombine date comparison
        
        f240f073d228e62afd3f60563c23626efad0df7f "Related: tdf#102308 sw: ignore seconds
        when combining redlines" had just naively cut off the seconds for comparison,
        but which apparently gave unexpected results when the two dates are sufficiently
        close but lie on different sides of a minute tick:
        
        Autocorrection-related unit tests like CppunitTest_sw_uiwriter6
        CPPUNIT_TEST_NAME=testRedlineAutoCorrect2::TestBody sporadically failed to
        execute some autocorrection, as in
        
        > uiwriter6.cxx:1436:Assertion
        > Test name: testRedlineAutoCorrect2::TestBody
        > equality assertion failed
        > - Expected: Lorem,... Lorem,…
        > - Actual  : Lorem,... Lorem,...
        
        What happened there in testRedlineAutoCorrect2
        (sw/qa/extras/uiwriter/uiwriter6.cxx) is that each emulateTyping consecutive
        simulated character input should extend the current redline range, by hitting
        the
        
        >                     // Merge if applicable?
        >                     if( (( SwComparePosition::Behind == eCmpPos &&
        >                            IsPrevPos( *pREnd, *pStt ) ) ||
        >                          ( SwComparePosition::CollideStart == eCmpPos ) ||
        >                          ( SwComparePosition::OverlapBehind == eCmpPos ) ) &&
        >                         pRedl->CanCombine( *pNewRedl ) &&
        >                         ( n+1 >= maRedlineTable.size() ||
        >                          ( *maRedlineTable[ n+1 ]->Start() >= *pEnd &&
        >                          *maRedlineTable[ n+1 ]->Start() != *pREnd ) ) )
        
        branch in DocumentRedlineManager::AppendRedline
        (sw/source/core/doc/DocumentRedlineManager.cxx).  However, when that happened to
        fail on a minute tick boundary because its
        
        >                         pRedl->CanCombine( *pNewRedl ) &&
        
        part was false, we would end up with split redline ranges, and
        SwAutoCorrDoc::ChgAutoCorrWord (sw/source/core/edit/acorrect.cxx) would not
        execute the autocorrection replacement across those split ranges due to its
        
        >         // don't replace, if a redline starts or ends within the original text
        
        code.  (One way of making that test fail reproducibly would be with some
        
        > diff --git a/sw/qa/extras/uiwriter/uiwriter6.cxx b/sw/qa/extras/uiwriter/uiwriter6.cxx
        > index 0159c5bf07ed..8716c6a09882 100644
        > --- a/sw/qa/extras/uiwriter/uiwriter6.cxx
        > +++ b/sw/qa/extras/uiwriter/uiwriter6.cxx
        > @@ -7,6 +7,10 @@
        >   * file, You can obtain one at http://mozilla.org/MPL/2.0/.
        >   */
        >
        > +#include <sal/config.h>
        > +
        > +#include <chrono>
        > +
        >  #include <com/sun/star/drawing/FillStyle.hpp>
        >  #include <swmodeltestbase.hxx>
        >  #include <cntfrm.hxx>
        > @@ -33,6 +37,7 @@
        >  #include <com/sun/star/text/XTextViewCursorSupplier.hpp>
        >  #include <com/sun/star/view/XSelectionSupplier.hpp>
        >  #include <o3tl/cppunittraitshelper.hxx>
        > +#include <osl/thread.hxx>
        >  #include <swdtflvr.hxx>
        >  #include <comphelper/propertysequence.hxx>
        >  #include <LibreOfficeKit/LibreOfficeKitEnums.h>
        > @@ -1431,7 +1436,9 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest6, testRedlineAutoCorrect2)
        >      CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString());
        >
        >      // Continue it:
        > -    emulateTyping(rXTextDocument, u"Lorem,... ");
        > +    emulateTyping(rXTextDocument, u"Lorem,...");
        > +    osl::Thread::wait(std::chrono::seconds(70));
        > +    emulateTyping(rXTextDocument, u" ");
        >      sReplaced = u"Lorem,... Lorem,… ";
        >      CPPUNIT_ASSERT_EQUAL(sReplaced, getParagraph(1)->getString());
        >  }
        
        patch.)
        
        So at least improve SwRedlineData::CanCombine to properly check for a date delta
        of <= 1 minute.  However, that still leaves those tests prone to sporadic
        failures (even though less likely), if they get delayed for a sufficient amount
        of time in strategically unfortunate places.  Ideally, those
        autocorrection-related tests (which appear to be the ones in
        sw/qa/extras/uiwriter/uiwriter6.cxx using emulateTyping) would run with
        redlining turned off, but many of them explicitly enable redlining, presumably
        for a reason.
        
        With that change, UITest_writer_tests started to fail with
        
        > FAIL: test_tdf135018 (trackedChanges.trackedchanges)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sw/qa/uitest/writer_tests/trackedChanges.py", line 203, in test_tdf135018
        >     self.assertEqual(147, len(changesList.getChildren()))
        > AssertionError: 147 != 111
        
        in a test introduced with b6ab2330d97672936edc56de8d6f5b6f772908ff "tdf#135018:
        sw: Add UItest".  That sw/qa/uitest/data/tdf135018.odt's content.xml contains
        147 <text:tracked-changes> <dc:date> elements ranging from 2020-07-11T10:29:12
        to 2020-07-21T11:50:32, and apparently some adjacent changes with sufficiently
        close dates now started to get combined when executing
        .uno:AcceptTrackedChanges.
        
        Change-Id: I1d3453bbf5b0206c080bd3421d525e6b8351f2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [6a99a9b602e4d933a54daeccdba91d862f8711eb]

        CppunitTest_sd_filter_eppt: inherit from UnoApiTest
        
        Change-Id: I0a88ecc55638d8c6ee06715db8c03d6327666215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141655
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [25373581ebe30f6b1b2d850b7f268487afdacb4c]

        nullptr check
        
        GetView() returned nullptr in a gtktiledviewer session
        
        Change-Id: I5e16f77d9e6a18e51f548464339fc11d8f733ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141582
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [89c732913d6155db48c74dd7c2c0325468048aa5]

        test: merge CalcUnoApiTest and UnoApiTest into one
        
        Change-Id: I24ec4c2c1c6d83865ef78a6460cde68cef84fdb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141638
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Noel Grandin  <noelgrandin@collabora.co.uk>  [09dfee8a1cf7698a637f647f48750cf8d5722b7c]

        tdf#133767 use more TempFileFastService
        
        Change-Id: I58728f0b7971e3247cd555dd701461824707d15d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141627
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-21  Caolán McNamara  <caolanm@redhat.com>  [a09f6099d20f8ea6fa0e0ae22aa31124a290bd72]

        macos: set TabRolloverTextColor color explicitly from theme
        
        noticeable if experimentally enabling dark mode
        
        Change-Id: Ia77a2b79d2ad47761d4fab8eac3936f1d6c93578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141632
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0bd8f9ea75459b1f3ca7daff20b235df7a558608]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aef7f8604b7b5b9eda83b7affc96f8c1b82ebc58
          - Reduce Chart screenshots to valid Help locales
            
            Change-Id: I58dd9143e235c08e645ae22f471a95e54b6b5140
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141645
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0bf7303d2dd3f7903f0c5737df49e871ed140e95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80427e4c2daa58ef30f0afb4f388f825b41b9c05
          - Reduce Draw screenshots to valid Help locales
            
            Change-Id: Ic3308d97f3c08df46ad0b5e107a1ef9c270c5dda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141644
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da7aa069f0cbe5a15cda89f91df5c1cb5ebffbe7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to da4a62735fa5728883666cd47a6e7a017b7b4000
          - Reduce Impress screenshots to valid Help locales
            
            Change-Id: I9c0199d8e1041ba4f7705a9890be3dad9b287fe8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141643
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [045869faa94f552a19e1f67e806c3f34d498d6b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f5ecc07647d1c01858b24f96683e6061ef49c02
          - Reduce Writer screenshots to valid Help locales
            
            Change-Id: I05b9b2d982ee5740bc0805cc0589bcb11182f0dd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141642
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [313cb64fbb4403e7ee54bd682f3b1ecaf27bff3d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 41d1e849558210e04f117f653ec90794d2680691
          - Reduce Math screenshots to valid Help locales
            
            Change-Id: I53b71cfbc5f09aaea397ebe1864c5038e3c28cd1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141641
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a1c1b9537b3846afa8701a25d49777c4fe7a1fb4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3cdeafe0c516a10aeb78d06c0f355e164b929454
          - Reduce screenshots/sfx to valid Help locales
            
            Change-Id: Ie13f38f22a6d8235a890e01c00c2c7420d046c24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141640
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [48e489871681ffea6c43e88cc25b5b05e26d78b1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6deeb4a1ad63f4657abfd06cf235f43291c19d78
          - Reduce screenshot/svt to valid Help locales
            
            Change-Id: I3b8ae51dacc263ee6224b6cb1a74cbac10ed2b53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141639
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [1f687c07878b56cd07bedf4a04790375ac881658]

        Related: tdf#114441 use better types in place of recently changed ones
        
        Best to harmonise these to sal_Int64, along the lines of
        commit 206543c7bef58fc559852553a3b2faba0b604259
        Author: Michael Weghorn <m.weghorn@posteo.de>
        Date:   Fri Sep 2 13:06:08 2022 +0200
        
            [API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit
        
        Change-Id: I3cddb192990ba87dc637cdd765d1427bc4611d2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141621
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [87778305004c45b4387d1c44e48e21a22738d655]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8c0ef544e9eddd68d1677e54f65715778029d59
          - Reduce screenshots/svx to valid Help locales
            
            Change-Id: I312b460c65e2e08b869a23a7727b1b5e58870bad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141637
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [03d6d07d8c1be4f0123f1f9b05b4e5f0f92eabf6]

        CalcUnoApiTest: work with mxComponent directly
        
        Change-Id: If6f2104ef3136952341c9d5d59a1f9784d0fe4b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141628
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b08cf04012655c4995e3fe5a1f3b698615db5f11]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f781c754a1700657be271246c57d75a65e924da2
          - Reduce screenshots/uui to valid Help locales
            
            Change-Id: I340d31c8aed053cf748613575df6db7576269f8f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141636
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4db87d526a7a56565bda717002412e15800b11a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bfbda821a7c89bd72aab271296671b24ecdd8781
          - Reduce screenshots/writerperfect to valid Help locales
            
            Change-Id: I5e96f9f3387eff74d4659a4527b6602b2386b669
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141635
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6037386b932d411df8c2dd2116d90c12192528ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b648f5c7fb4c78d5b2be3395d3cdeb952a4f6f8
          - Reduce screenshot/xmlsec to valid Help locales
            
            Change-Id: I22bbba88930439641b98a484ae624c85f4a7c30f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141634
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Michael Stahl  <michael.stahl@allotropia.de>  [72b69b422d33308809070e98a6ea8daad93e16d2]

        tdf#139736 sw: PDF/UA export: flys in header/footer are Artifacts
        
        * flys anchored in header/footer cannot simply be ignored, they need to
          get NonStructElement tag which is translated to "/Artifact"
        * borders of flys need to get "/Artifact" tag as well; this is also the
          case if they're anchored in the body as veraPDF complains
        
        Change-Id: Id69f0d80c59c3ade295da46c4413a5f0e8d96d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141534
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-21  Caolán McNamara  <caolanm@redhat.com>  [1cccfb05d1aaea33aa370b6f4f080cae95611cd0]

        cid#1516102 Dereference before null check
        
        since...
        
        commit ba58fc11723b7c9d370d6407385ea0e8829db099
        Date:   Thu Oct 13 22:11:35 2022 +0200
        
            tdf#151462 - Search for outline node containing the current node
        
        Change-Id: Ib0bc51b1c37cb4bc60e61800a2d190eee2b6aa61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141629
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-21  Noel Grandin  <noelgrandin@collabora.co.uk>  [4668bfe4f64acfb17da5efbb759407664b407d81]

        give main thread a name
        
        to make it easier to find in profilers and debuggersy
        
        Change-Id: Ie376186d623957ae71c3e5bcea36888fcdf85d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141625
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-21  Michael Stahl  <michael.stahl@allotropia.de>  [b1f25771fd7e5671f081bcb80ed58e8678f3105f]

        sfx2: avoid showing 2 dialogs in case WebDAV LOCK request fails
        
        ... with 403 error code, which typically indicates read-only; one dialog
        is enough - also for the initial load of the document.
        
        (cherry picked from commit 855d62fc841abc62e0eca079e9b30f9d0888a93f)
        
        There is an Infobar anyway that the user can click to try again to
        edit the document, and if that fails there will be a dialog that offers
        opening a copy.
        
        If opening a file:// document writable fails and it is opened read-only,
        there is also no extra error dialog, just the Infobar, so this is making
        WebDAV more consistent.
        
        Change-Id: Ice62d167199f384b246b9d60dab4eed456a62288
        (cherry picked from commit 48fa1f49d97ce04c9d3749ae02b2874af6477e82)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141620
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c7bcf51d3efe30047667fe026cbcd3cb87bdece3]

        sw: combine IGrammarContact and SwGrammarContact
        
        Change-Id: I4b9ab45ff8e21fa5091894f2cd5e3c7de57df425
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141431
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d4c4e3053ce59dba96d7531fc4c1828c1366f419]

        sw: modify NumberingCheck to work independent of node order
        
        Previosuly the NumberingCheck assumed we iterated throught nodes
        and remembered the previous text node. This changes how the check
        works so that the we find the next text node and check is with the
        current node.
        
        Change-Id: I043da74ae90b6387bff273f62eb2589faa2d1d31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141430
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d0f81680c1af5995baecc19bdbe4f22a8a76666d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b978f96f3604e1c1b5f55c259965dcac143dff14
          - Reduce screenshots/vcl/ to valid Help locales
            
            Remove screenshots with no Help pages associated by l10n
            
            Change-Id: I8d4a25d503c731e583042500db3a1f7d52aa4cec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141630
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [767092fe2cab4a8b28426a6b2b1c752277fc7df6]

        loplugin:referencecasting look for a new pattern
        
        Change-Id: Ib7ded8db2c513909159f0876389f63b60082a529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [57a03d7a52680e7177d07efe364785d53bf0a6df]

        sc: remove unused method
        
        Change-Id: I4e98ff61d5b592df970595b7aad551a9e37b93df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141615
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d4ce60cf669e1ddfbd5a168522f05184d204c30]

        loplugin:unnecessaryvirtual
        
        Make the script filter out more external code
        
        Change-Id: I131da451e148e193552ead7c1441b06b726df619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [05df7eaa30c48c405e3a35b877b0333183805748]

        Missing dependency
        
        Change-Id: I7dd74970c9e5743263546d750cb6688f9cb38d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141577
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [f947788617e06ac175a5cccb20a6bd0d0a7a88ed]

        sc: remove SetIsInUcalc.
        
        it seems it's no longer needed
        
        Change-Id: I346a12a150659ddde218a895d140c9087989d516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141613
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Mike Kaganski  <mike.kaganski@collabora.com>  [84552eaf8c50b46ab2c98ad70b6473b4db31baee]

        documentLoadWithOptions takes URLs
        
        m_aDocPath is set in lok_doc_view_set_property from data
        coming from gtv_application_open's calls to g_file_get_path.
        So the path is not a proper file URL, which is expected by
        documentLoadWithOptions. Some Linux paths can happen to be
        able to convert to absolute URL in rtl::Uri::convertRelToAbs,
        but not all, and not e.g. Windows paths.
        
        Change-Id: I0a17cb84000603336a6809b0179bbda3d54aec23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141579
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-21  Noel Grandin  <noelgrandin@gmail.com>  [848f9b2c56ce4c4620f62f1fbf9d12d84ec4da96]

        tdf#133767 new service TempFileFastService
        
        to use in places where we know we can use the TempFileFast mechanism.
        
        Speeds up export to EPUB from 43s to 17s on my windows machine.
        
        This is essentially a copy of OTempFileService, but it does not
        implement XTempFile (because these temp files have no name on Windows).
        
        Also remove a couple of calls to Flush() (which is not necessary now),
        and TellEnd(), which is a little slow on Windows.
        
        Change-Id: Iced300bf8121eae08c7a011d62ec68b93330d84c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141598
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-21  László Németh  <nemeth@numbertext.org>  [6383362999b72160eab6abdfc6ea6bdbd231b100]

        tdf#151657 sw: delete row with nested table in Hide Changes
        
        Fix for tdf#150976 didn't work in Hide Changes mode.
        
        Follow-up to commit c809867f3ee92a8eb36cbab840bd6d6c5b3b1c26
        "tdf#150976 sw: fix tracked deletion of row with nested table".
        
        Change-Id: If10c8184a01d025e3df53e33fc9503107fce0980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141611
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [60253fc1eaa66bd30ec1a5766a1551a6a7a796ad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60f360ebc592506713ad698ccdc34b621f187538
          - Removed executable bits on PNG files
            
            Change-Id: I68b6309df039a1a5e054c244efe31e7487f38e0a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141599
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
          - Refactor impress remote media files
            
            * Impress remote media has little or no localizable information
            
            Change-Id: Id49284820472fb33208199f1fc39769012946b97
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141614
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-21  Caolán McNamara  <caolanm@redhat.com>  [ab0958d5eb87a82cdd54245ca7aa18124b175a05]

        macos: set some more background colors explicitly from theme
        
        noticeable if experimentally enabling dark mode
        
        Change-Id: If71223fe631cf4f361190171769f1557b9ee97d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141602
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [563f0ec5c3a4e75feaa3d29baef4127f22406507]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b9be28ffef08b4cab9b91b310d0a356ca38f3a7c
          - Bracketed hidden <help text> gets shown
            Change-Id: I30a459a5445e7e42bf762fe081cfe7e7474188f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141576
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [d2a68bbbdb1db3973f19e30cdd19690d7a157214]

        chart2: do not skip validation in these tests
        
        Change-Id: I8af95fd1fbe766a2a3bd19a7d9fa033649a635b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141610
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  Paris Oplopoios  <paris.oplopoios@collabora.com>  [043f0b53aa1734af17fd12a5b07075d965f28730]

        a11y: Add check for highlighted text
        
        Add accessibility check and relevant test for a document that has
        highlighted text
        
        Change-Id: Ia4303215d9ba3eaf583b38bb5ab33f01370f1607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141469
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-21  offtkp  <parisoplop@gmail.com>  [de02e5560168060af0b0c9be847af01c4fadec0b]

        a11y: Add check for short hyperlinks
        
        Add accessibility check and relevant test for a document that uses
        short hyperlinks
        
        Change-Id: I5d6bfe345b50d6d42dc04e9e2f7f853cf5f63a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141338
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [da39ae24711110edac28a65c3a01ddb49a810bec]

        crashreportScraper: Also get info about the last 4 uno commands
        
        it can be useful
        
        Change-Id: I8e709775814922c2623350de1de2fe647d7deadd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141556
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-21  OmkarAcharekar  <omkaracharekar12@gmail.com>  [77131a5277f52300319f7cc5f8c2cc8b4d600a7c]

        tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer types
        
        Change-Id: Iebd876c8c7dd5576cdd457a24726d99790befa83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141516
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [013c096e4199b26ab4d0703953c688f01c7d3559]

        tdf#151613 Sifr: 3d Effects icons
        
        Change-Id: I4e30611f1ef14038a6d0804b9794eac340e7f49b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141538
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b887d67ff9914100df787bd2036b22bf32456fab]

        CppunitTest_sc_pdf_export: inherit from CalcUnoApiTest
        
        in order to get rid of setUp/tearDown
        
        Change-Id: I94dcb647760c71ec8bfc2bbdf50361d81f586eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141566
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [4856b94ae1d851546b2a95622f78af8b1be798a6]

        CalcUnoApiTest: factor out common code
        
        Change-Id: I1a56f152d6c6e6bca55ef20d0d52da2d82b77a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141565
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [b814c51ef7642f1a54294f945465e7d657533b4e]

        CppunitTest_sc_uicalc: inherit from CalcUnoApiTest
        
        so we can get rid of duplicated code in follow-up commits
        
        Change-Id: Ibfe0c25ac9aaabb20ae28008e6156f80122bc898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7569e1c0805f5b14c6dd3e648717bc651bc995da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26ffc4cceb80e3092fd2feb89335b2e0b9a23962
          - Removed executable bits on PNG files
            
            Change-Id: I017da9e9ac561799b6ffdd762343cb54895eb8b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141555
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2b404871d609cf0c36cc9f204b5aeaa214eb2d0]

        remove comment
        
        that no longer makes sense after
            commit 25a7b268555d73248594b9d485b69cd0e4cf34cf (HEAD -> master)
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Oct 20 12:47:39 2022 +0200
            SAL_WARN->SAL_INFO in sax
        
        Change-Id: I298df432d61f90e558251cd1c0e8d3c220423c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2409a57cc0c77aeb35463a3bf835b40fe2689797]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 51022f8f16780ecb19f4669e8b8259a7eaea22be
          - Fix malformed XML (missing closing tag)
            
            Change-Id: I81e223af8c85589569af75d755d787d3102ad6a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141597
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Miklos Vajna  <vmiklos@collabora.com>  [cb0e1b52d68aa6d5b505f91cb4ce577f7f3b2a8f]

        sw, numbering portion format: consider full-para char formats as well
        
        The bugdoc had a single paragraph with direct formatting (24pt font
        size), numbering enabled and a bookmark covering half of the paragraph.
        The numbering had default font size, not inheriting from the paragraph.
        
        Turns out that in case the bookmark is removed, then the custom font
        size is not an autoformat set on the whole text of the paragraph but
        rather a format on the paragraph level, which does influence the
        formatting of the numbering portion, as expected.
        
        Fix the problem by extending SwTextFormatter::NewNumberPortion(), so it
        looks for char props not only in the item set of the SwTextNode, but
        also in the hints of SwTextNode, if they cover the whole paragraph. This
        fixes the inconsistency that adding a bookmark to the document should
        not change the rendering of the portions.
        
        Interestingly DOCX import already set the font size on the SwTextNode in
        this case, but the ODT import created a char autofmt hint, that covered
        the full paragraph.
        
        Change-Id: I09ffabd84511da439bc05a6f8d134615e5dd8599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141572
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-20  Caolán McNamara  <caolanm@redhat.com>  [a25ed05617f304858c6c4c8ced93722130aa1d58]

        macos: set some more text colors explicitly from theme
        
        noticeable if experimentally enabling dark mode
        
        Change-Id: I2eccedc00d6b9a1710ad59bca48e06b3f7b71dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dbe46ae2c60dcb9da5e0fc0886c0859966db8c7d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fabf5ebb2f3fa923a473112a0cf6618937902520
          - Add uui, vcl screenshots for Help pages
            
            Change-Id: Ifb71ccb95ae7c083995325f28ce42609a6e75a93
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141570
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [351b73475818786c03aa6787758ed12b6f56c742]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0fde7fdf06b62f3e27b67b273c7375515321b2cc
          - Add desktop and xmlsec screenshots for Help pages
            
            Change-Id: Id46928e4ad660d0f8908c8bd8a5b61aa7c4714eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141568
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [06048a5a9485e32b19c77d148d61f08a968e7792]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 039d567afcb7694baeafffd15304d5cdf4de61bd
          - Add formula and dbaccess screenshots for help pages
            
            Change-Id: I29af5be211a7f7a111b44a28c970b91ad9522dc8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141563
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c8b31aca826a5dc35ac2c94ab70b24529155c5da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8783b797d785c42ac307e2b740cd3ccfcc4be77
          - Add filter screenshots for Help pages
            
            Change-Id: Ic4c4777da3569f1eb4ba9a2ee3c4740adbb56f35
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141562
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6b2a10f80377c4525b1ce4a18955d4040c3d3aae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37064b2619446b51aa5ddc064e19d865c7d29958
          - Add sfx screenshots for Help pages
            
            Change-Id: I89d7d5e0191bf6550bc5c2d1a57ccd8d0445e68c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141560
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [de61fd38b7dbe21ccc025f771fbcac575e0352f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ddad4610f085bc707e6e57bb37e93164e457f23
          - Add other modules/screenshots for Help pages
            
            Change-Id: I7d5ee7f88bb1a14a90bc045eb9750a2186d0e887
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141559
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7b6fb6869b377b2fe86bc5c205fd5d108e0e9981]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6de7e5db3a007aba120fd34dc439854573f3660a
          - Add screenshots for svt and svx for Help pages
            
            Change-Id: Ic35fb852aa9fd4a67bb7893338ecd06b8996610e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141558
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [40753d5524d07f6bf2fbefdf90ceb3c8bd0910df]

        SAL_WARN->SAL_INFO in sax
        
        This does not provide any value during normal debugging
        
        Change-Id: I6797183e64a3e7e90e1cc6b5ecdb92faa53d01d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7896f8b8760bf4823ec8ae05d7c8848e88c4035c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 39ec56dd4e2116d813d3bc26eafb763923952bcf
          - Typo grab bag
            
            Change-Id: I5065a95400934026fb8a52dbeb72793c66b8caf5
            
2022-10-20  Caolán McNamara  <caolanm@redhat.com>  [2ba3b81c90688878df4b7aa0d0ff28c9200de0e1]

        Resolves: rhbz#2136050 crash on input method "retrieve-surrounding"
        
        select the largest graphic on page 1 and press delete
        
        Change-Id: Ieb5860d9c3f80df010f4f04e2bace4d9641af315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141553
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-20  Caolán McNamara  <caolanm@redhat.com>  [0cc9d19db04fae6e5e1bd4d1020863ec76894300]

        ofz#52537 Abrt
        
        Change-Id: I3362e0a78d29084d49389ed8f0f3173869850451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141552
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-20  Stephan Bergmann  <sbergman@redhat.com>  [0dd37854627aea025aa7bdae3b3bf9ca2d893943]

        external/firebird: Adapt more configure checks to C99
        
        ...similar to f6be6cd82bd84f13d2a597ceb62181111ae0eb80 "external/firebird:
        Missing include in configure check" and 7e1ff1cee5dd203df679d584512930fb21b97f6e
        "external/firebird: Implicit int in configure check".  With recent Clang on
        Linux it had still failed to detected
        
        > configure:20511: checking for working sem_init()
        [...]
        > conftest.c:166:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
        >         main () {
        >         ^
        >         int
        > conftest.c:168:3: error: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >                 exit(sem_init(&s,0,0));
        >                 ^
        > conftest.c:168:3: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
        
        and
        
        > configure:21256: checking for native large file support
        [...]
        > conftest.c:167:5: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
        >     main () {
        >     ^
        >     int
        > conftest.c:168:5: error: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >     exit(!(sizeof(off_t) == 8));
        >     ^
        > conftest.c:168:5: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
        
        And at least the former, which erroneously suppressed setting WORKING_SEM_INIT,
        sporadically caused CppunitTest_dbaccess_hsql_binary_import to SIGABRT for me at
        
        > #10 0x00007f087fce37fc in __GI_abort ()
        > #11 0x00007f085a7e32e8 in Firebird::system_call_failed::system_call_failed(char const*, int) (this=0x55fbb11e5650, syscall=0x7f085a19ac06 "sem_open", error_code=17) at workdir/UnpackedTarball/firebird/src/common/fb_exception.cpp:244
        > #12 0x00007f085a7e33ba in Firebird::system_call_failed::raise(char const*) (syscall=0x7f085a19ac06 "sem_open") at workdir/UnpackedTarball/firebird/src/common/fb_exception.cpp:255
        > #13 0x00007f085a81ff4e in Firebird::SignalSafeSemaphore::init() (this=0x55fbb1268c80) at workdir/UnpackedTarball/firebird/src/common/classes/semaphore.cpp:138
        > #14 0x00007f085a38ee85 in Firebird::SignalSafeSemaphore::SignalSafeSemaphore() (this=0x55fbb1268c80) at workdir/UnpackedTarball/firebird/src/common/classes/semaphore.h:156
        > #15 0x00007f085a38c931 in (anonymous namespace)::MappingIpc::MappingIpc(Firebird::MemoryPool&) (this=0x55fbb1268bf0) at workdir/UnpackedTarball/firebird/src/jrd/Mapping.cpp:602
        > #16 0x00007f085a38176b in Firebird::GlobalPtr<(anonymous namespace)::MappingIpc, (Firebird::InstanceControl::DtorPriority)2>::GlobalPtr() (this=0x7f085a93e780 <(anonymous namespace)::mappingIpc>) at workdir/UnpackedTarball/firebird/src/common/classes/init.h:143
        > #17 0x00007f085a38d270 in __cxx_global_var_init.15(void) () at workdir/UnpackedTarball/firebird/src/jrd/Mapping.cpp:901
        [...]
        > #32 0x00007f085bb37626 in ModuleLoader::loadModule(long*, Firebird::StringBase<Firebird::PathNameComparator> const&) (status=0x7ffd9f8b42a0, modPath=...) at workdir/UnpackedTarball/firebird/src/common/os/posix/mod_loader.cpp:95
        [...]
        
        Change-Id: I082be878d95a020a7c419d6852614b711754cc23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141549
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-20  Calvince Otieno  <sir_kolly@yahoo.com>  [b74e7c0fef80336de1d0c2d0737c2fd2db56cbd9]

        tdf#114441 sal_uLong type to sal_uInt32 type
        
        Change-Id: Icaa9c0a45f257c8c8d5e9d80785554ac82902c59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141514
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-20  Miklos Vajna  <vmiklos@collabora.com>  [e368d26a7f24dc25f3d855511baabc128bc151e6]

        sw content controls, alias: add LOK API
        
        And implement sample handling of it in lokdocview.
        
        Change-Id: Ia1975e4daef6260e2030e5d0dba8fb4293a9484f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141541
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-20  Stephan Bergmann  <sbergman@redhat.com>  [82594fd81ba375d5e7ed919bef0b7b4b8072c02f]

        Use stable_sort for collator-backed sorting
        
        ...where ScTypeStrData::LessCase(In)sensitive is implemented in terms of
        ScGlobal::Get(Case)Collator().compareString.  And that apparently implements
        only a strict weak ordering (in the C++ Standard's meaning of the term) rather
        than a strict total ordering (i.e., sorts different strings into equivalence
        classes, e.g., ScGlobal::GetCollator().compareString("guet", "guͤt") returns 0).
        
        With a randomizing debug-mode libc++, tests recently added to UITest_autofilter
        failed for me with
        
        > FAIL: test_tdf123095 (autofilterBugs.autofilter)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/autofilter/autofilterBugs.py", line 45, in test_tdf123095
        >     self.assertEqual(get_state_as_dict(xTreeList.getChild("0"))["Text"], "乙二醇(进口料件)")
        > AssertionError: '乙二醇（进口料件）' != '乙二醇(进口料件)'
        > - 乙二醇（进口料件）
        > ?    ^    ^
        > + 乙二醇(进口料件)
        > ?    ^    ^
        
        when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is e.g. 140434132192856
        and
        
        > FAIL: test_tdf125363 (autofilterBugs.autofilter)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/autofilter/autofilterBugs.py", line 69, in test_tdf125363
        >     self.assertEqual(get_state_as_dict(xTreeList.getChild("0"))["Text"], "guet")
        > AssertionError: 'guͤt' != 'guet'
        > - guͤt
        > ?   ^
        > + guet
        > ?   ^
        
        when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is e.g. 139927542230616.
        
        (Those tests only required the !bCaseSens case to be stable_sort'ed, but it
        looks plausible that the bCaseSens case would suffer from the same issue, so
        lets stable_sort that one too.)
        
        Change-Id: I860ae7b58f09c85da82fca99a2962f12d70d2202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141548
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-20  Noel Grandin  <noelgrandin@collabora.co.uk>  [449117499ed4ce621057c7b6470b5be40d626d4d]

        workaround VisualStudio2022 compile error
        
        only seems to hit with --disable-pch
        
        Change-Id: I20533aa8516bd92a2cef295ce8c3b4e9a0ab72c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cbf6d5643717e9484ee3a8519ff1689b4c82b24]

        fix assert in debug mode
        
        not actually a leak, just a deletion ordering problem
        
        warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:200:
        SdrModel::~SdrModel: Not all incarnations of SdrObjects deleted,
        possible memory leak
        warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance
        of 12E3dSphereObj
        warn:svx:29983:29983:svx/source/svdraw/svdmodel.cxx:202: leaked instance
        of 8E3dScene
        soffice.bin: /home/noel/libo/svx/source/svdraw/svdmodel.cxx:204: virtual
        SdrModel::~SdrModel(): Assertion `maAllIncarnatedObjects.empty()'
        failed.
        
        Change-Id: Ia0e6e1387825c0d849904b1bc604eb1252090318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e75e6533bdb30f2645ea2119121c8e536cff3ac]

        add assert to catch case that should never happen
        
        otherwise we will lose a piece of the rendering
        
        Change-Id: I65bf0514665551c4930fe6d7462646e334c61989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141493
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Maxim Monastirsky  <momonasmon@gmail.com>  [aa779fbd649dbf0e8e35ba744cdc81bd7171057b]

        resave with latest glade
        
        Change-Id: I0ec13675efa1bd70fa4517bfcff0531da85a8e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141540
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [fcbe87abb87bc26f6a57ee246e7fb7e865766067]

        fix regression in "Format - 3D Effects"
        
        assert at svl/source/items/itemset.cxx:1302: SfxItemSet
        SfxItemSet::CloneAsValue(bool, SfxItemPool *) const: Assertion
        `(typeid(*this) == typeid(SfxItemSet)) && "cannot call this on a
        subclass of SfxItemSet"' failed.
        
        This hits in Draw when drawing a rectangle, then "Shape - Convert - To
        3D", then "Format - 3D Effects".
        
        regression from
            commit 31e7845339b30a69f06a04619660398fe4267268
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Feb 17 12:19:49 2022 +0200
            use more SfxItemSet::CloneAsValue
        
        Change-Id: I36af83fc04636aecefc89e2654929112051fb217
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141542
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-20  Miklos Vajna  <vmiklos@collabora.com>  [45f5c1941a21a932cfd758106a694af3b230ce20]

        CppunitTest_sw_odfimport: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I3a508acb1c0472ee432202cd2ba2927c92da4443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141535
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-20  Jim Raykowski  <raykowj@gmail.com>  [a3238a8e35c9c649069ef67ffa83e0d83f25936b]

        tdf#151521 Fix para applied style sub-level remains visible
        
        ... when parent outline content is folded
        
        Commit 22757917067d7c4e475228cec2a0dd4d2f900e95, removed making all outline content temporarily visible during style application. But it is needed so that paragraph applied stye sub-levels do not remain visible when outline-folding is set to include sub-levels as outline content. This patch fixes the cause of the bug reported in tdf#151315.
        
        Change-Id: I4b8fd4bdd1ca08d65cf8fbb8c3f73ef7d00dcc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141357
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b8fd73044cc7e8f3257a8ca56728e56119821046]

        tdf#151647 Sifr: Table/Cell border icons
        
        Change-Id: Ibd942b60bd908162866c5e92206bc0a5fb974c1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141539
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2a796c9d82cdd5d0076206e90d53bde4f35cd356]

        tdf#151631 Sifr: 3D Settings icons
        
        Change-Id: Ia7fadffe23f8cb611df44fca028ee02ecf05a90b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141536
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4ccdfff0becb54d71fe6270b5eeae0daaf04ed93]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 86b579b23438f66bba07c3d138f4e1764ffe2b66
          - Update screenshots for Help pages
            
            Change-Id: I86e1814ec0f5e76b122f6e5e90944a07e38d51ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141537
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-19  Kevin Suo  <suokunlong@126.com>  [f6004e1c457ddab5e0c91e6159875d25130b108a]

        tdf#151546: RTL text is reversed (Writer pdfimport)
        
        This is a followup to commit 69e9925ded584113e52f84ef0ed7c224079fa061
        for the fix of tdf#104597.
        
        The Writer pdf import filter code is similar than the Draw part.
        However, many fixes to the Draw part was not done in the Writer part historically.
        
        This patch ports the fix of text run in the Draw part to the Writer
        part. There is a todo related to continuous spaces issue which should
        be fixed separately.
        
        Also use CPPUNIT_ASSERT_EQUAL_MESSAGE for the output of xml content
        instread of using std::cout, in case of unit test failure.
        
        Change-Id: Id013700524750e6e5283d85eeab72d8075f16f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141420
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-10-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [ef9d461e420ca1869f88fa0d7ea749581819b360]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d599b915a77663f7766e12e3b818050a6738cbf5
          - tdf#151617 Fix help about Hotspots in ImageMap
            
            As pointer out by the OP the command is under the Tools menu for all LO applications.
            
            Change-Id: I1cb77b60a08f26847887f940ddf288958f9fb465
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141406
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [0644543097dc1ff739000d865988dcb2fd5e4c9d]

        Allow read-access to CombinedHoldCyclesInSeconds for checks
        
        Change-Id: I2685343bd5e0e7c10438274c0a38798e09d813e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141530
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3a82a8ba51195cf31b0f78164735acc7ebbcd2f]

        sc: factor out common code in tests
        
        Change-Id: I58558dd87f235bf3699f3f65271522bb1e7a2ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141529
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fed64d0f8023b425b1151a1aada4632e6c5301d6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0c7005445dbb3905567e2c3c778198f344b25e4e
          - Mute L10n for function string parameter DateDiff and DatePart
            
            Change-Id: Iea892bef40f76e08271c02c6604b689866a4be30
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141408
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-19  Caolán McNamara  <caolanm@redhat.com>  [c33607813ad0c4de69d20b98ba6146f319443d66]

        crashtesting: temp files accumulating over time
        
        Change-Id: I922ba92d0a9278b366b4bec38170a776830c1682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-19  Stephan Bergmann  <sbergman@redhat.com>  [e74d0f01504c61917d8ff9e7538a0017b6212ff5]

        Make MSVC -showIncludes processing more reliable
        
        With the Windows display language set to "Portuguès (Brasil)" (and the
        corresponding Visual Studio language pack installed), configure.ac detected
        SHOWINCLUDES_PREFIX to have the value "Observação: incluindo arquivo:" in UTF-8
        (i.e., with bytes ... C3 A7 C3 A3 ...).  However, for whatever reason
        filter-showIncludes.awk apparently didn't manage to match the input it receives
        against the value of that environment variable, and the Cygwin terminal
        contained output lines starting with either
        
        > Observa□ao: incluindo arquivo:
        
        (with toplevel plain `make`, plain `make` in a module, and `make -O` in a
        module) or
        
        > Observaçao: incluindo arquivo:
        
        (with toplevel `make -O`).  (Note how "ç" is either garbled as "□" or shown
        correctly, and "ã" is always shown as plain "a".)  It's not quite clear to me
        where exactly this garbling happens, and why the behavior is apparently
        different in configure.ac vs. make.
        
        The most reliable way to avoid these issues altogether is to force MSVC to emit
        English diagnostics, via VSLANG=1033, as explained at
        <https://stackoverflow.com/questions/2286216/how-to-change-msbuild-error-message-language>.
        (I didn't find any official documentation of that environment variable on MSDN
        though.  Thanks to Mike Kaganski for providing that Stack Overflow link.)
        
        dfbce2a556972f552d194d2358c170077915d776 "gbuild: try to run
        filter-showIncludes.awk in C locale" had started to call that AWK script with
        LC_ALL=C (and subsequent commits had copied that LC_ALL=C in calls to similar
        AWK scripts).  But that appears to neither be sufficient (see above) nor
        necessary now, so I removed all those LC_ALL=C settings.  (There is a gawk
        --characters-as-bytes option, but trying that out didn't make a difference for
        this issue.)
        
        clang-cl doesn't support VSLANG, nor does it generate localized diagnostics in
        the first place, but lets consistently add VSLANG=1033 when determining
        LO_CLANG_SHOWINCLUDES_PREFIX in configure.ac, too.  (The way VSLANG=1033 is set
        in gb_CObject__compiler in com_MSC_class.mk, it affects all kinds of MSVC and
        clang-cl invocations, whether or not they actually honour that environment
        variable.)
        
        Change-Id: I52d0e842d200ed256a44d6cc5de1b3868c0acc71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141524
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-19  Miklos Vajna  <vmiklos@collabora.com>  [add110bad816fadeb96e7af0d4689389c04c263e]

        sw content controls, alias and tag: add UI
        
        - add 2 new weld::Entry instances to edit these strings + matching
          labels
        
        - extend the grid to have 2 columns, as previously only a checkbox was
          there for all content controls, which only needed a single column, but
          now we want label + entry pairs in later rows
        
        - cover this with a UITest
        
        Change-Id: Ia5cfb90725d3b5b40eccf15ec7c7823e0e6d6751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141522
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-19  Miklos Vajna  <vmiklos@collabora.com>  [ffc23650d988051bf9fe43edeb4e16096907b080]

        CppunitTest_sw_ww8export2: remove not needed mustTestImportOf()
        
        If the input format is not DOC, we can use the plain
        CPPUNIT_TEST_FIXTURE().
        
        Change-Id: Id69ca33c4c92920989031272d87a31d6d23c0618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141513
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4d9b83a417bbde8148b67d2ab0abe9f4ae285276]

        CppunitTest_sc_anchor_test: inherit from ScBootstrapFixture
        
        so we can get rid of duplicated code
        
        Change-Id: I8e19489f4f3643239d43f83f71fa4c9668d77e54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141506
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6660c77f92f8a040210fb30035761649a19db14]

        CppunitTest_sc_anchor_test: move to slowcheck
        
        so Jenkins executes it in all platforms
        also move it out of 'extra' folder so we can change the
        inheritance to ScBootstrapFixture in a follow-up commit
        
        Change-Id: I06cb594b7f13ece2eb71c2099b6119861b4674ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141504
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-18  Calvince Otieno  <sir_kolly@yahoo.com>  [71aaa2eaa25f1a6bc958c5dcffa79b478ddfa664]

        tdf#42982 Make UNO error reporting more descriptive
        
        Change-Id: I1f1c8285a1d41a9c9694a54c0bdfb20c6f0b27ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141512
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [1e8aaf4f04b94fbd78e305132fa2f1ed77cddfdc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0824040c1aa2ca019a85d26404f61439f0d67432
          - tdf#151169 Document the Data Table chart feature in the help
            
            Change-Id: Iac7ca7a187461ea19926eb34473b58c34222d3af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141186
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [02bd827f39c1e37baabeea1d83921a37450e8a97]

        Move access to SystemDependentDataHolder to Bitmap (2)
        
        I was too positive thinking that SalBitmap would be fine,
        but it's locked to vcl. To be able to add system-dependent
        BitmapBuffering I move the access to Bitmap now. This is
        no functional change, but offers the same access as e.g.
        B2DPolygon/B2DPolyPolygon offer already.
        
        Also cleaned up usage/access to SystemDependentDataManager
        which removes quite some code in constructors and makes
        things easier in general.
        
        Change-Id: I2baa40a12479fab0fe66063a018f058c6b8f5597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141507
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-18  Stephan Bergmann  <sbergman@redhat.com>  [c74133420f6f9b4bc6b414b9c91d54cf8eb3f5af]

        tdf#151545: Restrict JvmfwkUtil_isLoadableJVM to macOS x86-64
        
        That check had been added with 32bc8ddbf335dd26019edcf12758643b4cff9913
        "tdf#94716 allow Oracle's JDK to be used on OS X 10.10 and 10.11", back at a
        time when there was substantial trouble with installations of Apple's own Java
        and Oracle JREs.  One consequence of that commit and its
        JvmfwkUtil_isLoadableJVM check was that on macOS we only supported JDKs (with a
        surrounding Contents directory containing an appropriate Info.plist files), not
        plain JREs (cf. <https://wiki.documentfoundation.org/ReleaseNotes/5.1#macOS>
        "Prior work arounds of having both an Apple JRE 6 and an Oracle JRE 8 are no
        longer sufficient.  Use of the JDK is now hard coded, see tdf#74877, tdf#94716
        and core commit 32bc8ddbf335dd26019edcf12758643b4cff9913.")
        
        However, Apple's own Java is long since deprecated (cf.
        <https://support.apple.com/en-us/HT204036> "You can also download legacy Java SE
        6 from Apple if you’re using an app that specifically requires this unsupported,
        out-of-date version."), and presumably of no practical concern at least on
        contemporary Aarch64-based macOS.
        
        And there is e.g. SDKMAN! (<https://sdkman.io/>), which installs JDKs in a way
        that they are not surrounded by Contents directories containing appropriate
        Info.plist files, so JvmfwkUtil_isLoadableJVM returned false for them and you
        couldn't add them on the LibreOffice Advanced Options tab.
        
        So at least for Aarch64-based macOS, drop that presumably-legacy
        JvmfwkUtil_isLoadableJVM check (but keep it for x86-64--based macOS at least for
        now, just to be safe).  (That implies that for Aarch64-based macOS, it should
        now work again to also use plain JREs.)
        
        Change-Id: I3bcbb3c14e3a9e9dde39fd6f4572b632e05df9e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141508
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [03ef97c7605f4d3f537d5a1f31c2f131a439578d]

        tdf#131910 speed up chart display
        
        the chart2 module likes cloning ScChart2DataSequence, which can take a
        long time if we have lots of data, so share the data via shared_ptr
        
        Change-Id: I4b0948610810c41a8569b97c58b2b52e8e3190f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-18  Hemant Kumar Singh  <iammrhks@yahoo.com>  [683c2e286e2b8f3220481625d085bdde8e1eab29]

        tdf#143148 Use pragma once in vcl/source/edit
        
        Change-Id: I62be40614baf489433a53f19397737031d1f217b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141509
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-18  Regina Henschel  <rb.henschel@t-online.de>  [2969900b75e288e8c626a34277250aa233dc944c]

        tdf#151518 Do not tweak text area distances in Writer
        
        The fix for tdf#148321 has introduced tweaks to the upper and lower
        text distances for the case, that their sum is larger than the text
        area height. That works well in import from PowerPoint but conflicts
        with import of SmartArt shapes from Word.
        
        Reason of the problem is not only the missing Twip to Hmm conversion in
        TextBodyProperties::readjustTextDistances(). But I have not found which
        detail in the tweak produces the wrong text location. For now I have
        disabled the tweak for import from Word. Maybe someone finds a better
        solution in future.
        
        Because the user cannot insert such large distances in Word and SmartArt
        shapes do not use such distances anyway, I think it does not harm to
        disable the method for text documents.
        
        Import from Excel cannot be tested because of tdf#83671.
        
        Change-Id: I2e133f6864bba4419ad96e94d88aec86fe97d0fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141414
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2022-10-18  Stephan Bergmann  <sbergman@redhat.com>  [179c9cbcb036717d7a5463591ffde7ff42146086]

        Elide a redundant var
        
        ...following up on 7b63242ea72885d05faa5f0879395fa93a3446d1 "tdf#145538 - Use
        range based for loops"
        
        Change-Id: Ice88c86e01e69e49b9fca920d61fe6d56763f134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141498
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  OmkarAcharekar  <omkaracharekar12@gmail.com>  [75e6ffe31d74ac36d8864b018008d4208a7efe73]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I35c883a1b05a797e83a41698fa205796e681d7c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141482
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-18  Justin Luth  <jluth@mail.com>  [0bf8a781ffec13b4fbcb96a2e9349b423a92cb1d]

        related tdf#151548 sw: KEY_DOWN access to FieldmarkWithDropDownButton
        
        There was no way to use only a keyboard to access
        dropdown formfields. (This should also work for LO's
        unique DateFieldMark - however you get one of those.)
        
        Change-Id: I2b0b2bd38a43817bbbf1801910815ebe87614f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141488
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-18  Miklos Vajna  <vmiklos@collabora.com>  [888a8c3ca70ed19309c15ff7b9f0968ece337cb5]

        sw content controls, alias and tag: add ODT filter
        
        Map the Alias/Tag UNO properties to:
        
                <loext:content-control loext:alias="..." loext:tag="...">
        
        on export, and do the opposite on import.
        
        Change-Id: Icecbe9037ede0bf8d72d52f2db44328a8db1d83a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141492
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [36bffa3cb5d30a6f58253c627ba23d1cde6864c8]

        sc: Add new wrapper for these tests
        
        Change-Id: Idfa3dc085a944fb8ffe5819b08ba9a264d58900b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141490
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-18  Stephan Bergmann  <sbergman@redhat.com>  [d4512d391bc7f96af9b66a8ee44f3f2be38dc5ec]

        tdf#105609: Support DateModified for updated tdoc stream contents
        
        ...so that the Python script provider, based on those DateModified values, will
        reload a script embedded in a document after that script has (programmatically)
        been modified.
        
        As long as a stream content in a tdoc document has not been modified, it will
        report a default-initialized (all zero) DateModified.  Only when the stream has
        been modified will that be changed to the current date.  While that might not be
        the most beautiful implementation, it at least gets the job done of fixing
        tdf#105609 "Python script provider does not reload modified embedded scripts".
        
        (The DateModified values cannot be stored directly in the tdoc_ucp::Content
        instances, as those are thrown away and recreated on demand.  So they needed to
        be stored more persistently at the tdoc_ucp::OfficeDocumentsManager.)
        
        Change-Id: Iee809960e1a1bc40961f0df2b3729e58b75e6028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141491
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Justin Luth  <justin.luth@collabora.com>  [8ad39b6f2aff3ca37aeaaaaff5373991e853c329]

        tdf#151548 sw: use provided name for formfields
        
        This was already aded for TextFieldmark in 2018 via tdf#120225.
        (A unique name is created if that mark already exists.)
        
        Added it to the other formfield items.
        This is needed for DOC/DOCX import,
        and is critical for connecting macros to the control.
        
        mstahl said that  DateFieldmark is not a valid MS formfield,
        and miklosv indicated  no likely value in preserving a name there.
        
        There is also NonTextFieldmark and FieldmarkWithDropDownButton,
        but they just look like implementation gadgets to me
        so I didn't give them the same treatment.
        
        No need for a unit test here. This is super foundational - anything
        else building on it will be the unit test.
        
        Change-Id: Ide49d6efb8391fea17e7a61c9e99b30532bb2014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141423
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-18  Szymon Kłos  <szymon.klos@collabora.com>  [2aacaa2231298e8a38d5964a13b285f7c5a3d8be]

        lok: impress: clear selection when exited the textbox
        
        it was sill visible in other views
        
        Change-Id: I75ce566a17fa1080d6e3008b964e367825225a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140086
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141478
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-10-18  Miklos Vajna  <vmiklos@collabora.com>  [e9861d8e0138028c17e93fec277125e7752439bd]

        sw: fix crash on deleting a bookmark with active selection listeners
        
        The document had a registered selection listener that created UNO
        cursors (bookmarks) in its selectionChanged() callback. Once an UNO API
        user tried to delete a bookmark, Writer crashed.
        
        What happens is that sw::mark::MarkManager::deleteMark() created an
        iterator pointing to an element of m_vAllMarks, then called
        sw::mark::Bookmark::DeregisterFromDoc(), which indirectly calls
        SwXTextView::NotifySelChanged(), which invokes UNO selection listeners,
        which are allowed to create UNO cursors, which modify m_vAllMarks,
        invalidating the iterator.
        
        Fix the problem by first creating a non-const iterator based on ppMark,
        then conditionally invoke DeregisterFromDoc(). If DeregisterFromDoc() is
        called, then update the iterator based on pMark, so it is valid by the
        time we erase the bookmark from m_vAllMarks.
        
        This was not the problem when erasing the same mark from m_vBookmarks,
        as in that case the iterator creation and the erase() both happen before
        the de-registration.
        
        Change-Id: Iaae95ec9c3038e8ee3b84408094844d0ff678213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141489
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-18  Jim Raykowski  <raykowj@gmail.com>  [a14247144df99f4888f0038adc79ff7d780d53cb]

        Fix turning off outline-folding doesn't clear all folded buttons
        
        This happens, for unknown reason, when buttons that indicate outline
        content is folded are near the current cursor position when the
        options dialog is used to turn outline-folding off. This patch takes a
        new approach to handle outline-folding options, that doesn't exhibit
        this anomaly, by using the ShowOutlineContentVisibilityButton UNO
        function. For the purpose of sanity and to aid understandability of
        what is going on here, extra effort has been made to provide useful
        comments and descriptive variable naming.
        
        Change-Id: I8c3d4c207791f0ba151d799af22e1998aa7c3768
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141353
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac859a4c6a7fce4efee9cdd45821a0c9e40e9e9a]

        tdf#147842 shrink selection to data area when applying to entire sheet
        
        This takes the time to apply the formating from "who knows how long" to about 500ms on my machine.
        
        Change-Id: I202d023c58ea191bf080ef3a85068e8acab52dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141463
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [aa70820a79152830a32070eb722311b8531945a4]

        Removed sd/inc/fadedef.h
        
        It's never included.
        
        It passed "make check" on Linux.
        
        Change-Id: Ia341d898aa64d9dd88f96a2a1c61ae5e873bdb5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141480
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [75932cc26ca18a6f526663416c5ca0ec203f49a3]

        Remove scfobj.hxx
        
        It's never included.
        
        It passed "make check" on Linux.
        
        Change-Id: I1a58f36b081d85ad18c2794120f3a343b30f0ac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141476
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1d6fd96119a34e9c38ca74004f9e8f1f82bd2073]

        Remove helperdecl.hxx
        
        It's never included.
        
        It passed "make check" on Linux.
        
        Change-Id: Iadcc59130374ae318fff5dd1674d59c2906cedd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141477
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Caolán McNamara  <caolanm@redhat.com>  [5b1f19daa1b0ffe5412fabfae80927fb4257e1c6]

        xs:short->xs:int
        
        Change-Id: Ie725e9eb523097ee6a5e159e45c29e0f16a72fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141474
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Miklos Vajna  <vmiklos@collabora.com>  [4595a36b204b2e980f1b55a7f4aaae815d2de413]

        sw: document SwFormatHoriOrient
        
        Unlike in Impress, horizontal position is not just an integer, but it's
        3 numbers: 2 for the anchor and the 3rd for the relative position.
        
        Change-Id: Ibcfed3dff480934659bffa6471e09dfa992fe2bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141472
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ba58fc11723b7c9d370d6407385ea0e8829db099]

        tdf#151462 - Search for outline node containing the current node
        
        If the index lies within a special section, the position of the anchor of the corresponding section will used to search the node of the paragraph. This patch searches for the outline node of the found paragraph in order to find all the corresponding sub indexes.
        
        Change-Id: I9be4bdc0768d5d0d5987d47d37e41acc5009cca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141344
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-18  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [008cf1285d8c9ab293ebf0de26317a9df9725742]

        Added handling of transparence to BackgroundColorPrimitive2D
        
        ...which was missing in ::create2DDecomposition.
        
        Change-Id: I585aa884e4d19bf6f34783d254f502a4c3dd6733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141470
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-18  Stephan Bergmann  <sbergman@redhat.com>  [aa674ac4b5018c7e1ba8e60135ac5202fa67529a]

        Adapt compilerplugins to recent Clang 16 trunk change
        
        <https://github.com/llvm/llvm-project/commit/bcd9ba2b7e64f6ce54defd2fa73fc8e0fee5707c>
        "[clang] Track the templated entity in type substitution."
        
        Change-Id: I314d1567512dc0332b3c61c95978b0230f52b274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141462
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-18  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d8abc710d221da8ca985b70592e3d375e4a8da38]

        tdf#151613 Sifr: 3d Effects icons
        
        Change-Id: Ifc8cda54bfb817f30aa7a44dda4fb8574d2fe698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141487
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-18  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f7b30c67c247a25f00d2582f99783e5ed9651238]

        tdf#151606 Sifr: Icons for Cell Text Extension
        
        Change-Id: I4719b58d7a3978e850cce29b9ca9c99035cb5e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141486
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-18  Michael Meeks  <michael.meeks@collabora.com>  [da6a1a05b2b718a60d31858f19f3af8629d602a9]

        basic: s/helt/held/ and some cleanup.
        
        Change-Id: Idebd2eef29230056caa605c79028e46d34891c44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141485
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-10-18  Michael Meeks  <michael.meeks@collabora.com>  [c0ce606701080bb93a8dff1d7e5df6006f19683a]

        basic: correct reference to method that doesn't exist.
        
        Apparently not there in basic from prior to its open-sourcing.
        
        Change-Id: I9b2da35abfc9971ee380c68f33e239fe63b381c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141483
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-10-18  Justin Luth  <justin.luth@collabora.com>  [7d260761702a5a172f3554bbf44d0e810c441a51]

        related tdf#151548 sw: use start of selection for GetCurrentFieldmark
        
        When walking through a form, the current formfield is highlighted,
        and pressing space should toggle a checkmarkField. Well, GetPoint
        was pointing at the end of the selection, and so we were getting
        a "sw/source/uibase/docvw/edtwin.cxx:2499: Where is my FieldMark??".
        
        My attempt at a unit test caused random crashing (I assume it was
        the protection-editing dialog box) and I never did succeed
        in getting the checkbox to report an unchecked status anyway.
        
        Change-Id: I0f28fb117a84cb5e56463a65d5bb72bbac174865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141424
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2022-10-17  OmkarAcharekar  <omkaracharekar12@gmail.com>  [7b63242ea72885d05faa5f0879395fa93a3446d1]

        tdf#145538 - Use range based for loops
        
        Change-Id: Ia4f795dc9bb59b6d1ee54daae49ac195bbc92a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141434
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-10-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [04778d32b342fe943117a0dfb7b4d35770c5b960]

        tdf#151527 Sifr: Add missing icons in Fontwork dialog
        
        Change-Id: Idf8d83bbbcf8f802743f760dcca2476b0e3e8836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141450
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [19907c9c39273834bca4cfb62cd6614e9309d969]

        ScBootstrapFixture: m_xCalcComponent can be private now
        
        Change-Id: Icc505f61f3df0736d33ffe7d5702dffc42dd1d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141475
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [eda9daa97d0573cc3a78ae37396e3cd462f8221f]

        ScBootstrapFixture: factor out setUp
        
        Change-Id: Ib1549e14b849786abe3a038ac8542c6a8ec1f11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141473
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [27de384c31d3225e02857db1b5e0215a5c1f3467]

        ScBootstrapFixture: factor out tearDown
        
        Change-Id: I3dbced70b7341807451d66d8e70ed61edb44592b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141464
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  andreas kainz  <kainz.a@gmail.com>  [e960180092a30738655e7e091b51f690914461ce]

        tdf#148017 harmonize sidebar .ui files
        
        Change-Id: Ia5139f7255ba0e78f7089a4313a41d583ae62961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141275
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-17  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2c5c611077278edd86247c58a078398ecf17a701]

        Move access to SystemDependentDataHolder to SalBitmap
        
        To be able to buffer BitmapData which is created based on
        Bitmap class data, move the access to
        basegfx::SystemDependentDataHolder from classes where it
        was used until now (WinSalBitmap and SvpSalBitmap) up to
        SalBitmap which is accessible outside vcl.
        
        This is a reorder plus a virtual access method to
        detect/access that helper layer, no functional change.
        It will be needed for system-dependent renderers when
        they want to use that standard buffering e.g. already
        used in the headless & windows backends.
        
        Change-Id: Ib30e7b98e722b977bb0c87ad253e3ffc1841e87e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141456
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-10-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dba6eb60bcd9f55b49699e767993707ec26a8565]

        tdf#151071 Sifr fix Korean Sort icons
        
        Change-Id: I18ccdda2e4106897b412ec73fbd4521ede8f0545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141460
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [7fb21cda4e354bc6714318eca4aead895356b441]

        CppunitTest_sc_parallelism: inherit from BootstrapFixture
        
        no need to inherit from ScBootstrapFixture, this class doesn't
        use anything from there
        
        Change-Id: Ib3d2bfa2161c05a838d1c7a554a3d3e670e9c4a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141465
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [12a438021ae8d8ff0968764ddbe68e878f506f34]

        CppunitTest_sc_dataprovider: Adapt setUp/tearDown
        
        to follow what the rest of ScBootstrapFixture tests do
        
        Change-Id: I9e3df8a53ee2b2d56dcc822a783a9f19a531b791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141461
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [923b75d9cae657a6bf18851c6105513ddab5e95d]

        tdf#135938 - Partially revert fix test case
        
        Because it sometimes hangs, see https://gerrit.libreoffice.org/c/core/+/140985
        
        Change-Id: Iee0d4584256441dff77b0548827fafbd0b559aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141400
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-17  Michael Stahl  <michael.stahl@allotropia.de>  [39b5701976ff3d489c3212d6e2a116d6244c8ad1]

        libxml2: upgrade to release 2.10.3
        
        Fixes CVE-2022-40304 and CVE-2022-40303.
        
        Change-Id: I5be3fd20ccf57596808a26b742aca325ac16f29b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141448
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-17  offtkp  <parisoplop@gmail.com>  [2c44f57b3f59012057a7a0a4d912648d362cf6f3]

        a11y: Add check for spacing spaces
        
        Add accessibility check and relevant test for a document that uses
        multiple spaces for spacing
        
        Change-Id: Ib92471c50a25ead28f2b6c7d5e00ed222d4b429e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141267
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-17  Paris Oplopoios  <paris.oplopoios@collabora.com>  [f03d285d51ba5d5b30e9f8a2b1165270140d5a20]

        a11y: Add check for spacing newlines
        
        Add accessibility check and relevant test for a document that uses
        newlines for spacing
        
        Change-Id: I14f14db5c51cbad1ee184e58eec8ff28563ba92a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141252
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [cbe2d304e1ab33fae8e7b0c72dccbaa576ee5184]

        tdf#149494 Breeze Sidebar Hamburger menu
        
        Change-Id: I485f8ab3d8039cd1e05e3af1beb002ec63d9eb32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141458
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a7ac5f7707f10749a00478af835c9ec212891d1b]

        tdf#151527 Breeze: Add missing icons in Fontwork dialog
        
        Change-Id: I983713fa415b82dc4f526fd28e4e8f179f0f06d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141451
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9932e200b038bacc6c2a188896074bffa5f973b1]

        CppunitTest_sc_datatransformation: inherit from BootstrapFixture
        
        no need to inherit from ScBootstrapFixture, this class doesn't
        use anything from there
        
        Change-Id: Id3cf385c6ff1d94bfe93b855780e70a4d8e8d0a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141453
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Stephan Bergmann  <sbergman@redhat.com>  [7106556d9c4525afc9a6663d60b9076aad48f42e]

        UBSan needs SwTabFrame RTTI now
        
        ...during CppunitTest_sw_uiwriter5,
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_uiwriter5.so: undefined symbol: _ZTI10SwTabFrame"
        
        apparently since c809867f3ee92a8eb36cbab840bd6d6c5b3b1c26 "tdf#150976 sw: fix
        tracked deletion of row with nested table"
        
        Change-Id: I2a2d5ff53a0e58da9373096ac6a9592410663b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141449
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b6cf36104f12f13fdc5321a6342842b03479fc66]

        CppunitTest_sc_range_test: combine both classes together
        
        it helps to reduce duplicated code
        
        Change-Id: Ia6769d6fc91bc2315903e2cce69e7187ee362f5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141454
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [e6ce4b980da5f89470277ded589ec9805e33e7f9]

        CalcUnoApiTest: factor out tearDown
        
        Change-Id: Iae1ae76c1903ff3155da2dd407f1237c29f91840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141375
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Justin Luth  <justin.luth@collabora.com>  [55628d6b258f77eac8a34a1a8f6bbcbf09fd97cc]

        sw vba: add WordBasic.MsgBox
        
        The unit test just consists of adding a
        "WordBasic.MsgBox()" to the vba code in testVBA.docm.
        
        make CppunitTest_sw_macros_test
        
        or just open the file manually for an easy-to-run experience.
        
        Change-Id: I38edfee42649fcc85f0f535a2c9861c45038fa0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141347
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [daa85533cf377a8ec2585f5d45e4d0127f74cdf8]

        ScBootstrapFixture: Move m_xCalcComponent to parent and use it everywhere
        
        Change-Id: I3422f907cd4ce30f0243eb28847e503446b60b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141452
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [8451f4691ebe0e2e6d7d067175b4f0aa548820ba]

        test: remove unneeded setUp/tearDown
        
        no other class in include/test/sheet/ has them
        
        Change-Id: Ia7e196f57f929e466e4dc5c2fb76d654f3be6d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141446
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Rakielle  <rakielledev@gmail.com>  [09ba0057e3d7f8c9d1166269b232a8b2692fa506]

        tdf#132293 remove unused imports and variables
        
        I used pyflakes to check for any unused imports and variables in python scripts under sc, sw, uitest directories, and then removed the unused imports and variables
        
        Change-Id: I0690c9366087dc602ee8ea169bc1c9063033fef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141421
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [61f660daef0e9c848087fbc7a8f95395c7093b8f]

        elide some dynamic_cast in writer
        
        we can use the virtual methods, which are faster
        
        Change-Id: I39215a7e5691cfd11623c0809799387344f14125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141443
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [6bde58fa51d3e546488471ee17760b7442533142]

        loplugin:redundantcast look for redundant dynamic_cast<T&>
        
        Change-Id: If5a8e74b7ede80b782b584b4f62ec1b8713fd86d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [993e075c909a609c8a2af80afc1080672d724ac5]

        simplify SmModel::queryInterface
        
        these two are redundant, the base class queryInterface already handles
        them
        
        Change-Id: I047b32941c104a03a994e0553d80c4ead2b967df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141444
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-17  Miklos Vajna  <vmiklos@collabora.com>  [1a94cd8257ef4c462eaaa6d49bf4f26c9ac56a5e]

        sw content controls: add rendering for the alias
        
        - add a new SwFrameMenuButtonBase subclass to show the title/alias of
          the content control under the cursor, if it's non-empty
        
        - hide it when leaving the content control
        
        - set its label to the alias from SwContentControl
        
        - set the position similar to footer frame menu buttons, at the first
          text portion of the content control
        
        - make the label clickable and bind the handler to the content control
          properties dialog
        
        Change-Id: Ia35f0cc59c70910fb88719b207ef9e498d6760d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141441
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-17  Miklos Vajna  <vmiklos@collabora.com>  [c308ed9fc6c2a223a51fd585e6e0a7d7f6c83352]

        sw: prefix members of SwSvxNumBulletTabDialog, SwTableTabDlg, ...
        
        SwTemplateDlgController and SwXSelChgLstnr_Impl
        
        See tdf#94879 for motivation.
        
        Change-Id: I84d1ba98798a375f8bd138276b5bff45b005d6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141438
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [425255567eafffba3a5817fb96050663d1db8e2f]

        use more string_view
        
        Change-Id: Ie826234aa9064b08b8f0647738b57c47ac0ed91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-17  Chris Sherlock  <chris.sherlock79@gmail.com>  [6125be0aa10113d840a1fdbe33cf3174d5896fcb]

        vcl: extract variable and rename Animation::mnPos to mnFrameIndex
        
        Change-Id: I889a33718da0984bd9230a9b93fe90403272888b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76415
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-17  Chris Sherlock  <chris.sherlock79@gmail.com>  [12ebfc4f6d7b77cd77ac9028dddf0554df05c91e]

        vcl: extract Animation function PopulateRenderers()
        
        Change-Id: I6e490d13ee23faf4536c930264f71354382a08d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76410
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e051b3a6d59ed925e1cddfa72696c9a740830808]

        sw: refactor SwParaIdleData - rename, lifecycle, move to header
        
        This renames SwParaIdleData to sw::ParagraphIdleData, moves it to
        the header file and changes from a raw pointer initialized at the
        SwTextNode construction and deleted at SwTextNode destruction to
        a pure member variable (which has the same lifecycle). A it is not
        a pointer anymore, there is no need to check if it is nullptr or
        not, which simplifies the code.
        
        Change-Id: I74413eef2cfd3666cf75177a6ea080219eee0ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140681
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [822e5aba1b40c69591b5fa6cf94819011adc8455]

        sw: use enum class IdleJobArea instead of a bool (bVisAreaOnly)
        
        It's more clear what the parameter means - either ALL or only
        the VISIBLE area.
        
        Change-Id: Ib9769da55e29feecab3aad81363429b333fa9d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140680
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9b7e904f2f115f22827e4ae3b8da51610ad0c609]

        sw: convert IdleJobType enum to enum class
        
        Change-Id: Ib1843830836b8d0d03d85c82979bae2f26851259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140679
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [01396925b76011ffccb6eea40956a22d58de6f17]

        sw: move the check to determine if job is enabled to own method
        
        Change-Id: Idf681b59f127a6aa1c6496ad7db39f3dd367b99c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140678
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [00c2ea6946db89cec824439b35dcaab17ae75330]

        tdf#150939 Fix conflicting strings in businessdatapage.ui
        
        This patch fixes various string inconsistencies in the businessdatapage.ui (which can be accessed via File - New - Business Cards and then Business tab).
        
        Change-Id: I90b2a316623c3f5c297fbc9b06819ac8440c89ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139845
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-10-16  Jean-Pierre Ledure  <jp@ledure.be>  [a69bca0fda60d988409f628efb21a1799a687378]

        ScriptForge - (SF_Basic) new CreateUnoStruct() method
        
        The method extends the set of functions compatible
        with their corresponding Basic builtin functions.
        
        BTW it might avoid the need for the user to
           import uno
        in his/her Python scripts.
        Of course (s)he remains free to prefer the latter.
        
        Impact only on Python scripts. Basic part is unchanged.
        An update of the help page about the Basic service is reuired.
        
        Change-Id: I3b01eb76aa52f62fa54bae49ddb45755126bc3fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141429
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [f4e7738112eb4a374186a99953a74a5288bee4b0]

        Simplify a bit
        
        Change-Id: Ia983d24c539ab37bcc6457630634142cd5826056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141399
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-16  OmkarAcharekar  <omkaracharekar12@gmail.com>  [3398a2bc324bb00c18071374cb33f97cd9902860]

        tdf#143148 Use pragma once in sw/source/ui/envelp
        
        Change-Id: Iff490b1ceb0bd73aa61fd7a92367d1e71b9f84ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141422
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-16  PoonamShokeen  <poonamshokeen7@gmail.com>  [42d7cd1abca095d5166a7f4355f1cfc0f822961b]

        tdf#114441 Convert use of sal_uLong to sal_uInt32
        
        Change-Id: I1443d1548fc191b057ce073e77f5f4f244086675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141264
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5a1f41a0d3aab15c113651f2edc9d4137ae99063]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e808afadc2ead6b98b40026f6eec15ae669de37c
          - pot file generation only looks for strings with en-US language
            
            so change lang="en" to lang="en-US" to extract the string
            
            Change-Id: I94defd0696be5df576b59030472c43261a359080
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/141366
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [5bf38da0910f590159e8fa4fe359f98c7bd395a4]

        tdf#151522 add Accessibility::HighContrast
        
        0 Automatic, do what the system says
        1 Disable
        2 Enable
        
        Forcing Disable/Enable won't have (much of) an effect on the widgetry, but will
        affect how document content is rendered where typically content color
        is mapped to fore/back ground color.
        
        Change-Id: I71a2dcf8bc334080414a01691f942a5b7de7b84a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139753
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [75fd3093ea748e35beca1f903e7828ad82f2372f]

        tdf#151522 drop Accessibility::AutoDetectSystemHC
        
        which doesn't preclude having a different option to force it
        on/off against the system HighContrast mode setting.
        
        Change-Id: Iab9f7f501ac5fd7bb865d07b30b6fad9f1f6809c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [94e3cce5a9d8136d7c36d1ed596b995aaf47c297]

        ofz: bump sc-rtf and html max lengths
        
        Change-Id: Idd605931d7637d2fc4d1ca878c4ddc6eca9af87b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141419
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Khaled Hosny  <khaled@aliftype.com>  [03ff7ee47c6b4e0dbf38a040825aaca53ce2ed28]

        tdf#123234: Fix subsetting CFF deprecated endchar
        
        Type 2 “endchar” operator can take 4 extra arguments and act like Type 1
        “seac” operator. Although this is documented as deprecated, the fonts in
        the bug report use it.
        
        Detect the presence of the extra arguments and output a “seac” operator
        for them.
        
        Change-Id: Ic24ec8fda586c82612f0cc13f2f31585d40ad9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139908
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5e4af7b91c5c8fd9af705b6333990a9848dfb263]

        Fix typos
        
        Change-Id: Ifd133889ffdc372831ce753deaca847b46705a53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141415
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [dd27b60cb60b7cbe03646a9f2951cedabf4212d6]

        ofz#52422 Build-Failure
        
        Change-Id: I24aae3d273190cc936996c9d81d2c07d9e436193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141418
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [d779ad8cb0ed4a3a1d996bc9979e2cc49a69cae1]

        resave with latest glade
        
        Change-Id: Ie69261feb7fed7f8fda7ac8cb6ee3b8613a1302f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Caolán McNamara  <caolanm@redhat.com>  [77fc0c157de024fbf33db90952a92bf9bb73a9ac]

        cid#1515941 Dereference null return value
        
        Change-Id: I61695d1689cfcef9c04d38b6ef07912840f250bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [5c2e1c894e6d0ef846d3643ef96c56ab548ef0d0]

        vcl: test generating ellipses
        
        Change-Id: Ic985bd9bbee4319243c01fff6dffa46e860581a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [781cf132167d81ff694c7cf82bac30de19711974]

        tdf#151526 Improve TOTD about text in curves
        
        Change-Id: Ib035608c0ee0cea413c5f8dc71b2e10fdc29e763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141394
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-15  offtkp  <parisoplop@gmail.com>  [f9eb59a59723275f7057419d2c05393ac2781972]

        a11y: Add check for background image
        
        Add accessibility check and relevant test for a document with a
        background image
        
        Change-Id: I7b97cff27af66c2614bfc535d369b17ec048e8d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141230
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [cf9a83b495576f9c12cd36f65b11d3d1b8f1d142]

        tdf#136921 Fix color of Insert - Section control in dark mode
        
        Change-Id: I907d39048cfd963d91643bdff7de3d10310217d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141176
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-15  Stephan Bergmann  <sbergman@redhat.com>  [1b9db6c99e5b5f4edb837756e50e949f0ef3a357]

        Restrict StringNumberBase::toAsciiUpperCase to rvalues
        
        Change-Id: I2cc4787d0db256337fe740e9cecb96ce7081bffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141374
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-15  László Németh  <nemeth@numbertext.org>  [c809867f3ee92a8eb36cbab840bd6d6c5b3b1c26]

        tdf#150976 sw: fix tracked deletion of row with nested table
        
        Rows lost their tracked deletion if one of their cells
        started with a nested table.
        
        Follow-up to commit 0140fd6501c2322cffddaaa14b49137009ffcae4
        "tdf#151478 sw: fix row/column selection at nested table"
        and commit 3442a46995f967dbd4c99797f7f13794912f0f58
        "tdf#47979 sw: test row & column selection with mouse".
        
        Change-Id: I39c291c13c5c5111d7f325f128090ee74a5e0845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141382
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-14  Michael Stahl  <michael.stahl@allotropia.de>  [8c32cc17ce914188ea6783b0f79e19c5ddbf0b8d]

        tdf#146500 sw: try to fix some layout loops caused by fly in table cell
        
        Reportedly regression from commit 1cb7e4899b5ada902e99a0c964ee047950c07044
        but reverting that on master doesn't seem to help.
        
        Inserting paragraphs with single letters into the first cell on page 2,
        once we get to "s" and press Enter, the infinite loop happens as text
        frame 56 is split at index 0 (where a fly is anchored), the new follow
        moves to page 3, and very quickly frame 56 is formatted again and all
        text in the follow moves back to page 2, where it doesn't fit with its
        anchored fly.
        
        The problem here is that the (Word format) file sets the
        ConsiderObjWrapInfluenceOnObjPos mode, which disables any use of the
        SwLayouter::FrameMovedFwdByObjPos() etc. functions.
        
        Oddly enough the spec obj-pos-without-wrapping.sxw claims that in this
        mode, "If a paragraph respectively one of the anchor characters moves to
        the next page during its format in step (2) or (4), the process is
        re-started with this paragraph, the complete paragraph is moved to the
        next page and it is assured that the paragraph doesn't move back again."
        
        What happens instead is that when a fly position is changed, its
        mbRestartLayoutProcess flag is set.
        
        So let's try to check this flag during SwTextFrame::Format(): stop at a
        position where a fly is anchored in a follow frame that has the flag
        set, via rInf.SetStop(true).
        
        This is similar to a check in SwFlowFrame::MoveBwd() that prevents a
        frame from moving back if it has an anchored fly with this flag set.
        
        Now we get a different loop, where the text frame moves forward, then
        back and then splits again.
        
        This is because ShouldBwdMoved() sees that the first line of the text
        frame fits into the cell of the previous page - but the first line
        consists only of a SwFlyPortion and a SwMarginPortion, for the fly
        anchored in the same text frame.
        
        So change WidowsAndOrphans::WouldFit() to continue until the first line
        that doesn't consist entirely of flys.
        
        Then there's another loop where the follow flow row is joined and then
        splits again - this is very similar to the previous problem, change
        SwTextFrame::FirstLineHeight() (which is only called from table code) to
        continue until a non-fly line as well.
        
        Unforunately this is all not so clear because we can't actually tell
        which text frame contains the anchor of a SwFlyPortion, so let's see
        what's going to break with these changes.
        
        Change-Id: Ia6e80f86f6ca3d2e3d91651b6a403c050d74ebfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141383
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-14  Khaled Hosny  <khaled@aliftype.com>  [720a093461aadff044ac0b1b7b45cf3d416b3785]

        vcl: Remove recently unused GetMirroredChar()
        
        Unused since:
        
        commit 69e9925ded584113e52f84ef0ed7c224079fa061
        Author: Kevin Suo <suokunlong@126.com>
        Date:   Tue Oct 11 10:04:16 2022 +0800
        
            sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversed
        
        Change-Id: I0d144d326a4f947a3453fdfb05fccb32a1e6e24e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141384
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-14  Caolán McNamara  <caolanm@redhat.com>  [07f675361d5a09ad4e3978f324dcd3c8c6d90cef]

        cid#1515996 silence Unchecked return value from library
        
        Change-Id: I37c4af0e0b1c60b2eaab8505c3b2eba9b9e131c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd3c16fbcb4f8e5e4c4448bc7cda96e8476d6aec]

        tdf#129101 CTRL+A & Cut very slow
        
        avoid repeated invalidation of number tree, shaves 90% time off
        
        Change-Id: I051f6a3fefc0b22c33c03cec41a3327fc3460f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141373
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-14  Miklos Vajna  <vmiklos@collabora.com>  [3565c3c94c6bdad5ab0913d979fd4e97547488e6]

        sw: tables have frames, not portions
        
        Went wrong in commit 60b0526ea4929ce273de499f552a4d478a973d10 (convert
        POR constants to scoped enum, 2019-01-17), which changed POR_TAB to
        PortionType::Table.
        
        Change-Id: I27131f2ab42f7c53310ee8e61b8481e07ed77da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141379
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-14  Caolán McNamara  <caolanm@redhat.com>  [2e49822ee7b3a77ac148997c7958cfa8d31090eb]

        ofz#51830 Timeout
        
        Change-Id: I934db0f86b118d4bb7876f162060ef75595fcef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-14  Alain Romedenne  <alain.romedenne@libreoffice.org>  [17c85818faedd639ca6deb63a0a0b5dc1db6969c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 50f596f7e6729dcc81f443f34bd8d41518790fba
          - typo
            
            Change-Id: Iaf047d5a663d1cd3facfd8ab270cd654b5ff0ce8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141322
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a96b911c112386b1af89115c9a96d4ace9d68326]

        CalcUnoApiTest: Move mxComponent to parent and use it everywhere
        
        Change-Id: Ibea7a300b7f302936f872d7133aadafeb13d6d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141350
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-14  Stephan Bergmann  <sbergman@redhat.com>  [99e019708609a52ea6b2ad29fc945c4dc4160351]

        Clean up loplugin:stringview
        
        ...after 3d236177be255b2027a997bfc12fe0833ca9a2f7 "Deduplicate
        O(U)StringConcatenation" changed OStringConcat and OUStringConcat into aliases
        (so they will get looked through by loplugin::TypeCheck::Struct's use of
        getAs<clang::RecordType> in compilerplugins/clang/check.hxx), but apparently
        forgot to drop their respective checks here.  (That the then-added check for
        StringConcat works as intended is verified by
        compilerplugins/clang/test/stringview.cxx, btw.)
        
        Change-Id: I3f8e26998d0a55704f0433a818493ef541fd05eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141370
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-14  Stephan Bergmann  <sbergman@redhat.com>  [e3706663a9ad5962155a5d23a6388cd648a49a05]

        Clean up loplugin:stringadd
        
        ...after 3d236177be255b2027a997bfc12fe0833ca9a2f7 "Deduplicate
        O(U)StringConcatenation" changed OStringConcat and OUStringConcat into aliases
        (so they can never show up here in a "getUnqualifiedDesugareType"), but
        apparently forgot to drop their respective checks here.  (That the then-added
        check for StringConcat works as intended is verified by
        compilerplugins/clang/test/stringadd.cxx, btw.)
        
        Change-Id: I2b589d977dbf2a384348cb7ee62acce30031ccec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141364
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-14  Caolán McNamara  <caolanm@redhat.com>  [f72cd57a3397088433df32baed5c1eb5210a6712]

        ofz#52353 Out-of-memory with ultrathick lines
        
        Change-Id: Id907795a0e8f7646462edd510dfbc62ad2c26617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-14  Miklos Vajna  <vmiklos@collabora.com>  [8d4f64427528f76afa4bf39a23edaa991850a50a]

        sw: improve duplicated images in copied header/footer text
        
        DOCX import currently maps linked headers to 2 Writer headers, the
        second header has a copy of the first header's content. The image in the
        first header is named 'Picture 1', the copied header names the image as
        'Image1'.
        
        This is similar to what commit 41403fbff8140ad0ca7cf8f81d37cddcfbd19197
        (sw: improve duplicated bookmarks in copied header/footer text,
        2022-10-13) fixed for bookmarks, what happens is that
        sw::DocumentLayoutManager::CopyLayoutFormat() clears the name of the
        image, and then these are filled in at the end of the import in one
        shot, to improve performance. The downside is that it's not possible for
        an API user to know which was the original image and which is the copy.
        
        Fix the problem by tweaking the in-header-footer && not-in-mail-merge
        case to generate a name like 'Picture 1 Copy 1': this is meant to
        preserve the lost connection between the original image and its copy,
        while maintaining performance for the mail merge and body text cases
        where we expect lots of images.
        
        In the long run it would probably make sense to rather support linked
        headers/footers in Writer core so we don't have to create such a copy in
        the first place.
        
        Change-Id: I9679c0ce67131ed5c48eaecfcfd38abd1bcd3da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141360
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [48c0b19205af6e8d0ddee31afa011890e54b46e5]

        sc: inherit from CalcUnoApiTest instead of UnoApiTest
        
        like the rest of tests in sc
        
        Change-Id: I15979c6279cf9af6953f661ed8dd2f5a60f1b988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141349
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ca3ac3f3b3007d25c5ea68f67536c5e63fbb4e9]

        sc: add tearDown to these test classes
        
        Same as the rest of CalcUnoApiTest tests
        
        Change-Id: I55294231fd11fd31ed6f57459b2f0292ddb23635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141358
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a42c8923031522284c3199bed397c9e9639a71b5]

        CppunitTest_sc_vba_macro_test: Do not test specific file on Windows
        
        tb39 fails now with
        
        C:/cygwin64/home/tdf/lode/jenkins/workspace/gerrit_windows/sc/qa/extras/vba-macro-test.cxx(605) : error : Assertion
        Test name: VBAMacroTest::testVba
        equality assertion failed
        - Expected: OK
        - Actual  : Test Results
        ============
        
         Failed:  : Test change event for Range.Clear set:
         Failed:  : Test change event for Range.ClearContents set:
         Failed:  : Test change event for Range.Replace:
         Failed:  : Test change event for Range.FillRight:
        Tests passed: 4
        Tests failed: 4
        
        - script reported failure in file Ranges-3.xls
        
        Change-Id: If226dfc201f124712abeec422cf79a675d25b9fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-14  Stephan Bergmann  <sbergman@redhat.com>  [6d2a9697c9933133539773af6d493a42c6fb94a9]

        Remove unused comphelper::string::reverseString overload
        
        Change-Id: Ic1c56c7be9804685fd37b8f6a13aaab039e07afa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141361
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-14  Stephan Bergmann  <sbergman@redhat.com>  [8195c98dbabc01a11fa2dd73fefabcd6d331d7cf]

        Fix loplugin:stringconcatauto
        
        ...after af2879e434fa0dc6b2a626617ed865e4f66eb5ad "Deduplicate stringconcat
        more" changed the *StringNumberBase::toAsciiUperCase return typr from
        O[U]StringNumber to the underlying StringNumberBase.  (And where that commit had
        added some odd check for a non-existing "StringNumber" type to
        compilerplugins/clang/stringconcatauto.cxx, presumably in error.)
        
        Change-Id: I622e6ae30fcec8f081c978eaf67ffb716a10ee4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141363
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c461e9d7a0d6fbb20dc6ac22ec049f1ff9100856]

        add missing dependency for gbuild-to-json
        
        while most of the integration targets are meant to have a nice debugging
        environment, others like the vim-ide-integration or also the vscode one
        seek to provide a nice editing experience with code completion and code
        lookup.
        
        Ideally you'd be able to have the integration available immediately and
        can use the editor while a build is running in the background. But from
        a fresh builddir make vim-ide-integration (vscode-ide-integration) fails
        because of the missing dependency. That dependency probably is optional
        for the purpose of just providing a editing environment as opposed to
        providing build-targets like the integration does for some of the other
        IDEs, so I consider this commit more of a "good enough" workaround for
        the time being.
        
        Change-Id: I586445fed849d416fde9804a1e2a9c6ee0ed50eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141248
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-10-14  Aron Budea  <aron.budea@collabora.com>  [77fb3ffdb6a8077cd3931985de923fbd1396d424]

        tdf#150682 Change shortcut of inserting Math objects to Alt+Shift+E
        
        Ctrl+Alt combinations don't work on Windows if they're also
        doubling as AltGr modifiers, eg. in French keyboard layout,
        Ctrl+Alt+'=' (which is the same as AltGr+'=' ) is '}'.
        Avoid this by switching to different modifiers.
        
        In addition '=' can require a modifier to enter, eg. in German
        layout (Shift+0), so use an ASCII character, 'E' instead.
        
        Ctrl+Shift+E is listed as a problematic combination in
        Accelerators.xcu, settled on Alt+Shift+E in the end.
        
        Also partially revert d156e891db34e88991a6c18fd3cff6feddfc61c8,
        which did not work.
        
        Change-Id: Ie3625f2c55171187fbbe2c4f79821eba8c25f40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141227
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-10-14  Emmanuel Peter  <awinspeters@gmail.com>  [6629197f08249725e9fef4f0c5fee3c98657d838]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Idf9f5b604bc60d7f1bacdd0001ce252aaeb7835a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141334
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [949d095eed47fdf8b320fdcff5a8dbdc92cd5d6c]

        Merge makefiles of Writer and Draw templates
        
        Simplify the list of files in the same way as for wizard templates
        
        Change-Id: If93374de161b670a96b9d2447f03f29d8c085efa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141274
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [dcff848b6ad04c4fe7b6456a3658357e84033b6d]

        Improve makefile of Impress templates
        
        Simplify the list of files in the same way as for wizard templates
        
        Change-Id: I38258dd0d06940acbf47e6cffbb76924e7d5466e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137364
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-14  Calvince Otieno  <sir_kolly@yahoo.com>  [93b75323205b1337643c7df2d5aa0eaeb49f888b]

        tdf#143148 Use pragma once instead of include guards in the header file
        
        Change-Id: I6566cfb722bbe2779e9a5b32fa83f17353457dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141351
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-14  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bdfcad586d7b1d4d26bcba50058af7fcb279558d]

        tdf#151503 - Do not evaluate a missing optional variable to a boolean
        
        Change-Id: I671f857344f91de63612eabcbbdb2cab9b94cc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141296
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-14  Caolán McNamara  <caolanm@redhat.com>  [aa451a4230778f9d4e6a931f51a60dba5f7a116a]

        Resolves: tdf#151468 honour tiff resolution fields
        
        Change-Id: I57d996f49c6ae7e60991ff53eae867144b56d89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-14  Caolán McNamara  <caolanm@redhat.com>  [937a96c7b8e9c02b6cc7dde3f2822d03c3c1cb4d]

        ofz#52337 Direct-leak
        
        cairo starts leaking things when a surface is in an error state
        
        Change-Id: I0be0d9f8e3c8938073cec1aa765ab82826ceb6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141335
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-14  Justin Luth  <justin.luth@collabora.com>  [a8209c52d6daeb00ed85d5c705ec84c9603e2f3e]

        sw vba: add WordBasic.ScreenUpdating
        
        Change-Id: I3d074c224b77eff9f4ab1ea6bade6d66828fc88c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141273
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-14  Justin Luth  <justin.luth@collabora.com>  [8717a700e847330897b44aa40d1787c65dfa64be]

        sw vba: add doxygen comment for class SwWordBasic
        
        Change-Id: I8b12845341e8754c0882411c19a57b7a46e05e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141290
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [97ee126d69859d01abfbdb55450d27afb71bf9b1]

        WASM add Calc as optional build result, make it build & run
        
        Adding new config option: --with-main-module=<writer/calc>
        With this switcher we can build only WASM writer module or
        calc module. The default value is 'writer'.
        
        This commit also reverts: 26603bc9ef0116ed31c510dab82b69d3666447b5
        (WASM fix orcus native exception handling (NEH))
        Because Calc import is using liborcus for loading styles.xml.
        
        Change-Id: I4c330ef8eea7d08214bf357531ee0bf7383ab788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137946
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2022-10-14  Jean-Pierre Ledure  <jp@ledure.be>  [06933af12a34aa07068c38af0ce196a7037f5119]

        ScriptForge - (Dialogs) tdf#151510 fix CreateScriptService("dialog")
        
        Bug description:
        Programmatic access to doc-based dialog
        is not possible using ScriptForge.Dialog service
        
        The relevant component was identified incorrectly
        in routine
           SFDialogs.SF_Register_NewDialog()
        
        Change-Id: I13f6302330ca097b8aef8fd3cdbd0b3d05a1b58c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141337
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-10-14  Miklos Vajna  <vmiklos@collabora.com>  [a42b495393a71c089f6aa2c05dd7bdb3ca0eba62]

        CppunitTest_sw_mailmerge2: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Iebce134a84b022f45548eb97af4325208e5a2235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141342
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-14  Chris Sherlock  <chris.sherlock79@gmail.com>  [65b2aa877dd8a9fd42992faf532144d22ae93182]

        vcl: followup 'vcl: extract function CreateAnimationDataItems'
        
        Change-Id: I25d2057477dae952e2ded966cf2f7feedf6d90f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141341
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-14  Rakielle  <rakielledev@gmail.com>  [f42bd275ce707ce3d88553d04582333f2eff0d71]

        tdf#143148 Use pragma once instead of include guards
        
        used pragma in 3 files
        
        Change-Id: Ia8a67501388bb5f79485494fd2aa77a8e45d710f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141352
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [833825eec54718ac99ab31877fb65a83864ba049]

        Fix typo in code
        
        Change-Id: If4cf1a77490650902d77705761b5168bdf5cece8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141306
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-14  Stephan Bergmann  <sbergman@redhat.com>  [9b227506a5fd3e84d4aa877fc6459996546348ba]

        Start to fix the "BASIC Macros" dialog's "Assign..." button
        
        c79212479f42cadd39173e77acc5e6446480ff05 "Fix a misuse of two-argument std
        string_view rfind" found that e.g. in Writer "Tools - Macros - Organize Macros -
        Basic...", in "Macro From" select "My Macros - Standard - Module1" and in
        "Existing Macros in: Module 1" select "Main", then "Assign..." had apparently
        rotten over time and brought up the "Customize" dialog's default "Menus" tab.
        
        With this fix, it now brings up the "Customize" dialog's "Keyboard" tab, in the
        "Category" tree list selects the appropriate "Module1" line, and in the
        "Function" list shows all the corresponding functions (just "Main" in this
        case).
        
        It doesn't yet select the appropriate line ("Main") in the "Function" list,
        though.  That apparently needs further fixing.
        
        Change-Id: Ia5b9ef88d29e01f4f5e22ce3aec20f5fc22b5d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a09c5c69e3b5fbf448cae1d6c476f39067e40023]

        This can be const
        
        Change-Id: I5e0cb22c9276e41b0a42978a253456ebd9ebefa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141356
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [8991cbb7986d3967bc6c3719d95254ff04428d1a]

        CppunitTest_sc_shapetest: use member XComponent
        
        Change-Id: If881b238991cfce8d866edd662fb6eb70c8f29a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141336
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [7fc96ad09520abea4833ed7410fd3a2d1b63d7b1]

        tdf#150473 Wrap text and set min size for Function description
        
        This patch does the following changes to the Functions sidebar in Calc:
        
        1) The function description now uses a TextView instead of a Label so that the text can now wrap. This is important because many descriptions are long and require more than a single line of text.
        
        2) The minimum size of the description TextView is set to 6 lines of text. Because there's no easy way to set this minimum size (since it is inside a Slider control), then the following rule was applied.
        - If the user resizes the slider to less than 6 rows (in this case, moves it down), the next time a new function is clicked the slider is positioned so that 6 lines of text become visible.
        - Moving the slider up, thus giving more space to the description view is still allowed as prior to this patch.
        
        Change-Id: I52dfa8bef52b645fdce379408e6b790f6e8e5dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140507
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-10-13  Eike Rathke  <erack@redhat.com>  [2b1d34679d8a5128bc13d932466c2a6464525627]

        Change split regexp from \~ to ~
        
            gawk: ./list-dateacceptancepattern.awk:70: warning: regexp escape sequence `\~' is not a known regexp operator
        
        Also set the executable bit again..
        
        Change-Id: Icdf45979d6fb19d207dcf5475845767438c3ef6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141340
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-13  Kevin Suo  <suokunlong@126.com>  [69e9925ded584113e52f84ef0ed7c224079fa061]

        sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversed
        
        For the simple Arabic string: ٱلسَّلَامُ عَلَيْك, the xpdfimport binary generates the
        follwing (drawchar) sequences:
        كَ
        يْ
        لَ
        عَ
        مُ
        ا
        لَ
        سَّ
        ل
        ٱ
        (i.e., in reversed order, one character by one character).
        
        Before this patch, after pdfimport the text shows up as لَسَّلٱ كَيْلَعَ مُا, which is reversed.
        
        It was surposed to combine these characters into text frames in
        DrawXmlOptimizer::optimizeTextElements(Element& rParent) (sdext/source/pdfimport/\
        tree/drawtreevisiting.cxx:677), but actually it was not combined successfully there.
        The single characters were then passed to sdext/source/pdfimport/tree/drawtreevisiting\
        .cxx:105, one by one, in the hope that the strings could be mirrored. The mirroring
        failed, because one single character, even after mirroring, always equals itself.
        
        The DrawXmlOptimizer::optimizeTextElements failed to combine the characters into
        one text frame, because the condition:
        (rCurGC.Transformation == rNextGC.Transformation || notTransformed(rNextGC))
        would never be true, as at least its horizontal position is different. A further analysis
        indicates that we do not need to check the transformation here at all, as this is an
        optimizer for a TextElement and in case a character is transformed then it would already
        be in a different draw element (thus will never be combined with this TextElement).
        
        After the fix of DrawXmlOptimizer::optimizeTextElements which now successfully
        combines the characters, there is another issue in the old PDFIProcessor::mirrorString
        function. It seems to mirror the characters within a word, but if a string contains
        two words, then the two words are not successfully switched (e.g. for string "abc def"
        it produces "cba fed" rather than "fed cba"),  which is not suitable for
        the case of RTL which requires all the characters been reversed. Fix this by using
        comphelper::string::reverseString.
        
        Change-Id: Ifa210836f1d6666dd56205ff0d243adfb4114794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141231
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-10-13  László Németh  <nemeth@numbertext.org>  [3442a46995f967dbd4c99797f7f13794912f0f58]

        tdf#47979 sw: test row & column selection with mouse
        
        Commit 0140fd6501c2322cffddaaa14b49137009ffcae4
        "tdf#151478 sw: fix row/column selection at nested table"
        fixed also selection with mouse, not only selection
        with Table->Select->Row and Table->Select->Column.
        
        Add unit tests for fixed row and column selections
        using code path of mouse clicks.
        
        Change-Id: I96c56a65e908a56fcaf43b8cfc2adbc091c65fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141297
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9e6db1ae2b0e8e070ae13fbae782bc2c01f49049]

        Remove duplicated include
        
        Change-Id: I481d3dca7fe2fd60093ad77636edb8df836da1d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141262
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-10-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3471299f1976499ab5f85fc6580b9633f4737399]

        tdf#151352 crash closing form while TOTD dialog is displayed
        
        regression from
            commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sat May 29 08:34:28 2021 +0200
            IsDisposed->isDisposed in vcl/../window
        
        Change-Id: I51889f2451f03797f5b89019e6df32a64acda707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-13  Stephan Bergmann  <sbergman@redhat.com>  [3b35199a1b5e860b17ace504ae2e99248e37fc63]

        Drop now-redundant %select
        
        ...after 3d236177be255b2027a997bfc12fe0833ca9a2f7 "Deduplicate
        O(U)StringConcatenation"
        
        Change-Id: Ib45d021da2bb5745055fa0cdebfd700680bfb787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141304
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [917c7837001345fa2faee5ecd700ad2318eb8bca]

        Fix typo
        
        Change-Id: I4bfa53602b34d18ae9229aa8e110b85dfd160f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141307
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6e896fef57ff879f3d5ce9e5b1f1eac47188d192]

        Fix typo
        
        Change-Id: If62e035cf92f5fad359da9dd426f0975b1da6b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141308
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [35e5dcfa40c9408152cfbc38a4dd450aaee6d5c1]

        Fix typo
        
        Change-Id: I4171730123186c8b057e6a05e382f253f81a0013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141310
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e13e253a4644fcb913591cc24c7af979a0ff87ef]

        Fix typo
        
        Change-Id: Ia4d7dd731e24c89c3228fdaf18cc0558a9c5ee66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141311
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [90bf4f661840f5dd6bf2a46564f2683c5e8fbd47]

        Fix typo
        
        Change-Id: Ie04728548d82e6eb5b0d46e65c279dcda5442bf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141309
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fb1b3f643bdb26a2d806f95ad254889270de660f]

        Fix typo
        
        Change-Id: Iff1adef6278239436bbaabd619ed12648d0819df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141305
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [509cc1ad19194934e15366a6e9ecc0a1b9ef4592]

        Fix typo
        
        Change-Id: Ib12fdce5b4a46ec98828aeba6a293ca3a3e1c766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141312
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [60c7493e661d19fd3f6dde3c8ab8cef4b1ba9f2b]

        CppunitTest_sc_macros_test: improve setup/teardown
        
        Similar to 8b4ac8c35d5e4efe3c0b83e15543a35213e786f2
        "improve setup/teardown handling in VBAMacrosTest"
        
        Change-Id: I34b64a72f6cab1f85e6e2628b6fd07f408f62cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141302
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [e8fae4d0fb2994a7b4ac00e9da35e1deccb296dd]

        tdf#124098: sc, ods import: do not recalculate row heights
        
        if we have already optimal heights in the xml, because it is
        not necessary and it takes a lot of time loading a file.
        
        Citing here for completeness:
        a) if there is no height attribute and the "use_optimal-row-height"
        attribute is set then calculate the row height
        
        b) if there is a height attribute just use it and do not recalculate.
        
        Maybe TODO for later: optimize row height calculation more in sc
        
        Change-Id: I9d964aad744970e5d36f239c0ce39ce98c00f273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141204
        Tested-by: Jenkins
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed99b776d59d6293a97e61dc5284619cc873e35b]

        tdf#151417: sd_uiimpress: Add unittest
        
        Change-Id: I8f5f957557612ce78036d962968a3e9fef113cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141291
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Mike Kaganski  <mike.kaganski@collabora.com>  [ba42683fada2abafa18a49cd50ce8298b92851c8]

        tdf#120326: properly prevent Windows from entering power saving
        
        The previous call to SystemParametersInfoW with SPI_SETSCREENSAVEACTIVE
        only prevented screen saver from running (which is not often used these
        days), but screen was still turned off (and power saving was started).
        
        Despite SetThreadExecutionState documentation [1] claims that it does
        not stop the screen saver from executing, my experiments show that it
        does (on my Windows 10). So just use it, because it is designed exactly
        for this task (documentation discusses the presentation applications).
        
        [1] https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-setthreadexecutionstate
        
        Change-Id: I6eced8f0a7c17211a0b68851a40227eed9a22b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141289
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [17f5c8ef18202355189f8b1b11f67b4e106fd31e]

        crashtesting: uncaught exception on export of forum-fr-20226.sxi to pptx
        
        due to not-found wav file linked to from presentation
        
        Change-Id: I48c7b4615d660a2a292feea36e228237235ab04f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  Chenxiong Qi  <qcxhome@gmail.com>  [665d1633c9e08da85fae179e62923211bc07c480]

        tdf#143123 port DocumentHandling examples to Python
        
        This port keeps the similarity with Java ones as much as possible.
        
        examples.html is also updated by adding the Python examples.
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I2af26aaf42f5408bf254a4e0507442200f843661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139887
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-10-13  Stephan Bergmann  <sbergman@redhat.com>  [5956cecdf61846671f7d028ad60623e1e840ad3f]

        Adapt CompilerTest_compilerplugins_clang to recent Clang
        
        ...where at least my recent Clang 16 trunk build now started to fail after
        af2879e434fa0dc6b2a626617ed865e4f66eb5ad "Deduplicate stringconcat more" with
        
        > error: 'error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/stringview.cxx Line 171 (directive at compilerplugins/clang/test/stringview.cxx:170): instead of an '{{(rtl::)?}}OString' constructed from a 'OStringConcat<rtl::OString, rtl::OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview]
        >   File compilerplugins/clang/test/stringview.cxx Line 196 (directive at compilerplugins/clang/test/stringview.cxx:195): instead of an '{{(rtl::)?}}OUString' constructed from a 'OUStringConcat<rtl::OUString, rtl::OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview]
        > error: 'error' diagnostics seen but not expected:
        >   File compilerplugins/clang/test/stringview.cxx Line 171: instead of an 'OString' constructed from a 'OStringConcat<OString, OString>' (aka 'StringConcat<char, rtl::OString, rtl::OString>'), pass a 'std::string_view' via 'rtl::Concat2View' [loplugin:stringview]
        >   File compilerplugins/clang/test/stringview.cxx Line 196: instead of an 'OUString' constructed from a 'OUStringConcat<OUString, OUString>' (aka 'StringConcat<char16_t, rtl::OUString, rtl::OUString>'), pass a 'std::u16string_view' via 'rtl::Concat2View' [loplugin:stringview]
        > 4 errors generated.
        > make[1]: *** [solenv/gbuild/LinkTarget.mk:337: workdir/CxxObject/compilerplugins/clang/test/stringview.o] Error 1
        
        Change-Id: I0b8c7d4a012c40c2c2c3cc8a9e55c52f45e8cfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141295
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-13  Miklos Vajna  <vmiklos@collabora.com>  [41403fbff8140ad0ca7cf8f81d37cddcfbd19197]

        sw: improve duplicated bookmarks in copied header/footer text
        
        Bookmarks in copied text were renamed in a way that made it hard to
        differentiate between the original bookmark and the copy, e.g. "Bookmark
        1" was renamed to "Bookmark 11".
        
        Bookmarks are supposed to have a unique name, so renaming makes sense,
        and it's probably better to do that compared to what commit
        3ec224dcb15e0e663ba85077b8ea0e632f8f03f8 (DOCX import: avoid duplicated
        bookmarks in copied header/footer text, 2022-09-08) did to just omit
        them during copy. That solved the duplicated bookmarks, but if one had
        bookmarks around images to find them, now it doesn't work to find all
        such images.
        
        Fix the problem by going back to copying bookmarks, but copy "Bookmark
        1" as "Bookmark 1 Copy 1" (and "Bookmark 1 Copy 2", etc), so API users
        can identify the original and the copied bookmarks.
        
        A similar problem is there for images as well, but that's not yet
        addressed here.
        
        Change-Id: Ic0689b05f790a99ff06523ff4836b1dd412af896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141293
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [580115275da91e8a591ecc94e6bf4b62f801cf60]

        tdf#150664 Initialize input line correctly
        
        Initialize code was not called when xlsx file was loaded
        (line count is only stored in ods format).
        
        Change-Id: I5b01f6079921af77ffd6da09ae5d5388b8beff1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141281
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [2734d2e058182a34c576e558138d84358c69ca5a]

        tdf#150622 use high contrast selection fg/bg colors for text selection
        
        with SettingsForSelection
        SettingsText -> HighlightTextColor
        SettingsFill -> HighlightColor
        SettingsLine -> HighlightColor
        
        Change-Id: Iaac5834ce0f8b3f1b89376711b564773cfd0bfe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [ee0d5e7bb8614c50e71dd074b8440f412eb62ff3]

        use OutputDevice clipping if its just a set of rectangles
        
        Change-Id: I249866d1aef29d256439c0437835a173d8a4c633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141286
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b9f41880b409cafd62fb3d1cad82537f12d08b1]

        tdf#145871: sw_odfexport2: Add unittest
        
        Change-Id: Ic473fa92b37ea1024ed5021ed6b59079d455c87c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141285
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2e887e04c0008a4eb6cbf34050b6fa463a33599f]

        tdf#125363, tdf#123095 - Use CaseTransliteration for autofilter
        
        Change-Id: Ib6f1edebe26a69d3316a901e00d2bc6e0c66695f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141047
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [06f990a50d211564b89420af184edcf6145c0ce8]

        tdf#151375: sw_odfimport: Add unittest
        
        Change-Id: I702059fcfc8e99b11412f959bc924af73780d351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141284
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [25d0e944ae0e6e535e90dcec28624f1478dba60c]

        tdf#151502 Sifr: Wrap in image properties
        
        Change-Id: Id33a3293349ca3dba6263b2d626acdf9748987bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141282
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-13  Noel Grandin  <noelgrandin@gmail.com>  [8f1f2ba78de1cd71447b6a387b701ebfb917df79]

        rearrange node logic here
        
        so we don't have to touch SwPosition.nContent.
        
        Part of the process of hiding the internals of SwPosition
        
        Change-Id: I02fed4998b68edaca4ef3014bc64cca85af7fcdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ce92931bf406fb467934374af1188927f34a972]

        tdf#151424: chart2_xshape: Add unittest
        
        Change-Id: I2570815857fd170d9511ad507b17b102ca8ddabf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141283
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [046bc5029681444cb5d707b33a8aa3cc67732c22]

        tdf#150622 allow use of selection color for frame in HighContrast mode
        
        Change-Id: I0a45051c9ba8bbfe785689103c6af6285a282345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [79fd84a2c3da8d52a09f31e272b33a941d355fd5]

        split frame into a separate overlay object
        
        Change-Id: If07591ba27cb8ebfdf9c737e7a2416702e4feb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141260
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  Caolán McNamara  <caolanm@redhat.com>  [d28942e5b8f0c58a724e52133eb58b261949266e]

        drop newly unused StyleSettings::GetFontColor
        
        Change-Id: Icd20283207e9ac0392d11d74553d7c607330dbe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140895
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-13  offtkp  <parisoplop@gmail.com>  [b45867766184ad1200df4183dab537fac9e83ea2]

        a11y: Add char attr a11y check for entire paragraph
        
        Accessibility check would not work if the entire paragraph had
        character attributes, because then it wouldn't have individual text
        hints
        
        Now check if there's a SwAttrSet and if it has the a11y char attributes
        that an issue should be generated for
        
        Also add test for this specific case
        
        Change-Id: Iee035eecd25ed130e78ed27041c3e56ea988ecc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141078
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-13  Miklos Vajna  <vmiklos@collabora.com>  [51500b21784792d13a7102dd2485787bac3ddf3e]

        pdfium: replace annot-alternate-name.patch.1 with upstreamed version
        
        Also backport an other patch that will allow testing date form widgets.
        
        Change-Id: I622c847a6139c69ec36a6d40e05b272d11f0119d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141270
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-13  Justin Luth  <justin.luth@collabora.com>  [3aebb45d18116926dc8edb268c205c6f4ff06f05]

        sw vba: tie WordBasic to VBAGlobals
        
        This allows WordBasic to also be run directly,
        instead of only working with Application.WordBasic.*.
        
        Change-Id: I60c3beaa1fce9a8bf25786cc0b2ed6ef6deda2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141200
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-13  Justin Luth  <justin.luth@collabora.com>  [8ac97a8cb4f5657b7601f30fc9ca6b0cecc1e429]

        sw vba: move SwWordBasic to its own file
        
        We had implemented Application.WordBasic.*,
        but it can also run as a global WordBasic.*.
        
        This patch just separates it from vbaapplication.
        It was just a copy/paste, and then I ran
        opt/lo/bin/clang-format -i on the new files
        and did some minor cleanup.
        
        I just guessed at the includes I needed,
        and then commented the remaining ones out
        one by one to verifiy they were needed to compile.
        Not very scientific, but I don't know any other way.
        (running \bin\find-unneedded-includes afterwards
         didn't show anything - perhaps that would have helped.)
        
        A followup patch will add the VBAGlobal connection.
        
        Change-Id: Id29ee582a5ed6186150bb41a1ab98d6c466676e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141199
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-13  Regina Henschel  <rb.henschel@t-online.de>  [e4515c1305e4b7bf6e7f105636e9cf6eb50b382d]

        tdf#149840 Use actual outer size for SmartArt in Writer
        
        SmartArt import needs the outer size of the diagram for to define a
        background shape in the correct size and calculate the size of the
        diagram shapes relative to the outer size. The patch passes the values
        read from wp:extent in writerfilter to DiagramGraphicDataContext in oox.
        
        Change-Id: Ib39227bc645ac353336bab2c558d041974188f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141223
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9e0dcfbaf0039d07609ed4e4a9ef9f1e2e1e6b55]

        tdf#151385 Only trigger mnemonics in dialogs when alt key is pressed
        
        Change-Id: I884afad38c64bd53fe4917418ed627f9c0674554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141022
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-10-13  Mike Kaganski  <mike.kaganski@collabora.com>  [af2879e434fa0dc6b2a626617ed865e4f66eb5ad]

        Deduplicate stringconcat more
        
        In the process, drop ToStringHelper::allowO(U)StringConcat, because
        we can deduce this information from ToStringHelper's addData itself.
        To do that, addData was converted to ToStringHelper::operator(),
        which allows to use std::is_invocable_v on the helper class.
        
        Change-Id: Ic77878ca0ff65ada8c0a942191bc11de15b9ad2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141254
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b3869749719288e6d1951030f07dc3fbccc0c222]

        tdf#151087 elementary:Grouped n Ungrouped Columns/Rows
        
        Change-Id: I25ada781c5308a8ea89ba98d2e021f7b50c13c67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141190
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [aca7edb4ca7fd58c50a6b64b472e80f2eb053fd5]

        tdf#151087 Sifr:+Grouped n Ungrouped Columns/Rows, Breeze: Revise it
        
        Change-Id: I6f1e72ec38414961cf5e3d41baf6b1448ab0aa95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141276
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa39cf137ded385b463b071f6e785f2cf3093a22]

        sc: remove duplicated test
        
        This is already well covered by Test::testAutoFill in
        sc/qa/unit/ucalc.cxx
        
        Change-Id: I5d539de101e1b4dcd19191ac40d2bc0734475889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141272
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [be1a43651fb1da5872d4501b409d2811f142c525]

        sc: move UItest to CppUnittest
        
        Change-Id: I6543994abe337041de5a1aab16a5a49105aacfbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141271
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b7356e57fbf28a62f10476cebbd45ee369fde17]

        tdf#151460: sc_ucalc: Add unittest
        
        Change-Id: Ib0c8d09da50a09b2715a946a1955eb5a09d83d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141269
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [2a1ea77eebed14c86b170c0845f0eb5330fd6a0c]

        sc: qa: avoid OUStringChar for better readability
        
        Change-Id: Idf730e05d2ebec9003a2a4700b43b8658d858b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141265
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-12  jsala  <javier.salamanca.munoz@gmail.com>  [b26793b907ce823e5cce38f6fe93b420ebe38579]

        tdf#147021 REVERT Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Reverting this changes made by error.
        See https://gerrit.libreoffice.org/c/core/+/136263/6/compilerplugins/clang/test/constvars.cxx#25
        
        Change-Id: Ica49759682adf55a1f0cef2a842acab603c62dac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141259
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-10-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [369c7d2dc4b941d5b7699b03a3cfc03ad0e3b430]

        tdf#60673: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: Ia36507483e5dc325431b17e9374882ae8102bfb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141263
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-12  Jean-Pierre Ledure  <jp@ledure.be>  [55477bf4fd3baa99f8b5d5686091d7613a1022c3]

        ScriptForge - (SF_Dialog) new SetPageManager method
        
        The SetPageManager() method
        
        Define how the dialog displays pages.
        The page manager is an alternative to the direct use
        of the Page property of the dialog and dialogcontrol objects.
        
        The arguments define which controls are involved
        in the orchestration of the displayed pages.
        Possible options:
            - select a value in a list- or combobox
            - select an item in a group of radio buttons
            - select a button linked to a page
              placed side-by-side the buttons can simulate a tabbed interface
            - press a NEXT or BACK button like in many wizards
        Those options may be combined.
        The control updates will be synchronized.
        The method will set the actual page number to 1.
        Afterwards the Page property may be used to display any other page
        
        The SetPageManager() method is to be run
        only once and before the Execute() statement.
        If invoked several times, subsequent calls will be ignored.
        The method will define new listeners
        on the concerned controls, addressing generic routines.
        The corresponding events will be fired during the dialog execution.
        Preset events (in the Basic IDE) will be preserved
        and executed immediately AFTER the page change.
        The listeners will be removed at dialog termination.
        
        The implementation has next parts:
        1. Store the arguments in the Dialog instance
        2. Set appropriate listeners on involved controls
        3. Page change synchronizes the values in the involved controls
           (be it by user code or by page manager)
        4. Events triggered by listeners change page number
        
        The method is available both in Basic and Python contexts.
        This commit require the Dialog help page to be updated.
        
        Change-Id: I00a0212414f283102c73de4ceb488aa1aeddf746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141257
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [d6a5431b5ef369823e4438a34767bf6c234eb231]

        use WindowTextColor as the fg for high contrast
        
        No platform sets TextColor away from its default of black and we're
        using WindowColor as the bg for high contrast, so we need to use
        something suitable for use on WindowColor. MSDN docs state
        COLOR_WINDOWTEXT for HighContrast if using COLOR_WINDOW.
        
        Change-Id: Icdd3cf6d76da7eb544f08619717689b44ab1fd38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141247
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-12  Mert Tumer  <mert.tumer@collabora.com>  [e20d2de7836da52dbf9e528d1043b1e188097bfd]

        new uno command uno:Translate with deepl api
        
        New Uno command added for translation
        right now it is only using deepl translation api
        
        There's a section in the options > language settings
        for setting up the api url and auth key
        
        uno:Translate is a menu button under Format tab
        which will bring up Language Selection dialog for translation.
        
        DeepL can accept html as the input for translation, this new
        feature leverages that by exporting paragraphs/selections to
        html and paste them back without losing the formatting (in theory)
        This works good in general but we may lose formatting in very complex
        styled sentences.
        
        Translation works in two ways;
        1) Whole document
        when there is no selection, it assumes that we want to translate whole
        document. Each paragraphs is sent one by one so that the output timeout
        can be minimum for each paragraph.
        2) Selection
        
        Change-Id: Ia2d3ab2f6757faf565b939e1d670a7dedac33390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140624
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-12  Stephan Bergmann  <sbergman@redhat.com>  [d75f27fd738eeb2c7dc6d22f198d55d3a877aa0b]

        Fix apparently-dangling pointer
        
        After 001de7e21d29fccff904fe23de05afd68922fe2e, CppunitTest_sw_ww8export
        CPPUNIT_TEST_NAME=testTdf94386::TestBody started to fail with
        
        > svl/source/items/itemset.cxx:176:42: runtime error: member call on address 0x60400083cbd0 which does not point to an object of type 'SfxItemPool'
        > 0x60400083cbd0: note: object has invalid vptr
        >  00 00 00 00  b0 6e 02 00 00 00 00 00  00 00 00 00 be be be be  40 44 b1 05 e1 7f 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               invalid vptr
        >  #0 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:176:42
        >  #1 in testTdf94386::TestBody() at sw/qa/extras/ww8export/ww8export.cxx:1555:1
        
        Change-Id: I6dff915866a4e7d1250b253e53061e5646aebf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141253
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-12  Noel Grandin  <noelgrandin@gmail.com>  [1d76a3dfea5d842d99447e094a3c1c1f9249335b]

        this adjust not necessary
        
        rPaM's nNode and nContent is already kept in sync here
        
        Change-Id: Ic79bcf8f950767885e117848475ccbebc4f6537e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141251
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-12  Justin Luth  <justin.luth@collabora.com>  [1e0306be6c3a3bc50f11e7c7814aa8a029f8928d]

        tdf#148806 vba: IsCompiled is required for SbxFlagBits::Private
        
        Two step approach:
        -putting this here where I need it - fairly targeted.
        -put it in FindMethod before returning,
         so that everything gets it in a valid state.
        
        Of course the second will probably cause consternations,
        but then when it gets reverted at least this will still work.
        
        Change-Id: I8772f85c9b9ae6ed9a25ba7966b50519afe0d6ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141243
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-12  Miklos Vajna  <vmiklos@collabora.com>  [b138d6c12aaeb0b87dce15ea52dd134cf1abf6ac]

        tdf#151190 sw content controls: make them read-write in protected sections
        
        When the user picked a date in the date picker inside a protected
        section, then we blocked the deletion of the placeholder, but allowed
        insertion to the content control, which is inconsistent.
        
        The trouble was that SwPaM::HasReadonlySel() detected that the cursor is
        in a protected section, so deletion failed, leading to an ever growing
        value of the content control.
        
        Fix the problem by handling content controls similar to legacy form
        fields: if the cursor is inside a content control, then that value is
        editable, even if we're inside a protected section.
        
        This is meant to fix all content control types, not just date pickers.
        
        Change-Id: I9eca4c4f71dcfaa61d84414f7727adcd4496735c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141249
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [cd79fbd624679f68662177fa25ebdfeaf7b2d3be]

        cid#1515941 Dereference null return value
        
        Change-Id: Id6b191482c70a95d861ba771925570bc5992f534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141250
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-12  Noel Grandin  <noelgrandin@gmail.com>  [2e78c92dfeefc301b1cc69130433917c3e77bfdc]

        use unique_ptr for SystemFontList, fix leak
        
        Using unique_ptr here fixes a leak, which in turn was hiding
        the fact that we don't manage the lifecycle of CTFontDescriptor
        in CoreTextFontFace properly
        
        Change-Id: I2ade5fae9a40ad0ebb10538488018941f3f285c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0f2bec39d5d90ec7f0879e57ff5b23d671bf8489]

        tdf#151071 Revise Sifr (Update color to follow symbolic Adwaita)
        
        Change-Id: I70aa82598f68492ebdfcd26f51858471c0a53f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141245
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-12  Noel Grandin  <noelgrandin@gmail.com>  [7aa0d01818e6934d1bbb361b750a91204251b465]

        rearrange node logic here
        
        so we don't have to touch SwPosition.nContent.
        
        Part of the process of hiding the internals of SwPosition
        
        Change-Id: I797eec2b4ccb01360602f2f19ae4a7a51fe712fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [950b2712e78e4c5015aff3762d78558be8a642bd]

        tdf#150622 use a solid border instead of a hatch for high contrast
        
        to do less work for smoother scrolling, etc.
        
        Change-Id: I6584bbb18247420d9926bfa90acfbd6afe536c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-12  Noel Grandin  <noelgrandin@gmail.com>  [7ad22252171f1e8c0ad65f0b9f8e38024f1e1bde]

        try to make CppunitTest_embeddedobj_msole more reliable
        
        It sometimes crashes on windows. Switch to using the same
        tearDown() logic as UnoApiTest::closeDocument, which
        seems to be the most reliable variant of this kind of code.
        
        Change-Id: I1493d6d265763b2aec4ee94f4ee66378dbe280b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141238
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-12  László Németh  <nemeth@numbertext.org>  [0140fd6501c2322cffddaaa14b49137009ffcae4]

        tdf#151478 sw: fix row/column selection at nested table
        
        Table->Select->Row (.uno:EntireRow) and
        Table->Select->Column (.uno:EntireColumn) didn't
        work, when the last cell of the row or column starts
        with a nested table.
        
        Change-Id: I31e2fdebb226911921fb727f58c03101c01a07b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141224
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [5f88c66b835718c5cc5f07d21825a5ac6880e458]

        vcl: extract function CreateAnimationDataItems
        
        Change-Id: Ifc245b570d82d2fcbcd2cbb83cbd43664b228bf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76409
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [ff7dd118bdc5d017d2dec28a4e37c3e3a6b97660]

        vcl: Animation does not need to be friend of AnimationRenderer
        
        Change-Id: I76441d55d62b63d380417554cd236e7e3cf882e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76408
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [06423ddc61a378894c91a6a23fb31afb1701d8f2]

        crashtesting: exception during dtor
        
        Change-Id: I9874778ba79540cfde32bf59c3a63ebb72889dc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141215
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [56b8703d6f759326f7ac1a84ca0e6d1c9b40aad7]

        assert from SfxItemSet::CloneAsValue with SfxAllItemSet
        
        in writer with insert, shape, add some text, change its
        text color.
        
        so like:
        
        commit fe2ec505786bacc6f3baca3292367903644ac99b
        Date:   Fri Feb 18 10:56:56 2022 +0200
        
            improve the SfxItemSet::CloneAsValue check
        
            to prevent object slicing.
        
        revert the asserting hunk.
        
        Change-Id: Iea2b118a9072eccf930c61eb85c1684149aa9e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141168
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-12  Miklos Vajna  <vmiklos@collabora.com>  [001de7e21d29fccff904fe23de05afd68922fe2e]

        CppunitTest_sw_ww8export: remove not needed mustTestImportOf()
        
        Which means postLoad() can go as well.
        
        Change-Id: I6c4a25ccd13118156c1bc2d0306db30a18af5b88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141236
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [575ff25cc338a35821e9dcea2d77ad6e85aa1407]

        Fix typo
        
        Change-Id: I4d8dbdf6752ec06f1a7047a89776d719d15742b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141240
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-12  Justin Luth  <justin.luth@collabora.com>  [73911ed8d35294a9e15771d8aaa1e9121ef10309]

        tdf#148806 doc vba: highest priority is ThisDocument AutoOpen V2
        
        A review by Stephan Bergmann made me re-think adding a separate
        event for this. It really is only one event and not two
        (or three as I initially imagined). In the end, I like this better
        because it highlights the difference between Excel and Word
        by keeping all the differentiating logic in one place.
        
        The inability to properly document the purpose of these new events
        was the impetus to redesign this. Thanks Stephan for the prompt.
        
        Change-Id: Ic2d461c13c4a52e279224cb485d2b6c4a3c57b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141233
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-12  Caolán McNamara  <caolanm@redhat.com>  [f518928c322d45cdec4163c0182b0008da0da729]

        only interested in genuinely bizarely thick lines
        
        Change-Id: I107a46cc11127910f28977b88152c41e8b6c6467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-11  Stephan Bergmann  <sbergman@redhat.com>  [8815ae462f32915209c838688b7cc86f57e280d4]

        loplugin:unreffun
        
        ...after the last use of that RawFontData got removed in
        112d07027c4484dd571519911596d11eae897524 "vcl: Use
        PhysicalFontFace::GetRawFontData() for font embedding"
        
        Change-Id: Id85eb39b6fd946da132d53ba937032f3c58b061d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141225
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-11  Laurent BP  <laurent.balland-poirier@laposte.net>  [7d698d505bf7b68d993c9c2246ab517e60106348]

        tdf#143956 Convert all Wizards template to XML
        
        All templates used by Wizards are now built from their XML
        It eases maintenance
        Page size, language and country attributes were removed
        
        Merge all wizard/package in one file
        
        Change-Id: I32193b2ff4c6a1b31934e6ed4e08d56801e5662e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137159
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2022-10-11  Justin Luth  <justin.luth@collabora.com>  [ffc15725b58d0988b4e2ed836c5751223ad00984]

        tdf#148806 tdf#151393 xls vba: no Auto_Open from ThisWorksheet
        
        Unlike Word, ThisWorksheet cannot hold auto-running
        subroutines for Open/Close/New.
        
        This fixes a LO 7.4 regression caused by
        commit beb6c62e990599d91ac5d9183164c94d269027d3.
        
        Change-Id: Idb8f72775d9392b306cb924ee776821272b12f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141127
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-11  Caolán McNamara  <caolanm@redhat.com>  [b320ef30977144c52de9b39bc4db0db540727c79]

        vml whitespace-check mangled Částečně to ste n
        
        Change-Id: Ib77ca39a5e17c7fb27c8d5204120fb261b885f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141228
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-11  Caolán McNamara  <caolanm@redhat.com>  [2241ce64b29e87e0c654ab529b71aa98f71b4a14]

        use std::unique_ptr
        
        Change-Id: Ibb3d71c8d50e1ad7236a6fe01ff83d3cd1a866f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [a6ec933d0fe2150a6b83cd54a0de30b252c9a600]

        tdf#91305 related: Drop redundant only-one-column/row check
        
        This check was introduced in commit 4cd9e45a439b654c8e1ff7983fe7e4bd073b9c92
          Author Yan Pashkovsky <yanp.bugz@gmail.com>
          Date   Fri Aug 12 23:39:30 2016 +0300
            tdf#91305 fix sort calc
        
        Then commit 63592999a067d76c896ed79204330e1a4b934c80
          Author Eike Rathke <erack@redhat.com>
          Date   Thu Aug 18 17:16:50 2016 +0200
            refine HasColHeader()/HasRowHeader() conditions, tdf#91305 related
        
        made the "not only one column/row" case check the same.
        
        Change-Id: I25ce867e1c64d7b89a617021de9a5e4f1c89d2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141219
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [8e39704b597fda9e3ef442252defed16a0a07b03]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I8a0de56c9e42adda71cffe8b79daca5a8e7a23a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Miklos Vajna  <vmiklos@collabora.com>  [0bd83ba4c40bd7c3ebd3f098421c23bc9ced7b9e]

        tdf#151470 svtools: prevent storing broken graphic of embedded objects
        
        Updating the preview of the embedded PDF object in the bugdoc leads to
        Acrobat generating a new preview, we throw away the old one, write the
        new one to the document, and next time the document is opened, we can't
        parse it, so the preview is lost for the user.
        
        The reason for this seems to be that sometimes Acrobat generates a
        broken WMF: the first 4 bytes is 0x0002 (DISKMETAFILE from the
        MetafileType enum), but the next 4 bytes is 0x6f43, which means that the
        header size is 56966 bytes long, but the whole preview is 29291, so this
        WMF looks broken.
        
        Fix the problem by adding error handling before we insert the WMF we get
        from Acrobat as a graphic stream to the document storage: don't update
        the graphic stream if the data is something that can't be handled by
        VCL's graphic filters. svt::EmbeddedObjectRef::GetReplacement() has a
        similar error handling, which is why the preview only gets broken on
        document reload.
        
        No testcase, this only happens on Windows and only in case a problematic
        handler for PDF is installed, which is hard to test from 'make check'.
        
        Change-Id: I9e1ce979e58a155fa5e72e31cd9ea38258bb8b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141229
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [ce9273e72f31ac3834fc6cf13f6dccc341d5fb8e]

        avoid accessing SwPosition.nContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I3a32cc601983313c29805603b1c0aa3f990d6b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [5f986951c92f6314fa05f87164c48fd51f20d501]

        avoid accessing SwPosition.nContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ie6bc1822ac2a4e5c601ba2a94a0d287fdf989c19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [429e327d14aaaa3a913b93b5788129b33bd26a43]

        use more string_view in sd
        
        Change-Id: Iafcab8d5b21f9562838c3494cbfd75090dd6e010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141152
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [86a80403c68d433b81b8d8a35b2e71fb9f8cd3d6]

        tdf#150222: Use static_assert to check contiguous item ids
        
        Similar to 5e29b084eb0bfcfbc82622df5c445a6148531989
        "tdf#151260, tdf#84930: Use static_assert to check contiguous item ids"
        
        Change-Id: I02836514b6904b79a16c2cd82200b9038d566731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141226
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [95933b725ff4f8f909fa5520f3e7fe0215715edb]

        no need to touch nContent here
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I15ed83739b12aebe7c7cd7fbdd528fa0cd282582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Justin Luth  <justin.luth@collabora.com>  [195cb01573cbc92545cbc84cbb7dd09bbb4ae692]

        tdf#148806 fix build for !HAVE_FEATURE_SCRIPTING
        
        I noticed this on one function, but completely
        missed it on the second one.
        
        Change-Id: I6ca74485b0c40cec2b04003fe894159198186ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141220
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [99f89d40f7ca7e26f683a75f62a2cb7fe30459ad]

        revert pessimization
        
        revert part of
            commit 113d9bba057b2fd634fcfcebb83a4d92cf41d69f
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Sep 30 09:06:51 2022 +0200
            use more string_view in stoc
        
        <sberg> This is another case of a potential pessimization, for no
        gain: The passed in schemeSpecificPart will always be an
        OUString, and path may be a view of its full content
        (if there is neither authority nor query part).
        
        Change-Id: Ibc60fb1f5f351668ef924e25ee3aeb1d80f6f710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4b4160cb1aab3ab1ff8eec6b2736bf459afed408]

        tdf#151016 Fix paint hamburger icons in Start Center (Sukapura)
        
        Change-Id: Ibe49b50f23a560ad2635d835d4e204a5efd06439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141209
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-11  Stephan Bergmann  <sbergman@redhat.com>  [a3351e6bf7f637632cc436071da2619841fb8287]

        Avoid UBSan invalid-null-argument
        
        ...as seen at least with --without-latest-c++ after
        d0b2f5f65e80a4262425bb87d5716d7b4341dfea "pdfium: drop not needed annot.patch.1"
        during CppunitTest_sw_core_text,
        
        > workdir/UnpackedTarball/pdfium/core/fxcrt/string_data_template.cpp:76:20: runtime error: null pointer passed as argument 2, which is declared to never be null
        > /usr/include/string.h:44:28: note: nonnull attribute specified here
        >  #0 in fxcrt::StringDataTemplate<char>::CopyContents(char const*, unsigned long) at workdir/UnpackedTarball/pdfium/core/fxcrt/string_data_template.cpp:76:3
        >  #1 in fxcrt::ByteString::ByteString(fxcrt::StringViewTemplate<char>, fxcrt::StringViewTemplate<char>) at workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.cpp:160:12
        >  #2 in fxcrt::operator+(fxcrt::ByteString const&, fxcrt::ByteString const&) at workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:265:10
        >  #3 in CPDFSDK_AppStream::SetAsTextField(absl::optional<fxcrt::WideString>) at workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_appstream.cpp:1805:34
        >  #4 in CPDFSDK_Widget::ResetAppearance(absl::optional<fxcrt::WideString>, CPDFSDK_Widget::ValueChanged) at workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_widget.cpp:655:17
        >  #5 in CPDFSDK_PageView::NewAnnot(CPDF_Annot*) at workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_pageview.cpp:108:12
        >  #6 in CPDFSDK_PageView::LoadFXAnnots() at workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_pageview.cpp:566:45
        >  #7 in CPDFSDK_FormFillEnvironment::GetOrCreatePageView(IPDF_Page*) at workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_formfillenvironment.cpp:625:14
        >  #8 in (anonymous namespace)::FormHandleToPageView(fpdf_form_handle_t__*, fpdf_page_t__*) at workdir/UnpackedTarball/pdfium/fpdfsdk/fpdf_formfill.cpp:169:39
        >  #9 in FORM_OnAfterLoadPage at workdir/UnpackedTarball/pdfium/fpdfsdk/fpdf_formfill.cpp:730:37
        >  #10 in vcl::pdf::(anonymous namespace)::PDFiumPageImpl::onAfterLoadPage(vcl::pdf::PDFiumDocument*) at vcl/source/pdf/PDFiumLibrary.cxx:764:5
        >  #11 in testContentControlPDFFont::TestBody() at sw/qa/core/text/text.cxx:746:12
        
        Change-Id: Iba73a9401eb10a8c03843dba038cd3a6eeeb0c4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141210
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [e61fc957f199930728854831b0223ee192054d50]

        escapeWith is just a substitution for OUString::replaceAll
        
        Change-Id: Ib0b84826a47474f58fa87ed4e1ca1d16c89e1620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141217
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-11  Eike Rathke  <erack@redhat.com>  [abd42a63f65f810c821085149c095682247e0d0d]

        Resolves: tdf#151460 Scale and round time diff fiddling with floating point
        
        Change-Id: I5cf4e16692d55f30cc06723a323b4cd0408aaab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141216
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e35decf9b854c29ca02b2a73dac10340ab687b44]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 43fb18e490c07701e9deb334c0086b03e8b2dbf2
          - Add Upper/Lower Sorbian Help
            
            Change-Id: I084e96a5b25e704cdbb95a3100fa1e1fa30ddd05
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141218
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3d236177be255b2027a997bfc12fe0833ca9a2f7]

        Deduplicate O(U)StringConcatenation
        
        And use an overloaded helper function with a better (?) unified name
        to show that the result is not an O(U)String.
        
        Change-Id: I8956338b05d02bf46a6185828130ea8ef145d46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141203
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [6c65c62c26a8aa4d04466545f8f04ec86b797012]

        Don't convert OUString to char* to get OUString in the end
        
        Which by the way fixes the mismatch between converting _sAppName to
        OString as UTF-8 in SplashScreen::SetScreenBitmap, and converting
        pName to OUString as ASCII in Application::LoadBrandBitmap.
        
        Change-Id: I2082f92693ca9633b64411dd668befaa30e978d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141202
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [f761e0aee58fe152b69daaa0e4b9697ad4f0e038]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I7685584b4f3b2c1f595146e87f8644f6d8feb1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [77d7f0b6a5e796a77b4b98869e3fe5dd09e860f9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 91c56d486085c7a08ce05241bbf617a05932318f
          - Turn conditional formatting help pages more friendly
            
            Change-Id: I6511663d80942720c5b9f1053e611f1f5209968c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141159
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-11  Noel Grandin  <noelgrandin@gmail.com>  [c9d5f33a46b5156aec94ea4eaa8f1a4fa20aa936]

        use more SwPosition::GetNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ib1a3a5bf1f3f875bbb02df523cbfd9c13b12c60e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141165
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Stephan Bergmann  <sbergman@redhat.com>  [d0f3e24a7a34aac41e0b433d45c657b136ff8fe0]

        loplugin:loopvartoosmall
        
        > /Users/stephan/lo/core/vcl/quartz/ctfonts.cxx:255:33: error: loop index type 'unsigned int' is narrower than length type 'CFIndex' (aka 'long') [loplugin:loopvartoosmall]
        >             for (auto i = 0u; i < nTags; i++)
        >                               ~~^~~~~~~
        
        (and whatever the motivation in d7083fe6dd383ac4144fbe53e300bc3d34f26ef6
        "tdf#72456: Support font embedding on macOS" to use an unsigned 0u here)
        
        Change-Id: I6a96dd2b2146c27d68a8a53daf3c2fe1f744738d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141201
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: Jenkins

2022-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [71337b4327805b73e92c995153c5746d89793b13]

        use more string_view in sw
        
        Change-Id: Ibefb8549834ba5011286e3221f1ae276e2c0c0bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-11  Miklos Vajna  <vmiklos@collabora.com>  [bab44a97d21d0ac8a8a06678e71024c1a830943f]

        tdf#151060 sw PDF export: don't paint off-page part of drawing object
        
        Reported to be a regression from
        c12358166a9bd88fe10feabca45a6ad3f65dff8e (DOCX import: fix lost objects
        anchored to an empty linked header, 2020-01-10), the 3rd page of the PDF
        export result contains an unexpected line shape.
        
        This was "working" before as all objects anchored to the empty header
        were lost.
        
        Fix the problem by clipping the rendering to the page frame when
        handling shapes, similar to what
        689cead9e0837dc932e3a4cd765f7d319b529018 (tdf#91260 svx, sw: don't paint
        off-page part of drawing object, 2016-12-06) did to fix the normal
        rendering of the document.
        
        The testcase document just has 2 pages, so there the unexpected shape
        was on the 2nd page.
        
        Change-Id: Ica24cd15717a1ee97dff448d385a10536671103e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141167
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f486d2220d5b51f422c8feca21c831e1c1d143d7]

        tdf#151071 Revise Sifr (Impress display view, slide layout & transition)
        
        Change-Id: I9319f95d064475f5073c6de39901686c90592a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141198
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-11  Justin Luth  <justin.luth@collabora.com>  [eaa38b0f9d672793af500222348a6cacd28910b0]

        tdf#148806 doc vba: only autoOpen PUBLIC macros
        
        Note: this should NOT apply to Document_Open which normally
        is a private subroutine and runs fine as private.
        
        I tested and it DOES apply to all three version of AutoOpen:
        -ThisDocument.AutoOpen,
        -<AnyModule>.AutoOpen,
        -AutoOpen.Main
        
        Note: this is different from Excel.
        Private Auto_Open runs just fine there.
        
        Change-Id: If10c8c90c35275c2b14dc2e15fb357674fc580b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141114
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [ebeb4ce43d04dbbd329f19210c0db86e2b1cf2a0]

        Use correct color in cuicharmap.cxx
        
        While fixing bug tdf#151232 (commited as 3e4697c7675430f5e4e2221c951971caee0bdeb8) I used the wrong color in cuicharmap.
        
        This patch fixes this error.
        
        Change-Id: I1435489424c5a2e343ab009852e51267cbc8eb01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141175
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-10-10  Caolán McNamara  <caolanm@redhat.com>  [d58dcdae6f6f2367a6713ba7a109923a9c239b12]

        attempting to load "1920x1080" not "intro_1920x1080"
        
        since...
        
        commit ff953c36ac8f335d6f12d9e22a29deafe90de34d
        Date:   Mon Oct 11 11:50:10 2010 +0100
        
            clean cut/paste brand location code
        
        Change-Id: I727a3698d70c3516dbdfa337e3ebf418a65f965b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141156
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-10  Hossein  <hossein@libreoffice.org>  [d1707bc31261d16893c1f5240c803d283e293ec1]

        tdf#149718 Fix crash on insert chart for tables with merged cells
        
        Previously inserting charts for tables with merged cells lead to crash.
        This was because a wrong assumption in unochart.cxx, specifically
        SwChartDataProvider::Impl_createDataSource() that every row has the same
        number of columns. Therefore the code was using the number of columns in
        the first row as the number of columns for all the rows, which is wrong.
        
        For example, inserting a chart for the second column of this table leads
        to a crash:
        
            [                      ]
            [    1     ][     2    ]
        
        In this way, an assertion failure was created because the number of
        columns where counted from the first row, which has merged cells, and
        therefore fewer number of columns compared to the last column of the
        selected part.
        
        To solve tdf#149718, now we use the maximum number of columns calculated
        across all the rows. In this way, the remainder of the function does not
        need a fix, although a cleanup for the whole function can be interesting
        and help avoid using tiny extra memory space.
        
        A UITest is provided to avoid this bug in the future. To run the test:
        
            cd sw && make -srj1 UITest_sw_chart \
            UITEST_TEST_NAME="tdf149718.tdf149718.test_chart_from_table_with_merged_cells" \
            SAL_USE_VCLPLUGIN=gen
        
        Change-Id: I3c1000d7f177417e98d3a8ceae7886824c1053a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140092
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-10-10  Noel Grandin  <noelgrandin@gmail.com>  [696d5c865c75c0a16f7367a9f9103684d764f75c]

        re-arrange logic to avoid touch SwPosition::nContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I43c994c5c3bcfd6e45bb14b90cd19ba4d9cddada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [5e29b084eb0bfcfbc82622df5c445a6148531989]

        tdf#151260, tdf#84930: Use static_assert to check contiguous item ids
        
        Change-Id: I9af0ad625ddb80052f7f7783061218a8de1db5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140946
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-10  Noel Grandin  <noelgrandin@collabora.co.uk>  [8b4ac8c35d5e4efe3c0b83e15543a35213e786f2]

        improve setup/teardown handling in VBAMacrosTest
        
        do the same thing that the other UnoApiTest subclasses are doing,
        seems to fix the problem for me
        
        Change-Id: I0d5288b638a5c8d6994fae5ae5d99f2f29bcf377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-10  Eike Rathke  <erack@redhat.com>  [f4d021e664f140b0c331a91e15887417d0924ee5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00a07b02f82b2177c6d1ad90168528ca9eb73be8
          - Related: tdf#43107 Clarify \n in Find and Replace
            
            Change-Id: I676879173b1c48c665402a6c677a3c94cb97c66c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141161
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-10-10  Martin Schumann  <mfs@mfs.name>  [42fe257fa4d970f58543ca40f5158c04f607bc61]

        tdf#151314 add Betterbird to Thunderbird-like mail clients in senddoc.sh
        
        Change-Id: Ie145aba936138968b31f1f89d85ad23ad937a367
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141158
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-10  Miklos Vajna  <vmiklos@collabora.com>  [f726fbc2699b05199a8dec3055710a7131e0aad6]

        tdf#151261 DOCX import: fix dropdown SDT when the item display text is missing
        
        Dropdown content controls have list items, and each list item can have a
        display text and a value. These are optional, and the bugdoc has a list
        item where the value is set, but not the display text.
        
        The trouble is that later in DomainMapper_Impl::PopSdt() we check if the
        length of the display texts and values array match and if not, then we
        throw away these arrays to avoid creating an inconsistent document
        model.
        
        Fix the problem by checking what display text and value we got at the end
        of each list item; if any of them is missing, we add an empty string,
        which matches the internal representation in SwContentControlListItem.
        
        This also helps in case these array sizes matched by accident, but
        display texts and values from different list items were mixed
        previously.
        
        Change-Id: Ib1eeabd2479963af4a84d4229d4f0ce4572e0f01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141151
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3e8bed6709e3a580445488b7e878001b2c2c6be9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0a4e56a9fa89c9a6ae13b3520b7a5f46c2793e53
          - Add Upper  and Lower Sorbian to Online Help language selector
            (part 2 is in core/ )
            
            Change-Id: Ifedec9aec069995443ff242143f80698cf454b56
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140758
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-10  Stephan Bergmann  <sbergman@redhat.com>  [68f4da7fff44c1bbb7922be536f496b38e457252]

        Adapt external/pdfium/gcc-c++20-comparison.patch to P2468R2
        
        (<https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2468r2.html> "The
        Equality Operator You Are Looking For"), as now implemented by Clang 16 trunk
        since
        <https://github.com/llvm/llvm-project/commit/38b9d313e6945804fffc654f849cfa05ba2c713d>
        "[C++20][Clang] P2468R2 The Equality Operator You Are Looking For", and which
        started to make my --with-latest-c++ build fail with
        
        > workdir/UnpackedTarball/pdfium/fpdfsdk/cpdfsdk_interactiveform.cpp:189:22: error: invalid operands to binary expression ('const CPDF_Dictionary *' and 'RetainPtr<const CPDF_Object>')
        >       if (pAnnotDict == pDict)
        >           ~~~~~~~~~~ ^  ~~~~~
        > workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:227:13: note: candidate function not viable: no known conversion from 'const CPDF_Dictionary *' to 'const char *' for 1st argument
        > inline bool operator==(const char* lhs, const ByteString& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:227:13: note: candidate function (with reversed parameter order) not viable: no known conversion from 'const CPDF_Dictionary *' to 'const ByteString' for 1st argument
        > workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:230:13: note: candidate function not viable: no known conversion from 'const CPDF_Dictionary *' to 'ByteStringView' (aka 'StringViewTemplate<char>') for 1st argument
        > inline bool operator==(ByteStringView lhs, const ByteString& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/bytestring.h:230:13: note: candidate function (with reversed parameter order) not viable: no known conversion from 'const CPDF_Dictionary *' to 'const ByteString' for 1st argument
        > workdir/UnpackedTarball/pdfium/core/fxcrt/widestring.h:285:13: note: candidate function not viable: no known conversion from 'const CPDF_Dictionary *' to 'const wchar_t *' for 1st argument
        > inline bool operator==(const wchar_t* lhs, const WideString& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/widestring.h:285:13: note: candidate function (with reversed parameter order) not viable: no known conversion from 'const CPDF_Dictionary *' to 'const WideString' for 1st argument
        > workdir/UnpackedTarball/pdfium/core/fxcrt/widestring.h:288:13: note: candidate function not viable: no known conversion from 'const CPDF_Dictionary *' to 'WideStringView' (aka 'StringViewTemplate<wchar_t>') for 1st argument
        > inline bool operator==(WideStringView lhs, const WideString& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/widestring.h:288:13: note: candidate function (with reversed parameter order) not viable: no known conversion from 'const CPDF_Dictionary *' to 'const WideString' for 1st argument
        > workdir/UnpackedTarball/pdfium/core/fxge/cfx_color.h:61:13: note: candidate function not viable: no known conversion from 'const CPDF_Dictionary *' to 'const CFX_Color' for 1st argument
        > inline bool operator==(const CFX_Color& c1, const CFX_Color& c2) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/string_view_template.h:277:13: note: candidate template ignored: could not match 'StringViewTemplate' against 'RetainPtr'
        > inline bool operator==(const T* lhs, const StringViewTemplate<T>& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/string_view_template.h:277:13: note: candidate template ignored: could not match 'const T *' against 'RetainPtr<const CPDF_Object>'
        > workdir/UnpackedTarball/pdfium/core/fxcrt/observed_ptr.h:98:13: note: candidate template ignored: could not match 'ObservedPtr' against 'RetainPtr'
        > inline bool operator==(const U* lhs, const ObservedPtr<T>& rhs) {
        >             ^
        > workdir/UnpackedTarball/pdfium/core/fxcrt/observed_ptr.h:98:13: note: candidate template ignored: could not match 'const U *' against 'RetainPtr<const CPDF_Object>'
        
        Change-Id: Ibef9e5515dc466431741220adebec9c6e20850e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141154
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ff18bb9fe16c1cd1690c7e5c25ed479aac5897f8]

        Update git submodules
        
        * Update translations from branch 'master'
          to a06c7f55db473a521b3318327ada335be99a0a0d
          - add helpcontent2 for hsb and dsb
            
            Change-Id: Ifac433cf11a7f18f68f8235f014b51951d5408f1
            
2022-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dae54fc666c8ac97445fb8470a502c92f1f5d800]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01be581e707e83a5aaefd2174dc363c1b410ec08
          - tdf#151386 - Add preferred resolution for images in file properties
            
            Change-Id: I31abed704493b6d91ab3af192b9af4926110cad7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141027
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aba47d363b8cdaea65245be2c4c06dc614401753]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44ae617cb4f7eaae3eb4b06f5a61fdb1f751e061
          - Update list of conversion filters Help page
            
            Change-Id: I04ada8ae7d8776fad8569ec655d09667c36d986e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/141157
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [302fb7e73e00e18b91b7a7bcc418e42e6e41d049]

        Update git submodules
        
        * Update translations from branch 'master'
          to df57c0c6513ed1118cc9a199c9d0f19625766e20
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I3b188be653b6e7bbd18d9c8e6d5cd1c33e0c6890
            
2022-10-10  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [8e8523018d7824aeefe654926c62b2fd49429e41]

        tdf#151071 Revise Sifr
        
        Change-Id: I47e286b1327ea8c34a11f05735bae087ced21dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141149
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-10  Miklos Vajna  <vmiklos@collabora.com>  [82c6e059c2ad864c943087704fd95fa72fc2d949]

        sw: prefix members of SwOutlineTabDialog, SwSplitTableDlg, ...
        
        ... SwTOXEntryTabPage and SwTOXSelectTabPage
        
        See tdf#94879 for motivation.
        
        Change-Id: Iecc48926c7c8dbde8a87c991edc717d04cc19332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141150
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-10  Stephan Bergmann  <sbergman@redhat.com>  [7f231cde1b54f73f2d1d9e916e4721fffa48472b]

        Missing test dependencies
        
        > warn:vcl.builder:608521:608521:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/scrollbars.ui at xmlreader/source/xmlreader.cxx:67"
        > warn:sfx.view:608521:608521:sfx2/source/view/frmload.cxx:494: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/scrollbars.ui at xmlreader/source/xmlreader.cxx:67"
        
        and
        
        > warn:vcl.builder:609394:609394:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:67"
        > warn:sfx.view:609394:609394:sfx2/source/view/frmload.cxx:494: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:67"
        
        Change-Id: I93a01404778718bbbcec1147b4716f3a7e3dedca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141148
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-10-10  Caolán McNamara  <caolanm@redhat.com>  [5f6596bd125aa8309875d970318f18d4d9704705]

        Resolves: tdf#151441 queries don't show any content
        
        Change-Id: I66ec14c7cb8816bc2181cc25f7d7f31fdc7d1604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141146
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a7683a16e98def4198e1f74a93fecdaacbf639e7]

        tdf#151071 Revise Sifr
        
        Change-Id: I2dba3af4e24f44211126b0648c921f24cb6ab3b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141144
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [221d76260096b9e6b4c4479b1b89c95af8b05774]

        simplify assignment
        
        pSttPos and pSpellArgs->pStartPos point at the same thing
        (and similarly for pEndPos), so no need to assign to them twice.
        
        Change-Id: I45a99187d07b24afa0667154e121e32557a389d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141142
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [b484e5d9e0d22b794c2d1c73741191836158a4ad]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I20842b90d0abb4435d6b06970c2545229268e5e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Aron Budea  <aron.budea@collabora.com>  [ca1378b6552251743c92a19f9ce8b3833557b548]

        "No List" option in Styles Sidebar doesn't remove list in non-English UI
        
        In a list, with Styles sidebar open and List Styles selected,
        the No List option did not remove the list if the UI language
        was other than English.
        
        No List entry exists since
        a56aa46fcc62227df7dc9a8fa04205e8ff5ed2a1 .
        
        Change-Id: I5210c07c811d08489c1b9a199f6756273153e05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141092
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [495788ceddc9b6fd6d6ef7bdbef2ed16b501ea46]

        use more SwPosition constructor
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I074f72d9bd2bac82b71cdcc7cdf165f07417dd8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [b9b184b3d4295464385df5714b8930e1a6b928da]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ibfd5e03966a96338e987b8794c49e6ac92f02153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [a46ccc36d430607f667c0672f72e9aa117a74990]

        avoid accessing nContent field of SwPosition
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I04917cb80887e82b873f5e778fd9f54f0615b38d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [8f9e625ebcb911b99316212676d9de1c02df549a]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I3b21c87b402fe0d4d0137fdb8d383a6e08189f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [dfac5bf18b5568bd60b8f85a058010b8ec8d3bf7]

        tdf#151424 Spider web chart drawing error
        
        regression from
            commit 333ccb081b4ab62adce50ca4c93162b9baf984d0
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Feb 5 14:58:07 2022 +0200
            use more concrete types in chart2, Axis
        
        Change-Id: Ib80bbec9f08b9fafa6ee1c8d0cace8b44fdadabc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [286347aec204e062e47842b7d62d734fa8513d79]

        tdf#151071 Revise Sifr
        
        Change-Id: I3415c7335697aba5f51098a981b9e083d72077fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141137
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [1a86be908952aea376d37473adbab091a5440a35]

        tdf#151417 crash in draw, activating Form controls
        
        regression from
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        
        Change-Id: I1798cead8ed72ad59799c40d0e99f3424f9e382b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Chris Sherlock  <chris.sherlock79@gmail.com>  [0d463de3adc204af6892cc2b2c2d8a698237fb0c]

        vcl: pAnimView to pRenderer (clarify variable name)
        
        Change-Id: I909aa5f3b2dd1c62d4fb1f8eb3ea0f5a2e4d7ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136434
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2022-10-09  Caolán McNamara  <caolanm@redhat.com>  [f8afeb0e026ba70a4c8544ce7443caca601552f1]

        ofz#51852 Out-of-memory
        
        Change-Id: I945bb7d7ed90e8f5f4c085b4527f1ec7a4c08eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-09  Noel Grandin  <noelgrandin@gmail.com>  [f17bd77105da8995df7a79c8978556a8848edf99]

        use more SwPosition::GetNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ia080b5bf4ca622e3bf0279ba41d8ccdd11e0be8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-09  Justin Luth  <justin.luth@collabora.com>  [d72571fdd47c627efcd0dff92fbe8a9747f92932]

        related tdf#148806 flatten filter/source/msfilter/msvbahelper.cxx
        
        I don't like mixing big formatting changes with logic changes.
        
        Change-Id: Id2dbdfd751ac86918fe39d6627aa9ce15c794323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141113
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-09  Justin Luth  <justin.luth@collabora.com>  [e2abb5bbc03cca884fa89345003d013688f0d94d]

        tdf#148806 doc vba: accept module AutoOpen.Main
        
        This is the lowest priority way of running AutoOpen,
        and it only applies to Word, not Excel.
        
        There is some code in basic/source/classes/sb.cxx
        that was somewhat finding this before it got lost in LO 7.4
        with commit beb6c62e990599d91ac5d9183164c94d269027d3.
        
        TODO: these AutoOpens should only run with a public sub,
        not a private one.
        
        Change-Id: I8a733cde13f96636942d84a0b05520692aac3e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141094
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1754b02e6acd5d0c03bdcf46151d166a07806506]

        tdf#151071 Revise Sifr
        
        - localization icons
        - Fix/revise 32px text based icons
        
        Change-Id: If57dc4413f42e9751dbc6f540e1135372f2d49f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141112
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-09  Mike Kaganski  <mike.kaganski@collabora.com>  [94df17f58fe6269452b7252b712a89978c444bec]

        tdf#151429: don't convert OUStrings to system encoding
        
        ... just to convert back to OUString in the end.
        
        Change-Id: I727d5e4c03d1a49f64bd5ca3d64157a9149cd9ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141125
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-08  Eike Rathke  <erack@redhat.com>  [8cf717efbdf8126a360f766d2c14c02cae497ac6]

        Konkani is CTL, the other unknowns are not ("Western")
        
        Change-Id: If6c9af6d4a6c7faee6231189014401314d1b1f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141124
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Eike Rathke <erack@redhat.com>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [1868dd67c97f2c30948a857e328722a296fca3e8]

        add another SwTextNode::CopyText variant
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I79c21a370918566c7d93008a62ff9843d3bfe3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [0df9418318b5f6718fd864f1755587b584d2a322]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: If1aa807be2963ab81fd535e12cc6a705186a6672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Caolán McNamara  <caolanm@redhat.com>  [d6dff5e96afc214baf11a3a41932b1432689b02e]

        tdf#124672 for hicontrast white/black bg select either Sifr vs Sifr Dark
        
        Change-Id: I63d789d90bfad9fe57ceee2011797f611a2ac8cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [2fccedec09c98d4a1c23ae831ce43db0dd936052]

        use more SwPosition::GetNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic618f4fea85dccfa31abba3efb3c0afd1994a90f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141096
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Justin Luth  <justin.luth@collabora.com>  [3d77fe0af515830001448fde0d394ef20a89002b]

        tdf#148806 doc vba: highest priority is ThisDocument AutoOpen
        
        Word has three ways of running events at doc open,
        although the two AutoOpen methods are exclusive.
        
        One is the special ThisDocument Document_open subroutine.
        
        Another is the AutoOpen subroutine, which is what this
        patch is about. It can exist in any module - first come
        first served (alphabetically) in doc - except that
        ThisDocument is checked first.
        [This is very different from Calc - which IGNORES these
        functions in ThisWorksheet.]
        //TODO: The subroutine must be public
        
        And finally, there can be an AutoOpen module with a Main subroutine.
        It is ignored if there is any AutoOpen subroutine.
        //TODO: fix the third way.
        
        I tried to create a unit test, but LO's Selection.TypeText
        always starts at position 0 for each call, unlike Word
        which also starts at position 0 for the first call,
        but then remembers where it left off.
        
        Change-Id: I4caf29eefd432c320b5acaf6210222f50a111e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141037
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [07211eda0c90d54d8993febd2af4d9811249a063]

        Simplify this code a bit
        
        Change-Id: I532784161de5f5655bca3fd8eb295bf95bb5d4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141102
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [75f24c582bce6db790d8027be3d7b8cca0289a9a]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Icb2d1017f57483b58069f0cb1347793f1d057e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [19f35314440ea1f4da57e6a6053dbe64acb4785a]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I32c0537a852a5d66f57b4dfcfd02a7c3e4cdc8dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Justin Luth  <justin.luth@collabora.com>  [21c0b368a3e7150fc5d18af5d568d5683a7a6a3a]

        tdf#148806 doc vba: AutoOpen runs before Document_Open
        
        The same is true for AutoClose and AutoNew.
        I tested in Word 2003, and DOCX with Word 2010.
        
        Change-Id: I7243573be0fee529494f1ab6031d89ec57805695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141093
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-08  Noel Grandin  <noelgrandin@gmail.com>  [50a4b5ed34b28f85f1df3be5f67266758b93c698]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I6c14e620fa5dcfac8c90a7adf942267d9970381b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-08  Jim Raykowski  <raykowj@gmail.com>  [53d5f5e15c005d95fa8c9d24d98e26afd2ca2103]

        tdf#151387 Fix regression cause by tdf#149279
        
        The gtk_tree_view_expand_to_path function not only expands all parent
        rows of path as necessary but also expands the children of the row of
        the path. This explains the difference seen between gtk3inst and
        salinst when a collapsed row is scrolled to. gtk3inst expands the
        collapsed row, salinst does not. The enhancement patch for tdf#149279
        removed the gtk_tree_view_expand_to_path function from
        gtk_tree_view_scroll_to_row. This caused a regression in the styles
        tree. To fix the regression this patch reverts the removed
        gtk_tree_view_expand_to_path functions. To make the enhancement patch
        behave the same for gtk3 and sal, the scroll to row is collapsed
        after scrolling if that was it's state before.
        
        Change-Id: I3c3975a3f258c6c432eb866a1c712299e2faf5be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141048
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-07  Justin Luth  <justin.luth@collabora.com>  [6834fda784f3066a89838cd6cda4fe945f4c7904]

        related tdf#148806 xls/x vba: no auto_open if Auto_Open module
        
        The presence of an Auto_Close module prevents any
        auto_close subroutines from running.
        
        Interestingly, Word is different. It doesn't care at all
        if such a module is present. (In fact, it uses that
        module's main() as an AutoClose if there is no
        Sub AutoClose.)
        
        Change-Id: I83a80b7f016dcf2ad3b7fd931acacb6f788241a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141036
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [4a07e9e31a6cd93958f94354a15325af098c93b8]

        use more SwPosition
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I3107ad6cb8636125ec98342ec4ed69d2c703a74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [83b6e22b37ffcd36d6030ab0c044fd7bb848f0df]

        simplify MakeOwnFrames usage
        
        the parameter is purely an "out" parameter, so unless we need the
        result, there is no need to pass anything in it.
        
        Change-Id: Ic4eda8790edb1a6cb8837fe5b6c97c9c61cc25a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [82ad6bc4e8c081bfb547ad10d29885cbdd0e8ea1]

        Related: tdf#98067 get high contrast hover/default button text color right
        
        Normal and high contrast themes seem to behave differently
        (in Windows 10)
        
        to play more directly with themes than the usual ui try:
        Press Windows Key + R and paste:
        shell:::{ED834ED6-4B5A-4bfe-8F11-A626DCB6A921} -Microsoft.Personalization\pageColorization
        
        High Contrast themes seem different to the others, with a high contrast
        theme set then its possible to customize the colors, otherwise not.
        Playing with 'Selected Text' it seems that this is the color used for
        the active/hover button text color with a high contrast theme.
        
        Change-Id: I561616fce6a6f6d781e4881bfdf8ba0abedcd75c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141051
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [e73f779f46cb709c2c7de7f0b6d217195ccb5a4f]

        set the background before setting the DrawMode
        
        so we get the document color set even in HighContrast mode
        
        Change-Id: I40a009cb473cc7e033f2be77488c081067fef69d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [4cb11d8a6682fecd661b926a417ae7f26f76e7db]

        Related: tdf#98067 do RollOver for Edit as well as SpinButton
        
        Change-Id: I058cc965a9b0d85e5491191e2ac712c01f700043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141086
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [8bc5c3bfdb5717f4bff0a513c5c2d17cd728771d]

        Related: tdf#98067 use EP_EDITBORDER_NOSCROLL for Edits
        
        which gives a border which indicates if the Edit has focus
        or not. In High Contrast Black this is a bright yellow and I see
        it in notepad and visual studio, so lets do that too.
        
        MultilineEdit left alone for now
        
        Change-Id: I6785e3cdef7d563509a3a6ea8617ab5f89602a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141085
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [c40671e082b6ece4dbd117346d9f5a3912900e54]

        use more SwPosition::GetNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I89fdef3ac8f12f88db76abe281d628f25a66536e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [aa0e536c2b09952aab729c529e81394fedeb8507]

        use more SwPosition::AdjustContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I645b620691c55c14b8f58261608ae06a9a5cffda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [911b6b413048a2161e8888803b85cf2fe45e8dd8]

        use more SwPosition::GetContentIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Idf4be99ea209c22eb0b0e1a478b93c8b2445628a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [dbee0c128b75b3ea0cb527300ebcd0ad55745fb1]

        use more unique_ptr in GetAllValidRanges
        
        Change-Id: I59f6afb5b39779a58d2b0ea47b524df299e1c0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141050
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [e5fc2a44a64afbf9058a01283be3834c21c7d12c]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I1a4ab83453a3a1750dce4ddae1f62ef896988efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141081
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Michael Stahl  <michael.stahl@allotropia.de>  [ac8717e861608031e50230015c90e64282a10ad0]

        tdf#151375 sw: ODF import: delete any layout frames before ...
        
        ... converting subtables.
        
        This avoids use-after-free by the frames or a11y code on deleted cells.
        
        For file open, there is no layout at this point, but when inserting a
        file the crash happens.
        
        (regression from commit e366c928819c44b5c253c45dca6dae40b71c9808)
        
        Change-Id: Ia2cbe548fd5cdce7ae2479bfc3dc993ebb3ce830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141080
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-07  Michael Stahl  <michael.stahl@allotropia.de>  [4757dfc2a520f63fba0b27cc161fe732231dbd0e]

        tdf#145871 sw: ODF import: don't convert subtables if outer row ...
        
        ... has fixed or min height.
        
        The code had 2 obvious problems: the fixed height on the outer row
        wasn't cleared if the inner row didn't have a fixed height, and the code
        to set lastSize on the last row erroneously set the first row's height
        as well due to sharing the row format.
        
        But it turns out that this doesn't work anyway in case any of the inner
        rows are variable sized, because without layout it's not possible to
        determine the height of these rows, and so the lastSize is going to be
        too large in many cases.
        
        (regression from commit e366c928819c44b5c253c45dca6dae40b71c9808)
        
        Change-Id: I42ac7c14236562f9cae228efc0e98dc2fa8c2a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141079
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-07  László Németh  <nemeth@numbertext.org>  [2a3e528bb9df4a1a2564ca5236be62dfdaba77e6]

        tdf#136617 DOCX import: fix empty table paragraphs with direct formatting
        
        Table paragraph styles applied on paragraphs without runs, i.e.
        on empty paragraphs, despite their direct formatting, resulting
        e.g. different font size, and after that different paragraph
        i.e. cell height, breaking the original table layout.
        
        Regression from commit bf3124cdf61b40c94ba117a76f1b63dabdfd528e
        "tdf#135187 DOCX import: fix table style at character formatting".
        
        Also clean-up commit 498d2b82187ec3ff58f076e0d15741e64c0505ba
        "tdf#131546 DOCX import: fix performance regression at tables".
        
        Change-Id: I41f8da61d49902c8c1683bd01632cce6d58aebd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141052
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [ea88911feb126f8db39ac2cc3d4fca584fcc329a]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ia1f31a54886b69b703055618641188f756a79cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141049
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [f59911c4381ca066facd0dcc6b1037077f4fc90a]

        ofz#52191 Integer-overflow
        
        Change-Id: I97daf9327c55229fe7da546164d398353e0696a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141046
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [84e9a0056967d5c641ec63bf6a4dc6c0f2798e3d]

        tdf#151076 Create callable Python script using InsertText
        
        As reported by the user, if you go to Tools - Macro - Run Macro and select the InsertText macro (under Application Macros), you'll get an error.
        
        The reason for this is that the InsertText macro is not meant to be called from the Macro Selector since it requires 1 positional argument.
        
        Therefore, this patch creates a simple callable Python macro that uses the InsertText funcion, so that this error message no longer happens.
        
        Change-Id: I63f766795bda2d2ae1b95a7c0d8110f41f9fbea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140384
        Tested-by: Jenkins
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-10-07  Andrea Rosetti  <andreamassimo03@gmail.com>  [e005259a6d4e237411c1b4adfb1b63313bcc5980]

        tdf#145538 use range based for loops
        
        Change-Id: If0cf2631d93986ed22159b4d4a049539ef9af989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140748
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-07  Miklos Vajna  <vmiklos@collabora.com>  [a70f5f141c1e6013abb4c1b3219e017b2eea40a8]

        sw content controls: emit only one PDF widget for multiple text portions
        
        If the content control's text is like "XXX<b>YYY</b>", then we used to
        create two PDF form widgets, while only one is wanted. This is
        especially annoying since the widget's width is defined by the Writer
        text, so tab portions would be a natural tool to nicely increase the
        width if wanted.
        
        The problem is that in case the content is rich text, then we break up
        that content into multiple portions, and each portion will be handled in
        SwContentControlPortion::DescribePDFControl() separately.
        
        Fix the problem by checking if the current text portion is the first one
        for a content control, handling the entire content control there and
        then silently not doing anything (no form widget, no plain text
        fallback) for the rest of the content.
        
        This also helps in case the content control has a linebreak to extend
        its height. Note that this can't be perfect in case the content control
        has multiple lines but the starting/ending line has text outside the
        content control. This is a restriction on the PDF side, since the form
        widget's area must be a rectangle.
        
        Change-Id: Ie8627faa4257d2660a733e2a28546a894548edd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141053
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-07  Michael Stahl  <michael.stahl@allotropia.de>  [98bcf50ad1e1e584d2f070693d10bf5084146eb2]

        tdf#150500 sw_fieldmarkhide: fix duplicate text frame on paste
        
        The problem is that in MakeFrames() after the 1st iteration the
        SwNode2Layout::NextFrame() on node 10 returns a SwTextFrame that was
        just created by the 1st iteration, due to a fieldmark merging the 2
        SwTextNodes.
        
        Only itreate the frames that are pre-existing.
        
        (regression from commit 2f726fa41cbd249f2fb30222b29d5f30bce52e6e)
        
        Change-Id: Iba684dfc903e1c72ca3e70a9aabf1aecf4baf32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141032
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [03fdae6565bc3e290bd7e7bb211ccdef39fc3105]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Iafd51120412e83796559694a5747c74223aa5cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [850e8823cd20476f66810c8ca5fa4c65212b8648]

        use more SwPosition::Adjust
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I77cae5313f00b283e7bb5e4f23323473fa57f252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141042
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [d71bfcd55f7ea5dcdcfbd06f89ec32454e62b7e7]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I8b39d1358462363d324959b64437355fadfcfc9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141041
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [66f33153be9d2b3571f80f975f13057391410b14]

        this assignment is unnecessary
        
        the SetMark call will already have set up the nContent field
        
        Change-Id: Ia74eeb43e5310aff1d58919970d11a400d049b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [bf12f7b4b3f6b32fe836864cd109ea7e6cd3d33f]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I7a0990c3fba08c0a8d68fa7007854457e05f0016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [0d545f1f0afc93bd568f8172a134ab9196529809]

        tdf#151370: RTF import: docvar name/value can have several sequences
        
        In case of unicode used there can be tokens, replacements, etc.
        So it is better to collect and join all received strings, not
        overwrite with just last received.
        
        Change-Id: I2b6ce465d87db4ee30987cbe0ecce1470386242f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141007
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [0cf173ff4a53618e6ddd40a278f375680d92a71f]

        vcl: test OutputDevice::GetTextBreak()
        
        Change-Id: I1618d268ca7495d4aae1bde1a43be6bcf8811869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140630
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-07  Maxim Monastirsky  <momonasmon@gmail.com>  [1a25000f91cae9f4275ec4a5c1d390fe7e52a86d]

        svx: Destroy unused table styles
        
        Loading sd document with a table, replaces the built in
        table style with the one loaded from the document. But
        the old one used to not be destroyed, because it set as
        a listener of its cell styles.
        
        Change-Id: I8ae0a553207df20233886656307bb4ad371993f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141043
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-10-07  Noel Grandin  <noelgrandin@gmail.com>  [ffbd28d9799f9d2c25b6274d9f9ef689b507cc12]

        simplify some node manipulation in SwUndoTextToTable
        
        Change-Id: I4893d17591dadc3a4cdcad26f9e04b26435f5151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-07  Jim Raykowski  <raykowj@gmail.com>  [22757917067d7c4e475228cec2a0dd4d2f900e95]

        tdf#151315 Fix char style not applied if outline-folding is enabled
        
        Making all folded content temporarily visible clobbers cursor
        selections which is the cause of the character style not applied when
        outline-folding is enabled. But it seems unnecessary to make all
        folded content temporarily visible during style application. It would
        have been nice if the author, me, had put a comment about why they
        thought it was necessary. This patch drops making all folded content
        temporarily visible during style application. If it is found to be
        required, there are ways to include it without clearing cursor
        selections.
        
        Change-Id: Iedb1d0f350d5271a211300af083bc76eb06b1326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141035
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-07  Miklos Vajna  <vmiklos@collabora.com>  [8e9fbf5cecfa3ab210a5e772c5e49b1c18a19ebe]

        CppunitTest_sw_mailmerge: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Also allows undoing the unwanted changes of commit
        5e71ec6aa0d4f9971f5e2b6f7091d18668c2f0b9 (tdf#150790 tdf#150791
        tdf#150947 tdf#150956 sw, a11y: fix visible bookmarks, 2022-09-02) to
        sw/qa/extras/mailmerge/mailmerge.cxx.
        
        Change-Id: Iab4916d8e87eab114e74b0a73903cab3ef7a759c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141033
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-07  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [be4c4c3189789c81ac8be9a15ce7e132cdf3b53b]

        tdf#151071 Revise Sifr
        
        - Distibute actions
        - Shape's Boolean operations
        - Hyperlink
        - MergeCell
        - 180 degrees rotation
        - Mirroring
        - etc
        
        Change-Id: I418feb4539fd0dc14e870042c314d73d96fe8c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141039
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-07  Caolán McNamara  <caolanm@redhat.com>  [6d724a494e37412c3fd2e5d0e5e54bda177c4108]

        tdf#98067 get menu readable in windows high contrast mode
        
        possibly a problem since:
        
        commit 9c5a22d19708eae17ad9880422bd03e81ea48c5d
        Date:   Thu Jun 21 17:55:53 2012 +0200
        
            aero toolbar: Extend the drawing of the toolbar to the menubar area.
        
        Change-Id: If76be9bf09a19992dafedf16d7e577acf1bc500d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [7cf5360ac4e70060e53a34608290cf6af7fa1ca1]

        tdf#151071 Revise Sifr
        
        Change-Id: Ic8c2f5e6d86cd11366a4f42cbc3e3f40913cae91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141012
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fe51aa0a8d796b456a3c6966c47afc98e4532cd0]

        tdf#135938 - Refresh cross-reference name after filter selection has changed
        
        Change-Id: I3e92adc10da089372637174f8551d531aea2fb13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140985
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [dcca81a4ecc0dbbb9d2f399c5a59dac0524778d2]

        Resolves: tdf#150501 borders and lines should be tearable
        
        Change-Id: I683dcf5cdf2289fde28be4990c10525fd60b88e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141031
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a05d1506038a4ca6036d6d0195278c02f51504ec]

        Fix typo
        
        Change-Id: I9bbb8b60a7056832a6526ec1f6bb9a81736381b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141030
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [68ebc8c6dd18f397af9c40f887e3397881f350cd]

        Fix typo
        
        Change-Id: I9176664cf07ae3bf1607bb91849bdd0846a8eafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141029
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-06  Eike Rathke  <erack@redhat.com>  [5d80971d8bc2027d78e1f6120bea7c388138d2d7]

        Do not use double hyphen in DTD comment to satisfy xmllint
        
        Change-Id: I0358abf107c2c80aa142627dd37819c55023be10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141028
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8eaeee05f7e0583e25282302811d73682c2f3cad]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I3f7943f2903827640bfaf21e2cc6c0c85730c7a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f3e958d7d1ee383793265d9a9e0d571fa80d64c]

        use more SwPosition::GetNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Iecac4bd1e7836022182eba7c9b6d25bb827dbe5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c98388db265e380a7e933a38c7dc616705269f03]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I8b5bf3c38c87ec5117aeeef5307bde37aed0fc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Maxim Monastirsky  <momonasmon@gmail.com>  [9080200713292a200f2c6283f9c3f438411fc7d4]

        tdf#149741 Handle also inherited direction
        
        Change-Id: I0abc381bb9895c8ec5a18ddee1071fa6d13183ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141003
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-10-06  Heiko Tietze  <tietze.heiko@gmail.com>  [27f98935f9207465186da96c85467f3c005662a6]

        [API CHANGE] Resolves tdf#131136 - Remove option "Use printer metrics"
        
        Option is out-dated and access via UI confusing
        * UI access removed from Tools > Options > General (Impress, Calc)
        resp. > Compatibility (Writer)
        * Unit tests updated
        * Tip-Of-The-Day cleaned-up
        * remove UsePrtMetrics value
        
        Change-Id: Ib645f6e1f648455e0536a437be14c2c6a7b25a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139863
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6a5214c70b82df5cef3cbac87a255c7f56b6726]

        sal_uInt16->sal_Int32 for some index vars in lcl_Highlight
        
        to match the possible length of OUString
        
        Change-Id: I561d1a7685d10fbd3b404ec91b486a9f5eb54932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141013
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [28bd6ad2318208644c13d355e91977389053170f]

        tdf#150622 sidebar icons empty in High Contrast mode
        
        Change-Id: Icfa78f0f655ee467c62cbc309b8e57ac310a73e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141021
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [21f3aebd6ea00d9cc344b46049b8097ad988401b]

        gtk4: need a SolarMutexGuard here
        
        Change-Id: Ia63e1d9f0c53df37f76a4125639084753b5e010c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141020
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [7c9bebb868cfe82dfec54f1edee199f6b4339b8f]

        Resolves: tdf#132309 adjust ui to get better tab ordering
        
        Change-Id: Ia9d6e8f57924ce1e89e54a29f559fafabfd7bb7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141011
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c252704139cb9ceb3c96aad56478cb492d053e2]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Icc684368fb8517743f45eeb9ed83e37e598ea291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Miklos Vajna  <vmiklos@collabora.com>  [e7ca10a35fd665722c67eea85e15f71c11c66248]

        SVG export: don't loose tab portions
        
        Impress slides are exported to SVG via a metafile. In case shape text
        has a string like "A\tB", that was exported as "AB", loosing the tab
        character.
        
        The relevant shape is exported as a metafile, with two text array
        metafile actions (one for "A", one for "B") and the tab needs no
        explicit action as both "A" and "B" has an explicit position. The SVG
        contained no explicit position for "B", so the tab was lost visually.
        
        Fix the problem by detecting when the doc model has a "\t" without a
        matching metafile action and emitting the explicit position in that
        case.
        
        An alternative would be to use implWriteTextPortion() to write a <tspan>
        for the tab, but that doesn't guarantee that the width of the tab in the
        SVG is the same as in Impress.
        
        Change-Id: Ie21bffce9d09194159e460fb28ab23fbefd52102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141014
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [22c66999008aec900c49e5c6caf9a14d3e4e2969]

        Related: tdf#150706 don't warn about already enabled LISTBOX_FILTER_LABEL
        
        Change-Id: I31173693145d4121735c93f2a72126e743bd0c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [bebdbf0e03a53fa981189540677d0b12fc731d08]

        resave with latest glade
        
        Change-Id: I1903e967744290806267f199e401c961d8d5b74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141009
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [3b5ebf0866ca471c9a5944d96e1190887b58c8b8]

        Resolves: tdf#150706 don't warn about user cancelling export
        
        Change-Id: Ibcc6efd8ae13d27aa66da57348efe5f06f67efb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141008
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce6babf777882d78dbf322de74f321354ac7b351]

        use more string_view in sc
        
        Change-Id: Ic7126ac57f8cc06b37f3098603f0710602f0ab28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140998
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [3c7cbaf19a5108e3870df6556c16ef25710011a2]

        Related: tdf#150706 don't warn about missing LISTBOX_FILTER_LABEL
        
        which is not unexpected for gtk where we don't use that label
        
        Change-Id: Ieed1a6498cc9f40cbf6546f996f723ec9cd3aba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141005
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [1da3406a8e97934615b5b644cbb81bf3108143ec]

        Related: tdf#150706 add OK and CANCEL to known controls
        
        which results that we can rename "Save" to "Export" in pdf export dialog
        
        Change-Id: I8186a9ea3d18bfb383b07ba54f2fd7a5cd71e7b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141004
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [81051d1fccffddf3e16d92bef0d0853a65afc8b8]

        tdf#151352 crash closing form while the tip of the day dialog is displayed
        
        Change-Id: I61826ab4d8873f82f7885e26a22d307e2d574e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [658946e0353c2fad5e26bb75f851744da4b7751f]

        Revert "android: add Grammar Checker component to native-code.py"
        
        This reverts commit f3b73cce60a440db584b5774319bba6d00bd94c0.
        
        lingucomponent_LanguageToolGrammarChecker_get_implementation is already
        listed, so it was listed twice
        
        Change-Id: I93eada023fa3cd9636abe5de5d6ecc9f50c8fd1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141000
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Miklos Vajna  <vmiklos@collabora.com>  [d0b2f5f65e80a4262425bb87d5716d7b4341dfea]

        pdfium: drop not needed annot.patch.1
        
        If FORM_OnAfterLoadPage() is called, then FPDFAnnot_GetFontSize() can do
        what we need.
        
        Change-Id: I8aa3acbbda5c040f30b28db36f8b3332115b50e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140997
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-06  Caolán McNamara  <caolanm@redhat.com>  [f8983580f67b06461b23fa34dd1bfdefbb33012a]

        Resolves: tdf#151053 Body text with dark bg not visible in Notes view
        
        this is a similar case to:
        
        commit 76a0b3170664b19c3eb66edc8fccb04dc5485387
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Fri Jan 10 16:49:19 2014 +0000
        
            Resolves: fdo#35779 set the bg color of the editeng from the text shape
        
        Change-Id: Ib7ca42426397346e5d7473b93e60f853e646a423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140995
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [1045aeecb20aeefd7f6181288853f9a89305c9ba]

        tdf#148938 Fix position arrows when dragging Calc tabs in dark mode
        
        In Calc, when you drag a tab to move it, the arrows pointing to where the tab will be positioned are always in black, even in dark mode.
        
        This patch fixes this issue.
        
        Change-Id: I9079099c5ac1a8fb767eaa105cf8863e54d0ec3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140760
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-05  Khaled Hosny  <khaled@aliftype.com>  [09c076c3f29c28497f162d3a5b7baab040725d56]

        tdf#151350: Fix extraneous gaps before marks
        
        After latest changes we no longer need HarfBuzz buffer level
        MONOTONE_CHARACTERS (which was needed to allow us to address individual
        combining marks). With the default cluster level, combining marks get
        the same cluster as their base and so we need not do any thing special.
        
        I had to update testTdf139627 because this results in using ActualText
        spans in the PDF, and PDFium support for them is lacking.
        
        Change-Id: I0011072330fdbf409c30ff781fd3beaceae400f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140994
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [7097d951e56ef241f4535514280c76ceb7f08d1e]

        I suspect the sizes are not enraged
        
        Change-Id: I2e03b49d3eb9e4123ecd75783d7b585ef9faab3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140993
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [d23b1d0240e8ca4a33fbd4fcd368c4ece7b8866a]

        Resolves: tdf#130529 reduce height of customize dialog
        
        to fit in 768px height (with default UI font size)
        
        Change-Id: I2359e39205e7c13335a7ed266dd367cf45e5dcb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140988
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [6aaeeb5a2a0cd7bc8c511c1bf7515e0943940797]

        Resolves: tdf#149277 we don't want to search the whole tree for dups
        
        just the immediate children of the supplied parent node
        
        Change-Id: I79595fd940257615f0d012cb9a4556aea51d7db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140986
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Eike Rathke  <erack@redhat.com>  [1ea19958d6fed38513b1983599c2c43ad76aae61]

        Add on-the-fly language tag to proper language list Western/Asian/Complex
        
        In which combobox wherever it was added, the correct SfxItem will
        be updated and at least when switching to another dialog tab and
        back it will appear in the correct list.
        (shouldn't tabbing out of the combobox already trigger that?)
        
        Change-Id: I5aa78797dc24527c753c97d0357c3058271fa4d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140991
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [667d61f98765dd9c5d1d8b5603c75a62dba3f795]

        update credits
        
        Change-Id: I101b0ffc043adae377c6ae4ef8741c015e5433d3

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [8b7df7b9ecf839584c74518456e5f01101eb9b5c]

        tdf#115634 recent/favorite widgets not hidpi scaled
        
        Change-Id: I65c74bd443b91827f62d46968ce8fda948fc6c26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140984
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Justin Luth  <justin.luth@collabora.com>  [d02962cb2ca4e691634abb1bf6ff30b9b366d2e3]

        tdf#148806 doc import: remove 2003 SetObjectShell(nullptr) hack
        
        This was preventing doc event-macros from round-tripping.
        Its original purpose was to "fix" doc->sxw export.
        We no longer export to sxw, and the OOo bug doc exports fine to ODT.
        
        Change-Id: I3a22db1b3bf9eaa2d64ac963f0c41892ba604e8d
        
        --- https://bz.apache.org/ooo/show_bug.cgi?id=20540 ---
        caolanm 2003-10-20 14:43:31 UTC
        Setting a target for this bug, fixed for 2.0 in
        portlaoisefilterteam16, and for 1.1.1 in droghedafilterteam15
        
        MIB->CMC:
        The document contains a Draw 4.0 OLE object, and the problem is the
        import of that object in the Word filter.
        
        During the import, the object's storage is copied into the document
        storage (in SvxMSDffManager::CreateSdrOLEFromStorage, msdffimp.cxx,
        5117). It now is contained in the document storage in the 3.o format,
        but it is not in the child list of SvPersist.
        Some time later, SvxMSDffManager::ImportGraphic calls a
        SdrOLE2Obj::SetModel, that again calls SdrOLE2Obj::Connect. This
        method notices that the object is not in the persist child list, and
        for that reasdon call SvPersist::Move to add it to the list
        (svdoole2.cxx, 374). Move converts the object into the OOo 1.0 format.
        The destination storage is the object's storage, so the 1.0 format is
        added to the existing 3.0 format, and the object storage remains an
        OLE strorage and does not get a package. This situation is not
        permitted and cannot be saved in the SXW format.
        
        Change-Id: I24e55e5d47c3a7d10d6609ddbf9cc2374a47a37b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140950
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3394e8746c505a8dae112f555cb2bb3e4596cbba]

        tdf#36383 - sc AutoFilter: fix changing row height
        
        Changing row height showed the rows hidden
        by AutoFilter, removing the result of the filtering.
        
        Change-Id: Iecc8eb03ed563de126e7a376dad41a4ab2434f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139883
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-10-05  Eike Rathke  <erack@redhat.com>  [5aa2002644d89ca452b96e664e4d28b191153538]

        More zh-* legacy
        
        Change-Id: I859bb1d100eed0d1940e31575611f34c1c308698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140982
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-05  Miklos Vajna  <vmiklos@collabora.com>  [5262aab9d220675f616579720b4bb43ee03cccfb]

        sw content controls: preserve tag
        
        This is similar to <w15:color> to preserve <w:tag>.
        
        Resolves
        <https://gerrit.libreoffice.org/c/core/+/137399/2#message-a5ba9f1e0dc9e586034758ee7c0a94e1533e8922>.
        
        Change-Id: I4fdab44aaf13ca812502ae79f38f32ec9468db11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140981
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [1490923bea9c3ec763488a73912ff0a143329a24]

        Related: tdf#151351 don't use stack/highlight bg for buttons
        
        in favor of reworked flat button default rendering
        
        Change-Id: Id1d4b773aa0bf91be0386bd9db3bb212d422f216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [f61b6a3a23303aff75051bc704375db92ae8f345]

        Resolves: tdf#151351 rework flat button rendering
        
        Change-Id: Idf98c5bb96e5646e25b1ccd70b3774c7de479d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140979
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [4006b855cc94fbd817f9c19d7361b5d6a06d152e]

        Related: tdf#151351 kf5 pressed flat toggle buttons not visually depressed
        
        Change-Id: I3ab2ec91f3317dbd5a7e011e5b81d0a5141b1348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7c1a8152889fe38d961f8f605713c44293920a28]

        tdf#122319 - Don't allow nullable form components if input is required
        
        Change-Id: I676aab37df7a98192680b87f0143a27d2a5fd3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140713
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [24f231563133ceca55cfca8f7b704db98cd2a923]

        toggle state regardless of which toggle was used
        
        Change-Id: I43c295e2cc39497dba8812f1c9e296068d07a224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Miklos Vajna  <vmiklos@collabora.com>  [481a082469802ffce08cd8c110e715260015eb97]

        sw content controls: preserve alias
        
        This is similar to <w15:color> to preserve <w:alias>.
        
        Related to
        <https://gerrit.libreoffice.org/c/core/+/137399/2#message-a5ba9f1e0dc9e586034758ee7c0a94e1533e8922>.
        
        Change-Id: I774b7204c5ca02ec6db89f5cbd3a6de6f2bf82a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140975
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-05  Eike Rathke  <erack@redhat.com>  [a10d712f7020c00a49085d55b8905caa66729d1c]

        Use SvtLanguageTableImpl::AddEntry() to determine on-the-fly ScriptType
        
        With a LanguageTag::ScriptType a language tag appears in the
        corresponding Western/Asian/Complex language list.
        
        Change-Id: Ifa7fe784ebee33990b552e8df0f5555dc98667f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140974
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-05  Eike Rathke  <erack@redhat.com>  [ecc30ac20f559e47fc4a183942d73913d615ff3f]

        Introduce unicode::getScriptClassFromLanguageTag()
        
        Change-Id: Ifb932ff2aabc5767571433627314f0b29c35c471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140953
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-05  Caolán McNamara  <caolanm@redhat.com>  [384167ab8501ba5912068c0a9673864552d119f1]

        tdf#151316 recalc what dependencies should be sensitive
        
        Change-Id: I40f78ec151c3d5901209b8587f6152ab76d04e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140976
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-05  Nalini Prasad Dash  <nalinidash@protonmail.ch>  [837d52dbc296526f65e16b458152414059abd782]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ib3b4a98560c278965a1e671171e1a84f600f09bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140948
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-10-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [379ea0bb9e4836b212e004fd93abfc8067ec8929]

        unotools: test ConvertChar::RecodeString()
        
        Change-Id: I1f82afe7e1ac57004723f67412f1a7007d107eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140938
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-10-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [bf3df0fc73fc3757d3abb94465d5bcb2106c355f]

        reportdesign: keep the constant values in a comment
        
        Similar to 07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7
        "tdf#151260: crash in SfxItemPool::SetDefaults
        (reportdesign/ReportController)"
        
        Since 9a444884c3b221c9bd7b0aa4476c160921c7fc35
        "tdf#150222 reporbuilder, set font for a text box crashes"
        
        Change-Id: I07e5808f1d74a470d7c6f73160f8335254e033fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140940
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-05  Gabor Kelemen  <kelemeng@gnome.hu>  [ca1fd7535770139044f7c1a9f7e59a082d710b6d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 0416c229fe3a2a6bc9d661a077e77264cd9d6929
          - Extend --enable-mpl-subset options effect to some dictionaries
            
            Change-Id: I09919a3dde90f986998d211fb84380497553a322
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/140936
            Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
            Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
            
2022-10-05  Miklos Vajna  <vmiklos@collabora.com>  [f6f34e71b6e30c2cab03e1762f56ca14093e7d2d]

        CppunitTest_sw_ooxmlw14export: remove not needed mustTestImportOf()
        
        All of the test cases in this suite use CPPUNIT_TEST_FIXTURE() directly,
        so this is never called.
        
        Change-Id: I709edb7f1a3fcbe9383396f9a48fba728da2a431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140952
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-05  Noel Grandin  <noelgrandin@gmail.com>  [a36173359d4614a8935e2f764acadfcf736e091c]

        tdf#151283 calc hangs when try to open XLS file
        
        regression from
            commit 258a8d133d0548c7af51f4852260e9969df288fc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            tdf#150034 very slow opening pathological chart
        
        if nNewLen is < 10, we can get stuck in an infinite loop
        because the calculation will not actually decrement nNewLen
        
        Change-Id: I98920deaa087713c44531a7f6506d1d5d32b2e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-05  Justin Luth  <justin.luth@collabora.com>  [0ab5a5ee6e7cafa0c0d3e5ffee809e6b77af3796]

        tdf#126917 menu: OpenXMLFilterSettings != Macros
        
        OpenXMLFilterSettings has nothing to do with macros,
        but was moved there in LO 6.3.
        
        In 6.2 it was placed just before Extension Manager,
        so that is where I returned it.
        
        Change-Id: Id80b5984c785dc66e66aeb3215d8f1ef8c837442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140739
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-05  Rafael Lima  <rafael.palma.lima@gmail.com>  [3e4697c7675430f5e4e2221c951971caee0bdeb8]

        tdf#151232 Fix lines in Special Characters dialog in dark mode
        
        This patch makes the lines in the Special Characters dialog visible in dark mode. The Insert Symbols widget is also fixed with this patch.
        
        Tested in gen, gtk3 and kf5.
        
        Change-Id: Id1ee21557f2a0ea4ad8b60973d3de71e4d6d5d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140759
        Tested-by: Jenkins
        Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-10-04  Khaled Hosny  <khaled@aliftype.com>  [cc038c471e96d766db404388b140364614898bf2]

        vcl: Fix thinko from recent commit
        
        From:
        
        commit 29de4d6e1afcf2ad79056e4ad4403c3d4bdda4a0
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Mon Oct 3 21:53:38 2022 +0200
        
            tdf#150665: Fix justifying spacing marks
        
        Change-Id: Ic312db0080526e66b918d6ca9edb09c6a669e449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140944
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-04  Caolán McNamara  <caolanm@redhat.com>  [ca46afebb7dc0ec4375e995fa90edccbed6c2530]

        default to 'flat' instead of '3D Look' for form controls
        
        better matches what the pdf/print output will be.
        
        Change-Id: I86869024768877f8345c4a0c320eb24d48b35f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-04  Caolán McNamara  <caolanm@redhat.com>  [ea36e0502c0bc381577cfa1b1a7fedf0f05d1d72]

        tdf#150786 use a 'standard' theme for form controls
        
        i.e. ignore system theme so we get the same results on export to pdf
        regardless of the theme (esp dark) and don't follow the system theme
        when hosted with a writer/calc/impress document (do continue to use
        system theme for StarBasic dialogs as seen in BasicIDE)
        
        Didn't reuse 'NativeWidgetLook' for this because is currently defaults
        off, while we currently do use the colors derived from the system theme
        even when this is off, its really the NWF flag to render using the
        platform theming engine
        
        Change-Id: I816d7ebaf793e5eac7bd937d44c1db0371145199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-04  Eike Rathke  <erack@redhat.com>  [437abb3abbc506c1e20c6fec8e574abfe3487842]

        Check acor_langtag for language-script fallback instead of only language
        
        A tag with script could be added for which we don't have locale
        data but for the same language in another script. Do not fall back
        to that.
        
        With that the share/autocorr/acor_zh-{CN,TW}.dat files created
        additional Asian language listbox entries
        "Chinese (Simplified, China) {zh-Hans-CN}"
        "Chinese (Traditional, Taiwan) {zh-Hant-TW}"
        because those are the canonicalized language tags.
        Prefer the known legacy zh-CN and zh-TW tags instead.
        Could also had happened with any document import.
        
        Which again revealed a flaw in the handling of mapping overrides
        where converting from a LanguageType LCID to Locale could yield a
        different mapping than from BCP47 to LCID, which in the case of
        a fallback for locale data lead to odd side effects.
        
        Change-Id: I1e2aaa8e9f99b6b3bc2c9a661215cb00bddd33d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140939
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-04  Khaled Hosny  <khaled@aliftype.com>  [71e11268569201f5dcd4dbc1e7560c4530b077fb]

        vcl: Remove holes in GlyphItemFlags and make 8-bit
        
        Change-Id: Iab83fbacab5232d34ea422183ae4bb4944686f54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140926
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-04  Kevin Suo  <suokunlong@126.com>  [244063d03117119d048376c84e22cf47c4abd250]

        Templates: Make localized names for "Simple" and "BPMN" show on the UI
        
        Currently there are 32 localized template name strings defined in:
        include/sfx2/strings.hrc. However, in sfx2/source/doc/doctempl.cxx
        only 30 were used. This makes STR_TEMPLATE_NAME31 ("Simple") and
        STR_TEMPLATE_NAME32 ("BPMN"), although already localized, not show up
        on the Template Manager UI.
        
        This patch adds these two strings in the sfx2/source/doc/doctempl.cxx,
        so that they properly show as localized strings on the UI.
        
        Change-Id: I64bb28cfe0a4d3b4b41c9114de7223014f6a3cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140785
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2022-10-04  Caolán McNamara  <caolanm@redhat.com>  [16c7ee1fb0eecba2b612731fbb1ceb510e16ea69]

        crashtesting: failure on export of ooo59560-1.sxw to rtf
        
        Change-Id: If65c5be203a877befacc0d710d98940b6504f593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140904
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-04  Khaled Hosny  <khaled@aliftype.com>  [29de4d6e1afcf2ad79056e4ad4403c3d4bdda4a0]

        tdf#150665: Fix justifying spacing marks
        
        We shouldn’t be concerned whether a character is combining mark or not,
        what we really care about is whether the font classifies it as mark
        glyph, so check for that. Furthermore, for our purposes a mark glyph
        forms a cluster with the preceding glyph, so we can use IN_CLUSTER flag
        and drop the IS_DIACRITIC flag. This fixes the big above and a few other
        issues I found myself.
        
        Remove also overzealous asserts in pdfwriter, they are long past their
        usefulness.
        
        Change-Id: I7c87868a5c5877774bb42343079cad6e89380961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140925
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-04  Caolán McNamara  <caolanm@redhat.com>  [ee7f55d3aa84435fcbdab57e0c7603129157ad5d]

        don't guess which frame will be the parent, provide it explicitly
        
        Change-Id: Iccbe0ebff35c0dc2287b785a160e80f763e6ed99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-04  Khaled Hosny  <khaled@aliftype.com>  [2cca160f8bfc4597cf0ad3aaaf0017a5210ea0ec]

        tdf#126657, tdf#145104: Don’t set language to none on defined styles
        
        Language is used for more things than spell checking (localized digits,
        accessibility, OpenType layout, and probably more).
        
        A better way is needed to disable spell checking for parts of the
        document by default while keeping the language alone, but right now I’m
        reverting these changes because they are workarounds for essentially
        cosmetic issues.
        
        This reverts the following commits:
        
        commit ca91beb9d983754a5cba9e3df1bf18295e6640a0
        Author: Vladimir Glazounov <vg@openoffice.org>
        Date:   Wed Jun 4 08:50:40 2008 +0000
        
            INTEGRATION: CWS sw30bf04 (1.51.2); FILE MERGED
            2008/05/13 07:20:17 fme 1.51.2.1: #i40133# rail: Set internet link style language to none to prevent spell checking
        
        commit 137a1d5380e310a43d36932c643e1331a94fd70d
        Author: Heiko Tietze <tietze.heiko@gmail.com>
        Date:   Mon Jul 19 16:40:50 2021 +0200
        
            Resolves tdf#143066 - Language set to None for indices
        
        Change-Id: Idc9455f3f04e661bd00a9829dd0f0916844dc8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140902
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [07caa3c6e9b6b554ed0989fb5a3b8aefedeb25a6]

        tdf#151071 Revise Sifr
        
        Change-Id: I7b4565cfda7d6d3cae218eba381f9bf6ec6f8b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140935
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-04  Miklos Vajna  <vmiklos@collabora.com>  [3aff88ae021c571b6e218f6e2a0f62728bb86394]

        tdf#151094 ODT export: fix crash when linked paragraph style is deleted
        
        If a document contains a linked paragraph-character style pair and the
        paragraph style gets deleted, we crash on save.
        
        Commit 3227975c0f42ff23d528f5ab94b4538c8af764c (sw: paragraph styles:
        add doc model & UNO API for a linked character style, 2021-09-24) added
        support for linked para/char styles, but it failed to get the lifecycle
        correctly when it comes to deleting these styles.
        
        Fix the dangling para/char style references by explicitly looking what
        styles may refer to us and clear their references.
        
        An alternative would be to clear the "link" pointer of our own "link"
        pointer only, but broken documents may e.g. link multiple paragraph
        styles to a single character style, so this is probably not enough.
        
        Change-Id: I9465d43e90cf54c3c02bffda3e7c75b52c543a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140930
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4a2a94d3f41bfcf13ca96027e0bb266a429a56c7]

        tdf#151071 Revise Sifr
        
        Change-Id: I526d1d55744bf27c2e0a83118b6a6517efb8e99f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140934
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-04  Justin Luth  <jluth@mail.com>  [55ee3ede2bb0211e895053ed3a54bb1c99cc94ca]

        tdf#139480 sc: Un/Track changes now marks spreadsheet as unsaved
        
        It makes it consistent with SW, which is why I went ahead
        with this without asking any questions.
        
        Change-Id: Ibb8f4149bfb3bd785c35772d0ff399f60c0d1c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140933
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-04  Justin Luth  <jluth@mail.com>  [545523f5624c959b2208001cd9d191a8464d2a32]

        tdf$131937 tdf#61060 sc: UnFreezing now marks spreadsheet as unsaved
        
        Freezing was done in LO 4.0.4 with 2013-05-09 10:55:44 UTC
        Sameer Deshmukh commit 07a14c901025722bcc0a06c76e83c40985ca01a6
            fdo#61060 - Freezing now marks spreadsheet as unsaved.
        
        Now Unfreezing does the same thing.
        
        TODO: should the same thing be done for splitting?
        
        It will be available in LibreOffice 4.0.4.
        
        Change-Id: I3d1d3563c5c62ccfe2dece64a26862db0380ec34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140932
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-10-04  Eike Rathke  <erack@redhat.com>  [85353c42de80e7492f5c80499e18375f942c75c9]

        SvtLanguageTable::AddLanguageTag() unneeded return can be void
        
        Change-Id: I048d38c90e0ca60d0de5defdb16c5411cfd161b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140929
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e86d7b19760e47d2b1a707c2085ed56be2afa4ad]

        tdf#151071 Revise Sifr
        
        Change-Id: I42ed1e912d112cd7733574070f4fdf6533690b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140917
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-03  Caolán McNamara  <caolanm@redhat.com>  [e5d59895ef3897141e5df304a8f98776aa70f021]

        tdf#151262 drop subpixel->logic pos asserts
        
        which have served their bootstrapping purpose
        
        Change-Id: I04b832fde21e4932ed191d972737bee97510f53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140903
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-03  László Németh  <nemeth@numbertext.org>  [5a1c668747f3495ddc7567ae95f2145663565647]

        tdf#138625 DOCX import: fix superscript footnote numbering in l10n
        
        Footnote/endnote numbers in the footnote area didn't get
        superscript etc. formatting in non-English locale
        settings because of the writerfilter mapping to
        the English localization ("Footnote Characters" and
        "Endnote Characters") instead of the correct
        programmatic character style names ("Footnote Symbol"
        and "Endnote Symbol") according to
        SwStyleNameMapper::GetChrFormatProgNameArray().
        
        Testing: unit test of tdf#82173. Manual: e.g. open test
        document of tdf#138625 in an Italian build, after setting
        Italian locale in it in Tools->Options...->Language Settings->
        Languages->Language of user interface.
        
        Follow-up to commit 707eb4db1918658e0c2c2c2033c6a69f80c4eafd
        "tdf#82173 writerfilter: charStyle XnoteReference->Xnote Characters".
        
        Change-Id: I36b3c5ff065e9f80289d051e27f618b40e0c9355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140918
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [aff6d64609bceceef017de2a4fc8b3dd2eba6460]

        sw: fix crash in SwParagraphNumTabPage::ExecuteEditNumStyle_Impl
        
        SfxViewShell::Current() could be nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/SfxShell::GetDispatcher()
        
        Change-Id: Ic2ffc2a35eff8b8acbb896ece198916ee074b019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140920
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [1896d200ecc775aa3a66cc772adc635332562f21]

        cui: avoid divide by zero in SvxNumberingPreview::Paint
        
        Just check for pActNum->GetLevelCount() > 1 as done later for nYStep
        
        See https://crashreport.libreoffice.org/stats/signature/SvxNumberingPreview::Paint(OutputDevice%20&,tools::Rectangle%20const%20&)
        
        Change-Id: I0e9518dafe50b2b10a83487e9247e2fd46f9decd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140921
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [5d155e920334b6d2f03276eedf4471989dae9105]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3f8c722ac252de3078e0137501e8fdaecc888c91
          - tdf#150857 Better x-ref Table Formulas in Help
            
            As requested in the bug report, this patch adds a bookmark so that searching for "table formulas" will be easier to find in the Help.
            
            This patch also fixes inconsistencies as to how this feature is accessed in Writer. It is not necessary to have the cursor inside a table to be able to insert formulas in text documents.
            
            Change-Id: Icb94193d2a274ff4e19255cb46c5fdad5cc3b2b3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140170
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-10-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [1354ea6cc90ec71ba2ccc6f7c98169346419e803]

        CppunitTest_sc_uicalc: simplify code
        
        Change-Id: I88f6243bde37128d4afafb9a0b180964b7d5c47e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140919
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-10-03  Arnaud Versini  <arnaud.versini@libreoffice.org>  [4ab8efd367dc09203a77983e5dcd3d6e9bfa7ddd]

        svl : use uintptr_t instead of sal_uInt32 or sal_uInt64
        
        Change-Id: I57a860ee67cc986936b1488f4ab59b5c47f2fd15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140657
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-10-03  Julien Nabet  <serval2412@yahoo.fr>  [07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7]

        tdf#151260: crash in SfxItemPool::SetDefaults (reportdesign/ReportController)
        
        + deal with the case when there's no XATTR_FILLUSESLIDEBACKGROUND (like here)
        
        Change-Id: I2a4cccc80eea69aa88d45b3485d7f6d4448816e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-03  Henry Castro  <hcastro@collabora.com>  [161e8c63a5175a634b3ddaea4314e335b290a298]

        tdf#127856: sc: Status bar "languages" when you click...
        
        the popup "More.." button it will show the format cells dialog.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Idb60decf1c582c906d24d10fc248cfd20f8f4cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138499
        Tested-by: Jenkins

2022-10-03  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [bd84c33f4247219a2888f68edfa7b704ba320787]

        tdf#151087 Breeze: Fix dark dan light Group & Ungroup Columns/Rows
        
        Change-Id: Ibbf0fc8f34e04c62231bcb70d310f29aa5099a5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140842
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-03  Miklos Vajna  <vmiklos@collabora.com>  [a93835da988134a7e14114701dcd90dd1f4dd26e]

        sw: prefix members of SwInsertBookmarkDlg, SwNumPositionTabPage, ...
        
        ... SwOutlineSettingsTabPage and SwSortDlg
        
        See tdf#94879 for motivation.
        
        Change-Id: Idcc0425cd65b908ec6b92b9689d441fd185e51a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140899
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-10-03  Caolán McNamara  <caolanm@redhat.com>  [a0bc0cc81b597aa81189355a8125753d6b873cce]

        tdf#150786 use the same colors for pdf widgets regardless of theme
        
        use StyleSettings::SetStandardStyles()
        
        Change-Id: Idf08872fabfe50cbc73091e17dd3ad7a4acc6715
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140900
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-03  Khaled Hosny  <khaled@aliftype.com>  [1dabf1fc58cf9e98bdc24efcca349fcc7a59d2d1]

        vcl: Drop redundant check
        
        The code already does the same check above.
        
        Change-Id: Ia9a9bd743235f888af1bb8ff2bd7f16e9776619e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140898
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-03  Khaled Hosny  <khaled@aliftype.com>  [bb67f10786fd5e232b198d09139c41078c3fc60d]

        tdf#112152: Fix subsetting empty glyphs
        
        When traversing the components of composite glyphs, the code was
        treating a component pointing to an empty glyph (e.g. space) as an
        error, but it is not. An overzealous bounds check.
        
        Regression from:
        
        commit 41007842ed9bb5d6165792a197769f72dae55a2c
        Author: Martin Hosken <martin_hosken@sil.org>
        Date:   Thu Sep 10 10:14:18 2015 +0700
        
            Refactor graphite integration and update graphite
        
        Change-Id: Ie352f17cb08cd5762ff2a339662248a536b4e934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140897
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-03  Khaled Hosny  <khaled@aliftype.com>  [9063d99ff5ee43cc1239fc1dbb5d9897bdda1c9b]

        tdf#137528: Fix skipping Kashida in fonts with bogus ones
        
        There was a typo in the check, and we also want to fallback to using
        blanks if no Kashidas were found, so check for Kashida positions first.
        
        Change-Id: I64cc3bf5c76ecc01764073bb5a2302520157fad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140896
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-03  Jim Raykowski  <raykowj@gmail.com>  [e3a81e039d0c5d4ee8e5a00e8b3eff04b62eb72a]

        tdf#148240 Drop IsExperimental from Outline folding UNOs
        
        Change-Id: Ib2152968afb92757fa705b03d3e8dd8996440bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140851
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-10-03  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2156ac86f02344090ad95c85eaa95448e99ead38]

        tdf#151087 Colibre: Fix dark dan light Group & Ungroup Columns/Rows
        
        Change-Id: I257e999ced55d44461e24e30e961648b09ea1087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140837
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-03  Caolán McNamara  <caolanm@redhat.com>  [8abc00614b746ce751838f9e33f62664ed515542]

        use G_MAXINT to create an "invalid" path to use to unset cursor
        
        Change-Id: I475a64ac3977bad716ce6f94a88ff02af37a932c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [57ecd472d7078f9e540cccd4873355d6250fc21f]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I7a1900352a9404b64987d71c9b9f44d07e2a176b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea49800fc2d545aa68fc625563ebfe9d495acc2a]

        use more SetPosition::SetContent
        
        part of the process of hiding the internals of SwPosition.
        
        Also, remove code that checks if pCnd is nullptr, because we
        have already dereferenced it at that point.
        
        Change-Id: I5362c2540af88bdd35db95472ceed420b90cf1bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [d23ca66f4dcdae9470972aed6861e84167a8571e]

        use more SwPosition::SetContent
        
        part of the processof hiding the internals of SwPosition
        
        Change-Id: I5789329e9d0a6cbdc03d51b2163fc88ebd9c6293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140829
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [3bc383f5f6059ace3b834a637a49bc884fc00324]

        use more SwPosition::Adjust
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I4c5cb657fa193ae2efbf0d7e315939e68ca89600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-02  Caolán McNamara  <caolanm@redhat.com>  [e4ffcf3225ab4ec38c704f4ba0d1f987e4368af5]

        crashtesting: assert on ooo8886-16.sxw
        
        seems a regression from:
        
        commit d7234feac18dbb94fef310e8c241428426b27717 (HEAD, refs/bisect/bad)
        Date:   Thu Aug 25 18:45:33 2022 +0200
        
            use more SwPosition::Assign
        
        Change-Id: I80602b2cc01b28986b04a97fce5c51673e6fe8a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140848
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-02  Eike Rathke  <erack@redhat.com>  [cf777cfcb22647b1f2d6ace307fbcc4f6d2cca30]

        Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip import
        
        The chain of fixes for #i119960# tdf#48621 tdf#125440 produced
        code that is suboptimal and not robust enough against some further
        corner cases, taking quoted field content where there shouldn't
        be.
        
        First, in ReadCsvLine() assume that if a generator is broken
        enough to start a field quoted followed by containing an unescaped
        embedded quote and there is no closing quote (i.e. immediately
        before a field delimiter) until the line end then the generator
        will not be clever enough to write embedded linefeeds either and
        the field starting quote wasn't one but to be taken literally as
        all other quotes until the now unquoted field end. In this case do
        not read a subsequent source line for the current row.
        
        Then, for individual fields of a row make a similar assumption, a
        quote-started field has to end with a quote before a field
        separator (or line end) or otherwise all quotes of that field are
        literal data up to the next field separator.
        
        This made it necessary to adapt two test cases of the garbage CSV
        import test to produce different garbage than before.
        
        Change-Id: I4424b65c87c7f9dcbe717a7e6cf207352cb613f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140850
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-10-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2a7fcaf582df3ada57ca519b50e29011973a1b6f]

        tdf#143158 - Handle double clicks on alphabetical indices
        
        Open the edit index dialog when double-clicking an alphabetical index field.
        
        Change-Id: Iaba398e485d2e7e848503189ad1f3b12975a5a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140836
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [dc9270d207af24c9b5cd775eda8997f3aad68f14]

        Unused constants
        
        Change-Id: Ic43a4e52b5ea40e54b368815e504840cb2c78aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140845
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [5cf31e332ed835fd1755bda133cee7bbc328dc09]

        tdf#132576 Remove unused template categories
        
        This patch removes the names of template categories that are not used. None of these template category names are reachable via the Templates Manager nor via the Save as Template function.
        
        Change-Id: Ic2caf485106134de8554b93b5d6e14bdf7f382e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140610
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
        Tested-by: Jenkins

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [81ccda84be0f8ce833c008c46da05b4cc881e977]

        Unused include
        
        Change-Id: Ie6b2a0cebab375e8b66d5a9658dbb0cc03b8c704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140844
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [330f5786b17cf3dd3a7404d54335020fb90dfc39]

        Allow building libeot on any platform
        
        It is not enabled by default, so I don’t see the point of silently
        over-riding configure option.
        
        Change-Id: Ib2c14b2ce7519775ed5a3365c34ade3c96b66532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140843
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Justin Luth  <justin.luth@collabora.com>  [cf805848ed5be4ba46eef9a8d3999d9b06848c60]

        related tdf#123990 sc condition: cleanup ScConditionMode::Between
        
        Change-Id: I6bec0af1c7fe109b81b5392c06f795eed03df061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140716
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [3b6e9582ce43242a2304047561116bb26808408b]

        tdf#72456: Don’t cache macOS font list
        
        The “system” font list is used for both actual system fonts and fonts we
        add with AddTempDevFont(), so the caching makes loading embedded fonts
        broken the first time the file is opened, requiring a next open without
        closing the application.
        
        The callers, I think, are careful not to call GetDevFontList() unless
        they really want to refresh the font list, so the caching is probably
        superfluous if not wrong.
        
        Change-Id: Ie14cc473a64425fd5270bc65ffd61dea2d873cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140840
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [5aad191eae5366c6892dc51b85171bbe3db7b60d]

        Revert "Use libo_CHECK_SYSTEM_MODULE for eot"
        
        This reverts commit ce54ba96f38b4af3aab1a7064078ee406eb021c6 and the
        followup commit 88c511981e31c73dced95b5dc3c200fdf2a4e932.
        
        Both effectively disabled enabling libeot support.
        
        See also: https://lists.freedesktop.org/archives/libreoffice/2022-August/089205.html
        
        Change-Id: I54780c69ca83b230b0c9b3b18065782fb5626da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140838
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [b7e7ae77f55e41dae2231b04062cf037f7f9b13f]

        tdf#151114: Improve styles preview alignment
        
        Change-Id: Iefe265584d710bd6cfc9e7ed0a656dd83d91c84c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140811
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [d7083fe6dd383ac4144fbe53e300bc3d34f26ef6]

        tdf#72456: Support font embedding on macOS
        
        With the previous commit, when we want the full font data we pass 0 for
        table tag. This does not work with CoreText’s CTFontCopyTable(), we we
        emulate it by using hb_face_builder to construct a full font from
        individual font tables.
        
        Change-Id: I0edb10982434872221466e9ec9ef9cd39087967a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140831
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [112d07027c4484dd571519911596d11eae897524]

        vcl: Use PhysicalFontFace::GetRawFontData() for font embedding
        
        Change-Id: I6f7c4508f7cef022eaf65a998cb242078d3771c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140826
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [c107d08460938270cbc2a32a89d995fc0ae8ebea]

        vcl: Remove unused AquaSalGraphics::GetRawFontData()
        
        It was used for subsetting, but we switched subsetting to a more generic
        code path a while ago.
        
        Change-Id: I6066b7697268e9444587d73810f9465488aa4740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140825
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [caa10a1f80da856debf4f397503f27c86199208f]

        vcl: Use a hb_face_t wrapper in TrueTypeFace
        
        We don’t need full access to PhysicalFontFace. This will be needed when
        we use hb-subset API for instantiating variable fonts.
        
        Change-Id: I2578525cd54167d01cd2748d5ac1900c607867a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140823
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-10-01  Justin Luth  <justin.luth@collabora.com>  [dd8775b051b40309d7d7e5730a3c5304d931f594]

        related tdf#123990 sc condition: GetCollator -> GetTransliteration
        
        In the content of Equals/notEquals, Eike said,
        "This should not use collation (which should only be used
        in sorting context) but ignore case transliteration instead."
        
        "I'm undecided about replacing this (and the Between|NotBetween)
        collator with transliteration. Locale sensitive collators have a
        different comparison than transliteration
        and order characters differently."
        
        I also added a few code clean-ups.
        
        Change-Id: I94f73d99b36f8995c4e80fd2f317f1b5bca4f165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140676
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [92c35f820d87ac50c19d60572275e49e2911e80b]

        Fix typo
        
        Change-Id: Ice3068f3b20c0f8a20e8b3c05ddf358b971f66ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140810
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9ec00833d37579884acfcac0e75519fd6287a27]

        Fix typo
        
        Change-Id: Ib547189e0f87f3e3a3096dd587127706474983cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140809
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-10-01  Sergey Fukanchik  <fukanchik@gmail.com>  [4e6b19b12ce26a28dd0f2730ee47cf13739f0957]

        Follow One Definition Rule for COL enum.
        
        Change-Id: I97292df52c50e73b3f0d4ee9b5f8134959f3b7e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-10-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [56ea2f069952d23e5b94689669a5ea18a505ea7e]

        tdf#136919 Fix table size label in dark mode
        
        Change-Id: Ifd4d67fa8211cf703c5d5d6ea99a0f41bd427e1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140612
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-10-01  Justin Luth  <justin.luth@collabora.com>  [acc71c3e502f23daaf2489d102dda3b00a45960a]

        tdf#148806 sw vba: fix GetVbaEventProcessor
        
        I've decided this is not an API change because there exists
        offapi/com/sun/star/script/vba/VBATextEventProcessor.idl
        
        This patch allows New, Open, and Close events to be
        sent to VBA macro event handlers.
        
        I tested with DOCUMENT_OPEN.
        
        Amazing - all this stuff is here in place,
        but isn't properly wired up. How can so much
        ground-work be done without it ever being functional?
        
        I don't think this has ever worked,
        and the same problem/code is seen in OpenOffice.
        
        The service names were already mismatched in the initial patch:
        commit fc135411fa926f4d89e98378d113f597af79e2a2
        Author: Daniel Rentz on Tue Jul 6 19:34:53 2010 +0200
            mib17: #i112634# add VBA sheet event handling,
                   based on a patch from Noel Power
        
        https://bz.apache.org/ooo/show_bug.cgi?id=112634
        says "Additionally I added the hooks for vba for word
        ( but they are compiled out for now )"
        
        Enabling this will open up the doors to a lot of
        untested code I think.
        I had to move initialization of mxVbaEvents
        because it was being set without a VBA project,
        but it didn't work to put it in VbaGlobals like Calc does.
        
        Change-Id: I08cc0e33444dc7dfaac82cf6cebb1a89dbb69faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140801
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-10-01  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dc3a6485b67ca0996803e3799faa76a11cddb46a]

        tdf#151071 Revise Sifr: Legend, Reset Filter, Import Slide)
        
        Change-Id: I063fda1f578ced27111d34c98e8bf25f412800c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140805
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-10-01  Khaled Hosny  <khaled@aliftype.com>  [054c8aade7cca8b6b482c16c5a80c5772522180c]

        vcl: Move TrueTypeFace where it is used
        
        No need to make it module public. Easier to modify it.
        
        Change-Id: I119381d463c8f176b355fc7df111011ae518b49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140821
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  Khaled Hosny  <khaled@aliftype.com>  [c3b5eea4304ad6815b491f549fce008a9630c213]

        vcl: Use LogicalFontInstance::GetScale()
        
        Change-Id: I5f79fddd4e514c8224446e2327528002e9daa566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140808
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  Rene Engelhard  <rene@debian.org>  [6cfa43fcf214eaf556e998438bb9754cc210c3d8]

        remove obsolete sfx2_emojiconfig from Repository.mk
        
        since the installer fails because it cannot find it.
        (was removed in 5f1eb2a12b6e6ee646b5e9536822531ad0bd3259)
        
        Change-Id: Id7d8cccc43b461bc10a447d8d5d48009bc48f6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140807
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: Jenkins

2022-09-30  Khaled Hosny  <khaled@aliftype.com>  [8da2560a8ddb530abe4fb72b59ef6e18ce219d80]

        vcl: Use the same underline sizes for overlines
        
        It makes no since to have overline of different sizes than underlines,
        and in fonts with big ascenders (like Amiri), we end up calculating much
        thicker overline than underline.
        
        Change-Id: I97e9818c94e815b2eb57813ab22329bc833fd34c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140804
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  Khaled Hosny  <khaled@aliftype.com>  [ba03e033d1be4bc49f2a8d6afbeecd381507b242]

        vcl: Use font’s underline/strike position and size
        
        This respects the values set by font designer, which are usually better
        than the values we calculate especially for fonts with deep descenders
        (like Amiri).
        
        Old code is kept as fallback in case the font does not provide such
        values.
        
        Change-Id: I51a5147e4c6e006d1dcd13817ed21f0f62b47e97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140803
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  Khaled Hosny  <khaled@aliftype.com>  [fb417ee082afdd2e80a1f48aa420bb8d5cb97686]

        vcl: Apply variations to font metrics
        
        Use HarfBuzz API instead of reading the raw font table directly, since
        HarfBuzz will apply the font variations as needed. For non-variable
        fonts we still also use HarfBuzz font metrics API, but in a more
        fine-grained way to maintain backward-compatibility.
        
        Change-Id: If6b12a11ecb63356be92ef4f0714355ae77378f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140799
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  László Németh  <nemeth@numbertext.org>  [5948e2e9f032916e3278f904097eff6b47b869d6]

        LibreLogo: fix ast, gug, hsb and sid language support
        
        Asturian (ast), Paraguayan Guaraní (gug), Sidamo (sid)
        and Upper-Sorbian (hsb) localizations did't work despite
        their existing localization stored in the language fallback
        dictionary of LibreLogo.py, because their 3-letter language
        identifiers with their country codes trimmed to 2-letter,
        for example: "hsb-DE" -> "hs" instead of the correct "hsb".
        
        Missing Upper-Sorbian support was reported by Michael Wolf.
        
        Change-Id: I57aa6752d05452d1f8bb95ff91f4d4456dffcd80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140796
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [6770a541e36a4e270ad309bd429a33e8d0bee15f]

        use gtk_tree_path_new_from_string here too for consistency
        
        Change-Id: I5d4795fcaf20ae89c18ddb1d75ca93f078e0e3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140798
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [0c2d5312071a2de2ef2a9bdb997b8b8d4a91e9b4]

        gtk_tree_model_get_iter: assertion 'path->depth > 0' failed
        
        seen in format, cells in calc
        
        try an explicit depth
        
        Change-Id: I395563d2b412b2ca8839292296f9dad6db704620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [f6785391fb0d6665109b3afe73e86f11cc11baab]

        align sparkline color labels like all the others
        
        Change-Id: I5a7b16fb5de83118bb2d0b3bbfd30fce1b9c8d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [8b803c13b4a81a3fc6aa7fed219caeccb88dba6c]

        use standard row and column spacing
        
        Change-Id: I55a469f30f837b7c55b6c7d9672c7e909abe6a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140791
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [12959054a0786811041c70173e1d4d448e85c012]

        resave with latest glade
        
        Change-Id: I0e6b4bf7a6420e555ef72b58995055a116afd43d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140790
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ccbea717d1e11a821bc5fc0900ac0e6f7a566c4]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I3dde04bf78e1412f731b3cd63c658adfb1b2fea5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140793
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f9fc5da3c38d3e73f1427f040d29a27bacfbe44]

        use more SwPosition::SetContent
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Idc7bc4cd22f13cf7bfb7982d445d13970a9e70a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140792
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [113d9bba057b2fd634fcfcebb83a4d92cf41d69f]

        use more string_view in stoc
        
        Change-Id: I6552f3daee7b18dbd311ac7e80ebf1e84e36704d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140787
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-30  Maxim Monastirsky  <momonasmon@gmail.com>  [79e450749d58e21cad747592f49e505830184d74]

        tdf#151172 crash in notebookbar with extension enabled
        
        Change-Id: I60d777b27ffee095807490f4b181b1b08ed88462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140683
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-09-30  Khaled Hosny  <khaled@aliftype.com>  [e6a46b235997c309a926bb0573de625a89b29b8c]

        vcl: No need to get font face from GetNextGlyphs()
        
        We can take it from the font instance.
        
        Change-Id: I54c507d498c58e271c479b0a615b165345a1c33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140788
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-30  Caolán McNamara  <caolanm@redhat.com>  [a091ae213eb8d64c21361969775b76e7911cc1af]

        tdf#143673 set an explicit drawing area bg
        
        noticed in gtk darkmode on switching from initial application
        to start center
        
        Change-Id: I1cffab97ecd69ca6043531a6b2b5fc34b1ca84f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140789
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ec9ace3f010dc654ac831cf66d9589a16b07931]

        use more string_view in starmath
        
        Change-Id: I3569d8dd41bf1c2db6a1fd379ca5596342922e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-30  Noel Grandin  <noelgrandin@gmail.com>  [379dc869229db17492686ff9b5abe268a6a89c2f]

        use more SwPosition::Adjust
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I0109d81181bddfdd7b02c8f2f03b67d53b30ee6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-30  Gabor Kelemen  <kelemeng@ubuntu.com>  [b06ba49a0ee6e3f295e8dc50e84e8a45bb3baafa]

        Drop unused gen-iwyu-dummy-lib.awk script
        
        missed from 079659eb7d15f15a37f1f508beb5cffe24fe6f25
        when the code using it was dropped
        
        Change-Id: I7d769f8be75335079a4a24391d120505d7bd6c84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140741
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2022-09-30  Miklos Vajna  <vmiklos@collabora.com>  [a3d3d8e0a994069986400c0e08701bf4f8a94ba0]

        CppunitTest_sw_layoutwriter2: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Also add a SwBookmarkPortion::dumpAsXml() can that show the colors of
        a bookmark portion, instead of faking that into the layout text.
        
        Change-Id: Id4da6b27bf3d33d55bba281445084242306d1525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140751
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-30  Justin Luth  <justin.luth@collabora.com>  [8253b8d6f1efb7fc3e2928d543c21a79c2cdc13f]

        tdf#148806 docm: fix vba macro events without ScriptCodes
        
        Prior to this, none of the DOCM ActiveX macros were called.
        Now, just like magic, it all works.
        
        Already broken at commit c5fc57de562850a7d2f708e3936296d24677012d
        Author: npower Developer on Tue Mar 2 15:04:15 2010 +0000
            npower14miscfixes: #i109706# move back msvbahelper to the filter module
        
        Change-Id: I25b25850b12609e5e00dd4bd5189a734abcbddd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140750
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-30  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [7e19bde57c825f361304e9bce1d3929995ee7ddd]

        tdf#151071 Revise Sifr: DB Query, DBReport, Freeze Pane, Go To Page, etc)
        
        Change-Id: Ib52ba298d8f6be57b6aa32dbfc4389ba3e4680ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140747
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-29  Noel Grandin  <noelgrandin@gmail.com>  [74e2d6dca536fe670b125ee9ac1192f45166db6e]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I5744c861a9996f4d6d710acf73720aae2af6d9fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noelgrandin@gmail.com>  [ab4c74241ddc1a09c82d5ef240a170b0dc38b31c]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I0efae00beb920aac21fc5c10b663570cecc681bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noelgrandin@gmail.com>  [13a10516e71609d677d7f7d274f3ddc98cb8df18]

        use more SwPosition::AdjustContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I43e32d6ce99e045c4ac9258d5f208bc557998812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140743
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noelgrandin@gmail.com>  [3c68edf8fc8343300de500f01b11ae36e02819a6]

        use more SwPosition::Adjust
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I85a732f068a94e91abda5e22597d4024bc5bddb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1cf478e77db23f688d697112ea31c6d470b2539]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ib643b5ea126ada9edb7c2ec07ea3536fc93d36d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3e07612eb6536aa14f2108484705068fc8e30d8]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition.
        
        In thi case we just need to point aDelPam somewhere else, so
        that is doesn't point into a node that is about to be deleted.
        
        Change-Id: I7b2ae167af30cebd896565e5e597bcbf79505e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [22535b5a6591e1f9f1ebd6c95bc6173f570f0082]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I7e4055250f68fd8d463f5cf205a91801ae7c2f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Julien Nabet  <serval2412@yahoo.fr>  [0103092bf2e25b0f1ad33b1855ea440dfa537f3d]

        Related tdf#151197: remove remnants of EmojiControl in svg parts of icon-themes
        
        Change-Id: I82fb27ddbec2d2ab92fc41c8e1c1a398450bbfe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140740
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-29  Luboš Luňák  <l.lunak@collabora.com>  [1c53f5b6647dcffa57012990d342b21eaff19888]

        introduce ScTable::GetColumnData() (tdf#151182)
        
        This is intended to handle possibly unallocated columns similarly
        to CreateColumnIfNotExists(), but unlike that one this one does not
        allocate, if the column is not allocated then the default column
        data is returned. This is intended for reading of columns.
        
        Change-Id: Ic3b637eb3d16bac69ebc7ecd389973407db4f7fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140737
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [436c37e6995c70af8ead81bb69b7692f8ef65912]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Id3a0105f0566db54fcbbf50f829094ca6ac3bcca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [867f7311c36c0ae6d8dd8b6e3f1466d6babe4817]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition.
        
        Change-Id: Ifa1996b286058bf17a29401a079ecfd4d2babd2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140735
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [16844900b94e07975888745aa6d07e60c07ff680]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I46fa167cafccb57baa4f8153528d2f130a4d96a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Caolán McNamara  <caolanm@redhat.com>  [c38d17b62c3ec206ccf484d701ff95cd037c6a4e]

        ofz#51859 Integer-overflow
        
        Change-Id: I985164aad4f0133c258d6bdb8a4f38a75c3f7edf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-29  Khaled Hosny  <khaled@aliftype.com>  [5f1eb2a12b6e6ee646b5e9536822531ad0bd3259]

        tdf#151197: Remove EmojiControl
        
        Change-Id: I7fb423727425ec42d1161f6ac5649f5cac82f12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140651
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7218379295630a3310efca69058c0e776d85969]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I759b9e3780151dc1574b75486e9e5bf43b198084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2ebf1ca2b696c800071a8c000a9715fdaa911c15]

        tdf#151071 Revise Sifr (object align, small icons with cursor, accent style)
        
        Change-Id: I7c7037719f73e761f21a416ff289b327766e8ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140723
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cfc8bbec95d64613fc235a7af8c00ea99b6a8ed]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I35124d74684e7f1b441dfc0168d9647d7060421a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140726
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1cf3bcae686a9c49c3a941100ded88d7fd84091]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I0cbe2865b0d411b3385476fa16988de4fd34531c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f455bf096c922b8dd07b045258c490bae93ab1e]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I58aef1248e52bd36239dad4029d127e58179e637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Khaled Hosny  <khaled@aliftype.com>  [b2808ebfeb8654d349f6324fa2bc0f6e97af4e33]

        tdf#55922: Remove redundant macOS dock icon menu
        
        The File → Recent Documents is redundant since macOS shows recent
        document on the main dock icon menu.
        
        Change-Id: I644745309fb06f340fb871f3a5dba620c279e718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140721
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad5567daa7beb422b868af3234f6da50138cc24e]

        use more SwPosition::Adjust
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I250484cec147b61c74a7fdb23bd389dd5d6c1d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140712
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c2ec9794db85a4ff2de71c7f50587c4fd7ac703]

        use more string_view in writerfilter
        
        Change-Id: Idd4582138e8da9cc60e0a728bdea5542a509a4f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noelgrandin@gmail.com>  [4b95451f859bac8e05956ce12df17f1ee410032d]

        split utl::TempFile into fast and named variants
        
        which makes it easier to know what each variant requires
        to stay on it's happy path
        
        Change-Id: I3275a2543573367714bc78092e882f6535507285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a08468c1a5255d3fb04cd8a0dc627acdea40426a]

        use more string_view in xmlsecurity
        
        Change-Id: I245961d0116a7a72f8506cfc0b009990e35c6796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140710
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-29  Miklos Vajna  <vmiklos@collabora.com>  [c74d97f1218a3592226a4fae4d4c1941dabe4f7a]

        oox: avoid else after return in WpgContext
        
        It's less code and does the same.
        
        Change-Id: I9b08f5b5c982bbf3740d7d5d04156ae01d878705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140718
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [100dc387ffd7df84199dae51abd9de35440905f1]

        tdf#151071 Revise Sifr (table & data action)
        
        Change-Id: I8e3ef21442c0465135d2eede0d9dc5979a5b8703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140720
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-29  Eike Rathke  <erack@redhat.com>  [48b9cbc742de3f6120986cb6cafc92eb5009da82]

        Fix incrementing number in dbrange names during copying, tdf#145054 follow-up
        
        lcl_IncrementNumberInNamedRange() during copying a sheet didn't do
        what it was supposed to do, it could generate names that would had
        been cell references, and the loop it was called from could had
        prematurely ended because it inserted into the set it was
        iterating over; also the loop ended as soon as it encountered just
        one dbrange that wasn't on the sheet that was copied. That never
        worked as intended with more than just a very few names only on
        the same sheet.
        
        Additionally after the actual change loplugin:stringviewparam
        forced me to pass a std::u16string_view parameter, for that some
        adaptions had to be made.
        
        Change-Id: Ib83d317c69d821e8e8a2f1cd6791da9616ed188d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140717
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1f7b050d83966b51e0b22de9b565bf4ceacdad16]

        tdf#151071 Revise Sifr (too lazy to mention)
        
        Change-Id: I88ce1157604c0168980276fe1855eee2f9649f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140715
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [03809a4338f4a1e9e5ad5088fdeedc4c3fe0f7b5]

        Related tdf#132576 Fix "draw" string in Template Manager and make it translatable
        
        The Templates Manager has a category name "draw" which cannot be translated. It also looks weird because all other categories have full names whereas this one is a lowercase string.
        
        The reason the word "draw" is used is because it is the name of the folder where the template is located. This patch maps a string "Drawings" to give a proper translatable name for this category.
        
        For this patch to take effect, the user needs to be on a fresh profile (or at least reset the user UI modifications).
        
        Change-Id: I2223dfe8761a5687b02e843957ebf7fb07f4a626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140506
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [124d786e68dd5838b814ec8a453769ff7ba76f23]

        use more SwPosition::AdjustContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic2a13b4bcdc820f3604179ee391b8a0df962226b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140709
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Jim Raykowski  <raykowj@gmail.com>  [589cfd3ef33ddb42ea265e2ab2b87d32f1f1f67d]

        tdf#140892 Account for list bullets and numbering
        
        when placing outline folding button
        
        Change-Id: I2cdd9916c0f1327d9a48443d00205490bfb04f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140585
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [a63fcd0916ebe51d866ed1113babd1a521c175c6]

        use more string_view in svgio
        
        Change-Id: I30d2f02941673ce33febc4e0f563e77b80a585fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa770d615ec5722411cc4ab1f88de89d4cad5809]

        use more string_view in ucb
        
        Change-Id: Id1d35aca0c8f62b3eb03eca9850a3f3c9799df98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [42a73e2259d5937ffb8896f7cd24991f83b1ad82]

        use more string_view in desktop
        
        Change-Id: I16dbc8cb027f51703bc016e095096c868f6e2881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Tünde Tóth  <toth.tunde@nisz.hu>  [adc042f95d3dbd65b778260025d59283146916e5]

        tdf#124333 PPTX import: fix Z-order of embedded OLE objects
        
        Choose mc:Choice in a:graphicData element
        if the selected p:oleObj element has a shape id
        to avoid of shape duplication which created also
        bad layout/overlapping because of the different Z-order
        of the duplicated shape.
        
        Change-Id: Idecff4903c2d637bc82353f13352cac72413cec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140041
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [36003e7644014cde9330bf45fee3815278a74035]

        fix bug in lcl_IncrementNumberInNamedRange
        
        from
            commit 690e4852809ea21b5fd909298c5fa2a053fa0458
            Date:   Mon Jan 31 09:02:33 2022 +0100
            Fix copying range when it doesn't contain a number
        
        OUString::lastIndexOf() eithers returns an index or -1, so adding 1 to
        it, means that nLastIndex is __always__ >= 0.
        
        Change-Id: I197f8c856a52534690d7a0d28e49cecf296dccb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140704
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noelgrandin@gmail.com>  [c4c3d1b575ba46f181a15d5c4b66c52a3020194d]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ia5d84c6b9905355f0b04cb64c18b628120c3c9b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noelgrandin@gmail.com>  [75502b3e837071389579787b8d0db6f47db7851b]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I5328dcf01d3fc2c8e61265667512f8bdcd739509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [50bd2ca20618ba9c9f512716d8de7521a9fde0f6]

        sal_uLong->sal_uInt32 in CommandStruct
        
        we are already using sal_uInt32 for this in some places
        
        Change-Id: I69ed8f6c29215fcedcafc403861cdd0e06c034ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [913ed3e5673c2d70e2c4e519eb65368b0606d7f0]

        sal_uLong->sal_uInt32 in SwHashTable
        
        Also
        (*) increase the number of items this table supports from SAL_MAX_UINT16
        to SAL_MAX_UINT32
        (*) add some asserts to document and verify the above limit
        
        Change-Id: I53f83303af04a9ac4f3786b221e338a7684fa1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Justin Luth  <jluth@mail.com>  [6cec8ba33a28de7248861b2eecfc5034cbde9d37]

        tdf#125216 import filter: allow .doc renamed as .dot
        
        A LO 6.2.2 regression prevented .doc-as-.dot files to load,
        giving a "Read Error. This is not a valid WinWord6 file."
        
        Well, it is not a valid .dot file (because of some bit differences),
        but it is a valid .doc file.
        Since it was renamed to be treated as a template
        (requiring a save-as), we should treat it as that.
        
        Change-Id: I308375797e9dae3ca6d203fab520e91ee788325e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140687
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-28  Miklos Vajna  <vmiklos@collabora.com>  [9be24f694d42fc9cae55ed911e0dff7f729803f1]

        cui: fix crash in SpellDialog::SpellContinue_Impl
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 128 for address: 0x0
        program/libcuilo.so
                svx::SpellDialog::GetNextSentence_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool)
                        include/com/sun/star/uno/Reference.hxx:114
        program/libcuilo.so
                svx::SpellDialog::SpellContinue_Impl(std::unique_ptr<UndoChangeGroupGuard, std::default_delete<UndoChangeGroupGuard> >*, bool, bool)
                        cui/source/dialogs/SpellDialog.cxx:355
        program/libcuilo.so
                svx::SpellDialog::ChangeHdl(weld::Button&)
                        include/rtl/ustring.hxx:527
        program/libmergedlo.so
                Control::ImplCallEventListenersAndHandler(VclEventId, std::function<void ()> const&)
                        include/rtl/ref.hxx:208
        program/libmergedlo.so
                Button::Click()
                        /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/std_function.h:244
        
        Change-Id: I2c7267118213ea7d915a28d77badf93f8ff75683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140586
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140689
        Tested-by: Jenkins

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d07dd1b5c9a81ac95407706ab93fdb3f1d82c13]

        elide some ref-counting
        
        Change-Id: I9fb70d1612dda3c20a683a050f550d1830dd1fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [217dab1c2c197bbaff8d9948ccb8e7cb4b959fcf]

        no need to convert this OUStringBuffer to OUString
        
        can save some cycles by treating it as a std::u16string_view
        
        Change-Id: I704118b26cbfbebcc8a7f19ce11079ef5a544a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [01c9e8808bdee7ee355a037fda2889150f21f6fe]

        use more string_view in formula
        
        Change-Id: I3d9feafb0e2010f284a1700becbe9b701edc9849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1d6ec66ce4b8dd84f0962f9b749b831cbb05baf]

        elide strlen cost in FastAttributeIter::toDouble
        
        by inlining the underlying code to rtl_str_toDouble
        
        Change-Id: If379bf40472455be93ca4da6ece25a126bed0b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b47733e5f0a16f3fc1bdaad5c3ec171f2fc35d02]

        avoid some ref-counting in a hot path
        
        Change-Id: Ibae87fc4e2fbe11d52cd89134a253ac2215134a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b697b15a4985160fbe5b384411aa6b9c0b11b60]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Iede060702cefc3c2b0a5c5268ece07affa1e3a83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [da100343e5416e1040f8f6d83fd73d8d0577112e]

        tdf#147724: DOCX STD import: use storeid to indetify custom XML
        
        We need to identify XML document to use by storeid in sdt block
        and in properties of external XML file. Otherwise are possible
        content collisions when same xpath can evaluate successfully
        absolutely unrelated custom XML.
        
        Change-Id: I6d201a539130b110046deb1818340513cc47a061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139771
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-09-28  Miklos Vajna  <vmiklos@collabora.com>  [914d246e0edcbdfa5969b7f3eea7c67e1a5b7522]

        crashtesting: fix PDF export of fdo83057-2.docx
        
        Loading this document and laying it out resulted in an assertion failure
        since commit de90c192cb8f1f03a4028493d8bfe9a127a76b2a (sw content
        controls, plain text: enable DOCX filter with data binding, 2022-09-19).
        
        Writer has two relevant invariants: First, if a draw shape is anchored
        into a header, then the "master" shape (typically on the first page) and
        its "virtual" shapes (on other pages) have their indexes / ZOrders set
        so that the master shape has the highest index. The second is that in
        case a draw+fly format is paired into a "textbox", then the fly index is
        always the draw index + 1. The assert fails because in this case the
        virtual draw shape's index is not smaller than the master one.
        
        What seems to happen here is that first SwDrawContact::ConnectToLayout()
        iterates the frames of the text node in the header, and happens to first
        visit page 1 and then page 2. So the master SdrObjects go to the first
        page, the virtual ones go to the second page. Then later
        SwDrawContact::ConnectToLayout() is called again, which removes the
        master and the virtual draw SdrObject from the layout and the virtual
        draw SdrObject from the model. Then it visits the text frames of the
        header text node again, but this time it happens to find the second
        page, and only then the first page (for reasons unclear to me, this
        didn't happen before the above commit). The result is that both
        invariants are failing: the master draw+fly is no longer on the same
        page and the indexes are also out of order, so one of the pages don't
        show shape text for the shape from the header.
        
        Fix the problem by two tweaks:
        
        - Improve SwDrawContact::ConnectToLayout(), so that in case it just
          appends the draw object to the layout for the master, then it adjusts
          its ZOrder so the matching fly will be the draw one + 1.
        
          This was working in the virtual case already, since there we call
          AddVirtObj() already, which calls SwDrawVirtObj::AddToDrawingPage(),
          which already knows how to maintain this invariant.
        
          This fixes master draw SdrObjects to be directly before their fly
          counterparts, even if the page order changes.
        
        - Improve SwDrawVirtObj::AddToDrawingPage(), so that in case the virtual
          draw SdrObject finds its fly, but that fly has an incorrect index (due
          to the changed page visit order), then we first fix up the fly and
          only then set the index of the virtual draw SdrObject.
        
        The result is a doc model like this:
        
        <SdrObject ptr="0x52ecd30" symbol="13SwDrawVirtObj" name="" title="" description="" nOrdNum="0" aOutRect="-16000, -16000, 0, 0"/>
        <SwVirtFlyDrawObj ptr="0x4e4bfa0" fly-frame="5">
          <SdrObject ptr="0x4e4bfa0" symbol="16SwVirtFlyDrawObj" name="" title="" description="" nOrdNum="1" aOutRect="0, 0, 0, 0"/>
        <SdrObject ptr="0x4ea4300" symbol="17SdrObjCustomShape" name="Rectangle 2" title="" description="" nOrdNum="2" aOutRect="10418, 2441, 1775, 485">
        <SwVirtFlyDrawObj ptr="0x52ec630" fly-frame="14">
          <SdrObject ptr="0x52ec630" symbol="16SwVirtFlyDrawObj" name="" title="" description="" nOrdNum="3" aOutRect="0, 0, 0, 0"/>
        
        I.e. each draw SdrObject is followed by its fly and the masters have the
        highest indexes.
        
        This all stems from the behavior that 1) re-connecting a draw contact to
        the layout removes the draw shapes but not the flys from the layout, 2)
        the order of frames in an SwIterator visiting is not something we can
        depend on and 3) textboxes are implemented using a pair of draw+fly
        formats.
        
        Change-Id: Ia03f0ec70cf67626660349accc63770fe2afef5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140688
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-28  Noel Grandin  <noelgrandin@gmail.com>  [ada3cf7a8392c59932fc339357cda9c3dda5c33f]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I1157df373fd1462dc44b3828ec4de667fcdc02bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [949f0fca3cbe3d80c4aaebe6b7d7f4a8beb2fc13]

        use more string_view in framework
        
        Change-Id: I9a79eef6d41696f1de7569f40d6eaf1d85ff77bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140638
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ceaff89c973953e283aa881292206c593e5f9c7c]

        use more string_view in oox
        
        Change-Id: Ib0d7015a898073d51ac2638d62a19eadcba37685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-28  Miklos Vajna  <vmiklos@collabora.com>  [3c3f41dc11957c1ee8e8e06fbf197cae28d7671b]

        CppunitTest_sw_ooxmllinks: remove not needed mustTestImportOf()
        
        All of the test files are docx files, so the stock
        SwModelTestBase::mustTestImportOf() does what we need.
        
        Change-Id: Ic1f1db76b24a94c3d5d5e65f882a7b6d0a25febf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140664
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-27  Eike Rathke  <erack@redhat.com>  [a3f0c5022dc98cdbf2723d328d97db94a67e8ecd]

        Replace dead langtag.net reference link with Wikipedia and W3C
        
        Change-Id: Ic62f0f2ed9d4e4c7b6e026ec879830cbdb5338cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140663
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [8361df4cf3728ef5e98b6c95a06a4bc829c8fd44]

        tdf#151187 don't check glyph substitute positions
        
        to see if they can be perfectly round tripped back to original
        application provided positions. This may have already served its purpose
        that there aren't unexpected gotchas and could be retired.
        
        Change-Id: Id30d00d0c1649c5d80d43b57887a6e6cfa8fb5be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Justin Luth  <justin.luth@collabora.com>  [27c22bac5439908ecdd1aa05580d75998a5eb058]

        tdf#123990 sc condition: use GetTransliteration, not GetCollator
        
        Thanks Eike
        
        Eike said "This should not use collation (which should only be used
        in sorting context) but ignore case transliteration instead."
        
        I had just copied ancient code from
        commit 952c2b02c73b30b011306faf2f0d6f2b4a935955
        Author: Eike Rathke on Date:   Wed Mar 14 14:57:39 2001 +0000
            use CollatorWrapper instead of International
        
        Apparently that code should also be changed
        in a follow-up commit.
        
        Interestingly, a \x000 - \x008 etc must be isEqual(""),
        so an attempt to ScGlobal::getCharClass().lowercase
        all variables at the beginning and use regular OUString
        comparisons didn't work.
        
        Also, a "" startsWith and endsWith each string.
        In Excel, a "" is also contained in every string,
        but not (yet) in Calc.
        
        Change-Id: I44a07c482d2d67a76a939ba2d593a003398d52c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140633
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-27  Michael Stahl  <michael.stahl@allotropia.de>  [70973680f05c587c866d2de2a16bff9ebf8007ca]

        sw: fix inserting fields between 2 adjacent input fields
        
        Primarily this is achieved by using GetTextAttrMode PARENT in
        SwCursorShell::CursorInsideInputField() and
        SwCursorShell::PosInsideInputField().
        
        But this requires some refactoring to make this parameter available.
        
        Change-Id: I1a0ef4e3d93a6733d972544abfe07ddf929eb62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140661
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-27  Michael Stahl  <michael.stahl@allotropia.de>  [85d099bd3680d517f1a76faf3eb720a9cb8e140f]

        sw: SwFieldDlg disable Insert button if shell cursor is in input field
        
        Lots of content including fields cannot be inserted into an input field,
        and if there is already a selection when clicking the insert button, the
        selection will be deleted but then inserting the field will fail.
        
        Just disable the button, as is already done if the cursor is in a
        protected section.
        
        Change-Id: Ib01cf378441582668a9dd4c76900062b906ff09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140660
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-27  Stephan Bergmann  <sbergman@redhat.com>  [5c425ca13001ddd64b3f6fd4dde8af7468bc37c8]

        Revert some string_view pessimization
        
        This reverts the configmgr part of 0a7eac8576f313dcaf27ee45326d71fd6b5aea1e "use
        more string_view in accessibility..configmgr":  All calls to Data::parseSegment
        (either directly, or indirectly either via Access::getSubChild or via
        parseSegment in partial.cxx) pass in an OUString path, and in some cases (see
        below)
        
        >         *name = path.substr(index, i - index);
        
        in Data::parseSegment reconstructs an OUString from the full path (i.e.,
        index == 0 and i == path.size()).  And I see no code that actually benefited
        from the switch to string_view.
        
        One example call stack for such an expensive reconstruction of an OUString from
        full path is
        
        > #0 in configmgr::Data::parseSegment(path=u"ooSetupSystemLocale", index=0, name=0x7ffff5299280, setElement=0x7ffff52992a0, templateName=0x7ffff52992b0) in core/configmgr/source/data.cxx
        > #1 in configmgr::Access::getSubChild(this=0x619000028f80, path=u"ooSetupSystemLocale") in core/configmgr/source/access.cxx
        > #2 in configmgr::Access::getByHierarchicalName(this=0x619000028f80, aName="ooSetupSystemLocale") in core/configmgr/source/access.cxx
        > #3 in utl::ConfigItem::GetProperties(xHierarchyAccess=uno::Reference to (configmgr::RootAccess *) 0x619000028fb8, rNames=uno::Sequence of length 6 = {...}, bAllLocales=false) in core/unotools/source/config/configitem.cxx
        > #4 in utl::ConfigItem::GetProperties(this=0x61100000cad0, rNames=uno::Sequence of length 6 = {...}) in core/unotools/source/config/configitem.cxx
        > #5 in SvtSysLocaleOptions_Impl::SvtSysLocaleOptions_Impl(this=0x61100000cad0) in core/unotools/source/config/syslocaleoptions.cxx
        [...]
        
        Change-Id: I51127d82aea927dd9aaf374880c406dbafaddcde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140658
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f3879db3dcf3dcbeeaf712aa1a55c257c33aa0f]

        Fix typo
        
        Change-Id: I269be7184ceeb34fd6d0c4e0311f7b4d5758e382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140643
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [1f09bf7bee753d34953fcefd6e2ee05797bf4b0a]

        crashtesting: assert on converting ooo64499-3.sxc to ods
        
        a problem since:
        
        commit 776ea34deefe7bdce2fb8a06e5c55ef27ec87ea7
        Date:   Wed Sep 21 11:09:46 2022 +0200
        
            use more string_view in xmloff
        
        Change-Id: Ifec0f4c84373aa4501acfde2fd357fd749f836c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140654
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Andras Timar  <andras.timar@collabora.com>  [fe9390fcfbadfce119a3dd8e2ed676f35c737098]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e01f85525f194ed75ae25eae6e7061efd32e147
          - remove empty paragraphs
            
            Change-Id: I42a12141e42c286e2d3398e8d05d19567ea0ca03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140652
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-27  Miklos Vajna  <vmiklos@collabora.com>  [a825e23a2980fcb3d970834c4ce1f8403fb93054]

        DOCX export: fix not-well-formed XML when hyperlink end is a textbox anchor
        
        We failed to save a document which contained anchored text and the
        anchor position was inside a hyperlink.
        
        The problem was that the hyperlink covered content which has anchored
        text, so when the text inside the shape ended its paragraph, it wanted
        to finish the hyperlink that was started outside the shape, which is not
        well-formed XML. This was a problem since
        7246e57216bb20c15af0ecf6a0183f5ffa81e780 (tdf#143591 DOCX import: handle
        anchored objects as at-char, 2021-09-20), previously we lost the
        character position of such anchor positions, so in practice this problem
        was not visible.
        
        Fix this similarly how we stash away the current state when entering a
        table cell: just save / restore the number of hyperlinks we have to
        close, that'll close the hyperlink outside the shape.
        
        Note that the source document has the hyperlink outside the shape's
        anchor, while we include the shape inside the hyperlink, but that
        doesn't cause problems in practice.
        
        Change-Id: I711fad2336fd78e2ba709c3fc0a4f75de32aae8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140650
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [7c2f8a1676c36e3045588e52545fb25062076dae]

        tdf#151071 Revise Sifr (Pivot Table, Table actions, autowizard etc)
        
        Change-Id: I9eb241b96a3160b4d4a17f7f6b7b454d0b63e916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140634
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [cd4f1eb7237d045d448be75933b4e94695ccd580]

        sufficient at this point to silently allow MissingJustBullet
        
        to not assert that there are unexpected glyph substitutions
        
        Change-Id: Ie4231c84fc1a509f86eac4242270c9e496bf7e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [f0c2719baadee4b2b315d61d39ce35bfbddfffcc]

        tdf#150916 make unselect in combobox dropdown same as initially unselected
        
        a similar issue as seen in tdf#148197
        
        Change-Id: I3848fe7b48f6148a5ae13d484c866953fed83c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140647
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [f725629a6241ec064770c28957f11d306c18f130]

        use more string_view in filter
        
        Change-Id: I75c98f1da8898840bb882c17c7f1e59ec11ae8af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [97eccc5d55d8786f91c88a0f3de36640c112e68e]

        use more string_view in cui,extensions
        
        Change-Id: I76253ae06af53f63206a47a84035317c6a5058b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140637
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6bf58503dda832bad97b262e4feed633fdd4853]

        use more string_view in package
        
        Change-Id: Ia38b2784222701d669f244523ce9a27c4068c5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140639
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a7eac8576f313dcaf27ee45326d71fd6b5aea1e]

        use more string_view in accessibility..configmgr
        
        Change-Id: Ie16d36faac7d06e275348ed68e6c6b2518534fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140636
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Stephan Bergmann  <sbergman@redhat.com>  [322ea272bba63ba779120ca5ead4a4b40d1bb93f]

        Fix some headless window sizes on Windows, to make `make check` more reliable
        
        ...by making it more resilient against varying screen sizes.  On my 2560x1600
        Windows laptop, three `make check` tests systematically failed, and apparently
        all of them were caused by that larger-than-average screen (similar to what has
        been detailed in the commit message of 3db6a93c558c55eed085b4386228f9951bb08936
        "Compute a better GetDefaultCenterPos"):
        
        * CppunitTest_sw_layoutwriter
        > test/source/xmltesttools.cxx:191:testTdf134298::TestBody
        > equality assertion failed
        > - Expected: 2
        > - Actual  : 3
        > - In <>, XPath '/root/page' number of nodes is incorrect
        
        * CppunitTest_sw_ooxmlexport12
        > sw/qa/extras/ooxmlexport/ooxmlexport12.cxx:526:testObjectCrossReference::TestBody
        > equality assertion failed
        > - Expected: Text 2
        > - Actual  : 2
        
        * CppunitTest_sw_uiwriter2
        > sw/qa/extras/uiwriter/uiwriter2.cxx:2702:testTdf122942::TestBody
        > equality assertion failed
        > - Expected: 2
        > - Actual  : 1
        
        Those tests are all run with both SAL_USE_VCLPLUGIN=svp and --headless.  But svp
        is only present on Linux and is thus ignored on Windows.  And --headless, while
        preventing any windows from actually being shown, nevertheless uses the GUI code
        to set up window sizes.  So the idea here is to hack the Windows backend in
        strategic places so that it uses "appropriate" window sizes in --headless mode
        to make `make check` succeed.
        
        The Linux svp backend has a single place in vcl/headless/svpframe.cxx where it
        hardcodes the number of monitors to 1 and the screen size to 1024x768.  However,
        for the Windows backend, code determining and using those values is somewhat
        spread, but it turned out that there is one strategic place in
        ImplSalGetWorkArea that does what we want (without touching the reported number
        of monitors at all), without (it appears) negatively affecting other scenarios.
        
        (It appears that macOS, also not supporting an svp backend, is similarly
        affected.  But it looks harder there to come up with such a strategic place to
        hardcode --headless window sizes, and at least my own macOS build's `make check`
        is unaffected as I use a default scaled 1829x1080 screen resolution there
        instead of the "raw" 3840x2160.)
        
        Change-Id: I822241f81497b9f6bed8e9688eddbe7d798c6b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140588
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-27  Khaled Hosny  <khaled@aliftype.com>  [694f8eb1f79ff28a45682c77d7bb88ad9197025b]

        tdf#144348: Remove EmojiOne Color font
        
        The EmojiFont setting is now a comma-separated list of the three common
        color emoji fonts, it should fallback to the next font if the first is
        missing.
        
        Change-Id: I7aa134f914ab829704e9b707f511f166a81a0089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140623
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-27  Mike Kaganski  <mike.kaganski@collabora.com>  [093143c5754ea1f8ec5e886468e124547ec5e21a]

        Reduce number of static objects a bit
        
        Change-Id: I80f0e8edeb4aa0b6a2179745ae9eda37cac278d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140641
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [5d48602bfc2083294fc7d6a370bae4ce689be59e]

        crashtesting: crash in DocxAttributeOutput::TableCellProperties
        
        on converting ooo59560-1.sxw to docx
        
        Change-Id: I616b254c83ae168806f08a80c07b14de696cc87b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Caolán McNamara  <caolanm@redhat.com>  [2aa3d771f157c60cee3fba867aa5c2ed40258536]

        cid#1500540 use check_after_deref instead of reverse_inull
        
        Change-Id: I9f33d2681865b4a8200549b962d76f5babedfa3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140593
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-27  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [49279212597db3993e1f8f1f70be873a2e22fe2f]

        rtl uuid : remove useless endian conversion
        
        Change-Id: I65a4dad0aceb83f2449c86c438cb478937c8b90a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138229
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-27  Mike Kaganski  <mike.kaganski@collabora.com>  [8623ce7cc634574f3f1294bc855ecd8dd32d661a]

        A bit of cosmetics
        
        Change-Id: If7440ea4e99ce33948a1c040f9f0345b18d18c42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140635
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-27  Miklos Vajna  <vmiklos@collabora.com>  [f01d7029601f01b591f8b36fb19d7c46742da880]

        sw: document SwDropCapsDlg
        
        It works with the current view in the SwDropCapsPage ctor, which is a
        bit poor, probably could figure out the relevant view via the parent it
        gets.
        
        Change-Id: Idc7641e1c56c6fbe2038115573db76b28c0375e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140626
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1026527a517fbdf35392d97f89b470a02d2e40e0]

        use more string_view in dbaccess
        
        Change-Id: Id0b41d57015e8e2542b47d3a09ca8f13d090dbca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [23a7bdecee5278673a7c79286fb3faea553a85b2]

        use more string_view in connectivity
        
        Change-Id: I313fe10ce3166a0cd96ae0a98e571fd4356da3b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-27  Eike Rathke  <erack@redhat.com>  [0d3dd0aa54ad792f91d0905f3d46c13df3512d89]

        Prevent erroneous fraction detection of not yet accepted date
        
        May had happened if the locale's date separator is not '/' but a
        preset format uses it (for example DD/MM/YYYY) and the locale's
        date acceptance patterns do not contain D/M/Y so the first '/' did
        not already lead to a possible date before a match against the
        format is to be tried.
        
        Change-Id: I7f91130da52564496a2b1369741328236dde10e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140632
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [55219f771cd4e255a079cb4272f640807c805e0f]

        Fix typo
        
        Change-Id: I0a2bab10b739a5e2462f53826cc77dd25abd9959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140625
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [920ca8c8eea0ccd40f42d3d72a3c43f59e6373e8]

        Fix typo
        
        Change-Id: Ib35b1ce171e655e2dfbca2ed996b7e212813b8f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140622
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-26  Miklos Vajna  <vmiklos@collabora.com>  [92259b092e7271a638c2f88d7565983dfe49f0b1]

        sw HTML export: fix PNG export of Writer images containing metafiles
        
        We attempted to export SVM metafiles as SVM+PNG, but then the SVM was
        turned into GIF. A GIF+PNG pair is not useful, just write PNG.
        
        This is similar to commit c8a9396e5695675ffe92935a9ba40354fc76ed79 (sw
        XHTML / reqif export: fix PNG export of shapes, 2021-06-03), which did
        the same for non-SdrGrafObj shapes.
        
        Change-Id: I1a0ab266473787d263573b4813dc19426e272435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140619
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-26  galjit  <qmebic1975@gmail.com>  [298588598af246250a89baa492fade686c8df270]

        Related tdf#132398 - Remove Hicolor Assets for Future Revamping
        
        - Removed all 32x/64x/128x/256x/512x/1024x svgs as their corresponding pngs can be created by using the svgs found in scalables directory
        
        - Removed 22x22 assets as they were used only within KDE apps but KDE has its own LibreOffice 22x22 icons anyway
        
        - Moved extensions.svg as it was probably misplaced
        
        - Removed math.png that was not meant to be in a mimetypes directory
        
        - Renamed 1024x1024 to 512x512@2x (for HiDPI) directory as 1024x1024 is not a standard hicolor directory
        
        Change-Id: I6fe333abb5de6d403e43fc4aa5c7c2a1326c4250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139715
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-09-26  Caolán McNamara  <caolanm@redhat.com>  [b98c6e213fa8cbae54c63ce30e7c07cca73b8860]

        crashtesting: don't assert on bogus font name in embedded ttf
        
        seen with kde156448-1.pdf, fontforge also warns about the fontname.
        Looks like the name starts in little endian (wrong) before switching
        to big endian and/or is initially out by one.
        
        䄀爀椀愀氀-BoldItalic
        should have been
        Arial-BoldItalic
        
        Change-Id: I4cd9f8bc6bc70d6e9a91c24801629ba140a3b675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [995d17697d1e46f66df67ca3132369d76caea29e]

        tdf#117173 wina11y: Send EVENT_SYSTEM_ALERT when notification shows
        
        Together with
        Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6
        ("tdf#119788 tdf#117173 add accessibility NOTIFICATION role")
        and Change-Id Id62b3942dc17c3a1ed6a08d23438406e5a19c39d
        ("tdf#117173 a11y: Send SHOWING state change event on
         Window{Show,Hide}"), this makes NVDA announce the notification
        in the Search and Replace dialog as an alert, similar
        to what browsers do e.g. in the alert on empty input
        for the input validation example at
        https://www.w3.org/WAI/tutorials/forms/validation/ .
        
        Change-Id: I3263df4711f84a6dd9e178aaaaad340b128aa074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140091
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-26  Michael Weghorn  <m.weghorn@posteo.de>  [c26d6cc3c4878d356328a538b5bf11e4e6a0e7dc]

        tdf#117173 a11y: Send SHOWING state change event on Window{Show,Hide}
        
        When a `vcl::Window` becomes visible, `Window::ImplSetReallyVisible`
        calls the registered event listeners with a
        `VclEventId::WindowShow` event. Likewise, a
        `VclEventId::WindowHide` events is sent in
        `Window::ImplResetReallyVisible` when the window
        is no longer visible.
        
        Handle that event in `VCLXAccessibleComponent` by
        sending a state change event for the SHOWING state,
        so assistive technology gets notified about this.
        (Similar handling can already be found e.g. in
        `AccessibleTabBar::ProcessWindowEvent` or
        `AccessibleTabBarPageList::ProcessWindowEvent`.)
        
        While doing so in `VCLXAccessibleComponent::ProcessWindowEvent`
        for the object itself would generally seem like a more straightforward
        and conceptually nicer approach, this would have the problem
        that the event wouldn't get propagated to the platform-specific
        a11y integration layer (like winaccessibility) for the
        `VclEventId::WindowShow` case, since the a11y event
        listeners are registered and unregistered as a response to the CHILD
        event (at least for winaccessibility and gtk3, qt6 doesn't do that
        (yet?)), and if the accessible event listener is not (yet) registered,
        the event is simply ignored.
        Since the CHILD event is sent in
        `VCLXAccessibleComponent::ProcessChildWindowEvent` and that gets
        called on the parent *after* `VCLXAccessibleComponent::ProcessWindowEvent`
        gets called for the object that became shown/hidden
        (s. `Window::CallEventListeners`), also send the state change
        event for the SHOWING state of the child from there, so the
        proper order can be made sure.
        
        The reverse order (first the state change event for the SHOWING
        state, then the CHILD event which results in removal of the a11y
        event listeners) is used for the case where the window gets
        hidden.
        
        In combination with
        Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6
        ("tdf#119788 tdf#117173 add atk notification role") and
        commit 155e8b1683f10847ff18e75287e2466220242bb1
        ("tdf#117173: qt a11y: Forward changes to SHOWING state"),
        this makes Orca announce the label with notification role
        in the Search and Replace dialog for the qt6
        VCL plugin as well.
        
        The gtk3 case already works with just
        Change-Id Ifcf9304883e2e824ea1b7998d7767e474b87c8b6
        ("tdf#119788 tdf#117173 add atk notification role") in place,
        because that one uses native gtk widgets in the Search and Replace
        dialog, and the Gtk library then takes care of sending the
        object:state-changed:showing event when the label
        with notification role gets shown.
        
        Side note: There are also comments that suggest to rework
        the a11y event handling for the show/hide changes
        more fundamentally, e.g. this comment in
        `Window::ImplSetReallyVisible`:
        
            // the SHOW/HIDE events serve as indicators to send child creation/destroy events to the access bridge.
            // For this, the data member of the event must not be NULL.
            // Previously, we did this in Window::Show, but there some events got lost in certain situations. Now
            // we're doing it when the visibility really changes
            if( bBecameReallyVisible && ImplIsAccessibleCandidate() )
                CallEventListeners( VclEventId::WindowShow, this );
                // TODO. It's kind of a hack that we're re-using the VclEventId::WindowShow. Normally, we should
                // introduce another event which explicitly triggers the Accessibility implementations.
        
        Similar ones can be found in `Window::ImplResetReallyVisible`
        and `Window::Show`.
        
        Change-Id: Id62b3942dc17c3a1ed6a08d23438406e5a19c39d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139813
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [d8789d175af75e7768e601662619b116e9780937]

        tdf#151143 Fix the size of Template Manager in ListView mode
        
        A previous patch (410bff99a708371eed6a82677b44e2151a4a990a) fixed the size of the ThumbnailView in the Template Manager.
        
        However it did not fix the size in ListView mode. So when the Template Manager opened in ListView, the height of the ListView the same as the number of available styles (rows in the list). The problem was most noticeable in Draw, which has just one template, but it actually affected all modules.
        
        This patch fixes this issue in ListView.
        
        Change-Id: Id6bf00b63e276b057ee191b191f57f295e9801cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140502
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-09-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [749573bfce08879587b4bd0c2cfeb6eada4c9912]

        use more string_view in sfx2
        
        Change-Id: Idf80ebfe6fb72c4b61eca15a4aee5da7621ffa48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140591
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9e044f04ac11b76b9a3dac575f4e9155b67490e]

        use more string_view in chart2
        
        Change-Id: I2afe0b5f82d1704a29bc80a969ee099eec90d3a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140590
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b419eb4bd407c26ee813a347fdf14424908379e1]

        crashtesting: forum-de2-1635.ods
        
        regression from
            commit b52fd544b9c128d3e28de6355286f6480b618e93
            Date:   Tue Sep 20 15:48:38 2022 +0200
            avoid some string refcounting with sheets with lots of conditional
        formatting
        
        Change-Id: If1414221aef0b227200cfb6ffb8e87abb48a90c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [fbc2e86a97c6499537f6054e7eabf1c96d3d975f]

        uitest: sc: check 'all' button in autofilter
        
        Change-Id: I9a64701446512178cc8deda64f94c293d939ec3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140592
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-26  Stephan Bergmann  <sbergman@redhat.com>  [92166dba58980fddb234cd7069694cbbca69a8f7]

        Add some missing @since tags
        
        ...for constants introduced with 4917430c1c5e8105987e81d65d31df21955ad60e
        "tdf#116542 a11y: introduce STATIC role" and
        947fe0d89dee75ee43515ef7dfb43837d65a45bc "tdf#119788 tdf#117173 add
        accessibility NOTIFICATION role", resp.
        
        Change-Id: I1533f3bfcac5e7014078dd891dc05571f1186bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140587
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-26  Szymon Kłos  <szymon.klos@collabora.com>  [cd0e3d61f2285b81d9c2bd8fa3d12e0deb505681]

        lok: create sidebar on demand
        
        Change-Id: I5393bba647aa4667643262e77acc6b6873afb571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139729
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140580
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-09-26  Szymon Kłos  <szymon.klos@collabora.com>  [db106346a9797565e406cf9c26e762327446f59a]

        jsdialog: send action not update for spin button value
        
        This will help us to reduce payload and fix bug where
        in Chrome regenerated spin field always focused "arrow
        down" button after click on the "arrow up".
        
        Use value from formatter - the same as generated in
        widget update JSON.
        
        Change-Id: I6ace90eb532e894daacb563bc9fb93332fd755ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138700
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140579
        Tested-by: Jenkins

2022-09-26  Szymon Kłos  <szymon.klos@collabora.com>  [c4c664e1413b9d4f830a994ee9fa44c1b002f45f]

        Be sure the number format dialog content is in correct place
        
        - use special container for content which is always above
          action area (place where ok/cancel buttons are)
        
        Change-Id: I53dea3d98e7c74d0b571fdc8a35932deb48a8ad6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138668
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140578
        Tested-by: Jenkins

2022-09-26  Szymon Kłos  <szymon.klos@collabora.com>  [f3b73cce60a440db584b5774319bba6d00bd94c0]

        android: add Grammar Checker component to native-code.py
        
        Change-Id: I87e6e74393d387beb254291e668ca7eb56e5370b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136823
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140577
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-09-26  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a96c9d7c5bb1ca6eaf72da49e29489f0f0ab1545]

        tdf#151104 correct missing ColorModification
        
        Presentation still uses Metafiles as transfer for
        Graphic content, so uses VclMetafileProcessor2D.
        Unfortunately processPolyPolygonGraphicPrimitive2D
        does not support an active BColorModifierStack,
        so use the default as working fallback to create
        correct GraphicData for the Metafile.
        
        Change-Id: Ia439b241cb414667263ef653b507ad8b7fecde61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140550
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-26  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b89a5eef6daa23c27265f7451ec617dfedd2ce67]

        introduce sw::SectionHidden as plain SfxHint
        
        Change-Id: I7412c16d0ffd4cf38a1b4186f81703443cdf6fbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140576
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-26  Miklos Vajna  <vmiklos@collabora.com>  [f7c88bacd214394fff3826b6ab759285f3411f56]

        sw: prefix members of SwInsTableDlg, SwRenameXNamedDlg, SwSaveLabelDlg ...
        
        ... and SwSectionPropertyTabDialog
        
        See tdf#94879 for motivation.
        
        Change-Id: Id622c7880e978e1631d235a8fe04cb2976bbcd2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140583
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-26  Miklos Vajna  <vmiklos@collabora.com>  [a974bccd06ac6c7081256d32d2372ea05b253fbb]

        tdf#150762 RTF import: fix missing left margin on numbered paragraph
        
        The bugdoc has a numbered paragraph with a custom left margin, but this
        left margin is missing in Writer.
        
        This went wrong in commit 61b7034824dead1635f9e9c6ec996297e10f6910
        (tdf#104016 RTF import: deduplicate before text indent from numbering,
        2017-12-05), and now it's broken because the numbering properties are
        applied before paragraph properties in the DOCX case, but the RTF
        tokenizer didn't do this ordering.
        
        This behavior of sw core somewhat makes sense, users expect the margins
        from direct formatting to go away if you apply a new numbering. So fix
        the problem by tweaking the RTF tokenizer to emit the numbering tokens
        first and only then the paragraph tokens, which is an order that's
        closer to the working DOCX tokenizer.
        
        This only affects the old (WW6-style) paragraph numbering markup, not
        the newer (WW8-style) numbering markup.
        
        Change-Id: I39698f57684d47c03ea4848fc8eb6b2e855c4fbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140584
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-26  Khaled Hosny  <khaled@aliftype.com>  [6de6231fa9266b64aac87ee3415e4855bbaeec4e]

        tdf#150726: Fix previous fix
        
        Fix regression from:
        
        commit 092e37a284ea8b8bc1e8dabbbeb001c98012a996
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Sun Sep 25 11:37:05 2022 +0200
        
            tdf#150726: Pass full string to DrawTextArray() when drawing bullet
        
        Since we are no longer copying the string, we need to use the actual
        rInf.GetIdx() here as well.
        
        Change-Id: Ic68593407cb313785c9d734e4a3a3687e2ba4eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140582
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-26  Jim Raykowski  <raykowj@gmail.com>  [947fe0d89dee75ee43515ef7dfb43837d65a45bc]

        tdf#119788 tdf#117173 add accessibility NOTIFICATION role
        
        and use it to make screen readers announce notifications from the
        'Find and Replace' dialog
        
        Change-Id: Ifcf9304883e2e824ea1b7998d7767e474b87c8b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139709
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a6abe4a33568d87904fd49c734af4726878af421]

        tdf#151071 Revise Sifr (Sheet, wizard etc)
        
        Change-Id: Ieeb1513ad2ddeca022180e9dc8e7c37b647fa59a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140581
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-26  Hossein  <hossein@libreoffice.org>  [d3050ff4a1355f7ebd3d4e7ddc8fb64f2b8894dd]

        Use Markdown instead of reStructuredText
        
        Use Markdown markup instead of reStructuredText for
        uitest/packaging/README.rst
        
        Change from reStructuredText to Markdown in setup.py is done according
        to this guide:
        
        Making a PyPI-friendly README
        https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/
        
        Change-Id: I12cbde53518d7ceadec034827d8cb00380df1547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138555
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ca78fe4dc72a4cd3737e4da9af888783d52285c7]

        tdf#151071 Revise Sifr including RoK locale icons
        
        Change-Id: Id3f4d32b0d801038f9dc49a1fb5633867ddb8634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140565
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [415bdf0c0aaa791122d5ef5f81a5409974dd646c]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I69f153abdc9789f327a7b5373560a97e90d622a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [1988782c8131d307aff14bdaf7feabd8a5bc3214]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Idc0b3c68d8f2c560868eacf5679e8a1f133cf80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [63f1484e460700b101825b8c00b87f6592d4a5d0]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I026a5480ede5e640550b39e8b030de303870cfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [eb1294a60783ceb450cefd6891d6eafa0021aadc]

        unwrap SwDelChr to plain SfxHint
        
        Change-Id: Ief37a8025181b6cc8a6e484e2726d8a8d92f57ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140567
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [b0cab944460816b96921bf4efd76e25d1cf75816]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I466640e5cf7aac57b0248e9a5069e75ccd7e779a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [16429ec437f4bf2acf33b4b2d968b45548f779b4]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I20052ec81800ce206877bc1781297e5c13fb400c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Noel Grandin  <noelgrandin@gmail.com>  [916d30ba7e8a5293f57ec04258f6c3839736295e]

        tdf#150715 Animations in LO Impress do not work properly
        
        Revert "updatePathFromSdrPathObj can just call getRange"
        This reverts commit 7c52337f9517135db13d75ecbbc10d7e26e01489.
        
        Not sure why this change did not work.
        
        Change-Id: I2c42b9b7ff4b85f3018bea289efd3d934dbe2be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-25  Eike Rathke  <erack@redhat.com>  [7dca847f07c57591d20b6a2c618bfd8bfe62a09f]

        Resolves: tdf#151165 Function Wizard: ISODD()/ISEVEN() truncate to integer
        
        Change-Id: I73d06c6c40ac33f59cf38218b3e696de9aeb0b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140569
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-25  Liu Hao  <ianahao331@gmail.com>  [f65ca3470ea2ede39314668348607dd061d003fe]

        tdf#150409 CJK&CTL properties shouldn't be hidden in Style Inspector
        
        Change-Id: I577e4c90eb000e3f55f5be9e14132a4c1d16fe9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138755
        Tested-by: خالد حسني <khaled@aliftype.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-25  Laurent Balland  <laurent.balland@mailo.fr>  [567b4281b96f56ce48d3feb57522255b06816f9b]

        tdf#139962 make shellnew files 0-bytes
        
        To use implementation of tdf#139991, shellnew/soffice.* are now 0-bytes
        files
        
        Change-Id: Ifa5c02c6903d1d505a882cbe0951e4d5c10720f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140538
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-25  Mike Kaganski  <mike.kaganski@collabora.com>  [c8ced26b479bc42cf316a7351793438f663f6fc0]

        Some simplification
        
        Change-Id: I7b455d1cb33bba2b3f2dfb3f469639519cd3076d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140552
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-25  Khaled Hosny  <khaled@aliftype.com>  [092e37a284ea8b8bc1e8dabbbeb001c98012a996]

        tdf#150726: Pass full string to DrawTextArray() when drawing bullet
        
        When drawing bullets for spaces, we were passing a substring to
        DrawTextArray() and even taking care of adding an extra character to
        both sides to help with Arabic layout. This, however, does not work when
        part of the text is in different color because the portion will cover
        only that substring and we wouldn’t be passing enough context.
        
        Copying the substring is unnecessary, though, and we can pass the full
        string like we do in the non-bullet case. The bullet array (where we
        replace spaces with bullets), can continue to be a substring as we are
        only drawing the bullets in this case.
        
        This probably also means we can re-use the glyph cache when switching
        between bullet and non-bullet mode.
        
        Change-Id: I256ae7b6d592b8c6670d66619e428f943714be57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140568
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-25  Michael Weghorn  <m.weghorn@posteo.de>  [aa0a39f2be0cf9d633c3654babc6f738d67f871f]

        a11y: Use FontSlant for "CharPosture"
        
        The platform a11y integration code expects a
        `FontSlant` in the "CharPosture" `Any`
        (s. e.g. `get_style_value`/`FontSlant2Style`
        in `vcl/unx/gtk3/a11y/atktextattributes.cxx`
        or `QtAccessibleWidget::attributes`)
        and that's also what e.g. Writer sets for that attribute
        for text in the document, so do the same in
        `CharacterAttributesHelper::CharacterAttributesHelper`.
        
        After handling for "CharPosture" was added for
        the Qt-based VCL plugins in
        
            commit 99841da686625428b8ad2e219dd19e5fbfb145f5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Jul 20 13:23:21 2021 +0200
        
                qt a11y: Report font style text attribute (e.g. italic)
        
        , clicking through the a11y hierarchy of e.g. Writer's
        "Page Style" dialog in Accerciser's treeview of the LO a11y
        hierarchy would otherwise crash LO when used with the qt6 VCL
        plugin.
        
        With this in place, the style is reported correctly
        there. (Tested by temporarily setting "oblique"
        style using glade for the "Next style" label in the "Organizer"
        tab in that dialog's UI file.)
        
        Change-Id: Ibea42db067e0cdb3b85c80dbcca5939b3dfe5570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140527
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6f3532f6aaafb6ad58a9e32dc0eff43a0d54862b]

        tdf#151012 - Initialize optional parameters with their default values
        
        Change-Id: I3ed3eb904b50892e5946abe684e801819ba296e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140128
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-09-25  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [2aed71fa9e8a36ff2dc9f48897092c26ab89ea9e]

        tdf#144939: fix chapter numbering updates
        
        Change-Id: Icd29a380663a1c5f70e3a8ee86db64ec4eae8d86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140558
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-25  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [eea9f1ee27db98617871b9ecf80e9b3a62a4e723]

        unwrap SwInsText to a plain SfxHint
        
        - also add some constnesss and move some things to private
        
        Change-Id: I67a45e1326361b5a8f7e320b3525e74e93b1ef12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140556
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-25  Khaled Hosny  <khaled@aliftype.com>  [79152891824581ad765dc8518150027c417bb9a2]

        tdf#83581: Improve caret travelling in in Edit Engine
        
        This uses the same caret positioning array introduced in:
        
        commit 8cb4db941f91cc234dd18c61f8b1e51f65360d1f
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Fri Aug 26 22:20:55 2022 +0200
        
            tdf#30731: Improve caret travelling in Writer
        
        But unlike the Writer change, this is used unconditionally not only when
        calculating caret (cursor) position. This might break something, so lets
        find out.
        
        Change-Id: Ia285197b7ee41f01ccd37101436be86b476c0272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140557
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-24  Khaled Hosny  <khaled@aliftype.com>  [943177e0f8074753db25d9a56d15f8010a755ffc]

        tdf#151114: Fix swapped width and height
        
        Regression from:
        commit 0483fbd1d05d74c394d9274bdee77b3b2aebb495
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Sun Aug 21 01:49:57 2022 +0200
        
            tdf#87535: Preview styles using CTL/CJK fonts in the sidebar
        
        Change-Id: I9108e2efa75eafe56c3ccc8ec2fff81b8cf7dc4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140551
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [a8662358b5babc8871dd604480b35cbd91caf1d2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b31c5d3344f617a0f38703da0af935c2a8803bcb
          - tdf#149221 Create target for Dialog Wizard help page
            
            Change-Id: I868d1aea648d133440c54c8cfb46014467fdfcb1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140328
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [8ed50c16a459f18d9beb036928a100d4569968b5]

        improve usage of TempFile in SVGExport
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: I1c239c90901af4450ba10e0d1505bb982cdce41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [aace38f9bf702ecbe8de7cafc0979754eaa178c1]

        unwrap SwDelText to a plain SfxHint
        
        Change-Id: I559f8f1e837830426e820dace6226618c5e0fc62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140210
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bd19c634c631c07717ba877053c0a57ec2840d77]

        Fix typo
        
        Change-Id: I7a275e86ba0c9c07144b71a1d5d7c01eb378f416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140539
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-24  Khaled Hosny  <khaled@aliftype.com>  [9e654aaaaa9ed8e1eaf83685e2f47279f0b17ccf]

        vcl: Removed unused PrintFontInfo and support code
        
        Change-Id: I4e4d67b5ff57585a02eaba9372599e767d31229d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140549
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-24  Khaled Hosny  <khaled@aliftype.com>  [c9615dd5fb3d04db49452701bf9ded3c3e86b9e2]

        vcl: Remove unused PrintFontManager::getFontBoundingBox()
        
        Change-Id: I0aed5ec3bbab91a1fe57996a2f647b758369308c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140548
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [a0e674851896d2d8e869474db067b7698293c02a]

        use faster TempFile for font subset writing
        
        by not asking for the name or URL, we stay on the happy path,
        which is faster on Windows
        
        Change-Id: Ia333ab251fc0fc4129ad0610412c5c509914a58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140453
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Khaled Hosny  <khaled@aliftype.com>  [0d6a103aa5da6fd995acd733699708d0b24ba391]

        vcl: accept bitmap fonts in OpenTTFontFile()
        
        We never subset such fonts after:
        
        commit 77cce80bb56801acf22da2149bd597d0d7793e3b
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Thu Sep 22 23:35:12 2022 +0200
        
            vcl: tdf#121327 PDF export for bitmap color fonts
        
        But PrintFontManager::analyzeSfntFile() calls this function for
        non-subsetting uses, it probably shouldn’t since all info it should
        possibly need can come from FontConfig, but re-instate this for now.
        
        This check is very blunt and it would lead to empty fonts in PDF if we
        ever try to subset such a font, but lets clean this up later.
        
        Change-Id: I804d0244ee24a4b4e92b36efd26b376cbe40784d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140542
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-24  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [f48cb25a914902d92bd109eff86ec3b6d26ba9c3]

        Replace RES_NAME_CHANGED with an SfxHint for stronger typing
        
        Change-Id: I0bbe9dc4e10491aafcc623c2add62a246ea67d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139961
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [6367348d5ce7d85697732b549d9d8591309b8db6]

        simplify CmapSubTable
        
        use vector rather than handrolling it
        
        Change-Id: Ie160d5d60470e01434c61d80a2c7965e9126d508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140540
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Michael Stahl  <michael.stahl@allotropia.de>  [03714397c8a657a3ac451cc42ffc7578c567d081]

        solenv: gdb: unbreak MarkBasePrinter
        
        (regression from commit b1cefa026d52fad4557d10c721fe9d5e57200bd6)
        
        Also unbreak SwXTextRangePrinter, not sure why that broke.
        
        Change-Id: I4d6f640e0b8422fcf9ae84fffabc77161311eac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140522
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [222e56157c6317435088e09e52a0705bc6a1a83a]

        tdf#151148 Finding KATAKANA which has voice consonant mark wrong
        
        regression from
            commit c7551e8a46e2f9f8142aa7921a0494221ae096e8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Sep 16 10:36:48 2021 +0200
            speedup CharacterClassificationImpl::toUpper
        
        Change-Id: I0309dec3d08220b9616be185360013869598fa1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140541
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [ab1d9893bad53ae6e1400c502b648e980ca876b5]

        flattenTrueTypeTableGeneric
        
        Change-Id: I197b2f45943513af7a514c92b5896bda659adf9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Noel Grandin  <noelgrandin@gmail.com>  [af6f379ec6cd4e2c09094604005a238250a0dbf4]

        flatten TrueTypeTablePost
        
        Change-Id: Ifafd87770732dd3f461dbb6823b92796331fa683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [64e916e498ca17e27aae2017b92260712a4cdb07]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to df6900524c02966c0d115312c458c5bc3e8f6f29
          - Silence strings for translation in SF Region service
            
            The example for calling "help" with the Number2Text method cannot be translated because the number and order of options is different for each supported language.
            
            For example, in "en-US" we have the following options:
            one, two, three
            ordinal: first, second, third
            ordinal-number: 1st, 2nd, 3rd
            year: nineteen ninety-nine, two thousand, two thousand one
            currency (for example, USD): two U.S. dollars and fifty cents
            money USD: two and 50/100 U.S. dollars
            
            Whereas in "pt-BR" the options are very different (and more importantly, a different number, which totally prevents translation).
            um, dois, três
            feminine: uma, duas, três
            masculine: um, dois, três
            ordinal-feminine: primeira, segunda, terceira
            ordinal-masculine: primeiro, segundo, terceiro
            ordinal-number-feminine: 1.ª, 2.ª, 3.ª
            ordinal-number-masculine: 1.º, 2.º, 3.º
            
            Change-Id: I688de573b82ca83d714562f1acc705c23333081f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137528
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-24  Julien Nabet  <serval2412@yahoo.fr>  [45bee7678319325942664d23688367c639bdf83b]

        tdf#117764: fix context menu item "Conditional formatting"
        
        Respond to https://bugs.documentfoundation.org/show_bug.cgi?id=117764#c1
        a) the function should be *available* on "clean" cells (removed after comment in gerrit)
        b) answering "No", one would not edit the existing format, *but will edit a new format instead*
        c) answering "Yes", one would edit the existing format
        
        Change-Id: I8c578a59084c557939a853d4746efffbaf4e56e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140266
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-23  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [5895fb9dac86ecf0cca42dbbb414f69caceae52e]

        remove RES_GRAPHIC_SWAPIN, it is never created
        
        Change-Id: I9e7546d3f8bf5a3c0cefbdd3a4925467d7439856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140105
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2022-09-23  Caolán McNamara  <caolanm@redhat.com>  [e5793c64063e83cc6682e3a8691308f740fbc268]

        ofz: bump sc-rtf and html max lengths
        
        Change-Id: Ic7c596b59a420dc098ae61298d9fa048f826662c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140528
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [93e0ce447ce2e913995800d45614dfc74d80b2b5]

        Rename #define
        
        Rename SCSTR_FILTER_TEXT_COLOR_COND to SCSTR_FILTER_FONT_COLOR_COND according to UI string changes (https://gerrit.libreoffice.org/c/core/+/137087).
        
        Change-Id: I34a707e4924299fccbbb3dcd9580de100221a012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139943
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4978c106cfffa4be63f3281b84e3aa80f56c0278]

        add a SwTextNode::ReplaceText variant that takes a SwPosition
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I6eeac9861f3d170d89b78f71a45bf48dd8478c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-23  Michael Stahl  <michael.stahl@allotropia.de>  [88c41829ab99af4fb8c5e5494508c763330fef53]

        rhbz#2122948 sw: fix ODF import of fieldmark in redline
        
        The problem is that SwXText::compareRegionStarts() calls
        SwXText::CreateCursor() which creates a cursor on the last node in the
        body text, but it's actually a redline.
        
        Override SwXRedlineText::CreateCursor() to create a cursor in the
        redline text.
        
        Complete mystery why SwXText has 2 virtual functions to create
        cursors in the first place.
        
        (regression from commit 463178fef5c22f1a04d10e54491852d56e2038b0)
        
        Change-Id: I0f3bcf4eda25f1ac7e1c1b0cf47a920f8302d2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Michael Stahl  <michael.stahl@allotropia.de>  [a0a529a131c61588cf865143d47cdc23961fd596]

        xmloff: ODF import: fix crash on fdo34997-1.odt
        
        Clean up the redundant checks too, these are all called after first
        checking hasCurrentFieldCtx().
        
        (regression from 463178fef5c22f1a04d10e54491852d56e2038b0)
        
        Change-Id: Ieec848944ef576caf319d5da7dc11139a4d26c58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140514
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Stephan Bergmann  <sbergman@redhat.com>  [8cadfec386d0fb906dbe9b8ea8f918e61927e622]

        Fix utl::splitLastFromConfigurationPath
        
        * Fix regressions introduced with 5edefc801fb48559c8064003f23d22d838710ee4 "use
          more string_view in unotools".  (Notably, misuses of two-argument std
          string_view rfind are something to watch out for, see the commit message of
          93e234c45c62af9d57041de676d888f7695ac0e8 "Fix a misuse of two-argument std
          string_view rfind" for details.)
        
        * Bring the implementation some more in accordance with the documentation, by
          being stricter about handling invalid paths, and making sure to really assign
          all of the input _sInPath to the output _rsLocalName in case of an invalid
          path.
        
        * Only &...;-decode the names of set elements in ['...'] and ["..."], not
          anything else.
        
        Change-Id: If01f4b34af42b0a594994b732d54f26695329286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140493
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-23  Stephan Bergmann  <sbergman@redhat.com>  [4689f7579ac3db998bb0de07b0adbe4092d5be14]

        Add tests for utl::splitLastFromConfigurationPath
        
        ...documenting how the implementation is in discordance with the documentation
        for some corner cases and how things got recently broken with
        5edefc801fb48559c8064003f23d22d838710ee4 "use more string_view in unotools", in
        preparation for an upcoming improvement of that function's implementation
        
        Change-Id: Ia47243c64b724009c5ed5eecb9d890820287e9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140492
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-23  Mike Kaganski  <mike.kaganski@collabora.com>  [b60dc48bb48bec63b21eb9c2ef705af64d9b9069]

        tdf#151117: Process non-existent long paths correctly
        
        Regression after commit 92e835dbf00590c9c29509d2995cc7918a9bbb90
          Author Kunal Pawar <hellokunalpawar@gmail.com>
          Date   Fri Feb 18 19:15:04 2022 +0530
            tdf#98705 Replace GetCaseCorrectPathName with GetLongPathNameW
        
        The fix tries to keep the performance improvement, and when the path
        exists, it will only call GetLongPathNameW once. Anyway, for unclear
        reason, this normalization only happens on long paths.
        
        Change-Id: I1cf9a47dfc35046ec1b5eebbbcaca09edb1c471a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140516
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d991134f55b8d39b7663f571a5060c530c0a48c7]

        Removed duplicated include
        
        Change-Id: Idc57a6d048d730acf9f59c565bc7a57928eb3aa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140515
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d5e3285e998ce2426c053dbe2bdd27315af52ed]

        CppunitTest_sc_uicalc: use utf-16
        
        Change-Id: I8fcb56d42c50748b31f7737f37e1f950b83fb539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138725
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [60705295aec404b7f476dfdce3d35bf8cabb4c17]

        CppunitTest_sd_uiimpress: use utf-16
        
        Change-Id: Idd22956c1b5412d7bb02fd99fd2e3ee54284c4bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140491
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Stephan Bergmann  <sbergman@redhat.com>  [c79212479f42cadd39173e77acc5e6446480ff05]

        Fix a misuse of two-argument std string_view rfind
        
        ...similar to 93e234c45c62af9d57041de676d888f7695ac0e8 "Fix a misuse of two-
        argument std string_view rfind".  This one got introduce in
        15d8762dd07289447e782a3812dfd4425fe9a82b "use more string_view in cui".  (And if
        it wasn't for other bugs elsewhere, this code could be reached e.g. in Writer
        with "Tools - Macros - Organize Macros - Basic...", in "Macro From" select "My
        Macros - Standard - Module1" and in "Existing Macros in: Module 1" select
        "Main", then "Assign...", and this code would have miscomputed aModule as "Main"
        rather than as "Module1".)
        
        Change-Id: Id3fd66e0bd252d79af629abbbf1e38b37679de70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140490
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-23  Justin Luth  <justin.luth@collabora.com>  [3bfed17b047422a8c4e98ab80001f3158afb227e]

        tdf#123990 sc condformat: case insensitive begins/ends/contains
        
        This is how Excel handles these.
        
        At first I was afraid that this would upset LibreOffice users,
        but then I realized that equals already is case insensitive,
        so this change ought to be more consistent, and thus there should
        be fewer outcrys.
        
        Change-Id: Ia3de78d5888672ba8b774866d41ecd65293397c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140484
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [23cbe9b969db11f9fb25d8dffe8d801e002b5e94]

        Fix GraphicTest::testLoadSVGZ() on non-default DPI
        
        Change-Id: I6f6435a285e34cf27798265d9d98f15337991b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140406
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Caolán McNamara  <caolanm@redhat.com>  [abe8d06682c68c85f750d05409322a5eabc84158]

        Related: tdf#35030 hide the "reset" button more reliably
        
        otherwise it won't end up hidden if the "keyboard" tab page is the initial
        page, this handler only happens when the user switches tabs.
        
        use the newly added virtual methods to manage this instead
        
        Change-Id: I3eef6b4d7d453a5ec16ec62b2ebb558bd4757caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Justin Luth  <justin.luth@collabora.com>  [bb47ffbc9d36e83695aa0d01767d3f83533c04e0]

        tdf#46733 sw: don't double-select column during deleteCol
        
        The problem here was that under IsNewModel tables were
        selecting the entire column (including merged cells)
        and then using THAT selection to ExpandColumnSelection.
        
        Well, that ends in disaster. Since NewModel already
        expands to catch the cells that are contained inside
        the selected cells, there is no need to expand
        the selection of GetTableCell.
        
        Change-Id: I43089d912cdd17b2599619a43e40fecc2f5dd3b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140455
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-23  Caolán McNamara  <caolanm@redhat.com>  [03a970babc2df4957051af996d8a426e4d94f17d]

        rename SfxTabDialogController::ActivatePageHdlHdl contents and make virtual
        
        Change-Id: I9ba605f83a5841319770ff1a6d52fb8200486c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Stephan Bergmann  <sbergman@redhat.com>  [93e234c45c62af9d57041de676d888f7695ac0e8]

        Fix a misuse of two-argument std string_view rfind
        
        ...introduced in 655b6c2f46a73d9893ba8e6b572731a5890a4f72
        "loplugin:stringviewparam".  Unlike its O[U]String lastIndexOf(x, n)
        counterpart (which looks for the last x whose end position, exclusive, is <= n),
        string_view rfind(x, n) looks for the last x whose start position, inclusive, is
        <= n.  (So here would have left slash unchanged.)  (And the seemingly simpler
        
          jvm_dll.rfind('\\', slash - 1)
        
        would fail when slash is zero, as in that case it would call rfind with a second
        argument of npos, i.e., search for the last '\\' in the complete jvm_dll.)
        
        Change-Id: I148a5db860d4b9e9d58a4a8847880a7a7020c5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140486
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-23  Caolán McNamara  <caolanm@redhat.com>  [e14a6b3f37c0f462afcc9534c8d4a90b430a6d80]

        resave with latest glade
        
        Change-Id: I461177666d04db2250e3f9cd617551343db832b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140487
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [501b15482ebb3b34277264ba7bfd442f91c593ff]

        use more SwPosition::SetContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ie9e74ec299d59458d0fdd99f795dc2b9ff86ed32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [dcb991bbc6a1a66103b3c0fbc6e996a27e3e90b1]

        svgio: Simplify by using replaceAll
        
        Change-Id: Id805787c5b5a812c6fd4fbfe3c3b2905578ce3bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140482
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [5e6b02055a887bc49c5252c1ae359ae96947e80c]

        tdf#151118: don't trim leading/trailing spaces in 'preserve' case
        
        Thanks again to Mike Kaganski for spotting
        
        Change-Id: Ifd8dcf15d7714ebc4f19083fefe0d78d27d46b4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140483
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Miklos Vajna  <vmiklos@collabora.com>  [82b9ff35649cd67ca16296676d2ad1e4eff15493]

        sw content controls, combo box: add PDF export
        
        Map it to vcl::PDFWriter::ComboBoxWidget, which knows that this has list
        items + allows free-form user input as well.
        
        PDF 32000-1:2008 Table 230 documents those field flag bits.
        
        Change-Id: Ifb99625c2ab8792b756ad52a3f6d599507c5773f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140480
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1cfa1e7a0976dce86a8b4168119c9c6f015ff5ce]

        remove some dead code
        
        after
            commit 590796ca0866168e3129d2abd0a0197114cddcdc
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Wed Sep 21 20:44:42 2022 +0200
            convert TrueTypeTable to C++ class
        
        Change-Id: I5c656011ebe37529788cea6a749c07ada2378385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-23  Khaled Hosny  <khaled@aliftype.com>  [2e2765ec4ab05ee4745125f56b907f74e7426eaf]

        vcl: Use glyph names from the font in Type 3 fonts
        
        Some PDF viewers might use glyph names to guess corresponding character,
        and it also makes debugging the PDF output a little bit easier.
        
        Change-Id: Ibe7f28d10814a9deb467129c85fed914fb7b3f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140465
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-23  Khaled Hosny  <khaled@aliftype.com>  [77cce80bb56801acf22da2149bd597d0d7793e3b]

        vcl: tdf#121327 PDF export for bitmap color fonts
        
        This change extracts the PNG data from the sbix/CBDT tables and embeds
        them as PDF Type 3 glyphs. In case the font supports both color layers
        and color bitmaps, the color layer take priority.
        
        This also reverts the part of the following commit that allowed bitmap
        fonts when creating font subsets because this is not needed now as the
        such fonts will now not reach the subsetting code.
        
        commit dcf7792da2aa2a1ef774a124f7b21f68fff0fd15
        Author: Khaled Hosny <khaledhosny@eglug.org>
        Date:   Tue Aug 27 15:19:15 2019 +0200
        
            Make Noto Color Emoji font work on Linux
        
        Change-Id: I350ec97956f37ae574956b22712869fd6d1a6990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140457
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [bdebe856d110700d757625f121879de920b9ef46]

        tdf#151118: svg: don't replace newline with space when xml:space="default"
        
        Partially revert ddf695db44bcb23dc2f1459fd439f93c0b6d5f2a
        "tdf#151118: svg: fix handling of xml:space="preserve""
        
        See discussion in https://gerrit.libreoffice.org/c/core/+/140404
        
        Thanks to Mike Kaganski for spotting it
        
        Change-Id: Ifdd26b8de2f5cc392127f215e148599ae63036dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140444
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-23  Luboš Luňák  <l.lunak@collabora.com>  [e47e0cb0ad1dc3554e9b57f8562a217cf785edbf]

        make sure SharedString::EMPTY_STRING is interned in pools (tdf#150647)
        
        Without this, it may not actually be there, so interning "" would
        use a different string instance, and then comparing with
        SharedString::getEmptyString() would actually compare non-equal.
        
        Change-Id: I22660f63aa321e3a8f72cfb96df1db56e08fbb84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140402
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [31a8de10e8f60d79d6eb588a049567b89a48f0b1]

        curl: upgrade to release 7.85.0
        
        Fixes CVE-2022-35252
        
        Change-Id: I549240f6ae31ae94f925422517cd03ef2e3b5732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [096e2ba8e4fce64c04a7d7e842dd1dbab8699801]

        postgresql: upgrade to release 13.8
        
        Fixes CVE-2022-1552 and CVE-2022-2625.
        
        Change-Id: I4964c43fefc94f12a16c45d8727ae41cf1ce278b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Caolán McNamara  <caolanm@redhat.com>  [b3abb0052ac781d776dfad3c21368d57f727013e]

        cid#1515535 Explicit null dereferenced
        
        get length of glyf before std::move it
        
        Change-Id: If2d9a2cc533d65ef4b8e0481cf7db677bf5e4349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140472
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-23  Aron Fischer  <gerrit@aron.guru>  [52e683677a83de117e080247a0f872fd5dbc7ccd]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 9e27d044d98e65f89af8c86df722a77be827bdc8
          - Recognise umlauts typed as -e on non DE keyboard
            
            This change helps the spellchecker to find correct words if the misspelling consists of replacement of Umlauts with their vowel+e variants.
            
            The file already contains entries such as "REP ae ä" on line 519 or "REP ss ß" on line 507. This tells the checker to try first replacing ae as ä and see if that works or to try replacing ss with ß and see if that works. This will only succeed if there is a single instance in the word that needs to be replaced.
            
            The word "greetings" typed as "Gruesse" was causing me trouble as it contains both ue and ss next to each other and the REP commands do not catch this.
            
            The MAP command seems to play a somewhat similar role as REP but whereas REP deals typically with "one character mistakes", MAP just defines character sequences that are related in a language specific setting and works with multiple replacements within a single word.
            See here for details: https://www.systutorials.com/docs/linux/man/4-hunspell/
            
            In any event, I doubt it can cause harm because the character sequences that I am relating in the MAP commands are actually related in the German language, and furthermore I am not changing any spelling rules, I am just aiding in the search for correct spelling suggestions.
            
            Change-Id: I4683db860467ff6a68e96301c0ed187df1089b3c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/136067
            Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
            Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
            
2022-09-23  Miklos Vajna  <vmiklos@collabora.com>  [49f1bf56ebfa3c96aa90835c1121eb827d713b9d]

        sw content controls, combo box: add insert UI
        
        - expose the combo box case in SwWrtShell::InsertContentControl() as a
          new .uno:InsertComboBoxContentControl command
        
        - - add the new uno command to the default & MS-compatible menus
        
        Change-Id: Ifb1a9cede8c219d956ce438119ee789a69507679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140468
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-23  Stephan Bergmann  <sbergman@redhat.com>  [c3d488c201231a98ef13560dc8d070267d8d5e86]

        -Werror=class-memaccess
        
        ...since 590796ca0866168e3129d2abd0a0197114cddcdc "convert TrueTypeTable to C++
        class"
        
        Change-Id: I9c1908ba0618f5a04bc669e722ea5ad54ae217b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140471
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-23  Julien Nabet  <serval2412@yahoo.fr>  [13b0c30f1b37c044a17e26cb5e64c2e9e9367773]

        cid#1515534 invalidate_iterator
        
        Change-Id: Ib7763b2a7df858ad8749eca35d3e7518a39fad75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140470
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-23  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [2914316bcffc890887ca577d2753149c07005815]

        tdf#150551 for PDF export, use the decomposition
        
        ...for better gradient visualization, see task
        for details.
        
        Change-Id: Idccd569b0e95763f6dbf6ad0a2204b62460c66d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140354
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-23  Miklos Vajna  <vmiklos@collabora.com>  [c097ff3fb2c6a58b0217213d12e69ea7833bf06f]

        CppunitTest_sw_ww8export: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ia3fb5d9d85817d6dd1efe9973b5cc8dfcafe40ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140451
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c6c95b545b6d4bced699e6f7d9e1d9c679b893e]

        add a new SwContentNode::GoNext variant
        
        that takes a SwPosition and keeps the nNode and nContent fields there in
        sync.
        this is part of the process of hiding the internals of SwPosition.
        
        Change-Id: I1996e588703ca2400fa84e979c72cc5382e5b700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-23  Michael Weghorn  <m.weghorn@posteo.de>  [782e4502898924eb94c4ff7f6c33d9ef36959f02]

        tdf#149952 sw a11y: Don't send a11y events for internal-only cursor
        
        The fact that `SwEditWin::GetSurroundingText` etc.
        use an internal-only helper cursor is an implementation
        detail and should not result in a11y events getting sent
        from LibreOffice to the platform a11y layer.
        
        Therefore, introduce a flag to `SwCursorShell`
        that indicates whether or not sending of
        accessible cursor events is enabled and set that
        to false during the use of the helper cursors.
        
        As described in Sebastian Keller's very
        helpful analysis on what was happening on the
        gnome-shell magnifier side (s. tdf#149952 comment 11),
        sending those a11y events resulted in the
        gnome-shell magnifier jumping to the right
        when typing empty paragraphs:
        
        > Regarding the issue of jumping to the right, it looks
        > like there is a 'object:state-changed:selected' for the
        > paragraph when pressing enter multiple times. This causes the
        > magnifier to center the entire paragraph, which has the width
        > of the entire page according to the extents, so this will be
        > further to the right compared to caret.
        
        Change-Id: I514aa2dad5cfffbe5e8d4b7e9d7d383e70470b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137104
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [9940a5dce79fe9dc3e6ff0302c9be8c7d1648f67]

        use more SwPosition::AdjustContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ieaaeafdbef6cdd715d1d8610cf6094d1bbf08b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c3bc67bffd1e0b9bdd60ef274a6d5e59101d322d]

        tdf#151091 Revert "tdf#148635 cache some chart stuff"
        
        This reverts commit fd2ca9607431fc6ca49e37ab6fef228aa72da5f9,
        since it causes a regression when copying a chart.
        
        Change-Id: I5d40de6f46b4b3e68531257d27f9a81540a06da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140427
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [40a428fde0a33e7127dfa30845d65c698e408053]

        Related: tdf#151107 make "sloppy" paper fit up to 1.25pt
        
        This reverts commit 0b6d45056ab6e1c47b4ed62eedaad02249439444.
        
        Change-Id: Ifbc0e286be4ab3dffd0d66228fd1abe2dfc0fde0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Eike Rathke  <erack@redhat.com>  [10d1e6ff6b3a10b673696524ad59297f4e5a1c2c]

        Fix string length assertion and handle parentheses in multi-line formula
        
        soffice.bin: include/rtl/ustring.hxx:842: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assert ion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed.
        
        when editing a paragraph (line) longer than the first, because the
        string was always obtained from the first paragraph but the
        position from the current selection.
        
        Also match parentheses in the current paragraph, not somewhere
        else in the first paragraph.. still we're matching only within one
        paragraph.
        
        Change-Id: I955fd371c1e248ce58735a5b61603bbce6c997db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140446
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-22  Justin Luth  <jluth@mail.com>  [f24841da29adb8c0b4a8ec1b29367ee63998d440]

        crashtesting: "unknown cell text: element" assert on broken xml
        
        Three invalid files are hitting this assert.
        They had invalid XML, so I couldn't even
        xmllint --format --recover content.xml
        
        Removing the assert - it has outlived its usefulness.
        
        Change-Id: I93d6d6e1d5ce53f9dd1ee46ce3881183993827c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140447
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-22  Michael Stahl  <michael.stahl@allotropia.de>  [3acd80a030707b3c4795c0f828f953ac0ae24d97]

        tdf#150616 sw: fix bad 0 height of SwTextFrame in table cell
        
        The bugdoc has a text frame 42 immediately following a section which
        contains a nested table, both inside a table cell 29.
        
        The problem is that with soffice --convert-to pdf, the height of frame
        42 ends up as 0, after a single layout action; this does not happen when
        loading it from UI.
        
        When the frame 42 is formatted, it calculates the needed height, and
        grows, but in SwTextFrame::AdjustFrame() it doesn't fit into its upper
        cell frame with a negative nRstHeight at this point, and the text frame
        is reduced to height 0.
        
        The odd code in SwContentFrame::MakeAll() exists unchanged since CVS
        initial import and is poorly motivated. It is highly suspicious that it
        simply grows the upper frame, without invalidating the size of the
        current one (which was already shrunk), and/or clearing the
        m_bUndersized flag.
        
        If this code is removed, on formatting the next frame 43, it goes up and
        formats the cell frame, which grows and at the same time importantly
        invalidates the text frame 42, so it will be formatted again and full
        height.
        
        At the point when the frame 42 was formatted, its upper cell frame was
        size-invalid, so it looks like that will be formatted eventually in any
        case and then invalidate 42.
        
        (regression from commit e7874c936dd1ff9b3423eb7477cbee2494535176
         but unclear why)
        
        Change-Id: I1ac0999a8fda39f7717bc183a10e3b513fbb8911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140355
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [6005aeca4416eb0d583fd12ab837afa91d9d18ec]

        tdf#151107 swap job orientation if paper matching swapped width/height
        
        if we eventually are forced to pick a final paper size which has the
        orthogonal orientation than that requested, then swap the orientation of
        the jobdata too
        
        and re-init the orientation to defaults in Printer::SetPaperSizeUser
        when we set a new user paper size rather than keeping the orig
        
        Change-Id: Ie9e783575734c7f9eec3984efd1357cae5375130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140358
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [3805a4090dbbffa54bb1a9d7fe63e723fc6d029b]

        pass in bDontSwap rather than use a local static
        
        Change-Id: I8758802064476199f34d57e0937ee56cef6e0363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140429
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Mike Kaganski  <mike.kaganski@collabora.com>  [74410f8a8cb05b6313c5235ba1036ec9ee160899]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a9fed471fe915e0ad8053cf21227c5a4d8a31108
          - TRUE/FALSE are functions
            
            Samples using them as constants simply don't work
            
            Change-Id: I1cc6199fa418363b3176dd3c2f18d9cc6620957a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140385
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [e301b61fd4c5005418c5aef255c3cad424f4f72b]

        reduce excessive code repetition when matching opcode in opencl
        
        I.e. use "ugly" macros to make code more nice.
        
        Change-Id: I053dd2313c140dbc6b25073d67155a1284c6b310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140398
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [1af18947bfd0d6a9c318bfafd5c5d73c23266d45]

        drop opencl implementation of MEDIAN()
        
        Input data to this function is not required to be sorted, so implementing
        this would mean sorting it in opencl, which is not exactly trivial and
        not worth the effort. There also exist algorithms that find the median
        without sorting an array, but they work by guessing it and looping until
        their guess is right, so again, not worth the trouble. I'd say there's
        nothing to be gained here from using opencl.
        
        Change-Id: Ic6d6efdfc59b9058bdae50d07d8039db481dfb75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140397
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [e0061a955ee2efed28c1632e06e44f1318c7878d]

        remove unused or duplicated opencl helper functions
        
        These mostly exist in "old" and _new variants which are more or less
        the same, sometimes there are minor differences. Keep just the _new
        ones, everything still seems to work, all tests pass.
        
        Change-Id: I903ea3f11bad6c5e1301febe03974469eb414368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140396
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [78c6e9efa8572fb8a681f562d057db8bef35c571]

        fix handling of string arguments in opencl
        
        As one of the code comments said the code used string hashes to represent
        strings and this was a broken idea. But the basic idea of that is actually
        valid, so just implement that properly and use it only for comparing
        strings. See the code comment in opbase.cxx for technical details.
        
        Change-Id: I113d6b4d5e1e78bbe2c05aafc0572605e2595ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140395
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [87e4520fdb661309da732c25a7ad58c7efd52a90]

        fix and simplify ocInt in opencl
        
        This is what core does, it also extends the range (the casting to int
        variant limited to the range of the int, which the core variant doesn't).
        
        Change-Id: Ib93bc57b38c0927f9732742d116d0f40700a0abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140394
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [799bde0490f2bcd0562e2c9a8d08709b472417b2]

        make ocTrunc and ocRoundDown the same in opencl
        
        It's that way in core too.
        
        Change-Id: Ic1100ed637a310b8073256b95a261023b32df827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140373
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [1c1195a09e62d37ad5cd93709d7e2b72466c22b3]

        ocAnd/ocOr are not actually binary operators
        
        They are listed in the SC_OPCODE_START_BIN_OP group, but AND(A1:A30)
        is fine.
        
        Change-Id: I397d1f8dc6bff450116dd46b6b1da7ffe447efb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140372
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [9f884bc933be1bffd25ba9c7b3a3343f942ff5dc]

        add SAL_INFO about which formula group will be interpreter by opencl
        
        It's actually not said anywhere in the otherwise extensive opencl
        debug output.
        
        Change-Id: I978239d045436c05457b1c0e3e00b672889b9279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140371
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [af5aaddee5e752fcb38cf1550d8152089443196e]

        fix opencl ocMod
        
        Basically copied from core.
        
        Change-Id: Ic46e6ed77d1e75fcd4dfb8c641a8f592d577cab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140370
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [43f2cdb3b41ff4f5e99500f0c0082d4bfa4bc97c]

        fix incorrect as_double usage in opencl
        
        as_double interprets the binary representation, it is not a cast.
        
        Change-Id: I3034a36b84fbf458b8818af1e2255b532d21d229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140369
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [64426b95bd6c9f1fe7a40c2f2bfabb43b1ce658c]

        fix opencl round(), roundup() and rounddown()
        
        These are quite tricky due to rounding errors, the pown() used
        to "shift" the decimal point left-right increases the rounding error,
        so this must be compensated for. The round adjustment is based
        on rtl_math_round(), the up/down variants check for valid 12 places.
        
        Change-Id: I940f11f4e913665a5248463cf826ab5e5dcbe797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140368
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [18d2347aea57748b0c846279587a12ea5ced1776]

        fix opencl ocHypGeomDist
        
        Logic primarily based on e58b3f987681d0034f692db82345af06de217836.
        
        Change-Id: Ib5c7912a20d13ee9e841afca9b5c77f2ce43f917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140367
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Luboš Luňák  <l.lunak@collabora.com>  [be36394708abf11a70be2be7591811b4fa6e81a6]

        fix opencl RATE()
        
        Simply copy&paste&adjust the core implementation.
        
        Change-Id: Iaba774b6a606d5ed323e2423c1d1261358814ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140366
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [7d95a22245e3a031016e403aafddc00a73008b74]

        Revert "Related: tdf#151107 make "sloppy" paper fit up to 1.25pt"
        
        mistook user verified +1 for jenkins +1
        
        This reverts commit b15f7297a7f2bb3cb54f2a787d1c460adc2ac6fe.
        
        Change-Id: I5656a9a83d92a227efd249073ed746484b57171d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140438
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Laurent BP  <laurent.balland-poirier@laposte.net>  [7251b2ecd728bb6bd1af4cc4199da3f06e2e1ca3]

        tdf#129674 "Go to Sheet" UITest
        
        Add UITest to new dialog
           Sheet > Navigate > Go to Sheet
        Check search entry behavior
        
        Change-Id: I4b22328f24744ba554320c65ef95c20eb35dfe3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135632
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [eaedd8f968aa200f49a15000f41ee1126004b5e7]

        use more string_view in svx
        
        Change-Id: I672f6cc93f3f00c54eb2be7fa490d656bb5f0b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140407
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6a1408ca7ac16994467d1ec6ea9a3d86abae854]

        add a function to SwMoveFnCollection to move a SwPosition
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I9cba241062f0539dd55fe3c943504bc0db16837b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-22  Noel Grandin  <noelgrandin@gmail.com>  [590796ca0866168e3129d2abd0a0197114cddcdc]

        convert TrueTypeTable to C++ class
        
        Change-Id: I06f01c79414380e37dc006cc7f7fdce1976035f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [64e4363527422c913151efab0c0d0c6b8c2256c8]

        Related: tdf#151107 make "sloppy" paper fit up to 1.25pt
        
        Change-Id: I7fe804732849c09659d8d3da41aa1d0650cefb26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140410
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [2329128fa16a4e08a5f8fee0a83dd8b4d5c9c279]

        upgrade libepoxy to 1.5.10
        
        removed epoxy.android.patch: fixed upstream
        (https://github.com/anholt/libepoxy/pull/263/commits/063c1df27974f58b0f3c0a57417732da068923cf)
        
        Change-Id: If0c6c438014121bc480efeaeb1018b6b74e51fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [971804673efa7f461be21589d9e9bf0f982b8b54]

        Related: tdf#151107 EnvC65 page size is inconsistent with EnvC5 and EnvC6
        
        *PageSize EnvC5/C5 Envelope: "<</PageSize [459 649] /ImagingBBox null>> setpagedevice"
        *PageSize EnvC6/C6 Envelope: "<</PageSize [323 459] /ImagingBBox null>> setpagedevice"
        but...
        *PageSize EnvC65/C65 Envelope: "<</PageSize [324 648] /ImagingBBox null>> setpagedevice"
        
        use the EnvC6/EnvC5 dimensions for EnvC65 instead of
        
        *PageSize EnvC65/C65 Envelope: "<</PageSize [323 649] /ImagingBBox null>> setpagedevice"
        
        Change-Id: I7a13d141435e2d4fc202dab59b8c6be12ff9610f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140409
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [a64204cc26745e7652cb71ee2ed39a9ae00b09cd]

        cid#1515531 Out-of-bounds access
        
        Change-Id: I543c9a14dcba3b448c2bd1197e46fae8e3b76ab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140401
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Caolán McNamara  <caolanm@redhat.com>  [022289b2f028efba55f679cb2664092f0ffbc20a]

        this originally checked for > 0
        
        Change-Id: I3babab9dc6257ed9e07911e346fd1e56e26dc7c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140400
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [ddf695db44bcb23dc2f1459fd439f93c0b6d5f2a]

        tdf#151118: svg: fix handling of xml:space="preserve"
        
        This allows the code to be simplified a bit
        
        Change-Id: If42dd9d3ebd7860ece9ff78cb090ff1b07e1b432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140404
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cde237f7612cc34b1a7e46b83507877754b8e921]

        Fix typo
        
        Change-Id: I4eaf6679d6e238f8c0b0d85769893387f954bfb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140408
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-22  Miklos Vajna  <vmiklos@collabora.com>  [01b1f57a90172a76faa1489b3b72250ee76169a6]

        sw content controls, combo box: add DOCX filter
        
        Map the ComboBox UNO property to:
        
                <w:sdtPr>
                  <w:comboBox>
                  ...
                  </w:comboBox>
                </w:sdtPr>
        
        and the opposite on import.
        
        Change-Id: I50e0b961bca99f4ecca86d6784d2e6a13f469314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140399
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-22  Miklos Vajna  <vmiklos@collabora.com>  [21d93d8d2ffd9c5d5cfe9064590b35e0727295c9]

        sw content controls, combo box: add ODT filter
        
        Map the ComboBox UNO property to:
        
                <loext:content-control loext:combbobox="...">
        
        on export, and do the opposite on import.
        
        Change-Id: I33c162ace15025c8031eb678ba5a43ac085c4b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140364
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-22  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [ddc5a7bb10c6229018dbdb3192740b6d893fa08b]

        lok: initialize the load-language
        
        We need to use the load-language for
        saving the document. This is to avoid
        using the language of the view that is
        issuing the save, which causes all sorts
        of issues (language-translation related).
        This logic was implemented in 4b7b449bbdc5
        but for some reason the load-language
        wasn't set.
        
        This patch sets the load-language.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I0cd1574d48a99e6ee84bacf75fc0d9ebe26e526b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137391
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit a0b2739b2354b622538304c0846606247bcf09c0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140362
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-22  Ashod Nakashian  <ashod.nakashian@collabora.co.uk>  [90e3244aa6c15a42c5c86ebe5b36592085de9c79]

        sw: restore UI language to en while saving
        
        Because the XML writer used in sw invokes the
        translation logic, which uses the UI language,
        saving can fail in case there are multiple
        views with different langauges. This restores
        the language used for loading before saving
        to avoid such issues.
        
        Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Change-Id: I6675204bb68ea33b1395c779a64ab3e9b339d73e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135482
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 4b7b449bbdc51557f62131a3b467b34ad39e8547)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140361
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-22  Miklos Vajna  <vmiklos@collabora.com>  [4c2a9f46c1a7f4495c08f84a48d984364dedffa3]

        connectivity: use default member initializers in OWriterConnection
        
        It's less code and does the same.
        
        Change-Id: I8660f5409a062da7eb608000fee0e5a9bb07cb2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140356
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-22  Stephan Bergmann  <sbergman@redhat.com>  [3db6a93c558c55eed085b4386228f9951bb08936]

        Compute a better GetDefaultCenterPos
        
        ...as is used by e.g. Writer's "View - Toolbars - Form Controls", then
        Ctrl+click the "Text Box" icon:
        
        After ebd7cc1848ba2010128d09c5db524af2c6f5aa66 "tdf#150845: sw_uiwriter3: Add
        unittest", my 2560x1600 screen Windows laptop kept failing
        CppunitTest_sw_uiwriter3 with
        
        > sw/qa/extras/uiwriter/uiwriter3.cxx:962:testTdf150845::TestBody
        > equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        
        As it turned out, SwDrawBase::GetDefaultCenterPos happened to pick a position
        that didn't fall on the single page horizontally centered in the Writer window,
        but on the background surrounding it, so in SwFEShell::BeginCreate
        (sw/source/core/frmedt/feshview.cxx)
        
        >     if ( GetPageNumber( rPos ) )
        
        failed and no control was created (and so the number of shapes expected by the
        test wasn't matched).
        
        The logic to adjust aCenter based on aDocSz is there ever since
        39ed6bd497f2fed29c84023aa7d1739b303fd043 "#104503# put inserted control at a
        central position", but that's hard to understand for me because it's hard to
        understand for me how SwRootFrame::CheckViewLayout in
        sw/source/core/layout/pagechg.cxx computes aNewSize (which is what ends up here
        as aDocSz):  At least when the Writer window width is larger than necessary to
        show the full page, aDocSz.Width() apparently doesn't only measure the page's
        width, but also (part of?) the width of the surrounding background on its left,
        so the aCenter.setX(...) adjustment could have come up with an X coordinate that
        wasn't actually centered on the page as apparently expected by the original
        code.
        
        Experimentally, I learned that for the three Writer view modes:
        * "Single-page view" corresponds to GetViewLayoutColumns() == 1 and displays the
          page horizontally centered in the window.
        * "Multiple-page view" corresponds to GetViewLayoutColumns() == 0 and displays
          the pages starting flush left in the window.
        * "Book view" corresponds to GetViewLayoutColumns() == 2 and displays the two
          pages horizontally centered in the window.
        
        And at least when the window width is substantially larger than necessary to
        show the one full page of a one-page document (as when showing a default
        full-size Writer window on my 2560x1600 screen Windows laptop), the behavior of
        inserting a default-positioned Ctrl+click "Text Box" icon is:
        * For "Single-page view" it now actually inserts the control, horizontally
          centered on the page (instead of not inserting it at all, or inserting it not
          horizontally centered).
        * For "Multiple-page view" it keeps inserting the control horizontally centered
          on the page, as before.
        * For "Book view" it keeps not inserting the control, as before, as apparently
          before and after it happens to compute positions (albeit different ones) that
          fall on the background.
        
        Change-Id: Icf7dd30d4ce81e9d47a3c362f455f721f9e3dd30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [00c5b0ca9264c5440bc70a68c425127ba5a47003]

        tdf#151071 Revise Sifr, tidy up links.txt, remove already declared icons
        
        Change-Id: Icf0c59adefda151b5dc79d0edf7e2edde9f6c4b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140342
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [18f4fc547a8c055afdaec4aad69c9fea387696c3]

        libpng: update to release 1.6.38
        
        Change-Id: Ife594699cc8736ffdfc8f68e462d11416d7930e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a42f5faac7c6d4590e632cf40e3ba9eb618e6f56]

        tdf#103888: Do not add a gap at the end of each text portion
        
        I can't think of any situation where it's needed
        
        Change-Id: I1c2c6ec3d22eb9263f3c3c20793d9fe3926b8d78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140351
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [5468a58c3244cf98341945c17db040b067c825f7]

        crashtesting: disable glyph caching for "XB Roya" font
        
        as seen in tdf119074-1.odt. harfbuzz upstream bug of
        https://github.com/harfbuzz/harfbuzz/issues/3824 filed to look for
        guidance.
        
        Change-Id: I792f86334c2a2958b175a0e14334a0a7a6ba81d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Justin Luth  <jluth@mail.com>  [8f5f0c754222425af019a9fdc1ba47d72c541d9e]

        tdf#75702 ODS import: send text:line-break to editeng
        
        A cell with a line-break specified is no longer a simple string,
        so send the string to editeng where it can be properly displayed.
        
        This already works fine for XLS and XLSX.
        
        This change effectively means that text:line-break
        will disappear, and become two separate paragraphs.
        Given the nature of spreadsheets, the precidence in
        various other patches and the failure to properly
        display without this, I think I'm fine with
        unilaterally changing one paragraph into two.
        
        Change-Id: I7abcbc6f698a4cb319aea5465a8b0393cf63f31f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140262
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [f41868a5dcdb1982c1e3064dd985d894eaba0074]

        use more string_view in editeng
        
        Change-Id: I7e434076750ebdf4aeee621151fbe6dfc929c60f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [318a7961fc3542724cb85e31edfbf3b898e2a4f3]

        possible fix for testRedlineAutoCorrect2 "Lorem,... Lorem,…" failure
        
        Change-Id: I5cd7ec6b63f680da4d6f8e0ec896b3194ec14f2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [85078a0d6353287c4494ea1e7fd14c44b9ab0c0e]

        Fix typo
        
        Change-Id: I46f3ada5c155250b56ae3c8227587b741a8144dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140349
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-21  Mike Kaganski  <mike.kaganski@collabora.com>  [4e738b824d825717b7c6b895d816dcac1adf08e1]

        basegfx: remove global ImplB2DPolyPolygon
        
        Similar to commit 7e911e9cd469d30369c213aa529675b3f7c4f0e8
          Author Michael Stahl <mstahl@redhat.com>
          Date   Fri Aug 25 20:51:22 2017 +0200
            basegfx: remove global ImplB2DPolygon
        
        There shouldn't be allocations of the objects just to destroy them
        without populating with data (it there are, they should be optimized
        away); and for any reasonable use, defaulting to a shared instance
        means that there is an unnecessary refcount increase and decrease
        aside from inevitable allocation of the unique instance.
        
        Change-Id: Ia92c229165c0836e56778d9274f0728181048e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140341
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-21  Stephan Bergmann  <sbergman@redhat.com>  [c1ee70dba2c8da567feeeb276fddf5f726863a81]

        Use the more "natural" string_view o3tl::getToken variant here
        
        Change-Id: I31edc76e4358f7bcedabd89376fe0b28ec73e5f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140343
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [776ea34deefe7bdce2fb8a06e5c55ef27ec87ea7]

        use more string_view in xmloff
        
        Change-Id: Ieef49d049760e557d341f1991f28333b09220c1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Stephan Bergmann  <sbergman@redhat.com>  [70f8bddf87537e5ca28758a1f59bda23c0963501]

        Extend loplugin:redundantcast to some suspicious reinterpret_cast
        
        Change-Id: I5534939bfbea67d216a17891722a683c53621d36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140303
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [c20afb30e724361b76257fec0f3f7b9b90f8d58c]

        new won't return null, so drop conditional now
        
        Change-Id: I08e0bac8215f5aff92dc4c79caea4d3275b9c08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140309
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [da730a3df0dd8a8b1ac0eca09ccc9bba04830802]

        use more string_view in svtools
        
        Change-Id: Id0317c400d7bc868916b97cd1c7abae04c4a9e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Mike Kaganski  <mike.kaganski@collabora.com>  [bdf346830b735aa484fba0df94be71fd1ea5cdfd]

        tdf#151100: xText->getString() may be empty for content needing export
        
        The check that is removed prevents collecting the table data.
        Assume that it's the performance optimization, and that processing
        empty text objects would be fast anyway.
        
        This basically reverts commit 73fcb052edf1a21d785583bc53e8b4323b577bb1
          Author Christian Lippka <cl@openoffice.org>
          Date   Thu Nov 22 12:26:35 2001 +0000
            #90330# only export text autostyles for shapes with text
        
        and commit 7661bbbaef31adfdb298b1447301b24a70f85834
          Author Michael Stahl <mstahl@redhat.com>
          Date   Fri Nov 25 22:46:34 2016 +0100
            tdf#102479 ODF export: ignore exceptions when checking shape text
        
        that becomes unnecessary after the former change is reverted.
        
        Change-Id: I709a7b4c5ac1cc0621d3a1b18f2eb74feb987efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140313
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-21  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [f10067abcb0beab2cf9b93592a945b6ba86686f2]

        update expat to 2.4.9
        
        Fixes CVE-2022-40674
        (https://github.com/libexpat/libexpat/blob/R_2_4_9/expat/Changes)
        
        Change-Id: I459cf5f5de31e7cf5420d3df6b11893d5c4ca4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [552b46cdc5add38005a602172bd0143c562a6c4c]

        cid#1515518 Dereference before null check
        
        and
        
        cid#1515520 Logically dead code
        
        Change-Id: If3eaece51004e3b05eaf123a3d80430ffc154be2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140308
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [7ecd9e1e6c57d9763ff57e42cccbd32243d2a4db]

        cid#1515521 Dereference before null check
        
        Change-Id: Ida2a6fa69b5ca771c87669b8c58e8febb0f8a2f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140307
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [f6afdd94def385c2851f92dd39a3197e540494f4]

        bogus OSL_ASSERT: nPos != std::u16string_view::npos ... warnings
        
        since:
        
        commit 5edefc801fb48559c8064003f23d22d838710ee4
        Date:   Tue Sep 20 11:37:12 2022 +0200
        
            use more string_view in unotools
        
        Change-Id: I095de3a1156613e95c96ad0d1375885e8f36d61c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140312
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [02aeec651ac3b09d42d1c05832c274c8d941b36c]

        drop extra space
        
        Change-Id: I0cd134dbeaef46bf3c925a01b423edc0be2bba63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140310
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Miklos Vajna  <vmiklos@collabora.com>  [37656a47d8797d45d706a17ab8843dcb8db90bbc]

        sw content controls, combo box: make the dropdown case read-only
        
        Dropdown should be read-only (select from existing list items only),
        combo box should be read-write (accepting free-form user input as well).
        
        Now that we have a combo box, allow editing a combo box's content, but
        turn dropdown into a read-only control.
        
        Change-Id: Ie9434eaf2580be8ce154ec1126f7768eb9401254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140338
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7cecf19a1f553b57b5d1cd81a9a99f51ee424a24]

        Update git submodules
        
        * Update translations from branch 'master'
          to a5f80090f50b6d1e06f579d12a22eb1ad805c99c
          - update translations for 7.4.2 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: Ia36bd93db2652764c7ed865058467bb0b17eb545
            
2022-09-21  Miklos Vajna  <vmiklos@collabora.com>  [276f3a3ce52ca422bf5ebccfa2c926d3e87d5eab]

        sw content controls, combo box: add doc model & UNO API
        
        This is similar to dropdowns, but combo box allow free-form user input,
        while dropdown is meant to enforce that the content is one of the list
        items.
        
        Change-Id: I4ae226c55f70b2b3237021348e21b7d184e8a5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140302
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-21  Caolán McNamara  <caolanm@redhat.com>  [a6541eb454644cd781f6f4345a34ee422d1a4520]

        cid#1515519 Uninitialized pointer field
        
        Change-Id: I5ebb88d3f0a9d02301e4bf19e8492300eff63c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140306
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-21  Miklos Vajna  <vmiklos@collabora.com>  [5aa575ebe5ee199b3ac545c4c0367260227eecb2]

        CppunitTest_sw_ooxmlfieldexport: remove not needed mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I819eea323c7445bf25444c11c35314f439d4116c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140261
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [bdb576ea889d944b2aa9d3dfaa8fbd7c07415c82]

        fix/simplify opencl GEOMEAN()
        
        I don't quite see why this one would need such a special handling,
        when most other functions (e.g. the very similar HARMEAN()) can do
        with just generic handling.
        
        Change-Id: I31f3772ffdf9540178a42f11ae4e376023ad2413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140257
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [b764e5e0532a9c017f871b60026e507f283eb133]

        fix opencl WEIBULL and ZTEST functions
        
        Sync them with their core versions.
        
        Change-Id: I8890b13c0be8ac1da91132ec7e294f542dcc577e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140256
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [ebc0db7acee7a470c4e41cddbb97274343899ce0]

        fix and simplify opencl functions that calculate difference from mean
        
        ocVar, ocStDev etc. Besides the copy&paste reductions, these also
        need to use fsub_approx() otherwise they can fail with large numbers.
        
        Change-Id: Ic96caaa0d5711d811a27b0e2034db357a71b9fa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140255
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [380b42bd1b8be39d774245f93651515b45df150b]

        fix and enable some disabled opencl functions
        
        Change-Id: Ic7bd01edcc7297317b390567590821ce00e5ef22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140254
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [ab561d74375576efbc1629ae4f169c8e02f5fee0]

        fix/simplify opencl DDB() and VDB()
        
        Change-Id: I7de072defa1f8a1020c0d974bd519e6d2f604381
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140253
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [2e983926e868bcb2182c84348b60ad7085588b96]

        various small opencl code fixes and error checking
        
        Change-Id: I9f1d109887faf11a86be83da050983292e99da49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140252
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [b79796ced86c232154801a3084df0cec3c022af8]

        fix some opencl financial functions (PMT, IPMT, etc.)
        
        These are mostly copy&paste from ScInterpreter and adapted.
        
        Change-Id: Ib05021556a34b2eb35d0e51673636f50f150732f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140251
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [be60dd63f43ba0602835332f7b086faf810eac0c]

        remove opencl implementations of ocDB* functions
        
        - These are hard/impossible to implement properly, since they all
        use 'SearchCriteria' argument, which is an expression to be matched,
        and already strings are hard in opencl and parsing/evaluating/whatever
        an expression would be so complex. Maybe number matching or very basic
        expressions would be possible, but not much more.
        - The opencl implementations of these are (hopefully) very unlikely
        to be ever used, since they generally do not make much sense to be used
        in formula groups (except if the result is repeated in the group).
        As such, simply remove these, as it's just not worth it.
        
        Change-Id: If007c84c1ff684a94cfce0fe171691d9b3578658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140250
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Luboš Luňák  <l.lunak@collabora.com>  [33f242266138d5179a58f2601ea15be4b6570835]

        rework handling of empty cells in opencl code
        
        Some of the code handling ranges of cells wants empty cells to be zero,
        some wants to skip them, and few want special handling. So just make
        three generic cases that handle these, which somewhat simplifies this
        while still allowing flexibility where needed. Also handle better
        Test::testFuncSUMXMY2, which works on a pair of ranges, sets a cell
        in one to a value and another is empty, in this case it is necessary
        to iterate over this pair with SkipEmpty even if for the second one
        it's beyond GetArrayLength().
        
        Change-Id: I6c8edaaadb02ffe2a6a7a9399347909008ea188e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140249
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [79f049d4d7f071aa87207b53c257b6a0aa15365a]

        use more SwPosition::Assign
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I19e7a24231a2f4c15ffdf4b778e191e1907e40f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140247
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fe36103482b6142833731e77b0d074946138538]

        use more string_view in vcl
        
        Change-Id: I66f96a305bb095716023ae1e565950971826bce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140242
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Noel Grandin  <noelgrandin@gmail.com>  [27a271b462c3174bfd5a96c9f5d63f6f689e0b18]

        convert TrueTypeCreator to a C++ class
        
        Change-Id: I07cd2dfeb947f555b31bd0dccb91fb76f549c675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Noel Grandin  <noelgrandin@gmail.com>  [fd49a057c9d0fc3a184097f4f3bcb6835eb70edb]

        use more unique_ptr
        
        Change-Id: I7836a1b1813d16db53ca0d6cc2b2ff2ae95e70cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140267
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Noel Grandin  <noelgrandin@gmail.com>  [4df352d39602c1b45c5cf156d9dee2c148418dc0]

        convert GlyphOffsets to a C++ class
        
        Change-Id: If693a5d0a94da666fd0361d45a3047890d9dec8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140265
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Noel Grandin  <noelgrandin@gmail.com>  [2de582e29dd6bc678b5b9d7d0ae1b8f8c6c0c862]

        convert HexFmt to a C++ class
        
        Change-Id: Iebe385b1a6d51ab2c179a27eef4fb1199bc3aa41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-21  Stephan Bergmann  <sbergman@redhat.com>  [59286d0b99679aeeffd989380754a3687effbb22]

        NameID must encompass the full OpenType Name ID range
        
        ...to avoid CppunitTest_vcl_fontfeature
        CPPUNIT_TEST_NAME=FontFeatureTest::testGetFontFeaturesOpenType failing with
        
        > vcl/source/font/PhysicalFontFace.cxx:376:48: runtime error: load of value 259, which is not a valid value for type 'NameID'
        >  #0 in vcl::font::PhysicalFontFace::GetName(vcl::font::NameID, LanguageTag const&) const at vcl/source/font/PhysicalFontFace.cxx:376:48
        >  #1 in vcl::font::FeatureCollector::collectForTable(unsigned int) at vcl/source/font/FeatureCollector.cxx:124:44
        >  #2 in vcl::font::FeatureCollector::collect() at vcl/source/font/FeatureCollector.cxx:198:9
        >  #3 in OutputDevice::GetFontFeatures(std::vector<vcl::font::Feature, std::allocator<vcl::font::Feature>>&) const at vcl/source/outdev/font.cxx:169:23
        >  #4 in FontFeatureTest::testGetFontFeaturesOpenType() at vcl/qa/cppunit/FontFeatureTest.cxx:143:5
        
        after 06a23b7b4d23a31a4808c68f00e1be42d8218737 "vcl: Add
        PhysicalFontFace::GetName()".
        
        Per <https://harfbuzz.github.io/harfbuzz-hb-ot-name.html#hb-ot-name-id-t>,
        hb_ot_name_id_t is a typedef for unsigned int, and per its referenced
        <https://learn.microsoft.com/en-us/typography/opentype/spec/name> OpenType Name
        IDs are apparently uint16 values covering the whole value range (e.g., "Name IDs
        256 to 32767, inclusive, are reserved for font-specific names").  We could thus
        presumably use something like std::uint16_t as the underlying type for NameID,
        but lets play it safe (and avoid potential data loss when casting from
        hb_ot_name_id_t to NameID) and simply use hb_ot_name_id_t as the underlying
        type.
        
        Change-Id: I50768c5ae6174500d959ba63fdbc15fe416f8777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140301
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-21  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [a3e36aaf5fcd7489f802913e93c200f3cde8492d]

        tdf#151081 render rotated gradients correctly
        
        We have to use regular primitive decomposition
        when the gradient is transformed in any other
        way then just tanslate & scale. For more background,
        refer to the bugzilla task.
        
        Corrected some typos.
        
        Change-Id: Ic767c9fe6d14444915facc1247ba4ec1f79fd02e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140237
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [90861cc6f815b3f34edb88d47afed0d1099e72e7]

        tdf#151071 Revise Sifr, tidy up links.txt, remove duplicate
        
        Change-Id: Ifcf5014448214238891fe5a583dc36e0b9fccfe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140285
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [e822ef8c39a326a10d489b5ee50583b934fbb2de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b0d630cec012f7aa10cad2029468f5ea6f25b6c
          - tdf#150958 Fix mention to Find tool in help page
            
            Change-Id: I57e98af47bed1ee499ad9f9268514697141eaf9e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140169
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [cff3cea643668228f97ee85056b5ea4d8c7ab475]

        tdf#151088 Use "Kraft Paper" instead of "Invoice Paper"
        
        As per discussion in Weblate, the correct term here is "Kraft Paper".
        
        Change-Id: I0c0ffeac66453911f016e2134436f4cb5c340f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140171
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f0a36babf2ef1384666705697f91e7ff4166f4e4]

        tdf#151071 Revise Sifr, remove duplicate and missplaced icons
        
        Change-Id: I3322303ab50c65301bfaeff14ba371662bb7e3cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140259
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b52fd544b9c128d3e28de6355286f6480b618e93]

        avoid some string refcounting with sheets with lots of conditional formatting
        
        Change-Id: Ibb2de1aa28a57748bede6085074f60af757ae5ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140244
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b98500614f179b8c725a8476d72ff84327c3716]

        add CanJoinNext method that takes a SwPosition*
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I401fa4d98a2e53a082bfb39f3d13315261a0a2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140246
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b25ea4386cfa48c8cf27a58144306f15b86397b]

        use more SwPosition::AdjustContent
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ied4eb6b219dbd505c53068ca1ec7a5b43e5a1cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [e4a72aa946b6c41a91dc6e74634093a83b9c22bd]

        tdf#151056: avoid modifying the static shared DEFAULT instance
        
        This was a thinko in commit e39fa3c4f5ae2560a4b6f6f789a0c5098ac43cf4
          Simplify b2d(poly)polygon implementation
        
        This led to exponential growth of elements in each next polypolygon
        created from scratch, that immediately manifested with the complex
        SVG logo shown on the backing window.
        And finally, there's no const_cast/as_const left in the file :)
        
        Change-Id: Ie60f75ec86a8fa21799f4f1b589c04c9e4646183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140248
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-20  Mark Hung  <marklm9@gmail.com>  [11ec622b8405dcaabc359e3d6e38c8a9142dad6b]

        tdf#150642 fix table layout with vertical writing.
        
        Revert part of 1bf82b26ae3.
        
        N | V | WAS         | 1bf82b26aea3 | WAS                  | 1bf82b26aea3 |
        -------------------------------------------------------------------------------
        F | F | fnRectHori  | fnRectHori   | fnAddRight/fnSubLeft |              |
        F | T | fnRectVert  | fnRectVert   | fnAddRight/fnSubLeft |		 |
        T | F | fnRectVert  | fnRectHori   | fnAddRight/fnSubLeft | fnAddBottom  |
        T | T | fnRectHori  | fnRectVert   | fnAddRight/fnSubLeft | fnAddBottom  | *
        
        *: the case fixed in this patch.
        
        Ref:
        
        commit 1bf82b26aea3a403920a64cdfcb4671c947c7a01
        Author: Mark Hung <marklm9@gmail.com>
        Date:   Sun Aug 14 15:23:14 2022 +0800
        
            tdf#135991 fix unexpected hidden RTL sections.
        
        Change-Id: I1e30c277dd03369bef0a6930b3d3534b7d57a640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139777
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [424595a5997d1cbbf5ab0e3601e329efac9c2fd0]

        fix and simplify openCL *A functions (COUNTA,MINA, etc.)
        
        These work just like their non-A counterparts, they just also accept
        strings and treat them as zeros. So instead of having a duplicated
        function for everything, use the basic functions, detect that string
        arguments should be treated this way and then convert them in the input
        data. This as a side-effect also makes
        the ScCalcConfig::StringConversion::ZERO part work (no idea if that's
        even been used).
        
        Change-Id: I3385b5363c15b0ae45ff191df00ac357e80bd3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140226
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [68ae0798078cbc9daa8ea951e0f5e7de55042f70]

        reduce opencl copy&paste (gaussinv)
        
        Change-Id: I44e5c74c903bab46a54b5b855f2665d924ac91fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140225
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [7dc92d60166a99e0539ce83ecf45bb40fd30d784]

        fix opencl AND() to treat empty cell in svSingleVectorRef as core does
        
        Functions_Excel_2016.fods incorrectly used "=AND(Sheet2.C22;C33)"
        instead of the correct "=AND(Sheet2.C22:C33)" (colon vs semicolon),
        and C33 is an empty cell. The return however was true because empty
        cells get special treatment because of Excel compatibility.
        
        Change-Id: I6d0b28280059fd6fc945e77c7b5d714b5e4727a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140224
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [7c86dd5819be4ebb3599a654b69d3416dcbb6138]

        fix opencl FTEST()
        
        Change-Id: I72a6e7e36a8514c1d3c824a70829ebf026659262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140223
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [b2c334d76d5d5e5219d94db90e36d597be654c6c]

        simplify opencl code in op_array.cxx
        
        Change-Id: I4379683fa239e6f7c543350b645addffa784ba70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140222
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [e39f5eedc09fb79159bc764f1215d24afa9035e0]

        fix and simplify opencl IRR(), MIRR(), XIRR() and XNPV()
        
        Change-Id: Ie57e43458f7fa5a769806d0fe3054745ec71c99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140221
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c8649af8d0353e2fba2e472f0ace50f5bd8167b2]

        Assert that cow_wrapped objects aren't called to do nothing
        
        An omission from commit e39fa3c4f5ae2560a4b6f6f789a0c5098ac43cf4
          Simplify b2d(poly)polygon implementation
        
        Change-Id: Ib0b10e06baf91888f0e9797e670e0626f512af15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140229
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f600c5389ccad6a221732b478650a20de4355890]

        use more string_view in svl
        
        Change-Id: Icd978cd3cb7946f96d2570a0b8c87a74eed57c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140241
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [78afe29f3d56e589be4e0d25573eef32377548eb]

        move some test from odfexport to odfexport2
        
        to trim the long run time of odfexport
        
        Change-Id: Ib2c2f13796ecea14a3aede51442005c08487c128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140240
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4fe4a2918fbca0dc38441261a0f890720538639]

        split the mailmerge unit test
        
        since it is substantially longer running than the next longest test
        
        Change-Id: Iec8f1e2f3d98a1c290c1a66620443c79dda9c237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140239
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [06c9e1d27093ca7bbe38a1eb93fbb85b80f75f75]

        nss: update to release 3.83
        
        Change-Id: Ic1cb36b3a56cde40296fd46ef356dea286932692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140231
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-20  Caolán McNamara  <caolanm@redhat.com>  [e37cb88b51e3ab0da687278b3c846140b507e00b]

        ofz#51471 Timeout
        
        Change-Id: I2ffdb9f439f61fc46f3a3e7176a0451904e8f2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e17fc21bf59d4dbd80de6a569172406c8f86a1c]

        split chart2 export unit test
        
        since it was running for quite a while compared to the others
        
        Change-Id: Ia83a452fea67de425691f8ef66f23cde47fc0af8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140236
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [5edefc801fb48559c8064003f23d22d838710ee4]

        use more string_view in unotools
        
        Change-Id: Iaf91f9c63a0a666250e92a5ba7bebdb06dffb258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Mike Kaganski  <mike.kaganski@collabora.com>  [321a1b5034e36e156755bbd5794c33c73608e5a5]

        Only try to convert outdir to system path when it's not empty
        
        Avoids a warning on startup of a debug build:
        
          > instdir/program/soffice
          warn:legacy.osl:1528:2140:sal/osl/w32/file_url.cxx:849: osl_getAbsoluteFileURL
          called with empty base URL and/or invalid relative URL
        
        Change-Id: Ic456f08011d099a95894259f31800f12318af223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140230
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-20  Caolán McNamara  <caolanm@redhat.com>  [8c285077e963eaa34d94ecd35c3241040c06e293]

        upgrade to harfbuzz-5.2.0.tar.xz
        
        Change-Id: I0b3c7bd425f6de2033696909c2d15e4263d3a52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140235
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-20  Noel Grandin  <noelgrandin@gmail.com>  [2e932f8aeb62ec05057c680ae23fc0fb3ed4f978]

        use O[U]String in TrueType code
        
        instead of manual memory management
        
        Change-Id: Iccde191bfcfbf9ff2488205fffc12b94b46ab658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [65062ceaae656dca2cf66653b0ed7d627737e54c]

        use more std::u16string_view in chart2
        
        Change-Id: I3617efa2e7fd55e6c1007338fd3c52aa9bbf13b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140232
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Caolán McNamara  <caolanm@redhat.com>  [6defa69b8f3a60643163ecba28b6df1f5825bcd2]

        ofz#51592 Timeout
        
        Change-Id: I8e3c80ae6d041fc1460807ec3869c4b6845116f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-20  Khaled Hosny  <khaled@aliftype.com>  [348452715de6af8be2d40407bbe191752452b883]

        vcl: tdf#138325 pass PostScript name down to CreateCFFfontSubset()
        
        If we don’t pass the name from the caller, it will try to read it from
        the CFF table but some fonts has CFF table without a PostScript name so
        we end up with a dummy value.
        
        Change-Id: Ie7c46cdf5542ce83a57b60dee35dbb704a898f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140220
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-20  Khaled Hosny  <khaled@aliftype.com>  [06a23b7b4d23a31a4808c68f00e1be42d8218737]

        vcl: Add PhysicalFontFace::GetName()
        
        Change-Id: I91cc7bd0b9c9ce8d59a31d17a354fb3f2be29499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140219
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-20  Miklos Vajna  <vmiklos@collabora.com>  [80550ade305b9e68c6281a258d162bc2c413713a]

        tdf#150990 ODT export: fix zero layout size of scale/scale images
        
        The bugdoc has a broken image where both axis are set to a relative size
        of 255%, which means "keep aspect", and the expectation is that only one
        axis uses this to match the size of the other axis.
        
        The problem was that commit b578fa08a25a83abccad2386e12b707586fffb26
        (ODT export: fix fallback svg:width/height for text frames with relative
        sizes, 2022-03-16) assumed that only one axis uses "scale", so we always
        get a non-zero layout size.
        
        Fix the problem by only using the layout size when exactly one axis uses
        the "scale" percentage, which is the expected the case.
        
        This way we just keep the aspect ratio of broken documents, then the UI
        will in practice ignore the scale request of the width.
        
        Change-Id: I2dbd6bb92f912f6185422fd301b99b284a66ef74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140218
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-20  Justin Luth  <jluth@mail.com>  [6e1c8bcec511444d2d51c5c5143be56d1900e5e6]

        tdf#150613 sw: better DOC import of paragraph marker formatting
        
        Following the lead of LO 6.4
        commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac.
        
        This fixes a LO 7.2 regression from tdf#108518.
        This patch depends on tdf#117994 being fixed in order
        for ww8export3's testTdf108518_CRnumformatting to round-trip.
        
        The problem here is that Word allows formatting the paragraph end
        marker, and applies the same formatting to the generated numbering
        string; Writer has no such marker thing.
        
        On m_xCtrlStck, the rPos is pointing to the end of the paragraph.
        GetStackAttr looks for char properties that are still m_bOpen
        or else where the Point (Mark is the Start, Point is the End)
        is greater than aPos. Well, at the end of the paragraph
        I don't think there can be any empty (point==mark) hints in .DOC,
        so this should only pick up properties that are spilling
        over onto the CR - just like we want.
        
        Change-Id: I06cab075f102d40f93d33fedf5ae0ce8e165e9fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139329
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-20  Jim Raykowski  <raykowj@gmail.com>  [30e427d4091277839f6cbe30d7232498c0b48ef9]

        tdf#150604 related: fix logic used in determining inclusion of
        
        a separator in the Navigator content tree context menu
        
        In commit fbc9c8e3759ab79fce457565cd725c5a5353186e, https://
        gerrit.libreoffice.org/c/core/+/139628, made to include the content
        type name in the 'Delete' menu item in the content type content entry
        context menu, I mistakenly used logical OR'ing where logical AND'ing
        should be used to determine if a 'Delete' menu item is present, which
        is used in determining wheather menu item separator, 'Separator2', is
        included.
        
        Change-Id: I4a49895db9e39a0a2feedac8ec3d3440945e8abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140211
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-20  Noel Grandin  <noelgrandin@gmail.com>  [ca09f1a350c23f49b90950680fffa687979a8ae2]

        simplify usage of TempFile in sw
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: I7e5f1cb7c83fc78d392c6874154563b64dd4a672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Miklos Vajna  <vmiklos@collabora.com>  [addfb3cce0f7ce8fbd0b169d467b6956ed95dbb5]

        sw content controls: add a11y description for PDF export
        
        Acrobat Reader shows these descriptions on mouse hovering on a form
        widget.
        
        Change-Id: I8614222e46c992baca8a57b13a948f88973e8911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140215
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-20  Noel Grandin  <noelgrandin@gmail.com>  [6754b647c145cded1f54b49d53d37ad35ace211c]

        simplify usage of TempFile in sc
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: I15f51b75d3bb8ed53d617fce373237f685d45e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [8615b106366896d944ff16aa8112d8610a0521e9]

        an implicit intersection requires a svDoubleVectorRef
        
        This was claiming e.g. =TTEST(A1:A10,B1:B10,1,2) had implicit intersections
        because the 3rd and 4th arguments were found to be implicit intersections.
        
        Change-Id: I9cba7e63330dd170ef0ea1ab03d33a653000e669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140189
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [66ad69f5b300060f174fdc6c6e106dbba2b0140a]

        correct handling of 'nested' in opencl vectors
        
        The 'nested' arguments means the value is used inside a loop, which
        already implicitly does range checking.
        
        Change-Id: I71ccbded2f9d623f58d11f11316aab28385f1614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140193
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [4c2b8db7814dead51607935c50c1d0160333d616]

        reduce opencl copy&paste in op_statistical.cxx (svDoubleVectorRef pair)
        
        Change-Id: I92daab29290c9d72f7531b25950c7f52084cc0bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140192
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [0513d1954c37f62cfb5336a640d3c336d3641e84]

        reduce opencl copy&paste when handling a pair of svDoubleVectorRef
        
        Some functions run one loop iterating two svDoubleVectorRef.
        
        Change-Id: I849becd7863a1740277e6da9625bc7daad4b5274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140191
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Stephan Bergmann  <sbergman@redhat.com>  [2dca86cde303ca41f835132ce03105cbedde4cce]

        external/fontconfig: Avoid UBSan invalid-null-argument
        
        ...as seen when CppunitTest_services is run while instdir/share/fonts/ happens
        to still be unpopulated (which is otherwise not an issue for that test),
        
        > fcdir.c:268:11: runtime error: null pointer passed as argument 1, which is declared to never be null
        > /usr/include/stdlib.h:852:30: note: nonnull attribute specified here
        >  #0 in FcDirScanConfig at workdir/UnpackedTarball/fontconfig/src/fcdir.c:268:5
        >  #1 in FcDirCacheScan at workdir/UnpackedTarball/fontconfig/src/fcdir.c:354:10
        >  #2 in FcDirCacheRead at workdir/UnpackedTarball/fontconfig/src/fcdir.c:462:10
        >  #3 in FcConfigAddDirList at workdir/UnpackedTarball/fontconfig/src/fccfg.c:537:10
        >  #4 in FcConfigAppFontAddDir at workdir/UnpackedTarball/fontconfig/src/fccfg.c:2912:10
        >  #5 in psp::PrintFontManager::addFontconfigDir(rtl::OString const&) at vcl/unx/generic/fontmanager/fontconfig.cxx:748:20
        >  #6 in psp::PrintFontManager::initialize() at vcl/unx/generic/fontmanager/fontmanager.cxx:711:17
        >  #7 in GenericUnixSalData::InitPrintFontManager() at vcl/unx/generic/app/gendata.cxx:51:26
        >  #8 in GenericUnixSalData::GetPrintFontManager() at vcl/inc/unx/gendata.hxx:88:13
        >  #9 in psp::PrintFontManager::get() at vcl/unx/generic/fontmanager/fontmanager.cxx:108:23
        >  #10 in GenPspGraphics::GetDevFontListHelper(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/print/genpspgraphics.cxx:264:35
        >  #11 in FreeTypeTextRenderImpl::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/gdi/freetypetextrender.cxx:110:5
        >  #12 in SvpSalGraphics::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/headless/svptext.cxx:51:23
        >  #13 in OutputDevice::ImplInitFontList() const at vcl/source/outdev/font.cxx:651:17
        >  #14 in OutputDevice::GetDefaultFont(DefaultFontType, o3tl::strong_int<unsigned short, LanguageTypeTag>, GetDefaultFontFlags, OutputDevice const*) at vcl/source/outdev/font.cxx:532:22
        >  #15 in SwStdFontConfig::GetDefaultFor(unsigned short, o3tl::strong_int<unsigned short, LanguageTypeTag>) at sw/source/uibase/config/fontcfg.cxx:245:23
        >  #16 in SwStdFontConfig::SwStdFontConfig() at sw/source/uibase/config/fontcfg.cxx:91:30
        >  #17 in SwModule::SwModule(SfxObjectFactory*, SfxObjectFactory*, SfxObjectFactory*) at sw/source/uibase/app/swmodule.cxx:150:32
        >  #18 in std::__detail::_MakeUniq<SwModule>::__single_object std::make_unique<SwModule, SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&>(SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/unique_ptr.h:1076:34
        >  #19 in SwDLL::SwDLL() at sw/source/uibase/app/swdll.cxx:98:26
        >  #20 in (anonymous namespace)::SwDLLInstance::SwDLLInstance() at sw/source/uibase/app/swdll.cxx:57:212
        >  #21 in rtl::Static<(anonymous namespace)::SwDLLInstance, (anonymous namespace)::theSwDLLInstance>::get() at include/rtl/instance.hxx:399:18
        >  #22 in SwGlobals::ensure() at sw/source/uibase/app/swdll.cxx:70:9
        >  #23 in SwXAutoTextContainer_get_implementation at sw/source/uibase/uno/unoatxt.cxx:1015:5
        
        Change-Id: Ic0d246e6012b3cd2c9a9deb63c2af7258f31f0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140214
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [b014adf12d70f00369adaf3dc4d836c4c5d17b94]

        error handling in openCL FORECAST(), MIRR() and SERIESSUM()
        
        Change-Id: Ied72d13953ebd765fc0ed8838b557487f5f74e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140190
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [4797becd04ccd8447f933b8aa3de4477c740a273]

        reduce opencl copy&paste WRT simple loops with svDoubleVectorRef
        
        Change-Id: Id68808d5b390c0771e82bf391930a840f423c1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140188
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [f0466cabc2d33877d5aaa86fcf71db753f400873]

        reduce opencl copy&paste also when handling svDoubleVectorRef
        
        This is for when a simple loop is enough to handle the ranges.
        
        Change-Id: Ia2fa3b6944573f30fafea614a9ec51a21c7e8226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140187
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [2adc8a32ff8c36b556ca947afa46ea45e0c9769d]

        reduce opencl copy&paste and fix in op_statistical.cxx
        
        So far functions using svDoubleVectorRef are excluded.
        
        Change-Id: Ie8a72d7f72de34c422b23bcc526ac66f6b170b10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140186
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Luboš Luňák  <l.lunak@collabora.com>  [c443a02ec9db419527566b6f80f413c45dea3be5]

        reduce opencl copy&paste and fix in op_financial.cxx
        
        Change-Id: Ia1cd64f68b75f445c15ec5f8088e9202fa39768e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140185
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-20  Sarper Akdemir  <sarper.akdemir@collabora.com>  [9ecc76988ec46ba0d6c5cb72ac88f65da48867b1]

        tdf#89928 pptx import: implement import of BiLevel threshold
        
        Implement import BiLevel effect's threshold value.
        If threshold isn't exactly 50%, we can't map it to the doc model.
        
        Therefore as a workaround apply the BiLevel (Black/White) effect with
        specified threshold directly to the graphic.
        
        Change-Id: Ib24d149d74b103d926560708c68bb937b02c4cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140136
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-20  Miklos Vajna  <vmiklos@collabora.com>  [4616f006df9497a8beaeb9181368b8708f1eeedc]

        sw: document SwUndoInsDoc
        
        Also reachable via UNO in SwUnoCursorHelper::InsertFile().
        
        Change-Id: I72564e62cfd9e9d7ebfbf23a55964885b0fe3ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140200
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [6af41e0e55a578b3419737fc8aa9ab7757402cd5]

        tdf#151070 Leverage UI layout to show relation between buddy options
        
        And this is why LibreOffice is found by users to be hard to use:
        because we suck at layouting. Just by swapping a checkbox and
        a combobox, the relation between the two magically becomes INTUITIVE.
        
        Change-Id: Id3801015a6e75d1372d46f1e2d99cfb3a662496d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140213
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-20  Sarper Akdemir  <sarper.akdemir@collabora.com>  [79ea27ec4418b82af5ba2187ae59cd9c0874060b]

        tdf#94122 pptx export: fix automatic text color export
        
        MS Powerpoint doesn't have automatic colors unlike Word or Excel.
        
        Therefore on export the automatic text color should be first resolved
        and then exported.
        
        Change-Id: Ied2c3a4235da403350d8518a3414ff6a372b57a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140059
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-20  Julien Nabet  <serval2412@yahoo.fr>  [5a6914af4678a24c794055ba23dd9cf0857f0254]

        Simplify a bit by using sal_uInt16 in vcl/BitmapPopArtFilter
        
        Since we're in the "if (bRet)" block, it means
         22     bool bRet = isPalettePixelFormat(aBitmap.getPixelFormat())
         23                 || aBitmap.Convert(BmpConversion::N8BitColors);
        is verified.
        
        isPalettePixelFormat implementation is:
        29  constexpr bool isPalettePixelFormat(PixelFormat ePixelFormat)
        30  {
        31      assert(ePixelFormat != PixelFormat::INVALID);
        32      return sal_uInt16(ePixelFormat) <= 8;
        33  }
        
        So we know we're using 8 bits max and this line:
        pWriteAcc->GetBitCount()
        can't give more than 8 and we can safely declare nEntryCount as sal_uInt16 (idem for "n" just below)
        
        Since "nFirstEntry" and "nLastEntry" are related to "nEntryCount", idem for mnIndex
        they can also be sal_uInt16.
        
        Thanks to these, we can avoid all sal::static_int_cast<sal_uInt16> conversions.
        
        Change-Id: I8cac2d01f00be33c86058c7a6eb7b9e25fb2635e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [39addcb4de4c3033adfd4155de2a79c7633aaf9a]

        tdf#151071 Revise Sifr to follow upstream
        
        Change-Id: Ie72cbfc50c323b4d44b08440945ea171b4a4330d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140212
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-20  Noel Grandin  <noelgrandin@gmail.com>  [b5e1a1d16055a2782b46580ed8c8190244628fda]

        simplify usage of TempFile in sd
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: I8672c5749f1e0dc95e59cd9d713015586301ae34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Noel Grandin  <noelgrandin@gmail.com>  [3e095961add3705b788b017ea63585937a9fd7d3]

        simplify usage of TempFile in sc
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: Icab41d12ab7846b8901a92c11fee05952b98fafc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140201
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-20  Jim Raykowski  <raykowj@gmail.com>  [e79741488cc740f49ebd4426c40b45e7139ff663]

        tdf#112237 Show tooltips for Assigned Commands in Customize dialog
        
        Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-19  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [032e1aee7aaae04ca7aaa7792ba49849364fd249]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80034ff19535b6320a8ea113a9cf2f068e6aea31
          - Wrong words
            
            Change-Id: I391a5fd97005fcffac324581856bbdb8a48f1ae9
            
2022-09-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [3e65f33d450e512c31eeafc80956ada1cfade903]

        tdf#132519: sc_ucalc_formula: Add unittest
        
        Change-Id: Ie2ff5a8961556cf21ca75a58d46f37754e0bb61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140183
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [dfa01bb05cc82811cdc306285a31c51816f81c6a]

        tdf#151046: sc_subsequent_filters: Add unittest
        
        Change-Id: I552d53f511373b170985185361621d8e149e582b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140184
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-19  Stephan Bergmann  <sbergman@redhat.com>  [e9262729e6b41065596af8092905bafe986803e9]

        loplugin:unreffun (clang-cl)
        
        ...and with ScopedFontHDC::fsp gone, there appears to be no reason to keep
        ScopedFontHDC::m_aFSP alive for the whole lifetime of the ScopedFontHDC
        instance
        
        Change-Id: I1028bc24f49f3bbaf6e23c09aef4459418267154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140100
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-19  Caolán McNamara  <caolanm@redhat.com>  [2f1ad908310918d964b2996ccf4e987b7b0af86f]

        tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor"
        
        they are the same in light mode, so do the same in darkmode
        
        Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140195
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8cc530b1ecbb706e998177ab6e85f33ac111b389]

        size this OUStringBuffer at initial construction
        
        Change-Id: I6414281cef5eedf1e797139695bf05c72c300447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Justin Luth  <jluth@mail.com>  [648f06e583cf2cd878580c587afb5813c3db4e33]

        crashtesting: "unknown cell text: element" assert for text:bookmark #2
        
        since...
        
        commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1
        Date:   Sat Sep 10 16:32:46 2022 -0400
        
            tdf#103829 ods import: parse <text:tab/>
        
        From documentation, it looks like we can also have
        bookmark-start and bookmark-end, so adding these
        even though no examples found.
        
        I looked for how to insert bookmarks in calc - basically
        no UI or menu (except one notebookbar, no calc documentation,
        no abandoned bookmark code removal, no bookmark import code.
        
        IIUC, in writer a bookmark is basically a field.
        Perhaps it is similar in Calc? In any case, with this
        limited wealth of information, I don't plan on trying
        to fix the LO 4.1 loss of bookmark.
        
        Change-Id: I44708a5c7d69ce37f688ec7beb243e08844dbfa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140197
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c6c3e364697a908949409ab2c77d0e0b021b65d3]

        Fix typos
        
        Change-Id: If24b9756d7fd8f6346580b4da84fac4f5ab1d3ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140198
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [31640cce53e850da53c75e3882375d286c0e9024]

        Fix typos
        
        Change-Id: If33ae9acbc1ed17398584efa3574566b2d854b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140149
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-19  Miklos Vajna  <vmiklos@collabora.com>  [2e6144fc350fd94f8e66be5a9007c7f06c0213e0]

        sw HTML import: fix height of images when it is missing and width is relative
        
        This is similar to commit 456abae730a787693c3ad98f7e57eba5f6163a76 (sw
        HTML import: fix height of OLE objs when it is missing and width is
        relative, 2022-09-06), but this is for images, while that was for OLE
        objects.
        
        The idea is still that in case only axis is specified in the HTML and
        that's a relative percentage, then the ratio should be taken from the
        bitmap and it should be kept.
        
        Change-Id: I36184ff6531bff2775013462cd8cc711e1a249c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140178
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-19  Justin Luth  <jluth@mail.com>  [60585bb65330ad703b5683aece1564dfc6301436]

        tdf#75702 sc: unit test for preserving text:line-break
        
        Change-Id: Id61e46ba4e0b3e2b534cf9f8bafe03fba10cd355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140182
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [43864dd8925c8046ee7cae286a71616559e7ed2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4b86dd440667832cd5510a1bd31ff35514532d06
          - tdf#119421 Add sample files for conditional formatting
            
            Change-Id: Id5826f32bd2de2e286eecf57dc817f4b60a2599b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140196
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6238758d80e170cdb586df2b34d479499574cb72]

        tdf#150650 Fix changing fill style to None via Sidebar
        
        Regression from 5491a82854e3e6dd2dbb4b0012cb4bbeb4ee22e0
        
        Change-Id: I17cfb037f2064a508317090e6b66f20e253a9436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140150
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [716a81042558143b400c502d1ba3e1ff1b3672e1]

        no need to use an OUStringBuffer here
        
        can just return the substring we need
        
        Change-Id: I9d605cb809f58fcf60c0ae2e29aaff17baa9faa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140177
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [c3ea4a8025f1ba241a8ac5c53ac79fd274ec6b3a]

        use optional in processEntry
        
        which means we save the cost of initialising an OUString
        
        Change-Id: Ib139383b43f6d49303e20368ce4177b068c38ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140176
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0b6ea30e5825d7b11c783c4e5c4397acff9cac4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9abe3f66a8951fef89d79b5125931773778cda22
          - tdf#119421 Enchancements to Conditional Format pages
            
            Add icons and how-to-get
            
            Change-Id: I1fb78ac737bc37745ee76d4508116edadd283938
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140130
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-19  Caolán McNamara  <caolanm@redhat.com>  [6352710e02c12783280afccb3b5e03aab7948f19]

        try harder to remove "OSL_PIPE" pipe on SIGTERM
        
        a) When oosplash got SIGTERM it used SIGKILL on soffice.bin, (concealed
        behind osl_terminateProcess) so soffice.bin has no chance to cleanup.
        
        Try SIGTERM, followed by SIGKILL if that doesn't work, to give
        soffice.bin a chance.
        
        b) java intercepts SIGTERM so if JNI_CreateJavaVM was called then
        our SIGTERM handler doesn't get called. Add -Xrs to jvm args to
        avoid this.
        
        Change-Id: I09f93d8093bc7c094482eda73b4eadc5a6cebb83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140152
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-19  Luboš Luňák  <l.lunak@collabora.com>  [bbc07c964ef9a4698b3867ff554259adcf81bc58]

        move code out of formulagroupcl.cxx to op_math* and opbase*
        
        formulagroupcl.cxx is already large enough, move away code that
        implements some operations and also move some type declarations
        to a header.
        
        Change-Id: I28fe59275f4fb89c3e530d77b08e7f2fcad02781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139971
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-19  Julien Nabet  <serval2412@yahoo.fr>  [b0ad8a9175d5a9dddb9b853721905943c5cd8d59]

        tdf#150992: fix crash popart filter to an SVG image
        
        part of bt:
        6  0x00007f018c80186f in BitmapPalette::operator[](unsigned short) const (this=0x5576a198fe48, nIndex=176) at vcl/source/bitmap/bitmappalette.cxx:139
        7  0x00007f018c3d1fce in BitmapInfoAccess::GetPaletteColor(unsigned short) const (this=0x5576a2bbc520, nColor=176) at include/vcl/BitmapInfoAccess.hxx:121
        8  0x00007f018c85b63f in BitmapPopArtFilter::execute(BitmapEx const&) const (this=0x7fffb7394728, rBitmapEx=...) at vcl/source/bitmap/BitmapPopArtFilter.cxx:73
        9  0x00007f018c83e66b in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) (rBmpEx=..., rFilter=...) at vcl/source/bitmap/bitmapfilter.cxx:22
        10 0x00007f01905e5bd4 in SvxGraphicFilter::ExecuteGrfFilterSlot(SfxRequest const&, GraphicObject&) (rReq=..., rFilterObject=...) at svx/source/dialog/grfflt.cxx:202
        
        some gdb info
        (gdb) p nIndex
        $1 = 176
        (gdb) p mpImpl->GetBitmapData().size()
        $2 = 34
        
        full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=182499
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=150992#c2 for some comments
        
        the main thing that makes me think that the order is reversed is the "nLastEntry" treatment.
        Indeed with the current sort, mnCount with 0 come first nLastEntry = nEntryCount - 1 (unless there's no color at all)
        
        Change-Id: I3b89f2f4d6f115ea9f6752c49bad776a33f0b020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140153
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8db47ac6d52da86451120ce3c095958939e2da60]

        can return by const& in PopString
        
        and avoid some ref-counting
        
        Change-Id: Id1e6fc09d1c517ce168cebb7a225aa6df48e72c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Alain Romedenne  <alain.romedenne@libreoffice.org>  [cc48e6f880d84275c29414ab74d4aadf36d1dcca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30682f2fa484e9a831ac20c26bfd19aab6c42a82
          - Reuse and sync help content
            
            Change-Id: Ia95c3da543efd8dddfdcfa635d316b3c10fa52eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139569
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-09-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [1b0ff1c166211b34370f53995ae9fb3f8eed182e]

        tdf#150402 Correct wrong Bound of Shape in Slideshow
        
        Added and use mbContainsPageField that gets set in
        prepareHyperlinkIndices() which has to be run anyways,
        so this will cause no change in execution speed.
        
        It lets us detect the potential error case that a
        PageField is contained in the Text of the Shape.
        That is a hint that maBounds contains the wrong Range
        and needs to be corrected.
        
        For more backgrund information please refer to
        tdf#150402, Comment 16.
        
        Change-Id: Ifee01fffdb6e2f5915aa705afc7b5842781aae91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140144
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [29cba5c6fd36280107115b58aae61e5ead7e4d6a]

        tdf#150802 Fix setting gradient from Sidebar
        
        Regression from adc536e9efc77690df62177aa722f9252bdbf96b
        
        Change-Id: I37db76373a3b9b4a1084e830233561abc4b1e6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140151
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-19  Eike Rathke  <erack@redhat.com>  [4da1b6a0499ab9bb142156dd0a240b260a430a21]

        Update language-subtag-registry to 2022-08-08
        
        Change-Id: I08609e88c1bdb62f778db25156363fbc6d2adff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140148
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-19  László Németh  <nemeth@numbertext.org>  [7462f728df54c28cea659dbf9aa92070019b489f]

        tdf#147507 sw: fix crash with Reject All around not content nodes
        
        Regression from commit f3bec764ddbf3fd3ae986f034c89626bf22940e0
        "tdf144058 sw track changes: fix table deletion at paragraph join".
        
        Change-Id: If08a2b85c3db9fe92ad623d3d7cb30f2feaaab36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140145
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-19  Eike Rathke  <erack@redhat.com>  [4cb347ae1c62f9c8a53f17c3b7957ab68aade95e]

        Resolves: tdf#151046 INDIRECT() try named expressions and DB range names first
        
        ... as older 1K columns allowed names that would now match a 16k
        columns cell address, which ConvertSingleRef() would already
        resolve.
        
        Change-Id: I9322732e554da20c81856c0a30c41a246356f65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140147
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [4c501d435250934a1290c5ed28dc432ba333a6c9]

        vcl: Handle alpha in Type 3 glyphs
        
        Change-Id: Ic21089ae8aeca1402fd5c4c46851dcd06a480723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140146
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [e5a797a9beb03b9d9759a94b98107f509a0d5488]

        vcl: Fix Type 3 glyph widths
        
        It seems we need the values to be in unscaled font units not PS units.
        Modify LogicalFontInstance::GetGlyphWidth() to return unscaled values
        when requested and the TT-to-PS conversion conditionally in PDFWriter.
        
        Change-Id: I94e7cdc0ecf842a0cf87fddaa4467966f698ae3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140126
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [bf41b120b7690bb6976daa7aa317b5f3b9f5b19c]

        vcl: tdf#104403 PDF export for layered color fonts
        
        Support color fonts using color layers from OpenType COLR table and
        color palettes from CPAL table.
        
        This uses PDF Type 3 fonts to wrap the layers into individual glyphs
        that can be drawn normally. Type 3 glyphs can use arbitrary PDF code, so
        here we output the layers in the regular font subset and then draw then
        in the Type 3 glyph with colors applied to them.
        
        This supports only version 0 of COLR table (solid colors only), the new
        but more powerful version 1 of the table is not yet supported.
        
        Change-Id: I4bf36f5b608a0ac15411104d8a6af893fb69a5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140125
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [8453d7ea1ff5b2b93196ed4b4bf430d6c574a7cb]

        vcl: Add PhysicalFontFace::UnitsPerEm()
        
        Change-Id: I9239085aabe450499193e74ac91d6a16437545c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140124
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Ilhan Yesil  <ilhanyesil@gmx.de>  [ba164651bbdbde1b8a4ae3495b845ebc13b01bad]

        tdf#149797 Change highlight background color in some controls
        
        The highlight and highlighttext colors can be set for some
        controls. So as example a selected item in a listbox can now
        be paint with anothers colors then the standard blue. Controls
        are: listbox, combobox, edit field and some special edit
        fields like date, currency and others.
        
        Change-Id: Iace2dd9a1a61abb7819b6c81eb0b8030912db32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136691
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [891d618bfdcf369119807d826e8ec6e3b112d73c]

        make OUString::operator=(OUString&&) a little faster
        
        one function call instead of two, and this function is pretty hot
        
        Change-Id: Ibb09ad9b930f337706fa392a1644077c82dbc61e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d5e1a11b028fb9c03ff80f986f33927d6667627d]

        get_value is cheaper than at() in toRefCell()
        
        and we expect the position to be valid here, so throwing an exception is
        no better than a segment violation
        
        Change-Id: I20e4849c95da57e6a5fc0937c4f61fbe004d11d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Caolán McNamara  <caolanm@redhat.com>  [946f67cfc9909ba2f3297a5484b4033fea3701e9]

        Resolves: tdf#151017 we now want the background to be the stock widget bg
        
        Change-Id: I44a800748ffafe91f3b6169617be30ef87919267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [dac60206ff553ff424593f15d6c196a6c9cc0b5d]

        vcl: Add PhysicalFontFace API to get color layers
        
        Change-Id: Ic221582a04982f0b1565089fa0beff1b34a749d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140123
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Khaled Hosny  <khaled@aliftype.com>  [92d67d4d32dee25c6b40ade5924f9d1ab488a16c]

        vcl: Don’t use temporary files for CreateFontSubset()
        
        The callers pass a path to a temporary file for the function to write
        to, then they immediately read from it. This change cuts the unnecessary
        use of temporary files and passes the subset font data around instead.
        
        The CFF subsetting code really wants files and needs more invasive
        change, so it still uses a temporary files but this is hidden from its
        caller.
        
        Change-Id: I2a2117e967b76fb903ff0d32c435925049bc6e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140122
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [54e84cf2f75504232e41b4c2fdab1318f259cd66]

        small opt in FormulaTokenIterator
        
        cheaper to init the stack with the first element, rather than calling
        Push
        
        Change-Id: Ia34f88b6534a663fae2ed08d0499d04d2f458847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [467085bfb0f595a094389c2de159589372d36d1e]

        Rename MouseNotifyEvent to NotifyEventType
        
        Also contains keyboard and focus events, not only mouse events
        
        Change-Id: Iec1d6c341b01a489ba80fe9634ea3579afb02ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-19  Miklos Vajna  <vmiklos@collabora.com>  [de90c192cb8f1f03a4028493d8bfe9a127a76b2a]

        sw content controls, plain text: enable DOCX filter with data binding
        
        - writerfilter/ had explicit code to not map plain text SDT to Writer content
          controls if it has data bindings specified, lift this limitation and set the
          value of content control from data binding, like Word does and Writer did it
          for input fields since b5c616d10bff3213840d4893d13b4493de71fa56 (tdf#104823:
          support for sdt plain text fields, 2021-11-24)
        
        - call DocxExport::AddSdtData() on the export side to do the opposite on export
        
        - give up on the idea to export content controls to DOCX by finding the text
          attribute in SwWW8AttrIter::OutAttrWithRange(): this needs buffering in both
          directions (need to start the SDT before the start of the run, need to end it
          after the end of the run), and solving this using marks and merges at a
          fast-serializer level looks like hacks on top of hacks. To be more specific,
          CppunitTest_sw_ooxmlexport7's testSdtAndShapeOverlapping seems to be very hard
          to fix with this design
        
        - instead, give not only the start position but also the length of the run to
          DocxAttributeOutput::EndRun(), which has random access to the doc model and can
          look up if there is a content control start or end that needs writing at the
          current position of the XML output, without any buffering, which also
          means less code
        
        - adapt CppunitTest_sw_ooxmlfieldexport's testSdtBeforeField, which didn't like
          the empty run at the start of content controls, which seems to be harmless
          otherwise
        
        - fix CppunitTest_sw_ooxmlfieldexport CPPUNIT_TEST_NAME=testSdtDateDuplicate by
          disabling the "set content control value from data binding" logic for date
          pickers because that logic in writerfilter/ sets the value as-is and it has to
          consider the requested date format before this can be enabled
        
        As a side effect, this gives PDF export for plain text SDTs, even if they have
        data binding set. CppunitTest_sw_ooxmlfieldexport's testTdf104823 is now
        updated to ensure that we import such SDTs as Writer content controls.
        
        Change-Id: I749a845b5a25454c51066b8ded892682f523b6b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140134
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-19  Tor Lillqvist  <tml@collabora.com>  [b20a64ce05ebf3720dd2d10ccd384020803c2ff2]

        Ignore also when a font has been substituted by itself with an empty style
        
        Change-Id: I40fbce716a11b010323ac07e0dacdc114f7d2320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140135
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-19  Regina Henschel  <rb.henschel@t-online.de>  [439eaa8efdd8179f93f7aaf44d25ceced6ab1665]

        tdf#151008 adapt anchor for eaVert and mongolianVert
        
        MS Office and LibreOffice act different whether anchor positions are
        rotated for vertical writing modes eaVert and mongolianVert. The patch
        converts the position on import and export.
        
        Currently shapes are not able to render mongolianVert. Nevertheless it
        is included so that the text block has already the correct position
        and the original position is restored on export.
        
        LibreOffice has vertical anchor alignments BOTTOM, that would require
        a third horizontal position in MS Office, which does not exist. It is
        mapped to anchorCtr='1' instead. Such does not occur in pptx-LO-pptx
        round-trip.
        
        Change-Id: I1b0e42a39ce3aba12cdb271b2aa8023dacb9c53d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140118
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-09-19  Noel Grandin  <noelgrandin@gmail.com>  [95684fb99ebed5b53bda99957c43466541597b2f]

        no need to allocate these separately
        
        Change-Id: I5e61c783806d78df94fa08840f7d3f37f1a743ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Miklos Vajna  <vmiklos@collabora.com>  [f0359fb2f01ecf9aed470ae90604f9bd6eec3380]

        sw: prefix members of SwFootNoteOptionDlg, SwLabPrtPage, SwMailMergeDlg ...
        
        ... and SwMailMergeWizard
        
        See tdf#94879 for motivation.
        
        Change-Id: I01521a5b96e45483bb810ea0e8cfb26cbf55bc40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140133
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-19  László Németh  <nemeth@numbertext.org>  [cb1f95e7e5781797a0f4485d4a835faff4a8cd8f]

        tdf#150955 sw InsertBookmark: add hidden status to hidden MSO fields
        
        In Insert -> Bookmark... dialog window, add hidden status
        to _Toc and _Ref hidden DOCX bookmarks to allow separating them from
        user-defined bookmarks using sorting. (In MSO, there is a checkbox
        to enable visibility of these hidden bookmarks in Insert bookmark dialog.)
        
        Note: UX field Hidden was only used for a lo:ext OpenDocument feature
        (with UNO-only creation of bookmarks with hidden anchor), see tdf#101856.
        This UX field was re-used for better handling of DOCX import of
        hidden (not user-defined) bookmarks created by MSO.
        
        Follow-up to fix for tdf#150956 in commit 5e71ec6aa0d4f9971f5e2b6f7091d18668c2f0b9
        "tdf#150790 tdf#150791 tdf#150947 tdf#150956 sw, a11y: fix visible bookmarks".
        
        Change-Id: I52e9f2c0b65e62c14ac24138235f07fb213da737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140079
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-19  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [7614859e5738cdf3789f3f99cc4379f2333e8870]

        Make impBufferDevice faster again
        
        When the Primitives for the Glow-Effects were added
        (modified ShadowPrimitive2D, SoftEdgePrimitive2D and
        GlowPrimitive2D) a modified version of impBufferDevice
        was created and used. That lowered the speed for
        drawing objects with transparence by about factor 2.5
        and was unfortunately not only done for these
        Primitives, but for transprent objects in general.
        
        For the mentioned factor refer to:
          Patch to demonstrate former and now repaint differences
          https://gerrit.libreoffice.org/c/core/+/129301
        
        After having reworked those Primitives to use another
        mechanism and being decomposed so they will work in all
        now and future renderers, it is possible to go back to
        that easier and faster method to render Transparency.
        
        For extended information, please take a look at the
        added comments, mainly in vclhelperbufferdevice.hxx
        
        Identified a still bad behaviour when objects use a
        TransparenceGradient. Corrected that and added (at
        this opportunity) a method 'createAlphaMask' along
        with 'convertToBitmapEx' which is now used in the
        GlowPrimitive2D & ShadowPrimitive2D which only need
        the AlphaMask to do their job anyways (I had commented
        there that thjis is possible before). That will
        be faster for visualizing those Primitives.
        
        Change-Id: Ieac880384de26960c2c4b8740a1dee1e15d7ac9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140022
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-19  Noel Grandin  <noelgrandin@gmail.com>  [4973de104da87e522fe1f485984c081bc0be1b36]

        simplify usage of TempFile in Graphic(In/Out)putStream
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: Icdfcb96b002c489dee51c03b69127c21be5c85ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Mike Kaganski  <mike.kaganski@collabora.com>  [8a713c3b46a9b476b92f848451472e4a2618e4ef]

        OSL_ENSURE->assert where we would crash if not true
        
        Change-Id: I1d922034aa1be709bcd1c77886d773835683b7d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140132
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-19  Mike Kaganski  <mike.kaganski@collabora.com>  [993695d75faa23776d6a664a214cc69546f1f8ae]

        OSL_ENSURE->assert where we would crash if not true
        
        Change-Id: Ib6c2806070ae11b5542fcbba284f2640400bf984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140131
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-19  Noel Grandin  <noelgrandin@gmail.com>  [c6c1445fe8d16fe98f809c31612c2bdddde946da]

        simplify usage of TempFile in XMLFilterJarHelper
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: Ied68dd4c22e77c2a4e2c81f965413a55fb1e563d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-19  Noel Grandin  <noelgrandin@gmail.com>  [d99bfa6e6829c708b62c804c0754ee90c976ce6a]

        improve usage of TempFile in SdrPowerPointImport
        
        TempFile already handles the stream. And not touching the URL
        means we stay on the fast path for temp files.
        
        Change-Id: I05c70c422275032deeadc9f2f62024eebad8fb02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-18  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [349e3af0c5dd5ed495ed61aab526f63c16f0e215]

        Checkboxes don’t need title casing
        
        Change-Id: I2f23240ff1f6edcefd3cc10605f3f0d924265795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140129
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-18  Julien Nabet  <serval2412@yahoo.fr>  [35784dffccd6a950c72e9426a6d5bf0cca433aab]

        Simplify by using replaceAll instead of insert in some loops (sc)
        
        Change-Id: I1defbbcd391230b928d57ebd049c514781bf720a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140107
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-18  Caolán McNamara  <caolanm@redhat.com>  [b59177e5ced9dcbbc20bacee17a3f0f2b19a44c8]

        cid#1515457 Unintended sign extension
        
        Change-Id: I187001b55aef6e0751cb846fe927e4af07e1a018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-18  Caolán McNamara  <caolanm@redhat.com>  [abe551fbc98ece2c2616f1b3e802ea8aedd02933]

        cid#1514676 perturb Logically dead code
        
        Change-Id: Iac0ae44be5e53364af25a4a2055359db32c33701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140120
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-18  Mike Kaganski  <mike.kaganski@collabora.com>  [1f985cb4779b581a77d419605ceb084707d408b8]

        tdf#151039: use the same defaults also for FontSubsetInfo::m_aFontBBox
        
        The defaults for "maFontBBox is not valid" case were already introduced
        in commit 2d1f08d63942666c0094904f50ba8c512ab69b9d
          Author Release Engineers <releng@openoffice.org>
          Date   Thu Aug 27 12:02:29 2009 +0000
            CWS-TOOLING: integrate CWS otf01
        
        but it used the four elements of maFontBBox unconditionally in later
        calculations. Possibly that code path is untested, because unless the
        wrong size is greater than 4, it would always crash.
        
        Unfortunately, use of { 0, 0, 0, 0 } here (as Khaled proposed in the
        bug, for "garbage in, garbage out" principle) is impossible: the PDF
        with such data shows an error in Acrobat Reader: "The font contains
        a bad /BBox".
        
        As Khaled mentioned, a better fix would be to use the equivalent font
        extents from head table.
        
        Change-Id: I949db23d8af7c1fd4c2362655bf602eea0e70062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140121
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-18  Justin Luth  <jluth@mail.com>  [e66606a3334a575a183e57360c7a4696b73393c8]

        crashtesting: "unknown cell text: element" assert for text:bookmark
        
        since...
        
        commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1
        Date:   Sat Sep 10 16:32:46 2022 -0400
        
            tdf#103829 ods import: parse <text:tab/>
        
        Change-Id: Ia157c3503b119f2fa8daf31870894344e0313204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140112
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6da65808a7cb603b0028a12306601d6bb4aefcc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd2deec2da512a3630cdadfd81cb553fb158b14a
          - tdf#119421 Add details on conditional formatting data bars
            
            Change-Id: I1215e909e73dfd9707299ed98f794eea689423d9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140111
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-18  Noel Grandin  <noelgrandin@gmail.com>  [898ba5beb4db4ff30cc4409da829c3d79907f37e]

        use more string_view in utl::TempFile
        
        Change-Id: I151c66479053b9b5b7699a4938a622b4320aeaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-18  Caolán McNamara  <caolanm@redhat.com>  [ca3d526a24390df6158bf233fa63e19f5f4b1f4b]

        crashtesting: "unknown cell text: element" assert
        
        on e.g. import of fdo74225-2.ods
        
        since...
        
        commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1
        Date:   Sat Sep 10 16:32:46 2022 -0400
        
            tdf#103829 ods import: parse <text:tab/>
        
        Change-Id: I3eaffda8d9815564d314edf613832173313e46a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140110
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bfb0dbee201a69c26293947c78356f320ff62a0b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c924256f4ea9c328d7b384b2cff31829399decd
          - tdf119421 - More on conditional formatting/Icon sets
            
            + Housekeeping
            + handle icon images in the XSLT
            + Fill missing information on Icon Sets.
            
            Change-Id: Iaab3e1231ad4a2212adfc1d353a593cc116c7978
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140108
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f8cfc4d07e0291edc11d64e9f32d6f875ba9b297]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 112fa92d3b4c9c643c76afbfe3b04269308a7705
          - Unclutter table in Conditional Format Help page
            
            Change-Id: Ia5b12237e4be3e674701ace0194994faa2a8b69d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140094
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [e39fa3c4f5ae2560a4b6f6f789a0c5098ac43cf4]

        Simplify b2d(poly)polygon implementation
        
        Most size checks should be only done in the outer object; implementations
        inside cow_wrapper only assert correctness. All const_cast and as_const
        are replaced with correct const method calls (and, where needed, mutable
        members).
        
        Change-Id: I69e9f72086d07257ebd5cefaff7f214e198b901e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140106
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f295ab96fea5ac71592ea9b92610db9d441d1bd5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 021c2e7aacebb92e8272bac8cb1dc5b53a1e10e0
          - Fix typo
            
            Change-Id: I599ef997dd6819c0d08e69afdac206a4c5da55f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139820
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-17  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [7369e3012ddde90e987b055302fcc20e40754556]

        upgrade to libwebp-1.2.4
        
        Change-Id: Iaa3872345abcc2b9042abb32a824ff4b95ec57b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139921
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-17  Caolán McNamara  <caolanm@redhat.com>  [9788961cc30e151adcc32044d16899a5406d2c51]

        ofz: bump sc-rtf and html max lengths
        
        Change-Id: Id3400c686fefbf395e459ee9a654382bac87f141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [0ce0f7f81f53d8ac416c439ca2ec9b4ebbb305a5]

        loplugin:staticmethods (clang-cl)
        
        Change-Id: I875b60fba5267e158ac85d1442133f1bd4bfe560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140099
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [61576dbeda71add6bd36da628bd3b626aa823a77]

        loplugin:loopvartoosmall (clang-cl)
        
        Change-Id: I8925e28d46f1ed983581b539cfbe6a01c034e0ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140098
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [9bed2b595688e73a72688852ec5d949d59fb7c2a]

        -Werror,-Wshadow (clang-cl)
        
        Change-Id: I58d99d17baf8dc13e4dc951bf281d7c7c358d259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140101
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [90b25330a2b67da084c500d3f15ebf2b978462b9]

        external/gpgmepp: Fix various -Wincompatible-function-pointer-types
        
        ...after Clang 16 trunk
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error".  The
        changes in workdir/UnpackedTarball/gpgmepp/src/assuan-support.c are due to the
        difference between ssize_t as used by
        
        >   ssize_t (*read) (assuan_context_t ctx, assuan_fd_t fd, void *buffer,
        > 		   size_t size);
        >   ssize_t (*write) (assuan_context_t ctx, assuan_fd_t fd,
        > 		    const void *buffer, size_t size);
        
        in workdir/UnpackedTarball/libassuan/src/assuan.h and gpgme_ssize_t as defined
        by
        
        > #ifdef _WIN64
        > # include <stdint.h>
        >   typedef int64_t gpgme_off_t;
        >   typedef int64_t gpgme_ssize_t;
        > #else /* _WIN32 */
        >   typedef long gpgme_off_t;
        >   typedef long gpgme_ssize_t;
        > #endif /* _WIN32 */
        
        in workdir/UnpackedTarball/gpgmepp/src/gpgme.h:
        
        > assuan-support.c(353,5): error: incompatible function pointer types initializing 'ssize_t (*)(assuan_context_t, assuan_fd_t, void *, size_t)' (aka 'long (*)(struct assuan_context_s *, void *, void *, unsigned long long)') with an expression of type 'gpgme_ssize_t (assuan_context_t, assuan_fd_t, void *, size_t)' (aka 'long long (struct assuan_context_s *, void *, void *, unsigned long long)') [-Wincompatible-function-pointer-types]
        >     my_read,
        >     ^~~~~~~
        > assuan-support.c(354,5): error: incompatible function pointer types initializing 'ssize_t (*)(assuan_context_t, assuan_fd_t, const void *, size_t)' (aka 'long (*)(struct assuan_context_s *, void *, const void *, unsigned long long)') with an expression of type 'gpgme_ssize_t (assuan_context_t, assuan_fd_t, const void *, size_t)' (aka 'long long (struct assuan_context_s *, void *, const void *, unsigned long long)') [-Wincompatible-function-pointer-types]
        >     my_write,
        >     ^~~~~~~~
        
        Change-Id: I71f34da1a14421335a9416dd500a91d94de2f48a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140097
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [ba4241ee9987492061e9bfb07beb1bbd2bae67c8]

        Silence -Werror,-Wdeprecated-copy-with-user-provided-copy (clang-cl)
        
        > In file included from cppuhelper/source/access_control.cxx:21:
        > include\cppuhelper/access_control.hxx(58,5): error: definition of implicit copy assignment operator for 'AccessControl' is deprecated because it has a user-provided copy constructor [-Werror,-Wdeprecated-copy-with-user-provided-copy]
        >     AccessControl( ::cppu::AccessControl const & ac );
        >     ^
        > include\cppuhelper/access_control.hxx(37,44): note: in implicit copy assignment operator for 'cppu::AccessControl' first required here
        > class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC AccessControl
        >                                            ^
        > include\cppuhelper/access_control.hxx(37,23): note: due to 'AccessControl' being dllexported
        > class SAL_WARN_UNUSED CPPUHELPER_DLLPUBLIC AccessControl
        >                       ^
        > include\cppuhelper/cppuhelperdllapi.h(30,30): note: expanded from macro 'CPPUHELPER_DLLPUBLIC'
        > #define CPPUHELPER_DLLPUBLIC SAL_DLLPUBLIC_EXPORT
        >                              ^
        > include\sal/types.h(208,47): note: expanded from macro 'SAL_DLLPUBLIC_EXPORT'
        > #   define SAL_DLLPUBLIC_EXPORT    __declspec(dllexport)
        
        Change-Id: I89b534b33c29fdc2d458087e1f3c2f4c958aa86c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140096
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Stephan Bergmann  <sbergman@redhat.com>  [3c967717d315fba0aa7b1a1ba3567edc0a88bb69]

        external/firebird: Fix -Wincompatible-function-pointer-types
        
        ...after Clang 16 trunk
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error"
        
        Change-Id: Ibe06a94f45010efdeaf0c05a661f269e7a07d561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140095
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-17  Caolán McNamara  <caolanm@redhat.com>  [ce8256032edef03320f9d6ba6deba85977209e8f]

        toggle the other togglebutton to the inverse state of this togglebutton
        
        Change-Id: I7e19fdb89b1503644a49d8beaef9ada3fe6beabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140085
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-17  Caolán McNamara  <caolanm@redhat.com>  [46169355558e017a94a1859ba206fd9e4e1e9106]

        cid#1500499 Resource leak
        
        the only change should be to the two trailing cases in
        OSQLParseNode::substituteParameterNames which do seem to leak.  The
        closest I got to triggering the actual code is toggling into sqlview
        mode of a query but couldn't quite construct a sql statement to trigger
        it.
        
        Change-Id: I320dc4df3b18a18b236c91ee30329c10001c9a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-17  U-LAPTOP-06BFT6KB\Client  <andreamassimo03@gmail.com>  [c1e65e8010348b39ba9ffadd3ebfd2587a969c82]

        tdf#143148 use pragma once instead of include guards
        
        Change-Id: I413382bfe1edc9c9827af338cfbbd17262e839ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140083
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d5752be6f2168ad8b1a81458955bf8d3d5bdffb]

        speed up large sheet with lots of conditions
        
        shaves 10% off view load time
        
        Change-Id: Iecb1274e35da2294f796376ebdc62eab509e5480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140071
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [d2184f3776b4528b7203b6789d0b185c5ea47cb6]

        speed up large sheet with lots of conditions
        
        shaves 10% off view load time
        
        Change-Id: I51078ef81613faa2f8c37530fb7dc77b73192525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [3752e8eaa81a50b018669d03dc59b3753a5248ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b0c4a0d68e1e2bf0ab4f89b06a15402ffe8daa30
          - tdf#150989 Document "Math baseline" option in Writer
            
            Change-Id: I1746ce0c2a0c414b0217b5df93f20f599d1537b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139985
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3bbdfab809609bec3475613a918eda699fbdc29]

        tdf#150974 Writer crashes when starting with WollMux installed
        
        regression from
            commit b2aa646ef09dc8434d3ca8a5bba53a8d8ff3f910
            Author: Caolán McNamara <caolanm@redhat.com>
            Date:   Wed Dec 15 11:43:32 2021 +0000
            use more OInterfaceContainerHelper3 in toolkit
        
        Change-Id: I26532ea79b7c5f750b4bf693881cbf41aeb82266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-16  Jim Raykowski  <raykowj@gmail.com>  [d87e1859cbd41a623f48a9522507ab0adc8e7324]

        SwNavigator: Make Drawing objects context menu entry 'Edit..' edit
        
        This patch uses SwEditWin::KeyInput handling of KEY_RETURN for the
        Drawing objects context menu entry 'Edit...' which moves focus of the
        selected drawing object into the text box of the drawing object.
        Previous to this patch the 'Edit...' menu entry would select the
        drawing object the same as the 'Go to' menu entry.
        
        Change-Id: I4d6d278e25badd086dc718c4c7ea02ce6330a45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140037
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-16  Caolán McNamara  <caolanm@redhat.com>  [a5eb6660ed85afb706527704e1170a35e0677cf8]

        cid#1514676 perturb mysterious Logically dead code warning
        
        throw a const at it
        
        Change-Id: I273c85329765e1655cfde9efdf5422e5bb90ee57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140082
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-16  Jim Raykowski  <raykowj@gmail.com>  [dced115279b953735040663f71a2e848762672d7]

        tdf#150589 Set cursor to better position after deleting a drawing
        
        object
        
        Cutting a drawing object involves SwWrtShell::DelRight which uses the
        drawing object's frame top-left point to set the cursor after
        deleting. Delete and Backspace do not use SwWrtShell::DelRight to
        delete a drawing object. This patch makes Delete and Backspace
        position the cursor like Cut after drawing object delete.
        
        Change-Id: I6dc07eccc8397393a230368a20b0589e6d57a89a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140036
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-16  Caolán McNamara  <caolanm@redhat.com>  [c690d7c3d49d887fab85f8040fa91965b4ab2781]

        cid#1513720 silence Improper use of negative value
        
        negative col doesn't seem to arise in this branch, seems it can only
        negative for the other direction and/or for styles which isn't handled
        in this method.
        
        Change-Id: I3a50ebef57a84e808a03fc677030acfd7605230d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-16  Caolán McNamara  <caolanm@redhat.com>  [bb1f2894e40881abcfcb0372b2b3c8fae5b8cd6d]

        OSL_ENSURE->assert where we would crash if not true
        
        Change-Id: I1544573ea9f57b5ca732c9b05acae9b4f91f53ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-16  Julien Nabet  <serval2412@yahoo.fr>  [bd3ef7afcc4548976303df9b58e50436c11e4736]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to ac6502c9f80eb897384e0bfb8f0879b668b6cf87
          - Add missing ref to Mongolian dictionary icon in Dictionary_mn.mk
            
            Change-Id: I1a50615c6e5c7e6502bc62e66b8bc228376be356
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/139981
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-09-16  Julien Nabet  <serval2412@yahoo.fr>  [cfb5bd869eda186fc7b899a81cead881e74646e3]

        [-Wmaybe-uninitialized]
        
        Change-Id: Iff7423ab7cc1523e01be8546ee1bf18b7853c9cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140084
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe9bce8049ef8749981ede192559ad71572b94d4]

        create less SwPosition temporaries
        
        because they need to hook themselves into global rings, which results in
        a lot of unnecessary pointer chasing
        
        Change-Id: I27173c5f0d5e2998fdbfbb7781e2cbd1be6d14b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140065
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Caolán McNamara  <caolanm@redhat.com>  [6c32fade56c56dcb7ef3101d27dbba0226825c69]

        only "PaintImmediately" the statusbar itself (and optional children)
        
        PaintImmediately normally checks to see if there are paints pending
        on any of the original candidates parents, and if there are, optimizes
        painting by painting from the top windows that is avaiting being
        painted.
        
        But in JunitTest_sc_unoapi_3 sometimes the ScGridWindow parent of the
        StatusBar happens to have outstanding paint requests when the immediate
        paint of the StatusBar is requested and there is deadlock on calling
        ScGridWindow::Paint where the soffice main thread wants to lock the
        SolarMutex at
        
        > #0: 0x00000001a110e270 libsystem_kernel.dylib`__psynch_cvwait + 8
        > #1: 0x00000001a114883c libsystem_pthread.dylib`_pthread_cond_wait + 1236
        > #2: 0x0000000101081dd8 libc++.1.0.dylib`std::__1::condition_variable::wait at ~/llvm/build/include/c++/v1/__threading_support:337:10
        > #3: 0x0000000101081dd4 libc++.1.0.dylib`std::__1::condition_variable::wait at ~/github.com/llvm/llvm-project/libcxx/src/condition_variable.cpp:46:14
        > #4: 0x0000000112a011d4 libvclplug_osxlo.dylib`void std::__1::condition_variable::wait<SalYieldMutex::doAcquire(unsigned int)::$_0> at ~/llvm/inst/include/c++/v1/__mutex_base:398:9
        > #5: 0x0000000112a00f98 libvclplug_osxlo.dylib`SalYieldMutex::doAcquire at vcl/osx/salinst.cxx:221:36
        > #6: 0x0000000115e6b920 libvcllo.dylib`comphelper::SolarMutex::acquire at include/comphelper/solarmutex.hxx:86:5
        > #7: 0x0000000116637178 libvcllo.dylib`SalInstance::AcquireYieldMutex at vcl/source/app/salvtables.cxx:149:73
        > #8: 0x00000001166f0c38 libvcllo.dylib`Application::AcquireSolarMutex at vcl/source/app/svapp.cxx:594:25
        > #9: 0x0000000112a07b38 libvclplug_osxlo.dylib`SolarMutexReleaser::~SolarMutexReleaser at include/vcl/svapp.hxx:1447:29
        > #10: 0x0000000112a03320 libvclplug_osxlo.dylib`SolarMutexReleaser::~SolarMutexReleaser at include/vcl/svapp.hxx:1447:27
        > #11: 0x0000000112a02d40 libvclplug_osxlo.dylib`AquaSalInstance::DoYield at vcl/osx/salinst.cxx:559:9
        > #12: 0x00000001166f01c0 libvcllo.dylib`ImplYield at vcl/source/app/svapp.cxx:475:48
        > #13: 0x00000001166efbc8 libvcllo.dylib`Application::Yield at vcl/source/app/svapp.cxx:559:5
        > #14: 0x00000001166ef958 libvcllo.dylib`Application::Execute at vcl/source/app/svapp.cxx:453:13
        > #15: 0x00000001017a41a8 libsofficeapp.dylib`desktop::Desktop::Main at desktop/source/app/app.cxx:1604:13
        
        while another thread
        
        > #0: 0x00000001a110e270 libsystem_kernel.dylib`__psynch_cvwait + 8
        > #1: 0x00000001a114883c libsystem_pthread.dylib`_pthread_cond_wait + 1236
        > #2: 0x00000001a20e87c8 Foundation`-[NSOperation waitUntilFinished] + 580
        > #3: 0x00000001a11d8210 CoreFoundation`_CFXNotificationPost + 812
        > #4: 0x00000001a209dc98 Foundation`-[NSNotificationCenter postNotificationName:object:userInfo:] + 96
        > #5: 0x00000001a3d6de0c AppKit`-[NSMenu insertItem:atIndex:] + 624
        > #6: 0x00000001a3f92784 AppKit`-[NSApplication(NSServicesMenuPrivate) _fillSpellCheckerPopupButton:] + 1888
        > #7: 0x00000001a3f91bf0 AppKit`-[NSSpellChecker _fillSpellCheckerPopupButton:] + 84
        > #8: 0x00000001a3f90ae8 AppKit`-[NSSpellChecker init] + 284
        > #9: 0x00000001a3f909bc AppKit`__36+[NSSpellChecker sharedSpellChecker]_block_invoke + 20
        > #10: 0x00000001a0f841b4 libdispatch.dylib`_dispatch_client_callout + 20
        > #11: 0x00000001a0f85a34 libdispatch.dylib`_dispatch_once_callout + 32
        > #12: 0x00000001a3f909a4 AppKit`+[NSSpellChecker sharedSpellChecker] + 140
        > #13: 0x000000028e51d364 libMacOSXSpelllo.dylib`MacSpellChecker::getLocales at lingucomponent/source/spellcheck/macosxspell/macspellimp.mm:117:42
        > #14: 0x00000001120a99d8 liblnglo.dylib`LngSvcMgr::GetAvailableSpellSvcs_Impl at linguistic/source/lngsvcmgr.cxx:963:67
        > #15: 0x00000001120ad1dc liblnglo.dylib`LngSvcMgr::getAvailableServices at linguistic/source/lngsvcmgr.cxx:1381:9
        > #16: 0x00000001120ada4c liblnglo.dylib`LngSvcMgr::getAvailableLocales at linguistic/source/lngsvcmgr.cxx:1445:42
        > #17: 0x00000001120a1d28 liblnglo.dylib`LngSvcMgr::UpdateAll at linguistic/source/lngsvcmgr.cxx:657:49
        > #18: 0x00000001120a0fec liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:414:5
        > #19: 0x00000001120a2c50 liblnglo.dylib`LngSvcMgr::LngSvcMgr at linguistic/source/lngsvcmgr.cxx:402:1
        > #20: 0x00000001120b1248 liblnglo.dylib`::linguistic_LngSvcMgr_get_implementation at linguistic/source/lngsvcmgr.cxx:1826:30
        [...]
        > #30: 0x000000010449a164 libeditenglo.dylib`com::sun::star::linguistic2::LinguServiceManager::create at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/linguistic2/LinguServiceManager.hpp:38:129
        > #31: 0x00000001044973d4 libeditenglo.dylib`GetLngSvcMgr_Impl at editeng/source/misc/unolingu.cxx:60:52
        > #32: 0x000000010449bbb0 libeditenglo.dylib`(anonymous namespace)::SpellDummy_Impl::GetSpell_Impl at editeng/source/misc/unolingu.cxx:216:61
        > #33: 0x000000010449b548 libeditenglo.dylib`(anonymous namespace)::SpellDummy_Impl::isValid at editeng/source/misc/unolingu.cxx:248:5
        > #34: 0x000000010439f2a0 libeditenglo.dylib`ImpEditEngine::DoOnlineSpelling at editeng/source/editeng/impedit4.cxx:2268:37
        > #35: 0x00000001042a3a14 libeditenglo.dylib`EditEngine::CompleteOnlineSpelling at editeng/source/editeng/editeng.cxx:2394:25
        > #36: 0x000000028fb26974 libsclo.dylib`sc::SpellCheckContext::ensureResults at sc/source/ui/view/spellcheckcontext.cxx:339:15
        > #37: 0x000000028fb2648c libsclo.dylib`sc::SpellCheckContext::isMisspelled const at sc/source/ui/view/spellcheckcontext.cxx:219:43
        > #38: 0x000000028fabd63c libsclo.dylib`ScOutputData::LayoutStrings at sc/source/ui/view/output2.cxx:1640:61
        > #39: 0x000000028fabc79c libsclo.dylib`ScOutputData::DrawStrings at sc/source/ui/view/output2.cxx:1471:5
        > #40: 0x000000028fa788e4 libsclo.dylib`ScGridWindow::DrawContent at sc/source/ui/view/gridwin4.cxx:914:21
        [...]
        > #59: 0x0000000115d6a9c0 libvcllo.dylib`vcl::Window::ImplCallPaint at vcl/source/window/paint.cxx:623:1
        > #60: 0x0000000115d6cc78 libvcllo.dylib`vcl::Window::PaintImmediately at vcl/source/window/paint.cxx:1335:24
        > #61: 0x0000000115f47d7c libvcllo.dylib`StatusBar::StartProgressMode at vcl/source/window/status.cxx:1327:9
        > #62: 0x00000001066ff8c4 libfwklo.dylib`framework::ProgressBarWrapper::start at framework/source/uielement/progressbarwrapper.cxx:111:21
        > #63: 0x000000010671edfc libfwklo.dylib`framework::StatusIndicatorInterfaceWrapper::start at framework/source/uielement/statusindicatorinterfacewrapper.cxx:50:27
        > #64: 0x00000001099ae138 libsfxlo.dylib`SfxProgress::SetState at sfx2/source/bastyp/progress.cxx:230:32
        > #65: 0x000000028e94e558 libsclo.dylib`ScProgress::SetState at sc/inc/progress.hxx:85:52
        > #66: 0x000000028ec7f954 libsclo.dylib`ScTable::Sort at sc/source/core/data/table3.cxx:1817:28
        > #67: 0x000000028e931380 libsclo.dylib`ScDocument::Sort at sc/source/core/data/documen3.cxx:1450:23
        > #68: 0x000000028f43ad90 libsclo.dylib`ScDBDocFunc::Sort at sc/source/ui/docshell/dbdocfun.cxx:611:14
        > #69: 0x000000028f798e18 libsclo.dylib`ScCellRangeObj::sort at sc/source/ui/unoobj/cellsuno.cxx:5317:17
        > #70: 0x0000000106268964 libgcc3_uno.dylib`callVirtualFunction at bridges/source/cpp_uno/gcc3_linux_aarch64/callvirtualfunction.cxx:38:5
        [...]
        > #73: 0x000000012252f650 libbinaryurplo.dylib`binaryurp::IncomingRequest::execute_throw const at binaryurp/source/incomingrequest.cxx:236:13
        
        Change-Id: Iecfbc7673a2c67851aede3f7ca8be24ee75d1b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [b92c4de7da81318abefce4750e826ac59094b748]

        Related: tdf#144092 improve wording
        
        Attempts to address concerns pointed out by Justin in:
        https://gerrit.libreoffice.org/c/core/+/138652/#message-6dd69691fbaabf26424b4c3fb85f42e550b53ee2
        
        Change-Id: I1af4d316fae73626ce734ca60c6539502eb80f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140067
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [28a7615ccdd000270f71e2eb32efeec4c87780f1]

        Fix typo
        
        Change-Id: I95626407aa025d2535e45f28a0b08e696c98d36c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140076
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-16  Regina Henschel  <rb.henschel@t-online.de>  [6c635fb11af389d88f36d4bf6b43421af062086a]

        tdf#149551 unit test writing mode in shape in Impress
        
        Commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad has among other things
        enabled, that a shape in Impress can use a writing mode corresponding to
        vert='vert' in a pptx file. It is new value text::WritingMode2::TB_RL90
        for property WritingMode. It is written with value 'tb-rl90' to attribute
        loext:writing-mode in ODF.
        
        The same commit has enabled, that the writing mode 'bt-rl' can be used
        not only for frames in Writer but for shapes in Impress too.
        
        The unit tests here test round-trip of these property values.
        
        Change-Id: I8dcf9e234d25c2769ed60edd0e435c3606f368bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140066
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-09-16  Michael Weghorn  <m.weghorn@posteo.de>  [7dbbf8eba4a8131efe224b17a613cd09c4042dd4]

        wina11y: Drop unused CMAccessible helper methods
        
        Their doc says that they are for the
        `accSelect` implementation, but that one doesn't
        actually make use of them.
        
        Change-Id: I9185a905d00484fcb950a1bdb6013e07a089bb22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140069
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-16  Stephan Bergmann  <sbergman@redhat.com>  [b040cf97c343076d8b98b16b5275df663cb86669]

        OUString::matchIgnoreAsciiCase returns bool
        
        Regression introduced with d2272426cc79d9aacf4a34c5fd7744b59c29e95b "Use some
        more C++ in sal/osl/w32", found with loplugin:implicitboolconversion.
        
        Change-Id: I5d929dd64bc02559318b8c89cb66bb0f5bba33f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140072
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-16  Stephan Bergmann  <sbergman@redhat.com>  [b97e8b9d13ef0f57f7cf0badbefcb038a8bbd137]

        external/coinmp: Adapt to std::bind2nd gone from C++17
        
        ...which started to be an issue when building with recent Clang 16 trunk after
        <https://github.com/llvm/llvm-project/commit/3e99b8d947ac024831e59be2b604ac67a24fed94>
        "C++/ObjC++: switch to gnu++17 as the default standard" against libc++.  (Recent
        versions of GCC similarly default to C++17, but libstdc++ by default still
        provides bind2nd even for C++17.)  Alternatively, we could define
        _LIBCPP_ENABLE_CXX17_REMOVED_BINDERS to work around this.  But as these appear
        to be the only leftover occurrence of bind2nd across all of the code base, and
        all but one of them have already been addressed upstream, lets address it for
        good with this little patch.  (Where the last remaining occurrence not yet
        addressed upstream is fixed in the same way as the other upstream fixes, using a
        loop rather than e.g. a lambda that would force us to start to pass
        CXXFLAGS_CXX11 into ExternalProejct_coinmp.)
        
        Change-Id: Iddcdddd22ea4c6d537b64bf2cf0b887d11da162f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139931
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-16  Stephan Bergmann  <sbergman@redhat.com>  [47e0180a55130bd698682ec12a6bb79fce88ec72]

        external/firebird: Work around std::auto_ptr gone from C++17
        
        ...which started to be an issue when building with recent Clang 16 trunk after
        <https://github.com/llvm/llvm-project/commit/3e99b8d947ac024831e59be2b604ac67a24fed94>
        "C++/ObjC++: switch to gnu++17 as the default standard" against libc++:
        
        > src/cloop/Main.cpp:31:12: error: no member named 'auto_ptr' in namespace 'std'
        > using std::auto_ptr;
        >       ~~~~~^
        
        (Recent versions of GCC similarly default to C++17, but libstdc++ by default
        still provides auto_ptr even for C++17.)
        
        Adding -D_LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR to CXXFLAGS didn't work, though,
        as firebird apparently only honors CXXFLAGS during the configure step, but not
        in its makefiles.  So instead add it directly to CXX.  (Adding /all/ the
        CXXFLAGS to CXX caused issues at least on Windows, where
        <https://ci.libreoffice.org/job/gerrit_windows/135851/> failed with
        
        > Main.cpp
        > C:\cygwin\home\tdf\jenkins\workspace\gerrit_windows\workdir\UnpackedTarball\firebird\extern\cloop\src\cloop\Expr.h(25): fatal error C1034: string: no include path set
        
        etc.  This probably needs a general clean-up, and the other *FLAGS passed into
        the firebird build system might have a similar issue.)
        
        Change-Id: Idf0a5243938fddfb8348cc960074e60dea775650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139932
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-16  Julien Nabet  <serval2412@yahoo.fr>  [ef1827ff7c753500c0e94943e69ada0f22c1924f]

        Simplify by using replaceAll instead of replaceAt in a loop (sc/global2)
        
        Change-Id: I26a51eb3b4d5e6a0d8903c348bd0e6084521f117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140039
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab5928517639e49dbcab2c2de195849d611124b9]

        tdf#150987 calc crash pasting content
        
        regression from
        
            commit d0119ff7f2c68aa05286bd303128f3a69c6bbd6a
            improve tools::Rectangle->basegfx::B2?Rectangle conversion
        
        which resulted in Fraction throwing an exception because of
        divide-by-zero
        
        Change-Id: I90a92a644c5fb40e9b93237c79f6760d4bb73d0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140064
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ebd7cc1848ba2010128d09c5db524af2c6f5aa66]

        tdf#150845: sw_uiwriter3: Add unittest
        
        Change-Id: I9d39964218cae2fade7ef04badb57b8086cc3a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140060
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-16  Mike Kaganski  <mike.kaganski@collabora.com>  [2875d11939679ec319e5b098a9b85da629781d5c]

        tdf#150982: properly unquote (URL-decode) vnd.sun.star.expand payload
        
        Similar to what is done in bootstrap_expandUri, expandUnoRcUrl,
        UrlReference::expand, JavaLoader.expand_url, and is documented
        in XVndSunStarExpandUrl interface.
        
        Change-Id: I92917adb38e42c3926494427e4df2451298033e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140042
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-16  Michael Weghorn  <m.weghorn@posteo.de>  [b855f9d430c4dce2936e7bd1208159bc38d5b199]

        tdf#137341 gtk: Set missing style text colors from theme
        
            commit 8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f
            Date:   Sun Feb 23 21:11:05 2020 +0100
        
                tdf#125532: White text on default/action buttons and selected tabs on macOS
        
        had introduced various new text colors to the style
        settings, but some were not set from the theme for gtk.
        
        Add the missing ones.
        
        Change-Id: I1bd7ce358626b3f4ff1d6f2794d5c0f19f78a668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140058
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9706878b7352b985b3a38d47b30a6e872a266a2]

        Add more asserts to SwPosition constructor to catch dodgy data
        
        where the two node pointers point at different nodes
        
        Change-Id: Ib556fac6b753898cc879f2df28d86e12c4c8fbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e2b926f82dd0da2edd0ca6edaf6fc0a0a8ceef9]

        fix SwContentIndexPrinter pretty printer
        
        after
            commit 739f3bb7228fa8c33029af46093b4646f848814b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Aug 31 15:29:20 2022 +0200
            improve the SwContentIndex debug pretty printer
        
        Change-Id: Ib7b30f2f7d9a33f70243d8b72357b6f9823bc397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Michael Weghorn  <m.weghorn@posteo.de>  [155e8b1683f10847ff18e75287e2466220242bb1]

        tdf#117173: qt a11y: Forward changes to SHOWING state
        
        While Qt doesn't have an equivalent state for the SHOWING
        state used in LibreOffice and in IAccessible2, it has
        separate `QAccessible::ObjectHide` and `QAccessible::ObjectShow`
        event types used to indicate that an object changed state
        to being (no longer) displayed, so use those.
        
        In fact, Qt's `AtspiAdaptor` handles those by mapping them to
        state change events for the AT-SPI "showing" state again. [1]
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=ce16eb2679f69b28d2debd1ce18a99f7279b4295#n896
        
        Change-Id: Iae2b9ec26403d9a9887e86c4155ba64a73f19b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139812
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-16  László Németh  <nemeth@numbertext.org>  [5e71ec6aa0d4f9971f5e2b6f7091d18668c2f0b9]

        tdf#150790 tdf#150791 tdf#150947 tdf#150956 sw, a11y: fix visible bookmarks
        
        Fix bookmark visibility (see Tools -> Options -> LibreOffice Writer
        -> Formatting Aids -> Bookmarks):
        
        – tdf#150791 Paint I-beam symbol (⌶) for point bookmarks instead of
          a vertical line (which was overlapped with visible page margin at
          beginning of the paragraphs, also it was very similar to the NBSP
          and narrow NBSP shading). Modify associated dialog window label in
          optformataidspage.ui according to this.
        
        – tdf#150790 Neighboring bookmark ranges are shown as ][ instead of
          a single vertical line (which could not be distinguished from
          point bookmark symbol and overlapping page border).
          Note: this has been implemented for bookmarks with metadata colors
          since commit 412e0ab26618c38f548c340f85ef63bbe73ef6b2 "tdf#150717
          sw RDF metadata: add custom color bookmark boundary marks".
        
        – Multiple bookmarks at the same character position are visible
          now, e.g. instead of a single |, neighboring bookmarks with
          point bookmarks are shown as "] ⌶ [" or "] ] ⌶ ⌶ [ [" etc.
        
        – tdf#150956 Do not show hidden _Toc and _Ref bookmarks imported
          from OOXML, like MSO does.
        
        Add bookmark accessibility and layout dump:
        
        – Add SwBookmarkPortion::HandlePortion() to return with bookmark names
          and types, e.g. for ] ⌶ [ as
          "#Name1 Bookmark End#Name2 Bookmark#Name3 Bookmark Start"
          (where "Name1"–"Name3" are names of the bookmarks, while "Bookmark",
          "End" and "Start" are localized versions of these strings),
          allowing XML layout dump of bookmark data.
        
        – tdf#150947 Extend SwAccessiblePortionData::Special() to forward the
          previous HandlePortion() bookmark data to screen readers depending on
          bookmark visibility (i.e. SwViewOption::IsShowBookmarks()).
        
        – Add unit tests based on the extended XML layout dump, also
          adjust existing unit tests.
        
        More visibility fixes:
        
        – multiple start marks of range bookmarks positioned before
          the character position, multiple end marks of range bookmarks
          positioned after the character position, i.e.
          single type boundary marks are there outside of the bookmark text
        
          some |text| here
              [[    ]]
        
        – neighboring end and start marks are centered around the
          character position:
        
           |text1|text2|
          [    ]] [[    ]
        
        – marks of the same character position are sorted based on their
          type and metadata color:
        
          – mark order: ], ⌶, [, e.g.
        
          ] ] ⌶ ⌶ [ [ [
        
          – color order: reversed at bookmark end, e.g.
        
          [c1 [c2 [c3 ... c3] c2] c1]
        
        Follow-up to commit 412e0ab26618c38f548c340f85ef63bbe73ef6b2
        "tdf#150717 sw RDF metadata: add custom color bookmark boundary marks"
        and commit 4ce8120f1e53f7b81e653b01d141643013bc69ab
        "tdf#45589 sw: create and paint text portions for bookmarks".
        
        Change-Id: Ia53903efbc44a531338b8615d9812d6da270e39f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139817
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-16  Heiko Tietze  <tietze.heiko@gmail.com>  [164a1f4c3315fc44161128d3d9ca886f767f7d30]

        Resolves tdf#80934 - GUI means to filter thumbnails in start center
        
        Resolves also tdf#92499 by removing the (badly placed) context menus
        from the left pane into the new "toolbar"
        
        Change-Id: I8e15d30380d4d915ed109877d716e1a4689885c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139730
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-09-16  Miklos Vajna  <vmiklos@collabora.com>  [08bce8eeb2e18c7cea4108dbfc2519ada56e8b61]

        sw content controls: fix getString() and setString() on SwXContentControl
        
        The setter was broken, it inserted the new content at the start, but
        didn't delete the old content. The getter was also broken, it returned
        an empty string, even if the content control had a non-empty content.
        
        This was always a problem since c4268efef25129b162884312b15527f1e5c3bcb0
        (sw content controls: add UNO API to insert this, 2022-03-31) introduced
        SwXContentControl.
        
        Fix the problem by extending SwXTextCursor, so in case m_eType is
        CursorType::ContentControl, then it keeps the cursor's range inside the
        boundaries of the content control.
        
        This also allows changing the data binding code added in
        b5c616d10bff3213840d4893d13b4493de71fa56 (tdf#104823: support for sdt
        plain text fields, 2021-11-24) to use content controls, in a follow-up
        commit.
        
        Change-Id: Ic3ae47a4b26af090539d61035372f1784c8ffe3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140040
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-16  Chris Sherlock  <chris.sherlock79@gmail.com>  [a2aaa6b77457041e08610eb4bced2d050ea7fa4f]

        vcl: AnimationBitmap -> AnimationFrame
        
        The emphasis is not quite right. An animation is made up a sequence of
        *frames*, not bitmaps. A frame includes such things as position, size,
        timeout till the next frame *as well as* a bitmap.
        
        Note: had to regenerate a bunch of precompiled headers
        
        Change-Id: Ib1959452653857555f41e01ac0151d08c41a3b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76460
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-16  Noel Grandin  <noelgrandin@gmail.com>  [3521cf575c1cede6b60318ddb561fc9184c8c16d]

        use SwPosition in SwArgsBase
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I3fb116fb9ce56ba5c6efb5c4954eb4a93a7fe722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Noel Grandin  <noelgrandin@gmail.com>  [fb93533d4be619d5d4e87175d87da77c26f85912]

        use more SwPosition::AdjustContent
        
        part of hiding the internals of SwPosition
        
        Change-Id: Iaa30a4fe39bc8f0140cc00e727330ebb82f68036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140028
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Noel Grandin  <noelgrandin@gmail.com>  [9473fa94abf06745d6d5e8c133a01747da2e56fb]

        use more SwPosition::AdjustContent
        
        part of hiding the internals of SwPosition
        
        Change-Id: If4e4bf99be1d380dbc61346f2701c255eae1af80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140027
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-16  Miklos Vajna  <vmiklos@collabora.com>  [493b10997053882d06803156a98ae8924bf7660d]

        sw content controls: add PDF export of font properties
        
        Like font name or size.
        
        Change-Id: Ie7b0d38be0ef69faf364b7c801d0bd3fdd60777a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140038
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-16  Michael Weghorn  <m.weghorn@posteo.de>  [c317f0adb308b1ece3bfa8bdffb4d0bcb1478d30]

        tdf#136928 Use dialog text color for signs in "Tabs" dialog
        
        and use an explicit matching background of dialog color
        
        Since the font color is black even in dark themes
        like "Adwaita-Dark", using a dark style/theme would previously
        result in black signs on a dark background for the Qt-based VCL
        plugins (qt5/kf5/qt6).
        
        Change-Id: I470011c26861221310e898c8f63fceef5e1aca3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140029
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-16  Miklos Vajna  <vmiklos@collabora.com>  [9b2327ce994771208a07479ca2aa13c63a124c98]

        CppunitTest_sw_uiwriter2: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I617d9ea2a46a69d9c214a191e23dbe84c6dd36be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140030
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-16  Justin Luth  <jluth@mail.com>  [eab9015d1e17950ee5a49f93a6ad40e7726f5050]

        tdf#103829 ods export: don't output invalid office:string-value
        
        If the formatted (i.e. \t) string was different from
        the raw string (i.e. \x001 EE_FEATURE_TAB marker),
        then export was outputing office:string-value
        with IsInvalidChar \x001.
        
        The impact on import is that the cell wants to display
        this string-value, which is missing all of the "invalid char"
        stuff. So, just don't export a wrong string at all.
        
        Change-Id: Ib98e58d0c6e1186d199a4dcf294b56403b710f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139816
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [f63a8fdcd964629cb6d72e17d00c6170e942df2c]

        uitest: sw: use wait_until_property_is_updated
        
        Seen in Jenkins
        FAIL: test_load_styles_from_template (stylesSidebar.StylesSidebar)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sw/qa/uitest/sidebar/stylesSidebar.py", line 69, in test_load_styles_from_template
            self.assertEqual(expectedResults[i], get_state_as_dict(xFlatView)['SelectEntryText'])
        AssertionError: 'customParagraphStyle' != ''
        - customParagraphStyle
        +
        
        Change-Id: I8b97a3a09025768d81969f01b3393126e1ec18dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-15  Noel Grandin  <noelgrandin@gmail.com>  [91b95e6f4ae0cdc1e9173e421666e1b318e6ef1d]

        use more SwPosition::GetContentIndex
        
        part of hiding the internals of SwPosition
        
        Change-Id: I46cea75089faa742de4b8f26a9594e30d224a646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [3d9f7d16298760b537c4cb1c5c0e1f4875e0bc36]

        cid#1500398 silence Use after free
        
        I am just going to blithely assume this doesn't actually happen
        
        Change-Id: Iad325f2f4e5243f27b6122e95522a979637a1692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [399f0aa2beb01637b343a7ce1da935b44f4bd059]

        cid#1509213 silence Dereference after null check
        
        Change-Id: Ib260440105930f173d5ffd011c76f90c898e34e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140023
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Noel Grandin  <noelgrandin@gmail.com>  [45c7f90951b6b9f2e78e6803948d58f16d3cb859]

        use more SwPosition::AdjustContent
        
        part of hiding the internals of SwPosition
        
        Change-Id: I9f91933e0d31b455a49e4872281c4a46d518d418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140026
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-15  Tor Lillqvist  <tml@collabora.com>  [8d0e40b331cf45b59dc14351eb0ca06aba41ebb0]

        Fix building without system cairo, fontconfig, freetype, and harfbuzz
        
        At least for me, this was needed when I added --without-system-cairo
        --without-system-fontconfig --without-system-freetype
        --without-system-harfbuzz to my otherwise fairly normal autogen.input
        on Linux.
        
        Change-Id: I149a57c24d6c11d710298125e53cb9524cb3dcaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-15  Julien Nabet  <serval2412@yahoo.fr>  [c4fb915213875fda248593743421d8c43533e375]

        [loplugin:fakebool] in desktop
        
        /home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:628:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool]
            auto const hasCurrent = set->hasByName(currentName);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:629:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool]
            auto const hasMigrated = set->hasByName(migratedName);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/desktop/source/migration/migration.cxx:647:5: error: VarDecl, use "bool" instead of '::sal_Bool' (aka 'unsigned char') [loplugin:fakebool]
            auto const hasMigrated = set->hasByName(migratedName);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        since 7f04bb393f830a2983e3e26485bbe217c66006ff
        Clean up color scheme migration
        
        Change-Id: I2a06b73cecc4812d2876689f22ba89eba12b308f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140024
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e46f9cc4b506c325cbe1060777bbc81fd1630f49]

        chart2: Set the data table fill style to default to NONE
        
        Change-Id: I57e463bf110fd3818ec586bbab1db75ff1101ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139972
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [f089f56aa0035ca0ee33bac752a7a92086680c24]

        tdf#150931: vcl_pdfexport: Add unittest
        
        Probably this test could be improved by checking the
        position of the pathes. For now, this is better than nothing
        
        Change-Id: I5063a9005a55be9d556eb147ba6a11fb2a1115a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140013
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-15  Eike Rathke  <erack@redhat.com>  [c7bb9521ba67f52e9d665fdd24d40d8b42f0387d]

        Resolves: tdf#132519 Use string reference syntax for CELL("ADDRESS";...)
        
        ... so the result can be used with INDIRECT().
        
        Change-Id: I76e4d7739e22c53a3cfa3e004a9b24dc3dfcd233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140021
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-15  Radhey Parekh  <radhey.parekh@gmail.com>  [51a780a26e4fbf339d4136ff0c7d75e01d6fad08]

        tdf#148251 Use std::swap() instead of using temporary values
        
        Change-Id: Ifdf59f4957428efdc56009947f8c87f6b6351603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139273
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-15  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c228803662d1d892405bf6431c4d5bd8dc22f7f6]

        upgrade expat to 2.4.8
        
        Change-Id: I4dea32ad24e9a6c24f69c75fea75dbd63c14c91b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139920
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [5a60014858384e8ae2a092cb699dc6fc1de61360]

        This comment is obsolete
        
        A leftover from commit f6e0527033be682dbf6b60bd9b060fdd853ffe33
          Date   Mon Mar 21 12:55:40 2011 +0100
            Remove most of dead code inlibs-core (basic)
        
        which dropped the related commented out code for "not implemented"
        stub, being there since c25ec0608a167bcf1d891043f02273761c351701
        "initial import".
        
        Change-Id: Ic09a0c63921f1c5daa277fe7bb6dfc194895b673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139978
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-15  Julien Nabet  <serval2412@yahoo.fr>  [b943d28f04014a36ce51da386f0b9411b8dbfa01]

        tdf#150877: Add support for Kamenický and Mazovia encodings
        
        ...as referenced e.g. at
        <https://docs.microsoft.com/en-us/previous-versions/visualstudio/foxpro/aa975345(v=vs.71)>
        "Code Pages Supported by Visual FoxPro".  That source lists those two encodings
        with "code page" values 895 and 620, resp. (which might be what we call "Windows
        code pages" in include/rtl/tencinfo.h) and "code page identifier" values 0x68
        and 0x69, reps. (which might be what we call "Windows charsets" in
        include/rtl/tencinfo.h.  But I deliberately left these two new
        RTL_TEXTENCODING_* values without any mappings to such Windows codepages etc.,
        as I didn't find any authoritative sources.  What I used is the information
        available at <https://en.wikipedia.org/wiki/Kamenick%C3%BD_encoding> and
        <https://en.wikipedia.org/wiki/Mazovia_encoding>.
        
        (And while at it, I also updated the instructions what to do "Whenever some
        encoding is added here" in include/rtl/textenc.h.)
        
        This commit is building on some prior, abandoned work by Julien Nabet at
        <https://gerrit.libreoffice.org/c/core/+/139819> "tdf#150877: DBF Mazovia
        encoding (0x69)".
        
        Change-Id: Iae8af4ebab8915411499ae7ef951339b335aa857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140014
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [382b82541a2e4d83197bd0b20fc5fc40bb4313e2]

        cid#1500440 Use after free
        
        this is the inline starmath editing where you can edit the formula
        directly in the view window instead of the command window. Currently
        requires experimental to be enabled.
        
        reproduce by clicking in initially empty formula and enter a character.
        In practice the deleted pos.pSelectedNode is not actually used-after-free
        in SmCursor::FindPositionInLineList because it is not found by the
        std::find of pLineList.
        
        Change-Id: I57476a8eb073914099c5026dd33dc75b20288d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140003
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [0d8813dc5c56de0df31a55fb8452668ec3980891]

        Conditional jump or move depends on uninitialised value
        
        ==1533286== Conditional jump or move depends on uninitialised value(s)
        ==1533286==    at 0x12DEC3C9: param_double_validate (gparamspecs.c:592)
        ==1533286==    by 0x12DEF924: g_param_value_validate (gparam.c:700)
        ==1533286==    by 0x12DEFA9A: object_set_property (gobject.c:1594)
        ==1533286==    by 0x12DF1F96: g_object_set_valist (gobject.c:2538)
        ==1533286==    by 0x12DF2253: g_object_set (gobject.c:2705)
        ==1533286==    by 0x241E8C44: gtk_adjustment_configure (gtkadjustment.c:833)
        ==1533286==    by 0x23B6310A: (anonymous namespace)::GtkInstanceScrolledWindow::vadjustment_configure(int, int, int, int, int, int) (gtkinst.cxx:8207)
        ==1533286==    by 0x23B63D3D: virtual thunk to (anonymous namespace)::GtkInstanceScrolledWindow::vadjustment_configure(int, int, int, int, int, int) (gtkinst.cxx:0)
        ==1533286==    by 0x36424112: SmGraphicWindow::Resize() (view.cxx:227)
        
        Change-Id: Ib81e26b1042e7a5eebd0a2b561f57f7b4eb25dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140002
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [b370b510af613303e4856ab8de7b394dc4cd3bef]

        cid#1500416 Resource leak
        
        Change-Id: I090e10604562665cf22aa98758e81dd398f4f9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139997
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [f634834434414c8b8d7ad28063bed08b683765a2]

        cid#1500581 silence Explicit null dereferenced
        
        presumably this must hold
        
        Change-Id: I2c218c6a63d5213f5abc1b671fa9f035bc69ed7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139996
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [f5abf4e6275aa4bd7821323f27cdc10912603c19]

        cid#1509209 DCN: Don't Catch NullPointer Exception
        
        Change-Id: I8e2cb9c71793a05db4f08662ee497a5f95759d67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139995
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  PoonamShokeen  <poonamshokeen7@gmail.com>  [d29958304b3ff87115ed5af16b482327ea05ce14]

        tdf#42982 improve UNO API error reporting
        
        Change-Id: Ibaf4bb0a9c9a8f613fd63ccd53a0e29d840fb21a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137904
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-15  Mahdi Tizabi  <m.m.mozaffart@gmail.com>  [cab4fd84ff9f59027d4de5a0bb96d50b7b07df13]

        tdf#42982 Improved UNO API error reporting
        
        Making `RuntimeException` instances's messages in  'SyncDbusSessionHelper.hxx' more clear.
        
        Change-Id: I40105102f8785536d29e103a44d20d11c68943bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136629
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-15  Stephan Bergmann  <sbergman@redhat.com>  [7f04bb393f830a2983e3e26485bbe217c66006ff]

        Clean up color scheme migration
        
        ...avoiding to have code in configmgr that knows about the details of the data
        stored in the configuration.  (See the comments starting at
        <https://gerrit.libreoffice.org/c/core/+/139690/9#message-44703a2529c07bf1b0202ed3a232aa661784b159>
        "Migrating product name related color schemes between different versions" for
        details.)
        
        This reverts the dubious changes of 583ea856f2aa227bb04581c5bcdc3a402f5a184f
        "Migrating product name related color schemes between different versions" in
        configmgr and offapi.  (Also, this moves the computation of sMigratedProductName
        in MigrationImpl::copyConfig, desktop/source/migration/migration.cxx, to a saner
        location than in the middle of the "check if the shared
        registrymodifications.xcu file exists" block where that
        583ea856f2aa227bb04581c5bcdc3a402f5a184f had placed it.)
        
        Change-Id: I7ab3d57db19065c7c818e697300a2abd9e7f72bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139963
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [eb30df9b8e86f756ebc66be86ae2eb345fafc850]

        tdf#106959: use table's first content node for cursor cleanup
        
        The problem was that when doing the SHELL mail merge with a document
        starting with a table, the generated marks point to the first node on
        the page, which is not a content node, but a table node. When getting
        page numbers for such mark, cursor got cleaned up, meaning that it
        looked for a content node as the cursor position. The lookup tried
        to go to a previous content node first, and that gave a content node
        on the previous page.
        
        The cursor position cleanup was introduced for i#18014 in commit
        468c7b8d3287712c6959cd531c71875f4d26bcbc
          Author Jens-Heiner Rechtien <hr@openoffice.org>
          Date   Fri Jan 04 12:19:29 2008 +0000
            INTEGRATION: CWS sw8u10bf02 (1.66.92); FILE MERGED
        
        The bug was incorrect restoration of cursor position after inserting
        a row to a table, placing cursor there, and undoing.
        I have checked that the mentioned scenario keeps the cursor inside the
        table, not jumps to the beginning of the document, as it did before
        the mentined commit.
        
        Unfortunately, I don't see how to test this properly in
        sw/qa/extras/mailmerge/mailmerge.cxx; FILE mailmerge tests there use
        a different code path; and SHELL tests obviously do not perform the
        post-processing from SwMMResultSaveDialog::SaveOutputHdl_Impl. Likely,
        an UITest would be needed.
        
        But why do we use this SHELL + post-processing here, instead of using
        the same FILE mail merge that is performed from form letter dialog,
        when SwDBManager::Merge is called from SwDBManager::ExecuteFormLetter
        with properly constructed SwMergeDescriptor? That would also speed up
        the merge, avoiding extra steps of generating full resulting document
        in memory, saving it to a temporary file, just to split it to pieces
        (TODO/LATER).
        
        Change-Id: I269de4ae3407261c4f6df51cacd5fc72643fd29a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139973
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-15  offtkp  <parisoplop@gmail.com>  [8ad101aaca50001a825f89fb330f5474965aa1fd]

        Revert removed lines and remove unused vars in GraphicFormatDetector
        
        Also removed now pointless line making stream seek back to start as a
        SeekGuard exists now
        
        Change-Id: I82e8e6852b47176fff8aae3e7d7b0e7d5c533b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139956
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  offtkp  <parisoplop@gmail.com>  [a9b3f25aa6b8fced74f39416652c27284dd7681d]

        Allow functions to short-circuit in graphicfilter2.cxx
        
        Change-Id: I5b86bd53d1fc68804970deba9d40f02861a1975b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139955
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [23c01f82682469e25fa2a8407c55100e89ab86de]

        Add documentation for data table added classes and functions
        
        Change-Id: Idc9756bf5b468d8ed0d11e6a75703d96350e1273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139960
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [d0760109b7bb965187243cdb1d3a07df83039db1]

        Only check second time when needed
        
        Change-Id: I28316a33fab208ddea2dda9f6ef3a22a8dc60457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139969
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [e4ecee9eadb496a4635232514e024ef9d71a454f]

        Fix the obvious leftover
        
        This was introduced this way since commit 468c7b8d3287712c6959cd531c71875f4d26bcbc
          Author Jens-Heiner Rechtien <hr@openoffice.org>
          Date   Fri Jan 04 12:19:29 2008 +0000
            INTEGRATION: CWS sw8u10bf02 (1.66.92); FILE MERGED
        
        Obviously, since pNode was not updated, the next check would fail again,
        and the updated value of aIdx would be discarded immediately, making the
        first check and the call to GoNext effectively a no-op.
        
        Change-Id: I878cd0887197a86d8800a467807275ed09e617c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139968
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-15  Regina Henschel  <rb.henschel@t-online.de>  [7d06665b7f5e7a7d1e9ac608c3bb827003fa3cb4]

        tdf#149551 unit test mongolianVert in shape in Writer
        
        Commit c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad has among other things
        enabled, that a shape with vert='mongolianVert' in a docx file is
        imported to a shape where the attached frame has WritingMode =
        text::WritingMode2::TB_LR and that it is then exported to a shape with
        vert='mongolianVert'.
        The unit test here tests this behavior.
        
        Change-Id: I18ef6fdcb9cbad4fdd18061aca536f95c9ea83af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139957
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-09-15  Miklos Vajna  <vmiklos@collabora.com>  [f7408cf0e472be91bdb7a4d2a4b8da3eb9a049a9]

        sw content controls, date: add PDF export
        
        Map it to /FT/Tx, and set the additional actions so it appears like a
        date picker.
        
        Also extract a SwModelTestBase::LoadPdfFromTempFile() to avoid
        copy&paste.
        
        Change-Id: I062481cc557d8222953987355c7b08cb92efda51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139964
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [47fe4927f01d7461f3a8f152895a75c98eae3e71]

        remove accidental printf
        
        Change-Id: I9deb3ec3dad5174dfb49cf0df3004746f3e47ea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139959
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [916692b861a969b93b01deb857cc0770e1e8c224]

        chart2: reenable chart data table test
        
        Change-Id: Ic40dfeb742e97b90332dd711cfb582b6f102c8df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139958
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Caolán McNamara  <caolanm@redhat.com>  [86b64eb83c48635a0ed0d92e59f0c77724989420]

        use a different file for testEmojiAutoCorrect
        
        than testRedlineAutoCorrect2
        
        Change-Id: I05ea1ef902f1cddf429d594e0031fab2ec89b653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139927
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [7bc10ea4fae2f2cbaa485f2a9820cfa3f9cfe121]

        no need to load SaveVBA symbol at runtime
        
        Change-Id: I246168902d07dbc75b68142c73f148e711320d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [18edbe1e0d96e8df029ea6ae7ec85bb26b18ab72]

        This does not need to be friend or linked externally
        
        Change-Id: I75aaa3b211d0385c7138b531a77058e05d58f028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139962
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-15  offtkp  <parisoplop@gmail.com>  [a809d89307ecfdc00fd6dcda96c53986189f35ef]

        Remove code duplication in GraphicDescriptor for PCX
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PCX files
        
        Change-Id: Ib4c9ca98c420b313fd3483272a7844d98ea227dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139274
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-15  Michael Stahl  <michael.stahl@allotropia.de>  [8fce9a0a41b1bbebd325fc9d98a79d8decd3950c]

        poppler: upgrade to release 22.09.0
        
        Fixes CVE-2022-38784
        
        Add external/poppler/disable-freetype.patch.1 to get rid of some new
        code that unconditionally requires freetype, to avoid building that on
        WNT/MACOSX.
        
        Change-Id: I854d1865286b6fb4112cdf37898cda0203c52f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139941
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-15  Miklos Vajna  <vmiklos@collabora.com>  [1b705ea0e912604a5a7e35c9dd3c861da1c362c4]

        CppunitTest_sw_ooxmlexport_template: remove not needed mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        All the tests in this suite use CPPUNIT_TEST_FIXTURE() already, so this
        is never called.
        
        Change-Id: I9f0c868b3fdcc17ed7c6240afa90d7fa3a374ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139951
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [35702fd6781542f5eefbd3710304ab9a25ac61fe]

        Add pdf file association to Windows installer
        
        Draw can handle PDF files, so offer them in "Open with" menu
        
        Change-Id: I1c8f9af8e38ee15490371074d02a2ccf35933076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139802
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-15  Justin Luth  <jluth@mail.com>  [a7589f621fcbe6305335730d2dd86b9230a18594]

        tdf#103829 ods export: output <text:tab/> when CELLTYPE_EDIT
        
        regression since LO 4.2
        
        Change-Id: Ic9b6c00af9f1cccdb58ac3eede59268d1c83c767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139761
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [c7e876f4eacab1ff4d735cc591718510452a0f09]

        CppunitTest_sc_vba_macro_test: unify the way tests are setup and teardown
        
        Some tests were using mxComponent and some other
        tests where using their own xComponent
        Hopefully this will fix the CppunitTest_sc_vba_macro_test
        failures on windows
        
        Change-Id: I75fa51edf273582057201f50847b2c1a3ed1fcc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139948
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [158344c57e661ffc5f4f44dbe1ef3760a64269ac]

        CppunitTest_sc_macros_test: simplify code a bit
        
        Change-Id: Ie0b685dbcbc3504de10372b9c0127781171f8fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139946
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-15  Michael Stahl  <michael.stahl@allotropia.de>  [521e920dda79f44a0ad637b6062f3dcb574f884b]

        zlib: add patch for CVE-2022-37434
        
        Change-Id: If09c419ba00fc9be021249e4d4da27d1650b9080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139913
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-14  Jim Raykowski  <raykowj@gmail.com>  [a33b8ec923b4e86a2ca2075f9541e79a729b2ed7]

        tdf#143547 SwNavigator: restore content tree scroll position
        
        after promote, demote, and move chapter
        
        Change-Id: Ie165fadf6154a019ad79a0fed489f63aa768c8f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139823
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-14  Rene Engelhard  <rene@debian.org>  [d480af79c6d67341e650a5b920bf66c2865309e0]

        fix system-abseil build
        
        after 	c97c60f70e9e6de594f7e0e0b85f17944c640dcf
        "external: update pdfium to 5298"
        
        Change-Id: I4a0a37ebf6cbc070d2fc5e17c89fd307a53de7fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139949
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>

2022-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0233b69dd1265d41321040c567f9d6da14fcdf71]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfa442b3d862539a7b10af5281a080acaef7e73d
          - tdf#150909 workaround for bad renderring of help page
            
            Change-Id: I6d33eb8fd9787cc36837cb4c10c93695d834ed26
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139770
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [ce4e3d6f39cb4db138ff2445b27d7af7ad01ff33]

        Resolves: tdf#144583 reuse lok hidpi icon scheme for gtk
        
        Change-Id: I91dc9f7123b878e49a1ad57e5f40b6741ab04487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139945
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Eike Rathke  <erack@redhat.com>  [939724fe6abd16015dbef6c476f7f57a2dc466d8]

        Related: tdf#149665 Unify input of a leading ' apostrophe in non-Text cell
        
        If a cell is not formatted as Text and
        ScSetStringParam::mbHandleApostrophe is true, all input (except
        one single apostrophe that otherwise would lead to an empty cell
        string) now is treated the same and the leading apostrophe is
        removed and the remainder is set as text content. The Input Line
        and editing a cell get an apostrophe prepended for the cases
        needed to generate such escaped string again.
        
        This made it necessary to adapt a unit test that exactly checked
        the old behaviour.
        
        Change-Id: I07b35d33f3704970784dc6de1322bda28903bb97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139934
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-14  Michael Stahl  <michael.stahl@allotropia.de>  [d621a8839cebf96fe3ac374026f344f8e68bf011]

        libxml2: upgrade to release 2.10.2
        
        Fixes CVE-2022-2309
        
        Change-Id: I180218be275d3b6d38f8f74aa51c57e50d2734ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139911
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [cc2a6787446f1ae6492a41c405f45a9cc8cc7d4e]

        Related: tdf#144583 move current lok hidpi icon thing into SalGraphics
        
        Change-Id: If34a2b15aebc5316783d72564ede23e02db04302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [434f6a1b5a5089ff276918f9756501c91e146759]

        try wait_until_property_is_updated in test_tdf134390
        
        ======================================================================
        FAIL: test_tdf134390 (navigator.navigator)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sc/qa/uitest/calc_tests8/navigator.py", line 143, in test_tdf134390
            self.assertEqual(get_state_as_dict(xColumn)['Value'], '2')
        AssertionError: '1' != '2'
        - 1
        + 2
        
        Change-Id: I7c781191facd10abbb25f895cb0d2bacb72d92ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [572c2ee4c4f4b8e53f2fa4398a5600f1468f3a38]

        no need to load ImportPPT symbol at runtime
        
        Change-Id: I4b50822183d9752d6a413b0308e1d661785fb10e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [412ec9ec100fb377791b9bced8bc61ce75870e10]

        no need to load ExportPPT symbol at runtime
        
        Change-Id: I01e06fe89f95141a177298e400ccd0f54c2a05db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Noel Grandin  <noelgrandin@gmail.com>  [970b87bb7b7d77ef12dbcad6ed7caa8edd92e413]

        should be releasing the DC here
        
        Change-Id: If2460da367356ef04ca344542c2c82f8283c9e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139935
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7864d1f24c31c993c800340ceb305ad15faec43e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 130638cf417ad37c42c7da8c47f552ba791fe3a7
          - Related: tdf#131136 Don’t mention obsolescent “Use printer metrics” option in Help
            
            Change-Id: Idfe7f76bef4c48fc4d4762544cbe4439760b1a17
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139953
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [3274fd1b9bfd04ca018c98084689cb9a810a350b]

        tdf#135060 Modify Vivid template
        
        Remove language (to get automaticaly user language)
        Restore same font size for Asian and complex font
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: Iea38c1e235967c7f8d47d6a4419aec62ff4e9a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139779
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [cee678f028e2f819414152770032e90fc777cc4a]

        tdf#149990 Remove unwarranted, unlocalizable term from main launcher
        
        This change was added in commit 6ed597a7dd1da40248236e7a71843c2d76d6173e
        for unclear reasons (that wasn’t asked for in the bug report), and,
        besides, it solves an inexistent problem. No one has been confused on their
        expectations after clicking this launcher on their app selector or Start menu.
        
        For anyone looking, it is an obvious thing that, if presented with a set of
        launchers like:
        
           LibreOffice
           LibreOffice Writer
           LibreOffice Calc
           ...
        
        ... the option that isn’t specific will launch a general interface. That’s just simple.
        
        “Start Center” is not the brand name of an application. Although, technically, it is
        a module, for users, it’s just a welcome screen, to which OOo has added a glorified
        name (it seems we’re experts on inventing weird terms for everyday UI paradigms…
        just see “NotebookBar”, which is just a ribbon; deal with it).
        
        It shouldn’t be present in the main launcher for the same reason we don’t add
        the word “Dialog” to the title of every dialog.
        
        Change-Id: I3703299fcb8a8244c721631c3107c9f9d3264d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139805
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [84cfd8c856e5d564e33b93cf3f8cf6ffe3df3793]

        tdf#135060 Modify Sunset template
        
        Remove gradient of hidden rectangle
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: I06c85be58593b63f55b3f61100a431f5ccf8c0c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139776
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fcbd3882ae2c529c355386e4d2a08b0d3d46ef8b]

        Fix typo signes->signs
        
        Change-Id: I3e673aba3190f3183c357681c2a379b2be8e2c84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139925
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8f90f1ab1fdb50cb0c74687b276f62aa0391b880]

        Fix typo
        
        Change-Id: I2bd3e533a6b93cded93659036ca057c04c426a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139923
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-14  Stephan Bergmann  <sbergman@redhat.com>  [f4f8f6ffd2f9c49e22a73dd15e9075617263f18e]

        -Werror=maybe-uninitialized
        
        Change-Id: I7f38dee2356e154493b708424362f535f3164edf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139942
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [3592c2e1af98b3fad00c43a4e886c29f3a4bb934]

        tdf#148620: sd: move UITest to CppUnittest
        
        hopefully this will fix the sporadic failures of
        UITest_impress_tests2 in Jenkins
        
        Change-Id: I3df2484b07a0cf7a0efdafb7235c3ff83f187200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139928
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-14  Mike Kaganski  <mike.kaganski@collabora.com>  [76342be56ee1ec52a27cf867760c2485ac4fd291]

        try_emplace is a bit more efficient
        
        It doesn't create the value_type when key exists.
        
        Change-Id: I9b45bf6b1db9a53dedf02f403f20d3eefbd0f714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139922
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [b8914154f5f24c429633d6ec1c5762e50ebe80d2]

        close "OSL_PIPE" pipe on SIGTERM
        
        so we don't accumulate ever growing number of stray OSL_PIPE_* in /tmp
        in crashtesting where timed out instances are killed off with SIGTERM
        
        and negate the need for hackery such as
        https://stackoverflow.com/questions/42515894/open-xchange-java-issues
        of:
        
        ox_kill_readerengine_instances() {
            ...
            rm -f /tmp/OSL_PIPE_*
        }
        
        Change-Id: Id5909cba6afc57498adb4ff0677d8a411330e221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139881
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [3076912419ddea4e1910a26e7c024cef4405dc5c]

        crashtesting: SvMemoryStream::PutData assert
        
        crashtesting logs contain a pile of SvMemoryStream::PutData assert
        failures with the last ~90 documents
        
        some experimentation suggests that the fallback path in
        TempFile::GetStream is getting taken to use a SvMemoryStream
        if there was no filename.
        
        presumably there is no filename because there is no inodes left
        in /tmp (see. https://gerrit.libreoffice.org/c/core/+/139881 to
        remove left over OSL_PIPE when killed) or some other similar problem.
        
        But the SvMemoryStream ctor used gives a Stream which cannot be written
        to because it's given an empty buffer to use and isn't allowed to resize
        it.
        
        this went wrong at:
        
        commit 7f8f277b94704a289fbbd1b836e4e5d66311580d
        Date:   Wed Jan 7 09:28:42 2015 +0200
        
            fdo#84938: convert STREAM_ #defines to 'enum class'
        
        with
        
        - pStream = new SvMemoryStream( eMode );
        + pStream = new SvMemoryStream( NULL, 0, eMode );
        
        which selected ctor
        a) SvMemoryStream(void* pBuf, std::size_t nSize, StreamMode eMode);
        Previously eMode was just a sal_uInt16 typedef and this gave a fairly
        arbitrary but useable nInitSize to select the other ctor of
        b) SvMemoryStream(std::size_t nInitSize=512, std::size_t nResize=64);
        
        Using eMode as nInitSize was bogus and worked by chance, that was
        introduced with:
        
        commit 160f790791d6e839919f0d0f9277cb047fe020ae
        Date:   Mon Oct 4 19:30:08 2004 +0000
        
            INTEGRATION: CWS mav09 (1.14.114); FILE MERGED
            2004/07/08 08:29:38 mav 1.14.114.3: RESYNC: (1.15-1.17); FILE MERGED
            2004/04/29 16:50:04 mav 1.14.114.2: RESYNC: (1.14-1.15); FILE MERGED
            2004/04/29 11:03:41 mba 1.14.114.1: #i27773#: no SvFileStream please
        
        Change-Id: I23ca3e8033400f6b016a802037dad3443df8af34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139926
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [de57562e3b11b64d95344a4ebaaf53607e7bc373]

        merge sdfilt library into sd
        
        it is very small, and this means we can get rid of some ugly runtime
        symbol loading
        
        Change-Id: I1d5f5da6a9e908ccd018915bf09b9ab97d67feb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139866
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [ea9de214311780119a0974e03b38fd835b5074f5]

        tdf#150882 qt: Report menu bar height when not hidden
        
        `QWidget::isVisible` only returns `true` if the widget is actually
        visible on screen.
        Therefore, even if the menu itself has been set to be visible
        in `QtMenu::ShowMenuBar`, the call to `mpQMenuBar->isVisible()`
        will still return `false` as long as the corresponding window
        the menu belongs to isn't shown on screen (yet).
        
        However, since the menu bar height may be used to calculate
        the position of other items (e.g. in the macro dialog) before the
        corresponding window gets shown, what should be relevant
        is whether the menu bar itself is meant to be hidden or
        not. Therefore, use `QWidget::isHidden` instead.
        
        Quoting the Qt doc [1] for `QWidget`'s `visible` property:
        
        > This property holds whether the widget is visible
        >
        > Calling setVisible(true) or show() sets the widget to visible status if
        > all its parent widgets up to the window are visible. If an ancestor is
        > not visible, the widget won't become visible until all its ancestors are
        > shown. [...]
        >
        > Calling setVisible(false) or hide() hides a widget explicitly. An
        > explicitly hidden widget will never become visible, even if all its
        > ancestors become visible, unless you show it.
        
        This makes the menu show properly in the macro dialog
        while still not reserving any space for the menu in the
        main window in case of using the "Tabbed" interface (where
        no "traditional" menu is present).
        
        [1] https://doc.qt.io/qt-6/qwidget.html#visible-prop
        
        Change-Id: Ifb6e22db8224013f06320d090a19d80d9e38a990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139910
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-14  offtkp  <parisoplop@gmail.com>  [5510a77f2c926770dbc312db252a035c7afbe7b3]

        Return to starting stream position after checking format
        
        After checking a format now return to starting format position in
        GraphicFormatDetector.
        
        Change-Id: Iaaeb2590f3d4928fbfba3f5386cb53e87ca16905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138936
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-14  offtkp  <parisoplop@gmail.com>  [868fb06a2ef8f915350c77f0d63c03844fc33f62]

        Remove code duplication in GraphicDescriptor for PBM/PGM/PPM
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PBM/PGM/PPM files
        
        Change-Id: Ib239bb0aafcfa691d63025d5965f199bf11c7649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138847
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-14  Luboš Luňák  <l.lunak@collabora.com>  [308174945174bfd67f0444ef0c29634a4ecd961b]

        fix off-by-one in Calc shadow handling (tdf#150931)
        
        A mistake from d48e68407931fc33044aa7f3fc9e971897fac610, the number
        is off as can be seen when compared to the bRightDiff part above.
        
        Change-Id: Id87d69c45cd3336ab8a122a2cae505a16848cdf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139902
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [4ba4b14e8101c6e025375b7d671bbb699f2dd23a]

        use a std::vector and can avoid a copy
        
        Change-Id: I7480d4b9c3e5a78b04848444c6206e60f3260969
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dcffba40f8c46820ef589aaca97ba93a9323bf71]

        Fix typo
        
        Change-Id: Ib41626ba675ced889bbc6fe4047e68a1d2ad529d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139918
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [32d83c950b6a21ba6564cde34d79e166af9ae25f]

        Fix typo
        
        Change-Id: I25cd034e29a05b04e11fec2ccd4aebeedb3d0afc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139915
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b7f59b20c4951784d15c7d62456774b3a8d2576]

        Fix typo
        
        Change-Id: I57c4b3d798f5509287f61648f52af94f0ef4f791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139917
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0415c2073841bffc86515922da32774dd2160740]

        Fix typo
        
        Change-Id: Ibe2c9498e86236461a192dea26d5014ccc90235f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139916
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [227693d3528f890f71bf934bcb5afc85874a68b6]

        Fix typo
        
        Change-Id: Ia6b1151d6a95cf797f8e13998e2ed372aaddb18f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139914
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [2f76e7baba6e86ab2eee493e432d6bf8932f07c5]

        tdf#135060 Modify Piano template
        
        Remove useless rectangle
        Force fill color to black
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: I69f746f4391063e3e2ff8bffcdf1953bc6e7aaa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139780
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [4d5f4ebce9a9204c5e179c1dab82c39043c43d91]

        always > 0 here due to preceding empty() check
        
        Change-Id: I4df9f2ce7568ce793fb8682b5be92cb36296d06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [cda1dbd978dba5bb8cd64ab28173a579133d4711]

        ofz#51205 Timeout
        
        the len here gets eventually assigned to sal_uInt16 of GlyphData::npoints
        
        Change-Id: If8217f5d414d1e627829df6a20d0c544a920e9ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139906
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [4ae293276133a12a8251585b6a37896907bbd67e]

        tdf#135060 Modify BeeHive template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: I97b8ed1ed3a9ba7f07ecbfed6dffb0938d10d4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139552
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [38160bc630567aa5d1384528516983ec17866edb]

        tdf#135060 Modify Inspiration template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: Iec0e87de4fa9f6cead971a97690bc17b62526a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139631
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [a4226f8afc6c2e6026581b41f2149024f04cdf04]

        tdf#135060 Modify Focus template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        Correct attribute error for asian font size
        
        Change-Id: I6d1c8be24a156bce72a09604ab013fc0800b9f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139767
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [f4adc07f4ab5f44b4bf60ae01e508d7c29682790]

        tdf#135060 Modify Forestbird template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        Same style for all objects
        Remove unused styles
        
        Change-Id: I7c00d20c06a0169b76dc76829798588a403bc3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139766
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [9242e6f49647a4247967ceb3a621a27d0a4e021c]

        tdf#135060 Modify Blue_Curve template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: I5cd01b882c45b46bc798c2c04a1df8b0eab01226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139768
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [531652352b3be6504c2f68ba4220edc7c236cb01]

        tdf#135060 Modify DNA template
        
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: I6bcbcab8783c128f6946edf6e54aa182d6d8645d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139774
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b0f9d52f797657310da56fe1a781f8affb0d91f]

        fix errcode.hxx location in comments
        
        after
            commit fd3888c69abd813462360f49f853fa988764596c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Sep 12 12:15:35 2022 +0200
            move ErrCode to comphelper and improve debug output string
        
        Change-Id: Icd231d52bcd2a9683e472d7a5c70f7e6fbfab379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Laurent BP  <laurent.balland-poirier@laposte.net>  [83c0ffb6e744a2338845532efc103e132fc74bbb]

        tdf#135060 Modify Progress template
        
        Rename Master Page Progress_2 to Progress
        Correct attribute error for font size
        When using template as master page, styles Accent_x are not imported
        This patch add direct formating to keep format when using template as
        master page.
        
        Change-Id: If2eaee8e96c93e98cd90ded4979924d2c9a7f63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139773
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a2176ae256643a3b8c42bca33d333aecad61d19]

        new loplugin refcountingbase
        
        Look for classes that have more than one ref-counting base class.
        A situation which is going to cause trouble.
        
        Which reveals that sdr::table::Cell has two different ref-counting bases,
        so rather make SdrText extends OWeakObject, which means
        that Cell can just have one ref-counting base,
        
        Change-Id: I8d968270f7b449cff2f29da0bd48fa17181c68c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139807
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Mike Kaganski  <mike.kaganski@collabora.com>  [58cb4fc7d17ae5b339c5ed6ae139e6ef2433c927]

        tdf#150927: properly handle nesting in tables
        
        This re-implements the relevant part of commit
        35021cd56b3b4e38035804087f215c80085564be, to follow the same
        recursion logic that is used in SwXMLExport::ExportTable.
        
        Additionally, it found a place where XML was still emitted
        when collecting autostyles (breaks were exported); fixed.
        
        Change-Id: I3b7eed06e0eca9ad20304b45db4c3e9d72478c9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139901
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-14  Miklos Vajna  <vmiklos@collabora.com>  [6b2433f3b66c1f118dabcd40924122deb2d4f204]

        sw content controls, dropdown: add PDF export
        
        Map this to vcl::PDFWriter::ListBoxWidget, which uses the /FT/Ch widget,
        i.e. a (dropdown) choice widget.
        
        Also extract a SwModelTestBase::StoreToTempFile() from the various test
        cases that export to a tempfile just by specifying the filter name.
        
        Change-Id: If9ad52ae2553d7199e28188cfdf455353e202ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139904
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-14  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [e735ad1c57cddaf17d6ffc0cf15b5e14fa63c4ad]

        Rework of ShadowPrimitive2D
        
        This is pretty much the same for ShadowPrimitive2D as the
        change for GlowPrimitive2D and SoftEdgePrimitive2D, so for
        more comments please refer to those commits:
        
         c2d1458723c66c2fd717a112f89f773226adc841
         707b0c328a282d993fa33b618083d20b6c521de6
        
        There are some needed differences due to ShadowPrimitive2D
        having existed longer and is used for non-blurred shadow
        for a long time and is used as unchanged as possible.
        Only for active glow of shadow is a buffering and local
        decompose used.
        
        Change-Id: I55e6516f59390079356ac16f24743b474e53fb05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139858
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [80d3fb7ef721b5aa2de1095249557a19e3697b3b]

        gtk4: use left aligned label for GtkToggleButton with xalign
        
        Change-Id: Ia9f4ac0132ee6eb309aefe3e43577f864d68df4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [e30f85f5b4de09a2e9fbe7f4c4af5ca7364e96ae]

        cid#1500603 Resource leak
        
        don't mix std::unique_ptr and rtl::Reference
        
        I don't know why mess around with osl_atomic_increment/osl_atomic_decrement,
        but at least sync with the pattern in use at
        ucb/source/ucp/tdoc/tdoc_storage.cxx StorageElementFactory::createStorage
        
        Change-Id: I25fc57d8e886bab3990a63543212efa67ac9772f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139811
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-14  Eike Rathke  <erack@redhat.com>  [a56e5434a4ed453b55b8f060ed18404d77a9fb10]

        Resolves: tdf#150926 Add-In result svl::SharedString needs to be interned
        
        Change-Id: If582e7e1bf818dcf9eaddd5313aa21f5768a578f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139886
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-14  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [63d1ed97e8d07baf1db2ac7cc4b5e4e203348add]

        Fix typo
        
        Remove the blank space "Search" and "...".
        
        Change-Id: Ide3c6046e7d2c3a22eabb34142dc96d5f407194b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139746
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-09-14  galjit  <qmebic1975@gmail.com>  [91672a9b353d404bcd7c81d99d1cf6a597b9cac3]

        Related tdf#132398 - Remove locolor icons
        
        Locolor icons are outdated, apparently not required anymore
        by freedesktop.org, and the installation was removed with
        I6c7eda89a145365ffb598a066b7e817f27f4ea9b
        
        Also related: tdf#132737
        
        Change-Id: Ibb99b6884f03c184bfde62585f03e7b8d34632da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139553
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-09-14  Noel Grandin  <noelgrandin@gmail.com>  [57145acf9ec47c23e307b7a5c0029d21d937cc35]

        simplify SfxItemDisruptor_Impl, just use Application::PostUserEvent
        
        Change-Id: I365fb5182bff59ace3eb0ad25222d2ee53814f72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd3888c69abd813462360f49f853fa988764596c]

        move ErrCode to comphelper and improve debug output string
        
        need to move it, because modules "below" vcl want
        to use the debug output method
        
        Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cc45f148dac2080d5cdc2d69db539d55b1ff816]

        no need to dynamically ImportCGM symbol
        
        we are preloading this library anyway, so whatever benefit this might
        have provided is long gone
        
        Change-Id: I36ca42de5f802c73b2e2da3b52a996657298211f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-14  Regina Henschel  <rb.henschel@t-online.de>  [c70ee4a6b9071468255e5d4fdb893e9c9bdf4fad]

        tdf#149551 use 'WritingMode' instead of TextPreRotateAngle
        
        Commit 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 changed the code so,
        that TextPreRotateAngle is used to track ooxml vert attribute. This
        patch changes it so, that the style attribute WritingMode is used.
        Now text direction can be written in 'writing-mode' attribute in the
        graphic properties in ODF, same for shapes as for frames.
        
        The needed conversion from WritingMode BT-LR and TB_LR90 to
        TextPreRotateAngle for rendering of text in custom shapes is now in
        one place in class SdrObjectCustomshape. The shape edit engine
        cannot yet render it itself.
        
        Some unit tests are adapted to use WritingMode property instead of
        TextPreRotateAngle.
        
        The value text::WritingMode2::TB_RL90 is introduced, corresponding to
        vert='vert' and textDirection='tbRl' or ='rl' in OOXML. It is used
        for frames too, so that the original text direction is preserved and
        vert='eaVert' can be distinguished from vert='vert'.
        
        TextPreRotateAngle is currently still used in SmartArt import for
        'upr' and 'grav' and in emulating 'upright' but no longer to
        emulate text direction.
        
        Change-Id: Idc4339bbfc3592fe90b154d75e2c404a1fa30856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138813
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-14  Miklos Vajna  <vmiklos@collabora.com>  [c97c60f70e9e6de594f7e0e0b85f17944c640dcf]

        external: update pdfium to 5298
        
        pdfium_arm64.patch.1 is now upstreamed as
        <https://pdfium-review.googlesource.com/c/pdfium/+/96010>.
        
        Change-Id: Iafb1ba480161429094db5446ab50314068ae4cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139876
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-14  Szymon Kłos  <szymon.klos@collabora.com>  [259ed2e3a135a5650fd321f408382d6b1b86bcad]

        sw: fix format brush to override old format
        
        It should not only add attributes but replace old direct
        formatting with new one (character format).
        
        Change-Id: Ieac5c3d8c00b93ee08c74a36ea2ce4938915a2b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139216
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-09-14  Luboš Luňák  <l.lunak@collabora.com>  [20de4e3ca38e177ea61e818b32d82008758b8caa]

        do not check and refcount Info access to Skia bitmaps (tdf#150817)
        
        VclCanvasBitmap keeps one around for no good reason, and I don't
        feel like digging into it. Since there's no pixel data involved
        in that case, let's assume the reader knows that the info about
        the bitmap will not change. Making this difference is actually
        what I suggested in 0e5b473a63409da2cdae4f4c60a91fcc93755ba5.
        
        Change-Id: I302a9c2c63c8b9474a541a963928933e223f4b45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139873
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-14  Tor Lillqvist  <tml@collabora.com>  [0bd72fe60dea0d14bec4b79fdfbeb8cc7a4004b1]

        Fix build of boost for iOS
        
        Change-Id: If5d812e1b37c9aa16b2b6075585f5f3023aca431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139827
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0484d071bf9b7cf87521dbd57ad93fbea009ebf2]

        Fix typo
        
        Change-Id: Ibdcc95a3275b4af1b278a5d069c19f47e3e2c8d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139874
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-14  Satya  <skompella@opentext.com>  [7e8ba44fed9a20b5d226b9d3733b79a35acbbe00]

        tdf#147646 Add unit test
        
        Change-Id: I49adaf075aa6bad0d0230bca3d9bedfca335abb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139832
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-14  Caolán McNamara  <caolanm@redhat.com>  [2ea790200f5d915f88c6f78014d978ce8d91e33f]

        tdf#142631 use document background color in the spelling widget
        
        Change-Id: Ie33a0e305192697c18e20c3b6c1a554ccddf4284
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [974c9825d339576c9438e7fc1309a059020ab50f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 420d0094490be80dc2cc019bb7bfe2b2b79fe4c1
          - Fix icon size
            
            + refactor border page
            
            Change-Id: Ic26dc2df773240c88d8f9d81e571c63cac1cd0cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139877
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-09-13  Tor Lillqvist  <tml@collabora.com>  [7653a5740e862ec51284225b8ec24977ea49b857]

        Bump minimum iOS runtime version to 14.5
        
        Change-Id: I69a0676f7a622a7b08041d87e0b0da82c0ba1a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139826
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-13  Tor Lillqvist  <tml@collabora.com>  [eb07bbb7acf45f106d4c3b6a34faeb3a10ad0233]

        Don't bother looking for so many old versions of the iOS SDK
        
        Change-Id: I94bafd68040ddce9f856955236a623ba090af22b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139825
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-13  Caolán McNamara  <caolanm@redhat.com>  [8e6df40db6e52b4ea657e5d81a32a7fdb006b00a]

        crashtesting: FastSaxSerializer::endDocument assert on export
        
        of ooo26868-1.doc to ooo26868-1.docx
        
        since:
        
        commit 17e27b4a19f22b912460f090b754d11f9a32fb7f
        Date:   Tue Sep 6 14:28:22 2022 +0200
        
            tdf#150756 - Assertion when opening report for editing
        
        but that commit looks blameless to me. Avoid the problem by
        checking for an empty Any for "TextBox" here as is common
        elsewhere
        
        Change-Id: I5f390952763044498d944a081703d0665cbb0444
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139867
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Caolán McNamara  <caolanm@redhat.com>  [66517fda4c40d0c20b52a3110ee169353ff8c227]

        gtk4: move ComboBox "items" to the start to get "active" property working
        
        Change-Id: I6a6c1d2ca7793d1ec83992171f41993b1f736f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139872
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Caolán McNamara  <caolanm@redhat.com>  [8f4ca55bcea5234aa4979e526c06a64f71b56042]

        drop gtk_check_version(4, 3, 2) checks now
        
        Change-Id: Ifaa909f8f1ffc5f6d012769e7fba3a6cab403273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Balazs Varga  <balazs.varga.extern@allotropia.de>  [583ea856f2aa227bb04581c5bcdc3a402f5a184f]

        Migrating product name related color schemes between different versions
        
        Making work to migrate product name related color schemes
        with different kind of product names. For example from a product
        named by LibreOffice to a product named by LibreOfficeDev.
        
        Change-Id: Iabef982216f126b781df122ed258816af2ae337c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139690
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-09-13  Stephan Bergmann  <sbergman@redhat.com>  [5e192fab19e1f51a704a0c690af5343d43b8e724]

        Turn this into a doxygen comment
        
        Change-Id: Icd310f663bcb83947c3ad40e3243bd8e37b4872e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139869
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-13  Miklos Vajna  <vmiklos@collabora.com>  [9bad5be0ffdcdee92d40162b598ed2ab2815e5d5]

        sw content controls, checkbox: add PDF export
        
        Map this to vcl::PDFWriter::CheckBoxWidget, which uses the /FT/Btn
        widget, i.e. a (toggle) button which is not a pushbutton or a
        radiobutton).
        
        Also avoid a border for content controls: it just cuts out some part of
        the rich text/plain text content control filled in text + causes a
        double border for checkboxes, so not useful.
        
        Change-Id: If8dd63fe71d7c2ba9bea4bf2ecc6621fefb74fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139864
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-13  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [849601bdec341eaee3cafc46fbe3cf223f06fb7d]

        Python3: upgrade to release 3.8.14
        
        Fixes CVE-2020-10735.
        
        Change-Id: I028bb1fe6154beffdd80c0190c9de40ab8a80c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Caolán McNamara  <caolanm@redhat.com>  [d2ecb536394f52f1fd7bce53d8feb202a3facfdd]

        cid#1500679 Resource leak in object
        
        to reproduce this in reality, insert a chart, activate it, select and
        copy and paste something like a bar of a bar chart. Select that copy and
        copy to clipboard again. reactivate chart, paste that element into the
        surrounding spreadsheet, select and copy something else to clear the
        chart transferrable and the model created by the chart transferrable
        leaks.
        
        there are an unrelated blizzard of a11y mutex deadlocks here btw :-(
        
        Change-Id: I650885d8c784cc1b2b023af8f5e23b3dceb2d9f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139794
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-13  Khaled Hosny  <khaled@aliftype.com>  [a387f39de8e59d7542b74962242504b798af1362]

        tdf#126242: Handle fractional values when subsetting CFF
        
        Instead of truncating the values, write the fraction using “div” operator.
        
        Change-Id: Ideff4ed3c9922a3ddd6c8aa0ec2733722ae722f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139854
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-13  Luboš Luňák  <l.lunak@collabora.com>  [f28087140a79949b7ba38cd9a724438ea92a44e8]

        do not assert on "failed" Skia call because of empty size (tdf#150821)
        
        There's no problem if the output size is actually empty.
        
        Change-Id: I680766919c65fcaad6687f09af28f6e95575c228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139830
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-13  Stephan Bergmann  <sbergman@redhat.com>  [2c8ced01216096dd03a4143fe41b4c5653deb67a]

        cid#1509290, cid#1509240: Silence "Use of 32-bit time_t (Y2K38_SAFETY)" for now
        
        We'll eventually need to do something about the 32 bit TimeValue::Seconds, but
        as it is unsigned we should be fine for another 80 years (until "06:28:15 UTC on
        Sunday, 7 February 2106", according to
        <https://en.wikipedia.org/wiki/Year_2038_problem#Solutions>).
        
        Change-Id: I74e680be0b2f0ef8cd84d6bc0faef436efc8d3cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139859
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-13  Gabor Kelemen  <kelemeng@ubuntu.com>  [fa7da09ad4afef8d6ae2dc809c5b9f059a9974b1]

        Migration: move L10N settings as well
        
        This is needed to keep UI language/locale settings
        Without this the language settings were reset to
        OS defaults in our rebranded version
        
        Change-Id: I6c09370e0053cf5171e0ac959429ac7cef5261b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139821
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2022-09-13  Khaled Hosny  <khaled@aliftype.com>  [196a8331ccb80fa7d79b74e827bf5433321b9815]

        vcl: Simplify calling FillFontSubsetInfo()
        
        Change-Id: I725ad2f3dcdbe032c0a36d9649a2ed85a499a20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139800
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-13  Khaled Hosny  <khaled@aliftype.com>  [1bf6acf0fe438194d76e7fb2f605ed26c7914f55]

        vcl: Move subsetting helper functions to sft.cxx
        
        No functional change.
        
        Change-Id: I8de9117c1b1b1fef251e2711287dbdadaccc4d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139799
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-13  Miklos Vajna  <vmiklos@collabora.com>  [01668b41c4140043f8a4fee18d01c0c4d85a5728]

        vcl: fix mergelibs build
        
        Seen the breakage at e.g.
        <https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1663031911.19370>.
        
        Change-Id: I96feb4e8922dd04cc24b5bd40b71d9cf99949a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139829
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-13  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [769cefd9c49652f28ba58cd371bc60b9e1bd5bd0]

        tdf#129163: GC cursor table at the end of the life of an portion enumeration
        
        Change-Id: I864c0ba9ec43a5b164bb9a118911e0507f2a538a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139778
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [eae7a05b94fcfdf0ae48adab2006fe0b82c95921]

        ofz#50767 docxfuzzer: Indirect-leak in rtl_allocateMemory
        
        Two fixes required here
        
        (1) the unnecessary use of aggregation in SwXDrawPage, which leads to a
        very confusing cycle that I don't fully follow. No indication why this
        is necessary in the git history, has been this way since initial commit
        
        (2) a ref-counting cycle through SvxShapeGroup and SvxDrawPage, use a
        weak reference here to break the ref-counting cycle.
        
        Change-Id: Ie7ec583960ed0864a073ad8489fb65964bd83080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-13  Eike Rathke  <erack@redhat.com>  [c0d09eb46665a0b2ab86f263cc95662f406d83d2]

        Empty string has no characters of any type
        
        Change-Id: Id7244032d52360d2b0ea57fba023dff162a29d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139831
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Eike Rathke <erack@redhat.com>

2022-09-13  Sam James  <sam@gentoo.org>  [b7d63694985bbb1cf86eb71769feadb28ce68c17]

        Fix build with Poppler 22.09.0
        
        With Poppler 22.09.0, LO fails to build with:
        ```
        /var/tmp/portage/app-office/libreoffice-7.3.5.2/work/libreoffice-7.3.5.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:682:36: error: too many arguments to function call, expected single argument 'start', have 3 arguments
            state->getLineDash(&dashArray, &arrayLen, &startOffset);
            ~~~~~~~~~~~~~~~~~~             ^~~~~~~~~~~~~~~~~~~~~~~
        /usr/include/poppler/GfxState.h:1506:32: note: 'getLineDash' declared here
            const std::vector<double> &getLineDash(double *start)
                                       ^
        1 error generated.
        ```
        
        Poppler changed the getLineDash interface:
        ```
        -    void getLineDash(double **dash, int *length, double *start)
        +    const std::vector<double> &getLineDash(double *start)
        ```
        
        Signed-off-by: Sam James <sam@gentoo.org>
        Change-Id: I29e18f20d7650a7fcac1bc8ab4aaa04aaa2ab8fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139249
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-09-13  Henry Castro  <hcastro@collabora.com>  [576ba26d09448f8bc332acdf6d17061e8ad552a3]

        sw: fix format brush to reset the font strikeout attribute
        
        The format brush always inserts attributes to a set,
        it should be intersected. For a special use case,
        ugly hack to reset the font strikeout attribute.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I94c172e61b3d6d3339b1243a9344952b5c59d872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138839
        Tested-by: Jenkins
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>

2022-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [907ba54b0d557b89e7e0e6f6eb25470e743c1918]

        tdf#150766: sc_uicalc: Add unittest
        
        Change-Id: I4acff046167f05a576eb7320edc3c85d759f6776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139790
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-13  Eike Rathke  <erack@redhat.com>  [ab0adac692b67fe7b63dee665607400c6a7e6c01]

        Fix everything using XCharacterClassification::getStringType() and don't use it
        
        See note in offapi/com/sun/star/i18n/XCharacterClassification.idl
        
        The brain dead implementation is useless but API ... its use in
        isAlphaNumericType() and similar never returned what would had
        been expected.
        
        Change-Id: I278f2468182dab94c32273ef69cf9634bc002cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139809
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-13  Caolán McNamara  <caolanm@redhat.com>  [f0f0d385b91df30d4ec42a9f727cbdbe5ce0861f]

        cid#1509232 silence Out-of-bounds access
        
        Change-Id: I53f0e0ead728c718d1241d1791135c3c60311303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139608
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-09-13  Tor Lillqvist  <tml@collabora.com>  [2a5eed7d10c378f29e4de74934aff4c78fccbda6]

        Bump current iOS SDK to 16.0
        
        Change-Id: Id44c90b5077e2ac4addb814e1089ed5d0d95df8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139824
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-13  Luboš Luňák  <l.lunak@collabora.com>  [aa0d6cb52979e29830596ec5a4e8e625500d6cb9]

        clean up opencl helper functions
        
        It seems a bit wasteful to use std::string for const strings.
        
        Change-Id: I31bb38f5cdcd0210f6f91144b3c37abae9301333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139487
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-13  Luboš Luňák  <l.lunak@collabora.com>  [85bf78b31b3719edd7a22ae768d8b2e23816cdbd]

        reduce opencl copy&paste in op_math.cxx
        
        Change-Id: Ibe2afa6ca3720a6cec8b74af5c582cb946cf5396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139486
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-13  Luboš Luňák  <l.lunak@collabora.com>  [7ed959dfe96f3a4edc0ee00f23473aac28734e1f]

        reduce opencl copy&paste in op_addin.cxx and op_logical.cxx
        
        The svDoubleVectorRef stuff in OpAnd etc. didn't make sense, those
        operators are required to do implicit intersection (which can be done
        in sc core in ScCompiler::HandleIIOpCodeInternal()).
        
        Change-Id: Ic970c8e649a651f6a804b5ed265fe2e08ff29681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139485
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-13  Luboš Luňák  <l.lunak@collabora.com>  [b58acf93626456f9d9b9ff66f9208a3f944180ac]

        reduce opencl copy&paste when generating function declaration
        
        Change-Id: Ibe3677ed56423aeb0d19b510664bc402fc53366d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139484
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-13  Miklos Vajna  <vmiklos@collabora.com>  [b9fcf43a38773f81ef1833897c4e36d8db16c0b1]

        tdf#140302 RTF import: fix unexpected repeated image
        
        The bugdoc has 2 images, but the resulting doc model had 3 images since
        commit 7e863504854ae8ab286b32510aba8b363a8e314b (tdf#81943 sw RTF
        import: fix missing wrap in background for in-table shape, 2018-07-16).
        
        The trouble was that shape replay wants to access the current shape at
        m_aStates.top().aShape, but we only set it, forgot to unset it after
        replay was done, which can result in duplicated insertions.
        
        Fix this by saving the old current shape on the stack, set the current
        shape to the wanted value and then undo it after replay.
        
        This only affects documents that have a \picprop group, since the
        unwanted insertion happened when popping that group.
        
        Change-Id: I088054de2332deb4b45f7e269672fa799dd49c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139818
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-13  Mike Kaganski  <mike.kaganski@collabora.com>  [8b5a989dcdcf4edd50c9fdb092d4180432ce4b6a]

        Fix path in comments
        
        include/tools/errcode.hxx was moved to include/vcl/errcode.hxx in
        commit f9f045e7830d184497554e0e438cc478fa990eb6
          Date Mon Apr 24 01:06:41 2017 +1000
            tools: move errcode.hxx to the vcl module
        
        Change-Id: I0d42839cad9118fba2d35e9dbf6ba456dcb5e3aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139815
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-13  Justin Luth  <jluth@mail.com>  [690a35680adad07c4ab79d82cd1531bb82fe4bc1]

        tdf#103829 ods import: parse <text:tab/>
        
        regression since LO 4.1
        
        Change-Id: I65e847a45b8b233c558bf7bc90b554ba8b4b7763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139757
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f7e874de97755be283675d7589a3f1401c54330]

        tdf#149204: chart2_xshape: Add unittest
        
        Change-Id: I601a5b3e649de0f4b02eea9289e175070b31781e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139806
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-12  Caolán McNamara  <caolanm@redhat.com>  [6f7d8e1b239438ac0f6d8e17b7441b7c65ab4fde]

        cid#1509268 Out-of-bounds access
        
        Change-Id: Ib649072ec0a28cd928d40e3fe2e0c6a50ba3e029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b9c37f62bf4e60ddde3925137727e4394be85cbb]

        Fix typo
        
        Change-Id: I7c98360de8f476ddb5e9eaa9c3c7e8bf0f5cdc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139788
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f7a837dedc1a44f2153ace7b587275dbd4718df1]

        Fix typo
        
        Change-Id: I9f22a63b912bbb2f12d9ff2d637cab0bb7c9707e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139789
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-12  Caolán McNamara  <caolanm@redhat.com>  [a6c272bff62f6ec215a11c61fd319784299a12ba]

        ofz#1509303 DCN: Don't Catch NullPointer Exception
        
        this is since:
        
        commit 8e63258a355d1b74fff89c39369e0ec72091e625
        Date:   Wed Jun 25 13:32:18 2008 +0000
        
            INTEGRATION: CWS rptwizard01 (1.12.68); FILE MERGED
            2008/05/21 10:14:32 lla 1.12.68.3: RESYNC: (1.12-1.13); FILE MERGED
            2008/04/14 09:11:53 lla 1.12.68.2: #i86092# handle nullpointer, add TODO
            2008/02/14 13:00:48 lla 1.12.68.1: #i86092# changes for new Report Wizard
        
        Change-Id: I6cb8938c311cf0432728ae06b08e16bffba39be3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139808
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f461f8eaa98544f8f1f0561f9110afbe973067c8]

        tdf#150832: chart2_xshape: Add unittest
        
        Change-Id: I6e74973b79cbefae3e311456989c78ea364a0aa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139795
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-12  Rene Engelhard  <rene@debian.org>  [455f0ac6c019da7299bc779a4fa2b0aade2fb9cb]

        bump harfbuzz dependency to >= 2.1.0
        
        as we already use hb_ot_name_get_utf8() and HB_OT_NAME_ID_FONT_FAMILY
        
        https: //harfbuzz.github.io/harfbuzz-hb-ot-name.html says
        Since: 2.1.0
        Change-Id: I19bac8be529e4919c4df5a4d2be4ea3363e4a249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139814
        Reviewed-by: Rico Tzschichholz <ricotz@ubuntu.com>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: René Engelhard <rene@debian.org>

2022-09-12  Chris Sherlock  <chris.sherlock79@gmail.com>  [247bbdf7e071344564af70743eeb5e30f4113601]

        ucb: remove unnecessary comments
        
        Change-Id: I56b8766526972bbf75425baabcecab9f45510fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139763
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3689c2227edcde9aceea574418f54ef3a9fc603d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aefcd8e0945387c36ae5a80b6815763cae2a3022
          - tdf#119421 Refactor conditional formatting Help pages
            
            * Still work to be done with other CF pages floating around
            * Strucutred the entry page for the CF dialog
            * Split conditions descriptions into sub-pages
            
            Many thanks to Roman Kuznetsov for the inputs.
            
            Change-Id: I5a9d91ab34febc127eb7dc762258428629ec5477
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139783
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [70dcd1135743eb4dae6f881201140b57c1daddd3]

        tdf#150753: always do the final steps, including unlocking draw model
        
        Otherwise, it's impossible to select objects added to the document
        created from a template without content.xml, until save-and-reload,
        because they never recalculate their bounds.
        
        Change-Id: Id97f0ff14be33196703b6f0ade713203ff10df74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-12  Miklos Vajna  <vmiklos@collabora.com>  [b96c5ede4a4fd82cfdf574ed4ef5d42b82cc021f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ce0e3da2dd19a12370bacac5aa84ed61a446f08
          - Add initial help for the sw contentcontrollistitemdlg
            
            Document the relation between display names and values.
            
            Change-Id: I559d7ae12514797d8b394c6c9f3a5608a9403079
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139801
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-09-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [700f92728478206b43177e09270bd7baee21dbe3]

        Add iWork file associations to Windows installer
        
        Change-Id: I725f3dfae295de92712ccf5c7abaaf94d9aa316d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139208
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5eff45749464739706c9f25cca6c1edff3187f1d]

        tdf#150267 Import docvar value correctly
        
        Change-Id: I388923e3f7bea35c1247f47812c158f5ab92fc0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139793
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [51f6ec80e7b02689c19dd3917043d1088c2e7843]

        tdf#150288: sc: Add UItest
        
        Change-Id: I3a71d37b4d0eed72f6f5fa291c9d460caadf373a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139595
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5343d2161e570b596b183c872dc1e8e589a0b229]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 20a70a340047c23cf5d49c10821d55432044b33a
          - Fix How to get section in page
            
            Change-Id: I2c17bdabd1e21dde126e98f254324832eea2dbd6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139784
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-12  Miklos Vajna  <vmiklos@collabora.com>  [bc4271c544dbeb3c27e4041e77d255f2c23b6b0b]

        sw: prefix members of SwFieldEditDlg, SwFieldInputDlg, ...
        
        ... SwInsertDBColAutoPilot and SwInsertSectionTabDialog
        
        See tdf#94879 for motivation.
        
        Change-Id: Id3e8c7fef6ef0d801a008636c1ff57218186effc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139786
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9caf9f8fde68f075a9ae1377bcc0cf6127c1737f]

        tdf#131073 - Don't show hidden rows/cols after setting optimal row/col height
        
        Change-Id: I1dbe92cfc577e3425787b942415182889cda6a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139327
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-09-12  Miklos Vajna  <vmiklos@collabora.com>  [82d90529dc2b3cb8359dec78852cbd910a66d275]

        sw content controls, rich text: add initial PDF export
        
        Similar to how such form widgets are emitted for form shapes in
        drawinglayer::processor2d::VclMetafileProcessor2D::processControlPrimitive2D().
        
        This is just initial support for rich and plain text, the other types
        from SwContentControlType are not yet handled.
        
        Change-Id: I765fec134f1959fe03f01ecaa128e830d86ab610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139787
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-12  Noel Grandin  <noelgrandin@gmail.com>  [7458cb8d13b2893ccbfb648198319cc3a73d7e50]

        no need to allocate this on the heap
        
        Change-Id: I33a85dfd8108c2131aa6d2a9b94d0b2c3d86bce8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f169e732d0b89a9bbbcf1afd19d20d25343e0b2e]

        Add new iWork mimetypes to .desktop files
        
        Change-Id: I91b719bdc5a7ffac125623e79f5e5729cc431b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139206
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [fe8692b413ade1ade55b2a858b53661082a335a9]

        Remove trailing blanks
        
        Change-Id: I6a44baa0069e25f7f2d79fbb59db05aa6b97e98d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139207
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0d5fcb9abdead51a55f1f611d59fd0128ace57a8]

        Fix dropdown mispositioned
        
        Only skip the relative positioning when the window is indeed a dialog.
        
        Follow up fix for a49245e04d45735aa76ad7720657c83530ba9ed8
        
        Change-Id: Idbd8327a943c512f0a617cb0ca72e9caeb2e61e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139204
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-09-11  Julien Nabet  <serval2412@yahoo.fr>  [4ca5c021c91680f1a5df47225d9cb0d41c0a8637]

        Simplify by using replaceAll instead of insert in a loop (sc)
        
        Change-Id: Ibf41f78521a390cc73e10adaf1b85cd499abc2ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139769
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-11  Noel Grandin  <noelgrandin@gmail.com>  [5bb826373f766a0ec105406a98d5529e2c360e8c]

        no need to allocate MemRingBuffer separately in OMarkableOutputStream
        
        Change-Id: I80d64f18480a2c078caeaa161f55767f66021253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-11  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [23118ce68a151232e542051d263d195b21d0d0e8]

        [COVER] add first set of ODF feature test files
        
        For providing coverage data of features in the LibreOffice code base,
        here's a set of files with orthogonal, high-level ODF features like
        bold & italic text, an image, a table in several variants etc.
        
        Use `make coverage` or `make sw.coverage` to generate coverage data
        for the entire code base, or subsets thereof.
        
        Change-Id: If27f720e8728788c421e16a3abbc1cf39521a2fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139765
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-09-11  Jean-Pierre Ledure  <jp@ledure.be>  [992b393be8c33103cd18ca65dfc51cdfdb3fd618]

        ScriptForge - (scriptforge.py) ignore PythonShell in bridge mode
        
        Bridge mode = python dialogs with LO process via socket.
        
        Behaviour before actual patch:
          the exception.PythonShell() method gives a Python error on the
             from apso_utils import console
          statement, because the APSO libraries are not in the
          pythonpath.
          (They are set in the path by the exension in macro mode)
        
        New behaviour:
          the exception.PythonShell() method does nothing,
          the import statement is not executed, hence no error.
        
        The rationale behind is:
          - in bridge mode, the macro run is started in practice
            from either a Python console or an IDE console
            that receive evntual print() statements outputs
          - there is no need for an APSO console that, anyway, should
            not receive any output of print() statements, except
            if redirection of the output towards the APSO console
            (run in the [LO] process) was possible, quod non.
          - the same script may be executed in both bridge and macro modes
            without change
        
        Change-Id: Id7c8eb19cd074bf39f470d84b5eb48880e908f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139772
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-09-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c747486335c089baf440b8f040d3ffdc14aa5049]

        basegfx: replace typedef with a class B2DSize based on Size2D
        
        Change-Id: Id8b3c2bcf0bf4be5aba2812b0edda479bc20c6a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139683
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-11  Eike Rathke  <erack@redhat.com>  [5f5f2f8107b6176654bfb9a30c21b7d5e0c62c6f]

        ScValueIterator ScDocument& parameter is now superfluous
        
        Since commit 3be1cdce9d92cbadca1b276b3193c727032ea717
        ScInterpreterContext is passed that has it. Just a minor change
        for a const ScDocument&.
        
        Change-Id: I388ff55393056c52f85d7543fcfb6c549fc2a346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139759
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-11  Khaled Hosny  <khaled@aliftype.com>  [38db900c1f7b471dfdf575bbda522a792db51372]

        vcl: Move CreateFontSubset() to PhysicalFontFace
        
        Having it in SalGraphics is not necessary as the code now depends on
        PhysicalFontFace for accessing raw font data, and this consolidates all
        the near identical copies of this code into one.
        
        Change-Id: I8a411f102fd2188a456bdeb8a0d794078d74e47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139762
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-11  Khaled Hosny  <khaled@aliftype.com>  [4286e745bccc7393ecd8b06346306d13d23316b5]

        vcl: Add a PhysicalFontFace-backed TrueTypeFont
        
        This is mainly to be able to get the font table data from the
        PhysicalFontFace so that an actual font file or full font data are not
        required (since they are not always available, e.g. with CoreText fonts).
        
        This is slightly based on QtTrueTypeFont that this code replaces.
        
        Change-Id: I6926706dfc6765076100ac0314a30f9ff970ddb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139760
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-11  Khaled Hosny  <khaled@aliftype.com>  [aa0a71b5cec118d4a4a922f6833ff20d7e4ba8ba]

        vcl: Add PhysicalFontFace::GetRawFontData()
        
        Change-Id: Iddeccfc8ffd5e63f7df09219ac4507502011fb28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139626
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-11  Jim Raykowski  <raykowj@gmail.com>  [218624bdf176010e18afc06b453b4535d7a00a04]

        tdf#126535 show search key found times in find and replace dialog
        
        search label
        
        Change-Id: I2850652896027ec04668d1fe3e0134c1ff53562e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139745
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-11  Julien Nabet  <serval2412@yahoo.fr>  [bff60eadeac348024849d710690435ee9580831b]

        Simplify by using replaceAll instead of replaceAt (sc)
        
        It also shows more clearly the intention. Since replaceAt with "0" as second arg isn't a replace per se
        since it doesn't remove the first arg string.
        
        + get rid of lcl_DoubleEscapeChar which was used only once
        
        Change-Id: I08c38c6cfd016a6265725134cb87e518b51ab361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139755
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-11  Khaled Hosny  <khaled@aliftype.com>  [ff869c52899a4e54b5bd4bbaee81adc79705200f]

        vcl: Fix setting symbol flag on TrueTypeFont
        
        This is a fallout from:
        
        commit 8597aed8a8576ad0f6efe139ff03556217b01b31
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Thu Sep 8 02:05:14 2022 +0200
        
            vcl: Get FontCharMap from HarfBuzz
        
        The intent was to set m_bIsSymbolFont from m_xCharMap if provided, but
        the else branch went missing.
        
        Change-Id: I7c7a5a65b8ae78ec6e6d53397dc0e4fbda974e5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139758
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [b31992ea518cec906a65ef971a637d0529302a2c]

        tdf#119039: workaround an OleLoad bug releasing passed storage unexpectedly
        
        See https://developercommunity.visualstudio.com/t/10144795
        
        Change-Id: I75ee88c1dd50e0772c358967ac09b7788156d9f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139756
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [b32c44f83ded245b0fc350aef350e1c55545e354]

        WARN->INFO in XMLTextFrameContext_Impl
        
        Unknown attributes are not really a problem.
        
        Change-Id: Ie21d42c6489eae11c730eec272fc430c2d17f727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Gabor Kelemen  <kelemeng@ubuntu.com>  [da22ffb0d54e259deabe11648c424c1a46e39e7c]

        Migration: move Persona settings to new user profile
        
        This is useful when changing product name and migrating the user profile.
        Previously the persona setting was reset to default in our rebranded version.
        
        Change-Id: Ic695b93be1ee8d19fb28131b0dc0b182df0bae83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139598
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-09-10  Gabor Kelemen  <kelemeng@ubuntu.com>  [e39d90f5919da88ff75dddb92cc87313923ce9a4]

        Migration: move ToD settings to new user profile
        
        This is useful when changing product name and migrating
        the user profile.
        Without this the ToD appeared in our rebranded version even if it
        was turned off previously.
        
        Change-Id: I10a9715e8208cf9d88a5ef2052fb4cf5168dae74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139597
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-09-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [53454c5ca1c15a0f0fb2407607d17b7d302f4d62]

        Fix typo
        
        Change-Id: Id6008749a90116f6826e624645dbab23288fe810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139606
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [a868a9cd5f45eb0ea6703db3b68c48b7fa79b808]

        crashtesting tdf135070-01.odt
        
        asserts with
            ./instdir/program/soffice --headless --convert-to pdf ~/tdf135070-1.odt
        
        ever since
            commit 0f0cc045e06c8f3cd3f9780054f2259c6a0995f7
            use more SwPosition::Assign
        
        Change-Id: I653a3136e46fde12b3e31bacec7f44695b0e1329
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [9908e48932e0cdac9785c05ff1d4c0e482ea78ca]

        remove warnings in SwTransparencyGrf Get/Put Value
        
        These have been here since
            commit 930f64d3f903787368a8c8cc86857a2932da815e
            Author: Oliver Specht <os@openoffice.org>
            Date:   Thu Dec 14 10:48:47 2000 +0000
            #82036# graphic attributes added to the API
        
        so it is unlikely that SwTransparencyGrf will ever be
        changed to a sal_uInt16
        
        Change-Id: I634901f07f40dee556f215daa733284c32685510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Caolán McNamara  <caolanm@redhat.com>  [a539db002bc9ee6692d14cde2aaa166bd213eb51]

        upgrade to openssl-3.0.5
        
        patch out using IPC::Cmd instead of requiring adding it
        to build-time dependencies
        
        for mysterious:
        
        The system cannot find the path specified.
        NMAKE : fatal error U1077: '""C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x86\cl.exe' : return code '0x1'
        Stop.
        NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x86\nmake.exe"' : return code '0x2'
        Stop.
        
        include fix from https://github.com/openssl/openssl/issues/18823
        
        and for
        
        move /Y crypto/aes/aes-586.asm.i crypto/aes/aes-586.asm
        The system cannot find the path specified.
        NMAKE : fatal error U1077: 'move' : return code '0x1'
        
        add own patch to use mv and rm for move and del
        
        Change-Id: I071750e20efd0931ea1c5c3b49e7a5173c7283f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139641
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-10  Caolán McNamara  <caolanm@redhat.com>  [779e6fbef37119e9ad0cd2f63915b23c5645dab3]

        move code depending on bBalance inside a block conditional on that
        
        entirely possible the divide by zero happens in a case where that
        result isn't needed anyway
        
        Change-Id: I3d4732903663f6cd76f525b46550b778790b05a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-10  Eike Rathke  <erack@redhat.com>  [1802fb78246977bb07c2ebde8fa5ebba93a5a456]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4e464b0c58a1b2dfc6a97b87c9b75e3cac572b0
          - Remove blank and period nonsense in defined names
            
            Change-Id: I759474b9cfae8a02519108cad98863c5caac7507
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139752
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-09-10  Eike Rathke  <erack@redhat.com>  [569d451bbe160829947ace201d07ad69442204b0]

        Resolves: tdf#150766 Listen to entire shared formula group instead of a slice
        
        Change-Id: I677602bd3401dbd401e35f7db64cd34d164d9d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139744
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [16987d2aae9e0ed052de8a8f7155070c4b05cf4a]

        unique_ptr->optional for Graphic
        
        Graphic is just a wrapper around shared_ptr, so no need to
        allocate this separately
        
        Change-Id: Ie657dea1c021e66a6876e814090a44cb6f995b91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [9e67902277421aa3fae3bf10eb7bb8b70259c78e]

        unique_ptr->optional for Graphic
        
        Graphic is just a wrapper around shared_ptr, so no need to
        allocate this separately
        
        Change-Id: If4d6367d16d6ebc6c70c9cb39f8635ddaebccd72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139737
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [94c5c9281ac09186242143191f3e383bef2a89a7]

        unique_ptr->optional for Graphic
        
        Graphic is just a wrapper around shared_ptr, so no need to
        allocate this separately
        
        Change-Id: I30de73ac8a7e29adbc5ffe681f3ce88cd700b68c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Stephan Bergmann  <sbergman@redhat.com>  [37af3c83bda0d56cf6d0d7a58665cbcaa60a3cc1]

        Use stable_sort to sort hidden rows in sortAndRemoveDuplicates
        
        With a randomizing debug-mode libc++, UITest_autofilter2 failed for me with
        
        > FAIL: test_tdf117276_autofilter (tdf117276.tdf117276)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/autofilter2/tdf117276.py", line 78, in test_tdf117276_autofilter
        >     self.assertFalse(is_row_hidden(calc_doc, 21))
        > AssertionError: True is not false
        
        when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is e.g. 0.
        
        Change-Id: I3e77731e2f3a2283fcf70293fab39369f316d301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139742
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ac7c09450bfc50269c0244fdb6eb55f2829d7dbf]

        basegfx: add Size2D template class - subclass Tuple2D
        
        Also improve Tuple2D - add operators
        
        Change-Id: I9b23fb2f716ab99a4d4349a48f4ccc2334a9f865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139682
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c2d3f4be406b3bef8e89b17b781cb7e827a0fe3d]

        basegfx: simplify Tuple2D, B2DPoint, B2DVector, B2DTuple
        
        Change-Id: I97e41fc62288ec4ee5805747fd3a3a6e019cfb57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139681
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [0252b7bdec3693096bb52c67d335c0e9e662e185]

        VclPixelProcessor2D doesnt need a pimpl
        
        it is module private
        
        Change-Id: Ic9e648202f23e4a48e5485237c9956501e9c96da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [62cea174f4c73ed39e5ac29e2a44fd27b92054bd]

        convert EmbeddedMacros to scoped enum
        
        Change-Id: I7e24b5ad53853ff7989f262a3b914b2082ac5ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Noel Grandin  <noelgrandin@gmail.com>  [9d30a59ee1f4b280d70d43e6ee3fc7472e8efa2a]

        unique_ptr->optional for AllSettings
        
        AllSettings is just a cow_wrapper, so no need to allocate this separately
        
        Change-Id: I8f7705d55ab70da209d1383f3812249e0750df5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-10  Michael Weghorn  <m.weghorn@posteo.de>  [c9974818bdf9ab8ccf2f8db140ff6b2b3eb1c461]

        win: Explicitly cast glyph ID to 16 bit
        
        After
        
            commit ba02639c9c17d75e73fc2eff83e64c116fcdaeb2
            Date:   Wed Sep 7 11:00:26 2022 +0200
        
                vcl: Make glyph IDs 32bit
        
        , my clang-cl Windows build would otherwise fail as follows:
        
            [build CXX] vcl/win/gdi/DWriteTextRenderer.cxx
            [build CUS] postprocess/images
            C:/tools/cygwin/home/michael/development/git/libreoffice/vcl/win/gdi/DWriteTextRenderer.cxx(264,39): error: non-constant-expression cannot be narrowed from type 'sal_GlyphId' (aka 'unsigned int') to 'UINT16'
                  (aka 'unsigned short') in initializer list [-Wc++11-narrowing]
                        UINT16 glyphIndices[] = { pGlyph->glyphId() };
                                                  ^~~~~~~~~~~~~~~~~
            C:/tools/cygwin/home/michael/development/git/libreoffice/vcl/win/gdi/DWriteTextRenderer.cxx(264,39): note: insert an explicit cast to silence this issue
                        UINT16 glyphIndices[] = { pGlyph->glyphId() };
                                                  ^~~~~~~~~~~~~~~~~
                                                  static_cast<UINT16>( )
            1 error generated.
        
        Change-Id: Ifa4fcdd98331378b5d9340f961e0bc4d7e842fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139721
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-10  Khaled Hosny  <khaled@aliftype.com>  [f4bd06f9928fc01762f9e52c5bebcb3137b39665]

        vcl: Use vector instead of array for FontCharMap ranges
        
        Change-Id: I8846c89d51cc33022f90c3a9c03bc1560497e651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139701
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-10  Michael Weghorn  <m.weghorn@posteo.de>  [235b30bdfa76b5c0514c7dfe2a0d13ab8ecf5be2]

        wina11y: Report actual app/toolkit name/version
        
        The previous way of reporting "Hannover" as app name, "3.0" as
        version and no toolkit name and version looks rather arbitrary.
        
        Can be queried e.g. from NVDA's Python console as follows after
        pressing Keypad_Insert+Ctrl+Z with any LibreOffice UI element focused:
        
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appName
            'Hannover'
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appVersion
            '3.0'
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitName
            ' '
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitVersion
            ' '
        
        Report the actual app name and version. For the toolkit use "VCL"
        as name and the same version that LibreOffice has:
        
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appName
            'LibreOfficeDev'
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).appVersion
            '7.5'
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitName
            'VCL'
            >>> focus.IAccessibleObject.QueryInterface(IA2.IAccessibleApplication).toolkitVersion
            '7.5'
        
        Change-Id: I3c6bdb79e6b945c0f9707bfa7bada0fb456d6e05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139743
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-10  Miklos Vajna  <vmiklos@collabora.com>  [37d778b601966434ff6042373c1a82d4687fd034]

        vcl: fix crash in SalInstanceWidget::set_busy_cursor()
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 128 for address: 0x0
        
        program/libmergedlo.so
                vcl::Window::LeaveWait()
                        vcl/source/window/mouse.cxx:640
        program/libsclo.so
                ScSpellingEngine::ShowTableWrapDialog()
                        sc/source/ui/view/spelleng.cxx:315
        program/libsclo.so
                ScConversionEngineBase::FindNextConversionCell()
                        sc/source/ui/view/spelleng.cxx:168
        program/libsclo.so
                ScSpellDialogChildWindow::GetNextWrongSentence(bool)
                        /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173
        
        Change-Id: I298789211d6ee038bd5a9a7bff7cf9ae4f132a91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139731
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-09  Noel Grandin  <noelgrandin@gmail.com>  [270df129a428a7346f87ebd760cfd51780750592]

        convert CursorMoveDirection to scoped enum
        
        Change-Id: I9ad59207fab6d3988b8c8106aec6c4fac21dc9d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [08051644adeed4d0ee137f3111f225b378e436aa]

        Fix typo
        
        Change-Id: I764af470a6bff3ec82182d32fd971e94fa2f725a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139732
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [e00a86699b89913a80b15eeea33dd0fac64299d0]

        GetCurNumFmtInfo is always called with the same context as given in ctor
        
        Change-Id: Ic3aefaa5ddd26b5cb44bfc299f7ae7188f205d17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [3be1cdce9d92cbadca1b276b3193c727032ea717]

        always pass ScInterpreterContext to ScValueIterator
        
        its available at every call site
        
        Change-Id: I764962d1d2330c414e02ed215b4a0c5be2979145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139637
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [2f4c49fa96db7d6134fb28b20ea9ad4c51183f28]

        crashtesting: threaded assert on loading forum-de3-3100.ods
        
        use SetInterpreterContext like I see in similar places to avoid the need
        to call ScDocument::GetFormatTable
        
         #9  0x00007fd35b1af283 in ScDocument::GetFormatTable() const (this=this@entry=0x5573153bf1d0) at sc/source/core/data/documen2.cxx:463
                 __PRETTY_FUNCTION__ = "SvNumberFormatter* ScDocument::GetFormatTable() const"
         #10 0x00007fd35b196f57 in ScAttrArray_IterGetNumberFormat(sal_uInt32&, ScAttrArray const*&, SCROW&, ScAttrArray const*, SCROW, ScDocument const&, ScInterpreterContext const*) (nFormat=@0x7fd354458b38: 0, rpArr=@0x7fd354458b30: 0x0, nAttrEndRow=@0x7fd354458b54: 0, pNewArr=0x557315063910, nRow=nRow@entry=30, rDoc=..., pContext=0x0) at sc/source/core/data/dociter.cxx:80
                 nRowStart = 30
                 nRowEnd = 30
                 pPattern = 0x557316c093f0
         #11 0x00007fd35b19e5b7 in ScValueIterator::GetThis(double&, FormulaError&) (this=this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0, rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:196
                 bNextColumn = <optimized out>
                 pCol = 0x557316aca050
                 nCurRow = 30
                nLastRow = 32723
         #12 0x00007fd35b19e8c4 in ScValueIterator::GetNext(double&, FormulaError&) (this=<optimized out>, this@entry=0x7fd354458b20, rValue=@0x7fd354458b00: 0, rErr=@0x7fd354458af8: FormulaError::NONE) at sc/source/core/data/dociter.cxx:297
         #13 0x00007fd35b6a5307 in ScInterpreter::GetNumberSequenceArray(unsigned char, std::__debug::vector<double, std::allocator<double> >&, bool) (this=this@entry=0x5573169d9900, nParamCount=nParamCount@entry=1 '\001', rArray=std::__debug::vector of length 2, capacity 200 = {...}, bConvertTextInArray=bConvertTextInArray@entry=false) at sc/source/core/tool/interpr3.cxx:3986
                 nCellCount = <optimized out>
                 nErr = FormulaError::NONE
                 fCellVal = 0
                 aValIter = {mrDoc = @0x5573153bf1d0, pContext = 0x0, pAttrArray = 0x0, nNumFormat = 0, nNumFmtIndex = 0, maStartPos = {nRow = 0, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, maEndPos = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, mnCol = 0, mnTab = 4, nAttrEndRow = 0, mnSubTotalFlags = SubtotalFlags::NONE, nNumFmtType = SvNumFormatType::UNDEFINED, bNumValid = false, bCalcAsShown = true, bTextAsZero = false, mpCells = 0x557316aca280, maCurPos = {first = {<mdds::mtv::soa::detail::iterator_updater<mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreTrait>::const_iterator_trait>> = {m_cur_node = {type = 10, position = 30, size = 1, data = 0x557316d734d0, __private_data = {parent = 0x557316aca280, block_index = 1}}, m_pos = {position_iterator = 30, size_iterator = 1, element_block_iterator = 0x557316d734d0}, m_end = {position_iterator = 7378697629483820646, size_iterator = 7378697629483820646, element_block_iterator = 0x6666666666666666}}, <No data fields>}, second = 0}}
                 eStackType = <optimized out>
                 aAdr = {nRow = 0, nCol = 0, nTab = 0, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}
                 aRange = {aStart = {nRow = 0, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}, aEnd = {nRow = 199, nCol = 0, nTab = 4, static detailsOOOa1 = {eConv = formula::FormulaGrammar::CONV_OOO, nRow = 0, nCol = 0}}}
                 bIgnoreErrVal = false
                 nParam = 0
                 nRefInList = 0
         #14 0x00007fd35b6aa9ed in ScInterpreter::CalculateSmallLarge(bool) (this=this@entry=0x5573169d9900, bSmall=bSmall@entry=true) at sc/source/core/tool/interpr3.cxx:3657
                 nCol = 1
                 nRow = 1
                 aArray = std::__debug::vector of length 1, capacity 1 = {1}
                 nRankArraySize = 1
                 __PRETTY_FUNCTION__ = "void ScInterpreter::CalculateSmallLarge(bool)"
                 aRankArray = std::__debug::vector of length 1, capacity 1 = {1}
                 aSortArray = std::__debug::vector of length 2, capacity 200 = {1, 21}
                 nSize = <optimized out>
         #15 0x00007fd35b6abac8 in ScInterpreter::ScSmall() (this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr3.cxx:3717
         #16 0x00007fd35b6cd929 in ScInterpreter::Interpret() (this=this@entry=0x5573169d9900) at sc/source/core/tool/interpr4.cxx:4373
                 bGotResult = <optimized out>
                 nRetTypeExpr = SvNumFormatType::NUMBER
                 nRetIndexExpr = 0
                 nErrorFunction = 0
                 nErrorFunctionCount = 0
                 aErrorFunctionStack = std::__debug::vector of length 0, capacity 0
                 nStackBase = 0
                 aTokenMatrixMapIter = Python Exception <class 'AttributeError'> 'NoneType' object has no attribute 'pointer':
         {_M_node = 0x5573169d99c8}
                 eOp = ocSmall
                 __PRETTY_FUNCTION__ = "formula::StackVar ScInterpreter::Interpret()"
                 bForcedResultType = <optimized out>
                 p = <optimized out>
                 eType = <optimized out>
         #17 0x00007fd35b3c6ed1 in ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (this=0x55731309d8f0, rContext=..., eTailParam=eTailParam@entry=ScFormulaCell::SCITP_NORMAL) at sc/source/core/data/formulacell.cxx:1945
                 pScopedInterpreter = std::unique_ptr<class ScInterpreter> = {get() = 0x0}
                 pInterpreter = 0x5573169d9900
                 nOldErrCode = FormulaError::NONE
                 bContentChanged = <optimized out>
                 aNewResult = {static MULTILINE_UNKNOWN = 0 '\000', static MULTILINE_FALSE = 1 '\001', static MULTILINE_TRUE = 2 '\002', {mfValue = 6.9438766800236802e-310, mpToken = 0x7fd3544591e8}, mbToken = false, mbEmpty = false, mbEmptyDisplayedAsString = false, mbValueCached = true, meMultiline = 3 '\003', mnError = 28442}
                 bOldRunning = false
                 bForceNumberFormat = <optimized out>
                 aRecursionCounter = {rRec = @0x557316da2b40, bStackedInIteration = false, cell = 0x55731309d8f0}
         #18 0x00007fd35b0c84cb in ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) (this=<optimized out>, rContext=..., nRow=nRow@entry=0, nLen=nLen@entry=30, nOffset=nOffset@entry=0, nThisThread=nThisThread@entry=0, nThreadsTotal=48) at sc/source/core/data/column2.cxx:3218
        
        Change-Id: Ifeddbfda8afe47c3754ed1fcab836dfd2c8f38ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139636
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [69b0c17f1e5d2fd8c7ca0548fb5c5ed8def26ce2]

        update credits
        
        Change-Id: I2b1e2e53b0688369e9ebc480ab296ace4cdb804b

2022-09-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6e34b6072fb602b3094f19e1e80c1e05d4d91eb1]

        Update git submodules
        
        * Update translations from branch 'master'
          to d2af5ccdc269827d9738b6ed08c8166bfd5c91cf
          - update translations for 7.4.1 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: Iead6e205e7824b0e4c5f7001661275410fe33360
            
2022-09-09  Eike Rathke  <erack@redhat.com>  [d2c500fb40be23aa7bd1d2b7cc02e47ea109d25c]

        Related: tdf#150312 Assert a defined name's non-empty table:base-cell-address
        
        Change-Id: Iaf377ae51c20e30e0362f5dc6f66172c544483d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139728
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-09  Eike Rathke  <erack@redhat.com>  [5a1bd80e0d685bbd76de2ebfaa1c6b0380d528f4]

        Related: tdf#150312 "Repair" broken table:base-cell-address of defined names
        
        ... to not lose them entirely, though this may shift relative
        addressing, which may be equally bad because there is no
        indication and can go unnoticed. Most defined ranges use absolute
        addressing though and formula expressions are rarely affected.
        
        Change-Id: If57ff9274e673a4eb43c656698f6ed43e8415458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139706
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-09  Eike Rathke  <erack@redhat.com>  [6afb3232d32f1ebad0cefb94c145922e217526bd]

        tdf#150312 unit test
        
        Change-Id: I140d94b4022dafe4f54b45d3d335c881d967ea56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139725
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-09  Eike Rathke  <erack@redhat.com>  [9a6c350d8dff4b5228ec7451006115e387f819f2]

        Resolves: tdf#150312 Move base-cell-address to a valid sheet upon deletion
        
        ... and adjust references accordingly. For
        ScTokenArray::AdjustReferenceOnDeletedTab() that now also moves
        the base of the first deleted sheet not only after, which was a
        one-off before.
        
        Change-Id: I4c19e8b8a7318ba03b6a7d0b2dfaae5d05a51a29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139720
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [d26faae8359ccf2e3475ef9e319c97485b76d08d]

        sw: avoid divide by zero in SwDoc::AdjustCellWidth
        
        See https://crashreport.libreoffice.org/stats/signature/SwDoc::AdjustCellWidth(SwCursor%20const%20&,bool,bool)
        
        Change-Id: I98b90dcbed6b6f3ea0a7d1668a5c248f39e7a2a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139723
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [521d438c41b2ac59bffc94763d1a2cb568ff9a60]

        tdf#150732 ReportBuilder: Moving fields from one section to another crashes
        
        regression from
                commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
                Author: Noel Grandin <noel.grandin@collabora.co.uk>
                Date:   Thu May 27 10:27:46 2021 +0200
                ref-count SdrObject
        
        Fixes 2 issues
        (1) where I removed some code that we need
        (2) where the OUnoObject constructor was deleting the object is was
        constructing
        
        Note that this only fixes the crash that Julien saw, not the underlying
        problem that this tdf bug reports. That bug appears to predate my
        commit.
        
        Change-Id: I3878ef460dedc3c2a6c86b88fce9d155e79bc0b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139714
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-09  Tibor Nagy  <nagy.tibor2@nisz.hu>  [fabfa4bd23e89a2d5b6e232cd2eab61996534659]

        tdf#150719 PPTX import: fix hyperlink format (lost underline)
        
        Hypertext lost its formatting partially: e.g. underline
        character setting lost, except on the last word.
        
        Follow-up to commit commit a761a51d9db3a2771ca9fd6ab233c513aa5d8ecf
        "tdf#149311 PPTX export: fix internal hyperlink on texts".
        
        Clean-up of commit 855a56fea4561135a63cb729d7a625a950b210e7
        "tdf#148965 PPTX import: fix internal hyperlinks on shapes" and
        commit cec1f712c87e557e1b7313e0dbef4a635f69d953
        "tdf#144918 PPTX import: fix internal hyperlink on shapes" and
        commit 7eb0e52527e729a21973e70d5be8e0a6779ec748
        "tdf#142648 PPTX: import long slide names to avoid broken link export".
        
        Change-Id: I1de8b06361c7b9529a70a039e194db88460cc27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138669
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [3a195e99b3e98b1784cad62531660e062e3c2df1]

        cache these tarballs for oss-fuzz build too
        
        Change-Id: I97b4c6996886037f1b042d77ba9dc61c2ebc765a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139712
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [9279b0bb5397d0520b727ab0d271f328807c8749]

        writerfilter: avoid divide by zero
        
        in DomainMapperTableManager::endOfRowAction()
        
        See https://crashreport.libreoffice.org/stats/signature/writerfilter::dmapper::DomainMapperTableManager::endOfRowAction()
        
        Probably since 116cadb5d2582532c69677a2f8499e8e9b7b9b80
        "tdf#59274 DOCX import: fix tables with incomplete grid"
        
        Change-Id: I12f2842107885fbbc62be2186511102f642e3efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139717
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [b711a008dfce399c03cd34272c37d7cc60f93363]

        ofz: Undefined-shift
        
        Change-Id: Ida81135280ff61c3a8e96e8f5ed977959e169f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139716
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [3642db420a66133ebe4aabb346ce0adca17e26e6]

        ofz#51149 avoid Timeout
        
        Change-Id: I7709e69154d231e597d364210bc876afca3df4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139719
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Caolán McNamara  <caolanm@redhat.com>  [7a7cd044887ce6801791e1cf7eb18ac1a0e68e07]

        rearrange to have a single ConvertTable call
        
        Change-Id: Ic48ebac04d6e95df8748f38b1f23a8295fba77b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139718
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-09  Stephan Bergmann  <sbergman@redhat.com>  [851d0e552ef80c394aa0a12812f49fd5efc690b0]

        Allow to pass LIBCPP_DEBUG into configure
        
        ...(e.g., by setting it in autogen.input).  I need that with some of my Clang
        builds until the issue discussed in the mail thread
        <https://discourse.llvm.org/t/pack-expansion-bug/64910> "Pack expansion bug?" is
        sorted out.
        
        (Make sure to even allow passing in an empty
        
        > LIBCPP_DEBUG=
        
        even though it turned out I needed a non-empty
        
        > LIBCPP_DEBUG=-D_LIBCPP_ENABLE_ASSERTIONS=0
        
        in my case.)
        
        Change-Id: I353ab535568ebd5add93485c219fe2a06fde0565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139711
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-09  Miklos Vajna  <vmiklos@collabora.com>  [e4d48ffe95b18d03fba98fc1ca9224215cf9b9c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18621b8577dda9415f471809c53db623059f8b51
          - Add initial help for the sw contentcontroldlg
            
            This dialog always has a single checkbox, but the 3 other frames are
            only visible for certain content control types, document what they are.
            
            Change-Id: Id54ac041b0e038c1205036eac40562616777c22f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139710
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-09-09  László Németh  <nemeth@numbertext.org>  [d011ae00cbfa714b9b2b4e8ca64fa18896ecde4d]

        tdf#150876 sw: track new rows inserted after a tracked row insertion
        
        New row insertions after an already tracked row insertion
        weren't tracked.
        
        Regression from commit b251228d2e5e2832e0a617213173e8841f5b7428
        "tdf#150666 sw: allow to delete tracked table row insertions"
        
        Follow-up to commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9
        "tdf#143358 sw: track insertion of empty table rows".
        
        Change-Id: Ic365e70aa7808237a1bd69d0101a098ae70e8813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139594
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-09  Miklos Vajna  <vmiklos@collabora.com>  [3c610336a58f644525d5e4d2566c35eee6f7a618]

        tdf#148214 RTF import: avoid fake paragraph for \page when possible
        
        The bugdoc has 2 pages, an explicit page break between them and the
        first page has enough content that an additional fake paragraph at the
        end would lead to a 3rd, unwanted page.
        
        The fake paragraph was introduced in commit
        7b58fc3dafc789aa55fff5ffef6ab83c3aa8b6e0 (fdo#48104 fix RTF import of
        \page in inner groups, 2012-04-02), because dmapper ignores more than 1
        page breaks in a paragraph.
        
        Fix the problem by only inserting the fake paragraph in case the "page
        break before" paragraph property would have no effect (very first
        paragraph in the document) or we already sent characters (para props are
        lazy-sent on the first character). This keeps existing cases working,
        but avoids the unwanted fake paragraph in the bugdoc.
        
        I suspect the root cause is that dmapper doesn't handle multiple page
        breaks in a paragraph -- once that's fixed, this parBreak() call can be
        completely removed.
        
        Adjusted tests:
        
        - testImportHeaderFooter: this asserted the presence of fake paragraphs,
          which are now gone in the easy case, so this change is an improvement
        
        - testTdf133437: no visual difference before/after, probably the test
          intent was just "make sure this page has several shapes", the exact
          number isn't that interesting
        
        Change-Id: Idd2b8a70b4122eb08d9d305018d384dc0bbb276a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139704
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-09  Julien Nabet  <serval2412@yahoo.fr>  [5f86f491701dc9f6f52129cf87644167e95ab40a]

        Simplify by using replaceAll in a loop (winaccessibility/AccTextBase)
        
        Change-Id: I68c895033d26c81c76e680d2042aac941d56d213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139707
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-09  Jim Raykowski  <raykowj@gmail.com>  [506af0e65e8d0896e3e9f8e2d47aa65799276137]

        tdf#150604 related: Label Navigator context menu delete entry
        
        specific to the content entry type
        
        Change-Id: I44ff745d8e61bcf24fee351cfa4148ae3ad31dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139628
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [88d7aa8ab79b1197191b5eb24a3b67d313797026]

        vcl: Drop CmapResult indirection
        
        Change-Id: I3b1beb5e976a255ef8ecdf8670b1e59547ec5ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139700
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Julien Nabet  <serval2412@yahoo.fr>  [91c0a4b982f5af093feb80eabe22b73376b5a430]

        Fix location of ScDocShell in comment
        
        Change-Id: I316d967427b6b86d3a2dbea46f535405f2966a1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139705
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4883ff377369e36ad9f080b0c5f027023707297]

        tdf#150845 fix crash in writer Form->TextObject
        
        regression from
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        
        Change-Id: I66370566562a1275c21c24523a505704508d3d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139703
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [cacb19b479f83dc0411f165edab9fd13f05b0afb]

        Fix CppunitTest_sw_core_layout on non-default DPI
        
        Change-Id: I84f21b165628577ad680c98b0f28ac6956328833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139699
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [7578842634e007d096ed146f494939bd315b78e4]

        tdf#150846: vcl_pdfexport: Add unittest
        
        Change-Id: I16a7326a0164e319cf97b1a34849a3134232364d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139646
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [eac65a1fed85cd15e860c08f39b77f29ade4a567]

        Fix CppunitTest_sw_ooxmlexport15 on non-default DPI
        
        Change-Id: Iba28b332e3f9b5c03a94f563bee9c5ecdf96a61a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139692
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Julien Nabet  <serval2412@yahoo.fr>  [3a1b2c2b01bba0f1aeff52067110c44b68cd31be]

        Simplify by using replace instead of replaceAt in loop in connectivity (3)
        
        Change-Id: If7517356959d4720bbe07acea822ec835a681a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139456
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Julien Nabet  <serval2412@yahoo.fr>  [4182f3cda4add3920c797087872b81f0212c2ae7]

        Simplify by using replace instead of replaceAt in loop in connectivity (4)
        
        Change-Id: Iab92f1ee2be1e5b9ab3fa005890acfe9acbf3732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139460
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Julien Nabet  <serval2412@yahoo.fr>  [727739fa3583a6db140a6f8ddb46b34cd4c29596]

        Simplify by using replace instead of replaceAt in loop in connectivity (2)
        
        Change-Id: I9bbe005f0bd1399b9c43cebe0e4c58d3ec88087c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139455
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [3801a45eb8e82095d5f1a65ad1646e300a900bdd]

        Fix CppunitTest_vcl_pdfexport on non-default DPI
        
        Change-Id: I6cfeed3059246d01e56b1b55c8c85f89256c7340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139698
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Miklos Vajna  <vmiklos@collabora.com>  [3ec224dcb15e0e663ba85077b8ea0e632f8f03f8]

        DOCX import: avoid duplicated bookmarks in copied header/footer text
        
        In case a DOCX document has 2 sections and the 2nd section has a linked
        header, writerfilter/ copies the header text from the 1st page style to
        the 2nd page style. This leads to duplicated bookmarks in the doc model,
        which causes an unexpected increase in bookmark count on export.
        
        This went wrong with 8885bdf2f564bb7b56181c50baf39ff99d551ec9
        (tdf#128106 sw: copy bookmarks at start if whole node is copied,
        2021-08-27), previously at least bookmarks at the start of the header
        were not duplicated, though that was also inconsistent, since other
        bookmarks were still duplicated. Interestingly the DOC import doesn't
        have this problem, because it first copies header text and only later
        imports the bookmarks.
        
        Fix the problem by introducing a new SwCopyFlags::SkipBookmarks flag,
        add UNO API to set this from writerfilter/ code and skip copying
        bookmarks (but not other marks) in sw::CopyBookmarks() accordingly.
        Copying other marks is still needed, because e.g. fieldmarks have a mark
        and a field, and it would be inconsistent to copy the field, but not the
        mark.
        
        Note that the text is still duplicated in header/footer, linked
        header/footer is a missing feature on the Writer side.
        
        Change-Id: I40e18f231ef2c0d91ae9582621684ef5b6284904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139697
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [845fa950ac635ea57dd860fb96fadcfb75e97f2b]

        tdf#150808: vcl_graphic_test: Add unittest
        
        Change-Id: Icc0f323606d5702abe03e1537e42fbd78dc6b297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139651
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d6ddd7a6c242cbe13a87266fa2e34b42454d2ed9]

        Fix CppunitTest_sd_export_tests-ooxml3 on non-default DPI
        
        Change-Id: Iaf9a36c63f2bca9b065b2370e88c5e86c5f06888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139677
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d83b84e00b33a694a28a6a08ce39d9da03b45ab7]

        Fix CppunitTest_sd_png_export_tests on non-default DPI
        
        Change-Id: Id969646a82b9a408fff111c794a6096d8e857db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139678
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [b59d13a7835b18f4676c3a11e9d70dfa9cb934b5]

        vcl: Drop now unused ParseCMAP()
        
        Change-Id: I2140b7b48ee4cc46a4a6e8e4719f3ce78a600829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139624
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [8597aed8a8576ad0f6efe139ff03556217b01b31]

        vcl: Get FontCharMap from HarfBuzz
        
        Implement PhysicalFontFace::GetFontCharMap() on top
        hb_face_collect_unicodes() so that it is the same charmap as what
        shaping code will actually use.
        
        Change-Id: I486e9d296cec5bd897e4f628d14a2f19e63b70b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139623
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [05b3d7ea4673654e809be816bee0fa67fbf0308a]

        vcl: Pass FontCharMap to OpenTTFont*() when possible
        
        Avoids parsing “cmap” table again to get it.
        
        Change-Id: I19eb882efd8c8aaaeb2fa770405ef2d69d985104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139622
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [f82e1596f5d886c60cbf41e9912de77be42eff9f]

        vcl: Sort fonts in workben/listfonts
        
        I only need a stable font order, so I can compare the output across
        invocations.
        
        Change-Id: I8141fd0425cdb638b0bf4bb4faa1889200bf8578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139621
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8ed8b54a94dd812d59e7531504248c99db6be194]

        Fix CppunitTest_sc_subsequent_filters_test2 on non-default DPI
        
        Change-Id: I940c3213dda02a73924a9f8dc6500d7ecc38ba6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139674
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c5bed7889fe391e0e408248c2db042b5e489bcda]

        Fix CppunitTest_sc_jumbosheets_test on non-default DPI
        
        Change-Id: I067622274cfa7518462ad74015dc3942f35b6b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139675
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Stephan Bergmann  <sbergman@redhat.com>  [85279475eb9f59119ccfd81caad1afb801eb49bc]

        Clean up some #includes
        
        ...after 9e7e95a57b7c16941d9fdc59f806c1f9e4263379 "tdf#147021 Use std::size()
        instead of SAL_N_ELEMENTS() macro" (and somewhat pedantically use the canonical
        <iterator> for std::size, even though the existing <vector> defines it, too)
        
        Change-Id: Iacf0a0619b496bfe7c6abb0a812b6a1b3eed40c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca510d64b4d27615fdabecb4dd146193cef48d8c]

        loplugin:unusedmethods
        
        Change-Id: I94861f9fa8d8a5d22a89c902984ad2afed43dc14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [75fcdffdcb1be4bab1f7e7c015ccf05ceef9d700]

        loplugin:unusedfields
        
        Change-Id: I104015dd9339fca3b274532ba475a66c7b01481d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1bc633f6b1e4ccee7e9911aa09a6d4e3e5b5d6e4]

        loplugin:unnecessaryvirtual
        
        Change-Id: I4461ca826960b194cf45ae4917093f3273b3b0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d222e26c9a4bde2f7a410a739e6546e193039dc]

        loplugin:virtualdead
        
        Change-Id: Iceb6916bcc8c211a72fccfa4bbcbb22c96a72050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139642
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [985aaf05cc8ac3612fb9155f0d41eb84981ce9e6]

        fix comments in xcu
        
        that I introduced with
            commit d156e891db34e88991a6c18fd3cff6feddfc61c8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Sep 6 10:30:42 2022 +0200
            tdf#150682 - bad shortcut in french langage
        
        Change-Id: Ibfb2613222456d6446cb81db948d6eb9c7be190f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Rene Engelhard  <rene@debian.org>  [fd42cea5f301a10cdeaa29959f04b111de534132]

        replace egrep/fgrep calls with grep -E/grep -F
        
        as egrep/fgrep is deprecated since long amd grep 3.8+ now actually warns
        (e.g. "egrep: warning: egrep is obsolescent; using grep -E")
        
        Change-Id: I5b10f05dffdd09081deb05cef974e3cdb2907315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139614
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [09e499e64ec4acb24c9524c8aacabc6182124442]

        Fix CppunitTest_chart2_import on non-default DPI
        
        It is really unfortunate that so much of our code depends on the
        DPI, that should not.
        
        Change-Id: Id1916677add508171490591a234f07a82a8e3f5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139648
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [707b0c328a282d993fa33b618083d20b6c521de6]

        Rework of SoftEdgePrimitive2D
        
        This is pretty much the same for SoftEdgePrimitive2D as the
        change for GlowPrimitive2D, so for more comments please refer
        to commit c2d1458723c66c2fd717a112f89f773226adc841
        
        Added suggested change of DoSaveForVisualControl mechanism
        
        Change-Id: I28901e7a0b6e1823000d2aa6a335ce2fd80e6ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139585
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [7d9c03fb354af184f35e257f319a70ef3481703a]

        Turn a macro into a function
        
        Change-Id: I7c98ae858f345389b63c4b429367612f7fb3691a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [9f682acf75d56c82b40114bb9fceb29d837de2dd]

        Related: tdf#150786 workaround unit test failure
        
        The test detects a different problem, so this issue is unrelated to
        the detection. Indeed, after this issue is fixed, the test could be
        restored to test it all, complementing the test coverage.
        
        Change-Id: Ie3c8621d76bf1ccb58ffbdde875a7adb7bceb76a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139639
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [686d9caaba6e1fe0bb1e1caedc6869fa9f2bddc7]

        Fix typo
        
        Change-Id: I0dc42449baa4bed54aa1fdd60c1b62d4a9cb358e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139647
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Miklos Vajna  <vmiklos@collabora.com>  [4d672ac4d1670e20551497abb0c9d48e1aca7fb5]

        CppunitTest_sw_uiwriter8: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ib1fb52e1677f343999878bc288ef0cb346d665a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139612
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [db85b90b52e87a97f62c15900801e3297bde4de3]

        tdf#150770: sd_import_tests2: Add unittest
        
        Change-Id: I4bd5f934abb62a161a2002697d68e1bda72e697e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139634
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [94b9827f790ea1d37c2e128df1e3dc4b57c5f768]

        tdf#150756 Assertion when opening report for editing
        
        regression from
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        
        Change-Id: Icfdf74035658a6d8222059bb6db36c852a51c4de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Miklos Vajna  <vmiklos@collabora.com>  [b06bd8a4f837ea30d6410190c701f5b27ad9d04c]

        sw: add an initial uitest for SwContentControlDlg
        
        And also test the inner SwContentControlListItemDlg.
        
        Change-Id: Ida92223f49871900f8f6692f21d5052cdb04dd2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139633
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [7aa5e94b712186bf2f65be39ea7c8f7978f1144b]

        tdf#150832: Revert "tdf#150034 very slow opening pathological chart"
        
        This reverts commit 613f6e75fbfcc024fc9c3732261cbf2cda6f4ad8.
        
        Reason for revert: it seems all charts in XLS files are affected.
        At least I could reproduce it with all the XLS files I tested it with.
        
        Change-Id: I68d13d6f609521ce6af759cf25249656176b66cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139557
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-08  Juan C. Sanz  <jcsanz@libreoffice.org>  [5d40ced9e8b0aa1e4c07aea56ed8c1bdaa89705f]

        Revert "tdf#150569 Modify hardcoded dates to extend the range of accepted dates"
        
        This reverts commit b20594f2fc8f6f9fdbf0b257b4e74d95a8d90139.
        
        Reason for revert: Further testing has shown some errors in other ways of displaying the data
        
        Change-Id: Ic4909f8571c8730ab3ba622c7fad99f2646616ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-08  Miklos Vajna  <vmiklos@collabora.com>  [cd30c34ed8465555b217b25ff353ae623923a7e4]

        sw: fix crash in SwViewShellImp::AddPendingLOKInvalidation()
        
        Fatal signal received: SIGSEGV code: 1 for address: 0x0
        program/libswlo.so
                SwViewShellImp::AddPendingLOKInvalidation(SwRect const&)
                        sw/source/core/view/viewimp.cxx:167
        program/libswlo.so
                Notify(SwFlyFrame*, SwPageFrame*, SwRect const&, SwRect const*)
                        sw/source/core/layout/frmtool.cxx:3299
        program/libswlo.so
                SwFlyNotify::~SwFlyNotify()
                        sw/inc/anchoredobject.hxx:204
        program/libswlo.so
                SwFlyFreeFrame::MakeAll(OutputDevice*)
                        sw/source/core/layout/flylay.cxx:141 (discriminator 3)
        
        Change-Id: I01a64c6e0c2ad4c72cf1a9edeca2aa22e08441b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139629
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [6b0ba9c94ed094cf9963b90c33671df9475867ce]

        SAL_WARN on parse exception
        
        Change-Id: I124b73844105b43ba9c474d5ff685d703bd30f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139630
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-08  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [392b2cd4889cf944ed47b3473c6dd2cc1f89e7e7]

        tdf#150102 Correct PrefSize for UNO API Metafile exporter
        
        Checked that in aBound is indeed the size - 1 (probably
        due to old integer stuff using Size()/Rectangle() and
        getWidth()/GetWidth() with the old one-less paradigm
        somewhere), so just correct to the correct size. Be aware
        that checking of tdf#126319 is needed, but looks good in
        my tests. Still: Changing the central UNO API Metafile
        export is always a risky thing, so it will have to show
        if this will not influence something else.
        
        Adapted a unit test to take into account that the exported
        object as PNG no longer has an empty column at the right and
        lo longer an empty row at the bottom. That test testTdf126319
        uses now the same test-indexing as the test testTdf105998
        already used. This shows a more correct PNG conversion, it
        was curious anyways that two identical exports of objects
        with a light-red border from dfferent apps had that
        difference at all.
        
        Change-Id: I8513688dc062025c5d931b75602f4fdbd924a32a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139596
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [467308d679a3f2b4bbdd117fcc73636d57d66c09]

        tdf#150846: FilterOptions in descriptor could come from import filter
        
        Tolerate failure parsing json here. Unfortunately this means that
        we can't provide a diagnostics to user when they provide bad json
        in the command line parameters.
        
        Change-Id: Ia3fa18e709a4c0b891faf4365453b79e6c58a9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139613
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eeca59964629f302802eeb03c4537fa6f7558a66]

        Fix typo
        
        It passed "make check" on my laptop
        
        Change-Id: Ideb7d2cd00bd1b3237924971e4a57d4e61eeea52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138533
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-08  Rene Engelhard  <rene@debian.org>  [429a4af9bb53bd0b69170e5e518352c47b3c00a0]

        revert configure.ac check for graphite2 to 0.9.3
        
        root@frodo:/# grep Version /usr/lib/x86_64-linux-gnu/pkgconfig/graphite2.pc
        Version: 3.0.1
        root@frodo:/# dpkg -l libgraphite2-dev
        Desired=Unknown/Install/Remove/Purge/Hold
        | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
        |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
        ||/ Name                   Version      Architecture Description
        +++-======================-============-============-==========================>
        ii  libgraphite2-dev:amd64 1.3.14-1     amd64        Development files for libg
        
        2.0.0 is a internal version (see
          https://github.com/silnrsi/graphite/commit/175151a45f4c228af912d52f8c299b96b124a136). At least 2.0.0 is fullfilled, but probably we shouldn't use it
        for checks
        
        Change-Id: I70ac1ff20ca5d583bbfa961bfd275ff6432d243c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139627
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: René Engelhard <rene@debian.org>

2022-09-08  Justin Luth  <jluth@mail.com>  [77689ceb8171943bfea272ce3c875b061e76e23b]

        tdf#149292 docx: pre-emptive unit test
        
        This document has floating tables.
        However, these tables should not get the page style property,
        so make sure that paragraph 1 contains RES_PAGEDESC.
        
        Change-Id: Ia7506907ce192a0ecbf2c57b4fc63b14882e93b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139619
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [a3bd84703ada964441c17971b5fc1ce1258b3b05]

        Require HarfBuzz 2.0.0
        
        Released October 2018. We want to use some newer APIs than the currently
        required version.
        
        Change-Id: I85f572ad3b7155926ad36a11b3afaf08a2a11714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139607
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [10ac07e03276889a68ebc9abc9bd14e88b49a27c]

        vcl: Drop now unused FontCharMap::GetGlyphIndex()
        
        Change-Id: Icf687d09c2d25a3d578faf7ae574b3e655b8540f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139600
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [e34d6e017ccfa2279f7e855eb6fd5fbbbd056714]

        vcl: Add LogicalFontInstance::GetGlyphIndex()
        
        And use it in a few places, particularly where we get glyph ID from
        FontCharMap. We want to get the glyph indices from HarfBuzz like we do
        for shaping, to avoid any potential discrepancy (e.g. a new “cmap”
        subtable that our ParseCMAP() would not automatically support).
        
        Change-Id: Ie80993b35f0586d8567b6bda0ea56ba453316e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139578
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-08  Khaled Hosny  <khaled@aliftype.com>  [ba02639c9c17d75e73fc2eff83e64c116fcdaeb2]

        vcl: Make glyph IDs 32bit
        
        To match corresponding HarfBuzz and Cairo types, and would eventually
        help us in supporting fonts with more than 65535 glyphs (currently
        supported only by HarfBuzz).
        
        Change-Id: I239421bcef6e1b26f17a4666243a239174ea4943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139576
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-07  Eike Rathke  <erack@redhat.com>  [5aa3f046f934092fbfd7cc92b93d79b4f548cc13]

        crashtesting: prevent nullptr access
        
        There's a xlsx export crash on *2nd* export with data pilot data
        of forum-en-38962.ods. We export without crash this .ods to xlsx
        *once*, but on saving again to xlsx it crashes. It also crashes with an
        export to .xls and then an export to .xlsx. Repeated exports to xls are
        crash free.
        
        Already on the first export there are loads of warning messages of
        
        ScDPMember::GetItemData: what data? nDim 0, mnDataId #
        ScNameToIndexAccess getByIndex failed com.sun.star.container.NoSuchElementException message: "at sc/source/core/data/dptabsrc.cxx:2267
        
        The pivot tables are broken on both exports.
        
        This smells like some sort of data pilot cache
        corruption/insufficiency during .xlsx export but the root cause is
        yet unknown. This only fixes the crash symptom.
        
        Change-Id: Ie479f7f0abc4af284e61f6aa5a69943ccdd72eab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139611
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-07  Tomoyuki Kubota  <himajin100000@gmail.com>  [86498bcd73050e44ea5ea53c384edb0baf033d16]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Ibd3f56f6e669a3bb1c1926aa4affdcc46623c81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [f8ef0f78ed1432659cc0537a0ebb85abe9211369]

        cid#1509288 rearrange to make clearer what actually happens
        
        similar to
        
        commit ce36d36233053cea8b5db7f39f2693726a43940a
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue Sep 6 14:25:09 2022 +0100
        
            cid#1500385 rearrange to make clearer what actually happens
        
        Change-Id: I559dab7b8570662644f6b4dac392c307bdef9a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139603
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [0fe9ce208190d2329707a8684ed705c2e7d6f1d0]

        cid#1509283 silence Dereference after null check
        
        and
        
        cid#1509253 Dereference after null check
        
        which seem to exist since:
        
        commit 42ba2b6c03a74815d2041e554fea83350d554dd1
        Date:   Mon Sep 19 15:37:25 2011 +0200
        
            Text Boundaries: draw small inner corners for the columns areas
        
        Change-Id: Ibd292003349816107acf5044433c67ba6accc84b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139605
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Stephan Bergmann  <sbergman@redhat.com>  [1bd83f0f6ad3d9fa84b4eae38b3393526e233771]

        Be careful with failed realloc
        
        Change-Id: I809e70487b9174ae902d3a11cc2845ec310d009f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139610
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-07  Tor Lillqvist  <tml@collabora.com>  [0c05d4dc4810749e65e81e98f04805b251d61e5a]

        Fix register clobber information and simplify in the C++/UNO bridge for iOS
        
        Avoid the use of unnecessary local variables to temporarily keep
        return values from a function called by the inline assembly. Instead
        use the GPR and FPR arrays also to temporarily keep such return
        values, like the Linux aarch64 code does.
        
        This fixes https://github.com/CollaboraOnline/online/issues/5204
        
        Change-Id: I11aac56e9c8cc8aff1a3653ced45bdf4844cbcca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139604
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb4216a9c933bf64ec7a30340b596cb83fe1b599]

        tdf#150307, tdf#150829: sc: Add UItest
        
        Change-Id: If4a7e9fc6e4d9057f880f6b8c1dba7598597031e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-07  Stephan Bergmann  <sbergman@redhat.com>  [3b98992ce119610d0d173939201dee1a331638f6]

        Remove obsolete comment
        
        ...after c8fd50f9ec02a131fd4c99e80f7252b49015653a "python3: upgrade to release
        3.8.13"
        
        Change-Id: I43428485e7cdffec7b3a7a575334bd886e2f26c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139609
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [4e55e2a10945d57aa39662e795a8a5c3b8ca41a0]

        cid#1513730 Useless call
        
        since:
        
        commit 3a8c74efa2da18f16af4f395e46ee13bfdfa76cc
        Date:   Mon Sep 5 14:16:28 2022 +0200
        
            use more SwPosition::Assign
        
        Change-Id: Ie6fc37f33c1c5b7ec1c65f5a880044b261f4130a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3b62c0018106adf493246cf129a4ff8b47067523]

        Fix typo
        
        Change-Id: I4f4133ca077d69e3238aba809cd758455918bc39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139586
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-07  Julien Nabet  <serval2412@yahoo.fr>  [e485d917058ff3c5ebf348c1e0ec28f0fa9b1b93]

        tdf#150808: General error importing svgz file
        
        Change-Id: I7f2a8c6ffe4eba0c9e75913bd3e4671b0727fd94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139537
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce79edd7e79c28516ba43814e4f900b2c05ab23a]

        Revert "tdf#150555: Skia seems to fail with Windows 8/8.1"
        
        This reverts commit e2a16489ff4a65e747e93b28d39096cb259bddd7.
        
        Reason for revert: See discussion in https://gerrit.libreoffice.org/c/core/+/138549
        
        Change-Id: I9ad22c594478d11e1eb062f69d83ce6b55b09eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139554
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [86b55d24940b476162c1a9d218082fbe9a0bf1e1]

        cid#1500419 rearrange to silence Use after free
        
        Change-Id: I4529306d94c88ba6572f108f512f1521c849246c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139536
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Justin Luth  <jluth@mail.com>  [c24fe44064c6624fefe642508086c8562c372fba]

        tdf#149547 fix "tdf#75297 sw uno: override default num char style"
        
        The problem was that things like chapter numbering were
        creating this style on import.
        Interesting that it didn't do it for my use case.
        
        This fixes 7.5 commit 758945b077220fe151c1565c6d5b0bad02de6d58.
        
        Originally I left this clause "as is" because I had not yet removed
        the obsolete part of the condition. But now I can change anything
        in that .isEmpty() clause since
        commit 1a57418e2837e7fd07b0619804feed06e1acfe41
            remove unused sw UNO_NAME_CHARACTER_FORMAT_NONE
        
        Change-Id: Ie52a0d1392d49ba6ae8a5620ab453ff7129bce7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139584
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [9220716bed8ff4337453f06788233aa73463d63b]

        tdf#150810 get visible placeholder text in GtkEntry with focus
        
        in gtk3 focus causes placeholders to be not rendered
        https://gitlab.gnome.org/GNOME/gtk/-/issues/378
        https://bugzilla.gnome.org/show_bug.cgi?id=657613
        
        FWIW, currently in gtk4 they are shown when focused
        
        Change-Id: I623c81dd71f651d8b24a717a63fe428bc9d6a505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [c8fd50f9ec02a131fd4c99e80f7252b49015653a]

        python3: upgrade to release 3.8.13
        
        Remove some code in external/python3/darwin.patch.0 as it was fixed upstream(https://bugs.python.org/issue45405).
        
        Change-Id: Ie6bfb2456f96a63adbf0dbcb9c902dc56f1151ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139493
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [0797eaaa04f2c932ef428c664b4f3fa32fa74a7a]

        apply ui-rules
        
        Change-Id: I5acc6cfe5488f8aa92ecaafa0ebdc50f2ad9758e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [fa877608bb65dc4d115455be5ce72f009ce0334b]

        we don't use urgency-hint or want any gravity hints
        
        Change-Id: I86255f9ba018aab7db654d91bf49043fcd4cb057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139590
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [28f40b79639c37da8af810d9d327b1af5baf8447]

        add truncate-multiline for consistency with vcl and all the others
        
        Change-Id: I7ccc294308d487ce2443699a946753290344a92d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139589
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [5791c779635b5d42de3c5691bdbadf4a079e096e]

        vcl: convert ImplGetEmphasisMark() to EmphasisMark class
        
        It makes more sense for an emphasis mark to be an object that can be
        queried, than it is for it to be a function with lots of output
        parameters.
        
        I have added a unit test, note that for now something doesn't seem right
        with polypolygon equality checks (test fails, but the disc is generated
        the same way) so not testing the shape creation.
        
        Change-Id: I7597603419b69639b8d9764afdb68e266da7a56b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122601
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [980c3721f0eb7665a2af5d7d5c363f8b5d0c3152]

        gtk4: caps-lock-warning is gone as a property
        
        Change-Id: I66aac55f0ebb381bc2f9f1fffbdb887d4a016005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139588
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [ddca05e0b38ebf113cec8f8803b4640fee50db69]

        every other .ui is version="3.20"
        
        Change-Id: Ifc45b74e06069855021b7c963a3e5c83c8eacfcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139587
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [48a822fe60fa6cdb8d105604f4511bd7f7d69903]

        Use exactly two comparisons in fround
        
        It is used extensively in drawinglayer; the typical path for values
        inside sal_Int32 range used three comparisons.
        
        Change-Id: Iafb09f06a746bb53a41585be4a5b1a701fa38057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139555
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [ca6888484e643e0c55918d9c882241e6dd6b734f]

        Related: tdf#122737 A hack to keep backing window opaque on context destruction
        
        Also this incidentally improves OpenGL frame rate, which could decrease
        the problem visibility (but indeed, this is not a proper fix).
        
        Change-Id: If1d0eec78cad14548a51be7da76f16a3ecfcddb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-07  Miklos Vajna  <vmiklos@collabora.com>  [f8a1dd7388403ecd7eecb4bfbc26e2732e01891e]

        sd: rename WriteAnimationNodeAudio to Media
        
        Because XAudio means both video and audio, see
        <https://gerrit.libreoffice.org/c/core/+/139265/comments/479934b4_978756a7>.
        
        Change-Id: I4d631d55ec1694c11e24c65b0826771c87457cdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139579
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [b4a82907eb13de4feabc9f09f8fa7d45d6c9eaec]

        use o3tl::span in SvXMLItemMapEntries
        
        which means we don't need to calculate the size of the map
        at construction
        
        Change-Id: I295defd7c4609b22a994928f6442fadadd9df66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [9251f7ef5aa705a2c5b2a5612167ffed7e3b4347]

        convert PreviewMode to scoped enum
        
        Change-Id: I36d6153e5bc65311ec5708839e640cf104b3f035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  jucasaca  <jcsanz@libreoffice.org>  [b20594f2fc8f6f9fdbf0b257b4e74d95a8d90139]

        tdf#150569 Modify hardcoded dates to extend the range of accepted dates
        
        Replaces date range limits to allow entry of dates between 1/1/0001 and
        31/12/9999, which is the normal date range in most database manager
        
        May need some discussion
        
        Change-Id: Ide8dfc64663d2ef2a66d8b7e1af3ef8ed3bb0af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138845
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  László Németh  <nemeth@numbertext.org>  [b251228d2e5e2832e0a617213173e8841f5b7428]

        tdf#150666 sw: allow to delete tracked table row insertions
        
        It was not possible to delete tracked table row insertions,
        if only those were selected, or if they were own insertions.
        
        Regression from commit 95213407dfcbf34056037d60243ff915340d1a2e
        "tdf#146622 sw crash fix: don't delete already deleted rows".
        
        Change-Id: Idd3bc78bca1c76bceba63cf339c6d8c73f8f9508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139575
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [87d03edf08cda2f9f6a9d4ef9e5b7fe71964c71f]

        convert ElementOpenMode to scoped enum
        
        Change-Id: Ib1b714c377ce0d4935ba5ead68163d69fa091cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [8fe31ee550bd6f127b4c1ea335ef8177ccafa747]

        ONavigator doesn't need a pimpl
        
        it is module private
        
        Change-Id: I21779fe8ac50aa4602e4c3d7798d0ced1ddab066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139541
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Caolán McNamara  <caolanm@redhat.com>  [65eb1595fc320b71937052da70bfc717ff34b18b]

        ofz#50118 Timeout
        
        Change-Id: Idf0669d62b8bb6d21a6b5ad22f698449bb66e531
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-07  Miklos Vajna  <vmiklos@collabora.com>  [95843ba6f75b2438a1a9b8c0cc4a001c45f3091d]

        sw: clean up DocxAttributeOutput::EndContentControl()
        
        This always felt dirty, and seems it's no longer needed. Remove the fly
        frame condition before somebody starts depending on it.
        
        Change-Id: Id286ab37981fd1890ca88bf5a17cb78876bcd2ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139574
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-07  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [3d4895e0720f5f0f5dc748470bd42d0aba2f6244]

        ConvertToBitmapEx slightly too bright if transparency involved
        
        Stumbled about this error when working on re-designing the blend
        primitives for shapes. Using convertToBitmapEx is the base for
        these (also for the UNO API conversion from Primitives to
        BitmapEx).
        
        Use a VirtualDevice in the Alpha-mode now to solve it. This
        creates the needed alpha channel 'in parallel'. It is not cheaper
        though since the VDev in that mode internally uses two VDevs,
        so ressoure-wise it's more expensive, speed-wise pretty much the
        same (the former two-path rendering created content & alpha
        separately in two runs).
        The former method always created the correct Alpha, but when
        transparent geometry is involved, the created content was
        blended against white (COL_WHITE) due to the starting conditions
        of the content creation.
        There are more ways than using a VirtualDevice in the Alpha-mode,
        to do this correctly, but this is the most simple for now - and
        I was persuaded by the following argument:
        Due to hoping to be able to render to RGBA in the future anyways
        there is no need to experiment trying to do the correct thing
        using an expanded version of the former method.
        
        Change-Id: I23e005f9c3723059e2b88660fede09aa83844b38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139272
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [329c1e6c0310429163a77d760acd5b3043873bc7]

        SvXMLItemMapEntries does not need an impl
        
        it is module private
        
        Change-Id: Iaceb84b6868fe1450eab748f34f131a3867d38cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139542
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Miklos Vajna  <vmiklos@collabora.com>  [22ed308622c1ab07d4f00a6b8150630b5d168906]

        filter: remove no longer needed back-compat of the svg presentation engine
        
        This was added in commit 4063dcdc7305177b167bd20b009b1dfede8b25ec
        (Revert naming back to lool to fix break with LibreOffice Online,
        2022-08-26), to give consumers of that API time to switch from the
        product name to the API name.
        
        Now this patch removes the product name, only on master.
        
        Change-Id: I27e2fd03c8ca646ffb0e0df541b7f94bd9ad3516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139551
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [f5c6ef40dd494f6984c6ed784fccc02806999836]

        OXReportControllerObserver does not need a pimpl
        
        it is module private
        
        Change-Id: I50bd06aa1b75d7561aee788c69c0482c6293db16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139540
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Noel Grandin  <noelgrandin@gmail.com>  [e801c211911deb673c8f75b5072a58c88832b720]

        convert ObjectType to scoped enum
        
        Change-Id: I1c103aebe02a41ed4fa59a72950cb55d3c6c93d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-07  Jim Raykowski  <raykowj@gmail.com>  [a8e4bf44012139adff7d1343f17edca13a70d0c5]

        tdf#150604 Writer Navigator: Make delete shortcut key delete Indexes
        
        Change-Id: I651159794790972b430c9a420d6eaa1ed77e5718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139550
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-09-07  Miklos Vajna  <vmiklos@collabora.com>  [b87685a7dd70efd707145e716056e9d4e56ce1e7]

        CppunitTest_sw_ooxmlencryption: remove not needed mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        All the tests in this suite are docx files, so this was an unnecessary
        override.
        
        Change-Id: I519599abd5081ec68c9603befbb16794dd5696b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139532
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-07  Eike Rathke  <erack@redhat.com>  [922b79a0f5a9151a6870ba395abcac5b54055275]

        Resolves: tdf#150829 Broadcast missing ScAreasChanged hint on sheet copy Undo
        
        Change-Id: I354b1e395079067cd4cc9299501b3936dea00cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139538
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-07  Satya  <skompella@opentext.com>  [88338b6bf1fdf9420d9ae9d1c78dc8b897f0ad7d]

        tdf#147646 Auto numbering is wrong when the row has split/merged cells.
        
        The fix is to,walk through the paragraphs in the cells that are
        vertically merged(PROP_VERTICAL_MERGE)and remove the numbering
        rules property from underlying text of those paragraph
        properties of a cell.
        
        Note that,there was a similar bug for DOC files,and it was fixed
        with tdf#49102,we need to provide a seperate fix for DOCX files
        as the DOCX filter is different than DOC.
        
        Change-Id: Ia1cc22cbc04448a11ae0d136519681d9363e2828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139401
        Tested-by: Jenkins
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-07  Eike Rathke  <erack@redhat.com>  [19648eca2d9cd729251af5ddfca7aae2dd8c7e14]

        Use XCharacterClassification::getCharacterType() instead of getStringType()
        
        Change-Id: I0bbd196a8691fb72a1f091af8825df749bfc7cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139535
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-07  Eike Rathke  <erack@redhat.com>  [55e7de171b666a87f29f072e0a4787480946c066]

        Always enquote ColRowName (label) as SingleQuoted
        
        It's anyway required by ODFF and also in UI prevents confusion
        between defined names and labels of the same name.
        
        Change-Id: Iba03f15f1f778132696101507e61cc0ef8de6c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139533
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  Eike Rathke  <erack@redhat.com>  [bb571bb225a5a5f3fa81b7aaea6cd559ebf1a94b]

        Add note to XCharacterClassification::getStringType() about meaninglessness
        
        Given how it works that's almost deprecated, almost..
        
        Change-Id: Ife2fe012db5568e4646b98b0ba55df8418069062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139534
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b218e34b9b92e5359b1c272d52f12259133876c1]

        svx: set vars to initial values in constructor init for SdrTextObj
        
        Change-Id: Id3fb342a4273b617ac2975bff3dd79159ab8df75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139531
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f8c7b96cc7f9752122a615524000665583ebb52]

        svx: fix description of SdrTextObj
        
        bTextFrame is now mbTextFrame and the type is changed to bool,
        so no more sal_True and sal_False.
        
        Change-Id: I55572df1b717444bdcc9ae875856bc9f9bb2674f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139530
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e71b7c917eab6357350f86e05936d25d4192f42e]

        svx: remove "using namespace *" in tablemodel.cxx
        
        UNO types are clearer when written from com::sun::star as root
        namespace.
        
        Change-Id: I9e063a904ecbdf471c9ca295a2f0c5bd727b9711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139529
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c502b9a2d56e907412ce6cddceae5b272ebd2e1]

        Removed executable permission on file
        
        Change-Id: Ie9097527d66cdb6ce5c616dcaaf5e2eafd282733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139481
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [ce36d36233053cea8b5db7f39f2693726a43940a]

        cid#1500385 rearrange to make clearer what actually happens
        
        Change-Id: Ibdd70300b5081b5ad054fed5db65fc3c8cc4c3cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [0e77a73f2f8bcdaa36dd3c099405123c614b4770]

        cid#1500509 silence Out-of-bounds access
        
        Change-Id: I6f23c74f5e69610f1f3bf387467796f20ad4515a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139522
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [37017c52ae3705e4d609e25a6722d588abe706c2]

        cid#1500538 Big parameter passed by value
        
        Change-Id: I4d432026d260c6bbda183a7849a83ed3f0a6a27c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [903d4a1fa770e1b9c2d020e3d3ada5fcc0de4395]

        cid#1500594 Explicit null dereferenced
        
        since
        
        commit 5480d9237af1cf25ac464bf49ba364a757fcf6f5
        Date:   Sun Jan 24 22:17:49 2021 -0900
        
            tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse
        
        lets make a copy of the iterator
        
        Change-Id: I855c58377871d7fb55ea676ebac48c0abc67e98c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Mike Kaganski  <mike.kaganski@collabora.com>  [a71f537c0243fd89b7bc153889fee0a65fed6726]

        Simplify SalSysObj(Child)WndProcW
        
        Change-Id: I578410db327c98cde5e6e2a9f802e4de5b64a539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139492
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-06  Mike Kaganski  <mike.kaganski@collabora.com>  [af415dc03f34cd89f9e6319971d00edb76ccba85]

        This can't be null after the null handler above
        
        Change-Id: I70c0d28fe5d817fbdbc9ad499e4e6e729f81399a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139510
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d156e891db34e88991a6c18fd3cff6feddfc61c8]

        tdf#150682 - bad shortcut in french langage
        
        the = key is } on a french keyboard,
        so remap the
          ctrl-alt-=
        shortcuts to
          ctrl-alt-}
        which means the user gets to keep pressing keys in roughly the same
        physical location for this action, regardless of keyboard
        
        Change-Id: I03e251dacc1c19e543182a44ae23fde2a57cfa45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [ebd697df0cfed7078346e61c069891cf02c2cc54]

        desktop : use a std::mutex instead of a osl::Mutex
        
        Change-Id: I149af335196eaa31cbd11965e1656c3dfe7431ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139440
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [604edde1946d4e0ced67ad9a7514253a6fe7fa40]

        sc : remove useless lock and init in cellkeytranslator
        
        Change-Id: Ibad2dfb721e4df390ddaf955a8b7fcdf676773e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139447
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [17e27b4a19f22b912460f090b754d11f9a32fb7f]

        tdf#150756 - Assertion when opening report for editing
        
        regression from
           commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        this logic is not meant to kick in for reportdesigner.
        
        If this commit causes further regressions, and we need to reinstate some
        form of this logic, it should be conditional on a flag which is
        deliberately set by the modules (probably only sd) which actually need
        it.
        And the flag should be an explicit "I want to kill attached UNO shapes
        when the page changes" rather than being conditional on some other
        condition which is, at best, only tangentially related.
        
        Change-Id: Ibc09149ab4ff88fde8d1bd1e0545e255ccdba50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [46216a79f440dc972724bb243396b295267530ce]

        check impress/calc IFrame "FrameURL" target
        
        similar to
        
        commit c7450d0b9d02c64ae3da467d329040787039767e
        Date:   Tue Aug 30 17:01:08 2022 +0100
        
            check IFrame "FrameURL" target
        
        Change-Id: Ibf28c29acb4476830431d02772f3ecd4b23a6a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Miklos Vajna  <vmiklos@collabora.com>  [456abae730a787693c3ad98f7e57eba5f6163a76]

        sw HTML import: fix height of OLE objs when it is missing and width is relative
        
        In case an OLE object's fallback bitmap had a width=100% size but no
        explicit height, we used to set the OLE object's size to a fixed value,
        based on the bitmap's pixel size.
        
        Falling back to the pixel size based on the current DPI is sensible if
        there is no height specified, but browsers keep the aspect ratio when
        only width or height is specified and we didn't.
        
        Fix the problem by explicitly checking for the "one axis has percent
        size, the other is unset" scenario in SwHTMLParser::InsertEmbed() and
        then handling the new SwFormatFrameSize::SYNCED value in
        SwHTMLParser::SetFixSize().
        
        Note that SetFixSize() is not used for bitmaps (only for OLE objects),
        so that codepath may still need a similar fix.
        
        Change-Id: I9f70307edbfbb06e228494fb5c04e7381ed8e5cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139526
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [1fb2b68d89d80ccc1b546685ea26a72796060f0b]

        cid#1500587 silence Dereference before null check
        
        Change-Id: I3672d8266b339f06d5c75285fb9582f331a07c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [2b9078b01889ededaf7de3e060ecf52261ef7815]

        cid#1500607 silence bogus Use after free
        
        Change-Id: Ibcb52aad5d47635e7096025d5b31de1b81503ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139517
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [8e7cb64a260831f3aa6561c05f1cf0ea5be56789]

        cid#1509195 silence Explicit null dereferenced
        
        Change-Id: I9a7cbdb0e2cc4a5624d78dbb88c7f5dacc68f309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139516
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [6bad4f6aed63c3fd54c46b269a285013e3ced553]

        cid#1509284 DMI: Dubious method invocation
        
        Change-Id: I1fd1f710ae2a6b8ebc9506a56d522006509fc935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Caolán McNamara  <caolanm@redhat.com>  [5c365c62aafc12f16bfcfe3804f95f2bb45c7421]

        cid#1509199 silence Constant expression result
        
        rename IsEqualData -> HasSameData
        
        Change-Id: I6294c847c284888e5537e04dc4f84314586c4b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139514
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Eike Rathke  <erack@redhat.com>  [64f673238cf9b645a751e8f8137ca14e595a779a]

        A ColRowName (label) is a QuotedLabel is a SingleQuoted
        
        Hence a ' is not escaped by \' but by '' doubling it.
        
        See also ODFF 5.10 Quoted Label
        https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#__RefHeading__1017950_715980110
        
        Apparently this was always wrong and even stored in files and
        never correctly read/compiled back.
        
        Change-Id: I94bdb7d1fdffe9bbd77cf443883dd76637be981b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139491
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a193c81f735771796a347cb4d545b8d277c0625]

        tdf#142031: sc: Add UItest
        
        Change-Id: Icfe8229a0079bbe5be8394883299b2f959a74efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139489
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [394655636307de3ba3c4b2d52f3c1abf4b900e18]

        vcl: Drop unused SalGraphics::CreateFontSubset() argument
        
        pWidths is always nullptr.
        
        Change-Id: I1c666f146865786269e9513cbb6c8ffdc7df96e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139461
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-06  Stephan Bergmann  <sbergman@redhat.com>  [12b89902036dba8d457c3e03080a4db50b99adcb]

        Use of uninitialized bMatchedRangesWereClamped
        
        ...introduced in a740176009411d21e20d7c11097af1d8812d251d "tdf#150749 Find and
        replace on very large sheet", causing
        
        > sc/source/ui/view/viewfun2.cxx:2068:94: runtime error: load of value 52, which is not a valid value for type 'bool'
        >  #0 in ScViewFunc::SearchAndReplace(SvxSearchItem const*, bool, bool) at sc/source/ui/view/viewfun2.cxx:2068:94
        >  #1 in ScTabViewShell::ExecSearch(SfxRequest&) at sc/source/ui/view/tabvwshe.cxx:264:21
        >  #2 in SfxStubScTabViewShellExecSearch(SfxShell*, SfxRequest&) at workdir/SdiTarget/sc/sdi/scslots.hxx:1461:1
        >  #3 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) at sfx2/source/control/dispatch.cxx:254:9
        >  #4 in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) at sfx2/source/control/dispatch.cxx:753:9
        >  #5 in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) at sfx2/source/control/bindings.cxx:1060:22
        >  #6 in SfxBindings::Execute_Impl(unsigned short, SfxPoolItem const**, unsigned short, SfxCallMode, SfxPoolItem const**, bool) at sfx2/source/control/bindings.cxx:964:5
        >  #7 in SfxBindings::ExecuteSynchron(unsigned short, SfxPoolItem const**) at sfx2/source/control/bindings.cxx:863:12
        >  #8 in SvxSearchDialog::CommandHdl_Impl(weld::Button&) at svx/source/dialog/srchdlg.cxx:1362:19
        >  #9 in SvxSearchDialog::LinkStubCommandHdl_Impl(void*, weld::Button&) at svx/source/dialog/srchdlg.cxx:1262:1
        
        during UITest_search_replace
        
        Change-Id: I05cd21ed881e120807f9859f6724c5023a96a989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139488
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [70e97793769baaa8e0fbb8d8d3949655c4aeb654]

        vcl: Drop now unused SalGraphics::GetGlyphWidths()
        
        Change-Id: Iec8974d6fc67d9d599c5e92aa325225963da0021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139459
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [789b517819495a9efff5538de7e8e5106fc64f81]

        vcl: Drop now unused PDFFontCache
        
        Change-Id: I7959103f43d993e39bff03e7c71289c37a5cfa3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139458
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [fe87b2a2cccbc99d001705fdd8f8dc2e9997f211]

        vcl: Use GetGlyphWidth() when emitting system fonts
        
        Change-Id: I152afc51b771d09c8b1d7a220f4706afb9407337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139457
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [60fd694ac362e9314f54fa992e31e8baa5bdf80f]

        vcl: Add LogicalFontInstance::GetGlyphWidth()
        
        To be used it in PDF export where we need the unshaped glyph width to
        calculate PDF glyph adjustments.
        
        Getting the advances from HarfBuzz instead of reading them font the font
        makes sure we are always getting the correct values (e.g. when
        using variable fonts, though we still don’t correctly embed them in
        PDF).
        
        Change-Id: I91365a1580d3848c2f93044adcb366fd01173155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139462
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-06  Eike Rathke  <erack@redhat.com>  [06e547d069c7f8c5ced8edca86e698f6c5fafc15]

        Remove duplicated ScCharFlags setting in XL grammars
        
        Change-Id: I0055eeb38ce6de519695675a29f6efccae49612a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139482
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [6778f8ec5a3fed427ef97293d8e71333c511b613]

        fix and simplify opencl COMBIN()
        
        Change-Id: I7568e3bb55cab31eb6e9b8644019a465333e8091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139200
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Taichi Haradaguchi  <20001722@ymail.ne.jp>  [96db5e3d610ede2ed82f1ab7673ac6d1c69fd588]

        upgrade openssl-1.1.1q
        
        Change-Id: I2317e734f074cf7301a6081cf3d2221beeaf5ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a003f37b4d71a06f915858690d40c6f3c6fa1bc]

        tdf#150499: sc_uicalc: Add unittest
        
        Change-Id: Id2aae130c3b9ede1fe88893d035a37b82b0964f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139478
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-06  Eike Rathke  <erack@redhat.com>  [0ff4a77f337237a5cad1d44390ff924af3992ff8]

        Resolves: tdf#150307 Broadcast missing ScAreasChanged hint on sheet deletion
        
        ... and Undo.
        
        Change-Id: I59413d5470294c415c51e7d7ada9134f4173c872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139450
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  Tor Lillqvist  <tml@collabora.com>  [6566c01192f73c687fa12f1d5ca816ded879efbb]

        Replace leftover use of StarSymbol with OpenSymbol
        
        Change-Id: I2cfc88dfbdb0d5d4f296dea6f5b72122a0af7965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139476
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [c3fdac32fee3b342bb1d881a443748140af510b5]

        opencl MOD() fixes
        
        Change-Id: I72c588f714a49ef6ed33657dc30b41ee10ecd5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139199
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [8d687f4399ba2aa03126f00788664e9cd185147c]

        fix opencl FACT() implementation
        
        Change-Id: I5b4525268c574c9edff2f4e8361b2b6d234c50f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139198
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [20caaffa82f701ef52900f4504227f88320d227f]

        check parameter count in opencl logical functions
        
        Change-Id: If77bd146bd9eafd54afa1b82203d378ab9cd26d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139197
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [08b0c3b848b8f2bd667fad00068f3c828c709ef5]

        fixes to opencl rounding functions
        
        Change-Id: I5cd99116a7230b8070051cbf6969a1fdd2f7fe62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139196
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [65a082168ef5c2ff002f20a615b622816c3f4d3a]

        use opencl's built-in PI values instead of hardcoded ones
        
        Fixes a sc_subsequent_filters_test error because of =ACOT(-1)/PI()
        getting slightly miscalculated.
        
        Change-Id: I3846553cae55f463c34fba13663cad72c0e60b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139195
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [218b288d0ca32e4372f546b143fa71542f75dcd0]

        fix opencl trigonometric functions
        
        Change-Id: Iacdae9fceff2feb198bd722e7e58e5e6dff5facc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139194
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Luboš Luňák  <l.lunak@collabora.com>  [5aad29e382658aa93191ea4a4ff6cc9094ae12d4]

        add missing Calc test file opencl/compiler/precision.ods
        
        Should have been included in 35ed13eba1ceb6ddab8a9a72c5ef46ab3af .
        
        Change-Id: I3cf1a6b38e9893b5ec4ec4d6ffdfc4bf0ddba065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139477
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-06  Julien Nabet  <serval2412@yahoo.fr>  [3d1dc81b5e072862af17154b4f595fcaa4863d49]

        Simplify by using replace instead of replaceAt in loop in sc/compiler
        
        + replace ScCompiler::EnQuote which is used only once with its content at this adhoc location
        
        Change-Id: I7d72fd573ec9cea06d9b54e9381b4783756cf08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139452
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f972f27b455ef78f0d5db5eea96edd707909a154]

        tdf#118247 - Correctly handle xlCellTypeConstants parameter
        
        Change-Id: I5cc281d6193bcf03d2da3c594d427ec340c2cfc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139239
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-09-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [f2d7f2a28c4334feed4a12eb1553b8d0563c0fc9]

        tdf#150599: sc_filters_test: Add unittest
        
        Change-Id: Ibc6434b3505276343da0a36c52ab175aefc518ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139470
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [30a3f2b7343be07f10c8cbf7f4a9e90e16db806e]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I7bdc95f27f191e8315b1cd69114601df0c151124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Miklos Vajna  <vmiklos@collabora.com>  [cfc851da557214286685cde26baaac6be70d8624]

        crashtesting: fix DOCX export of forum-mso-en-11199.docx
        
        This went wrong in a4432eb0946c0bc775b3d30b634bef5d66544f8d (tdf#104823:
        support for sdt plain text fields, 2021-11-24), when we started to turn
        cell SDTs into a field containing the cell text, which now needs to work
        with redlining, even if the original DOCX file had no fields.
        
        The root cause was introduced earlier, in
        0c84c60f48cf681daf467c0678a768711f22e5c3 (tdf#77419 DOCX table import:
        ignore right white space, 2020-01-21), which assumed that goRight(2,
        select=false) is the opposite of goLeft(1, false) + goLeft(1, true),
        which is not true for input fields where an input field with 2 chars
        will select 5 chars (not 1) when you do goLeft(1, true) with a cursor at
        the right edge of the field (2 chars of content +
        CH_TXT_ATR_INPUTFIELDSTART + CH_TXT_ATR_INPUTFIELDEND + the field's
        dummy character itself), as "going left" selects the entire field, not
        just 1 character.
        
        Fix the problem by replacing goRight() with re-positioning the cursor
        the way it was positioned before trimming whitespace a few lines above.
        
        Change-Id: Iaae8878e9801df95d3bc7465d3e8ad12c724a888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139469
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-06  Julien Nabet  <serval2412@yahoo.fr>  [2cd787b0f4ef67e426c2e307a7dd157fdd803ed8]

        Rather use copy(1) instead of replaceAt(0, 1, u"")
        
        Change-Id: Ia4d6980a32a47eb9ddbe63e62468f7ff26ecd293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139454
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-06  Mike Kaganski  <mike.kaganski@collabora.com>  [e835b00dc46e3c06dc833c5d4a98c3f40bc98864]

        Deduplicate screen rect handling
        
        Change-Id: I5aacadff5ada74c6bc83ac698c87bca75e85ba0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139468
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-06  Miklos Vajna  <vmiklos@collabora.com>  [7dba3bd5d7ab98390a5dceb9956a3fbfe41f166d]

        CppunitTest_slideshow_engine: remove unused includes
        
        I forgot to clean these up when I started this suite.
        
        Change-Id: I17e31bfff82caa7def00328ca6086b32a999f344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139467
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [46159a67dd45a604a0197a26d177d6e9dce62d96]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I878f32139a82eab4a9f77673ebaadb1f1f1007f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a8c74efa2da18f16af4f395e46ee13bfdfa76cc]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: If16a9bd3f01afd57dbb44d80dd14a0f5f9bde9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-06  Stephan Bergmann  <sbergman@redhat.com>  [33ad73f3214d895f438d3e15c5099a4d878d5041]

        Missing initialization of PhysicalFontFace::mbFontCapabilitiesRead
        
        Regression introduced with 28c8cddd4218905bca05778dcdbae5911132a096 "vcl:
        Consolidate PhysicalFontFace::GetFontCapabilities()", causing
        
        > vcl/source/font/PhysicalFontFace.cxx:252:10: runtime error: load of value 190, which is not a valid value for type 'bool'
        >  #0 in vcl::font::PhysicalFontFace::GetFontCapabilities(vcl::FontCapabilities&) const at vcl/source/font/PhysicalFontFace.cxx:252:10
        >  #1 in FreeTypeTextRenderImpl::GetFontCapabilities(vcl::FontCapabilities&) const at vcl/unx/generic/gdi/freetypetextrender.cxx:83:46
        >  #2 in SvpSalGraphics::GetFontCapabilities(vcl::FontCapabilities&) const at vcl/headless/svptext.cxx:46:30
        >  #3 in OutputDevice::GetFontCapabilities(vcl::FontCapabilities&) const at vcl/source/outdev/font.cxx:262:24
        >  #4 in makeShortRepresentativeTextForSelectedFont(OutputDevice const&) at svtools/source/misc/sampletext.cxx:1255:22
        >  #5 in DrawPreview(FontMetric const&, Point const&, OutputDevice&, bool) at svtools/source/control/ctrlbox.cxx:634:27
        >  #6 in FontNameBox::CachePreview(unsigned long, Point*) at svtools/source/control/ctrlbox.cxx:785:9
        >  #7 in FontNameBox::UpdateHdl(Timer*) at svtools/source/control/ctrlbox.cxx:564:5
        >  #8 in FontNameBox::LinkStubUpdateHdl(void*, Timer*) at svtools/source/control/ctrlbox.cxx:562:1
        >  #9 in Link<Timer*, void>::Call(Timer*) const at include/tools/link.hxx:111:45
        
        during CppunitTest_toolkit_a11y.
        
        Change-Id: I3591c4722410a8c6d1ae539f71a3d8ac37a4d3a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139464
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-06  Miklos Vajna  <vmiklos@collabora.com>  [4cad1d6229309f8a06634686b295bca54aaecd56]

        sw: document SwSelPaintRects
        
        This was mostly about the cursor only, but nowadays hosts other overlays
        as well.
        
        Change-Id: I4c43592273e4b996c2d7ed915fa78bd15ea41f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139451
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-06  Khaled Hosny  <khaled@aliftype.com>  [e75631211b596df3997f6fe6eb5422b931bd0384]

        vcl: Create HFNT on WinFontFace when needed
        
        I’m seeing frequent CI failures with warnings like:
        
        warn:sfx.appl:13336:18148:sfx2/source/appl/app.cxx:147: No DDE-Service possible. Error: 16399
        warn:vcl:13336:18148:vcl/win/gdi/salvd.cxx:99: CreateCompatibleDC failed: There are no more files.
        
        Lets see if this is causing us to hit the GDI object limit.
        
        Change-Id: I1257ac7e701277814b5d17b40192ad3bc81a8e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139449
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-06  Radhey Parekh  <radhey.parekh@gmail.com>  [feb8d07333544ff2206489b786b7af30744d014a]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Ic9009eda963f922fc4d2e75a5002026eda63a7aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138686
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-06  Eike Rathke  <erack@redhat.com>  [540a312af2f02108ea90f5d2a9f3bf573db622e5]

        Related: tdf#150307 Use SfxHintId::ScAreasChanged, tdf#137577 follow-up
        
        ... instead of ScTablesRenamed, as ScAreasChanged (confusingly
        named) was meant exactly for this and also updates the Navigator.
        
        Change-Id: I6d90b82e6d5121e69c1a40af369be36544ad1b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139453
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-06  خالد حسني  <khaled@aliftype.com>  [47981aeb3a233a01a8b099d3fe2c3f5a8a9cfb7b]

        Revert "vcl: Add LogicalFontInstance::GetUnscaledGLyphWidth()"
        
        This reverts commit fa1835db77b38047d8c3cea7041d38762c329867.
        
        Reason for revert: merged too early
        
        Change-Id: I7dba2e8fcc06db59b2cbc211a0f4e7d1f209aa05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139428
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [875aff18fb58767e909664fb81510a8853ad32c8]

        cid#1500657 silence Resource leak
        
        it is pretty ugly stuff though
        
        Change-Id: Icf588f44807d136342de6d5425bc41b968fff97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139445
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [cb549e48a8b8e23a89b608f63d9452e5bec83be7]

        Resolves: tdf#150797 page preview scrolling not updating position
        
        Change-Id: I8b495d755278ce850d69da8b7fb8588a4f111bd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Miklos Vajna  <vmiklos@collabora.com>  [16ed6110313cae310799a82294fc566ce75855a4]

        sw XHTML import: fix lost empty paragraphs
        
        Plain HTML import ignores empty paragraph, because browsers ignore such
        paragraphs as well.
        
        This has the benefit of layout compatibility, but it breaks the
        semantics of documents when roundtripping them from Writer's document
        model to XHTML and back.
        
        Fix the problem by disabling this tweak for XHTML: the idea is that when
        it comes to paragraph / line breaks, XHTML is meant to preserve the
        semantics of the original document model, even if that results in slight
        differences in HTML rendering. So in case Writer/ODT doesn't collapse
        multiple line breaks and browsers/HTML does that, we apply workarounds
        in the HTML case, but not in the XHTML case.
        
        Change-Id: I55de8880503ee2d48fbd7a6af3891f2754f0d172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139439
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac9ae6fed0c237b27861b718686c2cc23fd1ba5e]

        Fix typo
        
        Change-Id: I9d6a047a38c9bb3155ffea55a242143f24f563cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139379
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [fa1835db77b38047d8c3cea7041d38762c329867]

        vcl: Add LogicalFontInstance::GetUnscaledGLyphWidth()
        
        To get glyph width in font units (i.e. scaled at font units per EM), and
        use it in PDF export.
        
        First step towards dropping SalGraphics::GetGlyphWidths().
        
        Change-Id: Ic0ef165e8aed6f94caf68bf01ef7ecc0620ce7c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139448
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [89b9982b27039f77fb9e27b92b02dc4e4bfb7be0]

        vcl: fontinstance.{cxx,hxx} -> LogicalFontInstance.{cxx,hxx}
        
        Every time I need this file, I had to lookup the file name and location.
        Rename it following the pattern of other font classes and move the
        header next to their headers.
        
        Change-Id: Ia1e3ee4be9375c1110e169c593e1f8e7aad39c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139446
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  jsala  <javier.salamanca.munoz@gmail.com>  [8dc57426c3bd3385c30b9007991af8496b315f9a]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Also change some integer by std::size_t
        
        Change-Id: Ia51b27bb99b8adda576394f9331345cb11149d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137274
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-05  dante  <dante19031999@gmail.com>  [9b7600f547cec9ed1bacca3a1b995b3c33fd5723]

        Connect new import / export to starmath
        
        See: https://gerrit.libreoffice.org/c/core/+/120753
        Change-Id: I9b02a4a7b4bc6c132220710573b7672b1a5b1c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134163
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  jsala  <javier.salamanca.munoz@gmail.com>  [35a7e40d372d3211061465346825cf543a095f6d]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Also change some integer by std::size_t
        
        Change-Id: I6a0fda3ba44815aac3312d523be04f4f973ce84f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137142
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [599158b6dcc45a7579f73f3d94f6956e00128bee]

        rework comment a bit
        
        Change-Id: I9dff73a7a3e0579af4b6fdeab669a8f99722e2f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139438
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Povilas Kanapickas  <povilas@radix.lt>  [d752cb42473547872741c74a70809f28f9fe789c]

        vcl: Rename LongPress event to GestureLongPress
        
        We have 5 gesture types: GestureZoom, GestureRotate, GesturePan,
        GestureSwipe and LongPress. For consistency all of these will use
        Gesture as a prefix to reduce confusion and for easier grepping
        throughout the codebase.
        
        Change-Id: I8b9e245d011203a19c1172f9833c172f65382cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139244
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Povilas Kanapickas  <povilas@radix.lt>  [35319adcc28f197b73e146f9ba233e20616fd11f]

        vcl: Rename Swipe event to GestureSwipe
        
        We have 5 gesture types: GestureZoom, GestureRotate, GesturePan, Swipe
        and LongPress. For consistency all of these will use Gesture as a prefix
        to reduce confusion and for easier grepping throughout the codebase.
        
        Change-Id: I8b9e245d011203a19c1172f9833c172f65382caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139243
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Povilas Kanapickas  <povilas@radix.lt>  [231342ef6a913f0a5c9dfea3bd28830e92a3fc98]

        vcl: Use #pragma once on GestureEventPan.hxx
        
        The header guard macro name no longer matches file name. Instead of
        updating, just use #pragma once.
        
        Change-Id: I2dfb3fc0d73f5de7f7b31c4b0fb9a3ba5f2966af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139242
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Povilas Kanapickas  <povilas@radix.lt>  [99b85a2eda006a59306042dad5b0b1de116febf3]

        vcl: Rename Gesture event to GesturePan
        
        We have 5 gesture types: GestureZoom, GestureRotate, Gesture (for
        panning), Swipe and LongPress. For consistency all of these will use
        Gesture as a prefix to reduce confusion and for easier grepping
        throughout the codebase.
        
        Change-Id: I8b9e245d011203a19c1172f9833c172f65382ca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139241
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [c8cc4c29369f3d5df22c0b9260c00816a7c891eb]

        Avoid dup in include/xmloff/families.hxx by renumbering a bit
        
        306 was used twice.
        The renumbering should be harmless, see message here:
        https://lists.freedesktop.org/archives/libreoffice/2022-September/089343.html
        
        Change-Id: I18b90b4302276d298202e6c2854d4aceb9a36e87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139355
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Chenxiong Qi  <qcxhome@gmail.com>  [9928f139e858768047b8dea0405720395beb18cd]

        tdf#97361 replace getCellByPosition with access by subscript
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I50d6e29c34e3cf72cdf0afc9f118fafc3c144eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Chenxiong Qi  <qcxhome@gmail.com>  [14cff82b314709db488d929b75c254fbb0355419]

        tdf#97361 replace getCellRangeByPosition with slices
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I4368adca1e9500c6f926ea1f28b0790b06fae739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [6b3e66cd7a355061bf1dec76bbc4f389b6b60f2d]

        tdf147132 basic : flaten some functions
        
        Change-Id: I462cbac4183f304e9f4b296a6361a05a4615c7eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [4059cb5dbec67d17a636b03e6f6344ca313516fa]

        tdf#150507 like skia, even when subpixel rendering snap to a pixel Baseline
        
        Change-Id: Iaf064b483d65d25251f733cc6a67d9f1863bb64c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  dante  <dante19031999@gmail.com>  [d2873a0510d620de06ac3d4d30aabc9ab73ffe21]

        Identify OOo2OasisTransformer and act in consequence
        
        Change-Id: I99950e6dd73822ef49f9d4ef1155a5722b748127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [f2a98e85948451a9540831e0090422f08b945560]

        BASIC : missing parameter check in SbRtl_CreateObject
        
        Change-Id: I44e8c17274e20eb080494b2eaf25f74d33a35b36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Jim Raykowski  <raykowj@gmail.com>  [26e33cb1fc7024d04b68569f904ffd8583aef1fb]

        tdf#117173 make search label read by screen reader
        
        Change-Id: I3ced9f5f3637e8489d0512b48882724a5a51b577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [de7fced095e32e0d1c003ebd25c0ec884508b27d]

        Simplify by using replaceAll instead of replaceAt in 2 loops in sw
        
        Change-Id: Ib33adfaf7e0d2f5caf530169fefcdfcba64bb758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139367
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [8be964f0386308a10d02ce4e214da29a77890507]

        Simplify by using replace instead of replaceAt in 2 loops in oox/sc
        
        I grouped these because one has a reference with the other
        
        Change-Id: I9bbd87951e2f945dfd20d54d16ea7d9291d74f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [afaa86e7e9a0a9effb28d46289805453f3806a74]

        Simplify by using replace instead of replaceAt in loop in fpicker
        
        Change-Id: Ibe601294bd55ac9a93a535b6acd092064fdad364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [273ddb469abade5505ea919de77d2a18bc35f0c9]

        Simplify by using replace instead of replaceAt in loop in editeng
        
        Change-Id: I7eb974a4adab74a93a10ff08c8853fbb5ae88885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139372
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Julien Nabet  <serval2412@yahoo.fr>  [8364ed3d2f927c6bdb874baff96e0affcc20977b]

        Simplify by using replace instead of replaceAt in 2 loops in reportdesign
        
        It required to fix loplugin:stringviewparam error during build
        
        Change-Id: I0111ea5001d18df2913aaa9c154371a86ae7f3bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [90b4e348114cc9d060ce056690858c4849ed8b2e]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I9f41fcd023c90c9611fc38ae8961984900108422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff1c83c194aad9dd162c173efe3ca8e6183fbda5]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ia6d178ff639369d9e7bd4585ab48978e913f23c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee003ca99f94c9a5517ebba67ed02abb2a60dae8]

        add InsertText and EraseText overloads that take SwPosition
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I7affb1ee002869ea3ed8c7da0c79b1a3750e5c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [a740176009411d21e20d7c11097af1d8812d251d]

        tdf#150749 Find and replace on very large sheet
        
        This requires 2 fixes
        
        (*) First, we are deleting from the front of a block in the mdds
        storage, so apply a similar patch to mdds to the previous improvement,
        
        (*) Then, we end up with an O(n^2) situation in ScRangesList::Join.
        But we are only displaying this data, and in fact, we only display the
        first 1000 ranges anyway, so just clamp the list to 1000 entries, and
        pass a flag up to the dialog so that we can report that we stopped
        counting.
        
        (*) I had to tweak the testSharedStringPool unit test, since
        we are not actually clearing the underlying mdds storage, the
        reference counts do not drop until we have removed all the
        elements in that block of mdds storage (because then the entire
        block is destructed, including the not-yet destructed elements)
        
        Change-Id: I2c998f81dfb46453a48fce1254fd253d299d12b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b8bc6dc6b5b956d2cf3294f78a7ea2d24eaf561]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ie9cd58e276670875a73521b0f703fda78ae93efa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Miklos Vajna  <vmiklos@collabora.com>  [b9da26fac9cd17cff0ed56327fade37f5105d500]

        offapi: document com.sun.star.text.ContentControl
        
        It has a lot of properties and what's inside ListItems was also rather
        unclear.
        
        Change-Id: Iaef719d72b95374da6d0dfa8247870fa5f76d18d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139406
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [11999e2114040ba165da29ca6811d8e09e735413]

        dbaccess::DataSupplier doesn't need a pimpl
        
        it is module private
        
        Change-Id: I6d1479872e715d081030601b88ad4be38ab0f011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [5291c2a2238829bb6e1854dc24b6fc6662b8e5e2]

        cid#1500642 silence Dereference before null check
        
        Change-Id: If72495279b7fedd2e825ca6944fc822d80ad5f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [a89b1884273a3bde1a38cd92148a09cdf1c3a058]

        cid#1513509 Dereference after null check
        
        Change-Id: Ic325193e138175706b43a3f02a4a4cc2f84e75ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139404
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [8d92140e10e3e05bdb0aa05eb7bfdbb68029aa7e]

        cid#1513507 Dereference before null check
        
        and
        
        cid#1513511 Dereference before null check
        
        Change-Id: I58ec1fda9763c763c0e9cfbeeff4c623469c2135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139403
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [a80a7e286481ea668d33cdf9fcbf45d02fb10915]

        OSaveAsDlg doesn't need a pimpl
        
        it is module private
        
        Change-Id: Ib1eb6ddbbfc181b72e4a69a211b27c901e59affd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Chenxiong Qi  <qcxhome@gmail.com>  [26e3bfa02c4d582fd430171d509fa570ca364d35]

        tdf#73845 restore Empty and NonEmpty query filter after FILEOPEN
        
        Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
        Change-Id: I659e0d97c44bf189f457ca04eb49248121278c10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138919
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-05  Caolán McNamara  <caolanm@redhat.com>  [fbc871f642e22e7f4115de78712b99fbb8e8b53a]

        cid#1513506 Unintended sign extension
        
        and
        
        cid#1513508 Unintentional integer overflow
        cid#1513510 Unintentional integer overflow
        cid#1513512 Unintentional integer overflow
        
        fallout from:
        commit 206543c7bef58fc559852553a3b2faba0b604259
        Date:   Fri Sep 2 13:06:08 2022 +0200
        
            [API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit
        
        Change-Id: I98c025e3309b775a3c809d93a8e133bbcd9fb4df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139402
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-05  andreasma  <maand@gmx.de>  [4063dcdc7305177b167bd20b009b1dfede8b25ec]

        Revert naming back to lool to fix break with LibreOffice Online
        
        Reverts the commit https://gerrit.libreoffice.org/c/core/+/132204
        
        Signed-off-by: andreasma <maand@gmx.de>
        Change-Id: Icaf672038777a23c9901e6c3f9f52930157050e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138884
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-05  Miklos Vajna  <vmiklos@collabora.com>  [c8d41a03d478935b481aba27915601972468caea]

        offapi: document com.sun.star.text.LineBreak
        
        It's an XTextContent and also document the possible values of the Clear
        property.
        
        Change-Id: Ic1c338e4461ceea75cf16ce896e98e732d9af859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139397
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-05  Sarper Akdemir  <sarper.akdemir@collabora.com>  [2b902b6203a87bdca7856e17a9c0fcc403de4264]

        tdf#149670 fix color change api and adjust tolerance for ooxml
        
        It appears at the start of Graphic::colorChange aBmpColorFrom &
        aBmpColorTo gets initialized with wrong colors. Instead of {R,G,B},
        they get initialized with {B,G,R}.
        
        Instead of bitshifting use the ::Color constructor so that it is
        initialized correctly.
        
        For ooxml import adapt tolerance values of the image format in an
        attempt to get similar results on how the results appear in
        PowerPoint.
        
        Change-Id: I1fa901691512de82936dba0e47158b7e0ca2223e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139203
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-05  offtkp  <parisoplop@gmail.com>  [f438fd7e25254db8f501b86cdf37970194897e8f]

        Remove code duplication in GraphicDescriptor for SVM
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for SVM files
        
        Change-Id: I459ac1a3301ba8a4d423620c0c6977272fdbb384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138740
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-05  offtkp  <parisoplop@gmail.com>  [2d27ce875546f19054a8ba39a87fb07a5337216d]

        Remove code duplication in GraphicDescriptor for TIF
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for TIF files
        
        Change-Id: Ia55b1606df5171dc41d94d19262a83910bd024a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138730
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [28c8cddd4218905bca05778dcdbae5911132a096]

        vcl: Consolidate PhysicalFontFace::GetFontCapabilities()
        
        All subclasses are doing the same thing in slightly different ways, so
        move it to the base class that we can now access font tables there.
        
        Change-Id: I1f8827dbc345aa852e1f7aaaa4cb4615593289c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139395
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [8b9e7617e967c4033d9853e6bc2e96334bf6b243]

        tdf#150756 Assertion when opening report for editing
        
        Change-Id: I59cbbc63175a95568f9a0390ab618a5f32d6488b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139331
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Miklos Vajna  <vmiklos@collabora.com>  [dcd08af1808d7984f32d4156c06e4d6c6c25560e]

        sw: prefix members of SwChangeDBDlg, SwEditRegionDlg, SwLabFormatPage ...
        
        ... and SwLabPage
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic3208b78883e4926bd7bde836b1cf4b51c8a02e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139396
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [08b923efcb22bae08c799ccc654797076468fa83]

        DataSourceMetaData doesn't need a pimpl
        
        it is module private
        
        Change-Id: Ib0817d7964e603157a9369d3ef0685e2b79f0aa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [90f3182141d37407715254d5118aae907d559b41]

        HierarchicalNameCheck doesn't need a pimpl
        
        already module private≈
        
        Change-Id: Id5ea44b88c5cd6776d41fc71ac6c5fa4d639aab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139366
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [5f194a2705449698a4760982913fc2592720be6b]

        DynamicTableOrQueryNameCheck doesn't need a pimpl
        
        it is already module private
        
        Change-Id: I7830730161393c70e29670500c475fa3c6027435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [f69971ac3a0aa25e6302d9e6f81fa757612085cb]

        ObjectNameApproval doesn't need a pimpl
        
        it is already module private
        
        Change-Id: Ic597fa86ee83a5d22d88c29befc3d54ea6eaecf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [dd39a3b25af74511c108d4f71302b15fd9942e21]

        RowSet doesn't need a pimpl
        
        it is module internal
        
        Change-Id: I906c579c9303ae7e770559ee37c8bb253738d1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139363
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [18ea40107ae3b44b1fa5c3d44cb9d5cf1da7d80f]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Iaa316112fedfe3b28f1cd302917bb49a9f125282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Noel Grandin  <noelgrandin@gmail.com>  [1dd58b8bc136b6867fbcea5adbfdc82ff685f129]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ib9012888a7d75e75a9301ac612349ed28d02a8a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139359
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [262df14af32be6855b276dcf7548d3b233076ec6]

        vcl: Format PhysicalFontFace.{cxx,hxx}
        
        They are small files, lets format before adding more code.
        
        Change-Id: I5e8e7e4031f045cf6e124dd533e37ab67f34e985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139394
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [0e2b9be640118cde6bb8dc1350cb619000969683]

        vcl: Don’t parse cmap in PrintFontManager::getGlyphWidths()
        
        Use PhysicalFontFace::GetFontCharMap() instead which has already parsed
        the cmap table.
        
        Change-Id: Ieba7bace65c9c5d85ffb8feb04e99cd826d7ab48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139341
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [ca7d6be2d64a48e61db7a1c614d6325151817f59]

        vcl: Consolidate PhysicalFontFace::GetFontCharMap()
        
        All subclasses are doing the same thing in slightly different ways, so
        move it to the base class that we can now access font tables there.
        
        Also drop unused PhysicalFontFace::HasChar().
        
        Change-Id: I77022b4dc3688de2788c18966f39f407a6abb730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139340
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-05  Khaled Hosny  <khaled@aliftype.com>  [8f9638424f7f88c99ff16a8015ca343f3042b26d]

        vcl: make WinFontFace less indirect
        
        Create the associated HFONT right from the start and avoid the
        UpdateFromDC() dance. We want to be able to get table data at any point
        after the face is created, and for this we need a HDC with the right
        HFONT set on it.
        
        Change-Id: Ie1f8a5afa03e0eae49f51359ebb0dbd732269c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139375
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [f9547d335f93142c9db08b050a12b97fa7c43dc8]

        Fix comment of EnQuote function in sc/compiler
        
        Change-Id: I706cf665745fc6d0b58a6e69b0a8a918ad0d062f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139374
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-09-04  jsala  <javier.salamanca.munoz@gmail.com>  [9e7e95a57b7c16941d9fdc59f806c1f9e4263379]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change associated for by std::find_if in sqlbison.y
        Also change some integer by std::size_t
        
        Change-Id: I0d2100fbd7c22729da6ce0462c6cc093e0767fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136263
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [42d197ef301db68e56f7e45b6e36ace5fae04b4d]

        tdf#150773: Avoid bringing loading files to front several times
        
        The change attempts to establish this logic:
        1. Honor the ForceFocusAndToFront setting uniformly: previously, it
           was ignored when reusing existing windows (opening in Start Center,
           in place of an empty document, or trying to open an already opened
           document);
        2. When ForceFocusAndToFront is set, try to activate the window as
           early as possible (before loading begind), as a feedback to user,
           and also to avoid situations when activation would be impossible
           later (e.g., there is a timespan on Windows, during which entitled
           applications can bring themselves to foreground; a lengthy loading
           process can exceed that time);
        3. If activated once, do not activate second time after loading ends,
           to avoid nagging users who deliberately switched to other tasks.
        
        Explicit calls to impl_makeFrameWindowVisible were removed from
        impl_searchAlreadyLoaded and impl_isFrameAlreadyUsedForLoading,
        because those functions are called from impl_loadContent, which makes
        sure that they are followed by a call to impl_makeFrameWindowVisible
        (either in impl_setResult -> impl_reactForLoadingState, or directly).
        
        A fix to tdf#83773 was adjusted; I checked that the bug doesn't
        reappear after that.
        
        Change-Id: I4bdcf978d43016d1e8979adf2fdf108a37f6ba2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139362
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [d0d6e43f9f9894f65a18f22a28ed0d8c0dbd2b61]

        Fix comment, formulabase.cxx has been moved in sc/source/filter/oox since 2012
        
        (precisely since 8ada1cd2846e5e60ad63250c68ddea3a9356546f)
        
        Change-Id: I0be868233325ab5b92e35af14c3d9f77ee3edecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139368
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [884088de799c2c6947b72eb38cf2e7dbc46a1867]

        Simplify by using replaceAll in a loop (sc/AccessibleCell.cxx)
        
        Change-Id: I320f9631fb7c8c6d0c34fde1ad6c7b9479aa57db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139357
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [8926e891f9865f3857cfc00ccab1adce9077dd4c]

        Simplify by using replace instead of replaceAt in 2 loops in connectivity
        
        Change-Id: Ia89ab8131be9cda8b5365fa41769a32409c35a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139358
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-04  Mike Kaganski  <mike.kaganski@collabora.com>  [f0fbf30a9c9dab41fce10f3ad4bfc83434122c70]

        Some refactor
        
        Change-Id: I5b87f9298bfeec70848654eacf5086803c19080a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139354
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [25436ac4de0e08c41463fe0239f2614453d3057f]

        Simplify by using replace instead of replaceAt in loop (sc/navipi/content.cxx)
        
        Change-Id: If0daf975928ef90e83152f71d24ece3a5c7cfac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139356
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-04  Julien Nabet  <serval2412@yahoo.fr>  [c41020e73b5177263c393a57a37425f3da63b43f]

        Fix "invalid cast from 'GtkImage' to 'GtkLabel'" warning (sparkline)
        
        Change-Id: I7353d4f263925706917b284863cb8dcd0e5f4b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139333
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-04  Noel Grandin  <noelgrandin@gmail.com>  [3438939b831f555301305ace110e734bc02078fc]

        the mode parameter to MergeTable is unused
        
        and has been since initial import
        
        Change-Id: I0bf75a001e4d4b17729f3810210b8db295480697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-04  Justin Luth  <jluth@mail.com>  [449317473740d98338a61aca1e4ffb8821681c8e]

        tdf#117994 doc: Revert "tdf#99474 close direct char fmt at end of para"
        
        This reverts 5.1.4 commit 817c3b17fa57a7c4c4f80569bc00a21001fb6807
        which fixes regression bug 17994 (in the summary line).
        
        Another reason for reverting it is tdf#150613
        whose fix depends on getting this fixed first.
        
        Making any export changes based on the formatting of numbering
        is extremely dangerous, especially in this time period after LO 4.1
        when a wonky patch made wild assumptions about what was best.
        Well, that patch was reverted in LO 7.3 for tdf#108518,
        and apparently obsoletes the usefulness this patch provided..
        
        This patch that I'm reverting caused some visible regressions
        SEEN ONLY IN WORD which further confirms that we
        still have lots of wrong assumptions in regards
        to numbering formatting.
        
        I'm happy to see it reverts without causing any unit test failures
        even before I make any changes.
        
        I confirmed that reverting the 4.1 patch with
        7.3 commit 343d4d32f00053bd72cfe240125835fe25ce264f
        was what allowed testTdf99474 to still pass.
        
        Change-Id: I4cf6fbfb3a4a2d483d9a500f13686ad4305742b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139334
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-09-04  Khaled Hosny  <khaled@aliftype.com>  [dc92a4d973086ce8a6a5f75ba0f4d4c9ca05537a]

        vcl: Create hb_face_t in PhysicalFontFace
        
        The two map to each other, and we want to access hb_face_t to provide
        some functionality scattered currently in platform-specific
        implementations.
        
        Change-Id: Ib3842752ec240b8254db828dba95a6a0ad65f16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139275
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-04  Khaled Hosny  <khaled@aliftype.com>  [b87f4dfd33b48bb2f6cec9732ace51f2a272308d]

        vcl: Align GenPspGraphics and FreeTypeTextRenderImpl more
        
        They share lots of code with few small differences, reduce these
        differences and de-duplicate more of the shared code.
        
        The main motivation is to make sure FreetypeFontFace is always created
        with a non-NULL FreetypeFontInfo.
        
        Change-Id: I6f36f5975908d52033fe959cfe2b265c79ebe190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139280
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-03  Michael Weghorn  <m.weghorn@posteo.de>  [dd5f021e08b0f6da1b5330c37db4c759e35941c6]

        tdf#150683 gtk3 a11y: Expose AtkTableCell interface for cells
        
        While LO doesn't have any UNO a11y interface
        for table cells, the methods for the `AtkTableCell`
        interface can be implemented by using the methods
        from the `XAccessibleTable` interface of the table
        (which is the parent of the cell), similar to
        the way this was impemented for winaccessibility
        and the qt5/qt6/kf5 VCL plugins in
        
            commit 97a88e30e2e084ab860635ff4e0a03442d8a12af
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Sep 8 14:37:53 2021 +0100
        
                tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell
        
        and
        
            commit 6735a37747a3443ebd1c29c870a5eb26990350f2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Sep 21 14:47:51 2021 +0200
        
                qt5 a11y: Implement QAccessibleTableCellInterface
        
        With this and the Orca commit to make use of the AT-SPI
        TableCell interface to query the position for a cell [1],
        announcing selected cells that have a cell/child index
        that doesn't fit into 32 bit now also works for the
        gtk3 VCL plugin, see the full commit message of
        
            commit 206543c7bef58fc559852553a3b2faba0b604259
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Sep 2 13:06:08 2022 +0200
        
                [API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit
        
        for more background information.
        
        In a quick test with Accerciser and the gtk3 VCL plugin
        as follows, the output looked as expected:
        
        1) start LO Writer, "Table" -> "Insert Table"
        2) select to create table with  2 rows, 2 columns
        3) make sure "Heading" is checked, "Heading rows": 1
        4) "Insert"
        5) in the first row, type "First heading" into first column,
           "Second heading" into second column
        5) start Accerciser
        7) select the table cell element "A2" in Accerciser's treeview of the a11y
           hierarchy (which refers to the table cell in the second row, first column)
        8) type these in Accerciser's IPython console:
        
            In [1]: acc.queryTableCell()
            Out[1]: <pyatspi.tablecell.TableCell at 0x7fa17cf2b550>
            In [2]: acc.queryTableCell().position
            Out[2]: (1, row=1, column=0)
            In [3]: acc.queryTableCell().rowSpan
            Out[3]: 1
            In [4]: acc.queryTableCell().columnSpan
            Out[4]: 1
            In [5]: acc.queryTableCell().get_table()
            Out[5]: <Atspi.Accessible object at 0x7fa17cf975c0 (AtspiAccessible at 0x55bfe77b4e10)>
            In [6]: acc.queryTableCell().get_table().name
            Out[6]: 'Table1-1'
            In [7]: acc.queryTableCell().get_columnHeaderCells()[0]
            Out[7]: <Atspi.Accessible object at 0x7fa17d2e7b00 (AtspiAccessible at 0x55bfe77ab240)>
            In [8]: acc.queryTableCell().get_columnHeaderCells()[0].name
            Out[8]: 'A1'
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/commit/cb105d4d21c09d3e832273b493a407e8b48887fb
        
        Change-Id: Ia6ee90bea5c2f2faef6ed269981702f36496a3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139278
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-03  Julien Nabet  <serval2412@yahoo.fr>  [318e8578fa5816070610f83b752b6dc5c1697f93]

        Simplify by using replaceAll in a loop (sw/access/acccell)
        
        Change-Id: Iab310d0f0395fe36ee0db6ac5d242518b33516aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Julien Nabet  <serval2412@yahoo.fr>  [871f5e60047002238df907f4b9406bf205cf16fa]

        Simplify by using replaceAll instead of replaceAt in a loop
        
        Change-Id: I019d93a0937be6402c9749b72595354cf4b09b7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139281
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Aleksa Savic  <aleksasavicposao@gmail.com>  [519dae19abddaedaf0d3d109186eeb4a08471a92]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: Id0d772f796e1599322c74604ca19492d1f8ed426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139257
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [8b7b7a2b2048127128cd4010b9c93bc50ac28951]

        crashtesting: assert seen on loading forum-fr-40118.ods
        
        Change-Id: Ib84e07d0e22b30ac32eba21a849b2f7fd0739b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [f2762465eb8ccbad74acf07afca3358a5ab3e1c1]

        don't check that the shadow positions map back to source mapmode integers
        
        because they are fake positions created by the pdf export and not from
        the source application
        
        Change-Id: Ieeb1b835123a5302ebbb35902b29ebe77ef5fe27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [f137a42cc4979bf5bfcdcc23217f27f39556b41b]

        crashtesting: fix use-after-free
        
        seen on exporting forum-mso-de-77310.pptx to ppt
        
        presumbly since:
        
        commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
        Date:   Thu May 27 10:27:46 2021 +0200
        
            ref-count SdrObject
        
        Change-Id: I883ecb8b39c95550673c51e086dcf3058588f9e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [8c896f7405f77f96e7204fef9e9fa0fc7d48fe15]

        crashtesting: SdrMediaObj destroyed before ctor completes
        
        fix similar to SdrOle2Obj ctor
        
        seen on loading ooo88783-2.sxi
        
        presumably since:
        
        commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
        Date:   Thu May 27 10:27:46 2021 +0200
        
            ref-count SdrObject
        
        Change-Id: I06acecec81632f4e15f5e80384bb90154a54c9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139324
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [9699f6e2aa13cd82d96740d96d8f9bf7637b68fe]

        crashtesting: assert on loading ooo57561-1.sxi
        
        presumably a problem since:
        
        commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
        Date:   Thu May 27 10:27:46 2021 +0200
        
            ref-count SdrObject
        
        Change-Id: Id3c42d229f72d7b4f764e75cf13a193585d6fd76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139316
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [3554e6d92b9045e6dd9881e294c3306dc08aeac9]

        cid#1509261 Dereference after null check
        
        Change-Id: I74cf3eed734bc09abdbca455d9a762b5aeb02481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Caolán McNamara  <caolanm@redhat.com>  [d81ab079a01f1080506fd61194f5eb2642f3c692]

        cid#1513476 Useless call
        
        Change-Id: Ia1f50e7e78101ac588a9dea33ef9c05ddca58469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f3ee33c8e3400d4d53d4a06c6765d78eeb6b9a0e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d08951af8c17d621ed2787a8c68738add6d151c
          - tdf#150445 remaining references of "gear" in menus/toolbars
            
            Change-Id: If47eb4b4987a48fddf9a2ffb1d4bcc7bdae76d53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139295
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-03  Noel Grandin  <noelgrandin@gmail.com>  [4aa464f4634faa62499e6ff5737a647dc80d68cc]

        no need to use unique_ptr for this map in XMLRedlineExport
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: Id555367e9a3e44f60295b8296aadabb9c1681e6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [4060230ca5124f7bdd658f2aa5ee5527375edb86]

        gtk3_kde: Drop unused gtk3_kde5_a11y.cxx
        
        The file just has includes of gtk3's a11y
        source files, but those are also separately included
        in equivalents in `vcl/unx/gtk3_kde5/a11y/`, and the
        latter are actually used in the Makefile
        `vcl/Library_vclplug_gtk3_kde5.mk`.
        `vcl/unx/gtk3_kde5/gtk3_kde5_a11y.cxx` however is unused,
        so drop it.
        
        Change-Id: Ibca1bc30b8591177b3dd660dd245a6a77bd05271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139276
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [cafe239cbb94e3f6d24120fa31e52241bb8bac87]

        no need to use unique_ptr for this map in ScMyStylesMap
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: I29cceec51b1c09bf97eb428d363ad5143f28d902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Eike Rathke  <erack@redhat.com>  [c23c209a063273fda0670203bfbe3bf8ed6eb249]

        Resolves: tdf#150271 Further error checks of conditional formatting expression
        
        i.e. an obviously wrong or incomplete expression as far as the
        formula compiler can detect it sets the input field's error state,
        unless it's an unrecognized name that still displays the unquoted
        string warning.
        
        Change-Id: I54b5e32a1848acec246215a76cb19ec597630ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139269
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [7d5beaabeac4e474512337b086690257daeefc96]

        no need to use unique_ptr for this map in sc::FormulaGroupAreaListener
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: If9bc02d702fd5ba9994e606744b63494fbe20edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139237
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Caolán McNamara  <caolanm@redhat.com>  [a3b1c886227af1b117783bc569d32675441cd3fd]

        ofz#39186 reduce htmlfuzzer len to hasten closure of Timeout state
        
        restrict this to a very short length to reset ofz Timeout to force
        ofz to report a new issue when restored later. Bump up the sc-rtf
        one.
        
        Change-Id: Ida1a12f4833cef50a1fb8b7bb4c47f85f3fc155e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-02  Caolán McNamara  <caolanm@redhat.com>  [bcbd23e66a00567d17f8651975803b2c213bcb75]

        ofz#504464 scaling "calculation" timeout
        
        just skip this uninteresting branch
        
        Change-Id: Ida695cccdee8a44b7c2ec089bba8ad95e35c113e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-02  Caolán McNamara  <caolanm@redhat.com>  [5ad33bf93ca718bc4f33b4e7cf5693d7d6983cc5]

        Revert "ofz#48264 Timeout"
        
        This reverts commit d4eee72ea39f02ad8a63a592feb3553771bf9bbe.
        
        and all the related timeout improvement efforts and return to its
        original state, more trouble than its worth
        
        Change-Id: I5c4951ae225fe5e27a1b969cdaade3dd7ba3ce2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139266
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81a7c2543e04eb6792fccece01f514bf653a5ad0]

        Removed duplicated include
        
        Change-Id: If31e5046dcdf02c842a6f2c2b4dc281f1f5573b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139263
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c4f638b439d486d37479229a5edd99fba77aa36]

        Fix typo
        
        Change-Id: I562d9795efb48db690c0425a6f7048d10845ac45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139215
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-02  Eike Rathke  <erack@redhat.com>  [071fc970cd1deb326a30b667bd26c843890d97ad]

        Related: tdf#150271 Adjust unquoted string message to reality
        
        Change-Id: I9aa6a6420c0ab2b93331046845015c5cde7cfc90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139260
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-02  Stephan Bergmann  <sbergman@redhat.com>  [4f1aeeb06cbbe32dff49038e01d05a90d1c600e2]

        Set EXTRA_ENV_VARS with +=
        
        There's only this single setting right now, but there could be more (see e.g.
        the commits leading up to 5aa8e7ef07229d48cb719a5f3f01c9a7fa445554 "Fix setting
        SAL_NON_APPLICATION_FONT_USE"), so make sure they wouldn't accidentally
        overwrite each other.
        
        Change-Id: I08746dee491e0b04c32e0897bec0fa8966065279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139262
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [02dc0a8b3e641c3e081b1a167b6570a93f313a95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 54f3eaba5c786a531fd2839646d517b97b279127
          - Menu & dialog item updates
            
            Change-Id: I4a789ee68139f5d270d93e88393cd1ed443f5862
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138990
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [d92ad32c98c6a094195e10f066968eb60105dff1]

        tdf#150683 sc a11y: Add a test case for 64-bit a11y cell index
        
        Add a simple test case that retrieves the a11y object
        for the Calc cell in the last row, last column and
        uses its child index to retrieve the row and column
        number via the corresponding `XAccessibleTable`
        methods again.
        
        Before changing a11y child indices to 64 bit
        (s. Change-Id I3af590c988b0e6754fc72545918412f39e8fea07,
        "[API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit"),
        integer overflows would result in the a11y object
        getting a negative child index and an
        `IndexOutOfBoundsException` would be thrown
        when trying to use that to get the row and column
        using that.
        
        Change-Id: I41bfc0507bd57c3a21ad330638714508855055b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139259
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [206543c7bef58fc559852553a3b2faba0b604259]

        [API CHANGE] tdf#150683 a11y: Switch a11y child index to 64 bit
        
        With 16k column support in Calc enabled by default in
        
            commit 4c5f8ccf0a2320432b8fe91add1dcadf54d9fd58
            Date:   Tue Mar 8 12:44:49 2022 +0100
        
                change default Calc number of columns to 16384 (tdf#50916)
        
        , the number of Calc cells in a spreadsheet is larger than
        SAL_MAX_INT32, meaning that a 32-bit a11y child index is no more
        enough and using it resulted in integer overflows in
        methods handling corresponding Calc cells in the a11y layer.
        This e.g. had the effect of the Orca and NVDA screen readers
        not announcing focused or selected cells properly when their
        a11y child index was out of the 32-bit integer range.
        
        Switch the internal a11y child indices to 64 bit to
        be able to handle this properly internally.
        
        Since the platform APIs (at least AT-SPI on Linux and
        IAccessible2 on Windows; from what I can see LO's macOS
        a11y bridge doesn't directly expose the child index)
        are still restricted to 32 bit, larger child indices
        still cannot be exposed via the platform APIs.
        
        As a consequence, use of the the IAccessible2 and
        AT-SPI methods that use the child index remains
        problematic in those cases where the child index
        is larger. However, as an alternative to using the
        AT-SPI Table interface and the IAccessibleTable/
        IAccessibleTable2 interfaces with the child index
        to retrieve information about a specific cell,
        both AT-SPI and IAccessible2 also provide interfaces
        to retrieve that information directly
        from the cell object (TableCell interface for AT-SPI,
        IAccessibleTableCell for IAccessible2).
        
        Those interfaces are already implemented/exposed
        for winaccessibility (s. `CAccTable`) and the
        qt5/qt6/kf5 VCL plugins (s. the `QAccessibleTableCellInterface`
        methods implemented in `QtAccessibleInterface`).
        With the switch to 64-bit internal a11y child indices,
        these now behave correctly for cells with a child
        index that doesn't fit into 32 bit as well.
        
        NVDA on Windows already uses the IAccessibleTableCell
        interface and thus announcing focused cells works fine
        with this change in place.
        
        Orca on Linux currently doesn't make use of the AT-SPI
        TableCell interface yet, but with a suggested change to
        do so [1], announcement of selected cells works
        with the qt6 VCL plugin with a current qtbase dev branch
        as well - when combined with the suggested changes
        to implement support for the AT-SPI TableCell interface
        in Qt [2] [3] and the LO change based on that [4] and
        a fix for a nullptr dereference [5].
        
        The gtk3 VCL plugin doesn't expose the AT-SPI
        TableCell interface yet, but once it does so
        (via `AtkTableCell`), it also works with the
        suggested Orca change [1] in place.
        (Adding that is planned for an upcoming change,
        works with a local WIP patch.)
        
        For handling return values that are larger than what
        platform APIs support, the following approach has
        been chosen for now:
        
        1) When the return value is for the count of
        (selected) children, the maximum value N
        supported by the platform API is returned.
        (This is what `ScAccessibleTableBase::getAccessibleChildCount`
        did previously.)
        The first N elements can be accessed by their
        actual (selection) indices.
        
        2) When the return value is the child/cell index,
        -2 is returned for objects whose index is greater
        than the maximum value supported by the platform
        API.
        Using a non-negative value would mean that the
        index would refer to *another* actually existing
        child. A child index of -1 on the other hand
        tends to be interpreted as "child is invalid" or
        "object isn't actually a child of its (previous)
        parent any more)". For the Orca case, this would
        result in objects with a child index of -1
        not being announced, as they are considered
        "zombies" [6].
        
        What's still somewhat problematic is the case where
        more than 2^31 children are *selected*, since access
        to those children still happens by the index into
        the selection in the platform APIs, and not all
        selected items are accessible this way.
        (Screen readers usually just retrieve
        the first and last element from the selection and
        announce those.)
        
        Orca already seems to apply different handling for the
        case for fully selected rows and columns, so
        "All cells selected" or "Columns ... to ... selected"
        is announced just fine even if more than 2^31
        cells are selected.
        
        (Side note: While Microsoft User Interface
        Automation - UIA - also uses 32-bit indices, it also
        has specific methods in the ISelectionProvider2
        interface that allow to explicitly retrieve the
        first and last selected item,
        `ISelectionProvider2::get_FirstSelectedItem` and
        `ISelectionProvider2::get_LastSelectedItem`, but
        we currently don't support UIA on Windows.)
        
        Bound checks at the beginning of the methods from the
        `XAccessibleContext`, `XAccessibleSelection` and
        `XAccessibleTable` interfaces that take a child index
        (or in helper methods called by those) should generally
        already prevent too large indices from being passed to
        the methods in the lower layer code that take smaller
        integer types. Such bound checking has been
        been added in various places where it wasn't present yet.
        If there any remaining issues of this
        kind that show after this commit, they can probably be
        solved in a similar way (s.e.g. the change to
        `AccessibleBrowseBox::getAccessibleChild` in this
        commit).
        A few asserts were also added at
        places where my understanding is that values shouldn't
        be larger than what is supported by a called method
        anyway.
        
        A test case will be added in a following change.
        
        [1] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/131
        [2] https://codereview.qt-project.org/c/qt/qtbase/+/428566
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/428567
        [4] https://gerrit.libreoffice.org/c/core/+/138750
        [5] https://codereview.qt-project.org/c/qt/qtbase/+/430157
        [6] https://gitlab.gnome.org/GNOME/orca/-/blob/82c8542002e36e0d3d918088d583162d25136143/src/orca/script_utilities.py#L5155
        
        Change-Id: I3af590c988b0e6754fc72545918412f39e8fea07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139258
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-02  Miklos Vajna  <vmiklos@collabora.com>  [38671e21d7dbcd5019912b9468305018de0c922e]

        Related: tdf#149969 PPTX export: add loop from the animation of a media shape
        
        The PPTX import maps media nodes to XAudio nodes, but the export side in
        PPTXAnimationExport::WriteAnimationNodeAudio() only handled audio, not
        video.
        
        This is fine, that code was added for audio narration purposes, but the
        same animation handles looping for videos, so this needs extending.
        
        Fix the problem by exporting <p:audio> conditionally and write video
        markup (especially info about repeat count) when the content of the
        media shape is video, not audio.
        
        Change-Id: Iba6bb4901b984c4363023f05232efc06ff069022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139261
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-02  László Németh  <nemeth@numbertext.org>  [412e0ab26618c38f548c340f85ef63bbe73ef6b2]

        tdf#150717 sw RDF metadata: add custom color bookmark boundary marks
        
        Bookmark boundary marks applied a single color for all bookmarks
        with metadata. For visualization of metadata categories e.g.
        for quick verification of automatic annotation, add RDF-based
        custom color bookmark boundary marks, using LO_EXT_SHADING
        feature added by commit a8a9b4f4635bff3f1b7ec63b62f661bc15196cd6
        "tdf#142448 sw offapi: add custom color metadata field shading".
        
        Show all colors of overlapping or neighboring bookmarks,
        when there are multiple boundary marks at the same
        character position, by painting all custom color bookmark
        boundary marks of the same character position.
        
        See also commit 4ce8120f1e53f7b81e653b01d141643013bc69ab
        "tdf#45589 sw: create and paint text portions for bookmarks".
        
        Change-Id: I845dadcf2f888493c43fcf48bc34af1c4cf340c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139110
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [dabaf2879673fe4bbe874a2917e7a9200737ba81]

        tdf#136370 Very large Shape with pattern/hatch makes scrolling slow
        
        reduce some time spent in the 3-d rendering
        
        Change-Id: I5d622799bc101b5b988d382a039b5a3b03818d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139256
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Khaled Hosny  <khaled@aliftype.com>  [ffd404384ec7f2c41451783f999a636f4e581441]

        More graceful fix for cid#513473
        
        Though I don’t think it is possible to have a zero grapheme cluster
        count, lets be more graceful and assume it is not a ligature and take
        the other branch. Also a grapheme cluster of one is not a ligature for
        our purpose, so check for that even.
        
        Change-Id: Ie52af1127a05f55cdfc858d47e128fa0f783f710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139254
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [b467c7a12bd5e5e2862a8c018a2135635dcc50cb]

        no need to use unique_ptr for this map in SvxAutoCorrect
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: I26ac04787a3b36feebd574687710b3a2b6864c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Miklos Vajna  <vmiklos@collabora.com>  [d0176d65de40b1ea53b4fcbc0f607911fa64d8e5]

        tdf#149969 slideshow: handle loop from the animation of a media shape
        
        Impress supported video looping on media shapes, while PowerPoint
        supports this as part of the animation tree for the slide. To be more
        specific, it seems in case there is play command, then it looks up if
        there is a media node of the timing tree that has the current shape as
        its target, and checks if the looping is enabled for this shape in this
        media node.
        
        The PPTX import already creates an (audio) node for the media shape and
        we have UNO API to set/get a RepatCount attribute on this.
        
        Rather than tweaking the PPTX import to create a different doc model,
        just extend the rendering so in case the shape doesn't enable looping we
        can also notice that an animation requested looping.
        
        The PPTX export doesn't write a media node for videos at the moment, so
        that still needs work.
        
        Change-Id: Ifc6600be760a954230243fd8151736656958a429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139253
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-02  Stephan Bergmann  <sbergman@redhat.com>  [5aa8e7ef07229d48cb719a5f3f01c9a7fa445554]

        Fix setting SAL_NON_APPLICATION_FONT_USE
        
        ...after a342b72f4218cd617aa6fb413fcf5fbb182c316f "gbuild: set
        SAL_NON_APPLICATION_FONT_USE in gb_CppunitTest_use_more_fonts" had caused e.g.
        CppunitTest_vcl_pdfexport to be executed with merely
        SAL_NON_APPLICATION_FONT_USE=deny rather than the stronger
        SAL_NON_APPLICATION_FONT_USE=abort that vcl/CppunitTest_vcl_pdfexport.mk asked
        for.
        
        So introduce a dedicated gb_CppunitTest_set_non_application_font_use that
        accumulates the requested modes and then selects the strongest requested one
        ("allow" over "abort" over "deny").  That also means we can go back to model
        "allow" with an unset SAL_NON_APPLICATION_FONT_USE env var.
        
        Change-Id: I32ba0a94c1965f0e3336e676b17f4f5efb85efce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139251
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b392d0a25e229f305497ab5f9f084b71b24cc387]

        tdf#150712 reduce cost of SharedString::getString
        
        where the construction of empty strings is significant here
        
        which required fixing a couple of places that ended up using
        a reference to a temporary.
        
        Change-Id: I52feb1673bd39db4060585ac8d9ae2f3dea27fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Eike Rathke  <erack@redhat.com>  [3869673f95fce5e83c9d5d9eaf08f21f36ad0bd6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2db5a35831ceda4d75930077fc4c2f0298f4193e
          - Replace dead langtag.net reference link with Wikipedia and W3C
            
            Change-Id: I5bc4d6c1133a6af3d7ffa97acdc2da5ae5fb66ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139255
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [70cab065b4bfc2e68838b0056c52741eab8e32de]

        no need to use unique_ptr for this map in sc::ScRangeName
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: I774368091ace3775d9d63b3ed561e323ad3adb9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139236
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b5c039a58dde8992c41f7d7e22cf393a15e1033e]

        tdf#136370 speedup bitmap fill operations
        
        when drawing to an internal bitmap, we can use cairo_rect instead of
        cairo_polygon
        
        Change-Id: If298cddea71c6db2ffc3d3bcf15317e92b738f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [9fa65519ab203500928cd63560b35daedb6e5ed9]

        add more tsan supress
        
        for new glib functions that show up
        
        Change-Id: I43929d043e2fd1c72c262f50e6aaa62a557c02b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [ac7be5bec77ff65969f923c417d88454a4e216ef]

        no need to use unique_ptr for this map in TableSlotsMap
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: Ic1d3a671eda09e5fa6def30393e344d57a54d3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139238
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b24eceb5178fda17fcc4b20c5286e8d27c5ae474]

        tdf#150712 limit the dialog to only a sample of the data
        
        instead of the entire area, which makes the dialog pretty much
        instantaneous
        
        Change-Id: Icb08a09733ee872b67d5be00cb083139f05fba7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [5226e3889155ea22465d488174a6f8720085628a]

        tdf#150683 qt a11y: Add bound checks for table methods
        
        Since the row/column indices come from outside
        (usually from assistive technology like a screen reader),
        validate them before using them when calling the
        corresponding methods on the
        XAccessibleTable{,Selection} interfaces.
        
        Otherwise, calling the corresponding UNO methods will
        result in a crash due to an `IndexOutOfBoundsException`
        being thrown.
        
        Change-Id: I4d018d16b99f1c2c7b88c1c9e03f16d40ec3345c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139250
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-02  Khaled Hosny  <khaled@aliftype.com>  [30a8f7e97d41d60098dbd14118d4f56c5557c06d]

        vcl: set hb_font_t variations from CTFont
        
        Without this we will be using the interpolated outlines (done by core
        text) but apply OpenType features from the default instance.
        
        Change-Id: I7a39b5483ba0f35b440841ffa07f587ad966bbf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139248
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-02  Julien Nabet  <serval2412@yahoo.fr>  [d8326fc81f7225047178e1b8a7605d32109fa08c]

        tdf#150712: Format->Conditional->Condition 100% CPU (2nd try)
        
        Change-Id: I5f7fe01141ecd057840c01a9080ff7fd2b941049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139226
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee46457ce572649c0b5f238d2556c0cc5a7a8ead]

        assert SwContentNodeIndex passed to SwTextNode are actually also on that node
        
        which flushes out a couple of bugs - unfortunately my fixes to those
        call sites are pretty much guesses
        
        Change-Id: I4b3f8a94042eef10c35112f3dc19fe214b472906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139115
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Noel Grandin  <noelgrandin@gmail.com>  [91c5e7a924830dbefeaedd4e342f6f2d69e1b1ea]

        no need to use unique_ptr for this map in chart::CommandDispatch
        
        map is already a node based data structure, so the values will stay
        in the same place in memory
        
        Change-Id: I255d99cd2014f33524480e218d2d9cd5ca812375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-02  Stephan Bergmann  <sbergman@redhat.com>  [ae3965f6cc87a7d57da319370ef1d783682100a8]

        external/cairo: Remove dead code from cairo.RGB24_888.patch
        
        ...now that ab157ab93e0c5a62927947a8d2b0c1c277e526ac "move part of sanitizer
        patch to the patch that introduced the problem" unilaterally folded in here the
        content of f5e1314ffa564077c27fb9c954c792b498bcae12 "external/cairo: Fix
        previous -fsanitize=alignment fix", about which that commit's message had
        stated:  "The following line
        
        >       pixel &= 0x00ffffff; /* ignore next pixel bits */
        
        should no longer be necessary now, and it is probably better to directly fix the
        original code in external/cairo/cairo/cairo-1.10.2.patch, but I'll leave that
        for a potential follow-up fix, once the provenance and assumed quality of that
        original CAIRO_FORMAT_RGB24_888 code is clarified."  (The provenance and quality
        of that code is still not clarified though, see the still unanswered question in
        the comment at
        <https://gerrit.libreoffice.org/c/core/+/116637/2#message-407ec72875fcb015a3024f9a7ebf8480513b1e5e>
        "external/cairo: Fix previous -fsanitize=alignment fix".)
        
        Change-Id: Ic729bff238a35fac69d048b7c3912dd706a5b601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139211
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-02  Miklos Vajna  <vmiklos@collabora.com>  [255d208501be212416d161ad6c9a168d9f241573]

        CppunitTest_sw_ooxmlimport: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I93878ccb1d754f1e9a8cfc93557b6d5fa6fa9fca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139231
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-01  Stephan Bergmann  <sbergman@redhat.com>  [21229c2f45f96a8ee3060acb3296be77be3a9f1a]

        Filter out unwanted command URIs
        
        Change-Id: I0b7e5329af8cc053d14d5c60ec14fe7f364ef993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139225
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cba119c2a44bcef4684073412798aec193fbd1b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7e717277963bd80b80a6f4b947e79cc97eea0e2
          - tdf#150689 Fix Calc contents tree
            
            Change-Id: If23ba66db8806ff88e67dc0485c5cf6376ccd0e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139227
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a2f60a92ee16dbe783a6e24549f7d6a01db1dbe]

        Revert "cid#513473 Division or modulo by zero"
        
        This reverts commit 18a0c0c690eaa0df804cd2e3040c433ffd886275.
        
        already fixed by a9aea4bb0d272ba0c2c8cb83714a2a8171297af6
        
        Change-Id: I6ca69b1e56fd7a2fafe51eadfcc057b44c30ebcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139176
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [57d9cc81b058757421cd082e5dbe32a919716807]

        tdf#127806: RTF import: use shape dimensions for pib picture
        
        If RTF shape contains pib (embedded picture) we should override
        any picture sizes by values from shape. Values provided inside
        \pict are ignored by MS Word; only shape values matter.
        
        To achieve this we need to know shape dimensions so it's
        calculation is moved to earlier step before internal picture
        eval.
        
        Change-Id: I99c1af7ba62c343b64b3db734b837ff101483ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139043
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [c1fe2b6da61f4bd55c7551b4f0c1b379ed814ffe]

        qt: Add include needed with qtbase dev branch
        
        `qVersion()` has been moved to a different header in
        qtbase commit [1]:
        
            commit 50b05e3e2ad969abf4b939d5db2253380e47d775 (gerrit/dev)
            Author: Sona Kurazyan <sona.kurazyan@qt.io>
            Date:   Tue Aug 30 10:37:00 2022 +0200
        
                Move qVersion() from qglobal.h to qlibraryinfo.h
        
                Since qVersion() might be called also from C code, disable the parts of
                qlibraryinfo.h that are relevant only for C++ code if __cplusplus is not
                defined.
        
                [ChangeLog][Potentially Source-Incompatible Changes] qVersion() is
                moved from qglobal.h to qlibraryinfo.h, '#include <QtCore/QLibraryInfo>'
                needs to be added where it's used.
        
                Task-number: QTBUG-99313
                Change-Id: I3363ef3fa4073114e5151cb3a2a1e8282ad42a4d
                Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
                Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=50b05e3e2ad969abf4b939d5db2253380e47d775
        
        Change-Id: Iafeb0ed6a77420f9a303d8ec4d3c5ba29c6f4b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139221
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [9b140c16196585eeabbd15bb6562eb371e399373]

        wina11y: Drop CEnumVariant::m_lLBound that's always 0
        
        ... and doesn't increase readability.
        
        Change-Id: I62f3b37e8b8b948600e4d5e721c67a575628f1d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139217
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb7747f627fe7e909fca7264fd42fe6cb7aef0b5]

        tdf#150712 use more string_view
        
        Change-Id: I3a9022a7f99653ca8ecc00908558b14ac5ff278c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [153b51da381ba21d46a3d42c939080272818797c]

        reduce cost of B2DHomMatrix::isIdentity
        
        often the matrix is still default
        
        Change-Id: Ieacf19c375e9988487047309187fce6b5b8c9561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2977b5bd4b112af33258e471291474a1fe9e10e]

        cid#1513472 Dereference null return value
        
        coverity can't see that pCNd cannot be nullptr here, so add assert to
        keep it happy
        
        Change-Id: I51915fce2d2e14f33e0ed4c640420491a9a01e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a86c829b48eb9d1f72b20088e1b983b9f27e0d86]

        cid#1513471 Dereference null return value
        
        coverity can't see that pCNd cannot be nullptr here, so add assert to
        keep it happy
        
        Change-Id: I9d834511b1fd29147a653525134f5617ae6698a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139167
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Eike Rathke  <erack@redhat.com>  [033e98dbe6aafd6719eb83ea4d2fc68110e195c9]

        Related: tdf#142293 Have ScCompiler::GetOpCodeMap() overwrite
        
        ... FormulaCompiler::GetOpCodeMap() forwarding to
        GetFinalOpCodeMap() as that is what we want from ScCompiler (and
        always had), eliminating the now possible temporariness of
        FormulaCompiler::GetOpCodeMap().
        
        Change-Id: Ia87fb0e911e4f7995bfb5df07dcd1fde3713d006
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139205
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Eike Rathke  <erack@redhat.com>  [15acaddb54c3e14a49b0d26d879c4436d34933e1]

        Related: tdf#142293 Remove temporariness now implemented at GetOpCodeMap()
        
        Change-Id: Ic61f45b1da286e2f4890bbc81dc5cd18c0d5bbe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139202
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Eike Rathke  <erack@redhat.com>  [5aaa0cda74de4170972b7988d8fca16a560b8500]

        Resolves: tdf#142293 Implement the temporariness of GetOpCodeMap()
        
        Change-Id: I7c587a68dbdeab9a8c8ed324ecae2eb5dd75b9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139201
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Eike Rathke  <erack@redhat.com>  [b8a83c5c63873faf1a63205b8aad634f351d1a9f]

        Related: tdf#142293 Use FormulaCompiler::GetFinalOpCodeMap() in ScCompiler
        
        Change-Id: I65bf11fca11acfbc372c99a5210e0f79b61f2be4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139171
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [372c7b231c2d75f6d9bade63cd1b980a84391d4f]

        use forced Calc calculation type even for single rows
        
        It's for testing/debugging, so this should not get optimized.
        
        Change-Id: Ib72eaa8ddb2c49ceee051856d977e2393bbb6966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139173
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [2dc0e72f413677ac650fbc21a98f70d5a00ceca6]

        improve inheriting from std::num_put
        
        These function in the base class are protected, and apparently some
        GCC versions warn about other overloads being hidden.
        
        Change-Id: I9d2e674b4fc9eedc97f586bbe4e4f21a6954b8a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139161
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [5763e9eab84259bf3924a3898e2ce8286b7395e2]

        cid#1513468 Dereference null return value
        
        add assert to keep coverity happy
        
        Change-Id: I9d9acb3883c4ed8950a018a3ed9a2ac7d591ca60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [18a0c0c690eaa0df804cd2e3040c433ffd886275]

        cid#513473 Division or modulo by zero
        
        I can't see how nGraphemeCount could be zero, so add an assert to help
        coverity out
        
        Change-Id: I324cc9819b401e5c1ab984446174ed2e96796eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139165
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4b2f7c048a0115b6e9b7feee0ce990df33e0ece]

        cid#1513474 Explicit null dereferenced
        
        coverity can't see that the logic is such that nullptr is impossible
        here, so add an assert to make it happy
        
        Change-Id: I666dde47851d468c0b9e282c389fe07e640028fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [1dbf4a111486ee4e5e2d9da0bbf5544742ae7805]

        tdf#150683 qt a11y: Avoid using 32-bit child index here
        
        Passing the `QObject` of the child directly in the
        `QAccessibleEvent` ctor generally has the same effect
        as setting the parent in the ctor and then passing the
        child index via `QAccessibleEvent::setChild`. In both
        cases, `QAccessibleEvent::accessibleInterface` will
        return the `QAccessibleInterface*` for the child
        afterwards.
        
        However, the latter only works correctly with child
        indices that fit into 32 bit, which isn't the case
        for all cells in a Calc spreadsheet with 16k column
        support.
        
        Change-Id: Iaa7b936df237f82dc21a00d3ac419a1519a95226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139147
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-09-01  Eike Rathke  <erack@redhat.com>  [603f9ce4f39a59bd84b5c08e3d725e0ee664991f]

        Related: tdf#142293 Introduce a protected FormulaCompiler::GetFinalOpCodeMap()
        
        ... to prepare having GetOpCodeMap() return a temporary if a final
        doesn't exist yet. Currently just an alias.
        
        Change-Id: I6fc100ae6223010e149e4af01fc7c17630930de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139162
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [418beb68f00190f61effb69726343adcd4597f64]

        tdf#150688 return atk_noop_object_wrapper_new() instead of null on failure
        
        Change-Id: I20fd190a36649193ee2a1e536f520344c5f6c89a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139160
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [c097c2ff102e8033afd26e22b7ea092ae82e27b0]

        cid#1509261 Dereference after null check
        
        Change-Id: Ib6dd69e4610ee6df76cde8446677e0f68bed3e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139157
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [f5ce2df24a91796d6b8c732ad1a8ab3c5f736cde]

        cid#1500537 silence Dereference after null check
        
        CreateView never return a null/empty
        
        Change-Id: I55829aff18f6ea3d508cfbd101ebcbf09ff37295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139156
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [526c7c72fad67a50e4bc14b7484cd4043387ca52]

        cid#1500519 Using a moved object
        
        make this more clear, expected to be null at this point
        
        Change-Id: I85531e0df4e43e59b178dbab8cede1d0de1927d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [98d70f1ed97218da0657ff9f1e83b782a0f6a22d]

        cid#1513470 Unused value
        
        since...
        
        commit b692eb6680ef63d699ddab07eb719fb1efb219ca
        Date:   Tue Aug 30 10:05:23 2022 +0200
        
            use more SwPosition::Assign
        
        - rPaM.GetMark()->nNode = rPos.GetNodeIndex()-SwNodeOffset(1);
        - rPaM.GetMark()->nContent.Assign( pTNd, nMkContent );
        + rPaM.GetMark()->Assign( rPos.GetNodeIndex() - SwNodeOffset(1) );
        + rPaM.GetMark()->SetContent( nMkContent );
        
        which presumably is ok
        
        Change-Id: I202ee9b7ea3554bd6c2399b8304db15e99af76f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139154
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [7d31ca57725e790d6a24e8df9adf0c5a0097186b]

        cid#1513469 silence Dereference null return value
        
        Change-Id: Iaddf5aa526438757195d60dcb255d6928128cf9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139153
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [a9aea4bb0d272ba0c2c8cb83714a2a8171297af6]

        cid#1513473 Division or modulo by zero
        
        Change-Id: Ia08d3d8cb0942bfea6a28e178fcb843d2c74f1f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139151
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Julien Nabet  <serval2412@yahoo.fr>  [e4d9d522fec5770dd25f99384ae7a012636662cb]

        Revert "tdf#150712: Format->Conditional->Condition 100% CPU"
        
        This reverts commit 076be52655f2cf4e331b344e0f6497f41b37fa8c.
        
        Reason for revert: I misread and we replaced "xa" "xd" by empty but it's a space.
        
        Change-Id: I0246f6a3c667b4336f21ffd61fd86574009b7956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139175
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-01  Julien Nabet  <serval2412@yahoo.fr>  [076be52655f2cf4e331b344e0f6497f41b37fa8c]

        tdf#150712: Format->Conditional->Condition 100% CPU
        
        Flamegraph showed this part, see:
        https://bugs.documentfoundation.org/attachment.cgi?id=182121
        
        Change-Id: Id14ea4f95d8912847f77eed561b14d3edee2f67f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139152
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-01  Tor Lillqvist  <tml@collabora.com>  [63f7765c1d50fbd87b53d692a2cd1720a7a16d70]

        Use more idiomatic C++
        
        Change-Id: I0e9460f2500b76bec049c12413fbbee5dcb239c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139149
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [cff37ecf6b9ecd8b169224c327570aa7f63b791e]

        cid#1513474 silence Explicit null dereferenced
        
        Change-Id: Ifd33ce24ca4cc351a0a68c87b463baf556001c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139150
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [bc500f802dcadb9b3ae1bc4a17ec825a242884c0]

        we have one CJK text test that explicitly attempts to use not bundled fonts
        
        add "allow" to NON_APPLICATION_FONT_USE=
        
        =abort to crash and burn if there is font/glyph fallback, and
        =deny to just restrict to the bundled fonts for the test
        =allow to explictly denote a tests want to attempt to search for
               and use some specific system-side installed font.
        
        note: currently this only affects fontconfig using platforms
        
        Change-Id: Iadc8a70531ac363b4c3f0c52d9f7bd79191b0139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe8dfdf6dad15f39f68859b935e7337f1d1fa0eb]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ia832fec32146c0d323a9a6ee1d8645f713e0371f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5dd22c7fe8aeaaee76cb8124113adda6c43dfd39]

        Fix typo
        
        Change-Id: Id912bf46e9c9b2aa02f58124cc8ee63a7cd3322b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139137
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-01  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [08e62dfbc156ef79cd9fa98e54bfba043247af8f]

        Added BufferedDecompositionGroupPrimitive2D
        
        ...and adapted GlowPrimitive2D to it as a preparation to
        use similar to BufferedDecompositionPrimitive2D, but for
        primitives based on GroupPrimitive2D.
        
        Change-Id: Ia1f9a09d4db09238ebbf6ad1303a4cdbdb8baedf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139099
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [256086fc9b3a00181c7022294712226cd920b2e1]

        check parameter count in various opencl functions
        
        Change-Id: I896331287ac5f7705f9fdfdb8e0786a894bc6eb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139077
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [0f44a1c0448b0f5ba53167b20c5bf94f92e071d1]

        error checking in opencl BIT* functions
        
        Change-Id: Icf76d5d656226de8f96caf59be1d64cf13d07bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139076
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [1e3cf15e2d090671f0735faa83d8c57bea0a37d6]

        do not return "random" values from opencl FTEST if it can't handle something
        
        Change-Id: I539d184b015b79ce0511656ab5140bce8698397d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139075
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [e306e86ac70e6d47d779f0b63ea76b3a72645b5a]

        opencl LogNormDist cannot handle less than 4 arguments
        
        Change-Id: I0669aed4b0cac5fc2165becb9bc8861a688272c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139074
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [ea6ce6cb6ad5a69c5bc59d0290a6beedb882ea0c]

        opencl, don't use GetBottom() as value for empty cells
        
        I'm not quite sure what this GetBottom() thing is, but e.g. acosh()
        treating empty cell as 1 is not right.
        
        Change-Id: Id86ab979598603c12cec99ec5758c27a99589107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139078
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [35ed13eba1ceb6ddab8a9a72c5ef46ab3aff8224]

        make sure opencl generated code doesn't lose numbers precision
        
        The default precision of both iostreams and stdio is 6 decimal places.
        This means that e.g. =POWER(1.0000001,2) becomes 1, since buf << number
        will write that first number simply as '1'.
        Moroever some generated code actually doesn't compile because ambiguous
        overloads, because '1' is an integer and not a double, thus floor(1)
        is ambiguous, as there are only floating point overloads (and C/C++
        are stupid about these conversions).
        So force using a wrapper class that forces a higher precision and
        the decimal separator. For debug builds, also avoid excessive precision.
        Apparently, neither iostreams nor stdio are capable of simply printing
        a reasonable floating point representation that wouldn't be too precise
        or imprecise.
        
        Change-Id: Ifa045712d90e6a6bbe5781ac3c805c989673dc8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139073
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [0b6520c4acbfbb656f00d0fab11289899614494f]

        explicitly use BmpScaleFlag::NearestNeighbor when wanted
        
        That is the algorithm that doesn't change colors, BmpScaleFlag::Fast
        works the same way only because it's mapped to this algorithm
        (which may not necessarily be the case forever).
        
        Change-Id: Ibebfff668eaa1da93963f8e8601fec51cfdfca34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139128
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Luboš Luňák  <l.lunak@collabora.com>  [0415aa11f66de0c64f1ed524197bfea70fe3c3ca]

        fix limiting drawing of softedge effect (tdf#141981)
        
        Apparently an empty viewport actually means everything should be drawn.
        
        Change-Id: I55ae453a8f264d48222ade48a2953ab7d97c7f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139125
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-09-01  Khaled Hosny  <khaled@aliftype.com>  [a342b72f4218cd617aa6fb413fcf5fbb182c316f]

        gbuild: set SAL_NON_APPLICATION_FONT_USE in gb_CppunitTest_use_more_fonts
        
        So it applies to all tests using HAVE_MORE_FONTS.
        
        Change-Id: I60567c996286aa8a76c7180c58aea7f214a99d87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139144
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Khaled Hosny  <khaled@aliftype.com>  [80aab73bc299caa62e4eb105b3fec7149d804c73]

        Add all vcl subdirs to soffice.xcodeproj
        
        I hope I’m not breaking this for others who are using it, if I’m, feel
        free to revert.
        
        Change-Id: I6d91340d17c9edcd3db6064c9ab9755ffeac4f96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139139
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1ea7bee33ed53ecdc1a68acf554680e5c88804f]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Id4d02e2b5c156ff7a93ce5d2d974c4594052bac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Eike Rathke  <erack@redhat.com>  [24d382a18ec2ade0d9e9b9c6e6c3e86bed6cde14]

        Resolves: tdf#150370 Accept 'art-x-...' private-use input in language box
        
        ... for artificial constructed languages.
        
        Change-Id: Ifd0f2ca63738eb9bbe78361cd3fdf507f3e397f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139135
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-09-01  Tor Lillqvist  <tml@collabora.com>  [ebb73e9e220433be9326dde4ac2284eba5e42558]

        More handwaving: Assume that it's OK to substitute OpenSymbol for Symbol
        
        And that when that happens, there is no reason for a LibreOfficeKit
        client to optionally warn the user that the Symbol font is
        missing. (Which it always will be, in that case, on Linux.)
        
        Change-Id: I2d60721c826cb3053197a19be8a69b71cbd98e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139108
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-09-01  Miklos Vajna  <vmiklos@collabora.com>  [2a403bcbbe0f45cd14a74ae76c4647096463e8ca]

        tdf#150474 RTF import: fix missing char props for in-table newline characters
        
        I forgot about this in b9508dd55f82d35f09a58021dc001cf79b390e08
        (fdo#50665 rtftok: don't ignore character properties of text fields,
        2012-06-06), which handled the plain body text case, but not the
        buffered case.
        
        Change-Id: I5c5ebb58becc44a6cf1e0bb8984b2b8c212c3c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139143
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c9c68f0ddb6625fd86a6e172e15d1c943bb81911]

        cid#1500508 Using a moved object
        
        regression from
            commit f67392948d625db9ce115092e4c9bfd301268a25
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Sun Oct 10 19:59:23 2021 +0200
            loplugin:moveparam in xmloff
        
        And change the AddNamed method otherwise the unnecessarycast
        loplugin will trigger.
        
        Change-Id: I58ded1379a6e5179f1065d68d7c2e9b812aa91ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6917a939cc656aaafb643627685b155d60f0399f]

        cid#1509250 Logically dead code
        
        this looks like it went slightly wrong in
        
            commit 0f86f678ff98115d32a381134985a1bd0d8c931e
            Author: Noel Power <noel.power@novell.com>
            Date:   Thu Jun 7 14:00:03 2012 +0100
            attempt to use mce::FallBack for control/oleObject import
        
        attempt to match the code to the comments
        
        Change-Id: I682b340c69ca6aa8a103fad87a3e7a1761adf43d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [a21d29e77af57758c2fb54e1592db3d7ed675f2a]

        tdf#150723 "run" will make the dialog visible like "show"
        
        so make run drop m_aPosWhileInvis like show
        
        Change-Id: Id7c024c487baaa0b2fd9500888e953b9b808921d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139134
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [739f3bb7228fa8c33029af46093b4646f848814b]

        improve the SwContentIndex debug pretty printer
        
        Change-Id: I7fa4f25b285c4cf7a62e3aa4616dbbca4e1c1e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [019501e6827e176c70480822725f7fc7b6a59de4]

        cid#1500502,cid#1500623,cid#1500659 Resource leak
        
        Change-Id: I7025dd3616ab2404a688d50bb25f07d012b52ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139092
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-09-01  Miklos Vajna  <vmiklos@collabora.com>  [50e743f210f35178b8c21628b023d50bf03e54f9]

        connectivity: use default member initializers in OWriterTable
        
        It's less code and does the same.
        
        Change-Id: I2469868a9fc97f4a9e6a89d53f50686ab89177ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139130
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [790b5c3cc3b6627c41696a0cccae88358a6fd1b6]

        change ABORT_ON_NON_APPLICATION_FONT_USE to NON_APPLICATION_FONT_USE=...
        
        with =abort to crash and burn if there is font/glyph fallback, and
        lesser =deny to just restrict to the bundled fonts for the test.
        
        Change-Id: I0a8f7046260c24f3bf24ec3a91489924486fb844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139132
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Stephan Bergmann <sbergman@redhat.com>

2022-09-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c54c576a5043dc5a0cc01f8c71897373516ae091]

        Fix typo
        
        Change-Id: Idc3bfb5298a00c681950aa4686748335ddd90d9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139136
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-09-01  Caolán McNamara  <caolanm@redhat.com>  [22795263e6743005c4f7df3e0dcedd933ed133b4]

        use VirtualDevice, not WorkWindow, in test
        
        like
        
        commit 8ca13426ca50a9466f552ac1e2f062920003d5ea
        Date:   Tue Aug 30 16:28:38 2022 +0300
        
            Workaround interdependency of tests
        
        Change-Id: Ic550f1cae45ff3145a3a25785499bf0d226e4940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139131
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-09-01  Khaled Hosny  <khaled@aliftype.com>  [3e544b6938ee509a4f6df4c2e2996d71ce072506]

        FeatureCollector: check for alternates only in GSUB
        
        hb_ot_layout_lookup_get_glyph_alternates() does not take a table ta and
        GSUB table is assumed, but if we are checking GPOS table then we will
        passing a lookup index from a different table and the result will be
        garbage (e.g. think Inter’s kern feature has 8 alternate glyphs).
        
        Change-Id: I78d5eb8304aee3321f492d15e3fc10db47cdc628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139138
        Tested-by: خالد حسني <khaled@aliftype.com>
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-31  Khaled Hosny  <khaled@aliftype.com>  [912f238343b99d89766c9ddde3f211454a59ae0c]

        tdf#150710: Don’t draw kashida when drawing bullet
        
        Passing the KashidaArray to the DrawText() calls for bullet drawing has
        the undesired effect of drawing the Kashida’s in bullet color and
        without overlap so they look wider than the regularly drawn ones. This
        is a regression from:
        
        commit 3901e029bd39575f700e69a73818565d62226a23
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Mon Aug 8 22:08:37 2022 +0200
        
            tdf#104921: Cleanup Kashida insertion logic
        
        Change-Id: I0c521249a9ffdd6b0cc273f0742bdeec53975a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139133
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [7d873ed7043c4f7d671d443bcf92369b5fe37224]

        wina11y: Drop unused member and methods related to selection
        
        Those were only used by
        `AccObjectWinManager::UpdateAccSelection`,
        which has been dropped in
        Change-Id I49bfddb636721d9142a88b7ce1eb3ee3a2f9c695
        ("wina11y: Drop unused AccObjectWinManager::UpdateAccSelection").
        
        Change-Id: I11d1ad3f01929a68e341f910ec6382f91227e3c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139124
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [58649c1db48b888f7ce4946ca92895fa0bc63349]

        wina11y: Drop unused AccObjectWinManager::UpdateAccSelection
        
        It was already unused when it was added in
        
            commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
            Date:   Thu Nov 14 08:18:05 2013 +0000
        
                Integrate branch of IAccessible2
        
        `CMAccessible::get_accSelection` already queries
        information on demand.
        
        The dropped method looks like another one of the methods that
        could be used for manual bookkeeping of information
        instead of querying them from the underlying UNO
        interfaces on demand. But retrieving them on demand
        seems preferable, s.a. the commit message in
        
            commit fcf4a26275d7503835f9aa23cb94938809840300
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 5 13:41:53 2022 +0000
            tdf#146306 wina11y: Retrieve accessible desc on demand
        
        > Querying up-to-date values from the underlying
        > UNO interfaces on demand instead of doing extra
        > manual bookkeeping in the winaccessibility code
        > may be possible for more a11y attributes in addition
        > to the accessible description handled in this commit,
        > but each one will have to be looked at separately.
        
        Change-Id: I49bfddb636721d9142a88b7ce1eb3ee3a2f9c695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139123
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-31  Mike Kaganski  <mike.kaganski@collabora.com>  [0fa5b4e03ed981cd79ac9af57e616714fc41b685]

        tdf#150714: [API-CHANGE] change CSV default encoding to UTF-8
        
        Makes import and export use UTF-8 instead of Windows-1252
        when executed from API without options.
        
        Change-Id: If04b119801c2509b48ca5d809f45d8437971d4b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139122
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [f887c9beee0da27acec3abf683d8031b2385ff5f]

        cid#1500610 Explicit null dereferenced
        
        Change-Id: I4b63822212c8445007435be6bbc67b6b2c64bbb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139111
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [5cb20b2084cf2270ba2c8f15fd899e2575696bad]

        cid#1500647 silence Resource leak
        
        Change-Id: I3f3a3cb5f31aff28711786af18d4bedcbd8e9ab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139109
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [8b8810343dc25eb44c2a5500648b9afbc94ab7b8]

        glyph cache considered artificial italic the same as regular
        
        The "true" font metrics are the same so it matches, though the
        result when rendered is different. Do the same with artificial
        emboldening too.
        
        seen with Bahnschrift font from tdf#103596 and tdf#108497
        
        Change-Id: I5fb77b5abe55fea9a09091e350c58866725c9b3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Maxim Monastirsky  <momonasmon@gmail.com>  [a72861e3be5b89544ae943c0c5cc6d43e8e70a7d]

        tdf#150506 Execution parameter confused with slot state
        
        Regression of a6eddceda5d376cd73922123a3bb3a5683307c41
        ("rename some SID to FN_PARAM").
        
        Change-Id: I5bcafdcec16cc91b1b77f7a3affd630a2f6cc556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139121
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-31  Stephan Bergmann  <sbergman@redhat.com>  [f6f0ef29f17a7afebd855dc06bd7172884649d73]

        Missing test dependency
        
        > warn:vcl.builder:1135119:1135119:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui"
        > warn:dbaccess:1135119:1135119:dbaccess/source/filter/xml/dbloader2.cxx:460: DBG_UNHANDLED_EXCEPTION in load exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui"
        > unotest/source/cpp/macros_test.cxx:74:FirebirdTest::testEmptyDBConnection
        > assertion failed
        > - Expression: xComponent.is()
        > - loading failed: file:////tmp/FirebirdTest__testEmptyDBConnection_2lyauo.tmp
        
        Change-Id: I25ede2d4b74753d056a15147737ae67e1c4b5588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139087
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f0cc045e06c8f3cd3f9780054f2259c6a0995f7]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I1f96b39094ea833ff742b5933fda610ef211997d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [62878fd6823c0ef05ced046fdf04b63bb189354b]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I2010f2d46504d858cbe7451515e56d31e9c22a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [00c03d8947d05e17086aaa48dba6ed70d5eb0078]

        cid#1509246 Inefficient vector resizing with reserve.
        
        preserve the benefits of reserving with the benefits of logarithmic
        doubling
        
        Change-Id: I0d15c4a5b4f1890c71b27c71169d9364f6448370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [32726168948ead21d455f2f836c788d1a665dad1]

        cid#1509196 Inefficient vector resizing with reserve.
        
        preserve the benefits of reserving with the benefits of logarithmic
        doubling
        
        Change-Id: I52f610218adf4f10cfe1a714728ef3c4c3956a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [d8e70a0b831f53961249ef0ac93bab1bc66f2818]

        cid#1500692 silence Use after free
        
        Change-Id: I9cb8595023276bafa538ad80be110505a60c6882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139106
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Hossein  <hossein@libreoffice.org>  [e8c0a88d640b32129eae6c9042fd908c2892c7e1]

        tdf#139627 Test justified Arabic/Persian text to avoid gaps/big overlaps
        
        With the patches 3901e02..62ff105 from Khaled, many problems with the
        justified Arabic/Persian text which were related to Kashida are fixed.
        Here, we add a test for tdf#139627 which converts the example file to
        the PDF format, then checks the width and the position of the characters
        in the output to make sure:
        
        * The characters are present in the PDF file in the correct order
        * The characters are joined together
        * The diacritic mark is positioned correctly
        * The overlapping of the tatweel character is not more than 10% of the
          first character
        
        Sample odt file uses "Noto Arabic Sans" font, which is available via
        LibreOffice on all platforms.
        
        One may run the test with:
        
            make CPPUNIT_TEST_NAME=testTdf139627 -sr CppunitTest_vcl_pdfexport
        
        Change-Id: I7a826a1b43ee842978decb0cf9a5e2a3b7219982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138328
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [ead23d945fb7bc794996c82287282bc385296ada]

        cid#1509247 reserve here can't be right
        
        the assumption is that m_aSvXMLElementExportList[m_nDepth] can be
        written to here, so it should at least be resize not reserve
        
        Change-Id: I2bb6074ca9dd2f71e17f5b9ec955e4d6d65edaa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [5a7522d378e080eae4f3558102f0642d6f5fab71]

        ofz#39186 avoid Timeout
        
        Change-Id: Ie5b796de7b10893b08ccafdec57dbf60a947128c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139105
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Eike Rathke  <erack@redhat.com>  [2c2e0568e89942cc8463c0da9aa7a3d177667178]

        Related: tdf#150370 Convert isValidBcp47() bool to enum LanguageTag::PrivateUse
        
        ... to prepare for more finegrained private-use control.
        
        Change-Id: I118c3f5ee6e437435c07ed2cf699c4597e9cdf88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139112
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-31  Mike Kaganski  <mike.kaganski@collabora.com>  [08385a624cbcd6d3de3476c76511545d4034a931]

        Empty salvage item was handled above
        
        Change-Id: Id0882c2caabe47f435b693aac9eb3a1c96760c59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-31  Heiko Tietze  <tietze.heiko@gmail.com>  [3b05eab7eb9a949912a329a2eae41abb8a0270cc]

        Resolves tdf#150697 - Improvements to terminology
        
        Change-Id: Ifeadc7ea92cac3f1b3883a694b38cd567153f4af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139088
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [16d1ec5955333b72da05b3d8ab029a939a0642a3]

        a11y: Remove historical Calc table dimensions from XAccessibleTable doc
        
        The mention of Calc tables having 256 columns
        and 32000 rows is a bit outdated.
        I actually started looking here because with
        16k columns, the 32-bit a11y child indices aren't sufficient
        for all cells anymore...  (tdf#150683)
        
        Also remove duplicated words.
        
        Change-Id: Id707d56e3947c727811259d5f1c46a7f136efc40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139113
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbc655a1e6bdb118e09d87d1fd9022c201d7b068]

        cid#1509230 Inefficient vector resizing with reserve.
        
        preserve the benefits of reserving with the benefits of logarithmic
        doubling
        
        Change-Id: I41896d1cef3e9939fda13f055e045ccb5d6ea1ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [2b0b12fa3bf9a880ad447368f7bd8a296e3a2834]

        cid#1500609 silence Use after free
        
        Change-Id: I090624c75de9567261ca1d3e2e4b4106c5d58352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139107
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [fc91d611a231ae6fc498d0ac32944afb72775b95]

        assert when formula group size is not large enough
        
        That should never happen, as the size should originally come
        from the formula group size.
        
        Change-Id: Ic429ef498bb56d589c04a07d0fb44d9841deb19f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139090
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2ab1136594baf0393d84d2c04d21561847498ac9]

        update credits
        
        Change-Id: Ie408cedd6e71deb241e3e059c364c75ce0f1d308

2022-08-31  Miklos Vajna  <vmiklos@collabora.com>  [8431cde61432893dd5ba75d8244457306a9f177b]

        crashtesting: fix DOCX export of forum-mso-de-102317.docx
        
        This went wrong in b2bc4ea8ddae6b01f344469d988e21fed3143c42 (DOCX
        import: handle SDT around citation field, 2014-07-16), the problem is
        that a run/inline SDT is pending, but we wrote a header stream in the
        meantime, so the invariant that Start/EndParagraph() in
        DocxAttributeOutput is called in pairs doesn't help, which results in
        not-well-formed XML, which is an assertion failure in debug build.
        
        Fix the problem similar to 5f3af56b2c0ef6c628a7cfe5ce6e86f8e1765f5f (sw:
        refactoring for docx sdt blocks output, 2021-11-16), which already did
        the same for paragraph/block SDTs.
        
        Change-Id: I5e7273b839bb5c1f841c0fab9b68b4ca239cca18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139089
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c028d551298b69f153af86c9cbeb01f06c4b810]

        cid#1500618 Explicit null dereferenced
        
        regression from
            commit 97c934d96be62f906c48561673866399f6469446
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Sep 18 14:32:11 2018 +0200
            convert SwGlblDocContents to sorted_vector<unique_ptr<>>
        
        Change-Id: I7262bfb07825ed830e9e7fd8a93452fb7e749e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [c7450d0b9d02c64ae3da467d329040787039767e]

        check IFrame "FrameURL" target
        
        similiar to
        
        commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627
        Date:   Wed Aug 7 17:37:11 2019 +0100
        
            warn on load when a document binds an event to a macro
        
        Change-Id: Iea888b1c083d2dc69ec322309ac9ae8c5e5eb315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139059
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f4d48ce5723f96c5c5969ae8d7cd3a1bf9c3594]

        cid#1500540 Dereference before null check
        
        Change-Id: Id12ee298c5b3a1cafcb79afeb07d8cc679b947f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e774b4d49e332b40031c2a8759b996d15481e38]

        cid#1500462 Dereference before null check
        
        appears to be dead code all the way back to
            commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b
            Author: Jens-Heiner Rechtien <hr@openoffice.org>
            Date:   Mon Sep 18 16:15:01 2000 +0000
            initial import
        
        Change-Id: I591cd51097daa641ccf1f583f7770ade138726ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139096
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8fce4a0a1077ed9d5652c8a9101e60be1408f47b]

        Fix typo
        
        Change-Id: I1cbdfec2c6340a8305fd249ff8112e2d8e0ffdfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139102
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e5ae7adcb58d41d8733b85b3e801a5d484a2832e]

        Fix typo
        
        Change-Id: Iae97a43a18a8017e739eb2bb4275da6fa275aff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139101
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [56a1c4e80c45c81d42a12b536863f8f26f6144c6]

        Fix typo
        
        Change-Id: I18d696cbc5685778e23bf69ce99e044db25f9a55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139100
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [693cf862c7da540817d3bdff9120429f1528ef64]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I7ab1a9f34fb1c953d0b4ea7d5b610b37fab2b2fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139081
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [08fc49843f2893a89b97c8e5f522d31a182bc282]

        document attempt to upstream cairo patches
        
        Change-Id: If3fc80931a544030a6cef97978f9fed835b4530b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139095
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [ab157ab93e0c5a62927947a8d2b0c1c277e526ac]

        move part of sanitizer patch to the patch that introduced the problem
        
        Change-Id: I3fdec4dd5ae93187aebb4a17f9fb01f0a536c9cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139094
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Caolán McNamara  <caolanm@redhat.com>  [0a54d331f4fbc2df167b97a92e375dd6cafb5576]

        ofz#50805 crash seen in fuzzing libreoffice text rendering
        
        Change-Id: I8af207ff21399f1bc3f36c01b7d2912692cbb06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139093
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-31  Sarper Akdemir  <sarper.akdemir@collabora.com>  [aebd3c4a7def4476f34e171fce395d6ba70e3e1e]

        tdf#144092 pptx export: export endParaRPr for empty shape & cells
        
        Alters ShapeExport::WriteTextBox so that when it is called with an empty
        text (on PPTX export) an attempt to export empty text's char properties
        (stored in the Shape or Cell's properties directly) made on
        ShapeExport::WriteText.
        
        These properties are exported into endParaRPr.
        
        Implementing this caused some tests that contain connector shapes fail
        with XML schema validation errors, therefore disabled export of txBody
        inside cxnSp tags.
        
        Also adds a unit test that checks roundtrip of empty shape or cell's
        endParaRPr.
        
        Change-Id: I3e3feda802f42560fa7fecc9c0b1afe73a900a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138960
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-31  Sarper Akdemir  <sarper.akdemir@collabora.com>  [1a0ceb76e2fe12cdfff7cabf06ef43cfba296a34]

        tdf#144092 tdf#139511: revert parts of tdf#91762 tdf#137949 tdf#139511
        
        Reverts parts that have wrong assumptions wrt layouting a table in svx.
        
        The problems reverted commits solved previously, were refixed by commits:
        - tdf#144092 pptx import: correct table height during import
          (a5126a21351c87138ff86a6636326eb6cd6a0f8c)
        - tdf#144092 pptx import: fix import of empty cell and shape text properties
          (57f9b4b7d1ad164c56af12009ef1dafbc1be8369)
        
        So hopefully, reverting these now won't cause many regressions.
        
        Change-Id: Ie96293810b033dc86e41c200f10cf63326511cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138653
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-31  oguzbalkaya  <oguz.balkaya@gmail.com>  [2839b604af94dbd1ee59dc6d47dc2f4c6ebd8dc6]

        tdf#101302: Add option to clear unavailable files in menu/start center
        
        This patch adresses tdf#101302. It essentially adds a menu item to clear
        unavailable files from the menu and start center. Previously, they were
        visible as recent documents in the menu and start center, and caused
        error when selected.
        
        Change-Id: I55ee9f663b24c343a90817c438aff11d9230061c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120480
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [575081690b894322c771c0a7e3a7beb89eb1aa0b]

        fix assert in builds with assert enabled, but dbg_util disabled
        
        after
            commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 10:27:46 2021 +0200
            ref-count SdrObject
        
        Change-Id: Ib320f42daff3b12798ee16b3739142f0e9f6d2e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c66f655be6412910ad1dc041adb519d2c630fe8d]

        cid#1509223 Inefficient vector resizing with reserve.
        
        Change-Id: I12f215d60a7420676523c7cec85bfa5149683841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Noel Grandin  <noelgrandin@gmail.com>  [38b7c85f59e8b4ea2a0ae19ababa4da9c7061e99]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I4e50aa5c71f86ed0d06e4c42b84d11158579207f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [beb3d232f0d2987c09e2963c49329575a4e66048]

        gtk3 a11y: Use name of the actually called methods in SAL_WARN
        
        The previously used ones look like copy-paste errors.
        
        Change-Id: I58eebff657f01cc1b0fb9acd661603cc41a09ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139072
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-31  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [c2d1458723c66c2fd717a112f89f773226adc841]

        Rework of GlowPrimitive2D
        
        The new version does all needed stuff inside the GlowPrimitive2D
        implementation. Advantages are:
        
        - there is no need anymore to handle directly in the renderer
          implementations. That includes HitTest & future renderers, but
          also the currently existing fallback from MetafileRenderer
          to PixelRenderer
        
        - the buffered B2Primitive can re-use the last, potentially
          expensively cerated pixelation result
        
        - it checks for the possibility to do so using various
          aspects (see implementation, more would be possible)
        
        - it no longer uses impBufferDevice in the not wanted
          double-vdev/alpha-channel mode from presentation engine
        
        - it offers an example how to do all this with just a
          primitive (that can be replaced with another impl if
          needed without having to adapt any renderers). To
          support that, I added plenty of comments
        
        The group of GlowPrimitive2D, SoftEdgePrimitive2D and
        ShadowPrimitive2D use impBufferDevice in that much slower
        and expensive mode (two VDevs, processor-based alpha
        mixing). To get back to faster transparence rendering
        in general this is a 1st step, we also will need to
        re-work the other two mentioned primitives.
        The reworked one is now more efficient.
        
        Change-Id: I25c6fb970682b5311ce6f9ca4abf2702fb7c8862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138973
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-08-31  Tor Lillqvist  <tml@collabora.com>  [0885d13cea917e9187adfe6190e60f4ce6039d2a]

        Remove comment that has been outdated since 2001
        
        The "empty comments" the comment referred to were removed in
        24f7917d9dc493ba35b504172f1ea3cfcd4d1486.
        
        Change-Id: I32b37224bbe02892af1a1d8c8898e40c005110da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139080
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f92766413310a3b11669224980a7e9cbf012ed73]

        Removed duplicated include
        
        Change-Id: I03783e8d6aa78887d70c07f99dfbf135cb3976e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139069
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [7d3ff55a0d072c825dac843bfbf6659a460103ba]

        pow(x,-1) -> 1/x in opencl code
        
        Ok, division is somewhat slow, but pow() is hardly going to be faster.
        
        Change-Id: I1c0d94243a67d0cd77874eb6b9ee6b4ef9206240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139049
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [0fe3863a4ef510009bc3191c035f1deafdd2fb6e]

        revert 'loplugin:flatten in sc' in sc/source/core/opencl
        
        I have patches rewriting this code to be much cleaner, so this
        won't be necessary and it makes it hard to rebase those patches.
        Also at least the CheckVariables::CheckSubArgumentIsNan() change
        actually makes the code worse.
        
        Change-Id: I5d63c158c6883200e2c6e03d02e00f6672d6a1af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139048
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [fd72a87868708569d19cccaab158116107698db5]

        fix opencl implementations of comparison operators
        
        The normal core implementations use approximate comparison. Also
        add the two missing operators.
        
        Change-Id: I98f65b4fed70dd40f9087b6d98696b3bb10ea194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139053
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [067610f46ae57f88439a1b7c5a28209d129e641e]

        do not accept strings for opencl equal operator
        
        This is part of "using string hashes for strings is kind of stupid"
        removal. And it seems this is never used for all of Calc's tests.
        Just keep it for numeric comparison.
        
        Change-Id: I1c5e3b10c9cacf3d163a675373f14d879a857db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139052
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [975fa7d700d50d376090de6c370aa00b8b38e8cf]

        remove opencl implementation of CONVERT()
        
        Part of removal of string handling in opencl (using the hash here
        is not that bad, a hash collision is unlikely, but still).
        And the code handles only two conversions (m<->km and sec<->min ?
        I'm not even sure). And it seems it's not used a single time
        for all of Calc's checks.
        It could be added back if there's use for it (possibly with handling
        the strings better, e.g. by converting them in the C++ code
        to enumeration values passed to opencl).
        
        Change-Id: I65a6ab51d8fb42c09d8a76a1e09f6f5fcbae099a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139051
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Luboš Luňák  <l.lunak@collabora.com>  [19e64b69fe1327993e8eeec41572d9c258686965]

        do not take strings for opencl <,>,<=,>= operations
        
        OpenCL code doesn't actually work on strings themselves, but only on their
        hashes. And comparing hashes doesn't necessarily have the same result
        as comparing the strings themselves.
        This is a part of preparation for removal of string handling in opencl,
        as the whole idea of handling strings in opencl is probably stupid.
        
        Change-Id: I8fa98bca0af14832f0d76135c1e195e1fb24451a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139050
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-31  Khaled Hosny  <khaled@aliftype.com>  [ce7c1c608fa99c86c8f2380cd8b82d02123f514e]

        vcl: Fix GenericSalLayout::GetTextWidth()
        
        There was a mismatch between text width calculated in
        GenericSalLayout::GetTextWidth() and last glyph width calculated in
        GenericSalLayout::GetCharWidths(), with the later using the sum of
        GlyphItem::newWidth() and the later using the GlyphItem::linearPos(),
        but linearPos() includes glyph offset and it should be subtracted from
        it to get actual width and we were subtracting it in the wrong place.
        
        I fixed where the xOffset() is subtracted but didn’t change it to simply
        sum GlyphItem::newWidth() though that is simpler so that we continue to
        test that linearPos() is correctly set.
        
        Change-Id: I40d6be6d1c82ed0ca1ce04bf792adf72faa0d787
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139071
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-31  Khaled Hosny  <khaled@aliftype.com>  [bdbbdc9b931d35f6d7d816512ac5be599295dc80]

        tdf#30731: Use ligature caret positions from the font
        
        When ligature caret positions from the font are available, use them for
        more accurate caret positions instead of evenly distributing the glyph
        width over grapheme clusters.
        
        Change-Id: I0ecfa35e1fff2b264b105182a4b29b2ebd033093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138955
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-31  Noel Grandin  <noelgrandin@gmail.com>  [51103b8396c3a0c0dc34afcf3c11bd93e4342163]

        flatten data structures in SvXMLAutoStylePoolP_Impl a little
        
        set::set is already a node-based data structure, no need for
        more indirection
        
        Change-Id: Ib4083615696302621ce6f91059f99eee0849e4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139067
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-31  Khaled Hosny  <khaled@aliftype.com>  [8cb4db941f91cc234dd18c61f8b1e51f65360d1f]

        tdf#30731: Improve caret travelling in Writer
        
        Previously, when measuring caret position, Writer would measure the
        width of the substring before the caret (i.e. layout it independent of
        the text after the caret and measure its width).
        
        This is incorrect, though. It assumes cutting the string laying it out
        would result in the same width as when laid out as part of a bigger
        string, which is invalid assumption when e.g. cutting inside a ligature
        or between letters that have different shapes when next to each other,
        etc.
        
        This appears to work when the width of the substring laid out alone is
        close enough to its width when laid out with the full text. But in cases
        where is widths are largely different, like the extreme case in the bug
        report, the caret will be jumping around as it is positioned based on
        the unligated glyphs not the ligated, rendered glyphs.
        
        This change introduces a special mode of measuring text width for caret
        positioning, that will layout the whole string that return the width of
        the requested substring.
        
        Fields and small caps text are trickier to handle, so old behaviour is
        retained for them. Now one will probably notice but if they do, it can
        be dealt with then.
        
        This also tries to be conservative and keep other pleases using the
        existing behaviour which might be desirable (e.g. when measuring text
        width for line breaking, we want the unligated width), but there might
        be other places that should use the new behaviour.
        
        To handle caret inside ligatures, the grapheme clusters in the ligature
        are counted and the width of the whole ligature is distributed on them
        evenly. A further improvement would be using HarfBuzz API to get
        ligature caret positions for fonts that provide them, which helps when
        the ligature components have different widths.
        
        Change-Id: I02062e2e2e1b1a35c8f84307c0a8f5d743059ab5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138889
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-31  Michael Weghorn  <m.weghorn@posteo.de>  [d325edf88c8dbcdaf324b8e3585a314c9351cf60]

        tdf#150676  sw a11y: Remove item from selection list on dispose
        
        As reported in tdf#150676, selecting a table (or also just
        simple text paragraphs) in Writer, then deleting the selection
        would result in the following warning when using the gtk3
        VCL plugin:
        
            warn:legacy.osl:100403:100403:sw/source/core/access/acccontext.cxx:442: fire event for disposed frame?
        
        This is because the code responsible for sending a11y events
        for selection updates gets called after the a11y objects
        of the previous selection have been disposed already and
        wants to send an event that the object has been unselected:
        
            > 1   SwAccessibleContext::FireAccessibleEvent                                  acccontext.cxx         444  0x7f4ffc5be7a2
            > 2   SwAccessibleContext::FireStateChangedEvent                                acccontext.cxx         475  0x7f4ffc5be8c2
            > 3   SwAccessibleContext::SetSelectedState                                     acccontext.cxx         1508 0x7f4ffc5c3752
            > 4   SwAccessibleMap::InvalidateShapeInParaSelection                           accmap.cxx             1428 0x7f4ffc5ea0fd
            > 5   SwAccessibleMap::InvalidateCursorPosition                                 accmap.cxx             2671 0x7f4ffc5f119d
            > 6   SwViewShellImp::InvalidateAccessibleCursorPosition                        viewimp.cxx            415  0x7f4ffd515c32
            > 7   SwCursorShell::UpdateCursor                                               crsrsh.cxx             2029 0x7f4ffc745e06
            > 8   SwCursorShell::EndAction                                                  crsrsh.cxx             278  0x7f4ffc73d4a7
            > 9   SwActContext::~SwActContext                                               edws.cxx               169  0x7f4ffccd45d4
            > 10  SwWrtShell::DelRight                                                      delete.cxx             322  0x7f4ffdc5a454
            > 11  SwBaseShell::ExecDelete                                                   basesh.cxx             229  0x7f4ffd9e304d
            > 12  SfxStubSwBaseShellExecDelete                                              swslots.hxx            2173 0x7f4ffd9e2784
            > 13  SfxDispatcher::Call_Impl                                                  dispatch.cxx           254  0x7f5039ab6f72
            > 14  SfxDispatcher::Execute_                                                   dispatch.cxx           753  0x7f5039aba37c
            > 15  SfxBindings::Execute_Impl                                                 bindings.cxx           1060 0x7f5039aa62b7
            > 16  SfxDispatchController_Impl::dispatch                                      unoctitm.cxx           701  0x7f5039b7a55e
            > 17  SfxOfficeDispatch::dispatch                                               unoctitm.cxx           263  0x7f5039b7840d
            > 18  svt::(anonymous namespace)::AsyncAccelExec::impl_ts_asyncCallback         acceleratorexecute.cxx 481  0x7f5036a40cfc
            > 19  svt::(anonymous namespace)::AsyncAccelExec::LinkStubimpl_ts_asyncCallback acceleratorexecute.cxx 473  0x7f5036a40c1d
            > 20  Link<LinkParamNone *, void>::Call                                         link.hxx               111  0x7f50336ac77f
            > ...
        
        To prevent that, remove the entry from the map of
        selected frames as well right when the object gets
        disposed.
        
        If necessary, sending the corresponding event that
        the item has been unselected should probably be done
        here, but it currently seems to be of little value to me
        when the object gets deleted anyway, so this commit
        doesn't add sending an additional event here.
        
        While at it, convert the `OSL_ENSURE` to a `SAL_WARN`.
        Warning in case `FireAccessibleEvent` gets called
        on an already disposed object generally seems reasonable
        to me.
        
        Change-Id: I879ba4e6399ffdc61e38093c5a9bd2ae620888e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139039
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-31  Sarper Akdemir  <sarper.akdemir@collabora.com>  [a5126a21351c87138ff86a6636326eb6cd6a0f8c]

        tdf#144092 pptx import: correct table height during import
        
        It appears PowerPoint can export rows of a table with row heights that
        is less than the minimum height (for that row). And also export the
        total table height wrong with it.
        
        If PowerPoint imports such a table, those rows are individually
        expanded to the minimum height. (Also increasing the table's total
        height)
        
        In Impress import we calculate table height by adding up individual
        row heights. Table layouting code depends on the table height being
        correct. This is why rows with less than minimum height lead to
        layouting problems.
        
        To compensate for this, while importing tables, layouting is skipped
        until the table height is updated with the corrected height.
        
        The correct height is calculated by layouting the table without
        fitting to an area (i.e with bFit = false).
        
        Change-Id: I79187882470a4e285b45bca1eabb469a084067f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138652
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-31  Miklos Vajna  <vmiklos@collabora.com>  [4f738840d804a03c44fc9f468f3470688a43f926]

        CppunitTest_sw_odfexport: remove not needed mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I0444c9814e5854262e2dd1aef72b87174f762e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139066
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9ba1e1486bf3fcccf98da93d3963b3d4036705a9]

        Fix typos
        
        Change-Id: I4ed7373afbb4102bbfaf0565c248a5cc84bd3ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139068
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d806f9223ae53365acd9aa6cb448adbb1811c57c]

        Fix typo
        
        Change-Id: Id405de7e2abfa6c4e77930d70b204f77e9cac1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139070
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-31  Liu Hao  <ianahao331@gmail.com>  [aea89831f93b501738e62db9787a1085fd483193]

        tdf#145614 Convert #define to enum or constexpr
        
        Rename CommandId to ShapeControllerCommandID
        
        Change-Id: I41369ba893d68df876c8200aae19cc617837d077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138251
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [ef2ab3326ab1390c5c08d56d65af6dedd67c894f]

        gtk3 a11y: Implement methods for (un)selecting table rows/cols
        
        The `XAccessibleTableSelection` interface provides the
        required methods.
        
        This e.g. makes (un)selecting rows and columns in a
        Writer table using Accerciser as described in
        Change-Id I0c239c0d36a073cd63a35ca7d0802cf5591d9738
        ("sw a11y: Don't confuse row and column") work with
        the gtk3 VCL plugin as well.
        
        Change-Id: Ic17cc74c209b08907adedfa59ac586732b5ec3bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139065
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [0a8efec1cd6ad5c8a3c09d4266067944f5d9d7be]

        sw a11y: Don't confuse row and column
        
        The previous use of `isAccessibleColumnSelected`
        instead of `isAccessibleRowSelected` e.g. caused
        the row not to be selected when selecting
        the a11y object for a Writer table in Accerciser's
        treeview of the a11y hierarchy and typing this
        in Accerciser's IPython console with the qt6
        VCL plugin in use:
        
            In [25]: acc.queryTable().addColumnSelection(0)
            Out[25]: True
            In [26]: acc.queryTable().addRowSelection(0)
            Out[26]: True
        
        Change-Id: I0c239c0d36a073cd63a35ca7d0802cf5591d9738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139064
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [d079415f7ddc4e47cbdfe527d1b5dcd3565599dc]

        svx a11y: Simplify AccessibleTableShapeImpl::getColumnAndRow
        
        Just use division and modulo instead of a custom loop.
        
        Change-Id: I70a975d6c73d4c3f645d250b9c571fe6e35cd702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139063
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-30  Michael Weghorn  <m.weghorn@posteo.de>  [8acbe35ee38419bfa484c8c43e810c8ac68201c7]

        svx a11y: Drop TODO that doesn't need action
        
        `AccessibleTextHelper_Impl::getAccessibleChild` that
        gets called from `AccessibleTextHelper::GetChild`
        throws an `IndexOutOfBoundsException` on invalid
        index which is the expected behavior here and what
        the comment for `AccessibleCell::getAccessibleChild`
        says, so drop the TODO that seems to have been there
        to check this.
        
        Change-Id: If04438cc3625ce438ada75bb6dea7e6c88c3e894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139062
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-30  Eike Rathke  <erack@redhat.com>  [ac371ee822e6640a8e2d6591236c22d1ab679462]

        Use ScFunctionList::IsEnglishFunctionNames()
        
        Change-Id: I21a7bf18c2117187b2e8c770b9367f46323b2c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139054
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-30  cutamar  <amar.cutura@gmail.com>  [45394fcf7e45f623add7ed3c6dc43e6d6f89158c]

        tdf#141908 Replace usage of sal_Int32 with Color in unit tests
        
        Change-Id: Ifb5ff2e6d5ed28bcb9e190d7f2deaaa970693cbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138938
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [4343432d423b5d92ca2b4ff5037eb29c8ac080ff]

        crash inserting odt as embedded ole object
        
        Change-Id: I6bf8e2913fc677efe9904507ef8e4edddb9ef3ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [8ca13426ca50a9466f552ac1e2f062920003d5ea]

        Workaround interdependency of tests
        
        CppunitTest_vcl_text failed for me on Windows:
        
          [_RUN_____] VclTextTest::testSimpleText
          C:/lo/src/core/vcl/qa/cppunit/text.cxx:198:VclTextTest::testSimpleText
          double equality assertion failed
          - Expected: 28
          - Actual  : -1
          - Delta   : 4
        
        This turned out to depend on test order; the minimal failing command was
        
          make CppunitTest_vcl_text CPPUNIT_TEST_NAME="testArabic testSimpleText"
        
        and running testArabic before testSimpleText made the latter to render
        white text on white background, and thus being unable to get resulting
        height of the painted text.
        
        Changing how the complex tests obtain their virtusl devices fixes this
        for me. I have no idea how and why the previous complex test code
        affected following tests. Windows buildbots were unaffected maybe
        because they had HAVE_MORE_FONTS undefined.
        
        Change-Id: If079e21e6b986fed5407295a71f9b121cf8de0b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139047
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb38ff2ea917c5f7440f3d421a707cb53c1aa068]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I8858193e94fe34f1fe13d1aaaf7c7b1ed364af61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3f58796b5d192e1028bd32c852da53fdce1540b7]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I4ce9a5be9f3ad6d31eac8917ddb53b2228220066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [3978a2d53ec4e8a69ebae1d904e05211d202a0ff]

        bump scrtf input len some more
        
        Change-Id: I02a8250f85ee13e5eb8596f2ebf609b743a6cc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139060
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ef4ed1e4b506a9fc54b069b6de3980ed731be30]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I0defa466d8088aaad1c23b2fc780dcaa37691ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139006
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Miklos Vajna  <vmiklos@collabora.com>  [13219c632b7ec154ba882a715cf890b54f10b146]

        sw reqif/xhtml export: fix invalid pixel formats of graphics exported as OLE
        
        When exporting a Writer document to reqif-xhtml in ExportImagesAsOLE
        mode with something like:
        
        	soffice.bin --convert-to 'xhtml:HTML (StarWriter):{"XhtmlNs":{"type":"string","value":"reqif-xhtml"},"ExportImagesAsOLE":{"type":"boolean","value":"true"}}' test.odt
        
        images are exported as ms paint ole objects instead of plain images.
        
        This happens in WrapGraphicInRtf(), using GraphicConverter::Export()
        where we just specify we want a BMP output. This usually works, but not
        when the bitmap format is something exotic where we try to keep that
        format in BMP, but ms paint can't handle it. When this happens, we get
        an RPC_E_SERVERFAULT error from OleRun() in OleComponent::RunObject(),
        which doesn't say much, except that ms paint failed to read the byte
        array we handed out.
        
        Fix the problem by ensuring that if a graphic is exported as OLE data,
        then it always has the 24bit pixel format.
        
        Interestingly a 8bit BMP can be opened in ms paint manually, but not
        when embedding it as OLE object.
        
        Change-Id: I2285bf67c4528cde208ae9fba42ece56822f5403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139044
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-30  Tor Lillqvist  <tml@collabora.com>  [238c06f070b860ff1b6dac05b4d3c2b025a0cf3e]

        Filter out well-known metric-compatible font substitutions
        
        Change-Id: I9da63c173dcc926f577052b704284065b384f960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139038
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-30  Stephan Bergmann  <sbergman@redhat.com>  [eddd37280aa69da82cde91c9b9cc8139c6ec8cdc]

        These commands are always URLs already
        
        Change-Id: I5083765c879689d7f933bbe00ad70bb68e635a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139042
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0c5274497f252c6a41904d6249191d910c3f199]

        reduce cost of SwCache::Check
        
        which makes up 10% of the CPU cost of running writer unit tests.
        We can achieve the same correctness testing without an O(n^2) algorithm
        
        Change-Id: I2ba0574fa63a457b3c7bd670498a0c64a35280b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Tor Lillqvist  <tml@collabora.com>  [be7d65019566eba59ec596672d9d25b56e47f748]

        Add SAL_INFOs for the recorded and pruned font substitutions
        
        Change-Id: Ice7b64c87bff6dbc0eead7bda36f3b0a678986e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139037
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2ce5ce87ecbaf4fcfc0f7341110f35c780cefb3]

        OSL_ENSURE->assert in SwCacheObj
        
        if these overflow, we will get more serious problems further down the
        line. Rather assert here.
        
        Change-Id: I70f27edb7c61a0c622a9f8fcb2e1eb075966ac59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139035
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Luboš Luňák  <l.lunak@collabora.com>  [73f9048c4038707258ee42acaf1946d90df6270a]

        bail out in opencl unsorted vlookup as soon as a match is found
        
        Change-Id: Ic2eda985f93c4eac26e08251c5bdbc36d7c03708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139028
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-30  Luboš Luňák  <l.lunak@collabora.com>  [ad2b6f1623300d28723d66fa0ac40530498acc77]

        opencl vlookup, move constant condition out of a loop
        
        There's no need to check in every loop iteration if the vlookup should
        be sorted or unsorted, and this needless branching slows the execution.
        
        Change-Id: I4f3072ddeaf54269cfec51043e84adb2571f0f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139027
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-30  Luboš Luňák  <l.lunak@collabora.com>  [0db5b15e8e2799ed28ed4baa9939b76c90e944fb]

        opencl VLOOKUP should not look up in other columns
        
        VLOOKUP searches only the first column, I have no idea why this was
        made to search all of them.
        
        Change-Id: I3297a723a727ba3f56db9bbb320d5b868b247db7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139026
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8caf588bb5d1c2babd6a331dad8d27aa9491ae6c]

        add some comments to SwCache and de-indent a little
        
        Change-Id: Ie4390aa0b55f46bc0937c6858ca6fd08393e02a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139034
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [210042432462316db196464a83763405acc6b698]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I8dfb5e72563d2036b89ebdf49a7b1c29629ada14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139008
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e17717404d147a99d4c1f797298598ba54bb95f]

        SAL_WARN->SAL_INFO in SwContentNode::ChkCondColl
        
        we call this on all nodes, so it's not really a bug
        
        Change-Id: I7bb258e68abf6fb0ced5a46924b715febb79c587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139036
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [28223ab9198e693a1cb4e344f14f8f5d5fbf127a]

        Unify the two places dumping bimaps for debugging
        
        Using the environment variable allows me to use a directory
        where no "access denied" happens on write access.
        
        Change-Id: Iffdd9b8566f2d794a6741b71d736d14d4643576c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139033
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-30  Heiko Tietze  <tietze.heiko@gmail.com>  [9ddbae9c65e795e9122c43eea0b4fa3a4d118939]

        Resolves tdf#145159 - Use display colors in Header/Footer dialog
        
        Change-Id: Ia19babe3603f653fa631f3d138b43103a553e944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138998
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [bc8e1c3d3f471823dfd68beb8c7e0974be00f20e]

        fix "g_object_weak_unref: couldn't find weak ref" warning
        
        (soffice:3465993): GLib-GObject-WARNING **: 11:33:34.451: g_object_weak_unref: couldn't find weak ref 0x7fffe9553580(0x7fffb4014180)
        
        do the same thing for all the gestures
        
        Change-Id: I944645fc3c95fd73186cd22e71738f247d864bb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [6daa9cd1331f70b5bfa55d5306c2216331ede680]

        Inline some macro wizardry
        
        Change-Id: Ice11a7b004ae39b6e455efa8f9cee62225d55147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139032
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [b37e6d2cbd2cfbd5c6eeba81415182c1c766de8f]

        gtk4: connect the zoom and rotate gestures for gtk4
        
        Change-Id: I9aec166cadcd7ae961ffbc390e0cddf9d8535a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Tor Lillqvist  <tml@collabora.com>  [d9ef86236891ec71c958b5402262dd698c51bb7f]

        Fix typo
        
        Change-Id: I857bdb7831bd1e4158f80f09ec232d76d4db794e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139029
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [b692eb6680ef63d699ddab07eb719fb1efb219ca]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I675136be4de95a53bb0b2c08117ae67da405351e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Maxim Monastirsky  <momonasmon@gmail.com>  [dbeb697d62250e9429462c7f61b859893262a651]

        tdf#149956 Rework toolbar image flipping
        
        An unified code, covering both vcl and weld cases. For
        SidebarToolBox, the controller is created before items
        are inserted, so we listen for item insert event to set
        initially correct state.
        
        Change-Id: I3841f21883104b4d3f8541c97ec7fa5fc0bec575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139022
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-30  Maxim Monastirsky  <momonasmon@gmail.com>  [4fb8c0d14cb2468f7336438004f699b9eb7e7e4a]

        tdf#149741 tdf#149956 Make flipping work also in the sidebar
        
        - Reset the icon each time, as there seems to be no easy
        way to retrieve the existing icon from a gtk widget in
        order to mirror it, like we used to do for vcl. Similar
        approach is currently taken in
        ToolboxButtonColorUpdaterBase::Update.
        
        - Store the flipping state also in GtkInstanceToolbar,
        similar to vcl's ToolBox. This seems to be the easiest
        way to make flipping not break on icon theme change,
        covering all 4 cases (ToolBarManager, SidebarToolBox,
        ToolbarUnoDispatcher, GenericToolbarController), w/o
        too involved changes in each. This might benefit from
        some refactoring later on, but should be good enough
        for now.
        
        - One unsolved problem is the appearance of flipped
        icons with svg themes, as the regular variant is handed
        to gtk directly, whereas the flipped one is loaded by us,
        resulting with a different (blurry) look.
        
        Change-Id: I48c16827b46fb75fd798a041851af6e2648ae8fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139021
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-30  Maxim Monastirsky  <momonasmon@gmail.com>  [2958e4c92f15652c424765f02c87518011eb2406]

        tdf#149956 Remove previous vcl only solution
        
        Change-Id: Id67b75856a230e175ccc6328ec0838c78589191b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139020
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-30  Miklos Vajna  <vmiklos@collabora.com>  [1f6918b458e5edee8daa7c81675b30d50533249f]

        Split CppunitTest_sw_uiwriter3 into a uiwriter3 and a uiwriter8
        
        My build with 16G ram now regularly fails with:
        
        g++: internal compiler error: Killed (program cc1plus)
        Please submit a full bug report,
        with preprocessed source if appropriate.
        See <https://bugs.opensuse.org/> for instructions.
        make[1]: *** [solenv/gbuild/LinkTarget.mk:337: workdir/CxxObject/sw/qa/extras/uiwriter/uiwriter3.o] Error 4
        make[1]: *** Waiting for unfinished jobs....
        make: *** [Makefile:289: build] Error 2
        
        Change-Id: Ia758f2e905a13369a9eef7eece4104bb9ea76303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139025
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [6af64a35270678ce07a9c2e5e3aeaa7507f79710]

        its not ideal to wait until Paint to set the bg color
        
        set it at construction time
        
        Change-Id: I8923ea8f79c4bf18054fc697e2b35caad1b12486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139024
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d2272426cc79d9aacf4a34c5fd7744b59c29e95b]

        Use some more C++ in sal/osl/w32
        
        Change-Id: I407bd4b044143a42d5652dc4164421b602cfe486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138958
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [660018d787e0116f1e8a9615bffb1cbf570e42fa]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Idba478c29e3651200a9548c325835ed45f09b50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [b715118b8ea3374fc6895c7e5792b71410ad155c]

        ofz#50756 Direct-leak
        
        Change-Id: I76404a154bcf5b3724970ce546f64c0a3cf2f282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139015
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [92180791382f64c2b79f485e72b7a1026d573c2f]

        always call SetCursor even without a11y enabled
        
        returns too early
        
        Change-Id: I68715d965538853244aa1dbd52f4ae8adc27293b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139023
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [70e0b2ab2cfb45f7eaa08337a42546f9c9f94542]

        ofz#50761 Integer-overflow
        
        Change-Id: I8681e7b1b128e7ca33142b7120ad2d4bb3227493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Eike Rathke  <erack@redhat.com>  [5a16cd1123003d6f72d84983292cf96c7fb49d60]

        Move input handler function names to ScGlobal static
        
        ... as there is only one function list and
        InputHandlerFunctionNames can be shared instead of each
        ScInputHandler holding their own copy.
        
        Change-Id: Id82b2020f8846456ce7464daa83feb6915792aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139012
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [ffe488c38741f4391b2f19440a8d20f4ed38a886]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ib3a3867d8eafd66de3c426eacf50d3f7c97fc4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-30  Caolán McNamara  <caolanm@redhat.com>  [2b25dac755fbad79a9f30a7295a6e5cf0414d38c]

        cid#1512492 Logically dead code
        
        Change-Id: Ibb003782d8ea47a2318959f4d8b6aa11e0e874c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139013
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-30  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [599da3fa69805ebf8dee4517855fd8706e19d11d]

        tdf#114769: sw html export: better handling for relative URLs
        
        Usage of INetURLObject makes sense only in case of full URLs,
        but once relative one is provided it will contain invalid data.
        
        Change-Id: Icc5e191e2337a3dd9a76c660b1c7709551099a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138875
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-30  Miklos Vajna  <vmiklos@collabora.com>  [966299b64a9a52fcccc1abc99406ea77fe121619]

        sw: document SwFormatFootnoteEndAtTextEnd
        
        Subclasses only have to override Clone(), everything else is shared.
        
        Change-Id: I3ef6242cbddb02c23de466d1959ee6c930723011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139014
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-30  Stanislav Lopatin  <genkiginchan@gmail.com>  [91f91815124c00727eefdd92fbed2d927faaf60b]

        tdf#145538 Change common loops to range based.
        
        Just convert some loops to range based.
        
        Change-Id: Id80d9366f77bb08a130004db800b19e967496541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138221
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-30  Łukasz Leszko  <leszko.lucas@gmail.com>  [59ddcb0445da12f2b912f1a8a876117fec112c41]

        tdf#90299 Fix saving external links as relative
        
        In current build some links to external xls files are not saved as relative even if
        "Save URLs relative to file system" option is checked. This patch aims to
        solve this issue.
        
        Change-Id: I6d0984bdcdeef57b227c8ab1353e002fa4355fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131711
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a606244d9aa0054988caf1859efb7f26d38748cf]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I5ec22fd36b74ce08cbb60d055c5feea9ec489f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139009
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Caolán McNamara  <caolanm@redhat.com>  [51da8b9e80ea38a726bdc518fc8f19d4f13f806b]

        Resolves: tdf#150629 the window was destroyed from the fadetimer callback
        
        which is how it could be possible that SwPageBreakWin::dispose() could
        be both called, stopping the timer, but the timer callback could access
        the disposed SwPageBreakWin
        
        Change-Id: If29ffb45fbde607d35c12064b05e4b5d25c2f009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139011
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [591673d1637b25f83e01baccc321a83f10fc0ce7]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I58b7824f7eaa3a6d82ec290d7354ed65ca8acdbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [f9e415c87763b8d025764921df13e24a9449c4c0]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I4edc1917fd02f6b5c498cbb8e4f74fb536cdf60d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [ff1ec4d59a2c97ccabbfd6e5fa542c19ab65db14]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I4d754368561b69339dde3395a637a0fb19d75512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [571b9950236d09df406bf1a05875f6ba95632515]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I2936782ede9871189d48aeca7d25d47d13ae1fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [352ff49be44cdb438aab9d54364eeee393a14ebe]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ib3f8f40edd3d9a93460bf7dcd081af0b0bd4a6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c64a4fe576c5fb09334faba8f6cefec9d6e72a1]

        use more SwPosition::GetContentIndex
        
        and convert an unnecessary loop into a simple calculation
        
        Change-Id: I79fb07770fdac787a95c65e5ff0d86d905f03cb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ef8762c74ae296b867966b4535243e822aafb05]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I910cdd6a14d0171082935e0de94ec1779a9626c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138997
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb9a76c697b72cf0c31d1467a862c03d08760628]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I9a0e393e755c8cb6a1b9857ecf0abbabf61a2840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138996
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Caolán McNamara  <caolanm@redhat.com>  [b91d4cf7ec844cc638dd8e02cc20e02d8f96998b]

        crashtesting: various checkGlyphsEqual asserts
        
        since:
        
        commit b9f0caad5d9e628f82d5148dfc7d2436d32817e2
        Date:   Tue Aug 23 04:13:28 2022 +0200
        
            tdf#66819: Disable ligatures with character spacing
        
        add the item causing the differing SalLayoutFlags::DisableLigatures mode
        to the key
        
        Change-Id: I4589c0430a781ca55a7479d2af446f3b5e22025b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139000
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-29  Stephan Bergmann  <sbergman@redhat.com>  [62fda78aecc8ba827dc12081b1a5873393138ca9]

        span requires a complete element type
        
        ...see C++20 [span.overview]/3 "ElementType is required to be a complete object
        type that is not an abstract class type."
        
        At least a --with-latest-c++ build against recent LLVM 16 trunk libc++ failed
        for me now with
        
        > In file included from sd/source/ui/app/sdmod.cxx:24:
        > In file included from include/vcl/virdev.hxx:24:
        > In file included from include/vcl/outdev.hxx:24:
        > In file included from include/o3tl/span.hxx:19:
        > ~/llvm/inst/bin/../include/c++/v1/span:540:38: error: arithmetic on a pointer to an incomplete type 'const SfxItemPropertyMapEntry'
        >         return iterator(this, data() + size());
        >                               ~~~~~~ ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/access.h:144:36: note: in instantiation of member function 'std::span<const SfxItemPropertyMapEntry, 18446744073709551615>::end' requested here
        >       return _LIBCPP_AUTO_CAST(__t.end());
        >                                    ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:44:5: note: in instantiation of function template specialization 'std::ranges::__end::__fn::operator()<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' requested here
        >     ranges::end(__t);
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:44:5: note: in instantiation of requirement here
        >     ranges::end(__t);
        >     ^~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:42:19: note: while substituting template arguments into constraint expression here
        >   concept range = requires(_Tp& __t) {
        >                   ^~~~~~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:48:25: note: while checking the satisfaction of concept 'range<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' requested here
        >   concept input_range = range<_Tp> && input_iterator<iterator_t<_Tp>>;
        >                         ^~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:48:25: note: (skipping 16 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
        > ~/llvm/inst/bin/../include/c++/v1/__tree:761:23: note: in instantiation of template class 'std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>' requested here
        >     __node_value_type __value_;
        >                       ^
        > ~/llvm/inst/bin/../include/c++/v1/__tree:1798:49: note: in instantiation of template class 'std::__tree_node<std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>, void *>' requested here
        >         destroy(static_cast<__node_pointer>(__nd->__left_));
        >                                                 ^
        > ~/llvm/inst/bin/../include/c++/v1/__tree:1789:3: note: in instantiation of member function 'std::__tree<std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>, std::__map_value_compare<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>, SdExtPropertySetInfoCacheCompare, true>, std::allocator<std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>>>::destroy' requested here
        >   destroy(__root());
        >   ^
        > ~/llvm/inst/bin/../include/c++/v1/map:1033:5: note: in instantiation of member function 'std::__tree<std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>, std::__map_value_compare<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>, SdExtPropertySetInfoCacheCompare, true>, std::allocator<std::__value_type<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>>>>::~__tree' requested here
        >     map()
        >     ^
        > sd/source/ui/app/sdmod.cxx:57:11: note: in instantiation of member function 'std::map<std::span<const SfxItemPropertyMapEntry, 18446744073709551615>, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo>, SdExtPropertySetInfoCacheCompare>::map' requested here
        > SdModule::SdModule(SfxObjectFactory* pFact1, SfxObjectFactory* pFact2 )
        >           ^
        > sd/inc/sdmod.hxx:45:8: note: forward declaration of 'SfxItemPropertyMapEntry'
        > struct SfxItemPropertyMapEntry;
        >        ^
        
        and
        
        > In file included from sw/source/core/unocore/unochart.cxx:34:
        > In file included from sw/inc/unochart.hxx:52:
        > In file included from sw/inc/unocrsr.hxx:22:
        > In file included from sw/inc/swcrsr.hxx:23:
        > In file included from sw/inc/tblsel.hxx:22:
        > In file included from sw/inc/swtable.hxx:24:
        > In file included from sw/inc/swtypes.hxx:30:
        > In file included from include/vcl/outdev.hxx:24:
        > In file included from include/o3tl/span.hxx:19:
        > ~/llvm/inst/bin/../include/c++/v1/span:540:38: error: arithmetic on a pointer to an incomplete type 'const SfxItemPropertyMapEntry'
        >         return iterator(this, data() + size());
        >                               ~~~~~~ ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/access.h:144:36: note: in instantiation of member function 'std::span<const SfxItemPropertyMapEntry, 18446744073709551615>::end' requested here
        >       return _LIBCPP_AUTO_CAST(__t.end());
        >                                    ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:44:5: note: in instantiation of function template specialization 'std::ranges::__end::__fn::operator()<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' requested here
        >     ranges::end(__t);
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:44:5: note: in instantiation of requirement here
        >     ranges::end(__t);
        >     ^~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:42:19: note: while substituting template arguments into constraint expression here
        >   concept range = requires(_Tp& __t) {
        >                   ^~~~~~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:48:25: note: while checking the satisfaction of concept 'range<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' requested here
        >   concept input_range = range<_Tp> && input_iterator<iterator_t<_Tp>>;
        >                         ^~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/__ranges/concepts.h:48:25: note: (skipping 11 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
        > ~/llvm/inst/bin/../include/c++/v1/span:441:15: note: while checking the satisfaction of concept '__span_compatible_range<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &, const SfxItemPropertyMapEntry>' requested here
        >     template <__span_compatible_range<element_type> _Range>
        >               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/span:441:15: note: while substituting template arguments into constraint expression here
        >     template <__span_compatible_range<element_type> _Range>
        >               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/span:391:28: note: while checking constraint satisfaction for template 'span<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' required here
        > class _LIBCPP_TEMPLATE_VIS span<_Tp, dynamic_extent> {
        >                            ^~~~
        > ~/llvm/inst/bin/../include/c++/v1/span:391:28: note: in instantiation of function template specialization 'std::span<const SfxItemPropertyMapEntry, 18446744073709551615>::span<const std::span<const SfxItemPropertyMapEntry, 18446744073709551615> &>' requested here
        > sw/inc/unomap.hxx:317:7: note: while declaring the implicit copy constructor for 'SwUnoPropertyMapProvider'
        > class SwUnoPropertyMapProvider
        >       ^
        > sw/inc/unomap.hxx:26:8: note: forward declaration of 'SfxItemPropertyMapEntry'
        > struct SfxItemPropertyMapEntry;
        >        ^
        
        Change-Id: I53d7d427890b360d87fa29e184c7836eff672ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138995
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-29  Alain Romedenne  <alain.romedenne@libreoffice.org>  [1670e6504c00b254bf0f86ed5faae5cef6b2ff40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 463c1051d96b115ca526994920de2958f522d579
          - Addition of missing literals
            
            Change-Id: Ib185d6b0d71d19270be233168cff814d8beb5291
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138825
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-08-29  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a49245e04d45735aa76ad7720657c83530ba9ed8]

        Don't position dialogs relative to other dialogs
        
        When calling setPosSize on a dialog, and there are other dialogs on top of it,
        the dialog was positioned relative to its parent dialog.
        
        Fix this, so that dialogs are always positioned relative to the main window (if there is one).
        
        Revert of/Follow up to 8750c812c9b808ee980f7e0ce0e6ce91e75e1424
        
        Change-Id: I69f189865b118f9bc20077d48591fbd9e83b014f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138994
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-08-29  Miklos Vajna  <vmiklos@collabora.com>  [e268ac208d22aef687e99a625fc32e2a03a7b873]

        xmloff: extract ExportGraphicPreview() from ...
        
        ... XMLShapeExport::ImpExportTableShape(), this way
        XMLShapeExport::ImpExportMediaShape() can reuse it.
        
        Both write an XGraphic fallback, just the name template and the format
        of the export result differ.
        
        Change-Id: Ia1217b7bc3363d3fe3fe64f2add69e5072cc08c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138971
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [8611f6e259b807b4f19c8dc0eab86ca648891ce3]

        ref-count SdrObject
        
        Which means we can get rid of the majestic hack of ScCaptionPtr
        Previously, SdrObject was manually managed, and the ownership
        passed around in very complicated fashion.
        
        Notes:
        
        (*) SvxShape has a strong reference to SdrObject, where
        previously it had a weak reference. It is now strong
        since otherwise the SdrObject will go away very eagerly.
        
        (*) SdrObject still has a weak reference to SvxShape
        
        (*) In the existing places that an SdrObject is being
        deleted, we now just clear the reference
        
        (*) instead of SwVirtFlyDrawObj removing itself from the
        page that contains inside it's destructor, make the call site
        do the removing from the page.
        
        (*) Needed to take the SolarMutex in UndoManagerHelper_Impl::impl_clear
        because this can be called from UNO (e.g. sfx2_complex JUnit test)
        and the SdrObjects need the SolarMutex when destructing.
        
        (*) handle a tricky situation with SwDrawVirtObj in the SwDrawModel
        destructor because the existing code wants mpDrawObj in
        SwAnchoredObject to be sometimes owning, sometimes not, which
        results in a cycle with the new code.
        
        Change-Id: I4d79df1660e386388e5d51030653755bca02a163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138837
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Matt K  <mattkse@gmail.com>  [25a997c15d39fb30676a375df8ea4ce1ed2e1acd]

        tdf#53530 Only show 1 error dialog instead of 3 on export to PDF
        
        SfxObjectShell::ExecFile_Impl is called when exporting to PDF, and
        the 3rd error message pops up here, so we just add a check to see
        if we're about to show the general IO error during pdf export and
        skip showing the error message there.
        
        The first 2 error messages pop up from
        SfxMedium::TransactedTransferForFS_Impl, and so we just add a check
        to see if the first error message popped up in which case an abort
        error code is returned and we then skip popping up the 2nd error.
        
        Change-Id: Ifa85ca1e451b1f87c6ddd89a98d377ea04aeaa0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138333
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-29  Roman Kuznetsov  <antilibreoffice@gmail.com>  [de37cabc120b9a00ca089d1b28bc7b1958430db7]

        tdf#150246 Show CL and threaded in About dialog in the same time
        
        Change-Id: I8d4974967e1595159251275f58d88c25b9e91e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138824
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-08-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2509337d573a8eaaa852db155962238af3a5b99]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ib1a31abd1e4fc8483a8ef799accb8a245bb6352b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138965
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Miklos Vajna  <vmiklos@collabora.com>  [cbc6e67d3c88fb6ae39c304604a98eaa504f19cc]

        avmedia: implement video crop support in the ODP filter
        
        And also import/export the video preview as well. The naming follows the
        style used for table shape previews.
        
        The preview is important, since the cropping is relative to the bitmap's
        preferred logic size.
        
        Change-Id: I6115284c1f4cf342b3296cd0ac3beb70a809fd1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138959
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-29  Luboš Luňák  <l.lunak@collabora.com>  [690458889fd875a7885b692d3204c45c5016b925]

        fix undoing range reducing to apply only to COUNTIFS (tdf#150618)
        
        Before 7674399aac661eb503d7badc53b9a4d68bd9839d the code tried
        to range-reduce all operations except for COUNTIFS, the commit added
        handling also COUNTIFS and then later undo the rare cases when it
        shouldn't be done, but the undo wasn't specific to COUNTIFS even
        though it should have.
        
        Change-Id: Ibdb6516a1ac7bc7d34f16f8a99781859e9fc7b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138880
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-29  Miklos Vajna  <vmiklos@collabora.com>  [37376f63006db97a4385856019f61d26374ab618]

        sw: prefix members of SwAuthorMarkPane, SwCaptionDialog, ...
        
        ... SwConvertTableDlg and SwLabDlg
        
        See tdf#94879 for motivation.
        
        Change-Id: I9a8be0c3f5763ea0fb9119960eb799b6ff7a0a4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138956
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-29  Sarper Akdemir  <sarper.akdemir@collabora.com>  [57f9b4b7d1ad164c56af12009ef1dafbc1be8369]

        tdf#144092 pptx import: fix import of empty cell and shape text properties
        
        For table cells and shapes without any text, text properties weren't
        correctly imported. Both the master styles and properties defined in
        the endParaRPr were ignored.
        
        It appears the current implementation does attempt to import those in
        TextParagraph::insertAt(...), after the attempt they end up in the
        TextRange('s nodes) but they are ignored.
        
        This commit implements a fix by: If the cell or shape has no text, the
        text properties are also pushed into the shape or cell's propset
        directly
        
        Change-Id: Ie425b3e9a73937a2503e47322e25f37ed9a2a6be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138651
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-29  Noel Grandin  <noelgrandin@gmail.com>  [95aea41eb9fbb99452097e5b36f09b8782c8dfff]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ifad11a8bfdaf6156017a96a9df24ecebc2ddc3ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-29  Thorsten Wagner  <thorsten.wagner.4@gmail.com>  [5bf4f36b509ae2bdc507074d53af007b4852013d]

        Prevent rounding down fontheights depending on display resolution for macOS
        
        Change-Id: Ifb0ba848de3613e49237fd1e4b4739915154f355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138744
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [b323f1fba2a7a409177f5296c6ba8b98c9e537ad]

        ofz#50729 Integer-overflow
        
        Change-Id: I9713130c6d621a4c5cc45a861170ae336a600bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138950
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [08042d2c32f86117828e50923333e9952d1d835d]

        cid#1500646 silence Resource leak
        
        Change-Id: I68ae618a2f828de0d4043cf4d986c915ac1e1a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138944
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [f4ccf5da912a8cb33971cfd2f2276e90a0571d0b]

        cid#1500658 silence Resource leak
        
        Change-Id: I799c44990d2a2cca3b843c3c64774d4d49e4a8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138946
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [02663c8ba0cfe6bf71070ed2e02d13f1ced895d4]

        cid#1500473 silence Resource leak
        
        Change-Id: Ibf6b453b77d3fc83d40b04e0003f7f009df23e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [061363cea1642ba60de32b644b73c5c9cc136596]

        ofz#50674 reduce limit while fuzzing
        
        Change-Id: I1eeb4147f6c0c56c05450291c922bcd04017881a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [1ad7fe75cccafed2be3cd6628b931762067a56e8]

        cid#1500491 silence Untrusted loop bound
        
        Change-Id: I508337b8a8482b5aaa056a564a0dfa39cbbb4b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [18f16d9d2516b3f7c0edfef05ffe66629c598c36]

        cid#1500510 silence Use after free
        
        and
        
        cid#1500471 Use after free
        cid#1500604 Use after free
        cid#1500617 Use after free
        
        Change-Id: Idd86c8c81dd6f0afb6f055fadee778559cb6dba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138945
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [43644510f29ff15da2fd87c7a6ea654e9f799efc]

        cid#1500441 silence Resource leak
        
        and
        
        cid#1500631 Resource leak
        cid#1500695 Resource leak
        
        Change-Id: Idf8aa7b44c6ba3aafcde7b7d3a3522224fe3f865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Noel Grandin  <noelgrandin@gmail.com>  [e919ed82a5c63902a4daf48be08ed6fb583e0275]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: I3734c0e2f323720afa32e7ac2dd46f53bdea4e48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-28  Caolán McNamara  <caolanm@redhat.com>  [6d0d3f97741194983c52e2a33449485b80c8ed3d]

        cid#1512438 Dereference before null check
        
        Change-Id: Ibaf4d9250064255dc1bcf2e334c43d1260c295c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138940
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c1156e89b8993c5f71af80ad3919bd1e666a2905]

        Fix typo
        
        Change-Id: I4e21288bdf4ceaf36edb49d1f34ce4ab05ed7415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138656
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a739ad1304a73340f6e68ed7e03e7a1e84ccc892]

        Fix typo
        
        Change-Id: I99e5a87c8ee1667bbcc96051ecb25f1bf310055f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138934
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-28  Noel Grandin  <noelgrandin@gmail.com>  [472aacb9a34128ee46ae4f68e4ab0576b1ea7bbf]

        flatten some code in SwCursorShell
        
        Change-Id: Iae9d6cbfd771721a93b2d6fa4aa0e0631035cb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-28  Thorsten Wagner  <thorsten.wagner.4@gmail.com>  [87318da781b429abd8261a8b64bb8d72c79b9da2]

        Adjust button text colors for macOS Big Sur
        
        Change-Id: I1bbdcc97d65afbebce0b2d2e7530f156aa037315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138799
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-08-28  Aron Budea  <aron.budea@collabora.com>  [e3224c23f55f9fa489838bdf3b30b88a798ec33a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 97a0bfd2eda30586e70a090a8ffc1c83f49e1295
          - tdf#149980 updated Ukrainian dictionaries to 5.8.0
            
            Change-Id: I7f71818a3055dd46f5d2cb572f940455fe21b586
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/138914
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-08-27  Noel Grandin  <noelgrandin@gmail.com>  [d152455237f548ed3f3d87689b1f558aa1c057c1]

        crashtesting ooo117844-1.docx
        
        regression from
            commit 59785c0237f2bc5eaf9e9742bdf30136f3b3d2ba
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Aug 15 15:24:32 2022 +0200
            pass SwNode and sal_Int32 to delBookmarks
        
        Change-Id: I2d552cf1bc70850e09b354e11644d59013061377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138935
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-27  Aron Budea  <aron.budea@collabora.com>  [7bc61569e25fe0c32063896eced72219cc4fb3f5]

        Add Persian (fa-IR) dictionary to installset
        
        Change-Id: I7abf38be5c8d8c8bfb7eb3a756695054b4275f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138892
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2022-08-27  Aron Budea  <aron.budea@collabora.com>  [1d5b0b89e2f757709d59b3cfdc5a7a23ec4d8326]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1bee012fc52a625fe0e0abec071ed1b002fac918
          - Add Persian (fa-IR) dictionary
            
            Change-Id: I906c924dfe346898f7f5c69d2c1a3e6ae9424651
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/138891
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2022-08-27  Aron Budea  <aron.budea@collabora.com>  [9e1b93e2d586ce6c701c506300f8e51acbfc6168]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d201d1180ce044fe49e167d0d5b6d182a0f2850d
          - tdf#142152 replace keywords in Spanish dictionary description
            
            Change-Id: I806c1d8acdacd450454dde13fc507d15edd19e58
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/138915
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [310a52490749637cd6a6485407fbd1e5e143abe9]

        cid#1500688 silence Dereference after null check
        
        Change-Id: I53ffb3537b2ac5618a9776c946eebf866f725cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138929
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fdb7e4b97f20e80dadb0c0b24baf5512040cd20d]

        Fix typo
        
        Change-Id: I70e12e47fd2f72ce68f388861bdbf03cbad3c87f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138918
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-27  Hannah Meeks  <hmeeks4135@gmail.com>  [70c69ba1c48a42b763dd5426bd4f008d950ad967]

        VBA: make debugging of VBA tests much easier
        
        When basic fails it displays a MessageBox - which is immediately
        cancelled. With this we can easily see what it would have said.
        
        Change-Id: Icd0719caa87ede4217fa9731671e36f380cba702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137897
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-27  Hannah Meeks  <hmeeks4135@gmail.com>  [aa1e77cd1733ba448eaa04fc1853e47a7dc200b3]

        VBA Add test documents for XTable
        
        Change-Id: Ia12c055addda545574c33a55ba758b3f1d5b0b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137852
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [341d1462c23214a63293f62c6d5d42a27fd8e6fc]

        cid#1500596 silence Resource leak
        
        Change-Id: I4600c9cd0f7fdea698750ca416fc7f46dcebf23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [b9cf72d76014854753f5c609208f0784a60dbd45]

        cid#1500569 silence Explicit null dereferenced
        
        Change-Id: I55b765f12f0e77f1f4ef4cbce9d6f2c9b661d370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138927
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Noel Grandin  <noelgrandin@gmail.com>  [e3e49d07e2feebcec631eed98bea5e3f6f6ab572]

        sal_uLong->sal_uInt32 in ValidationEntry
        
        we are already using sal_uInt32 in various places, and passing
        this through SfxUInt32Item
        
        Change-Id: Iea06b59edc56632b823729462516a6b5fb74e28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138917
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-27  Noel Grandin  <noelgrandin@gmail.com>  [56a654ae337e48f5845252e91a95cf9a63ed3388]

        sal_uLong->sal_uInt32 in XclExpDV
        
        we are already passing this through ATTR_VALIDDATA which is
        a SfxUInt32Item
        
        Change-Id: I491a85379a2f4900c70f3eb92f5be3f3c16a1d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [d341313d3107f0480523378a464252585b17403b]

        cid#1500545 silence Explicit null dereferenced
        
        Change-Id: Ie8cb87ab80a148a79510591fcd089c0bc230612e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [ea892cc0ea96f94c5a51227b897694f18b2b785b]

        cid#1500523 silence Resource leak
        
        Change-Id: I9c2d026cb71615ac3121f47e47a6b0b163e820f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [aa81005151c4c266173cf7460b4db87339c921f5]

        cid#1500516 Explicit null dereferenced
        
        Change-Id: I3fda15451e55d4ee1b296cddb1f6933d81faae3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [97622503fe7ed58820b7dfc813b3b3ea8f5ad057]

        cid#1500455 Dereference after null check
        
        Change-Id: I5cbc1d182821b88514077db5ff2c436f62372bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138923
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [d455bf3665a4539ec64c6cf6ece76437a2c4cf75]

        cid#1500408 silence Resource leak
        
        Change-Id: Ic969e0dac9d5fceb2c14daee37eee44305c15220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138922
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [45e54afffa40c1f2bf3c98a3229a2137c050c0fc]

        cid#1509234 DCN: Don't Catch NullPointer Exception
        
        and
        
        cid#1509229 DCN: Don't Catch NullPointer Exception
        
        Change-Id: I113de964ff07fc771ac64acb8583341cd518d0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138921
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Caolán McNamara  <caolanm@redhat.com>  [995ae3dc84a9c220b62086664c8ad4a161401cc7]

        ofz: -Wp,-D_FORTIFY_SOURCE=2 in cairo a problem with msan
        
        Change-Id: I5c7bc7b9a370ee3a5c7dd3f7a2c92c5f2b193d58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138920
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Povilas Kanapickas  <povilas@radix.lt>  [85ab77d241ce3bc6adca26d541873583bce2d9d0]

        sd: react to touchpad zoom gestures in ViewShell
        
        Zoom touchpad gesture now works in the main Impress window to zoom in
        and out of the main slide.
        
        Change-Id: I50e2fef668b1670e446068200f65337ec5ab1a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-27  Khaled Hosny  <khaled@aliftype.com>  [f5c3a215fdd5505ebba8ae341d2146c3a4f739e3]

        vcl: Don’t leak hb_set_t
        
        Looks like I have a habit of never destroying these.
        
        Change-Id: I58e77908c68553222e34600aafb6fee186000a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138893
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-27  Eike Rathke  <erack@redhat.com>  [1581a631464254bbc428649c35b23c79df837ed2]

        Do not gather function data over and over again for each formula input
        
        The function list changes only if switched to/from English
        function names or if reset for AddIn config and only then needs to
        be rebuilt. In all other cases simply reuse a once obtained data
        set and only append the dynamic document content.
        
        Change-Id: I5b1d14205e2933010a1b4382c985594d75802742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138890
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-27  Hossein  <hossein@libreoffice.org>  [d05c176cc022f1b771f7c064f6ce74e9f8c27a1b]

        tdf#150457 Fix crash on hovering removed footnote reference
        
        The regression was caused by 402f36efb215338ad545caa65d39fb8a39685ea1.
        Before that, 0aa0fda64057647219954480ac1bab86b0f0e433 changed the cursor
        jumping behavior to fix tdf#81226. The goal was to make LibreOffice
        behave as described in the description of the issue:
        
        "When your cursor is on the last line but not at the end of it, simply
        press the down arrow to go at the end of the file (end of that line)."
        
        The same behavior was achieved for pressing down on the last line.
        
        The above patches allowed removing the footnotes and their numbers
        (except the first number) while the reference were still present. Then,
        on hovering a removed footnote reference, a crash was happening. It
        should be noted that even with this patch, removing the first reference
        number was not possible.
        
        This fix limits this behavior to anywhere other than inside a footnote.
        In this way, it prevents crashing.
        
        With this fix, the behavior of the cursor goes back to what it was
        before 0aa0fda64057647219954480ac1bab86b0f0e433. The user will not be
        able to select all the footnotes at once. Also, removing footnote number
        will not be possible.
        
        It is worth noting that not being able to select all the footnotes at
        once prevents the user from changing the characteristics of the
        footnotes all at the same time. Also, not being able to remove the
        footnote numbers, prevents the user from having footnotes with custom
        numbers written manually. Both of these actions are possible in MS Word.
        The other difference is that by going up, one can go out of the footnote
        section in MS Word, but this is not the case for LibreOffice.
        
        A UI test is added to make sure the crash will not happen again. The
        test can be run by:
        
         cd sw && make -srj1 UITest_writer_tests2 \
          UITEST_TEST_NAME="deleteFootnotes.tdf150457.test_delete_footnotes" \
          SAL_USE_VCLPLUGIN=gen
        
        Change-Id: I1ce7d2189355f6763b6f31219e00516ff7a8164e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138562
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-27  Michael Weghorn  <m.weghorn@posteo.de>  [903b8f8524b8c84eced3ccbf7cfec9c5b9015f4b]

        gtk: Fix gtk4 build after f2bd19f672023 and e6bed4293814d
        
        Other than their gtk3 counterparts, the gtk4 variants
        of `gtk_gesture_zoom_new` and `gtk_gesture_rotate_new`
        don't take any `GtkWidget*` param any more:
        
            In file included from .../libreoffice//vcl/unx/gtk4/gtkframe.cxx:12:
            .../libreoffice//vcl/unx/gtk4/../gtk3/gtkframe.cxx: In member function ‘void GtkSalFrame::InitCommon()’:
            .../libreoffice//vcl/unx/gtk4/../gtk3/gtkframe.cxx:1025:42: error: too many arguments to function ‘GtkGesture* gtk_gesture_zoom_new()’
             1025 |     m_pZoomGesture = gtk_gesture_zoom_new(GTK_WIDGET(pEventWidget));
                  |                      ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
            In file included from /usr/include/gtk-4.0/gtk/gtk.h:145,
                             from .../libreoffice//vcl/unx/gtk4/transferableprovider.hxx:14,
                             from .../libreoffice//vcl/unx/gtk4/gtkframe.cxx:10:
            /usr/include/gtk-4.0/gtk/gtkgesturezoom.h:46:14: note: declared here
               46 | GtkGesture * gtk_gesture_zoom_new             (void);
                  |              ^~~~~~~~~~~~~~~~~~~~
            .../libreoffice//vcl/unx/gtk4/../gtk3/gtkframe.cxx:1034:46: error: too many arguments to function ‘GtkGesture* gtk_gesture_rotate_new()’
             1034 |     m_pRotateGesture = gtk_gesture_rotate_new(GTK_WIDGET(pEventWidget));
                  |                        ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
            In file included from /usr/include/gtk-4.0/gtk/gtk.h:141:
            /usr/include/gtk-4.0/gtk/gtkgesturerotate.h:46:14: note: declared here
               46 | GtkGesture * gtk_gesture_rotate_new             (void);
                  |              ^~~~~~~~~~~~~~~~~~~~~~
            make[1]: *** [.../libreoffice//solenv/gbuild/LinkTarget.mk:334: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/unx/gtk4/gtkframe.o] Error 1
            make: *** [Makefile:289: build] Error 2
        
        Change-Id: Ia2f0f76b6353c34baef9fd6adcafe4af07bec543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138888
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [327a87f51d5a35d6dee0e9038b26f989052f6e0c]

        tdf#124300 survive update all
        
        unsatisfactorily just route-one avoiding null derefs
        
        Change-Id: I66153f3a16d53f245d538c407c512557b5ececc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [872ea3ac4a45700f1cd23fec48b700ee10fda613]

        bump scrtf input len some more
        
        Change-Id: I3690f2ec60eed58bba149c322e92b39cf2f8ba32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138887
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  PoonamShokeen  <poonamshokeen7@gmail.com>  [08a63a88543b0da68380090b655e777bd2b980be]

        tdf#145538 Use range based for loops
        
        Change-Id: I144d020c6c57937caa800f019ab175597ed8ede4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137538
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-26  Povilas Kanapickas  <povilas@radix.lt>  [e6bed4293814dd58f0a7d050e8057e717d03faab]

        vcl: implement touchpad rotate gesture support on gtk backend
        
        This change is enough to support both touchpad and touchscreen gestures,
        but currently GDK_TOUCH_MASK is not enabled, so only touchpad gestures
        are supported.
        
        Change-Id: Ia36b64cd891321d3a5420ea81dca236c936d9af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138790
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Povilas Kanapickas  <povilas@radix.lt>  [f2bd19f6720239db228cd4388be8e928505c51b6]

        vcl: implement touchpad zoom gesture support on gtk backend
        
        Note that this does not support touchscreen gestures. Enabling support
        for touchscreen gestures requires enabling GDK_TOUCH_MASK which has
        higher regression potential for touchscreen users, so it has not been
        done yet.
        
        Change-Id: I1baab36804230484394e638bf8bfb8c7a7ddabe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138789
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e1a32c881a7230481ecc8659d587e3621213e10f]

        tdf#142031 - Collect all the characters for the formula suggestion auto input
        
        Change-Id: Idec350b09279f42f2ca42a1c02082d8e9e4207b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138702
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-26  Noel Grandin  <noelgrandin@gmail.com>  [26958d40f48645abce7a6211394b7697d1385a5f]

        use more SwPosition::Assign
        
        part of hiding the internals of SwPosition
        
        Change-Id: Icc7f28a2c64e78bb87af9adab4a3e4e08ac6630d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Mike Kaganski  <mike.kaganski@collabora.com>  [2a3e8d220a244dd15c28d52895848546a915feda]

        lok: use ".uno:SidebarDeck.DeckName" for the rest of the decks
        
        Allows to avoid introducing a dedicated UNO command for each and every deck.
        
        Change-Id: Icc9b2fa9ec3ac495f022970d412d9b19ec000a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138883
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-26  Michael Weghorn  <m.weghorn@posteo.de>  [dce8fda483f38eb8624c89c20c07a1af68e3952e]

        qt a11y: Set the (un)selected child in selection add/remove event
        
        Qt itself sets the child index when sending
        `QAccessible::SelectionAdd` or `QAccessible::SelectionRemove`
        events for its own widgets and the handling in its AT-SPI adapter
        assumes that this is the case, so do so here as well.
        
        Work around QTBUG-105988 [1] by using the
        `QAccessibleEvent` ctor that takes a `QObject*` instead
        of the one that takes the `QAccesibleInterface*`, since
        calling `QAccessibleEvent::setChild` in the event object
        would otherwise break things.
        
        When used in combination with the suggested Qt changes to
        send AT-SPI `SelectionChanged` events for these event
        types and `QAccessible::SelectionWithin` [2] [3],
        the suggested Qt changes to add support
        for the AT-SPI selection interface [4] [5] and a
        corresponding LibreOffice demo change [6] that implements
        the suggested `QAccessibleSelectionInterface`, this
        makes Orca announce selected Calc cells for the qt6 VCL
        plugin.
        
        [1] https://bugreports.qt.io/browse/QTBUG-105988
        [2] https://codereview.qt-project.org/c/qt/qtbase/+/429146
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/429147
        [4] https://codereview.qt-project.org/c/qt/qtbase/+/428566
        [5] https://codereview.qt-project.org/c/qt/qtbase/+/428567
        [6] https://gerrit.libreoffice.org/c/core/+/138750
        
        Change-Id: Id1cd28aa8cab208d7713ddd46ede5a7acd73334a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138882
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-26  Michael Weghorn  <m.weghorn@posteo.de>  [f46ae9132d562ac3f881a663a70c50d27da4049a]

        a11y: Align SELECTION_CHANGED_REMOVE doc with reality
        
        While the documentation for
        `AccessibleEventId::SELECTION_CHANGED_REMOVE`
        said that the removed item is set in
        `AccessibleEventObject::OldValue`, all places that set the removed
        item in that type of event actually set it in
        `AccessibleEventObject::NewValue` and e.g. winaccessibility's
        `AccContainerEventListener::HandleSelectionChangedRemoveEvent`
        also handles the event with that assumption, so adapt the
        doc accordingly.
        
        (There are also various places that send `SELECTION_CHANGED_REMOVE`
        events without setting any of the two.)
        
        Change-Id: Ib49068715d9436a99e79d13f2c9720a52a094a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138881
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cd8e893355ac838dcf5ce92bc6a456b7246475f]

        make the parameter to SwTableNode::MakeOwnFrames optional
        
        since most of the call sites seem to be just creating a temporary and
        then ignoring it
        
        Change-Id: Ia50cdd4ce5eca665351d3f76e395178bab827b08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [5cbbad4a6e3138de17093e7fdf0b4b9d5d975e53]

        crashtesting: only warn about outsize scretch value
        
        ooo60911-3.odt renders fine with todays freetype and cairo, if
        there are similar problems elsewhere, better to cut off in
        CairoTextRender::DrawTextLayout instead
        
        Change-Id: I39ed574d441d929f307ca72290a52d2dc41f8356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138878
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [ba9c6ad27d76de2cc4bc43cc2836a9680a3e1a9b]

        freetype 2.9 was relesed in Jan 2018, drop workaround for <= 2.8
        
        Change-Id: Iaf95faa15d56e8f26ed57cb4744b039a18223c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [5c0ac89bfe0e412fa335b562e63e380f0be14cd9]

        crashtesting: empty brace init of o3tl::enumarray doesn't zero each element
        
        so the stretch used to layout fdo66401-6.docx is random, leading to
        sometimes too much stretch for cairo/freetype to handle and the
        conversion crashes. A problem since:
        
        commit d51db77c8d87f210785a8a8c6dd875f7bacddb3c
        Date:   Tue Oct 15 01:57:12 2019 +0300
        
            Remove some memset calls
        
            Replace them with default initialization or calloc
        
        Change-Id: I49408eee6c7e36bd9c98cbb10c7f95a57c0f7a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138876
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a9cd0104c5d60f156b974f0c297088c20ba9c5e]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: If411d65658bc42055527eb2ba3508b0997361db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138874
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f322d29bed638cfc19a7eed6bb22a70ec762c51]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I90e950897a079823820bbb8849c68548f1698df6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [fdc5ac4b0e4e1a964c259a5f5056041346dbf3cf]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I5ff23a9aa7c40d10a719d3f38af5c4c3f39ca2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138870
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [851739459484a710ec1599a3bafef35689c0bcde]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic458f63b8914993055c19ece159ad525a8ed9bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138869
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [456ffaede10d01cd46f551a13832ac2cb49a4bc7]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Id1f00a87b1097e7cc938450acf69e3bf5b71f167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [9deecb5e4ba12c94b2dc8f331eb512296e1ab702]

        improve ImplSubPixelToLogic sanity check
        
        Change-Id: Iae8620e3ef4f989555e0014459fcd8f152db843b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138872
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [6e802bc29d3a47e1d5b63d674dd4058503c00b58]

        crashtesting: avoid negative scaling
        
        regression from
        
        commit 1fa731d03ba0f22cb9392a578124ea977eaab2e9
        Date:   Tue Aug 16 23:39:53 2022 +0100
        
            tdf#150462 don't prescale dxarray before using DrawTextArray
        
        do the negative scaling checks as was done originally
        
        seen with:
        bugtrackers/odg/tdf35913-4.odg
        bugtrackers/svg/kde82509-1.svg
        bugtrackers/svg/fdo45001-3.svg
        
        Change-Id: I9eba78218d4676d60375fb9e9403be4e9bd5182a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [95ec9637d388220082fd622f448de2fb4b2d439a]

        cid#1500411 silence Resource leak
        
        Change-Id: I42272620ed046af85f91ac1f5dfe524e7832e767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [a82faa49ead9b0d43a7fa90488945dc3a7e87b60]

        retain precision until the end
        
        Change-Id: I1986bb5a5d9445ae4efaa54f0a65a35a0a5d5335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [fa2bf7313aa9ca0f14da0ae50c54c26972de5a89]

        cid#1500514 Uninitialized scalar field
        
        Change-Id: I54cf8f0e5d77b62d857f302d702c4bb99cc36ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [f3ee5a0d2ee88bcde84cdb43e9b22bbc6c0be1af]

        cid#1509239 DCN: Don't Catch NullPointer Exception
        
        and
        
        cid#1509234 DCN: Don't Catch NullPointer Exception
        cid#1509229 DCN: Don't Catch NullPointer Exception
        cid#1509219 DCN: Don't Catch NullPointer Exception
        cid#1509216 DCN: Don't Catch NullPointer Exception
        
        Change-Id: Iab1512b4e5ecd632104a58b1fc09ef150825f498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138859
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Miklos Vajna  <vmiklos@collabora.com>  [916848d877a788d02e2e7c980872314839101798]

        tdf#149971 avmedia: implement video crop support in the gsteamer backend
        
        If a media shape had cropping defined, we already took that into account
        when presenting a preview for it, but not during video playback.
        
        The reason for this is that the preview may be set by a file importer
        (e.g. PPTX) explicitly, in which case the preview is a bitmap we get
        without any video processing.
        
        As a start, implement video crop for the gstreamer backend (used on
        Linux), and also pass in the media item (containing crop and other
        properties) both during the edit view (MediaWindowImpl) and presenting
        (ViewMediaShape). We pass in the whole media item, so in case later
        other filters (e.g. black-and-white) are wanted, we have all that info
        in the backends already.
        
        Other backends (avmediaMacAVF and avmediawin) are untouched so far.
        svx/qa/unit/data/video-snapshot.pptx is modified to have a yellow border
        when cropping is unimplemented, which is now not visible with the
        gtreamer backend, matching PowerPoint behavior. PPTX export was working
        out of the box already.
        
        Change-Id: If26b7a4391bcffe9cbddd9933e1bab69be52924e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138867
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [2a7a576d19b9c212fd6f906f5e275fdf2266608e]

        cid#1500451 silence Resource leak
        
        Change-Id: I80851372e8cb27ada07cfacd2294287e9d7df965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138865
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [f0c07b826c34dea116ba8f4cbd6dc17759054b1e]

        cid#1500578 silence Dereference after null check
        
        Change-Id: I693efc4707d8ce8e0aacb43f86581cb4fcbdc1df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [3968bd07f3052c5ff90ed173c851e62d551e4012]

        cid#1500669 silence Dereference after null check
        
        and
        
        cid#1500619 Dereference after null check
        
        help coverity out that there is only ConversionDirection_FROM_LEFT
        and ConversionDirection_FROM_RIGHT
        
        Change-Id: I47c4c2d1a0627a303b2f82c2905e6f67d0602b63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138862
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [58931af8d567c532a27f548bdbbde75a203b0c17]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Id8449baac2a17a8a6a7b89a083fa7071636d1222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [b4339ccd5e161ec156d67babd4095a1b55f315fc]

        cid#1500704 silence Resource leak
        
        Change-Id: I5ab44c6aca318a56e63b8bba7dda51b4ec534a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [1d26a480fa2920c1e705b45ceb53466a6a6b013a]

        cid#1509211 silence Explicit null dereferenced
        
        Change-Id: I5f1c1d061a59b3edaa62b988fcbbc8dd6be0093b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138860
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Mike Kaganski  <mike.kaganski@collabora.com>  [dbe125fce5d226641bf84ac3be12ea88c41f6d91]

        tdf#150489: Drop Elements docking window
        
        and make uno:ElementsDockingWindow open the respective sidebar panel.
        
        Change-Id: I9736d6804c579b83404636d5e327c49c2fdeb914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138458
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-26  Eike Rathke  <erack@redhat.com>  [ae975b3ddab520906ead4314cef1752be999ad6f]

        Resolves: tdf#150371 Scan autocorr dirs for language tags to add to list
        
        Such that dropping an acor_art-x-mylang.dat file or with any other
        valid language tag creates a language list entry if none exists
        yet, so it can be chosen in character attribution and the
        autocorrection data be used.
        
        Change-Id: Idea200fd07dd821559db65c669a8c8e10af064f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138844
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [e8cdc1358ecebc285ccb2baa33496235661d9454]

        keep nXOffset as double
        
        Change-Id: I5a67af97c04e74fed8aa457261c4a7dd9ae79c17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [f83019d9098196e0d7dd1dd4a05cf5137cc1bceb]

        aAdjOffset is derived from a DevicePoint, so keep it as a DevicePoint
        
        Change-Id: Id05963df6ab96ecfdc28c4463415e61b796f8fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138852
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Povilas Kanapickas  <povilas@radix.lt>  [85b65b90ac10d39190097af87a2de609e87eea9c]

        vcl: implement rotate gesture infrastructure
        
        This change implements internal infrastructure to pass rotate gestures
        from low-level sources to the consuming GUI widgets. The API follows the
        established begin-update-update-...-end event convention that is used on
        various platforms.
        
        The API should be enough to support bouth touchpad and touchscreen
        gestures, as long as the underlying low-level source exposes enough
        information. The hardware drivers usually expose touchpad gestures
        already recognized whereas touchscreen gestures come as a set of moving
        touchpoints and application needs to figure out their meaning itself.
        Many toolkits recognize both and offer a unified higher-level interface
        that can be used by us.
        
        Change-Id: Iae667b3248d6f78bfb1eef755af6bc996432b6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138788
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-26  Povilas Kanapickas  <povilas@radix.lt>  [474414919c102f2973d2ed9815f997fdb1f30d9c]

        vcl: implement zoom gesture infrastructure
        
        This change implements internal infrastructure to pass zoom gestures
        from low-level sources to the consuming GUI widgets. The API follows the
        established begin-update-update-...-end event convention that is used on
        various platforms.
        
        The API should be enough to support bouth touchpad and touchscreen
        gestures, as long as the underlying low-level source exposes enough
        information. The hardware drivers usually expose touchpad gestures
        already recognized whereas touchscreen gestures come as a set of moving
        touchpoints and application needs to figure out their meaning itself.
        Many toolkits recognize both and offer a unified higher-level interface
        that can be used by us.
        
        Change-Id: I529afcc60459455616de0145fe20077a4dcf3983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138787
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-26  Noel Grandin  <noelgrandin@gmail.com>  [5f891974bfb27bacd5fc3d623463204e872fffad]

        simplify SvxShape::Notify a little
        
        (*) the logic at the bottom was very hard to read
        (*) by the time we hit the bottom of the method, we know pSdrObject
        cannot be nullptr
        
        Change-Id: I718d655f4e477bb3edaaa3f41412fb16c7336017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138846
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-26  Miklos Vajna  <vmiklos@collabora.com>  [9a6293bec8d1902b1f2ff2028c95c6b5bb950a35]

        CppunitTest_sw_ooxmlexport16: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ie85ede4f098ab659d85eb3e317c13d5701a16dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138843
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d9ed7e3e3301664d5f7bbe8cf6ba42bdfd78e3d0]

        Fix typos
        
        Change-Id: I28943475fe35aadab44b8bd2a87f1ea84c49dff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138857
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [db4535c0b060974667f2607a234c79d7a2cbc632]

        Removed duplicated include
        
        Change-Id: I6852fe11a142d13c71e111b3e4747cd1ca0850b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138856
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-08-26  Khaled Hosny  <khaled@aliftype.com>  [8f058de233e5110720daa5b42e0c66e7c3b2c31f]

        FeatureCollector: Drop redundant check
        
        HarfBuzz handles this for us, and it more future-proof this way.
        
        Change-Id: Ia8a65f0363a05c74a718a1a9f7d6df6c84373f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138853
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [6895bd63359f9d3ff7de0eea985c8171aef245f9]

        aStartPt is derived from a DevicePoint, so keep it as a DevicePoint
        
        Change-Id: I85f4275593fe491bf5ba06d334312881367ceacf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138851
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [d147ef14ac3d3250bd9039a47a9b819e7e23315a]

        nWidth is set from newWidth which is DeviceCoordinate
        
        Change-Id: I9d28fa57847b71383baa4b48d51a176017c0132f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138849
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-26  Caolán McNamara  <caolanm@redhat.com>  [100fe8a3a1724f1a5f834da11e17d1641be20994]

        automatically set TextRenderModeForResolutionIndependentLayout if we scale
        
        Always render glyphs with a mode suitable for rendering of
        resolution-independent layout positions if we scale the text positions.
        
        The idea being to typically continue to use the system defaults for font
        settings for UI elements, but where we are rendering into application
        canvases where there's a mapmode set then automatically use a good mode
        to render that.
        
        Change-Id: I0e5857e377da72ae1a2ede1d88d6408819fc9200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138324
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [33c6dcfaab35a70f8794a67d31fbec636cb485d5]

        tdf#150594 - Prevent crash while searching for the next outline node
        
        Change-Id: Ia83968b26f0053815c0da9910aa00f9dde577246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138850
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-08-25  Caolán McNamara  <caolanm@redhat.com>  [84629220ad7d7897f57070b4aba6a3cbaef756aa]

        ofz#47118 Timeout
        
        Change-Id: I8bb03b567acd4419aff15267d936298378ca03d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138848
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Justin Luth  <jluth@mail.com>  [3e3328987b69a2a549d24c79ee71b353b9a3e288]

        tdf#109285 sw numbering: RemoveLeadingWhiteSpace from all paras
        
        Change-Id: Ie834b9c10c9a6cfd7971c7713c5684157477acc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138807
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-25  Noel Grandin  <noelgrandin@gmail.com>  [f5eccd1ecf67daace793fb7c856b4429345a9338]

        add version of SwNodes::ForEach that takes SwNode params
        
        instead of SwNodeIndex. Part of the process of hiding the
        internals of SwPosition.
        
        Change-Id: I86f3eed9b614295857eb9219d76f3cd00c48a634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Noel Grandin  <noelgrandin@gmail.com>  [d7234feac18dbb94fef310e8c241428426b27717]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I86da72d648ba006f55fcec86854e5188720a1156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Khaled Hosny  <khaled@aliftype.com>  [3a541e3ba663485f94caf2803a05f7109653dce8]

        FeatureCollector: Fix parameter code for named parameters
        
        The code are 1-indexed (since 0 means disabled).
        
        Change-Id: I1d4ed80ba91191645305aadbbbb2d621116c5d36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138842
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-25  Michael Weghorn  <m.weghorn@posteo.de>  [8ce3d4f8b000e11d63d37546c5f574e57db46551]

        qt a11y: Forward text selection change event as such
        
        Change-Id: I7e208d964c5b5badb0a3ea3a19c3ca3cc7fa4ff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138838
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-25  Julien Nabet  <serval2412@yahoo.fr>  [653d098a00f737e79f2e1ea81978320b2d5d27cc]

        tdf#150561: Page dimension don't match paper format in Print Preview
        
        ...like claiming 210x148 to be A4
        
        Page size may have changed so sync mePaper with it
        
        Change-Id: I7d7329bbacfb2f0bd56e495b7390eedebecee02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138736
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0db029cd33fce069d168853fd07c801162aef5a]

        use SwNode instead of SwNodeIndex in CorrAbs/CorrRel
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Id00dc63fd30ea9cf015b9d5f69ee8eb82dc52228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138834
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e6afb0b2c0f9020b3144657f11b30c8c28bf67b]

        use more SwPosition::AdjustContent
        
        part of hiding the internals of SwPosition
        
        Change-Id: Ie42ffa1bdea93dc351bf4fa46a8cab080e1616c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Caolán McNamara  <caolanm@redhat.com>  [35e4647689b1663a6e5a13f7ab8aebb0165e4ab2]

        tdf#150507 reenable slight hinting for cairo with ResolutionIndependentLayout
        
        it was disabled because of:
        tdf#150145 text appears to have a row of pixels cropped out
        which seems to be the same issue as
        https://gitlab.freedesktop.org/cairo/cairo/-/issues/390
        
        reenable, drop CAIRO_HINT_METRICS_OFF and emulate a proposed solution of
        https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/235 by
        hacking in a route to disable CAIRO_ROUND_GLYPH_POS_ON
        
        Change-Id: I3c9f982c9737b84fe0ee6b645f507e1226807d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138810
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dd4b8c6535340eec1e94bca9d9635243cdf51d8]

        regression in SvxShape::Notify
        
        from
            commit 526f0fce45fb014b09057403ae37c125e5a18655
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Apr 9 12:05:16 2021 +0200
            tdf#130326 speed up opening XLSX
        
        which resulted in things staying alive too long, affecting an upcoming
        patch of mine
        
        Change-Id: I52a0b35c9be55a554885a39d9e0710379304766b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138811
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Miklos Vajna  <vmiklos@collabora.com>  [b6f0fd6a2f459ead2268e07bfd86db7e303b323f]

        Related: tdf#149971 avmedia: add doc model and render for crop of media objects
        
        It is possible to provide an explicit preview of media objects since
        commit 8fa1d453c94cdbb03dac646fb8db2ebd1a0e84bd (Related: tdf#149971
        svx: support explicitly provided snapshots for media shapes,
        2022-08-24), however they can't be cropped.
        
        This means that media shapes from PPTX with cropping show unexpected
        content and can also have a buggy aspect ratio.
        
        Extend avmedia::MediaItem to store cropping and take it into account
        when returning the preview bitmap in SdrMediaObj::getSnapshot(). PPTX
        import works out of the box, as oox/ already tried to set a cropping
        property on the media shape.
        
        This is just the preview, the cropping of the video itself is not yet
        implemented.
        
        Change-Id: I8db3e0dcf252613d56eb0e6139adf097e53b15cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138808
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-25  Michael Weghorn  <m.weghorn@posteo.de>  [9d2c9a592ad697fd332b9bccb63e30c955f49422]

        qt a11y: Work around Qt ignoring ActiveDescendantChanged events
        
        While Qt has a `QAccessible::ActiveDescendantChanged` event type,
        events of that type are just ignored in Qt's AT-SPI adapter [1].
        
        Work around that by sending a "focused" event for the child
        instead, for which handling inside Qt has been added in [2].
        
        While adding support for properly handling
        `QAccessible::ActiveDescendantChanged` in Qt might be
        worth looking into at some point, this appears to
        work just fine for now and e.g. makes Orca announce
        the focused cell in Calc when moving between cells using
        the keyboard in the qt6 VCL plugin.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=0131dbd2f95449c09758208d8b190c9238a5c46a#n1121
        [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=f3509565480107c2587212f7d55cc5f92facc417
        
        Change-Id: I809695de427b6438d37a5a4840044e7ca3d4cd08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138809
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-25  Eike Rathke  <erack@redhat.com>  [9c3c564659320fb24d2a9c230464f06cf855a136]

        Resolves: tdf#150599 Move obtaining data into loop again
        
        Regression from
        
            commit a23a7eea5cfcdc50d09be248828cb1e6293e5ebb
            CommitDate: Sun Dec 26 20:36:26 2021 +0100
        
                Avoid OUStringBuffer::toString where possible
        
        that erroneously also moved obtaining the data string outside the
        loop, whyever..
        
        Change-Id: I329108d42db43c1ab22ba82650d801e595dd7ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138805
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-25  Tor Lillqvist  <tml@collabora.com>  [2654a29a359e50029965054d187de550a795fb69]

        Fix thinko
        
        Change-Id: I0cfd501189275ad5558e6ceeb0fb479b4d2e5835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138804
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [83e53d664f3c4a476e6e855119b019a2ae691a7c]

        vcl: test removeMnemonicsFromString()
        
        Change-Id: Id0a84fb5cb9fa2f6f286ffeab1e1baea641d677a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138728
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [9481156090d0b455c6b35eaadd363f47c24b8086]

        vcl: rename GetNonMnemonicString() and make it standalone function
        
        Renamed GetNonMnemonicString() to removeMnemonicFromString()
        
        Change-Id: I272714f97bb6d9174360631c18c4fd9bb485698e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138103
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-25  Khaled Hosny  <khaled@aliftype.com>  [9ca3c6794ca1969f453ddaa66c4e02ac8c695cc6]

        FeatureCollector: Detect ENUM features in OpenType fonts
        
        A bit heavy handed, but the only way to detect the number of alternates
        a feature has is to get the maximum number of alternates for all lookups
        in all glyphs of this feature, which is what this code does.
        
        Additionally, for cvXX features, parameter names from the font are used
        when available.
        
        Change-Id: Ib7f7ea5e5288b47b03dac8703668ca6c4007f517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138749
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-25  Khaled Hosny  <khaled@aliftype.com>  [19787042b1f139cb9c366801d283c6c0227e85e6]

        FeatureCollector: Get feature labels for ssXX/cvXX features from the font
        
        If the font provides feature labels for ssXX/cvXX features, fetch and
        use them.
        
        Switches also to using the UI language not locale for finding labels as
        the UI language is what controls the UI localization.
        
        Change-Id: Ic7eeae9df25692e7f2924b2db65905666999c904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138748
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-25  Khaled Hosny  <khaled@aliftype.com>  [7581fcde3c6a8d098a37b2c89c74e54696d4c346]

        FeatureCollector: Simplify
        
        We are not using the script or language information for anything, so we
        can use HarfBuzz API to query the GSUB/GPOS tables directly.
        
        Change-Id: Ie68c51a1662494ba33ec192edb78afa0d8added4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138745
        Tested-by: خالد حسني <khaled@aliftype.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [187be4a26f38af6a0c8751a096379978e269a83a]

        These are DOS paths, not URLs
        
        Change-Id: I851120db13d84f7a48e4cbbbf8f9dca14ed6e61d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138801
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-25  Tor Lillqvist  <tml@collabora.com>  [c8d974444507a96bebc1ef46869809cb8c9ce5c7]

        Tell LibreOfficeKit clients what fonts in a document are missing on the machine
        
        Use the OutputDevice::StartTrackingFontMappingUse() and
        OutputDevice::FinishTrackingFontMappingUse() functionality that was
        added last year.
        
        Add a new LibreOfficeKit document callback:
        LOK_CALLBACK_FONTS_MISSING.
        
        "Font" here means just the family name. We dont really know what style
        from the family is missing.
        
        Change-Id: Iec4349b5827e7d1dbdde7f8a9f8da92efde429e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138802
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [eaf0b96ec2acdea2376413ef3a93c4c17889e23c]

        no need to allocate SwHTMLPosFlyFrames separately
        
        Change-Id: Ib3b23445d204058576b6e07806e3a4bfe45e5a74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Stephan Bergmann  <sbergman@redhat.com>  [eeb61b20728a87cd43124ba1a89bae3fa2d52d7f]

        Missing test dependency
        
        > warn:vcl.builder:774639:774639:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui at xmlreader/source/xmlreader.cxx:67"
        > warn:dbaccess:774639:774639:dbaccess/source/filter/xml/dbloader2.cxx:460: DBG_UNHANDLED_EXCEPTION in load exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui at xmlreader/source/xmlreader.cxx:67"
        > unotest/source/cpp/macros_test.cxx:73:DialogSaveTest::test
        > assertion failed
        > - Expression: xComponent.is()
        > - loading failed: file:///.../workdir/CppunitTest/testEmptyStdlibSave.odb
        
        Change-Id: I5a02b07b133fef03502cfcf03ddba98d9f223432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138777
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-25  Luboš Luňák  <l.lunak@collabora.com>  [32cbd1c57dbaf7cff2325c126b3adfcf2150bc23]

        lok: make sure flushPendingLOKInvalidateTiles() is called
        
        SwViewShellImp::AddPendingLOKInvalidation() collects invalidations,
        but this was relying on something eventually calling
        flushPendingLOKInvalidateTiles(), which wasn't guaranteed.
        If e.g. a spellchecker caused an invalidation from in idle callback
        and nothing else changed, then the LOK callback handling code
        didn't know there was something pending. So add an explicit
        call to ensure to notify about these pending invalidations.
        
        Change-Id: I0a9cb0d5aba2fdbbac126cd8a4a3412bef1cab25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136531
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-25  Caolán McNamara  <caolanm@redhat.com>  [38a29acd7e305ec99c4eb1871b9f31f75a3ab80c]

        use DevicePoint and SubPixelToLogic to return to source coord system
        
        Change-Id: I1aeae6270feb6cb0a44b7850e1b3143e68ae780f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Caolán McNamara  <caolanm@redhat.com>  [241ce1488b8354f6c203d4feaef8a9fed9a3f52c]

        retain accuracy when we have subpixels and convert back to Logic units
        
        Change-Id: If5a8624c1150919cc66f7b7d635edf112b480523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138738
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Michael Weghorn  <m.weghorn@posteo.de>  [53b5b720d33b93b2d05a845b28dbc7709eb4d9e1]

        avmedia gtk: Fix build for Gtk >= 4.7.2 ('-Werror=deprecated-declarations')
        
        Failed like this:
        
            .../libreoffice/avmedia/source/gtk/gtkplayer.cxx: In member function ‘virtual com::sun::star::uno::Reference<com::sun::star::media::XPlayerWindow> avmedia::gtk::GtkPlayer::createPlayerWindow(const com::sun::star::uno::Sequence<com::sun::star::uno::Any>&)’:
            .../libreoffice/avmedia/source/gtk/gtkplayer.cxx:346:38: error: ‘void gtk_picture_set_keep_aspect_ratio(GtkPicture*, gboolean)’ is deprecated: Use 'gtk_picture_set_content_fit' instead [-Werror=deprecated-declarations]
              346 |     gtk_picture_set_keep_aspect_ratio(GTK_PICTURE(m_pVideo), false);
                  |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            In file included from /usr/include/gtk-4.0/gtk/gtk.h:196,
                             from .../libreoffice/avmedia/source/gtk/gtkplayer.cxx:28:
            /usr/include/gtk-4.0/gtk/gtkpicture.h:73:17: note: declared here
               73 | void            gtk_picture_set_keep_aspect_ratio       (GtkPicture             *self,
                  |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            cc1plus: all warnings being treated as errors
            make[1]: *** [.../libreoffice/solenv/gbuild/LinkTarget.mk:337: .../libreoffice/workdir/CxxObject/avmedia/source/gtk/gtkplayer.o] Error 1
            make: *** [Makefile:289: build] Error 2
        
        Corresponding Gtk commit [1]:
        
            commit d8a73cbd03118e94bd75f5fa183a646fecb053ce
            Author: Marco Melorio <marco.melorio@protonmail.com>
            Date:   Fri Jul 15 18:18:26 2022 +0200
        
                picture: Add content-fit property
        
                It allows to specify the resize mode of the paintable inside the
                GtkPicture allocation. This also deprecates the keep-aspect-ratio
                property.
        
                Fixes #5027.
        
        While the doc [2] says its deprecated for 4.8, that sems to refer to stable
        Gtk version only and it's already the case for the unstable version
        4.7.2 (as packaged in Debian testing now):
        
            $ git tag --contains d8a73cbd03118e94bd75f5fa183a646fecb053ce
            4.7.2
        
        Use `gtk_picture_set_content_fit` with `GTK_CONTENT_FIT_FILL`
        that results in the same behavior for Gtk >= 4.7.2.
        
        [1] https://gitlab.gnome.org/GNOME/gtk/-/commit/d8a73cbd03118e94bd75f5fa183a646fecb053ce
        [2] https://docs.gtk.org/gtk4/method.Picture.set_keep_aspect_ratio.html
        
        Change-Id: I9fc527e6674cb8e4774adbe7d14cce2a264a5a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138797
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-25  Luboš Luňák  <l.lunak@collabora.com>  [b1b2083ec2ebde32d2c3f7ee2f2e3d2cc75721d8]

        try harder to ensure InterpretCellsIfNeeded() interprets (tdf#150499)
        
        ScFormulaCell::Interpret() tries to interpret the whole formula group
        (or the given range of it), but it's not guaranteed, and possibly
        just the called cell will be interpreted. So if a specific range
        really needs to be interpreted, handle that case.
        
        Change-Id: I7fb563ae471eefd49e5bb6c92b6aff98c42a440e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138741
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-25  Miklos Vajna  <vmiklos@collabora.com>  [71954eae45173618f7da1a839d674e888f64bab2]

        oox: avoid unnecessary value parameter
        
        This parameter is copied for each invocation but only used as a const
        reference; make it a const reference.
        
        Change-Id: Iff80fb1b8d2374b93eca718b932659aca8142713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138775
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-25  Noel Grandin  <noelgrandin@gmail.com>  [497fd09add19ccb834aa40226b60c642299e210e]

        no need to use shared_ptr for m_vFrames
        
        we can use unique_ptr and move the objects around
        
        Change-Id: I5ea6ac312318d32901a6ddd4967e6ce683a69f5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Noel Grandin  <noelgrandin@gmail.com>  [3369a24c48781fd5b8afe9bb707f92588825f6c3]

        Use SwNode instead of SwNodeIndex in SwPosFlyFrame
        
        part of hiding the internals of SwPosition.
        
        Also
        (*) Just define the whole class in the header, it is a
        dead simple data carrier.
        Then the virtual destructor and the SAL_DLLPUBLIC_RTTI
        becomes unnecessary.
        (*) No need to use shared_ptr, these are never
        shared, the call sites read the data and then discard
        them.
        
        Change-Id: I7fb64fd2bfa3469a7dfa4a325bb508457ca759a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138776
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-25  Rene Engelhard  <rene@debian.org>  [f7e170eb084cd4e92818de966b287330184749a8]

        Make configure work with gpgme >= 1.18
        
        Sam James wrote:
        > gpgme-1.18.0 dropped a bunch of internal symbols,
        > including progress_callback (see e.g. callbacks.h
        > which has a comment at the top saying it's internal).
        
        Plausibly the workaround to not link against older KDE-specific distro
        packages is not needed anymore.
        
        Check for main as a workaround as we do for other C++ libraries, too.
        
        Change-Id: I57065a5b5b23b9eadb73b01e4f3a289552c3bde4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138667
        Tested-by: Jenkins
        Reviewed-by: Sam James <sam@gentoo.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-08-24  László Németh  <nemeth@numbertext.org>  [24087697d5cf78aac346d4dcea0596373e15a95c]

        tdf#150576 sw: fix cursor pos deleting at rows deleted already
        
        Instead of jumping in the start of the document, set cursor
        after (or deleting the last row, before) the rows deleted
        already in Hide Changes mode with enabled change tracking.
        
        Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes".
        
        Follow-up to commit 189aa05c6ea17a8e823b4eab18ea0d1131d9d73e
        "tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes".
        
        Change-Id: Ifc2a7f41a57f413d27d9b464a0e464643d15f404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138772
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [7b5e13a4df115b5aeb046ae78e5d26d3df63b354]

        Add .uno:SidebarDeck.ElementsDeck to MathCommands.xcu
        
        Change-Id: I341daedb72bc09183b881bf19514936b683ffc31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138774
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-24  Michael Weghorn  <m.weghorn@posteo.de>  [61c0c1286dbd9015809ba8ee5ee687b612438bef]

        qt a11y: Remember associated QObject also for non-QtXAcccessible case
        
        This is similar to what
        Change-Id Ic890a387ff016e889f25dba70c82d0d81ae7a9e3
        ("qt a11y: Remember and reuse existing QObject for XAccessible")
        does to avoid creating another `QtXAccessible` for an `XAccessible`
        if one has been created earlier.
        
        However, there is an additional case that needs to be
        covered to avoid creating multiple `QObjects` for
        a single `XAccessible`:
        
        `QtAccessibleWidget::customFactory` not only gets called
        by explicitly calling `QAccessible::queryAccessibleInterface`
        from within LibreOffice code, but the Qt library itself
        also calls this method, in which case no entry associating
        the `XAccessible` with its `QObject` had been inserted into
        the map handled by our `QtAccessibleRegistry` previously.
        
        This would result in a "new" `QtXAccessible` object
        being created later when a `QObject` would be needed
        for that `XAccessible`, rather than using the
        `QtWidget` that is the actual `QObject` associated
        with the object.
        
        Prevent that from happening by inserting an entry
        into the map for this case as well.
        
        With this and two Accerciser fixes [1] [2] in place, jumping
        to bookmarks in Accerciser's treeview of the LO a11y
        hierarchy now generally works with the qt6 VCL plugin.
        
        It previously failed due to the fact that a new object
        was created and navigating the tree up to the root application
        object from the bookmarked object would then fail.
        
        The fact that there were two objects could be seen e.g. by
        using the following commands in Accerciser's IPython console
        with the root "soffice.bin" application a11y object
        selected in the treeview after starting Calc:
        
            In [25]: acc[1][0][0].get_parent().path
            Out[25]: '/org/a11y/atspi/accessible/2147483672'
            In [26]: acc[1][0].path
            Out[26]: '/org/a11y/atspi/accessible/2147483648'
        
        -> Two different IDs/paths for what should be the same object.
        (The parent of the first child of the object at tree path 1,0
        should be the object itself, but here it wasn't.)
        
        With this change in place, this now works as expected:
        
            In [28]: acc[1][0][0].get_parent().path
            Out[28]: '/org/a11y/atspi/accessible/2147483648'
            In [29]: acc[1][0].path
            Out[29]: '/org/a11y/atspi/accessible/2147483648'
        
        Together with
        Change-Id Ic890a387ff016e889f25dba70c82d0d81ae7a9e3
        ("qt a11y: Remember and reuse existing QObject for XAccessible"),
        this also addresses the remaining issue mentioned in
        
            commit 99640693d28ca11b31a1d3855e104d2d8c5122d7
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Aug 3 16:49:48 2022 +0200
        
        > Note however that this change alone is not yet sufficient
        > for a window to actually be returned for any arbitrary a11y
        > object deeper down the hierarchy. This is because
        > walking up the a11y hierarchy currently results in new
        > Qt a11y objects being created for the parents instead of
        > using existing ones, and the newly created ones lack
        > the association to the widgets.
        > (This works in a WIP branch that remembers/caches
        > a11y objects, but that needs some additional work before
        > it can be merged.)
        
        Note that there are still cases where navigation
        to bookmarks in Accerciser's tree view doesn't work
        (reliably), but those would need to be looked at
        separately and might not be specific to the qt6
        VCL plugin. (At least I have come across such
        cases with gtk3 as well.)
        
        [1] https://gitlab.gnome.org/GNOME/accerciser/-/commit/c2a3e9f1eb1fcd6eb059f1f2fe6e629b86521335
        [2] https://gitlab.gnome.org/GNOME/accerciser/-/commit/a092dc933985fafd5b1e2cc3374c7bbc0fb2d12e
        
        Change-Id: I02262014a45a4b024cdc1bbd385da8a35a2c304a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138764
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-24  Michael Weghorn  <m.weghorn@posteo.de>  [812fe185fba48b439fb1229517d62aa67c209016]

        qt a11y: Remember and reuse existing QObject for XAccessible
        
        Previously, a new `QtXAccessible` object was created
        for an `XAccessible` each time before
        `QAccessible::queryAccessibleInterface` was called,
        which is not only unnecessary but also causes
        various issues, e.g. it breaks walking the a11y hierarchy
        upwards (i.e. from children to parents), since a new
        object is created for the parent.
        
        This introduces `QtAccessibleRegistry` that keeps
        a mapping between the `XAccessible` and
        the associated `QObject`. That mapping is used
        to reuse already created objects instead of creating
        new ones for the same `XAccessible`.
        
        The entry for an `XAccessible` is removed again from the
        map in `QtAccessibleWidget::invalidate`, which gets called
        when the `XAccessible` gets disposed,
        s. `QtAccessibleEventListener::disposing`.
        
        With this in place, Orca now also nicely announces
        only the text of the push buttons themselves in the "Save Document?"
        dialog when switching between the buttons using the
        Tab key, rather than announcing the whole widget hierarchy
        every time (probably because creating a new object every time
        prevented Orca from recognizing that the previously selected
        pushbutton and the newly selected one are siblings, i.e.
        have the same parent object.)
        
        Change-Id: Ic890a387ff016e889f25dba70c82d0d81ae7a9e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138757
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-24  Julien Nabet  <serval2412@yahoo.fr>  [9931d6b1fb0406e16d56e186812884511738dcfa]

        tdf#150575: REPORTBUILDER: Crash when closing report when used report navigator
        
        0  0x00007fe062bdda64 in comphelper::OSelectionChangeMultiplexer::disposing(com::sun::star::lang::EventObject const&) (this=0x55fe72b7b680, _rSource=...) at comphelper/source/misc/SelectionMultiplex.cxx:82
        1  0x00007fdf90a97a6b in comphelper::OInterfaceContainerHelper3<com::sun::star::view::XSelectionChangeListener>::disposeAndClear(com::sun::star::lang::EventObject const&) (this=0x55fe6c94b6d0, rEvt=...)
            at include/comphelper/interfacecontainer3.hxx:362
        2  0x00007fdf90a6ace4 in rptui::OReportController::disposing() (this=0x55fe6c94b200) at reportdesign/source/ui/report/ReportController.cxx:341
        3  0x00007fe062539b5d in cppu::WeakComponentImplHelperBase::dispose() (this=0x55fe6c94b200) at cppuhelper/source/implbase.cxx:104
        4  0x00007fe0393b76e5 in cppu::PartialWeakComponentImplHelper<com::sun::star::frame::XDispatch, com::sun::star::frame::XDispatchProviderInterceptor, com::sun::star::util::XModifyListener, com::sun::star::frame::XFrameActionListener, com::sun::star::lang::XInitialization, com::sun::star::lang::XServiceInfo, com::sun::star::frame::XDispatchInformationProvider, com::sun::star::frame::XController2, com::sun::star::frame::XTitle, com::sun::star::frame::XTitleChangeBroadcaster, com::sun::star::awt::XUserInputInterception>::dispose() (this=0x55fe6c94b200) at include/cppuhelper/compbase.hxx:90
        5  0x00007fe0393af9d3 in dbaui::OGenericUnoController::dispose() (this=0x55fe6c94b200) at dbaccess/source/ui/browser/genericcontroller.cxx:1207
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=181994
        
        "addSelectionChangeListener" is called when "OSelectionChangeMultiplexer" is instantiated in "NavigatorTree" ctr
        225     m_pSelectionListener = new OSelectionChangeMultiplexer(this,&m_rController);
        
        but "removeSelectionChangeListener" was never called so add the mechanism to call it.
        
        Change-Id: I157b147f7a17244dbbfa7d12743fc7d48e7d5f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138773
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [ff38fc027ac04baecd0c5a17a5b795169a4273da]

        cid#1509260 silence Dereference null return value
        
        Change-Id: I513de1b3dd634e03965d7e813ba9b140249205fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138769
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [ee7b7acba288d265001237e3d81a1791e322ed28]

        cid#1509194 Dereference after null check
        
        Change-Id: Idb290b2780af402f8573c8231e63b2598b34ba43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [2f05a65a4eafcbda3438e50bd0b6518248c04d5d]

        cid#1509207 Dereference after null check
        
        remove useless null checks left behind after
        
        commit bb674aa5503ff40a5619d1fb4c9f310da5f5c983
        Date:   Thu Nov 17 13:16:30 2016 +0200
        
            loplugin:unusedfields
        
        showed they weren't consumed anyway
        
        Change-Id: Ia32ee9458e01a995692ab961e52512872b1c415c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138767
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [cfa942249162d5503b8a34d5813fddfb1182283a]

        pass SwNode to FindPrvNxtFrameNode instead of SwNodeIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ib0c24ca1179f9c8dd92e9b327daea8a5079cead1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [59f30175bfc557aa7c752ab0b45af9d34215d4dc]

        tdf#150577: Revert "Micro-optim in FormController::approveRowChange"
        
        This reverts commit e005ab5d40d358adb75a64e140d46f4bf605647d.
        
        XColumn::wasNull is documented [1] to require a previous call to a get*
        method. The reverted change internally queried the *previous* column's
        wasNull.
        
        [1] https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdb_1_1XColumn.html#a0d482c20564f9119052b1962f830190e
        
        Change-Id: I3e988358764fa6935e8eb3e66340a0869c157d02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138550
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-24  Miklos Vajna  <vmiklos@collabora.com>  [8fa1d453c94cdbb03dac646fb8db2ebd1a0e84bd]

        Related: tdf#149971 svx: support explicitly provided snapshots for media shapes
        
        Snapshots / previews for media objects are used when the shape's video
        is not playing. This is generated by seeking to the 3rd second in the
        video, probably to avoid initial black frames.
        
        The trouble is that PowerPoint takes the initial frame (at least in case
        of the bugdoc), so our snapshot doesn't match the reference.
        
        We already import a bitmap snapshot from PPTX files since commit
        e2d46da076f43a7c0d56fc486b9f15339243f7c9 (avmedia: add doc model for
        bitmap fill of slide narrations, 2021-01-21), fix the problem by
        changing the snapshot generation to prefer this bitmap over generating
        one from the video.
        
        The crop properties of this bitmap / the video are still not yet handled
        from PPTX.
        
        Change-Id: Id985eaaaad5e4222d9a98203d054e08a0f97a0f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138763
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [87de096032b0665abebed521f2f07f0ad893de0c]

        cid#1510129 Logically dead code
        
        triggered by the recent flatten, but there since:
        
        commit 36f21914b31a28f75ec2195c266424a18408f747
        Date:   Tue Oct 29 17:40:43 2013 +0000
        
            Resolves: i123564 corrected some aspects when working with bitmaps...
            with low color depth or small size
        
        Change-Id: I5f088c3f7096cc6f2efcd370943128d6667b2d0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [c61c70e51cd6bc1721ec0d840aad28b5ed284ae7]

        cid#1510131 Uninitialized scalar field
        
        Change-Id: Iff08a3dbbfc7ac14606061c66c81519e780d846c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138761
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [006fd925feafcf9beecf01279907fb330d704a89]

        Use more SwPosition::Assign
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: I49cf97b3beaa3ff79489ba23106ac9ede9475765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [55c638eb0d6aeacb7b5a8b0345add9b44aa6c889]

        use SwNode instead of SwNodeIndex in HasBareGraphicEnd method
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I89f5bc1a70a8cf54052eebdda9830f8ed634ce45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [f067bfebf6fbdfb66d545585fea9fe6cec559038]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: I8a418c2806eefada74471c28aa23189950d2e7ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138758
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a310d3f4669650b9b33eb81c1e9f7e9be679b1e2]

        Update git submodules
        
        * Update translations from branch 'master'
          to eb38107f17dbae1029eca4e4449128fbc2b9adf4
          - update tranlsations for 7.4.1 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: I3c03169b1a7d7ee775b8dbefca7eee140611ea8f
            
2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2476104c9168969b4970bd613a11078fec699435]

        fix ubsan signed integer overflow
        
        after
            commit 6b544507b01d479b991d3ba7c949cb70696a3f2e
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Aug 23 11:42:38 2022 +0200
            Use more SwPosition::Adjust
        
        ubsan started to complain because the SAL_WARN_IF here assumes that nVal
        is >= 0. Make it work if nVal is < 0.
        
        /sw/source/core/bastyp/index.cxx:332:5: runtime error: signed integer
        overflow: 2147483647 - -1 cannot be represented in type 'int'
        /sw/source/core/bastyp/index.cxx:332:5
        /sw/source/core/crsr/pam.cxx:257:14
        SwPaM*) /sw/source/uibase/wrtsh/wrtsh2.cxx:129:52
        /sw/source/uibase/fldui/fldmgr.cxx:1490:39
        SfxRequest const&) /sw/source/uibase/wrtsh/wrtsh1.cxx:2284:19
        
        Change-Id: Ic9e98b5350a55713f6b3fc2b39c9cbce97ee7223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138756
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [47d51286103dc6fa2c4ddfa871bde4878aef17ef]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: Icdcf9db112f34b3164e52c33f90484755cc08ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [be9644c5b6aeecdb363d4fc9ba4a113c6280ae80]

        use SwNode instead of SwNodeIndex in WillHavePageDescHere method
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ib671c8a0588e7e53567b2ed02ff6169226d7c2e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ba1f58c58857812d85e7c57d2f612ca80216786]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: Ia11f4797fe0b7b0ba4fb368fe4f9918a2d577c87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [573d6a12a450949246516c8d69e173c8c7680fc2]

        rename DeviceFontWidth/DeviceFontHeight to DeviceSubPixel
        
        Change-Id: I5378169e2c1d4d15fa160c3c2d2a130556dc80b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [990dd32a749cc402857535dbd94fccdb918c71a2]

        move & rename height relevant function near & similar to its width equivalent
        
        Change-Id: Icab3c11d6968efbbdb0f9f7f1dfeba2709e22a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Chris Sherlock  <chris.sherlock79@gmail.com>  [6c0bb0f9b846b3f1fee3ff07fb67409708449e0a]

        tools: test Rectangle::Normalize()
        
        Change-Id: Ia3fec45b2b6dd0011910c8db5819e161485336c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138713
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-24  Chris Sherlock  <chris.sherlock79@gmail.com>  [59210b075b79e4fc58f86542d9947d6ed0073abd]

        tools: rename Rectangle::Justify() to Rectangle::Normalize()
        
        Jusify() normalizes the rectangle so both the Width and Height are
        positive, without changing the location of the rectangle. It ensures
        that the x and y coordinates will be moved to the top left of the
        rectangle.
        
        The name is strange, so renaming Justify() to Normalize().
        
        Change-Id: Idbf163e65e52a798e38f785b8961b8042cf0cf2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137379
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-24  Caolán McNamara  <caolanm@redhat.com>  [51d2e734099e5c5c56393ef9f08007a7df441794]

        try and make test_Tdf148620 more reliable
        
        Change-Id: I11ec949cb82ebaaa225afbbc154f574fc56c0d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138753
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-24  Miklos Vajna  <vmiklos@collabora.com>  [f3294eb1789e9603b5129f0f2d61116fd4853b52]

        CppunitTest_sw_htmlexport: remove not needed mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Iaf7b77a18bcfca86ab06928580fd5d924f7af493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138742
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-24  Justin Luth  <jluth@mail.com>  [e93b7f6a5c5f9ee86546d95d7fe70ecc26b71b91]

        NFC related tdf#85592: simplify SID_ATTR_CHAR_COLOR_BACKGROUND_EXT
        
        I am tring to replace Writer-only uno:BackColor
        with uno:CharBackColor. The problem is this template flag
        which gets calls in svx and then does nothing in editeng.
        
        But I don't see any reason why this call should be
        transformed into a template (_ext) call.
        We can easily just keep the same call
        and do the state-checking only slightly different.
        All this other stuff makes _EXT seem much more
        complicated than it is.
        
        If I am right that this is a Non-Functional-Change,
        then I am well on my way to fixing this bug report.
        
        Change-Id: Idc08117217837f217ea5ca390005802c2fad392b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138101
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-23  Eike Rathke  <erack@redhat.com>  [65747afbb644607c0d2a1fbf354a1a080292b285]

        Make static ScCompiler::GetCharClassLocalized() public as well
        
        ... and mutex guard it.
        
        Change-Id: Ief9c6deaf7974ac43c7ae439a0fb73c29eced283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138733
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-23  Julien Nabet  <serval2412@yahoo.fr>  [e2a16489ff4a65e747e93b28d39096cb259bddd7]

        tdf#150555: Skia seems to fail with Windows 8/8.1
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=150555#c7
        
        Change-Id: I7c2f0a30b3d8cc3c5c528690087a42423fba68a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138743
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0de37cdd0251a7fc080bc6b95ac8708833bd0552]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: I46dbb7e562cf41dcceab57e2f5bf1e19babb955a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Justin Luth  <jluth@mail.com>  [285f5306d75892963707b64a3782850c80d4a315]

        related tdf#150197 doc import: ANLV2 - always SetListFormat
        
        Any time there is numbering, we expect to see an
        optional sListFormat set.
        
        This solves another case found by:
        assert(false && "depricated format still exists
        and is unhandled. Inform Vasily or Justin");
        
        Change-Id: Ie88d6ea6feaaebaae8a0953668a2801f6f1a139a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138734
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-23  Caolán McNamara  <caolanm@redhat.com>  [9fda7a0c938fdae3e57c7a8121a94459f2749dc2]

        backport some upstream hunspell commits
        
        Change-Id: I0c2b94a27af8c25c69579b367b944a4f77036487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-23  Stephan Bergmann  <sbergman@redhat.com>  [4c27aaa787a67e05a592adcf6cf42e49b7a02eaf]

        -Werror=redundant-move
        
        ...with recent GCC 16 trunk.  Introduced with
        1a2926a995fdbdcdae0ca6407877084f3520e539 "use std::move when popping stuff off
        stacks" but which doesn't make sense here where std::priority_queue's top()
        unconditionally returns a const reference (unlike std::stack's top()).
        
        Change-Id: I408920220e3b7ffe775fa87f9edbfdc7721058db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138732
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-23  Khaled Hosny  <khaled@aliftype.com>  [783f166793915a1c5a008de7142f773ad3898683]

        tdf#127423: Allow disabling default features in Font Features dialog
        
        In OpenType fonts we have no way if detecting what features are on by
        default and what not (short of hard-coding this, since HarfBuzz has no
        API of giving us this information, and it is also not a fixed set
        per-font, depends also on the text being shaped).
        
        The dialog currently does not differentiate between a disabled feature
        and unset feature. To make this distinction, feature value is now signed
        and negative value means the feature is unset (i.e. the default is
        used), and the checkbox is now a try state one to reflect this.
        
        Change-Id: Iba5d13f02610e7b761677acc19872788c72afde1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138729
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-23  Miklos Vajna  <vmiklos@collabora.com>  [31cb5b5538b9fd91dafb067ce961f2540555ad2b]

        sw: fix missing cache invalidation when switching between images
        
        It is possible to disable toolbar buttons from UNO API client code by
        registering a dispatch provider interceptor and then returning an empty
        reference when the UNO command associated with that toolbar button is queried
        for a dispatch. Such querying of a dispatch happens when changing context (e.g.
        text -> image selection), but not when switching between two images.
        
        A benefit of the current approach is that once a button is disabled this way,
        it remains disabled without re-querying the dispatch provider, which helps
        performance. A downside is that in case the dispatch provider intercepts the
        command based on the current selection (e.g. currently selected image), then
        switching to an other image won't re-query the dispatch provider, for at least
        two reasons:
        
        - SfxBindings::Register_Impl() is only called when the dispatcher is an
        internal one (e.g. not implemented in Java), so there is no listener that would
        re-query the state on selection change
        
        - even if we re-query the dispatch provider, the actual toolbar button won't be
        updated if the initial dispatch was an empty reference, since updating works by
        registering a status listener on the returned dispatch object in
        svt::ToolboxController::bindListener()
        
        Fix the problem by explicitly calling contextChanged() on the current frame
        when switching between images (but not changing context), similar to how
        SvtCommandOptions_Impl::Notify() invalidates registered dispatch objects when
        the configuration (on what commands are disabled) changes.
        
        This only helps with images and OLE objects, other object types are kept
        unchanged for now.
        
        Change-Id: I7f33dd2804067acf5cb0ca836f6a2a69fa950a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138724
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-23  Michael Stahl  <michael.stahl@allotropia.de>  [c5d255b1f0bea5fec520c27b5141bce4b41cb3d6]

        sw: Navigator: Protect Bookmarks should allow editing, part 2
        
        Nowadays the Navigator is created once on document open, so enabling
        the protection from the menu will be ignored in SwContentType ctor,
        while setting loaded from file will take effect.
        
        Change-Id: If70b49044a712ebb3729a800836501db76fc490d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138714
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-23  Michael Weghorn  <m.weghorn@posteo.de>  [b99c74804b254d32f582d2fd9e0c67161ebdf909]

        qt a11y: Drop unnecessary QObject inheritance
        
        While `QtXAccessible` has to inherit from
        `QObject`, `QtAccessibleWidget` doesn't.
        
        Change-Id: I5630f05cdd939bb0013dec4d26f010407d40a2c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138726
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0925dc81415276932aef66107b2d924b22c02d1e]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        
        Change-Id: I9a9889a819a3998aa4ff2188a2dc3e0cb2ec6888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Noel Grandin  <noelgrandin@gmail.com>  [fc10c4a3a7700fc96890149ae9095206b5e67685]

        use more SwPosition::GetNode
        
        Change-Id: Iad8d3247062f459960767487d603711aff01f10e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Caolán McNamara  <caolanm@redhat.com>  [0d73352d7b8a26c4655ce138cab1cecab15ff053]

        cid#1509308 silence Logically dead code
        
        Change-Id: Ie0fba1b7221b92b1e1c37c80ade621c82c4fbf79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138707
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b544507b01d479b991d3ba7c949cb70696a3f2e]

        Use more SwPosition::Adjust
        
        to keep the internal fields of SwPosition in sync.
        Add a new SwPosition::AdjustContent for when we need to update the
        context index alone
        
        Change-Id: Iad277f742a903157afdacd1d5c11b2abfa7d477c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Caolán McNamara  <caolanm@redhat.com>  [1c8ad4c95bd99dc6f8a105c109c725cbe92def26]

        cid#1509185 Logically dead code
        
        do oslDoCopyFile only for S_ISREG. openFilePath (called from oslDoCopyFile)
        returns osl_File_E_INVAL for !S_ISREG so use EINVAL as the error code here
        to produce osl_File_E_INVAL too.
        
        Change-Id: I25a6c091799e051fe58c7dbfc2e7e062f16fe517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-23  Liu Hao  <ianahao331@gmail.com>  [3f284b6f12e3eb047398998b223663b38a9bfec8]

        tdf#148251 Use std::swap instead of using temporary values
        
        Change-Id: Ibbc46bfb17d4d27dc40e63c65190b3f3a5f2d9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138256
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-08-23  Michael Stahl  <michael.stahl@allotropia.de>  [27892a5e12dada80226f778ab2bd14b1bdaab58a]

        sw: enable Replace with Protect Bookmarks
        
        The dialog calls Replace on the whole bookmark, and with commit
        7974cea6c788e02d7c36573e2d10dcc51884f70e the bookmark is preserved, so
        the HasReadonlySel() should not prevent this replace from happening.
        
        Change-Id: I823b042c8327c6716b2ac1a8a86beffd887e6e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138693
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-23  Caolán McNamara  <caolanm@redhat.com>  [937c22f242d0c08b0980ce864530966378ada9a9]

        ofz: now that ofz#24932 is closed, bring up the input limit
        
        Change-Id: Ide378cd9cad9f581faaca6e7d3a4e07470075ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-23  Jean-Pierre Ledure  <jp@ledure.be>  [8f6b7429ed123526659c197663bf5d950f461037]

        ScriptForge - (SF_Document) fix Import/ExportFilters properties
        
        in the internal method _GetFilterNames(), in an array
        of PropertyValues, 2 indexes were hardcoded to
        optimize their access.
        
        The sequence of items has been changed in LO 7.4.
        
        The search of the correct Name-Value pairs is reviewed
        to make it independent of their position in the array.
        
        No impact on documentation.
        
        The function is of minor importance.
        Patch for LO 7.4 to make only if bug reported in bugzilla.
        
        Change-Id: I2d3147c9c7624bf79a4e077469223794dc2398bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138695
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-08-23  Mike Kaganski  <mike.kaganski@collabora.com>  [c06e4fffd5b1148ba4fad59866ff9efd20e5e3e8]

        Drop obsolete code
        
        Clang also defines _MSC_VER macro.
        
        Change-Id: I7e483eb1811a3ce5c78a6721895026d004ca98fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138712
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-23  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [01e3c998e63fbf456e7f624adb1cae3d89ed7bb2]

        tdf#67669 - Make narrow no-break space visible by drawing a gray background
        
        Change-Id: I7a80fe6ceab6b3693241db4fda77ce6712624321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138710
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-08-23  Noel Grandin  <noelgrandin@gmail.com>  [e74c77f420281ff730ba981ddeddbb7b9b10fb8e]

        use more SwPosition::GetNode in CopyWithFlyInFly
        
        Change-Id: I2f74694466f7a01dcc12fd39527900c53825e1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Khaled Hosny  <khaled@aliftype.com>  [b9f0caad5d9e628f82d5148dfc7d2436d32817e2]

        tdf#66819: Disable ligatures with character spacing
        
        When character spacing is not zero, optional ligatures should be
        disabled (e.g. this what CSS requires and what browsers implement:
        https://drafts.csswg.org/css-text/#letter-spacing-property).
        
        This disables both “liga” and “clig” OpenType features because they are
        optional features and are enabled by default, it does not disable “rlig”
        because it is for orthographically-required ligatures, nor “dlig” or
        “hlig” because they are disabled by default.
        
        The character spacing values (confusingly called kerning in the source
        code) are moved from SvxFont to vcl::Font so it can’t be accessed in
        OutputDevice and pass the relevant flag to SalLayout.
        
        Change-Id: Ieacc875df3896ad7a63ae8d116f4c6ff7265b9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138711
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-23  Liu Hao  <ianahao331@gmail.com>  [e3d120e2ba991897bf7d8eff6cc4eba00f7d749e]

        tdf#148430 Use std math functions instead of rtl::math
        
        Revert the changes in rtl unit tests.
        Add some new unit tests to demonstrate the behavior of std
        functions is same as rtl functions.
        
        Change-Id: I12603e2502b8d0951ff5e1650dc8fa193d67c856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138696
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-23  Chris Sherlock  <chris.sherlock79@gmail.com>  [fe2fcbf0e564e2b0d8f3dbec326d3423bc5fbcf5]

        vcl: move ImplEmphasisMarkStyle() to vcl::Font and add unit test
        
        Change-Id: I958296225c5491a2cd78d64fb16d079272d7c28d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138140
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-23  Miklos Vajna  <vmiklos@collabora.com>  [9879eb714347a30444d85498975408e1706626be]

        sw: document SwUndoAcceptRedline
        
        Both redlines and undo track edits to the document. There is an undo for
        accepting redlines, but there is no redline for interacting with undo
        actions.
        
        Change-Id: I4b6f88d6d06aa68abdef4c26dc58aae334a2cb94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138704
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-23  Noel Grandin  <noelgrandin@gmail.com>  [a38834fa013e7a51fc81f7e6ad73a1371c7cad10]

        asserts unnecessary for SwNode::operator==
        
        since we're directly comparing pointers. Various places are
        already comparing SwNodeIndex from different documents like this,
        so this doesn't make the code any looser than before.
        
        Change-Id: Ic8feacee67b9495649ffc9560ce105078850a677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-23  Justin Luth  <jluth@mail.com>  [46dc9f3bbac67e9240adc44ab017f905482ef786]

        tdf#57317 odf export: avoid autolist conflict with NumberingStyles
        
        Somehow you can have autoStyles writing into the styles.xml.
        Well, the code to prevent duplicates for that needs to exist
        for autoStyles written into document.xml as well.
        
        Change-Id: I9602b7023a1ef009ad644374dc5081afb8a76916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138703
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [3cc6b870c48b23418f65d2c3cd6eab72ef0680de]

        make an effort to fix the UITest_inputLine intermittent failure
        
        debugging what normally happens I see that the EditEngine belonging to
        this inputbar widget is thrown away by calc when the content of the cell
        changes and is only recreated on the next "Paint" of the inputbar.
        
        It's plausible that throwing processEventsToIdle at the problem solves
        this.
        
        Change-Id: I620bae9eb87b2ff91755da9b8d7821791f0e4240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138708
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [6b68ac7d989dd34071c12ee64fe7c4cb99e37c09]

        cid#1509273 Unchecked dynamic_cast
        
        get ScDocument the way the rest of ScNavigatorDlg does
        
        Change-Id: Ib1e66a48cc385ac1ad479e8e3b6efa04349116e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [cd816c0b4e698386a482f20c975281a0f3a7d332]

        cid#1509296 silence Use after free
        
        Change-Id: I6c1d8c0365cb59f3c63537c08e27a34bac111aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138705
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [37494dc5457f5feb44465d2eb508a5f77fec74cd]

        I see this empty entry for the separator in the styles dropdown
        
        Change-Id: I0c0787f893e50ea32b3dc7bf4356b4603d8f8cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138689
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Eike Rathke  <erack@redhat.com>  [b759f6720b50487200740a6202e21774897b44b2]

        Resolves: tdf#150288 Do not prepend the locale's full date acceptance pattern
        
        ... if it wasn't present as first, but take the date acceptance
        patterns as specified by the user.
        
        Change-Id: Ife2fd39731bac0e0b121f22392f22b48ffc9c978
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138694
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [96d71754db51bf4eb0fba98a759e90a373e1d10a]

        tdf#150507 set hint style even if the platform returns no default font options
        
        if the platform (e.g. gen/kf5) doesn't return anything for
        GetCairoFontOptions() but we have need for specific font options then we
        also need to set them
        
        Change-Id: Ia805341d2ec75bdaf3d9de62955a247c33b106d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e5583150a3953f08782865e0f90d41f5c35cc6c5]

        chart2: always use the series for the keys (symbols) in data table
        
        In special case the legend keys are not series, but can be each
        value of a series. This can't be done for the data table where so
        this has been disabled.
        
        This caused a crash when positioning the symbols, as in some cases
        we got 0 symbols (due to another bug that didn't put the symbols
        into the collection) or more symbols that there were series (and
        the symbols couldn't be positioned correctly). With this change
        we now get the correct number of symbols for the data table.
        
        Also added the test document and test to open the document, to
        make sure we don't crash anymore.
        
        Change-Id: Idbebdd5295595a823b5420958e803b13258df035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138697
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  Michael Stahl  <michael.stahl@allotropia.de>  [5c3c49bbf768f88b3d9a45d1ffc88c44ad2870c1]

        sw: Navigator: Protect Bookmarks should allow editing the text ...
        
        ... in the bookmark.  Only deleting/renaming it is forbidden.
        
        Change-Id: I66c6d106f0fd97b416edabd0271cd3230909a279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138692
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-22  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7e2a8a9869e362ae181ad92f50ea287e9abf85bb]

        tdf#150139 - Add a concrete name to the error message
        
        Add a concrete name to the "Property or method not found: $(ARG1)" error message when creating a listener.
        
        Change-Id: I76c904793a96082c49f8aa2d45c76c50a453d892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138061
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0bda4401eda5b19b1ebfeb712cab6af8c8d1f59b]

        use more SwPosition::Assign
        
        as part of the attempt to keep the internals of SwPosition in sync with
        each other
        
        Change-Id: I6f109c32f5748ef3f76ab178a2aa9d6822bc58a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-22  László Németh  <nemeth@numbertext.org>  [189aa05c6ea17a8e823b4eab18ea0d1131d9d73e]

        tdf#148849 sw: fix cursor pos at tracked DeleteRow in Hide Changes
        
        In Hide Changes mode, the text cursor jumped to the start of the
        document after tracked deletion of a table row, instead of
        remaining in the table in the next table row.
        
        Regression from commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes".
        
        Change-Id: Iff959c9a9940db013827e1c827bcb92c07b4b26a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138683
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-22  offtkp  <parisoplop@gmail.com>  [86d49f41d46519235b55918ac375bc1d2b99552b]

        Remove code duplication in GraphicDescriptor for PSD
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PSD files
        
        Change-Id: Icae532a7143477dada411224293250a26676c684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138227
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [6a2fd2d07ed1cb7713776b32ff175b300ee732e9]

        Remove code duplication in GraphicDescriptor for PNG
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PNG files
        
        Change-Id: I8ce1c5eee44ff4122f4ecf1094d3d8b18379c6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138226
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [8d844452df8332edd92e9039e42cdcb1349e7e2c]

        Remove code duplication in GraphicDescriptor for BMP
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for BMP files
        
        Change-Id: I1cf096034a77826e61c36f0a5094976f49814747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138216
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [c24b88efc4ac80d25d79b9764e6718d0392f718a]

        Remove code duplication in GraphicDescriptor for RAS
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for RAS files
        
        Change-Id: I736c583a9cc974a9eb4151443295dbb4b1e71053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138212
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [0853187cbc66f17620c2951d24d1f71c9ea9f81a]

        Remove code duplication in GraphicDescriptor for WEBP
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for WEBP files
        
        Change-Id: Ib9d7169433b391e2520d6b9bca831fa964a8d136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138211
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [3682ef9da1ba3b6479e6bd6bf6d9705c784b4fd4]

        Remove code duplication in GraphicDescriptor for MET
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for MET files
        
        Change-Id: I3188fe4bcdd5e0d9a942c6606d28a01c56319619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138210
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  offtkp  <parisoplop@gmail.com>  [a1b2a8370e61ada2690a29a623d55b38bd7a7cf3]

        Remove code duplication in GraphicDescriptor for TGA
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for TGA files
        
        Change-Id: I939426d3016c90500c2a250ef464213b0fd7d642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138209
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [46003cb1c4c770a9ba4eb9b2a55561c2ebeb3519]

        upgrade to hunspell 1.7.1
        
        Change-Id: Ifff2f17d17ab2764f3703b008fcb096ff08c9315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138690
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Jean-Pierre Ledure  <jp@ledure.be>  [6caa4dad840542ba58570fa2bced35f63833aa8a]

        ScriptForge - (SF_Calc) support of 16384 columns in a sheet
        
        Alignment with Calc support of 2^14 columns
        as from LO 7.4 instead of 2^10.
        
        Review of comments accordingly.
        
        Minor optimization of internal method _GetColumnName()
        
        More accurate control of boundaries in
        internal method  _Offset()
        
        Change-Id: I590ae9a4fab0b90a6e9cc9bbacf6c1b582f9c6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138666
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-08-22  Miklos Vajna  <vmiklos@collabora.com>  [223a43537559efc96b4b5bca32d93211ed849ae5]

        crashtesting: fix DOCX export of tdf135569-1.docx
        
        This went wrong in commit 9700c1b2170ad04453a361ed5647937833ac3c18 (sw
        content controls, plain text: add DOCX import, 2022-07-25), which
        conditionally disabled the DOCX export of content control starts.
        
        The trouble is that the matching content control end is still written
        unconditionally, leading to a not-well-formed XML output.
        
        Reading the commit message, the motivation for the conditional start was
        testSdtAndShapeOverlapping in CppunitTest_sw_ooxmlexport7, but it seems
        that is no longer necessary since we try it harder to not pollute the
        doc model with never-read grab-bags in commit
        7ad44f3dd271a591529b048212c4391d8b38ed9d (crashtesting: fix DOCX export
        of forum-mso-de-99522.docx, 2022-08-16).
        
        Fix the problem by just reverting the problematic hunk, seeing it's no
        longer needed for the testSdtAndShapeOverlapping scenario and it causes
        a problem here.
        
        Change-Id: I5cc94ee00dfdf55de1fffe1c28242388549862ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138685
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2a93d2a22923cafd7eead86f70783706c7648a13]

        Update git submodules
        
        * Update translations from branch 'master'
          to f69bba3fa11f5345ec32bea471dbdfbbad3134a3
          - updatetemplastes for master/7.4.1 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: I265246d2f2ee85ea07314dc4632ac97952c7c7aa
            
2022-08-22  Michael Stahl  <michael.stahl@allotropia.de>  [28c0ed5f46af07052e05eeba7e2eeb02ee1f38d9]

        sw: forgot to remove temp FIXME of draft patch
        
        Change-Id: Ic4e0a9fcace27b781d401f9812df89e36f87bcd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138691
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [d18f649938806cd17383b2edd8994c5a66382771]

        cid#1500671 silence Resource leak
        
        Change-Id: I295d7877100b49a867a0f67e2edcc923d943401b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138664
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [b04507b6cc36de337b6aae67ed51fd36cc4a3482]

        ensure no font/glyph fallback is happening for repeatable results
        
        Change-Id: I7098ea59f1da2c80cde138109dd6a5c8e5b7e997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [91ebf44e997483d38096c4abac0c31fdcc3722b8]

        add Noto Sans Arabic to fonts known not to have bullet
        
        when measured by ImplFontMetricData::ImplInitTextLineSize
        
        Change-Id: I328436b3728927b58adc75f51061ebfa1d00b01d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138680
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [7c265a8b42aea2da28583863015ee73a58cd175c]

        cid#1509220 Explicit null dereferenced
        
        Change-Id: I5cc8958a5dd4f05fd8798eb561779027a868e386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138679
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [41ea53cdbfe669659a88e6f6da52cfefe8ee170b]

        cid#1509228 Explicit null dereferenced
        
        Change-Id: I60c806e08c23219b7f652fef55dae93a668290f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138678
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [361c645b6029f98f2c7e8ef51b6f098050c33dd0]

        only need to call ReleaseMouse once, the 2nd one is a no-op
        
        Change-Id: I7892a6956feef84e23b11a47199961052faf589a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138677
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [b30872826442ba1058d793dbef1533eda55fdfbf]

        cid#1509233 Explicit null dereferenced
        
        Change-Id: Ib48bc9fd9600115f00674eed385f9e2cdc80eafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138676
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [3bf0fbb267ea6c3a3c23efdeabbdced0724d65f1]

        Add a VisualStudio cpp.hint file
        
        It allows to improve IntelliSense results. E.g., this specific
        SAL_THROW_EXTERN_C define prevented from navigating to function
        implementations like rtl_str_hashCode_WithLength from IDE using
        'Go To Definition' feature.
        
        As described in the respective documentation [1], "Hint files
        relate to physical directories, not the logical directories shown
        in Solution Explorer", which means that the file can't be placed
        e.g. in solenv/vs, together with the .natvis file.
        
        [1] https://go.microsoft.com/fwlink/?linkid=865984
        
        Change-Id: I144d07b66b4a52c108a7e82b0aa9628843f5ae2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138665
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-22  Khaled Hosny  <khaled@aliftype.com>  [0483fbd1d05d74c394d9274bdee77b3b2aebb495]

        tdf#87535: Preview styles using CTL/CJK fonts in the sidebar
        
        Code is similar to code in svx/source/dialog/fntctrl.cxx and
        source/ui/chrdlg/drpcps.cxx, etc. Instead of using only the “western”
        font, it splits the text based on script type and uses the appropriate
        font for each script type.
        
        Change-Id: Iacdf92829d4568f2d580b39ca14ffe1218ceaa9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Khaled Hosny  <khaled@aliftype.com>  [044fc5c8b225732d57970d3bf0720c13a5a9e0a4]

        tdf#87535: Preview styles using CTL/CJK fonts in the styles menu
        
        Code is similar to code in svx/source/styles/CommonStylePreviewRenderer.cxx,
         etc. Instead of using only the “western” font, it splits the text based
        on script type and uses the appropriate font for each script type.
        
        Change-Id: I1db87748119beac18e5b7e61617419c149400c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138601
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [e92f7906527749f5b8148796d0bfb1a67387c4f0]

        cid#1509244 silence Dereference null return value
        
        Change-Id: I2dc9baee3e42712f6bf09aed5243e451aee6018a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [28f9791b9649f700971624700aa0ecc25b2eae79]

        cid#1509396 Explicit null dereferenced
        
        and
        
        cid#1509395 Explicit null dereferenced
        
        Change-Id: Ifd8dffe2ff2432ee2f0ef18bb2a480c2f042910b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [dd0ca80d887ad174511302ffadacd61447e93420]

        cid#1500530 return early to silence Dereference after null check
        
        Change-Id: Ia549ae31c7f13d70228620ffb4bce78ea95ba083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138673
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [f7b34a779eb49498ecce60b873538c53ec5bc278]

        cid#1500544 Uninitialized scalar variable
        
        Change-Id: Ibe55cef41b6e6fd2ea10a9f4684e5f3e7926983a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138672
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Michael Weghorn  <m.weghorn@posteo.de>  [2523b5451507c53bb3a10350e016651db82eb1d1]

        qt a11y: Don't set invalid Qt relations
        
        When no matching relation type is found when when trying to match
        LO's `AccessibleRelationType` to a corresponding Qt equivalent,
        don't set an invalid value, but skip this relation.
        
        Previously, when navigating to a Writer paragraph with the qt6 VCL
        plugin and Orca enabled, this would show up on stderr:
        
            warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 1
            warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 2
            Cannot return AT-SPI relation for: QFlags()
            Cannot return AT-SPI relation for: QFlags()
        
        This addresses the warnings emitted by the Qt library (lines 3 and 4).
        The first two warnings are from LO and remain for now, as long
        as Qt does not implement an equivalent for
        `AccessibleRelationType::CONTENT_FLOWS_FROM` and
        `AccessibleRelationType::CONTENT_FLOWS_TO`.
        
        Change-Id: If2cb5394b27d23926e4d4093ba8ab477997a16ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138671
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [17ec3096fc20439bed33ed28c627296d8f80f3b9]

        cid#1510101 silence Copy-paste error
        
        Change-Id: Ic5fcf10889147b6dfe22b18ea4ebee51ac547a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138660
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [82406c37d4ff10453ebf2ed56dfe8ec961954aaf]

        cid#1500700 silence Resource leak
        
        Change-Id: I606583919bceac98b480f3821c349069611808b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138662
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [91597052bea39720f5a557d30f7d687d4308e7a8]

        change hi to ar and Lohit Devanagari to Noto Sans Arabic
        
        for reproducible tests
        
        Change-Id: Ia5429c259190b2263dc4a9de971538dda0f53166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [2cbc6791a27c4b63639888162f97ace2352eacf2]

        cid#1500675 return early to silence Dereference after null check
        
        Change-Id: If43b82c9db4517e24cc3c6d8b61a38624e6243b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138663
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Noel Grandin  <noelgrandin@gmail.com>  [da50929c074aaa1587cdaf6cfab7767ac776f6a4]

        use more SwPosition::GetNode
        
        Change-Id: Iba1207fd5006c3bd56f45da3c46b84f5e8c43340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [ce891da19769f2c80e8f7517f85d67d2de5ba34e]

        cid#1500470 silence Resource leak
        
        Change-Id: I846746a351c619a4de7abce7a6443f510dc41690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Miklos Vajna  <vmiklos@collabora.com>  [bc209dd6689816c2c1fa93c1bab289465b7419a8]

        sw: prefix members of NumberingPreview, SwDocStatPage, SwEnvDlg and ...
        
        ... SwTestTabPage
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie60001ada507d5355715ebaaed3897de9854f7d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138655
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [2b06b5caeaa336de52746869fa91adfa6895f811]

        Remove NULL-terminated requirement where not applicable
        
        These functions take the string length instead, so may take
        non-NULL-terminated strings.
        
        Change-Id: I21dbfd97adec197ba52ae5f9e01340b44689805b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138658
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [5b9fd9222a10ce9fcf632e940ed720f990e183da]

        Use comphelper::Base64::encode taking OStringBuffer where applicable
        
        Change-Id: I65c46ad97804827477adba7bbc4eed13cc16b606
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138654
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-22  Caolán McNamara  <caolanm@redhat.com>  [86a78634bfef2c3e800990d245c227b832c89e6b]

        use "Rubik" from more_fonts instead of "System" for consistent layout
        
        using Rubik with trailing 0 because need to overwrite the binary
        fontname in the embedded wmf in this docx
        
        Change-Id: I2c49154bbef9405c15dd8bc044d21ec874f9825e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138639
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-22  Szymon Kłos  <szymon.klos@collabora.com>  [5053ad030b9ed5eba06157e161ff7fb8b61f6718]

        jsdialog: send MessageDialog on run not when built
        
        - some message boxes doesn't have correct notifier set initially
        - then when runAsync is called it is ok so we can remember widget
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: I8ecf2d20ef4c2ebda3acf3b80bb390717b6caf6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138107
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138650
        Tested-by: Jenkins

2022-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [02cf7ccf3f1abc245c494fd400ac19512c3904e6]

        Optimize and deduplicate Base64::encode a bit
        
        Change-Id: Ic549c8bf938ae363f9d1b83b8e3f4e6ee10603d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138657
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-22  Noel Grandin  <noelgrandin@gmail.com>  [4e91f49339d5197f8d32f633a5f48375db68e808]

        use more SwPosition::GetNode
        
        Change-Id: Id277c3c56a3a5f3d11160d750fd712d599150cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-22  Noel Grandin  <noelgrandin@gmail.com>  [db04b3e154a1fb8f222232ef969bb3617e051329]

        return 64-bit hash for O[U]String
        
        which gives better performance when putting strings into hashed
        containers that expect good key distribution.
        This hash implementation is the same one that Java uses.
        
        Change-Id: Iae5cf3cd27309856acfa51781295f2e56c8e77db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2b3b4e833484aa70cb73b296bb62cdb0304eac9]

        flatten logic in RenderFillGraphicPrimitive2D a little
        
        splitting part of it out into a helper function
        
        Change-Id: I135ba5c6c823eec9f708b4652900e06fa06bbba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f1adf4e4672b805fbda5682f4e0e6f08aed5ce79]

        tdf#150267 RTF: Import/Export unused document variables
        
        Previously document variables were only imported when there was
        a field in the document using them.
        
        This adds import/export for the RTF `docvar` group.
        
        Change-Id: I25099e037594f4b4c5530ba3a28c64aaa2927918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138482
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-08-22  Szymon Kłos  <szymon.klos@collabora.com>  [1e589375228b4dcee4a38122b34aea0720f888c0]

        Make Autofilter MessageBoxes async
        
        Change-Id: Ibfa13b423869d58dd42e398f46e209e170e02751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138106
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138649
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-08-22  Szymon Kłos  <szymon.klos@collabora.com>  [afb511b940e009e00fbb0b8358f454a293c44915]

        lok: Dont render active text edit on slide previews
        
        - extend ITiledRenderable interface to pass active text
          edit drawing state to the SdXImpressDocument
        - when painting tiles - allow text edit only for current part
        - pass new setting also to SdrPaintView where painting happens
        
        Change-Id: Ib4ff226961a76129f4f5ff11c90694cd46a83a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137676
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138648
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-08-22  Mike Kaganski  <mike.kaganski@collabora.com>  [1df81daa83a213086e4ca928834ae093a0f16f48]

        DumpAsPropertyTree: use more efficient overloads of JsonWriter::put
        
        Change-Id: I6fe3ff8138ed27a04a3a224c67492338cf23992c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c1647e6ee252fe68d7406d01043e88f1721590f]

        tdf#112865 assigning to mpDrawObj here is unnecessary
        
        because if mpFrame is set, the value of mpDrawObj is ignored.
        This shaves 2% off load time
        
        Change-Id: Ib64bb10fe03ab9623c94c8f285dd848ca13df815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [336a265711cc5e391a8675d8f34316fd788651d1]

        tdf#112865 inline a couple of hot methods
        
        Change-Id: I5db8b5717380a6a8fab50a6cbdd019e365be64af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138642
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [423b1b5864bb9f1d51bb5b237a560e88f921b525]

        upgrade to mythes 1.2.5
        
        Change-Id: I7ebe6eb62602797ce190632663900025741acf15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138636
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [547b4a054ac7f310485aaece6e936318f876d63e]

        Tahoma -> DejaVu Sans for reproducible tests
        
        Change-Id: Iedb007987848fbd5567bb96692e5501ff3046868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Seth Chaiklin  <sdc.blanco@youmail.dk>  [52eb2a91bf0acb5806d1cdf71124b9c54701300b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f82ea5276bce179a3e03785f5094d13923a4f583
          - remove "experimental" warning for outline folding
            
            Change-Id: Ic41c0ae829d659d8642bb0965b7e091209d9579c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138536
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [947a6455d23bff290319313734c8c30e8f495773]

        Tahoma -> DejaVu Sans for reproducible tests
        
        Change-Id: I1905a103e1981e5fe156ccd7bfaa4229380b2e82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138635
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [bfc39cf989fbfcdde525f7e52d3ef463378032ff]

        DejaVu Serif for reproducible tests
        
        Change-Id: I290b537da94218b30939eb9ddfc176452ee5400b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [82b27fabfe20e504233bdb0bac860266270bd6f6]

        tdf#131326 - Invalidate cell slots and update input line with new content
        
        Change-Id: I4881b73bb230380388ed366818d7e0808aec11e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138065
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-08-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [70c99eef1643a17b2c1f0dba38b55a58cdb9aafc]

        tdf#135451 - Change the skipSpace implementation of the break iterator
        
        Change the ICU whitespace function of the break iterator from u_isWhitespace to u_isUWhiteSpace to include no-break spaces.
        
        u_isWhitespace includes Java isWhitespace; Z + whitespace ISO controls but excludes no-break spaces
        u_isUWhiteSpace includes all code points with the Unicode White_Space property; most of general categories "Z" (separators) + most whitespace ISO controls (including no-break spaces, but excluding IS1..IS4)
        
        See https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/uchar_8h.html for further details.
        
        Change-Id: I21fddefaf2149096824908f644310a59d6e2f38d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137582
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [6c0b8669e1f09a8301f3ebd1da21855d84abb2b1]

        Arial Black -> DejaVu Sans for reproducible tests
        
        Change-Id: Ia4c4f47578f6674b6a5cfdbaa68fc12221ddb5ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [d76b194ffaa802948fda3e8008b84dd792288361]

        Palatino Linotype -> DejaVu Serif for reproducible tests
        
        Change-Id: Ia685cc28fe2f9c611f41c3a27d39014ceb3f30ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [b00b0b386e5de5b451b54704ddfe57dfb7951f05]

        ofz#50452 due to Timeouts, just abandon fuzzing on any JWRN_NOT_SEQUENTIAL
        
        I don't think I've ever seen timeouts on any other case, so use normal
        limits for fuzzing for any other set of warnings for now
        
        Change-Id: I1d4be748b931a18be9dc0291ac21d14b83a11183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Caolán McNamara  <caolanm@redhat.com>  [502c31cc73b2c3c6aac2df626a8c26b5bac8b1bb]

        There is no "Liberation Sans Unicode MS" font
        
        back in tdf#113720 the substitution
        Arial -> Liberation Sans
        was done, but that mangled
        Arial Unicode MS -> Liberation Sans Unicode MS
        which isn't a font that exists :-(
        
        ... style:font-name="Liberation Serif" ...
        ... style:font-name-asian="HG Mincho Light J" ...
        ... style:font-name-complex="Liberation Sans Unicode MS" ...
        
        Because this font is used as the default font for the complex text font,
        lets try Noto Sans here.
        
        This is also probably not technically correct as the CTL Noto Sans
        variants are in separate fonts like Noto Sans Arabic and Noto Sans
        Hebrew, etc, but at least it has more meaning than "Liberation Sans
        Unicode MS" and provides a hint which font substitution can use.
        
        Change-Id: Ib46ed07d469b00ae2bf06aee3e84129b24627374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-21  Noel Grandin  <noelgrandin@gmail.com>  [0c04043aed64bc7800e4910bff47f86d229ed004]

        use more SwPosition::GetNode
        
        Change-Id: Iaf3b6430d444405a0e72435d8d03975226b3dba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138594
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-21  Regina Henschel  <rb.henschel@t-online.de>  [64be7052ba7e02e248412222098e07a5f4106456]

        tdf#150407 do not use loext in save in ODF strict
        
        The 'bt-lr' attribute value of 'writing-mode' attribute and the
        'page-content-bottom' and 'page-content-top' values of 'vertical-rel'
        attribute are not part of ODF 1.3. Therefore they need to be saved in
        'loext' extended namespace.
        
        Error was, that this was done too, if the current ODF version is
        strict. That results in an invalid file in a productive build and a
        failed assert in SvXMLNamespaceMap::GetQNameByKey() in a debug build.
        
        Change-Id: Ie9ba99fdd02de21a2467b236409daa951933f011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138595
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [5eac26e79ef1482ebea31c8cd416c53f9d1714a9]

        cid#735694 silence Dereference after null check
        
        Change-Id: I76d6d7f33177b3cb15b258d497535e5db0f4d137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Jean-Pierre Ledure  <jp@ledure.be>  [d57836db76fcf3133e6eb54d264c774911015e08]

        ScriptForge - (Calc) extend use cases of FilterFormula
        
        A FilterFormula is a Calc formula that returns TRUE or FALSE
           The formula is expressed in terms of
           - the top-left cell of the range when FilterScope = "CELL"
           - the topmost row of the range when FilterScope = "ROW"
           - the leftmost column of the range when FilterScope = "COLUMN"
           After pasting, the relative and absolute references
           will be interpreted correctly.
        
        The FilterScope indicates the way the formula is applied,
        once by row, column or individual cell.
        
        The requested action is done only on the rows/columns/cells
        for which the FilterFormula returns True.
        
        Next methods receive 2 new arguments:
        =>   FilterFormula and FilterScope:
           ClearAll()
           ClearFormats()
           ClearValues()
           SetCellStyle()
        
        These changes are valid for Basic and Python user scripts.
        Without these new arguments above methods behave as before.
        
        The documentation needs to be adapted:
        - inclusion of FilterFormula and FilterScope concepts in the
          DEFINITIONS section of the SF_Calc help page
        - new arguments to add in resp. methods
        
        Change-Id: I657b231252106b91ed7e27a49ef3331c1fcee917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138590
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-08-20  Mike Kaganski  <mike.kaganski@collabora.com>  [5b6fd1bcdb417e73307885f92c31464fe326ec9e]

        jsdialog: dump IconView separator entries
        
        Change-Id: I1db0a6bf9348db79e9f8c25f5468ebd1398f285a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138593
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [c0a9108b417e9a1d8ef5c9e26b7e6b1b9aebf800]

        use more SwPosition::GetNode
        
        Change-Id: I602d52f1c2842ceec9006b40e7283d4785d8fd07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138592
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [65d90df1acfd2b014af835e4ed997a14e1182c22]

        use more SwPosition::GetNode
        
        Change-Id: Ic23fab765316d5e6423bff035c8ee3ec605210ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138591
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Khaled Hosny  <khaled@aliftype.com>  [726baadc33b06b3ac2d6f9a46471bedd8a6cbea5]

        Don’t unconditionally validate Kashida at start/end of layout
        
        That was a thinko. The mixed-style-in-one-word case will have the next
        position will be past the end of the layout. A position at the start or
        end of the layout is the first or last letter of a word, and we don’t
        want to unconditionally allow Kashida there.
        
        Change-Id: I0b287fe9cbf200282058fd7f8e81880ff328941d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138589
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [2cb162c87051971e2830d2bc80cbf7dd80bd00d6]

        SwNodeIndex->SwNode in NumOrNoNum
        
        Change-Id: Id877fd8d2881facef1dc4e97932128443892e10e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138587
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [dc454ce52d157caefef7c87cb51472c1d881d7fb]

        SwNodeIndex->SwNode in ClearBoxNumAttrs
        
        Change-Id: I7f1bd63bd151b4a00fed23c5507e8474428dc829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Khaled Hosny  <khaled@aliftype.com>  [c73f32dd137710ad4c322c45eb00743538dc6149]

        Fix displacement of Arabic combining marks
        
        This reverts part of:
        
        commit 5e2b7a656024b621bdeeb6efd977331191b66d9d
        Author: Khaled Hosny <khaled@aliftype.com>
        Date:   Fri Aug 12 02:12:04 2022 +0200
        
            Streamline Kashida validation logic
        
        Reverts an unnecessary change that was supposed to be a harmless
        simplification. Also add a warning to my future self not to try to do
        this again.
        
        Change-Id: I9213b6d0fb50f13fa98ed97b226f8fa1f3a807dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138588
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [c831f667d28640e6877b9b6fcf090db663c368f6]

        cid#1509231 Explicit null dereferenced
        
        Change-Id: Iac2f8f3e057f7a27ac0349822ab34f5ad3a6d164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138580
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [2533faa1dcb5c2319f05992380cff0d3dc317b11]

        use more SwPosition::GetNode
        
        Change-Id: Ib09191384e0ae3175a564edf9387e4de00ce851d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [c8f905fda1da4a3a58ab9bf4930cfaa7b7a04640]

        cid#1500500 Explicit null dereferenced
        
        check like SvxUnoTextRangeEnumeration ctor does
        
        Change-Id: I4dd4e08c72e9ad0f29afa2f88670f771dcb25b37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138576
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [77d8199f59b85f961088d8aec00d9d582b0df873]

        cid#1500683 silence Resource leak
        
        Change-Id: Ib4a469ea5e5392dc5144dcf4ff0c8994bd8847be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138578
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [b38b04702090504134d4433e36001079c1b027ae]

        cid#1500521 silence Dereference before null check
        
        Change-Id: Ia17524dd7bf9a56cad0a1358fa2f076b9e1776c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [b30c9626cbaab9436df776cc183770ac71c3f387]

        cid#1509238 silence Dereference null return value
        
        Change-Id: Ibb11b5e3de8c4b31fbf0e80be394778f32224555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138581
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [e6ce52bb1769c26e620f96130b9078e1de021df8]

        cid#1509221 silence Dereference null return value
        
        Change-Id: I28c5479106e6521f52ec25d98c3ae0565fc1596b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138579
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [bdc753d06f1306877f8adfffd0f86be7a1a1f754]

        cid#1500474 rearrange to avoid Dereference after null check
        
        Change-Id: I0cb4a8bc80b73fe6048540fc368096131ae0c231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Caolán McNamara  <caolanm@redhat.com>  [9cabb7ca71dfc426b9925300c4214f05399bfd12]

        always transport the text dxarray as doubles when rendering
        
        continue to do rounding to integer, just transported as double,
        unless the opt-in TextRenderModeForResolutionIndependentLayout is set,
        so this is not intended to create visible changes
        
        though
        nRunAdvance = static_cast<tools::Long>(nRunAdvance*fUnitMul + 0.5);
        becomes
        nRunAdvance = nRunAdvance * fUnitMul;
        in MultiSalLayout::ImplAdjustMultiLayout which might create a
        difference, but it is in the glyph fallback case where things are a last
        ditch effort already
        
        Change-Id: Iebd4ff9a602d0fa29a5253d73e6372d274d0c8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138565
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [b930f5f668fd8d9aa759d5a4d38da20a140328a4]

        SwNodeIndex->SwNode in HTMLAttr
        
        Change-Id: Ic8935b1f7f2e4620173be23ccbb76295c0aed3c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [5cb761865edefadbf10e92783d3f402b12159beb]

        SwNodeIndex->SwNode in XTextRangeOrNodeIndexPosition
        
        Change-Id: I4ad5c7c1545031425b85040c7e176e9c18e412f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138571
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [2fddd7abe6c237ca8beabf51c159848d46c5d0ff]

        SwNodeIndex->SwNode in StealAttr
        
        Change-Id: Ieb808380b7eeeca1568945765c80d12c5ae9fc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Hossein  <hossein@libreoffice.org>  [482264a7c2058d50906c83219566d79c1cf3cbb9]

        Remove extra output from "bin/run -l" on Windows
        
        The previous output contained extra file names other than executables,
        but now we limit the output to *.bat and *.exe files.
        
        Change-Id: Ie785d1e4388780b290f6580d02af635279080412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138556
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [3c9777436db6a2600206949951420ccc2387a960]

        SwNodeIndex->SwNode in CalculateFlySize
        
        Change-Id: Ieea800ff515fbbbdbe3ba89b6e5d1016955553d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [43546af2e7af3f87482512411466c278a99dc8f0]

        Add a SwNodes::Delete variant that takes an SwNode
        
        and use it to replace usage of SwPosition::nNode with
        SwPosition::GetNode
        
        Change-Id: I67449ce1cba1ea33c975a546df6e348bffe2d280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [5bbe546488508a77dc9ca090f2e50191a88c509c]

        use more SwPosition::GetNode
        
        Change-Id: Idbf0f55c5b1542e5a0f8ef29b77bb391e861310e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138563
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Noel Grandin  <noelgrandin@gmail.com>  [c4d43643ac53249df870141eb8b89ea0e774b9a5]

        unique_ptr->optional in CollectBoxSelection
        
        Change-Id: Id9e32567805130985c96525d7de61ec6036ac9b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-20  Julien Nabet  <serval2412@yahoo.fr>  [3f1c90beafdfd5389e6e22eabca30f9429530ce0]

        tdf#150502: crash after clicking between the horizontal and vertical rulers
        
        0  0x00007f22e3b294f7 in o3tl::cow_wrapper<ImplB2DPolygon, o3tl::UnsafeRefCountingPolicy>::make_unique() (this=0x7ffc2dcc7640) at include/o3tl/cow_wrapper.hxx:301
        1  0x00007f22e3b2a305 in o3tl::cow_wrapper<ImplB2DPolygon, o3tl::UnsafeRefCountingPolicy>::operator*() (this=0x7ffc2dcc7640) at include/o3tl/cow_wrapper.hxx:329
        2  0x00007f22e3b18fe5 in basegfx::B2DPolygon::clear() (this=0x7ffc2dcc7640) at basegfx/source/polygon/b2dpolygon.cxx:1433
        3  0x00007f22eb42d882 in drawinglayer::primitive2d::OverlayCrosshairPrimitive::create2DDecomposition(drawinglayer::primitive2d::Primitive2DContainer&, drawinglayer::geometry::ViewInformation2D const&) const
           (this=0x55a582f57d40, rContainer=...) at svx/source/sdr/overlay/overlaytools.cxx:244
        4  0x00007f22edae9e41 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const (this=0x55a582f57d40, rVisitor=..., rViewInformation=...) at drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx:36
        5  0x00007f22e2da32a7 in drawinglayer::primitive2d::ViewportDependentPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const (this=0x55a582f57d40, rVisitor=..., rViewInformation=...) at drawinglayer/source/primitive2d/primitivetools2d.cxx:70
        6  0x00007f22edae80c6 in drawinglayer::primitive2d::BasePrimitive2D::getB2DRange(drawinglayer::geometry::ViewInformation2D const&) const (this=0x55a582f57d40, rViewInformation=...)
            at drawinglayer/source/primitive2d/baseprimitive2d.cxx:73
        full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=181888
        
        Regression from a447b5b6d1114111c92e5e3e3f3ae83d4c2f3bca
        
        Change-Id: Ide5c03124d11ffe02c0510318d2198f25ea645f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138564
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-08-20  Khaled Hosny  <khaled@aliftype.com>  [9c2eb9c872bb10049fcb0217842b3bb849c27a22]

        tdf#373494: Correctly drop NotDef glyphs in mixed direction fallback runs
        
        Code drops NotDef from base layout if the glyph exists in a fallback
        run, but a fallback run can have multiple (sub)runs in mixed direction
        text and code was checking only first (sub)run.
        
        Change-Id: Ica7579565e6f6a791f312299e25f1268fc03f5d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138567
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4c96abd81460977d413d4d28e891bbbac5769ede]

        explicitly build for x86_64 in jenkins' mac-tinderbox configs
        
        Change-Id: I04511d12b1c6e500790448343320944eeb97a142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138519
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-08-19  Michael Weghorn  <m.weghorn@posteo.de>  [31e40de94c2e1c54b80ba963e26207125ee365e7]

        qt a11y: Report underline text attribute
        
        The IAccessible2 doc for text attributes [1] that specifies
        the format of text attributes also generally used by Qt has three
        different attributes for underlined text:
        
        * "text-underline-style"
        * "text-underline-type"
        * "text-underline-width"
        
        Map from LO's underline type to all of them
        where possible.
        
        Note however that Qt's AT-SPI adapter only
        actually maps "text-underline-type" to an
        AT-SPI equivalent, so e.g.
        `awt::FontUnderline::WAVE` will just be
        reported by the Orca screen reader as
        "underline: single".
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        
        Change-Id: I8fdca8ff23e0ca9f3e400617b03843439e8e8304
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138532
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-19  Michael Weghorn  <m.weghorn@posteo.de>  [1188364a28324b50ce40983fe5890cc960c7649f]

        qt a11y: Report (background) color text attribute
        
        ... using the "rgb(r,g,b)" format as specified in
        the IAccessible2 spec.
        
        Tested that Orca correctly announced both, text and
        background color in Writer when requesting it to announce
        the formatting using the Orca_Key+F keyboard shortcut
        (with Orca_Key being Numpad_Insert by default).
        
        Change-Id: Ie8b90dff872d7719617d68cd074efdab10d44dd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138531
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-19  Michael Weghorn  <m.weghorn@posteo.de>  [99841da686625428b8ad2e219dd19e5fbfb145f5]

        qt a11y: Report font style text attribute (e.g. italic)
        
        While the Qt doc for `QAccessibleTextInterface::attributes` [1]
        doesn't mention what format the returned string should have
        to report the attributes, the expected format for the text
        attributes is as specified in the IAccessible2 doc for text
        attributes [2], and Qt's AT-SPI adapter then converts that
        to the format as needed for AT-SPI, s. [3].
        
        Tested that Orca correctly announces "style: italic" when
        requesting it to announce the formatting using the
        Orca_Key+F keyboard shortcut (with Orca_Key being Numpad_Insert
        by default).
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        [2] https://doc.qt.io/qt-6/qaccessibletextinterface.html#attributes
        [3] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=4842cc176881ae22e14ca193fba46c6a04d09530#n1924
        
        Change-Id: I9877d1be0b6c9b82815e57f35ae28abe2ed99851
        
        Include
        
        Change-Id: Iddf974540c71f91d4078c2f99daa320474a445a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138530
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [e5606718a19592c1371b44fc5159a1ba0f2fffcd]

        ofz#50242 just stop fuzzing if there's a lot of graphic inserts
        
        Change-Id: I3d023f1cbe85642db2462a071ce80d965755f130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [f0827c392641b45647241b3a22e24a95e2b595e3]

        Resolves: tdf#150496 we want the AtkObject get_parent function
        
        GtkAccessible overrode it, but we expect the AtkObject implementation
        
        Change-Id: I5064bc619b11052bd22f9c75043b3e42697ebfc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [e15a5e6087eb0069f6e01089a3574314521f9244]

        ofz#50271 Out-of-memory with outsize line thickness
        
        Change-Id: Ia99e31c27b53110ae342cc49ba835a0b2f0224f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [d522a31a095eacc8eadc26419c02bd939c195c6b]

        implement line arrangement valueset a11y getLocationOnScreen
        
        directly rather than the default which iterates through the a11y
        parent to calculate it, which doesn't work when hosted in a gtk widget
        
        Change-Id: I90264a99c859a8b2a50daaf3befb016569b5a3ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Pranam Lashkari  <lpranam@collabora.com>  [174d78a887b0f80bad149f16e1e3b53e04ba8af7]

        added nullptr guard
        
        solves the segfault introduced in d365da2c4
        
        Change-Id: Ic9ab0c9e18a562cdc2120b1e1300c9b44e3f0900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138522
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-08-19  Pranam Lashkari  <lpranam@collabora.com>  [faf24c3aa5cbefda77367600f5c2185ca7886b3c]

        sw: online: make sure commment removal notification is sent
        
        problem:
        when comment is added inside a table in online,
        and entire table is deleted, comments were not removed
        due to notification not being sent.
        
        Another failed case was when some text with comment is
        copy pasted, and then pasted text is undoed,
        text was removed but comment stayed.
        
        This patch will notify comment removal before actaully distroying the comment/note
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I70aad7eb421b4bde52b9e54855e2360c59807852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138398
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138521
        Tested-by: Jenkins

2022-08-19  Khaled Hosny  <khaled@aliftype.com>  [2a78fbf4e4a49f2b52aa1352aac41ee024d0cf72]

        tdf#91764: Combining marks from “complex” scripts can’t be searched for
        
        Don’t skip search results that are in the middle of a grapheme cluster
        (AKA cell in LO speak).
        
        It is not clear why it was done like this, as these checks are present
        all the way back to the first commit of this file:
        
        commit 36eb193f4809221af42c01c5ac226a97cf74ec21
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Tue Apr 8 15:01:00 2003 +0000
        
            INTEGRATION: CWS calc06 (1.1.2); FILE ADDED
            2003/03/26 15:54:42 er 1.1.2.1: #i3393# moved from i18n module, cleaned out tools module usage, and added support for regexp
        
        But ignoring such results and only for so-called “complex” scripts seems
        arbitrary, and as the linked issue shows, people want to be able to
        search for combining marks. Furthermore, it prevents searching for a
        base character followed by a combining mark, unless ignoring diacritics
        is enabled.
        
        Change-Id: I530788d928861ddfa18dd7b813d0a13f53c0b77b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138410
        Tested-by: Jenkins
        Reviewed-by: خالد حسني <khaled@aliftype.com>

2022-08-19  Noel Grandin  <noelgrandin@gmail.com>  [f505d8fee149f089090b208db99a7b4107af76e9]

        unique_ptr->optional in SwFormat::SwClientNotify
        
        Change-Id: I9ac4a1c538fd45a7002f618966494b43245cb3c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Liu Hao  <ianahao331@gmail.com>  [466f86abb7208e853ad48ae46e97a2455667fa42]

        tdf#148430 Use std math functions instead of rtl::math
        
        Change-Id: I6bcb33d51c3974d0e8905e1ffeac556a99870aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138294
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [6e97fcf162b8495f0584f0bb67d020b3f3754780]

        ofz#50335 Out-of-memory
        
        Change-Id: I4a7dd1e0fc21518cc0efcb6a115f1946adef7aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Stephan Bergmann  <sbergman@redhat.com>  [d305edc242b7d1c03bd372356104418a344737fe]

        Update the reference rdbs to libreoffice-7.4.0.3
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.4.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        * no changes
        
        .../master/instdir/sdk/bin/unoidl-read --published \
         .../libreoffice-7.4.0.3/instdir/program/types.rdb \
         .../libreoffice-7.4.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I2e462a9fe8db2fabf5e5599e77962581cb1766ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138520
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-19  Stephan Bergmann  <sbergman@redhat.com>  [3a04cfe27b433a6be22fff39212e2432f91f8747]

        Upgrade external/boost to latest Boost 1.80.0
        
        <https://dev-www.libreoffice.org/src/boost_1_80_0.tar.xz> has been generated (on
        Fedora 36) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.80.0/source/boost_1_80_0.tar.bz2
        > $ printf '1e19565d82e43bc59209a168f5ac899d3ba471d55c7610c677d4ccf2c9c500c0 boost_1_80_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_80_0.html>
        > boost_1_80_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_80_0.tar.bz2
        > Unpacking boost_1_80_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_80_0.tar.xz ...
        > Cleaning up ...
        > 322e567e98c466c0aa0e380ed8c647552fe4af48998648428f1b5f0c8eff4666  boost_1_80_0.tar.xz
        > Done.
        
        * In StaticLibrary_boost_filesystem,
        <https://github.com/boostorg/filesystem/commit/36cf9aaf816a39dce3d32e2bfe09e214d7f3ab64>
        "Updated protection of remove_all against CVE-2022-21658 on POSIX" had
        introduced uses of certain POSIX *at functions (like utimensat) conditionally on
        some new BOOST_FILESYSTEM_HAS_POSIX_AT_APIS, to be discovered by
        workdir/UnpackedTarball/boost/libs/filesystem/CMakeLists.txt which we don't run.
        At least AT_NO_AUTOMOUNT, as used in
        workdir/UnpackedTarball/boost/libs/filesystem/src/operations.cpp, appears to be
        unavailable on the macOS baseline, but otherwise assume that all that POSIX
        functionality is available on all other non-Windows baselines and hardcode that
        in external/boost/StaticLibrary_boost_filesystem.mk.  (If it turns out that we
        need to exclude some more platforms there, we /might/ need to backport
        <https://github.com/boostorg/filesystem/commit/5864f397ccad30f6e73221b90bdac57a303b9752>
        "Fixed a missing include on POSIX systems that don't support *at APIs" from the
        develop branch towards Boost 1.81.)
        
        * In StaticLibrary_boost_locale,
        <https://github.com/boostorg/locale/commit/41868c62a0519799696b544518f1efd831ff71c2>
        "Support systems without implicit include path" had moved source files around
        (and then would have failed with
        
        > workdir/UnpackedTarball/boost/libs/locale/src/boost/locale/shared/mo_lambda.cpp:7:10: fatal error: 'boost/locale/shared/mo_lambda.hpp' file not found
        > #include "boost/locale/shared/mo_lambda.hpp"
        >          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        etc. without the additional -I option).
        
        * Some Clang builds would have started to fail with
        
        > In file included from desktop/qa/unit/desktop-lok-init.cxx:19:
        > In file included from desktop/inc/lib/init.hxx:20:
        > In file included from workdir/UnpackedTarball/boost/boost/container/flat_map.hpp:26:
        > workdir/UnpackedTarball/boost/boost/container/new_allocator.hpp:168:12: error: '__cpp_sized_deallocation' is not defined, evaluates to 0 [-Werror,-Wundef]
        >       # if __cpp_sized_deallocation
        >            ^
        
        so add another external/boost/include/ wrapper.
        
        Change-Id: I5e53f7ddab07eadba9bdf653acad571f50517b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138511
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [390c7b97ad674a8281735980120733a48e5d89a3]

        use more SwPosition::GetContentIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Iaf038c006fc9f82073664536278aac4d44754340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138512
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Justin Luth  <jluth@mail.com>  [eb8252f738bfd1689edee205c6a5e13643f89c29]

        fix tdf#77964 patch: don't change DefaultFormat
        
        I was actually making a chnage to the default frameformat
        instead of using a copy of it. Not at all intended.
        
        Change-Id: Idcb27eacd5b536914bc14d6086e730a42105ced3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138302
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [44f64ca9e71bd15e385ac40bf4e726472b107f70]

        vcl: make mapping functions private in OutputDevice
        
        Change-Id: If19db43248d9144f83a205890b3a00a23fcb6267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138040
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [5dbd9a7bb934fbe182a3fa2423f506563bd1ef8f]

        tdf#150336 add a static_assert to catch that happening again
        
        Change-Id: I96e0ef15aec28250c1e408d16e76cd4443b88ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Hossein  <hossein@libreoffice.org>  [a6c50882fd3fd90a7eaca81b311640e86eced9fa]

        Fix "bin/run -l" to work correctly on Windows
        
        On Windows, the script did not run correctly because of the "return"s.
        Here, we use "exit" instead.
        
        Also, there were many files with the same name but with different
        extensions in the output. Now, we only print out the names using grep,
        awk and sort utilities.
        
        In addition, a description for bin/run is added to bin/README.md
        
        Change-Id: Ifb106c89199ebc5a9debf6caef80bd1edf143b20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138514
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-19  Caolán McNamara  <caolanm@redhat.com>  [673bff36bc310252dd4d95ca9e31a0f69ba4454d]

        Resolves: tdf#150336 overlapping slot ids
        
        Change-Id: I54fc92d1d7afd61febbbb057868b038864f29ec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138510
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d045ef37475a993738855abde82fca90626f3b2]

        tdf#150331: sw: Add UItest
        
        Change-Id: I2b6d70a3036d2e7cfce6544a6304bf766ae34ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138500
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-19  Pedro Pinto Silva  <pedro.silva@collabora.com>  [75c14600a559f1e8e5cce52ba66e30d4a22a281d]

        Fix btn image size inconsistencies on CustomAnimationsPanel
        
        Animations btns (Add, Remove, Move Up, Move Down)
        - Images were being loaded from different locations
        - Images did not share the same size
        
        Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
        Change-Id: I33c033d50c802b7f2c9506b2c5a7b82967af7db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131551
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138487
        Tested-by: Jenkins
        Tested-by: Andreas Kainz <kainz.a@gmail.com>
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [e956091ad8ebfa77294e130bf2b5cf0200578fdb]

        Remove code duplication in GraphicDescriptor for EPS
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for EPS files
        
        Change-Id: I108aefc56a0e9215eaeef3ae2a7b4d884f0a5373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138208
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [416168c01097563fc1773b9f1986dee7e43e5d9c]

        Remove code duplication in GraphicDescriptor for PCD
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PCD files
        
        Change-Id: Ic49f9b7ebfbe4e756d7c4f1067958bd7a2ac0154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138207
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [e2043fd557200efc71ac8f014b79a40be2eaef76]

        Remove code duplication in GraphicDescriptor for PCT
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for PCT files
        
        Change-Id: I67b9d2ada18d5c141dd108564a4e8b632fc7299a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138189
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [ea75ae547eaf69f7b4063264fe4c811d044a5798]

        Remove code duplication in GraphicDescriptor for SVG
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for SVG files
        
        Change-Id: I5ababbd43ece4e8c08c5833895dc0b56ad467f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138102
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [735c6412deb4934e28ded552466be034a7b7b3fe]

        Remove code duplication in GraphicDescriptor for XPM
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for XPM files
        
        Change-Id: I9a5919cb4144edf70edc71ed89ab2cb0d605158a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138070
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [ca5e7672d6f0d149373aae00db082758bf3d1715]

        Remove code duplication in GraphicDescriptor for XBM
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for XBM files
        
        Change-Id: Id3cf1e573ec3125830299e49f0a99aab7b3fe77e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138069
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [d5472c797df5831bb95650ad8f3c0cf94512b819]

        Remove code duplication in GraphicDescriptor for WMF/EMF
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for WMF/EMF files and their Z
        compressed counterparts WMZ/EMZ
        
        Change-Id: Ia054c782320923aaa0c2c8bda2f33c27c3b123d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138067
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  offtkp  <parisoplop@gmail.com>  [45705461d4597b736c44e006360f9072eed3fe85]

        Remove code duplication in GraphicDescriptor for DXF
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for DXF files
        
        Change-Id: I13a3c40ee35259b6b61aa323f4fa5af73290e94b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137935
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [c61d9e70b1bf4948408392217b9fbed9a2dc5ab1]

        vcl: rename AnimationData fields to more sane names
        
        Change-Id: I5b3ae32b562f300fb33ba8daf5ef438268725a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76431
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [f57a7b374e0f2d878cee1fa020af3323145b56a8]

        tools: use std::swap() in gen.hxx
        
        Change-Id: I01df93aa825ab7a023cd4beb385b5fb41c2847ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137389
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [e1ab83cbc47ff581dd826d757dd2997743f47d58]

        svl: rename SfxRectangleItem::aVal to maVal
        
        Change-Id: I7bc86de644749fb42eba89872828b15be47bb0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137380
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-19  Noel Grandin  <noelgrandin@gmail.com>  [9a3cde8f2ad603cf0c57eab66276dea977b20de8]

        no need to allocate these separately in SwStyleManager
        
        Change-Id: Id2ff4612506861a11b03cd0ab458400c7e278c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Noel Grandin  <noelgrandin@gmail.com>  [7d1b8ae00edc4510d754147aa2b3381accd0fa38]

        unique_ptr->optional in SwFontSave
        
        Change-Id: I57acbc3f43eed6db49e475377b18c0c497acc8c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138504
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Noel Grandin  <noelgrandin@gmail.com>  [bf09ac2981ea1e6ee9aa1c6c3c94299a8b9ec2de]

        unique_ptr->optional in SwViewShellImp
        
        Change-Id: I1f1862c846c2dac0a845b1e8035f447b33e487d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [aed6183b12f496e1dcb7429a88da9e521ba622a3]

        tdf#150331: update index only when text is inserted
        
        other branches of the
        if( m_bIsOverwriteCursor && !m_sOverwriteText.isEmpty() )
        condition do the same
        
        Regression introduced by 218acb48df79101392c2cc3a030ddb5dcee878c7
        "tdf#146728 lok: IME: preset formatting in the new paragraph"
        
        CppunitTest_sw_tiledrendering passes with this patch in place.
        I plan to add a test in a follow-up commit
        
        Change-Id: I0f63b2c802b1280d16afeb18ad0f1735891e6a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138485
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-19  Noel Grandin  <noelgrandin@gmail.com>  [4478a78767e1d03126de4d875704a6b88ff132cc]

        convert more nNode to SwPosition::GetNode
        
        in places where we are using the result with operator<
        
        Change-Id: I2859b3e45bca141401feb557a27b4643280f8c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138502
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-19  Stephan Bergmann  <sbergman@redhat.com>  [fecfdf01505cd1326a864c27f61a535921d2fe30]

        Some more use of TOOLS_WARN_EXCEPTION
        
        CppunitTest_dbaccess_tdf126268 had oddly failed once for me with
        
        > [_RUN_____] Tdf126268Test::testNumbers
        > Fontconfig error: Cannot load default config file: No such file: (null)
        > warn:legacy.osl:4121315:4121315:dbaccess/source/core/dataaccess/ModelImpl.cxx:765: ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage from!
        > warn:legacy.osl:4121315:4121315:dbaccess/source/core/dataaccess/ModelImpl.cxx:765: ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage from!
        > warn:legacy.osl:4121315:4121315:dbaccess/source/core/dataaccess/ModelImpl.cxx:765: ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage from!
        > warn:legacy.osl:4121315:4121315:comphelper/source/misc/logging.cxx:63: EventLogger_Impl::impl_createLogger_nothrow: caught an exception!
        >
        >
        > Fatal exception: Signal 6
        > Stack:
        > workdir/LinkTarget/Executable/cppunittester(__interceptor_backtrace+0x5b)[0x5589724dcd5b]
        > instdir/program/libuno_sal.so.3(+0x62188d)[0x7fb0bba3888d]
        > instdir/program/libuno_sal.so.3(+0x6210a9)[0x7fb0bba380a9]
        > instdir/program/libuno_sal.so.3(+0x61eba6)[0x7fb0bba35ba6]
        > /lib64/libc.so.6(+0x3ea70)[0x7fb0baefea70]
        > /lib64/libc.so.6(+0x8ec4c)[0x7fb0baf4ec4c]
        > /lib64/libc.so.6(raise+0x16)[0x7fb0baefe9c6]
        > /lib64/libc.so.6(abort+0xcf)[0x7fb0baee87f4]
        > instdir/program/libEngine12.so(+0x3075ac9)[0x7fb029552ac9]
        > instdir/program/libEngine12.so(+0x3075c32)[0x7fb029552c32]
        > instdir/program/libEngine12.so(+0x318e53c)[0x7fb02966b53c]
        [...]
        
        and it might have been interesting to learn what that caught exception was.
        
        Change-Id: I3597ed22b4f02a8fa08f1cd36aa64d210e48356d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138509
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-19  László Németh  <nemeth@numbertext.org>  [f4668540ff7256bb0ddd382dfaf9f3499e99128a]

        tdf#150443 sw: fix crash of rejecting table row deletion
        
        Joining "Delete" redlines of deleted table row with
        overlapping tracked formatting change with same time stamp
        resulted bad tree parent in Manage Changes dialog window
        (tracked formatting change instead of tracked deletion,
        see its pencil icon before this fix), crashing at its rejection.
        
        Regression from commit eebe4747d2d13545004937bb0267ccfc8ab9d63f
        "tdf#144270 sw: manage tracked table (row) deletion/insertion".
        
        Change-Id: Ia0f0b1fdff96f4acbe14025f8016e39ce95c7f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138474
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [5ac75131556b687a01517ce4520a05bb49c1d840]

        Use combobox for category list on Elements sidebar panel
        
        And replace GtkPaned with GtkBox: the elements are not expected
        to have a resize handle between them.
        
        Change-Id: I9ba170458754fe28052007e8051d3814dc7d2ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138501
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [f85cd07295321cf875addeb52aa9e982808b74ae]

        tdf#150462 set mode to keep scaled glyph positions as floating point
        
        and match render settings to best support that
        
        Change-Id: I623f9e578ee6c3fe54a966342b3cdd16b31f219a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138450
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [1fa731d03ba0f22cb9392a578124ea977eaab2e9]

        tdf#150462 don't prescale dxarray before using DrawTextArray
        
        setup the device scaling instead and pass in the unscaled dxarray and at
        least give vcl the chance to retain some accuracy
        
        Change-Id: I17660eb77adf8586be6eb54e61bded3a5bcc20a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [b72ebcf5b26ab2e54c5251c5c45e6d45cade9236]

        cid#1509258 Dereference null return value
        
        Change-Id: Iebe32d16b3a294e60cca59c49de3da4b1f142e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138498
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [3996ced5fbc75ed6a528969e29642eb60b7b6be5]

        cid#1509291 Unchecked dynamic_cast
        
        Change-Id: I1289113a9ba65a671ba79bca1eca4cf9ecbbb10f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [f63ffcba32527d04abbd460dddd3e5ca63d695df]

        cid#1509286 silence Out-of-bounds access
        
        Change-Id: I35e84803c766e0932899f55d73922236260cb5e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138477
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Stephan Bergmann  <sbergman@redhat.com>  [91ba9654baa8d525e31614b03cd459cf7cb1f951]

        Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxx
        
        ...so that its TOOLS_WARN_EXCEPTION can be used in
        comphelper/source/misc/logging.cxx in a follow-up commit.  (And while at it,
        rename from diangose_ex.h to the more appropriate diagnose_ex.hxx.  The
        comphelper module is sufficiently low-level for this immediate use case, so use
        that at least for now; o3tl might be even more suitable but doesn't have a
        Library until now.  Also, for the immediate use case it would have sufficed to
        only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION,
        TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of
        include/tools/diagnose_ex.h into an additional new
        include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move
        the complete include file as is.)
        
        Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9144e8c3f4dd9c0460ea8f258682825688920537]

        Fix typo
        
        Change-Id: Id785575c297d7e3e8867db319ddb4bffa0496426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138496
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-18  Henry Castro  <hcastro@collabora.com>  [aaf6fc8ad599bd81155fe95414dc95481c2501ac]

        sw: lok: fix removing redlines annotations
        
        The redlines annotations has a logical remove
        and it fails to notify client side.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Iba228b4d6001b8c9009332f6889b7b78bc847247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138312
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        (cherry picked from commit ddc478a9afb89dd24cfa00ca2edef5d7d7fd4a71)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138426
        Tested-by: Jenkins

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [1528f6935e5f63103c6a4e901394fca46c243627]

        cid#1327197 UwF: Unwritten field
        
        Change-Id: Ib132101078a67803d21393c875e55f7a7bf8d225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138471
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fcfb30e81af51beaa6f4739280e555335c0167e5]

        windows packaging: remove unused msp creation
        
        Change-Id: I71903967f89d968d963f66a3e160d6dead7757f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138011
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-08-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [de3fcf4bea142fa376b043862ef2bde1db32098f]

        crashreport: __cpuid/__cpuidex are not available on arm64
        
        …and from a quick glance similar features are not exposed to userland
        applications on arm64:
        
        https://docs.kernel.org/arm64/cpu-feature-registers.html
        "The ARM architecture defines a set of feature registers, which describe
        the capabilities of the CPU/system. Access to these system registers is
        restricted from EL0 and there is no reliable way for an application to
        extract this information to make better decisions at runtime.[…]"
        
        Thus the CPU information would have to be gathered from the OS, probably
        from the Windows registry, at least it should be possible to read the
        name/model that way…
        
        Change-Id: I39e3679a7c4c581d8e3e4f71842d7ea7cdc2ba67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138380
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [64c60a67930ebf9a1b19b4396c9fea3c4c973e62]

        cid#1509305 Dereference null return value
        
        Change-Id: I17175b9ce05b784844e49aed53d85a55e33a0f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [b95038cd6795eec03989c708c1d05a894043dbc8]

        cid#1509313 Unchecked dynamic_cast
        
        we can get the ScDocument another way
        
        Change-Id: Ie1953b911d34a647fbac1923bc9166f67f346a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138483
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [f6e24b10c9148f1cf6a2a93359ffcc0c7ec56152]

        cid#1500536 silence Resource leak
        
        Change-Id: Ibd626a90136f89af731dc2bfa684d99609d44b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [1b3d662f291d10e42232f9f842affe5ad35035f0]

        cid#1500387 alternative silence Resource leak
        
        This reverts commit d40bfecddcac38006ee989d8072fb2b453cf6b9f for
        a different approach
        
        Change-Id: I8e058efbff214456b91346ce16e7eba7a89a8a53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [6105706deb71aa134f2f754aed6f50daf3b8d620]

        cid#1500586 Resource leak
        
        Change-Id: I32d837af7574f6eb4ac7db4759139d0b78f63e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138479
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Justin Luth  <jluth@mail.com>  [1ad2d1336a3f82e13e2bdfe979154c3a8c936ed6]

        related tdf#150197 doc import: ANLV - always SetListFormat
        
        Any time there is numbering, we expect to see an
        optional sListFormat set.
        
        This solves a few different cases found by:
        assert(false && "depricated format still exists
        and is unhandled. Inform Vasily or Justin");
        
        Change-Id: I127e100a003c46c7a9dfa681014ffc11ceda24ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138452
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [6e1be9f852f8b4901f3ae030fa50282c4468d61e]

        cid#1500645 silence Resource leak
        
        Change-Id: I1548017a39f5080dce0731169811fcb0a059c4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138478
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [05dba1a1236c662664d73bff322e4a54036f0860]

        cid#1509312 Unintentional integer overflow
        
        Change-Id: I93ca395f6a74dd6c67d4388512b5de3441b362fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [9446efdf587a7c37724a0b8f684d670fd8fda157]

        cid#1500682 silence Untrusted loop bound
        
        Change-Id: I44ae78fe7427d2647e3efe2688be8c124c16743c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [292fd4d83bba706a10926465b390fa5bc0d4e1ce]

        cid#1509254 Uninitialized scalar variable
        
        Change-Id: I2d1f0944a069230a435890734eb18e8ee3e275e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138470
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ef40d3be2f21fa11db3984f86251ee162a70ca57]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21c64d4e09d23bf8933f8d513a857d4df3029cfa
          - Update LO7.4 new features video
            
            Change-Id: Ic1290ef2d90aca04f1bf6df1aae5d19f64f5919f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138486
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-08-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7d5c4a1777a9ed187ffa269755e79273a24e5620]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to abecf1a85a2dded5a59c543f275df51d79f649bc
          - tdf#150445 Change Gear icon to Hamburger icon
            
            Change-Id: I7abe1c0d84550baad982d694922119a1af827bd0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138377
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-08-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [410bff99a708371eed6a82677b44e2151a4a990a]

        tdf#149768 Do not fix Templates dialog width and height in pixels
        
        This patch removes the fixed size of the Templates dialog in pixels so it works better in HiDPI displays.
        
        This patch also makes the dialog a bit wider and non-resizable.
        
        Change-Id: I256d8d5c8b76c8e32a4f008f3a235f80bf59634d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136922
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [010e2a574c7fadfb60d6794a1bfb38acc8082e0a]

        loplugin:moveit
        
        Change-Id: I34de7408553e4ca702cab9aa611c03dc60b9b6a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-18  Tünde Tóth  <toth.tunde@nisz.hu>  [e59db22b3b57c9e1a5678218cb56fb75bcc84c26]

        tdf#150434: chart2, XLSX import: strip long legend labels
        
        Full text of legend labels could overflow the chart area,
        if the legend text was too long. If it's longer than
        520 characters, strip it at the first space from the
        500th character (or if there is no space, at the 500th
        character). This results better XLSX interoperability, too.
        
        Change-Id: I23a94f6baaf620b40e9b2819738eba5c5a921722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137492
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [326534372ee5436d2f6e972de46fc01bb635e9d9]

        no need to allocate these on the heap
        
        Change-Id: Ia5eec87a4b36ac2dd15c3369bd7c630277a177c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6535669f9532b61ee5906d4b1339bc9af4b0882]

        use more pass-by-value in SfxItemSet
        
        which avoids some copying
        
        Change-Id: Id774c8947d0c2676425a1a192e0ac28c8f8402db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138468
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-18  László Németh  <nemeth@numbertext.org>  [f0454fe3bb5f8b589cc994203060a94d5cdad0a4]

        tdf#150394 sw: fix crash of "Don't hyphenate last word"
        
        Multiline last words, e.g. long URLs resulted crashing
        using the new hyphenation option "Don't hyphenate last word".
        
        Follow-up to commit 8c018910ae4d8701b1ce2a95727b9baed4016da3
        "tdf#149248 sw offapi xmloff: add option to not hyphenate last word".
        
        Note: .fodt format is not applicable for unit testing.
        
        Change-Id: I8633af1517f09003b40a06825ad14f3ed7f882a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138296
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [30d454e1498f74981d0e02c4121e7f4192aa3447]

        cid#1509397 Uninitialized scalar field
        
        Change-Id: I250a900298f455ce594bf7dd99acbe984efc5ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138466
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [67224d9ea094ac3db7bf9f8dd77bc1245ca5eb85]

        cid#1500394 Explicit null dereferenced
        
        Change-Id: Ie97b047b793c0d9546a17f9e9f1d20cbeed62626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138469
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Stephan Bergmann  <sbergman@redhat.com>  [b2760b7d2a3fa74f5cb4d477d44d9cef33c5065c]

        external/epoxy: Fix -Wint-conversion
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311>
        "Strengthen -Wint-conversion to default to an error", causing
        
        > workdir/UnpackedTarball/epoxy/src/gl_generated_dispatch.c:114547:77: error: incompatible integer to pointer conversion passing 'uintptr_t' (aka 'unsigned long') to parameter of type 'GLhandleARB' (aka 'void *') [-Wint-conversion]
        > GEN_THUNKS(glAttachObjectARB, (GLhandleARB containerObj, GLhandleARB obj), ((uintptr_t)containerObj, (uintptr_t)obj))
        >                                                                             ^~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/epoxy/src/dispatch_common.h:150:40: note: expanded from macro 'GEN_THUNKS'
        >     GEN_GLOBAL_REWRITE_PTR(name, args, passthrough)                  \
        >                                        ^~~~~~~~~~~
        > workdir/UnpackedTarball/epoxy/src/dispatch_common.h:95:14: note: expanded from macro 'GEN_GLOBAL_REWRITE_PTR'
        >         name passthrough;                                        \
        >              ^~~~~~~~~~~
        
        etc.
        
        That only hit on macOS because of the different
        
        > #ifdef __APPLE__
        > typedef void *GLhandleARB;
        > #else
        > typedef unsigned int GLhandleARB;
        > #endif
        
        in OpenGL's glext.h, which
        <https://github.com/anholt/libepoxy/commit/0cfb0a044bc43245409c020e2ca34091c96283d4>
        "Fix most GLhandleARB warnings on OS X with a big comment in our code" had tried
        to address by adding "a cast to uintptr_t to shut up the compiler" in its
        src/gen_dispatch.py (but without stating what compiler diagnostics exactly were
        supposed to be silenced by that cast that now started to cause the above issues
        with Clang 16 trunk).
        
        It turns out that at least my macOS build with Clang 16 trunk builds fine
        without that cast, so just drop it for good.  (And patching epoxy's
        src/gen_dispatch.py means that UnpackedTarball_epoxy needs to switch from
        gb_UnpackedTarball_set_pre_action to gb_UnpackedTarball_set_post_action.)
        
        Change-Id: I2c87bca2cc5510d17098028d4532989f48e349a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138407
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [5db76fd0eca0c80b1e54cdf4a7fea769f5dbc5a4]

        tdf#148671: sw_ooxmlexport16: Add unittest
        
        Change-Id: I634a1f31c93c9186be6aea35f4a020cceed6dd9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138459
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-18  Caolán McNamara  <caolanm@redhat.com>  [1286014bbfad29e99634d62111e1ccef2f5e9a2b]

        cid#1485150 Uncaught exception
        
        Change-Id: I793683bfb59ff6b8751baa14a999b699cc28fdc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138467
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-18  Liu Hao  <ianahao331@gmail.com>  [bef0cfcf2a6d0a70adb6ddc5558d5a888edb718c]

        tdf#39593 Ruduce copy/paste code in Converter::converterDuration
        
        Change-Id: Ic1b82b244ff614c8d5ab44f32bdc728deee24165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138465
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [712901b388d8645d94e14b474288f97761f5a4e5]

        Fix typo
        
        Change-Id: Ie0757b332f4ddb0e9d9d6e2c97b7497766221dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138310
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1bcb84a39106de1f082521d1765bb41864f280ea]

        Fix typo
        
        Change-Id: I6daee630eb433998711091780452dc0534398f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138460
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9923f2416b63abc09bf8cd83796d1d681e9de225]

        chart2: improve keys (symbols) rendering in a data table
        
        - better symbol positioning taking symbol height and cell height
          into account.
        - symbol height depends on font size (as with the legend)
        - take symbol aspect ratio into account
        - remove hardcoded values
        
        Change-Id: I3537d82538035cd31b928d4bb6fc5572914fcd13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138463
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e425ee936ee762825a20cd10e6027163eab747a2]

        chart2: convert the fill color only when style is "solid"
        
        The CharBackColor should only be set when the fill style has the
        value "FillStyle_SOLID", otherwise don't set it as we can't handle
        any other fill style.
        
        Change-Id: Icaec8996d47966bb32bd8cf88b8c5aad70ab07a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138462
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3115a9f3a903f14a71003f51dc30eed824ea92fb]

        oox: set fill properties correctly for the data table at import
        
        Change-Id: Ia108c5b67e85ba770bd84d90ad1d3dd27046b245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138461
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [66faff4d3c9756e4a83933a07e2f9329ede9e043]

        chart2: use only one "Data Table" string to simplify translation
        
        Change-Id: Idff337523a66195277b364be474baffcebca26aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138369
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-18  Noel Grandin  <noelgrandin@gmail.com>  [1085810635c1a666e31ca4614f5f32b30af5fb1d]

        convert more nNode to SwPosition::GetNode
        
        in places where we are using the result with operator<
        
        Change-Id: I3440d1204e69e30f21eaf833c2d0c42cde59e55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138454
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-18  Miklos Vajna  <vmiklos@collabora.com>  [ca05ad4c8dac439c676f84e13bb8949e81bca72e]

        CppunitTest_sw_ooxmlexport15: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I5b4e566139e37be0f8f106521600127ef72e20da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138453
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ca8760a836c906c4ea7f85404ee7a187ebf57b24]

        Make ElementsDeck the default deck for Math first start
        
        Change-Id: I471e268b6bb55d0cac9faed1b6631724b08b34a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138457
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [29f230a63370ee92ede2716edee97798fc0aab71]

        Show Math sidebar by default
        
        Change-Id: Id807d0c39f78a3a4be2e5eb31c75b31b1790f71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [8475b367298de73aec6abc60a159cc015baf9734]

        tdf#150452: sc_subsequent_filters: Add unittest
        
        Change-Id: Idf7727f71fb27d6316c360bf6d3671c03a3e91cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138449
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-17  Noel Grandin  <noelgrandin@gmail.com>  [dcd45e25407bc4e50a3faa1ede9c1c3149c21ad7]

        convert more nNode to SwPosition::GetNode
        
        in places where we are using the result with operator<
        
        Change-Id: I2aae14e9130efc31f5afd3450defdf6df4099950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [7e8be84f54fb10d5ba97c64009403c79c3976393]

        fix SfxBindings::Invalidate(const sal_uInt16 *): Assertion
        
        assert `*pIds > *(pIds-1)' failed.
        
        seen in impress, view, outline, press tab
        
        Change-Id: Ie5b61aac614789f13e59c49ab390e07a7a0a55a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Noel Grandin  <noelgrandin@gmail.com>  [b3761810532c98da42a4bb6cda0d0abe67af5c24]

        use more SwPosition::Assign
        
        Change-Id: I2a073fc8350aa85e44e57b587450e012f411b47f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  Noel Grandin  <noelgrandin@gmail.com>  [3a02b5f8aae803b7b5a232c724135594483627a4]

        convert more nNode to SwPosition::GetNode
        
        in places where we are using the result with operator==
        
        Change-Id: I28f8f6fa2c3754ec6612ab2334c3a58b61ecd065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  László Németh  <nemeth@numbertext.org>  [a18a74d6762e56a20093ca51cfd12925697c2524]

        tdf#150200 tdf#150438 sw, DOCX: fix drop cap dash, quotation etc.
        
        In drop cap layout, set smaller size for all glyphs positioned
        over the baseline, e.g. dashes (dash, en-dash, em-dash, figure dash),
        bullet, asterisks and quotation marks by extending the bounding box
        of the glyph to the baseline, like MSO does.
        
        Add "DropCapPunctuation", a new default compatibility option for this.
        Only old ODT files loads the old layout (which was partially broken:
        e.g. dashes were too long, often missing from the drop cap area or
        the drop cap was disabled). New ODT and imported DOCX documents
        use the new default layout for better typesetting and interoperability.
        
        Change-Id: I3aba0727fd15f6edb9245e31f523e12f407d189e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138356
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-17  Stephan Bergmann  <sbergman@redhat.com>  [9135cdbc1a5fa09d00aee76215ff5cd369f82756]

        Missing test dependency
        
        > warn:vcl.builder:232474:232474:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui at xmlreader/source/xmlreader.cxx:67"
        > warn:dbaccess:232474:232474:dbaccess/source/filter/xml/dbloader2.cxx:460: DBG_UNHANDLED_EXCEPTION in load exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui at xmlreader/source/xmlreader.cxx:67"
        > unotest/source/cpp/macros_test.cxx:73:Tdf126268Test::testNumbers
        > assertion failed
        > - Expression: xComponent.is()
        > - loading failed: file:///tmp/Tdf126268Test__testNumbers_2f43ug.tmp
        
        Change-Id: Ic8b530418319b56b3da824ebb66fc3bef6b7809e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138444
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [938c899831bd5b165b2b7db3945867a1ce155483]

        tdf#150452: Revert "tdf#130795 use concurrent hashmap in SharedStringPool"
        
        This commit reverts 3749d9af3745c0eaff7239e379578e4e2af89e9d
        which removes the dependency on the external library cuckoo
        
        Without using cuckoo the same file in tdf#130795 takes
        
        real	0m4,892s
        user	0m5,298s
        sys	0m0,449s
        
        With it, it takes
        
        real	0m4,914s
        user	0m5,276s
        sys	0m0,444s
        
        pretty much the same time
        
        Change-Id: I4cc9000ac5bf26de22bb9835283ae8d5b3230196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [4d78ed5c00b9c3c59ed28d24c28fd00e0f3a7657]

        Update SF translation to Portuguese
        
        Change-Id: I96ae7fabb65e44e6d70f0c4048609f93aed8be1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137722
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2022-08-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [94e8f2e0cd07a90d0d2fd0138bdb8fd1f241ad58]

        Revert "workaround clang-16 complaint in skia"
        
        This reverts commit 7548748e34966174abed39f3682bae445f1c8bdc.
        
        No longer necessary after doing a fresh pull of llvm, so llvm
        is at commit 4c244b2833bdc51bbb7970ea6433e844dfddf622
        
        Change-Id: I6dc721b47a905f553b227db3a036899173b35bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  Michael Stahl  <michael.stahl@allotropia.de>  [7d730cd580e957ab06b0c7f020ac37dd0c337aa2]

        tdf#147466 sw_redlinehide: avoid crashing by delete un-deleting
        
        After the first delete, there is a single redline from 170,0 to 177,9,
        which contains a section.
        
        [ 169]  0x6133358            TextNode "b) 9 (Robin Cook, Jack Straw, Margaret Beckett, David Milliband, William Hague, Philip Hammond, Boris Johnson, Jeremy Hunt, Dominic Raab)",
        [ 170]  0x61349d8            TextNode "Hangul script is used to write which language?",
        [ 171]  0x61396f0         SectionNode ,
        [ 172]   0x6138cc8           TextNode "Japanese",
        [ 173]   0x613ab58           TextNode "Vietnamese",
        [ 174]   0x613ad78           TextNode "Korean",
        [ 175]   0x613bc28           TextNode "Chinese",
        [ 176]  0x24a61c0             EndNode ,
        [ 177]  0x6139568            TextNode "c) Korean",
        
        Then the next delete is from 169,137 to 170,0 and it is combined in
        AppendRedline() with the existing one, removing the existing one.
        
        Now the code for tdf#119571 at the end of AppendRedline() that splits up
        the one redline into 4 redlines, with the section start node and section
        end node not covered by any of them.
        
        AppendRedline() of a delete redline causing previously deleted nodes to
        become un-deleted is a situation that UpdateFramesForAddDeleteRedline()
        doesn't expect.
        
        Additionally there seems to be an issue with CheckParaRedlineMerge()
        setting the Section's m_bHiddenFlag, which was unintentional, it should
        only set m_eMerge flag, but fixing that isn't sufficient.
        
        Reportedly this crashes since commit
        6433dc223f6d21570e7132c4a580d186a5d5a334 but the problem appears older.
        
        Change-Id: Ic83a93d5aaec4ee562fb960693b52bd7b25cb1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138411
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-17  Michael Stahl  <michael.stahl@allotropia.de>  [477e489e71b4a96ff10d9f2d2b802d91dec3e319]

        forcepoint#108 sw: tweak a bit
        
        * the fly-at-fly case didn't work, iteration also skips it
        * delete the bad redline section in the nodes array
        
        Change-Id: I21d3635fb53068e79984b0ea74a0a0913513bd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138434
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-17  Jean-Pierre Ledure  <jp@ledure.be>  [9f4405c94bc7d9d7500aedc1ade2d90955ab69d7]

        ScriptForge - (Calc) redesign CompactUp() and CompactLeft()
        
        This commit is mainly about the introduction of
        a new internal method:
           _ComputeFilter(range, filterformula, filterscope)
        
        A FilterFormula is a Calc formula that returns TRUE or FALSE
           The formula is expressed in terms of
           - the top-left cell of the range when FilterScope = "CELL"
           - the topmost row of the range when FilterScope = "ROW"
           - the leftmost column of the range when FilterScope = "COLUMN"
           After pasting, the relative and absolute references
           will be interpreted correctly.
        The FilterScope indicates the way the formula is applied,
        once by row, column or individual cell.
        
        The concept of FilterFormula was already used by CompactUp()
        and CompactLeft(). Their implicit (Filter)scopes were resp.
        "ROW" and "COLUMN".
        
        The _ComputeFilter() method returns an array of subranges
        contained in the initial range that match the filter.
        
        The isolation the code for the management of filters
        applied on ranges makes the later use of the concepts of
        FilterFormula and FilterScope reusable for other methods.
        
        CompactUp() and CompactLeft() are functionally unchanged.
        No impact on documentation.
        
        Change-Id: I7c4e890b54f315486f29b5434a3c236167e2f9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138368
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [1f088bb8dddfb71ebb7f5bba701a28c05651436b]

        Move application check to the point where it matters
        
        This simplifies and deduplicates call sites, and also makes sure that
        we don't lookup strings until we need that. Also helps adding a check
        for Math in a follow-up.
        
        Change-Id: I6b073253f19afbb9a95f29806ab306c6a9f63f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138413
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [db4c4676b70bb5f9a1c169735e8fbe92b097a57b]

        Related: tdf#118320 don't require experimental to be set anymore
        
        Change-Id: Iba42eaa820001651a596b9708504fcc796b406ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138381
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Miklos Vajna  <vmiklos@collabora.com>  [ee3ebda2be3965584d12b52c007fb047d624b64c]

        sw XHTML import: fix unexpected link on image
        
        The trouble was that once an image got a pending link applied, the
        remaining images also got that link in case they didn't have an own
        link.
        
        This was a problem since commit 56769d3982e6afb075cb6d833662f066437fab6a
        (sw XHTML import: handle non-image, non-RTF objects as clickable images,
        2022-05-24), the pending URL is not updated after it's applied.
        
        Fix the problem by clearing the pending URL, since we know that one
        pending URL is always applied just once.
        
        Change-Id: I0a363330fbcc1dec95f90f56dc7c420249769e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138409
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-17  Stephan Bergmann  <sbergman@redhat.com>  [f61ea9d2d8d61fe190aa43a57b2316def6c12b8d]

        Raise hdiutil -megabytes even further for debug builds
        
        My macOS build had started to fail with
        workdir/installation/LibreOffice/dmg/logging/en-US/log_750_en-US.log stating
        
        > Systemcall: cd /Users/stephan/lo/core/workdir/installation/LibreOffice/dmg/install/en-US_inprogress_temp.14524 && hdiutil create -megabytes 2000 -srcfolder LibreOffice_7.5.0.0.alpha0_MacOS_aarch64 /Users/stephan/lo/core/workdir/installation/LibreOffice/dmg/install/en-US_inprogress/LibreOffice_7.5.0.0.alpha0_MacOS_aarch64.dmg -ov -fs HFS+ -volname "LibreOffice" -format UDBZ
        > ERROR: Could not execute "cd /Users/stephan/lo/core/workdir/installation/LibreOffice/dmg/install/en-US_inprogress_temp.14524 && hdiutil create -megabytes 2000 -srcfolder LibreOffice_7.5.0.0.alpha0_MacOS_aarch64 /Users/stephan/lo/core/workdir/installation/LibreOffice/dmg/install/en-US_inprogress/LibreOffice_7.5.0.0.alpha0_MacOS_aarch64.dmg -ov -fs HFS+ -volname "LibreOffice" -format UDBZ": 256
        
        and which went away again with the increased $megabytes value.
        
        Change-Id: I483a8cb06df0720eeb42e6260276e6b52ea2a423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138406
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-17  Liu Hao  <ianahao331@gmail.com>  [af87ec3137c32ba098c072304595d8b590f3447c]

        tdf#149115 Trim the white sapce in title before emptiness check
        
        Title that only contains white space should be treated as empty.
        
        Change-Id: I7e4ec6aed206e01dd62fb3afc278fa90d84b7598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138268
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [d9655727ac688753ea12aaedc09a006134dd4a13]

        forcepoint#110 set PaMs to somewhere safe to park
        
        Change-Id: I4dbf27d67b74ff99583dad46a5448700f133c2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138371
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [fad0cb2fba8b3d41fe8b12659ba0cf63c89aa90e]

        cid#1456603 Uninitialized scalar field
        
        Change-Id: I301e6a111f63239b006d01834fb4b63f0d581b04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [a86dd4df616227ed7e7be911653dac06973d8e25]

        cid#1500585 Dereference before null check
        
        Change-Id: I9374a580d3dce7c7851881ff8193946d46ed2bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [6b6e044e05d272d89095b7f05f863c31da0da784]

        cid#1500519 Using a moved object
        
        make this more clear, expected to be null at this point
        
        Change-Id: I0ba06f1b540f53cc2ab70701cb037b9aabbd76fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138383
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [3d0f3a1a6fdc677507a8274e5882aca26cf98a22]

        cid#1509309 Use of 32-bit time_t
        
        and
        
        cid#1509292 Use of 32-bit time_t
        cid#1509217 Use of 32-bit time_t
        
        Change-Id: Icf1b2fa43e706c6d3ff783cf9bcfb5a345b8d50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138382
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [1a7f79d6ceab9871511758682efb677483437a87]

        cid#1500532 Dereference before null check
        
        Change-Id: I001b00f13913f89367257668300ddfa82d3c57d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138397
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [36e1834c9893deae9a45cd2026eb7d02e6a16bd9]

        cid#1509241 rearrange to silence Dereference after null check
        
        Change-Id: I1dc444d312a2075079ad90cdf917b1eaabdaff9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138396
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [996ded6b42c924124f279a20a10a67754df80a8a]

        cid#1509302 Dereference after null check
        
        Change-Id: I5dc783bd2651413140206ed42a174009cd3a0c8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [8575177e240f85850a3b9d27d41a61b3c5445fc7]

        cid#1509184 silence Out-of-bounds access
        
        Change-Id: Ie84f4e7288cfd6b7232352988bb2718f274d7eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138394
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [d40bfecddcac38006ee989d8072fb2b453cf6b9f]

        cid#1500387 silence Resource leak
        
        Change-Id: I847e2be95ad0c56246279e25ac3081967f8f6855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138393
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [3c6f95dd327ee0730e90f90b56b5a3dd2a2291fb]

        cid#1500507 silence Resource leak
        
        Change-Id: I738600ee653d68e80dc8a18970e759d97da08970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138392
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [a30e2862c2bf4635c53a627659905de29934799b]

        cid#1500382 Dereference before null check
        
        Change-Id: I93f50bf404af29147294a5824dcdd3f12c983758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138391
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [bf237656f829f64805af18a112dda76b4b986429]

        cid#1500403 Dereference before null check
        
        Change-Id: I0246551dd84cc7637d4a7a7fc0763ef2d084049f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [773f7a5223cb745d31243dfe20246e922cb7ad36]

        cid#1500480 Dereference before null check
        
        Change-Id: I15d9bd7be89eca4552f3d36571caa6a97dcc1b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138389
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [5d03464526cf4fbb8b6489124c7f7a1a7def4a9f]

        cid#1500490 Dereference before null check
        
        Change-Id: I4e54da303b9e59e7f3db02af06e5156294e717fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138388
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [cdcebac3b5be695bcf390bda116f5a52209c0dd1]

        fetch GetMarkedSdrObj just once
        
        Change-Id: I1af5326be2e71a5fe466b153177904907c12b7da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [2f3c3b8a205495df74e809f4167aa51400e5af89]

        cid#1500682 silence Untrusted loop bound
        
        Change-Id: I61900c89329b84ca07da09085be08a735569e392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [b0090023b09cdbbfff5cc5a6acf1cc976eb33175]

        cid#1509187 Dereference after null check
        
        Change-Id: I5e50670dd28f90621e155a2d851ad5b732f588c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [0b85a66cc3d8e54747506089f92e154dc7665bfe]

        Return std::optional instead of using bool* argument
        
        Change-Id: I47f03411a6677f22291bea4dc06920ab9052349a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138399
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-17  Noel Grandin  <noelgrandin@gmail.com>  [78fb8fe0c5a58bc4d5074de66e77c20c3a441fd3]

        pass sal_Int32 to MoveNodes instead of SwContentIndex
        
        Part of the process of hiding the implementation of SwPosition.
        
        Change-Id: I22858f1be5315141e3efd28db7b7cc2c9fdc5c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  Heiko Tietze  <tietze.heiko@gmail.com>  [d37559fb280857ce6b19c755b8a4d455a9c2596f]

        Relates tdf#126618 - Title style capitaization for compare documents dialog
        
        Change-Id: I5c09a7f706644c41746f5d426d69131c15cd5039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138361
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [45076f7f3a661ba18c4821147c0d6b3956603d86]

        tdf#133299: sw: Add UItest
        
        Change-Id: I4b5178b69d758b80ed23d4d5347d71d772fcb1a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138355
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d50bfb406900ddea3a4b2e0c59e0b983798780d4]

        chart2: for a data table we need to force shift category position
        
        To be able to show the data table correctly we need to always
        show the categories "between tick marks" as otherwise the table
        columns wouldn't align correctly. This forces that the shift
        position is always enabled.
        
        Change-Id: Ia6a627931fcaba64f0f974faf1d8763405ad410d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138337
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-17  Stephan Bergmann  <sbergman@redhat.com>  [b3bc93de3115994bb71e0be2700504db967482e0]

        Fix undefined behavior for good
        
        (Where the range of values of LineEnd is [0, 2], see include/tools/lineend.hxx.)
        7786bafdb8951aa3f0acda801ddb3704c81d00d8 "workaround
        -Wenum-constexpr-conversion" had silenced the (unintended, see below) warning
        about undefined behavior when eEnd was compared against LineEnd(-1), but failed
        to address the undefined behavior when eEnd was initialized with LineEnd(-1).
        
        (On Clang 16 trunk, the original
        <https://github.com/llvm/llvm-project/commit/b3645353041818f61e2580635409ddb81ff5a272>
        "[Clang] Diagnose ill-formed constant expression when setting a non fixed enum
        to a value outside the range of the enumeration values" only emitted diagnostics
        in constant evaluation contexts, then
        <https://github.com/llvm/llvm-project/commit/cc104113ddecbdcec2cca848adbb6afa1214e9de>
        "[Clang] Allow downgrading to a warning the diagnostic for setting a non fixed
        enum to a value outside the range of the enumeration values" accidentally
        extended that to other contexts, so caused the unintended warning here, and
        finally
        <https://github.com/llvm/llvm-project/commit/4e458765aaef7988e687e190d865f331727825c0>
        "[Clang] Restrict non fixed enum to a value outside the range of the enumeration
        values warning to context requiring a constant expression" fixed that mistake
        and made the unintended warning go away again.)
        
        Change-Id: I44c14ed9c9455d05d80baddcb63be97d0bfb0278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138385
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-17  Miklos Vajna  <vmiklos@collabora.com>  [c229f0484d906c1a46bbde4e6039d9de05481a80]

        CppunitTest_sw_fodfexport: remove not needed mustTestImportOf()
        
        All the test documents in this suite are odt/fodt and it they don't be,
        they should use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I0402e57d774d365a823c4b159ae6eaf76f5aaca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138379
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-17  Noel Grandin  <noelgrandin@gmail.com>  [133b9db4d68ba48eeb3682f4decba5689f6c0c1b]

        add comparison operators for SwNode
        
        which will make it easier when I do more conversion of code doing
        stuff like
           rPos.nNode ==
        to
           rPos.GetNode() ==
        
        Add an assert to make sure we are talking about nodes from the
        same parent node array.
        
        Change-Id: I12011768d67e7fbe5a87663c661a5cc444f1deb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138320
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-17  Heiko Tietze  <tietze.heiko@gmail.com>  [16f01f82a765fc51a19be2e370a69eb7819c9ce4]

        Resolves tdf#65473 - Unintuitive paragraph alignment options
        
        Switched Center and Right
        
        Change-Id: I7b24bb23d113dfa76b878b1533f3e7df1a2ba3dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138376
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-17  Heiko Tietze  <tietze.heiko@gmail.com>  [905e2793082f4366d8129430d06098a5ff36c4b9]

        Raise Glade version
        
        No actual changes
        
        Change-Id: I79d3831c3aa1399df95fa5c33f7c624468525a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138375
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [bb6c70f7a9af806347a1e1401a9cce2ad41bc81b]

        lok: register view callback also for nested sm view
        
        This allows to send context change events that originate in the
        embedded views.
        
        Change-Id: I574ca347a2ffa67f9645a2ee790e42088ad8721f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138303
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [f7e0493987f4d2d821d2724e9fef018676af5ddf]

        cid#1509203 Dereference after null check
        
        Change-Id: I6d584c36762d8ae91a766c47ef1ee0d5a68ff4a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138370
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [050ec6a5f282abc0c587d6971052510378a1dbe6]

        cid#1509249 Unchecked dynamic_cast
        
        Change-Id: I8015a53004d8ba8a6ee8d6dca29ec87c655eb3ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138372
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [833e4d059aae5f3a66c70f9f3d8dc1ab4c931322]

        cid#1509262 Explicit null dereferenced
        
        Change-Id: I65eab19b3b40fae6f6b88e4dd3cf21934dd3fd95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [8faf62c76ab3a89fb149f9ec127cb352f081fcf9]

        cid#1500520 Explicit null dereferenced
        
        and
        
        cid#1500605 Explicit null dereferenced
        
        Change-Id: Ic9d36899fb5c39fcd2e85fa8320addb0b05ac7d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [e1cd4b81d3133c460eef10efc7744f9a644b2c5b]

        cid#1500517 Explicit null dereferenced
        
        Change-Id: I83ccacf69c22d8c05374bf5f06eb5e7ee734b12f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138358
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-17  Caolán McNamara  <caolanm@redhat.com>  [cc396384b13a71a5ac2732d22b076c98316d64a0]

        cid#1500701 silence Dereference after null check
        
        Change-Id: Ic982e7d46688628396d659d0c1a9d17fdb8c43a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138360
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [04af1b4e1ce5e3e74bad517a238957bf9aaccdcd]

        qt a11y: Drop duplicate nullptr check
        
        There is already a check whether `object` is a nullptr
        just a few lines above, so this check is superfluous
        since
        
            commit f29e3dbe015571d49d4262f4623a165a0cbc94a3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Aug 16 09:39:01 2022 +0200
        
                qt a11y: Replace dynamic_cast with static_cast
        
        Reported by cppcheck:
        
        > .../vcl/qt5/QtAccessibleWidget.cxx:751: Condition 'pXAccessible' is always true
        
        Change-Id: Iab69c967d97fc01dad617a25503cc5b5e50a3b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138366
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [f2371a7d9b306ce217689bd69c920c9f780f1ee3]

        qt a11y: Clear QtXAccessible's ref to XAccessible once passed on
        
        The `QtXAccessible` only needs to hold a reference to
        the `XAccessible` in order to pass it to the
        `QtAccessibleWidget` ctor in `QtAccessibleWidget::customFactory`
        (which gets called via `QAccessible::queryAccessibleInterface`).
        
        After that has happened, the `QtAccessibleWidget` holds
        its own reference in its `m_xAccessible` member and is the
        only class in the context of the qt a11y bridge that needs
        access to the `XAccessible`, so drop the reference
        in the `QtXAccessible` to avoid any references being
        held even after `QtAccessibleEventListener::disposing`
        has been called, s.a.
        Change-Id I077dffe6ca3e887707d1f578e947ccf3c2c2a492
        "qt a11y: Clear XAccessible reference when disposing" for
        some more context.
        
        Change-Id: Ief80b2939e4c509fc4bc68e67500dbad66498506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138365
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [a65719ec67523cdfc294aeeda527b51ba4d2e17c]

        qt a11y: Clear XAccessible reference when disposing
        
        The `XEventListener::disposing` doc
        (in `./udkapi/com/sun/star/lang/XEventListener.idl`) says:
        
        > /** gets called when the broadcaster is about to be disposed.
        >
        >     <p>All listeners and all other objects, which reference the
        >     broadcaster should release the reference to the source.
        >     No method should be invoked anymore on this object (
        >     including XComponent::removeEventListener() ).
        >     </p>
        >
        >     <p>This method is called for every listener registration
        >     of derived listener interfaced, not only for registrations
        >     at XComponent. </p>
        >  */
        
        Therefore, clear the `XAccessible` reference held in
        the associated `QtAccessibleWidget`
        in `QtAccessibleEventListener::disposing`.
        
        This also implies that `QtAccessibleWidget::isValid()`
        (overriding the `QAccessibleInterface` method)
        will return `false` from that point on.
        
        Change-Id: I077dffe6ca3e887707d1f578e947ccf3c2c2a492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138364
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [48baddac8f175e628a854f78304a19238e25d529]

        qt a11y: Drop QtAccessibleEventListener's XAccessible reference
        
        `QtAccessibleEventListener` was holding a reference
        to the `XAccessible` but not making use of it.
        
        The `QtAccessibleWidget` class that actually
        operates on the `XAccessible` is holding its own reference
        in its `m_xAccessible` member, so there's no need for
        the corresponding `QtAccessibleEventListener` to
        hold another one.
        
        Change-Id: I5b838e55d8285b4e52287dc8c9c70e06e45ab317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138363
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Noel Grandin  <noelgrandin@gmail.com>  [b9a45cca8a0014d975f6e3d16c94cfe08c52a8bb]

        pass sal_Int32 to DontExpandormat
        
        instead of SwContentIndex.
        Part of the process of hiding the implementation of SwPosition.
        
        Change-Id: I69d2a92093109b52b21c558f8ea8e3ae486fe1ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138319
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [b2702d56437b7bf8f061259a063371529b7881ec]

        cid#1509186 Using a moved object
        
        Change-Id: Ib4d986bf21b3294e46e52d8b2f4428aca1683321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138357
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [4c511ac7d7a006d9a62a3685f3a962bb321017bd]

        cid#1500417 Dereference after null check
        
        Change-Id: Ib186c453aafc9bc29fd5c7d82578ca4157aed31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [addcd016bf1bed16299697fd18b8f9b1faf2cf3f]

        chart2: support data table rendering when the X axis is swapped
        
        In case when the X axis is swapped, so the Y axis is rendered in
        the place of X axis, we need to render the data table below the
        Y-axis labels. This is best done to put the data table into the
        Y-axis instead, so we get the correct size and position of the
        data table, and then just allow rendering of the axis labels and
        (re)position the table below Y-axis.
        
        Change-Id: I74aa79402a5638133b0d1ed83bbd8aad6f6c9d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138336
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [089f7b437326021beb0f61a05bdd180f1de8bb59]

        chart2: we don't need SCHATTR_TEXT_* text ranges for data table
        
        Change-Id: I1c857ebe1ce4851f15da05291daecc09e7e74209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138335
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fc909263a1bb9326f838326f3299b16b80318f42]

        chart2: don't use ref-size property when converting data table
        
        Change-Id: I4dd93d84879274721ded01be1a47b62487066b4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138334
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Michael Stahl  <michael.stahl@allotropia.de>  [a8b3953531035bf93306ed90142c4172cc32ac43]

        forcepoint#108 sw: prevent creating SwRangeRedline anchored in itself
        
        the SwRangeRedline in frame #8 triggers deleting itself at frame #0
        which repeats the DeleteSection attempt which is already in progress
        
         #0  SwRangeRedline::~SwRangeRedline() (this=0x5335300) at sw/source/core/doc/docredln.cxx:1168
         #1  0x00007fffc9b91aab in SwRedlineTable::DeleteAndDestroy(unsigned long) (this=0x4f388f8, nP=0) at sw/source/core/doc/docredln.cxx:669
         #2  0x00007fffc9c8454a in sw::DocumentRedlineManager::DeleteRedline(SwPaM const&, bool, RedlineType) (this=0x4f388e0, rRange=SwPaM = {...}, bSaveInUndo=true, nDelType=RedlineType::Any)
             at sw/source/core/doc/DocumentRedlineManager.cxx:2578
         #3  0x00007fffc9c84a2f in sw::DocumentRedlineManager::DeleteRedline(SwStartNode const&, bool, RedlineType) (this=0x4f388e0, rNode=..., bSaveInUndo=true, nDelType=RedlineType::Any)
             at sw/source/core/doc/DocumentRedlineManager.cxx:2676
         #4  0x00007fffc9c1c57f in sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (this=0x4f3b460, pNode=0x5331780) at sw/source/core/doc/DocumentContentOperationsManager.cxx:2092
         #5  0x00007fffc9cbfea7 in sw::DocumentLayoutManager::DelLayoutFormat(SwFrameFormat*) (this=0x4edad40, pFormat=0x53318b0) at sw/source/core/doc/DocumentLayoutManager.cxx:285
         #6  0x00007fffc9a9abd2 in DelFlyInRange(SwNode&, SwNode&, SwContentIndex const*, SwContentIndex const*) (rMkNd=..., rPtNd=..., pMkIdx=0x0, pPtIdx=0x0) at sw/source/core/doc/docedt.cxx:254
         #7  0x00007fffc9c1c53d in sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (this=0x4f3b460, pNode=0x532a1f0) at sw/source/core/doc/DocumentContentOperationsManager.cxx:2091
         #8  0x00007fffc9b965f7 in SwRangeRedline::MoveFromSection(unsigned long) (this=0x5335300, nMyPos=0) at sw/source/core/doc/docredln.cxx:1834
         #9  0x00007fffc9b951f8 in SwRangeRedline::Show(unsigned short, unsigned long, bool) (this=0x5335300, nLoop=1, nMyPos=0, bForced=false) at sw/source/core/doc/docredln.cxx:1277
         #10 0x00007fffc9c7d64b in sw::DocumentRedlineManager::SetRedlineFlags(RedlineFlags) (this=0x4f388e0, eMode=RedlineFlags::ShowMask) at sw/source/core/doc/DocumentRedlineManager.cxx:1149
         #11 0x00007fffcb129668 in SwXTextDocument::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x4f52730, rPropertyName="ShowChanges", aValue=uno::Any("boolean": 1 '\001'))
             at sw/source/uibase/uno/unotxdoc.cxx:1795
         #12 0x00007fffcab7ce8d in XMLRedlineImportHelper::~XMLRedlineImportHelper() (this=0x52792f0) at sw/source/filter/xml/XMLRedlineImportHelper.cxx:341
         #13 0x00007fffcac2366d in SwXMLTextImportHelper::~SwXMLTextImportHelper() (this=0x527cae0) at sw/source/filter/xml/xmltexti.cxx:157
         #14 0x00007fffcac236a9 in SwXMLTextImportHelper::~SwXMLTextImportHelper() (this=0x527cae0) at sw/source/filter/xml/xmltexti.cxx:152
         #15 0x00007fffea9d5ee2 in salhelper::SimpleReferenceObject::release() (this=0x527cae0) at include/salhelper/simplereferenceobject.hxx:76
         #16 0x00007fffeabc2619 in rtl::Reference<XMLTextImportHelper>::clear() (this=0x525cd60) at include/rtl/ref.hxx:196
         #17 0x00007fffeabb07e0 in SvXMLImport::cleanup() (this=0x525ccd0) at xmloff/source/core/xmlimp.cxx:458
         #18 0x00007fffeabb08bf in SvXMLImport::~SvXMLImport() (this=0x525ccd0) at xmloff/source/core/xmlimp.cxx:464
        
        Change-Id: I640874df3fd10af935cf05df707d45bea2c9fd6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138191
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [65021c6acc655b61cbba74d01829beb1c4181c97]

        chart2: use the FillColor property as CharBackColor
        
        For chart data table, the fill is always setting the char background
        (highlight). As we don't support other fill types in LibreOffice for
        the char background, we can't set anything else when rendering. We
        need to extend editeng and UNO API with the support for this.
        
        Change-Id: I47d342e02ad2347bac0515a62cc0de4391f98150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138331
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Stephan Bergmann  <sbergman@redhat.com>  [fe033eebec7db71010beb6df14f7a08aded471be]

        tdf#150427 Gracefully handle potentially unset logger
        
        Change-Id: I237e3b5da042cbfa3fde1a02043ab69cc0711296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138353
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-16  Miklos Vajna  <vmiklos@collabora.com>  [7ad44f3dd271a591529b048212c4391d8b38ed9d]

        crashtesting: fix DOCX export of forum-mso-de-99522.docx
        
        Export of this document to DOCX wrote not-well-formed XML output,
        resulting in an assertion failure in debug builds.
        
        writerfilter/ maps a selection of <w:sdt> tags to Writer content
        controls (a safe subset), and leaves the rest unchanged, which means we
        continue to map those to grab-bags. The trouble is that a combination of
        content controls and grab-bags leads to bad output on export, as we
        start the <w:sdt> element twice, but only close it once.
        
        Fix the problem by extending writerfilter/ code to not do any grab-bags
        for the richText type, we already did that in the past for dropDowns.
        
        In the long run, we should never do grab-bagging for any <w:sdt>
        elements that we map to Writer content controls.
        
        Change-Id: I27a0b814efd667cc0477d8f492f7f956c938c854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138351
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [0aa2b700aae306674d768356875998f5b8f14f0f]

        No need to use throwing Reference ctor from 'this'
        
        Change-Id: I1a9d69d101d3adede0455e94d4026e38131e6c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138350
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [84fbb174d6c773ecd284398a9dc4fee9f142a193]

        Drop redundant warning after throwing check
        
        Change-Id: I1cc9ce6c415eb8aef9a250b3b5f342a425071b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138349
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-16  Julien Nabet  <serval2412@yahoo.fr>  [13971f0619192deb3f1f1cf5ff30f9671ed25a38]

        Related tdf#82087: hyphenation: allow 1 character at line begin
        
        The default "Characters at line begin" value is still 2
        in Paragraph Styles->Text Flow, but now it's possible to set 1, too.
        
        See end of comment here:
        https://bugs.documentfoundation.org/show_bug.cgi?id=82087#c22
        
        Change-Id: Ib10e8a919715666214c7e4ac19f1506f111a6519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137937
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-16  xuenhua  <xuenhua2008@sina.com>  [d0ab89cd8b8b705689b432c1ea630501c7745264]

        Update iOS SDK Current Version to 15.6
        
        Change-Id: I2e6ec0a32b859cead16965284359115db0628f5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137277
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [707f8c10328290c8bcd928755101cbb88ab6a8cb]

        cid#1509215 Using a moved object
        
        and
        
        cid#1509294 Using a moved object
        
        Change-Id: Ic4ef9bbc94d7b946d7d1904edf4b5b23278baafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [bc91ece78e3ea2df4082c796469e42cc5fc72107]

        don't try and select position 0 of combobox if combobox is empty
        
        Change-Id: Ie3e128228c3a2d7d17126e743e756d7d3320255c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138309
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Noel Grandin  <noelgrandin@gmail.com>  [28a3f31e8cf8b7b7b3900b12de1a24dc88f2854a]

        pass SwNode and sal_Int32 to DelFlyInRange
        
        instead of SwNodeIndex and SwContentIndex. Part of the process
        of hiding the implementation of SwPosition.
        
        And fix a missing SwPosition constructor.
        
        Change-Id: Idc4d2675a53596e6f2ea53043dc7109b9c7bc2e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138317
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [a3f3453c00f701ea51f67896e633bb6b6a6a2d71]

        qt a11y: Implement QtAccessibleWidget::indexOfChild
        
        With this in place, selecting an object in Accerciser's
        tree view of the LO a11y hierarchy and then calling
        the method to get the child index returns the actual
        child index instead of just 0, e.g.:
        
            In [24]: acc.getIndexInParent()
            Out[24]: 4
        
        Change-Id: Ia3d4811226d6ffc82b86ed5a9abf3332b8b50b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138347
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [2fbf1082cde79b7259f0139a6c8978fe797be86c]

        cid#1500455 Dereference after null check
        
        Change-Id: I2ef903eaf4df4fbd225d01e394ba11ffa43386e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138346
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [6b008de9e47ea9938e0b615f3171a7c273884596]

        cid#1500410 Explicit null dereferenced
        
        Change-Id: Idc4e3ca35a0f68ffe8c3b32053c9eea1c6426ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [a51c1df3c2bad14de49a381945f4c55d4bccf8a8]

        cid#1500395 Dereference after null check
        
        Change-Id: I16b490849d2fa29295e6182e1bbe91836c5655bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138343
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Michael Weghorn  <m.weghorn@posteo.de>  [f29e3dbe015571d49d4262f4623a165a0cbc94a3]

        qt a11y: Replace dynamic_cast with static_cast
        
        The Qt doc on implementing accessible plugins [1]
        says:
        
        > Note that `object` will always be an instance of `classname`.
        
        Therefore, `static_cast` can be used here to avoid the
        cost of `dynamic_cast`.
        
        [1] https://doc.qt.io/qt-6/accessible-qwidget.html#implementing-accessible-plugins
        
        Change-Id: I57721c927808fa710b7d790c54d01bd899146a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138341
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [da46f3db22814c03fbc303275342f7182ea288b4]

        cid#1509285 Use of 32-bit time_t
        
        Change-Id: I5aea4aaa6da8cd974234ab3f0c36212d436e11df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Noel Grandin  <noelgrandin@gmail.com>  [59785c0237f2bc5eaf9e9742bdf30136f3b3d2ba]

        pass SwNode and sal_Int32 to delBookmarks
        
        instead of SwNodeIndex and SwContentIndex. Part of the process
        of hiding the implementation of SwPosition.
        
        Change-Id: Ic70cbf9bd72f7544bcc24a2ebc2f588d5efd9231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [4b1a57e075af70135703e38337e1096b2f248ebd]

        tdf#94223 always visualize surrounding frame for active text object
        
        Change-Id: I622582c188a32a5df27f3bb5d8382acc2afb089b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [034e8a14f6b6c12b870a71cb808fcfdc41221714]

        ofz: Null-dereference-WRITE
        
        took oss-fuzz about a picosecond to find a crasher, lets just use
        sal_uInt32 here
        
        Change-Id: I582377bc30de1c46dce9d3cd659a80237848ed73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Caolán McNamara  <caolanm@redhat.com>  [5be419d91c54bfa44f5d2897064dc07fb223de81]

        fix "invalid cast from 'GtkImage' to 'GtkLabel'" warning
        
        Change-Id: I7daa8d75151152c11ad4b1835101921006e2e62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-16  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [3329bfe698ecb65cbfbe2bf8f38fce45809fd436]

        rtl : use a local std::mutex instead of the global mutex
        
        Change-Id: I95a35fe451e459276dcb8c9b90d515d0a34fe36c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138318
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Noel Grandin  <noelgrandin@gmail.com>  [a20fa9bbbfb3fab623480f95975f30c3904af055]

        unique_ptr->optional in DocumentFieldsManager::UpdateTableFields
        
        Change-Id: I5b4595ea04d5e1a28007008b96a684defff744e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Noel Grandin  <noelgrandin@gmail.com>  [1920eb7843753392bd7581f02ff797f2f903c50a]

        improve SwContentIndexReg::Update...UpdateMode::Negative
        
        the indexes in the linked list are stored in-order.
        So
        (a) there is no need to overwrite a value with the same value
        and
        (b) there is no need to walk the list backwards before going
        forwards
        
        Change-Id: I77d6b227c5c2eb8e70ce3975963ec2d1826d0246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [81a5f33101c18fb22a952b865c0c90418fd6a490]

        chart2: always set text props. of the first paragraph and not cell
        
        When setting the properties of the data table it is important to
        differentiate when we set the properties of the text of the (first
        and only) paragraph or set the properties for the current cell.
        
        In this chage we refactor the code so that we always set the text
        via UNO text::XText call for the current cell, and in the next step
        get the XPropertySet of the first paragraph and set the properties
        relevant for the text from the DataTable model.
        
        Change-Id: Ibe82b21c3416083cfe8e86b95443d77984da05f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138330
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e0599e403b9b8714794f4f80afe78feac0a77b32]

        chart2: add "font effects" tab page to the data table dialog
        
        Change-Id: I5530477dc86ba2174ba6e553dfe77f8fa355a863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138329
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e4e5d77bcc30beb1d976fadf5da0247f00f5b9cc]

        chart2: render line legend symbols better in a data table
        
        Change-Id: I556b4f249688a3836bbeeb3f554cb9ecf1d31f65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138301
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5dcfa8f3750d549d895246c50285bb38690f9734]

        chart2: fix rendering of table borders of row/column headers
        
        The row/column headers didn't enable/disable the table borders
        correctly when outline was enabled and horizontal and vertical
        borders properties were disabled.
        
        Change-Id: Ifcb059dd7d39890bbcaf55d3a68dce41eef586cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138300
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9d6ffcc0572cc7917651489c69ca4b3452e89a89]

        chart2: Data table rendering of keys (legend symbols)
        
        Change-Id: Iff13b188df18fe8f9919274869774f53f2ea323b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138299
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Miklos Vajna  <vmiklos@collabora.com>  [777f1dbb96fc4499e682f2f67969410408f53b50]

        pdfium: replace windows arm64 patch with a backport from upstream
        
        No functional changes intended, just this way the patch can be dropped
        trivially the next time we update pdfium.
        
        Change-Id: I3259e98ddd20a51e109e860e1a3ab4c138597436
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138323
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fcf839cd4b76254d03426a849e17927b2a845352]

        chart2: Add undo/redo for the data table
        
        Change-Id: I6b25a7a82957705481952bc3cd181a6d0c1fce0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138298
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [3dec8709c1cba25b62492354fe75e6a41a6dfe40]

        tdf#150151: sw: Add UItest
        
        Change-Id: I59da074531d4545ea80096db2b00376b632eddbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138295
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [c1446da82b999349e1a09fed3420bd1c38d7b38c]

        tdf#103492: vcl_pdfexport: Add unittest
        
        Change-Id: I426ace3f1272b2cb5f40d627c9c701b903c3e632
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138272
        Reviewed-by: خالد حسني <khaled@aliftype.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f448de22e05a59307c8d968982140b182e736edc]

        correct the description of NumberingRules
        
        duplicated text - "@see NumberingLevel"
        
        Change-Id: I210c392dba738e65ed22b8c66e16a6bafb1c4265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138261
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-15  Miklos Vajna  <vmiklos@collabora.com>  [251589c17c0dfa33cf5e5e5bb1ed782d2293a67c]

        tdf#148289 sw clearing breaks: fix vertical layout
        
        There were 3 problems here:
        
        1) SwTextFly::GetMaxBottom() gets an already swapped frame, so going via
           the aRectFnSet abstraction is not correct, need to use Left() and
           similar functions directly.
        
        2) SwTextCursor::AdjustBaseLine() centers portions in the vertical case,
           so a clearing break portion with larger height will push the other
           portions towards the left, and this is not wanted. Fix this by
           filtering out the (logic) height of the clearing break portions in
           the vertical case.
        
        3) The fix for 2) has the side effect that the non-printable line break
           indicator character now has the wrong (logic) top position in
           SwBreakPortion::Paint(). Fix this by compensating for the offset done in
           AdjustBaseLine().
        
        No functional changes intended for the horizontal layout.
        
        Change-Id: I9ea27b4247944cbab8e96c5c5e2c8f82bbbd731c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138314
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-15  Caolán McNamara  <caolanm@redhat.com>  [f3b0a95f9c2f85604808c21485e46e43aebbbfed]

        fix "invalid class cast from 'OOoAtkObj' to 'GtkWidgetAccessible'"
        
        and similar
        
        Change-Id: I8a989465057a5b7810f6cedf370fc1cd77f5af0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-15  Noel Grandin  <noelgrandin@gmail.com>  [077cbb5faecf75b333531afad04d2c9622a47c91]

        pass SwNode and sal_Int32 to deleteMarks
        
        instead of SwNodeIndex and SwContentIndex. Part of the process
        of hiding the implementation of SwPosition.
        
        Change-Id: I290fbc14d738d1bbf5d3f613eae6d114fc7cda17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-15  Caolán McNamara  <caolanm@redhat.com>  [895d6716ba8f12d98e3685145d433fce72270faa]

        Resolves: tdf#149858 embedded starmath not using correct initial zoom
        
        since...
        
        commit ea21b870f8549d0110ef65187af50694a06458ca
        Date:   Mon Apr 19 15:22:22 2021 +0100
        
            weld SmGraphicWindow
        
        where the outer Window is not directly drawn into any more
        
        Change-Id: I70f45590f0fb7ff2f7af80da8873d580d219aca4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138297
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8750c812c9b808ee980f7e0ce0e6ce91e75e1424]

        Fix mispositioning when only quickstarter is active
        
        When positioning a dialog via external UNO connection,
        and no LibreOffice window is visible (only quickstarter is running),
        the window was mispositioned.
        
        The ClientToScreen call changes the requested position, so skip that
        for dialogs too.
        
        Change-Id: I7656ec66b6aeccdc1fa306f5e05cf72b3cb87214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138135
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-08-15  Stephan Bergmann  <sbergman@redhat.com>  [5b5f6b147f5f2a02476a14ed2d8feb247d5a7c79]

        external/nss: Fix -Wincompatible-function-pointer-types
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error",
        causing
        
        > ../../../pr/tests/testfile.c:126:41: error: incompatible function pointer types passing 'void (*)(void *)' to parameter of type 'void *(*)(void *)' [-Wincompatible-function-pointer-types]
        >         if (!pthread_create(&tid, NULL, start, arg)) {
        >                                         ^~~~~
        > /usr/include/pthread.h:204:15: note: passing argument to parameter '__start_routine' here
        >                            void *(*__start_routine) (void *),
        >                                    ^
        
        and
        
        > ../../../pr/tests/testfile.c:576:31: error: incompatible function pointer types passing 'PRInt32 (void *)' (aka 'int (void *)') to parameter of type 'void (*)(void *)' [-Wincompatible-function-pointer-types]
        >                               DirTest, &thrarg,
        >                               ^~~~~~~
        > ../../../pr/tests/testfile.c:93:36: note: passing argument to parameter 'start' here
        >                             void (*start)(void *arg),
        >                                    ^
        
        Change-Id: I642e5ca69289993c86abafded65ac23a63fd837e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138267
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-15  Thierry Emery  <thierryalemery@gmail.com>  [dbd104083dc4cc22075556811e67b5c81ef688ae]

        tdf#133299 Anchor pasted images 'to cell' by default
        
        This is already the default when inserting images via menu,
        do this also when pasting images from other applications
        (currently it would anchor 'to page').
        
        Change-Id: I5e1d010b026fc8eba2d3a7cca80ea96814a2ebe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138005
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [203eaefb4ac012c36a1ecdd3753e1cb2c5876efc]

        xmloff: import and export for the chart data table
        
        This change adds import and export code for the the chart's data
        table properties to the ODF format for chart documents. The data
        table properties are exported to a new element "data-table", which
        then references a auto style with all the properties of a data
        table + new data table specific properties: HBorder, VBorder,
        Outline, Keys which are mapped to "show-horizontal-border",
        "show-vertical-border", "show-outline" and "show-keys" chart
        attributes.
        
        Also adds a test for the import and export:
        imports xlsx -> exports to ods -> imports ods
        
        Change-Id: Id45d9369fd619959e4d6eba7ca51c8ddce9c8f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138260
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5861af0da5179689870d5b4f5ff56a5ea0a79901]

        chart2: DataTable set properties to default to false
        
        Change-Id: If8caf59629327b623b2630776b1e650cbe4fbed1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138259
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0c984c4dbe36a58859b09924e98fcf8ba8ed2d75]

        chart2: InsertDataTable and DeleteDataTable for context menu
        
        Change-Id: I8ef0698252209af01b0741a59dec70f845f0c965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138258
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-15  Mark Hung  <marklm9@gmail.com>  [1bf82b26aea3a403920a64cdfcb4671c947c7a01]

        tdf#135991 fix unexpected hidden RTL sections.
        
        SwLayoutFrame::MakeAll tried to manipulate the height instead of the
        width for SwCellFrame and SwColumnFrame ( i.e. when IsNeghbourFrame()
        is true. ), by selecting a wrong SwRectFn.
        
        SwRectFn fnRect = bVert == IsNeighbourFrame() ? fnRectHori :
        ( IsVertLR() ? (IsVertLRBT() ? fnRectVertL2RB2T : fnRectVertL2R) : fnRectVert );
        
        It doesn't make sense to select among fnRectVertL2RBT, fnRectVertL2R,
        and fnRectVert if the layout is horizontal.
        The frame position got a negative top value and make the frame invisble.
        
        Check he following commit for reference:
        
        commit c90b6806d18c8ed25015eb2ecdff13c7bab2572d
        Author: Andreas Martens <ama@openoffice.org>
        Date:   Wed Sep 19 07:45:10 2001 +0000
        
            Chg: Moving vertical help functions from SwFrm to SwRect
        
        Change-Id: I2f6da9cdbc2947de95a6fb9ce8fa94a79360c83a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138250
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-15  Stephan Bergmann  <sbergman@redhat.com>  [ae7efecd240eb5c035183b47c08b2ba6b1b78570]

        external/lxml: Fix -Wincompatible-function-pointer-types
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error",
        causing
        
        > src/lxml/etree.c:175589:60: error: incompatible function pointer types passing 'void (void *, void *, xmlChar *)' (aka 'void (void *, void *, unsigned char *)') to parameter of type 'xmlHashScanner' (aka 'void (*)(void *, void *, const unsigned char *)') [-Wincompatible-function-pointer-types]
        >   xmlHashScan(__pyx_v_self->__pyx_base._xpathCtxt->nsHash, __pyx_f_4lxml_5etree__registerExsltFunctionsForNamespaces, __pyx_v_self->__pyx_base._xpathCtxt);
        >                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/libxml2/include/libxml/hash.h:213:22: note: passing argument to parameter 'f' here
        >                                          xmlHashScanner f,
        >                                                         ^
        
        Change-Id: I2a359ed0dfdfa83b49fb03f447967a6d0ff73989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138266
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-15  Stephan Bergmann  <sbergman@redhat.com>  [49f392feb98feb2f69fafbed45ad5aa60c179e64]

        external/cairo: Fix -Wincompatible-function-pointer-types
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/af01f717c48f0fd2481600ed6c00441763365b62>
        "Default implicit function pointer conversions diagnostic to be an error",
        causing
        
        > pixman-bits-image.c:1184:39: error: incompatible function pointer types passing 'const float (int, int)' to parameter of type 'dither_factor_t' (aka 'float (*)(int, int)') [-Wincompatible-function-pointer-types]
        >         buffer = dither_apply_ordered (iter, dither_factor_blue_noise_64);
        >                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        > pixman-bits-image.c:1130:60: note: passing argument to parameter 'factor' here
        > dither_apply_ordered (pixman_iter_t *iter, dither_factor_t factor)
        >                                                            ^
        > pixman-bits-image.c:1189:39: error: incompatible function pointer types passing 'const float (int, int)' to parameter of type 'dither_factor_t' (aka 'float (*)(int, int)') [-Wincompatible-function-pointer-types]
        >         buffer = dither_apply_ordered (iter, dither_factor_bayer_8);
        >                                              ^~~~~~~~~~~~~~~~~~~~~
        > pixman-bits-image.c:1130:60: note: passing argument to parameter 'factor' here
        > dither_apply_ordered (pixman_iter_t *iter, dither_factor_t factor)
        >                                                            ^
        
        Change-Id: I3e28280c9c25dfb7cee5155719a71655db00e344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138265
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-15  Michael Stahl  <michael.stahl@allotropia.de>  [6f42a2c8631bace1caa4fac0b3ea554942f1fca3]

        tdf#150382 writerfilter,sw: RTF import of paragraph border override
        
        The style (default unnamed \s0, applied via \pard) defines green
        borders, which are overridden at the 2nd paragraph and cleared.
        
        Of course there isn't a single border control word to be found on the
        2nd paragraph, the override happens by omitting the borders of the
        implicitly applied style.
        
        Hence handle LN_CT_PrBase_pBdr in getDefaultSPRM().
        
        The export of the override relies on changes from commit
        967a03eb8760fb498c5ea6c32d03d1eea486bbe2.
        
        Change-Id: I081eb2908d76123e7828cab6c31ceb7b11760183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138193
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-15  Michael Stahl  <michael.stahl@allotropia.de>  [f6a0ca0e92e41ad8fea71acdacdc7ec5e775dc59]

        tdf#149921 ucb: webdav-curl: WNT: certificate revocation check
        
        - don't require it to be successful.
        
        Trying to connect to a server with self-signed CA results in:
        
        warn:ucb.ucp.webdav.curl:6796:6568:ucb/source/ucp/webdav-curl/CurlSession.cxx:946:
        curl_easy_perform failed: (35) schannel: next InitializeSecurityContext failed:
        Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.
        
        Apparently schannel wants to check by default (called with
        SCH_CRED_REVOCATION_CHECK_CHAIN) that all the certificates aren't
        revoked, but the self-signed CA doesn't specify how to check.
        
        Set it to only check revocation when the way to do so actually works,
        via CURLSSLOPT_REVOKE_BEST_EFFORT, which sets these flags:
        SCH_CRED_IGNORE_NO_REVOCATION_CHECK | SCH_CRED_IGNORE_REVOCATION_OFFLINE | SCH_CRED_REVOCATION_CHECK_CHAIN
        
        Change-Id: I6d77ca23fe2012d8a5d65000b14775070b5c9a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138204
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-15  Noel Grandin  <noelgrandin@gmail.com>  [e83daa9ff1d4d41ef7ac7b13fe7ab1dc0bd82f68]

        pass content offset into FieldsToCalc instead of SwContentIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I76aee9e18f37f70648c181af0c2bbc4d4f2dfd2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-15  Miklos Vajna  <vmiklos@collabora.com>  [dd4d55b48cb654dea0a08fca55ed7ccd5e95d932]

        sw: prefix members of SwAddPrinterTabPage, SwCaptionOptPage, ...
        
        ... SwMarkPreview and SwParaDlg
        
        See tdf#94879 for motivation.
        
        Change-Id: I13d2961f46ebfd608176798be5a91ac0cd6c9d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138263
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cb954e21aaa9166d762fe6c4a1d956c63820e6d4]

        Fix typo
        
        Change-Id: I1bc4d4649fbf4d2cfe8e93bc3a4fca64804de6b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138241
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-15  Noel Grandin  <noelgrandin@gmail.com>  [5dde7a14a2bfc4c29f5f60b7e47fdc7046ede0b0]

        this index should be sal_Int32
        
        since we are indexing into node content here
        
        Change-Id: I28c1a669a5202fb47757913bc175f1a926c4d4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c00d75738bb182b5c02848b1720e6623baed4b9]

        chart2: InsertDataTableDialog for inserting/removing the data table
        
        Change-Id: Ie3c033c587b150723e7aa39cd5ddf5774104db9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138257
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-15  Caolán McNamara  <caolanm@redhat.com>  [6c81a09e3ef239a2d7a991d00fe3620a67298b99]

        ofz#49713 Heap-use-after-free
        
        the dtor of ScAttrArray where the std::vector<ScAttrEntry> ends up
        will call ScDocumentPool::Remove on each entries pPattern, assuming
        that a matching ScDocumentPool::Put was called on each, something
        that is elided if we just do a simply copy here.
        
        probably a problem since:
        
        commit dddee125cc32f1ad5228e598a7de04e9654e65c1
        Date:   Thu Mar 10 15:03:25 2022 +0100
        
            load ods/xlsx with full row attributes without allocating all columns
        
        Change-Id: I3a5e2e3fa4d40343f30f9eefbabd1579d8a97e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138262
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [62ff1053eeba26cecd7264db08e73da154835816]

        svm: serialize MetaTextArrayAction’s Kashida array
        
        Otherwise reading SVM files would lose the Kashida but not the DX
        adjustments and would leave blanks in their place.
        
        Change-Id: Id37e09fed12da5e256d65e2c45c91869364c8d06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Noel Grandin  <noelgrandin@gmail.com>  [d0c07ec1cad386a0ec3bf34c6aa6e7b50859ef09]

        use more GetContentIndex
        
        Change-Id: I48e36a95872b5c2bdb6b92c66403d4c08eedd38c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138255
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [895843ad466954b63f6f99a1b6319b7813d0dbe1]

        tdf#103492: Messed Arabic letter spacing in text starting with LTR character(s)
        
        This partially reverts the still relevant parts of commit
        
        commit 41007842ed9bb5d6165792a197769f72dae55a2c
        Author: Martin Hosken <martin_hosken@sil.org>
        Date:   Thu Sep 10 10:14:18 2015 +0700
        
            Refactor graphite integration and update graphite
        
            Change-Id: I09db7262c2a6180a078620ba086dd7a4c132bd82
            Reviewed-on: https://gerrit.libreoffice.org/18459
            Tested-by: Jenkins <ci@libreoffice.org>
            Reviewed-by: László Németh <nemeth@numbertext.org>
            Reviewed-by: Martin Hosken <martin_hosken@sil.org>
        
        No mention of the commit about this change or its relevance to Graphite
        integration. But the separate Graphite layout engine is long gone and
        Graphite handling goes through HarfBuzz now, so whatever the change was
        for is probably no longer relevant.
        
        I reverted only one the two changes in impedit3.cxx, as the other one
        does not seem to make any difference for this issue.
        
        Change-Id: Id70a711d6231cce52c9a32dbc3604860b1da9f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138217
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [3836b99f335ac9e6890545607d07124e455eb531]

        Use doubles when calculating the number of Kashidas to insert
        
        Makes it a bit more stable across zoom levels and avoids excessive
        overlaps due to calculating one copy too many because of rounding
        errors.
        
        Change-Id: I6a21a89c1dfda085b1f7fa9570c9875a0d39f671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138192
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [3d0e482df81a28e6d0eb86cda71ac49d3363ae50]

        tdf#106653: Try harder not to return 0 for Kashida width
        
        The font in the bug document has a very small Kashida advance width and
        this gets rounded to zero at smaller zoom level. Try to round up the
        value to avoid returning zero too eagerly.
        
        Change-Id: I78c309d66a9e94812827c7c6724c67c4d09bcff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138169
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [5e2b7a656024b621bdeeb6efd977331191b66d9d]

        Streamline Kashida validation logic
        
        We are asked to validate the position *after* which Kashida will be
        inserted, but HarfBuzz will tell us which glyph we can insert Kashida
        *before*. So align both by passing down the position before and after
        and make the loop iterating over glyph items a lot simpler.
        
        As a bonus, the new code allow Kashida insertion across layout change in
        both sides, old code allowed it only at the start of the layout.
        
        Change-Id: I9f632610b92c0f4c512e50456bf7d207175f17ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138168
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [72e56537d4bb9411229346da977d1d669ccfca9a]

        tdf#139627: Don’t set Kashida insertion position after combining marks
        
        We were skipping the marks when checking for previous char, but not when
        setting the index to previous char.
        
        Fixes also the second part of tdf#106653.
        
        Change-Id: I73436ba9df6ccf104ea6d4dfbd76a59c86040a44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138154
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [640a2bc1cd093875b701bb958b6156d5752c0fac]

        tdf#137528: Sync Kashida algorithm in editeng with sw
        
        It seems that editeng is using an old copy of the code in sw and it was
        never updated.
        
        With this change, the text in the test document from tdf#137528 looks
        essentially identical in both cases.
        
        Fixes also tdf#146199.
        
        Change-Id: I38541bfb35eae36681af84e73a7965d36152448f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138145
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Khaled Hosny  <khaled@aliftype.com>  [3901e029bd39575f700e69a73818565d62226a23]

        tdf#104921: Cleanup Kashida insertion logic
        
        Communicate Kashida insertion positions in an explicit way.
        
        Rest of LibreOffice communicate adjustments to character widths (e.g.
        for justification or spacing) using so-called DX array. DX array is an
        array of absolute character positions (e.g. DX[n] is the position after
        character n from the start of the lines, and its widths is DX[n] -
        DX[n-1]).
        
        This DX array is modified also when Kashidas are inserted after a given
        character for Arabic justification, by expanding its width. VCL would
        use this to know where to insert the Kashidas and how many ones.
        
        But because DX array is used for both widths adjustments and kashida
        insertion, this turns out to be a source of bugs since VCL has tosecond
        guess the DX array to find which is pure width adjustment and which also
        involves Kashida insertion, and the heuristics it uses are fragile.
        
        This change adds a second array of booleans that records where Kashida
        is inserted and communicates it all the way from where Kashida insertion
        is decoded in Writer and down to VCL layout.
        
        This change passes the Kashida array only when it seems necessary (e.g.
        during drawing but not when measuring text since the DX array is enough
        in this case). Hopefully no places where Kashida insertion needs to be
        passed down were missed.
        
        A couple of glyph and layout flags that were used for old heuristics and
        no longer needed and are removed.
        
        This also fixes:
        tdf#87731
        tdf#106309
        tdf#108604
        tdf#112849
        tdf#114257
        tdf#127176
        tdf#145647
        tdf#146199
        
        Change-Id: I4ed0850ef2fdc3e9143341afac649e7e7d463c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cc54063b915a58db9133c919c151ec7e6209f4cd]

        chart2: add some data table default properties
        
        Change-Id: I4fac46ac2a119275bcdaa6ebc8b7382ad6fb5684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138249
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c5881289931f35b74ffda92ab72c01781c771f96]

        Fix typo
        
        Change-Id: I9a973141bdefca22dc24ecfaba58803dfc256e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138239
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [16fac85be1fdddb1695a29a9b8026cd4f8cfad64]

        chart2: add "InsertMenuDataTable" action to menu
        
        Change-Id: Ib60a2b061966eb61834480b63dc0653410a43a14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138248
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e727820149535e6bc99b9342ad826c498d196c7c]

        Fix typo
        
        Change-Id: Idb6ca21868789ea6e224e50e33198d684ef95638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138240
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-14  Caolán McNamara  <caolanm@redhat.com>  [f258dee15655b794596c11dcb901ada6f159881f]

        ofz#49949 Timeout
        
        Change-Id: I44ebfc50579cbcf6482fbb445c08b31961750467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138254
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Caolán McNamara  <caolanm@redhat.com>  [a6bb3eb13a6e28fd1efa2b98b18560f11f21afde]

        ofz#49750 Timeout
        
        skip slow path on fuzzing
        
        Change-Id: Idc27574ed7607011491248e726c1ba4bce9d483b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d4450b9a9fe26e03fabb07162e88f742ba2c1f77]

        chart2: allow to select the data table, fix object CID
        
        Change-Id: I0a8d3643fcaefe8105e935b929947174bd9bdc96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138247
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [300ea910badeef2c8038d9bb20683ea26f4b1973]

        chart2: add UI to the data table
        
        This adds a new object type "Data Table", with all the object
        identifiers and converters of properties.
        The data table is now shown in the drop-down of chart elements.
        A properties dialog was added, which allows to change properties
        of a data table. This contains the area, line and font tab pages
        and a new tab page specific for data tables, to change if the
        horiz. or vert. borders, key or the outline should be show.
        
        Change-Id: I9b4cd58cffbcc952daaa2c0c8f8a5a17e38ac293
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138246
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7601cf11ea31d4b74d82fde28aba65a2e2051258]

        chart2: remove unneeded class prefix in ObjectHierarchy.cxx
        
        Change-Id: Iee007f7ff4d9665ee089712e7ba98090a8090609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138245
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Caolán McNamara  <caolanm@redhat.com>  [97f2027fa75deafc7d28db3a2efe96236320d181]

        check SetOutputSizePixel for failure
        
        Change-Id: If57dbbd7f04f0ee5286cf24a00480271bd4d9f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Caolán McNamara  <caolanm@redhat.com>  [d2d01d5128b6c01bbf5bf3febb2c0ac18ebc7eda]

        ofz#50202 Direct-leak
        
        detect and flag as error failure to sucessfully create a cairo surface
        
        Change-Id: I6981ec3058e37f4f4f196f6136f1d81865623c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b3f71d852566059b98457edbc0685ef2191342ea]

        chart2: call clear instead of creating a new empty map
        
        Change-Id: I8b21909e92b558240e84cffd9432e0d9e270284e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138244
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4aa706e345db84b60706b5e17102a48e5db6563e]

        chart2: remove unneeded class prefix in ObjectHierarchy.hxx
        
        Change-Id: I1c851933e9b25dcd9a0dc29758baad8f3be7cb2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138243
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [edc5240a96f003b9aec8f8d2ce92db39ad603fd7]

        rename SwPaM::GetContentNode to GetPointContentNode/GetMarkContentNode
        
        Using a parameter to select point/mark makes the code much harder to
        read
        
        Change-Id: Ic24098a6045ff2262d4c808228ded7bf8206fe8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab0d9af99b2dc69fa8e7463fb33ca28cbccf484d]

        rename SwPaM::GetNode to GetPointNode/GetContentNode
        
        Using a parameter to select point/mark makes the code much harder to
        read
        
        Change-Id: I4ac8b904ac423e2b99253b7e4b6adc72c8afe1a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [25a299a8859e82fe0fdafc2bb70680aed54d3887]

        use more SwPosition::GetNode instead of nNode
        
        as part of the process of hiding the internals of SwPosition.
        
        This just changes the places we are passing nNode to the constructor of
        SwNodeIndex
        
        Change-Id: I3dffba5df6c044a69da27b6a1254592695b976af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-14  Noel Grandin  <noelgrandin@gmail.com>  [8bd23aaffd882e9fcc658263f083e645e9f91da0]

        improve lcl_HighestLevel
        
        only need to check for max when we are incrementing the level
        
        Change-Id: Ic8ae07783b6085c7566239d949cf351a11d0875f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138236
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-14  Justin Luth  <jluth@mail.com>  [ba8f6ca5b3f7710a27928add8e29c725d9f40901]

        tdf#77964 doc import: 0x1 placeholder is for AS_CHAR
        
        It looks like MS always provides an sprm that confirms
        this, but Kingsoft was saving without that sprm.
        
        Something similar ought to be done for ImportOLE,
        but it doesn't have a ready option for specifying
        that, so I just left it because I don't care about OLE.
        
        Change-Id: I0ae304a08b381c8c29f3db24f791f25f5e33b0c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138234
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [df3b7599f5ad92337a495224f53a1299cc82e97e]

        pass SwNode instead of SwNodeIndex to InsertTable
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I58e20facfb8987a31e354542a9a5e7824daa0b26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [89581c26be049b5af5bda96f21e908df81a1a194]

        fix UBSAN downcast...does not point to an object of type 'ScUndoManager'
        
        after
            commit 640a6488a32e8f682788feb6cab01acfffca7fa7
            Date:   Thu Jul 28 19:06:59 2022 +0200
            sc: allow undo of typing in 2 views independent from each other
        
        /sc/source/ui/view/tabvwshb.cxx:815:35: runtime error: downcast of
        address 0x6030007d3c20 which does not point to an object of type
        'ScUndoManager'
        0x6030007d3c20: note: object is of type 'EditUndoManager'
        00 00 00 00  30 0a 0d 67 ed 7f 00 00  d0 d6 11 00 f0 60 00 00  40 7b b7
        00 c0 60 00 00  00 00 00 00
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'EditUndoManager'
        /sc/source/ui/view/tabvwshb.cxx:815:35
        SfxItemSet&) /workdir/SdiTarget/sc/sdi/scslots.hxx:1456:1
        SfxItemSet&, SfxSlot const*) /sfx2/source/control/dispatch.cxx:1658:9
        /sfx2/source/control/bindings.cxx:260:22
        /sfx2/source/control/bindings.cxx:1275:17
        /sfx2/source/control/bindings.cxx:1220:5
        /sfx2/sour
        
        Change-Id: I4a505132184800a26725d602d3e27d1094e3ff65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [1743d74e87745a26043642a06dc8a57b1af29740]

        clang-tidy modernize-pass-by-value in various
        
        Change-Id: Ie091b22bd77d4e1fbff46545bc86c12f1dbafcfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138171
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [a0b9a7e7f0d14d0f121e54cb8979074bc5dfbe38]

        pass SwNode instead of SwNodeIndex to CopyFlyInFlyImpl
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ib2ac69352ca7e37117ad449fa7cb9f7cd69dd333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138232
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [0182491e5fdfe5fa085d6bed527bb66e8b6fdf39]

        pass SwNode instead of SwNodeIndex to GetSectionLevel
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I08f28a918c0d165ef4d143b8121d0aad5771dec0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138231
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [95639e7473f36a6031ac1305e0a1ed517e351976]

        unique_ptr->optional in DocxAttributeOutput
        
        Change-Id: Idd7432689700ad13765c50c22c30ae230647b24a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [235d12c5f051b9c40f3e007b3b1e49e8753b5c19]

        pass SwNode instead of SwNodeIndex to MakeEmptySection
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic24e646571eec0ff764d307e20e784d39d8411e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138230
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [796c626fe72d39f4f193107363ce92f51ee5ac68]

        Fix typo
        
        Change-Id: Ifa97ec24b479c11531e5e73f05da055df74ada60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138186
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [788be5ee625e50f14f9d4fda7c5a75f86755c6bd]

        Fix typo
        
        Change-Id: I66a7297e94c152920ac6c00a5a1aa61344a75fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138185
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [f7748dfefe3ffcf0b8f905d418b4be6e1befcbba]

        pass SwNode instead of SwNodeIndex to CopyNode
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Icaecb1c2eee09baf3f1630937bca9a96556eb023
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138225
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [38c1cba4067cffbf9f16b524ac4697efdb5c9e01]

        pass SwNode instead of SwNodeIndex to SwNode constructors
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I0b2dd3e24c82c1551a7275ffc78991823354858a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [912278671718d5d3d45fce25a3ca76228c81f7f3]

        unique_ptr->optional in SwUndoInsTable
        
        Change-Id: I30920fb2353b5d8616361c995f0947abc3d34370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Caolán McNamara  <caolanm@redhat.com>  [43c3b7440415e2a7900e85d8c8974d8a3602474e]

        cid#1507934 Big parameter passed by value
        
        and
        
        cid#1507935 Big parameter passed by value
        
        Change-Id: I11c2868960a22ca09c82aba9ee343535ac2c5ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-13  ehsan  <m.ehsan.movahedian@gmail.com>  [9b5f0234da27a674a939941d89975bc5a365f7ae]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: If783e2fbb65cae8e9c79ad9718f344dedf9dfe4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135074
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [740d45184fc7d05f8a37186dd619f07f527fa465]

        pass SwNode instead of SwNodeIndex to SwNodes::InsertTextSection
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Iddf8af8c7c9242bd3d9a48a59059b1cc8321be16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Michael Stahl  <michael.stahl@allotropia.de>  [f8f955238614312f81893ac4cb0e1dc097fec0bb]

        sw: fix crash in InitBookmarks() with forum-mso-en-8410.docx
        
        Error: attempt to dereference a past-the-end iterator.
        
        Probably this only crashes in the assert(iter->pNode...) as the rest of
        the function already checks that "iter == end".
        
        (regression from commit 46e04a712e97f9095ef4da7f0e52f50cf2bfbb32)
        
        Change-Id: If652a15d1cdebb21fbce028fceeaee8dce8f7f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138205
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-13  Caolán McNamara  <caolanm@redhat.com>  [46784e03d978cfab8aa5aff74eb15b177dbb82f1]

        complete the FIXME for the font substitution
        
        Change-Id: I9527bce0276f2aa77331f5bb16b21fc6c4402944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [56cf1d210b4d0d0f80c8c197866b706c619ece82]

        pass SwNode to DelFlyInRange instead of SwNodeIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I84fd5fbb800c822868840710e1b9fda3de2abaf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138173
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [4ea594c7012ee27bdc02ab27e909ea9dbbfc5718]

        pass SwNode instead of SwNodeIndex to SwNodes::SplitTable
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I23b23f23f2aeb559861f1328a2d795de5c54a013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138220
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [8d99841e2c2884d3305d1643b95f88f460bb8b6e]

        pass SwNode instead of SwNodeIndex to SwNodes::MergeTable
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Ia3b2563c23aaaf86f58b56bcdd60ded3c9d8404f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138219
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [0cedac9c64fe4d636be66d43d89c4c939865359b]

        no need to allocate these on the heap
        
        Change-Id: I692428cc8821f3dea53b4d6b52ced965b17f2ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [642017c88a303cf10d291d94836564edea9df0d8]

        bridges/jni : remove useless using and use css instead of com::sun::star
        
        Change-Id: I1b73d68b007ba0dfa54f99ff8f8fea55e94a1ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [1c4675580855a638877c90e70489bfae88143f4f]

        flatten SwNodes a little
        
        SwOutlineNodes does not need to be allocated separately.
        
        Change-Id: I134d3293b9b9c489c327b8c283b324875705541f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [aeefec8d794901a7b03b80aab04b7580065a6627]

        pass SwNode instead of SwNodeIndex to SwUndoInsert::SwUndoInsert
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: I00501617d8e602f51fbe6c79ba92654292e30f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [dc05dfde93afa45efab6c6ce5d2e41a2563e2404]

        unique_ptr->optional in UndoTransliterate_Data
        
        Change-Id: Ibb694d7257124a8fe4c22da45c854df3be56526e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noelgrandin@gmail.com>  [030eb8b168f3129a3a5b8b1bc757d56efcc00fa5]

        unique_ptr->optional in SwSubFont::DoOnCapitals
        
        Change-Id: I936d6e7d6bc40b81af10930642ca2a180f27c908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb41806ad98a394333234fce02ad8681f1a4604c]

        loplugin:unusedmethods
        
        tweak the python script to code with some clang weirdnes
        
        Change-Id: I88fc9f901748ff44af2b67704cc437b770ef0737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138196
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-13  Caolán McNamara  <caolanm@redhat.com>  [f4027dd967a3292cfba689ca735d839b16ac2d92]

        warning: empty <p> tag
        
        Change-Id: I6fb9dd331fe6ff9e35477a122a84ab0a6d3d8426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Noel Grandin  <noelgrandin@gmail.com>  [d57ad60d8ed5279a3366386553c5cefb7ae8b5bf]

        unique_ptr->optional in SwXTextPortion
        
        Change-Id: I6b55ed9fb907473ff2e44bfa0bd5ccced750ca60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138158
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d624c870943647a9896e45f1aeed7a1862ddbd8a]

        can store this SwNodeRange on the stack
        
        Change-Id: Ic3e985fc67dcfef7f9fd59c185e1223258123896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138194
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [02821cc81449b0807ab3478a2c91335c8471f481]

        can store this SwAttrSet on the stack
        
        Change-Id: I9e091c0fbbf75b899962db9d71138dc306c4b90a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [da2bd0555f07b0d040b8220cd9e6560a70664735]

        only store one node pointer/index in SwHyphArgs
        
        rather than two that have to be kept in sync
        
        Change-Id: Ic6443a6af80f63cc40570665d6680f9a49cdb8ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138174
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Michael Stahl  <michael.stahl@allotropia.de>  [656ff63ed045dfaedff7f34dc4adc0b203850543]

        tdf#149548 Revert "tdf#119840 loop backwards in ...
        
        ... DocumentRedlineManager::SplitRedline"
        
        This reverts commit 4701d17bfe785f00958ad58a63dc0ece4c5c3281.
        
        Somehow this reintroduces the crash.
        
        Change-Id: If6866cc59a1032f283aa8374d303b028f2cba486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138094
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [451b3e8ee8fd08b59b38c3117dc8b229b7d41215]

        Fix typo
        
        Change-Id: I354805dc54769cfa4564b0c1fd3be15f6c060b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138188
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [f6cc8cfae5e169c6ce52947c1c9bb8c838dcefb2]

        fix various glyph substitution asserts when using --without-fonts
        
        Change-Id: I1824e1a4a0ea03ba83e0a02a9436ce7cd728ebc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138203
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Noel Grandin  <noelgrandin@gmail.com>  [8fa80d743945ef7ae84e63e463ad50abd7d5a2be]

        unique_ptr->optional in MakeRegion
        
        Change-Id: I7295e337ca45761dc986c2dc660ea9a7432280b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138151
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0ec87af1be24f8bc7ac2a989cda3e40bb842aee]

        loplugin:unusedfields
        
        Change-Id: I8d15b380cd02237f688b8946530e1f024b698e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd26ff2418a8c2abc71c9155f458ff798a580bea]

        tdf#150325 Newly created animated gif is not saved
        
        regression from
            commit 6621c3c67f001c8b8798ae94bb5d84f483617cf4
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jun 20 16:51:48 2018 +0200
            loplugin:useuniqueptr in AnimationWindow
        
        Change-Id: I995a278aff3945070af45b01f1e63b253cceb24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [65f6447f891c26b3f5227431b8ed46baf169931d]

        Fix typo
        
        Change-Id: I2fbcd745717cf6c55f1ff47ca3de9ce12b8e6879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138187
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [af370069241742dd91082671a678da4a4bf740ee]

        Fix typo
        
        Change-Id: Ib7c38adc1a8d4d27197cc65b8bb704699bf1069e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138198
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ba38316f818c87b4ffbb8f114b26d459402f679]

        Remove duplicated include
        
        Change-Id: I2496cdd6652eb5f5c11ba70bc9101cf3e7e0c87d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138197
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0c9f07151a6e4549b158482b4f83cfa1677ac66]

        pass SwNode to RestFlyInRange instead of SwNodeIndex
        
        part of the process of hiding the internals of SwPosition
        
        Change-Id: Id56cbeaa67cdbfc620d26c8590f1c9eeaea26281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Justin Luth  <jluth@mail.com>  [835cda561217bd8c53af2de927158dd5712b06c0]

        related tdf#150197: use SetListFormat or SetPrefix/Suffix
        
        GetListFormat DEPENDS on having managed prefix/suffix itself,
        since it uses their getLength to modify the sListFormat.
        So any modification via SetPrefix/Suffix
        (potentially) invalidates the ListFormat.
        I added some code to ensure this doesn't get out of sync.
        
        One place that still uses PREFIX/SUFFIX is old ODT files.
        After import they are updated, but during import they use
        the old UNO properties, so I didn't add any assert here.
        
        Change-Id: I3bab780fb8e8e985c3573075bc7aac9216d116d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138073
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [acf2a2f17942c21b5aca4691c738902a3dd9aa6c]

        lok: This is tooltip, not alt
        
        Thinko from commit 0b92cf674cd44bdd2c2cdf8a5d597d4407e34002
        
        Change-Id: I66a142441f83f8cd43f2579a85651e3364e74c6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138170
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1367614cc0d75fa1c9e57e6442df9d996c6d192e]

        Fix typo
        
        Change-Id: I7ea9f6ab605dbc06f4c6d0caa152f48490854926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138184
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-08-12  Luboš Luňák  <l.lunak@collabora.com>  [c62a987ebce52f7e30afb1f6bce4c7bd3ac45644]

        revert direct append to aToken in SvRTFParser::ScanText() (tdf#150151)
        
        This reverts most of commit 09558e2f45e27d572fd261562c884c2d2cc896a7,
        the problem is that GetNextToken_() resets aToken, overwriting the value
        created by this function.
        
        Change-Id: I1daca07a6e01cfecfeff9fbf7c311b0d392d84d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138190
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3d7048552abcbcfaedffad0ba348d6939b6591d7]

        Example from DE->US
        
        Change-Id: I98a61123e632ee2d44a021f6a0aefa2920b62eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138112
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4583cc326b296d4bf97474aea480687691636a07]

        Fix typo
        
        Change-Id: I118c6e2a36c24e82abc58b1d60bd6a8d3ea4b420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138178
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [59a51e0a83f8e88a501fd4264ecac812cce09e6f]

        Fix typos
        
        Change-Id: I67e6e34265342b56bb922d2d9fc3a3385c8990d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138182
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e73fdbdf4472dae41bcaa6e6494f34a49fbcbcbe]

        Fix typo
        
        Change-Id: I63cdee1466397618cb72198c870e183b3ce90b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138183
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-12  Luboš Luňák  <l.lunak@collabora.com>  [82553b46b689c0ff4c218a2a70918c3f4dafccfe]

        fix checking glyph break position (tdf#150138)
        
        Glyphs in RTL mode are in reverse, which includes the fast that
        a cluster start is last, not first. So going back requires means
        going back just one glyph, not a whole cluster. I'm not sure why
        I originally did it this way, tdf#148954 works fine even this way,
        so presumably I got confused.
        
        Change-Id: I6ed0caf4e64e93e0643f7b88099bc7c992ea3329
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138144
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-12  Luboš Luňák  <l.lunak@collabora.com>  [d21a23cb03b54d423faf6c4a3d706cb9c749916d]

        use the same vcl::text::TextLayoutCache when comparing text layout
        
        Otherwise OutputDevice::ImplLayout() might use a temporary cache
        just for the subtext while SalLayoutGlyphsCache would use cache
        for the whole string, and those two might differ e.g. with an arabic
        string starting with numbers when the subset is just the numbers.
        
        Change-Id: Idea7ef277beae07e39e4a714088a7585361d13e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138143
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-08-12  Michael Stahl  <michael.stahl@allotropia.de>  [49a74d07ca38c313ce5cf237b4ac2df892a3fa0e]

        writerfilter: typo Srpms->Sprms
        
        Change-Id: Ib24c5711539b54b429231693fe2aa034593c6262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138156
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-12  Michael Stahl  <michael.stahl@allotropia.de>  [9cc6acce941ea9306f5c2aa81bb06ac28a7f7f45]

        sw: select entry in Insert->Bookmarks dialog when called from Navigator
        
        The context menu is called "Edit", so let's put dialog in edit mode.
        
        Change-Id: Ib3a2b164e4d6a0b93e3a5aac26125a20d41a60dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138155
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-12  Isha_Desai  <2020.isha.desai@ves.ac.in>  [44211d627f2e0652fb8ea0d071481f4cbf943be3]

        tdf#126618 Title for "Compare documents" file select dialog
        
        Change-Id: I47f6b097d51c5352e16648299c7beeb99e241136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138039
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-12  Radhey Parekh  <radhey.parekh@gmail.com>  [261f36c98448732daf70d3215883f6b0236753de]

        tdf#113753 Easier use of CSV in Wizards->Address Data Source
        
        Change-Id: Ie14aaa8621379acdb9741f67fcdeab6c477e382f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138153
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [997d7b280aa0f4495437e526e6a412e21399533f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e110ef3977829964466effa3e4e2b512d6f4086c
          - Fix typo
            
            Change-Id: If5be42039cf87934a8fb9d8b67151ddf6fd367d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/138176
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef04201e5837e1d9a0ba98c0e23baa2b6466d3de]

        Fix typo
        
        Change-Id: Iac8427094a4ec64826b712e0f79e5b24a3ea696a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138177
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [5a06127c3bdcb35bc38162f889ec038266ee0608]

        cid#1401328 Uncaught exception
        
        Change-Id: I3e438e4ea8b8061ffa3cb4253df8854e5f9f9d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [ba81f5bbeb37dfc184e178119e17a901e649374a]

        cid#1507887 Unused value
        
        Change-Id: I6c79cd874d870c3403e0bc15815f187c43cd24f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [f4f869400922e8803f4ece673f26a31983be052b]

        cid#1507888 Uninitialized scalar field
        
        Change-Id: I64747e43f76d0f214efc4bd964795517561d9693
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138163
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [544501b2db4e04b3db28d67b9ae6d498ac1a2202]

        Arial Narrow->Liberation Sans Narrow
        
        Change-Id: Ibabb753adfcf1980b2c117195e88123b27ecbdda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138162
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Caolán McNamara  <caolanm@redhat.com>  [5d54cfab9e0eb3d98dfa1a39a60068b2d02c50da]

        crashtesting: assert on export forum-fr-40415.ods to ods
        
        0 is an invalid year
        
        Change-Id: I2c638e2e2c1db628b4014a04a1c26231c236075b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138152
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [23dcd3fe7ae9d8128eb06e380eef023ef16d2702]

        vba: extract the local variable instead of accessing iterator
        
        Change-Id: I2f6dca6fa6f1f23602cbab28ef933725dfc9c3b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138166
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-12  Noel Grandin  <noelgrandin@gmail.com>  [aed2fbd28e54913ae6de13f0f68a7c60d6d6568f]

        no need to allocate this on heap
        
        Change-Id: I0a95d901d8f0b8660ad2dddf38a47b57dedc432e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138150
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [24865e2d57a32aab7212b1a283f9b30215900dda]

        clang-tidy modernize-pass-by-value in sw
        
        Change-Id: I9a3b33595e34a264baeede33672a0c090ae85157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [7786bafdb8951aa3f0acda801ddb3704c81d00d8]

        workaround -Wenum-constexpr-conversion
        
        in clang-16
        
        Change-Id: Iffacc1cc93642f150b2eab4693ff55bf8842a006
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138142
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [7548748e34966174abed39f3682bae445f1c8bdc]

        workaround clang-16 complaint in skia
        
        Change-Id: I4c7ce097c4992939f2c3443ac1eb4c7cea73b8d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138147
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [bfca51d9035000e518e4938ceb145cb92cc17b1f]

        turn off font combobox preview if SAL_ABORT_ON_NON_APPLICATION_FONT_USE set
        
        Change-Id: Ib9c74599afb2b85564de85bf64340315ca0ba4f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138108
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [5dbe2a1488de444c4af23a6009f9f16bba399052]

        don't worry about Linux Libertine O vs Linux Libertine G
        
        Change-Id: I3f7418380e655b6c25e675493d859444e343d646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138149
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [ff1db14fe71eec4cdf7e6b7cfec4c0db9c6014d2]

        add CVE-2022-1210 testcase
        
        Change-Id: I9390b128006dd3cec4e0b482885dbbd5492f912f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138138
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [0dffa005544ca29c8726aa008fadfccc5520e791]

        fix tsan data-race
        
        this check is not necessary, we are using a 32/64 bit counter (depending
        on platform) for some years now
        
        WARNING: ThreadSanitizer: data race (pid=90197)
          Atomic write of size 4 at 0x7b08002f474c by thread T90:
            #0 ScInterpreter::Interpret() interpr4.cxx:? (libsclo.so+0xb99c26)
            #1 ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95bfeb)
            #2 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) column2.cxx:? (libsclo.so+0x754eea)
            #3 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b)
            #4 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f)
            #5 ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? (libsclo.so+0x96b5e1)
            #6 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? (libcomphelper.so+0x1cb0a1)
            #7 non-virtual thunk to salhelper::Thread::run() ??:? (libuno_salhelpergcc3.so.3+0x67f7)
            #8 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae)
            #9 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245)
        
          Previous read of size 4 at 0x7b08002f474c by thread T89:
            #0 ScFormulaResult::SetToken(formula::FormulaToken const*) formularesult.cxx:? (libsclo.so+0xb0e11f)
            #1 ScFormulaResult::Assign(ScFormulaResult const&) formularesult.cxx:? (libsclo.so+0xb0e837)
            #2 ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95caa3)
            #3 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned long, unsigned long, unsigned int, unsigned int) column2.cxx:? (libsclo.so+0x754eea)
            #4 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b)
            #5 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f)
            #6 ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? (libsclo.so+0x96b5e1)
            #7 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? (libcomphelper.so+0x1cb0a1)
            #8 non-virtual thunk to salhelper::Thread::run() ??:? (libuno_salhelpergcc3.so.3+0x67f7)
            #9 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae)
            #10 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245)
        
        Change-Id: I3e51db3a8a0a18fee1647657369ecebf5de108e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Justin Luth  <jluth@mail.com>  [2405a36f3bcd43f80371ccaed47f7523ff0d8757]

        tdf#148360 doc import: add NO_NUMBERING_SHOW_FOLLOWBY(true)
        
        Change-Id: I2bc595e13fd13f29b4bf22f71c6c6bb4b4483731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138148
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-11  Michael Stahl  <michael.stahl@allotropia.de>  [eca3ce35fe9a346965a32f42d02cb6d3f5a3982f]

        tdf#129631 writerfilter,sw: RTF import of invalid border...
        
        ... and export of border on paragraph that clears the border from the
        paragraph style.
        
        The import problem is that a lone \brdrcf17 without any preceding
        keyword about which border it belongs to (as required by the EBNF in the
        RTF spec) is apparently handled by Word as overriding/clearing all
        paragraph borders that may be inherited from the paragraph style.
        
        The export problem is that a null SvxBorderLine isn't exported at all,
        but there needs to be a \brdrnone to override the definition from the
        style.
        
        There was also an API problem that the null SvxBorderLine is wrongly
        converted to a table::BorderLine2 with LineStyle SOLID.
        
        Change-Id: I5fa3857de2ef843f5194e12dd0c3e57bcf1ca52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138089
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [7e989259c63946b17cc0c7b765e4fa8261a06507]

        connectivity: avoid divide by zero in calculateTimeOuts
        
        See https://crashreport.libreoffice.org/stats/signature/connectivity::OConnectionPool::propertyChange(com::sun::star::beans::PropertyChangeEvent%20const%20&)
        
        To reproduce this, blow away your config and start writer, visit tools,
        options, base, connections and enable connection pooling enabled, find
        com.sun.star.sdbcx.comp.hdqldb.Driver and "enable pooling for this
        driver" and "apply" with the default 120 seconds, ok and exit
        
        then open a database (based on hsqldb) and click on "tables" (to start a
        connection) that default 120 seconds is the input for calculateTimeOuts
        (this becomes a final m_nALiveCount of 10 by the divide by 20), now
        visit the options again and change the 120 to something else and ok and
        the input for calculateTimeOuts is the old "10" calculated before and
        not the new expected value.
        
        The reason appears to be in OConnectionPool::propertyChange, it expects
        to get the new value of the property from evt.NewValue but it gets an
        empty Any so the m_nALiveCount is not actually changed, so the
        assumption it was set and will be >= 20 and sanely divisible by 20
        doesn't hold.
        
        For this easy fix, fetch the new value explicitly from the config
        
        Change-Id: Ie91bf5328634f9aafbda1814b10c29b86a3f9cbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138111
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef46b72f90f66892c06a513cd326916269f296c3]

        Removed duplicated includes
        
        Change-Id: Idda90285f0e364f135869eec02a5b25e8ce0e79e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138113
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0d9d0ca83fc072979ffda84d993055f44793d05d]

        lok: Simplify context change notification
        
        Change-Id: I3ead4deb5bdfe638bc49e05bfba0d8c630687958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138141
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [10e81b3dd5e0712eb8298ee7b6ebf844440fc2d8]

        some --disable-pdfium fixes
        
        Change-Id: I33867397cd5783adb90e9dc2c62b037ced131e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Justin Luth  <jluth@mail.com>  [727c5ed30f68abc28bb04531b25a1df30810760f]

        related tdf#150197: use SetListFormat instead of SetPrefix/Suffix
        
        Commits prior to this handled all the instances that were caught
        by a make check. I found a few more by temporarily setting an additional
        boolean parameter on SetPrefix/SetSuffix which let me catch these.
        This means we don't have unit tests related to these.
        
        Change-Id: I1b3bb1e6eec7878e43ccf546f6df7cb38ac5299e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138072
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [b42496a3944dce181c9c2034518e009230f3fc0e]

        update tsan suppression
        
        improve comments and add a gio function
        
        Change-Id: I4f3d57786a280093390db966cb64abb23246ebe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Noel Grandin  <noelgrandin@gmail.com>  [d3ace42f24b5bcfda10f32dcd5b180b32bde0368]

        unique_ptr->optional in SwPasteContext
        
        Change-Id: I90ccdee594340de55f7b89a07c5f35b91ea40674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138077
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Mert Tumer  <mert.tumer@collabora.com>  [b1560344c4ff2d1c5065eccdde31a8d4669510e4]

        lok: load template documents as regular documents
        
        otherwise lok cannot save them directly because
        libreoffice will try to open a save-as dialog
        For odg, change the draw8_template type draw8
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I34b0ed03adcac89eaa926f8ae6c57e6f622a90f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132633
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138098
        Tested-by: Jenkins

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [3f410b62672d5cef71ae16010b1a74b9eee52825]

        add CVE-2017-9937 testcase
        
        Change-Id: Ibefbd727a662292995be01d6c8c04354f10e9e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138110
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Michael Weghorn  <m.weghorn@posteo.de>  [c799dccfd69b69ba7e7d3a83f91ef5712798a7b6]

        a11y: Fix XAccessibleComponent::getAccessibleAtPoint doc
        
        The mention of a `TRUE` value when the return type is
        an `XAccessible` rather than a boolean looks like a
        copy-paste error from the
        `XAccessibleComponent::containsPoint` doc just above.
        While at it, also fix a typo present in both.
        
        Change-Id: I9b597f3e500c7f4e448e228ebc27c45d8dc420a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138095
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b2e8471727f0825bb18df58be86a9252de4432e]

        tdf#150219: sc_uicalc: Add unittest
        
        Change-Id: I94aeecb156485095fda476480ead3db1979f3c1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138060
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [cad5220c707ab7483e9146182e3353146ae24d41]

        tdf#150323: also add markers if there is a css style parent
        
        Change-Id: Ia900726ee31b7b19e98122d40b33581c9a60dcc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138090
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [600780e9904958bf91585d5e232e0cfa0c95827a]

        gtk3: silence 'invalid cast from 'GtkWindow' to 'GtkMenuShell' warning
        
        from the sidebar tab due to the accelerators in there
        
        its a bogus check in gtk3 in this case of a menu attached to a MenuButton
        
        Change-Id: Ie5216e749993f3d44bfc2e4560cd3b2f49aa8aec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138086
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  wjh-la  <wujiahuan@loongson.cn>  [d3625d968901eb93a9680db8d1165f70de3fd64e]

        Add loongarch64 support.
        
        Loongarch is a new RISC ISA , which includes a 32-bit version and a 64-bit version, Here are some documents about Loongarch：
        https://github.com/loongson/LoongArch-Documentation.
        
        The loongarch64 bridges implementation refers to mips64 bridges, and the code related to abi and asm has been modified
        
        Change-Id: I1d9cd3aadf63046c8cdecc9a64842567bfa1cecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137486
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [0b92cf674cd44bdd2c2cdf8a5d597d4407e34002]

        jsdialog: dump tooltips for IconView entries
        
        This required to move the code calling Help::ShowQuickHelp from
        weld objects into SvTreeListBox::RequestHelp, and have it only
        request the tooltip text from those objects.
        
        Change-Id: I25c97360bbaac4705830a13aa06e0992b68fffff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138084
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-11  Noel Grandin  <noelgrandin@gmail.com>  [cb34b8ad6fb5612411b5364bb0a0d673235c9770]

        unique_ptr->optional in SwASCIIParser
        
        Change-Id: I46cb62609c738a12cb988aa9c09171403e33c619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138105
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Noel Grandin  <noelgrandin@gmail.com>  [c8ef47651a32c9cd00183d51fb31912990b89793]

        unique_ptr->optional in SwWW8ImplReader
        
        Change-Id: I9d5961c974cf0ec378dd3560ad24d65e5d3aa197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [30efbe72f6b3a025ef12695b23821a77e1b1a887]

        calc: fix undo action disabled in different views
        
        when actions are independant.
        
        Update existing unit test to test this too.
        
        Change-Id: I0af804321c371e72fb1ce096ec4ec3566a3fcffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138079
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit db23578b694228c983b615c9be6aed8a6a2af84b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138029
        Tested-by: Jenkins

2022-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [335eb038e8964f6be99528341bfa76e4d7f55e27]

        uitest: sd: split UITest_impress_tests into 2
        
        Change-Id: I3c9d0ef457085f14ce59092db8756c04ad5ce62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138087
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [957bc2fe7093aa060f2e0abbc52cf107156e9a43]

        tdf#119246: sd: Add UItest
        
        Change-Id: I587c42e658d6f3dca2203d95cda2a972a4ddff91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138058
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [701763ac59e2e34d9211ebdd2a5748fe1a735253]

        make dtor order as reverse ctor order
        
        Change-Id: Ia5bff2361006d3dcb1032adef584ceb9910e56fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [89f4bc3b8c74a0c9e83d33577f9c924637e9c6c2]

        gtk4: clear action group in dtor
        
        Change-Id: I0b0a11fe108f63b63238e2517e9151d52673bbf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [54fb6a903ecc0161e55e4ce35c13e391cb5eade4]

        gtk4: get submenu hierarchy right
        
        i.e deck sidebar menubutton dropdown
        
        Change-Id: Ib33d4ed8593c6c73b51c4de4d2da4b5036c8a723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138097
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Caolán McNamara  <caolanm@redhat.com>  [bc73078803956561334f283311a83ff6e210723a]

        gtk4: get the menu in sidebar menubutton working
        
        this is an edge case where for gtk3 there has to be a GtkWindow present
        to support the accelerators, and for gtk4 the final window the
        menubutton is in must be the same one present when the actions were
        created.
        
        Change-Id: I08911daf8e7752b6eb589a162bb07edda76b6f30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138091
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b5aa0704734da79c0c9a89479d2c1d9e19ef20a]

        clang-tidy modernize-pass-by-value in sd
        
        Change-Id: Ic1e641b1a9373e3ae8da09436b0e8e7b852bede7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Michael Weghorn  <m.weghorn@posteo.de>  [2de74491a5a7b2183cce977f8ffaf81d0df11d75]

        qt a11y: Use correct coord system in QtAccessibleWidget::childAt
        
        `QAccessibleInterface::childAt` uses screen coordinates,
        but `XAccessibleComponent::getAccessibleAtPoint` wants
        local coordinates (i.e. coordinates relative to the
        object's top left corner), so convert accordingly.
        
        Change-Id: I61ab695ea6fdaf336903a0dc7d4c50c90a14e656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138096
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-11  Michael Weghorn  <m.weghorn@posteo.de>  [38289a8abed7dc2a34035d579bf8f0dbbf058d67]

        qt a11y: Implement QtAccessibleWidget::text{After,Before}Offset
        
        In a quick test with a Writer paragraph having the text
        "Abcd efgh ijkl" selected in Accerciser's treeview of the
        LO a11y hierarchy, the results of running these
        commands looked as expected:
        
            In [28]: text = acc.queryText()
            In [29]: text.getTextBeforeOffset(4, pyatspi.text.TEXT_BOUNDARY_CHAR)
            Out[29]: ('d', 3, 4)
            In [30]: text.getTextAfterOffset(4, pyatspi.text.TEXT_BOUNDARY_CHAR)
            Out[30]: ('e', 5, 6)
            In [31]: text.getTextBeforeOffset(4, pyatspi.text.TEXT_BOUNDARY_WORD_START)
            Out[31]: ('Abcd', 0, 4)
            In [32]: text.getTextAfterOffset(4, pyatspi.text.TEXT_BOUNDARY_WORD_START)
            Out[32]: ('efgh', 5, 9)
        
        Change-Id: Icc310c05634763e92c298e793d87a603b654ac4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138092
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-11  Michael Weghorn  <m.weghorn@posteo.de>  [69ecff82d0e5a0592f9bf6aa4fee364ff1c9754c]

        qt a11y: Check range for offset passed to text methods
        
        Otherwise LO crashes when invalid offsets are passed
        from AT when using the qt5/qt6/kf5 VCL plugins.
        
        One scenario that resulted in a crash:
        
        * start Accerciser
        * start Calc
        * press F2 in cell A1 to enter edit mode
        * navigate to the "Cell A1" object representing the
          editable cell, then to its paragraph child in
          Accerciser's treeview of the LO a11y hierarchy
        * in Accerciser's "Interface Viewer", type
          Enter, then any character
        
        This would crash due to a
        `com::sun::star::lang::IndexOutOfBoundsException`
        being thrown by one of the methods of the
        XAccessibleText/XAccessibleEditableText
        interfaces.
        
        Change-Id: I1b8c6057ca1e4e4485d516418bb82cd1a6697ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138078
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-11  Balazs Varga  <balazs.varga.extern@allotropia.de>  [f810f05e2b50068f6d14be152eb4c2ffbc1c4e5e]

        Related: tdf#150176 pptx chart import: fix automatic border style
        
        With this patch it will work not just for pptx, but other ooxml presentation
        file formats.
        
        Follow up of commit: 071a36e042c76286fedb38f479dac79f29b661f9
        (tdf#150176 pptx chart import: fix automatic border style)
        
        Change-Id: I05e03d2723e9978156dfd8025e3a4b5bcecddbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138059
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-08-11  Noel Grandin  <noelgrandin@gmail.com>  [a51509ee69b730e8987c149ac19e0bedccded127]

        unique_ptr->optional in SwUndoSaveSection
        
        Change-Id: I5fb07b35dbe3da55b6ca71537ac57dec9a5d0183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9685ae4470a4744f7cef525b8d67531e27235451]

        no need to allocate SwCallLink on the heap
        
        Change-Id: Id1300d6eba82c7aaee41fc937e07a8f9a74bd076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [450471ebbdbff40998509731028b28e0ada53f58]

        Removed duplicated included & move to pragma once
        
        Change-Id: If936a1b105f68f234a6537a4a9e9ab9661714a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138071
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [b55180df249fe9a2efa145142a9c1ed7c51be849]

        unique_ptr->optional in SwInsertField_Data
        
        Change-Id: Ifcf9cf2b3f731737e12c5316e4fa584cc47fce36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138076
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b099798085e7b883974928e06644a03ef98cea58]

        update credits
        
        Change-Id: I70c537db5dbf921de0c8b3bebf7d241f9173b705

2022-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [6aa61dc78640113060889ffe69464ef2e8aab5c4]

        jsdialog: dump IconView::GetActivateOnSingleClick
        
        Change-Id: I426c3148ee9ba92f10411ff88fc6a6fad8f0da53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138064
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b0d82e387bd541046ef92838461d2e5cf90a8a08]

        Update git submodules
        
        * Update translations from branch 'master'
          to f808bec4d777ad59ba0a993408723c34e2fa9989
          - update translations for 7.4.0 rc3/master
            
            and force-fix errors using pocheck
            
            Change-Id: I6c070b2c1cad40730d6a8ead60d4edd9b23c9c38
            
2022-08-10  Stephan Bergmann  <sbergman@redhat.com>  [ca550863f7d2e650116582dee298388ea3a97725]

        Better cast to sal_[u]IntPtr when passing pointer to O[U]String::number
        
        Change-Id: I5b7a0fa060c1e0ae4aa194e0c1862f303dd8a2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138062
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-10  Caolán McNamara  <caolanm@redhat.com>  [59341a78e42106fe8c4d1ba8298bd040e2fad9c7]

        mnemonic-widget of showlocation
        
        Change-Id: Ie0955c2c8efcec5d1f43c86fe12b3a2b964c4c0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [63f32f33709da3796b31328b358b313fd3887599]

        tdf#145226: sw_odfexport: Add unittest
        
        Change-Id: Ie9baaca378c8962326d69ad0164cf9899a1ce98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138054
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [bdf98cbb55aa89a15e194a48a7f248abb9465cb7]

        vcl: remove unused GLYPH_FONT_HEIGHT
        
        GLYPH_FONT_HEIGHT not used since:
        
        Commit: d538d3d84172a74dfe97d59a6d3daf9a45459cab
        Short title: This fallback code makes no sense any more
        
        Change-Id: I9c87e2fb2eb33abbc2a7e4d82435704f1a895c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137631
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-08-10  Michael Stahl  <michael.stahl@allotropia.de>  [b6e177982cb6c325ca67b208b2fb8397c03ab359]

        tdf#150269 sw: add unit test
        
        This was fixed by commit 3afe4f66f7266ede9922ce0682db38c9369349b7
        "sw clearing breaks: add RTF filter", which enabled sending run
        properties for \line.
        
        Change-Id: I7d8f8860bdbead0ec68ca5ad99bb28ddaa51f323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138053
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-10  Michael Stahl  <michael.stahl@allotropia.de>  [581ba395222e04e43697484bef9181c877d1fd61]

        sw: fix infinite recursion in SwEditWin::GetSurroundingTextSelection()
        
        The unexpected problem of calling SwCursorShell::Pop() from there ending
        up calling the function itself again, with gtk3 UI, on loading
        forum-mso-en-4034.docx and clicking somewhere or scrolling:
        
        466 SwEditWin::GetSurroundingTextSelection() const at sw/source/uibase/docvw/edtwin.cxx:6656
        467 ImplHandleSurroundingTextRequest(vcl::Window*, rtl::OUString&, Selection&) at vcl/source/window/winproc.cxx:2487
        468 ImplHandleSalSurroundingTextRequest(vcl::Window*, SalSurroundingTextRequestEvent*) at vcl/source/window/winproc.cxx:2497
        469 ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2826
        470 SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:306
        471 GtkSalFrame::IMHandler::signalIMRetrieveSurrounding(_GtkIMContext*, void*) at vcl/unx/gtk3/gtkframe.cxx:5707
        472 _gtk_marshal_BOOLEAN__VOIDv () at /lib64/libgtk-3.so.0
        473 g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
        474 g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
        475 gtk_im_multicontext_retrieve_surrounding_cb () at /lib64/libgtk-3.so.0
        476 _gtk_marshal_BOOLEAN__VOIDv () at /lib64/libgtk-3.so.0
        477 g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
        478 g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
        479 enable () at /lib64/libgtk-3.so.0
        480 GtkSalFrame::IMHandler::createIMContext() at vcl/unx/gtk3/gtkframe.cxx:5187
        481 GtkSalFrame::IMHandler::IMHandler(GtkSalFrame*) at vcl/unx/gtk3/gtkframe.cxx:5153
        482 GtkSalFrame::SetInputContext(SalInputContext*) at vcl/unx/gtk3/gtkframe.cxx:2711
        483 vcl::Window::ImplNewInputContext() () at vcl/source/window/window.cxx:1781
        484 vcl::Window::SetInputContext(InputContext const&) at vcl/source/window/window.cxx:2083
        485 SwView::CheckReadonlySelection() at sw/source/uibase/uiview/view.cxx:699
        486 SwView::AttrChangedNotify(LinkParamNone*) at sw/source/uibase/uiview/view.cxx:510
        487 SwView::LinkStubAttrChangedNotify(void*, LinkParamNone*) at sw/source/uibase/uiview/view.cxx:499
        488 Link<LinkParamNone*, void>::Call(LinkParamNone*) const at include/tools/link.hxx:111
        489 SwCursorShell::CallChgLnk() at sw/source/core/crsr/crsrsh.cxx:2544
        490 SwCallLink::~SwCallLink() at sw/source/core/crsr/callnk.cxx:149
        491 SwCursorShell::Pop(SwCursorShell::PopMode) at sw/source/core/crsr/crsrsh.cxx:2327
        492 SwWrtShell::Pop(SwCursorShell::PopMode) at sw/source/uibase/wrtsh/wrtsh1.cxx:2016
        493 SwEditWin::GetSurroundingTextSelection() const at sw/source/uibase/docvw/edtwin.cxx:6656
        
        This SwCallLink looks unnecessary here, but it's triggered because it
        compares the state before Pop() to the state after Pop(), instead of the
        state before Push() to the state after Pop().
        
        This problem could probably benefit from being solved more generally,
        but with 2 functions involved it gets rather ugly as it can't easily be
        encapsulated in SwCursorShell.
        
        (probably regression from aac9bd235e65b27faf63e64bba3ecd94837381d6)
        
        Change-Id: Ief176b54daf96da378d2e5d57f3dd5b4a0817299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137987
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-10  Michael Stahl  <michael.stahl@allotropia.de>  [4f62ae798cc1f9f7bc524e408fc7a370345b40a8]

        sw_fieldmarkhide: fix crash on exporting forum-mso-en-4034.docx to ODT
        
        The problem is that there's a field in a preceding paragraph that ends
        immediately before another field starts, and so the backwards iteration
        erroneously picks it up in ModelToViewHelper ctor.
        
        Change-Id: I6e65c04e0372377b3af48f1d80de287b6113e1c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137986
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [77a8d0d06573cd095863904d34dc7a0ca131cf1a]

        unique_ptr->optional in SwFormatContent
        
        Change-Id: I815fa0f2dcdc1512958d95703b56449010fd2f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [17073362f47425996575cefb682383f2710d3436]

        unique_ptr->optional in SwUndoInsert
        
        Change-Id: Id351826427ef1ab6a292d7af96d3fa5bcf6ebb9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [296110d547903ef67f6d1048c044378d30cb1406]

        unique_ptr->optional in SwUndoDelete
        
        Change-Id: I29cc59bb7283e86d4045cd854d7e9a4f056c3361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Maxim Monastirsky  <momonasmon@gmail.com>  [f4c922f91e717728376dca943008a6dd56387c71]

        Missing colon in toolbar help ids
        
        Regression of 5200a73627d13e2997f81b53f61e143e77e328ee
        ("use more string_view in various").
        
        Change-Id: I402eb6c03dcfa661c79c5469cfca3c86ac528f60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138066
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-10  Maxim Monastirsky  <momonasmon@gmail.com>  [c76857fe4e725834e6be9bd5b3273df95bf7fafd]

        Make ToolBox::InsertItem take the command name
        
        For the next patch for tdf#149956 I need the command to be
        already set when the VclEventId::ToolboxItemAdded event is emitted.
        
        Change-Id: I3d8ce44b426a3ed5704d4520d6e62bc4efbf8e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138038
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-10  Maxim Monastirsky  <momonasmon@gmail.com>  [085abe2b7187f2cfd69a5a1c6e84ef0c9c214f78]

        Unnecessary ToolBox::SetItemText call
        
        Change-Id: I8d15e9657b3a6d01de9d07130ae3aa8284fbd178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138037
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [032bacd44fc1a4a9c55139aa3fc13d988ef3d6a9]

        unique_ptr->optional in SwUndoInserts
        
        Change-Id: I838be443a9521db23ca903ce3d5804cdf8bbf674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [c83f85dcd9960e73564fe9a1b5866bee6c779118]

        unique_ptr->optional in SwTextFootnote
        
        Change-Id: Icc08fde3d385403d59fde8555f4b1d160209f3a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Noel Grandin  <noelgrandin@gmail.com>  [495563ecfdac26111f36b27acbe6caaac0d402fb]

        unique_ptr->optional in MoveNodeRange
        
        Change-Id: Ibc75ffd2ec5bad7eb3ef99fae526dd49b2f4e8c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c909d1466bf940f653984b61772cf19c320439d]

        loplugin:passstuffbyref
        
        Change-Id: Ib2b2650da7abc9260897f9b5aad619a0ea6ae941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138052
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [91d77d65190e7cf11dd7cd0b29d5de6b66061faf]

        vcl: AnimationRenderer::getOutPos() -> GetOriginPosition()
        
        Change-Id: I23275aa9915ea47cb91a8511b219869a4d62b96a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137352
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-10  offtkp  <parisoplop@gmail.com>  [100893da6f1db69f79d6c35b63df4053a9341784]

        Remove code duplication in GraphicDescriptor for GIF
        
        GraphicFormatDetector and GraphicDescriptor have duplicate format
        detection code so now GraphicDescriptor uses GraphicFormatDetector
        functions instead to detect the format for GIF files
        
        Change-Id: Ieabacb302c9c712fc6f3da85eaccc07dca035eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137934
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-10  offtkp  <parisoplop@gmail.com>  [5e636747faf919e36bfd015c6dfcf0aea0c41938]

        Prepare GraphicDescriptor and GraphicFormatDetector for merging
        
        Make GraphicFormatDetector return GraphicFileFormat instead of a string
        and various variable changes so that the two can be combined in future
        patches.
        
        Change-Id: I6e184b3ba52289db02e0d4eebeeadde0ce0433b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137627
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e2ce2a460458f17ee4360c45a2da2fc4b4d753e]

        uitest: sw: add test for add and remove in customize dialog
        
        intended to be a test for tdf#149966 but it's not reproducible
        with gen. Anyway, it's worth it to have it
        
        Change-Id: I2323bdec1f1c2b17ddd310257edec5156862b176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138036
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-09  Stephan Bergmann  <sbergman@redhat.com>  [790db5f98e7550a5d990e6b2907789509d53d382]

        Mark external/boost/constexpr.patch.0 as upstreamed
        
        Change-Id: I23898f6aebd5a1fd28a2de9da6a89503b25eb6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138035
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-09  Caolán McNamara  <caolanm@redhat.com>  [2d074a0b98c9150d2f15056ea86dcc9305f43ab3]

        crashreporting: frequent crash seen in PackedFile::flush
        
        at:
        
        if (osl::File::E_None == osl::FileBase::createTempFile(nullptr, &aHandle, &aTempURL))
        {
            ....
            if (osl_File_E_None == osl_writeFile(aHandle, ...
        
        createTempFile is returning osl::File::E_None but presumably we are
        missing setting a possible error state here
        
        https: //crashreport.libreoffice.org/stats/crash_details/ea4b4050-dd0f-42b1-b30f-b67612806371
        Change-Id: Ib2d0c3c91e40fe985571e79822b91f2faf401471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138013
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [a22746eb8e2e64ce31f304b601c4ea0ecf95da1a]

        uitest: sw: remove duplicated test
        
        Besides, remove empty lines and simplify code a bit
        
        Change-Id: I0e756a0209b3f126f4384e1485fcbc3d8075a372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5df8f82938973b2dd63e39d96b95833670005ba]

        tdf#149916: sw: Add UItest
        
        Change-Id: I79b75c35023c1f508a0e4e48739ca7ee99c19d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138012
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-09  Chris Sherlock  <chris.sherlock79@gmail.com>  [57fddf3e644c99715fb3bdf2e107aa2495c0ecf9]

        tools: json writer test does not need to use test::BootstrapFixture
        
        Change-Id: Iea7fa63ca7a3208d065ac2960998041672fc8d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136231
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [a9a6ec313be4787f99cece793f069f61a8ee73b2]

        crashreportScraper: replace quation marks from code
        
        otherwise, the csv is imported incorrectly
        
        Change-Id: I5451516b2fdc80a96a4fde83a2c72d701bfd995a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138009
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-09  Noel Grandin  <noelgrandin@gmail.com>  [620b18d0dda96525d818698ea6ce84c9e27e9d7b]

        unique_ptr->optional in SwAutoCorrDoc
        
        Change-Id: I3280b588f365b73e08e17f14e2909b58e0fd85ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137998
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [892bd0dfc1b107a5b00af36a0d0db1f9f9c05147]

        qt a11y: Return actual range of text with same attributes
        
        The start and end offset returned by
        `QAccessibleTextInterface::attributes` should indicate
        the start and end of a text segment where all characters
        have the same text attributes (like font size, color,...).
        
        Calling `XAccessibleText::getTextAtIndex` with type
        `accessibility::AccessibleTextType::ATTRIBUTE_RUN` gives
        exactly that information, so make use of it instead
        of claiming that only the character itself has those
        attributes.
        
        This is e.g. used in Accerciser's "Interface Viewer"
        for the text interface, to display the indices and
        highlight the text portion in which all characters
        have the same attributes.
        
        Change-Id: Iefb096f30c9df74f035d2fda86299d9a5de5d604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138008
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-09  Niko Fink  <libreoffice@niko.fink.bayern>  [1052ec9cff72e2810fdb934a85ab500d3b4ace35]

        tdf#133123: fix crash when importing defusedxml.ElementTree after pyuno
        
        Change-Id: I89ac6108c679504c81dd9a439a4fb02e9e1adc07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138007
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-09  Justin Luth  <jluth@mail.com>  [a8ae24a8bd7bfffa75af9d0dc50765d51df9c720]

        tdf#150278: avoid gen/gtk3 difference in m_xPropBox->GetCurPage()
        
        When switching between tabs, at this call SAL_USE_VCLPLUGIN=gen
        was returning the switched-to-tab id, while gtk3 was still
        returning the leaving-tab's id.
        
        So just ignore all that an use the OnActivatePage value.
        
        Change-Id: I166626eac033af65e95f8a280076a6bcc070bee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138003
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Balazs Varga  <balazs.varga.extern@allotropia.de>  [071a36e042c76286fedb38f479dac79f29b661f9]

        tdf#150176 pptx chart import: fix automatic border style
        
        Do not set the default border style for chart area in case of
        pptx charts, if it is came from the MSO as an automtic line style.
        
        regression from commit: 0dac43445b35da7e554dd4d7574c59611a0d0be1
        (tdf#81437 XLSX import: fix missing chart border)
        
        Change-Id: Iaaaecc1dffe80c3f1528851e707236f2f7228bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137993
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-08-09  Julien Nabet  <serval2412@yahoo.fr>  [a28ff6a920492b64095b30cf7800b0678ea84c60]

        tdf#124076: fix preview for horizontal alignment of object in frame border
        
        ...has left and right image exchanged
        
        Change-Id: Idea8fc05ab70133e6c0576a6def0610e94d1580e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137903
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Michael Stahl  <michael.stahl@allotropia.de>  [be11a3573a21e83dfb6a473d98bc8ba9bf57057c]

        vcl: allow editing a column other than the first one in GtkInstanceTreeView
        
        This is basically commit fe38553aef2121f358fb58e450ec69314aad851e
        for the native GTK widgets, so the "Edit Text" button in
        Insert->Bookmarks dialog works.
        
        Change-Id: Ifcd115de60ecee2c4e4c19535ce55156aa84ff79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137563
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-09  Chris Sherlock  <chris.sherlock79@gmail.com>  [fd9763cb7ecb05c43bcd23f6aedf73489e1bccb8]

        tools: prefix member variables with an 'm'
        
        Also updated debug pretty-printers
        
        Change-Id: I5204bb8f1c6a47677ad3c49d6579c090ea69aedc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137388
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-09  Eike Rathke  <erack@redhat.com>  [33c8c9d0dc8e76bc7dacb92175047a89f7d39a3c]

        Use CharClass::uppercase() for AddIns' English UI names, tdf#135993 follow-up
        
        ... instead of OUString::toAsciiUpperCase(). English names should
        consist of ASCII alphanumeric only, but we don't know what an
        AddIn's author comes up with. Lookup in ScCompiler is done with
        CharClass as well.
        
        For this, use the static ScCompiler::GetCharClassEnglish()
        instance made public and guard creation with a mutex.
        
        Change-Id: Icb79d49d4c7339c8d01b141de2a34715d794dd92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138004
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-09  Caolán McNamara  <caolanm@redhat.com>  [8f0e5308fac99f4c47fae98674f29a6a6a2948e5]

        sfx2: check saved last tab page name exists before restoring it
        
        since GetPage might return nullptr on a nonexisting page
        
        See https://crashreport.libreoffice.org/stats/signature/SfxHelpIndexWindow_Impl::ActivatePageHdl(rtl::OString%20const%20&)
        
        Change-Id: I26e21f783645e8a87d56cbe76c0126de8947bf3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137990
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Caolán McNamara  <caolanm@redhat.com>  [0c9c3f75d7f0d44efc4fe1d6320a07de8c04b36e]

        cid#1507857 Big parameter passed by value
        
        and
        
        cid#1507854 Big parameter passed by value
        cid#1507853 Big parameter passed by value
        cid#1507848 Big parameter passed by value
        cid#1507846 Big parameter passed by value
        cid#1507844 Big parameter passed by value
        cid#1507843 Big parameter passed by value
        cid#1507842 Big parameter passed by value
        cid#1507845 Big parameter passed by value
        cid#1507847 Big parameter passed by value
        cid#1507849 Big parameter passed by value
        cid#1507855 Big parameter passed by value
        cid#1507850 Big parameter passed by value
        cid#1507852 Big parameter passed by value
        
        Change-Id: I03138b93d0936fe5e62453651227f3925a7b4b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137981
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Caolán McNamara  <caolanm@redhat.com>  [813ad0b0e1b5b8708c900c58d8a974770a2bd73a]

        cid#1507856 silence Invalid type in argument to printf format specifier
        
        Change-Id: I05cfe777108667ea3640519b3231431fbe3fc0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Caolán McNamara  <caolanm@redhat.com>  [6f377e7baef480745ec7514c252087710ab9f2b0]

        move scrbar.hxx to vcl/toolkit
        
        Change-Id: I77038cbf500976703ad41365da9a675a698863a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137979
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-09  Michael Weghorn  <m.weghorn@posteo.de>  [1703c3bb70b1faa522c33ebdc1a8f353c60367e5]

        tdf#149818 qt: Handle double mouse click again
        
        Qt has `QEvent::MouseButtonDblClick` as a specialized
        type for "Mouse press again" [1] in addition to
        just `QEvent::MouseButtonPress` for a single click.
        Handle that as mouse button down event in LO as well,
        to make handling of double-click work again after
        
            commit 393c9f736b10d1ea82979e9c2c43c8f91ba5831d
            Date:   Tue Apr 19 16:00:31 2022 +0200
        
                Qt use QEvent::type to handle the event correctly
        
        [1] https://doc.qt.io/qt-6/qevent.html
        
        Change-Id: I9964b554bf71f30861ed0868e7a8000c84de50ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138006
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [452311610d38d7e147b2ec2345b76c1b29646159]

        crashreportScraper: continue when os_tab is not found
        
        Change-Id: I293ad70ad2776bfa6ea3e075ba69428963301433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137994
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-09  Stephan Bergmann  <sbergman@redhat.com>  [b8e451af93c2917d70214c75bb6b6a8bf566813b]

        Use stable_sort in comphelper::s3sort
        
        With a randomizing debug-mode libc++ (`export LIBCPP_DEBUG=-D_LIBCPP_DEBUG=1`
        in config_host.mk), CppunitTest_sc_ucalc_pivottable consistently failed for me
        with
        
        > Expected: A  Actual: a
        > sc/qa/unit/ucalc_pivottable.cxx:1886:TestPivottable::testPivotTableCaseInsensitiveStrings
        > assertion failed
        > - Expression: bSuccess
        > - Table output check failed
        
        when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is 140365334480272.
        
        This change apparently happens to fix it, but I have no idea what exactly is
        going on here.  (comphelper::s3sort was introduced in
        46d0afba738d8ee7c9b63384fef513f42ee587f3 "Implement parallel version of
        super-scalar-sample-sort...", and
        TestPivottable::testPivotTableCaseInsensitiveStrings traces back to
        96086484d3429ff849b468ef5d1ff8ac8e7874a9 "Move pivot table tests into a separate
        source file.)
        
        Change-Id: I24316db6cb274f7afd0ce0a5aa9ced79121eeeb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136623
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-09  Justin Luth  <jluth@mail.com>  [6161b951c246125caf3efc009def0faf7caccc75]

        tdf#150278 sfx2: use provided aInfo, not factory
        
        This continues the revolution from tdf#81293 that was done
        for the MOD section of this function in 7.4.
        It looks like the same thing needs to be done for APP.
        
        Prior to this commit, opening up the same form control
        property dialog always opened up to the same initial tab,
        regardless of the last-used-tab. ONLY of document reload
        would the last-used-tab come into play.
        
        Now it always opens up immediately tot he last-used-tab.
        
        This is full fix for SAL_USE_VCLPLUGIN=gen.
        gtk3 needs an additional fix so it doesn't follow the
        second-last-used-tab instead.
        
        Change-Id: Ie7c13cfb48de87c4ab595460680f4306e8feaac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-09  Noel Grandin  <noelgrandin@gmail.com>  [9bfc9c3f414a5ff928fe093a4725e5e00e28aba5]

        unique_ptr->optional in CellSaveStruct
        
        Change-Id: I046442f4ebfb62ad4ec346fa5622b37370774698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-09  Noel Grandin  <noelgrandin@gmail.com>  [c7e9a787a289c20e330df83e780da051f8646146]

        unique_ptr->optional in SaveRedlEndPosForRestore
        
        Change-Id: I355931b53457079c0bce3da26a99f250fdc11bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137997
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-09  Noel Grandin  <noelgrandin@gmail.com>  [029e607ef095be49d0d2e843cc183a99c587deab]

        no need to allocate this separately in SwHTMLPosFlyFrame
        
        Change-Id: Icf85acd3d96889248c62925993b06ca7ec7a52a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137996
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-09  Stanislav Lopatin  <genkiginchan@gmail.com>  [815851d1cbc427bbd85da1638f3b121b253d0926]

        tdf#145538 Change common loops to range based in ScanlineToolsTest.cxx
        
        Just convert some loops to range based and fix strange loop logic
        at 216 line.
        
        Upd: rename *iterators* as Mike Kaganski adviced
        
        Change-Id: Idf33b65f9c4466aa49c8f3bc13a12ad072dce7b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137929
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [3905d44dd11b5722b7d5019e8705b1fbef48de9e]

        gtk4: set draw-as-radio explicitly on
        
        Change-Id: I546abe771a6c6d1029258ac702713e34353b8e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [3fa9af03d409a6137c174618e0376c3c78aec60b]

        resave with latest glade
        
        Change-Id: I0c217736e9c4a0eea5315f32a1562d76a6ce84f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137991
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [729c29f3bef16ea85fd8ce7aa32a010a204589ad]

        sd: avoid divide by zero in FuZoom::MouseMove
        
        See https://crashreport.libreoffice.org/stats/signature/sd::FuZoom::MouseMove(MouseEvent%20const%20&)
        
        Change-Id: I3b07def2ba088a92e2358e7db57c27c047165cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137988
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-08-08  Jim Raykowski  <raykowj@gmail.com>  [469414e66f2b55c06439aaf062aa6dae66ef3096]

        tdf#138868 follow up: fix selected entry not unselected
        
        For Gtk3, setting the Navigator tree view cursor -1 doesn't unselect
        the selected entry which is what is wanted when the canvas selected
        object is not in the Navigator tree view.
        
        Change-Id: I879e8dc09870b91d42eadb6b42d9236c1a1cf40c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137916
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-08  Stephan Bergmann  <sbergman@redhat.com>  [cc3e2e7efa35dea85eecdd163de1ca1e71ce01f7]

        Adapt to changed clang::LambdaCapture::getCapturedVar return type
        
        ...where
        <https://github.com/llvm/llvm-project/commit/127bf44385424891eb04cff8e52d3f157fc2cb7c>
        "[Clang][C++20] Support capturing structured bindings in lambdas" on Clang 16
        trunk changed the return type from VarDecl to ValueDecl, causing
        
        > compilerplugins/clang/reducevarscope.cxx:541:26: error: no matching member function for call to 'erase'
        >             maVarDeclMap.erase(varDecl);
        >             ~~~~~~~~~~~~~^~~~~
        > /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:740:7: note: candidate function not viable: no known conversion from 'ValueDecl *' to 'const_iterator' (aka '_Node_const_iterator<std::pair<const clang::VarDecl *const, (anonymous namespace)::ReduceVarScope::DepthInfo>, __constant_iterators::value, __hash_cached::value>') for 1st argument
        >       erase(const_iterator __position)
        >       ^
        > /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:745:7: note: candidate function not viable: no known conversion from 'ValueDecl *' to 'iterator' (aka '_Node_iterator<std::pair<const clang::VarDecl *const, (anonymous namespace)::ReduceVarScope::DepthInfo>, __constant_iterators::value, __hash_cached::value>') for 1st argument
        >       erase(iterator __position)
        >       ^
        > /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:762:7: note: candidate function not viable: cannot convert from base class pointer 'ValueDecl *' to derived class pointer 'const key_type' (aka 'const clang::VarDecl *const') for 1st argument
        >       erase(const key_type& __x)
        >       ^
        > /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/unordered_map.h:780:7: note: candidate function not viable: requires 2 arguments, but 1 was provided
        >       erase(const_iterator __first, const_iterator __last)
        >       ^
        
        etc.
        
        Change-Id: I79b062ca604435bc83a58eeb32df673e6c658bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137984
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-08  Stephan Bergmann  <sbergman@redhat.com>  [fb992aefc8345a9be780c6928e4380da7c56904e]

        Adapt to changes in llvm::Optional
        
        <https://github.com/llvm/llvm-project/commit/3c49576417bab1b07764aa0b22664cbc8d3c3f53>
        "[ADT] Add has_value, value, value_or to llvm::Optional" is in Clang 15, and
        <https://github.com/llvm/llvm-project/commit/b5f8d42efe3e246d582d4a1a328fac915e4ce8dc>
        "[ADT] Deprecate Optional::{hasValue,getValue} (NFC)" is in Clang 16 trunk,
        causing
        
        > In file included from compilerplugins/clang/sharedvisitor/sharedvisitor.cxx:95:
        > compilerplugins/clang/pointerbool.cxx:118:21: error: 'hasValue' is deprecated: Use has_value instead. [-Werror,-Wdeprecated-declarations]
        >             if (ret.hasValue() && (ret.getValue() == 1 || ret.getValue() == 0))
        >                     ^
        > ~/llvm/inst/include/llvm/ADT/Optional.h:324:5: note: 'hasValue' has been explicitly marked deprecated here
        >   [[deprecated("Use has_value instead.")]] constexpr bool hasValue() const {
        >     ^
        
        etc.
        
        Change-Id: I377effe29fc6752484d2870b9a0fd66fddc26bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137982
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [00f3bbc84634a9f07c046140d84445303585817c]

        unique_ptr->optional in SwRangeRedline
        
        Change-Id: I4d4c55eef6e6b56634766bc57f11539ece9dc20d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137940
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [87bde9e695f72e3e9f498ef4d9d76dd2fcff24db]

        gtk4: cursor not changing on moving over other widgets
        
        Change-Id: I57f924522a6fd93950f56c44ca65aa5131fb4aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137989
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [d632b83a4b4998930112218081db4d619713583b]

        gtk4: complete set_cursor for gtk4
        
        Change-Id: I31413a6dafe1ddf1345ac6bccb96fc88ed2993c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137985
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [479cf04cee6f360c9bca618369b6b545b94e55ef]

        drop unwanted scroll corner
        
        Change-Id: I82143de336df91c5ca69693f6255b0d729e8381b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [b8128ae611a23e81544f7e4b96ec196a8594f840]

        no need for ScrollBarBox if bg is already the desired color
        
        Change-Id: I94f83a1c2142b8b8712fc3527a90dad4f0babb9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [9130c1abc65aedd0358d9f9dd4b9108b7e68f70f]

        make SwDoc::IsInTable more efficient
        
        Just follow the pointers, instead of unnecesarily indexing through
        the SwNodes array.
        
        Change-Id: I7da103d1300e1cbb54a8ca2994170fb7b2d9779f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [5ae0fcbc4a93cbc52071cf6ecfe271031af3ec27]

        no need to allocate on heap in lcl_FindField
        
        Change-Id: Ia9172292220f6935e4a21b659d07dc317c060740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [84329105914c6fb576792ee1788f237e5927871a]

        unique_ptr->optional in XTextRangeOrNodeIndexPosition
        
        Change-Id: Ie98a79befe4ab3d9a78c908169b0004f478075be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [307af8c1b0fd9f2b4b8aa2bf86151b65ec0cdf0e]

        unique_ptr->optional in SwXMLImport
        
        Change-Id: I66d32a8ffd03fb87aa9380f3f84b6e7463258a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137975
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [094572831b7e5fdc24d05f8244a70b4e9b4bb616]

        these two scrollbars don't meet, so drop the junction box
        
        Change-Id: I066a63910d7ad71c3777b26091ce527e4017017c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [ba394d2c9a2584ab9745b1b4f3deee3d7aa44636]

        move m_bNavigationBar to BrowseBox so it knows best scroll/status bar height
        
        to use, so databrowser with it (view data sources) has the tall case,
        while bases, create table in design view has the short case
        
        Change-Id: If3269d2ab2ce62f09acac624e5ef7e91ff91eaea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [6aedcba229bcead97fdb54e90d12dac1f9e94eb8]

        use separate width and height for databrowser vert/horz scroll sizes
        
        the scrollbar in the statusbar can be thicker than the vertical one
        which looks weird when both set to the thick size
        
        Change-Id: I76496e47203a7cde72082f8e6b83f5af3e8c3759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137952
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [bb24d34db707f574feb63e1ac657a159e21924c9]

        overpaint scrollbar junction with the face color
        
        Change-Id: Ib2dba2d5e47a8c39f79c3ab5a8e79e8185599da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137951
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Michael Stahl  <michael.stahl@allotropia.de>  [47b08551a77918e4d35a98197ac99c1c3d5dec73]

        tdf#148518 writerfilter,sw: RTF import/export of FORMDROPDOWN field
        
        On import, the values overwrote each other; export of the form data
        was missing completely.
        
        Change-Id: I918b3cfced39dc2602c6de03cdaf5848a9825dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137861
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-08  Mike Kaganski  <mike.kaganski@collabora.com>  [a1c536543df90723f33851609e78f3ace177d6a5]

        tdf#150293: UITest
        
        Change-Id: I662e82cce6dd8dbf13bac8608af064b34e21e0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137949
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [e50f6c023926269f76cd73e085b7a246cd0f88fa]

        no need for ScrollBarBox when bg is already the desired color
        
        Change-Id: I5e50d67687355b38190a991ea539b2d40ef74659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [d564d73673dc4dce43c988421397a6feae7620d5]

        no need for ScrollBarBox if bg is already the desired color
        
        Change-Id: Ia471938bf0340bdef51b4a745814194f57893eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137947
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [c473a34d77968fc9fad49f0c2539d37da4709fce]

        no need for ScrollBarBox when bg is already the desired color
        
        Change-Id: Id9dd4d4e3ba2c0b0a335fc9f8b1892cd70daf010
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137945
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [e77bfe281403e49c58730489e94b62032c296e75]

        android: Add scrollbars.ui into APK
        
        That UI file was added in
        
            commit 4bc62c4e9b5b4eab6e2e40577789c435dce59f66
            Date:   Thu Aug 4 15:33:51 2022 +0100
        
                split SwScrollbar up for reuse of adaptor
        
        Include it for Android.
        Without it, trying to load/display any document
        would result in Android Viewer crashing or getting stuck,
        with this in the ADB log:
        
            08-08 09:22:20.102  6064  6256 D libo:sal/osl/unx/file: double-slash in path: /assets//config/soffice.cfg/svt/ui/scrollbars.ui
            08-08 09:22:20.102  6064  6256 E libo:sal/osl/unx/file: miss cache: failed to open /assets//config/soffice.cfg/svt/ui/scrollbars.ui
            08-08 09:22:20.102  6064  6256 W vcl.builder: 23:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
            08-08 09:22:20.102  6064  6256 W vcl.builder:     when: Unable to read .ui file exception: void
            08-08 09:22:20.103  6064  6256 I LOKitTileProvider: ====> mOffice.documentLoad() returned null, trying to restart 'Office' and loading again
        
        Change-Id: I0938d77dc9553d8acc7b2bdd4a72b5299b4ec1a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137943
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [fd95bf6dea0bfa5a9fd1254c11854dec4a2cdcff]

        android: Drop empty main.jni.srcDirs from sourceSets
        
        This was shown as a recommended step in Android Studio
        when the update to Android Gradle Plugin 7.2.2 was
        suggested:
        
        > *Remove jni source directory from sourceSets*
        >
        > The jni block in an android
        > sourceSet does nothing, and will be removed in Android Gradle Plugin
        > version 8.0.0.
        
        Change-Id: I3378926047d5ad86548d0bf800e022b74efb5e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137942
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [56e7646a7dd421ef148a2452ea175c6a4cb91985]

        ofz#24932 Timeout
        
        restrict this to a very short length to reset ofz Timeout to force
        ofz to report a new issue when restored later
        
        Change-Id: Ibbdbb60f16ddca8367355d4c855e58aa16ea5f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Michael Weghorn  <m.weghorn@posteo.de>  [495efc3396f04a6dc2200b33d9969f125b2a79c8]

        android: Update Android Gradle Plugin to 7.2.2
        
        Change-Id: I3235716498168ca5eebf71ebf6f5ee571af7a72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137941
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-08  Caolán McNamara  <caolanm@redhat.com>  [cdf5b6a2a6f0ba2838323ce4398948c3d3a56f8e]

        tdf#117388 use native scrollbar under gtk in richedit control
        
        you get one of these by starting with a normal text box form control
        and changing its "text type" property to multi-line with formatting
        
        Change-Id: If922b6b9fdc49b78fa379dbb3e5974a73f6095ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-08  Noel Grandin  <noelgrandin@gmail.com>  [1b44b9d0c796a31b54c4160fa86f1d9225d60738]

        make more of the SwPaM constructors explicit
        
        which flushes out some more places where we were implicitly
        construcing temporaries
        
        Change-Id: I2eee5f99071cd8c155de1be369ba89ec1d732bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-08  Stephan Bergmann  <sbergman@redhat.com>  [8785b280eadbd04f78b32d352e9475f0772dd095]

        Pass $(verbose) into ExternalProject_libxml2
        
        Change-Id: I11c7c15f4a97d3024a179fd2489fdace27f15216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137892
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-08  Julien Nabet  <serval2412@yahoo.fr>  [7b204ecb49563544ee9c811dbcbee998062bf511]

        Related tdf#114790: add align and vertalign to datefield im/export
        
        Change-Id: I2661e0c372fbb3c364ac338f23ebbd5b1a448ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137936
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-07  Caolán McNamara  <caolanm@redhat.com>  [a56705efdbe9ceb0f5bb92d1d8bb2cefbc03f3ac]

        add set_scroll_thickness to provide a way to "zoom" the scrollbar
        
        Change-Id: I551112fb097a6ac2b442cd37d1a16bd2b34ecc54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137932
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [70015759e2d0ccf3fab0629bbea5c5d44a3975be]

        no need to allocate these SwPosition separately
        
        It is a small object, and in these places is already contained
        inside a heap object.
        
        Change-Id: Ib9aba6feaf0dd2c24659c03e55fc8a872610cc00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Mike Kaganski  <mike.kaganski@collabora.com>  [47b4c9bb7f0ef0175e55acaf22c740d11f6e9474]

        tdf#150293: setPropertyValue(WID_TXTCOL_LINE_WIDTH) takes mm100
        
        Before commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Thu May 27 13:00:10 2021 +0300
            editengine-columns: ODF support [API CHANGE]
        
        SwXTextColumns crtor took SwFormatCol, and stored line width in the
        same units as in SwFormatCol - in twips; conversion to mm100 only
        happened at export stage in SwXTextColumns::getPropertyValue.
        The mentioned commit changed to SvxXTextColumns::setPropertyValue,
        passing the line width from SwFormatCol also without any conversion;
        but SvxXTextColumns::setPropertyValue expects mm100, so the result
        was wrong.
        
        So perform the proper conversion at SwFormatCol::QueryValue and
        SwFormatCol::PutValue, and also store the line width in mm100 in
        SvxXTextColumns, to avoid useless extra conversion.
        
        Change-Id: Idfd62a7563f9d3aa5947c1149572a8b8b696b179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137931
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1cefa026d52fad4557d10c721fe9d5e57200bd6]

        no need to allocate these SwPosition separately
        
        It is a small object, and in these places is already contained
        inside a heap object.
        
        Change-Id: I930d87827104e04fff2ad6b481ed94348a49701d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [57ae68004899076303666da3ed7b2ee8a1e5ae94]

        no need to allocate these SwPosition separately
        
        It is a small object, and in these places is already contained
        inside a heap object.
        
        Change-Id: I63eee5390e4ab1d1a66197a100e3876f96f95944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [57de9cb734cbfc901a1b34a8fe4abe7167128cf5]

        Removed duplicated includes
        
        Change-Id: Ibf7f764eabd687e668183e276008c58086d45bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137926
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [80f99cda3d25180f0b9fbdbb6f25c7e3e295fee9]

        no need to allocate these SwPosition separately
        
        It is a small object, and in these places is already contained
        inside a heap object.
        
        Change-Id: Ib90f482c850d7e376637c5a11a7d09d78081719a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Caolán McNamara  <caolanm@redhat.com>  [cf2a7501fa1848fdccd9717f52f18d0f44db458b]

        Resolves: tdf#114790 add align and vertalign to currencyfield im/export
        
        Change-Id: Idef9a94aeefb295cd349ed0216d08bc8e2faf079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Julien Nabet  <serval2412@yahoo.fr>  [569fb42dab88cc9e1a392271a34879afa9d7cc5b]

        tdf#82087: hyphenation: allow 1 character at line end for Greek
        
        Greek and Ancient Greek allow hyphenation after the first letter,
        e.g. ό-νειρο. The default "Characters at line end" value is still 2
        in Paragraph Styles->Text Flow, but now it's possible to set 1, too.
        
        Change-Id: If1e197a57dc32f8359e6b813d8fbe429e41cf5fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137583
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-07  Rene Engelhard  <rene@rene-engelhard.de>  [47cd7055ba076275dbe6d8d502dd00feae82ad50]

        add libebook-1.2.so.21
        
        comparing the Debian packages of 3.44.1 and 3.45.2 the actual headers
        didn't change, so no code changes needed afaics
        
        Change-Id: Ifae6395831ca538bb1699a7f2ba4cb504e552baa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137918
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Caolán McNamara  <caolanm@redhat.com>  [6e2bd11251afbe64f9889ede36b28b00f47aaff5]

        tdf#150291 Revert "Fix crash when no valid EntryDescriptor found"
        
        This reverts commit 499ecbf3a36990c29dc7e1fb9b0ecb1d297c2848 because
        it causes the dialog not to start with the default selected macro
        auto-expanded like it used to. Possibly the other fix for tdf#150291
        solves the original problem.
        
        Change-Id: Ic91410de073fe87d4edebde18b60ffcc1ad324a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137923
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Caolán McNamara  <caolanm@redhat.com>  [42a32f375a2641e6e82ee685efa3573c0dcaf001]

        tdf#150291 crash on macro organizer with no macro selected
        
        Change-Id: Ib7e05f4e3e1c63bc0bd497b590256c4ee77a0bf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137922
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b112c8f8843613873181fce50990a8feef837ca]

        clang-tidy modernize-pass-by-value in sc
        
        Change-Id: Ia7ff651d1cbc119b36a9f8052594d03650988f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137848
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [799753cb80f4c81a6e87bf016924e0f2a29f03f0]

        make SwNodeIndex constructors explicit
        
        which flushes out some more places where we were implicitly
        construcing SwNodeIndex temporaries
        
        Change-Id: If044cb54acd1fe1265837c8076d7fdfe4de49290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137910
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Caolán McNamara  <caolanm@redhat.com>  [6f954f50266f671f9fba25006131f635b00b6e22]

        crashtesting: null date assert seen on loading forum-fr-25994.ods
        
        presumably part of this problem is since:
        
        commit 22c7da0ca5438b69165609db2a1ef219aa167dc2
        Date:   Wed Mar 19 04:50:20 2014 +0100
        
            the type in the Any is a util::Date and not a DateTime, fdo#74549
        
        and we also have...
        
            rOutProperties.emplace_back( "NullDate",
                          PROP_DOCUMENT_NULL_DATE,
                          ::cppu::UnoType<css::util::DateTime>::get(),
                          beans::PropertyAttribute::MAYBEVOID );
        
        which has DateTime and not Date, but we can get this set as either Date and
        DateTime, so just accept both.
        
        Change-Id: If77af5bb74755d2196527112665facf27a4d1403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137911
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [2808c8a0941f0fc7ab8db4a109cb8dfa0d7c41f1]

        return by const&
        
        Change-Id: I9c364d53c9020e46a719af1868c14353d0ede67b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137917
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [110cc21fe2d59ad76a28b56f029421c0f9672073]

        make SetGetExpField take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: If92c2b660d7e3333345c3bdd3bd5f4cba43d6659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137909
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [c186b552d2b4d9c21f064c77a4d28b9f9abf0667]

        make UpdateFootnote take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I118c684c30f5f1be5037db09c8f7377cc738d219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [e201a54ce653ba51863289a73af471634a75b218]

        make ParkCursor take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I5fde455225b5571bca7f461898146800837fa4cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137907
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [aad60d4a5b584e08e01c35eeace6434b83199989]

        make RestoreSection take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I7ba9a9ef81c78445328f3397f352e103e997cde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Noel Grandin  <noelgrandin@gmail.com>  [0c2933d0a3ebd6074b89369df653538511363abb]

        make IsInHeaderFooter take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic9e7e3fd121a86d8b84536157b6d6b204627f758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b8b9ad9ade866175d8d7f1b68a465060901efee9]

        Removed duplicated includes
        
        Change-Id: Ic981e0916c68181cab7081091303d18c54912377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-07  Hannah Meeks  <hmeeks4135@gmail.com>  [30759b5ce2ef4f915a6f4ba50ce25b602162805c]

        VBA conversions inches should be in
        
        Change-Id: I130925d9501f8cb4f3f2a8a0894bbf6824cd2eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137856
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [641d92a73e5b3d0e062e16ed4b42236e1a4796a5]

        ofz#49834 Segv on unknown address
        
        regression from
        
        commit 96fb8f88bd56c113eb23e50d23a038509703c288
        Date:   Wed Aug 3 15:47:51 2022 +0200
        
            elide some SwNodeIndex temporaries
        
        where the SwPam ctor a ended up getting called instead of b
        
        a) SwPaM( const SwNode& rNode, sal_Int32 nContent, SwPaM* pRing )
        b) SwPaM( const SwNode& rNd, SwNodeOffset nNdOffset, sal_Int32 nContent = 0, SwPaM* pRing = nullptr );
        
        Change-Id: I44e9f98bcbefa72301dc9a434ce5ebe720870cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137902
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a590bfe0427ed91fb20f037783ca0335f67cf6c]

        make MakeTextSection take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Ia64ddd3e1f34c7c160af0134ef5526faf43108e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137895
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Eike Rathke  <erack@redhat.com>  [d778c6fd5c2ba8e27df46ec9e183a61ad29e30d5]

        Resolves: tdf#135993 Create ScFunctionList and ScFuncDesc with English names
        
        Used in Function Wizard and formula tooltips. Without, no matching
        name is found for AddIn English name and no
        tooltip/description/arguments are displayed.
        
        Change-Id: Ib0cf419c476dae495467c444f1ee1f84a55633a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137883
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-06  Eike Rathke  <erack@redhat.com>  [0a78f11fdd13d914d5f063007b2df9796e6dce9d]

        Related: tdf#135993 Use ScCompiler to create English OpCodeMap with AddIns
        
        ... instead of formula::FormulaCompiler base class that doesn't
        know anything about AddIns, and copy AddIns along to new resulting
        native map.
        
        Change-Id: I9e4ece2f7450a561ac502ca1dbddaa5a697fa2fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137882
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [f1f6c82e613ace836aa78a822688721fb7fb5e80]

        tdf#150235: use correct types in XMLTextColumnsExport
        
        The types for the properties are defined in css::text::TextColumns
        servise. But before commit 95ebd24a629b4c8cd62cc20c0701683512cc8fa0
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Thu May 27 13:00:10 2021 +0300
            editengine-columns: ODF support [API CHANGE]
        
        the implementation of the service (SwXTextColumns) used smaller types
        for some properties. The export code (XMLTextColumnsExport::exportXML)
        mathced those implementation types.
        
        The mentioned commit changed the implementation to use proper types;
        but the export code wasn't corrected.
        
        This fixes the export code.
        
        Change-Id: I95838dec382edc61bb2e5b39177bf57a7d79e0bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137900
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [abb3c857bd7f00826e891859f08071f7e112841c]

        crashtesting: keep a reference to the passed in LibXSLTTransformer
        
        otherwise, as seen with:
        soffice --headless --convert-to docx forum-mso-de-42789.docx
        
        and error will notify the other thread that the load has ended and the
        other thread will destroy the passed in LibXSLTTransformer early while
        this thread assumes it continues to exist
        
        Change-Id: Ieea9ecc3439ea73cd0433e5e12b87811906c49aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137901
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Julien Nabet  <serval2412@yahoo.fr>  [407a61943539063c6d56eab8ab0c1b728dd642af]

        tdf#150232: put Intel Iris driver Skia/Vulkan in denylist for all versions
        
        + Nvidia on Windows just for device id "0x1401" in order to not being too restrictive.
        
        Change-Id: Ie2cb2c6c6bb50ac6080721230ca3e451e886bb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137768
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [b2cdf8a1eac730f74160d7c7a1ab9ec907dddd23]

        the "CreateWindow" function in svtools is newly removed
        
        Change-Id: I6fb569cf293a896c92bec4c6aae647a0bd02d012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [de5135060d01b650b7258c02e847e916ae9541fd]

        cid#1507764 Unintended comparison to logical negation
        
        missing - from ->
        
        Change-Id: Ieca42cf3fd3e1c10186ba57dd422f3e4ddf9e20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [71ce0e354437db3086d6d746b0e9edbc693ddcca]

        make SeekEntry take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Id43211f221f3b90c46629bedec25f9078c7bf9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [a95bf932ed22abbb346b1d70e3c32578074667f3]

        turn on -Wshadow-all for clang compilers
        
        mostly so that it matches the existing behaviour of the GCC compiler,
        which makes it easier submitting patches when building locally with
        clang
        
        Change-Id: I0197ec61bc97a3899c2b379efa0f2ad8ed028986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Hannah Meeks  <hmeeks4135@gmail.com>  [5fecf10b9ef6e76aa1d06b7ab350abb5a495dda0]

        VBA Add conversion methods to global
        
        Change-Id: I920799321f245c015a527c816272c1038cc04544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137851
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [4d96e375c28f9fe2dded40cba4ee8c67f77817f3]

        move SVTXGridControl to toolkit
        
        Change-Id: I513a2885027d0295f70e7c64269d1653a6c2642b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [488b69db9844e40fb432b847a271a92fd9e7414a]

        ScDataTableView has visible grid in the rectangle at the scrollbar junction
        
        so over paint it with the face color, and replace the unusual use of
        ScrollBarBox as painter for topleft corner with same
        
        Change-Id: I922541122d725a2feeee0db6a1078b953da3156d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137878
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [6d9ee6444d07bac64b9744b1c9fc7a2519e62965]

        tdf#117388 use native scrollbar under gtk in calc data view browser
        
        Change-Id: Ia0ab035473da7b5b64e18876bb81e25fd63effda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [800551502416d3d80c8d14a53335dad5190290a4]

        tdf#117388 use native scrollbar under gtk in reportdesigner
        
        Change-Id: If7a66055dbae6d8ee31768ff438eb8105b8f980f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137880
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [59a2650101a0ce711151bfd39af1bbb69f71f318]

        tdf#117388 use native scrollbar under gtk in database scrolled window
        
        Change-Id: I84486f8c8761b80fc45cdccc620485b67afdd048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [528941a3fd01465e638cea86801cf454cc61f807]

        Revert "align horz scrollbar to top if assigned more space than it wants"
        
        This reverts commit 106bc0fd7a94eb48e8a81be753c156496b83578a.
        
        it has an unusual effect in writer on hiding and reshowing scrollbars
        
        Change-Id: I0569bf3ddb9b04f1afc6c26add84086bdf4ff5fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137886
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Caolán McNamara  <caolanm@redhat.com>  [bd13bd144cfa00a52a056a95167c8510c84a0e40]

        ofz#49832 Integer-overflow
        
        Change-Id: I35efe0b78546b4804206f78159b2fc18172ca4f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137885
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [ed4ffba1c180c74e3b9c3aadc279ff92bda8ab5a]

        Drop some conversion from vbahelper; use usual functions where needed
        
        Change-Id: I71bea54f095072a0e403bfc7aa48a0f0f9a0ebaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137891
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-06  Noel Grandin  <noelgrandin@gmail.com>  [36333de160c88a3190d799c031b16e1ef6bcaa86]

        no need to allocate on heap here
        
        Change-Id: I889690c136f200cffd0398254ec9935e2027a32c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137893
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Eike Rathke  <erack@redhat.com>  [28c4c72a4e81821d9e567757725937f74a6d114f]

        Related: tdf#135993 Destroy temporary OpCodeMap when reading config
        
        Initialized at FormulaCompiler base class instance it lacks AddIn
        mapping and a still existing OpCodeMap prevents necessary
        reinitialization from derived ScCompiler instance later.
        
        Change-Id: I0c2db41dd45829abfb8460730264f097ab76ab2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137881
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7fba323df141be9eddbce39bec0c0f7ee412a7f7]

        make CheckNodesRange take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: If8e9426df4b78ebf95bbac54ebfdcff4b19b6292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137874
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1340083a8a22df3d834ba252e7947a50afc439e]

        make GetFirstAndLastNode take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Ic26ed0fef1d7394ed2673b5949718fe8099b3d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [59b8813606f084d62dbd3debed7f6b468d916459]

        make GetParaPropsNode take a SwNode, not an SwNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: Idefc1cd390c551bf7b54ee122c7fc7e4feb8f45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a444884c3b221c9bd7b0aa4476c160921c7fc35]

        tdf#150222 reporbuilder, set font for a text box crashes
        
        regression from
            commit c4cf2e82e8d0aaef9b1daedc033d6edf647e5284
            Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
            Date:   Mon Jun 13 08:53:22 2022 +0200
            tdf#128150 Add OOXML import/export for "use background fill"
        
        which modified XATTR_FILL_LAST.
        
        Ideally, I would just adjust the ranges for the pool, but I can't do
        that because we are using static defaults, and the range for static
        defaults has to be contiguous.
        
        Also update the aItemInfos array to avoid a DBG_UTIL check that
        complains about mapping a SID to itself
        
        Change-Id: Ie76bdc83fa0a0ad07b6b2afdb678193889373cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137867
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-06  Jim Raykowski  <raykowj@gmail.com>  [a9d225df2f8772e21435523ca20df1ece37390e4]

        tdf#148240 follow up: Make Outline-Folding non-experimental
        
        Change-Id: I147591c8088b1fad0575b2efe46f862573147fe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137774
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-06  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [7716a43e76fe26ba31393b31cfa967f5fcb6e747]

        Make parallelism configurable for BZ attachment fetchers
        
        Both forum and BZ document fetchers use a hardcoded size for their
        threadpools. Use the habitual env var PARALLELISM to override that
        optionally.
        
        Change-Id: I374a33ab0cfe481e0940a1f4d5d9a53ae647f135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137888
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-06  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [00014558d615c7004e133e2a2cb535d07f4691a2]

        Disable abisource from BZ attachment fetcher
        
        Expired TLS cert since a while, worth checking if it comes back.
        
        Change-Id: I4bd98d847ede6ac25d6d4a3361d7365396ad40fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137887
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [bbf8673da5a7f1154111776378edb158707c80db]

        tdf#117388 use native scrollbar under gtk in data browser
        
        Change-Id: I22745f1c910f68fd2c0b31e8392c111fc76ef529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [805e2a18b0da06ab01cb4d516d6ceda44c358507]

        resave with latest glade
        
        Change-Id: I0454f8285e819c0a0b320c0652db8e6042a07999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137876
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [1ec21c7f2ab80ce518acec2f44017649abae5974]

        Use 1 meter, not 10 meters divided by 10
        
        Change-Id: I035bd25509db608d2273949cecd438d412e5a4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137816
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [56145f237b63a35c142dbccd434fd780badcf489]

        wina11y: Drop unused AccessibleKey{Binding,Stroke}.idl
        
        The only include of the generated header file
        `AccessibleKeyBinding.h` was in `AccActionBase.cxx`,
        but that doesn't make any use of what's defined in
        the header, so just drop the include and the unused
        IDL files altogether. (The IDL files are part of the
        winaccessibility-specific UAccCOMIDL, unrelated to
        the IDL files for the UNO API.)
        
        `CMAccessible::get_accKeyboardShortcut` directly operates
        on the `XAccessibleKeyBinding` UNO interface ever since
        
            commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
            Date:   Thu Nov 14 08:18:05 2013 +0000
        
                Integrate branch of IAccessible2
        
                Just the winaccessibility directory initially.
        
        (the commit also adding those 2 IDL files), so it's
        unclear to me what might have been the intended use.
        
        Change-Id: I1a08e8ea789ca92e52640a0006f20fac219f6733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137866
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [245f39eb1279455f5af0e2329cf9617c79b6e240]

        wina11y: Drop unused Charset.idl
        
        This is one of the LO- and winaccessibility-specific
        (i.e. not part of the UNO API and not from upstream
        IAccessible2) IDL files and it's unused, so drop it.
        
        Change-Id: I8802934da174dda3c8b35c39c2196a0ac14a7c1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137865
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [07d8563785d26bfab30ae26ced94e6e9826ae002]

        align horz scrollbar to top if assigned more space than it wants
        
        as is currently the case for the databrowser scrollbar, and do the
        same to the vert for consistency
        
        Change-Id: Icf8694f172c3121f35f612a47faa2e2caef890c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [5ae01ffa70549b1a4d9f166d0528a8d04a5dc858]

        tdf#117388 use native scrollbar under gtk in basic editor
        
        Change-Id: Id8f2b4fdc40116bb28053dc6fbbf6fa86e6808fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137862
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [f5109c38e2d5bd608fc6b94fde75e73d70e0c4f7]

        wina11y: Fix indentation of this line
        
        Change-Id: I5b2344c90315aec974e27bba5e3a44e201ffc283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137860
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [9398654642fc7cd511c637730365043db87e7cf6]

        wina11y: Drop unused AccChildNode struct from defines.idl
        
        Change-Id: Ia725d6655512632b78abfa4f3791406724ca29ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137859
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [f03b908e285ad65fa4518f26862454c51efb54a8]

        wina11y: Drop extra location bookkeeping
        
        The location is already retrieved on demand from the
        underlying `XAccessible` in `CMAccessible::accLocation`
        and the separately remembered location was just used
        as fallback in case `m_xAccessible` was not (no more)
        set.
        However, when there is no valid associated `XAccessible`,
        there is probably no value in returning any location
        anyway, so just return `S_FALSE` for that case, as
        other `CMAccessible` methods also do.
        
        Whether the separately remembered `m_sLocation`
        was up to date is also questionable, s.a.
        Change-Id I04d0230d3599466aaa92082caba54da22a3b1a28,
        "wina11y: Drop AccObjectManagerAgent::UpdateLocation".
        
        This is also in line with what's mentioned in
        
            commit fcf4a26275d7503835f9aa23cb94938809840300
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jan 5 13:41:53 2022 +0000
            tdf#146306 wina11y: Retrieve accessible desc on demand
        
        > Querying up-to-date values from the underlying
        > UNO interfaces on demand instead of doing extra
        > manual bookkeeping in the winaccessibility code
        > may be possible for more a11y attributes in addition
        > to the accessible description handled in this commit,
        > but each one will have to be looked at separately.
        
        Change-Id: I2fc51939a5db1896e02efacb1cf5fbc90ce87c04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137858
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [0c3a159807965fa7db548a943a8d67d8bad5b208]

        wina11y: Drop AccObjectManagerAgent::UpdateLocation
        
        That static method doesn't do anything.
        
        `_IMPL_WIN` is not defined, so the
        
            #ifdef _IMPL_WIN
               if( pWinManager )
                   pWinManager->SetLocation( pXAcc, top, left, width, height );
            #endif
        
        in the method is unused.
        
        Since `CMAccessible::accLocation` already retrieves the
        current location from the underlying `XAccessible` on demand,
        I don't see a need to update the location manually
        in the first place, so there should be no need to enable that,
        code, just drop it.
        
        Also drop `AccObjectWinManager::SetLocation` which was
        unused since `AccObjectManagerAgent::UpdateLocation`
        (s. above) would have been the only call site.
        
        Change-Id: I04d0230d3599466aaa92082caba54da22a3b1a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137857
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Heiko Tietze  <tietze.heiko@gmail.com>  [a9c8ac0605fd1d19e1d79b54804b610a64a8a056]

        Resolves tdf#114508: Individual selection in recovery dialog
        
        Based on work by Danie Truter at I397119a6e50c256e87e3a484a6c17a252f191981
        
        Change-Id: I75fd321cbfeb7a92bd14e94b0c1ae0bb25be73cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136845
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [057c60192aa34ae42f9f8abc2cb0ec93caa79130]

        clang-tidy modernize-pass-by-value in starmath
        
        Change-Id: Ib6bd1ed629980d4ff122114bc45396886c94ab78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [6819707cbc8e7257a694623a6331c3c6f965fa94]

        tdf#117388 use native scrollbar under gtk in calc print preview
        
        This changes the scrolling to happen immediately during scrolling and
        not when the user releases the scrollbar at the end.
        
        Change-Id: Id8fdb8205964416ad25a99e2c71b061cabee8388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137853
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [cbef9c333bc6b41d9d0cd8d0d7142c7606ea1226]

        tdf#117388 use native scrollbar under gtk in writer's html source view
        
        Change-Id: I233745165140ff47d9bb462ad2248fdb8d9dd3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [da9b11a50ac33c70324fe007aa03ca01531abeb3]

        Use o3tl::convert in VbaApplicationBase::CentimetersToPoints
        
        Note that the old conversion was incorrect; it likely followed
        MS documentation [1], which is inaccurate: running in Word
        
          MsgBox CentimetersToPoints(1.0)
        
        gives 28.34646 (expected given the 1 in = 72 pt definition).
        
        [1] https://docs.microsoft.com/en-us/office/vba/api/word.application.centimeterstopoints
        
        Change-Id: I4eefccc4bd17958f944f364bc3ea579a8fdbd703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137855
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [063d7fda7e3942706ca8818abe7f2758a7991b92]

        introduce GoNextSection(SwPosition... and similar
        
        as part of the process of hiding the internals of SwPosition
        
        No functional change intended
        
        Change-Id: Ia34d7f19685308ff2b9bddcfc40f9d13df348b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137849
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [8a4271e168f70f9147b567189c1770a243e7fcb1]

        wina11y: Implement IAccessibleTableCell::get{column,row}HeaderCells
        
        This is essentially the Windows version of
        
            commit 12f96c3d0f61018cfa83c940765311aa9015f60a
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Aug 4 13:27:32 2022 +0200
        
                qt a11y: implement QtAccessibleWidget::{row,column}HeaderCells
        
        Tested using NVDA's Python Console as follows:
        
        1) start LO Writer, "Table" -> "Insert Table"
        2) select to create table with  2 rows, 2 columns
        3) make sure "Heading" is checked, "Heading rows": 1
        4) "Insert"
        5) in the first row, type "First heading" into first column,
           "Second heading" into second column
        5) start NVDA
        6) move cursor to the table cell in second row first column
           (i.e. the cell below "Heading 1")
        7) press KP_Insert+Ctrl+Z to start NVDA's Python console
        8) Use NVDA's Python console to call corresponding IAccessible2
            methods and check the result:
        
            >>> from IAccessibleHandler import IA2
            >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell)
            >>> cell.columnHeaderCells
            (<comtypes.LP_POINTER(IUnknown) object at 0x010528A0>, 2)
            >>> header_cell = cell.columnHeaderCells[0].contents
            >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).columnIndex
            0
            >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).rowIndex
            0
        
        9) Repeat steps 6-8, but now with the cursor in cell in
           second row, second column (i.e. the cell below "Heading 2") instead,
           which correctly returns the cell with row index 0 and column index 1 as header cell:
        
            >>> from IAccessibleHandler import IA2
            >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell)
            >>> cell.columnHeaderCells
            (<comtypes.LP_POINTER(IUnknown) object at 0x01024B70>, 2)
            >>> header_cell = cell.columnHeaderCells[0].contents
            >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).columnIndex
            1
            >>> header_cell.QueryInterface(IA2.IAccessibleTableCell).rowIndex
            0
        
        Without this commit, this would fail like this:
        
            >>> from IAccessibleHandler import IA2
            >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell)
            >>> cell.columnHeaderCells
            Traceback (most recent call last):
              File "<console>", line 1, in <module>
              File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__
            _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None))
        
        Change-Id: I8de495ad28b2bece971fe4462e539bcc242ed440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [a3ddcc9247351324e410f240e1599eaabb5bde5d]

        wina11y: Implement IAccessibleTableCell::get_table
        
        Tested using NVDA's Python Console as follows:
        
        1) start LO Writer, "Table" -> "Insert Table"
        2) select to create table with  2 rows, 2 columns
        3) make sure "Heading" is checked, "Heading rows": 1
        4) "Insert"
        5) in the first row, type "First heading" into first column, "Second heading" into second column
        5) start NVDA
        6) make sure cursor is in the first table cell ("Heading 1")
        7) press KP_Insert+Ctrl+Z to start NVDA's Python console
        8) Use NVDA's Python console to call the corresponding IAccessible2
           methods and check the result:
        
            >>> from IAccessibleHandler import IA2
            >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell)
            >>> cell.table
            <POINTER(IUnknown) ptr=0x7cc5b24 at 13f3850>
            >>> cell.table.QueryInterface(IA2.IAccessibleTable)
            <POINTER(IAccessibleTable) ptr=0x378d47c at 13f38f0>
            >>> cell.table.QueryInterface(IA2.IAccessibleTable).nRows
            2
            >>> cell.table.QueryInterface(IA2.IAccessibleTable).nColumns
            2
        
        Without this commit in place, this would fail as follows:
        
            >>> from IAccessibleHandler import IA2
            >>> cell = focus.parent.IAccessibleObject.QueryInterface(IA2.IAccessibleTableCell)
            >>> cell.table
            Traceback (most recent call last):
              File "<console>", line 1, in <module>
              File "monkeyPatches\comtypesMonkeyPatches.pyc", line 32, in __call__
            _ctypes.COMError: (-2147467259, 'Unspecified error', (None, None, None, 0, None))
        
        Change-Id: I67b84f1fd9d397a3aa40b5336c3baafad35eec29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137846
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Michael Weghorn  <m.weghorn@posteo.de>  [c48742e5d13fd9c8edddcf5198344e9eba651fbf]

        wina11y: Implement IAccessibleTableCell:get_rowColumnExtents
        
        The doc says [1]:
        
        > Gets the row and column indexes and extents of this cell accessible and
        > whether or not it is selected.
        >
        > This is a convenience function. It is not mandatory to implement it.
        
        Just use the existing methods to retrieve the information.
        
        [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_table_cell.html#a686348f0b7ecae19d4be5d7ef37ff201
        
        Change-Id: If009c3913e6e837317255266251bd7696d423118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137845
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [f5156b9e452a81e2daa4ecc67b5533c6911f77ec]

        tdf#117388 use native scrollbar under gtk in impress/draw documents
        
        Change-Id: I5dbcc14af083584fe4b73ecd4e4bf4187fb9af39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137836
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [9788bdc8c821becf54fda989d66fcba72f218ee5]

        start with size at optimal size
        
        Change-Id: Ibd5f009c4717ce236334e5fc407512a5ef8c2a70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137844
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [5da14ddc04325d25886b9d17aa5ca424c4e1bdfe]

        drop unnecessary nDelta of 0 optimization
        
        Change-Id: Idce5a4272314785382fbb7acf078ddb84ff61ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Hannah Meeks  <hmeeks4135@gmail.com>  [c9b57b7226de7062b9feaf7706825f6dc2a6fee8]

        VBA Add conversion methods to Application
        
        Change-Id: Ic0de06699a647565deca7985742965a72614df16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137787
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-08-05  Hannah Meeks  <hmeeks4135@gmail.com>  [f3234f4f14702da71528561418f07ee6670a8c2a]

        VBA Add Padding properties to XTable
        
        Change-Id: I021ad15b81ce55c4f9e9e9b515be1ddaaca8d07d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137630
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-08-05  Mike Kaganski  <mike.kaganski@collabora.com>  [563e95965c1e377db8f24066627919654e21494c]

        SwModelTestBase: helper methods to reduce copypaste
        
        Change-Id: I102bf95e68b628ed6a6d624e8f5d3e8b8d10cd84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137841
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-05  Michael Stahl  <michael.stahl@allotropia.de>  [27f9495891d86a21f18d7ef5455829f9163e5942]

        sw: rename to unique name SwFrameFormat::SetFormatName()
        
        Change-Id: I3058a3ade6bdedf0575c10783a4811d7768ac183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137812
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [7b20a1b0736825c9c934288428e6e581f79971e2]

        tdf#117388 use native scrollbar under gtk in calc document
        
        Change-Id: I436067b4f2b463fe9a5d6789cf96f906891757bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137810
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [8c4e8818fe9f5ac1f6cdf908299cc109d67f1e50]

        nDelta overwritten on all branches except default
        
        which claims to only exist to avoid a compiler warning. So drop
        GetDelta() call and fold the default into the Drag case instead
        
        Change-Id: I978bb38ccff34687bb70453abe416a9c73228655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137808
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Caolán McNamara  <caolanm@redhat.com>  [ae354652c8b0247a05ad0d8bb1551fdafd451e53]

        using ScrollType::Drag looks the safest choice
        
        rather than DontKnow, Drag assumptions seem to fit best
        
        Change-Id: Iae92b29d33e69410c67b43fabb933018f1277abf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137809
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Khaled Hosny  <khaled@aliftype.com>  [b7c1f13eca14836ce3427afb79cae1101661461c]

        vcl: Add a configure option to set VCL_FLOAT_DEVICE_PIXEL
        
        Disabled by default. It might improve sub-pixel glyph positioning a bit,
        though it is only used inside VCL and the API boundary is still
        sal_Int32, sound rounding to full pixels still happens at some point.
        
        Change-Id: I702f9a521e5b556d198756d6cdbb455ebaffbab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137664
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [f705132f20eb9e0cbe57f11f1f9594a287a63900]

        tdf#150219 Crash when cutting trace dependent with precedent on different sheet
        
        not sure exactly where the real bug is. This only started to show up
        when I changed the data structures in
        
            commit 3596c9891e16e1222208b18bdcdc9909c2f02d0f
            Date:   Thu Jan 16 12:10:54 2020 +0200
            use std::vector in ScMarkArray, instead of re-inventing the wheel
        
        before that it would harmlessly read from adjacent memory because nCol and
        nRow are -1.
        
        Change-Id: Iddf109eed04ddc57d5b6743f232eea940e42bd9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137834
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [94cda7386e06d75d26fd997db36981731f49e081]

        make GoStartDoc always set SwPosition::nContent
        
        as part of the process of hiding the internals of SwPosition
        
        by using the new
           SwNodes::GoNext(SwPosition*)
        function.
        
        GoStartDoc is only called from GoInDoc
        
        Change-Id: Ifb780883494e94eb9b445246733bd6fe80423d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e95bb3c1074bca7460977fe962a1042a2aef415d]

        introduce SwNodes::GoNext(SwPosition*) and similar GoPrevious
        
        as part of the process of hiding the internals of SwPosition
        
        These are still the easy ones, i.e. no functional change intended
        
        Change-Id: Ic1128d9e31fb87c015e1e9e66f5c365b3c2ebdca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [8dd67096d9472aaf46c9db59921b65d92f8c3827]

        use more SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        these are still the easy ones, i.e. no functional change intended
        
        Change-Id: Ibb2adf17de47bab5374730b508d9c020991a945e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-05  Stephan Bergmann  <sbergman@redhat.com>  [fa5ba20b953da85ad387449cf613d7be59c3d5c2]

        Fix typo
        
        ...introduced in f59136a2ed1e3eb01cc5b62c5a7da07c34cbdfae "tdf#91794 remove
        OSL_DEBUG_LEVEL > 1 conditionals"
        
        Change-Id: I4ead69b3fac4ab51602c3cbd25c8481e749a3e75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137835
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Eike Rathke  <erack@redhat.com>  [a56d0c34716f381accbd9d2e3040a62d3583d18d]

        Add known but not in AddInMap English names for GRAM_API, tdf#150253 follow-up
        
        Change-Id: I1edc2a979946078e4548c0933f9b64b7a08a7e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137773
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [3cf7b358799dfde4da1df3f0b9d6cf726d22a22b]

        qt a11y: Implement QtAccessibleWidget::offsetAtPoint
        
        Since `QAccessibleTextInterface::offsetAtPoint`
        uses screen coordinates, but
        `XAccessibleText::getIndexAtPoint` takes
        local coordinates (i.e. position within the object
        itself), convert that first.
        
        Tested as follows:
        
        1) start new document in Writer
        2) paste this text into the first paragraph:
           "Hello world, this is some test text. Lorem ipsum."
        3) start Accerciser
        4) select the paragraph in Accerciser's tree view of the
           LO a11y hierarchy.
        5) use Accerciser's IPython console to check the results
           returned by calling the corresponding AT-SPI methods:
        
            In [69]: acc.queryText().getOffsetAtPoint(acc.get_position(pyatspi.component.XY_SCREEN).x + 200,  acc.get_position(pyatspi.component.XY_SCREEN).y + 5, pyatspi.component.XY_SCREEN)
            Out[69]: 20
            In [70]: acc.queryText().getOffsetAtPoint(acc.get_position(pyatspi.component.XY_SCREEN).x + 250,  acc.get_position(pyatspi.component.XY_SCREEN).y + 5, pyatspi.component.XY_SCREEN)
            Out[70]: 27
            In [71]: acc.queryText().getOffsetAtPoint(acc.get_position(pyatspi.component.XY_SCREEN).x + 300,  acc.get_position(pyatspi.component.XY_SCREEN).y + 5, pyatspi.component.XY_SCREEN)
            Out[71]: 37
        
        With this change and the Qt changes mentioned in
        
            commit 35be93f83ac866ef18f0e06853c9818cd1d1bd56
            Date:   Wed Aug 3 09:18:46 2022 +0200
        
                qt a11y: Implement QtAccessibleWidget::characterRect
        
        , the results with the qt6 VCL plugin are the same as with
        the gtk3 one.
        
        Change-Id: Ie75fa9b7a64c413251c771f0379d9f3a3b200c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137795
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [56139f43ee6ca1ba255410b6d2b5f7e1db6b6ef2]

        tdf#150265: properly handle empty rectangle in SwView::CalcVisArea
        
        Use PixelToLogic taking Rectangle for this job, that does everything
        required in this case.
        
        Before commit 9426e90c2c339b16487c48cd885a3e4586e1e1f3
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Thu Jul 21 09:29:32 2022 +0200
            Cleanup restoring last position
        
        headless import always returned early from SwView::ReadUserDataSequence, because
        either !bGotVisibleBottom, or nBottom > (m_pWrtShell->GetDocSize().Height()+nAdd)
        was true. Thus, SetZoom wasn't called, and SwView::CalcVisArea wasn't called from
        it.
        
        After the change, in SetZoom, the empty rectangle created from passed zero Size
        got converted from pixels to logic, using transformation loosing its empty state.
        That resulted in some non-empty VisArea, and later in DOCX export of the table,
        WW8TableInfo::processSwTableByLayout got garbage from aTableCellInfo.getRect.
        
        Using proper Window::PixelToLogic overload allows to simplify and fix it all.
        
        Change-Id: Ib5e6d5bda10bf0f8dcb93ff6a46ca6cb81ff5a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137807
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-04  Caolán McNamara  <caolanm@redhat.com>  [4bc62c4e9b5b4eab6e2e40577789c435dce59f66]

        split SwScrollbar up for reuse of adaptor
        
        Change-Id: Idf46b209c573316e810371597acb1567536d9529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137806
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [20a5e0feaf22804de8c55d1471fd076e40cd2ce6]

        MvSection functions should maintain the SwPosition::nContent field
        
        i.e. when it moves the SwPosition::nIndex, it should move the
        SwPosition::nContent too.
        
        Change-Id: I96bee46766ebb303f97790aeb09024380b1cdc35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [6cb9d45c43b525a682a5f8826f93e3981703cf4f]

        a11y: Add missing "not" in XAccessibleText::getTextBehindIndex doc
        
        The doc was contradicting itself, saying (emphasis added):
        
        > Returns the substring of the specified text type that is
        > located after the given character and DOES NOT INCLUDE IT.
        
        and
        
        > For example, if text type is
        > AccessibleTextType::WORD, then the complete word
        > that is closest to and LOCATED BEHIND nIndex is returned.
        
        but also
        
        > The index character WILL BE PART of the returned string.
        
        Add the missing "not" to the latter to make this
        consistent and match the observed behavior when testing
        this with a Writer paragraph consisting of the characters
        "abcdefg":
        
        Calling `getTextBehindIndex(2, css::accessibility::AccessibleTextType::CHARACTER)`
        on the corresponding a11y object's `XAccessibleText` interface  returns
        a TextSegment with
        
        * "d" as text
        * a start offset of 3
        * an end offset of 4
        
        This is also consistent with `XAccessibleText::getTextBeforeIndex`,
        whose documentation is similar and includes the "not"
        at the corresponding place. Calling
        `getTextBeforeIndex(2, css::accessibility::AccessibleTextType::CHARACTER)`
        returns a TextSegment with
        
        * "b" as text
        * a start offset of 1
        * an end offset of 2
        
        The commit message of the commit adding this suggests that the
        semantics were changed at some point, maybe the doc just wasn't
        updated to reflect this at this one place back then.
        
            commit 161503a286e6f7e1be49f84d9ad6a6287bac486e
            Date:   Thu Apr 24 16:36:13 2003 +0000
        
                INTEGRATION: CWS uaa02 (1.1.2); FILE ADDED
                2003/04/08 11:43:30 af 1.1.2.6: #108113# Made validity of index 'length' implementation dependent for getCharacterBounds().
                2003/04/08 10:04:41 af 1.1.2.5: #108113# Added a sequence of requested attributes to getCharacterAttributes().
                2003/04/04 14:37:30 af 1.1.2.4: #i12332# Made position <length> a valid character for method getCharacterBounds().
        ->      2003/03/18 15:59:07 af 1.1.2.3: #108113# Changed the semantics of getText{Before,At,After}Index().
                2003/03/14 10:40:54 af 1.1.2.2: #108113# Removed references to the drafts directory.
                2003/03/11 15:00:42 af 1.1.2.1: #108113# Moved from drafts/com/sun/star/accessibility.
        
        Change-Id: I4a3e73829f03c79977cef7542ff59603ea10c6dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137800
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [12f96c3d0f61018cfa83c940765311aa9015f60a]

        qt a11y: implement QtAccessibleWidget::{row,column}HeaderCells
        
        Implement these methods inherited from
        `QAccessibleTableCellInterface` by retrieving all
        row/column headers from the table (= cell's parent object) and
        only returning those for the row/column that the cell itself is
        in.
        
        Tested with Accerciser and the qt6 VCL plugin as follows:
        
        1) start LO Writer, "Table" -> "Insert Table"
        2) select to create table with  2 rows, 2 columns
        3) make sure "Heading" is checked, "Heading rows": 1
        4) "Insert"
        5) in the first row, type "First heading" into first column, "Second heading" into second column
        5) start Accerciser
        7) select the table element in Accerciser's treeview of the a11y
           hierarchy
        8) type these in Accerciser's IPython console:
        
            In [10]: acc.queryTable().getColumnHeader(0).name
            Out[10]: 'A1'
            In [11]: acc.queryTable().getColumnHeader(0).get_child_at_index(0).queryText().getText(0, -1)
            Out[11]: 'First heading'
            In [12]: acc.queryTable().getColumnHeader(1).name
            Out[12]: 'B1'
            In [13]: acc.queryTable().getColumnHeader(1).get_child_at_index(0).queryText().getText(0, -1)
            Out[13]: 'Second heading'
        
        Change-Id: I69b9bd10bfe4076de9e4a05fe4aff97d1bfa4118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137794
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [c03a262c477b73aa170c6a38703d0930486255e5]

        qt a11y: Implement QtAccessibleWidget::selectedCell{s,Count}
        
        Change-Id: I728456d27211916010c0174fa71b0125c7530707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137793
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Stephan Bergmann  <sbergman@redhat.com>  [2ba38d4f4147c3d07273e259559b2722bbe1d227]

        Prefer -lclang-cpp over hand-curated -lclang* list
        
        ad5cbcf6ba0afdc1d8d7405c2641cce8de4a360b "try to autodetect flags needed to
        build Clang plugins" had added both, in that order, first a check for a
        hand-curated list of individual -lclangTooling -lclangDriver -lclangFrontend ...
        libs, and only then a fallback check for the combined -lclang-cpp.  It did not
        give any rationale for that particular order.  But checking for the hand-curated
        list first turned out to have the following drawback:  My build against recent
        Clang 16 trunk succeeded the check for the hand-curated list but then failed
        during the build because the hand-curated list missed to include a new
        -lclangSupport dependency.  And my naive fix
        5078591de9a0e65ca560a4f1913e90dfe95f66bf "CLANGTOOLLIBS needs to include
        -lclangSupport now" caused further issues:
        
        For one, I had naively assumed that libclangSupport.a would be available on our
        compiler plugins Clang 12.0.1 baseline, not noticing that the corresponding
        Jenkins build
        <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/119581/> only
        succeeded with
        
        > checking for clang libraries to use... -lclang-cpp -L/home/tdf/lode/opt_private/clang-llvmorg-12.0.1/lib  -lLLVMWindowsManifest -lLLVMXRay -lLLVMLibDriver -lLLVMDlltoolDriver -lLLVMCoverage -lLLVMLineEditor -lLLVMX86Disassembler -lLLVMX86AsmParser -lLLVMX86CodeGen -lLLVMX86Desc -lLLVMX86Info -lLLVMOrcJIT -lLLVMMCJIT -lLLVMJITLink -lLLVMOrcTargetProcess -lLLVMOrcShared -lLLVMInterpreter -lLLVMExecutionEngine -lLLVMRuntimeDyld -lLLVMSymbolize -lLLVMDebugInfoPDB -lLLVMDebugInfoGSYM -lLLVMOption -lLLVMObjectYAML -lLLVMMCA -lLLVMMCDisassembler -lLLVMLTO -lLLVMPasses -lLLVMCFGuard -lLLVMCoroutines -lLLVMObjCARCOpts -lLLVMHelloNew -lLLVMipo -lLLVMVectorize -lLLVMLinker -lLLVMInstrumentation -lLLVMFrontendOpenMP -lLLVMFrontendOpenACC -lLLVMExtensions -lLLVMDWARFLinker -lLLVMGlobalISel -lLLVMMIRParser -lLLVMAsmPrinter -lLLVMDebugInfoDWARF -lLLVMSelectionDAG -lLLVMCodeGen -lLLVMIRReader -lLLVMAsmParser -lLLVMInterfaceStub -lLLVMFileCheck -lLLVMFuzzMutate -lLLVMTarget -lLLVMScalarOpts -lLLVMInstCombine -lLLVMAggressiveInstCombine -lLLVMTransformUtils -lLLVMBitWriter -lLLVMAnalysis -lLLVMProfileData -lLLVMObject -lLLVMTextAPI -lLLVMMCParser -lLLVMMC -lLLVMDebugInfoCodeView -lLLVMDebugInfoMSF -lLLVMBitReader -lLLVMCore -lLLVMRemarks -lLLVMBitstreamReader -lLLVMBinaryFormat -lLLVMTableGen -lLLVMSupport -lLLVMDemangle -lrt -ldl -lpthread -lm -lz -ltinfo -lxml2
        
        by silently falling back to -lclang-cpp after the check for the hand-curated
        list had apparently failed due to the missing libclangSupport.a.  It turns out
        libclangSupport.a only got added with
        <https://github.com/llvm/llvm-project/commit/f26c41e8dd28d86030cd0f5a6e9c11036acea5d2>
        "[RISCV] Moving RVV intrinsic type related util to clang/Support" towards
        Clang 15.
        
        And for another, as discussed in the mailing list thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2022-August/089212.html>
        "Re: Libreoffice error during autogen", there are apparently environments that
        lack both libclangSupport.a and libclang-cpp.so, which then started to fail the
        configure check completely.
        
        Checking for the combined -lclang-cpp first avoids all of that (so this commit
        effectively reverts 5078591de9a0e65ca560a4f1913e90dfe95f66bf "CLANGTOOLLIBS
        needs to include -lclangSupport now" again).  The clang-cpp library should
        generally be available since Clang 9 (see
        <https://github.com/llvm/llvm-project/commit/a80a3a2b239591f62422686dae9071df89a3b339>
        "Document clang-cpp in the release notes for clang"), but it can presumably be
        configured not to be built, and there are apparently environments lacking it
        (see above).  So keep checking for the (original, lacking the problematic
        -lclangSupport) hand-curated list as a fallback, even though that list is known
        to become outdated and dysfunctional.
        
        Change-Id: I0edf23f5ca30b125e6438db0a42c849f1b4677d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137789
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc8106f66ea26c0ae2874a5c1168f43a6263a564]

        cid#1507745 return local
        
        regression from
            commit b4b4c129e9f00189978cd7b71fd74d0dca4c9ebc
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Aug 1 09:09:05 2022 +0200
            clang-tidy modernize-pass-by-value in ucb
        
        Change-Id: Ie5d7d78ebde6fdee1234a0da496ff9692ee3c2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137796
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Caolán McNamara  <caolanm@redhat.com>  [0ae71b5527e18a7698da093847e5ad2be6a11d09]

        resave with latest glade
        
        Change-Id: I0e9c4955d7d0c6127448913176f9ef24269c8989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-04  Caolán McNamara  <caolanm@redhat.com>  [d84f7217b25bd3766497b17a8e057e3cbf4c8db8]

        tdf#150249 close of popover not detected
        
        the popover listened to here isn't the one that ends up getting actually
        used, its contents are transferred to another one, so the
        OnPopoverClosed wasn't called, its sufficient to just use the
        SubToolbarControl dtor to detect what is wanted here
        
        Change-Id: I3f4a038acfc183b863457919bf89d600517ddc01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [7f5cab0cf4aa25cf3b84a39b0f9e41de51928fbc]

        qt a11y: Map BUTTON_{DROPDOWN,MENU} to Qt equivalents
        
        There are specialised roles for these 2 button types
        in Qt as well.
        
        Change-Id: I67f49f0c4afc5f20a8c42fa2388f08ea9d950b91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137785
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  László Németh  <nemeth@numbertext.org>  [cca71aa4c5b79302a4f30c5ab5582da2b9d378e8]

        tdf#149388 sw: add better limit to detect tracked text moving
        
        Detection of tracked text moving needs at least 6 characters
        with an inner space after stripping white spaces of its redline.
        This way frequent deletion and insertion of articles or other
        common word parts, e.g. 'the' and 'of a' won't detected as
        text moving by mistake.
        
        Note: to still detect their redlines, as text moving,
        update test document of testTdf145719 to contain
        moved text "dolor sit" instead of "dolor", also
        testRedlineMoving to move list item "An ItemIt"
        instead of "It", and add testTdf149388 with test
        document of the original testTdf132371, where redline
        containing "Third" is not detected as text moving,
        unlike the new test document of the new testTdf132371,
        which contains "Third etc." (at least 6 character
        text with at least an inner space).
        
        Change-Id: I7f24fadebe2e21ae303677f74001dbc2d2ad87a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137749
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8b636d703907014df49ee13e71c3c7a17e996b96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cf46caf4868e0061c9886bad0303b8e7c2ebd7a1
          - tdf#150251, Help part
            
            Change-Id: Ic53d78616c1257770ac588c80c447717dafdb253
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137733
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3e061845b736409094af2bcc2a542ec94b093d9]

        clang-tidy modernize-pass-by-value in sw
        
        Change-Id: Ie5c250c64f95e649d33d3f3da7b54e81a4b81d0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [502357eef1a6d74a0aeb0b3f2ed956cb6f671008]

        introduce SwPosition::AssignStartIndex and AssignEndIndex
        
        as part of the process of hiding the internals of SwPosition
        
        Change-Id: I496a0e24257a1ec6653a3becef4889b6fdf5339b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137788
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a999b8dc83a9ee1749502eb909794cddc6f34f84]

        tdf#150251: clarify macro URL authority in command line help
        
        Change-Id: Idaf76365802023204bd2be27d9b4db62cd12f8dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137780
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-04  Stephan Bergmann  <sbergman@redhat.com>  [427ba44505fd5be6920899595759ab5dc47c7342]

        Adapt test to LLVM 16 trunk libc++
        
        ...see
        <https://github.com/llvm/llvm-project/commit/309aed306817e5b1a302d8f757231c734cf71370>
        "[libc++] Implement P1423R3 (char8_t backward compatibility remediation)"
        causing
        
        > error: 'error' diagnostics seen but not expected:
        >   compilerplugins/clang/test/getstr.cxx Line 43: overload resolution selected deleted operator '<<'
        
        Change-Id: Ic2fb9409cf3033300aca6717a8db7889e9d03c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137786
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [9afc3e2715027811fe0f8bfc5be924a7781fc2a1]

        use more SwPosition::Assign
        
        Updating some more of the places where the usage is "safe"
        i.e. this patch should introduce no functional change.
        
        Change-Id: I02390b3daecf23c1541a69f1957e6cf507cef72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137777
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [ba31e1bfdbcb836ba0fb4ea795997ce788b21e11]

        qt a11y: Map AccessibleRole::FILE_CHOOSER
        
        Qt doesn't have an extra role for this, so
        use the dialog role, since `AccessibleRole::FILE_CHOOSER`
        is for a "specialized dialog that displays the files in the
        directory and lets the user select a file, browse a different
        directory, or specify a filename."
        
        Change-Id: Ib17b573dcd149148e72e1a47922dccf6f8fb67d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137784
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [dcefd68f6df333949dab5958ab874db539b191bb]

        qt a11y: Drop extra empty lines in switch/case
        
        Change-Id: I9208dccf15da918f8a30f21efb49986c69b68c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137783
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [0b15b7f589b17232c35d28d9cc9b002f7dd89246]

        qt a11y: Drop obsolete and misleading comment
        
        The
        
                /* Ignore window objects for sub-menus, combo- and list boxes,
                 *  which are exposed as children of their parents.
                 */
        
        comment had been added in
        
            commit 4d382636b0b1c555af2b98f2f41b4776fd7b5ffb
            Date:   Fri Sep 21 10:20:09 2018 +0200
        
                qt5: Add basic a11y support
        
        where the code was still actually doing that, but since
        
            commit 7384e53bbc5163534ae898b7295b4efe51c8acde
            Date:   Fri Sep 28 17:00:12 2018 +0200
        
                qt5 a11y: Use UNO Api instead of vcl::Window methods
        
        that is no longer the case, so drop the obsolete comment.
        
        Change-Id: Ic7739049f283dbe27f881414e87ada7616ca424f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137782
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5479f6290a5ac0fae3a26f01025d5eb9c554d4f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 72c42ca413faff125c621f2a410d6e88c152e192
          - tdf#150162 Add missing sample file for FOURIER
            
            Change-Id: Iad5fcedf6f2351abc904f0e5cbdc63c0f47fc7e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137770
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-08-04  Stephan Bergmann  <sbergman@redhat.com>  [49a5c32d6e29c6551531763bde126bdcc36ec93e]

        external/openldap: Fix -Wint-conversion
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311>
        "Strengthen -Wint-conversion to default to an error", causing
        
        > checking for pthread_detach with <pthread.h>... no
        > configure: error: could not locate pthread_detach()
        
        because of
        
        > configure:19227: checking for pthread_detach with <pthread.h>
        > configure:19249: ~/llvm/inst/bin/clang -o conftest  -D_XOPEN_SOURCE=500 -D_DEFAULT_SOURCE -D_BSD_SOURCE  -O0 -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -ggnu-pubnames -Iworkdir/UnpackedTarball/nss/dist/public/nss -Iworkdir/UnpackedTarball/nss/dist/out/include  -Iworkdir/UnpackedTarball/nss/dist/public/nss -Iworkdir/UnpackedTarball/nss/dist/out/include   -fuse-ld=lld --ld-path=~/llvm/inst/bin/ld.lld -Wl,--gdb-index -Lworkdir/UnpackedTarball/nss/dist/out/lib  -pthread conftest.c    >&5
        > conftest.c:109:16: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'pthread_t' (aka 'unsigned long') [-Wint-conversion]
        > pthread_detach(NULL);
        >                ^~~~
        > ~/llvm/inst/lib/clang/16.0.0/include/stddef.h:89:16: note: expanded from macro 'NULL'
        > #  define NULL ((void*)0)
        >                ^~~~~~~~~~
        > /usr/include/pthread.h:269:38: note: passing argument to parameter '__th' here
        > extern int pthread_detach (pthread_t __th) __THROW;
        >                                      ^
        > 1 error generated.
        > configure:19249: $? = 1
        
        Change-Id: I3f2b8836e7aba6536e2877b492b43de588804f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137758
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Stephan Bergmann  <sbergman@redhat.com>  [4f37c51e9de14a04365c35f7ec7a4ac256995a51]

        Fix typos, __clang_ -> __clang__
        
        Change-Id: I89b8a2cb778f91610b6a8e8efc0c4e6ed96a7644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137778
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Stephan Bergmann  <sbergman@redhat.com>  [c712520cf327de27553f62d0defcce4ba901e4c7]

        Silence false -Werror=maybe-uninitialized
        
        ...in code recently added with 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0
        "tdf#149551 separate TextRotateAngle from TextPreRotateAngle", hitting at least
        with gcc-c++-12.1.1-1.fc36.x86_64,
        
        > In file included from include/tools/degree.hxx:15,
        >                  from include/vcl/bitmap.hxx:23,
        >                  from include/vcl/alpha.hxx:28,
        >                  from include/vcl/bitmapex.hxx:24,
        >                  from include/vcl/graph.hxx:26,
        >                  from include/oox/export/drawingml.hxx:47,
        >                  from oox/source/export/drawingml.cxx:26:
        > In function ‘o3tl::strong_int<UT, PT> o3tl::operator+(const strong_int<UT, PT>&, const strong_int<UT, PT>&) [with UT = int; PT = FractionTag<100>]’,
        >     inlined from ‘void oox::drawingml::DrawingML::WriteText(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface>&, bool, bool, sal_Int32, bool)’ at oox/source/export/drawingml.cxx:3520:33:
        > include/o3tl/strong_int.hxx:143:12: error: ‘*(const o3tl::strong_int<int, FractionTag<100> >*)((char*)&nTextRotateAngleDeg100 + offsetof(std::optional<o3tl::strong_int<int, FractionTag<100> > >,std::optional<o3tl::strong_int<int, FractionTag<100> > >::<unnamed>.std::_Optional_base<o3tl::strong_int<int, FractionTag<100> >, true, true>::<unnamed>)).o3tl::strong_int<int, FractionTag<100> >::m_value’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   143 |     return strong_int<UT,PT>(lhs.get() + rhs.get());
        >       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > oox/source/export/drawingml.cxx: In member function ‘void oox::drawingml::DrawingML::WriteText(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface>&, bool, bool, sal_Int32, bool)’:
        > oox/source/export/drawingml.cxx:3346:30: note: ‘*(const o3tl::strong_int<int, FractionTag<100> >*)((char*)&nTextRotateAngleDeg100 + offsetof(std::optional<o3tl::strong_int<int, FractionTag<100> > >,std::optional<o3tl::strong_int<int, FractionTag<100> > >::<unnamed>.std::_Optional_base<o3tl::strong_int<int, FractionTag<100> >, true, true>::<unnamed>)).o3tl::strong_int<int, FractionTag<100> >::m_value’ was declared here
        >  3346 |     std::optional<Degree100> nTextRotateAngleDeg100; // text area rotation
        >       |                              ^~~~~~~~~~~~~~~~~~~~~~
        
        and then
        
        > In file included from include/oox/export/drawingml.hxx:38,
        >                  from oox/source/export/drawingml.cxx:26:
        > In function ‘rtl::OString oox::drawingml::calcRotationValue(sal_Int32)’,
        >     inlined from ‘void oox::drawingml::DrawingML::WriteText(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface>&, bool, bool, sal_Int32, bool)’ at oox/source/export/drawingml.cxx:3551:48:
        > include/oox/drawingml/drawingmltypes.hxx:168:19: error: ‘*(const o3tl::strong_int<int, FractionTag<100> >*)((char*)&nTextRotateAngleDeg100 + offsetof(std::optional<o3tl::strong_int<int, FractionTag<100> > >,std::optional<o3tl::strong_int<int, FractionTag<100> > >::<unnamed>.std::_Optional_base<o3tl::strong_int<int, FractionTag<100> >, true, true>::<unnamed>)).o3tl::strong_int<int, FractionTag<100> >::m_value’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   168 |         nRotation -= 36000;
        >       |         ~~~~~~~~~~^~~~~~~~
        > oox/source/export/drawingml.cxx: In member function ‘void oox::drawingml::DrawingML::WriteText(const com::sun::star::uno::Reference<com::sun::star::uno::XInterface>&, bool, bool, sal_Int32, bool)’:
        > oox/source/export/drawingml.cxx:3346:30: note: ‘*(const o3tl::strong_int<int, FractionTag<100> >*)((char*)&nTextRotateAngleDeg100 + offsetof(std::optional<o3tl::strong_int<int, FractionTag<100> > >,std::optional<o3tl::strong_int<int, FractionTag<100> > >::<unnamed>.std::_Optional_base<o3tl::strong_int<int, FractionTag<100> >, true, true>::<unnamed>)).o3tl::strong_int<int, FractionTag<100> >::m_value’ was declared here
        >  3346 |     std::optional<Degree100> nTextRotateAngleDeg100; // text area rotation
        >       |                              ^~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: Id0bf911ada8f8d7343e9c51107776e303ed72a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137779
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [96fb8f88bd56c113eb23e50d23a038509703c288]

        elide some SwNodeIndex temporaries
        
        Change-Id: I5391aa409d760870ead26d43b2287b23d2d40089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137776
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  László Németh  <nemeth@numbertext.org>  [6a0163d967ce0482598eeebbcc5a4f413f190533]

        tdf#150166 DOCX export: revert ToC w:move* to fix broken file
        
        Export w:moveFrom/w:moveTo of tracked ToC moving as w:del/w:ins
        (and w:delText for runs in w:del) again to avoid of interoperability
        problems.
        
        Partial revert of commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving".
        
        Follow-up to commit 64ac089ad5464c832592e050f5d51a136f533f21
        "tdf#150166 DOCX export: fix broken file with tracked ToC moving".
        
        Note: Commit 64ac089ad5464c832592e050f5d51a136f533f21 was only part
        of the fix for the broken export with interoperability problems.
        
        Change-Id: I520f3a7e08eca0ccd6aa221a2406b41925f70fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137752
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b58abd841d5fbca5ed9f4423d3f137b412ff761]

        add more SwPosition::Assign
        
        These are just the "obviously correct" places where we
        can use SwPosition::Assign, i.e. the places where we
        are already correctly setting both nNode and nContent
        in SwPosition.
        
        Change-Id: I27078c91e491c9162770ce729364197056d62cb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [6816a4d4aff1bcac91d2d5e33160b76a89a47f40]

        introduce SwPosition::Assign
        
        as part of the process of hiding the internals of SwPosition
        
        And use it in a handful of places where it is obviously correct to do so
        (leaving all the hard stuff for later)
        
        Change-Id: Ic1b8e80072f45acc8d2f08264662611168b1dd85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [99640693d28ca11b31a1d3855e104d2d8c5122d7]

        qt a11y: Implement QtAccessibleWidget::window
        
        Quoting the Qt doc [1]:
        
        > Returns the window associated with the underlying object.
        > For instance, QAccessibleWidget reimplements this and returns
        > the windowHandle() of the QWidget.
        >
        > It is used on some platforms to be able to notify the AT client
        > about state changes. The backend will traverse up all ancestors
        > until it finds a window. (This means that at least one interface
        > among the ancestors should return a valid QWindow
        > pointer).
        
        Check if the associated QObject is a QWidget and if so,
        get the associated window, otherwise walk up the a11y tree.
        
        Note however that this change alone is not yet sufficient
        for a window to actually be returned for any arbitrary a11y
        object deeper down the hierarchy. This is because
        walking up the a11y hierarchy currently results in new
        Qt a11y objects being created for the parents instead of
        using existing ones, and the newly created ones lack
        the association to the widgets.
        (This works in a WIP branch that remembers/caches
        a11y objects, but that needs some additional work before
        it can be merged.)
        
        [1] https://doc.qt.io/qt-5/qaccessibleinterface.html#window
        
        Change-Id: Iba05f7bd3fba30fb2ca741179abbda2d60bee980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137753
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Michael Weghorn  <m.weghorn@posteo.de>  [2690b0079c160ab68b98d720432bb0949624c78b]

        qt a11y: Consider QObject hierarchy to find parent
        
        The a11y hierarchy of the whole application
        includes a11y objects that have no LO-internal
        a11y objects associated with them, but are handled
        solely by the Qt library, like the Qt application
        at the root of the a11y hierarchy.
        
        Therefore, fall back to using the QObject hierarchy
        when looking for the parent of an a11y object.
        
        This e.g. makes the scenario of starting at the top-level
        application object, moving the hierarchy
        down two levels, then up again work, which now
        and ends up at the application object again.
        With the application a11y object ("soffice.bin")
        selected in the Accerciser tree view of the a11y hierarchy,
        this can be achieved with the following commands
        in Accerciser's IPython console:
        
            In [4]: acc.name
            Out[5]: 'soffice.bin'
            In [5]: acc.get_child_at_index(0).get_child_at_index(0).get_parent().get_parent().name
            Out[6]: 'soffice.bin'
        
        It previously failed like this, which is one of the reasons
        why restoring bookmarks in Accerciser didn't work when using
        the qt6 VCL plugin:
        
            In [1]: acc.get_child_at_index(0).get_child_at_index(0).get_parent().get_parent().name
            ---------------------------------------------------------------------------
            AttributeError                            Traceback (most recent call last)
            /usr/lib/python3/dist-packages/pyatspi/__init__.py in <module>
            ----> 1 acc.get_child_at_index(00).get_child_at_index(0)0.(get_parent).(get_parent).nameAttributeError
        
            In [1]: acc.get_child_at_index(0).get_child_at_index(0)
            Out[2]: <Atspi.Accessible object at 0x7fd3b8d11140 (AtspiAccessible at 0x56252b30bd40)>
            In [2]: acc.get_child_at_index(0).get_child_at_index(0).name
            Out[3]: 'VCL ImplGetDefaultWindow (Type = 362)'
            In [3]: acc.get_child_at_index(0).get_child_at_index(0).get_parent()
            In [4]: acc.get_child_at_index(0).get_child_at_index(0).get_parent() == None
            Out[5]: True
        
        Change-Id: Iba197a2e943671591fa0ee5641a7b330eae8822a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137747
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [c2e86396b741b956efc05e9dfea1e1c3286dfb9d]

        tdf#150247: patch orcus to use UTF-16 paths on Windows
        
        This adds UTF8->UTF16 conversion of the paths passed to ctor of
        file_content on Windows, since both boost::filesystem::file_size
        and boost::interprocess::file_mapping take UTF-16 strings on this
        platform. So the assumption is that 8-bit path strings passed to
        orcus are UTF-8-encoded.
        
        This partially reverts commit 75252e58d9b5d020bf7bd6ca66b3a9d780463051
        (it keeps use of osl_getThreadTextEncoding for platforms other than
        Windows).
        
        Change-Id: Ie467f71a65945f4f07ff432136ea06b811c3f794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137759
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-04  Eike Rathke  <erack@redhat.com>  [86ed0105a4d70d481e3358ae1c6855766ef44d23]

        Resolves: tdf#150253 Add English names for GRAM_API AddIn functions
        
        ... so not only the com.sun.star.sheet.addin.* programmatic names
        are recognized for XCell::setFormula() non-localized API calls.
        
        Change-Id: I1f1f3f45001360445b25765312782f04ee079ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137769
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-04  Martin Srebotnjak  <miles@filmsi.net>  [8a34f1cb2efc47861781eb2a7b0dc069d71d0cfe]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to b0fa8fc6b50cb4d528d08ad462b294d2b69e2278
          - Updated Slovenian thesaurus
            
            Change-Id: I7209dd3153e83674b473e95797fff7b0b01a7b2e
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/137772
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2022-08-03  Stephan Bergmann  <sbergman@redhat.com>  [ff2a90379fc14cc30e60e829ed20752b8c2fa02a]

        external/boost: Fix ill-formed constant expression errors
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/b3645353041818f61e2580635409ddb81ff5a272>
        "[Clang] Diagnose ill-formed constant expression when setting a non fixed enum
        to a value outside the range of the enumeration values", causing
        
        > In file included from IWORKTable.cpp:10:
        > In file included from ./IWORKTable.h:21:
        > In file included from ./IWORKTypes.h:20:
        > In file included from external/boost/include/boost/variant.hpp:31:
        > In file included from workdir/UnpackedTarball/boost/boost/variant.hpp:17:
        > In file included from workdir/UnpackedTarball/boost/boost/variant/variant.hpp:34:
        > In file included from workdir/UnpackedTarball/boost/boost/variant/detail/hash_variant.hpp:22:
        > In file included from workdir/UnpackedTarball/boost/boost/variant/apply_visitor.hpp:16:
        > In file included from workdir/UnpackedTarball/boost/boost/variant/detail/apply_visitor_unary.hpp:21:
        > In file included from workdir/UnpackedTarball/boost/boost/mpl/advance.hpp:19:
        > In file included from workdir/UnpackedTarball/boost/boost/mpl/negate.hpp:17:
        > In file included from workdir/UnpackedTarball/boost/boost/mpl/integral_c.hpp:32:
        > workdir/UnpackedTarball/boost/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: non-type template argument is not a constant expression
        >     typedef AUX_WRAPPER_INST( BOOST_MPL_AUX_STATIC_CAST(AUX_WRAPPER_VALUE_TYPE, (value - 1)) ) prior;
        >             ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/boost/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
        > #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
        >                                               ^
        > workdir/UnpackedTarball/boost/boost/mpl/integral_c.hpp:31:54: note: expanded from macro 'AUX_WRAPPER_INST'
        > #define AUX_WRAPPER_INST(value) AUX_WRAPPER_NAME< T, value >
        >                                                      ^~~~~
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/meta.hpp:30:46: note: in instantiation of template class 'mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>' requested here
        >        enum { x = ( BOOST_MPL_AUX_VALUE_WKND(T1)::value == BOOST_MPL_AUX_VALUE_WKND(T2)::value ) };
        >                                              ^
        > workdir/UnpackedTarball/boost/boost/mpl/if.hpp:63:68: note: in instantiation of template class 'boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>>' requested here
        >           BOOST_MPL_AUX_STATIC_CAST(bool, BOOST_MPL_AUX_VALUE_WKND(T1)::value)
        >                                                                    ^
        > workdir/UnpackedTarball/boost/boost/mpl/eval_if.hpp:37:22: note: in instantiation of template class 'boost::mpl::if_<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>>, boost::mpl::identity<boost::numeric::convdetail::get_subranged_BuiltIn2BuiltIn<int, unsigned long>>, boost::mpl::eval_if<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_udt>>, boost::mpl::identity<boost::mpl::identity<boost::numeric::convdetail::subranged_BuiltIn2Udt<int, unsigned long>>>, boost::mpl::if_<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::udt_to_builtin>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2BuiltIn<int, unsigned long>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2Udt<int, unsigned long>>>>>' requested here
        >     typedef typename if_<C,F1,F2>::type f_;
        >                      ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/meta.hpp:81:12: note: in instantiation of template class 'boost::mpl::eval_if<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>>, boost::mpl::identity<boost::numeric::convdetail::get_subranged_BuiltIn2BuiltIn<int, unsigned long>>, boost::mpl::eval_if<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_udt>>, boost::mpl::identity<boost::mpl::identity<boost::numeric::convdetail::subranged_BuiltIn2Udt<int, unsigned long>>>, boost::mpl::if_<boost::numeric::convdetail::equal_to<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::udt_to_builtin>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2BuiltIn<int, unsigned long>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2Udt<int, unsigned long>>>>>' requested here
        >       mpl::eval_if<is_case0,Case0TypeQ,choose_1_2_3Q>::type
        >            ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/udt_builtin_mixture.hpp:41:7: note: in instantiation of template class 'boost::numeric::convdetail::ct_switch4<mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_builtin>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::builtin_to_udt>, mpl_::integral_c<boost::numeric::udt_builtin_mixture_enum, boost::numeric::udt_to_builtin>, boost::numeric::convdetail::get_subranged_BuiltIn2BuiltIn<int, unsigned long>, boost::mpl::identity<boost::numeric::convdetail::subranged_BuiltIn2Udt<int, unsigned long>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2BuiltIn<int, unsigned long>>, boost::mpl::identity<boost::numeric::convdetail::subranged_Udt2Udt<int, unsigned long>>>' requested here
        >       ct_switch4<UdtMixture
        >       ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/is_subranged.hpp:205:9: note: (skipping 3 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)
        >         for_udt_builtin_mixture<udt_builtin_mixture, BuiltIn2BuiltInQ, BuiltIn2UdtQ, Udt2BuiltInQ, Udt2UdtQ>::type
        >         ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/conversion_traits.hpp:22:7: note: in instantiation of template class 'boost::numeric::convdetail::non_trivial_traits_impl<int, unsigned long>' requested here
        >     : convdetail::get_conversion_traits<T,S>::type
        >       ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/converter.hpp:584:22: note: in instantiation of template class 'boost::numeric::conversion_traits<int, unsigned long>' requested here
        >     typedef typename Traits::trivial trivial ;
        >                      ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/converter.hpp:29:32: note: in instantiation of template class 'boost::numeric::convdetail::get_converter_impl<boost::numeric::conversion_traits<int, unsigned long>, boost::numeric::def_overflow_handler, boost::numeric::Trunc<unsigned long>, boost::numeric::raw_converter<boost::numeric::conversion_traits<int, unsigned long>>, boost::numeric::UseInternalRangeChecker>' requested here
        > struct converter : convdetail::get_converter_impl<Traits,
        >                                ^
        > workdir/UnpackedTarball/boost/boost/numeric/conversion/cast.hpp:53:16: note: in instantiation of template class 'boost::numeric::converter<int, unsigned long, boost::numeric::conversion_traits<int, unsigned long>, boost::numeric::def_overflow_handler, boost::numeric::Trunc<unsigned long>>' requested here
        >         return converter::convert(arg);
        >                ^
        > IWORKTable.cpp:782:45: note: in instantiation of function template specialization 'boost::numeric_cast<int, unsigned long>' requested here
        >       cellProps.insert("librevenge:column", numeric_cast<int>(c));
        >                                             ^
        > workdir/UnpackedTarball/boost/boost/mpl/aux_/integral_wrapper.hpp:73:31: note: integer value -1 is outside the valid range of values [0, 3] for this enumeration type
        >     typedef AUX_WRAPPER_INST( BOOST_MPL_AUX_STATIC_CAST(AUX_WRAPPER_VALUE_TYPE, (value - 1)) ) prior;
        >                               ^
        > workdir/UnpackedTarball/boost/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
        > #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
        >                                               ^
        
        etc. when building ExternalProject_libetonyek
        
        Change-Id: I1830c1182a7ab966bb068b5eb97db099c9678fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137757
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-03  Stephan Bergmann  <sbergman@redhat.com>  [87eff817eb723e249783f16bf69a8b4cef53e3cb]

        external/redland: Fix -Wint-conversion
        
        ...with recent Clang 16 trunk since
        <https://github.com/llvm/llvm-project/commit/7068aa98412ade19a34b7ed126f4669f581b2311>
        "Strengthen -Wint-conversion to default to an error", causing
        
        > raptor_parse.c:260:66: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
        >   RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE(world, raptor_world, NULL);
        >                                                                  ^~~~
        
        and
        
        > raptor_serialize.c:243:66: error: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
        >   RAPTOR_ASSERT_OBJECT_POINTER_RETURN_VALUE(world, raptor_world, NULL);
        >                                                                  ^~~~
        
        Change-Id: I2c1083b78777589b992c180d8759e2313bf2fe42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137756
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-03  Stephan Bergmann  <sbergman@redhat.com>  [5078591de9a0e65ca560a4f1913e90dfe95f66bf]

        CLANGTOOLLIBS needs to include -lclangSupport now
        
        ...presumably since
        <https://github.com/llvm/llvm-project/commit/7a5cb15ea6facd82756adafae76d60f36a0b60fd>
        "[RISCV] Lazily add RVV C intrinsics", otherwise causing
        
        > [GEN] compilerplugins/clang/sharedvisitor/analyzer
        > /usr/bin/ld: ~/llvm/inst/lib/libclangSema.a(SemaRISCVVectorLookup.cpp.o): in function `clang::CreateRISCVIntrinsicManager(clang::Sema&)':
        > ~/github.com/llvm/llvm-project/clang/lib/Sema/SemaRISCVVectorLookup.cpp:195: undefined reference to `clang::RISCV::RVVIntrinsic::computeBuiltinTypes(llvm::ArrayRef<clang::RISCV::PrototypeDescriptor>, bool, bool, bool, unsigned int, bool, clang::RISCV::PolicyScheme, clang::RISCV::Policy)'
        [...]
        
        with recent Clang 16 trunk.
        
        It would have been nice to extend the configure check to actually catch that,
        but I didn't find any small code sample that would diagnose that:
        * Reverting 79ca031fb2e8802aa4383362f83306fad6895729 "make the clang plugins
          configure check faster" would cause the configure check to erroneously fail
          due to "no member named 'tooling' in namespace 'clang'".
        * And then replacing clang/AST/RecursiveASTVisitor.h with
          clang/Tooling/Tooling.h would make the configure check succeed, and not
          diagnose the above issue.
        
        Change-Id: I6b2eb38daaa1c514fb61652e5bd522f91aa67059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137755
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [6568d572e0c7a9c99580f3cc94273d8ddd00b781]

        handle scroll events in surrounding GtkSalFrame if there is one
        
        Change-Id: I47f71371246f6322f41b782697d4824517375c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [f6bbd43dc254755c0394473a871f240492abf1e7]

        forcepoint#105 add test-case
        
        was possibly fixed by commit 3d48adc6f9bbec0b7a169466273636961ffbb6bf
        "tdf#149649 sw_fieldmarkhide: delete any fieldmarks overlapping cells"
        
        Change-Id: I395da31d3afa5f4ddeb6b6889fbeb2b4b1fd8d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [1e5715907062570f2331ac2a640a1ee18ce71f44]

        gtk4: tweaks for native gtk4 scrollbars in writer
        
        Change-Id: I42072354fd6f901035d1419f9f9402eac2eaaaac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [6c12f6dca251ba583297090def8aa9597a818c14]

        tdf#117388 use native scrollbar under gtk in writer
        
        with the motivation that for gtk4 theming for vcl scrollbar isn't
        available, so it looks super yuck but this should also support the
        long-press scrolling thing under gtk3 as a side effect.
        
        Change-Id: Iada5a66087d5aa982f9213d7ec0a05f6177f4e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137750
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [adc15ce09e5f7fbcf5857238a9898f96da5acb9f]

        Move #includes to the top
        
        Change-Id: I2fcd283effed5ea95fb17d0cb60cfd69f25aec6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137711
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [21789a1da4c9fe572167460ab8529d826837e612]

        Removed duplicated includes
        
        Change-Id: I42905fcc622e09768e08d75fe3aaf7426d601515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137710
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-03  Heiko Tietze  <tietze.heiko@gmail.com>  [947ad25207a52d8d245a977430244cce38734b65]

        Resolves tdf#149944 - UI issues with Base's User Administration dialog
        
        Buttons for add, delete user and change password moved into a menu
        
        Change-Id: Ibddda5269f0a8a9219538833b1f871b041dd5341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137754
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-03  Mike Kaganski  <mike.kaganski@collabora.com>  [4f3d989a40a7083ce25a0ccddd711f7a045844b6]

        This must be non-null
        
        Change-Id: Id62b3c9e4bc9b6fd4bcc2cc9019d94db310adac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137719
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-03  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [4d6243693c228703394c00164276f8326447beb9]

        tdf#143703 sw: always assign name for fly section
        
        Previously generated name was assigned only if not in doc
        reading mode. But there is no guarantee that it will be assigned
        later. Better to insert any name in SwDoc::MakeFlySection_() and
        later it can be overwritten, but fly will definitely have
        any unique name.
        
        * Some test failed because GraphicImport_Impl::applyName() overwrote the
          name with a different generated one.
        
        * This breaks chaining of VML shapes, see test testTDF87348.
        
          The code introduced in commit 091fe76b6329b4bb974987554369cbfadd8f2401
          in DomainMapper_Impl::ChainTextFrames() breaks if the text frame
          already has a name; it's a bit confusing which names there come from
          the file and which come from the API, and it also mixes 2 different
          cases of VML chaining and DrawingML chaining that look like they
          should be using different data.
        
        * This also breaks moving flys anchored at-char in flys into them in
          SwXText::convertToTextFrame(), see ooxmlexport13 testFlyInFly.
        
          This kind of worked by accident before: the fly is copied and then the
          original deleted, keeping the same name (with help of
          SwDoc::mbCopyIsMove); with no name it would compare the SdrObject
          pointer, which is different for the new copy, now the name is the
          same.
        
          Fix this by only moving flys anchored at the edge of the selection
          back inoto the body; it turns out that Word actually supports at-char
          anchors in text frames, but only if it's a VML shape or Compatibility
          Mode or whatever; i wasn't able to do it in a document created from
          scratch.
        
          This is a bit tricky to ignore the nodes added for floating tables as
          seen in ooxmlexport10 testFloatingTablesAnchor.
        
        * Another change is required in SwDoc::SetFlyName() because of
          testTdf127732, as it would rename a frame named "Frame1" to "Frame2"
          when called to rename it to "Frame1".
        
        * Some tests failed because after MakeFlySection_() assigns a name it is
          immediately unconditionally overwritten; replace that with asserts
        
        Change-Id: I46752a4413ba3a9e981eccd1e153b3aaf8053781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127556
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-03  Pranam Lashkari  <lpranam@collabora.com>  [9f7b3e2c47ff56c9529b3359e2459130ee922808]

        sw: always show "tabs" tab in the paragraph dialog for multiple paragraphs
        
        In case multiple paragraphs were selected and the various paragraphs had different left/right margins in their item sets, we used to hide the "tabs" tab page on the paragraph dialog.
        
        This had the benefit that we avoided presenting information that is not entirely true for all paragraphs, but had the downside that it was not possible to set tab stops for multiple paragraphs when at least one of the paragraph had different left/right margins compared to the reset of the paragraphs. This required the user to "hunt" for the offending paragraph(s). The ability to always have the possibility to set tab stops seems to provide more benefit than the cost of presenting a partially confusing "tabs" tab page when reading the doc model.
        
        Fix the problem by relaxing the requirements and only hiding the "tabs" tab page in the writer/web page, show the tab page is now always shown for normal documents.
        
        This change makes no effort to show the common tab stops of all selected paragraphs on the UI, which would probably make sense, but can be done in a follow-up change.
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: Ida61e8878382988a7470d156ded187d21bcc9d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137707
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 3f97c911aa91c3bdfbae05fd5646b55987691e42)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137718
        Tested-by: Jenkins

2022-08-03  Michael Stahl  <michael.stahl@allotropia.de>  [de0120d9f75159f85d723439a89a6449082de669]

        tdf#145226 sw: ODF export: fix table-row/table-cell style display-name
        
        Missed this attribute in commit 5a9fe1d80ea977c439dd10ee2056abe6b0cb4d07
        
        Change-Id: Icc3c0ad32905b04bbf73cae976a58b9b505d245c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137740
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c927cc34e05c331c1cebf6885256f31becfb89d]

        improve assert message
        
        Change-Id: Ib51768018f5ed8db89993a162ac8c4b4951b3887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [e40f9ec9680a350e8e44dcbbd7decbe9603bcc51]

        export scroll type when possible
        
        Change-Id: I1c343507d7db4b0805c20eabb68bf58a4432d33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [41aad592685b0b36c2e5f1033e7263aef406c28b]

        clang-tidy modernize-pass-by-value in slideshow
        
        Change-Id: I89a56aa3d267f22665769ba073a47d1208d8b55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-03  Mike Kaganski  <mike.kaganski@collabora.com>  [4afb80eaa0df58b78e2bfad892f9e7ce5e1bce7a]

        tdf#150241: a blind fix attempt
        
        I can't repro it locally (the report misses clear repro steps), but
        the three changed OUString assignment operators use rtl::str::assign
        internally, and the unconditional dereference of the value returned
        from SwDoc::GetDocPattern (that may return a nullptr) is suspicious,
        especially compared to the checks made in SwDocStyleSheet::GetHelpId
        later in the same file.
        
        All four calls to GetDocPattern in the file were introduced in commit
        7b0b5cdfeed656b279bc32cd929630d5fc25878b
          Author Jens-Heiner Rechtien <hr@openoffice.org>
          Date   Mon Sep 18 16:15:01 2000 +0000
            initial import
        
        Change-Id: If9d4cff921443e5af71b7d541b79d00ea77e853b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137734
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-08-03  Stephan Bergmann  <sbergman@redhat.com>  [c7760b326cbfe553184e16f221391ecf27b9bc48]

        Fix 32-bit builds
        
        ...after fc898f20cffe94cfde0a24027480fb97ab84563e "Use some more appropriate
        index variable types", as reported by Rene,
        
        > /home/rene/master/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx:313:51: error: conversion from 'guint' {aka 'unsigned int'} to 'connectivity::ORowSetValue' is ambiguous
        >   313 |             aRow[17] = new ORowSetValueDecorator( i );
        >       |                                                   ^
        
        Change-Id: I1532a012a9d8c3c4e3768c48e78ed6f50be3fd50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137744
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [bd4b494ac8c4a82048d6849650672445c36e1026]

        repair writer's scrollbar tooltip feature
        
        where aRect was unused from a missing Help::ShowQuickHelp etc.
        
        probably bad merge of
        
        commit 6005dd5366a86d6b7b1535233a99e24501e053a3
        Date:   Tue Dec 11 03:31:17 2012 +0000
        
            Resolves: #i25945# Allow disabling scrollbar tips by API and configuration
        
            (cherry picked from commit a2bbabbe141de1303ebf052e5c22b6e77387785e)
        
        Change-Id: I72d11f1cdf075a5bb67c596406f19403655f86b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137742
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  ehsan  <m.ehsan.movahedian@gmail.com>  [e010a57ab2489464719fb73ad0aea6e4e4c60383]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I9f3819c155bed0796f1b12e5e46e51d42f098117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136775
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [cadd2a9ea61464c8da3536b262a09ab50691f8d6]

        allow welding scrollbars individually
        
        typically a full ScrolledWindow is probably preferable, but allow
        individual scrollbars to be used
        
        Change-Id: Iab290b387421d7d97d3604e31f528769d822155a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Michael Weghorn  <m.weghorn@posteo.de>  [35be93f83ac866ef18f0e06853c9818cd1d1bd56]

        qt a11y: Implement QtAccessibleWidget::characterRect
        
        With this and the suggested changes ([1], [2], [3], [4])
        for 4 Qt issues I ran into ([5], [6], [7], [8]),
        the Accerciser scenario described in
        
            commit 7b312771d7eb33f7410167e36efdaeca6f540b1c
            Date:   Thu Jul 14 08:35:53 2022 +0200
        
                tdf#149952 gtk3 a11y: Return pos relative to window when requested
        
        works for the qt6 VCL plugin as well.
        (The complete GNOME Magnifier scenario from tdf#149952
        still doesn't work with qt6, probably because a11y
        events are not sent (reliably) so far.)
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/422251/1
        [2] https://codereview.qt-project.org/c/qt/qtbase/+/422333/1
        [3] https://codereview.qt-project.org/c/qt/qtbase/+/424510/2
        [4] https://codereview.qt-project.org/c/qt/qtbase/+/424731/1
        [5] https://bugreports.qt.io/browse/QTBUG-105031
        [6] https://bugreports.qt.io/browse/QTBUG-105042
        [7] https://bugreports.qt.io/browse/QTBUG-105281
        [8] https://bugreports.qt.io/browse/QTBUG-105313
        
        Change-Id: Iaccc89bf62c4617bee06f34ffebbd309a62212e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137735
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-03  Miklos Vajna  <vmiklos@collabora.com>  [7c94d7267bc8b5f43185204ab4953c4b188214bf]

        tdf#149943 vcl: fix pixelated PDF export and print for a rotated image
        
        The bugdoc has a barcode which looks good in Writer, but it's quite
        blurry in the PDF export result.
        
        This is a problem since commit dd4a67084853a030bf4b9f1f85d728620e0604a5
        (vcl: avoid downscale && upscale in DrawTransformedBitmapEx(),
        2019-10-08), where the motivation was to not downscale a bitmap in case
        it has a larger amount of pixels but a smaller logic size. This went
        wrong here and resulted in a blurry bitmap for a not so small image.
        
        Fix the problem by mostly reverting the above commit, because it's no
        longer necessary: 68549e00d5e23aa22bc974a8151d93cd948444b3 (vcl,
        BitmapEx transformed draw: special-case simple rotations, 2019-10-10)
        already made sure that the rotation case doesn't use scaling from the
        transform.
        
        testTdf128630 has been adapted to pass again (after manually verifying
        that the bugdoc export result is still OK), now the bad case there
        simply produces a smaller bitmap.
        
        Change-Id: Ib28881c129a0cf037a96eecd065e5cadede97051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137737
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ae434ccb4878ed49f19be578e4935f50196b6b78]

        windows signing: use sha256 (instead of the default sha1)
        
        will be enforced in e.g. microsoft store later this year...
        
        Change-Id: Ifa7f98d5c72bd7c7f602dc54ba8e16f7470dc3d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137738
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-08-03  Caolán McNamara  <caolanm@redhat.com>  [da6caa65c80977191084c33d5f17eead1cac763e]

        salTrue->true
        
        Change-Id: I5982726248c52f88ac5d262912d106e2f6c39f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137701
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-03  Noel Grandin  <noelgrandin@gmail.com>  [84c4ccfec1cbbd573609623a026a8cd2ad20400f]

        tdf#149966 Crash on Windows and freeze on Linux when customizing Menu
        
        use the notifyEach helper, which unlocks the mutex while we are
        calling listeners, which means we can tolerate a re-entrant call to
        removeConfigurationListener.
        
        regression from
            commit dab35c152af3345786b8335e83cd067b67d08b81
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Dec 18 20:24:15 2021 +0200
            osl::Mutex->std::mutex in ModuleUIConfigurationManager
        
        Change-Id: I7a2fbffb1c734b8bd0e952614592ce12c1611328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-03  Miklos Vajna  <vmiklos@collabora.com>  [ba62400222232b49d034f6b0a51e0679d0729d10]

        CppunitTest_sw_ooxmlexport13: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ia2c6963e0350718da3f9ac592f07863b55255648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137704
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-03  Eike Rathke  <erack@redhat.com>  [86b2bfd34a4f07c54f03c8c8dfe48e0810834628]

        Avoid multiple conversions to LanguageTag, specifically in loops
        
        Change-Id: I47a969d7476df32e0c9d525d416467c59358d9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137712
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-02  Eike Rathke  <erack@redhat.com>  [8dc76b13458fac1a30787f8bbab117a4a9508ab5]

        Resolves: tdf#150203 Gather AddIn English names and provide for FunctionAccess
        
        This works at least for the bundled AddIns from scaddins/. It may
        for others if en-US compatibility function names are provided, if
        not the local name will be continued to be used.
        
        Change-Id: I09e23f731c0f3d9753ef355ab59c2005bc567464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137708
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e49156aff90861cb5e488bab5e83cb7a00f109df]

        introduce SwPosition::GetContentNode
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nContent.GetContentNode' | xargs perl -pi -e
                    's/\bnContent\.GetContentNode/GetContentNode/g'
        
        Change-Id: I50bcde481a4a2785062b974fb81465a401b0a3e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [a17374e429609748c381d508efdd9b4d5325f1b8]

        introduce SwPosition::SetRedline
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nContent.SetRedline' | xargs perl -pi -e
                's/\bnContent\.SetRedline/SetRedline/g'
        
        Change-Id: If4d774959b0cc0fb87040f8f91c094dcd830dcd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d479babebbed721b0a3cc0c4ba88ea2cc377e21]

        introduce SwPosition::SetMark
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nContent.SetMark' | xargs perl -pi -e
            's/\bnContent\.SetMark/SetMark/g'
        
        Change-Id: I7fe558da8fffdd8e56598c3063a1058bd5239977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [566d6accfc443915e6f741e5cb7b8cf244dd7c8b]

        clang-tidy modernize-pass-by-value in toolkit
        
        Change-Id: I51823060a967b5c9f304af587ed4f9c262734be9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Eike Rathke  <erack@redhat.com>  [8690d8878248320b0b706e9d6f7b8fa89ed903c4]

        Related: tdf#150203 Pricing, there is only one compatibility name, en-US
        
        ... but that was associated with de-DE instead.
        
        Change-Id: I9024666b5d33bbabbdb514075fe0598d072dacd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137706
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-02  Eike Rathke  <erack@redhat.com>  [dac843c4dc0407430d5a7441fd80940a99a4d8f8]

        Use nNumOfLoc instead of sizeof(pLang)
        
        ... which is count*sizeof(char*), but luckily this private
        function was never used with out-of-bounds values.
        
        Change-Id: Ief3b3de614ca0df00c424f7caabf70e029ea7266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137703
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-08-02  Noel Grandin  <noelgrandin@gmail.com>  [562b67b78783e578dea91669dbb7770d3249d1d8]

        elide some temporary OUString construction in oox parsing
        
        Change-Id: I2ea01ef4724dd375d641c8e39a7028c0e5ccec2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Jim Raykowski  <raykowj@gmail.com>  [189b65b02fe1f3ce6be5b7637cc59443561855e4]

        tdf#90150 Improve Writer page number display in the status bar
        
        Enhancement patch to show page numbers as 'First visible page and
        Last visible page' when two pages are visible in the view, 'First
        visible page - Last visible page' when more than two pages are
        visible in the view. Numbers shown in () are custom page numbering
        numbers. Numbers shown in [] are virtual page numbers.
        
        Change-Id: Ie07dee0f372e2cd94fb848b092d3df04f242ab51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132252
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ca87a6f3a9175993131c5217190212a922275c5a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 146e4b39ffdf800b6d81ba4c043810b85054d051
          - Fix typo
            
            Change-Id: I9d067f28df51e2537335c9b896c32d6a86bcc1d8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137699
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-08-02  Laurent BP  <laurent.balland-poirier@laposte.net>  [cdfea6cffa27019b2d219491190dca534e365c95]

        tdf#142306 New version of Inspiration template
        
        Follow template of bug report
        
        Change-Id: I29e8b771cd49ef4fba2c6099b52fa26d8614f086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137369
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-08-02  Miklos Vajna  <vmiklos@collabora.com>  [e2a84cd740c0e58c08beb5c4169877a440cf53e1]

        sw: make shift-doubleclick on graphics open the graphic dialog
        
        Double-clicking on images without modifier keys or with ctrl triggered
        the graphic dialog. However, shift-doubleclick did not.
        
        One drawback of this behavior is that extensions can catch the
        .uno:GraphicDialog command for plain or ctrl double-click, but they
        can't customize the behavior for shift double-click. Another problem was
        that if you had a text selection and you shift-clicked (single click) on
        an image, then no image selection was created. (While this works in
        Word.)
        
        Fix the problem by extending the code handling mouse button events in
        Writer in case the button type is left, the only modifier is shift and
        we get one or two clicks:
        
        - if the position points to an object that should be selected, then
          shift-click now selects that object
        
        - if the user shift-double-clicks on an image, then we open the graphic
          dialog
        
        This improves consistency, as double-click with no/ctrl/shift modifiers
        now all dispatch .uno:GraphicDialog. Do the double-click tweak only for
        graphics, other shape types can be added in the future if needed.
        
        Change-Id: I2edc70a399a9d2662b476a1bbc4c5f087ce8e59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137696
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-02  Colomban Wendling  <cwendling@hypra.fr>  [6185a27db46bf5cba404e669eaf3a1c78f4a8607]

        tdf#150064 Add tests for a11y tree order
        
        Check the tree order is stable across loads and page switches.
        
        Change-Id: I8850eb8b230d9193c4f2497150a44fd555030a9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137681
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-02  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a7d9837a8aa6d1233f4c21e4db5d32428a3ffc58]

        tdf#148360: sw: do not ignore list label followed by
        
        ...even if numbering is empty.
        
        Since this is a core change to avoid impact on other formats
        (mostly ODT) it is implemented as a new document setting.
        
        Change-Id: I35e1cec97eb40f9f3411e3ba74cb553bd8afac59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134989
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-02  Jean-Pierre Ledure  <jp@ledure.be>  [6814e4375c9c1e17b6a09dbbd0651034542dec54]

        ScriptForge - tdf#150203 Use RANDBETWEEN.NV i.o. RANDBETWEEN
        
        Extract of the bug report (Rafael Lima)
        
        This bug affects a method from the ScriptForge library,
        more specifically the GetTempName method from
        the FileSystem service, which relies on calling RANDBETWEEN.
        Because of this bug, GetTempName only works in English,
        but fails in other languages. Below is a sample code
        for testing the GetTempName error.
        
        Sub TestTempName
          GlobalScope.BasicLibraries.LoadLibrary("ScriptForge")
          fs = CreateScriptService("FileSystem")
          MsgBox fs.GetTempName()
        End sub
        
        Interestingly changing RANDBETWEEN for RANDBETWEEN.NV
        in the macro above will work.
        
        Occurrences of the use of RANDBETWEEN:
           wizards/source/scriptforge/SF_FileSystem.xba
           wizards/source/sfdocuments/SF_Calc.xba
        
        Change-Id: Iea38f11acb7113aa5eaab1feff7a0e64a739aada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137691
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-08-02  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [076a7cf9e1c7c06b935bf3c733d606c1dcfe8a0c]

        Shorten LanguageTool Options page name
        
        You don’t really need the word “Settings”.
        
        See commit 43f159dafa3fe61c09cafc8467cdd67233a02401
        (“Rename ‘Basic IDE Options’ to just ‘Basic IDE’”, 2017-08-07);
        its rationale still stands.
        
        Change-Id: I66e09d51950eb903c7d1cd617da3d7daf668bc07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137629
        Tested-by: Jenkins
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [af23d1c1fc407b3d5f020122e2830959d45ffaf1]

        introduce SwPosition::GetContentIndex
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nContent.GetIndex' | xargs perl -pi -e
        's/\bnContent\.GetIndex/GetContentIndex/g'
        
        Change-Id: I12684071a6666c365dbadbab2a4b37cf51b274d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137695
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [961d42e1ca1da7f3199d46445b3766d9c6a6c938]

        introduce SwPosition::GetNodeIndex
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nNode.GetIndex' | xargs perl -pi -e
        's/\bnNode\.GetIndex/GetNodeIndex/g'
        
        Change-Id: I3616cea4c47595afe74f1aa8e3be553279f25d44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [21ed46f683dd9d838371cdba02593f3e64a5124c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b97f163be7b79bdfe410274d2bb01bd34a33c2b7
          - Update bookmarks for python_programming.xhp
            
            This patch also fixes all duplicated IDs that existed in this file.
            
            Change-Id: I186f54d44a3863e2ead5f8e5ea33d4262e665f46
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137529
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-08-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [ed03d5c14373a49b3ee6245d17d984ed4045a777]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to addffa169b8782e07a6c8fcaec42233114c85543
          - Document the new method Normalize in SF FileSystem
            
            Change-Id: If991bff08656c3de0616e2914c8cc31979c4c445
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137417
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [81002bc718edad94613b20c2480719979b443b99]

        clang-tidy modernize-pass-by-value in oox
        
        Change-Id: Ia553a24693f2ffc0f580c9869b82f0d01a1a0ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Henry Castro  <hcastro@collabora.com>  [554370661554652e7be96034e310d6863c700285]

        desktop: avoid run graphic tests if ...
        
        DISPLAY=hostname:displaynumber.screennumber has
        defined a remote display server, otherwise the initialization
        stuck for long time.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Ieb598a023bce3d4298e02fa3ed6ae2bcfc6df015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137366
        Tested-by: Jenkins

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1c195afab72794a1f0d5ed63c2e3fe6f65bfa84]

        introduce SwPosition::GetNode
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nNode.GetNode' | xargs perl -pi -e
            's/nNode\.GetNode/GetNode/g'
        
        Change-Id: Id1937df1bd5a54677c2c1bbfb2d693a4e22a7b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Caolán McNamara  <caolanm@redhat.com>  [d11f2e00593300dc68bcd11e23ad05116465adba]

        crashtesting: assert on export of forum-mso-en3-17256.xlsx to ods
        
        a lang::IllegalArgumentException is thrown on seeing myEB_Y_Pos
        and the xml tags become unbalanced
        
        Change-Id: I2bd65933c572d7bd1d1ade699fcef21a63a85e9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137689
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [613f6e75fbfcc024fc9c3732261cbf2cda6f4ad8]

        tdf#150034 very slow opening pathological chart
        
        revert part of
            commit 10c934147d469965dba6abc78efd02759a010b8e
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Apr 23 09:26:46 2019 +0200
            tdf#113266 slow opening XLS with 45 MB drawing
        in this situation, avoiding setting all the rects dirty speeds up the
        load from 70s to 1s.
        
        Change-Id: Ia35119ff20ef5bded9a34f12cce453434dea4383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Khaled Hosny  <khaled@aliftype.com>  [c010c1375bfec3aaa7d154c7164ae31df556cb68]

        more_fonts: Update Amiri
        
        Update PDF export test that depends on a mapping the font no longer has,
        and use different characters that meet the test criteria.
        
        Change-Id: I0f89297a52ffcef3513e0a788ec3bab645cc354b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137661
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-02  Khaled Hosny  <khaled@aliftype.com>  [44aa6bb9b7d2abeb10731cb0e1b7b52c1a79b7a3]

        more_fonts: Update Reem Kufi
        
        Also update test expectation due to changed glyph order.
        
        Change-Id: I8f6d1a057077cb6de5e5d7fce4bec29929edb8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137663
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-08-02  Noel Grandin  <noelgrandin@gmail.com>  [4a99111c4216fcd56d8bccb71c32fa7969448d27]

        use more getStringDefaulted
        
        rather than repeatedly constructing an empty OUString parameter
        
        Change-Id: I9ed2826f260f1f551c77e03b26f13a98e277f42f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137685
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Noel Grandin  <noelgrandin@gmail.com>  [1abb82c0bc8c46acac8b2644e645725ff92dd538]

        generalize the undo independence check
        
        Change-Id: I441edbdf11ada1a0a724577a4f76ae8ae14177e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137683
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-02  Justin Luth  <jluth@mail.com>  [f7b5eefc36f6a7627e867651bafe38bdeb2f9c00]

        tdf#148810 pptx import: Depth set by EE_PARA_OUTLLEVEL
        
        It isn't enough to do Paragraph->SetDepth().
        It must match the property EE_PARA_OUTLLEVEL.
        
        So I was hoping that the only thing I needed was the
        "set property" helper. But unit tests showed that I also needed
        "get property" to return an empty aAny instead of a -1.
        
        My confidence level on this one is fairly low.
        This code is way too tangled and weird.
        I'm sure the concept is right (that the property is the
        most important thing) but all of the wonkiness around
        the level means any changes to the implementation
        will be fragile.
        
        make UITest_impress_tests \
          UITEST_TEST_NAME=tdf148810.Tdf148810.test_Tdf148810
        
        Change-Id: I4aa62fe28ecbc483d5df0d1532fecd172afc54b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137569
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-02  Miklos Vajna  <vmiklos@collabora.com>  [339d47a352650285c8ea14f9d8c0b36616b0ed7c]

        officecfg: link better mirror
        
        That doesn't depend on me.
        
        Change-Id: Id1dbdd82409295c86a041666ae8ffc377931212e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137680
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-08-02  Justin Luth  <jluth@mail.com>  [5c68399e6bea3aa18477487400f8bb143d6ed84e]

        related tdf#150197: sd should SetListFormat
        
        sd code should all use the new ListFormat behaviour instead of
        the legacy Prefix/Suffix numbering format.
        
        At this point I don't think any SD code is using the new ListFormat,
        but SetListFormat has code to SetPrefix and SetSuffix,
        so it shouldn't hurt to do this.
        
        Change-Id: I91f9816161676d3444533481cbb616a2f5b069e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137686
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-01  Justin Luth  <jluth@mail.com>  [654454a32bd6dc40d131861fab5dbe0a9111a7c3]

        related tdf#150197 editeng: clear oListFormat on SetListFormat()
        
        Although a pre=existing prefix/suffix was cleared,
        a non-existing oListFormat should replace an earlier one
        if it is being reset.
        
        The hasValue only applies to setting backward compatiblity stuff.
        
        No real-world impact noticed - just cleaning up after a code read.
        I ALMOST needed this in my prior patch, but then I changed
        to use the other SetListFormat function call.
        
        Change-Id: I39eed26b7720f0f9a0d982a1cd1703a55c5ab986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137675
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-01  Justin Luth  <jluth@mail.com>  [f306d601a1eab561815a0a1e6dc2cd3d857d4f05]

        related tdf#150197: SwWrtShell::NumOrBulletOn should SetListFormat
        
        sw code should all use the ne ListFormat behaviour instead of
        the legacy Prefix/Suffix numbering format.
        
        There is another case in sd - but I'm a little leery
        about whether SD really supports the new ListFormat for numbering...
        
        Change-Id: I8dc0e14f5bc24d448a2551dba70b3dcce18273b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137682
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cd45ff66cfdb8d4417e159aaae59060dc232e810]

        Fix typo in code
        
        It passed "make check" on my laptop
        
        Change-Id: I2d231c3a8ec40b63026a4b81256b98ee4be0ae1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137660
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Noel Grandin  <noelgrandin@gmail.com>  [75a862b887fb0b7ff633a396ee7f7f34c2c82964]

        use more string_view when dealing with attributes
        
        which means we don't need to call strlen on them, since we already
        know how long they are.
        
        Change-Id: Iefc76f38a23250e87a65c27df3634d562464a760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137679
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-01  Caolán McNamara  <caolanm@redhat.com>  [f8d764b138fddde719a04683f9bd3720c21e0656]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I691f4d2abca8177da5c03652f003bba341e28907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137662
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [43d81ab5dbbfcdadd32ef04a1923cec71a270293]

        Fix typo in code
        
        It passed "make check" on my laptop
        
        Change-Id: I72c01c63a67e3d664cc28fc93d5681f7b342d39c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-08-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [cab25db0c0eeb0606afaf93574265e26e7bb2bd8]

        no no need to call QuickGetTextSize here
        
        when we only need the height
        
        Change-Id: I16d74cb6f68e3391b9857cc9702cc6f93b9fb9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [258a8d133d0548c7af51f4852260e9969df288fc]

        tdf#150034 very slow opening pathological chart
        
        This chart has a ridiculously long legend, which makes the loop that
        tries to shorten legends take an extremely long time.
        
        Make this loop faster, at the risk of sometimes getting a slightly wrong
        answer.
        Ideally we could speed up the layout down in ImpEditEngine, but that is
        a much bigger task.
        
        Change-Id: I7cb337c674515bac13e4b11c3b0fabb94aed6865
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137677
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-01  Colomban Wendling  <cwendling@hypra.fr>  [0185ddd6d5f0324ba57b3fa36229103a6b27138e]

        Add infrastructure and basic tests including slight UI interaction
        
        This introduces a couple helper base classes for implementing
        accessibility tests more easily, and includes a few tests as examples,
        including basic document layout check and minimal UI interaction
        through menus.
        
        Change-Id: I8961af8be1e7d52dc55fe27c758806d9b4c3c5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137337
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-01  Justin Luth  <jluth@mail.com>  [56d5a31d6ec2b45e43659be4b5fd4964de29e61f]

        tdf#150197 sw: convert pre-defined num styles to ListFormat
        
        Early in 7.x, allotropia introduced a generic list format string
        instead of prefix/suffix. Convert the pre-defined numbering
        formats to use that syntax as well.
        
        The problem was that ms export wasn't able to handle the
        old way of doing things any more.
        For example, if a user added numbering via
        the numbering style "Numbering 123",
        then on export the numbering string was lost.
        
        Change-Id: I11cd00280da2b464a9b00a5f0a8d72080f14e44c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137632
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>

2022-08-01  Jim Raykowski  <raykowj@gmail.com>  [f181399656a0d4273c4cb0579bd0917448c54ddc]

        tdf#116411 fix Navigate By Page Next does not move the expected next
        
        page into view
        
        Uses newly introduced GetFirstLastVisPageNumbers function which does
        not include pages having only visible bottom or top margins. This
        solves the issue of pages with bottom margin remnants in the view
        causing Page Next to not move the expected page into view.
        
        Change-Id: Iec05f132b39e1db92be5d13c7d4cc41072dddac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132373
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-01  Miklos Vajna  <vmiklos@collabora.com>  [60f9ca81e84f1bede4928c6f680325692cc8bc49]

        vcl: fix crash in vcl::ImportPDFUnloaded()
        
        Crashreport signature:
        
        SIG   Fatal signal received: SIGSEGV code: 1 for address: 0x0
        program/libmergedlo.so
                vcl::ImportPDFUnloaded(rtl::OUString const&, std::vector<vcl::PDFGraphicResult, std::allocator<vcl::PDFGraphicResult> >&)
                        vcl/source/filter/ipdf/pdfread.cxx:256
        program/../program/libsdlo.so
                SdPdfFilter::Import()
                        sd/source/filter/pdf/sdpdffilter.cxx:55
        program/../program/libsdlo.so
                sd::DrawDocShell::ConvertFrom(SfxMedium&)
                        sd/source/ui/docshell/docshel4.cxx:500 (discriminator 1)
        program/libmergedlo.so
                SfxObjectShell::DoLoad(SfxMedium*)
                        sfx2/source/doc/objstor.cxx:768
        
        Change-Id: I2fc635de696643af6a80a29aa5af4fa128f8776c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137673
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-01  Justin Luth  <jluth@mail.com>  [c315a8cc84551a7fa7c80fc4b5c046c62a246fe6]

        related tdf#150197 sw: NONE numbering still returns prefix/suffix
        
        Missing this has surfaced repeatedly during the refactoring
        of numbering. A code read suggests this is necesary here.
        
        I'm not sure how to test this,
        or how to trigger it.
        A make check never hits this situation.
        
        Change-Id: I1adc81968ebddbb36db9b4af551e5d3867016b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137635
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-08-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4b4c129e9f00189978cd7b71fd74d0dca4c9ebc]

        clang-tidy modernize-pass-by-value in ucb
        
        Change-Id: I641d05e360c3208845a2fa6721ac8ba1ad0f3309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137667
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [915f3959fe6b3e756b9797a9222b95d9b8c3d293]

        introduce SwPosition::GetNodes
        
        as part of the process of hiding the internals of SwPosition
        
        largely done by doing:
        git grep -lF 'nNode.GetNodes' | xargs perl -pi -e
        's/nNode\.GetNodes/GetNodes/g'
        
        Change-Id: I05ac253803ef3f265edfa9be6f24f8f66b2b02c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-08-01  Justin Luth  <jluth@mail.com>  [4f48bdf758239b7928586c40d9072c65e4633009]

        remove NOP in editeng: HOLDDEPTH
        
        The clause to get into this function already tells us that
        HOLDDEPTH is offf. The functions called in here do not
        turn it on, so there is no need to clear it at the end.
        
        This looks unchanged since initial import.
        
        I tested with an assert that the flags saved at the
        beginning of the clause were identical to the
        flags at the end, and ran a make check. No asserts.
        
        Change-Id: I28bc8725062895d94f387fa0780a16e40b4efe5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137541
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-08-01  Miklos Vajna  <vmiklos@collabora.com>  [f5882e84653a181744fa379996b76a65050beab4]

        sw: prefix members of SwBreakDlg, SwCondCollPage, SwDropCapsPage and ...
        
        ... SwDropCapsPict
        
        See tdf#94879 for motivation.
        
        Change-Id: I2aefa925964745680529815a729d3a60b29fc545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137666
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-08-01  offtkp  <parisoplop@gmail.com>  [0c31d7d0f296d63059b487fd55f8bd674d8a4dcc]

        Remove pngread/pngwrite from excludelist
        
        Change-Id: Ifc9a2c147a9c40db4b6c68c781f40b2790fd3b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137259
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [c793e850bce9d67dd43da30e1535b1d991e3ee9c]

        tdf#150064 Keep a11y child order intact
        
            commit 8f9fd6806ccfbf381a383efe5d143ead86ee49de
            Date:   Wed Jun 29 19:47:20 2022 +0200
        
                tdf#137544 reduce cost of ChildrenManagerImpl::Update
        
        had added sorting based on memory addresses of the
        corresponding shapes, but the order of the
        children in `maVisibleChildren` is expected
        to reflect the order of the accessible children
        (i.e. based on the child index of the corresponding
        shapes' a11y objects), since items are accessed by
        index (s. e.g. `ChildrenManagerImpl::GetChild`).
        
        Since the `ChildDescriptor`'s `mxAccessibleShape`
        reference can be empty, its child index also cannot
        be used for sorting instead.
        
        To prevent the a11y tree from becoming unstable/random,
        don't reorder/sort `maVisibleChildren`, but
        allocate a helper vector holding pointers to the items
        in the real vector, and iterate over that one instead.
        
        This also moves identification of the elements
        that are only in the old, but no longer the
        new vector to `ChildrenManagerImpl::MergeAccessibilityInformation`,
        where the sorted vector is availabe, and returns
        a vector of obsolete children that is then
        passed to
        `ChildrenManagerImpl::RemoveNonVisibleChildren`,
        instead of doing the comparison of the old/new
        vector there.
        
        Change-Id: Ie449f76f1b98ffe8e85ca28e938b11d726086721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137622
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Colomban Wendling <cwendling@hypra.fr>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-01  Michael Weghorn  <m.weghorn@posteo.de>  [7ccaca8dcaab5868987b78b6b2436872ac7f1129]

        tdf#150064 a11y: Swap old/new list before merging information
        
        Swap the old and new list before merging information
        from the old list to the new one, not afterwards.
        
        This also moves this into the block guarded by the
        SolarMutexGuard, which seems to be held primarily
        due to changes to `maVisibleChildren` going on, which
        may already be happening in
        `ChildrenManagerImpl::MergeAccessibilityInformation`
        since the elements in the vector can be reordered
        since
        
            commit 8f9fd6806ccfbf381a383efe5d143ead86ee49de
            Date:   Wed Jun 29 19:47:20 2022 +0200
        
                tdf#137544 reduce cost of ChildrenManagerImpl::Update
        
        This change is primarily in preparation of adapting what list(s) get
        sorted/reordered in
        `ChildrenManagerImpl::MergeAccessibilityInformation`
        in follow-up commit
        Ie449f76f1b98ffe8e85ca28e938b11d726086721,
        "tdf#150064 Keep a11y child order intact".
        
        Change-Id: I88bd27b6cbca1e7a03702fd7e75f4094bdb5f977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7bacf8e855c49c1883662229d7934dbca47dc2af]

        Fix typo in code
        
        Change-Id: I215eb41bc2e7f442b0dc37393460bd2e53fed8c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137646
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8df7947f49cd00c5432dfe565dba9788d88ff714]

        Fix typo
        
        Change-Id: Ic60f4ca995b4f6261a45d7d5ca7f6736b9308f37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137656
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [88e2ca99e0dcc892a0900d7c3ff3d2ca20bbf0b8]

        Fix typo
        
        Change-Id: Ic0f544eeb53c60d2d461c219e38b8fef30eac46e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137658
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1238170d165a3d6c55a792e49132f8c8098d21df]

        Fix typo
        
        Change-Id: Ib8aabe9fc514b8f2b834e2805b2e583fac250efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137655
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c04cfbfb92b2cb247e3f58785d3fc49086b25cc0]

        Fix typo
        
        Change-Id: I511caa41a696b2181b7691e15940ff7fe9b6f1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137657
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cbab78f901e2bb1ca9d8c1500ea308bda6146361]

        Fix typo
        
        Change-Id: I2e2f9bf41bbe0427ab39a1f1870bc5104cd88bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137654
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-08-01  Jim Raykowski  <raykowj@gmail.com>  [a0e09cf64eea663122043294b848ac1bb8f05ac9]

        tdf#149916 follow up to include expand field text
        
        in cross-reference entry text
        
        Change-Id: Iaff06e02d272bbe41e63da5356e6c9a6f67c26f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137665
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-01  Jim Raykowski  <raykowj@gmail.com>  [c4fa91bf5b64e052d22d910097f2aca270fb86dc]

        tdf#138868 SdNavigator: track object selected on canvas
        
        Change-Id: Ie28d0ee9482d0bcb4a0a8803e499af3bc0e816d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135084
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-08-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [74918534ee4243d2849f74c4eaf91eb610999413]

        Add 'JobName' to PrintOptions
        
        Allow users to specify a job name which is sent to the printer
        (by default this is the current document name).
        
        Usage:
          Sub PrintWithCustomJobname
            Dim mPOpts(1) As New com.sun.star.beans.PropertyValue
            mPOpts(0).Name = "JobName"
            mPOpts(0).Value = "My Job Name"
            ThisComponent.Print(mPOpts())
          End Sub
        
        Change-Id: Id7c1c0da7f581b1c050bb3e6d61dd01b7e8205f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137562
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-08-01  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [12b3cd8737e1d4ab76eb0eedee8790eb44b1e278]

        tdf#142628 Update icons for Field and Field by Type
        
        Change-Id: I0f369c0d7c426b6f8930f4d34d7e2130c71a06c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137647
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-08-01  Tünde Tóth  <toth.tunde@nisz.hu>  [f224cdfb3c264a339d3148c7c2936f3202015f7d]

        tdf#120972 DOCX: fix import of decimal tabulators
        
        Use locale specific decimal separator for decimal tabulators,
        because OOXML does not support custom decimal separator.
        
        Regression from commit c0b6aadedc9429eee4f4df85957e00e29ccb0c8f
        "(related: fdo#81033) writerfilter: default tab fill character is space".
        
        Change-Id: I9d89e5817707f3b39a1b718b732f6e289f7c6a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136846
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-31  Khaled Hosny  <khaled@aliftype.com>  [9a6b673699fa925f5d87e47d4b359f37ad27260e]

        vcl: Better kashida insertion position validation
        
        Use the new HarfBuzz glyph flag HB_GLYPH_FLAG_SAFE_TO_INSERT_TATWEEL if
        available to prevent kashida insertion where is would interrupt shaping
        (between contextual glyphs). Previously we only prevented it when there
        is a ligature across the insertion position, with this change fonts that
        use contextual alternate instead of ligatures will be handled better as
        well.
        
        Change-Id: Ibb42a310c1e7dbcb225a1ba3acac82154b4edb3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-31  Khaled Hosny  <khaled@aliftype.com>  [4e72f70c796fee9b0af6a526159143b5e70dcd11]

        Update HarfBuzz to 5.1.0
        
        Dropping negativeadvance.patch that was applied upstream.
        
        Change-Id: I8eba49d2d158c0c29911f4079315ed0bf87b7fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137648
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-31  László Németh  <nemeth@numbertext.org>  [64ac089ad5464c832592e050f5d51a136f533f21]

        tdf#150166 DOCX export: fix broken file with tracked ToC moving
        
        It seems, bookmark export always resulted unpaired bookmark
        elements around ToC sections without causing any interoperability
        problem, but replacing bookmark elements with moveRange (where
        needed) releaved the problem, resulting a file format issue in MSO.
        
        Skip export the unpaired moveRangeEnd elements until there is a
        better solution, i.e. exporting moveRangeStart elements also in
        paragraph-end positions before TOC sections.
        
        Note: for back-porting this is the best, i.e. simple enough to be
        stable and to get a quick review.
        
        Regression from commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving".
        
        Change-Id: I93de467b6a43b2dd3fa97defaef47993969bb7ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137623
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ccbfaaf95005a34ca64ad250463ef5ce8842f43]

        sc, out of order undo: allow multiple actions from other view
        
        this is the calc equivalent of
            commit c88c2d40d1a4aebc46b25368b80c02bc2f136658
            Date:   Fri Nov 12 08:39:35 2021 +0100
            sw, out of order undo: allow multiple actions from other views
        
        Change-Id: I5acbd1e1cacef7c2e2a549f4d2270e961f576a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-31  Caolán McNamara  <caolanm@redhat.com>  [730f6dac9eaad5b3ffda3032c184a671a9a16f72]

        Related: tdf#150196 can't change away from "indeterminate" state
        
        Change-Id: Iefa29d422eb810b4f1404bb9582fac508e1853f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [440f7c40d74628f2c211f637f1a6c8d20cf883ca]

        Fix typo in code
        
        Change-Id: Ica86f2c5043fd8f78e83d06778e4b0f468032474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137645
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-31  offtkp  <parisoplop@gmail.com>  [826fea9d77dbb7f4ea71f934bbe137008aa8b7f0]

        tdf#150201 Fix endianness for placeable WMF
        
        The constant PLACEABLE_SIGNATURE in graphicfilter2.cxx had wrong
        endianness, which would cause the WMF file detection to fail for
        placeable WMFs. Changed endianness since WMF files are in little endian.
        Also added test using placeable and non-placeable WMFs.
        
        To run the test:
        make CPPUNIT_TEST_NAME="testDetectWMF" -sr CppunitTest_vcl_graphic_test
        
        Change-Id: Ia3c61bae5ab27375636f21bc902f773804cf9273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137634
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0f195db61d3df5e34b82318115152a1103be17b9]

        Fix typo
        
        Change-Id: I75b3562ac1710c4eed32b916382ec4fff7ce7041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137644
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-31  Michael Stahl  <michael.stahl@allotropia.de>  [5a9fe1d80ea977c439dd10ee2056abe6b0cb4d07]

        tdf#145226 sw: ODF export: fix table-row/table-cell styles
        
        The SwFrameFormat for table lines and table boxes gets an auto-generated
        name in SwDoc::MakeTableBoxFormat()/MakeTableLineFormat().
        
        The problem is that xmltble.cxx assumes that these SwFrameFormats never
        have a name, and sets names on them temporarily during
        exportTextAutoStyles(), then later reads them when exporting the
        table-rows and table-cells, then eventually resets them all to an empty
        name.
        
        One issue is that it assumes that a non-empty SwFrameFormat name
        indicates a style has been exported, but that isn't always the case, and
        the name may still be an auto-generated one.
        
        Another issue is that overwriting the names interferes with the use of
        the names in Undo operations.
        
        So store the name for the ODF styles in members of the filter classes
        instead of the core model.
        
        (regression from commit 083fe09958658de8c3da87a28e0f8ff7b3b8a5e9)
        
        Change-Id: I9b17962decbf9f8ecd2a91551230cf0f012e7a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127548
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-31  Noel Grandin  <noelgrandin@gmail.com>  [80cdfe4512a66ab58e0ae27c9fafad601c2f84b2]

        sc, out of order undo: allow a subset of a non-empty redo list
        
        This is the calc analogue of
            commit 60665dc4a2af238939b1a5056ae4a4ce2c083159
            sw, out of order undo: allow a subset of a non-empty redo list
        
        Specifically, we used to not allow out of order undo at all if the redo
        list was non-empty. This relaxes that condition a bit. Out of order undo
        is OK with a non-empty redo list, in case all undo actions in the redo
        list are either
        
        1) owned by the current view or
        
        2) independent from the undo action to be executed
        
        I.e. if view1 has lots of type undo actions and an view2 adds a
        single type undo action on top of it, then allow view 1 to execute
        multiple of its typing undo actions, not just a single one.
        
        Change-Id: Ib7ab88e9ebbefce267d3c7d567debd1cd98d7d6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137628
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [93bea3531cff7f1e35a4c982836afbabfa587a6f]

        clang-tidy modernize-pass-by-value in writer*
        
        Change-Id: Ib08c971eb3e859e7b04cdd408af7966d83c2955b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137585
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-31  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [d75c5c1f61a174b3b333e9db6536ab15cc37d00b]

        tdf#149944 Do away with some excessive, unwarranted horizontal spacing
        
        Change-Id: I01e2e57dd85802eba1ab024ca3730ba30f311e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137642
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c114d1a2c2cfe244892846732f2d5f2c070889f]

        Fix typo
        
        Change-Id: I3cfb8f3daf8e670adc5fe29edb2e3b6ce2ace0cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137640
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c3ac0f80b7571190c14fb7f6a9887fe370c28e4a]

        Fix typo
        
        Change-Id: I8ebd08019541a22acfe763330c2579b9b5c4c7bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137638
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [10a213572bd9fd183710a0da68ce306b3d9b5317]

        Fix typo
        
        Change-Id: I55558e5252c238be2417d370040760ed9c450a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137641
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-30  Hossein  <hossein@libreoffice.org>  [67615c8461eccc031c1934863a94df6bf8269641]

        Improve vcl scheduler documentation
        
        * Fixed a heading problem
        * Marked variables, functions and identifiers as fixed width
        * Added several related links
        
        Change-Id: If5e56c1e2a474fcfa52601ccda7911bf9e80c913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137636
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-30  Caolán McNamara  <caolanm@redhat.com>  [0482f156a0ade16d55787ea2ca1c08404f9961e5]

        gtk4: convert AtkObject::accessible-role to something else
        
        we only use AtkObject::accessible-role for "static", but there doesn't
        seem to be a good match to anything I can see in gtk4. convert it
        to accessible-role of "alert" for lack of a better idea.
        
        Change-Id: Ic0795fed006b827914f1319150a915187188a4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137617
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-30  Noel Grandin  <noelgrandin@gmail.com>  [640a6488a32e8f682788feb6cab01acfffca7fa7]

        sc: allow undo of typing in 2 views independent from each other
        
        This commit follows the same pattern as
            commit c72e500ccaf0ce2261c5233b80fba9342778f810
            sw: allow undo of typing in 2 views independent from each other
        
        with some changes since calc and writer have different undo/redo
        infrastructure on top of SfxUndoManager.
        
        Change-Id: Ib6e7e21caccb94752c01c529b5013553dba8b4f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-30  Jim Raykowski  <raykowj@gmail.com>  [be32cb92103326da2c744bc85d82b9c788f4e98b]

        Assert downcast
        
        In this case it should be guaranteed that pField is a pointer to
        SwGetRefField by:
        
        else if (pField->GetTypeId() == SwFieldTypesEnum::GetRef)
        
        To follow best practice to allow some diagnostic in debug mode,
        assert(dynamic_cast) before using static_cast to downcast.
        
        Change-Id: Ib2c6fb4259b66d5059f1886e23d05fc1c2aa3682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137578
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-30  Hossein  <hossein@libreoffice.org>  [c2746a665656b61927bbf551b4723ccfae8fa9c8]

        Add help and list executables options for bin/run script
        
        bin/run script is described as:
        
        "simple wrapper script to run non-installed executables from workdir".
        
        When the bin/run script was used without parameters, it was generating
        error as it could not run the folder workdir/LinkTarget/Executable.
        Now, we print usage instructions in this case, or when help is
        requested with -h, -help or --help.
        
        Also, now user can get the list of executables with -l, -list or --list.
        
        In normal execution, the script's name is also printed. For example:
        
        $ ./bin/run minvcl
        Setting env variables and running workdir/LinkTarget/Executable/minvcl
        ...
        
        Change-Id: I5c62c300d5247f55d1d1cfd095cecffc979d494b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137626
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-30  Matt K  <mattkse@gmail.com>  [07250a832787acdd432dccd458536de2987a58b2]

        tdf#117967 Fixes Save confirmation dialog for user cancel
        
        The "Confirm save" dialog is launched from SfxMedium::CheckFileDate
        via "xHandler->handle( xInteractionRequestImpl );" and if the user
        canceled it the error is saved in the SfxMedium via
        "SetError(ERRCODE_ABORT);".  Then, control is returned to the
        calling function SfxObjectShell::SaveTo_Impl which currently
        doesn't handle the cancel error condition, so this change just adds
        a check to detect it and return instead of doing more "save"
        processing.  This return then goes to the calling function
        SfxObjectShell::DoSave_Impl which also does some save processing
        after cancel, in particular it updates the timestamps of the
        current SfxMedium (which are checked in SfxMedium::CheckFileDate
        from above and determines whether the "Confirm save" dialog will be
        launched), so this change prevents the updates to the timestamps by
        exiting early (i.e. before "DoSaveCompleted();" is called) if the
        abort error condition is seen so as to avoid a timestamp comparison
        result of equality which would prevent the "Confirm save" dialog
        from showing on every subsequent save action from the user.  Now
        the behavior is for the timestamp comparison to fail equality (as
        would be expected if the file changed underneath the user) so as to
        ensure the "Confirm save" dialog continues to show for every
        subsequent save action by the user.
        
        Change-Id: I9c4aefc163a06029c80a8a28cdf4a09dff0031a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137540
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-07-30  Jim Raykowski  <raykowj@gmail.com>  [45312369331688bde9d1b8c97ad883a69e5982d7]

        tdf#149467 fix re-entrance crash
        
        This crash is caused by an odd re-entrance happening. In this case
        re-entrance to SwContentTree::UpdateTracking happens when
        SfxHintId::DocChanged is broadcast from SwDocShell::SetModified when
        GetContentAtPos is called from SwContentTree::UpdateTracking which
        eventually causes a stack crash.
        
        Getting model position for view point when getting content at
        position (GetContentAtPos call to GetModelPositionForViewPoint)
        shouldn't set the document modification state. Which is what happens
        using the steps to repro this crash.
        
        This patch disallows setting document modification state during the
        DocumentStylePoolManager::GetFormatFromPool call from
        SwTextINetFormat::GetCharFormat.
        
        backtrace of last 100 levels before crash:
        
        1   SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
        551  0x7fffbddbde96
        2   SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
        665  0x7fffbddbe891
        3   SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        4   SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        5   SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        211  0x7fffbdcf6f2f
        6   SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        452  0x7fffbdcf7fa0
        7   SwCursorShell::GetContentAtPos                      crstrvl.cxx
        1370 0x7fffbd581050
        8   SwContentTree::UpdateTracking                       content.cxx
        3700 0x7fffbe9864a0
        9   SwContentTree::TimerUpdate                          content.cxx
        3589 0x7fffbe985474
        10  SwContentTree::Notify                               content.cxx
        3047 0x7fffbe9811ad
        11  SfxBroadcaster::Broadcast
        SfxBroadcaster.cxx           40   0x7ffff4180f32
        12  SwDocShell::SetModified                             docsh2.cxx
        1446 0x7fffbe53b663
        13  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
        1150 0x7fffbe52d660
        14  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
        1131 0x7fffbe52d597
        15  Link<bool, void>::Call                              link.hxx
        111  0x7fffbd8889f5
        16  sw::DocumentStateManager::SetModified
        DocumentStateManager.cxx     50   0x7fffbd888729
        17  SwDoc::MakeCharFormat                               docfmt.cxx
        861  0x7fffbd6ef2b8
        18  SwDoc::MakeCharFormat_                              docfmt.cxx
        883  0x7fffbd6ef43a
        19  sw::DocumentStylePoolManager::GetFormatFromPool
        DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
        20  sw::DocumentStylePoolManager::GetCharFormatFromPool
        DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
        21  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
        144  0x7fffbdfa1a03
        22  SwTextINetFormat::GetCharFormat                     txtinet.hxx
        52   0x7fffbddb4f4e
        23  CharFormat::GetItemSet                              atrstck.cxx
        145  0x7fffbddb07e5
        24  SwAttrHandler::PushAndChg                           atrstck.cxx
        345  0x7fffbddb1047
        25  SwAttrIter::Chg                                     itratr.cxx
        102  0x7fffbddf02db
        26  SwAttrIter::SeekFwd                                 itratr.cxx
        296  0x7fffbddf1104
        27  SwAttrIter::Seek                                    itratr.cxx
        419  0x7fffbddf17b3
        28  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
        158  0x7fffbddf06e2
        29  SwTextIter::SeekAndChg                              itrtxt.hxx
        313  0x7fffbde01791
        30  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
        1658 0x7fffbddff83f
        31  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
        604  0x7fffbddbe337
        32  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
        665  0x7fffbddbe891
        33  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        34  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        35  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        211  0x7fffbdcf6f2f
        36  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        452  0x7fffbdcf7fa0
        37  SwCursorShell::GetContentAtPos                      crstrvl.cxx
        1370 0x7fffbd581050
        38  SwContentTree::UpdateTracking                       content.cxx
        3700 0x7fffbe9864a0
        39  SwContentTree::TimerUpdate                          content.cxx
        3589 0x7fffbe985474
        40  SwContentTree::Notify                               content.cxx
        3047 0x7fffbe9811ad
        41  SfxBroadcaster::Broadcast
        SfxBroadcaster.cxx           40   0x7ffff4180f32
        42  SwDocShell::SetModified                             docsh2.cxx
        1446 0x7fffbe53b663
        43  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
        1150 0x7fffbe52d660
        44  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
        1131 0x7fffbe52d597
        45  Link<bool, void>::Call                              link.hxx
        111  0x7fffbd8889f5
        46  sw::DocumentStateManager::SetModified
        DocumentStateManager.cxx     50   0x7fffbd888729
        47  SwDoc::MakeCharFormat                               docfmt.cxx
        861  0x7fffbd6ef2b8
        48  SwDoc::MakeCharFormat_                              docfmt.cxx
        883  0x7fffbd6ef43a
        49  sw::DocumentStylePoolManager::GetFormatFromPool
        DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
        50  sw::DocumentStylePoolManager::GetCharFormatFromPool
        DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
        51  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
        144  0x7fffbdfa1a03
        52  SwTextINetFormat::GetCharFormat                     txtinet.hxx
        52   0x7fffbddb4f4e
        53  CharFormat::GetItemSet                              atrstck.cxx
        145  0x7fffbddb07e5
        54  SwAttrHandler::PushAndChg                           atrstck.cxx
        345  0x7fffbddb1047
        55  SwAttrIter::Chg                                     itratr.cxx
        102  0x7fffbddf02db
        56  SwAttrIter::SeekFwd                                 itratr.cxx
        296  0x7fffbddf1104
        57  SwAttrIter::Seek                                    itratr.cxx
        419  0x7fffbddf17b3
        58  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
        158  0x7fffbddf06e2
        59  SwTextIter::SeekAndChg                              itrtxt.hxx
        313  0x7fffbde01791
        60  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
        1658 0x7fffbddff83f
        61  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
        604  0x7fffbddbe337
        62  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
        665  0x7fffbddbe891
        63  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        64  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        65  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        211  0x7fffbdcf6f2f
        66  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        452  0x7fffbdcf7fa0
        67  SwCursorShell::GetContentAtPos                      crstrvl.cxx
        1370 0x7fffbd581050
        68  SwContentTree::UpdateTracking                       content.cxx
        3700 0x7fffbe9864a0
        69  SwContentTree::TimerUpdate                          content.cxx
        3589 0x7fffbe985474
        70  SwContentTree::Notify                               content.cxx
        3047 0x7fffbe9811ad
        71  SfxBroadcaster::Broadcast
        SfxBroadcaster.cxx           40   0x7ffff4180f32
        72  SwDocShell::SetModified                             docsh2.cxx
        1446 0x7fffbe53b663
        73  SwDocShell::Ole2ModifiedHdl                         docsh.cxx
        1150 0x7fffbe52d660
        74  SwDocShell::LinkStubOle2ModifiedHdl                 docsh.cxx
        1131 0x7fffbe52d597
        75  Link<bool, void>::Call                              link.hxx
        111  0x7fffbd8889f5
        76  sw::DocumentStateManager::SetModified
        DocumentStateManager.cxx     50   0x7fffbd888729
        77  SwDoc::MakeCharFormat                               docfmt.cxx
        861  0x7fffbd6ef2b8
        78  SwDoc::MakeCharFormat_                              docfmt.cxx
        883  0x7fffbd6ef43a
        79  sw::DocumentStylePoolManager::GetFormatFromPool
        DocumentStylePoolManager.cxx 1514 0x7fffbd89132c
        80  sw::DocumentStylePoolManager::GetCharFormatFromPool
        DocumentStylePoolManager.cxx 1718 0x7fffbd892d86
        81  SwTextINetFormat::GetCharFormat                     txtatr2.cxx
        144  0x7fffbdfa1a03
        82  SwTextINetFormat::GetCharFormat                     txtinet.hxx
        52   0x7fffbddb4f4e
        83  CharFormat::GetItemSet                              atrstck.cxx
        145  0x7fffbddb07e5
        84  SwAttrHandler::PushAndChg                           atrstck.cxx
        345  0x7fffbddb1047
        85  SwAttrIter::Chg                                     itratr.cxx
        102  0x7fffbddf02db
        86  SwAttrIter::SeekFwd                                 itratr.cxx
        296  0x7fffbddf1104
        87  SwAttrIter::Seek                                    itratr.cxx
        419  0x7fffbddf17b3
        88  SwAttrIter::SeekAndChgAttrIter                      itratr.cxx
        158  0x7fffbddf06e2
        89  SwTextIter::SeekAndChg                              itrtxt.hxx
        313  0x7fffbde01791
        90  SwTextCursor::GetModelPositionForViewPoint          itrcrsr.cxx
        1658 0x7fffbddff83f
        91  SwTextFrame::GetModelPositionForViewPoint_          frmcrsr.cxx
        604  0x7fffbddbe337
        92  SwTextFrame::GetModelPositionForViewPoint           frmcrsr.cxx
        665  0x7fffbddbe891
        93  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        94  SwLayoutFrame::GetModelPositionForViewPoint         trvlfrm.cxx
        168  0x7fffbdcf6c08
        95  SwPageFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        211  0x7fffbdcf6f2f
        96  SwRootFrame::GetModelPositionForViewPoint           trvlfrm.cxx
        452  0x7fffbdcf7fa0
        97  SwCursorShell::GetContentAtPos                      crstrvl.cxx
        1370 0x7fffbd581050
        98  SwContentTree::UpdateTracking                       content.cxx
        3700 0x7fffbe9864a0
        99  SwContentTree::TimerUpdate                          content.cxx
        3589 0x7fffbe985474
        100 SwContentTree::Notify                               content.cxx
        3047 0x7fffbe9811ad
        
        Change-Id: I7e0814cf3a42dc876dd60c926d4b2245a036cc3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135802
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-07-30  Jim Raykowski  <raykowj@gmail.com>  [d87f69cc7e5a6f5c8a79075fed343a14675f3a5d]

        tdf#118696 better fix for sd Navigator object selection
        
        resulting in unexpected view movement
        
        This fix reverts commit 3c86ffd8ded628e6f2b4187948a1b1056f6a0f56 and
        reintroduces DrawViewShell::MakeVisible with change made to the
        passed object rectangle always being the snap rectangle instead of
        the rectangle returned from a call to object GetLogicRect.
        
        Change-Id: I05e777545fb1093838c05618e87ad4d4f5ec003c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137008
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [597d21d0d03b3dd229f725b4106c5df7cecb65d6]

        Fix typo
        
        Change-Id: I1b6c7eccebffc80b057eb2730428b20047ee685b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137625
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d4809b45c15b5722f33facc4a76ee61f6784fc6d]

        Fix typo
        
        Change-Id: Ic4929dd699b4b28572e46c99ce49d95371b54bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137624
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-30  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [1bdd72e2d7f4cd5d438646a1ac1aeade9432ec96]

        tdf#150045 Set secondary/explanatory labels apart
        
        Rationale in commit 0ebbe1f0080f474fd583e5912c9605e6fb2e13d5,
        of which this is a follow-up.
        
        Change-Id: If75aa32bf02aeb8761f5b7f4ddbbeaa3bdcaab3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137618
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [bee22fd4333408f341ee377fe52f0b1b6dbf76a0]

        Verify signing certificate cryptographically before use in tests
        
        Documents signed using an invalid (e.g., not having a trusted root)
        certificate give signatures that obviously can't pass validity tests.
        
        Change-Id: Id4b097516e06c548ea42cad65d76bbd8a6853cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137620
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [d6c6fee69c1457e029095ef93779d971bc89c39d]

        Resolves: tdf#147782 restore focus to launching frame asynchronously
        
        Change-Id: I7ebde70e4e1aae861f6ac7d70a91741596cb2cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [275e05cc232b1dc39645f9444ee98932fb3ded58]

        gtk4: update vcl when popup was closed by some external means
        
        Change-Id: Ie580cd0b42ca1c928bfea20a4a9f1494021047d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137560
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [ed4bf43b0b75b26fea236204bf4fedfc7568eb98]

        cid#1507489 Big parameter passed by value
        
        and
        
        cid#1507490 Big parameter passed by value
        
        Change-Id: I53a8ee3fd0312de6fecd39238eff90cfff5b3261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137588
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [09607592b9fb0a7346e8dd2175adf15ace2d24dd]

        cid#1507491 cut and paste typo triggering 'Constant' variable guards dead code
        
        Change-Id: I9b833575f3cc3ba886b355eefdfa9155d2dffae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137587
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-07-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ce2003a672c410e9cd47bb6580688eee57165d7c]

        svx: manipulate SdrObject::m_aOutRect indirectly
        
        Change-Id: I0d8a8e4df06595250c07a61181fbd76fe1da5662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137571
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f1436b235c02a4bfda001208cbe712c2b457acfa]

        svx: remove using namespace and unneeded "css::" ns declarations
        
        Change-Id: If2eb5f61798e4efbcc845957fc1345b1560bcbe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137570
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [7321db3cadc8c0e4437ca04e5dcb652734ea9c26]

        Related tdf#117276 sc: Show hidden filter elements as inactive elements
        
        Ignoring filtered-out value when we unselecting All, re-selecting All button,
        hitting the Cross-button ("Hide only the current item") or hitting the
        Check-button ("Show only the current item").
        
        Followed up commit of 2d1df9f3dccc10f13b8585ad18afce1542ebc4d1
        
        Change-Id: I33e169a08054f1afec887915730eeae9a26d4739
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137558
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [3777a1e769913460ecc818988df8fc57829d7113]

        cid#1507492 Improper use of negative value
        
        Change-Id: I7c44307917df3397cfc9c99a982c54f51693e660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137589
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  nazanin yadi  <nazanin.yadi02@gmail.com>  [12f2622a6941dca7f376e0c0e25d89623580ca0d]

        tdf#87605 Add new words to technical dictionary.
        
        Change-Id: Ic9eaf11c75f91812d3feb839f47e0898e12d65e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135455
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [8fc338f2afb9abb75f9b7c0a2d442f7d4f1b2a40]

        Better valid certificate check, consider filter data
        
        Otherwise, testSignCertificateSubjectName that has an explicit certificate
        subject name requirement would fail when user has other valid certificates,
        but not this one.
        
        Change-Id: Ic3c440a8316314c922a53a51085a3e829f235f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137593
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e3b3a9bd5370c68877d7d6abe97043460a687ca]

        tdf#119840 make this loop a little more efficient
        
        by breaking out early
        
        Change-Id: I2444c9f8b79e0b517eb3ab3b19fed2d98c52a8e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [3df5be9210ec0a057567f7f68aac445a77facb71]

        use more SwPaM::StartEnd
        
        which is more efficient than calling Start() and End() separately
        
        Change-Id: I41c99527bcb37728bb9a87f63ed654e0be3d1f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137614
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [af65e892dcf729a4b65198379d2155163460bf5e]

        clang-tidy modernize-pass-by-value in xmlreader
        
        Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-29  Julien Nabet  <serval2412@yahoo.fr>  [baf433a2f77082b12e111bfd4d60ba372e339be1]

        tdf#150187: Crash in Presentation Styles - Background objects - Modify
        
        Regression from e85b482df3fa01e5a2b549df63db96cc49f1ca78
        (use SfxItemSet::GetItemIfSet in cui)
        
        Change-Id: I74889f21f2bda248946269b0caf5ddc629002ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137580
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [047305b1dcf2a1c9cdc62c8ecd8079db4b994fcb]

        gtk4: add an initial placeholder image to flag there will be one set later
        
        Change-Id: Ib1696b16990d3ae08fd2be10cc9fe89322287369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137576
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  Caolán McNamara  <caolanm@redhat.com>  [276bd8005c4a0cc006a306c5f8d1eccdf9e8fa2c]

        resave with latest glade
        
        Change-Id: Ic47dd35a859723895d25ffa210d8cc8971c28e0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-29  Balazs Varga  <balazs.varga.extern@allotropia.de>  [fe2d59a0730e60c0196baa46af12440afd343878]

        tdf#150100 sc import and UI: fix double cell border dialog
        
        Hide "Hairline (0.05pt)", "Very thin (0.5pt)" and "Thin (0.75pt)"
        predefined border types for Double cell borders, because it has a
        minimum thickness 1.1pt, which means, we cannot allow to select them.
        Also setting the Medium (1.5pt) predefined thickness to the border
        width for Double borders as the thinnest possible predefined value.
        
        TODO: tdf#146466: Inconsistent choices of borders between toolbar and sidebar
        
        Change-Id: I46ccb206835a34a6dfaa39e63e614bb01bc6b02e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137441
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f61276dae10fdaf2ed33ab23d98adbe311cb7ee]

        svgio: Add support for clip-rule="evenodd"
        
        Change-Id: I028aa88bdd72b4f87526a3d1edabd612d7686571
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137577
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-29  Julien Nabet  <serval2412@yahoo.fr>  [d07f18e0c3f8d50deea643c0ecab171795bd1231]

        tdf#126754: Wrong OpenType tag for fractions in "font features" dialog
        
        Opentype defines only "frac" and not parameters values like 1 or 2 for "frac"
        
        See:
        https://en.wikipedia.org/wiki/List_of_typographic_features
        https://docs.microsoft.com/en-us/typography/opentype/spec/features_fj
        
        So remove STR_FONT_FEATURE_ID_FRAC_PARAM_0/1/2
        + remove the extra ":" for STR_FONT_FEATURE_ID_FRAC
        
        I gave a try with "Alegraya" font, it worked.
        I also give a try with "Linux Biolinum G", there are still "None" (value "0"), "Diagonal fractions" (value "1") and "Nut fractions" (value "2").
        It seems they're on the font itself like entry "'frac' Diagonal and nut Fractions".
        
        So it shouldn't bring regression.
        
        Change-Id: I2f46a3f4a53dc498b764dbeb1c1266589cc8d8c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137574
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [9507e96153cea750c6582f05a98af174270bdf33]

        svgio: qa: add unittest for fill-rule
        
        Change-Id: I76c0594d634c4154bd2b63027e93934b521998d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137573
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-29  Justin Luth  <jluth@mail.com>  [fd428245bf180bb4ecc0486110aeeca091aa8403]

        tdf#148810 ppt import: Depth set by EE_PARA_OUTLLEVEL
        
        It isn't enough to set Paragraph->SetDepth.
        It must match the property set.
        
        Change-Id: I96a22057c57ae869542b4ffbc069a7cd89bb06c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137543
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-29  Justin Luth  <jluth@mail.com>  [be39a3d8c1bf9b134839a90e52ccabb2101421f4]

        Revert "tdf#141652 partial revert "Reset ShapeProperty priority..."
        
        This reverts 7.4 commit 18cc1240565e697859dd7d17058f91d5e01df929.
        
        Someone backported it to 7.3 as well.
        
        Change-Id: Ie04595e11dd9d2e15fa940b8ada71714bd434f6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137581
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [cca8a1935197554a3ae22f448b15800eb12a700d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fbbbb4dedd4e42ed16056ba9c98a829601f61833
          - Improve description of how to invoke Documents and Calc SF services
            
            Change-Id: Id9b9cc379bd838bdbae882554c8320f30595453e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137416
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-07-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [89c7f5c5a8898ee2dcb0c738e8ce026e5b238ea5]

        oox export: export line/fill and text props. of a data table
        
        Change-Id: I02a4c35693b599578e073d52a2d22ad59bc31786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137409
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [67ed7f8e2da59211ac938f5ba84c31fbd812759c]

        pdfium: fix build on windows aarch64 - no __popcnt
        
        see https://docs.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics
        
        Change-Id: I291f727c1aa6e00d02d2339fcb338159ae49d0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137568
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-28  Caolán McNamara  <caolanm@redhat.com>  [eaa0954fbf455ad7a71c011406e382ee7f7a8018]

        gtk4: don't attempt to create a visual junction between float and launcher
        
        the alignment won't match when using GtkPopover to implement these,
        there's an extra border+margin between the launcher and the contents
        
        Change-Id: Idb78d903874fee5a28e87c89951d9b3f9063c547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137554
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [756ff6f6dfb24048c43b682a95241d5548a1bb8f]

        vcl: Animation - cleanup pause functions and fields
        
        Change-Id: I8a338a92823bd4e4c1f8123d52711d0925357ee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76430
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-28  offtkp  <parisoplop@gmail.com>  [a697296097a55a03189e97f93ce540819f42057a]

        Use bitmap width instead of scanline size in combineScanlineChannels
        
        Change-Id: I9f5de7ed1bdcd39e5d6e580a2edbd5c0dd2027e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137278
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [2732115080036e4333fd025ca00396b3ff48c624]

        tdf#143148 tools: Use pragma once instead of include guards
        
        Change-Id: Ie34bc66eb1dc475566b315db698976913c8aa37b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137390
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c2ae836aa6125e995f86985557c006c837a19bd]

        chart2: set the char props. to the cells of a data table from model
        
        This copies the char. properties from the model to the cells of
        a data table, so the correct char width, font is used for text
        when the table is rendered. Also add margin to the text, so it
        looks better.
        
        Change-Id: Ib74a8136459a31d64a86dec36a6ba14d2c313cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137408
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-28  Michael Stahl  <michael.stahl@allotropia.de>  [0dcebde891619b4dcb4c0d170b3b5919ac6750c8]

        tdf#150181 vcl: first column is editable by default in SvTabListBox
        
        (regression from commit fe38553aef2121f358fb58e450ec69314aad851e)
        
        Change-Id: I58e1afb228dfd87b7d642ccf1b58277960f01e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137561
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-28  Michael Meeks  <michael.meeks@collabora.com>  [a71a5cdb972174cb7c33e67927cd519152fd3cf6]

        lok: add dumpState feature for better in-field diagnostics.
        
        Always suspicious that some un-expected dialog / state can cause
        strange behavior in a client. An initial cut at an API to make it
        easier to unwind such problems by exposing the toolkit state.
        
        Change-Id: If8f17943fa4837df4f9ca659a111dcdce5c23244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137504
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-07-28  Justin Luth  <jluth@mail.com>  [2b0626e2e9d112280e9d9a296cc7d7ba3022bdc9]

        remove unused SETBULLETTEXT flag in editeng
        
        Already unused in initial import.
        
        Change-Id: I423442a2b036c64727af608fa667f1f8a427391f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137542
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-28  Julien Nabet  <serval2412@yahoo.fr>  [d39a6726b8583086215a4452ce6867eb20c118d8]

        tdf#119246: Dimensions dialog has wrong values in several fields
        
        Regression from a8dd49b9fc59371ff8edb31082bbd4f1b6179b1c
        Convert dimension lines tab page to widget UI
        
        Min and max should be -10000 and 10000 (in mm).
        
        Change-Id: I936857f4c10bd2b6fec7b0e492c069b88cc071dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137553
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [156073b6ed57424da685bd141ee366bd4467c4e0]

        these classes can be final
        
        Change-Id: I84bb39b6365e445998a793798279c7f9f1064581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [031da439aca27c031bf122a837ee53d074c75358]

        tdf#119840 elide some allocations
        
        Change-Id: Ibff6a80a65463641337dc30d88c7ee8432cf816c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137551
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-28  Caolán McNamara  <caolanm@redhat.com>  [b87ac05be8855275b9c5dd48770a1f52b8e8f966]

        gtk4: use GtkPopovers to replace popups
        
        still a bit rough, but functional at least
        
        Change-Id: I4b5f896a0d895ed20da3534173c20241a7fe7ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137510
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [44a11bb8c99e02ac3ac16b405377ea61ffa8841b]

        clang-tidy modernize-pass-by-value in xml*
        
        Change-Id: I9bd5f6adfd138c391d76aebfe08ba01e6b3ab3bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137550
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-28  Rene Engelhard  <rene@rene-engelhard.de>  [7091a5416e6e1d5ff8c3b40646de30fe1458db24]

        work around rounding difference on i386 in descriptiveStatistics test
        
        No idea why this only appears now, but:
        
        ======================================================================
        FAIL: test_descriptive_statistics (descriptiveStatistics.descriptiveStatistics)
        ----------------------------------------------------------------------
        Traceback (most recent call last):
          File "/home/rene/tmp/autopkgtest-lxc.4j23khs6/downtmp/build.zIT/src/sc/qa/uitest/statistics/descriptiveStatistics.py", line 108, in te
        st_descriptive_statistics
            self.assertEqual(round(get_cell_by_position(document, 0, 6, 10).getValue(),14) , 0.01524095329036)
        AssertionError: 0.01524095329035 != 0.01524095329036
        
        Change-Id: I496daf61a9542ea0da78e6092dd7070a2665ab0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127363
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [54f86db0c9267825e9283c523e990dfe71bf3fc9]

        tdf#119840 reduce OUString allocation
        
        this is hit fairly hard when iterating over the document
        
        Change-Id: I08050fc3262ab1951c1800e6daedb720b1f216df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137537
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [28dc1e713cfc5b5ea38e15f032aba72d05e40b33]

        tdf#119840 remove some OUString allocation
        
        Change-Id: I488db37b3a60feb351d1ecd46278f6d5c3cdde5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [7ba40c7d62c7c15f9c0e9cbc21b48f105454b885]

        lok: Properly update sidebar context in Math
        
        Change-Id: I830c0d9bdeaa6340283eafc3e91251d02602d7aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137247
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [30e08c83e502562966351f4236e9dd9230ffa435]

        lok: Enable sidebar in Math
        
        Change-Id: I1554a924eef0bfcaffa893057a37ef45321a0cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137246
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [2fc16dc84d0b1b1bd7978a30e1b79ff3100fefdf]

        Enable Math sidebar panels for JSInstanceBuilder
        
        Change-Id: I9c71dd3cad1e45d0a01ab187c652711c19fe3b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-27  Caolán McNamara  <caolanm@redhat.com>  [20cc897dddb8ae7cee3c6d66e9cebba9da543c3a]

        gtk4: for gtk4 set the size of both layers of the overlay
        
        the size request for the overlay comes from its main child, the drawing
        area in this case
        
        Change-Id: If814aaa1d1fc38b331b18f5e9685c405d4f0d1b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137509
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-27  Eike Rathke  <erack@redhat.com>  [3172472aa749defc68f51e3436a089f49a496e8b]

        Unnecessary to remember mbFiltering at column, tdf#140968 tdf#140978 follow-up
        
        It's inviting confusion and only needed for FilterEntriesHandler,
        so pass it there.
        
        Change-Id: I8056bf8e8f563b28358c46b19071e7caa69c88a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137513
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-27  Miklos Vajna  <vmiklos@collabora.com>  [4e329f50e42c91704b84b1fc583d6815ab22adab]

        tdf#148291 sw clearing breaks: fix RTL layout
        
        The bugreport has two documents that show clear=left and clear=right is
        basically ignored in Word in the RTL paragraph case, while clear=none
        and clear=all work as expected.
        
        There was no special-casing for RTL in SwBreakPortion::Format()
        previously, as the OOXML spec does talk about left/right even in case of
        RTL, i.e. no expected mirroring is documented as the behavior. Looking
        at [MS-OI29500], "2.1.528 Part 1 Section 17.18.3, ST_BrClear" does say
        that the Word "behaves unpredictably" in the normal (non-web) layout.
        
        Fix the problem by handling clear=left and clear=right as clear=none in
        the RTL case, this fixes the rendering differences for both
        bugdocuments.
        
        If later we do want the mirrored layout, then such mirroring could be
        done in SwTextFly::GetMaxBottom().
        
        Change-Id: I6265e64540fa9e5b893cfbea146152854416dce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137507
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-27  Eike Rathke  <erack@redhat.com>  [2085e90fe8ac129bc4dbac4612d1ea7544335dae]

        FilteredRow is not a property of the column, tdf#117276 follow-up
        
        It's only needed in the FilterEntriesHandler, so pass it there.
        
        Change-Id: I5554ad13a43ccce6aafbba82b33418f060173a43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137512
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-27  Eike Rathke  <erack@redhat.com>  [19533948370dc1ccd7334dbe1a8b7fc8330b10c0]

        Name FilteredRow what it is, not hidden; tdf#117276 follow-up
        
        Also avoid defaulted parameter, it's only one more place to
        change.
        
        Change-Id: I64468fcd7085eff7a49bd0c359fdf14a31058af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137511
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d5e922f0864b88ff44c49e75f984e96659171771]

        tdf#119840 Store pointer to redline
        
        in SwContentIndex, so we can walk the sw::Ring of SwContentIndex attached
        to a SwContentNode, which is considerably faster than scanning
        the redline array.
        
        Shaves 10% off load time
        
        Change-Id: I98c9815d98846862280f5a2b0a656667cf63f05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137438
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-27  Michael Stahl  <michael.stahl@allotropia.de>  [baf8d2c1c16cb3bdc4edad2560f95fea807a034f]

        sw: delete bookmark if paragraph is fully selected
        
        testTdf96479 requires inserting with absorb=true to be treated as
        Replace, and there is of course no string in insertTextContent().
        testDeleteFlyAtCharAtStart requires setString("") to be treated as
        Delete.
        
        Annoyingly this requires API setString() call to be replaced with
        internal call, do this for SwXTextRange and SwXTextCursor which are
        the 2 classes typically used in practice.
        
        Change-Id: I87caa1aa11abe298cdd3d9a9bbb602e547c7b443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137370
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-07-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [316e4c01f4056242b82047808169c78692a3d9e3]

        tdf#119840 elide some dynamic_cast
        
        Change-Id: Iafaedf26231bac142759d2bf667dfba083cf0122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-27  Michael Stahl  <michael.stahl@allotropia.de>  [c7a76952b6fa0e6688028047726ac794fdd5cca3]

        sw: SolarMutexGuard missing in SwXBookmark::setPropertyValue()
        
        Change-Id: I41187b02e6b0545529e2a2c5b07da671eae89079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137506
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-07-27  Colomban Wendling  <cwendling@hypra.fr>  [d6ce547a1a24379bf1783387e22cbf8d39866757]

        Better report unknown constant names by including their values
        
        Change-Id: Id93dedf39ad0e2d1968e80878dd1a1bb07d94b61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137336
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-27  Colomban Wendling  <cwendling@hypra.fr>  [98180644fe2125027dc3a5df637618d717a54e86]

        Don't use magic numbers or off-range enum values
        
        Stop using magic numbers standing for enumeration items.  It makes the
        code clearer, and this test is not here to verify the API stays stable
        but that the semantics are correct so there's no need for magic values.
        
        Also don't use placeholder values outside the enumeration range and
        replace them with the legitimate and pretty appropriate INVALID value,
        which has the same effect in the context of this test, and avoids
        abusing the APIs.
        
        Change-Id: Ib5c9d768ba83470d41c65e00ebe3e8878ce32f3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137505
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-07-27  Caolán McNamara  <caolanm@redhat.com>  [8e5c1982c41c234027245fe2da6bf9bc3f5fe238]

        tdf#108560 horribly slow to paste many lines into editeng with a11y active
        
        looks to me that once the bound rect (and visible children) are synced
        that they won't change again so continued recalculation of bounds
        doesn't achieve anything except super expensive calc for no effect.
        
        Change-Id: I1684e3724bca28d03f7c255c2d7a40eee1b70eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137497
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-27  Colomban Wendling  <cwendling@hypra.fr>  [150f89d3b39fd062af56e21aa6d185758af67c0e]

        Fix comparing some Writer objects
        
        Offscreen objects in Writer are not exposed as children of their
        parent, but might be reachable through relations. In this case, similar
        objects can easily be mistakenly deemed equal (e.g. empty paragraphs
        will have the same role, empty name and description, etc.).
        
        Try to avoid this by taking into account the object's relations, which
        should at least have different targets if they are not the same.
        
        Change-Id: Ie6e1aaf388006b76d014ba2bd26aabef88d7dd6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137335
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-07-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [50c480bc1f68bc681fe369e0cb002a8f5b51843a]

        chart2: add char properties to the DataTable model
        
        Change-Id: Ie4b49f36def7d20f89695157c3b95e6ee5d16d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137407
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-27  Miklos Vajna  <vmiklos@collabora.com>  [db4ac0542a33ba2ff4e64717ca1eb6de563f1a8c]

        sw content controls, plain text: send state changes to LOK
        
        This is similar to commit 373f655acbdad88ff5d76324f32650fe3a005e2e (Send
        state changes of content control UNO commands to LOK, 2022-07-22), but
        plain text was not a type at that point.
        
        Change-Id: Ia317c60411280c07e1e063ee4b23f12e0d9f6dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137502
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-27  Caolán McNamara  <caolanm@redhat.com>  [9d777ef254330bb3d6af06e62ba602fe17824db9]

        gtk4: don't use an arrow for the gtk3->gtk4 menus
        
        this was the clipboard dropdown matches the save one
        
        Change-Id: I423aeed097cd22d48aa9efcaf95e0e8d6fd36d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-27  Caolán McNamara  <caolanm@redhat.com>  [1b517e049001b856e8043c6892a4819709b8efcf]

        gtk4: fill in more of this menu related stub
        
        Change-Id: Ia646d6f98804ffbec1177d5964550708588ce88f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-27  Julien Nabet  <serval2412@yahoo.fr>  [4d855bb916bd41221e2b23d6d782e19b4b2740f9]

        tdf#150089: not all databases know "RESTART WITH"
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit
        tdf#119962 Fix autoincrement for copied table
        in 2021
        
        so use the block added in the patch only when detecting "hsql" or "firebird"
        in the string returned by getDatabaseProductName put in lowercase
        
        Change-Id: Ic35a03039e6d06846892d93d5b30186c53f24052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137499
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-07-27  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [772f7a2dc3508bdebb53b6de4a43685d517cf1ef]

        tdf#150161: senddoc: use corrected name url: original can be a file path
        
        ...and in this case file name will be not parsed and --attach-name
        parameter will be empty. This leads to missing file name of
        attachment. In case of Thunderbird it is not a big problem,
        but Outlook does not want to attach .tmp files: it is "potentially
        unsafe attachment".
        
        Change-Id: I7c2f696391e1183211a169b08004c6668771f288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137480
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-07-27  Rene Engelhard  <rene@rene-engelhard.de>  [c4f7043c593823b8c5605e779371ff430659eb20]

        HPPA is 32bit
        
        as already handled as such in postprocess/CustomTarget_registry.mk
        
        Change-Id: Idc7ead94db8f14e656c36db0438c916b0f2565e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137498
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-07-27  Rene Engelhard  <rene@rene-engelhard.de>  [c559dbd86474e4b0e5c2d0711508ab7f5efed6b5]

        rename GODSON/GODSON64 to MIPS/MIPS64
        
        as that what it actually is and the compiler defines are already
        -DMIPS/-DMIPS64 anyway (as are the PLATFORMID and the bridges'
        name mips/mips64)
        
        Change-Id: I274e7a3b0e140375a8e697c1790cbdb972251d29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137489
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-07-27  Caolán McNamara  <caolanm@redhat.com>  [93f28ca499c6d15415f359a9e868a72bbcdc9b4b]

        tdf#149439 Update Custom values that may have changed since last printer check
        
        keep any value the user explicitly set, but update one that was taken
        from lpoptions if that changed
        
        Change-Id: I02ed4ff575cb7b2580b777bb0948de2ff7211621
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-27  Colomban Wendling  <cwendling@hypra.fr>  [8fe5a832b02ea6c5113c573f5b9c23e58049a4d2]

        Make AccessibilityTools available more widely and use it
        
        Move AccessibilityTools helper to test/ and use it in accessible_relation_set
        test replacing the copied over feature and consolidating the test as well.
        
        Change-Id: Ia5ea69bb08bb2a86e3eb6c3dba2ab182b612561d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137307
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bbb57e8198863ee7bdadd3f2aac4420c08da94a3]

        tdf#67669 - Make narrow no-break space visible by drawing a gray background
        
        Make narrow no-break space visible by drawing a gray background like for non-breaking spaces.
        
        Change-Id: I3f2b4374a08ea8305c8c84eb497bc362866ad352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137490
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-07-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b9d360405a26ec976e443d501757ad806ffdcd6b]

        o3tl: use std::array as the container for enumarray
        
        Change-Id: I482140a14a4f18014d89ed5b8ce7c3ca9447b8d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137465
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ecef3edbcd61a80c1c65982a1ac71b23e06d3d54]

        Fix typos
        
        Change-Id: Ic0e61610612e987c9b1b75f9edcf9c04807d6737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137488
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-27  Miklos Vajna  <vmiklos@collabora.com>  [3cdfed5dba206c1b3e1c9de77432606a36fda53f]

        CppunitTest_sw_ooxmlexport12: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I7024b990f38fead082df9f200ec4a5865fbc093d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137481
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-27  Jim Raykowski  <raykowj@gmail.com>  [b8ac21a3981b9d6fd94aa74c4da9026e580f44eb]

        tdf#149916 revert to showing text of referenced text node
        
        reverts cross-ref field listings in the Navigator to pre commit
        21b5d6e0dce7c2034aded96d1499da27094e2781
        
        A static_cast is used in place of a dynamic_cast which should provide
        for reduced time to fill the fields members list for documents with
        cross reference fields which was the main purpose for commit
        21b5d6e0dce7c2034aded96d1499da27094e2781
        
        Change-Id: If2734386de463a1280d835cab54f95e8bd7fab5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137444
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-07-27  Eike Rathke  <erack@redhat.com>  [550392aeb849b326aa0d5d84a0ec1d28d3d42503]

        Set interpreter's push stack MAXSTACK to 512, not limited to architecture
        
        ... that fixed size halving from 16-bit for 32/64-bit might had
        made sense two decades ago, but.. is a legacy left-over.
        
        Change-Id: I9a5bda3f0b7ec6df8dcd2b1fd09357ba5dbc4691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137485
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d42aeae86253e167facb1adfddd0c9976b7801a]

        sal_uLong->sal_Int32 in the Find/Search methods
        
        we cast this to sal_Int32 once it hits the UNO methods anyway
        
        Change-Id: I8d18330929acbb5b2f40d9b0fd0f49e087be867e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3c66db70453d400528c3625335bfed2b0cfc475]

        tools::Long->sal_Int32 in SwCursor::m_nRowSpanOffset
        
        elsewhere in writer this is either sal_uInt16 or sal_Int32, so lets use
        the wider type
        
        Change-Id: I976aa2076a1bf703caff343806daf83de89782bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [773a8c919c70bf31a7eb240f779fe8a052326e63]

        no need to allocate here
        
        Change-Id: I0d08ee6a54ad87097909f5dacfd7a08c1f4b6770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c38f51c727fac25fdeb15d78a24d9203fabac5c]

        convert CRSR_SKIP_* to typed enum
        
        Change-Id: Ia5cb9915fc7ad3238f4386f5ed3e43efc4b74a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [b13631c562e85a6567a600edc5bb1d93418e4f53]

        make SwNodeIndex as SAL_WARN_UNUSED
        
        Change-Id: I26878594ea5629d8827bb2465050e5e5acc600e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Michael Weghorn  <m.weghorn@posteo.de>  [11cd74ade59c6b47b25a737775a541fdd6faed44]

        tdf#150104 Store full printer/driver name in doc's JobSetup
        
        Printer and driver name have a limited length (64 chars for
        the printer name, 32 for the driver name) in the
        `ImplOldJobSetupData` struct that is part of what gets
        serialized into the "PrinterSetup" config item in
        settings.xml when saving printer settings to the document
        (s. `WriteJobSetup`). Longer printer and driver names
        get truncated, and only the truncated name got restored.
        
        At least for Windows, this scenario would result in the
        doc printer settings not getting restored properly,
        because `ImplTestSalJobSetup` (in vcl/win/gdi/salprn.cxx)
        among others checks that both printer and driver name
        match, which isn't the case when one version is truncated.
        
        ODF spec, version 1.3, section 3.1.3.5 says this on settings.xml:
        
        > 3.1.3.5 <office:document-settings>
        > The <office:document-settings> root element contains
        > implementation-dependent settings. The file within a
        > package for the <office:document-settings> element is
        > settings.xml.
        
        Since the settings are implementation-dependent,
        changing the exact format and content of
        the data in "PrinterSetup" is unproblematic,
        as long as compatibility with older application versions
        is maintained.
        
        Luckily, there is already a way to save variable-length
        key-value pairs with `JOBSET_FILE605_SYSTEM`,
        added in
        
            commit 4bd178f6ee60f641b2a6c7fcc9f6e4b6dd01df27
            Date:   Fri Sep 22 11:55:00 2000 +0000
        
                new feature in JobSetup: additional parameters
        
        Make use of this to save the full printer and
        driver name using the "PRINTER_NAME" and "DRIVER_NAME"
        keys and restore the values from those if present.
        
        For compatibility with older versions, the (potentially
        truncated) values are still written and also used as
        fallback on document open.
        
        Change-Id: I55bed58023fa7a078525add79b13f2310aa9a9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137454
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-26  Caolán McNamara  <caolanm@redhat.com>  [59cfcd863b483a99491e6f8cd30016386bbff870]

        tdf#150145 text appears to have a row of pixels cropped out
        
        which is very similar sounding to
        https://gitlab.freedesktop.org/cairo/cairo/-/issues/390
        
        seems to be a bad interaction of slight hinting and sub pixel positioning
        with hints_metrics disabled with CAIRO_HINT_METRICS_OFF.
        
        lets continue to assume we desire CAIRO_HINT_METRICS_OFF most and
        disable hinting rather than use slight
        
        Change-Id: Id7b35d0e4f9291987e8ab96814936700374c6e16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137466
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-26  Tor Lillqvist  <tml@collabora.com>  [1c31791b0635dd626ce05a697c648ded0d6fea87]

        FreetypeManager::m_nMaxFontId is unused
        
        Change-Id: Idf50eee8dee0ad5f5e789a8554b80114c2c9f795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137461
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-07-26  Michael Stahl  <michael.stahl@allotropia.de>  [a89b221afe2d2d8aa670236fce6e95022ffa1cd9]

        tdf#150017 vcl,sw: add UITest
        
        Unfortunately i couldn't figure out how to send keyboard input to the
        Edit widget in the SvTreeListBox; it's created by
        SvTreeListBox::EditText() and shows up when calling dumpHierarchy()
        on the DialogUIObject as a child of the
        SvTreeListBox/"19LclHeaderTabListBox" but the execute() doesn't send it
        events, neither when called on DialogUIObject nor on TreeListUIObject.
        
        So forward explicitly in TreeListUIObject::execute() - probably not the
        best way to do this?
        
        When using the UI, events arrive like this:
        
        0  SvInplaceEdit2::KeyInput(KeyEvent const&) at vcl/source/treelist/treelistbox.cxx:202
        1  (anonymous namespace)::MyEdit_Impl::KeyInput(KeyEvent const&) at vcl/source/treelist/treelistbox.cxx:117
        2  ImplHandleKey(vcl::Window*, MouseNotifyEvent, sal_uInt16, sal_uInt16, sal_uInt16, bool) (pWindow=0x6dc4bc0, nSVEvent=MouseNotifyEvent::KEYINPUT, nKeyCode=1026, nCharCode=0, nRepeat=0, bForward=true) at vcl/source/window/winproc.cxx:1209
        3  ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2672
        4  SalFrame::CallCallback(SalEvent, void const*) const (this=0x8a19fb0, nEvent=SalEvent::KeyInput, pEvent=0x7ffc7f3639a0) at vcl/inc/salframe.hxx:306
        5  X11SalFrame::HandleKeyEvent(XKeyEvent*) at vcl/unx/generic/window/salframe.cxx:3190
        
        Change-Id: I0be42330aeef98ef09e21297acef6cf616b7f2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137459
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-26  Michael Stahl  <michael.stahl@allotropia.de>  [aa6ec3f79607478213272283b7eb17ec2116173c]

        tdf#150017 sw: allow editing bookmark text in Insert->Bookmarks dialog
        
        Enable editing the text of the bookmark if it's "short" enough and
        doesn't span multiple paragraphs; Replace the text when finished.
        
        This will delete any footnotes or text fields in the bookmark text,
        which isn't ideal but there's Undo.
        
        Double-clicking the column via property "editable" only seems to work
        with native GTK widgets, so provide an additional "Edit Text" button to
        start the editing.  The button requires commit
        fe38553aef2121f358fb58e450ec69314aad851e to edit the correct column
        with VCL widgets, and it doesn't work yet with GTK widgets (but with GTK
        double-clicking works).
        
        Change-Id: If9e8a148b039889924e4870b2e9bbe977c977ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137355
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [96844af26402e4ab26ff7ba02e52989c3b294095]

        elide some temporaries when constructing SwPosition
        
        because the resulting pointer manipulation is not free, the temporary
        has to be attached to a linked list and then immediately de-linked
        
        Also add some asserts to catch SwPosition being created with
        mis-matching nodes in the SwNodeIndex and SwContentIndex.
        
        Which flushes out some bugs in
            SwHTMLParser::NewDivision
            SwIntrnlSectRefLink::DataChanged
        where it was creating a SwPosition
        with the SwNodeIndex and the SwContentIndex pointing at
        different nodes.
        
        Change-Id: Iea69f5ffc5860eb654435e161bc544b412d4c245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Miklos Vajna  <vmiklos@collabora.com>  [4e6327c673075ab4a44f497a06a8dbf759c1a72a]

        sw reqif-xhtml export: fix duplicated bookmark names in fragments
        
        The problem was that exporting multiple documents to reqif fragments and
        then combining them to a single document resulted in non-unique bookmark
        identifiers, even if they were unique in the original source documents.
        
        Writer already tries to ensure unique bookmark names, but if the export
        result is not a full document on its own, this is not enough. On the
        other hand, bookmarks in these fragments are almost always used
        unintentionally.
        
        Fix the problem by keeping the bookmark output in the HTML/XHTML case,
        but disable it for ReqIF.
        
        Note that we disable unique anchors in general, so this fixes the same
        problem with section anchors as well.
        
        Change-Id: Ib47d1589fa08d205b7904e21656c937bfbca0a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137464
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [ebbd0d763a84fdc6fc4fc8e70242f5c5ee70be71]

        lok: don't force formulabar update on every view switch
        
        This will reduce number of messages and helps to avoid
        selection change in other views when someone is editing
        a multiline cell and other user is doing something else
        at the same time (which triggers view switching to perform
        operations as different user).
        
        Change-Id: I8efc82be9793910c46bf6f33f7993e4c5734f9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137304
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137463
        Tested-by: Jenkins

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [496475c66665209dcb56f0bd1528b14dd8b689ca]

        lok: allow shrinking too big widgets
        
        This is followup for:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b
        Add sanity check to avoid potential crash in the Collabora Online server
        
        nExtraSpace can be negative for shrinking the widget - this is correct.
        For example listbox can have many entries, in GetOptimalSize it returns
        size required to show all of them, then here we calculate how much of
        that size we can allow to be used. When we have too many entries we use
        negative nExtraSpace.
        
        The original problem is not that we get negative number but case when we
        get value that is much bigger than size of a widget and it becomes
        invisible.
        
        So this reverts hack which makes impossible to shrink widget what causes
        problems with listboxes in tunneled dialogs. Also it setups better
        size request for csv import dialog grid widget - so we don't paint it
        as 10px rectangle - what was workarounded by the previous patches.
        
        Change-Id: I478660b12cf0b6a783c704201800018e9849cc23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136728
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137451
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [8b5a6af435952398bfc6328c10e8f3cdae475312]

        MarkColumns should modify formula if editing is active
        
        Change-Id: I2ad4df0e6ad87bdad689112683bd29babf127502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137227
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137462
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [a6586ab2e6a5bb352f2958067cbe88095b6e2ada]

        lok: formulabar: handle mobile IME
        
        Change-Id: I7cb69efaebb42020353133e590a161b2e4bc5210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137086
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137457
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-26  Michael Stahl  <michael.stahl@allotropia.de>  [7974cea6c788e02d7c36573e2d10dcc51884f70e]

        tdf#150017 sw: Replace should not shorten bookmarks
        
        If there is a bookmark on the text that is replaced, its end will be
        after the 1st character of the replacement text.
        
        This is very odd and it would be much better to put the end at the end
        of the replacement text, particularly if the end of the bookmark used to
        be at the end of the replaced text.
        
        Text attributes already work such that the attribute on the first
        character before the replace is expanded to the entire replacement text;
        this seems odd too but as it happens Word does the same thing, so
        this patch makes bookmarks consistent with attributes.
        
        Change-Id: I6a4b43c779c207a31edb02b416d50c30386c94c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137272
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5b1a8f39ee58fe5372eea18ce1ee99c95b11ba05]

        oox export: add export of basic properties of a data table
        
        Change-Id: I2c8b76125fc788a9e4df164171d6cbd351bc1c4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137406
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [19807d4f31a1f58fe434dfe638e1f3c9a0d8e921]

        jsdialog: handle grab_focus action
        
        Change-Id: I20ec0ac75dfb6260cdd603f9dec7cd5001cb5650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137085
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137456
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [880ece2bf00587bdaa633eb572c8dfb56a57b701]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9d3310b0b0232aea02d5f75f4d3ce76b6d58635c
          - update translations for 7.4.0 rc2/master
            
            and force-fix errors using pocheck
            
            Change-Id: I05d988bab736eb89ef05e768a71e53157fe78a24
            
2022-07-26  Miklos Vajna  <vmiklos@collabora.com>  [6cf1f3c09c43bd3bbcda611a9476ff5e64c5164f]

        crashtest: fix crash on ODT export of forum-mso-de-84211.docx
        
        XMLTextParagraphExport::ExportContentControl() disables the export of
        the <loext:list-item> XML element in autostyle mode, then it should also
        disable the export of the matching attributes.
        
        Change-Id: Ia65fc8bd3398df0ab1b71973695c9bc8d10deaa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137452
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [a66c2f55118aac03ee3a06ebdd97d48a93a6da9a]

        jsdialog: formulabar: dont send huge paragraph id when not found
        
        Change-Id: Ia5586023f639815e54628bfad1a8df11c295c741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136848
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137450
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [c2a52693770c7db4741dedfdb7222b93f045b101]

        jsdialog: add open/close instead of toggle menu from dropdown
        
        it will make us sure we don't reopen popup when we just toggle
        so we will be in sync
        
        Change-Id: I014e824a29d91d5972a6840246bcd4c31d24ae48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136570
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137449
        Tested-by: Jenkins

2022-07-26  Caolán McNamara  <caolanm@redhat.com>  [61e4f8503c89e0933b294304320e371804b077c9]

        Resolves: tdf#149127 explain the infobar asking to refresh master password
        
        Change-Id: Ia8439dd6f5dca91f008150ed759eef92fcc4b9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137440
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-26  Miklos Vajna  <vmiklos@collabora.com>  [7748a0c437855133fb0a0ebadb60f5f083112f20]

        sw content controls, plain text: add insert UI
        
        - handle the plain text case in SwWrtShell::InsertContentControl()
        
        - expose this as a new .uno:InsertPlainTextContentControl command
        
        - add the new uno command to the default & MS-compatible menus
        
        Change-Id: Ie6eb7271f2c1603fb92036e0067b1e6be70d93ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137447
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [bbda36c328ddb16d32bdc1c3443893076f09a307]

        SwContentIndex: move the const_cast inside
        
        instead of doing it at the call sites
        
        Change-Id: I2ae8aafc14801894fa70c17b666b7d95849c7429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Miklos Vajna  <vmiklos@collabora.com>  [0c96a9ef657b12bcba6ae821b8703b433711b74b]

        sw: extend SwPaM documentation
        
        Explain which one stays and which one moves while adjusting a selection.
        
        Change-Id: I05ed0a376c1e75808f39a2683345ba389a83af3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137443
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [9acc54e65476e405bd8d9e4bca135be968448d3c]

        elide some temporaries when constructing SwPosition
        
        because the resulting pointer manipulation is not free, the temporary
        has to be attached to a linked list and then immediately de-linked
        
        Change-Id: I10594026aa388064abc652b91aff024deeb5ca54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [3caade9b4734245471347c7eb20090607d70f7b7]

        simplify some use of SwPosition
        
        by moving the const_cast inside the constructor
        
        Change-Id: I1b43a6d3759de250475f0ebc7d65449ff800b570
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Regina Henschel  <rb.henschel@t-online.de>  [5df1bb4b1b222be00d25097660c4ee33542896ea]

        tdf#135953 move txXfrm to compensate TextRotateAngle
        
        The text rectangle specified by the txXfrm element rotates around its
        center. We not directly use this rectangle but we use the text area
        rectangle of the preset geometry and crop it by setting distances so,
        that the result equals the txXfrm rectangle. But the text area
        rectangle still rotates at its original center. So we shift the txXfrm
        rectangle so, that it would be at it original place, when rotated with
        TextRotateAngle. We then can use the shifted one to calculate the
        needed distance values.
        
        This patch contains the calculation of the text area rectangle for
        type 'rightArrow' in addition. That fixes tdf#132302.
        
        Change-Id: I59d9aecaaa7ce2ef4502651088ff9576b90873f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137396
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [306ae32bfa92b06588173ee495acf3cb384ffb24]

        tdf#119840 HideIterator no need to always call GetRedlinePos
        
        if we are not going to process redlines.
        
        Shaves 5% off load time
        
        Change-Id: Ie46370b3f6172c35c057f7f9cb3285c76afa9d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7d5a3a762042d8becc2d870269981326665938ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb721e7331e6761ec1e42548033a56485ee4724e
          - Fix typo
            
            Change-Id: I5d332c35931a3b746111c946170b8946765a65e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137442
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-07-25  Aron Budea  <aron.budea@collabora.com>  [373f655acbdad88ff5d76324f32650fe3a005e2e]

        Send state changes of content control UNO commands to LOK
        
        Change-Id: Id6b3f9a35c129078b564f7906e03f6aa9306a5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137415
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-07-25  Mike Kaganski  <mike.kaganski@collabora.com>  [195faf2b3d1ee0f4fd1bf59137cc6310c390ebbe]

        Handle Ctrl+Z / Ctrl+Y in Math graphic window correctly
        
        ... instead of trying to insert a control character in the formula.
        
        Change-Id: Ifcf4d3ce1111a381cd29de310b041c08f7314cff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137402
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-25  Caolán McNamara  <caolanm@redhat.com>  [7a48b95e2516f51460341c6e0f8f991cca93c6f2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to edb58d78bc7d7f344c0f6fe00cfb65386be8a735
          - tdf#149127 explain the infobar asking to refresh master password
            
            Change-Id: Ib5be9007fb16be39687252ea654e133371d2a444
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137439
            Tested-by: Jenkins
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2022-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9fdb06d65a8f2c3401392bffee9c4639e178aada]

        rename SwIndex->SwContentIndex
        
        to help my poor brain with the different kinds of index we have floating
        around
        
        Change-Id: I47ed223922170687d7e07812445aed66b3218230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Mike Kaganski  <mike.kaganski@collabora.com>  [493b62c6805125b7f3ebfbd2b4b73a7d49aa0f67]

        Some refactor
        
        Change-Id: I58f315e39e33a09585d6325590998ac8195687db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137401
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cfa03bbfb7397c34fe2ea605a4ef573ae92e4ea]

        SwIndex/SwIndexReg is only used to deal with SwContentNodes
        
        so make that apparent in the type system and naming, instead of
        implicit.
        
        Which requires adding a small helper class for the one place we were
        instantiating an SwIndexReg by itselg
        
        Change-Id: I74db37239aed0005e5a2a01916635fa93de638f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Mike Kaganski  <mike.kaganski@collabora.com>  [ab12ae777b8213f2a3a8ed9a744adb82a1f75e32]

        A bit of RAII
        
        Change-Id: I58fb16f7e2c4c30212605b667cfd3f79a3dc7d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137400
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a843f7e98dfe6bfb04e91e5b16e3a1df18fbf58]

        loplugin:moveit
        
        make the plugin more conservative, so we see less false+
        (although we also miss some possibilities in the process)
        
        Change-Id: I91b1806271e7f802d7459834ab7bcc569047da3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [0351bec874f7e83c437e485e8d61a41f32718e25]

        use more o3tl::span
        
        which means we can reserve precisely the right number of entries when
        building maps
        
        Change-Id: I580414699289369de4730caae09829bbd8759e82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-25  Miklos Vajna  <vmiklos@collabora.com>  [9700c1b2170ad04453a361ed5647937833ac3c18]

        sw content controls, plain text: add DOCX import
        
        - the core of this is the writerfilter/ change to call PopSdt() for
          SdtControlType::plainText, which maps inline plain text SDTs to Writer content
          controls, not to input fields
        
        - disable the grab-bag in this case, otherwise we would run duplicated <w:sdt>
          elements on export
        
        - fix CppunitTest_sw_ooxmlexport7's testSdtAndShapeOverlapping by postponing
          the SDT start in DocxAttributeOutput::WriteContentControlStart() in case a
          shape is anchored at the same position as the SDT start: if the shape should
          start inside the content control, then it should be anchored after the dummy
          character
        
        - reduce the debug output in VMLExport::Commit(), which could write control
          characters to the terminal on test failure, potentially breaking it (requiring
          a 'reset' to recover)
        
        - fix CppunitTest_sw_ooxmlexport5's testSdt2Run: now we merge two runs inside a
          plain text content control into a single one, and there is no problem with
          that, so adapt the test instead
        
        - fix CppunitTest_sw_ooxmlexport17's testTdf148361: plain text inline SDT is
          now a content control, not a field
        
        - fix CppunitTest_sw_ooxmlfieldexport's testfdo82492: explicitly assert that
          there is 1 text run inside the SDT and there is a shape after it (outside).
          Also extend DocxAttributeOutput::EndContentControl(), so it ends the content
          control at the correct, earlier position in case it's followed by an as-char
          shape
        
        - fix CppunitTest_sw_ooxmlfieldexport's testfdo82123: again assert that the SDT
          has 1 run with text, and there is a drawing after the SDT
        
        - fix CppunitTest_sw_ooxmlfieldexport's testTdf104823: this revealed that some
          more complex logic is needed to support data bindings, so exclude
          text-with-databinding from the scope of this commit and continue to map those
          to input fields for now
        
        - fix CppunitTest_sw_ooxmlfieldexport's testFdo81945: this had a similar
          problem as as-char shapes, but this time a new SDT is starting right after a
          previous SDT. Adapt DocxAttributeOutput::EndContentControl() accordingly,
          though perhaps this should be generalized later, so we always close SDTs in the
          previous run, unless this is the last run, or something similar
        
        Change-Id: Ifaf581be884a683de6c8b932008a03ba43734b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137399
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-25  Miklos Vajna  <vmiklos@collabora.com>  [f17aec9f573f87e4a8fa5ccdf504897d745bb0a6]

        vcl: fix assert fail on invalid user input in the vcl::WindowData ctor
        
        This seems to be a problem since
        ea5a0918c8c32309821ab239c4b95f4d6a3b5c12 (VCL add vcl::WindowPosSize
        abstract class, 2022-06-02), which started asserting that the window
        size is not negative. Which is fine, but then callers like the
        vcl::WindowData ctor has to be adapted, since they get user input.
        
        My user profile had a string like:
        
        "1056298152,1049249376,-1906262000,-1906261808;5;0,0,0,0;"
        
        passed to that ctor, so soffice failed to start up.
        
        Just ignore the broken user input at the call-site.
        
        Change-Id: I942b0f2dfc1a07f9514c120761e100691f6d1a59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137357
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-25  Miklos Vajna  <vmiklos@collabora.com>  [a6e5726f186bf9d2a0ea91169649504c7396c539]

        sw content controls, plain text: add DOCX export
        
        Map the PlainText UNO property to:
        
                <w:sdtPr>
                  <w:text/>
                </w:sdtPr>
        
        Change-Id: I57f365fcfb3a80acb74aa932432a8ae8f3acc92b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137398
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-25  Miklos Vajna  <vmiklos@collabora.com>  [ebed8dc382817b8f356d090ac4794a3eee8f1f0f]

        sw: prefix members of SwCharURLPage, SwParagraphNumTabPage, Xst and Xstz
        
        See tdf#94879 for motivation.
        
        Change-Id: Idf6a9da5f00ca37fc12b994301df0e378509a90f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137397
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-24  Caolán McNamara  <caolanm@redhat.com>  [41f02927b6d8470c298c8a2f407c98420a5ebe24]

        ofz#45551 Out-of-memory
        
        Change-Id: Ic58fe7e279941b976412131fc8b3c81eba080296
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-24  Caolán McNamara  <caolanm@redhat.com>  [9a9d955f7bbcedb7921345a107f4aec5128c1c43]

        ofz#49217 height_sp member, etc unused
        
        massif peak from 37.10MB to 28.16MB
        
        Change-Id: I3d773637cee4243f235a4784e29a066d2c8b747a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [96648fa4b38a77cb86ed03962db2676916a8a97c]

        Fix typo
        
        Change-Id: Ia6c5e8615cc1438664f2208b6b1fc5f0383840ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137392
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [323ff48366f54f59f0c95c6dd1c161ff456f3577]

        Removed executable bits on doc file
        
        Change-Id: I8e6e4e73850897d6f4858da5bbe682733f513b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137393
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-24  Hossein  <hossein@libreoffice.org>  [e2b7f59c745a79542b15937bc824c7afe9969cde]

        tdf#147868 Disable add sheet when structure is protected
        
        Using "Tools > Protect Spreadsheet Structure...", it is possible to
        protect the structure of a spreadsheet document. Without this patch in
        place, the [+] (add new sheet) button is clickable but it does not work.
        This is confusing for the user, so it was decided that the button should
        be disabled when the structure is protected.
        
        This patch disables the [+] button just after the structure is protected
        using the above toggle menu option. The menu option becomes checked, and
        the [+] button gets disabled immediately. After choosing the same toggle
        menu option again, the check mark goes away, and the [+] button becomes
        enabled immediately.
        
        In this patch, GetDocument().IsDocEditable() is used to check if the
        document structure is protected. The argument for this choice is that
        the same function is used when renaming a sheet with
        ScDocFunc::RenameTable().
        
        Change-Id: If812d94841d3efd98d7ef898cc1f4b2f1387130b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137365
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-24  Hannah Meeks  <hmeeks4135@gmail.com>  [78071a36def92096920a0441b5fdac0fdd5a7c8e]

        VBA Fix Color mapping issues
        
        wdRed should retrun wdRed etc.
        
        Change-Id: I5ae359c8b5ec9c34ddd2fd18894bd860384b3cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137383
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4827d5cb1508f6bca9489e31b877cfff36393c50]

        Removed executable bits from source file
        
        Change-Id: I0f36bec337e6167668a0fccd48b5a047327a9215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137374
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-23  Ali_Abdollahian  <a.noghabi2002@gmail.com>  [5e7663b792ee1d56838d7a5082e5c29867f839f2]

        tdf#101731 Rename gradient border label to midpoint
        
        Renamed gradient border label to Mid_point
        
        Change-Id: Icda875d3c6f03ffd29395ac5ce932475cc629361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136851
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-23  Regina Henschel  <rb.henschel@t-online.de>  [3ade0a5fb1d39360b76c7d62eebee5a18d3f4196]

        tdf#149538 no text area rotation if upright exported
        
        This is a followup to commit 7e23cbdb. With that commit the attribute
        'upright' is correctly emulated by a rotation of the text area
        rectangle. But I forgot to remove this rotation when the 'upright'
        attribute is used on export.
        
        Change-Id: I46d0f421be8ef6b44537134c73dc1e4326ba7e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137368
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-07-23  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [1203fc97d9f036b24e1130575aa609bfe34601e1]

        Delete unnecessary new line
        
        Change-Id: I3e826c02895adda7dfa18c786dce0d94b08636d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137332
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-07-23  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9a612ce3d1d025d5f553cc348feaedeea37fc822]

        tdf#135761 - Calc cell editing: change search preference for the word boundary
        
        Since ImpEditEngine::StartOfWord is only used when a selection is deleted at the left, change the search preference of the word boundary from forward to backward. For further details of a deletion of a selection check ImpEditEngine::DeleteLeftOrRight.
        
        Change-Id: Ic68901cc04e5057e058ff03304f68eef1dca7a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137108
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-07-23  Justin Luth  <jluth@mail.com>  [28a947c8ceae8bb4b9306801ff4503970e9b1e76]

        related tdf#145998 sw ms export: smarter first header
        
        Possibly I should only set m_pPreviousSectionPageDesc
        when nBreakType is 2. However, this is export
        and LO doesn't have continuous sections,
        so it should be fine.
        
        The need for this should be VERY minimal now
        that a simple page break is usually utilized
        in this situation. As this unit test shows,
        it can still be valuable if a page renumber occurs.
        
        To push this idea much farther would require
        analysis of the actual layout, since a page chain
        can't be known whether we have seen a follow or not.
        
        Change-Id: I7dc37779ffebbf6649a10b08d561a14b0588c5c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137376
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0fec0010213e4596b7d22e03b3bcd5fda9efb49]

        elide some makeStringAndClear() calls
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: If1a1edef1d450f57cdfd35fbc0dbce03898cc4ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134944
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [fb5a6fe80750c0c21e3987106889e2af99bb8e5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to defa90e7b857b289bcc28529e9911d965e4a1166
          - Warn that names of Calc formulas must be in English
            
            While translating the help and doing some testing, I realized that the CompactLeft and CompactUp methods require the filterformula argument to use the English names of Calc formulas. This patch adds a note about it.
            
            Change-Id: Ie21b900ce52de566a2da8ec7a2813c46315403ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136933
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-07-23  Mike Kaganski  <mike.kaganski@collabora.com>  [1987aa7b597650930e32c274240fdec68617d903]

        Simplify greyscale palette initialization further
        
        Change-Id: Iaab6a493e0a0c329f6b6e229f0ce0cdabb188112
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137361
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-23  Justin Luth  <jluth@mail.com>  [fa5d80106080fa305479758dd43d0defb684376a]

        related tdf#145998 docx export: fix writing blank headers/footers
        
        That perpetual m_bHasHdr variable was really confusing,
        and it was completely misused (by me). This change should make
        it much easier to understand the purpose.
        
        To do this completely efficiently would require multiple variables
        for each type, but this is good enough.
        (It just means we might create a few more empty headers than is
        absolutely necessary.)
        
        Change-Id: I0686fe2af81203021ff1bd58d79d9cd3bc81a89f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137375
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-23  Eike Rathke  <erack@redhat.com>  [b1a2f727ca99ecd3402d4b051b99cbfd24266e59]

        Related: tdf#150011 Add HRK Croatian Kuna to Euro conversion wizard
        
        Maybe just for completeness, it's removed from menu but might be
        callable as macro.
        
        Change-Id: Iade0be845186d3deb2f00f4aaa230c0b344cea72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137372
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-22  Eike Rathke  <erack@redhat.com>  [7c4b2db21ef77b37daf234ac1ab9989234606a22]

        Resolves: tdf#150011 Add HRK Croatian Kuna conversion to EUR Euro
        
        TODO: switch defaults before 2023-01-01 in
        i18npool/source/localedata/data/hr_HR.xml
        
        Change-Id: Ifc62aefbc8c9fe8bbf044f61ae4fd6eeff692185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137371
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [2053fac9a81927a92aac016eab1b4525c058ce95]

        tdf#119840 tweak SwPosition::operator<
        
        It is slightly cheaper to check for == first, because that doesn't
        require fetching data via a pointer to another object.
        
        Shaves 7% off load time
        
        Change-Id: I4e22e55ed10198a8fadc49de708a5a6b55afc0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-22  Caolán McNamara  <caolanm@redhat.com>  [ed2e37de2d2d26d996e001a3eaade802a2d716fa]

        gtk: honour disabled columns from set_column_editable for start_editing
        
        Change-Id: I3b49254b9bdaee1e10e82cc2cff0c4cbf52f74fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-22  Michael Stahl  <michael.stahl@allotropia.de>  [fe38553aef2121f358fb58e450ec69314aad851e]

        vcl: allow editing a column other than the first one in SvTabListBox
        
        There are 2 members mvTabList and aTabs in SvTabListBox and
        SvTreeListBox, and only aTabs is evaluated to determine which column
        should be edited when calling start_editing().
        
        This solution is probably not ideal; it would be better to have a
        parameter to select the column because one might want multiple editable
        columns with multiple buttons...
        
        Also, the native GTK implementation has the same bug (but there
        double-clicking the column works).
        
        Change-Id: I727792e635d3b610a2132ee5f4155e3ee610aaf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-22  Justin Luth  <jluth@mail.com>  [c37f62b71fa59917ef85ff98480dff18aa936e41]

        tdf#145998 sw ms export: use page break, not section break
        
        If possible, use a simple page break instead of a section break.
        
        Eliminate unnecessary "page style" changes. If the page will
        become that style anyway, then a simple page break will suffice.
        
        The benefit is primarily for LO import, since it is virtually
        impossible on import to know if a section is identical
        to the previous section. Thus we have previously multiplied
        page styles - often redundantly.
        
        This also starts to fix a real problem with first headers showing up
        on an unnecessary new page style. Unit test deals with this.
        
        Change-Id: Ib9e24bbd579b29aa21efb2b85750ecfcb8c7e5cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137273
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-22  PoonamShokeen  <poonamshokeen7@gmail.com>  [053f470316b89b6fcea1fac69e6bffd4f65f91ee]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I7061e0985c51910ba6a8b862cd755b8b4f7016bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137279
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [8a97da679bbccf81e73dc5d2e864b5f40adfc0eb]

        fix clang-cl check on WSL
        
        Change-Id: Id357ee8e27eb3e8b6f5f076350c43bb75e7d0683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137348
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [f6882d91ad8d2219aa6fdc1583507910ee103e2b]

        fix configure handling of tarball path on WSL
        
        Change-Id: Ie33eb8e256a38c5120fdd713b3fc34160a8728b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137347
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [c93e40ea0be17b586c30fc3b53c5f8193f26cd79]

        configure fixes for WSL
        
        - Enabling some Cygwin checks also for WSL.
        - Handling of Windows paths as needed for WSL.
        - Reading of registry using wsl-lo-helper as WSL doesn't provide registry
          in /proc the way Cygwin does.
        Configure now passes for me (with Skia and Java disabled).
        
        Change-Id: I325c4e6f9f825b3b6d0aa6cb350bafabc4011ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137346
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [981ba02267af461792c3ff30b8fecc5cd73497a3]

        add fallback for $PROGRAMFILESX86
        
        It's not set in my WSL, but since it's going to be c:\program files (x86)
        in the vast majority of cases, just hardcode a fallback.
        
        Change-Id: I3bf41d6bae0e5bb36c53f0a4cf913a980a058fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137345
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [4fbcededefa07a97aa9ca55986241a0dd0146806]

        require wsl-lo-helper to be preinstalled, like 'make'
        
        It is needed to even find MSVC, so configure cannot easily build it.
        
        Change-Id: Ie4e950cf01b9d8778cdc3e9a53718954b0c3c166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137344
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Luboš Luňák  <l.lunak@centrum.cz>  [5a8a1c4a86938b65c5ea7807f60e721946d7d8de]

        use uname for detecting WSL
        
        There's no wslsys in my WSL setup.
        
        I also don't see why WSL should be at least version 2, they both
        should(?) work and it is recommended to use version 1 with NTFS
        (and version 2 also doesn't work e.g. inside VirtualBox).
        
        Change-Id: I5b9440f65624f49e331d84235046e4dd2e31af4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137343
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-22  Michael Weghorn  <m.weghorn@posteo.de>  [5b04eed4d22c9e3caa76e195582b15862e9261b6]

        tdf#147021 Use std::size in {Read,Write}JobSetup
        
        Change-Id: I6db569b8c5fb94dcd0e7ad629738ded8ba53e80c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137359
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [4be04385c5e9838687ecade94dae9e59fcc30621]

        Simplify paletted ctor logic
        
        Change-Id: I2c04eaf758fe9050a023061746cb342f2b862952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137324
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-22  Miklos Vajna  <vmiklos@collabora.com>  [5d68b3878fed165bf1bdc6aa47be1df4a8265b96]

        sw: fix heap-use-after-free in SwTextNode::InsertHint()
        
        This is a problem since commit 1dce9ee7e12871ee63434499db805e806b9e9d3c
        (sw content controls, plain text: apply formatting to the entire
        contents, 2022-07-21), because I forgot to check if pAttr is still a
        valid pointer after the input field code is executed.
        
        Below code already uses this flag to make sure it's not accessing a
        dangling pointer, apply the same fix here as well.
        
        Change-Id: Ifcba0bc5e3a3c0abd81ff954fb10f6880163461b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137349
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-22  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4d153517183193f468dee9148c94fe9d874bacb3]

        tdf#149697 PPTX export: fix changing place of connection points
        
        Place of the connection point of a polygon changed during
        a PPTX round-trip, connecting other vertices of e.g. a square
        or a hexagon, as before.
        
        See also commit c3f73f75772d076dfb2ed0538e7d515503edc038
        "tdf#149128 PPTX export: fix <stCxn> and <endCxn> connector properties".
        
        Change-Id: I64fc6377417a99d32e84ea71fbed13cf36760118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136474
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-22  Tünde Tóth  <toth.tunde@nisz.hu>  [b7a294af40521d71e6583dad2908e09f3758649c]

        tdf#139128 DOCX: fix export of line break in text frames
        
        Line breaks (text:line-break) of ODF text frames
        (draw:text-box) were lost during DOCX export.
        
        Change-Id: I2e1149234749437ceef0d4643b0e686d5ae92156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136998
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-22  Caolán McNamara  <caolanm@redhat.com>  [40efe03817805eee5eeaf7cba54d18963e02a370]

        tdf#150093 add scrollbar to calc general options for the case it doesn't fit
        
        Change-Id: I5099244153f38fc8393aaa6a09e74dcbd0a995bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137341
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-22  Noel Grandin  <noelgrandin@gmail.com>  [e7903c01b112665a300350b7e86c2bf65f81b8a7]

        elide some makeStringAndClear() calls
        
        Change-Id: I3b80d0f5b6d39c071242bc6ccc1e4333886c835d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-22  Noel Grandin  <noelgrandin@gmail.com>  [e7cc97d1e95fae3271fddafaa7a13bdf7c62b6ee]

        elide some makeStringAndClear() calls
        
        Change-Id: I58541cc3e0ec45a2f8127e1e14f4912a1295c740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-22  Noel Grandin  <noelgrandin@gmail.com>  [42572c6d0d1f1c84b3774f6c790e28e8abc7b45a]

        elide some makeStringAndClear() calls
        
        Change-Id: I3b7ae370b41638c0a67374d5132b7bdf56e7c672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-22  Noel Grandin  <noelgrandin@gmail.com>  [aa2067dda63852b0eb84d5c32497f5a28177bb1c]

        elide some makeStringAndClear() calls
        
        Change-Id: Iccdb04df53bc981e2240240daddf15e9e1bb5a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-22  László Németh  <nemeth@numbertext.org>  [7335d912de04eaa279dc805ee0ed5be0fcac5326]

        tdf#150086 DOCX import: fix ToC redline with lost content
        
        Inserted Table of Contents lost its redline partially,
        e.g. the redline contained only "Conte" instead of "Content".
        
        Regression from commit 69edfcf789db1920273191d93fae0bc03f385b81
        "DOCX import: fix assertion failure when redline ends right before a ToC".
        
        Note: it seems, it's enough to limit the original fix for
        delete redlines, because that was the main target of the
        interoperability fix.
        
        Change-Id: I617fa855aa8e194a33caa419d2d73e76588f4bd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137308
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [02a6d37131ab0b522d5b7551b2b24e98291ecf1c]

        Simplify small grey palette initialization
        
        Change-Id: I6a4fc8aa3c89654925821fcef75e27c8e3fd12b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-22  Miklos Vajna  <vmiklos@collabora.com>  [33cf26c8b6dc6cf38edf2d22cfefbd00904d9da8]

        sw content controls, date: add ODT filter
        
        Map the PlainText UNO property to:
        
        	<loext:content-control loext:plain-text="...">
        
        on export, and do the opposite on import.
        
        Change-Id: Icec0c35b2b9fca53104e6526c98083db52df5d42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137340
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-22  Balazs Varga  <balazs.varga.extern@allotropia.de>  [2d1df9f3dccc10f13b8585ad18afce1542ebc4d1]

        tdf#117276 sc: Show hidden filter elements as inactive elements
        
        Showing hidden values in the autofilter dropdown (as inactive when
        it was hidden by another row) - without changing the behaviour of
        autofilter. First those which belongs to non-hidden rows, then those
        which belongs to hidden rows.
        
        TODO: maybe we can add a global option where the user can switch on/off this feature.
        
        Change-Id: Iafeb43176efe7ab422b22697d399c68c95d0319d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136595
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-07-22  Miklos Vajna  <vmiklos@collabora.com>  [f96a1389ce2b9f09a76998db5f86586cd519f6eb]

        CppunitTest_sw_odfexport: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ieeeeb6be0d86eabfd5178ba576230a9859064724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137313
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-21  Miklos Vajna  <vmiklos@collabora.com>  [3b7c18a579f3165c9d425d172d697f8978d6cd84]

        sw XHTML export: fix writing of section direction
        
        The XHTML export behavior was the same as the HTML one for section text
        direction, the <div dir="..."> markup was used.
        
        This shares code with the HTML filter, but it's not valid in
        reqif-xhtml, while the CSS markup would be fine: <div style="dir: ...">.
        
        Fix the problem by keeping the behavior unchanged for HTML, but switch
        to inline CSS for XHTML.
        
        The other similar attribute was "id", but that's fine even in XHTML.
        
        Change-Id: I5797c90f9cf957dec7fc4074dd6e79dce11fada7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137305
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [8c15835762f2b16e7c8f5acd2d52f562c7dec9a4]

        tdf#144916: expand range to avoid unwanted effects on viewport edges
        
        This also allows to avoid clipping of impBufferDevice to the passed
        OutputDevice, because the expanded range couldn't otherwise be processed
        on the buffer device.
        
        Change-Id: I0d778365b09937c1a2ecee06477b0b17efcce44b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137296
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a02d4f656add39658c30669f2652bf6536207098]

        remove 4-bit bitmap bits that were still present in QuartzSalBitmap
        
        Change-Id: I3a363f9b382e298422e3a4bd6b58504cbaba077e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137286
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-21  Balazs Varga  <balazs.varga.extern@allotropia.de>  [c7b6c9407ce109ab27257f4c1ec66b86b48622df]

        tdf#150044 sc import: fix editing password in shared mode
        
        Set the readonly state back after we create the tempfile
        for shared files. It is necessary for later, when we checking
        the file is readonly or not and we need to give the editing password.
        
        TODO: filesave IO error is another bug
        
        Change-Id: Iafc4dc6e7ce825fc3b7fe18abaee65c014c49a0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137281
        Tested-by: Jenkins
        Reviewed-by: Tünde Tóth <toth.tunde@nisz.hu>
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-07-21  Caolán McNamara  <caolanm@redhat.com>  [8525e8bd9bc90139c97251f5fb49cf37dc07dbdc]

        Resolves: tdf#148743 TOC->Edit Index->Assign Styles; Styles aren't sorted
        
        Change-Id: I1ec804d315f487d7bd1138681ab8e8ae60f21a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-21  Stephan Bergmann  <sbergman@redhat.com>  [25da92004038c03c0feedf373e8038e7ee3e0c37]

        Make JunitTest_toolkit_unoapi_1 succeed again on macOS
        
        ...after afc828b9833b7a612369e95606ba56d41ef2c369 "VCL expect correct frame size
        for native menubars" caused it to fail with
        
        [...]
        > checking: [toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent] is iface: [com.sun.star.accessibility.XAccessibleComponent] testcode: [ifc.accessibility._XAccessibleComponent]
        > LOG> Execute: containsPoint()
        > LOG> Upper bound of box containsPoint no component points - FAILED
        > LOG> Lower bound of box containsPoint no component points - FAILED
        > LOG> Left bound of box containsPoint no component points - FAILED
        > LOG> Right bound of box containsPoint no component points - FAILED
        > LOG> Outer upper and lower bounds contain no component points - OK
        > LOG> Outer left and right bounds contain no component points - OK
        > Method containsPoint() finished with state FAILED
        > LOG> containsPoint(): COMPLETED.FAILED
        [...]
        > LOG> Execute: getBounds()
        > LOG> Bounds = (0,0),(0,0)
        > Method getBounds() finished with state FAILED
        > LOG> getBounds(): COMPLETED.FAILED
        [...]
        > LOG> Execute: getSize()
        > LOG> starting required method: getBounds()
        > LOG> ! Required method getBounds() failed
        > LOG> getSize(): COMPLETED.FAILED
        [...]
        > ***** State for toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent ******
        > [toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent::containsPoint()] is testcode: [containsPoint()] - COMPLETED.FAILED
        > [toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent::getBounds()] is testcode: [getBounds()] - COMPLETED.FAILED
        > [toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent::getSize()] is testcode: [getSize()] - COMPLETED.FAILED
        
        > Whole interface: COMPLETED.FAILED
        > **************************************************************************************************
        [...]
        > ***** State for toolkit.AccessibleMenu ******
        > [toolkit.AccessibleMenu::com::sun::star::accessibility::XAccessibleComponent] is testcode: [ifc.accessibility._XAccessibleComponent] - COMPLETED.FAILED
        
        > Whole component: COMPLETED.FAILED
        > *********************************************
        [...]
        
        I have no idea whether that test legitimately started to fail, or is itself
        bogus, and (if the former) whether adding back the call to ImplCalcSize in
        MenuBar::ImplCreate is the best way to fix this.
        
        Change-Id: I8b575c66c57a698c59ccab01698df5355d4553bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136996
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-21  Luboš Luňák  <l.lunak@collabora.com>  [9dff8edf97f454f24a40acbed4a9297816f91da6]

        Revert "avoid repeated writer layout calls with tiled rendering" (tdf#145396)
        
        This was incorrect, the proper fix was my previous Writer commit.
        
        This reverts commit b9c2207e1b5247b4d3184b137be9a75a4b8c6c37.
        
        Change-Id: I829da1633dd11cb0c6e944fbf5acef030fad7dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137294
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-21  Luboš Luňák  <l.lunak@collabora.com>  [94bde29634c095e40bfcf74d27821b48919595da]

        Revert "do not draw directly in SwViewShell in LOK mode"
        
        It is actually needed to process SwViewShellImp's paint region,
        as otherwise testTablePaintInvalidate::TestBody from
        CppunitTest_sw_tiledrendering will end up in an infinite loop
        repeatedly calling SwLayIdle ctor. That's what I tried to handle
        in b9c2207e1b5247b4d3184b137be9a75a4b8c6c37 and got it wrong.
        
        This reverts commit 2aa2d03ec4e775d9399420c21cd1f2e972984154.
        
        Change-Id: I25e897ea4e38db48cd969a3c21d677701f75a0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137293
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c409a21ce9fb3d864dd53e103b7014a7f2a9a167]

        Removed executable bits on doc files
        
        Change-Id: I29d38299318732c3ca342c2893bc87afcfc22c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137299
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [df31e72e5827a2d1d8e5206bee199a1de125d27d]

        Fix typos
        
        Change-Id: I62b11b80e4d3d2a8bd4c461804f39d8da6a58066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137298
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Stephan Bergmann  <sbergman@redhat.com>  [d022e237f1eb56bfdb65f842b5f0c5ec31334f94]

        More RTTI needed by UBSan now
        
        Presumably after 7a076dd9a6d11aef547f657f525ec0c27a50db58 "use more concrete UNO
        classes in writer", CppunitTest_chart2_export started to fail with
        
        > [_RUN_____] Chart2ExportTest::testStockChart
        [...]
        > warn:sal.osl:3513253:3513253:sal/osl/unx/module.cxx:152: dlopen(instdir/program/libmswordlo.so, 257): instdir/program/libmswordlo.so: undefined symbol: _ZTI12SwXTextFrame
        [...]
        > unknown:0:Chart2ExportTest::testStockChart
        An uncaught exception of type com.sun.star.io.IOException
        - SfxBaseModel::impl_store <file:///tmp/Chart2ExportTest__testStockChart_4uwve4.tmp> failed: 0xc10(Error Area:Io Class:Write Code:16) at sfx2/source/doc/sfxbasemodel.cxx:3205 at sfx2/source/doc/sfxbasemodel.cxx:1783
        
        etc.  (And marking only SwXTextFrame as SAL_DLLPUBLIC_RTTI would then cause
        
        > sw/source/core/unocore/unoframe.cxx:1271:18: error: dynamic_cast from 'com::sun::star::uno::XInterface' with default type visibility to 'SwXTextFrame' with default type visibility [loplugin:dyncastvisibility]
        >         xFrame = dynamic_cast<NameLookupIsHard*>(pFrameFormat->GetXObject().get().get()); // cached?
        >                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hdl:15:40: note: base class 'com::sun::star::uno::XInterface' with default type visibility defined here [loplugin:dyncastvisibility]
        > class SAL_NO_VTABLE SAL_DLLPUBLIC_RTTI XInterface
        > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
        > sw/inc/unotext.hxx:44:7: note: intermediary class 'SwXText' with hidden type visibility defined here [loplugin:dyncastvisibility]
        > class SwXText
        > ~~~~~~^~~~~~~
        > sw/inc/unoframe.hxx:47:7: note: intermediary class 'SwXFrame' with hidden type visibility defined here [loplugin:dyncastvisibility]
        > class SwXFrame : public cppu::WeakImplHelper
        > ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > sw/inc/unoframe.hxx:174:26: note: derived class 'SwXTextFrame' with default type visibility defined here [loplugin:dyncastvisibility]
        > class SAL_DLLPUBLIC_RTTI SwXTextFrame final : public SwXTextFrameBaseClass,
        > ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        in turn.)
        
        Change-Id: I5535853885a471d846458d3c6baf538ef047546b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137300
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [91809c9050193005af1ac611054b16d49bbd1188]

        Removed executable bits on doc files
        
        Change-Id: I20142959913d80e9fb683de8285e6ffde69741f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137265
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1c50d7e229942aacdc9ece7f01f233510500c87e]

        Removed duplicated include
        
        Change-Id: I0ebf29930fd6162c34f3d03ad74aa188839c7e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137023
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6d5399965a44ebe48cc1aa038cee7308636b5527]

        Removed duplicated include and typo
        
        Change-Id: Idd50b3533e8b32e66cb4975e1257048f9233089b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137078
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84b096680fa7a4f15656ce5694796285034ae1e2]

        Removed duplicated include
        
        Change-Id: I4c12d6f27957b344b2f04215ef4e76595bd5c21f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137020
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5bca4d8a7627228e2d9583a065d1c3ab866104b8]

        Remove duplicated include
        
        Change-Id: I78af6fe3599bfcd7ce2c167936589e48f68608c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137297
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e6168781f2feaaea12bf6310366ca2b7a9464250]

        Fix typos
        
        Change-Id: I626c182fc8c9b8fd17000f3ab3739c1bfb334a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137243
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-21  Jean-Pierre Ledure  <jp@ledure.be>  [cd8ab93d9b84ed34d18334e07e1e11bd1728e161]

        ScriptForge - tdf#149983 dialog.Execute() failure
        
        (patch https://gerrit.libreoffice.org/c/core/+/137084 cont'd)
        
        In SF_PythonHelper._PythonDispatcher():
        
        Force a hardcoded call of the methods in the Dialog
        service which may potentially be invoked while the
        dialog is displayed, bypassing the generic CallByName()
        Basic builtin function:
           Activate
           Center
           EndExecute
           Resize
           Execute => was missing in the list
                      Case when a parent dialog opens a child dialog
        (Controls is already hardcoded because returning an array)
        
        Change-Id: Ia12fccbb61362768301df6670161f258b32d3a78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137289
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-07-21  Stephan Bergmann  <sbergman@redhat.com>  [f570de5df5a51a593e5fe361bbd79fa5cd6d8173]

        One more -Werror,-Wunused-result
        
        ...similar to cf69bb4f503eb8b3966d5caf825e0c05264a369e
        "-Werror,-Wunused-result", after c6965c5bcc95430c2a2d01051791d23f2c2f5a5b
        "tdf#145528 add round1Rect to SmartArt text area corrections"
        
        Change-Id: I59292c7e4aae07be2ea46ae5c3db9629fa129a58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137295
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4d42b6fa4e69fed38f069bdc8b24e793ba82626a]

        tdf#119840 don't load redlines in lcl_FindParagraphClassificationField
        
        we don't need them here.
        
        Shaves 10% off load time
        
        Change-Id: I38050c131af24bf0cc7cadb71d0d4d9fa7a5a9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [49e559625dfb38bef82853c588eea88ab4f09a60]

        allocate SwFormatVertOrient inline in SwNumFormat
        
        which reduces allocation overhead when loading some documents
        
        Change-Id: I587752f9a59754e4cbb41963665d8be476f2d8c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Caolán McNamara  <caolanm@redhat.com>  [9659860c56164a3dade94714eabfdafdb90fd1c5]

        tdf#149823 default to MouseWheelBehaviour::FocusOnly
        
        instead of MouseWheelBehaviour::ALWAYS
        
        Change-Id: I77bf4db6ec30c00b680a1091670fa331a026e154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137271
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-21  Caolán McNamara  <caolanm@redhat.com>  [e3f5bf99ab7b558d867449e7142c982d667fc2a0]

        tdf#149823 follow MouseWheelBehaviour for GtkSpinButton
        
        so with FocusOnly set when it doesn't have focus don't react to scroll-events
        
        Change-Id: I520550590c7102ad823b677dfcce184b8b4ca377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-21  Regina Henschel  <rb.henschel@t-online.de>  [c6965c5bcc95430c2a2d01051791d23f2c2f5a5b]

        tdf#145528 add round1Rect to SmartArt text area corrections
        
        Some SmartArt types use text area rectangles different from defaults.
        The new rectangle is available in element <txXfrm>. This patch adds the
        needed corrections for type round1Rect. It is four times used in
        SmartArt 'Titled Matrix' with rotations 0deg, 90deg, 180deg and 270deg.
        
        Change-Id: I8c82b446a982ad93026e976b2a47d509b858858d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137287
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [9426e90c2c339b16487c48cd885a3e4586e1e1f3]

        Cleanup restoring last position
        
        The checks of valid bottom were introduced in commit
        f50ec0bda2a4a6d55217bbc8e82e1a9ab3daaa9f
          Author Martin Gallwey <mtg@openoffice.org>
          Date   Wed May 16 16:08:38 2001 +0000
            #86580#, #86953#, #86294#, make ReadUserDataSequence bullet-proof
        
        Possibly initially, bBrowse passed to SwView::ReadUserData was
        sometimes false; but at some point it became always true, making
        the code using right and bottom (stored in aVis) unreachable. That
        became evident after commit db93b92d78714ed193b3cbe52b18e3cfd9da99b8
          Author Noel Grandin <noel@peralex.com>
          Date   Thu Mar 17 11:21:56 2016 +0200
            loplugin:constantparam in sfx2
        
        So just drop the unused pieces, that for large documents often resulted
        in last position not being restored, because the code exited early at
        nBottom > (m_pWrtShell->GetDocSize().Height()+nAdd) check.
        
        Change-Id: If9b4e6faa2754b94cb1298a7221e70736c94f27e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137186
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-21  Aron Budea  <aron.budea@collabora.com>  [f319363b0e07010eea806c723254f17dacdf1b06]

        tdf#141294 Use DPI scale factor for sidebar width limit in config
        
        And don't lock up if the calculated minimum exceeds the maximum
        (sidebar remains unresizable in that case, however).
        
        Change-Id: Ibe96a43ad5d6a3fe4132a9fb64fe244ab022668d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137267
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [80a900838e46056a9b8886791a490cda0b6254e6]

        elide some makeStringAndClear() calls
        
        Change-Id: Ifd8de0042b843de0766a370fb19b9f7791974612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Miklos Vajna  <vmiklos@collabora.com>  [1dce9ee7e12871ee63434499db805e806b9e9d3c]

        sw content controls, plain text: apply formatting to the entire contents
        
        The difference between normal (rich text) content control and a plain
        text one is that if you try to format a subset of the contents, that's
        possible in the rich text case, but the plain text case extends the
        formatted range to the entire content control.
        
        Handle this in SwTextNode::InsertHint(), similar to how it's done for
        input fields.
        
        Change-Id: I9a1ad0095f0ca810da24d5c4ce4aa48d1ac59225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137280
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc6e6fe77f089ccfc6b94bbf80538f674e412118]

        elide some makeStringAndClear() calls
        
        Change-Id: Id81a0c0046d0d84e6c327eef4447b21fecae6ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [faa40c022ccee7c28de98472699ca26aa8aa827b]

        elide some makeStringAndClear() calls
        
        Change-Id: I8636102554a76f2ba3f6297219b40761473a4489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137285
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Gabor Kelemen  <kelemeng@gnome.hu>  [716c5a3c199f52a3d5c67e2c3af7702748b7f685]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to da7edbd2fd925bd80fdd6affe2ff6510c8ac1c5d
          - (related) tdf#134281 tdf#149351 Update shortcuts descriptions
            
            usable on the Presenter Console and the presentation canvas.
            
            Also the one added in c11b6b64f63b3c7f8f8bb0f1857a9c7d8748ba9c
            
            Change-Id: I55a392730ca24f92cac1e11e1f3c2ef1771a00d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137240
            Tested-by: Jenkins
            Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
            
2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6d4a664869a8bcbd01053cf152d7f455939ab46]

        shrink size of SwRangeRedline
        
        by re-arranging members, remove holes in the structure
        
        Change-Id: I934d4867f29bdd1bfd4e6afb8d8ed0ccc88ca219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [a0bcd1d187a4e56a9fa600462842004545b6be9c]

        tdf33787 lotuswordpro: fix increments of ordered bullets
        
        With previous implementation there was an bug which causing missing
        incrementing ordered bullets. For example:
        
                A. Lettered bullet uppercase 1 (A. )
                A. Lettered bullet uppercase 2 (B. )
                A. Lettered bullet uppercase 3 (C. )
        
        This patch is fixing that, and increments is working correctly:
        
                A. Lettered bullet uppercase 1 (A. )
                B. Lettered bullet uppercase 2 (B. )
                C. Lettered bullet uppercase 3 (C. )
        
        It is also make sure that nested and skipped bullets are working correctly:
        
                1) Numbered bullet w/ bracket one (1) )
                   Skipped bullet
                2) Numbered bullet w/ bracket two (2) )
                    a) Lettered bullet w/ bracket lowercase 1 (a) )
                    b) Lettered bullet w/ bracket lowercase 2 (b) )
        
        Change-Id: I1d1ad9ee549039077b418756efefb10bacfa1ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137112
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-07-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d449da36086409e3cc440036193c4fc8a10a37a1]

        tdf#123983 fix loading graphic that is in root folder + test
        
        We need to detect that the storage name is empty, so in that case
        the root storage needs to be set as the current storage.
        
        Change-Id: Ibe3287ccf1f1513a3531dcf4d540a456cca8dfb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137276
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c24f112ad86df77f2de27a31742bca01ed56bdf]

        chart2: apply line props. to borders when rendering a data table
        
        This sets the color, line width, line style to the borders of
        the table when rendering the data table. We also need the
        ChartModel inside DataTableView, so we can access the needed
        line dashes.
        
        Change-Id: Id3bef23b75e88517d6569ad87a716f178ed64343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137158
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a076dd9a6d11aef547f657f525ec0c27a50db58]

        use more concrete UNO classes in writer
        
        as opposed to opaque UNO interfaces.
        This is a prelude which enables performance work because now I can
        regular C++ method
        
        Change-Id: I9bcfdca1000b4439431c9ea3b17bed081d80f0b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [85f4938719180e1e344b28c073f909df6f972f96]

        clang-tidy modernize-pass-by-value in svx
        
        Change-Id: Iedd87d321f4d161574df87629fdd6c7714ff31c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-21  Stephan Bergmann  <sbergman@redhat.com>  [cf69bb4f503eb8b3966d5caf825e0c05264a369e]

        -Werror,-Wunused-result
        
        ...when building against a recent libc++ that marks std::clamp [[nodiscard]], in
        code newly introduced in 7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0 "tdf#149551
        separate TextRotateAngle from TextPreRotateAngle"
        
        Change-Id: Ifdce627b5d76fac269f1403e7bb98d4576dfa682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137257
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-20  Stephan Bergmann  <sbergman@redhat.com>  [eea7038c182cc1f6cd792359053ea2561a200026]

        Fix CppunitTest_vcl_svm_test for big endian
        
        These crc values are the results of Bitmap::GetChecksum() calls, and for
        headless Linux the formats of those bitmaps (ScanlineFormat::N24BitTcBgr |
        ScanlineFormat::TopDown vs. ScanlineFormat::N24BitTcRgb |
        ScanlineFormat::TopDown) depend on little vs. big endian (see the definition of
        SVP_24BIT_FORMAT in vcl/inc/headless/CairoCommon.hxx), so these tests failed on
        big endian Linux s390x.
        
        So I updated the tests with whatever values I got reported on s390x, whether or
        not those values are actually correct...
        
        Change-Id: I05d2b656ae2e0cf00cd870b895e1bf3cb9cf82f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137270
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-20  Miklos Vajna  <vmiklos@collabora.com>  [da8e95ebe0dce032cfbe37602ebb013869dc1e6d]

        sw content controls, plain text: add doc model & UNO API
        
        OOXML's <w:sdt> with <w:text> describes a plain text content control. We
        are currently mapping this to fields, and then on export it's possible
        to map this to FORMTEXT fields. The trouble is that our doc model could
        not differentiate between content controls and fields for non-formatted
        form text, so the exporter can't do the opposite of import.
        
        This has the benefit that input fields do a reasonable job of providing
        the feature set of plain text content controls, but it has the downside
        that we map two OOXML features to a single Writer concept, loosing
        formatting.
        
        Fix this by introducing a dedicated "plain text" content control type,
        which can be used for OOXML's <w:sdt> with <w:text>, and keep using the
        input field only for OOXML fields.
        
        This commit just adds the document model & UNO API, follow-up commits
        will add the remaining functionality.
        
        Change-Id: I0a0317adbd5f58c6ab880dccf6170292462d2671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137263
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-20  Hannah Meeks  <hmeeks4135@gmail.com>  [4205fb723144e825ae75e977034a6df1a99f4881]

        VBA Fix off by one error in setting range
        
        xEnd should not be smaller than xStart for compatibility
        Add first Document tests
        
        Change-Id: Ia8898d79db8c2885c6253ee9aaca793082b9dd20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137262
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-20  Hannah Meeks  <hmeeks4135@gmail.com>  [f6d45f07fcbb33ce542f128caf90064a85a91d31]

        VBA: Selection.Find should select whole doc if no prior selection.
        
        Change-Id: I8b77ae982a772a95290aea186f4fe6556f2a2e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137202
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-20  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [1844326df477eb379f281e6f027fc8e6475f28bf]

        tdf#141421 xml export: default stacksize for threads on macOS is too small
        
        libxslt usage means lots of recursion for the sample document and the default
        for non-main threads is 512kB, see
        https://developer.apple.com/library/archive/qa/qa1419/_index.html
        and contrary to linux it doesn't default to the value set via ulimit.
        
        https://docs.microsoft.com/en-us/windows/win32/procthread/thread-stack-size
        says default for Windows is 1MB, so use that as a new default.
        (on linux it effectively is 8MB via ulimit, if not specified it would default
        to 2MB for most architectures)
        
        Change-Id: I10bd25301b0aea83e5bbb0c2103a0dd47a7e0736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137269
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-20  Stephan Bergmann  <sbergman@redhat.com>  [eda0c48278da6549c01c9f0ce4f469249e420d63]

        Make combineScanlineChannels stop before padding bytes
        
        At <https://ci.libreoffice.org/job/lo_ubsan/2467>,
        CppunitTest_sd_export_tests-ooxml1 failed with
        
        > ==4831==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000211c54 at pc 0x7fcdcb44093f bp 0x7ffe85792760 sp 0x7ffe85792758
        > READ of size 1 at 0x629000211c54 thread T0
        >     #0 0x7fcdcb44093e in (anonymous namespace)::combineScanlineChannels(unsigned char*, unsigned char*, unsigned char*, unsigned int) /vcl/source/filter/png/PngImageWriter.cxx:27:22
        >     #1 0x7fcdcb43fbaf in vcl::pngWrite(SvStream&, BitmapEx const&, int, bool, bool, std::__debug::vector<vcl::PngChunk, std::allocator<vcl::PngChunk> > const&) /vcl/source/filter/png/PngImageWriter.cxx:231:21
        >     #2 0x7fcdcb43ce80 in vcl::PngImageWriter::write(BitmapEx const&) /vcl/source/filter/png/PngImageWriter.cxx:318:12
        >     #3 0x7fcdcaf04bc1 in GraphicFilter::ExportGraphic(Graphic const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >, SvStream&, unsigned short, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const*) /vcl/source/filter/graphicfilter.cxx:1801:28
        > 0x629000211c54 is located 0 bytes to the right of 19028-byte region [0x62900020d200,0x629000211c54)
        > allocated by thread T0 here:
        >     #0 0x4fd898 in operator new[](unsigned long) /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_new_delete.cpp:102
        >     #1 0x7fcdcbcbd50b in ImplCreateDIB(Size const&, vcl::PixelFormat, BitmapPalette const&) /vcl/headless/svpbmp.cxx:123:24
        >     #2 0x7fcdcbcbb483 in SvpSalBitmap::Create(Size const&, vcl::PixelFormat, BitmapPalette const&) /vcl/headless/svpbmp.cxx:152:13
        >     #3 0x7fcdca406c59 in Bitmap::Bitmap(Size const&, vcl::PixelFormat, BitmapPalette const*) /vcl/source/bitmap/bitmap.cxx:136:15
        
        because for the given N24BitTcBgr bitmap of size 89x71 we have
        pAccess->GetScanlineSize() = 268 = 89 * 3 + 1, so combineScanlineChannels wanted
        to erroneously read an excessive 90th RGB triplet.
        
        Change-Id: Ida117999de075b8906f43bfe4c2b7fa98df80b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137261
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-20  Regina Henschel  <rb.henschel@t-online.de>  [2f3b87d18a688b022a18a8b20b69b10cd6af7748]

        tdf#149551 Unit tests for insets in SmartArt
        
        This is followup to commit 7e23cbdb. That commit contains for several
        types of shapes a correction of the position and size of the text area
        rectangle.
        That commit fixes bugs tdf#59802, tdf#136234, tdf#118009 and duplicate
        tdf#142841 were the here tested shape types are involved.
        
        Change-Id: I7c8c9676cf3dbdcc3f91fe25d75901b63d0ca4da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137264
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-07-20  Miklos Vajna  <vmiklos@collabora.com>  [92914312cfb36a86ceb6308a2966f033152fd927]

        external: update pdfium to 5187
        
        build.patch.1 is extended to avoid:
        
        > C:/lo/master/workdir/UnpackedTarball/pdfium/third_party/libopenjpeg/openjpeg.c(438): error C2491: 'opj_decoder_set_strict_mode': definition of dllimport function not allowed
        
        and also is extended to avoid:
        
        > /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/stl_tree.h:2028:5: note:   no known conversion for argument 1 from ‘std::pair<fxcrt::RetainPtr<CPDF_Object>, std::unique_ptr<CPDF_PageObjectAvail> >::first_type {aka fxcrt::RetainPtr<CPDF_Object>}’ to ‘const CPDF_Object* const&’
        
        Change-Id: Icacc05627a8612b33d6445685d26470e7c757b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137238
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-20  Gülşah Köse  <gulsah.kose@collabora.com>  [9790585a62cb55e0e0024819596592193a6de269]

        tdf#149915 Proper creation of vnd.sun.star.pkg:// URL
        
        Using different methods of creation (one using DecodeMechanism::NONE,
        another using DecodeMechanism::WithCharset) gave differently encoded
        end results, comparing unequal.
        
        The proper way is using DecodeMechanism::NONE on the document's URL,
        as implemented in commit 06756e412b2a02030ce3355b3fe4e2ecc71d2301
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Sat Nov 18 22:41:40 2017 +0300
            One more proper construction of vnd.sun.star.pkg URL
        
        Co-authored-by: Mike Kaganski <mike.kaganski@collabora.com>
        
        Change-Id: I272f277ef8b4bd23e6cb7884e68f3c79f742683a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136901
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-20  Caolán McNamara  <caolanm@redhat.com>  [f37395de7177b7724c7b7d03e5b52e8da90c44d2]

        ofz#48366 Timeout
        
        Change-Id: Id643e80696843e0c22ae7eee2b5862320948ae27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137249
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-20  Caolán McNamara  <caolanm@redhat.com>  [779fc912b21102b6aed4109dc6b5d3f5937d2b4d]

        ofz#49200 Timeout
        
        disable slow path for fuzzing
        
        Change-Id: Ic23d7ba56210915b53b4330edb44458a672ba4ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137255
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-20  Gabor Kelemen  <kelemeng@ubuntu.com>  [2d466a95fc3c35c7ef00e6d6d8b97d4721372173]

        tdf#92610 Fix missing/conflicting accelerators on Header/Footer tab page
        
        Change-Id: I54099745b1246b474d2f389b7c87abb18d944cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137241
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-07-20  Hannah Meeks  <hmeeks4135@gmail.com>  [4a49644c97c0f2c3e14a931592f28044a8596425]

        VBA: Add Select Method to ActiveDocument
        
        Change-Id: I0d8d02c555fd113b96661085b339b12d83c6010f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137109
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-20  Hannah Meeks  <hmeeks4135@gmail.com>  [4d945a41bc15412b20490535ac322b01953b64b6]

        VBA: Add test documents for vba
        
        Mostly disabled for now pending core fixing
        
        Change-Id: Idf71cea820c52f2b56fb26b1d8de2666026bf90e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137105
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-20  Justin Luth  <jluth@mail.com>  [b4c55cb614ae1601d7cae4bc87aca3d5396c1598]

        tdf#139759 doc import: import comment highlight/shade
        
        Round-tripping depends on earlier commits for this bug.
        
        These two attributes are SvxColorItems in EditEng,
        but SvxBrushItems in Writer. So direct mapping doesn't work.
        
        Although it might be a highlight, LO doesn't have such a silly
        duplicate thing in the editeng code. So just map this as
        the same thing used for normal char background.
        
        As of LO 7.x, we default to exporting as char background anyway,
        so highlight is on the way out in LO.
        
        P.S. Highlight is one of 17-ish colors. It is the background
        button in the Char panel in MS Word. Background is on Word's
        Para panel (even though it is a character property),
        and so it can fairly easily be removed in MS Word.
        
        Change-Id: Id25879d90ba4a0eeff2d6afed030fc029d1c1039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137239
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-20  Miklos Vajna  <vmiklos@collabora.com>  [7d56dae3375dc0180aa6d20983b3f5f962302588]

        tdf#127236 vcl: fix missing encryption of PDF images during export
        
        Regression from commit 78e25558e86188314b9b72048b8ddca18697cb86
        (tdf#106059 PDF export: create a reference XObject for JPG images with
        PDF data, 2017-02-23), once a PDF image was inserted to a document, an
        encrypted PDF export lost those images.
        
        The reason for this is that we started to preserve PDF images as vector
        data with the above commit, but this means we copied over PDF objects
        from PDF images to the export result as-is, so encryption was not
        performed for them.
        
        Fix this by separating the write of the PDF object headers, stream
        content and object footer and then calling
        checkAndEnableStreamEncryption() / disableStreamEncryption() for each
        object, even if it's not something our PDF export created but comes from
        a PDF image.
        
        Note that when existing PDF files are signed, PDF objects are also
        copied into a vcl::filter::PDFDocument, but such PDF images are never
        encrypted, so it's fine to have stub implementations in
        vcl::filter::PDFDocument.
        
        Change-Id: I2f74b9f51cd35b4319221532ca890e197bab9cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137242
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [845393b9aa9057c5ace3c41ad5ac629b895d7f7f]

        move wintypes.hxx from tools to vcl
        
        Change-Id: Ief9949fd4252de9e33df172af07aa7ed097b5520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136560
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-20  Caolán McNamara  <caolanm@redhat.com>  [6721eddbcfefd9503a49499956e53d1a76f6712f]

        forcepoint#107: reproducible testcase
        
        make this reproducible without asan
        
        Change-Id: I32cee0a22616e96d85c59d76319a6f6074fcde8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136228
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-20  Regina Henschel  <rb.henschel@t-online.de>  [7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0]

        tdf#149551 separate TextRotateAngle from TextPreRotateAngle
        
        The import filter had only one member for both and had it mapped to
        TextPreRotateAngle. That resulted in lost text area rotation when a
        shape had both types of rotations, and sheared text when only text
        area rotation existed.
        
        The patch introduces a new 'moTextAreaRotation' member for the 'rot'
        attribute of the <bodyPr> element. It is mapped to 'TextRotateAngle'
        property. It becomes the 'draw:text-rotate-angle' attribute of the
        <draw:enhanced-geometry> element for a shape and 'style:rotate-angle'
        for chart elements in ODF. It must also be used to simulate 'upright'
        and is used for the 'rot' attribute in <txXfrm> of diagram shapes.
        
        The 'moRotation' member is now only used for the 'TextPreRotateAngle'
        property. That angle describes a rotation of the text without changing
        the text area. Valid values are multiples of 90deg. It is used for
        simulating vertical writing modes that are not yet implemented. It has
        no corresponding attribute in ODF. To make the meaning clear in code,
        the member is renamed to 'moTextPreRotation'.
        
        MS Office recalutes a diagram on file opening from layout.xml and
        data.xml. That is not yet implemented in LO, but we use drawing.xml,
        which gives the state of the diagram at time of saving. The patch
        handles the 'rot' attribute of <txXfrm> element as well. It has to be
        mapped to moTextAreaRotation, because it might contain angles, which
        are not multiples of 90deg, for example diagram 'Gear'.
        
        The <off> and <ext> child elements of <txXfrm> describe the actual used
        text area rectangle. The existing import calculates the difference of
        the actual used text area rectangle to the predefined one and
        incorporates it into the TextArea*Distance attributes. The patch adds
        calculating the current values of the text area rectangle as it would
        be using the preset markup. At that time in import there is no
        SdrObjCustomShape object, thus we cannot use its GetTextBounds() method.
        So it is down manually, covering most of those types, which are used in
        diagrams of MS Office.
        
        Remarks to unit tests:
        Now the rotation introduced by txXfrm is no longer in
        TextPreRotateAngle, but in TextRotateAngle. According changes are in
        SdImportTest::testN86510_2
        Test, testFdo87488
        
        Now the correct preset text area rectangles are used. That requires
        adaption of the needed distances. Done in
        SdImportTest::testBnc870237()
        SdImportTest::testTdf93830()
        SdImportTestSmartArt::testTdf134221()
        
        The buggy 'upright' export is fixed. Adaption in
        ScExportTest2::testTdf137000_handle_upright()
        
        Change-Id: I79df1559f88b76e96988fe745304dc4162de6316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136447
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-20  offtkp  <parisoplop@gmail.com>  [65f1903921c448da61733ca0d47c2ffc862b201d]

        Remove pngwrite.hxx and .cxx as it is replaced by PngImageWriter
        
        pngwrite is now replaced by PngImageWriter which uses libpng so these
        old files are removed.
        
        Change-Id: Ie91c314f30b8f56682890000b90009f408a79094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137140
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Caolán McNamara  <caolanm@redhat.com>  [21a31eefab1401d288dbb8220f3df3365be9efaf]

        tdf#149439 set initial customoption values from lpoptions when present
        
        I presume there's a better way to do all this.
        
        Change-Id: Id7e6cd3be5b82e419f17bba31834fef7cfe8299b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [48ce29b53eda95629d1b75ee3469780cd38fd2fa]

        Fix typo
        
        Change-Id: I1ad198827abb2b7a8fd9165deeb85c56c5c1c255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137226
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [44422b97e9d6398919445363b81b4cd1ab184ce3]

        vcl: AInfo -> AnimationData
        
        Change-Id: I4a4f8e2e346010edd1fde004eb9f14b67fc8487a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76407
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [93b07a377b93875b28464546f1292e4aa5f9e17d]

        tdf#149985: sd_import_tests2: Add unittest
        
        Change-Id: I0ce12e862ca90ab62da508820aecb3bce93445b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137235
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-19  Justin Luth  <jluth@mail.com>  [d4ea357e3cf1328597716c701adc255ec8f70a2c]

        tdf#135794 sw: add no-headers to AllowCommentsInFootnotes
        
        DOCX also doesn't allow comments in headers / footers
        so add that situation to the existing option that
        was attempting to improve DOCX compatibility.
        
        By default, comments are still allowed in headers.
        
        Change-Id: I5f9ee59cc0292e41e57ba46fa7cf41ac691acabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137210
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfe3479e99b5f94e5afefb3af88726786857fcb5]

        tdf#119840 reduce lines we need to scan in CompressRedlines
        
        .. to start at the point we modified things.
        
        Reduces load time by approx 10%
        
        Change-Id: I37214247f0cb7b1246c498aba6c2085bf12a21aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4701d17bfe785f00958ad58a63dc0ece4c5c3281]

        tdf#119840 loop backwards in DocumentRedlineManager::SplitRedline
        
        reduces load time by approx 20%
        
        Change-Id: Id1314ed640e54a104cfe26e4784c847f43ce64bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137231
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-19  offtkp  <parisoplop@gmail.com>  [65b29c5d38012f7c95ee0ee2070d11f679cbf3d3]

        Don't compare using long in PngFilterTest
        
        Change-Id: Ia6f0f7339e3e42acb2fe14eda914b21fc51b7d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137236
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-19  László Németh  <nemeth@numbertext.org>  [85a044abdf08bafa93e1caddf38f86e35d7e17f2]

        tdf#148913 sw: fix crash with pending infobars on Windows
        
        Usage of VclPtr<SfxInfoBarWindow> wasn't thread-safe
        on Windows, resulting random crashing during loading big
        documents.
        
        Regression from commit d89786054715b44aa983d0752484216825c74ae2
        "tdf#125909 tdf#141298 sw: show (Hidden) Track Changes infobar".
        
        Change-Id: Ic6a6ad43a8cf7ea650ef6d1c0aa5c76c48763ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137230
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-19  Michael Stahl  <michael.stahl@allotropia.de>  [a1ca68e91868df51a269682f7c3dac62a88a85ef]

        tdf#149170 sfx2: fix regression about spurious dialog
        
        Open a document that is locked, choose Read-Only, then click "Edit" on
        infobar: it is still locked, so a dialog pops up. Click "Cancel".
        
        Now a *second* dialog pops up that *again* asks if you want to open a
        copy of the document - this appears pointless so let's remove it.
        
        Change-Id: Id96a1211caea63e7559c67b08a6581d1a0ce9add
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137234
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-19  offtkp  <parisoplop@gmail.com>  [0ef286389e4f40fd59890937c6c6b1e7ce4a5064]

        Replace old png writer in pdfverify.cxx
        
        Change-Id: Iee38f9e86151717001ec4e4c083ec658603ad7c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137139
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [88e55fb61ef626099e2a43562d788cf75d86fdf2]

        Remove unused pngwrite.hxx include in vcldemo.cxx
        
        Change-Id: I8fe829eb34c07c2da47d93ef07f3dee098a9eed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137138
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Balazs Varga  <balazs.varga.extern@allotropia.de>  [8fa6a1f628ca9df5d910db2b2aa7328e1d6220d7]

        tdf#119491 sc odf export: fix password protection of shared files
        
        Handle SID_ENCRYPTIONDATA for shared password protected docs.
        
        Change-Id: If9554a991a39d6be45ed688a0bd638cd166589c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137146
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-07-19  offtkp  <parisoplop@gmail.com>  [b8c0b8b06cd24480c66f3bf657576e3dde03a5a6]

        Replace old png writer in gtksalmenu.cxx
        
        Change-Id: I6851d7a6c8bbd1fbb02b3ba74f46d13e1fd80223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137137
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [7785a62cd74e5924e4ade4d69519966c63a0decf]

        Replace old png writer in transfer.cxx
        
        Change-Id: I1423bd4e7650da71f31de50df8a88ee3c09db33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137135
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [20d0d2d2ff5ee0b8e1f40ca1adda115a82d974b6]

        Replace old png writer in gtkinst.cxx
        
        Change-Id: I5a9aefe1b957b800b5c56f3200d28ef727324cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137136
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [f5371a2e5367ab4cb1cd62efb18e46872159a94e]

        Replace old png writer in OpenGLHelper.cxx
        
        Change-Id: I028db48230fae64a539ee0a7964d73c039289740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137134
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [a91d5e5a69682ac857e39f6d015b6c8470273e96]

        Replace old png writer in ImplImageTree.cxx
        
        Change-Id: I26702462ec19056f33a582083e69630bec1fb3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137133
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [e50ff311ceda513fdcff4b73546d039bb847a0b9]

        Replace old png writer in QtTools.cxx
        
        Change-Id: I4f6438b811e7e97aedda90508423982cb82e0008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137131
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [c6082fd9fe2b1f1c3af6c7086a436405ad4c92b6]

        Replace old png writer in svmtest.cxx
        
        Change-Id: Iebd1dbf56fe4305871b9a091488ee5acd4f58814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137130
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [a4a0e7b24c34e67756668ae8381203b7cca3d6fe]

        Replace old png writer in baseindex.cxx
        
        Change-Id: I660579ed6ea886f9ab3fc913b785f92740f48dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137125
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [2bd224ba3b42cdada2c35ca3a513f90e5cf6b69b]

        Replace old png writer in screenshot_test.cxx
        
        Change-Id: I5271b56bcce32e1ce71544421b9581518b05455e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137124
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [f5703b39898b737f9b4bf34f0abdd07f24f065e2]

        Replace old png writer in sfxpicklist.cxx
        
        Change-Id: I8dd9925ea07fa16cea6918eef0e6d468d7b743c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137123
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [601ba8d8dfdc613ad801f1a7d66436d5e3c8fc4f]

        Replace old png writer in SlsBitmapCompressor.cxx
        
        Change-Id: Idc8ddcce918c5258f623f3b9065cfb523cb23629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137122
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [21ad38b61618c7bc4daea4e0e7989d8b21bd1150]

        Replace old png writer in imagemanagerimpl.cxx
        
        Change-Id: I8bc30a218b67d165d1a8ae3d663e5482a8113aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137118
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [d35ccaf7c3c6f5a8f4223de3c63de2d6f8f6324a]

        Replace old png writer in emfreader.cxx
        
        Change-Id: Ibc3ed62d5d09d2da9d7866deb21f49340ba71eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137117
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [6203edf731f4cd3e678691af05def22394db2a89]

        Replace old png writer in converters.cxx
        
        Change-Id: I360963c2ad36a7bce5a257c9740b1e5690efc8e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137116
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [605e391874e08484111ac760d5b353b7d4db6517]

        Replace old png writer in test_desktop_lib.cxx
        
        Change-Id: I9f73b316521bcacb9042375adef3a3339ab2166f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137115
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [4bd2aaaaaed3db9e71e756f9ae004d5fa6afd8cd]

        Replace old png writer in screenshotannotationdlg.cxx
        
        Change-Id: I21fbd95db7f8a9f036c5ecfbd08d7a46a9683dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137114
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [48eb565e2e62951eba712c64989c33b87e60ccbd]

        Replace old png writer in emfplus.cxx
        
        Change-Id: Ibdc550e55d73ed71def6e5aef129520ab2062eeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136936
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [1d548a2bc70e0b38e32ccae8b15b04bda84f3576]

        Replace old png writer in graphicfilter.cxx
        
        Change-Id: I68b35e82fd5ca4de87b3b9c3c6be5cf802f071ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137132
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [4d9e9ff5f4cb199844eb1d2b4000bb837089347f]

        vcl: allow OutputDevice::GetTextRect() cater for rotated fonts
        
        Change-Id: I52bdfe75ef1dd7973d14cad72e31a1e559bb7876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136667
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Stephan Bergmann  <sbergman@redhat.com>  [f9902fc13aaf2c4614125d78c653435ae454de3a]

        Fix endian-dependent test for good
        
        SvmTest::testComment introduced in e10df88b8ae4138862d4dd25c221189878641aa4 "Add
        Comment cppunit test to vcl" calls SvmTest::checkComment twice, first for a
        programmatically generated svm document, and then for the canned
        vcl/qa/cppunit/svm/data/comment.svm.  4f533655dd635dab30574c2a3b3915377124bd60
        "this test is endian-dependant" had fixed the endian-dependent check in
        SvmTest::checkComment for the first, programmatically generated case, but broke
        it for the second, canned case.  As seen on s390x:
        
        > xmltesttools.cxx:171:Assertion
        > Test name: SvmTest::testComment
        > equality assertion failed
        > - Expected: 00540068006500730065002000610072006500200073006f006d00650020007400650073007400200064006100740061
        > - Actual  : 540068006500730065002000610072006500200073006f006d0065002000740065007300740020006400610074006100
        > - In <>, attribute 'data' of '/metafile/comment[2]' incorrect value.
        
        So just not make the problematic MetaCommentAction payload endian-dependent in
        the first place.  (And one wonders why the test even needs to test such a
        problematic payload.)
        
        Change-Id: I203dae6545e0d4e63e7c2d521a27c661e1cf633c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137223
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-19  Caolán McNamara  <caolanm@redhat.com>  [878292b56d552d18a72c5dd4642dcefbc196c8de]

        crashtesting: assert seen on loading moz820988-2.svg
        
        Change-Id: I8ceab08348875cd8a88c440091ac0227012ab358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [4c3a23832ca8ee88d366e16adabea05a98ffeccb]

        Related: tdf#149990 solenv/bin/desktop-translate.py readability
        
        Satisfies many pylint suggestions and includes a formatting pass with Black.
        
        Change-Id: I33794902ab303f63b52a3412e4e4d18b492cc74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137101
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [9e7aee7c85b5ef341705d2969461bc96743fcbcc]

        vcl: migrate from getOpenHeight/Width() to GetWidth/Height()
        
        Change-Id: Ia51d6a6f2e9dcb6ba6193f7617848e7bd560dabb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137170
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Laurent BP  <laurent.balland-poirier@laposte.net>  [bad664731dc8da6fb9f9706111d1de866c650ed0]

        Simplify the template makefile
        
        Remove unused variable
        
        Change-Id: If2e69f30e8f94d662d619ded6b85f2a737ef3412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137196
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb9d618390c8a498ce6348d7ed77235165cede7b]

        get-forum-attachments: Add 2 more mso forums
        
        Change-Id: I5134ec5e39e398544764e4e50b6b50280759151d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136621
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-19  Jean-Pierre Ledure  <jp@ledure.be>  [0a2d22ceac6236fc999db368cc6201c6153dd71b]

        ScriptForge - (SF_Dialog) trap errors caused by dialog events
        
        A dialog is started with the Execute() method.
        
        During its life span user scripts may be executed
        as a consequence of mouse clicks etc.
        
        When those scripts contain errors and they are not
        trapped;
        - in the actual situation, the error is detected by
          ScriptForge and considered as an internal error
        - this new commit considers the error as a user error.
        
        The help pages should be completed to promote the
        use of errors trapping inside scripts triggered
        by events.
        
        Change-Id: Iba3eefc75d305c17e6e1d9d416496882e0f816bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137203
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a9d06eac4db5ac1595b8643a64d18c4a818ac96]

        tdf#119840 remove some unnecessary comparisons
        
        Change-Id: I1c997edfa315ca86356c014c4f091423ff8d4240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [0649dc97bed5639cee20320ce2ae9b9d764cc99f]

        tdf#119840 use more StartEnd()
        
        Change-Id: Ib3d08b9ad766cd257be0dbd7b4950add0b355bf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-19  Stephan Bergmann  <sbergman@redhat.com>  [7606a0652cd4adfdfc464ac0595158f6ec193212]

        Use more appropriate index variable type
        
        Change-Id: I85d2dec9f5dc8fd09c7efa33f7c8518b7fabd4b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137216
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-19  Stephan Bergmann  <sbergman@redhat.com>  [94d35d1cc5bea93b87aea86459ce5e8f1686600c]

        No need to cast to char here
        
        ...similar to 85d15cfaf9b0665d907e099d6588dea0ced556ff "No need to cast to char
        here"
        
        Change-Id: I9f8b226e90d67f49fb38f9139c03529add787c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137214
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-19  Stephan Bergmann  <sbergman@redhat.com>  [f9b747f35bb969c4ac8a2ca51f66f204f61615c5]

        nIdx is guaranteed to be non-negative here
        
        Change-Id: I692f24a923075c52e260b635a6ca235f89410e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137215
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [fac9dfa19b3853e4b1b6ec62baf1645a8b1194c9]

        Add 32bpp export support in PngImageWriter
        
        Also added support for "Translucent" property
        
        Change-Id: I45cc3cf82ecacac08c3852ca2ad09fb8137ffc44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137154
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [9e775a73240c6d73d679409d0753334f8494ed14]

        Add pHYs chunk export support in PngImageWriter
        
        Change-Id: Idbb9c8222cbfce9d908a0b17d082de291cd0e0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137145
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [089b101e5447aac42e6fc79345e60da3ec63893d]

        Add ms-gif PNG chunk export support in PngImageWriter
        
        Added export support for msOG chunks in the new PngImageWriter
        and unit test
        
        Change-Id: I258c9ca23e41c1d5ce01fc6711bc55c13636db17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137093
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [3d1032cf6b67f3f6fa539d1d42d681080517d38c]

        Add PngImageWriter 8 bit palette export support
        
        Also add test that fills a 256 color palette, exports a 16x16 image and
        reimports it and checks each pixel color
        
        Change-Id: Id53f3116e42d669cd528edfd791a1a981551ae0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136817
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [80395bf5f2bc7d48c690893abf8604540c24806f]

        Add PngImageWriter 1 bit palette export support
        
        Added support for exporting 1 bit palette png for non grayscale images
        and unit test
        
        Change-Id: I0b4c63c922fad4e42c7db61e81c553c69dd6bff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136813
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [4347a032d34497f324a944629dfb49702cb3c54c]

        Add PngSuite .png test files and test function
        
        Add testPngSuite function that tests the PngSuite files against width
        and height, bit depth, whether it's paletted or if it has alpha
        
        To be used with the new pngreader/writer to
        verify that it was implemented correctly
        
        Change-Id: Ic334df36735fabcde71ecec7fbf463e255b06d4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136359
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  offtkp  <parisoplop@gmail.com>  [6b4f4bdf9beb0c73fa8b8bc218cd206f2cd347fa]

        vcl: add PNG writer based on libpng
        
        Add PngImageWriter, a new png writer that uses libpng to replace
        our own at pngwrite.cxx
        
        PS: most of the work on this commit is done by Tomaž
        
        Change-Id: I52ffd1b286162ee0dd9f694c4f3210385f71daf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136008
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-19  Miklos Vajna  <vmiklos@collabora.com>  [40405372fe0bbc00e67f5b0185b0d4c2d6c1e08d]

        sw content control, date: allow selecting via the keyboard
        
        It was not possible to select the date of a date content control via
        keyboard.
        
        This meant only the mouse handling codepath needed implementing, but it
        broke accessibility.
        
        SwContentControl::ShouldOpenPopup() already knows how to handle
        dropdowns via the keyboard, extend that to handle date pickers as well.
        
        The appearing vcl Calendar / GtkCalendar appears to support keyboard
        navigation already.
        
        Change-Id: Ic36419f69cbcdba1a9069332184966cb4b347c49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137213
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-19  Miklos Vajna  <vmiklos@collabora.com>  [da9ef0bd92e7ad81d0595d57225ef5b20ea8f66c]

        sw: document SwCondCollPage
        
        This is not available in the normal paragraph properties dialog and for
        non-conditional paragraph styles, so it's a bit tricky to find.
        
        Change-Id: I6ce4ce29fce6285668d8b058b0b250e662d3f8bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137212
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-19  Stephan Bergmann  <sbergman@redhat.com>  [94efbeca0ae9757f706f3618d633eadeb7b37442]

        Consolidate writeBytes functions
        
        Change-Id: I44db198967a37f8b11f1b185a8b093b0de2d500d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137205
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-19  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [a2c5a29f76fa75d920b27149f1dffca1ca84177d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cf2296c78c6aad2f57c6e1fa4e7c50a34f340f33
          - Fundamental confusion: *“Beware that” → “Be aware that”
            
            Change-Id: I7f6b830a87bbdf2380c32d515554cb9836b50848
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/137211
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36994c19fdbf425108f685de21464496bd93b651]

        Fix typo
        
        Change-Id: Id4fd670d2c3e4212827b192c529c8dba4f9c8dff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137209
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-19  Justin Luth  <jluth@mail.com>  [e88c41b552ab958579baf3e4bccf941b588a537c]

        tdf#135794 sw: add no-frames to AllowCommentsInFootnotes
        
        DOCX also doesn't allow comments in textboxs / frames,
        so add that situation to the existing option that
        was attempting to improve DOCX compatibility.
        
        By default, comments are allowed in frames.
        
        Although the option name is worded fairly specifically,
        I don't see any reason for adding a second option.
        I also didn't want to change the name to be more generic
        since this has been in existance since 6.4.
        
        Change-Id: I3cc8631b4379a0523f2556ff99aed9127016485c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137010
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2022-07-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [47c428537154cd94b1d9a7547bde21ce711abd0d]

        related: tdf#97539: SVGIO: iterate over parent's clippaths
        
        This commit reintroduces fb33451a27d8668bc14f5bcfd6ea742fc4c5b84c
        "tdf#97539: SVGIO: iterate over parent's clippaths" which I
        reverted it in 82c0a363abbceac6464b62c3571aa3225415c7db
        "tdf#97539; if parent is css style, look one level up" because
        I thought it was no longer necessary, but I was wrong.
        Also add a unittest
        
        Change-Id: Ib66ca0afd63e8e52be6677b6965179e092a61aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137195
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [67c422585db43e30f0c9e4c9753fcd14f87a277f]

        tdf#126330: use correct type for symbol node
        
        Change-Id: Ibd4b7e021dac28469cb3ea2d30e79de8f24c88be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137201
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-18  Hannah Meeks  <hmeeks4135@gmail.com>  [5eb4c5e93b0f0a3fd9cded5e086086d07cb7c92d]

        Mend python support for lldb cppunit tests.
        
        Change-Id: I02f4872ac75d82f2d77c1854ce040b72883b484a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [278e97ab0272e9c1975bd7780697067f0b91bd46]

        cid#1507357 Big parameter passed by value
        
        and
        
        cid#1507358 Big parameter passed by value
        cid#1507359 Big parameter passed by value
        
        Change-Id: I7adb0497e4e8b90683ee644790c4657b8ac75fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137167
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Michael Stahl  <michael.stahl@allotropia.de>  [54aebc2c8ff25f17a4083fe6c60c38c4f391af12]

        tools: try to work around DavGetHTTPFromUNCPath() not URL-encoding path
        
        This was added in commit 20b1e6440aacab043753e93be4499e939a80b05b
        "tdf#126121: WebDAV redirection detection" and it works fine when i test
        it on my local Windows 10, returning an URL with encoded path.
        
        The logs from the customer system however show a http URL containing an
        unencoded ' ' in the path, which curl_url_set chokes on.
        
        Try to encode the returned URL with rtl_UriEncodeKeepEscapes, which
        should hopefully work in either situation.
        
        Change-Id: I6862fe0828307a13b0004b192153747d85bb3a42
        (cherry picked from commit 66e25aad35cf538da86bdd0157428f4bed95258d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137173
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [d996563ef15892aace8c6b31fe3d2097cbbd6093]

        tdf#119840 exit loop early in DocumentRedlineManager::AppendRedline
        
        reduces load time by approx 5%
        
        Change-Id: I2e82655055fc7b3b7777444a2c9a33d813faa88e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-18  Miklos Vajna  <vmiklos@collabora.com>  [c6d242ebf0d3ca5e57ac7d6e894d800faa38d15a]

        sw: fix crash in SwTextShell::Execute()
        
        Crashreport signature:
        
                SwTextShell::Execute(SfxRequest&)
                        sw/source/uibase/shells/textsh1.cxx:1540
                SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
                        sfx2/source/control/dispatch.cxx:256
                SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short)
                        sfx2/source/control/dispatch.cxx:811
                SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&)
                        sfx2/source/control/unoctitm.cxx:671
        
        This is the Grammar case, the Spelling case already checked for an empty
        xDictionary reference.
        
        Change-Id: If1f88e4bdf2d68d877fbb0bd89d0cadbd493771f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137198
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [e86291cc922fc467dd9ee74ea7afdb3e51f016a8]

        cid#1507356 Logically dead code
        
        Change-Id: I40af398107362615b2500dfa5262a63551489269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [50a52eda9b22ea6659c93b2619700f483b06f09c]

        cid#1507360 Uninitialized scalar field
        
        Change-Id: I3235d82db4eb7f2770ed888ec431eeac1e6a231c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Stephan Bergmann  <sbergman@redhat.com>  [d00dfde8b07adb21543e4ac36071a946ac3d7703]

        Drop leftover comment
        
        ...introduced by d203e3f35dc4547bb46151637ba6054d13025d01 "use
        comphelper::ByteWriter in UNOMemoryStream", made obsolete by
        3ca1a169e571a829598a00a2ffef6e1018d2cb18 "Use boost::noinit_adaptor", forgotten
        to be removed in 3c7378d54b7a04e3f6dfc75a994744bdd953af7b "Fix mid-air
        collision"
        
        Change-Id: I0c98e2e5a9eaf5fcc6def605d6d068080de55c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-18  Stephan Bergmann  <sbergman@redhat.com>  [07eaaeb76493b91520ef0062bf9601a36a9b6b0c]

        nNewSize is guaranteed to be non-negative here
        
        Change-Id: Idb427a0bd3bae94f056d3253682a024169b5288f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137172
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-18  Stephan Bergmann  <sbergman@redhat.com>  [fd2e907e448991e5c8b54acbe7e31bff24c8e875]

        comphelper::ByteWriter::writeSomeBytes always writes all bytes
        
        ...so rename it to writeBytes for clarity, and drop the redundant return value.
        Also clarify that it has a narrow interface and requires nBytesToWrite to be
        non-negative.
        
        Change-Id: I76dee83fecd6350f473f55dcffb950c16aa22d93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137169
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-18  Miklos Vajna  <vmiklos@collabora.com>  [aaebfb9baf53e4ed221a9bb8e1772fcbb7b921ab]

        sw content control, picture: allow replacing via the keyboard
        
        It was not possible to replace a picture placeholder with an actual
        bitmap without using the mouse, which breaks accessibility.
        
        The mouse handling code was added in commit
        b213abcb77e19fa5d22af45c7ecd17c8a63af554 (sw content controls, picture:
        replace placeholder image on click, 2022-05-18), which already split the
        functionality between SwEditWin::MouseButtonUp() and
        SwWrtShell::GotoContentControl().
        
        Fix the problem by reusing the shared SwWrtShell::GotoContentControl()
        and extending SwEditWin::KeyInput() to allow doing the same with the
        keyboard. This way the scenario when Shift-F4 selects the frame and the
        user presses Enter now triggers the filepicker.
        
        A possible future improvement would be to also handle Enter similarly
        when the text cursor is inside a picture content control, but that's not
        implemented here.
        
        Change-Id: I756395d3811e3f4dfdce698751c4de13a0d49729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137168
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [28daee8a3252e03a67484dc8d3dd26fd73af4826]

        cid#1507361 Unchecked dynamic_cast
        
        Change-Id: Ie1b5c3796cca07e3f41d5074de5c70c5308a2ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [96c97930d8914d4cfca165c50106308aa9fbf1bb]

        cid#1507355 Dereference after null check
        
        we always derefed pSObj before:
        
        commit 1d3d2a995239c3c71432006cb795324c56a0412a
        Date:   Mon Jun 20 17:27:53 2022 +0200
        
            tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxes
        
        so lets assume that state was sensible and drop the additional null
        check introduced there
        
        Change-Id: Ief8ce89e729d6fc51a9d8b7ae2dca18452667cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Michael Stahl  <michael.stahl@allotropia.de>  [de49e1c55dc10ce1b59345af5cc49fde3adf65b7]

        tdf#149548 sw: don't rely on binary search in SplitRedline()
        
        The problem is that for this bugdoc overlapping redlines are created by
        writerfilter, and so this one survives the split in SwDoc::TextToTable()
        when creating a cell on node 146 to 149:
        
        $125 = (SwRangeRedline) {
          <SwPaM> = SwPaM = {
            point = SwPosition (node 155, offset 156),
            mark = SwPosition (node 146, offset 0)
          },
        
        It's not found in GetRedline(), as that relies on the redlines never
        overlapping, so isn't split at end of 149.
        
        Then when copying to the clipboard, all redlines are deleted and this
        deletes cell start and end nodes, while the cell's SwTableBox is still
        referenced elsewhere.
        
        (reportedly somehow a regression from
        commit c4cf85766453982f1aa94a7f2cb22af19ed100be)
        
        Change-Id: I6466e6777cd83c7625381f7049f30c8a2f487af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137110
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-18  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [5dc4274eb5ccf3c2cc29676280b70dfc5d5a43b3]

        toolkit : remove useless comments
        
        Change-Id: I45565ae3259321e139f73071e36e94180dcfbffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-18  Caolán McNamara  <caolanm@redhat.com>  [7b11effaeb87b9d941add70d866bb87c340cb6ee]

        ofz#48795 Timeout
        
        Change-Id: Id0a00d5fa9fb937c34a0a8924c985d025e49f1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-18  Miklos Vajna  <vmiklos@collabora.com>  [5a13d43e7f26d7c86aeb44a0912230a2d9ba0f68]

        sw: prefix members of ww8toolbar
        
        Tcg255, Tcg255SubStruct, TcgSttbf and TcgSttbfCore
        
        See tdf#94879 for motivation.
        
        Change-Id: I8a37a640c564131839cd2ed651a93bb44dbb6d0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137160
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [14553d280ad76c3436d394e900002c63de7b6e51]

        chart2: better readable DataTable properties definition
        
        Change-Id: Ib9cadee39f58b73782e6a3268d86b688183de1fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137157
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d518ac1e9ec866785a13367491c52d2ac72d85ec]

        chart2: remove setting DataTable* props. from old chart::XDialog
        
        No API change needed as the properties were not officialy part
        of the API in the first place.
        
        Change-Id: I8682087d13ab2e9eb1c619646b87cde59c3a8e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137156
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7cb504bd5e2c49a73af3270d1ecefe1bd838b66f]

        chart2: use {V,H}Border, Outline Data Table props. at rendering
        
        insert DataTable class into DataTableView, so it is possible to
        take the properties into account when rendering.
        Change rendering:
        VBorder - draw vert. border of data table
        HBorder - draw horiz. border of data table
        Outline - draw the outline borders of a data table
        
        Change-Id: I8348d0672d9c188014d664d667abddde8ebbc7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137155
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-18  Maxim Monastirsky  <momonasmon@gmail.com>  [d69340d4d1e7f96f0633bebd5abcf20114fbef0f]

        Simplify by using InitAnyPropertySequence
        
        Change-Id: I145ce892e101ba4e8906cbdb0d32a52a4c655d43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137151
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-18  Maxim Monastirsky  <momonasmon@gmail.com>  [f1f52b6e5086124c75b57f6f6ff1f1f0353e40af]

        Remove the broken SupportsVisible hack
        
        pController is always empty since commit
        ac1aefd5174258d9bcb41465ce566ed1a0819f3d
        ("Extend ToolBarManager to build weld::Toolbar").
        But even before that it did nothing, as it was set
        only for controllers created by the sfx2 legacy
        factory, but neither .uno:SwitchXFormsDesignMode nor
        .uno:ViewDataSourceBrowser had such controllers (It
        did however work in the past for some other commands
        before commit fb60217569b0fb5bc949c58b054da71992fe2582
        ("tdf#83320 Hide vertical text commands early"). Also,
        searching the codebase for SfxVisibilityItem reveals
        more commands that set visibility, and I'm not sure
        if hardcoding all of them here is a good approach in
        general.
        
        Change-Id: Id8c22e729d2402837de0598fa8ca4d41160804c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137150
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-17  Heiko Tietze  <tietze.heiko@gmail.com>  [db26f712e1edfef6b61a324b146310be00aeb100]

        Resolves tdf#143688 - Allow detaching of sub-toolbars when locked
        
        Change-Id: I36669d953eb9438df73256676e2dfbfe3c263031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137100
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-17  Maxim Monastirsky  <momonasmon@gmail.com>  [f87c7018fa5641eeecd788907ea66892514255a6]

        No need for SfxWeldToolBoxControllerFactory
        
        sfx2::sidebar::ControllerFactory::CreateToolBoxController
        only supports creating controllers using the uno factory,
        or GenericToolbarController as a fallback. Given that we
        already handle the uno factory case in
        ToolBarManager::CreateControllers, all this complexity is
        really just for creating GenericToolbarController with a
        different ctor, which we can do locally as well.
        
        Change-Id: I3a5a3cda95a6c5db97615286e93630214f76cbfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137149
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7077e688408210b32596cbac2f2202610094ddf3]

        oox: support reading text and shape properties for a data table
        
        Change-Id: I740d3bd6af11457ecb54878be648ad1e22b9d4b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137153
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6b481f8bb44a14ebbfe010476cf2ca3728e7d539]

        chart2: add DataTable to AxisProperties, take account at rendering
        
        The Diagram model has the DataTable class, but now we need to
        take this into account at rendering. First add the DataTable to
        AxisProperties, to decide if the data table should be rendered or
        not.
        
        Change-Id: Ia18fcffccc632e4d36011544066072ae3cdfbfc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137152
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [71bcaa477e9379f4c584b3309d7a6149c801702c]

        oox: add data table and props. with the new UNO DataTable service
        
        Refactor filling of the old data table UNO properties to use the
        new service DataTable and its properties.
        
        Change-Id: Iee611c88bec6f58a50b5ae09d3acffd16e0b6dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136790
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [2fffe41501aa694082da2ac92e925b98c704bffd]

        Animations : no need to use the global mutex here
        
        Change-Id: Ia63a570efdd15c60fc31d978a23e76102e466745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [946d038c71ae09f3ae403474d66c26c959a18e13]

        tdf#119840 reduce cost of SwPosition::operator<=
        
        by fetching Start/End from SwPaM at the same time
        
        reduces load time by 5%
        
        Change-Id: Ie4a06c667aa0950c04e98e46b30cdc4b97f75ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137147
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [868b45039d2d168e1c51d971b0d1e0589d4d11eb]

        tdf#54703 fix unhiding at PDF export of cond. hidden sections
        
        The conditionally hidden sections became visible when PDF export
        is performed. This is due to field update where we temporary made
        the conditionally hidden section visible (as the frame is needed),
        but never put them back to hidden. Probably the expectation was
        that the condition will be recalculated later on, but wasn't. This
        change fixes this so that the changed sections will be recalculated
        at the end.
        
        Change-Id: Ic6d8a4a38f22ed961b2b37e05aaf3e720fc50ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137052
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [212f03a3cd33a1c276e93ee693dc1173a5c1b051]

        [API-CHANGE] chart data table implementation
        
        Adds new service DataTable, which is reposible for the properties
        of a data table for a chart. Also removes the existing properties
        related to the data table from Diagram service, which were added
        prematurely in the past, without a data table actually being
        supported by the chart module.
        
        Also adds an implementation of the DataTable service in chart2
        module.
        
        Change-Id: I0c6b32163745704c623d04baaf0ce0e208c107f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136789
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Caolán McNamara  <caolanm@redhat.com>  [8ab54ac42ca2516c333a49fb23f6d27196122c22]

        ofz#48585 Out-of-memory
        
        Change-Id: If6bb603cc78863df88d5630b4bd5b1198b4050de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-17  Caolán McNamara  <caolanm@redhat.com>  [604583b177fbf8fa5044e54d0a35b9adff949e45]

        cid#1506711 Uncaught exception
        
        and
        
        cid#1506712 Uncaught exception
        cid#1506713 Uncaught exception
        
        Change-Id: I8f9753369cb3c85e5f6b910b00aaf553db62750b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137144
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-17  Caolán McNamara  <caolanm@redhat.com>  [52c0c8a2b5a38f02125460c6e21d21c2e8c656cd]

        cid#1507325 Unchecked return value
        
        Change-Id: Ie47ba66cc83130472c68dc5f45c56cd20c9d406f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-17  Caolán McNamara  <caolanm@redhat.com>  [793267e2b7f41c4ce24615491ac2153040a8a148]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I4afb1f9893eadda28d4d9d2e90d5d6293a8ee60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137128
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [53c71a0fa29b98d997ced6c9684c627442cfff94]

        chart2: add initial code for rendering the Data Table
        
        Create a (svx) table with the data from the chart and place it below
        the x-axis line.
        
        Data table rendering is disabled in the code until the data table
        properties are available.
        
        Change-Id: I07d282c0b5e8df6b843516c8bdad538862d6575e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136788
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-17  Jim Raykowski  <raykowj@gmail.com>  [3c8e81669f2311dd35aa6787cbf3e5a6a0520433]

        tdf#149279 related: make gtk treeview scroll_to_row more sal like
        
        The SalInstanceTreeView version of scroll_to_row always scrolls a row
        that is not visible to the top visible row. GtkInstanceTreeView
        scroll_to_row does the minimum amount of work to scroll the cell onto
        the screen. This means that the cell will be scrolled to the edge
        closest to its current position. This patch makes the gtk behavior
        always scroll the row so it is the top visible row.
        
        Change-Id: Ib318d7bede3723de9e84ea2db5fbfa951324facd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-07-16  Caolán McNamara  <caolanm@redhat.com>  [dfab1b24bdf4e83ecf6ff701afa45d561fa12557]

        ofz#48693 Timeout
        
        Change-Id: I6912a41afc8325052d197990f1dd193399a7b053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-16  Caolán McNamara  <caolanm@redhat.com>  [eea7dc22c639cd9fcfdf94d66b69f64f0102ddbc]

        ofz#48643 Indirect-leak
        
        Change-Id: Ia19f1d15e52a869baf8a869b5c3bcceaacef7887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-16  Justin Luth  <jluth@mail.com>  [97f6fc9f752bc8bb34f2793442922ead59008757]

        tdf#64242 sw table: improve Optimal Column Width function logic
        
        This affects both Writer's minimze and optimize table functions.
        
        Instead of basing equal-width on the current table size,
        allow each column to have access to an equal portion
        of the full table size (in case that it can grow wider).
        
        This will help to maintain symmetry - one of the two primary
        intentions of these functions.
        
        [This is irrelevant for Draw - since the table size does not grow.]
        
        Change-Id: I0e8c499b66c538f06df52eb74374bad3b690e8d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137120
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-16  Caolán McNamara  <caolanm@redhat.com>  [15eac2ba222d2d07dfa2bb962f4bbddbcecb9dbc]

        ofz#49017 Integer-overflow
        
        Change-Id: Iadb8c0a9bccef400f1c7fb6e5f2f3444a45da480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-16  Caolán McNamara  <caolanm@redhat.com>  [2ad6beb1dff9a2e4e864831fdfc2c9c058506944]

        ofz#49157 Object-size
        
        Change-Id: I3a17d7967512a282b13894ba479aa3507f1be38f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137121
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-07-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ca056d8680334e48343ad2c1f6c512d7fc5bab8a]

        allow to override PKGFORMAT when running make
        
        building installation sets takes a long time, and is a .PHONY action.
        Having a way to skip that when running make is esp. useful with IDEs
        that have no nice way of separating the "run/debug" action from the
        build action. (XCode, looking at you and your awkward schemes…)
        Use with »make build PKGFORMAT=""«
        
        Change-Id: Iab0c03a4096fe5571a5496b52504b3393e9f3cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137111
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-16  Laurent BP  <laurent.balland-poirier@laposte.net>  [80e94899d2254a345f7c73804bffe5d5e008f8ad]

        tdf#149723 Fix footer of Beehive and Blue_Curve
        
        Beehive and Blue_Curve Impress templates have same bug
        as Piano template: presentation:class was missing to
        date-time, footer and page-number
        
        Change-Id: I5d4f2463ce7dee3e20eea65206cd4cd91020b989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137088
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-16  Jean-Pierre Ledure  <jp@ledure.be>  [91a1662c66e5e988d36012533fceab9221607282]

        ScriptForge - tdf#149983 dialog.EndExecute() failure
        
        In SF_PythonHelper._PythonDispatcher():
        
        Force a hardcoded call of the methods in the Dialog
        service which may potentially be invoked while the
        dialog is displayed, bypassing the generic CallByName()
        Basic builtin function:
           Activate
           Center
           EndExecute
           Resize
        (Controls is already hardcoded because returning an array)
        
        Change-Id: I4931f43b37ae5f7337740d1c65b255f4a14ca069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137084
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-07-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce29e6299932fc079b05b60662ba95c8342990bc]

        tdf#119840 elide some dynamic_cast cost
        
        when opening a large writer file, shaves off about 5% off load time
        
        Change-Id: I501d0ebfbaec572e7c93c1dbc3f0cfaab3938f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3a9cf24468d7c3c67ef44c3cc8fa618a56565d32]

        update credits
        
        Change-Id: Ia00bbfe76a95eb72687fb46eedf934c8327e3f03

2022-07-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4cbc28ec880cc4820b7a2e2293a17ee33a4cb688]

        Update git submodules
        
        * Update translations from branch 'master'
          to c875ee9259eeb47a0ec1767d8d602f86bb793a40
          - update translations for 7-4/master
            
            and force-fix errors using pocheck
            
            Change-Id: Ie4a055202e93e4ac5563df42235db5cf2b1c2b16
            
2022-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [82c0a363abbceac6464b62c3571aa3225415c7db]

        tdf#97539; if parent is css style, look one level up
        
        if the style attributes are set like
        
          <rect x="10" y="10" width="100" height="100" fill="#00D000"
                  clip-path="url(#myClip)"/>
        
        it works, however, if it uses a css style like
        
          <rect x="10" y="10" width="100" height="100" style="fill:#00D000"
                  clip-path="url(#myClip)"/>
        
        it fails to get the clipPath from the parent, because the css style
        is the direct parent, thus, check one level up
        
        Change-Id: Iff6df95c9fa9da4c2f1a986cca0ad82ab1494353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137094
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [babd850db840eebd59b71730b446c0d89de87d3a]

        macOS sandbox: disable donation info bar & help entries
        
        even when you are a verified non-profit, you still cannot just point to
        a donation site/you still would have to offer apple-pay...
        
        the helpmenu one is ugly since it changes the endresult compared to
        what is assembled in instdir, but is the least intrusive way for now...
        
        Change-Id: Id348d69371048bdd04d2961cad564fc73f11fd45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137050
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-15  Justin Luth  <jluth@mail.com>  [386a9fadffa446caf40fd4f40b865c8c9432fa27]

        tdf#139759 writerfilter: avoid exception importing w:shd in comments
        
        The unit test depends on the two previous fixes in this bug report.
        -initial load tests highlight import
        -export tests saving the character background
        -reload tests this shade import
        
        Change-Id: Iceb405841efc6814654061659e5551ac89f3c7b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137091
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-15  Michael Weghorn  <m.weghorn@posteo.de>  [7b312771d7eb33f7410167e36efdaeca6f540b1c]

        tdf#149952 gtk3 a11y: Return pos relative to window when requested
        
        ATK (and AT-SPI) allows to specify 3 different coordinate
        types [1]:
        
        1) `ATK_XY_SCREEN`: coordinates relative to the screen.
        2) `ATK_XY_WINDOW`: coordinates relative to the widget's
           top-level window.
        3) `ATK_XY_PARENT` coordinates relative to the widget's
           immediate parent.
        
        The `XAccessibleComponent` interface provides equivalents
        for 1) and 3), but not 2), and the gtk3 VCL plugin wasn't
        really handling 2) so far either.
        
        This adds handling for `ATK_XY_WINDOW`. The position
        in the window is calculated by recursively walking up the a11y
        hierarchy and summing up the positions relative to the
        parent, until a window is reached (or there's no parent,
        or none implementing `AtkComponent`).
        
        Also add an explicit check for `ATK_XY_PARENT` if
        none of the other two constants is used and warn
        and return if that isn't used either, to cover the case
        that new constants will be introduced in newer ATK versions.
        (That check needs to be conditional, because `ATK_XY_PARENT`
        is only defined from ATK 2.30 on, while our minimum
        required version is currently 2.28.1.)
        
        The coordinates received when testing this with a
        selected Writer paragraph in Accerciser's IPython console
        look generally plausible now with this change in place:
        
            In [108]: acc.queryComponent().getPosition(pyatspi.component.XY_SCREEN)
            Out[109]: (1939, 417)
            In [109]: acc.queryComponent().getPosition(pyatspi.component.XY_WINDOW)
            Out[110]: (19, 245)
            In [110]: acc.queryComponent().getPosition(pyatspi.component.XY_PARENT)
            Out[111]: (19, 113)
            In [111]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_SCREEN)
            Out[112]: (2015, 417, 5, 19)
            In [112]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_WINDOW)
            Out[113]: (95, 245, 5, 19)
            In [113]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_PARENT)
            Out[114]: (76, 0, 5, 19)
        
        (Previously, requesting window-relative coordinates gave the
        same result as coordinates relative to direct parent.)
        
        [1] https://docs.gtk.org/atk/enum.CoordType.html
        
        Change-Id: Idf8f7d08f9054a8df28d1ee8fccc791a803de045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137027
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-15  Miklos Vajna  <vmiklos@collabora.com>  [d65e85178abdd4f1bf068f161e49204e068bb5da]

        sw content control, dropdown: allow selecting via the keyboard
        
        It was not possible to select an entry from a content control dropdown
        using the keyboard, which breaks accessibility.
        
        This had the benefit that the mouse handler code could contain the popup
        start calls, but Word can do this with alt-down arrow, so make sense to
        add it on our side as well.
        
        Fix the problem by adding SwContentControl::ShouldOpenPopup(), which
        knows that dropdowns want a popup with alt-down, and then connecting
        SwEditWin::KeyInput() to it.
        
        Date content controls probably will want something similar, but that's
        not yet done in this commit.
        
        Change-Id: I6853d3a1661e4d826b96b1b5cb938909875af2ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137102
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [242b7d0162d55be0945ca849c3de841fbf6cb475]

        svgio: simplify code
        
        Change-Id: I100256b63fadeb4a0e4b8e4cbb67e58d2a1ce433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [126067992d7a2b3edc5dd6ce5e896343da537589]

        tdf#148248 Text Color -> Font Color in AutoFilter/Standard Filter
        
        Consistently with other places such as Formatting toolbar
        and Format Cells -> Font Effects tab page
        
        Change-Id: I7ec5733f01182b25b5d823a43a3639b21ee874e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137087
        Tested-by: Jenkins
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2022-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fd23887f1c32d73e5ad074deb752312685a0136a]

        Removed executable bits on doc file
        
        Change-Id: Iee36258987b5e57163ed0e111b4612fdf3b02089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137024
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [75b410f1292fc9f794984583f734260e8a0378c6]

        Fix typo "vetor"->"vector"
        
        Change-Id: Ie706797e1bda4d1cd279fa68e93fb15beabb6a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137077
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b14f4ef8eb37fe2d01cf5a366a24cc570fe06a10]

        svgio: remove recurrent check
        
        Change-Id: Ic8d79fdcc018a488c77cc601ee0deed76c55af87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137095
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-15  Miklos Vajna  <vmiklos@collabora.com>  [ba866df2dd51fb646d3c3dd295571dcaf9e074de]

        CppunitTest_sw_layoutwriter2: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: If199949412654cb008f15e6b2da82a14903083da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137089
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [8580cbdc19224bc2a467535cc527cd28b0f30879]

        svgio: qa: Add test for shape with ref to clipPath
        
        Change-Id: Ifefb27db8415eb55b22f1537e1790fcd9feb3ee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137092
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-14  Justin Luth  <jluth@mail.com>  [11937a68aecb8db9aebb1c929d940c5b85a0ecec]

        tdf#139759 sw ms-formats: export comment char background
        
        EditEngine's character background is a SvxColorItem,
        while Writer uses a SvxBrushItem. Thus we have no automatic
        transition possible between the two, and during export it
        was just being ignored as > RES_UNKNOWNATR_BEGIN.
        
        A unit test will have to wait until import (of shd) works.
        
        P.S. Import of "highlight" was fixed in an earlier commit.
        Setting Options - Save - MS Office Compat - As Highlighting
        would fully work now.
        
        Change-Id: I8674173a3d1bf1581c09458c3087d6fd39e48a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137090
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-14  Balazs Varga  <balazs.varga.extern@allotropia.de>  [cf936b57117b9bd4a9b1ae4c77244d544cc2bfec]

        tdf#61623 sc update current cell view if we switch or create a new tab
        
        Testing:
        - create a new validation list in the A1 cell with some value.
        - add a new tab while you are on the A1 cell on the original tab.
        or
        - switch to an existing tab from the original A1 cell.
        
        TODO: UNIT test
        
        Change-Id: Ic13afdca45cf31fb50a7446b6eb6d64069d30200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137040
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Tested-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>

2022-07-14  Eike Rathke  <erack@redhat.com>  [5b0ac00fe7db535286c081dacbd066ed6edf6813]

        Accept 'Y D MMM' date input for locales with LongDateOrder::YDM
        
        There currently is only lv-LV.
        
        Change-Id: I39aa38fbf34c44d914aeb6af0f55d820b5567a7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137083
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e00225bc7744abd365f1cc7133d43026e9438f13]

        elide some temporary OUStrings
        
        Change-Id: I8539dd5d9490a14ebac0520486a8322ff86a6cb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137081
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [1aaf5d44dceecc13a3bc8e08c13d0b2ba278c462]

        make B2DPolyPolygon thread-safe
        
        which is cheaper than copying it when querying from UnoPolyPolygon
        
        Change-Id: If4661dfdff7e277d5ef25a8f0c937e549f8be9f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Miklos Vajna  <vmiklos@collabora.com>  [c6eb8713438d1ba791fc858c8dc6e3d4d6583e0a]

        sw content control, checkbox: allow toggling via the keyboard
        
        Toggling a checkbox content control was only possible by clicking on it
        with the mouse, which breaks accessiblity.
        
        Trying to type into a checkbox content control triggered the read-only
        popup (which is good), but there was no special handling for the space
        character, which is meant to toggle the checkbox.
        
        Fix the problem by adding a way to query if the current keycode is meant
        to interact with the content control, and if so, invoke
        GotoContentControl() from SwEditWin::KeyInput(), similar to how the
        click handler already did this already.
        
        This only handles checkboxes, but other types can be addressed in a
        follow-up commits similarly.
        
        Change-Id: I5c88f2e2f1c2d0f4b28f2ce0b6b1c75b14b7d67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137082
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [bcb1620b3e4929df1d06d57b4769650422fff16e]

        speed up loading PDF file
        
        Change-Id: I3d892319f4af0c187455bc9c13b6edb0d52ac023
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137079
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Eike Rathke  <erack@redhat.com>  [ff1c5fedc96456a6be12e7e4fd2109ef5beb45c7]

        Let 'MMM D Y H:M' input follow the same date rule as 'MMM D Y'
        
        ... and not only accept for DateOrder::MDY.
        
        Change-Id: Ic17efbdfee5aac1e00d3cee7b14c16875b3dd292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137076
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-14  Stephan Bergmann  <sbergman@redhat.com>  [95706c680c509016b8cd60c026d820c7d4575a12]

        Drop some needless casts
        
        ...that were present ever since the surrounding code was added in
        95b27dd2e5b5bdcb39962f72882dcdf406bcb393 "tdf#45705 rework zoom in and zoom out
        UI commands in Calc", but for no apparent reason (when MAXZOOM and MINZOOM were
        macros expanding to unadorned int literals).  But even after
        ac2a6ee9618e377806e529ed641f67e88684f7e7 "basegfx: zoomIn() and zoomOut() should
        be sal_uInt16" changed MAXZOOM and MINZOOM to be constants of type sal_uInt16,
        contemporary compilers are unlikely to emit warnings for these nominally
        signed-vs.-unsigned comparisons.
        
        Change-Id: If4481a2e539632dbdca2ce4b13aab63fb84225b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137075
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c15ccc2671d93b06c00730d03b441f3466984d4]

        clang-tidy modernize-pass-by-value in sfx2
        
        Change-Id: I7984f0b52809091511dc01005fdbfeafd521b4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137048
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5d3238104a46f933584cc2a896b00bae82bf4ec]

        svgio: factor out common code
        
        Also skip spaces before the #, Something like
        xlink:href="     #target" is still valid
        
        Change-Id: Ia62e58ca31bfecd283776ec84fcc4bba1836afab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137074
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-14  Stephan Bergmann  <sbergman@redhat.com>  [905559f3f45991a0538912c1ca77199aa52fc7cf]

        Adapt to Clang 15 trunk increase in ElabortatedType sugar
        
        ...<https://github.com/llvm/llvm-project/commit/bdc6974f92304f4ed542241b9b89ba58ba6b20aa>
        "[clang] Implement ElaboratedType sugaring for types written bare".
        
        For one, it caused diagnostics to now emit 'OString' instead of 'rtl::OUString'
        etc., which required adapting a number of tests.
        
        For another, some tests started to fail because the relevant plugins didn't
        expect ElaboratedType sugar in places where it now occurs:
        
        > error: 'error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/redundantcast.cxx Line 297: redundant cstyle cast from 'Enum1' to 'Enum1' [loplugin:redundantcast]
        >   File compilerplugins/clang/test/redundantcast.cxx Line 308: redundant cstyle cast from 'Enum1' to 'Enum1' [loplugin:redundantcast]
        
        > error: 'error' diagnostics expected but not seen:
        >   File compilerplugins/clang/test/referencecasting.cxx Line 25 (directive at compilerplugins/clang/test/referencecasting.cxx:24): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 37 (directive at compilerplugins/clang/test/referencecasting.cxx:36): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 48 (directive at compilerplugins/clang/test/referencecasting.cxx:47): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 100 (directive at compilerplugins/clang/test/referencecasting.cxx:99): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 120 (directive at compilerplugins/clang/test/referencecasting.cxx:119): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 188 (directive at compilerplugins/clang/test/referencecasting.cxx:187): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 200 (directive at compilerplugins/clang/test/referencecasting.cxx:199): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        >   File compilerplugins/clang/test/referencecasting.cxx Line 206 (directive at compilerplugins/clang/test/referencecasting.cxx:205): the source reference is already a subtype of the destination reference, just use = [loplugin:referencecasting]
        
        > error: 'error' diagnostics seen but not expected:
        >   File compilerplugins/clang/test/typedefparam.cxx Line 42: function param 1 at definition site does not match function param at declaration site, 'FooT *' (aka 'test2::Foo *') vs 'struct Foo *' [loplugin:typedefparam]
        >   File compilerplugins/clang/test/typedefparam.cxx Line 55: function param 1 at definition site does not match function param at declaration site, 'FooT *' (aka 'test3::Foo *') vs 'Foo *' [loplugin:typedefparam]
        > error: 'note' diagnostics seen but not expected:
        >   File compilerplugins/clang/test/typedefparam.cxx Line 40: declaration site here [loplugin:typedefparam]
        >   File compilerplugins/clang/test/typedefparam.cxx Line 53: declaration site here [loplugin:typedefparam]
        
        Hopefully, there are not too many places in our plugins left that similarly
        don't expect ElaboratedType sugar in certain places, but which are not covered
        by tests.  At least, a full build didn't turn up any further false positives,
        but there may of course be false negatives now that would go undetected.
        
        Change-Id: I9bfb1cfb57df5f6e228b512c19c664d48285b675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137049
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-14  Stephan Bergmann  <sbergman@redhat.com>  [dcded5774c02da6528cf2ff97b13a531c7cf6813]

        Drop poor @attention paragraph
        
        For one, Javadoc (unlike Doxygen) doesn't support @attention, so this caused a
        
        > Generating workdir/CustomTarget/odk/docs/java/ref/help-doc.html...
        > Note: Custom tags that could override future standard tags:  @attention. To avoid potential overrides, use at least one period character (.) in custom tag names.
        > Note: Custom tags that were not seen:  @attention
        
        warning during the build.  And for another, that paragraph was phrased in poor,
        broken English and didn't add much value anyway.
        
        Change-Id: I603170ec262d042e92bdff38ae415dda0bcc28bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137053
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-14  Michael Stahl  <michael.stahl@allotropia.de>  [d7827f712ddd21a6c1e151f54dc6eba5c12690da]

        tdf#149978 sw: ODF import: fix nondeterministic automatic styles
        
        The problem is that in SwpHints::TryInsertHint() there is a check for
        IsInXMLImport() that is presumably an optimization to avoid the
        potentially expensive call to BuildPortions().
        
        While LO would only produce 1 text:span referencing an automatic style
        around any given character content, this is not required by ODF, and so
        other producers may legitimately produce such nested text:span elements.
        
        Unfortunately the current SwpHints::Insert() isn't deterministic, the
        RES_TXTATR_AUTOFMT with same start/end will be compared by address in
        CompareSwpHtStart() (whereas RES_TXTATR_CHARFMT has a sort number for
        this), so the result is going to be a random order.
        
        Change-Id: Id62a7ff5fb85dbe42b7e1a27b0d8b36b74cf1100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137033
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-14  Stephan Bergmann  <sbergman@redhat.com>  [306510f0850518dc3a8162769e4aeb83795486be]

        Adapt to new Clang 15 trunk -Wdeprecated-builtins
        
        ...<https://github.com/llvm/llvm-project/commit/0b89d1d59f82cf5b45c250cd5c3351e43ce35ef9>
        "[Sema] Add deprecation warnings for some compiler provided __has_* type
        traits", which hits in Boost include files,
        
        > In file included from libreofficekit/qa/tilebench/tilebench.cxx:27:
        > In file included from external/boost/include/boost/property_tree/json_parser.hpp:31:
        > In file included from workdir/UnpackedTarball/boost/boost/property_tree/json_parser.hpp:14:
        > In file included from external/boost/include/boost/property_tree/ptree.hpp:31:
        > In file included from workdir/UnpackedTarball/boost/boost/property_tree/ptree.hpp:16:
        > In file included from workdir/UnpackedTarball/boost/boost/property_tree/string_path.hpp:15:
        > In file included from workdir/UnpackedTarball/boost/boost/property_tree/id_translator.hpp:16:
        > In file included from external/boost/include/boost/optional.hpp:31:
        > In file included from workdir/UnpackedTarball/boost/boost/optional.hpp:15:
        > In file included from workdir/UnpackedTarball/boost/boost/optional/optional.hpp:42:
        > workdir/UnpackedTarball/boost/boost/type_traits/has_nothrow_constructor.hpp:27:84: error: builtin __has_nothrow_constructor is deprecated; use __is_nothrow_constructible instead [-Werror,-Wdeprecated-builtins]
        > template <class T> struct has_nothrow_constructor : public integral_constant<bool, BOOST_HAS_NOTHROW_CONSTRUCTOR(T)>{};
        >                                                                                    ^
        > workdir/UnpackedTarball/boost/boost/type_traits/intrinsics.hpp:199:48: note: expanded from macro 'BOOST_HAS_NOTHROW_CONSTRUCTOR'
        > #     define BOOST_HAS_NOTHROW_CONSTRUCTOR(T) (__has_nothrow_constructor(T) && is_default_constructible<T>::value)
        >                                                ^
        
        etc.
        
        Change-Id: I08376710e25013b44279532d6e5fc256ed95cb76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137046
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [310a787e1b03ba6d9c99996dfbd380296a8da825]

        tdf#149985 pptx crash on a one-slide presentation (with a chart)
        
        regression from
            commit 04073c5fedd33654f242fecb7e39afb07cf0e273
            Date:   Tue Jun 21 13:17:09 2022 +0200
            replace oox::OptValue with std::optional
        
        Change-Id: I830713495ca04771433018f1091faadf0f6bd71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137051
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Stanislav Horacek  <stanislav.horacek@gmail.com>  [8b8f9dae619dbc725cb39f2e5639f13ae9985dcb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e47587f2e85c6e206c70d6a2db553a09fa04c58b
          - fix Number2Text example
            
            Change-Id: I20b3a7741fcee1901cf8a064dd9f6aaa39d91114
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136950
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [34d8eb4d3f2a75a3a072f5f6a443f959ba99113c]

        clang-tidy modernize-pass-by-value in svtools
        
        Change-Id: I60e7373c924a479fed72eb4f0538006e3e422004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d009c405714934ae5f95f4131510cb4e9c2493f]

        loplugin:moveit
        
        Change-Id: I2702e716dc669ffbb870d36d060e110288d7a744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bdd97cb83e09225905a6272caf91579a0a77d3c2]

        fix bluetooth entitlement, was added to the flipped condition
        
        of course it should only be added when the bluetooth part of the
        sdremote is enabled, not the other way round...
        fixes c78b49ec132eb5126445ebee7d259d3df7fcaa68
        
        Change-Id: I0085c61a4bafece80be92c56928095c2726e11b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137025
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-14  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [7bb911d11813136935ac8a0bbe6dcbe211a24853]

        tdf#112626 lotuswordpro: switch to constexpr and update documentation
        
        Change-Id: I566c22285978f7b31961d105d02d99d0696908b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137041
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-07-14  Hannah Meeks  <hmeeks4135@gmail.com>  [7a4814f717520b8de8c963dc2d576f05fc15d2e9]

        Change make file so that debugging works - Previous error:
        
        hannah@localhost:~/master/sw>  make CppunitTest_sw_macros_test CPPUNITTRACE="gdb --args"
        [CUT] sw_macros_test
        S=/data/opt/libreoffice/master && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CppunitTest/ && rm -fr $W/CppunitTest/sw_macros_test.test.user && cp -r $W/unittest $W/CppunitTest/sw_macros_test.test.user &&   (  MAX_CONCURRENCY=4 MOZILLA_CERTIFICATE_FOLDER=dbm: SAL_DISABLE_SYNCHRONOUS_PRINTER_DETECTION=1 SAL_USE_VCLPLUGIN=svp LIBO_LANG=C      icerun   PYTHONWARNINGS=default gdb -return-child-result -ex "add-auto-load-safe-path $S/instdir" -ex "set environment LD_LIBRARY_PATH ${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program":$W/UnpackedTarball/cppunit/src/cppunit/.libs"  -ex 'set environment MALLOC_CHECK_=2; set environment MALLOC_PERTURB_=153'  --args   $W/LinkTarget/Executable/cppunittester $W/LinkTarget/CppunitTest/libtest_sw_macros_test.so --headless "-env:BRAND_BASE_DIR=file://$S/instdir" "-env:BRAND_SHARE_SUBDIR=share" "-env:BRAND_SHARE_RESOURCE_SUBDIR=program/resource" "-env:UserInstallation=file://$W/CppunitTest/sw_macros_test.test.user"   "-env:CONFIGURATION_LAYERS=xcsxcu:file://$I/share/registry xcsxcu:file://$W/unittest/registry"  "-env:UNO_TYPES=file://$I/program/types/offapi.rdb file://$I/program/types/oovbaapi.rdb file://$I/program/types.rdb"  "-env:UNO_SERVICES=file://$W/Rdb/ure/services.rdb file://$W/Rdb/services.rdb" -env:URE_BIN_DIR=file://$I/program -env:URE_INTERNAL_LIB_DIR=file://$I/program -env:LO_LIB_DIR=file://$I/program -env:LO_JAVA_DIR=file://$I/program/classes --protector $W/LinkTarget/Library/unoexceptionprotector.so unoexceptionprotector --protector $W/LinkTarget/Library/unobootstrapprotector.so unobootstrapprotector   --protector $W/LinkTarget/Library/libvclbootstrapprotector.so vclbootstrapprotector   "-env:CPPUNITTESTTARGET=$W/CppunitTest/sw_macros_test.test"  )
        ICECC[448] 2022-07-13 13:23:02: couldn't find any PYTHONWARNINGS=default
        ICECC[448] 2022-07-13 13:23:02: could not find PYTHONWARNINGS=default in PATH.
        make: *** [/data/opt/libreoffice/master/solenv/gbuild/CppunitTest.mk:121: /data/opt/libreoffice/master/workdir/CppunitTest/sw_macros_test.test] Error 115
        hannah@localhost:~/master/sw>
        
        Change-Id: Idebbd385f70edd9b691d91f6eded8ee02ac9cce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137032
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-14  Hannah Meeks  <hmeeks4135@gmail.com>  [febfbaff07562dd68bc2b5bc870699754f763e50]

        The DefaultPropertyName for range is tex
        
        Change-Id: I0e5f1ae0757a2ad8f58f011df435c30c577d8a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137006
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-14  Hannah Meeks  <hmeeks4135@gmail.com>  [0b5df6634a2021986b0de2ab12a41c0d4af4f60c]

        tdf#149963 -  XFind not a property/attribute of XRange
        
        Updated XRange to include XFind
        
        Change-Id: If9570fbb5de8d14063a72a4c4c55fcfd491dd496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137004
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-14  Heiko Tietze  <tietze.heiko@gmail.com>  [b2c81dad3a0b72d305f1c6967ee4a8069ae11b45]

        Relates tdf#139141 - Make variable date/time field the default
        
        Switched the fixed and variable/current field
        
        Change-Id: I18136feebed225f7645b6869d3600ee78f945bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137030
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-07-14  Luboš Luňák  <l.lunak@collabora.com>  [c069dc225897b774ce3e09fbcd45a7d35297a8a9]

        fix vcl::DeleteOnDeinit example in its docs
        
        The ctor does not take 'new T', now it takes arguments that
        are passed to T ctor.
        
        Change-Id: I04b330d98dd84c86e00ec937a00d1097f21c55c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137039
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-14  Miklos Vajna  <vmiklos@collabora.com>  [0df20c7ebd6bf9f53776e3c66e78db65feb86878]

        sw: prefix members of ww8toolbar
        
        SwCTBWrapper, SwTBC, TBDelta and Tcg
        
        See tdf#94879 for motivation.
        
        Change-Id: I778c3d47e6facc1fe69a9eb9d7af92fb2ef20cdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137042
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-14  Mike Kaganski  <mike.kaganski@collabora.com>  [9f4af852c4050d45bb5ab314480fc83639bea90a]

        tdf#148198: merge identical hyperlinks of adjacent text ranges on ODF export
        
        The true hyperlink boundaries are available as SwpHints starts/ends, which are used
        in DOC(X) export (see SwWW8AttrIter::OutAttrWithRange).
        
        However, I don't see a reasonable way to expose this information to xmloff, so I
        decided instead to just merge the identical hyperlink properties of adjacent ranges
        into a single hyperlink. This will allow to fix already split hyperlinks saved in
        previous versions. The downside is that this disallows to have separate adjacent
        identical hyperlinks - I hope that this would not be a real issue.
        
        Change-Id: I901e6035a5e89bc515b5742c6a5f564c77faf05b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137013
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-13  Justin Luth  <jluth@mail.com>  [fc8b757dad5d98f4ba1cd40d03505873128670cd]

        tdf#139759 writerfilter: import comment highlight
        
        Although it is a highlight, LO doesn't have such a silly
        duplicate thing in the editeng code. So just map this as
        normal char background instead of char highlight.
        
        As of LO 7.x, we default to exporting as char background anyway,
        so highlight is on the way out in LO.
        
        P.S. Highlight is one of 17-ish colors. It is the background
        button in the Char panel in MS Word. Background is on Word's
        Para panel (even though it is a character property),
        and so it can fairly easily be removed in MS Word.
        
        I didn't add a unit test because it doesn't round-trip,
        and an import-only test is basically useless.
        I'm having a surprisingly hard time finding why it doesn't export.
        
        Change-Id: Iad279b503b9f307994f1d9b96e7d984d6d8b44fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137036
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [126da357f4e9683073cca0b0794398ad7914e483]

        tdf#149950: svl_qa_cppunit: Add unittest
        
        Change-Id: Iae7facef72ad17b29b49ea5b52aab77c16357da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137031
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [5169378d2a0f0a25013c8a4387a6e3cb1a4a55e9]

        svgio: use href along with xlink:href
        
        xlink:href has been deprecated.
        See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href
        
        Change-Id: I622cd975c0bcc1a819831d7b9c867312ff59affa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137035
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [ac2a6ee9618e377806e529ed641f67e88684f7e7]

        basegfx: zoomIn() and zoomOut() should be sal_uInt16
        
        All zoom functions use sal_uInt16 values. For some reason, basegfx used
        long when zoomIn and zoomOut were created in 2012 (see commit
        315d2ddc16: "optimized zoom to use more common intervals"), this then
        got mass converted to tools::Long in commit 387a88fa25: "use tools::Long
        in basegfx..chart2".
        
        So fix is to change zoomIn/Out() to use sal_uInt16.
        
        Change-Id: I2a56d6f58e14f77aeb8741d332fe9bc282eb969f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135715
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-07-13  Eike Rathke  <erack@redhat.com>  [d818c341206895a6dda1c19fc8b32f04b5b7c520]

        Resolves: tdf#149950 Handle LongDateOrder vs DateOrder for middle month name
        
        Change-Id: I30598f7081cea73fa368374084c03b0df108be84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137026
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [fad98d4d2c6726fb5b30233cfe8c0cfe1a5f18c0]

        Remove unused --enable-chart-tests
        
        On 2022-07-04 I submitted 268f0f3f0d70902acaeb3f99e0d206ad66ffd67c
        "run CppunitTest_chart2_xshape without ENABLE_CHART_TESTS" to
        see if CppunitTest_chart2_xshape would fail for anyone.
        Since then, no one has complained about it, so I suppose
        the tests are stable nowadays, thus removing
        --enable-chart-tests which does nothing since the mentioned
        commit
        
        Change-Id: I0407c0379ea45eee93bd6689c90d1759b48e2844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137022
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-13  Michael Stahl  <michael.stahl@allotropia.de>  [c605283ad6785dea762feab5fdffd9d27e75c292]

        sw: fix spurious layout invalidation from ~SwCallLink()
        
        This code was added in commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c
        "sw-collapse-empty-table-par-like-html.diff" and leaves us to guess
        what it should do.
        
        Apparently it's trying to replicate a Word feature where an empty
        paragraph at the end of a table cell and preceded by a nested table is
        effectively hidden, *unless* the user moves the cursor into it, at which
        point it grows to its ordinary height.
        
        The problem is that this is implemented by invalidating the position of
        any table once the cursor is moved into it, causing it to be
        reformatted, at potentially great expense, regardless if the cursor is
        actually on a paragraph that may be hidden.
        
        Also limit invalidations to when the cursor has actually moved to a
        different node.
        
        To fix tdf#105330, un-collapse a paragraph after Undo, requires
        additionally doing the same notification from
        SwUndoInsTable::UndoImpl() because the SwCallLink won't see the removed
        table any more.
        
        Mysteriously this causes the test SwLayoutWriter2 testTdf124261 to fail
        in Jenkins, but only on MacOSX so impossible to debug; tb86 fails with:
        
        layout2.cxx:2227:testTdf124261::TestBody
        equality assertion failed
        - Expected: 1721
        - Actual  : 5437
        
        ... and tb84 with:
        
        layout2.cxx:2227:testTdf124261::TestBody
        equality assertion failed
        - Expected: 1721
        - Actual  : 3740
        
        Change-Id: Ifd55097735d3675e6b82264f455baa44e9c9e30a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136963
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-13  Luboš Luňák  <l.lunak@collabora.com>  [6c58b01c791ec4939523147d5d075611bbbfe314]

        move Skia setup code to a shared function
        
        Change-Id: Ifcd434512854b5fedb0baf4ce1251a05f659b006
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137017
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9eb42e3c36b2558d33be4808202441ca7ce8af70]

        fix #include location
        
        added in
            commit 54a97eb9ddd66294f303189ca12ef726177453cb
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jul 12 15:52:29 2022 +0200
            clang-tidy modernize-pass-by-value in vcl
        
        Change-Id: If1f468bc6d601809e3a7802f4414c3a49e54c2c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-13  Roman Kuznetsov  <antilibreoffice@gmail.com>  [c2bf1ff91fab4574dd27808a2e4391c7a4b99d20]

        tdf#147132 Flatten a Basic function
        
        Change-Id: I85eef5ca499197cfd96fecc4d05a82f7d11089cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136856
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc82dd830bf4ef66451897624c946655a1526bde]

        loplugin:unusedmethods
        
        Change-Id: Ifa9c3fe86e7bad6d3839fd3fdfdb8c1f7b5053c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-13  Maxim Monastirsky  <momonasmon@gmail.com>  [e695b6d89a00c86fc35332213be42d5b29196eae]

        Related: tdf#149956 Keep in sync after icon theme change
        
        We can't just refresh the listener for .uno:ImageOrientation,
        as that won't work for tdf#149741.
        
        Change-Id: Iee584c98f5b81542cd9be4760433b96e97981f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137015
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-13  Maxim Monastirsky  <momonasmon@gmail.com>  [421688a4c2fc64e64ce211d579bad2174e005db4]

        tdf#149956 Pass the correct frame to VclStatusListener
        
        Starting directly to Writer (i.e. with "--writer") will attempt
        to create VclStatusListeners for .uno:ImageOrientation before
        the frame is activated, causing the dispatcher to not be found.
        
        Also defer that stuff to after a toolbar is filled, so we get a
        correct initial state for toolbars which shown when the current
        paragraph is rtl already. (There is a similar problem with the
        NB, but it isn't handled in this patch.)
        
        Change-Id: Ie482007c10a4014b4a2fd4d53f05d433777ecfb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137014
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-13  Michael Weghorn  <m.weghorn@posteo.de>  [ca1b528972235c16dab74e3662ff768c68a6cc38]

        gtk3 a11y: Activate code that needs AtkRectangle
        
        I don't see where `HAS_ATKRECTANGLE` would be defined,
        not even in what we have as a single git commit that adds the
        code:
        
            commit 9b5df79fbd9e84ef9c2dde845867dbb1f98ac98a
            Date:   Fri May 5 09:55:52 2006 +0000
        
                INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED
                2006/03/31 14:09:17 obr 1.1.2.20: #i63580# AtkRectangle already in atk 1.7.0, but ATK_TYPE_RECTANGLE in 1.7.2
                2006/03/31 12:19:39 obr 1.1.2.19: #i63583# eliminated warnings
                2006/03/30 12:39:35 obr 1.1.2.18: #i63580# AtkRectangle not defined in older atk versions
                [...]
        
        The above extract from the commmit message as well as a quick
        look into the corresponding OOo ticket [1] suggest that the only
        concern were old ATK versions that didn't have `AtkRectangle` yet.
        
        Since the code looks sane at a quick glance at the corresponding
        ATK doc [2], just drop the `#ifdev HAS_ATKRECTANGLE` check
        and enable this unconditionally.
        (atk >= 2.28.1 is required by now, which definitely has
        AtkRectangle.)
        
        While at it, switch to the new style of using a dash
        instead of an underscore in the signal name.
        
        [1] https://bz.apache.org/ooo/show_bug.cgi?id=63580
        [2] https://docs.gtk.org/atk/signal.Component.bounds-changed.html
        
        Change-Id: If448c5e79df6f2dd38c3a9acd414cc778f4d1f3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137011
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [454e182898cdf9c8a9ce1b575591910bbff3a762]

        Simplify XMLTextParagraphExport::addHyperlinkAttributes
        
        Change-Id: I283fc348d1ecaee92095f50c6f7d92fff8b09dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136994
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [54a97eb9ddd66294f303189ca12ef726177453cb]

        clang-tidy modernize-pass-by-value in vcl
        
        Change-Id: I9ddb786eb88213c53cf53067ced6899ca40ac6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-13  Hannah Meeks  <hmeeks4135@gmail.com>  [72f631977435a704008a55d3be6489ba619e3064]

        add first writer vba test - for find behavior
        
        Change-Id: I25136c7954339d79521f84ad9eca79a701930fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136944
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-13  Laurent BP  <laurent.balland-poirier@laposte.net>  [cae349e4770862b36176b601d7d572844c215d4f]

        tdf#149723 Fix Piano Impress template
        
        Add presentation:class attributes to date-time, footer and page-number
        of Piano master page
        Add light grey color to footers on Piano1 master page
        
        Change-Id: I08c405df32639d77ef9ae8d59c1333e70215ce40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137007
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-12  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a4ab155ae15e9e6d4deb157634f8b86c87fcbde4]

        tdf#149313: DOCX import: improved conditions for removeparagraph
        
        Quite complex conditions to define if current paragraph can be
        removed for document were forcing to keep paragraphs after page
        break with only section definition. Usually these pars are removed,
        but since tdf#103975 fix they were kept.
        
        It looks like to resolve that problem will be enough to ensure
        current break is a column break: they are bit different and
        processed in a different way unlike other break types.
        
        So this condition part instead of "do not remove par with section
        info after any break" it is right now "do not remove par after
        column break".
        
        Change-Id: Ib6290dc6254430883a598bef3ecd1f7ab7063922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135969
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2022-07-12  Justin Luth  <jluth@mail.com>  [a73daa562c82a5c058a217ba80035da08d40451d]

        tdf#114734 docx export: save comment paragraph properties
        
        DocxExport::WriteOutliner is only called for TXT_ATN,
        so it is safe to change this generic-sounding function.
        
        Anything in the future that wants to save "draw" text
        likely also would want to save paragraph properties as well.
        
        Change-Id: Ied37670f2d3d0d6096300dbc9749c8230abfdc44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136965
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2022-07-12  László Németh  <nemeth@numbertext.org>  [c903c91aced13ae296456e54a5c90d7ca3938594]

        tdf#149707 sw_redlinenum DOCX export: fix tracked moving of list items
        
        Change tracking of the paragraph mark of moved list items
        wasn't exported. I.e. moveFrom and moveTo paragraphs
        are exported as old paragraphs with new content, e.g. accepting
        a removed list item and rejecting an inserted list item leave
        empty list items instead removing the list items completely in MSO.
        
        Note: in Writer the import of the old (incomplete) DOCX export
        worked before this commit, too.
        
        Change-Id: I9367d880af16aab376178ab6d226b3013688997c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137005
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [25446db3a951549492fba19fecb54c9347dd18ae]

        elide some dynamic_cast
        
        Change-Id: I32c804e64cf219364e27ad6d9549c68c1f737a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-12  Luboš Luňák  <l.lunak@collabora.com>  [52e1a6a3e4d613eeb9313922098b0ba11807fb12]

        use a read-only stream when reading graphic data
        
        EmbeddedObjectRef::GetGraphicStream() creates a writable
        SvMemoryStream, read the graphics data into it and then returns
        the stream, which will be afterwards used to decode the graphics.
        But if the data is broken, incorrect seeking may cause a seek
        way past the buffer, and since the stream is writable, it would
        be done and cause problems such as running out of memory.
        The VersionCompatRead class is one such place that reads size
        from the stream and then seeks based on the read data.
        
        Add SvMemoryStream::MakeReadOnly() that will change the stream
        to be read-only after the initial read of the data into it.
        
        Change-Id: I1d44aabaf73071a691adafa489e65e4f5e3f021d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137002
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-12  Laurent BP  <laurent.balland-poirier@laposte.net>  [56dff7b244fb0ef28951193a410dd5c4a3126590]

        tdf#96723 Number format: embedded text in decimal
        
        Embedded text in decimal part is represented by negative position
        Use number:position as it is defined as integer in schema [1]
        Add Unit test to import XLSX file with embedded text in decimal
          and export to ODS
        
        [1] https://opengrok.libreoffice.org/xref/core/schema/odf1.3/OpenDocument-v1.3-schema.rng?r=7f3c9da5#7142
        
        Change-Id: Ic68471a071ccbb1c3bec442bfcbe21d84f41ebd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135918
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-07-12  Colomban Wendling  <cwendling@hypra.fr>  [2dde21ea74223ca68865ee87558baad0d3eb4e46]

        unittest: Split out registry entries to alter UI definition search path
        
        Accessibility tests will require testing the normal UI, so will need
        not alter the search path for definitions.  It will however benefit
        from other environmental overrides (locale, fonts, etc.).
        
        The solution here splits out to a separate registry the piece of
        configuration that alter the UI, so users can select the features set
        they need.
        
        The default gb_CppunitTest_use_configuration is updated to keep working
        the same as before, using both layers.
        
        gb_CppunitTest_use_unittest_configuration is replaced by specific ones
        for each configuration layer, and the two direct call sites removed as
        they were redundant anyway (gb_CppunitTest_use_unittest_configuration
        is only a subset of gb_CppunitTest_use_configuration).
        New macros are gb_CppunitTest_use_common_configuration for the common
        layer and gb_CppunitTest_use_user_ui_configuration for the UI one.
        
        Change-Id: I75f82092079752b4e173e48ab463636e7b7515b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136997
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [c61f797110503104541b5f587883c2fcf4ca09e8]

        elide some temporary OUStrings
        
        Change-Id: I93ee61a04dfc1bb3dc758fd83a503f7374824ae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca2a4a4b1c839c14832043e714297c30087b4b6d]

        clang-tidy modernize-pass-by-value in xmloff
        
        Change-Id: Ica07e393763343d0f5caaad6a89fa3378f6ad344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-12  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [2f93eb49db71c8cbaffbd022cb2b654d56920bda]

        tdf#142715 sw: fix crash on exit when textbox inserted to table
        
        This reverts commit 06e2cbb31d0ea703df872b91eb8eacdcaced7653
        "tdf#130805 SwTextBoxHelper::create: fix frame position in shape"
        which caused this regression. That fix is not necessary any more: synchronization does the same without crashing.
        
        Note: according to this, unit test of commit 06e2cbb31d0ea703df872b91eb8eacdcaced7653 wasn't removed.
        
        Change-Id: I45bc15d3cf6a5d93b8c54cb4e68018702e58efff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136674
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-12  Luboš Luňák  <l.lunak@collabora.com>  [3dd03090ecee3ab9c3c406de0e8013ee2f3cd364]

        close object tag if writing out the preview(?) fails
        
        When writing out OLE frame, if a picture of it (or is it preview?)
        is not available, the code bails out, but that leaves the object
        tag unclosed. Since it sets only a warning and so it appears to
        be non-fatal, close the tag properly before bailing out.
        
        Change-Id: Ib8a6d692b0c3b4cb9ff5bcfe3c964efdaed3dab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136962
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-12  Andras Timar  <andras.timar@collabora.com>  [5e1ab6a203843f98966956e706c888fd1f89e284]

        sdext: these tests won't run without poppler
        
        Change-Id: I61deb7d5271bf87ac1bb3aad54c430ace8fd3f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136975
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-07-12  Hannah Meeks  <hmeeks4135@gmail.com>  [f6be2bf969bac1f5c6ac452b313374ba09ffaa58]

        tdf#149775 - VBA: Find should stay around.
        
        Previously we would create and destroy it for each set of a
        property on it making it useless. VBA Find object oddly
        represents the Find dialog in Word. Add it to SwDoc.
        
        Change-Id: Id9850cbd2296b24f9c93dc99b2967095bd84921f
        Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136630
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-12  Mike Kaganski  <mike.kaganski@collabora.com>  [faa88099d842b83365fa86a661dc56f0031a9b29]

        tdf#149947: simplify filter list creation
        
        Change-Id: Ic44d217a5593cc8694bc2f2f2e19e0c66d3ae9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136957
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [86977309bf5ff716ecf74e337a70f0f7f8edb5cd]

        Breeze tdf#149753: Distinguish between New Presentation and Start from First Slide
        
        Change-Id: I1a60b846343f25ee6bad8a4de2ab864d5a9acb5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136967
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6c00e6648d40b99a6066172ddd3c1de2ace9e849]

        Breeze: tdf#141110 Update No List icons
        
        Change-Id: I00563049f1d3ee4a131df9ae73bc081da70905fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136970
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [abf1fc512be49658e83ee5a091ed59ed0be1f238]

        Sifr: tdf#141110 Update No List icons
        
        Change-Id: Ie93d72783a078125c87631e79bea8466a9f3814a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136972
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [9eda7c8ad22d10f24897fe6e8b764f19e9b1948c]

        elementary: tdf#141110 Update No List icons
        
        Change-Id: I696c964fe5051eecb65a0c95820c3fd69897e735
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136971
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [52e2dc619d3d7b8089d9841d38b10f1d8a64f747]

        Colibre: tdf#141110 Update No List icons
        
        Change-Id: Iaa8e71c91b183c99c5ba7f4a13e7527c087cc6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136968
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [5a363056963501780451667d7adacf7435c49b08]

        Sukapura: tdf#141110 Update No List icons
        
        Change-Id: Ie043cb6933279d9d082c0636947ff42a0fb91286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136969
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-07-11  Julien Nabet  <serval2412@yahoo.fr>  [44eac6530c9692eeaf51efdbd2f5f37180c9c214]

        tdf#149951: MySQL/MariaDB (direct connection) save images in BLOB-fields
        
        There were several pbs:
        1) no size value was given to resetSqlVar whereas all BLOB or related need an explicit size so was 0
        => provide size value with x.getLength()
        2) Type provided was Sequence instead of a sal_Int8 so unitSize was 8 instead of 1
        => provide "&x[0]" instead of "&x"
        3) m_bindMetas[nIndex].length wasn't filled
        => initialize it with x.getLength()
        
        Change-Id: Iaca6a8f8142601c224d6f7aabe4414e61586d29f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136964
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-11  Justin Luth  <jluth@mail.com>  [cf02b94bc513ee1b742b4c5d7174632b568e8b72]

        tdf#114734 writerfilter: avoid PostIt exception
        
        Comments (aka AnnotationMarks) cannot contain
        a paragraph style. The exception was causing
        all properties to be dropped.
        
        This fixes the right-to-left text direction issue.
        
        Additionally, I need to cancel code
        when dealing with justify. There is no
        underlying style to deal with,
        and also MS Word seems to treat justify
        literally when dealing with comments.
        
        IIRC, LO interally always refers to justify literally,
        while DOCX normally depends on the RtL context,
        treating LEFT as START and RIGHT as END.
        
        Hmm - I bet that complicates things for export,
        since exporting comments needs to be handled uniquely.
        
        Change-Id: I4f604f90aaad36ea56b8a9157a8a8458f39877c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136690
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2022-07-11  Eike Rathke  <erack@redhat.com>  [dbef922b7ac63c56bd534c1475790198a64131b1]

        Resolves: tdf#141565 Correct character sequence for Devanagari unique ID
        
        A copy-paste error of the Farsi sequence.
        
        Change-Id: Ib19f97f0bc3bf018d659f8e998d0daa71e1d5c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136958
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [71ef4d46e9dd236fe355dceb7a2ee66c04d1ce1f]

        tdf#149649: sw_ooxmlexport16: Add unittest
        
        Change-Id: I764e8803d4067572516c2f1e3995f4a19b78b7c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136956
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-11  Hannah Meeks  <hmeeks4135@gmail.com>  [b12c18c8cfcf37e8a351d76b96aa853cf9bb6766]

        Re-work extension handling to make tests easier to add.
        
        Change-Id: Idddbb99804bdc1354db7a1059c68c820ba6a98b3
        Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-11  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [1d3d2a995239c3c71432006cb795324c56a0412a]

        tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxes
        
        Regression from 2110597ac730fa07dbbdd603fda82b182ed27c9e
        "tdf#147485 sw: fix group shape crash using std::shared_ptr".
        
        Details:
        
        1) Using reference instead of copy assignment in SwTextBoxHelper.
        
        2) Cleanup: Unused parts of SwTextBoxHelper were removed.
        
        3) Fixing destruction of textboxes, in case when first the shape
        is removed, with clearing all textboxes from the doc and the shape
        before the pointer is released. All of this only have to be done if
        the call is not coming from the swdoc dtor, unless there will be
        double freeing.
        
        4) Missing style conversion was fixed in writerfilter.
        
        5) Don't import sections in textboxes, unless the hack of dummy
        paragraph before tables in sections will be applied and the paragraph
        with anchored objects inside will be removed with the objects;
        
        6) ConvertTextRangeToTextFrame also fixed, so embed frames in
        frames are imported from now. (Also textboxes in frames, this
        can be useful when there is a floating table having group
        textbox with nested complex content inside, or floating table
        in floating table, etc...) Note: Follow up commit will enable
        group textbox import in frames and tables.
        
        7) Import of group textboxes with complex content in header/footer
        was impossible, from now this is also supported both from DOCX and
        ODT (test included).
        
        8) Guard class for blocking unwanted recursive textbox sync
        has been introduced, and maybe some speedup with group
        textbox import has been achieved.
        
        9) The anchor sync method got a new function which avoids
        unnecessary sync when the anchor is the same.
        
        10) Sync of As_char textboxes during layout calculation caused
        crash so that has a workaround from now, for DOCX import anchor
        change and Undo. That syncs starts before the layout calculation
        so sync not needed later.
        
        11) A memory leak was found in Undo, which has been fixed.
        
        Note: layout test "testTdf147485Forcepoint" has to be limited
        to Windows and Mac builds, because font substitution
        causes crash on the Unix based systems.
        
        Change-Id: I69d5d79cc120e3a70ba9285be32ec36a434b2a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136192
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-11  Julien Nabet  <serval2412@yahoo.fr>  [f8a84ef8f085251d545597a83d71b5b5b2f547d6]

        tdf#149738: Minor inconsistencies in sparkline related UI strings
        
        Change-Id: I5b4c31e69743ad519a8bcc99fa3a5a7512a4cc18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136955
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-11  Arman Rezaei  <fadelights@aut.ac.ir>  [20c54847db287a21285835bbdfd09a66070a4c6d]

        tdf#143148 - Use pragma once instead of include guards
        
        Change-Id: Ie8daf1c7baa6937bbc44538abed9074b4813f858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136953
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [934985becc567114c3f38a72322056a628aad7c9]

        tools: rename getHeight/Width() to GetOpenHeight/Width()
        
        By default Rectangle uses closed interval, if we really want to use half
        open intervals then we should specifically say as such in the name.
        
        Change-Id: Id7a91120ba1a1a4bc330014216b73a692dbf03a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136575
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [a19e01812b60580c656cf31619e212803e2ca0fa]

        vcl: change drawToPos() to drawToIndex()
        
        Change-Id: Iaf102e529cdfd3d758e4e6976f6a99330d8fc64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76405
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-10  nazanin yadi  <nazanin.yadi02@gmail.com>  [a93d7e7df6804cd6f1f2fa1ef0e6e95ce6c3752a]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ibbcfa123032cfbe141e6f33ff1f65054f129d3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136682
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-10  am.faraji  <am.faraji80@gmail.com>  [5aad816758652e5a4112527cf477d84e72a724ba]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I7bd02dba44a8bc62da660bcb7500960ef14172a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136939
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-10  Julien Nabet  <serval2412@yahoo.fr>  [e8388c9456dc1a7c753f4bc2a86473ced3be0830]

        tdf#143279: fix accessible-name in cui
        
        Change-Id: If9343a687173b489a24ef3640715f844d5ba9a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136911
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-10  ehsan  <m.ehsan.movahedian@gmail.com>  [514de206bcd4a59260a806b86f0e90146681d186]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I488c8e58620ed89adf67f93f0edb4084765a0ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136441
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-10  ehsan  <m.ehsan.movahedian@gmail.com>  [2558bb6cfd7e3faf33b7b24cb056a8e44ba8297d]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I89f7fb1ec47ee5d7fc3ddb737527bbf2497f9454
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136774
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-10  Mohsen Rahimi  <mohsenrahimi1380@gmail.com>  [63ef38cf8140a155e8d34497c5b0050432298bce]

        tdf#143148 embedserv: Use pragma once instead of include guards
        
        Change-Id: I5a96d63657cdbaf0c161f742307a1e7a09945dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136949
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [bb4314aa21baec08268e0f02b816a8cf05096ceb]

        tdf#146781 - Function wizard: search desired function also in the description
        
        Change-Id: I12f2fd5bf3497505a8652ab98bccb495a619333d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136905
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-07-09  Noel Grandin  <noelgrandin@gmail.com>  [77ead3d8c01b3663b0ff701a934f10b602252412]

        tdf#149890 SVG: pattern is displayed with black fill
        
        regression from
            commit 3cbe3a0259bea4dec70e72191ec3c03441926a07
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jun 14 15:05:59 2021 +0200
            tdf#101083 speed up SVG rendering with pattern fill
        
        Change-Id: Ifabe5dd0de92c3b27033c49af5713bc5825d10c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136912
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [c1c8ce3b0f1037bca4d500af2f39363cd9d38db6]

        svgio: Rename variable and add unittest
        
        The meaning of the name got obsolete after
        cded65d05a01ac34af750ddb97f1ffb51f3d638a
        < tdf#149893: Color names are ASCII case-insensitive >
        
        Also add a unittest for 9b0069c2833313ba9fab91f45edd354ba334f94b
        "SVG: Using the marker property from a style sheet is equivalent
        to using all three (start, mid, end).·" when this code was added
        
        Change-Id: I87e0866cbd56bbc770920b0778ce681ac9d255b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136910
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  Luboš Luňák  <l.lunak@collabora.com>  [e7cc4ceca48c263270c01e9178ac3d68869f0050]

        include namespace when writing <div> tag in Writer HTML export
        
        Change-Id: I5ae6cea44b1bff8dc55162e2f9cd6f034fe2857d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136897
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-08  Michael Stahl  <michael.stahl@allotropia.de>  [436ae10ec546391ce21875c69b0ec4bb3a06fa1f]

        tdf#149649 sw_fieldmarkhide: delete any fieldmarks overlapping cells
        
        The DOCX bugdoc has a field that starts in the first cell of a table, but
        ends outside the table.
        
        [  28]  0x3690e10           TableNode ,
        [  29]   0x78d6f80          StartNode ,
        [  30]    0x6cfb408          TextNode "\a FORMTEXT \003Data File",
        [  31]   0x6bf9620            EndNode ,
        
        [ 631]  0x779c768            TextNode "",
        [ 632]  0x69bd5f8            TextNode "\b",
        [ 633] 0x656f150              EndNode },
        
        This triggers an assert in layout:
        soffice.bin: sw/source/core/layout/frmtool.cxx:1971: void InsertCnt_(SwLayoutFrame*, SwDoc*, SwNodeOffset, bool, SwNodeOffset, SwFrame*, sw::FrameMode): Assertion `!pLayout->HasMergedParas() || pNd->GetRedlineMergeFlag() != SwNode::Merge::Hidden' failed.
        
        This bad documnet model is created from writerfilter in a call to
        SwXText::convertToTable(), so add some preventive code there.
        
        The end of the field is erroneously also at the end of the body instead
        of a few paragraphs below the 1st table, because in PopFieldContext() the
        xTextAppend->createTextCursorByRange(pContext->GetStartRange()) throws,
        due to the bad document model.
        
        It turns out that Word can actually load this document, but the
        behaviour is rather funny and would be difficult to replicate...
        
        Change-Id: I20b9293db8888511bc0066c775d54fc59fcaa349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136906
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-08  Stephan Bergmann  <sbergman@redhat.com>  [27ffdcf096a7e9863489599dd80528b088d1e9b8]

        rhbz#2104545: Only call utl::IsYounger when its result is actually used
        
        ...as it may be expensive, or even throw (uncaught) exceptions (as apparently
        happened at rhbz#2104545, throwing some css::uno::RuntimeException while aMedObj
        was an sftp URL).
        
        The two branches in the if statement's condition that will now potentially call
        physObjIsOlder are disjoint (one for aMedObj being a file URL, the other for
        aMedObj being any WebDAV-related URL), so there is no chance that this change
        accidentally causes utl::IsYounger to be called more often than it used to be
        called.
        
        Change-Id: I29a5f18a12a8b83ec603366db26451175b5622c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136904
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-08  Henry Castro  <hcastro@collabora.com>  [ca7fa700b10ea8947333ec72f763c3d47a4b2e57]

        sc: lok: fix offset other edit view
        
        Multiple view case.
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8049f2f36438e77beb5fe41399007ced0d500efa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136812
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        (cherry picked from commit 59bee366f9df6df26cc9b92b19997fc7f5112c7d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136917
        Tested-by: Jenkins

2022-07-08  Henry Castro  <hcastro@collabora.com>  [0138dde8fd01d63a789fee8ab146691f66e3066a]

        sc: lok: fix offset edit output area
        
        When focus is received, the edit view output area
        rectangle is calculated to draw the text, after
        EditGrowX and EditGrowY checks, so intercept the
        rectangle to not alter the text positions.
        
        Change-Id: I1439fc3d436bd5f4d03b13bd6bb56a85012a2655
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133214
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        (cherry picked from commit 037ec953d230aef045034b59d8315e6c41dc6687)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136916
        Tested-by: Jenkins

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [af0eca8181ad3d9e601167b70dd84e892f24ee8c]

        svgio: o3tl::starts_with() -> o3tl::equalsIgnoreAsciiCase(o3tl::trim())
        
        display="NONE" or display="  none " are valid but display="nonet"
        is not
        
        Change-Id: Ib230d9365be3671a9a0fcb05be099b7afad15375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136902
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3b63915221129b92d539bec81e450d19388cfd3]

        svgio: forgot the 'else'
        
        Spotted right after submitting 6dd0074e5e42467a7f82e363f67ca95d04466fa9
        "tdf#149913: add support for auto-start-reverse", stupid me
        
        Change-Id: Icaade6a5941f6e1cf6d612b56bbbfd4e2321a625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136900
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  Michael Stahl  <michael.stahl@allotropia.de>  [463178fef5c22f1a04d10e54491852d56e2038b0]

        xmloff, sw: ODF import/export of fieldmark separator
        
        Previously there were only the fieldmark-start and fieldmark-end
        elements; now add a fieldmark-separator, so that the field command can
        be stored as character data (and elements if there is any formatting)
        instead of attribute value.
        
        The import is a bit more complicated because there are already existing
        documents that are missing the separator; it's not possible to predict
        if there will be a separator at the time when the start element is seen,
        so add some hack to toggle inserting the SwXFieldmark with separator
        at the end (when the document contains a separator, i.e. after the
        command) or separator at the start (when the document is missing a
        separator, i.e.  after the result).
        
        Change-Id: I14d2f50f57d690e75643df5d14fd881ebc759a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136513
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3e9fede7e998979db7941a527496eb98c822e98]

        related: tdf#149893: trim the color name
        
        Change-Id: I50689993cbe979557a10d2d16eb2112471bef77d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136895
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  Stephan Bergmann  <sbergman@redhat.com>  [8abe6916308ed849ece9b3a58b860a73b04fec51]

        Make TestEmfPlusDrawPathWithCustomCap succeed on Aarch64
        
        CppunitTest_emfio_emf CPPUNIT_TEST_NAME=Test::TestEmfPlusDrawPathWithCustomCap
        introduced in 5b21b65572610df88986e700b81f1156aff14f65 "tdf#142770 tdf#143031
        EMF+ Implement CustomLineCap" failed for me both in a local master build on
        macOS on Apple M1 and in a Linux aarch64 test build of the libreoffice-7.4.0.1
        Flathub flatpak (at <https://buildbot.flathub.org/#/builders/21/builds/7749>)
        with
        
        > xmltesttools.cxx:195:Assertion
        > Test name: (anonymous namespace)::Test::TestEmfPlusDrawPathWithCustomCap
        > equality assertion failed
        > - Expected: 1423.297394625,1268.98481214025 830.006276132353,558.656004112967
        > - Actual  : 1423.297394625,1268.98481214025 830.006276132352,558.656004112967
        > - In <>, XPath contents of child does not match
        
        As this failed in exactly the same way for rather different builds (Clang vs.
        GCC; Apple M1 vs. whatever ARM processor used by <https://flathub.org/builds>),
        it smells like the test input might trigger a case where operations can
        legitimately produce slightly different floating point results, which would then
        cause the test to erroneously fail for some builds.
        
        So I hacked the test input
        emfio/qa/cppunit/emf/data/TestEmfPlusDrawPathWithCustomCap.emf slightly, making
        the EmfPlusPath's 2nd EmfPlusPointF Y coordinate identical to the 1st one's, so
        that the arrow now points west rather than north-west,
        
        >  00000190: 02 10 c0 db 00 00 00 00 00 00 cc ff 08 40 0e 03
        >  000001a0: 2c 00 00 00 20 00 00 00 02 10 c0 db 02 00 00 00
        >  000001b0: 00 00 00 00 2b b5 05 45 05 54 56 45 d6 66 00 45
        > -000001c0: 05 54 56 45 00 01 81 01 15 40 0e 00 10 00 00 00
        > +000001c0: 51 23 4d 45 00 01 81 01 15 40 0e 00 10 00 00 00
        >  000001d0: 04 00 00 00 0f 00 00 00 0e 00 00 00 14 00 00 00
        >  000001e0: 00 00 00 00 10 00 00 00 14 00 00 00
        
        which happens to let the test compute a different polygonstrokearrow/polygon
        value now, but which appears to be stable across at least my x86-64 and aarch64
        test builds.
        
        And temporarily reverting the non-test (i.e., drawinglayer) parts of
        5b21b65572610df88986e700b81f1156aff14f65 would make the test fail with
        
        > xmltesttools.cxx:121:Assertion
        > Test name: (anonymous namespace)::Test::TestEmfPlusDrawPathWithCustomCap
        > assertion failed
        > - Expression: xmlXPathNodeSetGetLength(pXmlNodes) > 0
        > - In <>, XPath '/primitive2D/metafile/transform/polygonstrokearrow/polygon' not found
        
        so the test appears to still faithfully check the intended difference in
        behavior.
        
        Change-Id: Iec31246dd7666ec764176622ccc4f246eea6e4ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136896
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-08  Michael Stahl  <michael.stahl@allotropia.de>  [5b0e81d462577113acac788ae4945e1cc00cf753]

        sw: split HideFieldmarkCommands out of ExpandFields
        
        The problem is that during ODF export, SwXTextPortion::getString()
        must return the content of the field command.
        
        Change-Id: I00f77056e286fefaca0f156dbc31b6569d9c816e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136512
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [6dd0074e5e42467a7f82e363f67ca95d04466fa9]

        tdf#149913: add support for auto-start-reverse
        
        See https://svgwg.org/svg2-draft/painting.html#OrientAttribute
        
        Change-Id: Iedcca7bc79a54333c0f80927364caec82ce61167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136894
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  Michael Meeks  <michael.meeks@collabora.com>  [a4acae686c2c55b18b5c27e832827d3c2d8e0f63]

        lok: skip app background rendering for lok case.
        
        this is/was mis-placed and tends to make a mess of large sheets'
        tiles close to the bottom at ~2^20 rows.
        
        Change-Id: Iac0977d58428707ff56c0ac30a7740c0ed0b27c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136866
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-07-08  Tünde Tóth  <toth.tunde@nisz.hu>  [93c83aa91cc7608bfdb6972ad024697f1bc85f98]

        tdf#149747 DOCX import: use UI style name for tracked changes
        
        instead of the programmatic style name, because rejection
        of tracked paragraph style changes was incorrect
        with an other UI than English UI.
        
        Follow-up to commit 0ad5d133bd75ccd3a04505aaac7ad3f2f9105f76
        "tdf#132781 DOCX: export interoperable hyperlink style names"
        and commit 4248d759744f83a68d334a8b347124719a2886a8
        "tdf#126243 DOCX: export/reject tracked paragraph style change".
        
        Change-Id: I3b3b163b2538732b2470162888083de0609895fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136624
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-08  Noel Grandin  <noelgrandin@gmail.com>  [8d8e6c84e512c1a8b33aac75965b84481d1a1d13]

        [API CHANGE] Drop css::accessibility::XAccessibleStateSet
        
        which is internal API, unused (as far as I can tell) by external
        users.
        This state is purely a bitset
          (as implemented by utl::AccessibleStateSetHelper)
        so we can just return it as a 64-bit value.
        
        This shaves significant time off the performance profiles
        of code that loads very complex shapes, because this state
        is frequently used, and we no longer need to allocate a return
        value on the heap for every call.
        
        Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [911ac42485b690df5cbbff6e3c04b111c1723aca]

        svgio: use IgnoreAsciiCase when checking these values
        
        They are also valid when uppercase
        OTOH, use equalsIgnoreAsciiCase along with
        trim() instead of startsWithIgnoreAsciiCase since
        " round " should be valid but "rounded" shouldn't
        
        Change-Id: If4060a23a1cf41833264051094103e37927d14c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136881
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-08  László Németh  <nemeth@numbertext.org>  [11071d95f4f3cbe578c3393729c42b7cce011b45]

        tdf#149711 sw_redlinenum DOCX: import moveTo paragraph mark
        
        It was imported as an old paragraph with new content,
        resulting that e.g. rejecting a moved list item left
        an empty list item instead of removing the moved list
        item completely.
        
        Follow-up to commit 80694a8fcfeb86ed69425ab6954b353b9a0ae854
        "tdf#149708 sw_redlinenum DOCX export: track inserted list items"
        and commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be
        "tdf#123460 DOCX track changes: moveFrom completely".
        
        Change-Id: Ia1997aeffeb45f89bb738c6faa95fb2efc54fd7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136886
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [19347d219fb017eeffb998c7ebd857585f263752]

        comphelper: replace tools::Long with size_t
        
        Change-Id: I1eba8e05bdc92fd689e368dd4fe0e79bc1f2b46f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135716
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b4c79383501225f53d1ef0fa430dd84cd97f2979]

        sc: refactor and simplify PrintPageRanges::calculate
        
        push more responisbility to PrintPageRangesInput with operator
        overloads and use ScRange instead of individual startRow, endRow,
        startCol, endCol and tab.
        
        Change-Id: Ia94c578c6dea48d65c59ceead2dc326faffc81ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135676
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-07-07  Luboš Luňák  <l.lunak@collabora.com>  [1f201d76d6e2fcc9d8af6504c38bd98c46e0798e]

        do not write vspace/hspace attributes to reqif
        
        These are not valid for the ReqIF-XHTML subset.
        
        Change-Id: Ie68560c49ba43b0f728c6e51eeb33b4829bded93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136887
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6a4537e3de65d551e10212a1ebba5eedf798ac5]

        svgio: fix copy-paste name
        
        Change-Id: Ic29fc98f70dd14b07190fd559c54c13be5777975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136883
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [09a3e24a8e4c0f11c62f104b0bfa9d31180003fd]

        i18nlangtag: replace tools::Long with long
        
        Revert to long as originally used in commit e81359a9a324:
        "added registerImpl() re-entered warning" and then apparently
        accidentally broken in the mass conversion commit
        e25fd7782ad04: "long->tools::Long in hwpfilter..oox".
        
        Change-Id: I39c983ddec83c84953bc3db167793944c671894b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135714
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [e03cd0893eb2031d775764b4696b838dd09fb474]

        svgio: make readLocalUrl standard-compliant
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=149880#c12
        
        Thanks to Mike Kaganski for the references
        
        Change-Id: Idb06cf40ee992dd73120ce051d8ba4f61faaadfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136877
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [adf419792743a4c79b2054e42618dff75bb552ce]

        elide some string copies
        
        Change-Id: I3e0d9f7e5a446689e007b9d01fb1c6bf9bc068e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136880
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-07  Mark Hung  <marklm9@gmail.com>  [23f80b26098bcf9a8ae870e8ded878cca6e0c541]

        tdf#149089 fallback GridMode.
        
        If line pitch is not defined -> fallback to none.
        Otherwise if charSpace is not defined -> fallback to lines.
        
        Change-Id: I1df027f2e74baf0215567fb9a70c879522558346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136622
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [cded65d05a01ac34af750ddb97f1ffb51f3d638a]

        tdf#149893: Color names are ASCII case-insensitive
        
        See https://www.w3.org/TR/css-color-3/#html4
        
        Change-Id: Ifdf887bad08ab606abef78fa8335bc49507f4a43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136879
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2022-07-07  Stephan Bergmann  <sbergman@redhat.com>  [68c6401e5359466fc0b888d1f3a9be75e4c6ec51]

        Use a dedicated log area for a SAL_INFO in test code
        
        Change-Id: I8824129c0c40406b3e0dd65d163662eb3aea258f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136878
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9030f2aa632633dd4014d41bd81cdb3c1aca4cb2]

        related: tdf#149741  improve tooltips for adding Table rows and columns
        
                 also change accelerator letters for columns, to avoid a
                 conflict with rows
        
        Change-Id: I99f36e654215f29fe1b4b2162fad4c6e12572c61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134359
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-07-07  Aman Jha  <amanjha752001@gmail.com>  [3bf537244973a19c09dc6ef6430e25a05ba5027f]

        tdf#139953 Apply and Edit Changes - drop first dialog go directly to Edit
        
        Change-Id: I613f78b8327aa62495ce2563944e3277895eac7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136103
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-07-07  Stephan Bergmann  <sbergman@redhat.com>  [c9cc978f5608eb1c89a99b563340ef67214b2055]

        Retire loplugin:toolslong
        
        ...which already carries some rather lengthy excludelists (indicating that the
        idea of "every `long` is wrong" is rather fishy), and now gets in the way of
        <https://gerrit.libreoffice.org/c/core/+/135714> "i18nlangtag: replace
        tools::Long with long"
        
        Change-Id: I5065064cf4ac61fe97a4c99ba4d493a807cdbf06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-07  Marco Cecchetti  <marco.cecchetti@collabora.com>  [3170a77121aed419cb5a606ee8e7bce7e9c275ac]

        svg filter: transform animations: support for scale and translate
        
        Now the emphasis grow and shrink animation is supported.
        Now the animation engine is able to handle array of values instead of
        single value param when computing the next animation state.
        
        Change-Id: Ic200103c6c26a63de8eecc37dcd36ba1a2f0d391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134870
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit a6ed16394c4a95cf204f38c30cb025bc99f00027)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136418
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-07-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [41139aa86ecbb4c34e9996eb0f95a194b8eb0771]

        Update git submodules
        
        * Update translations from branch 'master'
          to c2687d2f197c096563b19920262ded8ed15d2630
          - update translations for 7.4.0 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: I85614e5c08b7f31ebf654b85a50cf3b56c373d91
            
2022-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [d291957dce7a5af17717125cce974a2d2dd9d5b0]

        tdf#149880: handle url when it's inside the quotation marks
        
        Change-Id: I053323f9b48c8856d520095da0a4768ac03b0176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136847
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [9d4881392eded9081228509769f94538c38646b8]

        fix variable typo in upload_symbols.py
        
        Change-Id: I96e15bc4cc29262ce602a616e036a97f3e20916e

2022-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d8ac865bf32f37487c02a89c00d02cd3234ce1f]

        micro-optimisation in FastAttributeList
        
        Change-Id: If684357b8849258af213f06a52f71ea81ffac1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136844
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [67631563537623c44e5c6905e0df522ad204bfc9]

        shave some cost off SaxContext
        
        most of the time, we can skip the ref-counting associated with these
        string fields
        
        Change-Id: I7afc1aa08f3337d7c61478eab92abc2cdd2b9d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6923103a2d952aecb154223663688a085065b05]

        move old/unused plugins to store
        
        noting that I have only plugins that I wrote or worked on extensively
        
        Change-Id: Ic4931a6ac2df7902cac3968900330a7ce4eb2d57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-06  László Németh  <nemeth@numbertext.org>  [d5bf3d8dfe51aa6791fd88e62fc542d888aa05c7]

        tdf#149708 sw_redlinenum DOCX export: track inserted list items
        
        Change tracking of the paragraph mark of an inserted list item
        wasn't exported. I.e. a new list item was exported as an old
        empty list item with new tracked text content. It was loaded
        with bad actual/original numbering, and rejection of the
        incomplete insertion left an empty list item in the list instead
        of removing that list item completely.
        
        Note: the problem was inherited from OOo.
        
        See also commit 508ed558948353a3eb8be9adf3588368e440f4cf
        "tdf#115524 sw_redlinenum: show original numbering of insertions"
        and commit 4e5f89d2d3511b6421b388ecaba2f61ada14d084
        "tdf#119848 DOCX export: keep tracked deleted empty line".
        
        Change-Id: I869ba2f39749e188015f7c7371e5caf1d39060f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136838
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-06  Jean-Pierre Ledure  <jp@ledure.be>  [7c0f0afd58c00211236b138ddd4804099c5aec83]

        ScriptForge - (SF_FileSystem) new Normalize() method
        
        Normalize a pathname by collapsing redundant
        separators and up-level references
        so that A//B, A/B/, A/./B and A/foo/../B
        all become A/B.
        
        On Windows, it converts forward slashes
        to backward slashes.
        
        The Basic Normalize() method invokes the
        _SF_FileSystem__Normalize() function located in
        the ScriptForgeHelper.py module for execution
        with the os.path builtin library
        
        The os.path.normpath() function can easily be
        executed directly from python user scripts.
        However the FileSystem.Normalize() method is
        proposed as well for Python scripts
        - for compatibility Basic/Python reasons
        - to manage the FileNaming notation
        
        Change-Id: I1e089612432bd2c75b2e76ffa984289ef7f9d75c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136835
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd262525f45b389cd61d881c78d5d270afe298d6]

        CppunitTest_sc_uicalc: just use insertStringToCell...
        
        ... like the rest of tests in sc_uicalc
        
        Change-Id: I2fbe812443c194ad89411d837ace49f4c0b825cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136840
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d875e4fbb490c2cd3bd75fa88a865333932dd97]

        tdf#149665: sc_ucalc: Add unittest
        
        Change-Id: I0273e499ee607a54cbd32296e568ad46b1c0c0ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136839
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-06  Michael Meeks  <michael.meeks@collabora.com>  [170a2b9da7848b66d93e10aed29f7f5ac2c8ebca]

        tdf#90837 - clarify the error message re: over-writing readonly files.
        
        Change-Id: I757b29574526882da6e307cef51dfa70f6a1c4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136833
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-07-06  Michael Meeks  <michael.meeks@collabora.com>  [4140154fe76ab627ad142ecb9db62d304eae146c]

        opencl: no need for unhelpful nullptr OUString * case.
        
        Change-Id: I0b3cad2247706901e1a6b9c3df7fbbc9f23ff987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136816
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-07-05  Michael Weghorn  <m.weghorn@posteo.de>  [e4066a41406b1ddd454901b4fa718cf9be2746c4]

        qt a11y: Implement QtAccessibleWidget::table
        
        Implement that `QAccessibleTableCellInterface::table`
        override by returning the parent, if it is a table.
        
        This turned out to be the missing piece when working
        on an implementation for the Qt library to expose the
        AT-SPI table cell interface for a11y objects that implement
        `QAccessibleTableCellInterface`, and testing the
        "GetTable" method by calling
        `acc.queryTableCell().get_table()` on a selected
        LO Calc cell in Accerciser's IPython console.
        
        Change-Id: I6144c613f31cafc338ccac739cd7db1bf314d4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136836
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-05  Eike Rathke  <erack@redhat.com>  [484448bc04edfbe22db784d2c68a679a3f98fbb9]

        Resolves: tdf#149665 Strip first ' also for multiple '' if following is numeric
        
        ... and prepend accordingly when editing content.
        
        Change-Id: I9b35c4e370323966400e8e7ef3bce95026052f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136837
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-05  Henry Castro  <hcastro@collabora.com>  [ed3270a522c487e172f78eab5ee449fd68591bed]

        lok: vcl: introduce set_cursor_data method
        
        The ScEditWindow requires to assign a cursor,
        so the child widget can send cursor invalidation
        to client side.
        
        Change-Id: I429d484a311f217f2419e38d50f8d9a422640221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136829
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-07-05  Henry Castro  <hcastro@collabora.com>  [5e9f1f1bf905987c172299eb82f4a1f0f5682ee8]

        lok: fix regression "WeldEditView::DoPaint" for dialog tunneling
        
        Change-Id: I1cb345b3911d03dc90acef2a17705d654a06deb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128622
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136830
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-07-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f2af1527c65fbf696c4996a9b4fa68f7f325cf31]

        Fix typo
        
        Change-Id: I500b02954de8ed0897a9e6b7ba0e77252a171085
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136824
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-05  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [02c5c0288aeb3bd5e6f4bf63b53f39e6a73cba86]

        Related tdf#137145 tdf#137569 Capitalization + punctuation fixes
        
        Change-Id: Icd8a631da83c86333c7e5bcee0069165899d3041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136822
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [f5ca3291e4f2c25fbff49301d6f3a7ed0017a708]

        sw: fix null derefs of GetCurrShell()
        
        See https://crashreport.libreoffice.org/stats/signature/SwContentFrame::Cut()
        
        Change-Id: I00267b480d9c123f68996572d2e6fdebc4fb383f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136834
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-05  Michael Meeks  <michael.meeks@collabora.com>  [92f531209675e1855798f513fb7698fceddd022b]

        fix build with disable-avmedia.
        
        Change-Id: Ia57db9b2bcec4ff73e1332bb5b2197080343baa4
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136831
        Tested-by: Jenkins

2022-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f72592591f1dfbfda79e1aecb161de97f2a1b73]

        compact the RichString class
        
        Which reduces peak memory load from 495M to 455M when loading
        a large spreadsheet
        
        Change-Id: Iad78524bedf3db193820be2d507652abde59d67c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6378ed693960c852537c101faa85264c73643bf]

        compact the RichStringPortion class
        
        Which reduces peak memory load from 548M to 495M when loading
        a large spreadsheet
        
        Change-Id: I74adfddd1722bba7a9dfae6dd0135e5f2b78b1a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136826
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c90f2bd1ad87e86f0562920b49ea55c2cb317c9]

        remove span data storage from oox import
        
        We are not using it,
        and removing it reduces peak memory load from 648M to 548M when loading
        a large spreadsheet
        
        Change-Id: I683bfba6c8f151d8845bbd7d5f92cde2a9c17807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136825
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [a5d25a06a48b32fd35148265f3c328a28d21f73e]

        sfx2: fix null derefs of SfxViewFrame::Current()
        
        See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_tryLoadBibliography
        
        Change-Id: I80d764c4bbcf0c5affa3386fbb11f5a79e98b699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136828
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-05  Henry Castro  <hcastro@collabora.com>  [46ae4bea931a969feb82c9fce048c7893249ba23]

        sfx2: prefix m_ private member
        
        SfxFrameWindow_Impl class
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I8171d04b65b24b111048a6a13e8db6af9120edf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136814
        Tested-by: Jenkins

2022-07-05  Maxim Monastirsky  <momonasmon@gmail.com>  [b0a3245c63a2f77ce761ebd11820b341969a48b4]

        tdf#149741 Mirror insert column icons for RTL tables
        
        The usual approach of setting the respective property
        in *Commands.xcu won't work here, as that works with
        the paragraph direction, which doesn't have to be the
        same as the table direction.
        
        Change-Id: I9c4d49a5c553a8a74e7760d257167a0be42c89c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136818
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-07-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [18dacc47b212bec440a5f729a2787aa91db89b44]

        sal: fix invalid doxygen
        
        Change-Id: Ib26a695c88d02a0ce5a3c9974fae9f88d8ae89ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136783
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-05  Kurt Nordback  <kurt.nordback@protonmail.com>  [9b558357a3e7a4c908084134d56770809116b4f1]

        tdf#104428 Improve rendering of exploded donut charts
        
        This bug shows an exploded donut chart with more than one series. The
        concern is that the standard pie/donut' explosion' rendering, with the shape
        of the pieces unchanged but the pieces translated outward, gives
        unsatisfactory results in the case of a donut with more than one series,
        where the translated 'exploded' pieces can overlap with the inner ring.
        This proposed fix renders this case differently, by increasing the radius
        of the exploded ring but keeping the pieces concentric with the inner ring.
        
        This commit also modifies the unit test values for donut_chart.ods.
        
        Change-Id: I713b1f3ce4697d46d29914410056f0aa83c6aa8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [db63000ea7805ddd762521a7cf39de203dbe6c3f]

        tdf#137544 reduce ref-counting traffic
        
        we can store a direct pointer here, shaves 5% off load time
        
        Change-Id: I418916df946f53ead28bb5cf76614a874283e7d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136821
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7a8033dff0f6d3a35260ccaf24f51020f335463]

        tdf#137544 reduce unnecessary broadcasting when creating shape
        
        we have just created the shape, so no need to do the expensive broadcast
        
        Change-Id: I3500f0fd007aa531a63f894aaf21372d602f8dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-05  Julien Nabet  <serval2412@yahoo.fr>  [b98184bf82eafd6432b269ef14d1420c4242e941]

        tdf#117646: Clone Formatting not working for connector lines
        
        Change-Id: Idf62afeae3fa32708673a6b68da2d9e0ccbd5249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136815
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1e15482bcf6bf65dc611e19cbd2ffff479ef141]

        tdf#137544 reserve space in polypolygon
        
        Change-Id: Ic8dc5b7479c1353487bac883fc0e704356e90798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [567529002cac50624678d6968724e447bc243f2d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0222d5b94ca656d54f47027c4a3ca7b53a0ca6b3
          - update translations for 7.4/master
            
            and force-fix errors using pocheck
            
            Change-Id: I0ae7f1a2496b0deeaabe0518f4895c89c953e0c6
            
2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b9c51aee8a42e597efe78257ab051bf108c0128]

        dodgy use of dynamic_cast on an UNO object
        
        rather just stick to using getFromUnoTunnel
        
        ever since
            commit 5420fbd0d722754e4e01e48d661f0ee082caef56
            Date:   Wed Mar 12 12:09:03 2008 +0000
            INTEGRATION: CWS impresstables2 (1.16.30); FILE MERGED
            2008/
        
        Change-Id: I0ac7690ed779407c77c29fa319402e70427e184c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6124dccb7bb20688f98f5517c2604f510dd6f4fb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5a91be35bf16757602aa1600a0c154bd5560b2bf
          - tdf#149846 tdf#149759 Update CSV import Help page
            
            Change-Id: I1a3453a2ac8bf8a5db4df8c5fabecb3e5d83b873
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136807
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-07-04  Heiko Tietze  <tietze.heiko@gmail.com>  [de6f30bc459ba600193c0998b285afcfe0936c3e]

        Resolves tdf#133023 - Autocorrect "Automatic *bold*..." off by default
        
        Change-Id: Iddf3770f69d326e0e04551a93e8dd0695b1e92c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136727
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-07-04  Miklos Vajna  <vmiklos@collabora.com>  [4002a399af823055b6ba59db18ded1caba4969c9]

        sw content control, picture, lok: fix change of placeholder after insert
        
        Commit c769c369c87a46ec877b7eefee27988044a2798f (sw content controls:
        fix picture placeholders, 2022-07-01) fixed picture placeholders on the
        desktop, but left the LOK case still broken.
        
        This is a problem since picture placeholders are protected (which is
        wanted), and these only allow SID_CHANGE_PICTURE, not
        SID_INSERT_GRAPHIC.
        
        Fix the problem by adapting
        SwXTextDocument::executeContentControlEvent() to dispatch
        SID_CHANGE_PICTURE (and not SID_INSERT_GRAPHIC), but do keep the slot ID
        of the argument as SID_INSERT_GRAPHIC, since SwView::InsertGraphicDlg()
        looks for a non-interactive URL as SID_INSERT_GRAPHIC even if we're
        changing an image, not inserting a new one.
        
        This means that LOK clients can't use SID_INSERT_GRAPHIC to change
        picture placeholders, they have to go via
        SwXTextDocument::executeContentControlEvent(), which is what
        gtktiledviewer does already.
        
        Change-Id: Ica42939f6564da3d59396a4b302be826d3968f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136797
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [895643431e6aea672158bae3772a36f26cd05cde]

        tdf#137544 no need to create a OUStringBuffer here
        
        we can just pass a view here
        
        Change-Id: I71679106ee749f64eac4819c2a4f282e40865639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [de59dbdc488122f70229550dba21ba76e2c61146]

        sw_uiwriter: simplify autocorrect test
        
        In preparation for https://gerrit.libreoffice.org/c/core/+/136727
        Also put this test with the rest of autocorrect tests
        
        Change-Id: I9aa632ff5751e603bf2a4f201b96b9a0369efc91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136799
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e8f89f80ca0405c01d9b068ca9e85328e87404b]

        tdf#137544 avoid some dynamic_cast cost
        
        Change-Id: Ib60369eabb2ce5e9cde2dce80137b786130c0eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a6833a00fb7fcf04c71fcaa05dbee1f15a075d4]

        tdf#137544 reduce cost of SolarMutex checking
        
        the  std::thread::id facilities are cheaper than the sal versions
        
        Change-Id: I5ccb7e54f3a1e4d715338faa1e9c0aae9449e46d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d30810b5a116816fe8a6d3341aa98e43adc56de2]

        dont instantiate TextImport unless we need it
        
        speeds up loading XColorList and related UI elements
        
        Change-Id: I737137669afea8a70dfefa78cf9f8a325d16fbcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136806
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Attila Szűcs  <szucs.attila3@nisz.hu>  [690d4eb71509649ad147cfe60f5b97e2cfaaa519]

        tdf#43100 tdf#104683 tdf#120715 sw: cursor on spaces over margin
        
        Allow cursor movement on spaces over margin (or clicking it
        it to position the cursor), like MSO does instead of stopping
        cursor before the stripped (from the typesetting) spaces.
        This way it's possible to follow the modification of these
        characters, e.g. removing spaces or inserting other characters
        at the cursor position.
        
        Follow-up to commit 8741fd0e0ae9e346de2e09887f0668b831c9b48b
        "tdf#43244 sw: show stripped line-end spaces on margin".
        
        Details: extend SwHolePortion to calculate its width,
        that can be used for cursor movement, even over the right
        margin. Removed some code that not allowed cursor to be
        positioned over the right margin. Layout calculation uses
        m_nWidth variable (that was 0) to make frames. To keep the
        layout unchanged, this new width calculated into m_nExtraBlankWidth temporarily, and this extra width is added to m_nWidth only
        after the layout calculation is finished. (Ideally this 2 width
        values could be stored and used separately, but that would require
        a bigger refactor of the cursor calculation.)
        
        Known regression: lost selection at Search & Replace, e.g. searching
        double spaces: there was a narrow selection at end of the line
        showing the position.
        
        Other issues: when a different character inserted on the margin
        resulting new line break, space formatting marks aren't updated
        according to the less spaces. Removing the inserted character by
        Backspace results losing of the cursor movement on the spaces.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I342b3ac68bef508389f1e227e52a03a22919301e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136613
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-07-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac33020ea870fc137fd8ee80cbd6c79310b260ad]

        tdf#137544 avoid some temporary OUString
        
        Change-Id: I4db4d12261920c94bf632f07fc129e3d324dd22e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d6a363d83011ce3f195b96816e25dd749772cc24]

        tdf#131568 - Chapter numbering dialog: sort list of character styles
        
        Change-Id: Ibe6830a7d3fdd35c4d8e6fa2b7c0007fa318083a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136798
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-07-04  Henry Castro  <hcastro@collabora.com>  [d22d86e266826543e9e7ca406bedcddae04074cb]

        sfx2: replace pWindow m_pWindow
        
        SfxFrame class members
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: I1fd272a113763f6330f15ee34095e9e34ce5dd34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136753
        Tested-by: Jenkins

2022-07-04  Michael Weghorn  <m.weghorn@posteo.de>  [bf731dedfad5f498e4eebdc9fbf776c6e10eafce]

        tdf#149804 Set default listbox bg color to white
        
        This restores white background color for list/combo boxes
        for the the "gen" VCL plugin after
        
                commit 3c6a53b9ce64180b2a03e097c1844f7496f26815
                Date:   Sat Apr 17 14:49:43 2021 +0200
        
                    improve the look of the macOS combobox
        
        Other VCL plugins and Windows, which use the system style,
        are covered in
        Change-Id I31401af38b991e7e0cdc436b894ee0f491a22752,
        "tdf#149804 Set newly introduced list box colors from system colors".
        
        macOS Should be unaffected by this change of the default color,
        since it explicitly sets one in `AquaSalFrame::UpdateSettings`.
        
        Change-Id: Ia9a660bceade683386a07c84a45a1757af38882f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [268f0f3f0d70902acaeb3f99e0d206ad66ffd67c]

        run CppunitTest_chart2_xshape without ENABLE_CHART_TESTS
        
        This was added in d8ae59e097b3fca29f071d1a792cdb98ad8139cf
        "add concept for chart xshape tests" and it's only run
        when using --enable-chart-tests
        OTOH, SdImportTest::testDocumentLayout in sd/qa/unit/import-tests.cxx
        also uses doXMLDiff to compare shapes and it's run without any
        special flag.
        Let's remove the ENABLE_CHART_TESTS check to see if jenkins or any
        tinderbox fails. If it does, we can always revert this commit.
        If it works fine, I'll remove the --enable-chart-tests machinery
        in a follow-up commit in some days
        
        Change-Id: I5d462df09303701826e5849e9e3bacca465da814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136796
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-04  Miklos Vajna  <vmiklos@collabora.com>  [0203485a7f7dd85f8d3e04ce91579051aa89d26a]

        sw content controls, checkbox: reduce left vs right amount of shading mismatch
        
        This was a visual problem with all content controls, but most visible
        with short ones, like checkbox.
        
        A content control's layout starts with a field portion (shaded),
        followed by a content control portion (also shaded). The shading around
        the checkbox character is not balanced, the left side has more shading.
        
        Half of the additional shading is caused by shading for the field
        portion: avoid this in case we know where will be a content control
        portion after the field portion.
        
        The result is not perfect, but the left/right mismatch for the amount of
        shading around the checkbox is much better this way.
        
        Change-Id: I147d23c43e679113c84c21fbfc0c8ac1ca9e51b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136792
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-04  Chris Sherlock  <chris.sherlock79@gmail.com>  [6952be913510c63716940648a06163c19622187e]

        tdf#143148 registry: Use pragma once instead of include guards
        
        Change-Id: I8598034598d6911b784a1550c78552f6ac87bc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128172
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-04  Chris Sherlock  <chris.sherlock79@gmail.com>  [591b9daf8cf89dc4e7a01cec9bf9623747094a3d]

        tdf#123936 Add formatting commit to .git-blame-ignore-revs
        
        We need to ignore commit e02a7a55c23d:
        
        "registry: remove unnecessary comments"
        
        Change-Id: I5fa5c69a7ebb98b5d19260323480c33b0b48cd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136784
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-04  Miklos Vajna  <vmiklos@collabora.com>  [3b7920043fcb42f68efae99fe290d1b759522443]

        sw: prefix members of ww8toolbar
        
        PlfAcd, PlfKme, PlfMcd and SwCTB
        
        See tdf#94879 for motivation.
        
        Change-Id: If1d7b99971299f2360df5c7ef4631680f29fb3fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136791
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-04  Szymon Kłos  <szymon.klos@collabora.com>  [044b6d343ecdd31670bbd824a8758ee1071327cf]

        jsdialog: send grab_focus action
        
        - disable jsdialogs for navigator panel for now because it breaks
          tests but is not used in online yet
        
        Change-Id: Ib91050363add8cda1c386627c312b79e0f62b99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136603
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-07-03  Julien Nabet  <serval2412@yahoo.fr>  [d2dfc0c4286057f5d8dda178817de3503c3a7d29]

        tdf#149822: Clone Formatting does not apply glow effects
        
        and since we're here, let's add too the soft edge radius.
        
        Change-Id: I84f84c0f57b0cf59f6e681ada7682b152eb209f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136787
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [19dce74e1500fba57fa4dc37aebe6f73d09bf4e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95301198e1518884a318bf24a1adbd8fa883a412
          - tdf#139469 Fontwork dialog for text to curve alignment
            
            Help part, align with widget tooltips
            
            Change-Id: I80b750eaf852f7559307f01f857e617ff309545a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136520
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-07-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [45623966c670bfd039817a0178a7a92a8b599978]

        tdf#139469 Fontwork dialog for text to curve alignment
        
        Improve terms used in the dockingfontwork.ui dialog
        The dialog has no widget labels, only tooltips and extended tips.
        
        Help part follows.
        
        Change-Id: I010b545bccac5a14e11265c05151e7934c6089ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136519
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-07-03  Julien Nabet  <serval2412@yahoo.fr>  [7b49b3ebc17378566942e7b263e0e5f2b400dbd1]

        tdf#130252: Impress: Clone formatting not cloning highlight color
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=130252#c5 for full analysis
        
        Change-Id: Ie87663c716a6ed31f753e0db5519436f6947aad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136785
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-03  Chris Sherlock  <chris.sherlock79@gmail.com>  [c28455b899fa7e9d88f843cd59663aa522a28a33]

        tdf#143148 store: Use pragma once instead of include guards
        
        Change-Id: Ic07c02bfbde9cedd397ed5913a26d5add1fdda5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128171
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-07-02  Julien Nabet  <serval2412@yahoo.fr>  [dcdf970684131cd60af3c5b927a1e05ba6c7ba81]

        Revert "tdf#137544 std::unordered_set is cheaper here"
        
        This reverts commit 8e7edc8c3620e4f733c1974a288e5a5abd29f87e.
        
        With a brand new LO profile, launch Writer and close LO, I get:
        0  0x00007f76f7e752f5 in std::__uniq_ptr_impl<comphelper::SolarMutex, std::default_delete<comphelper::SolarMutex> >::_M_ptr() const (this=0x10)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:173
        1  0x00007f76f7e4ade5 in std::unique_ptr<comphelper::SolarMutex, std::default_delete<comphelper::SolarMutex> >::get() const (this=0x10)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:422
        2  0x00007f76f7e07249 in SalInstance::GetYieldMutex() (this=0x0) at vcl/source/app/salvtables.cxx:145
        3  0x00007f76f7ed92ee in Application::GetSolarMutex() () at vcl/source/app/svapp.cxx:576
        4  0x00007f76f97f4b29 in SolarMutexGuard::SolarMutexGuard() (this=0x7ffd84f3b080) at include/vcl/svapp.hxx:1368
        5  0x00007f76f98161a0 in VCLXDevice::~VCLXDevice() (this=0x724c050) at toolkit/source/awt/vclxdevice.cxx:44
        6  0x00007f76f98f19d4 in cppu::ImplInheritanceHelper<VCLXDevice, com::sun::star::awt::XWindow2, com::sun::star::awt::XVclWindowPeer, com::sun::star::awt::XLayoutConstrains, com::sun::star::awt::XView, com::sun::star::awt::XDockableWindow, com::sun::star::accessibility::XAccessible, com::sun::star::lang::XEventListener, com::sun::star::beans::XPropertySetInfo, com::sun::star::awt::XStyleSettingsSupplier>::~ImplInheritanceHelper() (this=0x724c050) at include/cppuhelper/implbase.hxx:155
        7  0x00007f76f98cc28f in VCLXWindow::~VCLXWindow() (this=0x724c050) at toolkit/source/awt/vclxwindow.cxx:336
        8  0x00007f76f980a6bd in VCLXContainer::~VCLXContainer() (this=0x724c040) at toolkit/source/awt/vclxcontainer.cxx:45
        9  0x00007f76f980a719 in VCLXContainer::~VCLXContainer() (this=0x724c040) at toolkit/source/awt/vclxcontainer.cxx:44
        10 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x724c050) at cppuhelper/source/weak.cxx:230
        11 0x00007f76f980d1e9 in VCLXContainer::release() (this=0x724c040) at toolkit/inc/awt/vclxcontainer.hxx:39
        12 0x00007f76e49080ae in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference() (this=0x8fa9710) at include/com/sun/star/uno/Reference.hxx:114
        13 0x00007f76e4921486 in SwAccessibleDocumentBase::~SwAccessibleDocumentBase() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:77
        14 0x00007f76e4923d1c in SwAccessibleDocument::~SwAccessibleDocument() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:374
        15 0x00007f76e4923d89 in SwAccessibleDocument::~SwAccessibleDocument() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:370
        16 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x8fa9620) at cppuhelper/source/weak.cxx:230
        17 0x00007f76e490a325 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleContext3, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::lang::XServiceInfo>::release() (this=0x8fa9620) at include/cppuhelper/implbase.hxx:115
        18 0x00007f76e4928495 in SwAccessibleDocument::release() (this=0x8fa9620) at sw/source/core/access/accdoc.hxx:139
        19 0x00007f76ee91c11e in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() (this=0x9012828) at include/com/sun/star/uno/Reference.hxx:114
        20 0x00007f76ee9391a9 in __gnu_cxx::new_allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> >::destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (this=0x8c9a8f8, __p=0x9012828) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:168
        21 0x00007f76ee9390ed in std::allocator_traits<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> >&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*)
           (__a=..., __p=0x9012828) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:535
        22 0x00007f76ee9390ba in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::_M_deallocate_node(std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true>*) (this=0x8c9a8f8, __n=0x9012820)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable_policy.h:1894
        23 0x00007f76ee939035 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::_M_deallocate_nodes(std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true>*) (this=0x8c9a8f8, __n=0x0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable_policy.h:1916
        24 0x00007f76ee938f56 in std::_Hashtable<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Identity, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::clear() (this=0x8c9a8f8)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable.h:2320
        25 0x00007f76ee938ed9 in std::_Hashtable<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Identity, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::~_Hashtable() (this=0x8c9a8f8)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable.h:1532
        26 0x00007f76ee938e95 in std::__cxx1998::unordered_set<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~unordered_set() (this=0x8c9a8f8)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unordered_set.h:97
        27 0x00007f76ee938e6d in std::__debug::unordered_set<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~unordered_set() (this=0x8c9a8d0)
           at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/debug/unordered_set:190
        28 0x00007f76ee9360fb in DocumentFocusListener::~DocumentFocusListener() (this=0x8c9a8a0) at vcl/inc/unx/gtk/gtkdata.hxx:221
        29 0x00007f76ee936129 in DocumentFocusListener::~DocumentFocusListener() (this=0x8c9a8a0) at vcl/inc/unx/gtk/gtkdata.hxx:221
        30 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x8c9a8a0) at cppuhelper/source/weak.cxx:230
        -Type <RET> for more, q to quit, c to continue without paging--
        31 0x00007f76ee920fb5 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x8c9a8a0) at include/cppuhelper/implbase.hxx:115
        32 0x00007f76ee9716ba in rtl::Reference<DocumentFocusListener>::~Reference() (this=0x1da9788) at include/rtl/ref.hxx:129
        33 0x00007f76ee96f259 in GtkSalData::~GtkSalData() (this=0x1da9730) at vcl/unx/gtk3/gtkdata.cxx:372
        34 0x00007f76ee96f309 in GtkSalData::~GtkSalData() (this=0x1da9730) at vcl/unx/gtk3/gtkdata.cxx:356
        35 0x00007f76f7efc79c in DeInitVCL() () at vcl/source/app/svmain.cxx:609
        36 0x00007f76f7efacaa in ImplSVMain() () at vcl/source/app/svmain.cxx:227
        37 0x00007f76f7efc839 in SVMain() () at vcl/source/app/svmain.cxx:234
        38 0x00007f7700ece163 in soffice_main() () at desktop/source/app/sofficemain.cxx:94
        39 0x00000000004008dd in sal_main () at desktop/source/app/main.c:51
        40 0x00000000004008b7 in main (argc=3, argv=0x7ffd84f3ba48) at desktop/source/app/main.c:49
        
        Change-Id: Id4ac45bdab96b5afb7e9c18570ef4da4a81eca1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136666
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [3a9d36d49d1fc7bd0b461d0ef1d1cc5a6c3a76dd]

        qt a11y: Only return actually supported a11y interfaces
        
        Let `QtAccessibleWidget::interface_cast` only
        return a pointer to self if the underlying accessible
        (`m_xAccessible`)'s context implements the `XAccessible...`
        interface needed to have the corresponding `QAccessible...Interface`
        methods do anything useful (s.a. the checks at the beginning of
        the implementations of the corresponding
        `QAccessible...Interface` methods).
        
        This way, the other interfaces (or their AT-SPI equivalents)
        are no longer advertised as supported.
        (See the corresponding handling of the "GetInterfaces"
        AT-SPI method inside of the Qt library [1].)
        
        While at it, also add/adjust the comments indicating what
        methods override those from `QAccessibleTable{,Cell}Interface`.
        
        I ran into this when clicking through the LO a11y hierarchy
        in the Accerciser tree view and seeing the following warning
        in the terminal from which I had started Accerciser, after
        clicking on an item that was in no way related to any table
        in the first place:
        
        > (accerciser:192270): dbind-WARNING **: 14:05:51.582: atspi_dbus_get_property: expected a variant when fetching Caption from interface org.a11y.atspi.Table; got (so)
        
        With this change in place, unsupported interfaces are
        grayed out in Accerciser's "Interface Viewer" as
        expected, rather than being shown as active, but not
        displaying any useful data.
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?h=6.3.0#n1408
        
        Change-Id: I1edbd451514253392e6b0a9caa6ffef2f789b55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136782
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [1a8132515babca53b1f1a464236e05f780cbfef3]

        tdf#149816 qt a11y: Report position in screen coordinates
        
        `QAccessibleInterface::rect()` is supposed to report the
        geometry in screen coordinates [1].
        `XAccessibleComponent::getLocationOnScreen` returns the
        position in screen coordinates, so use that instead
        of `XAccessibleComponent::getLocation`, which returns the
        position relative to the parent.
        
        With this in place, Accerciser correctly highlights
        the area of the item curently selected in its treeview
        of the LO a11y hierarchy.
        
        [1] https://doc.qt.io/qt-6/qaccessibleinterface.html#rect
        
        Change-Id: Iefb1e8792cd3ee720feafc81744e5e6ed6a949c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136781
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [64f4777d175026de6594eae48ec59fa3d5bb272c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8fc940edb19bef35a99ff891ba41357b3d367905
          - Typos
            
            Change-Id: I6d70cc7d010d09605565c0f24e5a349d08dd4291
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136754
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [05e037a9f104bba0749bd3c75d36ba581ea663cf]

        fix --enable-macosx-sandbox build
        
        after
            commit eecc113e6f6e51e5e37059235c1069dc9c4c1cc8
            Date:   Sat May 21 08:30:29 2022 +0200
            rtl_String->OString in sal
        
        Change-Id: I1b71858ae39ae3551a281b0fa5c47652f5bc1b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b73edefe21c6f70e49edba5e198dd1345d6df96]

        CppunitTest_chart2_xshape: reenable disabled tests
        
        Change-Id: I31e7bec5e4c7c7584b0c93522477416178500227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136739
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [b170210ddf1cf45fbfbce2e4213330bd036162f0]

        sc: remove CppunitTest_sc_chart_regression_test
        
        it only contains one test and it does the same as
        CppunitTest_chart2_xshape, so just move the test there.
        I don't know whether ScChartRegressionTest::test was ever
        executed but the reference needs to be adapted
        
        Change-Id: I0447054d8692901c72a36be5f582723334d2acba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136737
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-02  Stephan Bergmann  <sbergman@redhat.com>  [870452546a56ce635f36247c44aee6068d70c053]

        Use some more O3TL_UNREACHABLE
        
        Change-Id: I42401a5ba68e6e0d5b99fae4adbea01cd5fa1600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136778
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-02  Michael Weghorn  <m.weghorn@posteo.de>  [169ff786a6694ab412d53c911550db101fb50876]

        tdf#149804 Set newly introduced list box colors from system colors
        
            commit 3c6a53b9ce64180b2a03e097c1844f7496f26815
            Date:   Sat Apr 17 14:49:43 2021 +0200
        
                improve the look of the macOS combobox
        
        had introduced separate style colors to be used for list/combo boxes,
        but since those new colors were not set explicitly for gtk3,
        qt5/qt6 and Windows, this resulted in style/theme/system colors no longer
        being used, but only the default colors introduced in above
        commit.
        
        This sets the style/theme/system colors for qt5/qt6, gtk3 and
        Windows as well, using the same values that were used
        previously.
        
        Change-Id: I31401af38b991e7e0cdc436b894ee0f491a22752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136735
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [e01fc6d7c1353ed2df4d8fcc06bd3b335e89fa04]

        Add generated lo.xcent to .gitignore
        
        (recently introduced in c78b49ec132eb5126445ebee7d259d3df7fcaa68 "don't specify
        entitlements that are not used (sdremote w/o bluetooth)")
        
        Change-Id: Ied7db52d891e92224bc2be0ad1277f40e5d80b3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136752
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [17217a93418c9a5233eecd9491a7c4269d15057f]

        Use some more O3TL_UNREACHABLE
        
        Change-Id: Ibcf1b1de7b43460266e99fc9f27c1de0b510a361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136779
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [8895dc3c4cb3e3fafcde1d0243dd683e7283b805]

        Use some more O3TL_UNREACHABLE
        
        Change-Id: I5885c1f33fe7d15e6bd0b572b6d0db1410252362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136777
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [e37e1a7d2007bd6896027b69271774da2568e6f8]

        external/libnumbertext: Silence -Werror,-Wdeprecated-declarations
        
        ...as seen now with LLVM 15 trunk libc++, which marks the std::codecvt_utf8 and
        std::wstring_convert functionality, deprecated since C++17, as such
        (<https://github.com/llvm/llvm-project/commit/3ee9a50a146c585fc92f79e742c538261f98bd4e>
        "[libc++] Implement P0618R0 (Deprecating <codecvt>)")
        
        Change-Id: Id34e3fea540b76591ead8ba3df4c31a71d7b4aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136776
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [9e2dbeea9f680f2d3d1611167820c197ce8a9685]

        Adapt to LLVM 15 trunk clang::StringLiteral::isAscii rename
        
        <https://github.com/llvm/llvm-project/commit/a9a60f20e6cc80855864b8f559073bc31f34554b>
        "[Clang] Rename StringLiteral::isAscii() => isOrdinary() [NFC]"
        
        Change-Id: Iac293c19bd135a94dcc3a3ef9f252ca6175c959a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136744
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-07-01  Alain Romedenne  <alain.romedenne@libreoffice.org>  [7a89eae97a970939174d59aa58147eaa194acaee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9d5f04452ea8747348da648212681b4ec46ee15
          - tdf#148611 Base help page link is missing or incorrect
            
            Change-Id: Id835c0348887c8eba290ba8693230d1002e15c91
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136652
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-07-01  László Németh  <nemeth@numbertext.org>  [db1f4457543918b5e3cd8b4d3a70676855952314]

        tdf#149709 sw_redlinenum: fix list levels
        
        Levels of ORIGTEXT SwNodeNum weren't updated,
        resulting bad numbering of multilevel lists during
        editing and file import.
        
        Follow-up to commit d0e49c07203c9ae33c5dfa1855b2b8909c3e16dc
        "tdf#115524 sw_redlinenum: show original numbering of insertions".
        
        Change-Id: I478971643a10b2007f37a4f0074067896d546228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136734
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-07-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [c62587987f2046b3b4b22af3d9897dd17077d5a8]

        tdf#149787: sd: Add unittest
        
        Change-Id: I27ec82fb8942f8cf6d663ae358ef29a2f6fa940f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136726
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-07-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [e6fcee376f45c6701ef74c9e62aa1d6aa932cef3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6e98a37ec8cd0adc8219466555b200bd3b9af8b
          - Document the new UnitTest service of the ScriptForge library
            
            This patch also updates the sbasic.tree to include the Region and UnitTest services. I also moved the ScriptForge library so that it appears right below the Advanced Basic Libraries (previously it was inside this section).
            
            Change-Id: I7dfd9080dcd3212d2b53f88480087d48f5dec60c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136548
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-07-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c2775bbab1885ce6980021153267e97d8ca89682]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3569af3cc1cffcf14ff13273f422b99d652b9c39
          - tdf#120550,tdf#121367 followup to add or correct links
            
            Change-Id: Iee88c2927b5750d57dec1cfffee4d27bf860b834
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136645
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-07-01  Justin Luth  <jluth@mail.com>  [ed7a788dd916bd8786adb2d146ce543a727ce727]

        tdf#126395 writerfilter: don't guess table direction
        
        Wihtout specifying a direction, TextToTable is going
        to guess. Well, import isn't a guessing game,
        and there is a default value for something unspecified.
        
        Perhaps specifying LR_TB would be better,
        but we'll try with CONTEXT first,
        since it is a LO default.
        
        Existing unit tests (not affected)
        Both ooxmlexport and rtfexport have a table-rtf test
        which ensure bidiVisual is properly applied to tables.
        
        Change-Id: I1cabf518937e57dd757aca75ae5d2527c61fa736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136673
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [779489ca5ad11476b39555d7b3169d320ff89d4b]

        tdf#137544 reserve space in polygon
        
        Change-Id: I868584965b122735b8eb55cc17a3ee11a772b88a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-01  Miklos Vajna  <vmiklos@collabora.com>  [3f379f00b17268fbb63ba072d04336acb0c7e398]

        sw content controls: link ODF proposal
        
        Change-Id: I18a62cce01eb8a5cc1764ee813a9265cb02c5fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136736
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-01  Stephan Bergmann  <sbergman@redhat.com>  [94be87df833772dcaf7e96659af78b5fa355c966]

        Use stable_sort for m_vBookmarks
        
        Using a randomizing debug-mode libc++ (`export LIBCPP_DEBUG=-D_LIBCPP_DEBUG=1`
        in config_host.mk), where (among other things) the elements of a range passed to
        std::sort are randomly shuffled before being sorted, thus simulating a std::sort
        that actually behaves non-deterministically compared to std::stable_sort:
        
        CppunitTest_sw_uiwriter5 consistently failed for me with
        
        > uiwriter5.cxx:255:Assertion
        > Test name: testTdf140982::TestBody
        > assertion failed
        > - Expression: aType != "AnnotationEnd" || !bAnnotationStart
        
        when _LIBCPP_DEBUG_RANDOMIZE_UNSPECIFIED_STABILITY_SEED is 140384686472728.
        
        Dumping the contents of xRunEnum in testTdf140982
        (sw/qa/extras/uiwriter/uiwriter5.cxx), that randomized run has
        
        > Text "Lorem "
        > Redline IsStart=true
        > Annotation
        > Text "ipsum"
        > Redline IsStart=false
        > Redline IsStart=true
        > Annotation
        > AnnotationEnd <= the CPPUNIT_ASSERT failed here
        > Redline IsStart=false
        > Redline IsStart=true
        > Text " "
        > Annotation
        > Text "dolor"
        > Redline IsStart=false
        > Redline IsStart=true
        > AnnotationEnd
        > Redline IsStart=false
        > Redline IsStart=true
        > Text " "
        > Annotation
        > Text "sit"
        > Redline IsStart=false
        > Redline IsStart=true
        > AnnotationEnd
        > Redline IsStart=false
        > Text " amet"
        > Redline IsStart=true
        > AnnotationEnd
        > Redline IsStart=false
        > Text "..."
        
        whereas a stable_sort run would have
        
        > Text "Lorem "
        > RedLine IsStart=true
        > Annotation
        > Annotation
        > Text "ipsum"
        > RedLine IsStart=false
        > RedLine IsStart=true
        > AnnotationEnd
        > RedLine IsStart=false
        > RedLine IsStart=true
        > Text " "
        > Annotation
        > Text "dolor"
        > RedLine IsStart=false
        > RedLine IsStart=true
        > AnnotationEnd
        > RedLine IsStart=false
        > RedLine IsStart=true
        > Text " "
        > Annotation
        > Text "sit"
        > RedLine IsStart=false
        > RedLine IsStart=true
        > AnnotationEnd
        > RedLine IsStart=false
        > Text " amet"
        > RedLine IsStart=true
        > AnnotationEnd
        > RedLine IsStart=false
        > Text "..."
        
        which suspiciously has the Annotation tokens at different positions relative to
        the Text tokens, so something looks indeed broken.
        
        And when dumping (via ToString()) the content of m_vBookmarks in
        MarkManager::sortSubsetMarks (sw/source/core/doc/docbm.cxx; which is apparently
        called multiple times during that test) before and after sorting, there are
        often cases where multiple elements have the same node and index, so are placed
        into the same equivalence class by lcl_MarkOrderingByStart (assuming there are
        no sw::mark::CrossRefBookmark instances involved in this test, for which
        lcl_MarkOrderingByStart has special rules).
        
        I'm not exactly sure whether this use of stable_sort is indeed the right fix or
        just a workaround, and the real issue is that the equivalence classes of
        lcl_MarkOrderingByStart are too broad, or something entirely different yet.  I'm
        also not sure whether similar uses of sort in MarkManager::sortSubsetMarks and
        MarkManager::sortMarks would also need to be changed to stable_sort.  (At least,
        I didn't find any breakage with my randomizing debug-mode libc++ and `make
        check` that would point to one of those other non-stable sort calls.)
        
        Change-Id: I51040e43b906bd3f18219d3bd0d28e1ccee89897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136717
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-01  Miklos Vajna  <vmiklos@collabora.com>  [c769c369c87a46ec877b7eefee27988044a2798f]

        sw content controls: fix picture placeholders
        
        This went wrong in commit c321498f915f4e8b3f4853232860ce040ab48e46 (sw
        content controls: reject typing inside checkbox or picture content
        controls, 2022-06-10), now a freshly inserted picture content control is
        not replaced with an image on click.
        
        The problem is that we want to forbid typing into a picture content
        control (it should only host a single as-char image), but changing the
        picture's bitmap is meant to be still possible.
        
        Fix the problem by allowing SID_CHANGE_PICTURE even if the cursor is
        protected: this allows changing the picture again, and a real read-only
        document still doesn't show the "change" menu item in its context menu.
        
        If we later find some other corner-case where this command should be
        still disabled, we can extend SwGrfShell::GetAttrState(), similar to how
        e.g. inserting images in input fields is disabled there.
        
        Change-Id: I8b55e930330b9748ecda950dedae907b86c57e2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136729
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-01  Pedro Pinto Silva  <pedro.silva@collabora.com>  [5ced993524305bad3c8f6637639e133f423cd285]

        tdf#138748 Correct label locale group in CSV dialog
        
        The second group in the dialog is about the "Locale"
        and it was wrongly named "Language"
        
        Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
        Change-Id: Ie140c6af4560300261f816d0eb73dd451a2c5376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136724
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-07-01  Pedro Pinto Silva  <pedro.silva@collabora.com>  [05b80bc0cc082dd571bebbbc2de97e8de7499e86]

        tdf#138748 Correct group label in HTML import dialog
        
        Use "Locale" as a label instead of "Language" for locale
        options
        
        Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
        Change-Id: Ic7edd5108a59cf1be1062b3709cb80a84606fe82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136725
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [2fe50b2f11e2236ae7145fd633ad93342f5a0f6c]

        tdf#137544 ReformatAllEdgeObjects use recursion
        
        rather than SdrObjListIter, which wants to build a vector of all the
        child objects, of which there are a great many
        
        Change-Id: If6a4213b94e2ef2133100e406fb435b82944ac18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [78fece3619e986ae0e4a41594965af83214f7da8]

        small optimisation
        
        Change-Id: I10d18eddf0dfa96d468c8cfab22494779e38358f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-01  Miklos Vajna  <vmiklos@collabora.com>  [48010539f695bc269034f12cf72aa0665cca10de]

        sw content controls, dropdown: use DecorationView for the button's arrow
        
        Instead of drawing manually, which was the way form field dropdowns did
        it. Also enable anti-aliasing.
        
        Change-Id: Ia1ab5fe6168e0fb51dba3c760301764cfd1e0514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136692
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [46869037d0fee5601815f3e8ff12764564ae3489]

        small optimisation
        
        in a very hot spot
        
        Change-Id: I2115fb23e217de7cdd84f7301acd3a27829f3298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136660
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-01  Kurt Nordback  <kurt.nordback@protonmail.com>  [ec31df481568f6a654e5f6c1d597dc8b963b99e6]

        tdf#56580 Fix negative error bars on log chart
        
        This is a bug in the rendering of negative error bars on log charts,
        when the error bar size is greater than the chart value. This is
        numerically invalid, since it leads to taking the logarithm of a
        non-positive value.
        - Add a test for this condition, and turn off the negative error bar
          when the condition is met.
        
        Change-Id: If84823c27d68976d3515581b1f913d78d683f446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135106
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-07-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [184a45c4176d96bf799a8f8a0fba290a8c851948]

        tdf#149603 macOS: fix workaround to use web help if Safari is the default browser
        
        Safari won't access the local helpfiles from LO's app folder unless you
        enable Safari's webdeveloper menu. The workaround broke since
        f31f0038f5fd9254584a06665066faf9715d1cd8 switched from window to widget
        references and hence using a different codepath, skipping the workaround
        added in 44893662d510c4173e55ba27af02d0258a697a5d
        
        Change-Id: I0c59066fe1cef1514c6595e0439d31d3e60e02f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136685
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-07-01  Mike Kaganski  <mike.kaganski@collabora.com>  [010d420acc5b43b68458d0289b45c718deb8ca2f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6e77989ceace3a02684d5af35ed9f89712cc524d
          - A typo
            
            Change-Id: Ia66600bae81940747ec703b7c0d4b358cb88cb48
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136703
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-07-01  Miklos Vajna  <vmiklos@collabora.com>  [aad1bc31afd6a4186684a7801caab2ea21fd333a]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I8b4c7b88232532cbcffc0424b1ca40a809098eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136683
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fe18ba1b0be041f66124324e96d9cb6d56ff5ce]

        tdf#137544 reduce cost of dynamic_cast
        
        casting to TextElement is very hot here
        
        Change-Id: I3195da6f09edb270eebdc6f38a1bbb2405b74de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136659
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-07-01  Michael Weghorn  <m.weghorn@posteo.de>  [ee3976f2c613f9015477ab327996c074e8516f9d]

        tdf#149680 qt: Open native popup menu at given position
        
        Calculate the position at which to open the popup
        menu from the passed window and rectangle, rather
        than always opening the native popup menu at the
        cursor position.
        
        The commit message in
        
            commit 1e0b16f8695498e4eea7c2208aabf7e7664ce749
            Date:   Wed Feb 12 08:07:42 2020 +0100
        
                tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenus
        
        which had implemented native poup menus, already said:
        
        > For now, this always shows the popup menu at cursor position, which
        > can be changed by taking the Rectangle passed to
        > 'Qt5Menu::ShowNativePopupMenu' into account if there should be any
        > need.
        
        Change-Id: If1a44b6d53f3dcd6fa7ceec0738219f11cfc22c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136356
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-07-01  Eike Rathke  <erack@redhat.com>  [db00c13579a94dd256a01e76ef230cde342f30db]

        ChangeNullDate: assert valid date after normalization if it wasn't before
        
        ... and abort if not. Also take over only valid values.
        
        This might pop up more crashtest import failures that would need
        fixes similar to commit 7ca3eca66888a1fa1b7bd59d79bb8f4c96bd7460.
        
        Change-Id: I217204378374a1a598b5a3ff3c9c6728f112af70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136688
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-01  Eike Rathke  <erack@redhat.com>  [216b33b8eaf144f438f87b7a35e35d04baf943bd]

        Use DateTime::operator=(const css::util::DateTime&)
        
        ... instead of separated Date and Time constructions.
        
        Change-Id: I712187e41a18fe9ccbe467e9f2da3ac41693cbbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136687
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-07-01  Eike Rathke  <erack@redhat.com>  [d031accf712cde8f664828ec4547bf6a4661860f]

        Check sax::Converter::parseDateTime() success return value
        
        Change-Id: Ia843a1437a8c97e2dafc3f22d43a3dc61873269b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136686
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-30  Eike Rathke  <erack@redhat.com>  [8480e15f854cfc0a6b99a6b28f794465d0fb8253]

        Ignoring invalid NullDate is worth a warning
        
        Change-Id: Ie29151ab17b947561c96512e5128edbfdeaa226b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136662
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-30  Henry Castro  <hcastro@collabora.com>  [965cb44506c3ff182203d49d06b96beb6194f707]

        sfx2: replace pImpl -> m_pImpl
        
        Class SfxFrame
        
        Signed-off-by: Henry Castro <hcastro@collabora.com>
        Change-Id: Iad58908e76f3d9891816a9c8dad3d37aa6630722
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136684
        Tested-by: Jenkins

2022-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [59cf9a433e1ea74ccdb1abe080511353a6c0af08]

        tdf#149785: sd_import_tests2: Add unittest
        
        Change-Id: I8d11508adc999381a119da26a5cf438072c8aff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136672
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6f1659fa2be14f830fb4a8264b70420df22f7e0]

        tdf#137544 elide some UNO_QUERY
        
        Change-Id: I58b5a800d2f24168c9d1c109769344a00dea8e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Caolán McNamara  <caolanm@redhat.com>  [27ad7de6a9a8a019a0138179685268fc52e010d0]

        tdf#149787 capture a copy of mpViewShell and mpView
        
        so the callback can outlive the FuArea
        
        Change-Id: I392ffa46b6f13795faef7284c1cae74428655b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136679
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d84ac1cd25022be13bd0c3f831f24b8edfee75d]

        tdf#147199: sw_uiwriter3: Add unittest
        
        Change-Id: I86fa740fd69e14afcb2effaa091db2b22477a7cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136680
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f9fd6806ccfbf381a383efe5d143ead86ee49de]

        tdf#137544 reduce cost of ChildrenManagerImpl::Update
        
        there are 2 O(n^2) algorithms here, reduce them to O(n log n) by
        pre-sorting
        
        Change-Id: Ib3912155cda62cac95b5037528e23ef3c686a7e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [e64e4e373e43e9490dda4b778424dbef6d6f1299]

        tdf#149785 Read Error importing document
        
        after
            commit 04073c5fedd33654f242fecb7e39afb07cf0e273
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 21 13:17:09 2022 +0200
            replace oox::OptValue with std::optional
        
        and add a SAL_WARN to make this easier to diagnose in the future
        
        Change-Id: Ia5be0b82e3a5df34f50bc8a2decb1de98e0c5556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136665
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Mahdi Tizabi  <m.m.mozaffart@gmail.com>  [5cbbbe559ea37b10f276b5a6231c9cc26f8bee12]

        tdf#143148 Use pragma once in vcl part
        
        Change-Id: Idf48a2ee9909abb7817b37a546b5a94b13324068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136437
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-06-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [478154f172630fee5467be03f099a11427173166]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 11ed377dcb076aba37adfb200c1f3c01f4f2d920
          - some improvements to Writer Table toolbar and Table Format
            
               swriter/main0204.xhp (Table toolbar)
               * put commands (already found in help page) in same
                 order as toolbar (several commands still missing)
               - remove "Insert Table", because not found in toolbar
               * use new embed for "Table Properties"
               * rename German id
               * refactor to <h1>,<h2>
            
               swriter/01/05090000.xhp (Table Properties)
               * "Format" -> "Properties"
               * remove one German id and rename another
               * update howto embed to include icon
               * correction "Area" -> "Background" and add appropriate description
            
               swriter/00/00000405.xhp  (Format menu)
               + add icon for "Table Properties", with relevant section labels
            
            Change-Id: I28e2cb15109317e355187c04b34719d01d2d9a68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136648
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [2c80d2671659b6873f51e3224d06b9c9bfb5754f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 614feb3f2bc5f5c994dc6898b5af83f928a8b8f3
          - tdf#149638 (partial) add Table bar to Contents for Draw and Impress
            
               Also put toolbars in Draw and Impress contents in alphabetical order
               Refactor shared Table Bar to <h1>,<h2>, 1cm icon
            
            Change-Id: I2a1ae72c3c940a94e6f81d0a4374d211600d9451
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136649
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [edfd0202aca4177490a9cb6b707bc47218eed4c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4b84d252a9a17f0428ac4c7c555b4df92a54306a
          - Document the new Region service in ScriptForge
            
            Change-Id: Ic7869d6c21fdcbbd3a2a9631647d115654adf889
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136388
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-30  Szymon Kłos  <szymon.klos@collabora.com>  [eba47de3dc43fe249b7e53391a5c772c79961d4e]

        lok: fix position for cell item list dropdown
        
        Change-Id: I911199970d8c01fcf0767b974936d077f48fc89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136604
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-06-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [8f16718731ee47535a62e61af99b43a09626c65f]

        vcl: clarify variable in Animation::Animation() loop
        
        Change-Id: Ia7e211298896c40b92cf13c81302d30ddb661cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76404
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-30  m.hashemian  <mr.hashemian2000@gmail.com>  [3258bfd178749fd3deb06d852389554c69299c1e]

        tdf#132293 remove unused imports and unused variables in sw
        
        Change-Id: I00ae07a9d02e834de34f8dd7a7f53f0c68490832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136627
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-30  Miklos Vajna  <vmiklos@collabora.com>  [a4a6680718e2cbc6c471894ed9d3b729504002b7]

        lingucomponent: avoid 'using namespace' in a header file
        
        Because that would pollute the global namespace in any cxx file
        including this header.
        
        Change-Id: Ida324d125114ae03d8868842b881e3b94af62bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136631
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae27500eaf5cd7e0800cfc5d584809dc4e1739cb]

        tdf#137544 only construct SdAnimationInfo when we need it
        
        Change-Id: I15377a0f32bf4554c8feddc6c6c967002de9dd9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [333e24b347293503f1c3abf8871769191b0c751d]

        tdf#137544 slightly improve perf of pdf parsing
        
        Change-Id: I05af862137666606e557dc3fabe1c3ea249ee10a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e7edc8c3620e4f733c1974a288e5a5abd29f87e]

        tdf#137544 std::unordered_set is cheaper here
        
        when the number of on screen elements becomes rather large
        
        Change-Id: I5185c2d23db733c1587eb78108f69f31e20bd913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136661
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-30  Hannah Meeks  <hmeeks4135@gmail.com>  [cb41db23a044e6e6337bad642aad2c49174aa068]

        tdf#99514 - implement Value2 for compatibility
        
        Value2 ignores date formatting in a way that Value does not.
        Extended vba.xls to test this too.
        
        Change-Id: Id75a3dafae2166221731847b7c81e93e8ad835fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133645
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-30  Eike Rathke  <erack@redhat.com>  [7ca3eca66888a1fa1b7bd59d79bb8f4c96bd7460]

        crashtesting: assert on reexport to ods of forum-it-7248.ods
        
        source document available from:
        https://forum.openoffice.org/it/forum/download/file.php?id=7248
        
        The actual cause is already a bad
        
                <table:null-date table:date-value="0000-00-00"/>
        
        imported unchecked. For this, sax::Converter::parseDateTime()
        returns a success value, just use it..
        If bad keep the default NullDate.
        
        Change-Id: If4caa57e302cfe8304e6cb49bf9d330245a97660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136611
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-30  Justin Luth  <justin.luth@collabora.com>  [a7e0a5a6d0054483d3ed5a753bbba2e8ab599e90]

        tdf#131304 .doc: provide compatibilityMode value for .docx
        
        In case a .doc file will be exported as a .docx format,
        populate the appropriate compatibilityMode setting.
        
        11: Use features specified in MS-DOC.
        
        Change-Id: I5c03d2f7aed9d5fa2577853908d05d88ddf4c122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90437
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-30  Justin Luth  <jluth@mail.com>  [fcbd1e8363f14fcbdcef9bb2a6bca8a2cb7644ac]

        tdf#tdf#93747 tdf#145151 sw IsTableMode: revert obsolete one-offs
        
        I started playing whack-a-mole, patching functions for
        excessively selected cells. But now bug 145151 has fixed
        the selection process itself, so these avoidance clauses
        are now obsolete, so revert these 7.3 or 7.4 fixes.
        
        This keeps the unit tests in
        make CppunitTest_sw_uiwriter5
        
        Change-Id: Ie7848b483d495d79c046b9f4293b605d2edea658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136578
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [eefba50f5908d535bce81b5b0d3d883715b6575e]

        tdf#137544 reduce work in sdext::PageElement::resolveUnderlines
        
        when opening complex pdf
        
        Change-Id: I67146a60d016964c96a3994c5a0334287f7bab0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [9586d734c22e8650d0a060ec23d0bee6444d8bdb]

        simplify iterator manipulation
        
        Change-Id: I549947ad9ab93ed02049f7be5afad6be5ed69a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1ed54948ea3ffb43092d1748c1b6b53ce42fd3d]

        ChildrenManagerImpl::GetChildShape was clearly written very late at night
        
        Because it takes something that could be looked up by index, and instead
        looks it up by scanning an entire vector.
        
        been this way since
            commit 60f11adb950e4f9645cc9ecb0f5af8235cc97366
            Date:   Wed Nov 27 13:03:45 2013 +0000
            Integrate branch of IAccessible2
        
        Change-Id: I32d06a98a6fa074c8f6385611e12e1a64d5b7f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ee013bd6af5acb6a12f596a7b32e12cb42755efb]

        Fix typos
        
        Change-Id: Ifcefc082a007ebae2c44cccc15a475d73b6bf64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136628
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-29  Gabor Kelemen  <kelemeng@gnome.hu>  [643718d1ba48b16a4b180fbd8b0d45390b6a2554]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f962040984c92627f0fdca608c9f23877cd5c92d
          - tdf#98404 Document new shortcuts for Move slide commands
            
            Change-Id: Ibc2b560ac6cfe59d501e6a224c0143507c53ea68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136586
            Tested-by: Jenkins
            Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
            
2022-06-29  Caolán McNamara  <caolanm@redhat.com>  [6f064418f5ce5bbc80bedbdf86fb4254369a956e]

        crashtesting: assert seen on loading forum-de3-8113.ods
        
        This doc is available from https://de.openoffice.info/download/file.php?id=8113
        
        /* TODO: replace by a simple rRecursionHelper.EndIteration() call
         * if the assertions hold. */
        const bool bOnlyThis = (rRecursionHelper.GetList().size() == 1);
        assert(bOnlyThis);
        
        lets assume here that the assertion doesn't hold so drop the TODO
        and speculative assert from:
        
        commit ce8a7278e1304f7aaa65bce34aeeda5e83b231f1
        Date:   Tue Oct 5 20:04:19 2021 +0200
        
            Fix crash if conditional format triggers recursion with iterations enabled
        
        Change-Id: I9030e749b272e2bb0b1ce850e6295a3cd2a11915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136610
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b43f0b0295953c8d5d16c5b9eccaddb5ec214bab]

        allow to specify a macOS provisioning profile
        
        having one is one of the prerequisites of using TestFlight
        
        Change-Id: I9e20eb99905071fade4179dfbe2da5b7e5dd1c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136618
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d121e7cdd408fa5afb73b16466df42baa52b6a1a]

        only hide Impress Remote option if there is no sdremote at all
        
        it was incorrectly based on bluetooth support, but the remote can also
        be used in the local network.
        Regression from 4cdb960a79aff565f956f618116f3ea4b3836aa4 still worked
        for users who had it enabled in earlier versions, but not with new
        profiles.
        
        Change-Id: Ib4026c60fed0842b3bad483d78e46dd73d1d75f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136615
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5ebbb4e2b27d3fda6af410a553a196376d92034c]

        related tdf#126961 don't crash when access to the macOS address book is denied
        
        quick'n'dirty fix, ideally the user should get a message to reset the
        privacy setting and try again...
        
        Change-Id: I51cb852e305e285c87ff3a0e15b5198a2b1c5970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136620
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c78b49ec132eb5126445ebee7d259d3df7fcaa68]

        don't specify entitlements that are not used (sdremote w/o bluetooth)
        
        the network.server entitlement is only needed when the sdremote is
        enabled, and the bluetooth one only when the bluetooth part is built.
        Also warn about bluetooth not being built because of obsoleted/removed
        API. It was "silently" dropped before (lost in the flood of configure
        output).
        
        Change-Id: I38d83aa1132307b5b4b5d6dceba8f9020ffb2373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136617
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d1739c8c735bcf890167c63b5559f2610e5a017a]

        tdf#126961 fix access to the macOS address book
        
        Having the personal-information.addressbook entitlement is not enough.
        Without the plist key NSContactsUsageDescription, macOS will not ask the
        user to grant access and the request is implicitly denied without any
        feedback/logging.
        
        Change-Id: I954fa86b35a128f08e5c498191bc0949e0edeebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136619
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c33ba7c52a031e8e0f1510d32ed4c33954fe5a39]

        impress remote connection dialog must also work without bluetooth
        
        as otherwise you can never confirm the pin to approve new devices.
        old regression from 7c8c73dd5cf84050a8a2c51b04d7f5278b409fd7
        still worked for users who had it enabled/linked in a previous
        version...
        
        Change-Id: Icf9fb6ae4259252da47c3709ab99fb7a2a70aeac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136616
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [788dcbef1bae7dbe600f8f193944cd9b31aa27d5]

        Don't link against private CoreUI framework when sandboxed
        
        Actual use of the code was already disabled since 2014 with
        b8bee05dbf85bc4f5834520aa5d64e9ae18aba4e - but the link flags were not
        conditionalized.
        
        Change-Id: Ia1dd299cb78274850eb6a7b10259991bb4970ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136614
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c1af51b8fc98793bee156ccfa6d91ff5983226c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b6a8105c3ceb14f1216a12dbbe4b191acc0b99f3
          - tdf#120550,tdf#121367 update row and column resizing in tables
            
              This patch is a general review and update of commands to
              optimize the size of tables in Writer, Draw, and Impress.
              Thanks to Justin Luth for essential help in making accurate
              descriptions of these commands. It also started to improve
              the maintenance by moving the access commands and icon tables
              from diverse places to a shared/00 folder, introducing variables
              and sections that would allow reusing relevant sequences.
            
             shared/02/04210000.xhp  (Optimize Size menu)
              * add two missing controls as embeds from swriter/main0110.xhp
              * add icon tables for the two controls
              * correction to control name
              * modify switch to include Draw and Impress
              * put controls in same order as dropdown menu
              + add variable to h1, so page can be embedded in related topics
              * update to renamed ids
              * change image size to 1cm
              * refactor to <h1>,<h2>
            
             shared/00/00040500.xhp
               + add <section> to "Open Optimize Size..." (i.e., for opening
                 dropdown menu in Table bar), so it can be embedded into each
                 page for the individual controls.
               * use access controls from swriter/00/00000405.xhp, plus add
                 appl-switch
               * update access for Table menu
            
              swriter/00/00000405.xhp  (Access commands for Size)
               * move all relevant access commands to shared/00/00040500.xhp
            
             swriter/01/05110000.xhp (Row)
              * correction to two command names
              * update to renamed id
              * refactor to <h1>,<h2>
            
             swriter/01/05120200.xhp (Optimal Column Width)
              * update command name
              + add <relatedtopics> with two links
              * rename German id
              * refactor to <h1>
            
             swriter/01/05110200.xhp (Optimal Row Height)
              * update command name
              * rename German id
              + add <relatedtopics> with two links
              * refactor to <h1>,<note>
            
             shared/01/05120600.xhp  (Distribute Columns Equally)
              * corrections to description of the command operation
              + additional information about how to select
              + add "right-click" instructions to "howtoget"
              + add link to "Optimize Size" menu and "Table" bar
              + add <relatedtopics> with two links
              * rename German id
              * refactor to <h1>, changed paragraphs to <menuitem>
              * image size to 1cm
            
             shared/01/05110600m.xhp  (Distribute Rows Equally)
              + add link to "Optimize Size" menu
              + add <relatedtopics> with two links
              * rename German id
              * refactor to <h1>, changed paragraphs to <menuitem>
              * image size to 1cm
            
             swriter/main0110.xhp  (Table menu page)
              * update renamed ids
              + add sections to text in Minimal Row Height
                and Minimal Column Width, so that they
                can be embedded into "Optimize Size"
                menu page.
            
             swriter/guide/table_sizing.xhp
              + add links to "Optimize Size" and "Table" bar in text.
              + add "Optimize Size" to Related Topics
              * refactor to <note>,<tip>,<relatedtopics>
            
            Change-Id: I9b84ccb2cd4d9b4e221f82ee4654e95553f3d188
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135002
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2f5b54ba51157a2346e10dfb82e3d434d6030aaa]

        allow pretty names in --enable-macosx-code/package-signing
        
        also reorder the logic to avoid duplicating the matches for default
        value and manually provided one.
        
        Change-Id: I4466cbeaf5abd7168f21e22cd910f63568c14e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136224
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-29  Caolán McNamara  <caolanm@redhat.com>  [a440d93d2817b908643f0af9e53479fe91286905]

        cid#1506710 Unchecked return value
        
        Change-Id: I703b6eaaaf4381aeafdf9c616dffe871f82caafe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-29  Justin Luth  <jluth@mail.com>  [0031f34d0ba99de5384e13843e99ffbb01f729d0]

        tdf#145151 tdf#119540 sw IsTableMode: deselect unselected cell
        
        So far I have been playing whack-a-mole fixing the case where
        selecting table cells backwards leaves one cell seemingly
        still selected when applying paragraph properties.
        
        This patch seems to fix the underlying selection problem,
        meaning that the other patches can be reverted,
        and their unit tests become proof for this patch.
        
        Change-Id: I8d8a47333ab70917fccb80ff5e96c50302c386ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135569
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c71e26b4cf6181791acff4017f661edb3523c70e]

        elide unnecessary copy in SfxItemSet constructor
        
        Change-Id: I6881f5dcea753a6d2cfbf203b50043219191fae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-29  Szymon Kłos  <eszkadev@gmail.com>  [001d9a20ae3607e618a8fb0889ab2f2bcb612f4f]

        jsdialog: toggle toolbox buttons correctly
        
        Change-Id: Ic02f9ceab29257ebc4cb6261aae10c4f1a7ef176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135562
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit b6b7b3a5a46790baf2266aaeb10976753dfe0fce)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135539
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136605
        Tested-by: Jenkins

2022-06-29  Szymon Kłos  <szymon.klos@collabora.com>  [7fc989c564accbc1678628c9bda988ad06426105]

        jsdialog: formulabar: send also paragraph number for multiline formula
        
        Change-Id: Ia146be83f0ac6f3fbc94d5a904b8067ac8b2a8d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135833
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136596
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-06-29  Miklos Vajna  <vmiklos@collabora.com>  [c09eb0f74c0a110e4a4cfc4783b59883aad30475]

        tdf#149748 sd theme: fix crash on selecting none from color bar
        
        Opening Impress, going to view -> color bar to enable it and then
        clicking on "none" resulted in a crash.
        
        This went wrong in commit f5db3b12ae1cd3bfe6ee5d260aec9532cc65f2dc (sd
        theme: add UI (sidebar) for shape fill color, 2022-04-06), where I
        assumed that in case the slot is a SID_ATTR_FILL_COLOR, then its item
        set also has a SID_ATTR_FILL_COLOR key. This is usually true, but not in
        case of "no color" (i.e. transparent).
        
        Fix the problem by just skipping theming metadata for such a color.
        
        It seems to me that the color set of a theme is not allowed to contain
        such "no color" colors, so this should be safe.
        
        Change-Id: I3fb65548dca1d78631311de56c15fdb655b9645a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136599
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff6fc9927241afe4dc95580bf6bb987fe62a191d]

        tdf#117539 Assert after cut and paste operation of a chart stick
        
        inline the call to the other constructor, and remove the
            assert(size() != 0)
        it appears to be valid to have a size of zero here
        
        Change-Id: Iff18581109a27622701a5dbe22874854ee7b1faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-29  Stephan Bergmann  <sbergman@redhat.com>  [761d3a128214b48645f00e2ff094e0f8928d1ee1]

        Revert "tdf#43100 tdf#104683 tdf#120715 sw: cursor on spaces over margin"
        
        This reverts commit 7ef9c3ef30023cc40068e1f735aa4bec4811288b (plus relevant part
        of c08d71a0e0015ec7857335b68a354df04fa04a0c "Fix typos" follow-up).  It started
        to cause <https://ci.libreoffice.org/job/lo_ubsan/2441/> to fail with
        
        > /sw/source/core/text/itrcrsr.cxx:1659:50: runtime error: downcast of address 0x60700059b250 which does not point to an object of type 'SwTextPortion'
        > 0x60700059b250: note: object is of type 'SwHolePortion'
        >  00 00 00 00  90 23 40 a7 6f 7f 00 00  e1 03 00 00 00 00 00 00  0d 01 00 00 00 00 00 00  00 00 00 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               vptr for 'SwHolePortion'
        >     #0 0x7f6f9f1777f0 in SwTextCursor::GetModelPositionForViewPoint(SwPosition*, Point const&, bool, SwCursorMoveState*) const /sw/source/core/text/itrcrsr.cxx:1659:50
        >     #1 0x7f6f9efc2b39 in SwTextFrame::UnitDown_(SwPaM*, long, bool) const /sw/source/core/text/frmcrsr.cxx:1200:49
        >     #2 0x7f6f9efc5b50 in SwTextFrame::UnitDown(SwPaM*, long, bool) const /sw/source/core/text/frmcrsr.cxx:1298:31
        >     #3 0x7f6f9be4bac8 in SwCursor::UpDown(bool, unsigned short, Point const*, long, SwRootFrame&) /sw/source/core/crsr/swcrsr.cxx:2062:31
        >     #4 0x7f6f9bf0692b in SwShellCursor::UpDown(bool, unsigned short) /sw/source/core/crsr/viscrs.cxx:1025:22
        >     #5 0x7f6f9bb840c0 in SwCursorShell::UpDown(bool, unsigned short) /sw/source/core/crsr/crsrsh.cxx:511:29
        >     #6 0x7f6fa37f131d in SwCursorShell::Down(unsigned short) /sw/inc/crsrsh.hxx:359:50
        >     #7 0x7f6fa37dcfc9 in SwWrtShell::Down(bool, unsigned short, bool) /sw/source/uibase/wrtsh/move.cxx:171:27
        >     #8 0x7f6fb6aa1325 in testTdf43100_CursorMoveToSpacesOverMargin::TestBody() /sw/qa/core/text/text.cxx:532:20
        
        during CppunitTest_sw_core_text
        CPPUNIT_TEST_NAME=testTdf43100_CursorMoveToSpacesOverMargin::TestBody
        
        Change-Id: I37947825ec9db826446ed28fa87a23ee60749b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136549
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2022-06-29  Szymon Kłos  <szymon.klos@collabora.com>  [6ab6f7bf61efe7f42161a2d5760763bf39f8795a]

        lok: formulabar: send correct caret position for numbers
        
        It fixes the bug:
        
        1. Open spreadsheet and type long numer in some cell (only numbers)
        2. Move cell cursor to another cell, then using keyboard go back to the previous cell
        3. click in formulabar somewhere in the middle of a number
        4. try to type one character
        
        result: character was added in correct place but cursor was moved to the start
        expected: caret will stay at correct place
        
        Change-Id: I514d868dce5478e65d57fd2f350da9777b615e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136395
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136598
        Tested-by: Jenkins

2022-06-29  Szymon Kłos  <szymon.klos@collabora.com>  [850b7a567c9d0812dc612ba21ee804d8bafb6fe1]

        jsdialog: formulabar: handle multiline selection
        
        it uses format: "start;end;startPara;endPara"
        
        Change-Id: If3d36550f5e4a35fc04c72114c7719119b10da61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135866
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136597
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-06-29  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [cd67e988f27de819a39e75e5243b9b20ba56faab]

        tdf#149550 sw: fix crash by implementing nested textbox copy
        
        Grouped shapes with a nested textbox were copied without
        the textbox with frequent crashing.
        
        Regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
        "tdf#143574 OOXML export/import of textboxes in group shapes".
        
        Change-Id: Ie2cc24f10706d8999026dc92ebad21f2c5673003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135815
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-29  Stephan Bergmann  <sbergman@redhat.com>  [7e30d784025d2c36c85d8f3defc7740ef8a2fe5a]

        Adapt to LLVM 15 trunk libc++ dropping std::unary_/binary_function
        
        ...for C++17 and beyond with
        <https://github.com/llvm/llvm-project/commit/681cde7dd8b5613dbafc9ca54e0288477f946be3>
        "[libc++] Complete the implementation of N4190".  (Unless explicitly opted-in
        with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION.  This is similar to the
        MSVC standard library needing _HAS_AUTO_PTR_ETC=1 to enable those zombie
        functions for quite some time now.  Only libstdc++ still supports them
        unconditionally.)
        
        Most uses of those zombie functions across LibreOffice itself and the bundled
        external/* are indirectly within Boost include files.  And many (but not all) of
        those Boost include files only use those zombie functions conditionally, based
        on BOOST_NO_CXX98_FUNCTION_BASE.  For the (Dinkumware-derived) MSVC standard
        library, workdir/UnpackedTarball/boost/boost/config/stdlib/dinkumware.hpp
        already defined BOOST_NO_CXX98_FUNCTION_BASE.  So add a patch to define that
        also in workdir/UnpackedTarball/boost/boost/config/stdlib/libcpp.hpp (for all of
        C++11 and beyond, even if those functions were still available as deprecated in
        C++11 and C++14, but which shouldn't make a difference with our C++17 baseline
        anyway; only make sure that things still work if those Boost include files ever
        get used by code built with gb_CXX03FLAGS).  (Patching our bundled
        external/boost of course doesn't help when building with such a new libc++ and
        --with-system-boost against an unpatched Boost, but lets consider that "not my
        problem".  Also, one could always use a sledgehammer like passing
        CPPFLAGS=-D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION into gbuild in
        such a case.)
        
        Then there are two places that include boost/multi_array.hpp, which indirectly
        includes workdir/UnpackedTarball/boost/boost/functional.hpp, which still uses
        those zombie functions for non-MSVC builds (at least in the bundled
        Boost 1.79.0).  Lets do a targeted
        _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION in those cases.
        (Alternatively, we could patch
        workdir/UnpackedTarball/boost/boost/functional.hpp.  Also, I decided to make
        loplugin:reservedid support the new suppression mechanism, rather than extending
        its existing ignorelist even further.)
        
        And then there is external/clucene using those zombie functions even outside of
        a Boost include file, so extend the existing hack there that was already needed
        for MSVC.  (And adapt the accompanying comment:  For one, we are unconditionally
        "in C++17 mode" by now.  And for another, the exact places where
        external/clucene uses those functions have apparently changed over time.)
        
        Change-Id: Id0eec3bedcfddae86b16d33c02c7b5d3b3f8a16f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136579
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [2cf8c1d10e719a13afa6a5d9362a60f80e4318ed]

        tdf#149752: sc_subsequent_filters_test: Add unittest
        
        Change-Id: I6432916e4814864ca07e6966a54cb116e357d0a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136584
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-29  Szymon Kłos  <szymon.klos@collabora.com>  [55aece054255a57506b0c2921d8bc34ca7b5f610]

        jsdialog: be sure we send close popup message when destroyed
        
        use different m_sTypeOfJSON for popups so we can later
        detect popup closing
        
        Change-Id: Id0086815317011b142b49f4e1421b76e1e663358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135497
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136594
        Tested-by: Jenkins

2022-06-29  Szymon Kłos  <eszkadev@gmail.com>  [efc1b8a911599218a68992f568c98382ac77f52d]

        lok: sidebar: notebookbar: don't change view mode for other views
        
        We should change view mode (notebookbar/toolbars) only for current view.
        This prevents the closed sidebar from showing when other view joins the session.
        
        Change-Id: Iaeec1bee0afab7552e223f17dd7afac27d288db9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134690
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit 08891ae798b1e59719684d1b0343767c9d136a11)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135001
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136592
        Tested-by: Jenkins

2022-06-29  Miklos Vajna  <vmiklos@collabora.com>  [91d09185ca21d95f0c70f386bfaafc1c080ded0b]

        CppunitTest_sw_ooxmlexport17: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I12ac2b9764f270ecc516439c58a017bd61e87897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136587
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-29  Szymon Kłos  <szymon.klos@collabora.com>  [61f5c991a97de8990badfed6ef840941b5aa8c7f]

        jsdialog: correctly parse click position for drawingarea
        
        Change-Id: I8f0739cea8d2a3472926682f205bc5f5227bdc4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135241
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136593
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-06-29  Gabor Kelemen  <kelemeng@ubuntu.com>  [51bfd4a3105e4a406dc8f220102520202a72150a]

        tdf#98404 New shortcuts for Move slide commands
        
        Use Shift+Alt+PgUp/PgDn/End/Home since these are free,
        easy to remember and close to each other on a desktop keyboard
        
        Ctrl-Alt-Arrows as suggested in comment 21 is not so good
        since up/down clash with Gnome Shells switch workspace commands
        so they would not "work" in Impress, but switch to the upper/lower
        workspace
        
        Change-Id: I05955c59409aa000f54d0d878a86206f009617aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136585
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [c0ca9ae5b1059d4ab584c7a4c74f7f233789c84c]

        crashtesting: crash seen on exporting tdf117501-3.docx to odt
        
        where the "font stretch" is sufficient to trigger the FreetypeFont ctor
        mfStretch limit check to create an invalid font and we end up in
        this failure case, which might have been missed at commit
        
        commit 894b4911ffb96ff667fdeb3aec7922316ab7230a
        Date:   Thu Oct 28 09:27:29 2021 +0200
        
            pass DX array around using o3tl::span instead of pointer
        
            so we get bounds checking in debug mode
        
        Change-Id: I63d0ccf37ab42954735043c6bf028d3c01616a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136590
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Julien Nabet  <serval2412@yahoo.fr>  [b86c7136fe0f75813dd370b408a7096f78ff168b]

        Typo: "getGridBefore" instead of "getGridAfter"
        
        Change-Id: Ie4dafd54e2eaeb8879dc8938f188cb76ebdd7612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136589
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [8fe3795621a577a866fcd748465b6ee0b6a5385a]

        crashtesting: assert on loading forum-mso-en-8971.docx
        
        Change-Id: Ifce343a26a03b0a17624d584cb8936df49db6148
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136588
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Luboš Luňák  <l.lunak@collabora.com>  [b55a0eea78837d43e77078e96729befb8e420773]

        don't try to use self-referencing ScSortedRangeCache (tdf#149752)
        
        Both the documents from the bugreport use COUNTIF where the range
        includes the cell itself. So trying to create ScSortedRangeCache
        for the range would try to read the values of the cells in the range
        including the cell itself, which would try to interpret COUNTIF,
        which would recurse and deadlock on the mutex.
        
        Change-Id: I95c33d0b75015dcd1d628740ef52c2d680864791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136581
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d477d2eb37fe552a56d6b34be3ce7f773caab125]

        Removed executable bits on files
        
        Change-Id: I8508d26067084ff7bb15bbf2326a1ff7bc61a6ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136521
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [eb9ba4cdff002b95597fd1bdf6c89b9fd4d10ef9]

        ofz: Out-of-memory
        
        Change-Id: Iac52602b0c5f808b384896963c42c4f9dd31519e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [0b1e5f239bede5002f410a7e48c6b9092fe7ec2b]

        ofz: Direct-leak
        
        same issue as https://gitlab.freedesktop.org/cairo/cairo/-/issues/179
        
        cairo_get_source returns a leaked pattern when the context passed in is
        in error, so avoid the infinite stretch which creates the error
        
        Change-Id: I239b85694773cfee77754c2f7bc819f68ef448aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136580
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [496426503675c6da60c6f3cd78549c8a70a8c694]

        tdf#149755 bottom of characters missing in dwrite rendered case
        
        snap bounding box to full pixels
        
        Change-Id: Iecd973e99cec49ee129bad422ae00f558f057abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136577
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [273f59bdb5f446c119e1de4000e5bc7fb7266ea6]

        improve debug output for gstreamer backend
        
        Change-Id: I9fd7af5726ebbca933d69a38669281f40c6c0319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136576
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebbf3ccf693d5b6813746e72719e04e1c7cd438d]

        tdf#117539 Assert after cut and paste operation of a chart stick
        
        Change-Id: I314d263dc37a7af3969ba9eb32ac00997457003d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [0be0b4e57cbeaab3e73f1d12ef2ad9b55fd1c885]

        tdf#149754 correct gradient paint for outside definition range
        
        Change-Id: I45fc0a7a024a4288f698eb5f0abf6b0d1440edfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136561
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-06-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [5f5c105a6e1ee29c0327b50213f66090e1dcfc6d]

        Breeze tdf#149753: Distinguish between New Presentation & Start from 1st Slide
        
        Change-Id: If433cbde1425c7270f43ac869d822520821f27e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136573
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [e36ccc5cf5cb02a70fe5dd6bebcdac601c0fa18a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26d75235b7f3cb46f4d893c45efe9a8f94020027
          - Improve description a bit
            
            Change-Id: Iaaba632db103777f47d414647e611054824bea23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136545
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-28  Stephan Bergmann  <sbergman@redhat.com>  [8a456cc5e371c580d30df539e5fa22d3e7caa6f6]

        Fix typo
        
        ...that was present since 173214d92046b4ea11f6c0959ca40999d1e0bbd2 "Fix liborcus
        build for Android" (but doesn't seem to have caused issues all those years)
        
        Change-Id: I70161f20a94655e8f485cd49bec9ce461c7507f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136563
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-28  László Németh  <nemeth@numbertext.org>  [0b16da6148f67bc66fb5aff5a85d1de48f287752]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c40861d5aaa2430d1953258256c7be27a421b54
          - tdf#149761 new hyphenation options "no CAPS", "zone" etc.
            
            Document new hyphenation options of LO 6.4 (no CAPS) and 7.4
            (hyphenation zone etc.).
            
            Follow-up to core commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69
            "tdf#121658 Add option to not hyphenate words in CAPS",
            core 8c018910ae4d8701b1ce2a95727b9baed4016da3
            "tdf#149248 sw offapi xmloff: add option to not hyphenate last word",
            core commit 29359fc15c435cec17987fd6221ab6833d38746e
            "tdf#149324 sw offapi xmloff: add option to not hyphenate short words"
            and core commit 7a1d4b7d1db93ca1f541856a8d00d621d50e7bd6
            "tdf#149420 sw offapi xmloff: add hyphenation zone".
            
            Change-Id: I234a269d07fbd02efca03b89e7cd750d326d4af2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136572
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cc50e99381fe7a0d35d682c35ae44fbd003d3e7]

        tdf#134328 only copy the RegionBand if it is actually shared
        
        Change-Id: I870ac06dba2f41b5c005b8957049d64ff4a2d4e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Mike Kaganski  <mike.kaganski@collabora.com>  [120daca4198d8a4775bc5c7330a0c415213b7a0b]

        tdf#149447: use proper UNO types for marshalling unsigned Basic types
        
        cppu::UnoType<sal_uInt8> corresponds to UNO boolean, so its use made the
        unsigned values be converted to a true/false in Any; and additionally,
        using such a boolean Any, even having a 'true' value, as a parameter to
        a double argument would make operator >>=(const Any &, double &) return
        false, giving the resulting double equal to 0.
        
        The wrong conversion of UShorts and ULongs to cppu::UnoType<sal_uInt8>
        (aka TypeClass_BOOLEAN) was introduced in commit
        11f9aa4fcb2ad0a5fada8561c7041e7f25a059fc
          Author Andreas Bregas <ab@openoffice.org>
          Date   Thu May 10 14:22:42 2001 +0000
            #79615# sbxToUnoValue(): Choose smallest possible type for numeric values
        
        Treating of unsigned Basic Byte as a signed cppu::UnoType<sal_Int8> (aka
        TypeClass_BYTE) was already introduced in
        commit c25ec0608a167bcf1d891043f02273761c351701
          Author Jens-Heiner Rechtien <hr@openoffice.org>
          Date   Mon Sep 18 15:18:56 2000 +0000
            initial import
        
        Then, in commit 553cf2a834fcca17be6f7712c53e190e90e260eb
          Author Andreas Bregas <ab@openoffice.org>
          Date   Fri Jun 08 14:59:57 2001 +0000
            #87927# Map TypeClass_BYTE to SbxINTEGER instead of SbxBYTE because of signed/unsigned problem
        
        an attempt was made to handle obviously this same problem, changing the
        corresponding UNO type to TypeClass_SHORT. But it seems that it created
        problems when passing arrays of Byte through UNO to COM, where it needed
        to convert to a safearray, so this decision was reverted in commit
        dd6ba6b64aec20d37a402bee233e742e29285e88
          Author Mikhail Voytenko <mav@openoffice.org>
          Date   Thu Jul 08 21:33:48 2010 +0200
            mib17: #162917# let basic byte use one byte, let olebridge convert sequence to safearray correctly
        
        This change tries to avoid the problem that caused the latter revert,
        by only treating Bytes as UNO shorts in getUnoTypeForSbxValue, where
        scalar Byte values are considered, keeping old handling for arrays.
        
        Change-Id: I805108743376e2fc27dd21a27c31759b76dc0d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136526
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-28  Caolán McNamara  <caolanm@redhat.com>  [41879e4737ac42874d2f7f6a94566744a5ed1826]

        crashtesting: fix assert seen with forum-mso-en-8349.docx
        
        a string that ends in spaces
        
        Change-Id: I808f046be816d0d4a76f801a349e284024a2061c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [9dcbb941b21b35dec02a85544881b4e59e8dda2f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06913270253a3a6740fde42752dfec0389d2a1f2
          - Clarify AutoCorrect rules for separator lines
            
            Change-Id: Ia3b4e2acce14b919e5fdebaf58c6040f901169ff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136565
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ba8b37db55d210b915170528fd87df196ab29e7]

        use utl::TempFile directly in package
        
        so we can
        (a) control the lifetime of the temp file properly
        and
        (b) we don't need to use file URLs which means we stay on the
        efficient path on Windows
        
        Change-Id: I2b1eed5f5afc8f89f53bde35ebb44e9922889817
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136557
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7ce1674658bef5bc4da7984c396b77ec09e3670f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8871d41ec6b31d722e3de27742605ff270cd33e1
          - tdf#144055 Fix Find & Replace Help page
            
            Removed switch for Writer
            
            Change-Id: I9d2c1a303ab5c2afdda75fd7403341bd2be97390
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136516
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5b61dd25055d04a03163a3867feeec590bd9eeb9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68b34cc91fa64ca5f0356c9d867bff1b51e848c9
          - tdf#137649 Fix LOGNORM.INV optional arguments
            
            Change-Id: Ia239d14508c1bb6e86d3d4b1d67f50de0fdb5afc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136498
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [75bff1d686307a4c17e1ffa949201f28028f0948]

        tdf#134328 improve SdrObjList::RecalcObjOrdNums
        
        rather iterate directly over the data structure, cheaper than repeatedly
        using operator[]
        
        Change-Id: Ib688ba76e9af01dbaad8ce7fc22d53fa8886f97d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [1761cec439b0ee61544ad5d34d575c659c85116b]

        tdf#134328 avoid some dynamic_cast
        
        Change-Id: I6de30e50d9797090e7fdb3f46ad78552c5d406cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8aea2a4f660cff901c56bcbd2a88377482f4609]

        tdf#134328 use more make_shared
        
        one less allocation this way
        
        Change-Id: Id5fbd414837d7521306dd188306c4e60394307e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Maxim Monastirsky  <momonasmon@gmail.com>  [bdd217c1f23e0fb5f84542f1fb41036c3de538df]

        NewMenuController: Use status update to determine the default factory
        
        This is a follow-up to 2446fdba3ec4a81d6e3b619a1d9e91b3c6dcbd54
        ("tdf#134887 Rework last item handling in NewToolbarController").
        We should better get the information on what is going to be
        executed from the entity that will actually execute it, instead
        of guessing on our own. This makes a difference for at least
        XML Form Document, where CTRL+N used to be shown next to the
        "XML Form Document" entry, although pressing that shortcut
        will open a regular writer doc.
        
        Change-Id: Ib9b58ea2fb83a6cfe9a603af6be97fb36a25ddc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136554
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-28  László Németh  <nemeth@numbertext.org>  [d0e49c07203c9ae33c5dfa1855b2b8909c3e16dc]

        tdf#115524 sw_redlinenum: show original numbering of insertions
        
        in Show Changes mode, according to the name "Show Changes" and
        according to the interoperability requirements.
        
        Follow-up to commit 2413f213625253a9c2b1787b3b9fe859d724a9bd
        "tdf#115523 sw_redlinenum: show correct, also original numbering"
        and commit d3b0fb222f96964d7bd2b82fe20e1547f731b7a6
        "tdf#149710 sw_redlinenum: update numbering at deletion".
        
        Change-Id: I32476baa3daa73b48f9398282cbe7837d95b0a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136562
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [86ec14169cd0811a1ce8ee1e32cd7cad43cb0653]

        clang-tidy modernize-pass-by-value in vbahelper
        
        Change-Id: I7f2a7dd3e8f0a791496f5e021bd802dba89d7643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136559
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [2bf18879d77b6f4e7e8b54267157741f11fb8c5b]

        clang-tidy modernize-pass-by-value in test
        
        Change-Id: I375ff43a60d0058be36dd07e409027ad1dcd1bcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136558
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-28  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [47099350beb5d955d16776e43aa2276d4760eecb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9c4821a20ffdaa879d326ad0537cc72d4f10f886
          - Document all cases of AutoCorrect for separator lines
            
            Looking at sw/source/core/edit/autofmt.cxx we can discover
            all the six cases in SwAutoFormat::DoUnderline()
            
            I don't understand what the "gap 0.75 mm" means, so I removed them.
            
            Change-Id: Ia3e07d7c5e9bfd9581da37f99ce54374e1eb04ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136564
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-06-28  Stephan Bergmann  <sbergman@redhat.com>  [ead76a20700410c16f450e9dde61f5c1f0a4c5b6]

        The std::unary_function workaround should no longer be necessary
        
        ...with the bundled Boost 1.79.0, as
        workdir/UnpackedTarball/boost/boost/numeric/conversion/detail/converter.hpp no
        longer uses it since
        <https://github.com/boostorg/numeric_conversion/commit/ebfded1d7d4a2f773e8233c4df6f96131f79d72e>
        "Remove the deprecated uses of std::unary_function (again)" in Boost 1.66.0
        
        Change-Id: I58808cc2a7836c63ee13cf63c8528fc95f4e2cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136555
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-28  Miklos Vajna  <vmiklos@collabora.com>  [bab023ce3b584e815067a207adc7a8aca1f964af]

        tdf#149654 sw content controls: fix missing string before inline SDT from DOCX
        
        The document had a block SDT and inside that, a run SDT. The content
        that is before the run SDT but already inside the block SDT was lost.
        
        To work incrementally, it was intentional that once commit
        5ee8670f18cb8b1913a23d04590d6a31ac9730de (sw content controls, date: add
        DOCX import, 2022-05-30) changed most of run SDTs to content controls,
        it left block SDTs (and cell/row SDTs, too) unchanged, so they are still
        mapped to fields. What was forgotten is that m_pImpl->m_pSdtHelper in
        DomainMapper is a shared state: once a run SDT starts, it assumes that
        no non-run SDTs are in progress.
        
        Fix the problem by explicitly checking for non-run SDTs before
        PushSdt(), that keeps the separation (content control for run SDT,
        fields for the rest) but fixes the lost content.
        
        This is for plain text SDTs, but other types can be added if necessary.
        
        Change-Id: I46b029a3a945d7416028aa196ac3160e6d96eae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136524
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-28  Miklos Vajna  <vmiklos@collabora.com>  [23f76e2fed8d77c888a5595d96520ec958cccda8]

        sw: document UndoManager
        
        Expand on why we store SwNodes in the undo manager if they are not part
        of a document.
        
        Change-Id: Ibfb03c7bbffcf2e4fe90ec62e0523a6afe8250b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136514
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [213db06cbcd6dda8070b3a5f4b198a64f3465bf6]

        Fix typos
        
        Change-Id: I05271bd76574c09683740204534ff8a6907fc784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136522
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-27  Mahkame Arabgari  <mahkame17arabgari@gmail.com>  [30ef327ff4ad2eb213265596368677db9b4c074a]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I20ef1c159e481f0b5ca97ae9c16a0a3b314eafbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136288
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-06-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e4a57dcdabc9ae7d381025e008b90635c1b7b10c]

        tdf#137747 Fix POISSON.DIST required argument
        
        Cumulative argument of POISSON.DIST was marked optional and is actually
        required.
        
        Change-Id: Ib3be6fe97f6d2441c6c5d3b9186b04d7b83b7821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136499
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [2d9f3c066a065d6aa98f1e594dcf8a091fec2bde]

        Integer division could cancel small values of wrong sign
        
        ... as seen at some documents where the values are like -1. There
        the checks in pushToPropMap may pass (the division result would be 0),
        but the original small negative values would fail the asserts that
        were introduced in commit 5772cef244dbee5834efbc693bc714d89ae6301d
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Wed Jun 15 18:33:38 2022 +0300
            tdf#134210: Reimplement cropping from srcRect and fillRect
        
        Change-Id: I114588862b5cfd2b2e4491424430cc139bdbaae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  dldld  <LibreOfficeContribution@dldld.de>  [398ceced15ee4fdd24b1f8db5e09096c3afa4804]

        tdf#91456 OpenGL context rendered without slide on it
        
        When an OpenGL transition is initialized the screen might show
        for a short time a black screen, because the slide was not directly
        drawn onto the context and therefore a short black flash was visible
        on the beginning of the silde transition.
        
        This issue did on my side only occur, when the slide was changed
        by going to a specific slide, moving to the next slide was fine, like
        shown in the recorded video in the bug tracker. It seems that all
        events which are going over the EventMultiplexer are not having
        this flickering issue, as the moments when the drawing is
        happening are different.
        
        Change-Id: If57d9518e74d3a2ede166fd7e55ef5b290274109
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [6665db99973bd41d07c99a4aaf81f6d145ee4d24]

        sw: avoid divide by zero in SwTextGridPage::CharorLineChangedHdl
        
        See https://crashreport.libreoffice.org/stats/signature/SwTextGridPage::CharorLineChangedHdl(weld::SpinButton%20&)
        
        disable the offending widget if the value is zero.
        
        crash reproducible under gen with CJK features enabled by: format, page
        style, text grid, grid (lines and characters), max base text size of
        1000 and then click in "characters per line" and then click in "lines
        per page".
        
        Change-Id: Ic0f8131955ab01412dd54bdd5d3bffe518938fb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [1ea097688f27ce1cfbceb2637437b0d60e61bc40]

        ofz#24932 Infinite loop
        
        Change-Id: I05770f0209aaee1b9af6b88f85764ec98e7fa5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [e7b3c961e95fdf51557702f2e74db796a6bd2c09]

        cid#1506511 silence Uncaught exception
        
        and
        
        cid#1506512 Uncaught exception
        cid#1506513 Uncaught exception
        
        Change-Id: I964430a69ce4d4beb7f7a551d3ac454c8122a3fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136503
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a15fe37bf1dc50fcf88cea9c0038b217119671b8]

        tdf#149692 crash importing document with vba forms
        
        This bug appears to date back to
            commit a43cc9ec8dde4f311bcf8ff96e6a26d56b2abdcf
            Author: Noel Power <noel.power@suse.com>
            Date:   Wed Apr 17 17:08:59 2013 +0100
            implement MultiPage, Page & TabStrip import for oox
        
        Change-Id: Ia4784e4c34189f05e516704fa2e2485e4560fa4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136500
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [041eef2563198c50470236736fa6949e0b66cda5]

        ofz#48407 OOM
        
        Change-Id: I4e0ee34cffd17203b88602caecbd547fa5b58d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Armin Le Grand (allotropia)  <armin.le.grand.extern@allotropia.de>  [b72d264aa2dfa4fba5ccd9f50a97dbc7e8d6cf6e]

        tdf#149651 Correct the MasterPageBackgroundFill mode
        
        Had to massively adapt to what others do in this issue,
        moving from ViewContact(s) as main data source to
        FillStyle directly
        
        Change-Id: If48666212e2f0afac4fbfab9af4908a5d2b4c047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136487
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-06-27  xuenhua  <xuenhua2008@sina.com>  [2e9ee1e4828818266d528d349b090cc1675e5a28]

        tdf#149690 fix shapespanel bar width of impress
        
        Change-Id: I18afc90943e38bc79f0515d60f06f81b0eb5dd28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [4195b594b91f948a15de58e9426972f6b8c634c9]

        Mark external/libnumbertext/EmptyString.patch1 as upstreamed
        
        Change-Id: I8d926046c11f38daf3a8d7fb4d4176b78a995af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [448ca8c2729b5a0194906e9c9dae95504d5212b9]

        clang-tidy modernize-pass-by-value in svgio
        
        Change-Id: I48283b202a0d5b9560a587daa4ebbf86367875ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136453
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Stephan Bergmann  <sbergman@redhat.com>  [4178d7b2212a9e4ec35b3225c28e50f64132efcb]

        Mark external/liborcus/overrun.patch.0 as upstreamed
        
        Change-Id: Ibc77db49c7b584df1f5f3c086ecd479a28eb7797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136484
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [2a719774948fc1762e60cf7dd2ee3393c8922bb2]

        tdf#126263: do not try to delete non-temporary files
        
        Change-Id: I5df7db7eac6224fce833e6b9d4ea220cade44e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136483
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-27  Mike Kaganski  <mike.kaganski@collabora.com>  [738e0bd68c4b4286b85d3eb5c1a638247fcc26bc]

        tdf#126263: make sure to convert system path to file URLs
        
        Change-Id: Ia21f29e3a1eb078a7df2366399c59d46ab26ff3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136482
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [eea6b27762cdd5f831f4a83b8c5d2979652aab03]

        clang-tidy modernize-pass-by-value in ucbhelper
        
        Change-Id: I9f73760a800bee5a810add9ee0ebed3a778ddd8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Caolán McNamara  <caolanm@redhat.com>  [35ca93f7892e8f19b871f7f687a9f7e4933a65ad]

        crashtesting: fix assert seen on loading forum-nl-1226.ods
        
        Change-Id: If8c08a51b11a459a03b4a0604c1fb9897351e598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [9de4cafcf0efdc2986c3130658ee9233df392773]

        clang-tidy modernize-pass-by-value in unoxml
        
        Change-Id: Id0df30bed0de7db0564816180497406c55cf9fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Miklos Vajna  <vmiklos@collabora.com>  [5938687e5764ee50759374b54d2bb1cf0e0d59d3]

        tdf#149668 sw: fix DOCX->ODT: Multilevel lists causing list numbering reset
        
        The bug document had an outer (ordered) numbering and an inner one,
        finally the outer numbering was continued. This was fine after DOCX
        import, but once we saved to ODT and re-opened, the second outer
        numbering was restarted, not continued the first outer one.
        
        This happened because on one hand, lcl_SwXParagraph_getPropertyState()
        says that the state of the ListId property is "default" if the
        paragraph's item set doesn't have a RES_PARATR_LIST_ID, but on the other
        hand xmloff/ will only write the xml:id="..." attribute on a list if the
        ListId state is not default. This is a problem, because it can happen
        that xmloff/ refers to a list later by its id, even if the list doesn't
        have a RES_PARATR_LIST_ID set.
        
        Fix the problem by relaxing the condition where
        lcl_SwXParagraph_getPropertyState() reports FN_UNO_LIST_ID as
        non-default: just require that that the text node has a numbering rule
        + the numbering rule has at least one continue list. This fixes the
        reported DOCX -> ODT case with named list styles and keeps the original
        ODT import and HTML import use-cases working to not write un-referenced
        xml:id="..." attributes on export.
        
        This was a regression from commit
        8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced
        <text:list xml:id="...">, 2022-03-10).
        
        Change-Id: I300ebe7aa7da71a336c03abe7530074b696417f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136477
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [69485e422c906a3bb290797725a0784f73d94b9f]

        clang-tidy modernize-pass-by-value in stoc
        
        Change-Id: Ia628b2af646e576d52b6c72352255710a885c23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136452
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [04073c5fedd33654f242fecb7e39afb07cf0e273]

        replace oox::OptValue with std::optional
        
        Change-Id: I16e7179b2851640b4d73665685dcc1e84042ddaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-27  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [5b21b65572610df88986e700b81f1156aff14f65]

        tdf#142770 tdf#143031 EMF+ Implement CustomLineCap
        
        Change-Id: I9fae1d259ecdca37a1babac8a8a0e503b2dc0118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135960
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-06-27  László Németh  <nemeth@numbertext.org>  [75e2d313760847110479f00a86a19fba4f508181]

        tdf#149713 sw para dialog: gray out labels of the new options
        
        Labels of the new hyphenation options "Hyphenation zone" and
        "Minimum word length in characters" were always black, instead
        of gray, when Hyphenation is disabled.
        
        Follow-up to commit 7a1d4b7d1db93ca1f541856a8d00d621d50e7bd6
        "tdf#149420 sw offapi xmloff: add hyphenation zone" and
        commit 29359fc15c435cec17987fd6221ab6833d38746e
        "tdf#149324 sw offapi xmloff: add option to not hyphenate short words".
        
        Change-Id: Ic41c2fa0fa69385013b1e90568084956cc5d791d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136367
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-27  Miklos Vajna  <vmiklos@collabora.com>  [9c796266470183f673eb58a8637dfe621eefa8b3]

        sw: prefix members of ww8toolbar
        
        Kme, MCD, MacroName and MacroNames
        
        See tdf#94879 for motivation.
        
        Change-Id: Ida3a41b22887f5a21b3be48665fa722d4ff2b027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136449
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-27  Miklos Vajna  <vmiklos@collabora.com>  [167a5ce786b0561028ad42ea3fc92e55d14484a4]

        sw HTML export: fix missing escaping for image links
        
        Hyperlink URLs on images are currently written to the HTML output as-is,
        without any any encoding.
        
        Image links are written using HtmlWriter from svtools, which has the
        advantage of not building the markup manually (similar to
        sax_fastparser::FastSerializerHelper for XML), but that doesn't do any
        escaping. Some other parts of the HTML export build the export markup
        manually, but use HTMLOutFuncs::Out_String() to encode problematic
        content.
        
        Fix the problem by using HTMLOutFuncs::Out_String() in HtmlWriter for
        attribute values: it seems reasonable to assume that users of HtmlWriter
        would pass in unencoded strings, similar to how the sax serializer
        works.
        
        This could lead to double-encoding in case some user of
        HtmlWriter::attribute() would encode its attribute value already, but
        inspecting existing calls, none of the clients seem to do that at the
        moment.
        
        Change-Id: I5439e829b1b837cb9c51292b118f0b47e84197db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136399
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-27  Jim Raykowski  <raykowj@gmail.com>  [8e8e0aefc998adba749a93cacc4660d859fba675]

        tdf#149279 SwNavigator enhancement to show at least two headings
        
        above tracked heading
        
        For gtk3, treeview scroll_to_row to a visible collapsed row makes
        the row expanded. The sal version does not. To make the behavior
        consistent, the patch removes the call to
        gtk_tree_view_expand_to_path which causes a visible collapsed row to
        expand.
        
        Change-Id: I29e67535ab23aa1952b4ff97c1b81276794b8036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136436
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-06-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [85b7f8f155ae19957e1b2e6ea62f4aa8f08108cc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e1b00e5d940b647b550b3314985ebb775be2543
          - tdf#149218 Add pivot table formatting help page
            
            Change-Id: I807b0e62998bac85cf0cf348d57cb1f99b1dc742
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136411
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-26  Balazs Varga  <balazs.varga991@gmail.com>  [415dc3bb1c03dbdbc3cbca274bc435ac7557ba2d]

        tdf#148820 sc: fix conditional formatted cell color
        
        Store foreground color for color filtering, because in OOXML
        the foreground color is used for color filtering and we overwrote
        it with the background color which is used for conditional formatted cells too.
        
        Regression from commit: 6f908b48373b71d45c8119b296b0504fb586f6f8
        (tdf#143104 Fix xlsx import/export of color filter colors)
        
        Change-Id: I737e6f1170851822a2689fa477db59e62f0d47fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136055
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-26  Luboš Luňák  <l.lunak@collabora.com>  [423f277cc0c185ff7eaf79aa9237585c52e0c652]

        fix ByValue lookups with ScSortedRangeCache
        
        My fix for tdf#149071 actually disabled the optimization for all
        ByValue lookups, because in fact all such lookups have maString set.
        So lookups where the cells are a mix of numeric and string values
        need different handling. A simple solution is detecting such a mix
        when collecting the values for ScSortedRangeCache and disabling
        the optimization in such a case. But it turns out that queries
        containing such a mix are not that rare, as documents may e.g.
        do COUNTIF($C:$C) where the given column has numeric values that
        start with a textual header. So bail out only if the string cell
        actually could affect the numeric query.
        Also fix ScSortedRangeCache usage depending on query parameters,
        different instances are needed for e.g. different ScQueryOp,
        because the ScQueryEvaluator functions may return different
        results (isQueryByString() is automatically true for SC_EQUAL).
        
        Change-Id: Ib4565cbf6194e7c525c4d10d00b1c31707952a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136403
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-26  Luboš Luňák  <l.lunak@collabora.com>  [c92b92a3da7ac877337eb73a75cbce427b5ae8e5]

        rEntry.bDoQuery is always true for processed entries
        
        As can be seen at the beginning of ScQueryEvaluator::ValidQuery()
        in the for loop condition. Comes from 4fd1333ba4bb4f2311e909829,
        and I'm not quite sure if the passed value is really supposed
        to be always true or if it's a mistake.
        
        Change-Id: I44bde5d50ac70332d6e48ee583ffed13e664cd61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136396
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-26  Luboš Luňák  <l.lunak@collabora.com>  [5a9c4fc41ec42161ff89c946248f03f16fae7d24]

        more efficient recalculations from xlsx import of pivot tables
        
        The import of pivot tables in xlsx triggers recalculations, even
        though it's not necessary. Fixing that properly seems complex given
        how ScDPObject is designed, so at least ensure the calculation is
        efficient (formula grouping is otherwise done only after pivot
        table import). This can especially noticeable for formulas where
        groups make a big difference (e.g. COUNTIFS uses ScSortedRangeCache
        only for formula groups).
        
        Change-Id: I8dbdf854880707a9707cdc9dc3d73fc1d6b6b000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136362
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-26  Jean-Pierre Ledure  <jp@ledure.be>  [e58a75251a4c877ff4ded94ede01310135b996db]

        ScriptForge - (SF_Calc) accurate sheet name check
        
        The parsing of sheet names and range addresses
        has been reviewed to include the exact rules for
        sheet naming:
          must not be empty
          must not contain []*?:/\
          must not use ' (apostrophe) as 1st and last character
        Additionally (ScriptForge only) it must not contain "~"
        which, by convention, indicates the active sheet.
        
        The code accepts exotic sheet names like:
          "$"
          "$Sheet99"
          "$Sheet'99"
          "$.Sheet'99"
          "!'@#$%^&()-_=+{}|;,<.>"""
        and exotic addresses like:
          "'$'.A1"
          "'$Sheet99'.A1"
          "'$Sheet''99'.A1"
          "'$.Sheet''99'.A1"
          "'!''@#$%^&()-_=+{}|;,<.>""'.A1"
        
        Target is to match completely the Calc constraints for
        writing formulas and sheet names..
        
        The same rules are applicable evenly for user scripts
        written either in Basic or in Python.
        
        Change-Id: I759d7700152a3d811b89f156c4d9eee0071c2a7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136446
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-06-26  Parsa  <9400ioi4517513156392@gmail.com>  [e021fc0a1a00f4ac635cdbeb89826805482e50df]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Ia99101f10b3b98f2ba935d1f7cadfbbd4aaade6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136439
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-26  Amir H  <a.e.miir333@gmail.com>  [e9d4fe965aa40496fb0e2107a3abf1e260a65c28]

        tdf#143148 Use pragma once instead of the include guards
        
        Change-Id: Ief3c0d01746ea1897b55f4f0994237d28a8a04e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136440
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-26  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [8b82a71013567e148166b514d0ce0f5905f5a3e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5ef41a2b82144ac39ce0169013cbc803b456a6f
          - String updates…
            
            ... to remove some hardcoded product names and to bring the help
            in line with recent UI changes
            
            Kudos to Celia and Olivier
            
            Change-Id: If83039fce0612e04d59c5a5bebba6993c1e5a044
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136445
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-26  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [331a9f6135cb7808e53e8c18e1d3fa727bf9c1a0]

        Use a better label for the Unicode block combobox
        
        Celia resolved, and I concurred, that just having a bunch of obscure
        language/script names thrown around was puzzling for users, and
        suggested this new label. In a happy coincidence (great minds think
        alike!), Olivier thought about the importance of us using precise
        Unicode terminology in commit df030f6e632ab0046bd51d1f8425ecd8362c2b33.
        So let’s double down!
        
        Co-authored-by: Celia Palacios <celia.palacios@libreoffice.org>
        Change-Id: I74f54da00e9cf8fcc1a5603e5b1850b2b41c668f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136444
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-25  Caolán McNamara  <caolanm@redhat.com>  [e43aba4ec0d39ccf02a804a840bf2360125d16da]

        cid#707857 Uninitialized scalar field
        
        Change-Id: Ia83a46286f16ad94e6829e9c372c4e9465f503e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136443
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-25  Noel Grandin  <noelgrandin@gmail.com>  [34c6d02661949fcc9c15bd77d6e837623bbddcdb]

        tdf#149647 LibreOffice Calc cursor not positioned correctly
        
        Revert the offending commit
            commit feec8e3c34e08b621098a17f1011dccd0b4f7f4c
            reduce iteration in ScViewData::GetScrPos
        
        Change-Id: Id1df2bf7f87e6b800b40871c1472ed466b7eb6a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [1759fb1f50015a4ce4f8b9843891e71a615b5a2e]

        WIN flatten and assert some code
        
        Thanks to Mike Kaganski to come up with the correct asserts.
        
        Change-Id: I01b2b0026fc4de67a14fa803357a4c28951088ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135810
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4c92844e10029284a80770546e4b235793172f24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 82662154a36127478be0ead3ced7550dd6f2a1b4
          - refactor to avoid problem for some translators
            
            Change-Id: I60eedf1a4ac8f77bcc3747ea9454de30ad183ae5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136421
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [6aa4d96f1290596e7e346573afb18756441c823d]

        use SAL_WARN instead of printf for logging
        
        Change-Id: Ic6134cae251b8096b720005b62ce282def6b7ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136368
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [e18d8bf5cfdb12b75888c2ddd25a829cf5c66305]

        Resolves tdf#143055 - Make Snap-to-grid easier to access
        
        Added to page context menu, standard toolbar, and line & filling
        toolbar
        
        Change-Id: I04c2a77ac25a0c00771a74069f61a94d8e523a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136360
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-25  Marco Cecchetti  <marco.cecchetti@collabora.com>  [32f2f43929e2869bf2e66f5f70795beb03cb39a1]

        svg filter: support for emphasis spin animation
        
        Partial support for transform animations.
        At present only rotate is supported.
        
        Change-Id: If9ba69ec0b74bc3b527a963cb0c0bf3a7bfa5220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134626
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-06-24  Caolán McNamara  <caolanm@redhat.com>  [328b7a34255ed1ffb0029fa1f247d16ba92f18cd]

        tdf#149626 use recursive_mutex to fix hang in macro callback during dnd
        
        See frame #5 and frame #45 where
        
        both the same DNDEventDispatcher object and both functions lock m_aMutex which is a std::mutex since
        
        commit 8de81db4e3fca488d50db2d74734109b31541a6f
        Date:   Mon Aug 2 09:21:17 2021 +0200
        
            osl::Mutex->std::mutex in DNDEventDispatcher
        
         #0  0x00007ff094530c40 in __lll_lock_wait () at /lib64/libc.so.6
         #1  0x00007ff0945371d2 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6
         #2  0x00007ff08b901663 in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x1a32c60)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/x86_64-redhat-linux/bits/gthr-default.h:749
         #3  0x00007ff08b9024d5 in std::mutex::lock() (this=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/std_mutex.h:100
         #4  0x00007ff08b9018f3 in std::scoped_lock<std::mutex>::scoped_lock(std::mutex&) (this=0x7ffdd0d79240, __m=...)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/mutex:731
         #5  0x00007ff08b9006a8 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...)
             at vcl/source/window/dndeventdispatcher.cxx:156
         #6  0x00007ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...)
             at vcl/unx/gtk3/gtkinst.cxx:1710
         #7  0x00007ff0760a7010 in GtkInstDropTarget::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int)
             (this=0x199eb40, pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0) at vcl/unx/gtk3/gtkframe.cxx:5026
         #8  0x00007ff07609bb77 in GtkSalFrame::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int, void*)
             (pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0, frame=0x19b7d70) at vcl/unx/gtk3/gtkframe.cxx:4922
         #9  0x00007ff075649527 in _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINTv () at /lib64/libgtk-3.so.0
         #10 0x00007ff0865dcd5b in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
         #11 0x00007ff0865ddeb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
         #12 0x00007ff07595b491 in gtk_drag_dest_motion.lto_priv () at /lib64/libgtk-3.so.0
         #13 0x00007ff0757b8f7d in gtk_main_do_event () at /lib64/libgtk-3.so.0
         #14 0x00007ff0754e5463 in _gdk_event_emit () at /lib64/libgdk-3.so.0
         #15 0x00007ff075518056 in gdk_event_source_dispatch () at /lib64/libgdk-3.so.0
         #16 0x00007ff0864c3faf in g_main_context_dispatch () at /lib64/libglib-2.0.so.0
         #17 0x00007ff0865192c8 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0
         #18 0x00007ff0864c1940 in g_main_context_iteration () at /lib64/libglib-2.0.so.0
         #19 0x00007ff075f3e60f in GtkSalData::Yield(bool, bool) (this=0x952930, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkdata.cxx:405
         #20 0x00007ff075f43e43 in GtkInstance::DoYield(bool, bool) (this=0x9527e0, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkinst.cxx:428
         #21 0x00007ff08c2dc5df in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=false) at vcl/source/app/svapp.cxx:474
         #22 0x00007ff08c2dc24d in Application::Reschedule(bool) (i_bAllEvents=false) at vcl/source/app/svapp.cxx:493
         #23 0x00007ff091eeeb55 in SbiRuntime::Step() (this=0xa21eb20) at basic/source/runtime/runtime.cxx:801
         #24 0x00007ff091e0e659 in (anonymous namespace)::RunInitGuard::run() (this=0x76a6290) at basic/source/classes/sbxmod.cxx:1015
         #25 0x00007ff091e0d135 in SbModule::Run(SbMethod*) (this=0xa0ada00, pMeth=0xa16d7e0) at basic/source/classes/sbxmod.cxx:1176
         #26 0x00007ff091e0c503 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0xa0ada00, rBC=..., rHint=...) at basic/source/classes/sbxmod.cxx:775
         #27 0x00007ff090b3ee6e in SfxBroadcaster::Broadcast(SfxHint const&) (this=0xa231de0, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39
         #28 0x00007ff091e1372e in SbMethod::Broadcast(SfxHintId) (this=0xa231ca0, nHintId=SfxHintId::BasicDataWanted) at basic/source/classes/sbxmod.cxx:2113
         #29 0x00007ff091f6ddfa in SbxObject::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0)
             at basic/source/sbx/sbxobj.cxx:274
         #30 0x00007ff091d9dd76 in StarBASIC::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0)
             at basic/source/classes/sb.cxx:1324
         #31 0x00007ff091dd7127 in (anonymous namespace)::BasicAllListener_Impl::firing_impl(com::sun::star::script::AllEventObject const&, com::sun::star::uno::Any*)
             (this=0xa2344a0, Event=..., pRet=0x0) at basic/source/classes/sbunoobj.cxx:3831
         #32 0x00007ff091dd6ba1 in (anonymous namespace)::BasicAllListener_Impl::firing(com::sun::star::script::AllEventObject const&) (this=0xa2344a0, Event=...)
             at basic/source/classes/sbunoobj.cxx:3855
         #33 0x00007ff091dd792f in (anonymous namespace)::InvocationToAllListenerMapper::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&)
             (this=0xa110b70, FunctionName="dragOver", Params=uno::Sequence of length 1 = {...}) at basic/source/classes/sbunoobj.cxx:3983
         #34 0x00007ff091dd7be7 in non-virtual thunk to (anonymous namespace)::InvocationToAllListenerMapper::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) ()
             at /home/caolan/LibreOffice/core/instdir/program/libsblo.so
         #35 0x00007ff072d19921 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*)
             (pThis=0xa110b98, nVtableIndex=4, pRegisterReturn=0x7ffdd0d7b5c0, pReturnTypeRef=0xa875c0, bSimpleReturn=false, pStack=0x7ffdd0d7b5e0, nStack=0, pGPR=0x7ffdd0d7b900, pFPR=0x7ffdd0d7b8c0) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
         #36 0x00007ff072d184fc in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**)
             (pThis=0xa238bb0, aVtableSlot=..., pReturnTypeRef=0xa875c0, nParams=4, pParams=0x2470e40, pUnoReturn=0x7ffdd0d7bb80, pUnoArgs=0x7ffdd0d7bbb0, ppUnoExc=0x7ffdd0d7bb60) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
         #37 0x00007ff072d17c58 in unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**)
             (pUnoI=0xa238bb0, pMemberDescr=0x24c98c0, pReturn=0x7ffdd0d7bb80, pArgs=0x7ffdd0d7bbb0, ppException=0x7ffdd0d7bb60)
             at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
         #38 0x00007ff0472645ca in stoc_invadp::(anonymous namespace)::AdapterImpl::invoke(_typelib_TypeDescription const*, void*, void**, _uno_Any**)
             (this=0xa112060, pMemberType=0xa11be80, pReturn=0x7ffdd0d7c4f0, pArgs=0x7ffdd0d7bca0, ppException=0x7ffdd0d7bde0)
             at stoc/source/invocation_adapterfactory/iafactory.cxx:457
         #39 0x00007ff04726379d in stoc_invadp::adapter_dispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**)
             (pUnoI=0xa118a50, pMemberType=0xa11be80, pReturn=0x7ffdd0d7c4f0, pArgs=0x7ffdd0d7bca0, ppException=0x7ffdd0d7bde0)
             at stoc/source/invocation_adapterfactory/iafactory.cxx:605
         #40 0x00007ff072d04e95 in cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, _typelib_TypeDescription const*, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void**, void**, void**, unsigned long*)
             (pThis=0xa11b350, pMemberTypeDescr=0xa11be80, pReturnTypeRef=0x939280, nParams=1, pParams=0xa112460, gpreg=0x7ffdd0d7c520, fpreg=0x7ffdd0d7c540, ovrflw=0x7ffdd0d7c590, pRegisterReturn=0x7ffdd0d7c4f0) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191
         #41 0x00007ff072d04611 in cpp_vtable_call(sal_Int32, sal_Int32, void**, void**, void**, sal_uInt64*)
             (nFunctionIndex=7, nVtableOffset=0, gpreg=0x7ffdd0d7c510, fpreg=0x7ffdd0d7c540, ovrflw=0x7ffdd0d7c590, pRegisterReturn=0x7ffdd0d7c4f0)
             at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389
         #42 0x00007ff072d29836 in privateSnippetExecutor () at /home/caolan/LibreOffice/core/instdir/program/libgcc3_uno.so
         #43 0x00007ff08b903787 in DNDListenerContainer::fireDragOverEvent(com::sun::star::uno::Reference<com::sun::star::datatransfer::dnd::XDropTargetDragContext> const&, signed char, int, int, signed char)
             (this=0x5a444c0, context=uno::Reference to ((anonymous namespace)::GtkDropTargetDragContext *) 0xa1dda68, dropAction=1 '\001', locationX=89, locationY=33, sourceActions=3 '\003') at vcl/source/window/dndlistenercontainer.cxx:224
         #44 0x00007ff08b900b7d in DNDEventDispatcher::fireDragOverEvent(vcl::Window*, com::sun::star::uno::Reference<com::sun::star::datatransfer::dnd::XDropTargetDragContext> const&, signed char, Point const&, signed char)
             (pWindow=0x5a27060, xContext=uno::Reference to ((anonymous namespace)::GtkDropTargetDragContext *) 0xa1dda68, nDropAction=1 '\001', rLocation=Point = {...}, nSourceActions=3 '\003') at vcl/source/window/dndeventdispatcher.cxx:297
         #45 0x00007ff08b9007f5 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...)
             at vcl/source/window/dndeventdispatcher.cxx:178
         #46 0x00007ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...)
            at vcl/unx/gtk3/gtkinst.cxx:1710
        
        Change-Id: I06f24ac50d6d029803d46974162e1afec898d866
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Stephan Bergmann  <sbergman@redhat.com>  [3f17a643d0f943d02c7cb2b5d8e702fe0e63e38d]

        external/liborcus: Fix heap-buffer-overflow
        
        ...as seen during CppunitTest_vcl_pdfexport:
        
        > ==573913==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62b0001dba0e at pc 0x560576627186 bp 0x7ffeab9fa730 sp 0x7ffeab9f9ef0
        > READ of size 26624 at 0x62b0001dba0e thread T0
        >  #0 in StrtolFixAndCheck(void*, char const*, char**, char*, int) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3629:3
        >  #1 in strtol at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:485:3
        >  #2 in orcus::sax_token_handler_wrapper_base::attribute(std::basic_string_view<char, std::char_traits<char>>, std::basic_string_view<char, std::char_traits<char>>) at workdir/UnpackedTarball/liborcus/src/parser/sax_token_parser.cpp:344:22
        >  #3 in orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper::attribute(orcus::sax::parser_attribute const&) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:212:27
        >  #4 in orcus::sax_parser<orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::attribute() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:570:15
        >  #5 in orcus::sax_parser<orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::declaration(char const*) at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:389:9
        >  #6 in orcus::sax_parser<orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::element() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:242:13
        >  #7 in orcus::sax_parser<orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::body() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:214:13
        >  #8 in orcus::sax_parser<orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::handler_wrapper, orcus::sax_parser_default_config>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_parser.hpp:182:5
        >  #9 in orcus::sax_ns_parser<orcus::sax_token_parser<orcus::xml_stream_handler>::handler_wrapper>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_ns_parser.hpp:277:14
        >  #10 in orcus::sax_token_parser<orcus::xml_stream_handler>::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/../../include/orcus/sax_token_parser.hpp:215:14
        >  #11 in orcus::xml_stream_parser::parse() at workdir/UnpackedTarball/liborcus/src/liborcus/xml_stream_parser.cpp:68:9
        >  #12 in orcus::orcus_xls_xml::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/orcus_xls_xml.cpp:94:16
        >  #13 in orcus::detect(unsigned char const*, unsigned long) at workdir/UnpackedTarball/liborcus/src/liborcus/format_detection.cpp:68:9
        >  #14 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) at sc/source/filter/orcus/filterdetect.cxx:83:31
        > 0x62b0001dba0e is located 0 bytes to the right of 26638-byte region [0x62b0001d5200,0x62b0001dba0e)
        > allocated by thread T0 here:
        >  #0 in operator new[](unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:98:3
        >  #1 in SvMemoryStream::AllocateMemory(unsigned long) at tools/source/stream/stream.cxx:1698:12
        >  #2 in SvMemoryStream::SvMemoryStream(unsigned long, unsigned long) at tools/source/stream/stream.cxx:1544:9
        >  #3 in (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) at sc/source/filter/orcus/filterdetect.cxx:71:20
        
        This started to occur now after a95c585433246813096e8890b7ed6ef4fe30c621 "Pump
        XInputStream into an SvMemoryStream rather than an OStringBuffer" no longer
        guarantees that the memory range passed into
        
          orcus::detect(const unsigned char* buffer, size_t length)
        
        is followed by a null byte at buffer[length].  (There appears to be no
        documentation for that function, but it looks unreasonable to me that it should
        require callers to provide a buffer thus terminated, and I rather assume that
        what is observed here is an orcus bug.)
        
        The problematic calls of std::strtol were used in code apparently meant to parse
        strings matching the XML VersionNum grammar production, and then store the two
        dot-separated numbers each as uint8_t.  The new code using a local readUint8
        accepts a different set of strings now than the original code using std::strtol,
        but the new set is arguably closer to what the actual XML VersionNum grammar
        production accepts (which is '1.' [0-9]+ for XML 1.0 and '1.1' for XML 1.1), so
        this change should be OK.
        
        Change-Id: I1668542c96ced64667cb9f251e79126e1a54ac30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136405
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [79f3abc0e200ffa772bc7722b5f384eb538d7576]

        make oox::OptValue::value() assert if empty
        
        as part of replacing OptValue with std::optional, we need to mimc the
        behaviour of std::optional::value(), which will throw
        bad_optional_access
        
        Change-Id: Icf5141cefd4623a6a1bb7b3a3449d3af382e01c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Roman Kuznetsov  <antilibreoffice@gmail.com>  [a22652b76a5ed1fc130607e8999ed86681b4ed1f]

        tdf#148138 change Text Boundaries color to Gray for Dark mode
        
        Change-Id: I276896d0ea94e741be8c0ae49f79f95769e0c2a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136234
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c08d71a0e0015ec7857335b68a354df04fa04a0c]

        Fix typos
        
        Change-Id: I48d173ab697425bcff663f7f7d0bbc404a950bb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136402
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-24  Miklos Vajna  <vmiklos@collabora.com>  [3edfbc19950610bb2061d29cb58b3811b1a0b1a5]

        tdf#148522 svx: fix undo of cell border changes text alignment in other cells
        
        The Impress table properties dialog has multiple purposes: normally it
        only affects the properties of the currently active cell, but shadow is
        applied on the whole shape.
        
        Regression from commit fdeb04f7c59cf8032fe17072ed779e70505cc6ab
        (tdf#129961 svx: finish UI for table shadow as direct format,
        2020-12-15), we started to apply properties to the current cell, and
        then to the whole shape as well, unconditionally. This affects
        undo/redo, as there is a separate undo manager while the text edit of a
        table cell is active and when the text edit is ended.
        
        Fix the problem by only applying properties on the shape when there we
        actually have some properties: this way the text edit is typically not
        ended, bringing back the old undo/redo behavior.
        
        Note that we still need to end the text edit if the user explicitly sets
        some shadow properties, that part is unchanged with this commit.
        
        Change-Id: I78e28bd326a2c12c3775b33957adca4cd95ac582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136357
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c28906ff6b3cc2fc306d927010cf730e7ef5fbc]

        clang-tidy modernize-pass-by-value in sdext
        
        Change-Id: Ieded279152946830b2619ac80c4a9639d616557a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c57c295e86676d9cfe5aa72f55dbd5d24cc7930]

        clang-tidy modernize-pass-by-value in reportdesign
        
        Change-Id: I2c005a2f66139237cb1ebf09812f31fb08f53c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136397
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [72412c5773152a8023530b9807a42d7588f76f2b]

        svtools: avoid divide by zero in calcCustomItemSize
        
        See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::calcCustomItemSize
        
        Change-Id: I5f1b19b7679c73cf29952629469e5151395b2b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136254
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-24  László Németh  <nemeth@numbertext.org>  [4430bf8f97b1438252dc494cae89863d24469d2b]

        tdf#149710 sw_redlinenum: update numbering at deletion
        
        in Show Changes mode.
        
        Follow-up to commit 2413f213625253a9c2b1787b3b9fe859d724a9bd
        "tdf#115523 sw_redlinenum: show correct, also original numbering".
        
        Change-Id: Iebf54775f3850e668ac5b12ecbd9f010b4e93ee4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136363
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2800463878cc932a41701f5002f88da5d654830d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4943fb359a3209a2a998c442d41dc77972950ae0
          - Fix typo
            
            Change-Id: I7c898cbd8890c82c3ebcb0d3d0d4d22096b6f1d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136400
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [995cb63408f28753b868845641d584f1fac005aa]

        tdf#149679: sc_subsequent_filters_test: Add unittest
        
        Change-Id: Ieef8f8a079aad7948250ac7d1860b63066df974c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136361
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-24  Stephan Bergmann  <sbergman@redhat.com>  [9ea2483c20783000249c6648637b631114b702c6]

        SVG is a textual XML format after all
        
        When researching <https://gerrit.libreoffice.org/c/core/+/136350> "Make
        CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust", I
        was genuinely puzzled that git treated .svg files as binary data, until I
        discovered 93e425cda7b7ea026842bb6619d9aa4ce3280048 ".gitattributes: treat .svg
        and .jcs as binary".  I don't consider its rationale of "this is apparently the
        only way to prevent results from endless base64 encoded lines (svg) [...] in
        'git grep foo'" convincing enough, compared to the puzzlement and inconvenience
        it causes when you do want to grep for the content of SVG files.
        
        (I didn't experience similar issues with .jcs files, so leave that alone for
        now.))
        
        Change-Id: I1b1f4aa92f7a538408e246080cdd415e109d2002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136351
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-24  Alain Romedenne  <alain.romedenne@libreoffice.org>  [1c44d1051cfee6ce7099965dc4470b4820f80489]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68e39672b4fdc9719f2e0a85e83f2d6fff6c180c
          - Toc update to document Python resources
            
            Python modules deserve to be highlited:
            - scriptforge
            - uno
            - msgbox
            
            Change-Id: I6d0cad668527b17b1f3ca898d5001768cb30a318
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135947
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-24  Attila Szűcs  <szucs.attila3@nisz.hu>  [7ef9c3ef30023cc40068e1f735aa4bec4811288b]

        tdf#43100 tdf#104683 tdf#120715 sw: cursor on spaces over margin
        
        Allow cursor movement on spaces over margin (or clicking it
        it to position the cursor), like MSO does instead of stopping
        cursor before the stripped (from the typesetting) spaces.
        This way it's possible to follow the modification of these
        characters, e.g. removing spaces or inserting other characters
        at the cursor position.
        
        Follow-up to commit 8741fd0e0ae9e346de2e09887f0668b831c9b48b
        "tdf#43244 sw: show stripped line-end spaces on margin".
        
        Details: extend SwHolePortion to calculate its width,
        that can be used for cursor movement, even over the right
        margin. Removed some code that not allowed cursor to be
        positioned over the right margin. Layout calculation uses
        m_nWidth variable (that was 0) to make frames. To keep the
        layout unchanged, this new width calculated into m_nExtraBlankWidth temporarily, and this extra width is added to m_nWidth only
        after the layout calculation is finished. (Ideally this 2 width
        values could be stored and used separately, but that would require
        a bigger refactor of the cursor calculation.)
        
        Known regression: lost selection at Search & Replace, e.g. searching
        double spaces: there was a narrow selection at end of the line
        showing the position.
        
        Other issues: when a different character inserted on the margin
        resulting new line break, space formatting marks aren't updated
        according to the less spaces. Removing the inserted character by
        Backspace results losing of the cursor movement on the spaces.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I94b4ed40b8c560e1ef32f4d0d3537e070c08666f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135895
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-06-24  Heiko Tietze  <tietze.heiko@gmail.com>  [b1c6b936a74e41655e6ba6680654d21d019e5256]

        Related tdf#143055 - Grid and Snap to Grid on Drawing toolbar
        
        Change-Id: Ie04010d3bd0af65bcbb1f8c01a36878b2c9088ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136358
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-24  Tünde Tóth  <toth.tunde@nisz.hu>  [0ad5d133bd75ccd3a04505aaac7ad3f2f9105f76]

        tdf#132781 DOCX: export interoperable hyperlink style names
        
        Similar to the paragraph styles, export default character
        style names instead of the localized ones to avoid e.g. not
        interoperable hyperlinks in MSO.
        
        Change-Id: I65678a564ae4e73a1d8319df364defd698381256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136139
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-06-24  Eike Rathke  <erack@redhat.com>  [c5ddccf7376c75ad1f1b963c84f39e7bbc5807ae]

        Twice uppercase is one too much
        
        In both cases if ToUpperAsciiOrI18nIsAscii() returned
        bAsciiUpper=true or the pCharClass->uppercase() was executed and
        its CharClass locale differs from ScGlobal::getCharClass(), the
        ScGlobal::getCharClass().uppercase() was executed after. If
        pCharClass has the same locale as ScGlobal::getCharClass()
        (mbCharClassesDiffer==false) that was executed once. In any case
        the result is a ScGlobal::getCharClass() locale's uppercase. Do
        that only once.
        
        Change-Id: I1928b73b35b50068f96d809d9fa0734ec80a446d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136353
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-24  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a761a51d9db3a2771ca9fd6ab233c513aa5d8ecf]

        tdf#149311 PPTX export: fix internal hyperlink on texts
        
        by converting "Slide [digits]" URLs to slide[digits].xml
        
        See also commit 4142d728f003166ebe520bfdaf672505e585b807
        "tdf#149314 PPTX import: fix internal hyperlink on texts".
        
        Change-Id: I39e095c960b04e728b3e28fa0a657d37d9c71ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135250
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-24  Nathan Pratta Teodosio  <nathan.teodosio@canonical.com>  [ad1ffc62e40c2409b610dfff25a8483b1f2556ad]

        Follow-up for Poppler 22.06 update
        
        Change-Id: I8ee9f1a53cc4389e6a4d44e9765b478b5edfffd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136342
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [4340a47a41aa4bdf75538de451f4a04362b7e840]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a93d6a4ae5adb871cbd7cd54f4cc71fed63e27e
          - Fix (BIN|OCT|DEC|HEX)2(BIN|OCT|DEC|HEX) to mention string arguments
            
            ... and return types, and also fix the conceptually incorrect examples
            
            Change-Id: I9953d546c0c6ee8f224b866643f6975e538f44f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136378
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [5f09ac9e4c88377da068ea4d8c145487bba19f24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9a5b8988ad5e005b3a92038d51c6b07c44b7b79c
          - Document new ExportRangeToFile method of the Calc service
            
            This patch also clarifies the use of single quotes in sheet names.
            
            Change-Id: I6a0f3b62b74d7443144d7957ae5478196580bec8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136120
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [08489c211a902398c5f49c4f4676184b1657694c]

        almost nobody is using the oox::AttributeList::get methods properly
        
        Most of the call sites just ignore the fact that we are returning an
        optional value here.
        Which means that when an attribute is missing, they get an empty string
        or zero.
        And we seem to be fine with that.
        
        So make a plugin that warns about calling value() on a temporay OptValue.
        
        And add a utility method so we don't have to pay the cost of passing
        a default value to getString()
        
        The need for this is driven by wanting to change to std::optional, which
        will throw an exception if code attempts to read an empty std::optional
        
        Change-Id: Idb0a5ad1eac66b5caa93d6195928bad9e0b2ad70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [66365b89f6f335e62db690add57482e91418c7d2]

        sw: fix crash in SwLayoutFrame::GetContentPos
        
        FindPageFrame might return nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/SwLayoutFrame::GetContentPos(Point%20&,bool,bool,SwCursorMoveState%20*,bool)
        
        Change-Id: Ic69d26de4ab234ebd6283ace640d689f0ebe8eb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136307
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-24  Caolán McNamara  <caolanm@redhat.com>  [01fac859a5a2a5e65baca8052456ab7ae5bd95d7]

        can pass by ref without nullptr check
        
        as a follow up change
        
        Change-Id: I5251841618b154f14a2931bf5e65097e9b1bbfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136306
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-24  Caolán McNamara  <caolanm@redhat.com>  [79d13cbd68421df1d4938525e46600ae42642cab]

        crashtesting: forum-mso-en-13233.xlsx exports duplicate grouped-by attributes
        
        there is a warning that "there should be no NumGroup and Group at the
        same field", here just prefer Group to Numgroup if both are present.
        
        Change-Id: If887f865ca2f1e4c6467a6f7d879c15dd55ab244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136305
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-24  Caolán McNamara  <caolanm@redhat.com>  [500a64964ad0f22bb11ff494430c70a069659ec6]

        tdf#149609 release mouse before showing popups from calc grid window
        
        If we capture the mouse in the course of the mouse down handler, then
        release it before showing a popup to undo any unhelpful seleng capture.
        
        Change-Id: I94ead6b516c2b2a019030e0e04760f8e07ff35d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [522f5ad4d8c92624fffa869143aa869662a48589]

        tdf#147529 - BASIC MsgBox: Check for missing optional parameters
        
        Change-Id: Iecb47e0005c609ee1117d6fb141e810c0166806a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136339
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-06-24  László Németh  <nemeth@numbertext.org>  [2413f213625253a9c2b1787b3b9fe859d724a9bd]

        tdf#115523 sw_redlinenum: show correct, also original numbering
        
        in Show Changes mode, according to the name "Show Changes" and
        according to the interoperability requirements.
        
        Instead of the fake numbering which counted the deleted list items
        in Show Changes mode, e.g.:
        
        "3. This was the third originally, but now it's the second list item."
        
        now show the correct number followed by the original number within braces:
        
        "2.[3.] This was the third originally, but now it's the second list item."
        
        Note: the tabulators after the longer numbering are replaced with spaces
        to avoid messy indentation in Show Changes mode.
        
        New enum values for the alternative lists:
        
        SwListRedlineType::SHOW     - the original (fake) numbering in Show Changes mode
        SwListRedlineType::HIDDEN   - the original numbering of Hide Changes mode, and
                                      new numbering in Show Changes mode
        SwListRedlineType::ORIGTEXT - the new numbering of Show Changes mode to show
                                      the original numbering of the deleted or inserted list items
        
        Follow-up to commit c180c9447256588fe5e7991e06642883574760ae
        "sw_redlinehide_3: add second SwNodeNum to SwTextNode".
        
        Change-Id: Ieaca550561c5d5a7ac5d9defb9c7fa283d6aa674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136313
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-24  Luboš Luňák  <l.lunak@collabora.com>  [9e170a35eebbe86e6137510bc8ea34e5a45dbd8d]

        handle nullptr SharedString in ScQueryEvaluator (tdf#149679)
        
        This may be the case if the string comes from ScMatrix::Get()
        for ScMatValType::Empty.
        
        Change-Id: I35013449611bf7ffd1bc74e023d76597af010724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136347
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2df577b1a89d153da78b6c333e741082cf969086]

        loplugin:moveit
        
        Change-Id: If1e6428285bdc5631cebc1acfcb850ac0df6d94d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136300
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [adc536e9efc77690df62177aa722f9252bdbf96b]

        tdf#128150 Properly show/hide widgets when "use slide background" is selected
        
        And cleanup the logic a bit
        
        Change-Id: I9d866fd63ea622ac5eb706185b3277c21f40d7cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136301
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-24  Mahdyar M. M. Sadeghi  <mahd107@yahoo.co.uk>  [073b1aeb8c02500b8cf8844a1ac774a693e0d39f]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I8d42e4873a5cce88f2d8c3a471894c4b990890ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136289
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-06-24  Miklos Vajna  <vmiklos@collabora.com>  [7e134e4e80ce609aeaccd2fe0d61c34d5891804c]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I8d621a735cb269d9d3ab425351af7b2b7052a3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136349
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-24  Stephan Bergmann  <sbergman@redhat.com>  [ab627d300d0346d1f55b15687b56bdd8df3e2116]

        Let rtl_[u]stringbuffer_insert throw std::bad_alloc on overflow
        
        Prior to a95c585433246813096e8890b7ed6ef4fe30c621 "Pump XInputStream into an
        SvMemoryStream rather than an OStringBuffer", this change would have caused
        
        > $ truncate -s 3G test.xml
        > $ instdir/program/soffice test.xml
        
        to open an effectively empty draw document (after apparently catching the
        std::bad_alloc now thrown from within OrcusFormatDetect::detect; see that
        commit's commit message for details) rather than crashing.  This works because
        rtl_[u]stringbuffer_insert happen not to be decorated with SAL_THROW_EXTERN_C().
        But even if they were (or when they are called from an external C program), it
        wouldn't be worse to let the process terminate due to the unexpected C++
        std::bad_alloc exception than to let it crash due to an overflown signed integer
        computation and out-of-bounds memory write.
        
        Change-Id: I21e353367e2b978e8893a2886ac875367a75abd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136352
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-24  Eike Rathke  <erack@redhat.com>  [a7c9101b1a932c0d481dd3d39108a26548895be6]

        Avoid i18n uppercase overhead also for OOXML
        
        Change-Id: I0f5bdbac95bd764ce6d15f87d41717334b401ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136354
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-23  Stephan Bergmann  <sbergman@redhat.com>  [9e83d35c4a22bcb465f0736dda9b752b29f83959]

        Make CppunitTest_svgio CPPUNIT_TEST_NAME=Test::testCssClassRedefinition robust
        
        That recently introduced test systematically failed on my Fedora 36 machine with
        
        > /home/sbergman/lo2/core/test/source/xmltesttools.cxx:89:(anonymous namespace)::Test::testCssClassRedefinition
        > equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        > - In <>, XPath '/primitive2D/transform/textsimpleportion[1]' number of nodes is incorrect
        
        because the dumped data was
        
        > <?xml version="1.0" encoding="UTF-8"?>
        > <primitive2D>
        >  <transform xy11="26" xy12="0" xy13="0" xy21="0" xy22="26" xy23="0" xy31="0" xy32="0" xy33="1">
        >   <mask>
        >    <polypolygon height="100" width="50" minx="0" miny="0" maxx="50" maxy="100" path="m0 0h50v100h-50z">
        >     <polygon>
        >      <point x="0" y="0"/>
        >      <point x="50" y="0"/>
        >      <point x="50" y="100"/>
        >      <point x="0" y="100"/>
        >     </polygon>
        >    </polypolygon>
        >    <textsimpleportion width="16" height="16" x="20" y="20" text="test" fontcolor="#ff0000" familyname="Sans"/>
        >   </mask>
        >  </transform>
        > </primitive2D>
        
        rather than the expected
        
        > <?xml version="1.0" encoding="UTF-8"?>
        > <primitive2D>
        >  <transform xy11="26" xy12="0" xy13="0" xy21="0" xy22="26" xy23="0" xy31="0" xy32="0" xy33="1">
        >   <textsimpleportion width="16" height="16" x="20" y="20" text="test" fontcolor="#ff0000" familyname="Sans"/>
        >   <hiddengeometry>
        >    <polygonhairline color="#000000">
        >     <polygon>0,0 50,0 50,100 0,100</polygon>
        >    </polygonhairline>
        >   </hiddengeometry>
        >  </transform>
        > </primitive2D>
        
        because in SvgSvgNode::decomposeSvgNode (svgio/source/svgreader/svgsvgnode.cxx)
        aSvgCanvasRange = 50x100@(0,0) vs. aContentRange = 31x11@(20,9) did not match
        the
        
        >                         if(aSvgCanvasRange.isInside(aContentRange))
        
        branch ("no clip needed, but an invisible HiddenGeometryPrimitive2D...") but
        rather the
        
        >                         else if(aSvgCanvasRange.overlaps(aContentRange))
        
        branch ("Clip is necessary") introducing the additional <mask> element.  The
        size of aContentRange (and thus whether it is contained in or merely overlaps
        aSvgCanvasRange) is apparently affected by what actual font gets substituted for
        "Sans" in any given environment.
        
        The only font that is guaranteed to always be available and is not subject to
        --with-fonts (which isn't already demanded via gb_CppunitTest_use_more_fonts in
        svgio/CppunitTest_svgio.mk) appears to be "Open Symbol" (cf.
        extras/Package_fonts.mk), so use that (even if it doesn't have glyphs for the
        given text, but which should be irrelevant for this test).
        
        Change-Id: If6f6fdc481b313aa08803b4b3f406e01ff0be1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136350
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-23  Luboš Luňák  <l.lunak@collabora.com>  [b901fd3b27191d5565376c5a708da43a2ac0f6ee]

        no need to explicitly spell out bodies of default functions
        
        Change-Id: I7ed48c3f1005a0efe42d5378ed25e57ae63dd712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136346
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-23  Caolán McNamara  <caolanm@redhat.com>  [d4eee72ea39f02ad8a63a592feb3553771bf9bbe]

        ofz#48264 Timeout
        
        Change-Id: I5028fd192cda7741a51d5d4ff8913214e8c56a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4eeb12bb83d5d90eadd14ab5e57950613fcc5fc3]

        Removed duplicated include
        
        Change-Id: I1bf4b53e07cd8f0e3311620242d012c1ea1956e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136312
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [535cdff8127426ce8accdb6049f90b6b2fd754a2]

        tdf#149655 Crash: "Helplines while moving" crashes debug-build
        
        regression from
            commit a447b5b6d1114111c92e5e3e3f3ae83d4c2f3bca
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jun 13 18:46:45 2022 +0200
            loplugin:moveit
        
        calling std::move() on an otl::cow_wrapper apparently leaves it in a
        state where calling anything else on it will SIGSEGV.
        
        Change-Id: I00d53a6283f360e3d64c81f5e79075c8ac5a99e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [41e6e40d7280b4ccf373c93718c2c66e15444781]

        clang-tidy modernize-pass-by-value in lotuswordpro
        
        Change-Id: Ia20d653bdfedf49430f8ba46c8200c2b96734d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [74ff1a4355090c227f4bdcdddb20482a4abd6064]

        clang-tidy modernize-pass-by-value in package
        
        Change-Id: Id12d7b38d278c9fb18b30c6d921713a53168b048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7c2f6b37a834a3135e3683f1fc27f3ec938640c]

        clang-tidy modernize-pass-by-value in scripting
        
        Change-Id: I95e2a391a984905cac5cbf3f1bb640e1157fafd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Stephan Bergmann  <sbergman@redhat.com>  [5bb5763e2f208cddd114fe96466bdfa2ed3bdbf3]

        Silence another unhelpful loplugin:redundantfcast
        
        ...after 37ec4442d70339dc8ec5fb8e4ec8984420b6e14d "o3tl: ensure that the
        initializer of enumarray contains enough elements", in Windows-only code
        
        Change-Id: I1373a5d777240104d88a892bcf048acf3e7392fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-23  Caolán McNamara  <caolanm@redhat.com>  [05cd9a73542f0865639711e808771385ca835e66]

        crashtesting: assert on loading forum-mso-en-11942.docx
        
        with getToken index past end
        
        Change-Id: I9bfeb9cacd8ad89de8008d37c88d15350ef84fb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136340
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-23  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [a564dcff859e817015a87825cea3ad29b2d370ba]

        tdf#149650 avoid potential recursion with SdrPage content hierarchy
        
        Change-Id: I27e064eeedfb45a2fe96892f1d31da94b9976c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136303
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-06-23  Tünde Tóth  <toth.tunde@nisz.hu>  [18cc891483fef63ad168273658a30bff72b87a95]

        tdf#149401 show "Restart LibreOffice" dialog changing AutoRecovery
        
        Changing "Save Autorecovery... information every ... minutes"
        option in Tools->Options...->Load/Save->General shows that
        dialog window to warn about its work.
        
        Change-Id: I91ae72ea1e52ec5c6d9286a43cd986386636076c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135221
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-23  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4142d728f003166ebe520bfdaf672505e585b807]

        tdf#149314 PPTX import: fix internal hyperlink in editor
        
        Hyperlinks on text weren't imported correctly if the linked
        slides have default slide name, resulting broken links
        in the editor (hyperlinks work well in slide shows without
        this fix, too).
        
        Change-Id: I797fa94134c1346bc83729c713e65b2a268a14c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135245
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-23  Caolán McNamara  <caolanm@redhat.com>  [05299b4205fa0960c3b2ed55a8c4963ee76238be]

        crashtesting: assert in rtl_uString_iterateCodePoints with forum-en-32401.ods
        
        probably since:
        
        commit 78b7e5f76e72647e0cab662ad2c9342d4538704f
        Date:   Thu Nov 23 18:21:19 2017 +0100
        
            tdf#97198 Make Calc function SEARCH work with UniCode non-BMP characters.
        
        Change-Id: I538c034820e606ba4397f42567dd3087f14129fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136296
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-23  Tibor Nagy  <nagy.tibor2@nisz.hu>  [db39e5359d7f9b4e42c6101dd75bc5e8d809ad41]

        tdf#149126 fix export of PPTX preset shapes
        
        Follow-up to commit 63cd67e5e18f01aca303131e148c80398a181a41
        "tdf#92525 tdf#142398: fix export of simple custom shapes" and
        commit 744e6c0b758fefe6011f09860b44f03ab70fbcfe
        "tdf#147459 PPTX: add "glue points" to some basic shapes".
        
        Thanks to Regina Henschel for the code pointer.
        
        Change-Id: I378ffffc2ba09fcffcaa4e5dcf74bfd19e9f704d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135361
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-23  Attila Szűcs  <szucs.attila3@nisz.hu>  [12fd3f7ba73d2fd03b88513160545fab8edc8a20]

        tdf#149574 sc: fix missing nullptr check
        
        Regression from commit 605b4ba57b2daa447af9d43d3759079e15df8148
        "tdf#43958 sc: fix fill by selecting merged cell".
        
        Check if GetPattern(actual cell) is not nullptr, before using it.
        This is not the real problem of Bug 149574, but it is a problem
        anyway, and it fixes this bug. The real problem is the wrong
        ViewData::nTabNo, that point to an already deleted table,
        (fixed in 954d119db932434dc976ef739c643be0d9c7023c
        "tdf#149502 sc: crash fix: Change in Table destruction").
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I26fc629ccf354c9e0c2662d61254d01be91d08f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136230
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-23  Attila Szűcs  <szucs.attila3@nisz.hu>  [954d119db932434dc976ef739c643be0d9c7023c]

        tdf#149502 sc: crash fix: Change in Table destruction
        
        Postpone ScTable destruction a bit, when ScTable::nTab is synchronized
        with ScDocument::maTabs[] to avoid crashing.
        
        Before the fix random crashing occurred if the ScTable::nTab was
        already updated when ~ScTable() called, but the ScDocument::maTabs[]
        was not reordered yet, so nTab could have pointed to the actually
        deleted table in mTabs[].
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I2ac1450e3483ab334b4e20ac2598c2191e0135c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136284
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-23  Stephan Bergmann  <sbergman@redhat.com>  [a2fad16357309f1eba4346dc826bc5ad7012b1aa]

        external/pdfium: Adapt bundled abseil-cpp to Clang 15 trunk change
        
        ...<https://github.com/llvm/llvm-project/commit/5ea341d7c4f9cc4933adc04ff74d59e26ad2f306>
        "[clang] Fix trivially copyable for copy constructor and copy assignment
        operator", which caused my build on Windows with clang-cl against the MSVC
        standard library to fail with
        
        > In file included from workdir/UnpackedTarball/pdfium/core/fxge/win32/cgdi_plus_ext.cpp:19:
        > In file included from workdir/UnpackedTarball/pdfium\core/fxcrt/fx_string.h:14:
        > In file included from workdir/UnpackedTarball/pdfium\core/fxcrt/bytestring.h:23:
        > In file included from workdir/UnpackedTarball/pdfium\core/fxcrt/string_view_template.h:18:
        > In file included from workdir/UnpackedTarball/pdfium\third_party/abseil-cpp/absl/types/optional.h:39:
        > In file included from workdir/UnpackedTarball/pdfium/third_party/abseil-cpp\absl/utility/utility.h:51:
        > workdir/UnpackedTarball/pdfium/third_party/abseil-cpp\absl/meta/type_traits.h(501,3): error: static_assert failed due to requirement 'compliant || std::is_trivially_copy_assignable<std::pair<unsigned long long, unsigned long long>>::value' "Not compliant with std::is_trivially_copy_assignable; Standard: false, Implementation: true"
        >   static_assert(compliant || std::is_trivially_copy_assignable<T>::value,
        >   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/pdfium/third_party/abseil-cpp\absl/types/internal/optional.h(175,21): note: in instantiation of template class 'absl::is_trivially_copy_assignable<std::pair<unsigned long long, unsigned long long>>' requested here
        >               absl::is_trivially_copy_assignable<typename std::remove_cv<
        >                     ^
        > workdir/UnpackedTarball/pdfium\third_party/abseil-cpp/absl/types/optional.h(119,45): note: in instantiation of default argument for 'optional_data<std::pair<unsigned long long, unsigned long long>>' required here
        > class optional : private optional_internal::optional_data<T>,
        >                                             ^~~~~~~~~~~~~~~~
        > workdir/UnpackedTarball/pdfium/core/fxge/win32/cgdi_plus_ext.cpp(384,43): note: in instantiation of template class 'absl::optional<std::pair<unsigned long long, unsigned long long>>' requested here
        > absl::optional<std::pair<size_t, size_t>> IsSmallTriangle(
        >                                           ^
        
        because the behavior of Clang's built-in __has_trivial_assign no longer matches
        the behavior of std::is_trivially_copy_assignable for std::pair, which in MSVC
        happens to be implemented with a deleted copy assignment op
        
        >     pair& operator=(const volatile pair&) = delete;
        
        in
        c:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.32.31326/include/utility.
        
        (See the comments starting at <https://reviews.llvm.org/D127593#3596601>
        "[clang] Fix trivially copyable for copy constructor and copy assignment
        operator" for further details.)
        
        The easiest workaround appears to be to switch the implementation of
        absl::is_trivially_copy_assignable from __has_trivial_assign to
        std::is_trivially_copy_assignable, which should always be available in our
        C++17-based toolchain baselines.
        
        Change-Id: I5d9c3c4fd95852e57d93b56752b7e64d6d71d153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-23  Miklos Vajna  <vmiklos@collabora.com>  [74d545ee8e4f8c9a1317decd3352ce97e0e24913]

        lingucomponent: use comphelper::makePropertyValue() in languagetoolimp
        
        This allows giving aColor an actual type.
        
        Change-Id: If51ec4028b712166094c3f24a2e1d7643ff0136d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136295
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-23  Nathan Pratta Teodosio  <nathan.teodosio@canonical.com>  [0d0469b4302dfe95b016a6f04b145834b79d5ed3]

        Update for Poppler 22.06
        
        Change-Id: I8ee9f1a53cc4389e6a4d44e9765b478b5edfffd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136261
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [351c25e9bc882c65746720fe4ada286d39aab1c5]

        Fix typo
        
        Change-Id: I0482fc4379beb51495e1450a51a0e28f9b324299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136150
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-23  Julien Nabet  <serval2412@yahoo.fr>  [b6dfa2b7472a55b92de95732a0067c3a2f586c51]

        tdf#149615: "No list" twice in Outline & Style tab (non English UI only)
        
        Change-Id: I8a983b62175ed00ca8817556bd3e55fc87ddc9d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136110
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [46129115aa507609f97058fcf6f00786718b8c68]

        uitest: remove print
        
        Change-Id: Idce371f8f7bf1c2bb46616c21c16afee6c10cedc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136293
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-23  Jean-Pierre Ledure  <jp@ledure.be>  [30a6bf3960c37124c9c3cdbaec4794153e24c83a]

        ScriptForge - (SF_String) FIX Unquote() with "'" as quoting char
        
        The quoting character (2nd argument of the method)
        can be the single or the double quote.
        
        The single quote was erroneously ignored.
        
        Additionally comments are added in the code
        about non-symmetrical escaping approaches:
        	"" or \'
        (maybe to be added in help texts ?)
        
        Commit to push to libreoffice-7-4 branch too.
        
        Change-Id: Ifd8f66ee9e60310fdc292aa0f338e88d941b2e21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136292
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-06-23  Mike Kaganski  <mike.kaganski@collabora.com>  [69647b59544a072c78504e88af94c8ee1dd5de0a]

        Copypasta
        
        Change-Id: I9bf9b042c885a2546dc7a1425e49e6171711c0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136299
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5491a82854e3e6dd2dbb4b0012cb4bbeb4ee22e0]

        tdf#128150 Disable UseSlideBackground item when setting style back to None
        
        from Sidebar
        
        Change-Id: I883330ac7323c4758ca8cbd46f4567a2ea780fc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136290
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [26fbf6eef19e2746c28d2f1584505d5e10a295cc]

        clang-tidy modernize-pass-by-value in formula
        
        Change-Id: I275f96bb8b24838538ac88532508ad7dbd127eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Stephan Bergmann  <sbergman@redhat.com>  [a95c585433246813096e8890b7ed6ef4fe30c621]

        Pump XInputStream into an SvMemoryStream rather than an OStringBuffer
        
        ...to avoid overflow with streams >= 2^31 bytes.  This should fix
        <https://crashreport.libreoffice.org/stats/crash_details/d9613c81-de37-4de2-8c64-e36634d10ddc>
        which I could reproduce with a recent master Linux build with
        
        > $ truncate -s 3G test.xml
        > $ instdir/program/soffice test.xml
        
        causing a SIGSEGV at
        
        > #0  0x00007ffff7f193a0 in rtl::str::stringbuffer_insert<_rtl_String, char>(_rtl_String**, int*, int, char const*, int) (ppThis=0x7fffffffb330, capacity=<optimized out>, offset=2147479552, pStr=0x20a92e8 "", len=4096) at sal/rtl/strtmpl.hxx:1424
        > #1  0x00007fffb6af04e5 in rtl::OStringBuffer::append(char const*, int) (len=4096, str=<optimized out>, this=0x7fffffffb330) at include/rtl/strbuf.hxx:594
        > #2  (anonymous namespace)::OrcusFormatDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (this=<optimized out>, rMediaDescSeq=<optimized out>) at sc/source/filter/orcus/filterdetect.cxx:80
        [...]
        
        (Ideally, orcus::detect would only need a short prefix of the stream's content,
        but the implementation in
        workdir/UnpackedTarball/liborcus/src/liborcus/format_detection.cpp delegates to
        functions like orcus_ods::detect in
        workdir/UnpackedTarball/liborcus/src/liborcus/orcus_ods.cpp, which passes the
        content through some zip_archive that presumably needs the full content.)
        
        Change-Id: Ifaa37ee887d8296cbcf971313bde347ddfb17c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136297
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cac364376785bfc82fabf7f9ae82c94d3b2825f]

        clang-tidy modernize-pass-by-value in l10ntools
        
        Change-Id: Icf07a0f3784f0f39fa6b141a24aa25fddab71901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136272
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [154cffd87ee4a21b5c0c291f84c95d74cde2a143]

        clang-tidy modernize-pass-by-value in libreofficekit
        
        Change-Id: I1a6b4eb804a8cc4eb5e67ae4bbf8f31863f323d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136273
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-23  Stephan Bergmann  <sbergman@redhat.com>  [07295115f5742e0d06a21d280610903ad55a75f0]

        Revert "svp: don't directly yield in main thread"
        
        This reverts commit d2de55c93f94bbccff51fa7715b613341f1f4ae6 for now, because it
        appears to have caused a massive uptick in hung UITest_impress_tests
        (sd/qa/uitest/impress_tests/save_readonly_with_password.py, line 95) and
        UITest_writer_test6 (sw/qa/uitest/writer_tests6/save_readonly_with_password.py,
        line 54) tests across Jenkins, see the comments starting at
        <https://gerrit.libreoffice.org/c/core/+/117900/8#message-e439f5f2b9ed7a24d6f47fd640defe14dc392eb5>
        "svp: don't directly yield in main thread".
        
        Change-Id: Id114a0d904580024352e4acf37e2558f9f0ae6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136250
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1eaf11278a2f2f81fbff774fef73f72a6b1a4efb]

        fix build --with-help
        
        after
            commit 966d9757de471f2a5ea1ffa87cef019dcf1e0cb3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Jun 21 09:05:15 2022 +0200
            clang-tidy modernize-pass-by-value in helpcompiler
        
        Change-Id: Ie7c47d950287d96020857589f826b063e0912df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-22  Mike Kaganski  <mike.kaganski@collabora.com>  [424a293664cbdffcceaa79756d59bb2d29080613]

        Re-enable the test
        
        After commit 7d5dcf5f547e29d61e788b88f7a3f7b4feafb6b2
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Wed Jun 22 16:22:50 2022 +0300
            Fix shape rectangle calculation
        
        the test should not fail anymore, both on macOS, and with
        non-default DPI.
        
        This reverts commit	5c6139ac36134a21345525c21e167a356b0892b9
          Author Caolán McNamara <caolanm@redhat.com>
          Date   Thu Dec 31 19:40:17 2020 +0000
            disable contantly failing test
        
        and commit d0f6c9f924fdbeed4c466e3a6eff7d6980ebc659
          Author Noel Grandin <noel@peralex.com>
          Date   Wed Jan 06 09:22:57 2021 +0200
            exclude more tests for non-default DPI
        
        Change-Id: I8e4b872d8ef0b3e695c7ce0b87598c4a7effe94a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136294
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-22  Caolán McNamara  <caolanm@redhat.com>  [eacd9b08fa9914c674f287b7bdceacf94d93a6ad]

        crashtesting: assert seen with forum-mso-de-53682
        
        not reproducible for me, but appears to be an empty string here
        sometimes.
        
        Change-Id: I8465f178cc7e5a6efdc08c1d15c154eeb2277c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ccf84ce0de2580eadb1407f11707f05fb042a8bd]

        tdf#149204 revert getSeriesNames method to the original behaviour
        
        The VSeriesPlotter::getSeriesNames returned a filtered list of
        series names without the z-axis names, which is not expected from
        the name, so when refactoring the assumption was to return all of
        them names. This wasn't correct and has broken rendering of some
        charts. This change reverts the method to the original behaviour.
        
        Change-Id: I42464495a1a2b68a34efbc8409ae6c1417ff072d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136280
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  Caolán McNamara  <caolanm@redhat.com>  [5bb823073f9df786eb6dbaaec71f572b2059e818]

        crashtesting: assert seen with forum-mso-de-125088
        
        where at restoring the SaveIndex the underlying aLine string had
        been replaced, so the index is for a different string. Save and
        restore the aLine too. Not entirely sure this is what we want,
        but it does seem to be what this restoring code expects.
        
        Change-Id: I25bd02fad72d9b0729b9504fe04416340d0e070a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136286
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-22  Mike Kaganski  <mike.kaganski@collabora.com>  [7d5dcf5f547e29d61e788b88f7a3f7b4feafb6b2]

        Fix shape rectangle calculation
        
        At specific screen resolutions, caused failed CppunitTest_sc_shapetest:
        
          C:/lo/src/core/sc/qa/unit/scshapetest.cxx(169) : error : Assertion
          Test name: sc_apitest::ScShapeTest::testTdf137576_LogicRectInDefaultMeasureline
          assertion failed
          - Expression: std::abs(rExpected.Y() - rActual.Y()) <= nTolerance
          - after reload Y expected 9731 actual 10287 Tolerance 1
        
        which manifested the actual wrong position of shape written into ODF.
        Commit cd966aac6ecd8ce606ac3f2ccd602e467114ba3f
          Author Regina Henschel <rb.henschel@t-online.de>
          Date   Fri Dec 25 19:27:51 2020 +0100
            tdf#137033 improve save of cell anchored shapes
        
        had corrected the calculation of anchor point, but the overlook was
        that in some cases of non-transformed shapes, rMyCell.maCellAddress
        may differ from pObjData->maStart. Since aSnapStartAddress could be
        not set to pObjData->maStart for such shapes, the wrong cell range
        could be calculated for resized-with-cell objects.
        
        Fix this by using pObjData->maStart whenever there is pObjData. If
        it turns out that in some cases, rMyCell.maCellAddress is needed in
        calculations before the 'if (rShape.bResizeWithCell && pObjData)',
        aSnapStartAddress should be assigned to pObjData->maStart after the
        check.
        
        Change-Id: I7e0dc834c2ffb147430fb5b2cb8bdb4dca201b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136285
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-22  Michael Stahl  <michael.stahl@allotropia.de>  [81273c65dd9cec5acd9464b9041f452a5481e10e]

        tdf#134759 sw: do CopyToModify() for both start and end node
        
        ... in SwNodes::MoveRange().
        
        SwRangeRedline::Hide() does CopyToSection()/DelCopyOfSection() so the
        previous commit fixed it, and SwRangeRedline::Show() does
        MoveFromSection() so hopefully this should fix it to restore the
        situation before hiding.
        
        This caused several tests to fail, and the reason appears to be that
        they pretty much tested exactly the problem that's being fixed with this
        commit, but the pre-existing fixes and the new one cancel each other
        out.
        
        In all cases the pre-exising fix moves all redlines and moves them back
        again, which is the sort of thing that sw_redlinehide wanted to get rid
        of; not sure why i didn't notice this earlier.
        
        The check for the 3rd paragraph where the style was applied still
        succeeds with the new bugfix, but the one for the 1st paragraph fails;
        it is unclear why applying a style to the 3rd paragraph should have an
        effect on the 1st one.
        
        Hence:
        
        Revert code changes of commit 1d65ffc5a37be21e0316019b1c96eb9a1c871ac0
        "tdf#105413 track changes: keep paragraph styles"
        
        Revert code changes of commit d97fc64a819f834302e384792668507df4cc412c
        "tdf#122893 track changes: keep paragraph alignment"
        
        Revert code changes of commit 6a54dd844d1821165642bbcc16bd12a01a23393d
        "tdf#122901 track changes: keep paragraph top and bottom borders"
        
        Change-Id: I0b70134902a7993c7bb11a3c619e45742764c8ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136056
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [575cfa6aebbea714f08e303a3e78d1ac8d99a7e0]

        tdf#69750: sc: Add UItest
        
        Change-Id: I4039da64a069af74046f95abacd3476122d9a542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136232
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a9df32c1f693fb79a6b8b4518cefe9ab5db4e03c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 893489db23d56977dbc9f775ffdad9f83a5cde40
          - combine switch and switchinline template rules
            
            Change-Id: I4436c0da1b0443ab9e699aac75122368db8ab5a5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136198
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ecfb133598df609037263e06949acbbf520622b3]

        tdf#128150 Adapt sidebar to new "use slide background" property
        
        Change-Id: Idce049a7498f98b0079c708236cfeff7fddd6e95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135963
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f820cd30b3014c72f6711d80679faa8488ffcda]

        sw: fix crash in SwEditWin::MouseButtonDown
        
        Since GetPageAtPos might return nullptr
        
        See https://crashreport.libreoffice.org/stats/signature/SwEditWin::MouseButtonDown(MouseEvent%20const%20&)
        
        Change-Id: I4ad3492ef46bcd7b263a4de92efd9439a966fb56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136279
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-22  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [df3942bba54e5588020082e0197b233d0f043282]

        Revert changes to android/mobile-config.py
        
        made in 157298bb808a943616991927f9370a86c1f2ca48
        
        Got Tinderbox failure with
        
        Traceback (most recent call last):
          File "/opt/rh/rh-python36/root/usr/lib64/python3.6/xml/etree/ElementPath.py",
        line 263, in iterfind
            selector = _cache[cache_key]
        KeyError: ('%(component-schema)s[@%(name)s="Common"]/component/group[@%(name)s=
        "Filter"]/group[@%(name)s="Microsoft"]/group[@{http://openoffice.org/2001/registry}
        name="Import"]/prop', None)
        
        During handling of the above exception, another exception occurred:
        
        Traceback (most recent call last):
          File "/tinderbox/buildslave/source/libo-master/android/mobile-config.py",
        line 85, in <module>
            props = root.findall(microsoftImport)
          File "/opt/rh/rh-python36/root/usr/lib64/python3.6/xml/etree/ElementPath.py",
        line 304, in findall
            return list(iterfind(elem, path, namespaces))
          File "/opt/rh/rh-python36/root/usr/lib64/python3.6/xml/etree/ElementPath.py",
        line 277, in iterfind
            selector.append(ops[token[0]](next, token))
        KeyError: '('
        
        Change-Id: I34a770a342417fcbfb9689e3adc4b495d5bd5fe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136282
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [a3953061b66e8dcdd799109974e7175de311a356]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccf60dc3e77793c242a6188fe18e4faa7f2aa469
          - Document new properties of the SF_UI service
            
            This patch documents the following new properties in the UI service of the ScripfForge library: Height, Width, X and Y
            
            Change-Id: Ie15844c0688c9dbf22146a2e2ea5a8690b1c005a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136169
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [0f57d53f4339a5f39df5ae5d304d5216193d7d1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d0868a21f3789d2a73bfbcd4830b3b8ae4648087
          - Document ExportFilters / ImportFilters in SF_Document
            
            Change-Id: I63469ce9a6ea479f31f98612b0919bbca034e3a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136168
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-22  Stephan Bergmann  <sbergman@redhat.com>  [99ecc9732d44d528733e77c361c206ca3b121f99]

        Remove a dumpAsXml that looks like a debugging leftover
        
        ...left behind by d4123356c61db269651e950a0a2cc93e6d801c90 "RTF filter: allow
        measuring page borders from the edge of the page"
        
        Change-Id: Ib97061746e8f4ba988af7c7520b1e7e0c3e6cdce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136276
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-22  offtkp  <parisoplop@gmail.com>  [56bfb93d0028b735adaddd7d23be96145a7bd2ed]

        Detect WMF from header instead of extension
        
        Change ImpDetectWMF function to detect a WMF file
        from its header instead of just comparing the extension.
        
        Change-Id: I5a31cfd52b5425ab94424c2edce842365db04e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134876
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  offtkp  <parisoplop@gmail.com>  [eedc5b1c576fcaaea85a5278762efc8ba8c5a084]

        tdf#149449 Add unit test for CSS class redefinition inside SVGs
        
        Tests what happens when a CSS class is redefined with new attributes
        and with already defined attributes
        
        Change-Id: I5996fa4dce6c98c1792001a11387bf570d159a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136151
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  offtkp  <parisoplop@gmail.com>  [99f8e8aa0ccb741c2b5ede6cab75798c1793d899]

        tdf#149449 Don't ignore CSS class redefinition inside SVGs
        
        Previously if a css class was redefined like so:
        
        .cls2,.cls3{fill:#fff;}.cls-2{opacity:0.1;}
        
        the second definition of .cls-2 would get ignored and opacity would
        remain 1.
        
        This patch keeps track of the names of each previously defined class and
        makes sure to append the future redefinition instead of ignoring it.
        
        Change-Id: I20b55aea247d11774cd743505a90f1466f622b1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136109
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  offtkp  <parisoplop@gmail.com>  [29252e78627db79662d89919f77746824c6563c3]

        Add support for exporting SVGZ in Writer
        
        When exporting a graphic through Writer, graphicfilters ExportGraphic
        is called, which didn't have SVGZ exporting functionality before this
        commit. With this commit a valid Z compressed SVG file is exported,
        using the functionality that already exists in ExportGraphic.
        
        Change-Id: I6c7476ca78a8cb3719488ac4d8a5942e0557ed36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136094
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  offtkp  <parisoplop@gmail.com>  [9a5d46070e70e8cf42bea0dad37063d9ed71e375]

        tdf#100522 Add support for exporting SVGZ in Draw
        
        Detect draw_svgz_Export and compress the SVG before exporting if needed
        
        Change-Id: I7c8463292ee845a3ce2f2a3c5aa876b25dcedb2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135556
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-22  Lukas  <lukasmolleman@gmail.com>  [157298bb808a943616991927f9370a86c1f2ca48]

        android and bin/update: make pythonic
        
        Change-Id: Iaf791bfa8d9822843b26f2a2f2c3d94c55a60a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133358
        Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-22  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4e9b23cb2356cf7019a6ed81e08abf1664a72051]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e58e8bacdb26bce4eb86485c183f12f87cc3e31
          - Improve SF.exception PythonPrint() method content
            
            APSO extension is optional despite existing explanation
            
            Change-Id: Ib7615996a04dd770d2ec96e6f6066c272074248b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136051
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ab943f5bfa221f04195290149927321bb53f26c5]

        Document SD_DEBUG env var
        
        Change-Id: Ia1a71ba5ff4fcf4196899209f8d85c2975ed8e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136225
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-22  Caolán McNamara  <caolanm@redhat.com>  [257d80b4ab086aae504694d37e43c5b1a7d9a386]

        crashreporting: apparent null derefs of SfxViewFrame::Current()
        
        Change-Id: I0e2c07a7eaa0a13be0a44c7cd187feec8ed4c2c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136277
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-22  Jan-Marek Glogowski  <glogow@fbihome.de>  [d2de55c93f94bbccff51fa7715b613341f1f4ae6]

        svp: don't directly yield in main thread
        
        AKA svp: always release SolarMutex on yield, v2
        
        Implement the TODO when yielding a non-main thread: "use a
        SolarMutexReleaser here and drop the m_bNoYieldLock usage"
        
        This whole concept of "deferred yield" is prone to spurious
        "deadlocks", if DoYield spawns a nested event loop. This will
        not only block one yielding threads, but all indefinitly. And
        not releasing the SolarMutex is also not fair for any other
        threads waiting. That whole m_nNoYieldLock hack is just needed
        to defer GUI processing to the main thread without releasing
        the SolarMutex, the exact opposite of what yielding does.
        
        While we can't do anything for the main thread as long as the
        whole nested event loop concept prevails, we can prevent the
        yielding thread deadlock using conditionals.
        
        With all the special m_nNoYieldLock gone from SvpSalYieldMutex
        there isn't any reason to keep it around.
        
        Change-Id: I87c006ad36b4959f7e0dd18dda99a58c4e25032d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117900
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0feeb94f97332a8e803e1936d66e0f234bd51973]

        rename oox::OptValue::get to value
        
        as a step in replacing OptValue with std::optional
        
        Change-Id: Ia5d05c28a88beaced11ae1d0414de66106cc9e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [813939f8e392feff0b6eeeee1bae023bc9c98849]

        rename oox::OptValue::get(Type) to value_or
        
        as a step towards replacing OptValue with std::optional
        
        Change-Id: Ic4afaca87034b1b794432ee4261a6495058b26fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ff9582704a024b4a89da9a63322e117157b5857]

        make oox::OptValue::assignIfUsed a free function
        
        as a step towards making OptValue into std::optional.
        
        Change-Id: I3eae4034a846dd63a16e501abe4a6eba9d186a49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136266
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9affc204c1d330b2a7873f44b3f575bcccdf4dc]

        remove OptValue(bool,Type) constructor
        
        as a step towards converting it to std::optional
        
        Change-Id: I6f377967f2a495d8c29979444607c991aaaf5d63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136267
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Noel Grandin  <noelgrandin@gmail.com>  [3c6a53b9ce64180b2a03e097c1844f7496f26815]

        improve the look of the macOS combobox
        
        Change-Id: I4484fabcf6d883deeb3e417e46ce3973f2332f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114251
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Mike Kaganski  <mike.kaganski@collabora.com>  [4af2fa2a8be04f2c0070f5d61ac296d3a6ea9c7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a9daf1b47b52f675225f31843b67e186a140845b
          - Numeral systems are "based" on digits, not numbers nor characters
            
            Change-Id: I9c411fe39e81d734d68c9e98253b3d125978f3bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136239
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-22  Mike Kaganski  <mike.kaganski@collabora.com>  [3d71357556b7bddff09c8dc973b2bd0eb8c24e35]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc62afdf93da53b17e1b7859376d01b03292de9c
          - Drop this nonsense
            
            Phrases like this look like an explanation form a clueless person.
            The help should rely on basics (like differentiating text from names),
            and not suggest to "place the number in quotation marks" when the
            argument is documented to be a text. If needed, the word "text" may
            link to a glossary article with syntax explanation.
            
            Change-Id: I32e7a3c68659f74db6bc30c5a3fa9acdd158acb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136238
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7fce4a7d26aa559b0d86ec561348c9adee4efcc]

        replace oox::OptValue::use
        
        with emplace and operator*
        as a step towards converting it to std::optional
        
        Change-Id: I3fca397c7dcfe200962e2b81a423322e29787f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7bcbe333b802b4b44630e0b23897ac8e230bc19b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3fe1af89c370e1cd9058b541cb34f629348c610d
          - Fix typo
            
            Change-Id: I373f0e742157c2d5e7e2af9b34b0d7f38f605e5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136259
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-22  Miklos Vajna  <vmiklos@collabora.com>  [4db394c14edc804444e678e7b590a16634f3c6f5]

        CppunitTest_sw_ooxmlexport16: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I82403120433e69221e3533e371e53b92470f6325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136256
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-22  Stephan Bergmann  <sbergman@redhat.com>  [28597ee6f713baa6833e6e7837faac46ba5c173a]

        Make code a bit more explicit
        
        ...and avoid the ugly unsigned short vs. SvxAdjust mismatch
        
        Change-Id: Ie820b5fda00942d258668535598027f9d878c013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136264
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-22  Eike Rathke  <erack@redhat.com>  [086055b0d7e44d1d07b3f23af55503e6a3924d87]

        Related: tdf#142293 Consider bAsciiUpper for matching CharClass to lowercase
        
        ... as also that may had lead to the locale's uppercase.
        
        Change-Id: I5c75b4e52260539f5b66c0d2195b2137c9b1b8ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136265
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [6b15decd0acc2c7c0622baba65b9d4c019a4183a]

        crashreportScraper: encode the url
        
        Change-Id: I1f738f017966a6fe48dd9e2cf36dbdf5f50c0cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136229
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cbe00c2eea06bc59c4bf3b36fbb5f2d1d2d87ef4]

        Fix typo
        
        Change-Id: I116e7fe8ecc5d9440e537613a55b880512a1706d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136260
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-21  Stephan Bergmann  <sbergman@redhat.com>  [62e2288a9b0b7cef37af432f2f6671c0fded51f5]

        Use proper type for aSvxToUnoAdjust
        
        ...following up on a comment in the commit message of
        37ec4442d70339dc8ec5fb8e4ec8984420b6e14d "o3tl: ensure that the initializer of
        enumarray contains enough elements":  "In sw/source/core/unocore/unosett.cxx
        with its odd mix of saL_Int16 and USHRT_MAX, lets keep things that way for now
        (probably awaiting later clean up) and use casts to avoid the implicit
        narrowing."  The USHRT_MAX values always mapped to -1 when the elements of
        aSvxToUnoAdjust are used to initialize sal_Int16 nINT16 later on, so make that
        explicit here (but an explicit cast from int to sal_Int16 is still needed for
        them, to avoid narrowing failures from within the enumarray ctor).
        
        Change-Id: Ib401ff94c429f8415199a5d35997d17266e04279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136262
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [2bf296ddd10f0a56bdf799712bac1ccb10ed8b72]

        io: drop unnecessary cast
        
        Change-Id: Iaceab1b85e41dbb2102fe829f7abc2f8e3898a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [e02a7a55c23d23dd7afa2627a7e10c70e1cba001]

        registry: remove unnecessary comments
        
        Change-Id: I03b49dcf4bb668b0e4967eb4e88639a5a7e36c8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128174
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1dbfc4fdc9710e670e25bff5636e0336efee8a18]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a5a05714cad12c2205389b98557400c4069304ea
          - Fix bad link
            
            Change-Id: I6470492a640355d98a652183d688684874e843b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136257
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [fb9af884de622cdac23887417ccb32cfd34860c3]

        Refactor PopupMenu::ImplExecute for async support
        
        Splits ImplExecute into PrepareRun, Run and FinishRun.
        
        Change-Id: Ifddb1e968b468c9757eeece0bb19513cc26a9c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125597
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fd6298be955331f64f6f0b2e04675d9914f44e4]

        use SAL_UNLIKELY to make logging a little more efficient
        
        if we have logging compiled into a release build, the most frequent
        logging (e.g. INFO) is typically off, so most of the time, we are not
        going to execute the logging.
        
        Change-Id: I2b464b4153307df8730998728e508cce09d5013b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Jean-Pierre Ledure  <jp@ledure.be>  [7f2464c41adf3e45fe020e87198fb0cb939e6e34]

        ScriptForge - (SF_Calc)FIX wrong sheet name validation
        
        When the name of a sheet contains a "." or a space, when passed
        as an argument, the name must be surrounded with sinle quotes
        (like in usual Calc formulas).
        
        The validation of the sheet name goes thru the comparison with
        the list of existing sheet names in the document.
        
        The comparison compared erroneously the name with quotes and
        sheet name without quotes.
        
        Gave an unjustified user error.
        
        Example:
            calc.Sheet("'Commits 7.4'")
        
        Actual commit should be pushed to LibreOffice 7.4 too.
        
        Change-Id: I1ffd1dc42a0fd4a28fcea87de297c4cb02da6a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136233
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins

2022-06-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [afc828b9833b7a612369e95606ba56d41ef2c369]

        VCL expect correct frame size for native menubars
        
        ... and renove the wrong framesize hack in the Qt backend
        
        This wastes a few additional pixels in the frame backing store,
        actually covered by the real native menu bar, to get rid of all
        the hacks and eventually fix quite a bunch of bugs in Qt (and
        maybe other backends).
        
        This seems to work correct with Qt using either QPainter or Cairo
        as the painting backend. It's much simpler then my previous failed
        attempts to fix the Qt related bugs. I would like to convert every
        implementation to my interpretation of the API (at least I now
        documented the API). It looks like Win and Mac will just work,
        because Win has no native menu bar and Mac uses a global menu,
        so always returns the size of 0. And Gtk also seems to work, if
        it also lies about the menu bar size being zero. That just seems
        consequent, if the frame size is reduced by the menubar size.
        
        This fixes at least:
        tdf#64438 - Dockable panels in LibreOffice not dockable using KDE
        Works.
        
        tdf#130893 - XWindow::SetPosSize resizing based on
          XWindow::GetPosSize shrinks the window
        The document macro from tdf#130841 now doesn't resize the window.
        This is just fixed for Qt.
        
        tdf#134704 - KDE5 - unable to dock sidebar by dragging frame
        not fixed, because the sidebar window is now a dialog, which is
        not dockable. FWIW the same has happend the Navigator (F5), which
        also renders it non-dockable. No idea, if this is intentional.
        
        tdf#137471 - CMIS dialog advances beyond lower right corner of the
          screen
        So commit 3f8d3fd4649ef09e86c735617383a4bda0425540 ("tdf#137471 Qt
        return frame pos + client area size") was really not enought as a
        fix (at least it didn't break anything). The whole parent-based
        repositioning is wrong and it really depends on the correct frame
        size, so I'm keeping this as fixed by this patch.
        
        Change-Id: I7faeace61b456c2b0f42c7a826f58018b70d46ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135082
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [dbaf5f6fad2ec10f69cf46f9cb697b8760c2a01f]

        svp: fix UB SalGraphics vector access
        
        Change-Id: Ic417ffbf91b04ebd6e6f18ac03b155fd01bbb316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136226
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [d48dd6057ecc50dbb31d24adce76aaf27d16db16]

        Correctly free font previews on settings change
        
        Change-Id: I9fdce7c9fb8a18571d3d6a317b28a344f18efa82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136227
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-21  Siddhant Chaudhary  <urssidd@gmail.com>  [9d0ca8ee3f0c2a4e6c0bebec6ef1523cd04e849a]

        tdf#69750 Preserve last used Paste Special options for next session.
        
        This feature stores the Paste Special options for Calc in the LO
        registry for use across sessions, so that users don't have to set
        options everytime they start a new Calc session. A new group named
        "PasteSpecial" has been added in
        `officecfg/registry/schema/org/openoffice/Office/Common.xcs`. The
        function `ScInsertContentsDlg::storeFlagsInRegistry()` has been added,
        which is responsible for storing the state whenever the dialog is closed
        by clicking either the OK button, or one of the four shortcut buttons.
        Also, whenever the dialog is opened for the first time in a new session
        (represented by the `firstLoad` boolean flag), the options are loaded
        from the registry.
        
        Change-Id: Icc879b11feb5bfe32777b6e548d9c0804d93a33e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135110
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [36d3fa20a5e0ebd7d3befd789a6930c777972e8c]

        remove oox::OptValue::set
        
        as a step towards converting it to std::optional
        
        Change-Id: I49db0b13338388c92108fc2c27d8e662dcd954d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6471ea40f7739814264ce8540cdedef28a3cb731]

        remove oox::OptValue::differsFrom
        
        as a step towards converting it to std::optional
        
        Change-Id: I198abb4ae85b1d82f465577ebd0eec37b78c1111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Jim Raykowski  <raykowj@gmail.com>  [b99d5bd8318d7f3fefec4fb3cde609fbfbf88354]

        End listening and clear active shell when the dying shell view is the
        
        active shell view
        
        Corrects listening not being ended. This patch is based on the code
        in SwContentTree::Notify to end listening and clear the active shell
        when the dying shell view is the active shell view.
        
        Change-Id: Ic51e8b5355668e3bd133a8370eeb407694cc9e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135034
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [27e1bc4b2bd7c079dc7e920acd05c707db6b9e34]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ab7e2cf0ecd45c000eb7605c1918265569e52f7
          - tdf#149393 cross-ref DECIMAL <-> BASE functions
            
            Change-Id: I5f8a2e5d93ca0d723a6adfc31aa6cd3fcc7568c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136085
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0aca45d8e767b2a1f11b97354dd6313d56b87aab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ac04d8a56bb3e066ae1157adf05187bfee28824
          - tdf#149352 Add bookmark for selection Help page
            
            Change-Id: I60b56bbca62103a3f5b21d57e2909ebf926e8be0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136086
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [bf35c2b7f4b9fa18e387e2ee8df518303696e13c]

        OUStringBuffer: add append via operator<<(T&&)
        
        ... and use it to implement SalFrame::DumpSetPosSize.
        
        Change-Id: I82301f7e1f6641d6167c9577ce9ef44ef8067297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135808
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-21  Eike Rathke  <erack@redhat.com>  [909cdd552199d35f7c10be0a8be370158aea0815]

        Resolves: tdf#142293 No "+ or - may start formula" when editing content
        
        If it was a formula already it would start with = anyway.
        
        Change-Id: Ib3c0ebcaf99231d387f1aace8e1a5642061de3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136208
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7c49309d0021b0e26c3179dd7adce71431ec7fc]

        clang-tidy modernize-pass-by-value in extensions
        
        Change-Id: I9f31d6ddea3f99ed3334fa00d0f2c8448f9b9583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7778a1a573ad87fae76810ad67e6808b22f63420]

        clang-tidy modernize-pass-by-value in forms
        
        Change-Id: I9b4b8db9872ccc8aeb461e34ceed203af7ea35b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [49fdae5bb4f584d26cea958e554678154bedf379]

        clang-tidy modernize-pass-by-value in io..jvmfwk
        
        Change-Id: I6e19d4d03957c35caa79a231927eae04ae630442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Caolán McNamara  <caolanm@redhat.com>  [8fb6f3d894093c729e8ee304f8b6fb553a7ceac4]

        ofz#48161 Container-overflow
        
        Change-Id: I99a63c3cfa48344221dbe4a7400d313d875abd82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136207
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8487667e65184aa58520aa907fa747a73a08e34]

        rename oox::OptValue::has() to has_value
        
        as a step towards converting it to std::optional
        
        Change-Id: I9b2201c29827fcddae3b46480065c90b2907e6cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [966d9757de471f2a5ea1ffa87cef019dcf1e0cb3]

        clang-tidy modernize-pass-by-value in helpcompiler
        
        Change-Id: Ia074fb5be66486e56af2540a978e72c954485e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [79a279eee1071f2bf855a2681c1706169dd0062e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b48ace599e8c109c4090c178823c6718f78103da
          - make generated help files deterministic/reproducible
            
            generate-id() is only stable within a single invocation, the results
            vary from run to run, causing two builds of the same codebase result in
            different output.
            Due to help including snippets from different files, a simple count
            won't be unique enough, but combining it with the sourcefile's topic-ID
            does the trick.
            
            Change-Id: I2ab8988bc34c9136fcd99d074cf0b189a8f40eb7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136197
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-21  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [499ecbf3a36990c29dc7e1fb9b0ecb1d297c2848]

        Fix crash when no valid EntryDescriptor found
        
        When opening macro run dlg, the last selected entry is displayed again.
        When no entry was found, a crash occured in some situations
        (GetLastEntryDescriptor() returned garbage).
        
        Initialize m_aLastEntryDesc properly, and make sure the method returns
        when no last selected macro was found.
        
        Also fix some nullptr crashes which occurred during UITests
        
        Change-Id: I7bd1a0b8824725f9935876ae26d8222410a3bc25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136140
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-21  Caolán McNamara  <caolanm@redhat.com>  [3f04d692141714259a4c4f1060213cd43804d1db]

        cid#1506304 Uncaught exception
        
        Change-Id: Iaf2563edd5ec038d50c10cd5207eb40339bbb260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136206
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-21  Miklos Vajna  <vmiklos@collabora.com>  [8a5eff74fea46294fb15a2328e59214d11b8d52b]

        basegfx: extend basegfx::B2DHomMatrix::decompose() documentation
        
        decompose() on basegfx::B2DHomMatrix is easier to remember than the
        opposite direction.
        
        Change-Id: Ied534ad2fd00d23bde5caa16cfc22e0d06c6b984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136199
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b3337e50e4480fe385a23a58ddbd6709de714be]

        clang-tidy modernize-pass-by-value in embeddedobj
        
        Change-Id: I5ed8591a3c3ae58d5ddf921814b8d7a373f9c76e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c9d99a5cb2702e478f719bfa8167952293c2793]

        elide some makeStringAndClear() calls
        
        Change-Id: Ie8c04a8c414f32cc0e68fbab1d24a9707f179011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136201
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d30e9e101ae8167c33fe24ca12d8d0685f9f8fb]

        tdf#142293, tdf#141495: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: Icca8f402a960ac9de9a4f4d2c9f8d00f5abd0d37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136188
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [3be3fb9bafc4c2bf17ef3fe4eba0a059199abe24]

        tdf#126109 calc slow when replacing string to number
        
        Normally, the answer to repeated erase(begin()) is to walk backwards
        through the array.
        However, sometimes (like here), doing so will mean that we end up
        inserting at the front of a different array, which means we don't gain
        anything.
        
        So, store an extra field in the mdds block, which implements a kind
        of very simple approximation of a circular array.
        
        This gives me a 50% speedup for this bug.
        
        This is the simplest possible thing that could work.
        It could probably be made a lot more sophisticated in terms of not
        wasting space.
        
        Change-Id: I036349786896f28b617dfd0924f5743db6a57695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-21  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2185eb10147723bbf1b7966f995dc01d64c5e6c8]

        tdf#128150 Only show "Use background" btn in Impress & Draw
        
        Change-Id: I5d14f651af55b51a8a02a8a4ddbb1c0921b15d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136182
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [903403c1e3d5c0f882189fa87ed2b19c16a9893e]

        vcl: rename mnExtraData to mnRendererId
        
        The name "extra data" doesn't really describe what this field does. What
        it actually does it to specify what animation renderer should be used.
        
        Change-Id: I1e705ba89d09ceb41a8649c8947225c7b6816e7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76403
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [a98b0037c6116ed7a0f4f426571bbb361cf2e62f]

        vcl: rename ImplAnimView to AnimationRenderer
        
        An ImplAnimView is actually just a way of rendering an animation to an
        OutputDevice (RenderContext). Each instance has a unique ID (called
        mnExraData, which is quite misleading). ImplAnimView doesn't really
        mean much so hence the rename to make this a bit more clear.
        
        In the process, also rename local variables pView to pRenderer in
        Animation functions.
        
        Change-Id: Ib70f41052c5266acd7f2460001ce5be75b74d5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76402
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-21  Marco Cecchetti  <marco.cecchetti@collabora.com>  [0dd712ff067115b0b53ba412c61a4f5329662550]

        impress online: not handled transform animation causes core crash
        
        The transform animation uses the svg namespace for some attribute,
        anyway the exporter was not configured for handling attribute with
        such a namespace prepended.
        
        Change-Id: Ia33f55e3589b5743352ec0a156408b374a92509b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134356
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-06-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ab12274ffda3a1a5a1ff33203acf9de665d4a636]

        Breeze, KJ, Sifr, Sukapura: tdf#149646 Add More Button icons
        
        Change-Id: I89692967d9721cac4ec5bf51c1aec1e7caa92962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136200
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [3b852f274696a5e2a44bb4107c37cea9d291758e]

        add a fuzzer for our lock files
        
        Change-Id: Iaf28aa4455ea9d798d9e2649e1e7c6f1216846f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136194
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [fe53688bd379dbff08ef6afc1654d033ab3eecb5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9c5eb82a113db0fe3be363d5260b48da932b2b20
          - Document new FilterNames property of the Platform service
            
            Change-Id: Icf5093e394b06deebd66b2577af8443e109efea7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136119
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-20  Noel Grandin  <noelgrandin@gmail.com>  [b95142c11e80c58b70dff68bfd7f3792657b9ee2]

        tdf#58134 Reset Button in Options Dialogs
        
        fixed a couple of these.
        
        Change-Id: Ibef29afee1d702af2812996093deb7204c74e32c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [8388b834c547d39ceff68b0e247ec164e9fc505d]

        elide some makeStringAndClear() calls
        
        Change-Id: Id7116fac8a6f65db18ff93384c5faf2f6481f6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136186
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [98cd8e89e681463c909ff10d403fba540868e2f2]

        elide some makeStringAndClear() calls
        
        Change-Id: Id1657c6b9399780c81e8fbf0ff0a71371a66600f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Eike Rathke  <erack@redhat.com>  [36cf12d449c892e6bbacb7da5f4b008f7762232b]

        Resolves: tdf#147265 Return correct default if currency format is duplicate
        
        For the default currency format
        SvNumberFormatter::GetCurrencyFormatStrings() returned always the
        last added position, regardless whether that format was added or
        not, which it isn't if the format code is a duplicate. Let
        addToCurrencyFormatsList() return the position of the existing
        format if the duplicate was rejected and use that for default.
        
        Change-Id: I148d7379de75cae402b063f7b2f92947e345176f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136187
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-20  Hannah Meeks  <hmeeks4135@gmail.com>  [a1c6d24aac530d7374cf0fdc5c62570d86e30996]

        Simplify checks with functions.
        
        Change-Id: I55fbab5d8184a743ace3cfec884b0364536ee6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6623d5196467c489585130725866e8993bc8dde2]

        elide some makeStringAndClear() calls
        
        Change-Id: I4420042f7c8fdf743b888d6f7c1c0d2d3e0b877e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [48271742a062b0fbdedfe9396f942d3f9b5ce46d]

        Use of uninitialised value of size 8 on export to pdf
        
        ==2899330== Use of uninitialised value of size 8
        ==2899330==    at 0xCABB82A: (anonymous namespace)::appendHex(signed char, rtl::OStringBuffer&) (pdfwriter_impl.cxx:120)
        ==2899330==    by 0xCAEB14C: vcl::PDFWriterImpl::emitTrailer() (pdfwriter_impl.cxx:5466)
        ==2899330==    by 0xCAEDA09: vcl::PDFWriterImpl::emit() (pdfwriter_impl.cxx:5773)
        ==2899330==    by 0xCA9F10C: vcl::PDFWriter::Emit() (pdfwriter.cxx:53)
        ==2899330==    by 0x3D5FE329: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:1012)
        
        an issue since...
        
        commit be39eba9a3d81e20c42f1073a365e91ce855c1cd
        Date:   Mon Jun 6 00:17:02 2022 +0200
        
            Use same glyph width in PDF drawing and font subset
        
        Change-Id: I72dbcf2bb7934c9f911c7c5c3035d3d166e9521a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136183
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [b4760a4feefc8696dc29fdd7320b65d2d3b7e523]

        ofz#47118 Timeout
        
        Change-Id: I544074822cfa51ae162afa370c488a1f6132088c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136145
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Justin Luth  <jluth@mail.com>  [0332ab4bbbad2c4fad08650d62bf7addec0d2dd7]

        tdf#140967 docxexport: hairline is default and not a specific value
        
        This effectively is treated as a zero,
        although I didn't find any documentaiton that indicated
        what is supposed to happen when a:ln has no w=.
        
        Otherwise these numbers are normally in the thousands, and not "2".
        
        Change-Id: I9dd6a334e88feb9a2bafe29f92229b6cfdff9747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135674
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-20  Siddhant Chaudhary  <urssidd@gmail.com>  [ff9ff6018bea7c1a4524c8edca8ef554c74e4b3f]

        tdf#141026 Put user and computer name into collapsed section
        
        This patch hides away the file name and the name of the user when the
        user tries to open a locked file. This improves privacy, as discussed in
        the bug report.
        
        The .ui file for the new dialog box is
        `vcl/uiconfig/ui/openlockedquerybox.ui`. The source files
        `openlocked.hxx` and `openlocked.cxx` have been changed to implement
        the new dialog. The old string template `STR_OPENLOCKED_MSG` has been
        deleted to hide away the private data, and a new string template
        `STR_OPENLOCKED_HIDDEN_DATA` has been added; the latter will be hidden
        inside the expander dialog. Finally, corresponding changes in the
        makefiles have been made to let the makefiles know about the UI file.
        
        Change-Id: I3cc9d2f6e2d9bc43857c80662e2a405aacd7fc70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132342
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-06-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [df0d25d440aad265b3cb3555632bf19f74f47330]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5688744142df9c9059b84e4ce8a092d60dcae9f9
          - tdf#149318 (part) refactor row/cell table optimization
            
            Change-Id: I8f88def2a5f1b14abf271d6bb950062214d6b193
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136090
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [4d0abf6eec9beb8252a513be7e588b9ecbb7c9bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b190949bdc9482030154e4db6de1ffbd4215942c
          - Remove unreadable, obsolete fonts
            
            Change-Id: Ic1a9839b1819c6b455ded63e120b32c5995e58c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136153
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [7925b4de3f9213a1aadfe7a4b1153241f264f439]

        use std::monostate in std::variant
        
        as suggest by llunak
        
        Change-Id: Id22253198bff16eeb596e1a15ddaba1f6ac227d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [94be0c12fe419cc7f50f5cfc6cdf161805e7490f]

        SfxStyleSheetBasePool::Find can be const
        
        Change-Id: I5cf2737d05cfe4b0be936a77cfb96db053483438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [20faff1d46769a3c4150299b0b91d51bea4e543e]

        SwDoc::IsUsed(const SwNumRule&) can be const
        
        Change-Id: I9966c2d71670d53375e27090e1ad3dffb780f81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [843f33187740155db9e1d1e6638b403e4fdb0a59]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8db4f0bd980c14b969f8bc08d3a1ecac7d5f7336
          - tdf#142380 tdf#142531 Update font stack, w/o “system-ui”
            
            Change-Id: I1e6f27883b707147fdd07cdca2ca56e99a9fdc95
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136152
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Tested-by: Jenkins
            
2022-06-20  Luboš Luňák  <l.lunak@collabora.com>  [a6b9fbfc15b9e1756ac8ea939b4c588e3f170c1d]

        fix SwViewShellImp::AddPaintRect() for sub-rects (tdf#146536)
        
        Using just two corners to build the new resulting rect works only
        if the new rectangle actually really extends the previous one,
        but the <= means that this may compress also rects that are already
        contained in the previous rect, in which case it's necessary to
        make sure to use union to get the larger coordinate).
        
        Change-Id: Ie4303dfef903bded6d63625531e424a32cc01b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136144
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [54520bd1a01ff2e29bb92008778ebded8b2db9aa]

        ofz#39186 reduce max length allowed
        
        Change-Id: I1b11e5451a305f45f369d9140b71c2a5e8b77230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136147
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Caolán McNamara  <caolanm@redhat.com>  [43ae4e9a694c68101a907b0d1e31b4bd57e11bd1]

        ofz#47463 OOM only first byte of 'font', 'ratio' and 'space' are used
        
        1.098GB -> 854.6MB
        
        Change-Id: I3390c3a5abe457f8d0ad49b03b50a2d353566c2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-20  Mike Kaganski  <mike.kaganski@collabora.com>  [f4ff0ed55707078868415541c4a1aebd3db1e142]

        tdf#149622: also clear return value before calling method from SbxObject::Call
        
        Moves the custom cleanup logic to overridden SbxMethod::Clear, to simplify
        the cleanup code and make sure it restores empty Variant correctly.
        
        Change-Id: I01fa0529acd9ac787ffcda60fd6836ade4afdcb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136108
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-20  jsala  <javier.salamanca.munoz@gmail.com>  [2c68c419c1fce6de1a81e1f13a84b7069125a204]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Also change some integer by std::size_t
        
        Change-Id: I999b4dddba6ef1feb0a65aad24e97f507b577b59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136104
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-06-20  Miklos Vajna  <vmiklos@collabora.com>  [486810603fb3f84847bb549004ed0394a2e22d0b]

        sd theme: consider accent1 color when inserting shape with solid fill
        
        Once a theme is defined for the master page of the current slide,
        PowerPoint inserts a shapes with their fill color & line color set based
        on that theme (so this color is master-page-specific), while Impress
        sets the fill & line color based on the default shape style.
        
        The Impress behavior has the benefit of doing the usual style-based
        formatting, but now a document-level style overwrites a
        (master-)slide-specific theme, which is inconsistent.
        
        Fix the problem by extending sd::FuConstruct::SetStyleSheet(): if we
        construct a shape with fill, then not only apply the style sheet, but
        also set the fill & line color based on the theme (if there is any).
        
        Note that this works both in case the shape is instantly created on
        click (LOK case) or when the user first draws a top-left -> bottom-right
        point pair to define the position / size of the shape. At the same time
        line colors don't support themes yet, so that color is just a plain value
        for now.
        
        Change-Id: Ic6ae8f91bd719bd80f2b56f12b001d29b0961e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136138
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fd916f4eed3f04f345159347a35a2af4d18dbb9a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd6e7ec2b20e751a092a38cc3c3c92acf82fde81
          - tdf#149607 Fix broken link
            
            Change-Id: Icff7f1b3740063d253e9d5699a6918fed10dacb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136101
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-20  Michael Stahl  <michael.stahl@allotropia.de>  [9c2c48f14535e58cad0453fef584400ee703aecc]

        tdf#128150 xmloff: ODF import/export of fill-use-slide-background
        
        This would be better as a value of draw:fill, but we can't add values as
        an extension.
        
        Change-Id: I05db879a8cb5018e0261f049ae91a5b9aaa760b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135814
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [50394abcc36a73c0205e6cb69d925c66c25f81f2]

        tdf#128150 Implement/add SlideBackgroundFill visualization
        
        React/interpret new SlideBackgroundFill mode for SdrObjects/
        XShapes, defined by drawing::FillStyle_NONE and usage of
        XFillUseSlideBackgroundItem as (true).
        
        Do so by adding a detection, a mode to SdrFillAttribute,
        reacting on it by creating a new implemented  B2DPrimitive:
        
        SlideBackgroundFillPrimitive2D provides a Primitive2D for
        the SlideBackgroundFill mode. It is capable of expressing
        that state of fill and it's decomposition implements all
        needed preparation/creation/collecting of the geometry
        in an isolated and controllable space and way - the
        B2DPrimitive way. It does so based on the given
        ViewInformation2D, reacing out for all needed data/
        geometry from this.
        It clips & transforms/combines as needed, providing the
        necessary visualization of the MasterPage content *over*
        other objects on the Page/Slide. It is currently simple
        buffered (due to being derived from
        BufferedDecompositionPrimitive2D) and detects if
        MasterPage changes. Still, more may be needed.
        
        Change-Id: Ie11403c0b705fc2ecdfd7eb2fa5ae1a93a21b460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135971
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-20  Stephan Bergmann  <sbergman@redhat.com>  [8dfd706b1fd009eda88a27991fb17affed9659f3]

        Suppress unhelpful cid#1506515
        
        Change-Id: I8d1025a680ea5e4a6ec872478db118837dd91af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136137
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-20  Miklos Vajna  <vmiklos@collabora.com>  [2914e2d497f153736e5725c0428f9d340ef621ca]

        sw: prefix members of Acd, Customization, MSOWordCommandConvertor and ...
        
        ... Sttb
        
        See tdf#94879 for motivation.
        
        Change-Id: Ifc5637a97fced3a4bbab64b4ef9784cb4f586694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136135
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [983aa4a107bac672497f07b0bbbc752126af2d2a]

        store: remove useless comments from store
        
        Change-Id: I4b2582d3a7314d8752a56e83a4af7618b053abb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128170
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-20  Stephan Bergmann  <sbergman@redhat.com>  [1b7a4ea1d59c9f5cb9d5312d362c1d4decb19e02]

        -Werror=maybe-uninitialized
        
        Change-Id: I640fbd373262c008c44b616fbc0c05d28778226d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136083
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [39ffe421047e69554e601cedf0fde931ccc18ca7]

        KJ: tdf#149008 differentiate Description and Caption icons
        
        Change-Id: I6f02d336c1da9108199a3aa83efe033b84784a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136134
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e9b8e46e0b0c716b7c32763d3c7e966e43f06b63]

        Sifr: tdf#149008 differentiate Description and Caption icons
        
        Change-Id: I5fdcd8bc72516153fd027460dcf5c58285573cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136113
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [eabd22ad8ed99ccdbc4f94ea22944c471b21b447]

        Sukapura: tdf#149008 differentiate Description and Caption icons
        
        Change-Id: I063e2d881fb17516dd2a76ede76d8d5b2831b1fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136112
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [cb22629eb251de97084ab11f80cb54687483996f]

        Colibre: tdf#149008 differentiate Description and Caption icons
        
        Change-Id: Ie900f53008122f4df6349800fd0762f2671eda59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136111
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-19  Caolán McNamara  <caolanm@redhat.com>  [f5f946e707cb8beda0e4ae790aa65abbf61b3083]

        ofz#47706 Timeout
        
        2m34s->1.6s
        
        Change-Id: I2370237e07d6e2a45c831c70ac1c1158efef7816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136107
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-19  Gabor Kelemen  <kelemeng@ubuntu.com>  [352284e77f905bc5f09c1dfdab35059e0a3de6bf]

        tdf#68335 Increase default para spacing before/after to 56 cm
        
        and fixed line spacing as well.
        These may be set to 1584 pt in Word, but the UI incorrectly showed
        even the correctly imported values as 10 cm.
        
        Turns out this is only a UI limitation, so lift it for UX interop.
        Save/reload already works fine to odt, docx, doc, rtf formats.
        
        Change-Id: I69a772e860ad24a1b317dc041b0c55f0a9d461de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136102
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [994ff7a1d36382c21cff34f7a89b2b6690f2edd5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26d2c0e3e5bfd595b82dad52333e8b57f040a6f7
          - tdf#149301 Update Navigator terminology
            
            + Refactor, simplification of <switch>
            + Removed duplicated hid bookmark for Contents
            + Update icons and <alt> text
            + added some of the comments of tdf#178755
            
            Change-Id: Ifaba80d212828e47d99275a9b0a1681eb3bc3430
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136105
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-19  Julien Nabet  <serval2412@yahoo.fr>  [2a38c834c8b7712421f1125aa0e382de70767b55]

        tdf#128196: filenames containing # get truncated when saving to GVFS
        
        + replace getLength() by a call to isEmpty() since we're here
        
        Change-Id: I77a318ea3e8ceeeddd6c64cee25aa6700cb3457b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136084
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-19  Laurent Balland  <laurent.balland@mailo.fr>  [6cbe52d4e90a21495ea20a82e31afb2b19d13377]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76523322affd4d47952dfcfe0a6822c3d746ffa5
          - Update tdf#129679
            
            Remove Apache license as it is a new file
            Add some details.
            
            Change-Id: I9cf2b707d32772017ab56f093115419ca020398a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136106
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [30529311ffbbe193765aff0ff353d3409fce3a3e]

        tdf#113002 - Add numeric flag to recurring data fields
        
        Change-Id: Ife6ace86807f85c644ff919621f562c251c6690f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135915
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-06-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1c6057aa5a6b6cbd9cc8cbfbc3080dd2fdbd8783]

        Breeze: tdf#149008 differentiate Description and Caption icons
        
        Change-Id: Idc1bb11a5daffb5b9f29a14f6086c69e6ae875fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136100
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-19  Caolán McNamara  <caolanm@redhat.com>  [5d41aca772cb9c4afd92ad408c66bd9642bb3952]

        cid#1506514 Uninitialized scalar field
        
        Change-Id: I777d9008289b2afb464d1002e8be32072c0a4501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [66b93c18fd4c4587a3ae38d0114152d061702d22]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc1fab4011de88f60e5b8e6a3269971046e25c11
          - tdf#146762 update Tab key variations in lists and chapter headings
            
                tdf#146762 changed the behavior of Tab, Shift+Tab, Ctrl+Tab, and
                Ctrl+Shift+Tab when the cursor is in a list paragraph or chapter
                heading paragraph. This patch makes appropriate updating in the
                help for shortcut keys.
            
            Change-Id: I85aefa325363601a6d76e4b3acc57b11a09180d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135981
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [8303e3783952266ba5eec2e8b20fdae5400466b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ccf86626a70ee1c7c3b0f3b94a4406328b8116fe
          - tdf#146762, tdf#141128 correction for new tab insert behavior
            
            tdf#146762 eliminated the possibility to insert a tab at the beginning
             of a list paragraph. This patch updates the help instructions about how
             to insert a tab at the beginning of a list paragraph.
            
            Change-Id: I5d8475cc01a29dd0e73900d587900a7daac9e776
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135988
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-19  Caolán McNamara  <caolanm@redhat.com>  [f9ceb96c11dcb262f030966cf44b2dc5ed657144]

        ofz#48122 Timeout
        
        Change-Id: Ia00a8ced550a5d4c84899e6cfb293779216898e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136093
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-19  Caolán McNamara  <caolanm@redhat.com>  [03b5c306044c8a41e58b99ef7f648f81ee4a9533]

        factor out body as UpdateScalingMode
        
        Change-Id: Ib65856e4573bbd0a4ac08aac9ef6e26b86678f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136092
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [422fcc74f9e334d45e4cc971a45465bd9f5b1777]

        elementary tdf#149008 differentiate Description and Caption icons
        
        Change-Id: Ie05280cb594a748f9189eafccea2b219316065ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136098
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-19  Mark Hung  <marklm9@gmail.com>  [f770dd18192addf0bbc587c0b2d266e3dd56819b]

        sw: prefix namespace Justify with sw.
        
        Change-Id: Ia813b93dc719a5715804aa06b555c99eaf99b039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135594
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-06-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [50e60ef342b94974d57956f01427f93d91d9875f]

        elementary Sifr: tdf#144303 Calc cross cursor
        
        Change-Id: I2805060487720a434f3b68b24ca05d576d10d717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136097
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-19  Michael Weghorn  <m.weghorn@posteo.de>  [e4d23c27288b99c3ed3cfa332ff308b31c01f97d]

        qt: Fix qt6 build after fbc61e06584ff8e6d9240f8b67be8dc28ecab5b9
        
        Failed like this:
        
            In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtX11Support.cxx:10:
            /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtX11Support.cxx:15:10: fatal error: QtX11Extras/QX11Info: No such file or directory
               15 | #include <QtX11Extras/QX11Info>
                  |          ^~~~~~~~~~~~~~~~~~~~~~
            compilation terminated.
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:334: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtX11Support.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtFrame.cxx:10:
            /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx: In member function ‘virtual void QtFrame::StartPresentation(bool)’:
            /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtFrame.cxx:746:5: error: ‘m_ScreenSaverInhibitor’ was not declared in this scope
              746 |     m_ScreenSaverInhibitor.inhibit(bStart, u"presentation", bIsX11, aRootWindow, aDisplay);
                  |     ^~~~~~~~~~~~~~~~~~~~~~
            make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:334: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtFrame.o] Error 1
            make: *** [Makefile:288: build] Error 2
        
        As mentioned in [1], `QX11Info` has been removed in Qt 6.
        
        The `ScreenSaverInhibitor` related code (except for the `QX11Info` part)
        can be used for Qt 6 as well, so adapt the checks in
        the header accordingly.
        
        [1] https://www.qt.io/blog/qt-extras-modules-in-qt-6
        
        Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de>
        
        Change-Id: Ifd546b4f4210aaf7f09ebaa8c36d2a031763d492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136091
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [455197df7f7520bcce8c3f4210dfbb12ae0e7e60]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9219eb74dc4f25293ce4ac8a7ab7f923f6f62253
          - Fix Shell syntax
            
            Change-Id: I06f5f308bcb0e769644db1595a246dc22f2d1d7c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136052
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [65c0ac79a5242e84da81fbd34a60d211893fe37a]

        ofz#24932 Timeout
        
        still too slow, halve limit
        
        Change-Id: I4a3f1ae7e6d86c8fb1b6d67f1e382a436df45bc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [9a48563e33e54a04932ebf0ef195e7a0d2d1aa67]

        cid#1504663 workaround Resource leak in object
        
        and
        
        cid#1504667 Resource leak in object
        
        take a simpler approach over an unordered_map
        
        Change-Id: Ie0736dcb0c8e7cdcd3b4b6bd303642841b590bf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136087
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Noel Grandin  <noelgrandin@gmail.com>  [a5d355fef3896f3109c74c153f2a34b82fe6be38]

        clean up Sc*CellValue
        
        after my recent commits
        (*) make more fields private
        (*) rename fields (remove suffix "1") now that I am sure I got
        everything.
        
        Change-Id: I0f8b9b1a534181c8b66532f9da5a0d16aa049cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [634f13a722dc68b7a2df7518880ce4f9d5d89f19]

        add usual footer directives
        
        Change-Id: I1fd6c5e98e77bc7f275dff65f4c2287b58550f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136081
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [b9a83f9ad4bf1d7754e23af5e6e4eb03750adb92]

        cid#1506303 silence Unchecked return value
        
        and
        
        cid#1506308 Unchecked return value from library
        
        Change-Id: I2a2057b44f1e1e3b8577b02fb63e5460c7222b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Diane Leigh  <leighd2008@gmail.com>  [243ffb1604e784a5dbc455a32681af32dd0126af]

        tdf#143148 Use pragma once in embedserv and helpcompiler
        
        Change-Id: I006bbcea9ea69ffcf7c789691583430c9154af2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136058
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [53786f02fde9fa544a8d385d1f651b871030c220]

        cid#1506305 Big parameter passed by value
        
        and
        
        cid#1506307 Big parameter passed by value
        
        Change-Id: I7386eeea04f73a4ec9fe0fe09ff2981b2022be89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [97324e7e506273b425d5bca12961d9f3d58712b8]

        cid#1506306 Uninitialized scalar field
        
        Change-Id: I2daf370dc68dff19f1be538744d7241c080d8149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Caolán McNamara  <caolanm@redhat.com>  [8831ef2d478c4c66d37087e5ce2c97bb0379d37f]

        cid#1506304 Uncaught exception
        
        Change-Id: Ib4bc9b08982b1fe2f5130ef4e56489f366c01081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f8e07bd8acb9e0866a1e646b9276c51450c0ab84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8fee25674c3bdb0cf3cee4a7dfcc2a814431549b
          - tdf#149525 Update Writer-View-Toolbars
            
            + Added 2 extra files for undocumented toolbars
            + Still work in progress on main0200.xhp
            
            Change-Id: Ida0b1fd2c69cb48ce0cd39ef890e53e5f2b4f056
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136068
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [743aa2e0f9f513e0908daa505dbff1c83e9eba20]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f8357004d5a93f001e27db9491b9d9f56634054a
          - (related) tdf#148941 update label in Imagemap properties page
            
            Change-Id: Id9754b97eb51a7db5b159fff76512880ef59629e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136049
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-18  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1c5da6a9516f801a343811bea04016c2ca644a23]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 345a9ecdd1d744f97a7281a49ef6940824089fd4
          - (related)tdf#148941  update label
            
              tdf#148941 changed label from "Text" -> "Text Alternative" as part of
              making consistent usage across the UI. This patch updates the
              relevant help file. Also, introduces a variable for a sentence that
              is repeated across several options, and which uses the new label.
              This makes it possible to use <embedvar> instead of retranslating the
              same sentence with the label change.
            
            Change-Id: I3be6a3863f74790732682abd8228c47cd907b0b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136044
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-18  Eike Rathke  <erack@redhat.com>  [9aab475e221e1abee2108b21545f2bdaa48552e6]

        Related: tdf#142293 tdf#141495 Allow additional symbols in externals map
        
        ... to repair broken saved as Excel documents with saved Add-In
        programmatic names, by adding them as upper-cased symbols. Previously,
        adding such name was rejected if the Add-In already existed in the
        reverse map. Now multiple one-way aliases are accepted. The upper-case
        programmatic name was already attempted to be added for all Add-Ins of
        the collection (for the non-UI case via
        fillFromAddInCollectionUpperName()) but the pre-known Add-Ins are mapped
        before so existed already and those names were rejected, as they
        shouldn't be necessary. Except for broken documents..
        
        Change-Id: I3cb6848779362de3446581528d2f6e6f19af9ec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136072
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-18  Michael Weghorn  <m.weghorn@posteo.de>  [85c564285036f92f76c1095487c5d5e12709b1e2]

        qt a11y: Handle special value of -1 for text offset
        
        As the note in the Qt doc for
        `QAccessibleTextInterface::textAtOffset` says [1]:
        
        > An offset of -1 is used for the text length and custom implementations
        > of this function have to return the result as if the length was passed
        > in as offset.
        
        Without this, LO happened to crash quite frequently with Orca enabled
        when moving the cursor between paragraphs in a Writer doc when using the
        qt6 VCL plugin in a WIP branch including more changes to qt5/qt6 a11y.
        
        [1] https://doc.qt.io/qt-6/qaccessibletextinterface.html#textAtOffset
        
        Change-Id: I5c6ca69f8a9b2edad204bb1af740d4de17668f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136073
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [fbc61e06584ff8e6d9240f8b67be8dc28ecab5b9]

        Qt move most X11 specifics into QtX11Support
        
        Just some refactoring.
        
        Change-Id: I5b2ef531778d4d43d2fdc32fe7da59edffa3c02e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136061
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-18  Eike Rathke  <erack@redhat.com>  [994d517a48f7e092ec57d179abb855ef5a86eacb]

        Related: tdf#142293 Use the same locale to lowercase as was to uppercase
        
        ... so a #NAME? bad token isn't mixed up like it was with the
        stored loaded from document
        com.sun.star.sheet.addin.Analysis.getEdate
        upper-cased in tr-TR to
        COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE
        and then lower-cased in en-US to
        com.sun.star.sheet.addİn.analysİs.getedate
        which confusingly was the user-visible token string.
        
        Change-Id: I341648fcf34fa1cae164d24ad2023bd74573bd3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136071
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-18  Eike Rathke  <erack@redhat.com>  [36cb12bce80836a29e5124167b588490b3f7700d]

        Related: tdf#142293 Do not use locale's uppercase for Add-In programmatic name
        
        ... so in a tr-TR locale
        com.sun.star.sheet.addin.Analysis.getEdate
        is not upper-cased to
        COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE
        
        Which didn't matter as long as it was consistent and only used for
        lookup and mapping, if so..
        
        Additionally, the programmatic name does not need the CharClass
        overhead and toAsciiUpperCase() is sufficient and faster.
        
        Change-Id: I1c987cc56dc3a62b5285a0bc367c754e7acb6815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136070
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a7913c1b57b333223b30194c67c4d8d11e583d2]

        tdf#126109 calc slow when replacing string to number
        
        Store SharedString inline in ScCellValue.
        Shaves 10% off time.
        Use std::variant to handle the complexities of correctly calling
        constructor and destructor of SharedString.
        
        Change-Id: I820de5339e31434fbdbde1a72e25abe207bf008d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135863
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-18  Stephan Bergmann  <sbergman@redhat.com>  [1d609713d090723aa78b71c35575102ad06717ff]

        -Werror=maybe-uninitialized
        
        Change-Id: Ife1958a39a7cf673b745a7724ee963e868b21432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136064
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-18  Michael Stahl  <michael.stahl@allotropia.de>  [37ec4442d70339dc8ec5fb8e4ec8984420b6e14d]

        o3tl: ensure that the initializer of enumarray contains enough elements
        
        Currently this silently succeeds. Turns out oox already contains some
        too-short initializers, let's guess the missing properties are all
        invalid.
        
        One downside of the templated parameter pack approach in the enumarray ctor, as
        witnessed in vcl/win/window/salframe.cxx, is that argument types can no longer
        be implicitly deduced and thus need to be spelled explicitly now in certain
        cases.
        
        There were also three uses of enumarry with V being unsigned short (aka
        sal_uInt16) that started to cause narrowing conversion errors now and needed to
        be adapted:  In editeng/source/uno/unonrule.cxx the obvious fix was to use the
        proper type for V.  In sw/source/core/unocore/unosett.cxx with its odd mix of
        saL_Int16 and USHRT_MAX, lets keep things that way for now (probably awaiting
        later clean up) and use casts to avoid the implicit narrowing.  And in
        sw/source/filter/ww8/wrtw8esh.cxx the ESCHER_Prop_* values, while presumably
        conceptionally of type sal_uInt16, are plain #defines (thus of type int), so
        rather than changing V to int it looked more consistent to explicitly cast the
        ESCHER_Prop_* vlaues to sal_uInt16.
        
        (And in tools/source/fsys/urlobj.cxx the poor loplugin:redundantfcast started to
        unhelpfully kick in for (only) the first argument now.)
        
        Change-Id: If06c29e673ec7e565e283c6f447889cf1f777cb7
        Co-authored-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135970
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-18  Noel Grandin  <noelgrandin@gmail.com>  [20b8c7f38ae1c03dc0405a2da006ab6b2dbf3627]

        create getter for ScCellValue::mpFormula
        
        so we can assert that it has the correct tag type
        
        Change-Id: Iab13a6d6ea1783c69395f06f28732769e5fe8b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-18  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ca47989ad60b1414f92be22a1fbf4c1d1a92dd97]

        Breeze: tdf#138400 update General Format icons
        
        Change-Id: I7daad09129c505e300d84634768f4bcf14653500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136069
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-06-18  Eike Rathke  <erack@redhat.com>  [f804b8d0b1fc0c215c8883c76344b2d256d5c003]

        Remove comment of long removed MapDupToInternal field
        
        Change-Id: I0fd78eb1ff1fedf0ddb9728b06a3ee6de7973329
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136066
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [72a33ebe0a50f289d1842881638ae763c2f2449c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 65290dc95fe2efb330ac54ecf9d771984b4e5c9d
          - TDF#147862 (part) Update toolbar contents Help pages
            
            + Upgraded the Tools toolbar help page
            + several fixes in embeded files
            + bug147862 still work in progress
            
            Change-Id: I35238075f6a917a8d7c39bfb5cbf6a5a6ebc783b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136063
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d8bc56ca9a6ce3fffb4ba2379c6a3f39211f6271]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a
          - Refactor table into list in redlining_enter.xhp
            
            Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-17  xuenhua  <xuenhua2008@sina.com>  [0ec2b93c28093c80572c43f7be261630bd85f232]

        tdf#149431 Fix the sidebar's width
        
        When click the wider sidebar and then go back to the narrow one in Writer,
        the narrow one becomes the same width as wider one, it's not suitable
        and doesn't look good. Fix the width to smallest width unless you drag
        the splitter. Take the maximum width from the smallest width and
        mnWidthOnSplitterButtonDown.
        
        Change-Id: I60aaab84593d59ac28b96c2d3c3bd62a4bbddbbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135220
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [80d801cf07b6583e824ad89c3c750b076118f41d]

        Rectangle: split SetSize into SetWidth/SetHeight
        
        ... and inline the functions.
        
        Change-Id: I9285c72e8524f8f0a2d242bfd4cd29edf6d1ed73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135811
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [e2a8b4a420ab0f726c43ec6c609d17211cd6ed11]

        Fix and add ostreams for vcl::WindowPosSize
        
        ... and inheriting classes.
        
        Follow-up on commit ea5a0918c8c32309821ab239c4b95f4d6a3b5c12
        ("VCL add vcl::WindowPosSize abstract class").
        
        Change-Id: I4733cd4619f91fe1ba05c208a650be591ecf5d8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135806
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [8b6000f6075725b2e17b8fa745251ea96d7185f1]

        WIN drop window state redundancies
        
        So on Windows a window's state is stored in:
        - maGeometry, inherited from SalFrame
        - maState, which is the same type then maGeometry
        - mnWidth and mnHeight, which are just set, never read
        - mbFullScreen, which can be encoded in the vcl::WindowState
        
        IMHO we can get rid of mnWidth, mnHeight and mbFullScreen. Which
        leaves the mystery of the extra maState. But at least it looks
        like we can simply cache an vcl::WindowState instead.
        
        And this is a little start to make WinSalFrame variable members
        private; it'll be a long way...
        
        And it also changes a SW_SHOWMAXIMIZED to SW_SHOWMINIMIZED in the
        cleaned UpdateFrameState(), which looks like an error.
        
        Change-Id: I5895313d87a6f81371e2b77af6c813d35f591725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135809
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-17  Michael Weghorn  <m.weghorn@posteo.de>  [8c3e8af0e60865ec6d38e2117efdb4ed2f10a20c]

        qt a11y: Forward STATE_CHANGED event as such
        
        Handle `AccessibleEventId::STATE_CHANGED` by
        sending a corresponding `QAccessibleStateChangeEvent`.
        
        The previous way of sending a `QAccessible::ForegroundChanged`
        event looked rather arbitrary and had no effect in practice,
        since that type of event is currently ignored in Qt's AT-SPI adapter
        anyway.
        
        At this point in time, the Qt library doesn't forward
        changes of all states to the AT-SPI layer. Most notably,
        it ignores changes to the focused state.
        (Qt itself uses events of type `QAccessible::Focus`
        instead of `QAccessibleStateChangeEvent` with the `focused`
        state set to notify about focus changes, but that's not exactly the
        same, and e.g. causes Orca to ignore some focus changes).
        I have submitted a change to Qt to implement
        forwarding of `QAccessibleStateChangeEvent`s for the
        focused state to the AT-SPI layer, currently awaiting
        review. [1]
        
        With that Qt change in place, Orca still ignored these
        events in LibreOffice message dialogs, since those
        use a11y role `ALERT`, which wasn't previously considered
        when trying to retrieve a potential dialog that an
        a11y object belonged to.
        The corresponding Orca merge request [2] has just been merged.
        
        With these two in place, Orca now announces the focused
        button when switching focus using the tab key
        e.g. in the "Save document?" dialog when using the qt6 VCL plugin.
        (Most other things in the LO UI are still usually not announced.)
        
        For some reason, forwarding changes to state `AccessibleStateType::ACTIVE`
        resulted in Orca becoming unresponsive (stop talking) quite quickly.
        That needs further analysis, so that state change isn't forwarded
        to Qt for now.
        
        [1] https://codereview.qt-project.org/c/qt/qtbase/+/416510
        [2] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/127
        
        Change-Id: I81c9a0f5ec8c74f95943d3073bba5b304f995d31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136057
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [2e509b886f1d77ef158579385b55f1f94cfbc710]

        Convert ImplWindowStateFromStr to WindowData(str)
        
        To have a constructor as the counterpart of the toStr() function.
        Better then some unrelated independant function.
        
        Change-Id: Iba4cb3d400a92704753db6b35d12f2189b23077e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135807
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5e0b95494093de2849c5154b98917e1beab2a708]

        Drop a bogus slash
        
        ... added in commit eae791e82c8e138cc983c3e7058cc4e9dafa4002
          Author Jens-Heiner Rechtien <hr@openoffice.org>
          Date   Wed Jun 27 11:30:00 2007 +0000
            INTEGRATION: CWS awttree01 (1.1.2); FILE ADDED
        
        where it was misplaced (intended to be <TRUE/>, not <TRUE>/).
        
        Commit	1501e17b889b28e7394596ce4f98eab1c5b00d8f
          Author Rüdiger Timm <rt@openoffice.org>
          Date   Wed Jan 30 07:20:16 2008 +0000
            INTEGRATION: CWS dba24d (1.2.92); FILE MERGED
        
        added '/' before the '>', but kept the incorrect initial one.
        
        Later commit 928b8640c0d1a9c49249100efbdd70f8c1090b07
          Author Michael Stahl <mstahl@redhat.com>
          Date   Sun Apr 28 00:44:31 2013 +0200
            *api: convert <TRUE/> <FALSE/> <VOID/> <NULL/>
        
        removed the correctly placed slashes. This is a leftover.
        
        Change-Id: I800f28de02dd8447509bc236614cab05c2b8c0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136037
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [393c9f736b10d1ea82979e9c2c43c8f91ba5831d]

        Qt use QEvent::type to handle the event correctly
        
        No need for an extra function parameter.
        
        Change-Id: Iedb949b45ad3f161121110e2db2132b6c3cb706e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135894
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-17  Noel Grandin  <noelgrandin@gmail.com>  [c78193b32152122e9b71151b1b463b2dff99f42f]

        create getter for ScCellValue::mpEditText
        
        so we can assert that it has the correct tag type
        
        Change-Id: I984c22ae2527d652f2d4194227dc1173793300c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [69e5d752ef20f5cd5b3a429a3546ae46bbb5f62a]

        Drop wrong '@returns' documentation
        
        Caused this warning:
        
          /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/view/XMultiSelectionSupplier.idl:60:
          warning: found documented return type for com::sun::star::view::XMultiSelectionSupplier::removeSelection
          that does not return anything
        
        Change-Id: Iee156519c2075293b8305627ed22d586143c8688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136033
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-17  Noel Grandin  <noelgrandin@gmail.com>  [12b817140641a94ebb3ef8271c5e955eb80e56f2]

        create getter for ScCellValue::mpString
        
        so we can assert that it has the correct tag type
        
        Change-Id: I8933919aefc2bb22694a283b54dc3de11d16e5a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [c1eba8d34a5ea13e6317c7820507d717ace4ec5c]

        Change '@returns' into '@param'
        
        That was causing the warning:
        
          /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/embed/XInplaceObject.idl:85: warning:
          found documented return type for com::sun::star::embed::XInplaceObject::translateAccelerators that
          does not return anything
        
        A similar 'translateAccelerators' is in XInplaceClient.idl.
        
        Change-Id: I9abcb22ce8f460e2d26202542fef74b7e6a27ea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136032
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [dfdeb1bd67a7e1ce3bad26e5d02b54e4ece5f0f2]

        Drop useless '@returns `VOID`'
        
        ... which caused the warning:
        
          /home/tdf/jenkins/workspace/gerrit_windows/offapi/com/sun/star/sheet/XDataPilotTable2.idl:62: warning: found documented return type for com::sun::star::sheet::XDataPilotTable2::insertDrillDownSheet that does not return anything
        
        Change-Id: I028820dc11ed8110278f2a655f1ad0c26d7b91cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136031
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5772cef244dbee5834efbc693bc714d89ae6301d]

        tdf#134210: Reimplement cropping from srcRect and fillRect
        
        This avoids the scaling after the crop, since scaling is performed
        anyway when applying BitmapMode_STRETCH. This improves resulting
        bitmap quality.
        
        Also consider the "crop to zero" case (when the sum of cropped
        parts is equal to 100%). In that case, just use an empty graphic
        as the fill bitmap.
        
        This makes the differences between srcRect and fillRect processing
        explicit, simplifies the code, avoids extra rounding inaccuracies,
        and takes care of the edge cases that were considered in commit
        2859ec288f2c1323ea3123d82cb1684b349ff598
          Author Miklos Vajna <vmiklos@collabora.com>
          Date   Wed Jun 15 15:52:18 2022 +0200
            oox: fix div by zero in lclCalculateCropPercentage()
        
        The change in SdImportTest2::testTdf134210 is because we now don't
        scale the cropped image. The previous value was an interpolated
        color, while the new value is the actual color of pixel [0, 41] of
        the original image.
        
        Change-Id: I24fa9928cff32bcaa6a7b3e34def14700fddd7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135917
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-17  Luboš Luňák  <l.lunak@collabora.com>  [4dab8afe89c57318cc7503ae051963de89a6cd25]

        upstream Skia fix for Vulkan crash on texture binding (tdf#148624)
        
        Change-Id: Ic16a516bfde04aba0336baca58f605d6cf9fd413
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136011
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-17  Maxim Monastirsky  <momonasmon@gmail.com>  [230a988c9011ffc365070acf9ecd750825b0b1ec]

        tdf#125040 Ignore the default context
        
        This isn't a meaningful context, but a way to represent
        a lack of context. Typically it's a temporary state,
        followed by a proper context being set. The problem
        becomes apparent when a context deactivation is caused
        by switching to another document window, as the further
        activation will happen only when the former window is
        focused again. This makes the contextual controls
        disappear in the meantime.
        
        Change-Id: I96c8356acb2434c579dc74407043b55eb5374a0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136010
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c175b00d784a1e702ac6e757c78322dfb4175309]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 665f218e5e027ab3ad56bf6066d98d8323555ab3
          - Mute l10n
            
            Change-Id: Ie3f063c53f424293da59e85e4a34334f37d4324c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136021
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [bf195037e2e59c46a8b7d149aedb79357e5ea978]

        tdf#149579: sc_vba_macro_test: Add unittest
        
        Change-Id: I2cb673d9b42ea28b19fc408f2be86456258fcbe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136013
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [1328ff3ddc2646b6061baf31ebe5d7c84513d263]

        tdf#149529: sc: Add UItest
        
        Change-Id: I21a20c2d9d5922ac622d6b5858d500cdb3fc65ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136012
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-17  Miklos Vajna  <vmiklos@collabora.com>  [6fd91fe5ff246aba7c15c458e6440beef48f510b]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I0336c35df7b9b9d1704cc6611b8ffe1f111977a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136004
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-17  Ilhan Yesil  <ilhanyesil@gmx.de>  [0f1837306ae5c2c2e10f256b872c46b0bfba00dd]

        tdf#149575 UnoControlTabPageContainer: Handle tab image
        
        Setting a tab page's image in the tab button is done via
        method 'XTabPageModel.setImageURL'.
        
        Change-Id: Ideb096f88037dac26abe90fccae2251dcce84659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135900
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-17  Julien Nabet  <serval2412@yahoo.fr>  [0cea5d817434c5f7ccc8816f7f5e29a4ba95f8f0]

        Another "One call to XCellRangeAddressable::getRangeAddress() is enough"
        
        See https://cgit.freedesktop.org/libreoffice/core/commit/?id=e44e418783d101c530c916db0b0f72c376188fdf
        
        Change-Id: I1106d1777690c27b9e4765a3a94145bb73609005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136005
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-17  Luboš Luňák  <l.lunak@collabora.com>  [8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811]

        handle GC* pixmap functions on Mac reading past pixmap (tdf#145843)
        
        The code passes adjusted position for pixel data in order to create
        a sub-rect of the pixmap without copying, but at least on Intel Mac
        the GC* functions then try to read the entire pixel row even though
        it shouldn't be necessary. Since that may cause reading past the
        pixmap data if the last line is involved, use entire pixmap width
        to avoid that.
        
        Change-Id: Ia08059b363d39dd465b2cadde5138ee045628f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136003
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9ace7e3a6c2ebb8311a8277e05564953480aa3bc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9f035d777141d5f039a85d6f64b627eaf73b8079
          - (related)tdf#138844, (related)tdf#149018  "Type"  -> "Position and Size"
            
              tdf#138844 changed the "Type" tab in the Properties dialog for Image
              and Frame to be labeled "Position and Size" and tdf#149018 did the
              same change for OLE Object. This patch updates relevant help pages to
              reflect the change in the tab name.
            
            Change-Id: Ieb8f1f6947b59638a713e583d2bb9a174b8815a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136026
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-16  Stephan Bergmann  <sbergman@redhat.com>  [1638b4f78af70b7b97d0a081ed51390dd87bf1f9]

        rhbz#2097411 Avoid obsolete PyThreadState_Delete crashing Python 3.11
        
        1fb53a637597f76bea86514b62ddfad34f60c889 "pyuno_loader::CreateInstance: delete
        the initial PyThreadState" had added the PyThreadState_Delete for claimed
        benefits but whose details appear lost to history (cf. the comment thread
        starting at
        <https://gerrit.libreoffice.org/c/core/+/3452/2#message-602ff52abdd1c95fd5c13cfe405b5fadd0048c5f>
        "pyuno_loader::CreateInstance: delete the initial PyThreadState").  And at least
        a recent master Linux --enable-python=fully-internal build with the bundled
        Python 3.8.12 appears to succeed `make check` just fine with the
        PyThreadState_Delete temporarily removed.
        
        But on the other hand, building against upcoming Python 3.11 now started to make
        CppunitTest_services fail with
        
        > Fatal Python error: init_threadstate: thread state already initialized
        > Python runtime state: initialized
        > Thread 0x0000ffff81c8b020 (most recent call first):
        >   <no Python frame>
        > Fatal exception: Signal 6
        > Stack:
        > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37c28)[0xffff81be7c28]
        > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_sal.so.3(+0x37e40)[0xffff81be7e40]
        > linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffff81ccb7ec]
        > /lib64/libc.so.6(+0x82878)[0xffff81742878]
        > /lib64/libc.so.6(raise+0x20)[0xffff816fae00]
        > /lib64/libc.so.6(abort+0xe8)[0xffff816e72b8]
        > /lib64/libpython3.11.so.1.0(+0x104e28)[0xfffee4de4e28]
        > /lib64/libpython3.11.so.1.0(+0x105200)[0xfffee4de5200]
        > /lib64/libpython3.11.so.1.0(PyThread_get_thread_native_id+0x0)[0xfffee4ed6764]
        > /lib64/libpython3.11.so.1.0(PyThreadState_New+0x14)[0xfffee4ed6628]
        > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpyuno.so(_ZN5pyuno14PyThreadAttachC2EP3_is+0x78)[0xfffee4c8c52c]
        > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libpythonloaderlo.so(pyuno_Loader_get_implementation+0x5c)[0xfffee5243060]
        > /builddir/build/BUILD/libreoffice-7.3.4.2/instdir/program/libuno_cppuhelpergcc3.so.3(+0x544b4)[0xffff815544b4]
        
        because of the PyThreadState_Delete.  (The deleted PyThreadState, while not
        reused again directly, is still recorded in the state obtained from
        PyInterpreterState_Head() later.)
        
        So conservatively keep the PyThreadState_Delete of unclear benefit for older
        Python versions and only drop it for 3.11 where it is known to have negative
        effects now.
        
        Change-Id: I9b99f1e947f0b165ddc95c2bfbd764858dda39db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136006
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-16  Eike Rathke  <erack@redhat.com>  [7a0a0e23b7e81c1ee0601824a4ee990a2178f98b]

        Resolves: tdf#147822 ScUnoListenerEntry container must be std::list
        
        ... instead of std::vector to not get invalidated iterators when
        the container is resized.
        
        Regression from
        
            commit f8defe59ff75df2b516ee407f1dac22b0ac72a19
            CommitDate: Wed Sep 6 22:45:10 2017 +0200
        
                Replace some lists by vectors in unoobj (sc)
        
        which was bad for this case.
        
        Change-Id: I8d3a001242865cadc82b359a3198906d26373a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136007
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e247d62ea65f269d8ec304e08d21796a1cc52c52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b01904aabf78c6981d4c3b3953483bea9e86c2b3
          - Mute l10n
            
            Change-Id: Icd723b9b933788c5ac9e1b2bbb9e541f241bdbe1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136020
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-16  Noel Grandin  <noelgrandin@gmail.com>  [c2518134a55658218c924b43b5c87e4fbdaed1d4]

        create getter for ScCellValue::mfValue
        
        so we can assert that has the correct tag type
        
        Change-Id: I0d626130cb014e19239e88a6988018c83d061f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-16  Noel Grandin  <noelgrandin@gmail.com>  [7eae7e54e0c55d5896cf807c339fd0789f54d380]

        pass EditTextObject by unique_ptr
        
        to make the ownership passing obvious
        
        Change-Id: Icf4b94a422b91da3082fe1ce56eff149d390a649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0fe3459b05502bc62814dc1f90059653f52046f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 51cfc9a957eec7be595e8b667a528cbe749992a0
          - (related) tdf#149414 change in Impress Format menu command name
            
            Change-Id: I80d37dc341f35c89fe73d815df900178a3552c74
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136017
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-16  Michael Stahl  <michael.stahl@allotropia.de>  [3707c0b4ff683ac6f0942a176ebcb8d824b567ee]

        tdf#134759 sw: clear items in SwAttrSet::CopyToModify()
        
        Setting new items but not clearing existing items smells like an
        obvious omission. Why would we want a union of two nodes' items?
        
        This improves things a bit for the bugdoc, but now it ends up with a
        different wrong list on the node 254.
        
        Change-Id: I3f5db0a4f81ac6e9af56d1faaefc2cb107dff597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131841
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c0c0e33c4e74f62e77d54460595bcf0b3abb01a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7fba791de12f34179bb355fedbc111f4112bde8
          - tdf#149572 update "Left Paragraph Border" and "Right Paragraph Border
            
               tdf#149242 changed the Horizontal positioning labels in the
               "to" control from:
                   "Left paragraph border" -> "Left of paragraph text area" and
                   "Right paragraph border" -> "Right of paragraph text area"
            
                This patch updates the option names and makes corrections to
                in the description of the referent of these options.
            
            Change-Id: I604cb4354f239d476375791fa57865d10b1d0d24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135881
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [df454a21c6f15404b312f06ae99620bc720258ef]

        Next release is 7.5
        
        According to 27ebceb366356f65c836e7edcc3609193f6e009c
        
        Change-Id: I0fe247ca398a3c4607840c1a190453c52204749b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135986
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-06-16  Rene Engelhard  <rene@rene-engelhard.de>  [26cc731adeba5ac434f7ee76a4fe5b57e42c6702]

        Revert "enable Skia on big-endian too"
        
        This reverts commit b06663135f9c7c08f5866a87a1fb0932df5af8bd.
        
        Still/Again fails to build.
        See https://lists.freedesktop.org/archives/libreoffice/2022-June/089026.html
        
        Change-Id: I195c1584256d1da5fee3bbd1d7291a6639428acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135771
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-16  Rene Engelhard  <rene@rene-engelhard.de>  [cd35eebe4dde6e012c2a939461a87b58b2b7a497]

        fail big-endian builds with --enable-skia. Point to --disable-skia
        
        Change-Id: I0a1e5289a36e39eeea00e0fd67fbcf1fe7c902f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135772
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1c1a4ed4874f95683325856efe4722444a7a828]

        sc: uitest: move test where it belongs
        
        Change-Id: I59ce2a70622a6f3be112a5234a7d91d2efd372f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135996
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-16  Julien Nabet  <serval2412@yahoo.fr>  [2332a1ce5409c1a47d4ef6265a6377a67a8b2fd2]

        tdf#149524: fix crash in Writer after a label has just been created
        
        see bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=180683
        
        Change-Id: Iba461ffe65392a7e0e779f68d1f0737a444ae724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135675
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-16  Caolán McNamara  <caolanm@redhat.com>  [10404751bcb643605c50d530e3855ae005e60a5e]

        tdf#149529 crash on deref deleted ScDocument*
        
        maybe a problem since
        
        commit 46419cd7a2d453c6f252c28dfb9dbfb08605e1c4
        Date:   Tue Jun 18 15:11:30 2013 -0400
        
            ScFormulaCell is no longer a child class of ScBaseCell.
        
            Change-Id: Id33072f193045e2eaf51373b47dac803f9a5d52c
        
        presumably the cloned ScColorScaleEntry should end up with
        a ScFormulaCell for the destination document and not the source one
        
        Change-Id: I451d5827be183198b61116ab8c582cfda03b2031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135998
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-16  Miklos Vajna  <vmiklos@collabora.com>  [b2bee5a4db5552c4d408800908ca717b4ea2564a]

        sw HTML export, XHTML mode: fix lost <li> with a list header + item
        
        There is a general mismatch between XHTML and Writer lists: XHTML can
        only contain list items (for ordered or unordered lists), while Writer
        can contain list headers and list items. List headers have no bullet or
        number at the start, list items are the normal text nodes.
        
        Commit 8c2607ae3ce143586e623532b8ae5288277ec3ac (sw HTML export, XHTML
        mode: fix lost </li> when last list item is not numbered, 2022-02-21)
        fixed the list item end side of this problem: if all text nodes in a
        list are headers, then don't write ul/ol at all, otherwise end list
        headers with </li> as well to make sure the output XML is valid.
        However, this created a mis-match, the starting <li> for list headers in
        a list which have non-header text nodes at as was not adapted.
        
        Fix the problem by extending OutHTML_SwFormat() so list headers in a
        list with non-header text nodes always have a <li> and </li>, and this
        condition is the same on the start/end side.
        
        Calculating if at least one text node is non-header in a list may not be
        cheap, so reuse the already calculated info from
        OutHTML_NumberBulletListStart() in OutHTML_SwFormat().
        
        Change-Id: I3817a489f16166fc5b4c33ee64e2283c41a4402c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135999
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a2ef1dc48597d85d02576d6b722d1dd784eabf39]

        drop special case for win 64bit download name, use x86-64 consistently
        
        "x64" was introduced in 2013 for the 64bit windows packages in
        efdad0b126abd3c151b545740d0530a0a832d482 for no apparent reason.
        
        Change-Id: Ifae4faaeb99b4e8950cc64bb993d29c0a3ff24dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135923
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [7531f027c742a601c13a7a849dfae795a148d899]

        BridgeFactory should be a singleton
        
        regression from
            commit 9be078ae0d4cc4e4c01952bb42c9bb5943bbde86
            Date:   Sat Jul 4 09:12:35 2020 +0200
            binaryurp: create instances with uno constructors
        
        Change-Id: Ib7a7316fdee4afffac35b282adaf437ff8bdd009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-16  Eike Rathke  <erack@redhat.com>  [14ce950083cab9ca8067f36dc08ca5bfb33ae046]

        Resolves: tdf#149579 Expand Range.Sort single cell to Range.CurrentRegion
        
        Change-Id: Ib0ab1c2d0dd45f35f43cf710f7c15791d282ad4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135997
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae11a7ff790e413cd4053e1db931b3c72f8259bb]

        tdf#148072: sc: Add UItest
        
        Change-Id: Ibb03fc001db63ac8ba6624ab14d046f4ee1039d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135995
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c4cf2e82e8d0aaef9b1daedc033d6edf647e5284]

        tdf#128150 Add OOXML import/export for "use background fill"
        
        and allow editing this fill property in area dlg
        
        Change-Id: Ic63ba11e9d499d4a0fb22f6739587e3e25140b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134406
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-16  Noel Grandin  <noelgrandin@gmail.com>  [3d2e26d8b7a99d0a622741ef4327e8cbc93bbe02]

        make meType in ScCellValue private
        
        as a first step to wrapping up the internals of this class and adding
        some asserts
        
        Change-Id: Ic13ddd917948dbf3fd6d73f44b8efcc727726baf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135994
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-16  Luboš Luňák  <l.lunak@collabora.com>  [1ac3b4ae83856eebe6bc329b7a92575b6b1d84be]

        share ScSortedRangeCache between threads
        
        It's the same data for all threads, they access it as read-only,
        so it doesn't make sense for each thread to build its own copy.
        
        Change-Id: Ia1559c61d976bcce78661cae7e030bb8430aed7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135794
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [70d9ae7b59fd26dc524e77ff991f1cd887544475]

        Add precision to text orientation in extended tip
        
        Change-Id: I9f2c6290baa6f251dba38c3a75e61c775d87fd5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135615
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-16  Mark Hung  <marklm9@gmail.com>  [47eff9bf12abf963907b4d3dcb90b73e0ccc646d]

        tdf#149089 snap to grid if IsSnapToChars() is false
        
        for non-CJK scripts. Non Asian text was centered within as many cells
        as required according to ODF1.2 20.301. But it also required that
        text should be snapped to grid if style:layout-grid-snap-to is
        true ( i.e. IsSnapToChars() is false ) per ODF1.2 20.305. That means
        ODF1.2 20.301 ruled.
        
        This patch changes the width of inserted SwKernGridPortion so that
        non-CJK text aligns to the edge of text grid to make ODF1.2 20.301
        rule, an provide more consistent layout result as expected.
        
        Change-Id: Id6b4d2b965e20670eb9ddf657d36b8a49073f32a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135654
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-06-16  Eike Rathke  <erack@redhat.com>  [e44e418783d101c530c916db0b0f72c376188fdf]

        One call to XCellRangeAddressable::getRangeAddress() is enough
        
        ... each needs to obtain it via ScUnoConversion::FillApiRange().
        
        Change-Id: Ie98d5130067701f40c441d08bdb9faf7913bcdb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135972
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [0930096c4c5ed14f46a79f03b29f21cc915d7203]

        tdf#125040 Recreate Contextual Single for Writer
        
        Change-Id: I791631aedb9efbb7bbdc41234ee39e1d3c834ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135959
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-16  Maxim Monastirsky  <momonasmon@gmail.com>  [48ca2336251d62ac2e90300cd9945fb84b1cddd8]

        tdf#125040 Avoid flickering on context change
        
        Change-Id: I442fada34e10fe13e68987abba34969a8ab50bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135958
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [970f03cb9ed68d249fe04cff7d4aa15b0f2c6c35]

        crashreportScraper: use argparse to parse the arguments
        
        Change-Id: Idc1d32683c5113042fe4e7ec97357b6d76c5217e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135973
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fcdfd309345afaf88fac587e837e51e741c60400]

        Fix typo
        
        Change-Id: I7ff6efac1edd171f65ebd901d8f03f38364496b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135927
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [965bad9abb9b07245cce525694bc0b52c08c05fa]

        Fix typo
        
        Change-Id: I0ccce1c6e143b819dbb78d6fb74ccde8ce737f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135928
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cb958c4ff88da1d8edab756592e3c6483e1b8b28]

        Fix typo
        
        Change-Id: I9b29e51e550ea9f13497e1f46cf4cdc11cf8faa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135925
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1bd2c6391f28b9d3bb94d1b8ef58cdedacf858ba]

        Fix typo in code
        
        Change-Id: Ic2c07abd89361aaef0f216ee71d0fa8ce8529233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135924
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c7f971c23b908335ab5cfb3117bb4d6fe544a664]

        fix download-filename for Windows aarch64 builds
        
        was incorrectly using x64
        
        Change-Id: Ieb7c90c6b1ed3abd73315a15c59490ea639954c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135922
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9e0ac0c85fc0fb6011d2b0fc28f3c430bc10317f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a17fbdee73a7f567637c56a1b6354c0fef3b3a10
          - tdf#149353 positioning objects in multipage and multicolumn paragraphs
            
            Presented as <note> in "to paragraph" (shared/01/05260200.xhp),
            while only the text is embedded as a paragraph in "to character"
            (shared/01/05260300.xhp) because there is already a <tip> on that
            page, without much other text.
            
            <note> added to swriter/guide/anchor_object.xhp that positioning
            is only on the page where the anchor is located.
            
            Change-Id: I8173050620fbeb8fc78d747ad05d8ab1f74f1346
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135169
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [68c3a6e8ebcac50aa4f8f403958a42cb8db75355]

        Fix typo
        
        Change-Id: I92524505c8e7c82bf7c1263afc257f8e6d632ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135926
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7c4481e3c41547773db3fa1f53391430cff8d3cb]

        Fix typo
        
        Change-Id: Ic6252987b61d0f55a96193bdc5da5fecc1a36171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135930
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [81d14fa410079bd55397754b1b9af3645df3e100]

        Fix typo
        
        Change-Id: I38f2e4011f348574d1d2adb7eb34cac6b2df43da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135929
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Stephan Bergmann  <sbergman@redhat.com>  [4b46eb79c2f242e97249ace16b1fc57335574c95]

        Missing test dependencies
        
        > warn:vcl.builder:4159485:4159485:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui"
        > warn:vcl.builder:4159485:4159485:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/modules/swriter/ui/annotation.ui"
        
        and
        
        > warn:vcl.builder:4164787:4164787:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui"
        
        when building CppunitTest_sw_ww8export
        CPPUNIT_TEST_NAME=testCommentExport::Load_Verify_Reload_Verify from scratch
        
        Change-Id: I36eedd31c8ee55f2992cb1aec3b26cfdbc4e2a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135964
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-16  Eike Rathke  <erack@redhat.com>  [a4fa06be4f8cd4d2584a6f3e4c5bd02786e591ad]

        Related: tdf#149325 tdf#52602 SvNumberFormatsObj::addNew accept differing
        
        ... resulting format code of an existing format as not attempting
        to add a duplicate. It makes no sense to insist on strictness if
        the client can't know the rules..
        
        Change-Id: I0c8ca215984bf84487036ccf2b570128b1694d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135898
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-16  Caolán McNamara  <caolanm@redhat.com>  [79c7c66157b75cfbf2171ad2cf87542aa75bad7c]

        Related: tdf#147844 fix warning about negative extra space in manage changes
        
        Change-Id: I20c98578e2e96bc06e3c90c12eeda81ab06c988d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135913
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d417c6d463b51a796769ed54eacf986b1cf86b86]

        Add property name to IllegalArgumentException in SvxShape::setPropertyValueImpl
        
        Change-Id: I5e10f2c35568449a99f1972db614199a6336e6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135962
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-16  Miklos Vajna  <vmiklos@collabora.com>  [9aeca50f4f0c1b2503a91eb1c7d9ed8a7231e598]

        sw content controls: allow the properties dialog in read-only sel
        
        Once you enter a checkbox or picture content control, the selection is
        read-only to avoid loosing content the next time the content control is
        updated. But this means you can't launch the properties dialog to e.g.
        enable placeholder mode.
        
        Fix this by relaxing the restriction and allow the properties dialog on
        protected cursor as well, matching Word behavior.
        
        Change-Id: Ifef9af66d077682c46c852c9ecba2df5f17234fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135965
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-16  Luboš Luňák  <l.lunak@collabora.com>  [e445eac863ac616fb99c9d6bf5510b965fd15957]

        allocate column in ScTable::DeleteBeforeCopyFromClip() (tdf#149554)
        
        Change-Id: I22607f1dd0ec1c083f6a52a2ecccb976fc133687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135864
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-16  Stephan Bergmann  <sbergman@redhat.com>  [7da269700347ced21a3a6b779366bb6ecc98b4ed]

        This should apparently be a true assert
        
        ...as dereferencing a past-the-end iterator would be fatal, as seen with
        <https://ci.libreoffice.org/job/lo_ubsan/2432/> during UITest_sw_fieldDialog at
        
        > warn:legacy.tools:19040:19040:vcl/source/treelist/treelist.cxx:1353: Entry not in model or wrong view
        > /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/safe_iterator.h:283:
        >     error:
        >     attempt
        >     to
        >     dereference
        >     a
        >     past-the-end
        >
        >     iterator
        >     .
        >
        > Objects involved in the operation:
        > iterator "this" @ 0x0x7fc0a42e1fe8 {
        > type = Hٷm�␡ (mutable iterator);
        >   state = past-the-end;
        >   references sequence with type `NSt7__debug13unordered_mapIP15SvTreeListEntrySt10unique_ptrI15SvViewDataEntrySt14default_deleteIS4_EESt4hashIS2_ESt8equal_toIS2_ESaISt4pairIKS2_S7_EEEE' @ 0x0x7fc0a42e1fe8
        > }
        >
        >
        > Fatal exception: Signal 6
        
        Change-Id: Ibd547536849b15d56711e065262197a2e168db3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135961
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-16  Caolán McNamara  <caolanm@redhat.com>  [4e41879586fb24e925fb59dd06c43235f298e66d]

        Related: tdf#123846 don't auto toggle radiobuttons with left/right
        
        just do the default cursor move, toggle can be triggered with
        space/return or directly with 0-9 (+ a for 10)
        
        Change-Id: I654ca64e49b3a9d4672668553095e971a5c9d1e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135921
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a447b5b6d1114111c92e5e3e3f3ae83d4c2f3bca]

        loplugin:moveit
        
        Change-Id: Ic593974a44d9e327e0385c7ffaaa6d42576ae01a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135911
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [578521ed67ff905bcd2e1b56f0fee6a0635b41e7]

        Fix typo
        
        Change-Id: I169bb6381af825b3024c57a0a9996e1390a27d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135931
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-16  Miklos Vajna  <vmiklos@collabora.com>  [95df95001f75fdb0a4e5b136bd8cec815d4bb5ef]

        sw: document SwFormatWrapInfluenceOnObjPos
        
        The legacy iterative process doesn't need this, but the newer
        straightforward one does.
        
        Change-Id: I33932f37d5ad7bae0ffe5f23abdf2c4d82b84598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135920
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-16  Mike Kaganski  <mike.kaganski@collabora.com>  [cbbb67e05709e89bca60ae241342d6647ea64f79]

        Correct parsing of ST_Percentage
        
        Change-Id: I227b2abd493d3a4ce6f4e4dcd256aa29653fdce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135886
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-16  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [bbae8d3708691d10f18cac158e2ce8f2ee556d86]

        Revert "Fix typo"
        
        This reverts commit 157d58605acc714a5756525b567d6b59a1322d35.
        
        Reason for revert: IT IS NOT A TYPO
        
        Change-Id: I06ccc29f4a093068b0ba211682e1624476b8a6c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135946
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-16  Regina Henschel  <rb.henschel@t-online.de>  [aca189d118d4351b293c089cb26584eb898e1849]

        tdf#149551 write draw:text-rotate-angle only once
        
        The attributes 'vert' and 'vert270' set property TextPreRotateAngle on
        import from OOXML. The property TextRotateAngle can be set by macro.
        Both were written to file as 'draw:text-rotate-angle' attribute. So we
        got a file format error 'duplicate attribute'.
        
        The values are now added and the sum is written. That gives the same
        rendering as after applying a macro. Using the sum is a workaround. We
        have currently no way to save the direction specified by 'vert' and
        'vert270' as style:writing-mode to ODF.
        
        Change-Id: I93fd8ca42b82c1ed7f1bf6e33d932e5510615b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135901
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-06-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [513ae848b668647093ae4161718b2585d80fdb7a]

        Fix extended tips in labeloptionspage.ui
        
        Change-Id: Ib82fd7a19a837521afbe0d0a6c154d4c5c5f2824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135755
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Martin Srebotnjak  <miles@filmsi.net>  [c6c732e640ae0221e059e7b179edbf78ef7ca30e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 140d3bcbbdf20e83d772d419515e49846ae7e105
          - Updated Slovenian translation
            
            Change-Id: Ic93876c783b228af11b625e1a2e7370567798a84
            
2022-06-15  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7aadae242747bc09b316cfec9ff23b0d2690794b]

        Update git submodules
        
        * Update translations from branch 'master'
          to ef3257698791a7e3312d5d859ac8229ee48a0e69
          - update translations for master/7.4
            
            and force-fix errors using pocheck
            
            Change-Id: I748d74278038427100e6927f374e17d69a2eaee9
            
2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [1089c1baa887a7120d17707d8b54925fa5c2feee]

        Advanced Diagram support: make UI visualization experimental only
        
        In 391cb44d415e2126f668ecf62387d5e98ffa6f5c
        "Advanced Diagram support: UI visualization & simple interactions"
        added a UI visualization to advanced diagrams.
        However, the feature is incomplete at the moment, specially towards
        LibreOffice 7.4, thus, make it experimental for now.
        This can be reverted later on
        
        Change-Id: Ibf21d11899460ab9ef1ddf91cffb851171119618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135912
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [fc5357935cc160fd19b61db7cbf7f098962d42a3]

        tdf#52602: sc_vba_macro_test: Add unittest
        
        Change-Id: I3e6ab3d8f3e9dddfec90f1a9762e7bf2007c10db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135899
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [157d58605acc714a5756525b567d6b59a1322d35]

        Fix typo
        
        Change-Id: I9769e01a95b10a798769104e16e6b0c37585a2d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135559
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Michael Weghorn  <m.weghorn@posteo.de>  [8bb6190dd406390b404f0c1855894e8a48d0fda2]

        tdf#147084 sw a11y: Ensure focus event gets sent when moving to table
        
        The code responsible for sending an a11y focus event when the cursor
        moves from elsewhere into e.g. a table cell depends on the fact that the
        cursor was previously not in that object, i.e. the previous/old
        cursor/caret position is -1, s. e.g.
        `SwAccessibleParagraph::InvalidateCursorPos_`.
        
        Already setting `m_nOldCaretPos` to the the actual cursor position
        instead of -1 in the `SwAccessibleParagraph` ctor resulted in that
        assumption no longer holding when initially moving the cursor into a
        table (cell), so no focus event would get sent and
        the NVDA screen reader on Windows would therefore also not refer to
        the correct a11y object when handling the subsequent CARET_CHANGED
        event and fail to retrieve the caret position in the previously
        focused object (because focus/cursor have moved on).
        
        Make focus announcement work by only setting `m_nOldCaretPos` to the
        actual cursor position when processing the corresponding events related
        to change of cursor position, not in the ctor.
        
        Setting the cursor pos already in the ctor had been added to fix an
        issue with IM handling in
        
            commit 817da76529aa39f641d76805d429b09681348811
            Date:   Sat Nov 8 19:37:22 2014 +0300
        
                fdo#85912 Delete surrounding text failing for input method calls regression.
        
                When Apache OpenOffice code was merged in, a few lines were removed for
                no apparent reason.  This just adds the code back in, and resolves the bug.
        
                See the comments in fdo#85912 for details about this bug.  It is hard for
                majority language users to reproduce since they don't use ibus/kmfl to
                type their language's letters.
        
        The issue mentioned in the referenced tdf#85912 (== fdo#85912) is not
        reproducible for me with this change here in place either, neither with
        the gtk3 VCL plugin nor with kf5 (for which the relevant IM handling has
        been added in the context of tdf#149255, which has some more
        information on the ibus/kmfl setup needed to reproduce the
        original bug). The bug report already mentioned that the issue
        was reproducible with Linux 13 Mint and LibreOffice 4.3.3.2, but not
        Linux 17 Mint with exactly the same LO version, so without being able to
        analyze this any further, the best explanation I can come up with is
        that the root cause for tdf#85912 was somewhere else and has been fixed
        in the meanwhile.
        
        In hindsight, comment 5 in tdf#85912 already has further information
        on why adding the assignment back to the ctor was problematic:
        
        > Reviewed OpenOffice code as well.  The missing lines exist (but are
        > commented out) in the current AOO code.  The commenting out
        > occurred when Steven Ying implemented his huge "AOO IA2 enabled draft
        > version 1" change on 27 Sep 2013.
        > https://github.com/apache/openoffice/commit/0deba7fbda3d9908785c25a443701a293b6f4e71#diff-50d752f41bb880abd1094d09d9e1a7fc
        >
        > The current AOO comment is
        > // If this object has the focus, then it is remembered by the map itself.
        > // not necessary to remember this pos here. Generally, the pos will be updated in invalidateXXX method, which may fire the
        > //Focus event based on the difference of new & old caret pos.
        > //nOldCaretPos = GetCaretPos();
        
        Change-Id: If8cd4e92bc1f6233775ccc2834230f3a388ccadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135868
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [21747f8ef471080817db464a91ef203813e84677]

        Make sure pEntry is not null
        
        Crash seen:
        >	mergedlo.dll!SvTreeList::GetDepth(const SvTreeListEntry * pEntry) line 106
         	mergedlo.dll!SalInstanceTreeView::get_iter_depth(const weld::TreeIter & rIter) line 4230
         	basctllo.dll!basctl::SbTreeListBox::FindVariable(const weld::TreeIter * pEntry) line 271
         	basctllo.dll!basctl::SbTreeListBox::FindModule(const weld::TreeIter * pEntry) line 695
         	basctllo.dll!basctl::MacroChooser::BasicSelectHdl(weld::TreeView & __formal) line 473
         	basctllo.dll!basctl::MacroChooser::RestoreMacroDescription() line 158
         	basctllo.dll!basctl::MacroChooser::run() line 178
        
        Change-Id: Ic85758c0bbee952d0a23b1d52e8bbdd231e8de26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135914
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-15  Michael Stahl  <michael.stahl@allotropia.de>  [932a8efce878547bfd81521d0cf1ddfe8dc33ec6]

        tdf#135976 sw: preserve flys on backspace/delete with redlining enabled
        
        This is a continuation of commit 85376a02348810812d515ee72140dbf56f2b6040
        for the case when redlining is turned on.
        
        Also try to restore the anchors in SwUndoRedlineDelete.
        
        (regression from commit 3345feb67f2c49a1b76639965b56968e1c5f03ee)
        
        Change-Id: I4199f5755398d469a606618c037ad9756cb7aeba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135909
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-15  Michael Stahl  <michael.stahl@allotropia.de>  [f31f11f3222933dbc96dc672e6fa52233cda12be]

        sw: fix odd m_bCanGroup check in SwUndoRedlineDelete
        
        This looks like copypasta, presumably both flags must be true to allow
        grouping.
        
        Change-Id: I96afeac98f94b122a3b1a155940776a3aa44b0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135908
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-15  Michael Stahl  <michael.stahl@allotropia.de>  [cf9a16caf5012d65b2a45a5525e36e40585dd35c]

        sw_redlinehide: skip unnecessary updates when undoing redlined delete
        
        When reproducing tdf#135976 and then Undo, an UAF crash happens here:
        
          assert(!pFrame->GetDrawObjs() || !pObjs->Contains(*pObj));
        
        The pObjs was actually deleted and then re-created, because the pObj was
        removed from the frame and added again to the same frame.
        
        This is a bit unexpected, so prevent it by taking a shortcut in the
        caller UpdateFramesForRemoveDeleteRedline() to insert a check that had
        been removed in commit 14e87a4b15d31a34e6053f6194688f3aa23af991.
        
        If the rPam is inside a single node, the sw::RedlineUnDelText hint that
        was sent to the SwTextFrame should be sufficient to update it and the
        rest of the code in the loop that deals with newly split paragraph can
        be skipped.
        
        Change-Id: I5f36eb91bc20003887ee0bad03ea4a6e67135de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135907
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-15  Michael Weghorn  <m.weghorn@posteo.de>  [d8e827890f9ff3fca642b3af9475704fc376f845]

        wina11y: Drop implemenation for obsolete IAccessible::put_accName
        
        Just return `E_NOTIMPL`, as the
        `IAccessible::put_accName` doc now says [1]:
        
        > The IAccessible::put_accName method is no longer supported. Client
        > applications should use a control-specific workaround, such as the
        > SetWindowText function. Servers should return E_NOTIMPL.
        
        [1] https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-put_accname
        
        Change-Id: I4b36b6a4c4215f237ba7e7583d2f130e8d80f200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135903
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [539374caa5deac788f394a54a75b6e167ab04864]

        Show start center when closing last document
        
        also when there are active UNO connections.
        
        (Behavior was different when there were active UNO connections)
        
        Change-Id: Ief37b0f362b7e2a47eccbec985ee3017c475046c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135905
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-15  Caolán McNamara  <caolanm@redhat.com>  [2f30596347b12a7d0b9b78a1e4e2bc50eca9223a]

        don't assert on exporting forum-mso-de-104384.xlsx to xlsx
        
        a case of this -2 is also mentioned in
        
        commit 97af58093978d8e6b9d90eedcc59141304e7200e
        Date:   Fri Apr 5 22:04:13 2019 +0530
        
            tdf#123421 : xlsx export : Don't write data field entry...
        
        Change-Id: Ieded6035539df9d3896f2f08cf03c195082d4987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [18408e3405d34e039a642f2039ca8e52a1d7c469]

        Fix customslideshows.ui extended tip
        
        Change-Id: I72b861144e2634d074e7b6f7f91e27e4875304a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135613
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9c0f9b5eb7c908bb7fa5069e681a2ff5dd7257eb]

        Fix English
        
        Change-Id: I040c8052a4cf0b4a29b967483ec5d77968f80976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135659
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-15  Miklos Vajna  <vmiklos@collabora.com>  [2859ec288f2c1323ea3123d82cb1684b349ff598]

        oox: fix div by zero in lclCalculateCropPercentage()
        
        Similar to what oox::vml::ShapeType::getAbsRectangle() already does.
        
        Crashreport signature:
        
        Fatal signal received: SIGFPE code: 1 for address: 0x7fcd55eeff59
        
        program/libooxlo.so
                oox::drawingml::GraphicProperties::pushToPropMap(oox::PropertyMap&, oox::GraphicHelper const&, bool, bool) const
        oox/source/drawingml/fillproperties.cxx:103
        
        Change-Id: I0f82cbc955d9e60bad103682638b07153a5589e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135910
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-15  Justin Luth  <jluth@mail.com>  [6b6bedecf61e084e8db6b20a362a231dbac0e70a]

        tdf#145151 sw IsTableMode GetNumRuleAtCurrCursorPos: unselected cells
        
        ...shouldn't be treated as if the cursor was there.
        
        Change-Id: Ida435635aab4442b93f969d6f473aacf3f229e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134887
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-15  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [a2b4620d4981ea205788b0a786845cf9ffdbf21d]

        Related tdf#101285 - Remember position of conditional format dialog
        
        Change-Id: I4094fb46bb6130f4befcc25136424a45b90b9d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135897
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [636a22ffd7769c5f31844e66579c78928434df81]

        use stack buffer in transliterateImpl
        
        Change-Id: I7c3e24f3974dafeb9abb2af9e2a986003af7bfc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [06c3bd93379053862e57221a550e4e07129bff49]

        unnecessary realloc
        
        the transliterate functions will realloc the Sequence, no need to do it
        here
        
        Change-Id: Ia53e79b7586679b5c8a2a47c11b86e336195a4cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8e27e5b010d4d98400c97e5575ad77844848d7c7]

        Fix English in extended tip
        
        Change-Id: I753fe8c17a572c734bb4f865c0b9920285849ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135623
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ada38e5fc7c230e7861a00a6f3433dd5a11b5d3e]

        Fix English in extended tip
        
        Change-Id: Ice84ca4c1c6eed9e21e3d5916f47e686b61c79b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135621
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [641c95231ac0ca7e107da6cd931e92a870beb770]

        Fix English
        
        Change-Id: I45615f217120d90cb255ce1a3e9e1f710603770e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135663
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [839584cc3ab9583c1eaf2b513b38783e313052c4]

        Fix definition
        
        Change-Id: I4dbe6fcd04aebc25a17263f160b7683cbf01ac30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135671
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [fdde571c6a5ec65a24c496af4c5928e22bd89ba2]

        Negative percentile should be treated as 0
        
        Change-Id: I460cd2ea6950cf9f8bc656a94c71973bd93c1fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135879
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e726dcccabf0be4b880c6ddfaf0130dfd86aeb9f]

        Improve extended tip in splittable.ui
        
        Change-Id: Ie29092ed3a37cfd6bd0c95148a3edc5559ac260f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135763
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [072aec19257746008c70686be367373e7f7e022d]

        Bump xmlfiltertabpagegeneral.ui to latest Glade
        
        Change-Id: I0686e41c75c9887264c619d3f477bb7ca3c3a1fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135610
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Caolán McNamara  <caolanm@redhat.com>  [b8d8df6b8aeadb662dcaae3d3b36e054568084cf]

        ofz#47699 Timeout
        
        Change-Id: I8445fef2a116d063c15f65ed4c8ac705a8ce7491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [34293f75060061d248c178cc65b81135a01d8dba]

        Add precisions to opttablepage.ui extended tip
        
        Change-Id: Ic2f07d9a4e8e8608e5a56f23d421004f6631427a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135760
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfb0aa8ca36956690c963e3edfb1a2d78e908ba5]

        elide temporary string in comphelper::strip
        
        Change-Id: I093768c617490679d295cce37cc3ffe67c8e940a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135871
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8611bf020248d2b94e673465e22bd1db80f7eafd]

        Add precision on tocentriespage.ui
        
        Change-Id: Ibdaa15e1d573f34e3098bf00b883752ce4df40c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135767
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  offtkp  <parisoplop@gmail.com>  [376be26f4ebc5876ef93e7470ccbf85d21bf77cc]

        Add support for exporting EMZ/WMZ
        
        Split xcu files for Z compressable graphic formats. This introduces a
        new option for exporting each Z compressed graphic format without
        needing to check for extension.
        
        Change type detection accordingly in graphicfilter.
        
        Change-Id: Iabb971123f5e394196716900796632cb8ed12ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135181
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [7e81b2292fa881f5c6efecd259fbbb82a1c75759]

        vcl: change maList in Animation to maFrames
        
        Change-Id: I2358434ffa3aff8bda16576bf8849eed52a3edd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76401
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [bae82d9a57e2ed399f43ce1fe785509b8ab853f0]

        CppunitTest_sc_macros_test: move test where it belongs
        
        Change-Id: I95fd738f4fa8e93c1d90f4b8701e36facadaa7fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135865
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [eeb6f0740903a7e78156cf755cc442383ace77d9]

        Use rtl::isAsceeLowerCase/rtl::toAsciiUpperCase
        
        Change-Id: I61593b4f147bb2b83bd979f8fd429b70b3286d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135885
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [964eb2f1dd24d68bd1d6caf8d0f349305a2642ec]

        Revert "simplify SharedString::operator=(&&)"
        
        This reverts commit 2da1cdd31312a70f205f29bb4dfcbc1771409aa4.
        
        Comment from llunak:
        I'm possibly not remembering it exactly. But the point is that if you're going to destroy something, it's faster to destroy it outright rather than move it somewhere and destroy it later. If you google it you'll find posts on how implementing std::move() using std:swap() is generally a pessimisation.
        
        Change-Id: Ice4234ad074cd894a25782e9c52b34c5acb26c8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135880
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Caolán McNamara  <caolanm@redhat.com>  [dc051857c36a2f1e27cf149c13bd0e199db60109]

        crashtesting: assert seen on loading forum-en-38962.ods
        
        mismatched Push/Pop, catch offending exception
        
        Change-Id: Ib2297a8ab04a2f2491e4c922d9e4db82a66ea911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135825
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2203f68050bb0478322ead24f380f19792f9a21d]

        Bump opjecttitledialog.ui to latest Glade
        
        Change-Id: I37fea3c5788ce4fd00bec50276bb6c41e11cdb99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135626
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [00e522e8eb8028ae81b321b728e1b6ff83eea83f]

        Bump envprinterpage.ui to latest Glade
        
        Change-Id: Iaed3953370a3e12aa1150dd6878d797ec0f9179c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135660
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Jan-Marek Glogowski  <glogow@fbihome.de>  [14dfbfe1da056d9570c85df8b5d5bed3943d46e9]

        Drop SalMenu::DrawMenuBar (is WIN-only)
        
        This follow-up on commit 483f3125ecd4744cbcc2f8fd3cdf243d81a601ff
        ("WIN drop effectively empty ImplDrawMenuBar") should probably
        have been included in it. Windows was the only implementation of
        that API, but the API is just called for a native menubar, which
        Windows doesn't use (VisibleMenuBar returns false). Maybe Windows
        SalFrame::SetMenu should also be dropped?
        
        Change-Id: Ic3600e66c91ce9d56d7f911bce5674e0a9ee833c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135633
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [76e7418809c73dfb69411a4d96ce8dc321a01e38]

        Bump optgridpage.ui to latest Glade
        
        Change-Id: I4b862e1f5c8ceb3adfe5009cf13b32073c3ebb5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135670
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a55812aa84a9b416d181ff70d22b86435a4ac5af]

        CppunitTest_sc_macros_test: split it into two
        
        The .cxx are already separated, use a different
        makefile for vba-macro-test.cxx
        This might help to mitigate the CppunitTest_sc_macros_test
        failure happening in Jenkins on Windows
        
        Change-Id: I5708de3527041a5fcb33287f75f0e14642a88c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135862
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [5b69db47543946a1a27c821f174b277e8e16145d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 70653442aed4591284e2f543d74e5309f510ab87
          - Clarify URL inside this document a bit
            
            Change-Id: I7fdd48bd925619b42452df88fd8343727e1a2667
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135882
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-15  Eike Rathke  <erack@redhat.com>  [8661d5579bd19a9e294ddff64bbe817b537dbd46]

        Resolves: tdf#149325 tdf#52602 SvNumberFormatsObj::queryKey try also uppercase
        
        ... keywords; that should catch most lower case queries. If there
        are still remaining mismatches then either implement the bScan
        thing, or enhance addNew() to not fail on case-different format
        codes. That could be hit for the `General` keyword, for example.
        
        Change-Id: Ic728b8c5e38db76eb791cb305595f84acf7dc867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135854
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [20b19869eab5b991551a6bee7803e5b5c3dffee3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c1f8b9235eccee7650a0bc836c5543fc503be9e
          - tdf#148901  update Left Page Border and Right Page Border
            
               tdf#148593 changed the option labels:
                  "Left page border" -> "Left of page text area" and
                   "Right page border" -> "Right of page text area".
                This patch updates the option names and makes
                corrections in the description of the referent of these options.
            
            Change-Id: Icf1bf4d493bd0c1b23b46f99e487defcd57b1587
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135875
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-15  Miklos Vajna  <vmiklos@collabora.com>  [a234afc347a3310b0c418cc3f2bf5aed3df62d85]

        CppunitTest_sw_ooxmlexport15: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I4ab9af48f80cd5f61db05554d31a8f02b89990ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135857
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-15  Caolán McNamara  <caolanm@redhat.com>  [a1f42313e51f10d586d94297335da77a16cfab32]

        fix oss-fuzz build
        
        Change-Id: Id9eeea1c57a4461e0d178492c6472174ff78065a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135867
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-15  offtkp  <parisoplop@gmail.com>  [de22386cec6e2613e034a56ffe4bd505b4534dd3]

        Add unit tests for ZCodec
        
        Add unit tests that check compressing->decompressing a file should
        result in the same file. This is done by comparing the CRC32
        before and after. The same tests also implicitly test that
        compression/decompression works by checking the return
        value of ZCodec::EndCompression.
        
        Cases added for both mbGzLib=true/false.
        
        Change-Id: I5516760eba5f233c20331cef83fd0b1a1603373f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135233
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-15  Stephan Bergmann  <sbergman@redhat.com>  [fc898f20cffe94cfde0a24027480fb97ab84563e]

        Use some more appropriate index variable types
        
        Change-Id: Ife891e8757e3f83d53245dfd04594b0359a897cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135831
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7efd118d5d48e1d4b2f57752cb3b9170f5c05f71]

        Bump datanavigator.ui to latest Glade
        
        Change-Id: Ieebec25767282248a77b0c28a69afc2fa39348af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135662
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9c36b4d2aca72490781633bd9b023b6d5d7a3fbc]

        Bump optgeneralpage.ui to latest Glade
        
        Change-Id: I45998a83698831af510aca3dbcf52a8bed4154b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135666
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [51fb599f98e7b7814eaad7cf8e8d10f24aa86a2e]

        Bump insertdbcolumnsdialog.ui to latest Glade
        
        Change-Id: I6bc529308735d5f4cff90c6f55f399f64019713f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135668
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Caolán McNamara  <caolanm@redhat.com>  [0ce654a5858eee15a319526b996a6368c145888f]

        crashtesting: negative index seen on loading forum-de3-15472.ods
        
        Change-Id: I737e6132f117a85c4d7e5df4a33561d09eff86af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [ee0a296ff97f5e2fc18f6f7ac83540121be84028]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff415c86e59a656e2515c54cc64c57e9f96d509f
          - Fix some function descriptions
            
            Change-Id: I85bd929ab1febed3f1567a911ee188e134afe847
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135876
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [dcb36da2950ad967ad3f633ca12353da98ac620b]

        clang-tidy modernize-pass-by-value in drawinglayer
        
        Change-Id: I8a3245c6a4d687edbc95cf28b2932d80c86a7b65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [2da1cdd31312a70f205f29bb4dfcbc1771409aa4]

        simplify SharedString::operator=(&&)
        
        the release will happen in the destructor
        
        Change-Id: Ibb1f2ca11a157affdcfa9e0959558945657caa21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135856
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [1cc9f4d972f8a5e1e3f4980942e128dee9a2701c]

        tdf#126109 calc slow when replacing string to number
        
        retain the column block iterator array during the process, shaves 20%
        off the time
        
        Change-Id: Id492cf142ecc34af6fd236135d87f49b5a630d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135855
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [1968563b1dec40f2134a04b1241178ae27b0d6bb]

        tdf#149507: sw_uiwriter3: Add unittest
        
        Change-Id: I3268e2b286045257f2974b6b0397991d3aebc0eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135820
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [47f1602b2681130e1400a37909fac3dfa7f667bb]

        Fix with-vendor for cross-build targets some more
        
        Regression from be2252c8d3e5d892ec1e6b12a2b55c2026597cb9 where spaces
        in --with-vendor end up being poorly quoted.
        
        Opted to pass down --with-vendor to sub-configure unconditionally even
        if empty, due to the need of word splitting generally being needed for
        the sub_conf_opts variable.
        
        Change-Id: Id3740255bc8fbf98adf7464de7e2836fcde9f2fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135826
        Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b97420c5bc72504cfbf793aaa7837ebe812399a]

        tdf#149325, tdf#149531: sc_macros_test: Add unittest
        
        Change-Id: Ie6d9f75f2dd3ecb92eed4d464b4c36fd993076f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135819
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [4e8295638e68295d73b49ddb80e23c3509a49b3e]

        tdf#148868: sw_uiwriter3: Add unittest
        
        Change-Id: I110079662cb001bbe3044138a1e7d23383cc083d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135827
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [ac4719fe7365fb77c82bf5d937af069942671084]

        Revert "Load the locales from config file for languagetool"
        
        This reverts commit c3ed41752237a7a70c856dfb0d618f1c2eacea5a.
        
        Jenkins fails in CppunitTest_sw_core_draw on Mac and Windows
        
        Change-Id: I3e2b6359f3238a1b8af2e98d3cb5eee7aa864bae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135859
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-15  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [0c96561a567fd7dbb394a1a44479a42aa149bcc7]

        Bump minimum macOS to 10.14
        
        This gives us full support for variant, optional, any and visit libraries
        
        Change-Id: I9f1bff5d7c0e2d5acc8c8b92c9a269b00e317574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135804
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cb83063cc0eb4e93bd44bc0cb9b7c4841230cdef]

        Bump printoptionspage.ui to latest Glade
        
        Change-Id: Ief4eb8d551df8be318ceec82f2564877ccca7e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135761
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d05fb4f0bf737f4a2e70e9400cc94e11f5b870f9]

        Bump javastartparametersdialog.ui to latest Glade
        
        Change-Id: I01679630ef66f88acbd3412ce5ec3cd3994f2b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135622
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9c407a5fc6ed8e8b409cdb2b83245f3ce2339318]

        Bump textgridpage.ui to latest Glade
        
        Change-Id: Id8ae5ee23f9ca19be98586ecafbcce54b574f9de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135765
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-15  Justin Luth  <jluth@mail.com>  [1a57418e2837e7fd07b0619804feed06e1acfe41]

        remove unused sw UNO_NAME_CHARACTER_FORMAT_NONE
        
        CharacterFormatNone seems to be orphaned code.
        Was this ever written out to file? If not, then it should
        be removable because I don't see anywhere that it can
        be set.
        
        I found this while working on tdf#75297.
        
        Change-Id: I3212ab7dcda3c46adfe638ee1ae412a3ede8762c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134889
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-15  Justin Luth  <jluth@mail.com>  [5036c5a7afdd043c3fa5c108c985cd0d8ed352fa]

        tdf#145151 sw IsTableMode SelectionHasNumber: unselected cells
        
        ...shouldn't be checked
        
        This followup patch checks the proper cells to see
        if numbering or bullets are turned on.
        
        There is one side effect here.
        Picture this scenario where you
        select some paragraphs (_ indicates blank paragraph)
        _
        _
        1. some numbered text
        _
        
        In this non-empty case, SectionHasNumber is true,
        showing numbering on in the toolbar.
        
        Prior to this patch, the following scenario was "false",
        showing numbering off in the toolbar.
        -
        -
        1._
        _
        
        and the result was that all the blank lines toggled on.
        Now it acts just like the non-empty case. Although one can
        dispute that this is the correct action, consistency is nice...
        
        Change-Id: I8a1b8ee0fe947a7bfe7906a0add3aaf2d8e7b232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134886
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-06-14  Eike Rathke  <erack@redhat.com>  [9470c5531dc928d438a6a7f4d47f2d82f2296cc1]

        Related: tdf#149325 Fix yet another VbaRange empty ScRangeList access
        
        Change-Id: If2c44795ab794482b841138bdd55f37c4d30b592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135824
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-14  Caolán McNamara  <caolanm@redhat.com>  [c776524c5dda930a6c82cb81b594769802445c79]

        ofz#47668 OOM on massive line widths
        
        Change-Id: I310a9d438ef6f50ecc5931cea12fb26b7ed600c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [629d2db54bd9f97d2c494b85637a83229275a1a6]

        tdf#149554: sc_ucalc_copypaste: Add unittest
        
        Change-Id: Iba3cf497cdfaca64b75303d40bb062869bf3a50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135816
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-14  Aron Budea  <aron.budea@collabora.com>  [b33d89d8e97ba4bfb17743632dee471727d11ac5]

        tdf#149536 Move Up/Down in Data Table switched enabled statuses
        
        Regression from aa7e7747f4296b3b92379c3c7703b80ad8af6a8b.
        
        Change-Id: Id2b66b2e87fdb13a55b32a4989cae2c7796fd003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135801
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [691ff87812d3ebe1f7bb360f431859df16099d1a]

        Bump addconditiondialog.ui to latest Glade
        
        Change-Id: Ibd271a67456169837991fe16fd4cc35c240d5a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135624
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8586ce7315aac6575bff0a14e86c68e0b9abe8f4]

        Bump cellalignment.ui to latest Glade
        
        Change-Id: I2e34fb5acf84716f50d14070722ecebe88d836fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135614
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ae98da2ca0076dc962c6e9b4a9623ba2bc990425]

        Bump dimensionlinestabpage.ui to latest Glade
        
        Change-Id: Ide76dbdbd5e5b57f2d2790f3aac1b61c9f39cd04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135616
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [76f7f0c167a5148c01cdb1e0d8ea56b905f5a875]

        tdf#149351 Add a 'Turn off mouse as pen' shortcut
        
        for UX compatibility with PP: Ctrl-A turns off 'mouse as pen' mode
        
        Change-Id: I0379580f4034f07f044dc1079c14898f3014face
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135579
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [817f98279b58a0eaaa0e5ac26f76f1d2788c39ce]

        Fix extended tip
        
        (after translation round)
        
        Change-Id: I4eea58f44af49d19de9b1aa44fc9ad15e8edda12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135609
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Caolán McNamara  <caolanm@redhat.com>  [51ed616b278b257a490bc52b69d0bf9ed8de1e4b]

        crashtesting: crash seen on exporting forum-it-5909.ods to xlsx
        
        Change-Id: I64b629e2f5b0ece7f903049bd006775463f97586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135818
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-14  Caolán McNamara  <caolanm@redhat.com>  [66b849eab05bb6b696cced84ca90c17ca1bc31dd]

        stop using removed ---with-idlc-cpp=cpp argument
        
        Change-Id: I8ff0dd5314027e136782c236faebddd1077b180d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135830
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [d72bee64a97650507d042f17846b6fc427b8434c]

        tdf#148868 sw: handle selection then Insert similar to Replace
        
        ... if the selection is inside one paragraph, to avoid deleting flys
        anchored in the selection.
        
        From a code point of view it's a bit inconsistent to do this, but
        from user point of view there are some ways to conveniently create
        a selection such as by double clicking a word.
        
        (see also tdf#133957)
        
        Also in SwWrtShell::AutoCorrect(), which oddly enough might get called
        with a selection from textsh*.cxx, at least in theory.
        
        Change-Id: I8cf9459e5a7ec7754ce8fe323cd158c7e84a5c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135606
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [ec1019f2dac25d8e3d114553ff26eba21275f649]

        Make PARTIAL_FULLSCREEN a X11SalFrame bool
        
        SalFrameStyleFlags::PARTIAL_FULLSCREEN is just ever read in
        X11SalFrame, so there is no need to have it as a "global" flag.
        Just save it as a member boolean and drop it from gtk3.
        
        FWIW: consolidating all the booleans in X11SalFrame as a bitfield
        (AKA reorder the fields and declare them bool myvar : 1;) might
        be a nice easy hack.
        
        Change-Id: I6a94310d3b734ecfd083b520d613a076b1e7670a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135805
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f004c9fd176b42435cfde8dbe6ccee55cbce40d2]

        Fix extended tip of textgridpage.ui
        
        Change-Id: I2c59a0c3299aec96b27b37d95cfe4343a064f148
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135766
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [94399604def7c421acb9a84b9d6b97cc0d02516b]

        Fix English in validationcriteriapage.ui
        
        Change-Id: Ibfa172839f71c2b640c87edafa5d4ee1ef687915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135770
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [be050dfb9122bd5db65dd6f870f4e4d61900e989]

        Add better English to tocindexpage.ui
        
        Change-Id: Ieca4de5a09d7d38454b8c09481792c95d12d21ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135769
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2d4ac11358f07cdf71b9a24e02bce0fbd48f42ad]

        fix extended tip in sc/pastespecial.ui
        
        Change-Id: I8e6f6c227b0be37dea4c31f17df6eb8581d4f1ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135764
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5d2930c5cf10dc03a34ef871e9d2c55b68e3cff4]

        Include precisions for printing comments in extended tips
        
        Change-Id: I74d50a1b9af5485da6599eb2f3213f3cdc10c755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135762
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b63b116fa60fcb1326195eabf9ea4c5445c15a1c]

        Fix extended tips in mmselectpage.ui
        
        Change-Id: I7c66b1359aed06e20f27e00e1eface041b48f630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135758
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [df030f6e632ab0046bd51d1f8425ecd8362c2b33]

        Fix unicode nomeclature for specialcharacter.ui
        
        Change-Id: I2bc877046eaa6cab635008f3cb9ec7ab2cea0aec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135757
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8a23dffa1a54cdf5f65e8e7dcf0e96a1ec9ee9e0]

        Bump autoformattable.ui to latest Glade
        
        Change-Id: I876440946a52c58b8ff32f23f7d46cc00f9ffb15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135620
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Caolán McNamara  <caolanm@redhat.com>  [8b6c8e624b1257a2221e8f98ba71112eae86c795]

        cid#1504592 Big parameter passed by value
        
        and
        
        cid#1504665 Big parameter passed by value
        cid#1505368 Big parameter passed by value
        
        revert the clang-tidy modernize-pass-by-value changes that coverity
        warns about
        
        Change-Id: Id92fdc8d1caeed9eaf7ff1e9e745938e5a971a34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135803
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-14  Michael Stahl  <michael.stahl@allotropia.de>  [6de844c5da695bf4605bef5510d33e74a7ff04ee]

        tdf#149507 sw: don't delete bookmarks in SwUndoInsLayFormat::UndoImpl()
        
        The problem is that the CorrAbs() here deletes the bookmarks in the fly,
        and this isn't supposed to happen at this point, because DelFly() will
        call SaveSection(), which saves the bookmarks in the m_pHistory via
        DelContentIndex(), so that they can be re-inserted in Redo/InsFly().
        
        Also change the code that was inserted in commit
        0ee28fdf3e9a0bd8763eda6299af1d5c873a9dcf to not call CorrAbs().
        
        (although this bug has existed forever, crashing is a regression from
         commit 657de5fba12b0e9afcdee361654d2a2d0dbd7311)
        
        Change-Id: Iabac0ccf5587d5d974e88cbbc3e05bbaed3526f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135728
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-14  Luboš Luňák  <l.lunak@collabora.com>  [ef1be22efb3e1625da1683ea98392cc41657b1cd]

        allocate columns in ScTable::TransposeClip() (tdf#149554)
        
        Change-Id: I2ae151ed9656884bca6963ba09bdf236e09096b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135774
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-14  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [7b12c659842eb53b96dd98ecea65c6071506dfbb]

        tdf#131506 tdf#143031 EMF+ Fix displaying PathGradient fill
        
        With previous implementation, the EMF+ import is calculating
        gradient positions wrongly. It is causing warning:
        
          SvgGradientHelper got invalid SvgGradientEntries outside [0.0 .. 1.0]
        
        and the gradient was not displayed at all.
        This patch fixes that and gradient is displayed correctly
        
        Change-Id: I6229c516165436d0c7ae187d9eb69b5494da396f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135607
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-06-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [4879f99b824036b3d409ed52f74dc3eb3b4949e4]

        Fix leak with stock widgets in a dialog from an extension
        
        When loading a dialog from XDL, buttons can have dlg:button-type="cancel"
        or dlg:button-type="help". These buttons might not have a peer when
        they are not referenced from the extension.
        
        In this case, they also weren't disposed when the dialog was disposed,
        leading to an abort on exit.
        
        Change-Id: I799d7535b766984fde47cafbe41ee6e89e476205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135266
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-14  Mert Tumer  <mert.tumer@collabora.com>  [c3ed41752237a7a70c856dfb0d618f1c2eacea5a]

        Load the locales from config file for languagetool
        
        Locales needs to be read again
        in the Preferences/Writing Aids section and since
        this is a network operation it can cause a problem.
        Better to list all the supported locales in the xcu
        and load it right away.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: Ifff624334627f7be259b677f9b416d6ddedfb2c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135598
        Tested-by: Jenkins

2022-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [7353b79dfb7c206e99865e345c31b4da27111715]

        sw: uitest: remove assert that fails depending on which...
        
        ... components are installed
        
        Change-Id: Ib0090d6afcc824942ac9a0c89757ba7faf068637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135798
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [d0f61d94d6bd3e377083eba2c2de84442963c017]

        better solution for ignoreLocation for tree-wide plugins
        
        Change-Id: I7336003e038781d4ef50380fa49f66b5ff19379f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5dd9aeb8250890047732ef5dca9072a0ecc32f58]

        svx: remove annoying whitespace in SdrView and subclasses
        
        Change-Id: I3eb1949c0024ab0241a26c7dec410c774b91cdcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135793
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-14  Miklos Vajna  <vmiklos@collabora.com>  [b6758293e65864530f1b2508ec426bb4f0268c75]

        Remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: I157b331195cc8262e6bd1dcc536cb653587fc45f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135775
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [b7d6c3ce33ae06e6a61eac0e185121cb3931f61f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4252eedb1e8e11aaae5e4d5e1b1f6f1c24067afe
          - (related) tdf#149018: "Object"-> "OLE Object" for Insert and Edit menus
            
               tdf#149018 changed "Object" to "Ole Object" in the Insert menu
               and the Edit menu. This patch updates the relevant command
               sequences, and uses <menuitem> on changed sequences.
               Also updates the help pages for OLE Objects, including
               refactoring to <h1>,<h2>, adding variables or sections for
               embedding, and changing some items to embeds.
            
            Change-Id: I6931305d3576458f3f0dbec59a4ecbe00cdcf68a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135009
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-14  Michael Weghorn  <m.weghorn@posteo.de>  [4c8537589f2a73d1fbecaf4c1e9c64627b79e542]

        liblo-native-code: Add LanguageToolGrammarChecker
        
        Fixes Android Viewer crashing after
        
            commit d952df361a5e190246d7a0738ae5347b82cd57b5
            AuthorDate: Tue May 10 13:06:06 2022 +0300
            CommitDate: Fri Jun 10 13:52:17 2022 +0200
        
                LanguageTool Grammar Checker implementation
        
        when opening any file, with this in ADB log:
        
            06-13 16:14:07.274 20696 20736 W cppuhelper: 1:cppuhelper/source/shlib.cxx:299: unknown constructor name "lingucomponent_LanguageToolGrammarChecker_get_implementation"
            06-13 16:14:07.274 20696 20736 W linguistic: 1:linguistic/source/lngsvcmgr.cxx:1028: createInstance failed
            06-13 16:14:07.274 20696 20736 E LibreOffice/androidinst: SalAbort: 'Unspecified application error'
        
        Change-Id: Ib4316b576636d35a383d5c11c36c92a8c67a302a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135730
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-14  Michael Weghorn  <m.weghorn@posteo.de>  [3318742094157b6baf57f2294731b8dec8da73ad]

        android: Update com.google.android.material to 1.6.1
        
        Change-Id: If5aebe347534745065b371190abffce2421655f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135729
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-14  Eike Rathke  <erack@redhat.com>  [d6331fc7abe545ff0a369c41ab3f55b8f44a2cc1]

        Related: tdf#149325 Eliminate all unconditional ScRangeList::front() access
        
        ... to prevent crashes, and where possible substitute a missing
        element with the original sheet object range.
        
        Change-Id: I245844e89fa3eb7d6ec07e279bdd23022fd77958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135773
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d0fb2e4c2d5eb23b2a278e532d16e0652070a05b]

        Bump tocindexpage.ui to latest Glade
        
        Change-Id: I0c93e8115a64824170ccc40bd793f803d45f6afa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135768
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a809e8d53e54a86f4e7fea17f01fe345ae818907]

        Bump opttablepage.ui to latest Glade
        
        Change-Id: I23e95e46ffe476a675bdb66e35c78c57b8eadfbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135759
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-13  Miklos Vajna  <vmiklos@collabora.com>  [214438f1dcce52043c27c39e529cf60ff96c98cf]

        vcl: restore lost spinner images
        
        This went wrong in commit 13aa5081793f133077610cd01b7f01ee765b4add
        (remove unused defines, 2021-11-19), the trouble is that
        postprocess/CustomTarget_images.mk needs these images to be listed in
        bitmaps.hlst explictly, and the makefile won't see that the same names
        are used in Throbber::getDefaultImageURLs(), constructed dynamically.
        
        Change-Id: Ie7ea1734ed417d17e1ce54d6a755509ef52572d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135725
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-13  Balazs Varga  <balazs.varga991@gmail.com>  [be2252c8d3e5d892ec1e6b12a2b55c2026597cb9]

        Fix some cross-build targets errors
        
        1. error - if disable JAVA is configured, set '--without-java',
        otherwise it breaks python for the build part.
        2. error - forward '--with-vendor' setting to sub config,
        to avoid stupid windows system variable error.
        
        Change-Id: Icebdfc5d6d2816fa53538d83d3ea206a6e99ddd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135724
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [77a28966f06a7f872b305ff8e2c603e675a5c8d1]

        uitest: sc: reset values in paste special dialog
        
        in preparation for https://gerrit.libreoffice.org/c/core/+/135110
        
        Change-Id: I0bfa8ddd9b814239a0e284b1b219cf760ee34826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135733
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [31bf1a7f18de43014700869910767c8264cbd743]

        Bump specialcharacters.ui to latest Glade
        
        Change-Id: I5b001f5c38dda46f16e4a9619250d868a9489cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135756
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-13  Julien Nabet  <serval2412@yahoo.fr>  [2b7979d781b9e46161dcdfcab0e258af5e0b12b6]

        Revert "tdf#98743: TIFF export uses 96dpi by default"
        
        This reverts commit 988285410f8883ad49f32c4b804c4f5bd14569d0.
        
        It worked with brand new file and A4 example but not with attachment of the bugtracker.
        
        Change-Id: Ia33d06a994dd80a8fe0e0837f4e91fc8fdd5ce63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135795
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3b3b1730a96df7dac1dbe5f8373b9c9cc7035b4a]

        Bump labeloptionspage.ui to latest Glade
        
        Change-Id: Id3f7041f913096dc3d62d8068d2a792d118af913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135754
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e0332bfb9d71a37d80602034b8cfd0efb93cee7]

        clang-tidy modernize-pass-by-value in dbaccess
        
        Change-Id: I8f89ec8a73f82fd93320a710165df17180939f96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-13  Eike Rathke  <erack@redhat.com>  [3ad12672e924f7aef394119f9fe5f0b06a900b9e]

        Resolves: tdf#149531 Use initial sheet range for VBA Columns and Rows
        
        ... if the ScTableSheetObj's ScRangeList is empty. It might even
        be that was never intended to be used and worked only by accident
        in the past (pre 6.0), but it's somewhat unclear. It may even get
        in the way in case it exists and the (first) range was modified,
        e.g. shrunk by a Delete, as the resulting column or row object
        could be different from the initial sheet range.
        
        Change-Id: Ib9911df1b23802054a5bb0621bb7f5559ef3f39b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135732
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-13  Maxim Monastirsky  <momonasmon@gmail.com>  [9bc1ffa2153d2474b023e0860d3c9c68ee18727b]

        tdf#125040 Make single mode toolbar context aware
        
        This patch modifies the "Standard (Single Mode)" toolbar
        to have an optional context-aware section, given that a
        corresponding singlemode-<context-name>.xml files exist.
        This is a lot like the "Contextual Single" NB, except
        that it's implemented with regular toolbars, so docking/
        customization/extensions/uno api etc. are all working.
        
        In addition, the "Single Toolbar" mode was modified to
        not show any other contextual toolbar. (But of course the
        single mode toolbar itself is perfectly usable outside of
        this mode.)
        
        Change-Id: Id746d9df59340a81962a8689b132941deea54b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135591
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f01b42e73af0e0baa57a353554a53d936c4f5e2]

        clang-tidy modernize-pass-by-value in connectivity
        
        Change-Id: I1f1b609254c7f8cfba14c248167f81b51684d8e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-13  Michael Stahl  <michael.stahl@allotropia.de>  [646c6ddd91a98afddf914e3889cb269fc814c060]

        tdf#139982 sw: preserve flys in Replace with redlining enabled
        
        The problem is that there isn't a redline type "Replace" so it's
        represented as Delete+Insert.
        
        To prevent the flys anchored in the text from being deleted, move the
        anchors to the point between the old (deleted) and new (inserted) text.
        
        (regression from commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5)
        
        Change-Id: Ib600c9dbfb9421917e4b8d61195c48cf0b364f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135604
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-13  Stephan Bergmann  <sbergman@redhat.com>  [5687eba49fa06202bd190c87ad8e7af634354799]

        Drop obsolete preprocessor directives from UNOIDL files
        
        ...which were used by ildc, which is gone since
        a8485d558fab53291e2530fd9a1be581c1628deb "[API CHANGE] Remove deprecated idlc
        and regmerge from the SDK", and have always been ignored as legacy by its
        unoidl-write replacement.
        
        This change has been carried out (making use of GNU sed extensions) with
        
        > for i in $(git ls-files \*.idl); do sed -i -z -E -e 's/\n\n((#[^\n]*\n)+\n)*(#[^\n]*\n)+\n?/\n\n/g' -e 's/\n(#[^\n]*\n)+/\n/g' "$i"; done && git checkout extensions/source/activex/so_activex.idl odk/examples/OLE/activex/so_activex.idl
        
        which apparently happened to do the work.  (The final two files are not UNOIDL
        source files.)
        
        Change-Id: Ic9369e05d46e8f7e8a304ab01740b171b92335cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135683
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-13  Michael Stahl  <michael.stahl@allotropia.de>  [32dd76143bdf55ac73f03f705097453521b4bf2c]

        sc: ODF export: fix style:font-name on EE text/paragraph styles
        
        The problem is that sc contains its own duplicate export of EditEngine
        styles, where the SvxFontItem aFamilyName is exported directly to
        style:font-name.
        
        But style:font-name refers to a style:font-face, and for a given font
        family name there may be multiple font-face elements whose names have a
        counter appended, and they are written in some non-deterministic order,
        so effectively this picks font-face at random.
        
        In XMLTextExportPropertySetMapper::ContextFontFilter() there is already
        code to do the lookup, and also a fallback when the lookup fails to a
        set of individual attributes fo:font-family style:font-style-name
        style:font-family-generic etc., which is actually used for fonts in
        control shapes, which have "unknown" for one of the components, so there
        could be some other problem with them.
        
        It doesn't look possible for the lookup to fail for EditEngine items, as
        ScXMLFontAutoStylePool_Impl should have added all of them.
        
        This problem was detected by current ODFunDiff in 22 of 2000 ODS files;
        with this fix only other problems remain.
        
        Change-Id: I276f705296df628b0869526f4ea676c47a014328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135684
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7c260aee331474d993bf96a72bf31f5af350ef3]

        clang-tidy modernize-pass-by-value in chart2
        
        Change-Id: I73ae444487571fb61a02a2c813c060d269d52a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [24d15ba86c00178238f3f8ef6c548a0d19338aa4]

        loplugin:mergeclasses sd::TitledDockingWindow with sd::PaneDockingWindow
        
        Change-Id: I77314048173ebba0dc0e03f710607b74e73f0bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f20da3b330a5aad88a51f454c0914789d9c2457]

        remove #undef
        
        which is unnecessary, and does nothing and seems to have been there
        since
            commit 7b1d0af8640fb4641cfdc3af752ed0bf467f9229
            Date:   Wed Apr 11 17:07:29 2007 +0000
            INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED
        
        Change-Id: Ie6eaa1a939891a056f6fd1eb207db127352fc029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135718
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e8f97879c4e677107551692fa88b0791f70bd413]

        tdf#133675 - Hyperlink dialog: change frame widtget from editbox to dropdown
        
        Change-Id: Ibb8d5b14cf0f1524f6f554ee0ab77a14507330cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135657
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1af6cba09e7cc2ff0d02179bbff81b8c05afcad6]

        Fix grammar
        
        Change-Id: I9914acada7df44548b0f1eece87445db0e69179d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135669
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-13  Pranam Lashkari  <lpranam@collabora.com>  [9518a72e71a70cee07c2ab3491a147edf9e63f68]

        LOK: send state of Protect, UnsetCellsReadOnly
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I92675ed0033088233fb442138b39a3c8d663c614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135454
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit b8626e85a799fd0807749cab9e712652240f13cd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135389
        Tested-by: Jenkins

2022-06-13  Luboš Luňák  <l.lunak@collabora.com>  [91b98efc2a5cf41d9442f90d7cb37075721519e0]

        make VirtualDevice::SetOutputSizePixelScaleOffsetAndBuffer() LOK-only
        
        Because it's used only for LOK, and SvpSalVirtualDevice::CreateSurface()
        otherwise wouldn't know whether to apply LOK DPI settings or not
        (since this might be called for LOK tiled painting, when it should,
        or it might be called from somewhere else while LOK is active, in which
        case this should be handled normally). Getting that mismatched can cause
        things like https://github.com/CollaboraOnline/online/issues/4834 .
        
        Change-Id: I1df7b8a169c8ef2e799731a6695a032948536582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135588
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-13  Luboš Luňák  <l.lunak@collabora.com>  [b7b06f28d5728c2c33c073df35ac0c3bcc51e583]

        avoid uninitialized data when handling WindowState
        
        I get valgrind reports when I start LO with kf5 backend and
        a maximized window, since in that case position and size are not
        set (since the maximized state makes them irrelevant). The semantics
        here seem to conflict, the caller of GetWindowState() sets flags
        to say what data it wants, and SalFrame::GetWindowState() sets flags
        to say what data it provides, but as can be seen here those aren't
        necessarily the same. So actually use only those flags that are
        in both sets.
        
        Change-Id: I4559baab90d6f465382560549d52431b28119b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135563
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [930ba0c1ec9620641f58573d4bcdb9755be94d11]

        Fix comment
        
        No need to mention gerrit URLs in code comments
        
        Change-Id: I445f94211a3e660aa6e3482352f56ded7465e008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135692
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-13  Miklos Vajna  <vmiklos@collabora.com>  [cad76135ef6a72b6b7aa7d9dfc81ff77d01fefbe]

        sw: prefix members of WW8DupProperties, WW8SelBoxInfo, WW8_WrPc and ...
        
        ... WW8_WrtBookmarks
        
        See tdf#94879 for motivation.
        
        Change-Id: I4a3ede4c48220fb61ee8ccb4bbfb955a46cf56d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135686
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2fded499dfab88834bc91acba1b6ae0028937f4e]

        Add XFillBackgroundItem::dumpAsXml
        
        Change-Id: I21aa5ded0c9c114199c9d503b48437ec1a6171eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135691
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-06-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [3f817355a397699953311f85a9df1358a1099c23]

        0.8 is too small on Windows; follow-up to 0ebbe1f00
        
        Change-Id: Ie7b545acdb0648bccd39d452087c0b38c8c118e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135690
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-13  Michael Weghorn  <m.weghorn@posteo.de>  [025477e244df2cdb4917e202030c3cab0536550d]

        vcl: Trigger IconView action on space key as well
        
        Handle space key the same as the return key.
        This e.g. allows to insert the selected element
        into the formula this way in Math again after the
        switch to IconView in
        
            commit d79c527c2a599c7821d27cf03b95cb79e2abe685
            Date:   Wed Jun 1 11:20:12 2022 +0300
        
                Use IconView in SmElementsControl
        
        gtk3 was already behaving that way without this
        change in place.
        
        Change-Id: I061b286723fedf023551afbb2184abc946b54b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135592
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-06-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [f41b9842557c1e475f0ea68d81e4af4274dcd49c]

        TotD: Add a couple of missing words
        
        The issue was flagged two years ago (!!) by Steen Rønnow.
        
        Change-Id: I6d023bbe7c5392038f35b767acdf7f0ad0acd718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135673
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-13  Justin Luth  <jluth@mail.com>  [9a2e7bade3aa8b115f1973be532ec86fa0369171]

        tdf#145151 sw IsTableMode NumRule: unselected cells
        
        ...should not be affected when setting or deleting numbering.
        
        This patch depends on follow-up patches to properly
        detect if numbering is turned on or off in some cases.
        
        This patch prevents numbering from "leaking" into the previous
        cell if the cells were selected backwards.
        
        Perhaps it would be better to fix the selection code itself
        instead of handling all of these edge cases,
        but doing that might have unintended consequences that
        I wouldn't have any insight into. So this is safer.
        
        Change-Id: I98e18d6056e93a4d89fdbe75b6237daca7832f41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134885
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-13  Miklos Vajna  <vmiklos@collabora.com>  [aa5824b2a6df99ef9d788a8d37bdfa77582375c8]

        tdf#149509 sw content controls: reject page break insertion
        
        Similar to input fields, the intention is to keep the start and end of
        (inline) content controls within the same text node, so just disable the
        command in this context, as Word does.
        
        Change-Id: Ib797ad164a3a36b4bbde4d686cde29adf6db96bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135599
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-13  Miklos Vajna  <vmiklos@collabora.com>  [c321498f915f4e8b3f4853232860ce040ab48e46]

        sw content controls: reject typing inside checkbox or picture content controls
        
        Content controls are editable by default (and not only editable, but
        also capable of hosting rich text content), and Writer doesn't limit
        the possibility to edit explicitly, either.
        
        Certain content control types (checkbox and picture for now) limit the
        hosted content though: checkbox overwrites the content on click and
        picture is meant to host a single as-char anchored image. So far the
        simple implementation Writer didn't enforce these limits, leading the
        unexpected behavior when clicking on checkbox content controls (possibly
        not only a checked/non-checked checkmark was toggled, but other content
        was removed).
        
        Fix the problem by making these content control types read-only: this is
        what also Word does and this way you can't loose the content when you
        can't enter it earlier.
        
        We may want to also do this for dropdowns in the future, once combo
        boxes will be supported.
        
        Change-Id: I9d44206b3c719a64ec552f2fa0a076901094163e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135574
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-13  Caolán McNamara  <caolanm@redhat.com>  [37dde4ef13dee5107249ff6604c0bb134235143e]

        crashtesting: assert seen on loading forum-mso-de-79405.docx
        
        Change-Id: I91200a8e409eec76de4ead22d200bf45f02b88b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135679
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-13  Caolán McNamara  <caolanm@redhat.com>  [48de2ac37366d5671aabc64364660311431d3235]

        crashtesting: assert seen on loading forum-mso-en-2633.pptx
        
        probably since:
        
        commit 855a56fea4561135a63cb729d7a625a950b210e7
        Date:   Fri May 13 08:12:17 2022 +0200
        
            tdf#148965 PPTX import: fix internal hyperlinks on shapes
        
        Change-Id: I920cbbb5544cbe9d76f37b3d524c9ccebd426132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135682
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-13  Caolán McNamara  <caolanm@redhat.com>  [67a661800e32bb371a0a23ba498915c4508772bd]

        crashtesting: fix crash seen on loading forum-mso-de-98993.xlsx
        
        which may explain the backtraces seen with BitmapFilterStackBlur::filter
        and BitmapBasicMorphologyFilter::filter in crashreporting
        
        Change-Id: Ib55cde1603d354b8ca0e336a08fe2d73b548f73f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135680
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-13  Caolán McNamara  <caolanm@redhat.com>  [7fee3f624370bd2911842bb8ed35d8cb27af8062]

        Related: tdf#149490 OLE Object dialog should be modal
        
        Change-Id: I909f2afbf149c4d92c97e04c2d8f93648e1e3162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135655
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [8a09aa3eec065c78803781d05e1beee92aa0381a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9d11c15431aa1ae77c54d22e8a717cc7bdf3831b
          - Remove hardcoded product name from a translatable string
            
            Change-Id: I7788158520149c3b63b395fca089f6ecdd7b8f78
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135685
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-12  Julien Nabet  <serval2412@yahoo.fr>  [c0e66cfab12d6c78d68af09498533362724dbd05]

        Fix context menu on image which doesnt display
        
        - Launch Writer
        - Insert any image in it
        - Right click on it
        => Nothing displays
        + console shows:
        warn:legacy.osl:67182:67182:vcl/source/window/menu.cxx:2750: PopupMenu::Execute: need a non-NULL window!
        
        Regression from f71606c920a3f78294da745cd9ef1eacde010224
        new loplugin:moveit
        
        Change-Id: I89f5bfe2a3cd6a935b419d55c2f3e884c7eed2c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135681
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-12  Caolán McNamara  <caolanm@redhat.com>  [90d4b93c5a7e25498dce949ac6fd2e33d53b74af]

        crashtesting: forum-mso-de-92960 GetEnglishSearchFontName varying results
        
        depending on if it's called once, or twice on the input string.
        
        The first converts from Full-Width Characters to equivalent lower ASCII
        range with non letters retained. And then the second iteration would
        convert to lower case ASCII with non letters filtered out. Presumably
        the intention is the Full-Width case should get directly to the same
        results as multiple calls.
        
        Change-Id: Idba4ebe04c907c160ee53abf6d5551550da032dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135678
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-12  Caolán McNamara  <caolanm@redhat.com>  [55eeffe768c6a80c97ee4f2a58fb467872ddeb1d]

        split out the code that extracts a lower-ascii version of a fontname
        
        Change-Id: I77778ecd075712c41bd29324be090ab4a8351ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135677
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ab37d644773fe08d908a35fff14b9e6eefebbc55]

        Add precisions to extended tip
        
        Change-Id: I8d33d95dd1cb8a5b81ae837f78accad6060a94f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135667
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3f2b5da839d9985fa9957fb8348d60bdf045f1e9]

        Fix dialog name
        
        Change-Id: I19c9157347488cf79acde6cf5af68baddc01a220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135661
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c91f21b57de96072f9ed33b1b99d3ec0d9507aa]

        Bump docking3deffects.ui to latest Glade
        
        Change-Id: I94fdc2d594f217a727e10fe69f5d7fcc746107bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135664
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [20ee72b916d5431a7e8e5846c2613aef67dbb7de]

        Improve extended tip contents
        
        Change-Id: Ie95d20bb1f5c8e153b3a9f9a088c835d5254880f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135665
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a599fe4ac2470ecd35162a15b8c76aaf862f156d]

        Bump envformatpage.ui to latest Glade
        
        Change-Id: I74066e2c37a310c242d7222fce48fdc6f23a8a0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135658
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-12  Maxim Monastirsky  <momonasmon@gmail.com>  [881774e9e35055cbaed36324542bae006eedb4fb]

        Related: tdf#125040 NB: rework print preview context
        
        Current implementation broadcasts the context change before the
        new controller was set on the frame (via XFrame::setComponent).
        This isn't going to work for anything LayoutManager based, as
        it responds to frame events by recreating all toolbars, so the
        newly created toolbar won't see the context sent for the old
        controller.
        
        Solve that by delaying the context change to SfxShell::Activate,
        like anywhere else in the codebase. And make NB listen to frame
        events, so it could also switch listening to the new controller.
        
        Also fixed a crash when switching to print preview in Writer with
        the navigator in the sidebar being active. Ideally we shouldn't
        even try to create sidebar panels in print preview, as the sidebar
        as a whole is disabled. But left that for a future investigation.
        
        Change-Id: I07759c676d2a2eb6f752fe778b559b15d2d759ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135492
        Tested-by: Jenkins
        Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

2022-06-12  offtkp  <parisoplop@gmail.com>  [932257c50c1dc9302b14862424e24e975f88bcc2]

        Add compression support for GZ through ZCodec
        
        ZCodec uses zlib to deflate. That file has code
        to allow for compressing to GZ but it's wrapped in defines.
        
        There's places in code where there's need for zlib headers
        (ie. svx/source/gallery2/codec.cxx:71) and there will be need
        for gz header compression when EMZ/WMZ/SVGZ export support
        is added.
        
        Made compression functions care about mbGzLib bool. Also added
        a SetCompressionMetadata function to set metadata which are otherwise
        impossible to know (such as filename, which is needed in the header)
        
        Change-Id: Ic01050262b0b15e0632564b139c66656afac4611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135213
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-11  Julien Nabet  <serval2412@yahoo.fr>  [988285410f8883ad49f32c4b804c4f5bd14569d0]

        tdf#98743: TIFF export uses 96dpi by default
        
        Create a brand new odg with A4 format with just a rectangle or a smiley on it and export it in tiff.
        Since we export the whole page, the size is:
        - in cm: 21x29.7 (definition of A4)
        - in inches: about 8.2677x11.6929
        
        Taking a look at the value of the generated tiff, we got:
        ImageWidth: 794
        ImageLength: 1123
        
        Notice that 794/8.2677 like 1123/11.6929 is about 96.
        So resolution isn't 300x300 (like the code suggests) but 96x96.
        Then let's remove all the useless mechanism to try to find the X and Y resolutions.
        
        TIFF Documentation indicates that "XResolution" and "YResolution" tags use "RATIONAL" type which is defined as:
        "Two LONGs: the first represents the numerator of a fraction; the second, the denominator."
        Since we got a non floating value, we can use "1" for denominator and "96" for nominator.
        With this we change TIFFWriter::ImplWriteResolution implementation to put the nominator first which corresponds to the resolution
        passed by argument to the method and the denominator afterwards.
        
        Finally, let's fix the name of the second of ImplWriteResolution, it's the resolution value, not the resolution unit.
        
        Next step would be to use the dialog box for compressing options (like for png or jpg).
        But for this I think we should take benefit of external lib "libtiff" since we now use it now for import.
        
        Change-Id: I7dbd04e506e98c344f97e455955cdf2c2f6d83c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135631
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-11  Eike Rathke  <erack@redhat.com>  [35edeb2d2cef6759435e1a1b68a5a09fe5217178]

        Add English (Mauritius) {en-MU} locale data
        
        Change-Id: Ib384ceb8bdd3268d8d1e076ea2d2d4baeef1f475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135628
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3d25248301321449215fcb7aa8e6c2b0d9f555be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7701d69b3b526f438d9e11ec6c37884c8616422a
          - Add info on sparkline custom vertical max/min
            
            Change-Id: I5e87f7036eb34b1d5cbd0c635b319417981a16b3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135639
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-11  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0ebbe1f0080f474fd583e5912c9605e6fb2e13d5]

        Related: tdf#119827 Add “scale” property for non-interactive labels in more places
        
        Informative or secondary labels should be set apart in the UI’s typographical scale.
        This is helpful for more verbose languages, and will contribute to an effort to
        make dialogs more space-efficient.
        
        Change-Id: I9eacbebe365a37fe3f973fa6818986d0a4c1fa48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135656
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ed8dc2256464324e1dbc27178e857964e54e73b1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f4baba42e6068c031f51f9683cca53562fbe79e
          - Object anchor is only one.
            
            Change-Id: I7f7c0c6a50e86dc069421648a54d4a9d811588e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135635
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-11  Dietrich Schulten  <ds@escalon.de>  [9638a1ff71a77ca1a3b3f9e13a36fa1724f5f69d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f46574a53e1d22e302dc343218ea3ed1ba610b8
          - Relates tdf#36466 - Update help about copying visible cells only
            
            Change-Id: Ia33f942232b73aaad53bb34a5e02b4c457a0d8bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135541
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5a614a2585a36019ab931f8f754a0a91db88c90b]

        Add precision to extended tip
        
        Change-Id: I9723896a84df297d245e78f582f23d33c8a6dc4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135625
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [5b0c50544d3b1a5f2bfc5636384981caefe37f3b]

        WASM use 'em-config LLVM_ROOT' to get llvm-nm path
        
        Change-Id: I3073330ed25676d5fbf9f2af008e42828466fc3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135565
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-11  Stephan Bergmann  <sbergman@redhat.com>  [7e2f0f6c089b898056c0269299220593be1b22f8]

        Remove some more dead functionality
        
        Change-Id: I653c85d247b2d52c75e12fc0c54701616a44abd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134148
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-11  Stephan Bergmann  <sbergman@redhat.com>  [25fc5f91ab7e6fd410ccd403ba19741a16eaab49]

        [API CHANGE] Deprecate css.registry.XSimpleRegistry::mergeKey
        
        ...and let its implementations just throw a RuntimeException, now that regmerge
        has been removed in "[API CHANGE] Remove deprecated idlc and regmerge from the
        SDK".  Deprecate css.registry.MergeConflictException along with it (though
        stoc/source/implementationregistration/ still uses it internally).  And remove
        the previously unused include/registry/writer.hxx along with the newly unused
        include/registry/writer.h, RegistryTypeWriter, and RegistryTypeReader.
        
        Change-Id: I10fd286617975dc0ef9f74460a3a3eab8060939d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123615
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-11  Stephan Bergmann  <sbergman@redhat.com>  [3ae546f97bf6c80627271c28943795175b97fdb9]

        Use idlc/test/parser/conversion.tests in CustomTarget_unoidl/unoidl-write_test
        
        ...now that idlc is gone since "[API CHANGE] Remove deprecated idlc and regmerge
        from the SDK".  (idlc implemented some dubious conversions from floating-point
        to integer types, which unoidl-write does not implement, so the original version
        of idlc/test/parser/conversion.tests was not usable in
        CustomTarget_unoidl/unoidl-write_test.)
        
        Change-Id: I3b69920dda24c54c9313cd5c2cd0c0fdd9951ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123614
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-11  Rene Engelhard  <rene@rene-engelhard.de>  [69c964bbd56ff49324d1ca649739fae354dd4c16]

        fix 32bit build in new a11y cppunit tests
        
        /<<PKGBUILDDIR>>/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx: In member function ‘void XAccessibleComponentTester::testBounds()’:
        /<<PKGBUILDDIR>>/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx:51:5: error: no matching function for call to ‘assertGreaterEqual(int, sal_Int32&, CppUnit::SourceLine, const char [1])’
           51 |     CPPUNIT_ASSERT_GREATEREQUAL(0, bounds.X);
              |     ^
        /usr/include/cppunit/TestAssert.h:251:6: note: candidate: ‘template<class T> void CppUnit::assertGreaterEqual(const T&, const T&, CppUnit::SourceLine, const string&)’
          251 | void assertGreaterEqual( const T& expected,
              |      ^~~~~~~~~~~~~~~~~~
        /usr/include/cppunit/TestAssert.h:251:6: note:   template argument deduction/substitution failed:
        /<<PKGBUILDDIR>>/toolkit/qa/cppunit/a11y/XAccessibleComponentTester.cxx:51:5: note:   deduced conflicting types for parameter ‘const T’ (‘int’ and ‘sal_Int32’ {aka ‘long int’})
           51 |     CPPUNIT_ASSERT_GREATEREQUAL(0, bounds.X);
              |     ^
        
        etc.
        
        Regression from d2a5b4bc0b8c8d1dd82133719a3ef5cc01b0cbbe
        
        Change-Id: I123894e5ed6d6f3bcf46b1c5b37f1f49cb5f9f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135630
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-11  Rene Engelhard  <rene@rene-engelhard.de>  [f18b06ca5108d9e4f4bcfe0081bc1017acdef76d]

        really fix bigendian builds
        
        this time - since I missed to take over one rename
        between trees. sigh. Continues 089c91b1ad16232f130cb50266732509f83c52eb
        
        Change-Id: I726410ab1024b995937952fbce1214866ee8ba19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135629
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [da8d90854d2b5f03b9ed9878d562531465725e85]

        Fix English in extended tip
        
        Change-Id: Ifc72a7cacee66f78ae275ec2981c54142d9a6f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135619
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [df15a079e9a2f6c7cff44c8d0b00b0bcd64a8c62]

        Change extended tip in dimensionlinestabpages.ui
        
        Change-Id: Ibd51662c88d3d3ed0210f4af1f66369bf94c0d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135617
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0a7bdf6eebe12a318bab7e265477ef632d3a34d2]

        Bump hangulhanjaoptdialog.ui to latest Glade
        
        Change-Id: Ie9bb451699b2ca9dcd0ace6dd9a341076862d1b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135618
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [46927cdb83928acee300e3c504cf054762dd72ee]

        Bump pdfviewpage.ui to latest Glade
        
        Change-Id: Id8c5eca99cf1054587e8554581c32f4d5ca1c974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135608
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [30e6a4748bb29cc299c41755fbdf108db2c1c005]

        Bump customslideshow.ui to latest Glade
        
        Change-Id: I15bb8c7bfde9df109af3e9466763ff70c0e0a526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135612
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-06-11  Luboš Luňák  <l.lunak@collabora.com>  [7689bf445264d1b54038ec0b8d134c26847af40f]

        find last data row before searching for first data row
        
        GetLastDataRow() is more efficient than iterating every cell
        with HasDataAt(), so first reduce the row range from the end
        (in case the whole range is empty cells it's just one call).
        
        Change-Id: Idc494795f68492ed8b05b2cd575598a9c5868b7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135605
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e0c5f8b4f6152d19044f998edc293b4bb636e66c]

        Fix typo on xmlfiltertabpagegeneral.ui
        
        Change-Id: I2bc3caa254d997c815bfd36f47504dbc70cadff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135611
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-10  Stephan Bergmann  <sbergman@redhat.com>  [b32ab8e750f3bc90adfd481910dfd09ea90ab8e2]

        CppunitTest_sd_shape_import_export_tests also needs the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", to avoid
        
        > Test name: ShapeImportExportTest::testTextDistancesOOXML_Export
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 32512
        > - failed to execute: sh .../bin/officeotron.sh .../tmp/ShapeImportExportTest__testTextDistancesOOXML_Export_2l2moj.tmp > .../tmp/ShapeImportExportTest__testTextDistancesOOXML_Export_2l2mol.tmp 2>&1
        > java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init
        
        Change-Id: If7f3f9de14c7122b4a08b5a4807b4d28dffb9e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135595
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-10  Justin Luth  <jluth@mail.com>  [758945b077220fe151c1565c6d5b0bad02de6d58]

        tdf#75297 sw uno: override default num char style when NONE
        
        The problem was during ODT import. When no text:style-name
        is provided, or if it is an empty string, then the default
        "Numbering symbols" character style remained active,
        preventing the ability to round-trip a NONE char style.
        
        Since this depends on the built-in name
        (and that name can easily enough change)
        there is not much point in creating a unit test.
        
        Change-Id: Id942060abd3e024758f93f3d279ef8b561cfc5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134888
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2022-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [95d91cd41e030a317b51a00086bf042282c8f9e1]

        loplugin:constantparam
        
        Change-Id: I8134744b6c1279c497d4763eddf614bb840f7f3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b5c92677708ab0135d63e1496b91054383c45b4]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ica246a12d93f5417ad857b9484575d03c66f761a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [230e46106578a2abf8211b51c071c037fc6e5ad2]

        loplugin:unusedvarsglobal
        
        Change-Id: I37a1772ffdd682d17571aa06e24089136d2d8547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135600
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-10  Julien Nabet  <serval2412@yahoo.fr>  [7a7afd3ae5d44677791924a1450d42b7fcf9b82b]

        tdf#148978: Business Cards in Writer dont show database
        
        + remove "medium" tab since its goal is exactly what "label" tab does.
        So now "label" tab is common for "File - New - Business Cards" and "File - New - Labels"
        
        Change-Id: I9c7f4e74d7cbc0ffa8ee146a0ef39c87ff5261e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135566
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-10  Stephan Bergmann  <sbergman@redhat.com>  [a8485d558fab53291e2530fd9a1be581c1628deb]

        [API CHANGE] Remove deprecated idlc and regmerge from the SDK
        
        * Client code must replace uses of idlc and regmerge with uses of unoidl-write,
          see the changes to odk/examples/ and ure/source/uretext/ in
          40f2aee6584eafcf4cd1d95fcf1f775e5435440d "Provide unoidl-write also for the
          SDK" for examples.
        
        * The new types.rdb format is not compatible with LibreOffice < 4.1.  Clients
          generating extensions containing such files are advised to use appropriate
          LibreOffice-minimal-version elements.
        
        * For compatibility with old extensions, reading the legacy types.rdb format is
          still supported.
        
        * The SDK no longer ships an idl/ sub-directory containing the udkap and offapi
          .idl files (as, unlike idlc, unoidl-write does not need them).
          odk/config/cfgWin.js had to be adapted to look (somewhat arbitrarily) for an
          examples/ sub-directory instead of idl/ when checking for "an sdk folder".
          gb_UnoApi_package_idlfiles became unused and has been removed.
        
        * The idlc and regmerge executables have been removed.  Module idlc has been
          removed except for idlc/test/parser/, which is also used by
          CustomTarget_unoidl/unoidl-write_test, and which may eventually be moved into
          module unoidl.  Module external/ucpp and the corresponding configure options
          have also been removed.
        
        Change-Id: I42a0231699b863b5ebe2bee63bc32c8f79278cc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122363
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [611fe67394820e589e86f543c614632fc273eb5e]

        loplugin:unusedenumconstants add support for ParenListExpr
        
        Change-Id: I3dc2a5e4c0cae9a9ae955118e77eae63c17f7242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135590
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [27ebceb366356f65c836e7edcc3609193f6e009c]

        bump product version to 7.5.0.0.alpha0+
        
        Change-Id: I4c696b0942edc5afe7a3d2babe62e7b70463f543

2022-06-10  Michael Stahl  <michael.stahl@allotropia.de>  [45613274794636ba98d0e978fe872511297d275d]

        tdf#140007 sw: fix SwUndoReplace
        
        (regression from commit d6b0e84b236b78f4b21bd16e46dda3fa0876096d)
        
        Change-Id: I1facf1584a349d1d087438f4e6fd3a63a80c6f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135585
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c94961c6869c34b3874d21cfaa5ec1488609acfe]

        Update git submodules
        
        * Update translations from branch 'master'
          to d876aa338f5bc378bec4500d8e4d13654d7f8cea
          - update translations for master/7.4.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I6b70cdc276c670e1eb166910f095c46e81256a7f
            
2022-06-10  Miklos Vajna  <vmiklos@collabora.com>  [04cc6e079e3122c183054fde046c054ed6c7b737]

        sw XHTML export: avoid writing default transparent background for ReqIF
        
        We started writing properties of tables and rows since commit
        c3c3303516c3da9372dce3f05f38f15a104e961c (sw XHTML export: output table
        / table row background format using CSS, 2022-05-10).
        
        In case the SwTableLine has an explicit SvxBrushItem with its color set
        to COL_TRANSPARENT, we turn that into a "background: transparent" CSS by
        default. This is a 1:1 mapping from the doc model, but HTML defaults to
        this already, so this is considered as noise.
        
        Extend IgnorePropertyForReqIF() to filter out these unwanted defaults,
        and fix SwHTMLWriter::OutCSS1_Property(), because it used to not pass
        the CSS value for the filter function.
        
        The behavior for table cells is unchanged, we continue to not export
        cell properties (in the ReqIF case) at all.
        
        Change-Id: Idbcd07809e159def694f4de017eebc7ad4104575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135576
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-10  Miklos Vajna  <vmiklos@collabora.com>  [af3c766cb5ddb1959fb659e3c316e42f832d8de3]

        sw doc model xml dump: show table row properties
        
        Also extract SwTableNode::dumpAsXml() from SwStartNode::dumpAsXml(),
        ideally dumpAsXml() should only dump own members, not members of other
        classes.
        
        Change-Id: I5ef3e90d0cdd23ba44c192de1802844acad64cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135575
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-10  Mike Kaganski  <mike.kaganski@collabora.com>  [098999e62e5a428b268259704584dd0f15dc22f7]

        Drop unused text column from IconView's model
        
        ... and also the hardcoded column count and width. This allows to
        make the elements position themselves better in the dialog, and to
        avoid the unused space below the icon in GTK, similar to non-GTK
        as implemented in commit 54725f6e5f06b074d1c08d8efbd16518b96882d5
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Tue May 03 09:49:07 2022 +0100
            Don't add empty labels to fontwork's icon view
        
        Change-Id: I19fa4e2002856322266b21873b383bc887cf1029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135584
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-10  Mike Kaganski  <mike.kaganski@collabora.com>  [e52a805172914164912066a65c6e95988d8b2131]

        Entry may have no text
        
        ... after the changes made to IconView.
        
        This partially reverts commit 54725f6e5f06b074d1c08d8efbd16518b96882d5
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Tue May 03 09:49:07 2022 +0100
            Don't add empty labels to fontwork's icon view
        
        and instead, makes SvTreeListBox::GetEntryText tolerate absent text.
        
        Change-Id: Ifc386263ad656478416907a6f6b567cd1f3331ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135582
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [629a9b92da6d0126bd4be4cde373a02ac542ce7d]

        tdf#149503: Check size of vectors
        
        Crash introduced by 41f95c4a35a6335e9edb2f51c11d136d88bd0749
        "Remove SC_DPOUT_MAXLEVELS limit in Pivot"
        
        This brings back the old behaviour and now the
        "You cannot change this part of the pivot table." message
        is displayed again
        
        Change-Id: Ibad84c0a279d7d67b709b7e311ac875739cdb210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135578
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-06-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3a688ca467cebd65ef30ab80d4211715b1665348]

        autocorr for da: fx can appear at end of sentence
        
        as in e.g. "Vi kunne jo tage bussen, fx." so remove the "fx." entry from
        the autocorrect list
        
        Change-Id: I5c03f46bd1e35fcf8fa731983c7459f2ba99b174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134107
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-10  Mert Tumer  <mert.tumer@collabora.com>  [d952df361a5e190246d7a0738ae5347b82cd57b5]

        LanguageTool Grammar Checker implementation
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I275cbea668afc5beb5147370119631df8b6a2d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135178
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-10  Lukas  <lukasmolleman@gmail.com>  [044df303665606c778748fcfc0bfc47ce65ee914]

        bin/upload_symbols.py: make pythonic
        
        Change-Id: I44d86677f64b7b4a4212b94a574a20805bac649b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133223
        Tested-by: Jenkins
        Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f71606c920a3f78294da745cd9ef1eacde010224]

        new loplugin:moveit
        
        look for local variables that can be std::move'd to parameters
        
        off by default, since it doesn't do proper data flow analysis
        
        Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b28de9d32016a904e4ba457a9a6c62098416c729]

        tdf#135346: vcl_pdfexport: Add unittest
        
        Change-Id: I11ad776419ea3c0eb5babd0f1ee2c7c70b7e7485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135580
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc937347728a669d9baeee75c6ad5eea9d8d2710]

        tdf#114256: vcl_pdfexport: Add unittest
        
        Change-Id: Iaaeb0b248f84709855d9e83d34cecf22f1169769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-10  Eike Rathke  <erack@redhat.com>  [b7eddf3e9c2db503dde632b35513844806be3c36]

        Resolves: tdf#148072 Restore sheet-local names for Undo of Cut
        
        Undo of Cut uses CopyToTable() and not UndoToTab() as Copy does,
        so copy the sheet-local names also *from* Undo and not only *to*
        Undo. And mark for ScAreasChanged broadcast.
        
        Change-Id: Ib07f711a7d407dafdf548873291f1ccc81b85d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135568
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-10  Luboš Luňák  <l.lunak@collabora.com>  [cd7e262f7e34786496103dbe2be16c198bf97c64]

        add missing 'xComponent->dispose()' to a test
        
        Change-Id: I0ae2847e81eb2f1fba16e65d89ca1db1e55ac4b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135577
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-10  Miklos Vajna  <vmiklos@collabora.com>  [c3787043db572ff4b9933fad53dbcfec3428b75d]

        sw: fix use-after-free in SwFrame::ImplFindPageFrame()
        
        Header-footer controls have a non-owning pointer to their page frames in
        Writer views, so whenever a page frame gets deleted, we need to manually
        make sure that the header-footer control doesn't have a pointer to the
        deleted page frame.
        
        This already works with a single view, but in case one view has a
        visible header-footer control and an other view deletes the page frame
        that is known to the header-footer control, then we have a problem.
        
        Fix the problematic outdated SwFrameMenuButtonBase::m_pFrame by
        extending SwPageFrame::DestroyImpl(), so it un-registers itself (before
        deletion) not only from the current view, but from all views.
        
        Found by online.git's:
        
        tst=/tmp/testfoo.odt
        cp test/data/hello-world.odt $tst
        ./coolstress wss://localhost:9980 $tst test/traces/writer-hello-shape.txt $tst test/traces/writer-document-edit.txt $tst test/traces/writer-mash-text-table.txt $tst test/traces/writer-rambling-text-table.txt $tst test/traces/writer-add-bullet.txt
        
        although also reproducible on the
        desktop, in case you have two views (windows), do cltr-enter to have 2
        pages, go to the 2nd page in both views, view 1 clicks on the 2nd page's
        header, view 2 deletes the page (backspace) and finally view 1 clicks in
        the body text of the current page.
        
        Change-Id: I35e5d82256ab5db8e5f0ba198f5d2638cbff7d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135573
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-10  Stephan Bergmann  <sbergman@redhat.com>  [12ffb0cb65352307485913065f4c3b5d8069ece7]

        external/libtiff: Missing include for _byteswap_uint64 on Windows
        
        ...now causing a -Wimplicit-function-declaration error with Clang 15 trunk after
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning".
        
        (Unconditionally including <stdlib.h> on all platforms even for those that don't
        need it should be harmless.)
        
        Change-Id: Ic2191308ea252cb4b88842a2767167ab2d23d9fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135572
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4dae3508de6d2340562f0c97ca4d00b03dcae42d]

        Add asserts to those places where I fixed a EXCEPTION_INT_DIVIDE_BY_ZERO
        
        I found those crashes scraping https://crashreport.libreoffice.org/stats/
        so those are blind fixes basically. Add these asserts,
        hoping one day someone will hit them so we can find the root cause.
        
        See
        7c8b9fa98f4c5f7f5620e797dbbe24081e252548
        fae937b6859517bd9fe8e400cad3c84561ff98ab
        ce39195e533336ce1482e2be6b1bec2b7f992125
        23e3bff528ab38c8d5c6d401b672a0033cef2bd4
        ea4cd397300120a0f825752182eb3b943eb8a1b2
        
        Change-Id: I175f47361e07961417c87cc8f3d7d4d1fb50fb2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135448
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-10  Miklos Vajna  <vmiklos@collabora.com>  [d701eff3519287db599a2612a635bc5f610ba082]

        sw XHTML export: avoid writing background of table cells in ReqIF mode
        
        ReqIF mostly forbids using CSS styling on elements:
        IgnorePropertyForReqIF() only allows 2 CSS keys by default.
        
        This restriction was relaxed in commit
        c3c3303516c3da9372dce3f05f38f15a104e961c (sw XHTML export: output table
        / table row background format using CSS, 2022-05-10), to allow
        background for tables and table rows, using CSS markup. An unwanted side
        effect of this is background for table cells, which is still considered
        invalid. To make this nontrivial to fix, Css1Background::Table is used
        to track formatting for all of tables, rows and cells.
        
        Fix the problem by extending Css1Background with a TableRow and
        TableCell and then audit all uses of Css1Background::Table to explicitly
        say if they mean table, row or cell. This keeps table and row
        backgrounds, but fixes the unwanted cell background.
        
        Also document the 3 functions doing the export of table / row / cell
        background export to improve readability.
        
        Change-Id: I03301b1fd25593cbe83489dbf140e80138d4a0de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135570
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-10  Hossein  <hossein@libreoffice.org>  [d0e50ba13b545ab00dfb02a445eeb93011ff4af8]

        Add information on Java baseline in README.md
        
        As discussed in the ESC, although LibreOffice can be built with the
        Java Development Kit (JDK) version 9, the JDK 9 is no longer
        supported by the JVM vendors including Oracle, Red Hat and others.
        Thus, it is asserted here that JDK 11 or later should be used to build
        LibreOffice.
        
        For further information on the supported versions of JDK, and its
        lifcycle, see these articles:
        
        Oracle Java SE Support Roadmap (Updated March 22, 2022)
        https://www.oracle.com/java/technologies/java-se-support-roadmap.html
        
        OpenJDK Life Cycle and Support Policy (Updated November 22 2021)
        https://access.redhat.com/articles/1299013
        
        It should be noted that JDK 8 is still supported, but it is not usable
        for building LibreOffice.
        
        It is also documented that without Java one may lose many features that
        are described in the TDF wiki article Development/Java:
        https://wiki.documentfoundation.org/Development/Java
        
        Change-Id: Id001c341a221b0fe5c07c7129956a824261d32c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135557
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [317dc8569723d434fe4175a2b665b84fd15f6f99]

        tdf#135346 clear page row map to avoid invalid "hidden" flags
        
        With the print range cache surviving a longer time, we can get to
        a state where we reuse the page row map (m_xPageRows) that had
        older "hidden rows" flags still set, but they aren't valid for
        our new recalculated ranges. The result for this is that in the
        bug document, the print preview is empty (as hidden flags for the
        rows was kept but not valid anymore).
        
        We don't really benefit from keeping this map, so we can just
        clear it when we need to recalculate the print ranges.
        
        Change-Id: I1f8de889d6f006e700c6f21ef5bfa52a36bcdfc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135567
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-10  Miklos Vajna  <vmiklos@collabora.com>  [1cbdbff2f419d0729ae8772a7e509cb224b6a46d]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I1f8d1279ebd0aadfc6c657e63e62da265f785896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135564
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dfa2365dd8060cb5611a5c43830c3a8bc3af79a6]

        Fix typo
        
        Change-Id: Id11f0afe9aa32373837289b8bc7fa1b36112a28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135521
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-09  Rene Engelhard  <rene@rene-engelhard.de>  [089c91b1ad16232f130cb50266732509f83c52eb]

        fix bigendian builds
        
        after 410a64b472ae9de0bb06ddd8f4b55fd16686c860 and
        6624721b3226ace33f5032b1c1ce595c19f1915c which changed the
        surrounding places but missed the occurence in #ifdef OSL_BIGENDIAN:
        
        Change-Id: I610b0e19a37207b925668d7f2315b27abce21b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135558
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-09  Luboš Luňák  <l.lunak@collabora.com>  [dabf52b81621f1cbff508dfb7ae2e92597e521c3]

        remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)
        
        This code sets sufficient size for the virtual device that saves
        the content, so it's not some optional debug code. Without this
        selecting text in Calc formula bar and dragging it around leaves
        artifacts, because the saved content is not large enough to restore
        the original widget content. This dates back to
        d51fe1189dcbe0fe06805c8d99687c125cd254eb, which supposedly made
        the code warning-free (and also correct-free).
        
        Change-Id: I52dab8c8d3a083fff9da8aed27facdf21076622e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135555
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [2a28ebeef5ea3e2b01d836a7233d2316b765bf38]

        Accessibility for IconView
        
        Change-Id: I65ca9d43f70a50e2e95aabfc3b8ba1b15f9ff8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135226
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [2910ce0b43552cbd6415e5930953c660e41b1965]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a94b253eee022e358504b335e190e883e74749f
          - Document new CreatePivotTable method in SF_Calc
            
            Change-Id: I56de41d153c650058e85faaad023f169b3ca79cd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134436
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-09  Alain Romedenne  <alain.romedenne@libreoffice.org>  [0f9658f94f3505fa49449d0fca354f27edd89569]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09dfc9550cc74aae157411e570375edb7abda341
          - Replace outdated links to OOo's wiki
            
            Change-Id: I4603f02312347b203dbbc13170f92819401e9a3a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135535
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-06-09  Miklos Vajna  <vmiklos@collabora.com>  [51eb7b837996384d0155c0841bf69cf068bbe367]

        sw content controls: fix crash on trying to insert nested dropdown
        
        This went wrong in commit 3dd4f3691458ea537bc1867386269694775cfbcb (sw
        content controls: add document model, 2022-03-30).
        
        Change-Id: I8040e02975d1f98cc01ef6f8a22745f27afa5276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135554
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-09  Caolán McNamara  <caolanm@redhat.com>  [4308db47d950d6c1038968d22a9a9c453619eb4b]

        Resolves: tdf#142368 drop popover on ControlLoseFocus
        
        which is what appears when the Control derived inputbar loses focus
        while the main window losing focus gives WindowLoseFocus
        
        Change-Id: Iae9a2874c3dd513a1a092a18846858f819542370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135533
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-09  Caolán McNamara  <caolanm@redhat.com>  [88fbab01861064cd353c38b39b4359154d3495ce]

        ofz#47901 fix read overflow
        
        Change-Id: I707fe54e68ef548edcb8b69b83ba64c0674e44ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135532
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [de8eafffbd5dd1a73be6cd60b5499655c189580b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 5e97a2aaf2e7167def28de951c6dcfdb1b93bf81
          - update translations for master/7.4.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I6419ffd7d18beaa9637624d377e4e38f473f9a30
            
2022-06-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4361a89ee586bd62efcf5226f8f54f26b862b9c7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b97210c58dbbf9c16f4a4cbeba5665ada2efe6fb
          - tdf#126658 update "defining line ends"
            
            The content of the guide page "Defining Line Ends"
            (shared/guide/lineend_define.xhp) has not been updated since
            its initial checkin in 2004. This patch updates the relevant
            menu commands, aligns the description with the current UI,
            adds a little more precision in what gets added as an arrowhead,
            and refactor to <h1> and <menuitem>.
            
            Also, add a <relatedtopics> section to the "Arrow Styles" help page
            (shared/01/05200300.xhp) with an embedded link to this guide page.
            
            Change-Id: I3e619aadddb65b77cc7216074d18c4eb138b1774
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135393
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [e04fab838f8088e7cf12b68ac3b505350521623c]

        tdf#149484: subsequent_filters: Add unittest
        
        Change-Id: I867696100d79f599a58e8cc5a64723cec3cea2b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135525
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [485300f9aef53f63e24339422b1dd2bfa12d543e]

        loplugin:unusedmethods
        
        Change-Id: Ib89ab59f7ad7e90b2a44ddd122176cde904fba4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e1a0ecffa055062a21815ab13eb6e4f8c769b8f]

        get-forum-attachments: Add 2 more mso forums
        
        Add login mechanism for them
        
        Also add --config and --outdir arguments to
        set the pathes
        
        Change-Id: I641f10396e1f4cf5bdb19da287b1a2962ff4e2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135495
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-09  Caolán McNamara  <caolanm@redhat.com>  [b1d57168b8cecc1713e729c22260feaf33fab29f]

        a Frame has max two children
        
        during creation it might not have all its children created yet
        if a11y querys it during its setup.
        
        Change-Id: Ifbbec7eeb80409dc5e871c2022d1ee1e36c6e74f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-09  Andras Timar  <andras.timar@collabora.com>  [8494815ba566c94b59c3690fe138f70d8b6e169a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 68b272ec160ded8157c13117e350fc4dfc3037fb
          - Updated Danish spellchecker
            
            Change-Id: I7c8ff2e7fac358706a580f2b24842ade0a1baa55
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/135531
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2022-06-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [e9f407fbf0ede1760518b2e58931eba381879717]

        can pass by const& here
        
        no need to copy
        
        Change-Id: I1fcc5d645a8f5278e2122a168b00c846d75bc091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135522
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-09  Stephan Bergmann  <sbergman@redhat.com>  [0bbbde84b091c7969378ef9a5bbadd9706e57c5e]

        tdf#140886: Make "Do you really want to open it?" more reliable
        
        70009098fd70df021048c540d1796c928554b494 "tdf#128969: Let the user explicitly
        decide to execute an external program" had shoehorned that new warning dialog
        into the existing XSystemShellExecute::execute IllegalArgumentException return
        path, which caused some issues:  For example, it caused the warning dialog to
        reappear after you acknowledged it on macOS (see comment at
        <https://bugs.documentfoundation.org/show_bug.cgi?id=140886#c10> "Allow
        hyperlink opening on file with execute bit set ref. CVE-2019-9847"), and it
        caused the warning dialog to erroneously appear for a non-existing file on
        Windows (see comment at
        <https://gerrit.libreoffice.org/c/core/+/124422/2#message-ac76b728fedc53e7d0a04c99f00364068b51a8ea>
        "tdf#128969: Let the user explicitly decide to execute an external program").
        
        So rather than reusing IllegalArgumentException for this case, use a different
        kind of exception to trigger that warning dialog.  The existing
        AccessControlException (which is also a RuntimeException) happened to fit more
        or less well.
        
        Change-Id: I3f743c21be48d54f10951006ef3d7172e23e9076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135524
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a54e10c270bfb74c303dc338ad6bc484ac529566]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dae8c0f4225b25d4612f7a9db86fc4518bf4b3d9
          - (Related) tdf#126658 update Arrow styles help to reflect UI change
            
                 text/shared/01/05200300.xhp (Arrow Styles tab)
                   * update new control names
                   * corrections to description of tab and its use
            
                 text/shared/00/00040502.xhp  ("howtoget" for Arrow Styles)
                   + add appl-switches with 
                       * menu variations for Writer, Calc, Draw and Impress
                       + access variations using toolbars
                   + add right-click access
                   + add section for embedding
                   * rename German ID
            
            
            Change-Id: Ic224d72b2abeee777063626f4dcdb570562d3650
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133037
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-06-09  Balazs Varga  <balazs.varga991@gmail.com>  [246d4f14c347ddd8cf49a397984a5f13c9687896]

        Ignore warning C4723 for windows arm64 build
        
        Tinderbox message from windows arm64 build:
        C:\cygwin\home\tdf\jenkins\daily_workspace\tb\src_master\include\basegfx\range\basicrange.hxx(276) :
        error C2220: the following warning is treated as an error
        C:\cygwin\home\tdf\jenkins\daily_workspace\tb\src_master\include\basegfx\range\basicrange.hxx(276) :
        warning C4723: potential divide by 0
        LINK : fatal error LNK1257: code generation failed
        
        Change-Id: I86ce1a0ea6abdf46464dcac95b9b591120782a13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135523
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-06-09  Khaled Hosny  <khaled@aliftype.com>  [be39eba9a3d81e20c42f1073a365e91ce855c1cd]

        Use same glyph width in PDF drawing and font subset
        
        During PDF drawing we already know the glyph width, but when subsetting
        we get it again from the font subset.
        
        For fonts without CFF table this is redundant but harmless, but for
        fonts with CFF table, if the CFF and hmtx table (the authoritative
        source of glyph widths) disagree, we will be drawing the PDF string with
        the wrong adjustment resulting in displaced glyphs. This is a font bug,
        but avoiding redundancy and having one source of truth is an improvement
        overall.
        
        I kept the code that calculates advance widths for font subsets, just in
        case it is is still used elsewhere.
        
        Change-Id: I757cd0c2ebb6477b2f840d0005e84b5a131f7efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135442
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [136fac12eb9752f1072f852cc193d6a9accdc4a7]

        redland WASM: add Emscripten flags to fix NEH build
        
        Change-Id: I4ed242e774e1ce2ac05dabb9fc657329dc4a63c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135519
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-09  Seth Chaiklin  <sdc.blanco@youmail.dk>  [64b5eb228625f4da6368be3e7ec93e68cf74605d]

        tdf#149414 change Format Object label for Calc and Impress
        
          The label for Calc was Format > OLE Object (using
          .uno:ObjectMenu), while the label for Impress was
          Format > "Object and Shape" (using .uno:FormatObjectMenu).
          This patch (a) changes the label of .uno:FormatObjectMenu
          from "Object and Shape" to "Text Box and Shape"
          (to bring it in line with Writer). This change appears
          immediately in Impress, and (b) changes the .uno:ObjectMenu
          in Calc to .uno:FormatObjectMenu, which also gives the
          "Text Box and Shape" label, which is also more appropriate
          for its submenu.
        
          Kept the same keyboard accelerator "o", which was used both
          in Impress and Calc.
        
        Change-Id: Ifcf7b953b6bed262d630f7a07bf1f5000ee33aa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135162
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-09  Miklos Vajna  <vmiklos@collabora.com>  [19632bf0bc0561138f3dee4b2d79a5b3ade0de52]

        CppunitTest_sw_ooxmlexport14: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I6d5c130ea25982d2cc0dc424a79c6962c1aa4f1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135510
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [91fef4a47563451e0271784a14b471e4815729d1]

        clang-tidy modernize-pass-by-value in editeng
        
        Change-Id: Ibf912c597896a2ac0bf3ba8108f55c5018115bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135501
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-08  Caolán McNamara  <caolanm@redhat.com>  [66b1ebd4ddc7127a923bf81eb569e7f99dd52022]

        gtk: let math GtkIconViews flow to fill available space with icons
        
        Change-Id: I25f3433e9404ac1938568607a9a52a50ca8a7892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135513
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-08  Caolán McNamara  <caolanm@redhat.com>  [50c478fd84e2878b636d766e1d2141ccfa51e2f0]

        GtkIconView uses a different way to link model and view
        
        Change-Id: I1ad2734c9f28568433de8b9532cf20da8a27f7cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135512
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-08  Caolán McNamara  <caolanm@redhat.com>  [83c2a61737604e3ad870cb57d921bb38c934fbd4]

        drop two unused suppressions
        
        Change-Id: I0bf5bed7fbfb3b46c1c9a48969f492b5745b1fb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [19a67603c7a800d3433e9f41143a9b9ed6300b8d]

        Fix typo
        
        Change-Id: Id5517254be4e108c4aeedbd067f9bf3097f89452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135515
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [33f88380fba0202d03577da80f7370ac8e583fb1]

        Fix typo
        
        Change-Id: I278a23c9dc7a20f293e8167ee3c0492679e81f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135516
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [16af8e218540dd17f020411c32e809feb68abd78]

        Fix typo
        
        Change-Id: I6463eb09c5bac07e6aa8e23b4b5eab06172ab2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135514
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-08  Julien Nabet  <serval2412@yahoo.fr>  [a943e7ddd13315b18d7b33cd1b2f852144f54344]

        tdf#149470: Firebird, Clob may need several segments to store a very long input
        
        Change-Id: I85c7789f46d834d2ae1b251f915382f833bd529d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135480
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-06-08  Michael Stahl  <michael.stahl@allotropia.de>  [12acdce71dd6b6af2c52ba8fa3248d3166418543]

        (related: tdf#139514) sw: fix Undo of delete with at-para fly
        
        Nonobviously, there are situations where the anchor node must be
        preserved and restored when it's not on the node that is being deleted.
        
        (probably regression from commit 91b2325808a75174f284c48c8b8afc118fad74e4)
        
        Change-Id: I39f09ddb631204c8ad522f9ec7068d235ca94ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135509
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-08  Eike Rathke  <erack@redhat.com>  [33a8c4bd0e8533ab42894280e7e04c13a47aefa9]

        Related: tdf#149484 Write proper <number:boolean-style> with <number:text>
        
        Change-Id: I46b7987dde25840ae0b6e5871b14e3806c6e4ac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135508
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-08  Heiko Tietze  <tietze.heiko@gmail.com>  [755e0cd60d4634111911469b752485da678988e1]

        Resolves tdf#149010 - MInor UI fixes
        
        * Next/Previous controls placed in an extra frame
        * This frame becomes hidden in case of picture and objects
        (next/prev is only possible for frames)
        
        Change-Id: Iab7042b72efa7857c5405a8c345ba03d6b975519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135494
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-08  Michael Stahl  <michael.stahl@allotropia.de>  [85376a02348810812d515ee72140dbf56f2b6040]

        tdf#133957 sw: don't delete flys on Backspace/Delete keys
        
        Also fixes: tdf#134007 tdf#138835 tdf#139514
        
        When a character is deleted via the keyboard by Backspace or Delete key,
        an artificial selection is created in SwWrtShell::DelLeft()/DelRight().
        
        Ideally this should not delete flys that may be anchored to the
        paragraphs, but unfortunately this may happen if there are only 2 empty
        paragraphs in the section, because then the artificial selection cannot
        be distinguished by the SwDoc implementation from a selection from
        Ctrl+A (Select All), which *should* delete the flys.
        
        So introduce a new flag that needs to be passed down multiple layers so
        that SwUndoDelete can use it to determine if flys should be deleted, and
        translating it to a flag that had been introduced to preserve flys in
        ReplaceRange() previously.
        
        There are a couple more callers that look like they want to "replace"
        some text, so guess a bit at where to set this new flag.
        
        (note: of course fly anchored *as char* must be deleted via keys.)
        
        (regression from commit e75dd1fc992f168f24d66595265a978071cdd277)
        
        Change-Id: Ib4467476b12a12aefbbcb74ab9802f9318cf9aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135476
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-08  Eike Rathke  <erack@redhat.com>  [025231224b8b076e280235cd2b943addd2fb0755]

        Resolves: tdf#149484 Read and handle <number:text> in <number:boolean-style>
        
        Change-Id: I1be5f2be908eb88aa4ef7436ea7c09f35b076acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135507
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-08  Eike Rathke  <erack@redhat.com>  [2932dc7aa0c1239d39e060e6b7627317f1305549]

        Related: tdf#149484 Display BOOLEAN literal string text additions
        
        Change-Id: Ifbaf0b18178091c3a340a7c4bc66f78397aadc18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135506
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [98cfc7db5ed352b2ddb9a547c7f88abb83264cef]

        libtiff WASM: add Emscripten flags to fix NEH build
        
        Change-Id: I3ea1ca064cdddee1bea6b5816f63f0e4a93217de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135505
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [ea5a0918c8c32309821ab239c4b95f4d6a3b5c12]

        VCL add vcl::WindowPosSize abstract class
        
        ... and use it to remove a duplicate and simplify code.
        
        Should mostly be a refactoring, which was mainly done by some
        larger sed calls, except for the new API calls, which helped
        shrinking some LOC. All data is also now private.
        
        Originally two of the "replaced" "classes" had unsigned width
        and height and one had signed. Noel pointed out, that during
        calculations, the value might get negative temporarly, so this
        now settles with signed values. Still the set size should never
        be negative and this is enforced this way. Not sure that is what
        Noel had in mind.
        
        This also includes:
        - rename WindowState => WindowData
        - rename WindowStateMask => WindowDataMask
        - rename WindowStateState => WindowState
        - move WindowState and WindowDataMask to vcl/windowstate.hxx
        - move WindowData(Mask) and WindowState into vcl namespace
        - readability: replace or'ed WindowState enums with "meta" enums
          + add "meta" WindowState enums PosSize and PosSizeState
        
        Change-Id: Icd16cfb498531aa7238ddbde83fcb0ed6d9e4f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135426
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-08  Miklos Vajna  <vmiklos@collabora.com>  [d4123356c61db269651e950a0a2cc93e6d801c90]

        RTF filter: allow measuring page borders from the edge of the page
        
        This is similar to commit 51942eafdb4439559b6d59f3becd4afab45277f0 (DOC
        import: allow negative page border distances, 2022-06-08), except here
        we map \pgbrdropt's 5th bit to the "from page edge" bool, and then the
        rest of the import works already after the DOCX fixes.
        
        Similarly, the export has to map the "from page edge" bool to \pgbrdropt
        and has to call into editeng::BorderDistancesToWord(), but the rest of
        the process works after the DOCX fixes.
        
        Change-Id: Ic88f1ab17ac169025c38790ffa895748df0a76c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135502
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [c44fc5056913423258d740e74f4980017e2431ff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fc9022d593c7b7ae9818ed4b4502a2743e7ac377
          - Fix sentence about solver settings
            
            As pointed out by Adolfo in change 40ee3181de08d372b5a25bb691644a94d3ffe9bd, the word "beware" was used incorrectly. This patch fixes it.
            
            Change-Id: I3b2dd94b04b9c9c5ca5dc9c0b4c99a8e1c048941
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135384
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-08  Luboš Luňák  <l.lunak@collabora.com>  [118bafcfd1ce4a26ec9df912197ebd466d1bd497]

        use recursive mutex for LOK queue
        
        Callbacks may be invoked while calling getLOKPayload(), which
        would try to lock the mutex again. I actually originally expected
        this possibility, as the comment and moving the data to
        temporaries in CallbackFlushHandler::enqueueUpdatedTypes()
        shows, I just didn't realize the used mutex wasn't recursive
        and so would deadlock.
        
        Change-Id: I2b5c4b6b4c1a3933a32ae4641830877e085f2b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135499
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-06-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7905dba8a5c76eb7b4da5580e4f77e1a9b0dc8f0]

        fix typos
        
        Change-Id: I47acb63703d007da7493d9baaa5569bc375e4f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135386
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-08  Caolán McNamara  <caolanm@redhat.com>  [6f17d42f251bf4a20b4192c16fa007226dcf17ed]

        tdf#119827 implement GtkBuilder "scale" property for font size
        
        and use it for the case in charnamepage
        
        Change-Id: I5920aa429c750e9b147cbc09a6f3814166851a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135493
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-08  Luboš Luňák  <l.lunak@collabora.com>  [e3f8a433799b2ccc2f16ba7691f790bd98febb16]

        it is not our job to tell GCC whether to colorize its output
        
        GCC's -fdiagnostics-color option is complex (read: brain-damaged),
        since it depends on how the compiler was configured during building it
        (https://gcc.gnu.org/onlinedocs/gcc/Diagnostic-Message-Formatting-Options.html).
        So while with Clang coloring works out of the box and the option
        can be used for force it in special cases, GCC depending on how
        it's been built may (or may not) require the option explicitly
        just to do the sane default. 13b52f50e52d226c935dcb94fac641c59a77f13f
        added an explicitly =auto to handle that, and then
        9ab2703d5c212746c961dcb238a4c3025d3a2587 changed it to =always
        depending on gb_COLOR to prevent it from overriding
        explicitly used option. This results in a possible massive rebuild
        when redirecting build output (because e.g. PCHs get rebuilt if
        build flags change, and ccache I think cannot use cached compilations
        either).
        
        It should not be gbuild's job to go out of its way to handle broken
        tooling, so just revert both of those. If somebody uses such a lame
        GCC build, either don't do that, add those explicit flags
        to CXX/ENVCFLAGSCXX, or create a clean way to add flags to CXXFLAGS
        or something.
        
        Change-Id: Ieac6ac7dd198639529aba8f47983587771772349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135467
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-08  Miklos Vajna  <vmiklos@collabora.com>  [437acab38f2404886a2b83138eb9eb11c4146a76]

        sw: fix crash in SwFEShell::SelectObj()
        
        Fatal signal received: SIGSEGV code: 1 for address: 0x0
        
        SwLayoutFrame::Lower() const
                sw/source/core/inc/layfrm.hxx:101
        SwFEShell::SelectObj(Point const&, unsigned char, SdrObject*)
                sw/source/core/frmedt/feshview.cxx:317
        SwEditWin::MouseButtonDown(MouseEvent const&)
                sw/source/uibase/docvw/edtwin.cxx:?
        
        Change-Id: I6c4076eef21dd80381b37ed89aa2dc8bc20fbc98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135491
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-08  Colomban Wendling  <cwendling@hypra.fr>  [d2a5b4bc0b8c8d1dd82133719a3ef5cc01b0cbbe]

        toolkit: convert AccessibleStatusBar test to C++
        
        Just translate the test and add required or handy CppUnit helpers.
        
        Change-Id: Ib8ccd3490876c6302cca85e69f4d61600f7aec84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133844
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-08  Jean-Pierre Ledure  <jp@ledure.be>  [1d5ed2fdd14a8dc6871b687e795507b4f06fa67e]

        ScriptForge - (scriptforge.py) modify URL to help page
        
        Avoid using hardcoded release number. Use 'latest'.
        
        Change-Id: I04f531ee736bcd94d058413634ddb49046bc6c5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135475
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-06-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7784f289d29c49e14229c9ec86ce994b68d0ecb7]

        Fix typo
        
        Change-Id: I56b36663a460eb6840968bc02e61371ace558fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135490
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-06-08  Miklos Vajna  <vmiklos@collabora.com>  [51942eafdb4439559b6d59f3becd4afab45277f0]

        DOC import: allow negative page border distances
        
        In case the margin (distance between body frame and page frame) is
        smaller than the border spacing (distance between border and page
        frame), then we can map that to a negative border distance during the
        import of DOCX files since commit
        1f127a2b9e1c1daab0972f98fc8708ecb7afa299 (sw layout: allow negative page
        border distances, 2022-06-07), but DOC import had the same problem.
        
        The above commit intentionally kept the default behavior of
        BorderDistanceFromWord() unchanged to avoid side effects in other
        clients of that function (not DOCX import), but means that DOC import
        was still broken.
        
        Given that it turns out there are only 2 callers of
        BorderDistanceFromWord(), fix the problem by allowing negative border
        distances unconditionally: this simplifies code & SetBorderDistance() in
        the DOC import will now get the correct border distance out of the box.
        
        DOC export works out of the box without any additional work.
        
        Change-Id: I6bf15b3c73823c9265218b7b3a7b869e131818db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135484
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e216988657e20a1e52986f742ab60464697bcb41]

        tdf148321: convert OOXML inset values to text distance values
        
        Inset values for top, bottom are calcualted differently in OOXML
        and need to be coverted on import to the text distance LO values,
        that place the text relative to the shape correctly.
        
        At export, the values can be converted back to the OOXML inset
        compatible values, but the values are not always converted back to
        the same values as the conversion is not bijective, however they
        do render the same.
        
        This also adds the test for the conversion when importing and
        checks that the exported values are expected.
        
        Change-Id: Ic64eec1a2a80ddad997f916da3e87dc30aaa12be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135463
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-06-08  Miklos Vajna  <vmiklos@collabora.com>  [e9a7ed53260feef439b7b046286352b23a69668b]

        sw content controls: update the cursor at SwContentControlDlg end
        
        Once a dropdown content control is inserted, the properties dialog can
        modify list items. The desktop case updates these list items when
        SfxViewFrame::Enable() calls SwView::ShowCursor(), but for some reason
        the same implicit update doesn't happen in the LOK case.
        
        This means adding new list items requires leaving the content control &
        entering again, then the dropdown shows the new list items, which is
        confusing. And also the update (when it works) is implicit, so it can
        break without us noticing.
        
        Fix the problem by explicitly updating the cursor before ending the
        properties dialog: this will scroll to the cursor position, but that's
        not a problem since the properties dialog is always editing the content
        control at the current position anyway.
        
        Show / hide is used because that's an easy way to call
        SwCursorShell::UpdateCursor(), which is private to us.
        
        Change-Id: I43aca24c2961ef6c4cc14f895edd6f3f22980148
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135483
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-08  Miklos Vajna  <vmiklos@collabora.com>  [1cb9274494ec429bd9b937533d21c6b39a1795de]

        CppunitTest_vcl_pdfexport: reduce test doc size in testAlternativeText
        
        A one-pixel image will do the job.
        
        Change-Id: Ied9b51c104a39b0bcf5401d8486c11f87c979805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135477
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-08  Noel Grandin  <noelgrandin@gmail.com>  [bf29483599c67cebfe0c3e06d063d3ae233b28dc]

        tdf#81293 dialog “manage names” forgets size and column width settings
        
        I can't see any reason for this code to be this way. I can
        see that Jim has tried to make some dialogs retain window size and
        position. Surely all dialogs should be able to do this?
        Unfortunately, it has been this way since initial commit.
        
        Let us live dangerously and see what happens if we give
        power to ALL the dialogs.
        
           VIVA LA REVOLUTION!!!
        
        Change-Id: I44e389ba3cb46793365607d36a05474584ee6490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-08  Mark Hung  <marklm9@gmail.com>  [3e754c07fabd1f74d57f42f273ea46e03dbdc094]

        tdf#149089 fix extra mini space in text grid.
        
        1. Create Justify::SnapToGridEdge() to adjust kern array
        under CJK textgrid GRID_LINES_CHARS mode when snap to chars is off.
        This function can handle a) Unicode IVS b) rInf.GetSpace() like
        what CJKJustify() does.  c) rInf.GetKern() value for letter spacing.
        
        Excluded parts comparing to original kern array adjustment:
        a) Kana compression under textgrid mode has been removed. Kana compression
        is used to compress space of punctuation. It doesn't make sense to
        perform that under textgrid node.
        b) Inserting nSpaceAdd for CH_BLANK is removed. I don't know its
        purpose.
        
        2. Use Justify::SnapToGridEdge() in GetTextSize(), GetTextBreak(),
        DrawText(), GetModelPositionForViewPoint() to adjust kern array
        consistently.
        
        Change-Id: I136a92f513fae05af2fb429e747356ba7eedec7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135086
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-08  Caolán McNamara  <caolanm@redhat.com>  [0515ad196654c929dfd345dcf11f97fc09820cfc]

        add LIBTIFF to cross-compiling targets
        
        with an eye to win_arm64 cross build failure
        
        Change-Id: I6872859f288168352e3e70c1d559f4d318439958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135479
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f593c328b1c8fc10dafcbdc8c23ea6ac51a26d47]

        Fix typos
        
        Change-Id: If282a3a9f68de2cf0f1576ea34b56b9316f03ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135470
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [15e182148bbd3213c13d10f5b519edd750987982]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40ee3181de08d372b5a25bb691644a94d3ffe9bd
          - Related tdf#38948 Warn that Calc Solver does not save model to file
            
            Based on Comment 36 from bug 38948, the help should make it clearer that Solver models are not saved to the file by LO Calc.
            
            This patch changes the current <note> into a <warning> and makes it clearer that solver settings are not saved.
            
            Change-Id: Ie1cdf5a82c105c371e05b85ccad6736ed5e74a3f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135272
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-07  Tomoyuki Kubota  <himajin100000@gmail.com>  [d1581fe4cc1d7ea0c8b3f54fec3e16c8348b7027]

        rPosition to pPosition
        
        Change-Id: I5c1bda5419752288e494e2116bef8d258a1de4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133869
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b8e9d3126d4232c6c13e6059ab3542a521251d8]

        bin: Add script to get attachments from OO forums
        
        Testing it locally, I could download 52.000 documents
        Reuse mimetypes dictionary from get-bugzilla-attachments-by-mimetype
        by putting it into an external file
        
        Change-Id: I875d90f6119c3c3bdfea6a0efd3bbc8c5be1eb63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135457
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-07  Attila Szűcs  <szucs.attila3@nisz.hu>  [8741fd0e0ae9e346de2e09887f0668b831c9b48b]

        tdf#43244 sw: show stripped line-end spaces on margin
        
        in View->Formatting Marks mode instead of hiding them
        This way it's possible to avoid interoperability issues
        better, when these (now visible) spaces are stripped only
        in Writer, but not in MSO, resulting different layout,
        i.e. bad paragraph alignment, because the users can
        notice the extra spaces and remove them in Writer.
        
        Extend SwHolePortion::Paint() to paint its text,
        what is probably just a bunch of spaces.
        
        It's an initial fix for tdf#43100, tdf#120715 and tdf#104683
        (cursor movement on the hidden spaces, end of paragraph sign
        before the hidden spaces, unable to select spaces after the margin).
        
        Follow-up to commit 93d7bdcb855362b88cdcfcb18ea401d89da973fb
        "fdo#33167, i#20878: Show spaces at the end of line".
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I48df3b41af37c77fd594bb6776ca30e845c51490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135104
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-07  László Németh  <nemeth@numbertext.org>  [5a079652c1b1f968a851f47995b0a65b84d2d192]

        tdf#149421 DOCX: import/export hyphenation zone
        
        Hyphenation is a document-level setting in OOXML (only
        disabling hyphenation is a paragraph-level setting),
        import/export hyphenation zone in Standard style, similar
        to IsHyphenation.
        
        Note: Remove HyphenationZone from grab bag to allow its
        modification in Writer.
        
        Fix also grayed out hyphenation zone input box in
        Text Flow, when enabling hyphenation.
        
        Follow-up to commit 7a1d4b7d1db93ca1f541856a8d00d621d50e7bd6
        "tdf#149420 sw offapi xmloff: add hyphenation zone".
        
        Change-Id: Ic1a3f13ba4e80338227c3206a0ed619589809328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135474
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a0f39cece651b787a21d3778d0b69625a25dae6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aa1b42c379b95fc484853a82325dbd61ceb6e73d
          - Revisit Insert Image help page
            
            Updates on menus and instructions
            
            Change-Id: I45bbc4709baf550d0caad5700754e7f168c64ba3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135423
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-07  Stephan Bergmann  <sbergman@redhat.com>  [1e57cb128eb085ede312ebb189c982b8bda49377]

        Duplicate object ID
        
        > instdir/share/config/soffice.cfg/modules/swriter/ui/fldfuncpage.ui:723:1 Duplicate object ID 'liststore4' (previously on line 30)
        
        since 7e2a8abf0cd8c60cdfae100eece4839b4959c70e "liststore used twice by
        different widgets"
        
        Change-Id: I9e1b90ae352ba5c1fd5e634401096c70cdafb2bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135472
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-07  Martin Srebotnjak  <miles@filmsi.net>  [aa79ca510027f4e07311b8aaa045bef56da8d2cb]

        Update git submodules
        
        * Update translations from branch 'master'
          to 1cb47d77ece911852b9fc5ff728b92ac779e39bf
          - Updated Slovenian translation
            
            Change-Id: Ie86b805a08a629c9acb045cd083b6e0f326c47c1
            
2022-06-07  Luboš Luňák  <l.lunak@collabora.com>  [0372da98bf9b2af82afc2e4ff919068bdcaae7db]

        fix SwViewShellImp::AddPaintRect() rectangle compression (tdf#148255)
        
        Both the checks test whether a follow-up rectangle can be merged
        with the previous one by merging it at the bottom or the right of it,
        so the previous one should be always the top-left and the follow-up
        one should be the bottom-right.
        
        Change-Id: Ie5809595ec9bf28bd169fc503a6b391c6188d0b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135468
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-07  Eike Rathke  <erack@redhat.com>  [bc026248fe44321b44240fb5d9f4e6d3335380c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba3b8d5bc6416cec3ab2d86ba8452c292681086e
          - Include metacharacters fragment in ICU regexp URI
            
            So it leads to Regular Expression Metacharacters instead of just the
            page that starts with all sort of developer information not relevant to
            users.
            
            Change-Id: Id1efca75302d023a83b45a4bc81654ffe8c2980f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135471
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-06-07  Laurent BP  <laurent.balland-poirier@laposte.net>  [d93e9430bfbf6fa8a679ea2d4d98f955774026f6]

        tdf#129674 Add GoTo Sheet command
        
        Insert command in menu Sheet > Navigate
        (alongs with To Previous/Next Sheet)
        Use .uno:JumpToTable command from Navigator
        Use its own Go To Sheet dialog
        Add a Search entry to type partial name of sheet
        Menu translation missing?
        
        Change-Id: I16b8b56a688c8396159617f04a2a7e034721ce31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134714
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland-Poirier <laurent.balland@mailo.fr>

2022-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [19a6adddec0f5a6ee771939a17f85bdde4a44ce3]

        sw:  Divide-by-zero
        
        follow-up of aeeb0141aca4f1698b09bc8f06ded41247b54279
        "sw: avoid another EXCEPTION_INT_DIVIDE_BY_ZERO"
        
        Change-Id: I0b5cc10c4f7976a611f222f3d4c8764c5d04dba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135443
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [e55e3e1362910a9ea38b8283f5bb2b886e803cf3]

        use more complex scheme on newer Python (>=3.7) to avoid DeprecationWarning
        
        similiar to commit 069f0eb13f7d26ce4b854160bbb9592c25609b38
        
        Change-Id: I08577ced705df620d99781da53b6085398f52821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135450
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-07  Jean-Pierre Ledure  <jp@ledure.be>  [b4735aac82c6db0afd5692f485364510ac2d9a5d]

        ScriptForge - (SF_UnitTest) fix typos + layout reviews
        
        Typos in comment lines
        Minor improvements of test report layout
        
        Change-Id: Ic19e55a84475b098959055ac1c573de629e21731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135466
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [6ccff201088590274247fb9f63b7fa997cfee327]

        Fix ImageView without text on GTK
        
        Change-Id: I2c1884722de2d40e96282d1efbba4be0ad078bd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135465
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-07  Michael Stahl  <michael.stahl@allotropia.de>  [badad69848f10b462a11f5b5e784cb468a94b180]

        sw: fix pasting multiple flys in SwFEShell::Paste()
        
        This was most recently fixed in 3cfd63cb55ab1a7e6df53eaeb2a7623be05983d0
        but that didn't take into account that now with Ctrl+A multiple flys can
        be selected and copied, and all of them should be pasted; remove the odd
        restriction to paste only one text frame.
        
        This reveals that pasting a text frame will actually select the text
        frame, so subsequent flys end up anchored inside the text frame; delay
        selection until all flys have been pasted.
        
        Change-Id: I049f60ca9656e5075d481d4501bb1ffdd28a4e21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135366
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-07  Heiko Tietze  <tietze.heiko@gmail.com>  [196d9e16b7017db2225531cd240e7b6e8f7c1d66]

        Resolves tdf#146928 - Redesign charnamedialog
        
        Dialog was changed in d73602dc51aa8829fc88e5e67e2b0c4da6b8f715 to fit
        vertical size on small screens by placing Western/CJK/CTL into a notebook.
        But for CJK and CTL it's required to have Western fonts visible in parallel.
        
        * dual solution for western with nocjk and cjk dropped
          western scales to the dialog width if no CJK nor CTL is enabled
        * CJK and CTL placed in a notebook, Western as well for proper alignment
        * font names are presented in lists but size and style per simple dropdowns
        * info text sized at 80%
        * variables renamed to keep track of controls (old names kept in l10n descriotion)
        * UITests adjusted for variable names and tab positioning
        
        Change-Id: I45b40e9bc37565f6364f1dfc1b5d837270fe4644
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134666
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-06-07  Miklos Vajna  <vmiklos@collabora.com>  [410a64b472ae9de0bb06ddd8f4b55fd16686c860]

        sw: prefix members of SwEscherEx, SwWW8WrTabu, WW8_WrFkp and WW8_WrPlc0
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia8f3150b7da815c7b5f253f76e65dada3ef8256a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135461
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-07  Martin Srebotnjak  <miles@filmsi.net>  [f30b49b82e563d5d7f88a04080cd5d844872a3be]

        Update git submodules
        
        * Update translations from branch 'master'
          to 40da1e34cabf93b04d900b7b6ab501fb3160efef
          - Updated Slovenian translation
            
            Change-Id: If7fea40ad58b893757b644d670f1470c40dcbfde
            
2022-06-07  Mark Hung  <marklm9@gmail.com>  [7f310b8c2d8d496b38dd62aa6b06e61442e1a2d0]

        tdf#149365 tdf#149214 handle IVS and mix width chars
        
        in Justify::SnapToGrid correctly, and use it in
        SwFntObj::GetTextBreak() and SwFntObj::GetModelPositionForViewPoint()
        to get correct text positions before any further calculation.
        
        In fntcache.cxx a simple formula was used to calculate the average
        width of text grids occupied by ideographs. That's incorrect because 1)
        for strings containing Unicode IVS, a ideograph is composed of several
        sal_Unicode and the length of the string is not the same as the number
        of ideographs contained. 2) The average width doesn't work because
        character width varies, like ideograph and half-width kana in the
        test case.
        
        Change-Id: I863e8d8e346f555ff184a2f47d615e513b965b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135342
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-07  Miklos Vajna  <vmiklos@collabora.com>  [1f127a2b9e1c1daab0972f98fc8708ecb7afa299]

        sw layout: allow negative page border distances
        
        Writer follows the CSS box model when it comes to page borders: there
        can be a positive distance between the edge of the page and the border,
        and again a positive distance between the border and the body frame.
        
        This ensures that the page border never intersect with the body frame,
        which is usually what users expect. Word, however, can work with 2
        distances for border and text, both measured from the edge of the page,
        leading to a page border, which is inside the body text. This is
        described at great detail at
        <https://wiki.openoffice.org/wiki/Writer/MSInteroperability/PageBorder#Importing_case_3:>.
        
        Fix the problem by allowing negative border distances: this doesn't
        influence the position or the size of the body frame, but it gives us a
        way to position the border more towards the center of the page, leading
        the matching layout between Writer and Word.
        
        The doc model (to allow negative border distances), UNO API and DOCX
        filter is updated in this commit. The ODT filter works without explicit
        effort. Other filters are not yet updated in this commit.
        
        Change-Id: I723e1bdb8dc6391129f1686f88826cc089f6fd67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135462
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-07  Stephan Bergmann  <sbergman@redhat.com>  [f4b6cee77e1725837f9a6044fec0b561c7049c3b]

        Use o3tl::make_unsigned, OString::getLength() is guaranteed to be non-negative
        
        Change-Id: Ibddd4f2b3d8680c94fd0ab45f6ed6204215c6009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135339
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-06  Eike Rathke  <erack@redhat.com>  [f572585756494c59fb81f5d93c51cc2d35421f0e]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 15c340d66842e3f99729e20686ffec28d36c2784
          - Related: tdf#147390 Add oc-FR-lengadoc to oc_FR/dictionaries.xcu
            
            And remove trailing whitespace and convert to unix line ends..
            
            Change-Id: I1fba3ef0c1b7e279f299a4adfd3fdffb7a9a60d4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/135459
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Eike Rathke <erack@redhat.com>
            
2022-06-06  Eike Rathke  <erack@redhat.com>  [196f2b6f8e61cd8e78f6f8dfda6b55c4fbaec0c8]

        Resolves: tdf#147390 tag oc-FR to oc-FR-lengadoc, oc-ES to oc-ES-aranes
        
        Change-Id: I849e8e2c6cf2a61b81b25c96b79478bc04907b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135458
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-06  Eike Rathke  <erack@redhat.com>  [1e022eb12e1222d6d9c6d127a18b0ed8fd49b6c0]

        ScSingleRefData::TabValid: for absolute reference take sheets into account
        
        Change-Id: I56e7e34f127345e2633b5bef07c2783ed8ffbbfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135456
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-06  Eike Rathke  <erack@redhat.com>  [104596d005b32bd2bba15554e8c9ae740327aa46]

        Resolves: tdf#148163 Preserve names of bad cell reference input again
        
        A regression of
        
            commit e247262327d04ad9933f4af354050f4420c6e303
            CommitDate: Tue Jul 30 23:49:55 2013 -0400
        
                More on avoiding direct access to data members.
        
        that changed, for example, invalid sheet references
        
        -                aRef.nTab = MAXTAB+3;
        +                aRef.SetTabDeleted(true);
        
        The then following
        
            commit 8a19af57bbcc57a02a7d87c6408d1e3212a6deba
            CommitDate: Tue Jul 30 23:50:03 2013 -0400
        
                Now nobody accesses reference members directly. Make them private.
        
        changed ScSingleRefData::Valid()
        
        -    return  nCol >= 0 && nCol <= MAXCOL &&
        -            nRow >= 0 && nRow <= MAXROW &&
        -            nTab >= 0 && nTab <= MAXTAB;
        +    return ColValid() && RowValid() && TabValid();
        
        without taking the deleted flags into account, where previous to
        commit e247262327d04ad9933f4af354050f4420c6e303 nTab > MAXTAB
        fulfilled the condition of not valid.
        
        This makes it necessary to adjust the
        TestFormula::testFuncRangeOp() test case that relied on the broken
        behaviour.
        
        Change-Id: I42e769ca0d56a2eb786bb6f65917f0c15d082763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135453
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d987918e811d71357a934684cb481ca06466f06e]

        improve field name
        
        Change-Id: I78c1670589c21c047ba7a2eede86e46643e88f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135451
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-06  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [e4035407c048e61c62ea237581bf6d11374d66b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b96772378358eba9af18e8bf3dd99c5d8042eba
          - tdf#149437 Help: Update “Equally” to “Evenly”
            
            See core commit 73dde4733fdf66408d9ed6b048dfab4f77f088d8
            
            Change-Id: I4fab0377f68fc48dcc5958fd3369637353f8bc97
            
2022-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [03e8b5e08dcab5d29b360b769205977cd26bd41b]

        add comments to SvtBroadcaster about field sizes/packing
        
        Change-Id: Ia01897ac1444e9ac905a0e383b892fa1478c2c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135447
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [81b3cd44e160f4e600e4cb01410d540b32710c96]

        clang-tidy modernize-pass-by-value in basctl
        
        Change-Id: I12adfacb8f04ee6f08bcc711cef09c5882ff0b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135446
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [af36f2c269e4e04cdde426b5f149c87190d766ea]

        clang-tidy modernize-pass-by-value in accessibility
        
        Change-Id: Ib0658b5a0bb33e5f990b8ce4bf25b2d9cef32505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [65908a69836ab15d71d55f0740bc89d1fc643d16]

        Fix typos
        
        Change-Id: Icc97a5fdf00c9b8f267a2015a72c050438452105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135441
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fbce18558a58cddf910b788a67c2f2d4d25d68e9]

        tdf#149402 - BASIC: Don't extend comment if line ends in a whitespace
        
        Change-Id: I8adf530e77a0e65329fa59ac2873b99f48befac4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135336
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-06-06  Luboš Luňák  <l.lunak@collabora.com>  [d6752e02e3870875ced86adc04aae8e36a12cf0c]

        make SfxStateCache::xDispatch up to date before using it
        
        When e.g. having one image selected and then double-clicking on
        the other one Execute_Impl() gets called with SfxStateCache still
        having bSlotDirt and mxDispatch out of date.
        I originally tried to make all mxDispatch accesses first ensure
        !bSlotDirty, but then unit tests started failing with hard-to-debug
        crashes because GetSlotServer() also sets bCtrlDirty, which leads
        SfxBindings to handle that in idle timers. So at least handle this
        case, where it really is necessary.
        
        Change-Id: I4ec5908bc955c562e14cd813e269536924ce6f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135344
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [48646ab6d71db8ffa2aae9f54f515d413249809c]

        Fix typos
        
        Change-Id: I36d81be6e591830ee3762a0d43357dbacd68ad93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135439
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [365ac1c068578fdc5a84d54cefe0c7fd0324aa71]

        Fix typo
        
        Change-Id: I313b07bb1a3c387abddcad85c997075bd584ae6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135440
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c2cea024a0c7d1919abdb674599bf8d5b2f07f9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 396d82a4d705d7b473f767816f970bffec74d33e
          - tdf#148817 Sparklines Help page.
            
            + add bookmark entry
            + update Calc Insert menu help page
            
            Change-Id: I76315d7c35a2a98731ef92d9090ebcba41f9e004
            Co-authored-by: Tomaž Vajngerl <quikee@gmail.com>
            Co-authored-by: Roman Kuznetsov <antilibreoffice@gmail.com>
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135324
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-06-05  Eike Rathke  <erack@redhat.com>  [2ba57cd896484411fb2c8527802d551f02d419aa]

        Resolves: tdf#148428 Add Dhivehi (Maldives) {dv-MV} locale data
        
        Co-authored-by: Adam, M. A. <adam7171@gmail.com>
        Change-Id: Ia8259d8ad67fd4105bffb752d0442102d6576f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135438
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [2884ea0ccac3812fcded31327ad4fc9b978fd754]

        cid#1504664 silence Operands don't affect result
        
        Change-Id: I9ec3ae0e8cb87ab8a98746b8e49fd3f969ea0bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135437
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [86d39afd85ed929dcfb8e1497680605cb095fc41]

        cid#1504593 silence Dereference null return value
        
        and
        
        cid#1504597 Dereference null return value
        cid#1504595 Dereference null return value
        cid#1504666 Dereference null return value
        
        Change-Id: I6054120575fb2769633177c36eb41c6798c4c648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135436
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [264b78cbd7b049d323797cad332b664fe3af2088]

        assert if a model is used in duplicate widgets
        
        we never do this deliberately
        
        Change-Id: I6d6d8ea13fb5f09bcf631c0474e671d4605f4c69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135427
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [3cca2c605313576187878a195fb612eb25bd6150]

        restore %PRODUCTNAME to accessible descriptions that need them
        
        The original problem was that %PRODUCTNAME wasn't replaced for
        accessibility descriptions (which are reused for extended tips) under
        gtk.
        
        Universally querying all a11y descs on load to potentially replace
        %PRODUCTNAME in a11y descs at runtime led to tdf146971 which was a huge
        startup slowdown.
        
        The half way 7.3 fix was to leave a11y descs alone, but do the
        replacement when querying for the extended tip case. So the extended
        tooltips were ok, but screen readers would still say a raw
        "%PRODUCTNAME" text, hence the rewording effort to remove %PRODUCTNAME
        from the a11y descs entirely for 7.4.
        
        But there is now a few cases where some options paths exists in the a11y
        descs which is not exactly correct wrt to the text shown in the options
        dialog.
        
        Reworking the options dialog to not have %PRODUCTNAME there at all and
        updating everything to fit that sort of change would not be popular. So
        move the cases where a11y descs really should have %PRODUCTNAME in them
        out of the .ui files and into .hrc files and use specific
        set_accessibility_description calls for them via ResID which will do
        the %PRODUCTNAME replacement automatically.
        
        Hopefully the a11y runtime cost for just this handful of cases is
        negligible in the overall scheme of things.
        
        Change-Id: Ieb17d26fd581cd5804a52b371b3bb5ea43023aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135432
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [e6b5c2dc0bb12c7e0d23857bdd0e22076d587ca3]

        drop stray space before full stop
        
        Change-Id: I50013a672cc953822845a2e02d038e75f51ef457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135431
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Caolán McNamara  <caolanm@redhat.com>  [7e2a8abf0cd8c60cdfae100eece4839b4959c70e]

        liststore used twice by different widgets
        
        Change-Id: Id4577af678addbc984f35b8e35efc2841f5ff6c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [3f8d3fd4649ef09e86c735617383a4bda0425540]

        tdf#137471 Qt return frame pos + client area size
        
        My code comment about "drawable area" and Michaels bug comment
        12 about the "frameGeometry()" usage were both half right. LO
        expects the window's frame position and the drawable client area
        size almost everywhere when "geometry" is involved. The frame's
        border is stored in the decorations members of SalFrameGeometry.
        
        Change-Id: Ic00ad1f1d74d7afadcaca0c01e1a41ea7f2833de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135434
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-05  Noel Grandin  <noelgrandin@gmail.com>  [e0e944a42059271d082f8bd5121f30a4536fb8f3]

        no need to allocate this separately
        
        Change-Id: I30df477cd708d021fc5b6fcfa9925e1c99be6650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135429
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-04  Caolán McNamara  <caolanm@redhat.com>  [c1898a4d1b38e0077416a104e2b47573ce207ffa]

        Duplicate object ID 'altname-atkobject'
        
        Change-Id: I47c488ef5c192d464ef2661c4ff5473e98bb2208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-04  Noel Grandin  <noelgrandin@gmail.com>  [6aaa3e617523783b98bc68e260a3a7b4912d11b8]

        tdf#149304 Stylist does not show upper/lower case font effects
        
        SvxFont has code to handle these extra features, we just need
        to call that
        
        Change-Id: I45691efeeead3ea60ab838eeb081fa5f19a76b90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135428
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [428cc8da98ddb73f8abeaa3bddb555f3bd896a29]

        WIN refactor geometry updating
        
        Change-Id: I34e710c022e6362dc2381327eb896610c35bcbf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135425
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [434d471e9b8e54626af332974268ffd8fce4a78e]

        Rectangle: move inline definition into functions
        
        ... and add GetPos() as TopLeft() alias.
        
        Change-Id: Ia2c169d40ed121e829802835011648281f48f585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135424
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-04  Caolán McNamara  <caolanm@redhat.com>  [a717b1a8b625e4f0d520f16c546252ffb0679c98]

        this should call the base class enable_notify_events
        
        Change-Id: Icc26f3adcb3273426e6892aafd16da23176e23de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [395b2ca9fd5af7d56d1181ed36f8b45af899539b]

        elide some makeStringAndClear() calls
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: If2532f998343b49a2966e0c704f6f789af936e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-04  Caolán McNamara  <caolanm@redhat.com>  [8907b6a04e900a05efb2e8ae5b5ac4738e67c1f8]

        ofz#47759 Timeout
        
        Change-Id: I8d6b1adb83963c229d71b9f593d39d8cd3e281e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9b211ff5e8db8131c0f9a250ba9ba85d28b29a87]

        tdf#149242 more precise labels for left and right of paragraph text area
        
           The existing labels refer to paragraph border, which is ambiguous
            about where the border is located. Meanwhile these labels refer to
            an area that is to the left and right of the paragraph text area,
            which is well-defined (and explained in help). The change is to
            indicate that these options position in relation to the regions
            that are to the left and right of the paragraph text area.
        
        Change-Id: Ica033f8f48d47fb3f65a26f93ebede26b9cf80fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135161
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3a78fb5d750ae462bf62d4568ad3a504a6db17a7]

        tdf#148491 make Imagemap dialog consistent with Description
        
          This patch is part of a general effort to use
          "Text Alternative" consistently in the UI.
        
          The control names in the Description dialog for
          Imagemap and the Imagemap dialog were both changed
          to "Text Alternative". Tooltips were also added
          for "Text Alternative" and "Description."
        
          No change was made to the extended tooltip for
          "Description", because this field is not exported
          to HTML at present (tdf#149013)
        
        Change-Id: I2c5931efec93cff6b1ff1bf905de770d939b9b93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135155
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e1fd98e4d5bb7290fa6f8213a3995fc15126d322]

        tdf#148941 add tooltips for “Text Alternative” and “Description”
        
            Tooltips are added in the Options tab in the Properties dialog for
            images, frames, and OLE object. The extended tooltip for
            “Text Alternative” is corrected, and an extended tooltip for
            “Description” is added.
        
        Change-Id: I8a14f3aa57aa7414ab2cf4251189d845269788d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135073
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-04  Jean-Pierre Ledure  <jp@ledure.be>  [14c7bc1c90d671743c2f25b6958bb54f03140597]

        ScriptForge - New 'UnitTest' service for Basic
        
        The "UnitTest" service is implemented as a new
        Basic library called 'SFUnitTests'.
        
        ScriptForge unit tests (SF_UnitTest class module)
        ======================
        Class providing a framework to execute and check sets of unit tests.
        
        The UnitTest unit testing framework was originally
        inspired by unittest.py in Python
        and has a similar flavor as major unit testing
        frameworks in other languages.
        
        It supports
        - test automation
        - sharing of setupand shutdown code
        - aggregation of tests into collections.
        
        Both the
        - code describing the unit tests
        - code to be tested
        must be written exclusively in Basic
        (the code might call functions written in other languages).
        The code to be tested may be released as an extension.
        It does not need to make use of ScriptForge services.
        
        The test reporting device is the Console.
        
        Definitions:
        - Test Case: each test case is a Basic Sub.
        - Test Suite: a collection of test cases stored in 1 Basic module.
        - Unit test: a set of test suites stored in 1 library.
        
        Two modes:
        - the normal mode ("full mode"), using test suites and test cases
          The UnitTest service is passed as argument to each test case.
        - the "simple mode" limited to the use of the Assert...() methods.
        
        Service invocation examples:
        - In full mode, the service creation is external to test cases
                Dim myUnitTest As Variant
                myUnitTest = CreateScriptService("UnitTest", ThisComponent, "Tests")
                    '    Test code is in the library "Tests"
                    '    located in the current document
        - In simple mode, the service creation is internal to every test case
                Dim myUnitTest As Variant
                myUnitTest = CreateScriptService("UnitTest")
                With myUnitTest
                    If Not .AssertTrue(...) Then ...
                    '    ...
                    .Dispose()
                End With
        
        Error handling
        To support the debugging of the tested code, the UnitTest service, in cases of
        - assertion failure
        - Basic run-time error in the tested code
        - Basic run-time error in the testing code (the unit tests)
        will comment the error location and description in a message box and in the console log,
        providing every test case (in either mode) implements an error handler
        containing at least a call to the ReportError() method.
        
        Change-Id: I9d9b889b148f172cd868af455493c8c696d1e953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135365
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-06-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [cfb5148b56560a28fe4b790be12caa09fd05b492]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02043ac2c6e34f4ae96abe2bdc5737e35bc01e9e
          - Fix typo in AutoCorrect help page
            
            Currently the help page uses "Clear" for a checkbox option. However, "Uncheck" is more suitable here.
            
            Change-Id: If4a54e61ba96e5d9b4d76d175b165cb9a0cdbcbf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135374
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-04  Eike Rathke  <erack@redhat.com>  [5d47d2a493b4b2aa928efc99186ab3e3e894374c]

        Function Wizard: increase display length of array results
        
        So if the dialog is widened the Structure tab can display more
        details.
        
        Change-Id: I857ca525fea8badc229328ab4c822b7de0b2cc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135369
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-04  Eike Rathke  <erack@redhat.com>  [198ceb02bcd091f69b10e7ee5ca0d8e54119e9ff]

        Function Wizard: use actual array separators to truncate result
        
        ... instead of hard coded ',' and ';'. And truncate / append "..."
        after separator, not at.
        
        Change-Id: I62f8c00f108165102d3b6a8b73b82774b8973a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135370
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [c2a4a7a94887b5ea24e9ba7cfa062842a89e1b4e]

        tdf#149378: sc_uicalc: Add unittest, follow-up
        
        This commit also tests
        
        - 6079bf6879c4baf144b68ef459d825412ecea697
        "Add binary operators to ForceArrayReturn handling, tdf#149378
        follow-up"
        
        - a15ce15709acee3b46fb9f7d6836c57f6e1ef9a7
        "Propagate ForceArrayReturn only for Value parameters, tdf#149378
        follow-up"
        
        - bac202275b1bf1abe4277daf35f74ff973c23483
        "Propagate inline array only for Value parameters, tdf#149378 follow-up"
        
        based on their commit description
        
        Change-Id: Ie69868460ae87a67b31e0bd30a66644e89ea60ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135368
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3d4f7e8fb714aa987c542c8d6c8822a41818701]

        tdf#146988 Opening at cursor position doesn't work in large documents
        
        regression from
            commit 07021596acb3d104ba129d371b1ae0b79f67a6a4 (HEAD)
            Date:   Sat Jun 12 18:57:51 2021 +0200
            tdf#142242 Forename imported with trailing space
        
        Change-Id: I792fbe5955de464f41ac61c85f1ca651121b4a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135372
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Aron Budea  <aron.budea@collabora.com>  [08850dbead8a8a797965aaa97d43d639bc0814d3]

        Related: tdf#147844 still log the discrepancy
        
        Change-Id: Iaed261c5b85ce507fb30b572eb08f09c89dda3e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135367
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-06-03  Caolán McNamara  <caolanm@redhat.com>  [3b5f43a82309007cddec8a953cfb46b5ea1f3c9d]

        ofz#47781 Out of memory
        
        Change-Id: I6ebd284bb3fa2c220b6a09fa9875b97c79f4a239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135364
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [b72c0abac105d2c921e3e5d3e36d5cf2e5ccdbb2]

        tdf#149378: sc_uicalc: Add unittest
        
        Change-Id: Ie92b22ce664d667892e864598158618a0ee4ae6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a6b4b4f288621772991269180aa3a2cffff01af]

        clang-tidy modernize-pass-by-value in svl
        
        Change-Id: I184efd7aee2c3eb02399100a4a7500951255d423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f0b7b388ae06d95007b69812bcf844ac9bed15c4]

        Fix typo in code
        
        Change-Id: I2c1f14d033a733210dfee617ecaa7a9cea07c4f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Caolán McNamara  <caolanm@redhat.com>  [4c3b44fd1e4473ba3e4bd02042849bd0cd876915]

        upgrade libtiff to 4.4.0
        
        dropping ubsan.patch which was fixed upstream in this release
        
        Change-Id: Ic2e35b24f7a9c7c3e2a00da8bc5b5b7d500746fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-03  Eike Rathke  <erack@redhat.com>  [6079bf6879c4baf144b68ef459d825412ecea697]

        Add binary operators to ForceArrayReturn handling, tdf#149378 follow-up
        
        So ={1;2} or =-{1;2} or ={1;2}+3 or ={1;2}+{3;4} or ={1;2}+A1 are
        propagated. But ={1;2}+A1:A2 is not because the range reference
        should be implicit intersection not to be forced to array mode
        unless user says so.
        
        This also adds low level ocPush with svMatrix returning always
        ParamClass::ForceArrayReturn in FormulaToken::GetInForceArray() so
        any derived like ScMatrixToken inherit that.
        
        Change-Id: Ida24414a795d6609bf01e361f96438f9e7f7f66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135360
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-03  Roman Kuznetsov  <antilibreoffice@gmail.com>  [f30af7b3516d783d717745b63134499ea0d049fc]

        tdf#147132 Flatten Basic function
        
        Change-Id: I1e445a565dc9c45810e85b045e68db08a56207f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135271
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-06-03  Eike Rathke  <erack@redhat.com>  [a15ce15709acee3b46fb9f7d6836c57f6e1ef9a7]

        Propagate ForceArrayReturn only for Value parameters, tdf#149378 follow-up
        
        So in SUM(MUNIT(3)) the SUM does not get ForceArrayReturn.
        
        Same as in
        
            commit bac202275b1bf1abe4277daf35f74ff973c23483
            CommitDate: Fri Jun 3 13:08:11 2022 +0200
        
                Propagate inline array only for Value parameters, tdf#149378 follow-up
        
        Change-Id: I60b17352c6e2f4fe608070c07f538456ed863156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135358
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [ae5b06e346ca01bfbc0370632750e5a7c6154e46]

        Use o3tl::make_unsigned, nStrLen is known to be non-negative here
        
        Change-Id: Ibb51c5b47edefe3f22a3d4335bc3136988c65486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135355
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [6af99a90d059446d028cb6fe94c7c74140f2ed02]

        Use more appropriate type for MultiSelection::nCurSubSel et al
        
        (In MultiSelection::LastSelected, there is no need to set nCurSubSel (to a
        potentially negative value) before setting bCurValid to false, as nCurSubSel is
        only ever used after checking that bCurValid is true.)
        
        Change-Id: I3c23c89fbb7b4ef962436476f6576af9fe623fd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135354
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [628082158aecf3d5aeb8732d7ddf5dacc45e4d18]

        Revert "Better use size_t for malloc_size"
        
        This reverts commit 652e4ee372e8939f48f69411b6326b237c6d9e4b.  Turns out on
        Windows read (aka _read) actually has a parameter of type unsigned, not size_t,
        (<https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/posix-read?view=msvc-170>
        "read"), so this started to cause
        
        > C:/cygwin/home/tdf/jenkins/workspace/lo_tb_master_win64_dbg/soltools/mkdepend/main.c(504): error C2220: the following warning is treated as an error
        > C:/cygwin/home/tdf/jenkins/workspace/lo_tb_master_win64_dbg/soltools/mkdepend/main.c(504): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data
        
        (<https://ci.libreoffice.org/job/lo_tb_master_win64_dbg/34368/>) for MSVC builds
        targeting x64.
        
        Change-Id: Ica821c8b32e225b7ebbfcbd33d8b7d55515ab3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135270
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Michael Stahl  <michael.stahl@allotropia.de>  [ff525d0d70ea9d189a430bde944b56d048b03e55]

        tdf#148309 sw_redlinehide: fix mail merge performance regression
        
        The problem is that in the call to pTargetShell->EndAllAction(), the
        cursor is on the node before the newly appended one that has the page
        break, and only this node is formatted (via GetFormatted()), so no new
        page frames are inserted in the layout, which then creates massive
        performance problems later, particularly since the bugdoc contains
        multiple at-page anchored flys.
        
        (regression from commit 42448f48bb48a13d6618a181b12840db6d85c574)
        
        Change-Id: I05cd2a515a7f67132ab1c8c6fa0d675252ea3a15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135356
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [9c130462fd9b3515c3c71428bfc109285ed6ea0b]

        Improve some C code mixing size_t and ssize_t
        
        Change-Id: I9b6082f3e913a9bddcb3bd035b92e829f9b00c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135340
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [613467237fa2e9fe7c816d00127db9951c869c13]

        clang-tidy modernize-pass-by-value in cui
        
        Change-Id: If3d2717c22e33412f813673a93ccc56d23ab2fa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135348
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Caolán McNamara  <caolanm@redhat.com>  [c8642c0ebe4ca16bc06b1b08f9419e4a1a94ba96]

        allow to dynamically show/hide notebook tabs
        
        Change-Id: I19681d9bfcd91e205e684674d1ec8f0058c1eb91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4199a1d0da06b48c9b53afc59102064e86feb5f7]

        Remove duplicated include
        
        Change-Id: Ie59fb3c87bf614dce7288337ab270a31645ee845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135351
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [949f2e0624e798c4ee841585fb38e7d4b693e1d8]

        No need for a cast here when comparing against const int DATE_SIZE = 40
        
        Change-Id: I2e9190ac08dc79fe624572ff3a96c32c18afce29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135341
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [652e4ee372e8939f48f69411b6326b237c6d9e4b]

        Better use size_t for malloc_size
        
        ...as both malloc and read, to which this is passed, take arguments of type
        size_t, not unsigned
        
        Change-Id: I2b114c4e67bc9317d908d613fda607a12cf22579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135347
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [95573221d0597951a63fb73b1bd343d2ab5aeee0]

        Fix type of impl_getISO8601TimeToken etc. string index parameters
        
        ...after 6fc3dfd3f1b5cb13101299df42444f2ff0493846 "use more string_view"
        
        Change-Id: I0f4fb75e90d18ed3331f0c857dce1cfcb7482d65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Eike Rathke  <erack@redhat.com>  [bac202275b1bf1abe4277daf35f74ff973c23483]

        Propagate inline array only for Value parameters, tdf#149378 follow-up
        
        So in SUM({1;2}) the SUM does not inherit it, but in ABS({-1;-2})
        the ABS still does. This was always off, but so far didn't matter.
        
        Change-Id: I00dfcd4b71b8dea943475bb5a593224312258e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135349
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-03  Caolán McNamara  <caolanm@redhat.com>  [6697257931f8e9ed76b2c6a32b310456c94f2848]

        implement "show-tabs" for TabControl
        
        defaults to the current status of "true"
        
        Change-Id: Id4fa50d359e29fa3a7db845edbcb86a3b1caa790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-03  Seth Chaiklin  <sdc.blanco@youmail.dk>  [73dde4733fdf66408d9ed6b048dfab4f77f088d8]

        tdf#149437 "Equally" -> "Evenly" for Table Row Distribution
        
        Change-Id: I4b7f8fa02d0e788ea62b07734c2fbcf3cc0a8ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135267
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1965859c05ccd13859198fe1479167afb4efc7c]

        elide some makeStringAndClear() class
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: I4c780bd8dd356bd764b9f88400a41cca6d85f84b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [1fc5b6c9bd138d974f1d5fc3546b702bc4fc568c]

        Use more appropriate index variable type
        
        Change-Id: I0d18657fe3565b07fb1de2f0704f62aaf8226f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135338
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Roman Kuznetsov  <antilibreoffice@gmail.com>  [66fe1fa945a161b2f617ab3576ddef23d84148f8]

        tdf#147132 Flatten Basic function
        
        Change-Id: Ib2646bfbebdfb6d8e8a3cd1355db75b0405ccfe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135268
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-03  Gülşah Köse  <gulsah.kose@collabora.com>  [a658129012f1d183f95f8bf5dd6d7ff6926cd495]

        tdf#136787 Add control to create 1-bit B&W bitmap while creating mask.
        
        Glow effect creates half transparent pixels on shadow. Creating 1-bit
        B&W bitmap mask treates that half transparent pixels as black.
        We control 1-bit B&W bitmap creation when we have half transparent
        pixels.
        
        Change-Id: Iaf298a0e5ffeeb6637fe5d3f56cf4f8e30a203e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134981
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0b72bea05ae685fb0e91b90d2fd319bfd6f4c21]

        elide some makeStringAndClear() class
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: I5af990cbe1a8f2d5b19fea9a031d7d64aeba1c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [2e197356f8473d3b7ac56ec8e471ff61d9feeba1]

        Use more appropriate index variable types
        
        Change-Id: I3c8985862aeccb350c4e8e04d3f71f9dc7018e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f4e3f3aae0b733283b549fdde586d8409b0c552]

        elide some makeStringAndClear() class
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: Id5906bbd7315e80358d09a0d036e605c54ccbf93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135328
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Stephan Bergmann  <sbergman@redhat.com>  [d7c9a269a45ccb7fb8f87ed666a6358eb6712a38]

        No need to static_cast these const Id (aka sal_uInt32) values
        
        Change-Id: I1ae1a4c0e0ca002414db68bf3ad382cb564e17a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135333
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [10292a359673f57dffcfb26f7d1946788fb04827]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cfdb19246c3675fa8672cd07dfb577949768771e
          - Unnecessary
            
            Have you benchmarked all computers in the world?
            
            Change-Id: I8d818b9b7debd519001b6e1ec061b982481a5f5b
            
          - Fix remaining typo
            
            Change-Id: Id5c5100a25ce41c6cf4d5fbceaee23c68b3d8106
            
2022-06-03  Miklos Vajna  <vmiklos@collabora.com>  [b673b2b868d9d549d059db4c135d776b48977469]

        sw content controls, date: add properties dialog
        
        - add a dateframe to contentcontroldlg.ui, to be hidden for non-date
          content controls
        
        - use a SwNumFormatTreeView to present a list of number formats, with
          a special "additional formats..." at the end that triggers a popup
          where a custom date format and language can be set
        
        - set the format of that tree view in the SwContentControlDlg ctor
        
        - update the SwContentControl from the tree view in
          SwContentControlDlg::OkHdl()
        
        Change-Id: If245eee821fd7fe8b41a40f74b9011c1a6ec140a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135327
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b33227d80be9bae4d247db35391698c71d996bc4]

        clang-tidy modernize-pass-by-value in desktop
        
        Change-Id: Ie9c1cd41c5944b901f4ec6c1e4ffd8608c063ffa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135317
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-03  Miklos Vajna  <vmiklos@collabora.com>  [87c963199c438b88cb21f52d25a08e4d0f1535ff]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I647a84109c0eb79883e1c22e59a5098aa294f02f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135325
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [e3b48ed3b8ca5d3fd65efdb778fc51743123b976]

        Fix type of cppuhelper::TypeManager::getInterfaceMember separator param
        
        ...after a5343a89f898468178f04c241de0b2c2a314a1b5 "use more string_view in cppu"
        
        Change-Id: I7cd577f50cd92586e00f347b2e05247b6b5b0331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135326
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [ad67d0c99a12a2d58d26d84122501733c8aaa2f9]

        Use more appropriate type for LocationAccess::nOwnClassVectorIndex
        
        Change-Id: Iba1709b60a27c331dcc6cf4e6f0966d94130a66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135320
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9030bfb8401a73ff45a8df0f7ba05ae46332fafb]

        Fix typos
        
        Change-Id: I9b7800610a04d0c3e1d241531049fbab06943ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135208
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fc12f345a7db0ca6846f3838545ba1844827c8cc]

        Removed duplicated include
        
        Change-Id: If0b82a13aa5f8fca25fec4d4c72a05a4bf9f98ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135281
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7f1709d8b762c953f33ced3b53222599c40a40c6]

        Fix typo
        
        Change-Id: Ie7d5a2b2a6fceb09ffcb6b24a462dd6911886a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135307
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [74fe9be6fda68d331d73f4331f670d1a24964505]

        Use o3tl::make_unsigned, location is already checked to be non-negative here
        
        Change-Id: Id052b9628e8df6d0e8b61b66f6ddc64d925427ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135321
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [875abc7774e5fb72bc764e0ae8004a85cc9dd14f]

        Use o3tl::make_unsigned, length is known to be non-negative
        
        Change-Id: I2fac355230fd0c80016ca2259b8c6150e7160567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135323
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [f6f19c7ac5a324aa66055cf0ced18152ae21891b]

        Use more appropriate index variable types
        
        Change-Id: I8d82591c12642d66344f70997c5cf40e937569b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135322
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7eaa764d1d16a72d66a817046f8392c6f9c9a680]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1252663b4ac9c1f1220b56f855629734f745944a
          - tdf#129674 Add index bookmark
            
             + refactor help page
            
            Change-Id: I236737649aa20019db33b10e107cba15a20db342
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135305
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [86795b776371c5b788c561c0d5a21f1b358dfb50]

        Reuse o3tl::getToken
        
        Change-Id: Ib8d3b3d02febc03922104a954531db6057d06783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135318
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5e3ad701e28e0b7d57e434d646a6191e2c1b0c0]

        clang-tidy modernize-pass-by-value in avmedia
        
        Change-Id: Ia579341951d3fa0a227cdfa888c380b032e2ee2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [d16122e3e93c2ab4b94d089c4cf4f8ea2dbdf24c]

        clang-tidy modernize-pass-by-value in cppuhelper
        
        Change-Id: I231b84cd973d730fe301045cb7442af2d1ddc5d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [859e0acc39c5353bc8ec2bafcf62d030bfb2bacd]

        clang-tidy modernize-pass-by-value in cppcanvas
        
        Change-Id: I01e638c468f0941e042a839f73801a3ae3cb022a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [b4163877e722298b42f6e96831bd8ffef7785a20]

        Use more appropriate return type for ThreadPool::getPreferredConcurrency
        
        All call sites already effectively asked for an unsigned return type, including:
        * The ThreadPool ctor took an nWorkers argument of type sal_Int32, but
          internally stores that as std::size_t mnMaxWorkers.
        * ZipOutputStream::reduceScheduledThreadTasksToGivenNumberOrLess apparently
          benefits from an unsigned nThreadTasks parameter, getting rid of various casts
          in its implementation that were necessary to silence signed vs. unsigned
          comparison warnings.
        
        The only drawback is that
        
          comphelper::ThreadPool::getPreferredConcurrency() * 4
        
        in package/source/zippackage/ZipPackageStream.cxx would now silently wrap around
        instead of causing UB on overflow (which could be detected with appropriate
        tools).  Ideally, it would use some o3tl::saturating_mul if we had that, so add
        a TODO comment for now.
        
        While std::thread::hardware_concurrency returns unsigned, it looked more natural
        to go with std::size_t here, as some call sites already used that (see above),
        so the implementation of ThreadPool::getPreferredConcurrency is a natural place
        to hide clamping std::thread::hardware_concurrency() to std::size_t (in the
        unlikely case that std::size_t is of smaller rank than unsigned).
        
        This required addition of o3tl::clamp_to_unsigned in o3tl/safeint.hxx.
        
        Change-Id: I0a04a8b32e63ebfeb39f924c4b38520455a6fb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135309
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [86922db292f5708d2431959d15c5ceea70aee7fb]

        Revert "mark SvxFontItem as IsSortable"
        
        This reverts commit c390c2e3f44953e236389467c7c090cee9ebc1b7.
        
        Causes crashes like
        ./instdir/program/soffice --headless --convert-to pdf ooo30162-3.xls
        because code likes modifying items that are in existing
        pools.
        
        Change-Id: I988745a538509f90f357ec6a321b2e37828a4111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  tagezi  <lera.goncharuk@gmail.com>  [3cb921dece44e3e289fc73a64399c1a6c618259c]

        crashreportScraper: Removed time parsing, now it just resets.
        
        Change-Id: I39465cdbc14e28556760a0c1feab22d8998e4d16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135050
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1a4d2a49a47cd8b457b8c704134c0f1beaa9210]

        tdf#148846 TOC: Character fill for tabulation is wrong
        
        regression from
            commit 8e4453c2117b6c3bb15be6b949a0a8a43df66647
            use more FastAttributeIter::toView
        
        Change-Id: I510716d2e4c5535faefb3afb658827cca9b6c4fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [0307018e94f64cd0bf4426f943109e1d7593ec27]

        tdf#149389 Crash when closing document in dead key mode while adding comment
        
        blind fix
        
        Change-Id: I79405cf36ce664024626ca7f348885a3dc91a593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135304
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ac26ea039ea0c355b80232e30c29a07e2bb027d]

        tdf#148087 assert editing a cell with OnSelectionChange macro breakpoint
        
        assert was introduced in
            commit e1972743d692c8d8611912c31aae2cb08ae7636d
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Sep 5 15:01:44 2021 +0200
            be more disciplined with SetUpdateLayout on editengine
        
        We want to restore UpdateLayout when we're done doing layout, we should
        not just leave it FALSE
        
        Change-Id: Ic0431ffc3c66d0d02bfd10c323b18383f52dbc95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6ec923eee1b01d94de7a191940d7f3e1069233e5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 73968565bfdc77c58423f41c8f98be019aa9f446
          - Fix broken links in CEILING functions help page
            
            Address comments from https://gerrit.libreoffice.org/c/help/+/92097
            
            Change-Id: Id4ad0b4ed3d609f9e1ddb2482afd00f318d813bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135306
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [30703dbe59e909e257876524785836e7f4d993b2]

        tdf#143964 insert/overwrite cursor shape lags in formula editing
        
        Revert "tdf#132740 bypass work if selection has not changed"
        
        This reverts commit 865641047be4a693f7a51635ce06eab15675126d.
        
        Change-Id: I69244a1e57ce979bf21946e31df7165f8791423c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [0030fa0d5174b45ae7f99e3ae923bbec83e50cd1]

        tdf#145603 Drag-n-drop in formula bar creates mismatch
        
        Revert
            commit 60d35f767781de4b8f1e7b264b12015f655c647d
            tdf#132740 don't broadcast if modified status has not changed
        
        Change-Id: I5a0292499522e21708a2d5607966e4c2b3a18ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [bee7a82ae5004874fc5fb343f0e15ab7476aa909]

        A simpler way to avoid MSVC warning C4018 "signed/unsigned mismatch"
        
        Change-Id: I0e6418598cd446dd541708fc91145e5f47d14a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135289
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Luboš Luňák  <l.lunak@collabora.com>  [620cf04907360ce39a03dc2b9f97ac437cdf9a8e]

        fix handling of XTransferable2 if the type is only XTransferable
        
        Apparently some selections provide only XTransferable and not
        XTransferable2, making this entire call think that there's no
        selection at all. Handle that properly, and if XTransferable2
        is not provided, then presumably it's not important to check
        for isComplex().
        
        Change-Id: I3bbafe46a6b9ac8552c62e524137e1691b54895a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135300
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [733a6b4f8eac9d9b93d7ea9c605bebab9f5345dd]

        elide some makeStringAndClear() class
        
        when we are passing the result to a string_view, it is pointless.
        
        Change-Id: I1e11d2610d70ed49c0b00d0c908829e8f1252bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135298
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [d79c527c2a599c7821d27cf03b95cb79e2abe685]

        Use IconView in SmElementsControl
        
        Allows to send individual images over the wire in lok case,
        instead of sending full canvas at every scroll operation.
        
        The control's horizontal and vertical modes (when it's docked to a
        vertical or a horizontal parent window side) are now identical.
        
        Some TODOs:
        * Re-implement a11y - that needs to be implemented on IconView level;
        * Make sure that sub-pixel positioning is not used when creating the
          elements icons (makes elements look a bit slim on Windows);
        * Maybe restore mouse hover indication; in non-GTK case, a call to
          m_xIconView->SetHoverSelection would suffice in SalInstanceIconView.
        
        Change-Id: Idbc35f4e38e2b49fd0848a96da557fa2c1a1f6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134761
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6fbdb87a15f7de97e18676560eeba988fac1b67]

        tdf#149418: vcl_filters_test: Add unittest
        
        Change-Id: I643175f077723b0a865270691f3b50cc817e572d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135295
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c60ad041e8f48759062d652ca20216c424768fa4]

        clang-tidy modernize-pass-by-value in framework
        
        Change-Id: I024653154c51389bb27f3e94b422ff7fc1c9b46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135296
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Caolán McNamara  <caolanm@redhat.com>  [826b0fc9aacbe58c998aec8ebba3401c0a68a015]

        cid#1504597 Dereference null return value
        
        Change-Id: I6b1b34375a70c3081d7f6d90766cb0df053de355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-02  Caolán McNamara  <caolanm@redhat.com>  [6eb1f2c45c16639aa0c7f70f700765348f7c0efe]

        cid#1504591 Uninitialized scalar field
        
        Change-Id: I647888f13fc18010efc5ff6023790e91fa11611a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [aa1004c04b048d6917cd9bf367ec7944ce7c57d4]

        Use o3tl::make_unsigned, nPolygonIndex is already clamped to non-negative here
        
        Change-Id: Ib174df281389b334396905a94fc395900e7d9eb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135290
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [beb19b0a600573cebc66c387f5941efc982ee842]

        There should be no need for a cast here
        
        ...presumably added back in the day to avoid warnings about signed vs. unsigned
        comparisons with old compiler versions
        
        Change-Id: Id95e272949e48adf0e75883368cbcd421e289b33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135292
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [470bc862796a517090448ca18622eca22550a0e4]

        Use o3tl::make_unsigned, nPolygonIndex is already clamped to non-negative here
        
        Change-Id: Idaf80e28f177c84faaec2c047db2b4435b9e7e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135291
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6de84d46c2a41fc4ae53e2744d432e50c4a4ac1]

        std::move SfxPoolItem into SfxItemSet where possible
        
        found with the help of a temporary loplugin (which i have put into the
        store/ folder)
        
        Change-Id: Ide40d09bef6993ace50039a8fd0439b7e29c09a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135288
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Caolán McNamara  <caolanm@redhat.com>  [1577c0dc30ed3c9db361fb989e41a3e9d6c45dfa]

        tdf#149418 the expectation is on success the tiff stream pos is at EOF
        
        which is what the old one did, so do that here as well, libtiff will
        leave the stream some other pos by default, presumably the directory.
        
        which explains the testTdf138818 mystery
        
        Change-Id: I574700f81a21ee164d9911e05e2023aa48d10370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135279
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-02  László Németh  <nemeth@numbertext.org>  [7a1d4b7d1db93ca1f541856a8d00d621d50e7bd6]

        tdf#149420 sw offapi xmloff: add hyphenation zone
        
        Add hyphenation zone support, i.e. allow the specified
        amount of extra space in lines instead of forcing hyphenation.
        It's for limiting hyphenation, used especially with
        not justified paragraph alignment.
        
        Note: this is an OOXML interoperability feature,
        used also in DTP software and CSS.
        
        * Add checkbox to Text Flow in paragraph dialog
        * Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationZone)
        * Add ODF import/export
        * Add ODF unit test
        * Add layout test
        
        Note: extend SvxHyphenZoneItem::GetPresentation() with
        missing No CAPS and No last word hyphenation options.
        
        Note: fix OSL_ENSURE condition in SwTextFormatInfo::GetHyphValues().
        
        Follow-up to commit 29359fc15c435cec17987fd6221ab6833d38746e
        "tdf#149324 sw offapi xmloff: add option to not hyphenate short words".
        
        Change-Id: Ib8eff6ea98a9aa5ca6cb9d17faa0bbb789687ce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135247
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-06-02  Noel Grandin  <noelgrandin@gmail.com>  [6585fe3fc154c518d657202295a2c5214de55b56]

        elide some unnecessary null checks
        
        getSvxBrushItemFromSourceSet never returns nullptr, and
        therefore neither does SwFormat::makeBackgroundBrushItem
        
        Change-Id: I618e45c5e336f93a7bde3172f4a349b9672d0ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [51572f6024da72fbed4d9d1936041962afb1cac7]

        Suppress false positive cid#1504594
        
        Change-Id: I9a4a20a2725a050b7e3d0aa38cb4568e7462926c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135287
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Miklos Vajna  <vmiklos@collabora.com>  [f23b0d206e80fe740a45611d719fbd3ec81bcf57]

        sw content controls, checkbox: add properties dialog
        
        - add a new m_xCheckboxFrame to SwContentControlDlg that contains all
          the checkbox-related widgets
        
        - hide this frame for non-checkbox content controls
        
        - load the checked & unchecked states into entries to show their current
          value
        
        - provide buttons to easily pick special characters using SvxCharacterMap
        
        Change-Id: I8f2ad862d1102bac0198360d40cfe8b653ce4ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135286
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-02  Noel Grandin  <noelgrandin@gmail.com>  [294fe615e1adcbf20d750599094323725aefc9b8]

        remove dead allocation in getSvxBrushItemFromSourceSet
        
        Change-Id: Iffd60c6cac753807f5f400d13a655400562ba076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-02  Miklos Vajna  <vmiklos@collabora.com>  [147da063241fce62f623bba61feead879be87beb]

        sw: document SwContentFrame
        
        I.e. the layout side of images is not a fly frame, but a no-text frame,
        with a fly frame parent.
        
        Change-Id: If76029d02ea2cd583effb31230f5e2d9edc9f237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135275
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-02  Stephan Bergmann  <sbergman@redhat.com>  [c387bc7dd1762f807128ecdbf79ec63884aa33b6]

        The elements of XInvocation::invoke aOutParamIndex are non-negative
        
        ..so use o3tl::make_unsigned when comparing them against an expression of
        unsigned integer type, instead of casting that expression to a signed type
        
        Change-Id: I4fc0bd4447f55d5fd9bf893a4b22d6d2c2cfe3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135280
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f3b5cb5a17a451c9e7d9b47b5e8854c5e126801f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6edfe34b94d0639b0184aee99b3fbff23217c7a6
          - Fix typos
            
            Change-Id: I2606fd452bce8cda26345efd301c4c572690ee52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135207
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [1c16e8075b42ff2017d2a1f0b297770a334b8a5e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36303145afbcf57edf4a45129bd5a8b222dfec74
          - Base form properties Sort dialog name is case sensitive
            
            Selecting Base form properties data Tab Sort dialog help button caused 'page not found'
            
            Change-Id: If91a478964304893527ac8c03d417dcee445a4ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134072
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-02  Eike Rathke  <erack@redhat.com>  [dad1d7182eda5f0e155964d32ac03e5cd854eb96]

        Resolves: tdf#149378 Force array input if outer function returns array/matrix
        
        So the result will actually display as full matrix, or in the cell
        range marked prior to input, instead of just the top left element
        in one cell, without having to close the input with
        Shift+Ctrl+Enter to force array mode. The previous behaviour can
        be forced by pre-selecting/marking one cell, which also worked
        previously when closing as array input.
        
        Change-Id: I81c079ce02e0c8d0536617ca6882fb470a352441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135278
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-02  Laurent BP  <laurent.balland-poirier@laposte.net>  [b760b2f743ff5a451ddf2be6fd69fe94423ae8dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6cad3f7596e2296adda304ab1c613a429bb6ae93
          - tdf#129674 New command Go to Sheet
            
            Add help to "Go to Sheet" dialog
            
            Change-Id: Iede0523d0272b32b9b87489129bca0136d601a65
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134951
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-06-01  Rene Engelhard  <rene@rene-engelhard.de>  [197a28ae5038d7faed9b075877b2377c981bc97a]

        fix build
        
        add #include <optional>, since:
        [build CXX] comphelper/source/property/ChainablePropertySetInfo.cxx
        /home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx: In member function 'virtual void comphelper::ChainablePropertySet::setPropertyValue(const rtl::OUString&, const com::sun::star::uno::Any&)':
        /home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx:54:10: error: 'optional' is not a member of 'std'
           54 |     std::optional< osl::Guard< comphelper::SolarMutex > > xMutexGuard;
              |          ^~~~~~~~
        /home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx:23:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
           22 | #include <comphelper/solarmutex.hxx>
          +++ |+#include <optional>
           23 |
        
        happens since 49b9401465730b1151917bffcbc0ad1f0622fcee
        
        Change-Id: I643e7811f1ec7588ccde5453303cd57675c6165e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135252
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ed78f1be7cf3f2338323a146a84de5e4b6db1a4]

        tdf#149417: vcl_filters_test: Add unittest
        
        Change-Id: I1c575027d53b93c5d08c7e4fdf6da9d34654bc4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135249
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c2f826b4a3183b739eae06a10b586f689864d61]

        tdf#90579: sc_uicalc: Add unittest
        
        Change-Id: I96b1b639c766664e14a50ab8a267eb490d7239a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135274
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [0af4324c57a2ee22afcba72c0244c56cb7df8d4b]

        Use more appropriate type for SbiImage::GetString nId param
        
        Change-Id: I4207830e3923ce9b4f7c0f59cf5880dfcf89979b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135243
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Caolán McNamara  <caolanm@redhat.com>  [da250c36d43ab96e985b263f41a199b151cd34df]

        Related: tdf#149408 inspector crash with a writer OLE inside calc
        
        also on *leaving* the OLE mode
        
        Change-Id: I97e9cd7cd4dc1803c4bc40865a08a194819c9ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135244
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-01  Eike Rathke  <erack@redhat.com>  [89f4737ab791a0432fe92f327906ac42bcb77a7c]

        Remove nonsense comment, function *is* used
        
        Change-Id: I514b38c0770deb85ca995aed1e8e454eb4f23e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135251
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-06-01  Michael Stahl  <michael.stahl@allotropia.de>  [f2dc0bedeb7e32e1c78bf218a7277110cdb71ce5]

        nss: remove nss-3.13.5-zlib-werror.patch
        
        The zlib module should be used instead of NSS' bundled zlib since
        commit 1c748fefc3c5b42e3548a1a7f5017a579982005a
        
        Change-Id: I0d820cdd795712a7dbe27ef114f0efddd3f436ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135235
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b252b6adb1613c6392cbb1462bae218d0d43032]

        clang-tidy modernize-pass-by-value in filter
        
        Change-Id: Id55c90665eaa29ee2ece07606429411549e06b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135242
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [dabd26614ddf73a2fb382e7a105c8c11c88741d9]

        pass ScRange around by value
        
        it's a very small object, and trivially movable. No need to allocate it
        separately
        
        Change-Id: I0adf947433e73a425f39004297c450a93ac4e5f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135216
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [49b9401465730b1151917bffcbc0ad1f0622fcee]

        no need to allocate guards on the heap
        
        Change-Id: I66491a057f082a970158504474b678dbb4decf50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135228
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [754eb1541a6ca709f78afbc7fb2b75f626562dcc]

        No need to call resume() on all already running thread
        
        (This was there ever since the beginning in
        85c2477a9479b08e49e651a8f6bede5b8b51613c "INTEGRATION: CWS bunoexttm", while for
        the similar OuterThread it was always absent.)
        
        Change-Id: I3c43f0e35435b6035f6a1f2a1ca9f104bd639689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135240
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [c2253f587b68f7277f30259160155f2bbf7adc78]

        Introduce weld::IconView::insert_separator
        
        Needed to eventual re-implementation of starmath's SmElementsControl
        using IconView.
        
        This required re-implementation of IconViewImpl, to layout entries
        by iteration, because now it's impossible to find an entry position
        just based on its index.
        
        This coincidentally fixed some visual glitches in non-gtk IconView
        implementation from commit 5813660e7bfe128ac076e592fe31de64a6863780
          Author Szymon Kłos <eszkadev@gmail.com>
          Date   Tue Feb 16 16:03:30 2016 +0100
            icon view for RemoteFilesDialog
        
        where any selected element could become first in row when scrolling.
        
        SvTreeListBox::SetEntryHeight taking a SvTreeListEntry const* had to
        be renamed to CalcEntryHeight, to avoid both virtual and non-virtual
        overloads, additionally having different accessibility.
        
        A TODO is implement separators in GtkInstanceIconView. I couldn't
        find a GTK API for separators in IconView, so possibly a workaround
        would be needed with some non-selectable narrow elements.
        
        Change-Id: Ie8dc35d94049a1c48e4eb49697681ffbe93c17f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135112
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [1dbf0f53e2e690a3914512785cad1a2f0f46e45d]

        Don't resize to parent window
        
        The parent may contain other controls (e.g. Fontworks dialog's grid
        contains also a label above the icon view). The control already has
        the correct size; just use it.
        
        Fixes vertical scrollbar being partially hidden behind control's
        bottom in non-GTK Fontworks dialog.
        
        Change-Id: I424999777f24bbb28619d07a9de782057f0257a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135003
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [a130f0f406e67cda098adc3086e937317f737583]

        Implement weld::IconView::[gs]et_item_width
        
        Change-Id: I211e3c21b4e0148c4ff6fc9931838e37ccd0cc41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134897
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [1c2d3b069859f466f59f35e50819fadc0ab61af7]

        Implement weld::IconView::connect_query_tooltip
        
        Change-Id: I8a8540e240d6a7046f564404c7c3b6bff8c2f04d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134806
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-01  Caolán McNamara  <caolanm@redhat.com>  [c90db9e43db509bef6892c8443480ffa9ed8bbe0]

        Resolves: tdf#149417 allow one short read in tiff import as not a failure
        
        Change-Id: I77bff41abd51cfd3050836fff04e9644b0828c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [3483df997170378dc44d4f025b960e489e0c7924]

        Avoid -Werror,-Wdeprecated-declarations when building Library_vclplug_qt6
        
        > vcl/qt6/../qt5/QtFontFace.cxx:132:19: error: 'QFontDatabase' is deprecated: Call the static functions instead [-Werror,-Wdeprecated-declarations]
        >     QFontDatabase aFDB;
        >                   ^
        > /usr/include/qt6/QtGui/qfontdatabase.h:113:5: note: 'QFontDatabase' has been explicitly marked deprecated here
        >     QT_DEPRECATED_VERSION_X_6_0("Call the static functions instead") explicit QFontDatabase() = default;
        >     ^
        > /usr/include/qt6/QtCore/qglobal.h:382:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
        > # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
        >                                            ^
        > /usr/include/qt6/QtCore/qglobal.h:294:33: note: expanded from macro 'QT_DEPRECATED_X'
        > #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
        >                                 ^
        > /usr/include/qt6/QtCore/qcompilerdetection.h:1146:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
        > #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
        >                                    ^
        
        etc.
        
        Change-Id: Icc6a5f2f78af9b287b71bdd347f396928a100b25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135225
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Caolán McNamara  <caolanm@redhat.com>  [fc5833b86016b0a940dd87d43dbe490ba1308dfe]

        Related: tdf#149408 various crashes seen in redline panel
        
        with this writer in calc ole case
        
        Change-Id: I1ecd7725703674cc1bcfc9b3d411ec890bfe4bcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-01  Caolán McNamara  <caolanm@redhat.com>  [1fe266c22fb7d277ae612cffd6cc89ef4dcb4269]

        Resolves: tdf#149408 inspector crash with a writer OLE inside calc
        
        toplevel isn't a SwDocShell at this point, its a ScDocShell
        
        Change-Id: I3aa3c72e494cf6c0ceff1286a7026ca01385ab8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135236
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [7d8d65d850cdd0bdaa84e9cff9f8c1654c61ddb4]

        The return value of XConnection::read is guaranteed to be non-negative
        
        ...so use o3tl::make_unsigned when comparing it against an expression of
        unsigned integer type, instead of casting that expression to a signed type
        
        Change-Id: Id2bea3010bf67bdaeb0766b20baecba195bf0181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135227
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Michael Stahl  <michael.stahl@allotropia.de>  [9b453e699ff53253ddc2562435dc2b91d883b1df]

        nss: upgrade to release 3.79
        
        Fixes CVE-2022-1097 and moz#1767590 "memory safety violations"
        
        Change-Id: I6895f066ad943402231b616dae0d7ed6f5678b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135234
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [7e1108f6ec9b959f9b4c0917a0fc18c1dd801ca2]

        Fix domain
        
        Change-Id: I0391fb3d4b913967ed4f8459d6b30f7f39bf4b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135055
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [c58a51e5f1972eb2f3220d3158801b0c7601f407]

        Fix comment
        
        For one, the functions are already available in C++20.  For another, our
        fallback implementation is only an approximation, as it doesn't enforce the
        requirement that the involved template types "are standard integer types or
        extended integer types" (but which is at least checked in --with-latest-c++
        builds against standard libraries that already provide those C++20 functions).
        
        Change-Id: I91208c185f2db681cf25899d3cd9a9e2912d32a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135232
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6c3e1ec7d2177271ea6e01da4cedce022823c622]

        update credits
        
        Change-Id: I159625c29c07188e991ad55de291594f31715f02

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [89b0d94850aeda0a97907945538e4d5f41bac970]

        sw: fix crash in SwDoc::CopyMasterHeader and SwDoc::CopyMasterFooter
        
        Similar to 3eda5d345f14f8926358df7b425c452a8a165c7d
        "tdf#149184 DOCX: fix crash removing footer, then saving to doc"
        check that GetHeaderFormat and GetFooterFormat are not nullptr
        Also restructure the code a bit to reduce the scope of pRight
        
        See https://crashreport.libreoffice.org/stats/signature/SwDoc::CopyMasterHeader(SwPageDesc%20const%20&,SwFormatHeader%20const%20&,SwPageDesc%20&,bool,bool)
        and
        https://crashreport.libreoffice.org/stats/signature/SwDoc::CopyMasterFooter(SwPageDesc%20const%20&,SwFormatFooter%20const%20&,SwPageDesc%20&,bool,bool)
        
        Change-Id: Ia30d06593124d90b88f7d26ed7be9a5d7a64872c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135230
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [fea45cc200f2e30c0af7f1a81a2a6bfa38f6293c]

        clang-tidy modernize-pass-by-value in uui
        
        Change-Id: I55f55554e325ae67a7b9fa36ee12b14804fe446b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [292887379812dd9df00c3f129e21d17dd56519a9]

        clang-tidy modernize-pass-by-value in fpicker
        
        Change-Id: I9940338307241958e478ec6919068454d3a07b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [acb65a60be43d5ac146c2fc16c6f2a5f6879be99]

        Use more appropriate index variable types
        
        Change-Id: Ic2cf5512cabcda0ad476c43bcbc544d0d6dd2685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135231
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [aeeb0141aca4f1698b09bc8f06ded41247b54279]

        sw: avoid another EXCEPTION_INT_DIVIDE_BY_ZERO
        
        See https://crashreport.libreoffice.org/stats/signature/lcl_ModifyBoxes
        
        Change-Id: I786bbf87734dd3963bd84caecc5c5f45693d42c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135185
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea4cd397300120a0f825752182eb3b943eb8a1b2]

        sw: avoid EXCEPTION_INT_DIVIDE_BY_ZERO
        
        See https://crashreport.libreoffice.org/stats/signature/SwFormatCol::Calc(unsigned%20short,unsigned%20short)
        
        Change-Id: I79321737b7bed3acff3418d0b51dc6225baaf57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135184
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-01  Miklos Vajna  <vmiklos@collabora.com>  [2de53e222fa9126422ff69dde3c585349958d494]

        CppunitTest_sw_tiledrendering: use CPPUNIT_TEST_FIXTURE()
        
        Which changes the order of the tests in the suite, so testRedlineColors
        runs later and the global list of redline authors now contains
        unexpected entries, leading to an assertion failure.
        
        Fix this by clearing the redline author list at the start of each test.
        
        Change-Id: Ifffe079eb83cd3184c962ea2e69505bd518a52bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135229
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [af1147f4a6fd18a44dcd9209abe5d91bb74840c5]

        Use less noisy way to iterate over some (unscoped) enumeration
        
        Change-Id: I37ed9b3dd607367d2e42fcc163c423dc416cc7c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135224
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5ea5151467b2fb3d9487a178ef6d47436d4154d6]

        tdf#149010 add and improve tooltips to "Previous Link" and "Next Link"
        
        Change-Id: I357eb0dd45c0008ad56a541ad40b1bf3b0f77953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135071
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [e89e3a8b5a7639f14833d066e8a6c445dca97cc0]

        The return value of those getLength functions is guaranteed to be non-negative
        
        ...so use o3tl::make_unsigned when comparing it against an expression of
        unsigned integer type, instead of casting that expression to a signed type
        
        Change-Id: Ic47c6d96919b2aba2d16ce6d1a2a8e4c5761a480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Stephan Bergmann  <sbergman@redhat.com>  [6dbccf3d9344be0c2ba162a8df5fc0bf425cb84e]

        Clean up some loop a bit
        
        Change-Id: I96b760b7bd220b799f4843c5d5e07385a9a995d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135215
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-06-01  Miklos Vajna  <vmiklos@collabora.com>  [9cb1a07dc2760a30d7f321aa7fa4ce2a460dfa6c]

        sw content controls, date: add LOK API
        
        - send a LOK_CALLBACK_CONTENT_CONTROL with date=true when entering a
          date content control
        
        - extend lok::Document::sendContentControlEvent() to be able to set the
          date of a date content control (after the client's date picker is
          closed)
        
        - update gtktiledviewer to work with these
        
        Change-Id: I0abf21eb1d4ba233050f0aa2607b68740c048262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135214
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [64f8a70298695d1952c3a399e897755ab861add5]

        sw: fix crash in SwAnchoredObject::UpdateObjInSortedList
        
        See https://crashreport.libreoffice.org/stats/signature/SwAnchoredObject::UpdateObjInSortedList()
        
        Just a few lines above (line 636) the same checks are used inside
        the DocumentSettingId::CONSIDER_WRAP_ON_OBJECT_POSITION condition
        so I don't understand why they weren't added here as well
        Change-Id: Id8ade0a506d5996d9e357d45c20fe56a68a93eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135188
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-06-01  Miklos Vajna  <vmiklos@collabora.com>  [de6cd24c4c6de0b05a486b138bf46a1c91f17d50]

        CppunitTest_sw_ooxmlexport13: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ifd4a73bc9f8272ff3f6abdb8d983f9617eb1a959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135201
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-06-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f2d2334b032780d97f7a95aacb8283008e91c529]

        tdf#121367 (related: tdf#120550) consistent labeling between modules
        
          There is a slight difference in the label used by Writer 
          and the label used by Draw/Impress to refer to:  
          .uno:SetMinimalRowHeight and  uno:SetMinimalColumnWidth.
          This patch changes the label in Writer so that it uses the
          same label as Draw/Impress.
        
        Change-Id: I0469b32350bf9a57903b03929675d3b7e8abe287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135005
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2022-06-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [5423dfb8549743bd5045b6e3b1ebad7980e62965]

        tdf#148736 improve labels for Arrow style popup dialogs
        
        Change-Id: Ifc43650a3008cbd96cac8f994675e680368a215b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133287
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-06-01  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c2670f45252aa3642ea4fbb70a48e03e284eb60c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b30109758ad6b6bcb8b82d6a646fc055cd3a2402
          - refactor some embedvars that give a translation problem for some
            
            Change-Id: Ibb67c7dd61fe55892232bebc2280fb3faed0db37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135168
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [cd2ea94969b9c63b24e35e9b8e546cea0f62340e]

        Qt just resize the backing store on size change
        
        ... and if there is no need to create a Cairo surface if it
        doesn't exists, there is no need for a fresh QImage either.
        
        Change-Id: If607e03d246f3c31d66953b1e07a7af55659e64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135209
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-06-01  Eike Rathke  <erack@redhat.com>  [c30306ad19f7ba022628f4f88ba5b92b8a1af402]

        MoveCursorAbs: it is cheaper to check for marks first and then formula mode
        
        ... so repeated travelling with cell cursor will be less affected.
        
        Change-Id: I3f42356e66b2ec8acf60c0e0c777f8c34b9a952a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135211
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [483f3125ecd4744cbcc2f8fd3cdf243d81a601ff]

        WIN drop effectively empty ImplDrawMenuBar
        
        .. as VisibleMenuBar() just always returns false.
        
        Change-Id: Ie793d84d57970cbf08b81b6ec0350b9b5fd4192c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135210
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [bd279d30025e13125e9c5736f7baa9b00484156d]

        Use more appropriate index variable type
        
        Change-Id: I0a6de93876d316a1aa094cf98dc2ee5c7eddebbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135205
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [d1cdf9a24de0d87f22e283f5cb2ed93ff6e83ee6]

        Also assert that nNodeType is non-negative
        
        ...given that nNodeType aka AnimationNode::mnNodeType is later used as an index
        into the AnimationNode::mpTypes array
        
        Change-Id: Ic208fbdfaa8dcca44ff2a99cf3b169904b14a4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135203
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Eike Rathke  <erack@redhat.com>  [93a3f142bf46eb7b4309cd168354fe2a971e196d]

        MoveCursorAbs: do not reset selection marks while editing a formula
        
        i.e. when moving the cursor for reference selection, so an
        existing mark is preserved for Alt+Enter or Shift+Ctrl+Enter.
        
        Change-Id: I3a73145b4e3e299fa9eb28e2198338e76ffe5093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135202
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-31  Szymon Kłos  <eszkadev@gmail.com>  [09847cdbd435c1f6ac8c0ac0256f8be488edd194]

        jsdialog: introduce popup management
        
        Popup windows are managed by vcl (some moving between parents
        happens on show/hide popup).
        
        We need to access correct popup window to correctly close
        popup in LOK. So remember popup instances.
        
        Change-Id: I9e1ba18ded5a1bf675f95bd7178043eebd9bbd5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134576
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135197
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [b19a2dfafa366f5fea1b70a1bae2d39a76a54a8e]

        Use more appropriate type for SbiImage::nStringIdx
        
        Change-Id: I1448739b373c6f7b9f5e6ee5a725fa0a129a4fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [4c60697daaecc8be0a00e900ba1b4b62713e43df]

        The return value of std::count_if is guaranteed to be non-negative
        
        ...so use o3tl::make_unsigned when comparing it against an expression of
        unsigned integer type, instead of casting that expression to a signed type
        
        Change-Id: I487fd04eafbf8c56b8b6bfce579b477d8f34a052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135206
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Noel Grandin  <noelgrandin@gmail.com>  [a77b8b75f015fba74e2553c3cff58fcba298b9ed]

        elide temporary vector in TextDecoratedPortionPrimitive2D
        
        Change-Id: Ie3945d3a2e133d3ce527844f9c0d61a6541175e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [e1bac51546138aa5b138f73fd61430cb8582b9c6]

        clang-cl wants VCL_DLLPUBLIC SalLayoutGlyphsCache::clear not to be inline
        
        ...to avoid
        
        > [build DEP] LNK:CppunitTest/test_vcl_text.dll.d
        > complextext.o : error LNK2019: unresolved external symbol "public: unsigned __int64 __cdecl SalLayoutGlyphsCache::GlyphsCost::operator()(class SalLayoutGlyphs const &)const " (??RGlyphsCost@SalLayoutGlyphsCache@@QEBA_KAEBVSalLayoutGlyphs@@@Z) referenced in function "private: void __cdecl o3tl::lru_map<struct SalLayoutGlyphsCache::CachedGlyphsKey,class SalLayoutGlyphs,struct SalLayoutGlyphsCache::CachedGlyphsHash,struct std::equal_to<struct SalLayoutGlyphsCache::CachedGlyphsKey>,struct SalLayoutGlyphsCache::GlyphsCost>::removeSize(class SalLayoutGlyphs const &)" (?removeSize@?$lru_map@UCachedGlyphsKey@SalLayoutGlyphsCache@@VSalLayoutGlyphs@@UCachedGlyphsHash@2@U?$equal_to@UCachedGlyphsKey@SalLayoutGlyphsCache@@@std@@UGlyphsCost@2@@o3tl@@AEAAXAEBVSalLayoutGlyphs@@@Z)
        
        (Not sure why MSVC itself doesn't complain; maybe LLVM 15 trunk clang-cl
        accidentally diverges from the MSVC semantics here.)
        
        Change-Id: I910fc309f9e02ec0794e449b97ba111d33dcbb54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135199
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Szymon Kłos  <szymon.klos@collabora.com>  [81df11b1e5af610133874d9258999995a07364bc]

        lok: don't render active textbox on all slides
        
        when we render tiles for slide previews we use
        viewid = 0 (first session)
        
        so when first session edits any textbox and in other
        session we request slide previews (eg. after new slide was added)
        then we received tile with additional text from the first session
        
        this is caused by:
            commit bee4ff508a456a1552aacdf6fc838b8b7cffb9ec
            desktop lok: avoid unnecessary setPart() in paintPartTile()
        
            If possible, switch views, not parts, that way started Impress text
            edits don't end as a side-effect.
        
        but later there was a fix which doesn't trigger closing of texbox
        editing when switching parts:
        
            commit ce7bf351972bbfd64ca99e8d2fb4c5f77591c9e0
            impress: don't exit textbox editing when new slide was added
        
        so we don't need that in all cases...
        to fix issue described above: still switch views instead of parts
        when possible - but avoid views where editing is active
        
        Change-Id: Ib6e66a85b9ca68d6e67e3d9cb17060aa42b85220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133202
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133650
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135196
        Tested-by: Jenkins

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [3a06db0af05294e0b5db6f07daf35bec7371d4cc]

        Use a range-based for loop
        
        Change-Id: Id3c358e0a7f11a4a203b1acbd42b9b09c7f7a2fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135193
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [66500b5041135dbca62f10c8b20ce000a2ae43ff]

        Use some range-based for loops
        
        Change-Id: I4935bf51c6c7e9be1e3f069c6c72e618eaa0b4a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135189
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [52da30cd18990c47b5cea0e789f3d1f76c2a9e1b]

        Drop unnecessary cast to int
        
        ...when iterating over the enumerators of enum Image_XML_Entry
        
        Change-Id: Ic59da7543a41f8b498d6f89e48faafcdf40c6873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [5dd2ef5c783d9079bc70e7b07aea0178a31f4fc2]

        Use a range-based for loop
        
        Change-Id: I52bfe8ec1e7ca55964f2ed3aadcc709dba3662c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135192
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [6573ade5cf0cd63ff283446822e3bc87cd8a749b]

        Use some range-based for loops
        
        Change-Id: I26ad6ff194742b69cb6048c48fa01de7715865ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135191
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [12348430e0139b4f2e72984e8a1619baca842df6]

        Use a range-based for loop
        
        Change-Id: I50742cd64c63d6c81599ebda3ff2c093e722c91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135190
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [259a1ebd879f1cfe7e9db9af97d3842fcd51f640]

        Rework UUIInteractionHelper construction
        
        ...to remove the need to construct a fresh m_pImpl in
        UUIInteractionHandler::initialize
        
        Change-Id: Ia3f1b89903448f74242a5fec3dcf87c2b1f5e764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135187
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [391cb44d415e2126f668ecf62387d5e98ffa6f5c]

        Advanced Diagram support: UI visualization & simple interactions
        
        Added visualization to show an imminently recognizable additional
        visualization for DynamicDiagrams that can also be used to
        show/hide the DiagramDialog by the user. It is also used as
        additional drag/move handle for the object.
        
        Change-Id: I56292cebe7c7a6f79be920c17edafdd7e453b6eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135183
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [c593567b68d353ca13206e7ee62c4a0f8348d987]

        UUIInteractionRequestStringResolver::m_pImpl can be a plain data member
        
        Change-Id: I1daed58cec87d192118f027ce1843e56b17da19b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135186
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Luboš Luňák  <l.lunak@collabora.com>  [e4842a4c520c68813f0567d34ad321de11c4f1c3]

        lok: add more efficient getSelectionType() replacement
        
        The getSelectionType() function usually needs to be followed by a call
        to getTextSelection(), which means having them as two functions
        leads to duplicating to a number of calls, some of which may be
        somewhat expensive (pDoc->getSelection() e.g. for Calc builds
        another ScDocument for the selection, and then getFromTransferrable()
        converts that to the given format).
        
        Change-Id: Ib0a8844701d80eaaff4834dcd3633c09d6b921b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134603
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-31  Caolán McNamara  <caolanm@redhat.com>  [f90239263fcabec30f04098e17dc1be9f9a928d1]

        tdf#117006 gtk: detect High Contrast
        
        similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1606038
        
        .e.g. gnome a11y menu, pick "High Contrast"
        
        Change-Id: I60643b3a37b722230d5ed47082e4a6491d005ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-31  Michael Stahl  <michael.stahl@allotropia.de>  [225d8f31ad5fdcb802fbaa4ccb5266c80a3dd037]

        curl: remove curl-7.26.0_win-proxy.patch
        
        There is no justification why this patch was added, upstream doesn't
        want to add such a feature[1], and maintaining feature patches in LO
        for bundled externals doesn't make sense.
        
        Also, this doesn't respect the Inet::Settings::ooInetHTTPProxy*
        settings from the configuration.
        
        Let's remove it and hope nobody complains.
        
        [1] https://curl.se/mail/lib-2022-05/0083.html
        
        Change-Id: I1ccdefb76f69e6795a28d4d25bf443555c16ab0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135182
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5ca8b5bffc44443b08f74817a3dee2c314b7ced]

        crashreportScraper: use timeout in requests
        
        Change-Id: I03f8740fc124c11d250368034bf6e14239df5abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135180
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ecdedbf81af5516ff7d2195383dc9d6389fb0d0]

        clang-tidy modernize-pass-by-value in basic
        
        Change-Id: I9034ab95a4ccb58e36e77d911dd33cc50857c03a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135176
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [af44198d80edce92bdbb82dfd6f218eeb6163484]

        these can be stack allocated
        
        Change-Id: Idd2e5e49ba4fcef2e80fd9c569f374a6a69f380e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [6f26b6aeca827329dd8d55f344e509fcf7685172]

        Use more appropriate type for comphelper::internal::OPropertyAccessor::nPos
        
        Change-Id: Ia7055dcc3832002fd10ae23a35fd08df5a98ae40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135177
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Stephan Bergmann  <sbergman@redhat.com>  [2a263cbdaf16c723a93af020ebc11b3e07210242]

        tdf#145527 Revert "Related tdf#116767: Call URLClassLoader.close"
        
        This reverts commit 418533f0af7cd303d559c8fb136c49e7e9fb0d79.  Turned out that
        closing the given URLClassLoader once the script's main class has been loaded
        prevents the script from loading further classes located next to that main
        class.  So abandon the Coverity suggestion that such class loaders should be
        closed promptly to avoid resource leaks.
        
        Change-Id: I1bcf83117836cfe317eac9850d413f2c3767bd8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135158
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-31  Miklos Vajna  <vmiklos@collabora.com>  [5f335154459e044b6035f099a3e08c98fe258d2b]

        sw content controls, date: add insert UI
        
        - handle the date case in SwWrtShell::InsertContentControl()
        
        - expose this as a new .uno:InsertDateContentControl command
        
        - add the new uno command to the default & MS-compatible menus
        
        - hide the old .uno:DatePickerFormField from the menus that has the
          problems described in the sw::mark::DateFieldmark documentation.
        
        Change-Id: If3c1050d6a8302be0da4a11067a67805396dec48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135153
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2ad445acad66f23fe5452746835c539eaaf949b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bbaecd77c87afee5453dc89a9e033d4048c909e
          - tdf#107078 New way to load color palette
            
            As color, hatching and gradient palettes are now handled by
            extensions, this patch include:
            - Refactor of xhp tags
            - move palette_file from simpress/ to shared/
            - adjust tree files
            - add entry to shared/guide tree
            
            Change-Id: Ied501dd86431d26d09ed91249c22f422620b16d6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135096
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-31  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [445d4ce232b8e8efaeb2605533fede1b71f52f30]

        tdf#147991 PPTX export: fix bullet indent regression
        
        Instead of exporting the inherited master slide indent
        values of the placeholders, export 0 indent value for
        removed/disabled bullets to fix interoperability.
        
        Regression from commit f57cfddb51b7d7409b7b425dc200aa73406a13bd
        "tdf#145162 PPTX export: fix extra bullet regression".
        
        Change-Id: Icbf823adc07f19fd10d1a60da9cff17616a2aef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135025
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b94275f6d2cb4dc28d1563fd7994251042b6d51a]

        tdf#149157 - Break multiline continuation in a comment after a new line
        
        Change-Id: I3dd875152a6f2cfafb67f13f597c36f01a4759b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135018
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-05-31  Martin Srebotnjak  <miles@filmsi.net>  [7d25b8544b1534e8a413422ba0bf91d1b2af85a5]

        Update git submodules
        
        * Update translations from branch 'master'
          to ed14d57f503d87230572addc845e16da818e530a
          - Updated Slovenian translation
            
            Change-Id: I80fee32feef0bc879ab0d0ff1b420074e9ea47d1
            
2022-05-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [bf6c74f1bb4ba67c16d442a9d8847118891ec89e]

        crashreportScraper: Add new column to show the stack code
        
        Change-Id: Id6f9ed8540a8615a80de9cc561579ce069992e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135142
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-31  Michael Stahl  <michael.stahl@allotropia.de>  [aa8ef74b475a6fbd6e4ec27c42941aa274998df6]

        g: we are not, in fact, in the BUILDDIR
        
        For an out-of-tree build, "make fetch" poinlessly clones all git
        submodules.
        
        Change-Id: If4afb218946f49ba934f68b35806fd8143c39387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135143
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-31  Thorsten Behrens  <thb@documentfoundation.org>  [49f62ab95eeffd0ed4d19eca4c9abffa6e2cf84f]

        Revert 6eeb0942c35f07dfbadb13f35fc6aa3703dac945
        
        Change-Id: I096f25d38f19fb728110e209a189f89a8e8d402f

2022-05-31  Miklos Vajna  <vmiklos@collabora.com>  [b0386e4d029d90f91fcae72ec76c77f9b15c1478]

        CppunitTest_sd_tiledrendering: reduce test doc size in testTdf104405
        
        The actual image content is not interesting, so it can be a tiny one.
        
        Change-Id: I74e404f53b9674b44963313b096ddd8e1c40e146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135141
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-31  Andras Timar  <andras.timar@collabora.com>  [090ed6199ec8ed805d645b62387bc89df01b9564]

        date picker should rather show the current date instead of February 14, 2019
        
        Change-Id: Ie449873aad40b6f02198a8a44a7eae1aaba1cfae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135148
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-05-31  Seth Chaiklin  <sdc.blanco@youmail.dk>  [caf924d1d96a7a27356f6e04a192e666d552141e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d8c6f2f81847b48e2c24b5ee1b0af8a7a5c0b5d
          - followup to 580f62a41db6366a3ab13bf16a96a643710605a3
            
               add a sentence -- mentioned in tdf#149253, comment 3
               -- but not included in
               580f62a41db6366a3ab13bf16a96a643710605a3 as intended.
            
            Change-Id: I8ff660372a8bfc62aff2082ed870c5d795d69d90
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135156
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-05-31  Seth Chaiklin  <sdc.blanco@youmail.dk>  [95b673946c0661391ad66eeae287f0922d96c6f8]

        tdf#149253 improve tooltip for Anchor icon
        
             * Tooltip explains the purpose of the command icon
             * Change "Label" to give better indication of the command
                function in Customize menu
             o no changes to label in menu and context menu
        
        Change-Id: Ibffb673d5c37ebf7b38a1eea61affc22bdd3bf91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134791
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-31  Eike Rathke  <erack@redhat.com>  [dfd5081ff3973d5d0f216b06dda6360fa490cc9c]

        InsertMatrixFormula: correct references for across sheets array formulas
        
        Inserting an array/matrix formula across two or more
        selected/marked sheets generated wrong matrix offset references
        starting with the second sheet, pointing to the top left of the
        first array formula. Only the top left cell of the inserted
        formula on each sheet displayed the correct value. Deleting the
        array formula on the first sheet then left all matrix offset
        references on the remaining sheets with #REF! errors and those
        cells could not be deleted anymore because their original parent
        cell was gone.
        
        Change-Id: If5d53311f9aabdcd7432ff26ab555bb91b0b121d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135147
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [72c42be077908901e8a967d3a543296ca92ce51f]

        Use o3tl::make_unsigned, nCount is already asserted non-negative here
        
        Change-Id: I7213e9f2e3a5a4a785d44932900496a791b1964a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135146
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [26143512e590892e2371253f48216c8867229b5e]

        Use more appropriate index variable type
        
        Change-Id: Ieb3ed7931361e38ce62cd4dfa98b9712e4181d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135145
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [a9eed29a7ce85558fff6048a9cfe9bd437e63ce8]

        Fix linking Library_evoab
        
        > ld.lld: error: undefined symbol: LanguageTag::~LanguageTag()
        > >>> referenced by NResultSet.cxx:82 (connectivity/source/drivers/evoab2/NResultSet.cxx:82)
        > >>>               /home/sbergman/lo3/core/workdir/CxxObject/connectivity/source/drivers/evoab2/NResultSet.o:(connectivity::evoab::ComparisonData::ComparisonData(std::__1::vector<connectivity::evoab::FieldSort, std::__1::allocator<connectivity::evoab::FieldSort>> const&))
        > >>> referenced by NResultSet.cxx:82 (connectivity/source/drivers/evoab2/NResultSet.cxx:82)
        > >>>               /home/sbergman/lo3/core/workdir/CxxObject/connectivity/source/drivers/evoab2/NResultSet.o:(connectivity::evoab::ComparisonData::ComparisonData(std::__1::vector<connectivity::evoab::FieldSort, std::__1::allocator<connectivity::evoab::FieldSort>> const&))
        
        after 7b87afa899be289306c709d35eb1d32c0b73b1ed "clang-tidy
        modernize-pass-by-value in unotools" changed
        
        > --- a/include/unotools/intlwrapper.hxx
        > +++ b/include/unotools/intlwrapper.hxx
        > @@ -61,7 +61,7 @@ private:
        >      void                ImplNewCollator( bool bCaseSensitive ) const;
        >
        >  public:
        > -    IntlWrapper(const LanguageTag& rLanguageTag);
        > +    IntlWrapper(LanguageTag aLanguageTag);
        >      ~IntlWrapper();
        >
        >      const LocaleDataWrapper*    getLocaleData() const
        
        Change-Id: I29371b27c260c822c427dab70bcb29943e34dfc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-30  Luboš Luňák  <l.lunak@collabora.com>  [970ff17f47731be788ec34c0c8ddf3fb2c24ceac]

        fix setting cell borders for unallocated cells
        
        First of all, it should not be clamped to allocated columns. Second,
        06d3294502413a231e5c5265609862c7f67a2f2b incorrectly handled
        unallocated columns by setting the attribute for all rows, instead
        of handling the inner ones differently.
        
        Change-Id: I3115b314971f8c152cbdeda674863a8a78ee12eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135131
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-30  Luboš Luňák  <l.lunak@collabora.com>  [3e738f53a69e474f22b4d6599ce16e5fe3d691df]

        first arg of ApplyFrame is never null
        
        e4008dc0c3b43c9eacdd88511075be2b88 did this for ApplyBlockFrame()
        but didn't chagne ApplyFrame() which is only called from there.
        
        Change-Id: I9f1dce3dc7fda23b42e90432c13dfca0aa7f267e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135130
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab1cc47d5f0bdc238c86bec5725055efb8aa5d8f]

        tdf#145178: sw: Add UItest
        
        Change-Id: I5dbc302216b0d8b94ad29a336495856ce8cfc4b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135139
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [80c5e962fd22a6d1ddcc460ba60b0b775b303f0e]

        -Werror=maybe-uninitialized
        
        > sw/source/core/text/guess.cxx: In member function ‘bool SwTextGuess::Guess(const SwTextPortion&, SwTextFormatInfo&, sal_uInt16)’:
        > sw/source/core/text/guess.cxx:220:37: error: ‘bHyphenationNoLastWord’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   220 |         if ( bHyphenationNoLastWord && sal_Int32(m_nCutPos) > nLastWord )
        >       |              ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > sw/source/core/text/guess.cxx:201:14: note: ‘bHyphenationNoLastWord’ was declared here
        >   201 |         bool bHyphenationNoLastWord;
        >       |              ^~~~~~~~~~~~~~~~~~~~~~
        
        since 8c018910ae4d8701b1ce2a95727b9baed4016da3 "tdf#149248 sw offapi xmloff: add
        option to not hyphenate last word"
        
        Change-Id: Id3be25bf9f5d6769555bfe461a0f4e1e27e0e39e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135137
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [be86e93d9b880bf63555f8ee4d11690aa6d130b2]

        these ScTokenArray can be stack allocated
        
        Change-Id: I53d370bf6bc5133b7279e569516fc5a0a5ede1b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135135
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [a57209bf4b7aa442757c57b542512fb7ecc9b23d]

        no need to use unique_ptr for tokens in ScChartListener
        
        since vector is a moveable type, and we always initialise this field
        
        Change-Id: Icd598ad942dcfbdf77c7c8eef9fa0b6b7c6fe1be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [353dbd9afe8a373d8b2c7e3982b5110d224b2d9f]

        no need to allocate LocaleDataWrapper separately
        
        Change-Id: Icceaf255a3a71d612b17dad41d04b1906550a7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e32150731f0ec5176731686d77e2873023e9dd4]

        these can be stack allocated
        
        Change-Id: Ief9a0732d50af95d679d1d6b66dec9d2e2d141df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135132
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b87afa899be289306c709d35eb1d32c0b73b1ed]

        clang-tidy modernize-pass-by-value in unotools
        
        Change-Id: Ifa67ab7198f5d3b06171869f57703acdaa959f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Caolán McNamara  <caolanm@redhat.com>  [f3df14cc4343ce65608436acfa67b2ccfb68115d]

        ofz#47664 OOM
        
        Change-Id: If0d1ea55a194961fdb05ed2023bcfdaa6f933bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-30  Caolán McNamara  <caolanm@redhat.com>  [9104861a41e0edd07e4d74da47acb4e9d92b1ddd]

        tdf#147708 create floating menubutton on demand
        
        and destroy when it is fully faded out. Otherwise windows runs out of
        gdi handles with document with large number of page breaks
        
        todo: rename some things in a follow up commit after this more easily
        backportable commit is merged
        
        Change-Id: Ibbe3cd00d1027ac34915c4bff73e3a330e300f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-30  Miklos Vajna  <vmiklos@collabora.com>  [99eab75edd636fbb3e01e9a59e84b7729d999738]

        offapi: fix util::XCacheInfo header/footer
        
        Addresses
        <https://gerrit.libreoffice.org/c/core/+/135114/2#message-6f69c01338150fe3114c2699b417fc7223154cd2>.
        
        Change-Id: I36d48288be1456f06813befbb24e896767957eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135126
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b902cfa55e4ca77d6ee63dc8ec8c8e45cd39bb0]

        clang-tidy modernize-pass-by-value in sot
        
        Change-Id: I1ff31ae1291a82630ae32185077e369bbdfd3a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135127
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c921f24c761247639bb5ce344d6738568861564]

        use more SfxWhichIter::GetItemState
        
        Change-Id: Iae284fcad199684920aef0bd91ff39c407b48e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Caolán McNamara  <caolanm@redhat.com>  [a6856795267509aaf0b4f59a9fb3a626411d1cb6]

        cid#1504574 Resource leak
        
        make an owner for the PropertyMapEntries
        
        Change-Id: Ie915a8a312f2b24488566814ad67fdeef89b5941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135123
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5b676a480a68f2ad7ceb107147a2ab3363b4d22d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76f954f62ccd344d1760970d13a84645ceb6dd5e
          - tdf#91344 help for Writer "View" menu is not updated
            
            Writer View menu Help page was already updated modulo
            one minor correction in an embedded file.
            
            Change-Id: I7eac912669a30b9d675a51b966dcf6497269f502
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135092
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3676fb9d7b505d9f8079008b41e423b54663a86a]

        these can be stack allocated
        
        Change-Id: I7be63816fcdc3572d751fdd9ceab5931d0559ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [f218429d0a40d67319e89c63e3d4dceeb88c2220]

        CppunitTest_sd_filter_eppt also needs the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", to avoid
        
        > Test name: (anonymous namespace)::testThemeExport::TestBody
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 32512
        > - failed to execute: sh .../bin/officeotron.sh .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epm.tmp > .../tmp/_anonymous_namespace___testThemeExport__TestBody_w8epo.tmp 2>&1
        > java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init
        
        Change-Id: Id6f49c08a8bcd0ad9b5600de147624d5cfc6019b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135122
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-30  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [e1f6b136fd125c5d3648c51b202a698d418afc18]

        tdf#146272 sw: fix fly in fly hid by incomplete z-ordering
        
        Fixing z-order was incomplete for textboxes
        (shape + frame pair), because only the frame
        moved to back, but not the shape, covering the
        textbox.
        
        Regression from commit 504d78acb866495fd954fcd6db22ea68f174a5ab
        "tdf#143574 sw: textboxes in group shapes - part 1".
        
        See also commit 0e6d963fbca16f98a3dbb6ef2fee3736a89d055b
        "tdf#138141 sw: fix textbox z-order".
        
        Change-Id: I03e3b55302c984e5968e579e77ccd5ed0a336dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134942
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-30  Stephan Bergmann  <sbergman@redhat.com>  [bbcf26337cd2933205248909c55d5c1d161e9b9b]

        Avoid uninitialized temp_file_handle
        
        ...in case osl_create_temp_file_impl_ doesn't assign to it, for whatever
        osl_error reason, which then apparently leads to
        <https://crashreport.libreoffice.org/stats/crash_details/e47a9fbb-a6f1-4020-ade8-ab51549b727a>
        SIGSEGV at (relative to libreoffice-7-1)
        
        > 0  libuno_sal.so.3  osl_closeFile                               sal/osl/unx/file.cxx:1154
        > 1  libuno_sal.so.3  osl_createTempFile                          sal/osl/unx/tempfile.cxx:330
        > 2  libmergedlo.so   PackedFile::flush                           include/osl/file.hxx:310
        > 3  libmergedlo.so   comphelper::BackupFileHelper::tryPush_file  comphelper/source/misc/backupfilehelper.cxx:2090
        [...]
        
        Change-Id: I2e81bbeab7daaaa3c19de4accce8a76ad24faa47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135111
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-30  Tibor Nagy  <nagy.tibor2@nisz.hu>  [c3f73f75772d076dfb2ed0538e7d515503edc038]

        tdf#149128 PPTX export: fix <stCxn> and <endCxn> connector properties
        
        to avoid of detaching connections between shapes,
        when these connections were created in Impress.
        
        Change-Id: I1bc90bb8a408546b303b70bcfb27d3549d5e72d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134940
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-30  Roman Kuznetsov  <antilibreoffice@gmail.com>  [81aad6d53fa792dd95732e401ecb298714f699f4]

        tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro
        
        Change-Id: Id91ca2d7002b3743ecaed7b40edda3f85e080884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135061
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-05-30  Roman Kuznetsov  <antilibreoffice@gmail.com>  [d694b572c7262a326ac7ceac2e558f3fc6c78df4]

        tdf#147021 Use std::size() instead SAL_N_ELEMENTS macro
        
        Change-Id: I86956ab4beaba6b2b0905123ccea76c8ffad57fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135063
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-05-30  Miklos Vajna  <vmiklos@collabora.com>  [b3f2ae52e381f7d5fa466dc9df7d04d3d13ca4b9]

        framework: fix crash on Writer startup when using --enable-ext-wiki-publisher
        
        As reported by Julien, once the mediawiki extension is installed, the
        xHandler in framework::DispatchProvider::implts_searchProtocolHandler()
        points to an UNO component implemented in Java, and we crash in
        dynamic_cast<>(), at least on Linux with gcc 7.5 and libstdc++.
        
        This dynamic_cast<>() call was added in commit
        c0fa456436947a5c167c652d19a884064b43c03d (tdf#149261 sdext: fix crash on
        starting the presenter console for the 2nd time, 2022-05-26), to allow
        the presenter console to opt out from protocol handler caching. It was
        expected that the proxy object created for a Java UNO component would
        simply return nullptr when we try to dynamic_cast<>() it down to a C++
        interface.
        
        Fix the problem by moving the interface to an UNO one: this side-steps
        the dynamic_cast<>() crash at the price of introducing an UNO interface,
        which is not meant to be part of the public UNO API (but at least it's
        not published).
        
        It may still make sense to improve the bridges/ code at some stage to
        not crash in dynamic_cast<>() on generated Java proxy objects.
        
        Change-Id: Iaac44515339e0dc15dddc3be45ef7dee7331e47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135114
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-05-30  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e4e03e79fac598a9fafb0da8ab50da9a67c6978e]

        tdf#149200: docx export: transparent color fix
        
        If there is no color value we should not also try to write
        transparency information: otherwise w:srgbClr will have no
        parameter value and MS Word won't open such documents.
        
        Change-Id: Id67f174c5ae9aadf90ae54c126aef9a43ff3ba17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134945
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [d471bfb1125d87f86bca3b4b4cfaf2f44728d438]

        fix another domain
        
        Change-Id: I3a0c5aab62a7b6723df5820abb3f56e3f110d8b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135113
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-30  Caolán McNamara  <caolanm@redhat.com>  [2896c5dad1799addd72b626d93d7e89b1cf19ff6]

        Related: tdf#89131 draw up/down spins disabled if value is at max/min
        
        if there is a max/min set.
        
        Change-Id: I2dc7ccccad9ec2aa7eb89d8b5fa137e077a846fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135105
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-30  Noel Grandin  <noelgrandin@gmail.com>  [4fc1f038a687e1db4319bb08367fbdbad96fcbdd]

        use more Primitive2DContainer::append and more std::move
        
        Change-Id: Ide40a08f70cbb30a4f18c496d986feb78e5dfa1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noelgrandin@gmail.com>  [0ce1e13d2d530c891cad0d8b456adfa2c0d55df6]

        in ScOutputData::DrawFrame, we can skip the intermediate container
        
        and just feed the data in as we create it
        
        Change-Id: I5112e0b61bc4f4976978d5e4724053ab9ffc97e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135102
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noelgrandin@gmail.com>  [30400ebae2a46524558925424d41e612f1c1dc17]

        use Primitive2DContainer in impPolygonParagraphHandler
        
        which lets me move data around instead of copying
        
        Change-Id: Ibc7d8c2b5e0244537aa66561132facd93b424d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135101
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Noel Grandin  <noelgrandin@gmail.com>  [f0c82758f814c58f65e8cfb54bf01a97b1d73261]

        elide temporary vectors in impAddPolygonStrokePrimitives
        
        Change-Id: I759775bb672478f3baee782aba08ef17bd36124c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  tagezi  <lera.goncharuk@gmail.com>  [c3baf2a7f48b5ee46c6792b3106cb4fedb4a2ad2]

        sc uitests: Cleaning up unused variables
        
        Removed unused variables in the 'with' statement as the syntax
         allows the statement to be used without a variable.
        Removed variables like 'xcomments' and 'xseedspin', which seem
         to have been copied and not cleaned up.
        Removed variables 'gridwin' and 'xCalcDoc' if 'gridwin' is not used.
        
        Change-Id: Ia97692a0fb2e2af1d2693e09ac8f7c614360ade8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135042
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-30  Miklos Vajna  <vmiklos@collabora.com>  [507a8871c25aa9b7e5a02ceb86f5c60ebccc722b]

        sw: prefix members of CompareDrawObjs, SwBasicEscherEx, ...
        
        ... WW8AttributeOutput and wwSection
        
        See tdf#94879 for motivation.
        
        Change-Id: Iefc7aaf4caaaca5382ac0b28ea8e3ebe63250020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135108
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-30  Miklos Vajna  <vmiklos@collabora.com>  [5ee8670f18cb8b1913a23d04590d6a31ac9730de]

        sw content controls, date: add DOCX import
        
        - map
                      <w:date>
                        <w:dateFormat w:val="..."/>
                        <w:lid w:val="..."/>
                      </w:date>
          to the Date, DateFormat and DateLanguage UNO properties of content
          controls instead of fieldmarks, which model content controls poorly
        
        - fix CppunitTest_sw_ooxmlexport8's testN820509: date SDT is now a
          content control
        
        - add current date DOCX import
        
        - fix CppunitTest_sw_ooxmlexport13's testDateControl: date SDT is now a
          content control
        
        - fix CppunitTest_sw_ooxmlexport13's testInvalidDateFormField: date SDT
          is now a content control
        
        - fix CppunitTest_sw_ooxmlexport5's testfdo83048: minimal support for
          nested SDTs in DomainMapper::lcl_attribute()
        
        - fix CppunitTest_sw_ooxmlfieldexport's testDateFieldAtEndOfParagraph:
          date SDT is now a content control
        
        - fix CppunitTest_sw_ooxmlfieldexport's testDateFieldInShape: date SDT
          is now a content control
        
        - fix CppunitTest_sw_ooxmlfieldexport's testSdtDateDuplicate: date SDT
          is now a content control
        
        - fix CppunitTest_sw_ooxmlfieldexport's testSdtDatePicker:
        
          - retain placeholder
        
          - retain data binding
        
          - retain color
        
        - fix CppunitTest_sw_ooxmlimport2's testTdf121203: date SDT is now a
          content control
        
        - fix CppunitTest_sw_globalfilter's
          testDateFormFieldCharacterFormatting: date SDT is now a content control
        
        - fix CppunitTest_sw_globalfilter's testDateFormField: date SDT is now a
          content control
        
        Change-Id: I5a4c34217d23ed6fa0916e4dd6290351456b7232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135109
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-30  Roman Kuznetsov  <antilibreoffice@gmail.com>  [43458f83f29067752cfb3df2ccfe0eeb940f4b71]

        tdf#147132 Flatten Basic function implementation
        
        Change-Id: Ife73d08e57bb1c896a27f8cbbd6b1f4b106587a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135062
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-05-30  Noel Grandin  <noelgrandin@gmail.com>  [181cc77117b8d90c6dab63a17e8a690736ef62a0]

        move data out of impTextBreakupHandler
        
        instead of copying
        
        Change-Id: I3f851b877ece609547eed6f772b2b8df57aeae96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4c2c375d5f1c18540011d65b290afc440895458f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 580f62a41db6366a3ab13bf16a96a643710605a3
          - tdf#149253  improve help about anchoring
            
              shared/01/05260000.xhp  (Anchor)
              * corrected entries for "to page" and "to character"
              - removed double presentation of "Anchor" icon
              + add <relatedtopics> for Writer, with link to guide page
                on positioning objects
              - moved "note" on "Frame", which has been present since
                initial checkin in 2004, to after the option "To Frame"
                There is nothing special or unusual about anchoring to frame
                that needs attention. Maybe this note should be deleted, but
                have left it for now.
              + added variable to <h1> so heading and link can be embedded
              * refactor to <h1>,<note>
            
              shared/01/05260100.xhp  (To Page)
              * elaborate explanation of this option
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/01/05260200.xhp  (To Paragraph)
              + add information about what positioning regions can be used.
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/01/05260300.xhp  (To Character)
              - remove incorrect limitation
              * generalize the tip from ”image” to include frame and OLE object
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/01/05260400.xhp  (To Cell)
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/01/05260500.xhp (To Frame)
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/01/05260600.xhp (As Character)
              * correction to what changes the height of the current line
              + add related topics section and links
              * refactor to <h1>
              * update renamed German id
            
              shared/02/03200000.xhp  (Change Anchor)
              * Update command name
              * refactor to <h1>,<menuitem>
            
              swriter/guide/anchor_object.xhp
              * make explanation more general than image
              + adding headings for ”Moving an Anchor” and ”Changing an Anchor”
              + added section ids so these can be embedded elsewhere.
              * refactor to <h1>
            
              shared/00/00040501.xhp
              + add additional toolbars that have Anchor icon, and make
                an switchinline because Calc and Writer are different
              + add context menu access
              + indicated need to select an object before using command
              * rename German ids
            
            Change-Id: I43881be154163f71ca188a5446385e2dc5805f1e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134786
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-05-30  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f1d1555028c9e99ad1817fd15d68e24fb754d979]

        Breeze: tdf#149368 ^ radio & checbox button to follow up latest Plasma UI
        
        Change-Id: I2674ea52bc6217aa7cf9283c17f1d63533baaa49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135107
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [212cb61fb6adc05395b9f9afe0dacbd6594ae06b]

        Drop now-redundant cast
        
        ...that 3ca1a169e571a829598a00a2ffef6e1018d2cb18 "Use boost::noinit_adaptor"
        forgot to remove
        
        Change-Id: I82818c72e9178cda7b9698d8a30e1b8f3c3d87c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135099
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [3c7378d54b7a04e3f6dfc75a994744bdd953af7b]

        Fix mid-air collision
        
        ...between d203e3f35dc4547bb46151637ba6054d13025d01 "use comphelper::ByteWriter
        in UNOMemoryStream" and 3ca1a169e571a829598a00a2ffef6e1018d2cb18 "Use
        boost::noinit_adaptor"
        
        Change-Id: Ie890288485f499505184a12b0797d5fc9b877922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135098
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Noel Grandin  <noelgrandin@gmail.com>  [e42703d9f23d2235c3a1d61b06610248627595c0]

        elide temporary vector in processMetaTextLineAction
        
        Change-Id: Icf5a3ae47aec43854e669133f3d0c2bace1d942d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [db3f072dd61cd06ac67f52324f9ca0d21609f508]

        New o3tl::intcmp.hxx
        
        ...introducing o3tl::cmp_equal etc. implementing C++23 std::cmp_equal etc., plus
        an o3tl::IntCmp wrapper around it for convenient operator syntax
        
        Change-Id: I1d2e0d1aef99c531039fb83de31ed8e6036fde03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135095
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Noel Grandin  <noelgrandin@gmail.com>  [7088b6c6c191a105426fc631c9bf95a17e9f02dd]

        use Primitive2DContainer in TargetHolder
        
        which we can std::move the data around, instead of copying
        
        Change-Id: Id7aaad3970b942599807b7fda73d028f082a0f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-29  Noel Grandin  <noelgrandin@gmail.com>  [d286a820fac4dbac993e13afda52dde79b310af4]

        we can std::move the data out of TextBreakupHelper
        
        and save some copying
        
        Change-Id: I34cbc2edfd53fcc440d1765dba471fcbb05b2b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [1959d451da06f501dd3446ebfe9c631b5400af26]

        Improve some operator== involving OString,
        
        avoiding creation of temporary OString instances
        
        Change-Id: I27b4cb59b48b3ba40311a1f935a20250c8317d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135093
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [3ca1a169e571a829598a00a2ffef6e1018d2cb18]

        Use boost::noinit_adaptor
        
        Change-Id: Ide5f0394172548ed6a1ef4a6277ebf4752e685bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135094
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Stephan Bergmann  <sbergman@redhat.com>  [c3e9eb997f409f7fcf42659adedff43a8ade913d]

        [API CHANGE] Deprecate unused typelib_setCacheSize and make it a no-op
        
        ...and simplify the remaining code using the (now const) nCacheSize
        
        Change-Id: I4468cf223c158a318ba56ba63f5f60121c94f42d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134879
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-29  Caolán McNamara  <caolanm@redhat.com>  [0adee3ac5080723b5f0605c13f02ef358d848a0b]

        crashtesting: failure on loading gnome635181-1.tiff
        
        Change-Id: I5dd9552eb267ffb67aa0aae36b474eb28790b5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [061706c4b68e10b0ab265f52b77afcb1cfa74e5f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7bea4ecaa0fdc5dd19077c63f8901a4dde78cc67
          - Consistently capitalize acronyms
            
            Small follow-up/fixup for commit 2df65a1ff7072dc0ec866f5dfe11846c15208199
            
            Change-Id: I16f4c999c03af3828d6a279e862cc4c88c642138
            
2022-05-29  Caolán McNamara  <caolanm@redhat.com>  [ab1044c614bb674d165492f224e27985a6a15e0b]

        cid#1504583 Unchecked return value
        
        Change-Id: I172057b76ff4e6e1cf3d5e67a99360ecfc0a3fc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-29  Noel Grandin  <noelgrandin@gmail.com>  [42628f13f5228224d83b5a6ab949228e6926cf1b]

        use std::vector in AnimatedGraphicPrimitive2D
        
        instead of Primitive2DContainer, because I want to change
        Primitive2DContainer into a different data structure that
        does not support cheap random access
        
        Change-Id: I1bc55f2e21d9d5c4529c87be57a46aee63e04589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135087
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [71dd214624675afe3267d467d588afd1ce3eb693]

        Fix failing assert on shutdown with NVDA active
        
        The stack trace at the moment of calling implLookupClient with
        nClient == -1 was:
        
        > ucrtbased.dll!abort() Line 61	C++
        > ucrtbased.dll!common_assert_to_stderr<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number) Line 187	C++
        > ucrtbased.dll!common_assert<wchar_t>(const wchar_t * const expression, const wchar_t * const file_name, const unsigned int line_number, void * const return_address) Line 420	C++
        > ucrtbased.dll!_wassert(const wchar_t * expression, const wchar_t * file_name, unsigned int line_number) Line 444	C++
        > comphelper.dll!`anonymous namespace'::implLookupClient(const unsigned long nClient, std::_Tree_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener> *>>>> & rPos) Line 139	C++
        > comphelper.dll!comphelper::AccessibleEventNotifier::addEvent(const unsigned long _nClient, const com::sun::star::accessibility::AccessibleEventObject & _rEvent) Line 249	C++
        > svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const com::sun::star::accessibility::AccessibleEventObject & rEvent) Line 1416	C++
        > svxlo.dll!accessibility::AccessibleTextHelper_Impl::FireEvent(const short nEventId, const com::sun::star::uno::Any & rNewValue, const com::sun::star::uno::Any & rOldValue) Line 1408	C++
        > svxlo.dll!accessibility::AccessibleTextHelper_Impl::ShutdownEditSource() Line 700	C++
        > svxlo.dll!accessibility::AccessibleTextHelper_Impl::SetEditSource(std::unique_ptr<SvxEditSource,std::default_delete<SvxEditSource>> && pEditSource) Line 717	C++
        > svxlo.dll!accessibility::AccessibleTextHelper::SetEditSource(std::unique_ptr<SvxEditSource,std::default_delete<SvxEditSource>> && pEditSource) Line 1548	C++
        > svxlo.dll!WeldEditAccessible::ClearWin() Line 552	C++
        > svxlo.dll!WeldEditView::~WeldEditView() Line 864	C++
        > smlo.dll!SmEditTextWindow::~SmEditTextWindow() Line 85	C++
        > smlo.dll!SmEditTextWindow::`scalar deleting destructor'(unsigned int)	C++
        > smlo.dll!std::default_delete<SmEditTextWindow>::operator()(SmEditTextWindow * _Ptr) Line 3129	C++
        > smlo.dll!std::unique_ptr<SmEditTextWindow,std::default_delete<SmEditTextWindow>>::reset(SmEditTextWindow * _Ptr) Line 3276	C++
        > smlo.dll!SmEditWindow::DeleteEditView() Line 853	C++
        > smlo.dll!SmEditWindow::~SmEditWindow() Line 139	C++
        > smlo.dll!SmEditWindow::`scalar deleting destructor'(unsigned int)	C++
        > smlo.dll!o3tl::default_delete<SmEditWindow>::operator()(SmEditWindow * p) Line 46	C++
        > smlo.dll!std::unique_ptr<SmEditWindow,o3tl::default_delete<SmEditWindow>>::reset(SmEditWindow * _Ptr) Line 3276	C++
        > smlo.dll!SmCmdBoxWindow::dispose() Line 931	C++
        > vcllo.dll!VclReferenceBase::disposeOnce() Line 39	C++
        > sfxlo.dll!VclPtr<vcl::Window>::disposeAndClear() Line 206	C++
        > sfxlo.dll!SfxChildWindow::~SfxChildWindow() Line 198	C++
        > smlo.dll!SmCmdBoxWrapper::~SmCmdBoxWrapper()	C++
        > smlo.dll!SmCmdBoxWrapper::`scalar deleting destructor'(unsigned int)	C++
        > sfxlo.dll!SfxChildWindow::Destroy() Line 176	C++
        > sfxlo.dll!SfxWorkWindow::DeleteControllers_Impl() Line 599	C++
        > sfxlo.dll!SfxFrame::DoClose_Impl() Line 133	C++
        > sfxlo.dll!SfxBaseController::dispose() Line 981	C++
        > fwklo.dll!`anonymous namespace'::XFrameImpl::setComponent(const com::sun::star::uno::Reference<com::sun::star::awt::XWindow> & xComponentWindow, const com::sun::star::uno::Reference<com::sun::star::frame::XController> & xController) Line 1485	C++
        > fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1696	C++
        > fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1702	C++
        > fwklo.dll!framework::Desktop::terminate() Line 214	C++
        > fwklo.dll!framework::CloseDispatcher::implts_terminateApplication() Line 543	C++
        > fwklo.dll!framework::CloseDispatcher::impl_asyncCallback(LinkParamNone * __formal) Line 397	C++
        > fwklo.dll!framework::CloseDispatcher::LinkStubimpl_asyncCallback(void * instance, LinkParamNone * data) Line 245	C++
        > vcllo.dll!Link<LinkParamNone *,void>::Call(LinkParamNone * data) Line 111	C++
        > vcllo.dll!vcl::EventPoster::DoEvent_Impl(void * __formal) Line 53	C++
        > vcllo.dll!vcl::EventPoster::LinkStubDoEvent_Impl(void * instance, void * data) Line 48	C++
        > vcllo.dll!Link<void *,void>::Call(void * data) Line 111	C++
        > vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 2232	C++
        > vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2800	C++
        > vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 308	C++
        > vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4214	C++
        > vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5865	C++
        > vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5972	C++
        > user32.dll!UserCallWinProcCheckWow()	Unknown
        > user32.dll!DispatchMessageWorker()	Unknown
        > vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 475	C++
        > vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 506	C++
        > vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581	C++
        > vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 474	C++
        > vcllo.dll!Application::Yield() Line 559	C++
        > vcllo.dll!Application::Execute() Line 452	C++
        > sofficeapp.dll!desktop::Desktop::Main() Line 1600	C++
        > vcllo.dll!ImplSVMain() Line 202	C++
        > vcllo.dll!SVMain() Line 235	C++
        > sofficeapp.dll!soffice_main() Line 94	C++
        > soffice.bin!sal_main() Line 51	C
        > soffice.bin!main(int argc, char * * argv) Line 49	C
        
        Firing the event when we already set the id to mean "revoked"
        seems wrong. Also use the correct type for the id.
        
        Change-Id: Ie2e180c0c8c112023f789968ffa785f046de9d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135058
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-29  Noel Grandin  <noelgrandin@gmail.com>  [8ec7b04808b8aca32e2c38b8042af9b3c9bbe071]

        simplify and improve maybeInvert
        
        (*) we can move the data rather than copying
        (*) it should definitely not be const
        (*) we can use STL functions to do most of the work
        
        Change-Id: I02b4cbbdeed0588d592f24942d31608f2119561c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-29  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c7e190f62c93a31f67b8cf8d7fa539cd0c155d5b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2df65a1ff7072dc0ec866f5dfe11846c15208199
          - tdf#149010,tdf#148941,tdf#149012,tdf#149130 update to reflect changes
            
               New labels were given to some controls on the Options tab for
               Image, Frame, and OLE Object in tdf#149010 and tdf#148941.
               This patch updates the relevant help page (the Options tab)
               in the Properties dialog to reflect those changes.
            
               Because some of the controls in the Options tab also appear
               in the Descriptions dialog, and UI changes were made in that
               dialog (tdf#148941), then the help page for that dialog is
               updated as part of this patch.
            
               Have also updated some access commands to OLE Object, which
               were changed in tdf#149018
            
             swriter/01/05060900.xhp (Options tab)
               * "Names"-> "Accessibility" (tdf#149010)
                        and corrections to description
               + added an <embed> from the Description dialog page to provide
                 the new control label
                     "Alternate (Text Only)" -> "Text Alternative" (tdf#148941)
                     and the "Description" control, as well as the  corrections
                     to the control descriptions.
               + add "Sequences" section heading, in anticipation of tdf#149010
                      (comment 7)
               * corrections made to descriptions of "Previous Link" and "Next Link"
            
             shared/01/05190100.xhp (Description dialog)
               * Corrections made to Description dialog page, and control
                 descriptions embedded in the Options tab page. These corrections
                 were promised in 61b4b76000bd5adca504df0966ecef3410765ab3.
               * "Title" -> "Text Alternative" (tdf#148941)
                      and corrections to description
               + added separate <section>s for "Text Alternative" and "Description"
                 so that they can be embedded in Options tab. By keeping them
                 separate, it is possible to move their position in the embedded
                 file or use separately, if necessary.
               + add <relatedtopics> and link to Options tab, so show an alternative
                 way to access the Text Alternative and Description fields.
            
             simpress/guide/table_insert.xhp
               * move two bookmarks out of <ol>, because it disturbed formatting.
               * "Insert - Object" -> "Insert - OLE Object"
               * refactor changed items to <menuitem>
               * refactor to <h1>,<h2>,<note>
            
             shared/01/04150000.xhp (OLE Object menu)
               * "Object" -> "OLE Object"
               * corrections to menu contents
               * rename German id
            
             swriter/00/00000405.xhp  (access for Options)
               + added "right-click" instructions to howtoget
            
             shared/00/00040502.xhp  (access for Description)
               + added menu instructions for howtoget
               * make corrections in what objects can be accessed by context menu
            
             shared/00/00000404.xhp
               * "Object" -> "OLE Object" for menu access
               * "Formula" -> "Formula Object" for menu access
               * "Insert - Object - Chart" -> "Insert - Chart" for menu access
               * refactor changed items to <menuitem>
               * rename German id
            
            Change-Id: I1ddeb8d532b81f22eba2b1e480759775ff96969f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134191
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [6959a18d1a8fea4d65498083dc3ba05f640d0f39]

        tdf#144601 Qt fix creating QImage with alpha mask
        
        Rechecking the QImage documentation, this actually can be easily
        done; no more bit twiddling, which I got wrong to begin with.
        
        LO's alpha mask is inverted to Qt's expectations, but we have
        invertPixels() and then apply it with setAlphaChannel(). And we
        can even set the fAlpha using setOpacity()!
        
        Change-Id: If2030d3f87d3a4698d1cd9af005d307c2ee63061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135044
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-05-28  Caolán McNamara  <caolanm@redhat.com>  [8c4ca609c532b01c880d9803ba655c5688e5f0f1]

        ofz#47673 skip oversized tiff images
        
        Change-Id: I78727819b7c440855f89240f396dad845a295d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135041
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-28  Noel Grandin  <noelgrandin@gmail.com>  [9ae3863f2afaa07abda6af11daf34bf6b808c3af]

        add ClearItem to the SfxItemSet iterators
        
        to speed up operations when iterating over SfxItemSets
        
        Change-Id: Ie40327ffaf7faa801ccc12d2b05c546a7fe49802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135079
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Noel Grandin  <noelgrandin@gmail.com>  [8f3e12b7a918935eae4e98c47cdc3b575e8bf089]

        split SfxItem::ClearItem into two methods
        
        in preparation for passing a hint into it
        
        Change-Id: Id9e5516619a314406d8250bb2145996593dafbaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135078
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Noel Grandin  <noelgrandin@gmail.com>  [1cfa3f8694d4b585549e6dae7396d408184106cb]

        simplify SfxItemSet::Differentiate and SfxItemSet::Intersect
        
        using SfxWhichIter instead of SfxItemIter
        
        Change-Id: I046ae2cec9246b1dea9c484f94b88d64825f952c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135077
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [caf862fc843c89cceae2121f743a3822e09bbd46]

        tdf#149329 Qt change cursor via QWidget
        
        ... instead of its QWindow
        
        No idea, why my initial implementation used the QWindow. Neither
        do I know, why it's now somehow broken. The code is called, but
        the cursor doesn't change. But it seems to work via QWidget, so
        just do that. IMHO less QWindow is preferable generally; let Qt
        handle more of the low-level stuff.
        
        Change-Id: Id23fba719c9a4d7e760991c51e6021c6f89be345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135051
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-05-28  Noel Grandin  <noelgrandin@gmail.com>  [51f46ddaccd9a2c16b6a4a80b7627af7b13850f4]

        add GetItemState to SfxItemIter, the same way I did to SfxWhichIter
        
        to speed up GetItemState while iterating
        
        Change-Id: Ibe092e7581a5be0160eed52472122afe7e0ef377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135076
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Noel Grandin  <noelgrandin@gmail.com>  [bcd27039eec660fce2abd7604cdb8cd36ae4cdba]

        use the new SfxWhichIter::GetItemState feature
        
        to speed up other places that are iterating over
        SfxItemSets
        
        Change-Id: I646bae12420d15e67effdd279e071cdf8a8afffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Michael Stahl  <michael.stahl@allotropia.de>  [9896f330cdb3df67b74b16a2c2177a8505fd2485]

        tdf#145178 xmloff: ODF import: fix another bad attribute
        
        ...in XMLSectionFootnoteConfigImport.
        
        (regression from commit 9814c1f2edf56ecc0f31001db9234ef335488879)
        
        Change-Id: I79ab3b74853bd3ec9058fea72c341768e916bbd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135048
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [217ca9c79d75912df3fb735def4b64b0a7284e30]

        tdf#149255 qt: Implement deletion/"swallowing" for IM replacement
        
        This implements deletion of the text specified by the
        `replacementStart()` and `replacementLength()` of the
        `QInputMethodEvent*` received in `QtWidget::inputMethodEvent`.
        
        Quoting from the `QInputMethodEvent` doc [1]:
        
        > When receiving an input method event, the text widget has to performs
        > the following steps:
        >
        > 1. If the widget has selected text, the selected text should
        >    get removed.
        > 2. Remove the text starting at replacementStart() with length
        >    replacementLength() and replace it by the commitString().
        > [...]
        
        This implementation is sufficient for the scenario described in tdf#149255,
        but I didn't test any more complex scenarios, like one where text is selected.
        (My current knowledge of input methods is too limited to be able to do
        more extensive testing without first spending time to get deeper into
        the topic.)
        
        The gtk3 implementation in
        `GtkSalFrame::IMHandler::signalIMDeleteSurrounding`
        was very helpful to get an impression of what needs to be done.
        
        Since the documentation for `QInputMethodEvent::replacementLength()`
        talks about "number of characters", I suspect that conversion
        to UTF-16 code units is needed just the same way as it is for the
        gtk3 case and this therefore calls
        `SalFrame::CalcDeleteSurroundingSelection` the same way.
        However, this part is untested, since it is not relevant
        for the tested scenario (where each of the characters is represented
        in a single UTF-16 code unit).
        
        [1] https://doc.qt.io/qt-5/qinputmethodevent.html
        
        Change-Id: I2a34e58067e253c39dbd87905943134bdfa4ea27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134855
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [54f6599a4de738dfe3a26e8229e5588d26dd8165]

        Move GtkSalFrame::CalcDeleteSurroundingSelection to SalFrame
        
        It will be used for qt5/qt6 in a follow-up commit
        as well.
        
        Change-Id: Ic6a9351b0506519010b92e11d30962d5b105ec2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135052
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [87a932120d5f146933ed3bcc16c0f47dab90fd4b]

        ofz#24932-1 speed up GetItemState when iterating
        
        by having SfxWhichIter track the current position in
        the m_ppItems table, which means GetItemState does
        not need to traverse the ranges table to find the
        item position.
        
        shaves 75% off the time of
        ./instdir/program/soffice.bin --calc --convert-to pdf
            ~/Downloads/ofz24932-1.rtf
        
        Change-Id: Ib5fe61c75ca05bc2f1932e84b57ccfa55f8b7f74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135023
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [9ea767cb568cef1b142190d2adb0e301baa382e2]

        tdf#132350 Qt implement SalMenu button interface
        
        This turned out much more complicated then expected:
        
        1. The QMenuBar needs explicit adjustSize() calls to position a
           changed corner widget (or a resize...).
        2. The adjustSize() results in a temporary, minimal QMenuBar
           layout, so GetMenuBarButtonRectPixel needs to account for the
           extra space itself, instead of just a mapTo call.
        3. I didn't know, that you can't add shown widgets to a layout,
           but must call show() after add / insert, otherwise they are
           ignored in the layout (but show up as the layout items) and
           are painted in strange positions.
        
        This also includes the transparency flags for our QtWidget, so the
        updater "bubble window" is properly alpha-masked / shaped.
        
        And this maybe has too many asserts...
        
        Change-Id: I86a708175e9f9be786f5dc1810ae0197a0d3fc39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135021
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-05-28  Michael Weghorn  <m.weghorn@posteo.de>  [553750d5763b2e605cc8990d81c5588db4319b62]

        android: Update Android Gradle Plugin to 7.2.1
        
        Release notes [1]:
        
        > 7.2.1 (May 2022)
        >
        >     This minor update corresponds to the release of Android Studio
        >     Chipmunk Patch 1 and includes the following bug fixes:
        >
        >     bundletool does not package baseline profiles correctly [2]
        >
        >     To see the other bug fixes included in this release, see the Android
        >     Studio Chipmunk Patch 1 release notes. [3]
        
        [1] https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#7-2-0
        [2] https://issuetracker.google.com/issues/230361284
        [3] https://developer.android.com/studio/releases#patch-releases
        
        Change-Id: I57f37ea3786003dba4d95b291ddf6b0b44dccaa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135053
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-28  Luboš Luňák  <l.lunak@collabora.com>  [7674399aac661eb503d7badc53b9a4d68bd9839d]

        try to range-reduce even COUNTIFS if not matching empty cells
        
        It's possible to do reduce range of COUNTIFS to non-empty data too,
        since empty cells cannot contribute to the result, as long as
        the criteria do not require matching empty cells. Without this
        queries like =COUNTIFS($A:$A,...) can spend most of their time
        clearing and searching the vConditions vector that's big and
        not useful for the trailing empty cells in that column.
        
        Change-Id: I8d1e7977f172ac9b2cf84af3f982e945be3cb46c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135049
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-28  Luboš Luňák  <l.lunak@collabora.com>  [e3d3adbcde43965b517473387acda81e53e248ed]

        fix COUNTIFS when matching empty cells
        
        Change-Id: I8577324c0194d594a6df0b51431729b30ac8165c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135047
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-27  Louis Possoz  <louis.possoz@quelfutur.org>  [bbec710bd25fc5da27636cde73fe4ab23c76904f]

        tdf#145178 Formats in section Foot/Endnotes not read from saved files
        
        Imported, 'num-suffix' & 'num-format' properties generate debug warnings:
        
        warn:xmloff:10220:10220:xmloff/source/text/
           XMLSectionFootnoteConfigImport.cxx:123: unknown attribute urn:oasis
           :names:tc:opendocument:xmlns:style:1.0 style:num-suffix value=]]
        warn:xmloff:10220:10220:xmloff/source/text/
           XMLSectionFootnoteConfigImport.cxx:123: unknown attribute urn:oasis
           :names:tc:opendocument:xmlns:style:1.0 style:num-format value=One
        
        The faulty code is within XMLSectionFootnoteConfigImport::startFastElement()
        
        The namespace for these two properties must be set to 'STYLE'
           (it is wrongly set to 'TEXT')
        
        Change-Id: I923f12e19ed15779c67b2159d88d80a2ccb04e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133605
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-27  Szymon Kłos  <szymon.klos@collabora.com>  [0599a73c3c2bffdbfa4e695e2d694f1947215a07]

        tdf#145875 don't open Insert section dialog when pasting image
        
        This happens when we "copy image" in Firefox of the resource which
        cannot be accessed without logging in on some website.
        
        In that case we used HTML format and that resulted in pasting
        login webpage as a section.
        
        This patch detects simple HTML containing only an image while it also
        contains BITMAP format in the clipboard which we can use directly.
        That way we paste image data from the clipboard.
        
        Change-Id: Ia2ee7e246f8c71e1d0958c6c955ec056a0a96f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135011
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-05-27  Michael Stahl  <michael.stahl@allotropia.de>  [34eea317c5929d640aa43477c737d26d6b700bdb]

        tdf#149170 framework,sfx2: don't add ReadOnly=false
        
        There is a non-obvious difference in error handling when opening the
        file read/write for type-detection fails in
        utl::MediaDescriptor::impl_openStreamWithURL() - if ReadOnly=false is
        given, it will abort the file loading, whereas without any ReadOnly it
        will fall-back to a read-only opening of the file for type detection.
        
        At this point a StillReadWriteInteraction is used, so the user is never
        notified of the failure.
        
        (regression from commit 404c51f3664ffd4f7e2c1c8bb8a12ac70954fec2)
        
        Change-Id: I8c06fe23cc0bc0767df83f680a1a59e3700bbbbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135045
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [855a56fea4561135a63cb729d7a625a950b210e7]

        tdf#148965 PPTX import: fix internal hyperlinks on shapes
        
        Locale dependent code path resulted broken hyperlinks
        on shapes in a non-English build.
        
        Change-Id: I045bbe4246ab5336e2b967bf252b5fbca5b17706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134266
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3c965ccaa896b12b33ff5b7ccea0eb20d560116]

        clang-tidy modernize-pass-by-value in basegfx
        
        Change-Id: I1ec34b2f0e9869a82894795f1d6351189ae92d9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0779a1a185d2144d13766e6d827f43c0fd1bc814]

        Drop useless text width calculation
        
        It came from SvTreeListBox::GetHeightOffset dropped in commit
        7da765dde1800aa607f96e7a5807582ad2894acb
          Author Noel Grandin <noel.grandin@collabora.co.uk>
          Date   Thu Oct 27 10:21:42 2016 +0200
            loplugin:expandablemethods in svtools
        
        Possibly the calculation was used for something else GetHeightOffset
        used before.
        
        Change-Id: I2a13035e0852637529c40a0ffe1bd0e2b8b3d077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135010
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [74de217a52a15588e3fdf4059d62a384777c66db]

        tdf#127294 (related: tdf#147524) add ToD about Customize toolbars
        
            Inspired by tdf#147524
            Includes link to relevant help page
        
        Change-Id: Idb2b3da4839a61a5f713400b378babb0c765fb4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134904
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-05-27  Miklos Vajna  <vmiklos@collabora.com>  [0f70f4d76b5f68e5b1d81f0e300435ccef893c9a]

        sw content controls, date: preserve more properties
        
        While working on the DOCX import for dates, it turns out there is a need
        to store more properties for DOCX export purposes. Given that these are
        potentially useful for full support, add dedicated UNO API and DOCX
        export for these (i.e. not just grab-bag), but omit UI or ODT filter for
        now. This includes:
        
        - <w:docPart w:val="...">
        
        - <w:dataBinding w:prefixMappings="..." w:xpath="..." w:storeItemID="...">
        
        - <w15:color w:val="...">
        
        And tests for all these.
        
        Change-Id: I18ddec50d40c1c4abd87f7ea947a24dd8a92a755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135039
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d203d3aeb29a46bd85eb320d4ebcd7325ec4a1ab]

        clang-tidy modernize-pass-by-value in sax
        
        Change-Id: I0357c7e3f5ae1d0a560057ac756b1118917a5e11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba8502545fb5519a5cd13a673ee72d82f0fd8852]

        clang-tidy modernize-pass-by-value in tools
        
        Change-Id: Ib6ff202f5556f3342fb4e60de7e16b5107669319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135037
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-27  Miklos Vajna  <vmiklos@collabora.com>  [79baafccf3d390810f516b2cf9cb3ad2b4e9e63b]

        sw content controls, date: add current date handling
        
        While working on the DOCX import for dates, it turns out there is a need
        to store the selected date in machine-readable format as well. This is
        useful, because once the timestamp is formatted, the user is allowed to
        hand-edit the result, so otherwise the selected date would be lost.
        
        This commit adds:
        
        - doc model & UNO API
        
        - click handler (store the selected date, default to the current date in
          the date picker if possible)
        
        - ODT filter
        
        - DOCX export
        
        And tests for all these.
        
        Change-Id: I00f4e87ebfe0e8a19486367c32d472ccd2ff16a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135035
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-27  tagezi  <lera.goncharuk@gmail.com>  [bd6cb0d8219b117b1a72774c26d54774c72602da]

        tdf#132293: Removing unused imports from uitests files.
        
        This is the final cleanup of imports in the sc module.
        'pyflakes sc' is now empty.
        It seems, the most imports were copy-pasted from a file to a new one.
        Additionally, the import block and surrounding area made more readable.
        
        Change-Id: I8c4dff1007b9954c35795a7c8a940e8fcf8d7f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135036
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [7a8a25456b39eb6238571c7932eef8e44291ed84]

        tdf#149268: sw: Add UItest
        
        Change-Id: I5a7af83d1d97e009c9bd313b936c6b6d4ee48116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135016
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c716f3541205d295e1a5c23495db3dc931f491db]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6112298c946828a9d93b52384972f5e5f6c0538
          - tdf#148486  clarify "Vertical" and "by" controls in Position and Size
            
               also, adjustment to "Character" in "to", to indicate when it is
               available and to correct the description of its referent.
            
            Change-Id: Ic8ff382342503091dc9334aa72d05ea322d3e420
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134361
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Ming Hua <plateauwolf@qq.com>
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-27  Michael Stahl  <michael.stahl@allotropia.de>  [5c7f4b83c207b909312ed5a28282015fdcdd12da]

        sw: language fallback in MSWordExportBase::GetNumberFormat()
        
        There is this number format:
        
            <number:date-style style:name="N36" number:automatic-order="true">
              <number:day number:style="long"/>
              <number:text>.</number:text>
              <number:month number:style="long"/>
              <number:text>.</number:text>
              <number:year number:style="long"/>
            </number:date-style>
        
        in a paragraph which has fo:language="zxx", so the field has
        LANGUAGE_NONE.
        
        MSWordExportBase::GetNumberFormat() exports as: DATE \@"dd/MM/yyyy"
        
        But should be: DATE \@"dd.MM.yyyy"
        
        Follow Eike's suggestion to use the number format's language in case the
        field doesn't have one.
        
        Change-Id: I596bea5daa75c717931b3c5d5506103b87b8ee08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134638
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a8df5c815c8b002b7083b8777e3dd8beac573bf3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60d9df79df1071d5ad299464a4705abb237810ca
          - tdf#89131 add explanation about adding Heading rows to Insert - Table
            
            Change-Id: Ic3f9f82fad1693b60e31c331e2805a7748ce9cfe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135004
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [25e747ed39a3742d26c1128b6823679de279d5df]

        tdf#149124 PPTX import: fix broken connectors in grouped shapes
        
        Previously connector lines of grouped shapes were detached
        after the import losing the original layout (without
        ungrouping and moving the shapes).
        
        Change-Id: I660629d9d1c2cb0ab68de275ca5406f4c48e9145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134943
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-27  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [182d2a47a2b4ed0affdc828a534c1659cc2e926d]

        tdf#148365 sw: fix freezing with FrameIsAutomaticHeight
        
        Lock layout update temporarily during setting horizontal
        and after that, vertical orientations of textboxes
        with FrameIsAutomaticHeight to avoid freezing
        SwObjectFormatter, and depending on the platform,
        freezing Writer completely.
        
        Regression from commit 3b0a0e70cb67fc2e1f9999d2e8cbb9cfcd8c670e
        "Related tdf#66039 DOCX import: fix Z-order of group shapes".
        
        Change-Id: Ib106182b9f0d3d74ebdc3e746345380c8b685fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134480
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-27  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [c9d018df610b7bd7d5794231b2ccb0d8090573a6]

        make_installer: convert Win to Unix path for cygwin
        
        Usual cygwin auto-conversion magic doesn't work for PATH variable,
        which requires proper /cygdrive/foo/bar entries.
        
        Change-Id: Ic07ffcdf7cb28c5e5702964c331f337ee811c063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135032
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-27  Jim Raykowski  <raykowj@gmail.com>  [ba0a713fe76da5ee40ad34b375d3a900bff4e01a]

        tdf#149268 avoid null pointer dereference
        
        Change-Id: Iff3aece9eaed40c31764616504f1a4229db57e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134978
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4b5de4684fab255a1a69ecab9ece0384947a29c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bdaeee88ae63c1107b6c7db0dbcabb5347554397
          - (related) tdf#149018  add to OLE explanation in Glossary
            
                Can link to this explanation when discussing OLE objects in
                other help pages.
            
                Technical note: Needed to add a variable to the relevant heading
                in shared/optionen/01010200.xhp to be able to get a
                useful id to link to from the Glossary.  Also embedded that
                heading (which is the name of the control) into the Glossary so
                that if the control name is changed in the future, then the
                Glossary should remain up-to-date.
            
            Change-Id: I3318bc6b96a422dd40e792bf2230f7cefc9e85a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134793
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-27  Miklos Vajna  <vmiklos@collabora.com>  [10b1a9eb8588e15ea5e98001cc4d5ab2d56604f3]

        sw content controls, date: add DOCX export
        
        Map the Date, DateFormat and DateLanguage UNO properties to:
        
                  <w:date>
                    <w:dateFormat w:val="..."/>
                    <w:lid w:val="..."/>
                  </w:date>
        
        Change-Id: I4695ac30be26968b2c2ea14b044c1e2a10638ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135033
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [b7efccde76ca7bfa181fff39c52282e87e940614]

        tdf#147844: Use sanity check only if LibreOfficeKit is active
        
        Regression from 2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b
        "Add sanity check to avoid potential crash in the Collabora Online
        server"
        
        Change-Id: I2fcfb634b47f9d76f8efbbd64a8e69ea236894c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135024
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-27  Miklos Vajna  <vmiklos@collabora.com>  [fe2c9ca1bcf31d553c2142c4c282158c8e6429ae]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Icbf2c3b4c1dfcdf551ea8c1f1f9520449b55289a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135029
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [be3f29bd103bf058eeef063823fd4049448ce27f]

        android: Update compileSdkVersion/targetSdkVersion to 32
        
        API version 32 refers to the Android 12L feature drop
        (Android 12.1).
        
        According to [1], "12L is a special feature drop that makes Android 12
        even better on tablets and foldable devices."
        
        When getting over the list of behavior changes for apps targeting
        Android 12, I didn't realize anyting relevant specific to API level 32
        not yet in API level 31 as well, so there seems to be no need
        for any special adjustments for this update on top of
        
            commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
            Date:   Tue Apr 19 10:33:27 2022 +0200
        
                android: Update compileSdkVersion/targetSdkVersion to 31
        
        [1] https://developer.android.com/about/versions/12/12L
        
        Change-Id: Ic99c4ee5b81b6584648fa4717e23cc7f3c78bdab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [97b1a21f9b7b7ed8a24da4a83a043e82de46683c]

        android: Update androidx.constraintlayout to 2.1.4
        
        Change-Id: If2edff8006c3aa904d40dabf679d5ed0b0fd0127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-26  Michael Weghorn  <m.weghorn@posteo.de>  [b6258ff75dd3c19e8309a33c85e17e8a76b388cf]

        android: Update com.google.android.material to 1.6.0
        
        Change-Id: Iac3831d400d29b45be82d2585ca1454ed22676be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134986
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-26  László Németh  <nemeth@numbertext.org>  [73696a01224a3758bde686f32ec7e6f4c90877fe]

        tdf#146955 DOCX import: fix SAX exception with footnotes
        
        (Likely broken) DOCX documents exported by Writer raised a SAX
        exception, when PopFootOrEndnote() tried to access to a
        not-existent footnote, because PushFootOrEndnote() failed to
        create that.
        
        Note: the original ODT contains hundreds of frames, and
        these and the text content of the document have been put
        into the TOC section during Writer's DOCX export, resulting a
        broken document.
        
        Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
        "tdf#76260 DOCX import: fix slow footnote import".
        
        Change-Id: I9e32feb0cae778a87f034a8b5c41989fec90899d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134934
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-26  László Németh  <nemeth@numbertext.org>  [29359fc15c435cec17987fd6221ab6833d38746e]

        tdf#149324 sw offapi xmloff: add option to not hyphenate short words
        
        Add paragraph property to disable automatic hyphenation of short
        words based on a minimum character count.
        
        Note: there is a (broken) global option for Minimum Word Length
        at hyphenation, see "Minimal number of characters for hyphenation"
        in Tools->Options->Language Settings->Writing Aids), but
        for better/comfortable paragraph-level adjustment of typesetting,
        add a paragraph property for it. The same option is available e.g.
        in Adobe InDesign and in CSS Text Module Level 4 (hyphenate-limit-chars).
        
        * Add checkbox to Text Flow in paragraph dialog
        * Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationMinWordLength)
        * Add ODF import/export
        * Add ODF unit test
        * Add layout test
        
        Follow-up to commit 8c018910ae4d8701b1ce2a95727b9baed4016da3
        "tdf#149248 sw offapi xmloff: add option to not hyphenate last word".
        
        Change-Id: I68715f47d17b5c022430bd0e74c88a97bc7f81f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135028
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [3cde7345199b535763bb7d83a87096e9157b7317]

        clang-tidy modernize-pass-by-value in i18npool
        
        Change-Id: I96d99fbdce2b0432676acec8b327cece7c39bcb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134983
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Caolán McNamara  <caolanm@redhat.com>  [b566a5f5cef881c858d14d434df2b82b6d07d687]

        cid#1504573 Dereference before null check
        
        since...
        
        commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
        Date:   Mon May 23 15:48:41 2022 +0200
        
            Advanced Diagram support: Isolated IDiagramHelper, selection visualization
        
        we've already derefed pObj so can drop that check
        
        Change-Id: I9bdab5c069405c0015f74e4621e7b37fbbed2dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135017
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8148896dc8a81f4d4aeddae8527c18ab2db1aa3a]

        Fix typo
        
        Change-Id: Id418d65ce165d93e84463ae321ca2db869e857cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134670
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b9070eedb3b0296a04fcb53aad62f98bb528476b]

        WIP: dunno about "Hodler"
        
        Change-Id: I9fbee006237ccb70e31109023cf46b21aec325d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134668
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1cd8aee91b2fb9da6925d9165f10a980fa7b26b2]

        Fix typos
        
        Change-Id: I12273f1193a4089743b8e5a9716432e065930cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134990
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-26  Miklos Vajna  <vmiklos@collabora.com>  [ce12103990f7a8623c6de8b668784dbd0ab4d1b7]

        sw content controls, picture: add LOK API testcase
        
        Fails with commit 9a76be53dfb801b754bf55f9d4b8c5f82991a62f (sw content
        controls, picture: add LOK API, 2022-05-23) reverted.
        
        Change-Id: I6164e597099632a2212afee86ac9a4c7555e5c61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135022
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-26  László Németh  <nemeth@numbertext.org>  [8c018910ae4d8701b1ce2a95727b9baed4016da3]

        tdf#149248 sw offapi xmloff: add option to not hyphenate last word
        
        Add option to disable automatic hyphenation of the last word of
        paragraphs for better typography.
        
        Note: the same option used e.g. in Adobe InDesign, and a
        similar one in CSS Text Module Level 4 (hyphenate-limit-last).
        
        * Add checkbox to Text Flow in paragraph dialog
        * Store property in paragraph model (com::sun::star::style::ParagraphProperties::ParaHyphenationNoLastWord)
        * Add ODF import/export
        * Add ODF unit test
        * Add layout test
        
        Follow-up to commit 72bd0df107ee47c4d54fa88b4960d32ea03e9f69
        "tdf#121658 Add option to not hyphenate words in CAPS".
        
        Change-Id: Ida29c65b5a7cbfd7c399c342781531a6fb86f639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134985
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec694a32ea6c9f0287e8c12f4de62047abfcde72]

        avoid some allocation in SwDoc::ResetAttrs
        
        can put SwDataChanged on the stack
        
        Change-Id: I6631d04e181e2156184833642abdfab83092da60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f6fbed9f195078ed63760f1206a328f38571ba8]

        ofz#24932-1 walk ItemSets together in SfxItemSet::Set
        
        shaves 20% off the time of
        ./instdir/program/soffice.bin --calc --convert-to pdf
        ~/Downloads/ofz24932-1.rtf
        
        Change-Id: I85c8bdd51895d768c37d247f6bf07ce9183d1107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Caolán McNamara  <caolanm@redhat.com>  [c80c5ae7089e0e288c2f4ef9a9af5079f020c54f]

        cid#1504575 Dereference before null check
        
        since...
        
        commit 8b4b852a35149b1cfffc681cbb4f57d4c0b671b3
        Date:   Mon May 23 15:48:41 2022 +0200
        
            Advanced Diagram support: Isolated IDiagramHelper, selection visualization
        
        we've already defered pGrp can just drop that check
        
        Change-Id: I2b36a5fdc7e49ba1a8d4be5df910be0392bb7960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-26  Miklos Vajna  <vmiklos@collabora.com>  [c0fa456436947a5c167c652d19a884064b43c03d]

        tdf#149261 sdext: fix crash on starting the presenter console for the 2nd time
        
        This started with commit 3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4
        (framework: avoid re-creating protocol handler instances all the time,
        2022-05-02). In case there are 2 monitors, then one monitor shows the
        slideshow, the other shows the presenter console. The presenter
        console's protocol handler in
        sdext::presenter::PresenterProtocolHandler::Dispatch::Dispatch() has
        mpPresenterController->GetWindowManager() as an empty reference on the
        2nd time the presentation starts.
        
        The above commit started to cache protocol handler instances at a frame
        level for performance reasons, and this is meant to be safe in general,
        but the presenter console's window manager is re-created between
        slideshow runs, so it depends on framework/ code to re-create the
        protocol handler all the time, which is problematic here.
        
        Fix the problem by introducing a framework::CacheInfo interface that
        allows protocol handler implementations to signal if they want to avoid
        being cached.
        
        This should be good enough for now, but if later it turns out that there
        are too many broken protocol handlers out there, then we can consider
        flipping the default and only cache handlers which explicitly opt in for
        this behavior. This is not done in this commit.
        
        Change-Id: Ic159813b1b339540bc8c4e780c4d6d7d2d4d2445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135020
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc45e54be6ba5d4685ae4ef3c3ea696fc99cccd4]

        disable this sdext test on windows for now
        
        Change-Id: I06456afa84314b3348bce177c939f510e00aa743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [c390c2e3f44953e236389467c7c090cee9ebc1b7]

        mark SvxFontItem as IsSortable
        
        which speeds up some searching in the pool
        
        Change-Id: I9fe7da50b4d803010c88702d8cd03c3380e7cc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134992
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6b05d9feb5c74606b55a83da9ba06673ccc161f]

        avoid some allocation in SfxItemPropertySet::setPropertyValue
        
        by using std::move on the newly created poolitem, so that the pool does
        not need to clone it
        
        Change-Id: Ib90b14173d19768517eb2a31cc0a105e5eb4d7c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134991
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Miklos Vajna  <vmiklos@collabora.com>  [b3c6511659c58bcc75a9742e0ae0cc436b6f6825]

        sw content controls, date: add ODT filter
        
        Map the Date, DateFormat and DateLanguage UNO properties to:
        
        	<loext:content-control loext:date="..." loext:date-format="..." loext:date-rfc-language-tag="...">
        
        And do the opposite on import.
        
        Change-Id: I16d3f755d77ed20380d877ba65dfe6d063f2bec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134977
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [20deeb799a5298188eb967e3ba677b830c5a5d3c]

        Breeze: tdf#149036 add Label Field icons
        
        Change-Id: I37b2f965edffbc8ff803ca84389e06b61d27f225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134980
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [e09f49f944fa1d4163bfd52fd824f4216f93558f]

        bin: add script to retrieve info about crashreports...
        
        ... from https://crashreport.libreoffice.org
        The script saves the data into a .csv file
        
        Change-Id: I771d144402a3039851c99b025c52bd6e799f71ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134283
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [3d505f29942e74d5e5769c8c86c083253aa3412a]

        Colibre: tdf#148963 improve Restart Numbering, Insert
        
        Unnumbered Entry, Add to List icons
        
        Change-Id: I8b00bc0780a483d7c71597c8d09cd35228d92e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134984
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Caolán McNamara  <caolanm@redhat.com>  [f26926fe679d3718a61b6e5873cb2ffad0d391c3]

        ofz#47639 avoid Integer-overflow
        
        Change-Id: I3f89238187dfb8cfd7a929d5f5576b83f6ec37c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134982
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [24c709655e5c1ca51c6c6da7ef0cb733354f6d20]

        clang-tidy modernize-pass-by-value in comphelper
        
        Change-Id: I29074d801eaef57f160ce14b943b21831b327ecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134979
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-26  Rizal Muttaqin  <rizmut@libreoffice.org>  [85e477cd08aae47cd3a69a561ca333e3e1e19a0e]

        Revert "Breeze: td#149036 add Label Field icons"
        
        This reverts commit a4a62ea283e20a01c0c0c99359c6e029484fedb0.
        
        Reason for revert: misstyped bug number
        
        Change-Id: Idcaa75db63e006def67841e5c7df1b68aa7f0f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134999
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a4a62ea283e20a01c0c0c99359c6e029484fedb0]

        Breeze: td#149036 add Label Field icons
        
        Change-Id: I3843420f896c8913267ec7d699804304c1bc2af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134976
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c150f855b53d8cb2f0b98d86fc5e630144194bab]

        tdf#142071 Align Tip of The Day with real menu/options
        
        Change-Id: I242cf305d4e6d8ef26968e196c9f169754b90d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132849
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Miklos Vajna  <vmiklos@collabora.com>  [60a39b8dd89cffbb02bc275d888eee1fe53ef035]

        desktop: fix type of the last argument of lok_preinit_2()
        
        This went wrong in commit 5de22d1e559cd0f1f5fa4e247f0ce153710fbeab
        (Handle "addfont" from Collabora Online, 2022-03-09), running e.g.
        online.git unit-tiff-load with sanitizers complains:
        
        kit/Kit.cpp:2977:9: runtime error: call to function (unknown) through pointer to incorrect function type 'int (*)(const char *, const char *, _LibreOfficeKit **)'
        
        I.e. the type in lok_preinit_2() is LibLibreOffice_Impl**, but the type
        in LokHookPreInit2 is LibreOfficeKit**.
        
        Since this is just a pointer, there is no harm in adapting
        lok_preinit_2() to match.
        
        Change-Id: Ib80711a5ae7719a9058151f482aca50c43185348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134941
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-26  Miklos Vajna  <vmiklos@collabora.com>  [645413a14a91a72bc06acf0fb4703ff7b9fffec9]

        sd theme: add UI (sidebar) for shape fill color effects
        
        Which was perhaps the last missing piece of the "sd theme: shape fill
        color" story.
        
        Change-Id: Ice75d91412aa56afe0c9995086097d491ebf7299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134952
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-26  Julien Nabet  <serval2412@yahoo.fr>  [29dcafb5700938502cf62de27265f9d5d3920a8d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35e3b240996d1ad5f3011d72f92e8623665a09e2
          - Fix typo in reference
            
            following f3b76b5e8d644176704c4619304278869ae57127
            tdf#141474 Cdbl, Cint, Clng, Csng accept keyword arguments
            
            Change-Id: Ie580b7a975fe0f5bf0e3563fd9dba7762314a2f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134911
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-05-26  Luboš Luňák  <l.lunak@collabora.com>  [d235f705b4dda23cfd7b77c500b166016633e46c]

        use at least assertions mode if libc++ debug mode is not usable
        
        This way at least e.g. std::vector::operator[] will still check
        bounds even though things like iterator debugging will not work.
        
        Change-Id: If3c550cfec68eee9a19050fc8e60fca07148b4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134946
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-26  Siddhant Chaudhary  <urssidd@gmail.com>  [43f6ca7164a9ea7c99d177d711684e25d53e8be4]

        tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Removed a redundant assert on returned value of `MacrosTest::loadFromDesktop`.
        
        Change-Id: Ia318cd770b120baff87e7cf5f01120beaf112794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134957
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-05-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [84706376e333ca5cf9ccb9a2c08daef93fa3b16d]

        Breeze & Sifr tdf#136916 add dark underlines variant icons
        
        Change-Id: Ic15b8e56959606d8dbacb073d6e80d5188dc7502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134975
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-05-26  Luboš Luňák  <l.lunak@collabora.com>  [cb22a3f6f588323d7353990b5280f01df6e85997]

        unittest for SalLayoutGlyphsCache glyphs subset
        
        Change-Id: I341871c65e63f37ffc3507daaefe035f6762e62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134956
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-26  Luboš Luňák  <l.lunak@collabora.com>  [755ed6f5f062afecb157f06e6a3132873ca7b23f]

        do not use glyph subsets if LTR/RTL does not match (tdf#149264)
        
        Writer apparently sometimes asks to lay out RTL text as LTR,
        for whatever reason, and Harfbuzz in that case does not give
        consistent results usable for creating subsets of glyphs (or maybe
        HB_GLYPH_FLAG_UNSAFE_TO_BREAK is not reliable in that case).
        I don't quite understand what the problem here is, but avoid
        it by checking whether the text is LTR or RTL and simply do
        not try to create a subset from the glyphs if the text does
        not match the way it was asked to be laid out. I don't even
        know if this is correct handling or just a workaround for something.
        
        Change-Id: Ic77db04f529c9ca2c194893a2127e85953accf32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134950
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-26  Luboš Luňák  <l.lunak@collabora.com>  [13762c1ec222b6235bbef39eed9bb1037e082a1e]

        test also SalLayoutGlyphsCache in glyphs caching unittest
        
        Change-Id: Ic0e5ea44525e7cf76a6de1f64f77b943b8347dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134948
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-26  Luboš Luňák  <l.lunak@collabora.com>  [28a8746ad86907491b428f5fac7e1be4f5bfcf2c]

        check GlyphItem equality properly in a unittest
        
        I.e. use the existing operator==. I don't feel like writing
        operator<< for it just for one unittest though.
        
        Change-Id: I63181765a4987a5d6efedc74a1e20d56a70eaa83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134947
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-26  Eike Rathke  <erack@redhat.com>  [fd45045cc3029b41c02a2634e6fe2e5456f716ad]

        convertLanguageToLocaleImpl() speed-up a gazillion en-US fallback cases
        
        Change-Id: I7f9290383eabcf3733f15f8f45193ee04db9852f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134953
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-05-26  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [aee953d7b66c02bbd7034cbf8991e3748dc3794a]

        Reduce cmd line length for make_installer calls
        
        Seems on Windows, we're hitting the 8k character max cmd line length,
        on setups with slightly deeper src tree path locations. Shorten length
        of expanded call_installer calls by putting shell script into PATH
        locally.
        
        Change-Id: If1cddab9e4e07a7c5ebfae7a4e88e43b1bc8b907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134938
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-26  Caolán McNamara  <caolanm@redhat.com>  [50d0beecf23468e3f9a7090e2723e9bbf94b30bf]

        ofz#47617 don't skip TIFFClose on error condition
        
        Change-Id: Ie5a84488312b9f17733747942e45d767cd5d4966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Luboš Luňák  <l.lunak@collabora.com>  [e544febe2108d0bbe99936ce7373a22f32fe08a7]

        don't try glyph subsets if cloneCharRange() would return anyway
        
        A small optimization.
        
        Change-Id: I21786ce713bd39d14c075a941d83c060d04b8886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134949
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-25  Luboš Luňák  <l.lunak@collabora.com>  [ff6347f86f6bae66d21059d68ca0b47a63fb0aa2]

        Revert "verify that all results from SalLayoutGlyphsCache match"
        
        For now at least, as this is causing a number of Jenkins Mac failures,
        even though it originally passed (and still occassionally does).
        
        This reverts commit 04a36851aab1272c9c21ac97d0fc0f4ffe372fe0.
        
        Change-Id: I21454b6ec59e96dfb5f6eb723d4eb8f19948d195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134955
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4bf19321ed9ce2d0e49341193690fef0c7085ea]

        directly instantiate IndexedPropertyValuesContainer
        
        without the overhead of the UNO service engine
        
        Change-Id: I4a02fda2b3c92a897634374bf72cfffee4f531f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134923
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [18321eb3f447c9e6519e1691673677fc8a2c8117]

        elide some OUString allocation
        
        Change-Id: Idcb296980ea498373a0fb4f8c0c584eef2c5c9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0731f14d1b9c86a626e8560053d87dcaaef8ad6]

        std::set->o3tl::sorted_vector in MathTypeFontSet
        
        Change-Id: I8b664f10bee232355eeb431de6b1445d9c797f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [1bfbef9ad2092106c8f1f6c3e5942940173c2d15]

        tdf#149068 don't call any OpenGL if the context is initially 'invalid'
        
        Change-Id: I6a966e84574716a215d1625cde8b6826185cc451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [9525dc41e3f592a373315d005ed9a65cbb57861c]

        tdf#149280 modified called after dialog was destroyed
        
        just ignore it in that case
        
        Change-Id: I8f294acd9ee16d2f9c8662614fac3672f80b3376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Mark Hung  <marklm9@gmail.com>  [7f77a180dd22e7d07b1840660dc9a6e66463b84f]

        sw: refactor and create Justify::SnapToGrid()
        
        Move snapt to grid code from SwFntObj::DrawText() to Justify::SnapToGrid()
        and create a simple unit test case testSnapToGrid.
        
        Note that SnapToGrid() is for "Snap to char is on" case.
        
        Change-Id: Ib9b3a08c744216e37dd260434700cbf3f079a0fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134707
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-25  Roman Kuznetsov  <antilibreoffice@gmail.com>  [a68629fdf97f181d4c6975f91e66fe52f83247e9]

        tdf#148467 Move sparklines items to Insert/Format main menu
        
        Change-Id: I2606fdd6301e5d1cb1e855d79a971762ed2d835d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133608
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d203e3f35dc4547bb46151637ba6054d13025d01]

        use comphelper::ByteWriter in UNOMemoryStream
        
        to avoid a temporary buffer
        
        Change-Id: Ibe1d4ffb240993e14eaaddb219f9cde328f9afbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [371886dd1245751edb5ce728d0c764a6bb8e2205]

        elide some OUString allocation
        
        Change-Id: Ia21421731dadc1d0e65da182471eb2b8d799782b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134918
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e79db65efb48f2f4e82945fc850bc38c8923e22d]

        allow comphelper::OEnumerationByName to use a vector too for names
        
        so we can skip some allocation.
        Use a std::variant to preserve existing functionality
        
        Change-Id: If01ebb04f7895fd52fa3f5d90648868fd38dc39e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3866b859ee715da9eb124bc6fa8d2193d6af2442]

        Fix typo
        
        Change-Id: Ia3d5775b938d626457ac4701a5d62f7b7e4162e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134939
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-25  Miklos Vajna  <vmiklos@collabora.com>  [eb3fccbd86ca343f21aa42505fa3400bfec838c8]

        sw: add stub Title impl for SwAuthorField
        
        It is advertised as a property, but it's not implemented: just avoid the
        assert fail on inspecting the UNO wrapper.
        
        Change-Id: Icd20c0edf543cf5ac435b9dcfdc8542f435ef231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134936
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [4366e0605214260e55a937173b0c2e02225dc843]

        tdf#148864 Qt switch QtObjectWindow to QWidget
        
        ... and therefore rename it to QtObjectWidget
        
        Replacement of the QWidget with QWindow originally happened in
        commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3 ("tdf#121247,
        tdf#121266 KDE5: Add basic support for OpenGL"), but that
        unfortunately has a very sparce commit message with no reason
        for this change. Then the code was further complicated in commit
        25edbded9946801effd117b9c46de0f8b4bc5632 ("tdf#125517 Qt5
        implement a minimal Qt5ObjectWindow") and a few follow up fixes
        to restore input and focus handling.
        
        But appearingly all this QWindow handling isn't necessary and just
        returning to a QWidget based class fixes the problems with the
        video overlay (AKA QWidget::winId()) and video playback for good.
        
        The OpenGL Impress transition (Fade) mentioned in the original
        tdf#121266 bug still works.
        
        This also adds the previously missing SolarMutexGuard to all the
        overridden QtObjectWidget functions, which call the SalObject's
        Callback function. I accidently triggered a DBG_TESTSOLARMUTEX
        crashing Impress while debugging this.
        
        Change-Id: Ia22cabfd4f3585dc7fa3f9f18a913c5bd1987dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134864
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-05-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ff2b4bff61d2e1679bb525d754c960c48b81c495]

        Update git submodules
        
        * Update translations from branch 'master'
          to baa28fb3a6161fa057808d25b69ce24e21a1f9d8
          - update translations for master/7.4
            
            and force-fix errors using pocheck
            
            Change-Id: I6791c0fed18c372d154a25de9c826720bb037af8
            
2022-05-25  Luboš Luňák  <l.lunak@collabora.com>  [e74cfb13d3e97938ff8924fcf962a8ea03fe9c76]

        check column again when going to the next Calc sheet
        
        Since the number of allocated columns may be lower in the next one.
        
        Change-Id: I92eb4642ed01ff6c858a250aefcfa36c565103d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134932
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e2304f00960d8e0e8c3ff76e632ef8f92608084]

        elide temporary vector in PathSettings::impl_convertPath2OldStyle
        
        Change-Id: Ib86933ef564b0d27c47dbbaddaa55f03b8426c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [a2b3e397d86800f9a56e83d166dcabb4f077172f]

        50 null derefs seen in crashreporting report
        
        Change-Id: I42f1179ad1d60ac70ccda5362590853a69fd3712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [5dabac23d0b1fa3b0d6a975df3bce066d14afa8a]

        91 null derefs seen in crashreporting report
        
        Change-Id: I8114f57cf5a5f74b2debac963813dcf6aac1bd0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134930
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [856887cbc8a0a2fd04b90ee2170948d34c8ff9c4]

        tdf#65911 add accelerators for style editing
        
                  Alt+C - character style
                  Alt+P - paragraph style
            Shift+Alt+P - page style
        
        Change-Id: I8d9f48ae87daf9c2ad5db2445fd5a74e821dc076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132705
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [23e3bff528ab38c8d5c6d401b672a0033cef2bd4]

        svx: fix one more EXCEPTION_INT_DIVIDE_BY_ZERO
        
        See https://crashreport.libreoffice.org/stats/signature/SvxShowCharSet::PixelToMapIndex(Point%20const%20&)
        
        Change-Id: Ied5698fd47220fae54d72be263c3eeed5fb77911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Seth Chaiklin  <sdc.blanco@youmail.dk>  [969603ffa48c6566b602a2a9174fc0acea307428]

        tdf#149018 a  few more "Objects" -> "OLE Objects"
        
             -- part of a general project to use "OLE Object" instead of
                "Object" in the UI when appropriate.
                * updated command sequence in one "tip of the day" and converted
                  tip to a question (after preferred style)
                * title of dialog box for inserting or editing an OLE object
        
        Change-Id: I519930c2e95c7a157c43a0870dca8b3df362b65d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134895
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [7fffe8bfdc6c5c4034700d16c996c112ec5da400]

        cid#1504535 Uninitialized scalar field
        
        Change-Id: I354e6ccc118ec20649eac5257375e493c8172dfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [dbb2bdb4ad84cb3947e142daae991f869640b7b6]

        ofz#47587 Timeout
        
        Change-Id: Ic2e168020ad9040705fbdcd0b6945c6a2d2f5b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134884
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Miklos Vajna  <vmiklos@collabora.com>  [ce5d609da9d20b3c91f6f8eb4ee88451cbd55a9d]

        sw content controls, date: show a date picker on click
        
        - add a new SwContentControl::GetDateString() that knows how to produce
          a formatted date, taking the language and the date format into account
        
        - add a new SwDateContentControlButton that knows how to open popup a
          calendar on click and that puts the selected date into
          SwContentControl::m_oSelectedDate
        
        - extend SwWrtShell::GotoContentControl() to consume that selected date
          & update the document text accordingly
        
        - in case SwSelPaintRects::HighlightContentControl() notices a date
          content control, create an instance of this newly introduced
          SwDateContentControlButton
        
        Change-Id: Ia2cb0fa3aefbf543b8dc2e96bcebb41408eb12c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134926
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-25  Caolán McNamara  <caolanm@redhat.com>  [d77db907465547f8704fd32b2c90165b54873dba]

        tdf#149068 put a OpenGLZone around the sync indirect opengl calls
        
        to get the opengl version
        
        Change-Id: Ibd55974a39d9d79c9ec9a03e4d4482e4e8755471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-25  Luboš Luňák  <l.lunak@collabora.com>  [04a36851aab1272c9c21ac97d0fc0f4ffe372fe0]

        verify that all results from SalLayoutGlyphsCache match
        
        The code used to do it only for computting glyph subsets, but
        some of the failures there show that bugs in font code elsewhere
        can make the cache returning different results, so check
        even for normal repeated cached calls.
        
        Change-Id: I8a18710546fe2557f69aaef4ab0bdb63c62a9253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134659
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-25  Heiko Tietze  <tietze.heiko@gmail.com>  [ed45b67db66ef0f6c69887c75013a178c4412f74]

        Resolves tdf#119447 - Improve sidebar height in start center
        
        Reduced the font size multiplier from 1.4 to 1.2 to fit
        the window into 768px height and added the branding image to
        the height calculation
        
        Change-Id: I05473155f0068880298a461fe8491468b07079b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134867
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-25  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [8b4b852a35149b1cfffc681cbb4f57d4c0b671b3]

        Advanced Diagram support: Isolated IDiagramHelper, selection visualization
        
        Moved and isolated IDiagramHelper to own file to get SdrObjGroup smaller
        and less dependent again, all places adapted. isDiagram() now available
        at SdrObject directly, adapted and have less places which need to cast
        for SdrObjGroup for check.
        
        Started to add SdrHdl/selection visualization to seleced Diagram. Only
        as a start, will need to be extended to look good/better, plus evtl.
        functionality in handles/UI.
        
        Corrected error(s) found by failing UnitTests
        More clang-notes (static, namespace) I nneeded to follow
        
        Change-Id: If4675b3270d3ee30259fce49deb017dbbaf5c0c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134825
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-05-25  László Németh  <nemeth@numbertext.org>  [2682828f73a6c759735613ec924357424baeae24]

        tdf#56266 sw xmloff: fix tracked deletions in insertions
        
        RedlineSuccessorData export, i.e. tracked deletions
        within tracked insertions were loaded as plain
        tracked deletions during an ODF roundtrip. After that,
        e.g. rejecting all changes couldn't reject the lost
        tracked insertion, keeping the text of the tracked
        deletion as part of the original text by mistake.
        
        Regression from commit a9019e76812a947eb54cfa8d728c19361c929458
        "INTEGRATION: CWS oasis (1.3.276); FILE MERGED
        2004/05/12 11:00:37 mib 1.3.276.1: - #i20153#: changed <office:annotation> and <office:change-info>"
        
        Note: RedlineSuccessorData is still stored in an extra
        text:insertion within text:changed-region, only the
        not ODF-compatible office:chg-author and office:chg-date-time
        attributes were changed to dc:creator and dc:date elements
        in RedlineSuccessorData export:
        
        <text:changed-region>
          <text:deletion/>
          <text:insertion/>
        </text:changed-region>
        
        Because this structure still causes a bootstrap ODF validation
        error in the odfexport and layout tests, check the export with
        uitest. See also SetChangeInfo()/RedlineAdd().
        
        Change-Id: Ic15c468172bd4d7ea1fd49d9b6610204f23d0036
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134860
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-25  Heiko Tietze  <tietze.heiko@gmail.com>  [ba2c5e05319181aa00357d66ba2fbaba20231bd3]

        Resolves tdf#146762 - Consistency for list indent and level shortcuts
        
        Previously:
        * Shift + Tab on the first item decreases the indention
        * Tab on first item increases the indention
        
        * Shift + Tab on any item but the first does nothing
        * Tab on any item but the first demotes the list level
        
        * Ctrl + Tab on any item including the first inserts a literal tab
        
        New:
        * Tab on any item demotes the list item (move right)
        * Shift + Tab on any item demotes the list item (move left)
        
        * Ctrl + Tab on any item indents the whole list
        * Ctrl + Shift + Tab on any item outdents the whole list
        
        Change-Id: If64a5103a271d30c10fc903a306c9271e61cae49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134856
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [37a5d60df7631cca8ce597905d09748a48ff2a86]

        SvxUnoXPropertyTable is never passed a null ptr
        
        and make the type of the constructor functions more precise to avoid
        unnecessary UNO_QUERY at the call site
        
        Change-Id: I8164fd3df131720cf86eaf6d49735a3157d3cc97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134914
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-25  Hossein  <hossein@libreoffice.org>  [b6e0ae1b1bad5e222e21bbb4b2a158c1fc6f9779]

        Add Makefile for the FirstUnoContact C++ SDK example
        
        Add Makefile for the DevelopersGuide/FirstUnoContact C++ SDK example.
        The example now can be built using the same process for other C++
        exmaples.
        
        The DevelopersGuide examples will be categorized into several
        directories, according to the language:
        
        basic cxx java python
        
        This requires that all examples ported to each of these languages.
        
        Change-Id: I95c5c324fef66664836b5e07bf34c98117e6b478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134596
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [27fb97fbfe3da858cefb830614c90a496dfe3ad6]

        VCL SysEnvData: add Invalid Platform and Toolkit
        
        I accidently almost introduced some subtle sytactic error in Qt,
        because the default platform and toolkit values are actually valid.
        
        So add an Invalid value to both enum classes and then sprinkle
        some asserts, so these tests aren't working on invalid data.
        
        Thanks Michael Weghorn for catching this in review.
        
        Change-Id: Ic6a0764dfc5168181251023f4d1c66ffa32651d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134882
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [7bf9629d4f3e8504b5d09685d7721275b3287443]

        tdf#125925 Qt migrate KF5 theme font settings code
        
        Currently all implemented Qt platforms use freetype and fontconfig
        to handle the font selection, so just move the font styling code
        from the kf5 VCL plugin to qt.
        
        This really minimizes kf5 by just keeping the special file picker
        handling in that VCL plugin.
        
        Change-Id: I0bbb2496379396afc46e34fe0d026702dce1492e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134862
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-05-25  Miklos Vajna  <vmiklos@collabora.com>  [4a54a24c207f3040390e2fefec41cbbf0edd5eca]

        tdf#149205 sd theme: fix PPTX export loosing dk1 and lt1 colors
        
        Document theme of Impress documents were exported to PPTX only
        partially: dk1 and lt1 was hardcoded to the SYS_COLOR_SCHEMES define,
        while the rest was written from master-slide-specific svx::Theme.
        
        The benefit of this is that our theme is just a set of colors
        (<a:srgbClr> markup in OOXML), while dk1 and lt1 is more dynamic by
        default in PowerPoint (<a:sysClr> in OOXML). The downside is that this
        way a custom dk1 and lt1 color was lost on export.
        
        Fix the problem by switching to <a:srgbClr> markup even for dk1 and lt1:
        not using the <a:sysClr> markup doesn't seem to be a problem in
        practice, or at least much less problematic than rendering with bad
        colors.
        
        If there is a need, dedicated <a:sysClr> markup support can be still
        added later by extending svx::ColorSet::maColors to not only store a
        list of colors, but also some additional properties of those colors.
        
        Change-Id: I26df3fd8c891c217df0d36382f6599805198f4bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134883
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4bd8b4e469a4084eee0ec467721704ae51f82301]

        no need to call makeStringAndClear here
        
        we are passing it to a u16string_view arg
        
        Change-Id: Ieef467fde2acccedf41381e97e93034fffceca22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Pranam Lashkari  <lpranam@collabora.com>  [a4536c53eceac8eec6e5ac273583fefb6bafcb3f]

        comments: reassign ID when copy comment
        
        reassigning new ID will make all the comments have unique IDs
        this will also ensure there is no mixup when working with comments ID
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: I94b433130c68354ab94d4d6e9b86751038b31af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134686
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 0d3bba5c383ef8b9f62c121a26fed4445c813949)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134792
        Tested-by: Jenkins

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c022b7a169eebf15f38db0286660ac84cc537358]

        fix thread-safety in OInterfaceContainerHelper4
        
        we need thread-safety here (even though we use a mutex), because we use
        a singleton, and the singleton can be ref-counted when the
        OInterfaceContainerHelper4 is deleted, and is generallly not held at
        that point, and that is tricky to enforce.
        
        Change-Id: I1d61495786d5f0e18deae724b2eb6c6645feb51a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134872
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [d07acfc4b2cc92d094d8eac204868e26c9e25e27]

        tdf#145248 don't start a drag if actively selecting
        
        Change-Id: I00565adbb32a6d9109a75548a544e79ba1951650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134881
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [b0ba3ed1992b24c8808604553278fe75b093c0a9]

        Resolves: tdf#148168 disable gtk treeview seach box
        
        Change-Id: I63691d86084832e89d248527c214bcdcc98dc3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134878
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Michael Stahl  <michael.stahl@allotropia.de>  [4ec4dd04b1a0f2313edfeff3cb7818ee560c99c3]

        tdf#149170 sfx2: store IsOriginallyLoadedReadOnly() for recent files
        
        This flag stores the user's intent.
        
        (regression from commit 404c51f3664ffd4f7e2c1c8bb8a12ac70954fec2)
        
        Change-Id: I825eaf1323b613e131d058cb9b9ab86363d5f694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134880
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [027d937ac3baa357511f9974d958ef2002c7f60a]

        ofz#47591 avoid OOM
        
        Change-Id: Ic36cae516177d58a2bbf34a1afc2f843cdc431d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Miklos Vajna  <vmiklos@collabora.com>  [56769d3982e6afb075cb6d833662f066437fab6a]

        sw XHTML import: handle non-image, non-RTF objects as clickable images
        
        A pair of XHTML <object> elements is meant to be interpreted as "native
        data" (outer) and "fallback/preview image" (inner). In practice we map
        non-PNG + PNG pairs to images and OLE2 data + PNG pairs to OLE2 embedded
        objects.
        
        This setup works for OLE2 data and images, but XHTML producers can also
        put other raw data to the outer <object> like PDF, DOCX, XLSX, etc.
        These were mapped to ODummyEmbeddedObject, which preserves data, but you
        can't interact with the data.
        
        Fix the lack of interaction by changing how non-OLE2, non-image data is
        handled: map them to images where the image has a URL to the native
        data. This way the OS running Writer can decide how to handle that data.
        
        This required changing some existing tests where the intention was to
        have simple test data for OLE2 data, but that data was not OLE2, so the
        resulting doc model had images, but embedded objects were expected. Such
        tests now have OLE2 data instead.
        
        Change-Id: I0287ce2d9a02904e28cef619ff9f6e1f354d6147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134874
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-24  Michael Stahl  <michael.stahl@allotropia.de>  [0496252c2c7fd2d694c4a73f387ef75e0021de3e]

        sw: fix mysterious layout loop in CppunitTest_sw_uiwriter3 testTdf104649
        
        This didn't happen with master from a week ago on Fedora 35, but happens
        with Monday's master on Fedora 36. Also happens with libreoffice-7-3
        branch.
        
        Fundamentally the problem with the bugdoc is that there are tables in
        footnotes, which aren't really supported and can't split across pages
        like they would need to.
        
        The loop happens because a footnote on page 48 invalidates position of
        its anchor frame 549 on page 45.
        
        This is probably pointless, let's only invalidate if the anchor is on
        the same page (it should be on the same page, but probably the tables in
        other footnotes get in the way).
        
        Change-Id: I87976c7f8b35725bc8e642133bebb396d37ff0be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134877
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c779279f513a43724f5a4eeb003d39ef8cc3057]

        use comphelper::ByteReader in XBufferedStream
        
        to avoid an intermediary buffer
        
        Change-Id: Ic59e701491ac041022ca3e328741f170bb5b7ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Stephan Bergmann  <sbergman@redhat.com>  [5060c5015882b7109c54598c4ea858949beafc43]

        Use o3tl::make_unsigned in some places
        
        ...where a signed and an unsigned value are compared, and the signed value has
        just been proven to be non-negative here
        
        Change-Id: I20600d61a5d59d739bc1bee838c0038e4611aec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134875
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a86818c15a6b4773ddd012db37d55b5204163c24]

        reduce space needed for NameSpaceMap
        
        no need to store the key twice. Also rename related fields and typedefs
        to make the code easier to read.
        
        Change-Id: Ib76dea7fd683d024e8c9d8091d85cfec14829359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134871
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [e4977792c501305502100c0d45b5ca605981008f]

        ofz#47589 can't avoid passing in an output in the general case after all
        
        there's a flip case which assumes the dest buffer is available, so
        the 'ALTERNATE RASTER FORMATS' case of man TIFFRGBAImageGet isn't
        as useful as it looked initially.
        
        This reverts commit e912a446210fdae61be3fc04d20d90488cedcdf6, etc
        
        Change-Id: I09a614a5469c8996f93af103581099242747fd7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [c87b22976112e8a430057af23339b27cbf082eef]

        upgrade harfbuzz to 4.3.0
        
        Change-Id: I8c89e85e1f128782cc36e20593867053c0152474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Miklos Vajna  <vmiklos@collabora.com>  [af353743dfe161e5289a7786a46bf3e8b1de43e3]

        sw content controls, date: add doc model & UNO API
        
        This is meant to be a content control (providing rich text), which also
        has a dropdown-like date picker button.
        
        Add a new Date property to track this type, together with date format
        and date language. This should be enough for the UI to generate a
        correct date string when the file picker is used.
        
        Change-Id: If5d46a804d771e903a688fd73cfaf2d2809b7ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134847
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [912b8fa62f897fb6fdfd760108d87c4dd468b8ee]

        modernize and improve PropertySetInfo
        
        (*) use o3tl::span for the array param, which means we don't need a null
        entry to terminate the array
        (*) use std::unordered_map to speed things up
        (*) mark the array as static at a few more call sites
        
        Change-Id: I05b6cae7552f44459e183ec05cb94e60edb3bfe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134832
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [ec062c472ad58eafbb4392241119d5b53760120c]

        tdf#149186: Table of contents editor not showing buttons in Dutch UI
        
        an alternative approach that doesn't leave things too wide for the
        English UI
        
        Change-Id: I17d87702fcf49e593e87710bde44c1a2cba14a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Luboš Luňák  <l.lunak@collabora.com>  [b3bdb10195cca95b632d0489a16a675b4717754d]

        do not use ubidi_setLine() for text runs
        
        As far as I understand this, the setLine() is meant to be called for
        every line in the paragraph set by setPara(), but
        - our text layout API does not say this in any way, it may be kind of
        assumed that a substring is a line in a paragraph, but it's not a given,
        as we call layout functions also e.g. for underlined parts of the text
        - as I understand it after looking at the source of that function,
        it really just changes processing to work on a subset of the paragraph,
        so all it seems to do is to prepare the whole text once with setPara()
        and then reuse that with repeated calls to setLine(), so it's basically
        just an optimization, but here using setPara() on the entire string
        actually should make it slower by processing parts of the string that
        are not used
        - if the substring contains some control characters that may be
        interpreted as going to the next paragraph (#moz147714-1 does this with
        0x1e record-separator character), then setLine() will fail because
        it will not consider the substring to be in just one paragraph and there
        will be no run detected
        
        Change-Id: Ided1d777f086f7905732b408e845405db0163e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134763
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4ae96a261ccb7bbaaa2f7bc844a6a0e973755d5]

        elide some OUString allocation
        
        Change-Id: I29df28792eb413005a85235fce7295320798ae65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134859
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8f2ccb42014b5eccabd42e5f95190be9e8f4519]

        flatten the maps in SvXMLNamespaceMap
        
        to reduce pointer chasing
        
        Change-Id: I8d581c03f80fa279a93ed23b7116c6f950405b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Heiko Tietze  <tietze.heiko@gmail.com>  [7f2bcfe5f69e31a4166830422db5cd95c5bfaa80]

        Resolves tdf#148815 - Make SAL_NO_QUERYSAVE work for SID_RELOAD
        
        Change-Id: Ic23fd7294d1ec8b06f415ea6744190cf2ffe3ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134858
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [77b72be9548f6e4d06ce8545fafa8a5d47d3e5d2]

        reserve vector in FrameView::WriteUserDataSequence
        
        Change-Id: Ia66fd26d9697467c58b2d17a0e511604795a4316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noelgrandin@gmail.com>  [eb6f62496d7f0c8c477dc17bbcc00d0bfa3ae50b]

        no need to instantiate these services indirectly
        
        Change-Id: I5c798d2b0ac3895963cbb907e4a25fc0f14a9a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3f038db8a61e6c76ff40cd4d0d01f0b16e9378b]

        ConfigFlush can be directly instantiated here
        
        Change-Id: I97934ecf7aafbeec3db9e7149e149a468ae21374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134854
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [19251d0a9690a746e50b24742c5b92c150c434e6]

        m_xRefreshBroadcaster in BaseContainer is dead code
        
        because we are assigning a newly created object to a weak reference,
        which means the newly created object is destroyed just after it is
        created (verified in a debugger).
        
        This was introduced in
            commit e03dd544aec890a6fdf4638380c95104430752a3
            Date:   Wed Jul 20 08:27:45 2005 +0000
            INTEGRATION: CWS fwk18 (1.5.224); FILE MERGED
        2005/07/06 09:29:56 as 1.5.224.1: #123808# update sfx filter cache
        at runtime
        and
            commit 49a28fd6309011ba71c8efe1c37c4a585b06f20f
            Date:   Wed Jul 20 08:27:31 2005 +0000
            INTEGRATION: CWS fwk18 (1.4.224); FILE MERGED
        2005/07/14 12:22:13 as 1.4.224.2: #123808# listen on config to be
        informed about changes
        2005/07/06 09:29:56 as 1.4.224.1: #123808# update sfx filter cache
        at runtime
        
        Change-Id: Ic27cae4a499439009e89b003635067df440d4cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Stephan Bergmann  <sbergman@redhat.com>  [3e21c3c037134054195946720da8548ebb07c57b]

        workdir/UnpackedTarball/libtiff/libtiff/tiff.h is generated
        
        ...and included via vcl/source/filter/itiff/itiff.cxx ->
        workdir/UnpackedTarball/libtiff/libtiff/tiffio.h ->
        workdir/UnpackedTarball/libtiff/libtiff/tiff.h
        
        Change-Id: I717e23946d7d14572c5e9de9f7319d553a76364a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [0935e997d2eb3db04c06504dffa4e59de49a289d]

        avoid some unnecessary work when importing graphic
        
        calling SetLogicRect triggers a bunch of listeners, but that work is
        unnecessary while we are still loading the data
        
        Change-Id: If71448400878a52551a1a3225d1c9cc1052f9867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [55557e6cfb828dccb0af56d4886af73a5b46f052]

        tdf#148168 set built-in gtk search box to search "document name" column
        
        rather than column 0 which is used for icons
        
        Change-Id: Idef015e575fe6a4f76ad0cc67481ca8454a07206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134830
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [4bd3b725cba43c1c2cce2120008d017ac1ebef16]

        We actually want to divide by 257 here
        
        follow the * 257 suggestion at
        https://gitlab.com/libtiff/libtiff/-/merge_requests/336
        
        I did think it looked a tiny bit different than the others
        
        Change-Id: I92306ae22d2acc485a4162160a8c0464a32591d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134844
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Caolán McNamara  <caolanm@redhat.com>  [c16652e1ecf0a8cfcd50f361c199ff7598282b9c]

        move the comment around a bit
        
        Change-Id: I784534285baa5e68f8d8877c6a5fe8c10e5eb429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134843
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [a279887f1299838630b941d9c2aec3bff4922bf2]

        tdf#149198: sw_ooxmlexport16: Add unittest
        
        Change-Id: I62360e7e3f3cbf28119102baf566b4c647103c0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134812
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-24  Julien Nabet  <serval2412@yahoo.fr>  [9b02a65d9253fde66f0c27d3e03134fd66d56371]

        tdf#149186: Table of contents editor not showing buttons in Dutch UI
        
        With gen or kf5 renderings, I noticed this log:
        warn:vcl.layout:710042:710042:vcl/source/window/layout.cxx:288: nExtraSpace went negative, setting to zero for VclBox: modules/swriter/ui/tocentriespage/box2
        
        after some tests, it seems "visible" property was lacking for some items.
        
        Change-Id: Idbdd75790607b1928bfc583004041f7f98688ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134691
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-24  Julien Nabet  <serval2412@yahoo.fr>  [93b4191cefa5062b120c77335776beee34ee4392]

        tdf#149096: don't translate "Get" and "Post" submit methods
        
        Change-Id: I4427618dad0c168642225eaaf828a96e37936d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134718
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-24  offtkp  <parisoplop@gmail.com>  [5f30b778bccbcc417e4ed1da5997650babb942a8]

        tdf#149206: Add EMF test in GraphicDescriptorTest
        
        Add a testDetectEMF test case in GraphicDescriptorTest.cxx that tests
        GraphicDescriptor for EMF detection and that the size metadata were
        fetched.
        
        Change-Id: I6fbe082bea4d5f1e8660b43a923a09bfcdf466b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134845
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [504d61697bac45236da27fba23c7189daf8c171e]

        tdf#149206: sd_import_tests2: Add unittest
        
        Change-Id: I1ff0974d1fa2ae6eb45fc95115fad665eecc45bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134818
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-24  offtkp  <parisoplop@gmail.com>  [063d641f023ac90f49116de105e32e38be72a1af]

        tdf#149206 Set size correctly when loading EMF
        
        Regression fixed, rolled back ImpDetectEMF function
        to version before https://gerrit.libreoffice.org/c/core/+/132456,
        changed type detection from extension checking back to
        magic number checking. Also added a small uncompression
        at the start to keep EMZ support.
        
        Change-Id: Id4489da399a571c4c72ce137f841614f5c0d7bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134703
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Jenkins

2022-05-24  Miklos Vajna  <vmiklos@collabora.com>  [cef860d8fd1c6952bac74053928107d048d16528]

        sw: document SwFltAnchorListener
        
        Change-Id: Ib55d3654e130b9ac42f4664e01d3b2f62b0bae23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134831
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-24  Miklos Vajna  <vmiklos@collabora.com>  [e7fd5af6f65d17cbb3a753544bcab9501e5d1caa]

        sw HTML import: extend list of MIME types recognized as image objects
        
        The HTML import sometimes imports <object> elements as embedded objects
        and sometimes as Writer images.
        
        This MIME-type based approach works great to differentiate plain images
        (with PNG fallback) from real embedded objects, but analysis on some
        larger document corpus pointed out a few missing entries in this
        allow-list.
        
        Fix the problem by adding a 2nd variant for BMP, TIFF and WMF, which
        should also count as image, not object.
        
        This could be improved further in a later commit by getting a full list
        of image MIME types we support from VCL.
        
        Change-Id: Idb2485012e44b4c7db396b5062e7173f3c85495e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134826
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [30f1ef51e59f00aad687b7b1f59592111feb1269]

        elide some OUString allocation
        
        Change-Id: Iacbf1da6cdc77466d9f9da399b5cc17f5a87f0ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c59ede12ff06f7c10670d9ea8a631b25237e9f02]

        this data does not need to be per-object
        
        Change-Id: I7cf9486d80be103c2e9affd805c7bdac46fafe9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134838
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [086e5347dcf71bab57c66afd23218ac08623b7ed]

        elide OUString allocation
        
        Change-Id: I92d487b657c7d67a4301a499ba05b4b285cfed3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134837
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [967fa3b5e50968237d1734a158c209f47cf36295]

        no need to call makeStringAndClear here
        
        we are passing the OUStringBuffer to a method that takes a
        u16string_view, which means makeStringAndClear() is wasted effort
        
        Change-Id: Ib8012f06f18508351d04d5f61cdc032a051faa84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-24  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ac0163be9509d7e3f9761f904e853784f5e92867]

        tdf#149252  adjust vertical/horizontal positioning labels for paragraphs
        
           The Position dialog for objects (shapes, images, frames, OLE objects)
           used "Margin" in the Vertical position dialog and "Paragraph area" in
           the Horizontal position dialog. They refer to the same region, so
           their labels are now unified as "Entire paragraph area", to
           differentiate it from "Paragraph text area", to better specify the
           nature of the region, and to make it more parallel to "Entire page"
           and "Entire frame" options.
        
           Only the labels are changed. No change to the underlying functionality.
        
        Change-Id: Ic999b85c863b0f08da9f2c74ff33f65dd085dda2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134785
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-24  Jim Raykowski  <raykowj@gmail.com>  [f817b3de1aa827d93e2a622735c4d570514f4849]

        tdf#149231 Fix crash on print preview of master
        
        caused by commit 1f9a792a391f0811bbb5f570ad5c84d13312c539.
        
        Change-Id: Iecfa019b04b84bb70b5e04af51f9f786d7cd9fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134846
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [91f408fd94cf38b27dcb26ced9cd6c4e1a9d1cd2]

        external/libtiff: Silence invalid-null-argument
        
        ...during CppunitTest_vcl_filters_test,
        
        > tif_dirread.c:4176:40: runtime error: null pointer passed as argument 2, which is declared to never be null
        > /usr/include/string.h:44:28: note: nonnull attribute specified here
        >  #0 in TIFFReadDirectory at workdir/UnpackedTarball/libtiff/libtiff/tif_dirread.c:4176:17 (instdir/program/libvcllo.so +0xc4dbb6d)
        >  #1 in ImportTiffGraphicImport(SvStream&, Graphic&) at vcl/source/filter/itiff/itiff.cxx:238:14 (instdir/program/libvcllo.so +0xa691680)
        >  #2 in TiffFilterTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:70:12 (workdir/LinkTarget/CppunitTest/libtest_vcl_filters_test.so +0x16dc48)
        >  #3 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:132:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0xd8d5c)
        >  #4 in test::FiltersTest::testDir(rtl::OUString const&, std::basic_string_view<char16_t, std::char_traits<char16_t>>, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:160:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0xdcc71)
        >  #5 in TiffFilterTest::testCVEs() at vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:76:5 (workdir/LinkTarget/CppunitTest/libtest_vcl_filters_test.so +0x16e1c5)
        
        Change-Id: I2de4363ff0f5552e89fd0af84b7b88e38b7bb209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134823
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [38751a8d5e07a448fe56c4602701f567538b139e]

        Removed duplicated include
        
        Change-Id: I66e5f8ec9cb3d2c590bbd23c173f7028c23ce241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134807
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-05-23  Luboš Luňák  <l.lunak@collabora.com>  [091e615912e123f9d714952b61e2d9b8ae48a043]

        don't use glyph subsets with complicated LTR/RTL setups
        
        This should be a more generic solution for problems of some characters
        having neutral direction (spaces, commas, etc.) and ending up with
        different RTL flag depending on exactly what subset of the string
        is wanted (e.g. a space on its own will end up treated as LRT but
        if surrounded by RTL text then it'll be flagged as RTL too).
        Previous attempts 5d02daa5198d5bff9234d5db698e934a5e31c95f
        and 467f2c50a935efff6ff8911e7282ecea535665a3 still left some corner
        cases, and it seems that simply requiring BiDiStrong and matching LTR/RTL
        for this optimization covers the usual cases.
        
        Change-Id: I9824ba7ac52750d0a933e8ad818f809b8520ec87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134824
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [476b1fa176f00ec8128ae72b48dfde11096ed85a]

        Revert "[API CHANGE] call ftruncate instead of ftruncate_by_name"
        
        This reverts commit 1d58828f2285064635ed776e0641e83ee26d34da.
        
        because we need the filename for "sandboxed LibreOffice on OS X" functionality
        
        Change-Id: I598759de0f4bd9e6387df66038fc060e8a08027e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134783
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Caolán McNamara  <caolanm@redhat.com>  [97d90a9da36965f4f50293d50c8b2e5e043d3d9a]

        gtk: fix leak in treeview tooltip
        
        Change-Id: Ib268729abf501da7e9f217ac3c3700cd853dfd43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134815
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2106dff67921ba9d8555bee285f55a4157662d33]

        Fix typos
        
        Change-Id: I53f00e1914283480600dbe84ee96fb38e3cc8e03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134808
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [41bbc62f38b9eac97c03dc5a7e706fa6aaff055c]

        elide allocation of CacheItem when enumerating filters
        
        Change-Id: I44f83485b984548118364dc58cbc3939001506d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [86c95d195dfb1af7511cc0e70a93de9813284855]

        std::unordered_set->o3tl::sorted_vector in TaskManager
        
        avoids repeated allocation
        
        Change-Id: Ie3f380ab2f38314b9c8a51fdcd1985329254f5dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [d850510bae778afb788f7d5d48a418858686ea46]

        use std::move to avoid some object allocation
        
        Change-Id: Id37b54810e7755bd7a4e354c777e0cfdf069080f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [728ff63903083f3bc4321e8fbbb2c1d4b1755a0c]

        Bad hack to silence UBSan nullptr-with-offset
        
        ...since e912a446210fdae61be3fc04d20d90488cedcdf6 "tiff: use more complicated
        apis to need a smaller buffer during read" in CppunitTest_vcl_filters_test,
        
        > [_RUN_____] TiffFilterTest::testCVEs
        [...]
        > tif_getimage.c:998:21: runtime error: applying zero offset to null pointer
        >     #0 0x7f487da9d408 in gtStripContig /workdir/UnpackedTarball/libtiff/libtiff/tif_getimage.c:998:21
        >     #1 0x7f487da97c27 in TIFFRGBAImageGet /workdir/UnpackedTarball/libtiff/libtiff/tif_getimage.c:512:12
        >     #2 0x7f487bd1a56c in ImportTiffGraphicImport(SvStream&, Graphic&) /vcl/source/filter/itiff/itiff.cxx:219:19
        >     #3 0x7f485d820126 in TiffFilterTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) /vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:70:12
        >     #4 0x7f485a49ffa0 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:132:20
        >     #5 0x7f485a4a3a52 in test::FiltersTest::testDir(rtl::OUString const&, std::basic_string_view<char16_t, std::char_traits<char16_t> >, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:157:5
        >     #6 0x7f485d8206f9 in TiffFilterTest::testCVEs() /vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx:76:5
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2406/>).
        
        (If UBSan or some other tool starts to flag this too, we'll probably need to
        pass in a nullptr after all and teach libtiff to treat that case specially and
        not advance it.)
        
        Change-Id: I4477e6c7036c3c5f2782c2c90c612d98fee60468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Julien Nabet  <serval2412@yahoo.fr>  [a14d8acb93717b958598421590831e8a92fde27c]

        README libtiff
        
        Change-Id: Icece0daad46896334cba7dc66435351a347bd2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Caolán McNamara  <caolanm@redhat.com>  [daac48d510a64cfc2ca12a35ee6f54262c8e77dc]

        tiff: reverse row pixels for ORIENTATION_LEFTBOT
        
        and rotate
        
        e.g. novell600797-1.tiff
        
        Change-Id: I03edcc44f86a40f3e005bec1d8b82a0a89cad276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Caolán McNamara  <caolanm@redhat.com>  [95567d6175bccd45f8f954d3b329f73a73a7b8bf]

        crashtesting: we can have negative skew
        
        which is used to fill rows backwards
        
        Change-Id: I07543a622b9566a1a4a8e85c72302545600916c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Miklos Vajna  <vmiklos@collabora.com>  [9a76be53dfb801b754bf55f9d4b8c5f82991a62f]

        sw content controls, picture: add LOK API
        
        - send a LOK_CALLBACK_CONTENT_CONTROL callback with
          action=change-picture when a file picker should be shown
        
        - extend lok::Document::sendContentControlEvent() to be able to replace
          the placeholder with the selected URL
        
        - update gtktiledviewer to work with these
        
        Change-Id: Ifb3750803885fc09fc82905b0cf85b2b8ca06e77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134750
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-23  Michael Weghorn  <m.weghorn@posteo.de>  [95c55b40f7670984ba39447bd695c78ac7d6df1f]

        qt6 configure: Consider more paths to find Qt 6 moc
        
            commit 88d57cf241209ffec9eaed3e523942ab51af6db6
            Date:   Wed Sep 29 11:09:51 2021 +0200
        
                qt6: Add a qt6 VCL plugin
        
        mentioned:
        
        > 1) At least in my self-compiled Qt versions,
        > 'moc' (the meta-object compiler) is located
        > in the 'libexec' subdirectory in 'QT6DIR', while the
        > Qt 5 equivalent is located in the "bin" subdirectory
        > of 'QT5DIR', so the configure.ac check uses the former.
        
        Search for moc in the "libexec" subdirectory of
        all paths in `lib_dir` before trying `$PATH`,
        so e.g. the one provided as `/usr/lib/qt6/libexec/moc`
        by package "qt6-base-dev-tools" in Debian testing is found
        before a Qt 5 version in `$PATH`.
        
        With this change in place, building on Debian testing
        using the system Qt 6 works when building with autogen option
        `--enable-qt6` but no `QT6DIR` set and `/usr/bin/moc` points
        to the Qt 5 version of moc.
        
        Change-Id: I0471c73315224ffab018b350aff8d797a234a905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134814
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-23  Michael Weghorn  <m.weghorn@posteo.de>  [9adc0e9d381e8469ac2fe67d1fb09dfddad225d8]

        qt6 configure: Consider 'qmake6' when searching Qt 6 qmake
        
        Debian testing/unstable provides a `/usr/bin/qmake6`.
        
        Change-Id: I3dba55fc1a2d5667d9fc16aecacf8db6119ced02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134813
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [72582e9fb3d634a28c1466126bbe8e36fc00b446]

        rename osl_getSystemPathFromFileURL_Ex->getSystemPathFromFileURL_Ex
        
        so I can more readily distinguish between functions that are actually in
        the OSL API and functions that are not
        
        Change-Id: Ie113c30ea15d05457633396d56bca08057e38b60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Caolán McNamara  <caolanm@redhat.com>  [ecae51e5f14dad2591d6a15f2e70b4d024fb7985]

        tiled tiff found at rhbz552360-2.tiff
        
        fix up wrt skew and buffer size and the right put function
        
        Change-Id: Iff93876c39213668f38ba341e597741b695b47bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134759
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-23  Hossein  <hossein@libreoffice.org>  [3eda5d345f14f8926358df7b425c452a8a165c7d]

        tdf#149184 DOCX: fix crash removing footer, then saving to doc
        
        When openeing the simplefooter.docx, after removing the footer and
        exporting to .doc, LibreOffice crashes. This regression was
        introduced with 88e6a1bfeac86e0c89d2ff08c908c2b5ae061177 which is
        titled: "DOCX: export hidden (shared) headers/footers".
        
        The current patch fixes this problem by checking to see if the header
        or footer text is there or not.
        
        A unit test is added to avoid this problem in the future. One can run
        the test with:
        
            make CPPUNIT_TEST_NAME="testTdf149184" -sr CppunitTest_sw_uiwriter7
        
        Change-Id: I5586561677b3c490e49b4b10bd987aecdf3fc134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134684
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c046328596e21ce26ed59e215ba2ba5202361e2]

        cache ref to GlobalEventConfig
        
        so we avoid repeated allocation
        
        Change-Id: I9541c52e73878cf515c9159477bd3d2fda9e0078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a1bfe1e3fb298d7d7e2cfd85887d430cce59238]

        elide some OUString allocation
        
        Change-Id: I5f0b9057b86ec98b66b4ce2d6c681b8cb93d49e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [e1b3a6edd4b3400c25aa135d75bd1ad19b279609]

        no need to override 'operator new' in FileHandle_Impl
        
        it's been a while since we had our own allocator
        
        Change-Id: I091c69c94a9592657dd845387530a3fa587a8c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [f546767b4e9bf3de288ea50336cf1e15f1ee7435]

        tdf#149198 Fix previous fix
        
        ...c8d4ae2ad0cfdac770d897e7aca72fbb4a87765f "tdf#149198 Fix use of nullptr".
        Thanks to Mike for spotting my mistake there.
        
        Change-Id: Id5bdd723f32247b0fd7313135f62124d0f18f4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134811
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  AshSinc  <ashleighsinclair86@gmail.com>  [9e7597a1cc92e06d61acf87a8c560de3b4fdabf8]

        tdf#149141 - Added default object creation when drag size too low
        
        Change-Id: Ibbc0fab14c0bcb18a979d6364b04c236c8c5e29e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134499
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-23  AshSinc  <ashleighsinclair86@gmail.com>  [3aa5aa83039b04f1412185e49cad9e3b694d49ca]

        tdf#149141 - Writer - Added default object creation when drag size too low
        
        Patch in case consistency is required for suggested Draw/Impress change here : https://gerrit.libreoffice.org/c/core/+/134499
        
        Change-Id: If4f51109633338620cfe836695214df20c3ec577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134682
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-23  tagezi  <lera.goncharuk@gmail.com>  [69a103b57a39798473ebc48fdad0f696cbd606a6]

        tdf#132293: Removing unused imports from uitests files.
        
        It seems, the most imports were copy-pasted from a file to a new one.
        Additionally, the import block and surrounding area made more readable.
        
        Change-Id: Ie1f31c489cb1e744b5d01d35e3908f1071313e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134413
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-23  tagezi  <lera.goncharuk@gmail.com>  [30a048cb895a3dcdd6048f3c525edd95a1371b91]

        tdf#132293: Removing unused imports from uitests files.
        
        It seems, most of the most imports were copy-pasted from one file
        to a new one.
        Additionally, the import block and surrounding area made more readable.
        
        Change-Id: I8afc5debef6e758d7ad42b1a649f9556d3d7abbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134400
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8b60f77f389a248f98aa45592e6e1045baafbe1]

        rtl_String->OString in DirectoryItem_Impl
        
        Change-Id: Id7b97cbc4160b0d5953c5e378b11a2006292a9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134799
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [6ed597a7dd1da40248236e7a71843c2d76d6173e]

        tdf#140215 Improve the Comment strings in .desktop files
        
        Change-Id: I94bde89ee8cb122ed04f510e25e558240e3029b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134708
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [1e51a325a8e21eb5f900336a0c9e1bd78ed330ab]

        Missing #include <stdint.h> in various external code
        
        ...which is a problem presumably since GCC 13 trunk
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=6f038efd93593da6e661b829d1bd3877e75550f1>
        "libstdc++: Avoid including <cstdint> for std::char_traits".  (All the broken
        C++ code used unqualified uintptr_t etc. rather than std::uintptr_t etc., so I
        deemed it more appropriate to include <stdint.h> rather than <cstdint>.)
        
        Change-Id: Id9dfc383c5986126a425971c4557b90ac45ac963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [c8d4ae2ad0cfdac770d897e7aca72fbb4a87765f]

        tdf#149198 Fix use of nullptr
        
        ...which would have caused std::abort for non-production debug builds since
        4f0c70fb5554325e0cc2129741175bf07de22029 "Avoid calling OString ctor with null
        pointer", and started to erroneously pass a nullptr argument into a
        std::string_view for all kinds of builds with
        af16aa625682b649e8843237652b9246d519cbae "Improve loplugin:stringview"
        
        Change-Id: Iad4d1576ed651a74c0f8b2e8dee3c59f5214accd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134758
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  Noel Grandin  <noelgrandin@gmail.com>  [8d00d5f36454e202586df4e2dafb12c7195b7a1f]

        instantiate Title directly in chart
        
        which simplifies some code
        
        Change-Id: I0c9aa212334a3dedd8a54f8deda6100d93b0be70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134743
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c17712465b07e8a7ebe078b00123965b112f0ac]

        clang-tidy modernize-pass-by-value in jvmaccess
        
        Change-Id: I9a2ef4370136b0f26ae3590f358025e7d89f30d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Tibor Nagy  <nagy.tibor2@nisz.hu>  [f4efaf455136c3a0db8dfd3f1afc0db827192147]

        tdf#66228 PPTX export: fix lost U-shaped connectors
        
        which were replaced with straight connector lines.
        
        The "Line Connector" has no equivalent in OOXML. So far it has
        been saved as a "Straight connector". In most cases, the better
        solution is to change it to "Standard connector", keeping
        the original layout with U-shaped connectors.
        
        Change-Id: I9d6b6174d0556ba2478c6a9837c500b3cc794c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134284
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [6974647815a4bebf57136be9d7cb28d4137e96b3]

        cid#1504543 Silence unhelpful, aggressive UNINIT_CTOR
        
        Change-Id: Ida0c1bfd34ee68968b22579492bce4b137fa8a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134749
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [123d3a9301c90925c23cfb4806d7b0be01b975d6]

        sw: copy grab bags in mail merge
        
        Otherwise formatting may get lost when the result is stored as DOCX.
        
        Change-Id: I62cbeb1fc9f120dd9c424daf5dc0471686715537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134694
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [1b8c42f8b007d690a85676f260b28b44639fc79a]

        sw: avoid ~SwIndexReg() assert in SwFEShell::PastePages()
        
        Change-Id: I5337dc8568255a778d29b676a39c99f72c42486b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134693
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [4d3b750d08d05c475fb38f8b3961696d9cc9882f]

        sw_redlinehide: fix crash in IsMarkHidden() if pointing to table node
        
        This is called during mail merge from documentStartPageNumber()
        and if the document starts with a table, the passed UNO mark will point
        to SwTableNode.
        
        (regression from commit 943d9be770e550d20ca72274fa5e914d1f61e605)
        
        Change-Id: Ic69c12ba0d819eda85de5dde95e35a8071466c2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134692
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [be9a39488420b069ed5c7fd65347b2ff68883e62]

        clang-tidy modernize-pass-by-value in configmgr
        
        Change-Id: If2e69c04e4d72ec6911fb435092275dbfffbf991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [32c43ee75c094ffe3c34f7a713aa252479515ad0]

        starmath: fix real use-after-free detected by GCC 12
        
        In file included from starmath/inc/mathml/iterator.hxx:12,
                         from starmath/source/mathml/iterator.cxx:10:
        In member function ‘SmMlElement* SmMlElement::getParentElement()’,
            inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:43:39,
            inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
        starmath/inc/mathml/element.hxx:263:46: error: pointer ‘pCurrent’ used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free]
          263 |     SmMlElement* getParentElement() { return m_aParentElement; };
              |                                              ^~~~~~~~~~~~~~~~
        In function ‘void mathml::deleteElement(SmMlElement*, void*)’,
            inlined from ‘void mathml::deleteElement(SmMlElement*, void*)’ at starmath/source/mathml/iterator.cxx:19:20,
            inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:65:21,
            inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28:
        starmath/source/mathml/iterator.cxx:19:77: note: call to ‘void operator delete(void*, std::size_t)’ here
           19 | static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete aSmMlElement; }
              |                                                                             ^~~~~~~~~~~~
        
        Change-Id: I09acfe3f7e90bd7f919cfba161f72bdd7a8da70a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134742
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [486991b8ec2b63324c8cf5a26e9091942c24b3d9]

        sw: SwNodeIndex GCC12 spurious -Werror=dangling-pointer=
        
        It doesn't understand that ~SwNodeIndex() will remove the pointer,
        which is obfuscated by over-boostified code.
        
        In member function ‘void SwNodeIndex::RegisterIndex(SwNodes&)’,
            inlined from ‘SwNodeIndex::SwNodeIndex(SwNodes&, SwNodeOffset)’ at sw/inc/ndindex.hxx:54:22,
            inlined from ‘bool SwNodes::InsBoxen(SwTableNode*, SwTableLine*, SwTableBoxFormat*, SwTextFormatColl*, const SfxItemSet*, sal_uInt16, sal_uInt16)’ at sw/source/core/docnode/ndtbl.cxx:301:41:
        sw/inc/ndindex.hxx:37:31: error: storing the address of local variable ‘aEndIdx’ in ‘*this.SwNodes::m_vIndices’ [-Werror=dangling-pointer=]
           37 |             rNodes.m_vIndices = this;
              |             ~~~~~~~~~~~~~~~~~~^~~~~~
        sw/source/core/docnode/ndtbl.cxx: In member function ‘bool SwNodes::InsBoxen(SwTableNode*, SwTableLine*, SwTableBoxFormat*, SwTextFormatColl*, const SfxItemSet*, sal_uInt16, sal_uInt16)’:
        sw/source/core/docnode/ndtbl.cxx:301:17: note: ‘aEndIdx’ declared here
          301 |     SwNodeIndex aEndIdx( *this, nIdxPos );
              |                 ^~~~~~~
        sw/source/core/docnode/ndtbl.cxx:301:17: note: ‘<unknown>’ declared here
        
        Change-Id: I3f24cd8e3e0b1fd0a0943150d3d83d09f2c984fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134741
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [d37486537e7d404b19acdfaec358cb0ad706940c]

        svx: work around GCC12 spurious -Werror=stringop-overflow
        
        /usr/include/c++/12/bits/stl_algobase.h:431:30: error: ‘void*
        __builtin_memcpy(void*, const void*, long unsigned int)’ writing 1 or
        more bytes into a region of size 0 overflows the destination
        [-Werror=stringop-overflow=]
        
        Change-Id: Ib581b5788ff5d363b688000e700a42074c3b78eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134740
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [02ebfb8ed6175934a1985786e6816ecef1bd59f8]

        vcl: GCC12 says fclose() causes -Werror=use-after-free on any use of FILE*
        
        In file included from vcl/inc/unx/cpdmgr.hxx:34,
                         from vcl/unx/generic/printer/cpdmgr.cxx:25:
        In member function ‘size_t psp::FPtrHash::operator()(const FILE*) const’,
            inlined from ‘std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash, _Unused, __cache_hash_code>::__hash_code std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash, _Unused, __cache_hash_code>::_M_hash_code(const _Key&) const [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _ExtractKey = std::__detail::_Select1st; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; bool __cache_hash_code = true]’ at /usr/include/c++/12/bits/hashtable_policy.h:1268:18,
            inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::_M_erase(std::true_type, const key_type&) [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >; _ExtractKey = std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>]’ at /usr/include/c++/12/bits/hashtable.h:2358:43,
            inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::erase(const key_type&) [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >; _ExtractKey = std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>]’ at /usr/include/c++/12/bits/hashtable.h:971:24,
            inlined from ‘std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::size_type std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::erase(const key_type&) [with _Key = _IO_FILE*; _Tp = rtl::OString; _Hash = psp::FPtrHash; _Pred = std::equal_to<_IO_FILE*>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >]’ at /usr/include/c++/12/bits/unordered_map.h:763:26,
            inlined from ‘virtual bool psp::CPDManager::endSpool(const rtl::OUString&, const rtl::OUString&, FILE*, const psp::JobData&, bool, const rtl::OUString&)’ at vcl/unx/generic/printer/cpdmgr.cxx:725:28:
        vcl/inc/unx/cupsmgr.hxx:35:43: error: pointer may be used after ‘int fclose(FILE*)’ [-Werror=use-after-free]
           35 |     { return reinterpret_cast<size_t>(pPtr); }
              |                                           ^
        vcl/unx/generic/printer/cpdmgr.cxx: In member function ‘virtual bool psp::CPDManager::endSpool(const rtl::OUString&, const rtl::OUString&, FILE*, const psp::JobData&, bool, const rtl::OUString&)’:
        vcl/unx/generic/printer/cpdmgr.cxx:695:15: note: call to ‘int fclose(FILE*)’ here
          695 |         fclose( pFile );
              |         ~~~~~~^~~~~~~~~
        
        Change-Id: Ib035f2287649dcf9a2d37bda85ebcf52c6c51aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134739
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [cd4976646dc2e5b28c3328a7fa96361e147b23b9]

        vcl: WhitespaceToSpace() spurious -Werror=maybe-uninitialized
        
        vcl/source/helper/strhelper.cxx:366:9: error: ‘pBuffer[-1]’ may be used uninitialized [-Werror=maybe-uninitialized]
        
        Change-Id: I37250b0790bd9c33eb01c552c8267251bc0026f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134738
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [694db7d3e7be0caf81dd52dba1a865db206ac145]

        svl: spurious GCC12 -Werror=maybe-uninitialized
        
        In file included from svl/source/misc/sharedstringpool.cxx:11:
        In constructor ‘svl::SharedString::SharedString(rtl_uString*, rtl_uString*)’,
            inlined from ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’ at svl/source/misc/sharedstringpool.cxx:129:51:
        include/svl/sharedstring.hxx:56:20: error: ‘pResultUpper’ may be used uninitialized [-Werror=maybe-uninitialized]
           56 |     mpData(pData), mpDataIgnoreCase(pDataIgnoreCase)
              |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        svl/source/misc/sharedstringpool.cxx: In member function ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’:
        svl/source/misc/sharedstringpool.cxx:93:33: note: ‘pResultUpper’ was declared here
           93 |     rtl_uString *pResultLower, *pResultUpper;
              |                                 ^~~~~~~~~~~~
        
        Change-Id: I2171855844c76ad3b2a72c1eca737691ca96fc46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134736
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-23  Luboš Luňák  <l.lunak@collabora.com>  [5d02daa5198d5bff9234d5db698e934a5e31c95f]

        handle RTL space in non-RTL layout in SalLayoutGlyphsCache
        
        Reproduced with tdf#95217-1 on the crashtesting server.
        
        Change-Id: I44dfa762b624ca24a8bd4ce8df03f8c870d4e7c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134755
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-23  Stephan Bergmann  <sbergman@redhat.com>  [de403384f2efb163f8881aa42e08c6ead25291bd]

        Adapt comment
        
        ...after 084b2b068ad6729775f7fa5965429fc5cc3c2ae3 "optimise Any::operator=(&&) a
        little" folded moveAnyInternals into its only remaining call site
        
        Change-Id: I2a9d8a775d601bc0307a3f3a5dfc139c571489ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134751
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [3a1d90f4844f44ceea6b07ef8aa3947aae624825]

        skia: fix GCC12 -Werror=shadow
        
        Change-Id: I0ec8e9d7d54b48281332cb5128d03ac28dad87e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134737
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-23  Michael Stahl  <michael.stahl@allotropia.de>  [5cf5df83aad9c9c97060043727337bdef8af10ec]

        comphelper: -Werror=class-memaccess
        
        Change-Id: Ia38274fac70618902f562fec657ad9cccfcf8cb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134735
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-23  Miklos Vajna  <vmiklos@collabora.com>  [42e88e3b34faf7b5fea116c91aa85a0c4043d359]

        sw: prefix members of SwWW8Shade, WW8Glossary, WW8ListManager and ...
        
        ... sw::util::HdFtDistanceGlue
        
        See tdf#94879 for motivation.
        
        And add a build-time test to ensure that wrtsh.hxx is self-contained.
        
        Change-Id: I493931eeeb8c57264c6f884b48b83881dda6632d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134748
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-23  Heiko Tietze  <tietze.heiko@gmail.com>  [7c2bcac3e6aac31811adede6f466d2125184da4c]

        Resolves tdf#131155 - Keep frequently used options on sort criteria tab
        
        * Row/Column header moved
        * Sort by row/column moved
        * Extra variables removed
        * UI tests adjusted to read/set sort direction and header from first tab
        
        Change-Id: I9fc0406806256f289d52e45b096e392067768eaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130843
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-23  Tünde Tóth  <toth.tunde@nisz.hu>  [aeb8a0076cd5ec2836b3dfc1adffcced432f995f]

        tdf#149176 tdf#149178 fix Save autorecovery information.. option
        
        Autorecovery information was saved in every 10 minutes,
        regardless of the "Save Autorecovery information every" setting.
        
        Change-Id: I1a52da2fa5febb53c270a8db7472e9a8c0e4c426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134642
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-23  Mark Hung  <marklm9@gmail.com>  [f94ba53cd446a80f3d07a5d67740129fde831018]

        tdf#149017 Justify::SpaceDistribution unit tests.
        
        Cerate new unit test cases for core/txtnode/justify.cxx
        and Justify namespace. It implements basic utility to
        convert between KernArray and char width array, and can
        serve for kern array related tests.
        
        Change-Id: I3da172853c6d8aca517247af34b29f712d3b6e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134298
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-23  Michael Weghorn  <m.weghorn@posteo.de>  [123bb44f4a23acad6acb0bdaf43705680d8739c9]

        Extend '-Werror=attributes' workaround to GCC versions < 12.1
        
        Adapt the GCC version check from the workaround introduced
        in
        
            commit 2c6cea672a852b85cfb6d2e313d806f257481417
            Date:   Wed May 18 10:46:55 2022 +0200
        
                Work around bogus -Werror=attributes with old GCC
        
                ...after 9c3c6a6b661ea8f84c1285b07a502de5c98a1495 "Replace OFFSET_OF macro with
                a function template", as seen at
                <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/38076/>,
        
                > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/cppu/source/uno/check.cxx:263:28: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
                >      [[maybe_unused]] Char3 chars;
                >                             ^~~~~
        
                (Not sure which versions of GCC are affected exactly; lets restrict this to
        
        to all versions before 12.1.
        
        My GCC 11.3.0 build on Debian testing failed just the
        same way otherwise.
        
        A `git log --grep=maybe_unused` in the GCC git repo suggests
        that this is no longer necessary from the following
        GCC 12.1 commit [1] on:
        
            commit c0f769fa3114ea852a26d93f0ee3f9595463de0b
            Author: Jason Merrill <jason@redhat.com>
            Date:   Fri Jun 11 16:10:50 2021 -0400
        
                c-family: don't warn for [[maybe_unused]] on data member
        
                The C++17 standard (and C2x) says that [[maybe_unused]] may be applied to a
                non-static data member, so we shouldn't warn about it.  And I don't see a
                reason not to handle a FIELD_DECL the same as any other decl, by setting
                TREE_USED on it.  It doesn't look like anything yet cares about that flag on
                a FIELD_DECL, but setting it shouldn't hurt.
        
                gcc/c-family/ChangeLog:
        
                        * c-attribs.c (handle_unused_attribute): Handle FIELD_DECL.
        
                gcc/testsuite/ChangeLog:
        
                        * g++.dg/ext/attrib62.C: No longer warn.
                        * g++.dg/diagnostic/maybe_unused1.C: New test.
        
                gcc/ChangeLog:
        
                        * doc/extend.texi (unused variable attribute): Applies to
                        structure fields as well.
        
        [1] https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=c0f769fa3114ea852a26d93f0ee3f9595463de0b
        
        Change-Id: I815e4a24da13e0ae66b1dff2941e636c7ebdfd9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134653
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-05-23  Jim Raykowski  <raykowj@gmail.com>  [7ee7e966bd123fc571144b08bc07b1536a2e23e9]

        tdf#144788 follow up fix: Fix null pointer use
        
        Change-Id: I62c3e337a8ec5391c3f18bb42ce8778acd36451b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134747
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-22  Jim Raykowski  <raykowj@gmail.com>  [be0f8c193316087495fd2501b3228207d4095bb5]

        tdf#144788 follow up: fix SwNavigator footnote tracking
        
        Changes incorrect handling for both footnote and endnote tracking
        when either a footnote or an endnote attribute is at the current
        cursor position to handling for only footnote or endnote.
        
        Change-Id: Ib65704ae48298c02cfe557d62d1c002a1859321f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134717
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [d40def608f6482d9457df2e949f278ca466bcfdd]

        for fuzzers add libtiff to common externals, not just tiffuzzer
        
        Change-Id: I747a39a26c446000924a1d48c5d650fac330216e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134746
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [6204336cc7242ff1b0fdc26ccb7f8dd4f362fb78]

        Get make_installer calls to run in parallel
        
        If available, use GNU parallel to run N make_installer.pl scripts in
        parallel, to scale packaging LibreOffice up with the rest of gbuild.
        
        * fallback if no GNU parallel found - run make_installer sequentially
          as before
        * push most of the make_installer.pl input param tweaks from gbuild
          down into a shared call_installer.sh script
        * call gnu parallel with generated number of
          "templ:lang:prodname:ext:pkgfmt:strip-flag" tuples, one for each
          package to build (empty templ for non-windows, to save on cmd line
          length)
        * such that we can run all those in parallel (taking into account
          the build's PARALLELISM parameter)
        * there's still the main package build running epm sequentially for
          umpteen sub-packages from within _one_ make_installer.pl instance, but
          that's much harder to parallelize from inside Perl (so we punt on
          that here)
        
        Change-Id: Ie7d3084ed60d003d587c5e64dc9fb1809b23e409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133957
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [5b74eb7d41bbcf2d35154ae8272f0e71be128b60]

        tdf#131199 add some basic 16bitcielab support
        
        to get that final tiff loadable
        
        Change-Id: Ia772c06521c93ac860e9d3014706d677f16c8d4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [4f0b60d88fb3d7502ae9a820daa31b192cc6234d]

        move fuzzer to libtiff
        
        Change-Id: Ib2a3da65f13a239076981473410a0e3240cab670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134744
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [c5b3f8853751d67c364a91fdeaed3f36cea3179c]

        cid#1504537 silence Dereference after null check
        
        no change in practice because either pDoc or pDocSh and not both
        are set
        
        Change-Id: I1da19bef2a2a5cec700cbc6126f873079efcba88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [25747014cd54d66f55029f67886418b859f9b980]

        cid#1504538 Dereference after null check
        
        and
        
        cid#1504536 Dereference after null check
        
        Change-Id: If727df50e9e375b0ebd30e7537ac3d88ad72dc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [1a9c3c13cb5c652d7bc92618e0f1bebf58ed76c6]

        cid#1504545 Dereference after null check
        
        Change-Id: If23314cca9eec9c4b9cf668945976327184d5690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134730
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [a5d2e06d444b486bb2695c9268681f044f27d599]

        pass ScDocShell by reference in ctor to indicate never initially null
        
        Change-Id: I6b07f734aba06a643b6240562bb3e427e5c1e9ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [5de1567e30d54fde33875d7c8301bf3d36d6f1cd]

        cid#1504539 Dereference before null check
        
        seeing as its always derefed before here, the null check isn't useful
        
        Change-Id: I7c50d357978c7468eec469b4f32601e9b99e07e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [c4a8484bd6eb9c490b7af8c6aa1c25f05a3cfb5e]

        cid#1504532 Dereference after null check
        
        Change-Id: I044e3bfec2af9d6379849b8ee6ce4ecbe637cc35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134727
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [8cdfc82557cf1256aaa3e1e8200d1b2ce9f16608]

        cid#1504534 Dereference before null check
        
        Change-Id: I7deb272cbf7105b78911acb4b17bc3f078913a2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [66d7ed084a676ff7803a3c7672e80d9f7ca0e74e]

        cid#1504540 Dereference before null check
        
        Change-Id: Ia47b6dd5d1524bd377670815a342d0ee478f823e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134725
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [7dcab55d97713b48b003e20590ebd51c77b60391]

        cid#1504542 Dereference before null check
        
        Change-Id: I3a3ee9ddc09d63fb33fd041353399b3aa4f79d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [3d29f5860f3c836d528e9cce7b6096b4ae5a6f7f]

        cid#1504440 move Uninitialized scalar field annotation
        
        Change-Id: Ia147241460c537abea7f6ef3cd32038551c45826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134723
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [4be7c2a2b387f7aca679944728cd268df0907a52]

        cid#1504544 deliberately Uninitialized scalar field
        
        Change-Id: Idbc44ac01787f93fa5af1e5358a70590fa4cc64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134722
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [6245eeeaa10479e1e166cbc65de7152617a2c8e5]

        cid#1504541 Uninitialized scalar field
        
        Change-Id: I1fa061f9713c808bd06933ae9c574e70a1ec0915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134721
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [dc8e257e37e37ece9f59717a1609fc2d52a698b0]

        cid#1504533 silence Uncaught exception
        
        Change-Id: Id2c782e417b673dcc2e2b5170bcaf6b98bef85f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134720
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Caolán McNamara  <caolanm@redhat.com>  [f8523e26040040910ca53485039afcca65fd46ab]

        cid#1504535 Uninitialized scalar field
        
        Change-Id: I8a99a5e5e4ec892c460edb4151554cd071fb54ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134719
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d58828f2285064635ed776e0641e83ee26d34da]

        [API CHANGE] call ftruncate instead of ftruncate_by_name
        
        The actual point of this change is making osl_fileOpen faster by
        avoiding constructing and storing an OString. But that requires changing
        to using ftruncate on the filehandle, which is arguably more
        correct anyway, using the filename to truncate in the presence
        of unlink() is dubious
        
        Change-Id: I8bc5022e1d1afb53fb4e2fd920e43e5daaf74ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134704
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-22  Jim Raykowski  <raykowj@gmail.com>  [671e755aef9c4019bdca2fbbe5e5e6c704954a32]

        tdf#145182 related: fix SwNavigator repositioning on resize
        
        Repositioning on resize began with commit
        ca8f1ff34e291b74068dace619e58c37ef169f88 which is LOK related. The fix
        given in this patch checks if LOK is active before executing the lines
        of code that cause reposition to happen when LOK is not active.
        
        Change-Id: I13e7d289dd7ef1d99966d4f5b47a961b868b1b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131570
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-22  Jim Raykowski  <raykowj@gmail.com>  [bb1d48498c9fdedf8e78344765f6c6eda6f4707c]

        tdf#84502 related: Show keyboard shortcut in sidebar tab bar tab button
        
        tooltip
        
        Change-Id: Ia0d48ac437c6a18c4e1624dd9b154ee7a8514f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134594
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [b6266207b55a7633dc82b02142215757512adfb7]

        tiff: output libtiff error via SAL_WARN for failures
        
        Change-Id: Iff62f8081d5d7b1971940775bd72722f376bf3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134716
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [e6c1e7245ab526411acbe337e3bd655f10e9bf45]

        drop unused hxx files
        
        Change-Id: I68ea314f20b599c181f2ae9f264037918419d15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134715
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [08f757c32fc260c8857c1ff5cd44baf9aa8b8d03]

        clang-tidy modernize-pass-by-value in canvas
        
        Change-Id: Ib6e1b6182d83b09dbf5e2aeb9cf3e4ca11d9f48b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134712
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [098df8583bc8d4a8d0210525f05f69b460386a46]

        ofz#47559 Integer-overflow
        
        setLinearPosX already takes a double so use that type for nOffset,
        use DeviceCoordinate as the types where that is the type of the
        source data
        
        Change-Id: I411d5034a42648bab94d6b8789bbdd172d0cf841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [11e4235930f05906311f7b70444b0a6487d59a47]

        tiff: enable webp
        
        Change-Id: Ifd277fd89393f964817bf58dead53074321252d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134711
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Rene Engelhard  <rene@rene-engelhard.de>  [79f2773115c30278363a778d6cdfb586145abde6]

        fix system libtiff detection
        
        Change-Id: I9cd29a48a0b46bae9d265b502b250709ec8a3247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134710
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [7e06a8adc513c4fd29e3fed037a48126071abc86]

        tiff: add some error checks
        
        Change-Id: I55ca42f637c802bc917eeba5c08cc82074edd523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134697
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b36b225c6a2e73a6a8b7d353e69981a21d4bac77]

        clang-tidy modernize-pass-by-value in binaryurp
        
        Change-Id: I1570ed8ace3e1684ad228efbd8b13d2fe9b0f2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [80fab1529a5680fcad4075e4363924cfb2f7213a]

        clang-tidy modernize-pass-by-value in bridges
        
        Change-Id: I6c52316e46117aacb22a2adcb75841aed834041f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [685eff8c9e6e6097b6f9e365fd6554e10adef063]

        libtiff: enable jpeg and zlib
        
        Change-Id: Ied6ab75342f5cdaadefbff7f75fbe63e9d67e992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [f948108d85a3e7a965e61e22999d29d321acba94]

        explicitly disable some things that might otherwise get enabled
        
        depending on what happens to be installed on the build system
        
        Change-Id: Ic0c3eed721aeba6361aa6da82b467891d24d7557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [e912a446210fdae61be3fc04d20d90488cedcdf6]

        tiff: use more complicated apis to need a smaller buffer during read
        
        while the split alpha persists as a thing
        
        Change-Id: I17b37650e66ae8bd4aa42b953cd39fcfe7ac80ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134696
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [052a6c9e5e2c5e4a4d1e3b3d91ca6464939ebbab]

        elide OUString allocation
        
        Change-Id: I45cc3b8df0c29237b69cab87f0fbb6853776394f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [e59c9be85f8d00dc64c80e21dee91304fe232be2]

        drop old tiff filter
        
        Change-Id: I3bfeae4751cb9173fbe2efdbda531a9a1a491c8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134695
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Caolán McNamara  <caolanm@redhat.com>  [22b50f1937de67e4ad9e692d6964aa5b8d33af7a]

        use libtiff for tiff import
        
        TODO: check testTdf138818 change is acceptable/meaningful
        
        Change-Id: Ia72f2e7ec49a9f8fc23b178fe61cbc3d0e1287c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134647
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d05b8080b25877e94d54576744b68f01ae775380]

        flatten UUIInteractionHandler
        
        no need to allocate these helpers separately
        
        Change-Id: I9a062c689b5c3ecb40e6400cfe9715adcdf3ae31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [eecc113e6f6e51e5e37059235c1069dc9c4c1cc8]

        rtl_String->OString in sal
        
        Change-Id: I259c0dbe56fad2292f5ac0dc8e8f1047ead343c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Luboš Luňák  <l.lunak@collabora.com>  [9f5e5ea0011a8f04fbfc242a199630ab1fbf8c0d]

        update Skia to chrome/m103
        
        Change-Id: I35f1ca3fc703dbf31c68f4b145344b23029a156d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134688
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee37679d446edb82e9a2f848ae35788074cf26c0]

        cheaper to check for null return rather than catch exception
        
        Change-Id: Ifdbcbacc3d1340c77529ccacf4aaebf3dd250350
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [498f464ea7d60698192ec609fa4ee856123814a4]

        cheaper to loop over Sequence than construct SequenceAsHashMap
        
        Change-Id: Idbf9a104677bd0934e56803d96e233f52fc763e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [6e24713c8cb4d2c1aec8ee647c07c6b03de0063a]

        android: Drop 'android.enableJetifier=true'
        
        From the Android Gradle Plugin 7.2.0 release notes [1]:
        
        > Jetifier warning and check in Build Analyzer Build Analyzer now displays
        > a warning if your project's gradle.properties file includes
        > android.enableJetifier=true. This flag was introduced in a previous
        > version of Android Studio to enable AndroidX for libraries that don't
        > support AndroidX natively. However, the library ecosystem has mostly
        > moved to support AndroidX natively and the Jetifier flag is probably no
        > longer needed by your project. Additionally, the flag can lead to slower
        > build performance. If you see this warning, you can run a check within
        > Build Analyzer to confirm if the flag can be removed.
        
        Android Viewer has no dependencides requiring Android Support Libraries,
        so drop the `android.enableJetifier=true` flag.
        
        [1] https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#jetifier-build-analyzer
        
        Change-Id: I6943b2e82e5b226286be288f9ed30944c541eb1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134673
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [b62509e43c355d98b3ef26b1f55045cffcb1f486]

        android: Update Android Gradle Plugin to 7.2.0
        
        ... and gradle to 7.3.3, as suggested by
        Android Studio.
        
        The Android Gradle plugin release notes for 7.2.0 [1]
        mention a new warning in Build Analyzer when
        `android.enableJetifier=true` is set. That will
        be handled in a follow-up commit.
        
        [1] https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#jetifier-build-analyzer
        
        Change-Id: I9427f8b878346edc3c6e30be1d41fcc4dc32540e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134672
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-21  Dennis Francis  <dennis.francis@collabora.com>  [b846fb660a91130aceee52fed11170a95b2f3934]

        lok-calc: new callback for print ranges
        
        With this callback the lok clients can read and draw the print ranges on
        each sheet of the Calc document.
        
        Conflicts:
        	include/LibreOfficeKit/LibreOfficeKitEnums.h
        	libreofficekit/source/gtk/lokdocview.cxx
        
        Change-Id: Ie19351d4420e0f3d4191f6a354ce99ab830aede2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134375
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        (cherry picked from commit 172bc7a8f4eeab907adac077407186fbbd046a77)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134527
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        (cherry picked from commit 29b7b25d454e0a6cd07c00e13fdb83cc8a381583)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134614
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-05-20  Julien Nabet  <serval2412@yahoo.fr>  [a2ffd71f20e14f797f30223fe29b3ac1e92eafdf]

        build libtiff
        
        Change-Id: Id9b6e1355147c3f68b9922db14f1b4904a05c686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [826b536fddfebf9e19efae9dbf3dbd86861c6d74]

        don't waste time on memset when we're just going to overwrite it
        
        Change-Id: Id01b056a28e23c55757b0b4e08a5901c76821b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134677
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6510cbc486867db25d1d772f4a3b0b7b9bb2fc08]

        elide temporary OUStringBuffer in INetURLObject
        
        which requires a version of replaceAt for OUStringBuffer, which I'll put
        in comphelper::string:: for now
        
        Change-Id: I70b319b018e29a7dac26965dd92f6c4f9ea470ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134679
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [443799ad8c0f5a2ae78ca03fb38618a2273682aa]

        fix OWriteStream implementing XUnoTunnel
        
        doh, forgot to return it in the queryInterface in
        
        commit
            62531ec1091c7b3f6a3577889a18234790ec716d
            add ByteWriter to reduce memory copying when writing data
        
        Change-Id: I460388b55ca38962bf60ef6be6a2b108deee6d73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Caolán McNamara  <caolanm@redhat.com>  [c10dc73b46f4009aaf1a048aceedc9d02a8a24a3]

        add libtiff to notices
        
        Change-Id: I02d469848e86ab7ed50c3ba2743be5d89ddb4fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [08e1cdef0ddfd3c88483b084d8e1a28d01980364]

        revert some questionable changes "new loplugin:unnecessary locking"
        
        in commit f2c02331a7dc0a924bbf30cbc279e92621e89590
        
        which, as llunak points out, are questionable
        
        Change-Id: Ifb29429631c12c4f1c0b4da044a4d599592d3642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134660
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [37ce4266d66323f158b20b9e0ec0388209f5e9f6]

        osl::Mutex->std::mutex in DataSupplier
        
        Change-Id: I60fccc5d419d42571e768bd4b4ec5fe14d709896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134676
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce39195e533336ce1482e2be6b1bec2b7f992125]

        vcl: avoid EXCEPTION_INT_DIVIDE_BY_ZERO
        
        See https://crashreport.libreoffice.org/stats/signature/FormattedField::Down()
        or https://crashreport.libreoffice.org/stats/signature/FormattedField::Up()
        
        Change-Id: I30dfb06a1261a48a75b9d9c2380ed78121758ec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134674
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-20  Miklos Vajna  <vmiklos@collabora.com>  [73ed5e36047b6f46b3777bf6f36591ec4babb1f9]

        sw content controls, picture: add insert UI
        
        - handle the picture case in SwWrtShell::InsertContentControl(): insert
          a placeholder bitmap & create content control around the as-char image
        
        - expose this as a new .uno:InsertPictureContentControl command
        
        - add the new uno command to the default & MS-compatible menus
        
        - rename the SwWrtShell::Insert() overload taking a Graphic to make this
          a bit more readable
        
        Change-Id: I289d6b6a9cd622c585b6cf0ec0c91d6b51ad81ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134681
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff0387e726b59e374029d2f635ce00308d99eff6]

        tdf#135843: sd_export_tests-ooxml3: Add unittest for the export part
        
        3faf005a367cbd28077403bf93810bbaf4805851
        "tdf#135843 Implement inside horizontal vertical borders."
        also fixed a problem when exporting to PPTX.
        Before the patch, if attachment from tdf#106011 was exported
        to PPTX and then opened in Powerpoint, the table was
        visible there.
        
        Change-Id: Iaa06a0ab9d6421916eccd4944fd4a8f041046907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134683
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a615eb3f01391f048bee621c431339d0bc5e42ae]

        basegfx: add test for 2D vector classes B2DVector, B2IVector
        
        Change-Id: I300028f63c6222f7a4296aa9bf608acb3fa19dd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134652
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-20  Luboš Luňák  <l.lunak@collabora.com>  [d37e5bc08742de4ea9b0916a799e32540e74cdd1]

        bump up Calc MAXTILEDROW to MAXROW
        
        I.e. no restriction on number of rows for LOK.
        
        Change-Id: I248a70bafe18c68e59f604e33b9456474ab785c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134620
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-20  Luboš Luňák  <l.lunak@collabora.com>  [47e8763114f12fe14e2a8dd94b5a339f614d23bc]

        work around ImplGlyphFallbackLayout() returning garbage fallback
        
        As the comment says, this doesn't make sense to me, and it suggests
        that GetGlyphFallbackFont() is broken. And in case the missing codes
        list was in fact modified by the call, then ignoring the font
        and keeping the modified list meant fallback for those glyphs wasn't
        provided, which was confusing checkGlyphsEqual() in
        SalLayoutGlyphsCache. Restoring the missing codes list will not
        help much will the fallback, as that'll make this loop finding
        the same font, but at least this stops checkGlyphsEqual() assertion
        failures.
        
        I cannot reproduce this locally, only on the crashtesting server,
        by running '--headless --convert-to pdf' with ooo#57685.
        
        Change-Id: I533c776d1e470e6d6afe39a1363f7a203f345981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134655
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-20  Luboš Luňák  <l.lunak@collabora.com>  [5788c3e0a56be9e74900fa64d3e17341b6553c6b]

        remove remnants of hack for tdf#89231
        
        The actual part doing the substitution was removed
        in 47ea13ef8dc8ab9aeded6121845e3ebd1d28b292, so this doesn't really
        do anything.
        
        Change-Id: I47e2e67d6d62bc4279f5efea4b60451dba567ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134654
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-05-20  Miklos Vajna  <vmiklos@collabora.com>  [6a599ff57fb878c07353d93b476706acda6058f3]

        external: update pdfium to 5058
        
        Which started to use require __builtin_is_constant_evaluated(), which
        our baseline doesn't have, so patch that out for now.
        
        Change-Id: Idd1923291a933209d18bb677d011c9353c8f8c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134648
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-20  Luboš Luňák  <l.lunak@collabora.com>  [f937e06c9b33e476039ab9682cffb5a9a645825e]

        remove useless variable
        
        Change-Id: Ie6e95a4d089f3adb65e4f79ae0389eecb220488a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134658
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [ecd4867f99d64f5da6801bb106750bf64307e7ff]

        vcl: extend test to also check the description
        
        Change-Id: I53dbec86254670ca09432a316962cb9e337b286b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134661
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-20  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [918bae0100f2d547a1a6cb9e81a0e742db72b32a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35d09673e7c99c2fe84d0b50ec61133b40663641
          - Drop apparently German-inspired use of hyphens
            
            See core commit 4602a27bc9d6304f1ac7c56fde31c138fe7ad626
            
            Change-Id: I2dcf4722d25f2441e15781ae22cd23e5ad761fe9
            
2022-05-20  Miklos Vajna  <vmiklos@collabora.com>  [68da277559597c52833067c1749323ac38f3364a]

        sw: fix crash in SwHeaderFooterWin::IsEmptyHeaderFooter()
        
        Crashreport signature:
        
        Fatal signal received: SIGSEGV code: 1 for address: 0x0
        program/../program/libswlo.so
                SwPageFrame::GetPageDesc() const
                        sw/source/core/inc/pagefrm.hxx:144
        program/../program/libswlo.so
                SwHeaderFooterWin::IsEmptyHeaderFooter() const
                        sw/source/uibase/docvw/HeaderFooterWin.cxx:403
        program/../program/libswlo.so
                SwHeaderFooterWin::ShowAll(bool)
                        sw/source/uibase/docvw/HeaderFooterWin.cxx:273
        program/../program/libswlo.so
                SwFrameControl::ShowAll(bool)
                        sw/source/uibase/inc/FrameControl.hxx:49
        
        Change-Id: I3c1a6f46c7a15c2ca1a3db69a14d49abbea8c879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134656
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36efd0e460d4916d3bc15df2df8d382b6609d6be]

        Fix typo
        
        Change-Id: I66f23338aaebb9a4ba70f00cbd07f74d2344017e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134669
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-20  Miklos Vajna  <vmiklos@collabora.com>  [22d7cbc0f0c50c59abca7ab5f7db46e4d0e5f86a]

        sw content controls, picture: add DOCX filter
        
        Map Picture UNO property on content controls to:
        
            <w:sdt>
              <w:sdtPr>
                <w:picture/>
            ...
        
        And do the opposite on import.
        
        Change-Id: I5b164f796f194f5fc4bb30d7a30e053e577ed92d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134657
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [084b2b068ad6729775f7fa5965429fc5cc3c2ae3]

        optimise Any::operator=(&&) a little
        
        uno_any_destruct will get called by the other Any anyway, so no need to
        do it ourselves.
        And inline the helper now, since it is only used in the one spot.
        
        Change-Id: If4227ce7e9d8ef83e3440ac1d9fe2579ed3583e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0874486b348f1477d59e161a4d73c5cb56e238f9]

        Document sparkline related classes, functions and structs
        
        No functional change.
        
        Change-Id: I822c6a9d270dc582aaae2900f833843a0d6f8ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134651
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [6d2753da83f6f6a953622163f05263993e7915f5]

        vcl: move bDrawn variable closer to where it is first used in DrawEPS()
        
        Change-Id: I0c11ec2de55121cf7369672e9db1fdc6a3f63770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134002
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2c02331a7dc0a924bbf30cbc279e92621e89590]

        new loplugin:unnecessary locking
        
        off by default, since each warning needs careful inspection
        
        Change-Id: I805c1d1cdde531a1afdc76e87b22f879fc3c9753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [66d8951df3c11ead0b9415eb292c3ae88689edf1]

        sfx2: use natural string sort for sorting in object inspector
        
        Use a natural string sort for all strings in the object inspector
        tree view. This is more useful for properties as those can have
        indices, which are shown as numbers, so having them in natural
        order makes the tree view easier to digest.
        
        Change-Id: I7d036cd755f6595fa302c7a28a005684897f2963
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134541
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [09822cf77cdbe32b03553cd05154100b5f2591d0]

        comphelper: fix natural string compare function + reorganize tests
        
        Natural string compare function doesn't take into account that
        the string can start with a number and in this case it treats it
        like a conventional string compare. This change takes this case
        into account.
        
        This change also refactores the tests for NaturalStringSorter
        class. The previous tet used a mock XBreakIterator and XCollator
        implementations to test the functionallity. This is not needed as
        we can just use a real one instead, which makes the test more
        real as it actually uses a real implementation instead of a mock
        implementation, which could differ. This change removes the mock
        XCollator and XBreakIterator implementations and moves the test
        into a new file - NaturalStringSortTest.cxx
        
        The test is also extended with the new use case where the string
        starts with a number.
        
        Change-Id: I32ea055f914c2947e4d979093b32f56170a61102
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134540
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3d37b6a351aa8ba8f3edee22240f3e4f931903aa]

        tdf#148737 improve tooltip for Arrow Styles icon
        
           Have used "arrowhead" in tooltip in anticipation of
           the intention to move away from using "Arrow Styles"
           in the Line dialog (and possibly to use "arrowhead").
           Also, the dropdown box for this icon uses "Arrowheads",
           so the choice would be consistent and understandable
           in its context, and may make it unnecessary to
           change the tooltip with any future reworking of the
           Line dialog.
        
        Change-Id: Id15bcc35db194e3da0488078ae89cfda57c73f4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133286
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4602a27bc9d6304f1ac7c56fde31c138fe7ad626]

        tdf#149018  "Object" -> "OLE Object" in Menu and Dialog labels
        
             As a step toward internal UI labeling consistency, this patch
             focused on dialogs, menus, toolbars that involve OLE Objects,
             which can be defined as embedded objects that use
             the Properties dialog in sw/uiconfig/swriter/ui/objectdialog.ui.
        
             One reason for the change is to distinguish these objects from the
             generic term "object", which is also used for Shapes and Textboxes.
        
             The label "Object" is changed to "OLE Object", where appropriate,
             which will align the menu and dialog labels with the one that
             appears in Navigator and Toolbar. Also changed "Objects" to
             "OLE objects" for the Statistics field.
        
             Changed "OLE-object" to "OLE Object" - again for consistency.
        
             Changed "Type" tab label to "Position and Size" in Object Dialog,
             to keep consistency with tdf#138844
        
        Change-Id: Iba54c30fd83489631a9be546d6efc9365bdbefd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134186
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [70b00434bad4216aeaed360808e19344de794c9c]

        tdf#149047,tdf#149018 improve label and tooltip of .uno:ObjectMenue
        
           This patch is part of clarifying the meaning of some .unos
           in the Customize dialog (tdf#149047) and also part of
           using "OLE Object" instead of "Object" (when appropriate)
           in the UI (tdf#149018).
            
           Can give a longer tooltip because this .uno is not used
           in toolbars.
        
        Change-Id: I7596442f3842cd83fff8da9a6c3a191e7ffcb486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134444
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [31f4173f9dd06ee2083763d5f8029f08e12e0cd7]

        tdf#149047  add tooltip to uno:InsertObjCtrl and improve label
        
           This .uno provides a dropdown menu, if insertobjectbar.xml
           exists. It is barely used, so have only changed the
           appearance in the toolbar and the Customize menu. Have not
           added a ContextLabel, but might be necessary if used
           in a menu.
        
           The change is made as part of identifying "Objects" in the UI
           as "OLE Objects" (when appropriate, see tdf#149018
        
        Change-Id: Ia6c796e9f88e1731e155390b267aaa30336655e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134443
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0e5f4f3ac15e22cfcf4447704105aaa0d1e241ee]

        tdf#138844  rename "Type" and "Image" tabs in Image Properties dialog
        
            Change the Tab label in Image Properties dialog.
               "Type -> "Position and Size"
        
            To keep consistency in appearance across related dialogs,
            made same change for the Frame dialog in this patch, and
            for Object dialog in
            https://gerrit.libreoffice.org/c/core/+/134186
        
            Change the Tab label in Image Properties dialog.
               "Image -> "Rotation"
        
            Not found in the related dialogs.
        
        Change-Id: I57a3fbd45f84513e55e71896a141201bef000507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134189
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [43ff808c4662e176c7925f93ec51a0fa378bc1f9]

        vcl: a11y: Add test for text alternative value of images when exporting to pdf
        
        Checking tdf#57423, I found that the support for exporting alternative
        test to pdf was extended to all modules ( before it was only supported
        in Writer ) in 2840352ba56a212d191cc16e08378c87672d7b73
        < Enhance tagged PDF export for a11y >.
        
        I'm pretty surprise to see there was no existing test for tagged PDF
        so this one is the first. Killing two birds with one stone
        
        Change-Id: Ia4ca51438f2539bde8edc21e9c7278840e57682e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134649
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-19  Mike Kaganski  <mike.kaganski@collabora.com>  [8231d7957ae04599d7c87bba117f9a53452fcf0f]

        Simplify SmElementsControl
        
        Change-Id: Idcb075a474b440447b8566cc92a8f65bbc77127c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134643
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad5a41da383f34dc4894a21c8468cc3a8519d9b1]

        reserve vector in FilterCache::getMatchingItemsByProps
        
        Change-Id: Ic996b2d2e72c4aebc889d8c2a921b77c7c492276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [61c47d50284e2ac45bfb1641b7f79a350bfaad5a]

        optimise NumberedCollection::impl_searchFreeNumber some more
        
        Change-Id: I3740bb4f425020eb420fa6217b7c1373befa7e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [62531ec1091c7b3f6a3577889a18234790ec716d]

        add ByteWriter to reduce memory copying when writing data
        
        similarly to ByteReader
        
        move both of them down to comphelper, since we want to use it from
        comphelper, and comphelper is "below" unotools in the module dependency
        graph
        
        Change-Id: Ic98fa2268e125fd8e4378fb899ad5f97de721713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Michael Stahl  <michael.stahl@allotropia.de>  [5eb25f6a7ecb215f7bc81116cd930c1dec645e8d]

        svx: fix double-free if SvxShape of SwDrawVirtObj is disposed
        
        First SvxShape::dispose() deletes it, then ~SwDrawFrameFormat() via
        ~SwDrawContact() calls SwDrawContact::RemoveAllVirtObjs() and deletes it
        again.
        
        Back in 2009, CWS dba32 (60698c8a619f219129dbeac7da1f962f3fa63f6a)
        added this OSL_ENSURE, let's actually try to fix this now.
        
        Change-Id: I5c391aa425aa75fb87cecccbf9e41c9f90196f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134609
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-05-19  Michael Stahl  <michael.stahl@allotropia.de>  [288ad999090d3f88d87f52ff9b292f473f869601]

        sw_fieldmarkhide: fix wrong handling of SwInsText for fieldmarks
        
        For redlines, typically DocumentContentOperationsManager::InsertString()
        will insert text, and it explicitly removes any redlines on the text
        that has been inserted, hence it is always visible - so effectively the
        sw::MergedPara is updated correctly.
        
        However for fieldmarks the situation is different, if the insertion
        happens inside of the part that is hidden in the layout, then it must
        not be inserted into the sw::MergedPara.
        
        Try to figure out which part(s) of a fieldmark the insertion position is
        in and ignore the inserted text as appropriate in
        SwTextFrame::SwClientNotify().
        
        Change-Id: Ic5066b20e9609f50438ca64ac7d2cbd09baeef23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134611
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-19  Michael Stahl  <michael.stahl@allotropia.de>  [2a813483cdbfb458ce62e8d9bdcf2506c0ed02a9]

        sw: fix assert in SwModule::Notify()
        
        Apparently it happens when loading a 0-byte file that the
        SfxObjectShell is still in IsLoading() stage when close() is called.
        
        This then causes the SfxEventHintId::LoadFinished event to be emitted
        during close(), which is not a situation the assert was intended for.
        
        Change-Id: I60a260ca1c1e6cbf9502832ba6622de2628763e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134610
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-19  Stephan Bergmann  <sbergman@redhat.com>  [d34a43701d2bdd7c006497904e962d09eb31ac58]

        loplugin:redundantcast
        
        Change-Id: I1d9bebc5bc0b32e71694915070a8770b3ca601c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134606
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-19  Mark Hung  <marklm9@gmail.com>  [4122d2b96f98f3b7b7332f6c1b047e03d0744f95]

        remove using namespace css in justify.hxx.
        
        Change-Id: I22b582ed88d43ef5299443914dd28b8db61d1b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134639
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-19  Miklos Vajna  <vmiklos@collabora.com>  [81ce15c466cda946ae94f38904215f24555021ad]

        sw content controls, picture: add ODT filter
        
        Map Picture UNO property on content controls to:
        
        <loext:content-control loext:picture="...">
        
        And do the opposite on import.
        
        Change-Id: I47c3d04c505ba94da958d5d6b6b2c883236afc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134595
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-19  Miklos Vajna  <vmiklos@collabora.com>  [e9bee595fdff989b78abb3ebf27efbe9af543eca]

        sw content controls, dropdown: disable NOP buttons in the property dialog
        
        Rename, delete, move up & move down does nothing initially, disable the
        buttons when their event handler would just do an early return to make
        this less confusing.
        
        Change-Id: I4cfb9750d07b4686440c05901ef72e8ce4de961e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134538
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [8167859a27ecaf37565ebafd004476fd59f32701]

        follow org.freedesktop.appearance.color-scheme setting
        
        Change-Id: Id26d01fd19cc3ee12c0e14b785b3a5149d22baf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134553
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [0e10b846746e0a4861c42422c3bc9dd381af94e3]

        icon-theme not dynamically changing to match desktop if set to 'auto'
        
        Change-Id: Id5700cff1000fe4b6df6e73c1ce9ff4f206e0a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4e0f7978d5e00cdfa60548476db0bb21d08dace8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3b76b5e8d644176704c4619304278869ae57127
          - tdf#141474 Cdbl, Cint, Clng, Csng accept keyword arguments
            
            - expression argument uses english number notation
            - numbers are rendered according to LibO language settings
            
            Change-Id: I2d988e4d151223ea3fa4a3622300bbeab567a1fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132389
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [5447cbd11a4aba6a0de3f379107655d3f94b838e]

        tdf#124820: sc_uicalc: Add unittest
        
        Change-Id: Ib5c5ce333d9bc1b436454aae1f181e4f1ec73b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134637
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cafa5a378bd18b7136aa178a267e3f5e386964a]

        reserve vector in StgCache::Commit()
        
        Change-Id: I7d1253c9c8bba5801f942cb79f63d56d26481c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0a035d20f2f2f52c3d6f6b216ea3cd068ea2baa]

        fix location of #include
        
        after
            commit 343eed477ee7b55aa450bbc2aee6786dc0d9a071
            clang-tidy modernize-pass-by-value in o3tl
        
        Change-Id: I1800c0ba63abb0862b8c9aef185ebdf416245f3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [0bd22c4fa1d5b0eac92678d5adec54cdc85f913e]

        uitest: sc: Rename UItest and extend it
        
        The test was added in 6af4c1d097dfba897e305a1e57d1e920f36ce264
        "tdf#123877 sc XLSX: don't freeze during saving recovery"
        Hoewever, as discussed in https://gerrit.libreoffice.org/c/core/+/134409
        the UItest doesn't cover the fix itself but a regression introduced
        in the first version of the fix, thus, remove the reference
        to tdf#123877 in the test.
        
        I've also extended the test to check the document can be saved when
        the password is introduced to the retry password dialog
        
        Finally, I replaced the sample file by the minimal example added
        by Gabor to https://bugs.documentfoundation.org/show_bug.cgi?id=123877
        
        Change-Id: I2242ebd36072ce147de7eb9fc3d735298ac476b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134607
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-19  Miklos Vajna  <vmiklos@collabora.com>  [b213abcb77e19fa5d22af45c7ecd17c8a63af554]

        sw content controls, picture: replace placeholder image on click
        
        Previous content control types (rich text, checkbox, dropdown) had the
        cursor somewhere in the content control and click selected the content
        control in the placeholder case.
        
        The picture case is somewhat different: the content control has a single
        as-char image, and by the time SwWrtShell::GotoContentControl() is
        invoked, the picture frame is already selected.
        
        All we have to do here is to trigger the file picker to select a
        replacement and then insert that image to replace the already selected
        frame's bitmap.
        
        Change-Id: Id3ad94ed8f7e13b0ebc2f57327bb8c0b1e374a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134511
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-19  Stephan Bergmann  <sbergman@redhat.com>  [85d15cfaf9b0665d907e099d6588dea0ced556ff]

        No need to cast to char here
        
        ...when comparing some unsigned values against ordinary character literals
        encoding characters from the basic execution character set (which are guaranteed
        to have non-negative values regardless of the signed-ness of plain char, cf.
        C++17 [lex.charset]/3 "For each basic execution character set, the values of the
        members shall be non-negative")
        
        Change-Id: I2928ad81406d117e7660f2b6f122051341c3954f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134605
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8454627bd058a2d4166c4de3bd0572435c44178]

        use the std::function type for this lambda to prevent allocation
        
        other std::function will heap allocate
        
        Change-Id: Ia1fdb20142613e757fbdc6a4e133b530c6cd3682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8901242b249dacd9fb154ec12628d73562d89f79]

        the size table in MathType can be compile-time data
        
        Change-Id: Ie0769509e38d3414bf227d8d2b7248461bc41aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [d404f6c8b28bc9b298cd618ef6c0dd6d755bdc17]

        merge the g_bus_get_sync calls
        
        Change-Id: I320feb6673f18d6d8d9c5afa9ab602b9405ec581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134604
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [02f53bd61222d7999b847a22fd24d65195f129e5]

        tdf#148132: Revert "n#758883 dmapper: paragraph-level..."
        
        Seems original problem is no longer reprodicible with recent builds
        but ovewriting of numbering style params with inline values leads
        to another problems.
        
        Removing this mechanics do some impact on RTF filter: it tries to
        modify numbering styles, so this was also corrected. It is not ideal
        yet but looks better in support numbering char properties different
        from paragraph ones.
        
        This reverts commit 2123ede032ca64f696ef54af4ad3238974ca2b5d.
        
        Change-Id: If8c79d6191de13b2f09c128b59d17efcfdb1a4ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133877
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-19  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [5648363e8f70cd95b00db62f91effb7eb1385ac9]

        tdf#148720 sw DOCX: fix jumbled group textbox regression
        
        Left-aligned group shape was synced to the textbox, resulting
        jumbled positions after DOCX export/import. To fix it,
        set horizontal orientation of the textbox back to NONE.
        
        Regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
        "tdf#143574 OOXML export/import of textboxes in group shapes".
        
        Change-Id: I02ee79862344f3495846091e3eef27c24d8ef162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134149
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-19  Julien Nabet  <serval2412@yahoo.fr>  [1c25d22bfa072eb78da8930a3877f37a70ff707b]

        Simplify an "ImportGraphic" method by removing useless pExtHeader (WmfExternal)
        
        Change-Id: I2916610e08c3157e0438ec90592fb5b8f921cc24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134574
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Jenkins

2022-05-19  Tünde Tóth  <toth.tunde@nisz.hu>  [d4ab6a4693c0f3147b086173d5a9787f1f0eee34]

        tdf#148923 PPTX import: fix incorrect image in media file
        
        Linked media file was imported with incorrect image,
        if the Impress couldn't play the media file.
        
        Regression from commit 9564747d2fd5d2c859a359dd7fa6242c6859c0d7
        (tdf#53970 PPTX: fix import of linked media files).
        
        Change-Id: Ib277a61e83c3794376d2c090b7f742707e779832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134394
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [30ed714415eb6a5f200f893afa34b9d274ae8d1f]

        tdf#141186 ensure child of collapsed expander is not mapped
        
        If the expander is initially collapsed then when mapped all its children
        are mapped too.
        
        If they are mapped then the mnemonics of the children are taken into
        account on shortcuts and non-visible children in a collapsed expander
        can be triggered which is confusing.
        
        If the expander is expanded and collapsed the child is unmapped
        and the problem doesn't occur.
        
        So to avoid the problem of an initially collapsed expander, listen to
        the map event and if the expander is mapped but collapsed then unmap the
        child of the expander.
        
        Change-Id: Ib4c7a704295b338230357c4c4102a3692f8a9707
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [48ecbe9f7b9e324e9acc544c9ad4121d30a232d7]

        tdf#50400 show an explanatory label if ascii-only password is required
        
        Change-Id: Ib0e3d07e29d56e9782b4b9d215eab4d743158a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Caolán McNamara  <caolanm@redhat.com>  [9697c3d8c8a82602b686e622f8e3a7fe41b8d7a8]

        add a static role to minlenft message
        
        Change-Id: I175c2f13908dd0e4fa40f73f8ef4349cfd9737d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [60addb6e864e1e8eb6c4ea7bb5be04a94a1ea7fb]

        clang-tidy modernize-pass-by-value in i18nutil
        
        Change-Id: Ia0457c81ee1da2a88a8238a1a1d65354c1b639bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8bfdbf5b7474596fe1d7d3318920c9a36f630201]

        HyphenatedWord and PossibleHyphens do not need locking
        
        they never modify any local (or global) state
        
        Change-Id: Ifcfb4f6bb30b1f21e61c5ffaeaad0d0292242760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1dc27fef899ff6cd70873cd945d5312a53e1b3a]

        add utl::ByteReader pure class
        
        which lets us skip the inefficiency of needing an extra buffer when
        reading via XInputStream
        
        Change-Id: Ic5334b7d11ea6a57bc1800f508fc69611a053af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134348
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-19  Miklos Vajna  <vmiklos@collabora.com>  [2589f8a155d00b22078607ddd0229d155a394f3a]

        sd theme: add UI (area dialog) for shape fill color effects
        
        SvxColorTabPage::aCurrentColor already had these effects and
        XFillColorItem already had a way to store the effects, just connect them
        in SvxColorTabPage::FillItemSet().
        
        Change-Id: Ie3f6c1916d2cfa3f26732e105b9bae101d70fc12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134552
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [8a62f0a2124299709e3cce0463cc6ac2c2a9b12c]

        registry: fix some documentation
        
        Change-Id: I8fb21bf57a238fef2b87a124a9e43ff64873d797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128169
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a353f633ec029fc5c7cdc8062aefb6f979265a9e]

        chart2: simplify sheet indices constants for trendline calc. test
        
        Change-Id: I3ec16c33446d20b6d795c5950ceb882ff78fb029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134382
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-19  Luboš Luňák  <l.lunak@collabora.com>  [2e86718626a07e1656661df3ad69a64848bf4614]

        don't allocate unnecessary columns when inserting a row
        
        Change-Id: I616ef20dc1295ce17c4877ff367815bb6a90b7a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134547
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-19  Luboš Luňák  <l.lunak@collabora.com>  [141519233b16353c4998bb826fab11d17dbaf6a3]

        actually insert the column(s) in ScTable::InsertCol()
        
        This was broken if the all the columns weren't allocated, since
        at least in the full-column mode it was swapping the last empty
        columns in the place of the new ones, but without all columns
        allocated there possibly weren't last empty columns, so it was
        instead swapping in last data columns.
        
        Change-Id: I21552f0eb296b0df5507677510a8b85fccb1ae5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134546
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-19  Luboš Luňák  <l.lunak@collabora.com>  [f3e1ebd309a967d3bb06a7e0fe9b501d1faa124b]

        ScTable::TestInsertRow() does not need to allocate all columns
        
        Change-Id: Ic213997edf6838282a38e444a638713a72397fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134545
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-18  Mike Kaganski  <mike.kaganski@collabora.com>  [c061d3cee60af8aa5e9aa924df0f38248d91b777]

        OutputDevice::GetBitmap(Ex) takes logical size, not pixel
        
        Change-Id: Id882cab9bb913c33bf586d278eb94c63636403c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134554
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e39ea45caa3712ae2ff077203ef8aef0e16fe41a]

        tdf#105972: pdf form: export date fields as date type
        
        using AFDate_FormatEx which allows to set a custom format
        
        Change-Id: I38839965423794a0278b783c39c612c361a90eea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134543
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [955fd1c534c061b3b6992dfe034b62b46ee2e844]

        tdf#149106 Remove RenamePrgFolder and RemovePrgFolder custom msi actions
        
        This duplicates MSI functionality - if a folder cannot be written,
        MSI should request a reboot automatically.
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=149106#c17 for details.
        
        Change-Id: I65f295ff6e3bb22afc616feb2ba529413f3e24c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134513
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2022-05-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [33339778c83f2e2d06e302f392d3ae36ee886e8f]

        tdf#99708 Make sure to get the sanitized value
        
        Follow-up to d0cacf09a1105d89bf3df84b18623d790e3aeb82
        
        Change-Id: Iaf1f755b5dcf172d781fc5884fdba4c891b6b1a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134508
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-05-18  Julien Nabet  <serval2412@yahoo.fr>  [602299b92b7452fd47303c4de8945af2725fb255]

        Remove 1 ImportGraphic method
        
        and replace its only use in Shape::renderDiagramToGraphic (oox/source/drawingml/shape.cxx)
        by an existing one.
        
        It became quite useless since 2876a0f79f94cdd139cc8fa40669acde9674bf8c (2020/03/03)
        graphic: remove preview when importing with GraphicFilter
        
        Change-Id: Iec3b13d85297bbe7cbfefe91a2a88e33e53d506b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134503
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [825aeb04e6c45d0ba8ef1bd08e7ade297e9f5361]

        clang-tidy modernize-pass-by-value in linguistic
        
        Change-Id: Ia5fc81ed6e6e060d62e5ff42dccb06e36774a65c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134534
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6b12ba07be44099725b722c8d86227d7ec79885f]

        Fix typo
        
        Change-Id: I476e2eb0769a542ca17b440fa98838f39a12efcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134467
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [26a6c2affaf398f236716791cc1f08f36e4cb240]

        Fix typos
        
        Change-Id: Ie90f36439bb6ca23c45d1b75494ec1955b35513f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134531
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [75b72f5652b9067eee24b1dd76c9076fd9317e28]

        no need to take a lock when returning static data
        
        Change-Id: I8d836c4a919056e8b600549f82b0d5dee9ab1a47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f25d34d652de14959b5eebed8462225b43e408c]

        clang-tidy modernize-pass-by-value in idl/idlc
        
        Change-Id: Iccd18eb394564d3ba90c395725923c559b2b81e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [dfa53b3a69dda7eafc1c3573d5d20cd1b29c77c0]

        elide some OUString allocation in SvxNumberType::GetNumStr
        
        Change-Id: Ia552796cfe99e7886f4b716e717643269b570c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [52112a1b8c778bf94534537978a36ba82d7cdf6c]

        DicEntry doesn't need locking
        
        it never modifies state
        
        Change-Id: I040ba1bff6ea0567b13bf9d06150caefdcdaa522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ffedca8f3751363b406ad5cadfe9ad8b5361560]

        osl::Mutex->std::mutex in SystemDependentDataBuffer
        
        Change-Id: I3fcd1671195c65d370c4d27040c698b93591678d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4743a32b4f991c57e4b8a66adf035b1808ca793a]

        only need to create the folder for temp files once
        
        Change-Id: I805203dc51ca85515150fe0f28fc6464c45453c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4bd95a0d5c962cc0bb8e90c32300c69ae8e92c1d]

        tdf#105972: pdf form: export time fields as time type
        
        using AFTime_FormatEx which allows to set a custom format
        
        Change-Id: I2d30d9d8340782ed9ad53eb43e1f65728f926b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134510
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-18  Caolán McNamara  <caolanm@redhat.com>  [037cae112958be3894e734d308f5f4b468a2d710]

        resave with latest glade
        
        Change-Id: Ib6b221a9264d4563e0cdd41246871c7c96cc0e01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Caolán McNamara  <caolanm@redhat.com>  [9a474985387fabeed6814e1b69cd2b71a3289020]

        Related: tdf#50400 restrict "confirm" to same rules as "password"
        
        Change-Id: Idb8946e3d737557d2c05941dcf2be001a04cca2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134522
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Luboš Luňák  <l.lunak@collabora.com>  [11a626139a4a44422bb9eebe1cc7ef6f36b75276]

        silence coverity warnings
        
        Those fields are meant to be uninitialized by the ctor. And if they get
        used by mistake, I'd prefer to hear that from e.g. Valgrind rather
        than cover it up with some dummy default value.
        
        Change-Id: Ide57f84e9dc0fcc8c7395af99e216c7626d50913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134512
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-18  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [198381eb32edcc3e82d0f23df65f0804a08b44e6]

        tdf#148455 docx import/export: improvements to lvlOverride
        
        On save LO was just emitting w:lvlOverride to actual level
        where override does happen. But MS Word won't accept override
        for next level if there are no overrides for previous ones.
        
        For example, if we are overriding level 3 we should also emit
        empty lvlOverride for levels 0-2.
        
        Provided fix did cause some problems on DOCX import: overrides
        were applied to current level, but in this context current !=
        actual level where override did happen.
        
        Change-Id: Ia00dd9a5990f7f122027e8126f411642c32da189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134411
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [75918e709a6d0e2b94b5e4fd9c2eb248ef912e00]

        clang-tidy modernize-pass-by-value in unoidl
        
        Change-Id: Ibeb6aa656d6ed8b8ba78e800c9e28ba63ec0ec40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Mark Hung  <marklm9@gmail.com>  [f8560e09006cec5cc6ef26ccbf4f21aa28c22ac3]

        tdf#149017 fix space distribution in SwFntObj::DrawText()
        
        - Fix logic problem for the last element.
        - Some glyphs may be made of many sal_Unicode ( ex. Unicode IVS ),
          take care ( fix ) of the following case
        a) 1 as the second glyph
        b) n-1 as the previous glyph.
        c) nCnt-1 as the last glyph.
        - Move the code to justify.cxx and its own namespace.
        
        Change-Id: Ice2236a54e8290a489fb2d887a326ccc4768213e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134243
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [343eed477ee7b55aa450bbc2aee6786dc0d9a071]

        clang-tidy modernize-pass-by-value in o3tl
        
        Change-Id: I420e023aa6bad3c960a9ec4c52f09b51cdd5ff6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [225328b1e3994fcd6b293f007fee10c27e98291e]

        clang-tidy modernize-pass-by-value in codemaker
        
        Change-Id: I2bd9c4c8ced5f0edb9dbf560fe0ed126b9233c26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134519
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-18  Stephan Bergmann  <sbergman@redhat.com>  [2c6cea672a852b85cfb6d2e313d806f257481417]

        Work around bogus -Werror=attributes with old GCC
        
        ...after 9c3c6a6b661ea8f84c1285b07a502de5c98a1495 "Replace OFFSET_OF macro with
        a function template", as seen at
        <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/38076/>,
        
        > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/cppu/source/uno/check.cxx:263:28: error: ‘maybe_unused’ attribute ignored [-Werror=attributes]
        >      [[maybe_unused]] Char3 chars;
        >                             ^~~~~
        
        (Not sure which versions of GCC are affected exactly; lets restrict this to
        GCC 7 for now.)
        
        Change-Id: I28ec8914b60c98dce769ad40ef4141aec4960aa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134509
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-18  Stephan Bergmann  <sbergman@redhat.com>  [41a967af06a9584a997e11079c3c931d34158c09]

        Extend loplugin:redundantcast to trivial reinterpret_cast from T to itself
        
        Change-Id: I7c0be7b435d6b5f97bdd40484023584146638d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134506
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-18  Stephan Bergmann  <sbergman@redhat.com>  [1b6ecb1dc544b7a462948a1c85d4bfc6f08865b8]

        Avoid uninitialized vcl::EditWidget::PrependCurrencySymbol
        
        ...causing UBSan
        
        > /vcl/source/gdi/pdfwriter_impl.cxx:11017:53: runtime error: load of value 190, which is not a valid value for type 'bool'
        >     #0 0x7efed21c891b in vcl::PDFWriterImpl::createControl(vcl::PDFWriter::AnyWidget const&, int) /vcl/source/gdi/pdfwriter_impl.cxx:11017:53
        >     #1 0x7efed205c76b in vcl::PDFWriter::CreateControl(vcl::PDFWriter::AnyWidget const&) /vcl/source/gdi/pdfwriter.cxx:438:29
        >     #2 0x7efed1f5dc60 in vcl::PageSyncData::PlaySyncPageAct(vcl::PDFWriter&, unsigned int&, GDIMetaFile const&, vcl::PDFExtOutDevData const&) /vcl/source/gdi/pdfextoutdevdata.cxx:394:29
        >     #3 0x7efed1f64eac in vcl::PDFExtOutDevData::PlaySyncPageAct(vcl::PDFWriter&, unsigned int&, GDIMetaFile const&) /vcl/source/gdi/pdfextoutdevdata.cxx:612:28
        >     #4 0x7efed206486e in vcl::PDFWriterImpl::playMetafile(GDIMetaFile const&, vcl::PDFExtOutDevData*, vcl::PDFWriter::PlayMetafileContext const&, VirtualDevice*) /vcl/source/gdi/pdfwriter_impl2.cxx:288:48
        [...]
        
        during CppunitTest_vcl_pdfexport
        (<https://ci.libreoffice.org/job/lo_ubsan/2402/>)
        
        Change-Id: I95c6e58e1a4204ba828db29e3c1429285bae27ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134505
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-05-18  Mark Hung  <marklm9@gmail.com>  [beb3b39ddf04d90b4c18cb15c35dccac35f4dcb7]

        fix CID#1504441 for SwFntObj.
        
        Change-Id: Ia5dfb07e2c3e980f6fd8664f648ef96aa2c0d345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Mark Hung  <marklm9@gmail.com>  [6e9d183d4c1107d15dd0d5941cdca79cb4731693]

        fix CID#1504438 for ImplFontMetricData
        
        Change-Id: I037ad60c4bc2189ba6e93648ba9e168c6242efe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Caolán McNamara  <caolanm@redhat.com>  [7494eb0a847384599c88b66a159073c3ba056ac5]

        GtkCellRendererText 'text" attrib is the index of the text into the model
        
        and we need a trailing "id" column for [s|g]et_id which is assumed to exist
        
        Change-Id: Icb32e78ac76443cc15ca70f2e9248b92791b7890
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Caolán McNamara  <caolanm@redhat.com>  [35ab9969852dc2f95dde9f9ed5e12e9af9744c68]

        resave with latest glade
        
        Change-Id: Ib7e3534000d46ec128590494389ac5ba51a94702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134477
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-18  Stephan Bergmann  <sbergman@redhat.com>  [9c3c6a6b661ea8f84c1285b07a502de5c98a1495]

        Replace OFFSET_OF macro with a function template
        
        (in preparation of extending loplugin:redundantcast to more reinterpret_cast
        scenarios, which would have caused a false positive here).  Required a tweak to
        loplugin:fakebool (as the relevant reinterpret_cast to silence some occurrences
        is no longer seen "inline" now), and the heuristics of loplugin:unused no longer
        worked (also because of the now-hidden reinterpret_cast'ing), but adding a
        maybe_unused attribute looks better than tweaking that plugin's heuristics even
        further.
        
        Change-Id: Iead1a9b31983918cf8f3b0e6c727c0081437c6d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134504
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-18  Stephan Bergmann  <sbergman@redhat.com>  [f8512cf3a8aabdba60c2994bed71c845efc6a25e]

        Adapt flatpak build to recently introduced dependencies
        
        Change-Id: I48ffef665514378740b4146e2368f65930f74270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134502
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-18  Miklos Vajna  <vmiklos@collabora.com>  [a394b45125c6ebaae5d5dcc2154f6408e9a32d92]

        external: update libxmlsec to 1.2.34
        
        See <https://www.aleksey.com/pipermail/xmlsec/2022/010468.html> for
        details.
        
        Change-Id: Ia1f574caa1624cd323cdae8135cac26b13921de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134489
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [6fc3ec85a32cd70216b4bbf21e479b4fc32a38dc]

        tdf#137639 qt: UTF-16-encode mime data for "text/plain;charset=utf-16"
        
        Return a `QVariant` from a `QByteArray` containing the UTF-16-encoded
        characters when mime data for mime type "text/plain;charset=utf-16"
        is requested in `QtMimeData::retrieveData`, rather than
        a `QVariant` created from a a `QString`, to ensure that UTF-16
        encoded data is actually used in the end.
        
        While `QString` uses UTF-16 encoding itself,
        `QMimeDataPrivate::retrieveTypedData` from the Qt library
        would convert the retrieved `QString` data to UTF-8 [1],
        resulting in a mismatch because UTF-8 encoded data would
        actually be returned when UTF-16-encoded one has
        been requested.
        
        This gets called as follows:
        
            0 QtMimeData::retrieveData
            1 QMimeDataPrivate::retrieveTypedData
            2 QMimeData::data
            3 QtMimeData::deepCopy
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/kernel/qmimedata.cpp?h=6.3.0#n212
        
        Change-Id: I3db1476838336682584145fb43d397c8eed29ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134456
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-18  Luboš Luňák  <l.lunak@collabora.com>  [9b06af2adddc49414adc135f3d08dcc88c896058]

        make CreateColumnIfNotExists() non-const
        
        Generally const functions should not modify the data, so this
        generally should not be needed. Those functions that need to allocate
        a column because they can't/don't handle default values for
        non-existent columns well should go with const_cast, being
        an exception to the rule.
        
        Change-Id: I62706da5b447019542d6775f14064fa15b71f3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134488
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-18  Caolán McNamara  <caolanm@redhat.com>  [b2467d6c7af988f8ed4e090ebf9472be6c84fb06]

        ofz#46060 Timeout
        
        Change-Id: I157c8e12ffd33f320b1b21232afd74c83891f915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [35d1c2e3906a64e54f25539bf229959203ac6526]

        sw: remove images from sample document
        
        It was added in 7d20dc2ca69711c61fb1593ad85ccdef282c978d
        "sw: fix assert in SwObjectFormatterTextFrame"
        and it contains more than 300kbs of images which are
        not needed
        Change-Id: Ib2599baf7b83f83cba45492eccf1f5704aea39e5
        
        Change-Id: I7ecdd5ba7e1251ed334924a3f75f275415d298e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134491
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [b6e0528ca31341239cb4ba990141a66ad4b76d6c]

        Simplify the UI
        
        Remove the intermediary containers, keeping those that are really
        needed to create the necessary structure.
        
        I'm curious, how much CPU could be wasted by the unused container
        layers when calculating the layout.
        
        Change-Id: I56bf13c52b4e14dcef6595d00223cd36f48793d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134463
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Miklos Vajna  <vmiklos@collabora.com>  [9e3eee88338c45424b24040f731083f9f59cfbe2]

        sw HTML export: avoid pixel height when height is scale and width is relative
        
        Commit b17180a84cb4561b8a7bbf9e2281c91fffd56f87 (write out image size in
        html export for 'keep ratio' images, 2021-06-29) changed the sw HTML
        export to write the layout size of images in case one dimension is "keep
        ratio" and the other is some more concrete value.
        
        This is useful in case that other dimension is a fixed value, because
        "keep ratio" on the UI only means to keep the ratio as the size changes,
        it does not mean that the ratio will be the original ratio of the
        bitmap. However, it's problematic to write this layout size of the "keep
        ratio" dimension when the other dimension is relative, as this will mean
        the image's aspect ratio will change if the user resizes the browser
        window.
        
        Fix the problem by extending the way we write the "height" and "width"
        of fly frames:
        
        1) Write a percentage in case of relative sizes
        
        2) Write an explicit "auto" (or just omit the attribute in XHTML mode)
           in case the size is "keep ratio" and the other dimension is a
           relative size
        
        3) Write the layout size in other cases (fixed size or "keep ratio", but
           the other dimension is a fixed size)
        
        Note that HTML itself has no concept of relative sizes where 100% is not
        the parent's size (e.g. page, not paragraph) and also has no concept of
        keeping an aspect ratio which is not the aspect ratio of the bitmap, so
        those cases remain unchanged.
        
        Change-Id: Ic5c7dc4d697160eff81e960a2f7d335fb78ab7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134482
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-17  Szymon Kłos  <szymon.klos@collabora.com>  [4e91e24ced90d7617bbfbc076e47a0896151260e]

        lok: respect zoom in calc tile rendering of EditView
        
        Issue was that when using 150% zoom in LOK and editing
        some textbox inside Calc spreadsheet - we didn't see
        content of it (but tiles were invalidated).
        In other view we have seen textbox in correct place
        if zoom was 100%.
        
        To fix that we need to pass zoom factor and use it.
        
        Change-Id: Ib1cf49af02d0637e09ce68c5c2c41ffb3014c701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134437
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-05-17  Julien Nabet  <serval2412@yahoo.fr>  [522de4493e982d987f55fd88a64dd9e83c46e895]

        Revert "tdf#122057: read tiff with deflate compression (code 32946 only)"
        
        This reverts commit f0d3727322207b3a547313e14305440ad7009079.
        
        Reason for revert: Gimp was displaying a black rectangle, thought it was ok. Then with just Firefox, I could see that it should display a design plan for a house.
        
        Change-Id: I3a87ba24e779aee74d2124bf985b66c9cd7a0bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134449
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-17  Julien Nabet  <serval2412@yahoo.fr>  [f0d3727322207b3a547313e14305440ad7009079]

        tdf#122057: read tiff with deflate compression (code 32946 only)
        
        tiff format is more a multiformat container with different combination of parameters,
        above all compression and photometric interpretation.
        
        For this one, the only pb was deflate compression wasn't dealt with.
        So just use existing LO wrapper for deflate lib in package part.
        
        Remark: for the moment only decompression 32946 (legacy deflate) is managed not Adobe deflate (code 8).
        I expected the same behaviour but some tests with tdf#131199 showed it didn't work.
        
        Change-Id: I2c8d244fa89a2378bfe3b87d3d3262810c9952be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134485
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [b03f8414a0504fe7a25fb4fb6e6950320a654a39]

        ofz: Avoid Integer-overflow
        
        Change-Id: Ic61403673b09a148f69aa582b1799e01564f84e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [517a39c3201ff5a2a258402ca5de6ae9d9c41196]

        Resolves: tdf#145722 don't propose MOVE from AcceptDrop if not asked for MOVE
        
        announce to dnd that tree supports COPY and MOVE, but on accepting a drop
        return MOVE only if that's something the AcceptDrop has set as desirable.
        
        a) makes ctrl+dnd to select 'copy' work for gtk, including gtk on wayland
        b) makes gen correctly draw its copy dnd icon.
        
        git show -w
        
        Change-Id: Ie985f8c9201634afc5ae717fd2aef0dbc18a39e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134486
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [ba257c8443e3b66f73737895f68e57b7cd1c7cb2]

        Related: tdf#145722 need to clone userdata if we copy a module/dialog
        
        otherwise we double-free it, so do what TreeListBox::CloneEntry used to
        before it was dropped as unused at
        
        commit 4a72d6f474b105cdaa7a570b1f199475cc64bb14
        Date:   Tue Feb 11 13:50:50 2020 +0000
        
            drop newly unused TreeListBox
        
        Change-Id: I127511ef4f752cf9a2da26a541e6f1add2a9cf9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134484
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [1f8795df957c18c5c06bf1d68d0d60b1d30f015d]

        tdf#147220 sw_redlinehide: update frames in ReplaceRangeImpl()
        
        Change-Id: Ie5d62eaec01a3b06ff1bd6070510384641ea7ad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134483
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [7d20dc2ca69711c61fb1593ad85ccdef282c978d]

        sw: fix assert in SwObjectFormatterTextFrame
        
        sw/source/core/layout/objectformattertxtfrm.cxx:237: virtual bool SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool): Assertion `GetPageFrame().GetPhyPageNum() == GetPgNumOfCollected(nIdx)' failed.
        
        The problem is that there are multiple (9) flys on text frame 324.
        
        In the loop in CalcContent(), frame 324 starts out on page 13, then
        with the first/second fly moves to page 12, then with the 3rd fly moves
        forward to page 13 - but the pPageFrame that is passed to
        SwObjectFormatter::FormatObj() was fetched outside of the loop.
        
        (regression from commit c799de145f7e289f31e3669646e5bd12814e6c5e
         and commit 533a998e540b0f04068c876dde0e74adc3f79c93)
        
        Change-Id: Iae573900b4b6558634bfed161e5c95bd5ba27151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121924
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [6ee57b39ba912f0902714d8c4d1a267511a3c6ca]

        tdf#148461 sw_redlinehide: fix assert in SwContentNode::DelFrames()
        
        The assert(pMerged->pFirstNode->GetIndex() <= i) is intended for when
        frames are really deleted, but CheckParaRedlineMerge() calls it while
        the now-outdated MergedPara is still on the frame, but the nodes already
        have new flags; assign a dummy node in this situation.
        
        Change-Id: I23fbfdb6901e6e15abf92913aa252e59877bc280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134475
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-17  Michael Stahl  <michael.stahl@allotropia.de>  [e2ff01a08a70a96517287ac9b9e9de6fbfd6a00b]

        tdf#148869 sw_redlinehide: fix SwView::ExecSpellPopup()
        
        How could i forget that MovePara(GoCurrPara, fnParaStart) will move to
        a previous paragraph when it's already at the start of the current one,
        it's so intuitive.
        
        (regression from commit d814941b31b4f9cc8b6e9bd4ddc5188015529707)
        
        Change-Id: Ief9bcd42b7ea78feef50ac42bc93580c29c080b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134468
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [429a960e157f3375e795cdec8f265ace1c5bdc9e]

        elide some OUString allocation
        
        Change-Id: Iadd73477bf3b0edaa0fb7db10f9ffca88fe737e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Stephan Bergmann  <sbergman@redhat.com>  [4417c30d6aa8d415f1f63364bb5dedcd44ae5562]

        external/coinmp: Avoid -Werror,-Wc++2b-extensions
        
        > ClpSimplex.cpp:6038:2: error: use of a '#elifdef' directive is a C++2b extension [-Werror,-Wc++2b-extensions]
        > #elifdef COIN_HAS_MUMPS
        >  ^
        
        seen with Clang 15 trunk since
        <https://github.com/llvm/llvm-project/commit/a1545f51a9ef299ca6c6716bd80b862f360453ab>
        "Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode" (and which is
        turned into an error because External_coinmp builds with --pedantic-errors)
        
        Change-Id: I1db213aec91bc17c720fd58270eab452b2e4e0f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134478
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [64d2c70c9092149e634ff8bcf416ef2fb10d3062]

        Use structured binding to clarify the code
        
        Change-Id: I6b1c0532a64a18d961b7ab112675213eea2fd121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134438
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dc1a911a5b20bf08341b1db098a577ecc9afea3]

        use reserve before filling some vectors
        
        Change-Id: Ib2ae513de46b2a0c16101747540ba09a7cdfb018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134481
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [05b2436ce1c9c4609810e61cfc3b282d33ed9456]

        simplify CacheItem::update
        
        both branches of the if can be easily accomplished with the same code
        
        Change-Id: Iadef72b1e125a11fc27f628a26900ae30dc98220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0559fb4c97208f39fedebdf7e4fcd084a165318]

        clang-tidy modernize-pass-by-value in cppu
        
        Change-Id: I7f6432b9609d175ff7e21ff2e73991275eea60b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e2f5e85c9c22e57e01d6fa6f585f91287efc7ef]

        clang-tidy modernize-pass-by-value in sal
        
        Change-Id: If05c5cf0e333d0dbba31475af69c517486bf8923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Luboš Luňák  <l.lunak@collabora.com>  [bf9b032a08070633b0d7c9bd6554fe08b661b901]

        provide more details about failures in Calc 'functions' tests
        
        Instead of simply asserting that something failed, say which part
        of the .fods test document failed.
        
        Change-Id: Idd901186f27d2395b9e3561fbac6bfc1340b7e72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134460
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-17  Alain Romedenne  <alain.romedenne@libreoffice.org>  [693eebd6774660ebc079c0aca876488fb191359d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c6813f12e709e0ad6ad727ab0c9205d262fa89fb
          - Document SF_Dialog new Resize() and Center() methods
            
            Change-Id: I7867cde08f179f6100560f37b6e481238f9fc047
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133595
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [5938db731bd5f74182acb890102deee813635513]

        tdf#105972: pdf form: export numeric and currency fields as number type
        
        Initial support for AFNumber_Format and AFNumber_Keystroke
        More info in
        https://experienceleague.adobe.com/docs/experience-manager-learn/assets/FormsAPIReference.pdf?lang=en
        This patch adds support for CurrencySymbol,
        DecimalAccuracy and PrependCurrencySymbol for now
        
        Change-Id: I8d6ffac51d576a8c243b9c6d5be2c3517bc0125a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134471
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-17  Noel Grandin  <noelgrandin@gmail.com>  [f08c890482952820bf95b04872260c68082ef083]

        osl::Mutex->std::mutex in HierarchyDataSource
        
        HierarchyDataSource::createInstanceWithArguments does
        not need locking since it does not access local state.
        
        Change-Id: Ia29f9a5ca20095d51e4eb168cdc0a080d178f9bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  László Németh  <nemeth@numbertext.org>  [6af4c1d097dfba897e305a1e57d1e920f36ce264]

        tdf#123877 sc XLSX: don't freeze during saving recovery
        
        file by asking password re-typing unstoppably. Instead
        of this, skip recovery file saving, if the document
        contains password hashes which haven't been supported
        by the "calc8" filter of the recovery file (which
        triggered the "Re-type password" dialog).
        
        Solved problems:
        
        – Asking for passwords during a non-interactive
          background process.
        
        – A single Cancel didn't close the "Re-type password" dialog
          window, only pressing three times at least (according to the
          value of RETRY_STORE_ON_MIGHT_FULL_DISC_USEFULL), but
          waiting for the password for a while could result a
          frozen "Re-type password" dialog, where only retyping or
          removing the password(s) were the escape routes.
        
        – Re-typing the password required the password (but modifying
          the original document doesn't require this).
        
        – Removing the password resulted in loss of the protection
          after saving the original XLSX document.
        
        Add a UI test to keep the "Re-type password" dialog during Save As.
        
        Note: because of the regression reported in tdf#145757, it needs
        to wait 10 min for saving the recovery file, yet, despite the
        changed time in Tools->Options->Load/Save->General.
        
        Change-Id: Icc6ee4d67048cdf15ab75ef8e2ee8f1709cdd4c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134409
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-17  Stephan Bergmann  <sbergman@redhat.com>  [4a23511cdad3a82f7c628426ede3eb0928a3a325]

        At least make CppunitTest_sc_text_functions_test more resilient to ICU version
        
        61f4250ee9f43902107e4d2e6322cbf54f52dd8e "Make CLEAN fully compliant woth ODFF
        v1.3" has changed lcl_ScInterpreter_IsPrintable
        (sc/source/core/tool/interpr1.cxx) to use ICU's u_isdefined to check for Unicode
        code points of category Cn (i.e., noncharacter or reserved).  This is at least
        questionable, as assignment of code points to that category varies with Unicode
        versions.  And while
        <https://docs.oasis-open.org/office/OpenDocument/v1.3/os/part4-formula/OpenDocument-v1.3-os-part4-formula.html#__RefHeading__1017856_715980110>
        "Open Document Format for Office Applications (OpenDocument) Version 1.3.
        Part 4: Recalculated Formula (OpenFormula) Format: 1.4 Normative References"
        references "The Unicode Standard, Version 5.2.0" (so one might expect CLEAN to
        use the category classification from that old Unicode version), versions of ICU
        keep being updated with current Unicode versions' category classifications.  For
        example, the currently bundled external/icu's icu4c-70_1-src.tgz uses Unicode 14
        (according to <https://icu.unicode.org/download/70#h.x1orhyniml8k>) for its
        implementation of u_isdefined.  And for --with-system-icu, all that configure.ac
        apparently requires is that "icu-i18n >= 4.6" (i.e., it will potentially allow
        the behavior of u_isdefined to vary over a wide range of Unicode versions).
        
        And case in point, 61f4250ee9f43902107e4d2e6322cbf54f52dd8e also added a test to
        sc/qa/unit/data/functions/text/fods/clean.fods (row 47) that verifies that
        U+FDCF ARABIC LIGATURE SALAAMUHU ALAYNAA does not get cleaned away by CLEAN.
        But U+FDCF is only an assigned code point (thus no longer of category Cn) since
        Unicode 14 (cf.
        <https://www.unicode.org/charts/PDF/Unicode-14.0/U140-FB50.pdf>), so while
        builds against external/icu (covering Unicode 14) succeed, --with-system-icu
        builds like a flatpak build against org.freedesktop.Sdk//21.08, still at ICU 69
        and Unicode 13, fail CppunitTest_sc_text_functions_test with
        
        > Testing load file:///run/build/libreoffice//sc/qa/unit/data/functions/text/fods/clean.fods:
        > /run/build/libreoffice/sc/qa/unit/functions_test.cxx:43:TextFunctionsTest::testTextFormulasFODS
        > double equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        > - Delta   : 1e-14
        
        (<https://flathub.org/builds/#/builders/11/builds/7103>).
        
        Irrespective of whether using ICU's varying u_isdefined in the implementation of
        CLEAN is correct, at least make that "doesn't get CLEAN'ed away" test more
        resilient to what version of ICU is being used, by using F+UF00 TIBETIAN
        SYLLABLE OM, which got added all the way back in Unicode 2, rather than U+FDCF
        ARABIC LIGATURE SALAAMUHU ALAYNAA, which only got added in Unicode 14.
        
        (And to add insult to injury, in sc/qa/unit/data/functions/text/fods/clean.fods
        61f4250ee9f43902107e4d2e6322cbf54f52dd8e encoded U+FDCF in text not as the three
        UTF-8 bytes 0xEF 0xB7 0x8F, but rather re-encoded as the six bytes 0xC3 0xAF
        0xC2 0xB7 0xC2 0x8F, i.e., the three characters U+00EF LATIN SMALL LETTER I WITH
        DIARESIS, U+00B7 MIDDLE DOT, U+008F.  But I assume that was just a mistake, not
        something that I should faithfully copy in the file's new version.)
        
        Change-Id: Icc8d879b1397d8292914cbd31708d0c561f3b06e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134474
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-17  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [0ebc3a389e955f23e216272eac38158a5e5a6309]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 3cfa1a08999c0bfa7ef8f79db324b565fd87e8c6
          - Updated the English dictionaries: GB
            
            Change-Id: I3f96eeba1fdd449aed1b6922bf156f82fca925ed
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/133470
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [28c82b4a0189ec8b87b10104c566329a6db91cdf]

        Improve version check
        
        ... to not break on e.g. 4.0
        
        Change-Id: I5b93f6138a5ca85891d2d60beca098b6bcfc15d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134435
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-17  Mark Hung  <marklm9@gmail.com>  [01c14670554b2c93de79f07a71a3f94d81a2178d]

        vcl/GetTextBreak(): don't add extra width if char width is 0.
        
        Char width is 0 when multiple characters made up of one glyph.
        Don't insert extra space in that case.
        
        Change-Id: Ieb37aa8a4fffc534d84acf994a231e801e89f782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134244
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [96de6dee60aaf2f0d332291fa3b0ad7bb8b7127c]

        tdf#65067 Remove excessive spacing from Formula objects
        
        As described in bugs tdf#65067, tdf#103816, tdf#149052 and a few other duplicates, Formula objects in Writer receive 2 unnecessary spacings:
        1) From the "Formula" frame style, which has a Left/Right internal spacing of 0.2cm
        2) From the Math formula editor itself, that adds an additional 1pt of internal spacing (left/right)
        
        In MS Word the default behavior is setting all of these spaces to zero, which makes the formula flow better alongside text in paragraphs.
        
        Therefore, this patch set both of these spaces to Zero so that Formula objects in Writer behave similarly as Formulas in MS Word.
        
        Change-Id: Iedcef7124afed6b799f85bcefe37016c8fd972e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134185
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [069f0eb13f7d26ce4b854160bbb9592c25609b38]

        use exec_module on newer Python (>3.3) to avoid DeprecationWarning
        
        Change-Id: I7d0624f63e5d123d5013c14aa0f23355cd42dd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Noel Grandin  <noelgrandin@gmail.com>  [ef3c759357cb3dbe4fee46afd24105a1c2e24126]

        osl::Mutex->std::mutex in HierarchyResultSetDataSupplier
        
        Change-Id: I61bcbc85fbbae469c5463a69dc835b7d1ac0575c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Tor Lillqvist  <tml@collabora.com>  [42eeb373978deb660f38707babfc9d5af9da5cd9]

        AC_RUN_IFELSE won't work when cross-compiling
        
        Change-Id: I8e4d439f0e03ca9e9e3088b451efd8d09bf37203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134462
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-05-17  Seth Chaiklin  <sdc.blanco@youmail.dk>  [0b582183902cfd1de13ad4748d80dc4a9257f3f4]

        tdf#149047 improve labelling of .uno:InsertObjCtrl and .uno:InsertObject
        
            .uno:InsertObject opens a dialog to insert an OLE object.
            .uno:InsertObjCtrl appears to provide a control for a dropdown menu.
            It appears in one toolbar, but it is unclear if it is actually used.
            Meanwhile, it appears in the Customize menu, but when added to a
            toolbar, it does not have any obvious functionality.
        
            The purpose of this patch is to change the labelling on these two
            commands, and add a tooltip to .uno:InsertObject so that it will be
            easier in the Customize dialog to understand what .uno:InsertObject
            does, and to get an impression of a possible function of
            .uno:InsertObjCtrl.
        
        Change-Id: I7cb01763c4a84511e7b7c45d8d00dc6873a3748f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134434
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-17  Tor Lillqvist  <tml@collabora.com>  [f6b3746f9c410ff34024acbbcea73d35c6789a2e]

        Drop pointless and misleading copypasta comments
        
        Change-Id: I68701a61944c0d950468c6f069d2d2f82d5237f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134228
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-05-17  Tor Lillqvist  <tml@collabora.com>  [b3dc91920605705d8a1172fb3784a2377edfc4e7]

        Accept iOS SDK 15.5
        
        Change-Id: I19f54042613769993b92cfaf04de292cfbb72b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134459
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-05-17  Stephan Bergmann  <sbergman@redhat.com>  [bad6799603f7ec4c6566696c1104a8bcf9fcfdc7]

        loplugin:unnecessaryparen
        
        Change-Id: Ic96e2ee710cb28b0475c103ab9cba5974301e164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134407
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-17  Tor Lillqvist  <tml@collabora.com>  [c400311414fca20d3705ee9ef24747b9a5301167]

        Revert "use boost::flat_map in config_map"
        
        Fixes build breakage on macOS at least. Noel said it was OK to revert.
        
        This reverts commit cc4325f84a0ba35d8bbb564512bce0c6b8aab408.
        
        Change-Id: Ib78d29fc21d4d030b4032955b18271de1761f396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [9969b7ee3413b4c83f6e93d92e1038daeaf649e8]

        Resolves: tdf#149093 connect_value_change if we will query its value
        
        and not the text_change which is called before the value is parsed
        from the new text
        
        Change-Id: Ib6bd5647139f1b79f299beb42b704b465ddf535c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134412
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Caolán McNamara  <caolanm@redhat.com>  [40e55abe8b1bee7ac91a8745995392a75b1ffcee]

        add truncate-multiline to match vcl default
        
        Change-Id: Ic3e8840bd124eacdcd30182a584568d5ee0081fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-17  Miklos Vajna  <vmiklos@collabora.com>  [0f25676a07131b60f5ff7881b39379c33b3e9f54]

        sw content controls, picture: add doc model & UNO API
        
        This is meant to be a content control (providing rich text), which is
        also a picture placeholder field.
        
        Add a new Picture property to track this type, this way the click
        handler will be able to present a file picker when showing the
        placeholder.
        
        Change-Id: Ibbd3720fc94d0f17654ec813821d218166c76424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134457
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-17  Michael Weghorn  <m.weghorn@posteo.de>  [19f204a30de56f0c55a157cb040f2e4bdcbe62e5]

        qt: Drop unnecessary reinterpret_cast
        
        `OString::getStr` already returns `const char *`,
        so there's no need to cast to that.
        
        Change-Id: Ief787f9823ffea075882658cf0adec29a8030199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134455
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-17  Miklos Vajna  <vmiklos@collabora.com>  [566afb5fdf01ca0d7054af6a6355b91c10379b79]

        sw: document SwEditShell::InsertTable()
        
        How it interacts with SwCursorShell::MoveTable() is far from trivial.
        
        Change-Id: I04c9123c0b39192df43fe32984d66852102ebd1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134410
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a29fb309878ccf4ad880b02d544ddf4e207116c]

        osl::Mutex->std::mutex in framework::TransactionManager
        
        Change-Id: I8a1c8e8ccec8ca64cc4f615ea8e9e415a343996d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134396
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [edb1070f1bb13082f44444bf37821da1ee4503b5]

        elide some OUString allocation and re-arrange GetCustomShapeEngine
        
        so we check if we have a shape before we try to do any work
        
        Change-Id: I9496e6fd38d7d7f312226791b942190c56e9d34e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-17  Luboš Luňák  <l.lunak@collabora.com>  [ea980b36a7b48a3c9c17cf08d15c5f4f27f79942]

        freeze() and thaw() a widget during creation (tdf#149112)
        
        The repeated inserts each trigger SvTreeList::GetVisibleCount(),
        which has a poor performance because of repeated uses of the
        SvListView::Impl::m_DataTable map.
        
        Change-Id: Ibb261a8501a1d5c168b37675e34498386f161595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134415
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-17  Luboš Luňák  <l.lunak@collabora.com>  [5bf7058f4959ce0cf217817d2b5a30b81c4a7ff9]

        std::map -> std::unordered_map (tdf#149112)
        
        Faster and the ordering is not needed.
        
        Change-Id: I9d9f8ef084f441d24d35dc92ecf060f576d7db2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134414
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [964e2eaae9d32df201574e6f083acc630fed2f1d]

        tdf#142635: use the same ScDocument for clipboard and GlobalDrawPersist
        
        This way, the document used for chart copy has the proper sheets, and
        the data ranges are created correctly.
        
        This reverts commit 8d98dd8b3896c14af057e90e3a327172a9262e03
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Thu Jun 03 13:15:11 2021 +0200
            tdf#142635: skip UITest for now
        
        Change-Id: I0a3aa6028f49ded278f8665556007b1f722e21b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134251
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-17  Mike Kaganski  <mike.kaganski@collabora.com>  [5386e561204af47a7a5eac3e56850478980bbc15]

        Related: tdf#142635 Make ScDocShell reference ScDocument by shared_ptr
        
        Required for eventual sharing of the document between the shell
        and other pieces having different lifetime, as required to fix
        tdf#142635.
        
        Change-Id: I9e69bd2e3b57d7712526f51161e7e725d4af8068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134383
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-16  Luboš Luňák  <l.lunak@collabora.com>  [be441f1a8c40ecbd99653043aa443fc1130d91c2]

        use FontMetric as SalLayoutGlyphsCache key rather than vcl::Font
        
        Apparently even calling OutputDevice::GetFontMetric() rather than
        GetFont() makes a difference with e.g. tdf#65046-1, when only
        vcl::Font is used it triggers the assert in checkGlyphsEqual()
        because of the fonts actually being different.
        
        Change-Id: I2a2aba6bf6d4bf78b7449ccdb16be0746663ee87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134401
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [60ab59ef593d7466250b91bd58c123a6a8f4a734]

        Fix a UITest on Windows
        
        Change-Id: I943a7696fd896c8709fdcd25bce650dd80244daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134367
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [10bc799f9da2a4fdf2adf820d53175e4789fa6fe]

        Fix a UITest on Windows
        
        Change-Id: Ieb6d04e344b1d875f2661833e17f64930681e528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134366
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [212eeff28317543d66acec2be551d7da9ff2a87d]

        Fix a UITest on Windows
        
        Change-Id: If4e5612e2b9fa41c487a6ab54c1e23fd2d63ac9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134365
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [81623bf643c5d22e7c3aceaf5a4050fbd3a30c6c]

        de-lint the .ui file for auto gtk3->gtk4 conversion
        
        Change-Id: Icb288ae13e75784e7b560101f33b8a96935bda36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-16  Eike Rathke  <erack@redhat.com>  [f6e7b9a9921cc08ce603bb005deb187a7fdafb55]

        Update to ICU 71.1
        
        No major changes.
        See https://icu.unicode.org/download/71
        
        Change-Id: I7929d175962ff13e4369005633a4135f17f97e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134404
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-16  Chris Sherlock  <chris.sherlock79@gmail.com>  [9d64ab991b378e929c7c62a49bfc9d4016f30a22]

        store: add unit tests
        
        Test:
        
        - create a file in memory
        - open a stream
        - write a byte to the stream
        - read the byte from the stream
        
        Change-Id: I257880bdd9020d2410f183e612a356eb785621ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127674
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-05-16  Miklos Vajna  <vmiklos@collabora.com>  [a1e2fc012113339564b3414d03a6eaf118ff2713]

        sw content controls, dropdown: edit list items: add modify and delete
        
        Modify is really similar to insert, just we pre-fill the list item
        properties dialog with old data.
        
        Also allow moving items up / down, and eliminate a not needed frame in
        the inner dialog, which would assert when using the gen backend.
        
        With this, the content control dialog is quite complete for dropdowns.
        
        Change-Id: I26e77dd881f0a0eea44d2a6137f76fd29ab32fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134405
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9cfaeb1e083208d7bfcd7a291455b1cc1ef200ea]

        tdf#137748 make keyboard accelerators functional in Statistics dialog
        
           Make the keyboard accelerators in the Statistics tab of the
           File - Properties dialog select the text of the fields that they label.
        
        Change-Id: I61a93e227ed1e457355dc971dc4864ab4419a770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134358
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [673b781fcf18f45c5166c9826131863067c1417d]

        use explicit translatable="no" like we typically do in this case
        
        Change-Id: I6dfcca43fbeace4a75878f0eebe57289b221c4fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134388
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a49c68354656dcdcef87d5c14c8f8f3e3391ec6f]

        remove unnecessary copying in OInterfaceContainerHelper4
        
        caused by triggering make_unique in cow_wrappe when calling through
        non-const operator*
        
        Change-Id: I3191466f464d0f741a628afbe45b60f66f6af2c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134395
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f23633aa0adf5048b283e7bedb08f67198cff591]

        no need to stat a dir when opening a temporary file
        
        it can never be a dir
        
        Change-Id: Ib1c234cb20387cd075a19e13e6656738be88716b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134397
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [985240136dd0d99c50fd0e0b87b777f5b93e5153]

        pdfwriter: validator: fix rule 6.4-3
        
        See https://github.com/veraPDF/veraPDF-validation-profiles/wiki/PDFA-Part-1-rules#rule-64-3
        
        Spotted while validating https://bugs.documentfoundation.org/attachment.cgi?id=179703
        from tdf#148706 with verapdf <https://demo.verapdf.org/>
        
        Change-Id: Ic6cfd18b0c2e8fd252ddd470eff23941f54bb29f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134402
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-16  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [3d077ff9327ba591cbe2c663b0e93706857b6133]

        EMF+ Simplify and optimize the code
        
        Change-Id: Iae7e83253cfe7c0545d2381d83a2e69cb4b80e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134376
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-16  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [2156c1090d318b4d28bc14537754bea73507d501]

        tdf#143876 EMF+ Add DrawClosedCurve and FillClosedCurve support
        
        With this commit EmfPlusDrawClosedCurve and EmfPlusFillClosedCurve
        support was added. There is still missing Filling Mode (it
        is always set to Even Odd Alternate:
        https://en.wikipedia.org/wiki/Even%E2%80%93odd_rule )
        and Tension support for spline bends.
        The graphics is displayed as Tension=0.
        A value of Tension=0 specifies that the spline is a sequence of straight lines.
        As the value increases, the curve becomes more rounded.
        For more information, see [SPLINE77] and [PETZOLD].
        
        Change-Id: Ibccfd584e3d55cd0ca8a29da9f450916d56705d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134333
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c9711f2ff2ee40f9e3928325ac1ba7c47da158ad]

        basegfx: remove CoordinateData2D class and use B2DPoint directly
        
        For some reason B2DPolygon used a CoordinateData2D class that
        derived from basegfx::B2DPoint with no added functionallity that
        is used in practice (just an explicit method transform instead of
        using an operator*=). This class has been removed and replaced
        with B2DPoint instead.
        
        Also removed was the typdef CoordinateData2DVector and calls to
        the std::vector's iterator (begin, end) have been simplified with
        "auto".
        
        Change-Id: I0d187ded05a8e22de36a8e17523e87871aab912c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134378
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ed6d83dfbc590b9782a0699f53bc36f548ae3ec2]

        basegfx: move ImplB2DPolyPolygon inside basegfx namespace
        
        also remove unneeded typedef
        
        Change-Id: I24fd31ff9da579260f1889ed87065f95dcfd1e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134377
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-16  Jim Raykowski  <raykowj@gmail.com>  [9e2391561d80cc06b7c1959f58ce4b70aca2a444]

        tdf#149049 give media object a name when created
        
        so it is shown in the Navigator
        
        Change-Id: Ia4e9c847a1a8cfbaa3465f1472d4b899f4bde3fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134334
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-16  Jim Raykowski  <raykowj@gmail.com>  [fbe42e55fd5fa65587cdac6686dda4f51c7060d8]

        Make media object delete when it is cut
        
        Change-Id: Id586e015e42c23aa455d6f1a5dc42fbda492d2a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134381
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-16  Jean-Pierre Ledure  <jp@ledure.be>  [f9fa11e1c273e6aeba0d7656d518eaea0b14890b]

        ScriptForge - (SF_Calc) FIX CompactUp/Left whan range is 1 row/col
        
        When the range to compact spans only 1 row (CompactUp)
        or 1 column (CompactLeft), a GetValue() method returns
        a scalar and not an array as expected in usual cases.
        
        This caused an abort of the script when invoking the
        UBound() value of the returned array with a Basic run-time error
           Object variable not set
        
        A test on being scalar or array of the result of
        the GetValue() method avoids the error.
        To be done in both CompactXXX() methods.
        
        Impact only on Basic code. Python not involved.
        No changes due in documentation.
        
        Change-Id: I74cf2b274944b442f843e1f4b7ac3a05dd6eaae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134352
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-05-16  Stephan Bergmann  <sbergman@redhat.com>  [4ebfd85322beffed953db01121a45c4a8a12cd59]

        Revert "use more string_view in getNameNoExtension"
        
        This reverts commit d4f2b8eb74f430f5fc3622d668b33df1f99a0c1d, as it causes
        heap-use-after-free, e.g. during CppunitTest_dbaccess_hsqldb_test,
        
        > ==24944==ERROR: AddressSanitizer: heap-use-after-free on address 0x6070001a04a8 at pc 0x0000004b6b42 bp 0x7fff0f651490 sp 0x7fff0f650c40
        > READ of size 56 at 0x6070001a04a8 thread T0
        >     #0 0x4b6b41 in __asan_memcpy /home/tdf/lode/packages/llvm-llvmorg-12.0.1.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22
        >     #1 0x7f315931e373 in rtl::addDataHelper(char16_t*, char16_t const*, unsigned long) /include/rtl/stringconcat.hxx:89:9
        >     #2 0x7f3159beb290 in rtl::ToStringHelper<std::basic_string_view<char16_t, std::char_traits<char16_t> > >::addData(char16_t*, std::basic_string_view<char16_t, std::char_traits<char16_t> >) /include/rtl/stringconcat.hxx:553:14
        >     #3 0x7f3159beb7ea in rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >::addData(char16_t*) const /include/rtl/stringconcat.hxx:252:88
        >     #4 0x7f3159beb59d in rtl::ToStringHelper<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > > >::addData(char16_t*, rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > > const&) /include/rtl/stringconcat.hxx:271:122
        >     #5 0x7f315c3dc450 in rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>::addData(char16_t*) const /include/rtl/stringconcat.hxx:252:119
        >     #6 0x7f315c3c41b2 in rtl::OUString::OUString<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /include/rtl/ustring.hxx:495:34
        >     #7 0x7f315c3eb066 in void __gnu_cxx::new_allocator<rtl::OUString>::construct<rtl::OUString, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUString*, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/ext/new_allocator.h:136:23
        >     #8 0x7f315c3e9e46 in void std::allocator_traits<std::allocator<rtl::OUString> >::construct<rtl::OUString, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(std::allocator<rtl::OUString>&, rtl::OUString*, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/alloc_traits.h:475:8
        >     #9 0x7f315c3ea266 in void std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> >::_M_realloc_insert<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(__gnu_cxx::__normal_iterator<rtl::OUString*, std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> > >, rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/vector.tcc:415:4
        >     #10 0x7f315c3e9c59 in rtl::OUString& std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> >::emplace_back<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/vector.tcc:105:4
        >     #11 0x7f315c3bc742 in rtl::OUString& std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >::emplace_back<rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]> >(rtl::OUStringConcat<rtl::OUStringConcat<rtl::OUStringConcatMarker, std::basic_string_view<char16_t, std::char_traits<char16_t> > >, char const [5]>&&) /opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/debug/vector:489:11
        >     #12 0x7f315c3a7729 in ImplImageTree::getPaths(rtl::OUString const&, LanguageTag const&) /vcl/source/image/ImplImageTree.cxx:226:20
        [...]
        
        (<https://ci.libreoffice.org//job/lo_ubsan/2399/>)
        
        Change-Id: I3af57646bc97c33aad4570a4d6b68dff340b4c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134390
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [2438c2e9bc2c700d03fa25936dc79c2658f3e71a]

        Related: tdf#137748 "Update" should have use-underline
        
        Change-Id: I8303cd8d2cabd8888797758870480483661d8801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134391
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [0181f557b35eab1a96beb86736e5f76dbb0182e7]

        forcepoint#97 avoid Invalid read of size 2
        
         ==143282== Invalid read of size 2
         ==143282==    at 0x190CDBFC: SfxItemSet::Count() const (itemset.hxx:96)
         ==143282==    by 0x1910F33E: SfxItemSet::Get(unsigned short, bool) const (itemset.cxx:748)
         ==143282==    by 0x1F14D76C: ScPatternAttr::GetItem(unsigned short, SfxItemSet const&, SfxItemSet const*) (patattr.cxx:1347)
         ==143282==    by 0x1F14D7DA: ScPatternAttr::GetItem(unsigned short, SfxItemSet const*) const (patattr.cxx:1352)
         ==143282==    by 0x202A3E44: ScLineBreakCell const& ScPatternAttr::GetItem<ScLineBreakCell>(TypedWhichId<ScLineBreakCell>, SfxItemSet const*) const (patattr.hxx:83)
         ==143282==    by 0x2028E8BC: ScOutputData::LayoutStrings(bool, bool, ScAddress const&) (output2.cxx:1677)
         ==143282==    by 0x2028D4A8: ScOutputData::DrawStrings(bool) (output2.cxx:1473)
         ==143282==    by 0x202D9879: ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) (printfun.cxx:1675)
         ==143282==    by 0x202DD459: ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) (printfun.cxx:2301)
         ==143282==    by 0x202DF491: ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) (printfun.cxx:2713)
         ==143282==    by 0x20031888: ScModelObj::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (docuno.cxx:2259)
         ==143282==    by 0x30C1A485: PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) (pdfexport.cxx:219)
         ==143282==    by 0x30C1F879: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:987)
         ==143282==    by 0x30C33BA2: PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:174)
         ==143282==    by 0x30C33F2A: PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:237)
         ==143282==    by 0x21AC6986: SfxObjectShell::ExportTo(SfxMedium&) (objstor.cxx:2488)
         ==143282==    by 0x21AC2363: SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) (objstor.cxx:1553)
         ==143282==    by 0x21ACE816: SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objstor.cxx:2966)
         ==143282==    by 0x21ACCA87: SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objstor.cxx:2756)
         ==143282==    by 0x21AA8CDB: SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (objserv.cxx:317)
         ==143282==    by 0x21B2B4AD: SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) (sfxbasemodel.cxx:3132)
         ==143282==    by 0x21B2CB12: SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1768)
         ==143282==    by 0x1C507AFE: ScPDFExportTest::exportToPDF(com::sun::star::uno::Reference<com::sun::star::frame::XModel> const&, ScRange const&) (scpdfexport.cxx:192)
         ==143282==    by 0x1C511A33: ScPDFExportTest::testForcepoint97() (scpdfexport.cxx:571)
         ==143282==    by 0x1C52778D: void std::__invoke_impl<void, void (ScPDFExportTest::*&)(), ScPDFExportTest*&>(std::__invoke_memfun_deref, void (ScPDFExportTest::*&)(), ScPDFExportTest*&) (invoke.h:74)
         ==143282==    by 0x1C5276C1: std::__invoke_result<void (ScPDFExportTest::*&)(), ScPDFExportTest*&>::type std::__invoke<void (ScPDFExportTest::*&)(), ScPDFExportTest*&>(void (ScPDFExportTest::*&)(), ScPDFExportTest*&) (invoke.h:96)
         ==143282==    by 0x1C527659: void std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) (functional:420)
         ==143282==    by 0x1C5275E2: void std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>::operator()<, void>() (functional:503)
         ==143282==    by 0x1C52758C: void std::__invoke_impl<void, std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>&>(std::__invoke_other, std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>&) (invoke.h:61)
         ==143282==    by 0x1C52753C: std::enable_if<is_invocable_r_v<void, std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>&>, void>::type std::__invoke_r<void, std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>&>(std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()>&) (invoke.h:111)
         ==143282==    by 0x1C52731C: std::_Function_handler<void (), std::_Bind<void (ScPDFExportTest::*(ScPDFExportTest*))()> >::_M_invoke(std::_Any_data const&) (std_function.h:290)
         ==143282==    by 0x1C527A34: std::function<void ()>::operator()() const (std_function.h:590)
         ==143282==    by 0x1C527078: CppUnit::TestCaller<ScPDFExportTest>::runTest() (TestCaller.h:175)
         ==143282==    by 0x49326F2: CppUnit::TestCaseMethodFunctor::operator()() const (TestCase.cpp:32)
         ==143282==    by 0x15937E3D: (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (vclbootstrapprotector.cxx:46)
         ==143282==    by 0x4929ED1: CppUnit::ProtectorChain::ProtectFunctor::operator()() const (ProtectorChain.cpp:20)
         ==143282==    by 0x4B05D6D: (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (unobootstrapprotector.cxx:78)
         ==143282==    by 0x4929ED1: CppUnit::ProtectorChain::ProtectFunctor::operator()() const (ProtectorChain.cpp:20)
         ==143282==    by 0x4AF2F2A: (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (unoexceptionprotector.cxx:62)
         ==143282==    by 0x4929ED1: CppUnit::ProtectorChain::ProtectFunctor::operator()() const (ProtectorChain.cpp:20)
         ==143282==    by 0x491261E: CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (DefaultProtector.cpp:15)
         ==143282==    by 0x4929ED1: CppUnit::ProtectorChain::ProtectFunctor::operator()() const (ProtectorChain.cpp:20)
         ==143282==    by 0x4928690: CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) (ProtectorChain.cpp:86)
         ==143282==    by 0x4946ACD: CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (TestResult.cpp:182)
         ==143282==    by 0x4932103: CppUnit::TestCase::run(CppUnit::TestResult*) (TestCase.cpp:91)
         ==143282==    by 0x4932BCF: CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) (TestComposite.cpp:64)
         ==143282==    by 0x4932A5F: CppUnit::TestComposite::run(CppUnit::TestResult*) (TestComposite.cpp:23)
         ==143282==    by 0x4932BCF: CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) (TestComposite.cpp:64)
         ==143282==    by 0x4932A5F: CppUnit::TestComposite::run(CppUnit::TestResult*) (TestComposite.cpp:23)
         ==143282==    by 0x494FDBF: CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) (TestRunner.cpp:47)
         ==143282==  Address 0x1d7624b0 is 64 bytes inside a block of size 120 free'd
         ==143282==    at 0x4847669: operator delete(void*) (vg_replace_malloc.c:923)
         ==143282==    by 0x1F150EA1: ScPatternAttr::~ScPatternAttr() (patattr.hxx:53)
         ==143282==    by 0x190D29B2: SfxItemPool::Remove(SfxPoolItem const&) (itempool.cxx:802)
         ==143282==    by 0x1EA27F8E: ScAttrArray::SetPatternAreaImpl(int, int, ScPatternAttr const*, bool, ScEditDataArray*, bool) (attarray.cxx:574)
         ==143282==    by 0x1EBF43D5: ScAttrArray::SetPattern(int, ScPatternAttr const*, bool) (attarray.hxx:148)
         ==143282==    by 0x1EBD9068: ScColumn::ApplyAttr(int, SfxPoolItem const&) (column.cxx:634)
         ==143282==    by 0x1EC6C1EB: ScColumn::SetNumberFormat(int, unsigned int) (column2.cxx:3094)
         ==143282==    by 0x1F1CB737: ScTable::SetNumberFormat(short, int, unsigned int) (table2.cxx:2238)
         ==143282==    by 0x1EE3F135: ScDocument::SetNumberFormat(ScAddress const&, unsigned int) (document.cxx:3717)
         ==143282==    by 0x1F09CCA5: ScFormulaCell::InterpretTail(ScInterpreterContext&, ScFormulaCell::ScInterpretTailParameter) (formulacell.cxx:2155)
         ==143282==    by 0x1F099D9F: ScFormulaCell::Interpret(int, int) (formulacell.cxx:1615)
         ==143282==    by 0x1ECC048D: ScFormulaCell::MaybeInterpret() (formulacell.hxx:465)
         ==143282==    by 0x1F09F5C8: ScFormulaCell::IsValue() (formulacell.cxx:2760)
         ==143282==    by 0x1EA82355: (anonymous namespace)::hasNumericImpl(CellType, ScFormulaCell*) (cellvalue.cxx:155)
         ==143282==    by 0x1EA822FA: ScRefCellValue::hasNumeric() const (cellvalue.cxx:624)
         ==143282==    by 0x2028E876: ScOutputData::LayoutStrings(bool, bool, ScAddress const&) (output2.cxx:1676)
         ==143282==    by 0x2028D4A8: ScOutputData::DrawStrings(bool) (output2.cxx:1473)
         ==143282==    by 0x202D9879: ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) (printfun.cxx:1675)
         ==143282==    by 0x202DD459: ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) (printfun.cxx:2301)
         ==143282==    by 0x202DF491: ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) (printfun.cxx:2713)
         ==143282==    by 0x20031888: ScModelObj::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (docuno.cxx:2259)
         ==143282==    by 0x30C1A485: PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) (pdfexport.cxx:219)
        
        Change-Id: Idf19b79f5aef7e07666249f5f9ec510003a3f886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132431
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-05-16  Miklos Vajna  <vmiklos@collabora.com>  [92254b0a2feeb6326796e3f93c289db829eed896]

        sw content controls, dropdown: edit list items in the properties dialog
        
        - add a weld::TreeView to show existing display name - value pairs
        
        - add a button to add a new list item, together with a new
          SwContentControlListItemDlg to specify the list item properties +
          write the changed list back to the doc model
        
        Change-Id: I9243be84eb0af65437eccfb48c6780787609bc68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134379
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6cca743556c2135d5e381cdbd883e937221eef9]

        tdf#121740 elide temporary CacheItem object in BaseContainer::getByName
        
        shaves 2% off load time
        
        Change-Id: I91cc04916d77bc7ece1561462403067478a74bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-16  Mike Kaganski  <mike.kaganski@collabora.com>  [0bb480dfbc28e16a97783e5e735f34ef6a970b91]

        Unfriend some
        
        Change-Id: Ib0a87bae89903f9ae851a6e3e2d6ef9f9197cf13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134360
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-16  Miklos Vajna  <vmiklos@collabora.com>  [817b8fe7001a83cb74910eb09b7c14a3b95b8a39]

        sw: prefix members of SwMSDffManager, SwWW8FltControlStack, ...
        
        ... SwWW8FltRefStack and SwWW8ReferencedFltEndStack
        
        See tdf#94879 for motivation.
        
        Change-Id: I93ac7230bc383433d7232c5d14ed98339620316f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134380
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee3283dfdf2ebe8a6323ecfa518dee1b0fe8cbec]

        use more string_view in URLTransformer::parseStrict
        
        Change-Id: If3087253a75a1cba16f69eecccbaf845ed0b12bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134344
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-16  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [622620936b2da25c3376a8a09af176cd89fd6567]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b62a15c05d585dddfa0206a478867feff1294df8
          - tdf#148413 Help: Remove mention of dropped Character Set setting
            
            Change-Id: Ica686d2cef655d7039c0032dce3a5ff08f056f17
            
2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [dfd517af96c61b6bef75dde525f60bdd2a29a1a9]

        ofz#47473 OOM just skip the unused "reserved" data on read
        
        and don't store it
        
        Change-Id: I7e68111b5ed724c5eab9e8040b8c28f542064ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134353
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-16  Luboš Luňák  <l.lunak@collabora.com>  [392f87b099509d0c0f5e553ae1c5970dca9dc235]

        enable libc++ debug mode again if available
        
        Now includes a configure check for the std::to_string() crash.
        
        Change-Id: I45c3b804b7a1ff5f6520f7bdf772497f72ddee47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134338
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-16  Luboš Luňák  <l.lunak@collabora.com>  [86039563de87149a01ffb980b5ec99074b98fd5e]

        std::stable_sort() where libc++ debug mode breaks a unittest
        
        Libc++ debug has a feature that randomizes equal elements during
        sort, which normally wouldn't make a difference, but some tests
        rely on specific order of tested data. The ones failing without
        this include:
        CppunitTest_sw_ooxmlexport testMsoPosition
        CppunitTest_sw_xhtmlexport testTdf66305
        CppunitTest_sw_ww8export testCommentExport
        
        Change-Id: Id49846939a264150cc82091718ffe6b904d7130e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134337
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-16  Luboš Luňák  <l.lunak@collabora.com>  [ca8614fc44e66308b846d01b8c0ab6a63cc93eb9]

        fix GETPIVOTDATA() field name lookup
        
        Field names are case-insensitive, so the lookup was failing if
        the name wasn't typed in a way that matched exactly as
        case-sensitive. The A29 field in getpivotdata.fods test was passing
        only because the fields were typed in the same order as present
        in the pivot table, and std::sort() was accidentally stable. But
        reordering the fields in the formula makes it fail, and so does
        using libc++ with debug mode (which randomizes equal fields
        in std::sort()).
        
        Change-Id: I88d078da435685c3557f24dc5f4a0bfc4d563aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134336
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-16  Luboš Luňák  <l.lunak@collabora.com>  [b8aa4d7caf82903b3ba1ff45483756db6835cc60]

        make SharedString move operator= inline (tdf#126109)
        
        Calc uses SharedString in mdds::multi_type_vector, which may move
        contents of its blocks on some operations, and making this inline
        makes such operations faster.
        
        Change-Id: I67d14639cf253c56b8cca5b2837bb06bc9afd7d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134339
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [2fe18c214be06065a2966ffa3d4af5db6606b7ae]

        optimise common case of reading a single-pass PNG
        
        Change-Id: I5408f9d9b7c3e0d08c1bc6bafaca97f18898387f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fc2716740bd513154ae4ab5404d9c575678172e0]

        tdf#62776 expand tooltips for + and -
        
          The tooltips for + and - in the LibreOffice filepicker are elaborated
          further.
        
        Change-Id: Ifb66caae78076971eeb74a20ac9284a07038bf1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134357
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-16  Caolán McNamara  <caolanm@redhat.com>  [e843db51c74519acf41e377237914f603e0f6bab]

        ofz#46070 handle unknown line styles
        
        Change-Id: I8cc8f6d832e72483d27b09cc57afbde04df770ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134351
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-16  Jim Raykowski  <raykowj@gmail.com>  [d7cbd78a810b263fd2f53ca58ec678008a387e22]

        tdf#149050 fix .uno:Gallery not opening Gallery deck
        
        Change-Id: I3e43d61e9a37f0815dafc2cf400bcb658e6c6948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134297
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c5340bdf444ae74f3778a2cf9f90d5db6c9ef153]

        cache string in DocInfoHelper::GetGeneratorString
        
        since it doesn't change
        
        Change-Id: I8a9eee18b6de5f375ee2d4d67cdf48700590d007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134347
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc4325f84a0ba35d8bbb564512bce0c6b8aab408]

        use boost::flat_map in config_map
        
        reduces time spent allocating
        
        Change-Id: Idd571db62d28be7e48672f76d741174a7ab40959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134346
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c140247d1477d565680731434df7b82d01f4775]

        don't construct SequenceAsHashMap just to extract a couple of properties
        
        because construcing SequenceAsHashMap requires allocating a bunch of
        heap objects
        
        Change-Id: I2bb1d05b23613d8c8f8a475e006b313578c18c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134343
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-15  Jim Raykowski  <raykowj@gmail.com>  [2daceaba6f2d1666e195af9a8e5dc8c4a703c293]

        tdf#149049 related: fix media object inserts twice in Writer
        
        Change-Id: Id7a7b845e0255086eb877d21699ddb0b80cc47c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134335
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-15  Caolán McNamara  <caolanm@redhat.com>  [da50382b366d6f3de778d8a52136cd812ef5b751]

        tdf#149068 reject OpenGL versions that don't support glGenVertexArrays
        
        use a throwaway toplevel to figure that out, because if the current
        window is used then gtk will always call glGenVertexArrays on it due
        to the creation of a GLContext which is the problem we want to avoid.
        
        Change-Id: I40ccc48b5ed2d9fd99d3c242244847c8448c3803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-15  Julien Nabet  <serval2412@yahoo.fr>  [946b17b4195743b53672def347d280ad53b58c73]

        vcl/tiff-import-ccitt: Pragma once + prefix private members
        
        Change-Id: I49a81f7ae354ca487e8c441629aff5edc2ede2b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134341
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4a5a36cb65418a3b0f89de3490b331fbaa367175]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5252c954087cb842dff319b8787e0ddc4eec315
          - Refactor Direct SQL help page
            
            Change-Id: I7e201b789580caec861a754f40ff75f50e571123
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134332
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2dc80f843d93af12d71aad5d3ae5409cbd411945]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d913c170c5e0ef185b1e964fe4faaacc42b1616
          - Refactor XSLT for code colorization
            
            Change-Id: Ia619b7b0b1548c9de0b183a731e0cca3033eb529
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134349
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-15  Justin Luth  <justin_luth@sil.org>  [f413eb0b43fa36edf69909f3821dfe6a54e3edf7]

        tdf#124820 sc: overwrite more character level font attributes
        
        The issue here is that certain character properties applied
        at the cell level did not clear out those properties from
        the character runs. Specifically strikethrough, underline,
        overline, italics, outline, shadow.
        
        Specifically for xlsx import - where a default value is
        specified in many cases instead of not being defined
        at all - this meant that the cell change had no real
        effect, since the direct properties have priority.
        
        A 2010 commit 4ef978de83610b0e1912bce1d59432b9c382b9fc
        did this for font, size, bold, and color.
        Perhaps that was all that was needed at that time,
        although even back these other properties probably
        should have been handled as well, because the cell-change
        didn't affect the entire contents.
        
        In 2013 a LO 4.1 commit f54ce3e7f6d6aab7e34c54ad8eff06650e076fef
        increased the impact during xlsx import.
        
        I assume that adding the CTL/CJK attributes is also necessary.
        
        Change-Id: Id933af1ce187a79851868a6a295b33758062fe3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134254
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-05-15  Julien Nabet  <serval2412@yahoo.fr>  [63078e284fb088a5ddd81824dc962775588cade9]

        vcl/tiff-import-lzw various changes
        
        Seen during tdf#119686 investigation:
        - Prefix private members + add some spaces for readability
        - Pragma once
        - Declare constexpr CODE_CLEAR, CODE_EOI and CODE_FIRSTMULTICHAR
        - Rename m_nTableSize to m_nTableCurrentId
        - Use constexpr instead of #define for a const
        - m_bFirst useless
        - Reinitialize at each StartDecompression call
        
        Change-Id: I6342f3b25bef94950a152186db07aa11ecc6cd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134340
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [203609a393cd6f60bbb6b9e62023619c6bac30d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d4f563ca60a0dffe6a29c010bb6d833bb2abb91
          - Revisit Base Query page
            
            Change-Id: I74ab17b065f0dcd516ba7a80ee08c4d11f84aa49
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134330
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [27acfa28fbfdf5096608d1326d5234050b52dd8c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cfa7975316e7fa8e88a2c2e06ad37240d1b6e057
          - Add SQL code colorization to Help pages
            
            Change-Id: I2c74e63c67a323a6e6b726da352dd23e1a88d886
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134329
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-15  Noel Grandin  <noelgrandin@gmail.com>  [b6dab033f70fba5e28a45682190f7ec99179d962]

        use comphelper::WeakComponentImplHelper in GenericClipboard
        
        Change-Id: I7135ca3c5f8080929b99a65a0034b568f071d618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134328
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-15  Luboš Luňák  <l.lunak@collabora.com>  [8f61250bf9804ed54e7d960f1446a40b29d1a122]

        no ScSortedRangeCache-based query for number-as-string (tdf#149071)
        
        The comparison depends on the cell encountered, which makes it hard
        to prepare the sorted data.
        
        Change-Id: I22f55003acde7eedadb8a4c8d61390dd30b6ac8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134287
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-15  Luboš Luňák  <l.lunak@collabora.com>  [3165328258c2d7031801d6074611f82b59bec8b5]

        ScSortedRangeCache-based query doesn't work with mbRangeLookup
        
        Change-Id: I9ce8e3547fc261e92e1330df4c054c3efe532d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134286
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-15  Noel Grandin  <noelgrandin@gmail.com>  [7e2d26ef0ed47bf01d7396aa7c749062f9bdde98]

        osl::Mutex->std::mutex in SvtLinguOptions
        
        and fix SvtLinguConfigItem::GetOptions so that it only
        accesses state while holding the lock.
        
        Change-Id: Ie092bf427e130348131412a038bce7de8ebcde83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134327
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Caolán McNamara  <caolanm@redhat.com>  [163e4686914ecf04f1cbef2f6a087cadbfe59f81]

        ofz#47323 suppress Direct-leak
        
        __lsan_default_suppressions works in a local oss-fuzz image but seems
        to have no effect when deployed which fits with the report of
        https://github.com/google/oss-fuzz/issues/6066
        
        try explicit __lsan_disable/__lsan_enable guards which also works
        locally
        
        Change-Id: Ifbfdb9d9ba7014b78b43578c25fca97c3279bc5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134331
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-14  dldld  <LibreOfficeContribution@dldld.de>  [20f0ab23b1c0b60ca36a053464f3ba41bf27c80e]

        tdf#133716: Fix edge gradient when upscaling image
        
        When an image is getting upscaled with cario as engine it got blured borders.
        The issue that was worked on showed, in the PresenterConsole, that the
        borders of the previews and control area had an unnecessary gradient in it.
        As these borders are build from images which are getting upscaled,
        either in width or height a graident ocurred. This was because the cairo
        rending didn't had the correct pattern extention set: CAIRO_EXTEND_PAD.
        
        Nearly same issue also occured when adding an image to a presentation
        and upscaling it, the borders got blured. For images with either height or
        width equal to one this was a while back fixed: tdf#114117, but not for the
        general case. Using another extend mode fixes this, because the PAD
        extend mode doesn't blur the borders.
        
        CAIRO_EXTEND_PAD:
        pixels outside of the pattern copy the closest pixel from the source
        
        Change-Id: I39f8a14a69f035a43a93afb303f0a2e7ec8699c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-14  Julien Nabet  <serval2412@yahoo.fr>  [86050db1b0c15651335d1b0bf89ee8f6409dee1d]

        Related tdf#149072: avoid warning "misuse of method"
        
        complete warning log:
        <SwTextFormatColl::GetAssignedOutlineStyleLevel()> - misuse of method
        
        part of bt when opening attachment of tdf#149072
        0  SwTextFormatColl::GetAssignedOutlineStyleLevel() const (this=0x77064d0) at sw/source/core/doc/fmtcol.cxx:608
        1  0x00007f8a52aa7941 in sw::(anonymous namespace)::HeaderCheck::check(SwNode*) (this=0xa457630, pCurrent=0x7705e98) at sw/source/core/access/AccessibilityCheck.cxx:622
        2  0x00007f8a52a9a6a3 in sw::AccessibilityCheck::check() (this=0x7ffe4a14ab10) at sw/source/core/access/AccessibilityCheck.cxx:947
        3  0x00007f8a53ed2ad7 in SwDocShell::runAccessibilityCheck() (this=0x74ef0e0) at sw/source/uibase/app/docst.cxx:1559
        4  0x00007f8a16e7fdec in ImpPDFTabDialog::OkHdl(weld::Button&) (this=0xa0e9990) at filter/source/pdf/impdialog.cxx:324
        5  0x00007f8a16e7fb2d in ImpPDFTabDialog::LinkStubOkHdl(void*, weld::Button&) (instance=0xa0e9990, data=...) at filter/source/pdf/impdialog.cxx:317
        
        Change-Id: I2ed50f14eff01babd47ada3831c0a051fc767dbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134312
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Julien Nabet  <serval2412@yahoo.fr>  [4d3a9d4ffec4bf9765f965d92c163c94201a3c9a]

        tdf#149072: fix export PDF with PDF/UA in GUI after Index language was set
        
        Regression of a1f9fea520f5b3f5d54a284886aa531693f32e7a
        Make accessibility check dialog async
        
        First add of m_xDialog->response(RET_OK) fixes the bug
        the second one is just here to have same behaviour as before the quoted patch
        
        Change-Id: Ib24459e4e946b83172271a9097930e5977e676be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134311
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Caolán McNamara  <caolanm@redhat.com>  [dba12ec9cf049812dfadade3ed6a84127a9dca6c]

        tdf#149079 don't skip disposing DnDListener
        
        even if there is no longer a DropTarget don't return early and
        omit to inform listeners of the disposing
        
        Change-Id: I6ce7fe1664049a9e0a88b549b1c8c94ec8072c1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134322
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [22e08a3d8b043ce0ff2424d3fa0a704804afc567]

        tdf#121740 cache hashcode in SequenceAsHashMap
        
        shaves 2% off load time
        
        Change-Id: I5bd4eabf61205df21a27d2822acd2676a7732a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134315
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a274f47ee5759b17ab22497dbe64ef6135d4cd6]

        optimise SfxFilterMatcher::GetFilterForProps a little
        
        - avoid repeated construction of SequenceAsHashMap
        - avoid construction of OUString
        
        Change-Id: I62560dad26d3433e7c379669da437261b5fe0238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b86f167e9d2947077d7950cea735a5673ca53fb2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 789bc6e2c10536e5a876c5c4fb0126dbffe4dcbf
          - Bump Prism.js to 1.28
            
            + Add SQL coloring syntax
            
            Change-Id: I3a68a54dee211d791da72b459647315395e17658
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134326
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a3d45682089932ec36eb5a2ee9c7dedf5d683751]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c82eb12e524d454c02798994d08d50548c9734c
          - Fix bad filename and links in Query Desing Help page
            
            + Remove internal links that breaks reading comfort.
            
            Change-Id: Ic417bfa2dd8f2b904575d69e6d3e98f0b8a8ce37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134324
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8e4b2830d01efbfe11fb138e1307b9b05695006a]

        Fix typo
        
        Change-Id: Ic5163d9b570b907c6e7c840a8f6cc9dc73a8f958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134270
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e4bbd65376497585d035fd9d29490668bcce815e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5cc5cbc6aefae06f547529bc0d417e14dc486fc4
          - Fix typo
            
            Change-Id: Ia62d016ffacbeb4a9cac6a27f52843432c29e755
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134318
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1983a1fc803fe3bd35ee1f3b80b44c99582ca95]

        Fix typo
        
        Change-Id: I1454a649ab434fe4d34a181bc572472a2784c1df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134321
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef96de2252bca350a491185704de10b137a29ab3]

        Fix typo
        
        Change-Id: If7581fbc808b985cbf6d81a2e66571ddc465f16e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134320
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d028269b67aaa1cc36473a4c9f5fc3c01499d3e]

        Fix typo
        
        Change-Id: Ib0913aef00cd252d3f082ec5e8b39064df63a7fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134319
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [37bbac7f8b8649c8c3a759d4ae225ead7af2d69c]

        simplify initialisation in ToolBarManager::CreateControllers
        
        Change-Id: I2e876f0bff180e569394e2fe3c102b658a55d170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134309
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4f2b8eb74f430f5fc3622d668b33df1f99a0c1d]

        use more string_view in getNameNoExtension
        
        to avoid some allocation
        
        Change-Id: Ic8d42af03a4ffd15414e3458b5b08e04ded43114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [652ac2fb11adaea2ab6b07718aa86579de025a72]

        cheaper to let Any do the comparison in isSubSet
        
        rather than constructing temporary OUStrings
        
        Change-Id: Ibb083e3fab8a465ae5288359424b297faac83617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134317
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [216c21050ed90a3c80c4d59abbec800e495f2a79]

        elid some OUString construction in SmXMLExportWrapper::Export
        
        Change-Id: Icc091a7fab3c9ce368bd45536de1e75d29431c56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce214d56727ecf8fb212910a711b4e3ef38e4b63]

        bypass some unnecessary wrapping in Any in SfxEvents_Impl
        
        Change-Id: I96d1194253207642e7abe83b0b18c82eb3782824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134316
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3a91c52b5a8a4fa131c2b74ba83032c835da313f]

        Add extended tips for Direct SQL dialog
        
        Change-Id: I0b46222ed60084544d6271fba258f02955baaa0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134295
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c62a671a6676c27437f15a644032cd3e89b7c491]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6b0ba3babd4f6ed7aa55d9ccd85361970857977
          - tdf#149086 Fix Help page for Direct SQL command
            
            Add target bookmark
            Update page content with latest UI enhancements
            
            Change-Id: I88ec6bf787d7e4bb5df24b8e1652e5f176afdbf9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134296
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6fb43429c31ebb4f4cff7be8ba27f1c7f022c7b9]

        Bump directsqldialog.ui to latest Glade version
        
        No changes in dialog.
        
        Change-Id: I478e43aadd5c92363a514e32245a17cbabd17da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134294
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [f321113d71cca569624a848bdcb898cb04460137]

        Only obtain these after trying the cache
        
        Change-Id: Ia1ce426bb4734b669e3715776561cb94a1c6292f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134192
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-14  Luboš Luňák  <l.lunak@collabora.com>  [130552d925878fcf452a85fb5a60ae048dc12a60]

        require libmwaw >= 0.3.21
        
        File writerperfect/qa/unit/data/writer/libmwaw/pass/ScriptWriter_1
        causes CppunitTest_writerperfect_writer to fail here with 0.3.20.
        
        Change-Id: Id5e66b7c4531287357502b7b5ff7880af7186016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134306
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [27be40762e9e10de05cdc0692eef8a8c6fd5a23c]

        pass-by-value in TaskManager::MyProperty::setValue
        
        cheaper to move a temporary from some call-sites rather than
        copy-construct
        
        Change-Id: Ic1f994d0253c8368548295a08e83dfbbfae0a008
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134307
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8eabb8839dd81a1055aa0416ab5f3f67c7d3bb29]

        reserve space in map in ZipFile::readCEN
        
        Change-Id: I4d7764f00b7d05ba5d43a3fb35596f5ec4653da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [832c17278c9497de4b4b4a461cf858e8a62420da]

        cache some OUString in GetEnglishSearchFontName
        
        rather than allocating them repeatedly
        
        Change-Id: Ie0f751f589b512a97534d193e1401312ae2f2afe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [451efe2d7df16e61221fce4eafdba1fc7feaf60e]

        reserve space in vector in ImpEditEngine::CreateTextObject
        
        Change-Id: I4fd49ab81808b3912445b4037a50a5cd85c74144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6c5542a82135b3527f883110d45a935661985d30]

        Partially resolve: tdf#149010 rename section "Names" -> "Accessibility"
        
        Change-Id: I2f9f38ae79f0f05b42e6f209d504c5f8a5896ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134182
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1134ca31084e052554ba1b3fa25baf2fee8acd7]

        Fix typo
        
        Change-Id: Iebbecfbd395aa001d82dc00c7ef9b9587b4755fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134048
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [094b003268423a62cce9619a78caa82c59c7bbb8]

        elide some OUString construction in GetViewSettingsAndViews
        
        Change-Id: I4d0e6444e939731e9b109f961d36d9a2b8f00d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134305
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [93243decefd78cd956d3d0984b4cd829d13bed4c]

        skip some SetResizeProtect work during construction
        
        unnecessary to do all the work of firing ActionChanged etc at this stage
        
        Change-Id: I20aad96e16d7a1ae5176e868d3699080aa0bf6a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134304
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [60ba608b33b993ea9dc9cead84bd2d62f2ed50e1]

        pthread_mutex_t->std::mutex in lookupThreadId
        
        Change-Id: Ic9dfcfef5c604e778dfe527d627137042c8deb49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [06900403843e4afa413d0ca4e2ea6be761ac668a]

        osl::Mutex->std::mutex in framework::Gate
        
        Change-Id: I72f0ed62a65dbd487a29f409d1941a50cecb894f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [09dffa4cea17983748f9a2141bb311886e33b00b]

        use std::mutex in LocalProcessFactory
        
        which much faster than osl_Mutex, and especially for this simple case
        
        Change-Id: I4e8ba221649587af76c7f7cac5f308821490980a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134300
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [624ad0d635bdd0a5d6734fca36ce2a87314e92ce]

        use more string_view in oox
        
        Change-Id: I7c6d201cfbfb577ef53e685df245997e5ec8f134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134299
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6ad419ac923180fd951e2db901fd840aa4914b1]

        simplify construction
        
        Change-Id: Ib8a28575fe813a909ce5429732a60ae77f92b6ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa5f99e565e55ab5c7b32c88697c44541aa77745]

        less OUString construction in SfxDocumentMetaData
        
        rather than calling createFromAscii all over the places, just start out
        with the values as OUString
        
        Change-Id: I7f051fcf9fcbd9555462fa721c76dc867a84a706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [39acaf84f9b23442e1333db7d213100c6997ffe6]

        elide temporary OUString in SvXMLExport::initialize
        
        Change-Id: Ibf1b99042ccae1fcf5fb21ab7e60bb30a9ad74f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [e61ce6b317be45e405ba9b45aa79d2f1dac41e19]

        use comphelper::WeakComponentImplHelper for TerminateDetection
        
        Change-Id: I6184bdef7b487f71549cd50c96c764a93ef791de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134274
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Mike Kaganski  <mike.kaganski@collabora.com>  [2d93fd2631b4f8ceca1068c1779963424ff90e80]

        std::mutex->std::recursive_mutex in SvtUserOptions
        
        Since commit ac511d90cdf9d28eb8809c30be9fa08b42ea0bd3
          Author Noel Grandin <noelgrandin@gmail.com>
          Date   Thu Dec 23 19:42:19 2021 +0200
            osl::Mutex->std::mutex in SvtUserOptions
        
        non-recursive std::mutex is used. However, it looks like recursive
        locking is possible here, as shows the debugging that I made
        during the work on https://gerrit.libreoffice.org/c/core/+/134251.
        The call stack looks like this:
        
          utllo.dll!SvtUserOptions::GetToken(UserOptToken nToken) Line 318
          utllo.dll!SvtUserOptions::GetLastName() Line 294
          sclo.dll!ScChangeTrack::ConfigurationChanged(utl::ConfigurationBroadcaster * __formal, ConfigurationHints __formal) Line 2166
          utllo.dll!utl::ConfigurationBroadcaster::NotifyListeners(ConfigurationHints nHint) Line 85
          utllo.dll!utl::detail::Options::ConfigurationChanged(utl::ConfigurationBroadcaster * __formal, ConfigurationHints nHint) Line 112
          utllo.dll!utl::ConfigurationBroadcaster::NotifyListeners(ConfigurationHints nHint) Line 85
          utllo.dll!SvtUserOptions::Impl::Notify() Line 251
          utllo.dll!SvtUserOptions::ChangeListener::changesOccurred(const com::sun::star::util::ChangesEvent & rEvent) Line 116
          configmgrlo.dll!configmgr::Broadcaster::send() Line 168
          configmgrlo.dll!configmgr::Access::setPropertyValue(const rtl::OUString & aPropertyName, const com::sun::star::uno::Any & aValue) Line 714
          utllo.dll!SvtUserOptions::Impl::SetValue_Impl<rtl::OUString>(UserOptToken nToken, const rtl::OUString & sToken) Line 183
          utllo.dll!SvtUserOptions::Impl::SetToken(UserOptToken nToken, const rtl::OUString & sToken) Line 200
          utllo.dll!SvtUserOptions::SetToken(UserOptToken nToken, const rtl::OUString & rNewToken) Line 325
          test_sc_subsequent_export_test.dll!ScExportTest::testTrackChangesSimpleXLSX() Line 3072
          ...
        
        So getting the token may happen during notification of the listeners
        after setting the token, in the same thread. So let's use recursive
        mutex.
        
        Change-Id: I9be82f307a9948bcbc76d7d90632a0307c5dc4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134190
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-13  Caolán McNamara  <caolanm@redhat.com>  [9b1dcd8f591edc6ed1a6db469956985b59badaf5]

        tdf#149074 SvHeaderTabListBox not handling lack of preset column widths well
        
        Change-Id: Ibd33fe5c5168850eca1bdc7242afc38ed08b5fa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134289
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b9637e3aaf4ebf3755e1ebb39e7ed6bf2489dcf9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d9880014fd80f412d10b2f7536c45941552c4760
          - Fix YouTube display for Help online/offline
            
            + Enhance button CSS display
            + Refactor XSLT
            + Refactor XHP
            
            Change-Id: I58e46c31a97ad49eb25a4489994aae5dac62dbc3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134207
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-13  Caolán McNamara  <caolanm@redhat.com>  [5fa5a6b4353d47ab286e16e72bd4c440a95b2bdb]

        Related: tdf#148197 gtk_tree_view_scroll_to_cell needs either path or column
        
        so a null path is invalid here
        
        Change-Id: I1958e9695e3290e0c513bce89c9548908860754f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134280
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [92392494c92976e336778267919d93c0b2b577b3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 11bafb045eecef25e05dca0dbc1f693410812056
          - Fix bookmark semicolon
            
            Change-Id: Ie36fce4ad7aed7908cd66449044ccc3acf812576
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134285
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-13  Luboš Luňák  <l.lunak@collabora.com>  [e1f62d3c387b7080d50e06554fa65512bcbe1d83]

        make ScSortedRangeCache-based queries work with mbMatchEmpty
        
        Change-Id: Ifc8195222568184dc4f337b23f00e315e22febe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134218
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-13  Michael Stahl  <michael.stahl@allotropia.de>  [732fdafd9f7ccf383038258792c8cb15f30f8e74]

        officecfg,stoc: allow running JVM UNO components out-of-process
        
        The problem is that 32-bit Win32 applications have very little VM, and
        soffice.bin can run out, so try to move the JVM to a separate process
        (uno.bin) and connect to it via pipe.
        
        Add a new config to enable this:
        "org.openoffice.Office.Java/VirtualMachine/RunUnoComponentsOutOfProcess"
        
        If enabled, ServiceManager instantiates *all* JVM components
        out-of-process, by instantiating
        "com.sun.star.java.theJavaVirtualMachine" out-of-process.
        
        To ensure that the remote connection is disconnected at shutdown (and
        thereby prevent crashes with remote calls during late shutdown),
        JavaComponentLoader is now a "single-instance" service; this change
        should be harmless for the default in-process configuration case.
        
        Tested with these extensions:
          Wiki Publisher
          smoketest TestExtension.oxt
          odk CalcAddins.oxt Inspector.oxt ToDo.oxt
        
        Also passed "make check" on Linux when enabled, if the variable
        URE_BIN_DIR is set properly for CppunitTest_services.
        
        Change-Id: I76bf17a9512414b67dbd20daee25a6d29c05f9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133218
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [c63b86501828d35c3a80aa5be2d70f992b4f1b23]

        CppunitTest_sc_uicalc: simplify code a bit
        
        Change-Id: I65f32c3f308f7ac9a416026efaf0648ff6457ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134272
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [02367bacafe99fcfaa64c20fad0df50ba0b2301d]

        tdf#148863: sc_uicalc: Add unittest
        
        Change-Id: I15e692ed42445821e8fa65c955916c43f58072e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134271
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [168a1bda076058b11010760af966486b723ce376]

        Add mold linker temp files to .gitignore
        
        Change-Id: I8c3d27cae524b30be601cefb78dca9c4139b2602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134263
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-05-13  Miklos Vajna  <vmiklos@collabora.com>  [75f7e057039aaa49558e22d18cad651d11589da9]

        sw content controls, dropdown: add an initial properties dialog
        
        - read the doc model: show if a content control is a placeholder or not
        
        - work with a shared pointer in the dialog, which avoids lifetime issues
          in case the content control we edit in one view gets deleted in an
          other view
        
        - write the doc model: set the placeholder mode of the content control
          based on the checkbox state and mark the doc as modified if any widget
          is touched when pressing OK
        
        - handle command state: allow this dialog only inside content controls
        
        Change-Id: Ie0b9075ccd3450dd403cc7f8bbf93fc04de3b234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134278
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [923c1a79efd0885be37feb4a5b3c847e659e4f53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9567d477807671d7fe5b8379b13cbace2b9a0f22
          - Document new CompactLeft and CompactUp methods from the Calc service
            
            Change-Id: I6bc2a4d80fb94f7158c60e107252e112cee83c44
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134073
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [205f99d6cf4dcfab6ee6c66efd1788200ac118c4]

        use vector as backing for stack
        
        which is a little faster
        
        Change-Id: Id086b67eba3ec00dc86a48a0fdec1a467b600d1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [d01f8813084b245492c83cf750bb59bcd2659621]

        tdf#121740 cheaper to clear namespacemap rather than allocating
        
        a new one
        
        Change-Id: I413de3a61744400f5582f7e090c161ea21bf0b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134267
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [e709ebe42ad06974b822366e4eea1a6c2ee61e10]

        tdf#142261 EMF+ Add support for Miter Limit
        
        With this commit the Miter is properly implemented,
        according to [EMF-PLUS] documentation:
        https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-emfplus/5ef071f3-f503-4f16-b027-7c4bcf2d1d81
        
        The formula for stroke miter limit is described here:
        https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit
        
        Change-Id: Ida87063cc045460e61ffae118f64cf133c810dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134164
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-13  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [99e10099b5d63c30b9a960fc94fc438ae7ab63dd]

        Advanced Diagram support: Secure Redo, evtl. flush Redo-Stack
        
        Change-Id: Iade4ea85289377774e51671f1e9848c19d757633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134245
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-05-13  dante  <dante19031999@gmail.com>  [27a273293618e6dbc2de5b299247b1d9f05864c6]

        Use calloc instead of malloc and memset
        
        Change-Id: I591ee7f5360a30779f831f6492cdbe71ab94099e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134165
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3817965ded6c7ed915e4f9599e18b3e8abdaca44]

        add SvStream::ReadLine(OStringBuffer... to reduce OString allocation
        
        and use it where possible
        
        Change-Id: I3efc7a642f73661ce606c917c0323ba9948521c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134265
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ad920befe1290c40ef762e8d7d9797b1924f5d2]

        tdf#121740 reduce cost of mathml parsing
        
        by re-using OUString instances instead of allocating new ones for each
        SmToken
        
        Change-Id: Ia897427d6c1ffeb0e741dea90fde1f4d56a70175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Stephan Bergmann  <sbergman@redhat.com>  [388bed014ad19a23fa9879bc31a8088f34157a48]

        Remove need for two typedefs
        
        Change-Id: I8e576f0b2b417ed78e6f38b745e51cbf8b666c68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134262
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [3bd7111fe29ce19a007915af87f1f9269d27d9ff]

        tdf#148706: map value prop in numericfield to text
        
        Change-Id: Ifc37b0aa8dc657d7a7f05199c8132896d03eb437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134240
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-13  Stephan Bergmann  <sbergman@redhat.com>  [eac2e7520de09d019c07b63f9f89d865c20b1e4e]

        Pick a better type for the GetAttrib nAttr parameter
        
        ...which indexes into a std::vector.  To avoid the blemish of accompanying
        std::size_t variables potentially getting decremented past zero (even though
        that would be technically OK and not UB), rework some accompanying code to avoid
        that.
        
        Change-Id: Ie1ab2d079a7d8d34fceda1da2d31fa6a8c4fad6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134255
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-13  Miklos Vajna  <vmiklos@collabora.com>  [c7d80d229a5660a0ee702477bfbd2ca137992a7d]

        sw content controls, dropdown: add LOK API
        
        - expose the available list items in a new "items" key of the
          LOK_CALLBACK_CONTENT_CONTROL callback
        
        - add a new lok::Document::sendContentControlEvent() function to be able
          to select a list item from the current drop-down
        
        - add a new listbox to the gtktiledviewer toolbar to select a content
          control list item when the cursor is inside a dropdown
        
        - add tests for the array API of tools::JsonWriter
        
        Change-Id: I47f1333a7815d67952f7c20a9cba1b248886f6dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134256
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [09e0cfd9b3e391435c39d3bc933d26a87e2b082e]

        reserve space in map in SvXMLNamespaceMap
        
        Change-Id: I0c46a9869d17cde75263277d2b17f0c980f14c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-13  Miklos Vajna  <vmiklos@collabora.com>  [6efd443247c51c4ea1dac425e87129b5b97038a7]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ie52b96e1d7a5e5e2d55d9f68f7756e21b86ea9b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134249
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-13  Eike Rathke  <erack@redhat.com>  [4bd8eb13e1e2693961fdb9c19c403fde9d163de1]

        Use interpreter stack to determine JumpMatrix context, tdf#148863 follow-up
        
        pJumpMatrix may or may not be set; actually may need some rework,
        but get this straight here.
        
        Change-Id: I0948e6aeb6637e7a5009a17f63f01d0733c0205c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134252
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-13  Mark Hung  <marklm9@gmail.com>  [fb8eb0ad9c3a5957a6e131490a7a8c97e5353ba2]

        tdf#104930 aligning CTL text with hanging baseline.
        
        1. SwTextSizeInfo::GetHangingBaseline() calls SwFont::GetHangingBaseline() to obtain the hanging baseline value. Only CTL script handled, it always return 0 for other two scripts. Eventually Outdev::GetFontMetric() and TextMetric::GetHangingBaseline() are called to obtain the hanging baseline value from vcl.
        
        2. SwTextFormatter::CalcAscent() sets the baseline value for the portion via SwTextSizeInfo::GetHangingBaseline().
        
        3. SwTextFormatter::InsertPortion() sets the maximum baseline value for the whole line.
        
        4. SwTextCursor::AdjustBaseLine() calculates the new baseline in case hanging baseline is available.
        
        Change-Id: I1aae7a34dfc953227b7873fc8e3af5cc7e2fbbff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133668
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-12  Eike Rathke  <erack@redhat.com>  [9391e9fb99a87e71897e29da79eba084682fdaa5]

        Resolves: tdf#148863 In JumpMatrix context use its dimensions for results
        
        Problem was, that in array mode the result matrix of random values
        was created according to the dimensions of the formula cell range
        selected/resulting, which if transposed and displayed obeys the general rules of
        a repeating vector if not a 2D matrix.
        
        For example, entering the array formula
        =TRANSPOSE(IF({1,1,1};RAND()))
        (with , comma array column separator) is supposed to create a row
        vector of 3 columns transposed to a column vector of 3 rows. The
        selection created for the automatically determined result is 3
        rows in one column, for which the RAND() was calculated, resulting
        in a column vector
        
        {
        1
        2
        3
        }
        
        which transposed gave a row vector { 1, 2, 3 } and displayed for
        one column such row vector is repeated as
        
        {
        { 1, 2, 3 }
        { 1, 2, 3 }
        { 1, 2, 3 }
        }
        
        of which the first column displayed is the repeating first value 1.
        
        With this change the dimensions of the JumpMatrix created by
        IF({1,1,1};...) is used to generate the RAND() matrix, resulting
        in a { 1, 2, 3 } row vector that then is transposed and displayed
        as expected.
        
        Change-Id: I267ff5d336a86372ee456fd929249e5f0444f843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134247
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-12  Caolán McNamara  <caolanm@redhat.com>  [e9992e96faf92080402ab32322d16d51c367f6ce]

        make the expand/collapse node drawing easier to read
        
        Change-Id: I0b25affad41dfea7c0980c5eb6092fd0a149bae8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-12  Julien Nabet  <serval2412@yahoo.fr>  [891ff1334eb4288668ebf70636d7972af691fa88]

        tdf#119686: fix tiff with 1 bit per pixel
        
        On the 30 pixels width images, the 3 first bytes were ok,
        that's why the 24 first pixels of each line was ok.
        The pb was in the fourth byte, you must read each bit of this last byte
        until reaching 30 pixels, so 6 bits (since width 30 corresponds to 3 * 8 + (8 - 2)).
        Here LO always shifted this byte with the same value, so used the value of the first bit for the last 6 bits of the last byte.
        => just decrement the shift value at the end of each loop
        
        With this patch initial, attachment of the bugtracker https://bugs.documentfoundation.org/attachment.cgi?id=144656
        and the more complex one https://bugs.documentfoundation.org/attachment.cgi?id=144656 are ok
        
        Change-Id: I17339c54d6822c724184f167fb3a25b240e06543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134235
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-12  Miklos Vajna  <vmiklos@collabora.com>  [32dab3228cd315437efe0c5b850d116235eaa797]

        sw content controls: fixes for the ending dummy char
        
        - make sure the DOC/RTF export doesn't write the dummy char as-is
        
        - let "enter" only insert a linebreak while inside a content control, to
          ensure that the starting and ending dummy char stays inside the same
          text node
        
        - let deletion of the dummy character at the end behave the same as the
          start dummy character: if trying to delete that single character, then
          just move the cursor, don't delete it
        
        - reject document insertion in the middle of a content control, similar
          to input fields
        
        Change-Id: I9b54ef50261e6b17f38eadadacfe1e1111199e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134239
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-12  Miklos Vajna  <vmiklos@collabora.com>  [3f318b314eb161d293990efa401a626ed8017c87]

        sw: fix crash in SwDrawShell::Execute()
        
        Crashreport signature:
        
                SwDrawShell::Execute(SfxRequest&) [clone .cold]
                        include/svx/svdhdl.hxx:194
                SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
                        sfx2/source/control/dispatch.cxx:255
        
        which is a bit tricky to read (probably due to LTO), but what happens
        here is that the handle index is user input and we look at index up in a
        list without error handling.
        
        This is a problem since commit 7eed711a6115bf892c998cbd73a2c5b706c6f99d
        (Extended MoveShapeHandle command for Anchors as well, 2021-05-24),
        which assumed that handle indexes and the handle list can't get out of
        sync.
        
        Fix the problem similar to what commit
        48beccf52413981d3d1c525a81a2c57048abe261 (sw: fix crash in
        SwView::Execute(), 2021-09-03) did at SID_MOVE_SHAPE_HANDLE handler for
        Writer images (this one is for Draw shapes).
        
        This fix just makes sure we don't crash, there may be some deeper reason
        why the handle index is out of sync with the handle list in the first
        place.
        
        Change-Id: I8f3a25d74082984cedce09362a690f24d7236ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134216
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d03e7a8fba5494dc10433f33d902683eaae639bb]

        speed up simple use of NamedValueCollection
        
        where instantiating and allocating a whole map just to extract a single
        key is way inefficient
        
        Change-Id: I55248bc71a9e8826cab9b76fa6916bfa888efa0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134226
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5c33076ab2a4d995e312908ca482b56dd502189]

        avoid cost of NamedValueCollection in SfxBaseModel::attachResource
        
        which wants to construct a whole map just to extract some properties
        
        Change-Id: I79ea0e2d53c2b4aa8182b0622fe0cda2eaacef0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [59b5be40056721218be7304607c4eeaa339b5cba]

        reserve space in vector
        
        Change-Id: Ibdc882eff13b767076fc26f4c7cd7882bcb7f68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134222
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Miklos Vajna  <vmiklos@collabora.com>  [9f37840b0d7778ab4fc3294c44f62198ea932e3f]

        sw content controls, dropdown: add insert UI
        
        - introduce a SwContentControlListItem::ToString() that tries to use the
          display text of the list item, otherwise falls back to its value and use it
          while building the dropdown widget and when inserting selected list item
        
        - handle the dropdown case in SwWrtShell::InsertContentControl()
        
        - expose this as a new .uno:InsertDropdownContentControl command
        
        - mention the new and all previous content control commands in the
          MS-compatible forms menu as well
        
        Change-Id: I075f77933c1466b5258357d5a661e173c34de34f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134215
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-12  Alain Romedenne  <alain.romedenne@libreoffice.org>  [e98a68b23e14580dfa236536254b6ff80cd10df7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 400a0ea4d37d8d2ccd2ee51a661aa9aecf440e5e
          - Filelen() Basic function's upper limit is 2GB.
            
            This patch links to ScriptForge.FileSystem.GetFileLen() alternative method who returns higher range numbers, assuming libO Python Scripting framework is present.
            
            Change-Id: Id4a3f47cbe7be2ed27d162532b87c1388f23fce1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133857
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-05-12  Michael Stahl  <michael.stahl@allotropia.de>  [58a3bf5199818e30ef4207213f29692d81b519c6]

        curl: upgrade to release 7.83.1
        
        Fixes CVE-2022-27774 CVE-2022-27775 CVE-2022-27776 CVE-2022-27781
        plus 6 more CVEs that shouldn't affect LO.
        
        Remove obsolete configure-eval-fix.patch.0.
        
        Change-Id: Ifbd7ff5acf390df1d95d6b8be0dc7751e4753bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134225
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-12  Luboš Luňák  <l.lunak@collabora.com>  [818eeaa3ae7146190c71b7e8901bd7f67aa672b8]

        IsEmptyBlock() -> IsEmptyData()
        
        It's unclear what "block" is supposed to mean, as that may mean
        "cells with no value", but a cell also may have a note, or since
        recently apparently also a sparkline. To make it even more confusing,
        there is IsBlockEmpty(), which may explicitly take bIgnoreNotes set
        to true, in which case it presumably should check only data, but then
        the recent sparklines addition still counts sparklines even in that
        case, which is presumably a mistake.
        
        Rename the data-only function to make it clear, and remove the extra
        argument from the empty-in-all-ways function.
        
        Change-Id: I8e3f75407d243b733d61640e2f54954762601ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134217
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-12  Luboš Luňák  <l.lunak@collabora.com>  [1e990a5ab399a1bb15d4002ca30f13611ba6edbc]

        fix up order of some ScDocument functions
        
        For better or worse the usual order of arguments in Calc is
        SCCOL, SCROW, SCTAB, so make this consistent.
        
        Change-Id: Ie63c75f5ae92f82cb757c0873f7ff569f331e0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134229
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-12  Caolán McNamara  <caolanm@redhat.com>  [d9b072cd077cbb515e5aef584d98cb5deda48776]

        tdf#148740 draw expanders instead of using icons
        
        and then the color of the expander can simply follow the text color
        to get contrast for the selected entry case.
        
        At some point someone thought it would be a good idea to expose via
        uno the possibility to set custom expand/collapse icons so retain
        that support.
        
        Change-Id: I44c40bf691cae228e184e58ed848001aaa4b4996
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134168
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e4c966a894070e739ff93cca1c841f2cd95d082e]

        bump product version to 7.4.0.0.alpha1+
        
        Change-Id: Ifde1b0dba9dbbd9c4bba614098afff530cc0fdd9

2022-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [063a38a7b05fcbeb01cea99e52e0e3c18d65f1e8]

        Simplify this a bit
        
        Additionally, use UNO_QUERY_THROW where the result is
        dereferenced unconditionally.
        
        Change-Id: Ia8860c037732e6f59d0a71e0ad7866121157f24a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134181
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3c6a0a8703f922757dae2fa77d3dd7a7bdf317fe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3164d8b3f10d2d3f856182044ff541adfcb1439
          - Add dir attribute to html element based on language directionality
            
            Change-Id: I1dbb6cc2f3497ab70a806c94ad9d52ee1e10c13f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133294
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-05-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe000080c514891f7cd65c3dd1c6f38732d78e7d]

        tdf#143612: map SecondaryRefValue in form pdf export
        
        Change-Id: I590784eb94fb6f4f3a20c4f6d8e3fb618f60d0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134227
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [5551871733685b042ca40f86e98c85403c425085]

        Simplify ScTransferObj::SetDrawClipDoc a bit
        
        The two ScGlobal::xDrawClipDocShellRef.clear's were born in
        commit 623f5b26ffd77041d0b06d7ce9c3b32d05625440
          Author Noel Grandin <noel@peralex.com>
          Date   Tue Oct 27 15:12:58 2015 +0200
            don't allocate rtl::Reference or SvRef on the heap
        
        from separate calls to 'delete ScGlobal::pDrawClipDocShellRef'
        and 'ScGlobal::pDrawClipDocShellRef = NULL'.
        
        Change-Id: Ie214feda4bc139bd6fccfbe525d7193a5cd02bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134180
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-12  Mike Kaganski  <mike.kaganski@collabora.com>  [1ef99f117def74c52709b54ba971b4e348b14bad]

        Create a visualizer for OUStringLiteral
        
        ... and adjust _rtl_uString visualizer to use 'u' prefix, not 'L'
        
        Change-Id: Ie3b5de9c69fea8588503f22d1d367a28148d7f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134178
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e9fd1f8c6a70d527e94c89dc57aeb02f1886ecd7]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9ef7b8c2ece5a5fc774c5226151a84a84958015e
          - update translations for 7.4.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I3a84cc714bc77bdd377424a708c53651db476b81
            
2022-05-12  Seth Chaiklin  <sdc.blanco@youmail.dk>  [8afd0dcbe23846c12c830b2637db7993a0aa5942]

        tdf#148941 consistency between popup box and option dialog for objects
        
         cui/uiconfig/ui/objecttitledescdialog.ui
           * change "Title" to "Text Alternative" to use the terminology from
             Web Content Accessibility Guidelines (WCAG) 2.1
             https://www.w3.org/TR/WCAG21/#dfn-text-alternative
             which is also consistent with the purpose of this option in LO
           + add tooltips to "Text Alternative" and "Description" in
             Description popup box. The idea is that the tooltips will
             help to understand the purpose of dialog.
        
         sw/uiconfig/swriter/ui/frmaddpage.ui
           * _Alternative (Text only) -> "Text _Alternative"
             [This change matches the change in the popup box]
           + add missing : to "vertical alignment", according to HIG
        
         officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
           + add tooltips for the "Name" and "Description" .unos, primarily
             for the customize dialog, and icons in notebookbars.
        
        Change-Id: I1943b49e13763371823bfcf2cfc8652c907de110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134066
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-12  Caolán McNamara  <caolanm@redhat.com>  [70034096f20ab545e52e683e3a97b4b8f41ec4a8]

        these members can be private
        
        Change-Id: Icab045ac04f3e556672191b8df454f8f29ecc6d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134221
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6d2f218ad0dd1f3817411c4eb42dffc5bea9bf5]

        related: tdf#148442: do not replace 'Yes' if onValue is empty
        
        Change-Id: I748422dfbe7a385f4206c5d129eb3091289a180d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134220
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-12  Caolán McNamara  <caolanm@redhat.com>  [986892ddee74dd666dd467962a2effb21df96cb5]

        we already know the length of the string we pass to hb_language_from_string
        
        Change-Id: I860ed7c253ef872ed6609a01030294609cbbb78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134209
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [301b5c0aea7a525c436b0f2f54a8cef8be947c89]

        tdf#121740 avoid some temporary OUString construction
        
        Change-Id: Id70349e0e8f7d79bad693663ec3dc2963e0834b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2c4330b3570f16d6668936fd05e1ab2ade597bae]

        tdf#148835 don't write any sparkline xml elements if none exists
        
        Change-Id: Idd4058a88639cebceded13110dc367e74b6f7097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134141
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-12  Michael Stahl  <michael.stahl@allotropia.de>  [ebbf4004d6061c3b31f9749bee06ef87afc5deb9]

        framework: fix lock assert in Job::execute()
        
        include/osl/mutex.hxx:196: void osl::ClearableGuard<T>::clear() [with T = comphelper::SolarMutex]: Assertion `pT' failed.
        
        because clear() was called, then an exception was thrown and reset() was
        omitted.
        
        Change-Id: Iaa6d26e23261c2426eb3cc465b212752c4f454e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134195
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-12  Stephan Bergmann  <sbergman@redhat.com>  [32714f966186d301435d3eb9f7f6950bc9a6bb1e]

        -Werror,-Wformat
        
        > sal/cppunittester/cppunittester.cxx(553,65): error: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Werror,-Wformat]
        >             printf("\tat unknown (Error in SymFromAddr=%#08x)", GetLastError());
        >                                                        ~~~~~    ^~~~~~~~~~~~~~
        >                                                        %#08lx
        
        and DWORD should presumably always be a typedef for unsigned long according to
        <https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/262627d8-3418-4627-9218-4ffe110850b2>
        "2.2.9 DWORD"
        
        Change-Id: Ib1394c54fd649108bb6f6c748a5b7eae798884ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134214
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-12  Caolán McNamara  <caolanm@redhat.com>  [39d011376b9bcf020bcb9e05121bb0dfb01f8822]

        merge SetNodeBitmaps and SetNodeDefaultImages
        
        Change-Id: I31a9cc0fc9f97d564f9c8eac0c483892ae3c774f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134210
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-12  Mark Hung  <marklm9@gmail.com>  [3dcf845691ee55621a9475d7c39cbc63611c3f7a]

        tdf#148940 improve non Snap-to-char mode textgrid layout.
        
        - Revert b647f9f4bcb24ed9b71c77038da6b754b8d42eb7 , i.e.
        tdf#107362 don't insert kern if snap to char is not checked.
        
        This includes:
          a) Revert to insert kern portion to align the next CJK
          text portion to the next grid cell border.
        
          b) Revert none snap-to-char code to proecess CJK script only
           as before. Latin and CTL scripts are processed as witnout
           text grid.
        
        - EvalGridWidthAdd() now uses the 0th element of kern array as
          the glyph width to calculate the distance to the nearest cell
          border. This makes layout more accurate and do not generate
          extra spaces, allow testTdf107362 to pass.
        
        - SwFont::GetTextBreak() non snap-to-char mode now uses the same
          code as snap-to-char mode to calculate the accommodable text
          length. This fix one excess character per line problem for non
          snap-to-char mode.
        
        - Update testTdf107025 because the character in the test case
          occupies more than one text grid cells. Layout change has been
          verified.
        
        - tdf#107446 breaks again because of the patch. It needs different
          solution for Word compatibility.
        
        Change-Id: I7fadb065b9cce2d71aaaed39be2881c43d8e4db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134001
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-12  Stephan Bergmann  <sbergman@redhat.com>  [dd2010e79fb2ccb46e602bf0546487b7d1b095f1]

        -Werror,-Wunused-variable
        
        ...since 92f93f300371d2011b53d48d3491870b24cff0b4 "output error code when
        SymFromAddr fails"
        
        Change-Id: I9d831e363fe98068cb55102628c98aa9d4ad5d3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134213
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf954c71850521405176c6cbe4bf636806421c21]

        elide temporary std::vector in Access::getElementNames
        
        Change-Id: I9a875d5615930700e20f67c40b4b7a24458fd447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134198
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [8969695b2b764a7bebf183d80b1161a142536566]

        pre-size the maLinkHash map to avoid allocations
        
        Change-Id: I926747d852dc2de56b7125132e74a1c23c75bbd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7f527a0add582cde2f34d992b65ed6ec79633d4]

        tdf#121740 std::set->o3tl::sorted_vector in ImpEditEngine::FormatDoc
        
        we're almost always adding to the end, and we can size the vector
        up-front, a perfect application for sorted_vector
        
        Shaves 2% off load time.
        
        Change-Id: I708ff1451b91635b54eaea0355a03a84bd775754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-12  Miklos Vajna  <vmiklos@collabora.com>  [109debb0ca0c864296ad7f557cfbc2b05c9ec3c2]

        tdf#148961 sd theme: add PPTX export for shape fill color effects
        
        Which allows taking the fill color theme index from the model even in
        case there are effects.
        
        Previously effects meant reading from the grab-bag, and only the
        no-effect case read the color theme index from the doc model.
        
        Change-Id: Ib50c3128b971a388f14ad721ed7f73043916a736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134208
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-12  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [d45315c8eb91862958b29ead09cec58e03a80096]

        tdf#142840: doc export: use BookmarkToWord() for hyperlinks
        
        Inernal hyperlinks to bookmarks should not contain spaces. This
        is not required for RTF or DOC: MS Word is okay with spaces there
        (unlike in DOCX). But since we are replacing spaces in bookmark
        names we should do this also in links to these bookmarks.
        
        Change-Id: I7a3e530817572ed53032c2be1ad96f8e8498bac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133590
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-12  Eike Rathke  <erack@redhat.com>  [fe687d1b8f5305edfb167152a4fb19ffa20c5404]

        Related: tdf#142635 Remove address parsing failback code
        
        This could not have been correct. It may have served some odd
        purpose back when it was added with
        
            commit 296baa2fb6dd4150a7855114093a9703cdc18b09
            CommitDate: Tue Oct 5 18:14:37 2010 -0400
        
                Ported calc-extref-interpreter-rework-*.diff from ooo-build.
        
        during the transition from ocExternalRef to ocPush with
        svExternal*Ref, but parsed syntactically wrong strings and all
        valid external document references with "'filename'#" had been
        detected earlier at the beginning or passed via
        pExtInfo->mbExternal. The case it treated here is neither a valid
        OOo nor ODF notation.
        
        Change-Id: I5a519aec4b251720da382cb76a93ab10c8aeb493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134212
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ee5fb6d32147e180552f66e615d1de932fdcf9c]

        tdf#148442: map RefValue property to onValue in pdf
        
        Similar to what it's already done for radiobuttons
        Change-Id: I708d23dc5f9d4470a9850d7ecc60bd71fada594e
        
        Change-Id: I34107c757b0e0933f392a6d0845fa0d2e07aed62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134170
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-11  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [49ddbc94a088344bf69444445a0300342ea3f184]

        tdf#148148: Applying Title Case when selection contains only spaces
        
        Previously, if the user's selection does not contain any word
        characters, but the node does contain characters outside of
        the user's selection, then searching for the word boundaries
        when applying title case could result in start and end points
        that were incorrect. In Writer this results in title case
        being applied to non-selected characters. In Calc this results
        in a debug assertion being hit.
        
        This commit prevents those issues by skipping transliteration
        on the node in this case.
        
        Change-Id: I20c5ef44793741c5863f838c13ba222452346a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132801
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d63a011ed161a01419a40ab2fbb88796d59b20a]

        tdf#121740 just remove OLE_Objects limit for non-32-bit-Windows
        
        shaves 5% off load time
        
        Change-Id: I1893180124ebe86babff1776d77a696ef1e4a190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134202
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cfb15d06e82ff9af6a9de2dab815b15e9724c9c6]

        in SbUnoObject constructor, only query for XTypeProvider
        
        if we're going to use the result
        
        Change-Id: I49ad11e287f58c1021e509f56d934aa3ce745b0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134201
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cde416fea13c6020805ac663e254a50b2c885abd]

        in SetGlobalUNOConstant, only retrieve old value if we need it
        
        removes some unnecessary Find() work
        
        Change-Id: I6af9c4d9a043d4361fcca1a034b2025fe7c10c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134200
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8e144638c10f81a25478dd8d8061d7d870b383c]

        osl::Mutex->std::mutex in SvtSysLocale
        
        Change-Id: I722c4ca5d1bb6c0de6b1eff7478de03a23e9d89b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134199
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [bed301f42f0e51126c63c02c9a78091f7dec420c]

        elide temporary OString in GenericSalLayout::LayoutText
        
        Change-Id: I2169087bf780fb7b42aad8db0ee7484bf48d9ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [02446d13764d90567114525f648475b41d6b0d12]

        use better default size for UNOMemoryStream
        
        which means we don't need to re-allocate the buffer as often
        
        Change-Id: I81678af2ed4146b94eb200324459eef7016afd06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134196
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Caolán McNamara  <caolanm@redhat.com>  [dad7593cf6bb91ecf95153e983723dd2cd03b469]

        GetDontKnowNodeBmp is always empty
        
        so this is dead code, remove most of it, but recover setting
        aControlValue.setTristateVal(ButtonValue::DontKnow) when the
        possibility of expansion resulting in children is unknown
        
        Change-Id: Idc2abd9af70402a92d02ed2273ab1df6684b16fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134194
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-11  Caolán McNamara  <caolanm@redhat.com>  [528008104bcb7433f818ab3e8bf10bf1296e09b9]

        tdf#149029 Scroll to the selected object in the Animation panel on selecting
        
        Change-Id: I2c14f9c6df74d4534c936b392f0e066dabebea9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [5caa7f44b861876afa5b3b8f71e3848abd8875e6]

        fix HB_GLYPH_FLAG_UNSAFE_TO_BREAK for RTL in cloneCharRange() (tdf#148954)
        
        I got the meaning wrong, when the docs talk about beginning of a cluster,
        that refers to text, not glyphs, so this needs to be backwards too.
        
        Change-Id: I12ef775b033100405e3332d5611844cefb6b5a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134173
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Caolán McNamara  <caolanm@redhat.com>  [828a51e8617ece858b2f8bdc4a8d8759595beab0]

        tdf#149023 set property immediately on change
        
        and not in an idle which may be triggered on losing focus and
        arrive when a new shape is selected
        
        Change-Id: I7cec8f1c9bf864cdb30516dece1ef9d6b689a94e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [6d9691892b192f7fcecc0a938e929fc40ec208d8]

        Inline the typedef
        
        ... and simplify SwOLELRUCache::InsertObj a bit
        
        Change-Id: I7461e800ade0e0c3f2a1cd79715cecd5cfc971bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134174
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-11  Caolán McNamara  <caolanm@redhat.com>  [a66e2231c15321835e34469edb748947d6de3464]

        tdf#148730 set current widow/orphan state even if do not split para is set
        
        Change-Id: Ibdb6a830ad502cf04598ce9cd1c232ad6d9d8ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-11  Stephan Bergmann  <sbergman@redhat.com>  [c1c5ac11658966bddb60482e83bfd0cb7a88a318]

        Drop unnecessary cast to int
        
        ...when iterating over the enumerators of enum StatusBar_XML_Entry resp. enum
        ToolBox_XML_Entry
        
        Change-Id: I11904e941e98e0ffb96cf1ba4e61c91382944813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134169
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-11  Stephan Bergmann  <sbergman@redhat.com>  [da3aa26efddebbbe2af2a1895f89198f66b5c27c]

        Library_syssh must link against expat when using StaticLibrary_shell_xmlparser
        
        ...which in turn uses expat, so this caused a Linux build of mine to fail with
        
        > [LNK] Library/libsysshlo.so
        > ld.lld: error: undefined symbol: XML_ParserCreate
        > >>> referenced by xml_parser.cxx:74 (shell/source/all/xml_parser.cxx:74)
        > >>>               xml_parser.o:(xml_parser::xml_parser()) in archive workdir/LinkTarget/StaticLibrary/libshell_xmlparser.a
        
        etc.  (No idea why that only started to hit me now, seemingly out of the blue,
        but it looks plausible that we need that fix.)
        
        Change-Id: I1d0efabf8cc809bd82ce30ec67d16ce1eb547de0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134167
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8055ad41bbde67d0be0b240218295ea16c03d136]

        cache the PropertySetInfo in lcl_createModelPropertyInfo
        
        we only need one of them
        
        Change-Id: I2f6f2c75da96f76d4bf9cb31ef31bf597a3f5e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ca5cdbd87bedc6a239dfed060d3100ea5e0196e]

        reserve vector space in SmSymbolManager::GetSymbols
        
        Change-Id: I9101e07fa54e35f1cec9797deaf1647763c9ebfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134158
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd0586f2d52699b1270e307c7cd76470ab40b7c3]

        reserve space for bulk operations in SequenceAsHashMap
        
        reduces the number of allocations we do
        
        Change-Id: If8e61c8b0dd1942278d7adc1fa87580734aeeb99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9d450875c8a0bea2468f65c7a57b9ff77344b6c8]

        only instantiate SfxFilterMatcher when we need it
        
        Change-Id: Ibb6162ddc6bec73beef6fffc8cf53976dc82313a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [b03aa654eb2e2980f3efc0347b1435414d8f1d09]

        cache the Sequence we return in comphelper::PropertySetInfo::getProperties
        
        Change-Id: If4e6e43be5d7380665e56bf95c446ff14e6a7213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [52a0f9e6b881c21275358de3ec9b4c85f77402e4]

        avoid some ref-counting traffic in configmgr::Access:getNameInternal
        
        Change-Id: I3062855ab8f9ec9f1e7cdffe163f1c78865d5b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [86453991a7ca0c7f90ae95769ee23cd5ccecd83f]

        Add error handling to RenamePrgFolder and RemovePrgFolder
        
        These routines can fail during MSI installation
        (seen leftover program_old folders, with program folder missing).
        
        We at least want to see the error in the MSI log file when this doesn't succeed.
        
        This outputs error messages like:
        
          MSI (s) (C4:5C) [10:47:54:280]: Invoking remote custom action. DLL: C:\Windows\Installer\MSI37B4.tmp, Entrypoint: RemovePrgFolder
          CustomAction RemovePrgFolder returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)
          Action ended 10:47:54: RemovePrgFolder. Return value 3.
        
        Change-Id: I4ce4099eeb3e0ee79eb4a2e1d3887f9810fd9669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134160
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-05-11  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [1e016920769ae524575e40b1ec317c700ba0daa3]

        Advanced Diagram support: UNDO/REDO support for Diagram DataModel
        
        Added support for UNDO/REDO for changes in Diagram ModelData.
        This is currenly applied/used in the DiagramDialog for it's
        Add/Remove actions (also supports Cancel of that dialog 1st
        time ever). But it is defined more general to add/support
        manipulating actions like clone/change_text etc. Also the
        UI/dialog at he end will not be/stay modal, so this is a
        test implemenation how to use it.
        
        It uses an extract/apply mechanism to get/set the Diagram
        ModelData at/for the UNDO action. That may be expanded as
        needed for additional data in he future. It may also be
        considered to modify the Connection/Point ModelData to
        shared_ptr internally completely to avoid copying these
        at all. OTOH it is not that much data to handle at all.
        
        Change-Id: I4702ed908b79a476177fe66c0e3284898c6adda5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134118
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-05-11  Stephan Bergmann  <sbergman@redhat.com>  [5b9b07dcb3e0065ddb616a0a5b0e69c1c3841fa7]

        Revert "Disable -fsanitize=float-divide-by-zero in rtl_math_atanh"
        
        This reverts commit 6a4504bba84dcbaeb71869ec5c9ed6dfdc090619, which is no longer
        necessary after 6f75ec6115f0152517be634070607bc61bf96dd0 "tdf#148430 Use atanh
        from <cmath> instead of our own" changed the implementation of rtl_math_atanh.
        
        Change-Id: I11094f8c9fb0bb7b635541e7360e460816d3c171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134161
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e6e5d90121aebf1aa617a43f5685ffaa8b7e8aba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a71181cd6bd1b204e5b466c97b6e0e6c4434cca
          - tdf#148861 update Outline bar for Impress
            
                simpress/main0211.xhp (Outline bar)
                  - remove "Zoom" and "Slide Show", which are no longer
                    on the Outline bar
                  + add "Demote", "Promote", "Move Down" and "Move Up"
                  * change order of controls to correspond to Outline bar
                  * refactor to <h1>,<h2>
            
                simpress/02/11110000.xhp (Black and White)
                  * refactor image to 1cm, .svg, alt icon label
                  * refactor to <h1>
                  - remove colspan="" rowspan=""
            
                simpress/02/11100000.xhp (Show Formatting)
                  * "Formatting On/Off" --> "Show Formatting"
                  * refactor image to 1cm, .svg, alt icon label
                  * refactor to <h1>
                  - remove colspan="" rowspan=""
            
                 simpress/02/11060000.xhp (Show Only First Level)
                  * "First Level" --> "Show Only First Level"
                  * "All Levels" --> "Show All Levels"
            
                 simpress/02/11070000.xhp (Show All Levels)
                  * "All Levels" --> "Show All Levels"
                  * "First Level" --> "Show Only First Level"
            
            Change-Id: Ie4d57852d1e7cf702371071b5aa76a7cb502737e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133729
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-11  Miklos Vajna  <vmiklos@collabora.com>  [1e9416fac497a58be04011cfa0ffce9c74a9e397]

        sw content controls: introduce a word breaking dummy char at the end
        
        - this way double-clicking on the last word of a content control or the
          first word after the content control selects the correct text range,
          similar to how the same at the start of content control already worked
        
        - this allows not touching the expand flag in the SwTextContentControl
          ctor, which was overwritten by the ODT import (when the content
          control was at the end of the paragraph) anyway
        
        - hide this dummy character when accessing the paragraph content via the
          UNO API or the text export
        
        - still need to audit a few more places in follow-up commits to maintain
          the invariant that content controls have the same dummy char at the
          attribute start and end -- somwhat similar to how SwTextInputField
          does it with CH_TXT_ATR_INPUTFIELDSTART/END
        
        Change-Id: I88763d6db84afedbb865b680f040994c4d6ab7d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134151
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [35dec195a1f0a7a3aa8fab893698e512f5851d19]

        use -g with --gdb-index in configure
        
        It triggers an assert in mold's --gdb-index handling because of missing
        debug info. It sort of makes sense that --gdb-index should be tested
        with debug info actually used.
        
        Change-Id: I5adced29355deec9f0a6af390867f4ff2f2bd29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134153
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [c05c826bd18eedaa7720ff0817b5c796435dbc02]

        search faster an array where most elements do not match (tdf#144777)
        
        As said in previous commits, clearing and searching this array
        can be the major cost of large *IFS operations. And memchr() can do
        way better than what the compiler generates.
        
        Change-Id: Ibcaad05356f9fa33997593f929522b325c026579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134139
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [a49afabb0cf1eac8f1214bfada0d7c9bc662878e]

        reduce size of *IFS conditions array (tdf#144777)
        
        The array is used to count the number of matching conditions
        e.g. in COUNTIFS, which can be only up to nQueryCount, which
        is sal_uInt8. So there's no need to count it as sal_uInt32,
        and doing so may cause 4MiB array per thread for full-column
        references, which causes easily causes 60% of time spent
        just clearing and checking the complete array.
        
        Change-Id: Id4bebf90619f7f2a721edb9cd31e6a11469579aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134138
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [248e49d3f409d414331945ba91b3083406d59f78]

        no PerformQuery() with ScSortedRangeCache if not needed (tdf#144777)
        
        It should not be necessary in that case, since the rows are restricted
        only to those that match, selected by BinarySearch(). Still at least
        assert that, just in case I'm missing something (or BinarySearch()
        doesn't quite match what validQuery() does).
        
        Change-Id: Ie91d3ba997692e5b3650b1549e8a38b6c5f44c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134130
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [4c8f4390c846e0184955916b0555359a6ad98981]

        do not use ScSortedRangeCache inefficiently
        
        If the amount of data or size of the formula group is small, the caching
        is probably not worth it. And if rows are not absolute, then each
        formula cell would use a different range instead of reusing the cache.
        
        Change-Id: I42a82aaa5f4ffccc63e527793f46fc52fd539af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134129
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [905475435c85ebae9ec48e37de4768e1b92914d2]

        limit rows to ones having data when computing ScSortedRangeCache
        
        Change-Id: I2de9ea4887b6101f10eb3b8da6f3596de0ea09eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134128
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [12b8230c9e541e5bf14026ca3684e0880692e3d4]

        faster reverse mapping in ScSortedRangeCache
        
        Profiling shows this to be a noticeable cost.
        
        Change-Id: Ib247a75b77d721f2486a1fe50eb243437d865561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134127
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [4db2b19fe887cbf55d773f2af79ef5fe4d71908a]

        avoid somewhat expensive mdds position() call if possible
        
        Change-Id: I095f6285b9e1da5869ca08a0d8e6fae9ace40cfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134126
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [5b189abc13d4a9e408c82298e4ede0fdf505002d]

        make ScSortedRangeCache work for also ScQueryEntry::ByString
        
        Change-Id: Ifa769e20d91f7899fa81df537a7f3b7aeff52115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134125
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [4794aa29587255aaff1196e0cc6e29d136df7b76]

        make BinarySearch() do proper SC_EQUAL with ScQueryEntry::ByString
        
        ScQueryEvaluator::isQueryByString() makes everything a string search
        in this case, so this one should too.
        
        Change-Id: Ic1ebd14515cfb7f253f022ca4f76699a6cb63468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134137
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [e98a22b4e4f9c5a9249e634dd0489d30d9de2bb1]

        use ScSortedRangeCache also for generic queries
        
        This enables use for e.g. VLOOKUP or COUNTIFS (as COUNTIFS does
        not use the specialized code for COUNTIF).
        
        Change-Id: Idad7503750d421f3f1c9ac34dfe95393fa3ead15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134124
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [eaa2b5054443a1d6b7b5289eb44b8edf8a4c832e]

        make internal ScQueryCellIteratorBase functions protected
        
        Nothing is using these outside of the class.
        
        Change-Id: If2e1f2ce30980adeb1ce007f6084f492b314dd5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134122
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [18eeb85d4899fa8e4a2b1a84fc4a32c3a94f7640]

        keep only a reference to a vector if equal to what's wanted
        
        This avoids copying the data repeatedly.
        
        Change-Id: Id3fadf8414c66143e12261a14b75b984415ed9a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134121
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [122e676ce35b34c289cc4c91bb72e25398dc9e12]

        introduce Calc cache for sorted handling of unsorted cells
        
        The idea is that there's a cache for a given range, which keeps
        a vector of SCROW items, sorted by values of those cells. This
        allows some specific cases of e.g. COUNTIF to simply use
        BinarySearch() to find the range that matches and work only with
        that. This commit implements using this cache for COUNTIF.
        
        Change-Id: I5b36b289b4aecb3b8245bbb447fbb299371262e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134120
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4b87523605cf87b548d6eb2604c1d5e84f925038]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 61b4b76000bd5adca504df0966ecef3410765ab3
          - tdf#149012  updating of Options tab for Frame, Object, Image
            
               text/swriter/01/05060900.xhp
                 * corrections to control names
                 + added embed to "Description" which was missing, but
                   an adjustment will be needed in a subsequent patch
                   because the embedded file header describes the command
                   "Description" and not the field in the Options dialog box.
                   But the description is close enough to be useful for now, and
                   another patch will be needed here because of changes to the
                   dialog as a result of tdf#148941, so necessary adjustments
                   can be made as part of that followup patch.
                 * identify "frame only" controls
                 * change position of "Content Alignment" to match dialog
                 * refactor to <h1>,<h2>,<h3>,<tip>
            
               text/swriter/00/00000405.xhp
                 * clarify that frame styles should be used in sidebar
                 * refactor to <menuitem> for clarified paragraph
            
            Change-Id: I82e62a2d2fd49c44b779ac79e102a5b8623196ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134065
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-05-11  Luboš Luňák  <l.lunak@collabora.com>  [976a07a1dfbb136ac4f4daa6dddbda608390db7d]

        make it obvious which column BinarySearch() operates on
        
        It was setting the column to ScQueryParams.nCol1, which
        was somewhat confusing.
        
        Change-Id: I3ab2207f507a4dc3782ea78682dacb0b08c36b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134123
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4348d11156e4aae1d28bc01513b121c23f1d8d54]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44126837152e16fa861ded498f315d57b574e441
          - tdf#148943 Clarify CSV import token 4
            
            Change-Id: I5c0094293a1d8a9125cfc2d129681e0c456e8f99
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134135
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fe3202e99901d82b0df03e739f3a02b00441fda]

        elide temporary OUString in GetFilter4FilterName
        
        Change-Id: Idd51eb5f86b5d8148fe31ff69e17ce2d5724e6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134150
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Stephan Bergmann  <sbergman@redhat.com>  [e9b5518b4c53cf67860a504f2f1b823625b03788]

        Don't leave ImplFontMetricData::mnHangingBaseline uninitialized
        
        ...after 5f92e8cf3da6b5f66b6ef23219fcc91d2ad7c754 "tdf#104930 Implement
        TextMetric::GetHangingBaseline", to avoid UBSan failures like
        
        > [_RUN_____] (anonymous namespace)::Test::testLineSpacing
        > /vcl/source/outdev/map.cxx:291:9: runtime error: signed integer overflow: -4702111234474983746 * 1440 cannot be represented in type 'long'
        >     #0 0x7f408a2ba5fe in ImplPixelToLogic(long, long, long, long) /vcl/source/outdev/map.cxx:291:9
        >     #1 0x7f408a2bac1e in OutputDevice::ImplDevicePixelToLogicHeight(long) const /vcl/source/outdev/map.cxx:361:12
        >     #2 0x7f408a136ddc in OutputDevice::GetFontMetric() const /vcl/source/outdev/font.cxx:217:33
        
        during CppunitTest_editeng (<https://ci.libreoffice.org/job/lo_ubsan/2395/>)
        
        Change-Id: Ief2121c588d296a23606314143a0176c8ae9aa38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134142
        Reviewed-by: Mark Hung <marklh9@gmail.com>
        Tested-by: Jenkins

2022-05-11  Gabor Kelemen  <kelemeng@ubuntu.com>  [48c6046fa972536fd6fcda88ac5aa825969a6fdb]

        Drop IS_EDITMODE macro that is used only once
        
        Change-Id: I2fb5b8eb34aa18c35d3a53851ce8d92090d85590
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133982
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-11  offtkp  <parisoplop@gmail.com>  [6f75ec6115f0152517be634070607bc61bf96dd0]

        tdf#148430 Use atanh from <cmath> instead of our own
        
        Change wrapper in rtl::math::atanh to use atanh
        from <cmath>. Also changed all occurrences of rtl::math::atanh
        on files that use this function to directly use the standard
        atanh instead.
        
        Change-Id: Idc5c456f67291f5816756f023b61afde844b5ceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133965
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c61a88d9d23366274d4d2283a961a578911e5ddc]

        Fix typos
        
        Change-Id: Ie15016f4cbed703f15d7d47c25b7bfc2b41dbadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134106
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [04669a3a466d34d3452c88f4712b6ea6befb4d53]

        basegfx: generalize B2DRange and B2IRange with Range2D template
        
        Also add and/or re-arrange B2DRange and B2IRange tests
        
        Change-Id: I0f582b30c92776ffbab8b69810ec855da0931714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134111
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-11  Miklos Vajna  <vmiklos@collabora.com>  [24417d8c3c9e1c619936e85fa7a20481a24e3530]

        sw content controls, drop-down: add DOCX import
        
        - inline drop-down content controls were imported as an SwDropDownField
          previously, but that has the drawback of not being able to store both
          display texts and values of each list items
        
        - adapt tests under sw/qa/ which asserted that the import result is a
          field, and check content control properties instead
        
        - change dmapper so that SdtControlType::dropDown is one more inline
          SDT that gets mapped to SwContentControl
        
        - remove the no longer needed grab-bagging in writerfilter/, otherwise
          we would write the SDT markup twice on export
        
        - improve DomainMapper_Impl::PopSdt() to actually map the collected
          dropdown properties to properties on the to-be-inserted content
          control
        
        Change-Id: I7e88ec8cd1d73bc1c6c75154d6ab07352cbcec8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134143
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [3322e500f48794d3569c27f73cc5f3bafb5f2397]

        avoid some OUString construction on some hot paths
        
        Change-Id: I098b017d22b7a4502998a0901ddcfca08a57ee43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-11  Miklos Vajna  <vmiklos@collabora.com>  [078e65cac18fec8729ed8087233caa1655a02d02]

        CppunitTest_sw_ooxmlexport12: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I1f0fdb4947c0a9763d145d4926b37c7576a25cad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134134
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [405ab3483498efa55cda9ebf54103a5e3e097627]

        Avoid useless default construction
        
        Change-Id: I6b4cb48ab4e8f22b30a92fcf7d1de94b5cb9f34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134068
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-11  Kohei Yoshida  <kohei@libreoffice.org>  [1729da22a7f57eba6531d15388c67cb710fc3c30]

        Update mdds to 2.0.3.
        
        This release includes a revised block position search implementation
        that shouldn't touch the internal STL iterators so that even if you
        pass an invalid position hint, it should not trigger process
        termination.
        
        Change-Id: I8c76eb012ba7ce304ff10b38de468b7c9c6cce2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134140
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [172e208e6b0674f42c301c5ee5e280e9138ba1b4]

        chart2: prefix VDataSeries members, rename Double to m_aValues
        
        Change-Id: I74d560fa8a9c9d1ee761b26aa1ca90798f774a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134052
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [462457455e9664a4ba79c4b21747cdb4e47da6ca]

        chart2: remove code duplication in VSeriesPlotter::getSeriesNames
        
        Change-Id: Ib7b96e6fe0037a141efe696252ff2aa4a38ec327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133924
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [35f4f75a506839025bca529bd7cc5a60ffe7a20f]

        chart2: simplify with structured binding decl. and some cleanup
        
        - use structured binding declaration to simplify the code
        - use cend() instead of end()
        - use std::clamp to bound a value
        
        Change-Id: I83b9ba926e70d173cc161db713c53940df422241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133923
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-11  Eike Rathke  <erack@redhat.com>  [23689e492feb41a391738586cef04ab82cc21f80]

        Resolves: tdf#132582 Display duration for calculated time values selection
        
        Change-Id: I634cd0fb059ed9c35849b435bcbd178cd84ac2ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134132
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-10  Martin Srebotnjak  <miles@filmsi.net>  [52ebc944cf9c45ad6dc7f925c685472dfb7fc3e6]

        Update git submodules
        
        * Update translations from branch 'master'
          to d36f933b283e37e9bc85fc735a6df888154737f7
          - Updated Slovenian translation
            
            Change-Id: Iee6df28adec7863a8e2fcfff70b5f4056e393aad
            
2022-05-10  Andras Timar  <andras.timar@collabora.com>  [cb90a63846c2898974c5345a369a049ce0a81772]

        Update git submodules
        
        * Update translations from branch 'master'
          to 542c2f1192e848ca6ccf4f89b770774f7fbc6508
          - sl: typo fix
            
            Change-Id: Ib2330886ca3a0072543e017deda7a78985602190
            
2022-05-10  Caolán McNamara  <caolanm@redhat.com>  [4b693a0c594fb3b73f4a4c1e03e9916f1a107012]

        tdf#148470 if macOS glyph fallback provided a partial result flag what failed
        
        so another font can be attempted for the remainder
        
        Change-Id: Ie2c67c7c63510d02c99f2377c0c43ed6050ccd86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134131
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ad79900cd62c487bda9d2515892d62b3b08a5dfa]

        tdf#108188, tdf#131190 - Verify that the page style is actually used
        
        Change-Id: I007d26c6fcaf60d2a2378cc00e630da447f95a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134022
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [adb5eca79f3ae0c80c8046e73d7a411734a1b75d]

        Fix typos
        
        Change-Id: I48781032778c403420b3258c53e4be5d2b7531d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134133
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c25a2a114c0bb66641ad27499610fe5ee4393b9]

        tdf#121740 dont bother checking for VBA libraries
        
        speeds up loading by 2%
        
        Change-Id: I63bf7ea2ab8087d6bb60b655fdf7718532050b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Noel Grandin  <noelgrandin@gmail.com>  [3816184ee779f32d2210c8fcc9f7dd2c77b6f736]

        osl::Mutex->std::mutex in ucb::BaseContent
        
        Change-Id: I03c25405b7e4206d6c81bc9c98b6cb07e376cd01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Noel Grandin  <noelgrandin@gmail.com>  [3b2888fe0971b07d647a29467c317ba42a51b832]

        osl::Mutex->std::mutex in ucb::XResultSet_impl
        
        Change-Id: I67f70774c94d953880ebcf9fe9bf24a0492456f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Noel Grandin  <noelgrandin@gmail.com>  [f75b742997c119ccb081faa7e63ce04b8e88912c]

        osl::Mutex->std::mutex in GlobalEventConfig
        
        Change-Id: Id54f9f15547010c9df640e406d36fb09febac4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134089
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7d3243d22d6a94930e0cd21721442a2608e03fa]

        move creation of xParser to where it is used
        
        Change-Id: I03511a8c7b01b0abb69b276b900bf712549e5873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Jean-Pierre Ledure  <jp@ledure.be>  [56810b5b3dcae39dea1462ac1e2a490af375a0c3]

        ScriptForge - (SF_Dialog) FIX comments in Resize() method
        
        Fix mix-up of the definitions of the Left and Top arguments.
        
        The patch changes mainly a few comment lines.
        
        Additional changes:
        the list of methods includes Center() and Resize(). (patchset 3)
        
        Change-Id: Id049d42b053e5ef1971ee62fb2b8b9342053583f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134078
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-05-10  Seth Chaiklin  <sdc.blanco@youmail.dk>  [05fa375ff0dba60af7093acb058e07b767f0adab]

        tdf#148519 correction to vertical "to frame" mapping for object position
        
          The mapping for the anchor to frame was incorrect, possibly inherited
          from OOo. (Thanks to Regina Henschel for identifying this problem.)
          This patch changes the mapping and reverts
          2c19246a4090df14e8f97c35c7770b25c1974232, which had attempted
          to correct the problem of what options were shown in the UI for
          Vertical Position for objects that are anchored "to frame".
        
        Change-Id: I30c35475a38824ebc1f926bf63542d19bdf008d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133871
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-10  Miklos Vajna  <vmiklos@collabora.com>  [c3c3303516c3da9372dce3f05f38f15a104e961c]

        sw XHTML export: output table / table row background format using CSS
        
        The HTML export uses HTML elements / attributes to describe the
        background color of tables / table rows. CSS markup is used when
        exporting styles, not direct formatting.
        
        This behavior makes sense for the HTML mode, but XHTML wants to CSS
        markup whenever possible, and usage of CSS markup for the reqif mode is
        not even optional.
        
        Fix the problem by switching to CSS markup for table and table row
        backgrounds in the XHTML case -- this is OK for reqif when describing
        tables (the reqif spec only forbids detailed CSS markup for spans, not
        tables or table rows).
        
        This amends the behavior of commit
        4cd3c436923bfba281b1bf16d9785208a2119cea (sw reqif-xhtml export: limit
        values of the style attribute, 2018-04-11), which avoided invalid table
        row background markup by losing it on export.
        
        Change-Id: Ia0858986c3e8a3ea41adf8a24119442fe5068ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134119
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-10  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4cc3a144ef2ecc019da42bb9b115267a18e9559f]

        tdf#147919 PPTX export: fix curved and bent connector shape
        
        by calculating and exporting adjustment values to avoid
        of connector lines with bad turns overlapping the
        connected shapes.
        
        Change-Id: I0441508f4fe98b3482e2955df5f41f2cfc2ffb4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134109
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [1d8c31ea2555b339d5a4bc5449d40d546045435b]

        sort out query iterator's BinarySearch() corner cases handling
        
        If the code detects the range is not actually properly sorted,
        set position to the first row and return false to force
        linear search. If the searched for value belongs before the first
        item, do the same, in which case the linear search should see
        that it is this case (before this case nRow was set to the first
        row regardless of where the searched for value belonged).
        
        Change-Id: I8ff346783d93d74ff409b19aea394e202885647d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134100
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [e2f8e5cf7cf9c7b2812ffbcd48ec21dc994339d6]

        make BinarySearch() work for SC_EQUAL, SC_LESS, SC_GREATER
        
        Change-Id: I296686709688a9e3f2cda0864d73c79a17e33f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134099
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [6a5464b800aa0b0ce35d602fd008b555d96a94af]

        make query iterator's BinarySearch() find the last matching item
        
        If the code found a matching value, it didn't bother finding
        the last one in the range if there were several adjacent ones.
        
        Change-Id: Ie1f4c7bd3dcbd2aaf653f5b74e159902de4cf93d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134098
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [dce09d33aabfbad405f1accf02c14f8e85da8f6d]

        add tests of query iterator's BinarySearch()
        
        The BinarySeach() function is rather strange/dumb. If it doesn't
        find the value, it tries to use the last previous value (i.e. it
        additionally does the fixing up that VLOOKUP, MATCH, etc.) do.
        At the some time, if there's a range of equal values, it doesn't
        find the last one (and so callers need to fix that up). Write
        some tests for that before I start touching the algorithm.
        
        Change-Id: Ife2388acad691cce7ffaf5490fa74b5a3d453926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134097
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [80606b89bbd38f63423eccfac4d1b8e6732b9560]

        extend ScQueryCellIteratorBase for custom cell access
        
        This moves code related to accessing cells to query to a template
        base class. Creating more specialization of that class will allow
        queries that use a cache of sort order for the cells.
        
        Change-Id: I47d1bc2d038717ff64f1d11fa6c7dba2359fec11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134096
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [02c5ec92e3dfa8dee51e606ff8e929168948a8a7]

        assert pre-requisities of BinarySearch()
        
        Change-Id: I090a6538628eb5337a311ed8aec3580901e957ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134095
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Luboš Luňák  <l.lunak@collabora.com>  [4d2bd386837524fd9f74f827f59ac3dfc64b3a6a]

        BinarySearch() can be in ScQueryCellIteratorBase
        
        Change-Id: I89d7e58a9706526aa2871dba1e4f922ff94562a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134094
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-10  Colomban Wendling  <cwendling@hypra.fr>  [920558267bbd1e91e1639dd854beb8d56fc7b5c3]

        qa: Fix occlusion check coordinates in _XAccessibleComponent.java
        
        This could erroneously skip a check because the child was erroneously
        deemed obscured by another object.
        
        Change-Id: I67d76ea272874671ae328266bdbdeb037c0dc625
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133842
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [cdf70b909910974cad49a5c4372d2682209cc831]

        sfx2: add config warning in UndoManager complex test
        
        ... and remove obsolete comment, that problem was fixed a decade ago.
        
        Change-Id: I06e122128ff009778da87891739016ecc8975895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134110
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a1f81f2e0fbc0306cfa6317b41fe2c0bf04fe4c]

        tdf#121740 reduce cost of SfxDocumentMetaData::Init
        
        XPath is a little heavyweight for such a simple thing. Shaves 5% off the
        load time for me
        
        Change-Id: I109f68fa1dfc228b42740000a95a2e7a3de7e320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133927
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Mark Hung  <marklm9@gmail.com>  [5f92e8cf3da6b5f66b6ef23219fcc91d2ad7c754]

        tdf#104930 Implement TextMetric::GetHangingBaseline.
        
        The text metric value is initialized in ImplFontMetricData::ImplInitBaselines() using harfbuzz API hb_ot_layout_get_baseline. It can't handle multiple hanging baselines of the same font for different scripts yet because the script is fixed to HB_SCRIPT_UNKOWN.
        
        Change-Id: I2574f0dba45501187064b9341c573159914a4a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133667
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-05-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d5371ec06292b67fd5f401e9ad51586f603089f8]

        chart2: add func. to convert from css::awt and B2IRectangle
        
        Change-Id: I6da70d4559d1536b788228bcae64f5e43462d8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133922
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-10  Miklos Vajna  <vmiklos@collabora.com>  [6de2fc2a705d3f356cac898201a98d7db6102d1a]

        sw content controls, drop-down: add DOCX export
        
        Map the list items to an XML markup like:
        
              <w:sdt>
                <w:sdtPr>
                  <w:dropDownList>
                    <w:listItem w:displayText="red" w:value="R"/>
                    <w:listItem w:displayText="green" w:value="G"/>
                    <w:listItem w:displayText="blue" w:value="B"/>
                  </w:dropDownList>
                </w:sdtPr>
                ...
              </w:sdt>
        
        Change-Id: I483009603f1138e4bd5871bfd8c760a3de739ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134104
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-10  Caolán McNamara  <caolanm@redhat.com>  [d0eae1767bb7643d382d9a64393ae2ba85fc7646]

        ofz#47205 import never completed
        
        keep nEndPos and nStartPos consistent if there is no following piece
        
        Change-Id: Iaa0840eb9a60c429d60ff449aed0a2f981306b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134093
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-10  Caolán McNamara  <caolanm@redhat.com>  [070b34c2a40c5e7d93022e331a5c90626ca603eb]

        fix --disable-scripting build
        
        Change-Id: I41e0da3d379d54ec59f9eba46978cfe7f9e09d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134105
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [93a102be711f4f90d1c649af8fb0a62ec970406a]

        Update git submodules
        
        * Update translations from branch 'master'
          to df1f1ea62f4f5c39d4800a59814baace6363e8e1
          - rdm#3572 update github-repo lockdown
            
            Change-Id: I9aaebdb3a10bf485775b25aa581393951900f17b
            
2022-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [41a7d40f39fa99f2c207dbaa66df8710ac10ee4c]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d4165a5a9b83216339c731c42250f1417dfd9d26
          - rdm#3572 update github-repo lockdown
            
            Change-Id: Ifafd3a7367e142539140670b01c1184554395890
            
2022-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e7e5600e07d8201781e9ac98d900fbea0fbe34c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23f80fa92e4c0c12f5f16590787a71d55ecfc2b3
          - rdm#3572 update github-repo lockdown
            
            Change-Id: I48c866db63c986ad04b7bfa9dad79b53dae52cd8
            
2022-05-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [83d68dfd36881fc720380493e7095a5518cda8bc]

        rdm#3572 update github-repo lockdown
        
        Change-Id: I21eb89513d7823b68e593a69a4bf5d9b9b637ad3

2022-05-10  Stephan Bergmann  <sbergman@redhat.com>  [f522000d15614f854c60338c244b78ed2c6f364c]

        Fix stack-use-after-scope
        
        ...during CppunitTest_chart2_export,
        
        > [_RUN_____] testStrict::Load_Verify_Reload_Verify
        [...]
        > ==20402==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f220d8280d0 at pc 0x7f21a71c55cb bp 0x7ffc70fff650 sp 0x7ffc70fff648
        > READ of size 8 at 0x7f220d8280d0 thread T0
        >     #0 0x7f21a71c55ca in sdr::contact::ViewObjectContact::getPrimitive2DSequence(sdr::contact::DisplayInfo const&) const /svx/source/sdr/contact/viewobjectcontact.cxx:361:22
        >     #1 0x7f21a71c440f in sdr::contact::ViewObjectContact::getObjectRange() const /svx/source/sdr/contact/viewobjectcontact.cxx:199:78
        >     #2 0x7f21a71c33f7 in sdr::contact::ViewObjectContact::~ViewObjectContact() /svx/source/sdr/contact/viewobjectcontact.cxx:165:9
        >     #3 0x7f21a71d0af8 in sdr::contact::ViewObjectContactOfSdrObj::~ViewObjectContactOfSdrObj() /svx/source/sdr/contact/viewobjectcontactofsdrobj.cxx:51:1
        >     #4 0x7f21a70b6d08 in sdr::contact::ViewObjectContactOfGroup::~ViewObjectContactOfGroup() /svx/source/sdr/contact/viewobjectcontactofgroup.cxx:40:9
        >     #5 0x7f21a70b6d58 in sdr::contact::ViewObjectContactOfGroup::~ViewObjectContactOfGroup() /svx/source/sdr/contact/viewobjectcontactofgroup.cxx:39:9
        >     #6 0x7f21a71315e1 in sdr::contact::ObjectContact::~ObjectContact() /svx/source/sdr/contact/objectcontact.cxx:68:9
        >     #7 0x7f21a71e7108 in sdr::contact::ObjectContactPainter::~ObjectContactPainter() /svx/source/sdr/contact/objectcontactofobjlistpainter.cxx:43:1
        >     #8 0x7f21a71e77fc in sdr::contact::ObjectContactOfObjListPainter::~ObjectContactOfObjListPainter() /svx/source/sdr/contact/objectcontactofobjlistpainter.cxx:69:1
        >     #9 0x7f21a89793c1 in (anonymous namespace)::GraphicExporter::GetGraphic((anonymous namespace)::ExportSettings const&, Graphic&, bool) /svx/source/unodraw/UnoGraphicExporter.cxx:959:13
        [...]
        > Address 0x7f220d8280d0 is located in stack of thread T0 at offset 4304 in frame
        >     #0 0x7f21a896d04f in (anonymous namespace)::GraphicExporter::GetGraphic((anonymous namespace)::ExportSettings const&, Graphic&, bool) /svx/source/unodraw/UnoGraphicExporter.cxx:592
        >
        >   This frame has 89 object(s):
        [...]
        >     [4304, 4320) 'aCheckVisibilityRedirector' (line 955) <== Memory access at offset 4304 is inside this variable
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2394/>), presumably since
        db6c5c7f9dddd81a8f18a74d6051555680837adc "svx: calculate object range before
        using it"
        
        Change-Id: I77d56be1ca6bf16a0f5aa65cc1130547ae2fbf04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134103
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-10  Juergen Funk  <juergen.funk_ml@cib.de>  [cf650ceaafb4d3a3f46991dc1b12efa0e37a71f9]

        tdf#147590 update OLE object after document refresh
        
        Regression from b099da78a6f0b3e120f706714003b05d84d11e70
        we didn't update linked OLE document after document reload
        
        Change-Id: I8e52f6430f454b276cb43449c6f7a3b0e07e909f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130692
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2022-05-10  Noel Grandin  <noelgrandin@gmail.com>  [63a2f314250b05d484747fafc4a814a4553f461e]

        osl::Mutex->std::mutex in HierarchyEntry
        
        Several methods actually do not need locking because they are
        calling other methods which are already locked, and thereafter
        they touch only function-local state.
        
        Change-Id: Ic0c55df65988fcc64899a31586f6a426825cba81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134088
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-10  Miklos Vajna  <vmiklos@collabora.com>  [3ce14653edd9a7f845f81d9e727b5031a3349291]

        sw: document SwXTextField
        
        I.e. the UNO class wraps SwFormatField, and that wraps SwField.
        
        Change-Id: Ieadcf8bf1de8a034dacc567b1193ec2c5391a42a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134092
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bedd7279bccc490fd330c94420d6cf108202d5c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to faf6e6882194bbd7e1dddbe7559bce0d041297b0
          - Fix typo
            
            Change-Id: Idb3c20b35f3337e6d879a551b118a83016c6c30d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134102
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-05-10  Mike Kaganski  <mike.kaganski@collabora.com>  [bc1ab88ffa21ab67dbd56b5d3c724fe28c2b5a5b]

        More usual 1899-12-30 base Date in Basic
        
        Omissions from commit 8189d815641c583b5506d482f0b4f1ab47924f6a
        
        Change-Id: I6b205f7bcc9ff9c30e55b03d39d02b9be15a01c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134064
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e5fb120a32d04e241b35a7e63894c744196f576b]

        Fix typo in code
        
        Change-Id: I6fae9a4df450f80ee2af59e271a8cb1dd8bc918f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134047
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [7a4aa62a1ed171a5edd73090de8a7db381ea76e0]

        That AC_SUBST is already done by libo_CHECK_SYSTEM_MODULE
        
        Change-Id: I62ebdd0c1339eb4a804e2ea277f043f68c35c601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134082
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [52dfeeb636d2502ec639346736c420b636f1140f]

        crashtesting: use of negative return indication failure as length
        
        a problem since...
        
            commit e9c50fbbc3b07ef927d133da9cf2395c55611e0f
            Date:   Sat Apr 2 15:49:32 2022 +0300
        
                tdf#103954: Z compressed graphic formats support for EMF/WMF
        
        Change-Id: Ia994587bf411a2cda3df38cb209313171b78ee9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [6dc41e33e087032a52ee11832ff1299632b4f5dd]

        Related: tdf#148433 experiment with SAL_DISABLE_CURSOR_INDICATOR
        
        to turn off the arrow indicators in BiDi cursor
        
        Change-Id: I5ed96bccf17432e63564bdfc1c7d2ad4fecdd2a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134090
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Mike Kaganski  <mike.kaganski@collabora.com>  [ced3501a93fd44621d7d5e0479df72657a0f085d]

        Unify and simplify SbRtl_Hex and SbRtl_Oct
        
        OUStringNumber::toAsciiUpperCase is cheaper than OUString::toAsciiUpperCase.
        
        Let SbRtl_Oct use OUString::number as well.
        
        Change-Id: I3a97ec5d3a7b0005fc300310198bae47c62dfbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134061
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-09  Luboš Luňák  <l.lunak@collabora.com>  [cbbdcfd49db545f4f3e4041453706f33065267b7]

        make ScDocument::FetchTable() public
        
        I don't see why it should be private, it's range checked,
        so there should be no harm. Especially when a number of classes get
        declared as friends to get access to it anyway.
        
        Change-Id: I333d749aa9d09aaf9dcbabf43d67a67d1257a132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134051
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-09  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [1440ab87386bb5d1ad3634082577bf27f279e066]

        tdf#143875 tdf#55058 EMF+ Add support for individual line endings
        
        EMF+ is allowing different caps and arrows on both ends
        It is not possible to implement that with css::drawing::LineCap,
        as it is set line endings on both line start and line end.
        Additionally when the Dash Pattern is used, the css::drawing::LineCap
        is also applied there.
        
        To resolve that limitation, the Cap needs to be implemented
        independetly by using PolygonStrokeArrowPrimitive2D, and
        the css::drawing::LineCap inside drawinglayer::attribute::LineAttribute
        always set to css::drawing::LineCap_BUTT
        
        Change-Id: I4be76e2dbefcb34154a1404c3b57dc4b7f7ada85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133299
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-09  Pragat Pandya  <pragat.pandya@gmail.com>  [6abc09926c9b55a445b906303f56c6ec7fdeabf9]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I54257e87da0cd66da59d820c7960c3e4b020fda3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134027
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Tested-by: Jenkins

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [0c3950c4954848fde1515a932cc16b38ab961a7d]

        Remove dated check for C++11 <codecvt>, <regex> headers
        
        ...which should always be available with our C++17 toolchains
        
        Change-Id: If3b231f58c3c27a10d68ef4946b7ee2bb4f31a4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134083
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f37a0ff46a7f1a2a52ee78ff99731cfb3bbc2f8]

        Fix typo in code
        
        I find _rContext not _rContxt
        
        Change-Id: Iabc73590cf12112d0071e72b74064788b006e5e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134050
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-09  Mike Kaganski  <mike.kaganski@collabora.com>  [8189d815641c583b5506d482f0b4f1ab47924f6a]

        Use usual 1899-12-30 base Date in Basic
        
        It matches VBA, has an optimization in the code, and doesn't
        need any additional "-2" hackery.
        
        Change-Id: I4b90674ae643788eda5ce618b4c42e2cc045ec04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134060
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-09  László Németh  <nemeth@numbertext.org>  [ac9de05cc79e76392891c18814e8f120178ccf38]

        tdf#148993 XLS export: fix broken formula regression
        
        Exported XLS documents lost their formulas opened in MSO.
        
        Regression from commit 12ee423c7549ddd2b86dfc3fc6fed2c617dcca7f
        "tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulas".
        
        Change-Id: I009630a41b29bb21349711cc07d0ed181f816374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134075
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [696be1cbd7097510702f8343853239af51085ab1]

        ofz#47323 suppress Direct-leak
        
        Change-Id: I7189e4974a6bb8038a347442cf7ad925530e6f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134074
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [b125784fa5b17272577d46fae8f915ab48e57dd5]

        Drop an obsolete configure check
        
        We require at least GCC 7.0.0 anyway, per README.md
        
        Change-Id: Ib974690ef4e4a1861a43f33157fde9f4bb3ac8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134080
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [7251f9c1b840721b5ba1f1d5f8b65b405260945b]

        basic: remove commented out line
        
        Introduced in 90d33f5945336fa46b7c02f425100af794768b15
        "tdf#148358 - Compare Non-ASCII variable names case-insensitive"
        
        Change-Id: I5bccb3f2f54ac61f2fbf960e78e3d4e4a0893f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [57b58d4fb85579a9aacbd6b2d7e389cce46f5fbc]

        URE Library_boostrap should not depend on Library_comphelper
        
        ...and apparently doesn't need to, even though that dependency got added with
        6ffdc88e79904882e319bdd0b901e7491abae0b3 "Simplify Sequence iterations in
        shell..svgio"
        
        Change-Id: I7cb67dc48d11e426d5d5f7912eca13e25a32dbc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134079
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [52bd9c25d1e1150cb5f5a8890c4d5dcce4e32954]

        SvFileStream needs an absolute file URL
        
        ...and fail loudly if writing the file fails for any reason
        
        Change-Id: I1e6d2e3da4d2ef643f4d27067845184dbf2e40a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134076
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [c5e38abb10914ab262d970902743b204e4a99a99]

        URE Library_io should not depend on Library_comphelper
        
        ...and apparently doesn't need to, even though that dependency got added with
        6af2e7d21ce050758ad07fbb951a38b2da2b6c4c "use more
        comphelper::OInterfaceContainerHelper2"
        
        Change-Id: I74a4d04be9a37291bc37d908173381eb341b6df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134077
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Stephan Bergmann  <sbergman@redhat.com>  [81d55a0a8b999c58b5b347abd6214d6571ed9923]

        Revert "prevent using O[U]String::subView on temporaties"
        
        This reverts commit 59059d00c29334414a26bf5452572433f5735489, as it effectively
        did nothing, as rvalues can bind to `const &` just fine.
        <https://gerrit.libreoffice.org/c/core/+/133747> "Acutally do prevent using
        O[U]String::subView on temporaties" would have fixed that, but (a) it didn't
        find any actual mis-uses and (b) rather would have required a handful of
        legitimate cases to be dressed up with o3tl::temporary now, so is arguably not
        worth it.
        
        Change-Id: I923d0db2646dc8ea66d1b2a8b709ee2cd7a60ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134058
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-09  Mike Kaganski  <mike.kaganski@collabora.com>  [7c8f27e3d8ff9c22409313a093bf538256fa2f7f]

        sal_Int32 cast to tools::Long to pass to a function taking sal_Int32
        
        Change-Id: I81bb794e6a154dd3d022b34ce1348f32c854f52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134059
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-09  Alain Romedenne  <alain.romedenne@libreoffice.org>  [7f987c7218b1124ce8b8fe4df9388a85b8f1a3fd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 084d84f09882ec35007ad4566247932a30899799
          - tdf#141474 tdf#148466 Choose function accepts keyword arguments
            
            Change-Id: I82407ecc20b66c385f17509aa703222d2d2d10e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132390
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [10f3cb6aa8794d063ae5990066fcfa006d47c512]

        ofz#46070 Out-of-memory
        
        Change-Id: Ie7417f5f7e0ed49cfc3b38eda3117d53c8a2a59e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134053
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d0b19f3ea3932c9c9bd73604987373681440a1c]

        tdf#148843: sc_mathematical_functions: Add unittest
        
        Change-Id: Iea71c3fd92a471814c27bebda74bbe8b30d706f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134040
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [8bd91a40eae95f38c15d570d6af87b997c7eee39]

        tdf#148948: sc_statistical_functions: Add unittest
        
        Change-Id: I9dd5010931991001215102a2764f7faa67412676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134038
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [247f4aefb9879dd465e34a2072218a0f1748de53]

        Resolves: tdf#148985 crash on searching for non-existing prefix
        
        Change-Id: Ib89af12e75910adbd32abab5afceb9013dc51df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Miklos Vajna  <vmiklos@collabora.com>  [0db2cd321fef8db7c17c6c588b6593c7d59a9688]

        sw content controls: only try to insert placeholders if there is no selection
        
        The logic is that in case there is no selection, we insert a placeholder
        like "type here", but if there is a selection, that can be a custom
        placeholder.
        
        Without this fix, we would hit an assertion failure on inserting content
        control when there is a selection, as the placeholder is empty and
        operator[](0) is not allowed for empty OUStrings.
        
        Change-Id: I8370b8d74415faf0e76dccb574aa29bea1947bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134041
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-09  Mike Kaganski  <mike.kaganski@collabora.com>  [0c87c0b87a3bbc2c57b2dd65ba2dd0aeb2f0b0c3]

        Fix --disable-pch build: explicitly delete move constructor
        
        Without this, the implicitly created constructor is exported by MSVC
        for the DLLPUBLIC class, and requires that VirtualDevice is defined,
        resulting in this error in PCH-disabled builds:
        
          [build CXX] vcl/source/animate/Animation.cxx
          C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'VirtualDevice'
          C:\lo\src\core\vcl\inc\impanmvw.hxx(29): note: see declaration of 'VirtualDevice'
          C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)'
          with
          [
          reference_type=VirtualDevice
          ]
          C:\lo\src\core\include\vcl/vclptr.hxx(216): note: see reference to function template instantiation 'rtl::Reference<reference_type>::~Reference(void)' being comp
          iled
          with
          [
          reference_type=VirtualDevice
          ]
          C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled
          with
          [
          reference_type=VirtualDevice
          ]
          C:\lo\src\core\include\vcl/outdev.hxx(202): note: see reference to class template instantiation 'VclPtr<VirtualDevice>' being compiled
          make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:337: C:/lo/src/build/workdir/CxxObject/vcl/source/animate/Animation.o] Error 2
        
        Change-Id: I78723ce7d00667595aff39bcab22169ff347098f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134036
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-09  Miklos Vajna  <vmiklos@collabora.com>  [c3f4c43694f0f9aec35193ccf40f0e7c8476fdc3]

        sw content controls, drop-down: add ODT filter
        
        Map each list item to a dedicated XML element:
        
        <loext:list-item loext:display-text="..." loext:value="...">
        
        And do the opposite on import.
        
        Change-Id: I59a536a8317a3bb24919107b4449f858d5f6de96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134034
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-09  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [32cb4e4fe55e662d2e515e9a6facabffe3684754]

        tdf#89331 EMF/WMF Fix holes in lines created with LINETO
        
        If the lines are created with MOVETO, LINETO, LINETO...
        then Line Join NONE is applied. As a result the charts are looks ugly,
        with the holes inside it.
        For example:
        https://bugs.documentfoundation.org/attachment.cgi?id=179962
        and
        https://bugs.documentfoundation.org/attachment.cgi?id=179837
        
        Additinally commit changed default line join style to miter,
        as during experimenting with MS Paint and MS Word,
        it appear that default Join Style is PS_JOIN_MITER and
        Line Cap is Flat/Butter.
        
        The PDF export tests has been updated, as there is less number
        of PDF object after using joiners.
        The size of the exported tdf145873.pptx to PDF,
        was slighltly decreased from 22.8kB to 22.0KB
        
        Change-Id: I131cc3c5e90f827d67d2360eb18167eed6315abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133624
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-05-09  Caolán McNamara  <caolanm@redhat.com>  [d4ec15d5b7c64cd62b6f729c1334c167da5886b4]

        rsc is no more, but concat-deps leaks instead so still need this
        
        Change-Id: I06474f973c1858ed0740232dc75cfd75b8c4706e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-09  Noel Grandin  <noelgrandin@gmail.com>  [90523fd368cf249cb00bd1d881a2a19e1510ca85]

        osl::Mutex->std::mutex in SalUserEventList
        
        Change-Id: I463f1620e28bf71b8b7ad61a9da074ff6ee7f0f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133912
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-09  Noel Grandin  <noelgrandin@gmail.com>  [7537c81fd6a141a6e04b0de00608f147ca9ea7dc]

        osl::Mutex->std::mutex in desktop::Acceptor
        
        Change-Id: I450734e615c4c214f18641a3ac79f6810d98922c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-09  Noel Grandin  <noelgrandin@gmail.com>  [9277faf14a713b8ae88596785874bdcdfc47957c]

        osl::Mutex->std::mutex in cppuhelper::ServiceManager
        
        Change-Id: I2d30fb3c81e791eb554780b5abf4923a33cc884e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134029
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-09  Noel Grandin  <noelgrandin@gmail.com>  [f0ed5d46373f34a78a260617cf22606f7fd3c399]

        osl::Mutex->std::mutex in cppu::MappingsData
        
        Change-Id: I34292537e9724d7667ba099285c87a32ae13ffad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134028
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-09  Miklos Vajna  <vmiklos@collabora.com>  [c06b2ac50ec198a4c75345c15103541ab45462a4]

        sw: prefix members of RTFSurround, SwMSConvertControls, ww8::WW8Sttb and ...
        
        ... wwFontHelper
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib5ee24b6ed599041b0c2724931742d86ee9b360c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134033
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-09  Pranam Lashkari  <lpranam@collabora.com>  [db6c5c7f9dddd81a8f18a74d6051555680837adc]

        svx: calculate object range before using it
        
        Change-Id: I01f0176542e9d6f36a2f7bbc870a9e337705a5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133454
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit b604f17732b0b31d69781f812357d34f3da7175d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133486
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2022-05-09  Eike Rathke  <erack@redhat.com>  [920a083f3818765528899ab38170db5a2917a06c]

        Resolves: tdf#148948 Use QueryBy(Non)Empty for "=" and "<>" criteria
        
        Change-Id: I94e29370076fff977b6552d10883878633bee313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134000
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-09  Luboš Luňák  <l.lunak@collabora.com>  [b06663135f9c7c08f5866a87a1fb0932df5af8bd]

        enable Skia on big-endian too
        
        Without this the build will #error out, and despite the disclaimer
        it reportedly works fine.
        https://lists.freedesktop.org/archives/libreoffice/2022-May/088838.html
        
        Change-Id: I0e87b31647fe5107bca9b58d8f4af5fc0c67cd65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134032
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-09  Luboš Luňák  <l.lunak@collabora.com>  [c0f9157cf64242adbc4a9eb7cfac66fffa97e5a2]

        remove HAVE_LIBCPP_DEBUG (libc++ debug mode)
        
        It's currently too broken (https://reviews.llvm.org/D125184),
        but they're working on fixing it, so hopefully somewhen later.
        
        Change-Id: I3ca243a57d41bd9d8c4cdbdc4a6a3b5fdc49e4c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134023
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [cdf8e971d5d46df4bcab35a99c4254df9459213f]

        osl::Mutex->std::mutex in SaxExpatParser
        
        Change-Id: I9d99497dfbc67cd4dd690da9db58aab0db114d36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134021
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [34948e67772b4b27f47c4871b7428a0e3306d770]

        osl::Mutex->std::mutex in Pump
        
        Change-Id: Idb25603ba5659b3d8cabbdddb00df60e43045b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134020
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [cb65f89db892c3b0cecbafec77e61292e7d5afe8]

        osl::Mutex->std::mutex in OMarkableInputStream
        
        Change-Id: I935573e63471e5f38e719df51b3510992347fe09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [0daeb60f4fd24a0b075b94775a9d635fe7fc0824]

        osl::Mutex->std::mutex in OMarkableOutputStream
        
        Change-Id: Ie39f8cd7f8de8dfe647d006d0fd0c62fddc72a8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Caolán McNamara  <caolanm@redhat.com>  [fd4a089df684a38cff18e77217961ee4bee0c497]

        ofz#46607 Integer-overflow
        
        Change-Id: Id759423176b2e47fc00b8e7babd936b480956617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [e8b38f770012d2dad923c8a174ba4e9553db9afa]

        osl::Mutex->std::mutex in OAcceptor
        
        Change-Id: I0fa5628ff601a89ed9c74212b4986689957eab1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Mike Kaganski  <mike.kaganski@collabora.com>  [5393dbec555b89aa649a6ece3a58ec38538d398c]

        No need to use std::optional here
        
        Change-Id: I7129178ca4639aafabe7401dd6e3dc831e7e9562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-08  Caolán McNamara  <caolanm@redhat.com>  [233b1409f59292ac2ab51fa431149683c97065cf]

        drop special fuzzing path
        
        Change-Id: Ifa47253b1122f6f84f2c082b2f71b04451ec5162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-08  Martin Srebotnjak  <miles@filmsi.net>  [1fae699cc55b89db546e81df0c0292546f5866d6]

        Update git submodules
        
        * Update translations from branch 'master'
          to d317ea9b3412438e83f716001d7fda3a62516855
          - Updated Slovenian translation
            
            Change-Id: I2edec53223e0c5c09cff8fc58265f32d6aa3da8e
            
2022-05-08  Stephan Bergmann  <sbergman@redhat.com>  [7e1ff1cee5dd203df679d584512930fb21b97f6e]

        external/firebird: Implicit int in configure check
        
        ...so that with Clang 15 trunk after
        <https://github.com/llvm/llvm-project/commit/2cb2cd242ca08d0bbd2a51a41f1317442e5414fc>
        "Change the behavior of implicit int diagnostics" the check now failed to
        compile with
        
        > configure:21471: checking alignment of long
        [...]
        > conftest.c:166:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
        
        with consequences the same as in f6be6cd82bd84f13d2a597ceb62181111ae0eb80
        "external/firebird: Missing include in configure check" (so rename the existing
        configure-include.patch, as it now covers various kinds of C99 violations)
        
        Change-Id: I64e7c13945a3ede3900cc6a84da575e35bdce953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133994
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [9974ed792a1141fe3c3dc0a1ec5255a23e76f27b]

        osl::Mutex->std::mutex in slideshow::EventQueue
        
        Change-Id: Ie9e53e5dc2c842e11457846b5f177fc55683e0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [40b0cf86c23d72af90f964597ac814ceaf846259]

        osl::Mutex->std::mutex in sfx2::PreventDuplicateInteraction
        
        Change-Id: I4abc1462b4d691dc699a9716573d23824897176b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  Noel Grandin  <noelgrandin@gmail.com>  [df63d1aa9ca0676e3df7b68dc8dc99246aa44240]

        osl::Mutex->std::mutex in framework::ToolBarManager
        
        Change-Id: I6908dc61cbd6e6e4d11c52dfface1d863cd7e5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133977
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-08  xuenhua  <xuenhua2008@sina.com>  [e92536bac2545d7f2722fc2529d8c7a8ff7c85d8]

        Delete CJK-style mnemonics on macOS
        
        Delete CJK-style mnemonics for the dropdown menu of the 'New button' and lower menu of 'File > New' on macOS
        
        Change-Id: Idd0ab671cd75151095c92b37e5b6b5e81ddae7e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-08  Stephan Bergmann  <sbergman@redhat.com>  [ed977f0b6c849739d3c843c8425442265e2eb7ca]

        external/openldap: Implicit int in configure check
        
        ...causing
        
        > checking for compatible POSIX regex... no
        > configure: error: broken POSIX regex!
        > make[1]: *** [external/openldap/ExternalProject_openldap.mk:40: workdir/ExternalProject/openldap/build] Error 1
        
        due to
        
        > conftest.c:88:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
        
        with Clang 15 trunk after
        <https://github.com/llvm/llvm-project/commit/2cb2cd242ca08d0bbd2a51a41f1317442e5414fc>
        "Change the behavior of implicit int diagnostics"
        
        Change-Id: I8fb70ce21a73293e20bbc5b09c133141aa9b0ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133995
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-08  Seth Chaiklin  <sdc.blanco@youmail.dk>  [93d0c905fea61b689a984001d729f4fdc989b52a]

        tdf#127294  add new ToD about deleting arrow styles
        
        Change-Id: I5e6c3878f2c73f7136baf9a1cfaa6ac8aa1030d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133479
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [1bb9036e90688929fec61edbacae768afef9f5db]

        android: Don't use res Id in switch-case (ToolbarController)
        
        Like Change-Id I9d563b6ad4ed70a891c583a82331dd80db5956dc,
        "android: Avoid using res ID in switch-case (FormattingController)",
        but for `TollbarController`.
        
        Change-Id: I40f23b6a91ddf0bb7e90c3b3b690fe332cd874ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133999
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [dcc6b286ea58bca21fd6a85fde2bffa2cce8d564]

        android: Don't use res ID in switch-case (SearchController)
        
        Addresses this Lint warning:
        
        > ../../src/java/org/libreoffice/SearchController.java:73: Resource IDs
        > will be non-final by default in Android Gradle Plugin version 8.0, avoid
        > using them in switch case statements
        
        There's no need to explicitly set `SearchDirection.DOWN`
        for `R.id.button_search_down` since it has previously been
        set as default value anyway.
        
        Change-Id: I283c00b97e1417f5dc3a48922238df7a29032137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133998
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [1c5a8b5eafd67001875a0270459a1a9dd7b605d8]

        android: Avoid using res ID in switch-case (FormattingController)
        
        Adresses Lint warnings like this in FormattingController:
        
        > ../../src/java/org/libreoffice/FormattingController.java:89: Resource
        > IDs will be non-final by default in Android Gradle Plugin version 8.0,
        > avoid using them in switch case statements
        >
        >   86
        >   87      switch(button.getId()) {
        >   88
        >   89          case R.id.button_insertFormatListBullets:
        >   90              LOKitShell.sendEvent(new LOEvent(LOEvent.UNO_COMMAND, ".uno:DefaultBullet"));
        >   91              break;
        
        Change-Id: I9d563b6ad4ed70a891c583a82331dd80db5956dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133997
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [e1381521c593620511113e70ebe1b0c52a1f0378]

        android: Allow setting auto font/bg color
        
        Add a button in the color palette UI
        (that can be found in the bottom toolbar
        under "Styles" -> "Font Color"/"Highlight Color"
        when experimental editing mode is enabled) which
        allows setting auto color for the font
        or the highlighting/background.
        This allows to unset any explicitly set color and
        use the automatic color.
        
        This is equivalent to the "Automatic"/"No fill color"
        items in the font color and character highlighting
        color popups in the desktop version.
        
        Add a `boolean keepAlpha` param to
        `sendFont{,Back}ColorChange` to be able
        to distinguish between "auto color" and white
        when -1/0xFFFFFFFF is passed as color.
        See also previous commit
        Change-Id I2e6512f32e671f92c8d31b2780c350dd74fb0747,
        "android: Handle auto color as such", for some more
        context.
        
        Change-Id: I05182a2adbc00e64b1925ff52861a51ba8dcc21f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133996
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [5c50d8f7ee351e7605b382ae5b06ccaa8518747f]

        android: Handle auto color as such
        
        When no color is explicitly set for the font/background
        (i.e. automatic color is used which would e.g. be black
        for the font if no background color is set or white
        if a black highlight color is set in Writer), the value
        for the color sent in the ".uno:Color" event for the font
        color and similarly for the background/highlight color
        (".uno:BackgroundColor" in Calc, ".uno:CharBackColor"
        in Impress, ".uno:BackColor" in Writer) is -1.
        
        The previous handling of that special value was problematic:
        
        1) Where handled specifically, -1 was interpreted as "black color"
        rather than "auto/no color".
        
        2) The color handled by the above-mentioned UNO events
        does not contain/handle the alpha channel, while Android
        does, so a conversion happens to add/remove the alpha
        layer.
        However, the anonymous `ColorPaletteListener`s that handle font
        and background color updates in their `updateColorPickerPosition`
        methods were not doing a logical or to add an alpha channel to
        the LO-provided color, but *adding* 0xFF000000 instead, which is
        the same for actual colors without an alpha channel set, but
        the actual special value of -1 (0xFFFFFFFF) would then
        be converted to 0xFEFFFFFF and no longer be treated as
        special.
        
        The way of treating -1 as black would also have the
        side effect that an explicit white color (0x00FFFFFF) would
        be converted to 0xFFFFFFFF, which is -1, and
        would therefore be treated as black.
        (So setting font color to white would result in black
        being shown as font color in the font color UI in experimental
        mode instead...)
        
        In order to actually handle auto color as such, handle
        the special value of -1 right in the `updateColorPickerPosition`
        methods: In that case, unselect any explicitly selected color
        (and set color to transparent for the buttons in the "Style"
        tab of the toolbar, `font_color_picker_button`
        and `font_back_color_picker_button` in `toolbar_bottom.xml`).
        Also, do a logical or to add the alpha layer instead
        of adding 0xFF000000.
        
        While at it, unify the code in the two
        `updateColorPickerPosition` methods a bit.
        
        Change-Id: I2e6512f32e671f92c8d31b2780c350dd74fb0747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133992
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [bc762b702d9869070b05d63e14a39a758a21ad3e]

        android: Don't show any color in palette as selected if none matches
        
        In Android Viewer with experimental editing mode enabled,
        doing the following resulted in black still being marked as
        the current font color in the "Style" -> "Font Color" UI.
        
        1) create a new Writer doc in the desktop version with one
           paragraph that has the font color explicitly set to black
           and one with "Dark Brick 2"
        2) open the doc in Android Viewer with experimental mode enabled
        3) tap on the first paragraph with font color explicitly set to
           black
        4) open the "Style" -> "Font Color" UI where the color could be
           changed (layout file: `toolbar_color_picker.xml`)
        -> black is marked as current font color (OK)
        5) tap on the paragraph which has font color "Dark Brick 2" set
        -> black is still marked as current font color (NOK)
        
        This is because the indices of the previously set
        color would just remain set if the new color
        was not found in any of the palettes which contain
        a set of predefined colors.
        
        Change that to set the index for the `upperSelectedBox`
        palette to 0 (i.e. switch to the first palette), and the
        index of the `selectedBox` (i.e. color within the palette)
        to the special value of '-1' and don't mark any palette
        or color as selected in that case.
        
        The newly introduced `ColorPickerAdapter#unselectColors`
        will be used from elsewhere in a follow-up commit, so
        make it public right away.
        
        The two `ImageButton`s right in the "Style" tab
        in the toolbar (i.e. `font_color_picker_button` and
         `font_back_color_picker_button` in `toolbar_bottom.xml`)
        remain unchanged and keep showing the actual color, since
        those are not restricted to predefined colors in the
        palettes.
        
        For the case where no explicit font color is set
        (i.e. use of automatic font color, e.g. black if no background
        is set, but white if the background is set to black), the
        value '-1' is sent from the C++ side, and no color should
        be marked as selected in Android Viewer, which also works
        with this change in place in general.
        However, the current handling for the "automatic color" case
        on Android Viewer side looks suspicious in more ways that will
        be addressed in a follow-up commit.
        
        Change-Id: I228d57ace5341bd311761f40c477441d1e511d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133989
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [9a249103de13f2a00fc17bf138d3e656f9a311b8]

        android: Switch order of these if/else statements
        
        I find
        
            if (a == b) {
                // statement 1
            } else {
                // statement 2
            }
        
        more straightforward than
        
            if ( a != b) {
                // statement 2
            } else {
                // statement 1
            }
        
        since it doesn't require logically negating twice
        (else block is for `!(a != b)`) in the second form), and this
        also prepares for a follow-up commit where one of the conditions
        will be extended further.
        
        Change-Id: I1d2177bdcf662994e757b626983a9f9626c66aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133988
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [5c452ad4c31bcaa3f0a94c50b5eeb7cbca27da2e]

        android: Don't store selected pos in ColorPickerAdapter
        
        The position is already set and used in `ColorPaletteAdapter`
        as its `upperSelectedBox` member, so stop doing the
        double bookkeeping in both classes and retrieve it
        from there instead.
        
        Change-Id: I59896b85f5d5a0285076f61599be64638fa71121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133987
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [fd50cbbc410ebf949e00881de848bf90cb2f72aa]

        android: Make Color{Palette,Picker}Adapter members private
        
        ... and make some `final` as well.
        
        Change-Id: Ib50ff32788edaea753cc25f119f91a93e936b2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133986
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [87d0037d75386afcaef4002e2e652b95d6cd92d5]

        android: Drop explicit type arguments when calling ctors
        
        Addresses these suggestions shown in Android Studio:
        
        * "Explicit type argument String can be replaced with <>"
        * "Explicit type argument String, ArrayList<String> can be replaced with <>"
        
        Change-Id: Ibc78364cf5b246d8c1e1d32d755c3e8dcf0e32aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133985
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [621db9bfacca199ea1db1abf1a4b57f72fb8c8fa]

        android: Move assignment to existing loop
        
        There is already a loop just before this one,
        so just move that assignment there as well.
        
        Change-Id: Ie93a0275c0940b7932973264352bad64d0489b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133984
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-08  Michael Weghorn  <m.weghorn@posteo.de>  [4c2d7e23861861c13644f1c9e3dc4e4356912f71]

        android: Use existing Color.WHITE constant
        
        ... instead of creating the color from the RGB
        values manually.
        
        Change-Id: I2058de553e2e744440e7d856ca9bfaf5f9041b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133983
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-07  Caolán McNamara  <caolanm@redhat.com>  [50b89a53ffa73c05b64817184be6b5208d66d660]

        use VCL_FLOAT_DEVICE_PIXEL for fuzzers
        
        Change-Id: Id657d45a00c60e281891791dd7e2f178c7857a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133990
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-07  Caolán McNamara  <caolanm@redhat.com>  [441889318ff3bd1340e5c3d8afd868db948f1535]

        ofz#46070 Out-of-memory
        
        Change-Id: Ibc242ae6b267d989997162d9a4dac9a409f172be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133993
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-07  Caolán McNamara  <caolanm@redhat.com>  [cf804594215550379e092ef8dca8c9d8308c987c]

        ofz#47289 attempt to allocate negative len
        
        a problem since...
        
        commit e9c50fbbc3b07ef927d133da9cf2395c55611e0f
        Date:   Sat Apr 2 15:49:32 2022 +0300
        
            tdf#103954: Z compressed graphic formats support for EMF/WMF
        
        which added an unconditional seek to 0 of the stream which isn't
        desirable when done on the original stream which is deliberately
        seeked to the start of the graphic data, seeking to 0 just skips
        back to the start of the enclosing file, e.g. a word document stream.
        
        Presumably this should just happen in the case of the replacement
        decompressed stream.
        
        Change-Id: Ifb67fb265c70d5728a74dc3499f275eb5d69ddbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133991
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-07  Caolán McNamara  <caolanm@redhat.com>  [6a5ebe0766e221b4b900a8c968faac7ec6e0b9e1]

        cid#1504313 Uninitialized pointer read
        
        Change-Id: I0a5fa033a54d8f3b8b0248cf67e252c640b33e82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [e35d97c96139b836d71abd486644f2d576288e8c]

        osl::Mutex->std::mutex in framework::StatusBarManager
        
        Change-Id: I34cdb5ce7e9e5b3c3d8f985057bb7ff09f2b7f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133978
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [825066456efcad3d160bfc08dde5f2f2eaa7850a]

        osl::Mutex->std::mutex in filter::config::CacheUpdateListener
        
        Change-Id: Ib791be8495f2ad2855cceb94d45f2bd0995e3710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133975
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Stephan Bergmann  <sbergman@redhat.com>  [4e7f7a799e3973b8417f318bd4c0ce28ca48e87f]

        This condition is apparently fatal
        
        ...as mnPoints is the size of mxPointAry (see also
        323df76698be1e554ba3342f56a812517a25437a "Revert 'tdf#147919 PPTX export: fix
        curved and bent connector shape'")
        
        Change-Id: I10b9c6bd25bc88754d2d52e851c3871621b0d517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133980
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-07  Stephan Bergmann  <sbergman@redhat.com>  [ea2386b7ca141d0390b5f0c5ca7553aec62e316e]

        Drop excess +1
        
        ...as identified by Noel in the comment at
        <https://gerrit.libreoffice.org/c/core/+/133841/3#message-e2b2c6daa41983c25d6fc758235b993d04e1c055>
        "tdf#148299 Don't unmotivatedly mess with spaces in file names"
        
        Change-Id: Ie118191ceb731ceef3ca92869a4fa8c05f5835e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133981
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-07  Stephan Bergmann  <sbergman@redhat.com>  [7d1511cfd85915e7a0764eb9de4d7a4448741958]

        GCC 12 is still just as broken
        
        Change-Id: Ic2e151eb78512388150492b6dff0c39046d4d3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133979
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-07  Kohei Yoshida  <kohei@libreoffice.org>  [ce911276b87b86b58c45ac4b7e9f5226a7ef95c5]

        tdf#107765: Use the correct sheet index.
        
        This is a follow-up to f15e6293cf78d67963a6e512f60a11ae58da72c5.
        
        Change-Id: I3f1e6bbb1fe83fab48a0c3889fb53c6919f6351d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133967
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-05-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [90d33f5945336fa46b7c02f425100af794768b15]

        tdf#148358 - Compare Non-ASCII variable names case-insensitive
        
        Change-Id: I761eb27b16c92d58df1be8e6011fc9b94db2a59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133774
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-05-07  Stephan Bergmann  <sbergman@redhat.com>  [323df76698be1e554ba3342f56a812517a25437a]

        Revert "tdf#147919 PPTX export: fix curved and bent connector shape"
        
        This reverts commit 1f8c6efbfea10997f188962d036f5c7db4c13f8a, as it caues
        
        > warn:legacy.tools:12871:12871:tools/source/generic/poly.cxx:1581: Polygon::[]: nPos >= nPoints
        > =================================================================
        > ==12871==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x603000445080 at pc 0x7f6303ec7854 bp 0x7ffd23271600 sp 0x7ffd232715f8
        > READ of size 8 at 0x603000445080 thread T0
        >     #0 0x7f6303ec7853 in Point::X() const /include/tools/gen.hxx:83:51
        >     #1 0x7f63045baaa1 in oox::drawingml::lcl_GetConnectorAdjustValue(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, tools::Polygon, com::sun::star::drawing::ConnectorType, std::__debug::vector<std::pair<int, int>, std::allocator<std::pair<int, int> > >&) /oox/source/export/shapes.cxx:1556:27
        >     #2 0x7f63045b731f in oox::drawingml::ShapeExport::WriteConnectorShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) /oox/source/export/shapes.cxx:1701:13
        >     #3 0x7f63045984e7 in oox::drawingml::ShapeExport::WriteShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&) /oox/source/export/shapes.cxx:1956:5
        >     #4 0x7f62b399ad3b in oox::core::PowerPointExport::WriteShapeTree(std::shared_ptr<sax_fastparser::FastSerializerHelper> const&, PageType, bool) /sd/source/filter/eppt/pptx-epptooxml.cxx:1658:22
        
        during CppunitTest_sd_export_tests-ooxml3
        CPPUNIT_TEST_NAME=SdOOXMLExportTest3::testTdf114848
        (<https://ci.libreoffice.org/job/lo_ubsan/2388/consoleFull#-1714579836d893063f-7f3d-4b7e-b56f-4e0f225817cd>)
        
        Change-Id: I7eab9d3ef8e6604a57d3e59a77905edf6ce6e6ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133870
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5af08b3ed160a569d389474dc5d5445dccf3a63]

        tdf#121740 fast path in cancelCommandExecution
        
        skip the cost of constructing a SimpleIOErrorRequest in the common case
        
        Change-Id: Ib0a8989a9ffa76e6b71f984e0f32be94ec5cb8ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133959
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [e855dc52266eab9b43f5f2f679c84eb6e30be46e]

        osl::Mutex->std::mutex in TimeContainerEnumeration
        
        Change-Id: I44e054a6db59cbeae03b50cb0df4bcfdc8f293da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133969
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [09122ed302fd3d77718ee1a63d2ca4d5d7a0ace8]

        remove dead item cleanup from NumberedCollection::impl_searchFreeNumber
        
        which speeds it up a little, because WeakReferences are a little slow
        
        Change-Id: I76226b180ae4e11c4beb9e2f4ae12b05f980dcad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133960
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [a93220b79faad8d679f3c67ccd967cdfac68d49f]

        osl::Mutex->std::mutex in VDevBuffer
        
        Change-Id: I64b48e60f178574a0e0382e72a002a87320bbf39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [2a8401f61646d652a728204605ee3658ca3bdf17]

        osl::Mutex->std::mutex in comphelper::GenericPropertySet
        
        Change-Id: Ifbb8e2f7e8923d7bdc333097d6f415f10670e0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Noel Grandin  <noelgrandin@gmail.com>  [6e8f63f772ebb9487c75324c23352ef3fea8e38b]

        osl::Mutex->std::mutex in librdf_NamedGraph
        
        Change-Id: If28bef2bd44dc469e6534b166d4c25c0a7c3b2eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133968
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9313b6c02cc40633edfaadfc7941cbb5640368b2]

        tdf#62776 - Add tooltip for folder location shortcuts
        
        Change-Id: I326fd3c3695e5467a49688fc2164fe591aef2397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133709
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fe08ae6b383c2222178a21c926480a055a87f99]

        tdf#121740 increase DrawingEngine::OLE_Objects cache limit
        
        shaves 5% off the load time for me
        
        Change-Id: Ia0ed8caa9300bfe5bcf71cfe844b8c4fdaf0fef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133962
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-07  Kohei Yoshida  <kohei@libreoffice.org>  [f15e6293cf78d67963a6e512f60a11ae58da72c5]

        tdf#107765: Check the updated language and apply it to the cell.
        
        During the normal spell-checking in Calc, the user may change the
        language on the string segment with a spelling error, which is supposed
        to be applied back to that segment in the cell, but was not. This change
        should fix it.
        
        In case the new language is applied to the entire cell string, we will
        set the new lanuage to the cell as a cell attribute and keep the string
        as a simple string.  Otherwise, the new language gets applied to the
        edit engine string.
        
        This commit also changes the return value of EditEngine::GetLanguage()
        to include the string span information in addition to the language
        value.
        
        Change-Id: I713ec7aefe571f721321cd8ea687f616ab4dd61a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133966
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-05-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [431c692e4e58a4861e4ab7b4d30b1edf0aab0496]

        vcl: add some basic Animation unit tests
        
        Change-Id: Ib8e33fe5f4360b298d2be02fcb5777c21e71fd0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76400
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-07  Eike Rathke  <erack@redhat.com>  [4ea44fdb19e568093ab1e0549c3ffa33296a486b]

        Resolves: tdf#148843 Handle single reference error values correctly
        
        ... if errors are to be ignored through AGGREGATE(). Affected were
        AVERAGE, SUM, SUMSQ and PRODUCT. An error encountered in this
        constellation lead to the next argument being ignored as well.
        
        Change-Id: Ief28d79b4c230b1a2b6f8f0a865fbf8f51854c4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133964
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-05-06  Noel Grandin  <noelgrandin@gmail.com>  [18715f6a63af55045b108b98abeffeae8e51518b]

        remove unnecessary sequenceToContainer
        
        If we are not going to manipulate the resulting vector, then it is
        actually slower, since we have to allocate more storage for the vector
        
        Change-Id: I65677007d105f4783603df74113ebed6db0b551b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133963
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [b83a8483a1426ba400480d33f7df321fcc02e64d]

        avoid some ref-counting
        
        Change-Id: I11465f139044bc75085d1bb9a5f207889356ee58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133961
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Noel Grandin  <noelgrandin@gmail.com>  [9d0a8f7a2e3e473ebb3042f90dd82696dd8705da]

        osl::Mutex->std::mutex in Content_Impl
        
        Change-Id: I5e3983958629ac732c031b9b59e96deaac63e7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [738b8f09c52a0e0234842c622786fccbb027621b]

        remove unnecessary sequenceToContainer
        
        If we are not going to manipulate the resulting vector, then it is
        actually slower, since we have to allocate more storage for the vector
        
        Change-Id: I6d5f5b0150cea9e8a0663ccb1398b0237f3fca9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Caolán McNamara  <caolanm@redhat.com>  [517e07bbcf668e1ea58dabeb35c0fb467b36ed05]

        tdf#143720 treeview not expanding vertically to fill space
        
        use a simpler box instead of a grid here and it works out ok vertically
        
        Change-Id: I14fd05b25b00f79b115c041a8e9f5c7ebcf49419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [701591fac7eea1ac797bbc328cc934434ffb714e]

        tdf#148920, tdf#91035: sw: Add UItest
        
        Change-Id: Icdeb93a8c45bfccd4f749ec24d8226e9bdd8cdd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133933
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-06  Caolán McNamara  <caolanm@redhat.com>  [531405a695d6bad044545ab96f2eb26e5c6d5778]

        tdf#148962 starmath's UnicodeNotationToggle (alt+x) getting called twice
        
        Change-Id: Ib150e4825c547c19a30c7b66d3f33904b814a917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133942
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-06  Miklos Vajna  <vmiklos@collabora.com>  [71019ec15bd3fe15385443b68614fd2402e0040f]

        sw: don't copy useless char escapement to next node on split
        
        Unless autocorrect notices such a just-typed content, pressing enter at
        the end of a paragraph which ends with superscript or subscript text
        will carry over that formatting to the next paragraph, which is hardly
        wanted by any user. Technically this is not copying: paragraph split
        works by creating a next text node, moving all content & formatting to
        this next node, then move part of the content back to the previous node,
        which is all content in case of an enter at the end of a paragraph.
        
        Copying character formatting over to the next text node makes sense:
        e.g. paragraph alignment or boldness is probably something a user wants
        to continue using in the next text node. But superscript is typically
        created by autocorrect in English text for "1st" and similar input, this
        is usually unwanted in the next paragraph.
        
        Fix the problem by special-casing the RES_CHRATR_ESCAPEMENT case and
        remove the matching SvxEscapementItem from the hints of the just created
        next paragraph in case it's there.
        
        A possible future improvement would be to support this when there are
        other active (direct formatting) hints, in which case going via
        SwDoc::ResetAttrs() is probably a better choice, but the effects of that
        for undo and redlining is not clear.
        
        Change-Id: I57feb99d9a31f16c277eba44f464ab49936b65aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133936
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [40462e3e78e7beb7cd22c8825f473126d1c89ef8]

        update credits
        
        Change-Id: Ib5064763e88ca90d1ad52c71f4ac920de3ae0274

2022-05-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [f4e2d7b006aa86732b30bb7e2f219360481fc724]

        vcl: test ImplAnimView
        
        Change-Id: I1f17dce097810e4507a9feae1675ff486260657a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121698
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [4834cd392a93f14e9fb5c83accc5f416384841cf]

        uitest: fix typo
        
        Change-Id: I1cd8d50a5d4dce0dcb436d218af5de0ed8f05f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133935
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [3a45029a6bd049006a896a789c7ad45eedfdb924]

        Only dereference iterators after checking them
        
        Was this way since commit edf11d28fafac50b6380c9372d0e6cf07a355616
          Author Vladimir Glazounov <vg@openoffice.org>
          Date   Thu Apr 24 16:27:52 2003 +0000
            INTEGRATION: CWS uaa02 (1.3.44); FILE MERGED
        
        Surfaced after commit b1148c31ed2786396f0b018a988fce8288f1797d
          Author Noel Grandin <noel.grandin@collabora.co.uk>
          Date   Wed Apr 27 16:47:53 2022 +0200
            use more string_view in comphelper
        
        where the pointers were changed to iterators, which are checked in
        debug builds, failing an assertion.
        
        Change-Id: I87fce562aef8f50b94fb52ad6c2a79d2e84d6424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133934
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-06  Michael Stahl  <michael.stahl@allotropia.de>  [bbb8617ece6d946957c2eb96287081029bce530f]

        svl: fix crash if user cancels/closes master password dialog
        
        (regression from d7ba5614d90381d68f880ca7e7c5ef8bbb1b1c43)
        
        Change-Id: I8bb9a967aefa2e88f05c23456a0dd1a090e1a5fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133932
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-06  Miklos Vajna  <vmiklos@collabora.com>  [9ca44e925a8e06e0946fa9e7bd80cfdbfbb83c62]

        sw content controls, drop-down: select list item on click
        
        - remember the selected list item in
          SwDropDownContentControlButton::ListBoxHandler()
        
        - extend SwWrtShell::GotoContentControl() to update the document text,
          somewhat similar to how checkboxes are already handled
        
        - improve SwSelPaintRects::HighlightContentControl():
        
          - re-create the vcl widget in case a different content control was
            selected
        
          - adjust position/size and re-show the dropdown button after selecting
            an item + doc text was updated
        
        Change-Id: Id3b89b6132697bfec7046caeb1f0c5fe93e99b37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133915
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-06  Caolán McNamara  <caolanm@redhat.com>  [d357c9fdf9581ba27314dbf6c2433cbdd3e3b602]

        ofz#47268 Integer-overflow
        
        Change-Id: I263f206ce677c9ee1b198ee08f4461272b4adc04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [240a345bc3891887ed551e780ce619d8da303325]

        tdf#121740 reduce cost of OStorage_Impl::GetElementNames
        
        which shows up on the profile
        
        Change-Id: I7e4ef9d71d06562dc1c574fe41d616947e3d67e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133926
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Daniel Kamil Kozar  <dkk089@gmail.com>  [a88419f54b8aa9c23cd80e04bc47f1b5ef3931ca]

        tdf#148383: Obtain start/end strings always in system locale
        
        ScFillSeriesDlg always expects the strings describing the start and end values
        to be in the system locale. This change ensures that and fixes the bug where
        using non-locale-default data in the Fill Series dialog leads to an error.
        
        Change-Id: I25eafa2174294dc35a63473a54c529c2d7bd87ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132532
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-05-06  hasban12138  <1483478664@qq.com>  [2490715c112699487915865f4267a880fe7bc4b3]

        tdf#148837: fix cell range negative selection
        
        In Calc when you select all and then do negative selection, there has a
        bug. The reason is in ScMultiSel::SetMarkArea that case will make nBeg
        larger than nEndRow and in MarkAllCols start will be larger than end.
        So I added a condition in the if clause to make sure that nBeg is not
        larger than nEndRow.
        
        Change-Id: I7f39a588bf928b2885207810534d78481589c2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133538
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-05-06  Justin Luth  <justin_luth@sil.org>  [3a79bd968869f782b8540aea6598c1f8ee14cced]

        tdf#91035 sw page-style UI: All styles shown, not hidden
        
        The first entry in the list (All styles) is what is shown
        by default, so that means that the 0th entry should be
        pre-selected, not the 1st.
        
        Change-Id: I4c204fda41a0551b9f30724df361e4f797a87325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133911
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-05-06  Caolán McNamara  <caolanm@redhat.com>  [c7a32dab567cce8ee435c65299ec60b638700a35]

        Related: tdf#148433 use a slightly different cursor directional indicator
        
        make the rtl/ltr direction arrow equilateral and typically a little
        larger
        
        Change-Id: I9b233b76380865052b2112fda47009ae08c306af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-06  László Németh  <nemeth@numbertext.org>  [28c31ba12567f66ccb6a334fd21af10880f4a33b]

        tdf#128744 sw DOCX: unprotect change tracking with verification
        
        Unprotect change tracking only by password verification
        instead of 1) unprotecting without the password or 2) rejecting
        the correct password.
        
        I.e. now 1) clicking on Record changes icon of Track Changes
        toolbar or Edit->Track Changes->Record asks for a password, and
        2) Unprotect Record changes on Security page of
        File->Properties... accepts the correct password with disabling
        record changes.
        
        Show also "Invalid password!" dialog disabling Record Changes
        by its icon or menu option, like Properties... dialog window does,
        if the password is invalid.
        
        Note: Still allow to unprotect OpenDocument export of a
        protected OOXML import document, because that doesn't contain
        the original password info, only a dummy RedlinePassword.
        (OpenDocument exports protect Track Changes with the simple
        RedlineProtectionKey configuration setting, so it's not
        possible to map the OOXML password info to OpenDocument without
        extending this.)
        
        Follow-up to commit d416250f4f1766e2d596ea3feef6a94b7adf29f4
        "tdf#106843 DOCX: forbid disabling protected Record Changes".
        
        See also commit bfd7730f4cf002a79dc9c02c23286850fee3f12a
        "tdf#89383 DOCX import: fix permission for editing".
        
        Change-Id: Iafcf4a6b551a7e8485d4311aee889c2522526d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133894
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ed883b92efa9ca8e3006290eb2c28485e9052575]

        chart2: add function to create a table shape to ShapeFactory
        
        Change-Id: I18f76c3372504c1d660aa168ee0387f61817f30a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133921
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [71dee51995d46d0c820c83790d521fbd6bdd568d]

        chart2: use range for loop to iterate rVCooSysList in ChartView
        
        We always just iterate the rVCooSysList and don't need the index,
        so change the code to use a range for loop.
        
        Change-Id: I3148d5d251c27d8d8f457446508e3152ae86dcc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133920
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Noel Grandin  <noel@peralex.com>  [92f93f300371d2011b53d48d3491870b24cff0b4]

        output error code when SymFromAddr fails
        
        instead of random data
        
        Change-Id: Iba020ea3a2386e3ad940cc85aac18047c3773967
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7aa0730d6cdf1b2e74e1d8c9adb666cfb51d8fc6]

        chart2: typedef SeriesPlottersType is not needed
        
        Change-Id: I457bfa5eab8b403c4b00a72068e427082709995c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133919
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cc1be7312d9f6bd4a4ea742c6d1e3cb9293631cc]

        svx: move SvxTableShape into own file and externalize
        
        Change-Id: I0c4b37ebafa56ed50286bdcec1f2a8d5e1362f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133918
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1ad2fe68308b556bb95d1c1620a3d5e55982260e]

        comphelper: cleanup test_guards, add test for ValueRestorationGuard
        
        Move each test case into its own test function. Also add the
        missing test for ValueRestorationGuard.
        
        Change-Id: I588ab67f82ba82ef67939dac3d22438e8799ce11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133917
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-06  Julien Nabet  <serval2412@yahoo.fr>  [927561e4662ca2a04daa09914400fa72738531d3]

        Fix for callgrind TB
        
        /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sc/qa/perf/scperfobj.cxx: In member function ‘void sc_apitest::ScPerfObj::testSheetFindAll()’:
        /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sc/qa/perf/scperfobj.cxx:169:51: error: ‘makeAny’ was not declared in this scope
        xSearchProp->setPropertyValue("SearchStyles", makeAny(true));
        
        Change-Id: I484a17fb80c86694d0221670afbcba80fbe14c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133916
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-06  Justin Luth  <justin_luth@sil.org>  [f82644fed3e9266ab21114a2266277059cd5ccb9]

        tdf#148920 sw page-style UI: make conditional filter usable
        
        In windows, and SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice
        the style filter on the conditional tab was disabled.
        It worked fine in gtk3 though.
        
        This fixes a 7.2 regression from tdf#82802's
        commit 1f066313218449cac494a887eb209311efbaa405
        
        Change-Id: I1e6bb8d589224e4ad51ae0057d5278e3888cc3b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133910
        Tested-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-05-06  Kohei Yoshida  <kohei@libreoffice.org>  [1bf5884a7bd5e506c6edd9769f98e3102a4c4eb9]

        Add license information for liborcus, which is used in Calc.
        
        Change-Id: I6cbf93b8f2264a04c6745a2874ff35902e2cd215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133852
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-06  Miklos Vajna  <vmiklos@collabora.com>  [f932b00f3a72dd802a6e50af84c3dc55072a22a0]

        tdf#148929 sd theme: limit PPTX import for shape fill effects to lum mod/off
        
        Regression from 30735bdb5a0a81619000fdd24b2d0fbf45687f01 (sd theme: add PPTX
        import for shape fill color effects, 2022-04-27), the bugdoc's A2 cell
        lost its tinting (its background color is no longer lighter than A1)
        after saving back to PPTX + import again.
        
        The code assumed that in case a fill color has effects, it can only be
        luminance offset or modulation, since that's what the PowerPoint UI
        generates when setting a fill color explicitly. This did not take the
        table style case into account, which uses tinting to make a color
        lighter.
        
        Fix the problem by not importing the theme index / effects if tinting is
        used -- the current doc model is limited to theme index + lum mod/off
        with effects.
        
        This limitation can be removed while text color / fill color effects are
        not limited to lum mod/off, but also support tinting/shading.
        
        Change-Id: I382cc0067518cc262e261a462999170cb7db261b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133908
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [11f0cb056f8082103fbb06b4a339322f46b77d13]

        Remove duplicated includes
        
        Change-Id: I137707aaad44ffe42bb4b234a59ff69e4b2ecaa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133884
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-05-06  offtkp  <parisoplop@gmail.com>  [e9c50fbbc3b07ef927d133da9cf2395c55611e0f]

        tdf#103954: Z compressed graphic formats support for EMF/WMF
        
        - Added .emz and .wmz file opening support
        - Added a function to check for Z compression that
        all z comp. formats can use
        - Added 3 unit tests for emf/emz/wmz files
        and the example files have been checked with
        a different tool (File Viewer 4)
        - emf/emz file detection changed from magic byte checking
        to extension checking, like wmf/wmz does
        
        Change-Id: I3e433fd23d18482648a51cd04b8f467368e97b62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132456
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-05  Caolán McNamara  <caolanm@redhat.com>  [e4a7a50d831cb6fca95f2afff2af5298d66b5876]

        ofz#47241 don't use hardcoded SalLayoutFlags::BiDiStrong mode for fuzzing
        
        getting different results vs the real world wrt glyph caching, go back
        to normal and try a different approach when timeouts return
        
        Change-Id: Ifb335888615b82c9bea83bd19a1cabcf8660dc74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133909
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-05  Caolán McNamara  <caolanm@redhat.com>  [d66fb70959b13dd822664867c363591b2c401767]

        tdf#148771 in scrollable dropdowns show some lines before selected entry
        
        and don't just position with the selected entry at the top so it's quick
        to pick preceeding adjacent entries
        
        Change-Id: I20103200c34037fb02b3c0dcc29d154c1197549d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133893
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [869a5897cfe8de5f69b2a72f296a443467907c02]

        Upgrade external/boost to latest Boost 1.79.0
        
        <https://dev-www.libreoffice.org/src/boost_1_79_0.tar.xz> has been generated (on
        Fedora 35) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.79.0/source/boost_1_79_0.tar.bz2
        > $ printf '475d589d51a7f8b3ba2ba4eda022b170e562ca3b760ee922c146b6c65856ef39 boost_1_79_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_79_0.html>
        > boost_1_79_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_79_0.tar.bz2
        > Unpacking boost_1_79_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_79_0.tar.xz ...
        > Cleaning up ...
        > 2058aa88758a0e1aaac1759b3c4bad2526f899c6ecc6eeea79aa5e8fd3ea95dc  boost_1_79_0.tar.xz
        > Done.
        
        boost.utility.Wundef.warnings.patch was obsoleted by
        <https://github.com/boostorg/utility/commit/c3aab6a18411e637842247e0dd845c58ce8c6d6b>
        "Use #ifdef to test for BOOST_MSVC."
        
        Change-Id: I959f8ab42c3e20b9424cc3054421af60f6edd0d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133895
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Regina Henschel  <rb.henschel@t-online.de>  [124382eba6aaeb475b4077920c082bf5c51ac029]

        tdf#148707 implicit moveTo on all not only on first
        
        The current solution checks implicit moveTo only on the first arc in
        a sequence of arcs. The patch moves it into the loop, so that the
        implicit moveTo is done for each command in a sequence.
        
        Change-Id: I400fa8fc96d7377ede55296c71e7a82ce891cc24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133896
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [cf7e3ac040d1249f6df0d6796e11d834285680f0]

        Reinstate external/cairo/cairo/san.patch.0
        
        (Instead of just removing any hunks that no longer applied,
        86132d8188e5e76623dc8053e5a43c1d69eb0831 "upgrade to cairo 1.17.6" had dropped
        it completely presumably in error.)
        
        Change-Id: I98fe20fc96bd5ce9400b6ad6a9837b21f08cdff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133892
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e57e164844e67faaf2b0424181c2df29e871992]

        loplugin:unusedvariableplus
        
        Change-Id: Id93086be1224b6f6bf0bdaa1d50b4f289099027e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133876
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-05  Hossein  <hossein@libreoffice.org>  [7fe756570fb4ab30f540d644fd5125a67c2d9ea9]

        Warn if Visual Studio 2019 version is < 16.10
        
        During the compilation with Visual Studio 2019 v16.5, the dragonbox
        was failing the build, but it was OK when ugprading to the latest
        version, 16.11.
        
        It should be noted that according to the list of predfined macros in
        Visual Studio, v16.10 and v16.11 use the same value for _MSC_VER,
        which is 1929. Thus, the distinction between these 2 versions can not
        be distinguished.
        
        Predefined macros
        https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
        
        For not having the Visual Studio version > 16.10, a warning is
        shown, and if the Visual Studio version is < 16.5, just like before,
        an error is generated.
        
        Change-Id: I6661ee5121b03ca43e1f7503b74191abcc8d6b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132907
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-05-05  Hossein  <hossein@libreoffice.org>  [759792e40aceb17a621c37ed725d1e998acbd30d]

        tdf#148818 Fix missing text in boxes with empty first paragraph
        
        Text was lost from the text boxes with empty first paragraph. The
        problem was happening when there was 2 paragraphs in a text box, in
        which the first paragraph was completely empty. The regression was
        introduced in cf2449aac0141711a7610d67f7c50cd108e12443 because of the
        bad handling of the paragraphs, and only looking at the size of the
        text of the first paragraph.
        
        This is fixed by looking at mpOutliner->GetEditEngine().GetTextLen(i)
        for all i=1..k where k=min(2,mpOutliner->GetParagraphCount()).
        
        I have negated the condition to provide a better explanation of what
        the condition should be.
        
        Change-Id: Id5d8787df5111c734760afdd98a6fbe832047f32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133527
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [4351a6ca782e1d2081ba819338ebbf6a2d2ee2b2]

        tdf#145312: xmlsecurity_pdfsigning: Add unittest
        
        Change-Id: I12d6af46d13daa06eab98cdf81c82c6f5f41b5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133881
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-05  Caolán McNamara  <caolanm@redhat.com>  [00ca6261e812dc9c4b1cd882b76617b77a86e4e4]

        ofz#47239 Heap-use-after-free
        
        since
        
        commit 9bb83eefc1a1dda5c48efc5d09ef4a6840bf8b58
        Date:   Tue May 3 16:30:20 2022 +0200
        
            use more string_view in oox::vml::ConversionHelper
        
        ==169915== Invalid read of size 2
        ==169915==    at 0x484E2C0: memmove (vg_replace_strmem.c:1382)
        ==169915==    by 0x49D0EE6: char16_t* std::__copy_move<false, true, std::random_access_iterator_tag>::__copy_m<char16_t>(char16_t const*, char16_t const*, char16_t*) (stl_algobase.h:431)
        ==169915==    by 0x49D0E94: char16_t* std::__copy_move_a2<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) (stl_algobase.h:494)
        ==169915==    by 0x49D0E64: char16_t* std::__copy_move_a1<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) (stl_algobase.h:522)
        ==169915==    by 0x49D0E03: char16_t* std::__copy_move_a<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) (stl_algobase.h:530)
        ==169915==    by 0x49D0D84: char16_t* std::copy<char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) (stl_algobase.h:619)
        ==169915==    by 0x49D0C2E: void rtl::str::Copy<char16_t>(char16_t*, char16_t const*, int) (strtmpl.hxx:122)
        ==169915==    by 0x49CF83E: void rtl::str::newFromStr_WithLength<_rtl_uString, char16_t>(_rtl_uString**, char16_t const*, int, int) (strtmpl.hxx:955)
        ==169915==    by 0x49E3A44: rtl_uString_newFromStr_WithLength (ustring.cxx:1238)
        ==169915==    by 0x2B76A771: rtl::OUString::operator=(std::basic_string_view<char16_t, std::char_traits<char16_t> >) (ustring.hxx:653)
        ==169915==    by 0x2BC69DB4: oox::vml::TextBoxContext::TextBoxContext(oox::core::ContextHandler2Helper const&, oox::vml::TextBox&, oox::AttributeList const&, oox::GraphicHelper const&) (vmltextboxcontext.cxx:199)
        ==169915==    by 0x2BC46E5A: oox::vml::ShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:555)
        ==169915==  Address 0x267e1264 is 52 bytes inside a block of size 68 free'd
        ==169915==    at 0x48470E4: free (vg_replace_malloc.c:872)
        ==169915==    by 0x49CFB73: void rtl::str::release<_rtl_uString>(_rtl_uString*) (strtmpl.hxx:879)
        ==169915==    by 0x49CF8B4: void rtl::str::newFromStr_WithLength<_rtl_uString, char16_t>(_rtl_uString**, char16_t const*, int, int) (strtmpl.hxx:966)
        ==169915==    by 0x49E3A44: rtl_uString_newFromStr_WithLength (ustring.cxx:1238)
        ==169915==    by 0x2B76A771: rtl::OUString::operator=(std::basic_string_view<char16_t, std::char_traits<char16_t> >) (ustring.hxx:653)
        ==169915==    by 0x2BC69C87: oox::vml::TextBoxContext::TextBoxContext(oox::core::ContextHandler2Helper const&, oox::vml::TextBox&, oox::AttributeList const&, oox::GraphicHelper const&) (vmltextboxcontext.cxx:194)
        ==169915==    by 0x2BC46E5A: oox::vml::ShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:555)
        ==169915==    by 0x2BC47AE0: oox::vml::RectangleShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:715)
        ==169915==    by 0x2BC47B24: non-virtual thunk to oox::vml::RectangleShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:0)
        ==169915==    by 0x2B7341ED: oox::core::ContextHandler2Helper::implCreateChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (contexthandler2.cxx:100)
        ==169915==    by 0x2B734A7A: oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (contexthandler2.cxx:204)
        ==169915==    by 0x2B735464: non-virtual thunk to oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) (contexthandler2.cxx:0)
        ==169915==  Block was alloc'd at
        ==169915==    at 0x484486F: malloc (vg_replace_malloc.c:381)
        ==169915==    by 0x49CFA18: _rtl_uString* rtl::str::Alloc<_rtl_uString>(int) (strtmpl.hxx:838)
        ==169915==    by 0x49E0D72: rtl_uString_ImplAlloc(int) (ustring.cxx:1194)
        ==169915==    by 0x49E1355: rtl_string2UString_status(_rtl_uString**, char const*, int, unsigned short, unsigned int, unsigned int*) (ustring.cxx:466)
        ==169915==    by 0x49E1117: rtl_string2UString (ustring.cxx:576)
        ==169915==    by 0x205735F3: rtl::OUString::OUString(char const*, int, unsigned short, unsigned int) (ustring.hxx:451)
        ==169915==    by 0x20571680: sax_fastparser::FastAttributeList::getOptionalValue(int) (fastattribs.cxx:283)
        ==169915==    by 0x205716DC: non-virtual thunk to sax_fastparser::FastAttributeList::getOptionalValue(int) (fastattribs.cxx:0)
        ==169915==    by 0x2BA85A6B: oox::AttributeList::getString(int) const (attributelist.cxx:173)
        ==169915==    by 0x2BC69B06: oox::vml::TextBoxContext::TextBoxContext(oox::core::ContextHandler2Helper const&, oox::vml::TextBox&, oox::AttributeList const&, oox::GraphicHelper const&) (vmltextboxcontext.cxx:186)
        ==169915==    by 0x2BC46E5A: oox::vml::ShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:555)
        ==169915==    by 0x2BC47AE0: oox::vml::RectangleShapeContext::onCreateContext(int, oox::AttributeList const&) (vmlshapecontext.cxx:715)
        
        Change-Id: I745d8b718cccf894bda774b0343c2b17f49b0eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133880
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [abac7828ae85ecb42e73e83141f6e6c475b66db2]

        Deprecate css::uno::makeAny; completely disable it for LIBO_INTERNAL_ONLY
        
        There is just no good reason not to use a css::uno::Any constructor instead, so
        simplify the code base.  For URE backwards compatibility, keep it around as
        deprecated for !LIBO_INTERNAL_ONLY.
        
        Change-Id: I9409d8853cac270d47377a31ba35a1fc23fa9800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133879
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6e2e8b1fe932fef6cf4d5bf7ccda604dfc2f70ad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 886426b32dfefc962fc700dbf3adfeca7ca3c15e
          - Fix typo
            
            Change-Id: Ibd2cf7b5e4ac76b5320799d597a600fe733c7843
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133883
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-05-05  Caolán McNamara  <caolanm@redhat.com>  [c142722d0b2a16de3ce92f82e5f9552581912b39]

        vertical text test fails with latest harfbuzz
        
        with font "Droid Sans Japanese" which doesn't seem to be available in
        ci, but is by default in the Fedora 37 build roots
        
        I suspect since: https://github.com/harfbuzz/harfbuzz/issues/537
        
        Change-Id: I23d9415444668ce379765f32a96ed67f057ebfd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133846
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f1701d01d9f664828356976d8592492f85b30f5]

        use more o3tl::getToken
        
        found by inspecting call sites of OUString::getToken
        
        Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-05  Mike Kaganski  <mike.kaganski@collabora.com>  [b8bb44161aeb6e00526a38343b63e678ce7d4a1a]

        tdf#146007: make sure to not hold solar mutex
        
        COM might need to forward the call to another thread (with corresponding
        apartment); if that thread happens to wait for solar mutex, COM call may
        deadlock.
        
        Change-Id: I8fcf04619cd29b678fd7ade87254b9aad2f639a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133853
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [7c5d3d74ee7c1f5bb87e46c5ff532451a94cf115]

        Just use Any ctor instead of makeAny (Linux, sequel)
        
        Change-Id: Idcf537a838bb0e47cfa31db8bc09e477b277ee37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133875
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Michael Stahl  <michael.stahl@allotropia.de>  [08c979e235aa993f50e54224f8c715bb70697c33]

        sfx2: remove misplaced try-catch
        
        The exception is actually caught in an inner catch block; it was like
        this already when added in commit
        b4576f3da4d90139fc5140962d13cb91dab98797.
        
        Change-Id: I054c59493efe7d2d69877559b048bcf3c1f173e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133837
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-05  Michael Stahl  <michael.stahl@allotropia.de>  [cb64a52afc92891ab853b9bb1294610bb9ca98d0]

        ucb: webdav-curl: if LOCK fails, display error message
        
        Sharepoint may reject LOCK with HTTP/1.1 403 FORBIDDEN
        and then a dialog pops up via UUIInteractionHelper that says
        "Server error message: ."
        
        Let's actually put some error message in the dialog, why not the
        HTTP status line, plus a little prefix to see which method failed.
        
        Change-Id: Ied895787f813c5cddcb18eb4f693d5bfc8c62076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133835
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [b3a4ebd8de244078712d48f21a126f6246b7bc4e]

        tdf#148921: sd_import_tests-smartart: Add unittest
        
        Change-Id: Ib2016afb06914d453fe398127b2f6f50e48c0e93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133834
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-05-05  Miklos Vajna  <vmiklos@collabora.com>  [1c0dbc2c5c782c118ce44825d92f697a6265fc75]

        sw content controls, drop-down: show list items on click
        
        - add a generic SwContentControlButton, to be used for dropdowns, but
          meant to be useful for other types in the future (e.g. date picker)
        
        - add a contentcontroldropdown .ui file for the welded list items
        
        - add a SwDropDownContentControlButton, which contains the
          drop-down-specific logic
        
        - invoke content control button from HighlightContentControl(), so list
          items are shown on button click
        
        Change-Id: Ib3c6765020c5b3b1dd343a40a2b1862c73feaac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133874
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [d15a6560bd445cd1931e9fded6ad8ecfdd54211b]

        use more string_view
        
        found by examining the call sites of OString::getToken
        
        which means I needed to add a new o3tl::equalsAscii function
        
        Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [c895edf3f67f19d8d2012674c084456a7851436e]

        tdf#148921 Smartart: Incorrect Text position
        
        Revert
            commit b6fe3b13206eee0543ded37c3a1566add284e6da.
            no need to have two weak references to SdrObject in SvxShape
        
        Change-Id: Ie29d0002fd86226eb7634f621b43e7cb8dfc8aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [d7fbea57ef945c1444185581787d17a93dda8cd9]

        tdf#148299 Don't unmotivatedly mess with spaces in file names
        
        This conversion of double to single spaces had been done ever since
        84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", but it is unclear to
        me why.
        
        The same conversion functionality is also used at two places in
        sw/source/ui/dialog/uiregionsw.cxx.  Not sure if it has any motivation there, so
        lets keep that intact for now.
        
        Change-Id: I0558f015c53f69a9a405891b9dad21a98de3533c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133841
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Miklos Vajna  <vmiklos@collabora.com>  [0c13e4768c3c7937c2fd71675c86ff8a0ca3fe50]

        sd theme: add ODP import/export for shape fill color effects
        
        Map a themed color with effects to:
        
        <style:graphic-properties draw:fill-color="..." loext:fill-theme-color="..." loext:fill-color-lum-mod="..." loext:fill-color-lum-off="...">
        
        Change-Id: I18d8ddf8d6050ef468a8d67a9e797a576f682e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133843
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [574018db41b9be7619bddda098c6068efdc2886a]

        Just use Any ctor instead of makeAny in avmedia
        
        Change-Id: Ib43fa3be2e63de8ad6967682c2b00e702eb527ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133850
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [ffdad488a8d2cd52e7bc81c9dee7c9aa562d80e8]

        Just use Any ctor instead of makeAny in accessibility
        
        Change-Id: I7860a176bfd44d8f5071ece03229bc7f768d9d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [b5ab864096c6b099e6a79587f881f287234278f9]

        Just use Any ctor instead of makeAny in basic
        
        Change-Id: I21d9679064c4e68a1492d3550f083c3c91b5b43b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133848
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [3db0b7549e198ac0719ff52bff38a3d79e212083]

        Just use Any ctor instead of makeAny in basctl
        
        Change-Id: I4bd58031623dea1243193aaa60f6ca5bb0f7d562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133849
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [6ad8a6398dbf2b4605ee4c3c222a0c2ee396c163]

        Just use Any ctor instead of makeAny in chart2
        
        Change-Id: I156cd5597a4b9e683913d9730b8d8bb22e8064f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133845
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Stephan Bergmann  <sbergman@redhat.com>  [baf8ce5955c6e20fe730b33093b704a6eb377d18]

        Just use Any ctor instead of makeAny in canvas
        
        Change-Id: Iade345e814f2809bead96b228afa925d86057696
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133847
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fe61ab648e0f3b5993660f2255aca2de6f53c2a2]

        T no more...
        
        Change-Id: Ide06d5b57ddc203f5877b1f8ea8309234da7fca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133854
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [345d46112872842c34b6e3feb84d7407094dee64]

        Just use Any ctor instead of makeAny in cli_ure
        
        Change-Id: Iae41d9c4b600635bd5e2e61b65ea3859a14e6a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133840
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [eae2e1d6d61e7096d3fc0220832a1d1705d70093]

        Just use Any ctor instead of makeAny in comphelper
        
        Change-Id: Ib3edbef27c2d25dae8bac07e0199af071131170e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133839
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [158bd4ae5c5fc9a3ab96c46fd20a56bc0d5b81dc]

        Just use Any ctor instead of makeAny in cui
        
        Change-Id: Ibc76372e161a579df60c2265a4727b619e4a0b63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133830
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [1f110bf567bc5ea85d19a5a4d273ac072f8aaced]

        Just use Any ctor instead of makeAny in connectivity
        
        Change-Id: I68e7354f094ee0e673d105dd8770a658810703d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133838
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [cc6247a064360c943421a1cdcb996bf9a7324c2f]

        Just use Any ctor instead of makeAny in cppu
        
        Change-Id: Ie178e13251b7cb1b69facbbc12e530f6dc4632ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133836
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [86132d8188e5e76623dc8053e5a43c1d69eb0831]

        upgrade to cairo 1.17.6
        
        Change-Id: Ibdf84df380c89d3a0713163920a576bf1c47873a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133825
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [36aa242429ca992b20574f4974d471d544247362]

        Resolves: rhbz#2081661 gtk-critical gtk_tree_view_scroll_to_cell assertion
        
        Change-Id: I4c7c4caed907072ef3a73ccfafabe882d618fa0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [7ba88f7981305a08a162b5f38a49dc2bd1143a09]

        Just use Any ctor instead of makeAny in cppuhelper
        
        Change-Id: I296f297060f10e09639da837df44cc9d30cc594b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [3705139a8ecc98cd8f548cb7706503bd72dd4029]

        Just use Any ctor instead of makeAny in desktop
        
        Change-Id: Ieca85ea1b822ffa80420ed1cb6950bdedd15d000
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133828
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [5e4134535391e9977e72c7001e3b4a5eea113c3c]

        Just use Any ctor instead of makeAny in extensions
        
        Change-Id: I0441d30044168563b0d5b8406fcc99b51a9cbc1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133817
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [031173da38de93e5153c5d2c105706df07127b99]

        Just use Any ctor instead of makeAny in dbaccess
        
        Change-Id: I8b20d60d536a8fb3d3396e1ce26bacf309637f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133829
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [c7b923a9ebaa40809c11659f8816a1d2bfd44c89]

        Some JREs need the bin/server/jvm.dll path after all
        
        ...which had been removed in 18bdf78e156f3cd1e6ccbb3ae28e919583bac70c "Azul is
        just another OpenJDK variant", when fixing the previously mis-classified Azul
        JRE from "uses OtherInfo" to "uses SunInfo".  But the IBM Semeru Runtime
        (<https://developer.ibm.com/languages/java/semeru-runtimes/downloads/>) is
        another arguably mis-classified case due to its java.vendor of "IBM Corporation"
        (and where the
        
            VENDOR_MAP_ENTRY<OtherInfo>("IBM Corporation"),
        
        line in jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx might be relevant for
        some other JRE from IBM; at least, that entry is present ever since the
        introduction of vendorlist.cxx in 738e9b77b9d181b376188e405e1eb353cf93c597
        "INTEGRATION: CWS jl8").
        
        So just generally support the bin/server/jvm.dll path here for "uses OtherInfo",
        even though it should actually only be necessary for "uses SunInfo".
        
        (See the mail thread starting at
        <https://listarchives.libreoffice.org/global/users/2022/msg00246.html>
        "[libreoffice-users] LibreOffice 7.3.3.2 Windows 64 bit seems not detect
        AdoptOpenJdk JRE Windows 64 bit runtime".)
        
        Change-Id: I3a4d02309b7c833c3cd32dc2dda4f4cb7b216693
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133827
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [6ebf46e332facfae5fd6027ec667ccd5993dd493]

        upgrade to latest harfbuzz
        
        Change-Id: I149d7a5d36c6546d3e6898b2b55ce6cd585d4d41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133824
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Gabor Kelemen  <kelemeng@ubuntu.com>  [079659eb7d15f15a37f1f508beb5cffe24fe6f25]

        Drop --with-iwyu option
        
        Nowadays the bin/find-unneeded-includes script is a better
        solution for this problem
        
        This essentially reverts the commits:
        c716b3888e7e8150d1c1053ee6550afb56438b1f
        096c7e889f3b9bd42a81fb0216e2a68fb27159fc
        40e7eecb7efeeb9af59206d7a9c82ac55adf5279
        
        Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-05-04  Aurimas Fišeras  <aurimas@members.fsf.org>  [405ab5c3307948bfcf12670d7ac6df0b86fb8832]

        Fix typo in cbc34f69ec6363cd234ad2b1dfe09bfb531238db
        
        Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org>
        Change-Id: Iee5c7aec7817bc7af5f45d192165fe30301788d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133823
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [f1a9e1d8139db4461c1a1c5fee7b1131ce99eece]

        Just use Any ctor instead of makeAny in editeng
        
        Change-Id: Ic6a392ce006c9348abc28a5940c4ee0425e5b990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133820
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [a1c62cfc605a35f82dba4d9bfa47ab065e47cd99]

        Just use Any ctor instead of makeAny (macOS)
        
        Change-Id: I6c185eecf943205f78567393f0ef588580ee4dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [9c1c80bc9f679130939fccd251559c27abf675c8]

        remove unused layout call
        
        I should have removed this in bfb6a42e26de28d88ced43eb3a2c63ce323.
        
        Change-Id: Ieb4b5fabcc1eecf82dbacef66bef8288b6c51761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133815
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-04  Michael Stahl  <michael.stahl@allotropia.de>  [f670422a01e7336ba8a554331f3781ec7f5c4e8c]

        libxml2: upgrade to release 2.9.14
        
        Fixes CVE-2022-29824.
        
        Change-Id: I31d6ec794b01dee0bb17022ef2e18d2acd8255df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133813
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [5c1c4402809eebb092f9bba812fa0b07a3196343]

        Just use Any ctor instead of makeAny in embeddedobj
        
        Change-Id: I7e00a4b17b9fc3ccfb360ae5737d253a7d31d02b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133819
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [562499b75abf465ad15b4c7eac73616a6bf137b5]

        Just use Any ctor instead of makeAny in embedserv
        
        Change-Id: I2e5f94454a9e5d157cec1f883546655e8c11bd1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133818
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [720c0d61b0eb8c7ce945555293fa66ac2536cf82]

        Update git submodules
        
        * Update translations from branch 'master'
          to 87be4f00f4c2a9b269779ee4f1d6b2417a45a113
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I6f0fe9f8928d5a663a14c9d21990e37f94ee18f6
            
2022-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [1b928e0f21a21d03de38acf40c3aea50f3a59a88]

        reduce string conversions in jsdialog::ExecuteAction
        
        Change-Id: Id1b908e06ebaa7f6ba5981abff51584623770215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [cc264e8ee744aa2802edcac124e37b0cdc398778]

        Just use Any ctor instead of makeAny in filter
        
        Change-Id: I68bbbc2cc80ac5efde78e10706b488bf78c058bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133816
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [9bb83eefc1a1dda5c48efc5d09ef4a6840bf8b58]

        use more string_view in oox::vml::ConversionHelper
        
        Change-Id: I8616f608ee4cc62114acb4fbd774796bc11d1911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-04  Michael Weghorn  <m.weghorn@posteo.de>  [7250d61c28a9467fa17736717b409cefd50867d3]

        android: Don't use log tag longer than 23 chars
        
        Addresses this lint error:
        
        > .../android/source/src/java/org/mozilla/gecko/gfx/SimpleScaleGestureDetector.java:146:
        > Error: The logging tag can be at most 23 characters, was 31
        > (GeckoSimpleScaleGestureDetector) [LongLogTag]
        >         Log.e(LOGTAG, "No gesture taking place in getFocusX()!");
        
        Change-Id: I1d18fb3717ccea8dc36695bfef888d035efe8d55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133799
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-04  Michael Weghorn  <m.weghorn@posteo.de>  [0b463cbc22d00f40055983c213c505c60064289a]

        android: Make clear that column index is non-negative
        
        Use `Cursor#getColumnIndexOrThrow` instead of
        `Cursor#getColumnIndex` here, as suggested in the
        `Cursor#getColumnIndex` doc [1]:
        
        > Returns the zero-based index for the given column name, or -1 if the
        > column doesn't exist. If you expect the column to exist use
        > getColumnIndexOrThrow(java.lang.String) instead, which will make the
        > error more clear.
        
        As described in the `OpenableColumns` doc [2],
        `OpenableColumns.DISPLAY_NAME` is one of the two
        standard columns that must be supported:
        
        > These are standard columns for openable URIs. Providers that serve
        > openable URIs must support at least these columns when queried.
        
        Addresses this lint error:
        
        > .../android/source/src/java/org/libreoffice/ui/FileUtilities.java:139: Error: Value must be ≥ 0 [Range]
        >                 displayName = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME));
        >                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >
        >    Explanation for issues of type "Range":
        >    Some parameters are required to in a particular numerical range; this check
        >    makes sure that arguments passed fall within the range. For arrays, Strings
        >    and collections this refers to the size or length.
        
        [1] https://developer.android.com/reference/android/database/Cursor#getColumnIndex(java.lang.String)
        [2] https://developer.android.com/reference/android/provider/OpenableColumns
        
        Change-Id: I946fcd32a905a4bb8c0527fc1199b9dcc52bccfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133798
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-04  Michael Weghorn  <m.weghorn@posteo.de>  [4fb2a667a634d04cbb72f005e7a74b4f29af0f81]

        android: Call base class implementation in 'onActivityResult'
        
        Addresses this lint error:
        
        > android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java:253: Error:
        > Overriding method should call super.onActivityResult [MissingSuperCall]
        >     protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        >                    ~~~~~~~~~~~~~~~~
        >
        >    Explanation for issues of type "MissingSuperCall":
        >    Some methods, such as View#onDetachedFromWindow, require that you also call
        >    the super implementation as part of your method.
        
        Change-Id: Iab2bdadae7a776e4f52d671a6fd47c1b8146b2a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133797
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [9ab58d8cd680217e5cc3d0f5daa7dfd89107ddec]

        remove stray printf
        
        not one of mine for a change
        
        Change-Id: Iaa4151f8fcb0b31d98514075473d2768fbadd69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133810
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [ea59e9d9917421469b4c09c5ff41cf369c29939c]

        ofz#47199 Abort
        
        Change-Id: I5e18242b3a18f0c9ca1891ab4e29bd43aaab1f26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133811
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [e24daee6fd26da9de993128674bdb10d2fbc6cd1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21955867dc01dbc9e897c585c3a85299eb8f36ad
          - tdf#148444 corrections to Print Preview Bar and related pages
            
               text/swriter/main0210.xhp (Print Preview Bar)
                 *change order of commands to match toolbar
                 +add <embed> to (new) Single Page Preview
                 +add "Jump to Specific Page" command (no icon exists)
                 +add Print command and icon
                 +add Close Preview command and icon
                 +add <embeds> to "zoom in" and "zoom out" icons
                 *refactor to <h1>
            
               text/swriter/02/10040000.xhp
                 + add this file for Single Page Preview, with icon table
            
               text/swriter/02/10070000.xhp (Multiple Pages Preview)
                 +commit beginning with 0f337351 in 2013 accidentally removed
                   the <h1> line, now added back.
                 *changed description to match current behavior of command
                 +added More Options header
                 *refactor to <h3>
                 -remove colspan= rowspan=
                 *change image to .svg
                 *change image size to 1cm
            
                text/swriter/02/10080000.xhp (Book preview)
                 *refactor to <h3>
                 *change image to .svg
                 *change image size to 1cm
            
               text/swriter/02/10020000.xhp (Zoom out)
                 +add section to icon table
                 *refactor to <h1>
                 -remove colspan= rowspan=
                 *change image size to 1cm
                 *change image to .svg
            
               text/swriter/02/10010000.xhp (Zoom in)
                 +add section to icon table
                 *change image to .svg
            
               text/swriter/01/01120000.xhp (Print Preview)
                  +add link to Print Preview Bar page in description
                  -drop Related topics and link with incorrect label
                  *refactor to <h1>
            
            Change-Id: I902fe42d7f0405e2cfe3600199f5ab3fcb7e459c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132610
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-04  Tibor Nagy  <nagy.tibor2@nisz.hu>  [1f8c6efbfea10997f188962d036f5c7db4c13f8a]

        tdf#147919 PPTX export: fix curved and bent connector shape
        
        by calculating and exporting adjustment values to avoid
        of connector lines with bad turns overlapping the
        connected shapes.
        
        Change-Id: I615a20f3ba3c5d03ae73d87848dc41e9ecd29ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133635
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-04  László Németh  <nemeth@numbertext.org>  [d1ac8df139a2a65db45d1970ccc0b80e17d827f6]

        tdf#146346 DOCX import: fix table margins in footnotes
        
        Paragraph of the anchoring point of the floating table
        needs zero top and bottom margins, if the table was a
        not floating table in the footnote originally, otherwise
        docDefault (Standard) margins could result bigger vertical
        spaces around the table.
        
        Quasi regression from commit c46950fee11f5207fb8324947280cd565ae483e7
        "tdf#143583 DOCX import: fix lost empty paragraphs of footnotes"
        (before this commit, empty paragraphs at the end of the footnotes
        were removed by accident, which hid the real problem fixed now).
        
        See also commit e11c51eefe8c3210cef2b5850f401ba67a401d01
        "tdf#95806 tdf#125877 tdf#141172 DOCX: fix tables in footnotes"
        (Note: before this commit, only a single table was shown instead
        of the eight tables of the eight footnotes.)
        
        Change-Id: I4180a6f7d7c49faf0842637b23aa1c8c5680a76c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133752
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [efdf328a7147582d21da43966ed8afef2394d812]

        Just use Any ctor instead of makeAny in forms
        
        Change-Id: I25183cc06728c81e45b28fd41071c15abf05bbc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133809
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [6b6df07d2fe6346bc5a6b32912abcb7694853e2a]

        Just use Any ctor instead of makeAny in framework
        
        Change-Id: I9f4990cf58cc794408dd70cd7fbfb2a8effa138c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133806
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [f04375e1cfaadb12b2c42c8f0fbb0c05b223e092]

        Just use Any ctor instead of makeAny in linguistic
        
        Change-Id: I8697999ecedc1c3d368509470581635b087bcea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133802
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [b58c0531cfb1bc9d1d948f6298b30e8afe0f6f35]

        simplify lcl_parseHandleRef
        
        Change-Id: I0a7cb2754ab43b8b627f196c99778b5fa3f2e005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [66a71a288bea335cd5737710ee2f7e36ebd934a4]

        tdf#131725 use first page directionality for x-reference dialog TreeView
        
        Change-Id: Ib827f4e73266f6416ba8459214263545291c4727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133779
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [5493ddc18ffd256ae85ef6aa26649f177164ac7e]

        Just use Any ctor instead of makeAny in fpicker
        
        Change-Id: Ib23b10759bdc7c2eca4b585992756075e2642dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133807
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [cceeb407c61e9af14a300e8fcfaa57fd91ede49e]

        Related: tdf#131725 match the basegfx translation to the mirror logic
        
        that is used in the traditional code path, this will fix vcl RTL
        scrollbars in otherwise LTR UI
        
        Change-Id: I1451f7e17b93b0339ded6d33147df6415274ebfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133780
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [609402c6167c33f74b17e0c6c4ba093b343abd01]

        Just use Any ctor instead of makeAny in io
        
        Change-Id: I3b659072c54dde7f49aa90e5d52d24f5d762654a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133805
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Seth Chaiklin  <sdc.blanco@youmail.dk>  [c1c9905fce26c8058c640f8cee0827d423698875]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 987e2b26ee08db2d16ae224244324195c9247c17
          - clarify use of Alt+Enter for sections and tables
            
            Change-Id: I5436fe3b75ba73bf866ce34268ab3b33dcdf1778
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133600
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            
2022-05-04  Michael Stahl  <michael.stahl@allotropia.de>  [65362d63b9019e45d1224ed6d78d4e1d443d6b00]

        ucb: webdav-curl: fix handling of non-standard properties
        
        Sharepoint uses properties like these:
        
        "http://schemas.microsoft.com/repl/resourcetag"
        "urn:schemas-microsoft-com:Win32CreationTime"
        
        They aren't standard and don't match our own ucbprops namespace, and it
        looks like they should be handled by an encoding to a name like
        "<prop:Win32CreationTime xmlns:prop=\"urn:schemas-microsoft-com:\">"
        
        Unfortunately WebDAVResponseParser::endElement() didn't do that when
        handling a PROPFIND reply to get the property names.
        
        This causes a crash when all properties are copied in
        UniversalContentBroker::globalTransfer(), which is called by
        SfxMedium::DoBackup_Impl() when the setting
        "/org.openoffice.Office.Common/Save/Document/CreateBackup"
        is in effect.
        
        Change-Id: I2d6480bfd2f828b6e7fc431ba4b333d95ec12718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133769
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [d47d8f3725ca38d46c6f2f37465f3856945de90e]

        Just use Any ctor instead of makeAny in javaunohelper
        
        Change-Id: I71031155920e64eaf128d106cb0d18e9e744d34c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133803
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [bf6b64d5963002d52c3ed2093b064896a4316d0e]

        use more string_view in unotools
        
        Change-Id: Id10d68f2eb016671be6842dfaa82909207b0708d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [8342e4a5c7bd436f869e6c1c23d248556087ebdf]

        Just use Any ctor instead of makeAny in package
        
        Change-Id: I527024f34b88ec764488a3766872f1941f8dbb4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133794
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [9c111cc4302bf344b4093693e64833d6bd870602]

        Just use Any ctor instead of makeAny in starmath
        
        Change-Id: I8264c2330837fbd46ea372a8e370bb43ca1fb7b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133775
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [b1ea5cc2ee0b50651c7cac4d85a49a199693ed1c]

        Related: tdf#131725 if SvTreeListBox RTL set, set scrollbars to match
        
        so if we have a RTL SvTreeListBox in a LTR environ then we get RTL
        scrollbars
        
        Change-Id: Ia9aaab81f273e31c61cfe4fd4e138709414ad599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133778
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Caolán McNamara  <caolanm@redhat.com>  [d18c19a916d7221da5d1ac19df4b2d99afbd0724]

        remove completed TODO
        
        Change-Id: I51c446c2e1e4b02df34200357b2d4ccafd69c7f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133777
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-04  Miklos Vajna  <vmiklos@collabora.com>  [40fad57d097d2e2856e8e4f76ca2d5d6bc689e2f]

        sw content controls: enable indicator on the RHS of the content control end
        
        To be consistent with the SwTextContentControl ctor, which calls
        SetDontExpand(false). This way typing expands the content control
        exactly when the indicator is visible.
        
        Change-Id: I44dc3e0a68643bc670b75da21110914e5c4f8f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133801
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [422bf47201c7a18f7f61a2e39eb384fe540d90c9]

        Just use Any ctor instead of makeAny in reportdesign
        
        Change-Id: If8b6f8f7facf36f740b2e1773e923e28d8c85552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133792
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [adf7d6efed63c3b92a473553039645a37253f3ac]

        Just use Any ctor instead of makeAny in oox
        
        Change-Id: Id6c8341b545c819521056926ef1b80d20d148c5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133795
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [ed58593fcbf1e72c8a2fd04e4c30691db22cdf6f]

        reset cached SalLayoutGlyphs when statusbar text changes
        
        A mistake from bfb6a42e26de28d88ced43eb3a2c63ce323d33aa.
        
        Change-Id: Iddf885d41177e6dbbfdc1c916b45843f4d7ba499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133796
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [2cb75eb504e3fedb9c93bbfee3609021f583f849]

        lay out entire strings in SalLayoutGlyphsCache more often (tdf#148911)
        
        The document has parts of paragraphs e.g. underlined, which changes
        the vcl::Font part of the hash key. So if a paragraph starts that way
        but the rest is not underlined, the optimization of laying out
        the entire string would be missed. So do the optimization if there
        are subsequent calls for adjacent parts of the string (or starting
        at the same index and different length).
        
        Change-Id: I3d4a78b0eae42bd3085e96024340e6ed8daa9ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133790
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [3d0d3ae9e08b701c0762a751a431ed2b1f5010c7]

        don't lay out entire strings for Writer layout tests
        
        The SalLayoutGlyphsCache optimization of laying out an entire string
        if it looks like a caller will call it repeatedly for parts of the string
        conflicts with the SAL_ABORT_ON_NON_APPLICATION_FONT_USE checks
        causing PrintFontManager::Substitute() abort if font fallback happens.
        Simply disable the optimization, the output should be the same.
        
        Change-Id: I0cce6a0c2a1a2ce93b95df54d18fedbdc779f34f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133789
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [51c986230316643e42a3deff7e802a8455fd0459]

        Just use Any ctor instead of makeAny in pyuno
        
        Change-Id: I53eb836c64e8e4a354c5c895bc7f16b168bd4cf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133793
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [e4f1a6ba19f14f39dc45fff20b2f15adf2db04ee]

        Just use Any ctor instead of makeAny in sccomp
        
        Change-Id: I4872a74604b97ba68a7db10c2980fc32605bc492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133787
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [ae8f735965678680835e2408494c2b226047f755]

        Just use Any ctor instead of makeAny in sax
        
        Change-Id: I3aec9eecc35eeabd2be61c73a57cff220843c9b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133791
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Miklos Vajna  <vmiklos@collabora.com>  [3f82c113dcddb75d91ab5ad439c735cf2ea36fb1]

        CppunitTest_sw_ooxmlexport11: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I104989efd62758f5da862b95a4d9bbcac536b46f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133773
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [b0f42b588f52268b8cfad527ba76fdbd125ea5ea]

        Just use Any ctor instead of makeAny in sdext
        
        Change-Id: I78f6972f0fe94423e00f2c3766df694d8e118439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133784
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [6d6b84db61eda9eb7d8d6a0b08c911af5927d38d]

        Just use Any ctor instead of makeAny in sot
        
        Change-Id: I43830efeb1671838317c5667f77c609a319a4aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133776
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [6cd4194e05233e8d1ddb59ffb9703778668b3f1b]

        Just use Any ctor instead of makeAny in sc
        
        Change-Id: I5c2363ff03ae02274f3c334cc262977c834950d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [5fc8f8620d0367813d20b9a90ece47f0674996b3]

        Just use Any ctor instead of makeAny in scripting
        
        Change-Id: I611640a6fb7061fbb6a239034f75e006db075989
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133786
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [aebfe0e9432e37936bbdd040fe8a0f099a0d22a5]

        Just use Any ctor instead of makeAny in sd
        
        Change-Id: I0cd03dcfef02b0ef3bce6bfb88aee4c04d7f6f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133785
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [75f008ff116f936e51f268c3fa6775de7addee7a]

        Just use Any ctor instead of makeAny in slideshow
        
        Change-Id: I9b006826fe4a859e07340c8e39d99fd89d4f31c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133781
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [0bfa6a180850898ec5038ad70e09a2ff7baafa1a]

        Just use Any ctor instead of makeAny in sfx2
        
        Change-Id: Ie707881d6f4cd4a2f92f4f5a89aa9e0b051db8a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133783
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Stephan Bergmann  <sbergman@redhat.com>  [b34f6f3b5ae6b889fbfd84719ee255282cb45e0e]

        Just use Any ctor instead of makeAny in shell
        
        Change-Id: I08f061d2d7feda582cd2495ac4b11d2ac0a6bbc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133782
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-04  Jim Raykowski  <raykowj@gmail.com>  [ca34204a39716ec9aa621e60ea50fb3c058c55f6]

        related tdf#148312 Don't search for hyperlinks in ToxContent to track
        
        Hyperlinks in ToxContent aren't included in the Navigator content
        tree Hyperlinks members list. This patch saves some cycles by not
        searching through the Hyperlinks members list when the hyperlink is
        in ToxContent.
        
        Change-Id: Icc332748f37dee02f0bc5f6fc0500fed51dd1182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133669
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-05-04  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [1e8db42c878b0e0608717cec8e012269856e5934]

        vcl : avoid recursive call if skia context creation failed.
        
        To avoid this bactrace : https://crashreport.libreoffice.org/stats/crash_details/4d1984f3-3352-49fa-8569-ebf6994ed216
        
        Change-Id: I45ae8b56191c546c551ccaf48d5ab27a20b8e0e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133662
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [bfb6a42e26de28d88ced43eb3a2c63ce323d33aa]

        tidy up SalLayoutGlyphs usage in StatusBar
        
        It's enough to store just SalLayoutGlyphs, not whole SalLayout.
        
        Change-Id: I31d0faccf08142326255c527b875ba8128f9bb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133764
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-04  Luboš Luňák  <l.lunak@collabora.com>  [22191901bc91535121a5e8dc7ee6137233824d36]

        do not allow reusing already used SalLayoutGlyphs (tdf#148477)
        
        If the glyphs have already been used, the AdjustLayout() call in
        OutputDevice::ImplLayout might have altered them, since
        MultiSalLayout::ImplAdjustMultiLayout() drops glyphs that need
        falllback from the base layout. And then then
        GenericSalLayout::LayoutText() would not know to call
        SetNeedFallback().
        
        Change-Id: I2f79d26c8b861f20d7d52abaa0d917aaeefb37a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133758
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-03  Heiko Tietze  <tietze.heiko@gmail.com>  [0ba1d661430effda61d8a6fadff9527dc9562698]

        Resolves tdf#148568 - Rework the Sparklines dialog
        
        * controls rearranged and variables renamed
        * radiobuttons changed into comboboxes
        
        Change-Id: Ifda426b5fa9596c2b23c335165785c0cb341433f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133636
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [eaf1f095ef96ceaf94f2fb1859324c11a35422c6]

        Just use Any ctor instead of makeAny in svl
        
        Change-Id: Iefa570476bf0c881e36679ae9511ff63162e05d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133771
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [a3f4f372aa4f6a693ae8abe829a539b9d3977de1]

        Just use Any ctor instead of makeAny in svtools
        
        Change-Id: Ib5a86de01abd6eab2f60d76bda50fa9407286dbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133770
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [234f87d354d3af8dfe842d8cf8c733679c3180fe]

        Just use Any ctor instead of makeAny in stoc
        
        Change-Id: I3345444f356dd3df9069773eba2bab1b46a08c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133772
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [1d2b6b709e81eec8600118b3402d82707aa113bc]

        Just use Any ctor instead of makeAny in svx
        
        Change-Id: I59b1b3f817a9028f132456ea5094f38f88674d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133768
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [ca734f7cfa55814a85d5940e5f64d7c53638f6a7]

        Just use Any ctor instead of makeAny in sw
        
        Change-Id: I2c9023ba8d07314d23ae7a65e670e8748c5e9322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133766
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Caolán McNamara  <caolanm@redhat.com>  [dc3b0983561f9166da9f3d48f8c64f9077193b0c]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I9ca24a135494a49449aec63615b2d945a93e8b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0533a8d18bb902f70fd4c6418f44875eab38999]

        simplify RegressionCurveCalculator::getFormattedString
        
        no need to format number as OString and then convert to OUString, just
        format it as OUString
        
        Change-Id: I2ad686c4d69302c545d483bcfe7a1a129ce38eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [605a34ccca64c86c89e4e8b6e4b049175a994d54]

        Just use Any ctor instead of makeAny in ucb
        
        Change-Id: I5e6964b5fa02d27d37ee772c761c72ed5b50492c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133755
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [c46d27cfe4dce83f68b3f222c9c1d26ad33d0b49]

        Just use Any ctor instead of makeAny in test
        
        Change-Id: I926cabc8be39344ec254e87b429f4d1bc8cfc94f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [82b9af26a64cd91173dbec43c1805bc069dd9f71]

        Just use Any ctor instead of makeAny in testtools
        
        Change-Id: Ib895b2269805656a23a93c7e794e097a712bd401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133762
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [54725f6e5f06b074d1c08d8efbd16518b96882d5]

        Don't add empty labels to fontwork's icon view
        
        This allows to center the icon in the respective entry,
        not having whitespace in the bottom
        
        Change-Id: Ib148df6911f020f8d4efca4f6a80a65b7f95945f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133720
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-03  flywire  <flywire0@gmail.com>  [02b1be97df3646d3db9db52295129c787c6a84e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69073be69350efd4f9d4fffe9a05110fea8b0b5a
          - Cleanup ScriptForge examples
            
            Done these cleanups on ScriptForge examples:
            
            * Consistent ScriptForge examples variable names
            * Fix wrong link
            * Add missing text
            * Remove extra text
            
            Change-Id: I49f7e70268c9a9c576e6fb479559bc5c222f86ca
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131868
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [19e4ab8754240e019deae26b861745b91f4044e6]

        loplugin:stringviewparam
        
        Change-Id: I32ded64d7e9a86a6226dfbc4a3b9262bc7572ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133761
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [ab387593b9a9f5b23df55c12679118dddc8e181a]

        Use o3tl::make_unsigned in some places
        
        ...where a signed and an unsigned value are compared, and the signed value has
        just been proven to be non-negative here
        
        Change-Id: I1a9832b5b8b5304fa011a3ed57996a8e3751388b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Regina Henschel  <rb.henschel@t-online.de>  [8ad4fdb1687e705e31d9a4f30b385d50b91def08]

        tdf#148714 Repair path in older CurvedArrow shapes
        
        The CurvedArrow shapes had an error in their enhanced-path. The error
        was fixed in the geometry definition with commit 4cfe4699. But the
        wrong path was written to file markup. This patch repairs the path in
        shapes in documents written before the fix of the geometry definition.
        
        Change-Id: I6d7bc3b4ec4a61f16ce5dea3d352575525850b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133740
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [6f94aa6f1a5990363b92689546241bc447096294]

        Drop unused .uno:EditChart
        
        This reverts commit fb5e0581f922dba93f3689786201ee067cb01a73
          Author Muhammet Kara <muhammet.kara@collabora.com>
          Date   Fri Nov 22 13:16:25 2019 +0300
            Add command .uno:EditChart
        
        Obviously this command has never been used. It was named "EditChart",
        but in fact it executes the default verb for any selected object, so
        could be named like "edit object".
        
        Since it's unused, let's just drop it instead of renaming.
        
        Change-Id: I20aa8a17c54a0bf0030c3187340690846bfbc729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133473
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [87d368642c536880bd313a5993c30bfb9c250e9d]

        Just use Any ctor instead of makeAny in toolkit
        
        Change-Id: I55115f115e98b00e199007da5c6d9ea44cf2bab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133756
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [8bf380f7d33f39eaa4cb96b38a82ac18e589deef]

        add o3tl::matchIgnoreAsciiCase
        
        Change-Id: Iad8e1ed256d84808404bf20ed7a16b05b3db5818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [a56474374b7a5aeacf41419fc1a6c99007cd7483]

        Just use Any ctor instead of makeAny in unoxml
        
        Change-Id: Iae66ed959d1b5734151ba42d272171254293501a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133749
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [4ad4c963747729c0b980ef49228f468177dc2cca]

        Just use Any ctor instead of makeAny in ucbhelper
        
        Change-Id: I54169b62d93018d06655c92c0ba99fdee499a8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133751
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [54d6e9f7dcea00761a47121994dd9121f54e1798]

        Just use Any ctor instead of makeAny in unotools
        
        Change-Id: I58d2020035396da0b3580b058d87c8e2d3f2df40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133750
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Caolán McNamara  <caolanm@redhat.com>  [8cc937d73ccb1108c7b9c869aa6ae40d630fbdac]

        ofz#47200 Abrt
        
        Change-Id: I8975120de36575e1af5297db4f40ba3a39398bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d0cacf09a1105d89bf3df84b18623d790e3aeb82]

        tdf#99708 Save formula bar height to document
        
        Save the current state of the Calc formula bar to the document.
        Number of visible lines is saved into the document settings
        and restored when loading that document.
        
        Also adds a UNO property, so that the formula bar height can be
        changed via UNO.
        
        Change-Id: Ifef0c9e42cb4f7465516629d2c22974367e0eb33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133499
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-05-03  Michael Stahl  <michael.stahl@allotropia.de>  [5801b887629dbd784116ec6878b61bb99e991647]

        tdf#148426 ucb: webdav-curl: fall-back to GET if OPTIONS status 500
        
        With the ndr.de server, OPTIONS on an image URL results in a status 500
        Internal Server Error and an unexpected closed connection:
        
        16.591:info:ucb.ucp.webdav.curl:1634132:1634170:ucb/source/ucp/webdav-curl/CurlSession.cxx:285: debug log: 0x7f9c94004988: transfer closed with 222 bytes remaining to read
        
        Apparently Neon always reported the closed connection problem with a
        string:
        "Could not read response body: connection was closed by server"
        
        The HTTP status code is extracted in makeStatusCode() and the string
        doesn't contain it, so the status is reported as 0 up the stack.
        
        With curl, it can apparently happen that either CURLE_PARTIAL_FILE is
        returned, in which case the status is ignored and reported as 0,
        or CURLE_OK is returned and the status 500 is reported up the stack.
        
        Adapt the handling in Content::open() to fall back to GET in case of a
        500 status.
        
        Change-Id: I5f3dce7f67ce25c87bf3882c89e7ff2d386bcbad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133707
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-05-03  Miklos Vajna  <vmiklos@collabora.com>  [0a415b92d3c1ea2c5befd30b4ac29442f422a41d]

        sw content controls, drop-down: add doc model & UNO API
        
        Add a new property, which is a list of display-text / value pairs. If
        the list is non-empty, that implies that the type is a dropdown.
        
        This should be enough for the UI to be able to provide a list of choices
        & update dropdown state on click.
        
        Note that in contrast to dropdown field-marks, here each entry has a
        user-readable string and a machine-readable value. Fieldmarks only had a
        single value.
        
        Change-Id: I22b9f554e2e1a9e84cc7eb7e17772ea1a5775316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133742
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-03  Miklos Vajna  <vmiklos@collabora.com>  [27588f9728eb9c6be19fcf69fd1c3a56285b4c1d]

        sw: document SwTOXMgr
        
        Unlike most other managers, this is now owned by SwDoc: this can be
        created on the stack when there is a need for it. Then it can do its
        work and safe to delete when no longer needed.
        
        Change-Id: Ief2e8c1172602edada36d330a652f8fe51fc8be2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133710
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [2ec4aa9f24d618bae5be84b804bf4a51faea4e32]

        Keep passing LDFLAGS into external proejct builds
        
        ...which had been broken with 1ffd6897ddf15624e70585ab08e8af713114c938 "try to
        use also proper debug LDFLAGS for externals libraries", and e.g. one of my macOS
        builds uses a non-standard Clang compiler and libc++ library, and thus needs
        
          LDFLAGS=-L/Users/stephan/llvm/inst/lib
        
        in autogen.input
        
        Change-Id: Iae67a4a13603b0241e5cd6c0d01a07ac898ffb58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133746
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [46972be699730f4dc381a19b5d50a02eae407a71]

        Just use Any ctor instead of makeAny in vbahelper
        
        Change-Id: Ie985584ad55f69817294e45b11b7c832d39c9bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133737
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [4d55513852d41ed72e945597b1f8749c14562012]

        Just use Any ctor instead of makeAny in xmloff
        
        Change-Id: Ibefb18e5b798ccf1f9d7a5ba1524c9fb1e9bee32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133700
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [cbc34f69ec6363cd234ad2b1dfe09bfb531238db]

        Rename #define HAVE_LIBCXX -> HAVE_LIBCPP
        
        ...to harmonize it with the HAVE_LIBCPP configuration variable recently
        introduced in 6014f363a08f2edd6086cf30b3bbb913f1c621c6 "improve support for
        using libc++ on Linux and for libc++ debug mode"
        
        Change-Id: I6b3fee2e4e564d75caf1e60095d0b554153bce9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133745
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [1c12e5fe5a458f4a4d4dd8080c2ade2f20ef17dc]

        Just use Any ctor instead of makeAny in xmlsecurity
        
        Change-Id: Ic2e9189d116b03122d24a477d9396ca3d49a0a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133698
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [669fe2f229df17a569ee8f87b654a26b1b770e8d]

        Use o3tl::make_unsigned in some places
        
        ...where a signed and an unsigned value are compared, and the signed value has
        just been proven to be non-negative here
        
        Change-Id: I297d0f80b2b3e68ea7362de64c871d647ac07371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [6624124df227e5a8ba14595848008d0b2d901255]

        Why cast from FontWeight to int
        
        Change-Id: I2e283197024c89681dc123e77c05d593ccec4552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133738
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [3e4996f4276ec252a9cc5eab7898aba75103aca7]

        Adapt Base64::decodeSomeChars to change from OUString to std::u16string_view
        
        ...in 9c95415de877af1430ab5b7123e11dedd0ea622c "Let comphelper::Base64::decode*
        take std::u16string_view"
        
        Change-Id: I42b1552fba80568b422cb60ccc99a7ab8664f2d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133711
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [103a6bab82cde1035b4e9d2bd12fabac101b95a7]

        Just use Any ctor instead of makeAny in winaccessibility
        
        Change-Id: I402a77499daaa1a08beca8165199f266733aa1d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133712
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Caolán McNamara  <caolanm@redhat.com>  [86a006d8266850a9fda1e5d94d2f6cb821a0724e]

        ofz#24932 Timeout
        
        Change-Id: I1055c5b7db23693817221fe213ab96c9f29a11f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-03  Caolán McNamara  <caolanm@redhat.com>  [4e1cf8411197b4c11a6c5d4728e047e6d46567b5]

        ofz#47198 Use-of-uninitialized-value
        
        seen in ww8 filter with rName of length 0 in if (rName.startsWithIgnoreAsciiCase("Tms Rmn")
        
        Change-Id: Ia8a20971161a44d62ead9bfcef59f86b007fd58b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133713
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [ddef1e2c017b7d8e421dedc1a0ce722ff4208985]

        add o3tl::equalsAscii
        
        Change-Id: I042b8dcadbf7581de325c161763fe35aecde5ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-03  Luboš Luňák  <l.lunak@collabora.com>  [0a6d946694e4fcb39228c5e1fec58fcfd8a45989]

        optimize repeated calls for the same string in SalLayoutGlyphsCache
        
        It often happens that the entire text will be laid out in parts,
        so if the first call is a prefix and another one follows that,
        lay out the entire string and then use the glyph subset optimization.
        Doing this only for the second segment instead immediately for
        the prefix is more efficient, as sometimes there is only the prefix
        call and there's no call for the rest of the string. This also
        avoids failures in CppunitTest_sw_layoutwriter, as a number of tests
        such as testAbi11870 lay out only a prefix and doing a layout
        for the entire string leads to font fallback, on which
        CppunitTest_sw_layoutwriter aborts in PrintFontManager::Substitute().
        
        Change-Id: I76554868ec7e8a79dd09709a247ad1d839291c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133495
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [6ba14f83add039d0df133febfcf7199c99f8d936]

        Revert "enable test for all platforms"
        
        This reverts commit b294a94861289c322a26edb6b83f0d329575639d, which keeps
        failing frequently for Gerrit Jenkins Windows builds now, e.g.,
        <https://ci.libreoffice.org/job/gerrit_windows/125864/>
        
          C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows@2/sw/qa/extras/layout/layout2.cxx:1950:testTdf124261::TestBody
          equality assertion failed
          - Expected: 1721
          - Actual  : 3472
        
        Change-Id: I681274df98f2246312539ba5d0dfcde7e7ba4826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133718
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Stephan Bergmann  <sbergman@redhat.com>  [c8053f5a5629c04defd813b061f0d59d6bf15f88]

        Just use Any ctor instead of makeAny in vcl
        
        Change-Id: Ib9b588cd10154049a5493c1be16de72955ea6077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133736
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-03  Luboš Luňák  <l.lunak@collabora.com>  [0cc8da4c091ac5784c0b4c2c7850ca8dabffea04]

        remove the o3tl::lru_map "unlimited" hack
        
        It didn't quite make sense before that maxsize == 0 meant no cleanup,
        and now with items optionally being count as having size more than 1
        it makes even less sense to limit the size to max_size() of the
        containers. This comes from 16a338e173083954a9932a3a4005f17230,
        so instead make that special caller pass a large size, which in
        practice is the same.
        
        Change-Id: Id875862126200ba889211f6e4079ae5921f27650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133690
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-03  Luboš Luňák  <l.lunak@collabora.com>  [1661a3ee77d78807f287146f8190d02d89963fe2]

        use proper MSVC runtime lib for libwebp
        
        Change-Id: Icf976bb4a4593bfa8e8fc506d4c5e86cb7f88671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133705
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-03  Seth Chaiklin  <sdc.blanco@youmail.dk>  [69f412459257398a7d779541dad95aa7227a5e74]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 42ded671522a4e62659b561b0c8ea67fef5b9cea
          - tdf#148485 add missing options for Vertical positioning
            
              This patch started with the simple intent to add some
              missing options to the "To" control in the Position section
              of the the Position and Size dialog. However, problems were
              discovered with the names of some of the options to be added,
              as well as some of the existing options. This lead to
              tdf#148591 and tdf#148519, which changed the labels for the
              missing options mentioned in the OP for tdf#148485. Thanks to
              Regina Henschel for essential help in understanding the regions
              to which the labels are supposed to refer.
            
              Using the new option labels, this patch adds
              "Above page text area", "Below page text area" as "to" options
              in the Vertical position section of the Position and Size dialog,
              and "Frame text area" and "Entire frame" in both the Position
              and Size dialog for Shape and the Type dialog for Image.
            
              Because Above/Below text page area is not found in the Image dialog
              for Writer, needed to add an additional section to
              swriter/01/05060100.xhp (Image/Frame - Type tab), so that it is
              possible to add the missing options (Above page text area,
              Below page text area) to Position and Size help for Writer
              (shared/01/05230100.xhp), but not have them be part of a section
              that will be embedded in swriter/01/05060100.xhp (for Image/Frame -
              Type tab).
            
              swriter/01/05060100.xhp
                * Corrected description of "to" control
                + Added "Available only..." for "Line of text"
                * refactored to <note>
                o All embedded to shared/01/05230100.xhp for Writer (Image - Type).
            
            Change-Id: I9fffec30dd994d15aa9a7c9ef70dec01d63ed98f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132709
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-05-02  László Németh  <nemeth@numbertext.org>  [978e22f8cfb3db573bed3fd4b14a515cf090f7e5]

        tdf#146573 sw: recalculate cells with footnotes
        
        Commit 915d3eebc1dc4f18d7a1992db801ee8313ee46c0
        "tdf#39828 sw: fix table formula calculation at track changes"
        allowed to use footnotes in value cells unintentionally.
        The only problem was that modifying cells with footnotes didn't
        trigger formula recalculation in text tables, according to the
        incomplete SwTableBox::IsValidNumTextNd(). Instead of
        asking formula recalculation pressing F9, now IsValidNumTextNd
        was extended to skip footnotes, similar to the already
        skipped comments.
        
        Also clean-up to testTdf39828 (remove copy-paste code), and
        clean-up to commit 915d3eebc1dc4f18d7a1992db801ee8313ee46c0
        "tdf#39828 sw: fix table formula calculation at track changes"
        to avoid of unnecessary calls of GetRedlineText(), which
        is an expensive call, especially when there are a lot of redlines
        with overlapping (see commit d467cd0dd9e9cf3b018859a592e2638527bc7add
        "tdf#135683 speedup DocumentRedlineManager::GetRedlinePos").
        
        Change-Id: I00243ef0985805414723e26fe26d6e9c04ce86cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133579
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [64106353c98e8cb0c99c9e4ff509348edf8ed911]

        Just use Any ctor instead of makeAny in writerperfect
        
        (which needs one more false loplugin:redundantfcast suppression case)
        
        Change-Id: Ib8a72a510384f497bddaef5b812a46ea473481d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133703
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [92fc91bbb865af2888a0717cdaef5e2af5b4b719]

        Just use Any ctor instead of makeAny in writerfilter
        
        Change-Id: I3db5381c5dc72f0498171d9e61479ae6763312bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133708
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Miklos Vajna  <vmiklos@collabora.com>  [3f768cddd28a2f04eb1ffa30bed4474deb6fbfc4]

        framework: avoid re-creating protocol handler instances all the time
        
        Once you install an extension that adds its own protocol handlers (e.g.
        <https://github.com/niocs/ProtocolHandlerExtension>), DispatchProvider
        re-creates this protocol handler every time the custom menu gets opened
        or a command gets dispatched.
        
        This allows the dispatch provider to avoid managing the lifecycle of
        those protocol handler instances, but in case the constructor of those
        handlers is expensive, this leads to performance problems.
        
        Introduce a map of handler instances in DispatchProvider to avoid
        unnecessary re-creation and re-initialization: these instances get the
        same XFrame anyway (the DispatchProvider is owned by the frame), so this
        is meant to be safe.
        
        No testcase for this -- the problem is only visible if you have an UNO
        service registered in the global UNO service registry, but by the time
        our cppunit tests run, that is already a fixed list, so this would be
        hard to test from code.
        
        Change-Id: I6d69906a795a2d5a67706002d635b6cb3091b856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133706
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f8d35a20be7c3dc6eff5e79965b631e004d24a54]

        Remove duplicated includes
        
        Change-Id: I22e66f3cb370c53e1c5ca1e5fa6760d152def374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133696
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [75fe4051320ef9b1f4323fa958e8df3db2066882]

        Just use Any ctor instead of makeAny in xmlhelp
        
        Change-Id: I1e8d144e8a011868bdd0083bccd90ee80eabbe66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133701
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [7ae3fbe10811443050068627d0fdde66c551cd13]

        Silence -Werror=maybe-uninitialized
        
        > vcl/source/helper/strhelper.cxx: In function ‘rtl::OString psp::WhitespaceToSpace(std::string_view)’:
        > vcl/source/helper/strhelper.cxx:365:9: error: ‘pBuffer[-1]’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   365 |     if( *pLeap == ' ' )
        >       |         ^~~~~~
        
        that hits at least with GCC 13 trunk now (and which actually is a false positive
        as far as I can tell)
        
        Change-Id: I69b96e4cf68f0ed20ac7d73014c164db792983a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133704
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [2256912336fbcf0b985d84dfbf355d1728ee425c]

        Pick a better variable type
        
        Change-Id: I2a24201d0e9cb230aefbb92dadf30907b0d1dccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133677
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [fae937b6859517bd9fe8e400cad3c84561ff98ab]

        sw: avoid one more EXCEPTION_INT_DIVIDE_BY_ZERO
        
        Seen in
        https://crashreport.libreoffice.org/stats/signature/SwTextFrame::PaintExtraData(SwRect%20const%20&)
        
        Change-Id: Ie6924254dca73360d384987834460a6f813e0d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-02  xuenhua  <xuenhua2008@sina.com>  [7fd1b0aa2ba741103a7d9ac835514ebbeae3bcff]

        Delete mnemonics for CJK translations on macOS
        
        'Cop~y' translated into Chinese is '复制(~Y)'
        But the mnemonics '(Y)' is useless on macOS.
        In English, 'Cop~y' with the '~' removed is the correct result.
        But in CJK should remove along with '(' and ')',
        not just only for mbMenuBar. Use the method MnemonicGenerator::EraseAllMnemonicChars
        already defined in vcl/mnemonic.hxx
        
        Change-Id: Ic37ce566923e3dea47535d187b1b3dba2088e960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1139013b129fb7f3c58583cdef86b3cdae469f20]

        Fix typo
        
        Change-Id: I63a6ac96679cabe12263a97c3dfdbbd035983b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133697
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-05-02  Mike Kaganski  <mike.kaganski@collabora.com>  [21a0e9ae540f1f0244ddfcb0389deb47567b2f3a]

        Reimplement IconView::PaintEntry
        
        Use spacing between top, bottom, icon and text (the case of sum
        of items heights greater than element height is not yet handled).
        
        Draw the background even when there's no text: that allows to
        center the icon in the item, and still have proper highlight of
        selected item.
        
        Change-Id: I5d5dd14060efd15beb0e69df859ecf1efe8a0287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133612
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-05-02  Caolán McNamara  <caolanm@redhat.com>  [00e43c14558fa4d0369820fa3d2cd7b987e61377]

        Related: tdf#148433 experiment with CAIRO_OPERATOR_EXCLUSION
        
        export SAL_DISABLE_CAIRO_DIFFERENCE=1 to experiment with this
        
        Change-Id: If0e5fee8c71ae3d2181b1e0b90bf9ecd6536ffc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133671
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [8e08e6c0ce6a7e5190cd9db7dc76e9774e9bb5a8]

        loplugin:stringview
        
        Change-Id: I266dc947f9590f869ca7245d776263c692f02be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133688
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [0c34f61772a3d4b3169af869149bed5e4850eb14]

        Just use Any ctor instead of makeAny in xmlscript
        
        Change-Id: I6dbf6acdf051fefe73c82b7739105a73d3aabede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133699
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f13b8908d280a25e8a8753070862a2dda32dbf85]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 834789bd8d25cfee57662c8023a34f8e80cc078d
          - Update Basic function Shell page
            
            Change-Id: I64ed0d7ce000f6a0ca49d60fa0f4ed80690ac03c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133659
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-05-02  Luboš Luňák  <l.lunak@collabora.com>  [8ff55ff8c9779fd308cc50587d2f283d15518192]

        better for fix glyph font fallback with null character
        
        Text layout code already filters out unsuitable characters,
        the null character just wasn't included there because it's normally
        not expected to be present in text, only something broken like
        ofz34898-1.doc causes it.
        
        This basically reverts commit 3d7ca1bd1c4cc9d468ae214ecb497f71bad340f8.
        
        Change-Id: Ic29674d9507340c2a43098a88c0320d4253a0bf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133689
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-02  Luboš Luňák  <l.lunak@collabora.com>  [4bb730be0909d9cf55b7a44d7e916aa5de16b9f7]

        better cache size limit for vcl::text::TextLayoutCache
        
        This is not as important as SalLayoutGlyphsCache, as these should
        be smaller and less needed, but still, make sure to limit the memory
        the cache may use.
        
        Change-Id: I4051331f8c5254cb5723772bac4dd1bceb9a2a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133674
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-02  Luboš Luňák  <l.lunak@collabora.com>  [8e6ab6502278702499e7468404d1010069176578]

        better cache size limit for SalLayoutGlyphsCache
        
        With just limit on the number of cached SalLayoutGlyphs instances
        the actual memory used could vary wildly depending on how long
        the text is.
        
        Change-Id: Ibcf6918e562e81276d21876c532838996e275bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133673
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [bc7ea0a75911a782c0008be64508cbf3e0d74cc3]

        loplugin:stringviewparam
        
        Change-Id: Ife277f789270f80a40cd711a9235e41bbb3384ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133686
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [5d4ba848a378063ff7965a5871602525ac482703]

        loplugin:stringviewparam
        
        Change-Id: I30fddefcc0dc95f98a34ca45bd667f0900ec2044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133687
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Miklos Vajna  <vmiklos@collabora.com>  [02a5bd2e6c4eee50cbd8cb4ed009731c409711a5]

        sw content controls, checkbox: add insert UI
        
        - extend SwWrtShell::InsertContentControl() to be able to create
          multiple content control types
        
        - a new checkbox content control's content is always a non-checked
          checkbox
        
        - expose this as a new .uno:InsertCheckboxContentControl uno command
        
        - add this new command to the bottom of the form menu -- now that we
          have two types of content controls, have that in a sub-menu
        
        Change-Id: I058659600b3face69b89262feb0979fff32521c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133685
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-02  Caolán McNamara  <caolanm@redhat.com>  [b294a94861289c322a26edb6b83f0d329575639d]

        enable test for all platforms
        
        Change-Id: I9af29ee1601093a2cce342e6bb8f4274f946a444
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-02  Caolán McNamara  <caolanm@redhat.com>  [d0d780a05e03414e59a40e5c950bd2487a55e714]

        move layout-dependent test to explicit layout cppunit target
        
        Change-Id: If1d4c6047df5a69b5cf8f9e9a970c1ecad754ce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133670
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-02  Heiko Tietze  <tietze.heiko@gmail.com>  [ee1705a95bdfffbe0e36d449378be726733d7141]

        Use colors from standard palette for sparklines
        
        Change-Id: I95cfb74efd5e28e048c8057a464a57c88aab7e7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133634
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [40edf4e6ae3e0bedd978fcaacc9d731094000ecb]

        Add css::uno::Any(Color) specialization
        
        ...like was already present for css::uno::makeAny, in preparation of getting rid
        of makeAny
        
        Change-Id: I293e240e38fb9ad7e9e386a46da7b69beda7103b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133680
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-02  Miklos Vajna  <vmiklos@collabora.com>  [55c3860f98fc198bdbf21e2acbb37c5541bb7e6a]

        sw: prefix members of WW8_WrPlcPn, WW8_WrPlcSepx, WW8_WrPlcSubDoc and ...
        
        ... WW8_WrPlcTextBoxes
        
        See tdf#94879 for motivation.
        
        Change-Id: Id2cae0dcb328ff319607a29489231a54ad26c132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133682
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-05-02  Luboš Luňák  <l.lunak@collabora.com>  [46097559ed1ca17c08fd77943e088451d633adfe]

        support custom item size (cost) for o3tl::lru_map
        
        When used with items that may vary significantly in size (such
        as SalLayoutGlyphsCache storing glyphs for texts of different sizes)
        limiting lru_map to just the number of items performs poorly,
        since it may use only small amount of memory if items are small
        or it may spent a huge amount of memory if items are large.
        
        As extra optional template argument to o3tl::lru_map that is a functor
        that provides cost of item each, and the total size is based on this
        instead of each item having cost 1.
        
        Change-Id: I2b326754fe63eb4bd20010d4cea615187407e26c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-05-02  Stephan Bergmann  <sbergman@redhat.com>  [36783678bb93210284adede7f9c48332aa8d8b15]

        Add css::uno::Any(OUStringNumber) overload
        
        ...like was already present for css::uno::makeAny, in preparation of getting rid
        of makeAny
        
        Change-Id: Ic838a8297ec65dae75da6a1deb5933d562070753
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133679
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-05-01  Szymon Kłos  <szymon.klos@collabora.com>  [22887ce7b1ea890e06f4b64bafc97686f30ec129]

        lok: reset ui mode state when switch to notebookbar cancelled
        
        We have to keep state in the register in sync with the view.
        When we cancelled notebookbar usage we need to revert Default state
        so next time we will be able to activate notebookbar.
        
        Change-Id: Ie5f7d0160c9c22c6621aca73b2cdd7197f86ff78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133325
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133654
        Tested-by: Jenkins

2022-05-01  Szymon Kłos  <szymon.klos@collabora.com>  [db2e2e555b26c92af38be13f68d494423fc236e3]

        jsdialog: export symbol for buttons
        
        Change-Id: I412961bd59855dcb4204dfb917b30539dac0eac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132756
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133653
        Tested-by: Jenkins

2022-05-01  Szymon Kłos  <szymon.klos@collabora.com>  [7df8334b0078b4e8f8fbf5c55d9fdc54398b57b7]

        jsdialog: handle formulabar as textinput
        
        mostly boilerplate code
        
        jsdialog changes:
        - added force parameter to sendAction
        - added support for key press/release and command events
        - moved ActionDataMap to jsdialog namespace for sharing
        
        formulabar changes:
        - added calls to send jsdialog messages with formula
        - added cursor moving support - on command event
        
        Change-Id: I714715133901941ba0758655e2d5907a3bae79f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133010
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133652
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-05-01  Szymon Kłos  <szymon.klos@collabora.com>  [3dd8b19b814e959d00235df8bc08f9892f45dd87]

        lok: Introduce uno commands for formulabar actions
        
        thanks to that we can reach them using LOK as formulabar
        is not fully welded yet
        
        Change-Id: Icc1963ab11c1e6e3c407222d76b2a87fdaffa652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133496
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133655
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [bd1f61dff608fedf83ef559cd310d546d057d9d7]

        abort more writer layout tests if a font isn't found
        
        Change-Id: I4d94b60531505f2d5a493b4c51f4c9110d3a4517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [172270a8f04388a8f8062f672f9c3f3144a01a1f]

        abort writer layout tests if a font isn't found
        
        if (the default) of --with-fonts is enabled then additionally restrict
        fontconfig to those "application" fonts so the linux ci can be used to
        safeguard that font and glyph fallback isn't in operation during the
        layout tests
        
        Change-Id: Ic7fc705827c8177b8367cf41f55cdd8ae002c1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [cd9602dcc51a7ce54fadf9796642ee9d7fcf3cfe]

        ofz#47162 Integer-overflow
        
        Change-Id: I4d910a1844100415f95c89bda83843ddffdc3df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133663
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [ce17ecbfa6f578debcf8aec9d6c29836adb49c6f]

        ofz#47111 Timeout
        
        Change-Id: Ic50978f5189ea2079d8cc2b5d0803ef4baf4ea4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  xuenhua  <xuenhua2008@sina.com>  [38a1c6b760d9664e0ecbce23b3d869fb77e7fc35]

        Fix comments
        
        Latin a-z instead of Latin A-Z
        
        Change-Id: If638cdbe12a1c66cb27b982508867a5a34681b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133589
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [520d8c9ec7718cf6678614ecf18656dafcad9445]

        tdf#74331: 16bit "min-is-black" tiff not loaded correctly
        
        try an alternative fix
        
        git show -w is your friend here
        
        Change-Id: Ie9644f73431243ea0e9c6ef7f5c7ca4dadc7ed9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [d61e4b989574b16199773042808773a2d67acdb2]

        don't use an empty fontname, reuse the default from the virtual dev
        
        zero size font is odd, but that's as it was already
        
        Change-Id: Ib430f2ff2a53c21dc7d15d11377762ab336a61e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Caolán McNamara  <caolanm@redhat.com>  [b4dbdbdc9755dbbb586039eb48b935e7dbcc4cbb]

        ofz#47118 Timeout
        
        Change-Id: I5cf7f07c00faebb8005b150c9638dfbb742d156f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-05-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [96ce28f5eb7139f66ba35e74e997c3a686aeca39]

        Align macro menu in start center with other places
        
        Esp. "Edit Macros" was missing here - it's available in the other apps.
        
        Change-Id: I807e9c35da42729d3c3838266736fdfa5be23fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133434
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-05-01  Luboš Luňák  <l.lunak@collabora.com>  [6014f363a08f2edd6086cf30b3bbb913f1c621c6]

        improve support for using libc++ on Linux and for libc++ debug mode
        
        It seems to run slightly faster in --enable-dbgutil mode and also
        builds a bit faster (at least with Clang). But libc++ on Mac
        isn't built with debug mode support.
        
        Change-Id: Idf5dba9c4a56aba1f4163aa518a78d34b6837149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133664
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [5200a73627d13e2997f81b53f61e143e77e328ee]

        use more string_view in various
        
        found by examining uses of OUString::copy() for likely places
        
        Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [b90d3d316dd9c720c83180b31f6bbd7003fead78]

        use string_view in WhitespaceToSpace
        
        Change-Id: I64c63418ca51a09312083dab2432bcca0ea262a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-05-01  Luboš Luňák  <l.lunak@collabora.com>  [1ffd6897ddf15624e70585ab08e8af713114c938]

        try to use also proper debug LDFLAGS for externals libraries
        
        This is basically ea68de2968c0dbcd8e7549435e829db06795c16d but
        for LDFLAGS. A number of external libs cannot use this because
        their libtool mishandles -fuse-ld.
        
        Change-Id: Idee379eb0a3afb475b536519ee3de064b4e218f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133639
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-05-01  Luboš Luňák  <l.lunak@collabora.com>  [339fbb7bc30f227b9d4c9b9eea03b25f49533dee]

        SalLayoutGlyphsCache no longer needs to hash OutputDevice pointer
        
        It seems now the cache key contains all the necessary info and
        results can be shared even between different OutputDevice instances,
        as long as they are "the same".
        
        Change-Id: I367322f469ab6713299f178a711a63065b245f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132902
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [2c19246a4090df14e8f97c35c7770b25c1974232]

        tdf#148519 change positioning option "Margin" -> "Entire frame"
        
          A label for Vertical positioning, when an object is anchored 
          "to frame" was mislabeled as "Margin" (for Shape). Change
          it to "Entire frame", which is also used for positioning
          Images. 
          
        Change-Id: Ia001c22b5bdf2c74611948d23afa9566aab4078c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133290
        Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbff7af0a1a31e82c3a3eb6dac77d5a48ef3371d]

        split comphelper::string::strip functions into String and view version
        
        which is more obvious, from the perspective of the caller, and lets us
        avoid creating a new String if nothing needs to be stripped
        
        Change-Id: I66a980eaf4aa818251bec49bdb16c2dddb0745e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [40077fe30919494f0ecd04c4620cac2334d3d382]

        new loplugin:stringviewdangle
        
        to find places where string_view is pointing into a temporary String
        
        Change-Id: Ib530b36f441e95d83d8f687d40a97516a0806721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0a7c9153b0100db4d216b598969642e10aa52c2e]

        Fix typo
        
        Change-Id: If93c80f5c4c9d68aeeaf3c0b16d9ef234bcc6737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133553
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [a1cf6be07cf2fe3afcd053ae622f85b3e95ce833]

        Tw Cen MT Condensed->DejaVu Sans for repeatable layout test
        
        Change-Id: Ibf51eeab079383b769a73ac55d6bcd22dd34d95c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133632
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [fbb15d36b1a493a2665b01e9c35045970a7bd772]

        Georgia->DejaVu Sans for repeatable layout test
        
        Change-Id: I9d2c8023a8379178f85a8cad04ee47f7cd56e226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133631
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [df68d2dff8bfc9a055e5576edbb77f3dfe680c23]

        Century Gothic->DejaVu Sans for repeatable layout test
        
        Change-Id: Ic1241247bc877a00aeaf18aa938bd8f7517c54da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [acbad3afc8ea0c994ae063324affe2b7ae683a6d]

        sans-serif->DejaVu Sans for repeatable layout test
        
        Change-Id: Icfd4fe6a728704276c720eed36361cdcf1b1c48b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133629
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [c8e17398a0179eaac058a50e176e2639eeb8694d]

        Times->Liberation Serif for repeatable layout test
        
        Change-Id: Iafe43e341463169a81fee0988c63b0a253374601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133628
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [59e6f68850b6688d775e6d11d154ae4d8b65a5ee]

        Algerian->DejaVu Sans for repeatable layout test
        
        Change-Id: I2efe14b4f96eaebed4e70db51c9140755d808b0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133626
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [a5ec011963a893f4e14fe3334e24d57829222a73]

        Chinese Traditional defaults needed for CppunitTest_sw_layoutwriter2
        
        Change-Id: Ia11843d7e99e969a2d965de0355e0f9c81709c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133625
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [84ad4fe061ebfbbcdc0ffeec329e117250627157]

        tdf#148432 in LTR UI override the navigator treeview direction for RTL doc
        
        based on the first page directionality
        
        Change-Id: Ifa1a67dd0db53afb125bcea29df83e776f9e65d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Caolán McNamara  <caolanm@redhat.com>  [1f81dd9b05c4eaa3e4caae8fe38ef2ee7eb1db49]

        ofz#47104 Revert "tdf#74331: 16bit "min-is-black" tiff not loaded correctly"
        
        This reverts commit bd1d0967920655ef85a2352259332f99fef6876e.
        
        Change-Id: I4f4c0aa7d779487b9f3b1da46e7b2e1070f2dba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-30  Szymon Kłos  <szymon.klos@collabora.com>  [cdf2a60de28d7f36b5404451474cadb65db40a11]

        jsdialog: used for formulabar
        
        - do not block painting
        - use welded wrappers to send JSON
        - don't send tunneled dialog
        
        Change-Id: I54c3cd02ab63bad4a50a3623a32f13b0c94a3595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132757
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133651
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [460951403745c2d08094f707e884ee99ab5b9364]

        tdf#148782  Left/Right frame border -> Left/Right of frame text area
        
            Label was incorrect in Position dialog. Replaced with more
            accurate version.
        
        Change-Id: I5041e047ba52aa5df8628a3ca3491a39cdf27622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133594
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [cc7732fb4bbe8ffd6820c4db559d326c043bfb67]

        tdf#148718 Partial revert of commit 6fbc3de17cd9274dc3a09e1eeb914c45f7dfe140
        
           Put the "Heading" and "Heading 1.x" labels back
        
        Change-Id: I953622554c63c828f6c8353c8f3a0f5aafc61144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133488
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [c50afd45d2f6a7c70bb3a7591747b162a2675311]

        android: Show Impress icon for .pps files
        
        For some reason, that was commented out.
        Opening such a PowerPoint file worked just
        fine, and with this commit in place, the
        Impress icon is shown in the "Recent Files"
        view as well.
        
        Change-Id: I69bce54074c084928d9aa7b95f37145a9692b847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133649
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-30  Michael Weghorn  <m.weghorn@posteo.de>  [965205931162b7fcdc175672354103b40985c6ed]

        tdf#111427 android: Enable support for .ppsx
        
        Opening the sample file of MIME type
        "application/vnd.openxmlformats-officedocument.presentationml.slideshow"
        attached to tdf#111427 worked fine now when testing in an x86_64 AVD
        with API level 31, so declare support for it.
        
        Change-Id: I67ace0fb6ee82c0a43624dc32671ba2d453e473c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133648
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-30  Seth Chaiklin  <sdc.blanco@youmail.dk>  [bd950c4bfd2753589bb4b4b89aab6b05eaa1e346]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b218d6ebe0f497748414b3a7fd173cff363b76ae
          - refactor some switchinlines to avoid translation problems
            
               shared/02/06100000.xhp  (Move Up)
               shared/02/06110000.xhp  (Move Down)
            
            Change-Id: Ib67c383db0ee8690a9fcedb4850455319e34f7b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133603
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-04-29  Jim Raykowski  <raykowj@gmail.com>  [c81f4a4ecbfa7dc97d8c28b5ec5f00d1d561b6bb]

        tdf#143569 SwNavigator: Make Headings entries from headings in frames
        
        be in document layout order, not alphabetical order
        
        Change-Id: I75328311a7ddbda1eb050135709da20fed5d054a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133359
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [d4370761421508522a29c5206aea6e538d71b342]

        tdf#148851 Unmap + close file again in xdictionary dtor
        
        The file opened and mapped to memory in
        the `xdictionary` ctor was never unmapped
        and closed again, resulting in a memory leak.
        
        For Android Viewer, this resulted in the app
        running out of memory after a while when
        scrolling up and down in the Chinese sample
        doc from tdf#148851.
        
        On Android, closing the file is actually the relevant part,
        because the content of files from `/assets` is automatically
        loaded into memory when the files are opened (s. the call to
        `openMemoryAsFile` in `openFilePath` in `sal/osl/unx/file.cxx`)
        and that memory is only freed when the file is closed
        again (s. `osl_closeFile`).
        
        When using the sample doc, the file in question
        was "file:///assets/share/dict_zh.data", which
        has a size of 2.2 MB and is therefore actually
        loaded into memory anew every time, since only
        files below 50 KiB are handled by the file cache
        introduced in
        
            commit 26a46c1143e34e361d76d6459535c2056c59de77
            Date:   Fri Dec 20 14:46:36 2019 +0000
        
                android: file-cache to improve performance.
        
        Fix the memory leak by unmapping and closing
        the file again in the dtor.
        
        Change-Id: I3388964877080d1f2b3cf2682a41549e0bfb850c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133581
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-29  Miklos Vajna  <vmiklos@collabora.com>  [515bf5d4afa3a8ed413fd6f17f66fa98b6dbf29e]

        tdf#148683 sw: fix crash on deleting text with redlining enabled, but hidden
        
        Regression from commit 32902f66e7749b2d06d13f50416be5323a0c0ea9
        (sw_redlinehide: make layout based Show/Hide mode the default,
        2018-11-30), deleting some text in the middle of the paragraph with the
        bugdoc results in an assertion failure in the SwDrawTextInfo ctor.
        
        Normally this doesn't happen on text deletion as we already have a
        mechanism for truncating no longer needed lines in
        SwTextFrame::Format_(), though that only checks the length of the
        current line.
        
        Fix the problem by extending this mechanism to also check the remaining
        lines: if change tracking is on and the total of all line lengths is
        more than the string length of the text frame, then time to
        re-calculate.
        
        It seems this is not needed in practice when redlining is disabled,
        though we might want to enable this for the non-redline case as well in
        the future.
        
        Change-Id: Iede03e11daceb3c2b614a301e21560b075a60c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133620
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [0028266e34a683b1650410cee65dac502e304c9f]

        configure: default to --with-system-nss on Linux
        
        NSS is very ABI compatible and part of current LSB 5.0 and so it should
        just work to use the one from the system, i'm not aware of a Linux that
        doesn't ship it.
        
        There used to be some feature patch in external/nss but this was removed
        years ago, now it just contains build fixes.
        
        Problems can occur if a mixture of system and bundled NSS libraries is
        loaded, if first an old version .so is loaded and then newer version .so
        depends on it but can't find some required symbol.
        
        See for example:
        https://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg287043.html
        
        Another issue is that e.g. Fedora ships libnsspem.so in the nss-pem
        package, which may cause trouble in ASAN builds, where the internal NSS
        is built to call __asan_poison_memory_region but the system
        libnss-pem.so doesn't call __asan_unpoison_memory_region so we get:
        
          ==2568944==ERROR: AddressSanitizer: use-after-poison on address 0x61d0019afab0
          WRITE of size 192 at 0x61d0019afab0 thread T28 (utl::Moderator)
            0 in __interceptor_memset.part.0 (instdir/program/soffice.bin+0x466460)
            1  (/lib64/libnsspem.so+0x15f3d)
            2  (/lib64/libnsspem.so+0x16185)
            3  (/lib64/libnsspem.so+0x8a9b)
            4  (/lib64/libnsspem.so+0xe13b)
            5 in secmod_ModuleInit workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
            ..
            21 in curl_easy_perform workdir/UnpackedTarball/curl/lib/easy.c:715:10
        
        Also, with system NSS, things like p11-kit integration become
        responsibility of the OS.
        
        Change-Id: I50caedd46914dd5d6905c5d32d44a599cd78119e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120388
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [55b9b3c9d4a71de1f4e4c79bfce2766d3ef73e28]

        unotest: fix NSS initialization for CentOS7 system NSS
        
        When given an unprefixed path, CentOS7 system NSS 3.67 apparently
        ignores the nice unit test database and creates a legacy "dbm:" one in
        the same directory, which is of course empty.
        
        This causes:
        
            xmlsecurity/qa/unit/signing/signing.cxx:570:aaa_testODFX509CertificateChain::TestBody
            equality assertion failed
            - Expected: 0
            - Actual  : 1
        
        The intermediate/root CA certificates are read from the signature and
        added with CERT_NewTempCertificate(), which then does a lookup in the
        database to find the trust flags of the certificate:
        
         0  nssTrust_GetCERTCertTrustForCert () at pki3hack.c:610
         1  fill_CERTCertificateFields () at pki3hack.c:819
         2  stan_GetCERTCertificate () at pki3hack.c:926
         3  STAN_GetCERTCertificate () at pki3hack.c:973
         4  add_cert_to_cache () at tdcache.c:721
         5  nssTrustDomain_AddCertsToCache () at tdcache.c:849
         6  cert_createObject () at pkibase.c:1023
         7  nssPKIObjectCollection_GetObjects () at pkibase.c:853
         8  nssPKIObjectCollection_GetCertificates () at pkibase.c:1077
         9  nssTrustDomain_FindCertificateByIssuerAndSerialNumber () at trustdomain.c:796
         10 nssTrustDomain_FindCertificateByEncodedCertificate () at trustdomain.c:839
         11 NSSTrustDomain_FindCertificateByEncodedCertificate () at trustdomain.c:852
         12 CERT_NewTempCertificate () at stanpcertdb.c:366
         13 __CERT_NewTempCertificate () at stanpcertdb.c:474
         14 SecurityEnvironment_NssImpl::verifyCertificate() () at xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:524
        
        Change-Id: If334d056a9e13ad806e3ea1a03d395d606fd3d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133622
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Laurent BP  <laurent.balland-poirier@laposte.net>  [170cdf5e335f8803b6d851a9d16020d277e73288]

        tdf#139464 Change label of OK button
        
        In Move/copy sheet UI, change label
        according to selected action
         update: with UI test
        
        Change-Id: I8244b1635f56574c7641191be7e15ee4a098dce9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133364
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [c16128bba6da5f2c51e970631c6cccf3b561ff7c]

        use "Rubik" from more_fonts instead of "System" for consistent layout
        
        using Rubik with trailing 0 because need to overwrite the binary
        fontname in the embedded wmf in this docx
        
        Change-Id: I0338d4876345b0ab13e13cc4609081b3299b981e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133627
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [9550760e7fff134a1a84e21f88f6d48f0db19a75]

        binary patch fontname from Open Sans to Carlito for repeatable layout test
        
        Change-Id: I3b09bb193a0f507fe0a61b28458423be342101e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133615
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc3d56e5cf49a23b3c3fd08590fa497b72e6ff20]

        use more string_view in xmloff
        
        found by examining uses of OUString::copy() for likely places
        
        Change-Id: I50adefbcdbfde8aa71134e5f162b6986a6d566a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133623
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [7cc3d290779796b54f5b6fb1a4a32066f177d323]

        Check iterator before dereference
        
        ... since commit b1148c31ed2786396f0b018a988fce8288f1797d
          Author Noel Grandin <noel.grandin@collabora.co.uk>
          Date   Wed Apr 27 16:47:53 2022 +0200
            use more string_view in comphelper
        
        Change-Id: I182bc507b5693048350d6e54bb7b6176389e2241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133596
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [7c8b9fa98f4c5f7f5620e797dbbe24081e252548]

        sw: avoid EXCEPTION_INT_DIVIDE_BY_ZERO
        
        Seen in
        https://crashreport.libreoffice.org/stats/signature/SwBookmarkPortion::DoPaint(SwTextPaintInfo%20const%20&,rtl::OUString%20&,SwFont%20&,int%20&)
        
        Introduced by 4ce8120f1e53f7b81e653b01d141643013bc69ab
        "tdf#45589 sw: create and paint text portions for bookmarks"
        
        Change-Id: I7d025878164e1f97b86f9d129af9ba93e93b6ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133562
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [3a4a12b3801b0b88d119c6e7aaca1e183f7e470f]

        add a cppunit test for EraseAllMnemonicChars
        
        Change-Id: Ib7a9d0250e855d4c80c7ce2d66df02eac0ab2e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133618
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d606b6bb3e03467fb66a19f0acb85e46b0d4ff41]

        fix regression in linked bitmap import
        
        from
            commit 0527778df5f1ace8731043d070cf54b7b8648545
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Aug 21 13:19:36 2020 +0200
            use fastparser for fill styles
        
        spotted dodgy code while doing other work
        
        Change-Id: I339e8fbdb9df4d5f17ded76de199a3282f7c2d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [60f073c1851ffbbef80acee794ee590c61b7664d]

        set a CTL_SPREADSHEET font from more_fonts for cppunit tests
        
        Change-Id: Iff38496dbdcaec91048e6dd409addac1d0668e21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [e188b24e1c4211557209d857638ee425d107d0c8]

        Segoe UI->DejaVu Sans for repeatable writer layout tests
        
        Change-Id: Id8a59b4dfca7a5075d44fab35c9e83c3d7d9321d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Stephan Bergmann  <sbergman@redhat.com>  [5b6bc8182bc1586facca5c3a019c9985e0d7b411]

        Use the false warning suppression mechanism for loplugin:fakebool
        
        Change-Id: I6572e500edc1be845c28389b0a4d3ca258dbbecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133593
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-29  Michael Weghorn  <m.weghorn@posteo.de>  [779c01a9e1eb3ed176d57e1e04073e25aca34a64]

        gbuild: Drop obsolete checks for make version 3.81
        
        make 3.81 is no more suppoprted, see
        
            commit 4688e74bcf0c58ab1bbf60e9c19331d25ebfe95b
            Date:   Fri Apr 8 11:22:27 2022 +0200
        
                configure: require GNU make 3.82
        
        Change-Id: I0f820512df96fa1712374d3308d15591799222fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133592
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [5592ee094ca9f09bfcc16537d931518d4e6b2231]

        svl: fix testSignDocument_PEM_PDF with "dbm:" NSS DB
        
        CentOS 7 system NSS defaults to legacy "dbm:" DB.
        
          test_desktop_lib.cxx:2943:Assertion
          Test name: DesktopLOKTest::testSignDocument_PEM_PDF
          assertion failed
          - Expression: bResult
        
        NSS_CMSSignerInfo_Sign() (called from NSS_CMSEncoder_Finish())
        internally calls PK11_FindKeyByAnyCert() and that fails likely for same
        reasons as documented in previous commit.
        
        The workaround here is a bit more involved, it turns out there's another
        path with NSSCMSSignerID_SubjectKeyID where the caller can pass in a
        SECKEYPrivateKey, let's try to do that as a fallback if a manual call to
        find the key fails.
        
        Change-Id: I298ee72f178220bcf644093917dba8143b092c92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133577
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [c9e758e3961b71c83a781da4cb12e454f09b094e]

        xmlsecurity: fix testInsertCertificate_PEM_ODT with "dbm:" NSS DB
        
        CentOS 7 system NSS defaults to legacy "dbm:" DB.
        
          test_desktop_lib.cxx:2830:Assertion
          Test name: DesktopLOKTest::testInsertCertificate_PEM_ODT
          equality assertion failed
          - Expected: 1
          - Actual  : 2
        
        The problem is that getPrivateKey() doesn't work:
        
        warn:xmlsecurity.xmlsec:624712:624712:xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx:824: Can't get the private key from the certificate.
        
        In this function, there is a check for trust flags, and the CERTDB_USER
        flag is not set, which causes the failure.
        
        The certificate was inserted here and the trust flags were set; this
        does write something to cert8.db and it's not clear why it doesn't work
        (if this call is omitted with the "sql:" backend, the test fails with
        NOTVALIDATED = 4 - as expected).
        
        Oddly enough, while PK11_FindPrivateKeyFromCert() fails, there's another
        function PK11_FindKeyByDERCert() that does appear to work, so call it as
        a fallback.
        
        Change-Id: I9821966a086574374f4f6df0ac5db2f7376fe742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133576
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [e4184fa0b0b9b34872a0d1fbc6cca41170899a33]

        xmlsecurity: fix init of temp NSS DB when running with uid 0
        
        The problem is that in SecurityEnvironment_NssImpl::insertPrivateKey()
        the PK11_ImportDERPrivateKeyInfoAndReturnKey() fails because
        NSC_CreateObject() finds a slot->needLogin = 1.
        
        This value is set during the first NSS_InitReadWrite() in
        nsscrypto_initialize(), usually this fails, and the fallback path ends
        up calling PK11_InitPin(), which sets slot->needLogin = 0, whereas
        running with uid 0, the first call succeeds and PK11_InitPin() wasn't
        called.
        
        This causes test failures in CppunitTest_desktop_lib
        testInsertCertificate_PEM_ODT.
        
        Change-Id: I302ff17493f9b4d74ceae9da6831a5af87d7f622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133575
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [38258c7e1d55f23b8a73e5f1ba53d9f9fce34832]

        sal: tweak CppunitTest_sal_osl to run as uid 0
        
        Change-Id: I280bcc522f3cd375b5f94e644b76bc5f95899324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133574
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Michael Stahl  <michael.stahl@allotropia.de>  [c0b638bad9f60289d44101fce89c252a26260b69]

        sw: ascii filter: tweak copying of numbering
        
        Add an env var to copy the numbering when selecting a whole paragraph.
        
        Change-Id: I4b9025a4a34070d6848b7788a0ca2b0b9ec01d73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133573
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [183dd9deec869209c45378ff09f063cc9bf03e26]

        Revert "use more string_view in ucbhelper"
        
        This reverts commit d9c3f05dcb6c03633bbcc8d88e55237a0855d9a5.
        
        This is likely a pessimisation since the
           OUString aToken = rNoProxyList.copy( nPos, nEnd - nPos );
        was previously likely mostly just copying the whole string in which case it would return the same object.
        
        Change-Id: I1e09630f0095d194deb72f70bba2d65c04771487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133491
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [38d4b6eb42246c0dbd4958a50ed8437bc93508d6]

        use more string_view in oox
        
        found by examining uses of OUString::copy() for likely places
        
        Change-Id: I23c397b0438e67e0fdbc1fb4ffa6882aa5e2bf91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133591
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Justin Luth  <justin_luth@sil.org>  [f56f8be65b26cb3c8e83af05f10ba9f717ff76b2]

        tdf#126636 writerfilter: import USERNAME field as fixed
        
        This depends on and mimics some of the fixes for tdf#148380.
        
        Microsoft Word doesn't immediately/automatically update field contents
        like LO does. Instead, the user needs to press F9 on each field.
        So, these USERNAME or USERINITIALS fields just show the
        when-last-updated text that was saved in the document
        instead of the actual current value of the field.
        
        Although LO doesn't have that ability, we can flag them as FIXED
        and achieve a very similar result. Doing so fixes this bug report
        which might be quite common since USERNAME might be mistaken
        for AUTHOR or LASTSAVEDBY by the user - since in practice
        they tend to be the same thing.
        
        We already did this for AUTHOR (which is extremely safe since
        that can never change). I almost hate to do it with this one
        because even this bug shows it is too often a case of mis-use,
        but that is the way it is, and this seems to be the best solution.
        
        Change-Id: I48dc6d45992aff740023e80f619b56ad01231782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133346
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-29  xuenhua  <xuenhua2008@sina.com>  [1de6d6c539ec49a9cbeba9ab4c11fe8b6b5f14e7]

        Fix Method EraseAllMnemonicChars bug
        
        MNEMONIC_RANGE_2_START and MNEMONIC_RANGE_2_END defined in 'core/include/vcl/mnemonic.hxx'  are 'a' and 'z'
        This variable c is UpperCase, should be converted to lowercase, and thencompare with MNEMONIC_RANGE_2_START and MNEMONIC_RANGE_2_END.
        
        Change-Id: I721e293e88bf1b8260b7ea2dc39ae6a7fd4f3d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133587
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa88fd0fc8434a4a6077dd80afcd47464669d907]

        Revert "use more string_view in codemaker"
        
        This reverts commit 9463550eabd0455c374c1369bc72388108baccad.
        
        Reason for revert: The codemaker::UnoType::decompose was previously mostly returning the same OString it receives, so this change is likely a pessimisation
        
        Change-Id: Ie1b41889d0a6af9247b8683075d4edd1163fecc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133492
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [3240820acaa2f87e4917d1fa387255c2101460a2]

        oox: make buSzTx and buFontTx behave the same way as buClrTx
        
        I believe this is the right thing to do although this is
        a blind fix, since I couldn't find any file affected
        
        Change-Id: I500ceaf11b917abb5e86769b8816ddc2d6dfec6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133522
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [50e40364f5f60d1e4aa6aaacd48383cd98b3a25e]

        Open Sans -> DejaVu Sans for repeatable layout in test
        
        Change-Id: Ic349fb5a9f42244e7e3bd64f9674c4b07a12da87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133584
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [976c456be6d5e227ba1999da5ae37ee108b43ca7]

        Open Sans Light -> DejaVu Sans for repeatable layout in test
        
        Change-Id: Ia519723347e581b90cabf88e21e048e33ba761da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [392a805cbb243a65be6e13132cca791a79715d12]

        don't use fonts named '0' to avoid font fallback for writer layout tests
        
        Change-Id: I938290a3005cbe169fa91c1b6fd3510f86f1f03d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [9cdc915f3b831ab34452ebb9c504fdbebcbab484]

        repair fontname so no font substitution is needed
        
        Change-Id: Iabf80600f5f4780b3db49b2c87d110f97d686c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133569
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [0693458e6f00bd278b244e790b99dfd0368d4282]

        binary patch in a non-empty fontname for this test
        
        xxd for the win here
        
        Change-Id: I8f882a5975331e281deb539056998068b37c770b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133568
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [1b198e0b69484905a66fce852207c33849125b0f]

        repair fontname to ensure a reproducible layout
        
        Change-Id: I94cc69afff2822e25d09cca278d2d1fb992ac279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133567
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [70dec6deba251e3bc5b41be2829cdd7f773c9969]

        use "Rubik" from more_fonts instead of "System" for consistent layout
        
        using Rubik with trailing 0 because need to overwrite the binary
        fontname in the embedded wmf in this rtf
        
        Change-Id: Ie04a1f017e41d2319986f617b0b31751141edeac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133566
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Caolán McNamara  <caolanm@redhat.com>  [75277f27e38c3469bf9075e3fb4f823bdb29048f]

        set CTL_HEADING for cppunit tests to something from more_fonts
        
        Change-Id: Ieb2878048017cc186fb98fa3c79eaf72b8e7b798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133565
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-29  Miklos Vajna  <vmiklos@collabora.com>  [c53d3a1f4b8430507d54f5fac336870df7a700af]

        sw content controls, checkbox: add DOCX import
        
        My expectation was that <w14:checked w14:val="0"/> would be mapped to a
        single SPRM where the int value is 0 or 1 depending on if this is a true
        or false boolean. But the w14 tokenizer rules actually created a
        NS_ooxml::LN_CT_SdtCheckbox_checked token with a
        NS_ooxml::LN_CT_OnOff_val token in it, which itself again didn't contain
        just a bool but dedicated NS_ooxml::LN_ST_OnOff_true,
        NS_ooxml::LN_ST_OnOff_1, etc values.
        
        To make this more complicated, TextEffectsHandler even depends on this
        weird behavior.
        
        Bring the w14 rules closer to the "main" wml rules by folding the
        NS_ooxml::LN_CT_OnOff_val token into the parent token
        (NS_ooxml::LN_CT_SdtCheckbox_checked in this case), but leave the
        NS_ooxml::LN_ST_OnOff_* values unchanged for now.
        
        The rest of the changes are more straightforward: we now handle
        inline/run checkbox SDTs similar to rich text ones, i.e. map them to
        Writer content controls, rather than just doing a poor mapping to
        grab-bags.
        
        The main benefit here is that the checkbox type of Writer content
        controls actually change their value on mouse click, so it's possible to
        fill in such forms.
        
        Change-Id: Idbf49a8ff1843d5271f2836e5299c4387bb58e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133588
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d3849255b76e92a42f653c266b88945708984c4f]

        use more string_view in INetURLObject
        
        Change-Id: I4462f7cf4740fa4d1b129d76a0775f4250f41bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133555
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-29  Miklos Vajna  <vmiklos@collabora.com>  [f9b6bd6336b35de060f6f5bdd91517caf5e9a56e]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: I1bd84e232c8010fcbcf228295b80ef9306d30136
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133580
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-29  Regina Henschel  <rb.henschel@t-online.de>  [4cfe46997eab3498cc519ef94c85ad2d644d3886]

        tdf#148714 connect first and second arc with arcTo
        
        The curved*Arrows start with two arcs, which should be connected by a
        line. The used commands are double V and double B respectively. Both
        have an implicit moveTo, so that there should be no line between.
        Other applications show the shapes correctly without line. But because
        of bug 148714 LO shows a connecting line so that the error was not
        earlier detected.
        The patch changes the segment definition so that for the second
        command the variant with implicit lineTo is used. This does not change
        rendering in LO but makes other applications rendering the shapes
        like LO.
        
        Change-Id: I4f799f89497e52b1a7e00d8e5345a66ce21c00a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133586
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-29  Luboš Luňák  <l.lunak@collabora.com>  [467f2c50a935efff6ff8911e7282ecea535665a3]

        hack for glyph subset being different because of space being RTL
        
        This is a rather weird corner case than I can see only with
        JunitTest_svx_unoapi failing without this, when asking to lay out
        characters 7-9 from "paragraph 1" with layout mode set to RTL.
        
        Change-Id: Ic55e571a5934ea2b9de2f09b7c066abf014ac212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133578
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-29  Luboš Luňák  <l.lunak@collabora.com>  [3d7ca1bd1c4cc9d468ae214ecb497f71bad340f8]

        don't try to find glyph font fallback for null character
        
        Change-Id: I53000b4da6e208774d5e8c23948474e2e9a1cf3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133561
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-29  Luboš Luňák  <l.lunak@collabora.com>  [2e33af67e04da39116a1dc9fda96d961ae0a4bd5]

        move HAVE_EXPORT_VALIDATION from config_features.h
        
        So that so much stuff doesn't get rebuilt on --with-java change.
        
        Change-Id: I87388590a4fd218fd22e68ba0edd290831f6f0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133570
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Justin Luth  <justin_luth@sil.org>  [83d0f2eebae41d431d9a5bfd1a918523977752d0]

        tdf#137899 sc: accept any unfinished editing before adding sheet
        
        There might be a more general place where this belongs,
        to cover other similar kinds of situations.
        However, putting it here is very targetted,
        and shouldn't get me into unanticipated trouble.
        
        Any changes made in the "top view" need to be accepted before
        they are committed. In this case, the user switched gears
        and added a new sheet while in the process of editing.
        So what should happen here? Should we commit the change
        before changing task? Perhaps. Certainly it should
        NOT show up on the new sheet - but that is what was happening.
        
        Accepting the change when the user gets side-tracked is the norm
        in cases like print-preview, switching to another soffice app,
        or simply clicking on a different cell or switching tabs.
        So auto-accepting in this situation is consistent behaviour.
        
        Change-Id: I4f3f0103ad4fcc1aa8a0c6118383b63ace07ff5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126501
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-04-28  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [b7a37d6fb9fc21afc77964de725d5143f5aad435]

        Fix system-nss: add hasht.h header back
        
        Revert part of 02e1be8883a08ab17f3e890a834ab88f13c5867d which broke
        with-system-nss builds - the hasht.h header was actually needed.
        
        Change-Id: Ida36bc6cd91f0a9b26a2029f1cab835f90f40dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133571
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [972819fe36e5d59fd11b3b40d432f5270ae98bfb]

        avoid a glyph fallback in writerlayout test
        
        replace the obscure graphemes with a bullet that exists in the font
        
        Change-Id: Ib95ae2a8f83a04a3a8b32cf3f7d9d1ecaf7d5f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133564
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [1d59798a17b35ea9b508728809cf793520f06ab9]

        Linux Libertine -> Linux Libertine G for repeatable results
        
        Change-Id: I42ec2b6b0a42428f7a322ffd96fadb96ef0e7678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133563
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [49ce19a824700b2011334a6739ae2749e781155f]

        tdf#74331: vcl_filters: Add unittest
        
        Change-Id: Ia93f5f5f3ca5b4ddd51d68335af7f1c7b79b5c31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133551
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9c3f05dcb6c03633bbcc8d88e55237a0855d9a5]

        use more string_view in ucbhelper
        
        Change-Id: Ief60eda8be8e184b9d637ab84fec2f8740c04396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [ac1c31a577e6fb0efa05ff0ab098ee62f50cb88a]

        set CJK_HEADING and CTL_HEADING for cppunit tests to something from more_fonts
        
        Change-Id: Iabd60e6266f0543e258151aa1bc7199eb7edc35f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [8c9e6d3a99df641f9c395c65f7b48225b8775baa]

        Add initial support OfficeArtBlip TIFF format
        
        Additionally the magic number were replaced with enum
        Change-Id: I7d825ec84ff5cd5ff315ee37613e3b84cb6f0567
        
        Change-Id: Ic33022a0e225099f2397dd300f4792055184fd10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133526
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-04-28  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [3804d4991c2371dcf06f0d359aa21a11111f2860]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d7890e97169844d9a2f46703b893c1123dd8ebce
          - Drop reference to AskBot and update link
            
            It is never a good idea to hardcode the name of the backend software for
            a website in a translatable string directed to users. It’s not future-proof.
            Also, we’ve never called it that; it’s always been “Ask LibreOffice”.
            
            But in this case, I’ve carefully avoided mentioning the product name, for
            the sake of corporate builds.
            
            Change-Id: Ic4c1c01e7ecc86d44157fec638a5d79dcb809733
            
2022-04-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [ceb1d4836d7fa04f600dea2beb146c263f8d3efa]

        tdf#148593  Rename two Horizontal "to" position options for Shape/Image
        
           Left page border ->  Left of page text area
           Right page border ->  Right of page text area
        
           The CSS box model is the underlying idea here, where
           LO uses "page text area" for what is called "content area"
           in the box model. https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model
        
           The reference to "border" in the options was incorrect.
           The renamed controls refer to the regions to the
           left (and right) of the page text area. These regions
           can be used for horizontal positioning  of shapes and images.
        
        Change-Id: I2ea8c682da8fb34b04496b3629819bf5201e86e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133403
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [002e00eed994fdfb50cbbf4486deb1f88a9c5c0c]

        Thorndale -> Liberation Serif for repeatable results
        
        Change-Id: I2096d3a4265d5f38d8bce54ef6089f767aa39afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [dd00ccf29dd03a80bcd24feed63978e97ab7b2ca]

        Engravers MT -> DejaVu Sans for repeatable results
        
        Change-Id: I95273d657fe18b5a8f2315650a6232b5a1de4be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133557
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [a76bc737235a1872845817edccac749e65a646d1]

        override default "Segoe UI" for UI_SANS for cppunit tests
        
        Change-Id: If8b073c6ed9f9508a03ec65e885313d7a618b600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133556
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Caolán McNamara  <caolanm@redhat.com>  [5dcd46fb8f80372f7ce159e168cae4084d41a9fa]

        set default cjk/ctl fonts for cppunit tests that exist in "more fonts"
        
        Change-Id: Ib145f1ce60eb8bb3aef15c803b0d78f684507bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133550
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e6d60166dbece401d29608d5c9005a882b443baa]

        use more string_view in tools::INetMIME
        
        Change-Id: I3bfa5a1402835c21ec70b8d995f79a2edaa6577d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133549
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6cb72c5fc6f9f10f6e450fb80c043c3afa88bd56]

        Fix typo
        
        Change-Id: I600199f87df8a211b2a27913bc1fe2340d315766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133552
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f757f152b1d2267e92a1100a9db58bf6e5aa8d3c]

        use more string_view in tools::SvGlobalName
        
        Change-Id: I814744d250d6ce0ec7049daf215a506adb4f1ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133548
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4149201b099487c5b46d7015b0c174dfff1841ec]

        use more string_view in tools::Color
        
        Change-Id: I0203aff3af19d3994af5325538520469ab2900ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133541
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [34b3c66da2e5a300930f4ea47661b0e38a459565]

        add a hack to SalLayoutGlyphsImpl::cloneCharRange() for a strange glyph
        
        Change-Id: Id4859982079f5f156b5e2d85598940ec8c936475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133547
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [f4d51b6fc1f4e0457efc0d513bd74c64d5697938]

        use the same TextLayoutCache for the verifying call
        
        Apparently not using it makes the ImplLayout() call treat everything
        as one run, which changes whether a glyph may get ALLOW_KASHIDA.
        
        Change-Id: I1a951dbc4242d1fe8e4ee5074d9f9ad1d80480be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133546
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [825102492a04752c4cebf6c84e2c8639de983e9b]

        don't cut a glyph subset inside a composed glyph #2
        
        This is basically the same like 7b7d2f4a3e96e771e125c95a7d262b20f6dc9ecc,
        triggered by CppunitTest_sw_uiwriter3's testTdf104649 on Mac.
        
        Change-Id: Ibb3c33dd6924e8f0c8856185fc7fb7aeaaf72177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133545
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Seth Chaiklin  <sdc.blanco@youmail.dk>  [450b9630c8352667b69d238b7ccd73fafcfa1cb3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d4e7c6e6e119fe3fab827753bbb8d27caff195c2
          - tdf#148797 improve explanation of multiple selection in add to list
            
                Some of the options for using the Add to List command are not
                available when the Ctrl key is pressed. The existing description of
                how to use the Ctrl key may have contributed to confusion about
                how to use the command. This patch aims to improve the 
                description of the workflow with multiple selection.
            
                Also the order of the two procedures were switched, on the
                assumption that the most typical use was to add some consecutive
                items to a list, so now that explanation comes first.
            
            Change-Id: I4e7c57dba4b6060fcd87eb1046b9e0788dd50b1c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133483
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1148c31ed2786396f0b018a988fce8288f1797d]

        use more string_view in comphelper
        
        Change-Id: I1544da756d8da074787bc19a98d2740058e36479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae761fd359f4a553e4552125f77575204d62c958]

        tdf#37864, tdf#147496: sc: Add UItest
        
        Change-Id: Idfcf34a0101158f54bd73efc8629ea8e660a3b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133539
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-28  Julien Nabet  <serval2412@yahoo.fr>  [bd1d0967920655ef85a2352259332f99fef6876e]

        tdf#74331: 16bit "min-is-black" tiff not loaded correctly
        
        Since 16 bits part is well taken into account for photometric interpretation "RGB",
        just consider greyscale as subcase of rgb since greys are just "RGB" colors with same value for red, green and blue
        Finally, in ConvertScanline, nPhotometricInterpretation <= 1 (so "min is white" and "min is black") with nSamplesPerPixel = 1
        corresponds to nDstBitsPerPixel = 8 here, so consider this specific case in the same block.
        
        The last piece to adjust is when calling SetPixel:
        nPhotometricInterpretation = 1 corresponds to the same case as nPhotometricInterpretation = 2
        since RGB black is 0, nPhotometricInterpretation = 1 is minisblack so here too black is 0
        
        Change-Id: I5c8e420f851ed6e31998c0698d86300aaa7c4b19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133251
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [12dcfc191bc258b51f5d00f46ea44a6a1c6fda91]

        include LogicalFontInstance font scale in SalLayoutGlyphsCache key
        
        For some reason it may differ even if vcl::Font is the same.
        Without this ScExportTest2::testTdf66668 fails.
        
        Change-Id: I728a0848ac0420ce0d746134c7072f6ab59f2761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133537
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [f8d6ec1a516237f0e9f73080b172ecba3e96478d]

        make some LogicalFontInstance functions const
        
        They call non-const GetHbFont() internally, but conceptually they
        are const.
        
        Change-Id: Idec7f06425383c5e78030c76da2c50f560bf64fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133536
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Miklos Vajna  <vmiklos@collabora.com>  [8642389b954a0b8f5673c85f44d8b0ea34eb3430]

        sw content controls, checkbox: add DOCX export
        
        Map the 4 UNO properties to the following XML construct:
        
                  <w14:checkbox>
                    <w14:checked w14:val="0"/>
                    <w14:checkedState w14:val="2612"/>
                    <w14:uncheckedState w14:val="2610"/>
                  </w14:checkbox>
        
        Change-Id: I6457754e5dc9750204da7f2e5e479589380f3992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133532
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-28  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [41b012767feb8552b60a68c7be18d80c403304bf]

        tdf#100680 sw DOCX compatibility: fix wrap of as_char flys
        
        New DOCX compatibility flag "WordLikeWrapForAsCharFlys"
        has been introduced which true in case of importing DOCX
        documents. It modifies the wrapping of long words
        with as_char anchored flys anchored into the same line,
        resulting e.g. correct import of poor man's header lines
        drawn by using underline characters under an image.
        
        Note: this example was imported as a broken header line:
        half of it was there after the left aligned image in the
        same line, and after the line break, only the other half
        under the image.
        
        Change-Id: I9474900ef778bcf5ddc9d95f39d536d67015f3b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132571
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c724e18c2af227c2ad865342531ff35b0d511ac]

        use more string_view in i18nlangtag
        
        Change-Id: I92e3d60180c31d765994a2212e1c4547c09c93d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133517
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e3c2e46c61c4ff29b4f4e62aa7a7660042d091e]

        use more string_view in unodevtools
        
        Change-Id: I60e090381e6e56d531b9727604b4755b96c608c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133516
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [2b418c16cd6dfc4b9bdd86b03c941f236bb4945f]

        make SalLayoutGlyphsImpl::cloneCharRange() work for RTL runs too
        
        Glyphs are in the reverse order in this case, so the character
        positions for the wanted range must be treated that way. This improves
        e.g. the second attachment from tdf#112989. Unfortunately it's
        not that significant, as arabic glyphs are often unsafe to break at.
        
        Change-Id: I836ebff6282c420462c5cd5906d30d2e9431f218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133494
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3c0a4eb7d5f7a774f8a6ccef5db19b03e0049a5]

        use more string_view in idlc
        
        Change-Id: Id43d0188c37b0a4d0e7b77a2bb0c95c4411e52c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133515
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-28  Dhiraj Holden  <dhiraj.holden@gmail.com>  [b5e838334b57fee1e38febd95f944698059dfe4a]

        tdf#144788 Split up footnotes and endnotes in Navigator
        
        This patch splits the footnotes and endnotes section in Navigator.
        Before, there was one section for both footnotes and endnotes and
        now there are two sections, one for footnotes and one for endnotes.
        
        Change-Id: Ic0f3af92efa1c0487ee3c407a819bf34138ef4ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132796
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-04-28  Stephan Bergmann  <sbergman@redhat.com>  [27c850b2ea3d004b380921de6664c50e6d54d4f5]

        Fix determining ZXING_CFLAGS for --with-system-zxing
        
        While at least Linux distros typically provide the zxing include files in a
        dedicated ZXing sub-directory (i.e., /usr/include/ZXing/), the bundled
        external/zxing does not (it rather provides them in
        workdir/UnpackedTarball/zxing/core/src/, cf. RepositoryExternal.mk).  Therefore,
        source files like cui/source/dialogs/QrCodeGenDialog.cxx
        
          #include <BarcodeFormat.h>
        
        etc. rather than
        
          #include <ZXing/BarcodeFormat.h>
        
        etc., and for --with-system-zxing ad92c7dfa64c9e08aa2bcf612a9a4a68e9deae22 "fix
        system zxing build" simply hardcoded ZXING_CFLAGS=-I/usr/include/ZXing (i.e.,
        the typical location for these include files).
        
        However, for e.g. a Fedora Flatpak-from-RPM build of --with-system-zxing
        LibreOffice, the include files will be in /app/include/ZXing/ rather than in
        /usr/include/ZXing/.  (And which AC_CHECK_HEADER would find via
        CPLUS_INCLUDE_PATH containing /app/include for such a build.  But the hardcoded
        ZXING_CFLAGS then caused compiling e.g. cui/source/dialogs/QrCodeGenDialog.cxx
        to fail because it didn't find BarcodeFormat.h etc. in the hardcoded
        /usr/include/ZXing/.)
        
        So when checking for the sample zxing include file (MultiFormatWriter.h), try
        any $CPLUS_INCLUDE_PATH paths one by one (and with a fallback to /usr/include).
        (The explicit unset ac_cv_header_MultiFormatWriter_h is needed so that the
        second and later iterations of the for loop don't erroneously reuse a cached
        "no" result.)
        
        Change-Id: Id85f9960ffd3759c7960ef3a81982b85bc3c04c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133189
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-28  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d2199ca8e63365c2d1f03b88a7f6042b6d3c171d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b6accc5eaf8d547bc9721118caaa9edbc998a333
          - tdf#114263 Basic 'New' operator is optional when setting 'Option Compatible'
            
            Change-Id: I27ef9d9c832e4c52e5066336e54095ca949fec9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133398
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-04-28  Miklos Vajna  <vmiklos@collabora.com>  [30735bdb5a0a81619000fdd24b2d0fbf45687f01]

        sd theme: add PPTX import for shape fill color effects
        
        This is always direct formatting, so FillProperties::pushToPropMap()
        always has the needed info at hand.
        
        Change-Id: I3317b618e0e8bb7688d0f0fbfe4546e2e8b4e947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133525
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [bd568b360450b348ff0e6813862a49892df81140]

        check kashida only if the flag is set
        
        Change-Id: Ie508863c670e4b691bd30ac4d20ce479a569f793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133531
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [7b7d2f4a3e96e771e125c95a7d262b20f6dc9ecc]

        don't cut a glyph subset inside a composed glyph
        
        A glyph may may composed from several characters, when asked to make
        a glyph subset for a character range, make sure the end of the range
        is not inside this character group.
        
        Change-Id: I41d82b432858a87e103dcb0d2fac6a11f25a32dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133530
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [c8a7a6d600c2fb0ebe84c97553b2754936122023]

        better debug font compare in SalLayoutGlyphsImpl
        
        The pointer comparison can be false even though the contents match.
        
        Change-Id: I584d30fdc7f311fd1a6058ae3cef98ce8b243f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133529
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [9e2d48b9e04f7ea895fb095699c32ed8a44eb129]

        reduce Calc's INITIALCOLCOUNT to 1
        
        Columns should be dynamically allocated on demand, so there should
        be theoretically no good reason to allocate 64 initially. In practice
        doing so hides all places that do not allocate columns as needed.
        
        Change-Id: I8b46ecc97852ed23369e720f50f3266c48440435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133311
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Luboš Luňák  <l.lunak@collabora.com>  [ee57936475064b409565490022f414220656e12c]

        fix horizontal Calc cursor skipping
        
        UITest_calc_tests' columns.CalcColumns.test_column_hide_show fails
        with INITIALCOLCOUNT being 1 because column C was hidden, but
        searching only up to the first allocated column + 1 searched only
        up to column B. Whether an entire column is hidden is not part
        of ScColumn, it's stored in ScTable.
        
        Change-Id: Ib1befe5cd0db8d50a6196bc6621fb1b0967e6209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133524
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-28  Jim Raykowski  <raykowj@gmail.com>  [4c0939f900b862ae8abe585617d51898a7c0caf0]

        SwNavigator: Improve ordering of hyperlinks in text frames
        
        This patch improves ordering of the Navigator content tree Hyperlinks
        members that are in text frames by placing them in the order of
        document layout appearance. This is done by doing a second sort using
        the text frame anchor position. Previous to this patch only a sort
        using the node index of the node that contains the hyperlink and the
        start position of the hyperlink in the node text are used to determine
        sort order. This results in hyperlink entries being placed in document
        model order in which hyperlinks in text frames are placed before all
        hyperlink entries in the regular document nodes section. This sort is
        still always done initially with the additional anchor position sort
        only being done if needed.
        
        Change-Id: I26f1a12657748a09c2cccd54e89c75ea42ee2ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133342
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-28  Jim Raykowski  <raykowj@gmail.com>  [fecc129799c1ceb733dd65d3ccf28f61555b19f2]

        SwNavigator: Improve list order for text fields in text frames
        
        Fields in text frames may not be in order of document appearance in
        the Navigator Fields list. For example, when a field in the first
        paragraph has a greater start position in the paragraph than the
        start position of a field in the second paragraph, the field in the
        second paragraph is placed before the field in the first paragraph in
        the Fields list in the Navigator. This patch fixes this unexpected
        behavior by first sorting the fields in document model order and then
        doing a second sort using the anchor position of text frames for the
        fields in text frames to place these fields in document layout order.
        
        Change-Id: If86f133fbce72f936334dffbc237d097de382ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133350
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [dbf907f6ccbe83ba9e9982a7b6c8fc21b6dbdb37]

        UITest_impress_tests: fix sporadic failures
        
        Change-Id: I6825eccedd7a069ef743efb8d1265d9c9729a59a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133513
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-27  Luboš Luňák  <l.lunak@collabora.com>  [bb07fb341f9d9398a3723df2a5ccf3a025a7d361]

        todo note about SalLayoutGlyphsCache possibly reusing different mapmode
        
        Change-Id: I68f23addb834b5c59564dda66f5bce1bb9a541bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133506
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-27  Luboš Luňák  <l.lunak@collabora.com>  [3a407fc49490a348a8147a59dae242aa21708c31]

        make SalLayoutFlags match after makeGlyphsSubset()
        
        SalLayoutFlags::BiDiStrong would be set by ImplLayout() if the entire
        subset had no RTL, but the entire string may not be that, so when
        creating a subset make sure to also set this flag. Similarly
        SalLayoutFlags::KashidaJustification should be set only if any
        glyph in the range has GlyphItemFlags::ALLOW_KASHIDA.
        
        Change-Id: I0aa2526f2fdd0c6a6b905ad0cb4040ee556529a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133502
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-27  Luboš Luňák  <l.lunak@collabora.com>  [6d36d7185b025c77db9dcccea1861d37dd6bcc1b]

        provide explicit function for hashing vcl::Font
        
        It's cleaner than streaming the font and then hashing the result,
        and it's also faster.
        
        Change-Id: I6262e45362d386c21482f1e71be51912f123ee45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133500
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [8de60b9049f07d8a958d0e28759dca247c4d5044]

        tdf#148819: let the scroller know the custom widget's line size
        
        Change-Id: Ie30cd1db182aad5fbbf7e89498bd0ae9ce98c0f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133518
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [61a4b90dcdb953dd21a22a2f291ffd6be399ddd8]

        tdf#148665: sd_import_tests-smartart: Add unittest
        
        Change-Id: I345f0a55ba5bbe78e4c0bfccd9b21965c05bff33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133507
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [74c1b3216593eaf522fb54bd99ac36bae4ecc04a]

        tidy low-hanging documents to ensure layout using the fonts from "more_fonts"
        
        that would be suggested as fallbacks by fontconfig where the original
        isn't available.
        
        Change-Id: Id7e85ec36b6ad16f11d40ccf8a8a5a92c37738be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133521
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [70aae52a1e4c71785a9ef6a403ab10144b970537]

        tidy rtf to use reproducible fonts
        
        Change-Id: Ibb6e174c0cb5ce00c28fedad1a306e2bc7529fe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133514
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a58701650c2dd7ad8514752d571aa2569690fe37]

        Fix typos
        
        Change-Id: I04c9c441a7e93cd998e99e4ede7d9894e14c364e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133519
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6fbc3de17cd9274dc3a09e1eeb914c45f7dfe140]

        tdf#148718  Heading -> Chapter in Index preview
        
            change "Heading 1" to "Chapter"
            change "Heading 1.1" to "Subchapter 1.1"
            change "Heading 1.2" to "Subchapter 1.2"
        
        Change-Id: I9c74cef8f20728e38ab9e81df6d74d13c819148e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133478
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [3ce4689dd73e5652d58d186ed7380f576ff56617]

        Clean up includes
        
        Change-Id: Ied9a75953875e809e4284fdff03aab6add6800ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133511
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [9463550eabd0455c374c1369bc72388108baccad]

        use more string_view in codemaker
        
        Change-Id: If311f5600bd61387cc709065978306c21360dea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133509
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-27  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [a3e540304269772595439de22b54269011721bb2]

        tdf#146449 sw: fix Z-order after undoing
        
        Textbox z-order synchronization was missing in case
        of Undo, resulting broken text boxes.
        
        Regression from 504d78acb866495fd954fcd6db22ea68f174a5ab
        "tdf#143574 sw: textboxes in group shapes - part 1".
        
        Change-Id: I2632b7fb40e327f083e680e10b19c8f405df1875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130875
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Attila Bakos <bakos.attilakaroly@nisz.hu>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-27  László Németh  <nemeth@numbertext.org>  [d1d23f01ed321b088c26217e9be367c0fe8121af]

        tdf#85610 sw: show tracked footnote insertion/deletion
        
        also in the footnote area by formatting the footnote
        number there as the footnote index number in the main
        text (i.e. as anchor of the footnote).
        
        Previously deleted footnotes were shown as not
        deleted footnotes in Show Changes mode, also inserted
        footnotes lost their footnote number formatting (i.e.
        author color of the tracked change, and e.g. the default
        underline) after file saving.
        
        Note: for a working test, fix also MetafileXmlDump by
        removing the bad 0x01 from the XML dump, which resulted
        by the not expanded footnote index placeholder character.
        
        Change-Id: Ie003f4e19d2e2cee6f09d3b195db69fe5c10e405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133503
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [8ae17abbcce62dab714e8e36ef5225e6fef75334]

        tdf#125931: add Properties panel to Math's Properties deck
        
        For now, it only contains buttons opening the dialogs accessible
        from Format menu. This is enough for the initial implementation,
        and should later be changed to individual controls allowing to
        set the formula properties directly.
        
        Change-Id: Ia0e52915198ddb2648d13d577d55b367f178b1ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133508
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [38a475fbfb346234bcd9976fadf4067c7ea9da29]

        sw: qa: don't use try/catch in unittests
        
        Change-Id: Ib1d6ea6b5e8e7f3e985014210c16725ee7645f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133471
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [0a6ca96436312acfe9a44d005c9a5c42697b8c2f]

        forcepoint#93 fix crash on layout of specific rtf
        
        Change-Id: Id81729de2efd6f65f1b51bdb437ca21a260eaf6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [09530aec3c0687df316704eec96b3e2a96b1d804]

        cid#738565 Uninitialized scalar field
        
        Change-Id: I17a675d3b7468e528faef89de7ea862de37a57db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Regina Henschel  <rb.henschel@t-online.de>  [0818a3dcaf6d7962d043829d42a3bb9d998393d4]

        tdf#148784 consider StretchX in OOXML export
        
        The export to custGeom uses currently a static version of the shape. Its
        vertices are calculated with EnhancedCustomShape2d::GetParameter(). That
        has parameters to determine whether ReplaceGeoWidth and ReplaceGeoHeight
        has to be used. It needs to be used, in case the shape has property
        StretchX or StretchY. That was missing. It is added now in cases where
        GetParameter() returns a coordinate.
        
        Not all cases are covered by unit tests. Further files for manual testing
        are attached to the bug.
        
        Change-Id: Idcdd081f855ed6c4e3a84dba08f8a2148ddfe54c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133463
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [05e75d86dbac70486306b2d8bccd88fbc51d2906]

        use more string_view in tools
        
        Change-Id: I15ca12f35a66994cb90a0ccf60a1ce0f8efcfecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [3791aff7ba4481cc4a357b7223440bf785469bb3]

        use string_view in ImpSvNumberInputScan::StringToDouble
        
        Change-Id: I53df3f273fd5587b12c509ead1477c2108d7fe75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [fc12d6b962bf3b34501fe656e1cf9fefbd944332]

        update credits
        
        Change-Id: I5d60bff321a20a0d8f8b05af7ea58c7ebbbba1b7

2022-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d506ff97c25b5f433aa25d8b373f1a732af493d1]

        add string_view wrappers for rtl::math::stringToDouble
        
        Change-Id: I114bec72cb933238675e539a8388a607226827cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-27  Hossein  <hossein@libreoffice.org>  [148f45253f75bc724804f3231a0b04b2d453e0c7]

        tdf#148665 Fix crash while loading SmartArt graphics
        
        The regression introduced by c79fa460fe6220051bbda2d3c0cb67fbf765e2ac
        causes LibreOffice to crash while loading certain files that contain
        SmartArt graphics.
        
        By loading sample documents from tdf#148665 (docx) and also tdf#148735
        (pptx) in a debug session, it became obvious that the problem happens
        in these statements from TextBody::toString() in textbody.cxx:
        
             if (!isEmpty())
                 return maParagraphs.front()->getRuns().front()->getText();
        
        It is guaranteed that maParagraphs is not empty when trying to call
        getRuns(), but it is not checked that there are no runs in the first
        paragraph before trying to call getText(). The isEmpty() function
        returns false upon finding out that there is at least 1 paragraph.
        
        A check is added to TextBody::toString() to prevent a crash.
        
        This is the backtrace generated from loading documents from tdf#148735
        in a Qt Creator debug session:
        
        1   __GI_raise  raise.c   50   0x7ffff79ec03b
        2   __GI_abort  abort.c   79   0x7ffff79cb859
        3   ??   0x7ffff7846109
        4   std::vector<std::shared_ptr<oox::drawingml::TextRun>>::front  vector  443  0x7fffd23d1fa6
        5   oox::drawingml::TextBody::toString  textbody.cxx  92   0x7fffd23d0f85
        6   oox::drawingml::DiagramData::secureDataFromShapeToModelAfterDiagramImport datamodel.cxx   295  0x7fffd22d3047
        7   oox::drawingml::AdvancedDiagramHelper::doAnchor   diagramhelper.cxx   213  0x7fffd22fb92d
        8   oox::drawingml::Shape::propagateDiagramHelper   shape.cxx   229  0x7fffd2372a27
        9   oox::ppt::PPTShape::addShape  pptshape.cxx  574  0x7fffd25b2bd4
        10  oox::ppt::SlidePersist::createXShapes   slidepersist.cxx  150  0x7fffd25d81ea
        11  oox::ppt::PresentationFragmentHandler::importSlide  presentationfragmenthandler.cxx 404  0x7fffd25c1a78
        12  oox::ppt::PresentationFragmentHandler::finalizeImport   presentationfragmenthandler.cxx 550  0x7fffd25c3331
        13  oox::core::FragmentHandler2::endDocument  fragmenthandler2.cxx  53   0x7fffd22364ab
        14  sax_fastparser::FastSaxParserImpl::parseStream  fastparser.cxx  907  0x7fffe18b2d2b
        15  sax_fastparser::FastSaxParser::parseStream  fastparser.cxx  1480 0x7fffe18b71d2
        16  oox::core::FastParser::parseStream  fastparser.cxx  121  0x7fffd221d85b
        17  oox::core::FastParser::parseStream  fastparser.cxx  129  0x7fffd221d930
        18  oox::core::XmlFilterBase::importFragment  xmlfilterbase.cxx   413  0x7fffd2248ba5
        19  oox::core::XmlFilterBase::importFragment  xmlfilterbase.cxx   343  0x7fffd2248687
        20  oox::ppt::PowerPointImport::importDocument  pptimport.cxx   109  0x7fffd25a89e2
        ... <More>
        
        Change-Id: I3a40be33061008b93455a5926259ef5b92e4ffe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133341
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [221da351f37c33296c2e3ce17334280bfb9226cc]

        ofz#47051 Out-of-memory
        
        Change-Id: Ie5276cfda3abe2f4787d2fa85d916449390ddda2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  dldld  <LibreOfficeContribution@dldld.de>  [daeba3f3cc376365b041c2441e3b6dbd46aa8235]

        tdf#141835 handle SHOWWINDOWMODE_END when resuming the slide show
        
        The problem which is fixed with this commit is, that the slide show ends when the presention screen has shown "Click to exit" after the last slide, and then the slide show was moved to a specific slide. e.g. via Remote App or Presenter Console. In this case the slide show should be resumed and the slide should be displayed. Instead the slide show was ended.
        
        Instead of only handling the BLANK mode for resuming a slide show also the END mode is now inlcuded to resume the slide show.
        
        Change-Id: I78e00dc882b2d7af8b7a6b215aaac122bbd9ead9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133337
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-27  Justin Luth  <justin_luth@sil.org>  [4a8ea3d086e03098fcff2a744ccb632f50f173dd]

        tdf#148380 sw ms: import select fldLock'd fields as FIXED
        
        Many fields we are locking just because we can't trust that
        what is seen in MSWord is what will be seen in LO.
        
        Of the unlocked fields which normally should be updated
        (SAVEDATE and PRINTDATE), if MS Word secretly has also
        locked them (via Ctrl-F11), then we also need to lock them.
        
        Currently, on export these will be exported as plain text,
        which IMHO is perfect because them we never need to mess
        with these nasty fields again.
        
        WriterFilter import was already handling the complicated FldChar's
        fldLock OK, but nothing happened with the one for fldSimple.
        Proving once again that a monkey can program, I randomly made
        copy-changes to model.xml until I got the result I wanted...
        The unit test has one of each.
        
        Change-Id: Ia197794f4ea7e105b67cb1805c5def5347d7690d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133087
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [e678e013a9b8d928353f1136b77469950bdd2cdc]

        sd_export_tests-ooxml2: don't use try/catch in this test
        
        In general, try/catch shouldn't be used in unittests
        Follow-up of 9564747d2fd5d2c859a359dd7fa6242c6859c0d7
        "tdf#53970 PPTX: fix import of linked media files"
        
        Change-Id: Ibde31d033b0225ab47522eff01e156cbb2751f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133468
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [42eeddb2e634f70418b2aaba7ba9fb479a58ac0e]

        [ Edit Chart ] -> [ Edit Object ]
        
        This button was introduced in commit 376cd2ceaeedd12a8050c5acd142cd9b9d5e731a
          Author Muhammet Kara <muhammet.kara@collabora.com>
          Date   Wed Nov 20 15:30:01 2019 +0300
            Add Edit Chart button for online's mobile view
        
        It is shown for any kind of OLE object, including Math. So make its text
        more neutral.
        
        Possibly it could make sense to construct the name from the OLE object's
        proper name in a follow-up.
        
        Change-Id: Ied2e9b10db3bcbfab4328a1f65f812cd52f85004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133426
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [beb462d12de819ed1487b293db7312e790b1e5d5]

        use o3tl::toUInt32 to replace what was originally OUString::toUInt32
        
        Change-Id: I58fb024fa4e2633999f6be708da830ca3f9833c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133472
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [4b608064ef1af9e3ded464670832fa4de0ed75a8]

        ofz#24932 Timeout
        
        Change-Id: I8eff4cee1ba06c7ad69cb6ec8e483a84cfd3a347
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Miklos Vajna  <vmiklos@collabora.com>  [c2fab664a887b16cb78570851ceffcacd26815f7]

        sw content controls, checkbox: add ODT filter
        
        Map the 4 new UNO properties to XML attributes:
        
        - Checkbox <-> loext:checkbox="..."
        - Checked <-> loext:checked="..."
        - CheckedState <-> loext:checked-state="..."
        - UncheckedState <-> loext:unchecked-state="..."
        
        Change-Id: Ia4623004ee39c77f5f242c2d720bc188e4dd9433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133467
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [7fbfefaedec93d7b49d1f53e23aed3cbbb55b315]

        tdf#126658 UI improvements to Arrow Styles tab in Line dialog
        
             * label "Organize Arrow Styles -> "Manage Arrow Styles" 
             * label "Title" -> "Style _name"
             * button label "_Modify" -> "_Rename"
             + Add a tooltip for "Rename"
             - Remove label "Add..." (which was inadequate)
             + Add tooltip and extended tooltip for "Add" button
        
        Change-Id: I0226b32158c3bb9ae2600f8bfce3739f2ddbe5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133036
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [1c1427e81c2463fbc40855adfafa360c13108abb]

        reenable this test on mac
        
        now that the fonts are not substituted
        
        Change-Id: Ib9df279cfd296eabf4e25bc3ff2458c66f14ffb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133461
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [53392cbcba0c18fa56a9d7d65fa885fcf52ac17b]

        remove static buffer
        
        Change-Id: I77ebc45000e09d1553c8e63402f30e720852c057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Caolán McNamara  <caolanm@redhat.com>  [ff27c0e35ebfdbe998c372b7a36df8b5577e1fd4]

        use Bitstream Vera Sans for consistent results with LIBREOFFICE-UXTSOREL.rtf
        
        instead of Palatino Linotype which will typically get substituted
        
        Change-Id: I80c597c7fc807fef334c6edb160dfddf9214d7cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [40559dd30db04ab67d27fafe1e0c928757f7e7c0]

        tdf#131760 change category of Styles command
        
            "Format" -> "View"
        
        Change-Id: Ia702a28fd7eacf52bf02964e9dad7a3b69390241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133413
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-27  Miklos Vajna  <vmiklos@collabora.com>  [21891a777e4b6647b2a7b716be5f9b91d69d3272]

        CppunitTest_sw_ooxmlexport10: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I9006306f0522d08ed47bd26e2a808acdc560f12c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133457
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [5453f75a1e682992f3a725781bb563b8cc76cf1b]

        android: Slightly clean up style of LOKitTileProvider#resetParts
        
        * Reduce scope of the `parts` variable to the if block
        * add an emptly line before the next method
        
        Change-Id: I22389cb4c9307f6888c4ed836056caf23ce84da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133450
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [e996ad71582ecd4425a1ab0d0347cccf7c7724c2]

        android: Reuse existing LOKitTileProvider#resetParts
        
        ... instead of duplicating what it does in
        `LOKitTileProvider#postLoad`.
        
        Change-Id: I0ed3d77d9f9651efec764eafeaa3f71576abcf6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133449
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-27  Michael Weghorn  <m.weghorn@posteo.de>  [1b45a30ccd4726612420bd09318eeae2a72425be]

        android: Leave part names starting with "Sheet" etc. intact
        
        It's unexpected that opening a Calc sheet with two tables
        called "Sheet foobar" and "Sheet 10" would result in the
        sheets showing up as "Sheet 1" and "Sheet 2" in the parts
        view instead of their real names.
        
        Therefore, leave the original names intact and show
        them instead of generating new generic names.
        
        The change to rename such sheets (and similar parts)
        has been added in
        
            commit 1239dce2595877ad64fd8c8fd927ea4285d69abe
            Date:   Thu Nov 1 22:03:31 2018 +0300
        
                [Pardus] language improvements on Android
        
                More hardcoded strings extrated to the resource file
                Few Turkish language improvements
                This patch is sponsored by ULAKBIM/Pardus project.
        
        where the intention seems to have been to have a
        localized name for the parts show up.
        That still happens when the part name is empty
        (s. lines above), but I think that explicit
        names should remain as they are, as e.g. also
        happens for Calc sheets in the desktop version of
        LibreOffice.
        
        Change-Id: I3073babf99a6b2309be2107141bba92236eba76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133448
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-27  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [3a05acb8f0d94728ea6cbfd7a69dac6ffa7ffc68]

        tdf#148515: RTF filter: do not use char prop defaults for tables
        
        During deduplication of table row (when nStyleType == 0) we should
        not deduplicate character properties against default style: this
        leads to invalid default settings for table rows/cells.
        
        Attempts to do so are already made during \pard processing when
        default style is checked if it is paragraph style. But this is
        not enough: style definition can contain paragraph and character
        properties as well.
        
        Change-Id: If520c5a248897728b7de08a017136ca1a01a5f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132943
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-27  Seth Chaiklin  <sdc.blanco@youmail.dk>  [51809407d060973aa00c733615c35cf4222f7e51]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f6d93aeda80f5a1f24e6fd162c43143a0373add3
          - (related tdf#140818) update to "no character style" in help
            
            Change-Id: I7e5e09118ec985286cb6a9b8c15dedd17734bd6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133474
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-04-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [8831d4ebbf8253327f4f0024035ff310ae233e43]

        tdf#131760 change category of Load Styles
        
        Change-Id: I9d27c1a829991232f09486a6fd9cdd1625b03a91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133147
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [bc79e5fcde5d6ad07d75e2a02c8e164c45e0f02a]

        tdf#148732  Change label, add tooltip for .uno:DefaultCharStyle
        
          tdf#140818 changed the label "Default Character Style" to
          "No Character Style". The changed label appeared in the Styles
          sidebar, but the menu command that appears in the Styles menu for
          Writer was not changed. The present patch rectifies that oversight
          by changing the menu/toolbar label and adds a tooltip for this
          command.
        
        Change-Id: I4a82dc0626702c7282d3022d2f4e45eb6b33b373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133401
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [6a1a68596a822811db80c3f9d1bf1c30db75c972]

        ofz#47042 previous use of static variable affecting later runs
        
        Change-Id: I64fb184e43fb025798781c85c9a0a8e0354b21b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133452
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8a2c64fbab84e4c87910e0775aaba6f3f0ce9486]

        Fix typo
        
        Change-Id: Ic11575e553bfe7177a0bff6b7f5557213fb1930e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133447
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fe702f1b69a02a274621a01db68256a94edfd36]

        add o3tl::toUInt32
        
        Change-Id: I07f11bf12fbe1d1c2d812fa0965d6e632e1e1aba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-26  Tünde Tóth  <toth.tunde@nisz.hu>  [cf2dc247ff5f726238856e9b46a4926a30430e14]

        DOCX export: image deduplication and clean up
        
        Follow-up to commit aea8043bc5f5187498fa450505d6de9d6986e2a6
        "tdf#74670 tdf#91286 PPTX XLSX export: save image once".
        
        This reverts commit 797fef38612fb2fd62d1f6591619b9361e526bca
        "tdf#118535 DOCX export: save header image once"
        
        and commit 32ada80a9f47b095d7b0c4d16e3422f6ef7f2ac2
        "DOCX export: make sure a graphic is only written once"
        
        and commit b484e9814c66d8d51cea974390963a6944bc9d73
        "tdf#83227 oox: reuse RelId in DML/VML export for the same graphic".
        
        Change-Id: I2d90249808174290b6b3e4eb957b3ac87ad41f95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132506
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-26  László Németh  <nemeth@numbertext.org>  [2fbf0f418ccb25010add33449d4e42b8b3f7fd0b]

        tdf#148791 tdf#64902 tdf#127759 sw: fix row insert/paste
        
        Table insertion mode and Paste as Rows Above inserted
        only a single row above, and overwrite the next ones in
        the following cases (instead of inserting/pasting rows
        above according to the clipboard table content):
        
        The table stored in the clipboard
        
        – has centered, right or not paragraph starting alignment;
        
        – or its resource table has a table header with 2 or more
          repeating rows, and the clipboard content contains the
          same amount or less rows (it doesn't matter, that
          the copied rows weren't header rows originally).
        
        The reason was that parsing of the HTML clipboard content
        which is used for counting the row count of the clipboard
        content hadn't handle the following cases:
        
        – different table aligment results <tr> elements with
          greater indentation level in the HTML extract, according
          to the new root element <center>, <div> or <dl>;
        
        – copying rows from a table with row header always starts
          with <thead> in the HTML extract, i.e. detecting <tbody>
          can fail, because there could be only <thead> in the
          HTML extract (see Case 2 above).
        
        Follow-up to commit 0c8b1efbad48fa9697c0b1afbe4753bbbc3c4c5c
        "tdf#127759 Writer: add table row/column insert mode" and
        commit 7efae60f3625a58f8a617c80f2a55a695fbaef36
        "tdf#64902 Writer table: Paste Special->Rows Above".
        
        Change-Id: I466cea20705bc5dd5455e22842da7dfa6631ba81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133445
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-26  Tünde Tóth  <toth.tunde@nisz.hu>  [9564747d2fd5d2c859a359dd7fa6242c6859c0d7]

        tdf#53970 PPTX: fix import of linked media files
        
        Linked media files were imported as images in documents
        created with Impress after PPTX export.
        
        Change-Id: If4920c2e40f45fff73eca4a5fa987d524177597e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132635
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [5b27a93f58671b7546414cfff673179c3ff0550f]

        tdf#140272 gtk3: fix crash with dnd using touch
        
        gdk_wayland_drag_context_manage_dnd needs
        gdk_device_window_at_position(device, ...)
        to succeed
        
        similar to the problem of https://gitlab.gnome.org/GNOME/gtk/-/issues/1080
        
        Change-Id: I2e1956b40a622b1d74d3aef3b5fac654fc1256eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [a8d01742e98d29a57be6d990b7331f789bc3a5ee]

        Improve some signed vs. unsigned comparisons
        
        p2-fwd will always be non-negative
        
        Change-Id: I143d7fd3c5ec192ffaeb56bc2e9f45ac5e83cb6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133439
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [bdff0bb77b57def835fcaed3bded7519e69dc896]

        Use o3tl::make_unsigned in some places
        
        ...where a signed and an unsigned value are compared, and the signed value has
        just been proven to be non-negative here
        
        Change-Id: I9665e6c2c4c5557f2d4cf1bb646f9fffc7bd7d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133442
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Miklos Vajna  <vmiklos@collabora.com>  [651527b4efe9700c8c8dff58ce5aa86ad5681f16]

        sw: fix double-click opening frame dialog, not graphic dialog on images
        
        The user-visible problem was that once a user clicks on an image a lot
        (e.g. 5 times), then the slot ID dispatched on double-click in
        SwEditWin::MouseButtonDown() is no longer FN_FORMAT_GRAFIC_DLG, but it's
        FN_FORMAT_FRAME_DLG.
        
        This is already inconsistent, but it's especially problematic in case an
        UNO client intercepts only the first UNO command, but not the second
        one.
        
        The other inconsistency is that in practice this only happens for
        as-char images, at-char anchored images work fine.
        
        The reason for this seems to be how we get the doc model position for a
        twips view point. At-char anchored images are handled at
        lcl_GetModelPositionForViewPoint_Objects(), and there we return the
        SwGrfNode in case the view point is inside the frame of the matching fly
        frame. SwTextCursor::GetModelPositionForViewPoint() restricted the same
        to as-char fly frames which have text or layout frame children.
        
        Fix the problem by allowing non-text frame children for as-char images.
        
        Change-Id: If08e7dd2a72f46ebcfb8c6ddf110703eaeb7df6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133443
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [3524e4f7352993517ebdd514435378f6de0ca713]

        tdf#125931: Add Elements deck and Elements panel to Math's sidebar
        
        Change-Id: Ie04a5dc48de38f318f0ddb42efc42cea022dc62c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133393
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-26  Mike Kaganski  <mike.kaganski@collabora.com>  [9098d5a2e43b156648f187559790547d1b536896]

        tdf#125931: Enable sidebar in Math
        
        No panels yet, only one default deck (PropertyDeck). It is needed
        to have the uniform default deck like in all other modules (see
        commit c09f59eb6173a4a53a2d40ed80aebed18e3882ac); the panels for
        formula properties might appear later.
        
        Change-Id: If1785dc780111fe496638418f43e7b90a250ffce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133334
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [57087dd1945429d9cfe6ce8bdc329ef315f455d3]

        Pick better variable types
        
        Change-Id: Ia4ba19744e23c20d9b6fb0e9d803bc00b415191f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133441
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [fa7e4ddb61f79f2c1fd540a1445fd0045175a56d]

        Pick better variable types
        
        Change-Id: I134a8cddba169fe9bcc04687ad15c2cfeaccfb0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133440
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [2e1e14b7d0fab28858a54340636de01ed6eb4bc0]

        ofz#46901 Timeout
        
        Change-Id: I458ddb6ee4d7023f60c8d1c26699bbd74502ddc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133375
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [b1c80b5c0973563c8cbf7c305aef493e9d3f7c0d]

        Adapt function's interface to change from OUString to std::u16string_view
        
        ...in 6fc3dfd3f1b5cb13101299df42444f2ff0493846 "use more string_view"
        
        Change-Id: Ibd1b8748e7a261cdb457a14ba87b1ec68d2a83de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133438
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2252dd8098ab60ded2117deadd07e46b12e4133d]

        Update git submodules
        
        * Update translations from branch 'master'
          to c2b26d58f520fa40a8c64fb7d0217c578a1dd135
          - update translations for master
            
            Change-Id: I6c6fcd88b8e746f36dc784e6c0ccb3b16c81dbeb
            
2022-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [6df639114da3fa98bd2fd749eca40d3c2190c018]

        android: Use 'if' instead of switch-cases with just 1 case
        
        ... which IMHO makes this a bit more readable.
        
        Change-Id: Ica1d9416f711e75e6d6c23963ca64d13e08c138e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133428
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-26  Michael Weghorn  <m.weghorn@posteo.de>  [052c8a4b1b3aaa472ca89f834572c293f7d9ead2]

        android: Drop redundant check for SDK version <= 11
        
        minSdkVersion is 16.
        
        Change-Id: I1082cc5abd7ecc02211509e57fd41c97cf706e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133427
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [2cb23f6ff94a7ad466cd035df2f6519a7dbd0b57]

        ofz#47029 Timeout
        
        Change-Id: I0fe3a01b237eb142b9e156fc886144f48f8ede18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133436
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [a32bd25acf541168c332d18e44be3a4ab558deec]

        cid#1504074 silence Improper use of negative value
        
        Change-Id: I4580d4cce8a53f2b1faf0738d08509d2730868df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133431
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [2fa07953a6dfdcdbb4d214b289fe17a93f40f643]

        Translatable string improvements I push so they don’t rot in my local clone
        
        Change-Id: Ic057769718790ced80daf24510d27aad49e3341b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132975
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [c3d89622b18b600ceff4fde964567b269fed2484]

        use a std::vector here
        
        Change-Id: Ic5ad467bc6f1f8537d17be4bec3a92be947239a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [fb8b077e220ad8477ebc7feeb37d9d8356ec82aa]

        unnecessary dtor
        
        Change-Id: Ia2a5cf38930e394c4aecdd83fb18fc2a212df067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133432
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f1dc51468137971295393ab438b57fe5f77c1420]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79333af5db2af7c4532e8fffbebfe8ba7daa80c4
          - list toolbars in alphabetical order in Contents menu
            
            Change-Id: I13f64d384b51f02a73c3e0bb321caa9df9fef4ed
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133289
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [c0ec38fe54499b9d9940a85d3592671bc543958f]

        revert unnecessary change
        
        from
            commit 25ada1e520b50247aa27fdbb6f1ab35e678c7ef9
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Apr 21 13:59:07 2022 +0200
            use more string_view in cppuhelper
        
        Change-Id: Ie5bd9226dca0f222edd0798b8b478054eda5162c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133430
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-26  Miklos Vajna  <vmiklos@collabora.com>  [6f60a89a6be85d4cbe5840f9d0146eae98dbf543]

        sw content controls, checkbox: toggle the checkbox on click
        
        Implement this by selecting the content control's text (similar to
        placeholders), then replacing the selection with the content control's
        relevant state.
        
        Change-Id: I280ce45822fe3fd9615511a9a62d23dc230aa275
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133424
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [0aaa964224be38323e4f9e456655da2a8b4c2b66]

        tdf#148751 Enable Text toolbar by default in Draw
        
        The "Text" toolbar is not visible in the View - Toolbars menu, however it is accessible via Tools - Customize - Toolbars.
        
        As per user request in the bug report, I am setting this toolbar as visible in the default configuration.
        
        Change-Id: I1d2249925f24158758bd9f439634191d67ad38e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133395
        Tested-by: Jenkins
        Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [8f5141cea04430592cc4d47acac2cbf6b508d3ef]

        cid#1504268 Silence false data race condition warning
        
        Change-Id: I058a0f9d2e3c7434b5dc742c82067cb97c6102d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133425
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [cda53485ec0f2c666c86c0ac99e7af4b0f2b352f]

        ofz#46906 Integer-overflow
        
        Change-Id: Ic4c6b34b8fb2ddfbb606871f48e2b504fd24336d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [675788b208a7c775f8eaa51cd90528b1bb92ed79]

        Extend UNO API for custom jump lists
        
        * Allow to display the recent/frequent files
        * Allow adding items to the "Tasks" category
        * Allow adding multiple categories
        
        Follow-up to 7efd22c912262f7bf4e4735dae70db0b31ab3d5b
        
        Change-Id: I860d44c1a0d9bc8200529c908b6103741dc37bb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133367
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [90057e372cd07b41c8dbba4e7b7f107568a5f451]

        Related: tdf#148433 test if CAIRO_OPERATOR_DIFFERENCE is the problem
        
        export SAL_DISABLE_CAIRO_DIFFERENCE=1 to experiment with this
        
        Change-Id: I61ec30c818727cb6ab382b4cf9fe9bd29d8d179d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133419
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [44cab8856db1a2b5cbf09522b513d876c491a7e9]

        ofz: Use-of-uninitialized-value
        
        the msan flags aren't getting passed in
        
        Change-Id: Ib79c63cf559be9b11e19e2f8b11fd56b44665c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Stephan Bergmann  <sbergman@redhat.com>  [4049fe21481fe0bbce52f3fd9f09952d1e112e2d]

        Two more uses of rtl::createUriCharClass
        
        ...that 6a9f342addf8b1c766163575c7b63e7fcc1f714e "Introduce
        rtl::createUriCharClass" had missed
        
        Change-Id: Id37399cb88df25aff22d42e889aea12c1ca90797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133423
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [82e789bfc8c215a7b27d4ca8d6567590717168da]

        sw: show Manage Changes dialog for read-only documents too...
        
        ... and also the panel in the in sidebar, to allow navigating the
        tracked changes.
        
        Disable all the Accept/Reject buttons if document is read-only.
        
        This appears to work, even when switching between 2 documents, one
        editable and the other read-only, with the dialog open.
        
        Change-Id: I51cce414326d50e86ba2da35c31b87d4b6daf53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133414
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [6e80ee919b9ab3cb4d9f32059b5e213f1885bcc1]

        SwRedlineAcceptDlg: fix inconsistent enabling of buttons
        
        Looks like some were forgotten in some places.
        
        Change-Id: I29512e3258789e4f0d51c64ae793c56ce72fabd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133415
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [404c51f3664ffd4f7e2c1c8bb8a12ac70954fec2]

        officecfg,unotools,framework,sfx2: store ReadOnly for recent docs
        
        Add Office::Histories::HistoryItem::ReadOnly flag to configuration so
        that a document that was opened read-only isn't opened as editable from
        recent documents.
        
        Change-Id: I6985da287d3337a53a7e41e8e500421038eedb91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133385
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-26  Michael Stahl  <michael.stahl@allotropia.de>  [c51ef466f736c9e0e192d2c7feeda0a39bca2011]

        officecfg: deprecate Office::Histories::HistoryItem::Password
        
        Appears not to be set anywhere in the code, which is probably for the
        best; let's deprecate it.
        
        Change-Id: I2cb1d4095773819dfa602b0e2f71e83f1329011d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133386
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-26  Jean-Pierre Ledure  <jp@ledure.be>  [baa1583a7b9b8a4ea5859e4fc320e570f2d10741]

        Access2Base - (access2base.py) FIX remove duplicate
        
        In class _Module, the ProcStartLine item is defined
        both as a property (by its presence in classProperties)
        and as method
           def ProcSTartLine (...):
        
        This is of course irrelevant.
        
        The property must be removed and the method kept as is.
        
        Bug signalled by Paul M on Telegram.
        
        Change-Id: I33bec829244543dbbd88b53e35cdff6c5468692f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133388
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-26  xuenhua  <xuenhua2008@sina.com>  [37613bffe4621c444e5a34678bafb2c3a875263d]

        Fix for xcode-ide-integration
        
        'make python3.all' was renamed to 'make python3.allcheck' (or use 'make python3.allbuild' to build without unit tests)
        
        Change-Id: I5923382595deb952d3760a6173d40614e8ad5043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133343
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-26  Gabor Kelemen  <kelemeng@ubuntu.com>  [ffcd599c4f28ca4cfdd7e1505cd5aa5eb68cc32b]

        Drop obsolete workaround for LanguageTool 1.7
        
        Upstream patch for this issue was integrated for LT 1.8:
        https://sourceforge.net/p/languagetool/bugs/105/
        some 10 years ago.
        
        It should be safe to drop this workaround now that LT 1.7
        was dropped from core.
        
        Change-Id: I4ffec2247bcb6445cfcdb1c19018bdddec712c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133357
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-26  Gabor Kelemen  <kelemeng@ubuntu.com>  [f0ba8e43da0cbf4d47f18ec2adce2173176d1bef]

        Drop unused LanguageTool extension
        
        Do not bundle LanguageTool which is at a 10 year old version (1.7)
        while upstream has a lot of new releases (now at version 5.5.x)
        It is not bundled by any downstream distributions
        so it makes no much sense to keep it integrated here.
        
        Change-Id: Icd2ef151b1b8d0252ffa3db0caaba576f2783fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133356
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-26  Gabor Kelemen  <kelemeng@ubuntu.com>  [437b3b9d4ffc1cfba3bcc9dff1a72fe2656e3b30]

        Drop unused CT2N extension
        
        It is not bundled by any downstream distributions
        so it makes no much sense to keep it integrated here.
        
        Change-Id: I80180e53e050b8b3cd1b173ef01b51e8d706f295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133355
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-26  Caolán McNamara  <caolanm@redhat.com>  [2739f18fa93733a128321255aa49ddbefde36314]

        CAIRO_OPERATOR_DIFFERENCE define should have followed its usage
        
        when that was moved to here
        
        Change-Id: I34565d3568c7e75a9f0abac94360e3ff769afbd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133418
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-26  Laurent BP  <laurent.balland-poirier@laposte.net>  [fd9d71d7706adcbe1191b09c8ba252d2b4dfb50e]

        tdf#143956 Remove page size of Writer templates 3
        
        This patch concerns "offmisc" templates:
        - Businesscard-with-logo:
          - use predefined style names to have them automatically translated
          - use automatic date format according to locale settings
          - update preview
          - remove useless duplicate code and unused styles
          - contributor's name to top to fit in A4 and Letter formats
          - remove 1 empty line in table to fit in Letter format also
          - remove useless stuff in settings.xml file. Keep these fields,
        because if certain settings are MISSING, xmlimp will consider the file
        in old format (thanks to Justin Luth)
          - reindent xml files
        
        Change-Id: Ie1b35fe420dbb445cb5070b8a3726c40184973ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121267
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>

2022-04-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0bae88a9cd47185a71cbfd4c86bbd86ae44d30e]

        tdf#147586: Initialize mbBulletColorFollowText to false
        
        Otherwise, once it's set to true, it's never reset
        
        Change-Id: Ie8a752da4162775f40c2f84f480e6a103eb55942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133422
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [7678e7ed88007061c3469db3b28b0e91acea7ed6]

        rtf filter: reduce memory allocations count
        
        RTFValue in most cases contain only one value: either num, string,
        picture, etc. No reason to allocate all of them in the same time.
        
        RTF filter should became faster and consume less memory, however I
        did not made any measuremets.
        
        Change-Id: Ic12a941ce774b9066d7c57b38139af07851ac7b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131720
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-26  Justin Luth  <justin_luth@sil.org>  [4529690cf65f621554f3c829c04b579bd11989c9]

        tdf#132475 sw ms: import/export DI_CHANGE as field
        
        and (only) the AUTHOR portion as FIXED for DOC/DOCX/RTF.
        
        The SAVEDATE import was failing as a field because of exception
        writerfilter/source/dmapper/DomainMapper_Impl.cxx:6950:
        Exception in CloseFieldCommand() com.sun.star.lang.ServiceNotRegisteredException
        message: "unknown service: com.sun.star.text.TextField.DocInfo.Change
        at /persistent/git/libreoffice2/svx/source/unodraw/unomod.cxx:191"
        
        In terms of marking the field FIXED:
        MS Word doesn't update the save date while the document is being edited
        (although a user could force an update via F9)
        but it does update the field at FILEOPEN!
        
        So, since it updates the date on FILEOPEN, it makes perfect sense
        to treat this as a normal SAVEDATE field in LO - not fixed at all.
        At opening time, it will ignore the last-displayed-text
        and load the values from the field just like Word.
        The difference will be that it updates the field immediately
        after a while-editing-save, but that's fine, because when Word opens
        the same file, that is what it will see.
        
        However, curiously enough, MS Word does NOT update the LASTSAVEBY user,
        and thus the modified author can be set as FIXED,
        with the normal caveat that a LO user won't be able to update
        the field (except by deleting and re-creating it).
        
        Change-Id: I5640432708cf3eebb6a60eaa500fdf0b8f3a6e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133209
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-26  Miklos Vajna  <vmiklos@collabora.com>  [7f5d7a3cbe4a71a44a273c9599df1a5094b2fc5a]

        sw: document HtmlExportTest
        
        sw/source/filter/html/ is a mix of HTML import and export, but
        SwHTMLWriter is the entry point on the export side.
        
        Change-Id: Ia95c4c342ad5677d286b28d69f89fd88aa801129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133417
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [8b646cf931543093ba27e7aed7c8206d4b647a6d]

        natvis: some extra patterns for SvRefs<...> and writerfilter
        
        Change-Id: I077232d641fee38da0f50cb838091c0fd0787189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133416
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [67d8c245daf7c6ee33e908255f2bbd0ea8d08206]

        loplugin:stringview
        
        Change-Id: I4bd3efe67217a4c4418cf308cc8e7a55cf4a604a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133390
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [8e77be57024fa9422db2dddce7c0c7ef4302a3c2]

        loplugin:stringviewparam
        
        ...and loplugin:stringview(param) follow-ups
        
        Change-Id: I5ccb5c7b246a35aefb43c8f608d781b753f9830c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133392
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [f12448ce5f6fdccdaccfeed76b1ec22cccdcddec]

        loplugin:stringview
        
        Change-Id: I60b37ab39662c485855894642484b6d093070519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133391
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [34c1c57dc38b62036e8d68b0adec442c11f2cc5d]

        oox: Remove obsolete TODO
        
        This can go after 1c924efe1f80207a5e104d755615b1eb9a91d418
        < tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor
        properties >
        
        Change-Id: I9b9540cf0cdcd9ecbb39b92fe24b83a1810df7da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133382
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e4bdf75260169898f3204cae7071d91da5946e09]

        tdf#75263 - Export VBA-Project using detected charset on import
        
        Change-Id: Ia1f1bb31e077dcb4293c1106ac324a25a975a656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133064
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [2bb3587f5e7b1ee1fcb7163419c21144258ebf00]

        character dialog contents jumping around a little when label contents change
        
        Change-Id: Icc49b7b6a9163c769e80eb04dd4b725aaa725a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [0b674bda2564b10e65c12b26f1e610a1b4ef5bdc]

        repair mangled sizegroups
        
        Change-Id: I51b52fa160bca38f158e5e7aec5386ffdb286fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133383
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Justin Luth  <justin_luth@sil.org>  [115599cc3478e37879cd2fa0b6c6c9dabde7dfd1]

        tdf#132475 writerfilter: use proper date-field defaults
        
        When a field doesn't specify the format for a date,
        the system is free to implement it as it chooses.
        However, the user tends to disagree with that,
        so lets try to create a MS-similar default for
        these dates - since LO defaults to only displaying
        a date without any time component.
        
        For example: PRINTDATE \* MERGEFORMAT
        doesn't tell us how to display the date.
        
        MS Word uses different defaults depending on
        the language of the document. And that only make sense.
        For example, I noticed that of course en-GB's format
        is dd/MM/yyyy instead of en-US's M/d/yyyy.
        
        As a documentation example: 17.16.5.47 PRINTDATE
        Syntax: PRINTDATE [ switches ]
        Description: Retrieves the date and time on which the
        document was last printed, as recorded in the
        LastPrinted element of the Core File Properties part.
        
        Switches: Zero or one date-and-time-formatting-switch
        and zero or one of the following field-specific-switches.
        
        PRINTDATE (without any formatting switches)
           the results are:
        1/6/2006 2:58:00 PM
        
        Change-Id: I41f3bdc155bd8cdc74177e4626b31ece9b47e16b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133208
        Tested-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-25  Julien Nabet  <serval2412@yahoo.fr>  [fd4410aa5fd079e4277297f1fb70ad8c728e7a17]

        tdf#145240: Can't save drawing if I'm adding a short freeform line with no fill
        
        Here are the steps of the dup tdf#148693:
        1. Open a new sheet in LibreOffice Draw
        2. Select the tool Shape/Insert/Curves and Polygons
        3. Draw a short line (I mean very short)
        4. Click "File" > "Save" and select a random place to save
        
        =>
        1  0x00007fcd3c774fcb in o3tl::doAccess<com::sun::star::drawing::PolyPolygonBezierCoords>(com::sun::star::uno::Any const&) (any=
              uno::Any("[][]com.sun.star.awt.Point": uno::Sequence of length 1 = {uno::Sequence of length 2 = {{X = 0, Y = 0}, {X = 252, Y = 0}}})) at include/o3tl/any.hxx:284
        2  0x00007fcd3c74f759 in XMLShapeExport::ImpExportPolygonShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, XmlShapeType, XMLShapeExportFlags, com::sun::star::awt::Point*)
            (this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *) 0x7bcb3a8, eShapeType=XmlShapeTypeDrawOpenBezierShape, nFeatures=15, pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:2342
        3  0x00007fcd3c74d952 in XMLShapeExport::exportShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, XMLShapeExportFlags, com::sun::star::awt::Point*, SvXMLAttributeList*)
            (this=0x8770560, xShape=uno::Reference to (SvxShapePolyPolygon *) 0x7bcb3a8, nFeatures=15, pRefPoint=0x0, pAttrList=0x0) at xmloff/source/draw/shapeexport.cxx:811
        4  0x00007fcd3c75cca1 in XMLShapeExport::exportShapes(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, XMLShapeExportFlags, com::sun::star::awt::Point*)
            (this=0x8770560, xShapes=uno::Reference to (SdDrawPage *) 0x2d6b258, nFeatures=15, pRefPoint=0x0) at xmloff/source/draw/shapeexport.cxx:1006
        
        Change-Id: Ie6d626999bf606f951f4f79a7c314559a9a886f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133273
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [e63e769bd30800b72f4a1cdfc7222c0b64f3c770]

        Introduce a better mechanism to suppress false loplugin warnings
        
        ...by annotating occurrences of false warnings with [-loplugin:<name>] comments
        in source files and letting individual plugins opt-in to watch out for such
        suppression annotations, rather than maintaining lists of excluded source files
        in the individual plugins.  (See the new loplugin::Plugin::suppressWarningsAt.)
        
        Instead of making all calls to loplugin::Plugin::report check for suppression
        annotations, the intent is that this check will only be added opt-in to those
        places in the plugins that are prone to emitting false warnings.  In general it
        is better to have plugins that don't produce false warnings in the first place,
        or at least let those warnings be addressed with trivial and harmless source
        code modifications, avoiding the need for any suppression mechanism.
        
        As a proof of concept, I have removed the exclude list from
        loplugin:redundantfcast and instead annotated the relevant source code.  (And
        thereby found that three of the six originally excluded files didn't need to be
        excluded any more at all?)
        
        For now, this mechanism looks for comments (both //... and /*...*/, even
        documentation-style /**...*/) that overlap the current and/or the preceding
        line, because at least for code controlled by clang-format it is often easier to
        move comments to a line of their own, preceding the commented code.  Looking
        also at the current line (and not only at the preceding one) opens the door for
        erroneous over-eager annotation, where an annotation that was meant to address a
        false warning on the current line would also silence a potentially true warning
        on the following line.  This probably doesn't cause much trouble in practice,
        but is up for potential change.
        
        Change-Id: I91ce7a0e5248886a60b471b1a153867f16bb5cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133365
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Julien Nabet  <serval2412@yahoo.fr>  [176021427fece6363df56022b63813e93505fdc2]

        tdf#136429: use FieldUnit value for min/max of some fields of numbering dialog
        
        Change-Id: I01428703a7bdb2090fd145e5373c37aff0d386ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133348
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [9500e2d971150e0555980a7ae73da014ad83c95c]

        tdf#148654 stop playing sound with presentation ends
        
        Change-Id: I74aa4cd966b6966f7826d241fcf9bb9d64955464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [cf1a41c45abd28fb8ef5613338fcb9807d244f9d]

        Resolves: tdf#141441 get and set selected entry when "unfrozen"
        
        Change-Id: I4229460fb27ae3dc133c0f6a53c7792a87bf4db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  László Németh  <nemeth@numbertext.org>  [b97116791047f89b768ab4aa8126e543df826be3]

        tdf#141391 sw: don't paste as nested table in first cell paragraph
        
        Paste table content overwrote cells of the row(s) only if the text
        cursor was at the beginning of the table cell, otherwise the table
        cells on the clipboard were inserted as a nested table.
        
        This was a UX regression from commit 7600a2942ce2b9dac66836105bed6620d55abec2
        "fdo#37156 insert table copy as nested table in non-starting cell position"
        especially when the user clicked not exactly at the beginning of a
        cell, which containing a 1-line text or data.
        
        Since commit 1e278d1d0cfb1d5375195aa764739f00633f21e8
        "tdf#37156 Writer menu: Paste as Nested table" it's possible to
        force nesting (but not overwriting yet), this commit revert partially
        commit 7600a2942ce2b9dac66836105bed6620d55abec2: if the text cursor
        is there in the first paragraph of the cell, Paste table content
        overwrites the row, not embedding a nested table in the cell
        at the cursor position. This change results also better interoperability
        with the existing document editors.
        
        Note: table and text selection were checked with the change, too.
        
        Details:
        
        Heuristics to allow copying table rows or nesting tables
        without using Edit -> Paste Special -> Paste as Nested Table:
        
        At "table selection" (i.e. when cell(s) completely selected),
        or if the text selection starts in the first paragraph, or if
        there is no selection and the text cursor is there in the first
        paragraph, overwrite content of the cell(s). Otherwise insert
        a nested table, i.e. if nothing selected and the cursor is not
        in the first paragraph, or the selected text doesn't contain
        the first paragraph of the cell.
        
        Change-Id: I7746c6a464123bef6fb7dbff415ff0414e48365d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133377
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [0609ee7ec0748b85bcc2b741c73b5f2cbb2f35d1]

        ofz#46794 Timeout
        
        Change-Id: I58bfdbe4bab0ee8b7ff49f937711dff649392bbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3bbc4581b9af37dbc5adbc355633641d60575c30]

        tdf#126672 Add search field to extension manager
        
        Change-Id: Ie5c44e79cff236c5d306c34492a5c6c789d6fb60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133381
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [f6be6cd82bd84f13d2a597ceb62181111ae0eb80]

        external/firebird: Missing include in configure check
        
        ...so that with Clang 15 trunk after
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning" the
        check now failed to compile with
        
        > configure:21471: checking alignment of long
        [...]
        > conftest.c:177:3: error: call to undeclared library function 'exit' with type 'void (int) __attribute__((noreturn))'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >   exit((int)&((struct s*)1024)->b - 1024);
        >   ^
        > conftest.c:177:3: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
        
        and an exit code of 1 from the compiler invocation, which the check than
        silently mistook as an alignment requirement of 1.  (Which then caused the
        somewhat obscure fallout of
        
        > workdir/UnpackedTarball/firebird/src/gpre/msc.cpp:463:10: runtime error: member access within misaligned address 0x7f59d8e68196 for type 'gpre_sym', which requires 8 byte alignment
        
        while building ExternalProject_firebird with UBSan.)
        
        The corresponding "checking alignment of double" a few lines further down had
        already been modified in ccd0e5f445d4a7d0e7aca6c23c02c61bf14510b2 "Make firebird
        build for macOS on arm64", but without stating what actual problem (if any) it
        fixed.  I thus moved that patch into the new
        external/firebird/configure-include.patch too, to have them grouped together.
        
        (An alternative fix could be to replace the use of exit with return from main
        in those configure checks.)
        
        Change-Id: Iefa02a06d45c83add5f56fad5d726aaecee6d815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133368
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Gabor Kelemen  <kelemeng@ubuntu.com>  [dec2c5f3ca4d149bf5fefd573a5e64c650b61b19]

        Recheck module chart2 with IWYU
        
        See tdf#42949 for motivation
        
        This time using the new --noexclude switch to recheck validity
        of the excludelist; these were the obsolete exclusions
        
        Change-Id: Ifdf79b30ebaf198082c2194611a2ed2b664e6f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133309
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [14b39046ab70d71bf434f4a44b628d3f2c2bde12]

        Update to glade 3.38.2
        
        Change-Id: Ia57eef82cd74e14aa9f09143dcc0e5101eab9949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133380
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e156cd6610bf8cfe5097498f2223bbfd26819937]

        use string_view in CompareProtocolScheme
        
        Change-Id: I3584042d0341d5c1b4f4e742e25e9eb0aa26f1da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-25  Laurent BP  <laurent.balland-poirier@laposte.net>  [ace2e40a5b89967e247db1ebe9da65d41706d446]

        tdf#143956 Remove page size from Draw templates
        
        Update BPMN template:
          - content.xml:
        	remove lang and country tags
        	remove asian and complex tags
          - meta.xml: indent and add title to enable translation
          - styles.xml:
             change style name to English to get automatic
        translation
             remove lang and country tags
             remove page size
        
        Change-Id: I23058c63dbc13fa66a1138c20e9840a360b72ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132647
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [8ad7603c7c6ba327ff1e836e023c2ad0ab529d53]

        vector is a little faster than deque here
        
        Change-Id: I0471143b13ea8113919ed71abe956f27729cecad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133372
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Miklos Vajna  <vmiklos@collabora.com>  [70c8e6abc0a4ed4a2c7a948ee206ba9d4cffd22b]

        sw: make it easier to look up an uno command from a slot id
        
        This way if I see a slot id 20456, then searching with
        
        	git grep define.*20400 include/ */inc
        
        finds FN_FORMAT, and searching with
        
        	git grep FN_FORMAT.*56 include/ */inc
        
        finds FN_FORMAT_FRAME_DLG.
        
        Change-Id: Ibda8b131f73c81221569618cda33e52b03448feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133374
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-25  Stephan Bergmann  <sbergman@redhat.com>  [02311766135700f8dd8528cc7cacda636c8f304d]

        external/openldap: Don't use pthread_get/setconcurrency without declarations
        
        At least with glibc on Linux, those two functions are only declared in
        <pthread.h> when _XOPEN_SOURCE is defined.  And with
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning" in
        Clang 15 trunk that now causes hard errors
        
        > thr_posix.c:93:9: error: call to undeclared function 'pthread_setconcurrency'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >         return pthread_setconcurrency( n );
        >                ^
        > thr_posix.c:107:9: error: call to undeclared function 'pthread_getconcurrency'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >         return pthread_getconcurrency();
        >                ^
        
        (vs. just silently ignored warnings) when building ExternalProject_openldap.
        (And the way the corresponding AC_CHECK_FUNCS in
        workdir/UnpackedTarball/openldap/configure.in works, it always set
        HAVE_PTHREAD_GET/SETCONCURRENCY because it effectively checks for availability
        of the symbols in a library, not for declarations of the C functions in an
        include file.)
        
        But if we explicitly define _XOPEN_SOURCE, we now also need to explicitly define
        _DEFAULT_SOURCE or _BSD_SOURCE (which is otherwise implicitly defined by default
        in glibc's features.h if no other such macros are defined).
        
        Change-Id: I148d50c82ee2efc2a54f2cf4f84dead3941a3568
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133312
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-25  Miklos Vajna  <vmiklos@collabora.com>  [cd2272874d1b1911dec6c6e7bf3d67861be4a015]

        sw content controls, checkbox: add document model & UNO API
        
        Add 4 new properties: if this is a checkbox, and is so:
        
        - if it's checked
        - unicode value for the checked state
        - unicode value for the unchecked state
        
        This should be enough for the UI to be able to update checkmark state on
        click.
        
        Change-Id: I723532fd2d3377cf09a1127c69c55f9539649088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133363
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-25  Michael Stahl  <michael.stahl@allotropia.de>  [98ae340307786c8fe18addc3714c9b859fdf12dd]

        tdf#135978 sw_redlinehide: recreate fly frames anchored to subsequent nodes
        
        ... in SwTextNode::JoinNext().
        
        The 2nd node is deleted, so its frame is deleted, and if it is the start
        of a merged frame, fly frames on the node itself will be recreated
        already, but those on subseqent nodes need an extra call.
        
        Change-Id: I18999946334f5560b720d3d275610bc8b07973f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133335
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-25  Caolán McNamara  <caolanm@redhat.com>  [870ee667daa08bea0a60de40b13135da73e71e4c]

        ofz#46905 Null-dereference
        
        Change-Id: I26427ee1e010ce79e40c550459d9f53598570a7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133360
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-25  Miklos Vajna  <vmiklos@collabora.com>  [fe672dc74231c275a0b5593448f26d26b658743b]

        sw: prefix members of WW8_WrPct, WW8_WrPlc1, WW8_WrPlcField and ...
        
        ... WW8_WrPlcFootnoteEdn
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie49a167ca443216322a2038d4d6568d43736019a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133361
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-25  Gabor Kelemen  <kelemeng@ubuntu.com>  [655e5d4406e15774a76c945a57700d21516813c1]

        find-unneeded-includes: bail out early if no files are found with --recursive
        
        Change-Id: I5bd726b33e4fc7068baad91ff185763274307b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133308
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-24  Hossein  <hossein@libreoffice.org>  [45aac5b97192a97369c7785772ce7400d9ea8abc]

        Remove brittle test from WmfTest
        
        The WmfTest::testStockObject() contained test for the number of
        children in the metafile dump. This can be changed when unimplemented
        records are implemented.
        
        The problem was revelead while implementing SetPolyFillMode record:
        <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/112114/>
        
        xmltesttools.cxx:234:WmfTest::testStockObject
        equality assertion failed
        - Expected: 42
        - Actual  : 47
        - In <>, XPath '/metafile/push[2]' number of child-nodes is incorrect
        
        Change-Id: I627801b7ac535a2f0c736880d9675f3d0136136a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133353
        Tested-by: Jenkins
        Reviewed-by: Hossein - <hossein@libreoffice.org>

2022-04-24  Regina Henschel  <rb.henschel@t-online.de>  [3d7466b92a450d7ca4f45fef9a664143fbb3c386]

        Do not start a:path with lnTo in export to OOXML
        
        This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2
        
        The commands A, W, T or L of a draw:enhanced-path draw a line from
        current point to start of the arc or end of line, respectivly. If
        there is no current point the path is faulty and behavior is not
        defined in ODF.
        
        LibreOffice is tolerant and makes a move to the start point of the
        arc or to the end point of the line. With this patch we do the same
        now in export to OOXML, so the user gets the same shape geometry as in
        LO. If a path starts with lnTo, MS Office will show nothing.
        
        I wouldn't care about user-created faulty paths, but LO produces such
        faulty path when an EllipseRibbon shape from binary MS Office is
        imported. Even when that will be fixed, we need the fix here, because
        the faulty path had been written to document markup and will be used
        when such document is opened.
        
        Change-Id: Ic52ec3bc78231b26efb592ddadee2e3042fdc065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133349
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-24  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [8202df1815ed692df371e6d07a3b0f29a329f6ed]

        tdf#103859 EMF+ Use variable types according to EMFPLUS documentation
        
        With this commit, the types of variable for Brush and Pen
        were aligned to documentation:
        [MS-EMFPLUS] - Enhanced Metafile Format Plus Extensions
        
        As a side effect the code was simplified a bit
        
        Change-Id: Ibabad628d0aaef510f61ee8b3d881c3f024cebef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133327
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-04-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [eaab20c304882d26b9593edab402d64cc55c2df3]

        Fix typo
        
        Change-Id: I85013e2fc1150b1830fa21da7ed77ac95ff7452e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133352
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-04-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [f775b625b497b4fa6731bddd433916dde52fbb2e]

        find-unneeded-includes: add --noexclude argument
        
        To ignore the excludelist, thereby checking if its exclusions
        are still valid.
        It may happen that some refactorings make an exclusion obsolete.
        In this case the IWYU suggestion to remove a now-really-unnecessary
        header would be ignored forever.
        
        It makes sense to use it after a full cleanup of a module in normal mode.
        
        Change-Id: I8216a79ea2354ab428d6ce7a56a49e5cf67056fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133307
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [fef939d8ffd17abdb108a5e5635790a862018c2d]

        Recheck module chart2 with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: Id4cdca3eed8618c289f30913d506f8f2bd46f0bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133112
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c4d3188bb34c24f611bd4d5e94376d4734dd8c3]

        Fix typo
        
        Change-Id: If2bc62044609ef173ac147196a9f78363db002eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133345
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6aec08a3dd4207edd65f076412ff58ca49c210c3]

        tdf#148591 rename two Vertical positioning regions
        
           Page text area top --> Above page text area
           Page text area bottom --> Below page text area
        
        Change-Id: I3a63ec09e6a3dfbd51385139ea89454bd1792a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133288
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-22  Stephan Bergmann  <sbergman@redhat.com>  [8279d89d6e037def78f50c72fab2116ca56bef52]

        external/libassuan: Fix fallout of defining __STDC__ on Windows
        
        ...since 1bb0e177124d5d6661b72df6c7d848fb23639652 "Fix autoconf>=2.70
        gcc-wrapper breakage", which had the side effect of preventing various
        deprecated function declarations in system headers (e.g., isascii in addition to
        __isascii).  This went unnoticed so far due to the traditionally lax handling of
        missing function declarations in C, and only now started to cause
        
        > conversion.c(94,9): error: call to undeclared function 'isascii'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >           if ((isascii (*istr) && isprint (*istr)) || (*istr >= 0x80))
        >                ^
        
        etc. with clang-cl 15 trunk after
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning".
        
        Where undeclared functions have been used in Windows-only code, they have been
        replaced with their __STDC__-declared counterparts, and for occurrences in
        shared code Windows-only macro definitions have been introduced (as would have
        done in the system headers too, if __STDC__ was not defined) to not clutter the
        shared code with #ifdefs.
        
        Also, for getpid (resp. _getpid), the #include <process.h> was apparently
        missing from the upstream code, even without our __STDC__ hack in
        external/libassuan/ExternalProject_libassuan.mk (but never caused errors until
        now, either).
        
        Change-Id: I7442394d0c6e633bca1f6c7331d7ee51651179a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133339
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-22  Stephan Bergmann  <sbergman@redhat.com>  [b212163587524f723c737d698919cb4fe4e547e6]

        external/gpgmepp: Missing includes (Windows)
        
        > gpgme-w32spawn.c(288,8): error: call to undeclared function 'open'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >   fd = open (trans_file, O_RDONLY);
        >        ^
        
        etc. with clang-cl 15 trunk after
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning",
        which went unnoticed so far due to the traditionally lax handling of missing
        function declarations in C.
        
        Change-Id: I805ab10d2b0aae3f8b1f46ffeda57aff2bbcef2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133340
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-22  Stephan Bergmann  <sbergman@redhat.com>  [350c733a033c3ca233a445b5dda38e1fa64f0c9e]

        external/libgpg-error: Missing include (getpid, Windows)
        
        This was apparently missing from d400009e7c74d13f01fda923d7399eac11b83b66
        "gpg4libre: update gpgme, libassuan and libgpg-error" but went unnoticed so far
        due to the traditionally lax handling of missing function declarations in C, and
        only now started to cause
        
        > logging.c(845,57): error: call to undeclared function 'getpid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        >                                           (unsigned int)getpid (), pidsuf);
        >                                                         ^
        
        with clang-cl 15 trunk after
        <https://github.com/llvm/llvm-project/commit/7d644e1215b376ec5e915df9ea2eeb56e2d94626>
        "[C11/C2x] Change the behavior of the implicit function declaration warning".
        
        Change-Id: I66dc409f629d9bda807bc9cca21a8a5ecdda79be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133338
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-22  László Németh  <nemeth@numbertext.org>  [89c34706331984d12af8ce99444d53f19b40b496]

        LibreLogo: add basic HTML formatting support to LABEL
        
        It's possible to format character spans in text
        of LABEL, as bold, italic and underline text
        using HTML tags <B>, <I> and <U> and their
        lowercase equivalents. For example,
        
        LABEL '<i>Italic, <b>also bold</b></i> and <u>underline</u>.'
        
        Use HTML "&lt;" to avoid of the replacement. For example,
        
        LABEL 'some &lt;i>text&lt;/i>'
        
        prints "some <i>text</i>" instead of "some text"
        with italic "text" in it.
        
        Change-Id: I70fd97763c6c488eba23c168a541b84cff0c90e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132786
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1c924efe1f80207a5e104d755615b1eb9a91d418]

        tdf#148685: Unset CharUnderlineColor and CharUnderlineHasColor properties
        
        Change-Id: Iebf482434cd393f55ae3e4690580b573624d78b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133219
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-22  László Németh  <nemeth@numbertext.org>  [0204c00f241313e1d292b4c3ea117d42af7dec69]

        tdf#147453 sw: disable Delete Table functions on tracked deletions
        
        In Show Changes mode, disable "Delete Selected Rows" icons
        and the same menu options in the following cases:
        
        - no table selection, but the text cursor in a deleted table row;
        
        - with table selection, all selected cells in deleted table rows.
        
        Disable also "Deleted Selected Columns" and "Delete Table"
        icons and the same menu options, when the cursor is there
        in a deleted table.
        
        Follow-up to commit c4f6fee3bea0d8618b5815e60304ff9359ccd21c
        "tdf#147435 sw: enable Accept Change for table selection".
        
        Change-Id: Ic6781ccee794c7458e6979f2e981840339cd3883
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133320
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [9c8029866146b43014ecc7b08f7cd9b73045844f]

        Update context names to match EnumContext::ProvideContextContainers
        
        Change-Id: Id9bb806ba526a7557cda91ebdeb649578e64517c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133281
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-22  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [abe3a06c45c0803a5c8bcf16e0e586fd72781c93]

        tdf#55058 tdf#143875 EMF+ Don't change line weight while rotating
        
        Previously when TranfromationMatrix was used with rotation,
        the line weight and dashed line shapes were changed.
        In worst case if angle was larger than 90 degrees,
        the lines just disappear.
        
        This patch fixes that. The line looks exactly after rotation
        (with TranfromationMatrix).
        
        The tests were updated (added some additional rotation),
        to prove that now it is working correctly.
        
        Change-Id: Ic2382fa8d1b711a6bf06c94b2d0b9da9e7d396f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133329
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-04-22  Jean-Pierre Ledure  <jp@ledure.be>  [49dfec0a061ca4595a3c5122e92e6a5524cb768b]

        Access2Base - (access2base.py) Don't use bare except: statement
        
        The exception hierarchy described on page
          https://docs.python.org/3.5/library/exceptions.html#exception-hierarchy
        indicates that the default exception in bare
          except:
        statements is BaseException. This induces that the SystemExit,
        KeyboardInterrupt and GeneratorExit are also handled by the
        user script.
        
        This is a not recommended practice.
        
        Better is to use the explicit Exception built-in exception
          except Exception:
        
        Bug reported by Paul M on Telegram
        
        Change-Id: Ie1ae1f732ebc60a881e7d40ba8141aa704e9cd5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133328
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [d5986d1c5f639f21204412ebe4a2a9487088b2f3]

        do not duplicate code for ScCountIfCellIterator
        
        d468958331f36310d11265ba55d7c27366ab58ab improved COUNTIF performance
        by copy&pasting the generic query iterator and then basically removing
        what was not necessary. Which is in general a good way to improve
        the performance, except for the copy&paste part, as the code has
        already started to diverge (e.g. fc3b904b671a71266db2e8b30cbeeef4f79).
        
        So instead make the shared code into a template and reuse that from
        specific code. This has exactly the same performance as the copy&paste
        way.
        
        Change-Id: I168319a1f4273bafc8c0742a114dafbf433968bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133324
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [4af9403cf718207620376b63242f6d0dd047406a]

        move query-related iterators to a new separate file
        
        dociter.cxx/hxx are already quite big as it is, and the query
        iterators are more about queries than about iterating the document.
        
        Change-Id: I49e3a5636e4f366efb8b4968f54567d2716ade35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133323
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Mike Kaganski  <mike.kaganski@collabora.com>  [a09cf7e76a6d90a50a373d04d717897b7f717d54]

        Drop a bit more special-casing for Chart's sidebar property deck
        
        Introduced in commit 2d01ed9e8be543460e41e009fa992103a7c8d4c0
          Author Muhammet Kara <muhammet.kara@collabora.com>
          Date   Mon Nov 25 21:55:31 2019 +0300
            tdf#94288: Show chart props sidebar on activation
        
        The problem was that ChartController::attachFrame, that called
        SelectionChangeHandler::selectionChanged notification, did that
        *prior* to setting its m_xFrame - and the notification failed
        in ContextChangeEventMultiplexer::NotifyContextChange, that
        checks the frame first. That prevented the proper context (with
        correct application and context names) to arrive to listeners,
        and the sidebar didn't update properly.
        
        Changing the order of the calls should fix the original problem.
        
        Change-Id: I9da8465af2ee4ed1f8eabed1c65d1c318f81a3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133326
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [27953931d4f6a8c69b98a90c63db81ebb27cdf63]

        tdf#123381: sw: add table formula INT
        
        for DOCX interoperability.
        
        Change-Id: I4e63e213ef0a6f3a775bdf3bedfb7aca8853b479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133091
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2092e4da40d6767649b5c33761c3698c1f84a6c]

        fix master after string_view patches..
        
        crossed paths
        
        Change-Id: I066b357dc10e2109658194b3b3682b7083ebbbbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133322
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [64cb1d10fffccebbc825c858083f13eb717b0553]

        try to limit cell interpreting to only visible cells when drawing
        
        If there's a document with a huge formula group, InterpretDirtyCells()
        on load will only interpret the range needed for drawing. But then
        scrolling just a bit could result in e.g. IsValue() call on a cell,
        and that could result in unrestricted Interpret() on the whole
        huge formula group, which could be slow. So explicitly interpret
        just the drawn cells in the hope that it'll avoid any further
        Interpret() calls.
        
        Change-Id: I01c9f95cf8a1cf240b798feef27d21010957030c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133306
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [c315a2f7b99fc1dfbc3fc834590d22fbe41ea70f]

        limit Interpret() for dirty cells only to the given row range (bsc#1197497)
        
        ScColumn::InterpretDirtyCells() already takes a row range, and Interpret()
        can take a range inside a formula group, so don't lose the information
        in DirtyCellInterpreter, otherwise a whole large formula could be
        interpreted when just a subset would be enough.
        
        Change-Id: I93e5a7a212976be6fd588de6f68204cd1a271348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133305
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a81b803101f24975877d371c9b53dede9dbaf46]

        Fix typo in code
        
        Change-Id: I289162ed8adf93139bbc69e8f5f4a1444dd52199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133231
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [2b0579fbcc064dbcaf9217feead7ef23ec7a5222]

        remove nonsensical 'over and out' comments
        
        First of all, it's very obvious that a return statement returns,
        so there's little point in commenting that. Second, 'over' and 'out'
        together is Hollywood nonsense, 'over' means "talk, I'm listening"
        and 'out' means "I'm not listening anymore" ... so 'over and out'
        I guess means "talk, I'm not listening" ?
        
        Change-Id: I60a202c78b33bd063c40ef4cd51514f7a2e6c95d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133321
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Justin Luth  <justin_luth@sil.org>  [58cd67e096ca14123a85f8542c728b07645df705]

        tdf#132475 writerfilter: connect PRINTDATE with DocInfo.PrintDateTime
        
        NOTE: This patch depends on a follow-up patch to handle the case
        where no date formating instructions are provided.
        
        NOTE: The time part might be considered a regression by some since
        Word displays as local time while LO seems to display GMT time.
        
        Although the date was being imported as a generic field,
        it wasn't associated with the last printed date.
        
        PRINTDATE is about the only field that MS Word automatically
        updates without the user having to press F9 on it,
        so that shows we should NOT mark it as fixed on import.
        On the other hand, it doesn't update very often, so if a
        user hand-modifies the result, then (without marking it as fixed)
        LO will display differently from MS Word.
        
        Hey, its a last-printed-date field I say. Who cares what
        it looks like on someone else's computer. It only matters
        if it is accurate and visible on yours.
        
        This caused a unit test failure with
        make CppunitTest_sw_ooxmlfieldexport CPPUNIT_TESt_NAME=testGenericTextField
        because contents.match(" PRINTDATE ")
        NOTE: we are losing \* MERGEFORMAT on all of supported fields on export,
        but that might be OK because we don't do MERGEFORMAT anyway.
        
        Change-Id: I7cb79ce7470cd55090a61be63848ce328d48be06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132446
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca1027e7d3a47402a016dba26d12db93b097a856]

        use more string_view in unotools
        
        Change-Id: If32767647d3fba22a8e4a2b10fc57f47efca01d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [08a72cbb06776e83475e70e0ee5d6c0ca572944e]

        use more string_view in comphelper
        
        Change-Id: Ib186d2c9aa8458ddbdd14dd44e2d3938f0f26ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa856bdd2757745f71d2ae1e31e90006a9cdaa4e]

        use more string_view in bridges
        
        Change-Id: I842668655dec102e1595dcbac6413fe2b49d8515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [25ada1e520b50247aa27fdbb6f1ab35e678c7ef9]

        use more string_view in cppuhelper
        
        Change-Id: I846a1201b1b4fb8ca694a0b78b7d4cc2973dfbd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Noel Grandin  <noelgrandin@gmail.com>  [9820f11ad2b1ef32e5527eec519b0a7c766e2602]

        address review comments on "use more string in unoidl.."
        
        on
            commit 2d9291b9433c9645b0870525211f74bfb1151555
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Apr 21 12:53:15 2022 +0200
            use more string_view in unoidl,codemaker
        
        Primarily reverting the findEntity call-chain to use OUString
        instead of std::u16string_view.
        
        Change-Id: Ib01b9473c859bba3791563df753823bbf0a87ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-22  Miklos Vajna  <vmiklos@collabora.com>  [e4d1731ba3e8bac2801d1b76cfb66bf7f9795468]

        sw content controls: add LOK API
        
        This is somewhat similar to LOK_CALLBACK_FORM_FIELD_BUTTON: if the
        cursor enters or leaves a content control, then we send this message, so
        the LOK client can render some kind of shading and/or border around the
        content control to indicate the boundaries of the object.
        
        Similar to selections, this can be multiple rectangles in case the
        string is long enough that the layout breaks it into multiple lines.
        
        Change-Id: I0641a19503b7a1d4cade8fe9b510605cab49f258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133314
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [50774644bbede54784bf710e8f4c527110513361]

        fix an off-by-one error in GetEmptyLinesInBlock()
        
        The function has been there since the initial commit and is not
        documented, but I think it counts the shortest amount of empty
        cells in the given area starting from the direction given. And
        AFAICT the off-by-one error was there since the initial commit,
        when it returned one less if the entire area was empty and
        the direction was vertical (horizontal was fine). And
        ScHTMLExport::FillGraphList() even was adjusted for this until
        my recent commit changing that code). But then ad2bc869bfe2d34bde
        added a shortcut for unallocated columns that didn't have
        the error. And the error even got corrected during the rewrite
        in c008dc483f8c6840803983e7e351cec6fdd32070, but then
        01de94471c20a8b9c36d6080638d70e57eac55bf reverted that. Anyway,
        so fix this, I think all the relevant code should(?) now work
        properly.
        
        Change-Id: I194691f7276a1cea75945de05cb0dda2cdca859a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133319
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Miklos Vajna  <vmiklos@collabora.com>  [de1a94a6f3d10138897befd82ba14b2a897eaed9]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ib4887fb471665cc03fbf0420b9cd05da1a3641fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133313
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-22  Miklos Vajna  <vmiklos@collabora.com>  [1f2a07e06b440ff1b15d66c2a2e72338301cdf0a]

        sd theme: add rendering for shape fill color effects
        
        Only the no-effects variant was working previously.
        
        Change-Id: I50811a4c49d19dc801f0d1c841cbbdb2fae1ad60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133297
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [91e0314d4627b876c82dd81170f093f9f3756b16]

        Colibre: Update Paragraph Style icons
        
        Change-Id: Ie9380913d760fb23fe7f28a415cf7ffd2f1053fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133310
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [79ea331bbd91def54bb8a31ba2acd671fbf4422d]

        fix checking whether a block of cells is empty
        
        The GetEmptyLinesInBlock() call has unclear semantics and it appears
        that it has an off-by-one error. Use a simple clear function
        for the check.
        
        Change-Id: I45d9b73428aedababc1ad93c202daa1de945b5bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133303
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Luboš Luňák  <l.lunak@collabora.com>  [8b5fdf155817d516ce40c203ccbade0c64a5d6e6]

        use range-checked GetCellValue()
        
        Change-Id: Ie02b6be79d1be7481ebcfbc6862295a34e38f7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133304
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-22  Justin Luth  <justin_luth@sil.org>  [e4243a140345a4bcd800217115b42667e277c6a3]

        cleanup writerfilter lcl_ParseFormat
        
        If there is no \@, then we will never match what
        util::findQuotedText is looking for, so don't bother.
        
        Change-Id: I0a6709046673d98d00d74e921d7f502c9df54b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133265
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-21  Luboš Luňák  <l.lunak@collabora.com>  [1768d5705dc72328ae2369fac7fc82437fef4ae1]

        simply return from a loop
        
        Change-Id: I4e10945f32dfb535663ea7392f19532e45ca9ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133301
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-21  Luboš Luňák  <l.lunak@collabora.com>  [9ec0395a0666ce07871b945dcb9a741d2237103b]

        fix off-by-one error
        
        Change-Id: Ic58a896a7a2edf5ba602ab9cfc5a4578fd5d0a56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133296
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-21  Luboš Luňák  <l.lunak@collabora.com>  [4dfdb5a3c9b9ce1eb61c28d8f570398c04fb0d01]

        rework GetColumnsRange() and ScColumnsRange
        
        The problem with GetColumnsRange() was that it was clamping the range
        to the number of allocated columns, but that's not always wanted,
        e.g. ScDocument::InsertMatrixFormula() needs to iterate over the whole
        range and allocate columns if necessary instead of ignoring them.
        From an API point of view it's also not very obvious that something
        called GetColumnsRange() actually does something more than just
        returning the given range.
        
        Handle this by making GetColumnsRange() return the actual given range,
        and add GetWriteableColumnsRange() and GetAllocatedColumnsRange()
        for the specific cases. This also required changing ScColumnsRange
        to work simply on SCCOL value instead of using std::vector iterator
        (since the vector may not have all the elements in the range).
        
        Change-Id: I9b645459461efe6b282e8ac5d7a29549830f46c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133295
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [b68821acc77c774c09ebca8be157a768ea417e04]

        android: Show file chooser despite package visibility filtering in API 30
        
        While it was working just fine in my x86_64 AVD with API level 31,
        opening the the file chooser on a real HW aarch64 device running
        Android 12 no longer worked by tapping on the TextView in
        `LibreOfficeUIActivity` after updating target API from 28
        to 31 in
        
            commit 2ab389b251744fa7f3f6b060c09746e59d87f3b1
            Date:   Tue Apr 19 10:33:27 2022 +0200
        
                android: Update compileSdkVersion/targetSdkVersion to 31
        
        The
        
            intent.resolveActivity(getPackageManager()) != null
        
        check was failing there, so the Activity with
        `Intent.ACTION_OPEN_DOCUMENT` wasn't started there.
        
        This looks like an issue due to package visibility filtering
        introduced in target API level 30. Quoting from [1]:
        
        > When an app targets Android 11 (API level 30) or higher and queries for
        > information about the other apps that are installed on a device, the
        > system filters this information by default. The limited package
        > visibility reduces the number of apps that appear to be installed on a
        > device, from your app's perspective.
        >
        > [...]
        >
        > The limited app visibility affects the return results of methods that
        > give information about other apps, such as queryIntentActivities(),
        > getPackageInfo(), and getInstalledApplications(). The limited
        > visibility also affects explicit interactions with other apps, such
        > as starting another app's service.
        
        From how I understand it, the check is used to make sure that
        there is an app that can handle the Intent, as e.g. the
        "Android fundamentals 02.3: Implicit intents" tutorial [2]
        mentions it for the example using an `Intent.ACTION_VIEW`:
        
        > Use the resolveActivity() method and the Android package manager to find
        > an Activity that can handle your implicit Intent. Make sure that the
        > request resolved successfully.
        >
        >     if (intent.resolveActivity(getPackageManager()) != null) {
        >     }
        >
        > This request matches your Intent action and data with the Intent filters
        > for installed apps on the device. You use it to make sure there is at
        > least one Activity that can handle your requests.
        
        While that sounds reasonable to make sure there is an app that can
        view specific data passed *from* the app (and [3] describes how to add
        a corresponding `<queries>` element to make this use case work),
        it seems to be unnecessary for `Intent.ACTION_OPEN_DOCUMENT`,
        since that causes the system to "display the various DocumentsProvider
        instances installed on the device, letting the user navigate through
        them" and Android presumably at least provides a provider for
        handling local files by itself in any case.
        
        The `Intent.ACTION_GET_CONTENT` case used instead of
        `Intent.ACTION_OPEN_DOCUMENT` for API level < 19 should
        presumably be similar.
        
        Anyway, in case there should still be any case where the
        Intent cannot be handled:
        `startActivityForResult` "throws ActivityNotFoundException if there was
        no Activity found to run the given Intent." [4], so add
        a try-catch block handling that exception instead of the previous
        check.
        
        [1] https://developer.android.com/training/package-visibility
        [2] https://developer.android.com/codelabs/android-training-activity-with-implicit-intent?index=..%2F..android-training#3
        [3] https://developer.android.com/training/package-visibility/use-cases#open-a-file
        [4] https://developer.android.com/reference/android/app/Activity#startActivityForResult(android.content.Intent,%20int)
        
        Change-Id: I7702b100d71333be2d78df1bc81ef2e5a7e016bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133272
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [b68362b178f732f90fdc99073aaa5940bee409bb]

        android: Slightly improve style in use of arrays
        
        Addresses these warnings shown in Android Studio
        for class `LibreOfficeUIActivity`:
        
        * "Unnecessary 'Arrays.asList()' call"
        * "Raw use of parameterized class 'ArrayList'"
        * "Explicit type argument ShortcutInfo can be replaced with <>"
        
        Change-Id: I083e5fcf804209fae704b19643ce80bc92126ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133271
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [6515633aad867dd9e2d59378f3254e292dbdacb0]

        android: Drop unused import and extra semicolon
        
        Change-Id: I19557b0b1d63698a31dac61ce9fde3ce07f86451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133267
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [62524dcf152b274b855005402d082debaa3fc84a]

        android: Avoid using resource ID in switch-case
        
        Adresses this warning shown in Android Studio:
        
        > Resource IDs will be non-final by default in Android Gradle Plugin
        > version 8.0, avoid using them in switch case statements
        
        Change-Id: I8cead0ceb3b71e263b29d4283a8cfac522ed4204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133266
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [a03d7b1871673473b6201a8a15be175d7b65d71d]

        android: Use fake exceptions on all architectures
        
        This was previously only used for aarch64, and the
        workaround does not seem to be necessary in current
        Android versions on other architectures.
        
        However, while it's e.g. not needed on an x86 AVD
        with API level 21 (Android 5), at least my
        x86 AVD with API level 16 (Android 4.1), which
        is currently our `minSdkVersion`, fails otherwise
        when trying to open any document with the below
        in the ADB log.
        
        With this (and all the previous fixes for low API/SDK levels)
        in place, opening a document in Android Viewer finally
        succeeds there.
        
        > F/libc    ( 3288): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 3310 (Thread-122)
        > I/stderr  ( 3288): terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException
        > I/stderr  ( 3288): assertion "terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException" failed: file "/usr/local/google/buildbot/src/android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp", line 73, function "abort_message"
        > I/DEBUG   ( 1173): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
        > I/DEBUG   ( 1173): Build fingerprint: 'generic_x86/sdk_x86/generic_x86:4.1.2/MASTER/eng.wdu.20191218.182616:eng/test-keys'
        > I/DEBUG   ( 1173): pid: 3288, tid: 3310, name: Thread-122  >>> org.libreoffice <<<
        > I/DEBUG   ( 1173): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr deadbaad
        > I/DEBUG   ( 1173):     eax 00000000  ebx b76c9f4c  ecx 00000000  edx b76cbfd4
        > I/DEBUG   ( 1173):     esi b65ed000  edi 788c7d6c
        > I/DEBUG   ( 1173):     xcs 00000073  xds 0000007b  xes 0000007b  xfs 00000000  xss 0000007b
        > I/DEBUG   ( 1173):     eip b7661c03  ebp 788c7d88  esp 788c7d40  flags 00210246
        > I/DEBUG   ( 1173):
        > I/DEBUG   ( 1173): backtrace:
        > I/DEBUG   ( 1173):     #00  pc 00021c03  /system/lib/libc.so (abort+131)
        > I/DEBUG   ( 1173):     #01  pc 00030ff1  /system/lib/libc.so
        > I/DEBUG   ( 1173):     #02  pc 0e137175  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #03  pc 0e1372f5  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #04  pc 0e133d0a  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #05  pc 0e13323f  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #06  pc 0e133194  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #07  pc 0d369737  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #08  pc 0d3673b0  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #09  pc 0d366a7b  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #10  pc 0d377a25  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #11  pc 09a2b944  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #12  pc 098826da  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #13  pc 098cc47c  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #14  pc 098ded29  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #15  pc 098bb839  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #16  pc 098b7e23  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #17  pc 098bb8cf  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #18  pc 0987a677  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #19  pc 0987b7c7  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #20  pc 0987ab4b  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #21  pc 0987a9a7  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #22  pc 0987f90b  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #23  pc 0986d4ff  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #24  pc 09872298  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #25  pc 035625cf  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #26  pc 0355dff2  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #27  pc 035713f9  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #28  pc 03570d3b  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #29  pc 035714b8  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #30  pc 09a5fb66  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #31  pc 09a5f984  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):
        > I/DEBUG   ( 1173): stack:
        > I/DEBUG   ( 1173):          788c7d00  b76cca48
        > I/DEBUG   ( 1173):          788c7d04  b76ca208  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d08  b76699eb  /system/lib/libc.so (_fwalk+11)
        > I/DEBUG   ( 1173):          788c7d0c  b76c9f4c  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d10  00000000
        > I/DEBUG   ( 1173):          788c7d14  00000000
        > I/DEBUG   ( 1173):          788c7d18  00000000
        > I/DEBUG   ( 1173):          788c7d1c  00000000
        > I/DEBUG   ( 1173):          788c7d20  00000000
        > I/DEBUG   ( 1173):          788c7d24  00000000
        > I/DEBUG   ( 1173):          788c7d28  00000000
        > I/DEBUG   ( 1173):          788c7d2c  00000000
        > I/DEBUG   ( 1173):          788c7d30  00000000
        > I/DEBUG   ( 1173):          788c7d34  00000000
        > I/DEBUG   ( 1173):          788c7d38  00000000
        > I/DEBUG   ( 1173):          788c7d3c  00000000
        > I/DEBUG   ( 1173):     #00  788c7d40  00000002
        > I/DEBUG   ( 1173):          788c7d44  788c7d6c  [stack:3310]
        > I/DEBUG   ( 1173):          788c7d48  00000000
        > I/DEBUG   ( 1173):          788c7d4c  00000115
        > I/DEBUG   ( 1173):          788c7d50  0000007f
        > I/DEBUG   ( 1173):          788c7d54  b76c9f4c  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d58  788c7d98  [stack:3310]
        > I/DEBUG   ( 1173):          788c7d5c  b76c9f4c  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d60  b76ca208  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d64  788c7e04  [stack:3310]
        > I/DEBUG   ( 1173):          788c7d68  788c7d88  [stack:3310]
        > I/DEBUG   ( 1173):          788c7d6c  fffffbdf
        > I/DEBUG   ( 1173):          788c7d70  b76ca208  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d74  b76b3b24  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d78  b7661b8e  /system/lib/libc.so (abort+14)
        > I/DEBUG   ( 1173):          788c7d7c  b76c9f4c  /system/lib/libc.so
        > I/DEBUG   ( 1173):          ........  ........
        > I/DEBUG   ( 1173):     #01  788c7d90  b76ca208  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d94  b76b3b24  /system/lib/libc.so
        > I/DEBUG   ( 1173):          788c7d98  b9b98fc0  [heap]
        > I/DEBUG   ( 1173):          788c7d9c  8723cac3  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7da0  00000049
        > I/DEBUG   ( 1173):          788c7da4  8723cb39  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7da8  b766b6fe  /system/lib/libc.so (vasprintf+14)
        > I/DEBUG   ( 1173):          788c7dac  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7db0  b7670fa9  /system/lib/libc.so (__assert2+9)
        > I/DEBUG   ( 1173):          788c7db4  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7db8  788c7df8  [stack:3310]
        > I/DEBUG   ( 1173):          788c7dbc  86a0d175  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):     #02  788c7dc0  8723cac3  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7dc4  00000049
        > I/DEBUG   ( 1173):          788c7dc8  8723cb39  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7dcc  b9b98fc0  [heap]
        > I/DEBUG   ( 1173):          788c7dd0  b9b98fc0  [heap]
        > I/DEBUG   ( 1173):          788c7dd4  788c7e04  [stack:3310]
        > I/DEBUG   ( 1173):          788c7dd8  788c7e04  [stack:3310]
        > I/DEBUG   ( 1173):          788c7ddc  86a09960  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7de0  00000014
        > I/DEBUG   ( 1173):          788c7de4  86a09980  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7de8  788c7e38  [stack:3310]
        > I/DEBUG   ( 1173):          788c7dec  788c7e1c  [stack:3310]
        > I/DEBUG   ( 1173):          788c7df0  b9b1c480  [heap]
        > I/DEBUG   ( 1173):          788c7df4  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):          788c7df8  788c8238  [stack:3310]
        > I/DEBUG   ( 1173):          788c7dfc  86a0d2f5  /data/data/org.libreoffice/lib/liblo-native-code.so
        > I/DEBUG   ( 1173):
        > I/DEBUG   ( 1173): memory map around fault addr deadbaad:
        > I/DEBUG   ( 1173):     bfa03000-bfa24000 [stack]
        > I/DEBUG   ( 1173):     (no map for address)
        > I/DEBUG   ( 1173):     (no map above)
        > D/Zygote  ( 1176): Process 3288 terminated by signal (11)
        
        Change-Id: I0bc6d13b1217959c5e447e7c6126006b561639a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133264
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [7084da45dd322c253626c3576aef53ae021fdcdf]

        android: Explicitly load libc++_shared
        
        While it works just fine without that in newer
        Android versions, trying to open any doc in an
        x86 AVD with API level 16 failed like this:
        
        > E/AndroidRuntime( 2999): java.lang.ExceptionInInitializerError
        > E/AndroidRuntime( 2999):        at org.libreoffice.TileProviderFactory.initialize(TileProviderFactory.java:23)
        > E/AndroidRuntime( 2999):        at org.libreoffice.LOKitThread.<init>(LOKitThread.java:39)
        > E/AndroidRuntime( 2999):        at org.libreoffice.LibreOfficeMainActivity.onCreate(LibreOfficeMainActivity.java:149)
        > E/AndroidRuntime( 2999):        at android.app.Activity.performCreate(Activity.java:5008)
        > E/AndroidRuntime( 2999):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
        > E/AndroidRuntime( 2999):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
        > E/AndroidRuntime( 2999):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
        > E/AndroidRuntime( 2999):        at android.app.ActivityThread.access$600(ActivityThread.java:130)
        > E/AndroidRuntime( 2999):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
        > E/AndroidRuntime( 2999):        at android.os.Handler.dispatchMessage(Handler.java:99)
        > E/AndroidRuntime( 2999):        at android.os.Looper.loop(Looper.java:137)
        > E/AndroidRuntime( 2999):        at android.app.ActivityThread.main(ActivityThread.java:4745)
        > E/AndroidRuntime( 2999):        at java.lang.reflect.Method.invokeNative(Native Method)
        > E/AndroidRuntime( 2999):        at java.lang.reflect.Method.invoke(Method.java:511)
        > E/AndroidRuntime( 2999):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
        > E/AndroidRuntime( 2999):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
        > E/AndroidRuntime( 2999):        at dalvik.system.NativeStart.main(Native Method)
        > E/AndroidRuntime( 2999): Caused by: java.lang.UnsatisfiedLinkError: Cannot load library: link_image[1891]:  1176 could not load needed library 'libc++_shared.so' for 'liblo-native-code.so' (load_library[1093]: Library 'libc++_shared.so' not found)
        > E/AndroidRuntime( 2999):        at java.lang.Runtime.loadLibrary(Runtime.java:370)
        > E/AndroidRuntime( 2999):        at java.lang.System.loadLibrary(System.java:535)
        > E/AndroidRuntime( 2999):        at org.libreoffice.kit.NativeLibLoader.load(LibreOfficeKit.java:105)
        > E/AndroidRuntime( 2999):        at org.libreoffice.kit.LibreOfficeKit.<clinit>(LibreOfficeKit.java:82)
        > E/AndroidRuntime( 2999):        ... 17 more
        > W/ActivityManager( 1421):   Force finishing activity org.libreoffice/.LibreOfficeMainActivity
        > W/ActivityManager( 1421):   Force finishing activity org.libreoffice/.ui.LibreOfficeUIActivity
        
        Change-Id: I6e383e624b9e66c0daa9ecfda4a3b176c8fa0d94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133263
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [730add0ca619985b99e133dd586e063f0f12538b]

        android: Use drawable tag already supported with API level 16
        
        Use the `app:drawableLeftCompat` tag instead of
        `android:drawableLeft` to set the icon to show
        in the TextView.
        
        With the latter, trying to start Android Viewer
        in an x86 AVD with API level 16 resulted in this
        crash:
        
        > E/AndroidRuntime( 2510): java.lang.RuntimeException: Unable to start activity ComponentInfo{org.libreoffice/org.libreoffice.ui.LibreOfficeUIActivity}: android.view.InflateException: Binary XML file line #80: Error inflating class TextView
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2059)
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2084)
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread.access$600(ActivityThread.java:130)
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1195)
        > E/AndroidRuntime( 2510):        at android.os.Handler.dispatchMessage(Handler.java:99)
        > E/AndroidRuntime( 2510):        at android.os.Looper.loop(Looper.java:137)
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread.main(ActivityThread.java:4745)
        > E/AndroidRuntime( 2510):        at java.lang.reflect.Method.invokeNative(Native Method)
        > E/AndroidRuntime( 2510):        at java.lang.reflect.Method.invoke(Method.java:511)
        > E/AndroidRuntime( 2510):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
        > E/AndroidRuntime( 2510):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
        > E/AndroidRuntime( 2510):        at dalvik.system.NativeStart.main(Native Method)
        > E/AndroidRuntime( 2510): Caused by: android.view.InflateException: Binary XML file line #80: Error inflating class TextView
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:704)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:746)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.rInflate(LayoutInflater.java:749)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.inflate(LayoutInflater.java:489)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.inflate(LayoutInflater.java:396)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.inflate(LayoutInflater.java:352)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatDelegateImpl.setContentView(AppCompatDelegateImpl.java:696)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatActivity.setContentView(AppCompatActivity.java:170)
        > E/AndroidRuntime( 2510):        at org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:169)
        > E/AndroidRuntime( 2510):        at org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147)
        > E/AndroidRuntime( 2510):        at android.app.Activity.performCreate(Activity.java:5008)
        > E/AndroidRuntime( 2510):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1079)
        > E/AndroidRuntime( 2510):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2023)
        > E/AndroidRuntime( 2510):        ... 11 more
        > E/AndroidRuntime( 2510): Caused by: android.content.res.Resources$NotFoundException: File res/drawable-hdpi-v4/ic_folder_grey_48dp.xml from drawable resource ID #0x7f080083
        > E/AndroidRuntime( 2510):        at android.content.res.Resources.loadDrawable(Resources.java:1923)
        > E/AndroidRuntime( 2510):        at android.content.res.TypedArray.getDrawable(TypedArray.java:601)
        > E/AndroidRuntime( 2510):        at android.widget.TextView.<init>(TextView.java:614)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.widget.AppCompatTextView.<init>(AppCompatTextView.java:100)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.widget.AppCompatTextView.<init>(AppCompatTextView.java:95)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatViewInflater.createTextView(AppCompatViewInflater.java:194)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatViewInflater.createView(AppCompatViewInflater.java:115)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatDelegateImpl.createView(AppCompatDelegateImpl.java:1551)
        > E/AndroidRuntime( 2510):        at androidx.appcompat.app.AppCompatDelegateImpl.onCreateView(AppCompatDelegateImpl.java:1602)
        > E/AndroidRuntime( 2510):        at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:675)
        > E/AndroidRuntime( 2510):        ... 26 more
        > E/AndroidRuntime( 2510): Caused by: org.xmlpull.v1.XmlPullParserException: Binary XML file line #1: invalid drawable tag vector
        > E/AndroidRuntime( 2510):        at android.graphics.drawable.Drawable.createFromXmlInner(Drawable.java:877)
        > E/AndroidRuntime( 2510):        at android.graphics.drawable.Drawable.createFromXml(Drawable.java:818)
        > E/AndroidRuntime( 2510):        at android.content.res.Resources.loadDrawable(Resources.java:1920)
        > E/AndroidRuntime( 2510):        ... 35 more
        > W/ActivityManager( 1421):   Force finishing activity org.libreoffice/.ui.LibreOfficeUIActivity
        
        Change-Id: I4253a68f90d6c507805c7bf72aaf81011fb19339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133256
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [427188600ffe31d142ca6d0e1d549e3c1c4246b8]

        Fix typo
        
        Change-Id: I0444ed426dddd36e464b59758545155e11e9c13a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133298
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [07bf0ce4e7f04a79910cbe1340264863451f1926]

        tdf#148651: basic_macros: Add unittest
        
        Change-Id: Iadbe470de5a33dc633fe8f53083520988e497df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133255
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-21  Zain Iftikhar  <zain.iftikhar@7vals.com>  [02b740a7a047052e60274b8649f3624267eb079f]

        tdf#141000 replacing underscores with spaces of multi words icon pack name
        
        patch will replace underscores with spaces of multi words icon pack name.
        
        Change-Id: If37f6617b7c90eb912ab2f58fff0f1df225efa66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133094
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-04-21  Mike Kaganski  <mike.kaganski@collabora.com>  [c09f59eb6173a4a53a2d40ed80aebed18e3882ac]

        Drop special-casing for Chart's sidebar property deck
        
        Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a
          Author Markus Mohrhard <markus.mohrhard@googlemail.com>
          Date   Thu Jul 09 20:39:06 2015 +0200
            big step towards real chart sidebar
        
        later in commit da57c32c5cb27eee38e32d10232b31d459c399df
          Author Tor Lillqvist <tml@collabora.com>
          Date   Fri Feb 28 17:02:30 2020 +0200
            tdf#130348: Add special case for ChartDeck, too
        
        and then in commit ff23d87cb00388095a94b90e061564fc179e1823
          Author Mert Tumer <mert.tumer@collabora.com>
          Date   Fri May 08 17:23:12 2020 +0300
            mobile: fix calc chart wizard properties is not shown
        
        The normal PropertyDeck can host all the chart-specific panels,
        and the other decks that had "all" application context, but are
        not needed for charts, have their context fixed.
        
        This cleanup is needed for a following introduction of sidebar
        in Math.
        
        Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e31cf19e5f5bcdc9e96d1ecd896a611ea035a934]

        tdf#147723: sw_uiwriter5: Add unittest
        
        Change-Id: Ief6afaee548e58a31580b66d55b9b193ba23d153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133259
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5de4d0277e18fbf79f8f80fbe49d2d25be1fb4c]

        tdf#148669: sc_uicalc: Add unittest
        
        Change-Id: I2991ef99f5a617e36cfbe9499ef1c4195d52fdf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133254
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [cdfd4d6c9a8cebe55a85624aaaff2664f270b247]

        use more string_view in cppu
        
        Change-Id: Id6b33eb39917ce7b805ea4a5d713d5d78aaa93ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [7d7890871085a427b0844c208a76158341890219]

        subsequent_filters_test: put this test with the others
        
        Change-Id: I274d5b0c8aae2c4313ca8dd724898238c72539ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133253
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-21  Luboš Luňák  <l.lunak@collabora.com>  [c74b7dadd53a3821451c6bed93988eea1743f141]

        serialize linking of large libraries only if USE_LD is not set
        
        This problem with large memory usage during parallel linking
        of several large libraries is presumably only relevant for the poorly
        performing BFD linker. I can barely notice any memory usage increase
        even with something as "old" as gold.
        
        Change-Id: I20038c98543b1b920d75d8f645c6b90afb5fb6e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133250
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-04-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [347622a98f512dae709f938a85498dcdcf9f225a]

        tdf#148699 Qt track the active / shown popup
        
        I have no idea, if there can be multiple active popups in LO in
        some way. There can be multiple FloatingWindow and gtk does count
        them in m_nFloats... There is a whole lot going on in gtk3 related
        to isFloatGrabWindow(), with "funny" comments like:
        
        // FIXME: find out who the hell steals the focus from our frame
        
        So this goes with some "optimistic" approach: there is just one
        active popup, so we can track it in QtInstance. It WFM...
        
        Change-Id: I9778587696e1ad9e641dba4f102e2e921266eee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133249
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d9291b9433c9645b0870525211f74bfb1151555]

        use more string_view in unoidl,codemaker
        
        Change-Id: Ibc0624a662c98ef1308a3bb0c7c082935a89a25c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [9ac36f0ecba806b51e6d1cb4cf8d92fe062508f4]

        sd_export_tests-ooxml3: Add simple test for import/export of underline
        
        Change-Id: I684b633f6d96d4d06f203745fe2b887a2cfee5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133247
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-21  Regina Henschel  <rb.henschel@t-online.de>  [5168d06b1302c43a305d0f670ee65079f21063b5]

        tdf#109169 export Type encoded shading to OOXML
        
        A shape might have the shading information not in commands in the
        enhanced-path, but generated in ctor of EnhancedCustomShape2d from the
        Type value of the shape. This shading information is a 32 bit value
        with first the number of the shadings and then the shadings. A shading
        is encoded with 1,2,3,4,5,6,7 for lighten 10 to 70 and 8,9,a,b,c,d,e,f
        for darken -80 to -10.
        
        To get this information from EnhanceCustomShape2d I have made its
        method GetLuminanceChange() public.
        
        Because OOXML only has darken, darkenLess, lighten and lightenLess our
        values are mapped:
        -10, -20, -30 to darkenLess
        -40, -50, -60, -70, -80 to darken
        10, 20, 30 to lightenLess
        40, 50, 60, 70 to lighten
        
        The bupreport mentions only 'Octagon Bevel' and 'Diamond Bevel'. But
        the patch fixes missing shading for shapes of Types 'ActionButton*'
        as well. Such shapes come in from MS binary import.
        
        Change-Id: I03f19496b915f3ced6346222e8806832b4ee2827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133220
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-21  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8ac35ace9fca1e0d348e5f9c1ee777458661338c]

        Prevent save interception when un-sharing Calc doc
        
        Follow-up to bfc43aad0e8eb90e9d3495b940bc2283081f04c6
        
        Change-Id: I0b4562e8a41377839e78c5e471f36eed0a52d5bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133216
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-21  Stephan Bergmann  <sbergman@redhat.com>  [48d07b42b38fa30f9b0cc0459eac5d182f995a36]

        rhbz#2075918: Join ExtensionCmdQueue::Thread
        
        ...so that it can't still run when the main thread is already in DeInitVCL, and
        this thread would crash with SIGSEGV at
        
        > #6  0x00007fe79001ac74 in dp_gui::TheExtensionManager::modified (this=<optimized out>) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_theextmgr.cxx:498
        > #7  0x00007fe790834a0b in operator() (__closure=<optimized out>, xListener=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:1416
        > #8  cppu::OInterfaceContainerHelper::forEach<com::sun::star::util::XModifyListener, dp_manager::ExtensionManager::fireModified()::<lambda(const com::sun::star::uno::Reference<com::sun::star::util::XModifyListener>&)> > (func=..., this=<optimized out>) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/include/cppuhelper/interfacecontainer.h:292
        > #9  dp_manager::ExtensionManager::fireModified (this=0x5613a450e050) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:1414
        > #10 0x00007fe79082d907 in dp_manager::ExtensionManager::activateExtension (this=0x5613a450e050, identifier=..., fileName=..., bUserDisabled=<optimized out>, bStartup=<optimized out>, xAbortChannel=..., xCmdEnv=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:425
        > #11 0x00007fe790830b5f in dp_manager::ExtensionManager::addExtension (this=0x5613a450e050, url=..., properties=..., repository=..., xAbortChannel=..., xCmdEnv=...) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/manager/dp_extensionmanager.cxx:721
        > #12 0x00007fe79002d628 in dp_gui::ExtensionCmdQueue::Thread::_addExtension (bWarnUser=<optimized out>, rRepository=..., rPackageURL=..., rCmdEnv=..., this=0x5613a4753490) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:870
        > #13 dp_gui::ExtensionCmdQueue::Thread::execute (this=0x5613a4753490) at /usr/src/debug/libreoffice-7.3.2.2-1.fc36.x86_64/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx:744
        
        (Which can apparently happen when you quit/restart LO quickly enough after
        installing an extension through "Tools - Extension Manager...")
        
        The join was missing ever since the code's introduction in
        f167d090345c9c7950665e50006aff4fc0ace078 "INTEGRATION: CWS extmgrui01" (there
        originally was an unused stopAndWait that would have joined, but which got
        removed in 0014f10d9237e82357e11aedecca817f67827536 "#i105556#: remove unused
        code", but there doesn't appear to be at least any obvious reason why joining in
        ~ExtensionCmdQueue should cause problems (at least with the recent fixes
        2dce6754355a06e567427c39154d8747538864b1 "Reliably stop
        ExtensionCmdQueue::Thread::execute" and 057f504e6518d1cefd141713c98a15cf9160e676
        "Use the sander std::condition_variable semantics in
        ExtensionCmdQueue::Thread".)
        
        Change-Id: Iaad47fb77feed529dadf230088e1cb8ffccc80c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133248
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [b6a237ad1f5957b9d32bca7e41aa4a2b3bed01fc]

        android: use mavenCentral instead of jcenter repository
        
        From the `./gradlew --warning-mode all assembleStrippedUIEditingRelease`
        output:
        
        > > Configure project :
        > The RepositoryHandler.jcenter() method has been deprecated. This is
        > scheduled to be removed in Gradle 8.0. JFrog announced JCenter's sunset
        > in February 2021. Use mavenCentral() instead. Consult the upgrading
        > guide for further information:
        > https://docs.gradle.org/7.2/userguide/upgrading_version_6.html#jcenter_deprecation
        >         at build_a6ed945jjgv6miyybz50fclhq$_run_closure1$_closure2.doCall(/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/build.gradle:14)
        >         (Run with --stacktrace to get the full stack trace of this deprecation warning.)
        
        Change-Id: I5db84a9778b598d1e3459dd313aa05c229060368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133239
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [b548507896f9b1fef606e5d5329c6283436a592c]

        android: Drop obsolete build tools version check from configure.ac
        
        `build.gradle` no longer contains a specific `buildToolsVersion`
        since
        
            commit a93770e6d0d2fcc5a2eefbed546acee055833fd4
            Date:   Fri Mar 6 12:16:24 2020 +0100
        
                android: Update gradle
        
                The previous version e.g. did not support building
                Android App Bundles yet.
        
                Drop explicit 'buildToolsVersion', as suggested in the warning
                during build:
        
                > WARNING: The specified Android SDK Build Tools version (27.0.3) is ignored,
                > as it is below the minimum supported version (28.0.3) for Android Gradle
                > Plugin 3.6.1.
                > Android SDK Build Tools 28.0.3 will be used.
                > To suppress this warning, remove "buildToolsVersion '27.0.3'" from your build.gradle
                > file, as each version of the Android Gradle Plugin now has a default
                > version of the build tools.
        
        so the sed expression in configure.ac was evaluating to an empty
        string and only the existence of `"$ANDROID_SDK_DIR/build-tools/`
        was checked.
        As mentioned in a93770e6d0d2fcc5a2eefbed546acee055833fd4,
        each version of the Android Gradle Plugin now has a default
        version of the build tools. It takes care of downloading and
        installing that one as necessary.
        
        Change-Id: Ic8528c5dc238dccb35ccf215945ef935e8c3a89c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133238
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-21  Michael Stahl  <michael.stahl@allotropia.de>  [85aa57359befd7a21b3fdf36f2b362f50495f77c]

        sw: layout: fix crash when deleting page with section being formatted
        
        This crashes only when calling storeToURL() with writer_pdf_Export?
        
        There is a text frame 112, followed by section frame 126, which contains
        table frame 127.
        
        The section frame 126 is being formatted, which in
        SwFrame::PrepareMake() formats its prev, text frame 112.
        
        This does MoveBwd() and in SwContentFrame::MakeAll() formats its next,
        tab frame 127.
        
        This also does MoveBwd() and then there is this really odd condition in
        SwTabFrame::Paste() where it calls SwFrame::CheckPageDescs() if it
        *doesn't* have a RES_PAGEDESC item and the page has a non-default page
        style - this condition remains inexplicable since initial CVS import.
        
        Then CheckPageDesc() sees the (next) page is empty and deletes it.
        
        So check in sw::IsPageFrameEmpty() that there aren't any sections with
        IsDeleteForbidden() set.
        
        (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb)
        
        Change-Id: I3c64fe40fabffc255c4146a35c678ce6a1cc09c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133222
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-21  Miklos Vajna  <vmiklos@collabora.com>  [368b1e070a4b1f24d2d47b3ad5b111d26aa8cf0b]

        CppunitTest_sw_ooxmlexport9: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I315d54c4554141d3a0e04d3873b06b0fd5fa14d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133237
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-21  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [80c856336668e35837667323957fa3ad4172f3c0]

        tdf#55058 tdf#143875 EMF+ Fix display of dashed lines and line joints
        
        With previous implementation, empty spaces between dashes
        were too long.
        Additionally line joints were not working correctly, after
        EMF+ reworking: tdf#111486
        
        This commit fixes all these issues and additionally it is
        covering it with tests.
        Change-Id: I9404e566d2d7d3405ab817268ad9b1f538c200eb
        
        Change-Id: I523f92a928ab592ff175d0d01c1ad1a3bc22e324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133207
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-04-21  Miklos Vajna  <vmiklos@collabora.com>  [59393b73ec4c0f1f1965a9c24a2635780c707189]

        sw content controls: add insert UI
        
        - add an SwWrtShell::InsertContentControl() to put the current selection
          into a content control
        
        - if there is no selection, add a non-empty placeholder
        
        - expose this as a new .uno:InsertContentControl uno command
        
        - add this new command to the bottom of the form menu -- probably we can
          have a sub-menu there once there will be more types
        
        Change-Id: Icb32aee777ab08d09401bf468788692b933a90ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133241
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-21  Stephan Bergmann  <sbergman@redhat.com>  [057f504e6518d1cefd141713c98a15cf9160e676]

        Use the sander std::condition_variable semantics in ExtensionCmdQueue::Thread
        
        This avoids the need for the tricky osl::Condition::reset call.
        
        Change-Id: Id441fe6be42409fa43624bc0c1cbc8a62462d3e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133240
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [66365e9fb2105c98f7bf16152fb4910f605dae78]

        tdf#148437 - Hyperlink: Replace entire content if cell contains a formula
        
        Inserting a hyperlink through the hyperlink dialog should replace the
        content of the entire cell if it contains a formula.
        
        Change-Id: I2e06f134bfcd21ec3fef76f2a9b80e433adce1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132785
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-04-21  Julien Nabet  <serval2412@yahoo.fr>  [98f88ac1ffaee21f38615f9db27691b01491457c]

        tdf#148651: implement VBA.FormatPercent
        
        I started from a copy/paste of FormatNumber.
        Then I deduplicated the code (it saved about 99% of it).
        
        Change-Id: Ibcb9ffbf8cebf45d5ffac4713e3d220b8499ba11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133133
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8ce5b631484f2fb6818cccfb4e0c7d85c111b59f]

        Fix typo
        
        Change-Id: Ic31e50b22f64c55a1e0a7bbd5859672adfba5d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133230
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e764a1aca24769cdca94da09c450a5cd1225e574]

        Fix typo
        
        Change-Id: I1f7b1c0b28b9e5247debb85e07f19896d16f8bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133228
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f3da13e383f6333fd82b122c323e4aaf0898f82]

        Fix typo
        
        Change-Id: I7fbadf7c02d07db16e2f1112b828400e09a32c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133229
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d89019c207f1d068072bad0ccf995cd8c4dd4cef]

        Fix typo
        
        Change-Id: Id9dd449886bdcb8676f9a79af5227fcad824fb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133232
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6904c018bba408ddf410c1ee371f9f22c5cfc30c]

        Fix typo
        
        Change-Id: Ib3d058b8c47f8c5d7540e1a4ba4aeaf093a6cbda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133227
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-21  Stephan Bergmann  <sbergman@redhat.com>  [481e2bc6f7273d9c2c34db96e0dc211bf055ee63]

        Clean up odd function definitions
        
        ...that were like that ever since c25ec0608a167bcf1d891043f02273761c351701
        "initial import", but which when called would run into the assert(false)/
        "!!br0ken!!" code in rtl::str::newFromSubString (sal/rtl/strtmpl.hxx), as the
        count argument to OUString::copy is -1.  So just return an empty OUString,
        similar to what the getTimeDateFunctions and getNumericFunctions functions
        always did.
        
        (Stumbled across this when it got flagged by loplugin:stringviewvar with
        clang-cl.)
        
        Change-Id: Ief23c7e0c7712dd65e6213c9e7db3a10d276eaa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133226
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-21  Stephan Bergmann  <sbergman@redhat.com>  [2dce6754355a06e567427c39154d8747538864b1]

        Reliably stop ExtensionCmdQueue::Thread::execute
        
        ...even if nSize == 0
        
        Change-Id: I624a5958d0826aad70277af6291f62d31ced6798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133236
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-21  Miklos Vajna  <vmiklos@collabora.com>  [f4716b19e42ae89ab0c1d5df7e2e51cc7bb6a30e]

        sw: document AbstractSwRenameXNamedDlg
        
        It's also used by the navigator for e.g. bookmarks -> select entry ->
        context menu -> rename.
        
        Change-Id: Ieea79c57cfb07ff0f26f3c70e0b1ce33aa30d9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133224
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-21  Michael Weghorn  <m.weghorn@posteo.de>  [5d56255c22c79b72c1cedb48cfe0a200f89bdc66]

        qt6: Fix build (QtWidget::enterEvent)
        
        In Qt 6, `QWidget::enterEvent` takes a
        `QEnterEvent*` param.
        
        An override for `QtWidget` was added in
        
            commit dc886bc6de2c0061a840bea2426663c3be2ecd26
            Date:   Tue Apr 19 16:03:56 2022 +0200
        
                tdf#140463 Qt handle mouse enter+leave events
        
        Change-Id: I47579ce6686da321533afcef2e4436e315901059
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133235
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Stephan Bergmann  <sbergman@redhat.com>  [d81c26a1b9220c176f2d7162ac3b01983d6c8e4f]

        Simplify some code, use o3tl::starts_with rest argument
        
        Change-Id: I3eede83bdea26a6ac8ff81e664c0439b75879ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133225
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [dc886bc6de2c0061a840bea2426663c3be2ecd26]

        tdf#140463 Qt handle mouse enter+leave events
        
        Currently just implemented for the QtWidget, but still as a static
        function, so it may be used for QtObject at some point too.
        
        But there is no (mouse) enter or leave event function in QWindow,
        so no way to handle these there. And since we can't modify the
        returned QWidget from QWidget::createWindowContainer, the only way
        would be to expand the static QtWidget::handleEvent used by
        QtObjectWindow::event ... if it's actually needed at some point.
        
        Change-Id: If9009e5dfca508acd1e702df1a17eb8ad7c29690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133190
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [e44f71dd3439cd1c473b2e32516e33986de042f3]

        tdf#148669: do not try to transform tail to unit rectangle
        
        ... just to transform it back when it's used.
        
        The problem was that the transform had zero vertical scale; thus
        it couldn't be inverted. The unchanged matrix was used both in the
        SdrCaptionPrimitive2D constructor, and in its create2DDecomposition,
        thus scaling the X coordinate up twice. The result, which depends
        on the original value of X, was huge for comments attached to cells
        with large column numbers. Trying to convert such coordinate from
        pixels to logic units exceeded 64-bit integer range.
        
        Avoiding the transformations back and forth is possible, because
        the transform is constant in the object. This also avoids unneeded
        overhead.
        
        There is an open question why there was a need in the calculations
        for the XLSX file. The problem doesn't happen with ODS, so likely
        there is a calculation of the draw page size in some circumstances
        that may be avoided.
        
        Change-Id: Iccbe77936ec1078daf6b05b0b2d44a6fa3536c4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133217
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-20  Michael Stahl  <michael.stahl@allotropia.de>  [2f726fa41cbd249f2fb30222b29d5f30bce52e6e]

        tdf#147723 sw_fieldmarkhide: fix crash when copying multiple fieldmarks
        
        The problem is the UpdateFramesForAddDeleteRedline() call in makeMark(),
        this is called in a loop for multiple fieldmarks and when it's called
        for the first one, of course the other ones aren't in the document yet,
        so HideIterator::Next() can't find them.
        
        But this is only needed when inserting a new fieldmark anyway, so just
        disable for copying.
        
        (regression from commit 92384a813176b964a67bcbeb2fa617c554dbc4a2)
        
        Change-Id: Ic1b34d469a553cf7bbf2d1a99edaea900bdd7417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133215
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-20  Michael Stahl  <michael.stahl@allotropia.de>  [8d9c56e8f42428fd6695942c673bffb985d22ad5]

        tdf#146460 tdf#148429 ucb: webdav-curl: censor "curl" in UserAgent
        
        This is now the second bug filed because a server replies with 403 if
        the UserAgent contains the string "curl".
        
        Change-Id: I25ca2d255af76a7ff4e64dad900b1bf0b78de59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133212
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0f24ca516e13c86d410960788ed6df3efe367b2]

        no need to make copies of the vector here
        
        Change-Id: Ieca07df686668af252800089028146f0f55c26de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133201
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f958c076a86e80a48fcd7bbca65a834568e94ea]

        loplugin:passstuffbyref
        
        Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-20  Hossein  <hossein@libreoffice.org>  [a40558be785756929f606ab0798a026b985e0ffb]

        tdf#143122 - Port Java examples to C++
        
        Porting FirstSteps/FirstUnoContact.java to C++ is done. More
        information on this example can be found in the DevGuide:
        
        LibreOffice Developer's Guide: Chapter 1 - First Steps - First Contact
        https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
        
        Change-Id: I84b0a60738bfe614158d7eabf8bff3cda1ccca50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132910
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-04-20  Tor Lillqvist  <tml@iki.fi>  [63bad2bf8dc0d1052532e92be1a18118c0398fbf]

        Fix regression in the iOS app (and possibly the Android and GTK apps)
        
        The problem was caused by my remote font downloading changes. We need
        to be more careful in lo_initialize() and libreofficekit_hook_2() to
        distinguish whether the code is called from "normal" Online (with
        "pre-initialisation" through lok_preinit_2()) or otherwise, for
        instance the iOS app, where not pre-initialisation is done.
        
        Sadly, this fix makes state handling in init.cxx even more complex
        with one more static Boolean flag.
        
        Change-Id: I2a8fa96740eb79725aa162cf7adc86d49a8ba603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133175
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133196
        Tested-by: Jenkins

2022-04-20  Stephan Bergmann  <sbergman@redhat.com>  [956a01947d869247e5e117105a1e17edd46bfce1]

        Avoid unhelpful loplugin:stringviewvar
        
        Regression during `make check` introduced with
        ab699bfdb3375f7142a50cc35322e2924c9e5945 "new loplugin:stringviewvar looks for
        OUString vars that can be".
        
        Change-Id: Ib6b9aabcfd380b43a77a97cf9d7e15c37aeb852c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133204
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-20  Michael Stahl  <michael.stahl@allotropia.de>  [6a868fff7a947a630ef1e1573a165f8fe690fad0]

        ucb: webdav-curl: restore CppunitTest_ucb_webdav_core
        
        First commit 2177f48b16b8cd68c0ef4ec817ca391f28324418 forgot to adapt
        one use of WITH_WEBDAV so the test didn't run and then commit
        2cbf83e20889351e2d2a6e29e5c7d9250af58647 removed some functions that
        were only called by the test.
        
        Change-Id: I46c8b065d37aa072a8966cce30d9e63d63b1145c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133206
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-20  Mark Hung  <marklh9@gmail.com>  [88aeb649ed33a1a67547419f9b76c2c892dd2ee1]

        tdf#148630 fix text layout and cursor position for IVS+spacing
        
        in Impress. This involves:
        
        1. SvxFont::QuickGetTextSize() and SvxFont::GetPhysTxtSize():
        insert space only when text array value changes. Same value indicates
        diffferent characters of the same glyph item (e.x. surrogate pairs,
        unicode IVS that is made of a base character and a selector. ).
        
        2. ImpEditEngine::GetChar(): fix a logical mistake that tried
        to increase the index by 1 than checking the value of character
        position. To advance the index we always need to check the position
        first.
        
        Change-Id: I4e3547413ce361ae7801c957e6d589776ebed114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133102
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-04-20  Mike Kaganski  <mike.kaganski@collabora.com>  [89948bd544516604af057588676b0f979f21c163]

        lok: use correct window for the MapMode
        
        ... otherwise, using a zoomed document, the returned bounding box
        does not account for that zoom.
        
        Change-Id: Id7834bbc2bebaa923414cf029c37a8e22f9c1078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133205
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [65075a76ff177ac40df726b2174297c8c774fbaa]

        loplugin:stringviewvar disable for now
        
        since it might generate false +
        
        Change-Id: Icde883e0a2d60e70dd4ce9bbf823b54847cbb180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133203
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-20  Hossein  <hossein@libreoffice.org>  [c37d00a4f22a973c0905a9d8f409994763cb637a]

        tdf#143123 - Port Java examples to Python
        
        Porting FirstSteps/FirstUnoContact.java to Python is done. More
        information on this example can be found in the DevGuide:
        
        LibreOffice Developer's Guide: Chapter 1 - First Steps - First Contact
        https://wiki.documentfoundation.org/Documentation/DevGuide/First_Steps
        
        Change-Id: I8a97672a0b437177f19ddce029e6ef27e97533ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132914
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-04-20  Michael Stahl  <michael.stahl@allotropia.de>  [6d7c3848560883034a4ff12ac1ef52d2d1d28606]

        ucb: webdav-curl: check UseUserData before sending user name
        
        Hope this should be acceptable.
        
        Change-Id: I567e0cb358c8693db8f1c674b4fa6f841506f331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133188
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [0350c84a5e6bf7c48cd77c7fcb29a3bbdc1d8c8d]

        tdf#119649: sd_import_tests2: Add unittest
        
        Change-Id: Ib09e740a4b0e6b5c6e2769c0310aaf44e3392328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133199
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-20  Miklos Vajna  <vmiklos@collabora.com>  [f2ab1375b266d7465ef31d06ec8f949c6b91d853]

        sw content controls: add initial DOCX import
        
        - map inline/run SDTs with unknown type (i.e. rich text) to
          SwContentControl
        
        - decouple block and run SDTs and leave block ones unchanged
        
        - track start position of run SDTs similar to bookmarks, which needs
          different code to SDT at text start vs later
        
        - fix DocxAttributeOutput::RunText() to please
          CppunitTest_sw_ooxmlexport2's testFdo67013, which had an inline SDT in
          footer, not at para end
        
        Change-Id: I59b8b7f3170cf37f1547db07ae0992850e0e3aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133195
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-20  Regina Henschel  <rb.henschel@t-online.de>  [d5fb8d502e77c1dfc77b2c7bdda4bb1540f3ddaf]

        tdf#148501 color shades only for filled PolyPolygons
        
        For shading parts of a shape not of Type 'ooxml-*', ColorData is used,
        introduced about 2005. For 'mso_spt*' shapes they are set directly,
        for others they are encoded as 'col-********' into the Type value.
        During OOo time two changes were made, resulting in the bugs, that
        colors are assigned to wrong segments and that shadings are too dark.
        More details are in the bug report.
        
        With this patch the colors are assigned to the correct segments again.
        The too dark colors are visible in our preset shapes 'Octagon Bevel'.
        The shape 'Diamond Bevel' with corrected color assignment is also
        affected. Both need new ColorData. Since it is important for
        Libreoffice to have good compatibility with OOXML, I have decided to
        use only the four shading values available in OOXML. In the long run,
        these shapes should be replaced by ones that contain the shading
        information inside the <enhanced-path> element.
        
        Change-Id: I4b8323c45bf702fc371d6e6c82dd9102d0fd9929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133132
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-20  Justin Luth  <justin_luth@sil.org>  [8e9a963d20edcf5751705bb64126f51a2ace6b18]

        tdf#148380 sw fieldui: always allow turning off "Fixed Content"
        
        As we add more and more MS fields as fixed,
        some of them are set so the UI to manage that flag
        is disabled. While it doesn't necessarily make
        much sense to allow a user to SET these fields
        as fixed (so don't ALWAYS enable that flag),
        at least allow it to be turned off if it somehow
        did get enabled.
        
        Change-Id: I331c871fa7a3e40a7a0154ab4d7d68c67d9c1dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133086
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [c6fada2bfe38dc8b10908ad95b999b2092c841c5]

        android: Use android.ndkPath property to set path to NDK
        
        Quoting from
        
            commit 128de1949ff120ac925dbb06e398fa992fb295ba
            Date:   Tue Apr 19 15:18:49 2022 +0200
        
                android: Use property instead of ANDROID_NDK_HOME env var
        
        which ported from an obsolete (no longer supported by
        current Gradle versions) way of setting the NDK path to a
        deprecated but still supported one as an intermediate step
        to allow upgrading Gradle:
        
        > Note however, that with this approach of using the `ndk.dir`
        > property instead of the suggested `android.ndkVersion`
        > (with the latter having the stricter requirement that
        > the `ndk` dir would have to be a subdir of the SDK dir),
        > doing the actual upgrade to a newer Gradle (plugin) version
        > in follow-up commit
        > Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f
        > "android: Update Android Gradle Plugin to 7.1.3"
        > revealed that the use of the `ndk.dir` property
        > is deprecated in newer Gradle (plugin) versions as well,
        > resulting in this warning.
        >
        > > > Task :stripStrippedUIDebugDebugSymbols
        > > [CXX5106] NDK was located by using ndk.dir property. This method is
        > > deprecated and will be removed in a future release. Please delete
        > > ndk.dir from local.properties and set android.ndkVersion to
        > > [20.0.5594570] in all native modules in the project.
        > > https://developer.android.com/r/studio-ui/ndk-dir
        >
        > It might make sense to address that in a follow-up step,
        > but for now, it's an improvement and keeps it working
        > after the upgrade without potentially causing any incompatibility
        > problems with existing autogen configurations,
        > while support for the `ANDROID_NDK_HOME` env var that was
        > used so far seems to have been dropped, [...].
        
        The release notes for Android Gradle Plugin version 4.1.0
        mention yet another way of setting an explicit NDK path
        instead of just a version and that one is still supported
        and not deprecated [1]:
        
        > # Set the NDK path
        > You can set the path to your local NDK installation using the
        > android.ndkPath property in your module's build.gradle file.
        >
        > android {
        >    ndkPath "your-custom-ndk-path"
        > }
        >
        > If you use this property together with the android.ndkVersion property,
        > then this path must contain an NDK version that matches
        > android.ndkVersion.
        
        Therefore, switch to setting the NDK path using the `android.ndkPath`
        property in liboSettings.gradle instead of the deprecated `ndk.dir`
        in local.properties.
        
        [1] https://developer.android.com/studio/releases/gradle-plugin?buildsystem=ndk-build#ndk-path
        
        Change-Id: I34690ca8e15ff4742bab9a716a58b9ad85fa86e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133197
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [19363c84e0f9a19e3114cdac2393c81d58865daf]

        android: Set archivesBaseName differently after gradle update
        
        Setting the archive base name in build.gradle using
        
            project.ext.set("archivesBaseName", "LibreOfficeViewer")
        
        no longer worked after
        
            commit 39326bc7d439170dd24c9d4b837c2cdb720b5d6f
            Date:   Tue Apr 19 15:49:53 2022 +0200
        
                android: Update Android Gradle Plugin to 7.1.3
        
                ... and gradle to 7.2, which is what Android Studio suggested
                and did automatically when confirming.
        
        As a consequence, the generated .apk or .aar files
        would no longer have the app name in them, but be
        called e.g. "source-strippedUIEditing-release-unsigned.apk"
        instead of
        "LibreOfficeViewer-strippedUIEditing-release-unsigned.apk".
        
        Setting `archivesBaseName` in `android.defaultConfig`
        in libOSettings.gradle works, so move it there.
        
        Change-Id: Id03cbe10681aca85c35aeef64527bc7707c95736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133191
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e4453c2117b6c3bb15be6b949a0a8a43df66647]

        use more FastAttributeIter::toView
        
        Change-Id: I8a8ad5456fea349a45fca0aa468313cb04aa02f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133198
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-20  Miklos Vajna  <vmiklos@collabora.com>  [2ddf33f78fbc4ce0f49752e4adb9357c1fb69833]

        sw: prefix members of WW8PLCFx_PCDAttrs, WW8PLCFx_SEPX, WW8PLCFx_SubDoc ...
        
        ... and WW8SprmIter
        
        See tdf#94879 for motivation.
        
        Change-Id: Ic0c664e0a17b1c897b25efdac631d8ca016e95b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133193
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-20  Stephan Bergmann  <sbergman@redhat.com>  [a67450a8dd77e29f5b3d67ef035e058253675997]

        loplugin:stringviewparam
        
        Change-Id: I487d665875cfb182a5f30b8e6a3834960c0451e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-20  Stephan Bergmann  <sbergman@redhat.com>  [ed4627a868b94c05797ed30abe8d9f775ee3060f]

        loplugin:stringviewparam
        
        Not sure if the given url is guaranteed to be of a form so that neither of the
        two url.find(':') could return npos, but lets mimic the original code faithfully
        for now.
        
        Change-Id: Ib525b42ccb5b19b4bc13729f973248cf1c8713de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133192
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [d9b3374b13108cf6b847f6eb92fb666194a68770]

        Advanced Diagram support: Use better association Model<->XShape
        
        To have a more direct and more reliable association between the
        XShape/oox::Shape and the model data svx::diagram::Point I added
        optional usage of the Model-UUID for that at the oox::Shape.
        Also added a 'fake' UUID to work with the BackgroundShape's
        attributes. Changed all preserve/rescue code to work based on that.
        
        Also cleanups/comments and preparations of some flags in the
        Diagram ModelData to steer behaviour on re-ceration.
        
        Change-Id: Ie30effdff34dcdbbc79a766de09157b2a3bd97d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133168
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [f22f83fbac3a0a419c2e95d7b725525fd02649e6]

        android: Update dependencies to current versions
        
        This requires the Gradle update from
        Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f
        "android: Update Android Gradle Plugin to 7.1.3"
        as a prerequisite, since the build would otherwise fail
        with
        
        > > Task :desugarStrippedUIDebugFileDependencies FAILED
        > D8: Method name '$private$<clinit>' in class
        > 'com.sun.star.frame.XMenuBarMergingAcceptor$-CC' cannot be represented
        > in dex format.
        >
        > FAILURE: Build failed with an exception.
        
        after updating only the dependencies.
        
        Change-Id: Ifa007fa0e520e9494ace173d1643abb7d7a5f9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133183
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [8917c8b11a4c05e9dd8b0259146179a99ae08a19]

        android: Drop obsolete "sourceCompatibility 6"
        
        This addresses this warning when building Android Viewer:
        
        > > Task :compileStrippedUIDebugJavaWithJavac
        > warning: [options] source value 6 is obsolete and will be removed in a future release
        > warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
        
        Change-Id: Ic1a80117e7e8c31774947729452bfafacd7a24c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133182
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [39326bc7d439170dd24c9d4b837c2cdb720b5d6f]

        android: Update Android Gradle Plugin to 7.1.3
        
        ... and gradle to 7.2, which is what Android Studio suggested
        and did automatically when confirming.
        
        Also apply the following optional, but recommended change
        while doing so:
        
        > Migrate from lintOptions to lint
        > Configuration related to lint is now performed using the lint block.
        
        Change-Id: Ia982d72d877e229c3006c6d528b830d16c88481f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133179
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [76d50f83274549002cedc7dc6ded0e3eac7c277c]

        android: Stop using ANDROID_SDK_HOME env variable
        
        Otherwise, upgrading to Android Gradle Plugin 7.1.3 and
        gradle 7.2 (which will be done in a follow-up commit)
        would make the build fail like this:
        
        > FAILURE: Build failed with an exception.
        >
        > * Where:
        > Build file '/home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/build.gradle' line: 1
        >
        > * What went wrong:
        > A problem occurred evaluating root project 'source'.
        > > Failed to apply plugin 'com.android.internal.application'.
        >    > ANDROID_SDK_HOME is set to the root of your SDK: /home/michi/Android/Sdk
        >      ANDROID_SDK_HOME was meant to be the parent path of the preference folder expected by the Android tools.
        >      It is now deprecated.
        >
        >      To set a custom preference folder location, use ANDROID_USER_HOME.
        >
        >      It should NOT be set to the same directory as the root of your SDK.
        >      To set a custom SDK location, use ANDROID_HOME.
        
        We don't actually rely on `ANDROID_SDK_HOME` being evaluated
        by the Android toolchain, but it used to be set in configure.ac,
        and the value was then assigned to the `sdk.dir` property written to
        `android/source/local.properties`.
        
        Just use a new variable name `ANDROID_SDK_DIR`
        and keep the mechanism otherwise unchanged for now.
        
        Change-Id: I44826621a1342119d40036fb704d8ff1eeed7c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133178
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [128de1949ff120ac925dbb06e398fa992fb295ba]

        android: Use property instead of ANDROID_NDK_HOME env var
        
        Write an `ndk.dir` property with the directory path to
        `android/source/local.properties` instead, similar
        to how it's done for `sdk.dir`.
        
        Also, rename the `ANDROID_NDK_HOME` variable that's
        assigned in configure.ac that holds the corresponding
        value to `ANDROID_NDK_DIR`, because the gradle warning
        still shows up if that environment variable is set in
        addition to having an `ndk.dir` property in `local.properties`.
        
        This makes the following gradle warning disappear:
        
        > > Task :stripStrippedUIDebugDebugSymbols
        > WARNING: Support for ANDROID_NDK_HOME is deprecated and will be removed in the future. Use android.ndkVersion in build.gradle instead.
        > Support for ANDROID_NDK_HOME is deprecated and will be removed in the future. Use android.ndkVersion in build.gradle instead.
        
        Note however, that with this approach of using the `ndk.dir`
        property instead of the suggested `android.ndkVersion`
        (with the latter having the stricter requirement that
        the `ndk` dir would have to be a subdir of the SDK dir),
        doing the actual upgrade to a newer Gradle (plugin) version
        in follow-up commit
        Change-Id Ia982d72d877e229c3006c6d528b830d16c88481f
        "android: Update Android Gradle Plugin to 7.1.3"
        revealed that the use of the `ndk.dir` property
        is deprecated in newer Gradle (plugin) versions as well,
        resulting in this warning.
        
        > > Task :stripStrippedUIDebugDebugSymbols
        > [CXX5106] NDK was located by using ndk.dir property. This method is
        > deprecated and will be removed in a future release. Please delete
        > ndk.dir from local.properties and set android.ndkVersion to
        > [20.0.5594570] in all native modules in the project.
        > https://developer.android.com/r/studio-ui/ndk-dir
        
        It might make sense to address that in a follow-up step,
        but for now, it's an improvement and keeps it working
        after the upgrade without potentially causing any incompatibility
        problems with existing autogen configurations,
        while support for the `ANDROID_NDK_HOME` env var that was
        used so far seems to have been dropped, resulting in
        
        > > Task :stripStrippedUIDebugDebugSymbols
        > Unable to strip the following libraries, packaging them as they are:
        > libc++_shared.so, libfreebl3.so, liblo-native-code.so, libnspr4.so,
        > libnss3.so, libnssckbi.so, libnssdbm3.so, libnssutil3.so,
        > libplc4.so, libplds4.so, libsmime3.so, libsoftokn3.so,
        > libsqlite3.so, libssl3.so.
        
        instead if upgrading gradle without switching to the use of the property.
        
        Change-Id: I4a090e8736dac80777f69b0e12819b9c056f582b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133177
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [258fd217a35444ed245528ccbabdef62869c0419]

        android: Remove redundant label attribute from activities
        
        Android Studio was showing an info/warning in the "Problems"
        pane that this label is redundant, so remove it.
        (The app name is used by default if nothing else is specified
        anyway.)
        
        Change-Id: I799c681488b95e2fffe89b59e7de18febe654dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133174
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  Michael Weghorn  <m.weghorn@posteo.de>  [2ab389b251744fa7f3f6b060c09746e59d87f3b1]

        android: Update compileSdkVersion/targetSdkVersion to 31
        
        Google Play now requires that apps target API level 30 or higher, and
        compileSdkVersion/targetSdkVersion 31 is also needed to update
        the com.google.android.material dependency to >= 1.5.0 [1].
        
        Explicitly set the `android:exported="true"` attribute for activities
        which is required when targeting Android 12 or newer; quoting from
        the list of behavior changes for apps targeting Android 12 [1]:
        
        > Safer component exporting
        >
        > If your app targets Android 12 or higher and contains activities,
        > services, or broadcast receivers that use intent filters, you must
        > explicitly declare the android:exported attribute for these app
        > components.  Warning: If an activity, service, or broadcast receiver
        > uses intent filters and doesn't have an explicitly-declared value for
        > android:exported, your app can't be installed on a device that runs
        > Android 12 or higher.
        >
        > If the app component includes the LAUNCHER category, set
        > android:exported to true. In most other cases, set android:exported
        > to false.
        >
        > The following code snippet shows an example of a service that
        > contains an intent filter whose android:exported attribute is set to
        > false:
        >
        > <service android:name="com.example.app.backgroundService"
        >          android:exported="false">
        >     <intent-filter>
        >         <action android:name="com.example.app.START_BACKGROUND" />
        >     </intent-filter>
        > </service>
        
        The app worked fine in a quick test on an x86_64 AVD with API level 31.
        
        [1] https://github.com/material-components/material-components-android/releases/tag/1.5.0-alpha03
        
        Change-Id: Ibb919e4edb995740e48ebc3338ffab6ca35c1373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133167
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-20  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [ed007423eb4b6d1560d81317b20f291d81bced28]

        tdf#97228 Move ToolbarValue class to separate include file
        
        The ToolbarValue class defined in include/vcl/salnativewidgets.hxx
        was used only by vcl. Therefore, it is now moved to a seperate include
        file named toolbarvalue.hxx which is inside vcl/inc folder.
        
        This header file only contains the definition of the the ToolbarValue
        class. All the files that references the ToolbarValue class now
        include toolbarvalue.hxx.
        
        Change-Id: I78fe3ceb09892c5d3f720ee3d66111bdcdf48db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131321
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-04-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [e9dbbf0f184e4f742d5f0e1a6bc9adcd9d765739]

        tdf#148620: sd: add UItest
        
        I tried to implement this test as a CppUnittest but
        '.uno:OutlineUp' and '.uno:OutlineDown' do nothing there
        
        Change-Id: Ie0d35abcc423999891d6a5dac07ec55d4ca8ee71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133176
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-19  Justin Luth  <justin.luth@collabora.com>  [76de78c338fd508c21289ff2edab80fc4f5d8c23]

        tdf#148565 sw ms export: a new run can't be postponed-started
        
        This fixes a LO 7.4 regression from
        commit 46b62f7777c6acdc2c94dc4b2ab79d38a10c49f9.
        
        A make check with an assert indicated the following
        existing unit tests matched - but they had no noticable
        char run content to test against.
        ooxmlexport6's testShapeThemePreservation
        ooxmlexport7's testBnc884615
        ooxmlexport9's testTdf90789
        ooxmlexport10's testTdf90153
        ooxmlexport11's testTdf137655
        ooxmlexport14's testTdf131539
        ooxmlexport15's testTdf138739
        ooxmlexport17's testTdf126287
        
        Change-Id: Iae89ff1f6de06bfe37b886e1e39e8457157ae240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133187
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-19  Jim Raykowski  <raykowj@gmail.com>  [c7ed23137f7601833793ea8c27e1c601b6d19290]

        SwNavigator: List fields content type members in document order
        
        Currently all Fields content type members may not be listed in the
        order of document appearance. This happens because the sort is done
        using *only* the document model position of the text node (paragraph)
        the field is in. Fields in the same text node (parargraph) have the
        same sort value which results in an alphabetical sort of these. This
        patch uses both the document model text node index and start position
        of the field in the text node text to make the fields content type
        members list in the order of document appearance. This method is
        already used to sort Hyperlinks content type members in the order of
        document appearance.
        
        Change-Id: I05f5ad0699764a265b5320047b67e7f418b7fa99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133101
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [70bea73ffbe815c2d5b7067f20d3eebbb98df61f]

        ucb: webdav-curl: put user name from config into LOCK request
        
        ... so that the dialog in SfxMedium::LockOrigFileOnDemand() can show
        something more useful than hard-coded URL, which has been used since
        commit 99bdd887a6141883878978bad9beb35e7b326cd1 in 2009 when locking
        was added.
        
        This is half of the user info that is put into LO's own lock files
        (see svt::LockFileCommon::GenerateOwnEntry()).
        
        Change-Id: Iefac724644a536fc37c3c79ce862e25bd9be38af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133186
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [68f41f4e2dcec65e8885cdfa658c0568a26182a9]

        ucb: webdav-curl: fix getting DAV:lockdiscovery property
        
        commit b4576f3da4d90139fc5140962d13cb91dab98797 "tdf#82744: fix WebDAV
        lock/unlock behaviour - part 3" added a call to get the
        DAV:lockdiscovery property.
        
        But WebDAVResponseParser puts lock related properties into a separate
        return value maResult_Lock that is only returned for LOCK requests.
        
        Just add it as a normal property too, then PROPFIND can get it, and
        the dialog in SfxMedium::LockOrigFileOnDemand() no longer displays
        "Unknown user".
        
        Change-Id: Icee920588ea40b6e203b18287d75484528cfdebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133185
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-19  Stephan Bergmann  <sbergman@redhat.com>  [441e32d9555f410a0a2df995a70f9958cf2b0f1d]

        Fix heap-use-after-free
        
        ...when dp_gui::ExtensionRemovedListener::disposing
        (desktop/source/deployment/gui/dp_gui_extlistbox.cxx) calls
        
        >         m_pParent->removeEntry( xPackage );
        
        on an already destroyed m_pParent in e.g. the following scenario:  In an
        installation with some bundled extensions (e.g., --enable-ext-ct2n), "Tools -
        Extension Manager...", deselect "Display Extensions - Bundled with LibreOffice",
        "Close", "File - Exit LibreOffice".
        
        It appears the issue was present ever since at least
        051f7b163fa4bf1917fb3db98fed2a6a932a827e "jl152#i77196# Use ExtensionManager
        instead of PackageManager"
        
        Change-Id: I446cba382103828b97a2b1db9fa8afc207b73bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133180
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab699bfdb3375f7142a50cc35322e2924c9e5945]

        new loplugin:stringviewvar looks for OUString vars that can be
        
        ... that can be string_view
        
        Change-Id: I0ddf66725e08b58e866a764f57200dd188b9f639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [f393785a146433cccd5bbecf1e49b5f1485ec5a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 000df5aded9b5cbe2488dc2e9c9406c6b56767c5
          - Related:tdf#147107;tdf#144493 update B&N bar command names and explanations
            
               tdf#144493 (008cfd5980f31c9e01b5cdbede33631d66f2fb56) changed command
               names that are found in the Bullets and Numbering toolbar (and menus
               in Writer, Draw, Impress).
            
               tdf#147107 (3b222bcd75d57db404cd2ed5dc97a5c492c28060) made
               adjustments to some of the command names changed for tdf#144493.
            
               This patch addresses the consequences of these name changes for the
               Bullet and Numbering toolbar in Writer, where the changed commands
               also appear in the Format menu UI. Meanwhile, some of the help pages
               for the changed commands are shared with Draw and Impress, so any
               help file that needed to be changed for Writer was also updated for
               Draw and Impress. In addition to updating the changes in the command
               names, the descriptions of the commands were evaluated and corrected
               when necessary.
            
               text/swriter/main0206.xhp (B&N Bar)
                 *reorder controls on help page to correspond to order on toolbar
            
               text/shared/02/06100000.xhp (Move Item Up)
                 + appl-inline switch for <h1> and icon name to distinguish
                    Writer from the other modules
                 * adjustments and corrections in descriptions
                 + add appl-switch for mentioning toolbar and shortcut keys
                 + add link to relevant toolbar
                 * correction in command sequence for shortcut keys for Writer
                     and Impress.
                 * refactor to <keycode>,<menuitem>
            
               text/shared/02/06110000.xhp (Move Item Down)
                 + appl-inline switch for <h1> and icon name to distinguish
                    Writer from the other modules
                 * adjustments and corrections in descriptions
                 + add appl-switch for mentioning toolbar and shortcut keys
                 + add link to relevant toolbar
                 * correction in command sequence for shortcut keys for Writer
                     and Impress.
                 * refactor to <keycode>,<menuitem>
            
               text/shared/02/06120000.xhp (Move Item Up with Subpoints)
                 * correct the description, with separate explanations for
                   list paragraphs and chapter headings, and mention of
                   multiple selection.
                 * update command name
                 * change .png to .svg
            
               text/shared/02/06130000.xhp (Move Item Down with Subpoints)
                 * correct the description, with separate explanations for
                   list paragraphs and chapter headings, and mention of
                   multiple selection.
                 * update command name
                 * change .png to .svg
            
                text/shared/02/06050000.xhp (Demote Outline Level)
                 * simplify the appl-inline switch for <h1>
                 * correct the description
                 + add separate explanations for chapter headings
                     and list paragraphs for Writer
                 + add link to B&N toolbar
                 + add shortcut key info for Impress
                 * refactor to <menuitem>
            
                text/shared/02/06060000.xhp (Promote Outline Level)
                 * simplify the appl-inline switch for <h1>
                 * correct the description
                 + add separate explanations for chapter headings
                     and list paragraphs for Writer
                 + add link to B&N toolbar
                 + add shortcut key info for Impress
                 * refactor to <menuitem>
            
                text/swriter/02/06070000.xhp (Demote Outline Level with Subpoints)
                 * correct the description
                 * update command and icon name
                 * refactor to <h1>
                 * change .png to .svg
                 * change icon size to 1cm
                 - remove <colspan="" rowspan="">
            
                text/swriter/02/06080000.xhp (Promote Outline Level with Subpoints)
                 * correct the description
                 * update command and icon name
                 * refactor to <h1>
                 * change .png to .svg
                 * change icon size to 1cm
                 - remove <colspan="" rowspan="">
            
            Change-Id: Iaedfebe4f260658bb1f5821ef279846eba22415a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132870
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd2ca9607431fc6ca49e37ab6fef228aa72da5f9]

        tdf#148635 cache some chart stuff
        
        cache some intermediate stuff that it does a handful of times when
        finishing a chart - halves the time taken
        
        Change-Id: I75c5621844d4309b64e64219a7c9e2bcd344ce36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133173
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6500106dff0f0cd86f509ffd01542aab77c21596]

        tdf#148635 no need to init ChartDataWrapper more than once
        
        halves the time to finish a chart2
        
        Change-Id: Ib7f066672878f7630c2d1c90b9487a14f2048029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133172
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Hannah Meeks  <hmeeks4135@gmail.com>  [182833b893ae4ad7430479f2dfebcc9c130cf27c]

        tdf#97361 - make unit tests more pythonic.
        
        Change-Id: I853cda76522ebf3c9a8f7389d5b2b6fc9611f502
        Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133136
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [c929c563e2029bbb969dc417a688cca8934e69b0]

        sfx2: do reload on SID_EDITDOC in SfxViewFrame::ExecReload_Impl()
        
        commit b505ca5b9c31b3d9c639406d03a25bea4e914242 "Switch to read-only
        mode: do not force reload document if possible" replaced "true" with
        "bNeedsReload" here - but this is a problem when switching from
        read-only to editable.
        
        1. Start LO and load a document from WebDAV editable
        2. Start other LO and load the same document from WebDAV read-only
        3. In first LO, edit document, store it and close it
        4. In second LO, click "Edit Document" button
        5. LO doesn't reload the document and shows stale content
        
        It's not clear what problem that commit was trying to solve, but let's
        assume that it intended to change only what happens when switching from
        editable to read-only.
        
        Change-Id: I69c779c5c0c5c2ccda677ea8cb353c8716916861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133171
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [122905d30e8918e0ebe0ad3a84a50c7681ae228e]

        sfx2: fix utterly confusing bools in SfxViewFrame::ExecReload_Impl()
        
        bPhysObjIsYounger variable is actually true if aPhysObj is *older* than
        aMedObj.
        
        Due to the "bNeedsReload = true" that was added in commit
        b505ca5b9c31b3d9c639406d03a25bea4e914242 i had first thought that commit
        b4576f3da4d90139fc5140962d13cb91dab98797 is at fault and inverted the
        condition - but not so, its only crime is mis-naming the variable and
        the "bNeedsReload = true" is actually dead code because this branch
        always returns before any use of bNeedsReload further below.
        
        Meanwhile, commit f1035312f80746fdf4a7a04039db73b27d1387c3 actually did
        invert the condition, but that was in 2004 and presumably intentional.
        
        Change-Id: Ie342163a1de434f99c521e97711157a76191da0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133029
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [d40c6601330b70c3cb9c1be0fa9e9775ad51113c]

        tdf#148313 Basic IDE crashing while resizing dialog
        
        Change-Id: Ic68b78f26626f346f3ef8b54a584de64165d9eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [cd8848acc93346e5613bc8c1fdc1d6c74c099f1f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5bab8a2d2530d7487064a2560c440269018a56b9
          - tdf#148621 Make ScriptForge service tables mobile-friendly
            
            - Introduce <tablehead> element
            - While considering text-align, I noticed we do not take RTL languages
            into account. A CSS rule 'html[dir=ltr] th' was added, which does
            nothing at the moment. We should look into directionality.
            
            Change-Id: Ib59aa0c508529c0beaa35542d96bd5cc1aa4db29
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133114
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0c424ba729e4659ce1007254adbbceafbeaef5b]

        dont keep writing to config when persona is set to 'no'
        
        Change-Id: I87233fc2a8b1099a7468b28add1b87e864908f4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133169
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Mark Hung  <marklh9@gmail.com>  [7418fc88021a7d2cb45eb3b029466ed7a14d3338]

        tdf#148594 correcting the number of kern spaces.
        
        A glyph item ( or a glyph cluster ) may be made up of
        more than one sal_Unicode values ( e.g. CJK ideograph extension
        B characters that need surrogate pairs, or unicode iVS that have
        a base character and a selector ).
        
        Insert the kern space only when KernArray value changes. I.e.
        character belongs to a different glyph item or cluster. Count the
        number of needed kern spaces in the same way.
        
        Change-Id: If79766bda37cf4d10ca5be2d51dfdc992eaf9cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133093
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-04-19  Seth Chaiklin  <sdc.blanco@youmail.dk>  [2f5cc5a4249feb4ffded2892aef5957d2aed192f]

        tdf#144493  adjust changes to GenericCommands.xcu
        
         There are no chapters in Draw or Impress, so the label changes by
         008cfd5980f31c9e01b5cdbede33631d66f2fb56 in
         officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
         to uno:OutlineUp and uno:OutlineDown were inappropriate.
         Remove "Chapter" from ContextLabel, and just make it "Label" so that
         Customize matches command name in menus, and add TooltipLabel for
         toolbars that gives a more informative tooltip.
        
         No text changes for uno:OutlineLeft and uno:OutlineRight, but same
         label changes to make command name in Customize correspond to name
         in menus, and add TooltipLabel that gives a more informative tooltip.
        
        Change-Id: I03a43089654721b9023912c29835e9f56ffc5b26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133049
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-19  Noel Grandin  <noel@peralex.com>  [a93346144e2948fc5b2afc31601eb49a1a2838eb]

        use of template param here confuses Visual Studio
        
        version 17.2.0 Preview 3.0
        
        Change-Id: If73d984b0bbcfd85667ab859db7d86514af6c2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-19  Michael Stahl  <michael.stahl@allotropia.de>  [42c6dfa1662603793cf6e2c5be99a8a8ed0acaa1]

        sw: check if cursor position is valid before inserting file
        
        SwXTextCursor::insertDocumentFromURL() must not insert the file inside
        of an input field.
        
        If the CH_TXT_ATR_INPUTFIELD* become separated to different text nodes,
        things are going to break.
        
        Change-Id: Ia170e63f6c6d8a8fdd18f0b91e2b333e660ed924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133028
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-04-19  Stephan Bergmann  <sbergman@redhat.com>  [b12727e15a82216f709ccb6e37a9029d60ad4831]

        loplugin:stringviewparam
        
        Change-Id: I8f27a2260e7195dd0a7dbb0b5e3dd0064ef06c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133164
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7321d43155e91eeb4302ba94ab917b773695f944]

        Extend insertDocumentFromURL documentation
        
        Change-Id: I892c876ff53a0aaf2ce4d484604ef0c2a95d8801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133035
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-19  Julien Nabet  <serval2412@yahoo.fr>  [dc97aac5cdfa3789d4e71e9d92df6e7e68802825]

        Following tdf#142151: Red cast rendered in 16 bit TIFF image
        
        Just simplify by merging both almost identical parts.
        
        Change-Id: I1658621609e10312feed530090adfa873602d2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133115
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [41560f52a93602b61253e942d8a88046745c16aa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26cd9a5e8be28097e59188bcdf6bcaa9c75be4e4
          - Fix typo
            
            Change-Id: I624ec6267f5a72105c3d600d390849586b839da6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133154
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-04-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d3c22b1d4754e95a0fbb801a73295e5a4353f38f]

        chart2: change define to constant
        
        Change-Id: Id545105cb48fdd0c28a67e6017570658915f93b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133163
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [216493f32236f0086f4c5b527deb18b020b0ed1c]

        chart2: not really worth having a TrueGuard - just use ScopeGuard
        
        Change-Id: Ia2436d4cc843540a51e00ee937b80303cb600851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133162
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [540a54f59b49ee79a8db3cbcbfc184df5b8f433f]

        chart2: ExplicitValueProvider - make forward declrs. consistent
        
        Change-Id: I90e8b2d163f700c7b1e251064af8655529f76906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133126
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [efb39149be1744def96ef015d1d184b5af3f43b7]

        chart2: move ExplicitValueProvider impl. out of ChartView
        
        Change-Id: Ie1bcae70c5a5df3978f8890c127f9aae1ae9237b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133125
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Luboš Luňák  <l.lunak@collabora.com>  [57751a4a103d872774461d4da6622aa39680d26d]

        cosmetic changes to support the mold linker instead of "unknown"
        
        Current mold 1.2.0 seems to work fine, except possibly for GDB index
        (https://github.com/rui314/mold/issues/439), which can be worked
        around by doing 'strip --strip-debug' on the relevant crt*.o files.
        
        Change-Id: I097bb0b37fc31393f8e9a45ec068c5f05259b2f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133123
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-18  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a31a7b53c42eef3a8007766c60ec5a2539054a7c]

        tdf#147472: sw: bug in numbering with previous level NONE
        
        Previous fix for tdf#146257 was not complete and was not able to
        take care of disabled numebering started just at beginning of the
        numbering string.
        
        UI test test_tdf144439_outline with modifications is covering this
        situation. No need in extra testcases.
        
        Change-Id: Id17838cec7fb4fb039f9b457b7ee9ad3ab345678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133124
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e50f6cefdc92d98b16abcdaad11f1eb046dc7652]

        uitest: sw: move field dialog tests to their own place
        
        Change-Id: I9b4b462af85cea7e2427b4025a268dcc200fff51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133130
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-18  Jean-Pierre Ledure  <jp@ledure.be>  [bf51fd3de339555567b76cbe9a2de54fdfd18bd3]

        ScriptForge - (SF_Calc) new CreatePivotTable() method
        
        Create a new pivot table with the properties defined by the arguments.
        If a pivot table with the same name exists already in the
        targeted sheet, it will be erased without warning.
        
        Parameters:
          PivotTableName: The user-defined name of the new pivottable
          SourceRange: The range as a string containing the raw data.
            The first row of the range is presumed to contain
            the field names of the new pivot table
          TargetCell: the top left cell or the range as a string
          where to locate the pivot table.
            Only the top left cell of the range will be considered.
          DataFields: A single string or an array of
            field name + function to apply, formatted like:
              Array("FieldName[;Function]", ...)
            The allowed functions are: Sum, Count, Average, Max,
              Min, Product, CountNums, StDev, StDevP, Var, VarP and Median.
            The default function is:
              When the values are all numerical, Sum is used, otherwise Count.
          RowFields: A single string or an array of the field
            names heading the pivot table rows
          ColumnFields: A single string or an array of the field
            names heading the pivot table columns
          FilterButton: When True (default), display a "Filter"
            button above the pivot table
          RowTotals: When True (default), display a separate
            column for row totals
          ColumnTotals: When True (default), display a
            separate row for column totals
        
        Returns:
          Return the range where the new pivot table is deployed.
        
        The method may be used in Basic and Python user scripts.
        
        Change-Id: I99df23e1b1b97b17a747ae15a079d7e2f5655b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133131
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-18  Noel Grandin  <noelgrandin@gmail.com>  [383b55a38da0d92b4499f38b4d7f5ff036e0072f]

        tdf#148620 Crash in Draw using Format > Lists > Move Down
        
        This reverts
            commit 35f03f26799747894d1534796b6cb227bd4f233b
            speed up loading large ODS a little
        since ImpEditEngine::ImpMoveParagraphs wants to manipulate
        ParaPortion's and also identify them by pointer
        
        Also convert the OSL_ASSERT in this method to an assert
        to catch such problems earlier
        
        Change-Id: Id924d00c9524223db9a96e487b331ce60e3a4fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4845e68e6575030464c260406b667f0a51bf4a9e]

        tdf#142151: vcl_filters: Add unittest
        
        While at it, use the files Julien attached to the bug report
        to test 8 bits and 16 bits
        
        Change-Id: Ibed7409483e33200f6183db3df2bd5a0ad6f6a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133116
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-18  Isha_Desai  <2020.isha.desai@ves.ac.in>  [7de83e464d21f68e1c88b9bf69264482fcc1e49d]

        tdf#143148 Use pragma once instead of include guards.
        
        Change-Id: Ica5fa2616f271d02099eaa4e9cb02481b3e100d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133129
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-18  Isha_Desai  <2020.isha.desai@ves.ac.in>  [5e843d732d0a3f7613eaf003fc5c8dcc595b578d]

        tdf#87605 Added a few technical words.
        
        Change-Id: I591d984dba621f6845544fd36c03f9a0800dd4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132640
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1fdd501e3d0df156d330d4a3454a88f156fe8f25]

        chart2: convert TitleAlignment enum to enum class
        
        Change-Id: I0cfc0bb74b2e218c579a5f7e7ed8e39c01838fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133122
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dc8cbdae0a96708872cbfb6bd6e21deec2ce9a0b]

        chart2: extract SeriesPlotterContainer into its own file
        
        Change-Id: If190f0d99d5686e90fa56487744a9a663b345fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133121
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [45cdc2e83ff4a6464de4618c22dc2a402442d524]

        chart2: extract AxisUsage from ChartView into AxisUsage.hxx
        
        Change-Id: I680196af9c349c37312f177ab84051f0b68deae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133120
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f80376d76c6956c4b6321162cdb94128746420fa]

        chart2: use a constant instead of a function for a contant value
        
        Change-Id: I21cbe01732bf78f58b3242669e696fb1f82aa64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133119
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5c562a39c901e51c0dd5fef92f7c0ea97fdb2829]

        chart: cleanup member vars in Diagram.hxx
        
        Change-Id: I756d570ba932e116bb346f21b5272807e8434939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133118
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2e9e057913d5f31490f62ad60d2bae39ae81afee]

        oox: move DataTableConverter into own file
        
        Change-Id: I3dce87ecd5b8f69862f26edb66fe54c6acee8660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133117
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Julien Nabet  <serval2412@yahoo.fr>  [49ee1c889665c3539fa9a1c99a865a42fc08ee97]

        tdf#142151: Red cast rendered in 16 bit TIFF image
        
        I found this fix by testing "pure" red/green/blue files (see attachments in the bugtracker)
        where red 16 bits file was ok but not green and blue 16 bits ones.
        
        Change-Id: Ic700a0fa17c3056d1d4f1d1a7f16a799ff4c7378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133108
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-18  Siddhant Chaudhary  <urssidd@gmail.com>  [370077502210f4d41a1d2014c3e3f99536217ce7]

        tdf#42982 Improved UNO API error reporting.
        
        Messages to thrown `RuntimeException` instances have been added to make
        the error clearer.
        
        Change-Id: I566c475bd4ddf891a2cebf15664576cff792c118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133100
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-18  Batmunkh Dorjgotov  <bataak@gmail.com>  [f0d61446df66dd026419dae25fc9a8cfaccfb079]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e0a820ca5c6a4a7e5175a4191f21a2ec3108ee86
          - Update Mongolian dictionary
            
            Change-Id: Iefd26d95473785a73e77f8a3f459a50d1da03d27
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/131063
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2022-04-18  Justin Luth  <justin_luth@sil.org>  [c136249982345b205da83d1907e21da0c7bab7dd]

        tdf#148380 docx export: use content of unknown fields, not name
        
        This used to be GetCntnt, but then out of the blue in a huge
        squashed commit, it changed to GetFieldName. So I assume that
        was just debugging code that got accidentally committed.
        It just doesn't make any sense to export the field name
        as the plain text content instead of the field's value.
        
        commit ed40f62e64564d2b22c9285cfdc6778aeac8fd68
        Author: Michael Meeks on Mon Mar 14 16:51:14 2011 +0000
            Merge commit 'ooo/DEV300_m101' into integration/dev300_m101
        
        NOTE: DOC also does a .replace(0x0A, 0x0B),
        //replace LF 0x0A with VT 0x0B
        //#i19604# convert hard line breaks inside fields to word equivalent
        
        After taking care of SAVEDATE, PRINTDATE, I tested this with
        assert(rInfos.pField->GetFieldName() == "Sender");
        and found no other examples.
        
        Change-Id: Ie24b8c176fe6df4015be221c87aa249fe9b8ce92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132666
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-17  Caolán McNamara  <caolanm@redhat.com>  [f8e11c6480ff0005715b989a6d4e2e10a3816cf6]

        Revert "ofz#46632 Direct-leak"
        
        This reverts commit 4659fc2f0a7223a89446edff0b77e58758b5edf5.
        
        Change-Id: Id8d654ff4c36185b08012ab5a69f7cf75fc43249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133106
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-17  Caolán McNamara  <caolanm@redhat.com>  [178044ec01227771542de809f8140d107035ca0f]

        ofz#46782 Timeout
        
        Change-Id: I14129770c7fc8505c8060d79fa8bb9683a688a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133107
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-17  Caolán McNamara  <caolanm@redhat.com>  [689d1f5dd3dc12d9f85ba98702a66c7af20849dc]

        Related: tdf#148349 gtk[3|4] use a css effect to draw attention to the widget
        
        Change-Id: I96af6c87d5aeab6513ff782a0bf25554602b4953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133105
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-17  Aman Jha  <amanjha752001@gmail.com>  [7784744b1fbc0e07c1b01addd1043606e8a631da]

        tdf#143148 use pragma once in idlc
        
        Change-Id: I2f7108da12f8345a0b13754398c38c068aa74be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132853
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [11ad1fe346b16b388280018b0ef3f4130a45dd40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 24828f91e22842cdaf64faf7d22a028541e5746c
          - tdf#148621 Improve Basic Help layout
            
            - Get rid of tables
            - Add normalize-whitespace Prism plugin to get rid of useless indents
            - Fix code blocks poking through sticky header
            - Add some word wrapping CSS to fix mobile-unfriendliness
            
            Change-Id: I73fd1e0678624b0d4bd5561f50e80990db5567be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133096
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-17  Caolán McNamara  <caolanm@redhat.com>  [e8157e60561b950f6a7d8a577145f034912e742d]

        ofz: Null-dereference
        
        Change-Id: Ib058458860f606736455ae997a6f7f74de5585bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c69db531ede119b950fbe1f35560f94e762e1070]

        Removed duplicated include
        
        Change-Id: I09556d8041023f765980d8b5cf953b955545d0b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133023
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [33bd16b344e273c427091ee68e946bf67b371dd7]

        loplugin:stringviewparam convert methods using copy()
        
        which converts to std::string_view::substr()
        
        Change-Id: I3f42213b41a97e77ddcc79d84d512f49d68ca559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-17  Mike Kaganski  <mike.kaganski@collabora.com>  [fe597a337914decd62480d3eba84258333116db9]

        Test StarBasic's native non-ASCII name syntax
        
        Change-Id: Ie9f0cd21e59ffc1e3fbe2616e2ae7abbd0169424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133103
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [00e5bf746f85edf32ab7464abec2f4fccfc46bcd]

        use more string_view in sc
        
        Change-Id: I5f77167ad874200fa4f7bc16e5de8a3348cb1886
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-17  Jim Raykowski  <raykowj@gmail.com>  [8f27cde891cc925d5ff76a736fb54dd70e53b4ee]

        tdf#148237 Show 'Footnote' and 'Endnote' as field name for field cross
        
        references to footnotes and endnotes
        
        Change-Id: Ie1828c9c4ec0c3c8159c8e5653b09b2b7bd8a5e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133092
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-17  Jim Raykowski  <raykowj@gmail.com>  [f7102dafc44a66b8ffb7b8d516fe1720fc45f8fe]

        SwNavigator content tracking: clear selections and entry cursor
        
        when entry is not found in content tree
        
        This happens when the document cursor is positioned on table of content
        hyperlinks.
        
        Change-Id: I717b2dae31780b26cf5450fbea0c8f461659770c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132989
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [7337c4181331eaf091050181d4c21be5911ac815]

        use more string_view in sw
        
        Change-Id: Iaf4db41d913dde13ea1ceb3fbbb3dafc21f90d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-16  Hossein  <hossein@libreoffice.org>  [622b92dab29aff0fe9f23cf6fbf00dc7347bb34a]

        Update README.md files
        
        * Fix typo
        * Improve links
        
        Change-Id: Ie77ec795675bf7497c90620eb44ebb3191c003b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133067
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [670d07cc05b286e1f35b77b73a636ae259af5fb6]

        Fix typo
        
        Change-Id: I3f2da2522f80fdcbbd377686032a1f8e919e4484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133065
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-16  Caolán McNamara  <caolanm@redhat.com>  [95ee4f074f387b498a9083524a13dff636446fe7]

        Resolves: tdf#148197 crash on launching context menu with no row selected
        
        Change-Id: I4b05e6013ec4fb8f3968484a59c2dacf1e1c97ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133095
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [553dd8c722b4261da8b9aaa406a17fe30d3b5476]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d70f37fcc80c0b6c4fbfa36709ec1b1e9002a40
          - refactoring Line tab help pages
            
                  text/shared/01/05200100.xhp  (Line dialog)
                    *refactor <h1>,<h2>,<h3>
            
                  text/shared/01/05200300.xhp (Arrow Styles tab)
                    *refactor <h1>,<h2>
            
                  text/shared/00/00040502.xhp  (#line2: "howtoget" line tab)
                     +add appl-switch for "howtoget" Line tab
            
            Change-Id: I800a4c69ffce4edc88aec86b5e6cbe6a2e4d4f9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132707
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-16  Stephan Bergmann  <sbergman@redhat.com>  [590eb262e7841ff8d62246487ce9fb428ea5a9e6]

        -Werror,-Wunused-const-variable
        
        ...since a8383345174d91f6e722128e1d53c9a4ebc18195 "No Win16-style WIN.INI since
        Windows Vista"
        
        Change-Id: I36fa3f6516a6bd9ac6593e01163c1f3427933e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133090
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-16  Justin Luth  <justin_luth@sil.org>  [d9b33ed6644203141fdb0776c291425c2bc9f5ac]

        tdf#148380 docx export: support CHANGEDATE/PRINTDATE without format
        
        This is the same idea as the earlier patch for CREATEDATE.
        However, it isn't safe to import these as fields,
        so a round-trip test can only test the string itself.
        
        The unit test here really doesn't test any of the code changes,
        but is just pre-emptive to ensure that if DI_CHANGE
        is imported as a field that it will have the right
        output.
        (P.S. Expected date output matches MS Word 2003
         even after an F9 refresh.)
        
        Change-Id: I30a8b1fc851246898a67e6241a35e927f85dfbb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132664
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-16  Caolán McNamara  <caolanm@redhat.com>  [4659fc2f0a7223a89446edff0b77e58758b5edf5]

        ofz#46632 Direct-leak
        
        there is no DeinitVCL for fuzzing, so fill the fontoptions,etc cache
        before starting
        
        Change-Id: I14a30c3d38490d03c31b4c349674ba48dd32de15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb21bbc1210dc270a125613d571521701e379ff9]

        tdf#148551: sw: Add UItest
        
        Change-Id: I118c0c91f0ba90f57761512e8e9984186ab4ac19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133080
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b4b3398736d42bf1e3de4b397510576fdc5c3338]

        tdf#135377: sw: Add UItest
        
        Change-Id: I6e00601e1e8a6971e2668a744a3faac06344403f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133084
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-15  Regina Henschel  <rb.henschel@t-online.de>  [b195cf4db4c21da3cf754689fb22f0b6a904a03e]

        tdf#109169 use custGeom for Octagon Bevel shape
        
        The shapes 'Octagon Bevel', type col_60da8460, and 'Diamond Bevel',
        type col-502ad400, are LO specific preset shapes. They have neither a
        counterpart in MS binary nor in OOXML. So they need to be exported
        with custGeom. To force custGeom these shape types are moved from
        vDenylist to vAllowlist.
        These shapes were exported as prst='rect' before.
        
        Change-Id: I9619345812b6dba8f14ec2cc6a92ae808a56b595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133069
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [65e846d73c023cb8ed8a8393a91032d4a816f2a0]

        use more string_view in jvmfwk
        
        Change-Id: I05f3b171578b8fef5b15dcbbf10ae9b7cf2d1b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [15d8762dd07289447e782a3812dfd4425fe9a82b]

        use more string_view in cui
        
        Change-Id: I377d95ec2d80cef611c6fce274f1e17504132564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [267a0e94920dbaf3f9db316c9cbfe6fa72be8818]

        tdf#143483: sw: Add UItest
        
        Change-Id: I10d05ea3f2866523e5adaac9ba768073b03c15a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [4cc5ceb9e3349fccc8ba08fdacb444ae70c597eb]

        Adapt to clang::PPCallbacks::InclusionDirective change in Clang 15 trunk
        
        <https://github.com/llvm/llvm-project/commit/d79ad2f1dbc2db63121620f55d6cfa915f2733ac>
        "[clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective()"
        
        Change-Id: Ib2ea325cca3be03d3b5dfb9dfc3d870be659b129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133085
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [d1da1c59d196b7f6037b7e0820b81fc527d56a4c]

        tdf#148349 add a way to call the user's attention to a widget
        
        Change-Id: I2846155a44f3e51ddd8cc1acd81e84a38b4d3934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [fbfda267e8f4b55dff30a3827bff760565f36fdb]

        gtk[3|4] add the css "warning" "error" to GtkEntry when those states fit
        
        Change-Id: I4063155d25b80f6b5912f0b63dc3c8fa21c7263b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [211fb753067f315597ac79f13c1bc553407fbf2f]

        gtk4: warning and error are explicitly mentioned in the documentation
        
        Change-Id: If61b40e6d104ba54e71c4473bf1214a6df999089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [37fb1cbf7bceac8421741dc55b89146a42a77a22]

        Related: tdf#147237 change the SalObject background when the settings change
        
        which solves the problem of parts of the gtk ui remaining in the old
        theme when switching dark<->light
        
        Change-Id: I59060dfdf3937ca13cd706eefc9e67c133478992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133076
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Rene Engelhard  <rene@rene-engelhard.de>  [67c577c692faaa0382d26c3c3f47b5ffa9deaa77]

        apply ICU test workaround to < 70 to "fix" test with ICU 71
        
        See also 263961306ede0656ebb7904034a2172615ce81d0
        
        Change-Id: Ib64ec43dba59ffddb34fe7f1a0f0d2e589c3455c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133063
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9a15395dc1d71a9597296e0e29e266cf9441a7e]

        use more string_view in connectivity
        
        Change-Id: I916db7599e600ba795e02b7afd29b54d1dc7187e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133073
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [558aaa9ed222e7142fe87c9bab9a8293a5e2a159]

        use more string_view in xml*
        
        Change-Id: Ie219cb3feb98660463858d00f82f882881946ad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133072
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba74c925a5ef872c291613d4be589e1ab4b4e9e1]

        use more string_view in fpicker
        
        Change-Id: I2568dfa05082bbd2d3a433c54b47039455d91153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133071
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5d5c7e8c385f8a7e6ab824095e61aeeca4ab8c7]

        tdf#148494: export: Always add space separator
        
        Otherwise, the macro is saved as MACROBUTTONAllCaps
        instead of MACROBUTTON AllCaps
        
        Change-Id: Id1288e23f21ce72884bc1197f171e255ea7458f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133077
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-15  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b2b821715a3745718a941fa99dda92137c0f0c86]

        tdf#148551: sw ui: set default format value for Insert Field dlg
        
        My previous implementation was changing current format selection
        only for field edit dialog. However it should be initialized also
        for insert field dlg. It is not always first element. Instead of
        older confusing approach right now there is a switch to set
        defaults: it is less confusing IMO.
        
        Change-Id: I189339ba66effc49267004a42345a28892cb693c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132980
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [9efab24f38bb5e4b150c842cda51cfd76d694022]

        use the same colors for warning/error for gen ComboBox as Entry does
        
        Change-Id: I0fb24c0d60c66348052334c9a86e6a5425dccb46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [a0f9f8ddaaa4ca14c9cc37259e2ac5dce63b3c77]

        tdf#148448 pick a warning color more likely to be readable in dark theme
        
        I can't see anything that is useful which could be used to derive this
        so just pick a better hard coded color
        
        Change-Id: Ia351e636ed3a44e9af79147b2d9dfcf347bd8ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [b9c806b9e3631d76b8ceaa6208497aba60c75f83]

        address potential find/rfind failures
        
        in the conversion in
            commit 74957c7d2f3697fbf2b6f4d6a31c61d5d7df039b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Apr 13 13:54:22 2022 +0200
            use more string_view in l10ntools
        
        where the prior code might have been relying on the -1 returned by
        indexOf and lastIndexOd
        
        Change-Id: Ief5dedccbaf4e14e5f59aa3c2f7481ff0bb7e2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133027
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [6fd447aaf2f21a4708ca4e4268e209f4499cbeee]

        loplugin:stringviewparam
        
        Change-Id: I6b7e0482fca0d1b82afa13131ef5206763e1ccb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133032
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Szymon Kłos  <szymon.klos@collabora.com>  [dcc9d7f0a0e8a6978ada6e92244cd6cd4b276520]

        jsdialog: close popup correctly
        
        call popdown so we will mark popup as closed in DockingManager
        this fixes crash when trying to open autofilter popup second time
        
        Change-Id: I9f2db6fe284d9b9770c20dea4b8a4054524a998b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132619
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132917
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-15  Szymon Kłos  <szymon.klos@collabora.com>  [02c9687b0792a568897f911a0f8d6e1582fdbe6a]

        jsdialog: autofilter: unify with regular popup
        
        - remove special type "autofilter"
        - now autofilter will be handled by dialog code in online
        
        Change-Id: I3478c3e05ab2e83030a8d68632d0426a5cc0accd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132539
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132916
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [53ec893208e2fb82d1569a1e2414b83b5a20bbfa]

        warning: found </li> tag without matching <li>
        
        so use same solution as com/sun/star/style/XStyleLoader.hdl
        
        Change-Id: I53e77cb6547338f66d7e259779bb5391bc780765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132999
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Caolán McNamara  <caolanm@redhat.com>  [0ba7674c7389db8f1cf7eb089dc1c89ed93be778]

        ofz: Timeout 23s->4s
        
        Change-Id: I10d48584e0ab0ce52cabe8077602f557b6392492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133012
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [21121b0cba765958f38176ba17be85b6bc3bcb58]

        Also add C++20 char8_t overloads
        
        Change-Id: I1c55ca09b9fd24927acce9f0e2e2d435f23a3e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133031
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [020cf33af4de4f9a0b3a9b920d0b1035959df440]

        loplugin:stringview
        
        Change-Id: I4e03bb0674dff734c41f4206b1849ede3c6949ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133055
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [6a9f342addf8b1c766163575c7b63e7fcc1f714e]

        Introduce rtl::createUriCharClass
        
        ...to make those char class array initializations more readable.  (Making the
        corresponding variables constexpr is mostly done so that failures in the
        provided `unencoded` arguments, like non-ASCII characters or duplicate
        character typos, would lead to compile-time errors also for !HAVE_CPP_CONSTEVAL.
        And assigning to a sal_Bool std::array needs another hack to avoid false
        loplugin:implicitboolconversion warnings.)
        
        Change-Id: Ieb8827f69f55f1212a9428817d5331fcb18ef1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133058
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [d7480ed72d225ee1b2b9a6ec996eeeb7a18c98a8]

        Add some clarifying comments for o3tl::getToken overloads
        
        Change-Id: Ia81b11b659f6045f9e474b3a32b72e2c5242a80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [f23f594b17a2b117e0940ecff86b878955bf6e3e]

        loplugin:stringviewparam
        
        Change-Id: Id3bd8576b134728140dc68b00eebf78a8f3fd4ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133056
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [6457b72667de2a203e25a18b0f58cde67d41bbf4]

        loplugin:stringviewparam
        
        Change-Id: Iac1655373f5f30e3499fa5335405fb422fa8dc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133054
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Stephan Bergmann  <sbergman@redhat.com>  [dcd969ba5237e897c5767854df30f31fc8b4ee32]

        loplugin:stringviewparam
        
        Change-Id: Ie9dc89642c197baaf1ecfdfcd340cb6a427147ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133033
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-15  Mike Kaganski  <mike.kaganski@collabora.com>  [a8383345174d91f6e722128e1d53c9a4ebc18195]

        No Win16-style WIN.INI since Windows Vista
        
        Change-Id: I75bc8c7c61e863747cdfc65fb4ed7603c0eb1c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133034
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e1f3f2e00c37173e5f6f1cbb5235ab95b100bde7]

        sc: introduce SparklineShell and Sparkline context
        
        Having a separate sparkline context is very useful, so we can add
        a custom UI when the user has the cursor over a sparkline. This
        will allow a "Sparkline" tab for NotebookBar and its own deck in
        Sidebar, activated only when the sparkline is present. Also the
        pop-up menu can be customized specifically for the sparkline, but
        this may be less useful.
        
        For the sparkline context we need a custom shell - SparklineShell
        where now all the UNO commands can be implemented (not done in
        this commit).
        
        Change-Id: Idca2ad946af3afdd1b494744b80c9c093eec602c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133022
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-15  Eike Rathke  <erack@redhat.com>  [abe0080d66fe81013d92bbc3521980e049640f6d]

        Prepare SvNumberFormatter::GetEditFormat() to obtain for another locale
        
        Change-Id: Iab8b9a802ebac60b52007754430352d3de925374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133026
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-04-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [32e38ec654cfd467aad74da59366bd41142b3bdc]

        oox: move DataTable{Context,Model} into own file, prop. "showKeys"
        
        Move DataTableContext and DataTableModel into its own files and
        add the missing "showKeys" property of the data table (dTable).
        
        Change-Id: I44fb436000c7f00a596fc9b12489d15ea1368e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133021
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ee76783d2b2718a66bceefc6f8a71019daa7cc5b]

        lok: report state for sparkline UNO commands
        
        Change-Id: Ic1e8464ec97ef91f631944dbaa3de0e5bff26c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133006
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [7582286258984d790274295aea1cd7eb6ad96602]

        Add some clarifying comments for o3lt::getToken
        
        Change-Id: I417f048cdcd74e0a06b4c08d7d1851ea3e8a7077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133015
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Luboš Luňák  <l.lunak@collabora.com>  [4557ea11aeda19b705b4d701bdd1b85db7f0b206]

        move vcl::text::TextLayoutCache caching to the class itself
        
        I have no idea why I did that in GenericSalLayout.
        
        Change-Id: I163b08045e7c1dcdbf35cf408525f8dbcc06c4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133019
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [4475483b92da89f6ab7fa503c6db920b7b50d1b7]

        use more string_view in sd
        
        Change-Id: I301f3d8a6634df8be5fdd42649c0c265da8f9099
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Michael Weghorn  <m.weghorn@posteo.de>  [003e2873e4463974e59e1f909f9250cde743851f]

        android: Use proper Intent to open doc for API level < 19
        
        `Intent.ACTION_OPEN_DOCUMENT` was introduced in API level 19,
        therefore `Intent.ACTION_GET_CONTENT` is supposed to be used
        for older Android versions.
        
        The previous attempt at doing so didn't work, since no
        `ActivityNotFoundException` is thrown when trying
        to set the action to `Intent.ACTION_OPEN_DOCUMENT` on
        older Android versions.
        
        Fix that by using a proper version check instead.
        
        Change-Id: Ie06fa3f39e3042b4b7161a3c937bf655eb658abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133025
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-14  Michael Weghorn  <m.weghorn@posteo.de>  [f869807175f1fc49328465473aa8e90b6f1876ff]

        android: Use "ContentResolver#query" available from API level 1
        
        Use the `ContentResolver#query` overload that is available from
        Android API level 1 on, not the one that's only available from
        API level 26 on [2], which would otherwise trigger an exception
        if run on devices running Android version < 8.0, as seen
        on an AVD with API level 21:
        
        > E/AndroidRuntime( 2914): FATAL EXCEPTION: main
        > E/AndroidRuntime( 2914): Process: org.libreoffice, PID: 2914
        > E/AndroidRuntime( 2914): java.lang.NoSuchMethodError: No virtual method query(Landroid/net/Uri;[Ljava/lang/String;Landroid/os/Bundle;Landroid/os/CancellationSignal;)Landroid/database/Cursor; in class Landroid/content/ContentResolver; or its super classes (declaration of 'android.content.ContentResolver' appears in /system/framework/framework.jar)
        > E/AndroidRuntime( 2914):        at org.libreoffice.ui.FileUtilities.retrieveDisplayNameForDocumentUri(FileUtilities.java:137)
        > E/AndroidRuntime( 2914):        at org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:206)
        > E/AndroidRuntime( 2914):        at org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147)
        > E/AndroidRuntime( 2914):        at android.app.Activity.performCreate(Activity.java:5937)
        > E/AndroidRuntime( 2914):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1105)
        > E/AndroidRuntime( 2914):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2251)
        > E/AndroidRuntime( 2914):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2360)
        > E/AndroidRuntime( 2914):        at android.app.ActivityThread.access$800(ActivityThread.java:144)
        > E/AndroidRuntime( 2914):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1278)
        > E/AndroidRuntime( 2914):        at android.os.Handler.dispatchMessage(Handler.java:102)
        > E/AndroidRuntime( 2914):        at android.os.Looper.loop(Looper.java:135)
        > E/AndroidRuntime( 2914):        at android.app.ActivityThread.main(ActivityThread.java:5221)
        > E/AndroidRuntime( 2914):        at java.lang.reflect.Method.invoke(Native Method)
        > E/AndroidRuntime( 2914):        at java.lang.reflect.Method.invoke(Method.java:372)
        > E/AndroidRuntime( 2914):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
        > E/AndroidRuntime( 2914):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)
        >
        
        [1] https://developer.android.com/reference/android/content/ContentResolver#query(android.net.Uri,%20java.lang.String[],%20java.lang.String,%20java.lang.String[],%20java.lang.String)
        [2] https://developer.android.com/reference/android/content/ContentResolver#query(android.net.Uri,%20java.lang.String[],%20android.os.Bundle,%20android.os.CancellationSignal)
        
        Change-Id: I13ecc57d3d6b25a7eb2e5ff85a3420ef8064cb20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133024
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84de0b351c959c9a1ebbbd61bf0702561afc4d82]

        Fix typo
        
        Change-Id: I5707dbda5468256c8d03ac35b43fb54b8b4f3c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132991
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [6e53140dd3d7b414e81718d55ec288c4640ed587]

        cid#1504075 Uninitialized scalar field
        
        Change-Id: Ib24e34cabf99876b4aba56a768a34cd0da22a8dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [e1db8c27875eac73b1e619e4a23ecdb7a9924b61]

        Resolves: tdf#143615 clamp relative times to 1.0
        
        User input permits zero-length animations, so whenever we calculate
        relative position within the animation time frame, the case
        mnMinSimpleDuration == 0.0 means: we're already at the end of the
        animation, i.e. set relative time to 1.0
        
        Change-Id: I0e8c1e29f47bd9fa16f04115cf52d3a176e13fb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133005
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [af4407649d2c8a2ea59487d5fc1f8cc742ddd0b2]

        use more string_view in unotools
        
        Change-Id: I5fc3753475c3c6a45f86910eeb49055f96a2e925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133013
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a5b28eaaaf8ff56778fcdfb28f0a660592c7866]

        address review comments
        
        (*) fix parameter type of getToken()
        
        Change-Id: Ib6fcfc6b217e98f57e600dc44c888366b432c19e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133011
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Jim Raykowski  <raykowj@gmail.com>  [78b723c3a1fad1c095de1e5c746aef513556a53b]

        tdf#52113, tdf#148312 Don't include table of contents hyperlinks
        
        in the Navigator content tree Hyperlinks entries
        
        Change-Id: I8d4499ecd6d9f617192560b31d7f87f7f26269f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132988
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [36b7288a0ce9588b958e0b3a68613e9ee11cf17c]

        Use DeclCheck at one place in loplugin:implicitboolconversion
        
        ...and add tests for those additions to isBoolExpr done in
        8e4d82cd1125502c26ddaaa85c49c4aa44f65811 "loplugin:implicitboolconversion: warn
        about conversions to unsigned char" (and which were added to avoid false
        warnings like
        
        > testtools/source/bridgetest/bridgetest.cxx:643:21: error: implicit conversion (IntegralToBoolean) of call argument from 'unsigned char' to 'bool' [loplugin:implicitboolconversion]
        >                     (xLBT->transportPolyBoolean(
        >                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        and
        
        > cui/source/options/optaboutconfig.cxx:359:62: error: implicit conversion (IntegralToBoolean) of call argument from 'unsigned char' to 'bool' [loplugin:implicitboolconversion]
        >                             sValue.append(OUString::boolean( seq[j] ));
        >                                                              ^~~~~~
        
        )
        
        Change-Id: I0683144e1c39d31303faf678afaafd708ef7ff79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133018
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [9798f8ad50602cf1313a2804b86e79fb80c1ec4d]

        use more string_view in ucb
        
        Change-Id: I0aa83a1496436d6fb77ad85d24ba088a7ff75f6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [0d5c5c17a43726c1407d100e440a87ed06966d30]

        Resolves: tdf#148476 allow dialog resize buttons to "shrink" again
        
        a problem since:
        
        commit 5d388b94735e34ba445d65e1d5030a646aad7dbe
        Date:   Thu Jan 27 12:17:48 2022 +0000
        
            Related: tdf#146648 let SetWindowState size trump the initial layout pref size
        
        Change-Id: Ia765fc011e740386fce568704cb1efb066a5d5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Michael Weghorn  <m.weghorn@posteo.de>  [70cb4955f1c099b030567e6bf4702f7dc6ee521a]

        android: Port from Android Support Lib to AndroidX
        
        Replace the no longer maintained Android Support Library
        with the Android Jetpack libraries.
        
        Quoting [1]:
        
        > Version 28.0.0 is the last release of the Support Library. There will be
        > no more android.support library releases. All new feature development
        > will be in the androidx namespace.
        
        Most porting was done automatically by using Android Studio's
        "Refactor" -> "Migrate to AndroidX..." function.
        
        In `android/source/res/layout/toolbar_bottom.xml` and
        `android/source/res/layout/toolbar_color_picker.xml`,
        the uses of
        `app:layout_behavior="android.support.design.widget.BottomSheetBehavior"`
        had to be replaced manually as described at [2], because
        the app would crash when using the old "android.support"
        values.
        
        Also drop the Android Support Library related bits from configure.ac
        
        In a quick test, this worked fine and no obvious
        difference was visible when running this in various AVDs.
        
        When trying to test this in an x86 AVD still using
        SDK 16 (Android 4.1), which is currently specified
        as Android Viewer's `minSdkVersion`, only various
        unrelated issues showed up, some of which will be
        handled in follow-up commits.
        
        After the migration, many weird errors showed up in
        Android Studio, which disappeared after invalidating
        the caches (via "File" -> "Invalidate Caches...").
        
        [1] https://developer.android.com/jetpack/androidx
        [2] https://stackoverflow.com/questions/45100963/runtimeexception-could-not-inflate-behavior-subclass
        
        Change-Id: I2a57f0ebd56e7ecc09b7d65aae17fd15088a633b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133002
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [bfc43aad0e8eb90e9d3495b940bc2283081f04c6]

        Prevent save interception when sharing Calc doc
        
        Using the dispatch mechanism means that this can be caught by the dispatch interceptor
        which we don't want in this place.
        
        Change-Id: Ie7e5f92e6043e2aff98d4887829a3573c12c6d08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132941
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [3f793465819f63aa001f5842f232be24d13153fd]

        tdf#148101 don't autocomplete remote files dialog entry on delete/backspace
        
        Change-Id: Ieddb41eb37e7090416a418afeffb76ce0eddf90a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [ae0e7e3918284c31a91acca0f733919926ae3a62]

        tdf#141812 keep focus in an impress table cell when row/col deleted
        
        Change-Id: I3b396ba92039bad657ca159002598a271b68a79d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133008
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [590323f4235e5ec3de2dc6dee28a4f03288ac6d7]

        use more string_view in dbaccess
        
        Change-Id: I256ffe22fa060be6a6fc32e73d845879d71a187d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbe92dcfa79e3336411661fc94106deeba9317d6]

        use more string_view in chart2
        
        Change-Id: I9ab6cd3905bfb7c811e7ad14b54ced6c42d2e077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [871adb006645d0fd5eeecab70ea4c937de85c38e]

        Fix comment again
        
        ...which had been butchered by c7fb93764b321e5bf4cd143dd0c29be60de6d8f8 "Cleanup
        comment":  e4ff847fe0796420ba8023b70cad8589f5f19e9f "loplugin:stringview check
        for getToken and trim" had turned this into a template, but had not lifted the
        other restrictions.  But while at it, also adapt the mention of "OString" and
        "std::string_view" in the comment to that
        e4ff847fe0796420ba8023b70cad8589f5f19e9f change.
        
        Change-Id: I3c27efe145c4bea6c4b16f81da671bf22160545c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133000
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Justin Luth  <justin_luth@sil.org>  [206efef78ea367de76f000a1760dbd8bc7785b0c]

        tdf#148380 sw ms export: DI_EDIT is simply EDITTIME
        
        There can be no author related to total editing time,
        and SAVEDATE is the modified date, so this was all
        completely bogus code.
        
        No unit tests hit SAVEDATE on a make check assert.
        
        This all came from very early 2000 code,
        at which point DI_CHANGE only handled AUTHOR,
        so likely things were very confused back then,
        and when SAVEDATE was connected with DI_CHANGE in 2003,
        they failed to remove it from DI_EDIT.
        
        Change-Id: Ib9108a59128d5c7fa11d350c58005a925678cb4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132665
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [dfafd186f5884bfb7a19582b36677a051bde8101]

        warning: explicit link request to 'ItemState' could not be resolved
        
        Change-Id: Ied2c063d532a5da01d5b542e6f44ab49d198a942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [a8f89d5a6240b5e374e19c0c4df377f8b1f80e2f]

        tdf#148197 gtk_tree_row_reference_new_proxy warning on docking navigator
        
        Gtk-CRITICAL **: 09:05:11.124: gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed
        
        from TreeView::set_cursor(-1)
        
        gtk_tree_view_set_cursor is ok (and documented as such) with an
        "invalid" path to unset the cursor, but there isn't the same for
        gtk_tree_view_scroll_to_cell, though there null is docs as acceptable.
        
        Change-Id: I11b94ba997fbbd2f31031d9e73765ea1882ad9ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132996
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [c36f9e981d583c5f62943db9cf4116cbda0f0501]

        Pick a better variable type
        
        Change-Id: I1c9d3bcb1e750b130a04105ab9cf370b7f31f392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132994
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Luboš Luňák  <l.lunak@collabora.com>  [4fc3466d23010d9553c31c662650072483b81588]

        do not cache layout glyphs if fallback is involved
        
        In some rare cases (CppunitTest_writerperfect_writer can trigger them
        on Win/Mac) the fonts used for fallback change and it's not included
        in the cache key.
        
        Change-Id: I9611d500405d0dae7f95fa4469ccfaa39de672c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132995
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [250a70dc37a921b71049817d5e46aae2eb4cced6]

        use more string_view in oox
        
        Change-Id: I25fe1cbfae43bb533e7dfc2561d0b70976aa6a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132985
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [41fa4bb83ad95f0b2171808b405fa755613cef81]

        use more string_view in filter
        
        Change-Id: Ieff65b96487051721f9016c005523f31b7415901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132984
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [14f6700fefa945c4cf995c09af9326c2a022f886]

        use more string_view in editeng
        
        Change-Id: I5104dc8ce24089b110f9cd73e0f5e62ad5b44a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132983
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-14  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [edadfb564f1334887df473f9bc05dab6b1e7ef9d]

        Advanced Diagram support: Secure properties at Diagram ModelData
        
        Additionally to the Text/Attributes already saved/secured after
        Diagram import, secure more data that is part of the Diagram
        ModelData. This is about attributes (e.g. FillStyle/LineStyle,
        TextAttributes, ...) in UNO API formt that will be secured/
        attached to the Diagram ModelData in it's
        svx::diagram::Point structure.
        This is done for all those entries for which a XShape will/
        would be incarnated, thus associated to entries that will
        get a visualization, including the BackgroundObject.
        From that data, at re-creation time, the attributes can be
        re-applied to the re-created XShape(s), also after changes
        to the Diagram Model Data (e.g. Add/Remove).
        This is - besides the already added securing of the Style/
        Theme - a 2nd method for lossless re-creation. For the
        BackgroundObject - if it has FillStyles - it is even the
        only method to secure that data and thus necessary for that
        case. The selection of atributes that gets secured is minimal
        for now and may/need to be extended for existing cases
        accordingly.
        
        Change-Id: Ie9b72b9b9135113cf858d57fe6cd8622d736c4a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132976
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-04-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [16bbd139d6a54c47e4fd4a034dbcc238a75f2097]

        Removed duplicated include
        
        Change-Id: Ifac2665115cd5b84cd68fff8f1414b9f1c1fb510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132990
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [9a42c99d7b3e8a8429f14d7d851f3d186fa04594]

        Simplify equality comparison among the various UNOIDL integer types
        
        Change-Id: I67b11049938de470a2a5096cac376fdb0529ab5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132992
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Stephan Bergmann  <sbergman@redhat.com>  [fc2413e9a8f509bc6835cae473bf5053728c419a]

        Pick better variable types
        
        ...tweaking the code slightly to guarantee that j will always be non-negative
        
        Change-Id: Ie8ba450884cc8b12e0caa79b4d75f95dd96cc120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132993
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [5bfbb64cb9ae102e5a1f5b4cd020d0cd006d0a92]

        ofz#46630 Indirect leak
        
        Change-Id: I2af5f9e0b8ac210f6d1a7700ac6cb6213d706e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132986
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  Caolán McNamara  <caolanm@redhat.com>  [c15fceae5e70483daf8355a9b7d53215b7643c2b]

        Resolves: tdf#141625 give enough space to see full date+time
        
        Change-Id: I31193783231f27494ed1507faa143697e8facc30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-14  NickWingate  <nick.wingate@collabora.com>  [a1f9fea520f5b3f5d54a284886aa531693f32e7a]

        Make accessibility check dialog async
        
        Signed-off-by: NickWingate <nick.wingate@collabora.com>
        Change-Id: I88913b3d7e580a1d8c69a39454f2598e11ba43ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130438
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit 61fed0c4fe53738254d116543417f1c7028a0f39)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130451
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-04-14  Luboš Luňák  <l.lunak@collabora.com>  [6c8dffc19e2a570d5665344dcba6afedd3dc2e15]

        compute subset of glyphs in SalLayoutGlyphsCache (tdf#139604)
        
        When OutputDevice::ImplLayout() computes glyphs, the result
        is always the same for the same string (and font etc.),
        and if the function is asked to work on just a subset of the string,
        the returned glyphs are often also a subset of glyphs for the full
        string. Since e.g. EditEngine breaks text into lines by first
        laying out a full string and then repeatedly calls the same function
        for a subset of the string with increasing starting index. So if
        the full result is cached, it's faster to just make a subset of that,
        adjust it as necessary and return that, instead of doing a layout
        again.
        
        This requires support from harfbuzz to tell us if it's safe to break
        at a given position, and HB_GLYPH_FLAG_UNSAFE_TO_BREAK is that
        (https://harfbuzz.github.io/harfbuzz-hb-buffer.html#hb-glyph-flags-t).
        
        I'm keeping the optimization for tdf#144515, as avoiding the extra
        layout altogether is still useful.
        
        Change-Id: I33f70f9af89be79056e464908eac0861f58d274a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132753
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-14  Szymon Kłos  <szymon.klos@collabora.com>  [63abdec59d2fc23c988cb7c160bd4625e7e464a9]

        lok: send status update for .uno:SplitCell
        
        Change-Id: Ic972d3ff3334f4c3a507868a95ac955c9ffbc614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132585
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132871
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-14  Seth Chaiklin  <sdc.blanco@youmail.dk>  [3b222bcd75d57db404cd2ed5dc97a5c492c28060]

        tdf#147107 "chapter" -> "item" in B&N toolbar and menu
        
          Changes to:  Move Chapter Up, Move Chapter Down,
                       Move Chapter Up with Subpoints,
                       Move Chapter Down with Subpoints
        
           Also capitalization correction ("With"->"with") for
           Demote Outline Level with Subpoints in Bullets & Numbering
           toolbar and menu.
        
        Change-Id: Iacb0e798c54bf4101f7048454007bf58ec4081c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132869
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [187bf06aabf1b730cfcd47cbdf976f58b4960dcb]

        tdf#114303: sw_rtfexport4: Add unittest
        
        Change-Id: Id07c834a58db7aedada8a923a464f554f30f3013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132973
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-13  Caolán McNamara  <caolanm@redhat.com>  [056b81ff51f57da83c4d4b5de479bac1aa366694]

        Resolves: tdf#148122 Celtic MD font appears wrong
        
        Change-Id: Ib551f073b8ea0e0662660ccf01ebf56c2fd7f340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-13  Stephan Bergmann  <sbergman@redhat.com>  [58f533029b5cbd31993f2c667b16d3b487258e85]

        Clean up O[U]StringBuffer ctors taking a length parameter
        
        For !LIBO_INTERNAL_ONLY, go back to the state before
        d91d98a53612a972de368186415aa48698e074d9 "fix gcc-4.0.1 and/or 32bit build for
        string literals" of having just a sal_Int32 overload.  (For !LIBO_INTERNAL_ONLY,
        the current state was confusing, as the existence of further overloads depended
        on __cplusplus >= 201103L.)
        
        And for LIBO_INTERNAL_ONLY:
        
        * Have overloads for all integral types, with an assert checking that they do
          not use out-of-bounds length arguments.  (The std::make_unsigned_t dance in
          the assert is needed to avoid signed/unsigned mismatch warnings as seen at
          least with MSVC.)  This removes the need for explicitly casting arguments that
          are larger than (unsigned) int.  (And I cleaned up two such places that I had
          become aware of with the abandoned previous attempt
          <https://gerrit.libreoffice.org/c/core/+/132825> "Let O[U]StringBuffer ctors
          take sal_Int32 length parameters"; there may be more places to clean up,
          though.)
        
        * Have deleted overloads for all integral types that are not actually integer
          types.  (This excludes signed char and unsigned char, as at least
        
        >                             OUStringBuffer aBuf( rToken.GetByte());
        
          in ScTokenConversion::ConvertToTokenSequence in
          sc/source/ui/unoobj/tokenuno.cxx does a legitimate call with an argument of
          type sal_Int8 aka signed char.)
        
        Change-Id: I2df77429f25b74f19cc3de5064e6fd982e87b05e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132951
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-13  Michael Stahl  <michael.stahl@allotropia.de>  [ab65a74998b498ff49c15db87fc14a9afa89d8bf]

        ucb: webdav-curl: oops, increment after checking
        
        Change-Id: I8c51fa88253dbda595eb859d58408ad70ad661e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132982
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d55188fbf7b0399f01bae521f1a34d22ad8ba18]

        use more string_view in xmloff
        
        Change-Id: I0d860fa6e3d3261f3393e912b27930066dd93f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [902e81b1b0c62993270846962d44aea6774e9687]

        use more string_view in configmgr
        
        Change-Id: Ia8aab5ea1a03d1512a1da806d505ce06f6977828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Tor Lillqvist  <tml@collabora.com>  [ab612633003c75dfb30664db8cc8924c086a91ee]

        Follow-up fix to Collabora Online "addfont" handling: avoid assertion failure
        
        Change-Id: Ib75954a39d515088dbd432d0aa0ca5893194ecc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132970
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-04-13  Michael Stahl  <michael.stahl@allotropia.de>  [2bc4d1d22fdbd9d97c66bb53762b4b4bf7b61b47]

        ucb: webdav-curl: only allow system credentials for auth once
        
        ... and in any case abort authentication after 10 failed attempts.
        
        Apparently some PasswordContainer can turn this into an infinite loop.
        
        Change-Id: Ib2333b371a770999e8407ce7e1af21512aadb70d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132974
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [1aced94715b73cc0de2ab91963a4f2a2102d845a]

        use more string_view in sfx2
        
        Change-Id: I36db3d26a576adeb4d2427c28320096d5464f565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132964
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [d2572dc9d6c7cda9d6e08e46c42048e12e4f04e0]

        android: Deduplicate LOKitThread#load{,New}Document
        
        After Change-Id I15ecc2eba6c5ee441f6e14f8229594cab05dbba7
        "tdf#148556 android: Don't delay refresh when loading doc",
        the only thing that `LOKitThread#loadNewDocument` does
        in addition to `LOKithThread#loadDocument` is to save the
        newly created document (to a temp file) if loading was
        successful.
        
        So, have `loadDocument` return a boolean saying whether
        loading was successful and call that method from
        `loadNewDocument` to reduce duplication.
        
        Change-Id: I9b99e011b3f5105bb60f95174de393462ff08271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132966
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [4476fd51a324930e832535c10979564afc6968f2]

        tdf#148556 android: Don't delay refresh when loading doc
        
        The previous way of using a separate Runnable
        to do the refresh and posting that to the
        main handler instead of doing the refresh
        right away resulted in a timing issue, due
        to which it could happen that a Calc document
        would not be rendered when initally loaded
        (but only after another tile reevaluation was
        triggered, e.g. by tapping on the screen).
        
        While this appears to happen mostly on fast hardware,
        I could reproduce on my AVD as well when increasing
        the minimum time that has to pass between
        tile reevaluations to 100 ms:
        
            --- a/android/source/src/java/org/mozilla/gecko/gfx/ComposedTileLayer.java
            +++ b/android/source/src/java/org/mozilla/gecko/gfx/ComposedTileLayer.java
            @@ -157,7 +157,7 @@ public abstract class ComposedTileLayer extends Layer implements ComponentCallba
                     }
        
                     long currentReevaluationNanoTime = System.nanoTime();
            -        if ((currentReevaluationNanoTime - reevaluationNanoTime) < 25 * 1000000) {
            +        if ((currentReevaluationNanoTime - reevaluationNanoTime) < 100 * 1000000) {
                         return;
                     }
        
        For the bad case, the Runnable that triggers the
        refresh would be taken from the message queue and
        run on the main thread at a point in time that
        resulted in `LOKitShell.sendTileReevaluationRequest`
        not getting called in `ComposedTileLayer#reevaluateTiles`
        due to the above-mentioned minimum time in between
        tile reevaluations.
        
        Avoid the problem and simplify the whole handling by
        no longer posting a Runnable to the main handler, but
        calling `refresh()` right away.
        
        Posting to the main handler had been introduced in
        
            commit 27326e0f587c20d8dcf1595829233de1bd3fbe9e
            Date:   Fri Aug 3 07:13:00 2018 -0700
        
                tdf#119082 Exception wrong thread on Android Viewer
        
        to avoid crashes due to things being done on the wrong thread
        when switching to another app and then back to Android Viewer
        (s. tdf#119082), but that is no longer a problem, because the
        document is no longer loaded anew in that case since
        
            commit 1bc42472200c32c9a0a10dd1c3cd6c6a8a5d47d2
            Date:   Fri Apr 9 13:59:43 2021 +0200
        
                tdf#95517 android: Rework app/doc lifecycle handling
        
        , so the code path is not used there any more, but only when
        the document is initially loaded, triggered in
        `LibreOfficeMainActivity#onCreate`.
        
        After all, the problem seems to be a similar one as fixed in
        
            commit 128f67e0efa02294205a1abe1be874557ecdcecd
            Date:   Tue May 18 14:27:51 2021 +0200
        
                tdf#142348 android: Avoid extra refresh after loading doc
        
        , where another timing issue in the handling of a refresh event could
        result in a blank page instead of the Calc doc being rendered.
        
        With the refresh being done right away, the synchronization added
        in
        
            commit 55661298bb3e9087a89a08637e4285f090c4e0e8
            Date:   Wed Apr 1 09:00:13 2020 +0200
        
                tdf#131195 android: Don't destroy doc while loading it
        
        is also no more needed, because the situation described in its
        commit message no longer applies:
        
        > Since the 'refresh()' in 'LOKitThread::loadDocument' is
        > not executed synchronously but posted to the main handler,
        > this needs to be synchronized to prevent the document from
        > being deleted while it's being used.
        
        Change-Id: I15ecc2eba6c5ee441f6e14f8229594cab05dbba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132965
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-13  Michael Weghorn  <m.weghorn@posteo.de>  [827d97887a8284e09fdeb2aa2918f60f09fd1a4a]

        tdf#148553 liblo-native-code: Add services for numeric controls
        
        Change-Id: I67727b8ced6c501f0e220fa2024976640ca7028a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132950
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-13  Luboš Luňák  <l.lunak@collabora.com>  [cd1b93aafad2bd868025d363be9a913a2913ef39]

        empty SalLayoutGlyphsImpl is not automatically invalid
        
        Empty SalLayoutGlyphs is considered invalid, because otherwise
        it should have at least one *Impl, but an empty *Impl is apparently
        possible if it's a fallback but it doesn't find a single glyph.
        This avoid the warning in OutputDevice::ImplLayout(), triggered
        e.g. by CppunitTest_writerperfect_writer.
        
        Change-Id: I410d269b07ffb73f9860806ede9cd0b809668342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132968
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-13  Hossein  <hossein@libreoffice.org>  [3a641c344d35df13437f97e68ee5cfd993845e91]

        Add info on limerest / dump drawyinglayer primitives
        
        * Add information on dumping drawyinglayer primitives as xml
        * Add link to a new tool named limerest on gitlab
        
        Change-Id: I50a0018d9c3063281b2a761d437bb9def0f34bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132936
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [239752d358a44d9bd9e5e2a9b7e6084da97d8862]

        use more string_view in vcl
        
        Change-Id: Iabe6c14d17c7805fcc3697cd919234abe3f0a0f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132963
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [dae0083c69e91fff3c4f5db762e4189bbdc6eb7f]

        use more string_view in svl
        
        Change-Id: I9b6a074eb6342808d02a69f3ed1fa713e81d2608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132958
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5343a89f898468178f04c241de0b2c2a314a1b5]

        use more string_view in cppu
        
        Change-Id: Ifd2ee4827e0083ffaff9120fee239fb16553380e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132957
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [74957c7d2f3697fbf2b6f4d6a31c61d5d7df039b]

        use more string_view in l10ntools
        
        Change-Id: I93958e8e2dc1e172413ff697d6b6be975cff064d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132956
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Caolán McNamara  <caolanm@redhat.com>  [e8c2ae74ea433d9d75baf7ff8a349a0c86ace657]

        give SwParaPortion a const GetDelta() and non-const SetDelta()
        
        instead of two GetDeltas() one of which is non-const and returning a
        reference that can be used to modify the delta
        
        no logic change intended
        
        Change-Id: Ia5788bfffd169a589eb9b9b141b60575ab165391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132953
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [064f4fe82c30118a34c4aeb47bf8604f0b8356a1]

        tdf#139991: move 0-byte file handling to SfxFrameLoader_Impl::load
        
        This centralizes the code that handles templates, and allows the empty
        files to use default templates.
        
        This partially reverts commits:
        
        ada07f303e7cd1e39c73abe0741aefe7d9d73a57
          Author Miklos Vajna <vmiklos@collabora.com>
          Date   Wed Oct 28 14:54:52 2020 +0100
            tdf#123476 filter: try to detect 0-byte files based on extension
        
        2854362f429e476d4a1ab4759c6a1f1c04150280
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Wed Jan 27 16:05:54 2021 +0100
           tdf#123476 filter: Also handle empty ODF
        
        dff586735b6618d9b011823594a33287d8f7f223
          Author Mike Kaganski <mike.kaganski@collabora.com>
          Date   Mon May 03 17:04:04 2021 +0200
            tdf#123476: also use filter by extension when its service is the same
        
        The unit tests from these commits are retained and extended for templates.
        
        Change-Id: I755738d2d5a6d6955d84d6e12f3accc017e0391f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132938
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-13  Caolán McNamara  <caolanm@redhat.com>  [15f70da655301be4d66abf91ee788b50e8ab1215]

        upgrade to libwebp-1.2.2
        
        Change-Id: I76e11f21ecf2da7803407fa4bf6556b545f8f4a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132949
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-13  xuenhua  <xuenhua2008@sina.com>  [0be48023938b74e1bde3b675bbc5481df7550470]

        Fix typo
        
        Change-Id: I77ee60e6e7c5482f49cb671d793687f831856628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132918
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [05867c4e5f6d244f0f18db2a00e6fbc0d8141a41]

        tdf#80633 speed up dialog layout
        
        some small speedups when opening Format->Paragraph
        
        Change-Id: If97725ecff45b9c2c01b405e153ec05b12882573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Tor Lillqvist  <tml@collabora.com>  [5de22d1e559cd0f1f5fa4e247f0ce153710fbeab]

        Handle "addfont" from Collabora Online
        
        We use the AddTempDevFont() API to add a new font. Sadly there is no
        corresponding way to remove such a temporarily added font.
        
        Change-Id: I6fe61919daa5af29e964cec1caf7293aefa8ea4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132948
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-04-13  xuenhua  <xuenhua2008@sina.com>  [64c61aeb6be78bcfe458e72054bcea4792eb40e0]

        Fix the error message for GNU Make version
        
        Change-Id: I65b2c02badf619da284a3d5191270e412ae2834e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132739
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-13  Mike Kaganski  <mike.kaganski@collabora.com>  [b210c45d19e8791402d1f3aa9b3bb5bcd6c95f79]

        Move extension preparation out of the loop
        
        Change-Id: I6e4b5397e3d0ae9b943e261e9fca95735ccc9a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132866
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-13  Justin Luth  <justin_luth@sil.org>  [55c7691fadfb9b3a4869cc14432ec57c858f693f]

        tdf#148380 doc: Import AUTHOR/CREATEDATE as FIXEDFLD
        
        Writerfilter already did this earlier in the patch set.
        So now change DOC format to do all the same things.
        
        Change-Id: I8db2b4e3fc227b73c4d075ee624117e1b1f1d92e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132663
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-13  Miklos Vajna  <vmiklos@collabora.com>  [ada2d449175afd9a6aa1db9281739e5ad6ac6fef]

        sw content controls, DOCX export: handle SDT end at para end
        
        Once the DOCX import maps Run SDTs to SwContentControl,
        
        	make -C sw -sr CppunitTest_sw_ooxmlexport17 CPPUNIT_TEST_NAME=testTdf148361
        
        starts to fail without this fix. Previously we only tested
        SwContentControl end in the middle of a paragraph. Fix the paragraph end
        case similar to how hyperlinks are handled to be consistent.
        
        Change-Id: I0633ca8d7d909a2cb3c70e7edce3a85df5fac3f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132944
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-13  Stephan Bergmann  <sbergman@redhat.com>  [634990f32c354dd7690b6ae44b19a94c9f19ffc4]

        Fix copy/paste typo in comment
        
        Change-Id: I90d350abefebf3545c47f9460627435b4a514e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132940
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-13  Szymon Kłos  <szymon.klos@collabora.com>  [b632135072090bd241caee25814a07d7c8c36d00]

        jsdialog: reenable after welding, unify with dialogs
        
        Change-Id: I4a589f68fcdaa1c62ac08bd6075071d0fed0b28b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132538
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132915
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-13  Miklos Vajna  <vmiklos@collabora.com>  [6b92b144219acbbb43d0dfa9cd7c28aa1c16b6e9]

        CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
        
        See commit feeed3e762cf077fbd9cf48f82e949365108ccc1
        (CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
        2022-04-07) for motivation.
        
        Change-Id: Ic0647b9e43517e80487c66e8ee13e48eeebbdabb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132939
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [fdfd517a6f75e394ddcb1e195decbfed33ba56b9]

        loplugin:stringviewparam whitelist some more functions
        
        for which we have o3tl:: equivalents
        
        Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [e568c9dca8b93b96a8a130a8fb6f1bba1a33d6ea]

        Update remaining DevGuide wiki links.
        
        My Kate editor decided to do some whitespace cleanup, but maybe
        it's fine as the main changes are not targeting functional bits anyway.
        
        Change-Id: I5292e77e43055f94a6256a7f72d49fd59287d194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132928
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-13  Miklos Vajna  <vmiklos@collabora.com>  [c7970e3204f7e2d958d213c42a9f0db232578a62]

        sd theme: add UNO API for shape fill color effects
        
        XColorItem::maThemeColor already provided the document model for this.
        
        Change-Id: Iefbd0aeaa37a813bb4c86386801e0116e8fae40d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132933
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a98971ac975e19efa2336b608506eefa85ce2485]

        vcl: move X11 drawing that uses cairo into X11CairoSalGraphicsImpl
        
        If cairo is available we override drawPolyPolygon and drawPolyLine
        with an implementation that uses cairo to draw instead of X11.
        This override was previously done in X11SalGraphics, but as we want
        to have all the drawing in backends (SalGraphicsImpl children) this
        also needs to be moved to one. In this case we can just derive
        X11SalGraphicsImpl and implement specifics there. As there is some
        common stuff now betwee X11SalGraphics and X11SalGraphicsImpl,
        also add X11Common, which includes those.
        
        Change-Id: Id1e0c5227506e03d3dd0f937e4ef50d69b17bb22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132827
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [07745a031da255991c2d4c1533e916bb604d66c2]

        don't ignore GetDefPattern() in ScHorizontalAttrIterator
        
        As said in the previous commit, the default pattern is the default
        style that can be edited by the user, so it's principially incorrect
        to simply ignore it. If needed for performance, then it needs
        to be done explicitly. This change currently should not affect
        anything, as ScHorizontalAttrIterator is used only in tests.
        
        Change-Id: I31f153d427cdfd6e98a4d7a3584cfa89676d4c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132912
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [4d45d9886fa5830f4c8c92268ffca4297650ed70]

        don't artificially clamp attribute iterators range
        
        Even ScDocument::GetDefPattern() can be modified by the user (it's
        the default style that can be edited), so it's conceptually
        incorrect to ignore it while iterating, and clamping to allocated
        columns is also no longer needed. If this makes some code slow,
        then that needs explicit handling in that code or some other
        way of speeding things up.
        
        Change-Id: I4a7c7fef0a8625b559bbce4580df19a5e9ed92a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132911
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [e3830b06a9886620ed432a011d2de2abbb7a3a12]

        don't FormatDoc() a whole long text if not necessary (tdf#144515)
        
        The testcase has a very long text in a cell that is really high
        enough to hold only one line of text, yet EditEngine formats and
        wraps the entire string. Which can be expensive because of calling
        into text layout to find out width of a text portion, and this
        is done repeatedly for the yet-unformatted text, so pretty much
        O(N^2). For top-aligned text it's enough to format only as much
        as will fit and ignore the rest, so implement that and add
        EditEngine::EnableSkipOutsideFormat() to enable the optimization.
        
        Change-Id: Ida87a1843737a368798ba2b3e60eedc99ee0f611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132932
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [efb60b6fb5e11c31fecddf1e0502c1fe4feb7b57]

        treat Calc cells that don't fit as top-aligned rather than bottom
        
        For cells it normally looks better to align them to the bottom,
        but if the content doesn't fit, it looks better to align to top,
        because that shows the start rather than the end of the content,
        and it also logically goes together with the clip mark shown
        to the right of it.
        
        Change-Id: Iac51e9e59d5ab9f5c89374a3e638a4a572f8b1fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132931
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Stephan Bergmann  <sbergman@redhat.com>  [8e02f081ab405fe0a51614a37acd32e743c01056]

        Remove need for OPropertyAccessor default ctor
        
        Change-Id: Ia5ae4e28aa880600ce80bd284cde5183c49e4b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132929
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [01cb63b986d0879e10b58991959e0989b125b577]

        gtk4: GtkCellRendererPixbuf no longer takes a surface
        
        so use our own replacement when we want to continue to use a cairo_surface
        
        Change-Id: I4a1a0e7f5a86d27a4290cf71c0719ea017be3f0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132930
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [cbf9f638807736e69a5863a19128ade085b1a187]

        ofz#46352 Timeout
        
        Change-Id: I4544c9c15ec26fb1c27ec0f28ef956320d06a149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132900
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [e21fa6a5fdca05c49b4fcb9961690cfb6e240909]

        [loplugin:stringview] pass a 'std::string_view'
        
        Change-Id: If2e355729f051cd5be517fb05e8909844a24c7f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132927
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [77bc0bcfb610b77a9191af2343f64eae36073540]

        gtk4: add a surface_cell_renderer
        
        to bridge our continuing usage of cairo and gtk4 GtkComboBox cell renderers
        without dropping any existing hidpi wins
        
        Change-Id: If5244766c13dd5d82445cb626ef4096e3c6ea244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132926
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [8e0c19973726961d2099e541a74c9ff788f9df43]

        resave with latest glade
        
        Change-Id: Ib84f706deccc1f71810abc97a4208d5106826235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132901
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [9c47425041eb8c610da2963bdbaa707a6d3ea1f9]

        ofz#46632 Direct-leak
        
        Change-Id: I01fe4ae8907fb95708d54a39d1cc78d89b4d6e64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132893
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [f7fd2d4e3ec89afa524b3dac1c8533acafa9a015]

        gtk4: cairo_gobject_surface_get_type() needs to be called at least once
        
        before "CairoSurface" can be resolved to its type, this worked in gtk3
        because there was some fallback code which guessed what function name
        was needed to call to get it, but that's not present in gtk4
        
        Change-Id: I85a957ecd37e0e7a572578e8273152fbb19dac3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132920
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Kevin Suo  <suokunlong@126.com>  [22c7ce6c8e7d5b7f8b37ad6c519c2b8ca4853724]

        UI Workaround for tdf#146653: change localized Source Han {Sans,Serif} CN...
        
        ...to Source Han Sans CN Normal and Source Han Serif CN Medium for Simplified Chinese UI, so that
        the font shown is not bold.
        
        Tranditional Chinese and Japanese settings are not touched. It is up to the
        zh-TW and JA l10n team to decide whether to apply the same change.
        
        This does not resolve the bug itself, but makes the UI usable when the
        system has Source Han Sans CN or Source Han Serif CN fonts installed,
        so that the default font used is normal weight rather than bold.
        
        Change-Id: I52753448d886854d92ba8a26d8b03bf42522735f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128798
        Tested-by: Jenkins
        Reviewed-by: Franklin Weng <franklin@goodhorse.idv.tw>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-04-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [89dfd5058ac8f524021f03bd29d7aedca182bc72]

        odk: update DevGuide wiki links and correct history in footer
        
        Change-Id: I95c78d1346d354b755aeecaa1e6c9d789be0b693
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132905
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [c358ed52ade8308bf504c61fda58a4733ba7b1df]

        compress row height calculation (tdf#148492)
        
        Change-Id: I42346472485f00bd64d08d2e2d0aef0ec02423f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132897
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [9efb19a6ad39bdd0d744adec3390ab274c90be2e]

        bail out of the loop when the item is found
        
        Change-Id: If0816f38eeeb3330738ab40bc8a72f1e14575c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132904
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Stephan Bergmann  <sbergman@redhat.com>  [48e277ad1d3fc0a8f7cb3e3cf356e15f6102a17f]

        Fix unoidl-read invocation
        
        ...that had inadvertently been missing from
        bb64cd2884beb03a2d578ada10abdb3e0df22778 "Add unoidl-read to the SDK"
        
        Change-Id: I4003e1dede9c8d6caf036534f4c3d0e59a24da14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132903
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-12  Gabor Kelemen  <kelemeng@ubuntu.com>  [2b44f9490853c9de5a0e92c41fdc1279b6c91e06]

        Recheck modules [uU]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132768
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [67a5469f1cc40253453f1248622d2e52c92964ab]

        ofz#46639 Timeout
        
        Change-Id: I04f61749104bd21fa53edefd57a737d85c1d4faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [f0801aba21f20c6305ae2b9083443d74bad01d3e]

        ofz#46638 Integer-overflow
        
        Change-Id: Iaf3a6d1b5db1428a4cdfa440ac3484d115a491cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [71a11d27e2ef8ccf3e7a0f570d53ddb6a86d5a27]

        drop unused width variable
        
        Change-Id: I836234f86c01300d1a55e901699fee840efb37dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132895
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [0c7f683766c58062e3ea1e613ffd4d237ffcb856]

        ofz#46352 assert on bad string offset
        
        Change-Id: I60123fd0460b8038f08582a0bcbf2307af321df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [58e156bc54177d0ed60f50181640f62189f72ac4]

        tdf#148423: subsequent_filters_test2: Add unittest
        
        Change-Id: If630a0e0fe6370212c9d54a58b1b84dbe8b2dc64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132892
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-12  Jan-Marek Glogowski  <glogow@fbihome.de>  [af6dd54d53eee0d0de1164bff0a77c6b433b3935]

        tdf#148115 Qt handle tooltips via event loop
        
        Instead of calling QToolTip::showText directly from LO, this
        defers showing the tooltip to the QEvent processing, which takes
        the tooltip timeouts into account. So tooltips are shown with
        a slight delay, therefore they happen less fast on mouse move,
        reducing / avoiding artifacts of fast changing windows.
        
        This unfortunately comes with yet an other hack in the area of
        our fake popup windows...
        
        New handling is based on the code of the Qt Tool Tips example.
        
        Change-Id: I42634ad36dd12171c30f52f07a02a88d3c48a718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132841
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [ea68de2968c0dbcd8e7549435e829db06795c16d]

        use gb_DEBUGINFO_FLAGS consistently in gbuild ExternalProject's
        
        A number of them didn't use it at all, others had it hand-written
        in various ways.
        
        Change-Id: Iaf86325f9cdc032926bac917dc3eef4e34661544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132818
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [967717e65fffce20ff6069c2177720c067e174d1]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I87cfad2da9b90bc4487dc4deb2fda5bb31a6b763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [3361db2179dfe4ddb017ac59660c26c2acaaac8d]

        include OutputDevice MapMode in SalLayoutGlyphsCache key (tdf#148400)
        
        The mapmode also affects the layout of the glyphs.
        
        Change-Id: I9492bc4d3d9e991ef8ab5dc30ce424e44cbc79f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132822
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [cbaf1fbaa6e707d939f815eda360fad68a492aca]

        loplugin:stringview more o3tl conversion
        
        look for call sequences that can use string_view and the new o3tl
        functions in o3tl/string_view.hxx
        
        Also add a few more wrappers to said #include file
        
        Change-Id: I05d8752cc67a7b55b0b57e8eed803bd06bfcd9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-12  Jan-Marek Glogowski  <glogow@fbihome.de>  [f751417b77e6573a0c639778e76ec943449f4573]

        tdf#148491 Qt reconnect the QMenuBar close button
        
        When the QMenuBar of a QMainWindow is replaced, an existing
        corner widget is preserved / transferred, but its connections
        are still severed; a bit unexpected...
        
        The documentation for QMenuBar::setCornerWidget is not really
        clear what is happening, but the code has this nice comment:
        "// Reparent corner widgets before we delete the old menu".
        At least there is no need to explicitly delete the button.
        
        Still we must reconnect an existing button on each SetFrame.
        
        Regression from commit 9c4ef8ce3183e27ca174475cf4a8d15cc0368f60
        ("tdf#145954 Qt unshare QMenubar usage").
        
        Change-Id: I13c31734e665b78231a08cd76ca6305122e08879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132836
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-12  Caolán McNamara  <caolanm@redhat.com>  [88fca5281d60e487e21183953913d8b8365a9b4e]

        use cairo_font_face_t* instead of void* + casting
        
        Change-Id: If3f5883790e4eee4dd4c519074b02d9cc2eda86c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-12  Stephan Bergmann  <sbergman@redhat.com>  [6400c23d6a37617f92dbe4f514c0691e4e50fa05]

        Pick better type for a variable
        
        Change-Id: I30916b188c7f8de06aec0719e79aa134a3250aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132890
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-12  Justin Luth  <justin_luth@sil.org>  [5453721050f1cad2951410cc8d5ebca19ea38294]

        tdf#148380 docx export: support CREATEDATE without format
        
        When CREATEDATE is given as a field command without the optional
        format string, then export was treating it as bWriteExpand
        (aka ww::eUNKNOWN) and just dumped out the field name.
        
        Instead, accept an empty string as a valid number format
        in order to maintain it as a field.
        
        In order to do this, we have to also turn off write-expand
        for fixed fields, since import always treats CREATEDATE as FIXED.
        
        The other existing example is
        writerfilter/qa/cppunittests/dmapper/data/create-date-preserve.docx
        
        DOC: not yet importing as FIXED
        RTF: seems to just ignore bWriteExpand and does the right thing anyway.
        
        Change-Id: If0aef38f6730f55b5fa1be6a62e0b6a0b4871658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132662
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-12  Shady Mohamed  <shadimabdrawy1999@gmail.com>  [4d27d087de2922f918a76437a1385dc4a287afc3]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I6262d64edcff4e73f2b148e98a62ee8d4b0d3294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132839
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-12  Stephan Bergmann  <sbergman@redhat.com>  [812081337ae6458cd14cd17e56510b7ed48acbc6]

        Delete tempfile when done
        
        Change-Id: Ide7acab1ab8eae760f9818248ce44d07ca92a6f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132884
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-12  Luboš Luňák  <l.lunak@collabora.com>  [e97fc93876e3efecb9e345fe61e9e5bccab125f4]

        libwebp is a C library, set CFLAGS and not CXXFLAGS
        
        Change-Id: I79da4dcc61f50634dc8812dc5bf382053c170a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132817
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-12  Miklos Vajna  <vmiklos@collabora.com>  [846e57fd31e7fa37021a12b3088ca565a459ff4a]

        CppunitTest_sw_ooxmlexport8: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I92e2c25121a543747471e4066b55ddaf87a7a88b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132874
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-12  Miklos Vajna  <vmiklos@collabora.com>  [b40f9c536c1cefae8404a3f1c0080473151913d2]

        sw content controls: add initial DOCX export
        
        Wrap the text portions inside the content control inside <w:sdtContent>
        and <w:sdt>. Also map the (so far) single property of it to
        <w:showingPlcHdr>.
        
        This is just initial export for inline text content controls, more
        properties are to be added in follow-up commits.
        
        Change-Id: I21e085496b4c79114b158656c5611aff8ffdd08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132875
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [618d40799d25474c48d984ce1d52b0f08f220958]

        tdf#147876 Fix crash when cancelling Dialog import dlg
        
        Regression from 9a55b97e980bbf2a0ce12841f6168f1f7545ac96
        
        Change-Id: I3fc35981a0cb81e5b59236ec3b07450aec10541a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132737
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-04-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6790220e010f31ac97221f836b46e461c339a572]

        vcl: use auto delegate for X11SalGraphics and remove duplicates
        
        X11SalGraphics can derive from SalGraphicsAutoDelegateToImpl to
        remove many calls to the mxImpl, which can instead be done by the
        auto delegator.
        
        Change-Id: I7add2e824eb1be01f8d278e5af8a378a34b32671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132826
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-12  Miklos Vajna  <vmiklos@collabora.com>  [732d430f7a16f8976e7fcdbbdc5f4bf3a822315e]

        sw: document SwXMeta::Impl
        
        It already had some comments, but turn it into markup that is picked up
        by doxygen + mention the locking aspect.
        
        Change-Id: I6d9dba02f5be2e6f262733dfc124f09e29ba47eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132838
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-12  Dennis Francis  <dennis.francis@collabora.com>  [92caeb1a365d10d9cafaca0aed1368db92bc90f0]

        unit test: use temp copy in testInvalidEntrySave()
        
        Use a temporary copy of the source file to run this test otherwise it
        will execute a .uno:Save on the original document in the git tree!
        
        Change-Id: I673aad64453e72a9140efcad2b0ff9c0ceabc038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132854
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e38374b15be9ea4ced36a9b5954de1dc18ba2943]

        tdf#56363 - UI test fails if the selected font is not present Change-Id: Ic8ff99464b435169460d678590896decc91f5152 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132712 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-04-11  Szymon Kłos  <szymon.klos@collabora.com>  [657de2818468253aae65f49e5f37f5dcd3fc0938]

        lok: run autofilter without timers
        
        so we are sure we will get correct position
        
        Change-Id: Idd218e19b8b3f3d6da67e325472e11b5661bc3b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130725
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131123
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131512
        Tested-by: Jenkins

2022-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [9fcd2dc178ebc68617d7c8212bbc62db72bae469]

        tdf#148395: sw: Add UItest
        
        Change-Id: Id0e49ba6f0834dc85a26f4d9064dfe029a50fa35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132837
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-11  Szymon Kłos  <szymon.klos@collabora.com>  [b5e2a004dc355c4e6a8abeac9d1d414f25d8db2c]

        lok: fix formulabar rendering
        
        While forwardporting it was not taken into account that
        no pixel/logic conversion is needed.
        
        regression in:
        commit cf5b0d5972b02809e9b7f35780885445242b3f12
        Author: Szymon Kłos <szymon.klos@collabora.com>
        Date:   Mon Jan 17 13:11:19 2022 +0100
        
            RTL: lok: render correctly interim windows
        
        Change-Id: Ic6716bf9335d4a9297e3e5edfeb161702b846efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132424
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132809
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-11  Szymon Kłos  <szymon.klos@collabora.com>  [94d59b6227bf6818b191ee37d28b6fa64b67c9cf]

        lok: use JsonWriter for annotations notification
        
        This will unify received objects in LOK.
        boost::property_tree used "string" for number values
        we expect them to be a "number" type.
        
        Change-Id: Ie90d7e2dd98bb371fc09878dcc6e96f4cdf73f3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132054
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132808
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-04-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [9ae398054833120df36bf51738cc4cfd7efb3fdc]

        tdf#148481 Map RefHand cursor to Qt::PointingHand
        
        Change-Id: I79c7008655f22737f92a4a6430f1380e81c1c386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132833
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [2f998468b09de615eb89d2f0d607c635644f7750]

        android: Drop leftover German translation
        
        The English string had already been dropped in
        
            commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Apr 6 14:26:06 2021 +0200
        
                android: Drop custom file abstraction + UI
        
        While the leftover German translation is just ignored
        in development builds, it resulted in an error
        when building a release APK like this:
        
        > ./gradlew assembleStrippedUIEditingRelease
        > warn: removing resource org.libreoffice:string/filter without required default value.
        >
        >
        > > Task :compileStrippedUIEditingReleaseJavaWithJavac
        > warning: [options] source value 6 is obsolete and will be removed in a future release
        > warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
        > Note: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/src/java/org/libreoffice/SettingsActivity.java uses or overrides a deprecated API.
        > Note: Recompile with -Xlint:deprecation for details.
        > Note: /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java uses unchecked or unsafe operations.
        > Note: Recompile with -Xlint:unchecked for details.
        > 2 warnings
        >
        > > Task :lintVitalStrippedUIEditingRelease
        > /home/michi/development/git/libreoffice-WORKTREE-for-android-x86/android/source/res/values-de/strings.xml:28: Error: "filter" is translated here but not found in default locale [ExtraTranslation]
        >     <string name="filter">Filtern nach</string>
        >             ~~~~~~~~~~~~~
        >
        >    Explanation for issues of type "ExtraTranslation":
        >    If a string appears in a specific language translation file, but there is
        >    no corresponding string in the default locale, then this string is probably
        >    unused. (It's technically possible that your application is only intended
        >    to run in a specific locale, but it's still a good idea to provide a
        >    fallback.)
        >
        >    Note that these strings can lead to crashes if the string is looked up on
        >    any locale not providing a translation, so it's important to clean them
        >    up.
        >
        > 1 errors, 0 warnings
        >
        > > Task :lintVitalStrippedUIEditingRelease FAILED
        >
        > FAILURE: Build failed with an exception.
        
        Change-Id: I9a6c984d3250852d0e806cffdff81770ed868299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132834
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-11  Stephan Bergmann  <sbergman@redhat.com>  [de465317350f94c8b3308c73572467b588af5af0]

        -Werror,-Wstrict-prototypes (clang-cl)
        
        Change-Id: I72e35f51eb607662608ccaf944bec64ed422cef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132835
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6fc3dfd3f1b5cb13101299df42444f2ff0493846]

        use more string_view
        
        found by tweaking the loplugin:stringview and making it whitelist
        getLength
        
        Change-Id: Ic41cd4e3026d93b70a76fe1279c6de3abbe6b4a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8cbb08de38fc1a2f9d2ea0dfbdc2be8e8110ff73]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8219f0b1d741dc3e3927a1fb9ee4fc0b916d57e1
          - tdf#102265 Add Format - List submenu for Impress
            
            + usual refactoring and icon size adjustments
            
            Change-Id: I614438a36fa1ca34ddfaac81aadb0f54bd51940e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132736
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c4a7c3ebcc60b3f13aae3589084ff48ce341e51]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2dac57ec902e35a673966e66956a19096ed09f45
          - Fix alternate text in images for Manual Break page
            
            Add index for proper search
            
            Change-Id: I22591b61d6a42f0ac6cfae06e4d77a29050bcf55
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132821
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-11  Miklos Vajna  <vmiklos@collabora.com>  [ab8d141967111ca81f4607db3618bb09214e42db]

        sw: add sub Title impl for SwInputField
        
        It is advertised as a property, but it's not implemented: just avoid the
        assert fail on inspecting the UNO wrapper.
        
        Change-Id: Id482443aeeee71198dbddbcb3810ae0c4b7b30bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132819
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [538166da779e13197411cade8bd7dedb94778525]

        sc: fix rendering when sparkline doesn't have a data range
        
        Change-Id: I945594d93c893043cea1758b3ad9c4e7692ef27e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132815
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [5e28945bd4cbd31856ccd6ce894693ceafea4144]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4d46412589f57e6ee772560a2d71b3263dfffbce
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I962121d5d277887d6ecd827c183c177ea578bcd7
            
2022-04-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [bc227a15db04e218f34c6e2055c05b3cee67e4cf]

        tdf#148052: sw_ooxmlexport17: add unittest
        
        Change-Id: I4153e4598114e54481fc25d174c3ccb9394de6b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132811
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-11  Stephan Bergmann  <sbergman@redhat.com>  [bb64cd2884beb03a2d578ada10abdb3e0df22778]

        Add unoidl-read to the SDK
        
        ...as a replacement for the legacy regview
        
        Change-Id: I1e1eecb45f27422727f28feb19c2479af867bd79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132816
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [85c2ed8dc790689ce69ff0a08ff5a4de98df54b7]

        loplugin:stringview add check for getToken().toInt32
        
        where we can convert that to
            o3tl::toInt32(o3tl::getToken(
        and avoid the heap allocation of a temporary string
        
        Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-11  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [117688bd3f51a7a50b2620aa7dcc0c065f29d402]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 62983d1d5abdc3409b84bccc29a9cca6ae659a8e
          - Improve text further
            
            Attempting to make it a little less difficult to read.
            
            Change-Id: I3e852d95b32b3a56900d221a6e3a971a7d715f28
            
2022-04-11  Stephan Bergmann  <sbergman@redhat.com>  [77db890a80d62da5524c76addb33e71b3ed9fb6c]

        unoidl-check does not need to be part of installation sets
        
        ...it is a build-time tool used from solenv/gbuild/UnoApiTarget.mk, and should
        be of no value for users of LO (or of the SDK).  It was presumably a historic
        mistake that its predecessor regcompare was included in installation sets in the
        first place.  (The only mention of it in the Developers' Guide, which only
        acknowledged its existence without giving any details how to use it, has been
        removed in
        <https://wiki.documentfoundation.org/index.php?title=Documentation/DevGuide/Writing_UNO_Components&oldid=492551>
        "Drop mention of build-time tool unoidl-check that should not be part of any
        installation sets".)
        
        Change-Id: I626e22fa18ad900af150afe29a36aa1ceaf5e259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132814
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-11  Michael Weghorn  <m.weghorn@posteo.de>  [9c5facd726e3d5148d17ad547213afe0874ea910]

        android: Pass variable for "selected" param
        
        ... of the CalcHeaderCell ctor, to simplify this a bit.
        
        Change-Id: I02ff00acccaec26de54534c6c021b9cd05f1d472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132813
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-11  Stephan Bergmann  <sbergman@redhat.com>  [bdfab729df65d782bdc1aad53b8b1a413062847d]

        Drop duplicate regmerge/regview items
        
        ...that had been added with 26db47abd059a1482bd03df937314f4645c38ece
        "CWS-TOOLING: integrate CWS jsc312", probably due to a mis-merge.  (The first
        occurrences had been updated over time, and the second ones not, but lets keep
        the second ones, properly updated, as that matches the order in which the tools'
        full descriptions appear further down below.)
        
        Change-Id: I725105e926a5761c210c5901e00179ea9a1b6b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132812
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-11  Miklos Vajna  <vmiklos@collabora.com>  [d1649e5d38b51cd422302e566719a2c5aff42b2f]

        sw content controls: add ODT import
        
        Map
        
        	<loext:content-control loext:showing-place-holder="...">
        
        to com.sun.star.text.ContentControl and set its ShowingPlaceHolder
        property based on the XML attribute.
        
        This requires moving XMLImpSpanContext_Impl to txtparai.hxx, otherwise
        XMLContentControlContext would have to be in txtparai.cxx, which is
        already large.
        
        Change-Id: I9a915868160ebcc0e98ded61bfab72f32864bd76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132804
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-11  Justin Luth  <justin_luth@sil.org>  [431a0399bb050e65dedb2e9280e744699a724227]

        tdf#148380 writerfilter: Import AUTHOR as FIXEDFLD
        
        This patch depends on patches for tdf#147861
        and will require a follow-up export patch that handles exporting
        this FIXEDFLD (instead of just dumping the name of the field).
        
        This was being imported as plain text because of exception
        writerfilter/source/dmapper/DomainMapper_Impl.cxx:6950:
        Exception in CloseFieldCommand() com.sun.star.beans.UnknownPropertyException
        message: "Unknown property: FullName at
        /persistent/git/libreoffice2/sw/source/core/unocore/unofield.cxx:2156"
        
        Additionally, similar to tdf#134592, the create author will always
        be constant, so mark that as fixed. (This helps because in MS Word,
        the user can modify the field contents to be anything he wants,
        and it is only updated when F9 is pressed on the selected field.
        Thus, we might NOT want to show the real DocInfo.CreateAuthor
        as the unit test demonstrates.)
        
        Change-Id: Ie014c273d491fa5bbd9b9ecedc69702d0ae8d60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132661
        Tested-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c7fb93764b321e5bf4cd143dd0c29be60de6d8f8]

        Cleanup comment
        
        ... after commit e4ff847fe0796420ba8023b70cad8589f5f19e9f already
        made it a template.
        
        Change-Id: Ia433150cb1f9909906ceb986c50d4334cc2b1897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132806
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-11  Stephan Bergmann  <sbergman@redhat.com>  [1e859921ffc3b8974416e1b67face18d0e0de7fb]

        Remove unmotivated horizontal separator
        
        ...that had been added with 00bb4bff5cc42f702cb587b47bbdb92b226791ce
        "INTEGRATION: CWS sdksample", for unclear reasons
        
        Change-Id: I2931ecb6f1876d7e99b4706b1fd39f9b8761c68e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132807
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b9caa1c0732868903dac7ba70c4092d0213235b6]

        Replace references to rtl_ImplIsWhitespace with implIsWhitespace
        
        ... after commit 57f22d9b1a4e1cd161a35c8e4c390661db981d2c.
        
        Change-Id: I4232adc805593575d0bb7549b40ad35308829261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132805
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-11  Miklos Vajna  <vmiklos@collabora.com>  [bdc4819a37e16e12ea74531b3413f8bd8693479e]

        sw: prefix members of WW8PLCFx_Cp_FKP, WW8PLCFx_FLD, WW8PLCFx_Fc_FKP and ...
        
        ... WW8PLCFx_PCD
        
        See tdf#94879 for motivation.
        
        Change-Id: Iab9541c5d3e16395e8be43db7a95464ea260b3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132802
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-11  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [027db2df5371183136f87e84ec4829d59eef209b]

        Advanced Diagram support: Make Style/Theme info available
        
        The Style/Theme information is central for re-creating the
        Diagram shape representation. Make that data available in
        the ModelData classes in svx. With that information, a re-
        creation with all needed attributes is possible, e.g. when
        the model gets changed (remove/add data entries).
        Also some cleanups done.
        
        Change-Id: Icd925c9731891092f1ddd96c8feb165e1f846f4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132738
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-04-11  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [a5c27f59c4e28d9ec1c1ce8f8c0c5ef6fc68772c]

        odk: update DevGuide wiki links after import into TDF wiki
        
        Change-Id: I5a698250db7e822f8d95ff43d87705df05f91c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132784
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [6f39602ecb9b90795bfd4101273f90b16f17b6d6]

        Move unoidl-write from cross-tooling to default
        
        Fixes the ODK cross-build used for Windows Arm64.
        
        Regression from commit 40f2aee6584eafcf4cd1d95fcf1f775e5435440d
        ("Provide unoidl-write also for the SDK").
        
        Change-Id: I54d2732358ed1d48911e206ed02bfca2d3a78782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132718
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-10  Caolán McNamara  <caolanm@redhat.com>  [8182d26ddc66b1d89b60653fffec2780d4ec1b71]

        ofz#46587 Integer-overflow
        
        Change-Id: Icdc3d899a403f5c6dfa7247a3b71a97721e83f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132789
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-10  Behrad Khorram  <b.khorramnazari@gmail.com>  [a30b3ef7ff4c69272c7c20dc9ea947c15b16216e]

        tdf#143148 Use pragma once instead of include guards in xlimits.hxx file
        
        Change-Id: Ia54dad6650e4dfd618ebf48a89c2ccd9c588fcb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132481
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-04-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b24a4d255d31233c48152e6e1ce992a693cdaeae]

        use more string_view
        
        found by tweaking the loplugin:stringview and making it whitelist
        getLength
        
        Change-Id: Ic15d3703d1fb07658e99e1db1c89e2fa5bc70c19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132771
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-10  Mike Kaganski  <mike.kaganski@collabora.com>  [57f22d9b1a4e1cd161a35c8e4c390661db981d2c]

        Move impl functions to the only place they are used
        
        Change-Id: I6871bfc0ae3d2427a4cd135cb37aad76dac0d7a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132706
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [35bf17d758e67c939b8abcc5355e674030e135ac]

        Removed duplicated include
        
        Change-Id: Ica4231235b0a2d32ba8558cc409b549acd887077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132758
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-10  Jean-Pierre Ledure  <jp@ledure.be>  [43507de5764732300ae9a35cc570b7722a7e1a80]

        ScriptForge - (SF_Calc) new CompactUp() and CompactLeft() methods
        
        The CompactUp(CompactLeft) method:
        
        Delete the rows(columns) of a specified range matching a filter
        expressed as a formula applied on each row(column).
        The deleted cells can span whole rows(columns)
        or be limited to the width(height) of the range.
        The execution of the method has no effect on the
        current selection.
        
        Args:
          Range: the range in which cells have to be erased, as a string
          WholeRow(WholeColumn): when True (default = False),
            erase whole rows(columns)
          FilterFormula: the formula to be applied on each row(column).
            The row(column) is erased when the formula results in True.
            The formula shall probably involve one or more cells of
            the first row(column) of the range..
            By default, a row is erased when all the cells
            of the row(column) are empty,
            i.e. suppose the range is "A1:J200" (width = 10),
            the default value [for CompactUp] becomes "=(COUNTBLANK(A1:J1)=10)"
        
        Returns:
          A string representing the location of the initial range
          after compaction, or the zero-length string if the whole range
          has been deleted.
        
        Examples for CompactUp():
          newrange = oDoc.CompactUp("SheetX.G1:L10")
              ' All empty rows of the range are suppressed
          newrange = oDoc.CompactUp("SheetX.G1:L10", WholeRow := True, _
              FilterFormula := "=(G1=""X"")")
              ' The rows having a "X" in column G are completely suppressed
        
        Both methods are available for use from Basic and Python scripts.
        
        Change-Id: Ib1269b22bcd189ca86a1bd3bda2c67e895598cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132783
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-10  Caolán McNamara  <caolanm@redhat.com>  [64046625553ecbfd9fe0661e5b6f48e283a909e0]

        cid#1503836 silence Dereference null return value
        
        Change-Id: I11dae0872d1f4add67b59ffd9696134c1dd2dbea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a08f9ed2341bc60faae6b86538661fea40417ace]

        sc: add UI, undo/redo and test to change sparkline data range
        
        This adds a "edit sparkline" action to the context menu and a
        dialog to change the data range of a sparkline. To change a
        sparkline using undo/redo, a new class UndoEditSparkline  was
        added, which allows to change the attributes of a sparkline and
        revert back the old attributes when undoing. This is then used in
        the Dialog when setting the changed data range of a sparkline.
        
        To make sure that undo/redo works correctly, a simple unit tests
        was added.
        
        Change-Id: I08af1813fa288278bc0d33b0540660b325b17235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132748
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [655b6c2f46a73d9893ba8e6b572731a5890a4f72]

        loplugin:stringviewparam
        
        Change-Id: I62a7534844006a7bf3c2ece5e5d2f8b739a15b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132762
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4ff847fe0796420ba8023b70cad8589f5f19e9f]

        loplugin:stringview check for getToken and trim
        
        since we now have o3tl versions of those that work on
        string_view.
        
        Also improve those o3tl functions to support both string_view
        and u16string_view
        
        Change-Id: Iacab2996becec62aa78a5597c52d983bb784749a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132755
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [5a89496ffcfcd561b3e595e01f35e0302fa00841]

        loplugin:stringview
        
        Change-Id: I5e52f27408889d3b6939666520ffc8e767a1fc0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132763
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Arnaud Versini  <arnaud.versini@libreoffice.org>  [583b2e6bdb5550ff435ce739dac4318bc4a650e0]

        osl signalshared : use std::mutex instead of oslMutex.
        
        It also avoids possible double signal init and deinit.
        
        Change-Id: I4a24a011ee82d885e7a42abedea6a9fd96d3cab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-10  Julien Nabet  <serval2412@yahoo.fr>  [c1285d4d033a13667a942145db77e3aa38d3f953]

        cid#1503834: copy-paste
        
        Change-Id: Ibc5cf10d4daf809e89693ac9d3fb82188ba1b311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132767
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [fe858f28a0d5db819f80a6086bfe41f181df40df]

        loplugin:empty
        
        Change-Id: Ib52d0d4db0f50ba7551eadcb3db2920008596b59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132761
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [cb66be9e91c2ab178238b644b998d05145f5fddc]

        Silence cid#1503835 ("UNINTENDED_INTEGER_DIVISION")
        
        Change-Id: Idfc8ea082a9547622e03830f8dcdbf4d774f7f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132766
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [7e3d93fd5776244e9028ff4fb3b551222b49cd87]

        Various loplugin warnings (in new Windows-only code)
        
        Change-Id: I78863816c9ad520e0fc4919aeaa2e25ff768d451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132765
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [69a05652a5b30b4d4234c19cc0a1e355712759d5]

        -Werror,-Wignored-attributes
        
        clang-cl: "'dllexport' attribute only applies to functions, variables, classes,
        and Objective-C interfaces"
        
        Change-Id: I1c10431f442b601fd8110c029f6fe33915c62d08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132764
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-10  Stephan Bergmann  <sbergman@redhat.com>  [72303710ab70007769118a1f13106822f3558916]

        -Werror,-Wstrict-prototypes
        
        Change-Id: I7b3d6f5a19020191e7add5ed21666d84e54744a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132760
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-09  Caolán McNamara  <caolanm@redhat.com>  [d34d1db55978bdcff082af1e0f75b18fa6fc94f4]

        ofz#46526 Abrt
        
        Change-Id: Iaec536b0989c4ec11b39b1534c7798e46715d7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-09  Luboš Luňák  <l.lunak@collabora.com>  [33fe4909e29654faeef7f665f31ff31776ecfeec]

        add vcl::Font::EqualIgnoreColor()
        
        The color values in vcl::Font are obsolete, and the underlying font is
        the same regardless of the color.
        
        Change-Id: I66801a07092bc189f43bf2b28bc54ead6d20f70e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132747
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-09  Luboš Luňák  <l.lunak@collabora.com>  [136d9b34459edb444fb5154fa8b5c74d877099d5]

        no public data members in GlyphItem
        
        Change-Id: Ib5911a8ad33aefffa972f583c2b5fc7d42a2b9bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132746
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-09  Luboš Luňák  <l.lunak@collabora.com>  [0c852a14d61d2c06322b8a0e51960604fd212e2b]

        sal_GlyphId is internal to VCL
        
        And can't be put into impglyphitem.hxx, as then it would have
        a circular dependency with fontinstance.hxx .
        
        Change-Id: I57289fa5433851f095f7b73ce842ba5a0e8497ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132745
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7a2bd19355d78551f9ce253fca69d37881d1d1c1]

        tdf#56363 - Search font family without the font feature after the colon
        
        In the special character dialog, search font family without the font
        feature after the colon in order to find the correct item in the font
        combobox.
        
        Change-Id: I60d068bb22782bcce062365a8d4d53e15ec34c76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131953
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [035c9fc7ecaf0fce032748f47450fb31cc62d65a]

        use more subView when converting to Int32
        
        Change-Id: Ia1be48050cca386a6e765aa2229de1bc9e64ffff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-09  Stephan Bergmann  <sbergman@redhat.com>  [29578ae1394de2fffae2e34326d03d81b4c4f475]

        Introduce `unoidl-read --summary` mode
        
        ...as needed by odk/docs/idl/wikilinks.py
        
        Change-Id: I6dd096338e9f200679810d33e89c8b9ce18f69f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132752
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [2bf56582475179faa9d71573532a0d416cb64bfc]

        add a more complete o3tl::getToken
        
        so we avoid OUString copying (mostly when doing stuff like parsing
        numbers of out of strings)
        
        Change-Id: I4ef6ac23671c0b40807a22158e655e92dfad4af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-09  Eike Rathke  <erack@redhat.com>  [7a16002ede5fd31ae8f3358136ad49de40465ac1]

        Resolves: tdf#148052 accept a ". Month " name for matching DMY format
        
        ... even if the locale doesn't define such DM order or
        LongDateDaySeparator.
        
        Change-Id: I4bef720dff3582de9b60313824a84b570c153e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132741
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-04-09  Jim Raykowski  <raykowj@gmail.com>  [ccb78b98e0618cce365562fe326d018892b8104a]

        SwNavigator: set entry focus and update toolbox items sensitivity
        
        when content tree entry selection is made by the SelectContentType
        function
        
        The SelectContentType function is used when the Navigate By control
        combo box selection is changed by direct selection. This patch makes
        the tree entry cursor position be set to the selected content type
        entry so keyboard tab navigation will land on it. It also makes
        the move chapter up/down and promote/demote outline level toolbox items
        sensitivity update when the selection is made.
        
        Change-Id: I56675592678accc6db3eacb25bf9bccae8eb1cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132689
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-09  Eike Rathke  <erack@redhat.com>  [1c49b677313b94efe17bf8bf8f2952416c2453cc]

        Use DateTime(css::util::DateTime&) ctor
        
        Individual fragments set in the given order even raised SAL_WARN
        about non-existing year 0 ...
        
        Change-Id: Iadfc648423b9fc7ec1a9ebfbc05a1ea814078ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132742
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-04-09  Luboš Luňák  <l.lunak@collabora.com>  [7cc4b06fc44c06866cdabb4a8856c7cee3fcfe2d]

        use helper GetTextArray() in all places
        
        Change-Id: Icec4326cf614574d7dabe6752f985b3ac4462fb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132744
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-09  Luboš Luňák  <l.lunak@collabora.com>  [bc0acc7bd02057f3c04af39530ee0fe235353576]

        cache failures in SalLayoutGlyphsCache too
        
        Change-Id: I0ddbb8ac94705d7a1a843fe39d0821644dfb5084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132743
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [de45c09a3b48e8ab3ac995ea72681ec265c24123]

        add SalLayoutGlyphs* parameter to OutputDevice::GetTextBreak()
        
        Change-Id: I278e485e03cf27bc57724233453a672569dfd53f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132682
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [3e5863605881c6de6ad130fe06883c176ca1c69f]

        use just one shared global SalLayoutGlyphsCache
        
        Now the cache should be capable of detecting what needs
        to stay the same for having the same result, so it should
        be enough to have just one cache that can reuse results
        even between callers from different places.
        
        Change-Id: Ibdc0303f5b727d1a1d7be91d61db9465ed95e1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132673
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [53fe4a26c7c4691fcf9d07d022adfd45247d176b]

        ignore Point logicalPos argument in SalLayoutGlyphsCache
        
        It's only used for the DXArray argument in ImplLayout(), so if we
        ignore that one when caching, the position can be ignored too.
        
        Change-Id: Id2a7b452e2b75139177c1e73c48eaa466742a59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132672
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [9ed2912d4ecfd9573b3ca9d2390a0f1b0e3060a2]

        check better for unchanged OutputDevice in SalLayoutGlyphsCache
        
        Some things like font could change, so it needs to be saved and compared.
        If would be even better to avoid comparing OutputDevice pointers
        and instead compare only what actually matters, in order to reuse
        the same glyphs used for different output devices, but I can't
        find all the relevant data in OutputDevice.
        
        Change-Id: Ib8634165b5b312d1db2c9fc28f8d7fdf7b552d25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132671
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [376a9792c32a51c91079a54a0cf190acd58485af]

        use SalLayoutGlyphsCache in PDFWriterImpl
        
        It's unlikely to repeatedly lay out the same strings often, so
        it probably won't gain much, but still. If SalLayoutGlyphsCache
        would work even on different OutputDevice pointers (that would
        provide the same glyphs) then presumably this would be able
        to reuse caching even from e.g. Writer.
        
        Change-Id: Ib52d9ee92e950e69229497122df1789f5fc6b07e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132670
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [94c2fb28d76c9c37849412a66b31d6861bce3155]

        faster hashing of very long strings in SalLayoutGlyphsCache
        
        tdf#147284 being a (pathological) testcase.
        
        Change-Id: I08d8dffb40193b461555bed818c040761e8d575b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132669
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [1b593dbc62dc2ceebc3f8be30d7221c916098f6d]

        use vcl::text::TextLayoutCache in SalLayoutGlyphsCache
        
        Change-Id: I0ec22fe53e05319dec15456a916b10e97ea91a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132668
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea3f08b91d70587400011e7a34fd9df259542e85]

        tdf#83037: sw_uiwriter6: Add unittest
        
        Change-Id: I42a2b697e1b3efd719c0f45474420c9367300776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132680
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ed743de88da7ef70eb63fed925a7cf29980c01a]

        sw_uiwriter: put autocorrect tests together
        
        Change-Id: I06e720b6fccab298a866eb05403ca98152ab4c8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132679
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e7679738413054c7e6ce973380eac501bf41cf2]

        move comphelper::string::toInt32 to o3tl
        
        so we can use it in places where we cannot include comphelper
        
        Change-Id: Iba0ba3e4c0dcf0f9d1f09092a77c3b2010ec4f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3bfac2a7fad9737f31443292699bd6fee6ac3a6f]

        Fix typo
        
        Change-Id: I0e365196f90e0f117e80df2c194d8137252b959d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132735
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-08  Luboš Luňák  <l.lunak@collabora.com>  [14bfb0933073e5bf8ce4f810c38e91125066257a]

        allow to override the generator/producer string in output documents
        
        Add a (non-gui) setting GeneratorOverride that, if set, is used
        for odt/docx/pdf generator string identifying the application that
        has written it instead of the normal productname etc. string.
        
        Change-Id: Ibe12a063e7e6b5a09c69cdf66cba073793650d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132495
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [881cfbf77567194f5016a961d1c3db869734d68b]

        tdf#141578 Qt handle QtFrame screen changes
        
        LO doesn't provide any way to notify screen changes / scaling
        factors of a window and in fact doesn't really handle scaling
        factors in VCL. The QWidget doesn't receive a resize event,
        because it's size doesn't change, just the scaling factor.
        So we trigger a faked resize on QWindow::screenChanged signal.
        
        Change-Id: I6928c4c62d1c0995c70fea0088cff17849bcd1d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132650
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-04-08  Stephan Bergmann  <sbergman@redhat.com>  [126b1826c465002dccc7c354a584731fa70ec5fd]

        tdf#148423: Half a hack
        
        "Regression" introduced with de4d296619b978ec303f1d7b1e2c78e13fa7a512 "Avoid
        overflow in ScColumn::GetOptimalColWidth", which, for this bug document's
        nWidth/nPPTX = 6004/0.0647708 = 92696.1, changed the calculation of nTwips from
        the undefined-behavior 92696 % 65536 = 27161 to the clamped 65535, but which is
        apparently a value large enough to cause "silent" issues (i.e., not causing
        further undefined behavior) down the road, leading to a super-narrow column.
        
        That commit already wondered whether sal_uInt16 is a useful choice here, but
        lets keep that question unanswered and just clamp at half the previous value,
        which happens to cause presumably more pleasing results.
        
        Change-Id: I1df642b2b9d6818c8be0f8d8f4567a00c399c154
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132734
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-08  Mike Kaganski  <mike.kaganski@collabora.com>  [ad7b90fc541413f091f6ff4bc7e2ced9fee8700b]

        Fix build
        
        ... after commit 36e0e88b28e818faf25b8e32cc8c4dc444b8a0be
        
        Change-Id: I540d19f7146651035cd5fafe077c0ccdfcee11ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132733
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-08  Caolán McNamara  <caolanm@redhat.com>  [3bf4925903cadb011bedaabb3cf18fde65bcf61a]

        ofz#46162 and ofz#46287 Integer overflow
        
        Change-Id: I58bc9aadab1765e8ce4bc8e6e631cd72b853f9b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-08  Mark Hung  <marklh9@gmail.com>  [257bb11cbc5b1eb1f90014f528b9e7d6ccfeae86]

        tdf#148330 fix vertical offset for DFKai-SB (ukai.ttf).
        
        DFKai-SB (ukai.ttf) is a built-in font under tradtional Chinese
        Windows. The font is very common, especially for official documents.
        It is one of the so-called tricky fonts in FreeType[1].
        
        DFKai-SB has incorrect extent in the glyf table[2]. It results in
        incorrect glyph positions in vertical writing.
        
        FreeType recalculates the extents based on the
        glyph outline, but LibreOffice uses Harfbuzz with
        built-in ot font functions instead of ft (FreeType).
        
        This patch decides if the fix is necessary by
        checking the family name of the font and the y-offset
        value, and recaculates the glyph offset based on glyph
        height and top bearing obtained from the glyph bound rect.
        
        [1]https://freetype.org/freetype2/docs/reference/ft2-base_interface.html#ft_face_flag_tricky
        [2]https://github.com/harfbuzz/harfbuzz/issues/3521
        
        Change-Id: If632dd38c462c229837e1efb5446e2142f8f0639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132511
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-04-08  Mark Hung  <marklh9@gmail.com>  [2b2d1c08c94fdc3982971c2b19ea241f05e578c9]

        tdf#143447 ignore IME candidate window state.
        
        Some traditional Chinese IMEs ( Input Method Editors ) under
        Windows10 send WM_IME_NOTIFY with IMN_OPENCANDIDATE but not
        IMN_CLOSECANDIDATE. The behavior is different if users configure
        the IME and enable "legacy" option.
        
        That caused the cursor been hidden, misled by mbCandidateMode.
        
        The patch ignores the candidate window mode in case the length
        of the composition string is 0, assume in that case candidate
        window is useless, and resets the candidate window mode when
        composition ended to maintain the state as much as we can.
        
        Change-Id: I91a1c23ee1a031313243e032653f50f39b0f2a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132512
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-04-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [ddaab61002a5d9a6d150b53bb354112ee7f0b715]

        sw_uiwriter6: use keyevents to simulate the autocorrect
        
        This way, the tests mimic what users do while typing
        
        Change-Id: I04ade61ce5026f2d5de58c1d0e87c1dee1e5053b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132674
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [36e0e88b28e818faf25b8e32cc8c4dc444b8a0be]

        use more subView when converting to Int32
        
        Change-Id: I54e3ddf79ba793fd4328bf8bda7f949b65349651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-08  Miklos Vajna  <vmiklos@collabora.com>  [cf5bbe3fce4a250ab25998053965bdc604c6114e]

        sw content controls: add ODT export
        
        Wrap the text portions inside the content control in a
        <loext:content-control> XML element. Also map the (so far) single UNO
        property of it to <loext:content-control
        loext:showing-place-holder="...">.
        
        This is just initial export for inline text content controls, more
        properties are to be added in follow-up commits.
        
        Change-Id: I5d928255b925ed7e08fb635ba39f546e9a4879de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132717
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-08  Michael Stahl  <michael.stahl@allotropia.de>  [4688e74bcf0c58ab1bbf60e9c19331d25ebfe95b]

        configure: require GNU make 3.82
        
        Reportedly make 3.81 already fails since commit:
        b04be559ddf4a7f0a5cdc0b9abc2bcfc4aae25cc "gbuild: implement static
        partial build"
        
        <sberg> mst___, the `/usr/bin/make --version` "GNU Make 3.81" I have on macOS does not work to build LO (Some LinkTarget.mk:913 erroneous endef error is the first I encounter)
        
        There was an ESC decision years ago to drop support for make 3.81.
        
        Change-Id: I2e0ebec9eeb326df8c5a4d89ce1d53da6ed332ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132716
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-08  Stephan Bergmann  <sbergman@redhat.com>  [9ea17a6331ca9491e7012dca837d3815cd4309ac]

        Adapt to latest VS 2022 MSM versions
        
        ...as present at least with VS 2022 17.1.3
        
        Change-Id: I6d1cf247c8507ebab56c106aff6933ff739a4314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132714
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f9a094cc0c2f61fd0838a42489b717ede3e24fed]

        Removed duplicated include
        
        Change-Id: I898c24abd5366a85705b5f54258b16b22e044355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132715
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-04-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [34a97838137f6e54405722d607b7f414084f526e]

        sc: add an overlay to show sparklines in a sparkline group
        
        This adds an overlay that shows/selects all sparklines in a
        sparkline group for the cursor cell sparkline, if the cursor cell
        has an associated sparkline.
        
        Change-Id: I60a5873ebdf8606f262d217caf6011c4a003801a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132692
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-08  László Németh  <nemeth@numbertext.org>  [a21ef822f9769ded6ff834dbfa347cf0e5f913fd]

        tdf#147179 sw: select tracked row change in Manage Changes
        
        In Manage Changes dialog window, selecting items
        of list of changes results selection of the associated
        text changes in the main text, as a visual feedback.
        From commit eebe4747d2d13545004937bb0267ccfc8ab9d63f,
        text changes of deleted/inserted rows or tables are
        listed under a single "tracked row" list item, as its
        children. Selecting a "tracked row" list item in
        Manage Changes resulted incomplete text selection in
        the main text: only the first text change in the first
        cell was selected instead of all associated text changes
        of tracked row(s) or table.
        
        Note: Manage Changes supports multiple selections,
        i.e. it's possible to select multiple list items by
        Ctrl + click, and select ranges by Shift + click.
        This commit does the same with redlines of tracked
        row changes.
        
        Follow-up to commit eebe4747d2d13545004937bb0267ccfc8ab9d63f
        "tdf#144270 sw: manage tracked table (row) deletion/insertion".
        
        Change-Id: If7b12e8d3c0e437495e1fcae0e8f04e34301c516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132685
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-08  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [844be7358f1eec00094a55fa1fb4fadadb8cd1bf]

        tdf#95706: RTF import: tolerant font table parsing
        
        While font name in font table should end with semicolon
        ({\fonttbl{\f42 Arial;}}) it is not always true and
        MS Word is tolerant to it: it still able to parse this
        correctly. Seems LO also should not require strict spec
        conformance.
        
        So idea of font parsing is changed: instead of inserting
        font on semicolon, it is done on next \fN or destination
        end. All collected text to this moment is a font name.
        
        Change-Id: I6b41951217442a71fd2ebbfc58a3fc79f6f913db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132686
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a88b513fd90f4793b6de7a7412fa33369542f40]

        loplugin:stringviewparam convert methods using trim
        
        for which we add a new o3tl::trim method
        
        Change-Id: I9d37b6264eea106aa2f3502bd24b8cccf7850938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-08  Dennis Francis  <dennis.francis@collabora.com>  [388b4fc1085074da759903a9b1768bded43dd0d3]

        lok: unit test for invalid entry save
        
        Unit test related to the fix
        
        lok: avoid validation-dialog yield when saving
        e0175ee821eaff56c4b8e0a1b7afa1cabe0ab593
        
        The test ensures that the document is marked unmodified after save has
        been executed in the middle of entering partial data to a validation
        cell.
        
        Change-Id: Idffd6d647034e128d0d800fe8e29efc333c03db6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132655
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-04-08  Dennis Francis  <dennis.francis@collabora.com>  [08d3d0bcfd6a0540b19252730b2090da0b5da2d4]

        lok: avoid validation-dialog yield when saving
        
        Disable error dialog box when about to save in lok mode as this
        ultimately invokes SvpSalInstance::DoYield() when we want to save
        immediately without committing any erroneous input in possibly a cell
        with validation rules. After save is complete the user can continue
        editing.
        
        Conflicts:
        	sc/source/ui/app/inputhdl.cxx
        
        Change-Id: Iffa0766ad594db75f57158986c4e1d2646f71da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132410
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit e0175ee821eaff56c4b8e0a1b7afa1cabe0ab593)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132654
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-04-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [59059d00c29334414a26bf5452572433f5735489]

        prevent using O[U]String::subView on temporaties
        
        by making the method "const &"
        
        Change-Id: I8b369ca1dd1f8d10832c85ccf3d890edb14e2c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-08  Justin Luth  <justin_luth@sil.org>  [e61eed211766f26a3896c1d912dc7349abbe823d]

        tdf#147861 sw ms export: DI_SUB_MASK must exclude FIXED now
        
        This is a follow-up to
        7.4 commit daef39352b008fc1f903fd8c09288ff5e772fa42
        
        There is only one place in which DI_SUB_MASK is used,
        so I'm just changing it to what it could have always been,
        since it never was actually used to mask out DI_SUB_FIXED.
        Otherwise, I might have made this a MASK2 or whatever.
        
        The issue here is that AUTHOR was not being recognized
        when it was paired with FIXED, so every FIXEDFLD was
        ended up being considered as a date/time.
        
        In practice, this didn't really change anything
        because bWriteExpand already ignored any of
        these areas of the code. It is only when I turn off
        bWriteExpand as I implement fixes that I am seeing
        the wrong field type being created.
        
        And regardless, since the field is FIXED, the visible
        content remains the same anyway (until someone in MS Word
        refreshes the field with F9).
        
        Both Author and date have the same field name ":Created"
        so I couldn't super easily test this.
        
        Change-Id: Icd2d0be2d3fbe24dc4763e0e25801569bcca471b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132660
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-08  Miklos Vajna  <vmiklos@collabora.com>  [feeed3e762cf077fbd9cf48f82e949365108ccc1]

        CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing
        
        The contents of SwTextFrames are currently dumped two times in the sw
        xml layout dump: the first is misusing a11y's SwPortionHandler interface
        for testing purposes (older approach), the second is visiting the
        portions inside the text frame directly (newer approach).
        
        The advantage of the second is that it can show information inside
        multi-portions, and also extending it won't affect a11y. This commit
        updates some asserts to use the second -- the first can be removed once
        no asserts depend on it.
        
        Change-Id: I5112946a964f338fc873ba13300023de9418e837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132687
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-08  Rizal Muttaqin  <rizmut@libreoffice.org>  [b426a8a4c672c20e515f1ce24404530748cc4df0]

        Resolves tdf#142071 - Align Tip of The Day with real menu/options
        
        Change-Id: I2050d0335d2d25e42b9c0164e56b0c981deee1bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132555
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-04-08  Jim Raykowski  <raykowj@gmail.com>  [efe854bf9b6daff3d0ecf6e3d04bd9a50bfaa3f3]

        tdf#148357 SwNavigator: recover scroll positon after content delete
        
        Change-Id: I6c376e5190575232d2867843c1b2b0e57e620aaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132691
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-07  Caolán McNamara  <caolanm@redhat.com>  [39076309c6583e62f6ee8e1558074a54b797637a]

        Related: tdf#148448 add a separate WarningColor settings
        
        instead of a hard-coded yellow. For gtk we can use the named color
        "warning_color" to populate it: https://docs.gtk.org/gtk4/css-properties.html
        
        Change-Id: I538bffdc0f6286c78a08cef649fa8a074a6510ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-07  Caolán McNamara  <caolanm@redhat.com>  [c44a9e6efe99d4dd8d553be5de96e970c6c3c9e4]

        ofz#46467 Timeout
        
        Change-Id: Ib2a248a6f912a340d2f0b79a068b68036fa357c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132690
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-07  Luboš Luňák  <l.lunak@collabora.com>  [c5199abfc1a468b28c680faf41e2f11bc1729c47]

        work around ICU performance problem in text breaking (tdf#116400)
        
        Reported upstream at https://unicode-org.atlassian.net/browse/ICU-21946 ,
        they've confirmed the problem, but so far no actual code change. So
        let's push my patch for now.
        
        Change-Id: Idd92ca66eea9b28103ad890aec66c40029ec7ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132676
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-04-07  Caolán McNamara  <caolanm@redhat.com>  [26e09fb1d50ae137431c1b86a1178ad1286b4f62]

        Red used instead of Green
        
        Change-Id: I1261154fcff6f4904b4360099cbf26e33b9e7463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132683
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-07  Michael Weghorn  <m.weghorn@posteo.de>  [365bd679904ec5f67d1061511d7faf73f9f8aa62]

        tdf#148445 sw: Make "Exchange Databases" dialog modal
        
        This among others prevents opening the "Exchange Database"
        dialog from the mail merge wizard, then closing
        the mail merge wizard while the "Exchange Dialog" is
        still open, resulting in a crash.
        
        Change-Id: I86bd80d0bfa6084bf0f772bb430b2a871e9b5ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132678
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-07  Michael Weghorn  <m.weghorn@posteo.de>  [dafa352065b31428c54e8eded382a36951f7af5c]

        tdf#148445 sw: Resave exchangedatabases.ui with glade 3.38.2
        
        ... in preparation of fixing the actual issue.
        
        Change-Id: Ia3e60984b06e4fda856889f5116b49aecbbfb960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132677
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-04-07  Miklos Vajna  <vmiklos@collabora.com>  [97c18cf32a9a3088b5a51e2b0d535d8caf5daca8]

        sw: keep URL when applying frame style on images
        
        It seems that the intention is to reset properties which are possible to
        set in a style when applying a style. For example the paragraph
        alignment can be defined in a paragraph style, so reset that on style
        apply.
        
        URLs on frames can't be defined for frame styles, so it looks incorrect
        to reset the URL of a frame/image on style apply, fix this.
        
        Change-Id: Ie3a57b654cf06b9512b25d2dc103d15cd83727b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132675
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [584b700a2cccb9a7e730dadae15dc926736becf1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad82ae5f3d9c01f46ecab00a767be9bbbac76872
          - tdf#141237 Improve text on PDF security
            
            Change-Id: I76e179b30fce9d4a9af3c1c86a2bf55e524a62fb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132613
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [fa86ea147feb466cc3903bf504800fde433222b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6ba91f1d3a845fb6684b296ce23077981ef307e
          - tdf#148443  corrections to print icons and labels
            
            Basic problem was that the wrong icon was shown for Print Directly
            and wrong label was shown for the Print icon. The following changes
            correct these problems.
            
                text/shared/00/00000401.xhp
                  * correction to Print icon label
            
                text/shared/02/01110000.xhp
                  *refactor to <h1>
                  *add correct icon table for print directly, with section label
            
                text/shared/main0201.xhp
                  *change the icon embed to the newly added print directly
            
            Change-Id: I7a094f016c5e30881abee3db5d13589f1512ba36
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132611
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            
2022-04-07  Caolán McNamara  <caolanm@redhat.com>  [7a89821b85dd20ec79a61aab3bd2b6c8e71f4939]

        ofz#46457 don't crash with mangled INCLUDETEXT field case
        
        Change-Id: I86621bce8587aeeeded90bc81ae9f17049c17f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [e81385277c091dabb1f6542a94229d7dcc77289b]

        tdf#143135 Qt break recursive IM QueryCursorRect
        
        To reproduce the Impress crash, you need an IM, e.g. fcitx / ibus.
        This is triggered by having an active input, like double-clicking
        one of a presentations text fields, then leaving the window and
        switching back to it.
        
        This results in a stack exhaustion in a few seconds. The backtrace
        is basically:
        
        QWidget::setFocus
        QtFrame::ToTop
        sd::Window::GrabFocus
        ImplHandleExtTextInputPos
        QtWidget::inputMethodQuery
        QInputMethod::cursorRectangle
        QWidget::setFocus
        QApplication::setActiveWindow
        QtInstance::DoYield
        main
        
        I scratched my head over the longer backtrace for while, but there
        seems to be no good way to prevent this from LO's POV. The only
        alternative from the Qt VCL plugin is QtFrame::ToTop. That code
        is less ugly (no mutable or cached result), but QtWidget::
        inputMethodQuery is earlier in the backtrace.
        
        Change-Id: Ief3a8e44bca295cc676e75050d52d70a1da98a88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132643
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-07  Vincent Reher  <lo@4reher.org>  [5aa7b65c882019b74cfab95e5e9c77150b2876b0]

        Resolve tdf#49091 "UI: Alt-Left, Alt-Right keyboard shortcuts ineffective"
        
        Change-Id: I245943fb9185e03cf52f144d9e06ab22cda13592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132651
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-07  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [965313b9efc761c70aacf6e3ebee60ffa2b1d5dd]

        tdf#95706: RTF import: Use fontname suffixes to detect encoding
        
        Font names like "Arial CE", "Times New Roman Cyr" are not special
        fonts. They are classical Arial, Times New Roman... And these
        suffixes can be used to detect encoding used for RTF text.
        
        Most interesting: for MS Word these suffixes have priority:
        {\f34\cpg1253\fcharset161 Arial Baltic;} will have cp1257
        and not cp1253.
        
        Looks like compatibility issue came from dark ages.
        
        Change-Id: Ife8e781d5d04c3f6a8c11fcf604357c74bf33055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132584
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-07  Mike Kaganski  <mike.kaganski@collabora.com>  [751c6e25a3998845325c9b107163fc23a85b3367]

        Make "Calc:" in About dialog's Misc show "default" by default
        
        ... i.e., when neither CL, nor threaded, nor Jumbo are enabled.
        
        Change-Id: I55d4a5e2e9b9a63c8ea2735dbd410603644d0389
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132659
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [244cf83b9e1b23b3b75a84954c83f6fbf915671e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5de0b43d57142eca8fab90fca1ca119cffb6039
          - Remove a Germanism
            
            Change-Id: I92f009369c2081c5085e07651948c0085aecfeef
            
2022-04-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [803c9a6f8d8681e1862e4132dbbc8cdb2f61b7b6]

        tdf#80043 - Put selected text into hyperlink item
        
        If the user selects an entire cell by a single click, and inserts an URL
        via the hyperlink dialog, the entire content of the corresponding cell
        will be replaced instead of inserting a duplicate, or appending the URL.
        If the cell contains more than one URL or an URL including some
        additional text within the cell, the hyperlink dialog will only
        preselect the text field when opening. If this is not the case, it fill the URL field as well.
        
        Change-Id: I9a10c3f302a6cf91a4d9dfadfbe775075eb00fad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131156
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-04-07  Miklos Vajna  <vmiklos@collabora.com>  [07a1442b2441cc032c05fd9abf5b1a8db6c7e007]

        sw content controls: select the content on click when showing placeholder
        
        - teach SwCursorShell::GetContentAtPos() about a new IsAttrAtPos::ContentControl
        
        - add a new SwCursorShell::GotoFormatContentControl() to select a
          content control, and a SwWrtShell::GotoContentControl() wrapper around
          it
        
        - combine these together in SwEditWin::MouseButtonUp()
        
        The intention is that when you open a document and you click on a
        placeholder text like "Click here to enter text", then this content is
        pre-selected (so typing overwrites it), but typing real content there
        disables this behavior.
        
        Change-Id: Ia539865da7b18c41cbfb398282842bdb2e25f0bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132652
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-07  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9a773e8ca65ccb30cdfbf47b94aabe356df8cad2]

        tdf#143264  improve expressions with %MOD1 -/+
        
            also add link to relevant help page
        
        Change-Id: I087b3fe2573665a633dc04b222bcc3950edd782a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132385
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-07  Michael Stahl  <michael.stahl@allotropia.de>  [b11a5d3900e3c19e94833c1b1e5218288320c3e3]

        nss: depend on zlib
        
        Required on WNT since 1c748fefc3c5b42e3548a1a7f5017a579982005a, may
        be needed on other platforms if using --without-system-zlib.
        
        Change-Id: Ib8e544d81881f425d257514fc475e272ca2e53ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132648
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-04-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0e2fbf90571f4e0f966e661dff4e12524ce59275]

        sc: add sparklines commands to main menu
        
        Change-Id: Ie69d78162fb0d845f8ffd181397569c3cd3276f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132593
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [36ffd9022ff988f9f10e3bcc9b2b2a4f982b74bc]

        sc: take sparklines into account with auto fill
        
        Change-Id: I6bdb5f4291aece7ec02d8de0731b8f983b4f2bb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132592
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [93d7fbf73f8be7f09dd36e86f0dd06dfc8daa65c]

        sc: improve keeping track of sparklines in SparklineList
        
        Issues can happen when saving a document with sparklines where a
        sparkline is deleted and then undo-ed. The reason for this is
        because the SparlineList wasn't correctly updated when deleting,
        copying or adding sparklines. This change adds hooks when new
        sparklines are created or when sparklines are deleted to report
        this into SparlineList.
        
        SparklineList garbage-collects itself but this is not enough when
        we rely that the non-deleted weak pointers to the sparkline groups
        contain the correct non-deleted weak pointers to the correct
        sparklines.
        
        Change-Id: I976cbe7e6168813d3dd5089c036cc7fe4e357fb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132554
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-07  Caolán McNamara  <caolanm@redhat.com>  [ff2f433cdfda74dbf69a11342a98ccbfb5bc6a72]

        typo: out->our
        
        Change-Id: Ibd8eedb1d4fb7f32e7bd11cd62a921e480b9acd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132630
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ece3a421c2d577f7aad5b9457c9cd532f1c4a64f]

        Fix typo
        
        Change-Id: I4252e13a679ac84f255c8f9a63d1e7aa8fa270ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132649
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-07  Miklos Vajna  <vmiklos@collabora.com>  [f5db3b12ae1cd3bfe6ee5d260aec9532cc65f2dc]

        sd theme: add UI (sidebar) for shape fill color
        
        This requires extending .uno:FillColor with a new parameter, and then
        merging that parameter into the fill color item in sd/. The sidebar's
        color picker already generated these parameters.
        
        Change-Id: I83e3c4fc37b8d7bd34f0ef9c0cb96e164f7f0b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132646
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-07  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [6240902d996c31c1200fa523f89a419a934cde58]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9839c0b071de018ea00af1ae180756e9e5a52793
          - Revert "Fix typo"
            
            Besides being a wrong fix, please refrain from changing external code locally.
            Go to the upstream project instead, Andrea!
            
            This reverts commit 1e37e14da918a278abe5df8a5885fa211c02ee8b.
            
2022-04-07  Michael Weghorn  <m.weghorn@posteo.de>  [5b3227fac58dcbd588e2389e205679cd77842bac]

        tdf#147285 qt: Prefer "text/plain;charset=utf-8" over "text/plain"
        
        If there were no data for MIME type "text/plain;charset=utf-16"
        in the clipboard, but "text/plain" was provided, it was previously
        assumed that this would be encoded in the locale's encoding, and
        corresponding conversion using that encoding happened to provide
        "text/plain;charset=utf-16" ourselves.
        
        "text/plain;charset=utf-8" data was simply ignored, but using
        it (if present) and preferring it over "text/plain"
        is more reliable (and e.g. avoids incorrect paste of Chinese
        characters from Firefox into Impress when using the qt5/qt6/kf5
        VCL plugins on Wayland), so use it if present.
        
        Rename the "m_bConvertFromLocale" member to better fit
        the new meaning.
        
        (An alternative solution to adding our own handling for
        "text/plain;charset=utf-8" and making assumptions for the
        encoding of "text/plain" data would be to let Qt handle
        this and just call `QMimeData::text()` for the
        `m_bProvideUTF16FromOtherEncoding=true` case
        in `QtTransferable::getTransferData`.
        Since qtbase commit 589a01ff6b1eacf81e74a5fc4801572135214f43
        ("QMimeData: Prefer UTF-8 when multiple charsets are available",
        contained in Qt >= 5.13), that one handles MIME type
        "text/plain;charset=utf-8" in addition to "text/plain".)
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=589a01ff6b1eacf81e74a5fc4801572135214f43
        
        Change-Id: I89f33216bf6be02a347d245b2359273af2eb530a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132631
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [55b20c8781d7718fa992769df90282563694f7fe]

        tdf#121887: subsequent_filters: Add unittest
        
        Change-Id: Id3eff5a59e80483d24e4a09227161aa24c4618f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132639
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-06  Mike Kaganski  <mike.kaganski@collabora.com>  [aeeacd28456c8c1f223342c45bf8c7199e3acd34]

        Drop write-only uses of pNonConvertableChars argument
        
        Change-Id: Ibf60405868cfda08d125f63c45f8b74e52b32da4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132642
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [286ad6905bf5b773bf4cf7ab655e710434e6a35c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4b68b8f837be5932a30a9ff3546afeeaea4f93a5
          - Some ScriptForge services lack a pre-requisite note 2/3:
            
            - included pre-requisite note in SF help page
            - created a Python biaised note for 'Basic' service
            - will create a Basic biaised note for Basic oriented services in a subsequent patch 
            
            Change-Id: I0810602b527fde14e4a013857482fc892593ca7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132386
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-04-06  Michael Stahl  <michael.stahl@allotropia.de>  [9dc6e2c9062725ef1f9d7e321cae5f4dbe8ca749]

        sw: fix expansion of SetGetExpField in headers with split table rows
        
        The problem is that a get field in a header on page N may calculate and
        show values that do not take into account a set field on page N-1.
        
        This happens if a table row with multiple columns is split across the
        pages: SwGetExpField::ChangeExpansion() calls GetBodyTextNode(), which
        returns the first node in the first column that is on page N, but in the
        SwNodes array this node is *before* any node in columns 2..M, any of
        which may be on page N-1 in the layout.
        
        So try to fix this by adding a page number to SetGetExpField and using
        that as the highest priority in operator<().
        
        This is a bit risky because some of the places that create
        SetGetExpField don't have a frame to get the page number from; try to
        adapt all that call into MakeFieldList(), while leaving unrelated ones
        such as in MakeSetList() unchanged.
        
        Change-Id: Ied2a897ad34f0faf1ef3d50baad07b23fafd49bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132641
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-06  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [9592da0a8e596869a1cd0859619dd28a541d7234]

        tdf#148327 docx export: fix puzzle shape
        
        There is an exporter class for preset shapes,
        namely the DMLPresetShapeExporter, which in
        its ctor calls the msfilter::GetShapeName()
        converter method where the puzzle cause
        exception. To avoid this return with false
        to export it with custgeom in time.
        
        Change-Id: I8d29bf551638a66abf381c9cb8f6a0eebc881195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132567
        Tested-by: Jenkins
        Reviewed-by: Attila Bakos <bakos.attilakaroly@nisz.hu>
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1b8895c0fb6f131be27b93a84f6dc061678f78f8]

        Fix typo
        
        Change-Id: I14c4941e02a1b09966aaee08621b102d9db7c8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132627
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f93b789913400cbaa909e67a533656e6e97c88cd]

        Fix typo
        
        Change-Id: I88841e2ffb5a3717c15644c948d95c3ce46bd0d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132636
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-06  Julien Nabet  <serval2412@yahoo.fr>  [e0bd17c169fbf97f7f3223db43c432f9c4513602]

        tdf#148395: CRASH: doubleclick on chart OLE Object (bandaid)
        
        Change-Id: I623d2cf4b4665cd33e30ef0891d831370faf2553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132591
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-04-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [4a537cf77affc4f1f2e2e5be9ff0b1ff11724509]

        Qt drop unused QtMenu::mpCloseButton
        
        Change-Id: I988cabf4c07d5efd298c53b696f6d114f4f594bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132637
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [77a4b5b9b9a95ed4f9b4fccdb76d403086212fe2]

        sc: qahelper: Check GetErrorCode returns none in loadDoc
        
        I found it while creating a unittest for tdf#121887.
        IMHO, loadDoc should fail if there is a warning
        While at it, remove redundant assertions
        
        Change-Id: Ib2b9572ee1f0f4da9ac23913e231eac1ad57cb49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132638
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ca5d5a2ad5d0ee348dc4a814afcc0d8f11519517]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6304ba5dd0efe2d5e2a16254aa9e7d2e74f5660
          - tdf#127477, tdf#131382 scope of function Minute
            
            Change the headng of the Minute function to indicate BASIC scope
            
            + refactoring of the Help page
            
            Change-Id: I50286245c2e2f573d0ad4c96e37bcb218efe2954
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132632
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-06  Hossein  <hossein@libreoffice.org>  [9c2c16fbd1282a21ffb82f71e7e3c575fd0e78b6]

        Remove duplicate DevGuide example FirstConnection
        
        While cleaning up "LibreOffice DevGuide: Chapter 1 - First Steps" in
        the TDF Wiki, I understood that only 3 examples were compiled via the
        Makefile, but there were 4 java files. It turned out that the
        FirstUnoContact.java and FirstConnection.java are essentially the
        same. I removed the second one, as it was not built, and was not
        referenced elsewhere.
        
        Change-Id: I7df5dd9dfc3aae15de4484b4a3dd6272066a8683
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132457
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-04-06  Hossein  <hossein@libreoffice.org>  [f385661ec1463053c1ca51dc50db075c478de87c]

        tdf#148359 Fix emfio regression: missing emf image
        
        This patch fixes tdf#148359 which prevented the display of EMF images
        embedded in the rtf files or even loading when loading them directly.
        
        Looking into the problem caused by the cleanup commit
        3e7dd04dd8ca1baea4b7918eb7a7080c595c4625, it became visible that
        while enums were converted to enum class, there was a cast that
        was wrongly ommited:
        
            - sal_uInt16 nStockId = static_cast<sal_uInt8>(nIndex);
            + StockObject nStockId = static_cast<StockObject>(nIndex);
        
        Now, it is re-written as:
        
            StockObject nStockId = static_cast<StockObject>(nIndex & 0xFF);
        
        The symptom was that the StockObject field was mishandled, and thus
        the shapes were displayed in white, instead of black.
        
        "Stock Logical Object" is discussed in the MS document for EMF:
        
            * [MS-EMF] v20210625 - pages 44, 45 and 182
        
        A unit test is provided to make sure that the regression does not
        happen again. The test can be run by:
        
            make CPPUNIT_TEST_NAME=testStockObject -sr CppunitTest_emfio_wmf
        
        Change-Id: I9a7f1008e92a96d9fb12aeb7bd057af828c1722a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132540
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-06  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [4e8d6ccf97e29e5ea14e0d074074606f12040f36]

        Advanced Diagram support: Enhance BackgroundShape handling
        
        The BackgroundShape may have a FillStyle after import, so do
        handle that FillStyle accordingly. Also enhance breaking
        the Group by keeping that shape in that case and deactivate
        Move/Size change lock for it. Also Undo needed.
        
        Change-Id: Iccdb236a2311275efc07162fd4bd2cfc252fd437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132626
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-04-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c0f8570361aa4c2b771b758284258f8a8f0246f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68c52a06cf89d374fd8d46a5d5f78bd3d4a0cb9a
          - tdf#131382 Scope of functions LOG and ASC
            
            Change the heading to indicate BASIC function and not a Calc function
            
            Change-Id: I8dae4b7baf64b42dfa156b6dde8039baa6ac3058
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132629
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-06  Mike Kaganski  <mike.kaganski@collabora.com>  [e4f53484d255f844169957c411dc3e872af7d3bb]

        tdf#148413: Drop HTML export encoding configuration; use UTF-8
        
        Anything else is just a joke today.
        
        Change-Id: Ie6a0cec1edcd257cbadef702018e6a919e6a0b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132628
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-06  Stephan Bergmann  <sbergman@redhat.com>  [2f4d577e60a934e2845c90e00bac06072351ec65]

        Fix --enable-breakpad builds
        
        ...after c9b69e412b9646f7d49f500d47a078c2ea155c8c "tdf#130924 replace debugging
        printf calls with SAL_INFO/SAL_WARN" (and remove now-redundant "\n")
        
        Change-Id: I11fb72d3b2f71ec0fce2386b1c0560cc873e2859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132623
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [c0919c6e5787dfb45f1a3e4b8b5ad6f1ff28f1ae]

        tdf#144996: sc: Add unittest
        
        Change-Id: I8e6d9f420e9b487089cefaa1e7bf5a6082d6ce52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132622
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [9c4ef8ce3183e27ca174475cf4a8d15cc0368f60]

        tdf#145954 Qt unshare QMenubar usage
        
        The Qt code was sharing the menu bar from the top level frame, but
        LO expects independent menu bars per SetFrame calls. So instead of
        showing the new bar and then hiding the old one, this was always
        show and hiding the same menu bar, resulting in a hidden menu bar.
        
        As a result of unsharing, LO now must check that its menu bar
        pointer is still valid for usage. The QMainWindows takes ownership
        when a QMenuBar is assigned and destroy old ones.
        
        Change-Id: I2c6b12199a1e17a5d9f88686a4b27b1413beda47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132581
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-06  Hossein  <hossein@libreoffice.org>  [51431559bda9a81293d502328982452caeeba6c6]

        Fix type, calculation of FamilyFont PitchAndFamily
        
        This patch fixes problems caused by the cleanup commit
        3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 for type and calculation of
        FamilyFont and PitchAndFamily enumerations.
        
        FamilyFont enumeration is described in [MS-WMF] v20210625 page 33:
        
          "In a Font Object, when a FamilyFont value is packed into a byte
          with a PitchFont Enumeration value, the result is a PitchAndFamily
          Object".
        
        Thus, we will use sal_uInt8 as the underlying type for FamilyFont.
        
        The PitchAndFamily is created as shown in [MS-WMF] v20210625 page 96:
        
        [0 1 2 3] 4 5 [6 7]
         Family   0 0 Pitch
        
        The values for FamilyFont enumeration are created according to the
        [MS-WMF], and the calculations are changed to use '<< 4' and '>> 4'
        instead of applying the same shift to the enumeration values.
        
        Change-Id: I4f6df33ed6405589acf89ba2c9223a571cb510b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132614
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-06  Stephan Bergmann  <sbergman@redhat.com>  [cedf0b23542a06cd31440dd1deb450d03191a1b9]

        Remove obsolete HSQLDB_USE_JDBC_4_1
        
        ...that must always be true ever since 1b8c61d5ca8e2a7ae7a0bcd189b7a87defecea03
        "Bump JDK buildtime requirement to 1.6"
        
        Change-Id: I9432ac9d0a0e2c4999a80b6f144099d0e4dc15bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132616
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-06  Stephan Bergmann  <sbergman@redhat.com>  [fd0aa82a61612b90352b0780e62bb4d4dd0d94f8]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/e7cb9cff2cf5db044195a7626327bd29b4b00c44>
        "Merge pull request #184 from xlejo/adding-gvfsd:  Adding xdg-run/gvfsd"
        
        Change-Id: I1b700c1e7170e67abf3fb1351be9f8c11cc15f8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132617
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-06  Vincent Reher  <lo@4reher.org>  [2703f729e9ea0bbc1f64b04b535a676a2980e1b8]

        Resolves: tdf#146174 allow shortcut key event handling before menubar
        
        Change-Id: Ib0dadafcc66604baf53169cb222a059ee3f97362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132615
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [fbf739198aa7f02975d531521c6525073783c7f1]

        tdf#144585 Qt fix Wayland LO fake popups
        
        So Michael Weghorn was somehow reminded of an abandoned
        commit from me ("Qt5 rework parent handling") archived in
        https://gerrit.libreoffice.org/c/core/+/73463.
        
        The bug introducing the new QWidget parenting, tdf#145363, was
        resolved in a better way by explicitly setting parents for the
        modal dialogs, so LO doesn't break Qt anymore. The actual problem
        is, that an additional modal dialog needs to be stacked to the
        previous modal dialog; no "parallel" modal dialogs are allowed,
        which my original fix tried to enforce by reparenting.
        
        Then there is the problem with Qt::Popup's focus grabbing on show,
        which breaks LO's editable ComboBox. So LO's popup / FLOAT windows
        are mapped to Qt::ToolTip, which are automatically advertised as
        tooltips via accessibility. For X11 / xcb, Qt:Window with the
        Qt::BypassWindowManagerHint works well enough as an alternative,
        but WASM and Wayland don't seem to implement it correctly, so this
        just handles popups as Qt::ToolTip on all platforms.
        
        This reverts commit b00a68a8e19370e106cd76258a3c1825f43613ee
        ("tdf#145363 Qt reparent modal dialogs on show").
        In addition the popup widgets are switched back to Qt::ToolTip.
        
        Change-Id: If726771b4e9cc3f639f21cf502b3ec5985873643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132526
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-04-06  Miklos Vajna  <vmiklos@collabora.com>  [c2999f9f3e0efa04f89055399f2d176c9c95e92d]

        sw content controls: add overlay to render a border around the text portions
        
        - introduce SwSelPaintRects::HighlightContentControl() to create the
          overlay
        
        - use GetTextAttrAt() to enable this when we're inside a content control
          (not only when the cursor is exactly at the dummy char of the content
          control, which is at the start)
        
        - tested that this works correctly even if the portions inside the
          content control don't have the same height (similar to the selection
          overlay)
        
        Change-Id: I1db51cdb1ddc87c45740cd8677de645dc8906697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132618
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-06  offtkp  <parisoplop@gmail.com>  [c9b69e412b9646f7d49f500d47a078c2ea155c8c]

        tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: I2e7225b846c307e9a182dadfa490d9f7ff15d35e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132488
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-04-06  Miklos Vajna  <vmiklos@collabora.com>  [91cbd74b6d469079e97064c9c88e0860941841fa]

        CppunitTest_sw_ooxmlexport7: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I32bd9a8e6ddf706f87bc2f17b75539d4d4c68f13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132586
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [27aa7df0a093c9e18ce591d8c73b524ef7ff40de]

        sc: prevent a crash when deleting a sparkline
        
        Change-Id: Idf89d4bbdc2bd29ce55cc3a8fd6707ece345869c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132553
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3bc9f6176ad540d613a1238466e20f9ad3903881]

        sc: put SparklineList implementation into SparklineList.cxx
        
        Change-Id: I309087a27ea0bc297c9bea9b2b8945579e055f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132552
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c6fecc628a60a3955c022f04020cdb515cc4fb6e]

        sc: add Group and Ungroup to context menu for sparklines
        
        This change allows to group parklines together into a sparkline
        group, or ungroup them, so they use their own sparkline group.
        This also adds the undo and redo for this actions.
        
        Change-Id: I61b604203afaf2fe8c2d47b80082739ded15d6fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132545
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ec18c7bf707e85d85f362d43454d35b1636de40f]

        sc: add "Delete Sparkline Group" context menu action + Undo/Redo
        
        Change-Id: I34e11a4881c564351c3e08d157fb42ac4bb8ef3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132544
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Julien Nabet  <serval2412@yahoo.fr>  [ad3d2d1bc7e07f79a26841d89a85e94999a7c8ca]

        tdf#148397: Crash on font features dialog opening with EB Garamond
        
        bt:
        0  0x00007f7ba5ef549c in rtl::str::acquire<_rtl_uString>(_rtl_uString*) (pThis=0x0) at sal/rtl/strtmpl.hxx:825
        1  0x00007f7ba5ef8d45 in rtl_uString_acquire(rtl_uString*) (pThis=0x0) at sal/rtl/ustring.cxx:1199
        2  0x00007f7b485757e3 in rtl::OUString::OUString(_rtl_uString*) (this=0x7ffc345a9f20, str=0x0) at include/rtl/ustring.hxx:252
        3  0x00007f7b485fd1da in cui::FontFeaturesDialog::fillGrid(std::__debug::vector<vcl::font::Feature, std::allocator<vcl::font::Feature> > const&) (this=
           0x7ffc345aa538, rFontFeatures=std::__debug::vector of length 43, capacity 64 = {...}) at cui/source/dialogs/FontFeaturesDialog.cxx:98
        4  0x00007f7b485fcc83 in cui::FontFeaturesDialog::initialize() (this=0x7ffc345aa538) at cui/source/dialogs/FontFeaturesDialog.cxx:66
        5  0x00007f7b485fc8b9 in cui::FontFeaturesDialog::FontFeaturesDialog(weld::Window*, rtl::OUString const&) (this=0x7ffc345aa538, pParent=0x6f2f748, rFontName="EB Garamond 12")
           at cui/source/dialogs/FontFeaturesDialog.cxx:28
        6  0x00007f7b488f3165 in SvxCharNamePage::FontFeatureButtonClicked(weld::Button&) (this=0x6f0a620, rButton=...) at cui/source/tabpages/chardlg.cxx:1157
        
        Revealed with 5afdcad4c0e7850b18996c549892b9360cd8973f
        Pass context and resource string down to boost::locale separately
        because this is often on a hot path, and we can avoid the splitting and
        joining of strings like this.
        
        Change-Id: I20b18c8f46014feb453f81d66dd7cb490124efa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132590
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0fafd7ff653e26ccafc5067d1387d72239de8d3f]

        Fix typos
        
        Change-Id: Idcb10d0cc0759473e95e47afec7ed69853628612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132587
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [6453502fa8d3cc83e066c550d8df98facb1f4471]

        Related tdf#148384: do not pause after last email's failure
        
        In this case, SwSendMailDialog::AllMailsSent will keep the dialog open
        anyway, to allow to see the resulting report containing errors.
        
        Change-Id: I351a5da01c3ab50677be1d735b261d8e5516cb43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132588
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cbb66e9ace2151d4386ce100aabc3a2b0c9d483e]

        Fix typos
        
        Change-Id: Iaf248ec769b82bdb22ac0620a1dc31ea90823d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132535
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0f1ca9e3c5d9df15e71171086612624baea9aaca]

        Fix typos
        
        Change-Id: Ifed6fa039466e580d911af91288c4a37bce08aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132560
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b621e3e9013630ec8f57c6800e029b5c5d8d4d13]

        Removed duplicated include
        
        Change-Id: I7e1608faf0dcb92ad710cb0f6346e9ceca2954aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132559
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-04-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a9cd6c9fffc89cf00337e7caeca057567867a67]

        tdf#107952: sc_uicalc: Add unittest
        
        Change-Id: I121e645582edfd1985a2a099dc5e572a54a4bf8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132576
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-05  Caolán McNamara  <caolanm@redhat.com>  [5d41c2461642364b7159398024acccbee12f6e3e]

        forcepoint#104 sw: do not delete fieldmark chars in MoveNodeRange()
        
        The problem is that SwXTextTableCursor::mergeRange() wants to move some
        nodes, and the deleteMarks() deletes a fieldmark creating a SaveBookmark
        but it contains the positions relative to the CH_TXT_ATR_FIELD* still in
        the text, while deleting the fieldmark of course removes these.
        
        The SaveBookmark would need to adjust the indexes and store the
        separator position too and the vector would need to be restored in
        reverse order.
        
        But every time the SaveBookmarks are created, they are restored as well,
        so it looks simpler to just suppress deleting the CH_TXT_ATR_FIELD* in
        this case, and inserting them too (latter is already done when copying
        text).
        
        Change-Id: I690c6432a38eab6dec10adff74e638f0e52cca55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132531
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-05  Caolán McNamara  <caolanm@redhat.com>  [8f80986d6209bb79c44ca03c1f7b69c55cd9a854]

        Resolves: rhbz#2069486 classic help index entry autocompletes on del/backspace
        
        when it shouldn't
        
        Change-Id: I90fa338479e0d5612d7b09f94c45e356ea71f89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [ab62691aa212883704191049da132592d4f477fa]

        m_nSendCount -> m_nProcessedCount
        
        ... because that is what the number actually means, not that
        that many mails were actually sent.
        
        Change-Id: Ieff6dc7bf664b52ea20eaf8ba23a37a3024ba43d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132580
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8682ddfbb4b26902f7e7c2a4cdf63d623621b418]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e37e14da918a278abe5df8a5885fa211c02ee8b
          - Fix typo
            
            Change-Id: I7006b64cad6a049ea45d368e22842115ab97e4ef
            
2022-04-05  Jean-Pierre Ledure  <jp@ledure.be>  [2e3c34521d78cb738755ca93bebe606b0f627535]

        ScriptForge - (SF_Utils) new _VarTypeObj() method
        
        The method is for internal use by the ScriptForge core only.
        
        The only argument is an object with VarType() = V_OBJECT.
        
        The purpose is to inspect thoroughly the argument
        and to return a
           Type _ObjectDescriptor
              iVarType As Integer
              sObjectType As String
           End Type
        The iVarType indicates if the object is either
         - a UNO object => sObjectType contains the UNO type ("com.sun.star. ...")
         - a ScriptForge class instance => sObjectType contains the class
         - another Basic object
         - Nothing (different from Null)
        
        Several existing methods benefit from the new method and are part
        of the commit.
        
        No effect on help pages.
        No effect on Python code.
        
        Change-Id: I69565d335b3aeb7c08c48cbccfc13d3d82f11ae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132525
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-05  Miklos Vajna  <vmiklos@collabora.com>  [61888e49d6eee55197ca1c27b4b023f9b2108d48]

        tdf#148366 sw clearing breaks: fix handling of anchored objs from header/footer
        
        Regression from commit f86d1482bef285f90079b5130e410646db96cf58 (sw
        clearing breaks: add DOCX import, 2022-03-08), the trouble was that we
        considered an anchored object from the header for text wrapping, while
        this anchored object was in the background in Word.
        
        Change-Id: I806cc91ce1eb390c02cbff2defa4cb47fde86853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132578
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-05  Stephan Bergmann  <sbergman@redhat.com>  [19de5d97efbb80e9767bc6b873bcc2c263a721de]

        Allow building against JDK 18
        
        ...where ExternalProject_hsqldb failed with
        
        >      [java] java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release
        >      [java] 	at org.apache.tools.ant.taskdefs.ExecuteJava.execute(ExecuteJava.java:194)
        >      [java] 	at org.apache.tools.ant.taskdefs.Java.run(Java.java:891)
        >      [java] 	at org.apache.tools.ant.taskdefs.Java.executeJava(Java.java:231)
        >      [java] 	at org.apache.tools.ant.taskdefs.Java.executeJava(Java.java:135)
        >      [java] 	at org.apache.tools.ant.taskdefs.Java.execute(Java.java:108)
        >      [java] 	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:299)
        >      [java] 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        >      [java] 	at java.base/java.lang.reflect.Method.invoke(Method.java:577)
        >      [java] 	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
        >      [java] 	at org.apache.tools.ant.Task.perform(Task.java:350)
        >      [java] 	at org.apache.tools.ant.Target.execute(Target.java:449)
        >      [java] 	at org.apache.tools.ant.Target.performTasks(Target.java:470)
        >      [java] 	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1401)
        >      [java] 	at org.apache.tools.ant.Project.executeTarget(Project.java:1374)
        >      [java] 	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        >      [java] 	at org.apache.tools.ant.Project.executeTargets(Project.java:1264)
        >      [java] 	at org.apache.tools.ant.Main.runBuild(Main.java:818)
        >      [java] 	at org.apache.tools.ant.Main.startAnt(Main.java:223)
        >      [java] 	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
        >      [java] 	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
        >      [java] Caused by: java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release
        >      [java] 	at java.base/java.lang.System.setSecurityManager(System.java:416)
        >      [java] 	at org.apache.tools.ant.types.Permissions.setSecurityManager(Permissions.java:103)
        >      [java] 	at org.apache.tools.ant.taskdefs.ExecuteJava.run(ExecuteJava.java:216)
        >      [java] 	at org.apache.tools.ant.taskdefs.ExecuteJava.execute(ExecuteJava.java:155)
        >      [java] 	... 19 more
        
        while building target switchtojdk17 (but then unfortunately carried on, without
        the source modifications that should have been done by that target, leading to
        confusing errors like
        
        >     [javac] workdir/UnpackedTarball/hsqldb/src/org/hsqldb/jdbc/jdbcConnection.java:426: error: jdbcConnection is not abstract and does not override abstract method createStruct(String,Object[]) in Connection
        
        that should have been under control at least ever since
        7dbfc0012cc75e7dac9a416b53149ad8ec33f071 "make hsqldb build with java 1.7".)
        
        Unconditionally passing ANT_OPTS -Djava.security.manager=allow would cause older
        JDK versions (like Java 11) to fail with a java.lang.Error "Could not create
        SecurityManager" caused by a java.lang.ClassNotFoundException "allow", so
        introduce JDK_SECURITYMANAGER_DISALLOWED_FOR_BUILD.
        
        This should allow us to keep building against at least JDK 18, even though later
        versions of Java may remove the Security Manager completely, but in which case
        hopefully an updated version of Apache Ant will become available.
        
        Change-Id: I9d143d8bcfff67870017bb1c874eec53e0ff9672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132558
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-04-05  Stephan Bergmann  <sbergman@redhat.com>  [7c5ca44c48b05ba73defd48057a82db7dc833e0c]

        Expert Configuration: Allow modifying nil values
        
        The Expert Configuration's approach of classifying configuration properties
        based on their dynamic css::uno::Any types is hopelessly naive and broken, but
        lets add a little hack to at least allow setting a non-nil value for a nillable
        property of non-any type that was nil.
        
        (This change was motivated by the comment at
        <https://gerrit.libreoffice.org/c/core/+/132495/1..2/officecfg/registry/schema/org/openoffice/Office/Common.xcs#b2394>
        "allow to override the generator/producer string in output documents":  "The
        default value is needed because otherwise the advanced settings editor in
        Tools->Configure->Advanced claims the type is 'void' and doesn't allow editing
        it."
        
        Change-Id: Ia8eef454919b05bda23e56639e93c765ba3a8b13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132575
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [abaa11329822d659581d7860a82308409189f0f5]

        Related tdf#148384: Improve mail merge results reporting
        
        1. Disambiguate "address validity check failed" from "mail delivery error".
        2. Change "Cancel" button into "Close" when operation is finished.
        3. "%1 of %2 emails sent" changed to "%1 of %2 emails processed", since
           the number does not reflect the sent status, and includes failures.
        
        Change-Id: Idb4934618a843133dfb35de10b9903875094366a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132565
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [64b046b908cdf1204b105f1ebddfc41a5054e884]

        Related tdf#148384: Don't overwrite task name with result
        
        Regression after commit	ed200d9f2586b714718aaa7319ea68cf480261ad
          Author Caolán McNamara <caolanm@redhat.com>
          Date   Fri Jun 28 16:01:00 2019 +0100
            weld SwSendMailDialog
        
        Change-Id: I397d3263268b94f83f2ccd7137c3de36e91a03a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132564
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [2d9f12be1530f2532276a2447102ed2f1f0ecb5b]

        tdf#148384: Really leave mail merge results dialog open upon errors
        
        Restructuring mail merge in 5.2 cycle had broken the dialog keeping
        open when errors happened during sending. Later, in 2017, in commit
        bfaa6e35ff09a0426d2c3c9c36f069fabc0c9489
          Author Alex McMurchy1917 <mcmurchy1917-libreoffice@yahoo.co.uk>
          Date   Thu Aug 24 14:34:13 2017 +0100
            tdf#103919 mailmerge: prevent premature end of emailing
        
        SwSendMailDialog::AllMailsSent was changed in attempt to restore that
        expected behavior, but the condition was incorrect:
        m_nSendCount == m_nExpectedCount means "all mails processed", not
        "everything went without errors".
        
        So fix this by considering the error count when deciding to close the
        dialog.
        
        Change-Id: I98d61165803deaf0da985167ba0152e6f50f9246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132563
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [304be70b5b082ac4854dadc9e6a7c15075dd28b2]

        tdf#148382: Keep first entry selected when address field is not set
        
        Regression after commit f1ca64800074530d95e507f93c764a687310b9eb
          Author Caolán McNamara <caolanm@redhat.com>
          Date   Thu Oct 18 09:52:28 2018 +0100
            weld SwMMResultEmailDialog
        
        ListBox::SelectEntry did not change previous selection in case the
        entry was not found (because GetEntryPos would then return a huge
        "not found" value). OTOH, weld::ComboBox::set_active_text clears
        selection in that case (because find_text would return -1).
        
        The code makes sure to pre-select entry 0 before attempting to
        select an explicitly configured adderss field name; so keeping
        that entry selected when no field name is configured is expected.
        
        Change-Id: I9c8704261ce19bf06633bd4791d294fb16e76f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132562
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [fafadd7aee8c384af210008f693b5007a9f5ea48]

        tdf#148361: docx sdt: cleanup databinding data after inserting
        
        Databinding data is used only for current sdt block. It should
        be clean up after usage to avoid impact on next sdt blocks.
        
        Change-Id: I53f47dd655ed027d40eb518784dcae69813e612f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132524
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-04-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [28318bed905f21d25aa69d4153858e91b6d13cd1]

        tdf#99386: sc: move UItest to CppUnittest
        
        Change-Id: I8e79fd47abe238cbee47eed07ab3840f77dac431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132573
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-05  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7d7b413827368e79acf44e77da7022992152433b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 54fe9a16bee3b3b4f16add8bea3bc64a2a575cba
          - Minor string fixes
            
            Change-Id: Ic7ff445fea3ce1e7369554b165e4ae2aa4cb6c1d
            
2022-04-05  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [4319c73962d09ea8ace93d227c7b2c8ea032e5ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bf9c6c2a2b201e672b42bd36dcf08ce3e6601234
          - Minor string fixes
            
            Change-Id: If1f76eacb11216a0b647948e956c7c99711f4c35
            
2022-04-05  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e3a996bf72a16f5b22e6ff021745af5cec70a632]

        tdf#139948: docx and rtf import: emulate border in between
        
        Writer does not support border in between available in all MS
        formats. Since this feature is missing in core it will be
        better to emulate it with top borders than to ignore it
        completely.
        
        Change-Id: I4e5a99cde5908066c4bb483136cfe9a1316df53c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132429
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-05  Miklos Vajna  <vmiklos@collabora.com>  [8c632d8a837cc722c6e7b3b400f6d97edf9f9800]

        sw content controls: add initial layout support
        
        - portions inside content controls are not text portions but content
          control portions
        
        - teach SwTextPaintInfo::DrawViewOpt() to paint field shadings for
          content control portions
        
        - teach the attribute stack code about RES_TXTATR_CONTENTCONTROL, so if
          the whole document is just a content control, then adding text
          before/after the content control is properly text portions, not content
          control portions
        
        Change-Id: Ia9f955a5f7c7a4fd633899fafa8fc723e7c0d050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132556
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-05  Stephan Bergmann  <sbergman@redhat.com>  [19d623d54503327e47f6effa3507342ddbea3d73]

        Simplify GlobalNamespace check
        
        Change-Id: Id70abc5d1ccdc41dc771fe77ad0e7584efe76826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132569
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [af2741223e21128e95cb7df1ac0f5942b35b3365]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58d1badf99624f469e9b16a4b00d11ec992ecc1c
          - Update prism.js/css to v 1.27
            
            Upload un-minified version
            
            Change-Id: I4a74a06f4639acfcc6b1bbf08f223f69dba1f8e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132570
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-05  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [c79fa460fe6220051bbda2d3c0cb67fbf765e2ac]

        Advanced Diagram support: Move Diagram Text information to svx
        
        In a next step to get the Diagram mechanism/ModelData independent
        from oox, I moved the Text ModelData to svx, using a TextBody
        struct. This is a 1st move that covers most of what the
        algorithms to handle Diagram re-layout and other functionality
        use. This will potentially have to be extended accordingly
        when missing data is detected. It is potentially much more
        simple as the oox TextBody, by purpose.
        
        Due to functionality using that data I could now massively move
        more of it to svx.
        
        Change-Id: I6d6e6c572f119aeefa4e91eff56f58f3ceb6a31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132523
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a2bcac670ef0254d8b2e8632cfe07bb855b28d1c]

        sc: improve SparklineList to track added SparklineGroups
        
        SparklineList used to only track added Sparklines for a sheet, but
        usually (in an export) we want to start with SparklineGroups and
        then search for all sparklines belonging to a group. This changes
        to use that. Now there is a method getSparklineGroups() and then
        another method getSparklineFor(), which returns all sparklines for
        the input group.
        
        Also added SparklineListTest, and refactored the export code for
        OOXML and ODF.
        
        Change-Id: I975e30f649788d41aab92a9a3220e38998e39670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132543
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Seth Chaiklin  <sdc.blanco@youmail.dk>  [a207f96a089094072536911513056427071a1fa9]

        tdf#148355 add link to help for hyperlink click options in ToD
        
        Change-Id: I0427b69744712596d8693a16490408b48f804d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132393
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-05  Mike Kaganski  <mike.kaganski@collabora.com>  [b32c85d0beb219e9f4ba9f043ae712b5d3ce2c18]

        Move creation of case-insensitive variable name to a central place
        
        SbxVariable::NameToCaseInsensitiveName might then be used wherever
        such names may be needed (see e.g. tdf#148358).
        
        Change-Id: I7749a12a05225398848cbf72700c6f0bc119bc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132561
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-05  Seth Chaiklin  <sdc.blanco@youmail.dk>  [2ad6a4b547bcb62567836fa1c05f88c0051ac729]

        tdf#148355 improve ToD about hyperlink click options
        
        Change-Id: Ie26d5d35448fc28ae5a77f7be9b95337fc3f83a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132387
        Tested-by: Jenkins
        Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>

2022-04-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b2ad2e29e69fa5b7561f738cc82e49268f2b4ec]

        add some comphelper::string::toInt* functions for string_views
        
        Change-Id: Icf42e00575edf8fc847bccf9c9505cd9710fc9b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132509
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-05  Miklos Vajna  <vmiklos@collabora.com>  [abf73d576c10482a8e22cb0df3ab1520d751cbd7]

        sw: document SwXFieldmark
        
        It's interesting how fieldmarks have an UNO API but they don't have a
        UI.
        
        Change-Id: Icd4c973bf303547b8523d1d0411d21c5273abc8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132528
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-05  László Németh  <nemeth@numbertext.org>  [d4e2ed9324bd736275f07577ba81c974a0a70eb1]

        tdf#148345 sw: reject all tracked row deletion in Hide Changes
        
        In Hide Changes mode, undeleted rows didn't reappear at applying
        Reject All for tracked row deletions.
        
        See also commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes".
        
        Change-Id: I55d76fb0165fefc330934c5a2a6b018904d3a1a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132527
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [684ec4b870ad13b2eff3e10ef429f4e19bb57441]

        Fix typos
        
        Change-Id: I77ad3b01dbb2e8f8438b6f4a30ca2239490fb8f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132537
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [50b56ee25b119fb18480d7c9c670ec3986b725cd]

        Fix typos
        
        Change-Id: Ieb57b614962b398a19d87e0a7427d897b38cf37c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132536
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d48b472372f3d0b04338455ea8615f9af6e29169]

        Removed execution bits on odp file
        
        Change-Id: I32aa1660f4b83b349fd6e231fd08eac36d342973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132534
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [12bb0d897d97c9231e86d6b0071f8a0d29c7e660]

        sc: add SparklineGroup Undo/Redo
        
        As SparklineAttributes are COW, we can just exchange them around
        in the SparklineGroup when undoing and redoing.
        
        This also changes SparklineDialog to work with a local copy of
        SparklineAttributes when editing, or an empty initial copy when
        inserting a new Sparkline into the sheet.
        
        Change-Id: I36e9c887ca640f40266f381e98e57f027a5ca07f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132542
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [574384e90fdb24aed40e0dcffd17adae3443aa04]

        sc: Sparkline rendering improvement, take all attrs. into account
        
        This change moves Sparkline rendering into a new class and into
        a separate file - SparklineRenderer, and improve the rendering by
        taking all the sparkline attributes into account.
        Improvements:
        - render correct line width for lines
        - take hidden cells into account
        - draw the X axis
        - allow to override the min, max values (custom X axis limits)
        - handle empty cells (interpret as zero, as a gap or interpolate)
        - correctly handle first and last value
        - take marker attribute and color into account (missing before)
        - simplify range iteration (with RangeTraverser class)
        - show min, max also for stacked sparkline type
        - ...
        
        Change-Id: Id855f775677aa309b42174e086ad4f5d7de079c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132541
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d97d1f2643d30ebcab149854137cd3c4f46004d2]

        sc: edit all sparkline attributes in SparklineDialog
        
        Change-Id: I6ca9e3436e0dd807b30585576ae2067076c3b7ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132516
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5ff13a0866fe5c408f9e9c7441a9d052b383d99c]

        sc: use GUID for the SparklineGroup ID and use that
        
        This adds tools::Guid as the SparklineGroup ID. At import the
        Guid is parsed by tools::Guid and later it is used to identify
        the SparklineGroup.
        This is useful when copying sparklines so we can preserve to
        which group it belongs, when that is desired.
        
        Change-Id: I4f2b560d5ea74552e8add57bb05469be57cf4a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132515
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Jim Raykowski  <raykowj@gmail.com>  [097bcd530c7facde50c7fe21e1cee9b4bf4a7949]

        tdf#148103 SwNavigator: fix outline levels shown
        
        fixes regression introduced in commit
        3771a81060f9e1f60ada37c3b7fa0a51b3042952
        
        Change-Id: Ie9a839f0de32177f06bd47a204c55b38eb9371f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132533
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c07d2ea9589cf794bd300697e8a40bf9f94a8346]

        sc: make printing of Sparklines work
        
        Sparkline cells don't contain any data, so they would be ignored
        if we don't include them in the function that determine if there
        is any data in a cell or not.
        This is the main reason why the cells weren't drawn when printing
        as they had no data so they were ignored.
        
        Change-Id: I7849f1a00c9421616b8af90bdac368fd63ae1087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132514
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cf4d5ed026c8799a70432a832a8a707c2e316216]

        add tools::Guid class to generate, parse GUID values
        
        Change-Id: Ie4d8fad4d8f22c8277c22c21b7a9eb3e7c9e4f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132513
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [be7d84a3fbd47bf9a078ac7e6854bc4927e84933]

        Fix --disable-scripting build (WASM)
        
        Simply include the global transliterator in all builds.
        
        Regression from commit de81c2545aec06a1b269218b7d00656e97d8b66c
        ("Related: tdf#144245 Optimize case-insensitive handling").
        
        Change-Id: Ica1c6e5d67c8458f9977f2ff87d9594a43b4cff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132517
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [b812150696c574aea0a173d11f178e8d458b1a3e]

        oops, forgot to fix the comment
        
        Change-Id: Ib9281395087c8b21c2693a233d77236f9353e9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132529
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-04  Michael Stahl  <michael.stahl@allotropia.de>  [8fbe27a53c038cd32c45bad1f0b417e79d483185]

        forcepoint#101 sw: fix inserting at-page shapes to not set anchor pos
        
        The problem is that for an at-page anchor SwXDrawPage::add() sets an
        anchor position, but then a fieldmark is inserted and the node with the
        anchor position is deleted.
        
        The code that sets the surprising anchor position for at-page shape was
        added in commit cf345e026fc0378c4436173c8064717c7db4d538 "Fix #91289#:
        Draw objects anchored at page but without page number" and is similar to
        the code for fly-frames added in commit
        2e6d999cf8ceacabb94b11feee6ee0808c2a75bc "If no page number is given for
        page bound frames, calculate it using cursor" except that it is missing
        a check for GetPageNum() == 0, for no obvious reason.
        
        The matching code to replace the anchor position with a page number is
        in SwFlyFrameFormat::MakeFrames() and was added in commit
        572a48cd16f6ce3a68ffead44a975698954dfe11 "Fix #85019#: Insertion of
        flyframes without correct pagenumber"; it's not clear if this is only
        needed for shapes inserted via the above 2 UNO APIs or also for shapes
        inserted via UI.
        
        Then there is the issue that the page number is set in
        XMLTextShapeImportHelper::addShape() only after the shape is inserted,
        which was added and commented in commit
        b5fc47fe5c2892dd712e2bda922656eacbd932f1, earlier than all the above
        commits; testing shows that if the page number is set before inserting
        the shape, the shape ends up on the expected page anyway.
        
        Let's change this:
        1. the page number is set before inserting the shape
        2. at-page anchor with page number is left as is
        3. at-page anchor without page number gets anchor position and is changed
           to at-char
        
        Change-Id: I2f874bec8424de5eee94cf022e3b49382eaa55f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132479
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-04  Regina Henschel  <rb.henschel@t-online.de>  [1ad58c77352e418124387b804b18da2aeea22c8b]

        tdf#100391 calculate true textarea rect for custGeom
        
        Without the fix the attributes for <a:rect> were set to 'l', 't', 'r'
        and 'b'. That means that the textarea rectangle equals the shape
        rectangle. That is the default and works for many shapes. But 'Puzzle'
        has a smaller textarea rectangle, for example.
        
        Because the values in draw:text-areas are relative to the internal
        coordinate system given by draw:viewBox in ODF, but the values in
        <a:rect> are relative to the shape coordinate system in OOXML, we
        cannot simple write the current absolute values but need to calculate
        them depending on actual width and height. For that we need guides.
        
        The patch introduces a guide list. Currently the list contains only the
        guides for the textarea rectangle, but it can be extended when export
        of handles will be implemented one day.
        
        Change-Id: I1050627ef6459ab5f8fafa939d7905122870c903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132489
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-04-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [0225f1dd04e49191bbf1fa787bb15d1617ab996c]

        tdf#85553: subsequent_export_test2: Add unittest
        
        Change-Id: I70f436ec26ae5127869be971a09d8ca119906009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132522
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-04  Miklos Vajna  <vmiklos@collabora.com>  [81bcee9866661ee0558474467d83c0fa929e932c]

        sw lok: fix missing cache invalidation in SwRedlineTable::Insert()
        
        The trouble is that the FillRects() call in
        SwRedlineTable::LOKRedlineNotification() builds a text portion list, but
        that's not yet correct, and later we don't build a text portion list as
        we already have one.
        
        Fix this similar to the frame size problem by invalidating the cache
        after we got our rectangles.
        
        Change-Id: Ida759be418bc3706810d9774e060d06143893bb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132521
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [cec215e0e3adaf26c89c4ffbaa53f87481772f0c]

        tdf#147523 Qt use inner QWidget to set pointer pos
        
        Regression from commit e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d
        ("Qt use asChild for pointer positioning"), which should just have
        been a cleanup for commit ca28826a087245686d7fca3ffc8ca1f03307924d
        ("tdf#131467 Qt set default position on first resize").
        
        And scale the requested position by the device scale factor.
        
        Change-Id: I50b3c628d22896e987d8cc2eaf5635cb12ba3464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132518
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-04-04  Stephan Bergmann  <sbergman@redhat.com>  [88bba21f83ce47a517dabc637fb421ac9bad5416]

        Fix GlobalNamespace check
        
        ...so that e.g. building on F36 with -stdlib=libc++ doesn't fail with
        
        > i18nutil/source/utility/paper.cxx:311:75: error: NullToPointer ValueDependentIsNotNull ZeroLiteral -> nullptr [loplugin:nullptr]
        >         locale_t loc = newlocale(LC_PAPER_MASK, "", static_cast<locale_t>(0));
        >                                                                           ^
        
        when the locale_t typedef declaration is nested in extern "C" (from
        /usr/include/stdlib.h) which in turn is nested in extern "C++" (from LLVM's
        include/c++/v1/math.h)
        
        Change-Id: Ie81d7425cda231954bdbab47c3a0431dc7c27f5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132520
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bd992ae1228b2f7e556f89f95949da0aeade5b91]

        sc: sparkline import/export for ODF
        
        Change-Id: I0d8293cdd35cc8c7afab98efac0a28a3613d122b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132505
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [a52b1610009096c171b7571b9c2e8c307cada90b]

        Resolves: tdf#148336 portion width can be zero
        
        Change-Id: I9dcbf024882a0ca055d1847345ab2b8084d5871d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132510
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [321dac0b80c875247ae064e023d107d3ac1caef3]

        clarify that the link warning is a security relevant one
        
        add a tooltip to the "allow button" about trust and add a help button
        that links to documentation on the risk
        
        Change-Id: I3390c1316d65e1a50c564e11101551a4ed9d6b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132508
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1d25d32b4dcfbc750b8344cd79279aad0d621edf]

        sc: add support for xr2 namespace and read uid of sparkline group
        
        Change-Id: I470819a89338f4fb1d9b2486ffb4d93f8eb42844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132504
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [486fb3494c8b339f4251e4211f1419a0ffac760c]

        sc: add "Edit Sparkline Group" context menu action
        
        This adds a context menu to edit the sparkline group for the
        current selected range (if it contains a sparkline group). This
        reuses the SparklineDialog that is used for inserting a new
        sparkline.
        
        The context menu was rearranged so that all actions for the
        sparklines are in a "Sparklines" submenu.
        
        Change-Id: Ia1a025b7c0bf1849c72fdca77ea2f8dc8860c6ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132503
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [634399594cfd1672caaf412ed4bc945f12aa4913]

        sc: split attrs out of SparklineGroup into a COW class
        
        The attributes can be independent of the actual SparklineGroup,
        so they can be shared through multiple SparklineGroups and with
        the attributes being COW, they can be safely changed without the
        fear that it will impact a different SparklineGroup insstance.
        
        Change-Id: I274b1243d014288ea34a213326ef765ceff86a58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132502
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [1af123a588306419a9d22d6ee31ea8ee5f35a4f7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8dfebaba1d7e2874af4001ce15d807b436891925
          - add a warning about data exfiltration on allowing update of links/webservice
            
            Change-Id: I7c5cbcc7ffbf831d5266df196d56f7940fc7765c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132507
            Tested-by: Jenkins
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2022-04-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5de24375515bc2932d299047e9cb8c9c9bf3ee1d]

        use string_view in comphelper::string::split
        
        Change-Id: I4afe8aee85905ee35ba195b00b454aefa0ba38af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132486
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-04  Tünde Tóth  <toth.tunde@nisz.hu>  [c2e8a96a8107a37901e475c65a8e61211fc3b132]

        tdf#53970 PPTX: fix broken export of linked media files
        
        Missing TargetMode="External" in the export of
        linked media files resulted corrupted PPTX.
        
        Change-Id: I76246db331d199810a5b413d44bec95283e88e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132402
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-04-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c84e166de3ba993eb4d1c01d6b0fbe00d5f6572e]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4f65f25bc54fc4078363522caa2623c5de387c6f
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Iaad2f8d129208996bc1fef023045616b51aeff05
            
2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [ab53399cb80de649eb3752bf8984733c40ba1eba]

        ofz#46332 Invalid-enum-value
        
        Change-Id: I307cd054afc17ea0ec52f5aaccd250fc4a53ed6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [ad352fee880c006a5ca57354b0552bc1f81a28fb]

        ofz: Timeout
        
        Change-Id: Ic0ed98f878883c9e608a69b2735d2ab90e08c651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132499
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [8a13488f19a8be3bdaa58c7a08fbd26ed08e6e29]

        ofz: Invalid-enum-value
        
        Change-Id: I12805bd4cab4f00025aa86eb2fb014dcac5ba56b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132498
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [6905434f40a1b3a58955b3b444d69f239be1b14e]

        ofz#46331 Null-dereference READ
        
        Change-Id: Id03c7fc437d67e01d6a1ec0547b2584396066201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132497
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [602eb74e50685c27f34e6bf64a600519a52105cb]

        cid#1503776 Explicit null dereferenced
        
        Change-Id: I5dbd0529c7fc445c6330d3540c77050ce843d012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132496
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Mike Kaganski  <mike.kaganski@collabora.com>  [de81c2545aec06a1b269218b7d00656e97d8b66c]

        Related: tdf#144245 Optimize case-insensitive handling
        
        1. Make BasicCollection::implGetIndexForName take OUString again,
        after commit f7de7de1189ae4e63f73468076da47b37fe61ede made it take
        std::u16string_view. All call sites pass OUStrings, and commit
        ef32c3b4f9b80918d6018e14297fa41245afd381 made it create OUString
        from the argument.
        2. Have SbxVariable cache a case-insensitive variant of the name.
        It is currently only used in the Collection implementation, but
        may be used in other places; Tthe names are case-insensitive in
        Basic, and VBA allows non-ASCII characters in names, so this
        caching might be useful elsewhere.
        3. Skip non-ASCII characters when calculating name hash, to allow
        non-ASCII-containing strings still have some hash variance, when
        at least some of the first 6 characters are ASCII.
        
        Change-Id: If90ccea2c4b44c34967e6b764b6fab45b2976c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132493
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [af38d84380ee78f61822e8e080a56e955842b71e]

        sc: undo/redo for sparklines when deleting the cell content
        
        This adds support for undo/redo when clearing the content of a
        cell, which includes a sparkline.
        
        Change-Id: I79d9ef965e21cf5b35de84aa3b5cb93b644777ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132476
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [20ed714f87dd22e5f11a65c4208045037dc20017]

        sc: add Undo/Redo for deleting a Sparkline
        
        Adds the code to delete the Sparkline via DocFunc + test.
        
        Change-Id: I710a1ee59a5fe5f2bfb91f8bf487501ef39ce949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132475
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [54536bca332651051dc8a5ba02995c069cb75fd2]

        sc: add Undo/Redo for inserting Sparklines
        
        Move the code to insert a sparkline from the SparklineDialog to
        DocFunc and inside the UndoInsertSparkline, so there is no code
        duplication and the code can be tested.
        
        Change-Id: I85f4020190ae835b33e706ec9cb2cda9fd6fc752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132474
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b8cf500ed8ac7bd01a351e2815ce8251e506d79c]

        sc: add support for copy/cut and paste of Sparklines
        
        Currently cut,copy and paste will copy the Sparkline and create
        a new SparklineGroup for each cell in the new cell range. This
        probably need to be adjusted so the SparklineGroup is shared.
        
        Change-Id: I6f86bb026753b2b4b5bfa46aca4ca9794721f311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132473
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [7ca71fdb06af29429e749a2aa89dff57dd932635]

        forcepoint#103 avoid crash on layout of specific html
        
        return early if the prev frame was unexpectedly deleted
        
        and another similar case to forcepoint#100 and drop a
        SwBorderAttrAccess to allow the cache entry to be removed
        in SwCache::DeleteObj
        
        Change-Id: Ia83fe8911e2f6071a28d69c3089a96e3b87cc548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-04  Miklos Vajna  <vmiklos@collabora.com>  [cb35526e9221d9781abb3cee2ba6971736b6b333]

        sw content controls: include this in the UNO API text portion enum
        
        Which is how UNO API clients (e.g. ODT export) will be able to read
        RES_TXTATR_CONTENTCONTROL.
        
        Change-Id: Idf87312b1b89a0e44e7de2578de44b263fa8689a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132491
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-04  Miklos Vajna  <vmiklos@collabora.com>  [85d5113dc0472f59b60ce34ccf70c21a0edbe097]

        sw: prefix members of SfxDeleteListener, SvtDeleteListener, ...
        
        ... WW8PLCFx_AtnBook and WW8PLCFx_Book
        
        See tdf#94879 for motivation.
        
        Change-Id: I37dfe0e6019b6008be06796a03111f494fa5d300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132490
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-04  Caolán McNamara  <caolanm@redhat.com>  [b46baea4d1cce81c56ee0d82fbdc352921445fa7]

        forcepoint#99 SwTextFormatter unaware that FirstOfBorderMerge was deleted
        
        READ of size 8 at 0x606000a49e50 thread T0
            #0 0x7f7ab6214bf5 in SwPosSize::Height() const /home/caolan/LibreOffice/core-asan/sw/source/core/text/possiz.hxx:49:37
            #1 0x7f7ab636c311 in SwTextFormatter::MergeCharacterBorder(SwLinePortion&, SwLinePortion const*, SwTextFormatInfo&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:2807:43
            #2 0x7f7ab636ae08 in SwTextFormatter::InsertPortion(SwTextFormatInfo&, SwLinePortion*) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:354:13
            #3 0x7f7ab6371db1 in SwTextFormatter::BuildPortions(SwTextFormatInfo&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:709:9
            #4 0x7f7ab638b2ac in SwTextFormatter::FormatLine(o3tl::strong_int<int, Tag_TextFrameIndex>) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:1701:9
            #5 0x7f7ab62a8ad1 in SwTextFrame::FormatLine(SwTextFormatter&, bool) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1212:44
            #6 0x7f7ab62af1cc in SwTextFrame::Format_(SwTextFormatter&, SwTextFormatInfo&, bool) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1571:23
            #7 0x7f7ab62b1f17 in SwTextFrame::Format_(OutputDevice*, SwParaPortion*) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1743:5
            #8 0x7f7ab62b5260 in SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1932:17
            #9 0x7f7ab5dbdabd in SwContentFrame::MakeAll(OutputDevice*) /home/caolan/LibreOffice/core-asan/sw/source/core/layout/calcmove.cxx:1514:17
        
        0x606000a49e50 is located 16 bytes inside of 56-byte region [0x606000a49e40,0x606000a49e78)
        freed by thread T0 here:
            #0 0x4fe1f7 in operator delete(void*) (/home/caolan/LibreOffice/core-asan/instdir/program/soffice.bin+0x4fe1f7)
            #1 0x7f7ab6486d35 in SwTextPortion::~SwTextPortion() /home/caolan/LibreOffice/core-asan/sw/source/core/text/portxt.hxx:26:7
            #2 0x7f7ab63da0c9 in SwLineLayout::CalcLine(SwTextFormatter&, SwTextFormatInfo&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/porlay.cxx:430:21
            #3 0x7f7ab6435413 in SwMultiPortion::CalcSize(SwTextFormatter&, SwTextFormatInfo&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/pormulti.cxx:75:15
            #4 0x7f7ab6457749 in SwTextFormatter::BuildMultiPortion(SwTextFormatInfo&, SwMultiPortion&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/pormulti.cxx:2090:16
            #5 0x7f7ab636f12c in SwTextFormatter::BuildPortions(SwTextFormatInfo&) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:550:21
            #6 0x7f7ab638b2ac in SwTextFormatter::FormatLine(o3tl::strong_int<int, Tag_TextFrameIndex>) /home/caolan/LibreOffice/core-asan/sw/source/core/text/itrform2.cxx:1701:9
            #7 0x7f7ab62a8ad1 in SwTextFrame::FormatLine(SwTextFormatter&, bool) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1212:44
            #8 0x7f7ab62af1cc in SwTextFrame::Format_(SwTextFormatter&, SwTextFormatInfo&, bool) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1571:23
            #9 0x7f7ab62b1f17 in SwTextFrame::Format_(OutputDevice*, SwParaPortion*) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1743:5
            #10 0x7f7ab62b5260 in SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) /home/caolan/LibreOffice/core-asan/sw/source/core/text/frmform.cxx:1932:17
            #11 0x7f7ab5dbdabd in SwContentFrame::MakeAll(OutputDevice*) /home/caolan/LibreOffice/core-asan/sw/source/core/layout/calcmove.cxx:1514:17
        
        similar seen in the past as:
        
        commit 96acebb72211b4718eb3038c427df37b55b17b0b
        Date:   Tue May 14 01:49:03 2019 +0800
        
            tdf#124937 reset m_pFirstOfBorderMerge before truncate.
        
        commit ecd855794b22c0f7e6fb2f362b566c4d9c5f624a
        Date:   Mon Jan 15 22:29:31 2018 +0100
        
            tdf#114536 sw: fix use-after-free in SwTextFormatter::MergeCharacterBorder()
        
        Change-Id: Iad855f382a0daf50dac2537d4a91bfeaa9ff3799
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132439
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [413f144e84629fe8f3bae5d984b40228fdeec5c1]

        sc: change GetSparkline to return a shared_ptr instead of raw ptr
        
        Change-Id: If3d7b3ad4b96eb7d3b126ee8b130f8d5e684cd3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132472
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-04  László Németh  <nemeth@numbertext.org>  [d925d1ca9e03863650dd3e450331598624f21724]

        tdf#147546 bump libnumbertext to 1.0.10
        
        fixing only regression of hu_Hung
        transliteration of punctuation marks.
        Add unit test for the fix.
        
        Regression from commit 98fd4fcdc61202846e0957cb6aaed9e4a2d2c520
        "tdf#136368 bump to libnumbertext 1.0.8".
        
        Change-Id: I7b49467943c97582dba0e5aca20c02a92c43deff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132395
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-03  Jim Raykowski  <raykowj@gmail.com>  [2d6af46a82c6b9f1565933e8a1175e7a184256ca]

        tdf#147925 fix view scrolling back to comment
        
        fixes regression caused by fix done for commit
        85057da7f19e8e5d6023c16fa07d138e2b519a66
        
        Change-Id: I427513bd920f4e0047c64210feecfeac22ecfd10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132451
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-04-03  Mike Kaganski  <mike.kaganski@collabora.com>  [1ea95f05ee8ec496c628bd11750d23cc012c7fe4]

        tdf#148338: allow single-letter lowest-level domain
        
        The check that required lowest-level domain name to be at least
        two characters long, was introduced for #i25107# in 2004 in the
        commit dfcb4aa47b81ebd9affddefda88bf9b451508221
          Author Rüdiger Timm <rt@openoffice.org>
          Date   Mon Sep 20 12:13:22 2004 +0000
            INTEGRATION: CWS swmailmerge (1.1.2); FILE ADDED
        
        (See also related #i20057# for feature specification.)
        It didn't mention a rationale behind that check; but obviously,
        it's unjustified. There are single-letter second-level domain
        names [1], like 'x.com', and also under many other TLDs. Also
        the check prevented single-character third-level names like
        "a.foo.bar", etc. Plus, RFC 5322 (and its predecessors) do not
        restrict these lengths in 'Addr-Spec Specification' (and RFCs
        referenced from there).
        
        This does not enable dotless domains [2]; if justified, they
        should be enabled separately.
        
        [1] https://en.wikipedia.org/wiki/Single-letter_second-level_domain
        [2] https://en.wikipedia.org/wiki/Top-level_domain#Dotless_domains
        
        Change-Id: I03cc26a90c08b94b9c1f70e0a0f1746192cb7afe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132482
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-03  Caolán McNamara  <caolanm@redhat.com>  [f49d218a671df5f7a956ccb219dc46a5c8d0a53c]

        forcepoint#102 refetch pPara if it might have been destroyed
        
        by SwTextFly::Relax
        
        READ of size 8 at 0x616006d9ab08 thread T0
            #0 0x7f5c56a0fbe5 in Size::Height() const include/tools/gen.hxx:213:52
            #1 0x7f5c56a0fb98 in Size::getHeight() const include/tools/gen.hxx:219:55
            #2 0x7f5c56a040f0 in SwRect::IsEmpty() const sw/inc/swrect.hxx:306:21
            #3 0x7f5c56dbb018 in SwRect::HasArea() const sw/inc/swrect.hxx:302:13
            #4 0x7f5c58571d04 in SwTextFrame::Prepare(PrepareHint, void const*, bool) sw/source/core/text/txtfrm.cxx:2986:45
        
        0x616006d9ab08 is located 136 bytes inside of 608-byte region [0x616006d9aa80,0x616006d9ace0)
        freed by thread T0 here:
            #0 0x4fe1f7 in operator delete(void*) (instdir/program/soffice.bin+0x4fe1f7)
            #1 0x7f5c584602c5 in SwParaPortion::~SwParaPortion() sw/source/core/text/porlay.cxx:2557:1
            #2 0x7f5c5850b997 in std::default_delete<SwParaPortion>::operator()(SwParaPortion*) const /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/unique_ptr.h:85:2
            #3 0x7f5c5850b826 in std::__uniq_ptr_impl<SwParaPortion, std::default_delete<SwParaPortion> >::reset(SwParaPortion*) /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/unique_ptr.h:182:4
            #4 0x7f5c5850b630 in std::unique_ptr<SwParaPortion, std::default_delete<SwParaPortion> >::reset(SwParaPortion*) /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/bits/unique_ptr.h:456:7
            #5 0x7f5c5850960d in SwTextLine::SetPara(SwParaPortion*, bool) sw/source/core/text/txtcache.hxx:45:17
            #6 0x7f5c58509e7d in SwTextFrame::ClearPara() sw/source/core/text/txtcache.cxx:113:24
            #7 0x7f5c5855606e in SwTextFrame::Init() sw/source/core/text/txtfrm.cxx:758:9
            #8 0x7f5c585735c4 in SwTextFrame::Prepare(PrepareHint, void const*, bool) sw/source/core/text/txtfrm.cxx:3090:17
            #9 0x7f5c57ecafb4 in lcl_NotifyContent(SdrObject const*, SwContentFrame*, SwRect const&, PrepareHint) sw/source/core/layout/frmtool.cxx:3367:15
            #10 0x7f5c57ec968b in Notify_Background(SdrObject const*, SwPageFrame*, SwRect const&, PrepareHint, bool) sw/source/core/layout/frmtool.cxx:3443:9
            #11 0x7f5c57958669 in lcl_NotifyBackgroundOfObj(SwDrawContact const&, SdrObject const&, tools::Rectangle const*) sw/source/core/draw/dcontact.cxx:951:13
            #12 0x7f5c579556bc in SwDrawContact::Changed_(SdrObject const&, SdrUserCallType, tools::Rectangle const*) sw/source/core/draw/dcontact.cxx:1233:21
            #13 0x7f5c57953b8d in SwDrawContact::Changed(SdrObject const&, SdrUserCallType, tools::Rectangle const&) sw/source/core/draw/dcontact.cxx:1009:5
            #14 0x7f5c96008baf in SdrObject::SendUserCall(SdrUserCallType, tools::Rectangle const&) const svx/source/svdraw/svdobj.cxx:2767:22
            #15 0x7f5c9601befa in SdrObject::Resize(Point const&, Fraction const&, Fraction const&, bool) svx/source/svdraw/svdobj.cxx:1561:5
            #16 0x7f5c57da650c in SwAnchoredDrawObject::GetObjBoundRect() const sw/source/core/layout/anchoreddrawobject.cxx:733:22
            #17 0x7f5c57dae236 in SwAnchoredObject::GetObjRectWithSpaces() const sw/source/core/layout/anchoredobject.cxx:569:31
            #18 0x7f5c5853c39e in SwTextFly::InitAnchoredObjList() sw/source/core/text/txtfly.cxx:900:48
            #19 0x7f5c58537b0c in SwTextFly::GetAnchoredObjList() const sw/source/core/inc/txtfly.hxx:311:44
            #20 0x7f5c58532a5d in SwTextFly::ForEach(SwRect const&, SwRect*, bool) const sw/source/core/text/txtfly.cxx:1067:56
            #21 0x7f5c58533eec in SwTextFly::IsAnyFrame() const sw/source/core/text/txtfly.cxx:405:12
            #22 0x7f5c5832ccbe in SwTextFly::Relax() sw/source/core/inc/txtfly.hxx:337:17
            #23 0x7f5c58571af5 in SwTextFrame::Prepare(PrepareHint, void const*, bool) sw/source/core/text/txtfrm.cxx:2976:48
        
        Change-Id: Ibd0d4af69d2a8d74ad538afba7da53c864fa27b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-03  Caolán McNamara  <caolanm@redhat.com>  [24eb8731513e5a8b0b761cbd0dabd71ea7038c2d]

        cid#1503360 Dereference null return value
        
        Change-Id: I5c25149a9c2ec2938754de7f79991c93c741e914
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-03  Caolán McNamara  <caolanm@redhat.com>  [88f81a8df7483169592d106e4007d8810cb6ccfc]

        cid#1503358 silence Unchecked return value
        
        and
        
        cid#1503359 Unchecked return value
        
        Change-Id: I12e1a3501674c8d99a705e3a84aa9afe7b8b0754
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132477
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [05032132786b8dfc5cfda6b782acf85cb4d39be9]

        sc: make getters const in SparklineCell and Sparkline classes
        
        Change-Id: Ia0bc1d4bd7da834da3640f34bfdb744dd2ddeba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132471
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cbd4e2852545b5f67896dc9062ddda4d5744f751]

        sc: add unit test to delete Sparkline, update add Sparkline test
        
        Change-Id: Ib0e60ea5aa246b29a06ae90be2cb4b905722b1a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132469
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Julien Nabet  <serval2412@yahoo.fr>  [c6b15cdf99a84808f0747ac11127c4f3997f2600]

        cid#1503361: Incorrect expression  (USELESS_CALL)
        
        Since 5da08b21cd23f2e70f5003733b03a7aee7915225
        sw content controls: add UNO API to insert this with custom props
        
        Change-Id: Id1ebcbe99df9a4d3a06b6714a471a686602f15ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132470
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-03  Caolán McNamara  <caolanm@redhat.com>  [3644508aceee6019842bea1fee6c177eabd61681]

        forcepoint#98 don't delete SwFrame flagged as IsDeleteForbidden
        
        Change-Id: I1ac2db4bf96afc4bdc8e0646576f5fa0bcd9e410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-03  Caolán McNamara  <caolanm@redhat.com>  [1015359b5f4d01e2a423cbed7b155412d3f6db66]

        Related: forcepoint#100 don't reacquire after every release
        
        instead release when we have to, and only reacquire if necessary
        before use of pAttrs
        
        Change-Id: I9c413fc479cf73c771e8349fe5e853a4eac72110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132463
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-03  offtkp  <parisoplop@gmail.com>  [6bc187b2eb6b9520c942f232b1abcb4fb29bfa04]

        tdf#147132 Flatten Basic function implementations
        
        Change-Id: I21b0ec23de99aaf9b4398d59a5cc56d7d386ad58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132444
        Tested-by: Jenkins
        Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [84dfdac1f7139337e61288af0e75aef66c19b29a]

        sc: add "Delete Sparkline" context menu command
        
        Change-Id: I0e2bf2172da3cbba391ca64c93fad6bccd82f3ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132468
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e1e0af376d45f44dab975cea943de7fb676f967]

        loplugin:stringviewparam convert methods using match
        
        which converts to a combination of substr and o3tl::starts_with
        
        Change-Id: I5b01a181b9e6bee3483e4f49f1a9426abcc682d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [744722123a8ce3d3c30583ba1285a21e129b471f]

        sc: support deleting a Sparkline with 'Clear Content' function
        
        Change-Id: Ida61b402170238fb0505c777e49954c15d376cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132467
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [602f653a65f432e5f75acef8fef21189392a05e1]

        sc: SparklineDialog add type, colors and properties
        
        Change-Id: Ie8243985d61cc719fd0444b0e1aaf18f43489d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132466
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c61aa2dea120cc083f3cd51f0347284f47a9d566]

        sc: SparklineDialog and "Insert Sparkline" to context menu
        
        This adds a SparklineDialog, which is used to add/edit the
        Sparkline input/output ranges. The command for the context menu
        "Insert Sparkline" calls the SparklineDialog for inserting a new
        sparkline into cells. Currently the SparklineDialog include the
        properties for the SparklineGroup, which will be added in a later
        commit.
        
        Change-Id: I9036d788fdf2a035f1ce10fc7413327a92144137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132465
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-03  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ca5f7efcd92c8bdf36bf64f0c78fd2e112206cfc]

        Colibre: Update dark Send as Fax & Explorer On/Off icons
        
        Change-Id: If0dfccdafb14aebb0f01354259c1c9b1591160a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132450
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-04-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b1349537f936dc1053e623b333c9c8f57345b8ff]

        sc: simple unit test for adding a new Sparkline to a new document
        
        Change-Id: Ifb42167300dadd0e6c48bf178b7e8902985db3d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132464
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-02  Gabor Kelemen  <kelemeng@ubuntu.com>  [52ef78f4923283e6e52d575bec81985b031cb30b]

        Recheck modules t* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I109fa07d52721fd10354de07a2ed995ffa2f27c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132369
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-04-02  Caolán McNamara  <caolanm@redhat.com>  [f628a7dbae3f74eb1c0823f0fac79ee64f5a4952]

        forcepoint#100 drop SwBorderAttrAccess to allow cache entry to be removed
        
        for SwBorderAttr which gets deleted during this call
        
        Change-Id: Ie52aab7e5933d76b0c055389798104e4d93f39e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-02  Caolán McNamara  <caolanm@redhat.com>  [cf01ebf64634a014ca73bb7c042f6516123ae4eb]

        Related: forcepoint#100 we don't need pAttrs for the duration of the full scope
        
        similar to the case of
        
        commit 6b1eae0334ba8bad7656a859695551ce51b62f95
        Date:   Fri May 18 08:26:14 2001 +0000
        
            Fix #87058#: Locked boraderattribut
        
        the SwCache object cannot be deleted if its locked, leading to a leak,
        we don't need pAttrs for the entire scope here so we can defer to the
        end of the scope the reacquire the lock to set pAttrs
        
        Change-Id: I430331868b977e57121e968425a2377b395ea7eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132459
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-02  Noel Grandin  <noelgrandin@gmail.com>  [496ad6ad023229377476cf84eb243d2e669ae3d0]

        use more string_view
        
        Change-Id: I8be5ab687c2fe039e0a48d505b615f7cb88b633d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132454
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c898611bd56a2ea090b2eb46f4d7bd4dd57594a7]

        loplugin:stringviewparam convert methods using compareTo
        
        which converts to compare
        
        Change-Id: If03c790ea113a7caedbe89f926b29055c9ec1e76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-02  Stephan Bergmann  <sbergman@redhat.com>  [12f94913307450aad0e48f6ce06aac9f74807e1a]

        CppunitTest_sc_sparkline_test also needs the ASan hack
        
        ...from e854abe076155fc085b56549ced50b3ee9a095d2 "Avoid external processes
        picking up instdir/program/libnspr4.so", to avoid
        
        > Test name: SparklineImportExportTest::testSparklines
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 32512
        > - failed to execute: sh .../bin/officeotron.sh .../tmp/SparklineImportExportTest__testSparklines_230wbj.tmp > .../tmp/SparklineImportExportTest__testSparklines_230wbn.tmp 2>&1
        > java: symbol lookup error: .../instdir/program/libnspr4.so: undefined symbol: __asan_init
        
        Change-Id: Icb710014278c0e38ec60a075d145b0174404ef2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132452
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [1927b51993fb68907a75765676179b08ab195196]

        loplugin:stringviewparam convert methods using indexOf
        
        .. and lastIndexOf, which convert to find and rfind
        
        Change-Id: I6c4156cf904774c0d867f85a4c2785dba7593f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132445
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0dfa444f393a5766d36fe7d2480d0c8ec832e329]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9fcf9e1c710086a70bdd339ca60baead658a2cda
          - Add information on Writer manual row break
            
            Change-Id: Idf7f468173e3b26c6738d3750bb27496bae47b77
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132441
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-02  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a3b141624930b6eb96b3273fee8396476db6d116]

        Colibre: Update dark Save As Template icons
        
        Change-Id: Iac2b5497feb763ae27b543365ce63d5432002dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132449
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-04-02  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [3f15a310ff4f13cd9e26d442a82f091176e3583c]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes
        
        Change-Id: Ia938d9e7aaef08052a722c118e7b805d8986dd37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132448
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-04-01  Stephan Bergmann  <sbergman@redhat.com>  [5cb3a31ff0fb17ee75c4a8ce6c79ae6c39d0954f]

        UBSan needs some more RTTI during CppunitTest_sw_core_unocore now
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so
        > LinkTarget/CppunitTest/libtest_sw_core_unocore.so: undefined symbol: _ZTI22SwFormatContentControl"
        
        and
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so
        > workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so: undefined symbol: _ZTI16SwContentControl"
        
        presumably since 5da08b21cd23f2e70f5003733b03a7aee7915225 "sw content controls:
        add UNO API to insert this with custom props"
        
        Change-Id: I77370f11766456081827257d688490ff6e138cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132447
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-01  Michael Stahl  <michael.stahl@allotropia.de>  [784ed64ff50bad19ab3edeefaf336a85594bddaa]

        forcepoint#96 sw: delete fieldmarks in DelFullPara()
        
        The problem is that CorrAbs() will move any position of a fieldmark
        that's in the deleted SwTextNodes to a different node that doesn't have
        the CH_TXT_ATR_FIELD*.
        
        Then it will inevitably crash later when it can't find its chars.
        
        The other problem is that if there's only a CH_TXT_ATR_FIELDSEP in the
        deleted nodes, that fieldmark would then be missing it.
        
        Just delete fieldmarks with positions in deleted nodes, that should work
        fine for the usual cases where DelFullPara() is called.
        
        Change-Id: I8dfac9a315d74025dbe1ed5ccb95b7c9121fb569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132422
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-01  Caolán McNamara  <caolanm@redhat.com>  [74a12d9710ba1a9855c6afb18055152120148833]

        ofz#45529 Timeout
        
        Change-Id: I232d3c07623c7efbc7b0b910298bd77bf469a38b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132442
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-01  Caolán McNamara  <caolanm@redhat.com>  [cd91de9d23106ad5170bb83ce71b74342b42d02f]

        ofz: Invalid-enum-value
        
        Change-Id: I315223371d3b52981a0db109933f3a0e93903980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-01  Julien Nabet  <serval2412@yahoo.fr>  [da81a880df76bebb6d9fbc770c313381a3c33268]

        tdf#148310: Firebird: copy complete rows, CLOB field, last character lost
        
        off by 1 pb.
        
        Indeed we got:
        610     sal_Int64 nCharWritten = 1; // XClob is indexed from 1
        offapi/com/sun/star/sdbc/XClob.idl indeed indicates:
            114         The substring begins at position <code>pos</code> and has up
            115         to
            116         <code>length</code>
            117         consecutive characters.
            118         </p>
            119         @param pos
            120             the starting position, 1-based
            121         @param length
            122             the length of the substring
            123         @returns
            124             the substring
            125         @throws SQLException
            126             if a database access error occurs.
            127      */
            128     string getSubString([in]hyper pos, [in]long length) raises (SQLException);
        
        but if the string to copy has length 1, we never enter:
        while ( nLen > nCharWritten )
        => we must change this into: while ( nLen >= nCharWritten )
        also number of remaining characters to take into account at each loop must be adapted too:
        sal_Int64 nCharRemain = nLen - nCharWritten;  => would be 0
        into:
        sal_Int64 nCharRemain = nLen - nCharWritten + 1;
        
        Change-Id: I7697c8312024818f73a19c39f694cf209f494d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132443
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ed2457a089ae78b54f82c1fae07d54777dda3ca]

        uitest: sw: Deselect regexp checkbox after using it
        
        Otherwise, this is saved and it might affects other tests
        
        Change-Id: I326fd16ee87f49154acf952fe4d36616581a1cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132432
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Alain Romedenne  <alain.romedenne@libreoffice.org>  [43216ed5ddb6d8dc38d505cb63ca9b894be5f2c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6bc28e0b9909efc3052105193564ec4161954d60
          - Some SF services lack pre-requisite note
            
            Change-Id: Idfd233430aabb5815f1f1db625ca48fd2e613b15
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131873
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-04-01  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [f26ba7f7c951164cc8677e55fa73081e16659147]

        tdf#147818 EMF+ Fix restoring clipping states
        
        With previous implementation the clipping restoring with EmfPlusRecordTypeRestore
        was implemented wrongly as it is only taken to account
        the shape of clipping (state.getClipPolyPolygon) and doesn't
        take if clipping was even enabled (state.getClipPolyPolygonActive).
        
        Additionally the changing states should be made by using method:
        wmfemfhelper::HandleNewClipRegion() and not directly.
        
        The similar implementation was applied also to EmfPlusRecordTypeGetDC.
        
        Additionally the clipping for
           EmfPlusRecordTypeSetClipRect
           EmfPlusRecordTypeSetClipPath
           EmfPlusRecordTypeSetClipRegion
        was fixed, as initially the clipping is disabled (state.getClipPolyPolygonActive)
        and the clipping shape is empty (state.getClipPolyPolygon).
        It means that combination other than EmfPlusCombineModeReplace,
        was not working correctly.
        
        With this implementation, if Clipping is disabled, then treat clip combining
        in special way.
        
        Change-Id: I258bda64e8bfdade7f47ffc7518bf04b7340344f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132415
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-04-01  Stephan Bergmann  <sbergman@redhat.com>  [b3b18ed165b7bab80e15f130fe7826595460539c]

        Don't make UNO calls from PyThreadAttached regions (i.e., with the GIL locked)
        
        ...which caused e.g. UITest_writer_tests3 to occasionally hang with the
        python.bin process thread 1 at
        
        >   File "sw/qa/uitest/writer_tests3/insertPageFooter.py", line 30, in delete_footer
        [...]
        
        i.e.,
        
        > #4  ___pthread_cond_wait at /usr/src/debug/glibc-2.35-4.fc36.x86_64/nptl/pthread_cond_wait.c:618
        > #5  0x00007ff9d6ad9c43 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:72
        > #6  0x00007ff9d6ae8e79 in cppu_threadpool::ThreadPool::enter(rtl::ByteSequence const&, void const*) at cppu/source/threadpool/threadpool.cxx:303
        > #7  0x00007ff9d6ae9278 in uno_threadpool_enter(uno_ThreadPool, void**) at cppu/source/threadpool/threadpool.cxx:407
        > #8  0x00007ff9c7d016eb in binaryurp::Bridge::makeCall(rtl::OUString const&, com::sun::star::uno::TypeDescription const&, bool, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >&&, binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) at binaryurp/source/bridge.cxx:604
        > #9  0x00007ff9c7d322fc in binaryurp::Proxy::do_dispatch_throw(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const at binaryurp/source/proxy.cxx:168
        > #10 0x00007ff9c7d338cb in binaryurp::Proxy::do_dispatch(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const at binaryurp/source/proxy.cxx:101
        > #11 0x00007ff9d63222e0 in cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, typelib_TypeDescription const*, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void**, void**, void**, sal_uInt64*) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191
        > #12 0x00007ff9d6322b59 in cpp_vtable_call(sal_Int32, sal_Int32, void**, void**, void**, sal_uInt64*) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389
        > #13 0x00007ff9d63336ca in privateSnippetExecutor at instdir/program/libgcc3_uno.so
        > #14 0x00007ff9d6241f38 in (anonymous namespace)::ImplIntrospectionAccess::hasByName(rtl::OUString const&) at stoc/source/inspect/introspection.cxx:1114
        > #15 0x00007ff9d6b856b2 in pyuno::PyUNO_getattr(PyObject*, char*) at pyuno/source/module/pyuno.cxx:1392
        [...]
        
        doing a remote call to soffice.bin with GIL locked, and thread 4 at
        
        > #6  0x00007ff9e51efa28 in take_gil at workdir/UnpackedTarball/python3/Python/ceval_gil.h:207
        > #7  0x00007ff9e51f00d3 in PyEval_AcquireThread at workdir/UnpackedTarball/python3/Python/ceval.c:316
        > #8  0x00007ff9d6b9b1e8 in pyuno::Adapter::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) at pyuno/source/module/pyuno_adapter.cxx:181
        > #9  0x00007ff9d632b3e4 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
        > #10 0x00007ff9d632a4f1 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
        > #11 0x00007ff9d632a9e6 in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
        > #12 0x00007ff9d621384a in stoc_invadp::(anonymous namespace)::AdapterImpl::invoke at stoc/source/invocation_adapterfactory/iafactory.cxx:457
        > #13 stoc_invadp::adapter_dispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**) at stoc/source/invocation_adapterfactory/iafactory.cxx:605
        > #14 0x00007ff9c7d1a7db in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at include/typelib/typedescription.hxx:155
        > #15 0x00007ff9c7d1d65f in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:78
        > #16 0x00007ff9c7d33ad3 in binaryurp::(anonymous namespace)::request(void*) at ~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:172
        > #17 0x00007ff9d6ad9e1b in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100
        > #18 0x00007ff9d6adbb80 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:164
        [...]
        
        processing an unrelated incoming call from soffice.bin and blocked trying to
        lock the GIL.  (The reason that thread 1 doesn't make progress is that the
        soffice.bin process is also blocking with thread 6 at
        
        > #8  osl::Guard<comphelper::SolarMutex>::Guard(comphelper::SolarMutex&) at include/osl/mutex.hxx:142
        > #9  SolarMutexGuard::SolarMutexGuard() at include/vcl/svapp.hxx:1368
        > #10 sw::(anonymous namespace)::XStyleFamily::hasByName(rtl::OUString const&) at sw/source/core/unocore/unostyle.cxx:923
        > #11 0x00007f089d3d53e4 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
        > #12 0x00007f089d3d44f1 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
        > #13 0x00007f089d3d49e6 in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
        > #14 0x00007f089c1be7db in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at include/typelib/typedescription.hxx:155
        > #15 0x00007f089c1c165f in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:78
        > #16 0x00007f089c1d7ad3 in binaryurp::(anonymous namespace)::request(void*) at ~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:172
        > #17 0x00007f08a18ade1b in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100
        > #18 0x00007f08a18afb80 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:164
        [...]
        
        processing the incoming call from python.bin thread 1 and blocked trying to lock
        the SolarMutex, while thread 1 at
        
        > #4  ___pthread_cond_wait at /usr/src/debug/glibc-2.35-4.fc36.x86_64/nptl/pthread_cond_wait.c:618
        > #5  0x00007f08a18adc43 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:72
        > #6  0x00007f08a18bce79 in cppu_threadpool::ThreadPool::enter(rtl::ByteSequence const&, void const*) at cppu/source/threadpool/threadpool.cxx:303
        > #7  0x00007f08a18bd278 in uno_threadpool_enter(uno_ThreadPool, void**) at cppu/source/threadpool/threadpool.cxx:407
        > #8  0x00007f089c1a56eb in binaryurp::Bridge::makeCall(rtl::OUString const&, com::sun::star::uno::TypeDescription const&, bool, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >&&, binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) at binaryurp/source/bridge.cxx:604
        > #9  0x00007f089c1d62fc in binaryurp::Proxy::do_dispatch_throw(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const at binaryurp/source/proxy.cxx:168
        > #10 0x00007f089c1d78cb in binaryurp::Proxy::do_dispatch(_typelib_TypeDescription const*, void*, void**, _uno_Any**) const at binaryurp/source/proxy.cxx:101
        > #11 0x00007f089d3cc2e0 in cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, typelib_TypeDescription const*, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void**, void**, void**, sal_uInt64*) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191
        > #12 0x00007f089d3ccb59 in cpp_vtable_call(sal_Int32, sal_Int32, void**, void**, void**, sal_uInt64*) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389
        > #13 0x00007f089d3dd6ca in privateSnippetExecutor at instdir/program/libgcc3_uno.so
        > #14 0x00007f08a6b5d170 in operator() at sfx2/source/notify/globalevents.cxx:491
        > #15 comphelper::OInterfaceContainerHelper4<com::sun::star::document::XDocumentEventListener>::forEach<(anonymous namespace)::SfxGlobalEvents_Impl::implts_notifyListener(const com::sun::star::document::DocumentEvent&)::<lambda(const com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener>&)> > at include/comphelper/interfacecontainer4.hxx:285
        > #16 at sfx2/source/notify/globalevents.cxx:488
        > #17 0x00007f08a6b04c8b in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator() (listener=Python Exception <class 'gdb.error'>: Dwarf Error: Cannot find DIE at 0x0 referenced in module instdir/program/libmergedlo.so
        > #18 comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, at include/comphelper/interfacecontainer2.hxx:271
        > #19 SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&, com::sun::star::uno::Any const&) at sfx2/source/doc/sfxbasemodel.cxx:3253
        > #20 0x00007f08a6b066fe in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) at sfx2/source/doc/sfxbasemodel.cxx:2902
        > #21 0x00007f08a6f15def in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:39
        > #22 0x00007f087d640650 in SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) at sw/source/core/layout/layact.cxx:2389
        > #23 0x00007f087dc0832b in SwViewShell::LayoutIdle() at sw/source/core/view/viewsh.cxx:821
        > #24 0x00007f087d2ba194 in sw::DocumentTimerManager::DoIdleJobs(Timer*) at sw/source/core/inc/rootfrm.hxx:206
        > #25 0x00007f08a89fbd26 in Scheduler::CallbackTaskScheduling() at vcl/source/app/scheduler.cxx:472
        > #26 0x00007f08a8ca8780 in SalTimer::CallCallback() at vcl/inc/saltimer.hxx:54
        > #27 SvpSalInstance::CheckTimeout(bool) at vcl/headless/svpinst.cxx:212
        > #28 0x00007f08a8ca99bd in SvpSalInstance::ImplYield(bool, bool) at vcl/headless/svpinst.cxx:452
        > #29 0x00007f08a8ca9db1 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:524
        > #30 0x00007f08a8a27d4c in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:474
        > #31 0x00007f08a8a28445 in Application::Execute() at vcl/source/app/svapp.cxx:452
        [...]
        
        is doing the remote call to python.bin thread 4 with the SolarMutex erroneously
        locked.  But lets concentrate on just fixing the python.bin deadlock in this
        commit.)
        
        The PyThreadDetach antiguard just covering the xInvocation->getValue call in the
        "or a property" case had been added with
        e0a1cd4dc7202795e4a60c73ea1608d86984add7 "fixed a deadlock", presumably without
        taking into account that the xInvocation->hasMethod/hasProperty calls are
        equally problematic.
        
        Change-Id: I2483949df8213c3397a674be190224ee58c95c02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132428
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [93c1241eec9f5df84a96c57f8050efd4851cb0df]

        tdf#129629: sc: Add UItest
        
        Change-Id: I7da58c9f8da83676d68d74ef8d98606d462c9ea5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132427
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Stephan Bergmann  <sbergman@redhat.com>  [8ffcc3832ed4685af7211c9c3398c854fcf411ed]

        Use some more string_view
        
        Change-Id: I630c573eedfcc9d8678fda0466ddcc1902fac0f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132417
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e928ff9e66adc556fe998116be46710270aad48]

        uitest: sc: Deselect regexp checkbox after using it
        
        Otherwise, this is saved and it might affect other tests
        
        Change-Id: I866472d79ee98cb301c1fc61aa97720849d5d116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132426
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [d53aceb08cc443221b13446c3cc064ae7172b9eb]

        uitest: sc: by default calcsearchin is Formulas
        
        Change-Id: If1fbe328a4e89f3e0453c4248b2a516fe038bf71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132421
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c40b2be6a31444bec266ccd3dd5ef87152fad4d]

        tdf#65334: sc: Add UItest
        
        Change-Id: Icf2852a2fdc2c042cc9701e46135a8e0bf6aeb1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132420
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [1403a335b43089af7ed25fc67bd44df932dc9611]

        uitest: add wrapper for VclExpander
        
        Change-Id: I725c51fdddea9da9aa79d166d747261e80ca9376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132416
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-04-01  Jean-Pierre Ledure  <jp@ledure.be>  [7c8e9db0e488606baa27a654769a3906f35cc8cd]

        ScriptForge - (SF_Dialog) new Resize() and Center() methods
        
        The "dialog" service receives 2 new methods for easy
        move/resize of the concerned dialog.
        
        Resize(left, top, widt, height)
          Move the topleft corner of a dialog to new coordinates and/or modify its dimensions
          All distances are expressed in 1/100th mm
          Without arguments, the method resets the initial width and height
        
        Center(window)
          Center the actual dialog instance in the middle of a parent window
          Without arguments, the method centers the dialog
            in the middle of the active window
          The Parent argument can be either
            - a ScriptForge dialog object
            - a ScriptForge document (Calc, Base, ...) object
        
        Both methods are available from Basic and Python user scripts
        
        Change-Id: Ic3680739c9d518da3d76d3588943ae5ce6bad8ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132418
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-04-01  Caolán McNamara  <caolanm@redhat.com>  [ede4b852cd183a93161a4a154865793317d9b452]

        Related: tdf147485 add forcepoint test-case for duplicate issue
        
        Change-Id: I5e80eb62f9ca36a972894f536e3b77b6853bd3fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-04-01  Julien Nabet  <serval2412@yahoo.fr>  [66b86ed0b75690b8c52d5bad2e6db90246a08cf9]

        Remove useless connectivity/source/drivers/mysqlc/DataAccess.xcu
        
        Perhaps it's a temporary scaffolding during implementation of mysql native connector.
        I mean the only commit is 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 (2018-08-16):
        "
        Moving mysqlc into connectivity as a library
        
        Additionally I erased the remains of the old mysql C++ connector.
        
        Also update the code where the clang plugins were unhappy after moving
        the mysqlc module.
        
        Remove mysql-cpp-connector external.
        "
        
        Also there's already connectivity/registry/mysqlc/org/openoffice/Office/DataAccess/Drivers.xcu
        
        Change-Id: I928312a466620d8c194931381c861cf7a5ae9311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132338
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-04-01  Noel Grandin  <noelgrandin@gmail.com>  [e628a532d227a59f9d25d254037d0976a9fb73dc]

        tdf#147967 macos crash on insert formula
        
        blind fix
        
        Change-Id: I9a835d308f3809da874ee327afe70b9547ca8910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e60726891761ca29dcb72e27f075fef75a990c24]

        sc: use forward decl. instead of include for SparklineGroup
        
        Shouldn't trigger large rebuilding when SparklineGroup.hxx is
        changed.
        
        Change-Id: I9c5d265e94dd92d9f23e86e3fc75ca0644991339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132250
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [70bedb257a79eac45d614a09808b2e18074fa174]

        sc: render Sparkline columns smaller - reducee by 70% of the width
        
        Change-Id: I265a8b87b521f873e0ddea7a1a5becc558483ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132249
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0d9aa7388541d10a463c2d0a8d752d234aecfddd]

        sc: Sparkline export for OOXML documents + roundtrip test
        
        Change-Id: I4ab93d7ad33867ae817aa98d13ea9bc724b7d710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132248
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-04-01  Michael Stahl  <michael.stahl@allotropia.de>  [1c748fefc3c5b42e3548a1a7f5017a579982005a]

        nss: build with zlib module on WNT
        
        Change-Id: Ie875b4a8df1697de83a8f22cb1170a49792c47e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132367
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-04-01  Miklos Vajna  <vmiklos@collabora.com>  [5da08b21cd23f2e70f5003733b03a7aee7915225]

        sw content controls: add UNO API to insert this with custom props
        
        Add the ability to specify if the content control is a placeholder or
        not on the content control object itself before insertion.
        
        Change-Id: Ia06869c69a5b85cfc1d0a55739bbb23a53bef4d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132404
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-04-01  Mike Kaganski  <mike.kaganski@collabora.com>  [5b5205f1b1835cff20c091856887273f3a2c1e73]

        std::mutex->std::recursive_mutex in SwSendMailDialog_Impl
        
        ... after commit 2f2616a886cbf7bc06816d6b4a6f6b991f896d51
          Author Noel Grandin <noelgrandin@gmail.com>
          Date   Wed Aug 04 19:09:28 2021 +0200
            osl::Mutex->std::mutex in SwSendMailDialog_Impl
        
        The mutex may be locked recursively. Maybe it's possible to restructure
        locking to avoid that; but I don't feel brave to do that, and think that
        documenting the current behavior would be useful when such a restructure
        is performed.
        
        Change-Id: I3369445a5e615119db785054afe9aad5a9128b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132396
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-04-01  Julien Nabet  <serval2412@yahoo.fr>  [043dd5a8e143cc31cb602aaeef05b56e38a60afa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6e7aa9a6c7a40149d05a611cee896c582a9952f7
          - tdf#148302: Outline folding no more experimental
            
            Following tdf#148240
            
            Change-Id: I724ab325f628c21a713d61795a942c7791424c66
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132375
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-04-01  Arnaud Versini  <arnaud.versini@libreoffice.org>  [8fa40be492f4ae85eb3f0db363bd8d2cf7c214a6]

        cpputools : use std::mutex instead of osl::Mutex
        
        Change-Id: I75879a0f03d8212ac9392c04fb76113cf24d510e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132300
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-04-01  Miklos Vajna  <vmiklos@collabora.com>  [678446780446ae568ee8b1b814158c54ea5e393f]

        sw layout xml dump: handle hyph portions
        
        Also pass around the text frame's text / offset. This allows showing the
        text of the portions even inside multi-portions, which is not possible
        with the a11y-based approach.
        
        Change-Id: Ief8963ed0514fbe4b2abb24e93777865ec1d9242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132366
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-04-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [2110597ac730fa07dbbdd603fda82b182ed27c9e]

        tdf#147485 sw: fix group shape crash using std::shared_ptr
        
        for SwFrameFormat::m_pOtherTextBoxeFormats.
        Before there was broken manual handling of this
        member, resulting random crashes.
        
        Details: Writer textboxes are textframe + shape
        pairs. Accordingly the shape has a draw format,
        the frame has a fly format. In case of group
        shapes the paired structure doesn't work, because
        there is one shape format and many fly formats.
        To handle this there is a class (SwTextBoxNode)
        which has a small frame format table inside.
        This cache gives the possibility to handle
        each frame shape pairs inside the group depending
        on what SdrObject owns that textbox.
        
        However there is another place where these formats
        stored, namely the SpzFrameFormatTable in SwDoc.
        The only problem is that, when a flyframe removed,
        it has to be deleted from both tables, but if the
        DelLayoutFormat() is called, that will call the
        ~FrameFormat(), and if the format already deleted
        from the SwTextBoxNode, there will be double deleting
        for the same address, which caused the crash.
        
        To avoid this the following is present:
        
        When fly deletion occurs, first the format is
        deleted from the doc, then via the ~SwFrameFomat()
        will be deleted from the TextBoxNode. If the deleted
        format is a drawing, the whole node will be destructed
        via the shared_ptr. Hopefully that will be fine,
        without any leak.
        
        Change-Id: I007724695bc035998cb35efeefecd308aae36e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132308
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2022-04-01  Heiko Tietze  <tietze.heiko@gmail.com>  [d3e7dd4d4ddc88ba60be6ce5e90a1d1fcde47cca]

        Resolves tdf#148292 - Keep UI static for Impress' general options
        
        Right frame changes left position depending on unit's spinedit
        Added an arbitrary width request to make the UI static
        
        Change-Id: Ibb9033627bdd0d73108862d5e48683935eab0fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132364
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-04-01  Pranam Lashkari  <lpranam@collabora.com>  [fb4cf97f3d6a1efc3b3914067ebff304bb45ccf1]

        keep draw and impress sidebar page setup different in sidebar
        
        in draw sidebar "Page" deck displayed title "Slide"
        
        Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
        Change-Id: Iea7c95bc8c7ef2054c04c6cae77a254c969e1156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132368
        Tested-by: Jenkins

2022-04-01  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [fd6f8f39fe82532dfee6b8d5a02179e087203bef]

        tdf#148284 make app bg darker than doc bg
        
        Change-Id: I5966d46f77647168f2aa1f610ac9aeb3d4431ab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132348
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [040b3198fde3385e19e7380fdcabae84a0abac9d]

        tdf#83126: sc: Add UItest
        
        Change-Id: Ic2789ff1a2d60b79b8754554d061c840dc1163cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [ca832495ac83117bed6c334f3cc72d6a84d66a6c]

        A string_view is not necessarily NUL-terminated
        
        Regression introduced into LIBO_INTERNAL_ONLY code with
        1da69081732c8a429840edaaf10cfb789ea68df8 "add string_view variants of methods to
        O[U]StringBuffer".
        
        And add some tests.  Assigning an OStringChar to an OStringBuffer also uses the
        std::string_view assignment operator, so also test that with testOStringChar,
        even though there it is relatively likely that the OStringChar temporary is
        followed by null bytes, which could make the test happen to erroneously succeed.
        But at least tools like ASan or Valgrind could catch that.  On the other hand,
        assigning an OUStringChar to an OUStringBuffer does not use the
        std::u16string_view assignment operator (and rather uses a
        ConstCharArrayDetector-based one, which was similarly broken and has been fixed
        in b66387574ef9c83cbfff622468496b6f0ac4d571 "Fix -Werror=array-bounds"), so
        there's no test for that here.
        
        Change-Id: I7cf10ee5ce0e4280a91d116cd82d4871a0f44af6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132363
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [da27693800bd05a2bba092800d1b6a8e5dfaae7d]

        Basic Collection class unit test
        
        Change-Id: I7b67727ab8c3f7f67c2038500434ab44fa7d1949
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128544
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-31  Mike Kaganski  <mike.kaganski@collabora.com>  [50add7c97e75d604287218f49c9283aab052fdf0]

        tdf#148253: fix matching algorithm
        
        Using 'flag' as a "continue the loop" marker allowed to continue
        processing wildcard after its last character - not crashing because
        it was a subview of a larger string with separators, but failing
        the match.
        
        Change-Id: I308058b68c59d5719f3c8b5f5656998a95a9ba09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132336
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [b66387574ef9c83cbfff622468496b6f0ac4d571]

        Fix -Werror=array-bounds
        
        > In file included from svtools/source/svrtf/parrtf.cxx:28:
        > In member function ‘typename rtl::libreoffice_internal::ConstCharArrayDetector<T, rtl::OUStringBuffer&>::TypeUtf16 rtl::OUStringBuffer::operator=(T&) [with T = const rtl::OUStringChar_]’,
        >     inlined from ‘virtual int SvRTFParser::GetNextToken_()’ at svtools/source/svrtf/parrtf.cxx:183:94:
        > include/rtl/ustrbuf.hxx:352:20: error: array subscript ‘unsigned int[0]’ is partly outside array bounds of ‘rtl::OUStringChar [1]’ {aka ‘const rtl::OUStringChar_ [1]’} [-Werror=array-bounds]
        >   352 |         std::memcpy(
        >       |         ~~~~~~~~~~~^
        >   353 |             pData->buffer,
        >       |             ~~~~~~~~~~~~~~
        >   354 |             libreoffice_internal::ConstCharArrayDetector<T>::toPointer(literal),
        >       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   355 |             (n + 1) * sizeof (sal_Unicode)); //TODO: check for overflow
        >       |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > svtools/source/svrtf/parrtf.cxx: In member function ‘virtual int SvRTFParser::GetNextToken_()’:
        > svtools/source/svrtf/parrtf.cxx:183:94: note: object ‘<anonymous>’ of size 2
        >   183 |                                 aToken = OUStringChar( static_cast<sal_Unicode>(nTokenValue) );
        >       |                                                                                              ^
        
        as seen with recent GCC 12 trunk in an --enable-optimized build.
        
        And add a test, even though it is relatively likely that the OUStringChar
        temporary is followed by null bytes, which would make the test happen to
        erroneously succeed.  But at least tools like ASan or Valgrind could catch that.
        
        (For the corresponding OStringChar and OStringBuffer scenario, this issue does
        not arise, as OStringChar is not covered by ConstCharArrayDetector, so the
        correpsonding OStringBuffer assignment operator is OK memcpy'ing n+1 elements.
        There /are/ similar issues with string_view assignment operators for both
        O[U]StringBuffer, which will be addressed in a later commit.)
        
        Change-Id: Ia131d763aa5f8df45b9625f296408cc935df96ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132354
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [d940013e1726eba4d043110d5a01367c8d3f0a05]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/1ad91b85a5bb60f38a505756a0b5c338a8cb49fb>
        "Merge pull request #183 from ourigen/fallback-x11:  Change socket to
        fallback-x11 to fix 'Unsafe' warning"
        
        Change-Id: I9613d15cd74ac28e2d55eeed4a801a65062d5ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132362
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [1cac7d18ab8561f129a30d6c93c0f9f1d7868e01]

        tdf#130318 - Use the actual cursor position to create ToC "for chapter"
        
        Use the actual cursor position to create ToC "for chapter" beginning at
        the current level.
        
        Change-Id: I92e7c440005d52c517efa7e64a61c58da9db3197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125727
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-03-31  Miklos Vajna  <vmiklos@collabora.com>  [9caf6e4a3ac05a9d2e9d695e59d4ae048bf078b2]

        sw fly frames: add Tooltip uno property
        
        This is somewhat similar to commit
        1acf8e3cfaf1ef92008e39514a32ace0d036e552 (sw fields: add Title uno
        property, 2022-03-24), except that this is for images, and images
        already had a Title, which is persisted to ODT.
        
        So add a new Tooltip property which has priority over the tooltip
        generated for URLs, in case the tooltip is non-empty. This helps in case
        the URL is long / non-readable / confusing and a more helpful
        popup text can be provided instead.
        
        Change-Id: Ife34dab5e4490eb1682c55fb7c01f7509d0057fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132361
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-31  Michael Stahl  <michael.stahl@allotropia.de>  [bfb6c4c65781a610d21409d974227d73f264f41a]

        zlib: upgrade to release 1.2.12
        
        Fixes CVE-2018-25032
        
        external/zlib/ubsan.patch: remove, fixed upstream
        
        Change-Id: I2aa9a9008b9cf7efd970c5fff0df7029204204f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132358
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-31  Sarper Akdemir  <sarper.akdemir@collabora.com>  [e072e4149ffd4c07be1b6ded38e560f9cb635515]

        tdf#148273 docx import: fix section break format leak to bullets
        
        Fixes RES_PARATR_LIST_AUTOFMT leaking into the next section.
        
        Achieves this by resetting list related attributes on the cursor's
        text node in DomainMapper_Impl::RemoveLastParagraph() after the
        deletion of the paragraph.
        
        Change-Id: Ib4d09c5f190b8b8fd3bdc119ddd57d91f353de2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132324
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-31  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [ca6d879f765dad8471d42ec736b1f4235e5b8da4]

        Advanced Diagram support: Move class DiagramData to svx AFAP
        
        Splitted and moved parts of DiagramData class to svx as peparation
        to access from there. Done as pure virtual class so that no
        incarnations will be possible, also made the constructor protected.
        The derived class in oox hosts all functionality/data which
        involves usage/modification of oox::Shape class. That way we get
        closer to get the Diagram DataModel isloated/seperated.
        Not-yet moved is the String/Text holding data, it's still in oox.
        Moving that one will be next, that will allow to migrate quite
        some more functionalty to svx.
        
        Change-Id: I389dbf3ebf6171b8175cf30be7bbc8c20d9a38e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132303
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-31  Caolán McNamara  <caolanm@redhat.com>  [f99879edf4a4191daa98217f125e3d46d74a3031]

        add some documentation wrt kashidas
        
        that seems to match what we are currently doing in writer
        
        Change-Id: Iecc371deb88dc417fd86d5a6497dbf1dee53f72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132360
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-31  Julien Nabet  <serval2412@yahoo.fr>  [ca1e9a4ac8849c5d7967fe1340295495f328a8c8]

        tdf#148061: Crash when opening report from tdf#148042 (DBG_UTIL only)
        
        Change-Id: I30dd54547b1f93e55270d7c029168aff3d0e92bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-31  Caolán McNamara  <caolanm@redhat.com>  [3549367a5e0de95d33eaeffa144b1c3c638d4fe8]

        typo: charters->characters
        
        Change-Id: I48993192ec00aaf1d85cf65b6a12aacdcee67176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [6838d28ce0084e6e1952bfd5b7a101cb0a5bb294]

        external/freetype: Avoid nullptr-with-offset
        
        > workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:967:17: runtime error: applying zero offset to null pointer
        >  #0 in ft_var_get_item_delta at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:967:17
        >  #1 in tt_hvadvance_adjust at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1138:13
        >  #2 in tt_hadvance_adjust at workdir/UnpackedTarball/freetype/src/truetype/ttgxvar.c:1162:12
        >  #3 in tt_face_get_metrics at workdir/UnpackedTarball/freetype/src/sfnt/ttmtx.c:326:11
        >  #4 in TT_Get_HMetrics at workdir/UnpackedTarball/freetype/src/truetype/ttgload.c:104:5
        >  #5 in tt_get_advances at workdir/UnpackedTarball/freetype/src/truetype/ttdriver.c:269:9
        >  #6 in FT_Get_Advance at workdir/UnpackedTarball/freetype/src/base/ftadvanc.c:97:15
        >  #7 in af_shaper_get_elem at workdir/UnpackedTarball/freetype/src/autofit/afshaper.c:673:7
        >  #8 in af_latin_metrics_check_digits at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:1105:21
        >  #9 in af_latin_metrics_init at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:1156:7
        >  #10 in af_face_globals_get_metrics at workdir/UnpackedTarball/freetype/src/autofit/afglobal.c:462:17
        >  #11 in af_loader_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afloader.c:306:13
        >  #12 in af_autofitter_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afmodule.c:489:13
        >  #13 in FT_Load_Glyph at workdir/UnpackedTarball/freetype/src/base/ftobjs.c:978:19
        >  #14 in FreetypeFont::GetGlyphOutline(unsigned short, basegfx::B2DPolyPolygon&, bool) const at vcl/unx/generic/glyphs/freetype_glyphcache.cxx:903:19
        [...]
        
        during CppunitTest_svx_unit
        
        Change-Id: I6d45ec44006458350629edf06b8ec092a450ea05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132357
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cbdd82ef1d705af77a57f9a22a3274ee68a4929a]

        Remove execution bits from data files
        
        Change-Id: I2d3e00a93cb4f089c043c0067c8026cc9fc78301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132329
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [6bf6966c5e40ead076ec38464f777149010a3eb2]

        Missing test dependency
        
        > [_RUN_____] testPDFAddVisibleSignatureLastPage::TestBody
        [...]
        > warn:sal.osl:2861871:2861910:sal/osl/unx/process.cxx:343: ChildStatusProc : starting '.../instdir/program/xpdfimport' failed
        > warn:sal.osl:2861871:2861910:sal/osl/unx/process.cxx:344: Failed to launch child process, child reports ENOENT
        > warn:sdext.pdfimport:2861871:2861871:sdext/source/pdfimport/wrapper/wrapper.cxx:1090: executeProcess of file:///.../instdir/program/xpdfimport failed with 4
        
        when building CppunitTest_vcl_filter_ipdf from scratch
        
        Change-Id: Id155ee09eb90b4bfb0416ffa458554a126db9747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132334
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [bccbdce07cfa74f5cabf97c5fb11405991fffdfe]

        -Werror,-Wunused-but-set-variable
        
        ...ever since 24b06b9c6bdb777dff385b0fbfc81d55d3d013a1 "log access violation on
        windows tinderboxen"
        
        Change-Id: I8a26135131774d0c9fd160b805a3ab798a216cf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132349
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-03-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f0e19721bb598c75835cfa94f4158085f81288e]

        tdf#86166: sc_uicalc: Add unittest
        
        Change-Id: I7d7320e10c71e02606da192ee877f1df94d53c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132318
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [e2ba33336f5dfe989db0c287e3cb0d54e868939c]

        Adapt test to even slower builds
        
        ...like my local ASan+UBSan build, which now happened to fail once with
        
        >  Failed: TestReplacePerformance (t = 60 s)
        > Tests passed: 0
        > Tests failed: 1
        
        when the machine was under load during a parallelizing `make check`, following
        up on 3564b5c6e93b2bf5881b359015efae351dbe8342 "Adapt test to slow builds"
        
        Change-Id: I8f0c8f7e6e145b6d5009f48d2af865ea5caab375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-31  pragat-pandya  <pragat.pandya@gmail.com>  [a31aadb1ef7dfdd4ae76a15707ab51a82c95d868]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I38166d36e9e8518ab86ded7ab630a35f3a0c39d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132268
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-31  Stephan Bergmann  <sbergman@redhat.com>  [9f041e7678521074b09b20f4088996c86bea5cd0]

        tdf#147668: Reliably remove GTK menu bar widget
        
        ...rather than relying on a timely call to ~GtkSalMenu (which, like the added
        call of ShowMenuBar(false), would also call the relevant
        GtkSalMenu::DestroyMenuBarWidget in vcl/unx/gtk3/gtksalmenu.cxx).
        
        The call to ~GtkSalMenu can be delayed arbitrarily, when the owning VCLXMenuBar
        (which owns a VCL MenuBar, which in turn owns the GtkSalMenu) is e.g. held by
        some Java extension code (as in the case of the LanguageTool extension used in
        tdf#147668).  So when a SystemWindow was switched from e.g. showing a Writer
        document to showing the start center, SystemWindow::SetMenuBar(nullptr) was
        called to remove the Writer menu bar (before calling SystemWindow::SetMenuBar
        again to install the start center menu bar), but because ~GtkSalMenu was not
        called promptly, the Writer menu bar widget was not removed, and the
        SystemWindow ended up with a stack of two different menu bar widgets drawn at
        its top.
        
        So when SystemWindow::SetMenuBar(nullptr) calls MenuBar::ImplDestroy, use that
        as a hint to any underlying SalMenu implementation that it shall be removed and
        call ShowMenuBar(false).  For the GtkSalMenu implementation, a call to
        ShowMenuBar(false) happens to do what is necessary here.  But for the QtMenu
        implementation it would cause the menu bar to disappear forever from the given
        top level window, as subsequent calls to QtMenu::SetFrame (vcl/qt5/QtMenu.cxx)
        obtain the same, now invisible
        
          mpQMenuBar = pMainWindow->menuBar();
        
        again from the top level window; so just always call ShowMenuBar(true) from
        MenuBarWindow::SetMenu.  And for other SalMenu implementations the added
        ShowMenuBar calls appear to not cause any trouble, even if they would not be
        necessary for them.
        
        Change-Id: I66d5edf6b49a1c616fe849f6996570b5b00258ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132126
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-03-31  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [3ded7b2574c081e30285f470dbc33fef9167aa9c]

        Colibre: tdf#148135 ^ Ungroup icons
        
        Change-Id: I3150d62263b87ec9f63fa6406f74c26d42b47a97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132356
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-31  Miklos Vajna  <vmiklos@collabora.com>  [5dd4802c73dac4c3bd5c609562ce994d3b51e6a9]

        sd theme: add UI (area dialog) for shape fill color
        
        SvxColorTabPage::FillItemSet() has to produce a color item that has the
        theme index, which means SvxColorTabPage::SelectValSetHdl_Impl() has to
        change the current color to an svx::NamedThemedColor.
        
        The rest is just fallout from this, now that the current color has
        theming metadata.
        
        Change-Id: If0018c651239ba74f45745e69e41ff7040ac9b97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132327
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-31  Caolán McNamara  <caolanm@redhat.com>  [6c0dca63cd93c393b12bdbd2ce777c275a9279ff]

        Resolves: tdf#117159 don't crash with chart selected in database report edit
        
        Change-Id: I770008bf0a775c108019c2005b6ec73ee9702a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-31  Miklos Vajna  <vmiklos@collabora.com>  [c4268efef25129b162884312b15527f1e5c3bcb0]

        sw content controls: add UNO API to insert this
        
        This only allows the default richText type, the others are not yet
        handled.
        
        Change-Id: I39f73ccd9e2c1f0db5735cf97301b01482063d1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132350
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-31  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [f0c7746e83e9c9f17f7c415ef3423c882a6de1ca]

        tdf#116358: rtf import: "keep with next" also affects table rows
        
        Like in DOCX for RTF there is exactly same behavior for paragraphs
        inside cells. They do affect table breaking over the pages.
        
        So:
        1) Enable "TableRowKeep" doc setting for RTF documents.
        2) Do not ignore \keepn token for paragraphs in tables.
        
        Change-Id: I11e45ca9114c792b8cdbeb77dd51359717129651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132305
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-31  Dennis Francis  <dennis.francis@collabora.com>  [6ade0f41805261c9c8c7ac784f5bddb2ad47efda]

        lok: paste-undo: invalidate sheetgeometry
        
        In case of copy/pasting of whole column(row) and its undo/redo may
        result in column(row) width(height) changes. Hence a corresponding
        sheet-geometry invalidation message needs to be sent to the lok
        client(s).
        
        Change-Id: I7aa471d9770fc21c567a3c6f5d5926df0fd5dacb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132174
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-31  Dennis Francis  <dennis.francis@collabora.com>  [a8aad2c761ccc18cd24ff2a87e6bd1b5c2b8cfe1]

        lok: unit-test: add comment unique id checks
        
        Change-Id: I588484955ad3ad4c5ec3bfa9f5a844096c768ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131725
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 9bafce808b6d301b17ee60da452a41cd4b7cf02c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132173
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-31  Dennis Francis  <dennis.francis@collabora.com>  [48d0a9423f21b6380c3ca819e090947d3a25e23c]

        lok-comments: CopyOneCellFromClip: notify lok clients
        
        Change-Id: I4b433c8f7123fe33f1b106cbf45216d2b0c73dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131691
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 3902718e6daed24e4fe3653b4241f94e802c4e56)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132172
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-31  Dennis Francis  <dennis.francis@collabora.com>  [52fb77b4145e1206d164c36f045b367c684c266c]

        lok: CopyCellNotesHandler: use the cloned object
        
        to get correct id for the new cell-note.
        
        Change-Id: I4df492ad91faad5797ba513f9a3aa9abd2baf88f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131690
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit acafc2823f917b6f6299fa0b65a0d7461531c8a5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132171
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-31  Dennis Francis  <dennis.francis@collabora.com>  [d0221fb6c35ecceb53e347d2790ac66b8a021044]

        lok: ensure unique id for annotations
        
        Problem:
        When a cell containing comment is copied and pasted to another cell, the
        cloned comment/annotation in the target cell has the same id as the
        original one. The lok clients depend upon the id of each comment to
        identify them and update coordinates when updates are requested through
        .uno:ViewAnnotationsPosition. So the client does not have enough
        information to distinguish between comments of same id.
        
        Conflicts:
        	sc/source/core/data/postit.cxx
        
        Change-Id: Iebd7281113e0830826aff1bbdaae234bd5d5cd4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131689
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit dd229e4cd9a0211c9a80031da1d2f7fb71b6683e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132170
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-31  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4ee8a4662bb85a130467805194124ab649acd7e7]

        Colibre: Remove transparency for file emblem in Start Center
        
        See the screenshots: https://github.com/rizmut/libreoffice-style-colibre/pull/48
        
        Change-Id: Ief6b29dd9e4f4702b8cc0932b9d52d70dfa1958e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132340
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-31  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [aca4b5708207962935ca34adc70fed3a9ffb6074]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes
        
        (Callouts and Vertical Callouts)
        Change-Id: I5531550a21536351bd56e1da365d0bc640bc9f32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132341
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-30  Stephan Bergmann  <sbergman@redhat.com>  [0a05b1f46263a16c6d40c841a317c3ba9f4d31d6]

        Missing test dependencies
        
        > warn:vcl.builder:2475462:2475462:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/svt/ui/editcontrol.ui at xmlreader/source/xmlreader.cxx:66"
        
        and
        
        > warn:vcl.builder:2507015:2507015:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:66"
        
        when building CppunitTest_sw_layoutwriter from scratch
        
        Change-Id: I043db8e1b25a8b990bcad542dcbe533a57654c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132323
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [e10888cbb3bba4e0dff954566fd0f3721be3e5ab]

        unroll this typical writer-style multi condition if statement
        
        no logic change intended
        
        Change-Id: Iebb8df604aa69829536e3cab10b33056e4cdf78e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Julien Nabet  <serval2412@yahoo.fr>  [6fee8f6da0c25ab3c5c7a84da45f1f79a19d4951]

        tdf#148263: Calc: "Sheet" -> "Rows" is not very clear that it's about deleting
        
        Idem for "Columns"
        
        Regression from:
        commit 763e5d233d18a26f64dd8c4db67ce62ee289832e
        Author: Julien Nabet <serval2412@yahoo.fr>
        Date:   Wed Mar 16 20:35:33 2022 +0100
        
            Related tdf#114286: put duplicates commands in GenericCommands (DeleteColumns)
        
            Change-Id: Iecfa09729ea1b237fb6994be4b3ceaaa3ad126df
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131680
            Tested-by: Jenkins
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        
        commit 52a695d2ceb4231a9fcc419959e29023ecef037b
        Author: Julien Nabet <serval2412@yahoo.fr>
        Date:   Thu Mar 17 11:01:47 2022 +0100
        
            Related tdf#114286: put duplicates commands in GenericCommands (DeleteRows)
        
            Change-Id: I100297d10b2643c5ddad7753a7c1032526ce06cd
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131699
            Tested-by: Jenkins
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        
        Change-Id: I790f2b686e27195b137db3b2d6385787e1829e04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132325
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [551141c90f969421be77d9dc90a8feac791267ab]

        tdf#45020: sc: move UItest to CppUnittest
        
        Change-Id: I14e8fec80e06403868a80cabfe5231420bdd6f2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132328
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [ecdb3826e852a6270e3106d30dac44793ad56e1a]

        tdf#85353: sc: Add UItest
        
        Change-Id: Idc2fc8157a84b010be4855d8aa7c111d4594b4f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132326
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3bfea3cdb8723bb82840e6e0282bfd4a48fd8f79]

        Fix typo
        
        Change-Id: Ie50eeb9bcf1670b014ec600b62ef83a4fb27ee59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132330
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-30  Stephan Bergmann  <sbergman@redhat.com>  [ea2184d3dcd018e41e4448727b674976e116d1ef]

        Avoid float-cast-overflow
        
        > sw/source/filter/html/parcss1.hxx:163:35: runtime error: -1.0458e+22 is outside the range of representable values of type 'int'
        >  #0 in CSS1Expression::GetSLength() const at sw/source/filter/html/parcss1.hxx:163:35
        >  #1 in ParseCSS1_text_indent(CSS1Expression const*, SfxItemSet&, SvxCSS1PropertyInfo&, SvxCSS1Parser const&) at sw/source/filter/html/svxcss1.cxx:1955:45
        
        during recently introduced testForcepoint94::TestBody in
        CppunitTest_sw_layoutwriter, where sw/qa/extras/layout/data/forcepoint94.html
        contains "text-indent: -18446744073709551616.0cm"
        
        Change-Id: I1070f07ea0304a3813ab9a58441c9d7e45f79ffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132322
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-30  Miklos Vajna  <vmiklos@collabora.com>  [c434041f9abfc6fb3c9a2570f742a4c79885f2b4]

        sw clearing breaks: link ODF proposal
        
        Change-Id: I652a079f6bf31c6b4a278c4b246404684c771ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132317
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-30  Tünde Tóth  <toth.tunde@nisz.hu>  [aea8043bc5f5187498fa450505d6de9d6986e2a6]

        tdf#74670 tdf#91286 PPTX XLSX export: save image once
        
        Impress and Calc used to dump the same image file
        as many times as it was featured in the document,
        resulting redundant, sometimes huge documents.
        
        Note: using only checksum to recognize image duplication
        is a regression, because checksum collision results
        image loss. This is a very unlikely event, and
        the following commits have got the same problem.
        The solution is comparing the images with the same
        checksum byte for byte.
        
        See also commit b484e9814c66d8d51cea974390963a6944bc9d73
        "tdf#83227 oox: reuse RelId in DML/VML export for the same graphic"
        and commit 797fef38612fb2fd62d1f6591619b9361e526bca
        "tdf#118535 DOCX export: save header image once".
        
        Change-Id: I9f233d521941381746634cf4f9b5991da0dadda9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131928
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-30  Luboš Luňák  <l.lunak@collabora.com>  [94ace0e51744f82b58156392e53b4c4ad819e4bf]

        try to use llvm-readelf etc. first when building with Clang
        
        With Clang14 the binutils readelf prints out a lot of warnings
        that are presumably related to Clang's switch to DWARF5, but
        llvm-readelf is silent about it. And in general it seems to make
        sense to first try to use the related tool.
        
        Change-Id: If0dd4f267bae080b7053a6944cd24df7f9b9cf69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132309
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [910251c05059d0c31d9556f6c8e8dbffc8998f89]

        use the device dpi
        
        Change-Id: I8762e84a34a116778bd0bced706d631db4761a01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132302
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [0b9892fee990b7f6d0457ab6191f87c3991580e6]

        forcepoint#95 read past end of malformed document
        
        Change-Id: I8b2c558c733af3d7662f668af47e962e252ee339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Tünde Tóth  <toth.tunde@nisz.hu>  [96622aa772518926c4563a54238edc8e83e723c5]

        tdf#53970 PPTX: add unittest
        
        Change-Id: I1bcf8f79213245fdf135d6d3b2aafea6ed99f5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132296
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-30  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [95e85730ad850a66879a639d9f5936fa67549ab7]

        Colibre: tdf#120425 equalize icon dimensions
        
        Change-Id: I8d2ae21cee9ba021a3e7bc0efd7f6a67768105f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132280
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [79365d6f5a3706da8464d564deee6bb54422c3d0]

        WASM fix native EH build since Emscripten 3.1.6
        
        Building LO with WASM native EH and Emscripten 3.1.6+, the link
        fails with a missing "emscripten_longjmp" symbol. Actually the
        old build was simply wrong, because the emscripten_longjmp
        function is just used for the Emscripten SjLj and not the native
        WASM SjLj implementation. Linking just worked, because the used
        libcompiler_rt-wasm-sjlj-mt.a lib was incorrectly providing that
        symbol, which 3.1.6 removed.
        
        But since running the NEH build still fails early in the same way
        then before in FF nightly 100 and Chrome (= failure in the LO job
        scheduler calling Task::UpdateMinPeriod for the "desktop::Desktop
        m_firstRunTimer" timer, resulting in a WASM VM "RuntimeError:
        indirect call signature mismatch"), there is still no way to know,
        if nothing else it missing. The Emscripten / JS EH build still
        works without any code changes. And it's not the first call on
        a job object that fails...
        
        And unfortunatly, because Qt itself also uses libpng, it also uses
        SjLj for error handling, like LO in the image import, so the Qt
        build must also be patched to build with "-s SUPPORT_LONGJMP=wasm".
        Simply enough to do (see README.wasm.md). LO's configure now
        detects that symbol and will bail out on incompatible Qt and LO
        build setup.
        
        See https://github.com/emscripten-core/emscripten/issues/16572
        
        Change-Id: I3a1877f3aeb77873906176b9d3cd1ea92973f1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132139
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-03-30  Luboš Luňák  <l.lunak@collabora.com>  [21c24aa4fdea118ddda0b60e17486458c739375f]

        don't clamp columns to allocated ones for flags
        
        Flags and attributes can be set even for unallocated columns.
        
        Change-Id: I7c4e6b9c8f9359620f6c2ab06fe0563183b88f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132304
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-30  Alain Romedenne  <alain.romedenne@libreoffice.org>  [417fb5a4024a23bb7d6ea13f721e3a53aaf1ecee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f62d08a3fb7e4b3e56c06cf643354a2a16a1aaba
          - tdf#145754 Corrections to 'Option Compatible' Basic help page
            
            Change-Id: Ie44b6b8717de38073dc791c286ce778e7595db3e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132038
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-03-30  Miklos Vajna  <vmiklos@collabora.com>  [ddfafd9b67e6e61c144b29ac73bbafb413ddf03b]

        sw: fix crash in SwAttrSet::CopyToModify()
        
        Regression from commit 938a4d6624a78f3e272b3c4c07f314cb0c6db723
        (tdf#128375 sw: fix copying RES_PARATR_LIST_AUTOFMT to different SwDoc,
        2019-11-01), the problem is that we may get an autofmt pool item which
        is set, but its style handle is empty. Assume that this is the same case
        as having no autofmt at all.
        
        Change-Id: I87494fd04687d31201b4ec712cb0fb1ec7362b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132301
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-30  Arnaud Versini  <arnaud.versini@libreoffice.org>  [e96150520918d1bd008ba39485512e74cec3bc35]

        desktop : use std::mutex instead of osl::Mutex
        
        Change-Id: I775baf9a2c9599b10eb855535ac0f8e438dd863b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [bbd196ff82bda9f66b4ba32a412f10cefe6da60e]

        add infobar to prompt to refresh to replace old format
        
        Change-Id: Id99cbf2b50a4ebf289dae6fc67e22e20afcda35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131976
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [192fa1e3bfc6269f2ebb91716471485a56074aea]

        add Initialization Vectors to password storage
        
        old ones default to the current all zero case and continue to work
        as before
        
        Change-Id: I6fe3b02fafcce1b5e7133e77e76a5118177d77af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131974
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [efb6845d42c44bbd75771cc1641bc5f2225d8a96]

        ofz#46165 ubsan Divide-by-zero
        
        Change-Id: I5c56eae4456a03550770035610745de3be074679
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [72499d57daf8f53dae268b2160fa0585ed0bd36d]

        ofz#46160 Use-of-uninitialized-value
        
        Change-Id: Ic39fd3579623563adf16025442bb634a273decb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132298
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [254d0e17dcd9a6bce536057b020292ac0ab2e48e]

        ofz#46160 Null-dereference READ
        
        Change-Id: Id33a39a7a65849a4ca98b43a88e60d5a96eaf5de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132297
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7efd22c912262f7bf4e4735dae70db0b31ab3d5b]

        Add UNO API for custom Jump Lists
        
        Allows adding custom jump list categories to Windows Task Bar
        
        Change-Id: I13b6c3ad5de386cf74e2b346f10889bc46a8ad4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131540
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-03-30  Michael Weghorn  <m.weghorn@posteo.de>  [ab9422621bc0aa26a00aa92f8bdebe91a6519792]

        .gitignore: Add Qt Creator's '.qtc_clangd'
        
        Qt Creator 7 switched to using Clangd as the
        default backend for the code model. [1]
        After upgrading, `.qtc_clangd/compile_command.json`
        started showing up.
        
        [1] https://www.qt.io/blog/qt-creator-7-released
        
        Change-Id: I3cf30f1ef2873523d76c15c39d2d24c6227f8017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132290
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-30  Miklos Vajna  <vmiklos@collabora.com>  [3dd4f3691458ea537bc1867386269694775cfbcb]

        sw content controls: add document model
        
        This is meant to represent inline structured document tags (<w:sdt>
        elements in DOCX) or content controls (as Word users know this).
        
        Don't confuse this with block-level, cell-level or table-level content
        controls, which are not covered here.
        
        You may wonder why fields or fieldmarks can't be used to represent this.
        The problems are:
        
        - a fieldmark can contain a paragraph break, inline content controls
          can't
        
        - content controls must be a well-formed XML element, while fieldmarks
          can start/end at random document model positions
        
        - fieldmarks are supposed to have a field command and a result result
          (with a separator between the two), but content controls don't have a
          field command
        
        - mapping to a field has the problem that Writer fields can only have a
          single text portion / run, but content controls can have multiple ones
        
        So model content controls with a meta-like text attribute which covers
        all these cases.
        
        SwContentControl is mostly empty as a start, it can track more data in
        follow-up commits. SwTextContentControl and SwFormatContentControl are
        the matching text attr and pool item subclasses.
        
        Change-Id: I1e57f7756cf87041975371483ec4fc8abf875dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132291
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [84f5a7f5c714ed57e9ff7e0a2231425e52d3f4b8]

        ofz#46070 Out-of-memory
        
        Change-Id: I35bef5643d8a620aaa001bb1f4f7a9a60779ed97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [fc6d597a933f9ca71b479864b31682dac17724c3]

        Related: tdf#117162 use a marginally tidier but riskier fix for trunk
        
        Change-Id: I94a836d7424eb561af623fee9d3a7e6d307cf065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132287
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [78f7bd90b96ac168fdacd1e0cb0693ab3861872a]

        Resolves: tdf#117162 ImportDocumentHandler expects data provider to exist
        
        already in its ctor
        
        which changed since...
        
        commit 9009663deb8f0862f419fd99bf0b761c7f923eff
        Date:   Sun Feb 26 22:48:06 2017 +0100
        
            tdf#83257 [API-CHANGE] Pivot chart implementation
        
        which defers it, take a probably safely backportable approach here to
        fix it.
        
        Change-Id: I1863791af7ae737f337993833a9cf1429a3a8028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132286
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Caolán McNamara  <caolanm@redhat.com>  [70f3a94949cce612be9eff14fca94976acfc61a4]

        tdf#117162 ImportDocumentHandler expected XDocumentHandler argument
        
        but SvXMLImport not longer supports XDocumentHandler since
        
        commit fe2b4e7dc6533535736a8f08496f316427386179
        Date:   Tue Oct 6 18:27:27 2020 +0200
        
            make SvXMLImport fast-parser only
        
        here use a SvXMLLegacyToFastDocHandler to try and glue the two
        parts together again. Though the use of reflection::XProxyFactory
        is a bit worrying here wrt this change so unforseen side effects
        are possible. Full change over to fast-parser only is probably
        advisable.
        
        Change-Id: Ie14d1d9fa8534c187efc67a6c1cc0989316c4634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132285
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-30  Regina Henschel  <rb.henschel@t-online.de>  [365a3ed39083389f40612dec765d7b8e0dc2377b]

        Extract 'switch' block out of WriteCustomGeometry
        
        This is a follow up to commit 2029b2f6dd0109c5892e5ac5640022b31fe42fd2.
        That commit has increased the line count of WriteCustomGeometry to more
        than 500. This patch splits it to a main part of about 230 lines and
        a new method for the previous 'switch' block of about 300 lines. That
        makes the loops in the main part better readable.
        
        Change-Id: Ied4378f54e7c8dc7965a5b1db15baf0b35f63f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132274
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-30  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [b9b9b3afde384d2e24dcbf9a60fa9ee227576114]

        tdf#114263 tdf#147262 CallByName() function LibO Basic test unit
        
        Change-Id: Ia9bd38c0da4d3f94b824ebb1f98ac912758e8d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129610
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-30  Miklos Vajna  <vmiklos@collabora.com>  [7c647704cf0b272304f9e22940e27cee53fa034a]

        CppunitTest_sw_ooxmlexport6: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I8ee8a13a0aafda32176b109c1f27622974e9cf12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132284
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-30  Yomnasalama  <yomnasalama2000@gmail.com>  [92ddacfaa00f7dbcddc521f2239916e69e9a33d6]

        tdf#143148- Use pragma once in connectivity
        
        Change-Id: If15cf06a986e4bf6ac43b91567a7b2b1aa153d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132156
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-03-30  mostafa-elsharnoby  <mostafaelsharnobi@gmail.com>  [c03b09e502bf178ae3b6752408e4f9813d4a49a8]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: Iad31b4d3d22519059d340a02868080c829ce7b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132158
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-03-30  Luboš Luňák  <l.lunak@collabora.com>  [a3988b2d147a2442b348d58b79dbd6e71472b7af]

        handle xlsx with too large sheets the same way as e.g. ods
        
        The generic approach sets an error code on import and then
        SfxBaseModel::handleLoadError() takes care of it. This also
        allows checking for the warning in unittests. A drawback is
        that this generic approach can handle only one error code,
        so if a sheets has too many rows and column, there will be
        only one warning, but I consider that to be minor.
        
        Change-Id: I1d5f7f9162ef63c3c2e8414823d18a1ff50ad71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131970
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-30  Luboš Luňák  <l.lunak@collabora.com>  [e63704897b14085d1290f5112ebd7cf7c2f0b2c6]

        allocate columns for initDataRows()
        
        Triggered by TestSort::testSortImages() with INITIALCOLCOUNT set to 1.
        
        Change-Id: Ifd3e63de6411e0a4d8776ed6cc8a7b6c7c64eec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132283
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-30  Luboš Luňák  <l.lunak@collabora.com>  [cf560fd387ee9f54d3edaf066c70b411d1f7b299]

        use ScTable::ColumnData() in ScDocument::ExtendOverlapped()
        
        Otherwise there's invalid array access triggered by
        VBAMacroTest::testVba() with INITIALCOLCOUNT set to 1.
        
        Change-Id: Iaff333788d2d29444139c99b0f6e82b69a5a2d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132282
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  Stephan Bergmann  <sbergman@redhat.com>  [bd94e9dfd0a4c67266e21baa9ec10a56850d093f]

        Add back the opportunity to leave O[U]StringLiteral's buffer uninitialized
        
        ...once we have a C++20 baseline, which would render uses of the consteval
        O[U]StringLiteral ctors ill-formed if we accidentally failed to write to all of
        buffer's elements.  This had been broken (and the TODO comments had become
        misleading) with 21584b304b21bfe6b99b6f29018c6b754ea28fc0 "make
        OUString(OUStringLiteral) constructor constexpr" and
        bca539e889d40e06cb3275442622cb075b2484a2 "make OString(OStringLiteral)
        constructor constexpr".
        
        Also add corresponding test code.
        
        Change-Id: I2bc680282c717d403a681ff4b9396580c8382de1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132275
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [2fa01ae540e174452bf5cd763c1464cfe37af076]

        tdf#125800: sc_macros: Add unittest
        
        Change-Id: I9286264bbfa1e59e51d2a94417f7e8526357f821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132277
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-29  Luboš Luňák  <l.lunak@collabora.com>  [dde866578eff5eaf1d59c5a98d3e72ce87718b00]

        allocate columns in ScTable::Compare()
        
        This gets triggered by ScCellRangeObj::testSortOOB() if
        INITIALCOLCOUNT is set to 1.
        
        Change-Id: I4d9715e89403072b312c0002a43c67ac59960d1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132281
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [9333e50be8919ce70234bba2f8496523d90670f5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 602281f118a8b8218bef24511d835f39aea3561a
          - Remove redundant image title attributes
            
            From web accessiblity evaluation tool:
            
            The title attribute value is used to provide advisory information.
            It typically appears when the user hovers the mouse over an element.
            The advisory information presented should not be identical to or
            very similar to the element text or alternative text.
            
            Change-Id: Id95d6661d47d7c28ea8a3f6a43ecc1b12c579a95
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132265
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-29  Luboš Luňák  <l.lunak@collabora.com>  [8b175422fd00648085ddc604fcfbb05de3b2d343]

        allocate column in ScTable::FillSeries() when needed
        
        There's an assert triggered by Test::testAutoFill()
        if INITIALCOLCOUNT is set to 1.
        
        Change-Id: I65ecd7df3bf6b38a8121a252f7f53dd7f5bbb0fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132270
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  offtkp  <parisoplop@gmail.com>  [b0dfc4101366ff4e42c5ad9ea48e43ca2b957202]

        replace dynamic C style arrays with std::vector in Splines.cxx
        
        replaced all instances of dynamic C style arrays, removed delete
        statements as they are no longer needed
        
        also now removed a pointless loop for an std::swap
        
        Change-Id: I0438b1fa944dc6ae8c6a3cc488645504ab30c3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132278
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [fd8b0796092566576a80004cbffa95f3b05923f0]

        qt: Fix typo in function name: lcl_MapUndrelineStyle
        
        Change-Id: I50b2ffeb1b6bb490c14a307152634cc51022a426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132276
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-29  Julien Nabet  <serval2412@yahoo.fr>  [2525bab2fcca179263a4b3496bb929df61d0e2bf]

        tdf#148240: Make Outline-Folding non-experimental
        
        Change-Id: I8de81ec13228d0742a3b12af97edb1b97643a790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132243
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-29  Stephan Bergmann  <sbergman@redhat.com>  [3b53760bcd304c0a3efc58188d80cb963c24b484]

        Check for yet another consteval bug
        
        ...which caused at least recent Clang 15 trunk configured with
        LLVM_ENABLE_ASSERTIONS=ON to crash when building --with-latest-c++ e.g.
        sal/qa/rtl/strings/test_oustring_stringliterals.cxx since
        21584b304b21bfe6b99b6f29018c6b754ea28fc0 "make OUString(OUStringLiteral)
        constructor constexpr"
        
        Change-Id: Icef2ae27bfc518b127aabfc4767212b4b6a95a77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132273
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-29  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [f81800193a942b3f68c61a5cede634f3eeb47b1f]

        tdf#73499 DOCX import: fix grouped linked textbox
        
        Only ungrouped text boxes were imported correctly.
        Grouped textboxes lost their linking, resulting
        broken layout. Now the linking is fixed for DrawingML.
        
        Note: in old MSO versions, linking needed grouping.
        To import these DOC documents correctly, convert them
        to DOCX/DrawingML in MSO before opening them in Writer.
        
        Change-Id: Ib5a8744d783a9c95c42447d204e17891b3aea7bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130950
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [c1ee13b11f78026a323fea7f20d82d7b056ae9bb]

        sw: replace usage of sal_Int32 with Color
        
        after
        
        49a40e3ed200e7c6d728f36d0b4be22dd85c51be
        "tdf#135923 DOCX shape import: set text color"
        
        Change-Id: Ic96233555d8d79645ff3d5ff3711fa428b05c98b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132271
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8]

        tdf#89449 PPTX import: fix line connectors
        
        Line connectors were imported as plain shapes, losing
        their functionality during editing, i.e. keeping
        connections of boxes and other shapes.
        
        Change-Id: I0f1562be2dbcce0e45eb209c6ca4e035731039e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131303
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-29  Luboš Luňák  <l.lunak@collabora.com>  [bc601af632861896bdfaa14c96daf1a7ffdfcf71]

        avoid repeated calls to ScMarkData::GetMarkedRanges() (tdf#148147)
        
        ScTable::HasSelectionMatrixFragment() gets called several times
        when opening 'Sheet' in the menubar, and the functions it calls
        end up a quadratic cost for the number of columns repeatedly
        calling ScMarkData::GetMarkedRanges() for the same object. Fix
        the performance problem by getting the value once and reusing it.
        
        Change-Id: I8b05475832c3560318c43429c3b9323035a3691f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132267
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  Luboš Luňák  <l.lunak@collabora.com>  [faa6b71493a3a6be674a01243fc2f52db4398214]

        do not provide non-const iterators for ScMarkData internals
        
        It's a bad idea, and it's actually not needed.
        
        Change-Id: Ic1022bc4774a33abbc37158539881a15792bc282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132266
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  Stephan Bergmann  <sbergman@redhat.com>  [ac520c337bd3799366a1fd1dbda0baabb299e3bc]

        Revert "removed pointless using namespace std"
        
        This reverts commit 5b53dd0514c25f907c80d523b078387db71f859b.
        
        The using directive was not pointless, it was necessary to correctly call the
        std::swap customization point.
        
        Change-Id: I642587fe2a8fc281a6079837edce3a8a6c47ea33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132184
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-29  offtkp  <parisoplop@gmail.com>  [f54ed0bcaac5d41ad7ef9946b07094db369b3cb9]

        replace temporary value swap with std::swap
        
        Replaced 3 occurences of temporary value swap with
        C++ standard std::swap
        
        Change-Id: Ib4dea821da8e93e8d18a3ebe55a7e47a010c9de9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132194
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-29  offtkp  <parisoplop@gmail.com>  [64888968b30fb387d8c2536664117915e5423b0c]

        tdf#145614 Convert #define to constexpr
        
        Change-Id: I2c57e2021a224fb7f69d1de5cf0f809a7d2422b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132151
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-29  offtkp  <parisoplop@gmail.com>  [5b53dd0514c25f907c80d523b078387db71f859b]

        removed pointless using namespace std
        
        Change-Id: I117aa1ea74b636ef06f7eedce8f2e12f9c4226b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132213
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-29  Tünde Tóth  <toth.tunde@nisz.hu>  [49a40e3ed200e7c6d728f36d0b4be22dd85c51be]

        tdf#135923 DOCX shape import: set text color
        
        to the character color of the shape if it is not comes
        from direct formatting.
        
        Change-Id: I3f0a3e952b5449a6d92c5bb273d353a561f3e3dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130922
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-29  Tünde Tóth  <toth.tunde@nisz.hu>  [bc72514f90d90e1ab3fed8167663e835edf03508]

        tdf#53970 PPTX: fix export of embedded media files
        
        Embedded media files lost in documents created
        with Impress after PPTX export.
        
        Change-Id: I453b58f9cfa6a33653e9216fb82b66970a9ec31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132095
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [44950bc4bbcafb86d9e6466b5ce0852122d7f2be]

        android: Enable support for FODS
        
        Enable support for MIME type
        "application/vnd.oasis.opendocument.spreadsheet-flat-xml" in
        AndroidManifest, the comment saying it crashes the app
        is obsolete.
        
        However, at least on my Android 10 AVD, that MIME type
        does not seem to be associated with '*.fods' files, so
        they were not offered to be opened. MIME type
        "application/octet-stream" was used instead, for which
        no support is declared.
        
        For testing, I just disabled the MIME type filter locally and
        was then able to open an FODS file just fine:
        
            --- a/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
            +++ b/android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java
            @@ -266,7 +266,7 @@ public class LibreOfficeUIActivity extends AppCompatActivity implements Settings
                     }
        
                     intent.setType("*/*");
            -        intent.putExtra(Intent.EXTRA_MIME_TYPES, SUPPORTED_MIME_TYPES);;
            +        //intent.putExtra(Intent.EXTRA_MIME_TYPES, SUPPORTED_MIME_TYPES);;
        
        Change-Id: Ibf3f559a313f0b89bc4c25498e3efa0fcbded506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132263
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [67bfb36fc7d9e53bc6739e7d5a30e7aa1a8c01e5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c623dfe855734c75875f7333e49b1c7cd302988e
          - Use type="search" for index filter input
            
            Change-Id: I0427076aa8d688f837a38c66312b7690336c0d2e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132264
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-03-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [89fae8b4b5b88b92706e760d870849260c56f2c0]

        loplugin:unusedfields
        
        Change-Id: Iaf3a0a42e94994eab25f5e9ef8c111362e86fb02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132262
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-29  Michael Stahl  <michael.stahl@allotropia.de>  [c87bbaa87e2532c7601e8588d87de1dc4952f098]

        sc: fix use after free in ScChart2DataSequence::ExternalRefListener
        
        UITest_chart: tdf122011.tdf122011.test_tdf122011
        
        ERROR: AddressSanitizer: heap-use-after-free on address 0x61e00007a13e at pc 0x7f9a88217e2b bp 0x7f9a901e7ab0 sp 0x7f9a901e7aa8
        READ of size 1 at 0x61e00007a13e thread T53
            #0 ScDocument::IsInDtorClear() const sc/inc/document.hxx:2421:56
            #1 ScChart2DataSequence::ExternalRefListener::~ExternalRefListener() sc/source/ui/unoobj/chart2uno.cxx:2897:26
            #4 ScChart2DataSequence::~ScChart2DataSequence() sc/source/ui/unoobj/chart2uno.cxx:2458:1
            #6 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #8 com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence>::~Reference() include/com/sun/star/uno/Reference.hxx:114:22
            #9 chart::LabeledDataSequence::~LabeledDataSequence() chart2/source/tools/LabeledDataSequence.cxx:89:1
            #11 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #12 cppu::WeakImplHelper<com::sun::star::chart2::data::XLabeledDataSequence2, com::sun::star::lang::XServiceInfo>::release() include/cppuhelper/implbase.hxx:115:66
            #13 com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence>::~Reference() include/com/sun/star/uno/Reference.hxx:114:22
            #20 chart::DataSeries::~DataSeries() chart2/source/model/main/DataSeries.cxx:218:1
            #24 chart::DataSeries::release() chart2/source/model/main/DataSeries.cxx:537:1
            #25 rtl::Reference<chart::DataSeries>::~Reference() include/rtl/ref.hxx:129:22
            #32 std::__debug::vector<rtl::Reference<chart::DataSeries>, std::allocator<rtl::Reference<chart::DataSeries> > >::clear() /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/debug/vector:720:9
            #33 chart::ChartType::~ChartType() chart2/source/model/template/ChartType.cxx:65:19
            #34 chart::ColumnChartType::~ColumnChartType() chart2/source/model/template/ColumnChartType.cxx:134:2
            #36 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #38 chart::ChartType::release() chart2/source/model/template/ChartType.cxx:330:1
            #39 rtl::Reference<chart::ChartType>::~Reference() include/rtl/ref.hxx:129:22
            #46 chart::BaseCoordinateSystem::~BaseCoordinateSystem() chart2/source/model/main/BaseCoordinateSystem.cxx:185:1
            #47 chart::CartesianCoordinateSystem::~CartesianCoordinateSystem() chart2/source/model/main/CartesianCoordinateSystem.cxx:53:2
            #49 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #51 chart::BaseCoordinateSystem::release() chart2/source/model/main/BaseCoordinateSystem.cxx:406:1
            #52 rtl::Reference<chart::BaseCoordinateSystem>::~Reference() include/rtl/ref.hxx:129:22
            #53 chart::VCoordinateSystem::~VCoordinateSystem() chart2/source/view/axes/VCoordinateSystem.cxx:89:1
            #55 chart::VCartesianCoordinateSystem::~VCartesianCoordinateSystem() chart2/source/view/axes/VCartesianCoordinateSystem.cxx:69:1
            #65 chart::ChartView::impl_deleteCoordinateSystems() chart2/source/view/main/ChartView.cxx:1091:20
            #66 chart::ChartView::~ChartView() chart2/source/view/main/ChartView.cxx:1085:5
            #68 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #70 rtl::Reference<chart::ChartView>::~Reference() include/rtl/ref.hxx:129:22
            #71 chart::ChartModel::~ChartModel() chart2/source/model/main/ChartModel.cxx:183:1
            #73 cppu::OWeakObject::release() cppuhelper/source/weak.cxx:230:9
            #75 rtl::Reference<chart::ChartModel>::clear() include/rtl/ref.hxx:196:19
            #76 chart::CreationWizardUnoDlg::disposing() chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:235:19
            #77 cppu::OComponentHelper::dispose() cppuhelper/source/component.cxx:161:17
            #78 chart::CreationWizardUnoDlg::notifyTermination(com::sun::star::lang::EventObject const&) chart2/source/controller/dialogs/dlg_CreationWizard_UNO.cxx:140:5
            #79 framework::Desktop::impl_sendNotifyTerminationEvent() framework/source/services/desktop.cxx:1649:79
            #80 framework::Desktop::terminate() framework/source/services/desktop.cxx:282:13
        
        0x61e00007a13e is located 2238 bytes inside of 2712-byte region [0x61e000079880,0x61e00007a318)
        freed by thread T53 here:
            #0 0x4fe267 in operator delete(void*) (instdir/program/soffice.bin+0x4fe267)
            #1 ScDocShell::~ScDocShell() sc/source/ui/docshell/docsh.cxx:2899:1
            #2 SvRefBase::ReleaseRef() include/tools/ref.hxx:163:29
            #3 tools::SvRef<SfxObjectShell>::~SvRef() include/tools/ref.hxx:56:36
            #4 IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() sfx2/source/doc/sfxbasemodel.cxx:245:5
            #12 SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:757:13
            #13 SfxBaseModel::close(unsigned char) sfx2/source/doc/sfxbasemodel.cxx:1482:5
            #14 SfxBaseModel::dispose() sfx2/source/doc/sfxbasemodel.cxx:718:13
            #15 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
        
        Change-Id: I4ac7a702c50f9519a0f982ece9776c2d449c43ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132242
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-29  Miklos Vajna  <vmiklos@collabora.com>  [6d11a12464fd5349869875ff6a4b5dfb78c444fa]

        sw doc model xml dump: don't warn on SwFormatMeta
        
        No need to dump it for now, just silence the warning.
        
        Change-Id: I3f09f6198732aacfd7173f8f81f9df220bb59bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132257
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-29  Caolán McNamara  <caolanm@redhat.com>  [7684e31b16408b8a2f36ea2aa733d45bd40f5bc6]

        cid#1503287 silence Unchecked dynamic_cast
        
        Change-Id: Id7c6c1ecbfc88c97d5211826fa2d831344dc795c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132245
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-29  Caolán McNamara  <caolanm@redhat.com>  [1f83834bd0d78232762f7467a65ebdf0d4b9f7fa]

        cid#1503286 Unchecked return value
        
        Change-Id: I701039be73405e354fc64bd6a81999aff44e9e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-29  Luboš Luňák  <l.lunak@collabora.com>  [890b0482641bccd8281e4a952e8b8fe26fc745bd]

        initialize output parameter of ScFormatRangeStyles::GetStyleNameIndex()
        
        ScMyDefaultStyles::FillDefaultStyles() calls this in a loop and compares
        with previous.
        
        Change-Id: Iba3420023e16c3091f4695640251a5525b28f467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132199
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-29  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [a2d49b680cd026c3d64683f6ee3ba97e9834a7f7]

        tdf#147906 change sqrt(a * a + b * b) occurences to std::hypot(a, b)
        
        Change-Id: Ic84899bf34f98382e6cc1ffc14310b1667279ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132214
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-29  Miklos Vajna  <vmiklos@collabora.com>  [4cdb50923ed00b9219a9f4cb36693b3a8c444f7c]

        sw: document AbstractSwBreakDlg
        
        AbstractSwBreakDlg is implemented by AbstractSwBreakDlg_Impl, which
        wraps an SwBreakDlg, a bit complex at first.
        
        Change-Id: I366bb16b13a6343a45d5538f79ddff729fe31acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132241
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-29  Stephan Bergmann  <sbergman@redhat.com>  [f24756b2d3fe8b8dcb49c9351ca1d40e034b440b]

        -Werror,-Wunused-but-set-variable
        
        ...ever since f47a9d9db3d06927380bb79b04bb6d4721a92d2b "initial import"
        
        Change-Id: I5ae9d757270c69003899a3eaf825acbfc48ea047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132239
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [9ee8b709594d2d106dc6ba7b7cac5a7e4300609c]

        qt a11y: Handle TABLE_MODEL_CHANGED event
        
        Note however, that as of now, this doesn't
        have any effect in practice, since
        `AtSpiAdaptor` for Linux in the Qt library
        currently just ignores `QAccessible::TableModelChanged`
        events instead of forwarding them as corresponding
        AT-SPI events. [1]
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?id=9a4c32cedda3a00e06eb3aed13a731d23f6c56d9#n1105
        
        Change-Id: I6339d172da54bc30987bb9261ce37005ebce5501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132222
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [f622149cb2ee3a8259f8e8f3b013ca5b4b5e1d80]

        a11y: Drop unused, deprecated table model change event types
        
        All places that were previously emitting
        `AccessibleTableModelChangeType::INSERT`
        and `AccessibleTableModelChangeType::DELETE`
        events have been ported to emit
        the 4 new event types introduced in
        Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89,
        "a11y: Add new table model change types for row/col insertion/del"
        instead.
        Therefore, the handling of those events can be
        dropped from the gtk3 VCL plugin and for macOS's
        a11y listener as well.
        
        Also, drop the now completely unused
        constants from the IDL file as mentioned
        in Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89:
        
        > From a UNO API perspective, this change
        > and the final removal of the
        > `AccessibleTableModelChangeType::DELETE`
        > and `AccessibleTableModelChangeType::INSERT`
        > constants in a follow-up commit
        > should be unproblematic, because the
        > corresponding APIs have been unpublished in
        >
        >         commit 70626249cd247d9acdad417b8eaf252bae22c059
        >         Date:   Thu Nov 29 00:27:03 2012 +0100
        >
        >             API CHANGE a11y unpublishing and add/removeListener rename.
        
        Change-Id: I1c062e26481b916af882e301c5f911aba9550ea3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132221
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [623c8502a5af5c0061f5285e8c0c4ac973990b7c]

        sc a11y: Fix + port events for row/col ins/del
        
        Previously, incorrect indices were sent
        when inserting or deleting rows or columns from
        a Calc spreadsheet,
        e.g. when deleting rows 4 to 12 (i.e. rows with
        indices 3 to 11), the pyatspi script from
        Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89,
        "a11y: Add new table model change types for row/col insertion/del"
        would have this output:
        
        > object:row-deleted(12, 10, 0)
        >         source: [table | Sheet Sheet1]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        > object:column-deleted(0, 16384, 0)
        >         source: [table | Sheet Sheet1]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        
        i.e. LO would announce the deletion of all columns
        and the deletion of 10 rows, starting at index 12,
        which is obviously wrong.
        
        For the case where rows or columns have been deleted,
        the range in the update hint passed to
        `ScAccessibleSpreadsheet::Notify` is the spreadhseet
        range after the removed rows/columns; for the case where
        rows or columns have been inserted, the range
        in the update hint is from the first inserted
        row/column to the last row/column in the spreadsheet.
        
        So, calculate the indices of the actually inserted/deleted
        rows/columns from that.
        Also, switch to using the table model change event types
        introduced in the change mentioned above.
        
        With this in place, output of the Python script
        for the above case now is as expected
        (9 rows, starting at row index 3, have been
        deleted):
        
        > object:row-deleted(3, 9, 0)
        >         source: [table | Sheet Sheet1]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        
        Deletion of non-contiguous row/column ranges (e.g.
        deleting columns A to C and F to H) also results in
        the correct events getting sent, since
        `ScAccessibleSpreadsheet::Notify` gets called multiple
        times, once for each contiguous cell range.
        
        Change-Id: I6e61eb45f255741661b29efb72394029109d682e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132220
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [579f3d91c98cc35961538628c772e74b2f7df85a]

        sc a11y: OSL_ENSURE -> assert
        
        Change-Id: I79f477c950e0aca75e2a6041c5fb6a78be4b07c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132219
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [5a9340bceeee0e20817ecf23dc1e12653751ca1d]

        a11y: Use new table model change types for row/col ins/del
        
        This ports most existing uses of the now deprecated
        `AccessibleTableModelChangeType::INSERT` and
        `AccessibleTableModelChangeType::DELETE` to emit
        events of the the four new table model change types
        added in
        Change-Id I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89,
        "a11y: Add new table model change types for row/col insertion/del"
        instead, which among others fixes the a11y events that are sent
        on the platform level for gtk3 and macOS,
        s. commit message of the mentioned change for more details.
        
        From all I can see, `AccessibleGridControlTable::commitEvent`
        is just meant to handle removal of rows, not columns,
        so add a corresponding assert there.
        (See how only row-related a11y events are emitted
        in `svtools/source/table/tablecontrol_impl.cxx`,
        and the "columns aren't selectable" comment for
        `AccessibleGridControlTable::isAccessibleColumnSelected`.
        Given that the full range of rows would previously
        have been sent in the `AccessibleTableModelChangeType::DELETE`
        event for column removal, this should still have worked in
        practice, since this would have cleared the whole vector,
        and elements would have been inserted on demand as needed
        again later. However, if that should ever be needed in
        the future, it should be handled more explicitly.)
        
        The handling of sending events when rows or columns
        are inserted or deleted in a Calc spreadsheet is more
        fundamentally broken and will be handled in a separate
        commit.
        
        Change-Id: Icfd5e326143e8e90cc513e430bfabbba39e7bdc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132218
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Michael Weghorn  <m.weghorn@posteo.de>  [5371eef48a34acd06307a7b2bf898586938e27ff]

        a11y: Add new table model change types for row/col insertion/del
        
        So far, there were two types/constants
        to use in an `AcessibleTableModelChange` event to indicate
        the insertion or deletion of rows and/or columns. From
        `offapi/com/sun/star/accessibility/AccessibleTableModelChangeType.idl`:
        
        >     /** One or more rows and/or columns have been inserted.
        >
        >         <p>Use the fields of the AccessibleTableModelChange
        >         structure to determine the indices of the rows and/or columns that
        >         have been inserted.</p>
        >     */
        >     const short INSERT = 1;
        >
        >     /** One or more rows and/or columns have been deleted.
        >
        >         <p>The affected area of the table is stored in the fields of the
        >         AccessibleTableModelChange structure.</p>
        >      */
        >     const short DELETE = 2;
        
        From the documentation, it would be possible to indicate an
        insertion or deletion of both, rows and columns in a single
        event. However, there is no single instance where this is
        actually used to indicate the deletion/insertion of
        both, whole rows and whole columns at the same time.
        
        The way that indices are currently used is rather confusing
        and results in incorrect a11y events being sent on maOS as well
        as the gtk3 VCL plugin:
        
        When only rows are inserted, row indices are set as expected
        (index of the first and last inserted row), but the column
        indices are set to the first and last column in the table;
        i.e. the indices actually give the range of the newly
        inserted cell range, rather than just the indices of the rows
        that have been inserted. (The same applies
        the other way around when only columns are inserted.)
        That's not what I would have expected when reading the
        documentation. ("Use the fields of the AccessibleTableModelChange
        structure to determine the indices of the rows and/or columns that
        have been inserted.")
        
        In the same way, the range of deleted cells is set
        when emitting `AccessibleTableModelChangeType::DELETE` events.
        In this case, this can be seen as matching what the
        documentation says. ("The affected area of the table is
        stored in the fields of the AccessibleTableModelChange
        structure.")
        
        In any case, the way that the events are handled
        in the gtk3 VCL plugin and for macOS results in
        the emission of incorrect events,
        since those are handling such indices as if both,
        rows and columns had been inserted/deleted.
        
        Example for the gtk3 VCL plugin:
        Row with index 1 has been deleted from a table.
        
        -> an AccessibleTableModelChange event is sent with
        
            Type=AccessibleTableModelChangeType::DELETE
            FirstRow=1
            LastRow=1
            FirstColumn=0
            LastColumn=<index of last column>
        
        This would then result in 2 AT-SPI events being
        emitted by the gtk3 VCL plugin:
        
        * one that indicates that row 1 has been deleted (OK)
        * another event that indicates that all columns have been
          deleted (NOT OK)
        
        Instead of changing the handling of the existing
        `AccessibleTableModelChangeType`s, introduce 4 new
        types to replace the existing ones that
        don't mix handling of rows and columns at
        the same time: one for row insertion,
        one for column insertion, one for row deletion,
        one for column deletion.
        
        This commit also adds handling for the newly added
        change types for macOS and the gtk3 VCL plugin on
        Linux.
        
        winaccessibility is unaffected because
        it doesn't have any handling specific
        to the change type.
        The qt5/qt6 VCL plugins don't yet have any
        handling for the `AcessibleTableModelChange`
        event yet (but that will be added in a follow-up
        commit).
        
        Existing uses of
        `AccessibleTableModelChangeType::INSERT` and
        `AccessibleTableModelChangeType::DELETE` will
        be migrated to use the new types in
        follow-up commits.
        
        From a UNO API perspective, this change
        and the final removal of the
        `AccessibleTableModelChangeType::DELETE`
        and `AccessibleTableModelChangeType::INSERT`
        constants in a follow-up commit
        should be unproblematic, because the
        corresponding APIs have been unpublished in
        
                commit 70626249cd247d9acdad417b8eaf252bae22c059
                Date:   Thu Nov 29 00:27:03 2012 +0100
        
                    API CHANGE a11y unpublishing and add/removeListener rename.
        
        The following Python script was used in follow-up
        commits to check that AT-SPI events with the expected
        indices are retrieved with the gtk3 VCL plugin after
        porting existing uses of
        `AccessibleTableModelChangeType::INSERT` and
        `AccessibleTableModelChangeType::DELETE`.
        
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if e.host_application.name != 'soffice':
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, "object:row-inserted", "object:column-inserted", "object:column-deleted", "object:row-deleted")
            pyatspi.Registry.start()
        
        Change-Id: I30821a5acafa4f3d1dafdfc219f3b4568d9a6e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132217
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-29  Aron Budea  <aron.budea@collabora.com>  [5d0965f3f12fedb2228ba28f261a90245e343c09]

        sc: fix crash in SdrPageView::GetPageWindow()
        
        From online crashreport:
        
        SIG   Fatal signal received: SIGSEGV
        
        SdrPageView::GetPageWindow(unsigned int) const
        		svx/source/svdraw/svdpagv.cxx:84
        (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact(basegfx::B2DVector&, sdr::contact::ViewObjectContact const&) const
        		sc/source/ui/view/gridwin4.cxx:1397
        sdr::contact::ViewObjectContact::getGridOffset() const
        		svx/source/sdr/contact/viewobjectcontact.cxx:463
        sdr::contact::ViewObjectContact::getPrimitive2DSequence(sdr::contact::DisplayInfo const&) const
        		include/basegfx/tuple/b2dtuple.hxx:81
        sdr::contact::ViewObjectContact::getObjectRange() const
        		svx/source/sdr/contact/viewobjectcontact.cxx:198
        
        ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact()
        didn't check if PageWindowCount() was non-zero.
        
        Change-Id: I4a00b5b13a277d0805af3076150a952306908e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132251
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-03-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a6a0b8cde3fa8673ea5ded216f9e007a496c9a88]

        sc: set default parameters in SparklineGroup
        
        The colors are set to COL_TRANSPARENT except for the series color,
        which is set to COL_BLUE by default. Other parameters are set to
        their default values according to OOXML specs.
        
        Change-Id: I67ceab2ffd723511fbf0616cca661992f0a8cf69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131920
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-29  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4e37bb2e7b7c84457e2f44e3a9a0d47b96a603af]

        sc: refactor sparkline struture to store a list of sparklines
        
        We need to access a list of sparklines and sparkline groups for
        a sheet. To preven going through all the columns of a sheet, we
        need to store all the created sparklines in a list. For this it
        is necessary to change the model structrue a bit. A cell now has
        a container that stores a shared_ptr to the sparkline instead of
        storing the sparkline directly. With this we can store a list
        of weak_ptr to the sparklines in a list (vector), which can be
        accessed at any time and is quite fast.
        
        This is needed by the OOXML export.
        
        Change-Id: Iaca0a41e20912775f072ea6e8cab9c44367d6f30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131919
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [76a7e73ad72b1319e3c350f5245eea741926e042]

        Colibre: Add some inner shapes
        
        Change-Id: Ic383567a3274d59f9208130adbc2b278fb3de6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132246
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [33e5934c601930303f507d4c767cca88ffbe937a]

        Colibre: Simplify db related icons, update filter icons
        
        Change-Id: I888cb880a7dd17de63b86517b1d968be1e081d6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132247
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [60fc8c31beae4e822601ab9e7ea1cb0191c6f66b]

        -Werror,-Wunused-but-set-variable
        
        ...since 777e3930a1e85b9bc97c1852b09802fc389c5e2d "Move the code for "fill
        simple" to its own method."
        
        Change-Id: Iea240530696b89f56fba314b599e7cd43ce6a780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132231
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [25b977b0502b6b84596f57d03862cdba9ca760dc]

        -Werror,-Wunused-but-set-variable
        
        ...ever since bc712935a05dd34142b4c17dd6686761d9b9d5e1 "TableRef: refresh table
        column names before saving"
        
        Change-Id: I7537fa3632ff03f73d36eaf9fc6ba0ab73319cab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132232
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [688453cc94bc7e6ee2d444e97ec68ff62fcf2fa3]

        -Werror,-Wunused-but-set-variable
        
        ...ever since d9dd003f63a781e63bfbe380ea737e080c21881f "tdf#143103 Support Color
        Filter in 'Standard Filter' dialog"
        
        Change-Id: I04441f4d812e3598b5b91e3bf915315a11ab6e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132233
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [e199f252ed50a02a935108da2da9947ccd08355d]

        -Werror,-Wunused-but-set-variable
        
        ...since df50b02cd3177570bb26484a03273ba5caa50037 "weld ScFilterListBox"
        
        Change-Id: I02e835bb9de373fea7891babbce5eec605455198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132234
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [37dc769a410ba99c81066658b343562ee7fd1466]

        -Werror,-Wunused-but-set-variable
        
        ...ever since c97f9af5e47ea234ad709a1f66c1e8ed20640066 "tdf#129708 speed-up:
        reuse enumeration for each effect"
        
        Change-Id: Ice1a613676f25e3a63a3479548538d33f1b5ee47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132236
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [468ccb89e246744c740bc1efd5a33249d08dd1b2]

        -Werror,-Wunused-but-set-variable
        
        ...ever since 24da580f8bd0a348fee64c07f9015b09918f8388 "95584#; add RangeId to
        have the draw ranges unique"
        
        Change-Id: I60e98b9645eb4acb2d3d4e47ada81c976e43a424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132235
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [1e84c0b8d161e05c19c3aa227cbf7de15cc363a3]

        -Werror,-Wunused-but-set-variable
        
        ...which was apparently meant as a "Possible debugger breakpoint" in
        DBG_UTIL-only sw_DebugRedline.  The obvious fix is to mark nDummy as volatile,
        but increment of a volatile variable is deprecated, so replace those with reads
        of the variable, but which triggered false loplugin:casttovoid so fix that too.
        
        Change-Id: I07376e665caa4fd9befaba06d261a50df7a63a10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132237
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [43cff69eed2657c3287221b4f37a2543eb1b6f98]

        -Werror,-Wunused-but-set-variable
        
        ...since db51589575d37ca608067ad9904dcc6a09651e8c "Convert SVARRAY SORT into STL
        set"
        
        Change-Id: I50384d67252965beb46a9dad5a30df835188f3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132238
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [3da00be8cf0e434eae6db83c2089974c9ba86230]

        -Werror,-Wunused-but-set-variable
        
        ...since fa44673e154ed4fb0b518b8850e2f6e4b9069531 "bnc#885548: Adjust xlsx
        export of revisions to get it to work in Excel."
        
        Change-Id: I4e9c8d176cc5bd3ff1f374fcbcf16c738ebf2388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132240
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [2866b1a84e2667c9dd58955d3cd73b262ff6860b]

        -Werror,-Wunused-but-set-variable
        
        ...since 376cc3ea0fc2e0f209763a2a27c5852136332c86 "dbaccess: delete old paste
        autoincrement logic"
        
        Change-Id: I4ffa3ffbcc1b80091a4a3449362766334b31c5af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132229
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e506bf303c830e974e3b9972887d2c5ec0dbf480]

        sw: use getProperty<Color> when possible
        
        Change-Id: I50339493b0034667e9cd317940102b13066f901c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132203
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ac77243a1abd4d3084866482c407f6744faeced7]

        Colibre: Add some inner shapes
        
        Change-Id: I91ada6c8fca9e54fb5ee954abace04ed6e46c090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132227
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [91b45312b97ec272dfbbf5a01bd81d3db480e2aa]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes
        
        (fontwork shapes)
        Change-Id: Iee022e5b8051043d920f0b75c5c5a1a99bff889f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132215
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-28  Caolán McNamara  <caolanm@redhat.com>  [4085bbbb895060f085a58e6275201015b84e3532]

        forcepoint#94 fix crash on layout of specific html
        
        Change-Id: I1874a431d5af9d56248a695e08a2f95b5292ba9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132153
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [5b3c7ad096193ede848c2ad216d48160e266adbd]

        -Werror,-Wunused-but-set-variable
        
        ...since 0b6d0ac41afc72a0043e6ccdc6cdfd8648a5efdc "m_pRowMarker is unused"
        
        Change-Id: I68d23a11e4be814a23e8ede87723b9aba208b774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132228
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [014819fcb08c1413526f2e2b2dbe731bf9d173f3]

        -Werror,-Wunused-but-set-variable
        
        ...ever since 3c3a371c799d00475deb13b4c3e0a8860c7e4fb3 "tdf#125254 Performance:
        A spreadsheet opens too slow, part2"
        
        Change-Id: Ie04e72155b306f6d5e95abf09623d819ee21cdf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132230
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [a59cf3db7088b41ea7d2863335cde9c3d5fec469]

        Reduce variance in what Jenkins Gerrit builders pick up from their environment
        
        e.g., <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114702/> on tb91
        apparently picked up --enable-dconf and --enable-python=system (and failed, for
        unclear reasons), while a corresponding
        <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114728/> on tb89 didn't
        (and succeeded)
        
        Change-Id: I9ddd66ff7f1c6595a6cce65365f1cb0a07b6d67e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132216
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [a29f0554915bca051ad2fa7388c32b9c8a461099]

        -Werror,-Wunused-but-set-variable
        
        ...since its uses got commented out with
        a9cc0100645deea53f27e35c7e754c9f062680d8 "chart2: Weld ChartTypePanel"
        
        Change-Id: I5296ba7ed746df13e8174063f148ff2ce970756c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132224
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [04ccd3fab8e620633a11c84a642378b0b241c3a0]

        -Werror,-Wunused-but-set-variable
        
        ...since 35dce7a06088386f13636bc355bc35e93be6ba5d "INTEGRATION: CWS warnings01"
        
        Change-Id: Iaae91d7792348d0bf61173c5839295c8aa1b938f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132225
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [82e8160c3bebd89527f83bf24c2cfb2aa892611a]

        -Werror,-Wunused-but-set-variable
        
        ...since f1702aa8e46d63b85cc16e550c96b79509057c89 "INTEGRATION: CWS oj14".
        (Maybe the odd code was there to allow breaking on it with a debugger, and the
        original author wondered whether TypeClass_CONSTANT can actually happen here,
        which it probably can not, so it should probably be replaced with
        O3TL_UNREACHABLE, but that's left for a follow-up.)
        
        Change-Id: I97881b1b35f7de3940400c50b58eb08ca9a746a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132226
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [bc2b283959d4fa76aa0b9f6bea0babbd5a296ddd]

        -Werror,-Wunused-but-set-variable
        
        ...since 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox: replace PUT_PROP macro
        with comphelper::makePropertyValue() calls"
        
        Change-Id: Ic90e6e579e0d546454d2acd8c3fb5b5ac50f9f5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132223
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [f41d04817230c8c8cdf56a6c4aba15b6380b323a]

        Advanced Diagram support: Move data classes to svx
        
        As preparation for own im/export move data classes for
        which that is now possible to svx
        
        Made TypeConstant more safe, also sorted it. Corrected an
        error there. Secured TypeConstant usage by identifying
        usages (mnType -> mnXMLType). Had to convert from
        oox::OptValue to std::optional since 1st is not available
        in svx in datamodelcontext.cxx. That makes the test work
        and the test-file load corrrectly.
        
        Change-Id: Ifee008caf486ddb6b52a347dc08e7e053c49ef49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132195
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-28  Julien Nabet  <serval2412@yahoo.fr>  [c168f15a74fbd6231e1bbbe93939d8e26937b517]

        Micro-optim of RTFTokenizer::resolveKeyword
        
        Change-Id: I320df7087e5b9594e7d08a892468ad2cc9a00426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132152
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [630dc472627e4bb56648b4c7326b7bfc8b4b5316]

        -Werror,-Wunused-but-set-variable
        
        ...since 8e73111faeb9620117801fee89a838a407f0b7e5 "CWS-TOOLING: integrate CWS
        ab72"
        
        Change-Id: Ib2fdccc36090d366ca2288b31bd1948832366c95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132210
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  László Németh  <nemeth@numbertext.org>  [eda1a7aeff42c08e02295e5a8353a6d86a61a118]

        tdf#148228 sw: fix Undo of tracked table deletion in Hide Changes mode
        
        In Hide Changes mode, tables didn't reappear during
        Undo of their tracked deletion, only by saving and
        reloading the document.
        
        Follow-up to commit 0c6221e1545e7b96d9df23cdc24302c28ae935b8
        "tdf#148227 sw: fix Undo of tracked row deletion in Hide Changes mode".
        
        Change-Id: Ifdc25ab4ae0be25a0c7559ee05b6af2e4f1aa8cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132169
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [70507d8dabbb92c26a1db116bfb0dc633869d93e]

        -Werror,-Wunused-but-set-variable
        
        ...ever since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter
        to filter"
        
        Change-Id: Ia01b618c57318657976372257ea37ed2b1b354b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132212
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [c2b0438df3a3cb2e948023ce4c0f07d4c25ea76a]

        -Werror,-Wunused-but-set-variable
        
        ...ever since 45c8bbe9303094b50035967846196cf3b7c72ea6 "vcldemo - more clipping
        tests for RegionBand and Polygon cases."
        
        Change-Id: Ia311a6620b618706dde4de178f202f563bd4c012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132211
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Michael Weghorn  <m.weghorn@posteo.de>  [4f9bf4201bb706cd19142f0805cfc4c859186cd4]

        tdf#148235 Restore toolbar item to switch XForm to design mode
        
            commit 45b6f096e7ae86d0692ecdfd5b7069622d8a6efa
            Date:   Sun Oct 28 17:02:34 2018 +0100
        
                sw toolbars sync context toolbars between different apps
        
        had replaced the "Form Design" toolbar item to switch
        a complete XForm to design mode with an entry that
        switches the form controls to design mode instead.
        (The former one is labelled "Design Mode On/Off",
        the latter one just "Design Mode" in the English UI.)
        
        This meant that the XForm could no longer be switched
        to design mode from there, unless the toolbar was
        manually customized to add the entry back.
        
        This brings the previous toolbar item back.
        It also removes the one to switch the form controls
        to design mode again, since that one is already contained
        in the "Form Controls" toolbar, where it fits better.
        (And having two different toolbar items with almost
        identical labels but different functionality would
        probably be rather confusing.)
        
        Change-Id: Ia4c98dfa6ad8372eba08a9f08920153133a7f88d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132207
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [47a3fec2115fcb8066bbb756f8f6391d94dc04bf]

        -Werror,-Wunused-but-set-variable
        
        ...since fb6c99f21e03afb85d00459ca1e1abb07e71d126 "loplugin:unuseddefaultparam
        in svtools"
        
        Change-Id: I08da150389bfe8dad09ca293a8f445020c3a51ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132208
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [f891cecab59179efdb1e3153752f744db0a420ad]

        -Werror,-Wunused-but-set-variable
        
        ...ever since cab1870e677f33a2501f15916110da46d3336d24 "INTEGRATION: CWS
        languageguessing: #i73173# integrate Google SoC language-guessing"
        
        Change-Id: I0abf783944499b6ac8015e37952013d05b273558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132206
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Tor Lillqvist  <tml@iki.fi>  [e889c9b8bfafec4c8aaaa9af899eb0c4df52d897]

        Make slideshow touch gestures work again in the mobile apps
        
        Need to s/lool/cool/ here, too.
        
        Change-Id: Ib6762f196ca2b1c2e8735c6ff3e591164d34fb0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132204
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-28  Szymon Kłos  <szymon.klos@collabora.com>  [a20e761cb1112357bfae35e24b49fae872bce3f6]

        jsdialog: fix toolboxes with children
        
        Don't block JSON generation if toolbox has children...
        Fixes missing sidebar items
        
        Change-Id: I34696d780b4292881792b2190a522610a8b4b597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131696
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132201
        Tested-by: Jenkins

2022-03-28  Szymon Kłos  <szymon.klos@collabora.com>  [15e359b4892736da9332de0350887531008c8ea3]

        Notebookbar style previews: use CJK or CTL fonts if needed
        
        Change-Id: I4757cf7af16a11895ec0c6e71257f2b4f02cda68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132159
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        (cherry picked from commit f7c069e1008949a07481dc56e40bcd82343884dc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132052
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-28  Szymon Kłos  <szymon.klos@collabora.com>  [4a0f92bf62a4aed2fd24bb6b43d045c8b2b2dfdd]

        lok: compatibility with older copy-paste tables
        
        Change:
        commit 41b99644e8913dd4797775f4931382e93fa12a00
        Author: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Date:   Mon Sep 27 11:59:54 2021 +0200
        
            tdf#48622 Add new border line width defaults
        
        introduced regression in the HTML export used in lok.
        It changed expected value of border thickness what
        caused export of many empty additional table rows.
        
        Change-Id: I35045ad4673609b0f092477b4c7f71b057f18774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131702
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132200
        Tested-by: Jenkins

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [8a734ba9287f8d25c3c3df50b4efc91b9035127d]

        Drop support for OpenGL denylist on X11
        
        ...which appears to have become even less relevant with
        db89f53c31af997b9bf422b0e784afba8d62a42e "remove OpenGL VCL backend code".  And
        the vcl/unx/glxtest.cxx machinery that it is based on is (a) known to cause
        issues like <https://gitlab.freedesktop.org/mesa/mesa/-/issues/3957>
        "LibreOffice's OpenGL version detection code hangs when running inside a flatpak
        container with a different mesa version", and (b) is one of the two reasons why
        an soffice that uses Wayland nevertheless also requires Xwayland during startup
        (the other reason being oosplash).  So getting rid of the glxtest machinery is
        beneficial.
        
        The remaining two potential uses of OpenGL on X11/Wayland are the obscure
        css.rendering.SpriteCanvas.OGL service implementation (about which
        db89f53c31af997b9bf422b0e784afba8d62a42e states that "it seems has never been
        finished or enabled (or so it most probably should be dumped too)") and some
        slideshow transitions.  About the latter, Caolán stated on IRC:  "I think we
        grew this set of stuff to check for dodgy opengl primarily for the case where
        vcl used opengl for ordinary UI optimizations; but I think that use is gone now
        so I wonder does it make sense to just drop all of that entirely; for just slide
        transitions we apparently survived fine without the denylist for ages".  (And in
        any case there is still the WatchdogThread support with OpenGLZone::hardDisable
        in VCLExceptionSignal_impl, vcl/source/app/svmain.cxx, should any OpenGL code
        run into problems.)
        
        (The removal of gb_LinkTarget_use_glxtest from gb_LinkTarget_use_vclmain, which
        indirectly brought in gb_LinkTarget_use_libraries,*,vcl, revealed that an
        explicit use of vcl was missing from various Executables etc., which thus had to
        be added now.)
        
        Change-Id: Ifa5220fd09910a4459ca546d9655e479a2e38f1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131943
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Gabor Kelemen  <kelemeng@ubuntu.com>  [6b147d3369ece427e490d3108de6ec9f7448c570]

        Recheck sw/ cxx files with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I8a8df68946297fad517b753d73e4373203a45ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132150
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-28  Hossein  <hossein@libreoffice.org>  [ff0783ce6c74178ae44d6b5e402b0feecff918a9]

        tdf#146523 Fix editable protected drop-down fields
        
        Previously, drop-down fields from a protected section in a Writer
        document could be edited by double-clicking on them. This patch adds
        a check to see if the appropriate section is protected or not. This
        check is done before allowing LibreOffice to open a popup window
        titled "Drop-down Form Field" for editing the list of possible
        values.
        
        Also, with this patch, menu item "Form > Control Properties..." will
        no longer do anything for the fields in a protected section.
        
        Change-Id: I02a23818bd315abd61118f199c72ac28b7ed1ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128256
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-28  offtkp  <parisoplop@gmail.com>  [ab9896bfda4d2ef16f3cbb373edced33f9021492]

        tdf#147906 change all sqrt(a * a + b * b) occurences to std::hypot(a, b)
        
        Other changes:
        In Splines.cxx, no longer divides dx, dy with fDiffMax because we
        switched to std::hypot, and hypot avoids intermediate overflows.
        
        Change-Id: I8c459a0e56deb86606fc9b1bf3e68b132a60705d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132073
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2f2df626117380427d2e5e8417316f52823f1e6f]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes (flowchart shapes)
        
        Change-Id: Ic4cb480ec1e93cae3af86bff082bc4aec515ea46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132167
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-28  Aron Budea  <aron.budea@collabora.com>  [c5160e2151cf9d5f1fac9975caeac10f9c40158d]

        tdf#147014 Image missing due to integer overflow
        
        32-bit awt::Point/Size/Rectangle cannot fit size of 1M rows with
        larger (eg. 5x the usual) height, and could overflow.
        
        This causes problems in 64-bit Linux builds and, since the
        following commit, in 64-bit Windows builds:
        3d90997fb6f232d8008df4d166d7b97b869c200f
        
        For now, clamp possibly overflowing values to 32-bit.
        
        Change-Id: Ifda7265703388abdfb47f523da4f0c5822358404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129876
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [0792b859147d752bf298eb146ec3b2638cff8bf0]

        Adapt loplugin:singlevalfields to AtomicExpr
        
        > AtomicExpr 0xcb01120 'std::__detail::__platform_wait_t':'int'
        > |-ImplicitCastExpr 0xcb01108 'std::__detail::__platform_wait_t *' <LValueToRValue>
        > | `-MemberExpr 0xcb01048 'std::__detail::__platform_wait_t *' lvalue ->_M_addr 0xcafd9c8
        > |   `-CXXThisExpr 0xcb01038 '__waiter_base<_Tp> *' implicit this
        > |-IntegerLiteral 0xcb01098 'int' 5
        > `-IntegerLiteral 0xcb01078 'int' 1
        > AtomicExpr 0xd1e2d08 'std::__detail::__platform_wait_t':'int'
        > |-ImplicitCastExpr 0xd1e2cf0 'std::__detail::__platform_wait_t *' <LValueToRValue>
        > | `-MemberExpr 0xd1e2cc0 'std::__detail::__platform_wait_t *' lvalue ->_M_addr 0xcb02bf8
        > |   `-CXXThisExpr 0xd1e2cb0 'struct std::__detail::__waiter_base<struct std::__detail::__waiter_pool> *' implicit this
        > |-IntegerLiteral 0xcb01098 'int' 5
        > `-IntegerLiteral 0xcb01078 'int' 1
        > error: 'error' diagnostics seen but not expected:
        >   File ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/atomic_wait.h Line 312: oh dear, what can the matter be? [loplugin:singlevalfields]
        >   File ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/atomic_wait.h Line 312: oh dear, what can the matter be? [loplugin:singlevalfields]
        
        Change-Id: I71c43b482aaa0992b7ce131d27e262b8e3b4087f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132160
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-28  Miklos Vajna  <vmiklos@collabora.com>  [e799ebfd7a2deab13b47092807335670abb7b485]

        sw clearing breaks: add layout support for the left and right cases
        
        This means that the vertical position calculated in SwTextFly now depend
        son the horizontal position of the break portion, so it doesn't make
        sense to cache it.
        
        Change-Id: I4e30bb12d9ba117d3af065881a65a1c2001e1164
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132162
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-28  Miklos Vajna  <vmiklos@collabora.com>  [6624721b3226ace33f5032b1c1ce595c19f1915c]

        sw: WW8PLCFpcd, WW8PLCFpcd_Iter, WW8PLCFspecial and WW8PLCFx
        
        See tdf#94879 for motivation.
        
        Change-Id: I6c65fc584292f95bbf7ab24c5d94a41c2fa7576a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132161
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-28  László Németh  <nemeth@numbertext.org>  [0c6221e1545e7b96d9df23cdc24302c28ae935b8]

        tdf#148227 sw: fix Undo of tracked row deletion in Hide Changes mode
        
        In Hide Changes mode, table rows didn't reappear during
        Undo of tracked deletion of table rows, only by saving
        and reloading the document.
        
        Follow-up to commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes"
        and commit 794fd10af7361d5a64a0f8bfbe5c8b5f308617a5
        "tdf#147347 sw: hide deleted table at deletion in Hide Changes".
        
        Change-Id: I7ffe8a3687d1d385a549f7d438f7058d829ffd8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132123
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-28  Stephan Bergmann  <sbergman@redhat.com>  [7f6263c14bc062e858a3da3dd8c60ac8ddb1254e]

        Operate on VCL Menu with SolarMutex locked
        
        ...as such VCL code presumably expects to only be called when SolarMutex is
        locked, but which is not necessarily the case here for the ~VCLXMenu UNO object
        destructor.  (I ran into this with a tentative commit for tdf#147668 "Writer
        crashes shortly after loading document with LanguageTool extension active",
        which would have added DBG_TESTSOLARMUTEX() to some GtkSalMenu code indirectly
        called from within mpMenu.disposeAndClear() here, and where this VCLXMenu object
        was held by Java extension code, so the destructor call happened on some JVM
        asynchronous finalizer thread, outside any SolarMutex lock.)
        
        Change-Id: Ia2c3ebec837275cfdf1548f22cfa33f0752e8ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132125
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2816f498505bab01bc0f17ef0962ece663c607c9]

        Fix typo in code
        
        Change-Id: I9a67be63e92864d2e8c8578cf8759d73f5042ab8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132144
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f46068f963ab546f2f125e130ccd88bd119aa794]

        Fix typos
        
        Change-Id: I003bd994be4a6a089dfacca1558e84324bf7fc1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132145
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-27  Caolán McNamara  <caolanm@redhat.com>  [258ef8776637519c84365b8a58446d64716b2b43]

        forcepoint#92 fix crash on layout of specific doc
        
        Change-Id: Id40d25d05d10d641d071cddd2e1c84594ac777a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-27  Caolán McNamara  <caolanm@redhat.com>  [c19c582913c678cb88d97f908bb749072e6bd340]

        move DeleteListener contraptions to toplevel writer includes
        
        Change-Id: Ifa1e75b62da4174f27fca52eb86559cd6a381513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [164fd1e83d74d348083dc43bc8195b7635b157d3]

        Colibre: Fix contrast
        
        Change-Id: I36c03b424b34151b5b5d6367cb9c150deff89402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132140
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b15ae924e6c7e1ce9d69dc93e1b5afdb714ae2a9]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes
        
        Change-Id: If0546ad385a016d8d052b69530f9e73e6b177d19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132138
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a59e2ffbd632585293195485bce19bbc3442f9c0]

        Colibre: tdf#148029 Change line only shapes with real intersected shapes
        
        Change-Id: Id31941d9f947ef760fee9d62d1cec06fce513901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132132
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [9d033508af5257aeebbd8c22a053db5e74a814d3]

        tdf#148111: docx std fields: use placeholder text for empty data
        
        It is quite unexpected Word behavior: if data source for sdt field
        exists but contains empty string it is not used. Placeholder is
        inserted instead.
        
        In general behavior is more complex: logic of replacement is defined
        by <w:showingPlcHdr> property and results can vary (see testcase).
        But LO does not support this property correctly yet.
        
        Change-Id: I2ec8efe05f79a01af5d74d21bfcd05f3b19e3970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132096
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-26  Caolán McNamara  <caolanm@redhat.com>  [b07e36ee14c8dae4331fa6c9044fa18760728275]

        ofz#46033 explore ResolutionIndependentLayout as default
        
        Change-Id: I675c197b9fb708fd8d11539068fda00f484aedc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132133
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-26  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [2b56631f9406b29eebcfcbe8dec5348590b4b817]

        Advanced Diagram support: Preparations to make oox-Shape temporary
        
        When we come from the LO-side of things and need to (re)create the
        Diagram, no oox-Shapes can exist by definition. That forces to see
        oox-Shapes as temporary helper objects.
        Since some ModelData is at the oox-Shape after importing a Diagram
        that data needs to be identified and added to the Diagram
        ModelData.
        On the other path, when (re)creating a Diagram from the ModelData,
        oox-Shapes are needed to use the currently existing mechanism
        in the import-Filter to create XShapes froom the oox-Shapes. In
        that path, the Diagram ModelData needs to be applied to the
        newly created oox-Shape.
        For now I have identified e.g. the Text as such data value. In
        the future there may be more ModelData of that type identified
        and may need to be added. To support that, I have added methods
        to do that.
        It may even be feasible in debug builds to add code to compare
        the imported oox-Shape with a temporarily (re)created one to
        allow easier identification of yet missing secured/copied
        ModelData.
        To make that mechanism obligatory I have added code in
        DiagramData::build() that deletes all oox-Shapes which were
        created at Diagam import. This is necessary. That way, the
        (re)creation is used for Diagram re-creation and can be already
        used and tested.
        
        Deleting all oox-Shapes in build() immediately triggered an
        error in a UnitTest: testPictureStrip. This shows that here
        some ModelData in form of BitmapData is not secured - proof
        of concept and what I described above.
        To get forward, I adapted to not delete oox-Shapes when
        Diagram import is executed. Thus, the UnitTests work, and
        the ReCreate can be used to trigger that behaviour. As
        an end result this has to be re-activated. It allows now
        to search and add the missing model data from the test file
        used in that UnitTest.
        
        Change-Id: I6bc39a0898c7be1b4c656875f6d7508c36c9bea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132127
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-26  Caolán McNamara  <caolanm@redhat.com>  [0527446d05059a54130106edb7418a3aa6796d5b]

        --without-system-libfixmath for coverity build
        
        Change-Id: I28ba6fd50d2c97bcdb1f9b56eb416f01813bd175
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132131
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-26  Caolán McNamara  <caolanm@redhat.com>  [be04a8072e4af30ca6ead36aa92d5f380cd9feb9]

        forcepoint#91 fix crash on layout of specific html
        
        Change-Id: I145649e18f382c67ea34290f44fa219b7926127f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Jim Raykowski  <raykowj@gmail.com>  [b000d964fcc8849d10576bf3539bde7729db2eb1]

        tdf#142447 related: SwNavigator: Copy outlines
        
        Change-Id: Ibfc173ab6db3d9cbb1e8c59b515c40f1846f1e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129542
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [8910ab087c90972ce627591fb3206a9434aeac83]

        forcepoint#90 fix crash on layout of specific rtf
        
        Change-Id: I17c227ab278ed5a2cc60449d1d005212f00ded89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132128
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [448fa0bc518e0813b26e5d6c6178444b126bbbb4]

        forcepoint#89 don't remove page with footnote continuation frame
        
        in browse/html/web mode
        
        Change-Id: Ic821dd7f2cc1f47305b5fe2ced16d5168aedc0b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132122
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d4c4e82f1704eb66fb130ae03ee9ad28ddb2067]

        tdf#113541: sc_uicalc: Add unittest
        
        Change-Id: I8c2e2b531ef31b834d7431543c94acfb67ff9ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132113
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [bd769805180c9b0aadca5301e29161c2d84fbe64]

        add support to explicitly test swriter/sweb layout
        
        Change-Id: Ib47526d35428a95b081c88011d733397339f288d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132121
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Stephan Bergmann  <sbergman@redhat.com>  [47e6bf0109c686f71b48c550667af707705a777b]

        Fold MenuBarManager::Destroy into its only call site
        
        ...mainly to demonstrate that its SolarMutexGuard was redundant and that
        replacing it with DBG_TESTSOLARMUTEX() would be overkill
        
        Change-Id: I82f00873cd99cb5da1b644c40ba25f8c210503cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132112
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-25  Luboš Luňák  <l.lunak@collabora.com>  [b8720d1e1f0842d52f1830c48ef7551b1868ae6f]

        fix ScTable::GetLastChangedCol() for unallocated columns
        
        Column flags and widths are stored separately from ScColumn data,
        and so don't depend on allocated columns count.
        
        Also rename the functions from the misleading generic name to what
        they actually do.
        
        Change-Id: If85ae80efda1d8b382fa3b559aa65be0292e25ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132114
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [793fd21a4da5a442cc7130ae04628ffe3181ea6c]

        loplugin:unusedmethods
        
        Change-Id: I42cd6d52bd6c0759fa0a8b1b91bbf1af7eb70ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [21fb34bbb48393d6e631355f1124e5baa2759fcc]

        ofz: Integer-overflow
        
        Change-Id: Ic4a3e8b6d58e19fb93614521a8e0c1ba4dfaa834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132109
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [87259aef31a0411ccc8cb045ceb1365c23e917e5]

        forcepoint#88 temp std::string assigned to std::string_view
        
        Change-Id: I128a60b68a3af988e3a4bdb06994f43d9b18d67e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [32019baffa19a8f79cacf93d5dd5a95c7d416657]

        forcepoint#87 Assertion 'mp_char <= mp_end' failed
        
        Change-Id: I434928cb2425a2e8eb9440dff67f52cda241b2d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [52a9e4f0361e63f744e14f47c7c09b9407320c72]

        loplugin:unusedfields
        
        Change-Id: Ic34f6ac671cd80375085a3c9f858854ff74e2db2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ace70dae44eea914ea460cc2feb49202b61a20fc]

        loplugins ignoreLocation() is unreliable with PCH
        
        Change-Id: Ic12cacb6e058a8725ea6d722399e3afe6ea458c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Regina Henschel  <rb.henschel@t-online.de>  [2029b2f6dd0109c5892e5ac5640022b31fe42fd2]

        tdf#147978 export subpaths individually in custGeom
        
        ...and implement export of all missing commands,
           use existing viewBox if suitable,
           use one EnhancedCustomShape2d
           move WriteCustomGeometryPoint to protected,
           make GetCustomGeometryPointValue local
        
        The fix solves tdf#100390 too.
        
        Without the fix the entire enhanced-path was exported as one element
        <a:path>. The command F was applied to the whole drawing but should
        affect only the subpath. The implementation is changed so that each
        subpath gets its own element <a:path> and command F acts only on its
        subpath.
        
        Support for export of handles and equations is still a long way off.
        Thus there is no reason to tread shapes with and without handles
        different. Shapes with handles had used method WritePolyPolygon, but
        that is not able to handle subpaths. So have desided to use method
        WriteCustomGeometry for all cases.
        
        To get shapes exported regardless of path commands I have added the
        export for the missing commands.
        
        I have removed the no longer used method WritePolyPolygon.
        
        The special treatment of shapes "moon" and "mso-spt89" (right up arrow)
        in export is no longer needed. Related code parts are removed. The
        unit test testFlipAndRotateCustomShape is adapted.
        
        In case the method WriteCustomGeometry fails, the enhanced-path is
        invalid. In that case an minimal custGeom is written in case of docx.
        
        Shapes whose drawing does not touch all edges of the snap rectangle
        were exported with wrong position and size of the drawing inside the
        snap rectangle. That is fixed by using an existing ViewBox for the
        OOXML path size. The old way of creating a path size from point
        coordinates is only used if the shape has no suitable ViewBox.
        
        The point values in unit test SdOOXMLExportTest2::testTdf111798 are
        adapted to path size 21600 x 21600 and traverse direction of the points
        is corrected. The resulting shape outline is still the same as before.
        
        The expected xml is updated for file tdf92001.odp in
        SdImportTest::testDocumentLayout. The resulting shape outline is the
        same, because the shape touches the edges of the snap rectangle.
        
        The case, that the shape outline does not touch a edge of the snap
        rectangle is tested in SdOOXMLExportTest3::testEnhancedPathViewBox.
        
        Still missing is the case, that ViewBox has other left,top than 0,0.
        In that case all coordinates would have to be shifted because the path
        size in OOXML has only width and height but not left,top. That will
        not be included in this patch.
        
        Change-Id: Ib1736d6a08371f4d98411d2769275f0580cd0030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131837
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-25  Justin Luth  <justin_luth@sil.org>  [c4cb1d1dd581a5f120d9cf8b1d4274ec38f3eabe]

        tdf#147861 writerfilter: use GetFieldResult, not current DocProperty
        
        Import DOCX and RTF DocProperty fields as "fixed" if the displayed
        text does not match the File - Properties - Custom variable's content.
        
        Otherwise LO will automatically update the field and show the wrong
        contents (because MS Word requires the user to manually refresh via F9).
        
        Change-Id: Id5d3d0794e81b13465c5e824f1e994f563e62c1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131415
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-25  Miklos Vajna  <vmiklos@collabora.com>  [1fdd27398006baa03c2e45b4ca2412b74ef7ee62]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7fb73ebe42a4f7e5b00583aa38e7bcbd86911d7
          - tdf#145752 Correction to CompatibilityMode() help page
            
            Change-Id: Ie7ca911d8d445c57ad94458711164bdb18be1f13
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129946
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
          - sw clearing breaks: add help for this
            
            Explain what the 3 non-default options do.
            
            Change-Id: Ic94d09dd05dd6319f26120784e7bc6d1025f850c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132118
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-03-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4590048952a9e62124641c512dc2d19122f7fb2d]

        tdf#132924 - Firebird findColumn: return column alias if specified
        
        The function findColumn in a Basic macro should also find aliases for
        columns specified in an SQL query using a Firebird database.
        
        Change-Id: I96adb2564da1e18cee58f1c6803526d8ff4deabb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131990
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [a07e91a5a76546863ccf71462446e8d16d07d21b]

        ofz#45963 Integer-overflow
        
        Change-Id: I4e402a4803013fe2aee0737e1e021e657554403a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132110
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-25  Arnaud Versini  <arnaud.versini@libreoffice.org>  [370b5dbe0d5e62c71b90c795f936dd7c9c240f36]

        bridges : use std::mutex in java brige
        
        Change-Id: I07b215067b1cefc87919680fad3299d702ff6d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Michael Weghorn  <m.weghorn@posteo.de>  [d6ea4b8ffce91d7956cea0267c95ca69e208db24]

        Depend on 64-bit packages for aarch64 as well
        
        As Christian Lohmaier pointed out in [1]:
        
        > When building packages using the epm method, the dependency gets added
        > by instsetoo_native/inc_openoffice/unix/find-requires-x11.sh - and it
        > looks like it should also add the ()(64bit) marker to the dependency
        > when PLATFORMID is linux_aarch64 and not only for linux_x86_64
        >
        > check with rpm -q --provides libXinerama-1.1.3-2.1.el7.aarch64 whether
        > it provides "libXinerama.so.1()(64bit)"
        
        The reply of 2022-03-25T10:41 (public mailing list version
        probably still pending in some moderator queue)
        shows it does:
        
        > [root@1 rpm2]# `rpm -q --provides
        > > ^CbXinerama-1.1.3-2.1.el7.aarch64
        > [root@1 rpm2]# rpm -q --provides libXinerama-1.1.3-2.1.el7.aarch64
        > libXinerama = 1.1.3-2.1.el7
        > libXinerama(aarch-64) = 1.1.3-2.1.el7
        > libXinerama.so.1()(64bit)
        
        [1] https://lists.freedesktop.org/archives/libreoffice/2022-March/088637.html
        
        Change-Id: I1b9a4025399d82ac5f5e51ea5523417e3e6cf395
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132094
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [bcdb92870bdfe6f44b0d571ded756ba59fe09b87]

        tdf#122011: sc: Add UItest
        
        Change-Id: I67938dc8863e5c36bfe9e4a78059d6c467981945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132099
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-25  Julien Nabet  <serval2412@yahoo.fr>  [70cda6eff03ea186bff65318ed8d4cbeff7cbc48]

        tdf#148157: assertion after set "Between tick marks", click outside the chart
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=179065
        
        Change-Id: Id21f52d5cc33bbe99c27b7a8bdff056249c4d4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132027
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ca53dfa9b6d1ccdf632bec23b45bb588021f1e9]

        simplify some TypedWhichId code
        
        Change-Id: I7c908bac2217fb1e1a10dbd1fe8fe4d3cb253eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8334fedbd92da41932ed5c4875fda9fdc19aaad]

        loplugin:constantparam
        
        Change-Id: Id89c74fcd6c6332f5da9f57986bfc2fe075d71c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a5ba6ff05d94065c37324b32fa463c7373a4755]

        loplugin:constantparam
        
        Change-Id: Ic2c93bca1b77c29e547473f889f53a2af8755fe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [891c7fbbf201b90ae65ca0a33e68b1f788cbb7ff]

        loplugin:constantparam
        
        Change-Id: I3a3f78896a1483aa07d2ca2350a7c01ab860083a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Miklos Vajna  <vmiklos@collabora.com>  [eb53efed80302c4ca6409c6dbd023d8ba1eb8e47]

        sw clearing breaks: add clearing indicator during rendering
        
        A left / right line around the break portion now allows seeing if the
        clearing is none, left, right or all (somewhat familiar from Word).
        
        No test for this, SwBreakPortion::Paint() is a NOP unless rendering on a
        window, so the metafile-based rendering used for testing won't detect
        the difference.
        
        Change-Id: I3ff0c89bc4bb45deb03bea43c3ee4589887dee7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132093
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-25  Arnaud Versini  <arnaud.versini@libreoffice.org>  [34df7e2cb95385d513e9c74cda5178e3a68d27df]

        binaryurp: use more std::mutex
        
        Change-Id: I1d16c4cbf60e78323b74e7df049736bd0d0ab591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132072
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [38b8ca62dd07f119ad78f738d706cb1a80e23517]

        loplugin:constantparam
        
        Change-Id: If19a34e7f358e213d8827a107cc744a968ac6c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-25  Gülşah Köse  <gulsah.kose@collabora.com>  [362fb6c7b13d5506c6bd9d1b7f113ec45544809d]

        tdf#96389 Use default tab stop value of MSO for pptx import.
        
        Change-Id: Ib3dde68c672b44d8b60f121fb0e637942b5986b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131698
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-03-25  Stephan Bergmann  <sbergman@redhat.com>  [6e135909d398a08105e2df4cae834e73f253b440]

        tdf#147668: Destroy still needs to do its work when called from disposing
        
        Regression introduced with d4257daba1155ebccbfebea99bad0e4152ca9b08 "use
        comphelper::WeakComponentImplHelper in MenuBarManager" changing
        
        -    if ( rBHelper.bDisposed )
        +    if ( m_bDisposed )
        
        in MenuBarManager::Destroy, but where comphelper::WeakComponentImplHelper sets
        m_bDisposed to true before calling disposing.
        
        And Destroy is only called from disposing, so the check can just be removed.
        
        Change-Id: I2625dff9fbb333435a0d1478b0f285c21cd3ee15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132075
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-03-25  Miklos Vajna  <vmiklos@collabora.com>  [9fd5446c6f3281789ed21847f25cf56ce84dd395]

        sw layout xml dump: handle hole portions
        
        Show their blank width.
        
        Change-Id: I8753c9ea4c861eae4618472f8ea24ea86576f251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132089
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-25  Caolán McNamara  <caolanm@redhat.com>  [e8c95b796626cb9db163f5d563fa67f38a5e92b0]

        ofz: ensure unsigned index
        
        Change-Id: I38d6238a6eede0188f942229b2fb931614e56309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132090
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [be77181b3338ac249ca30b4f18c4d8e9e0a58da3]

        uitest: sc: remove tests not testing anything in particular
        
        these tests were added in 2016 as a demo:
        
        - 8a9861c47b66afed9f9a22ee7f507ba99cd4162a
        "uitest: add demo for chart wizard"
        
        - fc0c5d6163e99d29498c9b8599d9bdf9a3e4ca6c
        "uitest: add demo showing how to deselect an UI object"
        
        - 559f2e233108ed5e9da305ffbf945d6ed568f7eb
        "uitest: add demo showing how to activate chart"
        
        and others.
        They just perform pretty basic actions and they have
        no asserts at all.
        After all these years, there are already other tests
        covering the same actions
        
        Change-Id: I978e28c090cf71a65db4881da96c865080ab9b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132088
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [54e99c0bdea45ee76fd5d10c9712e848a010ed39]

        uitest: add prints to see the current dialog
        
        See
        https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/36931/consoleFull#-156104958948ce9c26-9d0a-43a8-83d8-c44f54920d59
        
        I suspect it might fail because there is a dialog displayed
        
        Change-Id: Ia68b780d5a3881a6e555e6a4bc3086c6c9644749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130793
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [618b38fb406dfc578c60f63d002ecc1cf912a901]

        tdf#39716: sc: Add UItest
        
        Change-Id: Ic28f676d14b21edc1f06b726afbcfc19c8015b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [f34994b20ecede29f03bf6c51bca2d48fda4ad1a]

        tdf#70455: sc_subsequent_filters2: Add unittest
        
        Change-Id: I757bef506eff21071de8b8b40f5e1fc9d82b1ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132083
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [897c3c8308ccfed1001e0ebc7b3461fbc0811f44]

        loplugin:constantparam
        
        Change-Id: Ic5fe48315ed86d72371191df75866b8a1d72b249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e12f49c6c1683f9a7545cc0b7f1082110d27df9]

        loplugin:constantparam
        
        Change-Id: I48abe56cc6be52b2a3cd0998e79e6643f65bbbf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2488029673365f03b14ddd1e4ccb0993dc1be7b7]

        loplugin:constantparam
        
        Change-Id: Ib863ea852792635e521050019a3a190b3eeb681e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132031
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [463c851ac898a81465632d090a1d2c8fcc3ca297]

        loplugin:constantparam
        
        Change-Id: I6bfbd0cb5c2eac60bdac69fd862154fb2f537a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c8e5c2e65aec50ff338ec1967e3865438093fbc8]

        Fix typos
        
        Change-Id: Iccb89d32b83b7f7035557ad7c0634f66f4c947d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132082
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [59352ff39dc5fa0af9cebe3f717cc45a4b321f5d]

        ofz#45991 Timeout, reduce allowed scaling
        
        Change-Id: I559df8ecc2778f6de9406da871941555a81d21eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Jim Raykowski  <raykowj@gmail.com>  [d9f3a656c40e47d23a1c6de427bcdc7511d5249a]

        fix gtk3 combobox up arrow and page up does not select first entry
        
        when popup is not active
        
        Change-Id: I0c4c0841bf0b24cc528d428829ec628e47032fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131882
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-24  Arnaud Versini  <arnaud.versini@libreoffice.org>  [ff3f11a7fa8b7f1096d0bb64a2aa41c4d1edae59]

        gtk3 VCL : remove useless check
        
        Change-Id: I45869f2160435da27f1b30acf41dbee76ce524e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132076
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2022-03-24  Miklos Vajna  <vmiklos@collabora.com>  [1acf8e3cfaf1ef92008e39514a32ace0d036e552]

        sw fields: add Title uno property
        
        The use-case is user fields, which are kind of variables in the
        document. They have a name and a value, but the name might be only
        readable to an extension or macro, not to the user. In this case, it
        makes sense to have a way to specify a user-readable tooltip.
        
        Be consistent with TextFrames which already have a Title property.
        
        Change-Id: I986792f5e55e0b96489347be482d640d155113cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132077
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [d7ba5614d90381d68f880ca7e7c5ef8bbb1b1c43]

        make hash encoding match decoding
        
        Seeing as old versions of the hash may be in the users config, add a
        StorageVersion field to the office config Passwords section which
        defaults to 0 to indicate the old hash is in use.
        
        Try the old varient when StorageVersion is 0. When a new encoded master
        password it set write StorageVersion of 1 to indicate a new hash is in
        use and use the new style when StorageVersion is 1.
        
        Change-Id: I3174c37a5891bfc849984e0ec5c2c392b9c6e7b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [2323fa29617e4919226517d50abbb9ad33b320ca]

        forcepoint#83 forcepoint#84 update to upstream fix
        
        Change-Id: I5add09b4379a1f86a720af75b758389424f4f50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132055
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [28e5cedd9be8f33dcbd95d345c0f530acaecfad4]

        forcepoint#86 RES_TXTATR_UNKNOWN_CONTAINER item put at invalid index
        
        RES_CHRATR_BEGIN is 1, presumably RES_TXTATR_UNKNOWN_CONTAINER should
        be stored in the last index
        
        Change-Id: Id37fff41cbbccbc26fe5ccce6027014af7362729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [400bfd03a97a9af75a55230bffd53fca45a0f3a6]

        tdf#113898: sc_uicalc: Add unittest
        
        Change-Id: I52fa7ad0cb1f9b3d2f72229d961674f6292be60f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132071
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [3756e3145c39ace4454d2569709c2c0d64ad389a]

        CppunitTest_sc_uicalc: combine external reference tests
        
        Change-Id: Ie3bc4dbf69e1b09ebbbb5ffdc4e7a02bc3a7cb02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132069
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [97d53be544fc32f1da294dde133195c5b10588e9]

        tdf#116149: sc_uicalc: Add unittest
        
        Change-Id: I304bbbbd21e818b90b4c4daba26448836e23bc2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132067
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [b658fdc33546f925a2a7406f8588a4aad160e4b8]

        Advanced Diagram support: Continue isolate oox-Shapes
        
        As preparations to use the Diagram ModelData further isolate
        it from the oox-library-only drawingML Shape used for import.
        It is necessary to completely isolate the Diagram ModelData
        from the Diagram import mechanism as a preparation to be
        able to re-create that Shapes on-demand anytime if needed
        for re-layout(s).
        
        Also removed one unused loadDiagram implementation and
        streamlined the AdvancedDiagramHelper some more.
        
        Change-Id: I7a7c55389e0d00f70c02db73ce2c3ff9ce7a5b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132058
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-24  Jean-Pierre Ledure  <jp@ledure.be>  [272a90c45af6ff8f6d5d80c024188b2959efdb93]

        ScriptForge - (SF_Region) new service in the core library
        
        Singleton class implementing the "ScriptForge.Region" service
        Implemented as a usual Basic module
        
        A collection of functions about languages, countries and timezones
        - Locales
        - Currencies
        - Numbers and dates formatting
        - Calendars
        - Timezones conversions
        - Numbers transformed to text in local language
        
        Definitions:
          Locale or Region
            A combination of a language (2 or 3 lower case characters)
            and a country (2 upper case characters)
            Most properties and methods require a locale as argument.
            Some of them accept either the complete locale or only
            the language or country parts.
          Timezone
            Specified as "Region/City" name like "Europe/Berlin",
            or a custom time zone ID such as "UTC" or "GMT-8:00".
            The time offset between the timezone and the
            Greenwich Meridian Time (GMT) is expressed in minutes.
            The Daylight Saving Time (DST) is an additional offset.
            Both offsets can be positive or negative.
        
        Properties:
          Currency
          Language
          Country
          DatePatterns
          DateSeparator
          ThousandSeparator
          DecimalPoint
          TimeSeparator
          ListSeparator
          DayNames
          DayAbbrevNames
          DayNarrowNames
          MonthNames
          MonthAbbrevNames
          MonthNarrowNames
        
        Methods
          UTCDateTime
          UTCNow
          LocalDateTime
          TimeZoneOffset
          DSTOffset
          Number2Text
        
        Change-Id: Iabf31ea0e6c235e960fcca5b1e7a9d928cf8cd0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132068
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [a0202e0b8c5757c3dbb5f0938a4305fbe2db9429]

        loplugin:external
        
        Change-Id: I6b18a514358488ed8a03b42313c3986c2b3fc9df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132021
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Heiko Tietze  <tietze.heiko@gmail.com>  [5b2238ce779c44378f0a86e498eda39f50df3542]

        Resolves tdf#140439 - AutoFormat Table preview not using DOCCOLOR
        
        WYSIWYG preview should use the actual document color instead
        the dialog/window background
        
        Change-Id: Ifff07b2f754ed88cb7e60e0494092e266d3c7cf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132023
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [e697506a60b85495e9863ea97438f16d7f7b457b]

        ofz: Integer-overflow
        
        Change-Id: Id75b0aab50ffda1771560213f1389cd9255a461a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [c2424341ed444647d979a69ae55268e96fad3d56]

        comphelper : use std::mutex in traceevent
        
        Change-Id: I959b8c189a9ad073167cf3e0620947cbda77196c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [3b30ea9c00598b9de85333b67e8b3339d414eec3]

        tdf#114820: sc_uicalc: Add unittest
        
        Change-Id: I6aa50bdaf6a8d796d1aee817b7a1c0fddce26030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132060
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [859a7e52b20859a5c13ce83eeb7ec7fceb126fb5]

        tdf#115162: sc_uicalc: Add unittest
        
        Change-Id: I79874452b1f6909f23629cf0662f8c59faf02558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132059
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [ceb8f5d62c7afc5547c9a6de8eb570a11b5fbd67]

        loplugin:constantparam
        
        Change-Id: I86592be0717c062a918108bf4437074b0f70b372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132029
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Tushar Jham  <jhamtushar12@gmail.com>  [86fac2109d3b5e159628aee6392ecc856fb8a5a6]

        tdf#114441: Convert use of sal_uLong into better integer types
        
        Change-Id: Ic564411644f9021825f8523af3ec1505352187bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131948
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-24  Heiko Tietze  <tietze.heiko@gmail.com>  [652772ee4e76ff5d3aa0c599ec0bbe11d7bbee94]

        Resolves tdf#147515 - Make header text readable on dark themes
        
        COL_LIGHTBLUE works well for bright themes but is too dark
        in case of dark themes
        
        Change-Id: I7fe317da4d67c1d8a5c0330320a10206a003b4ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132028
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-24  Mark Hung  <marklh9@gmail.com>  [882045b934a3416cc48da2c4e30648892a419577]

        tdf#141671 fix destroyed pargraph style in exported RTF in MSO.
        
        Do not call MoveCharacterProperties() in RtfAttributeOutput
        ::EndParagraphProperties(). RtfAttributeOutput::ParagraphStyle() has
        emited run associated properties defined in paragraph style.
        Calling MoveCharacterProperties() again overwrites them.
        
        As this bug is only visible in MS Word, no unit test case is
        added.
        
        Change-Id: I6e5bfd12e8afa7dc286ca54448c1ff022aade31d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131848
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2022-03-24  Justin Luth  <justin_luth@sil.org>  [f5c2085e70c40370a790868d4683133a41e6599d]

        tdf#147861 ww8import: solve TODO: not fixed-field if equal
        
        Do not mark the field as "fixed" if the displayed string
        matches the internal variable. This allows changing the variable
        within LO and having the field update to reflect that change,
        which is the way that these fields are supposed to work
        (although in MS Word they only update manually via F9
         which is why some needed to be fixed in the first place).
        
        Change-Id: Id359cbf0b48e63bddab3e45871326988467d7ddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131414
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-24  Miklos Vajna  <vmiklos@collabora.com>  [8a7d0e8a811da83265c383630cc48af57f96dc49]

        sw clearing breaks: add insert UI
        
        Expose SwLineBreakClear in SwBreakDlg and extend
        SwWrtShell::InsertLineBreak() to be able to insert clearing breaks as
        well.
        
        Change-Id: I17a4c34cb74f1c72d8e208bace25597de0367e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132024
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [312cf9580c4b7846d217ce241c36f327a81f6cea]

        tdf#100847: sc_uicalc: Add unittest
        
        Change-Id: I0bd79a0b3bc6d92ec83ecd86c4ca631e65528c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132057
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [8ae60da492da5e1c1e721cf5e05f947546cc79b3]

        forcepoint#85 Conditional jump or move depends on uninitialised value
        
        ==398461==    by 0xCDC7960: (anonymous namespace)::CopyUntil(char16_t*&, char16_t const*&, char16_t, bool) (strhelper.cxx:88)
        ==398461==    by 0xCDC839F: psp::WhitespaceToSpace(rtl::OUString const&, bool) (strhelper.cxx:294)
        ==398461==    by 0xCB54980: vcl::PDFWriterImpl::setOutlineItemText(int, rtl::OUString const&) (pdfwriter_impl.cxx:9875)
        ==398461==    by 0xCB547FF: vcl::PDFWriterImpl::createOutlineItem(int, rtl::OUString const&, int) (pdfwriter_impl.cxx:9851)
        ==398461==    by 0xCAF39B0: vcl::PDFWriter::CreateOutlineItem(int, rtl::OUString const&, int) (pdfwriter.cxx:383)
        ==398461==    by 0xCABD7C8: vcl::GlobalSyncData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:250)
        ==398461==    by 0xCAC0628: vcl::PDFExtOutDevData::PlayGlobalActions(vcl::PDFWriter&) (pdfextoutdevdata.cxx:616)
        ==398461==    by 0x3D06EA0F: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:1004)
        
        Change-Id: I6bc086997851ee06531a4a9ae263e2b26edfba84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132056
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Mike Kaganski  <mike.kaganski@collabora.com>  [1e2483a3ab9d32266cba73db250ff4c517bbe4f8]

        Create OUString from ASCII literal instead of createFromAscii
        
        Change-Id: I58d0b49a32edf4d67807c0d67e08a28705d7334e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132026
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e3ed5559ad2c7e037d04b644801d7a4f48754a0]

        tdf#36387: sc_uicalc: Add unittest
        
        Change-Id: I6da7fbb03d127a093042a5dc6546f314b6af40ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131988
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [14393256231c69ed143ddede4e7532ed8faa6a88]

        loplugin:external
        
        > vcl/win/gdi/salnativewidgets-luna.cxx(399,6): error: externally available entity 'UseDarkMode' is not previously declared in an included file (if it is only used in this translation unit, make it static; otherwise, provide a declaration of it in an included file) [loplugin:external]
        > bool UseDarkMode()
        > ~~~~~^~~~~~~~~~~~~
        
        Change-Id: Idca63c3b9f25629db31cde48bc3c975f943a25f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132022
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [0d22aa485110df0ada7761e2c7930f704fbc4bfa]

        -Werror,-Wunused-function
        
        ...after 92e835dbf00590c9c29509d2995cc7918a9bbb90 "tdf#98705 Replace
        GetCaseCorrectPathName with GetLongPathNameW"
        
        Change-Id: If7fc8b656f7f0736edeb3b7617044a032d1481f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132017
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [d6a02a99eaa3690c0aa5c33fea3a4c710813a0de]

        forcepoint#84 Invalid read of size 1
        
        Change-Id: I1d0d74940cfa78a3c88cee737c9535acf03e0f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131991
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Caolán McNamara  <caolanm@redhat.com>  [94b5ebbe8bb4dd1cadb2d0a305116d7f6df82b24]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I469d443b6e3d81c18f1b778882ae4d151c1d0e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-24  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [19c215e948678c5c8809df6ce8052122b32c97d8]

        Clean up unused translatable strings
        
        These icon themes no longer exist, and these items are ignored anyway
        since the list was made dynamic in tdf#63962, back in 2014.
        
        Change-Id: I5a4dd5001b449f94775447f22b726b99a4fe63ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132025
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [d105539a79c68cb134f15518d27134767150d164]

        loplugin:stringviewparam
        
        Change-Id: If67d685eb930a299587a711eb5f77cbe9fd0ca09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132020
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [5ace52e6aef6f602ce8bf367b45ab2b740a85cd6]

        Adapt loplugin:trivialconsructor to clang-cl
        
        ...where the S4 template constructor may still have an unparsed null body, so
        
            if (!constructorDecl->hasTrivialBody())
                return true;
        
        will suppress the expected warning.  Lets just accept that clang-cl on Windows
        will find less instances of loplugin:trivialconstructor.  (And moving the
        expected-error comment around on the line was demanded by clang-format.  Oh my.)
        
        Change-Id: I3357fbd0fbf932f7f93c421c2f079a8cfc536eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132019
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [d501a1c00cc6c7a98269465324620c44dd50f3e4]

        loplugin:trivialconstructor
        
        Change-Id: I44c7a934c2d2fec16bb5d8e90c9186030934a021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132016
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ed4be1257ef76db4d0ac858a27ea6bd12bd3de1]

        loplugin:constantparam
        
        Change-Id: Ib65abd0546f1219387fe3fd7ad4f6ba0eb029bd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Stephan Bergmann  <sbergman@redhat.com>  [7f4ecf3263db9f40fcb5f02e62fdb45c1fc355bc]

        -Werror,-Wformat
        
        Change-Id: Ifb282ae907495ab21f3a91b1cae1c34443cb3626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132018
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a2c36bb69970f20b4896472e2d5a4e41df95b39]

        loplugin:constantparam improvements
        
        (1) sanitize call value output, make downstream processing easier
        (2) remove bad ignoreLocation() call, which was eliminating a lot of
        valueable data and thus generating false positives
        
        Change-Id: I39230c260c5cf717559300913fbc68bc3485b957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131986
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-24  Miklos Vajna  <vmiklos@collabora.com>  [37c41f2c445ecf519f4137c23fb36f3942328b6b]

        sd theme: add PPTX export for shape fill color
        
        Do this only in case there are no effects on the color, as that is not
        yet handled.
        
        Note that the theme color was already stored in the grab-bag, so this is
        primarily interesting in case the theme color was changed or the source
        format was ODP.
        
        Change-Id: Ia4995be68d5f243875632eec4aaf8afbb8f4d5cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131984
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-24  Julien Nabet  <serval2412@yahoo.fr>  [6f80e618a79ac70bc6658771b64d018cd228200e]

        Related tdf#147997: connect directly dialog
        
        Change-Id: Ic5ee0e3213d1a607d4ac5cb2402ce34e823622c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131885
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-24  Jim Raykowski  <raykowj@gmail.com>  [91be53fc5e72042f4741ab8b85e831df868adf82]

        tdf#147807 SwNavigator: relate Navigate By control to Content tree
        
        Change-Id: I4f74999b88d425f6d36b03bc5ee88f996f6844c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131874
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [40a327857695d45c80f94b3c73e6b3599f96dcc0]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: I2836c1ac742f61dd2d7175601032e9d3642dc0c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131978
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fd3cbeeb1f62d260174ff3235dca4e7c9daa5261]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6565914b3808f621a36ebe1fb3872a7fd54e5c15
          - Fixes in text
            
            Change-Id: Id37c002443c34d06e4daad777127edc8e20c2476
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131869
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-03-23  Caolán McNamara  <caolanm@redhat.com>  [ee3e6c66ee9670ce4554b46f27467eda80632775]

        forcepoint#83 Invalid read of size 1
        
        Change-Id: I1576dfd8c9731d943107764aeb66bb1c2294ad5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131983
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-23  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [d0055ac076c61d24c505c2ffa4f99e36c97b1266]

        tdf#147906 Use std::hypot for Pythagorean addition
        
        Change-Id: I7813b9929771858d33e951e50e6de7893fe19085
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131684
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [323ff2749b6be5f6ef98c6250afce4fa89e3aa1c]

        tdf#147641 default font size for captions always reset
        
        regression from
            commit 65d2d2647ead42e5bbb7800f14c047f383fe450b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Nov 8 16:10:51 2018 +0200
            loplugin:singlevalfields in sw
        where I incorrectly reduced a boolean expression
        
        Change-Id: I7f3b4552dc27dcd5e118233b5c0ca75e4eb06fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131980
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a967b566603225d2719735c0d27bf6c91a49bd2]

        tdf#148146 Selecting an Impress template results in failed assert
        
        regression from
            commit 31e7845339b30a69f06a04619660398fe4267268
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Feb 17 12:19:49 2022 +0200
            use more SfxItemSet::CloneAsValue
        
        Change-Id: Ie56fe208b64d464bf24c480db69c03cbe438a032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131979
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-23  Luboš Luňák  <l.lunak@collabora.com>  [fc6055b84c3ec4dd021aff723c7c318b2d19d1de]

        forcepoint#81 fix array size
        
        A mistake from 694148a9898b47d749588f9a32173a9933262e29,
        the array is meant to be from column 0, so as if 'nStartCol == 0'.
        
        Change-Id: I7f2ecea6c7378d0d5530cb38314807a8f7c896c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131972
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-23  Caolán McNamara  <caolanm@redhat.com>  [29d697f8fe8b310ed46053e5f6c206017f510237]

        forcepoint#82 back() called on empty vector
        
        Change-Id: I8017777a58f1fef41d1545899868e333c2184c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131969
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-23  Szymon Kłos  <szymon.klos@collabora.com>  [dd25fd6bf9b9637d4f1efcfcc642efa4be7f62b1]

        Use correct language for spellchecking in calc
        
        Fixes the problem of not applied spellchecking language
        change in calc.
        1. Open spreadsheet with German text but with English UI language
        2. Change spellchecking language to German
        result: no difference
        expected: spellchecking should be performed and mark words correctly
        
        Visible in both LOK and desktop.
        
        Regression introduced in:
        commit bdd149b1ff3d43b94cadc0d43365100c287c7639
        Author: Dennis Francis <dennis.francis@collabora.com>
        Date:   Sun Oct 4 12:47:46 2020 +0530
        
        Improve spell checking performance and impl. in several ways:
        
        Change-Id: I679b1181af118e9894a3f5240523d4945af8ccf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131870
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [66dea2b9ba257c8e3e1baec9adbc37afd0eca910]

        update credits
        
        Change-Id: Id548d2a8260dd8ab23b68781c99cca6b983d52c1

2022-03-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4ac4d643425c26870bd6e0bac26bb5896186875c]

        update credits
        
        Change-Id: Iae73e10952fcb87e9fe24a5d053bc3ab554b688e

2022-03-23  Caolán McNamara  <caolanm@redhat.com>  [3f25abc0cd2d2f6da828b030a191b6787a682a51]

        ofz#45583 Integer-overflow
        
        don't allow massive doubles to be loaded
        
        Change-Id: Ib7fddd40728a05358adddddf6b1ddc417b36872a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-23  Noel Grandin  <noel@peralex.com>  [4f900a536940fce989cd9e3d688a8391e6edf62f]

        try to improve stack dumping on windows
        
        noting that this commit is completely blind. But we're not getting
        good stacks on jenkins, and it doesn't look right to me that we're
        using 64-bit functions on 32-bit stacks, so make the 32-bit paths
        consistently use 32-bit functions and structures.
        
        Change-Id: I413ab97001246c442df151700cc618df4391e03b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131964
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-23  Caolán McNamara  <caolanm@redhat.com>  [095cd83fd266a3549ff9b2ad5abd6f05c3852b33]

        ofz: Divide-by-zero
        
        Change-Id: I792f80ef1a8b88f6f3c3da18bd656a4714f5a160
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131966
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [0e3d0ee939b646ef61f640c830ea5ad3196f763b]

        CppunitTest_sw_ww8export*: use getProperty<Color> when possible
        
        Change-Id: I099467a1682af692ca41031a3f1ee947de942a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131963
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-23  Mike Kaganski  <mike.kaganski@collabora.com>  [c5c4dc5fc90e775537dd98439a581ba7764a4fd0]

        Drop ENTER/LEAVE_PROTECTED_BLOCK and ISDESTROY macros
        
        ... that created some local language dialect.
        
        Mostly an automatic rewrite, with clang-format applied where
        it is unavoidable.
        
        Change-Id: Ibc24d00f6e80000320fa9bfb35ee16add0f714cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131961
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [7619bd3a386dfed2e03e257f42a543e1e7be76ef]

        loplugin:unusedmethods
        
        Change-Id: I59c9e52997e80174a3aa7f81bacdfb29e47be0a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1a29b960bb3693b34f3e8d77010a2398398c964f]

        loplugin:unusedfields
        
        Change-Id: Ifa2e2b35b725a877ef43526ad243cbfd02148807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-23  Miklos Vajna  <vmiklos@collabora.com>  [59af0be9fbfcef4e157a74099a6aef0c60facb36]

        sw clearing breaks: add plain text export
        
        No need to care about the clearing, but make sure that
        RES_TXTATR_LINEBREAK gets downgraded to a plain CH_TXTATR_NEWLINE.
        
        Change-Id: Ia4f6b45f60a414d856db41fd09d06c902dffd908
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131958
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-23  Sarper Akdemir  <sarper.akdemir@collabora.com>  [9633cad413960a4bd2963a3ace25ad52d5747929]

        correct misleading comment
        
        Corrects copy/paste residue with the correct content
        
        Change-Id: Ie10a4db728de154ebbdaf6c7902b28c71c815456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131957
        Tested-by: Jenkins
        Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>

2022-03-23  Justin Luth  <justin_luth@sil.org>  [7974d5ef1446f106a5f7c45b76ea2728fe4b18ce]

        tdf#147861 ww8export: DI_CUSTOM write fixed field, not plain txt
        
        It looks like we just punt on fields, and try to avoid
        round-tripping them as much as possible. And for good reason
        since they are tough and poorly handled.
        
        But since import of DI_CUSTOM has improved for DOC,
        it would be nice to be able to round-trip it as well,
        so that is what this allows.
        It also opens the door to round-trip more field
        situations as well.
        
        This patch depends on the earlier related patch
        that removes " (fixed)" from the FieldName.
        
        RTF and DOCX also export OK, but import needs some love.
        
        Change-Id: I32d9aa1fea12763cc30a79bcfa6d1d1e19d2c619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131238
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-23  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e5f96e2881d46ed71e390524d7172dca211de3e4]

        tdf#111851: rtf import: fifty shades of grey
        
        Unlike in DOCX in RTF token \clshdngN can represent much more
        transitional cell shade values from 0 (white) to 10000 (black).
        So we should not match these values strictly but use ranges
        instead.
        
        Change-Id: I4e0066e2b79e73cf6fbc3dd773047be8dab2b907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131931
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-23  Miklos Vajna  <vmiklos@collabora.com>  [be5ef79b93f37c6e91d0f94c647bbc42dff2abe2]

        CppunitTest_sw_ooxmlexport5: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ia6d99af8989e32cfe5e5c5ebf9f55e6844ed149f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131949
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a0f520c40274f64435a18f46a01a67c0ce64b16a]

        Fix typo
        
        Change-Id: I6508daf621dcc0f0d7441d2e962f6a0da6e2a4d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131954
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f32577e7c797659ece4a28242d94030d4fd95031]

        Drop SAFE_SYSFREESTRING macro
        
        It is simply useless, and in vast majority of cases, it simply
        nullified variables immediately before assigning them new values.
        
        Change-Id: Ibdad31229069d3cc7000624d5fca372472e8b59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131955
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [131a06fb2e414d8b8e49cd03c6b45f715047bad1]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: I6cf080bfe896b3c91698a6a778b55ef78cb535eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131941
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-22  Mike Kaganski  <mike.kaganski@collabora.com>  [a2c3ef6d8108355ce5daf6ff72310ac93ae745f0]

        Move BSTR wrapper to systools, and fix some wrong BSTR uses
        
        BSTR is documented [1] to be prefixed by a 32-bit integer specifying
        its length *in bytes* (not characters), so passing wchar_t* as BSTR
        is wrong, and the length member of rtl_uString can't substitute the
        proper BSTR length, since rtl_uString::length specifies length in
        characters. Any code taking BSTR and using SysStringLen to get its
        length would only get half of the passed OUString data.
        
        In dbaccess/source/ui/dlg/adodatalinks.cxx, the abovementioned
        error was implemented. OTOH, OLEVariant::getByteSequence() in
        connectivity/source/drivers/ado/Aolevariant.cxx passed BSTR from
        tagVARIANT to ctor of OLEString, which resulted in the BSTR being
        freed in both dtors of OLEString and OLEVariant (the latter calls
        VariantClear, which itself clears string when vtfield is VT_BSTR).
        
        [1] https://docs.microsoft.com/en-us/previous-versions/windows/desktop/automat/bstr
        
        Change-Id: Iedbd62b20133644258af3660616add7b63cac258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131950
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [a83dc2cebb60ec27a0d2606a9b7c196e581766fd]

        tdf#103994: sc_uicalc: Add unittest
        
        Change-Id: I64704b615e148573ba084cf4ecd15dc716b35194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131942
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-22  Luboš Luňák  <l.lunak@collabora.com>  [a0f616070f5a344038516d7225295733fd417283]

        warn on too many rows/column when loading ODS
        
        There's a warning when loading XLSX, but not when loading ODS.
        Now that 7.4 is going to support 16k columns, that would be a useful
        warning, either if we raise the limits again, or backported to
        7.2/7.3 .
        
        Change-Id: I204bca32e1ff37332b86361d3d81d3fee29c15ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131940
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-22  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [4a46a74a3de0ac7df5d3ce949dda5e809c1729ab]

        Advanced Diagram support: Enhanced Ungroup for Diagram
        
        A Diagram has a 'filler' BG object as 1st object in the
        Group to guarantee the Diagram's dimensions. It has
        no FillStyle or LineStyle and is Move/Size-Protected.
        
        When Un-Grouping the Diagram and thus removing it's
        Diagram-Functionality that filler-BG Object is not
        useful and needs to be removed. Do that in an UNDO-
        supporting way to allow seamless UNDO/REDO actions.
        
        Change-Id: I1c5052de59dafb6ba1b35a68123bdabd10bf7885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131930
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-22  Caolán McNamara  <caolanm@redhat.com>  [fcf785b82b92ecfff942577dafc27b1369c5e19c]

        ofz#45583 Integer-overflow on drawEPS
        
        Change-Id: I6a8add3e2ba695d2012916280a7f976b7b11934d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131908
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4b3b9e7af77e7c0501fe4c87a3dfbe3b314cc085]

        Update missplaced icons
        
        Change-Id: If1e0e28d9e08bfbb0975841cd24e4fda530f3a98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131938
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d1e89988d45564d17acc286ecfb8d59cddf94ce]

        tdf#118983: sc_uicalc: Add unittest
        
        Change-Id: I7d0e473136b4d57fbebf6c6477044a61e2fa39f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131933
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [931ce5db280ab7c4ccd005cc43f08a693dc34e9f]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: I9cdfdaefa1a9f487e471fe3a3f958da3b9e86904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131917
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [099e432ad93eee3acd6ba0aa5d2a7d68cff7d732]

        Colibre: tdf#148135 ^ Group and Ungroup icons
        
        Change-Id: I25680b8191718a931f32b84b39d01c6e0d24b75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131937
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c9be555e4a12e4c4440b941d3de72644683fb0e]

        tdf#107572: sc_macros: Add unittest
        
        Change-Id: Ib80c8791ead9a151986642d835171fac04c1b1d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131936
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-22  Luboš Luňák  <l.lunak@collabora.com>  [ff8b9f6fca5784f62427302026642de0cdb1ef11]

        use dashing info from struct LineInfo in EPS writer (tdf#146804)
        
        It had a random(?) hardcoded '2' as the dashing info. While at it,
        I've also made few other places use the common implementation
        of creating the dotdash array instead of doing it manually.
        
        Change-Id: Id349ca138c98d08eef47dc0bfe6d162e03fc4a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131932
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [7bc16436e28153dfdd01e8d49cd193f62098476c]

        tdf#108292: sc_uicalc: Add unittest
        
        Change-Id: I0543b0ce1914ff5d69370802b65da311c37111f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131935
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-22  Stephan Bergmann  <sbergman@redhat.com>  [721c4faa50d12bb5bbff27cb9fb0c3beca8a5886]

        Adapt loplugin:indentation to --enable-qt6
        
        > In file included from vcl/qt6/QtClipboard.cxx:10:
        > vcl/qt6/../qt5/QtClipboard.cxx:142:16: error: statement mis-aligned compared to neighbours  [loplugin:indentation]
        >         Q_EMIT clearClipboard();
        >                ^
        
        etc.
        
        Change-Id: I8ceacfd5eafe963699d8313d3f8cadbed4ccd260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131929
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [215cbf1ad23399cb035781698aa28d1eabdb6489]

        tdf#114406: sc_ucalc: Add unittest
        
        Change-Id: I0d6be8945e3aaecdccfc674c70f60b6f150f3c05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131934
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-22  Sarrah Bastawala  <sarrah.basta@gmail.com>  [e0b281b17b974d20f98a61804377cfae07753016]

        tdf#135234 : Change initial focus of SpellDialog
        
        Change-Id: Ic316a8d99ad12a51a79b2e2680aa5cec5eac5c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131182
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-22  Juergen Funk  <juergen.funk_ml@cib.de>  [846c3ce7a2aa2a87399edb57ee858720ec837fb8]

        Solve exception in implts_flushConfigItem
        
        Regression from 4256c764aee0777770466115a97420d9b55c23ac
        in framework/source/services/autorecovery.cxx
        in line 1997 sloved the exception
        
        Change-Id: I4bee90b94307978c9c5186c1c5fdaca1aa420e21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131901
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [6c5257b680044514debc1dde1267ab985ef4548c]

        wina11y: Slightly clean up WinResIDGenerator
        
        Changes:
        
        * drop the optional `maxNum` param for the
          constructor, it's never set to anything
          different than the default value
        * store negative number in member (renamed
          from `max` to `m_nMin`) instead of storing
          positive number and inverting that when returning
          it in `ResIDGenerator::GenerateNewResID`
        * Use -1 as the first resource ID instead of -2.
        
        Also, add a comment that negative child IDs
        are used because it's common to use such ones
        to indicate unique resource IDs in
        IAccessible2.
        
        Quoting James Teh's comment on an NVDA
        pull request of mine [1]:
        
        > The use of negative child ids doesn't fit well into the IAccessible
        > spec, but it has been done by IAccessible2 for a very long time and
        > should be considered standard for all intents and purposes. A negative
        > child id should be treated as a unique id, while a positive child id
        > should be treated as a child index.
        >
        > That said, as noted in #13277 (comment), IAccessible2 elements are
        > always full IAccessible objects, not "simple elements". Thus, anything
        > that returns an accessible (including accSelection) really should return
        > an object pointer. In the case of accSelection, this means VT_DISPATCH
        > for a single selection or VT_UNKNOWN and iEnumVARIANT (with VT_DISPATCH
        > elements) for multiple selection.
        >
        > In short, NVDA supporting negative child ids returned from accSelection
        > isn't necessarily "wrong", but ideally, LibreOffice would be fixed to
        > return full objects.
        
        The latter (returning full objects) has already been addressed in
        
            commit 00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jan 31 07:41:14 2022 +0000
        
                tdf#147083 wina11y: Return a11y object instead of child ID
        
        but a unique ID is still relevant, s. e.g. the documentation
        of `IAccessible2::uniqueID` [2], which also mentions potential
        ways to implement unique IDs:
        
        > One means of implementing this would be to create a factory with a 32
        > bit number generator and a reuse pool. The number generator would emit
        > numbers starting at 1. Each time an object's life cycle ended, its
        > number would be saved into a reuse pool. The number generator would be
        > used whenever the reuse pool was empty.
        >
        > Another way to create a unique ID is to generate it from a pointer
        > value, e.g. an object's address. That would be unique because no two
        > active objects can use the same allocated memory space.
        
        The first approach is what the LO implementation currently does,
        except that negative numbers are used.
        
        [1] https://github.com/nvaccess/nvda/pull/13277#issuecomment-1024622871
        [2] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#aac1342376cf195a6a6e9ee3b7e30ae3b
        
        Change-Id: I6c0a6c4a4e3a69396205fe2d69cd66af6525a273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131927
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-22  Miklos Vajna  <vmiklos@collabora.com>  [66d1ea5915761f3550b39466db5d48eb723f0ccc]

        sw clearing breaks: add HTML filter
        
        Map between SwLineBreakClear and <br clear="...">.
        
        The import-time workaround with the anchor-only wrapping is no longer
        needed, the layout is now capable of doing this.
        
        Change-Id: I53fa49f11e13fc3338b3cf70d8f87f3633c414c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131924
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-22  Stephan Bergmann  <sbergman@redhat.com>  [afc144b1f949e799a966933f28e07f83f735a7e2]

        loplugin:loopvartoosmall
        
        ...with --enable-qt6, where QList::size() return type has changed from int to
        qsizetype (aka ptrdiff_t); but just replacing the use of int with a use of
        qsizetype would fail with --enable-qt5 in some build environments where the Qt5
        qglobal.h doesn't happen to already be included, so simply replace this with a
        range-based for loop and be done with it
        
        Change-Id: I5a6c7b0468ed7cef6de7fb647fdb2631a8cb5b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131916
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-22  Stephan Bergmann  <sbergman@redhat.com>  [fe40f6457800d4ce3d50a84b53f33b775087871f]

        Win/X11OpenGLDeviceInfo don't need a common base class
        
        Change-Id: I9fc7e763b8cf055c3aabaaa97fe8c85ebc5e71b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-22  Justin Luth  <justin_luth@sil.org>  [377e6f7e8556516b6d1698c58857a5662e6f5660]

        tdf#147861 ww8import: use GetFieldResult, not current DocProperty
        
        In all the testing I could think of on DOCX and DOC examples
        (and only a very few exist in the unit tests)
        the actual value of the DocProperty was irrelevant to
        what Word shows as the document loads.
        It always takes the in-document, as-last-seen static text.
        
        As a way to hack a fix using existing capabilities,
        I marked as FIXEDFLD the unknown custom fields
        that weren't handled separately.
        That fixes what is displayed as the import value,
        (which of course means that F9 will no longer
        return a modification back to the DocProperty value).
        
        It also means the (fixed) field is lost on export,
        but a follow-up patch handles that for DOC/RTF/DOCX.
        
        There were NO DI_CUSTOM examples in existing ww8 tests, but:
        -ooxmlexport8:  fdo74745.docx, fdo81486.docx
        -ooxmlexport10: tdf92157.docx
        and in these cases the plain text matched the variable anyway,
        but a manual manipulation showed that LO is importing DOCX wrong
        as well, so a similar import fix needs to happen for RTF/DOCX.
        
        My fear is that there are some special-magic-associations
        that worked properly the old way by accident that I will
        break by marking them as fixed. No backporting please
        since obviously very few people report bugs about fields.
        
        Change-Id: I3f167eb3bd570b66ee829241bf9d31d557fc8749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131237
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-03-22  Michael Weghorn  <m.weghorn@posteo.de>  [f0734deb7a3bcae2615adbe6a465ec39952b3e98]

        gtk3_kde5: Don't call deprecated QFileDialog::setConfirmOverwrite
        
        QFileDialog documentation says [1]:
        
        > This property is obsolete. It is provided to keep old source code
        > working. We strongly advise against using it in new code.
        >
        > This property holds whether the filedialog should ask before accepting a
        > selected file, when the accept mode is AcceptSave
        >
        > Use setOption(DontConfirmOverwrite, !enabled) or
        > !testOption(DontConfirmOverwrite) instead.
        
        Documentation on `QFileDialog::DontConfirmOverwrite` [2] says:
        
        > QFileDialog::DontConfirmOverwrite	0x00000004	Don't ask for
        > confirmation if an existing file is selected. By default confirmation is
        > requested.
        
        It already said that 10 years ago. Given that's the default,
        there's no need to set it explicitly at all.
        
        [1] https://doc.qt.io/qt-5/qfiledialog-obsolete.html#confirmOverwrite-prop
        [2] https://doc.qt.io/qt-5/qfiledialog.html#Option-enum
        
        Change-Id: I77a0022dc4128d157ba49c9aa8de447bb2c08379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131923
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-22  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [24b5490cb0fd8de19415509fbf452874669106ad]

        tdf#104390: rtf import: init default font for entire state stack
        
        If first document element is buried deep in destinations and thus
        deep in state stack (m_aStates) initialization of default font
        is very local and will be lost after closing these destinations.
        
        So let's initialize entire states stack with default font if none
        is provided istead of initialization just a top element.
        
        Change-Id: I966c282f43b84baece909a4c3cd359cbcd317e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131906
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-22  Stephan Bergmann  <sbergman@redhat.com>  [3076b4f009cd1ba8c7f71454436001def34d9bd0]

        OpenGLHelper::GetDigest is only used on Windows
        
        This is in preparation of getting rid of X11OpenGLDeviceInfo for non-Windows
        platforms.
        
        Change-Id: I9c08292716244d046bf223eb760880db43b6824b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131921
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-22  Mike Kaganski  <mike.kaganski@collabora.com>  [561cb62a5ac81053e89ec9bf1eed739801570c2d]

        Simplify CoCreateInstance / CoGetClassObject with COMReference
        
        Change-Id: Ieb1035410c3c6c4b40ea779e829a940460d19b5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131922
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6c16dc217ef5cbe25166df7a3728ade12a148880]

        sc: support sparkline bar colors, add markers to sparkline lines
        
        Change-Id: I705a7f57cc4d6544ecb35a5f93c18a27056b9944
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131918
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-22  Miklos Vajna  <vmiklos@collabora.com>  [adf924ce6742a419e6a082ebd60d58d296e2971e]

        sw: document SwXTableRows
        
        Which has a backing core C++ class, unlike table columns.
        
        Change-Id: Iebc546b8c3424f976043deceee8307eae764bbb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131914
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-22  Deep17  <deepoose2011@gmail.com>  [d84ea3c8744aa5a125cec56574c1b943e768b70a]

        tdf#145614 Convert #define to enum or constexpr
        
        Change-Id: I3090ae3421ae55b7c546d82aeb49a56e93c9f02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131913
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [28de720bc088a4afd3b2f28c5136a3478af5d22a]

        Use IID_PPV_ARGS to have less explicit casting
        
        Change-Id: Id8839a68320d7d0e2453b3d584dc5708c653cdf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131863
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-21  Stephan Bergmann  <sbergman@redhat.com>  [b73e4660af577609621461c33693b629e9b5a603]

        ScColumnsRange::Iterator actual needs to be bidirectional
        
        ...since 1463625ae26900d2461fd72a5a2c894b9f1b8726 "dynamic column container: fix
        some more for loops" started to use it with std::reverse_iterator (but
        apparently forgot to update the iterator_category, causing
        
        > In file included from sc/source/core/data/column.cxx:20:
        > In file included from sc/inc/column.hxx:22:
        > In file included from sc/inc/global.hxx:22:
        > In file included from sc/inc/address.hxx:22:
        > In file included from include/rtl/ustrbuf.hxx:35:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/string_view:206:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__string:13:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/copy.h:12:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__algorithm/unwrap_iter.h:14:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/iterator:669:
        > In file included from ~/llvm/inst/bin/../include/c++/v1/__iterator/reverse_access.h:14:
        > ~/llvm/inst/bin/../include/c++/v1/__iterator/reverse_iterator.h:53:5: error: static_assert failed due to requirement '__is_cpp17_bidirectional_iterator<ScColumnsRange::Iterator>::value || bidirectional_iterator<ScColumnsRange::Iterator>' "reverse_iterator<It> requires It to be a bidirectional iterator."
        >     static_assert(__is_cpp17_bidirectional_iterator<_Iter>::value || bidirectional_iterator<_Iter>,
        >     ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > sc/inc/table.hxx:146:37: note: in instantiation of template class 'std::reverse_iterator<ScColumnsRange::Iterator>' requested here
        >     std::reverse_iterator<Iterator> rbegin() { return std::reverse_iterator<Iterator>(maEnd); }
        >                                     ^
        
        etc.)
        
        Change-Id: Ice7527412a379a5ecb655349386e8814c911e87e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131909
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ca3de20e9567810964af008f606e5af1e3221a3]

        Removed duplicated includes
        
        Change-Id: I22b71580a79500e169ed9cab775501583975d67f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131911
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8a0b558a500181af9c71fd2e4c6ca3d036edcd5e]

        Fix typo
        
        Change-Id: Iba19e41fcc9277d428476e876b6a0bf50e7f18d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-21  Julien Nabet  <serval2412@yahoo.fr>  [2aa3097fe2beb56d43f037723997c8d37a7251b4]

        Related tdf#114286: put duplicates commands in GenericCommands (SplitCell)
        
        Change-Id: I8d63d47782a77350ab0f38b1a96cd045b44500a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131676
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-21  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [da1d70d1e27cbf5f9aceafa60693a407d29f1ab8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b79af43f87d6932dd49b4fac1552378a56f5ba5d
          - Help page cleanup
            
            Change-Id: I1066974181278b56071f16234358d67d8038e134
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131200
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [f4474b2967f9c7b3b82239c6e9c66850964c6e8b]

        ofz#45878 add a way to set some limit on hugely complex clips
        
        Change-Id: I6bbf7c6068560e3bb656560fb5c6cc2ed72cecd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [79b5ff92b17fde902c2f9db3e806f1c77a387dff]

        tdf#118047: RTF import: better deduplication for header/footer
        
        Here are two related fixes in one patch:
        
        1. By default current style index is 0, not -1. Due to this we
        can assume usage of default "Normal" style during deduplication.
        Seems there is no difference in case of no style mentioning in
        run or mentioning "Normal" one (\s0), so value -1 looks
        unnesesary.
        
        2. During header/footer "substreams" processing StyleTableEntires
        was not reused in new domain mapper impl instance. So deduplication
        did not work well.
        
        2a. To avoid copying of whole StyleTableEntries between instances
        it is stored as pointer in domain mapper impl.
        
        Change-Id: Id003d35554e9b43186238920d9a6373452095121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131899
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f8b482f6d601b40c0263333da393bc218c8114eb]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Iefbe24e122aab9c2ea95a4b93f4bf49d0940e17c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131903
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [bbb7ad2db9bb8525a619c3a329299da31c24bc1b]

        Move implementation of doubleToString to sal/rtl/strtmpl.hxx
        
        ... to reduce inter-relations between compilation units, and drop
        *StringTraits from sal/rtl/math.cxx.
        
        Change-Id: I0d7544dead03651dc71ec923cab10580f15cf49a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131895
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [29c4d47161dab81971029717ce358de59f52f8c3]

        Related: tdf#118320 tabpane is too white in darkmode
        
        the only reliable darkmode hammers are a button or drawing with some
        solid color derived from a theme element, try a button here
        
        Change-Id: I842a415020abd26dc60e51438f9fd3c961ecd830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131902
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [22fa995ae81739aa1b7fcc5ffb277d1a46bda452]

        ofz#45816 Direct-leak
        
        Change-Id: I73ed541c9a8fb6d9b0a8ee86ce7cf581721a9b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [06d132333deeb1580b7cc106dfb3ff4bc454178d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ced4b1d58efe8b35289643376d082fb416edae21
          - tdf#146847 Typo in IDIV Basic help page
            
            Change-Id: Ib303ad532c2daf9de856ed8c5c5cd2df673920d2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131854
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [c51140847efa90897253011bd0382a32440d73e3]

        Related: tdf#118320 swap TILES_SELECTED and TILES_FOCUSED
        
        so the selected tab gets the same bg as the tab page
        
        Change-Id: I26222cf755c4c30f8712fb7a4690c84784d9b508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [095f5910e3781e5e0a3f9d09821d2be6be48abff]

        ofz#45816 Direct-leak
        
        Change-Id: I63f4828fb35a1f24c98ccd235af91d186b48058a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131897
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [5bd4d100acc08307c96e2b4cc7b8301210386fbd]

        YYDEBUG is always 0
        
        Change-Id: I9255b0c6447126e5b0907b12622b668bb4c79474
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [726a3712eec4e26e88492dd5005360938307209b]

        yyoverflow is not defined
        
        Change-Id: I5769b82ededd15a50892bc4e9478f69edb4722c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131893
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [e746d8d3af46cb17c705dd7d6724cff8bdd6bca8]

        YYPARSE_PARAM is not defined
        
        Change-Id: Icda8e09ceb5e2bebb5187d00c0baa1bcccda88a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [08039ee959eefc6888e966fe3b3769abffd1fafc]

        YYPURE is not defined
        
        Change-Id: I5942de482c6216fba2c35fa6d113c44639d349e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131891
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [b77091684ba3de0a2009a1bc42514ef48ae6bcfc]

        YYLSP_NEEDED is not defined
        
        Change-Id: I324e811a84916f27037b2fe9df0aed2db5458564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Miklos Vajna  <vmiklos@collabora.com>  [3afe4f66f7266ede9922ce0682db38c9369349b7]

        sw clearing breaks: add RTF filter
        
        Map between SwLineBreakClear and \lbr<N>.
        
        Change-Id: Ibed94ad74157a08787212a34176590a1dc4d5547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131886
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-21  Justin Luth  <justin_luth@sil.org>  [a13faccd7e8c6503e96e9342a8615b4542b0601f]

        related tdf#147861: cleanup + a function provides the name
        
        This is not quite a NonFunctionalChange because it avoids
        adding " (fixed)" to the name. But that is what I want
        anyway for bug 147861, so this is an all-around good simplification.
        
        Plus, the writerfilter loop doesn't need to run if an
        inside clause will never be true anyway.
        
        Putting this cleanup separately helps highlight the
        actual fix and not clutter the real patches.
        
        Change-Id: I12f345cc92627398ad00fe32b64b98b54e5ed14b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131413
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [81eb293ff5c0879fa3d5f9be991c04f6bcd0fa96]

        dval can be const
        
        Change-Id: I452f666230aca5b6033dcb16495ae382e4fd1073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Caolán McNamara  <caolanm@redhat.com>  [516edf5c1a2c04dd1da8ec769a4eefd69cca48c3]

        ofz#45816 Direct-leak
        
        Change-Id: Iaf31e6b46cc5ab68de46c250926d6a4709eddd75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131887
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-21  Siddhant Chaudhary  <urssidd@gmail.com>  [8351179b787a10167e9e68584d3b3573fbdb6ebc]

        tdf#141908 Replaced usage of sal_Int32 and sal_uInt32 with Color in unit tests.
        
        Change-Id: Ieb8b6b3c3bfab0ab49bc55cf42db7be4f08e964b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-21  Juergen Funk  <juergen.funk_ml@cib.de>  [0498c522724bbfd789261cb1562b3bfe1a81bb3e]

        tdf#147589 In document with OLE link, don't show temp-file is in use
        
        Regression from 218f36dd614cf828e949f605faaf6a6fd615da26
        change the handling in OTempFileService::closeOutput
        That was the problem in the OLE-Link handling
        
        Change-Id: I5a7fa74b4a731f758e1c405dfb9cd298b30086a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130408
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-21  Miklos Vajna  <vmiklos@collabora.com>  [f461c889ac4bc053c306537f644ec4bf3e0d5128]

        sw: prefix members of SwWW8WrGrf, WW8Export, WW8PLCF and WW8PLCF_HdFt
        
        See tdf#94879 for motivation.
        
        Change-Id: I86c9fd2c634b2f5422b0820dd5423008b1c0360c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131884
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [c93d27c9d25e06a884c971fc8dbbea8fe7599578]

        Reorganize the code a bit to drop some detail::* helper functions
        
        Change-Id: Iee7402f5de7287678e1691b48b6493d3131ef7ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131883
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-21  Mike Kaganski  <mike.kaganski@collabora.com>  [7ad230676488d294ad03508ab027fc5e9c76a398]

        a micro-optimization
        
        Change-Id: I2d94c2d3d7a159953b264e21a0fce8f0a0340163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131856
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-21  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [494020efe6d29bc319c3abcd3245425e394674ec]

        tdf#131234: RTF import: extend default char props list
        
        There are much more character attributes should be applied
        wth default values if style contain them, but they were
        not mentioned in current run.
        
        These are obviously not a complete set yet, but most common
        ones are included.
        
        Change-Id: Ide52245bc98628febc2f3bd2e25166f0dcdf35cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131853
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0ca27824bf6e84adcf7d481d232cbe28ff99cfae]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: I80b5be377bfd7e0dadb2f138e0577bf89add55b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131881
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-21  Jim Raykowski  <raykowj@gmail.com>  [9a4e73e28a226b56531471da5e49a2cf0f5a51c4]

        Don't display search wrapped message when nothing is found
        
        by a search for Frames, Images, and OLE objects
        
        Fixes the search wrapped message being unnoticeably shown before the
        search not found message when nothing is found by a search for Frames,
        Images, and OLE objects. Also fixes a possible search wrapped message
        being shown when SwFEShell::GetBestObject is used by
        SwTextShell::ExecMoveMisc for SID_FM_TOGGLECONTROLFOCUS case.
        
        Change-Id: I57e518163d9b61dcf9838e5552a0de53f48faa0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131638
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-21  Eike Rathke  <erack@redhat.com>  [a997bd0e77d9721d55311dcfbd50fea802d801bd]

        ExtText2Doc: EmbeddedNullTreatment is not necessary for bDetermineRange
        
        Change-Id: I1efb8bf14889514b2258bcf7db5ff5b6b2efecf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131880
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-03-21  Eike Rathke  <erack@redhat.com>  [0b8a3d1f5fd339d0c77f4e074b3c8ea649407326]

        ExtText2Doc: fixed width columns don't need to be determined for each row
        
        Change-Id: Ie68f5d80a9fb0946c45cc89f89f25ea0995a7806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131879
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-03-20  Rene Engelhard  <rene@rene-engelhard.de>  [90babff28406d5366df153e2d3c6d4206f06d614]

        add system-libfixmath
        
        Change-Id: Ia0bd884d6fefde77c75889bf2ea831ebf1b401cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131876
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-03-20  Mike Kaganski  <mike.kaganski@collabora.com>  [cd973e75fa55e3b2703757b1901e9ce644881be9]

        Remove special-casing Windows stderr handling
        
        Since commit 506173a7f42f34821238a63f3f8c7362c9fae9d9
          Date   Mon Nov 19 13:07:20 2018 +0300
            tdf#112536 related: make soffice.bin a proper console application on Win
        
        and commit ab0942240507e9be81dbe43e8d69b7f9273b124f
          Date   Wed Jan 22 22:13:25 2020 +0300
            Make unopkg.com proper launcher for unopkg.bin on Windows
        
        there *is* stderr on Windows, so we can revert commits
        a34c9a8065c90250f7389cdea660a49e84289098
          Date   Tue Aug 02 09:52:37 2011 +0100
            can't use set_debuglevel under windows
        
        and a1775d69e8cccb827331c1984313d2d26ddadadb
          Date   Tue Aug 02 09:57:59 2011 +0100
            make logging less painful under windows
        
        Change-Id: I5698a69130e55094508d5ca22411e861ffeeed8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131877
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-20  Noel Grandin  <noelgrandin@gmail.com>  [5211aeb3de2e98f3d59d53d5ddc16f09a956e410]

        simplify some calls to RtfStringBuffer::append
        
        Change-Id: I68ad11d19fb0c0a20a336cb0888a1229ce12b995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [59a7c40255b836ed75e64686fabb3e9938b755f0]

        reduce down to the part and config we are using and move to tools
        
        Change-Id: Ifaddc59c3c7834808d368c138a5ec7c0b80db14c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [892ef6e8b6888b3029041ab150b409f81a5c31b0]

        Related: tdf#118320 let windows icon theme know when a dark theme is preferred
        
        Change-Id: I7569814a575e3d7c216e790eb162397d312fa0e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131843
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [348407dfdf5fd41b99f5998463eb032128799555]

        Related: tdf#118320 tabitems appear as light in darkmode
        
        so use a Button theme and matching button properties for drawing those
        instead as a workaround
        
        Change-Id: I5ba0e360adc109e80ab7ecb1ff2fd5bc84028b61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131852
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [32dc2d14287a4210589c33dbd62c6e36e095aa6e]

        ofz#45583 detect some invalid scale cases at import time
        
        Change-Id: Iad881f09bef707897e19d402a9931a6dea88f52d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131839
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [ef37fa084e55aa13ecebcd0ebdbc7c2bca908c11]

        ofz: Null-dereference READ
        
        Change-Id: Ie42af72e321bd55e3373aca33f0bcb6884bf8836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131849
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d02f111181b0f79eda2a96f47181da5ee8d3aabf]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Ibb17831fb110f2683ee94b332bca4c658962b4f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131847
        Tested-by: Jenkins
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-19  Caolán McNamara  <caolanm@redhat.com>  [c43c4a00089b1965c7ef69ef40c9e645dffc2e43]

        Related: tdf#118320 darkmode DrawThemeBackground doesn't work for tab bodies
        
        so just draw it as solid window color
        
        Change-Id: I4e452a7d6a21be91da8e23901746064fd33ee386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-19  Luboš Luňák  <l.lunak@collabora.com>  [1a1957eab90a11b5481faa1ef6d877eed1ce564a]

        handle broken row ranges in excel import, #2
        
        In ad1f6e62298612f4b277708b813a219ba390f1b0 I didn't add a second
        std::unique() pass, that seems to be necessary with some broken
        documents as well
        (sc_column3_regroupformulacells_heap_buffer_overflow.sample
        from crashtesting).
        
        Change-Id: I6865085a9b77fe51246180e519bf1a2309615144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131834
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [927cf43c07606c687f47831dcd70b57e52d52906]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Iabf739383aab078139289a6c8a50a711d05eb6c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131846
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [da3759155fcfe855dab99d59f3b9540efa9777d7]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Ie37c5a61de1f7ff53985e4555c430e00bc82733b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131845
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [566ee17c2709f9939145ddc7fbb1d61c35049321]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: I53c550ae5a0ec619c7bfe3e46defc72227bb90fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131844
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-18  Caolán McNamara  <caolanm@redhat.com>  [d643f9d5c66cdf8b6c935484e65b8f24b5ef31f0]

        ofz: Direct-leak
        
        Change-Id: I40024334b394e4de6a1766321556689234da86ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131840
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-18  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [f433d9cf8be6507f0299492794da9ed5d749a6ad]

        tdf#114441 Convert sal_uLong to other types
        
        Change-Id: I5651788dad4386aa325e20fa8bbfc0908dbfa629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128767
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fdbda2901080d3638475638f693299eca7c1cd7f]

        Fix typos
        
        Change-Id: If006b66919dcc7f409e9f9a30e1fe09fa592e698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131838
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-18  Caolán McNamara  <caolanm@redhat.com>  [467c8bc2229f51ef4ca6d9593554a7cf1e7ff7ee]

        ofz#45583 Integer-overflow
        
        we assert on use of a negative xscale too, so don't allow that either
        
        Change-Id: I3420fc3f4568eed187fcccf26067006e064d417e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131835
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ce3e760f9155ac8d80f60054be036e862df7029a]

        tdf#111924 - Special characters: don't lose focus on context menu
        
        Don't lose focus on the favorite or recently used items in the special
        characters dialog when right-clicking them to show the context menu.
        
        Change-Id: Iaedc4bbc6fb627591b9c0cd9a2c44940312eeb1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131721
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-03-18  Gautham Krishnan  <gauthamkrishnanpriya@gmail.com>  [67fcd8f268fd04ca2012470af2257b394b77b8fc]

        tdf#147906 used std::hypot for Pythagorean addition
        
        Change-Id: I9bf10374af93cd22e429a112937aaa8828126523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131504
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-18  Sinduja Y  <sinduja.code@gmail.com>  [a40ed687a3e2f8e1d17705fcd7d397ba09398cb6]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Ifed6b79a4186e3196dc1e9ac179fe8ad0ee4a342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131655
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-18  Stanislav Horacek  <stanislav.horacek@gmail.com>  [90020e670e543bbcd54598eb62b43a5e996de0d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 72eb5901a18fba63f13f832ac5e2082fd2d1f305
          - fix example for SF Menu service
            
            Change-Id: I769bb965ea1c8ea836850bdf6f3ba05068ec737a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129925
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [b650469c434c59f1076a5130aa5ba58345539e68]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b219699612bd7577c8b8d9e84c2d79a4f16abc33
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7da83d7d8933af55a1f5a7118c1cb3f4f1946fbd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131417
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [003649cb8229e012fd7dee62b79df39514e38ed8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30de8915b7c7d25f12a73d1f71af37f627af6355
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5d94abb478ab3c11840804365b1299ad123b1172
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131426
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [b969544d5a08d1cf581b9e1e4c9940164fe0c813]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 601640f0d687358b494f2e59eeed947e49e32b7d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I09c358047d4dd01f21745268c4618b47faaee4a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131440
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Deep17  <deepoose2011@gmail.com>  [b3bd864f7c05c3c794b431dea2ec91ad459812e7]

        tdf#145614 Convert #define to enum or constexpr
        
        Change-Id: Ie039a828b09aacc68ef2f95f495284d554122940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131510
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-18  Caolán McNamara  <caolanm@redhat.com>  [0f31597dcc144cbb9c7dead9a6f2154ba1c044e6]

        ofz: Timeout in clipPolyPolygonOnPolyPolygon
        
        Change-Id: I4257cd7133b29a2f5ae3407a5284965eb0814462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131737
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-18  Stephan Bergmann  <sbergman@redhat.com>  [9074f5602a9b0b51349647f29d8537256217ebe7]

        tdf#148063: Avoid dereferencing potentially bad user-supplied TypeDescription
        
        ...from Basic script
        
        > sub foo
        >   a = Array()
        >   oUnoValue = CreateUnoValue( "[]", a )
        > end sub
        
        at
        
        > Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
        > 0x00007fffc413b2db in stoc_tcv::(anonymous namespace)::TypeConverter_Impl::convertTo (this=0x3269200, rVal=uno::Any("[]any": empty uno::Sequence), aDestType=invalid uno::Type) at stoc/source/typeconv/convert.cxx:537
        > 537	                reinterpret_cast<typelib_IndirectTypeDescription *>(aDestTD.get())->pType );
        > (gdb) bt
        > #0  0x00007fffc413b2db in stoc_tcv::(anonymous namespace)::TypeConverter_Impl::convertTo(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&) (this=0x3269200, rVal=uno::Any("[]any": empty uno::Sequence), aDestType=invalid uno::Type) at stoc/source/typeconv/convert.cxx:537
        > #1  0x00007fffc413d144 in non-virtual thunk to stoc_tcv::(anonymous namespace)::TypeConverter_Impl::convertTo(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&) () at instdir/program/libstocserviceslo.so
        > #2  0x00007ffff4fe0264 in convertAny(com::sun::star::uno::Any const&, com::sun::star::uno::Type const&) (rVal=uno::Any("[]any": empty uno::Sequence), aDestType=invalid uno::Type) at basic/source/classes/sbunoobj.cxx:324
        > #3  0x00007ffff4fdfe79 in RTL_Impl_CreateUnoValue(SbxArray&) (rPar=...) at basic/source/classes/sbunoobj.cxx:4157
        > #4  0x00007ffff513b1b0 in SbRtl_CreateUnoValue(StarBASIC*, SbxArray&, bool) (rPar=...) at basic/source/runtime/methods1.cxx:1403
        > #5  0x00007ffff50ea80e in SbiStdObject::Notify(SfxBroadcaster&, SfxHint const&) (this=0x2003400, rBC=..., rHint=...) at basic/source/runtime/stdobj.cxx:1059
        > #6  0x00007ffff3decfae in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x3329e90, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39
        > #7  0x00007ffff518e772 in SbxVariable::Broadcast(SfxHintId) (this=0x31e8f60, nHintId=SfxHintId::BasicDataWanted) at basic/source/sbx/sbxvar.cxx:151
        > #8  0x00007ffff5186d4f in SbxValue::SbxValue(SbxValue const&) (this=0x31ff450, vtt=0x7ffff51ae718 <VTT for SbxMethod+16>, r=...) at basic/source/sbx/sbxvalue.cxx:66
        > #9  0x00007ffff518d291 in SbxVariable::SbxVariable(SbxVariable const&) (this=0x31ff450, vtt=0x7ffff51ae710 <VTT for SbxMethod+8>, r=...) at basic/source/sbx/sbxvar.cxx:45
        > #10 0x00007ffff517d44a in SbxMethod::SbxMethod(SbxMethod const&) (this=0x31ff450, r=...) at basic/source/sbx/sbxobj.cxx:838
        > #11 0x00007ffff510386b in SbiRuntime::FindElement(SbxObject*, unsigned int, unsigned int, ErrCode, bool, bool) (this=0x2d6f400, pObj=0x2003400, nOp1=32773, nOp2=9, nNotFound=..., bLocal=false, bStatic=false) at basic/source/runtime/runtime.cxx:3709
        > #12 0x00007ffff50f5a91 in SbiRuntime::StepRTL(unsigned int, unsigned int) (this=0x2d6f400, nOp1=32773, nOp2=9) at basic/source/runtime/runtime.cxx:4131
        > #13 0x00007ffff50faef8 in SbiRuntime::Step() (this=0x2d6f400) at basic/source/runtime/runtime.cxx:830
        [...]
        
        Change-Id: I552f0360aaf3f9aa6a499aa5ea6eca9ae37e4614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-18  Michael Weghorn  <m.weghorn@posteo.de>  [cfa5489982a84f847d86b8bf8ce49b25e033ed48]

        WeldEditView: Just pass new Size object as param
        
        Just pass `aOutputSize` as parameter instead
        of assigning that to `aSize` again and then
        passing that one as parameter in
        `WeldEditView::SetDrawingArea` and
        overrides in derived classes.
        
        `aSize.setHeight(aSize.Height())` can just be dropped
        as an overly complicated way of keeping the
        height as it is.
        
        In `SidebarTextControl::SetDrawingArea`, `aOutputSize`
        was already passed as param, so the new value of `aSize`
        was ignored anyway.
        
        Change-Id: I23192d3c5c85e4371a48774b3b8f854beb751b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131741
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-18  Johnny_M  <klasse@partyheld.de>  [8a4f58bcd76c2c5824b014efb35ed818907527b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af54aee36936ee0a00ba384b6a2f68b482787103
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib22f113740fd2b705df3b4338453d325739c20f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131439
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [8fb1676342cb228f9a3cbfe9603b74555dd7aeee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b19c37e8c418e90ae419f596969e4fa897077d7d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9586b4e55c96ed7587246a923524d34ffa26be16
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131438
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [d7dd3b5c423de3d259fbbfea5acd67784612dc95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e18bd4f9f40f51745b23ddb9aaa6740d5707771
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0a6ae497bf145ad4d6c6d30a83d2153a8350ea4a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131436
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [be42eeb21d2ae4e11dbfc272fbb900a0ce28bdf4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14a3f2ff9c37fb6899eae197cb94f50e1ffe7ee0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I14163e5b63027d4c6f4178e9db55369e383425a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131437
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [9e8f5f3f57478c157677e8a515d25bd47790ce00]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cc1e063e4079cd2f1cd8712f68ae546b85521ae
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2301032cce30fa40dbaea24f8e90c068586e49e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131435
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [890d2166f0966f4b2b60c9b6f8affb4237a58e79]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3afad289ad1faf5b556f724b9ef0c610f5b95264
          - tdf#132643 Translate German section IDs
            
            Change-Id: I527837a7ac78b411ed61f34e9d4c76b786c0b237
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131434
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Michael Weghorn  <m.weghorn@posteo.de>  [0f3f71cc3470b9d15ae5e35eb206040897e74135]

        gtk3 a11y: Rename drawing_area_get_accessib{ity -> le}
        
        "...get_accessibity" looks like a typo, but
        "...get_accessible" fits the naming scheme better
        anyway.
        
        Change-Id: Ie71ade5bb2ef58ac23ecff0efa5adaae792a9620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131738
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-18  Johnny_M  <klasse@partyheld.de>  [08090c81d84f2cdb846e120305638abf0abdc800]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7069eb7f582ca21299bfd3cc7f5decfa402725c0
          - tdf#132643 Translate German section IDs
            
            Change-Id: If85502fdc918d3b2814231faeb69211ad2d7bc82
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131433
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [d30c444314c7fdd36ab5967771c8474f33772f2b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d4cb0152bed3af90c4d2a09e35e472382213dee
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iafd82777eddf78a2d581f40dc7d94fed79929326
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131432
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [aeee02a72b508977833ce024420460e9991486ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c88ef67ff0902af8446b02529155268a892cd1f1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3f57be7c55f9376948f51a316646bf839685bd80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131431
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [318eb8b79d7fa5782da1bc4a502ee119950157ac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e0b454a0e8d1bd824f67a07f53192a700247976f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie8b8cd42cc943a853170531f932273b65e360d6f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131428
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [94aedc6aa30a47402d3c49fdb415a56d98957a45]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c08f9ca2f921f8994aad1e8956b15c525668934
          - tdf#132643 Translate German section IDs
            
            Change-Id: I484aaae6574871e5fd4171581318fbc83752b8ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131430
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Michael Weghorn  <m.weghorn@posteo.de>  [dadc8a8771645d475b6287dd4c65b88cdad81d93]

        a11y: Drop vcl::unohelper::NotifyAccessibleStateEventGlobally
        
        As mentioned in
        Change-Id I4681c28c9d18cf1953be5127765f4aa94563662d
        ("chart a11y: Drop bSendGlobally param from AccessibleBase::BroadcastAccEvent"),
        calling it has no effect, the `fireFocusGained` and
        `fireFocusLost` methods of the `XExtendedToolkit`
        interface in its only implementation
        in `VCLXToolkit` do nothing, so just drop it.
        
        Change-Id: Ie9352a4e4021d7bf0b35de71f55afc660795b906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131736
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-18  Michael Weghorn  <m.weghorn@posteo.de>  [fe09f12d83d934287c58f507a99b693212a84c79]

        chart a11y: Drop bSendGlobally param from AccessibleBase::BroadcastAccEvent
        
        Setting it didn't have any effect in practice:
        If set to `true`, it resulted in
        `vcl::unohelper::NotifyAccessibleStateEventGlobally` getting
        called, which calls
        `XExtendedToolkit::fireFocusGained` or
        `XExtendedToolkit::fireFocusLost`, but the only implementations
        in `VCLXToolkit` do nothing.
        
        Interestingly, the documentation for `XExtendedToolkit` in
        `offapi/com/sun/star/awt/XExtendedToolkit.idl` says:
        
        >    @deprecated
        >        This interface was only implemented in an intermediate developer
        >        release anyway.
        >
        >    @since OOo 1.1.2
        
        but the interface is still used in various places across the
        code base...
        
        Change-Id: I4681c28c9d18cf1953be5127765f4aa94563662d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131735
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-18  Johnny_M  <klasse@partyheld.de>  [38bc4742af4f96d26b81bdc41e0361d83d8f1f66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71f848d75265dbe7604af1b6aa170dc1aee11a89
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic2f22070b53266a12fcd2216e3e39ae12a7f11eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131429
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [6803a3309e064cda675141a2abb8d7f280e3420b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c629be9e6a24d4d73d849ceadd6d7f7cbb838f40
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Id8963dbe736314e167313e22e7ccb5513bc338be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131427
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [8e4324c0e1a74ef45d1c7602e1e0eb171cc5b614]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab9809abb7b9473a33bf8e4b185e1ece10a02bea
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib28cbc143b0a353bcbb024976a88a7e5823caf00
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131425
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [f19eae7e54f557b5baf02b36d95448e8ffc4c83f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 061aa40ba8f024628eecbb131a8b6b05c2e5dd0a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie62798486a3178bd341a72d5b4f477a46e6aeab8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131424
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [ddb2764f4d98c043160adf1c29ba102b3ef0ed7e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b60695989e6ad58d83dfebebe132f4914923938
          - tdf#132643 Translate German section IDs
            
            Change-Id: I40bde7ec9b387d337b3dcb2f5cd75f3b4f3d1dc2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131422
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [fe85a53f97ef38d31c84a7f2e182b6cb93fd40be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bc2c3db33139954b323d387e44fbe1374efbf2e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4a61d58100e28f8975cac375f982654ce8ea5099
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131423
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [a717a1bab852656d2e220754632eff384138f735]

        tdf#133603 increase cache size in CachedOutputStream
        
        modern devices require bigger chunks of data to keep them busy
        
        Change-Id: I356327718fc20d937364b6ee726b0e94b4199e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-18  Caolán McNamara  <caolanm@redhat.com>  [d277de1eac9ddc00eff3e5801ab29d8e8a9a3af7]

        ofz#45675 Timeout
        
        Change-Id: Icd893d6e0361f9ffe2c88b20b08eaef32919d01a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131718
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-18  Johnny_M  <klasse@partyheld.de>  [af55f4bdc9c067d7738472382c9a153b25b781e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01b8ee4ec65478ce46ce0f78423a4e55170f9b85
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic89725bc9d774f291bff2dada0888abe6d855c0c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131421
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [071e4b32f8bded89c16acde834035924f4f698e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bddd19a60f428195ebf29919fcc5886a93d203c7
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie11d36a733dfa94584306bed9b9d2873bb3ea23a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131420
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [4ea7a6fbc333a685283dc8a4409701042d628b9e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c416cf52fad8a4c5b3995c8ebaeff6fb8ca11f37
          - tdf#132643 Translate German section IDs
            
            Change-Id: I669488bec98e228aa2ad49773e226850dc3d85b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131419
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [8c46b01f575a3acd50d47f5d8299234218dbd393]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01240c16ba2314ad60d6395d88cf864f99a2776d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8ab12229bb36025f93895a807ea2c29b35e63916
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131418
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Johnny_M  <klasse@partyheld.de>  [7a6e61fd0c0c461129d0f970ee601bdddc43b46a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 73273a2766552382cdc55f4e953f7af65082de7b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0f36c3de1612d204ced34fcad5a424f7e13818b1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131416
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-18  Mike Kaganski  <mike.kaganski@collabora.com>  [21b17ba1e6ac3eb3c54a6613f5f66a7d5588850b]

        Simplify a static array iteration
        
        Change-Id: I7dc4fdcbbaef08c1bc3b23403cd13e2c23585f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131733
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbb41798b86c5ed35eb80aa07a5ee7c9866ac4e8]

        tdf#133603 remove some string copying
        
        Change-Id: I5b9f011d276ec30a50648e7984862b9e5f4b5577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-18  Eike Rathke  <erack@redhat.com>  [6b768542ddd52573bbdb0e7b5b85ce5a9dd4551d]

        Resolves: tdf#148054 Advance offset for all columns, tdf#104927 regression
        
        Regression from
        
            commit 621c189173b35ac7f5ce4c578f57045479c63ab6
            CommitDate: Sat Jan 9 05:13:55 2021 +0100
        
                tdf#104927 consider character width for CSV import
        
        that for fixed width introduced a visual count of character widths
        for CJK IVS characters but did not advance the character offset
        for skipped hidden columns.
        
        Instead of having to ask bDetermineRange three times in the loop,
        split off an extra loop for bDetermineRange, advancing the offset
        then is straight forward and just only non-skipped columns are
        extracted and written to document.
        
        Change-Id: Ib6ab6b68c5fc0f6ff854d629d75742c39ed6ddf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131722
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-03-18  Miklos Vajna  <vmiklos@collabora.com>  [0da10420ed6e69384498de7404287e8c936fef14]

        sw clearing breaks: add DOC export
        
        Map SwLineBreakClear to sprmCLbcCRJ's LBCOperand.
        
        And most importantly, write the newline character: a clearing break was
        not "downgraded" to a plain line break previously.
        
        Change-Id: I3bc11a120af09d5c774df992cb17cfc5ee251e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131732
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-18  Stephan Bergmann  <sbergman@redhat.com>  [7dd087002816cdde9a5049a36840446765061fb8]

        Improve a mis-translated comment
        
        ...which was the German
        
          // Falls wir ein Schweinezeichen haben, abbrechen!!
        
        until 3d361dbc2d69484657c42852dcfa426c00bc3175 "Translation of Comments to
        English"
        
        Change-Id: I655514ec38596d16b15d22a02f38d0cf60b80302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131726
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb53cc2a92886b83dcf5f9de762c82b1144f912c]

        tdf#133603 reduce some ref-counting during XLSX save
        
        Change-Id: I02ed854ba57c7f513205f65ec84cb4e08d3b068f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131728
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cb91a40e20b0ea405042429a1b497bf3c983e01]

        tdf#133603 cache languagetag in FontSubstConfiguration
        
        speeds up saving XLSX by 10%
        
        Change-Id: I5f48fcd3de44675d27e275c6ff2f4e51a067c750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-18  Miklos Vajna  <vmiklos@collabora.com>  [f451878ccff475dd263ad67ade5e1896cf9fc734]

        sw layout xml dump: handle expand portions
        
        Towards adding dumpAsXml() for all portions that have a HandlePortion().
        
        Change-Id: I9cb1f4c1f966e5cfd7ca27e21bf8aa022979f3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131724
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-18  Mike Kaganski  <mike.kaganski@collabora.com>  [9bdc79bf46744d92242c14e9e6978dc590e953ea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 87ab46fd2271fcf09ffc8a94bc403c3cf7082752
          - Fix service name
            
            Change-Id: I3f8fcc74afe4ed64c64a5ee8beb41fe289ec7763
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131604
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-03-18  Miklos Vajna  <vmiklos@collabora.com>  [1868dea877b0c956ee34e92afad59920e66cad3f]

        sd theme: add ODP import/export for shape fill color
        
        Refer to the 12 pre-defined colors by name + don't write the attribute
        for the case when there is no theme.
        
        Change-Id: I37c984b3371ec878a0d733977f5c937dce27c440
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131717
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-18  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [778bbcede813dd51e11ee61583247db1199eda63]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Ic881e63c2464adbe89e3abf8bc6626b674c38129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131723
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [d64ba1048716767db6fd3daedb637df193c7071b]

        Related: tdf#148053 fix a crash in out of range dx array
        
        also seen with tdf#124116
        
        Change-Id: I211c5b9d58ee5857c8286b2009e4159b35a9e047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131713
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [2c2b3aaa5ba15087aac06b762cc4b767eaea6cac]

        crashtesting: clip fallback glyph range to layout range
        
        as seen in tdf124116-1.odt
        
        Change-Id: If81192d326e298794051a87632e63798402ff60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131712
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Lemures Lemniscati  <lemures.lemniscati@gmail.com>  [fb48a6408a515057a03c485bf00df5c34706595b]

        tdf#148033: Loss of precision in /MediaBox (PDFWriterImpl::emitCatalog())
        
        License statement provided here:
        https://bugs.documentfoundation.org/show_bug.cgi?id=148033#c4
        
        Change-Id: I93333a17d4a6a266fc25a92abf50c22cb01a2b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131716
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-03-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fab611b2310579962fe74b86e537f1812431f761]

        Fix typo
        
        Change-Id: I7962b8fa81bd6510bc83b7656d84486806bd81c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131719
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [05ad57ea76b088569e5c34d5ff08342d8e894e1e]

        ofz: Null-dereference READ
        
        Change-Id: I0e3dfed65db245779d3402293d23864b0a4fb6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131705
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Szymon Kłos  <szymon.klos@collabora.com>  [feb8e7c58dc72d01febc914fd6575757f3f7e746]

        jsdialog: enable dialog on demand by env var
        
        It will be possible to enable some dialogs by environment variable:
        
        SAL_JSDIALOG_ENABLE=modules/scalc/ui/validationdialog.ui:modules/scalc/ui/validationcriteriapage.ui
        
        (you can specify multiple items with ':' separator)
        
        Change-Id: Iba1e6b7ac77716f40c9073a8064206c420f2d081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131597
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [8cf99c39b5dba7d1dbfda70e73ee3a8388037325]

        Use ScDocumentUniquePtr in ScTempDocSource
        
        Change-Id: I17d726aba52dd25f221f2ff3e9238f935afa4de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131715
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-17  Miklos Vajna  <vmiklos@collabora.com>  [9e8712ed6f9fb5dbd971e352a5709bd45fadc74f]

        sw image dialog: fix fallback width/height for images with relative sizes
        
        Make sure that we work with the up to date layout size of the image in
        the dialog, otherwise 80% shows up as 237%.
        
        Also fix SfxMacroTabPage::FillItemSet() to not put anything to the
        output item set when the macro table is empty, this way clicking OK in
        the image dialog results in an unmodified document when the user doesn't
        change anything.
        
        Change-Id: I4b987bd3e3818ee737e37ea10861f9043c25bc93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131714
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-17  Julien Nabet  <serval2412@yahoo.fr>  [52a695d2ceb4231a9fcc419959e29023ecef037b]

        Related tdf#114286: put duplicates commands in GenericCommands (DeleteRows)
        
        Change-Id: I100297d10b2643c5ddad7753a7c1032526ce06cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131699
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [e1e65c9388a9f2fe7b8dc34a5a10f14f08635720]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I7d9bb71cc3448e5552005ecac580e50073260e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [8e5bc762d8b1bf80e1d2fb7706b03978acc5082f]

        ofz#45598 Integer-overflow
        
        Change-Id: Ib3c6f9af746693678f9b031a23e4a703d0615b0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Caolán McNamara  <caolanm@redhat.com>  [a89c16d8f37effc1be0898fc268d7b88c0157407]

        can use a reference instead of a pointer
        
        Change-Id: I3811c9d24e4890022be7c6179148d0eac0e5525c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Mike Kaganski  <mike.kaganski@collabora.com>  [7f58df88771767962fc4e98f2b6bed445ab18994]

        tdf#148040: allow external link update for css.sheet.FunctionAccess
        
        Change-Id: I2608c10fd3354e90049d1c7315895922c865a648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131682
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6898a115426de6c3142521587fa693914fbe553f]

        Colibre: tdf#148029 Remove dark area in dark variant
        
        Change-Id: Idac844f8b84e80c590f0909235523e3e5a31c4a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131685
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1cfa579c988057830a83455946448d804a0926e]

        use actual type in AccessibleImageBullet
        
        instead of casting everywhere
        
        Change-Id: I954f6f1ef18baa7888d7447d64e8e7a8e5141a13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131709
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0cdfe74271c1544e4b6bdc2bcd1ec087d672d81c]

        use actual type in AccessibleEditableTextPara
        
        instead of casting everywhere
        
        Change-Id: I98b654fd93eb8cea49f2e6a399a986e45ed8381d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131708
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7fccffa78a26641053268b9c9e431156ce628552]

        use actual type in AccessibleContextBase
        
        instead of casting everywhere
        
        Change-Id: I547ad294e612488aef11788bb54e086897c19f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  László Németh  <nemeth@numbertext.org>  [794fd10af7361d5a64a0f8bfbe5c8b5f308617a5]

        tdf#147347 sw: hide deleted table at deletion in Hide Changes
        
        Last deleted row of a table frame was visible in Hide Changes
        mode, if it is deleted in Hide Changes mode.
        
        Fix also missing immediate update of the table layout during
        deleting only rows in the table.
        
        Follow-up to commit a74c51025fa4519caaf461492e4ed8e68bd34885
        "tdf#146962 sw: hide deleted row at deletion in Hide Changes"
        
        Change-Id: Ic0bf09ac68dd336bd53e84e58f52ebe88ca56238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131701
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-17  Luboš Luňák  <l.lunak@collabora.com>  [b804a64bf78218b79e5e9ca2e99aa95bee60b430]

        avoid warning about invalid cached glyphs
        
        Empty string has no glyphs, so SalLayoutGlyphs::IsValid() will be
        false and would trigger the warning at the beginning of
        OutputDevice::ImplLayout().
        
        Change-Id: I1be55679f27ba663570659f72c57e57e60f49a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131700
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [7de27fe664f2fbb310907b5f945010792cd79ed3]

        Call corresponding base class method in SpellDialog::Deactivate
        
        At a quick glance, the fact that `SpellDialog::Deactivate`
        previously did the same as `SpellDialog::Activate` looks
        like a copy-paste mistake; both were added in
        
            commit 5261417cbb3051b812164838d19c0f748573df45
            Date:   Fri Jun 14 21:56:44 2019 +0100
        
                weld SpellDialog
        
        Change-Id: Ib06d19e46470141d5bfcfc7e790160c1879b6a00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-17  Miklos Vajna  <vmiklos@collabora.com>  [71b952340726190d1f178ef0dadfa89677f2c1dd]

        external: update pdfium to 4933
        
        Stop tracking build_config.h in our repo, it can be now part of the
        release tarball. It was a mistake in the past to think that this is
        generated code, it's just external code.
        
        Change-Id: Ife2fed362e28c53859399244e2f1247efb1efe86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131695
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-17  Miklos Vajna  <vmiklos@collabora.com>  [31ac4edf2ec83c9f6ec475ad74e5fd94a0c8b1ca]

        sw clearing breaks: add DOC import
        
        Map sprmCLbcCRJ's LBCOperand to SwLineBreakClear.
        
        Change-Id: Ie6a114bcd90a9442295815da68f6b0a9616c3210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131697
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-17  Julien Nabet  <serval2412@yahoo.fr>  [7a7bf6afcdb8f069e750ac8cd4126930674e3f4b]

        Related tdf#114286: remove duplicates commands in Calc/Draw (InsertAnnotation)
        
        Change-Id: I745e8d06c7f9886421ff95426c6cb4cee8198cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131679
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [229012b4a5546c4611e3ff789432806d1b301e4a]

        cui: Use more range-based for in SpellDialog
        
        Change-Id: I566af40d67154ee8891c97257b6ef232556fe1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131688
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [58f29c4f1de3e116aec62d69b0921f2ee44b8c70]

        cui: Use range-based for in SentenceEditWindow_Impl
        
        Change-Id: I0e324d6b961f632130974d90f22345122650b666
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131687
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-17  Michael Weghorn  <m.weghorn@posteo.de>  [684502c24b5f0f5e67c189e79d9f3ffa79d1975e]

        cui: Use range-based for in SpellDialog
        
        None of the widgets should be nullptr.
        
        Change-Id: Iaaa2528571a7f301c5fab5ddf938494ed1c57f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131686
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-17  Julien Nabet  <serval2412@yahoo.fr>  [763e5d233d18a26f64dd8c4db67ce62ee289832e]

        Related tdf#114286: put duplicates commands in GenericCommands (DeleteColumns)
        
        Change-Id: Iecfa09729ea1b237fb6994be4b3ceaaa3ad126df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131680
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-17  Miklos Vajna  <vmiklos@collabora.com>  [1b556ae4d1a5ae73ceb0baf52aae01dc05eaf61d]

        sw: document SwXViewSettings
        
        Which is a bit confusing: there is separation between the views while
        running, but only one view saves its config to the user profile, it
        seems.
        
        Change-Id: Ie5c5ae782860e1b93dc9096be893acff7e555aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131674
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c8933594a4ea955eb4e785c7507d011c96c2aad]

        tdf#148013 speed up loading large file with lots of redlines
        
        We can skip lots of the table by using the binary search.
        
        Change-Id: I8c85cd4700bd1859cdc61a08159c61b1ab632163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Noel Grandin  <noelgrandin@gmail.com>  [ddff74993f128bd7b25d4d041b18b43b5836e11d]

        no need to have duplicate m_bIsRoot fields
        
        Change-Id: I4f8777462d0bb8cb9f1a6065a548a794d842d815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Noel Grandin  <noelgrandin@gmail.com>  [9a9bb1f212bb7eb40dcf34c15a3422e633fc195d]

        no need to have duplicate m_nStorageType fields
        
        Change-Id: I65bfce88e2bb1d32ec6c292e7e5f020904405bed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131677
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Gülşah Köse  <gulsah.kose@collabora.com>  [f8ac4be066b9277cf2f893b581adc33de841bb9e]

        tdf#147766 Export empty lines as line with noFill
        
        We have a case that 0 width line but has auto color. If that case
        exported there is no line over there, LO handles normally but MSO draws
        back borders as default. To prevent this we have to export them as line
        with noFill.
        
        testTableBorderLineStyle change reverts a workaround for
        3faf005a367cbd28077403bf93810bbaf4805851
        
        testBnc480256 Cell(1,0) still invisible. We are just checking
        this with another way.
        
        Change-Id: If5f6d2dbdba5c295d58307fcfe3b37629ede8a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131532
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-03-17  Julien Nabet  <serval2412@yahoo.fr>  [345149ef7b22fb05a2f519132704e36804570eed]

        Remove old mysql_jdbc/mysqlc in drivers.xcu
        
        and retrieve 2 missing items from it into mysqlc part
        
        Change-Id: I7494ca420e89f267659c06ef5f519790d47b3508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131681
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-17  Noel Grandin  <noelgrandin@gmail.com>  [17d2cf30760876b07292958d8c90965f01a33efb]

        flatten OStorage a little
        
        Change-Id: I4a380d036c3e94f2df41d2c583d51f574d2c161d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131675
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-17  Justin Luth  <justin.luth@collabora.com>  [6ba3c85aad33ad3eded935185686dfcaaa7fcaa8]

        tdf#119298 sw: keep automatic position on trivial width change
        
        The issue here was that simply moving the border around
        (which shouldn't change the table size at all)
        triggered a miniscule difference in reported table width.
        
        Well, that is not enough reason to change away from automatic
        positioning now is it?
        
        Change-Id: Ib40c50a1069d88fa22f4791366eb0a50b4e9b11d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131633
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-03-17  Jim Raykowski  <raykowj@gmail.com>  [94016b435404f19d84ed636c5b3fd1ab0c02e020]

        Notify Navigator when outline content visibility changes
        
        Change-Id: I1db018216eb37517192f87c5c22cd0b9e6319687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130472
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [f7aeeb2e1a9b90b538a3715c5b73abe52ce7ee68]

        ofz#45581 and ofz#45574 suppress Integer-overflow
        
        Change-Id: Ia32f0ae42e4ac45681749e25d95f3c84359396d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131683
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [a3f400886768bf95fbd8e6b236e11d7aac393b96]

        Related: tdf#118320 enable some windows dark theme support
        
        If experimental mode is enabled and only for windows >= 10.0.18362
        
        Toggling from dark to light mode is detected, and getting some
        suitable colors for dark mode works.
        
        The titlebar will toggle into dark/light mode successfully.
        
        DrawThemeBackground does something sensible for buttons and scrollbar at
        least, comboboxes can be forced to work. SpinButtons are less
        successful. Menubar and toolbar just bodged to draw a solid backcolor.
        
        Notebooks/TabControls don't respect the theme.
        
        Its possible it makes more sense to not try and use the windows control
        drawings apis and just set some dark colors and draw with the old
        built-in vcl widget rendering or alternative.
        
        Change-Id: Ic7927fb9af7ec94444d9de6e0204560e2789be46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131453
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [45f9c1862bd205f620ce21663a8cd91119b9b2d5]

        ofz#45612 Timeout
        
        Change-Id: I9c6f955b243f9f5027c4b702853e6dce546054a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  Stephan Bergmann  <sbergman@redhat.com>  [10981fb2fa26474f432e85165b1babbca6d74e16]

        Consistently avoid loplugin:trivialconstructor when there are defaulted params
        
        (The template default constructor in S8 had already been suppressed via
        
            std::distance(recordDecl->ctor_begin(), recordDecl->ctor_end()
        
        being zero, but the similar case in S7 caused a warning.)
        
        Change-Id: I4d18dec8bb971198eb8503262572a08c019c66bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-16  Stephan Bergmann  <sbergman@redhat.com>  [a20e0ae4e346dae93bacf25deff2e7fbcbf1dbe1]

        -Werror=unused-but-set-variable
        
        (with --disable-assert-always-abort --enable-dbgutil,
        <https://ci.libreoffice.org//job/lo_tb_random_config_linux/3741/>)
        
        Change-Id: I46c4ed35e1882a98bde4022681624ae6c94031b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131664
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [fe407fa6ff9cb7597f06e891ea3f136cd9521ef1]

        ofz#45583 Integer-overflow
        
        if we currently ignore 0 width/height here presumably we could also
        safely ignore negative width/height cases
        
        Change-Id: I3c061cdeebb1a6c684920977ee67e3ce156fda95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131668
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  Julien Nabet  <serval2412@yahoo.fr>  [f5c3b63b6fdcc7638a3a2683b2f58e6c15758385]

        tdf#147997: MySQL/MariaDB for dialog for direct connection
        
        Expand a bit rebranding to JDBC part and other locations
        
        Change-Id: Ia48972996b3eb3be0341d7d93a0ba1dc69fe0057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131632
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-16  Tushar Jham  <jhamtushar12@gmail.com>  [00937d1207394433970a4711fa4f51b072341290]

        tdf#141908:CppUnittests: replace usage of sal_Int32 with Color
        
        Change-Id: I8ce73250da932d2c308a93a9268170ba9a120301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131125
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-16  Heiko Tietze  <tietze.heiko@gmail.com>  [a3cb71ac80c0c2971e97c033d212cf4e464fa8f0]

        Resolves tdf#143100 - Disable cell style commands when sheet is protected
        
        Change-Id: Id532bee30ebd550df3a55074aec94a1f92aad564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131665
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d349d84bd8fcbb38f7809e140bc8591056c6c29]

        tdf#148013 speed up loading large file with lots of redlines
        
        We can skip lots of the table by using the binary search.
        
        Which is not actually a lot of use for this particular bug, because it
        contains bad redline data.
        
        Change-Id: If2a7a807723ec19f15d6f7fa011d75ea82bd6d1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131660
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e7895fbacff945d38f679f504c179a417e3b9af1]

        tdf#109214 - Highlight the favorites in the grid of special characters
        
        Change-Id: Ie1bb019495d2db4acd92da4bccf44ece2bd1d976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131446
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-16  Miklos Vajna  <vmiklos@collabora.com>  [b578fa08a25a83abccad2386e12b707586fffb26]

        ODT export: fix fallback svg:width/height for text frames with relative sizes
        
        In case <draw:frame> has style:rel-width="..." and style:rel-height="...", then the ODF spec says that:
        
        > To support consumers that do not support relative width, producers
        > should also provide the width in a svg:width 19.575 attribute.
        
        If the motivation is to support simple consumers, then it's better if we
        write the up to date layout size as the fallback value, not what was the
        layout size at insert time.
        
        (But don't ignore this at import time: 80% width and "scale" for height
        is a valid combination, and then height/width is needed to know the
        ratio.)
        
        Change-Id: Iefeb43cdb141b01a732086c37186201a3fef0952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131662
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [3eecde27009b74a7f3bf75809109a2367e262b09]

        throw away skia control cache on theme change
        
        Change-Id: Idd21e966cf2c9b246c7484ba6c118c872a3dbac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131568
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  László Németh  <nemeth@numbertext.org>  [3a14b2040ecd95a23acbc3e8d0f8087505135f11]

        tdf#148032 sw: add redline comment for tracked comments
        
        Tracked insertion/deletion of comments were shown as
        plain text insertion/deletion in that case, too, when
        there is no other text change in the redline (only
        the invisible placeholder character CH_TXTATR_INWORD
        of the comment). This was fixed by the new action
        icons of the Manage Changes dialog window before,
        but for better accessibility, now redline of a newly
        inserted/deleted comment gets also a redline comment
        "Comment added"/"Comment deleted", shown in Manage
        Changes dialog window with the Comment added/Comment
        deleted action icons, as suggested by Heiko Tietze.
        
        Note: because the redline comment (at least the
        tracked insertions) are stored in the document,
        this is a back-compatible solution.
        
        Follow-up to commit 128d3b454467e34538903b2eab45e866f976b314
        "tdf#73125 sw: add Insert/Delete Comment Manage Changes action icons".
        
        Change-Id: I7a9e82ae1b9519e4883956f69de0aafc289f7f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131659
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-16  Stephan Bergmann  <sbergman@redhat.com>  [0c50141cfc475768debb77127bc8ebb173b4a30f]

        Fix loplugin:trivialconstructor handling of ctor templates
        
        Change-Id: Ic8b2f26498099c77b834d8e152f06d2834dfee3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131658
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [26623cc6c144c451323a08be7bd021ae354b1a95]

        tdf#93951: sc_ucalc: Add unittest
        
        Change-Id: I3aaf896e2b3b9b4f2d1421abc591b8ec94a039ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131657
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1a81dd99da155cc84301b034a94bffa3a767911e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5aacf4b1d2bf97085ecf94becf9e026bfa80f0c
          - Add precisions on Option Compatible in BASIC
            
            Change-Id: I7759df12c05dfad209ebaca8747d2daa1d210f09
            ref: https://gerrit.libreoffice.org/c/help/+/74812
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131473
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [eae375a224b44cd5bb18e180732668668ee9178f]

        tdf#64639: sc_macros_test: Add unittest
        
        Change-Id: I0679ae2d129cd5f1445d03a5932b83ec8779b203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131650
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-16  Caolán McNamara  <caolanm@redhat.com>  [02f30509f8b19d862b569fab480617808f2be2a7]

        ofz#45598 Integer-overflow
        
        Change-Id: I1b997a35630bdb3a14fe606c9a34faf4330099ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-16  Miklos Vajna  <vmiklos@collabora.com>  [a64eae6ae3ce47d70f7d56aabd3d4a385c69c1ca]

        sw clearing breaks: add ODF import
        
        Map
        
        	<text:line-break loext:clear="..."/>
        
        to com.sun.star.text.LineBreak and set its Clear property based on the
        XML attribute.
        
        Change-Id: I76d375de23146592c2327df16aa5066ee2a6598d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131645
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-16  Justin Luth  <justin_luth@sil.org>  [cfd82e7a2cc2b45b738eb0efa0827196d2de61a4]

        tdf#128747 chart2: don't overwrite labels
        
        In almost every case, the values of a labeledDataSequence
        create a new column, and therefore the label is attached
        to the last column.
        
        However, in the case where there are no values at all,
        then this function is not called (for the value portion),
        resulting in no new column being created,
        and thus the label overwrote the previous series label.
        
        Empty-value columns are excluded in later code,
        so perhaps we shouldn't addDataSequenceToMap either,
        but I don't know the implications of that.
        
        Change-Id: Iad4ab54552b3c6b144feb2bc223ddae538316fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130946
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-03-16  Pedro Pinto Silva  <pedro.silva@collabora.com>  [baebd26c3548609872e0c523add135afa3dc66bf]

        Sidebarparagraph: Replace generic ids
        
        Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
        Change-Id: Ic6f0195c272f0442dc96cfff0321e15461f8bbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131616
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2022-03-16  Jean-Pierre Ledure  <jp@ledure.be>  [3044d81586365cd35b6f3ed51b7be9ec4f50638d]

        ScriptForge - (SF_Form) fix use of BaseForm
        
        Context: Base documents.
        
        In a form or formcontrol event, a user script might
        need the name of the form document in which the form
        or control is located, f.i. to close it.
        
        The name of the form document is supposed to be found
        in the SF_Form.BaseForm property.
        
        The property is set correctly when the Base form document
        to form/formcontrol path is taken (top-down), not when the
        opposite path is taken (bottom-up), typically in events.
        In the latter case BaseForm is equal to an empty string.
        
        The actual commit initializes correctly the BaseForm property
        with the hierarchical name of the form document.
        
        Change-Id: Icdee6ee9909f577f6c01ba96864fe3d6eaf3e750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131618
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-16  psidiumcode  <lbrmk.510@rgn4d.neomailbox.ch>  [5b320aa058504becae6ac6746926b481b326a24d]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: Ia711e939f769c6a2257bd1fb3607b315f931a0ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131634
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-16  Miklos Vajna  <vmiklos@collabora.com>  [47d0a7f4fb08b994cfea83c5deba085d27f75ac2]

        sw: prefix members of MSWordAttrIter, MSWordSections, MSWord_SdrAttrIter ...
        
        ... and SwWW8AttrIter
        
        See tdf#94879 for motivation.
        
        Change-Id: Iaa5b84d7ae58ac4b20d3e0f419fbcb44f895b270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131639
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-16  Jim Raykowski  <raykowj@gmail.com>  [b802cecbc0f57d0ba0d70434cf619a7e91c7393f]

        tdf#86395 tdf#104253 tdf#147658 tdf#135043 SwNavigator sort enhancement
        
        Provides for sorting content members by order in document or
        alphabetically. The option to sort comment and footnote content types
        members alphabetically is not done by this patch.
        
        Change-Id: If68c08bb0f1035b32cd1dad1d5bd08a340834b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131448
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-16  Heiko Tietze  <tietze.heiko@gmail.com>  [2e8cbf38b760d2d5d76048542f15962b94acc03a]

        Resolves tdf#35030 - Hide Reset button for keyboard customization
        
        Change-Id: Id69f2fd6ed5d33a622088886b25d1f61d7eb2516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131534
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-16  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [bcede3c0ed94d413fea18d2457b916a9f5f4346a]

        tdf#146851: sw: even numbering=None is still a numbering
        
        Text node containing a numbering rule with numbering format
        with SVX_NUM_NUMBER_NONE is still a numbering: it will display
        prefix, suffix and other numbering properties.
        
        Change-Id: I52077824b4a1db2e9220701fdd514670490a59db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131410
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-16  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [f50a8f1d8852bfc143809dc5d45ef662d3557a61]

        tdf#146851: writerfilter: do not recreate list levels on override
        
        AddLevel() can be called on w:lvl and on w:lvlOverride. But if
        we have level override and some extra level definition level is
        recreated and override information is lost.
        
        Change-Id: I6f1b9b50bdd3410b4ae2d403e760e4d6df5677d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131304
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [31eca81bd03f012f0581480dd6f581a0185e3ff5]

        sw: split CppunitTest_sw_uiwriter into uiwriter and uiwriter7
        
        Similar to a2a2e07996a0e49164663eaec5d79481bf7bb3e0
        "sw: split CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5"
        
        it already had 117 tests
        
        Change-Id: I6bcdcd672c655b853f8f366db3b78d3da49f9078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131635
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [ad1f6e62298612f4b277708b813a219ba390f1b0]

        handle broken row ranges in excel import
        
        LIBREOFFICE-39G76603.xlsx from crashtesting has broken data cause
        assertion failures about the ranges being sorted (because the ranges
        overlap and StyleRowRangeComp needs and assumes that they do not).
        Changing the std::unique() call to remove ranges that compare equal
        (which is not the same as being equal, due to how StyleRowRangeComp
        compares) and sorting again seems to drop all problematic ranges.
        (I'm not adding the problematic file to tests as loading it takes
        a lot of time.)
        
        Change-Id: If6ac94959a649a641d02fd703d33edddbdf0fb85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131637
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [1fa46653315810a579009f712f2c1bbdf1f5fd44]

        fix comparison operators in Excel export, #2
        
        It turns out that the end-vs-start comparison was intentional and
        the file causing problems is broken, so more or less revert
        83d599fd7c530d14f70ac60bd673b66640191bf7, and I'll handle
        the problematic file in another commit.
        
        Change-Id: I5c7538a7c3eeea9c5fd1661e1a9a2c3370b799c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131636
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [8da06340788296e5004f1625fc39fbf2a4c93fc9]

        -Werror,-Wdeprecated-enum-enum-conversion
        
        ...after 3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 "tdf#145614 Convert #define to
        enum and constexpr"
        
        Change-Id: I3ef1d17295e99c040125acd4b03fd5096848a0e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131630
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [1dbed50a6ed73570ca2d8a1e37237205e2394c34]

        tdf#134065, tdf#147998: fix thumbnail generation code
        
        This moves the code drawing thumbnails and overlay icons away from
        RecentDocsView to RecentDocsViewItem, where the final size of the
        thumbnail is defined, so that no scaling of pre-painted icon would
        happen.
        
        This also restores the SFX_FILE_THUMBNAIL_* to state before commit
        d43c6fa220524a09c0b24cbb5bc03c4456cd2515, and introduces a new set
        of SFX_FILE_OVERLAY_* to be used for the overlay icons. This fixes
        the display when RecentDocsThumbnail is disabled.
        
        Change-Id: I5eb4aed5325459ddec7e196300cf6c2f9ddf80b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131610
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@centrum.cz>  [c0361119dfb5a1accfae9f777844e22846af8ecc]

        set LO_TESTNAME on startup on all platforms
        
        c0b1d1bf5701d5f94b618f70da8e863d32d97ab4 did this only for UNX
        for no apparent reason. Solves CppunitTest_sc_tablecolumnsobj
        asserting on it not being set.
        
        Change-Id: Ia9484e5c90bef18450addcf9429f9a27d575c3b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131631
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [1f7703febb182a0542522b3403740d526c575abd]

        use SalLayoutGlyphsCache in StyleItemController::DrawText()
        
        This may get called very often during document import (e.g. during
        pasting in some cases, such as between Online windows, the backtrace
        is roughly SwTransferable::PasteOLE() -> SwReader::Read() -> ... ->
        SwDocStyleSheet::SetParent() and then a broadcast that's listened
        to by this code). And StylesPreviewWindow_Base::UpdateStylesList()
        gets called on every such occassion.
        
        Change-Id: I15e7e0509cd6ea56e1e0aab07c8c9739201ed9b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131391
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [673a210b73716cf9ceb7b104b38e39987d0515af]

        use SalLayoutGlyphsCache in EditEngine/SvxFont (tdf#94677)
        
        Change-Id: I4c7c94c10b9184ad1d3348e7b364748b4e7c34de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131611
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b633ab7a53aec033ba933c4ebc48a4fbe56d6c4b]

        tdf#91217: sc: remove disabled UItest
        
        Besides, tdf#91217 is a duplicated of tdf#90694 and
        I've implemented a CppUnittest for that bug in
        https://gerrit.libreoffice.org/c/core/+/131619
        
        Change-Id: Ic7d1eb2997e4bf32d81b983a8e4f3fbdae059909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131620
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a42b6236de6df452d1b2341ae6009da3c38bc481]

        tdf#90694: sc_uicalc: Add unittest
        
        Change-Id: I93c845a811e24e6ed79d1fb8264b5057a1e660a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131619
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-15  Julien Nabet  <serval2412@yahoo.fr>  [2aae3ef9ab464b72f6616aa8a66b6f17cae456a4]

        Related tdf#114286: put duplicates commands in GenericCommands (MergeCells)
        
        Change-Id: Ied2eac088535c7abc2e823b18cb130eac8d36c3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131399
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [4108348161b1f1f1693b722a828e7c9584c33cd6]

        Related: tdf#35030 - add tooltip and improve extended tooltip for reset
        
        Change-Id: I3153785bd5d7420bb6ec89cdf1592362acbbb5b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131480
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-15  Seth Chaiklin  <sdc.blanco@youmail.dk>  [1d64575346ff05c77042ec10825f4896a24e1f27]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89614f20e0b04b8415178244066090bbcf115af7
          - Related: tdf#35030 improve description of Reset button
            
            Change-Id: I0b231154ff9f12b890dfedd0cbca17f99b9e40e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131482
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [637c8771f458456e357355d85964c821ed149d4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e721d1ea84ec45e71ad7d218d9158542fa1b7f2
          - Update Calc Tools menu with Forms submenu
            
            Change-Id: I5524b4ba2674167a162133b9ff99677f2f59cfc3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131607
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-15  Caolán McNamara  <caolanm@redhat.com>  [fc42d1159f390a99d886ea0f82d268613ac22e2f]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I742132da8fab7168495c7756aaffb1742a1bd973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131613
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-15  Caolán McNamara  <caolanm@redhat.com>  [17da4c1e998bd626410d498d39c7a8198d0d4c7a]

        ofz#45574 suppress Integer-overflow
        
        Change-Id: I869a88964540538c7ccb2d91e80ea5095dd31367
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [c11464f54837306c32054202a1d13b796b8dcb0b]

        Simplify loplugin:trivialdestructor
        
        The recursive checking of (non-virtual) bases and the checking of all virtual
        bases were unnecessary.  It suffices to just check whether all the direct
        (virtual and non-virtual) bases have trivial destructors.
        
        (And FieldHasTrivialDestructor*Body* was a misnomer, as it actually checks
        whether the corresponding type has a trivial destructor.)
        
        Change-Id: I8a70e18eea4b629ad56577fa885f51925f9d7dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131608
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [baf6c57496fe38c5ee4ab34829aaf4d4d6598d28]

        faster comparison of very long strings (tdf#147284)
        
        Comparing long string backwards is inefficient because forward
        compare has better memory prefetch. For the PDF export
        of the document this drops the comparison cost to 1% from 6%.
        
        Change-Id: Ide29608bf56915cc528e6ec8b98ccf8ebf4693a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131579
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [a514e402d67aee558346850ffb023e81f89224c2]

        use GetVclCache() in one more place in SwFntObj (tdf#116400)
        
        This is fine, the cache is the same as long as the substring is
        within the full string size.
        
        Change-Id: I9ad7cbe33db73219d16b3b907f2a9dff694d0923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131566
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [64be4ee4dae524fc8dc9b49b618fcd55bb2d6104]

        use CreateTextLayoutCache() in writer (tdf#116400)
        
        Change-Id: Icc798c2a4e44260d47dc36f7d84487142cf56041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131558
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [47fe67de351dd4adbfe69247e0506d0766991813]

        use CreateTextLayoutCache() in PDF export (tdf#116400)
        
        This seems to have a pretty good hit rate, avoiding most of the cost.
        
        Change-Id: Iccaf310acb796d4bc2056fabc24fa27a3631ab18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131557
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Luboš Luňák  <l.lunak@collabora.com>  [b2f0da51e36ae65d304881967605700ecee59575]

        make CreateTextLayoutCache() cached (tdf#116400)
        
        The result depends only on the string, so it's possible to cache it
        easily, and caching this for text drawing calls can have a good
        hit rate.
        
        Change-Id: I56c6e254cc176ab07afe0df24ed37b19579fe64d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131556
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-15  Hossein  <hossein@libreoffice.org>  [3cc41346f5529026d7d38f2863ae3d84948e6ab7]

        Better CreateRomanString() to create Roman numbers
        
        The previous implementation of CreateRomanString() was complex and
        was using various tricks and pointers to create Roman representation
        of the integers.
        
        The new implementation is simpler, and easier to understand.
        
        Change-Id: Ibda4f8cfab02fd360e718736c957b3e04110c57a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131573
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [8e6462571bb4cb872f607b4ac9dfde7f43b79ac3]

        Allow for java.version consisting of four dotted segments
        
        ...like "11.0.14.1" reported now by
        java-11-openjdk-headless-11.0.14.1.1-5.fc35.x86_64, and which caused
        
        > warn:jfw:274674:274674:jvmfwk/plugins/sunmajor/pluginlib/sunjre.cxx:100: [Java framework] sunjavaplugin.so does not know the version: 11.0.14.1 as valid for a SUN/Oracle JRE.
        
        (For simplicity, cover it with the same code block that already covers a
        potential "_01" etc. part following the official(?) three dotted segments.)
        
        Change-Id: Id98235d3be59653ab412f9b6c1ffbf3b0470bd6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131586
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [25fee1f66ba42c0b6828409bfd2c2e822c1f7eb6]

        loplugin:trivialdestructor: Remove spurious anonymous union special case
        
        No idea what this "The destructor for an implicit anonymous union member is
        never invoked" block was meant to be good for.
        
        If a union-like class X has a variant member Y with a non-trivial destructor, an
        (implicitly-declared) defaulted destructor of X would be defined as deleted, so
        we must not warn about a user-provided destructor of X with an empty body.  But
        that is already covered by the fact that the anonymous union of which Y is a
        member will have a non-trivial destructor if Y has a non-trivial destructor.
        
        Change-Id: Ia30381a07fadd3132f5595575716c6c5097fa34d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131576
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [5e6ee5503bcfdf47327a019e7ff172a378939d31]

        Check that loplugin:trivialdestructor doesn't warn about deleted dtors
        
        ...which happens to be covered by
        
              if (!destructorDecl->hasTrivialBody())
                  return false;
        
        Change-Id: Ica2874e710da08d668b7e773373a1188a8ae16a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131575
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [c3346dc5731ecadb4762b939b76056eaed193341]

        loplugin:trivialdestructor: Only warn about definitions
        
        Change-Id: I666e72a5c95b48cd5bc0cb775de3ec6a6c82fe39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131574
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Hossein  <hossein@libreoffice.org>  [59cb2aa7908e1a7079a6fb692465b1bbe4321e2b]

        Update basegfx workbench
        
        * Update Makefile
          + Remove obsolete 'test' rule
          + Fix include
        * Add needed headers, std:: where needed
        * Add newlines in the print
        
        One can run the workbench simply by invoking:
        
            make
        
        inside 'basegfx/source/workbench' and then
        
            ./bezierclip
        
        Change-Id: I1055260a801d3a95c102a92004874000efb6871c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126903
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-15  Hossein  <hossein@libreoffice.org>  [3e7dd04dd8ca1baea4b7918eb7a7080c595c4625]

        tdf#145614 Convert #define to enum and constexpr
        
        * Converted symbolic constants with #define in mftools.hxx to:
          a) 'enum' where facing multiple values of the same category with
             similar prefixes, or enums from the [MS-WMF] / [MS-EMF]
          b) extracted the underlying integral type from the above documents
          c) 'constexpr' where there was a single value
        
        * Where possible, 'enum class' in 'emfio' namespace is used
          * Some enums with binary or comparison operations are not converted
            MappingMode, TextAlignmentMode, RasterOperations, PenStyle
            CharacterSet, ExtTextOutOptions, PitchFont, FamilyFont, WeightFont
        
        Change-Id: I144b2df4722e23d3b0c0aca7880cf603faa80686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124099
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b6a44a3d58cb050156f6f5253c14f6e0f79eabf]

        CppunitTest_sw_ooxmlexport*: use getProperty<Color> when possible
        
        Change-Id: I87116aeb0c176d67588ecfcff94098346e17dd6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131584
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [34636bea78020e98bb5db6c3165d98d984e022dd]

        UITest_solver: add more asserts to find where the test fails
        
        This test fails sometimes for unknown reasons
        See https://ci.libreoffice.org//job/lo_ubsan/2329/consoleFull#2818066648ce9c26-9d0a-43a8-83d8-c44f54920d59
        
        Change-Id: Ib5c01355fff1056f64cab7fcc8b486b31a0ba5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131583
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-15  Michael Stahl  <michael.stahl@allotropia.de>  [d9e38d5830ac278d7180b96fb6cefe3ee8ef6d76]

        tdf#135220 sw: fix layout after SwUndoDelete
        
        The bugdoc is 398 pages after initial load and 397 pages after Undo.
        
        There is really only one problem, on page 6 the fly frame 7370 "Figure
        3: Hay Rake in Weeds" anchored on SwTextFrame 5896 should be on page 7
        and aligned to the top of its paragraph.
        
        First, 5986 moves forward from page 6 to 7, hitting the condition added
        in commit c799de145f7e289f31e3669646e5bd12814e6c5e
        debug:1170918:1170918: SwObjectFormatterTextFrame::CheckMovedFwdCondition(): o_rbPageHasFlysAnchoredBelowThis because next chain on same page
        
        Then 5986 moves back to page 6.  When it is formatted there, the
        ConsiderObjWrapInfluenceOnObjPos() is true, preventing a formatting of
        the anchor frame - so it does not move forward.
        
        The flag SetTmpConsiderWrapInfluence(true) was set the first time (when
        it moved forward).
        
        Setting this flag for any anchor frame that moves forward was added in
        2005 in commit 46297c0923c50a12510c7b15b725c8d2fd80f9c0 and apparently
        the only way the flag is cleared is when SwDoc's SetModified() is
        called (or the frame is in a table or column).
        
        So it is similar to the InsertMovedFwdFrame() case that was addressed by
        commit c799de145f7e289f31e3669646e5bd12814e6c5e in that the flag should
        not be set if bPageHasFlysAnchoredBelowThis is true.
        
        (reportedly regression from sw_redlinehide
         commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c)
        
        Change-Id: I27b2a1becf5f7a760e74e801e23472116d0a5ced
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131560
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-15  Michael Stahl  <michael.stahl@allotropia.de>  [4c86ed851bc1c0a2414e254082064760c99437f1]

        hwpfilter: why isn't that path string null terminated
        
        Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [d3797ebe6fbd93bae27c6406a68a9154fa8401fd]

        Fix no-PCH build
        
        Failing locally with
        
          C:\lo\src\core\include\svl/poolitem.hxx(34): fatal error C1083: Cannot open include file: 'boost/property_tree/ptree_fwd.hpp': No such file or directory
          make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:344: C:/lo/src/build/workdir/CxxObject/sc/qa/unit/SparklineImportExportTest.o] Error 2
        
        Change-Id: I6d71a2a8da32ecb33faf470f7a5ddc0c7c8f4b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131577
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Tor Lillqvist  <tml@collabora.com>  [85adfa77911acb072a1a31f9e021e7a1707a2544]

        Accept iOS SDK 15.4
        
        Change-Id: I53efea3dcc7308f2189d331a9f5ec52d0e610b42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131581
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-15  Michael Meeks  <michael.meeks@collabora.com>  [3d347d1e7835104156ff3cce0b5ea05cefa8ba15]

        Avoid segv when co-editing around SvxColorTabPage.
        
        	vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
        		vcl/source/window/window.cxx:3403 (discriminator 2)
        	vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
        		vcl/source/window/window.cxx:3404
        	...
        	vcl::Window::ImplCallDeactivateListeners(vcl::Window*)
        		vcl/source/window/window.cxx:3404
        	vcl::Window::ImplAsyncFocusHdl(void*)
        		include/rtl/ref.hxx:112
        	...
        	Dialog::Execute()
        		vcl/source/window/dialog.cxx:1056
        	virtual thunk to SalInstanceDialog::run()
        		vcl/source/app/salvtables.cxx:4924
        	AbstractSvxNameDialog_Impl::Execute()
        		cui/source/factory/dlgfact.cxx:222
        	SvxColorTabPage::ClickAddHdl_Impl(weld::Button&)
        		include/rtl/ref.hxx:192
        
        Change-Id: I12a78d65a8e7b8b728dde84f7c51cc19005c9aa6
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131353
        Tested-by: Jenkins

2022-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [b70d17b08a7f24e4c470831910e63493082e0874]

        Round calculation to avoid blurry default icons
        
        Having the paper of 21000 x 29700, and nThumbnailSize of 256, the
        ratio is 0.0086195286195286195; aThumbnailSize would be calculated
        from 255.99999999999999915 x 181.0101010101010095; truncation will
        make the end result 255 x 181, and after drawing the icon on that,
        it will be stretched to 256x256 (so there will be 255->256 scale).
        
        Change-Id: Ic7d37206b42e2229b36161c215a36e4b71486802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131582
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [d0c2c78725f5f50e3f2d08b3495cda6ec03b4297]

        loplugin:trivialdestructor (macOS)
        
        Change-Id: I4f379f9f5c848e8fb01b05591d8a80a45719b43b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131578
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-15  Caolán McNamara  <caolanm@redhat.com>  [1b04fbca0dc7a49aa5acc799396ef993471a992d]

        drop some redundant semicolons
        
        Change-Id: Ib09ac9cfec70f803b23b28b0c0a8031620436e9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-15  Stephan Bergmann  <sbergman@redhat.com>  [0a9838700ba31ce6fc16015de68949e47d984d07]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14b884e807078b67f47d8615df2e4c2e363890ed
          - Revert "Update Clac Tools menu with Forms submenu"
            
            This reverts commit 31f0c48d3bc30742d49af32ac9686d71f8aa7215, because
            it broke the build, presumably because it forgot to add
            helpcontent2/source/text/shared/menu/forms.xhp as a new file.
            
            Change-Id: Ie51a7683f254b0439bbbc2e563ba943b8f98e02a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131486
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-03-15  Dennis Francis  <dennis.francis@collabora.com>  [64631ddcf360102d6f72a938a154529a1edc69f7]

        lokCalcRTL: chart-edit: no bounding box
        
        Fix for selections(svx-marks) similar to the fix for chart edit mode
        tile painting
        
        ```
        4fd2a14c6ee68f0574766ec7ec3dca35debe9d20
        lokCalcRTL: global RTL: fix chart edit mode rendering
        ```
        
        Conflicts:
        	chart2/source/controller/main/ChartController.cxx
        
        Change-Id: I2b5a2af7023b09254b8471b750122bec10126bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131091
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131572
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-03-15  Szymon Kłos  <szymon.klos@collabora.com>  [eca978841816f833616b4c2334e65aa976a9fb61]

        tdf#147761 record sort command in macros
        
        fixes regression introduced in:
        
        commit	70b81e74d2a14308e1897d840c681404225d328a
        author	Szymon Kłos <szymon.klos@collabora.com>	Tue Jul 21 11:40:22 2020 +0200
        
        SfxRequest's Done method records the action. It has to be called.
        
        Change-Id: I32529fa11febca3d3829b4afd2cd4e6dd359bf74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131484
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-15  Tor Lillqvist  <tml@collabora.com>  [3733772279ba8968f18a9f73a3294f43aebe53ac]

        Accept macOS SDK 12.3
        
        Change-Id: Ice469236dd79675b6fad6f7c5a244888200fea8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131565
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [860299fe04ec5a2ff0d716186d43d517006069aa]

        sc: test Sparkline OOXML Import into Calc Sparkline doc. model
        
        Change-Id: I513571de398be419074d54c5861374effae07709
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131490
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-15  Mike Kaganski  <mike.kaganski@collabora.com>  [d65c8b37595a4775fd766b2b7becbc01fe21a04e]

        Simplify GetOOXMLPresetGeometry and GETVMLShapeType
        
        Let them use types that know string lengths, don't require conversion,
        and are convenient at call sites.
        
        Also inline the maps initialization, instead of having separate arrays
        and initialization loops.
        
        Change-Id: Id4469f3f99f3f0eb2cd83f0671cf892df4e420a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131550
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-15  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [055fcef3fe3c3f74ed485a35451c48f6723991b6]

        sc: use enums instead strings for some SparklineGroup props.
        
        Change-Id: I082c0a7693c97a67bc4972398224bce4bdae85eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131489
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [288c78cb990bc427055dea7d97748de5cc4b8ab0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 31f0c48d3bc30742d49af32ac9686d71f8aa7215
          - Update Clac Tools menu with Forms submenu
            
            Change-Id: Ib8ac1f43116592ea569d88d16f84db44b0333286
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131567
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [84ada418f4fb47e18e4c4bbacb3442076908f71c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14a38203c36eab86b30e02c1acd66b1841cbfaf0
          - Update Calc's Tools menu Help page
            
            Change-Id: I9f52bd1636a472fc02924c1adf6685358b504e47
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131555
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3611192af750a34e681f3c1f59490132cef5b69f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 15250e5e03742751ec8b78b5f1a8eb339e66950d
          - tdf#147977 Add Share Spreadsheet help page
            
            Change-Id: Ic4d77dd4b33d3e0bd74c48a195a3d97b2ad647e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131553
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Hossein  <hossein@libreoffice.org>  [4d2d2f04288b87228511ff9afcdda691f103de16]

        Remove EMR_SETARCDIRECTION from unimplemented records
        
        As EMR_SETARCDIRECTION record for EMF is now implemented in commit
        7b28920382d3820344bfc4075bac98f85e838dba, it is now removed from
        the unimplemented list of records for EMF.
        
        Change-Id: Ib2931d339f924e813d243ba503d4b17aab0d6868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131401
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-14  Stephan Bergmann  <sbergman@redhat.com>  [83dd8deed7b5013fa0f0592140e136770fbda4d6]

        loplugin:trivialdestructor (-stdlib=libc++)
        
        That these are only flagged when building against libc++ and not against
        libstdc++ is a consequence of the plugin's dependence on implementation details
        of the relevant classes, but so be it.
        
        Change-Id: I6b96f81939edab2b8e618aa53c9fe23492edfbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131562
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-14  Julien Nabet  <serval2412@yahoo.fr>  [9aae749e99a92e6622fe18539e186e5cb07fa721]

        Return early if empty ref (xmloff/xmlimp)
        
        + fix a comment, the function uses "bool" not old "sal_Bool"
        
        Change-Id: I777dc93450a56eb826d15691d56c23cb051a4afb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131561
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9e73fa6661af591d98a262da0e7f32b346570281]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6e1ebf3f0b5cf3ea1b9d7678f86f67f3221af36
          - Fix typo
            
            Change-Id: I4856441ef0a64900b7b20c8f49333fec9002f250
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131554
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-03-14  Aron Budea  <aron.budea@collabora.com>  [b456297ced6f5111cf311556a2904cbb27598289]

        Send Calc Insert Headers and Footers state change to LOK
        
        Change-Id: Id51b4cf1eb962f22ee1e381873f4670789675525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131293
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131543
        Tested-by: Jenkins
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-03-14  Caolán McNamara  <caolanm@redhat.com>  [ca9e48c663b16bf461c37a5449c6ad5a930ad5a4]

        cid#1502951 Logically dead code
        
        Change-Id: I5968dda3b0638576fcc9ce222e47a3c04c949484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [061c71c8f9cbf154c21e3726325894a529c89e1b]

        tdf#147935: sw: Add UItest
        
        Change-Id: I80ef9cff8956402d6286741fa52885f66dac6f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131548
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [bee6568ae5d49f5b697740a23c5a1c6775f64d52]

        tdf#147905: sc_parallelism: Add unittest
        
        Change-Id: Ib71a30d7ef8d907c1fd86e35d3e6cae5c15218bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131549
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Eike Rathke  <erack@redhat.com>  [24e213b11569400751fc54bfbeb5a5f6afdd4172]

        Resolves: tdf#147935 A row may have no newline character, tdf#147496 follow-up
        
        Change-Id: I91672e31e324cdd17c02ca328863b636beeb5e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131546
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-03-14  Szymon Kłos  <szymon.klos@collabora.com>  [7fced7bbd0d6d7769dcf13ab326c793d4096a247]

        svx: don't remove object right after insertion
        
        This is regression from:
        commit 2d95b3846eac367d2baadc194ab258dc31e7bd33
        Author: Tomaz Vajngerl <tomaz.vajngerl@collabora.co.uk>
        Date:   Thu Oct 7 16:48:46 2021 +0200
        
            svx: Don't end text edit mode for all views
        
        It was visible with "direct insertion" where user doesn't
        need to draw anything but textbox is inserted in the center
        of a screen (eg. used in LOK case)
        
        Object was inserted into a view and right after that was removed when
        EndTextEditCurrentView was called
        
        Change-Id: I9943d46746aabadf96d76d6e74770b56d648b79d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131263
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131537
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [579f3b50bcffe14a5979d76a5316b4f51c76b7ad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f620b42736be0f4a3efc01100e223a6c877b0716
          - Fix a D'oh! in help page.
            
            Change-Id: Ib3e5c2f00320a6679b655d1a22ea0bb70950852f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131547
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a77981ad21aa0793f0af2ac262bd3573e0501235]

        uitest: sc: move external links tests to their own place
        
        Change-Id: Ie02318a502ec9baf8c27c9a353b070ae113672f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131531
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d5ec2c9d0bf8765fc75c17a0e6fdcb2583335d0]

        tdf#111675: sc_logical_functions: Add unittest
        
        Change-Id: I72f158007f456fd70149fcfd6029a0157e47837c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131539
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [360e7eaef92ed38f25a454c8f0f605e7cda974f7]

        tdf#128610: math: add UItest
        
        Change-Id: I9fe1a349a73790e7fa1c503112a27f76d238c0c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131538
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [33af49a83e06920f9d24d6127e18ca1ccdc6d321]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e159fae8ea7be0552646da8de925b6b7dafeefe9
          - tdf#147862 (part) - Fontwork toolbar description
            
            Change-Id: Ia43a7b69b301cbd85dac2e34ca5ea061ba09de6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131330
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a8e3560d8ee4f90e877f4535ff07d0d26edee714]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80f1bca2adc9b5b0b63d266943779a1c0ae08ce2
          - Improve track changes help pages
            
            Change-Id: I04ee3cd429e96d1830c1038337a88a3a2dcf8e9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131544
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [22be1665dc6eb28ea1d52c7c5e4347628fc5a76b]

        tdf#147143 Word selection error in Arabic text
        
        this reverts
            commit 563af8fd15aa37e75af8882cccbdf8914ebe8e61
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Jan 7 22:50:29 2022 +0200
            tdf#144890 Invalid selection area when text in LTR run
        and
            commit ec50b9e5eaec7c94df35617676077ef0d65cecc7
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu May 27 11:16:11 2021 +0200
            no need to allocate Sw2LinesPos separately on heap
        
        No idea why the commits caused trouble, clearing there is some
        "interesting" interaction going on.
        
        Change-Id: I606768403db777b61554f378d3f69f9b4d33d493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ba9daac763baf37c833911be5e5fb97e068bea1]

        add TypedWhichId version of QueryState
        
        Change-Id: I95b86fc081847da01e06f50a1b2c7e7f5456c638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-14  Szymon Kłos  <szymon.klos@collabora.com>  [a342ac91e21dd45640b7dea063bc04b80f0feb6e]

        lok: insert textbox directly in Calc
        
        Change-Id: I3ae00b255dfbaa34ab8d973356d12dfd0f71d345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131267
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131536
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d6c4ec7b00f3fe7b60f6155de4e7564a4dc72c28]

        tdf#147961: sw_uiwriter3: Add unittest
        
        Change-Id: I49f4f98d77f0c5e8caa6471e9c938a472a9aaf96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131526
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Szymon Kłos  <szymon.klos@collabora.com>  [851560310f93f87d923f39cd0cd01aa18db03ce3]

        lok: fix position og autofilter in RTL mode
        
        Change-Id: I73f2b003185c326f4d66c974a2e5aaecb4e0199a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130916
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131513
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-14  Szymon Kłos  <szymon.klos@collabora.com>  [68ff5bf424fd2813cb08dfa7f165e0227cb6a703]

        lok: send logic autofilter position
        
        we need to show popup relative to the grid window
        
        Change-Id: Ib0cf66d2c0422b765a3b8035d5499b45e83f768d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130528
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131511
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [d67017bfe251c71ac1345615d9a3080a7fefdf32]

        simplify GetOOXMLPresetGeometry
        
        all the call sites are using OUString, so push the utf8 conversion
        into the function
        
        Change-Id: I875249b8702cde63737fd42dc1d1592be059cc11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131525
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [c4c8146c9982313fd11f27894360ceaee3b3cbca]

        tdf#147767: sc: Add UItest
        
        Change-Id: I87d94c33af9676a147a07380b5f39add59b26038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131530
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [74f6f2cd88a4905e796d9b66393f4e9cd9eac3a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01883bab23e9bf50fbf1ce801fcde80f00508f5b
          - tdf#147862 (part) Update Navigation bar help page
            
            Change-Id: If10e2cfa110f62906028571ed23ef1adb0abf539
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131380
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [01ec377c04c8dfaebdeb1002fd2d9a0e8f135b8c]

        sw: fix bug id in comment
        
        Change-Id: I510a48765b2ad286ddc194f6ca1a96211bcb05f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131528
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [76bb029866a15918c1a842f81236b9caeac674ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 298513eb58210a77aed5d4ab8325f9c142bc4457
          - tdf#147862 (part) Update Form Control & Design toolbars
            
            Change-Id: Id19ec57e715e9d1fb85df45736ebac258a9d255b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131372
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [98d037c046913e28a517a418a76eba187afcd222]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e5dbb88dabc1ac5e5d0aa7ba130338690db800cc
          - tdf#147862 add  Track Change Toolbar help page
            
            Change-Id: I5e42059d5175838a8398694980f653cde5655e03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131397
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [3d8c11a8ea9cabb0ee77b279cc815ca67d39ba24]

        tdf#147894: sc_uicalc: Add unittest
        
        Change-Id: Id7e5159542b17a510958ea8e22343e979720a56b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131527
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [3a2c156eb8b5e68e9de430e788a57e0c220f7e3a]

        dont send text selection start/end when there is no selection
        
        when there is no selection, startrect and endrect get the
        cursor coordinates, we should not send it. Otherwise this
        causes selection handles to appear on online
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I4402e04d4a16a1f840499c57421fd01caf43f116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130525
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131520
        Tested-by: Jenkins

2022-03-14  Tor Lillqvist  <tml@collabora.com>  [7545a53f53c786c1124ba750f9339ffc237d6467]

        unit_online_get_fonts() has not been used by Online since 2017
        
        Change-Id: I7dddb4fd40f219df1969f452c95170bc70caa44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131524
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [9630bbc6df8bbff2c853e07be93579a96cc7cdbb]

        lok: Set pasted text rect pos to 0, 0
        
        Rect size change according to the length of the text
        however, this can make the text inserted in the negative coordinates
        and half of it becomes invisible.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: Ibd4e6164c21088205efecf024c1888c55ac33f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128603
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131519
        Tested-by: Jenkins

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [dc05d912b56751ee53e2ee3d2638d85829b6a2d9]

        set active element to -1 when no selection for fontnamebox
        
        FontNameBox sets the currentVal to emptystring when there's
        a mixed font-name selection on the text but does not update
        the active_element which is incorrect whereas other comboboxes such
        as FontSize does it correctly.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: Iff86bba64c2ab564ff5c5fa979eb846af9651a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128551
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131518
        Tested-by: Jenkins

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [74d24d03afc58a535d3afb7d0c2d172fa1636829]

        lok: remove residue text selection when there's none in the core
        
        Residue selection can stay at the browser even after changing the cellcursor pos
        make sure to clean it up if there is no selection rectangle in reality
        to be synced with core.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I1b06b6ec84ae195936d12dc986ef4a19b26dbc8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128351
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Tested-by: Henry Castro <hcastro@collabora.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131517

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [422fd364934d93ea02a614e8f431bfc1126b5a2d]

        LOK android: Fix csv sheet name becomes temp name
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: If43d7a995a5e53734fc7ecdcbf9b750b4886dc45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127684
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131516

2022-03-14  Mert Tumer  <mert.tumer@collabora.com>  [2df5a083a83f6e83ac45465d4b65887421ac945d]

        lok: Fix freshly added comments are not displayed
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: Ice772eff8b9f8ae8c23ec1e66675e33a80492028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128217
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131515
        Tested-by: Jenkins

2022-03-14  Caolán McNamara  <caolanm@redhat.com>  [c9a4c8a8ab9933949e14de09e80333a0de6612c5]

        ofz#45525 Null-dereference READ
        
        Change-Id: I9d31b89fc7fa9447823ded4f6891b47100215c0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131523
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-14  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [f34adef94825244b9834905f7cffb96505de5d2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b84a4ae1df2b644e612cbc2544ba9dc8b8cecf5
          - CallByname basic example correction
            
            Change-Id: Iccfbb52d678cae4c6ce100cfa41576f207120bb2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131204
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-03-14  Stephan Bergmann  <sbergman@redhat.com>  [5337675a31a4aad5151691b9c7587bd4b3140715]

        Simplify vcl::EnglishStringToMetric
        
        Change-Id: I10b93a073a58c175d487b7aac3a65d461974eb6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131514
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-14  Luboš Luňák  <l.lunak@collabora.com>  [89fb3f7e87fd7ab9312bc43dffea842ffc34b140]

        cache also failures in SalLayoutGlyphsCache
        
        This is what 3f69ec9ab4236de13d229f675943123aeb42ea29 did in Writer.
        
        Change-Id: I40fb49ce83fd24f16050318c523d87603300b06d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131392
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-14  Luboš Luňák  <l.lunak@collabora.com>  [3e3ef58be1c27e0ac32b0b5694f673f603d23224]

        move cache for SalLayoutGlyph's from Calc to VCL
        
        For reuse later.
        
        Change-Id: I43479148a8312a36e56f267435e77acc8bf9bd35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131390
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef82ccdda93186b4cab55aeac3844295194120a4]

        new loplugin:trivialconstructor
        
        Change-Id: Iaaf63c49ce94987ab9c4ebc68e963cc3054a3c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d156995180b565f34b52859aa1d6953995a76b9a]

        Colibre: Resolves tdf#146232 Adjust lock overlay icons
        
        Change-Id: I75598093ab1aaf2e6da897be75d6273ac5636556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131457
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [d0a5d8429c9338056ae0b0c22128db9f6a07e159]

        cid#1502949 Logically dead code
        
        Change-Id: I259e105c73141744b667f8ab61fd61dac8e4ef9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [0898179afc9334bc2370cdccbf3392337585b860]

        ofz: Divide-by-zero
        
        Change-Id: I8d88558be5bcf4556d94ab86015f5e039e72da08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131503
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Julien Nabet  <serval2412@yahoo.fr>  [924791c51b27226e34fd1e0a32cc7d3d66683d0b]

        Remove forgotten remnant test code
        
        Change-Id: Iffa86449fc2e4946821afea07e22deb355c7fbf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131507
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Heiko Tietze  <tietze.heiko@gmail.com>  [122e9364ab297661ed91854f192c7a880eb08634]

        Related tdf#146545 - Make Colibre (Dark) available in icon themes
        
        Change-Id: I4a66b6038d2a25160efa6d5ba64f6432d9736e2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131462
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [020e26dcdcbc9d95076350a61190fb9d3a9e3844]

        ofz#45528 we assert on using a negative y-scale so don't import one
        
        Change-Id: I3726a1b7164e4784c8e7954c7230745fa89ec2fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [b8bb44132f859c7f65d4be8740ae86af943cfc8f]

        don't need this exclude entry anymore
        
        Change-Id: Ifb9f611dfb5751af40c8d8ec5f967e0ec535ae60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Jim Raykowski  <raykowj@gmail.com>  [9ae74207e02d3a0ecc8f360720eb4e1c14bba0d3]

        SwNavigator: Gray out Comments members not visible in the document
        
        Grays out comment members in the Navigator Comments member list that
        are in hidden sections and folded outline content. Not showing comment
        annotation windows will not cause comment member graying. The patch
        also fixes comments sometimes not showing in the member list after
        document load due to the document layout of comments not being
        completed before the comment content array is initially filled.
        
        Change-Id: Id3ac664480c36f1a3d072f7658cc9269a55b70aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130471
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-13  Noel Grandin  <noelgrandin@gmail.com>  [7c7f00a89a675dad541d32ea60695a7b11210102]

        tdf#147961 Crash Typing "++" and press Enter (AutoCorrect Create Table)
        
        regression from
            commit 7cd5b35caa8d4fa9d0ba2b2c6ce4b88726ed2be6
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Fri Sep 24 13:21:35 2021 +0200
            return SwCursor from IShellCursorSupplier
        
        Change-Id: I6a4e3f90653dc96a91091be1372f27c6303ba346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [34cd775646a7f21f0d2d40462ae716671bab67c9]

        Fix typos
        
        Change-Id: I9f583937da2cf49fc9013d9e36d63fff312ccb92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131495
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36ad7bf558295a4b8474127b3c9bcc954f459bbe]

        Fix typo in code
        
        Change-Id: Ide7c82fadf701e8f16468c153d871757d6a92569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131496
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f13c92951d242b8c19d93a757a0b45ce1ff0f987]

        Fix typo in code
        
        Change-Id: I4655ae7da84f606e4a1d1b7e72dede609c43aada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131498
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3c6e9593094a6a1e1fd4974f962da67b8dacf4c5]

        Fix typo in code
        
        Change-Id: I2dd9383587fb3621f1f2bcc53c064c437de33bf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131493
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15cf536adce74c6ca3fb401e0e232aacadd87f8f]

        Fix typo in code
        
        Change-Id: Id38f846aaf451d94e975e049f6494a6261eb4ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131494
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [d71323b29cdf9714c2979484b359c15b50c778a5]

        cid#1502951 Logically dead code
        
        Change-Id: I59efa10d5aab53e3c0d830d04b659c39f14bdd3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131499
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [92e3d17dbea13f1ad2f33824d0e2dc2a0a8c4014]

        ofz#45525 Null-dereference
        
        Change-Id: If55d049f12eb00ba786f12d565081404fcdf147b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131465
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Jean-Pierre Ledure  <jp@ledure.be>  [ae24ce8c633a85e06aa8701c839b100b3dd5b6bf]

        ScriptForge - (UI) size and position of the active window
        
        The UI service receives next 4 new properties:
          Height
          Width
          X
          Y
        
        They all return a Long value representing the size or position
        of the active window. The active window does not need to be a
        document, it may f.i. be the Basic IDE.
        
        Those properties are read-only.
        To modify the size or the position of the window,
        use the the Resize() method.
        
        They are implemented for use from Basic and Python scripts.
        
        Change-Id: I0021663e39612f411cefa5c7ec9ec594a4cb6f39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131444
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f2d07a3b17430d21d4567f7a01525a702544ed8d]

        sc: initial code to draw sparkline into a cell
        
        Change-Id: I82861f4210a24f57573f0ec96489e86ab168677b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131488
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [841788923ce185c140ebeac6d34faffa348c8b6e]

        ofz#45527 detect too many points earlier
        
        Change-Id: I7716ca8b9de9312bcaabf1d16e60dbac7ae87e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [f7151c8ab4e4928de8f29c2b4ac232b0a7cefa74]

        pass reference to the target vector instead
        
        no logic change intended here
        
        Change-Id: I680914a6a41cceab41f68456e98de5f3b4a8a639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131491
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [a1cb80dc55a708733ea0822150718a7c8076f7ba]

        Degree10 has underlying Int16 type
        
        Change-Id: I17c10f6c3a1d342302363df50e2104d4c7c78088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [e4bc01d9f57d47d943ff1910e42abda3d9033f46]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I6239ebb640bf248d226979ed17de92930898f9ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131464
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [71fc9f50ac69da474c1767cef9abaf7edf529675]

        ofz#45524 string is presumed to be at least length 1
        
        Change-Id: If8a86e399109b414cf53f6e2bffdd3c7c6faa490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131466
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [434c221dcfff7b5d8243a970b7a63064163033a9]

        treat archaic sprmTDefTable10 like sprmTDefTable
        
        we don't import this, but parse its length like sprmTDefTable as documented
        
        Change-Id: I235e1842269ceb51502cb6863c988b1307663aee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Caolán McNamara  <caolanm@redhat.com>  [e54ac357ee669cfc7cb5c68eca4ddce27824ae9a]

        tdf#147929 "undo" may delete the current SwAnnotationShell
        
        Change-Id: I69fb7e65e28743aa73e943e02d5029654b5543cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131450
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-13  Adityarup Laha  <me@adityaruplaha.me>  [69656132a00491b96da3a898c350f11e9619da64]

        tdf#136427: Attempt opening native documents for known protocols only.
        
        Only try to open native documents (ODT, ODS, etc.) in frame for known protocols.
        
        This is to prevent LO from trying to handle internal protocol links when the
        file has a native extension.
        
        Change-Id: I908783b0d24330ec44caa9ddeca2511426001cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131449
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-13  Mike Kaganski  <mike.kaganski@collabora.com>  [0fcb5d2fcb46214b3182f7837a99725f02b7bd61]

        Small simplifications
        
        Change-Id: I250edc772edb7caa40cc3d370522a3e047513061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131452
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0e5c2514d7936e63e39cc9322b6bed01c36a8aa2]

        Fix location of commands in a tip of the day
        
        Thanks Jean-Baptiste Faure and Mihkel Tõnnov.
        
        Change-Id: I17c3f9009e5ca044f3858cbee605dc53c0398d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131455
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-13  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [be1aab8632ead65d75c0436005d3cac7d43b9f02]

        Colibre: tdf#147952 Fix Media Player icons
        
        Change-Id: I555d4d5d20d3c1bca03e9fac0354bb0b2d978d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131456
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2022-03-13  Jim Raykowski  <raykowj@gmail.com>  [ab4cffecd614d9443af5f9763d83add29178ade0]

        SwNavigator: make resolved comments visible on Edit... if needed
        
        Current behavior of comments members context menu item Edit..., when
        both unresolved and resolved comments visibility options are off, is all
        unresolved comments show before the cursor is placed in the comment
        annotation window of the entry in the comments member list which
        Edit... was selected. If the comment selected to edit is resolved the
        cursor ends up in limbo. This fix makes resolved comments visible on
        edit if needed.
        
        Change-Id: Idf016493c70a150273fe558e4967284472684db3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131292
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e2d25709fd5f31849ed9db3d51811ddb44c8e5cc]

        Colibre: tdf#146545 Fix some color, remove gradient to fully
        
        support dark variants
        
        Change-Id: I69950de6f67b57ced3d40fc5e6b6657ba1c34aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131454
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-12  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e16da3ea406a07c61eef763e5d30563ff1bbb099]

        Colibre: tdf#146545 Add dark variant
        
        Change-Id: I041d74336c3f59e0240341acfb7c50d60d64429e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131411
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-12  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [db7fc970400662a1efc16af5ff19389b190e2eec]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9760c17275898f3853f7b1d3e17ffb522a223318
          - Consistency
            
            Change-Id: Ie76a00c8f234e99043b4f108448f65af4fd23a2c
            
2022-03-12  Noel Grandin  <noelgrandin@gmail.com>  [0a790ba991daa9c84f836fd18290f621ea372460]

        tdf#147905 calc PROPER function doesn't like mulithreading
        
        regression from
            commit dac29c278531d5474289eb54aa03987c4958ac83
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Sep 16 11:03:04 2021 +0200
        
        if you hit Transliteration_casemapping hard enough, like
        in this test case, the state changes become a problem, so
        remove that by having multiple copies.
        
        Change-Id: I1d795af4370d6f79468387997202ba11c6a9d7b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [2291cbaeeb87fae2f2d6d75782e06f9296ba9c77]

        merge common parts of if/else
        
        Change-Id: I033eb905bcb3102ff1a1aa3beacd8c054e5011a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [172ba8b3d44c092435d690db7d4ca9090a114127]

        remove newly unused code
        
        Change-Id: I371fd1242070fe19e408277e008d8627fd8b28d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128567
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [556e70024df6ca092e199a3769100c0982ad7567]

        set portion width using the last position in the dxarray
        
        so both branches are consistent in measuring mechanism
        
        Change-Id: Ie9b671ac69d00550d42328ac28c707c850238312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128566
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Mike Kaganski  <mike.kaganski@collabora.com>  [de81df1f3f9b7660db450c638925f90adf9c026b]

        Introduce FastAttributeList::add(NS) taking std::u16string_view
        
        ... and simplify some places removing explicit conversions from
        OUString to OString.
        
        Change-Id: I4cdf9f3ee3101b3d00a0bbba53a983ed3bebce4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131445
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-12  László Németh  <nemeth@numbertext.org>  [128d3b454467e34538903b2eab45e866f976b314]

        tdf#73125 sw: add Insert/Delete Comment Manage Changes action icons
        
        If the listed redline change contains only a comment.
        
        Note: filter actions haven't been extended, because tracked
        comments are still handled as text insertion/deletion, and
        their redlines joined with the tracked text changes around
        their placeholder character, i.e. not all tracked comments
        got new action icons.
        
        Change-Id: Ie78e18a48b9a71c3789fca1406e5d87ab95952bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131387
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-12  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [8c94a17e408db8a0d27101ce07345fc640bef64d]

        tdf#144563: remove final dot in cross-references to paragraph
        
        It looks like in cross-references ending with dot (".") one last
        dot is removed in case of MS Word. This is not a true for any other
        suffixes after numeration.
        
        Change-Id: I554e62cf45e643bf27823df5344e1689b5b6ae54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131254
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-12  Julien Nabet  <serval2412@yahoo.fr>  [eff9dc65b88ca48171e9e6ab51f1e2ec8d0f436d]

        tdf#147309: Recreating a view with same name and in the same session fails (FB)
        
        Since HSQLDB already worked, just do the same.
        
        Change-Id: I44929cf36179cc3cdff6e61f05899c9a913c78b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131442
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c532b42fb3f61257bf8edce4b3dcb21810f780e]

        tdf#90391: sc_subsequent_filters: Add unittest
        
        Change-Id: If9e7dd7e4c022255bfae5afd3df337f7091f5e71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131383
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [996315f70a1611ad2655ef8bf25a09db888f96a8]

        ofz#45501 and ofz#45503 Integer-overflow
        
        Change-Id: I20576860dc20900589d13c43a98af91c5fd0fff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131443
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [de8e7ac97e405e30a50d4ceea023106d4da01a60]

        cid#1502950 silence Uninitialized scalar field
        
        Change-Id: I8bb8aac3eb091233ee625747aff7953f2ea28ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [916aca240195b3e224ea374df4d447201bf852be]

        ofz#45269 Integer-overflow
        
        Change-Id: I9fe6c4753da609933c8ce5ef051e49351a25fd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [621fa1a17e13095c687ac2e2b2f4fdb963b13d6f]

        CppunitTest_sc_subsequent_filters_test: combine crash tests in one
        
        Change-Id: I92a07847a92dd6bfd96a57062d28ad740c953b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131382
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c5a32c6cf072473ea28e2e9eca76ffd10c2aefa]

        tdf#147744: sc_uicalc: Add unittest
        
        Change-Id: Ica8f971ca12569cc299910a20b5a7a5bcfd49bd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131345
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee9d2bdd375b4e882e0990928fc863b3405a64f0]

        check-missing-unittests: fix path
        
        Change-Id: I568cfdd1874ccba2f7233e21166026cfcda8e733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131384
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-12  Eike Rathke  <erack@redhat.com>  [efb713febeaaf3e4b17886d405d46845d4a0e676]

        Related: tdf#111675 Clear global error for arguments if possible
        
        ... i.e. if the last result / current stack value is svError
        already (usually is nowadays in case of error) and error
        evaluating functions may be pending.
        
        Change-Id: I36fc0f169d36dfa7007e8bd3a5c368ed2bb3c919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131405
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [eb7fbe1f3a37d89b97bd8976bdc006099578c204]

        an inconsistent SwTextFormatInfo index, len, text length case
        
        seen on loading sw/qa/python/testdocuments/TESTMETA.odt
        
        maybe since:
        
        commit 2f3684b2289a8c46dc6144064a452cc529400f28
        Date:   Tue Jul 31 16:00:02 2018 +0200
        
            [API CHANGE] add some more asserts to the string functions
        
        but probably an underlying issue since conversion from UniString
        to OUString
        
        Change-Id: If731163fbc5e05b813ccd21df65164fe476cba9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131407
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [fb8f6927feed9751cd60727a9f3de13e595c4451]

        expand with some specific documentation
        
        Change-Id: I3886411c07b82417c29edaf612dd3720189a9ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131388
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [d8a27d9fda55a355ca0376f7024af06bb0cd4984]

        cid#1502952 Logically dead code
        
        and
        
        cid#1502951 Logically dead code
        cid#1502949 Logically dead code
        
        Change-Id: I3e1f1c8457dbb3d8a0c4754efbc34c36972b7c31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Caolán McNamara  <caolanm@redhat.com>  [13f2e8ab8d1d8b33f3208f82d21d61250f81057d]

        ofz#45488 get WW8+ calculation of sprmTDefTable length right
        
        we have the calculation correct for WW7- which is what the special
        L_VAR2 case is for, but for the WW8+ variant that wasn't understood.
        
        Change-Id: Ic9dde07223386df796f57dd1f33e69d16d3abf21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131395
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-12  Eike Rathke  <erack@redhat.com>  [84720c09ef30e79c56936026c3992240b4ae010b]

        Related: tdf#111675 Replace Pop() with PopError() where relevant
        
        ... to propagate the original (previous) error instead of
        overriding it with a new error. Pop() may only be used if the
        stack type is already known to be not svError, or to explicitly
        ignore a current error.
        
        Change-Id: I5a980c29f2d2679c0e2f2fc7e53c458dc147911f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131404
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-03-12  Noel Grandin  <noelgrandin@gmail.com>  [3d48db236e5e12460999fa8554d58e08a8f0f6df]

        no need to temporary OUString here
        
        Change-Id: Iffd95fcf4fd1f9aac0ba77effc3c63eedce69adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-12  Noel Grandin  <noelgrandin@gmail.com>  [15c097010f1567d933abf046bc43447bd7415e4c]

        tdf#147767 html pasted to calc has very small font
        
        regression from
            commit da9bba7cc3c243e936daea689fea64ecaf110f35
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jul 26 10:10:17 2021 +0200
            use officecfg for SvxHtmlOptions
        
        Change-Id: Ia84d713a18b4c694af98478681996b6156cbb928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131393
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-12  Noel Grandin  <noelgrandin@gmail.com>  [a378ac93e1b4e3c0dacdd3f0a3500813714537c7]

        tdf#147921 Filesave DOC: wrong layout and then all missing from 7.3
        
        regression from
            commit 990b2cb056788f7f412656a303456d90c003cf83
            Author: Noel Grandin <noel@peralex.com>
            Date:   Mon Jun 21 13:00:07 2021 +0200
            simplify and improve Wildcard
        
        Cannot pass a string_view into something expecting a char* because
        then it gets the length wrong.
        
        Change-Id: I638660a1e9a8a0d17e4d2f77500b3f01365a43d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131396
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-12  Noel Grandin  <noelgrandin@gmail.com>  [6fb716d58c1285a1abbfa6683c2f4bfaeb89e2c6]

        simplify some service factory code
        
        no need to get the factory from the component context and then
        get the context from the service factory
        
        Change-Id: I7675728992fbb5202bc42e27b86b2dba571c62c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-12  Mike Kaganski  <mike.kaganski@collabora.com>  [344353495c60dcdc69f7975ec4e51a753ebfb81f]

        Related: tdf#128610 drop obsolete encoding attribute replacement
        
        It was needed once, when we used expat; now libxml2 does its own
        detection (in its xmlDetectCharEncoding) after the strange dance
        in our XMLFile2UTFConverter::readAndConvert (which does nothing
        useful for UTF-16 case).
        
        The original problem in tdf#128610 was addressed in commit
        c964700d16d99d1569373a1eb9a1352fb3512915. This one just drops
        the obsolete replacement.
        
        Change-Id: I2e6b28212619dd0f6cb90ae8234277092a37e7a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131409
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-12  Julien Nabet  <serval2412@yahoo.fr>  [aef15ba6b5223804c9c795ed51f95af7c11f23fa]

        Fix Breeze & Sifr: Add missing icons
        
        Local build error:
        Link cmd/sc_about.png -> res/mainapp_16_8.png -> cmd/sc_adddirect.png
        Some icons in links.txt were found to link to other linked icons
        Link cmd/sc_about.png -> res/mainapp_16_8.png -> cmd/sc_adddirect.png
        Some icons in links.txt were found to link to other linked icons
        make[1]: *** [/home/julien/lo/libreoffice/postprocess/CustomTarget_images.mk:53 : /home/julien/lo/libreoffice/workdir/CustomTarget/postprocess/images/images_sifr.zip] Erreur 1
        make[1]: *** Attente des tâches non terminées....
        make[1]: *** [/home/julien/lo/libreoffice/postprocess/CustomTarget_images.mk:53 : /home/julien/lo/libreoffice/workdir/CustomTarget/postprocess/images/images_sifr_dark.zip] Erreur 1
        
        Change-Id: If7cc708f5201d21fb2134785cdb3f12a4974826a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131403
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [e98325d8996c436394d3e1db357683aa25fc4ca7]

        allocate column in ScTable::SetPatternAreaCondFormat() (tdf#147894)
        
        Change-Id: Id14bb20ef5e49551cef5216b5149e3c281c04223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131389
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [83d599fd7c530d14f70ac60bd673b66640191bf7]

        fix comparison operators
        
        It seems the ranges are always distinct, so the < comparison always
        worked in practice, but the == comparison added by my 6810aa937caca1
        is obviously incorrect.
        
        Change-Id: Ib7fcd36b5956901265248b34a4dc69e587cebe41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131340
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [eea8182795324d5f0df9c12f4debda6d532502bb]

        tdf#56036: sc_uicalc: Add unittest
        
        Change-Id: I48f5e0550e4ff7a57bd8a8eae057429b620c7508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131379
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dd7293e774f3bdaf3eda8d88c427f1a9b3605a8d]

        Colibre: Fix wrong color, the ones which doesn not follow Monoline (part2)
        
        Change-Id: Ibf021302c6d43bec109969fd7174c3c1532db620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131402
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c45a60386dec9345e42eeb5abe46550943386ae6]

        Colibre: Fix wrong color, the ones which doesn not follow Monoline
        
        Sometimes Inkscape change the object color to full back or sometimes
        a gradient from other file was carried out to the new SVG file. This
        could lead color inconsistencies. Here the fix comes to eliminate them.
        
        Change-Id: Id4dcdd3549ef4ef7b2f89dfe0dddabf324390266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131400
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [efa0d239c5a60b51298e1300aec92d0cfc12ce36]

        Breeze & Sifr: Add missing icons
        
        Change-Id: Iaeeb7026cf440d1db893c0673ea4154e8558e6a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131381
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b634028cec2df4136017be483ebc3c32bc8d9ec]

        use more SfxItemSet::GetItemIfSet
        
        Change-Id: I58af59d82d92c89ca1939d35f9fb4121b6815559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-11  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0234ddcac3acfd00f3a0a7ff89d943cd0b36e34c]

        Breeze: Add many missing icons
        
        Change-Id: I3619601346d7a0c5d149d53dee26e9e07ab35ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131339
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [6e88e4edfba146f6163e7a1173dbd4644b21432e]

        make svx::frame::Style ctor inline
        
        ScDocument: :FillInfo() may result in calling it often.
        Change-Id: I05d0582befc57c4959c33fae6dec3d340b8a49ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131338
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Caolán McNamara  <caolanm@redhat.com>  [916421d72528f99d48af29eeaf92a5a6bb33bfd9]

        remove a pair of newly unneeded translations
        
        Change-Id: Ic4952938db458909dc20663af7dc5f9e5d0a443f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131374
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-11  Caolán McNamara  <caolanm@redhat.com>  [5343835d72f235743c44f12da3c60c25dec5c6fd]

        silence 'sal/rtl/strtmpl.hxx:162: Found non-ASCII char' warning
        
        Change-Id: I7f537c641dcd8aa92cd5034b557f947b4a25ba02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131375
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [c964700d16d99d1569373a1eb9a1352fb3512915]

        Related: tdf#128610 Avoid use-after-free
        
        Creating SvMemoryStream from string makes it non-owning, i.e. pointing
        to the string's memory. So the string must outlive the stream.
        
        Since commit 64bc8b45b5c23efc5fe57585a69aa4263aaf4e83
          Date   Wed Jul 08 12:31:43 2015 +0000
            i#107734 Support for Math Input Panel in Windows 7
        
        Was only working by chance, when destructor didn't clean the memory
        (e.g., in optimized release builds) and the released memory hasn't
        been reused yet.
        
        Change-Id: I2e0c195de7bd2aff2889a94ef0f2eb084411933f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131373
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-11  Kohei Yoshida  <kohei@libreoffice.org>  [f19ae9b5e629d163314ee18d56973d0561d5fb3b]

        tdf#147744: Make sure to pass valid position hints.
        
        When pasting a single cell to a range with filtered rows, the existing
        code wasn't updating the position hint iterator after inserting cloned
        formula cells via ScColumn::CloneFormulaCell().  This caused the next
        call into the cell store to receive an invalid position hint.
        
        This problem has been there all along, but apparently it did not cause
        a process termination with the previous storage layout of
        multi_type_vector for a reason unknown to me.
        
        Change-Id: Ie1a4b99c7077536499c6373ccb7022961e9d93e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131331
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-03-11  Caolán McNamara  <caolanm@redhat.com>  [2c13433ed38e08be60824f21a73ba29f78b9520f]

        ofz#43310 don't try and delete prior header/footer contents
        
        If a duplicate appears, just hide the prior ones.
        
        FWIW our own html export only exports a single header/footer as far as I
        can see.
        
        Change-Id: I5df28f7215ed49ce4a13add990716edcc7f2c72c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131329
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [13acb2c06d9db2f8d79e4cbdc5b76b38a45b5933]

        tdf#63766: remove incorrect UItest
        
        the issue is still reproducible in master, thus this test
        makes no sense
        
        Change-Id: I101230ef13fd6408bab28e8fb7df6efe4ea3f9fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131371
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-11  Miklos Vajna  <vmiklos@collabora.com>  [07c2b73d16425fb6d3ea8ab9ec15c87e9548acda]

        sw clearing breaks: add ODF export
        
        Write the clearing break as:
        
        	<text:line-break loext:clear="..."/>
        
        Change-Id: Ieb517b825f2ee162bb70a453a3756ec870fa8aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131346
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f5f94d153fbade9cd96f841f1084fe16815f4f3]

        tdf#94208: sc: move UItest to CppUnittest
        
        The original test was incomplete and didn't fail without
        the fix in place
        
        Change-Id: I0ddec239b9cb06d90aed21be8b916f39d51a3a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131367
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-11  Julien Nabet  <serval2412@yahoo.fr>  [3307afa99c28fd282094e9558795b0a20ba5c6a0]

        tdf#114150: Remove duplication of strings found in file dialogs
        
        Change-Id: I86f720a23dd9d400d39d9606e073b483850a9df2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131153
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-11  Stephan Bergmann  <sbergman@redhat.com>  [d680b29e05dd3ac2e64e47c4e1f83a4e38b1db24]

        loplugin:trivialdestructor
        
        Change-Id: Id8a35dbbc1eecd2f568f253ddea5cb7ca3064ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131341
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a188ffa01616673c011c7bc1a392a6f6fa81f93b]

        use SfxItemSet::GetItemIfSet in sw/.../ui
        
        Change-Id: Ic6a15dfd159ee2e5d4aa0e0c3bc31cff1557a875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131229
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-11  Mike Kaganski  <mike.kaganski@collabora.com>  [459ee2660cba282ae988da43fdd3147a2ebce58b]

        Simplify MayBeRegExp/MayBeWildcard
        
        Change-Id: Ibc5dc0b1157fa28035fa0d09d7e1a5d34df9e39b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131333
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [dddee125cc32f1ad5228e598a7de04e9654e65c1]

        load ods/xlsx with full row attributes without allocating all columns
        
        If there's e.g. an entire row bold, it's enough to set default
        attribute for unallocated columns.
        
        This also reverts the workaround from commit 297ab561c6754, as it's
        no longer necessary.
        
        Change-Id: I0b208709aeaff1c0d59da2410926876715cfe642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131320
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [69b5f0b6579c6574a8fe68ab2a64208ec767db55]

        loplugin:constparams
        
        Change-Id: I5f184f93dbdb414514855c85c9dc1624e7ec8636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-11  Stephan Bergmann  <sbergman@redhat.com>  [4015b22dbc10bc246a3ef704d8b75e8f8cdca519]

        Simplify ConfigurationWrapper singleton construction a bit
        
        Change-Id: I8b0dd0e049ebeb3304673df3bdb9fe7c755b7750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7002caa97e10d29353d3490b4fbb782d436575b3]

        new loplugin:trivialdestructor
        
        look for potentially trivial destructors that can then be elided
        
        Change-Id: I435c251bd4291b5864c20d68f88676faac7c43fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131318
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a370e7ff7e8225b8343678401eca5a1721b2b9bb]

        Fix typos
        
        Change-Id: I76e302e4db6d048e009d1ccd8dd185610f6ccf9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131334
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [cf95c0024ad9312ebdda382aba8f3cc201a0fdb2]

        don't bother drawing zero-width cells
        
        If a document has most columns hidden, then they'd be "drawn"
        anyway, since ScGridWindow::Draw() calls ExtendHidden(), this appears
        to be needed in order to drawn properly background after the last
        cell. So at least try avoid zero-sized draw operations which
        may add up enough to be noticeable with 16k columns
        
        Change-Id: I631e3be7467f8ea2dbfb824e647f900a7573da61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131326
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Luboš Luňák  <l.lunak@collabora.com>  [eeffa4b2a85751fd0153503520f6fc49b3510d86]

        optimize searching for last visible row
        
        If all the remaining rows until the end of the sheet are hidden
        (which apparently some users do to make the sheet look "nicer"),
        don't search all the rows one by one.
        
        Change-Id: I5f7ef61ece62f7858d4d8cfdf53bb514daa5b504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131323
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-11  Miklos Vajna  <vmiklos@collabora.com>  [e1572ca283cb8aad35a3c81f22aecf18aa86ab90]

        sw layout xml dump: handle blank portions
        
        Show their character.
        
        Change-Id: I811d89954d006e8d042df64520e35f7a8c8cfd36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131327
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-11  Stephan Bergmann  <sbergman@redhat.com>  [52bd453eceea7dfb425e5e58b93244214dad29c2]

        Remove redundant check
        
        The precondition `nIndex >= 0` is already asserted at the top of the function.
        
        Change-Id: I7436ce923b19aa81f08d1fb20680308f609d2242

2022-03-10  Mike Kaganski  <mike.kaganski@collabora.com>  [3ccc4c123f5e78e0204d11abeab2d1a74278ca3e]

        Use OUStringBuffer in ScConcat
        
        Change-Id: Ic1ee6e1a1d13afd7d205cdfb9f76f5e29a176378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131298
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [05d4126637ad3af256b3048ec9dc7e08c2f1a0d6]

        ofz#45344 and ofz#45392 suppress Integer-overflow
        
        Change-Id: I775a5f3c12e784d2716f14fff15a65a669f0ce15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131328
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [7b28920382d3820344bfc4075bac98f85e838dba]

        tdf#113066 tdf#142204 EMF Implement SETARCDIRECTION
        
        Change-Id: I30206c68ecf1829ba0094e6259b8ed7dc05f2e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131103
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2022-03-10  Miklos Vajna  <vmiklos@collabora.com>  [8f48f91009caa86d896f247059874242ed18bf39]

        ODT export: omit unreferenced <text:list xml:id="...">
        
        This attribute is needed when a numbering is built using multiple,
        independent <text:list> elements. In that case the markup to connect
        these are either:
        
        	<text:list text:style-name="L1">
        	</text:list>
        	...
        	<text:list text:continue-numbering="true" text:style-name="L1">
        	</text:list>
        
        In case there is no other list in-between, or:
        
        	<text:list xml:id="..." text:style-name="L1">
        	</text:list>
        	...
        	<text:list text:continue-list="..." text:style-name="L1">
        	</text:list>
        
        In case there are other lists in-between.
        
        This means that at least in case all the text nodes of the numbering are
        after each other, then the random value in xml:id="..." is never
        referenced, so it can be omitted.
        
        This helps deterministic ODF output when the input is HTML, where there
        are never text:continue-list="..." attributes that would refer to these
        xml:id="..." attributes.
        
        Change-Id: Ice69422a12d4229879f89f3a4a24ed926c6d43af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131322
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-10  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [6e8ae79176be1c34cadc833c8e521be19455fade]

        tdf#116256 sw: fix textbox position in floating table
        
        in case of it has to follow the text flow.
        
        Change-Id: Ic4f195c2efcc465276faa9a95362933dafa65bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130077
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-10  László Németh  <nemeth@numbertext.org>  [64dcedcf7c073d1819794d68a33651b14877e1b5]

        tdf#147760 tdf#142902 DOCX export: anonymize date and moveFromRangeStart
        
        Anonymization exported a zeroed w:date in change tracking
        and commenting elements w:ins, w:del, w:moveFrom, w:moveTo,
        w:cellIns, w:cellDel, w:comment, w:moveFromRangeStart and
        w:moveToRangeStart instead of simply skipping it, according
        to OOXML.
        
        Also don't export w:date, if the imported DOCX was anonymized
        by Word's Document Inspector, i.e. it doesn't contain w:date.
        
        Fix also missing anonymization of author and date of
        moveFromRangeStart and moveToRangeStart elements.
        
        Follow-up to commit 2c51746997478ad5d0e7cc64aa6489769c473d43
        "tdf#146171 DOCX: fix loss of change tracking, if no date",
        commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving" and
        commit ded2452a52d21131347a0dc2e25c8161f20fcfad
        "tdf#142902 DOCX export: remove personal info of comments and changes".
        
        Change-Id: If79402e4723886ceab3b4b9c24e83793f87cd513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131317
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [f79ebdeaaacd08328142eedf048f77e11b035801]

        ofz#44982 limit matrices for fuzzing, but allow importing a little
        
        Change-Id: I708811e7e4900fc5d79445e91dc895def552d77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b218d2c85859209267844398b254b8db6fb9a7e]

        use SfxItemSet::GetItemIfSet in sw/.../ui/dialog
        
        Change-Id: I00d7f154fff6e21527ba1f97e8c31cf3c1e508cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-10  Jean-Pierre Ledure  <jp@ledure.be>  [511cc0cd621ebdc67fdfbd440d098b2d1c23dc58]

        ScriptForge - (SF_Root) differ loading of the localized interface
        
        So far, the loading of the user interface in the user's
        own language was done at the first invocation of
        ScriptForge, usually via
        - a CreateScriptService() method
        - a direct call to any method, f.i. SF_Array.Append()
        
        Now the same loading of the user interface in memory
        is done at the first request of a localized text or message.
        
        Due to the fact that since last commit
           https://gerrit.libreoffice.org/c/core/+/131255
        only error messages contain localized texts,
        the benefit is that correct scripts will not load any
        unnecessary texts anymore.
        
        The "Interface" variable has be renamed "LocalizedInterface"
        for clarity in the SF_Root class module
        
        No impact on documentation or Python scripts.
        
        Change-Id: Ie654625540c0c8f8442e9ba36d38ecaab00c0eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131313
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [3edb855e7c0e2ac0d49fa38654efd92c3618ed8f]

        ofz#45385 Integer-overflow
        
        Change-Id: I7d5e4ffa7fc2c46d7a2ad679598aa1a62a623862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131307
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [9929849f2d95fa83cbbd322169f8cf8756b30c75]

        ofz#45424 Integer-overflow
        
        Change-Id: I73efd2f099c6298f4532395c31e2214281c48dca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131309
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Michael Stahl  <michael.stahl@allotropia.de>  [5099c72ea8bfd469bf6e6ab9f8f47f447ab717f3]

        sw: downgrade "SVRect() without Width or Height" to SAL_INFO
        
        This occurs 2500 times in CppunitTest logs.
        
        Change-Id: I946ed240d978f1588ca3bc51c82407cba85e8e1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131316
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-10  Michael Stahl  <michael.stahl@allotropia.de>  [c79bf7865bff4e88cc201357370d8faeef8e6ad9]

        (related: tdf#139687) sw: ignore following footnotes in SwTextFrameBreak
        
        With the fix it now happens that after SwUndoDelete there is a gap at
        the bottom of page 21 and the paragraph at the bottom of it is split
        with 2 lines ("(here, wisdom), " etc.) on page 22.
        
        This is because when this SwTextFrame 1927 is formatted, there are next
        frames also on the page and those have footnotes on the page.
        
        These footnotes take up space and so SwTextFrameBreak::IsInside()
        breaks off the last 2 lines (1 may still fit but it has 2 widorp).
        
        A similar problem was fixed in commit 391613785ae6fbb735cf7a86ea2f6a93161a8769
        for footnotes anchored in follow of the current frame, but here
        RemoveFootnotes() cannot be used as it requires the next frame to
        already have moved to a different footnote boss, which clearly hasn't
        happened yet.
        
        So try something similar to commit e37ffdd118da2d21c5e78e8c7b67252d0d1adc8c
        and count the space taken by such footnotes as available for the text
        frame.
        
        Change-Id: I8f4c1332dc471a68539306a8788a0f59d0b12b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131256
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [84590ee3a9b681408d174449bf0cd3f9bd92e4e6]

        tdf#137008: starmath_import: Add unittest
        
        Change-Id: I4daadf45124331a2fb3b2ba28858c2cfe7c6950e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131312
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b52e7ab543406783a1535d03856a8b13b554a70]

        tdf#140386: math: Add UItest
        
        Change-Id: I7347619ce190778ca12e5bb56c23600efad3af95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131311
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a348c9881c1574604d0e6dcb9ea4fbfebcc7e21]

        uitest: math: at least execute the test on linux
        
        besides, fix it and remove duplicated tests
        
        Change-Id: I15c6696c6cdd1c7e03647e105d8caf268555018a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131310
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [b8e3c05261b0658fcb27c3cc12c7c0646e5aa983]

        can be const
        
        Change-Id: Iccb2f715025aad564850f3d21d46794337400237
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131306
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [317779e86a8cc4d1e2e3c7e227b732407bbadf26]

        ofz#45375 Timeout on negative width/height for MetaBmpExScaleAction
        
        Change-Id: I9c8ce8715cb683ac72f862606b6810fe4f1fe2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131305
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Gabor Kelemen  <kelemeng@ubuntu.com>  [84213a426ad10e85075ef159da28b4e56dabcb77]

        Recheck sw headers with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I99558e6b6952b3f2c1ee32dd07354ff659ad9cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131183
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-10  Mike Kaganski  <mike.kaganski@collabora.com>  [1bbcac7d172f9b0b97d54b07160ac6b5e736e651]

        Use readonly-aliasing icu::UnicodeString ctor to avoid extra copy
        
        See also commit 4ac48ae4b02b8e0e3ae7e4833893f9ad40d4d14d
          Date   Fri Feb 28 14:20:24 2020 +0300
            Use icu::UnicodeString's readonly-aliasing char16_t* constructor
        
        Change-Id: I40243543ae9b4bf97f015f657538e4b1a0eafae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131299
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-10  Tor Lillqvist  <tml@collabora.com>  [376588d3c6c8b83c663f350a7b2db499682e6a80]

        Trust the family name in the font file if necessary in AddTempDevFontHelper()
        
        If the passed in font name is empty, use the one that has been read
        from the font file.
        
        Seems like a reasonable thing to do, and I have a use for this small
        improvement coming.
        
        Change-Id: I3598179bf85ba3acdaca6058982ba5bf81e68288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131300
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-10  Jean-Pierre Ledure  <jp@ledure.be>  [14e550c5963dcd0d0a75666c659b4b91de4b98bd]

        ScriptForge - Console + progress bar receive a Close icon
        
        Next dialogs:
        - dlgConsole (modal or non-modal)
        - dlgProgress (non-modal)
        had a Close button with label "Close" or a translation.
        
        The "Close" text is replaced with a "Cancel" icon.
        
        Objective: make console and progress bar user-language independent.
        
        No impact either on user documentation or on Python part.
        
        Change-Id: Ib1c2370986d47ccab49c6d42500231fd73b9ff3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131255
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-10  Caolán McNamara  <caolanm@redhat.com>  [24babdb2bca7c57f09535a867d1ff0b5e0fc1671]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ie78aea01af09334a271ea50bcb16ba2563304522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131270
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-10  Miklos Vajna  <vmiklos@collabora.com>  [cee9b476d51f770fba03cb20b58370762d387e63]

        sw clearing breaks: fix layout when the line is empty
        
        The break portion's height was not taken into account when the line had
        no text portion ("had no content"). Fix that codepath to also take the
        break portion's height into account, in case that's a clearing break.
        
        Change-Id: Ib7b338911aa23fee766423897ed131ce4029223c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131297
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-10  Mike Kaganski  <mike.kaganski@collabora.com>  [0dc4cbe342d93ce27b92c5a408adcb009b39b48f]

        Use icu::UnicodeString directly
        
        Change-Id: I41b4e64d6d3a9310d819904c8d32c689e6300bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131296
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-10  Stephan Bergmann  <sbergman@redhat.com>  [41cbbb6ecb9d5bbca79d6537228dbabd8c896e84]

        Missing test dependency
        
        > [_RUN_____] HSQLDBTest::testEmptyDBConnection
        [...]
        > warn:vcl.builder:997476:997476:vcl/source/window/builder.cxx:479: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/dbaccess/ui/appborderwindow.ui at xmlreader/source/xmlreader.cxx:66"
        
        Change-Id: I695e19919c66e14852fca2cc23436b463544ec52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131252
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-10  Luboš Luňák  <l.lunak@collabora.com>  [7a9e60c4b7d6c28f5b3e084e3db9ab2445c94bfd]

        fix attr iterators to walk even unallocated columns if needed
        
        Things like applying bold to an entire row no longer allocates
        all rows after my recent changes, but the attribute change is
        done in ScTable to the default attribute of unallocated columns.
        That means that clamping column positions to the end of allocated
        columns is no longer valid when handling attributes. Add functions
        that clamp depending on whether unallocated columns have
        a non-default attribute set.
        
        Change-Id: I879d0a034c0b336064361d0f8cb12e5a8da22b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131265
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-10  Luboš Luňák  <l.lunak@collabora.com>  [a15c02effa654da06e9695b5e4c0c595f851a878]

        add ColumnData() for simple handling of unallocated column data
        
        Move the decision whether to return a column or the default data
        for unallocated columns into a simple function.
        
        Change-Id: I369b8c815de96b61181f2483c6afac44a5c3bc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131264
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-10  Miklos Vajna  <vmiklos@collabora.com>  [f5089e745367e111fb02c493c8c90e96a29e199c]

        sd theme: add PPTX import for shape fill color
        
        The theme index is typically not a direct property, but comes from style
        -> fillref -> theme index, so support that.
        
        Change-Id: I00733db44bb5321019bbc7337d10feb0a34661a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131268
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-10  Gautham Krishnan  <gauthamkrishnanpriya@gmail.com>  [51fb84829afbc1c0957fd1a489085613ad199f1a]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: If35c679839b39a01e474f7b0b0abee570e85bdd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130798
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [409371801a6c4ee00d7e55984e746ea9fe942447]

        tdf#147830: sc: Add UItest
        
        Change-Id: I9cc87630f6e9ec47d68285a8c2008d7afb6dfcfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131251
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [de1a3ebcb45dca64ec90fa3c1387982dee343cba]

        tweak suppression
        
        Change-Id: I85d343b87477fe98b131158c0f8e0654bd130e94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131266
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [db8afa367c6cda4680d820f15b5a91894d990d28]

        ofz#45373 and ofz#45362 fix ubsan issues
        
        replace the home grown 16.16 fixed math with an alternative
        
        Change-Id: If6fa4205aed62ff15157a8ab4dbf9b7c96e30216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131236
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [c391dddb4e6ba514a85e7a2e498db1c7b1d300b2]

        gtk4: remove set_accessible_relation_label_for
        
        and merge the contents of the old set_accessible_relation_labeled_by
        into that so there's only the need to have one call.
        
        Change-Id: I1c109fddd59219c4364103bf00d4d5b140bbdeab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [ea5af2f02a7b7ace1e3927d7eff684b9fbb26fd8]

        gtk4: use gtk_accessible_update_relation to set labeled_by
        
        Change-Id: I3dc69cf362192295d94e8f4d4072104430589a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [d07cb9eccd7ae0a24e352906578d5c514ff3bc1d]

        use SfxItemSet::GetItemIfSet in sw/.../ui/misc
        
        Change-Id: Icf83de0ca3f0bef20d73f65d0d540a222f1edbe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131260
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-09  Michael Weghorn  <m.weghorn@posteo.de>  [f56b932487509de1ecde46a42c40df76c6ecebcf]

        a11y: Leave cell vector handling to AccessibleGridControlTable
        
        Use `AccessibleGridControlTable::getAccessibleCellAt` and
        cast to `AccessibleGridControlTableCell*` instead of
        directly accessing the cell vector in
        `AccessibleGridControl::commitCellEvent`.
        
        `AccessibleGridControlTable::getAccessibleCellAt`
        just needs row and column index as parameters,
        and already takes care of everything else that's
        needed.
        This includes creating an accessible object for
        the given indices on demand.
        
        Therefore, limiting this to only already existing
        a11y objects, which was done to avoid crashes in
        
            commit 4fc7deb7b0528010ebf644654bf4a36594e03f8c
            Date:   Thu Oct 3 23:16:34 2013 +0200
        
                fix STL assert in accessibility::AccessibleGridControl::commitTableEvent
        
        is no longer needed.
        
        With this change in place, details of how cells are
        organized in the vector only need to be known inside
        of the `AccessibleGridControlTable` class itself, so
        drop the now unused method
        `AccessibleGridControlTable::getCellVector`.
        
        (This code path is e.g. used when using
        the macro from tdf#147742.)
        
        Change-Id: I21027f0edc2904475ad6cc5fb136316f387499dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131248
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-09  Michael Weghorn  <m.weghorn@posteo.de>  [4e641d9240a981216d6724141b9b7a9e4c63c82a]

        Related: tdf#147742 a11y: Dispose table cells as well
        
        When disposing `AccessibleGridControlTable` (which
        is done in `AccessibleGridControl::disposing`),
        also dispose its cells and clear the references.
        
        Without this in place, a crash sometimes occured
        when running the macro in the sample doc from
        tdf#147742 several times and clicking around in the
        table, with the Orca screen reader active.
        
        This was because a reference to one of
        the `AccessibleGridControlTableCell`s was still
        around after the `AccessibleGridControlTable`
        had already been disposed, and when trying
        to get its accessible name, the call to
        `IAccessibleTable::GetAccessibleObjectName` in
        `AccessibleGridControlCell::getAccessibleName`
        would fail because the object that the
        `m_aTable` reference was referring to had already
        been deleted.
        
        With the cell being disposed as well, the
        `ensureIsAlive()` check at the beginning of
        `AccessibleGridControlCell::getAccessibleName`
        will throw a `DisposedException`, that is then
        handled properly in the calling code.
        
        Backtrace (with master as of commit
        2598c35dbac8dc4492ad1fc79925c5347e683af0):
        
            #0  0x00007fffd9152ed3 in accessibility::AccessibleGridControlCell::getAccessibleName() (this=0x55555bbcdb70) at /home/michi/development/git/libreoffice/accessibility/source/extended/AccessibleGridControlTableCell.cxx:79
            #1  0x00007fffe45e864a in wrapper_get_name(AtkObject*) (atk_obj=0x55555bbcef60) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/a11y/atkwrapper.cxx:369
            #2  0x00007fffe3a87e5c in  () at /lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0
            #3  0x00007fffe3a947de in  () at /lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0
            #4  0x00007fffe3a94caf in  () at /lib/x86_64-linux-gnu/libatk-bridge-2.0.so.0
            #5  0x00007ffff75feff0 in  () at /lib/x86_64-linux-gnu/libdbus-1.so.3
            #6  0x00007ffff75eea1c in dbus_connection_dispatch () at /lib/x86_64-linux-gnu/libdbus-1.so.3
            #7  0x00007fffe36d74a5 in  () at /lib/x86_64-linux-gnu/libatspi.so.0
            #8  0x00007fffe9ab8cdb in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #9  0x00007fffe9ab8f88 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #10 0x00007fffe9ab903f in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #11 0x00007fffe460f546 in GtkSalData::Yield(bool, bool) (this=0x55555567c750, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkdata.cxx:405
            #12 0x00007fffe461402a in GtkInstance::DoYield(bool, bool) (this=0x55555567c5d0, bWait=true, bHandleAllCurrentEvents=false) at /home/michi/development/git/libreoffice/vcl/unx/gtk3/gtkinst.cxx:427
            #13 0x00007fffef7ab4be in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:474
            #14 0x00007fffef7ac0b0 in Application::Yield() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:558
            #15 0x00007fffef7ab18e in Application::Execute() () at /home/michi/development/git/libreoffice/vcl/source/app/svapp.cxx:452
            #16 0x00007ffff7c309af in desktop::Desktop::Main() (this=0x7fffffffd780) at /home/michi/development/git/libreoffice/desktop/source/app/app.cxx:1604
            #17 0x00007fffef7c9d75 in ImplSVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:202
            #18 0x00007fffef7c9e96 in SVMain() () at /home/michi/development/git/libreoffice/vcl/source/app/svmain.cxx:234
            #19 0x00007ffff7c947c9 in soffice_main() () at /home/michi/development/git/libreoffice/desktop/source/app/sofficemain.cxx:98
            #20 0x00005555555549f4 in sal_main () at /home/michi/development/git/libreoffice/desktop/source/app/main.c:51
            #21 0x00005555555549da in main (argc=4, argv=0x7fffffffdaf8) at /home/michi/development/git/libreoffice/desktop/source/app/main.c:49
        
        Change-Id: Idffa76809cbfad746f27d18191fdfc905b64ee0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131247
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-09  Michael Weghorn  <m.weghorn@posteo.de>  [b86c4d962c7df4a5066ee634df88868b8bb287fe]

        a11y: Drop AccessibleGridControl::m_xCell
        
        It's only used in one place and I see no need to keep
        a Reference in this class, so use a local variable
        instead of a class member.
        
        Instead of disposing this single cell in
        `AccessibleGridControl::disposing`,
        `AccessibleGridControlTable` should take care
        of disposing all of its cells, which will be
        added in a following commit
        (Change-Id Idffa76809cbfad746f27d18191fdfc905b64ee0e,
        "Related: tdf#147742 a11y: Dispose table cells as well").
        
        Change-Id: Ia7c84c65b45dde28850f48b12ab9558f2dc7d47c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131246
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-09  Michael Weghorn  <m.weghorn@posteo.de>  [5977d6b981dcde556450589199c06204009a4a1a]

        a11y: Let AccessibleGridControlTable calculate child index
        
        Just call `AccessibleGridControlTable::getAccessibleCellAt`,
        which already takes care of calculating the proper child index from
        row and column index.
        
        Change-Id: Id463c14108158c5833231f95cf16847764f5b646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131245
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-09  Michael Weghorn  <m.weghorn@posteo.de>  [319a5b5b457c46c8a036b99d6f024517bc87be42]

        a11y: Move TABLE_MODEL_CHANGED handling to table
        
        Move the handling for the
        `AccessibleEventId::TABLE_MODEL_CHANGED` event of
        type `AccessibleTableModelChangeType::DELETE`
        from `AccessibleGridControl` into
        `AccessibleGridControlTable`.
        
        To do so, make `AccessibleGridControlBase::commitEvent`
        virtual and override it in `AccessibleGridControlTable`.
        The method already gets called from `AccessibleGridControl::commitTableEvent`
        where the event was handled previously.
        
        Handling the details of how cells are internally
        organized in a vector only in the class itself
        rather than in different places seems to make sense.
        
        There are currently more cases where `AccessibleGridControl`
        deals with the cell vector directly that will be
        addressed in following commits.
        
        Change-Id: I26a7737432ecb198eac00279a8242d22e3c661d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131244
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-09  Miklos Vajna  <vmiklos@collabora.com>  [63dba12b779dd4d007c8cb8cf4b967bd78077cac]

        PDF export of PDF images: don't preserve annotations in general
        
        Regression from 33c9bc0225a92f26770f9ef20b252af47853e7b9 (PDF export of
        PDF images: preserve hyperlinks, 2022-01-07), the problem was that we
        want to preserve hyperlinks, but annotations are added by the PDF export
        explicitly, so it isn't a good idea to "preserve" them as well.
        
        Fix the problem by going back to the old behavior, except when the
        annotation sub-type is /Link.
        
        This keeps hyperlinks working but doesn't lead to duplicated comments
        when re-exporting an image + adding comments explicitly.
        
        Change-Id: I910990da59bdc1150cc346f1a5471cb6da55dd2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131243
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [77f4407cb5e8c22320bc2c750384e992fe076cf9]

        gtk4: get a11y description and label/name
        
        via gtk_test_accessible_check_property which seems to work for my needs
        though maybe not what its intended for
        
        Change-Id: I9fc0296edd7ad2459cab7d6bafae66e220b422dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [4cefeb50418e42cdad11429a2c5e03f5d21e73fd]

        use SfxItemSet::GetItemIfSet in sw/.../ww8
        
        Change-Id: I304b0cfbb191254db5176049696e5a3f6666f271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [dfaa3fb58bd35dbc2fcae094d080a56430a2b876]

        code accidentally commented out
        
        in commit 02caa6e40cfa55d96befc82515b343045b5cfd7b
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Feb 24 16:17:46 2022 +0200
            renames in template manager creates xml file in wrong location
        
        Change-Id: I21c06ebcfcfaf5fabe75aa3421948bb5a48d6176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-09  Michael Stahl  <michael.stahl@allotropia.de>  [86081afc3021fa0ae6c2b32d11b4b20cc8a190a3]

        tdf#139687 sw: invalidate text frame in footnote when moving it
        
        The problem (which only reproduces here on copy/paste with
        SAL_USE_VCLPLUGIN=kf5, not with gtk3) is that on SwTextFrame 2638 in a
        footnote on page 19 containing "Saeed, 100–101." there should be a top
        margin of 0 but it's actually 144.
        
        The footnote was initially created on a previous page with another
        footnote with SwTextFrame 2635 before it, that's how it got this top
        margin.
        
        Invalidate the print area in SwFootnoteFrame::Paste(), which is called
        when the footnote is moved to a different container.
        
        (somehow regression from commit 723728cd358693b8f4bc9d913541aa4479f2bd48)
        
        Change-Id: I7346fd03fccad3eddccbbcd56c4b50127a337b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131217
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [17546fa4f630bccd92e438b613014982a8d9fc03]

        gtk4: use new mechanisms to set a11y description and label/name
        
        Change-Id: I08ffd80f53e6360ddc2093523333b90ddedad294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131239
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Dr. David Alan Gilbert  <dave@treblig.org>  [9579737b36e5055d5eb72abc0ace2b9b65600c76]

        tdf#143216: pdfwriter: Don't treat semi-valid URIs as local paths
        
        Currently the PDF writer treats URIs that are rejected by INetURIObject,
        as local files, and prepends a path to them.  For URIs that are valid
        according to the basic URI syntax, but unhandled by INetURIObject
        (such as http://user:password@domain) this produces a confusing result
        with a ./uri in the PDF.
        
        Avoid the prefixing where the URI follows the basic URI syntax, even
        if INetURIObject didn't like it.
        
        Change-Id: I87c599885a40fd7101c678ae79f83f594d0f23ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125202
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-03-09  Dr. David Alan Gilbert  <dave@treblig.org>  [d8c5fdcb3f1e2fdaacc6a7e403a2077d93207c82]

        pdfwriter: Add check without relativeFsys
        
        Set relativeFsys on a per-test basis and add a test with
        relativeFsys off.
        
        Change-Id: I43b1d82200aca37b2cf8ac71d77a4aa61df543ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130197
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [dcd5fa0a7b896fd585ef964cf62ae70d247250f1]

        Drop misguided test added in 82a1d32d3d3ac1b4b0a6d4cfaca791c77d9b3c03
        
        The documented precondition is that index must not be greater than
        the length of string. Just assert that, and fix the found misuse.
        
        The added test is for in-place replacement, just in case.
        
        Change-Id: I3c545a6f0bf913fe93e2bef83ce733359c193065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131232
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-03-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [dd4dbc70d413ada95632eb818b4d435a14e87303]

        Colibre: Update some save icons & icons with print element
        
        Change-Id: Ib16046509ba51069f21f5c5bb79fc79b1bb9e2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131240
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-09  Caolán McNamara  <caolanm@redhat.com>  [6821d3ea7af00edc9e403581b029cf164dae4899]

        ofz#45385 Integer-overflow
        
        Change-Id: If65451a787c5709d792f9972e75e353b9b09f2ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131233
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [35dc4d32de59f14c388239449d4e89e0a5c4509b]

        use SfxItemSet::GetItemIfSet in sw/.../xml
        
        Change-Id: Id74876ca1217d8401798e8b43ca5464b3241d8c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131230
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [4e76c3ab5f029a4a4bb1042ad225edc1116e4b44]

        Related: tdf#146551 Make image and native checkmark same size in menu
        
        Commit 1be170d0629cf761f0ee4173007a3c021966546e tweaked the checked
        background rectangle to be 1 pixel shorter, to address the asymmetric
        vertical position of the rectangle on Windows, where toolbox button
        draw (used for the checked image state on menu) has 1 pixel smaller
        height than requested; but that seems incorrect. The native checkmark
        is drawn on e.g. 22 pixel high rectangle, while image background was
        20 pixel high after the abovementioned change.
        
        So instead of making top a bit lower, keep it as it was (aligned with
        the top of the menu item), and move its bottom 1 pixel down, to align
        with menu item's bottom.
        
        Change-Id: Ie1846061bf16fb8bb3ccf2ae1651c8b83b5b1283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131174
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ae0aa5e200a57cb30b6ca0131e7b6b7acb49791]

        use SfxItemSet::GetItemIfSet in sw/.../ww8
        
        Change-Id: I5dc3ac6fba9cbd7902151506e6b696ac5c247af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-09  Michael Stahl  <michael.stahl@allotropia.de>  [bc9eaec36f2fcc9f9263da84480856cfbdca0c99]

        sw: ModelToViewHelper: replace RES_TXTATR_ANNOTATION with nothing
        
        It's a field but unlike other fields uses CH_TXTATR_INWORD so it
        probably shouldn't break words.
        
        Change-Id: If14ac24ec3e7eee15d67f91a0e2b17ab2c2637cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131216
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-09  Michael Stahl  <michael.stahl@allotropia.de>  [e07b9c5142af838648a4d03a0bdce76612cf7535]

        tdf#147416 sw_redlinehide: fix spell checking popup
        
        The problem is that SwEditShell::GetCorrection() uses the SwTextNode
        text without filtering redlines.
        
        Using ExpandMode::ReplaceMode should work as it will replace
        CH_TXTATR_INWORD with nothing and CH_TXTATR_BREAKWORD with ZWSP.
        
        Unfortunately there isn't yet a mode that can handle fieldmarks as they
        are displayed in the layout.
        
        Change-Id: Ia243d90309fdd7b6ca159c5df2f4d98725400c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131210
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-09  Michael Stahl  <michael.stahl@allotropia.de>  [d814941b31b4f9cc8b6e9bd4ddc5188015529707]

        sw_redlinehide: get text from shell, not node in ExecSpellPopup()
        
        Change-Id: I0160c4927a2f5e71f5025c2162a103f67ed03723
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131209
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-09  Michael Stahl  <michael.stahl@allotropia.de>  [53560aa06462f1cf04d69acafed20da971bc5c27]

        sw: fix merging of format redlines in AppendRedline()
        
        This can cause:
        
        soffice.bin: sw/source/core/undo/undobj.cxx:1486: static void SwUndo::SetSaveData(SwDoc&, SwRedlineSaveDatas&): Assertion `rSData.empty() || rSData[0].m_bRedlineMoved || (rSData[0].m_nRedlineCount == rDoc.getIDocumentRedlineAccess().GetRedlineTable().size())' failed.
        
        When one character in middle of Format redline is deleted, then Undo.
        
        The condition is quite odd and apparently from initial CVS import; try
        to copy condition for merging Insert redlines instead.
        
        Change-Id: Ib56e12914269b878c16813b9e95b2f0df3330bbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131208
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-09  Miklos Vajna  <vmiklos@collabora.com>  [280ab11ee40c95d2513e6f23ec5b08a083ecc1c5]

        sw clearing breaks: add DOCX export
        
        Need to do this in two passes, because a clearing line break is a text
        attribute, but the DOCX markup is not a run property, so can only write
        it once the run properties are finished.
        
        Change-Id: I74e94dbd02ca4e6ceee0439c5eafd3c3bbe2264b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131231
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-09  Miklos Vajna  <vmiklos@collabora.com>  [493e7a952d291cbb0601ddc7bdc791bf21d5af88]

        CppunitTest_sw_ooxmlexport4: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Idcd5b5a2171d9e261f614bbdc1ca69b7feb9fa01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131223
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-09  Luboš Luňák  <l.lunak@collabora.com>  [4c5f8ccf0a2320432b8fe91add1dcadf54d9fd58]

        change default Calc number of columns to 16384 (tdf#50916)
        
        All tests pass now, and I've also handled all significant bugreports
        from tdf#133764. This commit is mainly meant to test this more
        in practice and collect feedback. Depending on how this turns out,
        there may be a backwards compatibility option or something similar,
        but so far I see no significant need for it.
        
        Change-Id: I1a946f4e0b51be5acf4e25dc773e7694c2b17b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131180
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-09  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [d6cd44b74cf0b6b0eaeea6f986f749da42d171ac]

        Fix some mistakes in strings reported by translators
        
        Change-Id: I56defd20865ddfcefd51dae624f3331abc8dd93c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131228
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-09  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [59bb9076aba89bb13fd16cb68943825554223913]

        Update a string I forgot to include in 9f16c3b5ac3ae1c9d24fe137ff48b67f54e4899b
        
        Change-Id: If0a281ec47f856720ec7baabfdfd4f9d77a9ada2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131227
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84e56886d7470b9a51740b831047132922daacce]

        Fix typos
        
        Change-Id: Ibaefacb89a680f5d7a34e64fdf856fbd0575ee4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131226
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-09  Mike Kaganski  <mike.kaganski@collabora.com>  [82a1d32d3d3ac1b4b0a6d4cfaca791c77d9b3c03]

        Simplify getToken
        
        It should not attempt to dereference pointers when nIndex is negative.
        Properly handle too large nIndex.
        Also it is not necessary to parse the string when nToken is negative.
        
        Related to commit be281db569bafaac379feb604c39e220f51b18c4
        
          Author Rüdiger Timm <rt@openoffice.org>
          Date   Mon Sep 20 07:43:20 2004 +0000
        
            INTEGRATION: CWS ause011 (1.18.22); FILE MERGED
            2004/08/18 11:47:54 sb 1.18.22.1: #i33153# Made getToken more robust.
        
        Change-Id: I6fc77a5b70308ccca08cb2132bd78d024bd7e3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131221
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-09  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [db5207644308f304372d4d63a5f8f3f904b26869]

        Colibre: Update some icons with navigation and ruler element
        
        Change-Id: I53afd1f54cfc883c3b14a9eb2b66cdf141661d34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131225
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-09  Jim Raykowski  <raykowj@gmail.com>  [279abd670317760dd1d58c549a0589c3a31c1e4d]

        Fix annotation window from being created by Navigate By Comment
        
        when a text selection is present.
        
        Change-Id: Icef331334a8ad7a499477860c6d883f26e909577
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131158
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [de3f19062a84890fc89cd4836512ded5b5d82b94]

        ofz: Timeout, give up earlier with a broken font
        
        Change-Id: Iccaedebe94db567cb248e0263d03983fc42b5d3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [ee116e166286d2fe0f35f1759c126d4207ee213f]

        cid#1502938 Uncaught exception
        
        Change-Id: Ie0c408a7cdbf09e877d0ff8d62c0675ad5e4f2eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131212
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [4f2ec0ab9c1055920cb5c08b2d237087493130b8]

        optimize checking for conflicting named ranges
        
        This extends 582fc887f1faafe8ff5f16a13a0208483a93353f, first
        check if there is any named range that could possibly conflict (which
        generally should be rare).
        
        Change-Id: Ia5e9e56cab29b459bcb489e871b4960ba215b665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131219
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [371e82c2d90c21bb9df6e4c110a229d29e24c4d3]

        don't provide non-const iterators to ScRangeName internal data
        
        Also make few trivial functions inline.
        
        Change-Id: I89b11b2aa4558696d624c9bde9135b1324b8eb36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131218
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [6bdabb9e14231b46b888810856a3bd3b11ff5128]

        Resolves: tdf#147722 ScrolledWindow expands beyond buttonbox
        
        Change-Id: Iaf65bf681739c7fc2c7cb14851621442a861c234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131108
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [9cfa3e086dc3be2b797edcc0e5ef2596b556cf7f]

        GetDisplayText() returning empty string if widget is clipped out
        
        seen in: make UITest_sort UITEST_TEST_NAME="tdf105301.tdf105301.test_tdf105301"
        
        with the fix for tdf#147722 which resulted in the first few rows
        scrolled out of view and GetDisplayText() then returning nothing
        
        Change-Id: Id833a6b5029a490b08e730c641bf9dcdea627b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131220
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [5da1d655bfb851d8d07c78b08e08d975549e95d3]

        ofz#45357 Floating-point-exception
        
        Change-Id: I2970c2b09d19f43cc4f98a89d2b99eb4475c3065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131178
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Jean-Pierre Ledure  <jp@ledure.be>  [7e834362a868979e8d703ff61bc22772b671e678]

        ScriptForge - 'SF_Root) load user interface from code when locale=en
        
        The user interface is loaded in the user's language
        at the first use of Scriptforge during the LO session.
        
        So far the labels were always loaded from the relevant
        .po file.
        Now they are loaded in memory by code when the user's
        language = "en".
        
        Objective = gain in performance.
        
        Additionally the default language is set to
           SF_Platform.OfficeLocale
        i.o.
           SF_Platform.SystemLocale
        
        Internal change, no impact on documentation
        
        Change-Id: Ia0d1235f8ca6a42141a5481fe80b5bec1d53a7e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131214
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [f5467ffb31fbd17d0ed57f9453373e36803404b0]

        tdf#107869: sc: move UItest to CppUnittest
        
        Change-Id: I6b8ab5e7fce23f25cf89ac09caa746787ce209d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131215
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [c9efbdbfaf110c18576b7294b72cd03dad310720]

        replace member-of in .ui a11y relations
        
        Change-Id: I454c945c5ce17bcc1834923064014b43a0b45be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131186
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [2c3779475299eeed6fd9836c03aa22e1b3a41e88]

        remove some member-of a11y relations
        
        In some cases the widgets are in frames now so that hierarchical
        relationship is captured already. In others labelled-by is a better
        match and/or is already labelled by the widget.
        
        Change-Id: Ifecd0eb96afecadbd66fcfdf843ce1590f5c5ff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131185
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [18e2a86f92689dcd43975e69ed79f6575de12a75]

        stop ScTable::ExtendMerge() from needless complaining
        
        With dynamic columns it is possible for it to be called
        for unallocated columns, and those can't be merged.
        
        Change-Id: If4a365ba175b9ea7e68704bb4db85a30e5f8a0db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131211
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [d032b81bbf2ca87114d15749d74166d0ba414972]

        proper columns range check (tdf#147830)
        
        Change-Id: Ib23bc3f194fa418035e7c70a4f3e1b682f9c46b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131181
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Noel Grandin  <noelgrandin@gmail.com>  [d73551e4023f2c9de5adaaba3d2dc0e940de41e4]

        no need to allocate fallback list separately
        
        an empty map is just a couple of words of storage anyway
        
        Change-Id: Ic14eb370cee5522f435c6709529c8480d2af9e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131170
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [5bf404afe2e075c6dea8bf1f57f2adbc575f712b]

        resave with latest glade
        
        Change-Id: Ie0e04a86d8aa8a2425fddb74089721f69d3bbe87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131184
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [34a34ec566f09e48fc5ec2ca65ffe34456c0ffea]

        move variables to where they are first assigned
        
        Change-Id: I529b4039a1962f9bafb29119c4ba6a9f5960bd22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c4afafa317f2e0adf56deffc4dc9f73ca4d45c6d]

        Sukapura: Update Frame Line Color icons
        
        Change-Id: Ie6cab6f9853f4a6d338f6291b5e093efe1b0cec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131176
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4fca66bd1f3e319b1ab33acd37da3fa06e84b1be]

        Sifr: tdf#147838 image for Base preview
        
        Change-Id: I3348ae989b57477ffa741b7f4e38ec9114fef66e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131173
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ab552b73e03c442e741443270e708d87a491d06c]

        Breeze: tdf#147838 image for Base preview
        
        Change-Id: Ib37ec53fed6d6d9ac2a39f9e81aff5564fb1d34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131172
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Stephan Bergmann  <sbergman@redhat.com>  [42b37ba1d19a0543b7edda2c9d8bbb9b80507a7c]

        Drop some debug code
        
        ...that had been introduced with 7e8e85adbee73346403c364326544487677cd5c6 "Add
        codeSnippet debugging output when dbglevel>1" and reinforced with
        6f121860d0537060084278da11842732a748d6b7 "tdf#130924 replace debugging printf
        calls with SAL_INFO/SAL_WARN"
        
        Change-Id: I9529bfdedd3d1a3dd623fdb28e01d6bd96c92d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131169
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-08  Miklos Vajna  <vmiklos@collabora.com>  [f86d1482bef285f90079b5130e410646db96cf58]

        sw clearing breaks: add DOCX import
        
        Map <w:br w:clear="..."> to the com.sun.star.text.LineBreak UNO service,
        but keep the default clear=none case unchanged.
        
        Change-Id: I145e891c1df0bbd0fdac2c62463dc801bca827fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131167
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [3455ef6eff0edb15b59d4e8818a1ce8f54b4454b]

        remove some member-of a11y relations
        
        In some cases the widgets are in frames now so that hierarchical
        relationship is captured already. In others labelled-by is a better
        match and/or is already labelled by the widget.
        
        Change-Id: I65cbeab514a443edd96c6f9353f892317ac5f775
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131155
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [48750b4ec4aeac978dbb0dd4dbf664ef87df9c3f]

        optimize ScTabView::SkipCursorVertical() for many rows
        
        Just like already done for RowHidden(), avoid repeated calls
        to HasAttrib() and IsVerOverlapped() that would return the same
        value because it's the same underlying attribute range.
        
        Change-Id: Ic270f5ba1333e15d46b5e54e14d9760602221ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131151
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [0e6465ecc0b4c607480f798b6f15e4dbbbbebb77]

        fix GetAttr() for unallocated columns
        
        Change-Id: Id7cbebf68ec3cc54d773bc5745fab192d043f952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131150
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [1e7be382b1f400801d350067e4dfd40d4cfd2db3]

        revert/fix the incorrect fix for tdf#126904
        
        The default cell style has protection turned off. That means that
        any cells that do not have a style that turns the protection on
        are actually not protected. So the original code was correct,
        it went beyond the cells explicitly saved in the file and the first
        "default" cell was not protected, so it was ok to jump there.
        Re-saving this document to xlsx and opening it in Excel has the same
        result.
        
        So revert the change. Keep the test, but edit the test file to
        actually protect cells in the default cell style too, as that way
        it's actually useful as a test of protected cells. And since
        the test for tdf#126904 is a subset of basically the same test
        for the same "bug" tdf#131455, keep only the larger test.
        
        Change-Id: I36f21c33aaf5a31e95aa29d616c6abdec17fcf42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131126
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [866c3ac0631f809f98547ee067dd226970db80c6]

        KJ: tdf#147838 image for Base preview
        
        Change-Id: Iee19c5a60aa0f1f7e17a446661f1db3741e1350f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131171
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [5c9e6a6a2b7fbdfc3ee32ef2b9d5433270fd6161]

        tdf#112126 Added Unit Test
        
        Change-Id: Ia02d0846ee932188a90687a2f29183e34e01c4c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129922
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-08  Tor Lillqvist  <tml@collabora.com>  [ba2f243d684fce905b1dc8871f57c64008471405]

        Make comment less misleading
        
        Change-Id: I608abe994cc8a67c295450d836d8c423026b85d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131175
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-08  Hossein  <hossein@libreoffice.org>  [abaac7a4c1b27d71c4e6f9cfb64900619a46f7f7]

        tdf#147801 Demote bsdtar in favor of tar in configure.ac
        
        The utility used to extract archives including tar.xz is chosen among
        'gtar gnutar bsdtar tar' (respectively) that may be present in the
        system PATH.
        When compiling LibreOffice, there is a possiblity that some bad tools
        that are available in the PATH are chosen incorrectly. As an example,
        Anaconda on Windows provides a 'bsdtar' utility which can not handle
        tar.xz files, but it is chosen as the archive extraction utility.
        
        This patch demotes 'bsdtar' comapred to 'tar' in configure.ac to fix
        the issue, which is filed as tdf#147801.
        
        Change-Id: If6aa47b9255a54c1220bbfce6c2515dc53fb795b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130974
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [5ffa84963cdff4d8e3f873bc54404e04b32bbdbe]

        elementary: tdf#147838 image for Base preview
        
        Change-Id: Ie840eae9f0ee2e05d76b21f7595e9d157b61baf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131168
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c4e0fd8dd682820c7daed1b7043e0612696ed513]

        sc: write the OOXML Sparkline props. to the model
        
        This moves the properties read during the OOXML import into the
        SparlineGroup class (the document model), so a sparkline can
        be connected with the properties.
        
        Change-Id: I09ecf560f1870624cb984722bdb8ee306d839dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131163
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e51784458bc46411d739877707f7952dd6808fa2]

        sc: add Sparkline to the model as a column multi_type_vector
        
        This adds a Sparkline class and a SparklineGroup class. The
        Sparkline class is added to a cell, and the SparklineGroup
        is referenced by the Sparkline, so multiple Sparklines can
        share the same properties.
        
        Change-Id: Id309ded34bfa7a35c1be43f7c0543d88594e66ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131162
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [04b3a9baf5731696418bc1a6db8c8b1bf65dc7c4]

        sc: support reading sparklines from OOXML document
        
        Read sparklines and sparkline groups from the OOXML document and
        add store it into a (temporary local) doc. model.
        
        Change-Id: Id2d34db70300957735571875d6defb3d560fbb26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131161
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [f35d1a9f16c811ea941be7d19228a92dd6be6acf]

        resave with latest glade
        
        and drop empty column
        
        Change-Id: I05aeb12fecf044aa8a95aa8bf35bf605c35f2498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131154
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Caolán McNamara  <caolanm@redhat.com>  [873454c9f4e044a00d67320bcbee7d02d719a723]

        ofz#45125 Indirect-leak
        
        Change-Id: I208c0b6751eefbe6dddffa126fe3d89a3bd353af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131149
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ddf4e817d2a9e005cdb26965014ae4e59da32b74]

        Colibre: tdf#137520 Increase & Decrease Font icons
        
        Change-Id: Idea7c926304008c00b281da6c9a37ceae4e6c9c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131166
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [43f717b06c514f1ac878cd1f0c078182a93875c5]

        Colibre: tdf#147838 revise Base dummy preview icons
        
        Change-Id: I72f19849f48566769a12be8a3b04308c8fcf7846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131165
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Stephan Bergmann  <sbergman@redhat.com>  [5f5d7931d991e02a12536ca69df7715ed42a1f85]

        Fix --with-latest-c++ build
        
        > In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCase.h:6,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:5,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h:9,
        >                  from sal/qa/rtl/oustring/rtl_ustr.cxx:25:
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type = std::__cxx11::basic_string<char>]’:
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50:   required from ‘static std::string CppUnit::assertion_traits<T>::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58:   required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > sal/qa/rtl/oustring/rtl_ustr.cxx:696:17:   required from here
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char16_t) [with _Traits = char_traits<char>]’
        >    25 |     ost << x;
        >       |     ~~~~^~~~
        > In file included from include/rtl/ustring.hxx:34,
        >                  from sal/qa/rtl/oustring/rtl_ustr.cxx:22:
        > ~/gcc/trunk/inst/include/c++/12.0.1/ostream:558:5: note: declared here
        >   558 |     operator<<(basic_ostream<char, _Traits>&, char16_t) = delete;
        >       |     ^~~~~~~~
        
        Change-Id: I70ae970c10650d0e6efa5ced3a354090642d5387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131164
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-08  Miklos Vajna  <vmiklos@collabora.com>  [82c879d8ff5c77d0d257e0659cb974460439f7cf]

        sw: document SwXMailMerge
        
        I.e. unlike footnotes or bookmarks, this is not specific to an opened
        document; while the UI only provides the matching menu item only for an
        opened document.
        
        Change-Id: I743bee4848a2da030369b9da55e0aae9bd2a86a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131148
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-08  Mike Kaganski  <mike.kaganski@collabora.com>  [69aae269ec597b9ee2ec27a2f0c3bbf48b898941]

        Fix a DPI-dependent test
        
        It fails locally on Windows using 150% scaling with
        
          - Expected: 9419
          - Actual  : 9437
        
        The original size of page in the PDF is 267.507 x 85.627 pt.
        Converting that on 96 DPI gives 356.68 x 114.17 pixels. Without
        rounding, that translated to 356 x 114 in vcl::RenderPDFBitmaps.
        
        This adds rounding when calculating bitmap size, giving smaller
        error (9446 hmm wide, less than 10 hmm from ideal 9437 mm/100,
        compared to almost 20 hmm error before). Also it adds tolerance
        to the unit test.
        
        Change-Id: I3cd8f6c0e1235adf2fe1c17f4c56f3667f0132bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131110
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-08  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e91a0dbb003ccf112627bc1547d79e2a035bcce1]

        Sukapura: tdf#147835: Fix paragraph direction
        
        Change-Id: I6cfb44ed407048c5ed77783889519ccb595541b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131157
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-08  Luboš Luňák  <l.lunak@collabora.com>  [c33fb83a62a4a155f11b082e6eb99d07403c3bb9]

        remove pAttrArray nullptr checks
        
        I missed these in 2e2e30d7ae445509e39ba47c1b248079f28c8d95.
        
        Change-Id: Ib0f75a2a0f018521e2468e83bdf41196f4b66c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131152
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [9aa1753aead0cf30387b26e6a50d2cce9392453f]

        gtk4: convert .ui a11y name, desc and labelled-by
        
        Change-Id: I3aa380330ccb22fdbc0dc356f1c9c973d14e02c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131118
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2d1d8006e0dfb26e1ea5d74b12036fb3dac0b1e]

        tdf#147755: math: Add UItest
        
        Change-Id: I778f5f309495ee3806ed15dfb753bad2683f360d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131117
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-07  Deep17  <deepoose2011@gmail.com>  [1fb1f0be10b5d6ce3be5bb364b4c9a8eb0d31b54]

        tdf#42982: improve UNO API error reporting
        
        Change-Id: I82adf31db09d2157ee8f1c776f33e8a0107c3b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131090
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [e2076b31a91d3882f3deeaa5d3d4659da0e4b17c]

        tdf#147414 sw_redlinehide: fix cursor position after AutoCorrect
        
        Change-Id: Ia06cd4e1a74a21788e4d0ddb5f0481e8a144d863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131147
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [b461ada70158de5cd2e96a54147c8e46ee1ca4ac]

        tdf#136632: sd_png_export_tests: Add unittest
        
        Change-Id: I1d85f989dd2a56f693befcf995985a69f62354cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131114
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [794b93daa9bc31f4ca78d5d88a8dafb12f7ff869]

        Resolves: tdf#146825 select under mouse on right click
        
        if something isn't already selected
        
        Change-Id: Ifa692cd71bb71ecb5c7af732deef510f2bac5fce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131111
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [6f20bcb152948a24dbe40ca2e6c4ecef2bebf853]

        tdf#147310 sw_redlinehide: recreate frames for whole table deleted
        
        SwUndoDelete calls MakeFrames with end being end node of the table, but
        it needs to be the following node (with a frame).
        
        (regression from commit 723728cd358693b8f4bc9d913541aa4479f2bd48)
        
        Change-Id: Id0974c8349be5aef9630822738eae9462bbcb4f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131112
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-07  Jean-Pierre Ledure  <jp@ledure.be>  [2598c35dbac8dc4492ad1fc79925c5347e683af0]

        ScriptForge - (SF_Document) new Import/ExportFilters properties
        
        The ImportFilters and ExportFilters properties
        of the Document, Calc and Writer services
        return a zero-based array (Basic) or a list (Python)
        of all filters available for the current document
        instance.
        
        These properties are NOT applicable to Base documents.
        
        ImportFilter contains the filters flagged for import
        or for Import/Export. Idem for ExportFilters.
        Both lists overlap each other partially.
        
        The filter selection is done thanks to the
        - filter type, to be compared with the Identifier of
          the document's component
        - filter flags, last 2 bits determine the import or export
          orientation
        
        The filter names are potential arguments of the OpenDocument()
        and SaveAs() methods (and alike).
        
        Both properties are callable from Basic and Python user scripts.
        
        Change-Id: I8ce5312a58a013bc7e1e68101ff9f50f3233155d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131106
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [a7e5c48b3d6d98ea35916cae9bd85a87f8ddf8e9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd0b076d8c049e1a73d98329f778e8aa698aafb3
          - Document new arguments of the L10N service
            
            Change-Id: Id187e740cc57785cecb0f92009fc754cfac06f71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130785
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [8cdfd9edce38447a3ab7660a0d534982bd9e69b1]

        cid#1500534 silence bogus Using invalid iterator
        
        Change-Id: I4885335832baaafd4468ae55bcafa2b541e26913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131105
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Luboš Luňák  <l.lunak@collabora.com>  [7df433cdc33b4d6ba38eafad9282d015571433ef]

        optimize ConfigurationProperty::get()
        
        E.g. officecfg::Office::Common::Save::ODF::DefaultVersion::get()
        gets called quite often during ODS export, taking ~14% of total CPU
        time, ~%5 in comphelper::getProcessComponentContext (handled by
        previous commit) and the rest trying to read the property.
        But it's possible to cache the final property values if there's
        a notifier that clears the cache on any configuration change (it
        can't be hidden as a static in the file like the other data
        becase that way it'd get destroyed too late and crash). This
        gets it to ~3%, most of which is spent in computing the path hash
        (which could be presumably made const if the OUString hash function
        were constexpr).
        
        Change-Id: I29f3cefc8442716403d4df8bdf253f4fe847a09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130705
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Luboš Luňák  <l.lunak@collabora.com>  [4256c764aee0777770466115a97420d9b55c23ac]

        do not pass XComponentContext to officecfg::...::get() calls
        
        It's used only for the ConfigurationWrapper singleton, so it's used
        only the first time and then ignored. It also causes calls to
        comphelper::getProcessComponentContext() for every single invocation
        despite the value not being needed, and the calls may not be cheap
        (it's ~5% CPU during ODS save because relatively frequent calls
        to officecfg::Office::Common::Save::ODF::DefaultVersion::get()).
        
        Change-Id: I02c17a1a9cb498aeef220ddd5a0bde5523cb0ffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131056
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Luboš Luňák  <l.lunak@collabora.com>  [58c6a36bfcc853ca9da81fbc2d071fa50585655b]

        optimize repeated std::vector removal (tdf#126326)
        
        Also it's enough to use just pointers to the elements, no need
        to refcount.
        
        Change-Id: I2e6a2f981d75e3dd57aefb41ba1fdbf800fed813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131107
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [2701a38cffd64853f881b3a4f81c49d64ee1549b]

        ofz: Use-of-uninitialized value
        
        Change-Id: I67063e20f5fc3c3418ee3db5c7a1f3e4a4a7121c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [e0b373227e135230bd9e678cbf9a6a56d4f3248a]

        tdf#146562 let toc default size and pos on first launch
        
        so only use resize_to_request when the user toggles the checkbutton
        
        Change-Id: Ib5fdac56da0441fae482bc9f2120d1d3ce173fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [685956b45355324f7fef1c9bfc514a4dcf58b35b]

        ofz#45314 limit to valid day/month indexes
        
        Change-Id: Ibf53fa1a0c1db3046a25367fb79da3b90f7cd924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [112592ac580108998a2cd99ae9bbf376c80c10d8]

        sw_redlinehide: more issues with SwEditWin Surrounding functions
        
        .. and SwEditWinUIObject.
        
        These need to work with TextFrameIndex.  Add some functions to
        SwCursorShell to make it possible.
        
        Change-Id: I884c4822a0e7ecf254ea09a893762e1e6d539534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131042
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [aac9bd235e65b27faf63e64bba3ecd94837381d6]

        sw_redlinehide: fix crashes in SwEditWin Surrounding functions
        
        These foolish functions write into the shell cursor!
        
        But the shell cursor's node isn't necessarily the same as before with
        merged paragraphs, so could crash with out of bounds indexes.
        
        Better use Push()/Pop().
        
        Change-Id: I4fd0e2aa915b6c5448772a2c766848607bbf5aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131041
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [6518c45dc0c2fb67500af85b97ed40466fd1d1e0]

        tdf#140077 sw_redlinehide: fix crash on SplitNode()
        
        The problem is that CutImpl() was called with nLen=0 and so returned
        without sending any hint to SwTextFrame.
        
        Then the MergedPara gets recreated, but the problem is that the
        SwParaPortion is never invalidated so it still contains the portions of
        the previous merged paragraph, and painting it will crash.
        
        But it turns out that there isn't a hint that would actually work here;
        instead, generalise a condition in SwTextNode::SplitContentNode()
        to simply throw away the portions.
        
        (regression from commit eb92dc08f2abf5ed088da0d736266f213adf00de)
        
        Change-Id: I06091ca695ea9180b32e61ddb88ce64fbf20443e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131039
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a144acfdf6a4be6654c6bdac4de954b91c577831]

        Fix some DPI-dependent tests
        
        Change-Id: I3c669802ac558379498c877c8ac4796bbff80f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131096
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-03-07  Tor Lillqvist  <tml@collabora.com>  [4618de024845573e33324539a7b455cd274a5fc3]

        Drop useless parameter
        
        The parameter to PrintFontManager::countFontconfigFonts() was only
        written to since babf6d5e53516e80e8e3f2485796ebfaeb20e9c1.
        
        Change-Id: Ie206fdbd620f1cfc6402c1d02709c3b653140c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131097
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-03-07  Miklos Vajna  <vmiklos@collabora.com>  [604bb64047a243a856ac42ea47786800901378ff]

        sw clearing breaks: fix rendering of the line break char itself
        
        The larger height is needed for the break portion, so the next line
        "jumps down", below the largest fly frame. But this has the side effect,
        that the line break character now has an unexpected vertical position,
        as it's vertically centered.
        
        Fix the problem by going back to the text height while painting.
        
        No test for this, SwBreakPortion::Paint() is a NOP unless rendering on a
        window, so the metafile-based rendering used for testing won't detect
        the difference.
        
        Change-Id: Ifd780c79488b149ff41d8e61585ee99c96a40128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131093
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-07  Michael Stahl  <michael.stahl@allotropia.de>  [03552ba854243dd05de37f471dabeb5873f5e73c]

        cid#1500542 swext: Wiki Publisher: "Insecure TLS version"
        
        Change-Id: I4b481cae6c1e13d34ea5a6dc3ff35a3b03ee281a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131005
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [08eb43d3e7f53077041d04c3021da3e244226f8f]

        ofz#45323 suppress Integer-overflow
        
        Change-Id: I22f9e2cd04d152e28cf91a4d474e46b83f85c952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131099
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [f6f665200c3ac6d046194ea25535c25d00717378]

        ofz: Null-dereference
        
        Change-Id: I11213a5ab05389b7c5020d878b0f657045693e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131094
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Luboš Luňák  <l.lunak@collabora.com>  [6adabd915d931b845fcf2fef15fbf3fca14ec9b3]

        faster check whether attributes have changed (tdf#117366)
        
        If the two item sets are equal, then trivially nothing has changed
        between them.
        
        Change-Id: Ib4c5922959603a0a28e11967a17ba4607e6a010f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131080
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Luboš Luňák  <l.lunak@collabora.com>  [6810aa937caca167a6dc1aa0ac63d5995a143b10]

        faster bulk insert into o3tl::sorted_vector (tdf#117366)
        
        Repeated insert() into o3tl::sorted_vector can turn out to be
        pathological, repeatedly moving most items aside for each
        element inserted. Make it possible to insert a normal vector
        that's been pre-sorted and made unique. 31s->9s for loading
        tdf#117366.
        
        Change-Id: If3a0366dd240ad46c23f5f3dc04e781b8c4b2aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131085
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [471c7d43a4ccdd6debd919cdf9a67f403ace110c]

        improve scope
        
        Change-Id: I69e4e47dbc17f32dacda336f31acad7fff992088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Caolán McNamara  <caolanm@redhat.com>  [c641ca15f2a898b7ec66cf39ef4517a1221bab81]

        tdf#147782 retain focus in launching frame on first activate
        
        Change-Id: I813c675ecf7c4a364f9d770af12e99275f510e7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-07  Miklos Vajna  <vmiklos@collabora.com>  [418cb3c844da2e7094fa6b63b33d8c938897203c]

        sw: prefix members of DocxAttributeOutput, SwDBTreeList, ...
        
        ... SwTOXBaseContent and SwURLFieldContent
        
        See tdf#94879 for motivation.
        
        Change-Id: I6481279dcb680ebba6392bbde3f4736dd270e52a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131092
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-07  Mike Kaganski  <mike.kaganski@collabora.com>  [66a9795f27fda887d9f66d0d8bb196fd636fe452]

        Add unit tests for searching empty substring / zero character
        
        Related to commit 713c83c0fc4a0d9950cfa0b598d7c5f4bae15755
        
            Add checks to avoid finding empty substring / zero character
        
        This activates tests in sal/qa/rtl/oustring/rtl_ustr.cxx
        
        Change-Id: Iab176e6583dc383a7a3413b0e19cc8f0d09b2824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131087
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-07  Jim Raykowski  <raykowj@gmail.com>  [99ac14c8ccf89a51de1b3fb9d14789406f2dc95f]

        tdf#140222 make InterimTearableParent docking windows not dockable
        
        and only allow dockable type docking windows to be undocked/docked
        
        Change-Id: Ia1b0ccbdd911c24f83baf1c0514954e354c9070b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129650
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-06  Regina Henschel  <rb.henschel@t-online.de>  [b4e9eb5b977e53e86abb3a6a3bb530d3a5ac7368]

        Swap light preview bmp in extrusioncontrols to correct order
        
        The order was wrong since commit dd1df645b4fe0 which moved them from
        independent entries in extrusioncontrols.src to an ordered array in
        extrusioncontrols.cxx.
        
        Change-Id: I346a40a0506d9103a33eb9f06c7017663d61949e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131086
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [4e93ba94f1969b672632319fc45db02f6558f87e]

        ofz#45255 handle short O_hhea table
        
        Change-Id: I649dfdb3eff868441125fbf62ff3c7d0d18d8d19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131084
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [e0cc2e1b775993ae559494bf373451f1cc326dfc]

        ofz#45271 suppress Integer-overflow
        
        Change-Id: I8611f340e6fde049f209627e46f8ca0e100b9b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131083
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [f9b8b666cb28f5b3947d3b4966b4479821dd441f]

        ofz#45230 avoid OOM
        
        Change-Id: Ia209809ddb7713d906fd481384dd463eba6dee57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131082
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Luboš Luňák  <l.lunak@collabora.com>  [94960bb3357bc443453e4cea2329f34cc7e80196]

        don't try to spellcheck after last data cell (tdf#122827)
        
        Change-Id: I728e7f19a521f5f3583b4963d84c7d36527c8842
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131076
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [673369abe3250ee9bbbb1a3f724084ecd070f752]

        ofz#45237 suppress Integer-overflow
        
        Change-Id: I44496ae9428a75a6a08633e5ec31a754522ef1d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [2e6a7db11b8cfbf326789600393549e9c01d24cd]

        ofz: Too many hatch points
        
        Change-Id: I08cb9d09a9bb48ab31763f50bc2fa23cf723330f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [434d852762eafe7230299ea6110096b9ac8bb98d]

        ofz#45276 uncaught exception
        
        Change-Id: I5863d6474aa47f24b24a15481c8329a5e587a8d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131078
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [c207e2c7a3a49bc46488056d0d106517781c3ef4]

        ofz#45286 Integer-overflow
        
        Change-Id: I1fb3aa68fb4e2ad274053f30d04f20ea479e1f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [be364e3c211b74899b9e0007ce22e8ef659d003d]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I1f1771c384e88417f40ea9dd76378fb057e3d977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131075
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [08bbd27e1cb6106e48489b2ca787201ca88da74a]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I41554dec3819efcd8e28f82bb732141c85414e9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [1c722a1fc02a76c9e503d36d66598aa5ca4dc2e1]

        cid#1502882 silence Unchecked dynamic_cast
        
        Change-Id: I30c2edd4df8175b9c5bbda91f6046d631193245d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131073
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Noel Grandin  <noelgrandin@gmail.com>  [9dee54299cb5c6877f68b061c47bb907df90ddcc]

        clear UserCall in SdPage destructor
        
        because I want to ref-count SdrObject, which changes the lifecycles
        of these objects, and then if an SdPage dies before an SdrObject
        we have a dangling m_pUserCall pointer.
        
        Change-Id: Ia08178c1b2f288f6d9d489fb9fd79e67bc3ea61c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131065
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-06  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [82f9e12b737b3dbdf8cb9175c94d61005b666725]

        Fix tdf#147755 by copying the vector.
        
        Revert partially 224953d896a3dba5d85992394525ab8b54d8c314
        
        Change-Id: Ic12d3b0a080ad3af69fa5c4e8c9b4d331305a663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [ffa0dedf93d913536488bc1718f855e6ff48284b]

        crashtesting: assert that !rtl::isAscii in xmlError message
        
        probably detected since:
        
        commit 089ce740f9f97f9c7b13e37a31acfc94984e9a3e
        Date:   Thu Feb 24 17:45:18 2022 +0300
        
            Deduplicate rtl_*String_newConcat*L
        
        or similar
        
        Change-Id: I69ac57bd5718a4da85516e2a2afa79dc2b04665e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-06  Luboš Luňák  <l.lunak@collabora.com>  [06bd8d70ea06679c992f110c7a29fe045733e306]

        make CellTextAttr half the size
        
        It's set for every cell with value.
        
        Change-Id: Ie46617a621e6eb16b5f67d92e85bf2155e650fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131072
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-06  Luboš Luňák  <l.lunak@collabora.com>  [35fad780879f0909187c7fa3cb3345814bdceb8c]

        make a bunch of SvtBroadcaster/SvtListeners functions inline
        
        These classes are used extensively during some operations in Calc,
        and not even LTO can inline these when they end up in different
        binaries.
        
        Change-Id: I5b17a004c6cc039508b76d557d58714c83f237a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131071
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-06  Caolán McNamara  <caolanm@redhat.com>  [143de4b1a9d6c45dce55c6c40061643c965492c6]

        os thrown -> is thrown
        
        Change-Id: I114bb29c59ad9a4b20ca3f34b057b02d439fbd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131067
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-06  Justin Luth  <justin_luth@sil.org>  [05502f78ed0d406ff50d43a39c05f7bb990001e9]

        link bug report to "likely wrong" comment
        
        Change-Id: I3184037d3df79b1bf4c972046e7636b372662cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129825
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-03-06  Luboš Luňák  <l.lunak@collabora.com>  [52f24a3a1e2ff7f0a599df7bb9caefc8543f7dc4]

        don't destroy and recreate broadcasters on large changes (tdf#131894)
        
        Change-Id: If5377687e7bcfab00af37887d3aaf302fa615690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131070
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-06  Luboš Luňák  <l.lunak@collabora.com>  [648a4b30b33569052847b797c38e52ba2fd2d500]

        do not destroy broadcasters and then recreate again (tdf#134268)
        
        Sorting ends tells all listeners on all the sorted cells to end
        listening to stop updates, then sorts the cells and starts
        listening again. This will cause all broadcasters for the sorted
        cells to temporarily stop having any listeners, so they'll be
        deleted and removed from the mdds vector (which may additionally
        cause moving large parts of the mdds vector repeatedly). And
        since all listeners will want to listen again after the sort,
        this will all need to be reconstructed. To avoid this,
        temporarily block this removal and then later just checks
        and remove any possibly left-over broadcasters that ended up
        with no listeners.
        
        Change-Id: Ie2d41d9acd7b657cf31a445870ce7f18d28d5ebb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131069
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [7ac19fbce8a35f559eebb879cd0f232bfc95e703]

        remove a workaround that appears to be no longer necessary
        
        Presumably whatever the locking problem was, it's got fixed
        meanwhile.
        
        Change-Id: I7bbd6299a501396f53ed2e8ccaf7d5893744512b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131047
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [94e8b4b6a5ca957e1426f47cda898f175932183c]

        ofz#45167 Integer-overflow
        
        Change-Id: Ib112686b192558421419a8695db9c3f35c5312da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [8030b9cf1c55cbbf9be8bf0cee0a408ff0a14710]

        compress RowHidden()/GetRowHeight() use in excel export (tdf#126326)
        
        Change-Id: Idc6a704cfc820bbbb2b51eff8db8159c251ea9ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131062
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [713c83c0fc4a0d9950cfa0b598d7c5f4bae15755]

        Add checks to avoid finding empty substring / zero character
        
        ... which changed in commit 281989007fd7dea997ed9a65f513f80b1aff67dd
        
          Author Noel Grandin <noel@peralex.com>
          Date   Tue Jul 01 13:17:01 2014 +0200
        
            Use standard library optimised routines for OUString/OString
        
        for optimized cases: strchr/wcschr/strrchr/wcsrchr find trailing zero
        character, and strstr/wcsstr find empty string; previous/unoptimized
        code does not find these. This introduced inconsistency between char
        and sal_Unicode functions on non-Windows, and for sal_Unicode between
        Windows and non-Windows (because on Windows, optimized code is used
        for sal_Unicode, while on other platforms, unoptimized code is used).
        
        Change-Id: I68529c91b26f4113d9bd7777fc5ac4809349864b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131064
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [805e73b555df277e7fb35825a0c48d244a2691a9]

        don't bother tracking changes if both cells are empty (tdf#141174)
        
        AppendContent() does something only if the cells differ, which can't
        be the case if they're both empty, so skip unallocated cells.
        
        Change-Id: I367801bac30a8ee641b4ce608392124bac6ef47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131060
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [be99b23809687ca1143c8fe8d4ec3cfe6703c363]

        don't bother scanning nonexistent data (tdf#141182)
        
        There's no point scanning for non-empty cells after the last data
        cell, and this avoids processing mdds structures (such as repeated
        creating of flat_segment_tree).
        
        Change-Id: Ibec324aa2de457e8439c38a561f55ced9f478899
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131059
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Julien Nabet  <serval2412@yahoo.fr>  [eed83764088bfdfcc6513778f7dc83d649f550a3]

        tdf#136632: Use 'Save transparency' when exporting selected objects for PNG
        
        To avoid some regression, consider that transparency should be enabled by default.
        So only remove transparency if it's required explicitely.
        
        + change QA test since "Translucent" property isn't a bool but a sal_Int32
        In officecfg/registry/schema/org/openoffice/Office/Common.xcs:
        <prop oor:name="Translucent" oor:type="xs:int" oor:nillable="false">
        
        Change-Id: I9bfb6aae8e2e8a31dee82f73a9165989129f222a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131057
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-05  Noel Grandin  <noelgrandin@gmail.com>  [492098417a590521506e41c05d3ab0f09628d39a]

        GetComponentServiceName can be const
        
        Change-Id: Iac61eec0b27660dd2ff45f70c92de5a8cdc2c301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [eaeb8b56a4e450917001919be0848bad115293a1]

        ofz#45231 Timeout
        
        Change-Id: Id761d0aeaffe869c7ce3ea048bdee09b55ae60a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131055
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [80d99a387fa0d5b8764dab720c20e2d3754e610b]

        ofz: Use-of-uninitialized-value
        
        Change-Id: If75e11dc26aae51d658dddd464135dd8a4f965ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131054
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [2fbf7dadf6255b7072c5a8bb7c6c071a22b726ea]

        add svm playback to local testing
        
        Change-Id: Ie69f628ee3f37b5cdab206c0c1c201a94841bf03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131053
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [c53570e524cff058d893ea950ce1e538ba925b5e]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I695b5721ec848845adff0a5c37b931b4cee5370d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131050
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [19c631692bcdb21d9d5324c63431a8bdfca5a72d]

        ofz#45233 need some more services to play back metafile
        
        Change-Id: Iafda9d9ad919a4a1a80131962c50a4a24b4b9b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131049
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Caolán McNamara  <caolanm@redhat.com>  [9cec15391b7dd9556a6fb78875ad7b3421b93ab1]

        ofz: record less than 10 bytes is invalid
        
        Change-Id: Ie6b88efbc12b4c7fddb7459e50cba28fcbcf35fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131048
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23257525df31a57bbf1a8935001ded2842a18b13]

        Fix typos
        
        Change-Id: I87f35153bbf53f58d6c8ca7b14a7fd09fec4372f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131052
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-05  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9d25f86236885c40662bcd24517f231688361e8c]

        tdf#38669 - Create the key event using a Unicode character
        
        Instead of using a plain char, create a key event using a Unicode
        character, otherwise the key event creates texts including rectangles or
        wrong characters.
        
        Change-Id: I9ec0d64998927d54eb3ae90a192c3b28e235f56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130721
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-03-05  Noel Grandin  <noelgrandin@gmail.com>  [34e347db726a415f3f6df0c1f2112aff6d67bdeb]

        AccessibleShape::GetStyle can be const
        
        Change-Id: Ic71ae0645c85ec27cc6a172d379070fe88a9f452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-05  Noel Grandin  <noelgrandin@gmail.com>  [6f652725fcbb068b8b482a74ef021396d4d0f133]

        make some svx methods const
        
        Change-Id: If04a160c46b8dbf641ca9d115d1560f17e87ce4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [0d2b5efdea72ba640169ba7dc9e6c1b87be1d68b]

        make sc_namedrangesobj test work with 16k columns
        
        'row1' is not a valid named range with 16k columns, it's a cell
        address. Since the named range is constructed by the test,
        not even 582fc887f1faafe8ff5f16a13a0208483a93353f can take
        care of it, so rename such ranges.
        
        Change-Id: I6643953d41e391c8c3cfc55768b06d61d9fcb0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131046
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  pragat-pandya  <pragat.pandya@gmail.com>  [6f121860d0537060084278da11842732a748d6b7]

        tdf#130924 replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: Iaef5eec6508d031ab711a71c0d8ecebb18112ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130764
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [31e0ada711a008d7841a2da243ce50bc49c6c857]

        remove more hardcoded sheet sizes from Calc tests
        
        E.g. sctablesheetobj test had the limits hardcoded, even as actual
        numbers. Apparently some tests cannot easily access global
        settings, but this at least makes it easy to check all tests
        after modifying ScSheetLimits::CreateDefault().
        
        Change-Id: I6cff577fb01b1ea262dcd1f9fde24e114e19abdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131040
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [16b4525e8770ca457c8b33f08c5f9ef5f35ef62e]

        remove more hardcoded MAXROW
        
        Change-Id: Ica57f18d3fd1bf9ec06f05869f4a956d7d1097b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131036
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [2e2e30d7ae445509e39ba47c1b248079f28c8d95]

        remove pAttrArray nullptr checks
        
        I don't see how it possibly could be nullptr in a correct situation,
        ScColumn::Init() is called right after creating ScColumn.
        Also make a bunch of trivial forwarding functions inline.
        
        Change-Id: I710d3cd86a660a8b4dcfbb9966a685b657b93c18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131035
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Luboš Luňák  <l.lunak@collabora.com>  [17bcf1073bf21088b9845e36fe735622d8f88fd7]

        introduce ScColumnData for ScColumn/ScTable code sharing
        
        Since columns are allocated dynamically on demand, up until
        this commit ScTable had ScPatternAttr member for unallocated
        columns that it was using in place of those unallocated columns.
        But that meant either copy&pasting pieces of code from ScColumn,
        or having extra slightly more cumbersome shared function
        in ScColumn, or even nothing.
        
        Improve this by creating ScColumnData, which will be used as
        ScColumn base class to keep things working as before, but
        ScTable now also contains one ScColumnData instance and
        so it can also call its functions.
        
        Change-Id: If1d842c4a5aec32e2a7729358006d79cd831349f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131034
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [e001a86393e363261617d2521b516287561905d4]

        Use rtl::isAsciiDigit instead of custom macro
        
        Change-Id: Iabca31825dd47cee661b47b14f09e96459a42015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131033
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-05  Mike Kaganski  <mike.kaganski@collabora.com>  [2c82ed241648dadd8326f0847479a4959385a6f1]

        Convert some macros to local lambdas
        
        Change-Id: I22942588c7e7ebfb3f53cc5739d2bbd9a7ccfd41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130983
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [c695c60be9fb7028b3176869400be2b11c6268ec]

        ofz: Null-dereference
        
        Change-Id: I01be4c06c6d97430953ada8f3f5f84ef0a389267
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131032
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [d3e0159a3e510f1d3202d1c7d3d652be9152a314]

        ofz: Null-dereference
        
        Change-Id: I7d8e30dc85df3cc5800617e5b2f232136bb72cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131006
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [bc9b5c830fe4d424148f9991f416442c51e6e4fd]

        cid#1500511 silence Resource leak
        
        Change-Id: I37cdd52d965112598249b929fa49c759a88606c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131002
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [f3226c540d45deefb08b30170fc8b2511742711c]

        cid#1500524 Dereference after null check
        
        Change-Id: Ic76f1b4992f51bdfe10406734ce00135607db357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131001
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [5541b7b1dd0d683a7018f7499aec4dbe6626a25a]

        cid#1500546 silence Explicit null dereferenced
        
        Change-Id: I44b97965548bd84adf6dc3ec1c67f028a4b31075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131000
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [b35571c348eb8816098f7c8786d8cc8ff9082f19]

        cid#1500566 Uninitialized scalar field
        
        Change-Id: I63e81377227ab35a0697a1d90fb3c9302a12a2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130999
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [9007ca10a3f2e11fabcd7bed74cf28da2920ce2f]

        cid#1500569 (likely) silence Explicit null dereferenced
        
        Change-Id: Ib44b3dcb94998ce7bf28c9dc1cd3ca7acc6e5190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [4ffb36265312f18e4c382fc6ff8940c5cdf268ca]

        cid#1500632 Using a moved object
        
        Change-Id: I5e7dd51c9f9b2b295ded161307bbe9a6a23c42de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130997
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [9ad752830f42dfc38f91eb2353b49650a3a48d0a]

        cid#1500637 Explicit null dereferenced
        
        Change-Id: I813703287faff25a48aa695ccb9c43bf469354d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130996
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [80c0625995585a43f8dd4cbc7404df47f62dfae9]

        cid#1500652 silence Explicit null dereferenced
        
        Change-Id: Ifb96f7cf3d28b3bef70c8d920d8c926c76329fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130995
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [6b566ed9a32c5c0eb3bde7512733c0c11a479ecd]

        cid#1500666 Explicit null dereferenced
        
        Change-Id: Id4283660feb95432995872b82e71c3331349f837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130994
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [9c526b557e264280cb0c9da704245494f5ec5af3]

        Advanced Diagram support: Allow reLayout without keeping oox::Shape
        
        Goal is to minimize dependencies on oox classes. For that pupose
        I redesigned the Diagram class to work without remembering
        an oox::Shape at all. For reLayout, a new temporary one is created
        and used. That was a bit tricky, I needed to find out what
        data at the oox::Shape is needed to sucessfully do that with
        the not-originally-imported one.
        
        Another necessary change was to move the DiagramFontHeights
        adapting mechanism away from oox::Shape, too. It fits better
        to Diagram class. That way it can also be used for reLayout
        and the oox::Shape gets a little bit smaller, too.
        
        This opens the path to move needed Mode-Data Diagam core
        claasses to other libs where changing/im/exPorting them will
        be possible.
        
        Change-Id: I40bc4b190d2abc797f5c56f9e476d22155d21422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131004
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [35428625b70829ba56da99fafe205b24b0018ace]

        Restore damaged comments
        
        They were broken in commit d1af3a5fc102f9bb3464541d83ef0fa4bb2ce2a1
        
          Author Vladimir Glazounov <vg@openoffice.org>
          Date   Wed Jun 04 09:02:42 2008 +0000
        
            INTEGRATION: CWS sw30bf04 (1.4.2); FILE MERGED
        
        It changed the original EUC-KR file encoding to ASCII.
        
        Change-Id: I423b6e7dac0a47ad7688175780f062ecaefb9101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131027
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [3dfd6657db5e4a1706004c006ebf6c40b23830f9]

        Turn conversion macros to proper functions
        
        Change-Id: I463dff95d81e497bafacb60268288bf7526fb3d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130979
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [823fe1cb509e80f36744ff948d506ec9eeffb752]

        Avoid some sprintf used with colors
        
        Also addresses possible buffer overflow because of possible
        color channel values greater than 255 (found by a fuzzer;
        likely by some unexpected value of shade exceeding 100; see
        https://gerrit.libreoffice.org/c/core/+/130956/3/hwpfilter/source/hcode.cxx#1292)
        
        Change-Id: I168685c3b51cbc8c9f664282bc9378b3c6669ba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131003
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Julien Nabet  <serval2412@yahoo.fr>  [ef0e15aaefad8347fc4a3c71771de07e370eda2f]

        Remove useless comment on a commented line since always (sal/w32/file_dirvol)
        
        git history gives:
        commit b76cb86eaa0aec1d02c5ff29c5a43e1e7a675b27
        Author: Oliver Bolte <obo@openoffice.org>
        Date:   Wed Sep 9 09:38:41 2009 +0000
        
            CWS-TOOLING: integrate CWS mhu20
        
        where it was already commented and from sal/osl/w32/file.cxx
        
        then digging a bit more gives:
        commit 73cd79644d4355de483b0d0c04fba034ac02795b
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Mon Oct 17 13:52:03 2005 +0000
        
            INTEGRATION: CWS perform05 (1.5.52); FILE MERGED
        
        where it's also already commented.
        
        => No need to keep this
        
        Change-Id: I3e8892e8c8f4e76d2e05a8bd158e77418a12eb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131030
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-04  Julien Nabet  <serval2412@yahoo.fr>  [b96435215a611e3a807c1fd4f365e84bd1b2ba22]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e228842ec7a29bd45b295f88acd65b86a98b1b3
          - Typo in accesibilitycheck
            
            Change-Id: I3653d1181c954af1224ff810201ac58329293234
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131009
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-03-04  Julien Nabet  <serval2412@yahoo.fr>  [d17b8d260f1a289140bf6fa25a7ca80a4db1b199]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01958f0b3eb4b87adbfa1f4504180182dd3d5935
          - Fix typo acessibilitycheckheading
            
            Change-Id: Id268a158bbb1e089387cb702d42ffae04e89bfcf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131008
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6a858e97bf595e2535daab8f7a3d8c9c64611c2a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eacc07e423211c32935013e8862d546838746c6d
          - Typo in bookmark/hid
            
            Change-Id: If07b640c888cac960116c7587f81889b5b33982b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131037
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-04  Luboš Luňák  <l.lunak@collabora.com>  [582fc887f1faafe8ff5f16a13a0208483a93353f]

        keep conflicting named ranges working with 16k columns
        
        Named ranges named e.g. 'num1' are actually valid cell addresses
        when using 16k columns. We prevent naming ranges in a way that would
        make them conflict, but it's possible to read them from a saved
        file that was created with fewer columns, and in such cases formulas
        using them would silently refer to those cells instead of to
        the named range. I don't see anything in the ODF spec, but OOXML
        in 18.2.5 recommends this in case there are conflicts (only outside
        of the normal Excel range of A1-XFD1048576, inside they are always
        meant to be references, but our normal range currently is only 1k
        columns, and it's simpler and probably harmless to always resolve
        a conflict this way). I can optimize performance of this in another
        commit if needed.
        
        Change-Id: I46aef54b069700e7bf268b50fdc1a88989f3ee29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130891
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [83e1d079c4304ed43dfe8f9c92490d1bd4963f4c]

        cid#1500667 Explicit null dereferenced
        
        I can't see how destroyingthe widget is a good idea here
        
        Change-Id: Ie4b2dcf9136568b01b5f4b85bcc849ad1c0504a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130992
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [ac2c0cb0ccb7e8978ec64059901e4b2aa44f239f]

        just make copy of string, not create a new one and then concat to it
        
        Change-Id: I559744b4a92c1ab222e2a80ea44042ba5c3d48a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130993
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9868ac008e1a5e8f769b5d2cdf8078b83cc38ce5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5573c118ebe4b2b5328b328170c21bf77cc9f2e8
          - Update prism.js used in the Help
            
            version 1.2.7
            
            Change-Id: Ibec037314046a2f17a9c6c2b9c67d9353c761319
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131028
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [0d9f46a1f4927831017fdbd63f3090f428e83ef1]

        cid#1502851 Uninitialized scalar variable
        
        Change-Id: I5d44106e1865c5c498d280d29f5f58115b4588a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130986
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [e403e4c0d42ff1a8dd26241d5a8ee722d59130fc]

        cid#1500743 Unchecked dynamic_cast
        
        Change-Id: I5a384ee3dae657d23bbba46c0dd19e6a71c752b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130987
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Stephan Bergmann  <sbergman@redhat.com>  [931996e61be61246f5d0c84f0c6caf314d3ef79f]

        Avoid "ThreadSanitizer: unlock of an unlocked mutex"
        
        ...in (somewhat contorted) test code
        
        Change-Id: I247a30e580b3d458eb748a833100a662c9890d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130991
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [9013ee1a00502b891637fe050f1c133b36d6d151]

        cid#1500701 silence Dereference after null check
        
        Change-Id: Iccd159c81011863cd664a2903dd14006bdc3b8a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130988
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [8b4c152a93d75658a2209089a4058daf5f7a5ff2]

        cid#1500690 Explicit null dereferenced
        
        this may stem from:
        commit fcc31cd0e0a6544a13dac0fdc66005d77f6f5cf9
        Date:   Fri Sep 7 18:41:58 2018 +0200
            Revert "clang-tidy performance-move-const-arg"
        
            This reverts commit 3d604d1cd6cc70ef96782ef769f0479b509987a8.
        which didn't 100% revert 3d604d1cd6cc70ef96782ef769f0479b509987a8
        
        so we went from:
        
        LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pMasterPersistPtr)
        : SlideFragmentHandler( rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout )
        
        to
        
        LayoutFragmentHandler::LayoutFragmentHandler(XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pMasterPersistPtr)
        : SlideFragmentHandler(rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout)
        
        Change-Id: I90cb437c467f88c75d248ed138d078bf56705a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130989
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-03-04  Jens Carl  <j.carl43@gmx.de>  [89aec8620034d9cbaa44275282fb3c56e8b3935e]

        tdf#45904: Remove ScHeaderFieldObj Java test
        
        The ScHeaderFieldObj Java tests are implemented in
        ScEditFieldObj_Header.
        
        Change-Id: I45d3b17bd244090c491c85475f20bc06eb92908f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130953
        Tested-by: Jenkins
        Reviewed-by: Jens Carl <j.carl43@gmx.de>

2022-03-04  Stephan Bergmann  <sbergman@redhat.com>  [4a804f87eba3a0e4cc8777a1e76d5f1fb06037c6]

        external/python3: Avoid "ThreadSanitizer: destroy of a locked mutex"
        
        ..when building ExternalProject_python3 with Clang -fsanitize=thread,
        
        > WARNING: ThreadSanitizer: destroy of a locked mutex (pid=973799)
        >  #0 in AnnotateRWLockDestroy at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interface_ann.cpp:184:3 (workdir/UnpackedTarball/python3/python +0x498460)
        >  #1 in recreate_gil at workdir/UnpackedTarball/python3/Python/ceval_gil.h:138:5 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0xe84aa9)
        >  #2 in _PyEval_ReInitThreads at workdir/UnpackedTarball/python3/Python/ceval.c:350:5 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0xe847c7)
        >  #3 in PyOS_AfterFork_Child at workdir/UnpackedTarball/python3/./Modules/posixmodule.c:469:5 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x1163dbd)
        >  #4 in os_fork_impl at workdir/UnpackedTarball/python3/./Modules/posixmodule.c:6253:9 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x11adcad)
        >  #5 in os_fork at workdir/UnpackedTarball/python3/./Modules/clinic/posixmodule.c.h:2750:12 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x117b481)
        >  #6 in cfunction_vectorcall_NOARGS at workdir/UnpackedTarball/python3/Objects/methodobject.c:463:24 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x9db7e1)
        >  #7 in _PyObject_Vectorcall at workdir/UnpackedTarball/python3/./Include/cpython/abstract.h:127:11 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0xf0225e)
        >  #8 in call_function at workdir/UnpackedTarball/python3/Python/ceval.c:4963:13 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0xef3f4a)
        >  #9 in _PyEval_EvalFrameDefault at workdir/UnpackedTarball/python3/Python/ceval.c:3469:23 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0xedc5d8)
        [...]
        >  #143 in pymain_run_python at workdir/UnpackedTarball/python3/Modules/main.c:610:21 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x1149f6c)
        >  #144 in Py_RunMain at workdir/UnpackedTarball/python3/Modules/main.c:689:5 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x11495e9)
        >  #145 in pymain_main at workdir/UnpackedTarball/python3/Modules/main.c:719:12 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x114a299)
        >  #146 in Py_BytesMain at workdir/UnpackedTarball/python3/Modules/main.c:743:12 (workdir/UnpackedTarball/python3/libpython3.8d.so.1.0 +0x114a30d)
        >  #147 in main at workdir/UnpackedTarball/python3/./Programs/python.c:16:12 (workdir/UnpackedTarball/python3/python +0x4d00f8)
        
        Assuming that the GIL is always locked before the fork, better tell TSan about a
        fake RELEASED before telling it about a fake DESTROY, to keep TSan's model
        consistent.
        
        Change-Id: I6c68d7e415aa0ffc3047e5a5c4c4aca6b0cce8cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130985
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-04  Kunal Pawar  <hellokunalpawar@gmail.com>  [92e835dbf00590c9c29509d2995cc7918a9bbb90]

        tdf#98705 Replace GetCaseCorrectPathName with GetLongPathNameW
        
        Change-Id: I1d03267cd67da4c155248b585ca59dc5191d28f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130144
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Luboš Luňák  <l.lunak@collabora.com>  [3db91487e57277f75d64d95d06d4ddcc29f1c4e0]

        set properly attributes for cells in unallocated Calc columns
        
        ScTable::ApplySelectionCache() was setting attributes only for
        allocated columns, so e.g. selecting a whole column and making it
        bold didn't actually set all of it bold. Make sure it set it
        for all columns, and make use of the default attribute for
        unallocated columns to avoid allocating columns just to set
        them the same attribute.
        
        Change-Id: Ie9886317d7a91c6a43951af69b717f9ba32a1c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130984
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [4015c18130ced8dcfdfaec99b11cd914beec0449]

        clamp and add some logging like SvmReader
        
        Change-Id: I8f744e1ab2684a0f0995abcc3e753a684a3b970a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130971
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [626e05a221909bcb068b5ef6af8be9356ce6d640]

        Fix typos
        
        Change-Id: I4b26b105e4c16b1860389deb7a629ff139bd260c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130976
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9bc38822a5458774c16f2698c0e2fcde5c6c34a7]

        Removed executable bits on rtf files
        
        Change-Id: I4b12bd5d399efa037bb84699572c8c9bfb07e459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130977
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-03-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ead26a871f240190be99b2f91f1bc22fac727f6f]

        Removed duplicated include
        
        Change-Id: I9c62e12f3b0f88ead3dbd2cdc69b7462cbbe294b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130978
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-03-04  Heiko Tietze  <tietze.heiko@gmail.com>  [b82b38bbc896bc4e19171cb8950cbd0e95d2c23f]

        Relates tdf#146929 - Remember user input for the compress dialog
        
        Missing ctor added
        
        Change-Id: Ifb71d6a0653d090e0fc46746d35c70cc8df43e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130928
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-04  Szymon Kłos  <szymon.klos@collabora.com>  [85a5b1d92ebb4d66c9ed683df99dc8b37c0f02a5]

        lok: fix goto functionality in Accessibility Check dialog
        
        Change-Id: Ie9ce42ccdb5cf6c72df3d3d48d3e7369f9e2f9cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130830
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130952
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-04  Miklos Vajna  <vmiklos@collabora.com>  [9df80f6e41b0e69fce2afc6647adb78b0dd1df44]

        sw clearing breaks: initial layout support
        
        - add a SwTextFly::GetMaxBottom() to know which fly frame has the
          largest bottom position from the current paragraph
        
        - add a SwBreakPortion::m_eClear to track if the break portion is a
          clearing break
        
        - consider height of breaking clear portions in SwLineLayout::CalcLine()
        
        - increase the break portion height in SwBreakPortion::Format() if this
          is a clearing break and we have a fly frame that has a large enough
          bottom position, so the next line can "jump down", below the fly frame
          (so the line can be full width, which is the whole point of a clearing
          break)
        
        Change-Id: Ia21984b9cf9d04287cc19f98495c5b44b880020a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130961
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [fc3d76819f2770bef596fcddf6b24df8e1966ece]

        clamp in StretchTextHandler like TextHandler
        
        Change-Id: I4e1247ef2945f46cd1e60e9e473c1a589f990bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130975
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [f30bc3ccdfb48356910d64ee4a3dda685b11de93]

        use internal SHA256Thumbprint api
        
        Change-Id: I6a51359af58dbb79b6a0399944030dbcbe97152b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130963
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [272c161cf24a7bab4920a05cd64f0194a91d148c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ba883f0c4bb56c10bbf2d0a675daa27c5cae7cfc
          - Document SheetName property of the Calc service
            
            Change-Id: I46411a2917c79059cda08212ded17c517fa49537
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130786
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [15a428765b543af8771f2922ec1715e65e9a780c]

        Drop commented out wrong tests
        
        Change-Id: Ief086996f94978d2ffd6879a6c3e5b0b2312dffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130962
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  zhutyra  <zhutyra>  [ab4bae2265f6f5ee52baf8db106c77eefd0bd159]

        the assumption is that aArray.size() matches the Length argument
        
        LIBREOFFICE-OWMTGGWJ
        
        Change-Id: I68dfcb0dcbb401c62d4e29f9ab6e4ee1ebc7f072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130973
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  zhutyra  <zhutyra>  [b279061b97e53b0730bdd463b3287c82075f1538]

        clamp svm1 text ranges to legal range on conversion
        
        LIBREOFFICE-OWMTGGWJ
        
        Change-Id: Ief2770fd8dc48be9f1f102b709a1c3be0165b195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130970
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [0253b5106d597690ef55fbce56065a39b27bc5e5]

        Convert rstartEl/rendEl/rchars macros to proper methods
        
        Change-Id: I0cdb7d0047e153b4eb6f6a1fc0bb09c116366b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130959
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [3367ac3093acca7d220502d0fca97678cfd62a23]

        Expand padd macro
        
        Change-Id: Ic3a5bbb872ae36151aed5c108f7694cb4a12495e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130958
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Szymon Kłos  <szymon.klos@collabora.com>  [b350a9a3f36282be41a2fb8ea9016f4ccfd4128d]

        jsdialog: enable Accessibility Check dialog
        
        - fix crash due to wrong type for label
        - deduplicate widgets with the same id in one dialog/builder
        - refresh on box reordering
        
        Change-Id: I6993552342a3f139de40c3f87243bdf4e0617fc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130797
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130951
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a8b43900d60c8bb060a3c04b4beb9f3619e1aeca]

        Expand ascii macro
        
        Change-Id: Ief7ce8c5477c0904cf1f9796913aa02d30ffce3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130957
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a400cdb4555d32e9648dae32c01296a075843bd1]

        Change hcolor2str to return OUString
        
        Change-Id: I9d2a34a2cc20df20453aa048c32f619a8e17ae72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130956
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [ae6591d8dc2c1a705a1cc4cb102ff1d8cbe9d311]

        Drop hconv and replace hstr2ucsstr with hstr2OUString
        
        Change-Id: I0c336003aa3d2d55ada13e79746b6eaa5363077c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130955
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [9f33c20dff4c2d86e1befd176c9ef8ec498a7f47]

        Drop Double2Str
        
        Change-Id: I8b8c415347fd2409c55fdd6707b4f280b7881eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130954
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [7e3e4d5058e34746b7b111312b9482323bbe0e1f]

        test more with svmfuzzer
        
        Change-Id: I4b43b2101e6f4defc90db2daa3fcd5f1d986c456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130960
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [596e4970c1475346f5fb19052db4fc2e565d84fa]

        Drop Int2Str
        
        Change-Id: I6e59e285c8148b381fc7670939ddf8d335f6b528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130949
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Caolán McNamara  <caolanm@redhat.com>  [65442205b5b274ad309308162f150f8d41648f72]

        compare authors using Thumbprint
        
        Change-Id: I338f58eb07cbf0a3d13a7dafdaddac09252a8546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130929
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [176a9dfcce7c10d1c5fd3e091f10a1d57d309b24]

        Use comphelper::Base64 in hwpfilter
        
        Change-Id: Id5c0a3d33ccda517473c8cbf96cb6e7b86ade57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130945
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Luboš Luňák  <l.lunak@collabora.com>  [fbb0b0a203f19d7a4dc64c47abd6d4b1d8c17340]

        provide MAXCOL/MAXROW also as strings
        
        Primarily for use in tests.
        
        Change-Id: Icb962cbdfa63a3b50115314e9afd46f3fa1a928a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130939
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-04  Miklos Vajna  <vmiklos@collabora.com>  [556689c485c2df35abd6a0cdff76329178af17bf]

        sw layout xml dump: improve handling of number portions at the start
        
        It's quite tricky to visit each portion exactly once. The "table" of
        portions is an SwParaPortion, a row is an SwLineLayout, which contains
        SwLinePortion instances. But SwLineLayout inherits from SwTextPortion
        (which is a LinePortion), so depending on if e.g. the paragraph starts
        with a numbering portion (not a text portion) or with plain text (is a
        text portion), the first portion in a line is the line layout itself or
        not.
        
        The old behavior was to explicitly dump the first portion of the line as
        an SwLinePortion, but this way e.g. the expand string of leading number
        portions were not visible.
        
        Change this to moving all the loops to SwFrame::dumpAsXml(), and then
        not recursing in para portions / line layouts, this allows reaching e.g.
        SwFieldPortion::dumpAsXml() for leading number portions.
        
        Change-Id: I813fdece0e4d6b7116112e15ec866046862beeeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130941
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [fbe4d77d961975bafe8ea3e419651df4d418f92b]

        tdf#147742 a11y: AccessibleGridControlBase: get accessible desc on demand
        
        Previously, the accessible description was retrieved
        in the `AccessibleGridControlBase` ctor and stored
        in a class member. Change that to fetch the
        description on demand.
        
        `TableControl::GetAccessibleObjectDescription` is used
        to get the description, which currently uses the row and
        column index of the currently active cell.
        
        When using the macro from the sample document in tdf#147742
        with the Orca screen reader active, no cell was active
        at the point that the ctor was called, so
        `ROW_INVALID`/`COL_INVALID` were used, resulting
        in a crash later (s. backtrace in tdf#147742).
        
        If necessary, `TableControl::GetAccessibleObjectDescription`
        could be extended to allow passing an explicit row/column index,
        as is the case for `TableControl::GetAccessibleName`, then
        override `AccessibleGridControlBase::getAccessibleDescription`
        in `AccessibleGridControlCell`, similar to how it is done
        for the accessible name in
        Change-Id I87eabb2ce3c99d4a622d919ab0fb8d7fb3beed6b
        ("tdf#147742 a11y: AccessibleGridControl...: get accessible name on
        demand").
        
        Change-Id: I58f3a2b0c83e2cdbae103811505d7d0a4f8bfc52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130934
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [83419f869c33d550a61d260b1b3aef6a00cefc45]

        tdf#147742 a11y: AccessibleGridControl...: get accessible name on demand
        
        Base class `AccessibleGridControlBase` was retrieving
        an accessible name and storing it in class member 'm_aName'.
        
        For the classes representing cells, derived from
        `AccessibleGridControlCell`, the index is needed
        to get a meaningful name, so the name retrieved in
        the `AccessibleGridControlBase` ctor with hard-coded
        row/column indices of 0 was replaced again in
        the `AccessibleGridControlCell` ctor.
        
        Replace that logic to just retrieve the name
        on demand, and override
        'getAccessibleName' in `AccessibleGridControlCell`
        using the logic used in its ctor previously.
        
        (No functional change intended here, but a
        somewhat similar handling for the accessible
        description was causing a crash when the Orca screen
        reader was active. This will be handled in a following
        commit.)
        
        Change-Id: I87eabb2ce3c99d4a622d919ab0fb8d7fb3beed6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130933
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [a9c57e6ac6bc46ad78b66409a964f5b717878931]

        tdf#147742 a11y: AccessibleGridControlTable needs SolarMutex
        
        ... in `AccessibleGridControlTable::getAccessibleIndexInParent`,
        just like in the implementation of the other a11y UNO API methods.
        
        Change-Id: I4ab7a2626db09398c79fe53d85c9802136decbf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130925
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [1ccb6dc5bd2aa67f151d590b1aad20cecefaa28c]

        tdf#147742 a11y: AccessibleGridControlHeader needs SolarMutex
        
        ... in `AccessibleGridControlHeader::getAccessibleIndexInParent`,
        just like in the implementation of the other a11y UNO API methods.
        
        Change-Id: Ib3bd44e73ae54bb1df05dc2714ce1f793f7222db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130924
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-04  Michael Weghorn  <m.weghorn@posteo.de>  [5189fd943a522b8158002d6c34a897a9034b8819]

        a11y: Use more conventional indentation of 4 spaces
        
        I hadn't even noticed that 5 spaces were used
        until the Jenkins CI build for my change adding
        a single line only indented by 4 spaces failed [1] due
        to our clang indentation plugin...
        
        [1] https://gerrit.libreoffice.org/c/core/+/130924/1#message-7a5209670085f69e53fd592ba41c2bd4b74a360a
        
        Change-Id: I859e8de4c02ff33c6a9fee957d868cf6e4ddd907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130932
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [04e325131f3aeec0910257b261c9624de2b59542]

        use SfxItemSet::GetItemIfSet in sw/source/filter
        
        Change-Id: I8712a42236310a268fcbd7c47c01899333f4731c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-04  Mike Kaganski  <mike.kaganski@collabora.com>  [eccbe009fd28f5b468267af853931b121b5601fd]

        Enable tests in rtl_str.cxx
        
        And disable the tests that try to use nullptr where it's not accepted.
        
        Change-Id: I1cd031e371485fdd57e7691565376253a01049c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130938
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-04  Justin Luth  <justin_luth@sil.org>  [c1b2ed31cbde0a81853ba4fe59841cded6c52105]

        related tdf#144092 svx: warn about wrong "empty cell" idea
        
        An empty cell is not irrelevant in making height decisions,
        at least in MS file formats, and yet all of this code that
        is being based on that wrong assumption is being done to
        import ppt(x) files, and causing one regression after another.
        [Worst of all, this isn't even a filter import codebase.]
        
        Unfortunately the regressions have been dealt with
        or discovered slowly, so some of this has been in place
        for years. Otherwise I would revert this in a heartbeat.
        
        At least throw in a warning, so that this seemingly
        logical conclusion will at least be challenged by
        the next bug-fixer - instead of building another
        layer on this house of cards.
        
        Change-Id: I0e984a7ecce5061224a4165c0ee61818348a9659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129659
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-03-04  Jim Raykowski  <raykowj@gmail.com>  [2b924f0d83ce63882e7d14a2b51cc645c2532920]

        SwNavigator: speed up footnote endnote content fill
        
        Reduces the time to fill the footnote endnote content array by avoiding
        SwFormatFootnote::GetFootnoteText which calls the somewhat time
        consuming SwTextNode::GetExpandText. Just calling SwTextNode::GetText
        to get the footnote endnote first paragraph text should be good enough
        here.
        
        Testing with debug and optimized builds on a test document with 6243
        footnotes and endnotes shows a relative average differene of 10000 μs
        between use of lcl_GetFootnoteText, introduced by this patch, versus
        the current use of SwFormatFootnote::GetFootnoteText.
        
        Change-Id: I6a870c0700a3e64348e5550a0fc129eabf1b1d44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130182
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [58f2c1e6ab3052e0746dabb36e6061125779b034]

        tdf#135413: sw: Add UItest
        
        Change-Id: Ic22042b604ac7228ac0368c7c0a3324c1863679b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130940
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [4cbaaf21fe1c22b36dd72798cecfa59e73d0f8c3]

        Use <cmath>'s std::hypot
        
        Change-Id: I2f9db19dca795b6318cd88ca645020077520f5da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130943
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [be1076297b9b1191030cb4fc8c94cfae354630da]

        Drop some strcpy
        
        Change-Id: I304f69147e570f08c743183c54cc5b759143550a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130942
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-03  Luboš Luňák  <l.lunak@collabora.com>  [19e3644eaf8f3f09c22c94e4ad8352f844fc4955]

        make ScMarkData::IsAllMarked() work also for simple marks
        
        Change-Id: I41009c83827619605b4cfc4909f1d9922cde68a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130923
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-03  Luboš Luňák  <l.lunak@collabora.com>  [f92e15bc09def64a718b52812a9cb39e43fb8b5b]

        improve ScMark* classes a bit
        
        Bin pointless empty destructors, make trivial functions inline,
        return value by simply returning it.
        
        Change-Id: Ia71e73262802bbe6b022ca4bafb2b958ffdf39f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130915
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [dd6ff950cbc570a11100a7cce69d51577a26bbd7]

        ofz: Use-of-uninitialized-value
        
        Change-Id: If10e8d2465ef6de62583f6547e3f68e92002f3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [dd7f4acfccee6fd845050ecdc5544c1c9c78afaf]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I358d826a1dafe345f610d26d0d517a7357c838d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [0a1031a9ecd1502b1841bde26dde7ad51358c638]

        use SfxItemSet::GetItemIfSet in sw/source/uibase
        
        Change-Id: Ic82df8d321ba2eb94957236264c71c5eb9a940a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Stephan Bergmann  <sbergman@redhat.com>  [c1ac79906bde5c902be5cb0ae6b530da96e52169]

        Handle symlinks
        
        LIBREOFFICE-PQ967WYM
        
        Change-Id: I5e4df92401e009fe6b7238565d1223cfb77d10ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130930
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [c2432d011ba64f69bd64c08fc860d0bcbc7b3569]

        ofz#45183 Null-dereference
        
        Change-Id: Ida18ceac652f6be0b2bc23682600d2c338ee0f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130927
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [f105ac345a5695685123de031f25bd7f369cbda6]

        CppunitTest_sw_uiwriter*: Remove unused includes
        
        After a2a2e07996a0e49164663eaec5d79481bf7bb3e0
        < sw: split CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5 >
        and 06f19fc07991ee233a870e98a9115deffa8abf6d
        < sw: split CppunitTest_sw_uiwriter4 into uiwriter4 and uiwriter6 >
        
        Change-Id: I28d4034917b660e3da7d5ae381500100ea33f0f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130931
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [6186e025e4b1e0cb4dbb3d7d4a06798ab1383eb5]

        tdf#107494: sw: move UITest to CppUnittest
        
        Change-Id: I32e9f3daf866f0598889594b106383db22590d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130895
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-03  Miklos Vajna  <vmiklos@collabora.com>  [a0f86d94e23e8ae0129780745deb2d3526b4fbfa]

        sw clearing breaks: include this in the UNO API text portion enum
        
        Which is how UNO API clients (e.g. ODT export) will be able to read
        RES_TXTATR_LINEBREAK.
        
        Change-Id: I44d2058fd8b4a4fefce3dacc49d3bb3da6060756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130903
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d04a04d76f8b813b3fc54195f95c7c53e01a1832]

        tdf#128445: vcl_pdfexport: Add unittest
        
        I couldn't revert the fix to check the test without the fix in place
        so instead I checked with branch libreoffice-7-2
        See https://gerrit.libreoffice.org/c/core/+/130921
        
        Change-Id: I895a2d0a8034a247a69ddedd9253e97bad60b3f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130920
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-03  Stephan Bergmann  <sbergman@redhat.com>  [a459e6e7984bb3f88f95b587b0cde4a6f8095242]

        Avoid loplugin:noexcept
        
        ...when building on Linux with Clang -stdlib=libc++,
        
        > In file included from bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:41:
        > bridges/source/cpp_uno/gcc3_linux_x86-64/share.hxx:156:51: error: Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept]
        > extern "C" __cxa_eh_globals * __cxa_get_globals() throw();
        >                                                   ^~~~~~~
        
        (The situation with respect to these exception specifications is a bit unclear,
        recent <https://github.com/itanium-cxx-abi/cxx-abi/blob/main/abi-eh.html>
        doesn't mention any exception specifications for those effectively extern "C"
        functions, and recent
        <https://github.com/llvm/llvm-project/blob/main/libcxxabi/src/cxa_exception.h>
        doesn't have an exception specification for __cxa_get_globals and recent
        <https://github.com/llvm/llvm-project/blob/main/libcxxabi/include/cxxabi.h>
        doesn't have one for __cxa_current_exception_type though it has `throw()` for
        __cxa_allocate_exception.  On the other hand, recent
        <https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/libsupc%2B%2B/cxxabi.h>
        and
        <https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=libstdc%2B%2B-v3/libsupc%2B%2B/cxxabi_init_exception.h>
        have _GLIBCXX_NOTHROW exception specifications for all three functions, which
        expands to `noexcept` for C++11 and beyond.)
        
        Change-Id: I1582c9d3b42977af011d4dc49674fdf12d5ea5ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [09a06141c516991865627f78e39593be856f6457]

        Deduplicate some char replacement functions
        
        Change-Id: Ie65224066941dbab89abb6fc91e6cbfbc45bf201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130901
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [0a774bae7d402a6880760b1226a6741604e23f5a]

        ofz#45165 verify table offsets
        
        Change-Id: I99649a03da28d3b896bed72999b50803ce0a4761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130919
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [d26d26b2c3052a97422005e864861c4d6f6f1482]

        ofz: Null-dereference
        
        Change-Id: I107f6b4e88ad4b472614331010cd2fa45a865f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130908
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Noel Grandin  <noelgrandin@gmail.com>  [fba41eff279df015d24cf8faee7d4ff85ef32fac]

        assert more in SvxShape
        
        Change-Id: I98812e4cd70ced6d493f558844832e8c0c99b684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130914
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noelgrandin@gmail.com>  [b6fe3b13206eee0543ded37c3a1566add284e6da]

        no need to have two weak references to SdrObject in SvxShape
        
        Change-Id: I62d8e34e6896ae4aba951045d2e6ce1669c0ed23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [94bdee6bf24965fab957c73a2c38e34c115a030e]

        crashtesting: assert that !rtl::isAscii in xmlError message
        
        probably detected since:
        
        commit 089ce740f9f97f9c7b13e37a31acfc94984e9a3e
        Date:   Thu Feb 24 17:45:18 2022 +0300
        
            Deduplicate rtl_*String_newConcat*L
        
        or similar
        
        Change-Id: I389d0875463f2ac59fda9266b168bdc35c82de95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130917
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [0dcd6317f3722f637cd28728fadde595c26d78d9]

        ofz: check hmtx offset
        
        Change-Id: I650a37472c70771d40febe52efcb723195856421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130911
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [117864df3688ae66b30ef0634fb0045363c604dd]

        remove now redundant double()
        
        Change-Id: I4be6a481b7e1043bfada6e19b95a37e863c27772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [defa0142c92e50e7a24689bebac593db434bb778]

        update credits
        
        Change-Id: Iccc04d9704a9ee9800d2015b38e55e707ff69c41

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [88e82c0f37b9fd362fe0cacba32442149eb3afaa]

        rearrange slightly to have one pair of reads
        
        no logic change intended
        
        Change-Id: I2c102d8fea89ae68b75cb22b32f77fc90843b079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130910
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [b667327463de24715405322e69e1933cf50d25e6]

        ofz: Integer-overflow
        
        Change-Id: Ifb3c0e4c9fec5af448bae7efaddac234854fb468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Mike Kaganski  <mike.kaganski@collabora.com>  [04af8ac89ecdc98361f52b792ff0ce1c3ccb4517]

        Use a more conventional begin() / end() syntax
        
        Also would potentially enable use in std range algorithms
        that take different end sentinel type.
        
        Change-Id: Ia75005caa7ce44302fc8612f5717a41d11087622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130902
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [896c097f1fa4bc9d2e5ea87a696c125bb335ecac]

        cid#1500573 silence Untrusted loop bound
        
        Change-Id: Ic932ba264e6e593ac8e5432fa9afd440ff1aa2d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-03  Gabor Kelemen  <kelemeng@ubuntu.com>  [96e3a64125354b61ecd43f7a76e6189e69968912]

        Recheck modules sv* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I25779cbfb1aa93c31d6e12ac95e136b3bdbbc058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130403
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-03  Caolán McNamara  <caolanm@redhat.com>  [ac605821ecf3ea263d4812ebec352314a2dbff42]

        add a SwFrameDeleteGuard to SwSaveFootnoteHeight
        
        Change-Id: Ic4f0bb7c26cc021119b09682075a05d5207b48a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130897
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [c35a59ae2e26ee30b036d3946a9be26e981838b7]

        use SfxItemSet::GetItemIfSet in sw/source/core/firlds
        
        Change-Id: I25d46d8435b8a95ac8809b9f67a6c3a9b14dd26e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130878
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a44807ff3a11afa8f7ce9857ae6a6144a61d481]

        use SfxItemSet::GetItemIfSet in sw/source/core/txt
        
        Change-Id: I386bc04447d8c900a4ae3a7caa44860731b1bf84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130880
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [09b50bcd11e35e68b5b303666bfeaec89d6c6ed8]

        use SfxItemSet::GetItemIfSet in sw/source/core/txtnode
        
        Change-Id: I3b6315e987899476ec46b3d7ec98f085a5cd598e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130881
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [552c9cb9a5e41797a1353a9a014ede03a0971ceb]

        use SfxItemSet::GetItemIfSet in sw/source/core/layout
        
        Change-Id: I19f13a9a822afefe2f59ea4440ab20e7f4150dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [1ff25864d9c40cfc913eb9829e28e366d409743d]

        use SfxItemSet::GetItemIfSet in sw/source/core/undo
        
        Change-Id: Iad685caa338367d51292166604892c6bd3ee81ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [4796e6d60b8d78cff401cc41712c2d2e862eee69]

        use SfxItemSet::GetItemIfSet in sw/source/core/unocore
        
        Change-Id: I18b05cfb49e5ab3e42db4c8c2c1fbfb4ec4659e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-03  Miklos Vajna  <vmiklos@collabora.com>  [6f50fe6f524d922c27ec1313ebef49352a2f9128]

        sd theme: add rendering for shape fill color
        
        I.e. update the shape fill color when the theme of the master page
        changes if the color is a theme color.
        
        Change-Id: Ia1ed566230a8547334aa4a7d69627882aa690546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130894
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-03  Kohei Yoshida  <kohei@libreoffice.org>  [fb9270b238cba4f36e595c5d7f4d85f6f3f18e1c]

        Check for cached formula block count to make sure it's correct.
        
        Change-Id: I16237d26bb9e55ba5c3e65087be98ba8f8086d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130899
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [04f9a8957c04b8c5abaa58140328d2c83381f4ff]

        tdf#147283 allow 'fake italic/bold' glyph fallback results to be cached
        
        see also tdf#32665
        
        Change-Id: I69746b815fec3c73f87de4dc3fe84dbc91e61f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [8716721f4645078b04770271c71f7687a2b21e07]

        Related: tdf#147283 set a concrete weight for the bullet font
        
        otherwise it's unknown and on a glyph fallback the resolved true weight
        won't match so glyph fallback cache can't be hit
        
        Change-Id: I2dcce3dc1532e9ee00a1e1980752df9f5053c77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130892
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [3cb30369d699a4836043d434833ba4c3d3d257c3]

        Unify normal/shortened, null-terminated/with-length comparisons
        
        Change-Id: Ie154efd1e0d9b49601200ac896d5d5dd0422d504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130832
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [aa54ea23233a54e32450138a07f2d6d2257149d9]

        Change the comment of the test cases to clarify the textual representation of the calculated string
        
        Change-Id: I98478297a577f723864b37514bbd432a6224350d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129844
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-03-02  Luboš Luňák  <l.lunak@collabora.com>  [11ad730e765824ac9b954865e1d5651b6c837b2d]

        function that modifies data should not be called IsXXX()
        
        IsXXX() is for const functions that check something. Using it
        for functions that modify data is confusing. Some of them even are
        in fact const, and the problem got "fixed" by making data mutable
        *sigh*.
        
        Change-Id: Ic385c96d6c32c818a8a6baa77ab025aab2c45a03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130890
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-02  László Németh  <nemeth@numbertext.org>  [2c51746997478ad5d0e7cc64aa6489769c473d43]

        tdf#146171 DOCX: fix loss of change tracking, if no date
        
        was specified, or it was specified as zero date (e.g. in
        a LO DOCX export).
        
        DateTime attribute w:date is optional in w:ins/w:del
        according to the OOXML standard. Not specified w:date was
        imported as invalid zero date "0-00-00T00:00:00Z" resulting
        loss of change tracking data completely during an ODF
        roundtrip.
        
        Import this invalid zero date as Epoch time to avoid losing
        change tracking data.
        
        Change-Id: If8442db9aa5e41c470827545c36c64f598887101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130885
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-02  Luboš Luňák  <l.lunak@collabora.com>  [89101372c892d2ec3cfa8008101cbfb56ac1cf99]

        remove self-assign
        
        Change-Id: Idd0dfd7c68dfc19458a710c79234dd76e6f91ab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130893
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [390bba81f590cc885582d17a2f78d0465e39fb72]

        cid#1485150 silence Uncaught exception
        
        Change-Id: Ib7aa5dc2cd7e32d31e9da84e6dcb9e6ce5b472d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [6b6c9fc67cdd42fa8feb3d7c4f6346ed54d4619c]

        cid#1500437 silence Resource leak
        
        Change-Id: Ibaa402dea5c684a08e2fe8ca8425ea92332bba9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130887
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [b9037cbc0c96c1a08d0691d8bc2edc0e64f394ea]

        cid#1500415 Explicit null dereferenced
        
        Change-Id: Ifcb4eb0c453f5d39ac9d44a40df060b16b33c462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130886
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Michael Weghorn  <m.weghorn@posteo.de>  [c4c1a6e6bfc42dddfa7a7ded826dca37c1d35dce]

        wina11y: Simplify this loop a bit
        
        Use a range-based for loop, `OUString::isEmpty`
        instead of checking the length and
        combine the two conditions into one.
        
        Change-Id: Iddc75369b1600f2f540f7ec4a6f8ed0b8462fd93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130841
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [06f19fc07991ee233a870e98a9115deffa8abf6d]

        sw: split CppunitTest_sw_uiwriter4 into uiwriter4 and uiwriter6
        
        Similar to a2a2e07996a0e49164663eaec5d79481bf7bb3e0
        < sw: split CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5 >
        
        it already had 126 tests
        
        Change-Id: Ia98a97ca621289c6b089f570bff3a1330a08efa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130883
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-02  Stephan Bergmann  <sbergman@redhat.com>  [a9e6b8a36b9ecf4f9471a9915cdfab3c99c8bcff]

        memcpy-param-overlap
        
        ...seen during CppunitTest_sw_filters_test, regression introduced by
        b871d057c45fdd231aa5e1d2b94e7d0a039f4292 "use OUStringBuffer for a string that's
        modified often (tdf#145862)" turning SvParser::aToken from OUString to
        OUStringBuffer:
        
        > ==768636==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x6250003ed112,0x6250003ed12e) and [0x6250003ed108, 0x6250003ed124) overlap
        >  #0 in __asan_memcpy at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3
        >  #1 in rtl::addDataHelper(char16_t*, char16_t const*, unsigned long) at include/rtl/stringconcat.hxx:89:9
        >  #2 in rtl::ToStringHelper<rtl::OUStringBuffer>::addData(char16_t*, rtl::OUStringBuffer const&) at include/rtl/ustrbuf.hxx:1750:14
        >  #3 in rtl::OUStringConcat<rtl::OUString, rtl::OUStringBuffer>::addData(char16_t*) const at include/rtl/stringconcat.hxx:252:88
        >  #4 in rtl::OUStringBuffer& rtl::OUStringBuffer::operator=<rtl::OUString, rtl::OUStringBuffer>(rtl::OUStringConcat<rtl::OUString, rtl::OUStringBuffer>&&) at include/rtl/ustrbuf.hxx:369:17
        >  #5 in HTMLParser::FilterXMP(HtmlTokenId) at svtools/source/svhtml/parhtml.cxx:1795:24
        [...]
        
        Change-Id: Ifc0a36de6503a06799ee4cd50ce57a6110c7d5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130889
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-03-02  Luboš Luňák  <l.lunak@collabora.com>  [31678ed7eb992586c42816ab96391bc3a921f176]

        fix incorrect search start
        
        A mistake from 05259e880db187f6698d6d545504775459d6e96a, the second
        if branch doesn't guarantee anything about where EXC_XF_NOTFOUND
        elements start.
        
        Change-Id: I942f87a7320c13a8f87ab3c9f1683a75d7a1e135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130876
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-02  Andras Timar  <andras.timar@collabora.com>  [09d86496f05c979da5a1c8c09af448d74683fad0]

        Do not pull in X11 dependencies when the build is configured for LOKit
        
        Change-Id: I44a1782cf523bbfbbbb0e0d5333364f36c7ed495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130783
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-03-02  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [cfb68712a4916448b4edbf57b6037eda53932b18]

        Advanced Diagram support: Extend UI to all applications
        
        As a preparation make the currently available minimal UI
        to interact with Diagrams available to all LO apps
        
        Change-Id: Idd0a4c187a295cd264ebd09be2b574a3d2a93e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130837
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5af30f3c37f5560cc685482e0be29127dda34b4e]

        use SfxItemSet::GetItemIfSet in sw/source/core/docnode
        
        Change-Id: I71f6b60e981aa4391563a5214be38bb03646cdf4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130839
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa90836808d0a071e544554a39724fc0dfc3c846]

        use SfxItemSet::GetItemIfSet in sw/source/core/doc
        
        Change-Id: Ia56daf87140680a83d783e995ea220134a8be4c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130838
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [c7579b6d77a837bc03c9aa529dd67952f0f1f4b1]

        tdf#113197: sd_png_export_tests: Add unittest
        
        Change-Id: I1e5a6818f7d540153a50cc42c9c12e17a41409ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130846
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [66cf7677a2352c3796ef12597bbff9145a2efdec]

        ofz#45140 just discard document where import has hopelessly failed
        
        Change-Id: Ic772402f99cd68abf24c79f2cf2270692f21aa53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130844
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [a625a9e6858fa1c8c62d6201040d7d36e71a4efa]

        move these two DeleteListeners beside each other
        
        Change-Id: I815223b88b09d19014bed7c4940873fc12b4854f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130845
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [fc6d3381da7555c7144b650d239ce1d88ce9026e]

        ofz: don't read past end of record
        
        Change-Id: I9fced38faf46dce9f4cc2b96e351e7ae945d0ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Miklos Vajna  <vmiklos@collabora.com>  [a2a2e07996a0e49164663eaec5d79481bf7bb3e0]

        sw: split CppunitTest_sw_uiwriter2 into uiwriter2 and uiwriter5
        
        My build with 16G ram now regularly fails with:
        
        g++: internal compiler error: Killed (program cc1plus)
        Please submit a full bug report,
        with preprocessed source if appropriate.
        See <https://bugs.opensuse.org/> for instructions.
        make[1]: *** [solenv/gbuild/LinkTarget.mk:341: workdir/CxxObject/sw/qa/extras/uiwriter/uiwriter3.o] Error 4
        make[1]: *** Deleting file 'workdir/CxxObject/sw/qa/extras/uiwriter/uiwriter3.o'
        make[1]: *** Waiting for unfinished jobs....
        make: *** [Makefile:299: build] Error 2
        
        And it seems uiwriter2 is the larger uiwriter suite in sw, so split that
        into 2.
        
        Change-Id: Iba029af2f5bb3f1196707bc13b5e32fefa7e58c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130842
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [3e94bd846ab02f3f0dac55e9646ac778d6b7f284]

        ofz: Integer-overflow
        
        turn macro into a function and have it return a double
        
        Change-Id: Ib410d8f9f53271f58e44f2c46382871051a4476b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130836
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [b28fbdc6dbee84ff265a2ab9002015d68fcd2ef7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 385b2a1c99550f8b49d8a4a2f83f89c9089b8943
          - Basic help extra x-links
            
            Change-Id: I875e5027de98d23e1644aaa5cfbce0a124f543b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130677
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-02  Jean-Pierre Ledure  <jp@ledure.be>  [363dd5850fd1681caeb2757f1ad2378b6a0e4afe]

        ScriptForge - (SF_Calc) new ExportRangeToFile() method
        
        The Calc service offers the possibility to export
        a range, given as a string, to a file in several
        different image formats.
        
        Supported formats: pdf, jpeg, png.
        
        Arguments:
        - Range: a sheet name or a range of cells
        - Filename: the file to export to in FileSystem notation
        - ImageType: the expected output format
        - Overwrite: True when the output file may be overwritten
        
        New error message: RANGEEXPORTERROR
        Error is introduced in po files.
        
        The method is available both in Basic and Python user scripts.
        
        Change-Id: Ibd297ec2da1b48fca3dee7d8e03bd2ee4815957a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130835
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-03-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [27940a5c65a0bf63fdc0a124c4f7fed075cea53b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9096610a179d357f0b289b6b6e788421b37b579
          - tdf#135812 Add help ID targets for the Manage Changes dialog
            
            Change-Id: I688282317f40e9be42d04b5dbd1307acd8cbd100
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130679
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-03-02  Miklos Vajna  <vmiklos@collabora.com>  [c1ce7d9f2c4036ae71f8cfa71e4bee4067f4d8d2]

        svx: the SdrObject of SvxGraphicObject can be nullptr
        
        Crashreport:
        
                Graphic::GetType() const
                        vcl/inc/impgraph.hxx:122
                SvxGraphicObject::getPropertyValueImpl(rtl::OUString const&, SfxItemPropertySimpleEntry const*, com::sun::star::uno::Any&)
                        svx/source/unodraw/unoshap2.cxx:1466 (discriminator 1)
                SvxShape::_getPropertyValue(rtl::OUString const&)
                        svx/source/unodraw/unoshape.cxx:1747
                non-virtual thunk to SvxShape::getPropertyValue(rtl::OUString const&)
                        svx/source/unodraw/unoshape.cxx:1732
        
        During SVG export of a selected shape.
        
        Change-Id: I29b56d49b0c5418dfe8fec8491ac8667e5ade2ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130740
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130819
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [3a371df3ecce456c9329a493f48600431d2ade69]

        ofz: detect endless loop in font processing
        
        Change-Id: I4e6c61d8be15a560f43b5d37d646e7bad9739eb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130833
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Heiko Tietze  <tietze.heiko@gmail.com>  [0bb3fcb96166fb1078512ad0c0a60e0046504d1a]

        Bump Glade version to 3.38
        
        Change-Id: Ibd8ffc90efaed9f8a5ced558f22ec53da7f31cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130822
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [aef976e9ba29ed8af96d2b94a38e7ee8cf623fc8]

        use SfxItemSet::GetItemIfSet in sw/source/core/attr
        
        Change-Id: Icec7a62a7b2987ffe9c0f74e2b49993bd2b9bfbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130821
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Gülşah Köse  <gulsah.kose@collabora.com>  [3faf005a367cbd28077403bf93810bbaf4805851]

        tdf#135843 Implement inside horizontal vertical borders.
        
        wholeTbl as TableStylePart should be handled in different way. Before
        left border of the whole table was handling like all cells left
        border but it should be left border of the first column.
        
        insideV and and insideH properties are imported but never handled. I
        added the inside vertical and horizontal borders handling.
        
        Change-Id: I5aea5cbefc746db637eac6c1438fa70a7d741bc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128971
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-03-02  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [e8a004d54dc939b257b2851a78c324269e2a3973]

        Advanced Diagram support: Disable enter Diagram (Groups)
        
        Groups which are in Diagram mode should not be entered, to
        do so disable at UI and - for security reasons - also at
        the executing mehod.
        Groups in Diagram mode can still be UnGrouped (which will
        remove the Diagram status & data)
        
        Adapted testRegenerateDiagram() to directly act on the
        model data to test the same as before. Using triggering
        of UI events to enter the diagram group object needs
        reorganization, but model op's will always be possible
        
        Change-Id: I199f3821c2a8308a6f015997ce9eaef87623c46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130541
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f7cbc3a5358620f94fd175dbd494e6d5c01f3de]

        use SfxItemSet::GetItemIfSet in sd
        
        Change-Id: I198b6101c1d62e81a70bac6a57faa2adc2dd36f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [615f72e74c9ac2202bce4dd95d98b6558b178f19]

        it's not for listening to a File Picker
        
        Change-Id: Ied7b9cec6283e1cec369558bbfff702135d806f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130812
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Michael Stahl  <michael.stahl@allotropia.de>  [f51ec0c0c860d751ac4255470796ffba4a5fafd3]

        sw: oops forgot to remove this comment
        
        Change-Id: I1e12def63a6353a9eab3f073ef35ba305ff32649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130829
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [10d46c0498b89350645cf45e744a528d3d8f1ac1]

        add a layout test to exercise UXTSOREL
        
        Change-Id: I57b29dd7d73c08bdbf227676c4ce9034aabf418a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130493
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-02  Michael Stahl  <michael.stahl@allotropia.de>  [3f569ffc9238e6bf2915e78bf21c844ca5f1270d]

        sw: really prevent footnote frame against delete while it's moved
        
        This reverts commit fe5d3fbfe63fe8b433776bd3a0508dd712b868b0
        
        It turns out that checking a single column's IsMovingFootnotes() is not
        enough - as frames can move both forwards and backwards the entire chain
        of columns would need to be checked.
        
        (Most callers of MoveLowerFootnotes() move forwards, but one place in
        tabfrm.cxx moves from a follow to master.)
        
        But it turns out that this is probably the wrong way in any case: most
        likely the intention in FormatAnchorFrameAndItsPrevs() is to format
        previous frames in the same layout environment, so if there is a section
        or column inside a footnote then this upper should be formatted, while
        if the footnote is inside a section or column this upper should not be
        formatted; this should make calls during MoveFootnotes_() safe as it
        should prevent the formatting of frames in the footnote boss moving a
        footnote that is already being moved.
        
        So tweak the fix in commit fa1bcc22921941b2cd8a0b32fe0d15655d12d607
        a little to make it more general.
        
        Also it was previously possible that for a section with columns,
        both the section branch and the column branch was taken, which seems
        supperfluous.
        
        Change-Id: I39487640322339fe4d511e845d9c6bced2ba9dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130544
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-03-02  Miklos Vajna  <vmiklos@collabora.com>  [1a240807f2c051ff9a63d713625404a024d7c221]

        sw clearing breaks: add UNO API to insert this with custom clear / char props
        
        - if (character) properties are specified when the text content itself
          is inserted, then format the anchor ("dummy") character like that
        
        - add the ability to specify a clear type (none/left/right/all) on the
          line break object itself before insertion
        
        Change-Id: I219a1031e53c2e0368ff329d45b7e3fff0934038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130818
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [46cf4096b794b11fee2bf75975f1083a38d889ec]

        fail more gracefully if m_aTmpPosition is empty
        
        LIBREOFFICE-N4LA0OHZ
        
        Change-Id: I7f863151f753ad5605c4f1f280cfd79aa4c6bce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [588f5c9a53c9ddd5a8d704137c4b008365adb3ff]

        ofz#45156 Floating-point-exception
        
        Change-Id: Ia121fca4123f83fbb953dd3ce3da496c19fcb3b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130813
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Caolán McNamara  <caolanm@redhat.com>  [0dce241698ff906c10f8a95da43009b6feeb7bd3]

        ofz#45063 Out-of-memory
        
        Change-Id: I3d7635b80fc3c64951bd01eed22a019328ce7183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130814
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-02  Luboš Luňák  <l.lunak@collabora.com>  [4e279e8c4986ca3de79bea2216c5783cb113a5bb]

        reuse a vector instead of repeatedly creating it (tdf#95346)
        
        With some documents this actually is a noticeable cost.
        
        Change-Id: Ibaf2157eeba83e0c8f78c7ba058771f92bb44e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130795
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-02  Luboš Luňák  <l.lunak@collabora.com>  [f8edf0a94e9608d7e7d8ed5fb46036b2ceb71693]

        try to avoid using map when searching most used item (tdf#95346)
        
        The last item is usually going to be the most common, so first
        check that.
        
        Change-Id: Ibad8b6bb9a829a96691c10b780b8e52610475126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130794
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-02  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [9c0779cfe6a091e222a35b068e9354dce32cc2dc]

        tdf#69648 tdf#119234 sw: fix at-char group textbox position
        
        in case of it has at-page relative position. This fixes
        missing or invisible text content of shapes.
        
        Note: the remaining problem (original DOCX resaved in
        MSO 2016) was fixed at tdf#119234.
        
        Partial regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
        "tdf#143574 OOXML export/import of textboxes in group shapes".
        
        Change-Id: I5c9af0d9a50e4251d3017862ad1fc94eca7d40c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129796
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [8ae8bea13565012410ecf13332f4696346294c12]

        Drop useless indirection and unused template
        
        Change-Id: Icbcf56c30c9d901a4436f56a1648a7c8e7504848
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130817
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d33c22e55b7af7481cc36a1fff979a33daf8519]

        remove writerhelper::DefaultItemGet
        
        the TypedWhichId template methods on SfxItemPool supercede this
        
        Change-Id: Ice8fc953b0ec2cc3cfd4075a99f21889c23accda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130806
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [24bcd1692cd9689f2586beebb5e4215d02fe8196]

        remove writerhelper::ItemGet
        
        the TypedWhichId template methods on SwFormat supercede this
        
        Change-Id: I7444dc1eb85fccfc9d60da4f1502ea2e2ceccdc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [919b923e9fe59bd83d954a53c21635317fea0de7]

        remove writerhelper::ItemGet
        
        the TypedWhichId template methods on SwContentNode supercede this
        
        Change-Id: Ibb9a6a6a1642e2d764004c7179dce642fef7a40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [31a8627f0323fad0f85f7859a513dbc039375afb]

        add TypedWhichId version of GetWhichOfScript
        
        Change-Id: Ieb93f9525d0cc5b3a23e013f30ddaad6f44890ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130796
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Miklos Vajna  <vmiklos@collabora.com>  [a12b4d548cd4173d87d8736ec6a484becb44d943]

        CppunitTest_embeddedobj_general: put the base class into an anon namespace
        
        Which reduces the probability that the base class name collides with a
        symbol from non-test code.
        
        Change-Id: I7df17a76602b12da7b10cb77f6e44466676d15a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130811
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-02  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [5752760f0af5c5c6411d4dc7704b2a683211341f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e15b650cf80aea131a4429d4bda438130f4cf601
          - Update menu path
            
            Change-Id: I2f23458e8abc9697b0a2da089e6fd48c86503186
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130816
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-03-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa01aa03b73ddeeae1f98730b21ec77338af5f9e]

        remove writerhelper::ItemGet
        
        the TypedWhichId template methods on SfxItemSet supercede this
        
        Change-Id: I9c6240657a7c98fad93399f9ce17c370acd125c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-02  Mike Kaganski  <mike.kaganski@collabora.com>  [5b03e07dd21b56e99d6b6b60edec1ed2f388bfc2]

        Unify and deduplicate to[U]Int[_WithLength]
        
        Change-Id: I05e71b36030da0a91c24b3926ee1d069912849f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130815
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-02  Justin Luth  <justin_luth@sil.org>  [b7f654a406b704f469d1df424d83a3d98ae46432]

        tdf#118117 sc pivottable: STR_PIVOT_DATA is an existing name too
        
        This fixes a LO 6.0 regression from
        commit a078328e91ab9cbd78a92608c1abdc2c57ff9ac5
        
        I looked for existing unit test examples using
        assert (rLabel != ScResId(STR_PIVOT_DATA));
        but found nothing.
        
        I don't see the need for a unit test here.
        The whole pivot table is messed up if you duplicate
        a label, so why bother testing. It just is not
        as bad now as it was before.
        
        Change-Id: I59cc73becf91f766a29d2007c2d67685ffa2a65c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130751
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-03-02  Hossein  <hossein@libreoffice.org>  [d1cfe4228316322d0ae9f3b8020036e5140fc32b]

        Remove 'const' from for loop variable
        
        In the commit f63a6f2e396fa41ed1338dcec874e06159cafa9f, a for loop is
        converted into a range-based for loop. The pointer is used to change
        the nodes using xmlUnlinkNode() and xmlFreeNode(), thus the 'const'
        should have not been used.
        
        The reinterpret_cast does not change the constness, thus I have
        removed the const from the loop variable, and it will no longer be a
        const reference.
        
        Change-Id: If4c61017ea77f464230bb5802f6fc928acc7a7e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130792
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [dc99d27f04b47c173de934a19b6d6a3cc572c20a]

        Resolves: tdf#145580 need to use gtk_im_context_filter_keypress
        
        for at least xim, ibus works fine. To reproduce under Fedora with gtk3
        can use a keyboard layout of "US International with dead keys" with
        export GDK_BACKEND=x11
        export GTK_IM_MODULE=xim
        
        and 'a in writer comment or calc header/footer dialog
        
        Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130801
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [684e0b742aa611e684cfdf1f7ddff711bf6ab513]

        xPreferredPixelSizeListener is never null
        
        Change-Id: Ide71bad809c192446e157662787ef2f4437ef66f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130800
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Luboš Luňák  <l.lunak@collabora.com>  [09558e2f45e27d572fd261562c884c2d2cc896a7]

        avoid a temporary buffer, append to the resulting one (tdf#145862)
        
        It doesn't seem to make a visible performance difference though.
        
        Change-Id: Iec56f4f484dbebcc216308d17422151424d0697c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130790
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-01  Luboš Luňák  <l.lunak@collabora.com>  [b871d057c45fdd231aa5e1d2b94e7d0a039f4292]

        use OUStringBuffer for a string that's modified often (tdf#145862)
        
        SvParser::aToken was OUString despite being a buffer where the parsed
        result is collected.
        
        Change-Id: Id24c842738ea0f6f1836f77d855069963ac5ae55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130763
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [2960d4128710afd3e0c090960d281e69b44e69eb]

        Use known length to pre-initialize buffer
        
        ... and drop now-obsolete conditional include, which is included
        unconditionally since commit 4c68c4b93c41c4e9c2d5faf6c02ece2d40e95eb4
          Author Stephan Bergmann <sbergman@redhat.com>
          Date   Tue Mar 01 08:23:31 2022 +0100
        
            misaligned-pointer-use
        
        Change nCount argument to sal_Int32, since that's what is used for
        string lengths. The call sites use sal_uInt16 and sal_uInt8 as the
        argument value.
        
        Change-Id: Ie2a9791f3ab9565590cb4f9c42d44f6eeff29745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130754
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-01  Miklos Vajna  <vmiklos@collabora.com>  [5028e5670da25ec1e8eeee62789b744c32e6108b]

        sw clearing breaks: add UNO API to insert this
        
        This only allows the clear=all break type, the others are not yet
        handled.
        
        Change-Id: Id4981b3cc0a8faca2166ad93827ae547f5539095
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130741
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2c5d4436f05ee99cf6937940f2010edf90e7f9e9]

        Fix typos
        
        Change-Id: I9a98bac7c570f25ff7d77df98e93aaeed2665038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130720
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e50f13c9947332639f455739c87213a954067299]

        use SfxItemSet::GetItemIfSet in sc/source/ui/
        
        Change-Id: Ia360a0bbc57f2d50dc26ae670d6e953d3f2d8a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [05db887bc226b85befe2c2b9e84b796020a6ca05]

        gtk4: media dimensions are only reliably available async
        
        this is also the case for the direct gstreamer use in gtk3 but
        more egregious when abstracted away from it in gtk4
        
        Change-Id: If90069308d67929585722c079c482cd4ad196e1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130468
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [ae071f7d680545e284e5947d26cbea30e59bdfb5]

        add a way to get informed when the XPlayer can return useful information
        
        Change-Id: Ia9adf81ba85653b5735f604461340df7bfc1f41f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Luboš Luňák  <l.lunak@collabora.com>  [a85b647f7bb6cb869abf22ab9ecce419ad5083e0]

        compress calls to AdjustRowHeight() to just one call (tdf#94677)
        
        This function imports only text, so I think doing one big call
        at the end should be fine.
        
        Change-Id: I267f5857ac11cfb95245434333f2ca5fa7e662cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130789
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-01  Luboš Luňák  <l.lunak@collabora.com>  [ffe7850a1449c43dd077c5cb073d8eee178f7099]

        fix o3tl::equalsIgnoreAsciiCase()
        
        As the OUString equivalent shows, it needs to check == 0. Commit
        33ecd0d5c4fff9511a8436513936a3f7044a775a for some reason also
        dropped the cheap checks (even from OUString) that OString has,
        so add them.
        
        Change-Id: I88e68b5ae10fd76c3c08b9b36d5abed0fad17bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130753
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [ee2a192923bf709d05c174848e7054cd411b205a]

        protect frame from triggering deleting itself
        
        LIBREOFFICE-N4LA0OHZ
        
        Change-Id: I0d24277665a317f047b286fe0f0878b3814ded65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130766
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [35f1e9c7f97ed08dcb87e90cb663ae2d333739e5]

        fix data races in cclass_Unicode
        
        WARNING: ThreadSanitizer: data race (pid=1220516)
          Write of size 4 at 0x7b1c00035510 by thread T19 (mutexes: write M0):
        i18npool::Transliteration_casemapping::setMappingType(MappingType,
        com::sun::star::lang::Locale const&) :? (libi18npoollo.so+0xe5685)
        i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int,
        com::sun::star::lang::Locale const&) :? (libi18npoollo.so+0x792fa)
        i18npool::CharacterClassificationImpl::toUpper(rtl::OUString const&,
        int, int, com::sun::star::lang::Locale const&) :?
        (libi18npoollo.so+0x83855)
        (libutllo.so+0xc6f42)
        (libsvllo.so+0xc5823)
        const&) ??:? (libsclo.so+0x4978f3)
        const&, std::shared_ptr<oox::xls::RichString> const&) :?
        (libscfiltlo.so+0x46b354)
        const&, int) :? (libscfiltlo.so+0x46b44a)
        (libscfiltlo.so+0x4764a0)
        :? (libscfiltlo.so+0x4764e9)
        oox::core::ContextHandler2::endFastElement(int) ??:?
        (libooxlo.so+0x1a10eb)
        (libexpwraplo.so+0x2fbdf)
        (libexpwraplo.so+0x2fb21)
        char const*, unsigned char const*, unsigned char const*)
        fastparser.cxx:? (libexpwraplo.so+0x2c255)
        /build/libxml2-vTtzwD/libxml2-2.9.12+dfsg/builddir/main/../../parser.c:9736
        (libxml2.so.2+0x5751a) (BuildId:
        baaa02c136f3351b1c499bbbbe94450b9b9c0d4e)
        /build/libxml2-vTtzwD/libxml2-2.9.12+dfsg/builddir/main/../../parser.c:9691
        (libxml2.so.2+0x5751a)
        sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
        const&) :? (libexpwraplo.so+0x2972d)
        sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
        const&) ??:? (libexpwraplo.so+0x30e88)
        oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource
        const&, bool) ??:? (libooxlo.so+0x1a3220)
        oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream>
        const&, rtl::OUString const&) ??:? (libooxlo.so+0x1a3467)
        oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
        const&, oox::core::FastParser&) ??:? (libooxlo.so+0x1c46c1)
        oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler>
        const&, oox::core::FastParser&) :? (libscfiltlo.so+0x4be642)
        workbookfragment.cxx:? (libscfiltlo.so+0x4b618d)
        (libcomphelper.so+0x15e63b)
        (libuno_salhelpergcc3.so.3+0x5257)
            #25 threadFunc :? (libuno_salhelpergcc3.so.3+0x550e)
        (libuno_sal.so.3+0x67e25)
        
        Previous write of size 4 at 0x7b1c00035510 by thread T18 (mutexes:
        write M1):
        i18npool::Transliteration_casemapping::setMappingType(MappingType,
        com::sun::star::lang::Locale const&) :? (libi18npoollo.so+0xe5685)
        i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int,
        com::sun::star::lang::Locale const&) :? (libi18npoollo.so+0x792fa)
        i18npool::CharacterClassificationImpl::toUpper(rtl::OUString const&,
        int, int, com::sun::star::lang::Locale const&) :?
        (libi18npoollo.so+0x83855)
        (libutllo.so+0xc6f42)
        (libsvllo.so+0xc5823)
        const&) ??:? (libsclo.so+0x4978f3)
        const&, std::shared_ptr<oox::xls::RichString> const&) :?
        (libscfiltlo.so+0x46b354)
        const&, int) :? (libscfiltlo.so+0x46b44a)
        (libscfiltlo.so+0x4764a0)
        :? (libscfiltlo.so+0x4764e9)
        oox::core::ContextHandler2::endFastElement(int) ??:?
        (libooxlo.so+0x1a10eb)
        (libexpwraplo.so+0x2fbdf)
        (libexpwraplo.so+0x2fb21)
        char const*, unsigned char const*, unsigned char const*)
        fastparser.cxx:? (libexpwraplo.so+0x2c255)
        /build/libxml2-vTtzwD/libxml2-2.9.12+dfsg/builddir/main/../../parser.c:9736
        (libxml2.so.2+0x5751a) (BuildId:
        baaa02c136f3351b1c499bbbbe94450b9b9c0d4e)
        /build/libxml2-vTtzwD/libxml2-2.9.12+dfsg/builddir/main/../../parser.c:9691
        (libxml2.so.2+0x5751a)
        sax_fastparser::FastSaxParserImpl::parseStream(com::sun::star::xml::sax::InputSource
        const&) :? (libexpwraplo.so+0x2972d)
        sax_fastparser::FastSaxParser::parseStream(com::sun::star::xml::sax::InputSource
        const&) ??:? (libexpwraplo.so+0x30e88)
        oox::core::FastParser::parseStream(com::sun::star::xml::sax::InputSource
        const&, bool) ??:? (libooxlo.so+0x1a3220)
        oox::core::FastParser::parseStream(com::sun::star::uno::Reference<com::sun::star::io::XInputStream>
        const&, rtl::OUString const&) ??:? (libooxlo.so+0x1a3467)
        oox::core::XmlFilterBase::importFragment(rtl::Reference<oox::core::FragmentHandler>
        const&, oox::core::FastParser&) ??:? (libooxlo.so+0x1c46c1)
        oox::xls::WorkbookHelper::importOoxFragment(rtl::Reference<oox::core::FragmentHandler>
        const&, oox::core::FastParser&) :? (libscfiltlo.so+0x4be642)
        workbookfragment.cxx:? (libscfiltlo.so+0x4b618d)
        (libcomphelper.so+0x15e63b)
        (libuno_salhelpergcc3.so.3+0x5257)
            #25 threadFunc :? (libuno_salhelpergcc3.so.3+0x550e)
        (libuno_sal.so.3+0x67e25)
        
        Change-Id: Idf8d9c307c09bc1af8541178331af23d146da927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130787
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [44a403d5a63b16e04b1c66ded6ef4e3bda605ab3]

        fix data race in ImportFinished
        
        touching these fields here leads to a race with the access in ::Import.
        Rather just leave them to be cleared when the object is destructed.
        
        Change-Id: I0016917455d4e252e360cc49e3d1ca56f4eabb30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6df85675378a5a90b0d89d712015e010f6893c9f]

        fix assert when changing fill on impress shape
        
        reverts part of
            commit 31e7845339b30a69f06a04619660398fe4267268
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Feb 17 12:19:49 2022 +0200
            use more SfxItemSet::CloneAsValue
        
        Change-Id: I5f385525adcdb73199a6eb4b057e275341fb85b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [0d29394598db2e336a9982cbb7041ea407b2bf6d]

        tdf#147126 sw: fix missing as_char anchoring of group textboxes
        
        which resulted lost (invisible) text content before
        implementing its support now.
        
        Cleanup to SwTextBoxHelper by removing its unneeded functions.
        
        testFDO78590 was commented out temporarily because it has a
        pure VML groupshape inside and it's converted to WPG during
        the test run resulting crash on reopening, because lack of
        its support in DocumentContentOperationsManager, trying to
        convert the content to a text frame inside a text frame.
        
        Regression from commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
        "tdf#143574 OOXML export/import of textboxes in group shapes".
        
        Change-Id: Ic6ce3549d390ae763044f54e991f390677704396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129627
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [16665c48fef0ac178f224cccb1ddced69311835c]

        Fix typos
        
        Change-Id: I13e7f1dc5d93f352e79139acb64b46dee298c9fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130186
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-03-01  Jens Carl  <j.carl43@gmx.de>  [26cbb045a06c4027bd7b446d692c3b38297d0283]

        tdf#45904 Move XComponent Java test to C++
        
        Move XComponent Jave tests to C++ for ScCellFieldObj_Cell and
        ScCellFieldObj_Header (formerly ScCellFieldObj).
        
        Change-Id: Ibf293a72801720fee49acdda5a3a463e9202bb58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130742
        Tested-by: Jenkins
        Reviewed-by: Jens Carl <j.carl43@gmx.de>

2022-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [66614d9d1c63ecd957440184e696cd1d71fba96a]

        No need to memset the allocated buffer in new_WithLength
        
        Other places that allocate, specifically newFromStr_WithLength and
        ensureCapacity, don't initialize the memory.
        
        Change-Id: Iad5301313312aac24948afefb27925d52fe3c673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130762
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-01  Tor Lillqvist  <tml@collabora.com>  [6c17a51c0f6f2bf9e8c1132a2d1c96edb404e522]

        Quick build fix: Add missing #include
        
        Change-Id: Ib36aa807c3fbe0678adaaea0d202163d2ac70022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130791
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f9268924f10bbcb6515b2008af37b4920730f3cb]

        Try to fix .bau files being ignored
        
        In some circumstances it might happen that one .bau file gets replaced with
        another one, but the "new" one has an older timestamp than the "old" one.
        
        In this case, the .bau file will not be recognized as changed.
        So instead of checking for a newer timestamp, check for a different timestamp.
        
        Change-Id: I4248fb283d4399a8501a979cae7e6bcc6d8e8a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130243
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [a427a46db0fa453acabe10389e106441031b317e]

        wina11y: Use range-based for
        
        Change-Id: Ie03126205d45ad2fcae14af53ab7a499f3c445f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130759
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [45ae2fb7a7de4da4c3d6c7c359aaf92ccf0688a2]

        wina11y: Use more range-based for
        
        And use const reference to css::style::TabStop instead of
        creating a copy.
        
        Change-Id: I4092cbefcfbdaa6a6697974b7f40242e26cc6aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130758
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [774364243b5541328aa633d7ae535fa4ae716105]

        wina11y: Use 'std::vector::empty()' instead of 'std::vector::size() == 0'
        
        Change-Id: Icc365bad285d99abc2a1c9f26997e28701823262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130757
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-01  Michael Weghorn  <m.weghorn@posteo.de>  [df80ed941621da16459c16eae04f73300a606c9b]

        wina11y: Use range-based for
        
        Change-Id: Icf2a4cb3a4baf0c7aaeb627d05ba355f238b4d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130756
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [9888bb3dbb7ca558e0b440314bdb24bc60843bb0]

        Fix the test failing when invalid certificate is in cert store
        
        testSigningMultipleTimes_ODT was failing for me locally because of
        an expired certificate present in my store.
        
        Change-Id: Ie3dfb9ee1a110259ba747a03fc28c205df2eea91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130743
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [c8ce8980b35edf394d72848fa777de49c37513e1]

        ofz: glyph data must be at least 10 bytes long to be useful
        
        Change-Id: I312c33c598013feced15c6f2dbcc66e493b703e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130752
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [8b95df7d8d4c4b651e169c73508fcd86833229ea]

        ofz: don't register style if hbox load failed
        
        Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb968c4f6bda49eb97014aec5e395232545935ab]

        more tsan suppressions
        
        Change-Id: I58a5f1e23980720615180640529af31205417cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Tibor Nagy  <nagy.tibor2@nisz.hu>  [744e6c0b758fefe6011f09860b44f03ab70fbcfe]

        tdf#147459 PPTX: add "glue points" to some basic shapes
        
        (ellipse, triangle, right triangle, trapezoid,
        parallelogram, diamond, pentagon, hexagon, heptagon,
        octagon).
        
        These glue points allow to add and use connectors
        on basic shapes, e.g. by specifying 8 glue points on
        outline of ellipses (and not 4 glue points only on
        their bounding boxes).
        
        Usage: insert a basic shape from the list above,
        select it, and click on the icon Connectors to
        show and use the new glue points on the outline of
        the shape.
        
        Note: PPTX import doesn't import connectors
        connected to the glue points – only ODP export keeps
        them for the planned editing, i.e. moving the connected
        shapes without losing the connecting lines and arrows.
        
        Change-Id: Iaef21ce8dc3f6677fa2fd6a484adf6d546e72ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130281
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [5911b25000f443d8ab39265e356628b8117f8a73]

        ofz: measure legal range from glyph offset, not table start
        
        Change-Id: I04c1036e004be678b70a7df197141970aa3c8b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130750
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  homeboy445  <akshitsan13@gmail.com>  [1c2dc4bc28a594c15464fdb0f5adaa30baf47af2]

        tdf#145486: Catch the error instead of re-checking readOnly state
        
        Change-Id: I555ccad0fae604133effbcf46bf2cb0ad30ac609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124585
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-03-01  Deep17  <deepoose2011@gmail.com>  [f63a6f2e396fa41ed1338dcec874e06159cafa9f]

        tdf#145538 - Use range based for loops
        
        Change-Id: I489a13330501ddfa1556a523f8334460505c0e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130658
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [2ca987b1a9bcb6bf248d31972b3035fb5e302896]

        ofz: measure maximum possible contours
        
        Change-Id: Ie039abd835fef06514edde12b99e17360f5481a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [2195e03808864a8d5cb3e130f62759684a19d012]

        tsan more suppression
        
        Change-Id: I42f9cb0bc326c7e6e2f26cd0501427b4d4865e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Hossein  <hossein@libreoffice.org>  [acc008c6600070837599c994e5552e66ec85c18c]

        Add asserts to make sure the calculation is correct
        
        On Linux/gcc (Ubuntu 10.3.0-1ubuntu1~20.04), I was getting this
        warning:
        
        sc/source/core/data/bcaslot.cxx:647:25: warning: comparison of
        unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
          647 |             assert(slot >= 0 && slot < mnBcaSlots);
              |                    ~~~~~^~~~
        
        slot variable is of type SCSIZE, which is defined as size_t in
        sc/inc/address.hxx.
        
        This is fixed in 405a7a09558ad17642808cc3739ab202f86bea0c. To make
        sure the calculation of slot is OK, I have added these 2 asserts:
        
            assert(nRow >= rSD.nStartRow);
            assert(nCol >= rSD.nStartCol);
        
        Change-Id: I731c1b6e913febde51fc16042d32c35950e707db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129805
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [fc8e5f91fcf3a63d6bcd29c498e58a67e9abe67f]

        use SfxItemSet::GetItemIfSet in sc/source/ui/view/
        
        Change-Id: I6c1c3ee4fbb6b105ad67c051ce1fa2dae258df85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e157252a2074729d1d89d6b49054dfd74ffe789]

        use SfxItemSet::GetItemIfSet in sc/source/filter
        
        Change-Id: I8ba941cea8f3b8ed0f37d2dc6b2520ae89652afe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130744
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Luboš Luňák  <l.lunak@collabora.com>  [0156eba76667fe1b0ed4355272fa77f98f9f63a4]

        make Calc jumbo sheets an explicit build feature
        
        On 32bit platforms tools::Long is 32bit, which is not enough
        for pixel coordinates with 1m+ Calc rows+. So do not allow jumbo
        sheets for such platforms.
        
        Change-Id: I2ebd56a051470d33fca967918af3e7d2b0172dc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130713
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-03-01  Mike Kaganski  <mike.kaganski@collabora.com>  [da77aec27e3121c895a6c6c287225216489cc8bc]

        Fix flaky test on Win64
        
        Obviously the left values are unstable; they were excluded on macOS,
        and they fail exactly on the same lines for me locally on Win64 build.
        So just test that the values are restored after delete and undo.
        
        Change-Id: I63dc50d223edb052a0ada200189cef94c2e0f8e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130738
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-03-01  Stephan Bergmann  <sbergman@redhat.com>  [4c68c4b93c41c4e9c2d5faf6c02ece2d40e95eb4]

        misaligned-pointer-use
        
        ...during CppunitTest_sw_filters_test,
        
        ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:385:20: runtime error: load of misaligned address 0x61d001aedef7 for type 'const char16_t', which requires 2 byte alignment
        0x61d001aedef7: note: pointer points here
         01 00 00 00 ff  00 00 00 00 00 00 00 00  be be be be be be be be  be be be be be be be be  be be be
                     ^
         #0 in char16_t* std::__copy_move<false, false, std::random_access_iterator_tag>::__copy_m<char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:385:20
         #1 in char16_t* std::__copy_move_a2<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:491:9
         #2 in char16_t* std::__copy_move_a1<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:522:14
         #3 in char16_t* std::__copy_move_a<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:530:3
         #4 in char16_t* std::copy<char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_algobase.h:619:14
         #5 in void rtl::str::Copy<char16_t>(char16_t*, char16_t const*, int) at sal/rtl/strtmpl.hxx:50:5
         #6 in void rtl::str::newFromStr_WithLength<_rtl_uString, char16_t>(_rtl_uString**, char16_t const*, int, int) at sal/rtl/strtmpl.hxx:1054:9
         #7 in rtl_uString_newFromStr_WithLength at sal/rtl/ustring.cxx:1246:5
         #8 in rtl::OUString::OUString(char16_t const*, int) at include/rtl/ustring.hxx:332:9
         #9 in ww8::WW8Struct::getUString(unsigned int, unsigned int) at sw/source/filter/ww8/WW8Sttbf.cxx:87:23
        
        presumably since 22de5757a2c7c6cd4544a4699e5d4c69969f5961 "Deduplicate string
        buffer code" changed the Copy function template in sal/rtl/strtmpl.hxx from
        using memcpy to using std::copy.
        
        (And this revealed that the !OSL_LITENDIAN code had apparently started to rot
        and lacked #include <rtl/ustrbuf.hxx>.)
        
        Change-Id: I3e2c5578c6ca18c8880c6d6b6afd191a91da268d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5a1863e16d209eb40758cd1f77500c6ff945f59]

        use SfxItemSet::GetItemIfSet in sc/source/core/data
        
        Change-Id: I60552d79f484848eef5b0c43de377a1eed5e76b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130737
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [535359269ed23e2faead8e9e905d57cc6121e269]

        use SfxItemSet::GetItemIfSet in svx
        
        Change-Id: I7a56c9452102cf7f6524296219209aef05383d81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Caolán McNamara  <caolanm@redhat.com>  [ca3e12d5b560d27615aeac986f9dbc1258993e65]

        ofz: verify table offsets
        
        Change-Id: I49fa886508b3bf553d4f638bfe53c37fa3e2f338
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1bf33a26b20a2fd0aa941cce5ad40e3737e0eb4]

        use SfxItemSet::GetItemIfSet in starmath
        
        Change-Id: Iaef2a2c507acfdabc6280e6cc8179319ea9d8a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130735
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Stephan Bergmann  <sbergman@redhat.com>  [f8238187bad40d0a4b8eccbae9f99eca4aa10f7a]

        Always join thread before destroying it
        
        m_aDestThread had been added with 7d6c646ec244f9ea1db9b5bd160ecfc43ac27f13
        "INTEGRATION: CWS vcl24", apparently for "#i28763# workaround possibly hanging
        CUPS calls" to address <https://bz.apache.org/ooo/show_bug.cgi?id=28763>
        "Loading document hangs if CUPS printer doesn't deliver PPD" and its duplicate
        <https://bz.apache.org/ooo/show_bug.cgi?id=30513> "OO.o hangs if cupsd hangs".
        
        However, PythonTest_sc_python now occasionally failed for me with a SIGSEGV in
        thread #1 of python.bin at
        
        > Thread 2 (Thread 0x7fc8df392fc0 (LWP 2268774)):
        > #0  0x00007fc8df42ee28 in _int_free () at /lib64/libc.so.6
        > #1  0x00007fc8df431c05 in free () at /lib64/libc.so.6
        > #2  0x00007fc8df7e4fe9 in _PyMem_RawFree (ctx=0x0, ptr=0xff64c0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:127
        > #3  0x00007fc8df7e5af7 in _PyMem_DebugRawFree (ctx=0x7fc8dfb36d88 <_PyMem_Debug>, p=0xff64d0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:2187
        > #4  0x00007fc8df7e5ff0 in PyMem_RawFree (ptr=0xff64d0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:595
        > #5  0x00007fc8df7e5301 in _PyObject_Free (ctx=0x0, p=0xff64d0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:1898
        > #6  0x00007fc8df7e5af7 in _PyMem_DebugRawFree (ctx=0x7fc8dfb36de8 <_PyMem_Debug+96>, p=0xff64e0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:2187
        > #7  0x00007fc8df7e5bb2 in _PyMem_DebugFree (ctx=0x7fc8dfb36de8 <_PyMem_Debug+96>, ptr=0xff64e0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:2318
        > #8  0x00007fc8df7e64c0 in PyObject_Free (ptr=0xff64e0) at workdir/UnpackedTarball/python3/Objects/obmalloc.c:709
        > #9  0x00007fc8df853d8d in unicode_dealloc (unicode=<unknown at remote 0xff64e0>) at workdir/UnpackedTarball/python3/Objects/unicodeobject.c:1879
        > #10 0x00007fc8df7e47b6 in _Py_Dealloc (op=<unknown at remote 0xff64e0>) at workdir/UnpackedTarball/python3/Objects/object.c:2215
        > #11 0x00007fc8df81aeff in _Py_DECREF (filename=0x7fc8dfa46c76 "Objects/unicodeobject.c", lineno=15296, op=<unknown at remote 0xff64e0>) at workdir/UnpackedTarball/python3/Include/object.h:478
        > #12 0x00007fc8df81adc6 in PyUnicode_InternInPlace (p=0x7ffdf1d0b048) at workdir/UnpackedTarball/python3/Objects/unicodeobject.c:15296
        > #13 0x00007fc8df7c7791 in PyDict_SetItemString (v={'__name__': 'sys', '__doc__': "This module provides access to some objects used or maintained by the\ninterpreter and to functions that interact strongly with the interpreter.\n\nDynamic objects:\n\nargv -- command line arguments; argv[0] is the script pathname if known\npath -- module search path; path[0] is the script directory, else ''\nmodules -- dictionary of loaded modules\n\ndisplayhook -- called to show results in an interactive session\nexcepthook -- called to handle any uncaught exception other than SystemExit\n  To customize printing in an interactive session or to install a custom\n  top-level exception handler, assign other functions to replace these.\n\nstdin -- standard input file object; used by input()\nstdout -- standard output file object; used by print()\nstderr -- standard error object; used for error messages\n  By assigning other file objects (or objects that behave like files)\n  to these, it is possible to redirect all of the interpreter's I/O.\n\nlast_type -- type of last uncaught e...(truncated), key=0x7fc8dfa71535 "stdin", item=<_io.TextIOWrapper at remote 0x1079630>) at workdir/UnpackedTarball/python3/Objects/dictobject.c:3416
        > #14 0x00007fc8df92af89 in PyImport_Cleanup () at workdir/UnpackedTarball/python3/Python/import.c:447
        > #15 0x00007fc8df94af6d in Py_FinalizeEx () at workdir/UnpackedTarball/python3/Python/pylifecycle.c:1229
        > #16 0x00007fc8df981f2d in Py_RunMain () at workdir/UnpackedTarball/python3/Modules/main.c:691
        > #17 0x00007fc8df9822fd in pymain_main (args=0x7ffdf1d0b1f0) at workdir/UnpackedTarball/python3/Modules/main.c:719
        > #18 0x00007fc8df982347 in Py_BytesMain (argc=4, argv=0x7ffdf1d0b378) at workdir/UnpackedTarball/python3/Modules/main.c:743
        > #19 0x0000000000401152 in main (argc=4, argv=0x7ffdf1d0b378) at workdir/UnpackedTarball/python3/Programs/python.c:16
        > #20 0x00007fc8df3c1560 in __libc_start_call_main () at /lib64/libc.so.6
        > #21 0x00007fc8df3c160c in __libc_start_main_impl () at /lib64/libc.so.6
        > #22 0x0000000000401065 in _start ()
        >
        > Thread 1 (Thread 0x7fc8be2dc640 (LWP 2269049)):
        > #0  0x00007fc8df424e24 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6
        > #1  0x00007fc8d19a8e57 in osl_acquireMutex(oslMutex) (pMutex=0xcdcdcdcdcdcdcdcd) at sal/osl/unx/mutex.cxx:100
        > #2  0x00007fc8ce0870b8 in osl::Mutex::acquire() (this=0x2b9f120) at include/osl/mutex.hxx:61
        > #3  0x00007fc8ce18a2a3 in osl::Guard<osl::Mutex>::Guard(osl::Mutex&) (this=0x7fc8be2dbd88, t=...) at include/osl/mutex.hxx:142
        > #4  0x00007fc8cec6dbb6 in psp::CUPSManager::runDests() (this=0x2b9ef40) at vcl/unx/generic/printer/cupsmgr.cxx:246
        > #5  0x00007fc8cec6d965 in psp::CUPSManager::runDestThread(void*) (pThis=0x2b9ef40) at vcl/unx/generic/printer/cupsmgr.cxx:223
        > #6  0x00007fc8cec6d7f1 in run_dest_thread_stub(void*) (pThis=0x2b9ef40) at vcl/unx/generic/printer/cupsmgr.cxx:193
        > #7  0x00007fc8d19c9f2d in osl_thread_start_Impl(void*) (pData=0x30a9aa0) at sal/osl/unx/thread.cxx:264
        > #8  0x00007fc8df421b1a in start_thread () at /lib64/libc.so.6
        > #9  0x00007fc8df4a6650 in clone3 () at /lib64/libc.so.6
        
        Hoping that any blocking (if that is even still an issue today) is not
        indefinite, turn this one osl_terminateThread into osl_joinWithThread as already
        used in all the other places (CUPSManager::initialize,
        CUPSManager::checkPrintersChanged).  (Also note that osl_terminateThread was
        effectively a no-op here, as the relevant thread never calls
        osl_scheduleThread.)
        
        Change-Id: Ic9c6d6dba1c42f802e09e95feaa7e4d093b5b2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130732
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-03-01  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [fcfa854db5b81454047e1dde36de781e395dd498]

        Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,
        
        Small Caps icons
        
        Change-Id: I1348cc7fbde63d335ba3676a4c424d76f8cf2349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130733
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-03-01  Gabor Kelemen  <kelemeng@ubuntu.com>  [144057a54a7283bf819de4a19c8067a3b8e2b3bf]

        Recheck modules s[f-t]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I1f520aad1b1c942ad5616d96851016fc366ac58f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130203
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-01  Miklos Vajna  <vmiklos@collabora.com>  [5787a610df7f0e63054c51968c573b539452f67b]

        svx: fix URL and class name in README
        
        It's a bit concerning that this URL was working in 2014, i.e. after
        Apache OpenOffice was established and still got broken, but luckily the
        archive has it.
        
        Change-Id: If79ae0bc861ed855650156d87c7fc052773fb33a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130726
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e85b482df3fa01e5a2b549df63db96cc49f1ca78]

        use SfxItemSet::GetItemIfSet in cui
        
        Change-Id: I0a6dbf50d29adf9da9512a9136709bf563e478f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130689
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [51b995b9861c3415c44f59fa5367347fd7eee255]

        use SfxItemSet::GetItemIfSet in sfx2
        
        Change-Id: I241b038953f61228b6667014a4096bfe8dcc9c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130709
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e13a8c7df2d11814a0a4669aad88e68e27835934]

        use SfxItemSet::GetItemIfSet in desktop..reportdesign
        
        Change-Id: Iaa0ddf4e97866d537a478e668e3c651a9eabc465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130708
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-03-01  Justin Luth  <justin_luth@sil.org>  [5a64b618d84edb65465950d54e3b4afc952a301c]

        followup tdf#122098 xlsx export: avoid corrupt format if not bool value
        
        Although I can't find any documents that cause a "b"
        when the value is not 1 or 0, if such should ever happen,
        then Excel complains about an invalid format and fails to load.
        
        (The formatting looks a bit weird, but that is what clang-format
        produces. How nice.)
        
        Change-Id: I090a27829596260cdd6379b6a6daa75ce250b7e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130734
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-28  Luboš Luňák  <l.lunak@collabora.com>  [2c6f5ebfe69c3031af7b4903637226bd8a3dde62]

        remove obsolete TODO.performance
        
        None of the issues listed is valid anymore.
        
        Change-Id: I3e28753b111b9a8fd0f280684555dff214c158f3

2022-02-28  Stephan Bergmann  <sbergman@redhat.com>  [8597748c42727b62e60f8a4af45520193d682de0]

        Brown paper bag fix
        
        ...of 87369ad7b82da6904e889614c88617e610d4506b "Use std::unreachable if
        available".  (Unfortunately, Clang didn't warn about the thus meaningless uses
        of O3TL_UNREACHABLE, presumably due to
        <https://github.com/llvm/llvm-project/commit/978cca9f49a1c0e3a01096017c9a34726866fbf3>
        "Suppress all -Wunused-value warnings from macro body expansions.")
        
        (While at it, and as the expansion of O3TL_UNREACHABLE is now a nice full
        expression, wrap it in parentheses, as is common best practice for such macro
        definitions.)
        
        Change-Id: I555e6716ebb66172add686521446d90db6054845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130729
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [30c302cf489571ef13579c1ecd27c276945138d0]

        uitest: fix sporadic UITest_impress_demo failures
        
        Revert 9158d2d2f19cf7bccba12d2ad4cb340e882b51cc
        < blind fix for UITest_impress_demo failed >
        and 99d2ee15ad6fae7073a53f7df8868300328a36e7
        < blind fix for UITest_impress_demo failures >
        Instead of asserting the shapes' properties directly,
        Use the Position and Size dialog
        
        Change-Id: Ie9aec0dbd1f1fc2ccab0993b428c8ac17938b3b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130724
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [907a3c0248834f13441ec8c1239b3ca5c016aa5a]

        uitest: simplify tests even more
        
        - No need to open the dialog to click the cancel button
        - Avoid repeated calls to document.DrawPage.getByIndex(0).
        Similar to 26298f29e9d36313be527b785a9bb96089582037
        this might fix the different failures these tests sometimes
        have
        
        Change-Id: I4e175b6c5d48c4651e5877ec2a72c4858b590321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130727
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-28  Luboš Luňák  <l.lunak@collabora.com>  [424de44cd0eba254368d3b867bc440c99b548168]

        make named ranges in tests work with 16k columns
        
        References like 'day1' are valid cell addresses with 16k columns,
        since they go up to XFD1. Since addresses currently take precedence
        over names, rename ranges to not conflict.
        
        Change-Id: Iab63947565ed176c98bc541de6189d7ee9e8d255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130728
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-28  pragat-pandya  <pragat.pandya@gmail.com>  [73ef2f6f615b88ef25366f9073c5fb3db5e76687]

        tdf#139734 removing redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I89ffa387464ce7cc43c1884b031d6fade5b85078
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-28  Jim Raykowski  <raykowj@gmail.com>  [393e8d622e1ebea0eb2ac59274e7216819b7022b]

        SwNavigator: fix cursor positioning on comment context menu 'Edit...'
        
        Makes the cursor end up in the selected comment annotation window
        instead of at the comment anchor position in the document when a
        comment annotation window has the cursor focus and the Comment context
        menu item 'Edit...' is selected.
        
        Change-Id: Iac87177670a1b74525dd03ecce05135c4b89d692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130572
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a810cd97b3d92c7b6ea277fe2e483c223405e88]

        uitest: remove duplicated tests
        
        They are pretty much the same as the other one in the
        same file
        
        Besides, the 'with self.assertRaises(IndexOutOfBoundsException)'
        nonsense
        
        Change-Id: I0ad9aaf80721eb49080d94a34deb43b0bc39724c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130718
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a6a3edaa8b34ead7458a59d00e96c5b38b4de887]

        Fix typo
        
        Change-Id: I9502432260287ae0e6d17231c60f34b4ae2e3729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130722
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-28  Justin Luth  <justin_luth@sil.org>  [6961f6732954742415413fa53bdeebd1b03d9ec5]

        tdf#122471 xlsx import: pivottable error OUString, not uInt8
        
        This fixes a LO 6.0 regression from
        commit 9fa34e9f2cebe2cfc551668f2a67ddcb799d3fb8
        which only half-way changed to OUString from uInt8.
        
        An exception was raised because in XLSX, an INT was written
        while the corresponding read function was expecting an OUString.
        
        However, doing this runs into problems with binary files (xlsb),
        which were still setting the value to an int.
        Unit test shows the need to use OUString for xlsb too,
        which now matches what I see in Excel 2003.
        
        make CppunitTest_sc_pivottable_filters_test \
          CPPUNIT_TEST_NAME=testPivotTableErrorItem2FilterXLSX
        
        Change-Id: I399c9e34984bb1ff71695a87aa56f53063d37b3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130714
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ff49a550df626a4b02869b86f1ca9b9a5a421e44]

        Fix the tests failing when invalid certificate is in cert store
        
        Change-Id: I72055c814a11a76c4934610bcad9c24aae21164e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130690
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-28  Stephan Bergmann  <sbergman@redhat.com>  [0694a66e8e5ad3c83f28a093add009ecc37d500b]

        Fix jurt/source/pipe/staticsalhack.cxx
        
        > jurt/source/pipe/staticsalhack.cxx:62:
        > sal/rtl/ustrbuf.cxx:29:9: error: 'RTL_LOG_STRING_BITS' macro redefined [-Werror,-Wmacro-redefined]
        > #define RTL_LOG_STRING_BITS         16
        >         ^
        > sal/rtl/strbuf.cxx:27:9: note: previous definition is here
        > #define RTL_LOG_STRING_BITS 8
        >         ^
        > In file included from jurt/source/pipe/staticsalhack.cxx:62:
        > sal/rtl/ustrbuf.cxx:29:9: error: duplicate defines [loplugin:duplicatedefines]
        > #define RTL_LOG_STRING_BITS         16
        >         ^
        > sal/rtl/strbuf.cxx:27:9: note: previous define [loplugin:duplicatedefines]
        > #define RTL_LOG_STRING_BITS 8
        >         ^
        
        after 22de5757a2c7c6cd4544a4699e5d4c69969f5961 "Deduplicate string buffer code"
        
        Change-Id: I5e6883effea0ce53c96cb5da8e02142450216ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130711
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [97ca239014e50d26bb2553ebeb96e0bc57e27d2d]

        tdf#146463: chart2_import2: Add unittest
        
        Change-Id: I1c8879eaab8cfc3d623a27d7d5d3d8a9cffb003b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130693
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [7dd7bd7d9ff03fe2038943f5460a95163bec5e04]

        wina11y: Drop another 'using' directive
        
        This is similar to
        Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213
        ("wina11y: Unify how AccessibleRole is referred to here"),
        just for `AccessibleStateType`.
        
        Change-Id: I5e99fad42dab87e0e303e5a08c610f6af77641ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130700
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [3cde1fe16965d2b976c6c1210e81f17ae352b79f]

        wina11y: Unify how AccessibleRole is referred to here
        
        Using
        
            using namespace com::sun::star::accessibility::AccessibleRole;
        
        and then
        
            case /*AccessibleRole::*/DIALOG
        
        looks a bit odd. Drop the `using` directive and
        consistently use `AccessibleRole::<ROLE>` across
        this source file when referring to `AccessibleRole`s.
        
        Change-Id: If4b295548468067c65afcd1a216d29cad9e0c213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130699
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [95e2e5190cf69c5b931639d2b9279e0adbbdaf3b]

        wina11y: Rename IsSpecialToolboItem -> IsSpecialToolbarItem
        
        Change-Id: I972a65783fcb481e91db68e6e58124d46f78ee66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130698
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [6723203528739430974d5c1dd14a26f8d4efcf0a]

        wina11y: Convert unomsaaevent.hxx constants to enum class UnoMSAAEvent
        
        Also drop the previous comments for the constants that add
        little value and are partially outdated.
        See the actual implementation to see how values are mapped
        to send out actual MSAA events, e.g. the previous comment
        
            // CARET_CHANGED --> EVENT_OBJECT_LOCATIONCHANGED
        
        was no longer correct by now, since that is by now mapped to
        `IA2_EVENT_TEXT_CARET_MOVED` in `AccObjectWinManager::NotifyAccEvent`.
        
        Change-Id: I38111ccb60c06f73ce53b18a6ca32e13dbd629b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130697
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-28  Michael Weghorn  <m.weghorn@posteo.de>  [470ed0ff78a8b07d5aa02e0bba97bfa479860cf3]

        wina11y: Drop useless #ifdef block
        
        `ACC_DEBUG` isn't defined anywhere and the
        `pFile` variable/member used inside of the `ifedf`ed block
        doesn't exist either.
        
        Change-Id: I0d04ca71dbc9a731a6673fad9b69c1229c472d16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130696
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [0969f23a2fde82863ece428fbfe81c62a8d8fff8]

        ofz#45117 Integer-overflow
        
        Change-Id: I1827c1bf3e0153d071b354f9b958d5f84bb2d8a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130710
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [42ca32d7a37631dda3fa900ab9f2169234b1f4b3]

        cid#1500397 silence Resource leak
        
        this reverts
        
        commit 1142dc2398de2e2be0e057ecb432ad9c8895313a
        Date:   Sun Feb 27 14:14:18 2022 +0100
        
            cid#1500397: Resource leak
        
        with an alternative that hopefully silences coverity and helps show
        better what is going on
        
        Change-Id: Ifb117d65789e80e66419911dbb6b327bdf7ed948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130707
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  László Németh  <nemeth@numbertext.org>  [a74c51025fa4519caaf461492e4ed8e68bd34885]

        tdf#146962 sw: hide deleted row at deletion in Hide Changes
        
        In Hide Changes mode, deleting table rows with change tracking
        wasn't applied on the table layout immediately, only using Show
        Changes and Hide Changes again. Now the deleted row removed from
        the table instead leaving an empty table row (except the last
        row of a wholly deleted table).
        
        See also commit 95213407dfcbf34056037d60243ff915340d1a2e
        "tdf#146622 sw crash fix: don't delete already deleted rows".
        
        Change-Id: I864957cafa38e631a65db0670c7b566cb689f4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130701
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [6fb261607810fb0d542c0818f60a3f9bead33032]

        check if cast is to the right type
        
        LIBREOFFICE-311XVJ95
        
        Change-Id: I159f516daafad3e4088677fe2c8c6f5423b3e264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [b3267935f5ec1b7376b2040219d3b523c1320a0b]

        Related: tdf#147667 don't toggle radiobutton on mnemonic if it's not unique
        
        which we already do with checkbuttons, and is what gtk also does when
        this arises
        
        Change-Id: I1b5a4c98bd5062f3a340a53a5d6d977a4af3e384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130691
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [a0b6883f06d16892b571655764852c4d6d3200f1]

        cid#1500555 try +taint_sanitize instead of -taint_source
        
        Change-Id: I2a0f9ef243c3f17717afed8809b1e3fbc033c6f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [25bcd30895f8ebd2d47a8bab5a291690cf0e0aba]

        cid#707501 Uninitialized scalar variable
        
        Change-Id: I89f08a858b7a820fce1dd3bc2b914c3e5eb3d656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130703
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [34d3f1601cf2dcb1c931d9454f2a06741f9e8b87]

        cid#707500 Uninitialized scalar variable
        
        Change-Id: I4680b59483ae827cbceb567968dc6c4e864f7ad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130702
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [d83323462452fb793b849758a0d975f3bd353ac9]

        cid#707503 Uninitialized scalar variable
        
        Change-Id: I8e1c27f04d8a2ce2ff4608f97b5ff58c55833a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Tünde Tóth  <toth.tunde@nisz.hu>  [7d6212e218d4d5c76c8bc60983b548a6893fc6a5]

        tdf#103800 PPTX shape import: fix regression of text color
        
        defined by list styles. Properties in a:lstStyle of p:txBody
        should take precedence over the same properties defined in
        a:fontRef of style elements.
        
        Change-Id: I02cc886eb9eba94f49fe413a63bf7c46c9e3c127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130237
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-28  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [f29c14e8c36819296d0c66bb995201acf0a2647e]

        tdf#147121 PPTX: fix regression of font size export of empty lines
        
        If the empty line has got direct formatted font size,
        don't forget to export it, unless the master setting
        is applied.
        
        Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e
        "tdf#111903 tdf#137152 PPTX export: fix placeholders".
        
        Change-Id: If686e487bca9c198fd7c96860a21e4efe91381bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130005
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-28  Tünde Tóth  <toth.tunde@nisz.hu>  [259a8e59107bb0a3d4f4f4bb7e056ce1e4231da2]

        tdf#128596 PPTX import: fix default tiled bitmap fill
        
        OOXML bitmap fill element a:blipFill has got default tiled
        area setting without explicit a:tile in MSO. Previous import
        of bitmap fill as "BitmapMode_NO_REPEAT" instead of
        BitmapMode_REPEAT resulted missing or incomplete area fill
        of shapes and other objects.
        
        Change-Id: Idf94f4450980f67172a0126784b3e08cc5c178c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129483
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [ebf4ba6d4a59b1947a1e5a94c7405693a0960ffa]

        cid#1473807 Untrusted value as argument
        
        rearrange to make it more obvious to coverity that the value of
        ttf->glyphOffset(glyphID + 1) is the same as nNextOffset
        
        and rename the initial use of length to glyflength to make that
        clearer to me
        
        Change-Id: I0e5c53d9929e1e41d500b7c0833b827808b610f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130695
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [f5f3eaa63f24093453af08ad01967ae17f108af2]

        cid#1501377 Dereference after null check
        
        Change-Id: I9dceb5c33f62df16b43429ba502b0d12180fa403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Heiko Tietze  <tietze.heiko@gmail.com>  [bbcf7e197190cdae186b210c5fd94d8eb8dfd133]

        tdf#147667 - Remove hard-coded underscore from UI
        
        Duplicate underscores make the hotkey unusable. While the
        path removes it from the UI it's neccessary to also clean-up
        the translations.
        
        Change-Id: Id8a216c7c928eccebabbac79744cb802c07ae3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130688
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [7375401eab02cb5bca37e2ea8c172b3cc9d413d8]

        Use 'assert' where appropriate
        
        Change-Id: Id7ecf874745fb32406bcd2250a954aaf3a345103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130667
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-28  Miklos Vajna  <vmiklos@collabora.com>  [24732bb12bfe0124d49733701226a34044c001a8]

        sw clearing breaks: add document model
        
        This is meant to represent clearing breaks, as in HTML's <br
        clear="..."> and DOCX's <w:br w:type="textWrapping" w:clear="...">.
        
        The new pool item is in the RES_TXTATR_NOEND section as this property
        can be only specified on a single document model position: linebreak
        characters.
        
        Change-Id: I6c86097a049e489e1292f42fc8446eb7282c816a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130687
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [3a364db18db25a438d1b725db45c698dff23cce6]

        ensure null terminator
        
        LIBREOFFICE-WB8DT2Q9
        
        Change-Id: I98529325bbd3ff475ba84b4991eb17240440df4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Mike Kaganski  <mike.kaganski@collabora.com>  [22de5757a2c7c6cd4544a4699e5d4c69969f5961]

        Deduplicate string buffer code
        
        Change-Id: Ia23974ad3a827c84bb1a5d633a953625aea2576a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130663
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e8d8870890b0a60ef9acc4c43c67688b58a42a3]

        address review comments for "Add XWeak constructor..."
        
        for
            commit 27352b81638f2f1e792ab48ec532eaacf6f61718 (origin/master, origin/HEAD)
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Feb 21 16:00:52 2022 +0200
            Add XWeak constructor and operator= to uno::WeakReference
        
        I accidentally created a new gerrit change for this, and thus managed to
        miss sorting out various review comments.
        
        (*) Fix version number in gcc3.map
        (*) Narrow the interface (i.e. assume non-null parameter) in
        WeakReferenceHelper
        (*) Remove cargo-cult catch and OSL_ASSERT in WeakReferenceHelper
        (*) Remove accidental indentation
        
        Change-Id: I8d1b22dd42216e9293959032d92df65405fb054c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130349
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e23161baf5a529d1006b320e9044e436827c764]

        use SfxItemSet::GetItemIfSet in chart2
        
        Change-Id: I1e5eeb8b29d2139a9c3e72c645bae9a8fb5dffff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6849b3a1593f56790ad22a050d60ec15333ce9af]

        checked signedness of Sfx*IntItem types (part2)
        
        See comments here
        https://lists.freedesktop.org/archives/libreoffice/2022-January/088360.html
        
        Make SfxItemSet::GetItemState check the type of the ppItem pointer
        using TypedWhichId the same way we do for other calls.
        
        Take the opportunity to name the new method GetItemIfSet and change
        the signature to reduce the boilerplate at call sites..
        
        This is just the initial commit, the bulk of the patch (the actual usage)
        will be split into lots of smaller patches to aid bisecting for
        bugs.
        
        Change-Id: I6704059331787c8776f786af764b4ba3478a307b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Caolán McNamara  <caolanm@redhat.com>  [a74a4236e4f4cc957123a9417c7da99b2699b242]

        ofz#44991 keep paragraph's that failed to load until import is complete
        
        to avoid dangling references to them
        
        Change-Id: Ic8710f63a8cf6a6a665348c7c84bf0b43f0e2c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-28  Miklos Vajna  <vmiklos@collabora.com>  [48f18fb66300cbdafd5b03b683e72aecaa0a2e94]

        sw: prefix members of SwNumFormatBase, SwOutlineContent, SwPostItContent ...
        
        ... and SwRegionContent
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib7d6f1eb5b96e4cebcc2f17727e876670869cd14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130662
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-28  Stephan Bergmann  <sbergman@redhat.com>  [87369ad7b82da6904e889614c88617e610d4506b]

        Use std::unreachable if available
        
        Change-Id: I686e36cf3e77a94293ef6923ba00181eb3e02c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130661
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-28  Noel Grandin  <noelgrandin@gmail.com>  [5c6d142f7f1ebffcd5b2b220d0e672401a4178c7]

        remove unused FN_PARAM_TABLE_SPACE
        
        ever since
            commit 7b0b5cdfeed656b279bc32cd929630d5fc25878b
            Date:   Mon Sep 18 16:15:01 2000 +0000
            initial import
        
        Change-Id: I65b6af6ba02bf99e0884694c8a776af4e0d5e49b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Noel Grandin  <noelgrandin@gmail.com>  [4b6424f81dc6e4a4c34b830d6a24f4aa7356a642]

        remove unused FN_PARAM_GRF*
        
        ever since
            commit dec81fe5aa2200b9b351240209fde9434a830c5d
            Date:   Tue May 15 09:03:55 2001 +0000
            #86986# SfxFileDialog/SvxImportGraphicDialog removed
        
        Change-Id: I5d75770dc86e40870abcc8dfe7b62f6711d6aa9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Noel Grandin  <noelgrandin@gmail.com>  [ff81f9aff4f67cedf4cb85de9ce763cb7259795e]

        unwrap data structure in SwCharURLPage
        
        we want to work with SvxMacroTableDtor and we are unnecessarily
        wrapping it in SvxMacroItem. Just use SvxMacroTableDtor directly.
        And remove FN_INET_FIELD_MACRO which is now unused.
        
        Change-Id: I83c0c7b0ecd02b996ddad1a03a0fc0dec6c38c10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Ouyang Leyan  <ouyang.leyan@hotmail.com>  [7c5cfe54357e4e8d08b4696e80741097d3335dcb]

        tdf#146463 Apply data series filter to the chart legend
        
        Consider a data series as hidden if there is no unfiltered value, do not
        consider data labels. It solves a regression introduced when working on
        tdf#134059.
        
        Change-Id: I6072bf469137d70e0aa353ffbeb0d0a1216ffa5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Hossein  <hossein@libreoffice.org>  [637e7ddf1e3091191b6835c7f66c71f014dfaa19]

        Remove redundant _test from i18npool/CppunitTest*
        
        As suggested in <https://gerrit.libreoffice.org/c/core/+/125813>, the
        name of the CppunitTests contain a redundant '_test'. This patch
        removes this additional word from the name of all the CppunitTests in
        i18npool.
        
        The new names for the tests in i18npool are:
        
        CppunitTest_i18npool_break_iterator
        CppunitTest_i18npool_calendar
        CppunitTest_i18npool_characterclassification
        CppunitTest_i18npool_defaultnumberingprovider (unchanged)
        CppunitTest_i18npool_ordinalsuffix
        CppunitTest_i18npool_textsearch
        
        Change-Id: Ie613c0048a7f156c7d815620f2ccb6578c069e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130542
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-28  Noel Grandin  <noelgrandin@gmail.com>  [61fd5f3419c79d1d8ad5fabab61b88c01bc0322e]

        FN_PARAM_NUM_LEVEL is dead
        
        since
            commit 3514ad82c4200be292ef6eaa1e94c5c6a41884e4
            Date:   Mon Dec 10 10:02:46 2012 +0100
            sw: unused SwRTFParser
        
        Change-Id: Ib437a3b3a59883869aaec35f3c70403d04bcd950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-28  Jens Carl  <j.carl43@gmx.de>  [a1877ab81b396c742c58a13d3830b4637db924c0]

        tdf#45904 Move XElementAccess Java test to C++
        
        Move XElementAccess Java test to C++ for ScHeaderFieldsObj.
        
        Change-Id: I1bc29be9f17d117edecfd889b4f9784ffbd74d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130660
        Tested-by: Jenkins
        Reviewed-by: Jens Carl <j.carl43@gmx.de>

2022-02-28  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [694d031fe470683a2f8e0fd3ae443fc829b6e26d]

        Colibre: tdf#137520 Revise Text Capitalization, color and Strikethrough icons
        
        Change-Id: If055a997abd26b59b3a5852d289d793f8cd5850c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130659
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [aafd4c8431aa511511375ff39f87a7f8bde726e0]

        tdf#135233: Useless looking translatable string: "error text goes here"
        
        Change-Id: I7e25ea89594b8b71e9009d8e9227e039aff8ee32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130657
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2022-02-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [53b11d3fe61b64b5a996a10d2d0491626c7fc5e4]

        Colibre: tdf#147686 Fix arrow of Text Direction icons (large size)
        
        Change-Id: I5e70cc6d4439ca80dd53851f4d710628aa90fd2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130647
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [d71aa209aec6adbd273497e240ae447e81ed9c05]

        ofz#45090 Null-dereference READ
        
        Change-Id: I74c1c0d1a090dbd763336fec845e29d6cc0065f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130651
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [f36a582dc24816d23bf0629b72a15cac22b42870]

        add translator notes for "Key", the K of the CYMK color model
        
        and so on
        
        Change-Id: Ia1104f5c92becee8e94c4e2988203149e6b1406d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [293cd13fd6cd59bea13be5dc032aa3b36f25e1cf]

        resave with latest glade
        
        Change-Id: If9dfbe8199993a400563bae51f5afbfaea293cb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [dc42e6989713e2790eeedb37ae1c3b4f342ec528]

        Use STR_INSTALLATION_WIZARD tooin instsetoo_native/sdkoo part
        
        Change-Id: I3a26ad7efabffc317448f3636ea98853217baf6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130652
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Jenkins

2022-02-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [31e7845339b30a69f06a04619660398fe4267268]

        use more SfxItemSet::CloneAsValue
        
        to reduce heap allocations
        
        Change-Id: Ia755c3e7f9610a5441a447cc74ea38ebcef068bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [c97a3592c78ce276a353f95ce68c70a8a39174a0]

        ofz#45090 Null-dereference
        
        Change-Id: I53ec35a8fe19511429004c8a94aee1bfadb55a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130648
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [b457e8df493aa3ccd380eba481d6996ae342b931]

        cid#1500380: silence Resource leak
        
        Change-Id: Ib938b921343359b91f42fc68d89bf9eda32132d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130626
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [1142dc2398de2e2be0e057ecb432ad9c8895313a]

        cid#1500397: Resource leak
        
        Change-Id: I765df1eef9ccf447cdd0a80497c1ca6f22bb9e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130625
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [d25142d2c33dea9fa9332a0cbc07694129ce48ed]

        ofz#45082 Out-of-memory
        
        Change-Id: I274a6beeec0013f5b974017500fe31bcecabfa86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130623
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [da95bafdacf100a7c44b39a8621eea1e2d409693]

        ofz#45081 check font length
        
        Change-Id: Ib8cea70652ae90403db3546c07d24a517b1ec93e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130621
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Jean-Pierre Ledure  <jp@ledure.be>  [740329373b2fe2c4f7c18ff1921e2f100d49a6bf]

        ScriptForge - (SF_Platform) add the FilterNames property
        
        The FilterNames property returns, as an unsorted zero-based
        array of strings, the list of available/installed import
        and export filters for components.
        
        The property can serve as support for the FilterName
        argument used for opening and saving documents.
        
        The FilterNames property is available both from Basic
        and Python user scripts.
        
        Change-Id: I607500b56836ceeb6716b10d39d22638b0741f3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130624
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [794f3a07b94d134c0393b5f804b8afaca3e20e59]

        cid#1500627: Resource leak
        
        All the memory cleaning seems still useful even when nOldSize = 0
        
        Change-Id: Ie5a9c5e5895f545b9c352dc337141116e33e7dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130622
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [a59e62abbd48a9e69dcfea574a84e70bd6983015]

        More replacement functions deduplication
        
        Change-Id: I700074cddf1be937f5fdaf90e6cc0b533a3c57ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130633
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [f074daffc2dcaf8ccca4bd0a7fd61b8b0d53ad03]

        ofz#45073 initialize names to NULL in case of 0 glyphs
        
        Change-Id: Ie410d2a6f3d2fcda19b1925675bd7515673b07a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [f1c6a16bf450d1f28c918dd8362969b9e5a841e4]

        ofz#45073 don't dereference null pointer on bogus font
        
        Change-Id: I28616696833b87c300d2ee7061a15921042934b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130613
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [4ca4c5ea49ddb1b00127c5ea8066215533b96c63]

        ofz#44991 keep within legal ArrowShape range
        
        Change-Id: I6bf70f27a66ba9b355a3f7ae0c68a696a7284871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Caolán McNamara  <caolanm@redhat.com>  [846e02fbac63eebab33819c3a8a1460d4df07279]

        ofz#44991 don't skip over terminator
        
        Change-Id: Ibc942705a788db60c104d00916a45d595596285e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130610
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [a8815905278e9df47bb0aea80affc2c30055b316]

        cid#1500496: Uninitialized pointer read
        
        Values retrieved from SmMlAttribute::setDefaultAttributeValue in case SmMlAttributeValueType::MlMaxsize
        see https://opengrok.libreoffice.org/xref/core/starmath/source/mathml/attribute.cxx?r=ffaaec23#94
        
        Change-Id: Ie36254157da7ce85223ca71e2070fbd075b52699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130620
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-02-27  Eike Rathke  <erack@redhat.com>  [42bb97c06ec326c7e136e01bcd1a88031700b1b1]

        Revert "Related: tdf#147448 Scope owning mutex before it gets destroyed"
        
        This reverts commit dcd042c6f28276d707af409a87a1a4380398e9b0.
        
        Reason for revert:
        Revisiting, it was wrong to put that protector in its own scope because the actual mutex lock is only held in its ctor and it does SetAllowRefresh(true) in dtor, so while it exists it prevents other refresh timers to execute.
        
        Change-Id: I058c1359c19971dba59a9273a7a8cddd77ece37f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130556
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        (cherry picked from commit 7aae1d338aaf454b99c7354aca78951e26043b2b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130566
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [fc6c2c752d711dd6113441659ec046032e2c6f80]

        Typo: attributte->attribute
        
        Change-Id: Ic90047599effeea7d4959f9d44360361d87b98c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130619
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [0112fd253483b7b8fcb90e845e0c58ef53ce88ee]

        Unify creation of character string copy
        
        Change-Id: Ifef89cfd98771f247a308fab58da410a7079ecfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130632
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-27  Julien Nabet  <serval2412@yahoo.fr>  [54e7ac4a8aa5bda78f1c41093fc0d10a56313305]

        tdf#145829: typo ERRCODE_UUI_IO_MODULESIZEEXCEEDED ("basic" instead of "BASIC")
        
        Change-Id: I0dc23d9aadd727efb3a9acb2f5361505afe8233e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130618
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-27  Luboš Luňák  <l.lunak@collabora.com>  [265bfa9fc0b732a8df9d75ad2c34b68440539665]

        fix inverted condition
        
        Logic says that 'contains' should be '!empty()'. And checking history
        shows that 94d76cef1f71056fab106caf4cc8e65504475615 inverted
        the condition presumably by mistake.
        
        Change-Id: I6c0ddc6486a5fb89eb39b93e32ee52d478c05927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130543
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [7b8671d7b58a2a70c641f8315dc506542e8266cc]

        Deduplicate newToAscii*Case
        
        Change-Id: I55f4f43375037ad4247f592bc981d8718c12de68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130631
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [bedb7118f5ca2cd19f4bc1eac1b26498ee5ef113]

        Simplify newTrim
        
        Change-Id: I36e2f8b0f0f4829fba32e637fe61cebe9e67cf91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130630
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-27  Luboš Luňák  <l.lunak@collabora.com>  [77ebac1021e1e795b6c6a7456a2ed8c56dd9370c]

        prefix CellInfo and BasicCellInfo with Sc
        
        CellInfo is a pretty generic term to be used in the global namespace.
        
        Change-Id: I9a2ce6b7b2157f75d7213321c615fc9636817252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130608
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-27  Luboš Luňák  <l.lunak@collabora.com>  [694148a9898b47d749588f9a32173a9933262e29]

        do not allocate so many CellInfo objects in FillInfo()
        
        FillInfo() is used for drawing to screen, so it's given a range
        of rows and columns, but drawing also depends on all cells
        to the left (e.g. their width, for position), so it allocated
        CellInfo for all columns starting from 0. But with many columns
        this can easily mean allocating and initializing a large amount
        of memory, easily 90MiB with a maximized window and going to XFD1,
        and handling all that can be slow enough to be seen when moving
        around.
        
        Since only few of the CellInfo fields are actually needed for all
        columns, split them into a separate smaller BasicCellInfo, and
        allocate CellInfo only for columns that need it. And exception
        is the nRotMaxCol code (for rotated cells?), which accesses more
        of the fields, so for that case allocate the same way as before.
        
        Change-Id: I2f0f2a9c27b1a8b74b70fc2d208d0689e16ee1a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130607
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-27  Mike Kaganski  <mike.kaganski@collabora.com>  [2126968ffbceb3c6f05db29c26ec90975e3f6331]

        Deduplicate more comparison functions
        
        Change-Id: I93aba36b7cde268e358bd96b55183533ddc70b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130603
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-27  Jim Raykowski  <raykowj@gmail.com>  [5df0289f6af5aa7142017b56a8e17c134d54fe41]

        tdf#147565 Make navigate by comments skip hidden comments
        
        Change-Id: I80f55146529505e5b6146db8cc324971fbc475e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130518
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [61105658881ac0b05b2d92a3a6723a7b6a6f1d72]

        Colibre: tdf#137520 Adjust some icons size to make them balance
        
        Change-Id: I168b00b5132742984520486535c391a7a46a902f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130615
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [03ef44a8f3c392486acd7d42a5854c7594ff50b1]

        Colibre: tdf#137520 Adjust some icons size to make them balance (large size)
        
        Change-Id: Id16f53d867b4487399e33a548e623950a1b76197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130616
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-27  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c189137f846399fbf30099592efc8750682f6d97]

        Sukapura: Make Emphasis Character Style icons slimmer
        
        Change-Id: Ib4a5497d0393be4b08fcdc2eafa6ab6332623bc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130617
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2a403801576543a7254edd41d6919c8c57c34f9e]

        Sukapura: tdf#147664 Shrink some icons to make them balance
        
        Change-Id: Iae3145b67b7eece42be8ec82967f4750d4e66956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130602
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-26  Johnny_M  <klasse@partyheld.de>  [de9480a3225209902919294306dbf00ff105e999]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dd0acce907394934a9323fc2d34290f1db74f166
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5a45f355b77d899a24ae346ceedf10fcb882d420
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130589
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [2bf8623d46f1d5b5beb495954a99318b9e69f7f9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 671306d813dbf9546aac2963cc84a0a56e587d80
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iafebe7e8c835f8fcdaf206f078d92ac4234443c4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130588
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [f516c685fbb51bf16258338425ac0bc3478cabe6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93d42d6384221b98d93dd5730cdd99082961c99c
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibca93fc3f787797cb9f085bba04d3db63231be7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130587
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [1d831d89cbe7143d17cbfd25749eb024f9a84239]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c16c09e9672fe032e965197b2431682274d9cf08
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibaeee3ea64bdc2c42d83607a624f864103468d72
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130586
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [5d484a3fd17677f2966fbb02946683b3ba18f14b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0bbeaceff9f8d9c4c636d27ded4546c7b0533fba
          - tdf#132643 Translate German section IDs
            
            Change-Id: If62f841f29d15ddbd143541a56488412384ca5b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130585
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [0b65a3bda5cc3a83f80f7da2bb7765ef5de9d34b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3851aac7a173686b5c74f2b744e3e7732905713b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0ceb0df437e37d91f0c84898bb2880fd3651de3f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130584
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [f503e567f8fc6ead3d280686b8a1d020653bd114]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13bc989cc1e90d627387bf4a4b18804662c1f8eb
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iec56c3f7338fb8abbdfdd5bbb118fd10b10df616
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130583
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [17db94f1e8425d6ccd430eeda3ec17b4acd1a3d9]

        do not repeatedly call ColHidden()
        
        The function returns the last column that has the same return value,
        so reuse the return value until that column.
        
        Change-Id: I5d19478ee37068049d4ff035efcacdb5eb724e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130606
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [f6a9910623cdeb30b7c0a8dc712153a11658e43d]

        ofz#44991 Use-of-uninitialized-value
        
        Change-Id: I0e3bcce489b665bac3e470e743394935a2ba3a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [e58d1b535bd7f0e30d41d72242cfe9f41ce8cd19]

        cid#708598 Uninitialized scalar field
        
        Change-Id: I35ee291afe6af5a20e7fca3e03af9cbc0d1d6b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [d4bb147320f381010f25c9232f4147406c443fbf]

        cid#1362689 Uninitialized scalar field
        
        Change-Id: I14bb8fce8bb2d8aa744463da4a065dec6a15f3ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [9c6a2a63fcca8d60f19e40d7c7125c38ee943ca0]

        cid#1500406 Uninitialized scalar field
        
        Change-Id: I1e2de80f8943d2bfe288b8ddcabd376561269d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [2e2bd25b4a13758745aa9ae687c5d94a0f32bb6e]

        cid#1500566 Uninitialized scalar field
        
        Change-Id: Idd0e3d461f84a5ec476d77fde9c8ab03b4dbbbd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [50cd7345dbafdf612f796fad8083e7ec0c7ace0c]

        cid#1500568 Uninitialized scalar field
        
        Change-Id: I0d6fb3b378d890daf5efbef588fdb0fe40fb625d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [caf833b67c03c419322c88732d4eed7cdaf55cc0]

        cid#1500598 Uninitialized scalar field
        
        Change-Id: I732117dae2b383356dc58b5f47e52f6e722e991d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [b6b9c6ebf66c1fa8f35d82d149aa108d91a86ba0]

        cid#1500651 Uninitialized scalar field
        
        Change-Id: If22e0931c13c6945640264c55edb1af52b2c4187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130594
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [dc3d27c53e5c8149571025a031857973783a9248]

        cid#1500706 Uninitialized scalar field
        
        Change-Id: I2546ea6880ad1cdb4312ca1c1251dbf6758ff5ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130593
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [10d8ba5fa6fac708c960278454ba403a95e355c3]

        cid#1500433 Using a moved object
        
        Change-Id: I150cd0f021aeb1aefe411f19dfcac111ac35b295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [dfa791941ee13bd06adc91ed097c44b65a995a14]

        cid#1500582 Uninitialized scalar variable
        
        Change-Id: Idec4ce43f99be60658a6e60cff73dd6702bb3d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [ad4692357b2d32ab10301576031a60ff68b51482]

        cid#1500670 Uninitialized scalar variable
        
        Change-Id: Ib4b873194c6db55212a5b786322b2a6d45277369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130590
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [d2fea40762d5d9ee918edcb4ff281e362df92c5d]

        optimize ScColumns::HasCellNotes()
        
        This probably doesn't matter much for optimized code, but in dbgutil
        builds this avoids all the libstdc++ iterators mutex locking (WTH
        does libstdc++ debug mode need to lock anything?). It's functionally
        equivalent (similarly to ScColumn::IsEmptyData(), and the container
        can contain only notes or empty elements), and cuts run time of e.g.
        sc_uicalc test to about a half.
        
        Change-Id: Ibb2bd8be522de889a8a06cbb7a4f880c9b065c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130604
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [dcf98b570fc33bc9ee3bdf5591c6cc92cfbf3aa1]

        ScCompressedArray doesn't need to be polymorphic
        
        It's value-based, and only inherited by ScBitMaskCompressedArray,
        which is also value-based and doesn't need a virtual destructor.
        
        Change-Id: I0814702107d50208aaff19690c989a501d2c4e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130605
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [61abbc2f9698f48bf92ec102952cd6b4fcc536d1]

        do not fail import if there are only warnings
        
        When opening CVE-2012-4233-4.xls or ofz5527-1.xls in LO UI, they
        show a warning about too many columns (presumably because Excel
        as of now supports 16k and LO only 1k columns by default), but
        besides stripping the extra columns they otherwise actually load
        normally. But ScFiltersTest::testCVEs() fails loading them
        just because of the warning. And if 16k columns are forced
        for the tests, the files unexpectedly load fine, making the test
        fail.
        
        ScDocShell::ConvertFrom() is rather inconsistent on whether
        only a warning results in a failed load or not, but most seem
        not to return failure on only warnings, and I think that makes
        sense, so make code paths for all formats consistently handle
        it that way.
        
        Change-Id: I202f29f5a5a44aecd34b84cf2f8180222e8d870a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130500
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Johnny_M  <klasse@partyheld.de>  [07edff135cc1b6f9a0abd3c5728fe2130b454937]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 24d491106fb6efa1e226551b8ca92264b1a09281
          - tdf#132643 Translate German section IDs
            
            Change-Id: I888e28c0e8c77e69c4153a95eadc07232fbeb293
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130582
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [2daf05a8515ddb31c9e4e64520a6f8394d2d6e14]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e084a58c1a941f9defe01396b496e56a8acbecdd
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idafc722094d13c95122cc376191f797a852430d6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130581
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [a43468cfadbe9c19f2a5145fa9724bd567685e2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d97d3a3135f825eaecb3aece0bd93cb347d3f4a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idb087b11111314e6ad5e95d6d50ccedecd9c2505
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130580
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [a70c13cc6be1ae5a5be74cefc4d5f4a5267a6b04]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4063bdcebeb42fd1a654fdc19c998bd84637d000
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2da4b42f16959ca61ad8c1fe7394611321b4814f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130579
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [4064cc45f7d153e5bbbde1132a67b0916ecba509]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 178cd79839e3ec1503344e699393e152ec4c6688
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iaa17f488790847c5b842b36eef48a072b50ecfd2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130578
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [f854df5b71616e7d65db9c512fac0469bdec2ee9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 868364196d941115bd03521780945e662091cb02
          - tdf#132643 Translate German section IDs
            
            Change-Id: I75d36228f91622990cba0eaefbe9ece19dcd9d00
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130577
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Johnny_M  <klasse@partyheld.de>  [188c47aaa2fd9ac35f692801992436bfbeb9ef70]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c986cbece97bc46a7c665140a4f3fa4459d6518
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id022d237801f6f763a8f50c58a1e99f5e05eedd9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130576
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [20b301efef0fce7c92b9fac9e62d38cbfe10529f]

        cid#1500663 std::move a sal_uInt16 and then return the original is unorthodox
        
        Change-Id: I7d3dcc6f6e625baab702ea16cd72ec85d213f8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130546
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [4946efd9b9ea532bc3b54f45f412424d1bbe70b0]

        Video preview doesn't redraw if the preview image changes
        
        because there is no check to see if the preview changed here.
        
        But because (bizarely?) Graphic::operator== returns true when the lhs is
        an empty graphic regardless of the rhs due to:
        
        bool ImpGraphic::operator==(const ImpGraphic& rImpGraphic) const
        {
            ///
            switch( meType )
            {
                case GRAPHIC_NONE:
                    bRet = true;
                break;
            ...
            }
        
            return bRet;
        }
        
        don't use that and instead just compare if the graphics contain
        something or not which is sufficient for my needs
        
        Change-Id: Ia3266e289b3a42ee30bdb9523bac29fb73f5e341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [fbd33571cd8f54161669abc6b696f6ebd085d70a]

        cid#1500654 Using a moved object
        
        Change-Id: Ia4b74cdeeae7f0c03e7e050be30714f948c67106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130567
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Caolán McNamara  <caolanm@redhat.com>  [779d659d990b584bf22498a3beb4bf2832b7a6f0]

        cid#1500452 Using a moved object
        
        and
        
        cid#1500429 Using a moved object
        
        Change-Id: Iecd989345cc043149ff1a2e24da4f6070c014c6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130568
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5fdf99ab0d09a5701db9f06299918ea76983bd92]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 692bb1647cfa5a6f6e7b83ffa803e4f35df1d5ba
          - Fix typos
            
            Change-Id: I429340ab93861fe38c80bdcd97daf0dbd661ab84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130536
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [643b592fcff3fd1bf537b985e6a2bf943767dfa9]

        make VBAMacroTest::testVba() pass with huge sheets
        
        One test checked for the last cell being $IV$8 or $AMJ$8. Simply
        add $XFD$8 to the list of possible values.
        
        Change-Id: I96685c4404b3281d64622380e7d42614adb1c041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130570
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Luboš Luňák  <l.lunak@collabora.com>  [4a896078a332c0270276e9a89b01f415e2238b27]

        lock paint when VBA sets value for a number of Calc cells
        
        VBAMacroTest::testVba() spends the majority of time repeatedly
        repainting.
        
        Change-Id: Iea69221834b80b0fbe484ee3ec5f64ba9e28e37d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130569
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-26  Mike Kaganski  <mike.kaganski@collabora.com>  [6819ff8549d0a247e9e16f98eddbb7abd287d123]

        Slightly cleanup newReplaceStrAt
        
        Change-Id: I230aa635aa797038055bdbc9453a5daa98412f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130465
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-26  Eike Rathke  <erack@redhat.com>  [aaa75591b0c0c7b097e2794a0b24ec7d0e0fa07f]

        Related: tdf#147448 Scope owning mutex before it gets destroyed
        
        Change-Id: I9bacffe1d075431427fb3bf01e4bf30ba6fbc201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130574
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-26  Eike Rathke  <erack@redhat.com>  [4361ee2585e616cb3c504eb719deca4076de78da]

        Resolves: tdf#147448 ScRefreshTimerControl mutex must be std::recursive_mutex
        
        ScRefreshTimer::Invoke() locks the mutex and subsequent nested
        locks are attempted in ScDocShell::ConvertFrom() and
        ScDocShellModificator ctor by ScRefreshTimerProtector.
        
        A std::mutex must not be owned by the calling thread when a lock
        is attempted, otherwise even deadlocks may occur, as was the case
        here. This is exactly the difference of std::recursive_mutex.
        
        Likely a regression from
        
            commit 287680683ca266f1fb4f447ac9bdaf76669d559d
            CommitDate: Mon Aug 2 12:17:07 2021 +0200
        
                osl::Mutex->std::mutex in ScRefreshTimer
        
        Change-Id: Iaa0f1da2b4b9616e9627d8d0001775f554756048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130573
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-26  Kohei Yoshida  <kohei@libreoffice.org>  [974bf22680b702b9474d4a91dbf1d06a785ff774]

        tdf#147298: Add a simple test case for formula cell tracking by column.
        
        Change-Id: Ibdd72c08f8660ade511fdce8b3fb7cd3ed97f4b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130511
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-02-25  Hossein  <hossein@libreoffice.org>  [ad65aa4391e00ee578595d0301f572f7384c1612]

        Add documentation for xmlsecurity
        
        * Add basic information
        * Add some references
        
        Change-Id: Id036c23f90f53c36052b155f62f68e0000e0266f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130289
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [cbb1241ebb7488aa584825645d399b7ee83272fb]

        Slightly optimize newReplaceAllFromIndex
        
        Change-Id: Ie73a5e8c44458123ef03096e3e8f6c9e41c48814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130466
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [ffb2e5520eff008d4e784fa6b15f4e2baa534e7a]

        Deduplicate rtl_uString_newReplaceFirst*
        
        Change-Id: I6e09fd8e8acc06290423c1c44cc0c175b0c47e0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130547
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [7025ca508b427fdf5eee7410d7e636adac9f0a94]

        Make an -fsanitize=undefined workaround conditional
        
        ...that had been introduced with b5cb4935c268f12e63b61e035b455b0a59e67aa2 "Work
        around undef conversion of large double to float" but should no longer be
        necessary with
        <https://github.com/llvm/llvm-project/commit/9e52c43090f8cd980167bbd2719878ae36bcf6b5>
        "Treat the range of representable values of floating-point types as [-inf, +inf]
        not as [-max, +max]" added towards Clang 9.
        
        Thanks to Mike Kaganski for pointing me at this old code and at Richard Smith's
        comment at
        <https://cplusplusmusings.wordpress.com/2013/03/26/testing-libc-with-fsanitizeundefined/>.
        
        Change-Id: I8ecf115fcf6b1ebf621cb4567f8d31ac9b10ef1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130531
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Michael Stahl  <michael.stahl@allotropia.de>  [b14bb255199e7d6db6ec9155b5d9237cb35fdba7]

        tdf#143239 sw: layout: invalidate fly position when moving off page
        
        It's possible that flags on the fly are all valid when it is moved off page
        when SwLayAction::FormatContent() returns and then it may not be positioned
        again, keeping its (wrong) position on the old page and will appear to be
        invisible unless you click on it.
        
        (regression from commits c799de145f7e289f31e3669646e5bd12814e6c5e
         and eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf)
        
        Change-Id: If07d5af7b47eb288bef71d1b9e3459197b50fdc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130535
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-25  Luboš Luňák  <l.lunak@collabora.com>  [d9a17ca961d65b01b4c5c036ecb11b10a3ff414b]

        convert more MAXCOLCOUNT/MAXROWCOUNT
        
        And add GetMax{Col|Row}Count() directly to ScDocument, and also
        add MAX{COL|ROW}COUNT_JUMBO.
        
        Change-Id: Ib92cfbf65dd7cbe87230b02b8916e7cc50fcdbc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130529
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-25  Caolán McNamara  <caolanm@redhat.com>  [237a5e5121a6f12981eb6e4c5a138fc8cfa1c3cf]

        do more work in sftfuzzer
        
        Change-Id: I8a0ae472988f9166dc35eea561a9d5d7084563e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-25  Julien Nabet  <serval2412@yahoo.fr>  [cccd241391438a381311cd7aeccfdb5ad52ee906]

        Typo: STR_ObjNameSingulDIAGAM->STR_ObjNameSingulDIAGRAM
        
        Change-Id: Ifbaa0623de02ce514c0cd551331bec445a9b7e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130540
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-25  Hossein  <hossein@libreoffice.org>  [0308e48e46cee2f56a6239c8479d26185146d74a]

        tdf#145759 30.6001 -> monthDaysWithoutJanFeb
        
        30.6001 shows month days without Jan and Feb.
        According to the below link, it is calcuated as (365-31-28)/10 = 30.6
        but because of a floating point bug, it was used as 30.6001 as a
        workaround.
        
        "30.6001, 25 year old hack?"
        https://www.hpmuseum.org/cgi-sys/cgiwrap/hpmuseum/archv011.cgi?read=31650
        
        The value 30.6 is used as i18nutil::monthDaysWithoutJanFeb here
        instead of 30.6001. The new value is ~30.60000038 which is > 30.6, so
        the calculations should be correct. In order to make sure, a unit test
        is added, and part of the values are checked against the values
        calculated by this website:
        
        Julian Day and Civil Date Calculator
        https://core2.gsfc.nasa.gov/time/julian.html
        
        Change-Id: I8cc7e046514dc3de652a1c37399e351cb2b614dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125813
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-25  Justin Luth  <justin_luth@sil.org>  [9cd4da63b6ed19b71a2475fccb4ab135f0a87873]

        tdf#147404 sc AutoFillPreview: consider hidden cells
        
        Back in the days before LO 3.6, only filtered cells
        were skipped by autoFill. But when hidden cells were
        also skipped, the preview function wasn't updated to look
        for hidden cells instead of filtered cells.
        (I said "instead" because filtered cells are also
        considered to be hidden, so it encompasses both cases.)
        
        Change-Id: I38b230361f0f0f1722873bbdd2c870d55b77bd06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129912
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-25  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [419fa8b13eef10297a5fd44012e89fd7af53cf9d]

        Advanced Diagram support: Support Diagram info at ObjName
        
        Change-Id: I30b1ca95d09ec73d3c21503cc3506141e845bac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130537
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [40f2aee6584eafcf4cd1d95fcf1f775e5435440d]

        Provide unoidl-write also for the SDK
        
        ...after the new types.rdb format that unoidl-write generates has been used
        internally since LibreOffice 4.1 in 2013; following up on
        6db34b6b33ba8e3b13683efd05df8441b87e9c92 "Directly build UNOIDL .rdb files from
        .idl files" and its "The legacy tools idlc, regcompare, regmerge, and regview
        are still contained in the URE or SDK for now."
        
        The tools idlc and regmerge are deprecated but still shipped in the SDK for now.
        The plan is to drop them completely for LO 7.5.
        
        odk/examples/ and ure/source/uretest/ are adapted to use unoidl-write instead of
        idlc and regmerge:
        
        * unoidl-write does not use a C preprocessor and the # directives in .idl files,
          it supports reading a single .idl file (containing an arbitrary number of
          declarations) or a directory tree where each directory corresponds to a UNOIDL
          module of the same name and each .idl file contains the declaration of the
          (non-module) UNOIDL entity of the same name.  For some of the odk/examples/,
          that required moving individual .idl files into sub-directories named after
          the respective modules.  In odk/settings/std.mk, definitinos of IDL and
          REGMERGE have been replaced with a new UNOIDLWRITE.
        
        * unoidl-write always enforces reserved UNOIDL identifier restrictions (see
          04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL
          identifiers across offapi" and 620179240670bd00f60555f1f5c5b0268492f97c
          "Enforce the UNOIDL identifier scheme") (which idlc only enforced optionally
          with -cid -we).  That required renaming "my_module" in
          odk/examples/DevelopersGuide/Components/CppComponent/.
        
        * The new types.rdb format is not compatibly with LibreOffice < 4.1.  Clients
          generating extensions containing such files are advised to use appropriate
          LibreOffice-minimal-version elements.
        
        Change-Id: I1a248fd96e86ecbf407f829bc100d44bfe7f4e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130533
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [72f836fb0c0c3daaf0e47832809a352888577905]

        Don't invent another strlen
        
        Change-Id: I7f7b7029ac03b1f06f4d9c2612b9b008b033baea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130538
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-25  Caolán McNamara  <caolanm@redhat.com>  [71080060ec5f19c1499e17784ae8ae617d9b8142]

        lastPoint might be 0xFFFF
        
        LIBREOFFICE-KYYAZMB9
        
        Change-Id: Ic0d95bd39a01dc1e5e0fec83dcc2c40b3f23b747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130534
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-25  Kohei Yoshida  <kohei@libreoffice.org>  [8f25d42938977b34f3281238a92fb34ebea5838c]

        tdf#147298: When swapping the cell stores, swap back the event handlers.
        
        Swapping the cell stores also swap the event handlers stored therein.
        But we do want the event handlers to stay with the original column
        instances as they store pointers to their host column instances.
        
        Change-Id: Id35b89db641e94dbaa341b33d0b64dce19a99465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130510
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Tested-by: Kohei Yoshida <kohei@libreoffice.org>

2022-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [33a49a99c76ca1879dbb0202384aa939a6d44a75]

        uitest: introduce wait_until_file_is_available
        
        For export - import tests
        See https://gerrit.libreoffice.org/c/core/+/124654/5/sw/qa/uitest/writer_tests6/edit_file_properties_before_saving.py#91
        
        Change-Id: I3c2537a43cc69067355f18162d6463e268420090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130530
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-25  Justin Luth  <justin_luth@sil.org>  [a24eac37fbf8a325b09c3b575c568621a696a560]

        tdf#81894 sc spelling: re-close EditView if not spelling error
        
        In order to check if there is a spelling error,
        the code had to open an EditView. If there was no spelling error
        at the mouse pointer, then stop edit mode again before showing
        the context menu so the full popup is shown, not just the edit one.
        
        1.) Open LOv4304.ods from bug 81894 comment 6.
        2.) right click on "The" in B3
        
        Since we haven't been in edit mode, it should show the full
        format popup. Before this patch series, that is what happened,
        so this follow-up patch is critical to preventing a regression.
        
        This patch makes use of a variable created in earlier patches
        to fix other issues related to right-click spelling.
        
        Change-Id: Ia9713e9654c1f74bc926d51fe8bc5180a8265c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130300
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-25  Justin Luth  <justin_luth@sil.org>  [bdea5805c0344cbddb5c68d1fd19d3cd3b6e3afd]

        tdf#81894 sc spelling: close EditView when moving outside cell
        
        In a previous patch, we noted that instead of a spelling suggestion,
        a popup was displayed. This patch handles that unfinished business.
        
        1.) Open LOv4304.ods from bug 81894 comment 6.
        2.) double-click on cell B4 (to enter edit mode)
        3.) right click on "spellng" which appears to be in D4
        
        Before any of the patches, this did nothing.
        After the first base patch, it was showing the format popup.
        Now it offers a spelling suggestion.
        
        [By running EnterHandler, we are accepting any changes made
         so far in editing mode. That is consistent with what happens
         if a left-click selects a different cell.]
        
        Change-Id: I23876a26861b695dc46efa42f6c3fed6fdb8da6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130299
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-25  Justin Luth  <justin_luth@sil.org>  [8238b887ccecb425f17166d2380afb208bbfdfbb]

        tdf#81894 sc spelling: choose correct cell when in edit mode
        
        In edit mode, text that is too large to fit inside the cell
        will expand to cover other columns (or rows if cell wraps).
        GetPosFromPixel doesn't account for this, so it needs to
        be done separately. (SHOULD the function itself take this
        into account? Probably, but it is used a LOT,
        so I'm afraid to mess with it.)
        
        This patch fixes two situations in bug 81894 comment 25's example.
        1.) Open Francewhoa---2017-May-29---speadsheet.ods
        2.) Double click on A1 to enter edit mode.
        Notice that the cell expands to cover A1:A3.
        3.) Right click on "productivityy".
        
        Before the patch, the spell check was inspecting empty cell A2,
        and thus showed the edit popup.
        With the patch, the spell check is using cell A1,
        and thus provides spelling suggestions, as expected.
        [This patch depends on this bug report's prior comit.]
        
        4.) Look at B3 and notice misspelled words spilling over from A3.
        Double click on B3 to enter edit mode.
        5.) Right click on the position where the misspelled word had been.
        
        Before the patch, a spelling suggestion was provided,
        even though we right-clicked on an empty place in a different col.
        After the patch, we get the normal edit popup.
        
        Change-Id: I58fbf60711a5c010263b525a96383a805be1b3ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130298
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-25  Justin Luth  <justin_luth@sil.org>  [cf18038c66075f7a18d89e47f3a2ab1a5bf7c4fd]

        tdf#81894 sc spelling: eliminate separate(inaccurate) check
        
        ExecuteSpellPopup is quite accurate at identifying whether
        the spelling at PosPixel is a spelling error or not.
        If it is not a misspelled word, then it just silently returns.
        
        If we make this a bDone flag, then it will just move
        on to the normal right-click dialog.
        
        There are a few additional scenarios that need to be
        handled (mainly in terms of showing the edit-mode menu
        instead of the full format menu, and also not
        always returning the correct row/col when in edit mode).
        I will do them in separate patches so that
        each edge case can be clearly seen and handled.
        They all rely on this patch being applied first.
        
        This is the base patch. Too many things simply don't
        work with the interim check, so I removed it.
        (Part of the problem is that EditView kicks on and off,
        and then a new CompleteOnlineSpelling needs to be run before
        IsWrongSpelledWordAtPos can return a meaningful answer.)
        
        This patch specifically fixes the problem of not
        opening SpellPopup on a misspelled word in a wrapped-cell.
        Steps to reproduce:
        1.) Open LOv4304.ods from bug 81894 comment 6.
        2.) Right-click on "spellng" in cell B12.
        
        Before the patch, a full format popup was displayed
        (not in edit mode) because IsSpellErrorAtPos returned
        false, when it should have been true.
        
        With this patch, spelling suggestions are provided.
        
        As an example of an edge case, also notice:
        3.) double-click on cell B4 (to enter edit mode)
        4.) right click on "spellng" which appears to be in D4
        
        Before the patch, nothing happened at all,
        but with the patch at least the fall-back menu is displayed.
        (EditView never switches out of cell B,
        so SpellPopup is looking at wrong information.)
        
        Change-Id: I91d413debc58de832dc7413034618e9e2bae3dd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130297
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-25  Luboš Luňák  <l.lunak@collabora.com>  [6c49b4290955ef1b3a502b4e5e223a4fd5573683]

        make sure that LOK "updated types" start a timer as well
        
        273a25c796fca9afa0dfadac57dc3f336831221c changed the handling of LOK
        messages to only set up an "updated" flag for types and then
        when flushing the value is fetched. This means that queue() is not
        called for such updates, and so the timeout to flush the messages
        wasn't started.
        
        Change-Id: I3a7324c86a55697f509f80b6c54cb949fb1daa72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130526
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6abf6449e26bb1e1da382ddbe769cd14463467f]

        tdf#142423: sw_uiwriter3: Add unittest
        
        Change-Id: I9b0b53a171689b7b67030010700c6bd7c6dfe4eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130521
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-25  Luboš Luňák  <l.lunak@collabora.com>  [d721bdf53687a0e5b280f29479a55fafd354b4f6]

        don't try to delete unallocated columns
        
        Change-Id: I1508f9eb624a78946f5216078953ce8f95e566b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130522
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [acbd88e677502e12ccaea39330efc5885db0a153]

        uitest: unify code and use while True everywhere
        
        No need for MAX_WAIT anymore
        
        Change-Id: Ia063068bd7c47f79d8991922086c22250c01f77d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130527
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [b1d500e8a4eadb72d0e574f77ebf33fbc5701900]

        Drop support for $host_os = 'macos*', in addition to 'darwin*'
        
        ...which had originally been added with baab4f890c8ac99d1b8dab5790fbb7ab949100ab
        "Initial WIP steps for building for macOS on Apple Silicon" for unclear reasons
        (just stating "use 'darwin' (or 'macos')" in the commit message), and then
        further improved with 5a0991c9cd60b6ab10fe0665511e7749a0c0ecc2 "mac: allow cross
        compiling with host/build x86_64-apple-macos".
        
        But it turns out that manually specifying --host or --build =...-macos rather
        than =...-darwin has issues as discussed in the comments at
        <https://gerrit.libreoffice.org/c/core/+/130353> "icu: override platform flags
        for MacOS build", and which can hopefully be avoided by not allowing =...-macos
        in the first place, and rather forcing people to specify =...-darwin.
        
        Change-Id: Ib100b7270250083eba4146430e967073a8cbca46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130505
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa95913dd8e505123ba8974d5de27ac0ec928cce]

        uitest: remove debug option
        
        it does nothing
        
        Change-Id: I6fa67aa42b1de6199cbb49100624826f5b3b77d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130524
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [48119cf42acef33dedcbba92d3bfb8cf8c9938d1]

        Upgrade external/boost to latest Boost 1.78.0
        
        <https://dev-www.libreoffice.org/src/boost_1_78_0.tar.xz> has been generated (on
        Fedora 35) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.78.0/source/boost_1_78_0.tar.bz2
        > --2022-02-24 12:05:39--  https://boostorg.jfrog.io/artifactory/main/release/1.78.0/source/boost_1_78_0.tar.bz2
        > $ printf '8681f175d4bdb26c52222665793eef08490d7758529330f98d3b29dd0735bccc boost_1_78_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_78_0.html>
        > boost_1_78_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_78_0.tar.bz2
        > Unpacking boost_1_78_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_78_0.tar.xz ...
        > Cleaning up ...
        > 0df00d3699c2c7c7fd490c5e165a3e72641861ea5d26428de2f008fb9a75659f  boost_1_78_0.tar.xz
        > Done.
        
        external/boost/boost_1_60_0.undef.warning.patch was obsoleted by
        <https://github.com/boostorg/config/commit/9e80993844cb3d69bfdfa10f059706d7f22eb324>
        "Define __clang_major___WORKAROUND_GUARD"
        
        Change-Id: I7e59ef01ace4ff3c28a285e978e63279b119b07d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130514
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Caolán McNamara  <caolanm@redhat.com>  [9d432faade9281b1211577f9e9a2d65d46ecbdb1]

        set the dialog contents to be approx 50 characters wide
        
        which is what was used in the original effort of...
        
        commit ebc07e1bde64a37ebe9c4326cfea7fbffd94f099
        Date:   Thu Jul 13 16:02:57 2006 +0000
        
            INTEGRATION: CWS jsc7 (1.1.2); FILE ADDED
        
        this dialog can be see on clicking through to the end of the
        installation process triggered with
        
        ./instdir/program/soffice desktop/test/deployment/dependencies/unknown-dependency.oxt
        
        Change-Id: Ice4908422858299c1f8d2be20d892c3100c4c7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130516
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-25  Caolán McNamara  <caolanm@redhat.com>  [8811dd76f02bce0425d784770af8c283db216ee9]

        replace mysterious 0x0C with more meaningful FrameSearchFlag
        
        Change-Id: Id95879ed04b844d939062f0d6a21b4ab508b9d73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [02caa6e40cfa55d96befc82515b343045b5cfd7b]

        renames in template manager creates xml file in wrong location
        
        revert part of
            commit dd42f133f604ee2f7e0ffbca6a8d94fb8f95dfe5
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Mon Jan 10 19:37:05 2022 +0200
            tdf#146375 Cannot rename user-defined categories in template manager
        
        specifically, revert the
        
        >    Simplify the UCB usage to just write the contents of the tempfile
        
        and also call SvStream::Flush() in utl::TempFile::GetURL(), so that
        the data actually hits the disk, so that when UCB attempts to read
        the data using a separate file handle, it sees the data.
        
        (Otherwise the temporary file data only exists in the operating system
        buffers, and can only be read by the same file handle that created it)
        
        Change-Id: I17798c53e49d65484605f2dcd96b45babd70054d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-25  Luboš Luňák  <l.lunak@collabora.com>  [612e7d52f8fda6ddb1c42fc51b123844810fdb9a]

        fix copy&paste mistake
        
        Introduced in bc734289e5542a0ffa04c0ac3cd1aa7cb1810be0.
        
        Change-Id: I5b844e579d6ebfb7be5edaa15944a6df1af66394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130517
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-25  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [e835c2c0d3aff4f1ee5d29c9eaf36400b1aca6a7]

        tdf#146597 sw: fix freezing with GroupShape
        
        in case it is anchored to character and wrap is none.
        
        Regression from 8da3586cff9cc11cf5db985d19851f21f0d42eb8
        "tdf#141220 sw: fix textbox popped out of off-page shape".
        
        Note: This is a backport-compatible fix made also for the
        7.3 backport. There will be a less urgent 7.4-only fix
        for its unresolved group case soon.
        
        Change-Id: I421c85e2dd16ad2649bc299fc4733d462be8d7b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130478
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [f58e351ff05e95fd42b4c108bf0be496be855b46]

        Use some rtl functions
        
        Change-Id: I12fe2f5fe447e2bc6567e3d0375f1671e781697e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130515
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-25  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [ec635b62af9424eddb32cc4646bc425559f4a622]

        Advanced Diagram support: cleanup/consolidate with existing code
        
        Reorganized and streamlined, use IDiagramHelper as main interface
        now also for existing code.
        
        Had to adapt oox::Shape && Diagram handling since there the
        import gets handled very different. This ensures that a Diagram
        is detected at export and that the same happens for now as before
        
        Had to add a detection that resetting the GrabBag is meant to
        disable the Diagam functionality. That is very indirect, but
        has to stay for compaibility reasons for now
        
        Change-Id: I620b7d61cd84b5f9dd8ae4dc890ebf70ce779cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130389
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [56c871c247b84d7c2cddf685c13e8355db50da46]

        Clarify comments
        
        ...originally introduced with a24a980424ec2ec81b13c8e5a95394d62cbf7406 "Make
        visibility tests work as intended on Mac OS X"
        
        Change-Id: I21eb6dc902e2c7c4c04eb2ed16c24dddf943fabc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130513
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Mike Kaganski  <mike.kaganski@collabora.com>  [8d7516a0e690fb34b894b8f064a47d705100a56f]

        Deduplicate some comparison functions
        
        Change-Id: Iffeb4323c99649d45387981ec583fdcff207ec4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130512
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-25  Miklos Vajna  <vmiklos@collabora.com>  [c2cf1b01d5bed68c572ca73b32c6f92d6723562c]

        sw HTML export: allow setting filter data keys from the cmdline
        
        For example to produce bitmaps for shape that look better with hidpi:
        
        soffice --convert-to 'html:HTML (StarWriter):{"ShapeDPI":{"type":"long","value":"192"}}' test.odt
        
        Change-Id: I2654f894d0c20b2cab381e8c6688ec7b13c6e11f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130509
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [a24889a4c9a11688904dbc4df688a418380ed6bb]

        Update the reference rdbs to libreoffice-7.3.0.3
        
        LD_LIBRARY_PATH=.../master/instdir/program \
         .../master/workdir/LinkTarget/Executable/unoidl-read --published \
         .../libreoffice-7.3.0.3/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        * no changes
        
        LD_LIBRARY_PATH=.../master/instdir/program \
         .../master/workdir/LinkTarget/Executable/unoidl-read --published \
         .../libreoffice-7.3.0.3/instdir/program/types.rdb \
         .../libreoffice-7.3.0.3/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: I7478040fee62a3d6b86de3492d9b25cad91cef40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130504
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-25  Stephan Bergmann  <sbergman@redhat.com>  [9c431f4d3afed0aad21b5ba67a5a55328c4d0685]

        Don't use Library_tl in URE libraries
        
        This partly reverts 8b5e23eac31cafbd442a3acab5fbcf98bfd0af11 "log nice exception
        messages whereever possible", e1eb7cb04a4c30cec238ab0f54d41a6cdc3299c1
        "loplugin:logexceptionnicely in starmath..svgio",
        d6d80c4e1783b4459bd4a8fbcbdfeebe416c1cb5 "OSL_FAIL.*exception ->
        TOOLS_WARN_EXCEPTION", and 877f40ac3f2add2b6dc37bae280d4d98dd102286 "tdf#42949
        Fix new IWYU warnings in directories [h-r]*", and adapts
        loplugin:logexceptionnicely accordingly.
        
        Change-Id: I792b853b988c7c5f77179ca0672c30cb4223b5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130502
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea25606de5f1a60430a74107b0e2e0986ac1bb15]

        uitest: check the value and not the text
        
        This fails for me with
        
        AssertionError: '90%' != '90\xa0%'
        - 90%
        + 90 %
        
        Change-Id: Ieec52a4aff721705451a0545eb606c97235b1248
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130507
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [8e8236500ce862ce27acbbfc7bbeab545931798e]

        uitest: try harder to close the dialog when it fails ...
        
        ... and close_button is empty
        
        This was introduced in
        
        2021-06-29 15:35:55 - ff641dc9e4d2aff1d1cbe4425cd9c03a2edc847e
        < uitest: try harder to close the dialog when it fails... >
        
        and later reverted in
        
        2021-07-02 20:41:50 - 4f8748fc973acdb67790ff048a247717afa9b9c7
        < Revert "uitest: try harder to close the dialog when it fails..." >
        
        Reintroduce it again and also fix the problem why it was reverted.
        Without this fix, it will hang when an assert is triggered inside
        a dialog when close_button is empty
        
        Change-Id: If643caea61139f69f72c9b429aaad5b9d7d78c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130506
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [2baf13e903164e92af6c87346e368043bbd09b28]

        use more TypedWhichId
        
        Change-Id: I6ab3ca829bc08e672736dd8dd41ba714d7172090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [089ce740f9f97f9c7b13e37a31acfc94984e9a3e]

        Deduplicate rtl_*String_newConcat*L
        
        Change-Id: I9712cd8a2798fe5493dffd557e68239d9db3b7aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130501
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-24  Miklos Vajna  <vmiklos@collabora.com>  [1127c63470096f62394f133c61cee2e6fb7fd0c7]

        ODT import: fix MSO-style <text:list text:continue-numbering="true">
        
        The ODF spec says that text:continue-numbering="true" should only
        continue the numbering in case the styles of the previous and the
        current list match.
        
        In contrast, Word continues the numbering even in case there is e.g.
        numbering, then bullets, then numbering again, in case the list styles of
        the two numberings are the same.
        
        Work this around at import time when the generator confirms that the
        document is coming from Word. At least Office 2019 and the latest
        renderer at office.com is affected.
        
        (I've mailed dochelp@microsoft, no answer yet.)
        
        Change-Id: Ib63e14322e5501a6220f798abd9365d7913dab4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130503
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-24  Stephan Bergmann  <sbergman@redhat.com>  [3469f6976c9435d1235315439e95beb9494bd8eb]

        Bump macOS build baseline to Xcode 12.5 and macOS 11.0
        
        ...as announced at
        <https://lists.freedesktop.org/archives/libreoffice/2022-January/088320.html>
        "Bump macOS build baseline to Xcode 12.5 and macOS 11.0 [was:
        std::optional::value]".  (The immediate benefit is that std::optional::value can
        now be used and no longer triggers bogus "'value' is unavailable: introduced in
        macOS 10.14" errors depending on which version of Xcode is being used; see
        <https://lists.freedesktop.org/archives/libreoffice/2022-January/088314.html>
        "std::optional::value" for details.)
        
        Change-Id: I819d8dfebabefc22c6af275154df0ff52ca77f5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128384
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [81b88be38651ae871f68f6a0425da56a12494ae2]

        cid#1500712 silence Explicit null dereferenced
        
        Change-Id: I5f7fc843fadfde9f1807350fc879ecea22d4817f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [ed5503ba4ef2952b5fbc1195692076e858597baa]

        Deduplicate rtl_*str_valueOf{Float,Double}
        
        Change-Id: Ie3254fbf6178f4e623fd8209b58e9f19d2c46d2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130480
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [c6cbf970943e17da5d95fc730fa1c15637caee05]

        Fix warning text
        
        Change-Id: I42d0b3a19809a288630cfba6c01bcd5c4fde7702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130454
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-24  Mike Kaganski  <mike.kaganski@collabora.com>  [b927f636a0992b750c6a8de8bb8e9cc5e98a0e33]

        Deduplicate valueOf*Int*
        
        Change-Id: Ib9da148c371f52ee8da2848581bb8a024f97de96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130479
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [14b219547dff8ed1c998a045f14cb1d9eed485c5]

        cid#1500677 Dereference after null check
        
        Change-Id: Ie6eacd21943939e586cdc6712757f34825f17913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130486
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [ede3fc1de7b21f9ba0c529e739cf32bf82c1924e]

        ofz#44997 Use-of-uninitialized-value
        
        Change-Id: I3803232ddc7346967e22770ae2bdbc3378779f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [eaef857346e08d504c25ab1e9112a335f10cd345]

        ofz#44990 Null-dereference
        
        Change-Id: Ia3af8b544f778698702552e42a5daa5269617916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130477
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Stephan Bergmann  <sbergman@redhat.com>  [602576cb86aff3b32f1781090d4a43af6ec193d8]

        Update README lists of URE dynamic libraries
        
        ...after 3a009c427fc04c0a1a100f5f04516cedd1f6f118 "fdo#60698: Merge all libs of
        io..." and 475e4b477c6d7ae114c3ae51ba4872882af67a68 "Move i18nlangtag lib to
        URELIB"
        
        Change-Id: Idf46dc1a8fa80417aac091e907ba54e83f9099e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130489
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-24  Stephan Bergmann  <sbergman@redhat.com>  [48b3894f74679a1624a92aabaabed29b90ef60cf]

        Keep URE libraries out of Library_merged
        
        ...to keep the (at least conceptional, but also reflected in how e.g. Linux
        distros split up LO into multiple packages) distinction between URE and LO
        proper.  This partially reverts 424a7f404565e068995e2a9827d5bc6f76920ec8 "add
        some more libs to libmerged".
        
        Change-Id: I0bd435d9fe4dc4a4ad230990a999ad5e8c487cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130490
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [e63ad6a1363a8bd0c40e8a84073c2f6b22f1e953]

        cid#1500434 Dereference after null check
        
        Change-Id: I10d7c70c40a41301752854b898d8d763ec6d6b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130485
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [50fa3055ad53f9e1f93c90e2119261dc6fa879a2]

        cid#1500555 try -taint_source function annotation tag on function body
        
        Change-Id: Iecc87e118e5c5a85ae40e1ae79348883ea328d8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130482
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [bba6fad408a32580c4bd8eb2e4155bd36f11544b]

        cid#1500415 silence Explicit null dereferenced
        
        Change-Id: Ia4f0e427d293bd514ef7b0db8513869ebf278ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [6c2e9d6bf457a7ca2cd39dd0fba110f5831cedc4]

        cid#1500708 Dereference after null check
        
        and
        
        cid#1500691 Dereference after null check
        
        Change-Id: I4117e925fd8cb3323eb5335e9a6da98bfc8fb592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [f0aae45de103fb4f7b6a514a9ee2749ea4613215]

        cid#1455690 Explicit null dereferenced
        
        Change-Id: I1a5c666fa1f99cd0dc86975c60fc2bf54ceefd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Heiko Tietze  <tietze.heiko@gmail.com>  [3c94c670fa3c3a4e00e88de7463c5e35f32b866e]

        Resolves tdf#142423 - Use absolute values for Writer styles
        
        Avoid rounding trouble when converting to DOCX
        
        Change-Id: Ie30f66671654b64b0b2596b14dc89d6f9befa8d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130475
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [7d2785e37fee0b55c3751d94336320495b0b408e]

        ofz#44992 Null-dereference
        
        Change-Id: I8b0251644769b490da97e6b0f97a320279f926f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130473
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Regina Henschel  <rb.henschel@t-online.de>  [c893c0e359b82be71107e064bd2266c6daff81d7]

        tdf#147580 use valid values for extrusion-specularity
        
        The fix for tdf#145700 has changed the internal handling so, that
        values larger than 100% from MS binary import are now kept und correctly
        used. But ODF 1.2 and 1.3 have the range restricted to
        zeroToHundredPercent.
        
        The patch writes values larger than 100% in extended namespace for our
        'ODF 1.3 extended'. It writes draw:extrusion-specularity in any case, so
        that older versions get a meaninful value, but clamps it to [0,100] if
        necessary to get valid files.
        
        Change-Id: I98298d5c3e3367ffe4a45cdc051be23679308119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130306
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-24  Szymon Kłos  <szymon.klos@collabora.com>  [cf2449aac0141711a7610d67f7c50cd108e12443]

        tdf#72776 Allow text removal in the shapes
        
        Previous fix had crafted condition for fixing one specific
        case but it was braking other cases.
        (svx/source/unodraw/unoshtxt.cxx)
        
        For example it was not possible to remove text inside textbox
        and save that -> it was not saved in LOK case.
        
        Problem is that we had not saved text inside shape and due
        to calling GetBackgroundTextForwarder() we did reset to
        empty content. In this patch we force UpdateData() call
        by releasing lock just before we try to do some final
        text cursor operations what applies changes in the content
        and prevents us from losing it.
        
        Call which was invoking GetBackgroundTextForwarder() was:
        file: xmloff/source/draw/ximpshap.cxx
        method: SdXMLShapeContext::endFastElement
        line: mxCursor->gotoEnd( false );
        
        After that I found that we had bug which breaks test:
        sd/qa/unit/import-tests.cxx    odp/shapes-test.odp
        It occurs when using this patch or when not using my code
        but removing locking functionality for SvxTextEditSourceImpl.
        NbcSetOutlinerParaObjectForText triggers shape resizing
        even when no text is present inside.
        
        Summary:
        1. revert hack from https://git.libreoffice.org/core/+/71b66b0039819f38c935b4eb5d5951ceaf6e8468%5E%21
        2. trigger text update by releasing lock for a moment to keep
           correct state
        3. fix bug with resizing empty shape
        
        Change-Id: Idf1fc6caf19dfb932ce7caa21034f76fa04ce5f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130474
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [76e11015a877da0eee21bb97b84a0f17bce41760]

        tdf#147609 and ofz#44965 Indirect-leak
        
        Change-Id: I2fb89bf68d8df2da1b97942d70c386f62f61c64f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130413
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-24  Stephan Bergmann  <sbergman@redhat.com>  [ba2a0eb8807409ed67af70ab828f45b69fe66c48]

        Don't run ExternalExecutable_python with LD_LIBRARY_PATH
        
        257bcb1a1140d3e070cfaef6fec0704740bc83b8 "get internal python invocations
        working" had made this use LD_LIBRARY_PATH or similar on the various platforms,
        but without giving any reason what it would actually be good for.
        5d8f48c81eac8650315b936d0e89ad1d54b566fc "solver doesn't solve anything..." then
        (somewhat by chance?) removed it for solenv/gbuild/platform/macosx.mk,
        apparently without loss of functionality, but left it intact for other
        platforms.
        
        But at least in some Jenkins Linux build environments presence of
        LD_LIBRARY_PATH (pointing at instdir/program/) appears to cause subtle problems:
        Builds like <https://ci.libreoffice.org/job/lo_tb_master_linux/49844/>
        occasionally crashed with
        
        [...]
        > make -O
        [...]
        > [build PAT] python3
        > [build PRJ] python3
        [...]
        > [build PKG] python3
        > [build EPK] python3
        [...]
        > [build BIN] python3
        [...]
        > [build MOD] python3
        [...]
        > [build PRJ] nss
        [...]
        > make[1]: *** Deleting file '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors'
        > [build UIA] sfx
        > Suppression file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr
        > False positive file: /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.false
        > sfx2/uiconfig/ui/documentinfopage.ui: WARNING: 'GtkLabel' 'label8' does not specify what it labels within 'interface'
        > 1 new warning (64 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them)
        > 0 new fatals (12 suppressed by /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/sanitizers/ui/sfx.suppr, please fix them)
        > Explanations are available on https://wiki.documentfoundation.org/Development/Accessibility
        >
        > /bin/sh: line 1: 31655 Segmentation fault      (core dumped) LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}"$I/program:$I/program" PYTHONHOME="$I/program/python-core-3.8.12" PYTHONPATH="${PYPATH:+$PYPATH:}$I/program/python-core-3.8.12/lib:$I/program/python-core-3.8.12/lib/lib-dynload" $I/program/python.bin $S/bin/gla11y -P $S/ -f $S/solenv/sanitizers/ui/sfx.false -s $S/solenv/sanitizers/ui/sfx.suppr --widgets-suffixignored +ValueSet,HBox,VBox,ToolBox,Preview,PreviewWin,PreviewWindow,PrevWindow --widgets-button +svtlo-ManagedMenuButton --fatal-all --not-fatal-type duplicate-mnemonic --not-fatal-type labelled-by-and-mnemonic --not-fatal-type orphan-label -o $W/UIConfig/sfx.a11yerrors $S/sfx2/uiconfig/ui/alienwarndialog.ui $S/sfx2/uiconfig/ui/addtargetdialog.ui $S/sfx2/uiconfig/ui/autoredactdialog.ui $S/sfx2/uiconfig/ui/bookmarkdialog.ui $S/sfx2/uiconfig/ui/bookmarkmenu.ui $S/sfx2/uiconfig/ui/charmapcontrol.ui $S/sfx2/uiconfig/ui/charviewmenu.ui $S/sfx2/uiconfig/ui/checkin.ui $S/sfx2/uiconfig/ui/classificationbox.ui $S/sfx2/uiconfig/ui/cmisinfopage.ui $S/sfx2/uiconfig/ui/cmisline.ui $S/sfx2/uiconfig/ui/commandpopup.ui $S/sfx2/uiconfig/ui/custominfopage.ui $S/sfx2/uiconfig/ui/deck.ui $S/sfx2/uiconfig/ui/descriptioninfopage.ui $S/sfx2/uiconfig/ui/developmenttool.ui $S/sfx2/uiconfig/ui/devtoolsmenu.ui $S/sfx2/uiconfig/ui/documentfontspage.ui $S/sfx2/uiconfig/ui/documentinfopage.ui $S/sfx2/uiconfig/ui/documentpropertiesdialog.ui $S/sfx2/uiconfig/ui/editdocumentdialog.ui $S/sfx2/uiconfig/ui/editdurationdialog.ui $S/sfx2/uiconfig/ui/emojicontrol.ui $S/sfx2/uiconfig/ui/extrabutton.ui $S/sfx2/uiconfig/ui/errorfindemaildialog.ui $S/sfx2/uiconfig/ui/floatingrecord.ui $S/sfx2/uiconfig/ui/helpbookmarkpage.ui $S/sfx2/uiconfig/ui/helpcontrol.ui $S/sfx2/uiconfig/ui/helpcontentpage.ui $S/sfx2/uiconfig/ui/helpindexpage.ui $S/sfx2/uiconfig/ui/helpmanual.ui $S/sfx2/uiconfig/ui/helpsearchpage.ui $S/sfx2/uiconfig/ui/helpwindow.ui $S/sfx2/uiconfig/ui/infobar.ui $S/sfx2/uiconfig/ui/inputdialog.ui $S/sfx2/uiconfig/ui/licensedialog.ui $S/sfx2/uiconfig/ui/linefragment.ui $S/sfx2/uiconfig/ui/linkeditdialog.ui $S/sfx2/uiconfig/ui/loadtemplatedialog.ui $S/sfx2/uiconfig/ui/managestylepage.ui $S/sfx2/uiconfig/ui/navigator.ui $S/sfx2/uiconfig/ui/newstyle.ui $S/sfx2/uiconfig/ui/notebookbar.ui $S/sfx2/uiconfig/ui/optprintpage.ui $S/sfx2/uiconfig/ui/panel.ui $S/sfx2/uiconfig/ui/password.ui $S/sfx2/uiconfig/ui/notebookbarpopup.ui $S/sfx2/uiconfig/ui/printeroptionsdialog.ui $S/sfx2/uiconfig/ui/querysavedialog.ui $S/sfx2/uiconfig/ui/saveastemplatedlg.ui $S/sfx2/uiconfig/ui/safemodequerydialog.ui $S/sfx2/uiconfig/ui/searchdialog.ui $S/sfx2/uiconfig/ui/securityinfopage.ui $S/sfx2/uiconfig/ui/singletabdialog.ui $S/sfx2/uiconfig/ui/startcenter.ui $S/sfx2/uiconfig/ui/stylecontextmenu.ui $S/sfx2/uiconfig/ui/tabbar.ui $S/sfx2/uiconfig/ui/tabbarcontents.ui $S/sfx2/uiconfig/ui/tabbutton.ui $S/sfx2/uiconfig/ui/templatedlg.ui $S/sfx2/uiconfig/ui/templatecategorydlg.ui $S/sfx2/uiconfig/ui/templatepanel.ui $S/sfx2/uiconfig/ui/urlbox.ui $S/sfx2/uiconfig/ui/versionsofdialog.ui $S/sfx2/uiconfig/ui/versioncommentdialog.ui $S/sfx2/uiconfig/ui/versionscmis.ui
        > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/solenv/gbuild/UIConfig.mk:157: recipe for target '/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors' failed
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_tb_master_linux/workdir/UIConfig/sfx.a11yerrors] Error 139
        > make[1]: *** Waiting for unfinished jobs....
        
        where the crashed instdir/program/python.bin is at
        
        > (gdb) thread apply all backtrace
        >
        > Thread 1 (Thread 0x2af0920e1a40 (LWP 30414)):
        > #0  0x0000000000000ae0 in ?? ()
        > #1  0x00002af0920b008a in _dl_fini () from /lib64/ld-linux-x86-64.so.2
        > #2  0x00002af093404ce9 in __run_exit_handlers () from /lib64/libc.so.6
        > #3  0x00002af093404d37 in exit () from /lib64/libc.so.6
        > #4  0x00002af0933ed55c in __libc_start_main () from /lib64/libc.so.6
        > #5  0x000000000040068e in _start ()
        
        with
        
        > (gdb) info sharedlibrary
        > From                To                  Syms Read   Shared Object Library
        > 0x00002af09232e2f0  0x00002af09253270c  Yes         /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libpython3.8.so.1.0
        > 0x00002af09286fe30  0x00002af092874cec  Yes (*)     /lib64/libcrypt.so.1
        > 0x00002af092aab8f0  0x00002af092ab6db1  Yes (*)     /lib64/libpthread.so.0
        > 0x00002af092cc2e50  0x00002af092cc394e  Yes (*)     /lib64/libdl.so.2
        > 0x00002af092ec6e90  0x00002af092ec77a4  Yes (*)     /lib64/libutil.so.1
        > 0x00002af0930ce350  0x00002af093139336  Yes (*)     /lib64/libm.so.6
        > 0x00002af0933ea9f0  0x00002af09353ab6f  Yes (*)     /lib64/libc.so.6
        > 0x00002af093799a50  0x00002af09379a05a  Yes (*)     /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/libfreebl3.so
        > 0x00002af0920a0af0  0x00002af0920bc060  Yes (*)     /lib64/ld-linux-x86-64.so.2
        > 0x00002af09a0e3be0  0x00002af09a10aa53  Yes         /home/tdf/lode/jenkins/workspace/lo_tb_master_linux/instdir/program/python-core-3.8.12/lib/lib-dynload/pyexpat.cpython-3.8.so
        
        What is suspicious is that it uses instdir/program/libfreebl3.so when
        external/nss has been built ("[build PRJ] nss") but has not yet been fully
        delivered (no "[build PKG] nss").  It uses instdir/program/libfreebl3.so because
        on that machine instdir/program/python.bin has a DT_NEEDED of libcrypt.so.1 and
        /lib64/libcrypt.so.1 has a DT_NEEDED of libfreebl3.so, which the LD_LIBRARY_PATH
        then resolves with instdir/program/libfreebl3.so rather than with the expected
        /lib64/libfreebl3.so.
        
        So remove setting of LD_LIBRARY_PATH on all the platforms where it was still
        used, in the hope that it isn't actually necessary on any of them.  Only on
        Windows, setting PATH is still needed (in line with how the Executable_python
        wrapper modifies it too) to avoid build failures like
        
        > instdir/program/python-core-3.8.12/bin/python.exe: error while loading shared libraries: python38_d.dll: cannot open shared object file: No such file or directory
        
        Change-Id: I398aa89166a6a7f3db58c4e65237840b73bec74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130470
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-24  Justin Luth  <justin_luth@sil.org>  [8f2b1b1cb84e1ae3139eb90b8efdf61e608adbad]

        followup tdf#122098 xlsx export: avoid dataloss if not bool value
        
        Change-Id: I54b2f44a1ab0b7681667e811be72d1504928fab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130469
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-24  Caolán McNamara  <caolanm@redhat.com>  [3e67678af2f6f8f7d25c5ad67b3828e96bc293b8]

        add to suffix denylist
        
        add the macOS specific suffixes from
        https: //support.google.com/mail/answer/6590?hl=en#zippy=%2Cmessages-that-have-attachments
        
        Change-Id: I3a834694e3aefb757974cd00ade009874c68c8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130397
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-24  Miklos Vajna  <vmiklos@collabora.com>  [0e083387551acc677efc903bffc866f5aadb3642]

        sd theme: add UNO API for shape fill color
        
        In preparation of adding import/export for this.
        
        Change-Id: I195be9e9ccdbb25fa41878a2858c22ee11d189a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130467
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-24  Michael Stahl  <michael.stahl@allotropia.de>  [fe5d3fbfe63fe8b433776bd3a0508dd712b868b0]

        sw: prevent footnote frame against delete while it's moved
        
        Change-Id: Ifebe53956ca0a7d3653469256c895a666cfffbf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130439
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-24  Justin Luth  <justin_luth@sil.org>  [e87f9b4fa158b917bb38fc00513bae7f94024e58]

        tdf#95882 svxruler: restore adjustment for borders
        
        This restores the clause removed from
        LO 3.6's commit 47a77d7dbc427e51421e2df8d59695834cb74980
            Ruler: disable snapping, tooltips
        
        [Because that removal left behind dead code,
         which was later cleared out, of course this patch
         restores that as well.
            commit 8303e7ed668fbcbd0ba75bd9dd259f03073ffd46
            Author: Noel Grandin on Fri Jun 14 10:41:11 2019 +0200
        ]
        
        Basic borders on the paragraph itself
        do not affect where LO ends the tabstop,
        and thus the removal of that clause was partially justified.
        But the table/frame/page/headers definitely need to be adjusted
        in order for the tabstops to show in the correct position.
        
        RightFrameMargin needed this as well,
        especially now that RTL is supported by the ruler since LO 3.6,
        although the Left/Right functions are very different.
        
        [Frames never worked because the aCoreSet wasn't accepting
         RES_BOX items. Interesting error considering all of the
         other sections of code created a new CoreSet.]
        
        Change-Id: Ic24839dbbd730e66d8b0d588bfbd73bc7cb260bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130125
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-24  Michael Weghorn  <m.weghorn@posteo.de>  [dc4c55c51d52340c84e21da92d61d3488a253cd3]

        a11y: Simplify AccessibleGridControlTable::getAccessibleCellAt
        
        Call 'AccessibleGridControlTable::getAccessibleChild'
        with the calculated child index instead of duplicating
        the handling to retrieve/create the proper
        accessible object.
        
        Change-Id: I8135f379f304d0e8ac61806eba9b3bd6c644f3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130443
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-24  Jim Raykowski  <raykowj@gmail.com>  [5693f0caa0bb589696ac36b9e0ca42b5e26924d0]

        tdf#146490 SwNavigator: don't show fields that are in header footer area
        
        Fields that are in the header footer area don't behave well when
        included in the Navigators fields members list. This patch make it so
        they are are not included.
        
        Change-Id: I99be944a08a9177676098f30d47ba56dea2b7441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130126
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-24  Jim Raykowski  <raykowj@gmail.com>  [21b5d6e0dce7c2034aded96d1499da27094e2781]

        SwNavigator: drop unneeded cross reference expanded text
        
        Reduces the time to fill the fields members list for documents with cross
        reference fields and corrects the descriptions displayed for cross
        reference fields.
        
        Change-Id: I30425640808d0844a96a528341c0bf0382ea75c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130118
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fa7e58e0bdc1252e164d78e3a35e3210bee70355]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ac52bffa0d4055a8c18d1a25d15a68eae00adee
          - tdf#145898 Formula to Value and Recalculate Hard
            
            Review of the Data - Calculate submenu
            - Added Recalculate Hard page
            - Added Formula to value page
            - Links and embed for navigation
            - Some precisions regarding non-volatile functions
            
            Change-Id: Ic39b61feb851b9cc7c8cb2ae6907651a64a81a6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130180
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [7234576d4e3a6b384168a84165b59ee7751cda62]

        tdf#147611: fix indices
        
        The maKeyState vector in ScSortParam is initialized with three elements,
        and they are never removed. The code in ScVbaRange::Sort incorrectly used
        1-based indices into that vector.
        
        This was broken since commit a02b445c39d969fedc554fc2c500b88a27a13906
          Author: Albert Thuswaldner <albert.thuswaldner@gmail.com>
          Date:   Tue Mar 20 19:38:29 2012 +0100
        
            fdo#45747 remove the limitation to 3 sort entries in calc part1
        
        It was fixed in commit 568d3912bf8ced76ecb9506bccc3bd361daba082
          Author: Kohei Yoshida <kohei.yoshida@gmail.com>
          Date:   Wed Apr 04 15:30:35 2012 -0400
        
            Cleanup. ScPivot(Collection) is no more.
        
        but was restored by commit 3e887edcaacc5b0f5e35d682a259124648e84229
          Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
          Date:   Thu Apr 5 05:05:40 2012 +0200
        
            Revert "Cleanup. ScPivot(Collection) is no more."
        
        Change-Id: I009252e794c9365f0aef8a61daf9cbd40eca8b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130441
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [129fde28f6aa26a8c52de193b41c0c92a08a7a89]

        tdf#147458: sc_jumbosheets: Add unittest
        
        For some reason, the test fails on windows with
        
        Test name: ScJumboSheetsTest::testTdf134553
        equality assertion failed
        - Expected: 1058
        - Actual  : -7421
        
        However, the issue is not reproducible manually.
        If the test is executed with
        aDefaultsOption.SetInitJumboSheets(true);
        then it doesn't fail
        
        Change-Id: I5314c326d3937eaf5e96e4d25d71a7f1347c11af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Justin Luth  <justin_luth@sil.org>  [dfd0717b3f55eeb15a5634e52d7d0ed544d17578]

        tdf#127720 chart2: create new columns for error bars
        
        This is basically a copy/paste of the bubble chart fix
        for tdf#103984 against the same LO 4.4 regression.
        
        No exist unit tests had error bars. Very interesting.
        
        make CppunitTest_chart2_import CPPUNIT_TEST_NAME=testPPTXChartErrorBars
        
        Change-Id: I81ff91ee2ba75277502a8e261106bf5837a8903b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130444
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [ea1600eb54fac1ac980339535e25cce00f59b711]

        Resolves: tdf#147292 the area of the tooltip is wrong
        
        gen happens to make use of the current mouse point so it gets shown
        anyway while gtk uses the designated area which isn't in the expected
        units or screen relative positions
        
        Change-Id: I11fdb09ad4ce2965d2f2e27fb1427c9d93de7a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130442
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Justin Luth  <justin_luth@sil.org>  [8f5d8669ca74fed8608e438a8436c173e35d43a6]

        tdf#122098 xlsx im/export: let formulas guess their number format
        
        This fixes the import side of a LO 4.2 regression
        from commit 07b66cd3ac1a9f6c7b61a1d7da6e9d266e6de92d
        and the export side of a LO 4.3 regression
        from commit 69ecdad805281b2cb6ec2437da18daa19576deae
        
        make CppunitTest_sc_pivottable_filters_test \
          CPPUNIT_TEST_NAME=testPivotTableBoolFieldFilterXLSX
        
        Change-Id: I4c680dbff844cf1eca52de641856daafa032eeb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130406
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-23  Luboš Luňák  <l.lunak@collabora.com>  [8feca2e3146171f76a8aa0b38fff54f327afddaf]

        handle hardcoded MAXCOL/MAXROW in ScInterpreter
        
        The change from <= to < is intentional to compensate for the change
        from MAXCOLCOUNT to MAXCOL (there's no MAXCOLCOUNT_JUMBO and I don't
        want to add it).
        
        Change-Id: I223b2fd3b1a9e22e82f6a31d16d44c98ae43876d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130436
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-23  Luboš Luňák  <l.lunak@collabora.com>  [90bf00cfb7b05f02c541965c5e713a6dadf9e6e0]

        remove MAXCOL/MAXROW from ScViewData
        
        Change-Id: I12461bac8dd127075ee9071e1015561f7a029624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130435
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [f4a62e5479b47d90d6de518f38a97ac0b5322c54]

        SdrLayerID must be based on sal_Int16
        
        ... which is the type corresponding to the related published property
        "LayerID" of com.sun.star.drawing.Shape service.
        
        Without this, the code asserts on values passed to the published API
        from external sources to be in the 8-bit limits, which is incorrect.
        
        Change-Id: I0449a7dd313f7e6c4adbc1c1f7b8c50b6a51434e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121760
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [4751853b19dabfb57963c58183b0c3557328b3b8]

        add to suffix denylist
        
        mostly https: //support.google.com/mail/answer/6590?hl=en#zippy=%2Cmessages-that-have-attachments
        
        but see also:
        https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows
        
        Change-Id: Ibe3abbdcdb6f82a73d245318ef97d86789d00523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130394
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [ebd508e1664fc13c8305ead62346f9fdf3a2b37e]

        sc: qa: no need to have an empty file, just create it
        
        Change-Id: I7586f1a196f057681e53173bd7d7dd3d57883abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130425
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [aff280d2304688673efa974eab35d8de4c83e9c1]

        sc: qa: factor out common code
        
        Change-Id: I3a71cdb4b64397403b1a17b9c63c736169581376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130424
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [d4ec94c90a195a34e19f8a7af48424a14f7cf227]

        cid#1500555 try -taint_source function annotation tag
        
        Change-Id: I237a22968024814d578d387e99ae96b748382e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [1af6ac544894fe9840716b0d4992852c16e73614]

        cid#1500434 Dereference after null check
        
        Change-Id: I1a9531446fbd5f977d02775f5d25696aba16287d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130431
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  flywire  <flywire0@gmail.com>  [b952a98a7f25ddd831e8b4e2604867d95ba1b975]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 046e5b4b6101edcc1614dd2dc392d8feab9eb891
          - Add ScriptForge services language headings
            
            Change-Id: I22fbe569cb3702d784f944738261d7aed6de3ca0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130314
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [41a4de04e97f18c87d23127b76d554afcc309e41]

        Sifr: tdf#144303 Calc's cross cursor
        
        Change-Id: Ied1c954c868b6779db8d2fa9c41154c2df22b99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130407
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [26d22a1e0514dab76dabfe87c747ace6a4a7e2cf]

        cid#1500676 Logically dead code
        
        and
        
        cid#1500414 Logically dead code
        
        since:
        
        commit dcda5569c41b33077a1795d1e147572a2d483d04
        Date:   Thu Nov 22 14:09:27 2018 +0200
        
            remove unused TableChgWidthHeightType::InsertDeleteMode
        
        Change-Id: I2159bf2b39e6b42ec9235e9b149752507096c7cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130432
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [52540a92343e72e4b402a6386464d69135460112]

        Karasa Jaga: tdf#144303 Calc's cross cursor
        
        Change-Id: Ie6a16959c37c14cb5ef158f18b1228baeb8eb703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130409
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [e68faf60e59ad82fa23a0fb18bf80847788589a7]

        cid#1500494 Explicit null dereferenced
        
        Change-Id: I543cc7b12e3517e26bd57463dc20c97c5498df55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [03aff21eafc19e2e02bfdb0bf541f64eb5942044]

        cid#1500550 Dereference after null check
        
        Change-Id: I0e0e17026fed5e12dacbdd0900dc305a74543e03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130429
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [d479a215538590e50ea9d8fb29ac972df06c6d10]

        cid#1500601 Dereference after null check
        
        Change-Id: I2f757ce2a57793720feacd1ca3b6d42bf56c1be9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130428
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [9e4825beb82ee68642eca5031ad57fc55d384256]

        cid#1500613 Dereference after null check
        
        Change-Id: I6f02265a4e208ebb66004bd7784e2dc1a50adef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130427
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f7b99812c088b1738f25fb57a821b90b8520d8dd]

        update credits
        
        Change-Id: I153162daf766b49806d327b64d9a6c574f275b12

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [26003c60aa0b539da1a05874278e5cd05b327aae]

        cid#1500615 silence Dereference after null check
        
        Change-Id: Ide4089fa37786f3bccb03cc679306a26e60aca73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf201db990e8973f801ba6c44f74605330a4af74]

        tdf#64914 elide some dynamic_cast
        
        Change-Id: Ifbd41d2de4642f4855f594067ccbbd71464a66d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [ee351bc9d83798c4bed6ef891e602981ae88ae24]

        cid#1500622 Dereference before null check
        
        Change-Id: Id19f46ff51759c8346915852bfcb2cec66962c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [efa6c3db7289266c46dd4c30b5bedc7ba22a203b]

        cid#1500643 Dereference before null check
        
        Change-Id: I1456b9a935c167344e0a56c7339da2c702a43e0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130419
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [1c17a15d8a7e5a38c999ac2b8388a73e50f088e0]

        cid#1500655 silence Dereference after null check
        
        Change-Id: I5ba5b4f4053ede895579620c728daf7b9b4e71c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130418
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [3c0662373361938822559d43b031b4c63850e32e]

        cid#1500664 Dereference before null check
        
        this looks sensible at:
        
        commit e7c7d6f0e9cf0185188e864f6419667073283dcc
        Author: Kurt Zenker <kz@openoffice.org>
        Date:   Thu Sep 11 09:16:30 2003 +0000
        
            INTEGRATION: CWS mav05 (1.1.2); FILE ADDED
        
        as:
        
        if ( (*pElementIter)->m_bIsStorage )
        {
            OSL_ENSURE( (*pElementIter)->m_pStorage && (*pElementIter)->m_pStorage->m_xPackageFolder.is(),
                        "An inserted storage is incomplete!\n" );
            if ( !(*pElementIter)->m_pStorage || !(*pElementIter)->m_pStorage->m_xPackageFolder.is() )
                throw uno::RuntimeException(); // TODO
        
            xNewElement = uno::Reference< lang::XUnoTunnel >( (*pElementIter)->m_pStorage->m_xPackageFolder,
                                                                uno::UNO_QUERY );
            (*pElementIter)->m_pStorage->Commit();
        }
        
        and then didn't after:
        
        commit 8c64f087f88173b3101307176cccdd03e6558c69
        Author: Rüdiger Timm <rt@openoffice.org>
        Date:   Thu Oct 30 08:48:27 2003 +0000
        
            INTEGRATION: CWS mav08 (1.2.10); FILE MERGED
            2003/10/15 08:07:55 mav 1.2.10.2: #i21121# substorages implement transacted mode
            2003/10/13 14:26:33 mav 1.2.10.1: #i21121# Transacted mode for storages
        
        Change-Id: Ib05359b282d078cd40b41ed8f2fe9242235c9c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130417
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [b2965afb8ba8ac155206a8dd790cd54ecfbf6d33]

        cid#1500665 Dereference before null check
        
        Change-Id: I451c0faad1060ff7e97ef24af61940f402e1b243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130416
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1fe159fa39b2fc5217848e14d68c674979c181c]

        CppunitTest_sc_pdf_export: don't load an empty doc in setUp
        
        Change-Id: Iebd4ebf3e0ca7c9e3fa00d0addc0ec21ee4deb57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130412
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [e1f5044b43dbe13e0c5a8383ec3f84b4c2c44ddd]

        we should be testing more in the hwpfuzzer
        
        Change-Id: I742efee39496d098677fa251727494bb741f627d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130357
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Stephan Bergmann  <sbergman@redhat.com>  [5931638fdabb033c2f957c90ae27d075477b1261]

        external/python3: Explicitly check that all extension modules got built
        
        ...to avoid issues like we now experienced on Jenkins box tb76, where e.g.
        <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/108402/> failed with
        just an unhelpful
        
        > /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/external/python3/ExternalPackage_python3.mk:46: *** file /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/workdir/UnpackedTarball/python3/LO_lib/_elementtree.cpython-3.8d.so does not exist in the tarball.  Stop.
        > make[1]: *** Waiting for unfinished jobs....
        > Makefile:299: recipe for target 'build' failed
        > make: *** [build] Error 2
        
        after ExternalProject_python3 had been built successfully, outputting just
        
        > [build PRJ] python3
        
        even though its workdir/UnpackedTarball/python3/build.log states
        
        > *** WARNING: renaming "_elementtree" since importing it failed: pyexpat version is incompatible
        
        and
        
        > Following modules built successfully but were removed because they could not be imported:
        > _elementtree
        
        (but which got hidden by gbuild)
        
        Change-Id: I28904ef41cb823e308bb8e15cbe969872702cb55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130355
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-23  Stephan Bergmann  <sbergman@redhat.com>  [c7a920a9b742ee273f3e7a8583d11eaeebf4fe1d]

        Sync the two definitions of python_arch_subdir
        
        ...in RepositoryExternal.mk and external/python3/ExternalPackage_python3.mk.
        The variance in trailing slash had caused
        <https://gerrit.libreoffice.org/c/core/+/130355> "external/python3: Explicitly
        check that all extension modules got built" to fail on Windows at
        <https://ci.libreoffice.org/job/gerrit_windows/120651/> with
        
        > Error: missing PCbuild/win32_asyncio_d.pyd
        > make[1]: *** [C:/cygwin64/home/tdf/lode/jenkins/workspace/gerrit_windows/external/python3/ExternalProject_python3.mk:37: C:/cygwin64/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/ExternalProject/python3/build] Error 1
        
        (and note the missing slash in "PCbuild/win32_asyncio_d.pyd").
        
        (Ideally, these two definitions would be consolidated anyway, but that's left
        for later.)
        
        Change-Id: If2e6081e966bf3931eb0092616705521b4cfd3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130410
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-23  Luboš Luňák  <l.lunak@collabora.com>  [19b7f715543bdb55293f5d729fcefbcf2f701efe]

        check valid col in ScTable::GetDataEntries()
        
        Presumably uncovered by 823eb92025853d120c17790d1c8efde59f033c69
        no longer allocating a column on GetPattern().
        
        Change-Id: I2f23414a912ec1a0f22b4b88ea367423fb6fb7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130388
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-23  Luboš Luňák  <l.lunak@collabora.com>  [bc734289e5542a0ffa04c0ac3cd1aa7cb1810be0]

        fix more MAXCOL/MAXROW in tests
        
        Change-Id: I7e3444f0b2ee5a4297705a24fbab3bfb96904b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130387
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [7e482815b4a719fa4d04f0013c96d8a8063bad21]

        keep paragraph's that failed to load until import is complete
        
        LIBREOFFICE-509JU93T
        
        Change-Id: I526edb182fed4fa023cce58e78a650a7c2046ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Caolán McNamara  <caolanm@redhat.com>  [445c38d0ea247e48055d770df2fe9fffe5a80e0e]

        blist is written to but not read from and storing pointers has no sideeffect
        
        Change-Id: I45221eda3d8536df75c4471888f35fb1b89e0a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130358
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [cba4282c3ab554db5416f8949d447bae4ec28170]

        CppunitTest_sfx2_classification: remove duplicated dispatchCommand
        
        it's already defined in unotest::MacrosTest
        
        Change-Id: I34645b95d83ca1ed167c99bd12c9b6ffebef032c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130400
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [280c5053734ad349dcc774909e56189f11fceb9e]

        CppunitTest_framework_dispatch: remove duplicated dispatchCommand
        
        it's already defined in unotest::MacrosTest
        
        Change-Id: I2abc4bea61f55242b9cf3c7f030f5c74f8a51efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130402
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [2c08104e4211594d3d06b1e4e85038276b58918a]

        Use rtl::isAscii
        
        Change-Id: Iab88c3281f3dd1ba1668b3372420c97087c14da5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130381
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [8dcda24026d6d803f064351b1a1df8f6b77c2fa0]

        Simplify NewCopy a bit; avoid direct use of memcpy
        
        Change-Id: I197978604d0dfa997c95b907715ce891211621f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130380
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Miklos Vajna  <vmiklos@collabora.com>  [8399c2b37f44cd983381ebf6b9d30ba19ad98f2a]

        CppunitTest_sw_ooxmlexport3: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I51a86924de2a6f3eb1a492d60890d6f413d4f6ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130392
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [6ec960fe0be916fa20829e0b29fcb12d64008414]

        qt a11y: Handle HYPERTEXT_CHANGED event
        
        Change-Id: Ib4e6f06a5cdac1ac47eb3d273ca103fb5081550e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130361
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [4f1ffd47812bb0507561e01a2ffca3b28b5c1412]

        Deduplicate newFromStr*
        
        Change-Id: I01dd9d70affdfa048af6bd7455301e662290e662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130370
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [ab925e1d8d927f3b26cbe2d60e5aa35e1c6f1076]

        qt a11y: Handle VALUE_CHANGED event
        
        Change-Id: I34d813ced29a591b0a6652eeb1271a978980bba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130359
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [fe9206b474464dd092da1d5c1ee788fe1c9b0765]

        qt a11y: Better handle TEXT_CHANGED event
        
        Trigger the corresponding Qt accessibility
        events for deleted and inserted text rather
        than sending a QAccessible::TextColumnChanged
        event (which looks like a rather arbitrary choice...).
        
        Qt also has a 'QAccessibleTextUpdateEvent'
        class that could be used to send a combined
        event, but since we get the relevant data
        separately in the LO event, using the latter
        wouldn't make things easier. And at least
        for the AT-SPI case on Linux, Qt sends
        separate AT-SPI events via D-Bus anyway. [1]
        
        Unfortunately, qt5/qt6 VCL a11y is not yet functional
        enough to e.g. test that the correct AT-SPI events
        are actually received when using the the script mentioned in
        Change-Id: Ibcae27ecfccf41a909e06d01ce681e4b7b97eb25
        (gtk3 a11y: Migrate from deprecated "text-changed" ATK signal).
        
        [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp#n964
        
        Change-Id: Ia9282382b6d5fd6bffd536dcda2989a6da901e90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130356
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [4162feb37109d4e9da44933831e10b5732721c72]

        gtk3 a11y: Migrate from deprecated "text-changed" ATK signal
        
        The "text-changed" ATK signal (which has a detail of "insert"
        or "delete" to indicate what type of change happened) is
        deprecated since ATK 2.9.4 and "text-insert" or "text-remove"
        should be used instead [1], so do this.
        Those have the inserted/removed text as a third argument,
        so this also obsoletes the workaround to remember the deleted text
        under the "ooo::text_changed::delete" key for the ATK object
        in the "text-changed:delete" case. (See inline comments
        dropped in this commit for more details on how that was
        used, by now "appropriate API exists in atk to pass
        the string value directly".)
        
        Note that this only changes the signal on the ATK layer,
        the corresponding signal on the (underlying) AT-SPI layer
        is still "object::text-changed::inserted" or
        "object::text-changed::deleted", but other than the
        ATK signal of the same name, this event already has
        the inserted/deleted text as extra data. [2]
        
        (The conversion from the ATK signal to the AT-SPI one
        happens in at-spi2-atk. [3]).
        
        I used this script to check the emitted AT-SPI events:
        
            #!/usr/bin/python3
            import pyatspi
            def listener(e):
                try:
                    if e.host_application.name != 'soffice':
                        return
                    if e.source.role != pyatspi.role.ROLE_PARAGRAPH:
                        return
                except:
                    return
                print(e)
            pyatspi.Registry.registerEventListener(listener, "object:text-changed")
            pyatspi.Registry.start()
        
        Pasting the Chinese sample text from tdf#147285 into
        an empty Writer document, removing the third character
        and typing "a" instead resulted in the expected output:
        
        > object:text-changed:insert(0, 12, 维基百科，自由的百科全书)
        >         source: [paragraph | ]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        > object:text-changed:delete(2, 1, 百)
        >         source: [paragraph | ]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        > object:text-changed:insert(2, 1, a)
        >         source: [paragraph | ]
        >         host_application: [application | soffice]
        >         sender: [application | soffice]
        
        Given this test worked, drop the old
        
        > // TESTME: and remove this comment:
        
        comment as well, and also drop the
        
        > // TODO: when GNOME starts to send "update" kind of events, change
        > // we need to re-think this implementation as well
        
        comment. From what I can see this is still the way to handle
        events using ATK (i.e. for Gtk 3 at least, Gtk 4 has a new a11y
        implementation [4], but that will have to be looked at separately
        anyway).
        
        [1] https://docs.gtk.org/atk/signal.Text.text-changed.html
        [2] https://accessibility.linuxfoundation.org/a11yspecs/atspi/adoc/atspi-events.html
        [3] https://gitlab.gnome.org/GNOME/at-spi2-atk/-/blob/0af3f73b/atk-adaptor/event.c#L962
        [4] https://blog.gtk.org/2020/10/21/accessibility-in-gtk-4/
        
        Change-Id: Ibcae27ecfccf41a909e06d01ce681e4b7b97eb25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130352
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [e70b054d4945dd9bda0e869e5bc0aa19432a9802]

        gtk3 a11y: Replace deprecated atk_component_get_position in atktext
        
        Change-Id: I06689dd0ff2f47c06879bdc3c61ce5b5db90a120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130334
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Michael Weghorn  <m.weghorn@posteo.de>  [63bc309c7af04496c68346b0eee0c138943300ff]

        gtk3 a11y: Replace deprecated atk_component_get_position in atkimage
        
        'atk_component_get_position' is deprecated since ATK 2.12 and
        'atk_component_get_extents' should be used instead, which also
        returns the width and the height (that we don't need here).
        
        [1] https://docs.gtk.org/atk/method.Component.get_position.html
        
        Change-Id: I8c49cc6942406051bca1fcdfa4ca0bfc8d326911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130333
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [c95d2c8ef7a7d062536e225b843006bdf3d7d65b]

        Deduplicate shortenedCompare*_WithLength
        
        Change-Id: Ie1ba2787036955976f43217e64af889a314a2e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130325
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Mike Kaganski  <mike.kaganski@collabora.com>  [d5c8888dedbf2241f9b09bbb5698f37c89f9510b]

        Drop obsolete code
        
        Change-Id: Ia362d00c7637370f4dc967763892269909f06578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130369
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a3f2def9359825cb022c6f989f10eb3168bafe27]

        Breeze: tdf#144303 Calc's cross cursor
        
        Change-Id: I1b37b6fb44f4637e559ccc978edfe2b54ed533ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130405
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1b32cac107141ce8f3c04cb797d6e82dc0f54cf3]

        Breeze: tdf#147603 Star icons in Extension dialog
        
        These icons are actually for Calc's conditional formatting,
        but the definition has been declared in links.txt:
        
        cmd/sc_stars-full.png sc/res/icon-set-stars-full.png
        cmd/sc_stars-empty.png sc/res/icon-set-stars-empty.png
        
        Change-Id: Ib3bb9b9d863e368919551c1e6c082c84bab8a0bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130401
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [3c01c93ac364f7d3965c163916da03effcf99670]

        Colibre: tdf#147603 Star icons in Extension dialog
        
        Change-Id: I730228371f66169fdcd4578918da4615415dac08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130404
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [79cc43585f93c000edaf56f3754e5be577ce75ca]

        Sifr: tdf#147603 Star icons in Extension dialog
        
        These icons are actually for Calc's conditional formatting,
        but the definition has been declared in links.txt:
        
        cmd/sc_stars-full.png sc/res/icon-set-stars-full.png
        cmd/sc_stars-empty.png sc/res/icon-set-stars-empty.png
        
        Change-Id: Idf1cfcf79ec09311fb5ee76b88d29a2b950c4fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130399
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-23  Miklos Vajna  <vmiklos@collabora.com>  [89667371e2c773760e7f7496590f55e7da062cb7]

        sw HTML export: handle LeadingTabWidth without FilterOptions
        
        LeadingTabWidth is meant to be useful for plain HTML as well, but the
        old code only considered it when FilterOptions was set (typically to
        enable th XHTML mode).
        
        Thanks Stephan Bergmann for noticing that the u"" SAL_NEWLINE_STRING
        "\xa0\xa0 test" form would not work with MSVC.
        
        Change-Id: I89a8b266d9a0f543f6022d82cf043bda4e6e639f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130360
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-22  Julien Nabet  <serval2412@yahoo.fr>  [bdc2e89d2083ec49df122834edfdb17db8ea0513]

        Fix a ODatabaseMetaDataResultSet type in evoab2
        
        Change-Id: I974b1ce90d87fb8591eb7d788f884402111b5a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130396
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-22  Julien Nabet  <serval2412@yahoo.fr>  [91a9520496370add61403e6fcc0dbd26f33b4032]

        Fix some ODatabaseMetaDataResultSet types in Firebird
        
        Change-Id: I12e579d04b81057d3513dab3459c035b1ae9df42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130393
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [00e77788dc0fa13e08ad9f4d1929bb10a53daf8d]

        sc: qa: factor out common code
        
        Change-Id: I363f4adba8d1d3e98cff8422d0a574e73a6c442f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130366
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Mike Kaganski  <mike.kaganski@collabora.com>  [52f692937d479e80182ab01e195359a2df064c30]

        Deduplicate newReplace
        
        Optimize some places for single character case for that
        
        Change-Id: I99b2abd2fd3c89a98ed1d84f7b70ed4def83da2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130371
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [8ba430f6edc2a09a3f600a8a52152cc26def14fe]

        sc: qahelper: combine saveAs and exportTo
        
        Change-Id: I75667249cce2a03e23bb2e0af080c935d5f15eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130362
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d2941516a6c133bd2b67f80bc54538e474610f4e]

        Fix typos
        
        Change-Id: I705530b841a5e1a4c45f78408948d4cdba630d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130291
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [aaae9e4e28e0d92a20bd2f1f79975dd3ece8e22f]

        Sifr: tdf#138400 General Number Format icons
        
        Change-Id: I3a4122569650c35aa337e8a9c897e321e0728a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130354
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-22  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [eaaf5ef8f99404797ffbb44ceeebf8795d85f07e]

        Advanced Diagram support: first additions/reorganizations
        
        To allow advanced Diagram/SmartArt support in the future
        this is a first step to organize imported SmartArt Data in
        a way that will allow to re-layout loaded SmartArts, under
        re-usage of the oox::Theme (held available).
        
        It is designed to work without holding available the
        original XML snippets defining the imported Diagram in any
        way, also for performance reasons. It tries to re-use some
        of the already basically added functionality, including
        the systematic layouting using the generic layout
        algorithm, plus some already available text extraction.
        
        Before being sure that the former state can be completely
        replaced this is optoinal and used when
        SAL_ENABLE_ADVANCED_SMART_ART is defined. Some new stuff
        is already done but e.g. the redefined reLayout method will
        not (yet) be triggered. It works and reliably produces a
        re-layouted identical version, also preserving
        transformations.
        
        Change-Id: I08cfbae04afa663d0589530aae549216d853128d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130171
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-02-22  Stephan Bergmann  <sbergman@redhat.com>  [8187737a7844fe4669f80bf0e8ef0950148dc58f]

        Restrict the converting rtl::isAscii* overloads
        
        ...to types that can be converted to sal_uInt32 without loss
        
        Change-Id: Iad83591c6b70bf5efe1b6b14bacf1b6e9a225295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130348
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa12351db402180eca4a4ed497f32efbd9b22db9]

        CppunitTest_sc_subsequent_filters_test: do not inherit from test::FiltersTest
        
        Change-Id: Id7e01ae7f087c6f1a981173aa840b169ec7d8799
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130351
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Rene Engelhard  <rene@rene-engelhard.de>  [19b0ba55ea7058b35b13f9e2ae0e8d4add374eef]

        add system-dragonbox
        
        Missed in 9eb9083ff2fdaeb96399a0830a4394de4e29ef64
        
        Change-Id: I1d001b39f55c8504a76bfbdadd1423b414adc9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130209
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [2ac21c47d0ca4993e828d1cad977942d340021c6]

        CppunitTest_sc_jumbosheets_test: do not inherit from test::FiltersTest
        
        Change-Id: I7a2e2bb29aa776f2b83af00329182ca4d7edae49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130350
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Heiko Tietze  <tietze.heiko@gmail.com>  [dc54d2477c6ad23e9132caf65849239bb9eab4fd]

        Resolves tdf#101179 - Correct menu entry for View > HTML Source
        
        .uno:SourceView disables the other view options and is rather a toggle
        
        Change-Id: I6be34bfbb5715db7fcd6458dccc1a99ca5885390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130344
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0a43965bf674599aba901666ad1a8ebfd18ed9a2]

        elementary: tdf#138400 General Number Format icons
        
        Change-Id: Ica0e26b766358cba97c76f8ba91c08514283d356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130343
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-22  Stephan Bergmann  <sbergman@redhat.com>  [79c2398b8047016671069ceb271f218570819fad]

        Replace some fprintf with SAL_WARN
        
        Change-Id: I3f31f223b6e906c6b40415a8d5c66c27e3c7cff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130338
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-22  Caolán McNamara  <caolanm@redhat.com>  [ff66c1d82b34ea8efbfb61835f6ec951e5b32caa]

        sort these alphabetically
        
        Change-Id: I03f89dd78908d08534413c0fe6a753e3346b3738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130336
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-22  Stephan Bergmann  <sbergman@redhat.com>  [14a8eecaa4368495f681f3fe2ed8f867697b234c]

        Remove a debug-style fprintf
        
        ...that had been added in 811de66d7fd8c93c43d8e4e2dc73720033ba939b "First
        attempt at getting access to the Java VM on Android", together with another
        
          fprintf(stderr, "Got lo_get_javavm = %p", lo_get_javavm);
        
        that had meanwhile been removed again in
        5510127e89d6971a219ce3664e4631d6c6dda2b1 "Android code refactorig and hacking"
        
        Change-Id: I1a50563e2af1ea5a0ecbd2cc9d49d70c6e5bbbd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130337
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2022-02-22  Renwa Hiwa  <renwax23@gmail.com>  [0b0b1820d2e287a193b83ae8a64cb2c53521c7d6]

        Better handling of msi
        
        LIBREOFFICE-SK4E5D8N
        
        Change-Id: I44f25a47ab6ffeb9d2b679874c8c96af1319eb2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130335
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [27352b81638f2f1e792ab48ec532eaacf6f61718]

        Add XWeak constructor and operator= to uno::WeakReference
        
        which is faster since we can skip the UNO_QUERY.
        
        Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ccdd0d164b16da9a13ab5d8290a1a0f041caaf7]

        CppunitTest_sc_tiledrendering: active LibreOfficeKit in the setUp
        
        Change-Id: I7099540ce2939a45d50193e74d08be19995bb23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130286
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [06b7f930a51d396bf9e3b6b8d0b3fcbd034730b4]

        tdf#64914 small improvements
        
        (1) do not read the config inside a hot loop
        
        (2) do not create a SvxShapeGroup only to remove it
        
        Change-Id: I8ff3840d0972d2f617a326a67d18260e44220f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130331
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b341bc420f85f06769db13791efab3d115c770b]

        tdf#147509: sc_jumbosheets: Add unittest
        
        Change-Id: I464d2ce3e79a9e79d034e4cce86d63355e0b5a81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130290
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-22  Luboš Luňák  <l.lunak@collabora.com>  [827b218b94c64b658549bd0d4468783a7f1e231a]

        merge poolio.cxx into itempool.cxx
        
        It doesn't make sense to have few SfxItemPool functions in a separate
        source file, and without LTO those tiny functions do not get inlined,
        which is confusing when profiling.
        
        Change-Id: I0ba891ba51c7d8dd3eba3f4cae0f7819f9b033e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130327
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [2ab735df698972bff159f52975a1ed5cd4df128e]

        gtk3 a11y: Make a11y role mapping more explicit
        
        Use switch-case instead of an array that uses
        the numerical value of the accessibility::AccessibleRole
        as an index.
        
        Change-Id: Id7fbc31c058d0db716d2b60a4a7eb7e7e954af95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130330
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [b910044514cfdeff2967eab248d03b2e9c5ca863]

        gtk3 a11y: Just use ATK constants for roles
        
        The ATK role used here that was added to ATK latest is
        ATK_ROLE_FOOTNOTE, which was added in ATK 2.26.
        With a minimum ATK version of ATK 2.28.1 (s.a.
        Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47
        "gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2"),
        all constants can simply be used as is, so drop the special
        handling that was there for older ATK versions which involved
        calling 'atk_role_register' that was deprecated in ATK 2.12 [1]:
        
        > Deprecated since:
        > Since 2.12. If your application/toolkit doesn’t find a suitable
        > role for a specific object defined at AtkRole, please submit a
        > bug in order to add a new role to the specification.
        
        [1] https://docs.gtk.org/atk/type_func.Role.register.html
        
        Change-Id: I93579e84576feb1bcae8cecf2dc8b264e8be3153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130329
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-22  Michael Weghorn  <m.weghorn@posteo.de>  [c688fd1393dccfb3df39bd05cceed1cf0c401b02]

        gtk3 a11y: Require atk >= 2.28.1, drop code for < 2.15.2
        
        README.md lists RHEL 7 or CentOS 7 as runtime baseline,
        which has ATK 2.28.1 [1].
        
        Therefore, check for that version in configure.ac
        and drop some code for versions < 2.15.2.
        Requiring 2.28.1 as minimum ATK version will allow for
        further cleanup in follow-up commits.
        
        [1] https://centos.pkgs.org/7/centos-x86_64/atk-2.28.1-2.el7.x86_64.rpm.html
        
        Change-Id: Id7084366d2359deb60948b8969c1d3dcc68ddb47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130328
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-22  Ramreiso Kashung  <ramreisog24@gmail.com>  [bcaf13205052a64373599245ae0b1020b04b1385]

        tdf#147132: Flatten Basic function implementations
        
        Some SbRtl_* functions have been flattened at basic/source/runtime/methods.cxx
        
        Change-Id: Id56485ddfaa972133c9b199d22b141d93df475f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130206
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-02-22  Noel Grandin  <noelgrandin@gmail.com>  [b77e806f937d769c58c6bd1c6fbb77fbaa11268c]

        eliminate a layer of conversion in createSymbol2D
        
        speeds up loading large charts
        
        Change-Id: I935971e21dd5384d8f3e04e0022fd81c2c1c8232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130301
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-22  Miklos Vajna  <vmiklos@collabora.com>  [775c75b8f36a09d6028de959f30efa7a20964919]

        sw: document SwNoTextNode
        
        Also make it a bit more clear that GetCharRect() and
        GetModelPositionForViewPoint() are the opposite of each other.
        
        Change-Id: I1ec2b57c047522e98c2fde0a4b698d5816884dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130304
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-22  Tushar Jham  <jhamtushar12@gmail.com>  [122ebe3ac77056ef381981d641ea5d03b2a62001]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: If049cbcfc9b9a485c3be67e6111440662296b468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130293
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [56cd3b2b5d395165cd4add2f46ac4ba25a4ea4af]

        tdf#64914 slow opening large chart
        
        shaves 2% off the load time by avoid the cost of
        comphelper::getFromUnoTunnel
        
        Change-Id: I9d0438bd0ad3cf753d34fe181481f3a57193651c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-22  Stephan Bergmann  <sbergman@redhat.com>  [44c7cbd93fa5ad8e9a6eb8494e64cfcfcb019c29]

        Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-gtk4
        
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgtk-4.so.1
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libpangocairo-1.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libpango-1.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libharfbuzz.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libcairo-gobject.so.2
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgraphene-1.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgio-2.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgmodule-2.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libglib-2.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libatk-1.0.so.0
        > instdir/program/libavmediagtk.so has suspicious NEEDED: libgobject-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgtk-4.so.1
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpangocairo-1.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libpango-1.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgdk_pixbuf-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo-gobject.so.2
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgraphene-1.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgio-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgmodule-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libglib-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libcairo.so.2
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libatk-1.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libgobject-2.0.so.0
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libX11.so.6
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libXext.so.6
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libSM.so.6
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libICE.so.6
        > instdir/program/libvclplug_gtk4lo.so has suspicious NEEDED: libdbus-1.so.3
        
        Change-Id: I686cdc5f21c9a730167e9efa120946f6d96eaed0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130305
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e2b4b08549ee95288fe4cb6e8f71bc75574e0414]

        Removed executable bits on data files
        
        Change-Id: Ifcdae0106380de978c608f46e82155c6c9eed20b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130292
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c993d9e7538ffad8b31b26774d7062ee85572e48]

        Colibre: tdf#147575 Open <DB Object> icons
        
        Change-Id: Iccf074831a0fcccf071dda6ec6900ae315eb0ba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130285
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Julien Nabet  <serval2412@yahoo.fr>  [4202ea2c932a14d216e74617bbb74a85030c9a59]

        cid#1500693 Resource leak
        
        Change-Id: Ic560c2079be0b04ce382350390e03e0ec2d8abcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130303
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3ba8b56b32c203326b776b940d20b16eb2340835]

        tdf#147089 - Round Integral Division (IDIV) literals to Integer values
        
        Change-Id: Ia243c6117a437d0c6efb33a4e76c5e9ee539fbdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130302
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-02-21  Hossein  <hossein@libreoffice.org>  [02e1be8883a08ab17f3e890a834ab88f13c5867d]

        Cleanup x509certificate_nssimpl.cxx
        
        * Remove unused headers
        * Remove 'using namespace'
        * Use enum values in the condition
        
        Change-Id: I45c20412db48ed1a3a4471db20193c2d9cde2f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130214
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-21  Luboš Luňák  <l.lunak@collabora.com>  [db345bee733fee8c7157c246979bed2c65799507]

        use 64bit for window sizes (tdf#147458)
        
        Change-Id: Iaa240aeae8bacbff6bccd9bf0721a02414b6f47d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130288
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-21  Miklos Vajna  <vmiklos@collabora.com>  [8c2607ae3ce143586e623532b8ae5288277ec3ac]

        sw HTML export, XHTML mode: fix lost </li> when last list item is not numbered
        
        This went wrong in 013a4f1f5c9ea5fb511568c53a7e76d1b365a65d (sw XHTML
        export: fix handling of list labels, 2021-05-13), where we started to
        assume that in case the last paragraph of a list is not numbered, then
        the entire list is not numbered. This lead to loosing the </li> for an
        <li> in case the list starts with a numbered paragraph, but ends with a
        non-numbered one.
        
        Fix the problem by (if necessary) looking back till the start of the
        list to see if any paragraph is numbered: that ensures that the <li> and
        </li> is always in sync.
        
        This fixes the new problem and keeps the old problem fixed at the same
        time.
        
        Change-Id: I7d347b37a40dcc727c2080bf8279e33c3ad147e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130287
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [97f41621580d884f59175964dd41898c3a9f9a23]

        cid#1500477 silence Explicit null dereferenced
        
        Change-Id: Ic57c49ce1c65ecca4e87be970e76bf16ba234711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [ff215479a8b9296ae26bd3ffab365dfa883a878d]

        cid#1500515 Dereference after null check
        
        Change-Id: I6483c3a036c5c56c8c6515b5b8f08720c8bd1a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130269
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [00866f35a9c912d8d566d3d42ae0af271c8ef6a3]

        cid#1500612 Dereference after null check
        
        otherwise this doesn't make sense
        
        Change-Id: I321a86cf8f9f05639b686a4c15b2e8fca2e10955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130271
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  flywire  <flywire0@gmail.com>  [b0ebb2bf61dbeff95520a3d123bb1a68eaca98eb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2dabe39b5600714274285d364cd0600bc7662267
          - Tweak ScriptForge GetDocument description to explicitly explain document must be open
            
            Change-Id: I9c2429de9114ed843215252803fa0118c113e41a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130162
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [ae7e7b3eed77878ac75e3f7f83b9902e133aeacc]

        cid#1500569 silence Explicit null dereferenced
        
        likely silences it, an experiment
        
        Change-Id: I095d2dad74331a08ed649cea9bef08b63f9ef1de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130279
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [57c30e9f773cc9553ae70e22828e6d41df04cdaf]

        cid#1500621 silence Dereference after null check
        
        Change-Id: Ib8d5eff6e2489e66754b73bc3a59f152e344d35f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130278
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [877705230adc23bc61186885ef5b95f3914d64b0]

        upgrade to expat 2.4.6
        
        Change-Id: Ibec5c6b2a321c48725e0888135c09d9b1835d0b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [7a736a1cdc45f14c66b1c5fc96db4f5418267114]

        CppunitTest_sd_uiimpress: Remove duplicated dispatchCommand
        
        SdUiImpressTest already inherits from unotest::MacrosTest
        
        Change-Id: If9683cf6ddb9c56913e19d9c7d1ebbf09864b742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130280
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3fd5ddb3d01598ea434e6ad843a04a82c2f238f8]

        Update git submodules
        
        * Update translations from branch 'master'
          to 149fb7cb5fbb3f555c66b2c93d057776f63e9ce3
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I84d3e51e5fc79ab4803b8df70e6522f9b34b8cc7
            
2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [8cb6bdf6279614cd8260d2fffdc6240dcc0f2b63]

        cid#1500584 Dereference before null check
        
        Change-Id: I7d5c0ba027e94d3f085eaacf158a31c525fa7eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130277
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [c118de71bf9be88ab1045621116e04bf0d1e084f]

        cid#1500564 Dereference null return value
        
        Change-Id: Ia3e0521a013c3226f2fd5fdfef4e67dc1d5a0374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130276
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [b55eca694b3cf4bcaec59512709c705fe4c25943]

        cid#1500563 silence Explicit null dereferenced
        
        probably silences it, an experiment
        
        Change-Id: I4bae3fb1d8907e6e02fa5e68a6fdb66e53e4f7b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130275
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [846374f00e820323b4555c6438309f2c1a524d6f]

        tdf#147164: vcl_pdfexport: Add unittest
        
        Change-Id: I254e9d7fa3795ee56080b9f065ab5112677fb7d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130244
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [e48ebfd576ab9547c89d23d647a14b43a85d70ea]

        cid#1500559 silence Dereference before null check
        
        Change-Id: I515c2ba2b1a258dd897f28b12a08f1d1f48106d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [e73c1e127b3395a9a65c55d4f978f2368b7ec3dd]

        cid#1500396 silence Dereference after null check
        
        Change-Id: I284f256637a9e91a8cc5c431565a1ebe946a202c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130272
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Stephan Bergmann  <sbergman@redhat.com>  [5e8f64e50f97d39e83a3358697be14db03566878]

        Avoid unnecessary empty -Djava.class.path=
        
        Change-Id: Idcfe7321077b60381c0273910b1faeb444ef1fd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130242
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d39f886ea541f71a09d1d7140c77852b01c847f0]

        speed up SvxShape::_setPropertyValue
        
        by using the Properties related code to create an SfxItemSet with the
        correct ranges, instead of creating an empty SfxItemSet and updating it.
        Shaves 2% off the load time of a large chart.
        
        Change-Id: Ia1f8527fa52ab5b8c70e13e1e2ab8c8f25739b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [e4aaf59f4801431d5bdd1aa6e18d2aa8eba39f1c]

        cid#1500465 Dereference after null check
        
        Change-Id: I3a9b1195c1694d6160c44da152b3502cdd501b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [a9a4b82c9f5523fbd500a4db0933c5f5ab9902b6]

        cid#1500458 Dereference after null check
        
        Change-Id: Ic9626b0817ee65fbc6d68592c592c3c2e39d42e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [587f3f98e1c00112200941750745e638bc830b41]

        cid#1500555 silence Untrusted loop bound
        
        and others, we're not bothered that the contents of the string might
        have been constructed using byte swapping
        
        Change-Id: I0d0c2e0667bf270e2c15624c59312f3f203bb83c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130246
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Stephan Bergmann  <sbergman@redhat.com>  [2a82e4cd5e1af0e232b770d7ad04c8dc61b0345d]

        external/skia: Missing include (for std::max)
        
        Change-Id: If15570311857b3d5c7a44777f20df446a0d91ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130245
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-21  Gabor Kelemen  <kelemeng@ubuntu.com>  [4df97bdfac6fb41ec0e3cabd4bef17f2c4e8d84c]

        Recheck modules sd* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I97c1a0e8c7f26807b12e6062581066d09ea13086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130114
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-21  Michael Stahl  <michael.stahl@allotropia.de>  [d50a7151431335d1431bccef000ae39f84bdf135]

        libxml2: upgrade to release 2.9.13
        
        Fixes CVE-2022-23308
        
        Change-Id: I1b3bf5cf58d7d1f39c224b0d898176c95107fbf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130241
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-21  Luboš Luňák  <l.lunak@collabora.com>  [b26c34267cdf9d0b7ba4e2fda7ae706d5cd76299]

        replace SfxPoolItem::LookupHashCode() with Lookup() (tdf#135215)
        
        The LookupHashCode() way still loops over an array while calling
        virtual functions for a type that is actually known. Overriding
        instead a whole new Lookup() function that does the loop
        avoids the virtual calls, allowing compiler optimizations such
        as inlining, or class-specific optimizations like the hash code.
        So this still improves performance with ScPatternAttr a bit,
        for tdf#135215 it saves about 40% of load time, but this is
        scraping the bottom of the barrel, as this is still a linear search
        (the IsSortable() approach, if it worked, would be still 3x faster).
        
        Change-Id: I8fe5f70cabb77e2f6619d169beee8a3b4da46213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130228
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-21  Mike Kaganski  <mike.kaganski@collabora.com>  [0723b41bed9bb4ad50d2993744a60177966d1a21]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f43f4bbd7d4cdfa714d2ac56b099199eafd846a6
          - Use soffice.com in command line parameters help
            
            Which is available since version 6.3. It is the proper console
            application on Windows, and thus will correctly show the console
            output, and return the program exit code, unlike soffice.exe.
            
            Change-Id: Iff3963489492fe2b8bad40bcfe259a40b3f38fe3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130250
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [b438854a0b5148880e455cbeeff14d4e3d825711]

        gtk4: get getPreferredPlayerWindowSize working
        
        Change-Id: I5e5b02be6a902232c24120db513cdf3fc68b4421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Caolán McNamara  <caolanm@redhat.com>  [f049c3884f7a376374ed6cffea6746ef35b00186]

        gtk4: get XFrameGrabber to work
        
        Change-Id: I737fd72d11b11d0c3592857113e422f29da76e77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-21  Stephan Bergmann  <sbergman@redhat.com>  [56c4445a8060d8ef6aec78f54ea28f4d7e5a8aa7]

        Fail Executable_ulfex upon duplicate keys in malformed input
        
        ...instead of causing use-after-free of pMergeEntrys, which would be destroyed
        during the (non-adding) emplace call but would still be used in the following
        if/else block (see the commit message of
        c6e2052b6f0d281fed334f8c803b1a6486d5b3bc "Update git submodules: Fix duplicate
        key typo")
        
        Change-Id: Iac8d67e61aba0144d3d5807f478c7b330d7c4c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130235
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-21  Miklos Vajna  <vmiklos@collabora.com>  [846f483dca0f0df0f3d1fd42ba3101e47580d98e]

        sw: prefix members of SwGlobalFrameListener_Impl, SwGlobalTree, ...
        
        ... SwGraphicContent and SwPercentField
        
        See tdf#94879 for motivation.
        
        Change-Id: Ida015287f722bdec4dbe6c5329d307fa95246583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130234
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-21  Stephan Bergmann  <sbergman@redhat.com>  [a663e4aaaa4962fc6356bbf3771831835ea3bc4c]

        Update git submodules
        
        * Update translations from branch 'master'
          to 11ab564c5b22d8de47c9284ae6c6943935633bd7
          - Also fix all the other locale duplicate key typos
            
            ...besides just the one in the "de" locale fixed by
            eb786dcfdb26a3ea4162190386fe01adba7ae992 "Fix duplicate key typo" (which I had
            unfortunately prepared for a `--with-lang=en-US de` build instead of a full
            `--with-lang=ALL` one)
            
            Change-Id: I196dfb80d8ccedaf0941384433e43cb7a0edaa0b
            Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/130236
            Tested-by: Stephan Bergmann <sbergman@redhat.com>
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-02-21  Deep17  <deepoose2011@gmail.com>  [6aec296589f9e1fb35443fc1cdbe5e8ea50d100b]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I8f2dd2049a70dde809a1b1afb1f67d5feaf60d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130222
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-21  Szymon Kłos  <szymon.klos@collabora.com>  [f1385af519ba9e5a6d78f89dcff83f1fd98feb60]

        Fix Bitmap::Rotate
        
        Bug introduced in:
            commit 74c46b12340f1afb1752f5df0bab91caca3ef63f
            speed up bitmap rotation
        
        it was showing some artifacts in LOK when using previews in rotation
        -> sin and cos values were used incorrectly
        
        Change-Id: Id85c54d0aa4488f19e7b5db2e242fdb446626699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129528
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130233
        Tested-by: Jenkins

2022-02-21  Szymon Kłos  <szymon.klos@collabora.com>  [522bde9470bbb321813fa5f1ca8e3c2ebb1bb5cc]

        Update styles previews in Idle
        
        This helps with performance when we do series of actions
        updating styles. In that case we will only request update.
        When we will reach idle state we will do it only one time.
        What removes unnecessary updates in the meantime.
        
        Change-Id: I9fc59992833a6cf98c42571c1189b3c5d49ba5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126840
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130232
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-21  Gökay ŞATIR  <gokaysatir@gmail.com>  [3ab1a849ba54410d14e2c988ae010f2c31dd4dce]

        Use JSDialogBuilder for "Find and Replace" dialog.
        
        Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
        Change-Id: I31307601f067c9b303854899258139678ddbba57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124586
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130231
        Tested-by: Jenkins

2022-02-21  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e90046a7de441552890aedb7df1f33561addd673]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 926ec2309a774598f438f00ced7990b9b094239f
          - fix typo at database toolbars page
            
            Change-Id: I5da6aaa59244cc3efb8c66c867252f29afe6dcce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130221
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e3ec2e51ae15d0089be33831bc6d4b8dbcddbfef]

        Sukapura: tdf#138400 General Number Format icons
        
        Change-Id: I71005bb44e407bdbc48654f7399a397d03ef86a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130230
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ddd4298086e98a706c8765b2a77d6a6f364706a8]

        Colibre: tdf#138400 General Number Format icons
        
        Change-Id: If1ee2bb381b2b27f4f6a405cdde5dc58a35b0f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130229
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2fb46b6afafe297499298f9af3ca69f9ce379781]

        Colibre: Update Template Manager icons
        
        Change-Id: If1d0101990fec60df0fc32f511d6d6e7cb8bff5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130227
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a0f208ce0763f60e02a11caa8059bd8cd538540e]

        Colibre: tdf#146761 add Edit Template icons
        
        Change-Id: I3382d1ddc0ac3837f5b292fdefcf8444024b6068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130226
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [205a94e7ac14569e535f47ed21cdf181a088e37f]

        elementary: Fix unused icon definition in links.txt
        
        Change-Id: I5ef56e9bac0c42d514839dc6f6dca522743ae584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130225
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-21  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [779dce05ab81f6c7ee0900f37b9621cbaf9781c3]

        Sukapura: update small Subscript & Superscript icons
        
        Change-Id: I59e4255312410d5d190b5034440fe059a866689d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130212
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-20  Heiko Tietze  <tietze.heiko@gmail.com>  [90546b02d70cb9a9c3ee88428d99635a2f7eb22a]

        Resolves tdf#146929 - Remember user input for the compress dialog
        
        Change-Id: I23a0cd10b6936de920a294901f860620fc2af0a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129894
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-20  Luboš Luňák  <l.lunak@collabora.com>  [0d402556af53790adb06380b4b04ea421d14d09e]

        fix usage of std::lower_bound() in SfxItemPool (tdf#81765)
        
        The function expects elements starting from smallest to the biggest,
        and finds the first one that is not smaller than the one searched for.
        That means that all items remaining will not be smaller, and thus
        end of search is when items compare larger. Comparing remaining
        items as smaller means searching until the end.
        
        Change-Id: If5cf5c18951abf987ddbbf201f49cfb195e36d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130220
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-20  Luboš Luňák  <l.lunak@collabora.com>  [e81400196cd9c24be32552a19851da4162d51c7a]

        fix ScPatternAttr lookup hashing (tdf#135215)
        
        I made a mistake in 98d51bf8ce13bdac2d71f50f58d6d0ddb by using
        SfxItemSet::Count(), which returns a number of existing items.
        But EqualPatternSets() compares all items, even empty ones,
        so I should have used TotalCount() (which is actually hardcoded
        as a number in the code). Without this, the hash usually didn't
        include all items, leading to matching hashes even though
        the items clearly didn't match.
        
        Change-Id: I1e25752d3ddca2b63c3c295a9a425965531cd4d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [26603bc9ef0116ed31c510dab82b69d3666447b5]

        WASM fix orcus native exception handling (NEH)
        
        While this fixes the build with --enable-wasm-exceptions, the
        resulting binary generates an "indirect call signature mismatch",
        which doesn't happen with the non-NEH build.
        
        The Chrome DWARF backtrace points to CallbackTaskScheduling().
        Further debugging reveals, it's actually the UpdateMinPeriod
        call for the "desktop::Desktop m_firstRunTimer" Timer.
        Disturbingly the debug dynamic_cast<Timer> at the start of the
        job loop fails, and the fallback generic job output is
        chosen, AKA:
        
        info:vcl.schedule: 6516 0x3871618  i: 0 a: 1 p: 1 \
            desktop::Desktop m_firstRunTimer
        
        m_firstRunTimer is a Timer member in the Desktop class, so this
        looks like some memory corruption or toolchain problem.
        
        The size difference is more then 10% and it's supposed to be
        faster too. FWIW the optimized link time is still high and needs
        32GB+ memory compared to the 13GB non-optimized memory usage.
        
        Change-Id: I06d37ecece09000fd3b72a73e7bf40f0b0f61457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130216
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [0b0d41b48fa7c5aebd42bdce60dab77421743ae1]

        Fix --disable-avmedia build
        
        Regression from commit 6f938dce6eaa927cfde39491ef7a0bc1d07df66b
        ("update video pos and size after change if currently playing").
        
        Change-Id: Ib618fcd7347255d0cae352b7fc90aa85a2c14d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130215
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [ac65b4bb7a75ec71294a527bc4139356fcbf0929]

        WASM depend on Emscripten 3.1.3 for native EH
        
        This reverts the special SjLj handling introduced in commit
        ae22f7d06246ee21f9c8e9f35f4477e88843c58b ("WASM add option to
        build with native exceptions"). This is supposed to work now;
        at least it compiles.
        
        Change-Id: I5ebceea9c7fe3c982d7c9a8818fd79f2018f03cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130219
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [89d97041e881ef6429c069e7d0485db50e0371b2]

        WASM test minimal Emscripten version in configure
        
        Extracting the version from the compiler defines is probably more
        stable then the elaborative emcc -v output.
        
        Change-Id: I491c0983be7f9811f4f6775b0a5f3cb172f0aefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130218
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-20  Stephan Bergmann  <sbergman@redhat.com>  [c6e2052b6f0d281fed334f8c803b1a6486d5b3bc]

        Update git submodules
        
        * Update translations from branch 'master'
          to eb786dcfdb26a3ea4162190386fe01adba7ae992
          - Fix duplicate key typo
            
            (cf. core commit f0a3678ef3b048d166179513670633e1bb3acfb8 "Fix 'Adding Central
            Kurdish(ckb) Spell Checker & Dictionary'"), which caused builds like
            <https://ci.libreoffice.org/job/lo_daily_tb_win/929/> to fail with
            
            > /usr/bin/sh: line 1: 51209 Segmentation fault      PATH="/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program:/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program:$PATH" $W/LinkTarget/Executable/ulfex.exe -i $S/scp2/source/ooo/module_ooo.ulf -o $W/ScpMergeTarget/scp2/source/ooo/module_ooo.ulf -m ${MERGEINPUT} -l all
            > make[1]: *** [C:/cygwin/home/tdf/jenkins/daily_workspace/tb/src_master/solenv/gbuild/InstallModuleTarget.mk:113: C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/workdir/ScpMergeTarget/scp2/source/ooo/module_ooo.ulf] Error 139
            > make[1]: *** Deleting file 'C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/workdir/ScpMergeTarget/scp2/source/ooo/module_ooo.ulf'
            
            because of (as seen with a corresponding ASan build)
            
            > ==250602==ERROR: AddressSanitizer: heap-use-after-free on address 0x6160000060b0 at pc 0x0000003845f4 bp 0x7ffdb0cb81f0 sp 0x7ffdb0cb81e8
            > READ of size 8 at 0x6160000060b0 thread T0
            >  #0 in std::_Hashtable<rtl::OString, std::pair<rtl::OString const, rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> >, std::__detail::_Select1st, std::equal_to<rtl::OString>, std::hash<rtl::OString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_bucket_index(unsigned long) const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable.h:796:55
            >  #1 in std::__detail::_Map_base<rtl::OString, std::pair<rtl::OString const, rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> >, std::__detail::_Select1st, std::equal_to<rtl::OString>, std::hash<rtl::OString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>, true>::operator[](rtl::OString const&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable_policy.h:772:32
            >  #2 in std::__cxx1998::unordered_map<rtl::OString, rtl::OString, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >::operator[](rtl::OString const&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/unordered_map.h:980:16
            >  #3 in MergeEntrys::InsertEntry(rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&) at l10ntools/inc/export.hxx:93:9
            >  #4 in MergeDataFile::InsertEntry(std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:317:23
            >  #5 in MergeDataFile::MergeDataFile(rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:205:13
            >  #6 in LngParser::Merge(rtl::OString const&, rtl::OString const&, rtl::OString const&) at l10ntools/source/lngmerge.cxx:154:19
            >  #7 in sal_main_with_args(int, char**) at l10ntools/source/lngex.cxx:39:17
            >  #8 in main at l10ntools/source/lngex.cxx:28:1
            >
            > 0x6160000060b0 is located 48 bytes inside of 576-byte region [0x616000006080,0x6160000062c0)
            > freed by thread T0 here:
            >  #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
            >  #1 in std::default_delete<MergeEntrys>::operator()(MergeEntrys*) const at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/unique_ptr.h:85:2
            >  #2 in std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >::~unique_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/unique_ptr.h:365:4
            >  #3 in std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >::~pair() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_pair.h:185:12
            >  #4 in void std::destroy_at<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > >(std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/stl_construct.h:88:15
            >  #5 in void std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, true> > >::destroy<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > >(std::allocator<std::__detail::_Hash_node<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, true> >&, std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/alloc_traits.h:537:4
            >  #6 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, true> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, true>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable_policy.h:1982:7
            >  #7 in std::_Hashtable<rtl::OString, std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > >, std::__detail::_Select1st, std::equal_to<rtl::OString>, std::hash<rtl::OString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_Scoped_node::~_Scoped_node() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable.h:310:39
            >  #8 in std::pair<std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, false, true>, bool> std::_Hashtable<rtl::OString, std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > >, std::__detail::_Select1st, std::equal_to<rtl::OString>, std::hash<rtl::OString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_emplace<rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >(std::integral_constant<bool, true>, rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable.h:2082:7
            >  #9 in std::pair<std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, false, true>, bool> std::_Hashtable<rtl::OString, std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > >, std::__detail::_Select1st, std::equal_to<rtl::OString>, std::hash<rtl::OString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::emplace<rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >(rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/hashtable.h:948:11
            >  #10 in std::pair<std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, false, true>, bool> std::__cxx1998::unordered_map<rtl::OString, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > > >::emplace<rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >(rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/bits/unordered_map.h:389:16
            >  #11 in std::pair<__gnu_debug::_Safe_iterator<std::__detail::_Node_iterator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >, false, true>, std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > > >, std::forward_iterator_tag>, bool> std::__debug::unordered_map<rtl::OString, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >, std::hash<rtl::OString>, std::equal_to<rtl::OString>, std::allocator<std::pair<rtl::OString const, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > > > >::emplace<rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> > >(rtl::OString&, std::unique_ptr<MergeEntrys, std::default_delete<MergeEntrys> >&&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.1/../../../../include/c++/12.0.1/debug/unordered_map:334:24
            >  #12 in MergeDataFile::InsertEntry(std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:301:14
            >  #13 in MergeDataFile::MergeDataFile(rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:205:13
            >  #14 in LngParser::Merge(rtl::OString const&, rtl::OString const&, rtl::OString const&) at l10ntools/source/lngmerge.cxx:154:19
            >  #15 in sal_main_with_args(int, char**) at l10ntools/source/lngex.cxx:39:17
            >  #16 in main at l10ntools/source/lngex.cxx:28:1
            >
            > previously allocated by thread T0 here:
            >  #0 in operator new(unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3
            >  #1 in MergeDataFile::InsertEntry(std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:300:24
            >  #2 in MergeDataFile::MergeDataFile(rtl::OString const&, rtl::OString const&, bool, bool) at l10ntools/source/merge.cxx:205:13
            >  #3 in LngParser::Merge(rtl::OString const&, rtl::OString const&, rtl::OString const&) at l10ntools/source/lngmerge.cxx:154:19
            >  #4 in sal_main_with_args(int, char**) at l10ntools/source/lngex.cxx:39:17
            >  #5 in main at l10ntools/source/lngex.cxx:28:1
            
            (which will be addressed with a modification to core l10ntools/source/merge.cxx,
            to reliably abort Executable_ulfex upon such bad input)
            
            Change-Id: I05f52a3650b57548e2035f6521d582a607d68c0d
            Reviewed-on: https://gerrit.libreoffice.org/c/translations/+/130217
            Tested-by: Stephan Bergmann <sbergman@redhat.com>
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2022-02-20  Stephan Bergmann  <sbergman@redhat.com>  [dc6530f2599c56fbf2e8c24cc5d4833f4b847735]

        Adapt Library_jpipe__staticsalhack
        
        ...to 9eb9083ff2fdaeb96399a0830a4394de4e29ef64 "Use Dragonbox to implement
        doubleTo*String*"
        
        Change-Id: I40f4db5b33d21f842705485e0ad8cdc0889736a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130211
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-20  Sarper Akdemir  <sarper.akdemir@collabora.com>  [c92aa69bc63ffb2dddbde0bfb3fe80c7de67a06f]

        tdf#146690: pptx export: fix endParaRPr size value for empty paragraphs
        
        Fixes paragraphs made from a single new line, not getting the
        correct sz(text size) value in EndParagraphRunProperties on pptx
        export
        
        Change-Id: I31ebb5735ad392e081aa2f43b0b60a845e4de9c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128265
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-02-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2b80f5a1646308ed43d1d7fee6ce3cefdc9e05e3]

        Sukapura: tdf#144036 add UNO Object Inspector icons
        
        Change-Id: I1b16ecb118df59add4b9d39118cf5b22afb4c6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130208
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-20  Luboš Luňák  <l.lunak@collabora.com>  [9c7f3ddf5b3c23de0fed08fa3ebdfa2a95fec588]

        optimize XclExpRowBuffer::GetOrCreateRow() (tdf#140893)
        
        This gets called often especially with larger spreadsheets.
        
        Change-Id: I6acf23d0942d1745a52963c9b5b08453e1ec28bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130207
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-20  Luboš Luňák  <l.lunak@centrum.cz>  [fdcea8ccc8236b0975ac9c85dcabf9c663e4b627]

        make CollectCellAction sort cells by cell address (tdf#119083)
        
        Many calc algorithms perform better if they process cells ordered
        by tab,col,row. In the case of tdf#119083 it's
        ScDocument::TrackFormulas().
        
        Change-Id: I1eedefc0130f5cf95feb84a4160b7599d3a09fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130205
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-20  Luboš Luňák  <l.lunak@collabora.com>  [131710cba68e46c175babbd20c810e7fc2fb811f]

        optimize AreaBroadcast() a bit
        
        Use ComputeAreaPoints() rather than repeated ComputeSlotOffset().
        
        Change-Id: If7869fe4c37a1e844ec9e6513a7c1799290c077f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130204
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b965efc0ab5d6996417c92b5588e9d1ff79e0572]

        Breeze: add Calc's Edit > Select > Select Sheets.. icons
        
        Change-Id: Ide474cd818217f24ec144de00eab58f01f8d2575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130196
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e64c2cf6cf64def94e9f382bcd101225173ae719]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2d7503bd781bb3d9b4680f75b4af7141fb6295c8
          - do not localize CallType values
            
            Change-Id: Ie5d6b52da5b254945b48b7e126e56b86936456f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130199
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-19  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ba002449738d2837d270452351cf2e914db97312]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f5f8ee67bc1b48c912e3bf6490827a9815fa5674
          - do not localize UNO service names
            
            Change-Id: I8e2452bd5bdacfd34fe93ed87da43c5e18ac279b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130200
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [19613544fcba9e08d0d9f24cbd976ed12431d4b2]

        tdf#147166 EditTextObjectImpl copy ctor doesn't exactly copy EditTextObjectImpl
        
        and this is apparently relied on, so eliding the copy gives unexpected
        results.
        
        EditTextObjectImpl::Clone returns a copy of *this, but the
        EditTextObjectImpl copy ctor explicitly does not copy the "PortionInfo"
        member, so in:
        
        commit fb8973f31f111229be5184f4e4223e963ced2c7b
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Sat Oct 10 19:21:38 2020 +0100
        
            ofz#23492 the only user of this ctor throws away the original of the clone
        
            so we can take ownership of the original instead
        
        where the copy was optimized away we want from a state where there was a
        new EditTextObjectImpl with an empty PortionInfo member to one where the
        PortionInfo of the EditTextObjectImpl was retained.
        
        So explicitly clear this unwanted info.
        
        It's very hard to make rational judgements about code if a copy behaves
        differently than the orignal :-(
        
        Change-Id: I642d60841d6bdccbf830f8a2ccdbd9f542a8aa18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130201
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [992f3922cfe164369f47b5a0f614a54bd539e52a]

        Breeze: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: I4fdde4466f98a0c7d19c880781d1f17091a69619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130193
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [166f57d927802bbe489197097b02ad52bbbffd79]

        Sukapura: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: I3005a62a1938d832fa33511f08f610d3f23fc814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130192
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [e1d0c27cc98006f8edfa6bc7e6dafb96ca1bc503]

        upgrade expat to 2.4.5
        
        CVE-2022-25235
        CVE-2022-25236
        CVE-2022-25313
        CVE-2022-25314
        CVE-2022-25315
        
        Change-Id: I1cb0449411fe938fe47ab47cead685fd04e137dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130198
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d3232aaa3330180ddc929b289fed19e4a895661e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b54a0e6d50e8eaaa37ca844b1c92d3778d4567cf
          - correct and reformulate description of CBool example
            
            Change-Id: I4a17e3bebc834c095ce909bbb06f0d7c8655cb04
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130107
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [f5651fc116c41611e3d6d0a6a8462c39b22bdf9c]

        KJ: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: I439d6b2e0ca5283d6b67c0bd917886258a6bdf66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130184
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [92b10e9ca4d6a78d9879380532e069f26a2703ba]

        Sifr: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: Iecbfdee0c6102c7bcfa17f78e2aeaf15041e000c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130185
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Luboš Luňák  <l.lunak@collabora.com>  [400568f51c63f5ec8de08a3255ce83cc1b0bdb66]

        simplify code using PutInOrder()
        
        Change-Id: I71efd7ef83618d4f556dd6a0baa8ca6ffec17392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130194
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [94fc8eaba84a328ea064ee13efdd405e61209a50]

        uilogger: improve language in comments
        
        Change-Id: I8406bdf375cf83d504e45a5c8f27ce2ceb1f9c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130190
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-19  Luboš Luňák  <l.lunak@collabora.com>  [725e1066cbe3bbd6759b3e7396bc5d0ecb55a504]

        remove MAXCOL/MAXROW from ScAddress/ScRange (tdf#147509)
        
        Change-Id: I4e80bba8b866f9915a6600ce67774380e619c2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130188
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [6f938dce6eaa927cfde39491ef7a0bc1d07df66b]

        update video pos and size after change if currently playing
        
        I'd prefer if it changed size during the resizing/repositioning, but
        at least make it immediately take the final size after the
        resize/reposition has happened.
        
        Change-Id: Ic3b4dd23921ad5cf6092f1514dd6538f9946998a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130178
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [f10ac3e5bd720e363e5c76a2c841dded4859a7a0]

        gtk4: use gtk_widget_set_can_target so the video can be picked up and moved
        
        at least the rect it should stick to can be picked up and moved
        
        Change-Id: I71b53865049fef8dc3efa09dd441d66003ed1f47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [62d9d64c90eaf4b6d8ff20b615c5645e12a9cba9]

        gtk4: the assumption is that video is supposed to fit to the window
        
        Change-Id: Iacc31ee978a1279c23ac895fb6f8fd610ab3113d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130176
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Caolán McNamara  <caolanm@redhat.com>  [869a2228401195179deea0a6ad994183841c2c4d]

        cid#1500273 silence Dereference null return value
        
        this has been unchecked since the initial commit, so let's assume its
        intentional
        
        Change-Id: Iefe5ea1c49b6e97d3b7bb1021d214c00d4369c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8a34ce5c3a1c4feffefa8a6c9315aed61cede2e6]

        Removed executable bits on idl file
        
        Change-Id: I1579cf509d3c3d50de2ebb1a03e6ca01fe27820a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130187
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-19  Julien Nabet  <serval2412@yahoo.fr>  [ec41dcdddb47f39ede581ce00dc20ecd4fe3458b]

        Simplify sequence of Property in dbaccess
        
        Change-Id: I270702ad4b4878ee5c1942be3c45eae370f37f8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130189
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e984de7855659fe96d37c533e4d5a8ba370f4b31]

        elementary: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: I102efd1dcc7e42e60afb3f0efcfd497a3afde515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130181
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Julien Nabet  <serval2412@yahoo.fr>  [f0a3678ef3b048d166179513670633e1bb3acfb8]

        Fix "Adding Central Kurdish(ckb) Spell Checker & Dictionary"
        
        Change-Id: I494c515e91ddcab469941ce04d08e9b11974ee7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130169
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6fd0d51549ef750e9e3c77ece7b4ab05ccf8ab23]

        Colibre: tdf#147521 add Duplicate Sheet icons
        
        Change-Id: I6f5df1857af9e0b0f81220658d09bab7ff0d6d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130183
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2022-02-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [bcc83732f906bb7e89f8d67e4817fe0f4bf09b0e]

        uilogger: make vertical tab handling more robust
        
        For example hyperlink dialog does not have numeric ids for tabs.
        Now the rule matches both integers and "common identifiers" as per
        https://textx.github.io/textX/stable/grammar/#textx-base-types
        
        Parent argument was removed as it does not seem to be used and
        it was empty in the case of the hyperlink dialog, causing the DSL
        parser to fail.
        
        More work is needed as self.xUITest.getTopFocusWindow() in a
        hyperlink dialog opening test does not contain the child "tabcontrol"
        and thus it errors out.
        
        Change-Id: I1637f7300884881ee4d869e8f04700e56935f2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130111
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-19  Eike Rathke  <erack@redhat.com>  [11a0e582ce4f4065c35fe0a12bc13bf53aaa1dd0]

        XFunctionAccess::callFunction() accept empty Sequence<Sequence<Any>>
        
        ... as omitted argument with ocMissing token.
        
        Change-Id: If6467c624223171904b4fa642b04581350c17973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130179
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [0038a2df911d807a47f7891ab47d19af0a9ed544]

        cid#1500272 silence Dereference after null check
        
        before:
        
        commit 24caeee8236576abd92086974c1dbbf15b81a4c5
        Date:   Sun Dec 8 17:33:53 2019 +0000
        
            Refactor a bit of the footnote handling code
        
        the IsFootnoteContFrame() was assume to be always true,
        return to that state but assert rather than OSL_ENSURE
        
        Change-Id: Ia8ca179814b08e3c415ea74ada8a063b75a2557a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130175
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Heiko Tietze  <tietze.heiko@gmail.com>  [87aeb7be943921942f791cd182122e8e073ce804]

        Resolves tdf#137381 - Use app colors on chapter numbering preview
        
        Change-Id: I8e5edec1ad6f4b6f44855014ce91a642efbd75f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130133
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [d0a527ec09516bc7215baf229adb90cd21ffa27a]

        first cut at using Gtk4 built in video playback
        
        Change-Id: Ib996cd3f5ddbf20a81cdbe4b1c6546d6df478fde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129783
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [4da31ebb064d13f5bb180b5b3b689375246ddc00]

        there's only one media backend per platform currently
        
        Change-Id: I8722395617929f7d710713934dd619134a318071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130170
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [bebf2433ba1b7797bddddb06bdeec7975250181c]

        tdf#124818: sc: move UItest to CppUnittest
        
        The original UItest is just wrong. The report talks about
        Select all - Cut - Undo and no cut and not undo is done there
        
        Change-Id: I53b925f86aa01fd4f161ec3180b2d7471baff09f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130172
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [dc6eb44e625c541be1db5911d53b3b0cc30a2b1f]

        qt a11y: Map CARET_CHANGED event to Qt equivalent
        
        The previous handling of mapping that to
        QAccessible::TableSummaryChanged looks rather arbitrary.
        
        Change-Id: I066cee4bd90a49a47dd29252c11f8f74edccb637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130141
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e2f69136d16ad2458dab87c66d4f865aa92f898c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71a2d9e0c995afbc1d71b7030b536c4590107afc
          - Improve bootstrap -env parameter at CLI
            
            Change-Id: Iba470dd3110269759608b8411a8fb2f5cb14e30a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130168
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2baedf218bb9e35d72f981a0d64c59b87900c5f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 70f656485e6b507466ecfe8c17fc35bad89f2e33
          - Fixes after translation comments
            
            Change-Id: I6ea5c43b75e89704a069add030070ddd8f008623
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130153
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-18  Henry Castro  <hcastro@collabora.com>  [12746af8c3c07cc38c682073d55bfa9eadde0b67]

        lok: sc: unit test drag & drop
        
        ..
        
        Change-Id: I774ece93e5c439c65df50e6a67d1447a062708b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121898
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129470
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Henry Castro  <hcastro@collabora.com>  [84cfc755828ae2c552f7edee221c2b5610c1d4db]

        lok: sc: update ScModelObj::postMouseEvent
        
        It is intended to process the drag & drop functionality
        in Calc.
        
        Change-Id: I501cd94e309dabf8472e5c5aa9661e7273cd0dae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118879
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117733
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Michael Weghorn  <m.weghorn@posteo.de>  [1afa29d1e526c4e10318a4b05767fa4333786cd4]

        sw a11y: Make these SwAccessibleMap members private
        
        And drop the 'SET_PARA' typedef which was no longer
        referring to a set by now anyway.
        
        Change-Id: I303b335cd3276562ed02e668a912895f78dc506c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130140
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-18  Henry Castro  <hcastro@collabora.com>  [6a5dfb88d75bccd6e7c8fd54365093cece2b1de7]

        lok: test: fix testSheetSelections
        
        The unit test is selecting again range,
        it will conflict with the drag & drop
        because it will drop to new cell address.
        
        The unit test will fail, the removed code
        will be used to a new unit test for drag & drop.
        
        Change-Id: I896f5cd7e6b671f3fac95c8ae76e7558fa8dd1d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123062
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129468
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Luboš Luňák  <l.lunak@collabora.com>  [35cad9f57e761eef78820d092a4bb9d2f0641052]

        convert more MAXCOL/MAXROW
        
        Change-Id: Ifb2c9ea7b440890224c7e837422c8a1358f8c5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130143
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-18  Szymon Kłos  <szymon.klos@collabora.com>  [c58c353d8c57aef62ec0a56c18918156ab7f84b7]

        lok: sc: focus gridwin before use
        
        commit ef29f8c57dbb73ee3bd2e09ea557b86bf3eacfa6
        lok: sc: update ScModelObj::postMouseEvent
        
        introduced Drag&drop for online. One missing thing was
        getting the focus for gridwin before mouse event processing
        like it is done in LOKPostAsyncEvent
        
        Change-Id: I4063340985f7dcc91cf5382631615119e28ea3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123391
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129471
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Szymon Kłos  <szymon.klos@collabora.com>  [70b54e7693830841ac6828b116fd814b178ce66d]

        lok: send drag overlay
        
        Change-Id: I1e134fd99dffc4962bacbba97456365ab9347e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123242
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129467
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [a9417687d5817f1e6e7cb8e63c660a5c6731cdda]

        Simplify sequence of Property in connectivity/jdbc
        
        Change-Id: I703a3adc7203045288e982c4155dfc19a01e414a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130137
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [b805f8bcfbc506ab2d6e7d54f3f9a562b5a98258]

        Simplify sequence of Property in connectivity/firebird
        
        Change-Id: Ie45d5418e474cfeb2ac3ac62edbaa1e5bd688d9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130136
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Szymon Kłos  <szymon.klos@collabora.com>  [f0117eefa7d1b35e747546fd7d7a28126ebff0b7]

        lok: reset and cancel properly Drag & Drop action
        
        used patch from Henry as a template:
        https://gerrit.libreoffice.org/c/core/+/118844/17
        
        but without custom actions invocation
        
        Change-Id: I8bce66deffee0de16f3c24f009cfee077eb26e82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123243
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129469
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b8d6af27156faecb831c16afdc52dd630b641a9d]

        Update git submodules
        
        * Update translations from branch 'master'
          to d65e9655a561110d8e2cf702729ae75aa10c55ac
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I6fcbb9b3da0a0608a85d68ef43dd88d92022b083
            
2022-02-18  Szymon Kłos  <szymon.klos@collabora.com>  [24bf5c002cbeecef109e4e409e51305f03ea9fe6]

        lok: deglobalize SetDragObject
        
        and other Drag and Drop related functions
        
        Change-Id: Idbaec91c0ed396da9888c8ed562d2eff35686cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123209
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129466
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [321f6577cdafa728f73d1b679d86581f1c0db110]

        Simplify sequence of Property in connectivity/ado
        
        Change-Id: I1b1e183b053d98139ca5b45f3642d252252da14a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130142
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [a782e76da377296791d6e9f6ddf38c08ef4c4fb1]

        Simplify sequence of Property in connectivity/macab
        
        Change-Id: Id0ed3ab3d66dfb8b76030fad7cd0b2bc3ea010fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130139
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [dbb361815aa3aa6888c79f7c513aa3f35cf34570]

        Simplify sequence of Property in connectivity/mysqlc
        
        Change-Id: Ib4e1c47262c42db92226be5f84742799c3a1cbb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130138
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [0c76e951d53d5da56616442d7344b373add4afe2]

        Resolves: tdf#147393 SpinButtons should be can-focus
        
        Change-Id: I092ed9c3421267ea3b2c671020e7079c3f792e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130130
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [33ecf9ee134468ee444af7d68f6aa20fb82edc24]

        resave with latest glade
        
        Change-Id: Ia6fcf99a0d9bb914eb977f20426d6b093f21e3de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Henry Castro  <hcastro@collabora.com>  [5648bcdd7478b500869415b9224d45825df1c2e4]

        lok: sc: simplify drag & drop functions
        
        The ScDragData is a global use for private drag & drop
        in a desktop case, it will be used by tiled rendering
        case to pass its own local ScDragData per user.
        
        Change-Id: I0bca8e6d5c0eab82b69374a67425e2a8d746ef4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118990
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129465
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Caolán McNamara  <caolanm@redhat.com>  [4384444051ba2a59002e500f2ef209279bb9cae0]

        clear ScDocumentImport position cache if iterators are invalid
        
        SheetDataBuffer::finalizeArrayFormula calls
        
        ScCellRangeObj::setArrayTokens
        ScDocFunc::EnterMatrix
        ScDocument::InsertMatrixFormula
        
        and InsertMatrixFormula calls the variant of ScColumn::SetFormulaCell
        which doesn't take a sc::ColumnBlockPosition& param when SetFormulaCell
        adds a cell to the column so any iterators belonging to ScDocumentImport
        are invalid.
        
        Change-Id: Ic2814ecbeafdeb99632d2a255ed6c1dedf7376b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129991
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a7ee47a44630012a6feb020a054f7e804c306a3]

        -Werror=maybe-uninitialized
        
        /home/noel/libo3/svx/source/toolbars/extrusionbar.cxx: In static member
        function ‘static void svx::ExtrusionBar::getState(const SdrView*,
        SfxItemSet&)’:
        /home/noel/libo3/svx/source/toolbars/extrusionbar.cxx:938:25: error:
        ‘eMetalType’ may be used uninitialized in this function
        [-Werror=maybe-uninitialized]
        938 |                         if (eMetalType ==
        EnhancedCustomShapeMetalType::MetalMSCompatible)
              |                         ^~
        /home/noel/libo3/svx/source/toolbars/extrusionbar.cxx:933:31: note:
        ‘eMetalType’ was declared here
          933 |                     sal_Int16 eMetalType;
              |                               ^~~~~~~~~~
        
        Change-Id: Ie98bb04900d271299cb930bf6d12af46d45ae8c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [c18ca36af9ab24bedb240d36d7d95c7a6365252c]

        Simplify even more sequence of Property in connectivity/odbc
        
        Change-Id: I8dd75cf5c41aa879efe740f48bcb305901742804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130135
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Luboš Luňák  <l.lunak@collabora.com>  [50a125464eb70cad42ef906d688e89881796cf38]

        remove MAXCOLCOUNT from calc pivot implementation
        
        It appears that PIVOT_DATA_FIELD is just a custom special value
        that's outside of the valid column range, but otherwise the value
        doesn't matter, and -1 is generic.
        
        Change-Id: Ieac1d4e3391f76350dc420e6b2ae9ed9f35d35f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130124
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-18  Michael Meeks  <michael.meeks@collabora.com>  [7b7ed248c435f45acae2e0b5a9489098df98e6af]

        boost: use utf-8 encoding for unknown locales.
        
        More exotic locales like es-419 cannot be parsed by boost, so we
        fall-back to the default encoding. This avoids an exception:
        invalid_charset_error of the form:
        
        "Invalid or unsupported charset:us-ascii or UTF-8"
        
        for this case.
        
        Change-Id: I6796dd893ec774b221956ea9febbcc19495d47b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130102
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-02-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f761baac91f97057862b2782b95c301f67dfeb8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04eab5c5e9782cc901262135c68f394f1b3fd163
          - tdf#147362 Add bookmark for italic autocorrect function
            
            Add also bookmark index for undeline, bold, strikeout.
            
            Change-Id: I6f5ebde77ffbc95b3a1e3758994e734be8f616c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130053
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa85b303cde517e187a7c3404f9b63f0a0752bf3]

        avoid an allocation in WhichRangesContainer::MergeRange
        
        speeds up loading a large chart by 5%
        
        Change-Id: Idd8566012a0049d429e38b589782fc6d76eb3a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130132
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe2ec505786bacc6f3baca3292367903644ac99b]

        improve the SfxItemSet::CloneAsValue check
        
        to prevent object slicing.
        
        Which reveals a problems with
            commit 044fa30a4c77013c87a7e2a6dd9022a2f6599778
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Sep 23 18:44:42 2021 +0200
            no need to allocate this SfxItemSet on the heap
        and
            commit 044fa30a4c77013c87a7e2a6dd9022a2f6599778
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Thu Sep 23 18:44:42 2021 +0200
            no need to allocate this SfxItemSet on the heap
        so revert the problematic bits of those commits
        
        Change-Id: I5eeba1d5bdb91f4e539850516f2b1c11e69ff2c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130127
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-18  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [657095c9d26147e290e7944db875b9555b33dd1a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e86799f1b1e957e442a23022bc12cc25bb0c8a6
          - tdf#123318 Use SHARED as the default module instead of WRITER
            
            Change-Id: I78c3f71a862ad0896cc13b105cac46dca99b4195
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130079
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-18  Henry Castro  <hcastro@collabora.com>  [470448227dc3e26190e68ea6c58551d7e3993dbb]

        sfx2: introduce SfxBindings::QuerySlotId
        
        In order to invoke QueryState with the slot id,
        which it is easier to invoke UNO command states in unit test.
        
        Change-Id: I36d72a4381ff8386b1f1af33284ce674cf26acd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123063
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129464
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-18  Ahmet Hakan Çelik  <ahmethcelik@gmail.com>  [62a8580587aec1c1a3070448b063889c01ac5c11]

        Revert tdf#64345: EDITING: Selected area looses selection when switching sheet
        
        This reverts commit c82634d5a222120b3a95cff1b950a7f7a1f5ded1
        
        Change-Id: I627b46f710da723ad58295d4fa0821df17eebd9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130108
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-18  Julien Nabet  <serval2412@yahoo.fr>  [a8da31c6884a21d4df242b3e9654a812b775c54b]

        Simplify sequence of Property in connectivity/odbc
        
        Change-Id: Iaa2b908d63899c2e1141602b26d6da6b064f63e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130119
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-18  Miklos Vajna  <vmiklos@collabora.com>  [7417ac0b63557869bc5b7b8faa485145e27151c1]

        Remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: Ieddb3d76a960d4b87cd2a1e89bce3fcbe0fce7e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130113
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-18  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [9d9e1b0174e901ba8630232960380fc8e66dff39]

        Revert "Related tdf#143578 - Rename SAL_NO_QUERYSAVE to NO_QUERYSAVE"
        
        This reverts commit 75ac604292e92dc08bb8ba5b9cc30799d643090a.
        
        Reason for revert: Decision was made to have some prefix, either SAL_ or LO_
        
        Change-Id: I42c7ad8a8b8a83161db568895d1ec98dcdc0838f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130026
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-18  Luboš Luňák  <l.lunak@collabora.com>  [17b39d150fce188f653632a3467891157375a1c6]

        fix Writer key event delayed compression (tdf#145963)
        
        SwEditWin::KeyInput() was stopping the flush timer on every
        invocation, which means that as long as key events kept coming
        the timer would be started again and again and would not time out,
        and so the input buffer would not be actually processed. It seems
        that AnyInput(KEYBOARD) there actually does not normally manage
        to return true ... except for Win11 where it seems that now
        GetQueueStatus() detects even key-up events even though it didn't
        before (I've not debugged this enough to be certain).
        
        I think it still makes sense to have the compression in case Writer
        get overloaded to help it process the pending input events, so fix
        this (but if there are problems, I think an easy solution is simply
        to drop it, it doesn't seem to be that necessary). Also decrease
        the timeout from 200 to 20ms, as 200ms is a very visible delay.
        
        Change-Id: I760ad9c4f58726a80bd6a9fbf93f2771f10cbdb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130083
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [3c94a0f7729f1638ab3b273a186c48de859cfb49]

        tdf#143817 Fix HUD deleting text contents in Writer
        
        Change-Id: Ie28388016c475907c5d8fbe51906bc4a01d6b0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130091
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-18  Mike Kaganski  <mike.kaganski@collabora.com>  [cb56edb177f4db5b9cc4d140543c4b11d41ef1b0]

        Define policy to optimize to_decimal to our use case
        
        We don't need it to strip trailing zeroes (we do that ourselves anyway);
        also we don't need it to handle negatives.
        
        Makes doubleToString ~5% faster in my testing.
        
        Change-Id: Ie3c4e3fec1899364af54fda3f7141678a95359d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130120
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-18  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [48fd4f813f067498c6813a57869072e2a6cdb884]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 401fb641aff217c7c333ce71d22abcf575d3ed09
          - tdf#114263 tdf#141474 tdf#147262 CallByName() function new help page
            
            Change-Id: I99ed22b86b04a3ae4338e0c2ab49dbd594032ac6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129607
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-02-18  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [c856f9bec12d98ed49f01578ded79f16ae7be051]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d8d02f0803ea5eb98cfc120b52e1892cb5e1c6e5
          - tdf#146847 correction to Integer division help page
            
            Change-Id: Icdbdaf1fed778a0d235277680a2504386ec9208f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130010
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-02-17  Regina Henschel  <rb.henschel@t-online.de>  [4c0b033ece143b6f398157e812ff1c6b22e2855d]

        tdf#147409 tdf#146866 use SetPropertyValue for toggle
        
        The toggles (Textpath,SameLetterHeights) and (Extrusion,Extrusion)
        change a value by directly writing the value into the property. That
        is lines (*pAny) <<= bOn;, for example. But that does not trigger
        InvalidateHash() of the SdrCustomShapeGeometryItem. So the item has
        still aHashState 'Valid'. On the other hand because of the change the
        hash itself has changed. Therefore the == comparison between the
        original item and its clone returns 'false' in customshapeitem.cxx#238.
        And as a result, the assert in itempool.cxx#679 fails.
        
        My solution replaces the direct writing with setting the value via
        SetPropertyValue(), which includes the needed InvalidateHash(). The
        method InvalidateHash() is private and so cannot be directly used in
        fontwork.cxx and extrusionbar.cxx.
        
        Change-Id: Ib6021defb61478de9cbefa8f26466a2fe21352a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130117
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [3fb587e89421a862a1e65f47cad17839e2b832e4]

        Revert "Fix failure of loplugin:useuniqueptr with older compilers"
        
        ...0bf61855164af5751e78ca8626c10d604b1ab13b, which should be obsolete now:  It
        speculated why 05a337e297eb0cfe88c99503d760bd9eaf495b7d "loplugin:useuniqueptr
        look for deleting in loops with iterators" had introduced Foo24 in
        compilerplugins/clang/test/useuniqueptr.cxx wrapped in
        
          #if CLANG_VERSION >= 50000
        
        and came to the conclusion that "either the old compiler lacked Clang's recent
        <https://reviews.llvm.org/D50666> "Fix Stmt::ignoreImplicit" (and the above
        initialization expression happens to include a CXXBindTemporaryExpr, at least
        with libstdc++), or an even older compiler was used in pre-C++17 mode".  But
        both of those potential reasons should be moot now, as the Clang fix got
        introduced towards Clang 8, and LO requires C++17 now (except for 3rd-party
        code).
        
        Change-Id: I307afbbecc5f031bca2319c4b22d54bd467eac81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130116
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [3c535b25110cb2b9cde41dd469d9ece2b52b1444]

        Don't exclude vcl/source/app/salplug.cxx from loplugin:externandnotdefined
        
        Whatever exactly the original reason to do so, it appears to no longer be
        relevant.  (Maybe that salplug.cxx got reworked in the meantime?)
        
        Change-Id: I5187635dcb095ca505b38992b19770fe232f5124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130115
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [9eb9083ff2fdaeb96399a0830a4394de4e29ef64]

        Use Dragonbox to implement doubleTo*String*
        
        This header-only library is accurate in decimal representation of
        doubles; provides API that allows to create custom representation
        - so it's possible to use custom decimal separators and grouping.
        
        This allows to unify all corner cases: integers, numbers close to
        DBL_MAX, up-rounding to the next decade.
        
        Note that Dragonbox creates the shortest decimal representation
        of the number, that is unambiguously convertible back to the same
        number; thus it may hide trailing digits that are unneeded for
        such conversion.
        
        The functional changes are minimal, and beneficial:
        1. Rounding numbers close to DBL_MAX now takes into account the
        bEraseTrailingDecZeros argument, as it should, allowing to have
        "1.8E+308" for rounding DBL_MAX to 2 decimals without trailing
        zeroes, instead of previous "1.80E+308".
        2. Incorrect rounding is fixed in some cases, e.g. 9.9999999999999929
        rounded to 10 previously using rtl_math_DecimalPlaces_Max.
        3. Representing the number in the shortest way may change display
        of some printed numbers. E.g., 5th greatest double is represented
        as "1.797693134862315E+308" instead of a bit longer, but giving
        the same double on roundtrip, "1.7976931348623149E+308". This would
        generally look better for some numbers similar to the famous 0.1,
        where users would likely expect more "round" representation where
        it's unambiguous (but we still truncate to 15 significant decimals
        anyway - so there's no point in pretending to provide exact digits
        for actual binary representation).
        
        These are reflected in the unit tests affected by the change.
        
        Change-Id: I05e20274a30eec499593ee3e9ec070e1269232a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129948
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [ee373f34ae1509e8d9fffaf4b5140ee9c35e8d41]

        Extend loplugin:stringview to O[U]StringBuffer::makeStringAndClear
        
        ...at least when called on an rvalue.  (The lvalue case would often be trickier
        to act upon, if the cleared object is still used later on.)
        
        Change-Id: I006e618da004b2127e9ed7381911c2d7b00b1169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130110
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [d1a2b80b9dc146c7fe63d2657e5506f49d6e5c0d]

        Bump compiler plugins Clang baseline to 12.0.1
        
        ...as discussed in the mail thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html>
        "Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at
        <https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html>
        "Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up
        compilerplugins/clang/ accordingly
        
        Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Caolán McNamara  <caolanm@redhat.com>  [eed401bc7429f29f1b21cf8e3b08969e011d5692]

        reenable this layout test again
        
        Change-Id: Icaedc8b25301be54fc2c99e829fca5907fcd86d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130075
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [01645b021c3609f86b8ebca100f54006f467573f]

        Deduplicate some code
        
        Change-Id: Ib05624739cce31b08fc409f238d447ed8d99bad9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130016
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-17  Renwa Hiwa  <renwax23@gmail.com>  [7d92ec5ae18fdec8a3182b1138a62b65e2d14c10]

        Better handling of terminals
        
        LIBREOFFICE-3MQTR80G
        
        Change-Id: Ifa52d7f65aae473056202b46788c5870a8ce38c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130085
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-17  Eike Rathke  <erack@redhat.com>  [be13ca182d7b0b59ad0c9509200cfdc45bd15cf2]

        Resolves: tdf#147496 No line feed for one single cell in clipboard Doc2Text()
        
        Change-Id: If6326bf414e1da43d846f952d88ceae37b2b9cd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130109
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-17  Miklos Vajna  <vmiklos@collabora.com>  [24231f2a336c50eac5e6a1621c57e60ebe1e1cf4]

        svtools: fix lost replacement non-rendered graphic when updating it fails
        
        This is similar to commit 8780fa41dcd164af244742461f4e57a4bcf4c7a4
        (svtools: fix lost replacement grpahic when updating it via OLE fails,
        2018-10-30), but that case was when we already had an old
        mpImpl->pGraphic, the updated failed and then we already lost the old
        one but didn't have a new one.
        
        Here what happened is that in case tools -> update -> update-all was
        used for an OLE object which had bad native data but a good preview,
        then the result was bad preview, depending on if you first scrolled to
        the OLE object to trigger rendering (good) or not (bad).
        
        The reason for this is that scrolling to the object calls GetGraphic(),
        which sets mpImpl->pGraphic using GetReplacement(bUpdate=false), which
        works, but svt::EmbeddedObjectRef::UpdateReplacement() calls
        GetReplacement(bUpdate=true). That explains why the update breaks the
        preview, but not when scrolling to it first.
        
        Fix the problem by improving svt::EmbeddedObjectRef::GetReplacement():
        if getting an updated graphic fails, try to get a non-updated graphic.
        
        The result is that GetGraphic() after an UpdateReplacement() not only
        always return a non-nullptr Graphic, but also it's no longer of type
        None.
        
        Change-Id: I8e5ff4aaaefdc58e032b325bb4001f2a604ccc8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130086
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-17  psidiumcode  <lbrmk.510@rgn4d.neomailbox.ch>  [b69dc9faac1bc5409f43160228703108a002ed11]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I5a946c9db1b3ca91fa9d59d0d742c9b30782ed00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129978
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-17  Julien Nabet  <serval2412@yahoo.fr>  [de4d89160e48dda88d1a0e05cee28bb1551355b4]

        Revert "ODBC: fix signatures of Bulk, SpecialColumns et NativeSQL"
        
        This reverts partly commit 8942956e05f2208ffb666a2118f5db092c30ce6a.
        
        Reason, Lionel indicates:
        In general UnixODBC has to deal with more portability to more platforms,
        so I would tend to more follow their signatures than the ones of Microsoft, that has to deal with only Windows OS on less CPU ABIs.
        
        Change-Id: I8b8924d35aa86ac23a8191baa8584463941eddc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130084
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [fe6043136fd3ba0333b99b8ca4dda699961c2bfd]

        Bump Linux Clang baseline to 8.0.1
        
        ...as discussed in the mail sub-thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2022-February/088476.html>
        "Also bump Linux Clang baseline to 12.0.1 (was: Bump --enable-compiler-plugins
        Clang baseline?)", and clean up newly-obsolete __clang_major__ checks
        
        Change-Id: Idacb9148b019c07e138277df3a085ba71c64a8e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130028
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Caolán McNamara  <caolanm@redhat.com>  [fe8ec10eeee51f806392e14440655c8d664bc234]

        cid#1498146 silence Dereference after null check
        
        Change-Id: I55da3d7a2f1ccfa0c7120b6cff9ae95936f10e92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-17  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [b7308bda7212da5681b7047c02e2e13e36b2a98a]

        tdf#147196: Fix crash in editeng when applying title case format
        
        Fixes a possiblity of crashing when applying title case format using the
        edit engine.
        
        Change-Id: I4f44f635a1c96b021c084bb5bb973180744e56e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129888
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [957d99a539df6e21fd40370938ca5dab1613cf8c]

        fix range checking in calls like ScDocument::GetNote()
        
        Change-Id: I5612e765b3484b0515f4a16030ee19133ae3126a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130076
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [7bb0b11873d0c96d8116b327987834db048754c3]

        fix range checking when parsing Calc cell address (tdf#147451)
        
        The document contains 'Sheet1', which Calc first tried to parse
        as a normal address, since it matches the format of e.g. 'XFD1'.
        The code parsed column into SCCOL (sal_Int16), which with 16k
        column limit overflowed and the code failed to detect the problem.
        
        Change-Id: I470db1b670dbff7bdc8013bede0a0b011e88c372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130073
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Caolán McNamara  <caolanm@redhat.com>  [0de9a87e36f928a360245feb86e30e48d94c5e8b]

        Refetch in case SwTextNode::InsertItem causes it to be deleted
        
        Change-Id: Ie189ae4d37ffc33e58bb405f2521d1ae02a9997b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-17  Jean-Pierre Ledure  <jp@ledure.be>  [60f786bde4524bbba462eccc6578715f39020076]

        ScriptForge - (L10N): add new arguments to the service creation
        
        Actual arguments:
          - FolderName: the folder containing the PO-files
          - Locale: in the form la-CO (language-COUNTRY)
          - Encoding: The character set that should be used
        
        New arguments introduced by this commit:
          - Locale2: fallback Locale to select if Locale po file does not exist
          - Encoding2: Encoding of the 2nd Locale file
        
        Both new arguments are optional => no regression on existing scripts
        
        The arguments are available in Basic and Python equally.
        They may be passed as keyworg arguments in Python only.
        
        The default locale is now set to the "OfficeLocale",
        which is the locale in the user interface.
        NB: the distinction between SystemLocale and OfficeLocale
        is new in version 7.4.
        
        Change-Id: Ie3bc5d30193df35a8c6c1ec706e13eaea0050981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130074
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [d697c96178d13725470192d63bd4fa1c202d0d2e]

        make DBG_UNHANDLED_EXCEPTION no-op if SAL_LOG_WARN is not enabled
        
        ee0e19296b959b4545b094f49a8b0c0b5463 make the macro unconditional,
        but that means it calls both DbgUnhandledException() and
        DbgGetCaughtException(), and then log it as SAL_WARN that's
        a no-op. With the document from tdf#105036 it added ~13% CPU time.
        
        Change-Id: I9360169e6e3976d40271bc5602765e56f58971d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130069
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Mike Kaganski  <mike.kaganski@collabora.com>  [41ca0b7262ca52646e935e41a187c5742c3993bb]

        Revert "Resolves: tdf#147421 Do not use OUString::replaceAll() to strip null-bytes"
        
        This reverts commit 4b0c17609c2cca326bbcc9e8488a327a4a9ea952.
        
        Reason for revert: it's possible now to revert to previous simpler code
        after commit 4e4a01302a140d75a49055821b3197a2eda81db5
        
          Related: tdf#147421: optimize O(U)String's replaceAll*
        
        Change-Id: Iaefac917afbc9c587e75c38457dd9ea87e4f5861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130017
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cbf83e20889351e2d2a6e29e5c7d9250af58647]

        loplugin:unusedmethods
        
        Change-Id: I58c60262ca543bafb4db4433dbb98b195f7571ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [51648c8de8dc060abc8dff1af105acfccadab77d]

        tdf#147398: sc_ucalc_formula: Add unittest
        
        Change-Id: I28c8a4614edf577e1f8f101ba55327fd9f358973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130068
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4758f3d3d083b6b59fa0c0f37dae473770f3c45]

        micro-optimisation: use std::move
        
        Change-Id: I3acee160130185e65a154bf205fcdcf52b9f8797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-17  Regina Henschel  <rb.henschel@t-online.de>  [157b027c4cfca2582b1c1bdb66992560084ac008]

        tdf#145700 Improve lighting in extruded custom shapes
        
        The fix tries to make rendering similar to MS Office.
        
        The ODF standard follows closely the extrusion in RTF and MS binary
        format. Rendering uses the 3D scene engine.
        
        The main problem was, that the z-component of the direction was
        interpreted with opposite sign. As result the maximum of a light was at
        false position. Especially a direction from the observer to the object
        has produced a light behind the shape and so looks as if light was off.
        
        The wrong z-direction has produced lighting, which was less intensive
        than in MS Office. To compensate that, a third light source was added
        as workaround. That part is removed.
        
        Second problem was wrong use of 3D-scene D3DMaterialSpecularIntensity
        and D3DMaterialSpecular (= UI Specular color). That was not only wrong
        in OOo but in my previous patch too.
        D3DMaterialSpecularIntensity corresponds to MS property 'c3DShininess'.
        Relationship is Intensity = 2^c3DShininess.
        D3DMaterialSpecular is calculated from MS property c3DSpecularAmt and
        and c3DKeyIntensity. The light source was missing, but needs to be
        included, because c3DSpecularAmt is 'the ratio of incident to specular
        light that is reflected on a shape'.
        The old unit tests are adapted to this change.
        
        MS gives no information how it softens a light in case of harsh=false.
        ODF specifies it as 'implementation-defined'. The patch uses four
        additional lights, which have directions in 60° angle to the original
        light. The light intensity is distributed. That comes near to rendering
        in MS Office. Changing our 3D engine to provide 'soft' lights was not
        doable for me.
        
        The way MS Office renders a 'metal' surface is different from ODF
        specification. To distinguish the kinds, I have introduced a new
        property MetalType. I have discussed it with the ODF TC (see minutes
        from 2022-02-07) and got the advise to use namespaced values.
        Therefore the datatype is not boolean.
        
        The 'Surface' drop-down in the extrusion bar is changed to make the two
        kinds of rendering 'Metal' available to the user.
        
        If a user sets surface 'Metal' in the UI of MS Office, it sets not only
        fc3DMetallic but reduces the value of c3DDiffuseAmt in addition. Our
        3D-scene engine has the corresponding ODF attribute dr3d:diffuse-color
        not implemented. To get a similar rendering I change the material color
        of the 3D-objects as workaround.
        
        Change-Id: Ia986b9c318b4c79688e0c0e2d858215b9d612fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128449
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-02-17  Michael Stahl  <michael.stahl@allotropia.de>  [424cd919c4234d6e6fd4da89acd90197771f7b9d]

        sw: one modeline should be enough for EMACS
        
        Change-Id: I888c35d7c5e5063b34b75f1564e67917d9d4583f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130064
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-17  Michael Stahl  <michael.stahl@allotropia.de>  [d195237d937ad37c18875a38f9cfff058133ddbd]

        libxslt: upgrade to release 1.1.35
        
        Fixes CVE-2021-30560
        
        Change-Id: I334662ddc40955780321133be9aee23858e04dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [99b13eed2145bfac41a57cdc96691e5e53403538]

        loplugin:unusedfields
        
        Change-Id: I07ec409ea3663e789b6505dbfc999666525ed97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e5036bb5790e1ee753d890e8b270eaceee74ce7]

        loplugin:unnecessaryvirtual
        
        Change-Id: I44c70bd930380d0e3f76524f37e6276cf4faeccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [59ac648a1482d9422b8f279bcb284a214032f5cf]

        Parameter should apparently be of type sal_Int32
        
        It was like this ever since 969aac0edf437ec0cad0baadfde46188c4822161
        "INTEGRATION: CWS pdf25", but the single caller of encodeBase64 passes a
        sal_Int32 value, and all use of i_nBufferLength in encodeBase64 are in
        sal_Int32-based computations.
        
        Change-Id: I2963a05bf5a83aaee25cdd71c11d28481b28061a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130067
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Stephan Bergmann  <sbergman@redhat.com>  [cf07bcddd79beb6a0920384690a162c847801d7c]

        Drop -Wdeclaration-after-statement
        
        It was introduced, without a rationale, into unxgcc.mk in
        eb09adaa9a2accbdc3531bb96447c8e7fbb9f8a9 "Warn if declaration follows
        statement in C-files", then carried over to clang-cl (com_MSC_defs.mk) with
        9055fb48402eaeb9ba876b7893e2f9a39fea06b1 "clang-cl: Enable more warnings etc.
        (like in the Clang/GCC case)", where it now started to cause
        
        > cppuhelper/source/findsofficepath.c(102,20): error: mixing declarations and code is incompatible with standards before C99 [-Werror,-Wdeclaration-after-statement]
        >     const wchar_t* SUBKEYNAME = L"Software\\LibreOffice\\UNO\\InstallPath";
        >                    ^
        
        after
        <https://github.com/llvm/llvm-project/commit/118f966b46cfb60897b56a9878e1c68fd0e2afa4>
        "[clang][#51931] Enable -Wdeclaration-after-statement for all C versions".
        
        Lets remove it from all toolchain settings, there appears to be not much value
        anymore in such a warning about pre-C99 code.
        
        Change-Id: Id4669089e46c97aaa926e5bd202c36eb5984b837
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130058
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [05259e880db187f6698d6d545504775459d6e96a]

        optimize blank cell Excel export (tdf#133749)
        
        The code in XclExpRow::Finalize() apparently creates an array
        of indexes for blank cells, and then uses it
        to efficiently write many blank cells (or whatever it's all exactly).
        But especially with huge sheets all this processing is basically
        repeatedly checking for all the blank cells at the end of the rows.
        
        Optimize this by calculating where the all the remaining blank cells
        start and process those more efficiently or sometimes even just
        plain ignore them. Possibly this could be optimized even more if
        I understood the code better, but this seems to be good enough.
        
        I've also changed some of the loops to use indexing instead of
        iterators, as libstdc++ debug iterators are horribly slow here
        (which possibly may even make a difference for Jenkins builds).
        
        Change-Id: Iafe36ccd2795a85b10b98cf84c041a7427aabc29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130046
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [855a0f40b285a438f8bd2ea61ebb8717daa16292]

        std::map -> std::unordered_map
        
        Change-Id: I70a039af151b7dd398d2665e6fc9bb825f719e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130006
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Eike Rathke  <erack@redhat.com>  [f6b9c471cace1963e8b625ecfe2c20f5248984eb]

        Handle the possible case of broadcasted row block, tdf#119083 follow-up
        
        Though unlikely and apparently not happening, the changed ScHint
        may theoretically notify for a block of rows, not just one
        address. Do not join out-of-band rows to the dirty header columns.
        
        Change-Id: I524bcbedf063fe6b5ff5b99bc984fcb9dc02b6ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130054
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-17  Jean-Pierre Ledure  <jp@ledure.be>  [d94a4767437cdb12ee92265814b8b56f13448a09]

        ScriptForge - (SF_UI) Fix omission of ServiceName
        
        The ServiceName property is part of the standard
        norm for ScriptForge services.
        
        It is used only internally.
        
        Its omission in SF_UI caused the tree in construction
        for help files to contain wrong redirections.
        
        Change-Id: I51f1966ef463fffe62c9495dbc2ea0c152fa9667
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130004
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-17  Tünde Tóth  <toth.tunde@nisz.hu>  [8f7d355e7f153a940b85179f5bc54a506eeab05a]

        tdf#147086 OOXML export: don't save the empty editing password
        
        Saving with opening password, but without editing password
        resulted read-only documents (only on their original path: saving,
        i.e. copying the file in a different path was a workaround for
        the lost permission).
        
        Regression from commit 1b53c1dfc76f08ca7df40a0673aa50eca700d072
        (tdf#144374 DOCX: export the password for editing).
        
        Change-Id: I2759dc876ee7668d00eee0aa81490c9d1e0c272b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129593
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [af0a0777584825035dbf5ba0ec48d7a6412010c2]

        fix maxrow/maxcol mixup
        
        In 5e402bac39dc4245844efbde442bdb3bd993a157 I accidentally converted
        a couple of MAXCOLCOUNT to GetMaxRowCount().
        
        Change-Id: I2f22e614fb79b8e651308bd4dbddcd7e04651903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130057
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-17  Miklos Vajna  <vmiklos@collabora.com>  [4e9a52c7f5ed12e4bb2a716d992edff7aa6c2a7d]

        svtools: extract EmbeddedObjectRef::dumpAsXml() from SwOLEObj
        
        Because sw/ doesn't have access to the internals, but dumping should
        show the state as-is, without calling getters that change the state.
        
        Especially GetGraphic() is not a trivial wrapper around
        mpImpl->pGraphic.
        
        Change-Id: I2cf43130d4eeab63611e37b4a978bb7aa546c7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130056
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-17  Julien Nabet  <serval2412@yahoo.fr>  [8942956e05f2208ffb666a2118f5db092c30ce6a]

        ODBC: fix signatures of Bulk, SpecialColumns et NativeSQL
        
        I compared with https://docs.microsoft.com/en-us/sql/odbc/reference/syntax/odbc-api-reference?view=sql-server-ver15
        
        Change-Id: Iac38c2305fbf3ace502f9e75802510f76a6bd700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130055
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-17  Jim Raykowski  <raykowj@gmail.com>  [11c37becdb2652d242b8cb6300005fff0d9a7cab]

        SwNavigator: reduce the amount of content tracking code
        
        Same behavior, less code.
        
        Change-Id: I2b93a0a31f754538be2663df90825fc14f4eb210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129981
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-17  Miklos Vajna  <vmiklos@collabora.com>  [8cc70d18c4507a746607fe5922b7c5e94b7f7579]

        sd theme: add doc model for shape fill color
        
        In preparation of adding UNO API for this.
        
        Change-Id: Iecb2e44c43bca9e892fcb6242870ec12faa48be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130050
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [b447be3ccba686c4e35d61b05b50d31045c9d1ac]

        tdf#132057: sc_uicalc: Add unittest
        
        Change-Id: I56c385e0458e2096e0c1e4fd0c85d47c40fe207b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129987
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e4a1615a77f7d4753ae5f657acff30bf6b248fc]

        tdf#147164 Drawings are gone converting to PDF from commandline
        
        regression from
            commit 9a850dd9f3c221660b6259bdfd64a77343f2256c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Jan 12 10:27:38 2022 +0200
        used cache value in ViewObjectContact::getPrimitive2DSequence (2nd
        attempt)
        
        for reasons I do not understand, the cached maObjectRange is wrong at this
        point in the execution, so switch back to fetching it again, like the code
        did before the above commit,
        
        Change-Id: I4a9f0abc38e59ef687b460689a30ee4badf620a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129994
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-17  Luboš Luňák  <l.lunak@collabora.com>  [6267a995ea5a621f5f147e5866b6af9cdd205b9c]

        remove MAXCOL/MAXROW from ScExternalRefCache
        
        The range is used just for filtering out, and since this is about
        references to other documents, I wasn't sure which document to use
        as the limits, so I did a copy that of the functions that returns
        all.
        
        Change-Id: I9711534004796496558848adef03d38ddb115441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129988
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Henry Castro  <hcastro@collabora.com>  [f3b2dd0fc4c413c9a8382aecbd8b7f842bfa8c28]

        lok: sc: handle all local mouse tracking for Calc
        
        Change-Id: I11f3477c0f966d403e076fc73b7e5507ad6597f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118877
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117779
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-16  Stephan Bergmann  <sbergman@redhat.com>  [c6db02a2afe4263e060fe6166db8e5426dd2ecd1]

        Extend loplugin:stringview to OUStringBuffer::copy
        
        (Somewhat oddly, there is no OStringBuffer::copy counterpart.)
        
        This required some modification to StringView::VisitCXXConstructExpr to avoid
        
        > In file included from odk/qa/checkapi/checkapi.cxx:29:
        > In file included from workdir/CustomTarget/odk/allheaders/allheaders.hxx:351:
        > In file included from instdir/sdk/include/rtl/math.hxx:31:
        > instdir/sdk/include/rtl/ustrbuf.hxx:1687:16: error: rather than copy, pass with a view using subView() [loplugin:stringview]
        >         return copy( beginIndex, getLength() - beginIndex );
        >                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        while building CppunitTest_odk_checkapi as external C++03 code, where the
        returned value is wrapped in a CXXConstructExpr.  And testing for that case
        required a new CompilerTest_compilerplugins_clang-c++03 that uses gb_CXX03FLAGS
        and needs to not set LIBO_INTERNAL_ONLY (via gb_CompilerTest_set_external_code),
        as compiling as C++03 would otherwise generate lots of errors like unknown
        char16_t at include/sal/types.h:118.  (There was a choice whether to name the
        new test "-c++03" or "-external", but the issue it tests is caused more by the
        code being compiled with C++03 than by this being external code, see above.)
        
        Change-Id: I873a9c5a70d3ea949cf13a169d46920b71282712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130036
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-16  Tor Lillqvist  <tml@collabora.com>  [2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b]

        Add sanity check to avoid potential crash in the Collabora Online server
        
        Make sure some coordinates don't become huge negative numbers. This
        doesn't fix the unknown root cause of course.
        
        There already was such a sanity check here in this branch, but for
        Android only. I now made it cross-platform.
        
        Let's use the same Change-Id as in the corresponding commit in the
        co-2021 branch.
        
        Change-Id: I28e343271b3f80ac203b52db1be58d2add89eecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128932
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130051
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [823eb92025853d120c17790d1c8efde59f033c69]

        do not allocate columns in ScTable::GetPattern()
        
        Otherwise e.g. going to the last column allocates all columns.
        
        Change-Id: I9cbdb18545bb200379616484c46c85ca31833563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129995
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [a717029e217621482ef799731f945090c6d6be4b]

        for unallocated columns check default column attributes (tdf#132057)
        
        The problem was that this was returning false for the protected
        attribute just because a column was not allocated, but the default
        attributes had the flag set (so if the column had been allocated
        first it would have the flag set too).
        
        Change-Id: I2ef1ef40cafb7e8fc6f7b561c0a376af63f2ad26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129984
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [980b91d5c850099766bf32dfe28880df8873c046]

        move simple checks out of DEBUG_COLUMN_STORAGE
        
        These few look like useful assertions and they should be cheap,
        so keep only the extensive checks inside the #if block.
        
        Change-Id: I9e6851d25d8b4d637041c1efe1d9712d410262e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130003
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Stephan Bergmann  <sbergman@redhat.com>  [d5c28daeb498dcdd4d211415d8eae4d82c3ffc82]

        Remove apparently obsolete external/boost/boost-android-unified.patch.1
        
        The two checks for __clang_major__ == 5 etc. had been added with
        23a8d5ffbbe58761b89f590f0735abccd69a3681 "Upgrade external/boost to
        Boost 1.69.0" because "with the non-standard Clang 5.0.300080 from NDK r16b, the
        build now caused failures".  But for our current Android build baseline NDK r19c
        (cf. README.md),
        
        > $ android-ndk-r19c/toolchains/llvm/prebuilt/linux-x86_64/bin/clang --version
        > Android (5058415 based on r339409) clang version 8.0.2 (https://android.googlesource.com/toolchain/clang 40173bab62ec746213857d083c0e8b0abb568790) (https://android.googlesource.com/toolchain/llvm 7a6618d69e7e8111e1d49dc9e7813767c5ca756a) (based on LLVM 8.0.2svn)
        [...]
        
        has __clang_major__ == 8 by now.
        
        Change-Id: I5a5131c14ddf410ed60337992c2d827792c3bbc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130029
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [38e7c18188f1c5310898181db87686774be3c040]

        sw: layout: allow keep-with-next paragraph with fly to move back
        
        The problem is that a paragraph that has the fo:keep-with-next="always"
        and also a fly anchored at-char or at-para with style:flow-with-text="true"
        will never move to the previous page, even with space available.
        
        In SwContentFrame::MakeAll() it will first MoveBwd() and then go into
        the special case "if ( bKeep && bMoveable )" which calls Calc() on the
        next frame.
        
        But this fails to move the next frame because of SwFlowFrame::IsPrevObjMove()
        finding the fly with a mis-matching mpVertPosOrientFrame - that will not
        be fixed until the first SwContentFrame::MakeAll() is done and
        SwObjectFormatter::FormatObjsAtFrame() is called.
        
        But SwContentFrame::MakeAll() first detects that the frame is not on
        the same page as the next one despite bKeep, so it MoveFwd() again.
        
        This happens already in OOo 3.3.
        
        IsJoinLocked() should be a reasonably good heuristic for "is the
        previous frame being formatted".
        
        Change-Id: I86996dcb3d0c46fcb99ec9ad463569abbb8b99f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130033
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-16  László Németh  <nemeth@numbertext.org>  [95213407dfcbf34056037d60243ff915340d1a2e]

        tdf#146622 sw crash fix: don't delete already deleted rows
        
        Delete tables and rows removed also tables and table rows
        with tracked row deletion/insertion. This resulted not only
        lost change tracking, but a crashing Undo.
        
        Crash regression from commit 99059a1ececa3621c2fe46fabdd79eed9d626c42
        "tdf#143359 sw: track deletion of empty table rows".
        
        Non-tracked deletion of the tracked row changes was a
        temporary solution for the missing UI of tracked
        row changes, implemented in commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Note: UI was added in commit f348440e17debacbcba9153e238e010e8c020bdc
        "tdf#146120 sw: show tracked table changes with different color",
        commit 95c003d75e0f8b255344715a35358072b5eba99d
        "tdf#146145 sw: 1-click Accept/Reject of table row changes",
        commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535
        "tdf#146144 sw: add tooltip to table rows with change tracking",
        commit eebe4747d2d13545004937bb0267ccfc8ab9d63f
        "tdf#144270 sw: manage tracked table (row) deletion/insertion",
        commit f481c2c8e74bded11fac754e493560391229dbcd
        "tdf#144057 sw track changes: hide deleted table rows" and
        commit 23846867ea32667ccf328c36142394dd6aaee8ba
        "tdf#147182 sw: accept/reject all changes of a table selection".
        
        Change-Id: I384b750b0d3626fa8b3f256c7eaf5b93f382e4e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129958
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [93495c2a94ab5a827912d73d24736eb9c1cc46cd]

        flat-odf-cleanup.py: fix FutureWarning
        
        The behavior of this method will change in future versions. Use specific 'len(elem)' or 'elem is not None' test instead.
        
        Change-Id: Ic1aedaff3569b9b3063823c747c1d09623b2efad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130032
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-16  Michael Stahl  <michael.stahl@allotropia.de>  [8f24e1a32f55ed179594c9fb50ca33a85608db7b]

        sw: convert an OSL_FAIL to SAL_INFO
        
        Change-Id: I1ff4c56b52716822dd04cb0e07347a19a2122a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130031
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-16  Caolán McNamara  <caolanm@redhat.com>  [dde88196360f489efb1170863f5d06e8405d37fe]

        reenable fuzzing for InsertMatrixFormula
        
        Change-Id: I9a665df74882eb4edac9a1787afe83af5e5e144e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129990
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-16  Tor Lillqvist  <tml@collabora.com>  [a6760a0fc4461ba58c9ddb089c7ceb8c962f5dc5]

        Don't confusingly use the term "gesture" for plain old mouse events
        
        "Gesture" is a term typically used for finger input on touch
        devices. The LibreOfficeKitMouseEventType type is for traditional
        mouse events.
        
        Change-Id: Id14ab725567546e33f3dd1277fb4380b9f81d59b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129985
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [069c0b32e2ca85340bc79a222bae57bef7d1f674]

        clamp ColumnSpanSet::executeAction() to allocated columns
        
        It's already done by executeColumnAction() and currently existing
        actions do not need unallocated columns. This prevents allocating
        all columns e.g. when selecting a full row just because
        ScDocument::GetRangeScriptType() gets called.
        
        Change-Id: I517ce14a756be83a385968549b32d430274b8002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129993
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [91c54829e84a372e9ea7460474a84abbef3d1171]

        do not allocate columns in ScTable::GetNumberFormat()
        
        Change-Id: I9347f1d638473f9bcca9b96640a71ae1ef09e415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129997
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Eike Rathke  <erack@redhat.com>  [a1f21d7094deb6f1ae5388718f2bc28eecd5737a]

        Resolves: tdf#147398 Test Intersects() instead of Contains(), tdf#119083
        
        Regression from
        
            commit 8406139062d9ffe1daed32aefe4e261c6c55d63e
            CommitDate: Mon Dec 6 15:45:35 2021 +0100
        
                process broadcasts for adjacent cells together (tdf#119083)
        
        that changed single cell broadcasts to blocks of rows broadcasts and
        
        -        if (rAreaRange.Contains( rAddress))
        +        if (rAreaRange.Contains( rRange))
        
        but a block of rows may be distributed over several broadcast
        areas so rRange is not contained within one rAreaRange and thus
        was not broadcasted. Testing for intersection instead fixes this.
        
        Change-Id: I10700296ebc897e4b7b7752e0e6bcb480085b487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130027
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [72c5c23defee2d542b0e4a57018fc86638d15137]

        tdf#127113: sc: Add UItest
        
        Change-Id: I3e40d775d95083d96776f3bcd36f92c11110a8a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129986
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4e4a01302a140d75a49055821b3197a2eda81db5]

        Related: tdf#147421: optimize O(U)String's replaceAll*
        
        ... and underlying low-level C functions.
        
        Change-Id: I78c2dd75e272e6d3cdd2cfae007ca0a0ec1635e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129942
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-16  Mike Kaganski  <mike.kaganski@collabora.com>  [acdf524e12d302b4bf9367a8b25408746737e123]

        De-duplicate some code
        
        Change-Id: I355fd800e09cef0776408375bd4d6053048d7eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129943
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [9625db65446711044e364443b5afbdbb09283055]

        simplify some vector construction
        
        Change-Id: I0bd131066f5d70fb1dc1c4f851d4d6059994a6f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [8fc4e188586cf3c04592e0c1027a0c384bd3c54d]

        non-const ScTable::GetFormulaCell() doesn't need to allocate columns
        
        A newly allocated column would contain no formula anyway.
        
        Change-Id: I7a9f65e5048c9fb6793caafdd4c60892659a1a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129998
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Noel Grandin  <noelgrandin@gmail.com>  [f04ae7a8b7be6205f6cbc645cb15e7a48f1df960]

        speed up DefaultProperties::SetObjectItem when loading large chart
        
        The cost of creating a SfxItemSet to pass around changed item
        information is surprisingly high, so avoid that and just pass
        the vector of changed items down (which we are already building
        anyway).
        
        Change-Id: Ifa48e3ce07fb6c92ad05a119ae95ce002af76199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-16  Seth Chaiklin  <sdc.blanco@youmail.dk>  [741ae431ed680ae66e9b242626eef0d8f274486a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0fa83de4173e9dfaaca3b3c288ec4843d15b9252
          - tdf#146733 (Related to: tdf#146937) remove "refresh" from help
            
                - refresh command was removed (tdf#146937), so remove from help
                + add clarification about templates in relation to categories
                + add "New Category" option
                + add explanations about conditional items in Manage dropdown menu
            
            Change-Id: I1cb7757b0a8b0546989c8a6bfe3e8a4ef1b196a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129619
            Tested-by: Jenkins
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-16  Michael Weghorn  <m.weghorn@posteo.de>  [5fd5e42bf28a7910321c6b6d76257e7386839fbc]

        configure.ac: Update kf5 include/lib check to work with KF5 >= 5.91
        
        The 'kcoreaddons_version.h' header was moved to the 'KCoreAddons'
        subdirectory in kcoreaddons commit
        
            commit d971ba9bb27a3e8f18a116692fdf98c1729ac244
            Author: Ahmad Samir <a.samirh78@gmail.com>
            Date:   Sat Jan 15 14:14:13 2022 +0200
        
                Install kcoreaddons_version.h in /usr/include/KF5/KCoreAddons/
        
                Instead of /usr/include/KF5/kcoreaddons_version.h.
        
                For more details see:
                https://invent.kde.org/frameworks/kservice/-/merge_requests/79
        
                GIT_SILENT
        
        Adapt the KF5 check to check for the 'KFileWidget' header and
        the 'libKF5KIOFileWidgets.so' library instead.
        This is more exact anyway, since we require KIOFileWidgets,
        and the previous check didn't ensure that.
        (So in case only KF5CoreAddons but not KIOFileWidgets was installed,
        configure would previously pass, but the build fail.)
        
        [1] https://invent.kde.org/frameworks/kcoreaddons/-/commit/d971ba9bb27a3e8f18a116692fdf98c1729ac244
        
        Change-Id: I7ecf7f29dce85e1a6e6b0d4f2519fa37ab04ca84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129996
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f574430f936c2a132f83661ca9e69680ddda42d3]

        Fix typos
        
        Change-Id: I3e1e3d214b465f071e57b2e9d349c38aa15657af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126639
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-16  Heiko Tietze  <tietze.heiko@gmail.com>  [75ac604292e92dc08bb8ba5b9cc30799d643090a]

        Related tdf#143578 - Rename SAL_NO_QUERYSAVE to NO_QUERYSAVE
        
        Change-Id: Iccec99ba55a1a99a71c685489890e0695a6d6d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129992
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-16  Henry Castro  <hcastro@collabora.com>  [fc2cdf4a61600a655629ea37099630da34a98cb1]

        lok: sc: apply local mouse tracking only for Calc
        
        Change-Id: I6c3d4c3c59652f20596e32d3f31c5357b7ed61eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118873
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117778
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-16  Heiko Tietze  <tietze.heiko@gmail.com>  [e7af16b2a6d097448a292cf19f04edcda82adf3a]

        Resolves tdf#143578 - Environment variable SAL_NO_QUERYSAVE to not show the dialog on changes
        
        Candy for the QA team
        
        Change-Id: I00094872e0c2e6113a7136fa5fd7fd5cb91ba3ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129967
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-16  Miklos Vajna  <vmiklos@collabora.com>  [e620fc11709787a7075b281a26c5da3acfc27eb8]

        CppunitTest_sw_ooxmlexport2: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I68841addb024a45bc3a98e5fdb2994f0eacfadc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129977
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [d0a42ce9b1033a200f8d354c1abf8c3b0d569f46]

        avoid debug build failing on an assert for tdf#144537
        
        It really should be an assert, and something is clearly wrong,
        as the chart shows one row twice after the operation, but I have
        no idea how to fix this, and it's not that critical, so reduce
        to just a warning until somebody fixes the problem.
        
        Change-Id: Idf0a3496a6f0472301ecb3c0e53ead43312c2f84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129980
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Luboš Luňák  <l.lunak@collabora.com>  [309f0f882b34c13d970677c2564f088c36c9691b]

        simplify code
        
        Change-Id: I5e5c419f2888d0f305f6b83445c66c187f3e0e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129979
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-16  Kohei Yoshida  <kohei@libreoffice.org>  [30ba505ba549be4a509dd59c4c88a210ee01b539]

        Update mdds to 2.0.2.
        
        See (https://gitlab.com/mdds/mdds/-/releases/2.0.2) for the detail
        of this release.
        
        Change-Id: Ib72a3eee4e1754bd7c0ca25ca25b62abac6d16e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129982
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [310c14b75cd4a755b905dea4373c9c979370f493]

        Removed executable bits on pptx file
        
        Change-Id: Ib14e5357830b587921b633fb57fa74b1314aa1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129975
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-15  Marco Cecchetti  <marco.cecchetti@collabora.com>  [76a98fa478ac8e75cf3f982e4f65548d69371b39]

        svg filter: google chrome doesn't render white spaces correctly
        
        In Google Chrome white spaces at the beginning of a text line are not
        rendered at all.
        
        Change-Id: Idd3b1bc5a383b21a54cc1629173bbe26a6da83bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129918
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        (cherry picked from commit 5eec28d86a5953de3aa0d5f0c424e92334860270)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129939
        Tested-by: Jenkins
        Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [6283ac89d76d68b7c09e018be78ec6b31018da9c]

        make ScBigAddress use 64bit
        
        It may points outside of the document, so with huge sheets 32bit
        may not be enough.
        
        Change-Id: I7aee1d8e90d6c59b91ec07584aa9f36d9352b55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129972
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [28cbc0dcb955954b4d9b85376f356999af429f06]

        move nInt32Min/nInt32Max to ScBigRange and rename to nRangeMin/Max
        
        Change-Id: I4537d6ebcd8293bc7a62651345a517ebfe901638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129965
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [4343976f0d38d727786b15a353ad3d49e76a65b8]

        remove harcoded MAXCOL/MAXROW from ScBigAddress
        
        Change-Id: I670bb5d6e7a1eb20d2bfd48b853d1d2ebf87fe70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129964
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Kunal Pawar  <hellokunalpawar@gmail.com>  [49746f40b06eaf1f61bb54454408a06a49d73c5e]

        tdf#145759 Use symbolic constants instead of magic numerical constants
        
        1.4142... -> M_SQRT2
        0.4142... -> M_SQRT2 - 1
        3.1415... -> M_PI
        2.7182... -> M_E
        
        Change-Id: If5b19aa38d9902b1a4b717f89f18bdf2f73a47cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129745
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [2bf59e3b60a0d5c6ebcd4498f5038d6d2e86db62]

        tdf#146848: sw_uiwriter3: Add unittest
        
        Change-Id: I6460a99ce31cbbcba0498a6caaaac3b304a5134e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129966
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-15  Eike Rathke  <erack@redhat.com>  [4b0c17609c2cca326bbcc9e8488a327a4a9ea952]

        Resolves: tdf#147421 Do not use OUString::replaceAll() to strip null-bytes
        
        It reallocates and concatenates for each replacement so for
        massive amounts takes ages.
        
        Change-Id: Ibe1673fd4775c5b95833000669c1a24e718fd77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129971
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-15  Miklos Vajna  <vmiklos@collabora.com>  [505f5db522f8406715f455d8007d014073a99097]

        sw HTML export: add a new LeadingTabWidth option
        
        This is a simple way to not loose indentation done with tabs (e.g.
        source code) during the HTML export.
        
        A more complex way would be ask the layout for the tab portion width,
        ask VCL what's the size of an nbsp glyph and then act accordingly, which
        is is not done here.
        
        Change-Id: I2a5c0512e9e5541e55e10f29952679bf05d63f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129974
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d18f03a503e173f158780eb3eafd849804948f17]

        Fix typo
        
        Change-Id: If0c567307fe169eda90bd3db81eb538b0c1d03e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129795
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [2361b6215bb4d8002cc7bfb157e125ebea26b7a2]

        Fix a CLANG_VERSION check
        
        These functions became available with
        <https://github.com/llvm/llvm-project/commit/a32a2e34431480759d4983949cbcc25456c6199b>
        "[clang] Move two utility functions into SourceManager" towards Clang 8 and
        <https://github.com/llvm/llvm-project/commit/5ef88bdb68234b21b2ecda683dfe2f76513502d9>
        "Fix isInSystemMacro to handle pasted macros" towards Clang 9
        
        Change-Id: I95b20bc88ff416b49502bdea23e223e6fa966eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129970
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Jean-Pierre Ledure  <jp@ledure.be>  [74a638011da4c2e8475d6f9d4d3a0ffbc4e10807]

        ScriptForge - (scriptforge.py) get lists of properties and methods
        
        To allow object introspection and some help
        files automatic generation (see Telegram discussions),
        the possibility to make the list of properties
        and methods used in Basic  available in Python
        has been requested.
        
        These changes are for internal use only.
        
        Main changes:
        - the SFServices parent class receives new basicproperties()
          and basicmethods() methods
        - Basic PythonDispatcher() is adapted to provide the lists to
          the Python caller
        - Methods lists are reviewed in SFDocuments to NOT include
          the methods implemented in the parent SF_Document class, to
          avoid redundant entries in the list
        
        Change-Id: I80758e225b039426b46f52dd67efe54c50f9f31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129969
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-15  Stanislav Horacek  <stanislav.horacek@gmail.com>  [b8337fdcc374864047b8fa5cdd213dde7387bc19]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36cdfb37ff3d02127ecf6a02335c52ce7b900505
          - fix script name in SF Menu example
            
            Change-Id: I6f999c1d51bfc030a3844ff8c77e316da8f77da0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129926
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [3cbd3012aa1801ba92d566faf7a827587f479995]

        Properly implement compat::isComparisonOp
        
        ...using clang::CXXOperatorCallExpr::isComparisonOp introduced in
        <https://github.com/llvm/llvm-project/commit/fc3c80c38643aff6c4744433ab485c7550ee77b9>
        "[ASTMatchers] adds isComparisonOperator to BinaryOperator and
        CXXOperatorCallExpr" towards Clang 11
        
        Change-Id: Icc4b2a2fc3f944b8c262ec5fea0bb2295fc051bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129968
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Mike Kaganski  <mike.kaganski@collabora.com>  [18742c27af1c67d41831b5d2297746c299ace3d7]

        Use relative path to the script, to please python3 on Windows
        
        Running 'make vs-ide-integration' fails since some recent change
        (no idea if that was a cygwin upgrade, or some change in core).
        Using 'verbose=t', the last lines are
        
          make[1]: Leaving directory 'C:/lo/src/build'
          cd C:/lo/src/core &&  C:/lo/src/core/bin/gbuild-to-ide --ide vs --make C:/cygwin64/opt/lo/bin/make
          python3: can't open file '/cygdrive/c/lo/src/core/C:/lo/src/core/bin/gbuild-to-ide': [Errno 2] No such file or directory
          make: *** [Makefile:495: vs-ide-integration] Error 2
        
        It looks like python3 gets called by shell with the script path as
        given in the comand line, according to shebang in the script; but
        cygwin's python3 can't parse Windows-style path to the script, and
        treats it as relative path from cygwin's current directory.
        
        Just use true relative path to the script, to avoid the problem. We
        cd to $(SRCDIR) anyway.
        
        Change-Id: Idc25cc74f7a23f0e5733f0d10044986888b43ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129930
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Jenkins

2022-02-15  Eike Rathke  <erack@redhat.com>  [4190d16412210743c11af5d8e88ea5e85457fd07]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5314824424e7efbba66df57cafafa7ae246b5b31
          - There is no EO country, eo-EO is a bad language tag
            
            Change-Id: Ia96d31b61d3eab009609f3d8cd8d78228449ccc4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/129973
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Eike Rathke <erack@redhat.com>
            
2022-02-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3073e475b320cab332d197db773c5a475665687c]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 86f503136b933cc40c65508cc3026949a2251c69
          - pt-BR thesaurus: remove idx file from source.
            
            idx fles are created in build.
            
            Change-Id: I32cef18b22aad876d3caf4f3d00e776c5aa1e195
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/129963
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-15  Attila Szűcs  <szucs.attila3@nisz.hu>  [9a457c24ab2731c99f1a5fa1d28f68788e6977f3]

        tdf#146704 sw: fix regression of endnote layout in sections
        
        Endnotes collected at the end of sections moved to a new page.
        
        Regression from commit 4c31b4ef2083087a822c3ae648fd09acc67d2f88
        "tdf#139336 sw: fix extra pages of multicolumn sections with footnotes".
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I36568e33b04ba8024ceef6b3ea84b71fb375e2a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129896
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-15  Henry Castro  <hcastro@collabora.com>  [068343e9b8a8b07f07ac34f06a20f067b11c1897]

        lok: fix sending mouse pointer
        
        The ScGridWindow is a document window, but the Parent
        is not the notifier, fix it to send mouse pointer when
        action is drag & drop.
        
        Change-Id: I5071dce2566331ce0268a96e023ffd61a1f09e56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118870
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118139
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-15  Caolán McNamara  <caolanm@redhat.com>  [0eb49566434cf7edd9d277e59a2801c6c7b8665b]

        cid#1498147 silence Improper use of negative value
        
        and
        
        cid#1498148 Improper use of negative value
        
        Change-Id: I651ea2673c740b5563c894290dd4c130b5f2ee7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129957
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [59534c68585e9ff80ebaafee8f61c2d171bdc9de]

        Remove unused includes
        
        ...after 9663341f9249c739219ffe6cccf3762aa8dd78f3 "Bump
        --enable-compiler-plugins to Clang 3.8.0" removed the uses of
        clang::PPCallbacks and clang::Preprocessor, and
        f23aa1a51cb1beea4ebe3a61ba0c9b3abd844fd9 "Bump compiler plugins Clang baseline
        to 5.0.2" removed the uses of clang::CompilerInstance, llvm::StringRef, and
        std::size_t.  But llvm::sys::fs::OpenFlags needs llvm/Support/FileSystem.h.
        
        Change-Id: I98227554646843db5cc13f75a2baed51be752dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129962
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [bdb66b740681e9d3a94fbd0226ae1a4f1663e589]

        fix SfxItemPool::GetWhich change
        
        In
            commit 339fde9d905135e24b2f4e204009ee289d678b0c
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Feb 15 08:56:13 2022 +0200
            add typed GetWhich operations
        I got the parameter type wrong
        
        Change-Id: I7b1d86bc06da7feb3238f5033bbffbd166cd4fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129959
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-15  Harshita Nag  <nagharshita16@gmail.com>  [6125517102493341b8172acd463dd9126afa7a64]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with Color
        
        Change-Id: Ife5de403a4684c8cae066d8b063f6bf0a989a3ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120612
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-02-15  Henry Castro  <hcastro@collabora.com>  [f45e4008cb21832fd7922dad3e014d66b15f9a4a]

        lok: sc: introduce LocalStartDrag method
        
        Update the mouse mode to start drag,
        otherwise it will conflict with normal cell selection.
        
        Change-Id: I6d4939b704114e7de1c9c051459fd02100a7536c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118874
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118203
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-15  rafaelhlima  <rafael.palma.lima@gmail.com>  [d519cbe89268ff24e2b8b05ba5124dca98f22b79]

        tdf#145745 Create uno:DuplicateSheet command
        
        Change-Id: Ic8d37f02d45c6f958bf6133c27997adea9bc8c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129541
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b24b2f2a346bf65c9c997926ecddd1dc5aa05d5]

        tdf#134553: sc_jumbosheets: Add unittest
        
        Change-Id: I43a401376b5ef8215fafb117d90535772440ebad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129960
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7c00544d672f0fc0f08c12f5fd9cd53fdbe96733]

        tdf#143709 - Create repaint rectangle with the old text size
        
        Otherwise, the repaint rectangle uses the new text size, which may lead
        to visual artifacts, if the old text size exceeds the new one.
        
        Change-Id: I9b49755bf6b8c453e319e2a4081d58bf2e433cd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129920
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-02-15  pragat-pandya  <pragat.pandya@gmail.com>  [5f21eaa0e6b689233336cacc949b9a55d545088f]

        tdf#145759 Using M_PI from cmath instead of magic constants.
        
        Replace the instances of Pi's value as magic number by M_PI
        Use M_PI_2 and 2_M_PI instead of calculating these values in code.
        Use basegfx functions to convert angle units.
        
        Change-Id: I6cca7cc93704a70ccf3a0571a56a789bc9df51ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129479
        Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Tested-by: Jenkins

2022-02-15  Miklos Vajna  <vmiklos@collabora.com>  [22d09d65c0e61cac1fa27af6a04a23e16f97c907]

        sw HTML export: extract a SetupFilterFromPropertyValues()
        
        From the two SetupFilterOptions() overloads, which meant that some
        options were only possible to set from FilterOptions, and others were
        only possible to set via UNO property values.
        
        Change-Id: Ib7cdbb082e93b9ff105afe72f295994733b4525a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129955
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-15  László Németh  <nemeth@numbertext.org>  [c4f6fee3bea0d8618b5815e60304ff9359ccd21c]

        tdf#147435 sw: enable Accept Change for table selection
        
        Accept/Reject Track Change options were only enabled for
        table selections, if the first cell of the selected cell range
        contains a redline. Now they are enabled, when arbitrary cell
        of the table selection contains a redline.
        
        Note: if the selected columns don't contain any redlines and
        any tracked row changes, but the adjacent not selected columns
        contain a redline, there is a false Enable.
        
        Follow-up to commit 23846867ea32667ccf328c36142394dd6aaee8ba
        "tdf#147182 sw: accept/reject all changes of a table selection".
        
        Change-Id: I1d7af04aa3fe5232bb1ff7f9af6116bcdc621ae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129811
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-15  Michael Stahl  <michael.stahl@allotropia.de>  [71e8a947753d359bd5b4d1174f4d6332eaf4a309]

        tdf#146848 sw: fix assert about input field in undo nodes
        
        These should not be updated.
        
        soffice.bin: sw/source/core/txtnode/atrfld.cxx:713: void SwTextInputField::UpdateTextNodeContent(const rtl::OUString&): Assertion `IsFieldInDoc() && "<SwTextInputField::UpdateTextNodeContent(..)> - misusage as Input Field is not in document content."' failed.
        
        3   SwTextInputField::UpdateTextNodeContent(rtl::OUString const&)
        4   SwTextInputField::NotifyContentChange(SwFormatField&) at sw/source/core/txtnode/atrfld.cxx:669
        5   SwTextField::ExpandTextField(bool) const
        6   SwFormatField::UpdateTextNode(SfxPoolItem const*, SfxPoolItem const*) at sw/source/core/txtnode/atrfld.cxx:407
        7   SwFormatField::SwClientNotify(SwModify const&, SfxHint const&)
        10  SwFieldType::UpdateFields() (this=0x7f7ff2d654b0) at sw/source/core/fields/fldbas.cxx:220
        11  sw::DocumentFieldsManager::UpdateFields(bool)
        12  SwFEShell::Paste(SwDoc&, bool) at sw/source/core/frmedt/fecopy.cxx:1117
        
        Somehow this causes testTdf139843 to go from 7 to 6 pages, but opening
        the bugdoc shows it as 6 pages too, not sure what's going on there.
        
        Change-Id: Ie25b2b2c4d8fd262850da31cbade5e121e9ec361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129919
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-15  Noel Grandin  <noel@peralex.com>  [224369b351884e8315368cfc99620c42eb97ee15]

        revert component name changes to makefile
        
        This reverts
            commit 2483cd198b51bd5d0819cbebf40f211b2ef1236d
            Author: Jan-Marek Glogowski <glogow@fbihome.de>
            Date:   Fri Feb 11 19:40:36 2022 +0100
            Correctly depend on source component file
        and
            commit 17ec55c48082254e1f55bcfa00808e45a50a9801
            Author: Jan-Marek Glogowski <glogow@fbihome.de>
            Date:   Thu Jan 20 10:06:54 2022 +0100
            Fail on non-optional, but filtered component names
        
        because they cause failures on Windows builds that look
        like:
        warning: failed to load external entity "C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows@2/workdir/ComponentTarget/binaryurp/source/binaryurp.component"
        cannot process C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows@2/workdir/ComponentTarget/binaryurp/source/binaryurp.component
        
        Change-Id: Ia34cdabd76b47a6a4686ebd0f96ceb774d3236f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129956
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [4246932611f99748684d05e6cbfd41e28430c5d2]

        Clean up some global sal_Unicode[] vars
        
        Change-Id: I40823a88ffc6808b45790b212617e31937c0861e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129952
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2f767b436e8bd0cb0b6d974d9236a1b448ed8aa]

        remove not-so-useful move operator from uno::WeakReference
        
        I messed up when I added
        
            commit a0ebc6f898992dbc0da9f252911da867dfdfd741
            Date:   Sat Nov 9 08:47:48 2019 +0200
            missing move operator=
        
        which is not a real move operator because it has the wrong type in it's
        parameter list, and doesn't actually do anything useful as a
        consequence.
        
        Change-Id: I7bd3d41d6ed98deecd143b1e1bb64870530dab03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [339d481688c4d12a05ae79611f7b1b17cfa2826b]

        LIBO_INTERNAL_ONLY stuff does not need to be SAL_CALL
        
        Change-Id: I9d7ccaab19ad20509601642745e3fdaea50304ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129818
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [ddb682f6f7955595065df97b5d13497c08e38389]

        return by const& from SdrObject::GetName
        
        shaves some small amount off the profile of loading a large chart
        
        Change-Id: I24c99a68382663e52baccd34e22b63bf16fa1eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129954
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [2029fb151855fba2f812403fbb96b0db1965bcf6]

        loplugin:fakebool
        
        ("use 'bool' instead of 'gboolean' (aka 'int')")
        Change-Id: I9a2e830ecf22f65a8313985a07c98d4e92ea5688
        
        Change-Id: I2cf51ce0ad6107339c8ec18592c952c829a7af42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129951
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Sarper Akdemir  <sarper.akdemir@collabora.com>  [6df267780c4d41b41101c1be0a954b2f16ee8012]

        tdf#132557: PPTX import: Workaround for slide footer shape presets
        
        It appears that placeholder shapes with service names:
          - com.sun.star.presentation.TitleTextShape
          - com.sun.star.presentation.DateTimeShape
          - com.sun.star.presentation.FooterShape
          - com.sun.star.presentation.SlideNumberShape
          ...
        
        Are unable to have custom shapes in Impress. (i.e. can't be
        ellipse, triangle etc.). These presets get specified in OOXML
        with <a:prstGeom prst="ellipse"/> inside spPr (shape properties).
        
        Therefore with similar results to the PPT import, a workaround
        is applied where slide footers which have non default shapes
        are imported with com.sun.star.drawing.CustomShapes service.
        
        The layout/master footers are left as is since if they were to
        be imported as CustomShapes they would appear on each slide
        even if the slide had those footers enabled or not.
        
        Change-Id: Ic8a8ab3f6dfb7367ecd2c619ce888bf77abef460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129889
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [16ebca1cd9732fe613fd89884c84fa3b3a0184ea]

        -Werror,-Wunused-private-field
        
        (all its uses are wrapped in #if 0)
        
        Change-Id: I16ad0406327a9ced791bbd1baae40d66a2e5b3ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129950
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [ad1cc7420ff87745ef6981a85e4e0122f8d8a9e3]

        find-unneeded-includes: check existence of files listed in yaml files
        
        It might happen that some files are removed/renamed
        warn about such files to adjust filter rules
        
        Change-Id: Ib8f1c586a67310cc8be04edfcc75f655da2dbfe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129881
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-15  Miklos Vajna  <vmiklos@collabora.com>  [400d36a9a04ae3568d3430b7519cf1e23f9686d4]

        sw: document sw::GroupUndoGuard
        
        This has nothing to do with group shapes, even if it's next to
        DrawUndoGuard.
        
        Change-Id: I2e4608cb2941142f05ba633911709143eb3f9800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129924
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [339fde9d905135e24b2f4e204009ee289d678b0c]

        add typed GetWhich operations
        
        to reduce boilerplate at call sites
        
        Change-Id: I290c2bf60ad5e6ddb000aa26cf543830ed39120a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [459373a2fe7c7a5d04b3dd4d64f70d3f18525d33]

        Fix xml namespace
        
        Follow-up to 82f8a96065194913a6f452bd8fe0ac2ad26a4be0
        
        Change-Id: I3f347b162dd6c094557e9b13e24aa8290ecc1d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129947
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [92d08206b48f8ac426dce9bdfda599cb997e1f41]

        test for jumbosheet named ranges export/import
        
        Change-Id: I17df36688187f68be6c3ed564e8b4da42522e489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129921
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [3c24fe20ec6cb450abc4a822d323874ebbaecb10]

        don't export a document twice in a test when not needed
        
        XPathHelper::parseExport2() exports the document, which duplicates
        what saveAndReload() does, it's enough to use the first export.
        
        Change-Id: I36d740765d9267a45e37bd72c7b68e8dbd1a405c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129855
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [7714bee48caafc80135f3df78e00b5e407e7ee22]

        "&(*xShell)" -> "*xShell"
        
        Change-Id: I259ff2b545491591ca5918380208ec96e223e2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129854
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [a97a492080b0dd0a885e32e7ebb8f1b9899f889c]

        tests for import/export of full-row/column ranges in huge sheets
        
        Check that =SUM(2:2) or =SUM(C:C) are read and written properly.
        
        Change-Id: Idf77d4ff5e8d1ee7434f0017289c60ec9d938dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129850
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Luboš Luňák  <l.lunak@collabora.com>  [af85db89093767656382106b0ff8da68c0afecc9]

        finally write entire row/column references as such to ODS
        
        The comment from eeea41e2e726dd5d69cd323909e1666efb9de472 saying
        that we may want to enable this in the future is from June 2015,
        so I think we may now want to enable this.
        
        Change-Id: I4151784dcf46f75e1ca786428c24c7039a713986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129848
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-15  Stephan Bergmann  <sbergman@redhat.com>  [1748245ab1bdbaf6fe4067d7fd864d98ad6823d6]

        Fix CppunitTest_sc_jumbosheets_test for ASan
        
        ...cf. test::BootstrapFixture::validate (test/source/bootstrapfixture.cxx),
        which it uses
        
        Change-Id: I77ebb83634ca8a4ae33a370222ac327a9b391874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129914
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-15  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [44d237c375b7ef9a5a61a2f752bd19b57649ffbd]

        tdf#104902 - Handle embedded newline in Calc's .uno:EnterString
        
        Change-Id: I6377aebb06b6e6873ce61984a887d9e16eecd361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127766
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-02-15  4k5h1t  <ask160203@gmail.com>  [31180cc24f8ff66895c52a2d4aa828ee0dcb34f3]

        tdf#145092 - Remove option "Word justify" from FontWork toolbar
        
        Change-Id: Id36f7b1b8313868e730018737b353d92adbde33e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124337
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-15  Jim Raykowski  <raykowj@gmail.com>  [d4ce88a36428231e65cc247967890496192e78cc]

        SwNavigator: Check if document changed before calling HasContentChanged
        
        The HasContentChanged function is costly. This patch makes
        HasContentChanged only be called if the document change flag has not
        been cleared when the content tree gains focus.
        
        Change-Id: Iab051f6eea23d7bea91195214f6efdfcf5f24cc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129700
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [2bb10a827ac13d0caf009e8526ccd9f17dc71653]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 96ecbe7fb1c54ffec16a13b052dcee884f2ecb5a
          - Corrections to pt-BR thesaurus
            
            This patch fixes many entries with spelling mistakes. For each patchset there is a message with the list of words fixed.
            
            Change-Id: I3b123c89afe4826318b00800646f682412cce119
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/128540
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [69e964c77e689e493f12c265b87adb89ae66fbd6]

        Fix typo
        
        Change-Id: Ib78a5987b5fa9c7117583e24e6945b1e2c724690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129901
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [82f8a96065194913a6f452bd8fe0ac2ad26a4be0]

        Add LibreOffice Crash extension
        
        This extension crashes LibreOffice.
        It is to be used to test the crashreporter setup.
        
        Change-Id: I494cdcd746dd49a4f566507712c601494a0bbfac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128906
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d0c4b646aa5b90794eb41a8a82db78fa0b8e66da]

        tdf#147027: vcl_pdfexport: Add unittest
        
        This is the only way I could find to test this issue
        
        Change-Id: Ib47355562abd69f9d15184e1f044e21da3a87fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129923
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5727a12acc6a159ff2df3526530fee8e3fca2984]

        Adding Central Kurdish(ckb) Spell Checker & Dictionary
        
        Part II (core) Dictionary packaging
        
        Based on
        https://gerrit.libreoffice.org/c/core/+/59882
        
        Change-Id: Ib60553acf1764743918e666d4e6308c1976c6813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129120
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-14  jwtiyar nariman  <jwtiyar@gmail.com>  [27f7077cff0c85c99c34d7bf47c14179f105e2d1]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 86b4933bf508370ae9668a0906359a86d1f35395
          - Adding Central Kurdish(ckb) Spell Checker & Dictionary
            
            Part I: Dictionary components
            
            Change-Id: I1feac655796024e22fc1993edb4e2e8675c45b9b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/122939
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Eike Rathke <erack@redhat.com>
            
2022-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [b05f2e0f3117ed59f63d97cebeb7ea7372df8ed5]

        tdf#147394: sc: Add UItest
        
        Change-Id: I0fa20d777247501593ac80ab394407d0570763bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129910
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c49a9c98620153e206a3aabc2a89ef19c0a1046]

        sw_uiwriter3: just check the number of pages is the same...
        
        ... before and after, sometimes it might be 6 instead
        of 7 and in this test we just care about it not crashing
        
        Change-Id: Ia358517f4b0c566199af368da51ba385845218a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129916
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-14  Luboš Luňák  <l.lunak@collabora.com>  [4eb0ee5032903d301c0dde30ed3d25d16cab3a4c]

        make sanitizers happy
        
        See https://gerrit.libreoffice.org/c/core/+/129892 .
        
        Change-Id: I28eb22332bff3fca2a204e9fa170eb228f371c30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129902
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-14  Luboš Luňák  <l.lunak@collabora.com>  [0691cc55148503448012326b070aa9209c54270b]

        remove hardcoded MAXCOL/MAXROW from datatableview.cxx (tdf#135332)
        
        Also remove the pointless separate Init() functions.
        
        Change-Id: I6235047ea472899c0885d86a84a603d7641c3191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129913
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-14  Luboš Luňák  <l.lunak@collabora.com>  [7adb3757944452a0f3a1a12fee1dd504eb90a1df]

        don't gradually move columns to a large distance (tdf#144380)
        
        The old code was trying to move the changed columns, each one in
        a loop, which is O(N^2). Since the changed columns are those that
        are inserted/deleted (and thus the content shouldn't matter),
        instead move all the columns after them to the right place,
        which is O(N).
        
        Change-Id: Iad29b945fe9b3525ece43523ba04ecf306797c6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129911
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-14  Caolán McNamara  <caolanm@redhat.com>  [3d61c9026a8a562022fa3099472a82b60172f112]

        update play/pause/stop when one of the other changes
        
        so (esp under gtk) that when pause is enabled and pause
        is clicked again that it remains visually enabled
        
        Change-Id: I779bb1491d2473db926b8075a0b574ef5767337d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-14  Caolán McNamara  <caolanm@redhat.com>  [0414b84a8ad5a436df4354a5af1e8486334acb42]

        Related: tdf#34759 ditch PlayPending hack and use GST_STATE_TARGET
        
        which seems to resolve the various problems here like that
        pressing stop makes it rewind to start but continue to play and
        that rewind/seek makes it start when it shouldn't
        
        Change-Id: I3df44f82205b7e81ecbc4ac86240e02d52a92e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129907
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-14  Caolán McNamara  <caolanm@redhat.com>  [6a3f402f44572ddaa409915a5d67c10cec8d63b5]

        cid#1472568 silence Integer handling issues DIVIDE_BY_ZERO
        
        Change-Id: I196e3910804902c9251b46497b1626f3470b6171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129905
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-14  Pranam Lashkari  <lpranam@collabora.com>  [48c32f1118431afded725b21b6bf65b89a52ecdd]

        updated gitignore for Android builds
        
        Change-Id: I7603b1de266745ba23a3d991d5e903c6fac9ab41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117674
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122905
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129915
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-02-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [14001bc7586b2c4ba16ff62629ab710a2b5346e2]

        Recheck modules s[a-c]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I867e1f7a2c44210de3281b36e22708a5d32ddb7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129476
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [b4c131cf4237ed7d4e4be1212318c818dc943fce]

        tdf#109061: sc_jumbosheets: Add unittest
        
        Change-Id: Id0b930ebb478809b857c7d03a0d11ccb070c2ffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129904
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [644520cdefcc9170ee0ec57e200f5765cb51eab0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4cbfef4feb88cc1186760ca3dec7208e207c82e8
          - Document new locale-related properties in SF_Platform
            
            New properties are: FormatLocale, OfficeLocale and SystemLocale.
            
            Change-Id: I9203a41c891f3c7491d78b8d2eede369d77679e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129831
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-02-14  Caolán McNamara  <caolanm@redhat.com>  [21292d2bdc669ed379185c1e324727071cffc082]

        Related: tdf#100007 pause state not always updating "play" state to off
        
        if I press pause then the UI gets stuck with both pause and stop
        pressed in, the check against time here seems insufficient so
        change merge and the setters to return true if there was a real
        change and use that as the guard to update the UI
        
        Change-Id: I550624fa3dcd5655d715a1f965bba9345b25ded7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-14  Caolán McNamara  <caolanm@redhat.com>  [e37b9b21edccf2750816c18103b5b39d42779fac]

        can drop unneeded TODO
        
        Change-Id: I58d65b1da1aa54716b84fc31af7550037817194a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129908
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-14  rafaelhlima  <rafael.palma.lima@gmail.com>  [bf5277500d0d317a24df66f81b7409301f8422a6]

        tdf#147042 Manage changes sidedbar no longer needs to be experimental
        
        Currently the Manage Changes sidebar in Writer only appears if experimental features are enabled. However, since the sidebar relies on a fully functional dialog, it no longer needs to be experimental.
        
        Change-Id: Ia18a4e81c606c8dcbe5a53eaba33c0109f939dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129477
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-14  Michael Stahl  <michael.stahl@allotropia.de>  [e7874c936dd1ff9b3423eb7477cbee2494535176]

        sw: layout: fix overlapped table rows in --convert-to pdf
        
        If the document is loaded via UI, the first layout action is triggered
        from resizing the Window and the table is positioned properly on the
        first try.
        
        If the document is loaded via --convert-to, only getRendererCount()
        formats the content of the table, and positioning goes wrong.
        
        Somehow the 2 rows of the table in the fly end up on the same Y
        position, because when the text frame in the 1st row is formatted
        and grows from 0 to 230, the already-valid position of the cell
        frame in the 2nd row is not invalidated.
        
        This happens since the earliest version checked, OOo 3.4 beta.
        
        This fix is somewhat similar to commit
        068c133ac41c97652909b88c432e3b73010efc3e
        
        Change-Id: I3259c440265cfe40dc7731cb4830bfe2487acf38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129851
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-14  Michael Stahl  <michael.stahl@allotropia.de>  [75cb31432c8e928fdf75fcd2e5c14b4c543c1a8f]

        flat-odf-cleanup.py: remove rsid attributes
        
        Change-Id: I2d2bcd2bce525b111906c59d2d119e1d63d2174b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129852
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-14  Roman Kuznetsov  <antilibreoffice@gmail.com>  [23f1d0436f4a23b496c271c86325b8e336d60f3b]

        tdf#143266 Use correct menu item's names in ToD
        
        Change-Id: I0796e6c8b2dc2b6e56e7e69611cbcb97ff3e7e34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129842
        Tested-by: Jenkins
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-14  Miklos Vajna  <vmiklos@collabora.com>  [2f0c26dc83448a934af5383f9f6b7a607c334744]

        sw: prefix members of ConditionEdit, SwView, SwXFilterOptions and ...
        
        ... SwXViewSettings
        
        See tdf#94879 for motivation.
        
        Change-Id: I68f647d13edf156cfc471a54f247ac686cd6cd06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129893
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-14  Luboš Luňák  <l.lunak@collabora.com>  [32e480cecd9f5c35880a8d1762012e44c36c478c]

        remove use of MAXCOL/MAXROW from address.hxx
        
        Change-Id: Icfc00584b0190ee90e506f80c73231e12f155cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129853
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [5382df1422832fb7a18a2a39ac52fb75ababff17]

        find-unneeded-includes: rename argument to --continue
        
        sounds more natural than --dontstop
        
        Change-Id: I4650f8bf97a426782828f0e088805551c5830acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129880
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [58ac3288b5a4a1f1f9b21fed4f4c1ab06dd43db9]

        cui: show image pixel size below logic size
        
        Change-Id: If919d1fade2ed85aec7437b429a648ca658e2c92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129885
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ace0adfd2312211854a61fdc0aa60c1ba9c4d446]

        cui: prefix member variables of SvxGrfCropPage class
        
        Change-Id: If6f4a32df97c352d30958fb27dc90ffec5bbf44d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129884
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-13  Noel Grandin  <noelgrandin@gmail.com>  [11a3e5707d6b524728b24e170eb542bba273d811]

        tdf#147394 delete crash legend
        
        regression from
            commit 63e8c2ccd39263b24f644c3d0394044a2613eb88
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Jan 29 21:21:27 2022 +0200
            use more concrete types in chart2, Diagram
        
        Change-Id: I6598bb7c116bd94272a805e77751aa8cf5dc174a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-13  Johnny_M  <klasse@partyheld.de>  [5854e65351a7ff430b01ec9eb7db75fa659c3ee1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1c448c51a9ba356c62e1fe100186e076228b081e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I70ffee911ca9cfcc1ade46198223b0e9dbe9ed84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129874
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Noel Grandin  <noelgrandin@gmail.com>  [9985cc1088218c616f9cb8854cd58eb1f4fa895c]

        rtl::Static -> local static
        
        Change-Id: I43059938f1fc814b2b8306258210a67d7a1fac84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-13  Luboš Luňák  <l.lunak@centrum.cz>  [0e3092fd6c8dc8908bd7820a4eb858771ca7eb00]

        set up gb_COMPILER_SETUP properly for gb_ExternalProject_run
        
        If the command to run would be "cmd1 && cmd2", the old way would
        set up the variables only for the first command.
        
        Change-Id: I190bbf535eab4fb0191a87add2ec19e9a2f11e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129878
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-13  Luboš Luňák  <l.lunak@centrum.cz>  [c5e29ad23da99913a73e28e7d5d1c096c7b9e312]

        may just as well use -Z7 if trying to avoid shared .pdb access
        
        -Z7 writes all debug info into the .obj file, so it avoids the .pdb
        altogether.
        
        Change-Id: I89265009782d0a901ba3583a7241da0daf83860e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129877
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-13  Johnny_M  <klasse@partyheld.de>  [bff93ba74ec9fdb21ab5aba9df33c181d5a7408f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0a82cbf071c1c6540bbcd3dace8f29d3e13625ad
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifc3ae651992037a4ebd9f067abed75e83ddca76f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129873
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [4c8d0abf65b127e38d8d0a113f208ec52ffd9a36]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dfaa80e9ae8c0948a6d1691b5e0406c6fe205f25
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8b146a974b3220561ce6f2d1181851663f0b409d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129872
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [5e52cad9d5a0432f707328ff8ddbc0e935bb1487]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6eb4e6b6a68f36db612040f391a8683780eee460
          - tdf#132643 Translate German section IDs
            
            Change-Id: I33c485aee4f6e16bb35ceda14541091b09cf1088
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129871
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [a3270efa82ef35907f87e9c26b80b417e633f0ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e0a8c989991406a0644272544763cc46dca13b2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2c3da3855c159524fa0e20fc3b817857b96cd9d8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129870
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [7c6e8c7e34c91016ae62c4d47f6d44468bf6b470]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a7e0e8446ea94f6ca0737750a88ba7f8229bfd20
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8f9898aae8da81c5a04fddf4fa824143051ffeac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129869
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [d092fd5d773bae722e2af5f21b106a3475d0aa27]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c60e4d69ec32eb450e5075c03af329ae141eb33d
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ie363a0cacea00c34f1b16f2b767e198d45ac3a92
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129868
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Johnny_M  <klasse@partyheld.de>  [c1ec5b45d745ad5af7aa6abdf30b56a0f59372ec]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 348add24c9ee527eb35d52ef1a4204ea2980077c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I892e5e64d6d430dd3d12ad5329b48ba4e2e1d5c7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129867
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-13  Julien Nabet  <serval2412@yahoo.fr>  [d582bc9735022996a317ed661388621edabf78cc]

        tdf#147343: Wrong typo for AM/PM indicator in Spanish locales
        
        Change-Id: I0cc077a94b6f11f67436981033e024e3097c635a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129793
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [03358ae57959e14a62e3c9e6b7cb6ce6a7bde3ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd2715dfc0b767f9478566d5d0ae58b722c685cb
          -  Allow Contents to access targets in Help page
            
            Change-Id: I42f0a0805353608538dc1cb476c5bfccaa707a6d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129826
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-02-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [95b80365218f9406a5d952c1250d53222d319000]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3a3a1b9968d7735d4fe3c201b52c9a4942f1e09
          - tdf#137259 Update BETAINV and BETA.INV description
            
            Patch set 2
            The namespace information was by tdf#94537
            
            Change-Id: Ic107bdf1a15b762fe8962ae68d536df3acc8b7da
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129821
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-12  Stephan Bergmann  <sbergman@redhat.com>  [d2ba5d98ec67e684c819ef80421eb496723a8d06]

        Fix some tautological std::type_info (in-)equality comparisons
        
        ...which could never succeed.
        
        I became aware of this when Clang 15 trunk -std=c++2b, implementing
        <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1328r1.html> "Making
        std::type_info::operator== constexpr", pointed at two of the broken comparisons
        with
        
        > sw/source/uibase/app/docsh2.cxx:478:25: error: code will never be executed [-Werror,-Wunreachable-code]
        >                         pTmpFrame->GetFrame().Appear();
        >                         ^~~~~~~~~
        > sw/source/uibase/app/docsh2.cxx:475:33: error: code will never be executed [-Werror,-Wunreachable-code]
        >                         bOnly = false;
        >                                 ^~~~~
        
        (It didn't emit warnings pointing at any of the other broken comparisons,
        though.)
        
        All of these broken comparisons were regressions introduced with
        89d39bc100aabf5dccbe77c0b5c0c85736e85b39 "tdf#94559: 4th step to remove
        rtti.hxx", replacing uses of the IS_TYPE macro (from include/tools/rtti.hxx,
        meanwhile removed with d64e535fe9a00b671cf1be3eb5632c0d5f4b8bea "Remove unused
        rtti.hxx").
        
        I now added loplugin:typeidcomparison to also find the other broken comparisons
        introduced by that commit.  (The remaining cases where that commit replaced uses
        of TYPE_INFO with typeid comparisons were correct and/or have meanwhile been
        replaced with code not using typeid, see
        553ee72041d6f66e26156eb1ad0d9e3c13457f7a "simplify some use of typeid" and
        d656da9bc4f2df0bb99c65a288847e3fdd43a37c "~SwModify: do not silently tolerate
        clients registered past death".)
        
        The original IS_TYPE macro made sure not to dereference null pointers,
        
        > #define IS_TYPE(T,pObj) \
        >         ( pObj && (pObj)->Type() == TYPE(T) )
        
        I don't know if any of the pointers now dereferenced in those typeid expressions
        can legitimately be null.  But to be on the safe side, I replicated that check
        in the newly introduced isType (sw/inc/istype.hxx).
        
        (It is interesting to note that none of the static analysis that we routinely
        employ seems to have noticed these broken comparisons.)
        
        Change-Id: I65baffdd27bac1abf744283ff98c2dc864fa63b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129865
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-12  Eike Rathke  <erack@redhat.com>  [7cd3013a3704b8365e295f4260e242273d45d27e]

        Update language-subtag-registry to 2021-12-29
        
        Change-Id: Ia9e1c68bd13974ec7403016197cc2d91c193f7bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129860
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-12  Stephan Bergmann  <sbergman@redhat.com>  [29126e36a8c76ed9447e2d0375962e152a355a3c]

        Simplify checking for exported std::type_info symbols
        
        ...to cover just those four classes for which type_info is actually exported
        from Library_salhelper (at least under the rules of the Itanium ABI).  (All
        these checks had been introduced with c62a55b37f5d8918aa25e2f6876a016b0da13ebc
        "INTEGRATION: CWS sb22: #109743# Test that the API exports the necessary
        symbols.")
        
        Change-Id: I71e86ed19f4ee63ffb2519aca37c6757169d2a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129863
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-12  javierde22  <javierde22@hotmail.com>  [436ed3693d3edf409ab99762349e79c8597ccdff]

        Resolves: tdf#147053 Add Aranese {oc-ES} locale data
        
        Change-Id: Id7f1f11a9ebb6b2ad1484e6ff5cdb9e271fc982d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129178
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [8311159f9d2a259e1bc1a051cceef007c71866a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 42b1b45509ab2fa2de686f248781468e09d3f9d8
          - Use max-width in YouTube placeholder style
            
            Change-Id: I8acaa11f8d8c11f5034cea7c4dfc247cee90d487
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129857
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-02-12  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [9654c8e4bd87259d5fd198132cfa557cd314c707]

        Basic compiler undetected typo
        
        Change-Id: I53add0bbb14e084978e3582083978924d1c11c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129434
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-12  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [5c44540954b4acc53938d54826ddb4c395c5eb8a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3994c9e899323a85d4db4f9264f5dda8aae5b92b
          - tdf#146847 (\) Integer Division operator help page
            
            Change-Id: I43e82fd2038a8f557c1fcefebd1beadb2bda7184
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129432
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-02-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ca22f1ce703c1d03fc1b1ed1f5ac1fc903b09e6f]

        chart2: Break labels text and limit the size to the axis size
        
        Previously a long label wouldn't be broken into multiple lines
        and be limited to the axis size if the chart sizing was automatic.
        This would cause the label to distort the whole chart and make the
        chart area very narrow. With this change the label text is limited
        to the axis width and gets broken into multiple lines if this is
        necessary.
        
        BarChartVeryLongLabel.odp provides a test document which includes
        automatic size and fixed size chart are. We make sure the area
        that the label text occupies is not larger than the chart wall
        size.
        
        Change-Id: If58bfa3e51ab68f720f22df5416ae305401bcd34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129814
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [92da88582ae8d5ddbd786f9936e1b2b46eaddf2c]

        chart2: crop x-axis label if it's too long on fixed size charts
        
        If the label text is too long on a fixed size chart area, crop it
        as we can't resize the chart area to accomodate for text breaking
        into multiple lines.
        
        The algorithm to determine if cropping is needed has assumed that
        we need this in case the x-axis label is vertical, so there was
        no check to actually make sure the text is horizontal or vertical
        and in case it was horizontal, it has taken height into account
        and not width, so nothing got cropped.
        
        Change-Id: I8e73027fc51722280418c9e0be34ce487c41171e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129813
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-11  Henry Castro  <hcastro@collabora.com>  [0bf0feb40ae5c394a14cdfe4f94fb98dd9053597]

        lok: add drag & drop functionality
        
        In the desktop case, the drag over and drag drop events are
        handled external like GTK framework. In tiled rendering case,
        we do not have it, so handle the drag and drop events in the
        cloned ImplLOKHandleMouseEvent function.
        
        Change-Id: Ib41232b3b9d5d6d859b2c965311b87af5d193ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118869
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117896
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [2483cd198b51bd5d0819cbebf40f211b2ef1236d]

        Correctly depend on source component file
        
        Regression from commit 17ec55c48082254e1f55bcfa00808e45a50a9801
        ("Fail on non-optional, but filtered component names").
        
        Change-Id: Idab5b3dbf9658c03b0ec1af67d1d9b740111c6a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129849
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-11  Miklos Vajna  <vmiklos@collabora.com>  [b86679ea6bd2bb053c3822c4642a62a49e381909]

        sw XHTML / ReqIF filter: avoid adding and removing <br>s for trailing <br>s
        
        The sw/ HTML export writes two <br>s for a <br> in the doc model at the
        end of a paragraph, because the last <br> would be ignored by browsers.
        But then the import ignores all <br>s at the end of paragraphs, so the
        import and the export are not a 1:1 mapping; but at least the layout of
        the exported HTML is close to the Writer layout.
        
        ReqIF focuses on the preserving the semantics of the doc model instead:
        it already doesn't open the document in "web view", and it's not
        expected that the number of <br>s change on import or export.
        
        Fix the problem by disabling both the import and the export tweaks in
        the ReqIF case.
        
        It would perhaps make sense to do this in general, but for users who
        only care about the export layout (and never import the result again),
        that would be probably a regression, so don't change this
        unconditionally for now.
        
        Change-Id: Iabd4a462185493c1ece0352069077e04c293816b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129820
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-11  Luboš Luňák  <l.lunak@collabora.com>  [ff8e1199b338df5f28b200d417947c96fc919b12]

        basic import/export test for ods/xlsx with a value in column 2000
        
        Which is above the "normal" 1024 column limit. This tests my recent
        commits.
        
        Change-Id: I8ec3fcdbfef879ca0eeec4cfa3fa067378f6f57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129823
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-11  Luboš Luňák  <l.lunak@collabora.com>  [06759801f0a9e8ee80790cf7b8aa02fcb47290a0]

        rename class in jumbosheets-test.cxx to ScJumboSheetsTest
        
        The ScFiltersTest name was probably a copy&paste leftover.
        
        Change-Id: I4b4e43e264fb5274fa4672f4db2ebbcb083e4e25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129822
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-11  Caolán McNamara  <caolanm@redhat.com>  [a4b8925e57fa727c980157ebeef83100386c7444]

        Resolves: tdf#147325 "Edit in SQL View" should accept tab
        
        Change-Id: I286281c317c30e5c189747f2d4844a0d5dd0828f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-11  zhutyra  <zhutyra>  [9d5005ac7bb27fb336bc4b593936fe2230b23eac]

        limit style export to words max style count
        
        LIBREOFFICE-U78X8I5G
        
        Change-Id: I436b4c13a4ce07f5e9e5d374163bc4de55cd2cde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129803
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-11  Henry Castro  <hcastro@collabora.com>  [54ac7d8472e807a50ef60fe366410779070238fe]

        lok: fix the "mbStartDragCalled" status
        
        The drag starts it is only called when mouse down +
        mouse move.
        
        Change-Id: Ifadfd904c2be28bd123c17a47a82f49dd6d5a04a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118867
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117895
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-11  Stephan Bergmann  <sbergman@redhat.com>  [7f15354c4f5048d7b9fd9fec5968f81e8ef8b09b]

        Avoid warning C4702: unreachable code
        
        > C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\sc\inc\arraysumfunctor.hxx(75) : error C2220: the following warning is treated as an error
        > C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\sc\inc\arraysumfunctor.hxx(75) : warning C4702: unreachable code
        
        (<https://ci.libreoffice.org//job/lo_tb_master_win64_dbg/32859/>)
        
        Change-Id: I27a66176717b293d60f98f82f06ec5ce7a28e6c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129812
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [b545f7feef14ec5cee19d7c49adfca6dbefa14ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fbf1f624314ee83866d10c2b53741ac4c1d0e08f
          - Document new properties/methods in SF_Platform and SF_FileSystem
            
            This patch documents the Extensions property in SF_Platform and the new ExtensionFolder method in SF_FileSystem.
            
            Change-Id: I4adca2d71ae9ac6d2f6a3dfc59d055e92b0ceb2d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129757
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-02-11  Mike Kaganski  <mike.kaganski@collabora.com>  [5276177877cc53c53653a87f3038eb208a5580ab]

        tdf#147364: fix function signature to account to calling convention
        
        First, the integer function result is returned in a 64-bit register (RAX),
        and truncation it to sal_Int32 breaks any pointer return value.
        
        Second, using explicit (not vararg) first function double argument would
        pass it through XMM0, without also copying it to RCX (which is guaranteed
        for varargs).
        
        Ref: https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention
        Change-Id: I08212c44d8690d6910068b13c16af2ce899c94f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129808
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-11  Henry Castro  <hcastro@collabora.com>  [de1c0ccc3766b4a9367d16a972adc04ef011a536]

        svx: fix dynamic cast SdrView
        
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]: SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/collabora/online-buildscripts/staging/builddir/libreoffice/svx/source/sdr/contact/objectcontactofpageview.cxx:353:57 in
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]: /home/collabora/online-buildscripts/staging/builddir/libreoffice/include/svx/svdview.hxx:235:65: runtime error: member access within address 0x61c000489880 which does not point to an object of type 'SdrView'
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]: 0x61c000489880: note: object is of type 'SdrPaintView'
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]:  7c 04 80 3b  90 58 b9 3d 60 7f 00 00  30 51 96 0a 20 60 00 00  38 51 96 0a 20 60 00 00  38 51 96 0a
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]:               ^~~~~~~~~~~~~~~~~~~~~~~
        Jan 19 13:48:41 ip-172-31-35-149 coolwsd[23647]:               vptr for 'SdrPaintView'
        
        Change-Id: Ifc9177902ac834d400d6bf9f72b94e82f544b348
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-11  Henry Castro  <hcastro@collabora.com>  [1000a4fa834c8d7b20ed235b124d9c4fe9cd2e26]

        lok: add private member transfer data to GenericDragSource
        
        In tiled rendering case, the class GenericDragSource is
        created by default, but it does not hold the transfer data
        and it cancels the drag & drop.
        
        Change-Id: Ib96f426a42e1fdae823e2412dc5280d70b59c44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118866
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117894
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-11  Michael Stahl  <michael.stahl@allotropia.de>  [b4271e028686d729189afc5e42a9c310f81144f3]

        sw: fix layout loop on soffice --convert-to pdf ooo95698-1.odt
        
        For unknown reasons, this loops since commit
        32902f66e7749b2d06d13f50416be5323a0c0ea9a
        "sw_redlinehide: make layout based Show/Hide mode the default"
        
        The problem is that when page 1 is layouted for the first time, it
        splits into 6 pages, and then the SwTabFrame 47 decides that it wants
        to move its follow flow line because it fits onto page 1.
        
        Then splitting the SwTabFrame again fails, but for this
        RemoveFollowFlowLine() was called a 2nd time and removed the one on
        page 3.
        
        The result is a layout with content on page 1, nothing on page 2, 3
        and again content on page 4.  This seems to reoccur every time page 1
        is formatted.
        
        But the first RemoveFollowFlowLine() was wrong because
        CalcHeightOfFirstContentLine() returns 0 because
        lcl_CalcHeightOfFirstContentLine() didn't handle the case of
        SwSectionFrame containing SwTabFrame.
        
        This is similar to commit e024cad7c1365da6a198656c3ca0c32b28938e87
        doing the same thing for text frames in section.
        
        Change-Id: I23fb4d1d56622039f461bb2d357a9c88db140605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129800
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [5505b0d7c3e5924c2614b03789307e4c26cb6f24]

        uitest: sc: add a buidable name to the tabs in DataSubTotals dialog
        
        Change-Id: I045f301083767fa32fd516a4a46823b3af4a6a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129794
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-11  Caolán McNamara  <caolanm@redhat.com>  [9576b5e411562bcbe6c6be9a78560874e66a1b1e]

        these label properties are already set to this text in the .ui
        
        so we're just wastefully overwriting with the same string
        
        Change-Id: Ib03d5ae2cf48aa00f5f31256427afef58b684177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129802
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-11  Miklos Vajna  <vmiklos@collabora.com>  [00b0ff0687081bd6e88d3c3b0a1352c291fa6bb8]

        PNG export: allow setting filter data keys from the cmdline
        
        For example, to set a custom pixel size:
        
        soffice --convert-to 'png:draw_png_Export:{"PixelHeight":{"type":"long","value":"192"},"PixelWidth":{"type":"long","value":"192"}}' test.odg
        
        Change-Id: I628717ba36b6ad1ac03911eec06855c1745ef258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129801
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-11  Stephan Bergmann  <sbergman@redhat.com>  [405a7a09558ad17642808cc3739ab202f86bea0c]

        -Werror=type-limits
        
        > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/sc/source/core/data/bcaslot.cxx:647:25: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
        >              assert(slot >= 0 && slot < mnBcaSlots);
        >                     ~~~~~^~~~
        
        (<https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/36619/>), where slot is of
        type SCSIZE, which is a typedef for size_t (sc/inc/address.hxx)
        
        Change-Id: I52cfa8b746791d4bd43be9a9d16cda992319c694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129781
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-02-11  Jim Raykowski  <raykowj@gmail.com>  [39155ca940cb1541c27a9db7f4a4bb17b935f4cc]

        SwNavigator: Improve bookmark tracking
        
        Change-Id: I217b46da48c662032d00e553639e985412f681ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129710
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [473ffb6532b507aba9d69d0b57319f752142b0d2]

        mrAntiImpl field in SvxShapeImpl is unnecessary
        
        Change-Id: I196c6cafaf0ccb6c2547ca56b0e7c48c9e0dd6ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129798
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2cee820e5e204058a721c59f2c5df8d8a2a3ca8]

        merge IPropertyValueProvider into PropertyValueProvider
        
        nothing directly extends IPropertyValueProvider
        
        Change-Id: Ib393bd31bde7f68d8b21dc3bdeeb30b538de1488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129797
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [01b3187e0713243c8f71d58197da17ee87c4dbb5]

        svx::PropertyChangeNotifier improvements
        
        (*) rename the enum to make it's purpose more obvious
        
        (*) remove the enum header - it belongs to this class, no need to have
        it somewhere else
        
        (*) return property name by const&, no need to copy here
        
        (*) use a o3tl::enumarray instead of a std::unordered_map - there are
        only 3 entries here, and two of them are ALWAYS used, so just flatten
        the data structure.
        
        Change-Id: Ic496bd5220d55be1209a3243c095d461df0a02ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129788
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-11  Dennis Francis  <dennis.francis@collabora.com>  [59460f4e02cc312062d76a8fc315800129bb9219]

        lokCalcRTL: global RTL: fix chart edit mode rendering
        
        If global RTL flag is set, vcl-window X offset of chart window is
        mirrored w.r.t parent window rectangle. This has to be undone to get the
        correct chart bounding box in negative X document coordinates so that
        the offset calculations for tile rendering remains the same for RTL
        documents irrespective of the system/global RTL setting.
        
        Conflicts:
        	include/sfx2/lokcharthelper.hxx
        	sfx2/source/view/lokcharthelper.cxx
        
        Change-Id: I3e1666681af4e7ab1257bcc88d44bbdb053a7d47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129704
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit 4fd2a14c6ee68f0574766ec7ec3dca35debe9d20)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129778
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-11  Eike Rathke  <erack@redhat.com>  [0613c89308c3d37c7631a9af3605b31abcff6980]

        Better SCSTR_COLUMN, SCSTR_ROW names, tdf#140290 follow-up
        
        The remaining SCSTR_ROW wasn't used anymore at all, remove.
        Rename
        SCSTR_COLUMN      -> SCSTR_COLUMN_LETTER "Column %1"
        SCSTR_COLUMN_NAME -> SCSTR_COLUMN        "Column"
        SCSTR_ROW_NAME    -> SCSTR_ROW           "Row"
        
        Change-Id: I1f68c8d0cc4e970ca508c8ee854f4c59a6d2f7d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129806
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-11  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [96e1be11540bada172fbdbfbbe3f9b7dc3e58462]

        tdf#146917: docx import: better support for style with num reset
        
        When paragraph style is disabling numbering defined in parent
        style we should apply margin properties (like we already do
        in other numbering cases), but we should include only properties
        from styles not affected by numbering. In other words, only
        styles without w:numId are used.
        
        Unittest was extended to cover different combinations of this
        situation.
        
        Change-Id: Ic19e00fcfe16b2357cdfe763b4f969cc63122e89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129701
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-11  Heiko Tietze  <tietze.heiko@gmail.com>  [35b9e7f90ca3751d474efff7745582b4bff3e2df]

        Resolves tdf#140290 - Make sort keys accessible
        
        Inline string is plain now in favor of the caption
        Column/Row before the dopdown control
        
        Change-Id: I7f012d38c360113b7207f19fa32437d28d90d049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129366
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [063997f8371f634e671947866b9e12e0a56c0f63]

        remove obsolete code (and last MAXCOL/MAXROW) from excel filter
        
        Even if what the comment says were true, 6318254d63ef5c62bbd504
        already broke it by possibly passing MAXROL/MAXROW. This originates
        from 64274b38f6cc50a8bb49f114f1ac9e7c1c3 (the r263929 part),
        but I've checked and at least Excel2013 reads its fine. I also
        don't see anything in the OOXML spec that'd say what we do is wrong.
        
        Change-Id: I0c48beae2b54213a8b3b5e2112076a88b11e6cb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129787
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [a3510e31065245987e5314c821d5688e0d73442f]

        remove hardcoded MAXCOL/MAXROW in ScRangeListTabs
        
        Change-Id: Id26c4456429d25dbf1bf97e8cac28f86cb81563d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129786
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [6a6a147ecebfbc4f0c8a3d626737104155426393]

        move ScRangeListTabs members from RootData to XclImpRoot
        
        A comment suggests that it's the thing to do, and I'll need access
        to GetRoot() from ScRangeListTabs in another change.
        
        Change-Id: Ic0cf4b1cae7f5e1f9ad265d5a98651c51068c88c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129785
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [5e402bac39dc4245844efbde442bdb3bd993a157]

        remove most hardcoded MAXCOL/MAXROW from Calc filters
        
        Change-Id: I50d4a5c22a2b224526978e41fc7b8cb194b4bf3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129780
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [7973ba264101f46356d632545e4cb303f5b6d6c1]

        cross-toolset: fix galleries build with webp
        
        All the tested cross builds don't build galleries, so the
        cross-toolset won't contain gengal and no vcl is build.
        To fix the full static build, add LIBWEBP to the list of
        PERMITTED_BUILD_TARGETS and use gb_CONFIGURE_PLATFORMS to
        provide the --host and --build flags.
        
        Regression from commit 60eaa424c5e213f31227008e1ed66a646491a360
        ("support for the WebP image format (tdf#114532)").
        
        Change-Id: I017c4fc72456859616d535ddfb2d568442ffa446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129790
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-10  Caolán McNamara  <caolanm@redhat.com>  [f8eb28d6b6e306d87e5cec3f1b6f83c841a5f01e]

        tdf#137571 use XActionGuard to lock blocks that don't need updating
        
        so we can avoid constantly generating new TextForwarders which
        are the same as the one they replace.
        
        The underlying problem is that of tdf#123470 but this solution should
        be safe to backport
        
        Change-Id: I742f2a9ce0024adf9bd0acc5bb8edb9372fc0af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-10  Caolán McNamara  <caolanm@redhat.com>  [6ca2a8d0cf238dc504920095493c777c956cea5e]

        use std::vector
        
        Change-Id: I65eb157b530414a7e1859af97248683ed27a23c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-10  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [61f4250ee9f43902107e4d2e6322cbf54f52dd8e]

        Make CLEAN fully compliant woth ODFF v1.3
        
        Not only check for characters of category Cc, but also for characters of
        category Cn.
        Use generic functions to check is characters belong to one of the above
        categories.
        
        Follow up of commit e38ebf0737297fe94e3128459fc25ef9259faa6b.
        
        Change-Id: I97618dbf33db70b01b2833cf653988610b499333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129222
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-02-10  Luboš Luňák  <l.lunak@centrum.cz>  [807a15bd64c1f2a57371d12e7684541293cd9791]

        MSVC -arch is independent from the ability to use CPU intrinsics
        
        It's possible to write AVX512 intrinsics in code compile only with
        -arch:AVX . So do not require -arch for being able to do so,
        especially since there is no -arch option for only AVX512F without
        other AVX512 subsets (the option enables also CD, BW, DQ and VL
        https://docs.microsoft.com/en-us/cpp/build/reference/arch-x64).
        
        https://crashreport.libreoffice.org/stats/crash_details/55ef825d-c323-4df9-95e2-76672c674e60
        is presumably caused by this, I can see use of registers XMM0-15
        in arraysumAVX512.cxx built with -arch:AVX2 but when built
        with -arch:AVX512 registers XMM16-31 are used too (I'm not sure
        if that's AVX512DQ or something else, I can't find info on it).
        
        Change-Id: I74473333a17e618327d43b920b8929d1b0e733b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129724
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [8232965cfb5f50bb2e01f7749d04c227a9622860]

        replace various sal_uLong that might overflow with huge sheets
        
        16Mx16k cells is more than 32bit, so things like cell counts
        or progress -> sal_uInt64. Height/widths of complete rows/columns
        -> tools::Long.
        
        Change-Id: I8077ec0c97782310db024c20c335cfcbc3833227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129634
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [1db6e8b7760de1abd49d62df230d89480ffd2161]

        no need to use shared_ptr in PropertyChangeNotifier
        
        these things are never shared
        
        Change-Id: I21c3b7cf2abf6e47a8839ac60e7bf27b7282ed76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [2d36e7f5186ba5215f2b228b98c24520bd4f2882]

        remove AVX and AVX512 code from Calc
        
        It's been a source of numerous problems since the beginning.
        Poor separation of C++ code causing the compiler to emit some generic
        code as CPU-specific, compiler optimizations moving CPU-specific
        code out of #ifdef to unguarded static initialization, etc.
        
        And it doesn't seem to even particularly improve performance,
        on my Ryzen2500U for one full column (1m cells) sumArray() takes
        about 1.6ms with AVX, 1.9ms with SSE2 and 4.6ms with generic code.
        So SSE2 code is perhaps worth it, especially given that SSE2 is our
        baseline requirement on x86_64 everywhere and x86 on Windows,
        but AVX+ is nowhere near worth the trouble.
        
        So this code removes all AVX+ code from Calc, and makes SSE2
        a hardcoded option on where it's guaranteed. If we raise the baseline
        to AVX, the SSE2 code may be replaced by the one removed by this
        commit. Generic code is there for other platforms, if other platforms
        add CPU-specific code, they should preferably follow the same rules.
        
        This does not necessarily mean that CPU-specific code cannot
        be used at all. Some externals use them, for example. It just
        needs to be working, maintained, and worth the trouble.
        
        Change-Id: I5ab919930df9d0223db68a94bf84947984d313ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129733
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-10  Mike Kaganski  <mike.kaganski@collabora.com>  [51d1f84abf889df32218b018e66ecd1deccafd7d]

        Deduplicate PutInOrder's
        
        Change-Id: I76db8dd5398628e544fdd76179046b98f76d80a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129773
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-10  Henry Castro  <hcastro@collabora.com>  [03bcc8ad7a3347a817f087b4e444d7bed95ca973]

        lok: add generic class DragContext, DropContext
        
        In tiled rendering case, there is no exists a generic
        dummy to fire drag over and drag drop events.
        
        Change-Id: I1d334df8316a09950c11bc365f12f28f0352dfc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118860
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117893
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [9c2d5c877d61965d6e5fc9ef2d81299f0e04892c]

        tdf#37623: sc: Move UItest to CppUnittest
        
        Change-Id: I0937baf4dc9db222da6ba74d2b9bcea9f18627ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129782
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [eb0a6b48cbd1346bcee92e2e418a454655c10c63]

        tdf#63805: sc: Move UItest to CppUnittest
        
        Change-Id: I8b2192c1944299b92f82cc6179fcdb0842de9803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129779
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [587e3e27171d66470f7216e36ed2967c2a8b3867]

        tdf#126577: sc: move UItest to CppUnittest
        
        it's possible to know the arguments of .uno:FillSeries
        using the macro recorder
        
        Change-Id: I8e459c0ca42bd9cd0226e61b3a0b2107bdc22c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129774
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [5b2a153779b68e8454a66973579512fe17e376d5]

        do not call purge() on string pool too often (tdf#125428)
        
        It turns out svl::SharedStringPool::purge() can be somewhat
        expensive with larger documents. Profiling suggests it's primarily
        the cost of the CPU trying to access the rtl_uString instances
        scattered all over the memory, so it can't be easily optimized.
        So instead delay and compress purge() calls if they come from
        temporary ScDocument instances from undo or clipboard.
        
        Change-Id: Ie26cce113025ff45ee2c473c6b06f684f453b27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129713
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [9db03b879b912d79060ab06f03a54d4a59e6ac65]

        i18npool: fix wrong static function symbols
        
        I build a full-language WASM build and the WASM linker was
        complaining about mismatching function signatures for
        get_zh_zhuyin and get_zh_pinyin.
        
        Turns out LO has two exported functions with the same name
        but different signatures. For a static build, these collator
        functions are renamed, so they don't clash, and this was
        silently calling the wrong functions from
        i18npool/source/indexentry.
        
        Change-Id: I6afe1c3a289dfccea5a5fec41a9a6db37f4e19bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129741
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-02-10  Henry Castro  <hcastro@collabora.com>  [7e7ae7ef1dd4d9c9c84ee0b96cb96f456c8da48e]

        lok: introduce local mouse tracking
        
        Add the term local mouse tracking per frame window (per user)
        instead of global mouse tracking in the desktop case.
        
        Change-Id: I3f8c55fc770b4ac7dea167385586d8639ac4d93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118856
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117777
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [8bb457d17ef970676f60976cc4e2de9c9f5340c0]

        dynamic logarithmic columns in ScBroadcastAreaSlotMachine
        
        The rows have been handled this way for quite a while, but column
        were still using a linear distribution for a hardcoded column limit.
        Sheets with >1024 columns didn't work because of the hardcoded limit.
        
        Normal sheets use 57344 slots and 6 distributions (ScSlotData),
        and this commit doesn't change that. For huge sheets the original
        broken implementation used 90112/10 and this changes to 270336/50
        (there are now 5 ScSlotData horizontally instead of just one).
        Given that the number of cells is 256x larger I find this acceptable.
        
        Change-Id: I619b979f1363b5427d270f9ca0728415d58f41b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129678
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [a6eddceda5d376cd73922123a3bb3a5683307c41]

        rename some SID to FN_PARAM
        
        because they are not slots, they are only being used as parameters
        
        Change-Id: I539f4832b884d1ea7dc14ce4ef6c79feec6681cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129732
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1c9071dd5f578c5773abc00553d2099cad30ced]

        crashtesting ooo#ooo83229-2
        
        this reverts part of
          commit b314b5a0612c9dc7279039dae44a250d4d3ec6b1
          use more concrete types in chart2, DataSeries
        since writer uses it's own implementation of the XLabeledDataSequence
        UNO interface
        
        Change-Id: I52154dcee104ca17bfa63a3a8b11ef739cef147f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129772
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [967900354d36de50eff76e9622b0b4655d450f41]

        simplify the template makefiles
        
        can later be combined further, the process is the same/no real need for
        separate makefile rules
        
        Change-Id: Ic04acc4084605382147fa43a905fe559f9197d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129726
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-02-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3cc082dd61c3bb47792e6784e2e196b014ecd806]

        simplify autotextuser makefile
        
        could be made static, but left as pattern based since the rules could be
        combined with the other makefiles/there's no real need to treat building
        the user using separate makefile rules, it's the same procedure for both
        shared and user variant.
        
        Change-Id: Ic1dbbcf4dfd8f533d215cc930cc455f95658db1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129725
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-02-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f5ce765d560aaa6ac6c5a92048432dd1e6e8f851]

        simplify autotextshare makefile/only build what's packaged
        
        The multiple indirections/complex nested constructs don't really provide
        any benefit here, they certainly don't make the makefile easier to read.
        
        It was building the autotext .bau files for all languages, despite being
        packaged only for the requested UI langauges (via AllLagPackage) and the
        long list of autotext files was duplicated (even if all .bau files
        should be built, the list could be reused from the other makefile)
        
        Also remove the empty mimetype files and just touch them instead of
        copying them.
        
        The xml, mimetype and other files are now intermediates and are removed by
        make once the .bau is built. (if that's not desired, they can be flagged as
        .SECONDARY)
        
        The list of individual files (3.6k lines) could also be cut down if
        using e.g. make's wildcard function
        
        Change-Id: I223a49d26d1de1435d62a68a04b3713278a8320c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129696
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-02-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a378b130c390423c22999db0841ad1fcf10b4e5c]

        simplify autocorrect makefile
        
        The multiple indirections/complex nested constructs don't really provide
        any benefit here, they certainly don't make the makefile easier to read.
        
        Also remove the empty mimetype files and just touch them instead of
        copying them.
        
        The xml and mimetype files are now intermediates and are removed by make
        once the .dat is built. (if that's not desired, they can be flagged as
        .SECONDARY)
        
        Further simplification is possible when using the same language code
        for both the intermediate directory as well as the source directory
        layout and the .dat files
        
        Change-Id: I0e0c28abcad2b404a88d1f32b9b9cdb53b4125c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129628
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-02-10  Justin Luth  <justin_luth@sil.org>  [bda200a5e9c4592bd61b7924fa171ec3265bfd24]

        tdf#113785 sc: IsDataFiltered must be normalized
        
        I can't believe this hasn't caused major issues
        and has survived as a bug for so long.
        
        Due to the way IsDataFiltered is coded,
        it is required that the range is normalized
        in order to get any kind of meaningful result,
        so lets ensure that.
        
        Change-Id: I2ede77f738fbaeb05a0f1425a2e88e59fca08e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129735
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c0aa970650ffc7c749e0b5ea655ebb2d137c8ae]

        add more TypedWhichId
        
        Change-Id: I6401dcf2507ac53a71dbe4de4ba774aed905961e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Jean-Pierre Ledure  <jp@ledure.be>  [3e340d3f7b73c8577e58c561a34c2b826e77da51]

        ScriptForge - (SF_Utils) review optional argument of _Repr()
        
        As from LO 7.3, optional missing arguments must not be used
        in assignments and comparisons.
        The Basic interpreter tolerated it before 7.3.
        
        Probable commit having changed Basic behaviour:
            https://gerrit.libreoffice.org/c/core/+/121794
        
        A unique case of this singularity was found in the
            SF_Utils._Repr()
        method.
        
        The bad consequence was that the commonly used
            SF_Exception.DebugPrint()
        method calls above method. This broke in fact
        the whole ScriptForge library.
        
        Change-Id: Iba8792b92c73c992429de4382bd8a3dc4b58a94f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129728
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [cecf2082df0427babc491dfad10f6e15e0ec7583]

        do not use /arch:SSE with MSVC
        
        It looks like I missed this one when making SSE2 our MSVC baseline
        in 75edcfc0569ca76fa22db451fd61138e52870a62 .
        
        Change-Id: Iec8dd1522187a32ed379d387439ee01074a624ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129722
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [73cfd7eeac7031c97a57bba82677f36ef1eff731]

        avoid destructing many unique_ptr's most of which are nullptr
        
        With huge sheets there are so many CellInfo structures that
        calling all the destructors actually shows up in profiler data
        while trying to scroll around (it allocates CellInfo for every
        column starting from 0 up to the last one wanted). Keep
        the owning pointers in a vector that'll be much faster to process.
        
        Change-Id: Ibadb05fcce467fb808c38e2ed9a13b4cfef3720e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129699
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Luboš Luňák  <l.lunak@collabora.com>  [d48e68407931fc33044aa7f3fc9e971897fac610]

        clean up accessing CellInfo array in RowInfo
        
        The array allocates one extra item before and after, which means
        all indexing must add 1 to column number. And a lot of the code
        uses array index variables instead of column numbers, which
        makes it confusing whether the value is +1 or not. To sort this
        out, hide the array inside RowInfo and provide access functions
        that will hide those +1 from caller code, plus it will do error
        checking.
        
        Change-Id: Ia91bd76e15fc6c96c09f27c742d71001f4c4151c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129698
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-10  Justin Luth  <justin_luth@sil.org>  [98ecef56d0f87cd922ca560fead4e2533b30d57c]

        tdf#79186 ww8export: save LayoutInCell property
        
        This property was saved in DOCX, but not in DOC format.
        The field can hold 16 values, even though we only handle
        this one on import.
        
        This patch depends on the previous patch which re-worked
        the import side to default to "true".
        
        Since the default is to LayoutInCell, I don't see
        any reason to add this property when true.
        The only reason would be if this property can be
        inherited from somewhere else, and a true needs
        to override the inheritance, but I'm not aware
        that such an inheritance exists in this case.
        
        Change-Id: If42f7b1dc49c69a69552e841b93576f638b6d1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129658
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-10  Miklos Vajna  <vmiklos@collabora.com>  [a227efdbc9128f6a3038b4cb0ae4cb87f20bb7d0]

        sw: document SwDropPortion
        
        It does not drop anything, it's about initials.
        
        Change-Id: Ibb71870a73ff4bc8695e67ffc44c5893c318b9cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129739
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-10  Yunusemre Şentürk  <yunusemre@collabora.com>  [b7aea47561fa0e1b4c8015419a3c64bed13309e7]

        Remove interactivity of asking permission when make distclean
        
        Change-Id: I8cce598b96b1339afeb40679375a2f0a60ca4d9c
        Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129719
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-10  Jim Raykowski  <raykowj@gmail.com>  [fb307b3ac5962a1550219671df8ff1493d3c7cd1]

        SwNavigator: rework entry reselection in Display function
        
        Eliminates duplicate code for entry reselection in the
        SwContentTree::Display function. Behavior change: Pre-patch, when there
        is no selected entry the first entry is selected. With this patch, no
        entry is reselected in this case.
        
        Change-Id: Ief54961c27336f6b46cc0b2bb8dd76dd2c5890ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129188
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-10  Jim Raykowski  <raykowj@gmail.com>  [bc4ed9e69c99ade94e2f156e1719e386b9765f32]

        SwNavigator: absorb lcl_InsertURLFieldContent function
        
        lcl_InsertURLFieldContent was done in commit
        6fcb52aa3d8b8f3686ba1dfae03f9d3cc281b5d3 to group common code. Since
        commit 3771a81060f9e1f60ada37c3b7fa0a51b3042952 it is now only used in
        one place.
        
        Change-Id: I0cba0765e011f1bb5183209d2530b96711f4d95a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129394
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-10  Noel Grandin  <noelgrandin@gmail.com>  [5dfe561cffe6e2a41a76ee78244b16bdb80b0892]

        use more concrete types in chart2, SvxShape
        
        Change-Id: Ieadcd95d7d75d925b2c5528ba231d4686d4fcb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Noel Grandin  <noelgrandin@gmail.com>  [5477193c9ca425509d529fb20dcb0db6a66b5d08]

        use more concrete types in chart2, SvxShape
        
        Change-Id: I9ae954f8efaec31d5b848c633e66adb62a13f3f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129737
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Noel Grandin  <noelgrandin@gmail.com>  [d1568521a0205ca557d7c4bb488d5a8ccc72c442]

        can avoid UNO_QUERY here
        
        Change-Id: Ie43759ab2771a40a0553eb61847766932cac2e47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-10  Jim Raykowski  <raykowj@gmail.com>  [a2ee79c90a6d158e642ad1ac404e5ccd87d27f76]

        SwNavigator: test if member count has changed
        
        In the HasContentChanged function, make the comment "FillMemberList
        tests if member count in old member array equals member count in new
        member array" honest.
        
        Change-Id: I88ee65bb4ed0c56930b8d5ee968ed6c5abb8d841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129393
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5cd672ee291f47ff0f5ea9cba828639a41ae40a7]

        Fixed function name
        
        It passed "make check"
        
        Change-Id: I0828ea2c2531cb970f32581333776f02a46a8d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129314
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-10  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [ea3b18ad18829db26cc32a320af992a1e760d28d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6097a00383b743f7b48da4ec0bd91a0677012bf2
          - Improve recently introduced strings
            
            Change-Id: I917d61ce5450f5e404c4c01de7f737900f69b1c4
            
2022-02-09  Hossein  <hossein@libreoffice.org>  [a5c6fbe247ee9f9b2fba828d1360748c3fe4642b]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        The signed loop index variable of type 'int' is converted into
        'size_t' to match the return value of std::size() which is unsigned
        
        Change-Id: I39170c487a46aed0370d987f6ec94949c71509cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129676
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-02-09  Stephan Bergmann  <sbergman@redhat.com>  [134edb2f4a06398e2725628200292b816d79bbb9]

        clang::IfStmt::getCond can return null
        
        ...for C++23 consteval if statements.  (These caused
        CompilerTest_compilerplugins_clang tail fail with
        
        > clang++: include/llvm/Support/Casting.h:104: static bool llvm::isa_impl_cl<clang::DeclRefExpr, const clang::Expr *>::doit(const From *) [To = clang::DeclRefExpr, From = const clang::Expr *]: Assertion `Val && "isa<> used on a null pointer"' failed.
        
        assertions.)
        
        Change-Id: I095469c8327f91107110e5ed426b95bb41ae26b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129740
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-09  László Németh  <nemeth@numbertext.org>  [23846867ea32667ccf328c36142394dd6aaee8ba]

        tdf#147182 sw: accept/reject all changes of a table selection
        
        Selecting multiple cells of a text table which contain
        tracked text changes, and choosing Accept Track Change/Reject
        Track Change, only text changes of the first cell were
        accepted/rejected (a problem inherited from OOo).
        
        The fix allows to accept/reject also all tracked row
        deletions/insertions in the selected table rows by a single
        click.
        
        Note for manual testing: first cell of the selection should
        still contain a tracked change, otherwise Accept Track Change/
        Reject Track Change menu items/icons aren't active.
        
        Change-Id: I11e71075f4144bba86dda690ec712a24ccf815dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129717
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-09  László Németh  <nemeth@numbertext.org>  [2bb9ad2078e355b71ab25db0c46f3d0bb19cf6d4]

        tdf#147181 tdf#147322 sw: fix drag & drop multiple table rows
        
        With change tracking, moving multiple table rows tracked
        only the first row as deleted, and in the insertion point,
        as inserted.
        
        Without change tracking, only the first row were deleted
        from the original position. This is a regression of tdf#84806
        from commit 5e8aa259e48d5602b932353bb146ebb523982cf2
        "tdf#146967 sw table: fix freezing in Hide Changes mode".
        
        Add unit tests for the change tracking fix and for the original
        table moving fix in commit 7fe64353dc9950e19182a59a486a1ecac27cf98e
        "tdf#84806 Writer: drag and drop selected tables, don't empty".
        
        Change-Id: I43250fcef4bbf482e67a7414f4f655e75d226b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129635
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-09  Caolán McNamara  <caolanm@redhat.com>  [a59952f64c6e78f8e5bad6d6ab8373879f6a826f]

        Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggled
        
        Change-Id: I10a2085e91bb592a8ccea7a50b7188250288e74a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-09  Caolán McNamara  <caolanm@redhat.com>  [5cefbd837a9e41102270d8c60010e3496b76f0a0]

        Related: tdf#132591 connect adjustments to the correct spinbuttons
        
        commit eb807e785b6acda1529b2f58ada2c1e84b38f7f5
        Date:   Fri Feb 19 12:54:21 2021 +0100
        
            Resolves tdf#140511 - UI glitches
        
            Clean-up of nested grids and boxes
        
        removed adjusments 1 to 4
        
        commit dd5039ceea319ebfc72a3e032753b22538add12e
        Date:   Tue Aug 24 11:14:46 2021 +0200
        
            Resolves tdf#143633 - Image size wrong after disabling relative image width
        
            Adjustments added back, missing from 3cbecf3d0d9d68de286589e153ee31f8f709be03
        
        restored them, but added two of them back to different widgets than they
        were originally connected to.
        
        but that's not the problem described in the bug report
        
        Change-Id: I6dcfbf76a6d76ac2f40679a678bcfb384b07d165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-09  Caolán McNamara  <caolanm@redhat.com>  [0a1d94d58d6eff85f6266ea01ae1722217ae0b01]

        Revert "add webloc and url extensions"
        
        This reverts commit e4c3fa614d9be6e32dde49970ace55d9a2b57368.
        
        Reason for revert: there's no evidence that they should be in this list
        
        Change-Id: I8aa5f8a6beaf578feb76684cad5f6a69e17e2b2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129624
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-09  Julien Nabet  <serval2412@yahoo.fr>  [a555aa25bd17781b2828e13ac81456a45387284d]

        tdf#147262: CallByName() argument names does not match that of VBA
        
        Change-Id: I3029b98abbe3b8facf01f0e50a7efdff545c2141
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129646
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [9003593c9e4b8e32dc5b0ae119cc84a14d17f53d]

        Simplify SvGlobalName::GetHexName
        
        Use a single sprintf instead of ten, and don't use interim OStringBuffer
        to convert to OUString in the end.
        
        Change-Id: I5dcbec85d64af3a30b4bb64f12090e5320421013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129734
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [80d00b3eec3a7811c0139afe0ea749cc319ce7b9]

        Fix typo
        
        Change-Id: Ic5e211c4802cedde313d5e03859bb6d3b6be48ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129718
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ff1544883f5daa96a27319a229a7ba94d34e1dda]

        Fix typos
        
        Change-Id: I82405059d900b6605075bf5756f3f0fb99e9002e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129451
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-09  Justin Luth  <justin_luth@sil.org>  [618084819babc839510860b74b36631749093c4c]

        tdf#113785 sc FillAutoSimple: also optimize in negative direction
        
        By only coding the optimization for the downward autofill,
        it totally broke an upward autofill.
        So this patch simply fixes the LO 4.3ish regression
        from commit a995462e6855061816c6529c366f20ace2b45868.
        
        This fix means that the non-hidden cells get the auto-value
        instead of being erased.
        
        However, the hidden cells are still erased
        (which is the topic of tdf#119957).
        
        I'm not going to bother with a unit test for this
        portion. If I can solve bug 119957 as well,
        then the unit test for that can cover both situations.
        
        Change-Id: If6320ccf87fa8893ca6766c265b7760cc46ed7d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129723
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [30146dd8052c8c7f701417eecc2ca1e529aa23cc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c82b7b47513c4fee5357365b7bd67003a22d86e0
          - Document method RunCommand in ScriptForge
            
            Change-Id: Iebbf6c521c426d55ffebb48265485c5fa8015390
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129560
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-02-09  Heiko Tietze  <tietze.heiko@gmail.com>  [dd545b5aabb457257de102c0027dfc914e129bfc]

        Resolves tdf#147301 - Disable Hidden Row/Col indicator
        
        Off by default now
        Entry in View menu added to easily switch on/off
        
        Change-Id: I138ce90f1d2e3c2337368870803d5aa959116c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129712
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-09  Stephan Bergmann  <sbergman@redhat.com>  [12697a559b89539b03779030f94079a27cb1a12f]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/36da4a90d90eef38f5d02beed427a6dd112b93bb>
        "Merge pull request #178 from JamesBelchamber/file-picker-bookmarks:  Adding
        access to gtk-3.0 config"
        
        Change-Id: Ie491cfa4481251ac55b8ab38a5068272165c12de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129727
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-09  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [6a604a9658dd4a619b9a9e02a8b398386adc1abf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 751aa416e5aa4fdb6faf5be273aa8d999e1630e4
          - Add YouTube consent click
            
            Change-Id: I60d64e1becbc7ea33301d4a8073f0b550998b87d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129716
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [a3e8bacbdb8d50ca5eb4917462cc9806be4879a2]

        Flatten SvGlobalName::MakeId
        
        Change-Id: I5b592162d0fad3e57cfe9ad6d4b2252e7f7596d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129709
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [dce85afb01c74eddb2cec3656fa76867aa131bd1]

        expand out IMPLEMENT_FORWARD_XTYPEPROVIDER3
        
        Change-Id: I31a7452bd8822f13905812e8f3fcd31a0753e0a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-09  Michael Stahl  <michael.stahl@allotropia.de>  [d794c377e503aa7d00dbc6daad0aa32efad9e682]

        (related: tdf#147206) writerfilter: fix another end in...
        
        ...DomainMapper_Impl::PopFieldContext() that probably should use the
        m_aTextAppendStack insert position.
        
        Change-Id: I718d4b745258ca88e8ffec0bff5e5ea95037a312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129686
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-09  Michael Stahl  <michael.stahl@allotropia.de>  [a10a031199b36914ba14705e417efd76dbb0383a]

        gdb: fix SwXTextCursorPrinter
        
        m_pImpl was removed in commit cb0991e32987108d900ec7e8fcd4ce477ebc9fb4
        
        Change-Id: I9ca0cdbca97242ace5243f140ac2e17055b3f718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129685
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-09  Caolán McNamara  <caolanm@redhat.com>  [e4c3fa614d9be6e32dde49970ace55d9a2b57368]

        add webloc and url extensions
        
        Change-Id: I02b959f6bcdff5657525a6fd45d12c31315c1a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129715
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-09  Renwa Hiwa  <renwax23@gmail.com>  [7484c3393dc2216239cdb730983725fe2e08e730]

        Better handling of inetlocs
        
        LIBREOFFICE-39BBF6YM
        
        Change-Id: Iadae856a524a0ccda238785f60c8f3459e7b6157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129714
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-02-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [571be264d9604c3d77036e26812f909655cc0bb2]

        Fix typos
        
        Change-Id: I50e8988c320c0068f7adf4a3429d7639df0cbcd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129596
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-02-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a79e7dc9e8097c199e91288027861e3883e14d1b]

        tdf#146672 - CDbl: skip spaces and tabs at the end of the scanned string
        
        Change-Id: Ib7a4e8c7145b549a5327de23549d39d11f8590cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129648
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-02-09  Michael Stahl  <michael.stahl@allotropia.de>  [9d30e168112bc5c3c7f2dfc029f293c540ebb280]

        tdf#147206 writerfilter: fix end position of hyperlink in ToX
        
        (regression from commit 58a86af36295b4fc1e07c0bd38f74530a2ce0f08)
        
        Change-Id: Ied4c26255b60f4320f38432ef5e2e27882b7a135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129681
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-09  Sinduja Y  <sinduja.code@gmail.com>  [0bc1f4aba10194547a8169eb568cc62e84ec89db]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: I17183f45dfad71cb306c31d4e70d8dcbeda5cb48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129672
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [690e4852809ea21b5fd909298c5fa2a053fa0458]

        Fix copying range when it doesn't contain a number
        
        Copying a range named "aaa" resulted in a new range named "1".
        Now it will be named "aaa2".
        
        Also, when range is named "my_range", the new range is now "my_range2" instead of "my_1".
        
        Change-Id: Ib6356454d70244b76de50816e7902852290c3270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129198
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-02-09  Justin Luth  <justin_luth@sil.org>  [19a5e50955ecc8da7ff5dbdfb9f47352d851ee1d]

        related tdf#79186 filter: value is more than just LayoutInCell
        
        nGroupShapeBooleanProperties contains 16 shape properties
        and 16 flags to indicate whether they are to be used or not.
        Up till now, only fLayoutInCell has been used by LO,
        but it handles far more than that, so lets change the code
        (now that we have the documentation for it)
        to make it clear that this could be useful for further
        compatibility fixes.
        
        There is no need to determine whether the setting
        has been provided or not - since a zero default indicates
        everything in this bit-set should be ignored.
        
        The naming and the if clause in ww8graf.cxx suggests that
        reverse engineering didn't really grasp how this worked,
        so I took the liberty of removing all of that awkwardness,
        and verified that at least several associated document
        from the OOo Apache bugtracker still worked.
        
        ===============================================================
        https://docs.microsoft.com/en-us/openspecs/office_file_formats
        /ms-odraw/a0ae6aa5-16e4-4550-87a2-b8ca180c7fd7
        
        fLayoutInCell (1 bit): A bit that specifies whether this shape
        is displayed inside a table cell. If fUsefLayoutInCell equals 0x0,
        this value MUST be ignored.
        The default value for this property is 0x1.
        
        Change-Id: I82f80123a7419a83737b796f253406576732b6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129657
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-09  Miklos Vajna  <vmiklos@collabora.com>  [69f62aea8bfaa6d80cf9f54bd01e9af6fca0f9bb]

        CppunitTest_sw_ooxmlexport: avoid mustTestImportOf()
        
        Can use CPPUNIT_TEST_FIXTURE() instead.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Id86c3c7129fe3f61351325eda8a6f0b44efd2151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129691
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-09  Noel Grandin  <noelgrandin@gmail.com>  [7c62e59587949344160dd346f7e060577fbc3490]

        use more concrete types in chart2, Axis
        
        Change-Id: Ia47fd6deedd0a1cf6bedc882cb9817206dfa88b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-09  Noel Grandin  <noelgrandin@gmail.com>  [da7e9f8613f66265bc8822519fa60412cd463917]

        use more concrete types in chart2, Axis
        
        Change-Id: Iab742573a18384adbd1a397326ca6f4998b45ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129689
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-09  Noel Grandin  <noelgrandin@gmail.com>  [11c4ec15f13bbcc1b7a85e966519d75e64f62c4a]

        use more concrete types in chart2, Axis
        
        Change-Id: Ia45eac5e63d4937310a52a88c142623274fd4e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-09  Noel Grandin  <noelgrandin@gmail.com>  [6e800111d6daa927564e5f4dba8937bbf56e7b8f]

        use more concrete types in chart2, DataSource
        
        Change-Id: I513491e8d39ee79edf8521d279bd32031cf22a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129687
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-09  Michael Weghorn  <m.weghorn@posteo.de>  [425ff2e7911436cf2a20d5640d87274d2467b7c0]

        sw a11y: Drop custom implementations of std::less
        
        SwFrameFunc's operator() just applied the less-than operator
        which is the same as 'std::less<const SwFrame*>' does.
        The latter is the default for the 'Compare' template argument of a
        'std::map' with key type 'const SwFrame*>' anyway, so
        there's no need to specify any explicitly.
        
        The same applies for 'SwShapeFunc' accordingly.
        
        Change-Id: I2472b38d04dd6d280bfb825d750a6d67c2d9797c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129682
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-02-09  Jeff Huang  <jeff@mail.ossii.com.tw>  [3e5e0c2943e057873952b5394b81dbe6d29ef1e2]

        tdf#146937 Remove "refresh" command from Template Manager
        
        Change-Id: I12b43c10cca455a6885101909327b81940dafb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129584
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2022-02-09  Mike Kaganski  <mike.kaganski@collabora.com>  [4e0ba699ab3ba0294acd2589507b50fab82c98f5]

        Simplify SvGlobalName
        
        Its data only takes 16 bytes, the same as std::string_view on 64-bit
        platforms, which is considered trivial. No need to use cow_wrapper
        that would itself take 8 bytes, and have the performance penalty.
        
        Also reuse the conversion to sequence from comphelper.
        
        Change-Id: I3e3177ea759bf22d099aaa5402559196c5934ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129679
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-09  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [42c5506a9e9ef58efd8193a193464e3b49d481ca]

        docx import: right margin was not respected for para with list
        
        If paragpraph has list defined somewhere in styles and right
        margin defined in current style this margin was overriden with
        older value from parent styles.
        
        Change-Id: Ic0a2e9a1ce5f77b9ef38c549a62f1494c050982c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129595
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [a45f057d9d2bcd28e6b4342bbdf45fec38a43ac1]

        Remove COMPILER_PLUGINS_CXX from distro-configs/Jenkins/linux_clang_dbgutil_64
        
        It had originally been added with e754d0931ca75403647cc16100edd98e7e5ceadb
        "Remove CXXFLAGS_CXX11 from Clang plugin compilation", so "if
        COMPILER_PLUGINS_CXX is not set, simply default it to g++ instead of trying to
        construct an acceptable CLANGCXX value from CXX (which would be Clang).  (The
        problem with using Clang without CXXFLAGS_CXX11 is that Clang, unlike GCC,
        typically defaults to C++03, but building compilerplugins requires C++11 at
        least.  That would cause e.g. the Gerrit/Jenkins linux_clang_dbgutil_64 builds
        to fail---but which also needs COMPILER_PLUGINS_CXX to be explicitly set to 'g++
        -std=c++11' as GCC on those machines is still 4.8.5 defaulting to C++03."  But
        that should no longer be an issue with contemporary Clang, which defaults to >=
        C++11 for quite a while now.
        
        On the other hand, when trying to update the Clang used by
        <https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/> from 5.0.2 to
        12.0.1, and adding
        
        > export COMPILER_PLUGINS_CXX="ccache $LODE_HOME"/opt_private/gcc-7.3.0/bin/g++
        
        to
        <https://git.libreoffice.org/lode/+/refs/heads/master/bin/linux_clang_dbgutil_64.env>
        (where this setting arguably belongs, rather than in
        distro-configs/Jenkins/linux_clang_dbgutil_64, anyway), which is needed
        because that version of Clang (and thus loplugin built against it)
        cannot be built with the baseline CentOS 7 GCC 4.8.5, that setting of
        COMPILER_PLUGINS_CXX got overriden by the one in
        distro-configs/Jenkins/linux_clang_dbgutil_64, and configure failed due to
        
        > configure:21069: checking clang/Basic/SourceLocation.h usability
        > configure:21069: ccache g++ -std=c++11 -c -I/home/tdf/sberg/lode/opt_private/clang-llvmorg-12.0.1/include -std=c++14   -fno-exceptions -fno-rtti -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/\
        > tdf/sberg/lode/packages/llvm-llvmorg-12.0.1.src/clang/include -I/home/tdf/sberg/lode/opt_private/clang-llvmorg-12.0.1/include -std=c++14   -fno-exceptions -fno-rtti -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_L\
        > IMIT_MACROS -I/home/tdf/sberg/lode/packages/llvm-llvmorg-12.0.1.src/clang/include conftest.cpp >&5
        > g++: error: unrecognized command line option '-std=c++14'
        > g++: error: unrecognized command line option '-std=c++14'
        > configure:21069: $? = 1
        
        Change-Id: Ic33b116090f648ef645febb4fbb28ceb6a2a7cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Caolán McNamara  <caolanm@redhat.com>  [50bad83484f7f36c2e43b6df8390ee280fc4d469]

        tdf#147251 can't generally shrink popovers if they don't fit under/over
        
        so instead forget about forcing under/over if it doesn't fit on either
        side and just position so its visible
        
        Change-Id: I529bf0d2bb1a3108a8702792ef067372441c2002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129662
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-08  Henry Castro  <hcastro@collabora.com>  [2f7a0b81f21f7e383808c2e5f5d532cb50b84376]

        lok: introduce Application::LOKHandleMouseEvent
        
        Entry point to call the ImplLOKHandleMouseEvent function
        mainly to process mouse events.
        
        Change-Id: I17513643733bf5990d41ab8cf47cdc322ed526ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118846
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117711
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-08  Julien Nabet  <serval2412@yahoo.fr>  [d8538d7fd693a24c7698ac9dd5447134c0c0f210]

        Drop some methods returning just a string and only used once
        
        Change-Id: Idccc6edea7dabc79135d49ffe69c1a13f2990b76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129684
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-02-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8b500fc1c7a8ccee6a938463d74a570431a1480]

        simplify complex conditional
        
        Change-Id: I56b9aaf752c3ae809a99b2e6897a929f7f4bbe8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129683
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [98d51bf8ce13bdac2d71f50f58d6d0ddb9041a4f]

        speed up SfxItemPool searches with items that can't use IsSortable()
        
        As pointed out by 585e0ac43b9bd8a2f714903034e435c84ae3fc96, some
        item types cannot be used as IsSortable(), because they are modified
        after having been inserted in the pool, which breaks the sorted
        order. But it's possible to at least somewhat improve performance
        of these items by explicitly providing a hash code and using
        that first for comparisons when looking up items, which may be
        cheaper than calling operator==.
        With ScPatternAttr such comparisons seem to take only 60% of the
        original time, reducing loading time of some documents by 25%.
        
        Change-Id: I41f4dda472fb6db066742976672f2c08b9aeef63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129667
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [aaf130beacfda06bcbc305e70030bdf5369e0743]

        CppunitTest_sc_uicalc: give more info when asserting the position
        
        Change-Id: Ia1848f1c985b346742f3858e504b18b5807eb688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129680
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [c7a84ca2f5c526cb28411677981e15a2b757cd37]

        tdf#130094: sw_uiwriter3: Add unittest
        
        Change-Id: Ic04c4241e78541dd4479186a9bf00b23883c1550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129663
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [f6d751971acf295e2567f30f56b529f273f2c05a]

        no need to take copies of the shared_ptr here
        
        and copying shared_ptr is fairly slow
        
        Change-Id: I0bf06056f867494319c087e113b3f77b5a5632c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd2f6282cb898f4a356ea8acf3dd1129f09fc1e1]

        tdf#126319: sd_png_export_tests: Add unittest
        
        Change-Id: I36cdd81fcb70d5383519c22b92a3d6366b719b8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129380
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [cf8408bfcbaca2998d47a56df9f1dc6f3cb98b0e]

        make the large-sheet maxrow value pow2-based and not pow10-based
        
        All the other limits are powers of 2, I see no good reason why
        this one should be 16000000 and not 16777216. Also at least
        ScBroadcastAreaSlotMachine actually requires the values
        to be powers of 2, otherwise the logarithmic algorithm in its
        ctor will miss some rows at the end.
        
        Change-Id: Iee30a271e9e67d092c34d2e4175cb672e6f737a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129588
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Michael Stahl  <michael.stahl@allotropia.de>  [7ac06bdbf8a2b9fed512ae7817131f26f3744898]

        ucb: webdav-curl: fix deadlock in SerfLockStore::refreshLocks()
        
        ... and removeLock()
        
        (regression from commit 03c7cd9bbe3d46bb13a5cf1ad72ba0eaf702747e)
        
        Change-Id: I4029a7079c7331a7a00c11e2bec5639086bcc928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129666
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2022-02-08  Marco Pinto  <marcoagpinto@sapo.pt>  [3671d16e4a03351b235fef6b5ad885fad158066e]

        [pt-PT] Added 43 words to autocorrect
        
        Change-Id: Ie70e27786aedf7e8ec71b08a14b15f07dada060e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128149
        Tested-by: Jenkins
        Tested-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Aron Budea <aron.budea@collabora.com>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [7a6786c570a1550d2353debd508fd31fbac8262b]

        loplugin:nullptr
        
        Change-Id: I134ca6b0e69124739b734dfb49763da4284f7412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129652
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8be929f4cbb2fe16a366ef146be29955715fa2f]

        tdf#116685: sw: Add UItest
        
        Change-Id: I94d9adb86662e67e0334e9777721b4117b3b9c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129664
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b8fbd7256c2487251fdfa811e5c67b2a21e7984]

        uitest: no need to have a document with a table, just create it
        
        Change-Id: I06b9d5cb18379ef6fb144817db857bd36902812e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129665
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Miklos Vajna  <vmiklos@collabora.com>  [4df75c2a2f9abbf2621a9aacd0c4f9fe8841b051]

        sw: fix size of inserted PDF image
        
        We used to multiply the pixel size with the DPI, which resulted in some
        large enough mm100 width that the inserted image was as wide as the body
        frame allowed it.
        
        Change-Id: I97b81f23166889006363b9241a572f6afde99ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129640
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-08  Caolán McNamara  <caolanm@redhat.com>  [dbf92d1825bed9f79925f232a5be7cd9f3a330f3]

        drop checksum assert that is platform dependent
        
        Change-Id: I3459d753a8f655ca34ecf6c25fdfd9655687c6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-08  Caolán McNamara  <caolanm@redhat.com>  [77919edd1fe447d9574ff3636e036d6459cf445a]

        cid#1497933 suppress Macro compares unsigned to 0
        
        Change-Id: I7f06f889f2bd687028c00d79bdcf9e2edacc5c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [545622887c55e935be2bb482b838a8fb84a84298]

        optimize ScViewData::GetScrPos() for many hidden rows/columns
        
        With huge sheets checking width of each column may be expensive,
        and hidden columns have width 0, so if the rest of the columns
        in a row are hidden, this would check them all. Skip hidden
        ones at once.
        
        Change-Id: I16308e53ce579837fc7e2384919f6cfe04e26c7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129647
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [d20598d14a95675a436736679ab4a82a8cc3a703]

        optimize ScTabView::SkipCursorVertical() for many hidden rows
        
        The code skips all hidden rows, and it does so one by one, until
        it encounters the last row, and then it reverses and goes back.
        With a huge sheet it may spend a noticeable time doing this.
        Since the RowHidden() function gives a range, use that to skip
        hidden rows faster.
        
        Change-Id: I14a990d288d28e9cab69d7dcc7f0dc9210434859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129643
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [cd50d33fc4af3f2d4ab40de98ecf02f0d832d750]

        MAXCOL/MAXROW -> ScSheetLimits in fillinfo.cxx
        
        Change-Id: I71b3f8984737e87e8413c21b016425beb6a7d21a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129637
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [03f225039b366f075b23a074e63edc6a47b12d3c]

        if these are row/column numbers, then no need to use sal_uLong
        
        Change-Id: I7c9dd795961f8756fe932df910a3fe6272b3211f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129631
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Luboš Luňák  <l.lunak@collabora.com>  [fd4384c59eefc8f34d5fe90929d7cb44ee15b27f]

        avoid overflows in ScFlatUInt16RowSegments
        
        Loading a document with >1024 columns caused overflow warnings.
        
        Change-Id: I723185eadf0ed1e806c9fd693ed35dc47d8c2135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129632
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-08  Henry Castro  <hcastro@collabora.com>  [abc32f115ffd8df20ed122f6a769027b68da13f2]

        ucb: webdav: fix "__lll_lock_wait () "
        
        0  0x00007ffff74bc29c in __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:103
        1  0x00007ffff74b5714 in __GI___pthread_mutex_lock (mutex=0x7fffbfad04c0 <(anonymous namespace)::g_Init>)
            at ../nptl/pthread_mutex_lock.c:80
        2  0x00007fffbf996ed2 in __gthread_mutex_lock(__gthread_mutex_t*) (__mutex=0x7fffbfad04c0 <(anonymous namespace)::g_Init>)
            at /usr/include/x86_64-linux-gnu/c++/8/bits/gthr-default.h:748
        3  0x00007fffbf9b0b56 in std::mutex::lock() (this=0x7fffbfad04c0 <(anonymous namespace)::g_Init>)
            at /usr/include/c++/8/bits/std_mutex.h:103
        4  0x00007fffbf9b69dd in std::unique_lock<std::mutex>::lock() (this=0x7fffffff97e0)
            at /usr/include/c++/8/bits/std_mutex.h:267
        5  0x00007fffbf9e0878 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7fffffff97e0, __m=...)
            at /usr/include/c++/8/bits/std_mutex.h:197
        6  0x00007fffbf9f01e7 in http_dav_ucp::SerfLockStore::startTicker() (this=0x7fffbfad04c0 <(anonymous namespace)::g_Init>)  at /home/hcastro/projects/online/lib/core/sid/ucb/source/ucp/webdav-curl/SerfLockStore.cxx:107
        7  0x00007fffbf9f0728 in http_dav_ucp::SerfLockStore::addLock(rtl::OUString const&, com::sun::star::ucb::Lock const&, rtl::OUString const&, rtl::Reference<http_dav_ucp::CurlSession> const&, int)
        
        Change-Id: I01d3c1f67281ceab38e0452ba9cc714d4aacdbcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129447
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [6f654837ac9f6d3b3ade85f44cad92d3dc2af42e]

        loplugin:external (clang-cl)
        
        > vcl/source/app/salplug.cxx(440,6): error: externally available entity 'HasAtHook' is not previously declared in an included file (if it is only used in this translation unit, make it static; otherwise, provide a declaration of it in an included file) [loplugin:external]
        > bool HasAtHook()
        > ~~~~~^~~~~~~~~~~
        
        Change-Id: I8e293fa53ad0324d2cac4195145dad536e699c47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129653
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [81b89ed0099696e881ef21f15d7f3a416d85cd8e]

        external/libwebp: Support clang-cl
        
        ...fixing
        
        > Makefile.vc(18) : fatal error U1050: Unable to auto-detect toolchain architecture! If cl.exe is in your PATH rerun nmake with ARCH=<arch>.
        
        because workdir/UnpackedTarball/libwebp/Makefile.vc naively relies on cl.exe-
        specific output details in
        
        > !IFNDEF ARCH
        > !IF ! [ $(CC) 2>&1 | grep -q "x86" > NUL ]
        > ARCH = x86
        > !ELSE IF ! [ $(CC) 2>&1 | grep -q "x64" > NUL ]
        > ARCH = x64
        > !ELSE IF ! [ $(CC) 2>&1 | grep -q "ARM" > NUL ]
        > ARCH = ARM
        > !ELSE
        > !ERROR Unable to auto-detect toolchain architecture! \
        > If cl.exe is in your PATH rerun nmake with ARCH=<arch>.
        > !ENDIF
        > !ENDIF
        
        Change-Id: I376295fc75d6ab19773e53dbb607d3b156fbe948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129655
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [aea216e2527f37970654a7160eab57d097cbd0f5]

        Avoid -Werror,-Wunused-variable also with clang-cl
        
        Change-Id: Iebf3a95bb104eeff641fbeaa14c620f84b1047f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129654
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Stephan Bergmann  <sbergman@redhat.com>  [b01e0483ee14826057c42dfa58c3d6200a474791]

        Extend loplugin:stringview to O[U]StringBuffer::toString
        
        Change-Id: I7ad212dfff8b34d05e3b45107a1ef033a4efc454
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129651
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-08  Noel Grandin  <noelgrandin@gmail.com>  [b314b5a0612c9dc7279039dae44a250d4d3ec6b1]

        use more concrete types in chart2, DataSeries
        
        Change-Id: I80bc8961832a20c29b31f7618b9d2609f15ab3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129642
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [d4d16e26a7deb5bfddc9736b4cc9e87c5f6704ee]

        tdf#146462: sw: Add UItest
        
        Change-Id: Ifae155b3d6c727403d395c28842b3aea36b92b49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129633
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b36aec3abca0da7222e126fa46dd2b4387e240f]

        uitest: simplify sample file
        
        Submitted by mistake in 9d02b1edafd44b75a8996a97c329fdd4967e8f54
        < tdf#96499: sc: Add UItest >
        
        Change-Id: Idae2b5d7b51022439289ab6c870b47860feaa388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129645
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d762c146a79b5971541aa22217541c8aac017a4]

        add template versions of SwContentNode::GetAttr
        
        Change-Id: I62c0d54c9e1dc89c5684210075219c1eeee9f942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-08  Miklos Vajna  <vmiklos@collabora.com>  [ce8b6f3426e55b6d09a52eb4a7d17614fc1a6c15]

        RTF paste: fix cursor creation on shapes
        
        This went wrong in commit 232ad2f2588beff50cb5c1f3b689c581ba317583 (API
        CHANGE: add a "position" parameter to XParagraph/TextPortionAppend
        methods, 2012-11-28), the problem is that the text range is part of the
        shape text's node range, so we have to call createTextCursorByRange() on
        the shape's XText, not on the body text.
        
        Change-Id: Ifa97213659130b8c279022a6a03f920dca6061bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129603
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-08  Julien Nabet  <serval2412@yahoo.fr>  [a7c9980a4a6bb1f547c0c4a7b554ac9afe7b25fc]

         Simplify sequence of PropertyValue in linguisting/reportdesign/sc/sfx2
        
        Change-Id: Icd19a46f59e7b4e9ef4062354c5d066382ea8ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129644
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-08  Jim Raykowski  <raykowj@gmail.com>  [6a031514a922dd3c53d96f4d4980e7f8ee598507]

        SwNavigator: factor out m_nMemberCount in FillMemberList
        
        Change-Id: I91464080aa035c841d1c6bfc0bcf4aee1789037d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129392
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-08  Henry Castro  <hcastro@collabora.com>  [845e53ea13b317bd8ef4dc42cd60ea51359f34ab]

        lok: sc: introduce ImplLOKHandleMouseEvent
        
        In tiled rendering case, each user has a View/Controller
        object to interact with a unique document (Model) for
        collaborating purposes. However, in the desktop case a
        unique user has many View/Controller objects to handle a
        unique document, so the user has only one global active focus,
        capture and tracking window object.
        
        In order to handle independent drag & drop for each user,
        it is created ImplLOKHandleMouseEvent.
        
        Change-Id: I735fae9b9858a75f9fedb603798220ab302d65f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118843
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117708
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-07  Stephan Bergmann  <sbergman@redhat.com>  [dcd9e98383c767bbb6014c6ca5fe786579eda08f]

        float-cast-overflow
        
        ...after ea771e85b2302829394df545bb82c02bff2750c2 "Resolves: tdf#146997 use
        sal_Int64 instead of sal_Int32 for spinbutton values" changed the default values
        of pcr::ONumericControl::setMin/MaxValue
        (extensions/source/propctrlr/standardcontrol.cxx) from int to sal_Int64 limits.
        
        With SAL_USE_VCLPLUGIN=gtk3, in Writer creating a "Form - Label" and selecting
        "Control Properties" in its context menu caused
        
        > include/tools/helpers.hxx:75:93: runtime error: 9.22337e+18 is outside the range of representable values of type 'long'
        >  #0 in FRound(double) at include/tools/helpers.hxx:75:93
        >  #1 in (anonymous namespace)::GtkInstanceSpinButton::fromGtk(double) const at vcl/unx/gtk3/gtkinst.cxx:16443:16
        >  #2 in (anonymous namespace)::GtkInstanceSpinButton::get_range(long&, long&) const at vcl/unx/gtk3/gtkinst.cxx:16521:15
        >  #3 in weld::MetricSpinButton::update_width_chars() at vcl/source/window/builder.cxx:258:24
        >  #4 in weld::MetricSpinButton::set_range(long, long, FieldUnit) at include/vcl/weld.hxx:1991:9
        >  #5 in weld::MetricSpinButton::set_min(long, FieldUnit) at include/vcl/weld.hxx:2005:9
        >  #6 in pcr::ONumericControl::setMinValue(com::sun::star::beans::Optional<double> const&) at extensions/source/propctrlr/standardcontrol.cxx:401:38
        
        and similarly for pcr::ONumericControl::setMaxValue:
        
        For one, for fVal = -9223372036854775808 (i.e., -2^63), -fVal + 0.5 (i.e.,
        9223372036854775808.5) was outside the range of 64-bit tools::Long, so rewrite
        the non-positive branch in a simpler way (and I have no idea why it was written
        in the more complex way in the first place).
        
        For another, for fVal = 9223372036854775807 (i.e., 2^63 - 1), fVal + 0.5 (i.e.,
        9223372036854775807.5) cannot be represented as IEEE 754 double exactly and is
        represented as 9223372036854775808, which was similarly outside the range of
        64-bit tools::Long, so treat that limit value specially on the positive branch.
        
        Change-Id: Ic2a553e9ce6319eac591058b1218b29dffaeab2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129638
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-07  Stephan Bergmann  <sbergman@redhat.com>  [a56981e9f1710ae44637fa6a31a37dc40c0c445a]

        float-cast-overflow
        
        ...after ea771e85b2302829394df545bb82c02bff2750c2 "Resolves: tdf#146997 use
        sal_Int64 instead of sal_Int32 for spinbutton values" changed the default value
        of pcr::ONumericControl::setMaxValue
        (extensions/source/propctrlr/standardcontrol.cxx) from int to sal_Int64 max.
        
        For example, UITest_calc_tests9 failed with
        
        > vcl/source/app/salvtables.cxx:5507:12: runtime error: 9.22337e+18 is outside the range of representable values of type 'long'
        >  #0 in SalInstanceSpinButton::fromField(double) const at vcl/source/app/salvtables.cxx:5507:12
        >  #1 in SalInstanceSpinButton::get_range(long&, long&) const at vcl/source/app/salvtables.cxx:5541:11
        >  #2 in weld::MetricSpinButton::update_width_chars() at vcl/source/window/builder.cxx:258:24
        >  #3 in weld::MetricSpinButton::set_range(long, long, FieldUnit) at include/vcl/weld.hxx:1991:9
        >  #4 in weld::MetricSpinButton::set_max(long, FieldUnit) at include/vcl/weld.hxx:2012:9
        >  #5 in pcr::ONumericControl::setMaxValue(com::sun::star::beans::Optional<double> const&) at extensions/source/propctrlr/standardcontrol.cxx:422:38
        
        because std::round(fValue * Power10(get_digits())) = 9223372036854775807 (i.e.,
        2^63 - 1) cannot be represented as IEEE 754 double exactly and is represented as
        9223372036854775808, which was outside the range of sal_Int64, so treat that max
        limit value specially.  (The corresponding min limit value -9223372036854775808
        doesn't have that issue.)
        
        Change-Id: I9ff7a281278a0c66b0b0d49deb0846bcdb91a8fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129639
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-07  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [19bca24486315cc35f873486e6a2dd18394d0614]

        tdf#126287: docx import: use defered linebreak
        
        In some cases when we have combo linebreak, endparagraph and
        end section at very bottom of page, MS Word does ignores linebreak
        to avoid empty page with same section and lonely end paragraph mark.
        
        With defered linebreak we could simulate and ignore such linebreaks
        during import.
        
        Change-Id: Ie6ee4c0990ee1c2e853691a76953c83191664e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119709
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-07  Caolán McNamara  <caolanm@redhat.com>  [2634c1ae4fcaadc92a86976f2f9594773f5f84ec]

        fix big-endian hsql to firebird migration
        
        Change-Id: I047d2366ad80eca701924cb0f66b6b1bcfdcac5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-07  Caolán McNamara  <caolanm@redhat.com>  [a2bda9579e784842bfade539da2dffd61348515a]

        ofz#44471 crash in isMoved if re-insert of invalid range failed
        
        Change-Id: I21a3a3e544c016205d65d7e81889ebfddc7e322d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [9d02b1edafd44b75a8996a97c329fdd4967e8f54]

        tdf#96499: sc: Add UItest
        
        Change-Id: Ie81d5cfd493cb25698b48f406f5eaaa68e14e2e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129604
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [10d453b6dc2f6a9477d28638b67f53f07bd03a02]

        Fix typo in code
        
        Change-Id: I78730afbfdebbd634343741b57718a467f6c9b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129350
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-07  Michael Meeks  <michael.meeks@collabora.com>  [1eab80a0495b2c858a168148bc3a96ab287b5bd2]

        boost / gettext warning improvement.
        
        std::runtime_exception of:
        	"Invalid or unsupported charset:UTF-8 or UTF-8"
        
        is less useful than it could be when spat out from the boost gettext
        impl. Survive for the next (and probably more useful) exception.
        
        Change-Id: Ibeb60b4a34f09f47051844c3e8048f38618d0e05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129566
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-02-07  Luboš Luňák  <l.lunak@collabora.com>  [c24b04707c5b914bda22d709c2da025c784f5045]

        remove pointless BCA_SLOTS_ROW assertions
        
        This is now only used for assertions, but otherwise it's actually
        not used at all. This code is apparently remnants of original
        slots code, which just distributed them linearly in slices. Then
        b3579d71c6536ab1d03 increased sheet size limits and optionally made
        the distribution logarithmic, and then de7e83969b60ab6d78e501
        removed the linear case but didn't remove these assertions.
        
        Change-Id: I6c5a74aa4e060552da3ad1dcc6bbaa21c831a4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129496
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-07  Kevin Suo  <suokunlong@126.com>  [24e6217c0abdaed703a077e77881ad6e8b4f6f0e]

        tdf#77803: Use NATNUM12 and NATNUM4 for Chinese Numberring
        
        For Chinese, format code NATNUM7 and NATNUM8 are "short lower
        case text" and "short upper case text", respectively, see [1].
        We need full lower and full upper here for numbering purpose, not
        "short" form. E.g. for number 100, we need "一百" (lower case)
        and "壹佰" (upper case), rather than "百" which is in short form.
        
        Use NATNUM12 for chinese lower, and NATNUM5 for Chinese upper.
        See bug 147054 for the reason why we do not use NATNUM4 for Chinese lower.
        
        [1] https://help.libreoffice.org/latest/en-US/text/shared/01/05020301.html
        
        Change-Id: I69c93d62f1026117a6d403ade63a9abfbe5c73f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129143
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-02-07  Miklos Vajna  <vmiklos@collabora.com>  [30585873ca8c861aa2d13f85797930f62195ee55]

        PDF export: increase default precision of doubles
        
        Follow-up to commit 50682cea4196819980c8e2d4018f80384097ce6f (PDF
        export: improve precision of pdf image sizes, 2022-02-04), sounds like a
        good idea to do this in general, not only in that specific case that was
        required for the test to pass.
        
        Change-Id: I5b36a5a3be26132e96a4de9d224abcaaf79beadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129599
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [d9ff5556e7b24c7548a476862726b4bd54425047]

        use more concrete types in chart2, DataSeries
        
        Change-Id: If92f6ff6f90d53a9dc6211fd9f071d4d3fce2997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3ff7f9e50bda9e6416d0df5f3b935aae34efbb8f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5e2cb8e64fbd008ab9e1372575f5b96f0f27e728
          - Fix image URL in page
            
            Change-Id: I5b316b0107fa0fbb361de70fceb583082959865d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129605
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-07  Julien Nabet  <serval2412@yahoo.fr>  [ad9aa572594f04d2c498d087fb81b0fb215b8e7d]

        tdf#113191: Add 21 and 42 in size list for CJK for typographic scale convention
        
        Change-Id: I2be3160dbab780254b6f02db8dec69389ec500d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129530
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-07  Caolán McNamara  <caolanm@redhat.com>  [2d21560b780060114c2e9ab95d6a4680a590ab0f]

        sal_uInt8 is typedefed as unsigned char so this casting isn't needed
        
        Change-Id: I190bbcb915664ed0cf803814c399b841ae41c519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129594
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [04c0a05f58618f53e1be83856ebc2b615066391a]

        tdf#74577 tdf#92960: sc: Add UItest
        
        Change-Id: I52ef2bbaf6de6dc1b8c823a17ef99f117ef1f6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129589
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1272f775704057119c81ba370a9097201e1e86e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 03b9f426c60e045d5ba6eca701d3dad66e1344e0
          - Fix typos and mute l10n in some Help pages
            
            Change-Id: I1520155dd72e11a2158e3893a7771a3879ec5a66
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129564
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-07  Henry Castro  <hcastro@collabora.com>  [a2264fb76a29809a0bcc0ffc9c87c1cd2ee1ebe6]

        lok: add 'dropdown' dialog type
        
        The position of the dropdwon is absolute to screen so
        add this type so we can transform correct position on the client side.
        
        Change-Id: I9e2faeb532e313a1a4043d4044f71ada2e7225a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127439
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129459
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-07  Caolán McNamara  <caolanm@redhat.com>  [6fa736d1baac1114c042c8c8333c77cf5846439f]

        upgrade harfbuzz to 3.2.2
        
        note 3.2.1 causes CppunitTest_sd_layout_tests to fail
        
        Change-Id: If03d884040bb2261e1a96241b3933b97fb8a8614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-07  Dr. David Alan Gilbert  <dave@treblig.org>  [2a57ef5512a018bfcfac85a8cd63f2e528f7cdca]

        pdfwriter: Check URIs exported
        
        Check the URIs that are exported.
        
        Change-Id: I2d8b00f767a61c5abdb9163701fe497bb258c790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125203
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [372f5902200b46edd794c865f6d316a4a32d9cc6]

        crashtesting ooo#20372
        
        this reverts parts of the "use more concrete types in chart2,
        LabeledDataSequence" commits, since writer uses it's own implementation
        of the XLabeledDataSequence UNO interface
        
        Change-Id: Icc2c5e9a38f789cddd9fbca63301397ce759fbff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129587
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-07  Justin Luth  <justin_luth@sil.org>  [32c946c064cc2889bda2f46c1862e5100f0a257a]

        tdf#145868 sd replace: if search changes, restart find/replace
        
        REPLACE is really a replaceAndFind instead of a findAndReplace.
        Thus, when you changed your search parameter and did a replace,
        it replaced the previously searched for item, and then found the
        first instance of the new search parameter.
        That of course is just wrong.
        
        So make sure to verify that the previous search
        matches the current search competely.
        However, that doesn't mean that the entire searchItem matches,
        since we don't want to restart the search just
        because the replace parameter changed.
        
        In my testing, this wasn't an issue for REPLACE_ALL.
        So the only time we need to worry about the last search
        result is in a replace once situation.
        
        P.S. This commit exposed that mpSearchItem can point
        to a destructed SvxSearchItem, so this patches unit test
        will crash if the other 7.4 commit is missing.
        
        Change-Id: I7be14d64534018718145c6ac5f8629ff5f2e5611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129385
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-07  Jean-Pierre Ledure  <jp@ledure.be>  [b52016e5d065ca3fe77ec3c02090ea4b2b3e1ba5]

        ScriptForge - (SF_Platform,SF_FileSystem) Manage extensions
        
        New properties and methods
        --------------------------
        
        SF_Platform.Extensions : (property)
           provide a list of the installed extensions
           as an array of strings
        
        SF_FileSystem.ExtensionFolder(Extension as string) : (method)
           provides the location in FileNaming notation of the
           folder where the given extension is installed
        
        The SF_FileSystem.ExtensionsFolder (notice the additional "s")
        is kept as a property providing the folder containing the
        extensions installed by the user.
        
        All methods and properties are available with an identical
        syntax and semantics both from Basic and Python scripts.
        
        The difference between a propert or a method is
        irrelevant for Basic but is essential in Python:
        a property must not have brackets, a method must have them.
        Hence the distinction between
           ExtensionFolder being a method requiring an argument
           ExtensionsFolder being a property without argument
        
        Change-Id: Idd18a5624f4abd84095d146e467e8fdcf497bd0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129572
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-07  Miklos Vajna  <vmiklos@collabora.com>  [e893606068a82c84103b1466a5eb92e2bd415b4b]

        filter: avoid 'using namespace' in pdfexport.hxx
        
        Helps to see if we have an rtl::Reference or an uno::Reference here.
        
        Change-Id: I5b8c42fbf01a026d637b1aaec299cae51673188a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129585
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-07  Szymon Kłos  <szymon.klos@collabora.com>  [cf5b0d5972b02809e9b7f35780885445242b3f12]

        RTL: lok: render correctly interim windows
        
        Change-Id: Iec23fba24464c6d29ecb63d3d2018ded8d9937f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129495
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-07  Julien Nabet  <serval2412@yahoo.fr>  [6dcd73f505eca7d0ea31555564855dd4cd0813b4]

         Simplify sequence of PropertyValue in forms
        
        Change-Id: Iab1af5c8d8d824ef2a4be471395f174cadabfc1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129583
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-07  Julien Nabet  <serval2412@yahoo.fr>  [ed652a6af731c5cd024c245013923717b7764a60]

        Simplify sequences uses in sw (2)
        
        Change-Id: Ic4b3136414d778990e179e36162ca61327cb13f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129578
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-07  Mike Kaganski  <mike.kaganski@collabora.com>  [76fa8d13c5244cf8b1f573e849f4cd2d2347a128]

        Simplify the code a bit
        
        Change-Id: I9c35a32dcb877634d885b64ee56099fb8f314a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129559
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [8b327cd86d71d71d2f5f883321e5d53e3b42ed4e]

        tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro
        
        Change-Id: I4f5258ca5b37e9b1b4237c5d29e4a9e5362fa855
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129116
        Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-02-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6bbc2eba29389bf7937ab5fd08b62821cbd56a97]

        Fix typo in code
        
        Change-Id: I1c5350ab5e039b80ebc36922a66da7f0083162a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129450
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [1c635de6ed48dec4566341c174351432ddab757d]

        Avoid excessive reallocations
        
        Change-Id: I68ff7021c26dd2148f85506fd0c67e233753c63a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129558
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Johnny_M  <klasse@partyheld.de>  [68aa3222b1b7953f2b5eb419ea3bec871091e574]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cd6e1e0360f3bef1879d717be450d6ec27e3f38
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: I68c7f378b8edea60771ae25829f618e6598955a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129577
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Johnny_M  <klasse@partyheld.de>  [46e20f95bc459add5c2f4cc2daef112ff768535e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 75d8c2b3a2233265040c08483d5e889916b8616a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie93feb7f23ef7f83d72f59c1ae0706de60e3f426
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129576
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Johnny_M  <klasse@partyheld.de>  [8cd3565cfed84d517d0839d96a620423ab02b9cc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 507676ac005119b4e006fd3fa4c1dd57ab9a191f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I118f997877d52531f12f977a9038c47dade422ac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129574
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Johnny_M  <klasse@partyheld.de>  [37d72723edbbc70e85751c707a2407110a0a4b5d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23bf50f5437f38debeaff483b662c7be552fdda5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3cb1e4b7aa824cd5229168ddaad4064330802d46
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129575
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Johnny_M  <klasse@partyheld.de>  [db9a9c20bb5b6d93fb88f72749fa73abddb754d4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d56c38aa1dd32984760c2bd4c09631230fb28d1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I32148f7c65f9bb62c76ec8da657d88e76312f275
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129573
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Johnny_M  <klasse@partyheld.de>  [2bdcb898e4640e7cc8c1937bea83384195cbe25f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00a6d094b561c8155047ea68f85d7477a296c782
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iabf5d2f5dd8c00621eb180a5d608eff7526f2ea3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129515
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8912058eb3af906f354779fff19f46c3530148a2]

        Fix typo
        
        Change-Id: I7ce6c8dec7cc6b441e2767911b6da99fa348926c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129537
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Stephan Bergmann  <sbergman@redhat.com>  [5b9a7d2251a844bb5bef2b5a187518c0c0f59c26]

        Missing initialization of SVGActionWriter::mbIsPreview
        
        ...introduced with f609a16a52f1ac37f1edd297cf1d9e5f2a294724 "lok: render image
        preview with lower resolution",
        
        > /filter/source/svg/svgwriter.cxx:2949:9: runtime error: load of value 190, which is not a valid value for type 'bool'
        >     #0 0x2b2ee3c573d5 in SVGActionWriter::ImplWriteBmp(BitmapEx const&, Point const&, Size const&, Point const&, Size const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*) /filter/source/svg/svgwriter.cxx:2949:9
        >     #1 0x2b2ee3c3b670 in SVGActionWriter::ImplWriteActions(GDIMetaFile const&, unsigned int, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*, GDIMetaFile const*) /filter/source/svg/svgwriter.cxx:3782:25
        >     #2 0x2b2ee3c5b3a8 in SVGActionWriter::WriteMetaFile(Point const&, Size const&, GDIMetaFile const&, unsigned int, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const*, GDIMetaFile const*) /filter/source/svg/svgwriter.cxx:4015:5
        >     #3 0x2b2ee3a86ae2 in SVGFilter::implExportShape(com::sun::star::uno::Reference<com::sun::star::drawing::XShape> const&, bool) /filter/source/svg/svgexport.cxx:2227:42
        >     #4 0x2b2ee3a7e1e2 in SVGFilter::implExportShapes(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const&, bool) /filter/source/svg/svgexport.cxx:2050:20
        
        during CppunitTest_sd_svg_export_tests
        (<https://ci.libreoffice.org/job/lo_ubsan/2291/>)
        
        Change-Id: Ied5a2cc8599466949f57caae05f9fb90c92266b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129582
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [64c0569d8d1328091e1dfbd76afd86a3664a0da7]

        Simplify sequence of PropertyValue in cui/editeng/extensions
        
        Change-Id: I0c8f46d2671f3623ff3dd1ee6ec84cde7db41003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129580
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [049bc1e7d7ca44767dc826fdda161e01306bf17b]

        No need to call makeStringAndClear to pass a string view
        
        Change-Id: Id9e18e66f3b3c583d7cb22ee0a5d6272ca2f7ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129556
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [fdc7a587275adcf06866d954d4da4116c8717723]

        We know the length here
        
        Change-Id: I0b8898551ac964711250832057af61e3064ef0c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129554
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [a8818b4d72233e2b600d183605c0c6abcf43b1d3]

        We know the length here
        
        Change-Id: Id201a8e5798230352234d95268d4a6e36c2d1807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129557
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [cbb380e48d60c8ae449b807ec5d68aed0826a996]

        Simplify code a bit
        
        Change-Id: I6f1df008e2b51ff42d058f2c4f37393066798c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129555
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [4aa6a80f001124788593a25c2777c3f6b8f23361]

        No need to call makeStringAndClear to pass a string view
        
        Change-Id: Ic794e91da7a8cc405116104544f02d1b659b753a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129553
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [423174a7830c2cf9333c55872ef3775fabfd6962]

        We know the length here
        
        Change-Id: I45b90c40f062afe950952740901c40fee085ed06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129552
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Caolán McNamara  <caolanm@redhat.com>  [4f533655dd635dab30574c2a3b3915377124bd60]

        this test is endian-dependant
        
        Change-Id: I03c1c926441f80c3741bb7d9231363603d0dbffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129579
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-06  Stephan Bergmann  <sbergman@redhat.com>  [e15c04f16fa28aa70de7de1e10d57fd03ab0b2d4]

        Avoid signed-integer-overflow
        
        ...as seen during e.g. UITest_calc_tests9 now,
        
        > unotools/source/i18n/localedatawrapper.cxx:1017:17: runtime error: signed integer overflow: -9223372036854775808 * -1 cannot be represented in type 'long'
        >  #0 in LocaleDataWrapper::ImplAddFormatNum(rtl::OUStringBuffer&, long, unsigned short, bool, bool) const at unotools/source/i18n/localedatawrapper.cxx:1017:17
        >  #1 in LocaleDataWrapper::getNum(long, unsigned short, bool, bool) const at unotools/source/i18n/localedatawrapper.cxx:1217:5
        >  #2 in weld::MetricSpinButton::format_number(long) const at vcl/source/window/builder.cxx:306:32
        >  #3 in weld::MetricSpinButton::update_width_chars() at vcl/source/window/builder.cxx:259:61
        >  #4 in weld::MetricSpinButton::set_range(long, long, FieldUnit) at include/vcl/weld.hxx:1991:9
        >  #5 in weld::MetricSpinButton::set_min(long, FieldUnit) at include/vcl/weld.hxx:2005:9
        
        Change-Id: I940e2f1e2e4d42db84d4bb0e7b68086204dc77ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129570
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-06  Caolán McNamara  <caolanm@redhat.com>  [570001ad3a045c9ca25ab06d2ecf1f9e9d9ad939]

        Resolves: tdf#147218 label doesn't have use-underline set
        
        so the _ is shown to the user, not used to add an underline
        
        Change-Id: I2de707a2d1da8d842ef03497f9b8f69d37368f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129531
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-06  Caolán McNamara  <caolanm@redhat.com>  [a1ac293aae7d898190733e55512cc30afef05599]

        intermittent CppunitTest_sc_macros_test failure
        
        seen as:
        
        C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/sc/qa/extras/vba-macro-test.cxx(596) : error : Assertion
        Test name: VBAMacroTest::testVba
        equality assertion failed
        - Expected: OK
        - Actual  : Test Results
        ============
        
         Failed:  : Test change event for Range.Clear set:
         Failed:  : Test change event for Range.ClearContents set:
         Failed:  : Test change event for Range.Replace:
         Failed:  : Test change event for Range.FillRight:
        Tests passed: 4
        Tests failed: 4
        
        - script reported failure in file Ranges-3.xls
        
        Failures !!!
        Run: 39   Failure total: 1   Failures: 1   Errors: 0
        
        try this alternative to see if it makes a difference
        
        Change-Id: Id4675635e5740fdd9e4b199b603223a95a379960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-06  Mike Kaganski  <mike.kaganski@collabora.com>  [5bd55c22c1bd3e4daed48f9c162557dc9161d4ac]

        We know the length here
        
        Change-Id: I630b7fbda7c9ebf578e74260a0d67eea32e9e429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129549
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-06  Caolán McNamara  <caolanm@redhat.com>  [05b067f05c561b1993deeea84a5700805bc9c3a6]

        qt5: crash entering ë with french IM
        
        which for me with french IM enabled on my keyboard is physically
        AltGr+[ (crashes here on trying to underline ¨ with a length of 2)
        then e.
        
        Change-Id: Id59bd84af2ab4d8403b11b1a13efb2bbdb608199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [1d6140b7cc3412340626e5adac70d5c0a9fdbb39]

        Simplify sequence in sc
        
        Change-Id: Ie4e6ce049da370516fbcb0e7f0863fc1c4bf8e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129571
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d0a11f591a57754362bb86c4bb07869bc18e5f75]

        sc: fix	rendering of conditional formatting icon
        
        The bWorksInPixels flag	isn't needed as	it means some rendering
        information is in pixel	instead	of logic, but we render in logic,
        not in pixels as it is falsely assumed.	So don't take into account
        the bWorksInPixels flag	and just render	in pixels when LOKit is
        active.
        
        Change-Id: I3703d459a2d1444c397f2d9e97af9f0d3010d544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129546
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [67cf91ec83a5933b07a87bdeb6ddeb6e1f781dea]

        chart: prefix members of AxisLabelProperties
        
        Change-Id: Ife658e44dc039811d61b45f4712635920f5c34b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129545
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-06  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [b0011dd5b23d926b3a0d62af7d0c1133ecbe580c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f1051e47fa1e496ec6492725698cd7005d60412e
          - Correction to Basic example
            
            Change-Id: Ib15ce21cdbcd2434f051fd62c9a2a73977d2f36a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129438
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [91bbb6522de9925c74ea99272e5153b882266bde]

        Typo in a comment of EmbedVerbs.idl
        
        Just wonder if shouldn't copy-paste description from:
        https://docs.microsoft.com/en-us/dotnet/api/microsoft.office.interop.word.wdoleverb?view=word-pia
        
        Wonder too why we use "MS_OLEVERB_IPACTIVATE" instead of "MS_OLEVERB_INPLACEACTIVATE"
        but now it's too late to change this since it's a public API
        
        Change-Id: Ie782da22f4ea3d1af31026644d09a6e566b388fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129569
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [8b465a740b69e6c7108dd72d6b1bb74c11a6e06f]

        Simplify sequence in cui
        
        Change-Id: I47e6e6bd2743a380bb316612230bd1e968ed7084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129568
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [fadc0932d7959a872152905d4ec27cd85c3aa19d]

        Simplify sequence in sfx2
        
        Change-Id: If7a22560280eae15dc0c82e3a4521b2c28d65e9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129567
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Eike Rathke  <erack@redhat.com>  [8a9b870a40c41c7cae6e43452b593804fa17f831]

        Resolves: tdf#74577 tdf#92960 Create missing offsets in very outer table
        
        ... if local table is outer table.
        
        Change-Id: I5996609264f4ad9efa8d76a8d0ab730bf1dded24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129540
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-02-06  Julien Nabet  <serval2412@yahoo.fr>  [a7bdfd979470a842712f6475590bbda7542c4ccc]

        Simplify sequences uses in sw
        
        Change-Id: I23358cc037656181d71ded4f7e53435e767166bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129543
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-06  Dennis Francis  <dennis.francis@collabora.com>  [69ef42fedda05b2eca65883ebc8e2db4c5811001]

        svx-lok: incomplete invalidation when resizing/deleting...
        
        shapes in writer. The problematic commit is
        
        5e37acbaaa0b0891829907331ecacd2d3b67526d
        lokCalcRTL: shapes: do not send negative(X) invalidations
        
        The above change forced the lok mode to use the second branch hence avoid the
        view-transformation based invalidation. This patch restores the old
        branching condition, but do the negation of invalidation rectangle in
        case of lok-calc-rtl mode(IsNegativeX).
        
        Change-Id: I679473f0610d2edabeb6071edbb32a63a436d053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128491
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        (cherry picked from commit 242d2752aa6af2c52affc90e84b58c59c5fa779d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129440
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6ed0ffe9177ff6851e1b1e338dd92f81e7987f57]

        vba: small fixes for GetOpenFilename and documenting structs
        
        Check the XFileDialogSelectedItems is using the expected impl.
        after dynamic_casting.
        
        Rename VbaKeyBinding to VbaMacroKeyAndMethodBinding and document
        the struct.
        
        Change-Id: Ica4b24fed3013c5efa97a14e98bf9bdc2c74b68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129320
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-06  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [c0269fe079f4cefe5a5d98a31e8dda5f60ccb09e]

        Colibre: New large Text Direction icons
        
        Change-Id: Icd69c7b2bd873cdf1ea4547946802347cdd95873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129532
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-05  Caolán McNamara  <caolanm@redhat.com>  [29e66d56d1f5499556fc38e51df76ce9210119fe]

        WaE: storing the address of local variable [-Wdangling-pointer]
        
        this is presumably what was intended
        
        Change-Id: I0c436c1440207140158ae902b17b43549a94d8c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129536
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-05  Caolán McNamara  <caolanm@redhat.com>  [6481fffb1e3aa0f4f75778bd354389a1d39a8f00]

        WaE: angle[1|2] may be used uninitialized [-Wmaybe-uninitialized]
        
        Change-Id: If8771e4c73656d6f6d236d2d530d0ec92c1f5a7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129533
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-05  Julien Nabet  <serval2412@yahoo.fr>  [a7bc3bd919749ff269cc4c7cd19db0def6e466b2]

        tdf#145835: typo in customanimationeffecttab|text_delay_label
        
        Change-Id: Ib3d42ab54ec855af5a922f4dd47cedd96bdf10c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129529
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3ec962799a0fe0e8de5459c1b50da8a64adde046]

        Removed duplicated include
        
        Change-Id: Ia58d5fecbc8d6b580ef1adf5b0c0d30c9269abb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129449
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-02-05  Noel Grandin  <noelgrandin@gmail.com>  [333ccb081b4ab62adce50ca4c93162b9baf984d0]

        use more concrete types in chart2, Axis
        
        Change-Id: If80b6487ad2b8ac75f98f798b839aff2b8a5c23e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129522
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-05  Caolán McNamara  <caolanm@redhat.com>  [1a4955f2c1158197db74d7cf4f1f0c98c096224c]

        this test assumes KacstBook has no Latin glyphs
        
        which is true for the one bundled with LibreOffice but is not
        true for the fedora one (kacst-book-fonts-2.0-26.fc35), but
        neither of them have Cyrillic glyphs
        
        Change-Id: Ide8b84502886c7b9e0bc4fcef4685b4b89ec2bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-05  Justin Luth  <justin_luth@sil.org>  [5f4ebedcd010f8248d9eea93bd36142a64820fe5]

        tdf#123658 sd search: restart search start on slide change
        
        When the user switches between slides and then re-starts a search,
        they expect that the search will begin on the current slide.
        
        This fixes a somewhat 5.2 regression. Before that time, the first
        search attempt failed, but the second attempt started
        at the current slide. After 5.2 fixed the first-attempt-failure,
        the starting position was "the slide after the last find".
        
        This patch resets the starting position to the current slide,
        which I saw was done in every case by DetectChange().
        I thought about moving all this logic into DetectChange,
        but it doesn't make much sense to affect a spell-checking
        dialog run by moving around in the slides,
        so just keep the logic here.
        
        I submitted the unit test in a PRIOR patch.
        The basic search was failing on WIN/MAC platforms
        and so I wanted to confirm that this was NOT my fault.
        Indeed, on those OSes the testing fails,
        so I just run it under Linux where it works fine.
        
        Change-Id: I4d1af3049bb2c0a59ec46f005c4b1773aefffb6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129204
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-05  Noel Grandin  <noelgrandin@gmail.com>  [f7016b59dd21e3444d9e6802e2a9d254c4684b83]

        use more concrete types in chart2, LabeledDataSequence
        
        Change-Id: I50b23923c1aa946f2c448534719a6c18003592a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3e895e3d766fd680b96eb0c8d069b7a329f7fd45]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 812cf4e5abff9e7e8b458358590b9672eb6f5adc
          - More smath refactor
            
            Change-Id: I3315edb41319e262b883dc77d149cfe1b21a86c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129527
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Mike Kaganski  <mike.kaganski@collabora.com>  [94ba3770ffe31bd26e0c67a5609c8935994b808a]

        tdf#138691: avoid buffer overflow
        
        Change-Id: Ib5eaf6c658e1185c1e3eec7ce34f0ce54d6ce771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129441
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [74ad7417afc3a8dce6fed2d716a085e0489414f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d2597dae72dca7ac307bc2882521149e019e23c
          - More smath refactoring
            
            Change-Id: I5a293454a9c4381a84ebe2c96d0d2ee7314ed8aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129525
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ef86fb4bfa12741885d4d761987d37237ac9fed9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37f649594e9ea276857717278383a9f4b16c9059
          - Refactor smath help files
            
            Change-Id: I85ef1e1b012a0d287faf9e3ae43e59a09796583b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129523
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [165e6ccb97e72696fc530e7d7469551473e0b576]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4c67afc5f5ac8ada17f82a248eba33c8bd0c520
          - Drop last 00/00000004.xhp#wie and simplify XSLT
            
            Change-Id: I85d2da067db208f806b78020a9ca95889444ce0d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129519
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [6156ea35f77cc38c197fb718f2ed4bd5015a8dfa]

        Fix [-Wignored-qualifiers]
        
        Change-Id: Iba8b8536be38f99b7b7447d96abad61db7b7269f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129517
        Tested-by: Jenkins
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-05  Johnny_M  <klasse@partyheld.de>  [efcb393a0f21574d37d623882f05f6f1efdfcc0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 819edf7e03678c292f2c4226572bde4d8727d093
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9a043f5129c4cef17fa780bf1034b02587274294
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129516
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [92039e306d17fea932174631c444fa401177245f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 509e5d044b1674133079aa76a35c9984cbae903d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1a47ddb4bda170a7174498deea03f7650fc14530
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129513
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [b40ff345be20ca6628dce7efe98a17362d825984]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 97dc64b7770686075c9499ef8a3f4dbedf16f2b5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I540a88c566b4e12580207fb13df67b2d163d3b23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129514
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [20c68e54ea167bb434c70be7fa18577813ed0cfe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed189f299e4ec419c03119a15f903c5d0e6c9667
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9edfcdc81e2c38e5034c2a2bda22dcd2c85394da
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129511
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [275c709a46f9d611d39c9a049807c93dd6bdbeb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac85a5e995f8f0a47cc994ae917cb5782ff5c723
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4fa16989a089a9a513565eeaa85cd8e7b1562b33
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129512
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [4bdee7cdfc09fe91ac6690b1be32d451370c82ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to beb992ccb561985ae6bb45f087b73bc705c90431
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia9bcd4903b0ee5a8f6cef30f0c4dba262f586de7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129510
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [911bbbe7621ebb969e8b51c13bc840e897ca7cd7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cb9523a78ae0814c55821c81a990a64a36cf10e7
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3657890c864efe55565033c483e55890fcee539f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129509
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [3a643654bb564c1f8767af1af8dacc9c6c6df41d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b40105dc79803834bcaef7eec72f75f1e7495af
          - tdf#132643 Translate German section IDs
            
            Change-Id: If5a315df7958d45ef923056fa9491108408ccc9b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129508
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [1760015fa8bae678ed6856add2419100aa415198]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc571195db53ae344bb151680dfb4bdac56cccba
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifa47729a6dd4ffb7485ee368422c3742213654a5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129507
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [bdc3cbe7f65ec8dd38090e9754212cf1bd00350f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1aff65079bdcb5e87cc03946e60c7ff8aa50851f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id5e819358ac1a37ef2cbd04f6cf22e925c3a24f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129506
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Johnny_M  <klasse@partyheld.de>  [b7577a531b9c0e64224c41974c1b987cff893641]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f1350dc1ede475b40ceefcaebd8753770d3a1bd6
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4ef0e4edbec4e314b9f9e3bd8a2184939bfc523d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129505
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-05  Julien Nabet  <serval2412@yahoo.fr>  [47dc55872b5d581640dbd062148a8ca1337db99a]

        Fix duplicate id and renumber a bit to respect order
        
        Change-Id: I36ba3e0c6793b6a566e839e8d1c314606a4e0d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129520
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-05  Szymon Kłos  <szymon.klos@collabora.com>  [f609a16a52f1ac37f1edd297cf1d9e5f2a294724]

        lok: render image preview with lower resolution
        
        renderShapeSelection callback is used to render
        image previews which are later used during
        eg. rotation.
        
        Do not render preview with original size which
        slows down app a lot. Use 1280x720 max.
        
        Change-Id: Ia8365a67d87cea869ef74cb70ce4830439a523b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129497
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-05  Caolán McNamara  <caolanm@redhat.com>  [c59f37b9735a0ca122f29606508c50d25bbaa985]

        be more stylistically standard
        
        Change-Id: I8fa978a5b58faa79c9c07b2c832a56b4d5230dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-05  Caolán McNamara  <caolanm@redhat.com>  [824a84a894755f2ce41f4612f27d2e1110676c6d]

        Related: tdf#146836 daisy chain together some more event handlers
        
        so old ones are not clobbered but are called from the new ones
        
        Change-Id: I4cdd25fc1f3b13b10711d5c2f30c46645ae6c968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129503
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-05  Dennis Francis  <dennis.francis@collabora.com>  [349593166af244566fe0a8d2c11f3bcd73048c1d]

        lokCalcRTL: fix chart insertion position
        
        Change-Id: I573cb19643d7a048f3313aba90fa9b5514c9cc74
        (cherry picked from commit f1ff0ec57914e8871f8563cd26ee1b87d562f1c8)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129365
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-05  Dennis Francis  <dennis.francis@collabora.com>  [3cd2d9665fba5723ac84732fcf41dc675577f08c]

        lokCalcRTL: trim invalidation rect to ensure +ve X
        
        Change-Id: Ifecb52167e3cddee036e1e1e9bd5782a1138b654
        (cherry picked from commit c2cbe0dbe4c9e4ce8014e881ba3663add77f7aca)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129364
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-05  Szymon Kłos  <szymon.klos@collabora.com>  [604ea1bfe06a8a19b084b5a6a603d8c1ba041f0a]

        Fix ambiguous error in VS
        
        Change-Id: If18ef06f5a27a4266b21df4ba07bd5bc01255f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128381
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        (cherry picked from commit af168ae749dfd816fe029bbca5967fc3d5a1aa81)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129439
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-05  Julien Nabet  <serval2412@yahoo.fr>  [b63a080c0c1dc9c3f2fc82e03d97d45d91dd7d16]

        Following simplify a bit ODatabaseDocument::impl_getUntitledHelper_throw
        
        Change-Id: Iae6eafba5fffb8128526642f67dc932ddd115336
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129486
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-05  Dennis Francis  <dennis.francis@collabora.com>  [368ae1026db78478b54cb4dc4e06475ce29a3a55]

        lok: setClientZoom: check PPTX/Y approx equality too
        
        This is needed because the initial PPTX/Y on document load does not
        match the implied PPTX/Y corresponding to the client requested zoomX/Y.
        
        For instance when document is loaded by LOK client and 100% zoom is
        requested, the correct PPTX/Y should be (1/15 = 0.0666667) but the
        initial PPTX/Y on the ScViewData is 0.0647702
        
        Change-Id: I996e9f003abd269df0994f3d114e42f84bb2bb20
        (cherry picked from commit 04bb404bffa9fe19568655e81bcd5db21f153cbc)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129363
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-05  Dennis Francis  <dennis.francis@collabora.com>  [e3e8aaa2517dfbaf9ab5dcf10612547c6c6b0eb4]

        lokCalcRTL: fix rendering of charts in edit mode
        
        Inform Sfx2InPlaceClient and LokChartHelper when negated X coordinates
        are used. Ensure that invalidation rectangles have positive coordinates
        in all cases.
        
        Conflicts:
        	include/sfx2/lokcharthelper.hxx
        	sfx2/source/view/ipclient.cxx
        
        Change-Id: I8f5440718e288d8f0d379c8da5f49a29e51f6940
        (cherry picked from commit 284068c7eb473bafd5cafeb30a78daab4538cff6)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129362
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-04  Justin Luth  <justin_luth@sil.org>  [583185235389b55d6cfffac3067c0e1ccb2852b1]

        related tdf#145868 sd: Clone SvxSearchItem to avoid use after free
        
        I tested "if (mpSearchItem)" which passed, but then it
        crashed when trying to access (*mpSearchItem) == (*pSearchItem)
        because the mpSearchItem's DTOR had already been called
        prior to the if(mpSearchItem).
        
        Since mpSearchItem is never compared to another
        memory pointer, it is safe to assign it to a Clone.
        
        Steps to reproduce:
        1.) open Impress and search for something
        2.) change the search string to something else
        3.) search again.
        
        Note that there isn't currently any code that hits this.
        I discovered it trying to craft a fix for bug 145868.
        
        Change-Id: Idc5f5a3e812ed3e49631347c35c3f4b2d8bb4127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129347
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [5b0b004107f47ebfedd68d5916aa2176dad0d27b]

        test fails with both fedora KacstBook and bundled KacstBook installed
        
        fedora KacstBook ver is less than bundled KacstBook ver so bundled is
        preferred, bundled KacstBook has no Latin glyphs, but glyph fallback
        finds system one and sees it has the missing glyphs, determines that the
        whole thing can be done in the fallback font, so the toplevel is unused
        and so "invalid" and this test fails on checking that.
        
        The test is supposed to ensure that glyph caching gives the same result
        as uncached, which it does, so just assert if there is a difference
        between cached and uncached
        
        Change-Id: I3c424a17f3e544aa64f4af98e0c151fc00b2e6e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129499
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [8f44cb12670ba864f8b33bf0477d1edee99d2798]

        the tend -> they tend
        
        Change-Id: I2b1843ef46d7ed30c3125e8bcda8a0669d0a0fa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Michael Stahl  <michael.stahl@allotropia.de>  [6d5f22585003e1b0091eefad9d6a2446a1b510d1]

        tdf#146462 sw: fix broken CrossReference field tab page
        
        (regression from 40487d9c81c69c4e5ee1621e53c8162ae33c80b2)
        
        Change-Id: Ifb4117a8fa5c393483209b2768f0b6ea4eea2d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129502
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-04  Dennis Francis  <dennis.francis@collabora.com>  [8bd08a18bf58bafc0a68e86d1091295528e257b4]

        lokCalcRTL: negate mouse event X for chart and controls
        
        Conflicts:
        	sc/source/ui/unoobj/docuno.cxx
        
        Change-Id: I389047140d1a3d2c67a861a3e20f799206d937b6
        (cherry picked from commit 0f2208a43861ebe94c4a2482a0cf7e5c63bb186e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129361
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-04  Dennis Francis  <dennis.francis@collabora.com>  [226847e385d021bf2feacdfa796b3eb7023d6f0f]

        lokCalcRTL: fix editing of shape text
        
        Inform editeng that negated document x coordinates are used in this case
        and ensure that editeng generated invalidation rectangles always have
        positive X coordinates.
        
        Conflicts:
        	sc/source/ui/view/gridwin4.cxx
        
        Change-Id: I2e450707ce02f7bcd8e4d299f857c37ebbd5e2c6
        (cherry picked from commit 0fe02bb99e5dfa8379a49de75683fc350e4c4dbd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129360
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-04  Luboš Luňák  <l.lunak@collabora.com>  [0be8060a856f86fdfb42372e58073586b29c93fa]

        Revert "lok: copy over the alpha channel too for cairo..."
        
        Not needed in the end.
        
        This reverts commit 688051edf59a311371b84ea34db4991d3a164d52.
        
        Change-Id: If2474ccff0ada5fd0ca5206f10ca2893df0fe1f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129491
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-02-04  rafaelhlima  <rafael.palma.lima@gmail.com>  [c7923851d10e2dda9deb414dee67c4813d93bc87]

        tdf#146893 Remove extra buttons from Manage Changes sidebar
        
        After commit 2e1a38ceb6866248ec30f6fe58cd3adc1b910eec that moved the command buttons in the Manage Changes dialog to the List tab, the Manage Changes sidebar started showing the buttons twice.
        
        This patch remove the duplicated buttons from the sidebar.
        
        Change-Id: I767e88ba9ca7595913b6ddc57d152febd595f504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129103
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f0d27c973323f522a4ca2bce557e1c095d32f77]

        tdf#146795: sc_uicalc: Add unittest
        
        Change-Id: I37accef701ad1240572839170258b9f405409abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129488
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [510d551669bb8c487ea7e2a4f5e4a7ab67d96033]

        fix direct leaks in vcl cppunit tests
        
        the uses of new are wholly unnecessary
        
        Change-Id: Id7238be6e73567add8a0d3ed6dc9f3262e15c043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129493
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [d5a43d2c0ce695a87b3ccd322c11b1d28400f2da]

        use some more add toId/fromId
        
        Change-Id: I3a21e2aa5a2c482c0bac1d4c9bf84f8b56261408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Miklos Vajna  <vmiklos@collabora.com>  [50682cea4196819980c8e2d4018f80384097ce6f]

        PDF export: improve precision of pdf image sizes
        
        This helps exporting full-page PDF images from Draw more accurately. In
        case the page size was A4, then the page height is 841.8897637795276
        i.e. 842 points. Full-page PDF images are scaled to this size, so the
        referred PDF form XObject has the reciprocal of that scaling.  We used
        to just write 0.00118, doubling the precision leads to
        0.0011878840.
        
        In practice the old precision resulted in e.g. hyperlink rectangles to
        get out of sync with link text after 2 roundtrips, while the new
        precision doesn't result in any noticeable modification to the link text
        position after a roundtrip.
        
        Change-Id: I72cc68696b9b9bcc1cbfde8df331c2b9c5f9eb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129482
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-04  Szymon Kłos  <eszkadev@gmail.com>  [ad674edf394bd1c9b56410b5f53587c303693fcc]

        Use unique id for FN_UNO_TRANSFORMED_GRAPHIC
        
        Change-Id: I1425fbbe843534adba8b87f9c7b23461cc6049c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129375
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129489
        Tested-by: Jenkins

2022-02-04  Szymon Kłos  <szymon.klos@collabora.com>  [2ed8f9b6bc820c68dfae1267bc87429d502625b1]

        lok: use focused tab page help
        
        When we open dialog with tab pages, help should open
        website for corresponding tab.
        
        Use focused window - but not global which can be modified
        by other view in lok case.
        
        followup for:
        commit 70f2fc7a10f41204e353bd3487377983a1018b53
        lok: don't use focus window to request help
        
        Change-Id: Ib7544a91696ce2f2c8ab01e62a47d279d2c5c655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128863
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129167
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [e00032ba6a2ddd4c08ae6f03b1982d3c099d288e]

        add toId/fromId to tidy up some ugly casting
        
        Change-Id: I70f34ac5e9b5d2f2d6c0375e823908eaa2e540b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [8d3f658aa58ddee8c7bc32ddea070c1bb3bf19b8]

        ofz#44398 defer getting resolution if Pdfium disabled
        
        Change-Id: I292d36ad9bb900881662898345f8e1f00ebf28b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Noel Grandin  <noelgrandin@gmail.com>  [ccbd2b0c663fa19be5301f0ea8ac74caa055fe47]

        use more concrete types in chart2, LabeledDataSequence
        
        Change-Id: Iecc22ad488fff7d0536ffa37f4cde7da460c2c7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Jean-Pierre Ledure  <jp@ledure.be>  [a1513003543e4a7a47da47659a715eec2b6af452]

        ScriptForge - (SF_UI) Import RunCommand() from SF_Session
        
        Functionally SF_UI groups methods impacting the
        user interface, while the Session service groups general-purpose
        actions.
        
        The RunCommand() method (newly introduced in 7.4) simulates
        menu commands applied on the active window.
        
        RunCommand() fits better in the UI service.
        
        It is removed from SF_Session.
        
        Change-Id: Ia72150efea2f50de13d15a4c1f5fea79777d1760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129453
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-04  Henry Castro  <hcastro@collabora.com>  [1a62f3383dfda9c35d46adbbdfbc3a9c2278eeb5]

        lok: ensure no more tunneled spellchecking menu
        
        Change-Id: Ic79d9b6d606573d93830347390c6466b033e9f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120963
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129460
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2022-02-04  Pranam Lashkari  <lpranam@collabora.com>  [d2a3333ba6f354027a248bbfb2e1b8359d403c52]

        Added master slide handling in getPart* functions of SdXImpressDocument
        
        There was no option to get the master slide info from SdXImpressDocument
        
        Change-Id: Ic42a4c541c406a50ec26ec2113174ab25675a074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129423
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129480
        Tested-by: Jenkins

2022-02-04  Noel Grandin  <noelgrandin@gmail.com>  [f90ac900a9ff48c4ea8ae797972ed4c442b516fb]

        use more concrete types in chart2, DataSource
        
        Change-Id: If5001a8a8fc1103a8d662429d3077c7ce81cc2b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Noel Grandin  <noelgrandin@gmail.com>  [fc03ef1e02da261073994e7478b08fa57b3ea962]

        use more concrete types in chart2, LabeledDataSequence
        
        Change-Id: I88d5b7e045814cbd40750ebe927e6a76d5a463d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [957d5cf0d2acd10eee5b36f6cdf66117c059a4c0]

        Revert typo fix, 'stringly typed' is the intended form
        
        Change-Id: I46cba870cd90d02c3dbaa60e9b1291ef751db377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129485
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-02-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [d934f6db87afa61ce4ad6c5fb6b4e5ab842cac8a]

        CppunitTest_sd_png_export_tests: fix order of arguments
        
        nY goes first. See include/vcl/BitmapReadAccess.hxx
        
        Change-Id: I1af00102d2267017b98e6b6e286f2eda74f9ca24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129374
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [ea771e85b2302829394df545bb82c02bff2750c2]

        Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton values
        
        for these cases where draw wants to massively scale the units
        
        the underlying "metric conversion" are already using sal_Int64 anyway
        
        Change-Id: I94e120d72644319548f75b2f68cfe60d4829a2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [f2d62b11cd7d47925fd098b3947726313d6b296e]

        cid#1497934 silence Division or modulo by zero
        
        Change-Id: I2f894e46b962adfc9a5c97dc6731d292a61939a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Stephan Bergmann  <sbergman@redhat.com>  [bfbb28d4130a70a821466fa25948c5da5369f973]

        UBSan build missing RTTI now
        
        ...e.g. during CppunitTest_sc_copypaste
        
        > [_RUN_____] ScCopyPasteTest::testCopyPasteXLS
        [...]
        > warn:sal.osl:22300:22300:sal/osl/unx/module.cxx:152: dlopen(/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libchartcorelo.so, 257): /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libchartcorelo.so: undefined symbol: _ZTI19SvxShapePolyPolygon
        [...]
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2289/>)
        
        Change-Id: I6b62aa4636b65ae728c462e91e5a024366c95a56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129481
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-04  Mike Kaganski  <mike.kaganski@collabora.com>  [627869ff6cd910faa92bd7511e5fd0e8c10b8379]

        Don't cast enum to bool instead of comparing to a defined constant
        
        Change-Id: I1be04d5c52903bb75105182c3cf46defa266d755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129431
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-04  Caolán McNamara  <caolanm@redhat.com>  [f9950994914c0d605260e6f5bbc0e21bcab94826]

        the real font used for 'Roman' is arbitrary
        
        the font name isn't a typical semi-standard one so it neither exists nor
        has a standard fallback. binary-hack "Roman" to "Arial" which is
        conveniently the same length and does have a standard fallback of
        "Liberation Sans" which we can add a dependency on via more_fonts
        
        Change-Id: I1d9b8294f67a00a1e5cabe38b71467e66b83aedf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129454
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-04  Stephan Bergmann  <sbergman@redhat.com>  [84b79376d7bc57a3967d7203a7d51466625588e8]

        Add a clarifying comment regarding the use of UTF-8
        
        ...justifying that 2f3a0bfbfe110c0837b3c7e04f9ad0969d6e56e4 "tdf#147088: Also
        handle U+FFFE, U+FFFF invalid XML 1.0 characters" added code that assumes
        `string` is UTF-8 while carelessly removing the "assuming we're writing UTF-8"
        disclaimer comment that had been added with
        8b25b67d5268abbb260da968cc23b6f6c8dd31af "escape invalid XML characters with
        _xHHHH_ when writing escaped"
        
        Change-Id: I0866da2bbbc536b2feb977c35b164459b745d918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129422
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-04  Noel Grandin  <noelgrandin@gmail.com>  [3c2192c840f8bc86a677dd1394e9e1b1b52f86f3]

        use more concrete types in chart2, DataSeries
        
        Change-Id: I51a30d2a6a3c424dcdc29b6647aa2b67fa35884a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Miklos Vajna  <vmiklos@collabora.com>  [b78ef5d55b891d8f6788ac53adfab0087d49c7be]

        sw: prefix members of SwClipboardChangeListener, SwPagePreview, ...
        
        ... SwScannerEventListener and SwView_Impl
        
        See tdf#94879 for motivation.
        
        Change-Id: I19958bc70e7dd80ea3f1c75e06b9ac192d40f254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129472
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-04  Julien Nabet  <serval2412@yahoo.fr>  [bcd5a154e4284848553f994d4d0612182130c271]

        Use only toUInt64 for reinterpret_cast<DBTreeListUserData*>
        
        Change-Id: I3e7ad37ae5cc59dd0378ef1b08b4cc47a780e005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129475
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-04  Julien Nabet  <serval2412@yahoo.fr>  [ebc572c4366b871c737cd4785a48111c1344cad2]

        Simplify a bit ODatabaseDocument::impl_getUntitledHelper_throw
        
        No need to call "m_xModuleManager->identify" which throws if the component var
        is an empty ref then do nothing with the exception.
        
        Change-Id: I213aaa3bf4c67c2a1b94b725283b2421c904abba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129474
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-04  Kevin Suo  <suokunlong@126.com>  [bcf10015c5d12d363d0be9f6da25092c83112692]

        sdext.pdfimport tdf#137128: Recognize more font name and weight...
        
        ...values from the embeded 'PS' font names.
        
        Change-Id: I8465a6b1d845ce626848112f0a735a9ee3696e5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Kevin Suo  <suokunlong@126.com>  [2f605009907166d509ccd1dcb6385e5cd456e3e4]

        sdext.pdfimport: these SAL_WARN should be SAL_INFO
        
        SAL_WARN should be some message which showns where the program
        runs abnormally. Normal debugging output code should be SAL_INFO,
        and if you have set it to SAL_WARN for easy debugging you should
        set it back to SAL_INFO or delete those lines when submit.
        Otherwise our dbgutil terminal will be flood with unrelated
        messages
        
        Change-Id: I0767bfbeb7a21f208be12208009ccda8b6c72bab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118763
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-04  Dennis Francis  <dennis.francis@collabora.com>  [0a95b424c8fd4eb58b439828120ba631048be32f]

        lokCalcRTL: shapes: negate mouse-event x coordinate
        
        Conflicts:
        	svx/source/svdraw/svdview.cxx
        
        Change-Id: I153334940b41859e6fd9dee64217925627f0f292
        (cherry picked from commit bb37b46182bcff2f10edcc590cedbc4bb5820c4b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129359
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-04  Miklos Vajna  <vmiklos@collabora.com>  [9f7e6d10d863bb206ba3d671e34d2f019e2d2480]

        svx: show width and height of SdrPages in the xml dump
        
        Which is useful to see, as a 2 page Draw document has 2 normal pages and
        a master page (3 sizes), but in practice there can be only a single
        size, so it's useful to see what size is coming from where when they
        don't match.
        
        Change-Id: I505653029ae67ea0a57c8f8bb61cf475d77aaccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129425
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-04  Jim Raykowski  <raykowj@gmail.com>  [a93e15c2e3a957ba97a166ee76be520a219ac540]

        make floating Navigator stay put
        
        Change-Id: Ibbdd2bb66061189b361f4921e98ac4fd99563eab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128714
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-04  Kohei Yoshida  <kohei@libreoffice.org>  [703fb7739a5e604d90e147db6f67917b8d141150]

        tdf#146795: Make sure to use valid position hints to avoid crash.
        
        This commit also unifies the code path for both "skip empty cells"
        option is selected and when that option is not selected, which
        simplifies the code quite a bit.
        
        Change-Id: I21054cccdd9f60e073695091740b9415dfef2985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129267
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-02-03  Miklos Vajna  <vmiklos@collabora.com>  [80723fccbb03c215bab84b10ac1eefaedef66b7c]

        filter: allow PDF export to sign from the cmdline
        
        Sample soffice invocation:
        
        soffice --convert-to 'pdf:draw_pdf_Export:{"SignPDF":{"type":"boolean","value":"true"},"SignCertificateSubjectName":{"type":"string","value":"CN=..."}}' test.odg
        
        You can copy the subject name from the PDF export dialog. This works
        only in case the signing certificate already appears in the certificate
        list.
        
        Change-Id: I8670f9a410c6e80497a4d6223d1438938bc949e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129387
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [41acfefe1ee1ba28ae38ad0cd3d9760e1e4d1765]

        CppunitTest_sd_png_export_tests: use assertColorsAreSimilar
        
        Change-Id: Ie78797eaa774ba94b7b57fad025c811707d2db04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129448
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [42ad4accc4d3fe27fc71edc97eaf948451848756]

        cid#1497932 Dereference after null check
        
        pSh->GetOut() is always dereferenced before this check
        
        Change-Id: I1909ec7a726049cc154c5a2300fe921dc8cdcbb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d5f015185240a7bddfed7ddf10d6b5426e35fb72]

        tdf#134965: sw_uiwriter3: Add unittest
        
        Change-Id: I985b26f4340f17b060c6ef18dfa70c327585e4f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129409
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [e153f35929475ef661f03b06dfa25aacaa28acfa]

        We know the buffer length here
        
        Change-Id: Ib4c7176d046a86ad22d57fc8789cd53e87859076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129346
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [772460f5cc61035a5b10bdf55a71f2a03f88af73]

        vcl: simplify assertColorsAreSimilar
        
        Change-Id: Ifd25bf75c5e173a7db4778713f1d371e9ee24ac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129381
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [f6180e3e8725687605027815b4e878dc83b300b0]

        rhbz#2047319 drop the SolarMutex before QApplication::init()
        
        https://invent.kde.org/qt/qt/qtwayland/-/merge_requests/24#note_383915
        
        reproducible with with qt5-qtwayland-5.15.2-17.fc35.x86_64 and
        export OOO_FORCE_DESKTOP=plasma5
        export SAL_USE_VCLPLUGIN=gtk3
        
        Change-Id: Icdf6b8709865c723c266e6400169b33639a1b0e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129373
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [8f67e2633af1386fbfe15b53b4e309dcda988a6f]

        tools::Long -> sal_Int32
        
        Change-Id: Ife7fc63f4ad0f3dcd34c9079d74044bae7924988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [789e22f7eb115d56351f19ec238a5c92798b0a4c]

        tdf#147119: sd_png_export_tests: Add unittest
        
        Change-Id: I69504a65926e3611e0d954d3ed317d45741b341b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129354
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [a2b920c0a741bf9f25a60366df3af18c3cf65713]

        22 characters needed to Base64-encode 16 bytes
        
        Change-Id: Ia7f6f1b72b487889c115b664fcc32a4955f4bc36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129345
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [297f000c4968da9a61846d1b336d4fb77e01610c]

        cid#1497939 Division or modulo by zero
        
        and
        
        cid#1497937 Division or modulo by zero
        
        Change-Id: I24f939e19791d811845a476c68125f40bb78f9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129400
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [50f4b6bfd5c71a66d0c50aad7a99408ce1b99d58]

        cid#1497935 silence Division or modulo by zero
        
        Change-Id: I60fc87d0724d8b677479c107af4f3cef4ef47186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129401
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Jean-Pierre Ledure  <jp@ledure.be>  [de03a5ca23ddb09a55014f9d79ebcd6df54503bb]

        ScriptForge - (SF_Calc) FIX range parsing error when leading $
        
        When sheet name contains
        - a leading $
        - surrounding single quotes
        an error message was errorneously displayed to the user.
        
        Corrected in the SF_Calc._ParseAddress() function
        
        Change-Id: I8abd4908a4c92bd6e569b95be58ab21e16ffc169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129408
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-03  Tor Lillqvist  <tml@collabora.com>  [266e6b76763d16bcb1dcf67bab2478a7d2d7b8fc]

        Make inserted or pasted PDF sharper on macOS
        
        When inserting a PDF file as an image or pasting PDF data from the
        clipboard on a Retina iMac the resulting rendered image did not look
        sharp.
        
        Using a surprisingly large extra scaling factor helps. The exact
        reasons for this are unknown. It isn't enough to use a scaling factor
        of just 2 (which is the HiDI ("Retina") scale factor on my iMac).
        Possibly the fuzziness is related to what Pdfium uses to render text.
        
        Also, look at CountDPIScaleFactor() in vcl/source/window/window.cxx.
        The GetDPIScaleFactor() function lies on macOS even more than it does
        on other platforms. It claims that the DPI scale percentage is always
        100. But in fact most Macs nowadays have a Retina display so it would
        make more sense, in theory, to at least always return 200 instead.
        That wouldn't be any more wrong. But that causes regressions in the UI
        rendering, like needlessly large icons in the toolbars.
        
        Change-Id: Idc694f742c4ac32a5a134f8d206cf4eee467c39a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129369
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-03  Noel Grandin  <noelgrandin@gmail.com>  [6b14014342a665268b822729d465e9d3a3a2ca57]

        make css::chart2::InterpretedData a normal struct
        
        this is internal-only, no need for it to use UNO IDL
        
        Change-Id: I5f9844f48640618ac5bd348721bdee43e5f0a57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4f61a594608219d08b489205ebb5569d905f444]

        no point in mapping SID to itself
        
        and once we remove that self mapping, no need to call GetWhich for those
        IDs either
        
        Change-Id: Ia881328a29bb022dace8d5f25c57279a381e0377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5eddf3b047dca78ea321005cc6dc5e92914e032]

        sal_uLong->sal_Int32 for refresh delay
        
        and improve the naming of the related methods and variables
        
        Change-Id: I1dc522090b0353fd4c63e74864a0deeb8d70fd28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9aaf8db1e4ac20fce4b19bc43c13b25938e80275]

        SfxMetricItem should take signed value
        
        since it extends SfxInt32Item
        
        been this way since
            commit 5f51e579fc2e3207166b053382ca14b95082728c
            Date:   Wed Apr 11 18:28:13 2007 +0000
            INTEGRATION: CWS hedaburemove01 (1.1.2); FILE ADDED
        2007/02/09 16:12:44 vg 1.1.2.1: #72503# get rid of hedabu procedure:
        Moving headers to svtools/inc/svtools and correspondent necessary
        changes
        
        Change-Id: Id23909c5cb842b858baf2f6918298607a79adcec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Julien Nabet  <serval2412@yahoo.fr>  [91fd537a4517409da87229fd7c0f21d269973d43]

        tdf#147144: Writer crash after adding rectangle, add link and delete it
        
        bt:
        0  SdrMark::GetMarkedSdrObj() const (this=0x0) at include/svx/svdmark.hxx:68
        1  0x00007f958c31555c in SwDrawBaseShell::GetState(SfxItemSet&) (this=0x6bbcd70, rSet=
            SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678), ... = {...}) at sw/source/uibase/shells/drwbassh.cxx:899
        2  0x00007f958c3148bd in SfxStubSwDrawBaseShellGetState(SfxShell*, SfxItemSet&)
            (pShell=0x6bbcd70, rSet=SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678),...] = {...}) at workdir/SdiTarget/sw/sdi/swslots.hxx:8315
        3  0x00007f95a6025de1 in SfxDispatcher::FillState_(SfxSlotServer const&, SfxItemSet&, SfxSlot const*)
            (this=0x65acbe0, rSvr=..., rState=SfxItemSet of pool 0x2dc5730 with parent 0x0 and Which ranges: [(5678, 5678), (5713, 5713),...] =
            {...}, pRealSlot=0x7f958d1eb190 <aSwDrawBaseShellSlots_Impl>) at sfx2/source/control/dispatch.cxx:1658
        4  0x00007f95a6004fe9 in SfxBindings::Update_Impl(SfxStateCache&) (this=0x65863c0, rCache=...) at sfx2/source/control/bindings.cxx:259
        
        Change-Id: I910429103f505e855d88b7efe9a5ca771d5fc92e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129388
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-03  Luboš Luňák  <l.lunak@collabora.com>  [2eb00243a1d5596ed608a476a73b2d063ab09a49]

        ignore ~ backup files when searching for .py uitest files
        
        Change-Id: I9b476336349b67d3d9bb149d4ad4824740797eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129370
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [4f0a5cc84862e83649e933dbde272629c55c1210]

        cid#1497938 Uninitialized scalar field
        
        Change-Id: Ic551b34069496c683a065997f051037ecabe3b7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Andras Timar  <andras.timar@collabora.com>  [d1d3b2e7090e71b9f827f43a0da75342d109f0cb]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 8fecc831337825ee6a5a471ec72f79bad5b3dda5
          - resolve committed conflicts in this file
            
            Change-Id: I98376d34feb682794bb92c4463a3854a8b8498ee
            
2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [ee1d3fce6b1fe42ed70a99511ee18785e987da0f]

        ofz#44303 Null-dereference
        
        Change-Id: I2202ca853edea29e987e920b1f8bf65ca622291e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129397
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [028602a7fc0691958ade01c9bc7cd617e85203ac]

        tdf#147119:Revert "tdf#123973 fix missing MasterPage content in export"
        
        This reverts commit 87866def6bfe2ee91be34a5ce37b79d6da881617.
        
        This also reverts commit 98d6ed2aeb22b27fddf716a372f483b89ecea841
        < tdf#123973: sd_png_export_tests: Add unittest >
        
        Change-Id: Ic3c8c70ef789b83cec0614e766a3c067cbf078fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129351
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [417feeff2c547f2675e3bfcea639faf7fd140e7f]

        tdf#147027 Cannot display pattern, gradient or hatch fill in bar or area chart
        
        this partially reverts
            commit 0b0934056b47485527442b6366d7fd3274a4601f
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Jan 4 18:50:01 2022 +0200
            bypass SvxShape when creating rectangles in chart2
        
        specifically the part responsible for setting all the style-related
        properties on the SdrPathObj.
        
        There is just too much logic to re-implement in bypassing SvxShape. And
        the logic is spread out over several different classes/methods and
        overrides, so getting it perfect is pretty much impossible.
        
        Change-Id: I7dbae95dda780e7fa40c4e0798e6c199e4eaf41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [fdf84b42a09fa2eed03dccfaeec98dba720e6557]

        Call SymInitialize only once
        
        Also simplify the logic by passing fInvadeProcess = false there, since
        passing true is the same as calling SymRefreshModuleList explicitly.
        
        Fixes an overlook from commit 853a058ca6b75b0fb14e232911eb9f9553574736.
        
        Change-Id: I296f06845a9f92375908d72e69574c2ecd190028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129338
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-03  Luboš Luňák  <l.lunak@collabora.com>  [5d3c8da8c320a950d94e0809c165dac8482f8837]

        handle graphics test specially in backends too if needed
        
        The backend test unittest already needs some special handling (such
        as not smooth-scaling in Skia backend when in HiDPI mode), but
        graphics test were failing because the name of the unit test was
        used for detecting whether to do special handling.
        
        Change-Id: Ieb23915f1eeafc13c921de06475cb761dc4c485f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129292
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [2b95b55983689d5476e89c27177351e2d6785047]

        tdf#125849 cannot modify the ruler unit of measure in translated UI
        
        Change-Id: Ica74dd5e55d30605ee03affa4b724ffa4ec65b5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129357
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Caolán McNamara  <caolanm@redhat.com>  [5a33b4df9201d5d04b923b8f67d50eec0f11fd2b]

        Related: tdf#146997 no value-changed emitted for FormattedSpinButton
        
        under gtk. When the formatter sets a value during focus out then gtk
        won't emit a value-changed because it wasn't changed by gtk, move that
        emission to the formatter itself
        
        Change-Id: I6e2681b77d6effcd3abaa028e3e5383aa218863a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129306
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6a0f00d3b9d1a74637c92ec6eff1ba5fedc82f3d]

        tdf#146742 - Move the initialization code of a method to SbMethod::Call
        
        Change-Id: I516bacdcd22ed094a0e9b6e125e941f32fe88c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129238
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-02-03  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [65b09ef1c5e24651579eb11900cf2ddbbb7b0971]

        tdf#146803 tdf#146805 OOXML import: fix bodyPr at grouped shapes
        
        Grouped text boxes (WPG) lost their alignment and spacing,
        because the bodyPr tag what has the information for this,
        processed after the textbox content, and applied to the XShape
        which in case of group shape is not ready. To solve this, the
        mentioned properties read for the shape member after copied
        to the XShape when its ready, and than synced to the textbox.
        
        Regression from commit 121cbc250b36290f0f8c7265fea57256dad69553
        "tdf#66039 DOCX: import textboxes (with tables, images etc.) in
        group shapes".
        
        Change-Id: Ifb5e8bde58613137441bec2e2b51bc67118dab40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128854
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-03  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [4a38ca4035ac03571925e72cb47e0beb8da2003a]

        tdf#146802 OOXML import: fix embedded VML in grouped textbox
        
        E.g. OLE formulas inside them broke document load.
        
        Regression from 121cbc250b36290f0f8c7265fea57256dad69553
        "tdf#66039 DOCX: import textboxes (with tables, images etc.)
        in group shapes".
        
        Note: now embedded VML OLE is loaded in WPG shapes, thanks to
        that the ShapeHandler in oox/ has a stack having the start
        token inside for each shape.
        
        Change-Id: I973d78ed88c5c83efffd9629061e2a2c6fdd25e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128627
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-03  Tünde Tóth  <toth.tunde@nisz.hu>  [b8925251e48534706c6960a54c320d3879317321]

        tdf#146822 OOXML: fix export of the transparency in hatch fill
        
        The transparency value of the hatch was not exported.
        
        Follow-up to commit 001afbed910b7e565f602c1b11b1b4538cd59442
        "tdf#127989 OOXML: fix import of transparent hatching".
        
        Change-Id: I9b82a3422de8e4f85c534f861c45c0c097ceb02f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128504
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-03  Julien Nabet  <serval2412@yahoo.fr>  [61f8ac1db7b4e3dbdc8e2d1e32a867e5cb699afb]

        coverity: swapped-arguments->swapped_arguments in vcl/print3
        
        Change-Id: I657cc2b99e84c0846891da0402b84a4ae668553f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129389
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-03  Mike Kaganski  <mike.kaganski@collabora.com>  [30483a6e0642c287d95e8d617e1a3da26e29f9f2]

        Use default argument
        
        Change-Id: I44e9c2e5de2c041f2839b14a057e1b88fd6ea01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129337
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [895a1e89e2b3e37eb1a2fd0dd494ddd385bd0456]

        SID_ATTR_GRAF_TRANSPARENCE and SID_ATTR_GRAF_MODE have conflicting types
        
        Meant to be SfxUInt16Item, until the below commit accidentally
        introduced SfxInt16Item usage.
        
        commit 4d814ec1518c98d2ca251a5a10287f40a427ea6e
            Author: Armin Le Grand <alg@apache.org>
            Date:   Wed Apr 24 09:50:54 2013 +0000
            Related: #i122111# Adapted pState usages in NotifyItemUpdate methods
        
        Change-Id: I2aff5cc1eea9257186b4da12a73f928503bc233c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-03  Justin Luth  <justin_luth@sil.org>  [1f13e12700af83734eb830e4aed04f701a2caabc]

        related tdf#90805 sw table: ensure border when setting border style
        
        When using uno:LineStyle to set a table's border style,
        add all borders if there are none at all.
        
        The thickness of this line is set in svx/source/tbxctrls/tbcontrl.cxx
        to ::Thin (which is different from ::VeryThin set by color and borders).
        
        Change-Id: I8af1e6a2447a3bb99f00b9c19708bd2a1208109d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127166
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-02-03  Justin Luth  <justin_luth@sil.org>  [71303d77febfd51a493ce797933143cc318818cf]

        tdf#147115 writerfilter: style is only default if default=true
        
        This was a dumb mistake in LO 2018 (so perhaps LO 6.2).
        Regression from commit 6b7f12f6108f136d60bd77e3787ef6a2632038cd
        
        Change-Id: I2adc642ffe9c2af1037fcc0a5d2b83c993511258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129386
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [98089907d9601f43d113dcf31734feb9df9e2de7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04988a9ba792fae28ce53c80cf73606b86c3ecec
          - tdf#147139 Wrong string for Gallery menu entry
            
            + some image refactor.
            
            Change-Id: I0d45f9c4ea37ace923f8ba08ecb141940ab0d92e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129382
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [023aefdd7551440080f3f6e2e447b4549e0a3481]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 56c146e68448db5622dc54823874ebb8605b55a9
          - make comments in example for TextStream localizable
            
            Change-Id: I4f18e6f5c2d3f8ec6ead759217178095d0c108a2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129383
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [8488f6edeed5e8a8225f5f8541887021b31a5a77]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 84169c6b03ae925d6b483c0c0141f28889c0bf56
          - make two sentences in Timer service localizable
            
            Change-Id: I39e7cd9bb39cc2905aa9fc36f3434dc70b8e5fe4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129390
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-03  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [34733d6eaeb1316354bcb8689ffe2b57b4efbf16]

        Colibre: Fix for tdf#147150 (same net type chart)
        
        Change-Id: I4831f6f1ec2fc28a746212a825cd3017a01d1e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129391
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-03  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ad613f7da1dd7371930ddbb41d1e0389944c72cf]

        Colibre: tdf#147106 Update chart type design
        
        Change-Id: I432af416fee44a78d8e4ef73b08404eadc8358b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129274
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-02-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ca657b98e49eb2282775f7919827062a7a0b4bfe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eaae254a25e283cff0c0303d1831e48cd6dc1642
          - tdf#147137 Unclear Text on decrease indent
            
            + some refactoring that includes icons
            
            Change-Id: Ia26b5c20f295546474a1cc42147c69a16d3a91e9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129379
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9d1fc948f929ab18d9c42745c66f30581bbc055b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c3eb8a242ee732d6789310b5a9dd0bf10b5a4c6a
          - tdf#147136 Fix help entry for "What is this?"
            
            Change-Id: I3429d0b496cb986e39797dd588c4789aba9614b6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129378
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e6d6842ba258192e04b435a99c3eaa479f8a2f29]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d3038cce3723b7b7a74a7723944e5c18bca6e5f1
          - tdf#147134 Fix help page on edit pivot table
            
            Change-Id: I9eafeead4048bbc2c2d83ed239ae120980b4e89e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129377
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [38d4f94788549f7f8118b28b03d9e056f994c841]

        tdf#147088: sc_subsequent_export_test2: Add unittest
        
        Change-Id: I5370911eba3ada6e518b2c4f50ed11a33c4c8ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129358
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-02  Miklos Vajna  <vmiklos@collabora.com>  [3e9975cf507e24e9c501575c501833164d217acc]

        tdf#137920 sw: avoid layout loop when inserting at-char anchored large image
        
        Regression from commit d250ca91c79f457102daf4da81446b7f130fb0ee (sw:
        insert image: set anchor to at-char by default, 2019-11-18), the problem
        was that the document has 2 pages, the first page would host the anchor
        of an inserted image and looped while creating/deleting a next page
        frame when updating the layout on inserting of an image.
        
        This problem was less visible before, as the at-para anchor is a
        different codepath, which was the previous default.
        
        The primary problem is that the loop in SwLayAction::Action() assumes
        that we make progress, so in case m_bAgain is set, then doing the layout
        again won't re-set m_bAgain, but it happened here.
        
        That happens because each iteration calls SwFrame::InsertPage(),
        followed by a SwPageFrame::DestroyImpl(). Examining the backtrace of the
        SwPageFrame ctor leads to SwTextFrame::FormatAdjust() which tries to
        split the text frame only in case it has either a number portion or a
        text portion, but the check there was incomplete: a "none" number format
        results in no number portion, leading to this loop.
        
        Fix the problem by checking for HasVisibleNumberingOrBullet() before
        assuming that we can split an empty text frame into two pieces where at
        least one of them is not empty.
        
        Change-Id: I454e1ec275ad6c00202e65b97adb79647d11a0b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129371
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e262770bf55e9ef6023cddefbfa5607bc744a2c4]

        Fix variable name
        
        It's just a comment, but so it is the same as in
        PropertyActionsOASIS.cxx
        
        Change-Id: I43b2b3c51f5e2e23dc273e1cf65ad7c5608b9366
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129311
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e0a6d27e93f634a868987ef869093d912d17d4a8]

        Fix variable name
        
        It passed "make check"
        
        Change-Id: I02c46c42c3e705849562d465a086801425e32828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129312
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [3ee6e4e7c2046c4124b5c34f053888d3ee0a5a53]

        Related tdf#66039: restore unit tests disabled temporarily
        
        Follow-up to 121cbc250b36290f0f8c7265fea57256dad69553
        "tdf#66039 DOCX: import textboxes (with tables, images etc.)
        in group shapes"
        
        Two tests have been restored. One of them had to be modified,
        where the test document has a pure VML shape inside, and after
        its reload, the shape has got a DML part with textboxes. This
        differs from the input, but verification handles it now.
        
        Change-Id: Ic71cd06496da7d07c09530770282c03c7438640e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128055
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-02  Stephan Bergmann  <sbergman@redhat.com>  [7f60111fe347e6b2f0412c3e6ea2150ac9fd3279]

        UBSan build missing RTTI now
        
        ...e.g. during CppunitTest_chart2_import2
        
        > [_RUN_____] Chart2ImportTest2::testTdf114179
        [...]
        > warn:sal.osl:1990837:1990837:sal/osl/unx/module.cxx:152: dlopen(instdir/program/libchartcontrollerlo.so, 257): instdir/program/libchartcontrollerlo.so: undefined symbol: _ZTIN5chart20RegressionCurveModelE
        [...]
        
        Change-Id: I2c89fef471139f7b5417aadf1321d2da4f4ffec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129367
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [af3316b6f6f10fe7713d5d4e761d1fd03878cb34]

        SbRtl_Spc is exactly the same as SbRtl_Space
        
        Change-Id: I0ccbffef348fc23ef5ca090ec2112abfe333e8e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129332
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-02  Tünde Tóth  <toth.tunde@nisz.hu>  [1bce0e3004e3ec9d62a3c43801f8f2e8ef5f7fdb]

        tdf#112209 PPTX import: fix grayscale effect on image filled shape
        
        Some image filled shapes with grayscale effect in PPTX documents
        created with PowerPoint were not grayscale in Impress.
        
        Change-Id: I0a89f283f525eb47c21c5d5fa788484d8074a7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128616
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [6c4bc632180c25b3ceb30e32383b3f5db8eaf0e2]

        Use OUStringBuffer in SbRtl_FormatNumber
        
        Change-Id: Ie3e187b7dd1329f8fae04042fa6375c4bde3fa57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129331
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-02  Tor Lillqvist  <tml@collabora.com>  [79e8c5dfa992c2b14320844f625d7ddb07b2cfd1]

        Add some source files for debugging convenience
        
        Change-Id: If54e8ed6c41afcaaeb6b629ffae447de7240a61f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129368
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ee91c0b0fa03a59581bbc67709756b565cddff52]

        Fix function name
        
        Change-Id: I53a9018ed96b66095ddfc87ad24dc32e2e5bb485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129319
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Heiko Tietze  <tietze.heiko@gmail.com>  [2c713f73bf4e654b5b437eaa5de232899252a49e]

        Bump Glade version to 3.38
        
        Change-Id: I05ee4ba0a3bc85d1fef1e381ead4c9c32360dcb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129352
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-02  Miklos Vajna  <vmiklos@collabora.com>  [d933dba2f1740c6289dd7650fdf249326978af56]

        flat-odf-cleanup: survive already missing settings/scripts
        
        If they are already removed, just don't do anything.
        
        Change-Id: I3ef09ea5de8841820d586b41ed6c86e78bd06b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129326
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-02  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [3b0a0e70cb67fc2e1f9999d2e8cbb9cfcd8c670e]

        Related tdf#66039 DOCX import: fix Z-order of group shapes
        
        A missing function resulted covered textboxes which weren't
        visible in group shapes.
        
        Follow-up to 121cbc250b36290f0f8c7265fea57256dad69553
        "tdf#66039 DOCX: import textboxes (with tables, images etc.)
        in group shapes".
        
        Change-Id: I08eb1c1cf4a4f4769af8812500b9cf9778b01e9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128279
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [8165c629be4e70ea188f3ccf2b8e913feec75da1]

        speed up bitmap rotation
        
        (*) use more cache-dense temporary arrays
        (*) use float instead of double - I cannot see a difference in results
        (*) tools::Long->sal_Int32, we don't need more than 32-bits for x/y
            coordinates
        
        Change-Id: I81a1da573735f183a7d2a117f6170cf373433e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-02  Dennis Francis  <dennis.francis@collabora.com>  [26a22407124314479c99b44559ffbbce8c261fa5]

        lokCalcRTL: negate the +ve shape handle X coordinate...
        
        ...from lok client as all shape X coordinates are negative in lok-RTL
        mode.
        
        Conflicts:
        	sc/source/ui/drawfunc/drawsh.cxx
        
        Change-Id: Ic4ba064888901109c85760bb0afda609b5d5942c
        (cherry picked from commit 3df583520ee03bad42df09db7dde4c0c683a228b)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129193
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-02  Luboš Luňák  <l.lunak@collabora.com>  [bff5d1a68a8b6f5776c5edb4ef0f919af1194d03]

        disable ScPosWnd completely in LOK mode
        
        366e328dc7f36061971c549c2d33d365026b65ca already mostly disabled it,
        but the instance was still created, and it sets up listening that
        results in ScPosWnd::FillRangeNames() getting called on every
        SfxLokHelper::setView(), which forms the major cost of the view
        switching.
        
        Change-Id: Ic16da4bdfb678d53a79da57e9bbdcb7fc59c576d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126481
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [ebcf824de8101fbbda01ee91010698977041f031]

        fix build
        
        Yesterday I pushed 5d05abcc7cb53fd7f7d7ed700e3c65e9da3e5dea
        < tdf#105998: sd_png_export_tests: Add unittest >
        Meanwhile, Armin pushed 4d535c4f867d86d40786788e5e5c9fd061a65673
        < tdf#126319 Corrected bitmap creation from metafile >
        making the size of the export shape to be 193x193 instead of
        192x192
        
        Change-Id: I366b7fc7d53db46a0beb1c5b588ac33ecabc343b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129348
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-02  Tibor Nagy  <nagy.tibor2@nisz.hu>  [22b66d4083d34cbce2b7b48daeed3152bf9877b7]

        tdf#137675 PPTX export: adding missing fill="none" to a:path
        
        Follow-up to commit 9310e47e2ce71348a16e5412131946348833f4b2
        "tdf#101122 DOCX custom shape export: remove bad fill".
        
        Change-Id: I2acdae3964c31ee366387d9938fe366405dcace9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127944
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-02  Mike Kaganski  <mike.kaganski@collabora.com>  [fd7a84aca0c94044bbc3bfb8852a1ae5115845bf]

        lok: find active SmViewShell reliably
        
        ... even after SfxViewShell::Current() had been set to parent document
        frame's viewshell (e.g., see LOKPostAsyncEvent grabbing focus, which
        replaces current frame and its associated viewshell).
        
        Change-Id: If63087f4c7f3f878ada93d93cc0af6c20a6c0a62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b13579fd2a811e32b06f34ebf932469cabe5fd27]

        Fix method name
        
        It passed "make check"
        
        Change-Id: Ic5ae07a7137d5fd72cbb77e716825fbb7f68a8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129313
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8064d229e5e1eebf0dd2a92f77e39e532485e772]

        Fix typos
        
        Change-Id: Ifac9aedb4972323da8b70d0a8f6f663513d2fbdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129310
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a4636e01b0ea18e7f8d2acd72670f503f0ce3f23]

        Fix typo
        
        Change-Id: I185a577c2614b6f1847a33136b2696d624167343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129316
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Luboš Luňák  <l.lunak@collabora.com>  [3b491e84dc2bec4117060bbbfa52b38b7871a220]

        fix std::min() used instead of std::max()
        
        In 534fc16a9f8cd01bb88485e2cf6b9cd33aed3745 I got this backwards,
        if the value is not supposed to be 0, then it should be at least
        the small value, not at most.
        
        Change-Id: Ic55d2b2402985d26e77be0d1605b9ba5985b5ac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129277
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-02  Dennis Francis  <dennis.francis@collabora.com>  [8839705b6f719f8f3bd5275eac57b78e26e4050b]

        lokCalcRTL: RTL negation for shape insertion
        
        Conflicts:
        	sc/source/ui/view/tabvwsh2.cxx
        
        Change-Id: I8e3bb21fadd05a7b67acce34bfdc354fefba076b
        (cherry picked from commit 18038bd35c01abf1aad69932c4a7e75988921289)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129192
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-02  Dennis Francis  <dennis.francis@collabora.com>  [cc827250ed249202afd97a84db13575648ed9b49]

        lokCalcRTL: shape selection: negate mouse X...
        
        as in LOK RTL mode draw objects have negated document X coordinate.
        
        Change-Id: Ie4c00fc0d1aa458a0aa6dd502be227cd6f82be3e
        (cherry picked from commit d423a86b3e063da02cfdb302eaa996ca54eed9d0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129191
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-02  Dennis Francis  <dennis.francis@collabora.com>  [a1e4dad6b98a2a5d4b4ef5db479d6f520331f1d1]

        lokCalcRTL: ensure +ve X coords in shape handles/selections msgs
        
        LOK client expects all coordinates to be in +ve document coordinates, so
        negate the negative X coordinates of LOK RTL shapes before sending the
        selection/handles messages.
        
        Conflicts:
        	svx/source/svdraw/svdmrkv.cxx
        
        Change-Id: I683581370c5b115efbe315224d6218ec2e74c7f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129190
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-02  Dennis Francis  <dennis.francis@collabora.com>  [2c250e8f5007e756afb794944f0be791e2d535f4]

        lokCalcRTL: shapes: do not send negative(X) invalidations
        
        LOK client expects tile invalidations in positive document coordinates
        irrespective of RTL flags.
        
        For this introduce a flag mbNegativeX in svx class SdrMarkView to
        indicate the case when all x coordinates are negated (this happens only
        for the LOK + Calc + RTL mode). Use this flag to counter negate the
        x coordinates before sending invalidation rectangles.
        
        Conflicts:
        	sc/source/ui/view/drawvie3.cxx
        
        Change-Id: I35d8142718b538e55b668a8ee18f3dd1fe433951
        (cherry picked from commit 5e37acbaaa0b0891829907331ecacd2d3b67526d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129195
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-02  Noel Grandin  <noelgrandin@gmail.com>  [9903e1f4957cf14039f4a3cef096cf7a08aedcc0]

        use more concrete types in chart2, RegressionCurveModel
        
        Change-Id: I0efecc48c63dc0fc62372eff7e9d5471666346b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-02  Michael Stahl  <michael.stahl@allotropia.de>  [bdf1d9b8151476531f2fbe06f66db260efcbc529]

        tdf#147006 sw_fieldmarkhide: fix crash when deleting fly with fieldmark
        
        The problem is similar to commit eef10be20a4c5108c68b19ccdda263c5ca852386,
        there is a fieldmark in a fly and this results in
        UpdateFramesForRemoveDeleteRedline() re-creating fly frames that have
        already been deleted in SwUndoFlyBase::DelFly(), and then the
        SwFlyAtContentFrame::SwClientNotify() crashes on a null anchor position
        in the SwFormat::ResetFormatAttr(RES_ANCHOR).
        
        This time the passed rPam is empty, after removing the dummy characters
        of the fieldmark; there isn't really anything to do in this case so
        just return.
        
        Change-Id: I475b8fcb0bcf94be58ff553454c261d75076303b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129308
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-02  Michael Stahl  <michael.stahl@allotropia.de>  [ea06852ee87531794f07710de496734a647a9062]

        tdf#147008 sw_fieldmarkhide: fix invalid NonTextFieldmark positions
        
        Commit ab6176e88f78d0b3aa2490fbc7858304c2d4a437 introduced a crash
        in ModelToViewHelper when the positions of a NonTextFieldmark are invalid.
        
        The NonTextFieldmark must always contain 1 CH_TXT_ATR_FORMELEMENT
        but after SplitNode() the position is
        (rr) p *pFieldMark->m_pPos1
        $2 = SwPosition (node 10, offset 1)
        (rr) p *pFieldMark->m_pPos2
        $3 = SwPosition (node 9, offset 0)
        
        This is because in ContentIdxStoreImpl::SaveBkmks() there is an
        asymmetry where the m_pPos2 is recorded to be wrongly corrected to node
        9, but if the positions were swapped so that m_pPos1 is the start
        position, then it will not be recorded and remain in node 10.
        
        So fix this by changing the NonTextFieldmark to insert its
        CH_TXT_ATR_FORMELEMENT differently.
        
        There is some very subtle code in SwTextNode::Update() that is again
        asymmetric and (non-obviously) prefers to move m_pPos2 and leave m_pPos1
        alone (by moving it to aTmpIdxReg) in case the positions are equal.
        
        But then the fieldmark code increments "rEnd" (which is really the
        m_pPos1 i.e. the start after InsertString() returns), and then
        decrements m_pPos2.
        
        So avoid the problem by removing these 2 pointless adjustments.
        
        Then it turns a bunch of tests fail because other code assumes that
        m_pPos1 is the end of the NonTextFieldmark, so fix
        MarkManager::changeFormFieldmarkType(), ModelToViewHelper and
        SwHistoryNoTextFieldmark to use GetMarkStart().
        
        Change-Id: I7c82f9a67661121662c95727e0f8f15e06d85a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129289
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-02  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [4d535c4f867d86d40786788e5e5c9fd061a65673]

        tdf#126319 Corrected bitmap creation from metafile
        
        The conversion from Metafile to Bitmap in GraphicExporter
        is based on metafiles which does just not deliver enough
        precision when getting the bounds to do the correct size
        calculation for the target Bitmap.
        So I changed that to use Primitive functionality what
        produces better data. That old fix/correction itself was
        based on hairlines only which is anyways no longer
        sufficient since LO uses less hairlines nowadays, what
        is good in general (They are a relic of non-AA times
        when it was not possible to paint/work with lines taller
        than one pixel).
        Thus, cases need to be solved more generic based on
        better data. It would also be good to change this
        to primitives completely, but that is too much for now.
        
        Change-Id: I71bd136b106ef8ff3ba51458c46df08269773c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129235
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-02-02  Miklos Vajna  <vmiklos@collabora.com>  [60a1f07049a817d4d3d7beb6c9b9da2571e2463b]

        sw: fix swapped inner vs outer border for Word-style right/bottom page borders
        
        This is similar to commit cf2690ae76b4250af32be7c8980b8d83b3611591 (sw:
        fix swapped inner vs outer border for Word-style bottom table borders,
        2022-01-13), but that was for outer table borders, this one is for page
        borders.
        
        The explicit mirroring is needed because Writer will automatically
        mirror, but Word mirrors in its document model, so we need to "mirror
        back" to get the matching rendering.
        
        Change-Id: I38fbf8adbc87ecd217a11b177840b0fede4cdf8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129281
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [74bcd46bbf4cb88112b054e5b192a995f3ef354a]

        Fix typo
        
        Change-Id: Ice5721d480567be4f8a4a79da6e01a6a389bf4bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129318
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [13053299999c1a1931c322761b7e3390d7bdaa1f]

        Fix typo
        
        Change-Id: I2532e97d2f7b4808832ef1ead5a928885ff7c3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129317
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-02  Regina Henschel  <rb.henschel@t-online.de>  [9877a0190e43241f4a5102e5d9cc7181f91d5a6f]

        tdf#107727 disable border in RTF export if not drawn
        
        A border of a text frame is not drawn, if it is really disabled or if
        its line style is None. The patch considers both cases. Previously the
        first case was missing.
        
        LO can disable single border lines and single border lines can have
        different styles. The patch uses a border line now, that is really
        drawn, to get the color and width. It uses the first one in order
        top, bottom, left, right.
        
        In theory RTF can describe disabling single border lines by using the
        flags fTopLine, fBottomLine, fLeftLine or fRightLine. But Word has
        only the ability to enable all or none of the border lines for an old
        kind text box as contained in an rtf-document. The current patch uses
        therefore this all-or-none approach too. It enables border if at least
        one is actually drawn, because that keeps the style settings for that
        border line. Previously all four border lines need to be drawn.
        
        If it is changed to use the flags fTopLine, fBottomLine, fLeftLine
        and fRightLine on export, then it would be possible to recover showing
        only single border lines on reimport. But that is out of scope here.
        
        Change-Id: Ib78604def154c133d3c93bc75a38731eb6b02294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129305
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-02  Miklos Vajna  <vmiklos@collabora.com>  [ea23f640d3bf06e4035a96ebe8b8c07a59d6f12c]

        CppunitTest_sw_ooxmlexport: remove no longer needed deny list
        
        This suite no longer has tests with such document names.
        
        Change-Id: I1fbe072c1663f657354493b8db1b69fcedd7f162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129304
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5e401d253891930e2836dbfc9e5118f340c3c575]

        Fix variable name
        
        It passed "make check"
        
        Change-Id: I3536d5ff0100cfa6b840aeded822e6e310c081dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129315
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [13d6bfa5bb017ad2b107c9db982369ea050ccbdf]

        convert OfaRefItem to a normal class
        
        only instantiated with one type, so just turn it into a normal class
        
        Change-Id: If3ae908f3e226ae9f4d3b81a7a7d9ba492ccda4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3c78bbee81a82bb50ed2b92944d9946348f73ad]

        sal_uLong -> sal_uInt16 slot id
        
        Change-Id: I312844466157a4029f6744a4b13306903229c51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [65d2c9ca4d930bd9352e0b51f45e163cf4393241]

        vba: test key-binding define by the macro
        
        VBA macro can be bound to a key shortcut, so it is executed when
        the key combination is hit. This checks that the macro gets bound
        to a specific key combination, when opening a document with such
        a macro.
        
        Change-Id: I1a7739ec9de745a82c130957236576bc694a86cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129268
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-02  Jim Raykowski  <raykowj@gmail.com>  [b4d5b4bdf45f76832b4c2714244cb8bf302eb092]

        SwNavigator: set bookmark member count
        
        Missed in commit 3771a81060f9e1f60ada37c3b7fa0a51b3042952
        
        Change-Id: Idce750efc266415ec092cef4e781ba5fbb7048bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129269
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-02-02  Justin Luth  <justin_luth@sil.org>  [9d50307b2e1fd26d415539d3ed8624c7a449e45b]

        tdf#129578 rtfimport: CJK char properties are not CS
        
        This fixes a LO 6.4/6.3.0.1 regression caused by
        commit fd95fb975b754d71d3750e85431a4e596a40e659
        which was focused on export, and not import.
        
        The code originally didn't have any
        mention of DBCH, so it used the default.
        However, in the 6.4 change, it was wrongly tied together
        with the Complex Script indicator.
        
        So revert that part of the change.
        Mark fixed the same problem in 7.1 for font size.
        
        Change-Id: I1c87ae856de93ebc693135585574f2eb144b214b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128113
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb7873cebd191143e2c0bcf944c8c777be5439dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc8821b42714d2b2856dad4b569e9337e5cfe014
          - Fix typo
            
            Change-Id: I9ee453c0ca7c2bb990e024a4881ef7940d2df35c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129309
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d3d1b8aa2b36986b7991c759133c3ddb8e2d516]

        tdf#107413: sw_rtfexport5: Add unittest
        
        Change-Id: I0f45d472f5ea59625c62b87dd5364bef19a6af27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129216
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-01  Luboš Luňák  <l.lunak@collabora.com>  [adc2ac31fb2763077e48658756946a39d91c8e12]

        adjust gradient drawing in vclcanvas (tdf#144073)
        
        For whatever strange reason the drawing does not use the given
        geometry, but something bigger. When I added direct drawing using
        VCL in a46cb5dc607d1d1af402ff3e8fce731e7427854d I naively assumed
        that the drawing area for the gradient would be the given area.
        
        Change-Id: Ia62cb0e5046e622679143eef56a3c6782781bf59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129298
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-01  Stephan Bergmann  <sbergman@redhat.com>  [2f3a0bfbfe110c0837b3c7e04f9ad0969d6e56e4]

        tdf#147088: Also handle U+FFFE, U+FFFF invalid XML 1.0 characters
        
        Change-Id: Ieec81fcde41e3508c6a9aa4250d7050db2fbb442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129296
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [3eac118b31ed569dbcec845fc32386ebd0022f73]

        sw: add note to DateFieldmark
        
        Change-Id: I50cc5fcc46e200116745cdfa1c3588436ac0aa46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129288
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [b72fcad54b7346615f8b8e703e243b72e5cca9f9]

        sw: change test to check the text content instead of just the length
        
        Change-Id: I7a0abd1c7520b441b80ed4da11d3b50c2367cd69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129287
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-01  Michael Stahl  <michael.stahl@allotropia.de>  [53c547d54c0e97b6fb3f054cdba1acacf40e3724]

        add bin/flat-odf-cleanup.py
        
        Change-Id: I0e4512762519a6ac4e4968cbeee3576cc7eeafa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129286
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-02-01  Caolán McNamara  <caolanm@redhat.com>  [62de82a45aa3e02ab3fd57b56ccf051a4bd5ac80]

        ofz: fix further build failure
        
        Change-Id: I0f4f6d4dec543780a2421193785d099c0b998f95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129307
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [aabc5b0f7c8e9cf6bb711815a67ff6b6e900b5aa]

        Slightly optimize truncateToLength and padToLength
        
        Change-Id: I7a18ce1f1c25e9f7a3c230109c741d6642786a13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129256
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-01  zhutyra  <zhutyra>  [5e8ceac64b66d1298037b939350d3adb86b37752]

        ensure bounds checking
        
        LIBREOFFICE-SBQ5TJRS
        
        Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  zhutyra  <zhutyra>  [dfcf8a75a975b09d3a39e4c753a717dc67036a3c]

        read of width/height uses wrong record size
        
        this initially went wrong at:
        
        commit b4fb7a437bb0ce987702b12008737756623618ac
        Date:   Mon May 23 21:38:40 2011 +0100
        
            fix up some more endian
        
        LIBREOFFICE-SBQ5TJRS
        
        Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129293
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  Luboš Luňák  <l.lunak@collabora.com>  [5dfafa8b1450d6952d7d8d87eb6b0d01c7afcee2]

        use comphelper::ScopeGuard instead of (ab)using std::unique_ptr
        
        Change-Id: Ie948064ea09b6fe415b28ec4165883bc78136619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129279
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-01  Jean-Pierre Ledure  <jp@ledure.be>  [50696923190add8131f8a2de63ba0ae8e9688d85]

        ScriptForge - (SF_Platform) refine locales
        
        So far, only SF_Platform.Locale was supported, returning
        the locale of the operating system.
        
        Now, 3 different locales may be considered:
        
        - SystemLocale: identical to Locale (still supported)
        - OfficeLocale: the locale associated with the LibreOffice
          installation
        - FormatLocale: the locale associated with how numbers and
          dates are formatted.
        
        Of course, in many cases all locales are identical. Anyway
        a distinction can be made.
        
        All these properties are read-only.
        
        Those properties are supported in Basic and Python evenly.
        
        Change-Id: I0792d49a052b1441a30ac231d61eda997dc4216a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129297
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d05abcc7cb53fd7f7d7ed700e3c65e9da3e5dea]

        tdf#105998: sd_png_export_tests: Add unittest
        
        Change-Id: I4a32d815b085f10ab9be1b861bdfdeb128ec242e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129275
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-01  Julien Nabet  <serval2412@yahoo.fr>  [270a9843711a562f93d4bce01a63040ee3ce95bd]

        Mysql/MariaDB: remove useless include+using and unused vars in mysqlc_driver
        
        BUNDLE_MARIADB seems to be useless since 2018 with:
        7430dfe2a4a3b13ffa248bf14a3a2ca87993f48d: loplugin:unusedmethods
        
        Change-Id: I75c9954f096e28c715f95073962241cafb787a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129173
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [9dc666afc81ec61c6ac3131fb13d6025433dd3b6]

        tdf#145030: sd: Add UItest
        
        Change-Id: I28cf3bf29905f66f458b9dfbb8ad31742f866d73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129280
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [c5a2d17d8daa3867399b217c279c52b17dab8d4e]

        fix build
        
        After de5aa409353c839483df21d47254fd2a508ab7d9
        < tdf#144851 Honor Selection When Applying Title Case Format >
        +1 from Jenkins was from Nov 11, 2021
        
        Change-Id: Idb16d9ca0fd72d84d77d0542a07d11dac830a734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129291
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-02-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0b397d8ef0a2615e8e6202804ca2f6cb58436fa5]

        tdf#147109: Optimize ScInterpreter::ScSubstitute
        
        Avoid multiple reallocations, making it freeze for e.g.
        
          =SUBSTITUTE(REPT(" ";1000000);" ";"")
        
        Change-Id: I269c0b06a0b3cbf9369cc47f33c2eea026b12903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129252
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-02-01  Miklos Vajna  <vmiklos@collabora.com>  [e6d031ae85214fc3d420d456c215242c20773b0f]

        sw: document SwXBookmark
        
        I.e. this is used not only for bookmarks, but also for fieldmarks.
        
        Change-Id: I01e7c0fdfcd8e2fc93217dd5bc7b2ba00709ecd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129236
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-02-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3ae013df7b8fccb2a4191b6d2d0c1648ca895f9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f31e889de0278a2b90525428389ab7d6af15314
          - Add 7.3 New features video to online Help
            
            Change-Id: I7249a32716c51fa07d63285037d35a3a563eba29
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129285
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-02-01  Justin Luth  <justin_luth@sil.org>  [18cc1240565e697859dd7d17058f91d5e01df929]

        tdf#141652 partial revert "Reset ShapeProperty priority...
        
        ... and handle only crop case."
        
        This reverts a portion of a tdf#134210 related, LO 7.2/7.1.2ish
        commit b90a67838e189f3aee6a50724c78c0a50d416970
        that was introduced for no apparent reason.
        
        I have no understanding about shapes, and so
        I have no idea why setting FillBitmap to an xGraphic
        is different from setting it to a name, but it makes
        a huge difference on the image size,
        and the crop values aren't scaled to the reduced size.
        
        Since this section of code looks like a cut/paste
        relic of early stages of developing the fix,
        lets just revert this portion since the original
        author has made no response at all to the regression report.
        
        Change-Id: I9488c419ceb41bd4ebd7b10494a52fb816654832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128260
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-01  Luboš Luňák  <l.lunak@collabora.com>  [8e4624b9b9fa1322592b73fe0dd6cb03be6fd57f]

        fix build
        
        cdd0a141094c9ceb690a702bb0 got pushed now after it got a Jenkins
        verification in September, and now fails because of my change
        from November.
        
        Change-Id: I6472444a05c8ff8f2e844dfff29c14a75a40ada1

2022-02-01  Jean-Pierre Ledure  <jp@ledure.be>  [57f6c7f4c913368f1ef34859e6c973c9c1660c65]

        ScriptForge - (SF_Exception) error messages give access to help page
        
        When ScriptForge detects an error in a user script,
        a message box is displayed with a summary of the
        syntax and validation rules the invoked method
        should respect, and/or any other reason the library
        has identified.
        
        Now the error message is completed with
        - the sentence "Do you want to receive more information
          about the '%1' method ?"
        - 2 buttons Yes/No (No being the default)
        
        When the Yes button is pressed the local browser opens
        the help page/anchor of the invoked service/method.
        
        The pot template and the english po files are modified.
        
        There is no difference between Basic and Python in this
        matter.
        
        Change-Id: Ie6210b9d108c9a1e98a46173504680e3985125b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129232
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-02-01  László Németh  <nemeth@numbertext.org>  [a2d9b270ce8537ebb59de50ebd07697fe9aa191b]

        tdf#146964 sw layout: fix reappearing deletion in Hide Changes
        
        mode at moving text.
        
        Test: in Hide Changes mode, move the selected text by
        cutting and pasting it with change tracking. Before the fix,
        hidden deletion reappeared again (only clicking on Show
        Changes and Hide Changes again fixed the layout).
        
        Regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving"
        
        Change-Id: Ia86f570bd634dd513fdbb93a83a929fd0ba4e273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129223
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-02-01  tushar  <tusharrai282@gmail.com>  [cdd0a141094c9ceb690a702bb0e3d64c368c1160]

        Fix issues of Data Transformations.
        
        * Corrected Delete column Transformation considering the case when
          multiple columns are provided as input.
        * Corrected implementation of Split Column Transformation.
        * Provided valid ranges for Sort Transformation and corrected
          implementation .
        
        Change-Id: I4558602f69bf4aa7836e1e84931fabd346f83465
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118368
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-01  Ahmet Hakan Çelik  <ahmethcelik@gmail.com>  [c82634d5a222120b3a95cff1b950a7f7a1f5ded1]

        tdf#64345: EDITING: Selected area looses selection when switching sheet
        
        Change-Id: Idf59c3968319053431741394e2ad218d7be6463d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119478
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-01  Luboš Luňák  <l.lunak@collabora.com>  [ddaebfb270c4b52ddebaf678a9352312c75247fa]

        fix the orientation combobox in the print dialog
        
        Changing the orientation value to anything else than 'Automatic'
        didn't do anything by default. This was because by default
        neither isPaperSizeFromUser() nor getPapersizeFromSetup()
        were set, so PrintDialog::setPaperOrientation() did nothing.
        It looks to me like 8cbdc6a068ad88fc43a98bd0f88 that introduced it
        was rather broken (not just this bug, but also e.g. the ugly
        modifying of the paper sizes by non-const reference from a const
        function). In fact this whole stuff still looks broken to me, why
        does it change paper size instead of just setting the orientation?
        It seems like the orientation gets reset, or maybe the setting
        was just a band-aid. I don't know how to fix that all though.
        
        Change-Id: If5fdf4c47e06f2b0797d27126d21b3451b8334cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129239
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-02-01  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [de5aa409353c839483df21d47254fd2a508ab7d9]

        tdf#144851 Honor Selection When Applying Title Case Format
        
        Prevents Title Case formmating from occuring outside of a
        user's selection. This is relevant if the user has started
        or ended a selection in the middle of a word.
        
        Change-Id: I39d8f2445acf5d9bb225bf8e3b36e2eb3b518857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124102
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-01  Justin Luth  <justin_luth@sil.org>  [bace2e0a80b939f7b1c666cf669ae99bc8758f05]

        related tdf#111733 svx: SfxVoidItem != SvxKerningItem
        
        When selecting text containing several different
        kerning values, the pItem returned is a VoidItem.
        
        This was showing up as random numbers in the
        TextCharacterSpacingControl spinbutton.
        
        Change-Id: I94cfc566daa42e0d8c3d403eb08af659f01e6d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129270
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-02-01  Szymon Kłos  <szymon.klos@collabora.com>  [490fcebb0dc160e56058a925e32f31ec7bcb6e4d]

        jsdialog: sidebar: enable animation panel effects
        
        - enable subcontrol .ui for jsdialogs in annimation panel
        - optimize to not recreate widget on every sidebar refresh
        - don't sent close message for whole sidebar when called from
          subcontrol
        
        This fixes widgets in annimation panel like: Direction listbox,
        or other replacements for selecting color, font etc. for font effect
        
        Change-Id: I5683ca9cefe384ed0d2a34d46936ddf4a9b45bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125757
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129170
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-01  Szymon Kłos  <szymon.klos@collabora.com>  [1f847d09246a5bd437248234ddc32f1c491acdc7]

        jsdialog: correctly clean statically created message dialogs
        
        - remember WindowId for statically created message dialogs
        - remember _DIALOG_ handle for message dialogs so response
          action can be done
        
        Change-Id: I1f6c9877e20dcbed4855b32d1e89d9ce3ff12111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125686
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129169
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-02-01  Szymon Kłos  <szymon.klos@collabora.com>  [2a5f0acacad765f2e25f2b9974b979b2b3a9d0cb]

        jsdialog: send popup when launched using Popover widget
        
        - enable validity listbox in online
        - flush when sending close popup to be sure it is sent
        
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Change-Id: Icf33e26c48b78ab60030a7395e8c7ee5462fbf7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125647
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129168

2022-02-01  Stephan Bergmann  <sbergman@redhat.com>  [bca18a7269781542f8ec20509148af621af580a3]

        loplugin:sallogareas
        
        Change-Id: Ic116d0207df6d37fed850357ad41d7778bf08df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129233
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-02-01  Caolán McNamara  <caolanm@redhat.com>  [4fa6ed7b0902e08de006bcb7534ba49696affb9f]

        tdf#145030 if all in effects list is unselected retain last marked obj
        
        in the slide selection
        
        Change-Id: Ibdd9c827fea3ef33f0ae385147b3fa633d5dff83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  Caolán McNamara  <caolanm@redhat.com>  [4c11673e78813dedb2089dd7e1a76a12da26cc8b]

        tdf#147032 unselect anything set_cursor selected as its side-effect
        
        Change-Id: I723bbd82fc01f644de3bfb2a80b4640cec0cfbca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  Caolán McNamara  <caolanm@redhat.com>  [8a1825bf896c8004a10275d93a626e472a52966c]

        Revert "tdf#145030 resync with empty selection if we unselected everything"
        
        This reverts commit ba535d8cbda1026823ce9796c20f97b7367d581f.
        
        Change-Id: I277e640c0f8ed0038e8ea867ddeef999a00b7b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129242
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-02-01  Noel Grandin  <noelgrandin@gmail.com>  [9706ddb47c99e1508a1e169225e6dde7b2eb3d0d]

        use more concrete types in chart2, RegressionCurveModel
        
        Change-Id: I844238da0ce0ce4aea308c652c341efa540149a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-02-01  Justin Luth  <justin_luth@sil.org>  [c0f914ad912796ef521ea151abf8ea7e9bc2f771]

        tdf#111733 TextCharacterSpacingControl::GrabFocus kerning spinbutton
        
        When the kerning menu opens, it defaulted to very tight,
        regardless of what the current setting was.
        However, the current value can easily be connected to the
        menu options, so lets do that.
        
        This depends on increasing the spinbutton range beyond -2.0,
        done via LO 7.4 commit 2334561bf15ec9b061636919efbd0e2a7b89e29b
        
        Change-Id: I0be0956bf1cc3604faecc691aeac70a5bbba807b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128909
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-02-01  Gülşah Köse  <gulsah.kose@collabora.com>  [48575b3eb856406d9de406cb1d2de23866b0178f]

        tdf#135843 Do not export unused border lines.
        
        Setting as XML_solidFill all borders caused wrong exported borders.
        All table parts aren't used for all table styles. We should set borderline
        if only they had used.
        
        Change-Id: I35b247f520c7d7862599ade2c6fdfb0d7efcd5c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129227
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-02-01  Dennis Francis  <dennis.francis@collabora.com>  [3b7aae08f26a2e6dc1112985024aa946550124aa]

        lokCalcRTL: adjustments for shapes rendering
        
        In LOK-RTL mode GetScrPos() always returns document pixel coordinates
        and not something mirrored w.r.t gridwindow width.
        
        * Grid offset must have the opposite sign since the SdrObjects/ranges
          have negative coordinates with no offset.
        
        * Drawing area rectangle and the pixel-offset for tile rendering device
          also needs adjustments when painting the drawing layers.
        
        Conflicts:
        	sc/source/ui/view/gridwin4.cxx
        
        Change-Id: I987a6876983aee129c06b3577918dbc62d6e7c4c
        (cherry picked from commit 2e7d02ab55754ffbc9e799c98cb7c8e37394a420)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129189
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-02-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [beb6c62e990599d91ac5d9183164c94d269027d3]

        vba: fix registering shortcuts keys defined by the vba macros
        
        On issue with registering was that the registering happened when
        the macro source was in	the process to be read into the library,
        which is just a	bit too	early, because the macro wasn't	found and
        not registered.
        Another	issue was with searching for the macro method (hasMacro),
        which doesn't search the same when the module name is known and
        when it isn't. This was	changed	so we just iterate through the
        modules	and call the same "FindMethod" method without any extra
        restrictions.
        
        Change-Id: I811cfcaca58e8dfa8bef6cf983a8aff2b60eba35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129196
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-02-01  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [d140817428cdbb519efa496f578bf6c054c94361]

        Avoid calling AVX code in library static initialization
        
        Despite 26072b8db7ba53f00c83197cb064229a76001989 and
        12c6b1ef6a824b09778163ec83fc44bb196e65db, Linux builds using
        RH devtoolset-7 gcc7 still hit occasional unit test crashes
        with illegal instructions.
        
        Backtrace is always:
        
        > #0  __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535) at core/sc/source/core/tool/arraysumAVX.cxx:20
        > #1  _GLOBAL__sub_I_arraysumAVX.cxx(void) () at core/sc/source/core/tool/arraysumAVX.cxx:112
        >
        
        So lets make sure initializer is run only on function entry.
        
        Change-Id: I69f5cb725e4d72fb346166b21870612473f974b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129246
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-02-01  Justin Luth  <justin_luth@sil.org>  [d098e027cb9899e31ae3ff7ba245b78a009681fb]

        tdf#120896 sc: commit change after PopupSpelling
        
        Although PopupSpelling visually has changed the screen,
        the underlying document still contained the
        old cached string or spelling status.
        Thus spell-check still thought it was spelled wrong,
        and right-clicking got very confused.
        
        Steps to reproduce:
        1.) type aaa and hit enter.  (spelling error noted)
        2.) right-click on "aaa" and chose various options.
        2a.) --- replace with a suggestion
        2b.) --- ignore word
        2c.) --- add to dictionary
        2d.) --- change language
        2d.) --- autocorrect
        (note we are still in editing mode)
        3.) right-click again on the new or approved word
        (no pop-up at all.)
        
        The fix is to stop editing, so the changes are
        applied to the various caches.
        
        Steps that should NOT stop editing the cell
        2e.) --- press ESC (or anything that cancels the pop-up)
        2f.) --- choose Autocorrect Options
        
        Change-Id: I9965ede6f6a5c31a811ff89abb687497306d6d1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126802
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-31  Stephan Bergmann  <sbergman@redhat.com>  [3564b5c6e93b2bf5881b359015efae351dbe8342]

        Adapt test to slow builds
        
        ...like my local ASan+UBSan build, which kept failing with
        
        >  Failed: TestReplacePerformance (t = 35 s)
        > Tests passed: 0
        > Tests failed: 1
        
        when the machine was under load during a parallelizing `make check`
        
        Change-Id: I59c81a61a29df7165f6fad33e3fe3da975f05ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129237
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-31  Caolán McNamara  <caolanm@redhat.com>  [eb22360b0f71ea087845b3db2c99ff48304f1a18]

        ofz: fix build, webpfuzzer missing from Repository.mk
        
        Change-Id: I8cd33d24b3289b00471aa10404dbb77343365d7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129245
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [98d6ed2aeb22b27fddf716a372f483b89ecea841]

        tdf#123973: sd_png_export_tests: Add unittest
        
        Change-Id: I4e3f97aef0865a00a771d8fa959422203a8f08f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129228
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [1a1e9f6b5929d5abeceeb49d0a7135bcd728ef7d]

        sd: move png export tests to their own file
        
        in preparation for a follow-up test for tdf#123973
        
        Change-Id: Iadedff75c42fa24390602a6eb914027157b53029
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128979
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [9266bc555f52e64b32f505c32ed5008fd3a14e7d]

        tdf#146994: sc_uicalc: Add unittest
        
        Change-Id: I2bd5c426bab4dfcef084db764bce0a91e6104495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129218
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [acab384edfaaa7142b567f4f53f8a39fe402f329]

        Update git submodules
        
        * Update translations from branch 'master'
          to cc24a4e892c5f8b1f5ee88c927013ffe4ab4c061
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I5ee0866633d20e924f2a3a885ae04419b4f4a125
            
2022-01-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [4669ee729fd25ce36f6b2b2d501481528f9f464b]

        tdf#146722: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I2a608a7007c50690e8c27252422b16619a65a07a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129217
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [44febe0ea815405ceb90ace5430f11fde634d89b]

        tdf#146999 draw, artifacts when scrolling up and down
        
        sigh, not even draw manages to get invalidation right
        
        regression from
            commit 9a850dd9f3c221660b6259bdfd64a77343f2256c
            Date:   Wed Jan 12 10:27:38 2022 +0200
        used cache value in ViewObjectContact::getPrimitive2DSequence (2nd
        attempt)
        
        Change-Id: I2692ac6933a3956eb98f48ff0875cdc0c933bd8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129221
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-31  Michael Weghorn  <m.weghorn@posteo.de>  [00c0ee8cf0fac0c933c5ae600e99a64b1c7d4397]

        tdf#147083 wina11y: Return a11y object instead of child ID
        
        Quoting MSAA doc about implementing child IDs [1]:
        
        > # How Servers Implement Child IDs
        >
        > Server developers can assign child IDs to both simple elements and
        > accessible objects. However, the recommended approach is to support the
        > standard Component Object Model (COM) interface IEnumVARIANT in every
        > accessible object that has children.
        >
        > If you implement IEnumVARIANT, you must:
        >
        > * Enumerate all children, both simple elements and accessible objects.
        >   Provide child IDs for all simple elements and provide the IDispatch to
        >   each accessible object.
        > * For accessible objects, set the vt member of the VARIANT to
        >   VT_DISPATCH. The pdispVal member must contain a pointer to the IDispatch
        >   interface. Note that the VARIANT is allocated and freed by the client.
        > * For simple elements, the child ID is any 32-bit positive integer.
        >   Note that zero and negative integers are reserved by Microsoft Active
        >   Accessibility. Set the VARIANT structure vt member to VT_I4 and the lVal
        >   member to the child ID.
        >
        > If you do not support IEnumVARIANT, you must assign child IDs and
        > number the children in each object sequentially starting with one.
        
        So far, LibreOffice was returning negative "child IDs" instead of pointers
        to accessible objects, which were not conformant to the MSAA
        specification and not accepted by NVDA as valid child IDs
        (s.a. discussion on the first version of my related NVDA pull request
        to fix the announcement of a single selected cell in Calc, [2]).
        
        Adapt that to return pointers to accessible objects and
        drop the now unused 'CMAccessible::Get_XAccChildID'.
        
        [1] https://docs.microsoft.com/en-us/windows/win32/winauto/how-servers-implement-child-ids
        [2] https://github.com/nvaccess/nvda/pull/13277
        
        Change-Id: I52a6f637adf334dee66627e6992451e6d81a7c9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129201
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-31  Michael Weghorn  <m.weghorn@posteo.de>  [d92b4dc5c9cfed8785f1c54217bc04bc20dc9681]

        wina11y: Drop unnecessary reinterpret_cast
        
        'IMAccessible' derives from 'IAccessible2', which in turn
        derives from 'IAccessible', so there's no need for any
        explicit cast from 'IMAccessible*' to 'IAccessible*'.
        
        Change-Id: Id5ad2d778f040364a1a056916a0ad1fe306707e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129200
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-31  Miklos Vajna  <vmiklos@collabora.com>  [1cdff0363727327d3bf0e7d5eb105e867ba2d806]

        sw: prefix members of SwPagePreview, SwScrollbar, ...
        
        ... sw::sidebar::PageStylesPanel and sw::sidebar::WrapPropertyPanel
        
        See tdf#94879 for motivation.
        
        Change-Id: I8eb8be59b9fad087fadb2735c46133aca4810415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129199
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-31  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [e1dc4a5815a56eef27d2c83f7971e0eb1ac09b45]

        Related tdf#66039 DOCX WPG import: Do not put extra paragraph at the end
        
        Regression from 121cbc250b36290f0f8c7265fea57256dad69553
        tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes
        
        Change-Id: I16195d1d3b0955d5686fe225bbba6def2c28ef93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128043
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Attila Bakos <bakos.attilakaroly@nisz.hu>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-31  Tibor Nagy  <nagy.tibor2@nisz.hu>  [b1865ecd67a4ea791ac24e3234d4ad3d2be9d1e3]

        tdf#130165 PPTX export: fix master objects visible property
        
        Follow-up to commit 4574a1ea408c2ac30042dca32d02207ec7add4da
        "tdf#146223 PPTX import: fix master objects visible property".
        
        Change-Id: I34e6132837d6c84974f8446978c59226a9a7d2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127908
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-31  Szymon Kłos  <szymon.klos@collabora.com>  [44f00ff35c7ea5ed2bfb56fe1abab8c72ead7316]

        Unit test for 0-byte ods detection
        
        Fixed by commit:
        d9a4e323555d01202dd15e71a3a32294bfd568cc
        Open empty (0 bytes) ods as spreadsheet
        
        Change-Id: I9b7220f46f5d00f6e4a73d6325dca51d7ea5b656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129166
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-31  Szymon Kłos  <szymon.klos@collabora.com>  [972760951b3c7a064f482b924c65fd670056d299]

        Open empty (0 bytes) ods as spreadsheet
        
        Before this patch we opened it with Writer UI because
        we didn't detect any filter with PREFFERED annotation
        
        Change-Id: I6262fb695b5fe20a377120f298f144e2cafbadc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129165
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-31  Szymon Kłos  <szymon.klos@collabora.com>  [496fcccfa655f250086c10de9e3c05f5fcf43f3f]

        jsonwriter: ensure correct number of bytes is available
        
        In some functions author forgot that addCommaBeforeField()
        can add additional two characters.
        
        I didn't change cases where more bytes than needed are requested.
        
        Additional change is that in debug mode there is a marker at the
        end of allocated buffer - we check that after every write to
        detect overflow. No need to request more space for a marker as
        we always allocate "needed size * 2".
        
        Change-Id: I28066797b0ba833e408b0a731abc01b7fd989da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129163
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-01-31  Michael Stahl  <michael.stahl@allotropia.de>  [9b5894e67d6ba820443c9f1130231be8c0278f82]

        ucb: webdav-curl: suppress libcurl proxy detection
        
        The UCP already reads proxy configuration from configmgr, including a
        list of hosts that should ignore proxy: Inet::Settings::ooInetNoProxy
        
        Hence also set an empty string with CURLOPT_PROXY, disabling the
        detect_proxy() function.
        
        (The neon library was never built with the libproxy dependency it
        needs to detect proxies.)
        
        Change-Id: I279d1b85dbdd2455791d393e634a1fa7c1c17ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129220
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-31  Tünde Tóth  <toth.tunde@nisz.hu>  [81abc0d7657f194804681415a786627ab71475e3]

        tdf#146066 chart: fix automatic axis scaling at dates
        
        Automatic scaling of the Y axis was incorrect
        when the X axis was a date axis and the last
        Y value was the highest value. To fix this,
        increase maximum date value by one month/year.
        
        Regression from commit ed2c880a691a0b179bbc92a8ce4ee49eac004035
        (tdf#133005 Chart: fix ODF import of date axis position).
        
        Change-Id: I0989ae8002e55f4ecfaf530ab845badb4409ecf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128209
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [36d75660ee5f3d2f9b433935e2c5d689767804fc]

        tdf#146860 Vertical alignment of text inside grouped shapes textbox incorrect
        
        some stupid side effect at work
        
        regression from
            commit c1916d3ab8f764e465f889334050ce7c863576b3
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed Dec 8 12:25:58 2021 +0200
            meRememberedAnimationKind is dead
        
        Change-Id: I7ba245a2096ed011f88e08f9d3a87021948e0b01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129219
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-31  Noel Grandin  <noelgrandin@gmail.com>  [9f36eba17042d14519de2409f7e3e581806b4ae6]

        use more concrete types in chart2, DataSeries
        
        Change-Id: I561d3d04cd534a30e774b0ed3fe1fb927a40c8df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-31  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cba7646dbc17cd026f3d2b29006f998ced540f76]

        Fix typo
        
        Change-Id: I472190c743dd26e88e3400f323ab52fa05c187d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129215
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-31  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4f3b6eac84e0a5381f6a9637d29418ae9353deb5]

        tdf#106899 - Remove header definition of buffer size
        
        Change-Id: Ia7e3cc32c067afa0f376e52e0eb5cdc83ca2e4b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129082
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-31  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [3b427f51f8965bfa8ec10733c1c804ed45d44896]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d5322f2e2832fa0567505439dfb1ad0e1af0d578
          - tdf#146847 Integer Division (\) operator help page
            
            Change-Id: I90505e2412eb53b3423407af52d6b358801c41f8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128543
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [24afbaab3a916df567589d2e5c1d56eaa1990ffe]

        Fix format string
        
        Change-Id: I18952bf6641175d25128b512ddfb56fd51767038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129083
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-31  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [cc3f3fa21244a2d9e104da1fc211cda91681e28d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4c31c91253c24933d762683045fb667da6c307bf
          - Improve recently touched string, we’re gonna retranslate it anyway
            
            Change-Id: Ieea3aa49cd9d3838c97fc288c3ee2a2d73138174
            
2022-01-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [663834876fd7dcc4d79240505e81f4b3ab1c5bab]

        SID_COPY_STREAM_IF_POSSIBLE is a SfxBoolItem
        
        The cast in appuno.cxx has been wrong since this constant was introduced
        in
            commit ecccc429183b999f2e488e991ef41bbee17604b6
            Author: Oliver Bolte <obo@openoffice.org>
            Date:   Mon Mar 27 08:33:39 2006 +0000
            INTEGRATION: CWS fwk36 (1.113.44); FILE MERGED
            2006/03/16 15:44:13 cd 1.113.44.2: #i46895# Fixed typos
            2006/03/16 14:55:24 mav 1.113.44.1: #i46895# allow to create a copy of the document if possible
        
        and I looked that cast when I added the TypedWhichId annotation.
        
        Change-Id: I1d541094e08633e5aced2423c30904506ca68368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6acab23396d1585565681a7cbc5be615eaccb7e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69fb882589e0accf46cdaef9cc5e01cc47358137
          - tdf#67026 Limitation of Calc precision documented
            
            Contents borrowed from M. Kaganski FAQ page at
            https://wiki.documentfoundation.org/Faq/Calc/Accuracy
            
            Change-Id: I89ba43c78d10ed4671b66ba0acc7df2e9947783a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128359
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-31  Dhiraj Holden  <dhiraj.holden@gmail.com>  [22c9ba31c6d455e5f1ddbf3f91e37fcb76140607]

        tdf#46037 remove confighelper from uiwriter tests
        
        Change-Id: I984d707e61d526791c60d57dd35727432f7f42bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129135
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-01-31  Justin Luth  <justin_luth@sil.org>  [2174b56ffb5817e42c8b4f6891214fcb67c55b30]

        tdf#83523 ruler: Invalidate full ruler rect on app bg change
        
        Instead of waiting for the application to restart,
        hack out an immediate invalidation of the ruler.
        
        Perhaps there is a better place to do this
        because the ruler background apparently IS
        changing, but it seems to require a hack
        to invalidate everything.
        
        Change-Id: I4a27cbaf484e96c19c71c04017c649e95bf80d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128733
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-31  Heiko Tietze  <tietze.heiko@gmail.com>  [ad1da9345b75dbe3ed9c503916c83c38d8a2e22f]

        Resolves tdf#146261 - Remember size of bookmark dialog
        
        Change-Id: I0c6f20692af88c603106d76c45c722cdb7deb118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126993
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-31  Caolán McNamara  <caolanm@redhat.com>  [afaaf8cdb0f00b068c7eb20c6de261a23b5b35dd]

        extract an initial webpfuzzer_seed_corpus.zip from the afl corpus
        
        Change-Id: Iae44bf9113cf78e2f7dcf20a4f987bda0614b2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129214
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-31  Mike Kaganski  <mike.kaganski@collabora.com>  [81a3d9b4bf471158de00d2fbb63fca420da94a38]

        tdf#132388: add unit test
        
        I hope that this performance test is OK. I chose 20 s threshold, as
        it works much faster on my system (under 4 s); it shouldn't be much
        slower elsewhere; and both the original bug, and the regression that
        followed the initial fix, made it execute orders of magnitute slower
        (I expect hours on fast systems).
        
        Change-Id: I75ee4c60e562473fe70a203faa94b48c5fbfb4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129203
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-31  Luboš Luňák  <l.lunak@collabora.com>  [60eaa424c5e213f31227008e1ed66a646491a360]

        support for the WebP image format (tdf#114532)
        
        This commit implements a WebP reader and writer for both lossless
        and lossy WebP, export dialog options for selecting lossless/lossy
        and quality for lossy, and various internal support for the format.
        
        Since writing WebP to e.g. ODT documents would make those images
        unreadable by previous versions with no WebP support, support
        for that is explicitly disabled in GraphicFilter, to be enabled
        somewhen later.
        
        Change-Id: I9b10f6da6faa78a0bb74415a92e9f163c14685f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128920
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-31  Justin Luth  <justin_luth@sil.org>  [b7d5ff4bbf41094b6579ae26023fbd686b060ce9]

        tdf#123658 sd search: partial UI unit test
        
        Windows and Mac OS are failing this unit test
        at an early stage, before the code change should
        even hit. So I am decoupling the unit test and
        running it prior to my patch to ensure that it
        really is some pre-existing issue and not
        related to my code.
        
        [Because lcl_search() was is not used in MAC/WIN,
        I was getting errors about an unused function,
        so I also used it in another test (where I
        got the code from in the first place).
        I verified that test still failed when
        the associated commit was reverted.
        I also made it bBackwards just to make sure
        the variable is used, even though irrelevant here.]
        
        Change-Id: I2413fa54b881d8e8eb8c6c8907fbc0d13c352e10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128729
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-31  Noel Grandin  <noelgrandin@gmail.com>  [47bbacb2b170c156fa0be751bc5213d412db8cff]

        use more concrete types in chart2, DataSeries
        
        Change-Id: Ib07ed6ec3321dc617cfec872d16683cf5de60907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129181
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [4537886ec1de8beed02c7aea34a50727bc058bbd]

        externals: always provide platform configure flags
        
        No idea why we just provided the platform flags when cross-
        compiling. In the curious case, where the host platform is
        detected as x86_64-pc-mingw32 per default and we actually
        want to override it with x86_64-pc-cygwin, we don't do a
        cross compile, but must override the host platform.
        
        But there is additional special handling needed for the omitted
        cross-platform build in the special case of --host=i686-pc-cygwin
        and --build=x86_64-pc-cygwin, where we deliberatly ignore cross
        building; Windows is already a slow build, so try to keep this
        optimization (AMD64 can execute x86 binaries).
        
        There is the theoretical case, where the externals config.guess
        would have detected something else and that "magically" even
        worked, while the LO detected triplet would fail, but this
        should be fixed in the external in any way.
        
        Change-Id: Ib7a9719e0e406fe90334b7611dc3f01b51692bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129153
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-31  Caolán McNamara  <caolanm@redhat.com>  [4d5cefb561535d968654c114b0ea9671e4e7771c]

        gtk4: use ToggleButtons if we want to show an image
        
        SAL_USE_VCLPLUGIN=gtk4 make screenshot
        
        now finally passes, so that's the end of this phase
        
        Change-Id: Iddb1e7d13a3218497419ae434b8bc4e2e80e74fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129185
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-31  Caolán McNamara  <caolanm@redhat.com>  [3bc0cebd7b4ec528b9f28ee361d9d7dbd5d8b5ef]

        upgrade to expat 2.4.4
        
        Change-Id: Ie141268793dc4332d8c253bec4e986894682c7a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-31  Dennis Francis  <dennis.francis@collabora.com>  [709111b40441294a0b48cb71feb7d6cf8b299656]

        lokCalcRTL: fix autofilter popup position
        
        Change-Id: Iecf41c286e28f849f77da47a0c5f73cbbc02986a
        (cherry picked from commit be329f241ee4953a039ab4bb22f46a5ac0ad5859)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128904
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-31  Dennis Francis  <dennis.francis@collabora.com>  [f7b439f5d510a021f5c7cce965d9fb09f9929a44]

        lokCalcRTL: fix autofilter button hit detection
        
        No mirroring needed when not in tile painting mode. All positions are
        in document coordinates.
        
        Conflicts:
        	sc/source/ui/view/gridwin2.cxx
        
        Change-Id: I45425e2ddce7f5ddc5086dcdce31bb6d081edc41
        (cherry picked from commit 2eb5f597c3b1c5a680d6e0f9d0719f9f6977e1a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128903
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-31  Dennis Francis  <dennis.francis@collabora.com>  [ce76f9245d678f4894e2d4148204b994f0032626]

        lokCalcRTL: Workaround to avoid DrawPoly ghost drawings
        
        Conflicts:
        	sc/source/ui/cctrl/dpcontrol.cxx
        
        Change-Id: Ib6c794766fe68305566a293892c9123d64a2fc47
        (cherry picked from commit 85a986f25956518978381df097b1f7d88477fd3d)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128902
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-31  Dennis Francis  <dennis.francis@collabora.com>  [324b76a3f76acd2bd00c2023a3fe990d4eefd12d]

        lokCalcRTL: draw autofilter buttons at correct coordinates
        
        Factor out the transformation from document coordinates to tile device
        coordinates in ScLokRTLContext.
        
        Conflicts:
        	sc/source/ui/view/gridwin4.cxx
        
        Change-Id: I426a179bff253233f6d45b67ddfde8b3bb1344a1
        (cherry picked from commit 0145c2c0e4c69d486693488fa24490ee4458349a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128901
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-31  Stanislav Horacek  <stanislav.horacek@gmail.com>  [5c138ac6a8334825ef171ac6291b66b277eb4288]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7dea7021f47a85d16260bbcd775897f36ffa9ee6
          - make title of method list localizable
            
            Change-Id: I8a1a8c1657c6390b8bcd7a42a6f6824293bf43f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129177
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-31  Eike Rathke  <erack@redhat.com>  [61cb699e88b3680becf78dc7b8bd514b2b7318a4]

        Resolves: tdf#146722 Force row label for single text with numeric to the right
        
        Note this *might* break other uses of the non-deterministic
        automatic labels where exactly this constellation previously lead
        to a column label. For which expecting a column label though makes
        less sense..
        
        Change-Id: Id85df7485f9b71620d8cbc404a981852d1567a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129187
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-30  Stanislav Horacek  <stanislav.horacek@gmail.com>  [12c6bff0e43b81b9017050f644bd87e865bbbf9e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05845e7cdac8b52eef41070a2f05445396058b92
          - fix format of UnoProperties method syntax
            
            Change-Id: I50ee4de218b1236283e3aaf76137edb8b79fb062
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129123
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-01-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7e6e0fd63eac57de0f76ab1efdb1283c22ad6e6c]

        tdf#108910, tdf#125496 - read/write index entries using utf8
        
        Always write an index concordance file using the utf8 encoding and read
        the index entries using the appropriate character set which is either
        utf8 or the os thread encoding.
        
        Change-Id: I5b30f4749f635bd51d8f0933ce5029d5303aef3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128745
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-30  Noel Grandin  <noelgrandin@gmail.com>  [c496412631c950f081d7696867db907fa313653a]

        use more concrete types in chart2, DataSeries
        
        Change-Id: Ida984d1701e2426958127845418365f6645a9043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Caolán McNamara  <caolanm@redhat.com>  [c5ab758bc3e1227e9ab3013d2fba4c2cd387e296]

        cid#1497923 Logically dead code
        
        and
        
        cid#1497924 Logically dead code
        
        Change-Id: I548c09b2394e263d88a48fe97490f5b63d7d693a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129171
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-30  Caolán McNamara  <caolanm@redhat.com>  [152752ad8552024209ca36b0eb13fea2893c5f96]

        ofz#44207 Integer-overflow
        
        Change-Id: Ia3cace5df71ec9dbf17d06f3c21b65a87025bfd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-30  Julien Nabet  <serval2412@yahoo.fr>  [e5c72fcf22e479871bc5a47f660bc56878db5626]

        Mysql/MariaDB: remove useless include+using + unused vars in mysqlc_connection
        
        + replace one time used define MYSQLC_URI_PREFIX
        
        Change-Id: Ia2ad5b2883f5f417bdbdcc7b39055bd5454c10f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129174
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-30  Jean-Pierre Ledure  <jp@ledure.be>  [9688e4970eed2b4bb4265df2a5781452a8ef5c52]

        ScriptForge - (SF_Session, SF_Document) add arguments to RunCommand()
        
        Next wiki page
         https://wiki.documentfoundation.org/Development/DispatchCommands
        facilitates the use of commands with the
        DispatchHelper service, including with arguments
        
        This commit
        - adds the RunCommand() method in the Session service
        - extends the scope of existing RunCommand() methods
          for the Document, Base, Calc and Writer services
          with the addition of command arguments
        Syntax by examples:
         (Basic)
          session.RunCommand("BasicIDEAppear", _
            "Document", "LibreOffice Macros & Dialogs", _
            "LibName", "ScriptForge", _
            "Name", "SF_Session", _
            "Line", 100)
         (Python) (1)
          session.RunCommand("BasicIDEAppear",
            "Document", "LibreOffice Macros & Dialogs",
            "LibName", "ScriptForge",
            "Name", "SF_Session",
            "Line", 100)
         (Python) (2)
          session.RunCommand("BasicIDEAppear",
            Document = "LibreOffice Macros & Dialogs",
            LibName = "ScriptForge",
            Name = "SF_Session",
            Line = 100)
        
        Change-Id: I60cd5eb1ed0a057420215ce7aebe92b2aafabd53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129175
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-01-30  Gabor Kelemen  <kelemeng@ubuntu.com>  [7b5193e2ae9eceba881163787b98c90f2310056d]

        Recheck modules [o-r]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I6b4b05a5e59b256653c4caf5297fffd601b45083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128845
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-30  Noel Grandin  <noelgrandin@gmail.com>  [026e2f437e969d75209ed05211e7f02349035b98]

        use more concrete types in chart2, RegressionCurveModel
        
        Change-Id: Ib4a5198f425577307ba437c73c61408b88d83dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129160
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Caolán McNamara  <caolanm@redhat.com>  [85cc59ba11f9334e0ed5f277607f5d9d63302856]

        Resolves: tdf#147013 transform the control point positions too
        
        Change-Id: Ia73317a79de66778d4b2d0face07ee4c41e328d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129157
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-30  Mike Kaganski  <mike.kaganski@collabora.com>  [a03b7d2a8d0f0fd7e710202bbeecf165f0fcd06a]

        tdf#132388: reimplement fix for tdf#142487
        
        Each call to css::i18n::XTextSearch::SearchForward transliterates input string,
        making performance of repeated calls unacceptable. So prepare the transliterated
        strings once, and use the offset sequence to map search results to indices into
        original string.
        
        Change-Id: Ie08dd5a408aca9a950067db285a480b41a3f9a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129162
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-30  Noel Grandin  <noelgrandin@gmail.com>  [63e8c2ccd39263b24f644c3d0394044a2613eb88]

        use more concrete types in chart2, Diagram
        
        Change-Id: Ieaee7c8381c19e3bfd3560d2f674bebf49afac56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [63400fa8c2333a519f0c3180dd490d2b4204fbc7]

        animations : use cppuhelper::BaseMutex
        
        Change-Id: Ife2b5480ad26c01388f5803f1cc5ae1e9e44a123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Noel Grandin  <noelgrandin@gmail.com>  [2f2e1bb1f7a247923fc2e25bbfb227756a1f7f2a]

        use more concrete types in chart2, Legend
        
        Change-Id: Ib6bff730c50fdda095482f2ebf2c4e7b63b0e26b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Noel Grandin  <noelgrandin@gmail.com>  [56c3cc776a7b0a487a794029f68a30244d65857b]

        use more getChartModel in ChartController
        
        avoids some unnecessary dynamic_cast
        
        Change-Id: I7389fd793c295d52cb6eb1b946199a2887544512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-30  Eike Rathke  <erack@redhat.com>  [7055ad90927d0d2e0dc5eab3774322e386fe2b15]

        Resolves: tdf#146994 InitOwnBlockMode() with current mark range or cursor pos
        
        This sets specifically the end position to the correct value. The
        start position and dependent logic if meBlockMode==Own is
        re-initialized in MarkCursor() via InitBlockMode(). Unfortunately
        that (calling MarkCursor()) happens after the end position was
        incremented in ExpandBlock(), previous with the wrong values.
        
        This new own block mode init now also makes it possible to
        expand/shrink the marked range after a paste or undo/redo, as it
        would be expected for any existing selection.
        
        Change-Id: Id26e4aa32896ec0c714e33b99dbf6702df144995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129158
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-29  Jim Raykowski  <raykowj@gmail.com>  [07982093f9751e333526252982292bf56d0990d3]

        SwNavigator: fix HasContentChanged always returns true
        
        when there are outline nodes in the frames, headers, footer section of
        the document model
        
        When outline nodes are in the frames, headers, footers section of the
        document model the outline content array, used to fill Writer Navigator
        content tree outline content type members and determine outline content
        change, will likely differ in order to that of the document model
        outline nodes array.
        
        Outline nodes in frames, headers, and footers section of the document
        model are placed at the beginning of the document model outline nodes
        array. Writer outline content array members are placed in document
        appearance order.
        
        This patch is done to correct comparison of old outline content array
        members to current outline content array members to determine outline
        level change.
        
        Change-Id: I5047aa0491a9d0f170fe61f381bf0982f97ff906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129063
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-29  Jim Raykowski  <raykowj@gmail.com>  [b0434f62c17b69e10caf05ad85a60f1bffdb5238]

        tdf#147041 Always show navigated heading at top of visible view area
        
        Revert to pre commit 1df2581cfffc87386c6de7614793b2d664244e5a behavior
        
        Change-Id: I06fe630bf0c0e611351e0e9a56361a3028f207d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129129
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [f65188894e06db8c2e28e11ad6466a435220b0c4]

        cid#1497868 Logically dead code
        
        given the surrounding bIsTiledRendering conditional
        
        Change-Id: Ic4853f0f840ca2b50937c29f5399b981c5f9bde2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129131
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [62539f7b7b6c67327dbe3d6d181c72cf4df3825d]

        gtk4: remove stray xalign
        
        Change-Id: I6a54b1547dbf78ec285dee59893ed3a899285997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129152
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [52c22530ad3dc2b1156f7e0555b75b4aaeaf7cb0]

        gtk4: dlsym hack for gdk_wayland_window_set_application_id not needed
        
        Change-Id: I66b6c0157759caf20df9af1642e0f5488d47dc22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129151
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [28e76f61ff3bb3d99329dc4157f5290d779402d9]

        gtk4: remove stray label_yalign
        
        Change-Id: Ia1eb3fe4fac9511c4d0b531bdbc722e420a96f1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129150
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [d5d49b49abb7284e95758d6831784824b127faa0]

        gtk4: remove stray xalign
        
        Change-Id: Ie4dbcdd97f815760370babb225c0cb287fecf1bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129149
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [71a737c5b81bdf9dce75f8f575da2f98e70f0418]

        tdf#146876: sd_layout_tests: Add unittest
        
        Change-Id: I4df3b153750be8d650f2c3b0ea5bd840b4397c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129134
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [5f10bae4559aa7eb6cc7988a320bfbf588b13edc]

        CppunitTest_sd_layout_tests: use CPPUNIT_TEST_FIXTURE
        
        This file is relatively new, convert it to use CPPUNIT_TEST_FIXTURE
        before it grows more. it's clearer and faster when writting
        new tests
        
        Change-Id: I15485642d64e5e3ed628155ffac4cfc70e8c3451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129132
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c3d5c9a08df77f9c0d0fd2493cf299dbad1a9dff]

        used TypedWhichId in the constructor of various svx *Item classes
        
        to act as an extra check that we have the association of Item and
        TypedWhichId annotations correct.
        
        (*) requires that I add an upcasting constructor to TypedWhichId
        
        (*) Make the field dialog stuff in writer use a new item id
        FN_FIELD_DIALOG_DOC_PROPS instead of abusing the
        existing SID_DOCINFO
        
        Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [58c849a94234f18eac020be66117aa2378487e2f]

        gtk4: remove unwanted caps-lock-warning from GtkSpinButton
        
        Change-Id: I723b13a5b012a89379cf6984a2b0fdd44ae932f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [c347a949786a2ae41740849480f16ecdc7d13f8a]

        gtk4: stray accidental GtkAction
        
        Change-Id: I9b0bd6608e0ead79aba8957a8e19ddd5e9094c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129147
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [75c6e50358d13ecf30121aa29018676113716e0d]

        gtk4: remove stray xalign
        
        Change-Id: If1b09a8697a813e5b5bca55f84d1c816a2081e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129146
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [3c574197052d2257cb6e544e937392cce68a1c90]

        gtk4: GtkStatusbar no longer has spacing
        
        so move the contents into a GtkBox which does
        
        Change-Id: I1ecbe91731fbd6c967e02cfc663a3855030c6796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129145
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [935b1a31b179802bdb2e430bff7e7b65d66975e1]

        resave with latest glade
        
        Change-Id: I49bd7743b9c17fcc84866eba52103fb35ba907d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129144
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [f6bbab3ec94e13bb652885eae4ab427c5d3df23c]

        gtk4: drop unnecessary stray 0.5 yalign
        
        Change-Id: I931332b95f96091b82944f5ef02420ea336c22b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129142
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [38fe7f4324b2051b3060eace86dd25ccccbc845b]

        resave with latest glade
        
        Change-Id: Icfa6ebf920491c811fee969c3a4620804a0ca48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [d0a34ccce9cc3915546c08235c9bb176bf4e8336]

        unwanted 'end' vertical align
        
        Change-Id: Ia1c6f0182f5006b68c6d963f41f53f7c0a8ae128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [30665ebf596039b5b2c72f7c6f892d7ea92cd9ea]

        resave with latest glade
        
        Change-Id: I7b8c189e5949c2266ea079eefa3239e4b801bb1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129139
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [b2786cb25f78aec212056810e2b9a8b61cec5d36]

        gtk4: remove stray 'gravity' property
        
        Change-Id: Ia68e3d96a7fbc381fc4215800b33dd21d2a38119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129138
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [77e78027ed87c7a299fc4a5056af6dab0d7d396d]

        gtk4: implement create_screenshot_window
        
        Change-Id: I7c99ead4a7a3107039d5ec096ad4a96463a8a432
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129137
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Noel Grandin  <noelgrandin@gmail.com>  [2781c7a50f3a9bcf48e84a8c5f450b16d576a8e6]

        use more concrete types in chart2, Legend
        
        Change-Id: Ifbf8ddd92eacd4caaf6fdaa061821222e543a1a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [8c5619b0272a67530760573993814fe7968a6c97]

        avoid dangling tmp files in hwp import
        
        if there is embedded data use office-binary-data to transport it
        instead of a temp file
        
        https: //issues.oasis-open.org/browse/OFFICE-3933
        Change-Id: Ia1cebf0770c99210df09f03dbb507451d9cf7764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129114
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e0175629fd0c6a99bb286f155e7a4855b8473d6]

        no need to call GetWhich on these SID_ values
        
        none of them are remapped (via the SfxItemfo stuff in the pool)
        
        Change-Id: Iefd38f1aac55e6059e2c57d102efb508bd1572b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Noel Grandin  <noelgrandin@gmail.com>  [1be7f03c8f6b945a0fc6514e1f5c1e228ea03547]

        use more concrete types in chart2, ChartType
        
        Change-Id: I78fe27e14993b7a6e5d27662282241b3007ac03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [6cd47f659c812bee33174e95f8353d1b67305061]

        CppunitTest_sw_rtfexport*: remove unused includes
        
        Change-Id: I38a439709b9a0c6a1298f21bdb9bf19c5121b827
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129127
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5b389b43fd31a7b405b647da4669aafdd04f77d7]

        Fix typos
        
        Change-Id: Id74af6775a04fee013df6a02b0261155908dc22f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129122
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [59dc59bb6e50d6d42d9fd6b82a165069d6e4bdbf]

        crashtesting: failure on import of ooo64618-1.ods
        
        since:
        
        commit 98f360b261d7b36fa63b10fadb86cf6f381cbd36
        Date:   Fri Jan 21 18:43:59 2022 +0200
        
            use more concrete types in chart2, BaseCoordinateSystem
        
        where the old situation was that the empty xDiagram caused
            Reference<XCoordinateSystemContainer> xCooSysCnt(xDiagram, uno::UNO_QUERY_THROW);
        to throw and get caught in the catch block of this try
        
        Change-Id: Id38793c28ccaf03bb84a7e8939ab76400092f002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129125
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Caolán McNamara  <caolanm@redhat.com>  [241641afe92fe525e45eb3b6d30f1a0f737d825c]

        use mktemp for FAKEDBRPM
        
        Change-Id: I53d0f027b60d681e16298531e3d890fafc43aea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129062
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-29  Noel Grandin  <noelgrandin@gmail.com>  [2fc38f8156d3fb1f58af223133acf8c543dbf09b]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I3c8ec5e24cae9b44164b0ad32623cfe3c42d553e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129112
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Justin Luth  <justin_luth@sil.org>  [2334561bf15ec9b061636919efbd0e2a7b89e29b]

        svx textcharacterspacingcontrol: allow smaller kerning
        
        On of the options in the kerning list is "very tight"
        which sets a -3 pt kerning. However, the custom spin
        button only allows down to -2 pt. Certainly we need to allow
        the user to adjust as much as the other options allow,
        and it only makes sense to allow as much negative
        kerning as positive kerning.
        Additionally, this field is supposed to show the
        REAL current value - which it can't do if the range
        of values is too limited.
        Finally, we can't pre-focus "very tight" very easily
        if that spin button cannot match the "very tight" value.
        
        [Based on testing, a too-small kerning gets treated
        as the smallest-possible-kerning and doesn't cause
        real problems.]
        
        In terms of positive kerning, the real maximum pt value seems
        to be 1638 before the denormalized version of it hits the sal_Int16
        maximum and then starts wrapping over into minimum values.
        
        Change-Id: I465fcd0bbf3ca310b203004b46632a9a1ee01a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128984
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f3682ecb8a40fe85b6525be9e73d49d76bb308b]

        fix loading file with very large number of styles
        
        where nCurrentPosition was wrapping around
        
        Change-Id: I839215f3138d58884f03509b6341147ef28edb4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [91622529794f0c519bec2938513a756f660e849c]

        CppunitTest_sc_subsequent_filters_test*: remove unused includes
        
        Change-Id: Ibd0e6e903622bba468dfffd019b19840caea97bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129128
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-29  Katarina Behrens  <bubli@bubli.org>  [4bb0ffa4684dada708ecdf727f4fc9f500a9bced]

        tdf#122708: on GetFocus, select something also when items are filtered
        
        Previously if nothing was selected, we picked item with ID 1 to
        select/highlight. But if a filter is active, such item may not
        match the active filter (case in point: document template no. 1
        matches 'Writer templates' filter, but not 'Impress templates' one)
        
        Try harder to find an item to select by looking at the list of
        filtered items too
        
        Change-Id: I9cb053b884dc724c7a6199ec002d83024ed83976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129117
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2022-01-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed79bc866bf5fee5037ceb55f582d10807244164]

        std::vector -> std::array for NfKeywordTable
        
        slightly faster to use std::array when we have a fixed size table
        
        Change-Id: I2080c18e6e550b10d521247c3734251ecace49fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129107
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-29  Kohei Yoshida  <kohei@libreoffice.org>  [e8032897b4a012d8e236211ee6e5ce89fb90492e]

        Standardize the flag name on bSkipEmptyCells.
        
        And document what the flag does. This corresponds with the "Skip
        empty cells" check box in the Paste Special dialog.
        
        Change-Id: Ic6cf9099efbee43f737a1472a4e275839e3d2c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129130
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2022-01-29  Jim Raykowski  <raykowj@gmail.com>  [3be0151bb619786b65499be413de04ad7c343cad]

        SwNavigator: check if unselect_all is needed
        
        Change-Id: I2a3914482167700bebf5ff8e67c34f7e31a0be9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129089
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-29  Dennis Francis  <dennis.francis@collabora.com>  [07e8233298965ed035bc4a285de19ca540e72246]

        lokCalcRTL: selection coords should be mirrored w.r.t output area
        
        Conflicts:
        	editeng/source/editeng/impedit.cxx
        	editeng/source/editeng/impedit.hxx
        
        Change-Id: I52bbbd4ca69a599c90c00d25513064b025f72bf4
        (cherry picked from commit 04a48ea15b9e692ded4f3012b41e765451669e46)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128900
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-29  Dennis Francis  <dennis.francis@collabora.com>  [86125f45b8cb608a5f9277fa8013f175496dfe4d]

        lokCalcRTL: fix editcell painting from other views as well
        
        Change-Id: Iac431996570f1f7eb091809442d8781ea60aa9b5
        (cherry picked from commit 455d4047487396c3c70d6113ac5d07deecb1d3a1)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128899
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-29  Dennis Francis  <dennis.francis@collabora.com>  [47c793529eabbd1395c7251b91a83efb853950d8]

        lokCalcRTL: edit cell painting: avoid indent...
        
        to match the behaviour in desktop Calc.
        
        Change-Id: I615255635500edf375b237abcab0a21ba6153cce
        (cherry picked from commit 48e6ef20c6bab7029e46d985d67a907147dd2adf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128898
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-29  Dennis Francis  <dennis.francis@collabora.com>  [5264f325ab8fc6b7523821a9fc7dd7157a7c66ba]

        lokCalcRTL: text cursor pos should be mirrored w.r.t output area
        
        Change-Id: Ied4e02d2dd30b7132ea1bc5f0d5b717355ed8b4f
        (cherry picked from commit 92d2035acc9d13fea46003a2b2650439d6a2f2fb)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128897
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-29  Dennis Francis  <dennis.francis@collabora.com>  [09ed49ae42b7c5368d0ef2774ba4e04aeb9bafdb]

        lokCalcRTL: fix editcell tile painting
        
        Don't use internal gridwindow width to invert the edit area coordinates.
        The gridwin width is not in sync with lok client width, and it seems
        making them in sync is non-trivial as it currently breaks other things.
        
        For tile-painting, always use the width of visible columns in the
        (combined-)tile area as the mirror width.
        
        In the case of LOK + RTL, because we avoid coordinate mirroring based on
        gridwin-width, any corresponding adjustments in edit engine paper-size,
        output area, visible area are done appropriately.
        
        Advantage of this approach is that the invalidation rectangles sent are
        in the document coordinates which is exactly what the client expects! So
        no additional coordinate reversal needed in core or in lok client for
        invalidation.
        
        Change-Id: I0b687a12dc9344fba9ee772111e7598888fa16bf
        (cherry picked from commit 8266f569c864ae309f362088d42dfb3b952c4267)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128896
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [651ff4f195804b206941e6316c5120a914d28b6b]

        CppunitTest_sc_ucalc*: remove unused includes
        
        Change-Id: Ia741cd86f36e41282c00670532c407ab896c471c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129126
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e35d6030bc1a5bfb4fb96e5499d75189c96b1a10]

        CppunitTest_sc_subsequent_export_test*: remove unused includes
        
        Change-Id: Idda4beeabab4a2445cc6d084ab910458e40e2532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129121
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Stephan Bergmann  <sbergman@redhat.com>  [d6cbf5532b843a3f189c9df2481c3003690dda73]

        Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf...
        
        ...plus --enable-mergelibs, like 4a2db3545a023468e191a5ec89a6343b7aef2ef2
        "Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf"
        
        Change-Id: I981ab82ecf2a459b384e243260a9611f6016acf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129119
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [43d04b91e59e17b872798e3227cbf44e9973506e]

        upgrade expat to 2.4.3 + CVE-2022-23852 and CVE-2022-23990
        
        wget https://github.com/libexpat/libexpat/pull/550.patch -O CVE-2022-23852.patch
        wget https://github.com/libexpat/libexpat/pull/551.patch -O CVE-2022-23990.patch
        
        Change-Id: I1f2694abd9f577e0b4fedbf27118b52be8a1a688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [ac41defa75365451db264379c514993679618208]

        Resolves: tdf#147016 ensure focus returns to document after popup closes
        
        Change-Id: I67e59afc08bc5983d473cb9dceb4fcefedeec117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129094
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Noel Grandin  <noelgrandin@gmail.com>  [642e98613ad4479f7601ea8cec78754546f563d1]

        use more concrete types in chart2, ChartModel
        
        Change-Id: Idd686acd0e8acaafcbbd18a4d6b0f298cc577784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Stephan Bergmann  <sbergman@redhat.com>  [38358c6b1630d1d003e3a6e8289ab36bf4d40546]

        Fix --with-latest-c++ build
        
        ...after e53ad7928fc1cbe9950efebe41f1aa5a1a289439 "CppunitTest_sw_uiwriter*:
        remove unused includes" and ba593f5fdfecd1b8b2036f99618b39e18facca55
        "CppunitTest_sw_ooxmlexport*: remove unused includes" caused
        
        > In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8,
        >                  from include/test/bootstrapfixture.hxx:20,
        >                  from sw/qa/inc/swmodeltestbase.hxx:26,
        >                  from sw/qa/extras/ooxmlexport/ooxmlexport.cxx:10:
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type = std::__cxx11::basic_string<char>]’:
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50:   required from ‘static std::string CppUnit::assertion_traits<T>::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58:   required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > sw/qa/extras/ooxmlexport/ooxmlexport.cxx:967:5:   required from here
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char16_t) [with _Traits = char_traits<char>]’
        >    25 |     ost << x;
        >       |     ~~~~^~~~
        > In file included from ~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:41,
        >                  from ~/gcc/trunk/inst/include/c++/12.0.1/memory:76,
        >                  from sw/qa/inc/swmodeltestbase.hxx:13:
        > ~/gcc/trunk/inst/include/c++/12.0.1/ostream:558:5: note: declared here
        >   558 |     operator<<(basic_ostream<char, _Traits>&, char16_t) = delete;
        >       |     ^~~~~~~~
        
        etc.
        
        Change-Id: I85087a8472eab923065ceb7ca6a1585f7ade75e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129118
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [231f827fabe0b4361c6e3e3245e7bf25a61dff44]

        use our own tempfile mechanism
        
        Change-Id: Ie7853ea8bd083d1056872cfad4323ff6cede235f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0176a6627755d938163ac64733929af79508f825]

        CppunitTest_sd_export_tests-ooxml*: remove unused includes
        
        Change-Id: I2811e151a9643f589e251e176d9c717472a5dd4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129099
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [1a403f67ec437c57d25a1ac2d0368dce6c571cbd]

        WASM set correct path to FS image unorc
        
        Guess in all the fixing when upstreaming all the WASM changes,
        that hunk got lost. This actually makes the WASM build run, not
        just compile.
        
        Change-Id: Ided621af284e62961eb47957d74b31871a30a2bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129105
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-28  Noel Grandin  <noelgrandin@gmail.com>  [6043d01496fe7e4c2000b2c3121aab759cab0fc3]

        use more concrete types in chart2, ModifyEventForwarder
        
        Change-Id: Ibd1102dbc269bb2e9a2afd67fae1e4ec7d51b1ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [66567d95ac103b8dba8736b554d9a061cf771fe8]

        CppunitTest_sw_layoutwriter*: remove unused includes
        
        Change-Id: I5f826496f7fbdbe6ef4139f0907c4baf04826bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129106
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Miklos Vajna  <vmiklos@collabora.com>  [8bac48991857d222f0e8f0c07b8c4e06649e1632]

        DOCX import: handle a subset of <w:ptab w:alignment="left">
        
        The case when we can map it to a line break. This way the page number is
        visually inside the rectangle shape that is behind the field.
        
        The test intentionally uses \n as-is for line-break, because
        SwASCWriter::WriteStream() uses \n in the LINEEND_LF case even on
        Windows (and not SAL_NEWLINE_STRING), while SAL_NEWLINE_STRING is used
        for paragraph-break.
        
        Change-Id: Ic85e57b2391bfac73507727b17240f4d85fc2698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129059
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-28  Noel Grandin  <noelgrandin@gmail.com>  [8c558549b7dc3348da207627663824043eed6204]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I0f1c50448f6ab744e40d8744340685f59f139261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [1dea71cbaa04a68aa496a146bb71a690aed0f88d]

        Related: tdf#146261 the intent it to keep the dialog within the screen
        
        not the parent allocation
        
        Change-Id: I1801fca14e864e4e18c0b42d7f3c3956e71f8e23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129115
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Stephan Bergmann  <sbergman@redhat.com>  [a4348ec796e6efe0edce7bb8bfa47b1fa95d0e34]

        We no longer know how to contact TLX anyway
        
        GCC 12 trunk started to warn
        
        > svtools/source/control/asynclink.cxx: In member function ‘void svtools::AsynchronLink::HandleCall_PostUserEvent(void*)’:
        > svtools/source/control/asynclink.cxx:76:15: error: storing the address of local variable ‘bDeleted’ in ‘*this.svtools::AsynchronLink::_pDeleted’ [-Werror=dangling-pointer=]
        >    76 |     _pDeleted = &bDeleted;
        >       |     ~~~~~~~~~~^~~~~~~~~~~
        > svtools/source/control/asynclink.cxx:75:10: note: ‘bDeleted’ declared here
        >    75 |     bool bDeleted = false;
        >       |          ^~~~~~~~
        > svtools/source/control/asynclink.cxx:75:10: note: ‘<unknown>’ declared here
        
        And while that is arguably a false warning, it points at some dubious code
        anyway:  The only reason for the AsynchronLink _bInCall and _pDeleted members is
        to potentially SAL_INFO some "valuable historical artefact", if
        AsynchronLink::Call were ever called recursively.  But
        0de7513cd73f1f35265e42f9a2b9befe81302c2c "osl::Mutex->std::mutex in
        AsynchronLink" apparently already argued that such recursive calls can never
        happen, as locking _aMutex in a recursive call of Call would now deadlock.
        
        Change-Id: I9ee47ac65652e40e23a37be3d0694fa1185b877a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129104
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [a93eedc5277f97d1b0c6dbfe8bf32a79869a9830]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9de15af089243bac07ce6ea9b7d505163c1b3f78
          - Create documentation for SFWidgets.Menu service
            
            Change-Id: Iaf0d10c2a1100d78098a99c93a2479d31b0f412b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128947
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [f4e2d99582252167b721eaf512658e2c3bfc6831]

        CppunitTest_sd_import_tests*: remove unused includes
        
        Change-Id: I5592b1cb244b220fac40db1680e3b9f726ba57e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Ramreiso Kashung  <ramreisog24@gmail.com>  [124059f64a87d8074a0be32d6cc5f74c71bf836e]

        tdf#145614: Convert #define to enum
        
        Change-Id: I1e89d233797461dc363bcd5021cc5347598ffff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128001
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ba593f5fdfecd1b8b2036f99618b39e18facca55]

        CppunitTest_sw_ooxmlexport*: remove unused includes
        
        Change-Id: Ic568ff3fc7eaf11dc496a0df685990acd3506b40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129091
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [2e4d32ed28f1c0d077e15ec7112918b79f982f70]

        CppunitTest_sw_uiwriter: no need to inherit from HtmlTestTools
        
        Change-Id: I62413319720e110503a186e65ba0f7167a0cb069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129093
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Justin Luth  <justin_luth@sil.org>  [9167d0aa28d1326d6a0074efbc13dfad0c5605ce]

        v2 tdf#134951 docxexport GUI: don't lose postponed comment
        
        A previous patch handled ooxmlexport's unit test failure.
        But saving interactively writes the nodes in a different
        order, and thus the flys process differently.
        The comment was still lost/moving into the textbox
        when manually testing.
        
        So, just make sure that comments are written out before
        a call to OutFlys().
        
        There is one other place where OutFlys is called that
        I didn't cover here. As a !bTextAtr, it doesn't seem
        likely to need it, plus I don't want to modify ANYTHING
        here without a proof document.
        
        Change-Id: Iaf3d19bd8d8f6744b9fea1c8686e59612c0a7ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128732
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e53ad7928fc1cbe9950efebe41f1aa5a1a289439]

        CppunitTest_sw_uiwriter*: remove unused includes
        
        Change-Id: I9f06f259df43ba5f5ea591427e86b1191c712dfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129087
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-28  Mike Kaganski  <mike.kaganski@collabora.com>  [a610126ea7288574ce57e1d253032786e7a23605]

        Temporary is enough here, to reduce scope
        
        Change-Id: I6621089d37b292acbd9a466097f6f76b3f73d5f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [e863b90a0e5fc90c3b824e4b0012f9389b87a3ac]

        ofz: Undefined-Shift
        
        Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [e3efba0f8187251cef8cb29c00a7eee5930ec70f]

        use mktemp for outdir
        
        Change-Id: I2aa04ab31c0966167dee47b1c0ea6d2228e262da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-28  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [5a67220831b994c4ecb83d93333eb76bffb88015]

        tdf#126319 Correct area(s) on selection export
        
        For shapes like TextFrames the export of the selected
        object(s) to Bitmap needed to be adapted. It should
        not reduce to minimal geometric necessary size.
        
        While reduction seems good initially as an idea this
        may change aspect ratio and expected size of the result
        by cutting off visually empty areas, e.g. the text
        distance areas to the shape's logical bounds.
        
        This also needed to be adapted to multi-selections
        accordingly.
        
        Change-Id: I85bffe60fcfc2e8da87f69936af30f64c26deead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129002
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-01-28  Caolán McNamara  <caolanm@redhat.com>  [2d603914d8162317b0ee7b77a73585c32bceb6da]

        use mktemp for UNPACKDIR
        
        Change-Id: If87fb28193f42e60419aa30b5ba7e4af6e05bbcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129057
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-28  Tor Lillqvist  <tml@collabora.com>  [7517fc118a1a230ff59f6c629316a8e7e1282dff]

        Enable pasting PDF into Impress
        
        Just like when doing Insert>Image... of a PDF file, you get a bitmap
        of the rendering of the first page of the PDF, not separately editable
        shapes or text. The pasted PDF document is included when exporting to
        .odp at least, just like for Insert>Image...
        
        I don't know how common or easy it is on Windows or various Linux
        desktops to have PDF format data on the clipboard, but at least on
        macOS, if you select a rectangle of a PDF document viewed in the
        Preview app, and do Edit>Copy, a PDF document is put on the
        pasteboard. (Preview also puts a TIFF rendering of the selection on
        the pasteboard, but for some reason that is of ridiculously low
        resolution. That is what used to get pasted into Impress previously.)
        
        Change-Id: Ic4b29deb12609dd839d8578779600156ff1ec48b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129049
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-28  Noel Grandin  <noelgrandin@gmail.com>  [00e28abcd33f7a52539cb0250b1cadcaf22f8f35]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: Ieb815775e069dd0d2cc36a2ab97b318e3b9f7a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [4abb554b164ae537a9854c40ab347d5cbfb125f5]

        no need to call GetWhich on these SID_ values
        
        none of them are remapped (via the SfxItemEntryInfo stuff in the pool)
        
        Change-Id: Ic4f1b13e1f35f7e67195a12c727ea2f088f8ddc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Miklos Vajna  <vmiklos@collabora.com>  [7875b1d4dab504d3b8a8632a1d8fd0afe910d7c3]

        sw: remove unused include in rtfexport
        
        It was the only '#if OSL_DEBUG_LEVEL > 1' in this file, so the include
        is definitely not used.
        
        Change-Id: I51e5a8ee04999f803fa7af92a4fd3a250b5c9c22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129064
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-28  Noel Grandin  <noelgrandin@gmail.com>  [59b6ffb3812fee3ed3d92602c31bc836efbee319]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I28b2af18ebd073701b4f8d3e9161d242396ce44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-28  Justin Luth  <justin_luth@sil.org>  [bb183ef3734cc3ccad81bd1ca1309f726c279870]

        related tdf#111733 TextCharacterSpacingControl sw draw: goto position tab
        
        The kerning button on the sidebar very unhelpfully
        did nothing at all in draw text (like textboxes).
        It should have brought the user directly to the "position" tab
        where the kerning property can be found.
        
        Change-Id: I89d4a180ac19e1e096b9157f3f32a254ff138940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129045
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-28  Justin Luth  <justin_luth@sil.org>  [e1f82fec6262db708f7911d20b62b74a4b4feab2]

        related tdf#11173 TextCharacterSpacingControl sw annot: goto position tab
        
        The kerning button on the sidebar very unhelpfully
        did nothing at all in draw text (like textboxes).
        It should have brought the user directly to the "position" tab
        where the kerning property can be found.
        
        Change-Id: I83687c732cc45bb28a835e878d0c91f10fb713ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129046
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-27  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [25aecb05a9835742266d216a0be6859c835d4415]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d16329383f7ff6ce14d00dec6670de29343bae26
          - Remove max-width from menus
            
            Change-Id: I7d59fb7161af41449cd0a1508f38143c241d50d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/129061
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-27  Jim Raykowski  <raykowj@gmail.com>  [3771a81060f9e1f60ada37c3b7fa0a51b3042952]

        SwNavigator: move content type init into SwContentType constructor
        
        With commit 7270ed7b81c12c8ba2e57b1a0d2ae084f8489d61 the Init function
        is no longer needed to help determine if content has changed. It's
        other duty of setting wheather content type can be edited or deleted or
        both, and if it has attachment for URL are moved to the constructor.
        
        Change-Id: Ie6cf2273baca8e84e2b0d4757794e91f0a1af2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126799
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [12be8dadfad2167ff4317935d30782626afa3eaf]

        no need to call GetWhich on these SID_ values
        
        none of them are remapped (via the SfxItemEntryInfo stuff in the pool)
        
        Change-Id: Ic7b5f2c3cc75a65bdf9c45f9522cc53954b4ba38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Noel Grandin  <noelgrandin@gmail.com>  [0e570fafd319c6567d798ff9e5530099c53312ee]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I76c3c094e94a21b65034dbc80bf98e4b4e3f57af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Noel Grandin  <noelgrandin@gmail.com>  [883ae88f297fc83a5a47a85dbcd1802a15e8eb3c]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: Iacbca66dbb5cfe617c5e8ca25796a7261f1ce10d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129053
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Justin Luth  <justin_luth@sil.org>  [7bd5f80185a349e3660d19b4b4a5d4dd1e2208e3]

        sw uno:Color: directly goto CHAR_DLG fonteffects tab
        
        .uno:Color started the character properties dialog,
        but opened whatever tab was last opened,
        and not the font-effects tab where color settings are found.
        
        This is related to tdf#111733.
        
        In terms of draw text (like textboxes) and comments
        it did nothing at all, so I fixed that too.
        
        I found this looking for other possible uses
        for CHAR_DLG_POSITION or CHAR_DLG_EFFECTS.
        
        I didn't find any pre-defined menu where this could
        be seen, but a customized menu adding the right
        "Font Color" (uno:Color) demonstrates the difference.
        There might be more EFFECTS, but this was the only one I found.
        
        Change-Id: If80f14e00d1a2ebae850a885df06fc556f77903a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129044
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [6c28ad0863a8ee1467280d7150e4b5642641a953]

        CppunitTest_sw_uiwriter4: use CPPUNIT_TEST_FIXTURE
        
        there are two reason why i'm doing this:
        1. Use the same way to define tests as CppunitTest_sw_uiwriter2
        and CppunitTest_sw_uiwriter3
        2. Over time, these files grow quite large, it's easier
        to split them when they use CPPUNIT_TEST_FIXTURE
        
        Change-Id: I4f23882b5622106a17cb14ed0525cfb3fecf88ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129058
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-27  Justin Luth  <justin_luth@sil.org>  [46b62f7777c6acdc2c94dc4b2ab79d38a10c49f9]

        v2 tdf#134951 docxexport: don't lose postponed comment
        
        This patch basically reverts and re-writes the original fix.
        
        Prior to mstahl's 7.4 commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3
           tdf#143039 tdf#143106 sw: DOCX export: don't export duplicate flys
        ooxmlexport5's comment would only last for one or two round-trips,
        and then be lost after that. It kept moving around into things
        like the fly itself, or the footnote.
        With mstahl's commit, it was lost immediately (same as Word 2016),
        and so the ooxmlexport5 unit test that broke was commented out.
        
        Change-Id: Ia7e881143f1243a3ab81bb94c02b57189f3730f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128703
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-27  Gabor Kelemen  <kelemeng@ubuntu.com>  [67478f9d637096781c9e3df64896b1ddaccc331b]

        Recheck modules [i-l]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I758bb27e93779e3df21c463714e49354748f446f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128715
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-27  Justin Luth  <justin_luth@sil.org>  [c73670326ce5b571c31d43721729a05a11563b01]

        related tdf#111733 TextCharacterSpacingControl sw: goto position tab
        
        The kerning button on the sidebar very unhelpfully launches
        the character properties dialog at the last-used tab,
        instead of bringing the user directly to the "position" tab
        where the kerning (.uno:Spacing) property can be found.
        
        Notes:
        -sw draw text (eg. textbox) does nothing - no dialog at all
        -sw comments also do nothing
        -sc does nothing
        -sd does nothing
        
        Somehow the sidebar is calling SID_ATTR_CHAR_KERNING,
        but I can't find out where. In any case, I have to change
        this SID_ATTR_CHAR_KERNING into SID_CHAR_DLG_POSITION
        for these "do nothing" situations. That can happen in
        separate commits for each situation.
        
        I basically copied SID_CHAR_DLG_EFFECTS which is
        explicitly called in underline's "more options",
        so it is used a bit differently.
        
        Change-Id: I833d54da3664b9c01325130a2c36bbbe90b2b878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129043
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [a951590bfb8d161096d87dbc953552f653318e92]

        let SfxDispatcher::fillPopupMenu operate on css::awt::XPopupMenu
        
        rather than need to be passed its internal PopupMenu
        
        Change-Id: Iff1106b80b71602cf8b77361086517f0e8f11c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129052
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [40456ff3d26c7edc2eb49c14077b2cbfa492af3c]

        tdf#144166 use border drawing style for VclScrolledWindow
        
        to avoid rounded rectangles on Windows.
        
        Change-Id: I29b9631ec0f3d125cbf103b0c12580a41f9b9264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [53b979fc1fff8a1e16cc84b956b022cc2672de2f]

        fix some TypedWhichId
        
        regression from
            commit 956dd4a202a0897b7ca1f8abd285af2cad47abb2
            Date:   Wed Dec 20 15:53:37 2017 +0200
            TypedWhichId in svx part 2
        
        Change-Id: I29babe072987f6b116df426d71f1fd6a24db2ab3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Eike Rathke  <erack@redhat.com>  [3480a1812d28c5d7e60bbec43f22af823234866a]

        Resolves: tdf#146602 Add Pennsylvania Dutch {pdc-US} locale data
        
        Co-authored-by: info@padutchdictionary.com
        Change-Id: I420847e2cfe1adc8fec6e30392557c1bc8b21ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128998
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-27  Julien Nabet  <serval2412@yahoo.fr>  [0adff3f2476f797843fb62d6810de90bfb333e10]

        tdf#126960, tdf#131330: FB make views editable+refresh auto after creation
        
        Change-Id: I78783056659a26cc8139d74eefc225de1a11ca7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129011
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [ba67202007f37d228a813c0915fd630bc2ff177b]

        Fix up "Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built"
        
            commit 5801b9fc65508391e130670f79a9af51f18d4e96
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Jan 27 08:17:54 2022 +0000
        
                Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built
        
        was missing the spaces for the 'filter' function, resulting
        in an '--enable-kf5 --enable-gtk3-kde5' build failing because
        "TRUETRUE" doesn't match "TRUE".
        
        Change-Id: I6dca8fb4cd9f58077ce08f51e003f3539f368f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129047
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [b5dd694e75c6eba1bbb33c64b41d82abf422530d]

        CppunitTest_sw_uiwriter: use CPPUNIT_TEST_FIXTURE
        
        there are two reason why i'm doing this:
        1. Use the same way to define tests as CppunitTest_sw_uiwriter2
        and CppunitTest_sw_uiwriter3
        2. Over the time, these files grow quite large, it's easier
        to split them when they use CPPUNIT_TEST_FIXTURE
        
        Change-Id: Ibdeb23f08237d15063e99637297615343cb7ee1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129042
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-27  Tor Lillqvist  <tml@collabora.com>  [f343d3ac4abcf974d2223b866aae17e7fe2f416a]

        Add more source files for debugging convenience
        
        Change-Id: I2b4cc77d1d7a873c3a3549a8132fd8a1d90525cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129048
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-27  Mike Kaganski  <mike.kaganski@collabora.com>  [75036ee916046b9d1bfd705b368ffe94cc7cfa79]

        Simplify oox::xls::UnitConverter and its uses
        
        Use o3tl::convert where it was used to convert between two fixed units.
        Simplify cases where several conversions were performed in a row.
        Use EMUs as UnitConverter base unit, to have simplest quotients and
        increase accuracy.
        
        Change-Id: I07c197dba470cfe289cef84e82b78547635cf9af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129016
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [5d388b94735e34ba445d65e1d5030a646aad7dbe]

        Related: tdf#146648 let SetWindowState size trump the initial layout pref size
        
        so a size can be restored from config and overrule the initial layout
        size which is calculated on first show.
        
        for existing cases, this changes behaviour if a dialog is shown,
        hidden, layout changed and then reshown and the new layout is smaller
        than the old layout. But that should align the behaviour of vcl
        layout-enabled widgets with gtk ones.
        
        Change-Id: I526f16dba91ccfd6d52c63a17e5dc51bf79750a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129037
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [4bd1cf9c1aece1bb405c157e6e6b2444517a27ae]

        CppunitTest_sw_uiwriter4: remove duplicated code
        
        No need to have blank file either, just pass nullptr to
        createSwDoc and it will create an empty file
        
        Change-Id: I05f34953b5c936d740babeee9a0489048a051cce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129036
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [3c4d16a9123ecd2df5036ccc59af92a83bb6c541]

        document what the workaround is for
        
        Change-Id: Icceaa0fde4100f9d49293bec1f826030cbae99ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129038
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [a161aa6234c8fb356dc23f8a52493a33d7865c53]

        sw_ooxmlexport: distribute the num of tests more equally
        
        Num of tests before:
        - ooxmlexport11: 124
        - ooxmlexport12: 25
        
        Num of tester after:
        - ooxmlexport11: 68
        - ooxmlexport12: 81
        
        Change-Id: I698d129d375783a2f1b0a944e077330a63defa2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [ce7519272269b7e9cc62342bdb48f395223e7bf9]

        toggle no-show-all on so the widgets don't appear despite visible off
        
        Change-Id: I9426c8d9e0149072c2318aff31b01227edd8149c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128989
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [06dbd2f50662d04d03140458afdff4501ea5827e]

        Fix typos
        
        Change-Id: I49d514a5977ef46a4ade52d53a9a47d56c718052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129041
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fed86b3ebb52cbf28ba2a561e67108e3a05a206]

        add some more TypeWhichId annotations
        
        and update the idl compiler to cope with namespaced class names
        
        Change-Id: I7b5242f872e358bc3c5584f543767719172aac83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129026
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Kevin Suo  <suokunlong@126.com>  [7e380a76e1f0faa90fdf8f0575053d4a1ca6e1de]

        Add CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY to numbring list
        
        Previously we only supported CIRCLED NUMBER ONE through CIRCLED NUMBER TWENTY.
        Unicode aready has CIRCLED NUMBER TWENTY ONE through CIRCLED NUMBER FIFTY.
        This improves Circled Numbering, especially for CJK.
        E.g. ➀, ➁, ➂, ... ㉑, ㉒, ㉓, ... ㊽, ㊾, ㊿.
        
        Change-Id: I7c4c851f03522fef9d44163da7450cf69aab3889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129015
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-27  Tor Lillqvist  <tml@collabora.com>  [0b18b6b85de4088280f0be88016424562b207c9d]

        Add more source files for debugging convenience
        
        Change-Id: If2f1d379e8e8694a3519d20eb3f425c0bbd381e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129032
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-27  Tor Lillqvist  <tml@collabora.com>  [9a828b4d1fcd5bfa471df404dc40fe3ddfccfbb9]

        Add a SAL_INFO listing types on pasteboard
        
        Change-Id: I6b1fa8da47f1140fc42287b05ee8d2afe5ee5d68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129031
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-27  Julien Nabet  <serval2412@yahoo.fr>  [4fa33b05e8128ced16240b663c1d3a487afb3f1d]

        Mysql/MariaDB: remove obsolete comment in views
        
        Obsolete after eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45
        Mysql/MariaDB: after creating a view then refresh, make it appear as a view
        For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete).
        
        Also, deleting a brand new created table works now.
        
        Of course, there are still pb with schema containing special characters like "`"
        
        In fact, the description of the previous commit was wrong since renaming a view
        still shows the table icon instead of view icon.
        You must reopen the file so the icon is ok.
        
        Change-Id: I2d27107db672e02af74e34a692309844ac310004
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129035
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-27  Michael Weghorn  <m.weghorn@posteo.de>  [5801b9fc65508391e130670f79a9af51f18d4e96]

        Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built
        
        Since
        
            commit 894450d6ebbb2d5e063d72b971580d1b8c10a5e3
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Tue Sep 28 08:36:44 2021 +0200
        
                Unify how Qt/KF build flags/libs are set
        
        the qt5/kf5 externals are used to set includes and
        compiler/linker flags for the gtk3_kde5 VCL plugin
        as well.
        
        However, the relevant link targets were only actually
        defined as needed when building the qt5 and kf5 VCL plugins
        was enabled as well.
        Adapt that so that building the gtk3_kde5 VCL plugin
        but not the qt5 and kf5 ones also works again
        (e.g. '--enable-gtk3-kde5 --disable-qt5 --disable-kf5').
        
        Change-Id: I65b75d7c2ccab71eade01aa2529fb45174056701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129022
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-27  Tor Lillqvist  <tml@collabora.com>  [0101c7918bb735d796bc1bc0d1705f995e41ee98]

        Add simple unit test for recent fix to take layoutInCell into consideration
        
        ... when a graphic is in table row.
        
        The test just checks that the IsFollowingTextFlow property gets set as
        true, it doesn't check that the table row height actually is correct
        or that the result looks correct.
        
        Change-Id: Ia6feec2b2a9bbff6e130f9542c15106750ff415d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128982
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [e0d6f0f9334e368ac45c68a41a736bb34fb31222]

        cid#1158096 silence Unchecked dynamic_cast
        
        Change-Id: I90ddb8c297117bc3e1255b55d45c55a7b6eb968a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [0c7c475080a8d941db74060428a4a607e1a39b33]

        cid#1497856 Unchecked dynamic_cast
        
        and
        
        cid#1497857 Unchecked dynamic_cast
        cid#1497858 Unchecked dynamic_cast
        cid#1497859 Unchecked dynamic_cast
        cid#1497860 Unchecked dynamic_cast
        cid#1497861 Unchecked dynamic_cast
        
        Change-Id: I29d3abc66e86bcf03ebcd6cc0ea9dfbc24f8ff3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Dennis Francis  <dennis.francis@collabora.com>  [6db8c9c40bbeb8c4c4601d0a05151754727a2dc6]

        lokCalcRTL: incorrect invalidation rectangle for...
        
        cell properties change. LOK client expects invalidation rectangle in
        document coordinates so ensure we don't mirror the x coordinate.
        
        Change-Id: I27bdd29a0d56c7a7b838b7669e3edde805dd1504
        (cherry picked from commit d819e543c13f85bd9c18fbe61c7983efab9d21c5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128895
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-27  Dennis Francis  <dennis.francis@collabora.com>  [2cb7c14eff5c4b2051c7039ba31239ee6a2a68f0]

        lokCalcRTL: selections: lokclients need exact document coordinates
        
        so do not do horizontal mirroring.
        
        Change-Id: I93432002810dacfeb609268f436bdf2cfecb3a60
        (cherry picked from commit 241909beda0d8985667435127e16bdf902850932)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128894
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [26d7f3440a0c9dd179ad407d48ce747699d678dd]

        Fix copying named DB when it doesn't contain a '_'
        
        Follow-up for d9472a5284fde7bb96823655efcb6eb31f405493
        
        Change-Id: Ib97d2c81159ddcf60604558f38e87af59cef86dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129023
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [a714dfbfb266839633156ef02669ee2c919d1615]

        use WindowStateMask::Size
        
        Change-Id: I6200e9fc20f8eb71bcf509fa739f4234c059f6da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129024
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Heiko Tietze  <tietze.heiko@gmail.com>  [ba0100be03c6bbc5ae10201bae340b3f7b7c4500]

        Resolves tdf#128258 - Draw a dotted line before hidden columns/rows
        
        Color and on/off configurable via Tools > Options > Application Colors
        
        Change-Id: Ia4b1e1c86f36d1b0f508a5b3e866a79418f16c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128553
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-27  Caolán McNamara  <caolanm@redhat.com>  [2f4f4cbeb8e50081d607b86b0475b93971c40ab8]

        add WindowStateMask::Size for convenience
        
        Change-Id: I8669a37b5495ba2150013f77c65357dc0f531a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129003
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9c3e9bbe780a394e43bf380cdedb6f2c9c8d8ac]

        fix ubsan downcast of SfxInt16Item
        
        source seems to be
            commit 0c8b1efbad48fa9697c0b1afbe4753bbbc3c4c5c
            Date:   Fri Oct 25 15:02:26 2019 +0200
            tdf#127759 Writer: add table row/column insert mode
        
        /sw/source/uibase/shells/tabsh.cxx:872:26: runtime error: downcast of
        address 0x60300137c2f0 which does not point to an object of type 'const
        SfxInt16Item'
        0x60300137c2f0: note: object is of type 'SfxUInt16Item'
        83 25 00 34  d0 ad 9b bc d1 2a 00 00  01 00 00 00 1f 50 00 be  03 00 be
        be be be be be  00 00 00 00
                      ^~~~~~~~~~~~~~~~~~~~~~~
                      vptr for 'SfxUInt16Item'
        /sw/source/uibase/shells/tabsh.cxx:872:26
        SfxRequest&) /workdir/SdiTarget/sw/sdi/swslots.hxx:12197:1
        const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:254:9
        const&, SfxRequest&, SfxCallMode)
        /sfx2/source/control/dispatch.cxx:753:9
        
        Change-Id: Ib5ac07778cf80c6826917d33912594e0b9027fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129021
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Julien Nabet  <serval2412@yahoo.fr>  [5e80706dca6395dfac006cfc7009a2dfe388a46e]

        Avoid warn:dbaccess:828616:828616:dbaccess/source/core/dataaccess/ModelImpl.cxx
        
        Just open an odb with embedded Firebird, browse tables panel and close LO
        Full message:
        warn:dbaccess:828616:828616:dbaccess/source/core/dataaccess/ModelImpl.cxx:923:
        com.sun.star.container.NoSuchElementException message: "/home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974:
        at /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974"
        
        Change-Id: Ibcea49b5ae28fd42cc1008c74f8cd5a9b7434068
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129009
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-27  Miklos Vajna  <vmiklos@collabora.com>  [0a78f4dfb7889c3d4807c9320bc21d3d4f8dec6e]

        sw: remove confusing 'using namespace objectpositioning' statements
        
        The using namespace declaration implicitly put the
        SwAnchoredObjectPosition definition into that namespace, but this is far
        from obvious when reading the code.
        
        Just put the definitions into the namespace, the way other code in sw/
        does this.
        
        Change-Id: I580c6bc5bb46a76364ddeeca021dd7b0e4369e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129007
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-27  Stephan Bergmann  <sbergman@redhat.com>  [a6f21bc32e746fd89ce963b1567ef78315612669]

        external/mdds: Avoid -Werror=use-after-free (GCC 12 trunk)
        
        > In file included from workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree.hpp:37,
        >                  from sc/inc/columnspanset.hxx:16,
        >                  from sc/source/core/data/columnspanset.cxx:10:
        > In function ‘void mdds::__st::intrusive_ptr_add_ref(node<T>*) [with T = mdds::flat_segment_tree<int, bool>]’,
        >     inlined from ‘boost::intrusive_ptr<T>::intrusive_ptr(const boost::intrusive_ptr<T>&) [with T = mdds::__st::node<mdds::flat_segment_tree<int, bool> >]’ at workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:93:44,
        >     inlined from ‘boost::intrusive_ptr<T>& boost::intrusive_ptr<T>::operator=(const boost::intrusive_ptr<T>&) [with T = mdds::__st::node<mdds::flat_segment_tree<int, bool> >]’ at workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:154:9,
        >     inlined from ‘mdds::flat_segment_tree<_Key, _Value>::flat_segment_tree(const mdds::flat_segment_tree<_Key, _Value>&) [with _Key = int; _Value = bool]’ at workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree_def.inl:88:25:
        > workdir/UnpackedTarball/mdds/include/mdds/node.hpp:244:10: error: pointer used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free]
        >   244 |     ++p->refcount;
        >       |       ~~~^~~~~~~~
        > In function ‘void mdds::__st::intrusive_ptr_release(node<T>*) [with T = mdds::flat_segment_tree<int, bool>]’,
        >     inlined from ‘void mdds::__st::intrusive_ptr_release(node<T>*) [with T = mdds::flat_segment_tree<int, bool>]’ at workdir/UnpackedTarball/mdds/include/mdds/node.hpp:248:13,
        >     inlined from ‘boost::intrusive_ptr<T>::~intrusive_ptr() [with T = mdds::__st::node<mdds::flat_segment_tree<int, bool> >]’ at workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:98:44,
        >     inlined from ‘boost::intrusive_ptr<T>& boost::intrusive_ptr<T>::operator=(const boost::intrusive_ptr<T>&) [with T = mdds::__st::node<mdds::flat_segment_tree<int, bool> >]’ at workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:154:9,
        >     inlined from ‘mdds::flat_segment_tree<_Key, _Value>::flat_segment_tree(const mdds::flat_segment_tree<_Key, _Value>&) [with _Key = int; _Value = bool]’ at workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree_def.inl:87:19:
        > workdir/UnpackedTarball/mdds/include/mdds/node.hpp:252:9: note: call to ‘void operator delete(void*, std::size_t)’ here
        >   252 |         delete p;
        >       |         ^~~~~~~~
        
        etc.  The warning is apparently new in GCC 12 trunk (see
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=671a283636de75f7ed638ee6b01ed2d44361b8b6>
        "Add -Wuse-after-free [PR80532]"), and I'm not entirely sure whether this
        is a true or false positive, but the fix looks somewhat plausible, and at least
        also my (Clang) ASan+UBSan build does a successful `make check` with (and
        without) this change.
        
        Change-Id: I63fafceba8d1b4e0ddd7cf2e58403a3bc763e53c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129008
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-27  Noel Grandin  <noelgrandin@gmail.com>  [e82192764485e7599af43c002d658b7b15c01f94]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: Icc1579520ae98efdd4191530e5f046555baad99e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Noel Grandin  <noelgrandin@gmail.com>  [93933e5f4ec1d8109717f89deb4029a8472d17ff]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I98890707708f2b6161e52ef5c1563cceb6e3e56a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Noel Grandin  <noelgrandin@gmail.com>  [a12b65360b6e8f1ace3e589117b4d172230a0050]

        use more concrete types in chart2, Diagram
        
        Change-Id: I768983241bf277d3b7688dca12a1ab441ac2373d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9a46a203515779ae40b7cfac36dbc22990e23290]

        vba: add tests for scrolling, range selecting, print area
        
        This adds various tests involving scrolling to a particular cell
        in the document, selecting whole ranges or ranges o filled cells
        and setting the print area.
        
        VBA functions:
        ActiveWindow.ScrollColumn
        ActiveWindow.ScrollRow
        Selection
        Selection.End(xlToRight)
        ActiveSheet.PageSetup.PrintArea
        
        Change-Id: Iacde9c513b41571e98234c12cc3b42a16de4b833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129014
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [93806a2831c93154981e3a6ef933270d0d5a6021]

        vba: add support for Application.WindowState + test
        
        This just delegates the get/set calls to ActiveWindow.WindowState
        which is already supported, but calling it directly on Application
        is also possible.
        
        Change-Id: Ibf6f55581a5c66a47ec4dd21cc8d0fe3558330ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129013
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cfa4867b0b66b0d4fb3aee52ca40d380e50de9ef]

        vba: test for selcting and hiding columns from a VBA Macro
        
        Change-Id: Ib954a98e3cf91253c416f358a114bf6b6eb549b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129012
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d9472a5284fde7bb96823655efcb6eb31f405493]

        tdf#145054 Copy named DBs too when copying sheet
        
        Change-Id: I5bf75a7188532776e70c7af64e88371638d76335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126916
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-01-27  Luboš Luňák  <l.lunak@collabora.com>  [35db43e328aca8290eda72806c52d757a8a5f579]

        do not require that an image type has a 3-character extension
        
        WebP does not (AFAIK) have any other extension other than .webp,
        so do require that. It's probably some old idea from the times
        when files were expected to have 3-character extensions.
        
        Change-Id: I64db137e1f5345f12d27ad85d83b715f6e10167d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128925
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [fdf5411bfebd639ef284f505a69b8610a294628c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 714b152de6a39ced79cc88ef17e51ef7efec5abc
          - tdf#147011 Fix text on entering data in Calc
            
            Change-Id: I713351de49059b643acceae8ce0f65f664829980
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128962
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2fe5fcfec107be93793f77f868763ab58da3573a]

        Remove debug import of time
        
        Change-Id: I847f7c1a641d85a9f0d74c04a94463c515337c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128819
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-26  Luboš Luňák  <l.lunak@collabora.com>  [534fc16a9f8cd01bb88485e2cf6b9cd33aed3745]

        make sure to not divide by zero when computing miter limit
        
        The minimal angle is valid only if the line join style is miter,
        and e.g. FileDefinitionWidgetDraw can call these with round join
        style and 0 angle, which would divide by 0. So either clamp
        the value or compute it only when needed.
        
        Change-Id: I2a2c71481490c03ec6d01b8e33cab991400adb35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129006
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-26  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [60c30241ecb0caeab077a7fb7215442405c42506]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f76d8e9280cbe1e726cfcf2d4a798c8cf418241
          - tdf#145693 tdf#141474 Chr ChrW method signatures
            
            Change-Id: If285713e1e76a661205f291f551cc988b194cd35
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128542
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [b9039e511ed103814dd3c2987c2e408aebb58058]

        ensure no 'angle' is used in a GtkLabel
        
        Change-Id: Id6231774fb1a8d12e771815023e661d5e0ac06a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129004
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [47a863f09d1c1273dc0c00cc03719d322b00ddd4]

        whack ubsan with a bigger hammer
        
        it seems to have trouble compiling code when it can't see
        chart::ChartModel, so just include it from one of the central
        headers.
        
        Change-Id: I1c96e40b5b8e35b74dd80f44d8c3243af5ba2626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Michael Stahl  <michael.stahl@allotropia.de>  [a3a6ef172927087d4d98f1e04f428de870db3c8c]

        ucb: add more webdav-curl doc to README
        
        Change-Id: I50a56f9f5b0126c46133129d62464e0171dc40f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128422
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-26  Michael Stahl  <michael.stahl@allotropia.de>  [cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc]

        tdf#139737 sw_fieldmarkhide: add unit test
        
        Change-Id: I4adfed97a00db71d42bbc4771221f5ebde43197c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128997
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-26  Michael Stahl  <michael.stahl@allotropia.de>  [94ef342679629c76eff2686243b423e926bbf680]

        tdf#139737 sw_fieldmarkhide: writerfilter: don't copy header/footer
        
        ... when inserting into an existing document.
        
        The header/footer will not be removed by SwUndoInserts::UndoImpl() and
        thus the extra nodes will screw up subsequent Undo actions.
        
        Inserting a header from a file is already disabled, but there is a
        function that copies from a preceding page style that was missing a
        check.
        
        This never worked and reportedly crashes since commit
        4dc1615c80e8e66d339dc86fa95bbc76e884d988
        
        Change-Id: I895d867ee9fd30a936144492f3ee1633d045fe8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128635
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-26  László Németh  <nemeth@numbertext.org>  [6ad9a3d74ef6eae3e645df12dedbe059acc180c4]

        tdf#146966 sw: fix inserting empty rows at copying multiple rows
        
        HTML expansion of the clipboard content is used to calculate the
        row number of the table on the clipboard. Skip its empty <tr></tr>
        elements here, similar to Paste As HTML in Edit->Paste Special->
        Paste Special... to avoid inserting empty rows (e.g. selecting and
        copying/moving 4 rows inserted 30 extra empty rows).
        
        Note: likely this was a regression, related to the new empty
        rows in the clipboard/expansion code.
        
        Change-Id: I58b16c7869c08cda7e2a2c21c3c03bf38446d826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128986
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [f25d5b11d6151978ad0b7ff3c4161cbc2cc8aded]

        this should be a normal dialog type
        
        Change-Id: I1c8c180b521c3cd2def35fca93b3f299ca437dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128996
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [59491bb67c52be32dd9a079a966ce802cbc0b239]

        resave with latest glade
        
        Change-Id: I10ebd53c21670242c49332068a1d5b04e6f58fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128995
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [5c6285da8b0008f3ba0499a4e297864d117d7906]

        warning is a dialog not a popup
        
        with the wrong setting it appears misplaced on a multi-monitor setup
        
        Change-Id: I43faeb72f6678a653feef82e0f0deaf87c039e9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128994
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a5f73561a54fa3be7413cd28568fc34d62eeffde]

        Fix typo
        
        Change-Id: I82c9da0e6ce73cc73a1edaf2d7d9559c5086fde9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128993
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c51799c88daabf000b506594b89220720ea814e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d6b5e9dd1371dd72703d271533bc08d2cef11ae
          - Fix typo
            
            Change-Id: I80d7efe7a970ea8646e725b7bbafbbf539cc33fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128992
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [c5cd7cd0fdc32969971c05a6b4fa0b5aeaa93a49]

        tdf#146992 gtk_window_set_attached_to causing widgets to shift
        
        which isn't desirable, just drop its use.
        
        Change-Id: Ic29efa9e785cad3c221e0ef37816b8485979e719
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128990
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [31d2ad2be96faf64f410c80cb32c3969015e15fc]

        resave with latest glade
        
        Change-Id: I87d9b78100cdecc2ab7bb21dbdf454d1ed90d57c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128991
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [385bd85b20b9efff981e7e5cd063a01d39e1e45a]

        tdf#146991 Insert chart -> crash
        
        regression from
            commit a2eaf99e46f370ffb3b73828c2bdc53dc193b9a4
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 14 10:56:50 2022 +0200
            make comphelper::OInterfaceContainerHelper4 more threadsafe
        
        Change-Id: I259d24a3f0c710222544797728c5f40ff299e50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Eike Rathke  <erack@redhat.com>  [083c93d406a9653922e9510509333f7ee64049fa]

        tdf#146602 Add Pennsylvania Dutch {pdc-US} 0x06AF to language list
        
        Change-Id: Icc4ed353c1bad53c2e2bf85fc098a50d66ee5b33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128988
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-26  Jim Raykowski  <raykowj@gmail.com>  [3bf0f94b373037fc662e617f936b57f9f317b142]

        tdf#146648 make find and replace dialog reopen at last position
        
        Makes the find and replace dialog reopen at the position it is closed/
        canceled.
        
        this may have begun to go wrong for X11 at:
        
        commit 8e2398bf72507324718e99fb2066c068c7898bf8
        Date:   Thu Jul 21 16:00:30 2011 +0200
        
            Remove supportsICCCMPos. Resize working with Sawfish anyway.
        
        Change-Id: I7bdcf5cd53dba8f3aacb1f2d1ae24f4bbcee26d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128473
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [65564103f619aa75eb1d1872546af78caf3144b6]

        update credits
        
        Change-Id: Ib2d0e2477b932669ab55b36abcfc347d43dc8bcd

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [be34fe06751609382b5a650d481cf4be2484c6f8]

        Related: tdf#146648 store last known position when visible to return later
        
        if the window is hidden when its position is queried, which is what vcl
        does and the assumption this is possible is baked in
        
        Change-Id: I5ce96a638796a6691eeb1b09578e23752a70c243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128980
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [92f84e7864c0c6729c2d87a03c1176ce565c8b99]

        ofz#44080 throw exception on a negative length
        
        Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128983
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [e4c5c92a2b01c5b46f0e8b0fa6567e15624527fc]

        Update git submodules
        
        * Update translations from branch 'master'
          to 59aa6716126252d64cbd897153f231389c05ac2d
          - update translations for 7.3.0 rc3
            
            and force-fix errors using pocheck
            
            Change-Id: Iedaea86e48ece63ca63d38dceac9b0d15091f38d
            
2022-01-26  Heiko Tietze  <tietze.heiko@gmail.com>  [008cfd5980f31c9e01b5cdbede33631d66f2fb56]

        Resolves tdf#144493 - Improve Promote/Demote wording
        
        Promote Chapter = Move Chapter Up
        Demote Chapter = Move Chapter Down
        Promote Level = Promote Outline Level
        Demote Level = Demote Outline Level
        
        Promote/Demote List Level reversed (promote to left,
        demote right)
        
        Change-Id: Ia119d311b1cf99d1b07e008e54a3bd070b87410c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128722
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [6661ea398523aaadb252abce0eac8a1f4f701ce7]

        suppress spurious gcc 10 warning
        
        /home/noel/libo3/sw/source/core/txtnode/modeltoviewhelper.cxx: In
        constructor ‘ModelToViewHelper::ModelToViewHelper(const SwTextNode&,
        const SwRootFrame*, ExpandMode)’:
        /home/noel/libo3/sw/source/core/txtnode/modeltoviewhelper.cxx:182:44:
        error: ‘*(int*)((char*)&oStartHidden +
        offsetof(std::optional<int>,std::optional<int>::<unnamed>.std::_Optional_base<int,
        true, true>::<unnamed>))’ may be used uninitialized in this function
        [-Werror=maybe-uninitialized]
        182 |                         aHiddenMulti.Select({*oStartHidden, i},
        true);
        |
        ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I88480daee070c77463b33dd1387865cc4ebf01cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4935bb372e3618eca105997c83101aa2b3d422e3]

        Revert "extra include needed for UBSAN"
        
        This reverts commit ddf7e388f2e45dbbe4e1f90610373dea530a425f.
        
        Reason for revert: because we're using a differnt approach with
        https://gerrit.libreoffice.org/c/core/+/128973
        
        Change-Id: I69bf4eda463052573d49379f7c4b4de155fbb3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [723a4d450cf67ba9aa48170cbf98000659146d18]

        weldPopupWindow is always implemented by now
        
        Change-Id: Ia1f2c6cb66175cd1dc0f5f42fb88f7a901d40cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128975
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [6443c79170d0082142850262b293ddec5fcde84b]

        move ToolBoxItemId into its own header
        
        Change-Id: I34838bee7ad27bfd60d92c26af7eb2de508686b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [26a750aac8e6bcf3d6d064ac6ef59005f95e34c3]

        give more wriggle room to avoid hitting max pixmap size with super hidpi
        
        Change-Id: I28d9b7333b52db46c85e6ae51265b3a4bd993c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128968
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  László Németh  <nemeth@numbertext.org>  [b15638440d692dd8cce55c0e936fbb82d24f8414]

        tdf#146857 sw change tracking: fix freezing during Undo
        
        Re-insertion of hundreds of redlines during Undo resulted
        freezing, because of the unnecessary call of isMoved() in
        SwRedlineTable::Insert(), multiplying the slow Undo by
        ~40 extra redline checkings around each redline to find
        tracke text movings.
        
        Stop unnecessary call of isMoved() during Undo in
        SwRedlineTable::Insert(). The state of isMoved bit i.e.
        the green/double strikethrough/underline redline
        formatting is preserved anyway.
        
        Regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving".
        
        Change-Id: Ib7901c7b4fefd87633c49ef252750b84dcdb73dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128762
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-26  Rash419  <rashesh.padia@collabora.com>  [b37e3e8c8c545a0776a9fcdbad3cb752162d2e3d]

        svgexport: fix: attribute id redefined
        
        If there is a id for empty paragraph exist we need to create a empty
        text paragraph to accomodate the id if we don't do that then we
        get multiple id attribute on same element for example:
        <tspan id="id14" id="id15" id="id17" class="TextParagraph">
        
        Change-Id: I41c21dc94deef93e423aaff2248f6931fa6ca8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128856
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128924
        Tested-by: Jenkins

2022-01-26  Dennis Francis  <dennis.francis@collabora.com>  [83d8a49c2a4357e1dcfb4b046da8a57db7bcb4ed]

        lokCalcRTL: no internal width based mirroring in GetPosFromPixel
        
        The gridwindow width is historically not synced with the visible area in
        client. Mirroring is not necessary when the client is already sending
        the true document coordinates of the mouse events etc.
        
        Change-Id: I74573be406c512324f4c5db0c53fbc12374b88c8
        (cherry picked from commit ef3c67beb96df80179b46bb6d5116d4a5cab7f77)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128893
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-26  Dennis Francis  <dennis.francis@collabora.com>  [7c5bb09b0b082dbba57262e11162dd6fa077f253]

        lokCalcRTL: provide sheet RTL flags to client
        
        Change-Id: If881fdea1c6bae10735cfde624ad6f4f3a34e389
        (cherry picked from commit 1ebd27ac521f78f9cc2124573d85b03b533e8653)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128892
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-26  Caolán McNamara  <caolanm@redhat.com>  [7600afa82505ba4f5b78800aa95855d01bb766fc]

        split two paragraph warning into primary and secondary messages
        
        Change-Id: Ie3bd9205a549ac55a0e5c7b9a444928b0fd80174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-26  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [87866def6bfe2ee91be34a5ce37b79d6da881617]

        tdf#123973 fix missing MasterPage content in export
        
        The old fix tdf#96922 is no longer needed, so I remove it now.
        It prevents MasterPage content to be included in export. Checked
        that task is fixed && old task does bnot re-appear.
        
        Change-Id: I8b6923e01f6e24f662288e24d26634c06c9527f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128940
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-01-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [10692be9472584c2dc49d298afd0192fb9ebfe86]

        tdf#146876 PPTX: various graphical elements misplaced
        
        Revert "use cache value in ViewContact"
        This reverts commit 2e162bb1e8521ad8cd8148e0a18adc3eebadd710.
        
        Apparently invalidation is not reliable anywhere for ViewContact
        
        Change-Id: I1ec40f27de77859a55bf00b80d029fa7181b4492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Miklos Vajna  <vmiklos@collabora.com>  [d0451dcf96508bf4d75c8147168f974ad3ebf03f]

        desktop lok, export options: allow passing through a JSON string as-is
        
        setFormatSpecificFilterData() sets useful defaults, but the PDF export
        code has the (sane) behavior of preferring FilterData over
        FilterOptions, so in case we explicitly got a JSON string in
        FilterOptions to in fact set FilterData, then leave FilterData empty.
        
        Change-Id: I20e8094bf431782fe0f5d68e3ec630e1274e30c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128970
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-26  Michael Stahl  <michael.stahl@allotropia.de>  [822b551f6ca92c9d4a8fb17dfc7ba28c272794cc]

        gbuild: fix spurious rebuilds from gb_LinkTarget__use_libraries
        
        Apparently the eval inside of "ifeq" needs to be escaped, currently both
        branches of the "ifeq" are evaluated and generate makefile dependencies,
        which causes spurious rebuild of Library_salhelper with
        DISABLE_DYNLOADING unset from:
         make Library_salhelper && touch -c ../master/sal/osl/all/compat.cxx && make Library_salhelper
        
        (regression from ecc50f56b3282ec3b0364101d860f22fe8da9042)
        
        Change-Id: I8b5607b7a172c8b4b05abeaf4d5ff3a68d53cb14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128930
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-26  Mike Kaganski  <mike.kaganski@collabora.com>  [bc1b2b03718b596506db2acedd6dad10f489d9fe]

        Simplify error COM handling using exceptions
        
        Change-Id: I2514e39bba8debcbdbb60929d2ca2f1ba3aaa2e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128456
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-26  Noel Grandin  <noelgrandin@gmail.com>  [b8cbb6930febadc9ae8839c9a21c4a20eb6fb609]

        use more concrete types in chart2, Diagram
        
        Change-Id: I5a836ccfe3c3c071b42664ba340ef18ff0e4ba91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Noel Grandin  <noelgrandin@gmail.com>  [ea00a6ce3b5e15ac2640983cfaaf11755d233644]

        use more concrete types in chart2, Diagram
        
        Change-Id: I8640175f493d89bea7eb4780b4cbebf7d0b74a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Noel Grandin  <noelgrandin@gmail.com>  [f4dd0dfd27201152b1e39c35302e1ca9c6ce12b6]

        remove now unused function
        
        Change-Id: Ic59756b8cecef026e8583bc378cedcc1b6e3e88a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128944
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-26  Dennis Francis  <dennis.francis@collabora.com>  [688051edf59a311371b84ea34db4991d3a164d52]

        lok: copy over the alpha channel too for cairo...
        
        ...based svp-graphics
        
        Conflicts:
        	vcl/source/gdi/bmpacc2.cxx
        
        Change-Id: I653a8e4048c712911f44f610e13c7f6c3e323de2
        (cherry picked from commit a9c473c3306e28462f9a1898a94277cf0adcbe5e)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128891
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-26  yalda  <yalda.ef@gmail.com>  [e9fce801c2a888b76fd8230343b04f72b5b6b5ce]

        tdf#139734 deleting redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I5cd2d05913f5c90499e3454e108d43ad75eee09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128888
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-25  Julien Nabet  <serval2412@yahoo.fr>  [eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45]

        Mysql/MariaDB: after creating a view then refresh, make it appear as a view
        
        For this, I took example on hsqldb part this time (instead of Firebird which is uncomplete).
        
        Also, deleting a brand new created table works now.
        
        Of course, there are still pb with schema containing special characters like "`"
        
        Change-Id: I4849f412ed5b3c2f35fbb4caaf06577828cc255a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128943
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [67240ca4191bfda561b2949905d29e6c2ed4a09f]

        don't use oversized surfaces
        
        which leads to warnings of "rendering text failed with stretch ratio of:
        10, invalid value (typically too big) for the size of the input
        (surface, pattern, etc.)" on my 200% scaled hidpi
        
        a problem since:
        
        commit cf9be3417bc2be5f772c03180b7cbd248b82cad5
        Date:   Tue Jan 11 19:08:50 2022 +0100
        
            avoid Xlib cairo surfaces for small virtual devices (bsc#1183308)
        
        where the nNewDX/nNewDY passed to the cairo_surface_create_similar
        branch should remain as the unscaled sizes.
        
        This does change the meaning of
        (nNewDX <= 32 && nNewDY <= 32)
        for the hidpi case, but presumably that's ok
        
        Change-Id: I663a399c0e9c8480437a5663329cf753d69eb155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128938
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [02363fb279d60f3f5a0328f43a048960028ac5c3]

        log where cairo surface error really started
        
        otherwise later seen at:
        
        vcl/unx/generic/gdi/cairotextrender.cxx:283: rendering text failed with stretch ratio of: 10, invalid value (typically too big) for the size of the input (surface, pattern, etc.)
        
        Change-Id: Iaf65213bbfcf64f09bae8c83efea75e70b8a9c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [39f452953e12e24350e7a3740129fa4930aedfca]

        use more concrete types in chart2, Diagram
        
        Change-Id: I40cd39d0878dc56e4e86e05149c9744cb563d745
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [d1207a5f3a573dbe39a7874931ce373e5c88628d]

        tdf#90341 Clean Up Excessive const_cast'ing
        
        Change-Id: Ib4cab4a4e476b469378b0b86d0819d4642f38893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128907
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [8a2da2585f2dc031235cda98ecd811683755474e]

        use more concrete types in chart2, ChartType
        
        Change-Id: I0f95c0a7be864ebde5f3234e77e4f915f57ffdcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [37d720b980c116a5b396b730d5850ebc6fc9d5a0]

        use more concrete types in chart2, ChartType
        
        Change-Id: Ife8d3f31d65e2911fa365a53f0defacde183f7b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1f44cb8ca941734c3bbb0647815125d88d67630f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4132705c109ba58744669ac21b9983bfc32fb03c
          - Fix typo
            
            Change-Id: Id60e34680e07b3d2842e0540eea4d9cdc07a6baa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128941
            Tested-by: Jenkins
            Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            
2022-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [65627bf58bac634ef60488e533905bc428c51f83]

        Removed duplicated includes
        
        Change-Id: I58b3245a03b7cbe37ea78833dd0ee50f8c698fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128914
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [36121e87b7e2a2defbfe75dfdadb2dde4fff6b4f]

        tdf#146970 use a textview to show the proposed replacement formula
        
        so it can scroll and keep the text area to some finite size
        
        no strings changes or new translations, so this is a backportable
        change.
        
        Change-Id: Ibc36812c6aa7fff8e035c06d0dad885909f057ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [15862b0118fe73a5cca10b6af05323bcab2d81cf]

        Fix typo in code
        
        Change-Id: I5fcf8c2c4439aa7be581dcc0fd6b55cfa19f2e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128915
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-25  Mike Kaganski  <mike.kaganski@collabora.com>  [737a270c61cd2038ede7911b7d7b4afcf020f53c]

        lok: enable in-place editing of math equations
        
        Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [0b9a4fd995c36c5348026f277aa28564615f2aad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3144ec5695574689ffd32dcef7b7b7a29e63dbf9
          - tdf#146911 Improve Basic DateValue description
            
            Change-Id: I41cbd011f753796b45556c5cf33e5fa93f6e7461
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128818
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8a505fd840b53182514076e4ced4c6b45aa654ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6705dd31c29a15e6c8bd9e73e5188e6adfc1386
          - shared/explorer/database is no more
            
            Change-Id: I286096e6de26f5a0e35200b4db7a2a89cfddcb5f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128934
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [30921ff65522fdc730dac5cca9ee2ac4016653f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30c15a5e48886b78d0bd3eac3e5bdf9f29cd9ac3
          - Add PostgreSQL connection Help page
            
            Related to tdf#43369 where a patch has been abandonned but is
            nevertheless still much wanted.
            
            The db connection wizard is generic and has no information on
            the required connection sctrings. The Help button in the wizard is
            not working as of today.
            
            The issue is recurrent in user-space.
            
            Change-Id: I3a5d30f859d6fb4e12813df3fe6df35d5e2e0f68
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128887
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [1385203dd927ac85939215d9e5b048aa49f0a4cf]

        gtk4: GtkSpinButton doesn't have has-frame anymore
        
        Change-Id: If2d230021e7b1e4777e2b663aa835e3917d896d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128929
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [bb9e718e6ae037ab0fadebe99da8f28fc5576e8a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 919def267b89cfe03f40218baa8c16cf65526448
          - tdf#123318 tdf#129697 Don't hardcode product name in CSS and JS
            
            Change-Id: I0ef315146fed188eb1cf33c416ff5f3e9899bbae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128524
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [1376b1c01f678311934afc5bafc0e4d72a09b9c6]

        use more concrete types in chart2, ChartType
        
        Change-Id: I68c04c7e3ffb21a52ad054adac7e9ed0c554e583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128883
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [d48530c535574a827d7261ae8d9d1068fd53c5aa]

        use more concrete types in chart2, ChartType
        
        Change-Id: I5efd85ac51fbb8bd3cd9a9d2e07b345782d0fdc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [933464ad3cfc8af141d1035afbebdcceb6814bb7]

        gtk4: deprecated GtkEntry shadow_type was removed
        
        Change-Id: I378db5406c508e3672927905735449a3a1003e3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [142de90574ddb307f89e7595c7444cab5a7f49d9]

        drop stray fprintfs
        
        Change-Id: I690df81054aa56209b0bfded742481c2f8c06feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Bayram Çiçek  <mail@bayramcicek.com.tr>  [adbaec38eca4847915871c817b67f5c722f0997d]

        tdf#146407: Hide diagonal border icons for Writer
        
        - Writer and Calc use the same 'Borders' UI.
          - svx/source/tbxctrls/tbcontrl.cxx
        
        - Diagonal borders for Writer has not been implemented yet.
          Therefore, diagonal borders don't work when clicking on them.
        
        - It would be convenient to hide diagonal border
          icons until the functionality is implemented.
        
        Change-Id: I6601ef924dbfb0acd40c3144300fecf74922c49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128487
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-25  Michael Weghorn  <m.weghorn@posteo.de>  [a85908f507f39c88a6cf244f5f4120361ad5e2ae]

        tdf#146941 qt: QtFilePicker::finished needs SolarMutexGuard
        
        Change-Id: I4165c72ddd6370c8fe7faf55f9db831359f6f8a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128923
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ddf7e388f2e45dbbe4e1f90610373dea530a425f]

        extra include needed for UBSAN
        
        Change-Id: I7a5125947bac0ff657a98fda9cdc34f188d0f5d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [b7712be56515ef48cef5ed084f46e355d818d941]

        call baseclass Close
        
        Change-Id: I661b4fe839a01f3929119540eb3bd1065f5fdbf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128917
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [c7fcd5a3bdbf181817ce6e5d2067434d480287a6]

        Related: tdf#146971 remove %PRODUCTNAME from accessible-description
        
        Change-Id: I83ff18c8b5e95fa172de950eb351cbfd855c9d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128919
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [ea09bad389ee1af19e5e626905e4d67bcc94636e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e1da23a649197d960c8492373326e11286b3239e
          - Related: tdf#146971 rename %PRODUCTNAME Macros to Application Macros
            
            Change-Id: I83393ec16732482deade1694c6a1a8e2b92f3944
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128916
            Tested-by: Jenkins
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [be7c21cc6a8df1c06a3210f32322eab382834b72]

        Related: tdf#146971 rename %PRODUCTNAME Macros to Application Macros
        
        Change-Id: I6a11c335b28cfaeaceba93b22e7d2db30ee803db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Jeff Huang  <jeff@mail.ossii.com.tw>  [964da41e9dc95318a55cf300bb03bc6f309cb1fc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 798fa0b98aa4308d1082583966571d4de5f504bb
          - tdf#139735 Change all "Link to External Data" to "External Links"
            
            According to https://bugs.documentfoundation.org/show_bug.cgi?id=139735#c4
            , this patch change all of "Link to External Data" sentence to "External Links".
            
            Change-Id: I654a6666d8eeac76589bcd205cb8edf94c218a41
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128911
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-25  László Németh  <nemeth@numbertext.org>  [5e8aa259e48d5602b932353bb146ebb523982cf2]

        tdf#146967 sw table: fix freezing in Hide Changes mode
        
        During change tracking, drag & drop or Cut & Paste a
        table row resulted freezing in Hide Changes mode.
        
        Test: In Hide Changes mode, select a table row by
        clicking on their left border, and drag & drop or
        Cut & Paste it in a different table row.
        
        Regression from commit 5a1c19624eda0c8b847af0dcee70b82502578ceb.
        
        Follow-up to commit 5a1c19624eda0c8b847af0dcee70b82502578ceb
        tdf#146965 sw track changes: fix tracked table row moving
        
        Change-Id: Iab606ce036fedcc70e42638e3ccf804c9dbca064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128875
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [9446b3ccd1240dbd44cbe1f1ccdfca04b61c85af]

        tdf#146571 Ignore focus changes after closing Manage changes dialog
        
        Change-Id: Ib588310410a265acdd129a8e51adf56bb5973bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128869
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  László Németh  <nemeth@numbertext.org>  [5a1c19624eda0c8b847af0dcee70b82502578ceb]

        tdf#146965 sw track changes: fix tracked table row moving
        
        During track changes, drag & drop or Cut & Paste
        a table row resulted a nested table in the first cell of
        the newly inserted empty table row instead of moving
        the original table row.
        
        Test: select a table row by clicking on their left border,
        and drag & drop or Cut & Paste it in a different
        table row.
        
        Note: This fixes crashing at Redo of tracked table row
        insertion, too.
        
        Regression from commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9
        "tdf#143358 sw: track insertion of empty table rows".
        
        Change-Id: I9a31cae2c0e6e5e05450336a1e5b8d792035df35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128726
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-25  Dennis Francis  <dennis.francis@collabora.com>  [cd7abd3e2c6bb28ecfeb1acef675280cfe438e3e]

        lokCalcRTL: h-flip the "combined" tile
        
        This h-flip is needed because the tile containing cell A1 will have the
        coordinates (0, 0). Further aim is to have document coordinates for all
        tile messages and tile invalidation messages. The LOK client should be
        able to map the document coordinates to the correct view coordinates.
        
        In the lok client we also need to h-flip the "regular" tiles at the tile
        position.
        
        Change-Id: Iaf89afeb89f916cb490800ee5d34c4780125f3a0
        (cherry picked from commit b3ca461871a92d8d2bd1d4ee713046ee74abbcf0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128890
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-25  Caolán McNamara  <caolanm@redhat.com>  [97cf76e9197a244a7d12f1f0a52074ccf36685e2]

        tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issues
        
        so leave it alone, and do the conversion just for the originally
        report situation as a safely backportable change with a follow up
        to not allow us to get into this situation in the first place
        
        Change-Id: I4f95f85791d0f937e53d7541804870b2cbf62b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128886
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-25  Tor Lillqvist  <tml@collabora.com>  [9aa90da7e03b4b0806b27451665b7c41b8836bc0]

        Take layoutInCell into consideration when placing graphic in table
        
        Set our IsFollowingTextFlow property accordingly.
        
        Thanks to Miklos for doing most of the work.
        
        Change-Id: I67d214d6ed41c19dcb2f3ad2db9be94ca77c5842
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128880
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-25  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [b0b300e6d2f6e16dbf9ad5e99b1091c79acf3516]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14cfe4926e77b4ab9bee348b391c7532c7339349
          - Fix some mistakes noticed by translators
            
            Change-Id: I8781dae8cd46678c20973bb53c5c24c925bfa0f7
            
2022-01-25  Dennis Francis  <dennis.francis@collabora.com>  [8866098c2ac731ffd878c72d70f38f6a65c17184]

        lokCalcRTL: Fix the tile offsets
        
        Change-Id: Id0db3d422c8c47ed6fbbc505ca9a857ac54c033a
        (cherry picked from commit 250aeac7434f924c82927a9de8a089e42a4fec00)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128889
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [1b728994b89b1518137a538f57ee3d7e6644d8da]

        use more concrete types in chart2, ChartType
        
        Change-Id: Ia3d49d53548a843301449c0fea97b81ba85e71e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128878
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-25  Noel Grandin  <noelgrandin@gmail.com>  [bf691e4598ae51b534d004ce21f839081dcd3df9]

        use more concrete types in chart2, ChartType
        
        Change-Id: I91acfea8bbac90fe505aae587299fae2b709ca86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128877
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-24  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [34412339f863b35508842a3bf20fcc7341a006e7]

        tdf#97706 CLEAN is neither ODFF nor OOXML conform.
        
        Patch makes CLEAN 100% compliant with ODFF v1.3 and almost 100% compliant
        with actual Excel results (just character 0x7F differs).
        
        co-author: taylorleebiz@gmail.com
        Change-Id: Icc070ca2560b7ca7640128c5a538d1fbfa1193e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128350
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [3ed01498d10b0eca08453eb29fcc2c59c33d2467]

        tdf#139843: sw_uiwriter3: Add unittest
        
        Change-Id: I51b1ef4a9a4af07ddcf68e4a6a4e5ea0d039bef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128885
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-24  Verne-Lai  <verne@ossii.com.tw>  [687cfd51ac785c2ab2cb8e49dea28aa7f53cbdfb]

        tdf#131327 Add double clicked event on auto-redact table
        
        Change-Id: Id927244fcd7e985edadb2b9f9cfdd61ba93066e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123570
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-24  Eike Rathke  <erack@redhat.com>  [8204d322379cbc054fb834911d88fb0fe3b040c6]

        ScInputHandler::UpdateFormulaMode() also for multi-line formulas
        
        Additionally sprinkle some
        TODO: MLFORMULA
        comments on places where multi-line formulas should be supported
        as well but code currently only works for one paragraph.
        
        Change-Id: If2630a6493910984e0abb81ff2ed42ed51394681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128787
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c22c95d41cd67ab865d40292e659abdd04a1b3e]

        tdf#139974: sc: fix test
        
        See https://gerrit.libreoffice.org/c/core/+/128651
        
        Change-Id: Ib38890351d7fb83ab4bffebfa9564427c16b6bcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128874
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [6c5c6ede0103e15b8e8ac432f0ca7f6e00c9dcb4]

        tdf#146913 don't destroy the dialog if we just want to hide it
        
        Change-Id: Ie534aba915120d12e65aa965e5435bc7575ecb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [de170db187852c42f6bad845d00c2b19b99e9a31]

        update pch
        
        Change-Id: I35cda63e774c076ada7bbc8802e325c23c578600
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128873
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [fc056783bc63b2dfc8ede01a10ab8a7e653e4aa3]

        move titledockwin to the one place it's used
        
        Change-Id: Ia9a1e0f687de3f916d59f28112b7b00c0d4a6610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128872
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  rafaelhlima  <rafael.palma.lima@gmail.com>  [2e1a38ceb6866248ec30f6fe58cd3adc1b910eec]

        tdf#146893 Rework Manage Changes dialog
        
        This patch reworks the "Manage Changes" dialog (In Writer, Edit > Track Changes > Manage) so that the buttons "Accept", "Accept all", "Reject", "Reject all" and "Undo" only appear in the List tab, since they're not needed in the Filter tab.
        
        A help button is also added and HID constants are defined for both tabs.
        
        Change-Id: I12da7811635dfc142d5d0a66d3275d3d170692e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128563
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [7679820af5739d3b6d5de0c4cb771d081407f406]

        can use a forward decl here
        
        Change-Id: I9abce9c3b02d998ed422405af0eb3a06cfa4057a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128871
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fbec819fc041cddcd64621acdd29bd35f4dd493]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I86b7fa98a6d4a269637ac042a9bb99b41ab90b0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128870
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [54930a004e42f76f310c7ae15f61d07fbb7c7bdb]

        gtk3: "expand" icon in reference windows goes missing on entering shrunk mode
        
        Change-Id: Ie303f82d1cc0de10ebd14248a31111a16be344f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128867
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Jean-Pierre Ledure  <jp@ledure.be>  [e95f6fcbf48a433bba4872de1bb3543497b14ebf]

        Dispatch commands: Include tooltip labels in the Description column
        
        The modified script updates the
         https://wiki.documentfoundation.org/WikiAction/history/Development/DispatchCommands
        wiki page.
        
        A typo excluded the tooltips while they're
        meaningful when they are longer than the usual
        UI labels or the "context" labels (whatever a context
        label might mean).
        
        Change-Id: I001d1a5624be9f40761f5e0dcd28da0a9feb981e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128866
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [20a0356a7b389cbae723d5b302ffd3737677ac84]

        gtk3: set placeholder image in GtkButton in .ui
        
        so the image+text layout is created by default
        
        Change-Id: Id5e9801274ebaa9e9cfdddcfac628b83828342fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128865
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [2bec949e85dc058b2e9009b2b7eb03745a5be71b]

        gtk4: use help-browser-symbolic for wizard help button too
        
        Change-Id: Icf16311cecf2b76afe62e4a415d7887864518bc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [e2ff4206d60df486bf02931ce69c47857de6b04e]

        gtk4: adapt to window_[g|s]et_default_widget
        
        Change-Id: I916e5db05f8ea10ecc8b319cc77a671ca7cbcb93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128859
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [f3d8750b07ff3ab89b27f0b1274b71de4924def6]

        remove explicit can-focus of False from GtkToolButtons
        
        Change-Id: I60ce3a7c1e83e99f396ff61166a6ba4912b9f82e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Miklos Vajna  <vmiklos@collabora.com>  [e993638d5ecd33783f2eebdccfa87a81e5a8a2c5]

        DOCX import: fix <wp:anchor layoutInCell="1"> with <wp:wrapNone>
        
        If wrap is set to none ("in front of text"), then <wp:positionH
        relativeFrom="column"> ignores layoutInCell="1" in Word. But in case
        relativeFrom is something else (e.g. page) or wrap is not none, then the
        old behavior is OK.
        
        Adjust our import so that Writer's layout also allows this shape to
        leave the cell.
        
        Change-Id: I6ca7511d46d7a70df11a65dc67c182f4fff4ae69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128862
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-24  Dhiraj Holden  <dhiraj.holden@gmail.com>  [cf0b49af5464507a269b03900b29e3cba155ce2b]

        tdf#46037 remove configurationhelper from WinUserInfoBe
        
        Change-Id: I7d23fe4f32c3b67304103ca88a757529ba4faa09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128508
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-24  Luboš Luňák  <l.lunak@collabora.com>  [8ca549ebc01a7aa0b288c521a9e60e76f4d8e97d]

        avoid Skia GPU surfaces for small virtual devices (bsc#1183308)
        
        This is similar to the previous Cairo commit. Fetching pixels
        from the GPU is not as slow as fetching them from the XServer,
        but this still can make a visible difference. And small surfaces
        should not need fast GPU rendering that much, so hopefully this
        improves more cases than it regresses.
        
        Change-Id: Ida031b38cd1ce14ded464747c20a38c6d094c5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128310
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-24  Luboš Luňák  <l.lunak@collabora.com>  [cf9be3417bc2be5f772c03180b7cbd248b82cad5]

        avoid Xlib cairo surfaces for small virtual devices (bsc#1183308)
        
        The (private :( ) document contains a large number of small shapes
        for which VclProcessor2D::RenderTransparencePrimitive2D() gets
        called, which results in GetBitmapEx() on the VirtualDevice.
        And Cairo normally needs to do a roundtrip to the XServer to fetch
        the content, which makes the rendering pretty slow. Forcing
        image-based surface for small sizes of VirtualDevice actually has
        better performance for the document, and the lack of possible
        HW acceleration generally shouldn't matter for a surface this small.
        
        Additionally drawinglayer's VirtualDevice reusing tries to reuse
        even a large one when a small one is needed, so a hack is needed
        to avoid that in this case, I couldn't find a better way.
        
        Change-Id: I0f58659ab88165a6bd915f100fc3b1d4802a0fa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128309
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [bbabe9c8ddb116a8e05bf93b29578c38de63e42d]

        gtk4: make wizards work
        
        Change-Id: Icc268c4ca650de2684e1b3a4d37fdef42491582c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128855
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [379a9e76ef5cbe7dd17641745cd07b85b5852a0b]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I621cc667d914ddfbfc84a9dd5a71bc76d411954b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128847
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [1da258a6269720f01e7c342e2b93e7834d86f02c]

        Make Certificate not found dialog async
        
        Change-Id: I8da2a2dc763cffd13659b61966a954a6e1ef06a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124269
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128841
        Tested-by: Jenkins

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [98d2c965aca67f59a27c0a9a7a3bc6e4fdb90950]

        Make View Certificate sub-dialog async
        
        Change-Id: I0e1a6a59d856ab266511fc3d6be87fe04c5afdfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124143
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128840
        Tested-by: Jenkins

2022-01-24  Jeff Huang  <jeff@mail.ossii.com.tw>  [6ff04de38652d639694489f9dc8e58c7039e067d]

        tdf#139735 Change "Links to External Files" to more precise sentence.
        
        Change "Links to External Files" to "External Links" for all components.
        
        Change-Id: Id6bec316c8ded153c724751d89f6f1a879b9a00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128718
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0ba124aac91f443fa381b7991e1f55298c9e7df]

        asan: fix symbol visibility in chart2
        
        asan needs some more RTTI
        
        Change-Id: Ib79655fc873c4e7b1b3088e23f7c1854b1a1d48a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [221492bdb70429c1896a59346caf983d4703bc68]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bf6a1d8dc24c4baa8879ef252f68cd1e93006d29
          - Fix icon alt text 
            
            (After  translation cycle, thansk to Valter Mura)
            
            Change-Id: If6a3e51d51d1326ae8bc452b843a16788f5e875e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128812
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [b9f53322df937098eef4fd5b2889989a38e4ffda]

        jsdialog: use string identifiers
        
        Thanks to that it is easier to debug and find widgets in maps.
        Sidebar and notebookbar are now in different map entries.
        This fixes the issue when destroying notebookbar deleted sidebar's
        widgets.
        After this patch sidebar works correctly when using notebookbar mode in
        lok.
        
        Change-Id: Ie9dcb82675129bdb567b766e29779744f500cb48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125216
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128853
        Tested-by: Jenkins

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [e064a2a1e82e913c49312706cd52736fa6a4f994]

        RTL: lok: draw mirrored native widgets from file definition
        
        Change-Id: I66318e4cb605a1882f557e53c03185cc767683b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128394
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128837
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [e82f8fffd32dcdfd28a49e577770b5a318347e96]

        cid#1497619 Uninitialized pointer field
        
        Change-Id: I951309dd201d9ef40ec265638c7bb04da1061097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128852
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Stephan Bergmann  <sbergman@redhat.com>  [9b2c6bbcc330cd19d41ed25f95589c700d435b2c]

        external/curl: Fix manipulation of LD_LIBRARY_PATH
        
        This fixes the same issue as
        <https://github.com/curl/curl/commit/e39421cef31f13a19b6bef5c644978e0c54e4e16>
        "curl-functions.m4: fix LIBRARY_PATH adjustment to avoid eval", just in a less
        intrusive way so that we can get away with just fixing the resulting configure
        rather than having to run any Autotools reconfiguration commands.
        
        40a84af1bdd7b3c414a8a78ca32b0951c03f9976 "upgrade to curl-7.81.0" caused
        <https://ci.libreoffice.org/job/lo_ubsan/2272/> to fail with the cryptic
        
        [...]
        > checking for gethostbyname in -lnetwork... no
        > checking for gethostbyname in -lnet... no
        > configure: error: couldn't find libraries for gethostbyname()
        > /home/tdf/lode/jenkins/workspace/lo_ubsan/external/curl/ExternalProject_curl.mk:41: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/ExternalProject/curl/build' failed
        > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/ExternalProject/curl/build] Error 1
        
        because somewhere in the middle of curl's configure LD_LIBRARY_PATH got garbled
        because of this issue, so that invoking
        /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang started to fail with
        
        > /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang)
        > /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang)
        > /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /home/tdf/lode/opt_private/clang-llvmorg-9.0.1/bin/clang)
        
        (because that clang is built against a local GCC and libstdc++, so needs
        LD_LIBRARY_PATH to be set up properly to find the latter), which caused the
        gethostbyname check to fail (as seen when looking into that build's
        workdir/UnpackedTarball/curl/config.log).
        
        Change-Id: I3d45018cdfdb22b98c0dec0757e754a172a811de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128850
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-24  Caolán McNamara  <caolanm@redhat.com>  [9c27377389e0495e8a7cc1ad6b1289649db5b0fa]

        upgrade to box2d 2.4.1
        
        Change-Id: I618467eb37ea578c17dab0810f0ed5ad160f1552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128789
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [c892b224bee72c35e145f0f190b3fec64ac343e1]

        RTL: lok: mirror cursor position when needed
        
        Change-Id: I3e574e1b1d5e26528794c39cb631d8f5cf60e927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128390
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128836
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [26a57a59b9ca8af2f9584e292f03655c02fc2698]

        RTL: lok: render tunneled dialogs mirrored
        
        Change-Id: I14d33706eddb99167cf5537f6ece379124187bf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128371
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128835
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [74c80afa8544be52bce20b93aec982a3c64d233f]

        RTL: lok: handle mirrored mouse coordinates
        
        Change-Id: Ib881b92f691e250f150db1d02c48dd465c622fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128370
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128834
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [c13ec26f6a20bc9a0e3e4fd8f03d8f4e1d46c7d1]

        Make View Certificate dialog async
        
        Change-Id: Id93145ecf6be3cb558f0ce8d3cc340bbc67095e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124061
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128839
        Tested-by: Jenkins

2022-01-24  Szymon Kłos  <szymon.klos@collabora.com>  [71a8bad4b96627fd965b23288dea14aae3f0f468]

        jsdialog: enable Digital Signatures dialog
        
        In LOK case run it in the readonly mode.
        In readonly mode we can run it asynchronously.
        
        Change-Id: I721dd14fa23d4e30255dd976e0cc2a4f30470a3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124058
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128838
        Tested-by: Jenkins

2022-01-24  Miklos Vajna  <vmiklos@collabora.com>  [0c3b8792b712e939d2ad524d554f96616b4844be]

        PDF export: allow setting filter data keys from the cmdline
        
        Follow-up improvement to commit 3eb9eb9906c9 (lok: add pdf version
        option for export, 2021-11-15), possibilities are endless.
        
        For example, to skip the first page of a Draw document:
        
        soffice --convert-to 'pdf:draw_pdf_Export:{"PageRange":{"type":"string","value":"2-"}}' test.odg
        
        Add watermark:
        
        soffice --convert-to 'pdf:draw_pdf_Export:{"TiledWatermark":{"type":"string","value":"draft"}}' test.odg
        
        Encrypt:
        
        soffice --convert-to 'pdf:draw_pdf_Export:{"EncryptFile":{"type":"boolean","value":"true"},"DocumentOpenPassword":{"type":"string","value":"secret"}}' test.odg
        
        Version 1.5 (instead of the default 1.6):
        
        soffice --convert-to 'pdf:draw_pdf_Export:{"SelectPdfVersion":{"type":"long","value":"15"}}' test.odg
        
        The cost of the verbose syntax is probably smaller than the benefit of
        having this 1:1 mapping from string to PropertyValues.
        
        Change-Id: I2093a3a787a9578dd02a154593b7a020f4a0ba31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128849
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-24  Mike Kaganski  <mike.kaganski@collabora.com>  [5253bef351ebc5413a382e41586b78028b9ee358]

        Add a reference to respective documentation
        
        Change-Id: I6934dbe0a43a34e70a4bb988ae31d2a503928573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128808
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-24  Noel Grandin  <noelgrandin@gmail.com>  [ed9b410a1932fabfd335ab0b613be6595af6a5a2]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I823641fe7dc2038da90dab8b4e4e3ad3652c1934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Eike Rathke  <erack@redhat.com>  [86a9c860410351125708543c1050bfc0977d3b97]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 55e53682d9285f018385e273774a7d106a34efd4
          - HYPERLINK() clarify that it is not "CellText" but CellValue
            
            i.e. the argument and thus function result does not have to be of
            type text.
            
            Change-Id: I8e1917ecc5f740f880b5321c4c91f7512c9e3245
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128844
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2022-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d63b243594d7e5ca3402745f662b4349cc5753f7]

        Fix typo
        
        Change-Id: I4d29762972355fd0794742349e1b14a50d3b4c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128843
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-01-23  Julien Nabet  <serval2412@yahoo.fr>  [3366b529bbb51de725d5341bf25f9ea961fd0c0b]

        Mysql/MariaDB: Fix slight bug in Tables::createObject:
        
        unescape scatalog before converting it in aCatalog
        
        In Views, remove connectivity::mysqlc::Views::disposing which seems more cargo cult
        
        Remove useless XConnection.hpp in tables (how come I didn't spot it in cleaning process?)
        
        Change-Id: I28863dcd93baae923877dbd431b6807226c0a548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128799
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [133b5010c5580d564a87df6f36ead48120167716]

        use more concrete types in chart2, RangeHighlighter
        
        Change-Id: I0a0fed3b703c2fda36b8e26391b0b7713e80f4d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128831
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [11d8b1c04a7b85d5c50b9dd7484cbd01240c8174]

        use more concrete types in chart2, Diagram
        
        Change-Id: I5b0fb710880ce08276201278b7da18bdcfaec1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [d5e1fee5af79b462cb0dd9b18ebc0604b6d3ea9c]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I780b391ffbff7cb79201eb2895702a7a9a07f89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128829
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [ea6cbf9e42c772e0cb8814142dc8a0eeae14e2fa]

        use more concrete types in chart2, Diagram
        
        Change-Id: Iaeb477d6c5760dc701291059c4f250c2f1aa0ed5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [b274c175a2f57cc414ccff127a2199692fc3b3b4]

        use more concrete types in chart2, Diagram
        
        Change-Id: I78b0e12e469ff17974b6ba176336d1a5f39afce5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Szymon Kłos  <szymon.klos@collabora.com>  [218acb48df79101392c2cc3a030ddb5dcee878c7]

        tdf#146728 lok: IME: preset formatting in the new paragraph
        
        When we wrote something using Heading or Title style and
        then moved to the next paragraph by pressing enter
        we should get "Text Body" style in the new line.
        
        Do not copy style. Use NOHINTEXPAND when inserting initially
        so we can use EMPTYEXPAND later - at the end of composing -
        and use correct styling.
        
        followup for:
        lok: IME: directly copy formatting for inserted text
        d8dbd123bfa7f39489ceb15ac83142635531fd43
        
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=d8dbd123bfa7f39489ceb15ac83142635531fd43
        
        Change-Id: I55b764068337e125eea3fba641edb6486b2ac9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127875
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Ashod Nakashian <ash@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128832
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2022-01-23  Arjun  <pikabell70@gmail.com>  [1cc2690fe2f87e8acce4e9b4e0cb533fda26e295]

        tdf#97046 prefix gb_ to system variables
        
        Change-Id: I8be2f55e3306d7ac34ea5819ab93fd537315b281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128804
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-01-23  Jan-Marek Glogowski  <glogow@fbihome.de>  [fb1e658bbdc2e6f9d316fdf9a1d08b414d72c9a7]

        icu: use libo_CHECK_SYSTEM_MODULE
        
        ... and drop --system-icu-for-build.
        
        Seems all the special handling was introduced for MingW in commit
        d1cc4bb69eb21b19c96fc0111611382b51a3d7ae ("mingw: allow forced use
        of system icu tools"). MingW support was removed for a long time.
        
        I'm not sure the cross-compiling with --system-icu is really a
        usable scenario, but this keeps the system tooling setup. Neither
        do I know, if ICU >= 4.6 (release 2011-03-11 for ICU4C 4.6.1) is
        a sensible configure check.
        
        Change-Id: I00da8d6fc383e7e7d87d027074058ba7bec2d2b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128026
        Tested-by: Jenkins
        Reviewed-by: David Tardon <dtardon@redhat.com>

2022-01-23  Seth Chaiklin  <sdc.blanco@youmail.dk>  [284bfb3ee95b9a0732d42f2cff61e8f9fac9d83e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc64499cecf5d0695bcf9b70b75ab99013270e38
          - tdf#146733  - add "reset default"
            
            Change-Id: I48ca877a20e44dc0a66ac92483ad47725a4864e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128807
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-23  Andras Timar  <andras.timar@collabora.com>  [a244beeed618fc4507a65934932a1a6607c62804]

        change rpm compression algorithm to multi threaded xz
        
        Our baseline is CentOS 7, it's safe to switch to xz that is supported there.
        Here is my measurement on rpm package build time and package size on a
        48 core machine, however 48 cores were never used (8-10 max). Compared to
        reference w9.gzdio which was used before the patch.
        
        Compression   Build     Package
        method        time %    size %
        w9.gzdio      100%      100%
        w7T.xzdio      69%       66%
        w6T.xzdio      62%       67%
        w5T.xzdio      55%       67%
        w4T.xzdio      41%       70%
        w3T.xzdio      31%       73%
        w2T.xzdio      26%       75%
        w1T.xzdio      24%       77%
        
        Conclusion: we'd like to optimize rather for the build time, therefore
        w1T.xzdio was picked. The package size was still smaller than the reference
        size, and the build time was 4x faster (in this measurement 18m16 -> 4m26).
        That makes a difference.
        
        Change-Id: Iabb532628d38a2d5091fa41fd08bfee69007d0ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128800
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [71a5a9437557d7c79046207b7304ccc10c8aeb68]

        these methods do not need to be virtual
        
        Change-Id: I2be143adfab9a3f842469cb030281ed3c0610266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4007a8135a689221e30b69b849beea674a8e63d0]

        use more concrete types in chart2, ChartModel
        
        Change-Id: Icee63a8a9d2e63f05064506df6c2d36314fe05c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [bc518de4b9ae9d5985b3706dd4fbf60a0d6e1a79]

        remove css::chart::XDataInterpreter
        
        these are purely internal interfaces, they cannot be used
        from outside chart2.
        
        Change-Id: I43c6d8aa96eb94e47767a4b16b89b4889f571579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128792
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Stephan Bergmann  <sbergman@redhat.com>  [5462235f5611a784b60e5a0ab1fff6a1ea6ebc1d]

        Avoid loplugin:salcall
        
        > In file included from jurt/source/pipe/staticsalhack.cxx:39:
        > sal/osl/unx/module.cxx:212:6: error: SAL_CALL unnecessary here [loplugin:salcall]
        > void SAL_CALL osl_unloadModule(oslModule hModule)
        > ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        in an ASan+UBSan build with --enable-compiler-plugins, after
        b5b1eae538a902fed165d5dd93ad6ddda3c5cb70 "Add HAVE_(UNIX_)DLAPI config header
        define".  DISABLE_DYNLOADING was defined there ever since
        ddc7bb629ade15b3341f2e3c347652c7b8925037 "Poor hack for libjpipe.so under Clang
        -fsanitize=*" but doesn't appear to be necessary.  (Alternatively,
        loplugin:salcall could be taught not to warn if the function definition involves
        any #if'ery.)
        
        Change-Id: I5786979eb944d59f969c9875d77b03f9b2432161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128797
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e170d62b488117a09fe401a6ac63355a74347689]

        Removed duplicated include
        
        Change-Id: Ie3d9f815f1e998d23a6dafcbdfa37e9c4d7708f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128794
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-23  Caolán McNamara  <caolanm@redhat.com>  [630be1877054ad8822bfd9f134dea888cc98845b]

        upgrade to nss 3.74
        
        Change-Id: I6cc2e86abb85895e8102dbc69c3809c18933a11f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128793
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [afc49a652ec2eb5cce7a68918b6c5e6d9e8c2813]

        use more concrete types in chart2, Diagram
        
        Change-Id: Ic3e54f0d82e4cfd0e8eee08214800ce7f1427d25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Noel Grandin  <noelgrandin@gmail.com>  [0f64a9ade726880c945047b590134910775e5845]

        use more concrete types in chart2, ChartType
        
        Change-Id: Idd81f73e1352118f25102542effc8a3287e244cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128790
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-23  Stephan Bergmann  <sbergman@redhat.com>  [162017cd9abd9c1ca63a6b671a084464b896e85c]

        Improve DBG_UNHANDLED_EXCEPTION output a bit
        
        For example, in de3898aecb11307789644a1814e9cbb1ee4cc29b "Add missing test
        dependency" it would have output
        
        > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: "URL at svx/source/unodraw/unoshape.cxx:1600"
        
        rather than
        
        > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: URL svx/source/unodraw/unoshape.cxx:1600
        
        making it slightly clearer that what follows "URL" is not the value of that URL
        but rather the source location where the exception was thrown.
        
        Change-Id: Ia3abd232fce3d95a8b66ff4ed5bab2fcc248df2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-23  Caolán McNamara  <caolanm@redhat.com>  [465c3ad95059f0efa13c8027f7383c4d20a5b2ff]

        Related: tdf#135935 set some hints as to what widget should have starting focus
        
        for wizards where the help button gets initial focus under gen
        
        Change-Id: I40b0a4620f417a4688366c028db4c9cb59eb333c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128749
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e7eb5f7e10899cf106b922439454b5d2f65d8f5e]

        Fix typos
        
        Change-Id: Ia34d2b2f704da96ff3182d25a1cfa05a98fbb60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128795
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Jim Raykowski  <raykowj@gmail.com>  [a903d114f8d67f266e12d129333fb35c04861ae2]

        tdf#146490 SwNavigator: replace page number field expand field text
        
        when field is in header/footer
        
        Change-Id: Ic11f020655a863d05e638e55db6ab150ce4ad7c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128752
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b2f2f7afce2ae711239bfe36deb20e6a3a6c0c0e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 043e34d3c9e0d636488a838ae61a849bc7eeadbc
          - Fix typos
            
            Change-Id: I080525c23f7dd35fafed81200abd91cf93af6c59
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128796
            Tested-by: Jenkins
            Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            
2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [0f2b8305ed31746cd4dca33aa080adb220109353]

        upgrade to openssl-1.1.1m
        
        Change-Id: I7c3e576501b4587a0f6814cdc4895663ef6d3f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128769
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Noel Grandin  <noelgrandin@gmail.com>  [58766f997d59e4684f2887fd8cdeb12d2f8a9366]

        remove css::chart::XChartTypeTemplate
        
        these are purely internal interfaces, they cannot be used
        from outside chart2.
        
        Change-Id: Ib89e98e8099c34a530951bd85236fced216aff18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128784
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [75495067f6f4ba47bb7ff7fe2426f2199c175c78]

        Use o3tl::convert instead of OutputDevice::LogicToLogic
        
        Change-Id: Ifb7be992c6e951692a741d10ed24ec8b3836982a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128782
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [5e3ee8a1fff0ef0d77f274d1826a1e63e4a00040]

        Typo: documet->document
        
        Change-Id: I0eda84ea313029311c81782abe7157b06de3a2cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128786
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5c01241e072adc71cde1b42cafcb13ef6cfd426d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00a7b31dcc0335a65995cb3569479cee6a3a8998
          - LDAP abook is gone so gone is LDAP Help pages
            
            Change-Id: If226a312e6757fa79f699fced19fadc975e05d64
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128785
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [40a84af1bdd7b3c414a8a78ca32b0951c03f9976]

        upgrade to curl-7.81.0
        
        Change-Id: I0a34239bfb16bf19e25bf374c7f36c4cdf1776c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128783
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [5190b933ef6d3c5faa23d8165b2109c4ea21df42]

        upgrade to Python-3.8.12
        
        Change-Id: I0dd1a767c5c65e5789e690e13958ba4ad92a7e16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Stephan Bergmann  <sbergman@redhat.com>  [de3898aecb11307789644a1814e9cbb1ee4cc29b]

        Add missing test dependency
        
        > [_RUN_____] SdOOXMLExportTest3::testTdf140912_PicturePlaceholder
        [...]
        > warn:vcl:680849:680849:vcl/source/bitmap/BitmapEx.cxx:98: BitmapEx::BitmapEx(): could not load image sd/res/image.png via icon theme colibre
        > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: FromWordArt svx/source/unodraw/unoshape.cxx:1600
        > warn:svx.uno:680849:680849:svx/source/unodraw/unoshape.cxx:1599: Unknown Property: URL
        > warn:svx:680849:680849:svx/source/unodraw/unoshape.cxx:1779: DBG_UNHANDLED_EXCEPTION in setPropertyValues exception: com.sun.star.beans.UnknownPropertyException message: URL svx/source/unodraw/unoshape.cxx:1600
        > sd/qa/unit/export-tests-ooxml3.cxx:1863:SdOOXMLExportTest3::testTdf140912_PicturePlaceholder
        > equality assertion failed
        > - Expected: -8490
        > - Actual  : 0
        
        Change-Id: I7710bf04ff5106d52fe51b515f2ed59097e88e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128753
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-22  Noel Grandin  <noelgrandin@gmail.com>  [8a728ac6cf7d8d032eb93f486618458b7814d42b]

        use more concrete types in chart2, ChartType
        
        Change-Id: Ibd299e2e8d82169706d810af98c29d684809c320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128741
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [fe9f6ac055ec95d06d9e28ee4d9871cc366ac540]

        Mysql/MariaDB: Clean mysqlc_keys + remove using
        
        Change-Id: Idd7d0ce4ffd18fec95102c41372c83fb7df11168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128757
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [c1205c1cf6e08d94e6e2e2753679d99bc1842ca0]

        Related tdf#146909: add missing IDIGNORE in Basic
        
        Change-Id: Idbbceb2f5375d47c942bab70ce81f7be79b17478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128780
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-01-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [5522e0770fc71f75d27e6179ec58db542daf6183]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3bcf0ef395578e011a76943a15f3467ea128b35
          - tdf#146778 Clarify the use of the "Interval" argument
            
            + minor refactoring.
            
            Change-Id: I339ea6a2fbd94be3aa9fe756181e3a7b6a5cc604
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128677
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [c03ae5acdd7a719e03314dd8c94d3117bda77ac4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7577c4518f2592b2da440638cc1945c0f54f0319
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibfe4268a0ddc5c3d6b3679a93002d6a460c31a8d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128779
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [2870fc5631b0503f99634111dc027df212e7334a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3c5d27c93253aa497b11880e6205a14b3f9211f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia53167243daf595f43b0d6ff977f56059e270d0a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128778
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [73f114a925c3ae7b431250bf22df9e7ed9416c2c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5c99664f8678fbd7445dad722019bfd6f17b870
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4eed750435b01b17c79235572bd546c630c50cd7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128777
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [806a960a5656a6994578a3dc27bb09e9e8e0857f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53dd06a1d068c9da4a5bb6c273dc70a8fa2ba174
          - tdf#132643 Translate German section IDs
            
            Change-Id: I10b3eaf6bae7644223ae48bd281221fc94e4f2c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128776
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [f080d12c31f9c4eddf8cbc870b8bd5c35f3ac122]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6a0e47621671f8d099b8b857e20b1093f5b95fa
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9d3cfe419740ebd4db7759fac47351a558491e8c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128775
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [a85ffacc9a53e6c31677bad0f6647b67a8a86b17]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f6c933bfc9ffe1a6d92816e9e9acf7736b5cdbe
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4ce843fbd0a4683edbe243705304a8bd0e3c76cb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128774
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [a9442de049c6ed7eba6884b1a1fbfebb277cc4e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 665ac4656a0cc0fcbd90353d82589d962e899b7b
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ife6a8253235594752f9aa7b0651b31fe0b6b4fdd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128773
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [f77bf2e8063b8efcc28b408d02bac9eca0148685]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc28eb455d344762519687068a245eea30c30035
          - tdf#132643 Translate German section IDs
            
            Change-Id: I631a9268808e9d14b4bb1336c6f98db2502a356a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128772
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [e35c81098ce4695050c62d40595e7882f2ed4ee6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d3ab37c18ddd781cd1e1c82cd49d5e5b6299800
          - tdf#132643 Translate German section IDs
            
            Change-Id: If14616fde18fdcc6bf500cffb68a19a911790726
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128771
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [7341d1ea0f73d05058e9c2b8e8de29755df73ca3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 65dca462c0c5e1b1ee5689346cdc02a4e9c33d4a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib355904a72fd3149a24dd36b40c3ae4afc989ae7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128766
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [f6b70ed26450ea7d9dcaf2cd18acccc7a1b4db01]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b3f8364f47a474b76e3edaed180c294d0d56c46
          - tdf#132643 Translate German section IDs
            
            Change-Id: I946974bd99c22be9ce4517b262d390de6798fed2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128765
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [34a01f215f481a4b9b1c508bf8dc24e367908e41]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88c1720669758e0ef5796e1b5d3cdfe673a88dfd
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iba7139828199fee92a3ab667eedca3b1788c791b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128764
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Johnny_M  <klasse@partyheld.de>  [d0840c92d5101a16636718e076fdffe46dab3736]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to df005bb445ee7be2a126cca60df7d80ca09f6e7d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I502542e291326cf7f0c09e35ca957c716a72a0f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128763
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [8f81535faf6a5d80d5e4d522768c7537e0ca5d21]

        ofz#43949 Timeout
        
        Change-Id: Ia1691d30e754924314d39d733135614db4c56834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [8c1f919823e4386d3e2744a8b4732a5bcc1a2280]

        Mysql/MariaDB: Clean mysqlc_catalog + remove using
        
        Change-Id: Ia9cd6dc9a6389ea1764a85c5f35a65f7d6ac40a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128755
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Mike Kaganski  <mike.kaganski@collabora.com>  [69e33b83f58c6d0dae36a6f85070a5340366dc75]

        This conversion is no-op
        
        The two map modes are both mm100, and it was always that way
        since commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b
        
            author	Jens-Heiner Rechtien <hr@openoffice.org>
            date	Mon Sep 18 16:07:07 2000 +0000
        
            initial import
        
        Change-Id: I4c24f8665b7b27569431526a3a7ead6469322055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128682
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-01-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a08742cbb3950295c6b6a8ca1016d4a3ca506116]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d086373e657a29f067c15df5138e9b532a70c65a
          - Update database toolbars Help page (II)
            
            Change-Id: Id67be14239df0186b54f68b63e66c6b6057304ed
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128781
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [4165eee714d1b06a56a14e75a030dba9da91b11a]

        Mysql/MariaDB: Clean mysqlc_column + remove using
        
        Change-Id: I10e3cc1fb2b66d7bebbaa33d7eb0b2099658e3af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128759
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [544cf2e9b71e18973fd64376791fbc2a6cf2f88f]

        Mysql/MariaDB: Clean mysqlc_views + remove using
        
        Change-Id: I11e1284f9e7589cf4770d723e36c91a84b9b36b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128761
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [7da9683f63dd2acf4a74ef40de6add112d60bd4d]

        Mysql/MariaDB: Clean mysqlc_view + remove using
        
        Change-Id: I6fcb2f2c4346e6293a1e40e6f143ef6e8a68ee8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128760
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [98cc5c51f58fdf869c82f30654eab0ea0568ccc4]

        resave with latest glade
        
        Change-Id: Idb87c5cfd4f2363bb139ff28307ea4efeeba1e6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ac4cc29de9960bbc59ad73fd46c6fa3b2b9b30c6]

        Fix typo
        
        Change-Id: I77e8015efc4501793c2e80bc3208463a1523e9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128751
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [e3f92c53c084fe438e410d7d33a302b5d03144fd]

        Mysql/MariaDB: Clean mysqlc_table + remove using
        
        Change-Id: Iae0c8d4f12644bee15f78311b86d367f179a4fbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128754
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [7fec58370d2f7814f14ddc9538cab139920fada9]

        Mysql/MariaDB: Clean mysqlc_columns + remove using
        
        Change-Id: I6d29d594ed423efa25f063fd3107718b0f8b5b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128758
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Julien Nabet  <serval2412@yahoo.fr>  [c74aa0fa623d6f7712f24c6be7370cf357471354]

        Mysql/MariaDB: Clean mysqlc_indexes + remove using
        
        Change-Id: I893dc2d858a90b45b92b2866129527567bdb45e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128756
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-22  Caolán McNamara  <caolanm@redhat.com>  [3cf12be142b4455026112192e2a3cc39e66d2a2c]

        ofz#43902 Timeout/Hang
        
        Change-Id: I87a8f3856f82de060bfb4b6cc4abec482c7462e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-22  Noel Grandin  <noelgrandin@gmail.com>  [1a6e00363fcc2439f4fa43e165009c9a40f1ae84]

        simplify function object
        
        Change-Id: Iadba25f2c7ceae1dfc24de421b88ba9e8afb9155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128738
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-22  Stephan Bergmann  <sbergman@redhat.com>  [cf0e691d42661d14dc8c653e48d3f9662861786d]

        Add missing test dependency
        
        > starmath/qa/cppunit/test_starmath.cxx:153:(anonymous namespace)::Test::testSmTmpDeviceRestoreFont
        > assertion failed
        > - Expression: pPrinter->IsFontAvailable(aFontName)
        
        Change-Id: Ia704559c3e29f38b281a05f2308888e1ec0e57eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128706
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-22  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [b8278d93bbf8c63e283024783da32f84f7e4f246]

        Make installer compression tool configurable
        
        So we can use pigz or other parallelizable tools if available. Shaves
        off noticeable build time when packaging install sets.
        
        - figure out if pigz is available (fallback to gzip otherwise)
        - pass compression tool down into make_installer
        - and handle as one of many global options there
        
        Change-Id: Ia9d1ea27a9f990874238b6f0be3e1fd30a662ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128469
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-22  Jim Raykowski  <raykowj@gmail.com>  [7270ed7b81c12c8ba2e57b1a0d2ae084f8489d61]

        SwNavigator: revamp SwContentType::HasContentChanged function
        
        Effort here is to improve function performace and understanding by
        restructuring code and providing code intended purpose comments. Non
        in-depth testing shows modest improvement in function speed for
        documents with large amounts of content fill in the Navigator.
        
        Change-Id: Iedf53ef8e759c848c417d9a390fb6422d4896794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126467
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-22  Noel Grandin  <noelgrandin@gmail.com>  [98f360b261d7b36fa63b10fadb86cf6f381cbd36]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: Iea726c410829fbd3f116ecead76610e356ef83ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [571438a34ad9aba0d496a89e8345851331740fbd]

        tdf#118246 add support for Application.GetOpenFilename func.
        
        Opens the file dialog and returns the selected filename.
        
        Change-Id: I4eccd34a7fbb892c0950b2f7c34977cf2aad6f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128721
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-21  Eike Rathke  <erack@redhat.com>  [e27a41a362bf25e12487b36f625985b35fb891e3]

        Remove MAXCHARSINPARA truncation in ImpEditEngine::ReadText()
        
        The called ImpInsertText() already handles that gracefully without
        truncation. See also related tdf#139974.
        
        Change-Id: I0ecef7ac0b2b8db5962d19c767cbc23e91cb3cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128744
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bfa688fa260a1c70dc73b782988c4efb11c3e1bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79a8a92881681680fbf99b23a27b8247510a2b91
          - Refactor and update database toolbars Help pages
            
            Change-Id: I72125cdc222be36199be96c112973af531304784
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128747
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [873803e7e57a8befff0c2032641512489711a4ab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6192b00a59c9a10fe59eef50f6eb7d25fb3813a3
          - Refactor and update Report design (main)
            
            Change-Id: I2e8b809ec57f97bf96aa27d26f3a597ae48e795e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128743
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-21  Caolán McNamara  <caolanm@redhat.com>  [f05f92f09d99c48a96a3ef18943c265a803e3820]

        tdf#146891 there is a case where "chapter numbering" can be changed
        
        where "Chapter Numbering" is present but the list is editable, so
        we can't be sure that just adding "Chapter Numbering" for display
        purposes is safe enough, so add a specific id for the "pseudo" list
        style and check for that id (instead of the name) to determine the
        additional case where "Edit" button cannot be enabled
        
        Related: tdf#145804 show "Chapter Numbering" as (uneditable) list style
        Change-Id: I35d852523314c985ea5b7217e9394ac3e9c6e331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128737
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [ab234f749cc4a213711e389d29ced9a169bfa090]

        sc: move vba tests to the new vba-macro-test file
        
        Change-Id: Iaec40b8a1d5bce5d9a96447fee5102dc18a16f59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128736
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [456ccf994d15a5af1ba2039cace8f0fdc886049d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4eecbf9045ed866b0d716a45046f89b472dd3835
          - Refactor database Help files
            
            Change-Id: I8f8c96bf9cc9c401c38e3cc92f4c3b274b3f15e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128740
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [67e88d173fb56a2628a5464d56276134bf6f65a2]

        tdf#135935 Ensure help page is opened in chart creation Wizard dialog
        
        Prior to this patch, if the user opens the Chart Wizard dialog (Insert > Chart) and clicks the Help button without clicking anywhere in the dialog, the help ID was not being applied. This problem happens on kf5 and gen, but not on gtk3.
        
        With this patch, the expected behavior is achieved in gtk3, gen and kf5.
        
        Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-21  Caolán McNamara  <caolanm@redhat.com>  [c7c5f662ea3661f0cfe8534af235aa76dc4ef63a]

        gtk4: set homogeneous to true to get two equal width buttons
        
        Change-Id: Iff8c9579bbb4758c2bb13b946fafcaf3b9433a84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [fadb53a393b52eb4c9336fa8c9c780b4d6b3e391]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I6930e09ed471592d7c8b8fb16565b355b17bffc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  Caolán McNamara  <caolanm@redhat.com>  [58daee3693e6881e1412715db195009c9ab39f46]

        gtk4: GtkPopover::modal has been renamed to autohide
        
        Change-Id: I0ccfbc1284ef85ea276979d3133f30628517200a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [496ab9284185745a4ae43ec28561d69bf003d72a]

        The Emscripten FS image isn't installed anymore
        
        ... it's just symlinked by the unxgcc.mk link target to binary
        locations.
        
        Change-Id: Idce067d82de6751cf422d924e00537d93fd716bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128730
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [c42a13c491196743d734107e54ef2f323fa1395b]

        asan: fix symbol visibility in chart2
        
        asan needs some more RTTI
        
        Change-Id: I77ffe652c3252a6d9b71f3b29b085170963eba3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  Noel Grandin  <noelgrandin@gmail.com>  [928cb2963844ffd07fdbda6ec55f8de0c51581ff]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I25fc26c9c3eb861d72c44ac04e502b2f002ef951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4304947164bbcd3fea758df491a730b01d578be2]

        fix opengl slide transition
        
        regression from
            commit 62efb188668a3296591dcfa3658185e2f982e356
            use comphelper::WeakComponentImplHelper in SlideShowVie
        
        Switch notifyEach to leave the mutex locked after being called,
        because that seems to compose better - because after a call
        it is in the same state that was when we entered the call.
        
        Change-Id: I42e80cc7be1b65ed8cab24ab7c11210e056d916d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  rafaelhlima  <rafael.palma.lima@gmail.com>  [47f21d290087638b1986c291c969bf2997574ddd]

        tdf#141591 Add DevTools to the Tabbed interface
        
        This patch adds the DevTools command to the Tabbed interface. It is located in the cotnext menu in the Tools tab.
        
        Change-Id: I5f323b1b5ffc6707fc4f8b3c6eca2db7b8b97adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127973
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a29be0d52c2edccee451ecfa32dafec7cba31f45]

        Fix typos
        
        Change-Id: I6ba7c7db6c58fde2e7648ccf32b93fc05f5eae65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128620
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ef2a7db1e0d42264a5c549b76066fedbf5caff6]

        Fix typos
        
        Change-Id: I7b3d17431c5acc92ebc593f4f0fae385c944f61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128727
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [fced837029123f34a125f5a794e5681ed297fc2a]

        tdf#146478 vcl: vcldemo and other vcl examples segfault on close
        
        We need to call on framework's shutdown to cleanup after ourselves
        properly. This has only become apparent after commit 6e35794ca where we
        assert if we try to dispose to process's component context before we
        shutdown the app properly.
        
        During this we also noticed that we got a warning:
        
        warn:i18nlangtag:1855739:1855739:i18nlangtag/source/isolang/mslangid.cxx:105: MsLangId::getConfiguredSystemLanguage() - not configured yet
        
        So I have fixed this by configuring the system language at init.
        
        Change-Id: I3cb73b1dad84f1097696c15e5c845d97fa58befa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127796
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [a9bb94e28a6757719a2e833c9d3ca17b3205283b]

        VCL fix shutdown when run via system loop
        
        Adds DoQuit and SAL_USE_SYSTEM_LOOP to complement DoExecute.
        Makes it easier to switch between a LO with and without nested
        event processing. Unfortunatly the recovery dialogs run outside
        of Application::Execute(), so this currently also disables
        recovery handling.
        
        Follow-up (and no more Emscripten-specific) change to commit
        93133585b5b52e38defc3162eeb1e7704dceafcb ("WASM optionally run
        any app via system loop").
        
        Change-Id: I1b622065d7fa0c5ad03a7c7daaf8241dcc3f09a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128717
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-21  Miklos Vajna  <vmiklos@collabora.com>  [3eb6d764b3023500f2299d36bf1860bc8e67db9f]

        DOCX import: floating table with negative top margin has to be a fly frame
        
        The bugdoc has a large header, then part of the table goes into the
        whitespace of the header by specifying a negative vertical position.
        
        Keep this as a floating table as normal tables can't have negative top
        margins.
        
        Change-Id: I95299051f004976778765965971428d9764bef08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128724
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-21  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [dde74d2ec45976a1de58296e79d9301f2cb1c001]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66dc0fd6708f70b931f189d63ef140de7114dfa1
          - tdf#145517 Change “Icon Style” to “Icon Theme”
            
            The synonym can stay in the option’s description, to reduce translation work.
            
            Change-Id: Ie2a36ba5c5cc595516f503514e9ef5eebc59218a
            
2022-01-21  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9f16c3b5ac3ae1c9d24fe137ff48b67f54e4899b]

        tdf#145517 Reduce overload of term “style” in Options > LO > View
        
        Change-Id: I23e43e4fdbfb7caded2537e6b92ec74a5b996675

2022-01-21  Heiko Tietze  <tietze.heiko@gmail.com>  [d6e46baea0a5bfce83cf5af12631e4b0e3c1624f]

        Bump Glade version to 3.38
        
        Change-Id: I7f55bb36f6598a1be4547b3f212c8d7c9c7565e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128719
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0c6ee963e1f089cb73e0c68a28af29d0f8d9e0df]

        sc: fix VBA Copy-Paste using same and separate document
        
        This fixes 2 issues with VBA copy-paste:
        - VBA command Range(..).Copy issue where the range wasn't selected
        when copying and the copied cells were from the previous selection.
        The Copy command now does the same selection as the Cut command.
        
        - VBA PasteSpecial issue where the wrong view was used to get the
        clip document.
        
        - VBA Workbooks.Add issue where the new workbook wasn't activated
        after it was created, which causes an issue when running tests, but
        not when running in LO application. The Add command does now the same
        as the Workbooks.Open command.
        
        All the issues are supported by new test cases.
        
        Change-Id: I36ec45c01f18f7f76e4f95a25a28402a6ee0e2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128720
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-21  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [d769e75de28a1afbb1df31b48840626cb35ed7ba]

        tdf#122995 Trigger Chart refresh directly in UpdateCharts for SW
        
        For OLE/Charts in SW we do not (yet) have a refresh
        mechanism or embedding of the primitive represetation, so this
        needs to be done locally here (simple solution).
        To have the Chart already invalidated at the next repaint,
        I needed to add a 'immediate' mode to InvalidateTable.
        
        Note: The text there claiming that the framework should do this
        is correct, but as long as the mechanism is incomplete (VC/VOC/OC
        in SW) direct refresh is needed.
        
        Change-Id: I3c845b3ec46fbb494e7bce163cfe105145421450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128572
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2022-01-21  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [87fe449c4c1ed46003e9d5fdaf1919f11a53b959]

        tdf#140020: Disable also menu File->SaveAll for docs with LockSave
        
        If LockSave attribute is applied, docs with it are not affecting
        File->Save All menu item: these documents are not enabling this menu
        and also not saved during this process.
        
        Change-Id: I00bcd251fccfab3f13cb42c20ccb61b54ab49346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128650
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-01-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [399e92ddb7be6280465ddf5e6337f4831e152d97]

        fix ChartDocumentWrapper::createInstance
        
        which I broke in
            commit fe37aa64ff79abcd3aeedeb03d8d74798225a367
            Date:   Sat Jan 15 13:45:44 2022 +0200
            use more concrete types in chart2, ChartView
        
        by copying behaviour from the wrong construction site.
        
        And then in
            commit c592574948b0a28bac965b508bc260aaa6c365d3
            Date:   Sun Jan 16 12:25:49 2022 +0200
            use more concrete types in chart2, ChartView
        
        I spread the error further by using the incorrect behaviour I had
        introduced in
        the first commit in Chart2ModelContact::getChartView()
        
        Change-Id: I4b004b8893fa51b8968328b6a8b6ffde081f1269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  Miklos Vajna  <vmiklos@collabora.com>  [4871cae48c1c9f522a0c0cc85a852b0568ca31e6]

        comphelper: move JsonToPropertyValues() from desktop/
        
        Because filter/ code will need this in a bit, and that can't depend on
        desktop/.
        
        Change-Id: I07f0f8ef30942a2d11388c6721c7f277e117bfba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128709
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [b438a4502d2b388012b0744374e86d1ff0543e8d]

        tdf#140731: sw: move UItest to CppUnittest
        
        Change-Id: Ib72e03d2ca089ee86fa6d9dd4ae7d555be56ff4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128710
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-21  Noel Grandin  <noelgrandin@gmail.com>  [c53181f3e91d9b8612abbc53307c2a39ca1446f1]

        use more concrete types in chart2, Diagram
        
        Change-Id: Ib78f327c8bf1b71c3bb038c029b10e6fe54edaa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128708
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b682de9bd020d4fba9cafd6858d93c9a70416307]

        Removed duplicated includes
        
        Change-Id: I9f8350f44952692a9efef297792a2326086d3d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128704
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-21  Julien Nabet  <serval2412@yahoo.fr>  [5e5bda0accf10b80029e9fd40bbc2485d96b0695]

        Mysql/MariaDB: Clean mysqlc_tables + remove using
        
        So it allows to make the variable types far more explicit.
        It may help to differentiate the global mechanism from the specific mechanism
        
        Change-Id: I655824b97dbef5eab610d3b1535307b108245f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128699
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-21  Eike Rathke  <erack@redhat.com>  [fbdea6633be4c613b73278006f030c87440731aa]

        Output full non-iso locale names, not just language_script
        
        Change-Id: I3639dfff2da10afd711be37b6bfede44266c307f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128713
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-21  Eike Rathke  <erack@redhat.com>  [ea933cc3b6d72b1d7ff09c9e85286f4d3343f335]

        Related: tdf#139974 Keep HYPHEN-MINUS with a number to the right
        
        Force line break
        
        1234567890
        -1234567890
        
        instead of
        
        1234567890-
        1234567890
        
        but still
        
        abcdef-
        abcdef
        
        Change-Id: I0b427b33b05eea12d13aad148c604385ffe000d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128691
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-20  Julien Nabet  <serval2412@yahoo.fr>  [33d24b08677ef45ea7525d8f7f762f152988ea8e]

        Mysql/MariaDB: allow View renaming
        
        Strange bug the renamed view appears like a table but when closing and reopening the file,
        the view is indeed there as a view (and not as a table) and renamed
        
        Change-Id: I0f26fca66ffb0785ece6223df623845c5e015c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128707
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2022-01-20  Seth Chaiklin  <sdc.blanco@youmail.dk>  [d6f6a07c838d529680ab7b1260b003e19a89cc53]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b0d6bcb0c0703832e913fd0e42de43250b9bd1ac
          - Resolves: tdf#146733 - updating template manager help page
            
                - update position of "open" button
                - add icons for "open","edit","set default","move","delete","rename"
                - correction for "listview" icon
                - update labels for "import", "export", and "extension" icons
                - correction about editing built-in templates
                - move "move" and "export" entries to "individual templates"
                - correct descriptions for move, import and export, because they are
                     no longer buttons, but part of a context or dropdown menu.
                - move "tip" about move and export.
                - move general "tip" about templates from bottom toward top
                - adjust <h2> to <h3> for "move", "import", "export", "extension"
                - update instructions in Example 2
            
            Change-Id: I18a42999103b10d55cebafd51a9ed2c2e0efb87d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128345
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [23bf2c591f6a1523d436d28734394999bc8e319d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b14288f63c5147754507f085642ddbe512f9e9a8
          - tdf#135812 Add target HIDs for Manage Changes dialog
            
            Change-Id: Ic48fd22c1886cf1d671052149c5d500d62b20ba1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127948
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [43ecf9f6f28b6667f9ce3dd7c644d8fb67847650]

        gtk4: gtk_file_filter_add_suffix now exists to fill this gap
        
        Change-Id: Ia69b755f8a00621041de45974c4adf0d8c4b36f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128712
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Michael Meeks  <michael.meeks@collabora.com>  [0d32a186d6e52c7966191bbbaea7aa43aa90a99e]

        lok: avoid reundant progress bar messages.
        
        Change-Id: I9e04f428dbfafd98d1b08a549bb2758b9cc60eff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128674
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [f7c838f3d112727cc9cdba610f862355998ee009]

        gtk4: implement SalGtkFilePicker::SetCurFilter
        
        Change-Id: Ia147336c52422fb76600760526f3f020a052fd1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128700
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Stephan Bergmann  <sbergman@redhat.com>  [177387fa50e9e95a436584bea74613d4aee0be26]

        Add missing test dependencies
        
        Change-Id: Icd74795dfe912cb180ff2e0d86996915d6d5b013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128697
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [0b6de2227ca685881f794105d5124307dac667ce]

        gtk4: take SolarMutexGuard on key event handler
        
        Change-Id: Ifa195e02a2da1b530feb51f9473b41eb14e4e818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128698
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [4ed26badfd6fd9190cb6e54078b41eb38cb37dca]

        use resolution independent positions for writer's screen-rendering
        
        in favor of pushing it down to the text renderers and leave
        it to them to optimized as best they can the the rendering
        to make it look as well as possible.
        
        the separate ScrArray can then be dropped as a consequence
        
        Change-Id: Ic0849c091a36e1a90453771b1c91b8ff706b679e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128418
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [d798b2784f8aae25168555a6c8b1ccb3ffec79ea]

        gtk4: hide frame for gtk4 to pretty things up
        
        they were typically invisible in gtk3 and we mostly designed assuming
        that so it doesn't look great
        
        Change-Id: Iae44e3fd92b4c5ef7bea25174978477d75c03433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128690
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [36a186f28757eadb8fddac5887f5ebecebfe8229]

        tdf#139974: sc: Add UItest
        
        Change-Id: I2fe60ece55cd5f8298ed656fa043287eeaef1a53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128651
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-20  Michael Meeks  <michael.meeks@collabora.com>  [fc66855f1aa9fa7bcf28b417adf861e940200d89]

        sc: ubsan - initialize D&D pointers properly.
        
        Change-Id: I95c6a9b55ed25cc6d51f9f4544cb9fc016bbec64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128672
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-01-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [12a6b57c74aa555ab15de84c58d4698a14881752]

        WASM update README.wasm.md
        
        Change-Id: Ic38a7a0637ab007f12a6046655cb7d36e24fae33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128655
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [1ad8c5066bdb6ea825ad09d2a6c7f633b974fc69]

        Sorting component implementations needs LC_ALL=C
        
        Change-Id: Ifba53b95fdefed59123a2e682e787119b6c67857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128689
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [493d3558c6e6dce980cb92434f72c0ad03487aa0]

        Fix typo
        
        Thanks a lot to Valter Mura:
        https://listarchives.libreoffice.org/global/l10n/2022/msg00005.html
        
        Change-Id: I37467e1b9ba7cba2553be5df0d8324da8fe6c13b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128303
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [a557830dea9c287b11f3e610778acab94d03cdb0]

        centralize these GetTextArray uses
        
        no logic change intended
        
        Change-Id: Ide0a6afc30690d05647acf9bf1a0eccf72a9e60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [96607133f4457b31ddaee5808c04e96243ed99c6]

        Move credits link to config
        
        as all other related URLs
        
        and replace with a hub link, see https://redmine.documentfoundation.org/issues/3569
        
        Change-Id: Ic30f2a5980ae17b5dfff184ead391b21cff7ab7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128660
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2022-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [19e962d15c8febde84e56b10fd09fc22f824b814]

        use more concrete types in chart2, ChartModel
        
        Change-Id: Ic3020221111fea9c1026a91c72f7a2d1d5da42dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128666
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-20  Eike Rathke  <erack@redhat.com>  [81a5ba3cfc8b0d95724b38e7cc7cafdd83fb870d]

        Related: tdf#139974 Try to find boundary for forced line break
        
        So we break at word or number boundary, e.g.
        
        1234567890+
        1234567890
        
        instead of
        
        1234567890+123456
        7890
        
        (which in the sample case also keeps a formula expression
        functional).
        
        Change-Id: Ied01d76d8e30822d6e70c1bc2c1ca8609b0e3778
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128665
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-20  Michael Stahl  <michael.stahl@allotropia.de>  [f8ef102a82513233fb794109cecd599304e78407]

        ucb: webdav-curl: fix the debug logging more
        
        Unfortunately didn't work in the cases where it needed to work.
        
        Change-Id: Ia132ba38fb6f0be4481dce48da2d713d47fa8bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128658
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9578a19a2461aa1d788dc59df3fa43ac7f3de5f9]

        Fix typos
        
        Change-Id: I95ee74b281eb243e5d251bd5a099029ddfcda1e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128662
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2022-01-20  Michael Stahl  <michael.stahl@allotropia.de>  [03e8e1a408eef3c8acc5545416eda9d0938e21f7]

        comphelper: fix UAF in SequenceOutputStreamService dtor
        
        Change-Id: I91f77ee9ab4d509ebee3d04f94a3c63986de0ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128657
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [1499ba1213f353238ee4c5acfb4fc626c5f37ca6]

        Revert "can use the glyphcache for this GetTextArray call"
        
        nothing wrong with this commit, but there's a an underlying bug
        in the direction I wanted to go here.
        
        This reverts commit 5fc43fe24c24c58e401707fa6fffe9250186b99c.
        
        Change-Id: Id670d9331cf41a0d2dcc2a74792c1aa7db4ec284
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [17ec55c48082254e1f55bcfa00808e45a50a9801]

        Fail on non-optional, but filtered component names
        
        If any of the optional component lists contain a non-optional
        component implementation, fail the component file generation and
        show a diff of the offending component implementation name.
        
        Change-Id: Ieac876e613f6945362186d4586dd2aacc5669920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128645
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b39bdb65b39e86996c704cdfe14360ad317f3a1f]

        use more concrete types in chart2, ChartModel
        
        Change-Id: Ie38d941f855978b04995162040d8871a2577255c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128641
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [d6ea90ad273637d27487850bd97a1784a6bf8fa3]

        WASM re-activate and fix the Chart build
        
        Change-Id: I13c50ac005e1e990bd185115b6e1717ce2c6bb45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128654
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [4a0ccb5fec19c2f42b9c206d9c2007c355345eb2]

        WASM make test file loading work
        
        Change-Id: Ic34104534c3e0e73791cf867bfb2e1246dc79cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128653
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [9fbda3ca63c940dac566076eeeb54a7b33f3da3c]

        tdf#146294 Fix extended tooltips for Next/Previous buttons
        
        This patch also adds normal tooltips for the four navigation buttons.
        
        The corresponding help page will be updated in a subsequent patch.
        
        Change-Id: Ib7d77a643847e417cd66cf872739e39187555df1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127950
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-01-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [5c3ae3024891341c8bcf77ad6b22c2a8c74585c5]

        uitest: sc: make sure text is copied from the input window
        
        Change-Id: I17f163486f253bc80f40f13c01fb61187d8276e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128649
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-20  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [02140554ee1d70b219a42546191e2219d58be4b0]

        WASM --enable-wasm-strip now skips lots of LO code
        
        ... resulting in a stripped-down, Writer-only build to decrease
        the resulting WASM bytecode size.
        
        It removes the following code from the build:
        * All other major modules: Base, Calc, Chart, Draw, Impress and
          Math and related writerperfect filters
        * The premultiply tables
        * The (auto-)recovery functionality
        * All accessibility (but not the accessibility document checker)
        * The LanguageGuess component
        * EPUB support
        * The start center / BackingWindow
        * The TipOfTheDay functionality
        * The splash screen communication
        
        Currently crashs with anything different then soffice --writer.
        Closing the document also still crashes.
        
        FYI: many of these features are now behind ENABLE_WASM_STRIP_*
        defines, but they normally don't work on their own, globally!
        That's because we started with stripping the main components.
        
        Change-Id: Ib9c0f9452815910c0a2aceaf142ba1ad4a9cb0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126182
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Michael Meeks  <michael.meeks@collabora.com>  [02634fb7c7e8dc613ffc3717bb244f85cf81a7c6]

        lok: avoid duplicate emission of statechanged: messages.
        
        We tend to get many of these per keystroke, with the same state.
        
        Change-Id: I9d759f54aee8d6dabcef094997e8f352dd608ec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128539
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [1284937bf2bd112197a99e844a5a1a961e2cf4fc]

        ofz#43689 Direct-Leak
        
        Change-Id: I09823f30817163b0467b6b96f56956987337b991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [7b37a1a5144a3a4c8b0803b7e2da81e9e108bf66]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [65c27ed5aa3b5ee6bdc9f1c992428ab31cd0634c]

        cid#1497461 Logically dead code
        
        Change-Id: Ia8a7fe24e46d749f8837efb50145c66b0ecb5ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Miklos Vajna  <vmiklos@collabora.com>  [31bbaf478783e3a2c21bd3ea94ddf39299a63d1e]

        tdf#141340 PDF export: fix hyperlinks on the wrong page with page num range
        
        Regression from commit 01dbb38680aa39a4d3bc7afd05d44a4b2c9bc6ab
        (tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden
        slides, 2020-03-10), the problem was that the sd/ code that mapped page
        numbers between the model and the PDF output only handled hidden slides,
        but not partial exports.
        
        Fix this by revisiting the decision to handle hidden slides in sd/, the
        filter/ code at the end does have enough information to correctly do
        this mapping at the end, and this way both tdf#61274 and tdf#141340 can
        work at the same time.
        
        Change-Id: I5679743ca67fab562e14c73e32f1a06ead8e7a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128643
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [972aa39fb976e30ce73065b1eba69f4c78c17855]

        WASM open links in new browser tabs
        
        I quickly gave up trying to understand what exactly clashes
        between the Emscripten macros and OUString templates /
        initializers. Not sure it can actually be "fixed".
        
        Also disables the makeshared clang compilerplugin; currently
        there is no way to get rid of all the false positive hits
        when assigning the std::shared_ptr from a function instead of
        a constructor call.
        
        Change-Id: I8b13f179629ea63ff221584030556d2bedadc01b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128604
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Caolán McNamara  <caolanm@redhat.com>  [e9443070888628f7643741c1abcaaef28de6a53f]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ia19985b7c042e6ab9608220343e3b678890f7215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128638
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce8745f01a14a16c30e0ef62bc0a34ad4f7f4d0e]

        tdf#128375: sw_uiwriter3: Add unittest
        
        Change-Id: I24b862d23d2e8dd9fbe930043457963f4cceec1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128636
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-20  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [f4559274154324e132f82ba9c21676326f6db7e5]

        tdf#140019: Revert "Don't disable "Send doc via email" ..."
        
        Locked export should also disable ability to send document.
        
        This reverts commit b9930d0d05db39a8466b18dccf626bc3d8ae5c4e.
        
        Change-Id: I3b7b423c0e17a59872065ec7ceadbaf1cda45ccc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128550
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2022-01-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [a86669f4301541b446cab2e4fbbe1d86ba8a8a38]

        WASM show the compiled-in English help
        
        Even without XMLHELP support, the default English help strings
        can be shown.
        
        Change-Id: I0ac7a617d7209f70cc7c3cdd34bf0f17a5d4133a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128626
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-20  Julien Nabet  <serval2412@yahoo.fr>  [578d26b3160db5df03a6cf9dcd447fa38bb36ed0]

        Mysql/MariaDB: deal a bit better schema/table with existing functions
        
        In "Tables::appendObject":
        - Simplify code by relying on :dbtools::createSqlCreateTableStatement
        - Call "createObject" with "sComposedName" instead of awkward "sSchema + "." + rName"
        and since "createObject" decomposes its parameter with ::dbtools::qualifiedNameComponents
        we can also get rid of the ugly "CONCAT(TABLE_SCHEMA, '.', TABLE_NAME)" and just use "TABLE_NAME"
        
        In ODatabaseMetaData::getTables, we must remove "`" since it seems incompatible with LIKE
        (or missed how to make it compatible)
        
        Also remove useless Keys::dropObject.
        It seems we can rely on general mechanism since adding/removing primary key works
        and so remove m_pTable which also become useless
        
        bonus: avoid "using namespace dbtools" in mysqlc_views.cxx for 2 uses only
        Change-Id: Ic24ec84c61dea7d419fc3a05ded6545bf20455bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128579
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f7a5be583f0b3b99f7e9def6be8be02ae645bd75]

        tdf#106899 - Import concordance file using appropriate charset
        
        At the beginning of the import process for the various index entries,
        try to determine the correct character set for the tox concordance file.
        
        Change-Id: I3f48325a80ed08c2c06c295a24b2fc29ce1adf99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128194
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Jenkins

2022-01-19  Stephan Bergmann  <sbergman@redhat.com>  [9a540619334c80608960abdf8d3975884c45492a]

        Drop unused loplugin:externandnotdefined suppression
        
        ...that was added with the initial dac4ca5f682fdd0c3eee7f7ee1d98c9b3c8b7ce4 "new
        loplugin: externalandnotdefined" but doesn't appear to trigger any false
        positives when compiling the relevant source files
        
        Change-Id: I7ff8f49209ee426b87c89e1e64efb33eb98bf982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128562
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-19  Stephan Bergmann  <sbergman@redhat.com>  [d923625d89fdaa3881d5ad1fef75a8b728b74879]

        Let CppunitTest_odk_checkapi build against the SDK include directory
        
        ...which contains only the URE include files, rather than against the SRCDIR one
        which contains many more.  This would have prevented
        148536afc9838398100ca2267b99ab349dcbb38c "Drop config_global.h from
        osl/module.h", where an URE include file had accidentally started to include a
        non-URE file.
        
        (The way $(INCLUDE) is now set up in odk/CppunitTest_odk_checkapi.mk is a bit
        hacky, and this change required teaching compilerplugins about SDKDIR to avoid
        false warnings.  Another approach would be to make the test compile in the SDK
        build environment, similarly to CustomTarget_odk/build-examples, but setting up
        the SDK build environment from within gbuild is not supported at least on
        Windows for now.  A smaller improvement would be to drop the need to include any
        CppUnit include directories, by turning the test into some kind of compile-only
        test similar to a gb_CompilerTest.)
        
        Change-Id: If79761909c67c3162d01f847dfb5d4f538f91ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128591
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-19  Eike Rathke  <erack@redhat.com>  [2cfa04cbf03fe5c2ce32a7384082cdc5de5a4785]

        Resolves: tdf#139974 Do not munge character after forced line break
        
        A classical +-1 error..
        
        Change-Id: I8b6bc0843fa585d8a710c74f757098ab9c6f823d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128637
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-19  rafaelhlima  <rafael.palma.lima@gmail.com>  [e8e53b29777b60b136520b5dbb3f776ce9f04d63]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d37591fce4d79d229ccb4543eee9815935b3f34f
          - Fixes to pt-BR thesaurus
            
            Change-Id: I723bc49bc942c90e28db8cf9a5d25b45954601c6
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/128640
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-19  Noel Grandin  <noelgrandin@gmail.com>  [c6b8383e90c56efec87110f5303e64351aba9a1b]

        use more concrete types in chart2, SvNumberFormatsSupplierObj
        
        Change-Id: I15bb69bab11e374db2bfa2b964ba820063f01cda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128631
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noelgrandin@gmail.com>  [79a2b786d3c39a4a756fb13778e437a20758caf8]

        use more concrete types in chart2, InternalDataProvider
        
        Change-Id: Iee2cc56b00f0464e652a14eace2640e5d798eb5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128629
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noelgrandin@gmail.com>  [ea1cc9899a85e4379ea2c512d56d9b950c63b8f5]

        use more concrete types in chart2, UncachedDataSequence
        
        Change-Id: Ic5ca09567b74840c28d1c892a315476a6b7e9e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [49ebfdd9b7cf9c5363e3e06765b3fae284ab0379]

        WASM merge wasm-qt into static module
        
        Change-Id: I1ed26685561fd79d26cc0844faa3dfe4c00d439a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128625
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd5492275d31f59b1d269205018d1487af52426f]

        print out a debug warning when we ignore dodgy processing
        
        Change-Id: I92d758caea3942e6a2fccdf9eb1f8019c5acae14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128614
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [2064cdb1cd908a3ee55a54f0aeb4aee15f7c12da]

        use more concrete types in chart2, BaseCoordinateSystem
        
        Change-Id: I1c246a3ea37595647ac254f492170a9e18540794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128623
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [b7313bc131a285056906f85b51b0c3b53b7b3560]

        WASM add fontconfig data to FS image
        
        We probably want to pre-create the fontconfig cache in the image.
        Startup time still is not really worse for me, but YMMV.
        
        Change-Id: I419682339dd6d943753de9043ff82f2fb877b168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128624
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d9036fa313712a8aff9aee37bb3136a960fd392]

        Fix typo
        
        emscripten.py is not in the LO source, but in the emscripten project.
        Guess they were referring that one.
        
        Change-Id: I3ad2b4ad90420a554871cfd1aba94b447c275127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128619
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Stephan Bergmann  <sbergman@redhat.com>  [7e101d967328610de3d37b83ca68aca708e4ac48]

        Decouple SRCDIR/include from SOLARINC
        
        ...turning the latter into "whatever include directories are needed for the
        given toolchain and platform, outside the scope of LibreOffice".  This is a
        prerequisite for fixing <https://gerrit.libreoffice.org/c/core/+/128591/1> "Let
        CppunitTest_odk_checkapi build against the SDK include directory", which failed
        to find the C++ standard library headers (available via SOLARINC) on Windows.
        
        (In external/icu/ExternalProject_icu.mk, SRCDIR/include is needed for ANDROID to
        find <android/compatibility.hxx> in external/icu/icu4c-android.patch.1.)
        
        Change-Id: I960e31140b0839b2b6184a78d935042c3c558d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128615
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4dedeb5bd3f59e5fc912dc11ed1fecef0bb80660]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd1d33167a3b3fd460098d7c53529538aaf24938
          - Fix typos
            
            Change-Id: Iadee715d8804c383e57de3fce7e7d1f8a78d826c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128618
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-01-19  Stephan Bergmann  <sbergman@redhat.com>  [19de52a0a66323eefd9f82f148ff1751dc6af08e]

        Fix processing of first path in SOLARINC
        
        ...which does not have a space before the -I, so copying starting at pos+3
        dropped the leading character from the path.  This was apparently never a
        problem in practice, as the first path in SOLARINC happens to always be
        SRCDIR/include, which should not be needed anyway when building external
        projects with this GCC wrapper on Windows.
        
        (So this commit is a change in behavior, making SRCDIR/include available to
        those external project builds on Windows, but the follow-up commit
        <https://gerrit.libreoffice.org/c/core/+/128615> "Decouple SRCDIR/include from
        SOLARINC" will change the behavior back again.)
        
        Change-Id: I3f82a83683ed381b791d221fe1da78b9797aea94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128621
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [89790beaf8464d890bcb000ee0c784b86732c355]

        tdf#139638: sw_uiwriter3: Add unittest
        
        Change-Id: I7b98453b629734b4b07830687d1ec26b4bd468ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111834
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [dd30f90b3846c4fa7d8214c95a4ca31f2a7b3d72]

        WASM support external DWARF info
        
        merged into the --enable-split-debug tests.
        
        Change-Id: Id0f25bec08bd45daebb0ccd30d17a4feeb08d02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128601
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4683eaa6f92db03bd0a6ecd401ded51131db7ae6]

        use more concrete types in chart2, ChartTypeTemplate
        
        and return data using a little struct rather than std::pair, to
        make the call sites read a little better.
        
        Change-Id: Ieb6fc24e053f50823789167ed0112aa04a083725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128613
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [93133585b5b52e38defc3162eeb1e7704dceafcb]

        WASM optionally run any app via system loop
        
        Allows LO to run via system event loop instead of having an
        own one and processing system events as needed. Needed for
        WASM, so the browser isn't blocked, as there is no way to
        run the browser mainloop from WASM. Generally an alternative
        to running LO in a WebWorker and communicating to some
        frontend.
        
        Change-Id: I24955638827f3b8c04240845ffc781cd28f2aa29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128602
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [04a1d47e00f38a689ad84cbb86ba4cfb4692bb0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 16349874381940368315a7162e0e18ddde4edef0
          - Fix typo
            
            Change-Id: Ieb8d249536a6aeba31b5c6b28bd2a01a0c84421b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128617
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [ae22f7d06246ee21f9c8e9f35f4477e88843c58b]

        WASM add option to build with native exceptions
        
        Currently disabled, as literally no runtime has a working
        implementation. It also currently conflicts with LLVM's SjLj
        (AKA setjmp / longjump) when generating WASM bytecode, but
        the only offending code doesn't use exceptions, so this can
        be avoided in general.
        
        Change-Id: I2b338f3529e7350d54a7950772c6e7aae2282fe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128600
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [5f3b92f89767deda73620bc5e77e1933dfa81dcc]

        WASM add toolkit and Emscripten version to About
        
        Change-Id: I095cbb17accf04654a928bf0d89c0fbf1f443c9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128610
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [4565382ee6f8fec96f0df94c34a2567816291c2e]

        sw: generalize ModelToViewHelper to handle all NonTextFieldmarks
        
        Rename getDropDownsFor() to getNoTextFieldmarksIn().
        
        Move some code so that sw::mark::ExpandFieldmark can expand all
        fieldmarks that use CH_TXT_ATR_FORMELEMENT.
        
        Change-Id: I8a1e28fc0ad77df3a749d9e55c306cb45187a082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128606
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [ab6176e88f78d0b3aa2490fbc7858304c2d4a437]

        tdf#139638 sw_fieldmarkhide: hide fieldmark command in ModelToViewHelper
        
        The crash happened because the generated ToX text contained CH_TXTATR
        but the fieldmarks themselves were not copied.
        
        Just filter everything except the result of the fieldmark.
        
        Change-Id: I349e7793987624e64f5afe08dfa2ca977368156b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128605
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-19  Michael Meeks  <michael.meeks@collabora.com>  [2584950681b6485bb0772d2719cafee678cf7583]

        lok: avoid duplicate notification of tab-stop and ruler changes.
        
        We get far too many of these, one per key-stroke sometimes.
        
        Change-Id: Ifecffe0a82c6eef6809e3a49883bb3f17cb4d170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128535
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [96878d682cb298173cfc649271f0e92fc9f62dd4]

        use more concrete types in chart2, Diagram
        
        Change-Id: Id21836b1258b8757e634fc9ab670ef1180748469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128612
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [88b94aafc23348238b2d112682bc55719d1978a3]

        WASM create and link the Emscripten FS image
        
        There are three posibilites to add files to the image:
        - gb_emscripten_fs_image_files to add individual files
        - gb_emscripten_fs_image_autoinstall to add files from AutoInstall
        - gb_emscripten_fs_image_filelists to add files from a .filelist
        
        Change-Id: If6804e282a37a37ffae1d291d2af8430e60b59d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128598
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [c367a2781f99ed22d0f7d64184fb567aacc43f35]

        WASM UNO: add a minimal dummy bridge
        
        ... and use the same fake exception rethrowing code then the
        mobile platforms.
        
        Change-Id: Ic90de1cfd1e0092d6064d041a613d60d9f5f76b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128596
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb65cf92b91873bfd13c96250c782998f1eef337]

        add ChartController::getFirstDiagram code
        
        utility method to simplify some code
        
        Change-Id: I24225e993ef03e7e859a96e7ff2434df158c318b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f0f87108ab1560558c5b11185acc2bdfde150b8a]

        use more concrete types in chart2, Diagram
        
        Change-Id: I870f6d9fa4c0b51cf7c887199079fdbabbca1fec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128597
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Michael Stahl  <michael.stahl@allotropia.de>  [3170fba5dff3ea5cc67ea94f51a0dd5458f01edd]

        sw_fieldmarkhide: disable layout cache if there are fieldmarks
        
        ... similar to the "ShowChanges" check that is already done.
        
        This prevents a crash in SwLayoutCache::CompareLayout() on fdo38619-2.ott
        
        Change-Id: I1a90c45f041ae18beacd3fbd4dcbdae5ba86c317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128556
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-19  Miklos Vajna  <vmiklos@collabora.com>  [fde5f0083e71d68fcd2b3830e2944a4adada464c]

        vcl: remove FIXME in MetafileXmlDump::writeXml()
        
        Commit fff9163cd8ad27d251c06d0e903a71e185009d80 (Add ClipRegion cppunit
        test to vcl, 2021-06-10) implemented this, just forgot to remove the
        FIXME.
        
        Change-Id: I53f1ba385a0dfae5693313306089f72434e140ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128595
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-19  Caolán McNamara  <caolanm@redhat.com>  [ed31a7c85a167d346cc203ac83cf53878c60101f]

        crashtesting: use SetTextIdxLen and SetIdxLen
        
        as seen on loading e.g. kde112038-2.html
        
        Change-Id: I001733d63734d2138740afc74751b170fd268def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128594
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [7a9e4c4ba8c6b8e068005f3831b989e3c929e8eb]

        WASM add strip flags to configure.ac
        
        Doesn't include VCLplug flags and it should work with gtk3 too.
        But normally you want to use:
        
        --disable-gtk3
        --enable-qt5
        
        Change-Id: Ifea5e5b1e63633ff1fa709cdeb49afdb43fa0e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128588
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ab36ed96f9dce18bad751c67bb447d3783f3aba]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I36b6ac63ce62e0eb0e9bec951d582f39aed3be25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128592
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [a27296ded79e9eb8fa325ea05fcd560d171cabbd]

        WASM gbuild: add --pre-js dependencies
        
        Currently includes environment.js for general environment settings
        and soffice_args.js for soffice command line flags.
        
        Change-Id: I1166c5a9ae53c56a69b9223c865b4df525d07450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128590
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [f090004c5f236275ca5142fc578f0375872c0336]

        WASM adapt link and debug flags
        
        Changes the linker flags, so a debug build will not rewrite the
        WASM binary code for instrumentation, as this takes ages and more
        then 64GB of RAM, currently.
        
        For the same reason - long link times - prefer DWARF debugging to
        the external source maps.
        
        Initial memory and thread pool size are linker flags, so move them.
        
        Change-Id: I5cf39842e5091ef55b4fac719f881575e69fe8d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128589
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [c3d25b55990e2205af56747aa2935f4ff11ad0aa]

        WASM Qt: various EMSCRIPTEN adaptions
        
        * Don't create a native window handle
        * Use a static QMimeData for non-working clipboard
        * Use Qt::Tooltip for LO's popup windows
        
        Change-Id: I6b6edfa26466814cb0500116098eafcbe41bba26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128587
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [e76c7cf17827405344c995f5396cc21644f52213]

        WASM boost: fix build with Emscripten
        
        boost probably expects a WASI, not Emscripten.
        
        Change-Id: I7f275e1b501d6ea46d43637be815bf5a45b1cc40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128586
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [ad5563b4f210b32bcdd7a2efb167ce2c2745f9db]

        WASM setup as non-multiuser, desktop build
        
        Change-Id: I2ee6e006554cf1e5e5e42c2f4f73d8788bff8f4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128585
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [599cbdb9c2a1184680bb89aa2978e8003eca93d9]

        WASM more initial bits and pieces
        
        All the small stuff, which is needed for the WASM build, but is
        not really worth an extra patch.
        
        * No soffice.sh script needed for WASM
        * WASM soffice.bin executable extension is html
        * Some small additional SAL_LOG output
        * Default to colibre icon theme
        * Test for qt5 even without X11
        * Remove emconfigure artefacts at the end of the configure run
        * No oosplash for WASM
        * Disable the Office IPC thread
        * Suppress -Wno-enum-conversion for Cairo builds
        * Fix libnumbertext by using gb_EMSCRIPTEN_CPPFLAGS
        * Map EMSCRIPTEN to LINUX nls
        * No extra newlines for missing icon theme images
        * Print the missing dependency in some gbuild error messages
        * Copy Qt WASM loader, HTML template and SVG logo for binaries
        * Especially build the vcldemo for Emscripten
        
        Change-Id: I356370c72cc09357411e14d0c00762152877a800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128584
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Caolán McNamara  <caolanm@redhat.com>  [9ae9b3b47c24556b2bc9a100b3bde33273018c5e]

        ofz#43803 Null-dereference READ
        
        git show -w is your friend
        
        Change-Id: I2e451f3df4f093cb801dac0aaa61bc5a69aab0b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128577
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-19  Miklos Vajna  <vmiklos@collabora.com>  [4a7281fa206c0a82cfc2ba23f25c31ae775d8777]

        sw: fix unexpected paragraph border inside table cells
        
        The bug document has a table cell, which contains a paragraph with
        borders. Its left/right/bottom borders are rendered in Writer, but not
        in Word.
        
        The reason for the left/right border is that it's outside the
        paragraph's frame area, which is not rendered in Word. Fix this by
        clipping the rendered borders so they don't go outside the paragraph's
        frame area. (Normally the frame area is the larger rectangle, and then
        margins may cause a smaller "print area", but in this case we have a
        negative right margin, so clipping the print area to fit into the frame
        area actually does something.)
        
        This is quite similar to what commit
        1e21902106cbe57658bed03ed24d4d0863685cfd (tdf#117884: intersect border
        with paint area of upper frame., 2018-05-26) did for table borders.
        
        The bottom border is a different problem: the cell has a fixed height
        and enough content so the paragraph is cut off vertically. This means
        that technically the bottom border would be inside the frame area, but
        Word cuts it off, because they apply clipping on the not-yet-cut-off
        rectangle. Fix this by dropping the bottom margin when the frame is cut
        off.
        
        Change-Id: I7f65b68997330b247db65839db8a484e74f78c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128569
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc503bfebf8a9d4dc512d46bfcb01e8c8b4bbb93]

        use more concrete types in chart2, ChartModel
        
        Change-Id: I6fea07e7b9684b5333c908dbb353aeda58dd73a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [f4a1099abd5a5951f0993f197f33e0c7d1837501]

        Keep intermediate *.component.filtered file
        
        Makes debugging / understanding componentfile generation easier.
        
        Change-Id: I6c71d4d3787820320e95e3c075a08a0b9d756995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128582
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-19  Miklos Vajna  <vmiklos@collabora.com>  [82525bbd39d213d54d03b264fd78157e8f741f03]

        CppunitTest_sw_odfexport2: rework to avoid mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Id6d45cfa011a45b0e8ef9f486498d6a89af8e49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128574
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-19  Noel Grandin  <noelgrandin@gmail.com>  [25298b632f31b02b664c72fac91ae77d1531a9db]

        use more concrete types in chart2, PageBackground
        
        Change-Id: I432b77bab48c8574373daa00916ef6ceea4ebc93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128576
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noelgrandin@gmail.com>  [65c4b292afda53c1fffd9be3b88d4a5c535149ca]

        use more concrete types in chart2, NameContainer
        
        and simplify the NameContainer class, since it has only one use site
        
        Change-Id: I5b68b8985c22bb5eb37fa559aba1d5314c3d3aa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8a3ce5db8382a3769617c215cb0f7b1da611fe5]

        use more concrete types in chart2, ChartTypeTemplate
        
        Change-Id: I1bfbc81ca0d44efc669e5bc2b525cfa8b51be1ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-19  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [40bab1e31c7865f8c45883b8e4b684c0134b9191]

        tdf#145614 Convert #define to enum or constexpr
        
        Change-Id: Ib6694ec77c275c9a604abfa7d87df6ab262449b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128250
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [4a388f5e01ebb5a512931d11e48c4380382239c8]

        vcl: move eps functions to eps.cxx
        
        Change-Id: I0d61835d0964e18b578ec42b7002671310a8a36d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124603
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [64004f0c9d9c34baeef41b153a1ce1638852c527]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b1075e1e032be5bb6cba1dbdcc11de2a1824add
          - tdf#145332 Improve help pages for TRUNC and ROUNDDOWN
            
            Since TRUNC and ROUNDDOWN perform the same function, the help pages are now more consistent. The help pages were created in separate files.
            
            Change-Id: I68092c61f2cb80c66e798c188d9c4172de5d48c0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128244
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [d7070cdc8fc8383d53fe973d6f15cafe63f22a6c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a560f1347dfcf3f181bb827845fd33d1b22eddb
          - tdf#145060 Create help page for the Find toolbar
            
            Change-Id: Ifad2102915236ffe2098b1aae15d3e5c39bb2921
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128079
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-18  Gabor Kelemen  <kelemeng@ubuntu.com>  [c6620b4e538d21c1dfa321dde31b568eb8b8bd32]

        tdf#146612 Drop confirmation question when applying new doc hyperlink
        
        To be consistent with other tabs of the dialog where Apply does
        not show a similar question
        
        Change-Id: Id3bced8ec861b7166974da5ad223513dbfec25c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128424
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-18  Caolán McNamara  <caolanm@redhat.com>  [5fc43fe24c24c58e401707fa6fffe9250186b99c]

        can use the glyphcache for this GetTextArray call
        
        Change-Id: Ibe7c7ce788074e0990f3857e97a9ee037484577f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128564
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-18  Stephan Bergmann  <sbergman@redhat.com>  [42694bc5dbb2e2cab05bc476e70fd6f9fda7a23b]

        Drop useless readlicense_oo_DIR redefinition
        
        ...introduced with 7a9f6df7fb83ec23d09cb5744c2c865fa22e7143 "single source file
        for licensing info with conditional text", presumably in a copy/paste error
        
        Change-Id: I3166d53874262e35669988ea38601cdc953a0fce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128568
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-18  Stephan Bergmann  <sbergman@redhat.com>  [038894acbdd764ee54c344d49df9477502475876]

        The URE C/C++ include files don't use Boost
        
        Change-Id: I90baf9b2bf21c35f0b6de066b95483a39debb9a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128565
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e7b2b12292537e5c6d8b3885ab672187c14e213]

        use more concrete types in chart2, ChartTypeTemplate
        
        Change-Id: Ife0be0fde2f8d273411cbdbbafa2173ac80f80f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0d97c05696fa6f9c0f1f754158622bc352752346]

        Removed duplicated include
        
        Change-Id: I33d7a8ebfed47ec695cbd710aa6299096afb0733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128519
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [148536afc9838398100ca2267b99ab349dcbb38c]

        Drop config_global.h from osl/module.h
        
        Quoting sberg: "an include file like this one that is part of
        the published URE interface must not include an include file
        like config_host/config_global.h that is not part of the
        published URE interface."
        
        I did grep for other config files in include, but that missed
        the "ifdef LIBO_INTERNAL_ONLY" protection; most time this file
        will be included via some other header, so just drop it.
        
        Change-Id: I18b0792de3f8351efd00557a66d4ef8979ca6550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128555
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [aa06241b9c90cd41bed804bd1d55233b28f03886]

        use more concrete types in chart2, ChartTypeManager
        
        Change-Id: If5055256c3e3a20ab1a30e9c8bf46f453785e80c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128557
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [a8795a983b48ed7b9820b746fb70c173a7d230b1]

        Use "smart" INetURLObject ctor for user input right away
        
        ... instead of trying to process it strict, falling back to smart
        processing on error.
        
        Similar change was implemented to SvxHyperlinkInternetTp in
        commit 6b973753d407d66dfa5fda86547246c486ab7087. Trying to
        parse it strict initially there resulted in wrong detection
        of "generic" protocol in incomplete URLs missing scheme and
        having port. This change simply unifies the code, no specific
        behavior change intended.
        
        Change-Id: I48ba4187a27644f42f3fd5a3b6cd77e55038cb0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128534
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [21215562cde2378245a3641457c00e5fad82981a]

        sw: rename Sperren to CharacterSpacing in code
        
        Sperren is a German typography word related to Sperrsatz, which
        refers to increased space between characters. German UI calls it
        Zeichenabstand, English one "Character spacing". The English
        Wikipedia has an alias "tracking", but that seems as obscure as
        Sperren for most programmers.
        
        Change-Id: I2066bccac5e430b9ac2708559a6f2f262f2dea52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128554
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-18  Caolán McNamara  <caolanm@redhat.com>  [1ac3b903dfb3dfa6dd2282173dc847a324a282d0]

        this width is always overwritten before being read
        
        so drop this unnecessary calculation
        
        Change-Id: Ie79674098f947612e7f1f13de351f00d1d3ac41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [531f30b7387e45cc4616a92023fe0a6209f16192]

        tdf#146515: sw_ooxmlexport4: Add unittest
        
        Change-Id: Ib273156124a677fc774340dbd780393dfbd3070b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128548
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [a605f2f8fd3e848ed1229328144f948adea82256]

        fix locking in comphelper::OInterfaceContainerHelper4::forEach
        
        regression from
            commit a2eaf99e46f370ffb3b73828c2bdc53dc193b9a4
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Fri Jan 14 10:56:50 2022 +0200
            make comphelper::OInterfaceContainerHelper4 more threadsafe
        
        Change-Id: Iea42fd0bba6da99d82076b4d1b495d67fa62243c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [1103240cb3e884ea6024a690eeed743934662a12]

        tdf#145321: sw_uiwriter3: Add unittest
        
        Change-Id: Id64d3469ed1bd4c38e684c4af0c20121a81043fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128552
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [b5b1eae538a902fed165d5dd93ad6ddda3c5cb70]

        Add HAVE_(UNIX_)DLAPI config header define
        
        ..., add the configure test flags and rename DLOPEN_LIBS to
        UNIX_DLAPI_LIBS.
        
        Initinally convert two dlsym callers to use HAVE_DLAPI and
        osl_getAsciiFunctionSymbol.
        
        There are a lot of places, which still use -ldl and even more
        direct dlsym calls; good opportunity for many simple EasyHacks.
        
        Change-Id: I4f2d2f7cb079a075af8f9d01eb5ee45de40c7f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128523
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-18  Stephan Bergmann  <sbergman@redhat.com>  [31700036e517691d154701f4b8aeecb85cde607f]

        Avoid endless recursion in ImplSmallBorderWindowView::Init
        
        At least on macOS, some `make screenshot` tests crashed for me due to endless
        recursion, like the processing of modules/swriter/ui/converttexttable.ui in
        CppunitTest_sw_dialogs_test for LO_TEST_LOCALE=gu:
        
        [...]
        > ImplSmallBorderWindowView::Init at vcl/source/window/brdwin.cxx:557:20
        > ImplBorderWindow::Resize at vcl/source/window/brdwin.cxx:1736
        > vcl::Window::queue_resize at vcl/source/window/window2.cxx:1351:28
        > ImplSmallBorderWindowView::Init at vcl/source/window/brdwin.cxx:557:20
        > ImplBorderWindow::Resize at vcl/source/window/brdwin.cxx:1736
        > vcl::Window::queue_resize at vcl/source/window/window2.cxx:1351:28
        > ImplSmallBorderWindowView::Init at vcl/source/window/brdwin.cxx:557:20
        [...]
        
        where in the calls to ImplSmallBorderWindowView::Init, nWidth=24 and nHeight=31,
        as well as mnLeftBorder=6, mnTopBorder=6, and mnBottomBorder=6 remain stable,
        but mnRightBorder keeps changing between 6 and 5.
        
        This appears to be caused by instabilities in the
        ImplLogicToDevicePixel and ImplDevicePixelToLogic calculations in
        OutputDevice::GetNativeControlRegion (vcl/source/outdev/nativecontrols.cxx),
        which can be avoided when we compute a hypothetical native control region from
        aCtrolRegion that includes the borders, and only remove the borders from the
        resulting aBounds and aContent.  (The code to shrink aCtrlRegion prior to
        calling GetNativeControlRegion had been introduced with
        27be8a263eddb54cb6b66cc0f832bfd02016a694 "KDE4 fix edit box borders".)
        
        Change-Id: I88c0d15ae7045a6888768226ca4d5fdd66bb41ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128549
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-01-18  Mike Kaganski  <mike.kaganski@collabora.com>  [009e7406f2a1eb25aab4a3f0b647fa5c9f3766ee]

        Drop useless indirection
        
        Change-Id: I87f26e2a2cf10d3000b0955a6ba2d877ee92bdf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128547
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-18  Caolán McNamara  <caolanm@redhat.com>  [5d40e80926a309a0765023d0014fda1adce7ad63]

        tdf#146515 export "Use printer metrics for document formatting" to docx
        
        import already works
        
        Change-Id: Ia94c6d21ed2abc922a3f450a78dfaf3c331847ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128510
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-18  Michael Stahl  <michael.stahl@allotropia.de>  [d32e7ddb6497c3b36b86589765790dbfc3de335e]

        ucb: webdav-curl: add even more logging
        
        Some servers like to put error messages in the body if there's a
        problem, let's try to to dump that via SAL_INFO, unless it's too big.
        
        Change-Id: I9a29de59ab299f4bfda08ecc3be838972cf0c71d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128513
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [3122b12cbf7c0da2b717cbbd0b7848e02f1c7a6f]

        Drop unused HAVE_FT_FACE_GETCHARVARIANTINDEX
        
        Change-Id: Iececf24304d69b5f06903be52193bf3b222ce2aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128521
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [0941ff0add733f3da2bcf47506e7a74f3b9850a1]

        Remove now invalid using_vclplug info
        
        Follow-up on commit 5da906d07bf88bb9c56325d03272006d5a0662c4
        ("iOS+SVP convert remaining VCL plugins to salplug").
        
        Change-Id: Ifa2bee03c1cc107aaf22aedcbb08815d2623d57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128525
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-18  Heiko Tietze  <tietze.heiko@gmail.com>  [9585e88a811198585d91d37d4454c815529f7be9]

        Resolve gtk3 crash of If1ffb50743292f3cc0c3271646d0538337977762
        
        Change-Id: Id1080b71d1252bdcef804a4f8398a3c42073ee0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128522
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-18  Jim Raykowski  <raykowj@gmail.com>  [0e7e8bb7ed30cdb1dee7ca72748c742657b19dab]

        SwNavigator: disallow tracking update when content tree has focus
        
        When document layout has not finished and there is no content to track
        at the cursor position, e.g. the cursor position is at the start of a
        document having text before the first heading paragraph, a selection
        made in the Navigator content tree can automatically unselect. This is
        not only annoying but causes a crash when action of a choice from
        the Navigator context menu is dependent on entry selection, e.g.
        'Delete', 'Edit', 'Rename'. This patch prevents this annoyance and
        crash by disallowing content tracking when the content tree or the
        content tree context menu has focus.
        
        Change-Id: I2b0fd1ac4f53571e30ce1efa2934a70de2aad819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128520
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-18  Miklos Vajna  <vmiklos@collabora.com>  [078d9da95f6e32965b99248eb61e6e7b859ef150]

        RTF import: handle the pictureContrast and pictureBrightness shape props
        
        Map it to (the UNO API of) GraphicDrawMode::Watermark, similar to what
        the binary import does in SvxMSDffManager::ImportGraphic() and how the
        drawingML import does it in
        oox::drawingml::GraphicProperties::pushToPropMap().
        
        Change-Id: I8023aa8fcbd086d4c7a30729e3ca615a7356da4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128515
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-17  Stephan Bergmann  <sbergman@redhat.com>  [5db574727f4564238a54159a1a0673eaa2884b69]

        Avoid -Werror=dangling-pointer=
        
        > vcl/source/bitmap/Octree.cxx: In constructor ‘Octree::Octree(const BitmapReadAccess&, sal_uLong)’:
        > vcl/source/bitmap/Octree.cxx:69:17: error: storing the address of local variable ‘aColor’ in ‘*this.Octree::mpColor’ [-Werror=dangling-pointer=]
        >    69 |         mpColor = &aColor;
        >       |         ~~~~~~~~^~~~~~~~~
        > vcl/source/bitmap/Octree.cxx:67:21: note: ‘aColor’ declared here
        >    67 |         BitmapColor aColor;
        >       |                     ^~~~~~
        > vcl/source/bitmap/Octree.cxx:67:21: note: ‘<unknown>’ declared here
        
        (new with GCC 12)
        
        Change-Id: I5b1ffa15b92f2c41dbe51dfa843eb6bab3a4b449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128517
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-17  Julien Nabet  <serval2412@yahoo.fr>  [911b10395433d1e3c11e92ef7b2720bf2dc2e3d8]

        Mysql/MariaDB: copypasta from Firebird part, no pb for table renaming here
        
        Change-Id: I58cb94376e8cf7f06cd825ee7019fb5e9726fc9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128516
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [703167d4fb6e1d1e7bb72bfd79cfa0ae140ca89f]

        tdf#146731: sd_layout: Add unittest
        
        Change-Id: I50e7c1e89a217c845612d02942a22d9ef1abbea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128511
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-17  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [e7b01e4a5a856543e85f614c82950122e9598518]

        tdf#145538 - Use range based for loops
        
        Change-Id: I5bf5a88d40f9633d9af9c40df2ee927130701f91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128318
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ec81837cba7be61b41fd475e14172bc813a7046]

        sd: this is actually a layout test, move it to the right file
        
        Partially revert fa5ab8aa5d88e7128015127af75980a65f945cbb
        < tdf#135843 Fix the missing border handling >
        
        Change-Id: Ib80530c9e46e029c910843beac0d55dbd393af3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128512
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-17  Eike Rathke  <erack@redhat.com>  [0d6ab8d4ea7226db53d07dc158e176fe962fd8d9]

        Resolves: tdf#146757 Use correct format index keys instead of wrong hack
        
        The hack worked by accident as long as the internal index
        constants didn't change. Which was the case with
        
            commit f7d0c6b42a0a5ec98876006cd5048589219be741
            CommitDate: Thu Sep 23 20:28:42 2021 +0200
        
                Sort ZF_STANDARD_NEWEXTENDED_DATE_... into ZF_STANDARD_DATE category
        
        convertDateString()
        Standard + 36 == old ZF_STANDARD_DATE + 6 => DATE_SYS_DDMMYYYY
        unchanged
        
        convertDateTimeString()
        Standard + 51 == old ZF_STANDARD_DATETIME + 1 => DATETIME_SYS_DDMMYYYY_HHMMSS
        became wrong nothing (no format assigned, empty DATE slot)
        
        convertTimeString()
        Standard + 41 == old ZF_STANDARD_TIME + 1 => TIME_HHMMSS
        became wrong ZF_STANDARD_DATE_SYS_DMMMMYYYY (DATE_SYS_DMMMMYYYY)
        
        So time 08:00 double 0.33333... was converted to string
        "30 December 1899" which then numeric was 0.
        
        Change-Id: I642e0a977d4e167f78537d20624e86721e518c54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128507
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [52b15c66c90b53f0e663acfcf1b9cdb49c3d564d]

        Use convertTwipToMm100 directly
        
        Change-Id: I776f5c1babca523c476a5a094ed219219e1c89c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128445
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a827738a57b1ee0c050d4672f27810be36901464]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d7f7d5045e12127006f92247e7df56076c65f0ba
          - Remove inacurate statement on regex Help page
            
            Refer to discussion in patch
            
            https://gerrit.libreoffice.org/c/help/+/73408
            
            Change-Id: I543e052609ca4330f52a2c4ebae7189a2275ba75
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128509
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2761545769ef564b14fc8cd854a35c42bc269f02]

        loplugin:finalclasses in chart2
        
        Change-Id: I6cc88d50df7a6c77285f8534de43fd0c8d251bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-17  Caolán McNamara  <caolanm@redhat.com>  [bb495c6a2f00346698a041bce69a5a97effc79d7]

        tdf#144862 set default render mode to LayoutAndMatchRender
        
        Change-Id: I7340d7b7802a58922635fe49a4f15e085505e409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128499
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [44c05a9ae8de321875f2e9868b7bb1046eccd64a]

        Drop unused declaration
        
        Change-Id: I17cd0d144b64fc6bfc8ce10f1de2db3ce4565ac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7a101c5ced5f634e7b661062a74c637e48ba1f2b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to df6f47ebcb1caf2a9791661de0fa8c484efd0515
          - tdf#129697 Use LIBREOFFICE instead of GLOBAL as index heading
            
            Change-Id: I8c00eb4ed888eb8b2e898144141ef1c5a659bb49
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128503
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-01-17  Mike Kaganski  <mike.kaganski@collabora.com>  [503f10205559673185150110c2d2a2faacab1fcb]

        vscode-ide-integration: use gdb from $PATH by default
        
        Change-Id: I6f69439465b2968c5ab3900dbb9d5591c1c1f800
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127360
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2022-01-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [aede2a0234f3d62d4bb89e0f638b7bb1304d9163]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96608a0e847be46c1429e5711b08e7a0c2b66e68
          - tdf#89805 Document "Always apply manual breaks" option
            
            This patch also refactors headings to use <h1>, <h2> and <h3>.
            
            Change-Id: If886313cd9e140246016d8c6537f4267c1d4b0a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128431
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e4bcbb67dda204ba78f99df68a63458c29e7470]

        tdf#145321 Crash scrolling DOCX to bottom
        
        this is a consequence of
            commit d4dc6b5cfdb02ad00a06ad32650948648abe010d
            use std::vector for fetching DX array data
        which made pre-existing bugs easier to see.
        
        This crash made apparent that we have bad data ending up in
        SwDrawTextInfo. So I added some asserts there to catch that.
        
        However, that simply made apparent that there are bug(s) at
        a higher level that I have no idea how to to fix.
        
        So at the primary problem site in
        SwTextCursor::GetModelPositionForViewPoint I clamp
        the values to sane ones.
        
        Change-Id: Ic74f6944932bbfc22e8cf9addf9e7511755b18be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-17  Miklos Vajna  <vmiklos@collabora.com>  [bbc4360b5beb012adf1e2652328d3e18d66224aa]

        SVG export: fix missing custom bullets
        
        It seems this was broken since b76628acb1ae4fc06f8c1b70ec2e0cf39356deef
        (text export support for bullets and hyperlinks, 2012-08-11), the
        problem is that SVGFilter::implEmbedBulletGlyphs() has a fixed list of
        characters that are typically used as bullets, but e.g. "-" is missing
        from that list.
        
        Fix this by improving SVGTextWriter::implWriteBulletChars() to continue
        working from those shared glyph paths when the glyph is in the fixed
        list, but otherwise call GetTextOutline() to look up the path for the
        custom bullet.
        
        Change-Id: I3de8fab8dc6c78e273629d13566d1f9f289eb752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128495
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-17  Gülşah Köse  <gulsah.kose@collabora.com>  [586a0f149f332c0b0e53c0bb30568d4bd411b0e3]

        tdf#135843 tdf#146731 Fix the missing border handling
        
        Reverts fa5ab8aa5d88e7128015127af75980a65f945cbb inside. And fix the
        missing border problem with better way. Reason of the problem is using
        ORIGCELL cell style for bottom and right of merged ranges is wrong.
        
        Eg: We have Row X Col 3X3 table. (0,1) and (0,2) merged. The right side
        of right border style should be same with (0,2). But ORIGCELL points (0,1)
        instead. In case we should use LASTCELL. Same reason is valid for bottom case.
        
        Change-Id: I5282083541f0bd02f3765943da4f34cabe05ef13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128493
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
        Tested-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-01-17  Jeff Huang  <jeff@mail.ossii.com.tw>  [0596ef354ee8d40976c6be044a646757240f7921]

        tdf#136362 Remove unnecessary blank area and option in some image toolbar
        
        Only in Calc, Draw and Impress.
        
        Change-Id: I944aad875fedd1dd19657c49b059e33fd6e9d3f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127984
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-17  Caolán McNamara  <caolanm@redhat.com>  [84dc0f3dc044ab13e3d8638433d2b5533fc55aa0]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128496
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-17  Caolán McNamara  <caolanm@redhat.com>  [a6b1f367419e2b3645f37b572736f3d504520c16]

        ofz: Use-of-uninitialized-value
        
        Change-Id: I77847175d5ad0b2757eb24fcff08a4caf5d77519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [5da906d07bf88bb9c56325d03272006d5a0662c4]

        iOS+SVP convert remaining VCL plugins to salplug
        
        While this makes the preprocessor usage even larger, the code in
        salplug.cxx is now hopefully easier to follow. I added a comment
        about the main code structure at the beginning.
        
        It also includes changes to the generic plugin list to include
        gtk3_kde5 before gen, qt5 and qt6 after gen, but still skips the
        headless / svp plugin.
        
        And I explicitly excluded salplug.cxx from the externandnotdefined
        compiler plugin. I could have added a dummy, but that seemed not
        worth the effort. My try on a non-dummy with correct includes and
        defines made the code in salplug.cxx much harder to follow.
        
        FWIW, the iOS VCL plugin actually seems to use the osx SalData, so
        I think these changes to iosinst.cxx are more correct then commit
        7d990aafdc363b2a12b5db78637d7f3bef7780bd ("VCL drop m_pInstance
        from *nix SalData"). But hard to tell without a compiler.
        
        Change-Id: I0e2944d4221ca5910fb2120cc8b24def5c5b3f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128477
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-17  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [6985f81b528b0e06bd3b11160c35ed2d4a999845]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21f7faaea2017e085b030d4c40c24067e37a1ee5
          - Related tdf#123318 Fix harder and update Base URL path
            
            Base Help used to be generated into the path shared/explorer/database
            
            Change-Id: I977dea766c621c0387c78238b65e45b5d4017929
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128450
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [4b8cef4f6e3a4eb5969631485a7c725252f3cabc]

        Add <module>.*all aliases to .all* and update help
        
        And just echo a rename info for the 'all' target and exit with
        an error, so people will actually adapt. 'all' had been modified
        to run 'allbuild' in the original commit anyway. And since there
        is no toplevel 'all' target, this just seems consequent.
        And .PHONY the new targets.
        
        Also advertise "make help" a bit more at the end of configure.
        
        Follow-up on commit d6496fce2e51a3e44753e6b5c462824f182b48d5
        ("split gbuild's <module>.all to <module>.allbuild or .allcheck").
        
        Change-Id: Ia74020375f0a024dc67ea37ae4b18655af9df084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128490
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-17  Caolán McNamara  <caolanm@redhat.com>  [df044d1558d340e51d42264f212c3247c534f6da]

        ensure glyph fallback would use the correct dxarray variant
        
        Change-Id: I4f7183f2f038bcc780e9438b04ee4d15b945d065
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-17  Miklos Vajna  <vmiklos@collabora.com>  [d64afaac3411ef74d16ca24cb4b5aa5254ea6f36]

        sw: prefix members of SwTableFUNC, sw::sidebar::PageFooterPanel, ...
        
        ... sw::sidebar::PageFormatPanel and sw::sidebar::PageHeaderPanel
        
        See tdf#94879 for motivation.
        
        Change-Id: I68ac0ba7d36ae9217a98d90245cac104c636fe1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128492
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-17  Heiko Tietze  <tietze.heiko@gmail.com>  [c32994e22ff291b0227ed74de6d0d050cf0901c8]

        Resolves tdf#143733 - Make selection border wider
        
        Border width and handle size follow the zoom factor now
        Border is drawn evenly inside and outside the rectangle
        
        Change-Id: I83cfb8a8156e2f0346ded3e2abed4386d4006d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128222
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-17  Dhiraj Holden  <dhiraj.holden@gmail.com>  [5b07acbf3345918f450fccf7ee243ad5bcb3fd67]

        tdf#142450 add code to store showing whitespace
        
        I have put in code to store the option to show whitespace.
        This option is stored at the document level like the other
        layout options.
        
        Change-Id: I26989da2714f884a5a4d5ced3329ff669771fe7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126497
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-17  Gabor Kelemen  <kelemeng@ubuntu.com>  [e3206e67402f623bac17ca94a20dfb45391dcb48]

        Recheck modules [e-f]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-16  Julien Nabet  <serval2412@yahoo.fr>  [52443996eff721e612ac4afc1eb1a53bb8a3e06f]

        Mysql/MariaDB: implement edit VIEW with GUI or SQL
        
        Delete View works (and the list is updated)
        Modifying View works
        
        But, there are at least 2 things to fix:
        - adding a view still works but the list isn't updated without manual refresh)
        - renaming view doesn't work (a popup error message appear)
        
        Change-Id: I48ffb322910ca64d51a161424f265de387bdd7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128483
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-16  andreas kainz  <kainz.a@gmail.com>  [7a2042dc00c72ac074a21c2c324ace5eac89a5f0]

        tdf#146421 Calc Sidebar Alignment Section follow arrangement guideline
        
        Change-Id: If1ffb50743292f3cc0c3271646d0538337977762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126688
        Tested-by: Jenkins
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2022-01-16  Jim Raykowski  <raykowj@gmail.com>  [bf28e1df0a04cf6a06d9c4cf591e238a45a34ec1]

        SwNavigator: use one loop instead of two to fill fields member list
        
        Change-Id: I02f20e48606a34b2f9f4739f1777dd8aea8637ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127798
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [8728cebf75b127e5a0d6a043bbed40a1c9e34641]

        dump AltNaturalDXArray if present
        
        Change-Id: I3410a7c4c999e660b2df69dcea8f7c5bd7fa3196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128486
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [e8b45704fc8d41a42d2272cb14bb40ee59516768]

        add missing placeholder labels
        
        Change-Id: Iae743fd6d7e13f91501e386e609e5965ef742db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128482
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [3fcfa152c5a12f549aed9d6c8261017f2ad75df3]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ib1c3b306573dda073f6ff3d7d0cc17aef39c0a0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [95ade11df658d73e90d196f041d0839895aca3f0]

        tdf#146453 retain precise vertical base pos with ResolutionIndependentLayout
        
        Change-Id: Ied157d8d4bc9b57cfa17716453189ddf48cba641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128485
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [99460be87a11a404ce6c055fc540ec7ece404fb6]

        Related: tdf#146453 retain accurate positioning in rotated text rendering
        
        Change-Id: I477c5a72dd9618a2b0f3e91a96209ae3f6b3d1aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Julien Nabet  <serval2412@yahoo.fr>  [276258618b9ab548927a6c5df0cadba11994b70b]

        Firebird: missing space in DROP command
        
        It's more to have something clean.
        Indeed there wasn't impact on Firebird since the table name is surrounded by quotes,
        eg: DROP TABLE"TableTest"
        
        Change-Id: Iad525ccb912347798c6780fd1a5bac12ee85333f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128488
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [ffb5915c08314f1ec1b71f28b108060771a0a545]

        restore the explicit translatable="no" for some labels
        
        Change-Id: Ifbb05dc12a02afd11470e868b88d72fa18c1a388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [aa460a757431afc7408d08569142e6c0e3f6f301]

        ofz#43689 Null-dereference
        
        Change-Id: I6edb50b3c281d50187d8965ce9665a9aae0e9098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-16  Jan-Marek Glogowski  <glogow@fbihome.de>  [ced4cde59eb51e4364daf69520a184b55c2c54db]

        Qt notify LO of many QScreen related events
        
        LO just has a single display event, SalEvent::DisplayChanged, Qt
        has a multitude. So this will generate multiple LO notifications.
        I don't see any reasonable way to prevent that. Doesn't seem a
        problem here.
        
        Change-Id: I2f11e53765869a4ca292a1d337347e4e7470e3c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128474
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-16  Noel Grandin  <noelgrandin@gmail.com>  [c592574948b0a28bac965b508bc260aaa6c365d3]

        use more concrete types in chart2, ChartView
        
        Change-Id: I51d503cd71ef2adc0e590ef836dabf9906495bbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-16  Noel Grandin  <noelgrandin@gmail.com>  [5a4b75dcb5abc2e925870614a28e1c2876df8ed9]

        use more concrete types in chart2, Diagram
        
        Change-Id: Iae84e16b3406f4c08139764a1838e38b13cebee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128471
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-16  Caolán McNamara  <caolanm@redhat.com>  [dab0d4e1f36faace21145a51733bd3a946992624]

        tdf#146439 retain precise base start pos when using ResolutionIndependentLayout
        
        Change-Id: I16a585abf4805d87a2eeb4e3e9d9bd9f2697b838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128472
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-15  Caolán McNamara  <caolanm@redhat.com>  [dd497f18e5a5aaa5d1116e87b12ea23d619088e2]

        include memory for std::unique_ptr
        
        Change-Id: I63aa82b45f3dfcfd89d5d655eae3b347c1092af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128470
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-15  Noel Grandin  <noelgrandin@gmail.com>  [e1802876e0773d57631f6a8f773fafaf4cfc7926]

        use more concrete types in chart2, ChartModel
        
        Change-Id: Iecbc92aa096ede1845936faa708d1a9e8747b658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128467
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-15  Julien Nabet  <serval2412@yahoo.fr>  [cec7cce3798eb0961496d0f896d782aeb2fc0a5f]

        Mysql/MariaDB: make rename table work
        
        by just letting general mechanism deal with it
        
        Change-Id: Iac70137c94419b719266f31222205d651d18b43b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128468
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-15  Caolán McNamara  <caolanm@redhat.com>  [4342717dcd580d5aea4e35636d4e35a4ea055d36]

        include memory for std::unique_ptr
        
        Change-Id: I15f78ecfc53e75403bb8edbcd6e5400e8ecaaa44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128465
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-15  Eike Rathke  <erack@redhat.com>  [26b3fc1f31b682fcc7ac0c10af07e64cffbe86e7]

        A unit test for tdf#146367
        
        Change-Id: Ie47f1525f387d019c7c1131a76faf3784ee99d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128466
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-15  Stephan Bergmann  <sbergman@redhat.com>  [29bc12777ceffd00ed0ae103b8f2affa26897b4e]

        Let loplugin:nullptr look into template instantiations
        
        It missed some occurrences of 0 when only looking into uninstantiated template
        code, as Clang doesn't model them with an ImplicitCastExpr, even if the target
        is known to be a (dependent) pointer type.
        
        Looking into all template instantiations of course carries the risk that a given
        use of 0 is meant to be interpreted as a pointer in some and as an integer in
        other instantiations.  But the only case where that happened in the current code
        base is RegistryValueList::getElement (include/registry/registry.hxx), where {}
        is arguably a better choice anyway.  (And which would presumably also hold for
        any future such cases.)
        
        Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-15  Noel Grandin  <noelgrandin@gmail.com>  [fe37aa64ff79abcd3aeedeb03d8d74798225a367]

        use more concrete types in chart2, ChartView
        
        Change-Id: I7316d01d08eb1d9d482937fdd87bd34e2ae7e3c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-15  Noel Grandin  <noelgrandin@gmail.com>  [abb6978cabd3ef5d0bf086a388af7be6e144907e]

        remove XTransformation UNO API
        
        unused after
            commit 18bc9ea75daf4eb3520a4d0ef6649d92261012a6
            Date:   Tue Jan 11 15:02:14 2022 +0200
            replace XTransformation with more efficient class
        
        Change-Id: I9e6bf80d8a8cdba8514ad0e94ce090bdbceab853
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-15  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [5448ad57032df1113daf1c3899741febc069d8b3]

        Allow g to run git gc command
        
        Change-Id: Ibca338cbd99839b20a2373075a2e544e7ab638e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127870
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2022-01-15  Caolán McNamara  <caolanm@redhat.com>  [f005fe8e463695cb701f343c32777fe4d48159ed]

        request the 2nd rect explicitly instead of one with a particular 'top' value
        
        Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-15  Julien Nabet  <serval2412@yahoo.fr>  [bcc61497fc954efa7ebb8cef7ad3020d360a813f]

        Mysql/MariaDB: related:tdf#81430, fix regression refresh tables/views manually
        
        Change-Id: Ia17a396a8d55e38ac8ad42fab90c50bfaf96809e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128459
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-15  Eike Rathke  <erack@redhat.com>  [730b8aba72356bb8ba0066a5517b1224a4f1e232]

        tdf#146367 reintroduce approxAdd() similar handling with last summand
        
        ... to tie result to 0 eliminating opposite sign small equalish
        fractions.
        
        This does not "fix" all interim values of the bug's sample document,
        which repeatedly adds single values in sequence using SUM() and should
        use the + operator instead to benefit from approxAdd() for each, but
        maintains the better accuracy of Kahan summation in the not near equal
        zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting
        in 0 with all permutations.
        
        Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2022-01-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0c141900b49c2efeb0535dbcbea94f7b9b6aacd2]

        Change cursor -> pointer in spreadsheet option tip
        
        Change-Id: I4fe40f321849846daaddd1c9374a0271689b5823
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128425
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-01-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e19f4c1a1c24de32043c6d94394d048e1dc63dba]

        Fix extended tip on printer options for speradsheets
        
        Change-Id: Iad153527e4ee4b74cb9d7bf6a57821a9f13f1f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128426
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2022-01-15  Heiko Tietze  <tietze.heiko@gmail.com>  [d73602dc51aa8829fc88e5e67e2b0c4da6b8f715]

        Resolves tdf#139395 - Redesign of font name and effects pages
        
        * Western/CJK/CTL selection placed into a GtkNotebook
        * Font color and transparency in one line
        * Alignment adjusted at font effects page
        * Char-, para- & style dialogs made non-resizable according the guideline
        
        Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-15  Julien Nabet  <serval2412@yahoo.fr>  [ff3720c4747b9b75e3886163bc61e2e58a5aabb5]

        Mysql/MariaDB: related:tdf#81430, fix regression create table
        
        Change-Id: I8f2983c1d08026ad0cbe796f73e0ff44f917de17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128458
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6b973753d407d66dfa5fda86547246c486ab7087]

        tdf#146754: consider xyz:123 as host:port when parsing URLs smart
        
        ... rather than scheme: and path.
        
        Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-15  Julien Nabet  <serval2412@yahoo.fr>  [be27b6f0bb73128ad4970fc5649c93d546822a84]

        Mysql/MariaDB: related:tdf#81430, fix regression drop table
        
        Change-Id: I4b021847cfe855061b862006fbdc4ac36797ee09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128455
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-14  Julien Nabet  <serval2412@yahoo.fr>  [628fedabdd27ad08e9a42f47106864751e493c2c]

        Mysql/MariaDB: tdf#81430 make tables editable (with or without PK)
        
        Change-Id: I7df464107e692817ef80d887a4addea618d6cc72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128356
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-14  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [8be1888ede5b17bae7e5ee239011a9156b9c7614]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 143eb86de536e863170222617485c3e7f41d628a
          - Related tdf#123318 Fix filtering with SHARED
            
            Change-Id: Ic704b5ddcc0448a884da4ca01fa54bb94692495f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128423
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2eaf99e46f370ffb3b73828c2bdc53dc193b9a4]

        make comphelper::OInterfaceContainerHelper4 more threadsafe
        
        (*) make all the methods that require an external mutex take a
        std::unique_lock as a parameter, so that call sites cannot forget
        
        (*) make the forEach method drop the lock when firing listener methods,
        to reduce the odds of deadlock
        
        Change-Id: I0a80e3b3d1c1c03b7de4a658d31fcc2847690903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [49a5e69f567302633299bf6626a9d9b9544ee94b]

        Removed duplicated include
        
        Change-Id: I080325a828d26a9d3fd93542315b3c4f5f1584e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128421
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-14  Miklos Vajna  <vmiklos@collabora.com>  [60c0242bbc05be0a5accc28f17a688124717590e]

        sw tests: audit uses of loadAndSave()
        
        When it comes to changing import + import-export-import tests to do only
        import-export instead, this is only safe if we assert the resulting
        exported XML.
        
        Replace calls to loadAndSave() with loadAndReload() when we want to
        assert the doc model after an export.
        
        Thanks to Justin for flagging this, luckily it seems there is only a
        single test that fails after restoring the lost asserts
        (and that has already been fixed).
        
        Change-Id: I62cd4330c62d801dd9e6c7ef73decab3972c0b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128411
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [e9da6bdabaf2e5b49c78e7ba54243f8f33622b15]

        VCL move SolarMutex (un)locking into (De)InitVCL
        
        Fixes all the backends, where SolarMutex access needs SalInstance.
        The ImplSVData::SalInstance is just set fron the return value of
        CreateSalInstance, so it can't be accessed earlier, globally.
        
        Regression from commit ad94bb5d23d9c4ecbb2ca84807f01623862de43e
        ("VCL drop m_pInstance from *nix SalData).
        
        Change-Id: I13259009571a9973ea7e3ded20c0ea4c660ee214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128420
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [cb4e90c05fb26f37124b5d4bcf15bd1736c05850]

        tdf#146375: sw: add UItest
        
        Change-Id: I8d165b257f4bee3921f1a4624a7797ed22327e40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128419
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [7d990aafdc363b2a12b5db78637d7f3bef7780bd]

        VCL drop m_pInstance from *nix SalData
        
        AKA the "*nix SalData untangling" commit.
        
        The original plan was to get rid of vcl/inc/saldatabasic.hxx and
        even SalData for all the *nix backends. But after many backs and
        forths, reinspecting the code and imagining the resulting code, I
        decided against that plan. All these variants would have resulted
        in reinterpret_cast calls, I wanted to prevent. And they would
        have required larger renames for no benefit.
        
        An other, related idea was to include all SalData implementations
        in the vcl/inc/svdata.hxx header, but that seemed like an include
        explosion, so was also dropped.
        
        I tried to untangling iOS from using GenericUnixSalData, as it
        doesn't use any of it's features. The new, minimal SalData should
        be sufficient.
        
        I'm leaving the easier drop of mpInstance from the Windows and
        MacOSX backend as a minimal interesting EasyHack.
        
        Change-Id: I5be01c1f42131a7e31cb30899392308e1e2de53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128402
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [4bdf28b404f90236d93ce207671f755a71f28496]

        tdf#136481 show the focus rect for the case nothing is yet selected
        
        but the cursor is at pos 0
        
        Change-Id: I7c94480bffdced23fe89d4e3ba0e729742247130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128414
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [adc7fb85b9f525dfee8619c030ec57b2ba71ea37]

        ofz: fix build. error: missing member 'm_pPIManager'
        
        probably since...
        
        commit bc3f70f220091f09ad02c148a6a49fdccb7b85c5
        Date:   Thu Jan 13 20:15:39 2022 +0100
        
            VCL move PrinterInfoManager into GenericUnixSalData
        
            ... and use a std::unique_ptr.
        
        Change-Id: I07ffed4f722e30269ddf4828ffba3ac34952adb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128417
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [d59f1570cb9a49f3daf159b80744e5c93a74dc5a]

        respect TextRenderModeForResolutionIndependentLayout for mac too
        
        Change-Id: I1e572bd03387e1708fe75b90c2bce220b41c29e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128409
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Michael Stahl  <michael.stahl@allotropia.de>  [4c4fb36222f6c624cfdea82ce266bf9d99073558]

        Restore tdf#134951 docxexport: stop duplicating stuff in postponed text
        
        Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3
        to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported
        by jluth the test case testfdo79008 that failed was apparently somewhat
        misleading and the test case testTdf134951_duplicates that should test
        comments erroneously failed to fail because it is doing a loadAndSave()
        instead of a loadAndReload().
        
        Change-Id: I7e788287da3b1742f65697ec350997d175db9e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [168bd36582a1795a1b2a64a62afef742c3e017a6]

        tdf#146747 InternalItems has to be null terminated
        
        Change-Id: I15c0afdcae3e9bc1412e6564c15df2196515052e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128412
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [b1ec326619f7b91e56252b992159fd00bbff2ba7]

        tdf#146703 Rework previous fix to query extension metadata
        
        to limit its error potential by encoding only the category string
        
        Change-Id: Ia3d3bfa6981ec46b71b500980abda9ad7f606cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128361
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2022-01-14  Heiko Tietze  <tietze.heiko@gmail.com>  [90df5b09188c66c3a7752934650570246dfc321d]

        Resolve tdf#124572 - Draw a faint line between tabs
        
        Change-Id: I6cbbefe1cb16599ae81fc6dcb5a51ef1ca2db6f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128407
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-14  Julien Nabet  <serval2412@yahoo.fr>  [299441fbd995f5d80d253aba638e3dbc3ba875a2]

        Firebird: no need to override getTypes in Table
        
        Change-Id: I0af49eef735f5191f956f9ef9ae8e39c1eb7651a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128375
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [44cf7a7f3cd585b442b404ff9e791dc7df513a51]

        tdf#146605: sw: Add UItest
        
        Change-Id: I203387db47c3b936ec79bbe951f21bec6c7c26ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [bc3a0205e2100b845b504b63e591b7400833d632]

        Recheck modules d* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I916f42c46efa1b6cfd7744a189b79659b2867431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128196
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [ad27c35a11bd9a78f30bbe4da76cdde223cf8624]

        resave with latest glade
        
        Change-Id: I7d41fa2fbfd188c75b690be34f7c9baf6ae20044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Michael Stahl  <michael.stahl@allotropia.de>  [2a506a2e2b747e28e1684e0748fa3d237c65772b]

        ucb: webdav-curl: build debug callback also in release builds
        
        And fix the Authorization header redaction, it was assuming there is one
        call per header line, but all headers are passed in one call.
        
        Change-Id: Idf86b9e0a4a8f8e9fb39098402a002abc394a589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128395
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-14  Jean-Pierre Ledure  <jp@ledure.be>  [c8b5debd3f5536839e480ccadb1a1a0ba3a5ceda]

        Dispatch commands: reviewed wiki layout and content
        
        The wiki page
          https://wiki.documentfoundation.org/Development/DispatchCommands
        is generated by the execution of the python script:
          /bin/list-dispatch-commands.py
        
        Layout and content changes:
        - better commands list coverage
            Scan of .xcu, .sdi and .hxx files
            The list is the "union" of the found commands
          => Base and Charts commands are part of the list
        - new classification based in the 1st place on the .xcu files
          i.o. the .hxx (or "slots") names
          => Commands are listed only once
        - The sources providing the listed info are referenced for
          each command with a direct link to the opengrok sources
        - New information when available
            A subclassification: the group
            The potential arguments of the command
        
        Change-Id: I54dd8c219d0e7a00fd346faa7577e181a068bbaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128254
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2022-01-14  Caolán McNamara  <caolanm@redhat.com>  [9dbfda4cea569459e42203771754b902c1a09759]

        upgrade poppler to 22.01.0
        
        and popppler-data to 0.4.11
        
        Change-Id: Ibd8c28f36408a670b5853f1b266c6b8c36916a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8a5312b82ff1d3305baabbd2362ed0706ba8ace]

        reduce default cost of OInterfaceContainerHelper3
        
        most of these are never used, so rather store a pointer to a shared
        empty vector
        
        Change-Id: If5b8b82235171769420615147a0e0b316c237874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e162bb1e8521ad8cd8148e0a18adc3eebadd710]

        use cache value in ViewContact
        
        Rely on the cached primitives without always rebuilding.
        
        But only enable it for calc and draw right now, by adding a flag
        at the SdrModel level.
        
        Change-Id: I295e5a366b1b21d0f1561e6736bac919082afb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [8960dae3a24f5dd2712f1fe74de0c3b22552b12b]

        no need to hold OInterfaceContainerHelper4 by unique_ptr
        
        when empty, it is only a single pointer big anyway
        
        Change-Id: I3e45dd705c4bef3799435617db1a4192d62860e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Noel Grandin  <noelgrandin@gmail.com>  [b32e46fbc3b536c1f56fe5d3714772ad673542a3]

        improvements to ModifyEventForwarder
        
        (*) Firstly, the XWeak machinery in here was never useful. This
           class has always used hard references to its listeners. So
          just remove all that.
        (*) Convert from osl::Mutex to std::mutex and use the latest
            utility classes in comphelper with that.
        
        Change-Id: Id129527cf53da6d7a9f6e1c76b556c57fe1a0270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [bc3f70f220091f09ad02c148a6a49fdccb7b85c5]

        VCL move PrinterInfoManager into GenericUnixSalData
        
        ... and use a std::unique_ptr.
        
        PrinterInfoManager::release() was just called from ~SalData(),
        so this should make this more clear.
        
        Change-Id: Ic4aade2db3813fdc96ede116a50604692ef3dbec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128399
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [fa7389b430f242706b1bcea430f82fffa112fb9b]

        iOS+Android+SVP "merge" all SalData instances
        
        It's always the same code.
        
        Change-Id: I2385d0bda24939b964306e27a3df99ea44356eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128401
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-14  Miklos Vajna  <vmiklos@collabora.com>  [a4d770731f4e5228ef1101c286d1815cf94a1fd9]

        connectivity: can avoid copying here
        
        aTableNames is not changed till we hold a reference to that name.
        
        Change-Id: I8a06b5bead101cba4e3293f6c29a849e7a9d0f6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128396
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-14  Noel Grandin  <noelgrandin@gmail.com>  [bd1fbe307840eedadcb0266ed097a21765d3e579]

        use more concrete types in chart2
        
        in this case, ModifyEventForwarder.
        Instead of doing UNO_QUERY and implicitly relying on it's
        implementation, make it obvious what we are doing
        
        Change-Id: Ie02a11f115da9c8af7d4ca85bda9fb9a69c5d52f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [b0d0b80d8e5428393b7e5185582fed78ed1b2bbe]

        iOS+Android remove empty header
        
        Change-Id: Ib7cb14872f74ef5ab5adeb332fb791b7c98fc63f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128400
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [45dee329c30f5548b0ba57cc1457c73f2fc870a3]

        tdf#134960: sw: Add test for multi-page view
        
        Change-Id: Id3292de4eca6ab72d5116b967a619f78ab96082b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128391
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [ceb79e1db5c1b5cbaced683d39125da3bdeaf521]

        ofz#43613 oss-fuzz build failure
        
        Change-Id: I17ddc43c37d806f267f4ca57bb02227bd053d2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128397
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Jim Raykowski  <raykowj@gmail.com>  [63a9d8adedd5e9b2fcc689aae843c491f47261dd]

        SwNavigator: fix outline delete removes first character of next outline
        
        paragraph
        
        The to be deleted outline selection may already be to the start of the
        following outline paragraph as happens when a table is the last
        content of the to be deleted outline. In this case do not extend the
        selection right or the first character of the following outline
        paragraph will be removed. Also check if no selection was made which
        indicates an empty paragraph and the selection right is needed.
        
        Change-Id: I5b2516bd7b1e88ee415986dbe9313f93039dbac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128264
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [935761709fb7629c8d23aa5dc8bfcbd2988f5bbf]

        tdf#144862 adjust positioning experimental options
        
        drop GlyphPositioningMode::ClassicInspired as that just demos the
        tradeoffs of the original GlyphPositioningMode::Classic vs the chaos of
        GlyphPositioningMode::PreferReadability where hinting at small sizes
        pushes the text outside its layout bounds.
        
        add GlyphPositioningMode::LayoutAndMatchRender to demo the next
        option.
        
        so:
        GlyphPositioningMode::Classic This is as it ~always was, using the
        technique documented at https://wiki.openoffice.org/wiki/Writer/WYSIWYG
        
        GlyphPositioningMode::Layout This is just taking the high resolution
        layout positions, dropping the "Classic" technique and let vcl do its
        default scaling and rendering of the glyph positions as happens in
        editeng.
        
        GlyphPositioningMode::LayoutAndMatchRender same as Layout, but during
        text render preserve the scaled glyph positions as floating point
        positions and pass through to the various platform text renderers
        configured as best to handle that.
        
        Change-Id: Ic37bb8f3cf4472bdc3c48f02b1f9057a0f80cbd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128360
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [711cc3278ffc256a9d1782da1bc157498e82e1a6]

        upgrade to libjpeg-turbo-2.1.2
        
        Change-Id: I6d24be03c6401a815e6f19d79f418fcc90334393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [444477a07bcaf59181dbbc719b913566091deadc]

        ofz#43577 valid reclen must be >= 20
        
        Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [b589fc5a8d1124b81ac75dfac972c1036ae55477]

        set hint_metrics seperately from hint_style
        
        I unsure hint_metrics makes any difference to our use case, but probably
        won't hurt
        
        Change-Id: I82a4ff0d3a05e50ec30e878363e0c24a438c96cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a02faeade844050d1235588093c13024bb2cdeed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d958791300f4cf1eee8f26b46fe888cee3fae2e
          - Fix typos
            
            Change-Id: I951914bd28c7cd4f49e2704f3393e91fb18e6cd0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128385
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Michael Stahl  <michael.stahl@allotropia.de>  [f261fae4af72b1328bc3e93fc52a9a24ce0975b3]

        tdf#143039 tdf#143106 sw: DOCX export: don't export duplicate flys
        
        The problem is that at the end of the paragraph a second call to
        OutFlys() is made in line 2730 and that causes the duplication; for
        this call the value FLY_POSTPONED must be returned, not FLY_NONE.
        
        (regression from 3eced2d52415abeac266804ab682bee022322a19)
        
        Also revert commit deb892628a1501527c8c41b85a65282df95b81b1 because its
        test fails now as 0 comments are exported; it was apparently another
        problem introduced by the above commit, and apparently this fix helps
        for duplication of comments too.
        
        Change-Id: Ib9706e4c24db38c15a0170ba2e8f08fba5327f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128386
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [bb830461f0c22f7efe10de799a6a39b56cc5b4a5]

        keep scaled ResolutionIndependentLayout glyph positions as floating point
        
        When rendering in ResolutionIndependentLayout mode keep the scaled
        glyph positions as floating point all the way down to the renderer
        
        Change-Id: I02415f18c26737a886751972f472b499a25c776b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [99c51ce0e44bf03ddea0efd7612389faa636b658]

        allow selecting text rendering mode suitable for natural glyph positions
        
        Change-Id: I6b8c815fda3a48917467719432071c0716e3e9ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127338
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [5e218b5c51f7d9cd10bd9db832879efca41b9c75]

        always use B2DPoint for DevicePoint
        
        Change-Id: If75c3448776743f1b9efbf84a487cfc0c75364ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128365
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Miklos Vajna  <vmiklos@collabora.com>  [cf2690ae76b4250af32be7c8980b8d83b3611591]

        sw: fix swapped inner vs outer border for Word-style bottom table borders
        
        This is similar to commit fc04a84f297b78a1049182b6d8cf745f863ffe61 (sw:
        fix swapped inner vs outer border for Word-style left table borders,
        2022-01-11), but that was for vertical borders, this is for horizontal
        ones.
        
        The other difference is that Word mirrors vertical lines, but not
        horizontal ones. This means that our horizontal line need less
        mirroring, while our vertical lines needed more mirroring.
        
        Change-Id: Iff07adac5c53420673139d5c93ce52f6148fb977
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128383
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [c26b0bc9f324974480843efbb3aaf4851872747e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb1bf86ac137d050daaaed114a70c29002acc4fe
          - tdf#123318 Add navigation menu entry LibreOffice for Shared
            
            Change-Id: Ibd46738e03721127e07ee1575e0a925fc36fbe9d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128382
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [3f041e3153fee98aa708edcd9071ea58fdde052b]

        Related: tdf#145625 adapt the reportdesign color section margins
        
        to the changes of:
        
        commit 8d2bf9b679dec223a78e1fd8f3684f76c5802bae
        Date:   Wed Jan 12 13:32:13 2022 +0100
        
            Resolves tdf#145625 - Alignment issue at color options
        
        Change-Id: I66c43e964b19da3bdfd4f13cc343dc399ae9cd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [3840a567d40e8343bdb0f12e355b691acc11eb81]

        restore some placeholder labels
        
        glade tends to clobber the GtkMenuButtons placeholder labels
        
        Change-Id: I2f1e8dd3f9b86e09a9fe7ce311b40a84f298b4a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128377
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [6ba527ab55456eee154528247ec4c9256ea946c8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c10ab097835514a63c4b0876b0ea5254bed1228
          - partially resolves tdf#146733: corrections for template view
            
               - correction to listview icon
               - correction to location of listview and thumbnail icons
            
            Change-Id: I5133e88bf2e683bdc6388cacc40a341ee050e714
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128340
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-01-13  Seth Chaiklin  <sdc.blanco@youmail.dk>  [9b02edcf77f30527a1f6cd6da0c911f27ef8c249]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cf8ad59654e0f7edff6033d55bf10710f1255b4d
          - partially resolves tdf#146733: change "tools" to "manage
               - change mention of "Tools" icon to "Manage" widget
               - update menu items in Manage dropdown menu, and remove 
                    obselete items
               - remove tools icon
            
            Change-Id: I3c68b4686abb10f58cfc8158e95a3eaf51aa9816
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128339
            Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
            Tested-by: Jenkins
            
2022-01-13  Stephan Bergmann  <sbergman@redhat.com>  [9780be6c05ece20d292035f6aba50dab34a8b024]

        Make HWPStyle::style type-safe
        
        Change-Id: I3a8dcf497a236d12eedff9e7b5943e14747cb9bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128374
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [3d27b1148b7ac54c39632baef16e9695c5e92d85]

        split up ImplPrepareLayoutArgs a little
        
        no logic change intended
        
        Change-Id: Id24fb2647e2e6c00a485165edd7fc265ad090c23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [8b797df02a00349085121993dcf0ce8d5320b185]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c41ec4fa1f8b000c62c3df3f66e594818f63094
          - tdf#146117 Explain that Var/Str are locale-independent
            
            Change-Id: I0a90befe2c63e8f9719ec7179666c9342602d0e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127782
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2022-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [0583b3b6cd1eeb7f6d01da76b77d06dec4528fde]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d3d7401d26288e8bc7eb984dcd714590bc72e82
          - tdf#91230 Improve description of Conditional Formatting
            
            Change-Id: I536c959bec3ad94deb5e9893b956755d64f438f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128337
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb0083acc30210173e168431dd2aaec248aea35b]

        small optimisation
        
        Change-Id: I51fc0292a3907613391bc8a2a16bac486cdadee6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128366
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [6057d03c60c9f6a483a7b0caf2cb32cab0e83103]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3cb9f803eae6a60ae6bc8ca35ccd74126f14a871
          - tdf#70551 Improve description of the WEEKS add-in function
            
            Change-Id: Ic4e234496a05fb1e88de88f554a2b5ae90244651
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128331
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Stephan Bergmann  <sbergman@redhat.com>  [18220ad65bb989fdbfe73fa36ae03ef6466d7ee5]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/65437462b575881703146b132d2ae6c7e998c1b6>
        "Merge pull request #174 from vroger11/patch-1:  Add global-menu support for KDE
        and unity"
        
        Change-Id: Id9c9c9d63303fc7de12b47e12b1e32f6556f1f02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128368
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-13  Stephan Bergmann  <sbergman@redhat.com>  [4ee0ad0541a9767cbf527a268df321d554b00384]

        Fix build
        
        ...after 840b4eb2f3443ff883016e6a8a8ae49e9cbd9e4e "Recheck modules [a-c]* with
        IWYU" causing
        
        > In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCase.h:6,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:5,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h:9,
        >                  from cppu/qa/test_any.cxx:26:
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string<char> >::type = std::__cxx11::basic_string<char>]’:
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50:   required from ‘static std::string CppUnit::assertion_traits<T>::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58:   required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string<char>]’
        > cppu/qa/test_any.cxx:282:9:   required from here
        > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char16_t) [with _Traits = char_traits<char>]’
        >    25 |     ost << x;
        >       |     ~~~~^~~~
        > In file included from ~/gcc/trunk/inst/include/c++/12.0.0/istream:39,
        >                  from ~/gcc/trunk/inst/include/c++/12.0.0/sstream:38,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/portability/Stream.h:283,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:7,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCase.h:6,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:5,
        >                  from workdir/UnpackedTarball/cppunit/include/cppunit/extensions/HelperMacros.h:9,
        >                  from cppu/qa/test_any.cxx:26:
        > ~/gcc/trunk/inst/include/c++/12.0.0/ostream:558:5: note: declared here
        >   558 |     operator<<(basic_ostream<char, _Traits>&, char16_t) = delete;
        >       |     ^~~~~~~~
        
        etc.
        
        Change-Id: I2e6d3591dec9eeb6647738d37296c7d2bfa6a186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128369
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [687ec84b16f3031da8704c04c7f6c4a81f7c3f00]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0ab09791a5f69b886f51eea97cba0e120d63a21d
          - tdf#80658 Calc stream Hlp page (part)
            
            - Added contents to live data stream help page
            - Used some of Vipul Gupta contents from attachement in ticket
            - Still incomplete because the setup to work is non trivial
            
            Change-Id: I02bf8178859ddce7ce28082388d21e31853dac4e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128348
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [21cfbd6c1d6e4311301b5eeb84490e2474717ff0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to edc442479a8762dbb44c55741f28400efb528ec3
          - tdf#72461 Fix Help bookmark for CMIS setup dialog
            
            + Effective changes are in the <bookmark> at the top
            + Uncommon bookmark HID, svtools/ vs svt/
            + Refactor of the file
            
            Change-Id: I6f2c73fb3912d271e8b496bcdb6edfa0e4dc2eeb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128324
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [b04be559ddf4a7f0a5cdc0b9abc2bcfc4aae25cc]

        gbuild: implement static partial build
        
        This stores all the dependencies collected from the full build,
        and uses that info to link static binaries in per module.
        
        Change-Id: I27bd41c217bf0d2248ee88004038dd6b813f2624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128129
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-13  Luboš Luňák  <l.lunak@collabora.com>  [d6496fce2e51a3e44753e6b5c462824f182b48d5]

        split gbuild's <module>.all to <module>.allbuild or .allcheck
        
        This is similar to the removal of the 'all' target in the past.
        Using 'make vcl.all' is supposed to build the vcl module and all
        its dependencies, the problem is that it builds also tests, which
        means not only building and running the tests but also their
        dependencies too, so 'make vcl.all' may in fact also build Writer
        because a unittest depends on something there.
        
        So now <module>.allcheck is the new name for that, and newly
        there's also the (IMO actually useful) <module>.allbuild .
        
        Change-Id: I55baa014a657783e641cee67948ee8fb062b1982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128349
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-13  Caolán McNamara  <caolanm@redhat.com>  [f5f5b45001eb419ab45c823c17cafc53e6a4659e]

        fix up label mnemonics in writer view options page
        
        Change-Id: I8acf5421c7e986a15a759f7b4c203d3c844b77f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128357
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-13  Stephan Bergmann  <sbergman@redhat.com>  [b0ab07ba89c88006932c68e0ca08dffcd0a4621e]

        Always set MAC_OS_X_VERSION_MAX_ALLOWED = MAC_OS_X_VERSION_MIN_REQUIRED
        
        ...and drop the --with-macosx-version-max-allowed configure switch.
        
        Looking at the documentation in
        /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/AvailabilityMacros.h,
        a value of MAC_OS_X_VERSION_MAX_ALLOWED larger than
        MAC_OS_X_VERSION_MIN_REQUIRED would allow functions that only started to become
        available in that range to be resolved as null at runtime, so would need our
        code to be prepared to get null function pointers in such cases, but which our
        code is presumably not prepared for to begin with, anyway.
        
        Change-Id: I1423ee7435aa2b36eb91c62ff91b1fc414995a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128363
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2022-01-13  Gabor Kelemen  <kelemeng@ubuntu.com>  [840b4eb2f3443ff883016e6a8a8ae49e9cbd9e4e]

        Recheck modules [a-c]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I74a3c3a67c3639376e2251c3eb917fa4139dfbd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127808
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-13  Heiko Tietze  <tietze.heiko@gmail.com>  [8d2bf9b679dec223a78e1fd8f3684f76c5802bae]

        Resolves tdf#145625 - Alignment issue at color options
        
        * Label "On" cleared (kept internally for size calculation)
        * Deprecated xalign removed
        * margin-start set to 0, halign=start, valign=center for
          color labels and checkboxes
        * margin set to 12 at the right edge to have more space
          for the scrollbar
        
        Change-Id: I32b7c1fc4ad93b1e9fa7b78968eedbbc3580a379
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128322
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-13  Miklos Vajna  <vmiklos@collabora.com>  [b24ef22fee1196a89750b92463cb0b7a541e83c9]

        external: update pdfium to 4818
        
        Change-Id: I68751a7b6ca2c8c86a412a0fd401e0d0f172297b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128353
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-13  Stephan Bergmann  <sbergman@redhat.com>  [229c312834f8931994ed1147a0cc136ce4b2de69]

        Adapt comment
        
        ...to 76e04aef4b4adea8179d564b158e58f495ed43a4 "Rename LO-specific uno ini-file
        (Linux: program/unorc) to 'louno'".  (And yes, the original comment guessed
        right: it is the URE uno ini-file that we look for here.)
        
        Change-Id: I3006a5169ae066b984e415d17841f69db338b68b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128325
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [809d1e206fa9ac87ee9e04006285edfc3907667c]

        Simplify COMReference a bit
        
        Use ThrowIfFailed and small refactor
        
        Change-Id: I0bcd57c26cd169380364cdaaaa76e764b9662d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128362
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [38eaa0c825ec461a296f4ea5f7bdc90f3a6408e9]

        cache result of query for dataseries properties
        
        shaves some time off the perf profile of large charts
        
        Change-Id: Ic9feab719d784b2e58e96c8a1c642d363d3c5f27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128355
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfe32f3e50b5406810e740ac41368f101033e766]

        optimise ensureGeometry
        
        for complex polygons, return early
        
        Change-Id: Id4bb2311f84508d95a71a3f4353872164baabe6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0c68f982dfabd33b6049c3614734401f70bae50]

        split the BarChart rendering method down a little
        
        into slightly more manageable chunks
        
        Change-Id: I2a8c031618516102e2dccf071beef51fe9917f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128347
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-13  Mike Kaganski  <mike.kaganski@collabora.com>  [897d91c0d3a570492477bcffdc4b6b3b6213a7fa]

        Small refactor
        
        Change-Id: I18a3bcce4aa7cac3d01b3889aff24b3ec992809d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128358
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [62aee746b72cf4cf3eac324a428418d6ef380d1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 28d35d3226eeca83ec15a1fc648a7cdd19ff9a0f
          - Enable translation for strings
            
            Change-Id: I9092595635af48a92c1c3df35effb58a41924aac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128336
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4dc4c766f4451c0f5789e2a1e0290e3afb893185]

        Fix typos
        
        Change-Id: I38ca4904f28a67236b546ff267ab17ba4bfe42fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128352
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-12  Caolán McNamara  <caolanm@redhat.com>  [00391f14ab72f31ebc35078b34fbf3628b5cc7a1]

        ofz: Direct-leak
        
        Change-Id: Iedef8c99f0650750f5cfd808ac36421cc0d5c281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128316
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-12  dtm  <daniel@fearnley.net>  [582bf1a27c5adc6684e8d9af3805cfe40fa051d5]

        tdf#145538 - Use range based for loops
        
        Change-Id: Ib16c742b39af62694ef591dcdaa975b9a720b4a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127203
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2022-01-12  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cd7af555b75fbc90d9a9012c0b0b40ae2e11ac2f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 87e0eb58bfcb1cdfe04f26833376827a09c1e241
          - update translations for 7.3.0 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I372f976206656723929dfd06c958afd839805a2c
            
2022-01-12  Caolán McNamara  <caolanm@redhat.com>  [6c9e722fa989ce9530569be2342c67ffd141c466]

        ofz#43551 Use-of-uninitialized-value
        
        Change-Id: I2eb139f3bff296cff7d8f0e9a05f19df56b27ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd7f4f02a547d0437b65adf6966fb7a9520b9dd0]

        Fix typos
        
        Change-Id: I47fc636e0b69b72fb6ca247f9e0cbabbddb3985e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128321
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1240ceacfcf04cb909d00118f927e079c210a32e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 38eda1bc74077cba48617976f48765d10da43c34
          - Fix typo in a color name
            
            Change-Id: I66c777c3b9a6ae88422d71aab781ab20879d72fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128320
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [2d11710df6d81c03007d136667a443e09cc70eed]

        tdf#146454 - Check for multiline string in setDataArray
        
        Check for a multiline string in the setDataArray function. If that is
        the case, set a string or edit cell. Otherwise, just set a plain string in order to prevent performance issues due to the adjustments of the row height.
        
        Regression from b9e2c5d2a36fbd189c20448cadf4212edf02914d
        
        Change-Id: I9216b198b878fda5da29596d25504db853acd756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127660
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-12  Luboš Luňák  <l.lunak@collabora.com>  [c78b4cdb4fc922f3b35172b71fee772385526d98]

        use std::optional::operator* rather than value()
        
        Apparently the latter doesn't work on some MacOS versions
        despite it being C++17 too (see comments
        at https://gerrit.libreoffice.org/c/core/+/128308)
        
        Change-Id: I5adb95720cabecd1837d17ed1543ff656734410d

2022-01-12  Luboš Luňák  <l.lunak@collabora.com>  [6fd4209a7e5884e44f4214342c7565229aa9b7d5]

        block amd drivers that crash with Skia's kDifference (tdf#146402)
        
        This is a follow-up to 4a11c85baeb4998e12bc2ab45b0c23, after all
        it was a driver problem. But the time 7.4 is out the newer one
        working will be hopefully in sufficient use.
        
        Change-Id: I682a56ec6e5b6dfe4c85930346177fc5c13569c9

2022-01-12  Caolán McNamara  <caolanm@redhat.com>  [be30c734bf420f9dd890906c84d2b4460385a2ba]

        keep positions as DeviceCoordinate within SalLayout
        
        Change-Id: I20bbb0e252ffd09901f587599430e715dbe977b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128300
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a850dd9f3c221660b6259bdfd64a77343f2256c]

        used cache value in ViewObjectContact::getPrimitive2DSequence (2nd attempt)
        
        Rely on the cached primitives in VOC.
        
        But only enable it for calc and draw right now, by adding a flag
        at the SdrModel level.
        
        This way we can leave it disabled for writer, where it definitely doesn't
        work.
        
        Change-Id: I11ca4836eb773c0f078cdb82056c6e0309d15a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128319
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-12  László Németh  <nemeth@numbertext.org>  [eebe4747d2d13545004937bb0267ccfc8ab9d63f]

        tdf#144270 sw: manage tracked table (row) deletion/insertion
        
        in Manage Changes dialog window, where deleted/inserted
        tables and table rows were shown as multiple cell changes,
        as a regression. Now a single table deletion/insertion or
        deleted/inserted consecutive table rows are shown with a
        single tree item in the dialog window instead of showing
        multiple cell changes.
        
        Add new Action icons to the tracked table row
        insertion/deletion tree items (re-using table row
        deletion/insertion icons).
        
        Show cell changes as children of the single parent
        item tracked table row change.
        
        Accept/Reject and Accept/Reject All support
        1-click acceptance or rejection of table (row) changes,
        instead of clicking on all cell changes of a single
        table (row) deletion/insertion.
        
        Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be
        "sw: fix crash due to redlines on tables on ooo121112-2.docx".
        
        Change-Id: Id03a8075cc6849b70a8d32e1a955b79e7d3a3246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128314
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-12  Tor Lillqvist  <tml@collabora.com>  [439df74885ba9c24db3a1d417744acf4b3b6c48f]

        We do want scripting on iOS, too
        
        The native-code.py script unconditionally generates references to that now.
        
        Change-Id: Ib0ca1e994af15597f8a191ccdd32d95efca063da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115796
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118897
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128317
        Tested-by: Tor Lillqvist <tml@collabora.com>

2022-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f510ea2d7962a4325055c6380a0032331b4e87cf]

        don't bother trying to draw stuff which is effectively invisible
        
        speeds up rendering of complex drawings with fine lines
        
        Change-Id: I62924c5ddb6293f993eef9ca200a43cba753d53e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1bc9d8510299aa9c31589ecb31457b98e644e58]

        remove unused code
        
        Change-Id: Ieb5100dab1ed8af23e765926a8a1f33d75132406
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-12  Heiko Tietze  <tietze.heiko@gmail.com>  [2d627b37643ba7308fec6ec5acb9e89cdaa6dfa3]

        Bump Glade version to 3.38
        
        Change-Id: Icddb8f9ee67d929a4fcacde72263439976ff2f4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128315
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-12  Luboš Luňák  <l.lunak@collabora.com>  [9cb34aa3c98ac6254b7e70e26e92f3e2ba881fab]

        reduce explicit Skia flushing
        
        The docs say that Skia handles this itself, and with Vulkan excessive
        flushing may show up in profiling in some cases, as it's apparently
        a non-trivial operation in GPU mode. Remove even the two workarounds,
        I cannot reproduce the problems anymore, so let's assume it's been
        fixed in Skia.
        But still keep the flushing after a certain number of operations,
        as too many pending operations still may overload Skia (or Vulkan?),
        besides tdf#136369 I can also reproduce it while loading bsc#1183308
        which does a large number of tiny VirtualDevice's and does GetBitmap()
        on them.
        Also change the counter to be global, as we use just one Skia drawing
        context.
        
        Change-Id: I48b96c2a59f8e1eeef3da154dbe373a37857c4be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128293
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-12  Luboš Luňák  <l.lunak@collabora.com>  [d39acd432df374ffdf4142c23d1c74df8821160c]

        do not force pixel reading in VclCanvasBitmap ctor
        
        BitmapReadAccess is not need by most calls in the class, and
        creating it already in ctor forces reading of all pixels,
        which is expensive e.g. when fetching them from the GPU.
        
        Change-Id: Ie5da67d1c41ad798928646077b5b4c33147d0ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128308
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-12  Caolán McNamara  <caolanm@redhat.com>  [b89a26457eef67c23f5bcc1495b564fc7a86654f]

        cid#1497092 Result is not floating-point
        
        Change-Id: I3ee4a3fa13db8958970206059dbd99d841d3c706
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-12  Jan-Marek Glogowski  <glogow@fbihome.de>  [dc9ccf3d8f294cd7ae9d5bece7b6c16c3b22f6a5]

        gbuild: build static LO / link static executables
        
        This allows to build a complete static LibreOffice on Linux,
        except for linked externals. Since LO's static build implies
        disabled dynamic loading, one must select one VCL backend to
        be compiled in.
        
        See the (large) comment in solenv/gbuild/static.mk trying to
        explain, why this implementation was chosen (spoiler: seems
        there is no other way) and what is actually implemented.
        
        This will collect all libraries, statics and externals of
        executables. If the executable uses components, it will get
        linked to all static components. While it works with any
        Executable, it just makes sense for soffice.bin, because the
        static component map sucks every dependency in, bloating most
        other binaries.
        
        In theory on could generate the dependencies based on the list
        of used components (see gb_CppunitTest_use_components), then
        generate a specific static constructor map, directly include it
        in the exe's cxx code and then link the minimal dependencies.
        
        The static LO should build on Linux with:
        --enable-customtarget-components
        --disable-dynamic-loading
        
        Tested VCL plugin config is:
        --disable-gtk3
        --disable-gen
        --enable-qt5
        
        The partial build support is split into a 2nd patch.
        
        Change-Id: Iafc95752fae9e88095f54a21f1e30a4f080815e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126790
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [aaec6db548ef2fe4d1d1869491eea15571457f57]

        CppunitTest_svx_unit: simplify code (part 2)
        
        Change-Id: Ic98a25f495630517827c1e9f9827e1c45e1401ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128304
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-12  Caolán McNamara  <caolanm@redhat.com>  [3c1ab4940914ba07c8cb61d13e03a319f73fce7c]

        make it easier to adjust the value of a basegfx Tuple2D
        
        Change-Id: I849e945db651c5064b4ca0c1d15e9fa0066eeea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-12  Stephan Bergmann  <sbergman@redhat.com>  [3b48e20b0101584a5e7ef48ba82238e735f0772b]

        -Werror,-Wunused-parameter
        
        ...since fcf4a26275d7503835f9aa23cb94938809840300 "tdf#146306 wina11y: Retrieve
        accessible desc on demand"
        
        Change-Id: I8acdca5fac481ca7b970fb9c3660470c5febdf99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128307
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-12  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [3e94991d7fd3a085549c3a5d4c991688042d2cb9]

        Bump minimum macOS to 10.13
        
        Change-Id: If495606bb1b0c82abba8fa93277cf3d445e0136a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128291
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [12e03ccd0cc45394cff479a6190e97a6d599d2c8]

        Remove break; after return
        
        Change-Id: Ieafdbe14a3e51bc5d804e3cfe3c6f5757bef3ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128216
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-12  Miklos Vajna  <vmiklos@collabora.com>  [ac025a464086c73c564024f484fd181c97138bd9]

        CppunitTest_sw_odfexport: rework to avoid preTest()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ie7187c7a843a191475688a4a6390514199c6a1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128298
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dc35df15c5d125ff0caf82e9e7c99695d7cd7dfc]

        Fix typos
        
        Change-Id: Ib132f2582fce1fb62755926d3f55987ea474ec74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128297
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ab6369c626a249b9ce9e92c04a4f59f91bed2dd6]

        Removed duplicated includes
        
        Change-Id: I3329e75577b92348f830524a4ea116d073efabc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128296
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [964191e2daa1594e7087784d2a6883fe5a7f19d2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to abe9969968c47e5ff4b85468fa8ef32377b4e086
          - Fix typo
            
            Thanks a lot to Valter Mura:
            https://listarchives.libreoffice.org/global/l10n/2022/msg00005.html
            
            Change-Id: I3416cd3e0da0426aa4ea074e8b9c8268dfd2b627
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128302
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2022-01-12  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f2e1c6033890e513aa8e6b15dd6f26905d4622c8]

        sc: fix cond. format icon size, when we work with pixels
        
        This is the case when the device is bWorksInPixels is true, which
        is the case when running LOKit.
        
        Change-Id: Ibfced11bf614604521240908f4821fb9abfbf362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128200
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-12  Gabor Kelemen  <kelemeng@ubuntu.com>  [b957454e5ed46029ea0ca06a7d345d9608bfa4a1]

        tdf#142564 Localize extension category names
        
        Change-Id: I57ca7cb194bd325f621841edc24e3af9ef7c3b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128305
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-12  Gabor Kelemen  <kelemeng@ubuntu.com>  [348e0651cc5add15ac03b11dde08057cf33f9b16]

        tdf#146703 Fix URL encoding when querying extensions
        
        so that extension information files are properly downloaded such as:
        https://extensions.libreoffice.org/api/v0/Color Palette.json
        
        Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [4032284bf9629e9cfbbbb4597d0b10394f9e61be]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d29732c1b544fa75cb12a30c8feff3109dddc1f8
          - tdf#138418 Document color command in Math
            
            Change-Id: I0220cfbb50af4167155578f778c7845476db9120
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128240
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-11  Julien Nabet  <serval2412@yahoo.fr>  [bb29b12a9e367d181a5d9d962d466df41e093e0c]

        Mysql/MariaDB: add column(s) + table(s) (almost) skeleton part
        
        Change-Id: I9447d7220faeb7a8147e649f0cca57ae15d3e9aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128301
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-11  Caolán McNamara  <caolanm@redhat.com>  [6fda1c3e0484cd45c48f92b7801a267b091518bd]

        cid#1497094 silence Uninitialized scalar field
        
        and
        
        cid#1497093 Uninitialized scalar field
        
        Change-Id: Ie6a7f5032a6a3eda8480c1f3a3a0d0f2e831a53a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-11  Julien Nabet  <serval2412@yahoo.fr>  [8dd86eb5602bed539da5ffb584e09847dbde4d60]

        Mysql/MariaDB: add catalog+indexes+keys+user(s) skeleton part
        
        + sort objects in Library_mysqlc.mk
        
        Change-Id: Ide8ea46424b034c109670ee5514b0afebfa376aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128176
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-11  Caolán McNamara  <caolanm@redhat.com>  [f523c854a50358fe3434d8e65bd47f76ccc77b90]

        make VCL_FLOAT_DEVICE_PIXEL compile
        
        Change-Id: I0673b77a24085a8f06471d67c4cfdec43047c226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128290
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [18bc9ea75daf4eb3520a4d0ef6649d92261012a6]

        replace XTransformation with more efficient class
        
        this UNO interface is not being used an a real UNO API, so replace it
        with something that doesn't pass around 3 doubles in a Sequence
        
        Change-Id: I39d8ae03a3e861daba87f46686c0f93815bb1805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Stanislav Horacek  <stanislav.horacek@gmail.com>  [610c089cf545ae3346262cc1e78fd21a9e1f8efb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e0e8633018698b124deb530169ddc73f00cc1b6
          - corrections to ScriptForge Dictionary page
            
            * Item returns Empty if key does not exist, no error is raised
            * replaced LibreOffice by %PRODUCTNAME
            * use the same capitalization of PropertyValue as in other places
            
            Change-Id: I45f9cfa873e0931a9bdf35d54a63b7591721e221
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128190
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-01-11  Miklos Vajna  <vmiklos@collabora.com>  [fc04a84f297b78a1049182b6d8cf745f863ffe61]

        sw: fix swapped inner vs outer border for Word-style left table borders
        
        The minimal DOCX bugdoc has a single cell, the left border style is
        thinThickMediumGap, the right border style is thickThinMediumGap, which
        means the doc model already has the left/right mirroring, don't have to
        do it at layout time.
        
        The normal Writer way is to have a single border style and mirror the
        right/bottom border line.
        
        But then looking at the Writer vs Word output, inner vs outer is
        swapped, so at the end we have to mirror the left border line for
        Word-style table borders to get compatible output.
        
        Change-Id: I10fb95dfac67e466188cfc9ecf35efde806c14b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128289
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-11  Caolán McNamara  <caolanm@redhat.com>  [68818db0ec0e9c308c8a0772d46af551f439b32c]

        build a IDWriteFontCollection1 of our FR_PRIVATE fonts
        
        so we don't need to fallback to gdi in skia for those
        
        we build it incrementally as GetFontFromFontFace fails
        in the system font set
        
        Change-Id: I2ac6d151657b9b720eed46dd7bcee0e9682e462a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f242cc6d5be5c6f5446976fd6a7c26ad0cee7683]

        use vectors to build up point data, instead of Sequence
        
        which shaves 1% off the load time of a large chart
        
        Change-Id: Ieb8f029f760f41c3bef63bbc4cd221c1473f0f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Luboš Luňák  <l.lunak@collabora.com>  [4c3384dd6c4a92404d170f9011c569de045dfbf7]

        do not call broadcast SetStyleSheet from a non-broadcast one
        
        In the document from bsc#1183308, which contains a large number
        of custom shapes, I get a noticeable time spent in the callchain
        EnhancedCustomShapeEngine::render() -> SdrObject::NbcSetStyleSheet()
        -> sdr::properties::GroupProperties::SetStyleSheet() ->
        SdrObject::SetStyleSheet(), which means that a non-broadcast call
        ends up in a broadcast one, and the time is spent in
        SvxShape::Notify(). And it even seems that nobody actually cares
        about the broadcasts, possibly because the SfxStyleSheet* value
        is actually the same.
        
        I originally tried to make SdrObject::SetStyleSheet() return
        if the SfxStyleSheet* is the same, but that fails the test from
        717dc8e3575a18e1e. I don't quite understand the reasoning for that,
        but solve it then by changing the code to call the Nbc variant
        if that's enough.
        
        Change-Id: I096a6799a0dc51c31ec3b0ba070c7f99ec96ac5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128048
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b7a32ac6e39d2c5991ee2fbdcf7d40556747578]

        skip unnecessary in DateScaling::doScaling
        
        when the timeunit is DAY, we don't need to do the AddDays thing
        
        Change-Id: Ie06c50dbb8b315e604f19e341bcdd88c75481a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a67b622ce51b4a8d0d36a62e4749f4ed0f17cfd2]

        OReadStatusBarDocumentHandler doesnt need SolarMutex
        
        it is only ever used from a single thread. This was there
        since the beginning.
        
        Change-Id: Ib001db94c7a5b2520d9a6435e21c27dca60d1dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Stanislav Horacek  <stanislav.horacek@gmail.com>  [a895ccb1032aa610055284bd3122cce623036464]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2a6cfde785b43b77c2accfa133e6aeac3fc22cf1
          - mark source code line as not localizable
            
            Change-Id: Ia8481b52854f72a2af0b68eb7f644d77038b8d05
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128145
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [72493fe922ffe91c6587f660f82f99a229e4d6fd]

        OWriteToolBoxDocumentHandler doesnt need SolarMutex
        
        it is only ever used from a single thread. This was there
        since the beginning.
        
        Change-Id: I580cf86457b2983cd7729bce32cbc0ccca601005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [934d246e77659ec91321f57e9a244dc39e917150]

        OWriteImagesDocumentHandler doesnt need SolarMutex
        
        it is only ever used from a single thread. This was there
        since the beginning.
        
        Change-Id: If6c2929677ea1231cbf3326974451c3c6d51486f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128269
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [c155710de15a400efa4b1bf33eabb549c2dafa25]

        OReadImagesDocumentHandler doesn't need SolarMutex
        
        it is only ever used from a single thread. This was there
        since the beginning.
        
        Change-Id: I7a2629071a3b2f3d4ddb6c7758a24515cfd5cebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128268
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [91c6279dd60b07788c8015fb04ecd2d310de1623]

        CppunitTest_svx_unit: simplify code
        
        Just use CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE
        or CPPUNIT_ASSERT_EQUAL_MESSAGE
        
        Change-Id: Ibf399cc802e31c5265ba1301f38df79958bf9e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128262
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-11  Caolán McNamara  <caolanm@redhat.com>  [11eecc7dadbee933a1f1e77adb1e4724015d2310]

        ofz#43509 use std::vector and at()
        
        Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-11  Stephan Bergmann  <sbergman@redhat.com>  [20a9b1ba01636b2b35b6cc2bc5c1c807055c5e8d]

        Adapt test value intervals to my Linux --without-system-fontconfig build
        
        Change-Id: Ie0867782b0925800cc094f43f8387fb9d1ff0c21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128272
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-11  Miklos Vajna  <vmiklos@collabora.com>  [efc287877328d3193c23d3a1065b6f015d7d12ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb8d368b0df51add887d63e7ec866ac06d5102e3
          - Add initial help for the cui themetabpage
            
            The OOXML spec does not say much about the purpose for the 12 colors,
            but include some guesses based on what typical themes do.
            
            Change-Id: I00d2b1e64e53c1eb3efe750fc1ebecbd6ff37e2f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128277
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-01-11  Stephan Bergmann  <sbergman@redhat.com>  [c1d1588ab6665403b9b35e3e85d915b9cfccffe8]

        Make external/fontconfig use -fPIC
        
        ...to prevent Library_skia from failing to link with
        
        > /usr/bin/ld.gold: error: workdir/UnpackedTarball/fontconfig/src/.libs/libfontconfig.a(fccfg.o): requires dynamic R_X86_64_32 reloc which may overflow at runtime; recompile with -fPIC
        
        etc. in a --without-system-fontconfig build
        
        Change-Id: Idd09785096d1a8be3f3086d6e565f307fa046a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128267
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-11  Michael Stahl  <michael.stahl@allotropia.de>  [cb188ce336e434c2b7002b3d8a41a681e73ae51a]

        tdf#146605 sw: try to fix SwSectionFormat notifications
        
        SwSectionFormat no longer notifies via its SwModify to SwClient
        listeners, but only via SvtBroadcaster, so SwSection and SwSectionFrame
        need to be SvtListeners.
        
        This can be seen when changing the footnote-at-end setting in the
        section dialog, if the SwSection doesn't get the event the footnote
        numbers aren't adapted to a new restart value, if the SwSectionFrame
        doesn't get the event the footnote container isn't moved.
        
        This is of course not pretty but hopefully it will be refactored further
        in the future.
        
        (regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a)
        
        Change-Id: I93c616e209a01fc5d4c8eba701a6ddce5d5b432e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128257
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-11  Gabor Kelemen  <kelemeng@ubuntu.com>  [cf3840931454553ff25e488dc1ede2af65e0016b]

        tdf#145919 Localize strings in Graphics Test dialog
        
        but not in the saved log file
        
        Change-Id: I65c580e7b8762b654f1812c96bc53841b882a960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128087
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-11  Miklos Vajna  <vmiklos@collabora.com>  [98538ea2155274b4cdb66a5d4e46d221aec564d3]

        sw: document SwPagePreviewWin
        
        SwPagePreviewWin is just a widget, owned by SwPagePreview, which is a
        view shell (more or less an opened window).
        
        Change-Id: I8f93ef354412273f85e9d4a5b375a3e2b7412221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128261
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [a8bbd66011da4d9996f28a6ed06db10ed026312b]

        icu: always use USE_SINGLE_CCODE_FILE pkgdata mode
        
        The pkgdata tool basically not only generates the data, but
        forces a non-parallel build for all data files for platforms,
        which can't use the (single file) assembler mode. This hits
        the WASM build, bringing down the parallel build to a crawl.
        
        But there is already the "hidden" optimization implemented in
        pkgdata to just write a single C source file, instead of one
        per locale. For some reason, that is just enabled on OS400.
        
        I don't think we have a platform, which would have a memory
        restriction doing this, so just uncondition this pkgdata
        build mode for everyone.
        Feel free to otherwise condition this patch for your platform
        in external/icu/UnpackedTarball_icu.mk.
        
        Change-Id: I482d80e853128d00faa43687e38f5b88fbf6958c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128266
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8de8abc5d26bfd0b3d7006d33a2231001ed77161]

        preload configmgr data for COOL
        
        touch all the config data we need during LOK pre-init.
        This means that most of the keys we need should become cached by
        ConfigurationWrapper in comphelper.
        Which means that the child processes we fork should be able to use the
        shared pages and not allocate their own.
        
        Change-Id: Iea8b1c4beaba67b6310b20cc161061ccf9a0db89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128247
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Gabor Kelemen  <kelemeng@ubuntu.com>  [4af29b3e75dc7bf50309be726d02ed82cf962813]

        Drop unused file dbaccess/source/shared/registrationhelper.cxx
        
        since commit d29a314300d523d29ed894f1822227497fcb68f8
        
        Change-Id: I16c76e0cc56fe06d92fe37e38a5a4549fa205f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Noel Grandin  <noelgrandin@gmail.com>  [5c00fadcc94bdfaefb9bee81a9bc610838fb9615]

        optimise and simplify ZipOutputEntryInThread
        
        by just using the tempfile service as intended, we can stay
        on the "happy path" which means that, on Windows, if there is
        sufficient system RAM, the temporary file never even hits
        the disk.
        
        Change-Id: I3b27cf09bd40a4cfee01c23273af05860708a16f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Noel Grandin  <noelgrandin@gmail.com>  [dd42f133f604ee2f7e0ffbca6a8d94fb8f95dfe5]

        tdf#146375 Cannot rename user-defined categories in template manager
        
        Regression from
          commit 3624a703361b108d22448bd60a97733f05e37820
          tdf#135316 remove OTempFileService pessimisation
        
        So fix two things here
        
        (1) make it so the tempfile service flushes the SvStream buffer
            and resets the file position, so we can read the data
            after writing it.
        (2) Simplify the UCB usage to just write the contents of the tempfile
            via the tempfile InputStream, which is simpler and safer
        
        Change-Id: I15ed3b02c2d6415d10a9579f66374e6268188d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128195
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [46b6ddc000a12795af361062bce471fa6e997d9a]

        Fix ISO C++11 -Wwritable-strings
        
        osl/unx/nlsupport.cxx:863:18: warning: ISO C++11 does not allow \
          conversion from string literal to 'char *' [-Wwritable-strings]
        
        Change-Id: I45da986ad8992716df9d1f9a0cc443fdb9cd46ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128213
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1f2daefbe921d223079a50358527e1d35470850]

        Fix typo
        
        Change-Id: I04ded03b3dd16627959a6451696a2e3392c17f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128215
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [2925063f0bb85c7e4d1d9a956365fe87a91dab22]

        uitest: executeCommand doesn't return anything
        
        Change-Id: Ie59ed6926c42b96471f3b74a9547f7f1f2cd175a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128259
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-10  Michael Stahl  <michael.stahl@allotropia.de>  [840cc7883849a10eea11a02a743848238723a3de]

        sw: stop inheriting SwSectionData::m_bProtectFlag from parent section
        
        This is actually no longer inherited by accident since commit
        2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a because it replaced the
        SwSectionFormat::Modify()->ModifyBroadcast()->CallSwClientNotify()->CallSwClientNotify()
        with a call to GetNotifier()->Broadcast(), and apparently SwSection
        is a SwClient of SwSectionFormat but not a SvtListener.
        
        But some consider the new behaviour useful, as previously there was no
        way to un-protect a section inside an outer protected section at all,
        while in this way every section can have its own independent protection
        flag. (The m_bEditInReadonlyFlag is not used for this purpose, as it is
        only for the case when the document was loaded ReadOnly.)
        
        So make it more explicit by removing the SwSection inheritance code.
        
        A similar change was made for hidden flag in commit
        91b0024965908c692bea40f47c58ea9d1bf8a596
        
        Change-Id: I29d3c84309a84267573950775f2a1c6353623724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128221
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [17950f4d204e9947f125ebc0aac1156eba6501f2]

        use less SvStream::Flush()
        
        Flush() turns into a sync() on the device, which is pretty slow.
        Most of the time all we actually want to do is to flush the internal
        buffers from the SvStream.
        
        So expose the FlushBuffer method and use that where possible.
        
        And also means we don't need the mbDontFlushOnClose flag on SvStream
        any more.
        
        Change-Id: Ibe089b88b325f0fdc565200a97ce72cd26b7fcfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-10  Miklos Vajna  <vmiklos@collabora.com>  [952b3b227e02ae4eedce3138fcb39613bf12486d]

        sd theme: fix applying new colors after theme change for group shapes
        
        UpdateSdrObject() is called for both group and non-group shapes, so
        don't assume that they always have text, otherwise we would crash.
        
        Change-Id: I3672673176f0cb462a8b8d61a68466f541e9ce06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128248
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-10  Miklos Vajna  <vmiklos@collabora.com>  [56ded398c9c72810f20b9da0aa98097739423180]

        editeng: avoid writing past the end of of pLine->GetCharPosArray()
        
        	Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
        	0x00007ffff6df4951 in ?? () from /usr/lib64/libstdc++.so.6
        	(gdb) bt 10
        	#0  0x00007ffff6df4951 in  () at /usr/lib64/libstdc++.so.6
        	#1  0x00007ffff6df5792 in __gnu_debug::_Error_formatter::_M_error() const () at /usr/lib64/libstdc++.so.6
        	#2  0x00007ffff47384bf in std::__debug::vector<int, std::allocator<int> >::operator[](unsigned long) (this=0x6b3dca0, __n=7) at /usr/include/c++/7/debug/vector:417
        	#3  0x00007ffff47b5440 in ImpEditEngine::ImpBreakLine(ParaPortion*, EditLine*, TextPortion const*, int, long, bool) (this=
        	    0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093, bCanHyphenate=false)
        	    at editeng/source/editeng/impedit3.cxx:2041
        	#4  0x00007ffff47b1fb6 in ImpEditEngine::CreateLines(int, unsigned int) (this=0x1ce0040, nPara=0, nStartPosY=0)
        	    at editeng/source/editeng/impedit3.cxx:1352
        	#5  0x00007ffff47ad0c2 in ImpEditEngine::FormatDoc() (this=0x1ce0040) at editeng/source/editeng/impedit3.cxx:387
        	#6  0x00007ffff47bf516 in ImpEditEngine::FormatAndLayout(EditView*, bool) (this=0x1ce0040, pCurView=0x0, bCalledFromUndo=false)
        	    at editeng/source/editeng/impedit3.cxx:4190
        	#7  0x00007ffff47be333 in ImpEditEngine::SetUpdateLayout(bool, EditView*, bool) (this=0x1ce0040, bUp=true, pCurView=0x0, bForceUpdate=false)
        	    at editeng/source/editeng/impedit3.cxx:3927
        	#8  0x00007ffff46f059e in EditEngine::SetUpdateLayout(bool, bool) (this=0x1ce2b20, bUpdate=true, bRestoring=false)
        	    at editeng/source/editeng/editeng.cxx:1472
        	#9  0x00007ffff48ce5e3 in Outliner::SetText(OutlinerParaObject const&) (this=0x1ce0cc0, rPObj=...) at editeng/source/outliner/outliner.cxx:586
        	(More stack frames follow...)
        	(gdb) frame 3
        	#3  0x00007ffff47b5440 in ImpEditEngine::ImpBreakLine (this=0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093,
        	    bCanHyphenate=false) at editeng/source/editeng/impedit3.cxx:2041
        	2041            pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width();
        	(gdb) print pLine->GetCharPosArray()
        	[Thread 0x7fffd2010700 (LWP 5008) exited]
        	$1 = std::__debug::vector of length 7, capacity 7 = {707, 1414, 2121, 2828, 3535, 4242, 4949}
        	(gdb) print nPosInArray
        	$2 = 7
        
        Change-Id: I3a8121c0c0a3b0949e91eb53c0468f7e629b146f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128223
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [1bb08a227ca4854a7d1960ca61a5b0de9fe9363d]

        Use one define for the common NLS archs
        
        Just some refactoring.
        
        Change-Id: I9edae9bce381dcd9fdcb98471d461d00220fea57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128218
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-10  Miklos Vajna  <vmiklos@collabora.com>  [3914ca68e05d31eec4df03db50a4c0c258d2704b]

        sw: prefix members of ConstRectangle, SwBaseShell, ...
        
        ... SwJumpToSpecificBox_Impl and SwZoomBox_Impl
        
        See tdf#94879 for motivation.
        
        Change-Id: I5daf3f0a2c0c712a554aa32a6a219acb07d64a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128201
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b15010fdfafeae9a6b22998852f0dafd8bf0d3ce]

        sc: fix typo
        
        Change-Id: If9a8f7265c17dafa99b51fe6266d935afedfa394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128207
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1126212885ee2d1ba0fd5e48bdb5f6e9d99e0302]

        cui: no need to fetch the property from the map twice
        
        Change-Id: I7597c352b2ae166657f1e431e3405fc690520afa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128206
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e17f003b5feb8da26498f317914eb2eb83be834b]

        document GenericCheckDialog, GraphicSizeCheck and related classes
        
        Change-Id: If3f8c33601f7823c87b75d601e0b8620d4bfe197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128205
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [13a524392d6788727b27ad11aef20973ef3042f8]

        Update git submodules
        
        * Update translations from branch 'master'
          to f6628660c35c8b21a632418e1363784b906f6ff9
          - update translations for 7.3.0 rc2/master
            
            and force-fix errors using pocheck
            
            Change-Id: I7ba555073adb5a8ddfcb37be8dd61c7df6ad5b40
            
2022-01-10  Hossein  <hossein@libreoffice.org>  [98eea4c8c73a05114ec831a18ef8b3eed9a574da]

        tdf#146084 Test for languages without hyphenation
        
        Add test for languages without hyphenation. The fix can be tested with:
        
        make CPPUNIT_TEST_NAME="testLanguagesWithoutHyphenation" -sr \
        			CppunitTest_i18nlangtag_test_languagetag
        
        It is important to know that Kurdish language consists of different
        dialects with differences in hyphenation:
        
        1. Central Kurdish (Sorani): Arabic script, no hyphenation
        2. Northern Kurdish (Kurmanji): Latin script, uses hyphenation
        3. Southern Kurdish (Xwarîn): Arabic script, no hyphenation
        
        Change-Id: I541281af6de296e57a5ab2dc8254f511787ebda0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128188
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [059c1aba91962262b971267819b52e6f822bd9a0]

        small cleanups to TempFile related code
        
        unnecessary temporary variables
        
        Change-Id: Iefa6c9a6627311495e6cd2f01f5446082ae0589d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-10  Caolán McNamara  <caolanm@redhat.com>  [b4c56c0fd917623bbc0982eb53276e6ca64e7f42]

        ofz: Use-of-unintialized-value
        
        Change-Id: I6c9a1a22240defbc8d9fa262ad087770445ffc4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128210
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-10  Mike Kaganski  <mike.kaganski@collabora.com>  [fd9a47981bf8c139a6c6ca962f3b520387019ef3]

        Revert "Use clear() instead of remove_if"
        
        This reverts commit 8accfa30343195b5d7cfd111301677a6a9b6a21b.
        
        Reason for revert: causes asan failure:
        
        =================================================================
        ==18688==ERROR: AddressSanitizer: heap-use-after-free on address 0x60e00041a3d0 at pc 0x2b01131ad126 bp 0x7fff818edb50 sp 0x7fff818edb48
        READ of size 8 at 0x60e00041a3d0 thread T0
            #0 0x2b01131ad125 in SalBitmap::DropScaledCache()::$_0::operator()(std::pair<ScaleCacheKey, BitmapEx> const&) const /vcl/source/app/salvtables.cxx:154:40
            #1 0x2b0113043742 in void o3tl::lru_map<ScaleCacheKey, BitmapEx, std::hash<ScaleCacheKey>, std::equal_to<ScaleCacheKey> >::remove_if<SalBitmap::DropScaledCache()::$_0>(SalBitmap::DropScaledCache()::$_0) /include/o3tl/lru_map.hxx:156:17
            #2 0x2b01130432e5 in SalBitmap::DropScaledCache() /vcl/source/app/salvtables.cxx:153:16
            #3 0x2b0113043d38 in SalBitmap::~SalBitmap() /vcl/source/app/salvtables.cxx:159:27
            #4 0x2b01145628bc in SvpSalBitmap::~SvpSalBitmap() /vcl/headless/svpbmp.cxx:44:1
            #5 0x2b0114593be3 in void __gnu_cxx::new_allocator<SvpSalBitmap>::destroy<SvpSalBitmap>(SvpSalBitmap*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/ext/new_allocator.h:140:28
            #6 0x2b01145939d9 in void std::allocator_traits<std::allocator<SvpSalBitmap> >::destroy<SvpSalBitmap>(std::allocator<SvpSalBitmap>&, SvpSalBitmap*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/alloc_traits.h:487:8
            #7 0x2b0114593184 in std::_Sp_counted_ptr_inplace<SvpSalBitmap, std::allocator<SvpSalBitmap>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:535:2
            #8 0x2b010fb8cba6 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:154:6
            #9 0x2b010fb8c9d7 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:684:11
            #10 0x2b01117831dd in std::__shared_ptr<SalBitmap, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr_base.h:1123:31
            #11 0x2b0111782267 in std::shared_ptr<SalBitmap>::~shared_ptr() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/shared_ptr.h:93:11
            #12 0x2b0112b4f51e in Bitmap::~Bitmap() /vcl/source/bitmap/bitmap.cxx:166:1
            #13 0x2b010faac276 in BitmapEx::~BitmapEx() /include/vcl/bitmapex.hxx:37:37
            #14 0x2b0112dbb6bd in std::pair<ScaleCacheKey, BitmapEx>::~pair() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_pair.h:198:12
            #15 0x2b0112de2cfd in void __gnu_cxx::new_allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > >::destroy<std::pair<ScaleCacheKey, BitmapEx> >(std::pair<ScaleCacheKey, BitmapEx>*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/ext/new_allocator.h:140:28
            #16 0x2b0112de2ba9 in void std::allocator_traits<std::allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > > >::destroy<std::pair<ScaleCacheKey, BitmapEx> >(std::allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > >&, std::pair<ScaleCacheKey, BitmapEx>*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/alloc_traits.h:487:8
            #17 0x2b01135146cc in std::__cxx1998::__cxx11::_List_base<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::_M_clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/list.tcc:76:4
            #18 0x2b01135471ce in std::__cxx1998::__cxx11::list<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_list.h:1406:9
            #19 0x2b01135470f4 in std::__debug::list<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/list:539:9
            #20 0x2b0113541f69 in o3tl::lru_map<ScaleCacheKey, BitmapEx, std::hash<ScaleCacheKey>, std::equal_to<ScaleCacheKey> >::clear() /include/o3tl/lru_map.hxx:179:18
            #21 0x2b011353ce61 in DeInitVCL() /vcl/source/app/svmain.cxx:586:37
            #22 0x2b0108fea6c3 in (anonymous namespace)::Protector::~Protector() /test/source/vclbootstrapprotector.cxx:32:13
            #23 0x2b0108fea7b4 in (anonymous namespace)::Protector::~Protector() /test/source/vclbootstrapprotector.cxx:28:35
            #24 0x2b00ed90d6ae in CppUnit::ProtectorChain::pop() /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56:3
            #25 0x2b00ed9ae022 in CppUnit::TestResult::popProtector() /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196:21
            #26 0x4ffaea in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:338:20
            #27 0x4fbbc5 in main2() /sal/cppunittester/cppunittester.cxx:478:16
            #28 0x4fa052 in sal_main() /sal/cppunittester/cppunittester.cxx:614:14
            #29 0x4f9e9e in main /sal/cppunittester/cppunittester.cxx:609:1
            #30 0x2b00ef76f554 in __libc_start_main /usr/src/debug/glibc-2.17-c758a686/csu/../csu/libc-start.c:266
            #31 0x425894 in _start (/workdir/LinkTarget/Executable/cppunittester+0x425894)
        
        0x60e00041a3d0 is located 16 bytes inside of 152-byte region [0x60e00041a3c0,0x60e00041a458)
        freed by thread T0 here:
            #0 0x4f7080 in operator delete(void*) /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_new_delete.cc:160
            #1 0x2b0112dd4714 in __gnu_cxx::new_allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > >::deallocate(std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> >*, unsigned long) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/ext/new_allocator.h:125:2
            #2 0x2b0112dd46c1 in std::allocator_traits<std::allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > > >::deallocate(std::allocator<std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> > >&, std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> >*, unsigned long) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/alloc_traits.h:462:13
            #3 0x2b0112de2c5d in std::__cxx1998::__cxx11::_List_base<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::_M_put_node(std::__cxx1998::_List_node<std::pair<ScaleCacheKey, BitmapEx> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_list.h:387:9
            #4 0x2b01135146de in std::__cxx1998::__cxx11::_List_base<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::_M_clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/list.tcc:80:4
            #5 0x2b01135471ce in std::__cxx1998::__cxx11::list<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_list.h:1406:9
            #6 0x2b01135470f4 in std::__debug::list<std::pair<ScaleCacheKey, BitmapEx>, std::allocator<std::pair<ScaleCacheKey, BitmapEx> > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/list:539:9
            #7 0x2b0113541f69 in o3tl::lru_map<ScaleCacheKey, BitmapEx, std::hash<ScaleCacheKey>, std::equal_to<ScaleCacheKey> >::clear() /include/o3tl/lru_map.hxx:179:18
            #8 0x2b011353ce61 in DeInitVCL() /vcl/source/app/svmain.cxx:586:37
            #9 0x2b0108fea6c3 in (anonymous namespace)::Protector::~Protector() /test/source/vclbootstrapprotector.cxx:32:13
            #10 0x2b0108fea7b4 in (anonymous namespace)::Protector::~Protector() /test/source/vclbootstrapprotector.cxx:28:35
            #11 0x2b00ed90d6ae in CppUnit::ProtectorChain::pop() /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:56:3
            #12 0x2b00ed9ae022 in CppUnit::TestResult::popProtector() /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:196:21
            #13 0x4ffaea in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:338:20
            #14 0x4fbbc5 in main2() /sal/cppunittester/cppunittester.cxx:478:16
            #15 0x4fa052 in sal_main() /sal/cppunittester/cppunittester.cxx:614:14
            #16 0x4f9e9e in main /sal/cppunittester/cppunittester.cxx:609:1
            #17 0x2b00ef76f554 in __libc_start_main /usr/src/debug/glibc-2.17-c758a686/csu/../csu/libc-start.c:266
        
        Change-Id: Ief4b3e60a8846121a828f1c933cc3c7dc3fe0369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128150
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-10  Miklos Vajna  <vmiklos@collabora.com>  [bf883027ee62ece0844730572305094f53daa521]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 78e8b7920821848f56d081972a2875ed10bba299
          - Add initial help for the cui textcolumnstabpage
            
            Based on the cui textanimtabpage help page.
            
            Change-Id: I744794a13f10145565e78fb45f558db0c5ff3091
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128204
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-01-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [093c98dcb4be1c124871468f73be4b59ec99af1f]

        sc: make icon size of cond. formatting same as font size
        
        This makes the behavior of the Calc te same as other spreadsheet
        programs, where the icon size of the conditional formatting is
        the same as the font size and not the actual cell height (as it
        is the behaviour now).
        
        Change-Id: I00c96ad83458cd31f67c0b6f566e3d01dd8cd47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128185
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [ef5e2d8604b976d352b944c007ae71aa33ffc607]

        Move HAVE_MORE_FONTS into an extra config header
        
        No need to recompile most of LibreOffice, because the --with-fonts
        configure flag changed. This preprocessor define is just used by
        unit tests anyway.
        
        Change-Id: Ia2eae7d0c74e59e034fdd8513504a34e51ab428e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128197
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Caolán McNamara  <caolanm@redhat.com>  [b4a281af53efa0c36ee1770e6cf4d800be77a6d2]

        ofz#43818 delete of uninitialized pointer
        
        Change-Id: I91509915c18c3e9b54cb3047462b9dd9a8c7a46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-09  Caolán McNamara  <caolanm@redhat.com>  [e28f4b6bccafb2b9f3c44dfabf36d1b822d85f84]

        ofz#43458 avoid OOM
        
        Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-09  Caolán McNamara  <caolanm@redhat.com>  [27e9de358b4afc6a89b09c173316cee0abfb471d]

        ofz#43446 Undefined-shift
        
        Change-Id: Ibe3485983ecf764ca8b8e667b470c6b210b6d2d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128192
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-09  Hossein  <hossein@libreoffice.org>  [7ac5ee3546e15455c5ee306af234bb7fe8a29049]

        tdf#146084 No hyphenation warning for Pashto
        
        Pashto language, which is spoken in Afghanistan and Pakistan uses the
        Arabic script, and does not use hyphenation.
        
        Change-Id: I87a1235b183055b0961ab27f45281be7aa9965c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128191
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-09  Stephan Bergmann  <sbergman@redhat.com>  [6e527140e8a75a999db2a35208fb85ab3bb552a8]

        Improve some CPPUNIT_ASSERT checks
        
        (In each case, the name of the file is obvious from the surrounding
        code, so there's no loss in not having CPPUNIT_ASSERT_LESS/GREATER_MESSAGE
        available here.)
        
        Change-Id: I5e4e1a30f6389f8b2801648a6179b574727f0859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128116
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-09  Noel Grandin  <noelgrandin@gmail.com>  [a3fa2c3bad77b976e7f79de5d0f2abc0283e7b3e]

        Simplify some TempFile service code
        
        Change-Id: Id39be33dcc5aa9378e29c850cb71d3662093ab25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9754b3feb4092243f30c665abc0344b1a665b5f6]

        tdf#90497 Replace Open Sans -> Noto Sans
        
        See comment #19 of tdf#90497.
        
        Change-Id: Ic102e2155ae97cb191b13f883d7c2fcec6b9a38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128139
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [032a96621d88097b62fd4613f13e7f617a9c01f3]

        Try a different approach to fix ofz#39303
        
        ... to get rid of all the "unused, assigned variable" compiler
        warnings.
        
        Reverts commit 619dcf67c1f770685c6b40477f15657f70c05865.
        
        Change-Id: I5a8bf190f00e7698f806b807b2cbfeb8fb63c766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128182
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [dd6ff1fd7fea0cfae75e5f65afed9d5f871d1313]

        implement anyToHash() and use it for SdrCustomShapeGeometryItem
        
        Using anyLess() still has quite some cost with bsc#1183308, this
        makes the cost almost unnoticeable.
        
        Since some values of Any are not handled, return empty std::optional
        for those cases.
        
        Change-Id: Ib45a81441e8bb456c4749f9bc53a981f09bbb1a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128109
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [9ba45189c76373d0464cc06902270914888162a3]

        make SdrCustomShapeGeometryItem sortable and fast (bsc#1183308)
        
        The document contains a complex graphic consisting of many shapes,
        and SfxItemPool tries to avoid duplicates by checking for equality.
        And SdrCustomShapeGeometryItem contains a UNO sequence as data,
        and comparing those is non-trivial. Make the item sortable, which
        should make things faster, and use anyLess() for the ordering.
        Additionally first check the size of the list of property names
        the class keeps for an easy fast return.
        
        Change-Id: I49220e589b6510c6f1f40d584301be83367fb5a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128047
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [74a37dce322d56251edfa49e7b98a2195f8c8e45]

        make SdrCustomShapeGeometryItem internal data consistent
        
        The PutValue() function didn't update the property map properly
        the same way the constructor and other functions do.
        
        Change-Id: I107f7095077d888cd9701d87a6e536339b0257b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128104
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [afda77cd6565e53a356c0b0be93d708808079e49]

        use C++ class handling ownership for anyToString()
        
        This matches changes I did for anyLess() in my previous commit.
        
        Change-Id: Id38c49c10223340b7359765e1071d8a9f72ba92e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128046
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [ba252c51f5b49314d8a8e5f9594aedb81f358b2b]

        make anyLess() work also for compound types such as sequences
        
        The previous implementation used the specific predicates, which
        are not recursive. And since that'd require constructing Any
        instances, which copies, which would be slow, write new code
        based on anyToString() instead.
        
        Change-Id: I439f81d4b1efbd46c10d50d0725a5f6f40968b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128045
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Luboš Luňák  <l.lunak@collabora.com>  [9e7e63b8f812977b253b05db8a02dd0444de375a]

        uno sequences with different sizes are not equal
        
        This should often the case, and should be way faster than the UNO
        data comparison.
        
        Change-Id: Ied648d75779ef3aafd293c36906a1bab66bdeade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128098
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-09  Mike Kaganski  <mike.kaganski@collabora.com>  [1bdb4ddfc516d62f482f83fc6191e9585aa4786b]

        Slightly optimize code handling angles
        
        Change-Id: I8bc10513f6cd704abc7a2bbb17d8d0d8d2628401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128187
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [dbf57c78f075fe0e255cc7d256cd1416569d2bb0]

        VCL drop unused glyphcache include
        
        Change-Id: I5c7461a9ee5d63024b8376f4173d418c21a07935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128184
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [7af8def453c1cc066b439a14bf207ea42bcd6acb]

        Replace single sw.level2 log area user with area sw
        
        Change-Id: I3df5c5f937361a7a0283a05a7b9c6669bb404c1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128183
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [0c124cb6e112b340c397c7615b127e71fbfd5e8c]

        Qt minimize modal reparenting a bit
        
        Change-Id: Ie7203e9d92e5971de6c2730ff847f351e5641c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128178
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Julien Nabet  <serval2412@yahoo.fr>  [652a7f1fce0daedee2efa1034ac6047dd49e206e]

        Add TODO in include/cppuhelper about compbase.hxx and compbase<N>.hxx
        
        Change-Id: If046e624d6fe5a711aec803652800a4a3830ec74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128181
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [f7346dc88200fa2160d39b4e4b4ae31fcad59a8c]

        Qt use platform-independent visibility functions
        
        show() isn't just some conveniently renamed setVisible(true), but
        presents a window in a platform-dependant way, which - at least
        for WASM - means maximized and without a title bar. This is not
        really expected and WASM can also use multiple windows.
        
        Change-Id: I3fbaec1dfc2cd32bf3a90a94dcee01ebc88e58c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128179
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [b6feea0a84d34a2d74fcba499a48c5902f42200c]

        soffice.sh depends on config_host.mk for the sed
        
        Change-Id: Ifd2ab80fcbfa05ad606a88ac83f1f65dd1713490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128180
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Hossein  <hossein@libreoffice.org>  [7650d164a1e9c34ce99bf30bf4198e7ceb21fb5d]

        tdf#146084 No hyphenation warning for Vietnamese
        
        The Vietnamese language does not use hyphenation, so LO should not
        warn for lack of hyphenation data. This was described in the commit
        message of 151c56ed547490a99d912524c0e56b5d6d4a1939, but the actual
        code for fixing the problem for Vietnamese langauge was missing.
        This patch, adds the Vietnamese language to the list of languages
        that do not use hyphenation, so the warning for the lack of
        hyphenation data will no longer be displayed for this language.
        
        As described in the above commit:
        
        "In Vietnamese all words consist of single syllables, so they are
        often very short; hyphenation is not allowed at all."
        https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf
        Hyphenation is declined in Vietnamese orthography since 1975
        https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography
        
        Change-Id: Id8d3681ad0a93065e61e9da2422af64793fbc111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128177
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-09  Jim Raykowski  <raykowj@gmail.com>  [35d8a3f15266e5280c9a1255417c47b5ad22a5e6]

        SwNavigator: Fix outline select when table is the only content
        
        Prior to this patch for outline content having only a table(s), right-
        click on an outline entry without the cursor and choosing 'Select' from
        the context menu only selects the outline paragraph when the current
        cursor position in the document is after the outline to be selected.
        The solution given here is to move the document cursor to the outline
        being selected before the outline selection is made.
        
        Change-Id: Ie25bfc81306dfb10a8ced8369e0ee7de0f3eacff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127884
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [3a683edd9c77e20255357879fc70ce49c9217fa8]

        Catch exception if failing to set the drag source
        
        ... or the drop target.
        
        This is the "don't trust the comment or lose a day debugging WASM
        AKA don't switch of your brain" commit.
        
        The comment was "createInstance can throw any exception", so - no
        more createInstance, no more exception! Nope, you're WRONG! While
        the uno::Reference<...>::set(..., UNO_QUERY) might itself not
        throw an exception, something else from the CreateDragSource or
        CreateDropTarget call could.
        
        The symptom was a caught exception when loading the initial Writer
        document in SynchronousDispatch::dispatch.
        
        While at it, also apply the clean-ups suggested by Mike Kaganski
        in a comment to the original patch after the merge.
        
        Regression from commit 031576105c21b2e0c2585a1236092487d5d193e2
        ("VCL move platform code from mouse.cxx into plugins").
        
        Change-Id: If80a90a9a6c070d912584f85b9fd10382b98e29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128175
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-09  Stanislav Horacek  <stanislav.horacek@gmail.com>  [9f55945b125f196226738d4c44e456dbcf511549]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e181836ae842bdafb6c54bfca86e054540f53510
          - fix names of TableControl properties showing headers
            
            Change-Id: I2ac8de7ea17ed7a24244a59cdb10b14803e76769
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128144
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-08  Noel Grandin  <noelgrandin@gmail.com>  [4c4ce3dc2133199f0d804a686a1e0cd0c9124914]

        tdf#146556 feature 'drag-mirror' is broken
        
        regression from
            commit 11e52fe2979b0947814a49b9c17ec373795cbf8e
            introduce Degree100 strong_int type
        
        where I tried to introduce a more efficient NormAngle36000
        calculation, but it produces the wrong answer.
        
        Change-Id: Iefeb0849984bc59d3ce9191eaf6f064beba94c59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-08  Noel Grandin  <noel@peralex.com>  [31872a382342060d6e1ecd9168b2a8c7a57d4717]

        fix Options->LibreOffice->View->Visibility->Menu on Windows,
        
        impossible to set to Hide, regression from
            commit 131759a3db51140c21594308ed99c71aa7aba43a
            Date:   Sun Jul 25 16:21:39 2021 +0200
            use officecfg for menu options
        
        Change-Id: I5312be2963d15ab85c267ece073e52984b1a34de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [e44b54a847672836253f56feab9d9ed2c11c0bc7]

        Fix build
        
        Commit 326351e2b342eae5ca0154b2ba303b937a696577 crossed with
        commit b37f9fbf05e16eb58eae40c6d900a4b9da2972db.
        
        Change-Id: I1a10641aa0324e6af25698bb52d82157898c45d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128142
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-08  Ramreiso Kashung  <ramreisog24@gmail.com>  [4e5bbcdc3d1fc4dd94ec896480ab049f3a4926fa]

        Optimise a range-based for loop
        
        This patch is an extension of https://gerrit.libreoffice.org/c/core/+/127734 related to comment made by Mike Kaganski
        
        Change-Id: Ia7a6480dba2a0752a52ae4f9655c345af9f3ba64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128134
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-01-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [c906ac8e8a06dc5df980e56d7d6776dfcb08aa2a]

        Don't install the uno script when uno is not build
        
        ... move it into cpputools and rename ure/Package_install.mk to
        ure/Package_ure_install.mk, to match the module name.
        
        Follow up from commit 92a90cf5ccb998d2fcc77a62bb971534e410cdec
        ("Don't build the static uno binary"). I missed that hunk in a
        larger patch, because the script was in a different module, then
        the binary.
        
        Change-Id: If7f3152be9567cf84be176d3fedefbcd5ad8d387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128138
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-08  Caolán McNamara  <caolanm@redhat.com>  [326351e2b342eae5ca0154b2ba303b937a696577]

        move UserData bodge into VCLXMenu
        
        Change-Id: I20c303788e576a29574a696cb20c9e8a235233b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-08  Caolán McNamara  <caolanm@redhat.com>  [5f6aed6016c33c3d2dae26789ac3b6b69f5edbba]

        tdf#146641 allocations attempted while hidden are discarded by gtk
        
        Change-Id: I46288cf4c106e2763feba298f1c44dbbf6c85581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128132
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2fe749a2559a2fde67e930ffbaa0fa85663b6650]

        Fix typo
        
        Change-Id: I4d16867dece00154161fef0344d521aae24be288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128130
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [dabeab27dae5d3aef2bf41c186a6fc308d617466]

        vcl: Create listfonts utility
        
        The listfonts utility gets the details of all available fonts on the
        system. It prints out the information, or stores it in a text file,
        if a file name is passed to it as an argument.
        
        An example invocation to store the information in a file named
        fonts.txt is:
        
            ./bin/run listfonts fonts.txt
        
        To get the correct font metrics, you actually have to get the font
        metric from the system, and then set it as the current font of
        OutputDevice, then get the font metric (which corrects a variety of
        things like the orientation, line, height, slant, etc. - including
        converting from logical coords to device coords).
        
        The information is reported for each font family. On the top is the
        family name, and then comes other details. Here is a report for an
        example font:
        
        FreeSans
            Family type: swiss
            Style name: Regular
            Weight: normal
            Italic: none
            Pitch: variable
            Width type: normal
            Alignment: top
            Charset: UCS2 (aka Unicode)
            Symbol font? no
            Ascent: 13
            Descent: 3
            Internal leading: 0
            External leading: 2
            Line height: 16
            Slant: 0
            Bullet offset: 0
            Fullstop centered? yes
            Orientation: 0 degrees
            Quality: 18477
        
        There is a -v (or --verbose) option that output font features.
        
        Change-Id: Icfc4da96459bea47c4233a5509496566c04d460c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127365
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [ed1aa172f8807ee479e4f529df49d19c13a8bc86]

        Unify condition names and fix "else" paths
        
        Drop Build prefix and settle on Lib and Exe prefixes. Also add a
        note about the "else" part of the condition and fix offenders.
        While at it, define COND_LIB_SAL_TEXTENC to be used by sal to
        prevent diverting coditions in build and cxx code.
        
        Change-Id: I944587ca1ccbe46b765d1a631a7214c8126fe951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128136
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [92a90cf5ccb998d2fcc77a62bb971534e410cdec]

        Don't build the static uno binary
        
        Change-Id: If6d5384d4692fba94070bb11bb5a47a66b813f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128135
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [692838e958310cb8497d4b4f8994bdaa5c0f1942]

        sp2bv is just used by the ODK on Windows
        
        And I should have tested gb_Helper_optionals_and. Inspecting the
        generated token for comparison doesn't result in gb_[T1]_[T2],
        as I expected. So first filter the token from BUILD_TYPE, then
        filter-out the result from the input token. If true, then both
        sets are equal == and.
        
        Change-Id: I74a324f766331b30a0af9c9bfd7c927c1d21df53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128115
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [35aa82ef1c8047087e7eb76fe5abccbe48fbac1e]

        tdf#145693 - Argument name should be 'charcode' instead of 'string'
        
        In addition, changed argument datatype from Int to Long.
        
        Change-Id: I702e09b6b8061d7cf00dd403e4681a0ab348d4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128100
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d0445802a86d67b55b5e333a4c815d062b5e6036]

        Use WindowsErrorString instead of FormatMessageW
        
        Change-Id: I183f19f6abd4ca3f54d13533c8551deb09cd9458
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128118
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-08  Noel Grandin  <noelgrandin@gmail.com>  [563af8fd15aa37e75af8882cccbdf8914ebe8e61]

        tdf#144890 Invalid selection area when text in LTR run
        
        In
            commit ec50b9e5eaec7c94df35617676077ef0d65cecc7
            no need to allocate Sw2LinesPos separately on heap
        
        I made this change,
        
            // If there's no doubleline portion involved or start and end are both
            // in the same doubleline portion, all works fine, but otherwise
            // we need the following...
        -    if( pSt2Pos != pEnd2Pos && ( !pSt2Pos || !pEnd2Pos ||
        +    if( (pSt2Pos || pEnd2Pos) && ( !pSt2Pos || !pEnd2Pos ||
                pSt2Pos->aPortion != pEnd2Pos->aPortion ) )
        
        I tried to follow the explanation in the comment, since the
        existing comparison of pointers made no sense, since the two objects
        would always be distinct.
        
        However, that appears to have caused this bug, so change the
        comparison to directly represent the original logic.
        
        Change-Id: I95d6d870cecd762d4eb809d371e4a61b6641c85e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2d742faa062d3656f751b32acfe089ffa2dca3f]

        reduce cost of Sdr properties for text-derived objects
        
        when they have no text in them
        
        Change-Id: I70c18898abf21141f3b30b7dee9c931c9b27cffb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Hossein  <hossein@libreoffice.org>  [151c56ed547490a99d912524c0e56b5d6d4a1939]

        tdf#146084 Don't warn for languages without hyphenation
        
        Upon opening a Writer document containing some languages that do not
        use hyphen, an alert is created with the text:
        
        'Missing hyphenation data Please install the hyphenation package for
        locale "ab_CD".'
        
        in which 'ab_CD' is the locale.
        
        This patch removes the warning for these languages, that do not use
        hyphenation:
        
        * Arabic script languages (except Uighur)
         + Persian (Farsi)
         + Kashmiri
         + Kurdish (Central Kurdish and Southern Kurdish with Arabic script)
         + Punjabi
         + Sindhi
         + Malai
         + Somali
         + Swahili
         + Urdu
        "Words are not hyphenated in Arabic language text, however hyphenation
        is possible for Uighur text written in the Arabic script"
        https://www.w3.org/International/i18n-tests/results/word-break-shaping
        The list from MS documents is lenghty, but some of the languages are
        were not available in LibreOffice, so they are ommited:
        https://docs.microsoft.com/en-us/typography/script-development/arabic
        There were languages like Hausa and Kanuri from Nigeria that use both
        Latin and Arabic script, but only Latin script was listed in the
        LibreOffice languages, so they were also ommited.
        
        * CJK languages
         + Japanese
         + Korean
         + Chinese
         + Yue Chinese
        "CJK languages differ from European languages in that there are no
        hyphenation rules"
        https://tug.org/TUGboat/tb25-0/cho.pdf
        
        * Vietnamese
        "In Vietnamese all words consist of single syllables, so they are
        often very short; hyphenation is not allowed at all."
        https://tug.org/TUGboat/tb29-1/tb91thanh-vntex.pdf
        Hyphenation is declined in Vietnamese orthography since 1975
        https://www.quora.com/When-did-hyphenation-decline-in-Vietnamese-orthography
        
        The fix for Japanese (tdf#143422) was previously done in:
        53d5555f13371252874ec962dee4643168d26780 and the functionality is
        preserverd with the current patch.
        
        An alternate approach would be adding all the unicode scripts,
        specifying the script for each langauge, and decide upon the script
        (mostly) and not (only) the language.
        
        More information about the hyphenation usage of many scripts can be
        found in:
        https://r12a.github.io/scripts/
        
        This is the list of Unicode scripts:
        https://unicode.org/standard/supported.html
        https://en.wikipedia.org/wiki/Script_(Unicode)#List_of_scripts_in_Unicode
        
        Change-Id: I7d2b4ee55a0893d1f0d1f9cd3b7cc037a49589b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126435
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [9ec6c2989897a2a54b6bcf82f61929c29ac62126]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a5cccb45ec8ea2e4e45a92668136d4cbe045f7f4
          - tdf#145866 Fix information about accessing Function List
            
            Change-Id: Icfa91482c8260dc838e53eee5dafee54fca7a5b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127953
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [a6415004630c28ac4c0a64b83d8f0fd5c77a6a31]

        ofz#43388 Direct-leak
        
        Change-Id: I5d410461d7b4e8466533fc4186ee77ec99fae089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128123
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Stephan Bergmann  <sbergman@redhat.com>  [5dda4fb74a7f961d067d4a5b8760d96466ebd0be]

        -Werror,-Wshadow
        
        ...after c35f81148fb18ba070516edcbb4d614444899235 "Use
        sal::systools::CoInitializeGuard and sal::systools::ThrowIfFailed"
        
        Change-Id: I3df9fd523820e1d3651480d51ebbaafaafa3ed48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128095
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [4cb6f75b390760c52f7f59fc973eaf07dfb11f44]

        Don't build a static unopkg
        
        Currently we don't destinguish between between extensions without
        code, which couldn't be executed with DISABLE_DYNLOADING, and all
        other extensions, like translations, dictionaries, etc., so there
        is no need for a static unopkg.
        
        Change-Id: I427a51b3174d074e467a582e808490a85e98e8eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128114
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [33e1ffac0264f21a291d80f7fe949245752f58d8]

        Use CreateThread instead of _beginthreadex
        
        Untested change - this code seems to be not compiled in 'make check'.
        
        Change-Id: I02189c88360da585b8419f96cbe2677b224e6712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128122
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [54add6c702cfef4898ae750caa98c3d18c6f60a3]

        Use CreateThread instead of _beginthreadex
        
        Change-Id: Idae8112f0684f6d3aac70c4450eedc77e48432dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128121
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [97e2dc2ed0c4602c7823bdd6c6d5376e8da60c62]

        Disable oosplash pagein feature for static builds
        
        I'm not sure how useful this is today. Still hard-disabled on Mac
        and Win. Obviously unneeded for static builds.
        
        Change-Id: I3a95dede3c596ccdc0d15eba9edc072ad35f33fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128089
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [b5d9fefe0e3ac56eef247c90b137d4b6d7a667c6]

        Use CreateThread instead of _beginthreadex
        
        Change-Id: I7c272880d6567bc669d4c3c2684aa2e0daeca1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128120
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [7cdae23d690921349737c5da30ea7bc125ad2d2e]

        Use CreateThread instead of _beginthreadex
        
        Change-Id: I5633674ba7dcb03d9ad3049fa5eb380d385983b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128119
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [809a36a6d5beb09ca916ee4313bc19a92099a672]

        Use CreateThread instead of _beginthreadex
        
        Change-Id: I4a106a670daaca85cefed08c7baeaa980841a233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128117
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Julien Nabet  <serval2412@yahoo.fr>  [dcb7bd026cc1813eaee8b7dadba0583348b4458e]

        Mysql/MariaDb direct connector: don't show system schemas
        
        Let's do like MYSQL JDBC where no system schemas appear and let's remove:
        - information_schema
        - performance_schema
        - mysql
        
        Remove all the crufts about information_schema then.
        
        Also, Mysql 5.1 has been released in 2008 and 5.0 beta was in 2005 (no production date indicated in Wikipedia for 5.0)
        So we can consider there's no need in 2022 to test if Mysql > 49999
        
        Change-Id: I49715bb5aa21681b687bab0e75603e4bd0c422de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128062
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-07  Miklos Vajna  <vmiklos@collabora.com>  [b1df51873452014f84ef04872c4376258ee8d6cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93f11134d0d2e6005dcb1f15c0f9ea97d06ba7ca
          - Document the theme palette, as a second special one
            
            The palette list is followed first by the theme colors, finally by the
            document colors.
            
            Change-Id: I3183f709a1de27eaf6cba33e747831dd7a4b7168
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128128
            Tested-by: Jenkins
            Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
            
2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [8fd6924fc36b7a006e2edec60b7b59cec2ca883b]

        Resolves: tdf#129745 don't override child help for application frames
        
        the glue WindowInstance is created on demand, and on creation descends
        into any existing open dialogs and changes their help handlers. We could
        not descend into child dialogs, but we shouldn't change the app frame
        help handler anyway.
        
        Change-Id: I8d149d324f04824fbe9eec517d8c482fd96b125b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128112
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [568423845a06923bfdd365f29b67deaab7ce269d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c5aa1b0f8efcfb5e4963af8ce667ccb5866fc317
          - tdf#97674 Add information on how to remove protection from a section
            
            This patch adds detailed information on how to remove protection from a section. It also adds bookmarks so that when the user presses F1 in the warning message, the appropriate help page is shown.
            
            Change-Id: Ie4c310375995ce56e7e0153255ab8366b16dc532
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128068
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [b2bd92f4a59b2ef3e98bc4eaba3ef750562ca10e]

        fix hierarchy in comment
        
        Change-Id: Ieaf94ce6ce524c4c017cbe1bb82fa75bd5f7e801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128094
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [c037ff2a2d1c83eb8fc0595e335dd8174b9062fc]

        make GroupProperties extend BaseProperties
        
        it doesn't need any of the logic in DefaultProperties
        
        Change-Id: I75d56a29f1edf2819c22a1fd69df464948544aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128093
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Miklos Vajna  <vmiklos@collabora.com>  [1984a5c140cc3c7c291047dacf3bddd7061d2047]

        PDF export of PDF images: preserve hyperlinks
        
        The input file has a single page, with a full-page PDF image, which
        contains a hyperlink. Similar to pdfcrop, we used to wrap this into a
        form XObject, so page-level annotations like hyperlinks were lost.
        
        Explicitly merge page-level annotations from the source page to the page
        that contains the PDF image to preserve those annotations.
        
        Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128108
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [7df337b3636f9df9bf05d7f493e6c89e43c3f5ca]

        tdf#146423 don't set a size-request during a size-alloc
        
        and use a better width calculation
        
        Change-Id: Ib873a8ed9e6424c09630650af352ba5a20c674b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128051
        Reviewed-by: Kevin Suo <suokunlong@126.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [639419601a3730eb84d0922ef3a540c961b81910]

        tdf#146621: handle an exception that may hang process at ExitProcess time
        
        Change-Id: I3ffc2303ae1851ab909612ae9bb7f70a077b24fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128097
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [8295a3344704ce9a18489933c499a50c403f1a3d]

        remove E3D_INVENTOR_FLAG and convert SdrObjKind to scoped enum
        
        We don't need E3D_INVENTOR_FLAG, we can just check if the SdrObjKind is
        in the right range.
        
        Which exposes some dodgy code in DrawViewShell::GetMenuStateSel
            SfxItemState::DEFAULT == rSet.GetItemState( OBJ_TITLETEXT ) ||
            SfxItemState::DEFAULT == rSet.GetItemState( OBJ_OUTLINETEXT ) ||
        which has been there ever since
            commit f47a9d9db3d06927380bb79b04bb6d4721a92d2b
            Date:   Mon Sep 18 16:07:07 2000 +0000
            initial import
        just remove that.
        
        In SwFEShell::ImpEndCreate() move some logic around to avoid
        using an out-of-range SdrObjKind value
        
        Change-Id: I4620bfe61aca8f7415503debe3c84bfe5f4368a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127763
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [8accfa30343195b5d7cfd111301677a6a9b6a21b]

        Use clear() instead of remove_if
        
        Change-Id: I1d312798b66ae4ef4be1ac7c838d2f0e18691f80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128069
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [bb20a583e8d02ce25e8b287b15764f2c2a52a5de]

        add truncate-multiline to match the vcl default
        
        Change-Id: Idd188ed20191668c412791e8f081be7ca377478f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128103
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [77611e43241dfe3b6224d792156c8457a0fd93d8]

        Objct->Object
        
        Change-Id: I5a69596e65b300bd57fd539fe696f1c064ce555f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [71be70b16b37fb3c1b6331ab3581300556ecc7aa]

        ofz#43376 Null-dereference
        
        Change-Id: I57f67465e4f8ca6fc6bd47d7b095e9b470d9d2c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [260a2036d688afddc6e6e477764e1196cc915194]

        tdf#130426 - Rename file for tdf#145693
        
        Change-Id: I1435f3e8c8ecf41ecd6b2766e19009c6b1783326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128099
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2022-01-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b71d6953f0fa8edd809e9957822f0134ea726c4f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 16edeee7671a4dcbc23180e0d1829cbc1fbf2e92
          - tdf#146580 No info on Document palette
            
            Change-Id: I79fe3f451bbaa43824e1ee5659456324412b79fd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128032
            Tested-by: Jenkins
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            
2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [93790b70ea663184f758031dc5af311828fe36ad]

        move applyDefaultStyleSheetFromSdrModel from BaseProperties..
        
        to AttributeProperties, since it only applies to AttributeProperties
        and its sub-classes.
        
        Change-Id: I01527f75815659d1cf2a9859888ef04c561633a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128092
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [c52aa97b988aeeb16d1eb21262889f565b8a72a3]

        move some methods BaseProperties->DefaultProperties
        
        These methods are part of the implementation of DefaultProperties,
        so they do not belong in a superclass
        
        Change-Id: I553f5d5b771aa0a408a8ade25f009cc56f829c72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128091
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [81ccab11ff457786c3877e7b0047d08685493d3c]

        split PageProperties from EmptyProperties
        
        to make it clearer - PageProperties just ignores stuff,
        but it is not a logic error to set props on it (or so
        it seems from its comments)
        
        Change-Id: Iba3dbcdffae6165a14e9a2d71e4111fbbd29febb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Luboš Luňák  <l.lunak@collabora.com>  [2692dc5f662c74e3df63224ae829fc492503aa1e]

        save alpha channel processing when not needed
        
        Change-Id: Icbf19e86b833c0cec08a9ac5c41c01fd2dd1a4e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128060
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-07  Luboš Luňák  <l.lunak@collabora.com>  [c4b83dc2c4b8d4ea4b664b34309fbf0cf2fd8ad1]

        CUCKOO_CFLAGS is unused
        
        The include is set explicitly in RepositoryExternal.mk . And
        when using system cuckoo, it's not necessary to refer to the
        unpacked tarball location.
        
        Change-Id: Idd241f7551fb98cb5948c4e7007204ad3a8d87a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128061
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [7e4ddea574b18aeed678526cac42f45613b4ae20]

        Resolves: tdf#146342 spelling menu doesn't appear
        
        the XPopupMenu from CreateMenuInterface owns the vcl menu after it's
        created.
        
        Change-Id: I0959b3359a4683ce8ca50912136f829b8bbee859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128063
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Caolán McNamara  <caolanm@redhat.com>  [75f1d3a9109acd4edd96033edbabe53d80920a52]

        Resolves: tdf#146285 the "edit" button should be insensitive
        
        for this case
        
        Change-Id: Ib60577d10bd4a91ea01c5aa6fcf3d50b38fbe24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-07  Stephan Bergmann  <sbergman@redhat.com>  [2796d4ab5c3cc3637d04b33a5e7f0dad4c90d408]

        loplugin:redundantcast
        
        Change-Id: Ia68f492ebd4ac81feb44e736c53f0f4a2d99274d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128096
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-07  Stephan Bergmann  <sbergman@redhat.com>  [982ecf4407854208a909898b8a69b1d8ca35d519]

        Silence various UBSan warnings in external/freetype
        
        > workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:1992:44: runtime error: applying zero offset to null pointer
        
        etc. seen during CppunitTest_sd_misc_tests etc.
        
        Change-Id: Id85c4331f9a892d99e4f3b9cae37b4ffe8c53973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128034
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-07  Mike Kaganski  <mike.kaganski@collabora.com>  [6d0956c8a61bacc154bef225f83eb74cdf442c57]

        Drop unused forward declaration
        
        Change-Id: Id2053d255624cef365753debea83d4bf1c3d9de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-07  Miklos Vajna  <vmiklos@collabora.com>  [7b8bb9f085ca8e70247da48fdd2bf7ab06a0a102]

        sw: remove debug code that doesn't build anymore in ww::SortedArray
        
        It also claimed "You will not see this message again", but I don't see
        how the matching flag would be static.
        
        Change-Id: Ia003dc9c6326d44ad4f4409bed6aca490bfc964e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128064
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-07  Gabor Kelemen  <kelemeng@ubuntu.com>  [a49865c8dab0e8117bc37da6725efd6f6d6af8ae]

        Drop unused define CLASSPATH_DELIMITER
        
        since commit 200cc2d20a21ceb5d176604f9c384f15c6a87570 (2014)
        
        Change-Id: Idf0eb7b484eff26be6b341cbb217572eb8da7306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127809
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-07  Noel Grandin  <noelgrandin@gmail.com>  [f07a2d1b5c7c6deabe6da60892fd6f6fbffad15f]

        remove debug code
        
        accidtionally committed with
            commit 302b44125aa0c1d5216f986ecf8e341cd6e57418
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Dec 9 11:45:36 2021 +0200
            use background XShapeGroup for bar-chart area
        
        Change-Id: Id9fd82a94fd2bb046901fcd4373aac71586d0d13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [74e74e9a7b6c264112eda1f5bc9e9c5dddf9f4c5]

        fix setPropertyNameMapForFilledSeriesProperties
        
        called the wrong method to set new properties,
        rather than overwrite all existing properties
        
        Change-Id: I85de598a14876c110e414371fc07a3fde9c6a123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [031576105c21b2e0c2585a1236092487d5d193e2]

        VCL move platform code from mouse.cxx into plugins
        
        ... by moving it into ImplCreate(DragSource|DropTarget).
        
        The existing Create* variant now checks for headless mode and the
        IsRunningUnitTest flag, before creating the platform variants.
        There are two small helpers to initialize either X11 or Ole based
        UNO DnD interace implementations.
        
        Unfortunatly Windows requires to move two dtrans header files, but
        at least any other changes are minimal.
        
        Change-Id: Id79459ad71a26243b1c9cb1fe38ab236b0ab8fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128049
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [32bf2040bfa9d76731fc7c679845eb3835dde8a3]

        gbuild: fix actually used libraries for mergelib
        
        Just the $(filter $(gb_MERGEDLIBS),$(2)) in the "if" was wrong,
        but reformat and add a comment to make the code easier to read.
        
        This way we correctly header-depend on all requested libraries,
        but just export-depend on the real libraries.
        
        And actually use gb_LinkTarget__is_build_lib in the ifeq, as
        otherwise the build now fails for the reduced dependencies.
        
        Change-Id: I24d5701891324f5055c9dfa535bd854d09fbb905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127994
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-07  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [d3308503a8c320b4a1c3f6156a6b7e6a71a5806d]

        tdf#146479 - Use basegfx fTools for converting the angle unit
        
        Change-Id: Id54191d7c1e41ae444d42f6d110c4b82ba4515b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127788
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2022-01-06  Andras Timar  <andras.timar@collabora.com>  [3a0d539b3a8a76efc2cdac04c658645fe750bec4]

        tdf#73523 support WinBMPv3-NT version of BMP files (found in Visio files)
        
        It is a special case when there are additional 12 bytes of color bitfields
        after the info header. See also the useful comments at
        https://searchfox.org/mozilla-central/source/image/decoders/nsBMPDecoder.cpp#47
        
        It turned out we generate this type of BMP files internally from EMF files,
        but in that case the bfOffBits of BITMAPFILEHEADER struct points to the
        pixel data. In case of Visio, bfOffBits points to the color mask. There was
        no better solution than preventing jumping back in the stream.
        
        Change-Id: I97f0fd4f184ea77beeab8b22fc98fdb78472d9bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127920
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127927
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2022-01-06  Stephan Bergmann  <sbergman@redhat.com>  [caaff91025316a464aa979b743a4748ab2d207ac]

        -Werror=maybe-uninitialized
        
        Change-Id: Icebc6b95596e62628d00cc3c851f56a6a78ee727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128058
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-06  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [f0ad6ec2a23a36ade407db8cda36655ba2f144c1]

        tdf#145059: sc: always write dxf node for color filter for XLSX
        
        If there is no dxf reference to color filter (for example if selected
        color is not in range of available colors for current range) Excel
        is not able to show color filter correctly: it is not marked as used
        filter, no ability to reset, etc.
        
        Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-06  Mike Kaganski  <mike.kaganski@collabora.com>  [e9dce4e8cbea04d6c6636a45f5a172e986714409]

        tdf#146617: iterators may be invalidated during handler call
        
        ... when the handler decides to remove itself from listeners.
        
        Change-Id: I1d5fe802f50d284bf70d747edaff0a19852c5a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128054
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-06  Tor Lillqvist  <tml@collabora.com>  [568293d7ce6d96ba71ae8c2d591b6cf237e31db1]

        It's called a slide, not a foil
        
        Change-Id: I8b5b062faf9d2728c729384bbdafead00d5bf917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128042
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-06  Michael Stahl  <michael.stahl@allotropia.de>  [82cf116fe646c822bc91b4ae0a6c4e6e948a6f4d]

        get-bugzilla-attachments-by-mimetype: query different bzs concurrently
        
        Downside is we can't easily detect when one tracker is done, but it
        should be faster.
        
        Change-Id: Ie78ddf0381690040d7a4fa06f910717fcdfe0eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128038
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2022-01-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [7df70a1cdcec43352e25fca9fdb5687bdb0616a6]

        Switch Linux Jenkins release build to mergelibs
        
        Currently mergelibs errors just fails the later callgrind build,
        not early in Gerrit.
        
        Change-Id: I165f99fa819ea3d88b76089a5a0967731570d42a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127426
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-06  Miklos Vajna  <vmiklos@collabora.com>  [526c8bdb54eff942d5213030d1455f97720a1ba7]

        sw: fix too long inner borders intersecting with outer borders for Word cells
        
        This is similar to commit 66ac8e60896f6306bed8fbb34606fd14474f19ce (sw:
        fix unwanted long vertical border around vertically merged Word cell,
        2021-03-04), but this one is about how we handle table border painting
        when an inner border intersects with an outer border.
        
        Previously we used to paint the full outer border and the full inner
        border, which looks silly in case you have e.g. double border outside
        and a single border inside -- the inner line stops at the edge of the
        thick outer border in Word.
        
        Do the same by limiting the start of a horizontal line if its start
        would match the X coordinate of a vertical line (and the remaining 3
        combinations of hori/vert line start/end). We always limit the inner
        line, so this needs extending SwLineEntry if the line is an outer one or
        not.
        
        Change-Id: I669a271ce3a4c3c69916779d4f3167208e999f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128053
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-06  Caolán McNamara  <caolanm@redhat.com>  [d5288dd29611f2e5c4140724255cea8e7bb2b25b]

        ofz#42785 Timeout
        
        Stream::Seek (like istream::seekg) clears any eofbit
        Change-Id: I90253e69a52c4099aa2971294a215dff37e8a246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127975
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-06  scito  <info@scito.ch>  [67fb363eed88b15eec7821fe604eb23d142d84cc]

        tdf#146392 fix --enable-pch=full build
        
        x509.h includes cert.h. But that doesn't know of LO using
        xmlsecurity/source/xmlsec/nss/nssrenam.h, which has a "#define
        CERT_DecodeDERCertificate __CERT_DecodeDERCertificate". So the PCH
        doesn't know of this rename and the compiler fails.
        
        move the include line into the file that needs it and the --enable-pch=full
        build works ok
        
        Change-Id: I247bd219cf47964490ded439ad51bd8e8e120c48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127744
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2022-01-06  Jan Holesovsky  <kendy@collabora.com>  [9067b827f013caafc61ef3d0d63305572a320ee2]

        Add a comment how to use MetafileXmlDump in the tests
        
        Change-Id: I5088874be3fbf2ac114f5e5d0cd9571a3caf48dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128040
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-06  Noel Grandin  <noelgrandin@gmail.com>  [ab07c078d14970db934f5a27cfdb6c2e5413738a]

        speed up lcl_removeEmptyGroupShapes
        
        by bypassing the SvxShape layer, which adds a bunch of unnecessary
        overhead for this situation
        
        Change-Id: I0ba2f973e26e42995713d488593de7c4f3e00b88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128024
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [27775987a3355769cd8f4ca5368b9ba5731f67d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 94cb6f9bbb1410fd53c4160c76d8b77896572258
          - typo
            
            Change-Id: I1c081bbad56c1d7d047109ef0d3f86c50bf2cebf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127965
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6d2dbdde27aee8c05898c656823f4bedd1b3afee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e2c9a736ac622fcf032094ede32709dcf62f1ae
          - Typo
            
            Change-Id: Ic52b4fdd51e17ac5a55f18257d19e70d4ba7efac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127964
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-06  Gülşah Köse  <gulsah.kose@collabora.com>  [fa5ab8aa5d88e7128015127af75980a65f945cbb]

        tdf#135843 Fix the missing border handling
        
        Adding +1 at that stage causes indexoutofbounds.
        But never throws that exception and tries to pull
        empty cell style instead. As a result we can not
        see the border. Actually no idea why +1 used here.
        
        Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2022-01-06  Justin Luth  <justin_luth@sil.org>  [42e7dc75363ee7f326f7f9e2b4476e55300f1f7a]

        tdf146491 Revert "tdf121374 ooxmlexport: export H/F to def...
        
        ...default section"
        
        This reverts LO 6.3 commit e6f5dec3250b4d26bc4bb485fad2100ee29a3528.
        Something else must have changed because it doesn't seem to
        be needed anymore.
        
            It wouldn't be terrible to duplicate headers/footers
            unnecessarily,
        
        One side effect is that page styles could be
        duplicated multiple times if there were many
        non-overlapping sections. If the H/F contained images,
        that could bloat the filesize,
        or in this specific bug, it was duplicating fields.
        
        Since it doesn't appear to be necessary anymore,
        let's just revert it.
        
        Change-Id: Id95a4f162fb2ecbf6ce0f97db056071db9ebad3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128041
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-06  Caolán McNamara  <caolanm@redhat.com>  [72dfa7ec4c3cae074c9769cc99fe1b7eb029de43]

        upgrade freetype to latest release
        
        Change-Id: I2b13aceffd9932978c98c49bc688bd5f71690523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-06  Caolán McNamara  <caolanm@redhat.com>  [af55dc3891f7950d392175004b2090cb0e54828e]

        annocheck warning about missing .note.gnu.property section
        
        copy and paste recommendation from:
        https://sourceware.org/annobin/annobin.html/Test-cf-protection.html
        
        and adapt like:
        https://github.com/openssl/openssl/commit/51994e505dbb1cd0dd76869ec962e2948b77b585
        where https://bugs.ruby-lang.org/attachments/8962 is similar
        
        Intel docs have "The ENDBR32 and ENDBR64 (collectively ENDBRANCH) are
        two new instructions that are used to mark valid indirect CALL/JMP
        target locations in the program."
        
        Change-Id: Ie867c263a888763db4478720ba189c9ec6cc974d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126859
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a65c1e2d81b12c8ce96fa5cddcf11fabf7bbf709]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ce4649ea3b21406c4e95e81930097968cb95cf6
          - tdf#120247 Update CONVERT() Calc funct  wrt ODFF1.3
            
            Change-Id: I6c58f86c943cb41cb2f9161de630d3519aef9a86
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127945
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-06  Mike Kaganski  <mike.kaganski@collabora.com>  [0bc5584ef296683c015357232d48180b85f8baac]

        Add 'reference' to the iterator_traits, needed by LegacyIterator reqs
        
        This addressed a failure with VS2022 Version 17.1.0 Preview 2.0:
        
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(1152): error C2794: 'reference': is not a member of any direct or in direct base class of 'std::iterator_traits<`anonymous-namespace'::lcl_DataSeriesContainerAppend>'
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): note: see reference to alias template instantiation 'std::_Iter_ref_t<`anonymous-namespace'::lcl_DataSeriesContainerAppend>' being compiled
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): note: see reference to variable template 'const bool _Iterator_is_volatile<`anonymous namespace'::lcl_DataSeriesContainerAppend>' being compiled
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4048): note: see reference to function template instantiation '_OutIt std::_Copy_unchecked<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>*,_OutIt>(_InIt,_InIt,_OutIt)' being compiled
            with
            [
            _OutIt=`anonymous-namespace'::lcl_DataSeriesContainerAppend,
            _InIt=com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer> *
            ]
            C:/lo/src/core/chart2/source/controller/dialogs/DialogModel.cxx(504): note: see reference to function template instantiation '_OutIt std::copy<std::_Vector_iterator<std::_Vector_val<std::_Simple_types<_Ty>>>,`anonymous-namespace'::lcl_DataSeriesContainerAppend>(_InIt,_InIt,_OutIt)' being compiled
            with
            [
            _OutIt=`anonymous-namespace'::lcl_DataSeriesContainerAppend,
            _Ty=com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>,
            _InIt=std::_Vector_iterator<std::_Vector_val<std::_Simple_types<com::sun::star::uno::Reference<com::sun::star::chart2::XDataSeriesContainer>>>>
            ]
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): error C2938: 'std::_Iter_ref_t' : Failed to specialize alias template
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): error C2062: type 'unknown-type' unexpected
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): error C3376: 'std::_Iterator_is_volatile': only static data member templates are allowed
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4026): error C2976: 'std::_Iter_copy_cat': too few template arguments
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3994): note: see declaration of 'std::_Iter_copy_cat'
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(1152): error C2794: 'reference': is not a member of any direct or in direct base class of 'std::iterator_traits<`anonymous-namespace'::lcl_RolesWithRangeAppend>'
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3932): note: see reference to alias template instantiation 'std::_Iter_ref_t<`anonymous-namespace'::lcl_RolesWithRangeAppend>' being compiled
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(3992): note: see reference to variable template 'const bool _Iterator_is_volatile<`anonymous namespace'::lcl_RolesWithRangeAppend>' being compiled
            C:\PROGRA~1\MIB055~1\2022\Preview\VC\Tools\MSVC\1431~1.309\Include\xutility(4048): note: see reference to function template instantiation '_OutIt std::_Copy_unchecked<_InIt,_OutIt>(_InIt,_InIt,_OutIt)' being compiled
            with
            [
            _OutIt=`anonymous-namespace'::lcl_RolesWithRangeAppend,
            _InIt=const com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence> *
            ]
            C:/lo/src/core/chart2/source/controller/dialogs/DialogModel.cxx(563): note: see reference to function template instantiation '_OutIt std::copy<const E*,`anonymous-namespace'::lcl_RolesWithRangeAppend>(_InIt,_InIt,_OutIt)' being compiled
            with
            [
            _OutIt=`anonymous-namespace'::lcl_RolesWithRangeAppend,
            E=com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence>,
            _InIt=const com::sun::star::uno::Reference<com::sun::star::chart2::data::XLabeledDataSequence> *
            ]
            make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:332: C:/lo/src/build/workdir/CxxObject/chart2/source/controller/dialogs/DialogModel.o] Error 2
        
        Change-Id: Ic93dc7922cd48870ef62bfd682dd5cbdc827a255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128036
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-06  Tor Lillqvist  <tml@iki.fi>  [6bcf00763402fc0969486e852634b5559fa044ba]

        We don't want or need any LOKClipboard on iOS
        
        Try to make the code more like in the co-2021 branch, where copy/paste
        between Collabora Office and other iOS apps currently works again, in
        both directions, both for text and images. Sadly something is broken
        or missing either here in core or in online as it doesn't fully work
        in a Collabora Office based on the master branch of core, even after
        this commit, though.
        
        We use only the system clipboard on iOS. (It is actually called the
        "pasteboard" in Apple's operating systems.) The code to interface with
        the system clipboard is in vcl. It has worked fine to copy and paste
        between the Collabora Office iOS app and other iOS apps without any
        LOKClipboard being involved. If LOKClipboard is used it doesn't work
        at all.
        
        Change-Id: I0d3b4e3eabe17b633390e071701225e1d356a75a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128037
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2022-01-06  Alain Romedenne  <LibreOfficiant@gerrit.libreoffice.org>  [69880354d192c34fec1e77f94e55bc5e8e16dcee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d3da999f45d4db4f79e269baae9f07d48c3e7b8
          - Basic sample correction
            
            Change-Id: I1da6b83fba84a06b8da18c20cdfe3787f5c628f8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127962
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne
            
2022-01-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [302b44125aa0c1d5216f986ecf8e341cd6e57418]

        use background XShapeGroup for bar-chart area
        
        which means we don't have to set the Z-order, which is expensive for
        large charts.
        Shaves 5% off the load time
        
        Change-Id: I8c73df6ddc17a3cfedaa18dbe8ec3aeb768e3e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5cfa563169d7e012a6c6e77a3d379c2d183d9339]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b4685908844ed4891a29d5b024db8dfb493d4933
          - Calling Calc Add-in function for Dates and Pricing
            
            Inform respective UNO services
            
            Change-Id: I97f6b3a957f398074213239da79564f310e2db82
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128028
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [577a0c3f0bba24649f33af33bce20ac0be3ad184]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bcc5f53bd012afc91b7c86cd0779d179f93ab71
          - tdf#135175 Styles Inspector Help page
            
            + Borrowed contents from Jean Weber and Shivam Kumar
            + Added more descriptive examples
            
            Change-Id: Ie045498e5c0239686f20f4fe55b40067c4bb893c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127978
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-06  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [121cbc250b36290f0f8c7265fea57256dad69553]

        tdf#66039 DOCX: import textboxes (with tables, images etc.) in group shapes
        
        Text boxes in group shapes were imported as shapes, losing
        complex text content: tables (tdf#66039), colors (tdf#73022),
        images (tdf#81958), lists, paragraph styles, hyperlinks
        (tdf#122960) and track changes.
        
        Note: a few unit tests have been deactivated temporarily.
        Test document "groupshape-trackedchanges.docx" of
        testGroupshapeTrackedchanges is imported correctly now:
        with track changes, and the test was modified accordingly.
        
        Follow-up to commit 2951cbdf3a6e2b62461665546b47e1d253fcb834
        "tdf#143574 OOXML export/import of textboxes in group shapes".
        
        Change-Id: I6eb918dbf64393fd723fe43f798f93b5b9a12575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125051
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-06  Julien Nabet  <serval2412@yahoo.fr>  [470d1be4ec5a3a5a0aba8febda06600ea39852c5]

        tdf#68341: trim some variables passed on Base wizard
        
        Here is a git grep -n fillString:
        dbaccess/source/ui/dlg/ConnectionPage.cxx:232:            fillString(*_rSet,m_xJavaDriver.get(), DSID_JDBCDRIVERCLASS, bChangedSomething);
        dbaccess/source/ui/dlg/ConnectionPage.cxx:235:        fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething);
        dbaccess/source/ui/dlg/ConnectionPageSetup.cxx:134:        fillString(*_rSet,m_xConnectionURL.get(), DSID_CONNECTURL, bChangedSomething);
        dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:144:        fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN, bChangedSomething);
        dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:416:        fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething);
        dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:417:        fillString(*_rSet,m_xETHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething);
        dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:418:        fillString(*_rSet,m_xETDatabasename.get(),DSID_DATABASENAME,bChangedSomething);
        dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx:531:        fillString(*_rSet,m_xETDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething);
        dbaccess/source/ui/dlg/admincontrols.cxx:117:        OGenericAdministrationPage::fillString( *_rSet, m_xHostName.get(),     DSID_CONN_HOSTNAME,    bChangedSomething );
        dbaccess/source/ui/dlg/admincontrols.cxx:118:        OGenericAdministrationPage::fillString( *_rSet, m_xDatabaseName.get(), DSID_DATABASENAME,     bChangedSomething );
        dbaccess/source/ui/dlg/admincontrols.cxx:121:        OGenericAdministrationPage::fillString( *_rSet, m_xSocket.get(),       DSID_CONN_SOCKET,      bChangedSomething );
        dbaccess/source/ui/dlg/admincontrols.cxx:123:        OGenericAdministrationPage::fillString( *_rSet, m_xNamedPipe.get(),    DSID_NAMED_PIPE,       bChangedSomething );
        dbaccess/source/ui/dlg/adminpages.cxx:219:    void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const weld::Entry* pEdit, sal_uInt16 _nID, bool& _bChangedSomething)
        dbaccess/source/ui/dlg/adminpages.cxx:227:    void OGenericAdministrationPage::fillString(SfxItemSet& _rSet, const dbaui::OConnectionURLEdit* pEdit, sal_uInt16 _nID, bool& _bChangedSomething)
        dbaccess/source/ui/dlg/adminpages.hxx:218:        static void fillString(SfxItemSet& _rSet,const weld::Entry* pEdit,sal_uInt16 _nID, bool& _bChangedSomething);
        dbaccess/source/ui/dlg/adminpages.hxx:219:        static void fillString(SfxItemSet& _rSet,const dbaui::OConnectionURLEdit* pEdit,sal_uInt16 _nID, bool& _bChangedSomething);
        dbaccess/source/ui/dlg/advancedsettings.cxx:351:        fillString( *_rSet, m_xAutoIncrement.get(), DSID_AUTOINCREMENTVALUE, bChangedSomething );
        dbaccess/source/ui/dlg/advancedsettings.cxx:353:        fillString( *_rSet, m_xAutoRetrieving.get(), DSID_AUTORETRIEVEVALUE, bChangedSomething );
        dbaccess/source/ui/dlg/detailpages.cxx:146:            fillString(*_rSet,m_xOptions.get(),DSID_ADDITIONALOPTIONS,bChangedSomething);
        dbaccess/source/ui/dlg/detailpages.cxx:303:        fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething);
        dbaccess/source/ui/dlg/detailpages.cxx:406:            fillString(*_rSet,m_xEDDriverClass.get(),DSID_JDBCDRIVERCLASS,bChangedSomething);
        dbaccess/source/ui/dlg/detailpages.cxx:407:        fillString(*_rSet,m_xEDHostname.get(),DSID_CONN_HOSTNAME,bChangedSomething);
        dbaccess/source/ui/dlg/detailpages.cxx:408:        fillString(*_rSet,m_xEDSocket.get(),DSID_CONN_SOCKET,bChangedSomething);
        dbaccess/source/ui/dlg/detailpages.cxx:608:        fillString(*_rSet,m_xETBaseDN.get(),DSID_CONN_LDAP_BASEDN,bChangedSomething);
        
        So I don't think that trimming these may be harmful.
        Now we could also add a boolean fillString to indicated if a trim is needed
        but does it worth it?
        
        Change-Id: I6fa841a0c062d4b81a09549cbe865fd627d070cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128029
        Tested-by: Jenkins
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [d84c06577f3198d6c6bd05176429724897d918e6]

        wina11y: Don't use space in qualified name
        
        While 'MyClass:: MyMethod' (with a space in it) is valid in C++,
        it's unusual and may break a naive plain-text search for
        a specific class member definition.
        
        Change-Id: I8c9779865715a0b4f1a66d3e35b874f2cec19193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128016
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [9cbd17314f4e4c04dc5e912bdb2030daddcd2f75]

        wina11y: Use range-based for in AccObject::UpdateState
        
        Change-Id: I29793e63ddc040ccbae99012090e975bd80cafc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128011
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [e523b205364e59f11ae3e735c1440d61427f15d7]

        wina11y: Deduplicate 2 common lines in CMAccessible::get_accRole
        
        Change-Id: I3bd4f26861d46f6a43a4b0edda3dbf628e2da2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128010
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [fd787538797a182786ab7b1dfc041562b2e5073a]

        wina11y: Drop now unused AccObject::SetRole
        
        Change-Id: I04db43ac49d7bc6ff42157cdd0c94087c454c981
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128009
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [e60406b0873d9e73e84682248f234fca600a1a34]

        wina11y: Drop unused AccObjectWinManager::SetRole
        
        Change-Id: Ic2d470a137e4d0c907f28e24c58ba19a937a8b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128008
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [fcf4a26275d7503835f9aa23cb94938809840300]

        tdf#146306 wina11y: Retrieve accessible desc on demand
        
        Adapt 'MAccessible::get_accDescription' to directly
        retrieve the accessible description on demand via the
        corresponding XAccessible, rather than keeping
        track of it in a class member.
        
        This simplifies the handling and makes it
        unnecessary to "manually" update the description
        on 'accessibility::AccessibleEventId::DESCRIPTION_CHANGED'
        events, since the new value will
        be queried next time it is needed anyway.
        
        This also fixes the problem that a significant
        amount of time was spent generating accessible
        descriptions for all newly inserted a11y objects when
        entering values into Calc cells with the NVDA
        screen reader in use, resulting in several
        seconds of delay.
        
        Querying up-to-date values from the underlying
        UNO interfaces on demand instead of doing extra
        manual bookkeeping in the winaccessibility code
        may be possible for more a11y attributes in addition
        to the accessible description handled in this commit,
        but each one will have to be looked at separately.
        
        Change-Id: I57f4c523ca8b10afad3f9c347c8ff5e9420ad968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128006
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [e9b6eedd66257decf7ac36b71b06e91609f1e02e]

        wina11y: Use existing method to update description
        
        The accessible description and the accessibile *action*
        description are two different things.
        
        'AccObject::UpdateActionDesc' was (IMHO somewhat confusingly)
        handling both.
        Drop the handling of the accessible description from there
        and call the already existing 'AccObject::UpdateDescription'
        at the only call site of 'AccObject::UpdateActionDesc' in
        addition, which does exactly the same thing.
        
        Change-Id: I220df676f128a5db69ab4cebe7772d92f6b9b0ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128005
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Michael Weghorn  <m.weghorn@posteo.de>  [7210a9d712b156d68627b5510bd2f2404d6fd657]

        wina11y: Use separate local variable for action description
        
        Use a separate local variable for the accessible
        *action* description here, which is independent of
        the accessible description handled above.
        
        While at it, use '!OUString::isEmpty' instead of
        'OUString::getLength() > 0'.
        
        Change-Id: I146d8603ed3decde68f8ce716ac13c04b0263040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128004
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2022-01-06  Caolán McNamara  <caolanm@redhat.com>  [d99efe24213400932b97e47b131049fcbbfac612]

        Resolves: tdf#146592 "Reset" to the current document properties
        
        not those seen at the initial load of the TabPage
        
        Change-Id: Ieba4c278a0a9b7fef3030d8462cb845c27dba9b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-06  Miklos Vajna  <vmiklos@collabora.com>  [d9061f32b5d225f221e9399c5fa54996a6f7f43b]

        sw textbox: pShape -> pFormat for frame formats
        
        A frame format can be a fly or a draw frame format. Only the later is a
        shape.
        
        Also this way the parameter name in the definition matches the
        declaration, improving readability.
        
        Change-Id: I69e51bfaceba925002d23cdfb5fa6d60afa3c550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128023
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-06  Noel Grandin  <noelgrandin@gmail.com>  [1626122615828c2c1689fb3aab2d05e0bdc1b4d3]

        avoid Sequence realloc
        
        construct with the right size
        
        Change-Id: I94f0743a9c77ad374d1f0f59a1a5ef531cccfeab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-06  Noel Grandin  <noelgrandin@gmail.com>  [0b0934056b47485527442b6366d7fd3274a4601f]

        bypass SvxShape when creating rectangles in chart2
        
        Change-Id: I461449959fffa8948bf4321a6c3114505d87a149
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127997
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ea545653e17e687c9069543897975b3726dc6a2b]

        Removed executable permission on pptx file
        
        Change-Id: I6a571f12f2e194a6d72a457622505cca72bd8eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128021
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-06  Mike Kaganski  <mike.kaganski@collabora.com>  [2fd019442e14e122884fff42b88de23fa150e4df]

        Simplify osl_getModuleURLFromAddress a bit
        
        Change-Id: I71243c99d43b58329317baa250d5b60aa62db360
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128030
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [86b0753ca3a02d247b13f0a6654ae315ce3a044b]

        gbuild: skip libmerged externals for partial builds
        
        When running a full build, all externals of merged libraries are
        also added to libmerged when adding externals for the merged lib.
        
        Non-skipping for partial builds also breaks gbuildtojson, for all
        modules, which are merged and have additional libraries, tests or
        binaries, which then depend on the libmerged.
        
        This triggers for gbuildtojson, because the skipped %.exports now
        actually matter when checking the libmerged state. make then tries
        to rebuild it, but this can never work for a partial build, even
        with the full gbuild ruleset, not stripped by
        solenv/gbuild/extensions/post_GbuildToJson.mk.
        
        The totally confusing result, due to the mangled ruleset, is that
        the first externals %.exports overwrites libmerged in instdir.
        
        Change-Id: I2b72a8b543dbbd8c8f573bfe963164329bdd73e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127995
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-05  Stephan Bergmann  <sbergman@redhat.com>  [2177f48b16b8cd68c0ef4ec817ca391f28324418]

        Simplify --with-webdav
        
        ...to just be yes/no, now that curl is the only remaining implementation
        option.  (A drawback of the existing code was that it silently treated
        --with-webdav or --with-webav=neon etc. the same as --without-webdav.)
        
        Change-Id: If1478ac3bf5c49d0754d6ab89c8c04c7c51c9ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128020
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-05  Caolán McNamara  <caolanm@redhat.com>  [ae406d7acc985c56bacd7c0e0c9658170afa907d]

        upgrade to latest harfbuzz
        
        Change-Id: I29213e65ed817208a32c75279133b7e281f3cd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-05  Mike Kaganski  <mike.kaganski@collabora.com>  [9d886e80ab742de49e2fe4fe62763edb21485d4e]

        Simplify osl_getModuleURLFromAddress using GetModuleHandleExW
        
        Somehow missed that in commit 515d2579d305a6127c6c194319a58eac62437e33
            Date    Fri Apr 05 13:15:42 2019 +0300
            Replace legacy dynamically-loaded functions with statically linked ones
        
        Also drop obsolete suppressions of warning not emitted by MSVC anymore.
        
        Change-Id: If4a4c2ec76b275fb358b325652422e81e9003eb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128019
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-05  Mike Kaganski  <mike.kaganski@collabora.com>  [9b85e4e3263fe2bc75c371969256064e952d7fd4]

        Use GetModuleHandleExW instead of GetModuleHandleW
        
        ... and find directory cearching for path separator.
        Also drop obsolete code related to Windows XP and mingw.
        
        Change-Id: Ib48cfeea8a2ae01d3f8b37728ce1e8ca4aa73b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128017
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dba8853271b1ee52c294c2401a5c8d98cc52cdc3]

        Fix typos
        
        Change-Id: Ie05c44dd3b85f1fd6c592a8cf5482d5954d7a354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127971
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4c4d37d00628ced52376f1034ff58f96dc274c95]

        Fix typo
        
        Change-Id: I8663c82eac06305a2ce7be131c240eacd2e2de9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127281
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-05  Stephan Bergmann  <sbergman@redhat.com>  [3773dd5bb42f78300446b8c6c0b5c58b8bbb3728]

        Missing RTTI for UBSan
        
        ...which caused e.g. CppunitTest_chart2_export to emit lots of
        
        > warn:sal.osl:3446618:3446618:sal/osl/unx/module.cxx:155: dlopen(.../instdir/program/libchartcorelo.so, 257): .../instdir/program/libchartcorelo.so: undefined symbol: _ZTI12SvxShapeRect
        
        Change-Id: I26b0ad58ad6fa577e0e8299dde80bcac444f9504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128012
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-05  Noel Grandin  <noelgrandin@gmail.com>  [a6e7b7c9044c689b7824cf97f4ff79655a950802]

        tdf#146499 Crash to desktop when activating presentation mode
        
        mutex deadlock, regression from
            commit 62efb188668a3296591dcfa3658185e2f982e356
            use comphelper::WeakComponentImplHelper in SlideShowView
        
        Change-Id: I1822d4beffaa44be7f789db4bd0f5a25d1896396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127998
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [58787bd05d83cc521bfb0d7695416b78f46a9e01]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1fbed0448d0d1d77532fe3abb5be05fc13d93bdb
          - Improve paragraph spacing in text
            
            Add more space below paragraphs.
            
            Change-Id: Ie282883229bcc1471aed6c35ef57d1ec909996b5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128013
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-01-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6891bcfb7b3330bfb41f252635fc25b51196253a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 53e0c535c9892e7d586d5ae5b3eada2bd07f9550
          - Remove unused css rule
            
            Change-Id: Id49a843abd96ba1719c706b36d20d27766698898
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128018
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-01-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d2b491adb9375f6ef0a62c7b38b618b735baeaa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d2e185e13b0afe7c007144fc05ae68357d7c470
          - tdf#142380 (part) Use variables in css
            
            Change-Id: I14f9e8af88cb7eb1fbf8f6647d2ad891018edbff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128014
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2022-01-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [a6fae99466cd52143a52a98b0ac89588f679f1a1]

        Disable epoxy test with --disable-gui
        
        Instead of always testing for DISABLE_GUI, just disable the epoxy
        test and handle !ENABLE_EPOXY in RepositoryExternal.mk.
        
        Change-Id: I38213ffa77353bc93f32caa1b4164c5fa88170ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127999
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-05  Stephan Bergmann  <sbergman@redhat.com>  [df9cbdd22658131b881e6527467c8e2a2dd36c70]

        Drop remnants of --with-webdav=neon
        
        ...that were left behind by 023ebf17898db4bca63129f079fd90b5cf76c1a9 "ucb:
        remove --with-webdav=neon"
        
        Change-Id: I617ca74d1c4b46d8f0b9dac317b5972bfb911813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127986
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-05  Mike Kaganski  <mike.kaganski@collabora.com>  [eb31b387ac4b679e4da851b8b17e9b4e35722c04]

        Use GetModuleHandleExW instead of GetModuleHandleW
        
        ... following commit d75bf2c7703d6a741f04e4a3fc5a6180428f53b2
            Date:	Wed Jan 05 13:20:09 2022 +0300
            tdf#146554: use GetModuleHandleExW instead of GetModuleHandleW
        
        Change-Id: I37c989de37c28123ca692145a429b6ba03202f99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128002
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-05  Dhiraj Holden  <dhiraj.holden@gmail.com>  [207d202ed2f1f44e5b62157b5a92ee5e8cc2c3e5]

        tdf#130076 Fixed flip not working properly from file
        
        Added code to check whether the angles need to be changed when the
        section is flipped.
        
        Change-Id: I9cc3e16db74c6e9616385bc39849e4c73686b56c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127853
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2022-01-05  Miklos Vajna  <vmiklos@collabora.com>  [e242c0fb26c2bf5662b10fc6c8195deeda5b1097]

        svx: mark RTTI symbols of Svx3DSceneObject as public
        
        online.git's unit-calc under sanitizers fails without this, but also
        seen at <https://ci.libreoffice.org/job/lo_ubsan/2254/console>:
        
        > warn:sal.osl:30805:30805:sal/osl/unx/module.cxx:155: dlopen(/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libchartcorelo.so, 257): /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libchartcorelo.so: undefined symbol: _ZTI16Svx3DSceneObject
        
        Change-Id: Ibebb839751c1048ab44110dd70e2140f8d5dc6b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127996
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-05  alt  <alexander.solodukhin1@gmail.com>  [a409739efe4507e23926d1862215c128904fda88]

        Fixed tdf#143142 when unable to scroll table column width properties.
        
        Fixed the issue when unable to scroll table column width properties on some occasions.
        
        Change-Id: Id0a89d248d2a4effc0cb08ca0dc60aa23f66d70e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127938
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2022-01-05  Mike Kaganski  <mike.kaganski@collabora.com>  [d75bf2c7703d6a741f04e4a3fc5a6180428f53b2]

        tdf#146554: use GetModuleHandleExW instead of GetModuleHandleW
        
        This allows to avoid use of module name when obtaining current module
        handle, which needs to be synchronized and thus is error-prone.
        
        Change-Id: I2f0e0af7f616c3582b0a3271cf9e06420a9dfc8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127993
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-05  Miklos Vajna  <vmiklos@collabora.com>  [9fb45044d93ffcaa63cfe3275c8fb5feb8c00504]

        xmlsecurity nss: log what XML DOM node is given to libxmlsec
        
        We have two environments where the signature and the stream bytes are
        the same, still in one case the signature verification succeeds and in
        the other case the hash doesn't match.
        
        Log the signature as parsed into a DOM node (recursively), just case
        something goes wrong during extracting a single signature from the
        signatures list XML.
        
        Change-Id: I54af71fdeb63d8ef44342f106746f938fa51f29a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127991
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-05  Caolán McNamara  <caolanm@redhat.com>  [1cb5b519a06709e22b99bec75d7bf95020442205]

        ofz#42829 Timeout
        
        Change-Id: I7c170fca4601fb0cee8acb28b65ce8bd59595911
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [78dae8b20b85686d1a642415195d2e10fbb2dc1f]

        Update gpgme to 1.16.0
        
        * remove GPGME_CAN_EXPORT_MINIMAL_KEY, upstream now has support for
          key export flags in c++ wrapper (gpgmepp >= 1.14)
        * therefore, external/gpgmepp/add-minimal-keyexport.patch now fully
          obsolete, tweaked xmlsecurity code to use upstream function
        * bits of external/gpgmepp/find-libgpg-error-libassuan.patch are
          upstream now (configure and makefile pieces, though we keep
          configure.ac changes for the while - to not pick up system versions
          too easily)
        * external/gpgmepp/gpgme.git-fe2892618c20cd40c342cce26ffb6ac4644fd3c3.patch.1
          was from upstream anyway, removed
        
        Change-Id: I991c20c0eeff0f9135e97c991afcb905be55a959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127665
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [568a5bba2a30ab588b52677106bf209d4c0df758]

        Update libassuan to 2.5.5
        
        Change-Id: Icd1034f4c6b43605f5d43fe28f7e0d191311daf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127664
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [7d50d74d0a10b4811b82f66dc5ac5a696c2974c7]

        Update libgpg-error to 1.43
        
        Change-Id: Iecd4a131f9c5b43bb03c5f9c4b6c7efe36e443aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127663
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-05  Justin Luth  <justin_luth@sil.org>  [44c37c4af2d23d1469cdeeb56f2f5a2bef493986]

        tdf#146489 writerfilter: ensure only character properties
        
        This is another RTF regression found against LO 6.0's
        commit fdfdea4d5af51a68f2d497cc5c3359d74c385fd5
           tdf#82173 writerfilter: apply char properties to footnote
        
        The original commit in LO 6.0 intended that only character properties
        were used. A follow-up commit for RTF tried to ensure that
        these would be on the top of the stack.
        
        However, in this case, it seems like somehow the table is
        getting involved in putting the paragraph context
        on the top. (Actually, there is no
        GetTopContextOfType(CONTEXT_CHARACTER) at all.)
        
        In any case, aFontProperties should only contain
        character properties, so ensure that.
        
        The unit test shows that there is still some kind
        of import problem, because the footnote marker
        should be a large, red character, but it is just
        normal text. See tdf#108949.
        
        Change-Id: I1ea7256891b198046f79f0d3a36e43d6c2ae3383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127943
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2022-01-05  Stephan Bergmann  <sbergman@redhat.com>  [e1b51099ac306118ee88bf3b7c94621df2564133]

        Explicitly build external/freetype --without-png
        
        ...instead of having its configure.ac determine whether to support png based on
        it being installed on the system, but which then might cause a Linux
        --without-system-freetype build to fail to link Library_pdfium with
        
        > workdir/UnpackedTarball/freetype/src/sfnt/pngshim.c:199: error: undefined reference to 'png_get_error_ptr'
        
        etc.
        
        Change-Id: Idf47ba5252b8f4d7f2e295f7adf6b761dbee4d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127985
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-05  Sarper Akdemir  <sarper.akdemir@collabora.com>  [8bdd134bef3baca2ebd878163af4e55e5f898efe]

        tdf#146534 pptx import: make Z rotation work with rotation transform
        
        Expands previous idea from a9c5c0d814a266096483572b84c72875ef8efd77
        (tdf#133037 OOXML shape import: camera rotation along Z)
        and uses it also for shapes that have a true bUseRotationTransform flag
        
        Also fixes same Z rotation exporting twice from InteropGrabBag to
        both spPr and textBody causing text overrotating on roundtrip.
        
        Change-Id: If0f192af029ca86b932a63613f961be1f5003c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127880
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-05  Miklos Vajna  <vmiklos@collabora.com>  [678af723a6c0c26f20607532eec4e8a8208234bc]

        CppunitTest_sw_rtfexport5: rework to avoid mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Id694d789fdf68dbce4e323b74455798f48be53c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127972
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-05  Jim Raykowski  <raykowj@gmail.com>  [1aa49bb9cf2b960312bf1e65ea1eee2521873a16]

        tdf#134960 tdf#146419 use sorted array to list hyperlinks in Navigator
        
        in document order
        
        The current approach of using layout position to list hyperlinks in
        document order works for single-page view but not for multiple-page or
        book view. This patch makes the list order layout independent by using
        SwPositions to sort the hyperlinks in document order.
        
        Change-Id: Ie09ac362aa0e8db813430de50c7f06f3072179f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127856
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1fe79827ea87580f8fba8ef3b1a3e96f10fd5be9]

        Fix typo
        
        Change-Id: I1fa74a81f30e8e20aea60f5954d7a6a37080bcab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127977
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [22f52db0be81ceec2aa7a61f7092b54f36e2d00c]

        vcl: migrate AddGradientActions() from OutputDevice to Gradient
        
        Change-Id: I815fb3ce366c93b81f60d19eeed906dc7288708a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127030
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [88d8c9af7140ec25dfbcd9323b870a2da7b6f7e0]

        sc: fix crash with document properties dialog
        
        "ImagePreferredDPI" property was added for impress and writer,
        but it was not handled in calc, so it document properties dialog
        crashed (exception because of a non existent property).
        
        Change-Id: I9eb3f6aa7cf6d8ab48930b3071b993e073117688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127942
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [43befdeda4a66a71bd3c204a79f06cb96c7b0145]

        vcl: cleanup SvpSalGraphics includes
        
        Change-Id: I16619e55acfff7510803aff7ebf27c8d892a0d75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127983
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c138cfa104ec0cd7f6e97885553b08f98d9f5848]

        vcl: move getBitmap to SvpGraphicsBackend
        
        Change-Id: Ic72e1fdd3994a5bffef40bb70b713f10c1112903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127982
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [507ca0eb16707917eab3608674243ed0eeacda72]

        vcl: move drawAlphaBitmap to SvpGraphicsBackend
        
        Change-Id: I182d775318a9b43a5955a5868e78a4b09c4a74c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127981
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [581bed6233f31ec5eafb1231fcb93bc3f583f9cb]

        vcl: move drawBitmap, drawMask functions to SvpGraphicsBackend
        
        Also fix the QTSvpGraphics that uses a special drawBitmap (renamed
        to drawBitmapBuffer) call and moved in also to SvpGraphicsBackend.
        
        Change-Id: Ic50630ba23e35a62ea3d5aaa0955a7666f2bca68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127980
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [86fdd581a832c7476d7556f3f4fb7d83f5de4d8b]

        vcl: move tryToUse{Source,Mask}Buffer to BitmapHelper
        
        Change-Id: I9352aec388db56596fef3f5f323244b1df26cdcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127979
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5a7cdbfbd3cbf3ea92c38e78a3b159fdffed7740]

        vcl: move SystemDependentData classes to BitmapHelper
        
        SystemDependentData_BitmapHelper, SystemDependentData_MaskHelper
        to BitmapHelper.{hxx,cxx} files.
        
        Change-Id: I23f3b4badd8e262c442e5c6387876b078f22fd73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127926
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fed7cc51c9bea947478a2451d545cd9fa53ebd1d]

        vcl: move estimateUsageInBytesForSurfaceHelper to CairoCommon
        
        Change-Id: I3c4140f99db4867109b04416317b96b268d9d8c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127925
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-05  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [94bef9ce68b35e1d6d2c7ce4ffae2c6b301686ea]

        vcl: move BitmapHelper and MaskHelper into own file
        
        Change-Id: If6f2a489be7cb51f62c55a2d4c804fcc741579bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127924
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [9b4d5214557ed264e3d785507712878559803e94]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2e3f6779c041ea475ba5127dbefefbd2f6a9c6fc
          - tdf#135137 Create help for "Rename object" dialog
            
            With this patch, if the user right-clicks an object in the Navigator, chooses Rename and click the Help button, a proper help page will be shown.
            
            Change-Id: I5ba3c37519858de27c1fa526681fa00524c9e66e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127949
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [6fe0b829df1126caffe6fe465b4cadce09acf4b7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 573cb7bfe3af24d830f02fff227166e2ea292c14
          - Related tdf#130442 Redirect to Font Color section of the help page
            
            When the user clicks "Font Color" in the "Formatting Bar" help page, it should land in the "Font Color" section of the "Font Effects" page.
            
            Change-Id: I011a3a19d9e7eb10e7e84e1bfbbc834ba494ae24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127951
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a4ff505f9ca4ec56441980818a01bc45fbe2ac36]

        Fix typos
        
        Change-Id: Ia2629c23ed6d0da0a4863daee687671a4436d456
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126615
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-04  Julien Nabet  <serval2412@yahoo.fr>  [e43573aae0fa07d170fb042b7184156c851c1f77]

        tdf#146432: fix crash with REGEXP_REPLACE() executed in query editor to MariaDB
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=177292
        
        Noticing:
        warn:legacy.osl:7697:7697:connectivity/source/drivers/mysqlc/mysqlc_general.cxx:188: mysqlToOOOType: unhandled case, falling back to VARCHAR
        I found REGEXP_REPLACE returned a MYSQL_TYPE_LONG_BLOB and some locations should be taught about it.
        
        Also, let's also deal with MYSQL_TYPE_TINY_BLOB and MYSQL_TYPE_MEDIUM_BLOB
        
        Change-Id: Ib7fd6ef747ce1b1851c788d2bb5a1d4ec673aee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127919
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2022-01-04  Miklos Vajna  <vmiklos@collabora.com>  [77d2bbaa18e0be5347d7bd7167b245264789e0a4]

        sc export chart as graphic: handle PDF
        
        The context menu for Calc charts would call into
        GraphicFilter::ExportGraphic(), which has explicit code for e.g. SVG,
        but not for PDF. The graphic exporter to PDF is only meant to work with
        images backed with PDF data, not with all shapes.
        
        Fix the problem by explicitly handling PDF in
        GraphicHelper::SaveShapeAsGraphic() in svx/, and invoking the normal PDF
        export in that case. Continue to fall back to XGraphicExportFilter for
        other formats.
        
        This requires passing down the current document from sc/.
        
        Change-Id: Ia5f78bffa1d26989bb0ad3ed265b922e609f076f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127969
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8e78d0f335240a5ca42d53ab2f1f4e0c652ade88]

        Removed break; never reached
        
        Change-Id: I027c967020821e93fecab8df0f23c5e7b5664734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127008
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2022-01-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e951937950e68be7b93093879e943211ae7f1601]

        speed up setting properties in chart2
        
        can skip the intermediate map
        
        Change-Id: I53b6e7f88c7ff1c4dd84b6e7f4f4ff8b066166b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127967
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Tor Lillqvist  <tml@collabora.com>  [6bfeb2290c585e0e5fe982dde6ac57e4afca2e2f]

        tdf#146264: Add unit test
        
        Make sure the text is not duplicated in the output.
        
        Change-Id: I1600d18f0921d2ab2cb67898bc02b68f0f9b36c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127935
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-04  Miklos Vajna  <vmiklos@collabora.com>  [18444c2822e6561aa302f28f8166042b8dad0fe1]

        Revert "use comphelper::WeakComponentImplHelper in AccessibleSlideSorterView"
        
        This reverts commit 2d541dedde4ec516eacd7669bdc3ed8fb6fc2548. It
        switched to a non-recursive mutex in AccessibleSlideSorterView, which
        now deadlocks regularly when opening Impress documents:
        
        	#0  0x00007ffff65b5de3 in __lll_lock_wait () at /lib64/libpthread.so.0
        	#1  0x00007ffff65ae301 in pthread_mutex_lock () at /lib64/libpthread.so.0
        	#2  0x00007fffcdac12ed in __gthread_mutex_lock(__gthread_mutex_t*) (__mutex=0x5646c40) at /usr/include/c++/7/x86_64-suse-linux/bits/gthr-default.h:748
        	#3  0x00007fffcdac2f40 in std::mutex::lock() (this=0x5646c40) at /usr/include/c++/7/bits/std_mutex.h:103
        	#4  0x00007fffcdac3fcf in std::unique_lock<std::mutex>::lock() (this=0x7fffffffb980) at /usr/include/c++/7/bits/std_mutex.h:267
        	#5  0x00007fffcdac3c86 in std::unique_lock<std::mutex>::unique_lock(std::mutex&) (this=0x7fffffffb980, __m=...) at /usr/include/c++/7/bits/std_mutex.h:197
        	#6  0x00007fffcdac514b in accessibility::AccessibleSlideSorterView::getAccessibleChildCount() (this=0x5646c10) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:200
        	#7  0x00007fffdce577c3 in AtkListener::updateChildList(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&) (this=0x5647130, pContext=uno::Reference to (class accessibility::AccessibleSlideSorterView *) 0x5646c88) at vcl/unx/gtk3/a11y/atklistener.cxx:149
        	#8  0x00007fffdce579e0 in AtkListener::handleChildAdded(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&, com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&) (this=0x5647130, rxParent=uno::Reference to (class accessibility::AccessibleSlideSorterView *) 0x5646c88, rxAccessible=uno::Reference to (class accessibility::AccessibleSlideSorterObject *) 0x42d3698) at vcl/unx/gtk3/a11y/atklistener.cxx:178
        	#9  0x00007fffdce5806e in AtkListener::notifyEvent(com::sun::star::accessibility::AccessibleEventObject const&) (this=0x5647130, aEvent=...) at vcl/unx/gtk3/a11y/atklistener.cxx:441
        	#10 0x00007ffff4fef0d5 in comphelper::AccessibleEventNotifier::addEvent(unsigned int, com::sun::star::accessibility::AccessibleEventObject const&) (_nClient=44, _rEvent=...) at comphelper/source/misc/accessibleeventnotifier.cxx:262
        	#11 0x00007fffcdac4df2 in accessibility::AccessibleSlideSorterView::FireAccessibleEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) (this=0x5646c10, nEventId=7, rOldValue=uno::Any(void), rNewValue=uno::Any("com.sun.star.accessibility.XAccessible": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x42d3698}, <No data fields>})) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:148
        	#12 0x00007fffcdac7bf0 in accessibility::AccessibleSlideSorterView::Implementation::GetAccessibleChild(int) (this=0x5646ce0, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:746
        	#13 0x00007fffcdac79ca in accessibility::AccessibleSlideSorterView::Implementation::GetVisibleChild(int) (this=0x5646ce0, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:725
        	#14 0x00007fffcdac529d in accessibility::AccessibleSlideSorterView::getAccessibleChild(int) (this=0x5646c10, nIndex=1) at sd/source/ui/accessibility/AccessibleSlideSorterView.cxx:213
        
        The problem is that both getAccessibleChild() and
        getAccessibleChildCount() take a lock, so this requires a resursive
        mutex for now.
        
        Change-Id: I32205d19451d86e112922e3194661cce2406f70a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127946
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [746127cf803070c5a695a7cb30a2ecdb5a777e75]

        use deque in SdrObjList
        
        which has much better performance for
        (a) inserting stuff at the front
        (b) appending large numbers of items
        
        something that happens when constructing large charts - shaves 5% off
        the load time for large sample bar chart
        
        Change-Id: I3ebccbfdc75e4df3ec88eb2dde46acfe0ab0ae7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127940
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Michael Meeks  <michael.meeks@collabora.com>  [7ba99b8d6da07c2133c644de4d1a3613a9fa5a68]

        lokit: double check for disposed windows & fix leak.
        
        it seems we can get windows disposed before we get to the emission.
        
        <segv>
        vcl::Window::IsTracking() const vcl/source/window/window2.cxx:341
        (anonymous namespace)::LOKPostAsyncEvent(void*, void*) sfx2/source/view/lokhelper.cxx:725
        LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double) include/rtl/ref.hxx:112
        SwXTextDocument::postMouseEvent(int, int, int, int, int, int) sw/source/uibase/uno/unotxdoc.cxx:3561
        
        Change-Id: I93aea931dad1e7f43d3d610568424c53d2b22fbc
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127907

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eee703970581545b56f3b2faa5b5911923ec28ea]

        vcl: move SurfaceHelper class to CairoCommon
        
        Intermediate step beore moving bitmap related members.
        
        Change-Id: Icf2d4cfb787dfb029f299cba4b4ffabae563bf6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127923
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [3e9786b4dcbf342aab469940710e8a01be62d694]

        drop the OverwriteMap stuff in chart2
        
        as a step towards setting properties directly on SdrObject
        
        Change-Id: Ia05487408eeb97598742e7ceb94834095e7dff1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127936
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [971b029308c527737d4085559e91fa8495b93d9c]

        vcl: move Toggle1BitTransparency to CairoCommon
        
        Intermediate step beore moving bitmap related members.
        
        Change-Id: Iaa30fd53d3b14c08fd502b33d370950569994139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127922
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Tor Lillqvist  <tml@collabora.com>  [31808345ffd97dfe9d542eae17fadb98148b29c6]

        Drop also commented-out obfuscated SAL_DEBUG calls
        
        Change-Id: I7bc8ee2e5e989e41fcc0b6f96c5b2b8f151cdd3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127937
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [348afc5b8ec8c4d8e215896137f32c636c1bc36e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 082a62657dc9e89dc54c3299e47dd1f76c4c9de1
          - tdf#137887 Fix help links for Position and Size dialog
            
            Change-Id: I9d7f1a90feabf8ec417e0b071a53df82995d126e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127781
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-04  Miklos Vajna  <vmiklos@collabora.com>  [b737cf89a3e555ea81ff86fc0dd96d2a76a4dc4f]

        xmlsecurity: log the signature we read from the ZIP package
        
        We can already see if a signature verification fails and what is the
        content of the ZIP streams we hash.
        
        Show what is the expected hash as well.
        
        Change-Id: Ibc67b7de0e8d03e06da1b86b6e8a7b2b2e613882
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127934
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-04  Kiyotaka Nishibori  <ml.nishibori.kiyotaka@gmail.com>  [5b5ba7f407637023cfe50267296312bf5e8cf538]

        changed CuiResId into SvxResId.
        
        though some translation entries for tooltip for border preset images were in
        svx.mo, cui/source/tabpages/border.cxx referred the entries to cui.mo with
        CuiResId route, and the translations was not gotten.
        
        this commit is alternative change.
        
        Change-Id: Ica7a7ea71f7afe7044104b9d953f1b3edf9c2503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127852
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [55dcb060ea5feef0478f7abcaa4da9cbe69bd440]

        Drop all commented SAL_DEBUG calls
        
        Change-Id: I3be7153d27b83766303519e73d1a355ba327871a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127929
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [5de44f16b68977058386a60ca468de3efa780a25]

        osl::Mutex->std::mutex in StringResourceImpl
        
        Change-Id: I6a724976f96df43c666a783634fcda0eb4ff789c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127918
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Mike Kaganski  <mike.kaganski@collabora.com>  [1be170d0629cf761f0ee4173007a3c021966546e]

        tdf#146551: improve native checkmark and bullet drawing on Windows
        
        This takes marks' borders into account, and removes some hacks used
        previously in place of those.
        
        It introduces one new hack - adjusting only rectangle's top in
        ImplPaintCheckBackground - to workaround one pixel less height of
        selected images background on Windows, caused by the current method
        of drawing that background, abusing toolbar button for that on all
        platforms. Ideally, drawing it (or the whole image) should be
        implemented using OutputDevice::DrawNativeControl with dedicated
        ControlPart value, which would enable use of ImplDrawTheme with
        MCB_BITMAP menu background state on Windows.
        
        I have tested on Windows 10 (using both default and Skia drawing,
        with normal and scaled UI), and on Ubuntu with gtk3, x11, and kf5
        plugins (since common code is affected); it seems to give expected
        results on all of them.
        
        Change-Id: I677c3af30fedc608dbc6b391d5dbbbdb141da0d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127909
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-04  Miklos Vajna  <vmiklos@collabora.com>  [71141a78f47f9a70aae986959ac80f19ce0816fa]

        sw: document SwDrawTextShell
        
        It's only for shape text, not everything editeng-based (e.g. comment
        text is not handled here).
        
        Change-Id: If76bf16c16e6cbf6f9f4c31f234e2d10f6bc9dd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127911
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-04  Mike Kaganski  <mike.kaganski@collabora.com>  [745dcdb1e7e4c070a95db7a1c52840bd65eefa63]

        Drop MSVC special-casing for OWeakObject ctor
        
        It was introduced in commit 0c38ca4412531adafdb9cbac9dfa7f6f8e0d9882
            author	Daniel Boelzle <dbo@openoffice.org>
            date	Mon Nov 18 08:59:15 2002 +0000
            #104560# outlining of msvc mapfile symbols
        
        cppuhelper/source/msvc_win32_intel.map was dropped in commit
        b222aa8fff63c803781703e72366ca203f3e6a76
            author	Matúš Kukan <matus.kukan@gmail.com>
            date	Tue Aug 23 15:03:09 2011 +0200
            cppuhelper: convert to gbuild
        
        The symbol '??0OWeakObject@cppu@@QEAA@XZ' is still exported from
        cppuhelper3MSC.dll (checked using dumpbin, that number and names of
        exported symbols are the same), thanks to the CPPUHELPER_DLLPUBLIC
        macro at the class, that expands to __declspec(dllexport) [1], [2].
        Hence, this patch is expected to not cause an ABI change.
        
        [1] https://docs.microsoft.com/en-us/cpp/cpp/dllexport-dllimport
        [2] https://docs.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using-declspec-dllexport
        
        Change-Id: I895c350970f0e4e0adc1ba90f60925f8d4ba3941
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127471
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-04  Jim Raykowski  <raykowj@gmail.com>  [492a64a694679bbf0fad2b7ef2a5ca0941f7eed7]

        Outline folding: Check frame area is valid before using pointer to
        
        saved outline frame
        
        It seems when a frame is removed it is not immediately destroyed, so a
        pointer to the removed frame may not be a null pointer. This patch
        checks for valid frame area definition before using the save outline
        frame pointer with intention to fix an intermittent crash occurrence
        when an outline paragraph is removed.
        
        Change-Id: I4f9b55acc6aeb83553a3f26c2701159c2ba439a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127717
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-04  Jim Raykowski  <raykowj@gmail.com>  [c29909d976b79aced58a682f9957eed9c47a1590]

        tdf#134960 SwNavigator: Improve table content member list ordering
        
        by sorting by table node index in the document model
        
        This has advantage over sorting by frame layout top position because it
        always shows the tables in the order they appear from start to end in
        the document independent of single-view, muliple-page, or book view.
        
        Change-Id: I9103c32bbb32afd44e0528b1c7744812075b2339
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127828
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [146ea5360e7ce60693a1c80f1774856520b83cd4]

        osl::Mutex->std::mutex in FastSaxParserImpl
        
        Change-Id: I3bb067a0aafe8d7ca1171ab7119acbf94323725c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127915
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [bc613dc5dba6a9fc2ad2bdb3fbd160ba7615788f]

        osl::Mutex->std::mutex in FastSaxParserImpl
        
        Change-Id: I5f93c3d1373f8d5a95d8069b1f8381c45e11a875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [300308480c0d4d660a2899a26c08275b87c2c303]

        osl::Mutex->std::mutex in ScDocument
        
        Change-Id: I163b7e6b7403f9f489b4965861241280cfc37e02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127917
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Noel Grandin  <noelgrandin@gmail.com>  [f3d795aca9aecb0911771c26fc41bb46a2039b22]

        osl::Mutex->std::mutex in SfxEvents_Impl
        
        Change-Id: If154764b5bd9917b1d41b885dc1f4da6812607d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127903
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a2eb140692f2671c9b01c2a691ce73575e409a71]

        vcl: move FastConvert24BitRgbTo32BitCairo to CairoCommon
        
        Intermediate step beore moving bitmap related members.
        
        Change-Id: Ic0adff8ba8fadd0687ec903460e0caf7507e99b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127846
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5b185397198171bf8adaa99439931d12f42eff51]

        vcl: move createCairoSurface to CairoCommon
        
        Intermediate step beore moving bitmap related members.
        
        Change-Id: Ia3321ddd1ca3adb11e2b4610c3fb6b0be5ee6515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127845
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [96b62c331c5c780100de7a5b474af259c8fbb916]

        vcl: drawAlphaRect to SvpGraphicsBackend
        
        Change-Id: I44f388b6578d4f9e7d0e5b75e17fab534574da1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127844
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [dd8ab22bd615bba1a5016f3b418157900bed921c]

        vcl: move empty blendBitmap, hasFastDraw,.. to SvpGraphicsBackend
        
        Moves blendBitmap, blendAlphaBitmap, hasFastDrawTransformedBitmap,
        supportsOperation to the SvpGraphicsBackend. Most these are empty
        stub implementations that aren't supported by the backend. The
        exception is supportsOperation, which already had been implemented
        but not removed from svpgdi.*xx files.
        
        Change-Id: I240a803d9a8614f1c4ed763a8fc34296202045fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127843
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [52c903c6a48d62d6ed7841ba2d1021300c8189b3]

        vcl: copyArea and copyBits to SvpGraphicsBackend
        
        Also move the used (sub)functions to the CarioCommon:
        copyBitsCairo, copySource, copyWithOperator, renderSource and
        renderWithOperator. Also use these functions in some calls
        needed by drawBitmap & co.
        
        Change-Id: I51395953545827951b6f255a9833e828aec7ea60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127842
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9cc3672a4d7e9c9a647d388dba493bbb28d96da2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 816284668c5fece9eaa275fb94899e8d57e2e502
          - tdf#94537 OPT_* functions help ID's
            
            + Added reference to not-ODFF
            + Changed suggested help ID's to match If275d804fc81b535c422a29ba594eb88ce5e70c0
            
            Change-Id: I81664d85d8b589db86a51cecc759580a8086e336
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127897
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [13c6497512c3784507ea5d210e340b9f2605630a]

        Split xmlsecurity components based on the config
        
        One non-obvious hunk is the dependency of GPG based on NSS. While
        it doesn't need NSS per-se, the signature validation code uses
        NSS functions.
        
        This is mainly an improvement / has the same origin then commit
        1c6382b2564fbf19f8ee99e11021dff2ce19ed6f ("xmlsec: handle missing
        EqualDistinguishedNames").
        
        Change-Id: I12416139e1e391822d878c61b4ed06f3a409c334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127913
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [9f33f046f0d0d491dec305c8e7efa2ccadb64bff]

        lngconvex is just a build-tool for Windows
        
        Change-Id: I0395b5d14babe14301bd89f79f87eaa02c0ab7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127912
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [df37e6e98053d2f4a9f179c21a276c56dc3a90d9]

        Drop / merge some Haiku special build cases
        
        Just don't test gtk3, so it's also not enabled. This way we can
        also rename the kde install module to haiku on demand.
        
        The kf5be1 is kept kde-only; no idea if that is intentional.
        
        Change-Id: Id93b15fc6057a50da59efd655e1fc7d5f416c6de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127894
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4ab7735fb4c88e54b42a94678b346ab501307db7]

        tdf#129115 Calc functions OPT_* have no Help id's
        
        Change-Id: If275d804fc81b535c422a29ba594eb88ce5e70c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127896
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [20b41d29f1b66a73179e66413123d7a6752d16ef]

        osl::Mutex->std::mutex in SfxPrintHelper
        
        Change-Id: I8a88af7e177f6737e683d398531c914d1766266c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127902
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [7d87312ab6b39c3c03e93d305a1e6d7f0b78f9a7]

        osl::Mutex->std::mutex in SfxStatusDispatcher
        
        Change-Id: Icfd23cb898da6d2fc6de9f5e57c906044b9a28de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127900
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Caolán McNamara  <caolanm@redhat.com>  [3bb2cec6f9b81724f5a5e98065122da1f502e6ff]

        cid#1496842 silence Uncaught exception
        
        and
        
        cid#1496843 Uncaught exception
        
        Change-Id: I39b972b5573a5d0093e13206508ddd0088cb1146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [c87c58feb2e4be996ae28a6bc393fc86cde18598]

        osl::Mutex->std::mutex in ImplIntrospectionAccess
        
        Change-Id: I311762ccaac48161c8ce38f8ce081bf01e27ab09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [527e33784ab35c57e997024f6322aebd909bcf59]

        osl::Mutex->std::mutex in SfxApplication::GetOrCreate
        
        Change-Id: Ieb44d6e342dda2d8aa6302f126ed0eb3fec8bf95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127901
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Olivier R  <olivier.dev@grammalecte.net>  [71ea9a7219e4c7db442901bc159b2081914d2b9b]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 3fc3d99f071693dd40a78ba1f729ef47dc189692
          - Update French hyphenation rules
            
            Change-Id: Iece44334bc101a97f6297d13b24b2fc764ffc7f5
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/127910
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2022-01-03  Tor Lillqvist  <tml@collabora.com>  [11d2a2f5d260bb27d0e67f90579ca761cb2250ea]

        tdf#146264: Add a somewhat questionable hack to fix the issue
        
        Seems to work but probably has unintended side-effects.
        
        Change-Id: I33c6c78757d84fbb59176788a28645691f87b781
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127683
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [4686b3f623393aa8ce4d44f1d0f97e582a21c545]

        localedata: keep the intermediate %_new.cxx file
        
        Mike tested it, and I tested it on Windows too. But at least for
        my Linux static build, these files are auto-removed. So tell GNU
        make we really want to keep them.
        
        Change-Id: I00eb191c4d0086de87f895a6e6fe26d1e405cab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127895
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [90290e7285ca177cc89daff699ced39904f71c7e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b79052ed393b4e006658816c7e611b7a6ef6b2f6
          - tdf#144332 Fix HID for Accessibility Check
            
            Change-Id: I9789043afbe17bc6eab6fd7bc3f664409d5effda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127779
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [552a42c1846b7b60ca1cf4d2a16641892990438e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6eb2b4b5600c3102a1f90e1b4eb6a7e934e9c07d
          - Related tdf#146117 Refactor XHP files
            
            This patch refactors XHP files that will be affected by an upcoming bug fix. No changes are made to the actual strings of these help files.
            
            Change-Id: I0c7449a1c940f44588a3723e3cc03e6fd46d06e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127778
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [3311d213dd6163154f962b0616567e5a78f2c0b6]

        use more SvxShape in chart2
        
        Change-Id: If39b252369d4e5b0add99b7357c5af5b50391818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [0899daa267ff6b31dd16f6daae7eb457f6e39203]

        use more SvxShape in chart2
        
        Change-Id: Ica9fff6c2d9619708a8f1b9994ad7d8a7d21a36d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127891
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [ee28a1464f2bbeaa24c34c73fee382f6e13a8ebb]

        Just ENABLE_* VCL plugins, if we test_* them
        
        .. and move the code into a new m4 macro.
        
        Writing the m4 macro turned out more complicated then expected,
        because of the quoting needed to handle the unexpected argument
        scope of AC_DEFUN.
        
        Change-Id: I644a95e4a988f843d89713a0b544cafc79262adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127893
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [5d79b65d56ab02f2ca9ff3ac37cc1008913ffead]

        use comphelper::WeakComponentImplHelper in UndoElement
        
        Change-Id: Ie0c950eca65c61eaec3ecbd5dc5eff1f97b0467f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [8f0ce842dffe229d31bd9841ac6e999da1ae976d]

        use more SvxShape in chart2
        
        Change-Id: I4a445ca3501d32cd8ff04f12239cce52457b9228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127889
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Miklos Vajna  <vmiklos@collabora.com>  [7d90a00a49435ddf9545a62dfea93b34ad9fb4ee]

        xmlsecurity: add some more logging
        
        We only get:
        
        warn:xmlsecurity.xmlsec:32272:32272:xmlsecurity/source/xmlsec/errorcallback.cxx:53: digests.c:226: xmlSecNssDigestVerify() 'sha1' '' 12 'data and digest do not match'
        
        when one of the XML streams have a bad hash. Add some logging to help
        figuring out (without a debugger) which stream is at fault.
        
        Change-Id: Ib5f39df87bcdaaac1a21eb560c8f775c42a4079f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127885
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-03  Tünde Tóth  <toth.tunde@nisz.hu>  [678790f292b63c9def1f0427df20028a1f734c15]

        tdf#127696 PPTX export: fix lost outline character formatting
        
        Now outline font property export is supported partially in PPTX
        export and in text shape export in other OOXML formats.
        
        Note: OOXML/MSO has customizable Text Fill and Text Outline in
        Format Text Effects, while LO has only simple and buggy outline
        character formatting property, showing only white or completely
        transparent outline fill color. Transparency issues and the buggy
        outline font handling of LO (e.g. 1% font color (line) transparency
        results 100% fill transparency of the outline text) haven't been
        handled yet.
        
        Change-Id: Ic34bce4efd4a544d799b1d89af1107c4918061d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126996
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6fefed87a3ffac4a8d236e6a96a6405bfbb31f0]

        CppunitTest_sc_subsequent_filters_test2: check format instead of string
        
        Otherwise, this might fail. See 660e538ee77109bc3e7dff4491164d696e503abc
        < Disable broken part of ScFiltersTest2::testTdf126116 >
        
        Change-Id: I40534b70fc19ee163d9e6cb0c081fae40b81fdb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127887
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2022-01-03  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [2951cbdf3a6e2b62461665546b47e1d253fcb834]

        tdf#143574 OOXML export/import of textboxes in group shapes
        
        In this part, oox module has been modified in order to prepare
        for WPG handling during OOXML import. Note: Wpg is the drawingML
        equivalent of v:group, supporting text boxes in the group.
        
        1) Added new parameter for WpgContext to support nested
        Wpg shapes, and WPS enabled for the WPG member shapes.
        
        2) A bug has fixed, where group member line shape and
        connector shapes have wrong positions before in the group.
        
        3) Unit tests had to be modified, and 3 of them disabled
        temporarily due to missing Writerfilter implementation (what
        will be the next commit)
        
        Now group shapes can have textboxes and the text is imported
        for that, but complex content is still missing (this will be
        fixed in writerfilter by the next commit).
        
        Known issue: WPG shapes with textboxes in floating table
        have issues during import at floating table conversion, so until
        this is not fixed this function is disabled for shapes in tables
        (will be fixed a follow-up commit later).
        
        Follow-up to commit 19394a924fdc486202ca27e318385287eb0df26f
        "tdf#143574 sw: textboxes in group shapes -- part 4".
        
        Change-Id: I71032187697807087bd8f27f7c3a7b052e174bd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124964
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-03  Mike Kaganski  <mike.kaganski@collabora.com>  [cce57fd94e9335c5dd5f3725a5fe54f5d3929e8d]

        Don't call it second time
        
        Change-Id: Ie2195bd1059c41b1b58f828649d5908b3b9a844d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127775
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-03  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4574a1ea408c2ac30042dca32d02207ec7add4da]

        tdf#146223 PPTX import: fix master objects visible property
        
        Master objects were always visible after the import, which
        could change the background of the slides.
        
        Change-Id: Idc5260718f2916e207f751286044e9a7fabdee89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126833
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-03  Tünde Tóth  <toth.tunde@nisz.hu>  [87db920b141fe9846cbd1b37fff3a9806a9b5c2d]

        tdf#98736 OOXML export: keep CaptionShape as TextShape
        
        Caption shapes were lost during OOXML export. As a
        workaround, export them as text shapes, losing
        only the leader lines, but not their text shapes and
        text content.
        
        Change-Id: I372708fa4c9356c807a0a239c722691fd88ec1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126123
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [ad51b6c85da5fd2e12130f453bcd5dbc8bf83f0e]

        no need to pass around a ShapeFactory instance
        
        since the methods are all static now
        
        Change-Id: I4296a22f0d9ce86df8f1b36c4a1babc7e9d5c070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127883
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [3a93cc176da60e80a4a8876c535f30fb11fb4373]

        use more SvxShape in chart2
        
        Change-Id: I15cc7e8e0f934772ce6dc29dc89471a78f008916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [383616c2c0c9e6874a714d7f494e5a2ec1a3f08d]

        freetype/fontconfig: ignore --without-system-libs
        
        Since commit 8677e994d37329a28ca8278358a99d18b9cada69 ("Simplify
        FONTCONFIG and FREETYPE tests"), these tests adhered to the
        ${with_system_libs} setting, which might not be desirable.
        
        As a result commit 4e7f3692c9eb42a00797025289782baa69a42cc7
        ("Make external/freetype use -fPIC") is needed as a linking fix.
        
        This still keeps the possibility to build with internal freetype
        and fontconfig. This also adds a new macro option, "test-system",
        which follows the $test_system_* variable without additional
        configure switches.
        
        Change-Id: Ifed91fdc6e4a77f708a3dbbd784b6069bf2a61b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127878
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b4164ec443650f77aa472fc0d06e6dba716e2d28]

        vcl: (re)move drawEPS to SvpGraphicsBackend
        
        Change-Id: Ic5936a0d5bfe566d75532ccff52f25bf502019ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127827
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d1c813809a9f21fc670e759828922c2f11d972dc]

        vcl: move invert to SvpGraphicsBackend and CairoCommon
        
        Common invert to CairoCommon, 2 invert members on the interface
        to SvpGraphicsBackend calling the common invert call.
        
        Change-Id: I2fada75cc0d730f0708ae7ca934a51e1d17cef1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127826
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-03  Miklos Vajna  <vmiklos@collabora.com>  [1557391b9859c79c4cf67d6c80ab423cd22840fa]

        sw: prefix members of ConstCustomShape, SwXAutoTextContainer, ...
        
        ... SwXAutoTextEntry and SwXAutoTextGroup
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie09cd100e1ecc29a7e5e4b68d566785ba63e5da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127881
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2022-01-03  László Németh  <nemeth@numbertext.org>  [98fd4fcdc61202846e0957cb6aaed9e4a2d2c520]

        tdf#136368 bump to libnumbertext 1.0.8
        
        – Soros.py: fix FutureWarning: Possible nested set at position, reported by Rene Engelhard
        
        – tdf#136368 fix Old Hungarian transliteration
        
        – fixes for Chinese, French, Marathi, Polish, Ukrainian
        
        Change-Id: I99f56b8a6089bc94f43056bcdedcae89ff4e68c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127821
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2022-01-03  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [ab92f97b48741dc2a78daf6f030cfad572ffdfef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66835d0b781676751880a47989a5464b9dd1590f
          - These don’t need to be translatable
            
            Change-Id: I58aaae67b6c4e138ff7b7d7a655bdc3a71761bb7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127886
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-03  Kevin Suo  <suokunlong@126.com>  [86cffd61c1f01a18f4016bb09c8d63a581f5cded]

        tdf#129448: Auto first-line indent should not be effected by line space
        
        Previously, if you set the first line indent to auto, then if you change
        the line height, the first line indent will also change. I do not see a
        reason to change the first line indent value in case of change in line
        spacing, even for English language.
        
        Some languages (e.g. Chinese) may have set the auto first line indent
        to be 2 characters of the current font, but if the first line indent
        changes when line height changes, then this 2-character rule is not possible.
        
        For compatibility with old documents, a compatability flag
        'AutoFirstLineIndentDisregardLineSpace' is added in this patch, thus this
        patch only has effect to new ODF documents. DOC/DOCX documents will also
        benefit from this patch, no matter old or new, because, as Miklos Vajna
        has pointed out, Word does not have the auto first line height feature.
        
        Change-Id: I1e2ddc33cce4ff9b3b2b4122445894f724d5bcd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125627
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2022-01-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3aaf8506b3ee0d4a1bb86be7c6ca4d9402467d49]

        vcl: move getPixel to SvpGraphicsBackend
        
        Change-Id: I409581a2bdc9e18420bb159ce349fb5a5b86c463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127825
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [7c36f46a1ea35633d64c44a2ee1e834b1f88cc8d]

        add new SvxShape hierarchy class
        
        to serve as a shared/common base class, so I can plumb
        SvxShape types through chart2.
        
        Change-Id: I8758fff1599c92a214b334ee44cf7b4e582c1915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [5f41e5741fa3abe59dd14a50e692d425eed472d5]

        use more SvxShape in chart2
        
        Change-Id: I7fb23da1ad60d07ac8c3165f70dafefcfaf5ab8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127872
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noelgrandin@gmail.com>  [2678e4467f2d7d193b93e4cdd1b96b12d3ff53f1]

        use more SvxShape in chart2
        
        Change-Id: Iedc03bd4e55ecb35012432c774a7510957c22333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127871
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4423520845ca4f566474e57cd0c0988034e0c7c]

        loplugin:unusedmethods
        
        Change-Id: I922778e8ced0ad922d90a153b0eda47abbec94ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-03  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [660e538ee77109bc3e7dff4491164d696e503abc]

        Disable broken part of ScFiltersTest2::testTdf126116
        
        Fails since New Year with:
         Test name: ScFiltersTest2::testTdf126116
         equality assertion failed
         - Expected: 03/03/21
         - Actual  : 03/03/22
        
        Change-Id: Ic5c259e6bf1f184ceb7cf15e1ba7a83dac729c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127879
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2022-01-02  Caolán McNamara  <caolanm@redhat.com>  [73631b1bf52a2e6dd8a85d6fef36d754c15dcf82]

        ofz#43052 crash in WW8TabDesc::MergeCells
        
        Change-Id: I4d7acc006458598ad43033fa8e35b2f422d76ff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127876
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-02  Stephan Bergmann  <sbergman@redhat.com>  [f6e02294ce8d71a03c8e440e041094d2dd0a9834]

        Replace obsolete *_use_external_project for libjpeg-turbo
        
        ...which no longer is an ExternalProject but just a StaticLibrary since
        1295f497e0cc7fc7cfcb66182496a4d29aa701b3 "upgrade libjpeg-turbo to 2.1.1".
        (This caused e.g. a from-scratch `make Library_pdfium` to fail with
        
        > [PRJ] libjpeg-turbo
        > touch: cannot touch '.../workdir/ExternalProject/libjpeg-turbo.done': No such file or directory
        
        when workdir/ExternalProject/ happens not to exist yet.)
        
        Change-Id: Id0f0e3b13cc7e9e556d9c8e7698d4dfa1bb01659
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127874
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-02  Stephan Bergmann  <sbergman@redhat.com>  [4e7f3692c9eb42a00797025289782baa69a42cc7]

        Make external/freetype use -fPIC
        
        ...to prevent Library_pdfium from failing to link with
        
        > ld.lld: error: relocation R_X86_64_64 cannot be used against local symbol; recompile with -fPIC
        > >>> defined in workdir/UnpackedTarball/freetype/instdir/lib/libfreetype.a(ftinit.o)
        > >>> referenced by ftinit.c:89 (src/base/ftinit.c:89)
        > >>>               ftinit.o:(FT_Add_Default_Modules) in archive workdir/UnpackedTarball/freetype/instdir/lib/libfreetype.a
        
        etc., presumably since 8677e994d37329a28ca8278358a99d18b9cada69 "Simplify
        FONTCONFIG and FREETYPE tests" no longer implicitly forces use of system
        freetype on Linux
        
        Change-Id: I2743619768e2dd636ec431408fcb2871871504f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127864
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2022-01-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e2c4bd9228bd0cf973f13dbe4410a2391d06ab8]

        loplugin:unusedfields
        
        Change-Id: I20a387563a0f65bc9a7149ab0b08b09f1946e9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127867
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e327bccf14130eb469f06c96721b9d8aea5dd506]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ia7d68c07d44aaa9ce44fe4e7ed72987e96433269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127866
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [a5dbd92d06025e5bbaeb95d49be50f6c32971e5f]

        osl::Mutex->std::mutex in FormScriptListener
        
        Change-Id: Ic5a1a9f84374ec41685ee32a69cf7fe43e215d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127831
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [978acbeb8cb203ae94040d5253031be11d17d15e]

        idl : no need to use rtl::Static
        
        Change-Id: I8b53ab93010f500a61aa4930817c25d09cb2552d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127869
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Arnaud Versini  <arnaud.versini@libreoffice.org>  [477fa6c3cb92f578032dee60482718efdb8f44f2]

        avmedia : use std::mutex instead of osl::Mutex
        
        Change-Id: I0e779db4ef32ac74b9df18d1e162b49236b44b88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [5f567b9aec84283546c3084f015d01a70bd76c86]

        use more SvxShape in chart2
        
        Change-Id: I53e4f5e68a982bec1fcbcd626f60124ebd0d51b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [0249e598044b12e7f82cc6e95546687cfbbdfe38]

        use more SvxShape in chart2
        
        Change-Id: Ib973fe1eb226ca6a55166ad8f3afeeca766ec8df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127860
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [5d33befeeb2452f1cfa0404483c71816fcd88314]

        use more SvxShape in chart2
        
        Change-Id: I95342cfa39be2a058ec6c5d106ece6e60bf85520
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127859
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [594c422851c991e17ad051b880457d66b404dfdb]

        use more SvxShape in chart2
        
        Change-Id: I97f57652d2ce17efc9b69e07bbca78c318451f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127858
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [00be6e6767869aec015807e6e1f52a2b9fac351b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7e7800abe70df5f14c03c63a829ed74d403a5fd
          - tdf#94537 ORG.LIBREOFFICE.* namespace information
            
            Change-Id: Ide646195514d45dec1b4b386890b1d64ae3b3138
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127840
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f198e8bb0822f9316bab2eda8d39f6f7bb568081]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 990e1236dc288bca7e7c8678353f505e9d1e9116
          - tdf#94537 ORG.OPENOFFICE.* namespace information
            
            + removed reference to other suite interoperability
            
            Change-Id: Ide0fe6dd306e1cd3fa2e0a7377b16fb1a6e89f58
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127839
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [d1a1b58d068ba9e629d9b5437ff1b542cb21776f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d12e99d7502858285b5a0acc695036aa3b916f5
          - use consistent argument names of SF Shift* functions
            
            Change-Id: Ib99180a481a94c5140b36ec022cf4f495a6f74dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127865
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [610ebe90e15176a9106552790c896a8f29a3cbc7]

        use concrete types in chart2, SvxDrawPage
        
        Change-Id: I0bdaa74595c0201a04490e293619c2c399ab03bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127838
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [0691e3a0d901fe0373ec261cb22e8e6745303e5f]

        use concrete types in chart2, createText
        
        Change-Id: Ic3b5920192c62cbdd025b480b01d04fb57d0be00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127837
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [97429d17665a4a251701b0ba5281413c7fcf56ab]

        Fix typo in libclucene-core
        
        ... as pointed out by jospezial on the github patch. And really
        fix the 2nd typo I didn't see... looks like the 'c' moved.
        
        Regression from commit d951a054445ad3741d678f422a5b605feae06a6b
        ("Use libo_CHECK_SYSTEM_MODULE for clucene").
        
        Change-Id: I22ab271b270d1ec1de44d9ca4208884e7b43aae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127857
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>

2022-01-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e5492dfe039b6fd0b4feff869c657c46960a97b7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bd81d7cc74baa40d0dd5f44518056fda10b2010
          - use link to internal CSV filter help page instead of external wiki
            
            Change-Id: Iab042f6e9c458fda66c849b2a7737f39f8c18ab9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127849
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2022-01-02  Mike Kaganski  <mike.kaganski@collabora.com>  [4494966015fbdf544928a9f6d1105d57e7a8212a]

        Factor out drawing native menu mark into a separate function
        
        Change-Id: I87da929d5311c72189f6c22f910b33f3a03393c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127847
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-02  Mike Kaganski  <mike.kaganski@collabora.com>  [9f4aad493c7087256d03b01ca3fb18d96f461526]

        Introduce OUString::unacquired(const OUStringBuffer&)
        
        ... and avoid OUStringBuffer::toString when the temporary is used
        for checking current buffer content
        
        Change-Id: I114178f3e74ca3e4a3e517763f9eaab4797b7deb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127478
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2022-01-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [41ee9dcc4e12c32d49294dd4b19a97cb24f8253f]

        Use correct ld syntax for old clang versions
        
        ... and forward the same ld setting to the cross-toolset.
        
        Change-Id: I23a40fe3fecd105cdd67dc50bb325dc659c1440a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127855
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-02  Noel Grandin  <noelgrandin@gmail.com>  [dbdfdb74b42b32bd8428acdffac20fe63599a67d]

        osl::Mutex->std::mutex in ChineseTranslation_UnoDialog
        
        Change-Id: Ife56a3d106f64b00b63798d6300e768bbfa81335
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [a3adb6f82eb582f5bc52037018ad3b7b53bb4bd1]

        Error-out on --enable-ld with path and gcc
        
        Now that mold can successfully link LO and its unit tests (needs
        mold 1.0.1 or later), gcc could support an alternative linker
        with '-B<path>' to search for its tools in some extra path.
        
        But it turns out that libtool filters the '-B' option from its
        arguments, so it falls back to some system ld. But since we
        already tested "our" ld for some features, this might not match,
        resulting in libtool failing to link externals, like orcus.
        
        The original use case was testing mold, which can also be done
        by using LD_PRELOAD=/usr/lib/mold/mold-wrapper.so, so this patch
        just shows an error, if gcc is used with an use_ld_path.
        
        Change-Id: I9c7860895f8b24a5f3fc4b1e0fd5232be22293f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127493
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [7f5140fb8cf3d127b5cb8704d277b03de2f63b51]

        oss-fuzz: put LO downloads into $SRC/external-tar
        
        Change-Id: I0d5cf89fabc8e044959dbd0af484b5ca46404eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127854
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [126424cbfa70dea1186070a8986c020778ca7c96]

        oss-fuzz: drop unused static fuzzerstubs
        
        Change-Id: I432d216207026077ba338251943e58e19647c8b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127455
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da13a44c2b63887de5f27cfd1bed55f0a2d86d04]

        Fix typo
        
        Change-Id: I01e9575dd37d9e15538ea7e4d6d5d0f382840730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127850
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [a4e15140b33633301c387a4d95b18de24231cbdb]

        Further separate saxparser run from cmp'n'touch
        
        At least on Windows the calls to saxparser almost feel as slow
        as the compilation. So this adds an intermediate file just for
        the cmp calls, costing just a bit more filesystem space.
        
        This also reverts the gb_MKTEMP usage introduced in commit
        14eeed686c5490ddbd356c1ac807b16231e4cb88. Using a fixed name in
        WORKDIR is easier to debug eventually, then some random mktemp
        generated file, and is faster anyway.
        
        Change-Id: Id4979b75b881e916c209ff0ff8e123536294e93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127841
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [bf44ea9d2daea4a57d7add7d2d81c8309d659bb2]

        osl::Mutex->std::mutex in Svt*Options
        
        Change-Id: I329849310f289e0fe7a886bbf3855f8d569767c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [98dbb1b50af57b3070da6434825e79747f536f8a]

        use cppu::BaseMutex in FmXFormShell
        
        because passing a ref of a local member to a parent class
        means passing uninitialised data
        
        Change-Id: Idaa8d3d3c54a14e184c84a0d6df15219b2ec2f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127832
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Arnaud VERSINI  <arnaud.versini@libreoffice.org>  [335ecfee17f9971b431761e978ae3c89e742891c]

        idl : use delegating constructor
        
        Change-Id: Ic3a23dfc1278a9f34d0b7a441d604903eadc2a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127818
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2022-01-01  Caolán McNamara  <caolanm@redhat.com>  [f3dce2a4039ce16593a084480d1fc6f82ce9b147]

        fix solenv/gbuild/extensions/post_Fuzzers.mk:11: *** missing separator
        
        since...
        
        commit c859b4aa48956cbf5ff41280b0008456e8f5189c
        Date:   Fri Dec 31 09:11:10 2021 +0100
        
            gbuild: introduce gb_%_linktarget_target
        
            Just some refactoring.
        
        I also think gb_Executable_linktarget_target should be
        gb_Executable_get_linktarget_target.
        
        Change-Id: I270fe10ca7d12c454ce69744815a2e35a909a851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2022-01-01  scito  <info@scito.ch>  [4d0d4fb11f7251e0437ec8e6fe7b7693f3a31800]

        tdf#140286 fix INFO("OSVERSION") for Linux: return kernel version
        
        If LibreOffice Calc is running on Linux, the Linux version as shown in
        about dialog is returned, e.g. "Linux 5.3".
        MacOS and Windows parts are prepared, but  not implemented.
        (I develop only on Linux.)
        
        Change-Id: I2b266a257e5c01c0fde7d076385ded4a6413d3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127756
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [6b85c0adf8050c1eba89f2115dc5151a7507369f]

        use concrete types in chart2, createCircle
        
        Change-Id: I42810d2a77e860e8a911288db8556043f7ed1d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c065f342a0f2a0eb694b787096ed3bd600671cf1]

        vcl: move drawGradient to SvpGraphicsBackend
        
        Change-Id: Ifc3d0b0a693113b0cfbd763bf6ac0bd34eb6c872
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127824
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [27856da9b43cd475922f57fec32bdef60dd21720]

        vcl: move (legacy) drawPolygon(.., Point*) to SvpGraphicsBackend
        
        Change-Id: I5b3b915712921fbbdaa0b0d7ad9b9c39291e00f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127823
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8d6343e6b29fc6162d88b25dfa3a165e0d1b063d]

        vcl: move drawPolyLine (+legacy) to SvpGraphicsBackend
        
        Also moves drawPolyLine with cairo context param. to CairoCommon
        as it is also needed in X11SalGraphics::drawPolyLine.
        
        Change-Id: I49b24bc31ecf3f6ab3cebca4eaab351c91564db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127740
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [977e0bf1fc468976cf9b86df142807039623a71c]

        osl::Mutex->std::mutex in ThreadManager
        
        Change-Id: I9a7ad88b77222c3419ab5eee0859ecc931d6b0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127811
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [34b67c5cb3338c4bd72f42df99a4b79ca1588071]

        osl::Mutex->std::mutex in SwRetrievedInputStreamDataManager
        
        drop the locking call in
        
            IMPL_LINK( SwRetrievedInputStreamDataManager, LinkedInputStreamReady
        
        because it doesn't actually touch any related data and the lock
        is taken in the call to PopData.
        
        Change-Id: I2e679b97a1ce36e7d39a9a2818a9d62fd53009a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [1bb248fa3670ac11d4623ba14d1e914554fb6971]

        gbuild: silence Windows Skia clang builds
        
        When building Skia on Windows in an non-English environment, the
        console is filled with "Note: including file:" output. That's
        because cl.exe has some translated output, but clang.exe has not.
        
        So detect the clang usage and its "showIncludes" output and
        override that setting for the compiler call.
        
        Change-Id: I19b403aa79a8dde70616865aef051aa365f79de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127822
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [42834bec6ba590f060e74c23324d362bf8d4fd1a]

        oss-fuzz: depend on linktarget, not the binary
        
        Not really an oss-fuzz-only problem, but general linking of static
        binaries.
        
        Broken in commit ecc50f56b3282ec3b0364101d860f22fe8da9042
        ("gbuild: set library dependency for static builds").
        
        Change-Id: Iba9c9405cf4adb78c1ec9b64dfa02c3a82d2cf55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127800
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [c5af1c2615ded871946a1ac60e67497fc8753495]

        Forward PCH setting to cross-toolset
        
        Change-Id: I0b4bc369b070924cf3b79ba272b476501ca11467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127820
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [818123e878f2ca6f408fc4e9563beb813bccd64a]

        Android Arm: fix wrong bracket after refactor
        
        How did that even pass in Jenkins on Android Arm?
        
        Regression from commit c859b4aa48956cbf5ff41280b0008456e8f5189c
        ("gbuild: introduce gb_%_linktarget_target").
        
        Change-Id: Id06cc151e92e221da856814d69eb8cced167b427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127829
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [056de1a0812ccec8496619c918091d4fe120f11a]

        Skip always failing testDrawingText on Windows
        
        Change-Id: I15e60e13735bf87529264905773b486afb3fc74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127835
        Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [94e021c5e1f1fdb19d18fe8f5be7b5b4e5b841a7]

        osl::Mutex->std::mutex in SwChartData
        
        Change-Id: I1bc85e4c8ac4945e13063793203fd308526263a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [3f1886a2d00d8819b94220f0436f3a134041bcba]

        osl::Mutex->std::mutex in SwXTextField*
        
        Change-Id: I80dde4f44dd3d2f701a246dec850f7560207ffee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [15314d2d28535d1baa9694f9d01cb8b34cf6f0d2]

        osl::Mutex->std::mutex in SwXFrame
        
        Change-Id: I3d809accf34bf89f638481c84a671826ca4bd45f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Noel Grandin  <noelgrandin@gmail.com>  [35c92336c5e1e81f87597350975296172bc36258]

        osl::Mutex->std::mutex in SwThreadJoiner
        
        Change-Id: Id0fb961e78c7db9e352babce12625ac355d99d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127810
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [102a29d59a0a195ee42a52d5563adf99fa32a541]

        vcl: move the draw*Bezier methods to SvpGraphicsBackend
        
        These methods only return false (for fallback implementation to
        kick-in).
        
        Change-Id: I167dda09d401e69ca4a2296e8024ab0f203b097a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127739
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [96107b0196a0b91e8966db1f12052f5c3d32c944]

        vcl: move drawPolyPolygon(..., Point**) to SvpGraphicsBackend
        
        This moves the legacy drawPolyPolygon, which takes a 2D array of
        points as the input. The implementation just converts it to a
        B2dPolyPolygon and calls the regular drawPolyPolygon.
        
        Change-Id: I5be8b818bcdf58a15e575b904ed20bb8f97bcffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127738
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a2da849163cbbba5ab4272999b9fb081240f1786]

        vcl: move drawRect and drawPolyPolygon to SvpGraphicsBackend
        
        Also move add_polygon_path and SystemDependentData_CairoPath class
        to CairoCommon.
        
        SystemDependentData_CairoPath is temporary made public until other
        dependencies are moved too.
        
        Change-Id: I381407fc7c168c8982fcfd8c886cf622f95591fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127711
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2022-01-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cf6f1aae98e23227e4a9a17d72801abf38c6259f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7ad8f2bbd7b786557b8bcd9b275e0c312a921bf8
          - tdf#94537 COM.MICROSOFT.* namespace information
            
            + Covered all COM.MICROSOFT namespace of wiki page in the bug report.
            + refactor of other info such as release number availability.
            + Muted l10N in a table and drop duplication.
            
            Change-Id: Id77f9657f164193d5e672e9edf82a2170b5f4040
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127817
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-01-01  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [fb32c4d96141ccc1766fa4e39405130fcf409a6a]

        Bump copyright year to 2021
        
        Change-Id: Icbb000677066127fa67e8c22fb0ab6880acc0169

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [1b3c8f4a6997fdf5685639cc70947c6edb1d85fc]

        osl::Mutex->std::mutex in SwXBookmark
        
        Change-Id: Ic3deffdafb62111f20540c1785824e5cd66a1623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [c859b4aa48956cbf5ff41280b0008456e8f5189c]

        gbuild: introduce gb_%_linktarget_target
        
        Just some refactoring.
        
        Change-Id: I47adb93f8a413d289f6abb2a48ed3f049f582a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127799
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [aa29327fcab653f8c4d3de7b2ed6d691219b92ea]

        osl::Mutex->std::mutex in SwXParagraph
        
        Change-Id: If65a862dab3d760357598ece1940e68e4bbc7907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127803
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [68647c78eaa9171befe050e4d0a1d2dce3b732e1]

        osl::Mutex->std::mutex in SwXMeta
        
        Change-Id: I395597215be7e6f5796b99c55ebb49da284c6a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127804
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [2d9d0b549e14f3a71414a573d67bd0f63f54dac2]

        osl::Mutex->std::mutex in SwXDocumentIndexMark
        
        Change-Id: Ic6b167ccec8a605a757eb437e2da86e0a290c63a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [dcd17b7a39608f7b962d330c3ac771e18ed75bc7]

        osl::Mutex->std::mutex in SwXFootnote
        
        Change-Id: I5e831f85a151cff1b5472c4c7560bcb486b98b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127801
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Krzysztof Hałasa  <khalasa@piap.pl>  [0143ec4d3d56eeee7edf16371c1d3c3981890b71]

        tdf#134982: use the right protocol for Mysql/Mariadb
        
        Thank you Krzysztof Hałasa for the patch!
        
        Change-Id: Ib7532a716b7e0fa73f309e0a4f9af9e663e0d3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127673
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2021-12-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f1c12253068bdac425c89164be207f402d9eb567]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 830ed1f1dd5ad301e635f32f4120297fcb104000
          - tdf#94537 Inform user of non-ODFF functions (part)
            
            Open for discussion and contents improvement, other patches will
            follow once this is approved.
            
            - used embed to reduce translation workload
            - un-localize function name space
            
            Change-Id: Iab42e87754d5b9b0c3d2a248af82e297ec73ea7c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127751
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-31  Caolán McNamara  <caolanm@redhat.com>  [95a4fade262efbebee34760a2518f62701387c83]

        fix ubsan --disable-extensions error seen in oss-fuzz build
        
        i.e. instdir/program/libcuilo.a(dlgfact.o): error: undefined reference to 'typeinfo for AdditionsDialog'
        
        Change-Id: I6445632d81ca9d87b44cf9b0be59358ccd8f57ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127791
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-31  Julien Nabet  <serval2412@yahoo.fr>  [22a9faa36057b96b8478f7a1f990762fa78f3d26]

        tdf#146472: Missing page count in Go to Page dialog for some locales
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=146472#c2
        and https://bugs.documentfoundation.org/show_bug.cgi?id=146472#c3
        
        The _ is added by use_underline/use-underline
        In the case of Czech language, "z" was used as the shortcut for _Cancel/_Zrušit
        and since "of" is translated "z", the "_" had been put before the 1
        and "z $1" was transformed into "z $_1"
        
        So let's remove the shortcut for "page_count"
        
        Change-Id: I11a03cf11cafe108f77f4b6427fa66b1686d0ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127790
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [a6bc44821c9da9b2e8664de391a9f2869709b88f]

        use concrete types in chart2, createLine3D
        
        Change-Id: I4e4eb969e8c3e797a5816fe2e781e3192367a0d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Noel Grandin  <noelgrandin@gmail.com>  [4155a29e379f2b86af2fda447019b08ab9ca4418]

        use concrete types in chart2, createLine2D
        
        Change-Id: I7e93bd51e7b02e72e56367a5fd027d3a129ee541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127761
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-31  Julien Nabet  <serval2412@yahoo.fr>  [6b0f13012167a9c98aa58789a35320bdc1d0cb16]

        Fix icon links.txt parse error
        
        When trying:
        ./bin/run vcldemo
        
        I got:
        vcl/source/image/ImplImageTree.cxx:603: ImplImageTree::parseLinkFile: icon links.txt parse error, incomplete link at line 2643
        
        Change-Id: I41899b5a6cb6c9b20b1da7e3456fe0ae23cae71b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127760
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [7fb7831afa7ae958d838a0058975529d4063272f]

        tdf#114995: sc: Add UItest
        
        Change-Id: I351f080f56b5e6183d932463ea2faf13bb666ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127765
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Ankur Khandelwal  <khandelwalankur176@gmail.com>  [96882cdec23c64974737c4833f157d54b85a129e]

        tdf#145538 Use range based loops
        
        * Use range based loops in cui/source/tabpages/swpossizetabpage.cxx
        + Goal: Better readability of the code
        
        Change-Id: I8df81be6d6d628d4f3366bc2de4b3e44adbc430f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123871
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [b779831ae89a7b921ec3d8658009a191e2270525]

        tdf#127484: sc: Add UItest
        
        Change-Id: I7c15750ae42d78bfb714638e44c7b761f5c22b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127759
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [572cc53ec16b0a022a5158483920e1a6f1c174b9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cb892ee8ca64a05e0912eaf83f175866b90089ad
          - tdf#131206 Review Writer field format
            
            TDF#131206 Comment 13 - 2
            
            Change-Id: Id7d9f178df365ccb3120055a2626c646cd9c31e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127764
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [fa97804611f56db9f70a2b14ea07f59ca5f5e34a]

        uitest: sc: reintroduce code incorrectly removed
        
        Change-Id: I18ad03632950530d7ae2c24608936dba325b0a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127758
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Mike Kaganski  <mike.kaganski@collabora.com>  [089e0cb2cce6ee6f80ed1b77e333e83234fd3961]

        tdf#133697: use true bullet size to avoid stretching in scaled UI
        
        Change-Id: I7fcff6234fa6ee5dcb47a6c32651a9bae5f056c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127741
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [72af8f8e8f11a74ced2dfb6c2457026550814129]

        use concrete types in chart2, SvxGraphicObject
        
        Change-Id: Ia01be1d6cdb1b9a1c2af32a8873575227fe32b03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [098da417618e09692a8f574e2c5cb7af582104e9]

        tdf#95217: sc: simplify test
        
        Rechecking again, I found out that the encoding problem described
        in tdf#95217 was actually fixed by the same commit that fixed
        tdf#146048 ( 3392f567be8d52804b187b0bced47204ef38fa3c
        < tdf#146048: detect UTF-16 without BOM > )
        
        This commit partially reverts d7fb6b22cf7e66eb2594001cc42c6bff8b5a49e2
        < tdf#95217, tdf#142600: sc: Add UItest > since we don't
        have to create any http server to reproduce the issue
        
        Change-Id: I2f0177f8450f77de5df756354d48505193a6ba3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127742
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f1cbb458e158c8f62c9c47917f8ab0ef76ba0ced]

        vcl: move drawLine to SvpGraphicsBackend
        
        Also move getClippedStrokeDamage, AddPolygonToPath, impPixelSnap
        to CairoCommon, as it is needed by the move.
        
        Change-Id: I002f0094935e5f5d4836bb973f7cf7bea0218ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127710
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c14ca07fdcb7dee9b0099ec9c9ec419affe68779]

        vcl: move drawPixel to SvpGraphicsBackend
        
        Includes moving getClippedFillDamage and dependent functions to
        CairoCommon.
        
        Change-Id: Iea7c39377816c3639de1b97cea47efa71ca47315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127709
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9d895ff47126b4fd95b95c8138bc8fdb8abbf1cc]

        vcl: move applyColor and clipRegion to CairoCommon
        
        Change-Id: I0a207b10017923c4336d49ebc8abd53c78d809ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127708
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [11dd4c918749839867568651f0c62db30fdda297]

        tdf#126269 Add clipping to diagonal border lines
        
        See task for in-deep discussion. Needed to do some
        re-arrangements to add clipping to diagonal border
        lines. It is necessary to only clip visible geometry
        but not touch vectors that get added to be able to
        solve all that dynamic border line style start/end
        overlapping.
        
        Change-Id: I656a5cd63a011140ee1281873e44ab5e60606b67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127713
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [88c511981e31c73dced95b5dc3c200fdf2a4e932]

        Fix uppercase EOT => LIBEOT usage
        
        Originally I had these hunks included, but somehow came to think
        that using EOT instead of LIBEOT would work... well I'm obviously
        wrong, so re-add the uppercase LIBEOT usage.
        
        Still uses the lowercase "eot", because of the autoconf switches.
        
        Regression from commit ce54ba96f38b4af3aab1a7064078ee406eb021c6
        ("Use libo_CHECK_SYSTEM_MODULE for eot").
        
        Change-Id: Id3e1c97cdb67621f0c0cfd67b78836f62df0e8e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127737
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Ramreiso Kashung  <ramreisog24@gmail.com>  [7886b6a56a51cb699fb2a18d8a8dff0e224bdfb5]

        tdf#145538 : Using range-based for loops
        
        Change-Id: I9674eff3e2572ffef7ee19af12befc8a9b6b1c06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127734
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-30  Hossein  <hossein@libreoffice.org>  [dd1b0471b70f9b5c5db6b681c1fceacfe17c9349]

        Minimal vcl application
        
        Created a minimal vcl application inside vcl/workben in ~55 loc
        in which creates a window and paints a simple text inside it.
        
        One can run the application by invoking:
        
            ./bin/run minvcl
        
        Change-Id: If648666ff25c4b66089a37c8d8164752663fa225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125124
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [206c52d1248cc474fc7c3bbb6812688c97eb2ca0]

        use concrete types in chart2, Stripe
        
        Change-Id: I8814616024345206a69b7e33ade42c74656e9213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [2228bda030384c8e48810d6d4fb5525084a31511]

        use concrete types in chart2, PieSegment2D
        
        Change-Id: I18bd576fdc3a679013f999d769089dce35e09994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [042bfbddfd134f3e2fefc144f3c06cef61813278]

        use concrete types in chart2, Svx3DLatheObject
        
        Change-Id: I3c007cc5b70e6a7b854438b9b2558229f5a5c73f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Julien Nabet  <serval2412@yahoo.fr>  [13de0ade50bec34be612ba4a3196c2efd9ce3b4e]

        tdf#146471: Firebird: impossible to delete an external table
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=146471#c1
        for full explanations
        
        Change-Id: Ie75669cf951429654ff8e6c28508b9fee2ee03bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127715
        Tested-by: Jenkins
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [66a4ac244220add87f6972ab9961c3de8ce37ea2]

        use concrete types in chart2, Svx3DSceneObject
        
        Change-Id: Ic1cdc8a4efbb91bfabe84c32b703cb4868cd31a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [0ea295876797cc8677817cf5e64ce19cc36f46ea]

        use concrete types in chart2, Svx3DExtrudeObject
        
        Change-Id: I8b9dc0568cabf5c5e3f35c2330803f96c7623e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127726
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [3f3e011c9bbf5c51df983c2a28b348dcdff3dd3f]

        use concrete types in chart2, SvxShapePolyPolygon
        
        Change-Id: Ica53484d44e6992278b8d188ffb536e238aeb195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127725
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Johnny_M  <klasse@partyheld.de>  [e4282270bf5fee98c7647f13cb96ee2cdea1f018]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 40af7a44e3d2518bc0ef9364eb5f7253323d2fbf
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5d0adeae10558b749268da1b5030f29f4b080eab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127625
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-30  Szymon Kłos  <szymon.klos@collabora.com>  [d131cd35103c54cdcfa2ea75dfc9aa3d4fdf315d]

        jsdialog: send default button state
        
        Change-Id: Ida7e9ce598d1fe45e793184ced7f5874e6956e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126648
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127733
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [26836c3a4f7032f597b829f4d6b896294404ef8f]

        vcl: move getting and releasing cairo context to CairoCommon
        
        The getting/creating and releasing of the cairo context is needed
        by the SvpGraphicBackend.
        
        Change-Id: I133b181b8a6b114e08c8acc4596ccefb88a3f514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127707
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [96113a1d1df9b1f0e2bf75a90e6111a65250334d]

        vcl: move lineColor, fillColor and paintMode to SvpGraphicBackend
        
        The member variables are moved to CairoCommon.
        
        Change-Id: Ia03f613c7ad02ec2e7d70705c7666ec25d63f003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127706
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [49c5ee173bb9085bc56822cdc90786e1477abd5d]

        vcl: move set and reset clip region tothe SvpGraphicBackend
        
        The clip region variable now needs to be in CairoCommon and used
        in SvpSalGraphic and SvpGraphicBackend.
        
        Change-Id: I577ad2c3b6531a26089019ccbdc5e07398f70378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127705
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [aa4f1be4a9c0161711d3d8a6cdabb7b05f53cf07]

        vcl: pass CairoCommon to SvpGraphicBackend, move over some methods
        
        SvpGraphicBackend now accepts CairoCommon on construction, as we
        need it to move over methods. This moves over GetBitCount and
        GetGraphicsWidth, which also needs the frame size, that is added
        to CairoCommon.
        
        Change-Id: I362c9bed3ef0d85fc51f90a192cc20e06d7a45c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127704
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [70a1f26a5ebb839279f1c7d58ffd9f085bfb1f0b]

        vcl: Introduce CairoCommon to manage the cairo functions
        
        CairoCommon is needed so that SvpSalGraphics and SvpGraphicBackend
        can both access the same cairo constructs. Currently the common
        one is the cairo surface.
        
        Change-Id: Ia23c30489c9df889a348da5720ee84c82c792374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127703
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [1c26cfdd8a7137cb6db29b1f88e5023e43f9d6e4]

        libo_CSM: better output for disabed tests
        
        Change-Id: Id912495169b6c83ce9798a13d24e1cf4b9e83a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127723
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Ismael Luceno  <ismael@iodev.co.uk>  [c1be12396088563ed77ed61e54fd4e153469701d]

        Add configure test for the backtrace implementation
        
        Improve robustness by testing explicitly; instead of assuming based on
        the OS, test first the libc and then test for libexecinfo.
        
        The assumption was wrong for FreeBSD (included since 2017) and for
        musl-based systems (not in libc).
        
        Also, remove INCLUDE_BACKTRACE and clean up a bit.
        
        Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220271
        Change-Id: Ib4b7fd4fe2cdf5f76babe47a21bd2990fcf42649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127538
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [d7fb6b22cf7e66eb2594001cc42c6bff8b5a49e2]

        tdf#95217, tdf#142600: sc: Add UItest
        
        for that, launch an http server in a separate thread
        
        Change-Id: I9d78c9a4349620a9de31b3963f2a31ff1d354f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127592
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Szymon Kłos  <szymon.klos@collabora.com>  [035422a44acb5fc19042199013eb01af3790632e]

        jsdialog: don't send back typed text for combobox
        
        Do the same what we do for Edit fields for ComboBox entry:
        when content is changed by event coming from the client
        because user typed something - then don't send back updated
        text so it will not disturb typing. It was visible with
        slow debug builds.
        
        Change-Id: Ib73096c4b96ebfdfd038ed56234c31ff32a5cda3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126549
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127732
        Tested-by: Jenkins

2021-12-30  Julien Nabet  <serval2412@yahoo.fr>  [240b3ccaec684da6231d41309bd3aa79f139b055]

        Fix case for "ByVal", "Variant", "UCase"
        
        Change-Id: I136d292cd535d4208457ef91a7773fc7ac00d5c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127716
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [00315ee52b09cb64de268f762809c2418716f49e]

        tdf#137737: sw: Add UItest
        
        Change-Id: I54c7925d9093153ba90d9aaf9a07d7729114b700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127714
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-30  Szymon Kłos  <szymon.klos@collabora.com>  [dee44fe48ffa928ca3ef56152a7666412894f3ec]

        Warn instead of crash when mpDialogImpl is missing
        
        In LOK case we have some issues with dialogs to solve.
        Try to not crash in release but warn.
        
        Change-Id: Ic966d2b317a4e454d1d164ae36a96327c435ae6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126020
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127681
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-30  Szymon Kłos  <szymon.klos@collabora.com>  [a0f29dc3e20a9f1682dab43ea2994e281272a10a]

        jsdialog: send info about initial focus in dialog
        
        Change-Id: I9daef497cb083e863d45a2acfd7eee3ee92bdc38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126565
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127682
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-30  Szymon Kłos  <szymon.klos@collabora.com>  [4dab08d7dd70d87aa737248442a3c9fe1a68cc2c]

        lok: don't limit line length in HTMLWriter
        
        Problem:
        https://github.com/CollaboraOnline/online/issues/3645
        
        Test case:
        1. Open Collabora Online and paste "Alphabet" section from
           wikipedia article: https://en.wikipedia.org/wiki/Estonian_language#Alphabet
        2. Select last two sentences (starting from "The letter")
        3. Open Insert -> Hyperlink dialog
        
        Result: notice that some spaces was removed/converted into new line
        Expected: Text field should contain original text
        
        Hyperlink dialog uses current selection which is get as HTML from the
        core.
        In the SwHTMLWriter there is a parameter defining how long
        line should be and it replaces ' ' space into '\n' new line
        when limit is reached.
        
        This patch turns off that feature but only for getting html
        for current selection in LOK case.
        
        For now don't remove new line at the beginning as cypress has to
        be fixed first. Added FIXME in the code.
        
        Change-Id: I03b540b0b2d639a08774ecc4fc75abb7b3f0b7a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125482
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127680
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [3bf767b1312cd691d9f7d59f661f43c60998c728]

        use concrete types in chart2, SvxShapeRect
        
        Change-Id: Ibd537ed709be237e00715057c162dd9197759373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [282d9c0e1561f533090e0872be2cda28cf919397]

        osl::Mutex->std::mutex in SwXTextSection
        
        Change-Id: Iee955ab229e91ae6efca48e513380798f79ae642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [487389da0c38c9b7306c7e1f1a60d45c236816d3]

        osl::Mutex->std::mutex in SwSrcEditWindow
        
        Change-Id: I752ffe7bd1b21dba2abfec12ccdafa6610233fd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127721
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [3cb1da0e7bf86bd9bb12e3b8ace900caa4841ece]

        osl::Mutex->std::mutex in SwDBManager
        
        Change-Id: Ibcb3c3a48fea6732104b57eb07a2578d97f59c2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [d11b7cca060f0df710248697dab6659d8d3ca01f]

        osl::Mutex->std::mutex in SwXTextTable
        
        Change-Id: I863df5a6f8a9e7cefc2d546dbe17c79953bd2854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127719
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [57a58433e6a9fc7443cd3a2e7811bf508946cacf]

        use concrete types in chart2, SvxGroupShape and SvxShapePolyPolygon
        
        Change-Id: I2b86c39610f31260fe8fb5abdbb94e853ec31cec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [85fc392926ec5b74bf4328867460ea312ab0cbac]

        use comphelper::WeakComponentImplHelper in AccessibleTextHelper
        
        Change-Id: I886d510fc1ebccb058446703a64854c7854891bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127688
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [b29e3131eace8f97d705a2cd76b18e18fa982654]

        use comphelper::WeakComponentImplHelper in ChartPanelFactory
        
        Change-Id: Id81031b061981771a5f5dc91de3f5a404857164e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Noel Grandin  <noelgrandin@gmail.com>  [d26d13f49ca3ee1972588e24246bf8d1abebdc42]

        use comphelper::WeakComponentImplHelper in SidebarPanelBase
        
        Change-Id: I527098109916113e4dc25a3ae30cfe6325aa02d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [d951a054445ad3741d678f422a5b605feae06a6b]

        Use libo_CHECK_SYSTEM_MODULE for clucene
        
        Change-Id: I8b3e6ae8e66b894119784a6ac9190dee4c7ca407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127640
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ab6471861ca916eab445e6cc17a2f7f8457cb56e]

        vcl: Introduce SvpGraphicsBackend
        
        SvpGraphicsBackend contains the implementation of the graphic
        drawing backend, which uses cairo for drawing. Currently the
        cairo based graphic drawing implementation is on SvpSalGraphics,
        but will be steb-by-step moved into SvpGraphicsBackend, just like
        with other vcl plugins.
        
        Change-Id: I70c94f08c5bd1d705f2faeacb66373ddf12f494a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127702
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [ce54ba96f38b4af3aab1a7064078ee406eb021c6]

        Use libo_CHECK_SYSTEM_MODULE for eot
        
        Change-Id: I019a2047d05019b161c4f08c1d17a084a2224ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127639
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [299349ed74bae9cad9bbac9a62c4465b0972bd01]

        Further refine libo_CHECK_SYSTEM_MODULE
        
        Adds the possibility to have default-disabled externals and
        various fixed variants. The reorganized option handling is also
        easier to follow. Can't use the newer m4_case, so this uses m4_if
        with multiple compares, but the code difference is minimal.
        
        This also swaps the 4th and 5th argument to reflect the precedence
        of "enabled" over the "system" handling. And since these now have
        multiple values, TRUE was replaces with more sensible strings.
        These and the other arguments are now checked, as possible.
        
        I've also thought about dropping the 2nd argument for m4_toupper,
        but that changes to much for just a minimal gain.
        
        Change-Id: I22e835d81f9288f22d42be36e939374f7a455599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127424
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Eike Rathke  <erack@redhat.com>  [9749cabf7222dfcc74fa951e88a74dd4b301d97a]

        Use primary().anyOf() instead of yet another equalsPrimary()
        
        ... where for each or'ed expression the same nLang was masked again.
        
        Change-Id: I61d572be6f72c70d24dc56e67b950af2d2b5f767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127642
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [eef42ef32b651a9fd47edd0d8fcb650a2a058831]

        oss-fuzz: add more verbose output to build script
        
        * dump git HEAD status on build start
        * dump "date -r" and "df -h $OUT $WORK" at various steps
        * run "make clean" before autogen.sh, if Makefile exists
        
        Change-Id: I22885f820e81fa46d02699fb5c2129ac5921c5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127609
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [6979fec4c1d0d0c4c99bbf58aa4fd7d0f2be42f4]

        oss-fuzz: chain-depend all *fuzzer binaries
        
        Change-Id: Id92ae26db0c4321f1670f7bd6d8c03c521e18d93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127712
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [8ab460a050aecfd21045ffe3cd3de4f63cc2c992]

        Drop libo_CSM internal CFLAGS+LIBS parameters
        
        ... and just use *_(CFLAGS|LIBS)_internal variables.
        Requires deterministic variable names in configure.ac.
        
        Change-Id: Id3f53ca5e6189e531596265945531f4a789a035c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127638
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-29  Ramreiso Kashung  <ramreisog24@gmail.com>  [8a044b089e1ec3da3a3bc7f1a18555f7e19a4fd0]

        tdf#146479 - Use basegfx fTools for converting the angle unit
        
        Change-Id: I0436aae81d6f89f44a8da91324ac1ccaa2f107d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127300
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-29  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [c02dc02a98ff58e88cf0d6f805fcb5c2b7fb1cc7]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with Color
        
        Change-Id: I8ae4004a2c38c418a51768b135cacee2acbfca8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127678
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-29  Mike Kaganski  <mike.kaganski@collabora.com>  [bf882ec15df1ff92043293deac3bbb4a838a36fb]

        Drop VisualStylesAPI wrapper
        
        The APIs are available on all supported Windows versions.
        
        Change-Id: I3b7fddf3d3d58c5221cc6cf7492597dcb669a324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127701
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [30102143662a539a740d6a050e49fa25ccfa24ff]

        use comphelper::WeakComponentImplHelper in ModifyListenerCallBack
        
        Change-Id: I951799d31cb12f54320d8950c1a14271add05d7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127687
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [a67fc38496a7a621357cf156e17ba12bdf05b3c7]

        use comphelper::WeakComponentImplHelper in ChartToolbarController
        
        Change-Id: I21fab4cc23221a4965231e6e8c477c7a24e4b5fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127689
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [0031ca43d892cb7d0b65e957adb8f3e95d83c9da]

        use comphelper::WeakComponentImplHelper in SidebarController
        
        Change-Id: Ied30f3aaa33b6f3eb3b13c9731f9a92293fefb77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127696
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [75d7a9ef706df23d5422e53217c13d1db8929021]

        use comphelper::WeakComponentImplHelper in PresentationFactoryProvider
        
        Change-Id: Iab203714c4b500b064e8fab568cd3cebf0037fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127686
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [20f3968e412881e64a38d7545987821722180227]

        use comphelper::WeakComponentImplHelper in ShapeUndoElement
        
        Change-Id: I9f8143916441c4f48055f1f2cb902bd1ad69ca89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [f0f67a42b82ecb0e654e3e0716d194ff4cbb13b1]

        use comphelper::WeakComponentImplHelper in PopupRequest
        
        Change-Id: I199e40de2ac3215d03a90d75988a7775f87890b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [f55f46594cf43b46ed092af415a8a3af6972a7cd]

        use comphelper::WeakComponentImplHelper in RangeHighlighter
        
        Change-Id: I38d14bb253981db18885355c64accaa91c3accd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [94fbd711d0184b847ba78b70114ce9bdde04a63b]

        use comphelper::WeakComponentImplHelper in Theme
        
        Change-Id: Ia50d3919cb8a13781a43f00d102c556a82744ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [b66bc8fb918acd19ee0bd02312e7506db43d8317]

        use comphelper::WeakComponentImplHelper in svx::sidebar::SelectionChangeHandler
        
        Change-Id: I7f60374710f5768efef07ee993757558a225c111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [0c920406888f141d163ce2df01e707404f9e7acd]

        use comphelper::WeakComponentImplHelper in CenterViewFocusModule
        
        Change-Id: Ia326a78c3f96ac213a3d729e3c1deafc04f70ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127685
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Johnny_M  <klasse@partyheld.de>  [69c083b5c47196b193345af29889126411f8e05a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5b52ef051f06d12451dae02151b5869a8355a34
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7654e3273f2881c55bb7030471dfed54df1d0e06
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127630
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [048d4235338571e42117516a2df39047fe3be3b0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad3c2b4a3c77ebb2976bce2a453de2d163c54c3d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3e52f628e4485b47774a1e0572667e2f9ead656f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127629
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [1462bb4fe568a23bcaa80f88d0c5f9312eac7e03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bcf808f340e455809fad86ad77a40c7ef9ecf3c3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I864ddc5d3277cc550a4be86f160b1e2471c25112
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127626
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [3e7a548d18eb7f430bae9e1827a2cdb98e31d0e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71f7756924bb4c294f582f6c8c13c0203bfde3fd
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifc3b924267846178b30e8cdc67ef276013de0f06
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127628
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [0545b085cebf08a7a2cb34be4849890e699ba576]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cd6426394998d5c634c9777b683bdac197c70de8
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ieabbbdd36a3fbd59812078dcd7e4dd9682b35e4b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127627
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [3bac917f2ae6b4d733f81fe6b49275624804945a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 852b06d6213d508898c6b47ae43b990a3292b4b2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I91c25b34638ae47f489a6a793b1f068313a6f004
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127624
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [8b4f7a73dc1185ebf7df23ad4213848449ff09df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96366d7eb56601ff9090debe361faf02ffaea75e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib58809f5d66165f1bf2fcd42c3ebefb423535f41
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127623
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [c937be91e6a94f533ae8333bd8b8f87db1b4de37]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 978086ba1d611c4541fe82107edc9007469afc2e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia4271cd657f5ca6688ddc497d6211327cae9be14
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127622
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [7530985eb7aad1183139e74cb2a5e636a445dbea]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 29175243b1bc023c4a19359160d513b3bf88ad92
          - tdf#132643 Translate German section IDs
            
            Change-Id: I04f4e99200c949bea71993239da26640faed9c5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127616
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [ea94e61452a0d987e509e0704c799ea73533998b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 223a275c2a1f64d0584ac42b0f9e5798bf075345
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iac1262fc6d7b3deb60c5ffd650d34f07d7c90634
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127621
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [43e6f736c0b7ebf6544891426afd37b90ad8327b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 075267e4c91017db720e986b84b9ddde5ca99a2b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9c6ed2e51229811429aebb204ccd42b9e08eeed8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127619
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [3b7c491da357234b0679ccbdbc8c2ab9bcbab220]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c7408bd6bcc0682abeaa143f4e80f99e9cd1f993
          - tdf#132643 Translate German section IDs
            
            Change-Id: If678e860442b8c1947decf377a809377e0a61dc0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127620
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [7fb851f8c8b52969873ce7b69243acb75f7e1001]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff2b672d7b16f70f9c78066fd6567283d51d5345
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3851952ab34b923c42b6308be0e52af193182632
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127618
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [d21cd01c391328be06977df28e674182bf1da469]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 928fb677a668708cee67c095f07a43d2d875e49f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8d2abec69f3d8d218831781de6926d8cede90f71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127617
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Johnny_M  <klasse@partyheld.de>  [b9929fda5e47c5242ba4ba1954409f2a1c38cfed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed75133656ca68c43e561fe297745c5345296c7c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8a9423b60e7071def9fcf5c71c9beb417321ea3c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127507
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-29  Caolán McNamara  <caolanm@redhat.com>  [ab8333baee56fa20dae644c85fa29a7edb2d55b1]

        be more exact about the type of pDocument
        
        Change-Id: Iab0d23e8ee691ac6ed3381bd7e1ee02bb59dc64f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-29  Mike Kaganski  <mike.kaganski@collabora.com>  [907fd292c19868b78bcf51ae896e4daffa452ec0]

        Small refactor
        
        Use a bit more modern flags with MENUITEMINFOW, and simplify
        MYITEM destruction.
        
        Change-Id: I015e09b875fafcd287bbf45cdc20cf83d2c3e502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127679
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [2a881af4e93f8744bc6bea43f3a06fa531626c22]

        lok: no need to layout comments in writer
        
        Annotations in writer use EditEngine what caused to
        send cursor position from that EditEngine to online
        and showing cursor in the top left corner of a document
        after comment insertion.
        
        We don't need to resize/update position comment windows
        as we send only abstract description of the comments
        and later rendering is handled by client.
        
        Change-Id: I1df0e44f9500c438efd00942a372754c7fbaa170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124794
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127677
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [d434be2d76febe3302047640a4c4f1820ecb8870]

        jsdialogs: use for MessageDialogs
        
        Change-Id: Ie82558356cd9669f21afefd1ee88d769bf28eb8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124270
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127676
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [fc4b25b3dad62f9e25462e43177ad8d081f855b2]

        jsdialog: activate tabpage after switch
        
        Change-Id: Ib9f61f9e219f1775bccccdb2304cc7ce9fc8a1ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124150
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127675
        Tested-by: Jenkins

2021-12-29  Ismael Luceno  <ismael@iodev.co.uk>  [4242c7b91887236375e08e2b6b24de0cecbf1626]

        Always use <poll.h>, no modern system needs <sys/poll.h>
        
        This was standardized in IEEE 1003.1-2001, so more than 20 years old.
        
        Verified following systems using online resources:
        - FreeBSD 3.0 (1998)
        - NetBSD 1.3 (1998)
        - OpenBSD 2.0 (1996)
        - CentOS 5.0 (2007)
        - Debian 4.0 (2007)
        - IRIX 6.5.30 (2006)
        - SunOS 4.1.3 (1992)
        - SUSE 10.2 (2008)
        - Red Hat 5.0 (1998)
        
        So the check used for BSDs on vcl/unx/generic/dtrans/X11_selection.cxx
        was never correct.
        
        On GNU/Linux specifically, <poll.h> is provided since glibc 2.0 (1997).
        
        musl libc produces the following warning if the non-standard header is
        included:
        
            /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
        
        Change-Id: Ia8f4b9e1ee069f86abe03140c18a77d17336d09c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127666
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [923665ac525e8dad218724327fdbd98d4fb790ad]

        crashtesting: set document reference only once
        
        For SdtHelper we need to keep valid reference to main document
        (in our case first call), not to any of substreams like header,
        footer, etc.
        
        Change-Id: Id9d99c1a9bff9a3392eea4cc6e2abe774e5868d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127672
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [d34047e02e947bcdba555065804a2f772cdd75f2]

        jsdialog: weld Image widget
        
        Change-Id: Iaf900da5d6256b1aa441dc0dad07ba967f88b085
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123877
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127671
        Tested-by: Jenkins

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [0cb4bc34deef43dc18c73daa0344c92717115456]

        Move SalInstanceImage decl to header file
        
        Change-Id: Ic71e10a9cb296e8fed366b7dd622d8875d68f2d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123876
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127670
        Tested-by: Jenkins

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [27c815286befeb038a1b8463ba5bd45d3def3305]

        lok: hide useless insert image button in sidebar
        
        do this also in draw, not only in impress
        
        Change-Id: Iaaf2349cfb98b801957b71bd4504f0e9efbfba4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124840
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124902
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127669
        Tested-by: Jenkins

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [3365e860d44b3396a5c1dd10e3f8db9c5da0ce02]

        flatten ModuleController a little
        
        no need to allocate these maps separately
        
        Change-Id: If83f6540933716ab720778740a1e20f0bb14fd7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [eb4511f59abff5163e978c09c7188657b8c5588b]

        jsdialog: export common properties for Image
        
        Change-Id: Id01686106477cc1911fb5ec345ffcff5537e0de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123884
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127668
        Tested-by: Jenkins

2021-12-29  Szymon Kłos  <szymon.klos@collabora.com>  [673937056794da2fb96acb219d8c3dbf69a561a9]

        lok: fix formula mode after reference dialog was used
        
        m_nCurRefDlgId is a global variable which can be used by many views.
        It should be deglobalized in LOK case in the furture.
        
        For now let's fallback when we didn't get child window for
        remembered value of m_nCurRefDlgId. It fixes following case:
        
        1. opened pivot table dialog and in destination section selected
           "selection", selected a range, closed dialog
        2. tried to type formula in the cell and point any cell to add
           reference
        
        before this patch formula mode was closed, after it adds correctly
        the selected range to the formula
        
        Change-Id: I4d6756f08207f78a6033865203905bc2fed59fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123803
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127667
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-12-29  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [5fa0f02dace4538b0948bceddc23a9f55e1bf8a3]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with Color
        
        Change-Id: Ia3060a154c69be198ee12baf90cef9ef7db8e6c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126656
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [2cf9f0fe3a5da6fe53021278be88e33ad9e6e09d]

        use comphelper::WeakComponentImplHelper in PresenterCustomSprite
        
        Change-Id: I4d85620cc189fb918d0b52a569f8612c51a39f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [f5f97c7949d08c706ffb1f7a17b8bab32d2e2109]

        use comphelper::WeakComponentImplHelper in PresentationFactory
        
        Change-Id: Iff8c17951e3d17c280f47211432ee619ff188ea0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [ee6d4e2c79bd7d9b007518592f1a3ecc884660f1]

        use comphelper::WeakComponentImplHelper in sd::SlideShow
        
        Change-Id: I40f53eb70decec86564b658c3a0ebec5b44d14fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [9530816af8b178f3179deab441ea99db96e423bd]

        use comphelper::WeakComponentImplHelper in sd::DocumentRenderer
        
        Change-Id: I0eea3b1cd1e4b9a83d2227c48c687827adbb0218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [10a0f2dc50fec37a858b5e20c240cc416503019e]

        use comphelper::WeakComponentImplHelper in CallbackCaller
        
        Change-Id: I98844120f2cf6b1137a781b6401bcd45859b0689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [fda744bcc89a767ce6270e441cab9fcfda2a97d7]

        use comphelper::WeakComponentImplHelper in SlotStateListener
        
        Change-Id: I36c95472aeff208dd5f1e68c5b398635a5bfad53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [f65e44b6dd9c6dd94905996764c261dc1fc4aecf]

        use comphelper::WeakComponentImplHelper in FrameworkHelper::DisposeListener
        
        Change-Id: Ie044a38af7d65b57e7b0ce15590dc6f6cb20ce2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127654
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [140c06ce5bc049addae56c7c3de296a20042d255]

        use comphelper::WeakComponentImplHelper in SlideSorterModule
        
        Change-Id: I5acc47ba25c9dd293a21e4d634fc82eb239a7b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127659
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [37862564f3452f4bd588c0f49a200c3c9c182f2b]

        use comphelper::WeakComponentImplHelper in ViewShellWrapper
        
        Change-Id: I4684fb5ab74afb8dd8d7debe9e1ed9dceb9021e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [820ac2f6a932855ecd79f6050ab4a9064237d89c]

        use comphelper::WeakComponentImplHelper in ModuleController
        
        Change-Id: I58e716a67509560b405c6e613e0700f46a59462b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [388369ad8fad3684da03d23c850e9f4e1b7bec1d]

        use comphelper::WeakComponentImplHelper in sd::framework::Configuration
        
        Change-Id: Ib86f6da9dabac4cec43d7ee53de56972b2301c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [f030d899d8f52684b0d34bcc1f4d9864f243ce73]

        use comphelper::WeakComponentImplHelper in ViewTabBar
        
        Change-Id: If64cb90586532ee20321cfbf3dd634781a9d9a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [2d541dedde4ec516eacd7669bdc3ed8fb6fc2548]

        use comphelper::WeakComponentImplHelper in AccessibleSlideSorterView
        
        Change-Id: Id8e49fde253fd79eeae142d9fd7069fd8c3a9035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [03ce2a8ec6bdf6740bc1a54e52fc57d033060d0f]

        use comphelper::WeakComponentImplHelper in LifetimeController
        
        Change-Id: Id3d9e766fbe2f3707946c0ac2f1c25319685c515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [e833a526ba141eb7f9524f173525b177c29266c0]

        use comphelper::WeakComponentImplHelper in ViewTabBarModule
        
        Change-Id: Ie3c5f2f868cf68f2701c3cbd4bf0091894c901d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Noel Grandin  <noelgrandin@gmail.com>  [7d01e69a91250c321eb10c133684adaedf28c439]

        use comphelper::WeakComponentImplHelper in ToolBarModule
        
        Change-Id: I98caacf7ea4d994d81927e9dba6e4d46f0057f3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-29  Ramreiso Kashung  <ramreisog24@gmail.com>  [7fe2ce55ab86cc7a32850fdf504e368c535949c3]

        tdf#143148 : Use pragma once instead of include guards
        
        Change-Id: Ic9318847b387fb84af6124ad94d4340cbd57c797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127637
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-12-29  Jeff Huang  <jeff@mail.ossii.com.tw>  [8578add8775a258c79bd32f52a704ab2173bea47]

        tdf#144190 Change _Left Align and _Right Align to Align _Left and Align _Right
        
        Change-Id: Ib864f3fb960db47e0f431df6f0c2f985cb276017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127540
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-28  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [1bb0e177124d5d6661b72df6c7d848fb23639652]

        Fix autoconf>=2.70 gcc-wrapper breakage
        
        Re-generated configure file gets confused & claims not finding C89-
        compatible compiler for gcc-wrapper-building libassuan with msvc
        underneath.
        
        Work-around the problem by telling toolchain right off that this
        _is_ a std c compliant compiler.
        
        Change-Id: I4fa23673b790bc70a9294951df545c27f5236f81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127641
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-28  Caolán McNamara  <caolanm@redhat.com>  [cfbcbb605dbaaea45dc9ac5ea792d72cb2f2c1bb]

        changeTextAntiAliasMode is unused
        
        Change-Id: I421a5402f7765ebe3daa0c47b83ad7109573c1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [565a5fdee3c00b383b4d36180be845d48fd42556]

        tdf#145960 - Return type of boolean operators should be of type boolean
        
        In addition, added missing vba test to the test routine.
        
        Change-Id: I3ee837e1eab30f10e0a4169d11014f9b6574ad1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127631
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [144e2e6fc56d1d7d24dc19bc31670e28a1675a32]

        use comphelper::WeakComponentImplHelper in PresenterHelper
        
        Change-Id: I56eb9e0dc3730e2ad0af946bfe3f9494f6ff8a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127636
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [f1561065dd2178088925f45f64e6fc4cdfe72c4c]

        use comphelper::WeakComponentImplHelper in PresenterPreviewCache
        
        Change-Id: I23537d6050a4055c1d06b227722a6f6991f245cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [39e4c9c228ec7998334cffc8c451b2d6c6063b0a]

        use comphelper::WeakComponentImplHelper in SlideRenderer
        
        Change-Id: I0372899c0f1f7c9c0090e7a2392c152f6606e688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127634
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [9787eaec05eb7099d5c56bdd6d52d3e97fc5c5be]

        use comphelper::WeakComponentImplHelper in sd::Listener
        
        Change-Id: I55ae2617b7464fa2b0cad0ad53e660dee704805c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [60d8f836a33aa3bf0e7fcaa04a4d64ce3228ee71]

        use comphelper::WeakComponentImplHelper in SlideshowImpl
        
        Change-Id: I5adfe14dfb6d466f288c4ab665aa1642d8fd175f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [114fcfd8754a3996df3a346380dc3840602b398a]

        update credits
        
        Change-Id: Id193ff586cecdb483a212c8e44d438ee905736ae

2021-12-28  Dhiraj Holden  <dhiraj.holden@gmail.com>  [75705bc48e1ad5cc4a31e810f77578ce462291fa]

        tdf#139602 Added all subtotal functions to autosum
        
        For every function that is an option for SUBTOTAL that was not already an
        option in autosum (that is COUNTA, PRODUCT, STDEV, STDEVP, VAR, VARP),
        the option was added in the autosum menu.
        
        Change-Id: Ic560cd45df206dafaa2d960550aaf185a1806806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127600
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-28  Ismael Luceno  <ismael@iodev.co.uk>  [9d0568609be69a2b533d9a4bf4d03c37c15e779d]

        idlc: Always use sys/wait.h on UNIX
        
        According to (and since) POSIX.1-1988 it's always <sys/wait.h>; and all
        supported systems include it, back to 1995.
        
        AFAICT, none of the systems mention <wait.h> in their manual pages.
        
        musl libc produces the following warning if the non-standard header is
        included:
        
            /usr/include/wait.h:1:2: warning: #warning redirecting incorrect #include <wait.h> to <sys/wait.h> [-Wcpp]
        
        Change-Id: Iff1293a08ad080fdc987770596b10ef08cc145a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127537
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-28  Stanislav Horacek  <stanislav.horacek@gmail.com>  [488029489480fe6786be7b2dc1c9b38185b7e52e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 35461b4c4367cc867fd5566442dffdd98670de87
          - SF ImportFromCSVFile: allow localization of data and date format in example
            
            Change-Id: If089e461708cf483d963aae8876b386504b6e6c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127453
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [adfceaf7429a7d30c69add8f7e16a908b9a42a1d]

        inline SlideShowView::init
        
        only called from one spot
        
        Change-Id: Ib1351d91f8949c60b4c4a909e5b0672e4ac3f0f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [a354d8e9db49af08a42c62939769147065bef3ae]

        no need to allocate these separately in SlideShowView
        
        Change-Id: Ibbcdd0469b9b8c7ed7385206af40e751fe039f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127606
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [62efb188668a3296591dcfa3658185e2f982e356]

        use comphelper::WeakComponentImplHelper in SlideShowView
        
        Change-Id: I61c82bf27764d1743181b94f89981dc9f03849e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127605
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Julien Nabet  <serval2412@yahoo.fr>  [4761e11aea650dd93fbc8830ddd7c4976334105e]

        Drop FIREBIRD_SQL_DIALECT constant and use SQL_DIALECT_CURRENT
        
        Change-Id: I6731ad4c49066b197ffc5b4e5d2c482bd7ca169e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127615
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-28  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7d575c9f3db65297e4c3c6290d326ee31908ecbe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e2fd4d54e75115e3a3530e1659352fd4aea83f29
          - fix comment in Python example
            
            Change-Id: Ia83cc3896ac8cc6f383cb3ea66a36088aa755322
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127534
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Kevin Suo  <suokunlong@126.com>  [95a10c797b2d0dfc14c15ec24341437dac5e9b03]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4251a294d02ab5ae1c136b7bd90ba5c69bf8cce5
          - Fix the error message for sc error code 524 "Error: Not a valid reference"
            
            The error message on the UI is:
            NC_("STR_LONG_ERR_NO_REF", "Error: Not a valid reference")
            
            rather than "invalid references".
            
            Change-Id: I86c1bb0d950fd30654c82d80011164eec25da43b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127514
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Kevin Suo  <suokunlong@126.com>  [885106479d2e5b9fdf6b63dd90cbd757ad747044]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7b309ae9478219e6d6423b8caa94bfed7a39b0a0
          - Fix the error message for sc error code 519 "Error: No value"
            
            See https://gerrit.libreoffice.org/c/core/+/127512
            
            Change-Id: If45d0aaedf6077434c8d548324bbcb4e9b441c50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127513
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [8d15d32f71d56e9b3325a23700cddefe59f6dde5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to be4d585fabb320f67407d492ecb74218fd4c08a3
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifcf431c40f1f73215c13df88444cbb19a1fd03c5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127510
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [6ed8bda5819896f5e05e0ee4c0eb0d9d46e73c86]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3b090b5e5d89258794aa4d650b893522633838e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1d31788e998758a0561f055d6eed0e0945bd15c0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127509
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [69f9c6b6b309cfc95596d1fa03e2f27d183c192e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18d2e5fcdbae480820014edec4f57d59ce5cc206
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0914f3115627fa2bb8a9436c1904ac1b888070a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127508
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [5d2230cbb81b18823ccaec4f4050cea4dbc4097c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 309dce330d56354bca7f3fe080a58f2ca81a5907
          - tdf#132643 Translate German section IDs
            
            Change-Id: I14a58cce61fee971ec84a594ac7f6a4cba13c1e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127506
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [557ae4615c7e2ef1ca9d57c65404ca29e4374815]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e2179bc8f9d07405e797867489718cdc42ae2e9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I353f3e75d28c835a535229f14a373bc779cfce31
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127504
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [2e87a0e8ff1e6866dac1c6f387c162831566ed56]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 036021e6fcd776923e8de670a2668397d6c3ea0a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1b868da1c3cf3daa1dae3419b7b26fe9cf421fcb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127505
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [88ccc92e7328c4d5277c8e991a8d9d5da90cbf4f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8582febd0d409d68fc8b78a4f97fe3bfd3c69e82
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9a3fe59bc0351896314cfd1f3202e25c4d0ea6a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127503
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [97f5d7efd3281d742963dab5443d56352b8e0f4f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0686d6a2a0d815e67cc25eaee3345e3d0253a40f
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ia20e806b0e189450a42a8c02ed4f8cc7f1c60060
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127502
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [a9fef76172a3c2baa71e0ffb6c2ffeda3f74ac5e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80d658501844f2296f11fea50caaaab7f85ced18
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iff5b682bbf823fac27f4804647488fa674fafdac
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127501
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [dbf8a6cde1b5eaa7c0aa7fe371393e51478f17b9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0357ff5917a7257a1af082540dd9fe8a7d3f265d
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia900677e3e24bc147dce2bab3502a23e98f59ecf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127499
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [38df9b51e15c8685ad62dd76ec099235da039197]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a4fcd285e58d8754776be613893c0e24a1779b2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I05ca94bfd394e4d4b225a1f83a6ccd86e26a8fdf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127500
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [63f538f5abfcccad233e31966049b9cf66bcab75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8981a7ef20b2d27c855dac315e874a151ef7d692
          - tdf#132643 Translate German section IDs
            
            Change-Id: I20e44bec98e01aadf6cbeb7b20d7c3fe09d9b4a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127498
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [ac284452e9dab8031c1af9a24908b3cc367195c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to da95edef1f9d1ccbbe363a99ad927c93e9def1f5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I93f42cb05cfda8b16206dd507ef1069cff13dfaa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127497
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Johnny_M  <klasse@partyheld.de>  [eb0677d6aaed3020a598f2994897e65b58f5d58e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f4f309aac90ef3642cbb7aae58c9606d1e1910f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iabccc4ffaa037663c549b65adbe8ef41df133edd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127496
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [1a4310cab738076e492206ca5b38a2ecfb61d62a]

        use comphelper::WeakComponentImplHelper in sd::sidebar::PanelFactory
        
        Change-Id: Icb6cb535e0b4447635aeeb77079465d2033b6a18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127604
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [2d6db9bf6f1c2d5489f6de648df9e9c2e08c383e]

        use comphelper::WeakComponentImplHelper in sd..controller::Listener
        
        Change-Id: Idecb4bc7bf3516464ff6bd637a5c9b3bfa06ea9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [e6c7996a53691ebf2ab32f1660aeba74bc30b9c3]

        use comphelper::WeakComponentImplHelper in SlideSorterService
        
        Change-Id: Ic1fbe40e5dd3795d2fb8680772e0a0073b408710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Noel Grandin  <noelgrandin@gmail.com>  [a7d1de9dac4fdeb0594acc6e82cb4dfd1ebefc08]

        use comphelper::WeakComponentImplHelper in EventMultiplexer
        
        Change-Id: I0941e4b4beb1e549453f3a94e246160aaf63e1e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-28  Mike Kaganski  <mike.kaganski@collabora.com>  [9de3aa9328e46aed6ca7fdd9485085b7355c3e25]

        Use OUStringLiteral
        
        Change-Id: Id337f2c9cfa192663f2ddb226c786cdb9f6b3265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127590
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-12-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [9e8c1da64fa8a520730ce0aea0f7199cd75c892f]

        gbuild: announce date when acquiring the link lock
        
        Must use echo, because we're in the shell at this point.
        
        Change-Id: I576ae2afe743b11a11bc776e5fa19a1904bbd1fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127610
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [a56c68c9b14c1487f260d919859c6df66a5efc64]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d55fd06206b521062d8bb8b325b28f53e9cc8d6b
          - Silence strings for l10n in sbasic/shared (Part 5)
            
            Change-Id: I9961615c4288b3470a640ed2a4a3ec3674db7833
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126820
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [46b4899a36e42911ed361187260f7a399e8b9767]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b29d39e06a24b828e5e765de355498f0e92400f6
          - Silence strings for l10n in sbasic/shared (Part 4)
            
            Change-Id: I1f3ef4a2c4a7593258a475a87b4d64495c5763df
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126819
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [d07de10da5a47bc82e3021502fd9ef5c0f1a3f75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5fe4c2ccda3e9004aa46647d171ef431c76df263
          - Re-enable translation of strings in sbasic/shared
            
            This patch partially reverts the following two commits:
            - bba53dc2eb06941ab4e9b9c22722b22c19cd3698
            - fa7fd622849d9e31d3f27e3762b0a0e578838cc0
            
            The reason is that I wrongly silenced a few strings used in syntax declarations that should be translatable.
            
            Change-Id: I9929f2c43a611598450a05433a78ed88824d0935
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127482
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [e9173f63c47a6f0a8294722ac41877b1742def6a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9e87f321b532421614b1059e4b0ed0b6ee372c9b
          - Silence strings for l10n in sbasic/shared (Part 3)
            
            Change-Id: I9093f2b361f35fa485f9b76f0096e98d1ea66993
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126817
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [60796450cd7a7149050e46c1c9539d50a5ede9db]

        osl::Mutex->std::mutex in SwXTextDocument
        
        Change-Id: Id8bb84f04bdb6e0944e883a844448183d048278d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127594
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Caolán McNamara  <caolanm@redhat.com>  [c67705f2ffa23a02bdedcbb96178a0402eafa241]

        ofz#43008 drop ---with-system-lockfile from oss-fuzz build
        
        Change-Id: Ic50f10d60879eee0eb0bc0194f7d08b58c58266b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127608
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1606f778e4cd3d8056aecbac3d13f5858361356a]

        reduce default cost of OInterfaceContainerHelper4
        
        most of these are never used, so rather store a pointer to a shared
        empty vector
        
        Change-Id: I4736794a31237c598d1188ef42f4210ea6d3f871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [dbc411773457aeb9e740a61325845469c8b5603e]

        use comphelper::WeakComponentImplHelper in ShellStackGuard
        
        Change-Id: Ibb771041d60512ee0ca2201ecf810d0703a47884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127562
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Tomoyuki Kubota  <himajin100000@gmail.com>  [71eac37392f09f1f6f38c1a2848b7fae63eb774a]

        remove unused DECL_ABSTDLG_BASE and IMPL_ABSTDLG_BASE
        
        Change-Id: I8ba8f940cb4931974d10c8d6cf1d4fd205c18e71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127469
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d8428094c7f8b186b37c76fd7e9508a075424f80]

        tdf#144353, tdf#146281 - Correctly copy the information about variables
        
        During the assignment of a variable, copy its information only if there
        isn't already one present.
        
        Change-Id: I29fcfcd10406f2af0708a879d57e0a3c704f179e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127387
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [6fa21fba91610723a5895f8375937f4183a42ec9]

        osl::Mutex->std::mutex in ODocumentCloser
        
        Change-Id: If4f4b144842cc3d37a200b9529b0a29b6d90a5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127595
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [64aa0e462f189bf3962c3ab4ae5d5e9b0cd177bd]

        osl::Mutex->std::mutex in lockFile
        
        Change-Id: I5ebd56741568ecd25677af57e8c91389c69ddaad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127596
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [c143160737e0aa6a44f7ca23392171b55091a120]

        use comphelper::WeakComponentImplHelper in AccessibleSlideSorterObject
        
        Change-Id: I18a77111cf8285d5b66ce400624fa417fefc9e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127563
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [7ee443a6fa1a426d75c603e27114823d4c6e9137]

        remove incorrect SolarMutexGuard
        
        we are not calling anything that needs the SolarMutex here,
        and all the other places that touch mnClientId are just using
        the local mutex, which is already locked when we call here.
        
        Change-Id: I5905db1f413051966461ea3a6b75d24360903ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [73644ddc5a1c997d8dd415ac3df8f35088cc8465]

        use comphelper::WeakComponentImplHelper in PresenterCanvas
        
        Change-Id: If6ffeee67c1064da68e64748d4c30b1eef1f9116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [8e70d7a5ecd7fe96890753e02d3837067c57453a]

        use comphelper::WeakComponentImplHelper in BasicToolBarFactory
        
        Change-Id: I2c8bc3ea8226cb1145b52a37e37d6c245e9bbeee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [60649390a3a33a77649e12c2a7781e18e3bca41a]

        Fix typo
        
        Change-Id: I4591b016b087abb49de54f66eb947ba4004500f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127598
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-27  Julien Nabet  <serval2412@yahoo.fr>  [8cf970d4b3dca4f2f93fcebb8910aaeeb7ccf5fe]

        tdf#130595: Parameter query with :parameter IS NULL doesn't work
        
        Problematic SQL here:
        SELECT * FROM "Table1" WHERE "Name" = :name OR :name IS NULL
        
        Firebird considers there are 2 parameters.
        
        When providing an empty string, no pb, OPreparedStatement::setNull is called which is ok for both parameters
        
        When providing a non empty string, we go to OPreparedStatement::setString. For first param no pb
        but for second param, sql type is SQL_NULL so it must be taken into account
        See https://www.firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-datatypes-special-sqlnull
        for full details
        
        Change-Id: I80dff259d85957e8547c098e4c48b642cce26804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127593
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [03c7cd9bbe3d46bb13a5cf1ad72ba0eaf702747e]

        osl::Mutex->std::mutex in SerfLockStore
        
        Change-Id: I931e20b4b604ebd6fac83006deeabaa5939e8c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127587
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [c350c74dbd7783a5efd5ba04e937001670101243]

        remove pImpl from DataSupplier
        
        Change-Id: I0fe2d3d83c1d45abc90d22406265a034140bee02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [1308bcda6fa8d682af01b6342deb0ec47ff314c0]

        osl::Mutex->std::mutex in DAVOptionsCache
        
        Change-Id: I4798f1e4de268522fe81505181ebde5fcacda55f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [a5e9a6ddda92f8f5c80d2a10ab048f87309d5755]

        osl::Mutex->std::mutex in PropertyNamesCache
        
        Change-Id: I9af4098a30383ce695147bf7e1442769b98f6fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [bc346f7add9cad9016466788be09a66c722f9a91]

        use comphelper::WeakComponentImplHelper in BasicViewFactory
        
        Change-Id: If4f9a2ac6fb182b35787b4615fdfb5722b4948c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127560
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [9ed378edc9a3f5c3730e046fc4be72f6e0507e93]

        use comphelper::WeakComponentImplHelper in BasicPaneFactory
        
        Change-Id: I2bf00d2534bb31670998eeee65109e2e9a0d20c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127559
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [bf2b46aa15665dde63ceff4e7686b99b3990354f]

        tdf#146257: sw: better handling for list numbering = NONE
        
        Previously during refactoring were lost some corner cases with
        some level having disabled numbering. In this case LO should
        strip useless delimiters up to next level.
        
        For example, if second level has disabled numbering, third level
        should look like "1.1", but not "1..1".
        
        Change-Id: I259a16b456f51bc76d5c8360974d0acadfc36776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127517
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-27  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [bbfce0b49fb11997af8eb03d40431b6a78f2aebe]

        tdf#141908 replaced sal_Int32 with Color
        
        Change-Id: Icb9aa78035087e62c132b82bd8ab3023f31d42d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127494
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [58a750598cb064f7d9a4569e80ce91f22a87512d]

        osl::Mutex->std::mutex in CommandProcessorInfo
        
        Change-Id: I7de1e3e822b272fa4719c9113089c5e4852498ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [2a5b87316625d3f5cd735f01376c263dc40e7c81]

        tdf#146377: sc_logical_functions_test: Add unittest
        
        Change-Id: Ia844ad53ec460abeb1ef7874ad88eeac9c6bf5a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127550
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-27  Julien Nabet  <serval2412@yahoo.fr>  [abaf2b4ac7faada914885d95c49b554f576d7cee]

        Related tdf#130595: SQL_NULL means pVar->sqldata = nullptr
        
        Fix this assertion:
        0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
        1  0x00007fcc7f2b2536 in __GI_abort () at abort.c:79
        2  0x00007fcc7f2b241f in __assert_fail_base
           (fmt=0x7fcc7f418998 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=<optimized out>) at assert.c:92
        3  0x00007fcc7f2c1212 in __GI___assert_fail
           (assertion=0x7fcc614a5de7 "false", file=0x7fcc614b3542 "/home/julien/lo/libreoffice/connectivity/source/drivers/firebird/Util.cxx", line=346, function=0x7fcc614b3865 "void connectivity::firebird::mallocSQLVAR(XSQLDA *)") at assert.c:101
        4  0x00007fcc6149c715 in connectivity::firebird::mallocSQLVAR(XSQLDA*) (pSqlda=0x5bca950) at connectivity/source/drivers/firebird/Util.cxx:346
        5  0x00007fcc61470722 in connectivity::firebird::OPreparedStatement::ensurePrepared() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:110
        6  0x00007fcc614714df in connectivity::firebird::OPreparedStatement::getMetaData() (this=0x5bc6a10) at connectivity/source/drivers/firebird/PreparedStatement.cxx:147
        7  0x00007fcc6147165d in non-virtual thunk to connectivity::firebird::OPreparedStatement::getMetaData() () at connectivity/source/drivers/firebird/PreparedStatement.cxx:154
        8  0x00007fcc66694776 in dbaccess::OPreparedStatement::getMetaData() (this=0x5bc6cc0) at dbaccess/source/core/api/preparedstatement.cxx:178
        9  0x00007fcc6669480d in non-virtual thunk to dbaccess::OPreparedStatement::getMetaData() () at dbaccess/source/core/api/preparedstatement.cxx:179
        10 0x00007fcc667711bd in dbaccess::OSingleSelectQueryComposer::getColumns() (this=0x5bb99f0) at dbaccess/source/core/api/SingleSelectQueryComposer.cxx:824
        
        Change-Id: I285c9bcd0b1fd059994d339ae4d419dec516f220
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127551
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [c0dc544a853c179f6b5c0c227180c0858578746c]

        use comphelper::WeakComponentImplHelper in UpdateRequest
        
        Change-Id: I9e8030d86e892ccd6488c1b87b51eb761391b76f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127555
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [42050ccb71663a776d6bc79d3f24ea0932f1245e]

        osl::Mutex->std::mutex in PropertySetInfo
        
        Change-Id: I6db00939e9896fc2798d2eea09a7675fb9504f37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127542
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [42ac3410c0642c5c00023c3d6fb2df093af5fe94]

        use comphelper::WeakComponentImplHelper in UcbStore
        
        Change-Id: I0246fe4c93208e87bddcf08ce6423d1e8f7505d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [0f3d19d2ce953b5e2883ecb51643fd3c47bf7ec7]

        use comphelper::WeakComponentImplHelper in GenericConfigurationChangeRequest
        
        Change-Id: Iab037f7fe008dc4662f8d5b403f54c39facaa2d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [3a7e36eff37070a4626184bf0af479aef6292d8e]

        use comphelper::WeakComponentImplHelper in AnnotationManagerImpl
        
        Change-Id: Iab6dc63a9b05e096118fb948ec535269b74812ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127553
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [65dbcbfc58d55d7a7396f3c7c280afefabf34eb4]

        osl::Mutex->std::mutex in DAVSessionFactory
        
        Change-Id: I7cca2a76b9285e66f7c54deef8a6e612fd262ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127541
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [70ab33213c5d8f6fd6f58ae0115014c13224fde3]

        vscode-ide-integration: don't abuse "folders" for workdir/instdir
        
        It is for multi-root workspaces. Use hardcoded subdirectory paths
        instead. Also see commit 411e8c24a289649797c679afc084113f7f61667a
            author	Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            date	Fri Feb 12 12:29:18 2021 +0100
            vscode: make it work better when srcdir=buildir and add mac lldb config
        
        The problem it was addressing (VSCode unable to use second folder
        name that points to the same location) is still unresolved upstream.
        
        Fixing my mistake in commit 986e946d0cf3a6f61873efc09bab8c5e07c04f80
            author	Mike Kaganski <mike.kaganski@collabora.com>
            date	Wed Dec 15 14:19:31 2021 +0100
            VSCode IDE integration: add safe path for pretty printers
        
        This change reverts it partially.
        
        Change-Id: I6a6db189f587288f6eee0d9a5051bd9d8cf5a055
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127359
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [a709a654a5d6a761db836aca69c6d53244ae8817]

        osl::Mutex->std::mutex in ResultSetMetaData_Impl
        
        Change-Id: I58d67d1d52241eeb01b98972779238b7abae5a68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [8229902963404204cc3b3615c4e75aac42c56933]

        osl::Mutex->std::mutex in ResultSet_Impl
        
        Change-Id: I1c1900e94893b42a3ad4a5ef58f0cfe277305344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a235c8ddb1284757c97d92163bb6dea81ae6650f]

        tsan: fix data race
        
        WARNING: ThreadSanitizer: data race (pid=4190705)
          Read of size 1 at 0x7fddb936aa7a by main thread (mutexes: write M0):
            #0 Application::Execute() /media/disk2/libo-tsan/vcl/source/app/svapp.cxx:443 (libvcllo.so+0xa5c998)
            #1 desktop::Desktop::Main() /media/disk2/libo-tsan/desktop/source/app/app.cxx:1594 (libsofficeapp.so+0x2bcd8)
            #2 ImplSVMain() /media/disk2/libo-tsan/vcl/source/app/svmain.cxx:199 (libvcllo.so+0xa68e8d)
            #3 SVMain() /media/disk2/libo-tsan/vcl/source/app/svmain.cxx:231 (libvcllo.so+0xa6b69f)
            #4 soffice_main /media/disk2/libo-tsan/desktop/source/app/sofficemain.cxx:98 (libsofficeapp.so+0x737c5)
            #5 sal_main /media/disk2/libo-tsan/desktop/source/app/main.c:51 (soffice.bin+0x4e5020)
            #6 main /media/disk2/libo-tsan/desktop/source/app/main.c:49 (soffice.bin+0x4e5020)
        
          Previous write of size 1 at 0x7fddb936aa7a by thread T7:
            #0 Application::Quit() /media/disk2/libo-tsan/vcl/source/app/svapp.cxx:542 (libvcllo.so+0xa5ce33)
            #1 framework::Desktop::terminate() /media/disk2/libo-tsan/framework/source/services/desktop.cxx:306 (libfwklo.so+0x23c4f4)
            #2 non-virtual thunk to framework::Desktop::terminate() /media/disk2/libo-tsan/framework/source/services/desktop.cxx:? (libfwklo.so+0x23dd79)
            #3 gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /media/disk2/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77 (libgcc3_uno.so+0xd6fe)
            #4 cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) /media/disk2/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233 (libgcc3_uno.so+0xca27)
            #5 unoInterfaceProxyDispatch /media/disk2/libo-tsan/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413 (libgcc3_uno.so+0xbfbe)
            #6 binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const /media/disk2/libo-tsan/binaryurp/source/incomingrequest.cxx:235 (libbinaryurplo.so+0x1c3f1)
            #7 binaryurp::IncomingRequest::execute() const /media/disk2/libo-tsan/binaryurp/source/incomingrequest.cxx:78 (libbinaryurplo.so+0x1b6a7)
            #8 request /media/disk2/libo-tsan/binaryurp/source/reader.cxx:85 (libbinaryurplo.so+0x24ceb)
            #9 cppu_threadpool::JobQueue::enter(void const*, bool) /media/disk2/libo-tsan/cppu/source/threadpool/jobqueue.cxx:100 (libuno_cppu.so.3+0x8bf2)
            #10 cppu_threadpool::ORequestThread::run() /media/disk2/libo-tsan/cppu/source/threadpool/thread.cxx:164 (libuno_cppu.so.3+0xb582)
            #11 non-virtual thunk to cppu_threadpool::ORequestThread::run() :? (libuno_cppu.so.3+0xb729)
            #12 threadFunc /media/disk2/libo-tsan/include/osl/thread.hxx:189 (libuno_cppu.so.3+0xbefe)
            #13 osl_thread_start_Impl(void*) /media/disk2/libo-tsan/sal/osl/unx/thread.cxx:264 (libuno_sal.so.3+0x68e15)
        
        Change-Id: I2cedecfe83fef85fb79614b9a77ab9cfe47d049b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [6464be15193cd0b54b4c1b8236b99e7971311c83]

        use comphelper::WeakComponentImplHelper in UnoPolyPolygon
        
        Change-Id: I82248cfbb0cbdb765fa2f97f53e8990a9e05a28b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127547
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [e038ef76c1ef205143c853a3666fb56ca831750d]

        tdf#126269 Handle diagonal borderline better for merged cells
        
        Change-Id: I04776bbd237dc1fa881385bfe9be7f034b58e35a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127431
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [0147b132235d26931a97015fb94c13344b77647b]

        sc: clean up fods files a bit
        
        Change-Id: Ibb424d1b1d9d310bb5537098d4afd9e2a3d297cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127549
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [7dddf84e5ff0b6b75225c4fe656507be91fe1e5b]

        Drop some unused 'using'
        
        Change-Id: I306fe3b41d82dd4774b852ddb1689e74b7780d2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127485
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [aaa42c672596e5fcac684b0cefee2e72a216f5bc]

        use comphelper::WeakComponentImplHelper in WindowContentFactoryManager
        
        Change-Id: I0918d7d1ff84b4d5e41191b554d08474abce1f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127518
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Mike Kaganski  <mike.kaganski@collabora.com>  [da86317827b494affb12039b9b7c817652f7d598]

        Missing include
        
        ... after commit ad492932e9b64991001a0eb5e0aa1fa7801bb3fa
            author	Noel Grandin <noelgrandin@gmail.com>
            date	Sat Dec 25 19:04:05 2021 +0200
            use comphelper::WeakComponentImplHelper in ShutdownIcon
        
        Change-Id: I1b692522ddf0601320f1a789d9950a4825f703fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127484
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [36df4a8929149ef106a0cd844eefa01e17497250]

        use comphelper::WeakComponentImplHelper in SwXAutoTextEntry
        
        Change-Id: Idac9fbf80c69df436b3583a2022e28eeeee1721a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [e0770936a792be422aeebbece1004018e51d1eaf]

        use comphelper::WeakComponentImplHelper in SwPanelFactory
        
        Change-Id: Ia9bbd593b73c1071520f2a9cb599a7544faed1f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [dfed2ae7f25fe30441205efc704fe39532e93798]

        use comphelper::WeakComponentImplHelper in ScPanelFactory
        
        Change-Id: Ib772bffd73f6ea1984781701c5827958e7e35488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [60625112f53014b296fe3f26198408f9795ad935]

        use comphelper::WeakComponentImplHelper in ScChartRangeSelectionListener
        
        Change-Id: I1efac3114b3661ce1d65974d828af7715d5a0d74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [e056276600dc9a9e0ac649c995c3af7a42cbee4e]

        use comphelper::WeakComponentImplHelper in ScEditFieldObj
        
        Change-Id: I7e839be0685958b12760ef499bc6c71b5003fcd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127528
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [ae80ee2d722ea8a0a0e133488f829b331ca2c195]

        use comphelper::WeakComponentImplHelper in Provider
        
        Change-Id: I60e496c823ab36ee5f9775b0b758617815b85151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127519
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [6c3b3832902157324af49bca5a16cebdf5ba3caf]

        use comphelper::WeakComponentImplHelper in TablePivotChart
        
        and remove some unnecessary use of SolarMutex
        
        Change-Id: I3934d89eb75f47a6b7051a8b737dcdbeecfa0c3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [260ea19fb5e9aaa4ffff3f3ba06fc9c295be8d6a]

        use comphelper::WeakComponentImplHelper in SelectionChangeHandler
        
        Change-Id: Iab23271e69b9ae703444387ecca172361f67dfd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [d3ca7a50908b6a689129eafe45305f5a1663da30]

        use comphelper::WeakComponentImplHelper in ExpandContentProviderImpl
        
        Change-Id: I3c24b1c2eb3d44cb58709cb18de53597adf56e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [bde743f7455f1b714e3fb495ef45ee00361484cb]

        use comphelper::WeakComponentImplHelper in UcbCommandEnvironment
        
        Change-Id: Ic27f2554613e159094be4c180647c2e59f57e00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127522
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [34cbc302e3899fbacea01e27c66d3fd0bed4ac0d]

        use comphelper::WeakComponentImplHelper in UcbContentProviderProxyFactory
        
        Change-Id: I60b68c6589ce34673a2435260cd7b75c17b91a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [62a80ea77e950a4bfeb1c826856352274171e285]

        use comphelper::WeakComponentImplHelper in WarningDialogsParent
        
        Change-Id: I952924973f27387a64c8c7f48506081099592f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127524
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [0c50bf65eff7a2f7b788adb7c9afebb859a0f81b]

        use comphelper::WeakComponentImplHelper in MtfRenderer
        
        Change-Id: I54812a5db5d69a158b93ea1b89db47eb6f996ba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [ad492932e9b64991001a0eb5e0aa1fa7801bb3fa]

        use comphelper::WeakComponentImplHelper in ShutdownIcon
        
        Change-Id: I1cb6292e981948e9a1ff9ce339d037540ade9614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127525
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [26048e4f37cc0c595dc25dd07698aad82180fb3e]

        use comphelper::WeakComponentImplHelper in ThumbnailViewAcc
        
        Change-Id: I0a9aa7fac5efd8c91fdcca39882895171aeaf71f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [174b39754e45f4df0e0123336f3ed298bf81ebc4]

        use comphelper::WeakComponentImplHelper in GridColumn
        
        Change-Id: Ibadee8190f254f8af1f76a69a5671010e6dd0016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [5437632edfa35d45b3b91c818f00b8967c5a5888]

        use comphelper::WeakComponentImplHelper in UIElementFactoryManager
        
        Change-Id: I048e5671df230c498a2425d60f64208089fd044b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127489
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Noel Grandin  <noelgrandin@gmail.com>  [cfd257873a06f066b5c683bf564b3ccb3a24df5a]

        use comphelper::WeakComponentImplHelper in UIControllerFactory
        
        Change-Id: I4b583d72a1ece5af86f43be2f2add3da2779502a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127488
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [22dd44f479fe9b3c34b03ae55177c7b66170e41b]

        vcl: change Get{Linear|Complex}GradientSteps()
        
        No need to have split out the function, we can just check the gradient
        style type. However, if we are checking the steps for a metafile we can
        make this a static function.
        
        Change-Id: If0524567ec5974db92aff928e0733ab746ecbeba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127029
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [1de7e1f4640bad725626b574b33eb2db9244f378]

        vcl: remove unnecessary actions from DrawGradientToMetafile()
        
        It turns out, we never actually needed to decompose the gradient into
        seperate actions in DrawGradientToMetafile(). We still need this for
        AddGradientActions() however.
        
        Update tests and add new ones for AddGradientActions().
        
        Change-Id: I2115da8e7d1efa5bcd2a8f4f00d9678216549e4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126846
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [06230ac3a62c1cc4012e4d8d0a76f9db356911a9]

        oss-fuzz: also build libxml2 for the cross-toolset
        
        Change-Id: I777975446d8f1901445100144baac79b7db2b1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127535
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-26  Mike Kaganski  <mike.kaganski@collabora.com>  [9c95415de877af1430ab5b7123e11dedd0ea622c]

        Let comphelper::Base64::decode* take std::u16string_view
        
        Change-Id: I5b04f7adf11c61f52b7bfb0f52c8c075f838f0f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127480
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-26  Mike Kaganski  <mike.kaganski@collabora.com>  [a23a7eea5cfcdc50d09be248828cb1e6293e5ebb]

        Avoid OUStringBuffer::toString where possible
        
        Change-Id: I99abbe97a48b2077e28d6221fb70036e5e412657
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127479
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc517c687de7205487936d40b64481107656f239]

        fix comphelper::WeakComponentImplHelper::query
        
        Which was not hanling queries for sub-interfaces.
        
        We need to copy the complicated query function from cppuhelper,
        unfortunatly. It has a signature that includes the base class, so we
        cant re-use it.
        
        Change-Id: I3668abb67c6cb669086ce32505b383ac11d3c3ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127511
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Julien Nabet  <serval2412@yahoo.fr>  [de47e94bf8468d0da4b39c6dab1281e750e6c426]

        Typo: insertHierachyElement->insertHierarchyElement
        
        Change-Id: I1e1114c77d4d8bbc9e1d927a2e8604981b1db7b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127516
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-26  Kevin Suo  <suokunlong@126.com>  [5d56a2301ca00b21dff110b0f11677cf80dff04e]

        sc-error-codes: STR_LONG_ERR_NO_VALUE should be "Error: No value"
        
        rather than Error: Wrong data type.
        
        STR_LONG_ERR_NO_VALUE was marked as "Error: Wrong data type" in
        the source code. It was translated in the en_US UI as "Error:
        No result", which seems to be intentionally. This causes confusion
        for other languages.
        
        This error code is used for case FormulaError::NoValue and this
        FormulaError enum entry is used in various places, most of them
        indicates that it is used because of no value is returned.
        
        "Wrong data type" should be a reason why there was "no value"
        returned, thus "Wrong data type" should be a subset of "No value",
        but anyway STR_LONG_ERR_NO_VALUE != "Wrong data type".
        
        Change-Id: Ie0e355ba02e9800fca2263744ed74ada700bfbeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127512
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-26  Eike Rathke  <erack@redhat.com>  [1c14b9efb0677dea65ff220222fbb8d5c2aa6973]

        Resolves: tdf#146377 Propagate condition error of IF(condition)
        
        Previsouly a given ELSE-path was executed as the condition is never
        TRUE on error, which wasn't significant unless the ELSE was an
        error evaluating function like IFERROR() or ISERROR() or other
        IS...() functions.
        
        This changes behaviour of an undocumented side effect, so *might*
        break existing expressions that (unwillingly?) relied on it.
        
        Gnumeric, Excel and GoogleSheets all agree on propagating the
        error value as implemented now.
        
        Change-Id: I0905a363be7a3b02925f1c41b4e6c8d36f12df93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127515
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [16506994ecef4bd800575beb9f2b66eb16d902fa]

        can use OUStringLiteral here
        
        Change-Id: I1e71a35c2ce6bc7ef3081054e51494411d9a29ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127491
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [7313b9ecf2285768563d82c19715d34b7c66d5ef]

        use comphelper::WeakComponentImplHelper in SvXMLEmbeddedObjectHelper
        
        Change-Id: Id574f7a1ff54fae4a76bcafb011b9a80b5f35232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127407
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [56c233961f3121f45448fe06104c36fe3bf92f4c]

        no need to store 3 different refs to the same object
        
        Change-Id: I025719a9682cf0f0a6e3773362fe37d80fddb1ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127490
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [8566b3f8d2c89ac408e5a66335f978848bfc9e9f]

        use comphelper::WeakComponentImplHelper in StatusbarItem
        
        Change-Id: I2c278547d16c5ad0530188f1e465cb784d345746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [a839a6afada46b44095be184548f6fa75d80e961]

        use comphelper::WeakComponentImplHelper in UICommandDescription
        
        Change-Id: I042c9761c60d3b1c39950cfede80958edf2d84c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [92c0775f2fa4f90ef9a19cb1d466e6bfec3dd9f0]

        use comphelper::WeakComponentImplHelper in SubstitutePathVariables
        
        Change-Id: I1b41ae57b65b42ef63d2d2c026cf78a00b5b937d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127462
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [2d1ed93e46e01f575b3f3755bf9f5da0d6f370ef]

        use comphelper::WeakComponentImplHelper in TaskCreatorService
        
        Change-Id: I2414ef01bc0990c68bb6fa02a897bfa19d7982a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127463
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-26  Noel Grandin  <noelgrandin@gmail.com>  [058c64ad17ef8ed0d7f583a804368aa8d0071e59]

        use comphelper::WeakComponentImplHelper in WindowStateConfiguration
        
        Change-Id: Iada515ab1926aa1e0b7a3f39690d7c6eebf28aea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127465
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Mike Kaganski  <mike.kaganski@collabora.com>  [9f5188173a4a37a9d41ee90a5555874f1f17136e]

        Revert "Init WeakComponentImplHelperBase::m_bDisposed"
        
        This reverts commit c1f21a6ce6491ac82a022502c618e2758d3b3a31.
        
        Reason for revert: a better fix is implemented in commit
        f0c0c62c10e4ffdb9ce44202e2540d2f39a9fcb5
            author	Noel Grandin <noel.grandin@collabora.co.uk>
            date	Sat Dec 25 11:43:11 2021 +0200
            uninitialised field in comphelper::WeakComponentImplHelperBase
        
        That change allows to keep the ctor implicitly defined and inline.
        
        Change-Id: Icb8064ebc77d4120d279d30df5de4ebee5479b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127474
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Eike Rathke  <erack@redhat.com>  [4674ff347cd2e71445503efdc0c110d094daa80b]

        Related: tdf#146377 Let AND(), OR(), XOR() propagate the current error, if any
        
        ... instead of forcing Err:504
        
        Change-Id: I7e91671ffc61bf82d9095378656b41981040f55e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127492
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b7acac77f5bff97b3d525507a64c3d6bea8b43e1]

        Colibre: update Save related icons
        
        Change-Id: I01542908edf1d855fe723e0a7818cd05297f49aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127457
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [5e528165e2e6026d2d1ba3386f2b45544c0c6ab1]

        Colibre: update Save related icons part II
        
        Change-Id: Ic2bbd21ae12d8465cc8ba1f6429e0c516f6dbc59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127458
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [d4257daba1155ebccbfebea99bad0e4152ca9b08]

        use comphelper::WeakComponentImplHelper in MenuBarManager
        
        Change-Id: I687f71c5af810618b3ab27b004bf765b53d7b8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127466
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [98dbe250d7d5e3ebe626e8c8650e7fdccd399869]

        use comphelper::WeakComponentImplHelper in ContextChangeEventMultiplexer
        
        Change-Id: I6f8c2be817695e44b25f209a5a56e021cd3e94d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127487
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [752052cb1ff82949183cea59ca18683266c7b4ff]

        Convert i18npool_LD_RULE template to pattern rule
        
        No need for various, evaled custom rules. A normal pattern rule is
        sufficent for this task.
        
        Change-Id: I4f7ad0cafb7fe78fc161eab54bb3170003c83ade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127325
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Mike Kaganski  <mike.kaganski@collabora.com>  [be5f70e2b8498345f2301598cba325d5524513f2]

        Simplify INetURLObject::parseHostOrNetBiosName a bit more
        
        Change-Id: Ie22e7a142aabd2c0f12c34945ad0858f5bd868a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127451
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [a7a1d8647a8e03675746d4cbbcf707422f4db888]

        use comphelper::WeakComponentImplHelper in ModuleUIConfigurationManagerSupplier
        
        Change-Id: I22164080dd87ab3c3a93b50d06cba8574e00c189
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127464
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [37106f20bd5cc016a473fbdb2e9e37da096cff5f]

        oss-fuzz: convert to static cross-build
        
        This way we can get rid of the pre-generated locale data and the
        special fuzzers target, which invokes a full gbuild make for
        every prereqisite, always parsing the whole tree, taking ages.
        
        This also reverts:
        - commit d0780b21cfe235c4446adf649eb690f9c1771dd5 ("fix oss-fuzz
          build") by adding epubgen and revenge dependencies.
        - commit ff25d6a123beb42476bf42d189b3033a86835b2a ("ofz#41602 fix
          more build failure"), which shouldn't happen anymore since
          commit d47628f287f4377394c4ff488c433bfe254b6abe ("don't want to
          link to system static libs for DISABLE_DYNLOADING")
        
        Change-Id: I3aed9ec62da507254b42e4e7470bae1097b4bc8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127031
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [fa5db38ae5bbe9abfd41b6765074ca1200b8def2]

        oss-fuzz: fix some compiler warnings
        
        Some unused functions and variables and many missing
        HAVE_FEATURE_NSS warnings, because the native-code.py
        stubs were missing the config_crypto.h header.
        
        Change-Id: I88ff7d8f96e7382027a21f205db982fd797bd6af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127392
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [35267be7ce33c5203a76e8023382c287b2e1f180]

        use comphelper::WeakComponentImplHelper in ValueSetAcc
        
        and remove unnecessary use of SolarMutex, the fields
        are already protected by mutex and the locked region
        doesn't call into vcl.
        
        Change-Id: Ia010674b14fafe2bfac27956af71fb557a4df212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127408
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [eb400749a3c193ff53617aca3cd2baab9a5d0e05]

        use comphelper::WeakComponentImplHelper in TableDesignStyle
        
        and remove some unnecessary use of SolarMutex, when accessing
        static data.
        
        Change-Id: I4cd489d89be71df09f34602d05feb40855dc1567
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [c70271ca5ba26718cfbc621d08c53acb5e1da4b4]

        oss-fuzz: use fuzzer_statics for default statics
        
        Change-Id: I3616507127e0661635d87ba2b949ddaa13bc898d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127454
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d16cb4dc76aab319097617ebcfc7874c41734c01]

        Colibre: various icon updates
        
        Change-Id: I1a0d0d8669597f50c4105b055ad91a1f629484e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127456
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [c68c744b68fd50adb6ce725bf9de377a5f915dab]

        pass unique_lock as param in WeakComponentImplHelperBase::disposing
        
        so that subclasses can drop the lock while calling listeners
        
        Change-Id: I6105438110af08f10b0ed50057b28172c3442b95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [f0c0c62c10e4ffdb9ce44202e2540d2f39a9fcb5]

        uninitialised field in comphelper::WeakComponentImplHelperBase
        
        Change-Id: I7ab702c0dd61231b334aac647e87233095cc69e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127450
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6e968d18951ff0c27d2aa7aa2a34f8d78634023f]

        Colibre: update Undo/Redo, adjust Wizard & Clear Direct Formatting icons
        
        Change-Id: Idd604c2cb3d80b2e46dab0fa189194372c49f56a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127452
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [c1f21a6ce6491ac82a022502c618e2758d3b3a31]

        Init WeakComponentImplHelperBase::m_bDisposed
        
        From the Jenkins_Linux_Ubsan TB:
        
        /comphelper/source/misc/compbase.cxx:20:9: runtime error: load \
            of value 190, which is not a valid value for type ´bool´
        ... in comphelper::WeakComponentImplHelperBase::dispose() \
            /comphelper/source/misc/compbase.cxx:20:9
        
        Maybe also the problem breaking Java for the Jenkins_Linux_Dbg
        since the comphelper::WeakComponentImplHelperBase patches
        went in.
        
        Regression from commit 252dd254b5b29298457b889623783152e9bed534
        ("new comphelper::WeakImplComponentHelper").
        
        Change-Id: Idebf6dfcc051f8fcb4cde1fb66d40b38e6f9dddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127449
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [3454055d4da3326540905fc69626b934d5aa0744]

        tdf#145090 LO Calc Crash with drop-down-menu
        
        avoid attempting to call into widgets while in the middle of dispose
        
        regression from
            commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac
            IsDisposed->isDisposed in vcl/../window
        
        Change-Id: If346dc9dc8547f8da28d091bfa20eff39162a0b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127437
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [f5ba1d0aa5850d5c2a2e267c89ad60885144ae28]

        osl::Mutex->std::mutex in SvtPathOptions
        
        Change-Id: Ibf0aef2116e6ee7ab1cdc0de2b2bb502a8ce05e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [ebdc45cda44618c4f165f01de2a5466ee6fb2242]

        no need to take SolarMutex in TableDesignFamily::createInstance
        
        the constructor doesn't actually do anything other than allocate
        memory
        
        Change-Id: Iff437111018a6025d3aa02c350f67983bc64b08e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [9660c79a7933a6ae123d5760c123dd71851b9ff5]

        Colibre: tdf#146410 update Clone Formatting icons
        
        Change-Id: Ia331ffb5381a8aa077755a68f74587a6e0105ca7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127448
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-12-25  Arnaud VERSINI  <arnaud.versini@pm.me>  [7a6fb939053f0c4f5c3e653fe4b21bc2d904d7dc]

        idl : remove useless define and copy the code directly !
        
        Change-Id: I92d53beb110a44624b72f7ec76ab8d1089f9caf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127438
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-25  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [57415c0f65478a699182e90ccc3b71e3d53a9a22]

        Colibre: update graphics/image related icons
        
        Change-Id: I8f61a8332d1be1a2a5cbbd3e96c761314cc6b369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127447
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [870a3b5bc34d5d4082b46940822d871106cac2d9]

        osl::Mutex->std::mutex in CEvent
        
        Change-Id: I644ebf86803448e824818f571d6612741408d02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-25  Noel Grandin  <noelgrandin@gmail.com>  [8d17c555ad913b787927ab327586965c04048505]

        osl::Mutex->std::mutex in OTempFileService
        
        Change-Id: If841031faf5b214a1978422b93b59cfa32fcd299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Jim Raykowski  <raykowj@gmail.com>  [9bfc42015acd6ae3475ab7927ccc006507cc38a2]

        tdf#146003 tdf#106613 Draw: fix slide rename not updated in Navigator
        
        Change-Id: Iee2d34e3192e3f7875ab10f3e79e9dc1a2fb20b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127397
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-24  Mike Kaganski  <mike.kaganski@collabora.com>  [132d652ad1af4ec067fe08e388e8ddba963ddc2b]

        Simplify INetURLObject::parseHostOrNetBiosName
        
        Change-Id: I18818e89b2e6f0ef203caa51ba554c281753d3f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127383
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-24  Mike Kaganski  <mike.kaganski@collabora.com>  [8b333c76945960fc62a01829666ba234f59a6d94]

        Use rtl functions instead of own surrogate checking/combining
        
        Change-Id: I3eb05d8f5b0761bc3b672d4c855eb469f8cc1a29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127375
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [fd4acfaca9fc012313f03f46e927add6feb6a553]

        osl::Mutex->std::mutex in SvtModuleOptions
        
        Change-Id: I6882b30c823d06aa04c04c8a17bfe33cc45d7307
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [addd00fefe246e3045380e97e9a66a39a23ecb4a]

        use comphelper::WeakComponentImplHelper in SvXMLGraphicImportExportHelper
        
        Change-Id: Ieb76e57ac8c9e2f456e5d7d2c127668d5f2b8490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [439cb9d60d853b9521def7931a68226b95de48a8]

        use comphelper::WeakComponentImplHelper in ParametricPolyPolygon
        
        Change-Id: I923970389870ced5e8e310c0f73859117b1cedb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [1576ef8532cf2cea2da361db9c5707f1994e65e2]

        osl::Mutex->std::mutex in SvtCommandOptions
        
        Change-Id: I80eaba645351e2f3a3c67586fdced3325608633e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127413
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [d94db4056a49fc4fee73173e1ef1c943f8ecc21f]

        osl::Mutex->std::mutex in SvtPathOptions_Impl
        
        Change-Id: I04d0bf2a6b00ab0da24735158ad267632356128f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [03faef951a0dd4352a371ead89ca79040359234b]

        mergelibs: fix duplicate aSfxInt16Item_Impl
        
        The callgrind / mergelibs build fails with:
        
        /svx/source/form/typemap.o: in function `aSvxColorItem_Impl´: \
           multiple definition of `aSfxInt16Item_Impl´; \
        /sfx2/source/appl/appbas.o: first defined here
        
        Regression from commit 60d7796624f1c56eb036d3e73d7f8a8216cce2a4
        ("sd theme: allow setting color effects in the sidebar").
        
        Change-Id: Ibe382e2e12d3359caa3e853e264de0ede6a5e601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127429
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [ac511d90cdf9d28eb8809c30be9fa08b42ea0bd3]

        osl::Mutex->std::mutex in SvtUserOptions
        
        Change-Id: Ib16cc05a8d9c3e7ef828223e8b1067eeb7faf809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [4621e719c283cb24ec6b884b55a6719a321336f3]

        use comphelper::WeakComponentImplHelper in SvXMLGraphicHelper
        
        and remove unused disposing() override
        
        Change-Id: I6423d9c3c418bb07f84e1622c8df6eac8ad762c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127406
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [69b6c87eca7d7fa1e83653750e79e04ae1d5d384]

        autogen.sh is actually in $(SRCDIR)
        
        Change-Id: I9c58294fb607683929d370a5f2707901e2a88548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127421
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [6bed8aa4462ac553921392533be646ef26f7b9e7]

        Re-run autogen.sh on m4 macro change
        
        Change-Id: I8cd1203bcdf1b98bb34c0fd1ec38ad3f6af0eaed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127422
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cf6976280f5371c01251c0ffce206535433207a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 215707177c272f9fcf73a79b9150fe677b991716
          - Refactor database files
            
            Change-Id: If6acf26ea094234d06522c26c8bb8274c0abdaa5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127430
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [a3af03ec84ff5e8a89ccfa6fb2350eec6f09883c]

        use comphelper::WeakComponentImplHelper in ChildrenManagerImpl
        
        Change-Id: I24b1f497a77b7ff896060a8f7dacc5d3a5e27ea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [c55d1affc6299feed36145a01279b641bb60ac57]

        use comphelper::WeakComponentImplHelper in PanelFactory
        
        Change-Id: I936fd58fdb626d6707cf672f188cd8570269bc44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Arnaud VERSINI  <arnaud.versini@pm.me>  [82807f810b3300111820e9b2fa9a82e3e35a313a]

        bridges : remove redundant public
        
        Change-Id: I836412674448acb2a047d3d8b4711fa8d0b67257
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [b0163975efc6924c154793590a759784ffa77d08]

        osl::Mutex->std::mutex in OCipherContext
        
        Change-Id: I0a457dc8ddccc0fce42032956aff6d661d1ae80a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [c5a0bcf94403a29490d707ae1878fba3e0423d13]

        use comphelper::WeakComponentImplHelper in EditBrowseBoxTableCellAccess
        
        Change-Id: I36a1dd4fa488517a1e69d3a1c4b03c850d1a933e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127404
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [d1e270557a62bfe81f63a72b6802a11eff9e047d]

        use comphelper::WeakComponentImplHelper in PrimitiveFactory2D
        
        Change-Id: Iead37062710d64705fca2d00404922b3ad3b6f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127409
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [166e2a09052b8adb0525cc3a50b8b7cac0bbe6f1]

        rename some methods on UcbLockBytes
        
        The Impl suffix means internal methods, but these are part
        of the public API of the class
        
        Change-Id: I9c969f3464e0ae78d52f997643f7fb8489b7bd61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [15bc492281111997a5da556961b923bb607642b6]

        tdf#146382 cant open file from Explorer-attached remote location
        
        problem spotted by mikekaganski
        
        regression from
            commit 0b46361ef84a61100a0274a007062317607d097a
            Author: Noel Grandin <noel@peralex.com>
            Date:   Sat Nov 20 08:03:49 2021 +0200
            tdf#133835 speedup calc autofilter (4)
        
        where I changed the behaviour of parseHostOrNetBiosName from overwriting
        the destination buffer to appending to it.
        
        Change-Id: I1bd3c7eade035a867c026364f5e114c1e652ca32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127352
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [ac5d7288ce9ec08e3bfda3c4803ce736c1527568]

        use comphelper::WeakComponentImplHelper in JSDropTarget
        
        Change-Id: I40f8090e0c24a29bdb310183981187997696f8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Rene Engelhard  <rene@rene-engelhard.de>  [e31191d45c27965bb1a73577b9fcc99b5d88795a]

        bump liborcus dependency in pkg-config check to >= 0.17.2
        
        since that is what is needed now since aadbac5467bb6ab768f87ed6ec003c55159d54aa
        to make the tests pass.
        (One could do a version-check like done with libmwaw etc, too, but
        didn't follow that route)
        
        Change-Id: Id70871104b5c12462db12f14b637c6884a98954c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127144
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [5e6d6be86bf29896e030af5c0f770f2b389d7e8a]

        tdf#146132 tdf#146327 tdf#146330
        
        regression from
            commit fe6a140a537eda1b6703c44ff5ee49d2ba875b81
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Dec 7 14:55:13 2021 +0200
            used cache value in ViewObjectContact::getPrimitive2DSequence
        
        Unfortunately various things like scrolling/zooming/moving item
        to new page do not seem to invalidate the VOC, and I can't
        track down the right place to do that, so just revert.
        
        Change-Id: I8009c99417f634b26adc770b6d6d2eb6969d9629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Noel Grandin  <noelgrandin@gmail.com>  [252dd254b5b29298457b889623783152e9bed534]

        new comphelper::WeakImplComponentHelper
        
        to replace the cppu:: equivalent with a lightweight version
        that uses std::mutex instead of osl::Mutex
        
        Change-Id: I1b7873a0c2d9cda21f529e43a4ac2fa7574c91a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-24  Jeff Huang  <jeff@mail.ossii.com.tw>  [54115790926a5964534472dff7e4661ea34acb28]

        tdf#140726 Change func func(<?>) to func <?>(<?>) in Math
        
        Change-Id: I9b28097c0043c7c6daffb047683b6af1f0202223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127393
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-24  Aron Budea  <aron.budea@collabora.com>  [fa9ab05d78bb398efa3c09148e9d6d717f6168d1]

        python3: fix build on Win 10
        
        With Windows 11 SDK (10.0.22000.0).
        
        Error message is:
        fatal error RC1116: RC terminating after preprocessor errors
        
        https://bugs.python.org/issue45220
        
        Applied fixing patches to 3.8.
        
        Change-Id: I0860b05fd963ea81b493a4b9df7f39db86598dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127395
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [5fe088133442cc77e747ba5fc97ccafbb08f342d]

        Fix Test::testTdf97663
        
        Unfortuately the build and merge of
        
        commit 4e2e57b530544736804ab663f832173ba1d78559
        ("tdf#97663 SVGIO: Fix line spacing for <tspan>")
        
        overlapped with the merge of
        
        commit e3bd776e020723ad8caf0a02d8db0d19e0f0e650
        ("Split BasePrimitive2D UNO interface into separate object")
        
        Change-Id: Iaa7c4ffda7d863a2571c7f8320889b668f82a844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127394
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [a4c21026b5bafc755466ccb114a8f53169081c97]

        Re-allow SCRIPTING for the cross-toolset
        
        The commit message already described the need to allow scripting
        in the cross-toolset for the special Java case, but nethertheless
        it removed the SCRIPTING from the permitted BUILD_TYPE filter.
        
        Regression from commit fb308c193bc9f0d07ad2cccd5a0b239f86cbe442
        ("Fix --disable-scripting for DESKTOP build").
        
        Change-Id: If794860e9f3a47332ad6c26f893277afb220d733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127391
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [e07c8e6e617f0e30a2de134e53509a31b7b07bf3]

        Fix some forwarded cross-build options with spaces
        
        I forgot about the problem of quoting variables with command
        options having arguments containg spaces to pass to a subcommand
        in shell scripts. AFAIK there is no way to handle this correctly.
        
        A possible workaround might be to create a temporary shell script
        with the correct quoting. But I'm just aware of the $with_theme
        and $with_parallelism variables to eventually contain spaces, so
        just handle them separately.
        
        Regression from commit c0c937d1ff2a47c55b597e10c0f0055e5bfda7e0
        ("Echo cross-toolset configure options").
        
        Change-Id: I56f777bdc24210726997afcd9d22ddfe3580f4e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127390
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [ecc50f56b3282ec3b0364101d860f22fe8da9042]

        gbuild: set library dependency for static builds
        
        For DISABLE_DYNLOADING builds, all libraries become real and not
        export-only dependencies. And all real linking targets need a
        dependency on all static libraries.
        
        Change-Id: I8433a0225d428951739f7afa3068a61dce9e61eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127236
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [af4c5d3ea1ec5d140b9477feea2cb9487977a6c4]

        Enforce cross-compilation for static builds
        
        ... AKA DISABLE_DYNLOADING, except for oss-fuzz, which will be
        converted to a cross build in a follow-up patch.
        
        This includes skipping the static registry and help tooling and
        aborts configure when the ODK is selected to be build.
        
        Change-Id: Ifae32e91acf5e9ffa234d8f915ee459b197091fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127287
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-24  Hossein  <hossein@libreoffice.org>  [4e2e57b530544736804ab663f832173ba1d78559]

        tdf#97663 SVGIO: Fix line spacing for <tspan>
        
        tdf#97663 is a regression caused by the commit
        701324a1e1f7e0c181ff1a50956ced686785ea53. The previous patch caused
        LO to forget the size of the font which was needed to calculate line
        height based on em units.
        
        em, px, pt, cm, in...
        https://www.w3.org/Style/Examples/007/units.en.html
        
        Accompanied with this fix is a unit test provided to avoid this
        issue in the future.
        
        The fix can be tested with:
        
            make CPPUNIT_TEST_NAME="testTdf97663" -sr \
                CppunitTest_svgio
        
        The em_units.svg is opened with Firefox, Chrome and Inkscape and the
        rendering in LibreOffice is compatible with the rendering in these
        applications.
        
        Change-Id: Idaecd9fb18101f7925fe2a917f7fc3fe7257ebc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127130
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-24  Gabor Kelemen  <kelemeng@ubuntu.com>  [fbe169fa17adb832704ada89ae6d889ad31ae502]

        Recheck include/[s-x]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: Iaebddd648c52c175da17d2a55a1e8de82c213f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127330
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-23  Jim Raykowski  <raykowj@gmail.com>  [1609bb6ab5e34fc8fff67240e3c49dde93f2d2d7]

        Outline folding: check pointer before use
        
        Change-Id: Ifa79ef5f286da77fdac9464b4e271021107bf34e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127348
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6acff3b34ce07f88fc469ace05eefa36056a0328]

        CppunitTest_sw_uiwriter3: use assert equal instead of !=
        
        Change-Id: I27666c608b4265dd7fc515958c59f18d5b977796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127358
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-23  Michael Stahl  <michael.stahl@allotropia.de>  [2954039767e1adab7a65838b61a449b701f244a4]

        tdf#138743 sw_redlinehide: delete FlyFrames when hiding tracked changes
        
        Cannot remember why but when RemoveHiddenObjsOfNode() was added in
        commit 464ef392f901c6e2ad3d32df8b039f2226073cf4 only as-char draw shapes
        were removed from the draw page, but as-char fly frames remained.
        
        For these only a barely visible border is painted sometimes, but the
        problem is they remain as a mouse click target, not sure how i didn't
        notice this earlier.
        
        Somehow image painting is wonky on current master, works fine on 7.1.
        
        Change-Id: Ie4e20f6a399daadda1badf155ba510445394f5e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127366
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-23  Caolán McNamara  <caolanm@redhat.com>  [c13db6e792cc347ffff4585f23866f195651f21f]

        ofz#42868 fix fuzzing build
        
        Change-Id: Ifcdc302d6aee121f5b889b2a02a47b333d23069f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127388
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [f4ab9cf69c3b1e9f17fc3873f160ddebd5f812fb]

        CppunitTest_sc_subsequent_filters_test2: fix test depending on current year
        
        While at it, move the file from ods to fods
        for better tracking in git
        
        Change-Id: I16df221e3a7341dc7c53de6130158c3887c472a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127361
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-23  Stephan Bergmann  <sbergman@redhat.com>  [f02dea373c8162bbec5a6e0e60b74ffbd107f1a9]

        Adapt .gitignore
        
        ...to 8d7e266943447a97ad09caebc263f3b2d6abdbde "provide a 'make
        vscode-ide-integration' target"
        
        Change-Id: I16a7ba8acc66c3765f29f2235c173fb6853c82be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127357
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-23  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8f6c5861a107a01234e6a0500c9bca4b03df926e]

        vscode: set editor to not show newline at end-of-file as empty line
        
        and also tell it to always add newline at EOF to be consistent with
        traditional editors like vim and others
        
        Change-Id: Iba7e9a3778229c72c06981bd95460980f8c4e9d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127333
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-12-23  Rene Engelhard  <rene@debian.org>  [46ebf8c0ad191f9d9d94c898475dd953fb48d9fd]

        work around off-by-ones on i386 in uicheck uitests...
        
        <@x1sc0> _rene__, I guess we could use assertAlmostEqual with delta=1 there,
                 but maybe once we add it, the next assert also fails for you?
        
        Change-Id: Ic64641ccdf9ca721997b4a842b646cf4b9e30f16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121641
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins

2021-12-23  Noel Grandin  <noelgrandin@gmail.com>  [e3bd776e020723ad8caf0a02d8db0d19e0f0e650]

        Split BasePrimitive2D UNO interface into separate object
        
        Rather than make all the BasePrimitive2D classes bear the cost of being an UNO
        object, we just wrap the top level BasePrimitive2D in this class when we need
        to pass them over UNO.
        
        This reduces the locking overhead when doing normal drawinglayer operations,
        and reduces the size of drawinglayer objects and the cost of initialising
        them, which shaves 5% off the load/display time of a large barchart.
        
        Add new drawinglayer::convertPrimitive2DContainerToBitmapEx utility
        method to avoid needing to convert to Sequence<XPrimitive2D>
        
        Change-Id: I553eaa4c16ba016b098cb21f6c55f5008f0d9b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126487
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-23  Mike Kaganski  <mike.kaganski@collabora.com>  [be596c0192f059324d06716b625be6a11079f8ea]

        Nullify passed pointer in releaseDecimalPtr unconditionally
        
        This was an implementation error ever since it was introduced
        in commit 79d3bc479950127ecfd40f73978c0fc84c1e7908.
        The function is used to release the refcounted object, and the
        calling code does not always set the pointer to another value
        or discard it (see uses in basic/source/sbx/sbxvalue.cxx). If
        it resets the pointer in some cases, it must do it always.
        
        Change-Id: I17de412914935082d20f2a1a91ea6e4e289936aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127254
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-23  Michael Stahl  <michael.stahl@allotropia.de>  [657de5fba12b0e9afcdee361654d2a2d0dbd7311]

        Revert "Revert "sw_fieldmarkhide: init fieldmark mode from options""
        
        This reverts commit 70dd95aabd11b2146e2556c1da87da4a22d6f7b5.
        
        Looks like we might get some time to fix bugs.
        
        Change-Id: I7038c5e854676e2540011dd2a8dcfb8870788502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125558
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-23  Michael Stahl  <michael.stahl@allotropia.de>  [d11fb6cecaf72787973990e09cc7e8d03bdbf9d7]

        tdf#138771 sw_fieldmarkhide: fix overlaps in SwScriptInfo::InitScriptInfo()
        
        For sw_redlinehide, the MergedPara::extents were guaranteed not to
        overlap with the MultiSelection aHiddenMulti in this function because
        CalcHiddenRanges() took care to remove deleted redlines, but now extents
        may be created for fieldmarks and it does nothing for fieldmarks.
        
        Fix InitScriptInfo() to handle overlaps between extents and hidden
        ranges.
        
        (regression from c0864f26f3143ea81c65d3826fae32a8fd54c531)
        
        Change-Id: Ic7aa432e1b5b960f3a865176cf9dbc096b2cfd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127329
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-23  dtm  <daniel@fearnley.net>  [763c2a436baa1814d2bf95477b9d79fa3934d5e5]

        tdf#92161 add GB18030 encoding to iodetect
        
        Change-Id: I0f1201cb9cba13f70cb3430772612aa00fcc4b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127347
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9d0460ae7210367c9aee6788378758c59b1b0c42]

        add drawinglayercore to merged libs
        
        Change-Id: I3c2fc7f72fab8eb5deb21c609bd60663ba35e251

2021-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ed5e8dac7f3b3fa2a027ada26425f36863c33e51]

        remove drawinglayercore from RepositoryModule_host
        
        Bad attempt to fix the issue.
        
        Change-Id: I27c79c0a28f48c46e5f978793e1f7a78140a91ce

2021-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a51d464a75fe68ed131b3fc5b72c2afb0960fcf5]

        add drawinglayercore to RepositoryModule_{build,host}
        
        Change-Id: I06d24306e3a56bd1d1f7107a25d1b556c60f1521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127345
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [24cc816e62011d06d101a881c426e28749f10e82]

        update PCHs
        
        Change-Id: Ida2e859165e1698bf1837a6495d6df0f01b4a284
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127339
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-22  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4cae99b99e9853c5b1e64dac1926ecd718982409]

        janitorial: the lang definitions aren't really an optional part of gbuild
        
        furthermore there's no need to keep them separate to fit dmake anymore,
        so lump together what goes together...
        
        Change-Id: Ic0377a322100c20352e211e53a670a9b0b227ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127332
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-12-22  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b85e99950dc4584160512cffec303827c02f2d15]

        tdf#145057 Fix saving color filter when multiple data ranges in sheet
        
        When mutliple data ranges existed in one sheet, only the first one was
        considered when exporting color filters.
        Consider all of them, as any could hold a color filter.
        
        Change-Id: I13ae2018057eef7ef24fc8298c814a93df24f74b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127328
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [22f3f806abc0ef3ef02cd6733bdb3f950085dd17]

        tdf#135061: sw_uiwriter3: Add unittest
        
        Change-Id: Ied2ae576810a9f66e51883375959d372af59abe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127326
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [dd073b6e2be32749333af25c160ea637c4a27e10]

        tdf#143569: sw: Add UItest
        
        Change-Id: Ia87441c1b9ea2948981720fcc768d554ba474ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127319
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-22  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [c38dbafe0f332c6c263d1412eb41572222120c5c]

        tdf#104823: unittest
        
        Ensure reading and writing to datasources
        
        Change-Id: Idbc907a21fe3b881d1b835ed0e8c795c4ea36863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127311
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a997f6224201dff31dcadf91163876b4d8f557d0]

        cleanup AcceleratorCache
        
        (1) reduce visibility of stuff nothing is using outside the class
        (2) remove noise comments
        
        Change-Id: Icea829ef92d6121b957ad47a992ef7ac04656af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Julien Nabet  <serval2412@yahoo.fr>  [aaff8a5cde6b3df9efdf4cf18157c9318c463e1a]

        tdf#146363: fix crash when changing width/height of text box
        
        Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc
        tdf#126180: EndTextEdit on all views before delete/cut slide
        
        Just declare and initialize nMarkCount later since calls
        to methods like ResizeMultMarkedObj or RotateMarkedObj may change the result
        
        Change-Id: Ic2a07a6f41b8052dcc3c2736205e1b9c6d538233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127308
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-22  Mike Kaganski  <mike.kaganski@collabora.com>  [822998f1dc202aba7a558767f641687aef0c1148]

        tdf#143582: Avoid error on clearing leftover return value of a method
        
        SbxValue::Clear happens to not error out on clearing string and some
        other types of objects, but for the rest, it calls SbxValue::Put, and
        the latter errors out if not CanWrite(). The original test implemented
        in commit 24d24debef4cda7de702c4b470a3707f1aae3ea3 only checked string
        return value, so happened to miss this problem.
        
        See similar code in SbiRuntime::FindElement.
        
        Change-Id: I7c17137cc9e7ee3133ee86a9f701559df66e53b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127248
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [771e721837e76bdf1f85dda164f607a3d3c6c9a2]

        tdf#129625, tdf#144672: sw: Add UItest
        
        Change-Id: Ie6a4cc8b5d218112c56ff3cbba6a0c51ab30fb59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127309
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-22  Jean-Pierre Ledure  <jp@ledure.be>  [2562a7b60214c1a0cd5393ca3f75e949dd58d5f3]

        Access2Base - Fix argument check in OpenDatabase()
        
        Read Mike Kaganski's comment in
        https://gerrit.libreoffice.org/c/core/+/9303
        
        Change-Id: I8d89d9dd93dd6c31438418847d4073568baf11f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127312
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-12-22  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [5df35405494b2726f214c852e78ad8852d7c4829]

        Recent XOOXMLDocumentPropertiesImporter changes went into 7.3
        
        Adjust @since statement to new realities
        
        Change-Id: I8a65b4bdd2ef2ffab95f8a934ff5e5e8ffb90f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127282
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8d1cc8b11821e43c59e341c8d628ddb3cfd1e9f]

        revert part of "loplugin:flatten in filter..include"
        
        revert part of commit a3bc9dc51104d01ec203b8e2d5767dd055a42b58
        accidentally included (was an early workaround when the plugin
        was misbehaving)
        
        Change-Id: I12d06b7c4d6387b674b4d0c69914732094d20f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Stephan Bergmann  <sbergman@redhat.com>  [e88fbc883fd7fc06c324819bae35cb8d3a80ab77]

        -Werror,-Wundef (clang-cl)
        
        Change-Id: Ife97d1645c0ef4684a00f943c649b19623290d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127299
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-22  Stephan Bergmann  <sbergman@redhat.com>  [cd057f55bae74c6a14d893d292286909430b4382]

        Silence loplugin:fakebool for BOOL GetMessageW even harder
        
        8f22ce5ea3e62a4837773f6958b8ce7ac96f811a "loplugin:fakebool (clang-cl)" had
        tried to use auto to silence the warning about GetMessageW's misused BOOL return
        type (where GetMessageW encodes more than just true vs. false), but that no
        longer works after Clang 14 trunk
        <https://github.com/llvm/llvm-project/commit/c9e46219f38da5c3fbfe41012173dc893516826e>
        "[clang] retain type sugar in auto / template argument deduction", so just use
        int here as the type for which BOOL is a typedef according to
        <https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/9d81be47-232e-42cf-8f0d-7a3b29bf2eb2>
        "BOOL".
        
        Change-Id: Ie703676e858dba915de5c4496c02db82a2735e29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127298
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-22  Caolán McNamara  <caolanm@redhat.com>  [f22751cac9b81e5d7c5ad6b2e0a2eff21b683cad]

        Related tdf#144862 add some notes on various compromises
        
        Change-Id: I6b1c7f90bbad70224040f3d2355a40601f58fa4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [70ac13eecfa620e94770a64110eeaa05f8c266e6]

        tdf#135061 sw_redlinehide: fix copy into delete redline following table
        
        When pasting, the entire document body is covered by a delete redline.
        
        The insert position is in the last node, whose SwTextFrame has a
        MergedPara, and the problem is that the MergedPara::pLastNode continues
        to point to the last node of the document, even when the delete redline
        is adjusted to end in a newly inserted node by
        SaveRedlEndPosForRestore::Restore().
        
        Thus afer the 2nd paste, SwDoc::SearchNumRule() goes into infinite loop
        from node 141 to 86 and then jump via the bad MergedPara back to 141.
        
        The reason is that in DocumentContentOperationsManager::CopyWithFlyInFly()
        the RecreateStartTextFrames() isn't called.
        
        This is because it only checks if the preceding node is a text node,
        while here it is a table node.
        
        Fix this by checking if the node at the insert position is merged to a
        node preceding the previous node.
        
        Change-Id: I103b60b2bec86af11006ed591cfda2feb5f575a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127273
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [af4e20426ad24c6f2c0164b37472f2b7b54ecd30]

        tdf#135061 sw_redlinehide: create frames following hidden table
        
        When pasting, the entire document body is covered by a delete redline.
        
        The insert position is in the last node, following a table; table nodes
        do hot have any connection to frames if they are hidden by redlines,
        so MakeFrames() won't create frames for the inserted nodes.
        
        Refactor SwNodes::FindPrvNxtFrameNode() so that it can detect that table
        nodes are hidden in the current layout and continue to search in this
        case.
        
        For multiple layouts, MakeFrames() may need to use different nodes per
        layout, as the "nearest" one in one layout may be hidden in another.
        
        Change-Id: I3bb2c861c861438ac2695ab49dd91dc2bde87db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127272
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [b922988e2cd57c9397b9e512a7616a10612b2b8f]

        sw: simplify SwNodes::FindPrvNxtFrameNode(), de-golf conditionals
        
        Change-Id: Ie5b35793ce38e6338e34d47725e649a56078d603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127271
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [e0f13ce0f9e2dac836c42141bb848d2bf4fbda75]

        sw: simplify SwNodes::FindPrvNxtFrameNode(), pEnd is always passed
        
        Change-Id: I6bd606e8c70704cb716b1eb474934dedb54d81da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127270
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-22  Michael Stahl  <michael.stahl@allotropia.de>  [25aa814aa466cb0a59e34dfef33c50065c445f60]

        sw: simplify SwNodes::FindPrvNxtFrameNode(), improve comments
        
        Change-Id: I2f715ffe49d1c3ef373ffeb2a3cc335d511e0c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127269
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-22  Stephan Bergmann  <sbergman@redhat.com>  [4a0f329eda7e1878dd2b78cf4529f98c9e253762]

        -Werror,-Wunused-variable
        
        Change-Id: Ia43a7f973d08794a4fc8cd0b1060df8f33759b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127297
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-22  Stephan Bergmann  <sbergman@redhat.com>  [091e711b44874481e2701526191bdb2c4c1bd2df]

        loplugin:unusedvariablecheck
        
        Change-Id: I02b42dc4a825e01363e36d6a82f78519e2c6dfe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127294
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-22  Miklos Vajna  <vmiklos@collabora.com>  [60d7796624f1c56eb036d3e73d7f8a8216cce2a4]

        sd theme: allow setting color effects in the sidebar
        
        Which requires adding slot ids for the theme index / luminance
        modulation / luminance offset. Also merge them on the sd/ side, similar
        to what the character dialog does already.
        
        Change-Id: I0ae1b4d315b2bd53c17522dbccab160e6208716b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127304
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-22  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7bd62c00c58c6b1580df4bf5f44b083a50d9f673]

        Separate core drawinglayer func. into drawinglayercore library
        
        This separates the drawinglayer core functionallity into a
        separate library, to keep a strict separation what is backend
        dependent and what is not. More strict separation can be done
        at a later date.
        
        This will make it possible to push part of drawinglayer
        (part of processor2d) directly into VCL.
        
        Change-Id: Ibc26580067e50bf20d7cdd37fa0e44eb10200878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127286
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Miklos Vajna  <vmiklos@collabora.com>  [a4c3475ec1a28f379a90cbc001b970093f8dbae4]

        CppunitTest_sw_rtfexport: rework to avoid mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I3937b6e91b5889f4ca0d7b2e9e66f09f505e7af2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127278
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-22  Caolán McNamara  <caolanm@redhat.com>  [39a57fa8c047227060915534e64c4e90affa4b1a]

        tdf#144862 explore alternatives to writer's on-screen glyph positioning
        
        writer does glyph position adjusting to try and split the difference of
        the "printing" positions and "screen" positions.
        
        it seems to have been there from the initial import
        
        commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62
        Date:   Mon Sep 18 23:08:29 2000 +0000
        
            initial import
        
        we seem to sync with the printing positions after each whitespace so
        each initial glyph after whitespace is a stable position and is the
        'printing' position while each following glyph is in a position which is
        somewhere between the 'printing' position and 'screen' position. Which
        leads to noticeably unstable positions of text during editing at various
        zoom levels and without a clear rationale for the heuristic.
        
        GlyphPositioningMode::Classic, the original mode which remains the
        default.
        
        GlyphPositioningMode::PreferLayout, takes the vcl provided print
        positions and just uses those unmodified for screen layout like editeng
        does.
        
        GlyphPositioningMode::ClassicInspired, which is similar to
        GlyphPositioningMode::Classic in using 'printing' positions for the
        start of runs, but using 'screen' positions for run content.
        
        GlyphPositioningMode::PreferReadability, replace the 'printing'
        positions with the screen-optimized positions for all content.
        
        use tools, options, writer, view, glyph positioning to change
        
        Change-Id: I6677af973268bc586d825c7fbf0b483aaf651ca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [a3bc9dc51104d01ec203b8e2d5767dd055a42b58]

        loplugin:flatten in filter..include
        
        Change-Id: I74c1ea8b9b490eaa9508a885758224063e39051b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [494b3e69fd4bef0af19627cf31da98da376019d0]

        loplugin:flatten in package..reportdesign
        
        Change-Id: I2da242fcb59709ebdd0819ec04d051d794da71e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [968b64d054eb164cee9fb92b6bf7dd93f478bf24]

        loplugin:flatten in l10ntools..lotuswordpro
        
        Change-Id: Ie6de142db1987094fdf538148ac5ee33379a3e4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-22  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [1d21a51d814b39711cb1cc7f925b0c620b42eaa7]

        ucb: webdav-curl: update README
        
        Change-Id: I3b72183fc367875f8ebce6f3fffc7efc32ca6c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127285
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [6dbe55d34ad65627ef37f10dfdb548a717bb8c78]

        tdf#133713: sd: Add UItest
        
        Change-Id: Ibeaf5fe2c6302de4b01be9b38fcc9c2cf482d3c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127241
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-21  Gabor Kelemen  <kelemeng@ubuntu.com>  [6fef768289f4dfa441a109282d253154a20a6123]

        tdf#109390 Warn about empty New Document only on Apply, not OK
        
        Creating new document type hyperlink shows a warning about empty
        file name only when pressing Apply, and closes silently on OK
        
        Change-Id: I00e7b20a12df8e35e154e3cf532067cbad72c614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127010
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bddf28af4a6fccb715fd29ad38fa100d2ac011a4]

        Fix typo
        
        Change-Id: I0b441f47062a45395777b609d71ea0fa978bffc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127279
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [078d5c433e029389aaaa261220715e9984540658]

        Fix typo and removed duplicated comment
        
        Change-Id: Id8dd9ff12fe62f5225112eebc681bf840e69f7a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127280
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [870a4b7019119c0e23b25a7fd9638d50b622ffac]

        Fix typo
        
        Change-Id: Iefc9cb27f6ac84958a002e395bd631eb0590f022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127274
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [17e920d3de45295f52622f0280b93259b7294838]

        merge the two places we adjust the kerning array
        
        no logic change intended
        
        Change-Id: I39aa616b9ec3ba40ad9d0d2a2d6bbafe9d3db984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [d7bdc8cd42b69bd752f0225ab11e3b196bd46618]

        split the two reasons aKernArray values are changed into two blocks
        
        no logic change intended
        
        Change-Id: I4305ecc865ff18f29278e78afc6e995ad095e803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127246
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Julien Nabet  <serval2412@yahoo.fr>  [d7cc9e829823239a6054de86408cf29bf8f2b4e4]

        Typo remaining "bSelected"
        
        Change-Id: Ic0cede117753cf1f7cad6c1fcb1649864cb18254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127268
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [3bcbec1fd0ba9953d445a4076114e4c6d027e45f]

        move variable to where its set
        
        Change-Id: Iff9c47766f325a382198311392c087b2ee150711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127245
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [e240ce9a491e2f99d4a00e61a86a1fa46f44d75d]

        format these two related blocks the same
        
        no logic change intended
        
        Change-Id: I0bb7f2c5f8ec1c2ff7c8af14f5a62f77411660d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127244
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [7cb140082905549808dd438d9276d06f5f234722]

        both branches start with the same code
        
        no logic change intended
        
        Change-Id: Ic15315bd44e7e718aacac188500f755e7fd0bec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127222
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [224a400f7c46548a22060659e74e33db2a02f5a0]

        split out the block where we add extra space from the kerning adjustment block
        
        so the two independent things are seperated from eachother
        
        no logic change intended
        
        Change-Id: I55532b58974077286a6b062144eb4872d2c40328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [535c91ea75d154d1f8c5905ef747dd982e565c67]

        move this variable to where its used
        
        Change-Id: Ib0559558ddea395c66149813ad6fb84d3531cab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c62b8a46470957560b1911651dbade3b0649dee5]

        Update git submodules
        
        * Update translations from branch 'master'
          to f506a2490665212eeefb5934d6d4346a8a8c1856
          - update translations for 7.3.0 rc1
            
            and force-fix errors using pocheck
            
            Change-Id: Iaf5f970103a9ace669ee6019b2362031e34cbdf0
            
2021-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [2c4cd9c336e4264aeec9117d7c62307546d94df6]

        update credits
        
        Change-Id: Ibc9821175f53f57773e91877224c6b1d9e57f409

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [d7bc33b5bfc4174e7190dd56e981ae7287b7a258]

        Keep GUI with --enable-avmedia and --disable-gui
        
        So I thought I could come up with a rich MediaItem and can get
        rid of all the GUI elements. But all the still needed features
        require a MediaWindow. Probably not for real, but there are
        multiple levels of createPlayer (some static) in MediaWindow
        and priv::MediaWindowImpl.
        
        Untangling this will require more time, so just return to the old
        --disable-gui state with actually keeping all the GUI elements.
        
        Regression from commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
        ("Fix --disable-avmedia for DESKTOP build")...
        
        Change-Id: I2b04459003d474cd3abf8b086f2f20f17274a7ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127226
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [87cdb3e51f90267be77d535b3acd368bad2f5999]

        Don't build clucene if not needed
        
        Just build it if HELPTOOLS or XMLHELP are in BUILD_TYPE. And
        simply tets for clucene just in this case. And since XMLHELP
        is not in the list of PERMITTED_BUILD_TARGETS, disable it.
        
        Change-Id: I13fdbf096c60191a428e23c22344f7e22e8c5d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127231
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [82233965486f88f4ce1313dcf35b4bc688e1832a]

        loplugin:flatten in desktop..drawinglayer
        
        Change-Id: Ie6594c9961aba5517c6ff61fb3bc1142081b1197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127225
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [489bce598626390d9c0aa5e5b8514e26070add61]

        loplugin:flatten in filter..framework
        
        Change-Id: I15a577b3c6da03001bbbf2c2b43b29b41c4007c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127234
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [f19599c929ac6ae2708b19b9eff62ff70b44ee75]

        loplugin:flatten in editeng..extensions
        
        Change-Id: Ica8f0a6e3d30dba3b5a083e3c04522073de8303f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Miklos Vajna  <vmiklos@collabora.com>  [e519d7465f38367205b37bc80f0244029e352306]

        filter: try to detect 0-byte DOC files based on extension
        
        Commit ae1f51b4888a3aa14837ac6e4083f33b2176ca45 (tdf#123476 filter: try
        to detect 0-byte files based on extension, 2020-10-28), already
        implemented this UNO-based import filters, do the same for built-in
        filters as well.
        
        Another problem in filter/ was to pick the WW6 filter for .doc --
        require export+preferred support in the filter to get WW8 instead.
        
        An additional filter that may kick in is MS Word 2003 XML: this is
        avoided by requiring "preferred".
        
        Change-Id: I46e280beb5341213b0fe7a09a549b52c0c1ea3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127219
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [c35f81148fb18ba070516edcbb4d614444899235]

        Use sal::systools::CoInitializeGuard and sal::systools::ThrowIfFailed
        
        Change-Id: Ifb40e7672671df03b5ffc89905ad1e7b68451b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127232
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-21  Julien Nabet  <serval2412@yahoo.fr>  [9466e895b319fc695cc326b37ee773e14b465c0a]

        Fix typos in mdrivermanager.cxx (connectivity)
        
        Change-Id: Ib5c115faf0dcff61be806b538c4f93bc16b9928b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127230
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-21  Tünde Tóth  <toth.tunde@nisz.hu>  [001afbed910b7e565f602c1b11b1b4538cd59442]

        tdf#127989 OOXML: fix import of transparent hatching
        
        Set FillBackground property of hatching fill to false,
        if the alpha value is 0 in the <a:bgClr> element, i.e.
        if it's a transparent hatching. This way the previous
        non-transparent hatching is transparent now.
        
        Change-Id: I483d5c654be55e74c9073769b06f185526429635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126550
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [25298930bc86d1a449a7e5b139d65e49f695f8c1]

        loplugin:flatten in canvas..cui
        
        Change-Id: I208767eaa60d913fe2882403f1f9351eb08256f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  László Németh  <nemeth@numbertext.org>  [1edaee2f03bce0efa409c592919458658d0aa751]

        tdf#146244 sw: fix Undo of accepting table row insertion
        
        Fix Undo of accepting table row insertion to get back
        the "false" value of HasTextChangesOnly property and the
        associated light blue table row background.
        
        This fixes also the missing update of the table row
        background at accepting the table row insertion.
        
        Follow-up to commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12
        "tdf#146244 sw: update HasTextChangesOnly in modified rows".
        
        Change-Id: I8e2436b6b7b67f06037481955ff22cdbc2b22dc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127228
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-21  Julien Nabet  <serval2412@yahoo.fr>  [0f472e35033b356cc2dd885762ec4c4cc7b02b8f]

        Typo: "seleted" instead of "selected"
        
        Except "getSeletedPositionStart" and "getSeletedPositionEnd" defined in offapi/com/sun/star/accessibility/XAccessibleTextSelection.idl
        since e5618f1707626a8c096ea2ca8da3cbe2c5f3db16
        author	Steve Yin <steve_y@apache.org>	2013-11-16 23:58:19 +0100
        committer	Michael Meeks <michael.meeks@collabora.com>	2013-11-19 10:02:25 +0000
        commit	e5618f1707626a8c096ea2ca8da3cbe2c5f3db16 (patch)
        tree	de014d37b3de5a7ab505a86a6e6ce46ade4bdc1f
        parent	1263b20f56d896706c982ad1b91d2936abf5d617 (diff)
        Integrate branch of IAccessible2
        
        Change-Id: I814923003bb247c4ef66f296ac4033bae9073988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127227
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [996610352fd0fc5d57a9231fa7fb3d43533863d6]

        Use sal::systools::COMReference in getAdoDatalink
        
        Change-Id: If0c474209da5390c0c6e28c11ca26a1c915ab51f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127218
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [26f46b861d8504033685b2eec4d003eef8109a27]

        loplugin:flatten in accessibility..basic
        
        Change-Id: If2cc282c2b135d634daf393a082c29049b10a677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127223
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [ca28826a087245686d7fca3ffc8ca1f03307924d]

        tdf#131467 Qt set default position on first resize
        
        Setting the position in Show() is too late, because LO will try
        to set the mouse pointer to the default button, if configured.
        That obviously needs the window position.
        And also take the menubar offset into account.
        
        Change-Id: Ia280539c082ff6f675966869fb6643a41a17d696
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127154
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-21  Stephan Bergmann  <sbergman@redhat.com>  [b927eaa6db173702eb81ca610e751b157978fd9e]

        Fix loplugin:unusedvariablecheck
        
        ...on macOS, where it started to cause false positives like
        
        > vcl/inc/osx/a11ywrapper.h:89:98: error: unused parameter 'anAccessibleContext' [loplugin:unusedvariablecheck]
        > -(id)initWithAccessibleContext: (css::uno::Reference < css::accessibility::XAccessibleContext >) anAccessibleContext;
        >                                                                                                  ^
        
        after a214369f14d3f53d45b1889827057882c0ffd62e "loplugin:unusedvariablecheck
        improve"
        
        Change-Id: I450df3a6d768b4452d0975b5920ea0b3ce53ce13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127220
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-21  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8d7e266943447a97ad09caebc263f3b2d6abdbde]

        provide a "make vscode-ide-integration" target
        
        to be consistent with the other ide integrations and to take care of the
        extra step of running "make vim-ide-integration" to create the
        compile_commands.json file required by the vscode integration.
        Not using the autogenerated file created by configure directly might
        also spare some users from having their own additions overridden
        
        Change-Id: Ibb269197dc84f607b28ddad03adc919864e0c040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126860
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-12-21  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [01de8e10bfa6a99dbbfd771a626657790be8129c]

        Fix formatting (wrong indentation)
        
        Apply clang-format to this method
        
        Change-Id: I67fbdc4ca8b9c602ed85a57dbbde8ed47bdd45c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127215
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-12-21  Miklos Vajna  <vmiklos@collabora.com>  [4f140ebac1f971d72f5bb59ee23a3fe248c4d16e]

        sd theme: allow setting color effects in the chardlg
        
        Which means not only the 12 colors from the theme are offered (which
        comes from the current master page), but also lighter/darker variants.
        
        And once these are selected, their theme index and luminance modulation
        / offset is also remembered. This means if you pick light blue and later
        change accent1 from blue to orange, you get light orange out of the box.
        
        Change-Id: Ia83b8971ad894d02ed4ec5ca914684fc9cf9a677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127211
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6fa091a75eaf665ec734a56ef1e10b72bc603dd]

        no point in release solar mutex before calling PostUserEvent
        
        which will just acquire it gain
        
        Change-Id: I62b0d43e15f93994a53d64b24f9765c5e7b676ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b83a4131ff6f2ddf457f6a2754d491722d3e2dc]

        no point in release solar mutex before calling PostUserEvent
        
        which will just acquire it again
        
        Change-Id: If483a74ccac762f288bcd05956066ce726a96516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc873abca8fa070cd50f82b640a425ffbb651f2b]

        no need to take solar mutex here
        
        Application: :Post* will already do that
        Change-Id: If116ddd79b4ba30ce983d467161b8fab32dbd1cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [69fb0fb44d8d60d3bb550f0117f91f64b6194369]

        Transfer preferred DPI into SfxTabPage with additional properties
        
        This adds to SfxTabPage a new member maAdditionalProperties, to
        make it easier to transfer additional properties into a tab page.
        This is then used to transfer the preferred DPI into the tab page,
        which was previously done by user data, which is less than ideal
        and always doesn't work.
        
        Change-Id: Ia4daa72093d96310009b0065f8a0e26be6bedec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127205
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [98cf3bfefd10f8680d8307920c8ad8a4ebf5127e]

        we already have the glyph positions in this case
        
        Change-Id: Ie3c1a84cf7c33e8bf758a4b849ded6f2a31bd81b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127148
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [45ca7938dbc146ffa39e1e759e20d8e0b60a3c85]

        SAL_WARN->SAL_INFO
        
        this method is often speculatively called, so the warnings
        here are not that useful
        
        Change-Id: Idc9460b365dac955d1ced4c1bc2c9d2f49fbe540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Justin Luth  <justin_luth@sil.org>  [3807e43b3b1a05eb7d9c88988b41448cfc05015a]

        tdf#90805 sw tables: use veryThin instead of hairline borders
        
        This keeps it consitent with tdf#99027 which was fixed on the
        same day.
        
        Change-Id: I03d8a9c2ab1e7f6cf8a7c95d7600d549138e414e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127165
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [cb2d87c97b8e67e78a3cb42267df88aa5fb39569]

        Use sal::systools::COMReference in connectivity/ado
        
        Change-Id: Ic3c59f70cf0e1ed0020bf4f11d7dee14c69f2119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127189
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [e5594e656d7d7958015cfe0bdbcd42ecd5a9c9c3]

        also handle SVG_COMPAT namespace here
        
        Noticed an "unknown element" message while doing some
        unrelated debugging
        
        Change-Id: I1c6d4c9cddb340d892ba63d6d209bf8f72e2203d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127210
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-21  Caolán McNamara  <caolanm@redhat.com>  [be446d81e07b5499152efeca6ca23034e51ea5ff]

        only use X509Data
        
        Change-Id: I52e6588f5fac04bb26d77c1f3af470db73e41f72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127193
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-21  Jim Raykowski  <raykowj@gmail.com>  [6485187c5351f9356a3f27bae86bd0460b6bd3c8]

        tdf#144672 fix Index entries in Naviator are always grayed out
        
        by fixing The return from SwTOXBaseSection::IsVisible.
        
        SwSectionFormat::GetInfo for RES_CONTENT_VISIBLE always returns false
        so it needs negated here and also need to test GetInfo pool item
        argument for valid pointer to a frame, indicating content is visible.
        
        Change-Id: I82326642b5714dd38779cf03a501ed0a2b032bcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127024
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-21  Justin Luth  <justin_luth@sil.org>  [12832284318125b8649f6a67e3aa12aa953afdfb]

        tdf#133713 sd: bullets and numbering should enable it
        
        This fixes a LO 6.3 regression caused by re-working
        the numbering dialog (switching from FuOutlineBullet
        to the new FuBulletAndPosition).
        
        When running uno:OutlineBullet, one expects to have
        numbering applied to the selection. However, that part
        was completely omitted from the new implementation.
        I can't imagine why, since most everything else in the
        nearby code was just a copy/paste from the old methods.
        
        This patch restores some of the logic from the old function.
        [Deleted in commit 5ff162bede44b77cb19e5ff6571b6e34f228d9fb
        Author: Gül?ah Köse on Mon May 27 23:49:41 2019 +0300
            tdf#120905 Remove old FuOutlineBullet dialog code.]
        
        Partially revert loplugin:unusedmethods to recover EnableBullets()
        from commit cae829e9c1394851fc88829d5197460929c2792a
        
        This fixes Format -> Bullets and Numbering,
        right-click pop-up Bullets and Numbering,
        and sidebar's Toggle * List's "More Numbering".
        
        Change-Id: Iee3b66bd715e92167c9423242627a996191dcb72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126904
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-21  Miklos Vajna  <vmiklos@collabora.com>  [771be31ed767f0441293f24b82d55bc6a6df9ae7]

        sw layout xml dump: handle SwFixPortions
        
        Shows the horizontal offset of tab portions (not only their width).
        
        Change-Id: I87a6b44b7b06bb78b4a52985032ffb5033b5ea53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127194
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-21  Stephan Bergmann  <sbergman@redhat.com>  [fb8754b80b23c9f57169bbd6994e460b982c02ab]

        Run `make check` in flatpak build
        
        Back when solenv/flatpak-manifest.in started with
        68fda058972a6fbb38b797f50575b84f4cb3fab1 "Put flatpak-builder manifest file into
        core repo", the default `make` target ran various unit- and slowchecks (so that
        was what Flatpak builds did back then), until
        a58e086ededb8442938e81f971dfae36ef7eb076 "rework the default make target"
        changed the default `make` target to not run any checks at all (so that is what
        Flatpak builds did since then).
        
        Also, for one, 9cf2616c5e709b595eeee6ab88dacdfad2003f98 "Work around i386 kernel
        vs. JVM bug for now by disabling all tests on i386" had made i386 not
        run any tests at all (back when the default `make` target still ran various
        unit- and slowchecks; and which was later cleaned up with
        243c05ac27e3ffd94343630e668a53cf3ad18744 "Retire build-nocheck" when there was
        no longer a need to explicitly mention build-nocheck to not run any checks at
        all).  But at least on Flathub we no longer do i386 builds anyway, so this is
        presumably moot today.
        
        And for another, 6cb20e0b298f41fe88984aebfe5454f936a0ae3a "Disable
        CppunitTset_sc_*_functions_test for linux_aarch64 for now, too" had disabled
        certain "tests for aarch64 for now too, to get Flathub builds unstuck" (back
        when the default `make` target still ran various unit- and slowchecks).  But
        that has since been fixed (and 6cb20e0b298f41fe88984aebfe5454f936a0ae3a been
        reverted with ae6f41424608b349b45eb3f18ee8c7cff5d6c182 "Revert 'Disable
        CppunitTset_sc_*_functions_test for linux_aarch64 for now, too'"), with commits
        culminating in 57ad86fec9e5b4981332392bdb5c5a1f5e468bfe "Allow for some variance
        in results of some more Calc function calls".
        
        A recent master test build with `make check` on Flathub succeeded at
        <https://flathub.org/builds/#/builders/32/builds/71637> (for the two
        architectures aarch64 and x86_64 that we build on Flathub), so lets enable that
        for now and see how that works out in practice.  If it proves too brittle with
        too many spurious check failures, we can either restrict it to running fewer
        checks (e.g., the old unit- and slowcheck behavior), or disable it completely
        again.
        
        Change-Id: I62efc41669ff634551fc07f24069f296f3d0d0bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127201
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [44406d90e657afeea66e43b22eb4d4c897639276]

        Introduce move ctor/assignment for sal::systools::COMReference
        
        Change-Id: I063a1d4a42eb28e2b81956b9b2baefaad3208234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127190
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-21  Mike Kaganski  <mike.kaganski@collabora.com>  [64e46c7cb0968a6249dd37ac0a7b12bccc19ee58]

        Introduce sal::systools::COMReference::TryCoCreateInstance
        
        Helps fixing uncaught exceptions introduced in commit
        00eb9b8954a129fb365191ce8cdcbc4cf66a7333.
        
        TryCoCreateInstance returns HRESULT, because it allows to pass the info
        to the caller, which must check the result (either HRESULT, or validity
        of the reference) anyway.
        
        In case of failure, the previous contents of com_ptr_ is kept, which
        would be consistent with existing code in connectivity/ado replaced in
        a follow-up patch.
        
        Change-Id: I4c94695de96861ec312247acaa0c8fd35a23010a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127192
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-21  Jim Raykowski  <raykowj@gmail.com>  [64065ade86cac68b9d500f0495ffc5745a944819]

        tdf#134960 List hyperlinks in order of apperance in the document
        
        in Writer Navigator Hyperlinks content type member list
        
        Change-Id: I0473c767478b1125acbb7e1b4bda99ac22934884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126992
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-21  Jim Raykowski  <raykowj@gmail.com>  [c8ac73daa670ab571c3d52541c67c28270ee6a08]

        tdf#143569 fix fly frame Headings out of order in Navigator
        
        This fix uses the function that is used to determine SwSectionsContent
        nYPos. Using this approach also works to make the listing order of
        members of outline content type (Headings) the same order as they
        appear in the document.
        
        Change-Id: I108994553026e05088b103e1094e38a94d6608be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127022
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [681d8b9ec49b0318c0df17f86cc27baeed7eac5f]

        Fix English in extended tips
        
        Change-Id: I4125a68930d5debb17902aed58c0d6cb896fbe5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127172
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d]

        Qt use asChild for pointer positioning
        
        .. and refactor some variable names.
        
        Change-Id: I7d31a7a377f614bdd78f8d09852a2eda0cc47442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127153
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [b8a801def427255587a7e519577d29d1acb91162]

        Disallow multiple component files per library
        
        This converts existing users of multiple component files to the
        new filtering mechanism and adds a check to error in the case
        that someone tries to set multiple component files again.
        
        Change-Id: Ie75d6c5d1b78f446ff06faba7350715289b8d17e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126892
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-21  Jan-Marek Glogowski  <glogow@fbihome.de>  [379b685730ca7adb3b8d1905c73a2c3df1d31799]

        Filter optional component implementations by name
        
        Instead of trying to make up BUILD_TYPE items to match complex
        build conditions and then patch the component file with it, filter
        the component files based on the unique implementation name and
        an <optional/> tag. Currently these optional implementations are
        grouped in external files with an identifier.
        Originally the optional implementations were automatically iden-
        tified by adding them to any external file, but this behavior is
        too easy to get wrong. Even better: if need arrises, one can now
        easily implement a feature to add implementation names directly
        using gbuild calls, instead of grouped files.
        
        The basic mechanism is to collect all optional implementations,
        remove the needed ones from that list and then filter-out all
        implementations not needed (AKA the rest of the list).
        It's no problem to have the same optional implementations
        selected in multiple files. This is especially used by the
        vcl.common component in a later patch.
        
        For gbuild this adds gb_Library_add_componentimpl. The component
        parameter for the call is explicitly omitted, so you must call
        gb_Library_set_componentfile before selecting any optional
        implementations. The strict naming is also enforced by appending
        the identifier to the component file name.
        
        This replaces commit 65c0887bca2909b2046eb5aa4aaace0cc320c3f2
        ("Allow for conditional parts of component files").
        
        Change-Id: I0261cadce8bdfebb6b3ec96669ec378a5c1d9699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126891
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-12-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [50f553cacad76da22166d058db98f28d5ce6d65d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a35f8b648fd4bac70bbde0554a2d4051c7633cde
          - tdf#146336 Fix missing default in Help page
            
            Logic was designed for moduls with page formatting.
            
            MATH, BASE and unknown module were not handled. Default is
            for Writer.
            
            Change-Id: I4d92a37110a342274a3d131f025213716134dd60
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127191
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2cd50d80c229bc58cf9d8867f8506c720f2e17d]

        tdf#146019: sd: Add UItest
        
        Change-Id: I6698246a0719c3abc5f852911685079e16f7cf2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127164
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-20  Caolán McNamara  <caolanm@redhat.com>  [001259475f82d01c59fb559f47500bc62fc7da94]

        tdf#146333 don't create a new XTitle just to remove a listener from it
        
        seeing as the listener obviously won't be in it
        
        Change-Id: If9944c003fa51309288276f1327011dc7403b31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127159
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-20  Stephan Bergmann  <sbergman@redhat.com>  [7cf387c43562a78192a59bd8fcfeea9b67d96f09]

        Add css::uno::Sequence move assignment operator
        
        Coverity had reported it as lacking, which
        b0b2d7f040c6a7c5dc1f3949693b368ca54ea3b5 "cid#1495784 Missing move assignment
        operator" and c4aa4b55e21915ca072daa7db93edabc043f26ab "cid#1495784 Missing move
        assignment operator" had worked around by instead modifying the calling code.
        But even though a move constructor would be of little benefit, a move assignment
        operator does have the slight performance benefit of avoiding some refcount
        manipulation, so add it anyway.
        
        Change-Id: Ibc9ca4557dd8beb6070b3451cb6103a8aadd10e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127188
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-20  Stephan Bergmann  <sbergman@redhat.com>  [e86734315c24d030f6cd9e8914c743a44ba35bd6]

        Missing inlcude (for std::as_const)
        
        (presumably since 807f238f12e0774fabf507a17ca0ba9204d47833 "Recheck
        include/[e-r]* with IWYU")
        
        Change-Id: I188edd1e9cea0bc2ca65cc834b94aa9c0913c0ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127187
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [a65d126a2f68c1a157d4eee1090620b82da6e575]

        use cppu::BaseMutex in TransportAsXWindow
        
        because passing a ref of a local member to a parent class
        means passing uninitialised data
        
        Change-Id: Iec76a614d99f16b34f0fd5208a7f074153d57003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Miklos Vajna  <vmiklos@collabora.com>  [0aca74c0acc3e1c3f6099f47bfe9bfedfa7bf86d]

        sw: fix SwTextGlyphsKey::operator==()
        
        It assumed that the length of our text and the RHS's text is the same,
        but that may not be true.
        
        Originally introduced in commit c7b83934fcf4120c1a4cba8e1eaf9c7aef9edc82
        (tdf#119992 sw: compare sub-strings in SwTextGlyphsKey comparison,
        2018-10-12).
        
        Change-Id: I0361ec001aaffdbad6814bbbfefec6eaeb367f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127163
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [14eeed686c5490ddbd356c1ac807b16231e4cb88]

        Just recompile changed generated localedata
        
        Also use random temporary files.
        
        Change-Id: If59a9f3ac8e736272ad51747c6a032351a6bec39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127138
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [3eab026369105ae8e8c9d9b39d3e090e0b0aa050]

        uitest: sd: move data folder one level up
        
        To be consistent with sc and sw
        
        Change-Id: Ie3e3bc1594449f236dc701667fcb48410e36da20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127162
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [6198ea0469d1fca24fe2de2b8ac17bbfd0f3c1b6]

        osl::Mutex->std::mutex in AcceleratorExecute
        
        Change-Id: Ib95f4bf1d5f09e8647ce8f35e8165c6858247fd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [97d00de4afe9827ddaf299cfdfa8534425a11fe6]

        osl::Mutex->std::mutex in SvxUnoTextContent
        
        Change-Id: I78c576cabc91488c9496aa684f42dde47f004103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [1dc917b86cc1ae68dd9469e89c6f6aa2f9da5347]

        osl::Mutex->std::mutex in lcl_LookupTableHelper
        
        Change-Id: I76989e1f52be35fad63a090809da950ceed8fc69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [a08f3b10550761d637d27f5d88d554bd949417df]

        osl::Mutex->std::mutex in GlobalImageList
        
        Change-Id: I12b3074e77e67bfd0914f74d71ad2dace8d1ac21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127107
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [361b1aaae1d69a642e2735c862d4fe9243ea4646]

        osl::Mutex->std::mutex in TextSearch
        
        Change-Id: Id424d7b0d2eee12eb53d9dda4445189526b63d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [dab35c152af3345786b8335e83cd067b67d08b81]

        osl::Mutex->std::mutex in ModuleUIConfigurationManager
        
        Change-Id: I012ba8ab049fd19832e9f1df643957e57c05b69c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [d246fcf94638604911ef11ff2f4bdc0c5ba8dbfc]

        tdf#137318 sw_redlinehide: fix assert on export moz715138-3.doc to ODF
        
        (regression from 31f51598fd08c2b76583a1baad0c0d6d4b336664)
        
        Change-Id: Ia3e5d25e46da3016d1af9f5e1dbdcfc6bdd46457
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127145
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [f16fd6725582659602ca8b138937db7283a81bf3]

        flatten LocaleDataImpl a little
        
        no need to store LocaleDataLookupTableItem separately
        
        Change-Id: I06de28518fe80f6ae1a22c20af2ff32245b66acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127112
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [516fa8464f84378f5f6441555689f468ef2e8eb9]

        osl::Mutex->std::mutex in ImageManagerImpl
        
        Change-Id: I2feae13f2d8fe90d1f3b072156f3e384fd71db82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [20cd1d36916a55e0f89f39e876a61d52576ee0b1]

        Fix typos
        
        Change-Id: Ib75af11e67cadd3522c2c4b94b0549c8a96b8464
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127150
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-20  Arnaud VERSINI  <arnaud.versini@pm.me>  [587c530d13a5427ea6610d68d3db3fde27f50725]

        bridges : use std mutex instead of osl::Mutex.
        
        The lock_guard moved from RTTI::GetRTTI to x86_64::getRtti to avoid recursive lock.
        
        Change-Id: I0e71581dd57a4fb2655d4b9040fb9d943f73ab9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127095
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [d53b9c69e24d699a50497a1938dacf40e1682fc3]

        osl::Mutex->std::mutex in UndoManagerHelper_Impl
        
        Change-Id: I4d279e2175f22422bec242ef8a15166cf67ef59f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127105
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [833b240d1d04a8aae1c1f83c760d2e2fd800550a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb0af5ca08c6c9cff2223e641dbd73f9cd2c47c0
          - tdf#145725 VBA mode for RGB functions and warnings
            
            + Added a RGB [VBA] page specific to VBA mode for RGB stressing
              differences
            + placed warnings on Red vs Blue color interchange in VBA mode
            + Refactored here and there.
            
            Change-Id: I0556babb7c3a4bd3eeff1bfe6993624aa0e78d6d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127098
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-20  Michael Stahl  <michael.stahl@allotropia.de>  [40487d9c81c69c4e5ee1621e53c8162ae33c80b2]

        tdf#145062 sw: try to fix UBSan crash in UITest
        
          /sw/source/ui/fldui/fldref.cxx:470:32: runtime error: downcast of address 0x60700065f330 which does not point to an object of type 'SwGetRefField'
          0x60700065f330: note: object is of type 'SwInputField'
           a8 04 00 78  30 d8 f7 f1 8c 2b 00 00  60 9a d4 4c 8c 2b 00 00  00 b6 57 00 10 61 00 00  00 00 00 00
                        ^~~~~~~~~~~~~~~~~~~~~~~
                        vptr for 'SwInputField'
              #0 0x2b917d44b1fc in SwFieldRefPage::UpdateSubType(rtl::OUString const&) /sw/source/ui/fldui/fldref.cxx:470:32
              #1 0x2b917d463aa9 in SwFieldRefPage::TypeHdl(weld::TreeView&) /sw/source/ui/fldui/fldref.cxx:358:5
              #2 0x2b917d45f9e4 in SwFieldRefPage::Reset(SfxItemSet const*) /sw/source/ui/fldui/fldref.cxx:258:5
              #3 0x2b917d436efd in SwFieldPage::EditNewField(bool) /sw/source/ui/fldui/fldpage.cxx:110:5
              #4 0x2b917d48e725 in SwFieldDlg::ReInitTabPage(std::basic_string_view<char, std::char_traits<char> >, bool) /sw/source/ui/fldui/fldtdlg.cxx:214:16
              #5 0x2b917d48f411 in SwFieldDlg::Activate() /sw/source/ui/fldui/fldtdlg.cxx:233:9
              #9 0x2b8c8ac6f2b8 in Timer::Invoke() /vcl/source/app/timer.cxx:75:21
              #16 0x2b8c8abaec67 in Application::Yield() /vcl/source/app/svapp.cxx:532:5
              #17 0x2b8c87842191 in Dialog::Execute() /vcl/source/window/dialog.cxx:1056:9
              #18 0x2b8c8a7bfabd in SalInstanceDialog::run() /vcl/source/app/salvtables.cxx:1685:23
              #19 0x2b917cc6879c in weld::DialogController::run() /include/vcl/weld.hxx:2516:47
              #20 0x2b917cf6e99c in SwFieldInputDlg::run() /sw/source/uibase/inc/inpdlg.hxx:56:47
        
        Apparently SwFieldPage::Init() is called from SwFieldRefPage::Reset()
        and replaces m_pCurField with whatever is at the cursor position now.
        
        This should avoid crashes but it's kind of ugly. Should the dialog
        perhaps switch to a different tab page?
        
        Change-Id: I9c46665680090a5f164fd5d594fd3e7b1ab31f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127013
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-20  Miklos Vajna  <vmiklos@collabora.com>  [7d5984d7aed2bafcb599882b66bb0dde2d22ff3f]

        sd theme: allow setting the color's theme index in the chardlg
        
        This routes not only the rgb color and a name, but also a theme index
        from the color picker to the chardlg (only there as a start).
        
        That way the picked color will be updated if the master page theme
        changes.
        
        Change-Id: I7a45d7cf63c7c36013e4656c66d9b2dbc3aa0b88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127135
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [24ea26f55ee4e8a3c69b6dc9911a8c42e56f1eb2]

        pass by ref in lcl_LookupTableStatic
        
        rather than passing by pointer and then asserting that the
        pointer is not null
        
        Change-Id: I8df464ca2ae770ab343417fe1b15c378c88110d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Miklos Vajna  <vmiklos@collabora.com>  [38768976f82834010f160cc234eade5ca5aeefa5]

        sw: prefix members of SdrHHCWrapper, SwAutoTextEventDescriptor, ...
        
        ... SwFlyNotify and SwHyphWrapper
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib1508f7a97cedebd70186e379f5f7e571cd1f60a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127133
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-20  Gabor Kelemen  <kelemeng@ubuntu.com>  [807f238f12e0774fabf507a17ca0ba9204d47833]

        Recheck include/[e-r]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I44e4e3a88067c1c29ce9d563b22741e984b43576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126964
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [309c8bd4fc5cc7034754b90d6306bbe4084be4d9]

        remove leftover
        
        from commit b33a4d3c4acc37b9284c611caaaa661d2fe34db8
        
        Change-Id: I6218b84d040a2b3ebd32cc515c5bf25e303487f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [599cb40c92f2d758d21c7040790cbf2ceab213f3]

        osl::Mutex->std::mutex in Oxt_Handler
        
        Change-Id: Iaa7120a5373c09a1515dc76e5a5ba19b16cf1554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127102
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Gabor Kelemen  <kelemeng@ubuntu.com>  [656ed2c6f217d73e4686726783dec5b940851daf]

        tdf#146311 Hide Columns section in sidebar
        
        for media file in Calc
        Change-Id: Ia3e50d79eff645d66e7315bff51a62307dff2d69
        
        Change-Id: Ie8f2a6439a1cc68bce6d13bc304de9597fe86b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127131
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [95b7ecbbdb445a8f2408d1b0b3d32cb799d15568]

        osl::Mutex->std::mutex in WakeUpThread
        
        Change-Id: I469fa855eb373829f23232875669f607dcb0c6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127104
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Mike Kaganski  <mike.kaganski@collabora.com>  [00eb9b8954a129fb365191ce8cdcbc4cf66a7333]

        Use more sal::systools::COMReference
        
        Change-Id: I29bf304d90db968682c2b0791372d0ea41375096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127132
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [82ceab070de76d447505a598d07d5a9a1c48d80d]

        osl::Mutex->std::mutex in UIConfigurationManager
        
        Change-Id: Idbad742b51c1ee8b8ba7104bc7520772ad947ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [7e44d8d78a3c58a5468c4c3331992a0c472560c6]

        osl::Mutex->std::mutex in HelpOnStartup
        
        Change-Id: I3133ab5e0f0af40c7570856c216f3921576818af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127103
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [7fe0a4cddf23f0c15e95ff59e658ee3bbe11db51]

        osl::Mutex->std::mutex in StorageHolder
        
        Change-Id: Ie0ababcea79b445ac73ffd4e69d260a7641af663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127106
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [71f27d514549b7354f2c7b759c661e689e586162]

        use cppu::BaseMutex in SvXMLEmbeddedObjectHelper
        
        because passing a ref of a local member to a parent class
        means passing uninitialised data
        
        Change-Id: I8ebfce789da19538379cfa0888a63a9b31d35a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [279487b53ac876bb8ece9e5c2ec2882ca077bf13]

        use cppu::BaseMutex in SvXMLGraphicHelper
        
        because passing a ref of a local member to a parent class
        means passing uninitialised data
        
        Change-Id: I1171c3e5f5df148c7e63dad451bf54dff23fe2aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [858c4cd07f22ad0f7dfbb31e55619bcc7d8b1051]

        osl::Mutex->std::mutex in SocketConnection
        
        Change-Id: Ia63c9cfaf189b328c6fa492bd132f6c9767f573e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [86aa6ad680998d2e854b964f63b51a2c7d98251a]

        osl::Mutex->std::mutex in PipeAcceptor
        
        Change-Id: Iafe6c0238d5a00bbf3c586b36c10ea7793f466b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Noel Grandin  <noelgrandin@gmail.com>  [5f4a580ea13d34d7cc0ece0099dd2003612ca635]

        osl::Mutex->std::mutex in SocketConnection
        
        Change-Id: Ifce8ab564c6f43f65ce02706b74f2c58d9b42bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-20  Jim Raykowski  <raykowj@gmail.com>  [8d29c5db519eb83b51f5a799759e4962c4a62487]

        Check pointer before use
        
        Change-Id: I06a19b4e6a5fa892c8aec555e5416fda7fe24146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127090
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e34067483ef78c1569641becfe99b79a97600aed]

        Set the original size in crop dialog to preferred DPI calc. size
        
        If we have the document setting preferred image size set, then
        use that as the default DPI and recalcualte the logical image
        size using the DPI and the size in pixels.
        This is useful so we have the preferred DPI size as 100% in the
        crop dialog, so we can adjust the size in relation to that value.
        
        Change-Id: I50806f194032e228ee2cf56a39e5735a57358d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127096
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [046e6cfa544d2ffd67fd29ba7dde41b495744618]

        Add graphic size checker for the preferred document DPI
        
        This change adds a graphic size checker, which checks all the
        images in the document, if they largely differ (outside of 50% and
        110% of the image size) from the set preferred image DPI document
        setting. For all images that don't fall under this bounds, list
        them in the dialog and offer the posibility to select/goto the
        image and pop-up the properties dialog for the image to change
        its size.
        
        Change-Id: I06efce77c291fdb6ec3864d72c2f4d15dba9c42b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127094
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-20  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b5c616d10bff3213840d4893d13b4493de71fa56]

        tdf#104823: support for sdt plain text fields
        
        This is a squashed commit containing set of changes:
        * Create a input field from sdt text block.
        * Advanced support for reading field data from data bindings
          which can point to custom xml or properties xml. For this
          XOOXMLDocumentPropertiesImporter idl interface was extrended
          with extra getterrs to get properties as xml dom elements.
        * Support for exporting of this feature back to docx. For this
          some extra parameters for sdt block are kept in newly introduced
          grabbag for input fields. If field does not contain grabbag it
          being exported as before (FILLIN or whatsoever), otherwise
          sdt block is counstructed based on data from grabbag.
        * Basic support for updating custom xml values back into
          custom xmls with usage of xslt transformations. To achieve
          this extra parameters were introduced to XXSLTTransformer:
          now it is able to support in-memory transformation stylesheets.
        
        Some unittests were corrected: since sdt plain text edit area is
        a field located inside paragraph in outout corresponding sdt is
        also located inside paragraph (instead of Word's approach with
        paragraph inside sdt). Seems this is not critical.
        
        Change-Id: I1a73ef300db3619804f7adf18579bea708764c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127015
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-19  Stanislav Horacek  <stanislav.horacek@gmail.com>  [302ef0c63b8e95d040cf5b19865e8540e78f9d15]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d25f1958da0b19339f2302e1a4f46663e08160cf
          - fix typo in importing/exporting from/to
            
            Change-Id: Icc7b9379bde2bc11bbdaed1844838e48101b0e9e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127100
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-12-19  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0c3d9f5e4eabc9b20da5f47371c2dfcd991088a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 06aefeb52aef710b60138fd6a71a849367341b5f
          - This string actually refers to the Eurozone, not the bigger European Union
            
            Change-Id: I495fa0ff13479f34ee84e02fb5122f733f981492
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127099
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [64589ddc911ed7bcc334adecd46b472adfec15f2]

        use more cppu::BaseMutex
        
        Change-Id: I7ac096acfde05aa58a48fb76e895e880e27225d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [3fd6e05a77e0e9ca1db6c7f9e5a1b17d32250b36]

        osl::Mutex->std::mutex in I18nHelper
        
        Change-Id: I8743755992eeb78ec213cb51913da1b66b712142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127069
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [35d9ce88107f860e1a358c5273087985689a22c0]

        use more cppu::BaseMutex
        
        Change-Id: Ib9da716de0addc70ca58d9085ff351c2ff8c706f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Caolán McNamara  <caolanm@redhat.com>  [6ca94dbd576be7aaa643393e2a9e2ee1c723c357]

        ofz#42605 Null-dereference
        
        Change-Id: Ief752f20aa3e7672e4ed7f6cd1809ee56a096c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127087
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [7620833fb4c48b9f981c81ea1ae72102c680f1a5]

        use more cppu::BaseMutex
        
        Change-Id: I16fcc9b840ee8da79571ecb1a0811b03a2746915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127081
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [a5e270ba999050b97c7ff50339dd649547057d54]

        osl::Mutex->std::mutex in EditorWindow
        
        Change-Id: I58c5416239760f4a50a138bbe4a97c85f15126b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127071
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Julien Nabet  <serval2412@yahoo.fr>  [ccb4ec50aac95bceedea762345203023b5ba57f3]

        Merge getColumnRows in getColumns (evoab2/OEvoabDatabaseMetaData)
        
        Change-Id: Ia8177290b604413d9b4d5c0d703719b502277492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127093
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [f09eaefafbc8fe279ef07a6889f80c06c34b17dd]

        use more cppu::BaseMutex
        
        Change-Id: Ida8eb69bb90a2ce53a9a783595b1dc0b0c9f334c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127076
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [4547c4d208a8978684d602a582b933898385008e]

        use more cppu::BaseMutex
        
        Change-Id: I1374d615e8e72286a23407c50b5fe5f52017926a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [2e1cf05f3b1a7d111c538a2588e891aad67792bb]

        use more cppu::BaseMutex
        
        Change-Id: Ida7f6b536f5c07c929ddb21c97be6e9dc4a2b2f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [fd1fda8feacd1d006960e4505ad21dea213f1ec1]

        osl::Mutex->std::mutex in AccessibleBrowseBoxAccess
        
        Change-Id: Idc6e32b81190b3940a42ddb4bb30f1eff35b59fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127070
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-19  Noel Grandin  <noelgrandin@gmail.com>  [3152f5a33e787e33ec0dfef8c75d7bbf95194c00]

        use more cppu::BaseMutex
        
        Change-Id: Iddd7438161ead93b27cf8e8058ca5b1eae3d8001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Julien Nabet  <serval2412@yahoo.fr>  [729834abac1618aa2f0dcc6d774deb74f7c42bb3]

        tdf#146295: fix Base linked to txt or csv files crashes on filter dialog
        
        Regression from e01786898406130aa81eadc32f7bc2fad65c5344
        author	Julien Nabet <serval2412@yahoo.fr>	2021-05-14 18:46:57 +0200
        committer	Julien Nabet <serval2412@yahoo.fr>	2021-05-14 23:09:11 +0200
        commit	e01786898406130aa81eadc32f7bc2fad65c5344 (patch)
        tree	6852a41ac21a081114f51f5c0272249eb5f962d6
        parent	be96aa21aed3069775609780566541b3631cbbe1 (diff)
        Directly initialize vector in connectivity (part 3)
        
        Change-Id: Ib4097b3425e07de73abbc47ffefebb06b1458308
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127086
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [6108a4413af817636bfa4500de9d50a0c4aa2ed0]

        Value is never nullptr - no need to use pointer and check
        
        Change-Id: Ia3eac25536a16a756486fffe75735d94e2987177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127088
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Johnny_M  <klasse@partyheld.de>  [354fc44694cf8617113f9d6a20fa068445dcb8e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 583c749b6ce66090af9a57e0dc63ee0ee0a924e3
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iebaf405a886b8b8c06074972af6476dff6bc0de2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127043
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [ea925a2a42a335fe6bf83ed2eca279cfc4261995]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23bbbafa530b389488b285d95fe1b1a3a79a50c3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3658d9e89ee8edd4f5cb54af702345da66748f52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127042
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [0ea5ed8cc0fe056ebbd6af1e97e91202c3ec5ec7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c906e0fdfcd9c563003ea9b8b89027206fe11bd
          - tdf#132643 Translate German section IDs
            
            Change-Id: I91d7920269b18b17eeebae64d34a282dd29540ec
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127041
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [3b503bfd447893c76aee20f40da9cd215d89932f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c03c80e53e4d0174d24e363b1c63cdb47285359d
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia3ac8edc4510ce06a8b6c9834a5f253456aacb17
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127039
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [ef588233ef9ab32e4bc33b602851ac1b899070a7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4755e154f97d0c17333e1cfbccb680501c2ab48a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I18589a239de5a275595d8e2bc0e23f60e47cee37
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127040
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [02d12764c9dc9e66126236b3313e7ce8bd11ad47]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a360e08e19be32289f17c85d430fcabce633839b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I955142119478b05d4449801eebdbef5a444650fb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127038
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [8120ffda308ddc624f9352cf8d81acd5411c4af7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ec867f2646bcf32674eed69916290d7ac6a778a0
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia42c907850f116a93e5323c4d4681826817fb6a5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127036
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [225a4496db1bf3467e092a29b69e5727553205da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 767af08e138363db2a00aeb979e8e7797e475a76
          - tdf#132643 Translate German section IDs
            
            Change-Id: I252148ae140ffef29563e7383b5b71e4badb2038
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127037
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [7fc4151bc010d4786e299e4ce5500ef0d592e043]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1bd5a427849859308cce79cbe011d22d5a521260
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icefcb5c8fcffa05cc99110cd92fe91c4952966b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127033
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [dd3162f141eaec92c322362e01d5480cdfc50359]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5fb77c3cac4f6789090f6a2dc48715eca6dc3335
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ice21502113b09ee9565a57287ff03e8b48550783
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127035
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [6689f49b272f43d8cd032d1aab57aaffca619ec7]

        Drop ComSmart and use sal::systools::COMReference
        
        Change-Id: Ib4f5d160b66c01caa507f536fb487bc5ee527815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127045
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Johnny_M  <klasse@partyheld.de>  [8e300570d5ad745441d560e7b0ea2e7cb66fa21e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2cfcfbcaae15be44630c6a98e9f60cf808bb9cbc
          - tdf#132643 Translate German section IDs
            
            Change-Id: I63cf5868378583988da49db2663f57f04125fdd1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127034
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Johnny_M  <klasse@partyheld.de>  [a5b23487a70b24d8b57ff891de94e5823c727bc5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ad6d936dc315d93ee29d8c837737674b947d5b2
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib70a66cfe1b8152fdd8d9f17a425b97e4f050278
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127032
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [6649fa5b2e6d715a4aa9666a77c840886d78cf65]

        remove some unused defines
        
        Change-Id: Ieeba8b55451dffa768d6bcc7f24dd33bd19c2a15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [3cdab0587977927b781a631dd8e2d43a3faa3c07]

        use more cppu::BaseMutex
        
        Change-Id: I00b63f8ce201d2f83b89b493b4ae086368ed54d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127082
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [9366a40b7ee4d422b283467caf7c130fee611140]

        add unit tests for OInterfaceContainerHelper3
        
        Change-Id: I2baf512a3b5edd3ce29e302e444dfa5e65724613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [1d83453ce33de1ab72f0a635f73d13c440a46c81]

        use more cppu::BaseMutex
        
        Change-Id: I679e9027f9550fefc0b4ced555f8ffb89bc9491a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127079
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [4c72b9d08afbb3c503c33b37771f1dc8968df1bb]

        use more cppu::BaseMutex
        
        Change-Id: I9defebeb9cb0ba22df3578c8aae7501add36a11c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127078
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [fcba66fa86a77a3ca86705a4f145f8aae198ff87]

        osl::Mutex->std::mutex in ModuleInvocationProxy
        
        Change-Id: I2ec935fb1c53338f475d5e8aec877f84824a56e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [de9fa7b24c14473ce97fac2edc124093e5a17814]

        osl::Mutex->std::mutex in ImplRepository
        
        Change-Id: Ie3cd416d32214fe4a0477c50bf49749ac620d76a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127072
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [4f043fb3e78429277ba94f05f57fae408d6bda12]

        osl::Mutex->std::mutex in CurrDirPool
        
        Change-Id: I889f643266c6f087c34f681e71f27d8ab493e04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127073
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [6b16793cd13e540c1dfc1686df948c0dbcbe8068]

        use more cppu::BaseMutex
        
        Change-Id: I1ee9aff2774a673666c332c116aa5b0ba0d8b585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127077
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [a22772c4393f4b0a3d1a838f074c4d51be762388]

        osl::Mutex->std::mutex in ucbhelper::PropertyValueSet
        
        Change-Id: Ie4d3392e26a24ff3ffd9869809bb48bee7fcc2bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127067
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [580b5227144c6d71b1dc2663fc741ed29f119767]

        osl::Mutex->std::mutex in ResultSetImplHelper
        
        Change-Id: I7567369120593579740e23668d3426a25377a105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127068
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Kohei Yoshida  <kohei@libreoffice.org>  [9547114247c09a90f283e42c4db947ae57e9529c]

        tdf#103331: Add a test case for inherited font weight attributes.
        
        Change-Id: I8ebca3ab492313a3f7aa9019533bbb7eee2e4a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127019
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-12-18  Caolán McNamara  <caolanm@redhat.com>  [c4aa4b55e21915ca072daa7db93edabc043f26ab]

        cid#1495784 Missing move assignment operator
        
        Change-Id: I44004ad1628fed0c71392a000cd0633107732651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-18  Noel Grandin  <noelgrandin@gmail.com>  [54b80473f4a4b8ac3dfc1936b2214733474a3485]

        tdf#146286 Crash/hang calling context menu
        
        regression from
            commit b37f9fbf05e16eb58eae40c6d900a4b9da2972db
            osl::Mutex->std::mutex in VCLXMenu
        
        Change-Id: I60caa02f9d8bb40b7fcf8a1009aeeac6ff3a094c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127044
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-18  Julien Nabet  <serval2412@yahoo.fr>  [ebc9cb8ae21c5930887cf27e1dbbe2c7493f3e30]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 84b6347bd05d0a7e5a7ea5075702f5f2892b5c1f
          - tdf#146299: MsgBox can have the parameter MB_ABORTRETRYIGNORE
            
            not MB_ABORTRETRYCANCEL
            
            Change-Id: I79867d5320c8e39fb717ac92f03875744a264a99
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/127048
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [0fb0a1e1590d5e6b4c0eced0164ad2bb50b9ca7e]

        Drop unused CSGuard
        
        Change-Id: Ic822345127569a5e08b3dfe80f8e80f2ea49d613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126985
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Caolán McNamara  <caolanm@redhat.com>  [bc206f7fd3b4a9e843c81f39dcd2faeeff9c785a]

        cid#1495785 silence Unchecked return value
        
        Change-Id: I7a5e2e02e00de95e84e412bfa639b694677ab649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-18  Caolán McNamara  <caolanm@redhat.com>  [b0b2d7f040c6a7c5dc1f3949693b368ca54ea3b5]

        cid#1495784 Missing move assignment operator
        
        Change-Id: If9211cbfa326992f2fbbc321f5bf21804de091ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-18  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [be172e5a93a94b2c615dc0aae0979b9a9fa9ebab]

        tdf#104823: basic support for reading field data from databinding
        
        Change-Id: Ie45eb18205c1c54a631303b45887e54e456b6d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125550
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-18  Eike Rathke  <erack@redhat.com>  [6e91ff7b57a231ca34f619a40297cf6ef1904ea2]

        Change Interslavic Latin tag to {art-Latn-x-interslv}, tdf#145853 follow-up
        
        Change-Id: I4d19251fe350d8d2139ede9adbe0de1e3b570a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127028
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [b329502b23c59ff605ff02c3054f1bd2599dde08]

        Simplify BSTR RAII
        
        Change-Id: I0eaff245a4f5dec9c86ab2c04a329e0d2a7edca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [6e37b340874e7f8db0d346a4755b5fc30f2a08d6]

        Move ULONGGuard where it's used
        
        Change-Id: I2b440da8cb9b8cc48904f94af0e7468f620dfb21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127047
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [ce827c541dfa8c11b51224a52d4809cf27e08a8b]

        Implement building ComponentTarget directly
        
        I have no idea, why this was omitted; probably just an oversight.
        While a path as the target specifier looks strange to me, e.g.
        ids like ComponentTarget_svx/util/svx, they work as expected.
        
        Change-Id: I6dd4d382dddb8ad67cdd397db3b1c985c14cd948
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127023
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [b33564f3a351388efe3df763885b9428dc5f7371]

        Drop unused WriteDebugInfo declaration
        
        Change-Id: I53a6b51fdb1c1d801974da56813b8842384a1c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126986
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Mike Kaganski  <mike.kaganski@collabora.com>  [8c32e155acf1935c5f6cef5eeda21c3d5f5af46b]

        Drop CoIfPtr and use sal::systools::COMReference
        
        Change-Id: Ie6433bb65b4c0a799c98a44c67a708356a5eedef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126983
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-18  Stephan Bergmann  <sbergman@redhat.com>  [5804d0a2b94b34ca9cdfb8f75065d008f582be7e]

        Fix loplugin:unusedvariablecheck
        
        ...after a214369f14d3f53d45b1889827057882c0ffd62e "loplugin:unusedvariablecheck
        improve", so that it doesn't cause false positives for
        
        >             CoIfPtr<IADsADSystemInfo> aADsysGuard(pADsys);
        
        and
        
        >             CoIfPtr<IADsUser> pUserGuard(pUser);
        
        in (Windows-only) extensions/source/config/WinUserInfo/WinUserInfoBe.cxx, where
        the CoIfPtr default constructor is
        
        >         CoIfPtr(If* p = nullptr)
        
        Change-Id: I6107fa8d8aa7244b2fc5c50df2baea5096d46214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127017
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-18  Justin Luth  <justin_luth@sil.org>  [1addd8c104f6ad390bdd0ca61cd5ce97b55ce218]

        tdf#144364 sw: Revert "Use FastParser in SwXMLTextBlocks"
        
        This reverts 7.0 commit fd6feb4f538b0c5c9061529ff002be9f62a7239a.
        Noel said this was just a performance fix, so just go ahead
        and revert it.
        
        It caused the regression documented in bug 144364.
        
        Change-Id: I044c49e42873db120a94d93a00e9b35105778b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127012
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-18  Jim Raykowski  <raykowj@gmail.com>  [17a4f4d5e4d49189b43e748271d2d4fa330eef9b]

        tdf#131063 Add Navigate on select expert option
        
        Enhancement option to scroll the selected entry in Writer Navigator
        into the document view.
        
        Change-Id: I5c19a2e6a3a204a28723c3e1dfb15167dcb77c74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126906
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-18  Eike Rathke  <erack@redhat.com>  [a25774ac230ad8c36f9c9fb99ecdda0098279f31]

        Worth an assert (inserting the range name should not fail) not OSL_FAIL()
        
        Change-Id: I7178d7d9c3e4b86e3fca256031b9ee4de904e5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127020
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-18  Eike Rathke  <erack@redhat.com>  [430a6fea4012752eed0c61bff4936e9c366aa750]

        Resolves: tdf#145853 Add Interslavic Latin|Cyrillic to language list
        
        Interslavic Latin {art-x-interslv} 0x06AD
        Interslavic Cyrillic {art-Cyrl-x-interslv} 0x06AE
        
        Change-Id: I487d6593db89af038555a192674298e2dabf5582
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127018
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-17  Julien Nabet  <serval2412@yahoo.fr>  [0e8cc398f87315d121d0ebb28038f02f09d8e336]

        tdf#142961: Drawing toolbar: Rename dup tooltip "Callout" into "Callout Shapes"
        
        Change-Id: I22df0b93501d0421ace1282ec4b9795082083929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126632
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-12-17  László Németh  <nemeth@numbertext.org>  [213173edc5e47bb6da11f9a301f4dca71854a48c]

        sw: fix crash with commit 8c028b7e41e3d350d0e67005b16faf0159cc5c12
        
        "tdf#146244 sw: update HasTextChangesOnly in modified rows".
        
        Change-Id: If0ce16681704fed41ab8d6e6b23033b82487f503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127014
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [68264c4d24f50dae3435ca76e5eafc4c069a0cc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02ad9fafa8ed2e393f118fe42c838d674ea9dda2
          - tdf#145983 Fix CTL information in Hyphenation help page
            
            Change-Id: I0863327574e671443255b49e86a1a13896c2d8bb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126937
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [ce26276238bdbfde7964dfe51a174cf9c46b82dc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to af5933948773b624c5802148c33094691cd5e196
          - Related tdf#145350 improve subscript/superscript help about sidebar
            
            Change-Id: I4336688ee1c2c9cbb09d0ff06db75579656311cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126938
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9d65987055a6127899403951cec270f1cf5295e5]

        Fix typos
        
        Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-17  Michael Stahl  <michael.stahl@allotropia.de>  [31f51598fd08c2b76583a1baad0c0d6d4b336664]

        tdf#137318 sw_redlinehide: fix JoinNext() if deleted node contains redlines
        
        The GetRedlineMergeFlag() of the deleted node is None also if there are
        deletions contained completely inside the node, but in this case the
        merged node does need a MergedPara, so check if the deleted node had a
        frame that has a MergedPara in addition to the flag (which remains as
        an "optimization").
        
        (regression from d258fc29560baa5ecae03ebc2740e11420643e27)
        
        Change-Id: I44456f230374ec1de159106678e80fb4670c9f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127011
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-17  Gabor Kelemen  <kelemeng@ubuntu.com>  [30f6ad6a617e7b9aa86f774e8b6da9c4ae8ad9f4]

        tdf#146019 Remove confirmation dialog about applying images EXIF rotation
        
        Change-Id: I53553f91eeb5bd56bbad19b80421177a84625d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126616
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-12-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [a214369f14d3f53d45b1889827057882c0ffd62e]

        loplugin:unusedvariablecheck improve
        
        to find unused smart pointer variables
        
        Change-Id: I200bdd8949032a0e061de61f7903a156651793e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127006
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Kohei Yoshida  <kohei@libreoffice.org>  [6b2da3ae3ea7f47dff3c807c151f88a9e1ae9964]

        tdf#103331: Make styles attributes optional.
        
        Apply only those that are actually specified.
        
        Change-Id: Ib2e090fefe4dbfe3d4fca2b953bcf51d97d9ddec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126901
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-12-17  László Németh  <nemeth@numbertext.org>  [8c028b7e41e3d350d0e67005b16faf0159cc5c12]

        tdf#146244 sw: update HasTextChangesOnly in modified rows
        
        It's not forbidden to write in rows deleted or
        inserted with change tracking, also Accept/Reject
        only part of the text changes here. Improve to
        handle these in SwTableLine::UpdateTextChangesOnly()
        by keeping property HasTextChangesOnly = false
        (tracked row change) only if
        
        1) there is an insert redline, which is the oldest redline in
           the row (tracked row insertion) or
        
        2) there is a delete redline, which is the newest redline in
           the row, and no text outside of redlines, and no insert
           redline in the row, i.e. whole text content is deleted
           (tracked row deletion).
        
        Also update HasTextChangesOnly table row property at accepting
        SwRangeRedlines in changed table rows.
        
        Change-Id: I426c445da760f36f718d737f34ccdb904e87aac3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126919
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-17  Justin Luth  <justin_luth@sil.org>  [b58dbb862296b63f3f2395c59d30fba40fa5f59f]

        tdf#58125 sc: don't show comment notifier for hidden columns
        
        This fixes a LO 3.6-ish regression.
        
        Things have changed a lot since then. I assume that pCell
        was empty when it was hidden. The test for pCell was
        removed in commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094,
        which was in the range that bibisect suggested.
        
        Change-Id: I0af137358335a808de901111a71f5c113fabcf24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127001
        Reviewed-by: Justin Luth <jluth@mail.com>
        Tested-by: Jenkins

2021-12-17  Hossein  <hossein@libreoffice.org>  [4d396956b06c80bd7ade3825ef1a9fe1e787488c]

        tdf#146225 Revert "Use g_get_real_time instead of g_get_current_time"
        
        This reverts commit 489d7298d2e609ee5900f05ba0064845a7a551ce and
        4812c8df39cb03b59d8c033005e8e9dc45a260dd.
        
        Change-Id: Ic537a605eedc39c6cbafab4c28a77d81edfa1e20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126998
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins

2021-12-17  Miklos Vajna  <vmiklos@collabora.com>  [4bbbd15fb8e8269a8bdfd188d3ca2a2a84c00922]

        sd theme: add a "theme" palette to the color picker
        
        This implements listing the current theme colors (which depend on what
        is the master page of the current slide) in the color picker and also
        allows picking those colors.
        
        The colors are picked as-is for now, not yet setting the color theme
        index in the document model.
        
        Change-Id: I2553725c29c2a9f9de80f86b38d22a06bf9c0364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126994
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [b33a4d3c4acc37b9284c611caaaa661d2fe34db8]

        fix for crash converting ooo31011-1.sxw and tdf#146132
        
        ./instdir/program/soffice.bin --headless --convert-to odt
        ./ooo31011-1.sxw
        
        regression from
            commit 681e10eecf67a1a01bdec2cc9b834e0345e25206
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Dec 9 11:12:49 2021 +0200
            tdf#146137 tdf#146132 image redrawing
        
        It is because we cache high-level primitives, and then during paint, we
        decompose those high-level primitives, and that triggers layout,
        which triggers an invalidate i.e. an ActionChanged(), which blows
        away the cached data we are iterating over.
        
        Change-Id: Id18e47b6c2b71a5404f24b075a43d2040a5e3509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126995
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Stephan Bergmann  <sbergman@redhat.com>  [793d4596d0facf5fc361fe2170bb73e01c60c9c7]

        Revert brittle UITest for now
        
        UITest_writer_tests2
        UITEST_TEST_NAME=ComplexGroupShapeTest.ComplexGroupShapeTest.test_ComplexGroupShape,
        introduced with e5650de86072b9db586a4532b5239acda77598c4 "tdf#143574 sw:
        textboxes in group shapes - part 3 take 2", is apparently brittle and often
        fails with
        
        > ERROR: test_ComplexGroupShape (ComplexGroupShapeTest.ComplexGroupShapeTest)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "/home/tdf/lode/jenkins/workspace/lo_ubsan/sw/qa/uitest/writer_tests2/ComplexGroupShapeTest.py", line 96, in test_ComplexGroupShape
        >     self.assertEqual(True,document.getCurrentSelection().getByIndex(0).TextBox)
        > AttributeError: TextBox
        
        in (slow) ASan+UBSan builds like <https://ci.libreoffice.org//job/lo_ubsan/2232>
        as well as in (fast) Flatpak `make check` test builds like
        <https://flathub.org/builds/#/builders/32/builds/71183>.
        
        There is work going on at <https://gerrit.libreoffice.org/c/core/+/126861>
        "[WIP]Sw: Replace PyUITests with CPPUnit ones" to fix that, so remove the test
        for now until that fix is ready, to get the various failing builds unstuck.
        
        Change-Id: I3579cedce35e1373c04f976a1a57ac98f1f33448
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126990
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-17  Miklos Vajna  <vmiklos@collabora.com>  [f6e6255022ac796ea1a2f81f0d949d04c24a7f9d]

        Remove empty docpp doxygen comments around namespaces
        
        I assume this was originally added to work around some broken doc
        generator, but we don't enforce comments for namespaces today, so this
        is no longer needed.
        
        Change-Id: Ia2311658516be84b26ae69e09362af560d793a7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126963
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [b37f9fbf05e16eb58eae40c6d900a4b9da2972db]

        osl::Mutex->std::mutex in VCLXMenu
        
        Change-Id: I93883f5cd8f5f83f33eded87d995f95dbfd7989b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126989
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [9564433292aa6a5a79c6c619a05434973bd4b7b3]

        osl::Mutex->std::mutex in VCLXFont
        
        Change-Id: I01fbf0c94996412129101a47171aa9f3a6a78ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126988
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [bcab8f876746434979e5b4538c268ae700aba278]

        use OInterfaceContainerHelper3 in CommandDispatch
        
        Change-Id: Ib193947279c4fe1862559d681278a3a73c8e8249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [7994791e0a3681d46d8b257f09422b04deeae41c]

        use more OInterfaceContainer3::notifyEach
        
        Change-Id: I0dd6e9f1514792e73a31e81896d09c27c1912318
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126966
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [134425eb98147d197833cb4ef7bb4d8c3d7fd2bc]

        simplify ViewObjectContactOfUnoControl_Impl::getUnoObject
        
        Change-Id: I7dd9758180c629fc0de4e59ffef7d33e62d43dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126965
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Noel Grandin  <noelgrandin@gmail.com>  [d505940a7fff8674ff4d22eaa04972a56bea516e]

        tdf#146250 fix SvxHtmlOptions::IsDefaultTextEncoding
        
        regression from
            commit da9bba7cc3c243e936daea689fea64ecaf110f35
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Jul 26 10:10:17 2021 +0200
            use officecfg for SvxHtmlOptions
        
        spotted by himajin100000
        
        Change-Id: Id237f7c4d6d816539141de97a19add0a993d92ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126902
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-17  Regina Henschel  <rb.henschel@t-online.de>  [b9c159361abd79862b30412c433fb355d63299e2]

        tdf#145904,tdf#145956 unit test extrusion of shapes
        
        These tests belongs to commit 453c5b6,
        improve extrusion of custom shapes.
        
        Change-Id: I3b89a887d72b6814540a659dfa088f1550a1d47b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126962
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-12-17  Jim Raykowski  <raykowj@gmail.com>  [dc54785f153a7fe8fecc1e21b0ef7c6549e2d0d0]

        SwNavigator: fill content member lists when toggling from root view
        
        Other content type member data could have changed while in root content
        view. Fill the content member lists when toggling from root, excluding
        the toggled from root content which should already have the most recent
        data.
        
        Change-Id: I7a014affa72c05f0a89df29acfbabcaf59fe711a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126796
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-16  Mike Kaganski  <mike.kaganski@collabora.com>  [986e946d0cf3a6f61873efc09bab8c5e07c04f80]

        VSCode IDE integration: add safe path for pretty printers
        
        Change-Id: I900ea4aef58fddb21f8bf3cb8264d9c8d9169a9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-16  Stephan Bergmann  <sbergman@redhat.com>  [5a7eb9cb97ce58d212348d46fad3a1755b54db64]

        NEON_{SHA256SUM,TARBALL} are gone from download.lst
        
        ...since 023ebf17898db4bca63129f079fd90b5cf76c1a9 "ucb: remove
        --with-webdav=neon"
        
        Change-Id: I6744cc853d5c12bf29751bb6c1815d5de507d0fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126961
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [045665d7760f14b36f9971f8b736d5dee6189b0a]

        tdf#129796: sw: Add UItest
        
        Change-Id: I0eb3aa6a5550b1c49e88b0aa3195d3aae5d6396b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126960
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [63f2350fa3f91fcc310f85a59f1becdfee2784af]

        Fix typos
        
        Change-Id: I66feced8bed05c7859e36a6d2f746a7faf30c7a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126915
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-16  Julien Nabet  <serval2412@yahoo.fr>  [ab864bd178a44208c98a2fd1b1248df5f1db1fc9]

        tdf#38235: fix sort failure for Evolution
        
        Several issues to deal with:
        1) The initial pb:
        "Error setting the source criteria. The column  XXX must be visible as a column. SQL status: 01000, Error code 1000."
        =>
        OEvoabResultSetMetaData::getColumnLabel was returning the nickname of the column with g_param_spec_get_nick
        we just want the column name to display and to use
        
        2) SQL parsing in OCommonStatement::orderByAnalysis
        2 "sub-issues":
          a) ENSURE_OR_THROW was testing SQL_ISRULE( pAscDesc, opt_asc_desc )
        opt_asc_desc is defined in connectivity/source/parse/sqlbison.y with:
        opt_asc_desc:
                        {$$ = SQL_NEW_RULE;}
                |       SQL_TOKEN_ASC
                |       SQL_TOKEN_DESC
                ;
        not sure if it should be kept but for DESC I had to use this:
        SQL_ISTOKEN(pAscDesc, DESC)
        
          b) Retrieve of ascending
        By default ascending is at true but then we tested the node with:
        if  ( ( pAscDesc->count() == 1 ) &&  SQL_ISTOKEN( pAscDesc->getChild( 0 ), DESC )
        But when we use DESC, it's directly a TOKEN so just this should suffice:
        bool bAscending = !SQL_ISTOKEN(pAscDesc, DESC);
        
        3) CompareContacts wasn't taking into account bAscending
        since we use comparison function for g_slist_sort_with_data, I only used
                int nOrder = 1;
                // if descending sort, reverse order
                if (!sortCol.bAscending)
                    nOrder = -1;
        and multiply the result with this to have the ad hoc order
        
        Change-Id: I3c360a5ef9cf0dc737a7ce4a138d2d2586abdca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126698
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-16  Tor Lillqvist  <tml@collabora.com>  [00ba09e5675fd30032d0fba38212dcad1a696e73]

        Accept iOS SDK 15.2
        
        Change-Id: I42182f86673586ce48905bdda3281ef4499263a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126958
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-16  Tor Lillqvist  <tml@collabora.com>  [e84dcee44aa7cdd340ee22d528afe14abebba994]

        Fix iOS compilation after recent changes to Sequence
        
        Change-Id: I73c519174029766a3a2f61f9ad93fd63589b8184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126957
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-16  Mike Kaganski  <mike.kaganski@collabora.com>  [866b569b58a13dab2da247aef70822933353663c]

        tdf#146219: don't try to detect if a recent file is a directory
        
        This avoids accessing (possibly unavailable) remote URLs,
        when we already know that MRU items are files.
        
        Change-Id: I97e07f007d4129b93b4939311c67cf95de6ff836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126943
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-16  Stephan Bergmann  <sbergman@redhat.com>  [57ad86fec9e5b4981332392bdb5c5a1f5e468bfe]

        Allow for some variance in results of some more Calc function calls
        
        ...similar to 04215f03492f6fce83d6bc64491749bf803c389a "Allow for presumably
        more precices results of some more Calc function calls", this time with
        gcc-c++-11.2.1-7.fc35.aarch64 and -O2:
        
        * row 74: actual 236.965090983394 vs. expected 236.965090983393
        * row 75: actual 232.103818773718 vs. expected 232.103818773717
        * row 84: actual 226.508770412418 vs. expected 226.508770412417
        * row 85: actual 238.902033404946 vs. expected 238.902033404945
        
        Change-Id: I348623fdd5c4c851cd002f1d62c5a8867b32e325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126950
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-16  Michael Stahl  <michael.stahl@allotropia.de>  [42448f48bb48a13d6618a181b12840db6d85c574]

        tdf#144565 sw_redlinehide: fix mailmerge when flys anchored at last node
        
        The InsertPageBreak() calls SplitNode() which is not ideal as the flys
        anchored at the last node of the document may end up anchored to the
        newly inserted node and this one will be removed again a bit further on:
          GetNodes().Delete( aDelIdx, iDelNodes );
        
        ... which is what crashes, when the SwNodeIndex of the anchor is moved
        hard to a different node, which causes inconsistencies such as:
        
        sw/source/core/text/txtfrm.cxx:1263: TextFrameIndex SwTextFrame::MapModelToView(const SwTextNode*, sal_Int32) const: Assertion `static_cast<SwTextNode*>(const_cast<sw::BroadcastingModify*>(SwFrame::GetDep())) == pNode' failed.
        
        Instead, always use AppendTextNode() and then set the break item
        directly, which even simplifies the code.
        
        (reportedly a regression from 166b5010b402a41b192b1659093a25acf9065fd9
         although i wasn't able to find an earlier version that didn't crash
         in some way)
        
        Change-Id: I4cac74fc86fc505f62b14cf0d7a7f9689c7402ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126921
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-16  Julien Nabet  <serval2412@yahoo.fr>  [b8f68233b8dc5a009396141fba6e47867e70f342]

        Related tdf#145910: relax even more denylist about OpenGL
        
        Comment this one:
        <!-- tdf#125516: crash on preview of slide transitions, or in slideshow, when OpenGL rendering enabled Windows 10, with Intel DCH packaged driver -->
        <entry os="10" vendor="intel" compare="between_inclusive_start" minVersion="26.20.100.6861" maxVersion="26.20.100.7584"><!-- tdf#125516 -->
        
        Revert these:
        1)
        <entry os="all" vendor="intel" compare="less" version="10.18.14.4264">
            <device id="all"/>
        </entry>
        commit 5621762a36483f7bc555dd0e6a294eb68100490a
        Author: Tor Lillqvist <tml@collabora.com>
        Date:   Fri Jan 8 15:53:54 2016 +0200
        
            Don't use the "marketing" version number for the Intel driver
        
            The 15.x.y.z.d number is not the real version number that our code
            sees.
        
        commit b1878ab683adeff6d151617fcd8f4a4530366e0e
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
        Date:   Fri Nov 20 22:55:38 2015 +0100
        
            opengl: populate blocklist
        
        2)
        <entry os="8" vendor="intel" compare="equal" version="10.18.10.3308"><!-- Intel(R) HD Graphics 4000 -->
                <device id="0x0166"/>
        </entry>
        commit 5e416099f088a2f8a8980e08e3d5b731da0a6d9c
        Author: Marina Latini <marina@studiostorti.com>
        Date:   Thu Nov 10 14:34:00 2016 +0100
        
            Windows 8 driver blacklist
        
            Blacklisted intel driver for graphics card Intel(R) HD Graphics 4000 for Windows 8.
            With this card LibreOffice won't start.
        
        3)
        <entry os="7" vendor="intel">
            <device id="all"/>
        </entry>
        commit c9b2af045acc92c8665a8523407f530cc691d5bf
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
        Date:   Tue Jul 26 16:21:13 2016 +0900
        
            tdf#101138 opengl: blacklist intel drivers for Win 7
        
        (crash in general but nothing about slide transition, let's give it a try)
        
        4)
        <entry os="all" vendor="amd" compare="less" version="15.200.1062.1004"> <!-- 150.200 -->
            <device id="all"/>
        </entry>
        commit b1878ab683adeff6d151617fcd8f4a4530366e0e
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
        Date:   Fri Nov 20 22:55:38 2015 +0100
        
            opengl: populate blocklist
        
        5)
        <entry os="all" vendor="nvidia" compare="less" version="10.18.13.5362"> <!-- 353.62 -->
            <device id="all"/>
        </entry>
        commit b1878ab683adeff6d151617fcd8f4a4530366e0e
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
        Date:   Fri Nov 20 22:55:38 2015 +0100
        
            opengl: populate blocklist
        
        6)
        <entry os="10" vendor="nvidia"> <!-- tdf#128441 -->
            <device id="0x2182"/>
        </entry>
        commit ed94101d8c399f6de2e2b9b7cd31dd6b68d269a8
        Author: Julien Nabet <serval2412@yahoo.fr>
        Date:   Sat Nov 2 18:34:06 2019 +0100
        
            tdf#128441: blacklist nvidia on Win10 deviceid 0x2182
        
        (crash on Writer so not Slide transition)
        
        7)
        <entry os="all" vendor="microsoft" compare="less" version="6.2.0.0"> <!-- 6.2.0.0 -->
            <device id="all"/>
        </entry>
        commit b1878ab683adeff6d151617fcd8f4a4530366e0e
        Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.com>
        Date:   Fri Nov 20 22:55:38 2015 +0100
        
            opengl: populate blocklist
        
        Change-Id: I7c2c99488e74277cbbff2f0f37937ca3b2115b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126489
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [23ac04c1c890c2d026cd422bec8558b5a14650f0]

        Removed break; after return
        
        Change-Id: I4dff60b9b24b60d58ddd174c7dcb222b4ca26224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [88a2856c319b1ef5635d2a6ad2755be3fbef638a]

        Removed executable bits on .odt
        
        Change-Id: Ibcfb38261e9d5bdd44259849c060de0d8c3a69a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126913
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [efe7d60333ba707223e526a8dd164d3a9348f4ff]

        Removed executable bits on .doc file
        
        Change-Id: If41904da363187128c900910c39ee1d375271946
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126914
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-16  Caolán McNamara  <caolanm@redhat.com>  [c26ce14c2bc2f4583cb02af56fdf7c00df3c5aac]

        drop ui-previewer
        
        the need for this is gone now the transition from src to ui
        is completed. I certainly don't use this anymore.
        
        Change-Id: I5bf9c8bc4f00152977091f466c2e808b824acb44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Caolán McNamara  <caolanm@redhat.com>  [ede7be0c3c70a92cd8601762d8cae7c07976360e]

        drop ui-previewer from install set
        
        this is intended for use for bootstrapping the process
        of conversion of the .src to .ui and isn't useful
        to have in a normal install
        
        Change-Id: I88066bb086ca58a56c2adc7ef5a96b03b670f086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [759da7e51d73ad4a0ae40156097eea96f029bd4f]

        tdf#126565: sc: Add UItest
        
        Reuse existing test I created earlier this week
        
        Change-Id: I4556d64f99a6aa498fc44f19aa2e39ca94b24218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126918
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-16  Arnaud Versini  <arnaud.versini@libreoffice.org>  [ab4ee55a2a03ce93debcda41d817a95517a711f0]

        comphelper : use std::mutex in numberedcollection
        
        Change-Id: Ifd8b1668ceac69f5393a279ffb19070655149e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124126
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c84ec0b1debb9b72f05ffc1d669608afc454cec2]

        tdf#99027 Set default table border width to 0.5pt
        
        Change-Id: Ib6c8a6e63271f400d69702c3c090678d6c016af3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126922
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-12-16  Caolán McNamara  <caolanm@redhat.com>  [b2aa646ef09dc8434d3ca8a5bba53a8d8ff3f910]

        use more OInterfaceContainerHelper3 in toolkit
        
        Change-Id: I3861a254d660662cbf575e9669cbacba36634856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126855
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Justin Luth  <justin_luth@sil.org>  [6ce377a649c8db7576dbb7a30949d0f89c08439f]

        related tdf#90805 sw table: ensure border when setting border color
        
        When using uno:FrameLineColor to set a table's border color,
        add hairline borders if there are none at all.
        
        Change-Id: Ib2b2f8aff0052dc32b38486c98670ebff3bd6a4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126923
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-16  Luboš Luňák  <l.lunak@collabora.com>  [672c6d74b027fc7731afb959599ffea77d6ae2ba]

        ensure invalidate tiles LOK message range checking
        
        3db1ce30ab235ad22aed71c22e4f6f52b7b88829 added some range checking
        on the rectangles, such as making sure (x,y) is not less than (0,0),
        and it added it to converting string messages back to rectangles.
        But then 3b729db05553c1a6d461fb41c89a05702f407448 avoided
        the conversions from string messages back to rectangles, and thus
        it avoided also these checks.
        
        Change-Id: I73a08e418dc2e48ef5e89fe1aee0272851f7d363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126865
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-16  Justin Luth  <justin_luth@sil.org>  [9f93a26c23ae21324f2389a18512d71d3d610b99]

        tdf#90805 sw: if no border when adding border color, add hairline
        
        Due to things like tdf#90070 (since LO scales down an image when
        adding a border), only make this a hairline border.
        Otherwise, a larger default would seem reasonable...
        
        From what I can tell, SID_FRAME_LINECOLOR
        in SwFrameShell::ExecFrameStyle affects frames and images
        and OLE objects.
        
        Change-Id: Icd72cecb7ebd7fc8b236fb5b8ebd14771399f94d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126910
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [d67058ff3dd723cc616237216ef28e8dd1f4d611]

        uitest: sc: make sure the tab number exists
        
        Otherwise, something like
        
        gridwin.executeAction("SELECT", mkPropertyValues({"TABLE": "100"}))
        
        would create a new tab called Sheet101
        
        Change-Id: I052c68a1881bfe0a32e35a62f5c4f557ef10db8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126917
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-16  Tor Lillqvist  <tml@collabora.com>  [b824634cbdc7bcacb0b67b8b1bcd17846273e85a]

        Fix typos
        
        Change-Id: I837a135f6c94c9dbdd91c5642b92aa48800118f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126909
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-16  Julien Nabet  <serval2412@yahoo.fr>  [0661c796c767802c114441ad9a17fd0979d72ef4]

        tdf#137101: fix e_book_client_connect_direct_sync signature in Evolution
        
        since it changed in 2015, see all details from tdf#137101
        Thank you to krumelmonster for having spotted this!
        
        + some cleanup to remove all eds_check_version calls
        and dependencies
        
        Change-Id: Iaf2437f8f5c04ab9674a380dac1dfb16ec8c7201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126898
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Miklos Vajna  <vmiklos@collabora.com>  [90556b6df0f6378fb60d7dee18b2f5d275ece530]

        VML import: handle <v:imagedata gain="..." blacklevel="...">
        
        Map it to (the UNO API of) GraphicDrawMode::Watermark, similar to what
        the binary import does in SvxMSDffManager::ImportGraphic() and how the
        drawingML import does it in
        oox::drawingml::GraphicProperties::pushToPropMap().
        
        On export, the drawingML export is used, and that already maps
        GraphicDrawMode::Watermark to <a:lum bright="70000" contrast="-70000">.
        
        Change-Id: I33986a03bf3d3863da5c5b1f0a2e0da0fa595c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126908
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [69a68bc38d29964ef9af8c30ea457975f9e568fe]

        uitest: remove incorrect pass
        
        Change-Id: If155962b14485b6a6cb812e562c555cabd60ef77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126911
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-16  Jan-Marek Glogowski  <glogow@fbihome.de>  [bd1868c1057f0582f1a733bb90eca0c1c7e07933]

        Refactor Library_sal_textenc build condition
        
        ... by adding and using gb_CondSalTextEncodingLibrary.
        
        Change-Id: I04e8f56bde6296477d449f1c447e8133cdf86e6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126788
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-16  Miklos Vajna  <vmiklos@collabora.com>  [48cb441fceab83a6320dc871f291dcb313696650]

        sd theme: add UI to set individual colors of a color set
        
        Which completes the UI to set and get various parts of the theme itself
        (not yet referring to a theme).
        
        Change-Id: I30cb575046d1146083cb5723377400b67de79a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126905
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-16  Caolán McNamara  <caolanm@redhat.com>  [6b8bba1fa1a9ab9059c205b3afdeb1beb8405cdb]

        crashtesting: assert on 0 scaling on creating thumbnail for moz392233-9.svg
        
        seen since:
        
        commit 1ceb4f36a7cabe7a0fb2b0c2e36079389d6a69b2
        Date:   Sun Dec 5 11:35:57 2021 +0100
        
            generate a thumbnail to save without a metafile
        
            This is similar to 59cca1a28df4cdc94450d68cc1e247a8fb5ff6f3,
            if the wanted result is a bitmap, there's not much point first
            converting to metafile and then to a bitmap.
        
        Change-Id: I44bea7c8c301f12ff53295eba5be190239337ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126897
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Caolán McNamara  <caolanm@redhat.com>  [5cfb92d11de73aba88dce809cc0355a8d9c23e95]

        crashtesting: Assertion `nMin <= nMax' failed in MinMax
        
        MinMax(T, tools::Long, tools::Long) [T = int]: Assertion `nMin <= nMax' failed.
        
        seen since
        
        commit 374e261ad1ea8b41f5ecdd850c27fdc961c4868b
        Date:   Sun Dec 5 11:55:58 2021 +0100
        
            increase maximum document thumbnail size from 256 to 512
        
        but presumably always lurked previously.
        
        This commit is supposed to change nothing, just rearrange to show that
        the nWidth == 1 branch (and adapted the nHeight == 1 branch too) doesn't
        use the data generated by the asserting block and move that block into
        the nWidth/nHeight != 1 branches
        
        Change-Id: I1d3284ee32c1eff738c34bc252400726dc7632b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-16  Jim Raykowski  <raykowj@gmail.com>  [85057da7f19e8e5d6023c16fa07d138e2b519a66]

        tdf#145747 Fix cursor not shown
        
        after moving focus from shape object to comment window to edit window
        
        Change-Id: Ibce3939575cfdc941eec45fea24383fc5edf53d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125431
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-16  Miklos Vajna  <vmiklos@collabora.com>  [c40df02caa6b5473f80bd8c2ed14763dac2076cd]

        writerfilter: some param -> sprm in rtftok
        
        The structure for these properties is to have a list like "paragraph
        properties", which then has keys (e.g. NS_ooxml::LN_CT_PrBase_pBdr for
        border), which may have sub-keys (e.g. NS_ooxml::LN_CT_PBdr_top), and
        finally some value.
        
        Stop calling sub-keys "parameters"; the real parameter will be some
        writerfilter::Value subclass.
        
        This is just meant to make the code more readable, no functional changes
        intended.
        
        Change-Id: Ie63b3216cafa6fcd0ad1ee8cf990cd7982ab7fb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126894
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-16  Gabor Kelemen  <kelemeng@ubuntu.com>  [617052236400e86888e1a2894f9ae4125fd73351]

        Remove transitional header drawinglayer/primitive2d/polygonprimitive2d.hxx
        
        follow up to commit 1103727fb24b368419ea0cfd2382560ef6b82f43
        
        Change-Id: I227042f4703f3f4c18a8dc0355f044d2ad7dfb2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126838
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-16  Kohei Yoshida  <kohei@libreoffice.org>  [aadbac5467bb6ab768f87ed6ec003c55159d54aa]

        Update liborcus to 0.17.2.
        
        Change-Id: I76c0d57da63c1e35f80b13071793dbbb27cb218a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126655
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-12-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [deea3b7471c3dab0220eca6146c225a2d47681a2]

        tdf#145062: sw: Add UItest
        
        the different tabs in the insert field dialog share the same 'type' id,
        so create a unique one for each tab
        
        Change-Id: I14013f17aa00b73ae5a7ade8c2f12f01a37d13b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126889
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-16  Eike Rathke  <erack@redhat.com>  [ec4f8cd2172bf7b232961f31ebd22d7e13af261e]

        Resolves: tdf#126565 RefEditModified() preset current sheet for address-only
        
        Change-Id: Ifa662a9d55fae10e3e1e3e115c9c5eb10972cbbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126899
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f52f92b13e523b1c7ff93a3f915af4293334c7d]

        uitest: sw: make sure there is one textfield
        
        Otherwise this test wouldn't fail
        
        Change-Id: Idfca309d47b5518c8511503e5cac3a3028986f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126896
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-15  Luboš Luňák  <l.lunak@collabora.com>  [fa91a519c002442a369ffb1ff8b35cd5297d1dbc]

        use $CCACHE instead of hardcoded 'ccache'
        
        Change-Id: I0083b4478902a09661fd2743c58369d85325e1a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126893
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [20301ba19829766eaafc05b06a272865e59fc344]

        tdf#146236 Hide Columns section in sidebar of Writer images
        
        Change-Id: I1716d10c7b18179c167c64e04965cb46b35c0294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126888
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-15  Jan-Marek Glogowski  <glogow@fbihome.de>  [8a008416c7c72321964c219f9979c4730e6e1a63]

        lockfile: use a single build condition
        
        ... and introduce solenv/gbuild/Conditions.mk
        
        The Conditions.mk is included just after the Helpers.mk, which
        should make its content available basically everywhere.
        
        Change-Id: Ie4498e12b3d0f676ed0c9abf4b3bb4899d6a1c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126787
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-15  Noel Grandin  <noelgrandin@gmail.com>  [d023a95526b8277775927c6ef3bf39925c77f76b]

        add support for macOS SDK 12.1
        
        Change-Id: I30d816d5926e5b1771901c697b67eb275d122636
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-15  Jan-Marek Glogowski  <glogow@fbihome.de>  [79ca2a6a7c8e0102aa8e7e3af709d5cf2e4d9532]

        Simplify CURL and LIBCMIS tests
        
        ... by expanding libo_CHECK_SYSTEM_MODULE with yet an other
        parameter to optionally disable the feature completely and
        adding the matching AC_ARG_ENABLE.
        
        As a result, --disable-cmis becomes --disable-libcmis.
        
        Also adds more documentation to m4/libo_externals.m4.
        
        And use simpler help strings, now hopefully correctly escaped.
        
        Change-Id: I8ac67145721d8518cca6f6867bc05738a87ed77a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126771
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-15  Eike Rathke  <erack@redhat.com>  [7c22bed187c12122fe29459279771ca414799ac8]

        Related: tdf#146228 convertIsoNamesToLanguage() fallback for empty tag
        
        An empty tag might be the result of a bad LANGUAGE=":" setting.
        The old implementation tried an unconditional "-" tag (for both
        language and country empty) that was wrong anyway. Do not keep the
        resulting LANGUAGE_SYSTEM as that is exactly what we want to know
        the actual locale for.
        
        Change-Id: I7d6587f59e9a3362c7d877926a325ebcfe7b48db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126863
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-15  Caolán McNamara  <caolanm@redhat.com>  [2dc2188c40282e85ecf9eb62321320251357f760]

        unset mpMenuBarWidget when it was destroyed along with its parent
        
        Resolves: https://github.com/flathub/org.libreoffice.LibreOffice/issues/173
        Change-Id: I875cf658fb86adfa389429ead059bfd7c4f08ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-15  Eike Rathke  <erack@redhat.com>  [f2c3c927021cd008366291e67606f6537e3e20be]

        Resolves: tdf#146228 env-var $LANGUAGE can be a colon separated list
        
        Try to extract a first or second if first is empty.
        
        Ideally the sequence would be matched against available UI
        localizations, but that's simply not available at this stage.
        
        Change-Id: I37d0c289fe165c76a98086c63279aacf6856900c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126862
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [cc02c0e32fda654cb4bcb93f87ceb48b356e1d84]

        tdf#139843 sw_redlinehide: fix crash while updating reference fields
        
        Use layout in MakeRefNumStr() when checking if node is numbered,
        because a hidden node has a null SwNodeNum.
        
        (regression from ae246b44da1708417aaaefe4f9186cfbbb9a9137)
        
        Change-Id: Iea797c03018929601ea797f00e3cf2d7749e55ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126857
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [023ebf17898db4bca63129f079fd90b5cf76c1a9]

        ucb: remove --with-webdav=neon
        
        Remove code in ucb/source/ucp/webdav-neon, and now unused external
        neon.
        
        The --with-webdav=no option is retained for now.
        
        Change-Id: I4ce429587e3991fa82009da2f8e4a068abe36435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126839
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-15  Michael Stahl  <michael.stahl@allotropia.de>  [f45b7871e7d31dfc6ed31d1b79928990bba0d0dd]

        ucb: remove --with-webdav=serf
        
        Remove code in ucb/source/ucp/webdav, and now unused externals
        apr, apr-util, serf.
        
        Change-Id: I31ab8bb1491f5290e175e87f2b30499811c5a359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126835
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [1a038e6ee1c29eafb267e035104b2a2a05714f15]

        uitest: sc: fix problematic test
        
        Change-Id: I3a445f48930e1d6c6f8d59d392bbf87cc9cb2cf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126858
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-15  Gabor Kelemen  <kelemeng@ubuntu.com>  [b24064f2b75bf2d868564a4ac680d37751a92db4]

        Recheck include/[a-d]* with IWYU
        
        See tdf#42949 for motivation
        
        Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [86ac9eb59a6d058cc868ca2b05117375d6ea88f4]

        tdf#119178: sc: Add UItest
        
        Change-Id: I8737e95b1d45433168380f1564fe4c61eb4b3641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126856
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [5fc6d68e9e125b00dc16600543e516bd15fb3a64]

        uitest: simplify code
        
        Change-Id: Id3355be0e763217a4915b53d22220c30536415e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126852
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-15  Tor Lillqvist  <tml@collabora.com>  [30e474a7e5bba6cebb7b082abd7ae8dc8d8bf8b0]

        s/2DO/TODO/
        
        Also s/4now/for now/ .
        
        Change-Id: I170c912e09435fb33532eb51ee0c15e6a0e85460
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126854
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [41f7b1b12dfdfce508f04878409854fb9da38874]

        tdf#141175: sw_uiwriter3: Add unittest
        
        Change-Id: Iba615528f8515fe60dc71bc61c0d815c0e1962e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126851
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-15  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [76f29376183be48c076ada06159581ea981de3d1]

        tdf#145381 handle closing brackets in URLs correctly
        
        The task presents an URL that ends with a closing bracket. If
        pasted to LO, the closing bracket got interpreted as not being part
        of the URL due to the heuristical interpretation of URLs in
        urihelper.
        Adapted this to handle matching brackets, so that an closing and
        ending bracket will be added to the uri text when there is a
        matching pair.
        Added unit test to testFindFirstURLInText with simplified uri
        example.
        
        Change-Id: I58dd460a37d0066ff46845832eabd2a790e4ccd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126832
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-15  Hossein  <hossein@libreoffice.org>  [4812c8df39cb03b59d8c033005e8e9dc45a260dd]

        tdf#146225 Fix delay when exiting from the gtk3 ui
        
        While removing the deprecated g_get_current_time and replacing it
        with g_get_real_time in 489d7298d2e609ee5900f05ba0064845a7a551ce,
        a behaviour change in sal_gtk_timeout_expired static method is
        done, which lead to tdf#146225.
        With this commit, it is changed back to the previous state, with 2
        additional variables of tv_sec and tv_usec.
        Eventually, the method should be simplified.
        
        Change-Id: I2f1bb22b9a2d518e6f0332472535be8d4adf92f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126829
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-15  Caolán McNamara  <caolanm@redhat.com>  [3769508f4952ca54cad7e9d33f4113b0d18066c9]

        tdf#145934 workaround rounding causing 'dancing characters'
        
        Change-Id: I1fb260196beb0cc54232aa60a1191d3090fa31b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126848
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-15  Miklos Vajna  <vmiklos@collabora.com>  [c634f836945379ae17a3714938210bba7995dd25]

        sd theme: add UI to set/get the name of a color set
        
        The two names make sense because the theme can have not only color sets
        but also font names, etc -- but for now we just care about the theme
        name and a named color set.
        
        Change-Id: Ieafca36da005a9c74964e39216bee3c33f6427cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126850
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-15  Regina Henschel  <rb.henschel@t-online.de>  [453c5b6214654b440fe1d3e926cddfb695e17f10]

        tdf#145904,tdf#145956 improve extrusion of custom shapes
        
        The patch addressed these errors:
        The property Origin is relative to the bounding rectangle of the shape
        not to the snap rectangle. That error is visible e.g. for a block arc.
        Rotation center x- and y- values are relative to the snap rectangle and
        not absolute.
        Rotation center z-value is in Hmm and needs conversion to Twips in
        Writer.
        Rotation is around rotation center, which might be different from shape
        center. That has been ignored.
        
        I have moved calculation of the 2D logic rectangle of the scene to
        main method to be able to reuse the transformation and other values.
        I consider using a special local class as unneeded overhead.
        
        I have reordered some parts to bring geometry relevant parts together.
        
        Change-Id: I35ad0721091b365ae99cd3d7b2afb0ad7efe47fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126847
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-15  Miklos Vajna  <vmiklos@collabora.com>  [85c5feaf8aa889906ad3a20a1d6e5cbffd446921]

        CppunitTest_sw_rtfexport: rework to simplify mustTestImportOf()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I21b08893f726f13a09a905f28f354f74b1b423ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126845
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-15  Mike Kaganski  <mike.kaganski@collabora.com>  [2f848eb5dc6f6f9344f250ac9860065130aaf436]

        tdf#131850: avoid encryption check for recent docs overlay
        
        Change-Id: I673de978c39492bf9be78945ece95ade2a943ffc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126849
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-15  Hossein  <hossein@libreoffice.org>  [ddd675c5a79b26d23da8d4affeeb888ac3664635]

        tdf#144961 vcl: fix CJK matching in FindFontFamilyByAttributes
        
        Whilst testing CJK matching, I uncovered an issue. The matching
        algorithm detects that the font is a CJK font if there are any CJK
        characters in the font name. However, if you searched for a CJK font
        against a font that was not a CJK font (i.e. the family name had no
        CJK characters) then it would still match against this font family.
        
        We now check if the font being matched against was a CJK font family
        or not, if not then I reduced the testMatch value by CJK_MATCH_VALUE.
        
        The fix can be tested with:
        
            make CPPUNIT_TEST_NAME=testShouldNotFindCJKFamily -sr \
                CppunitTest_vcl_font
        
        Without the fix in place, the test fails with:
        
        Test name: VclPhysicalFontCollectionTest::testShouldNotFindCJKFamily
        assertion failed
        - Expression: !aFontCollection.FindFontFamilyByAttributes( ImplFontAttrs::CJK, WEIGHT_NORMAL, WIDTH_NORMAL, ITALIC_NONE, "")
        - family found
        
        Change-Id: I18b246f151b2174dc4ae0f5507630a4e8e4bb442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123309
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-15  Dhiraj Holden  <dhiraj.holden@gmail.com>  [25ac6754d144a258d39cd9251677f3e35f4b3ee6]

        tdf#145630 Changed atan to atan2 where appropriate
        
        The extra checks are superfluous with atan2, and thus removed. More
        information can be found here:
        https://dev.blog.documentfoundation.org/2021/11/17/use-atan2-function-instead-of-atan-easyhack/
        
        Change-Id: I1de97562ce3f7180ce846629870915f789a7bedf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126212
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [cfe7dc2ef91ea119ea54b56e207ef7a77291a9d7]

        tdf#136855: sw: Add UItest
        
        Change-Id: I2626f56d59456f0e4c0942f4783c6b5270534260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126843
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [19f2054c6063177d08c818c5b7eeba7ab9178249]

        tdf#141175 sw_redlinehide: fix crash in lcl_DeleteRedlines()
        
        The GetNext() returns itself if it's alone in the Ring.
        
        (regression from 27aa4b16bf704d0246595750daf57b57ff2577b3)
        
        Change-Id: Idf92ce5362c4a4acf1582f463fe7bafc8553b400
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126844
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-14  Michael Stahl  <michael.stahl@allotropia.de>  [d16c5f47600d236e911ae50d0e58a3f2256f5a61]

        tdf#136855 sw: fix ReplaceRangeImpl() restoring of rPam
        
        This broke in CWS swrefactormarks2 (commit
        df6d312ca537402463e4eb0530f22b956600fc02) but for spell-checking the
        ReplaceRange() wasn't used until commit
        e1629c210ad78310e3d48c0756723134a27b89df.
        
        Change-Id: I4a6256b65b89e21e9e87ff45d0c5e6c4577a5846
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126842
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-14  Noel Grandin  <noelgrandin@gmail.com>  [38c008de39ef004a7f9089baba96bc408de67bae]

        Stream::Tell returns sal_uInt64
        
        Change-Id: I02e49d4f59c17a9868c4111ac91b5dd2715e689c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126630
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [c2f67e6ed60554de8b02b499fb93a60e703d533a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3ee28f154cea6cc94999015364e0a2965ee41c7
          - Fix minor typos and L10N in ScriptForge help pages
            
            Change-Id: Ie5c236da58f1a13e9aa022549aef65e661fbfd9b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126673
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-12-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [d3f0aa90ce30c2566f0c7ad775c4355b939f338c]

        tdf#124412: sc: Add UItest
        
        Change-Id: Ic0b8a6f8a8ccc3d63154be607e672e759b862714
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126841
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [f9267444d9961812214d127c1c69caeb154ef555]

        Missing test dependencies
        
        > [_RUN_____] Chart2XShapeTest::testPieChartLabels1
        [...]
        > warn:vcl.builder:4127841:4127841:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///data/lo/core/instdir/share/config/soffice.cfg/svt/ui/tabbuttons.ui /data/lo/core/xmlreader/source/xmlreader.cxx:66
        
        and
        
        > [_RUN_____] Chart2XShapeTest::testPieChartLabels1
        [...]
        > warn:vcl.builder:4129133:4129133:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///data/lo/core/instdir/share/config/soffice.cfg/modules/scalc/ui/posbox.ui /data/lo/core/xmlreader/source/xmlreader.cxx:66
        
        and
        
        > [_RUN_____] Chart2XShapeTest::testPieChartLabels1
        [...]
        > warn:vcl.builder:4132624:4132624:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///data/lo/core/instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui /data/lo/core/xmlreader/source/xmlreader.cxx:66
        
        and
        
        > [_RUN_____] Chart2XShapeTest::testTdf88154LabelRotatedLayout
        [...]
        > warn:vcl.builder:4134247:4134247:vcl/source/window/builder.cxx:481: DBG_UNHANDLED_EXCEPTION in VclBuilder
        >     when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: file:///data/lo/core/instdir/share/config/soffice.cfg/modules/simpress/ui/tabviewbar.ui /data/lo/core/xmlreader/source/xmlreader.cxx:66
        
        Change-Id: Ie8251580793654c0b7931d430be4a17ae0782cfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126836
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Luboš Luňák  <l.lunak@collabora.com>  [0d1971a8dc1f7ce24f67abcab4d6af9cf2b7b823]

        make sure text operations are not queried by (numeric) value
        
        E.g. SC_CONTAINS is, according to isPartialTextMatchOp(), a text-only
        operation, so query it as such and not as a numeric value. This
        fixes/allows e.g. substring queries on dates.
        
        Change-Id: I6c612d9934193828b7a7eabed92f2bfeb385e5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126767
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-14  Caolán McNamara  <caolanm@redhat.com>  [d9a115ae5ba869c1629973e9462d1925812354f0]

        tdf#145999 -1 was the representation of unlimited cell width
        
        when using UniString -1 -> 0xFFFF i.e. old-time EDIT_NOLIMIT
        
        Change-Id: Ie40fa65a88a2b8961d70635ca5e4ec851567e089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126834
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-14  Miklos Vajna  <vmiklos@collabora.com>  [c2726c29b233b8fa7fbd390aafe149bdf7e94b07]

        sw ODF shape import: improve is-textbox check
        
        This builds on top of commit 28d67b792724a23015dec32fb0278b729f676736
        (tdf#107776 sw ODF shape import: make is-textbox check more strict,
        2019-08-26). Before that commit, any non-empty parent style name on a
        shape resulted in an sw textbox. After that commit, we filtered out Writer
        images by checking for the Frame parent style name.
        
        The problem with this approach is that in case two documents are to be
        merged together, then it's reasonable to rename the Frame style, but
        then the complex content inside the shape gets lost.
        
        Fix the problem by going with a middle ground: require Frame as a
        prefix, but allow other names as well. This gets e.g. FrameX to work
        without breaking the "reject Graphics" use-case.
        
        Change-Id: Id59ed28a64a9398f2f1620f69b5f148d65e6c95a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126828
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-14  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [19394a924fdc486202ca27e318385287eb0df26f]

        tdf#143574 sw: textboxes in group shapes -- part 4
        
        A new UNO property has been added and implemented
        for the filters. This provides the possibility of
        assigning textboxes in the filter at import time via UNO.
        
        Follow-up to commit e5650de86072b9db586a4532b5239acda77598c4
        "tdf#143574 sw: textboxes in group shapes - part 3 take 2".
        
        Change-Id: I58c445cb7f6d865c1d82dbe68f985e4c11ff832e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126162
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-14  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [e5650de86072b9db586a4532b5239acda77598c4]

        tdf#143574 sw: textboxes in group shapes - part 3 take 2
        
        In this part, missing parameters have been fixed, and
        queryInterface method can handle textbox groups now.
        
        A new function, synchronizeGroupTextBoxProperty has been
        introduced to do the sync for all group members. Nested
        group textbox shape handling also has been introduced.
        
        Note: Copy still has issues.
        
        Change-Id: I3d2090fe6a4066edfd2cb417b30bca9dd9acb011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126052
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [cf2c1c28d7539c99b9b899da641c50ad21e1c210]

        Drop brittle test
        
        Not only did it not work on Windows (witness the #ifdef), it would also fail at
        least for Linux Flatpak builds (if they did make checks) where creating
        <file:////tmpname> happens to succeed with E_None.
        
        Change-Id: I9b82d500cb37fb80648407d2b4ade5ac85e97a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126831
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Luboš Luňák  <l.lunak@collabora.com>  [18470cb6bff9f682b3b86495d80e9ad54c9b5567]

        fix handling of the "EMPTY" LOK tile invalidation
        
        The LOK_CALLBACK_INVALIDATE_TILES documentation says that
        invalidate-all message should say "EMPTY", which wasn't converted
        properly from the MaxTwips rectangle representation. Doing that
        now needs also changing the testTileInvalidationCompression() test,
        but that should be a fix of the test, and conceptually it should
        be the same.
        
        Change-Id: I58fcc56ee56d9f6fcdb9298938e8aa7e3609d6db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126651
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-14  Caolán McNamara  <caolanm@redhat.com>  [70e6d969dcbece69bc9bd5e3a0bc5d878a33ca6a]

        ofz#42338 avoid timeout in autogrow frames during ppt import
        
        Change-Id: I4bcd8b5ee59609016451ddce5eaeb445f7c793c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126827
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [be9655420e05f55ff2df9cda0fbe5128d3a77e32]

        uitest: sc: Add test for the import xml source dialog
        
        Change-Id: Ic52148788c96a6d37def30145aa0a874d9847a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126805
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-14  Caolán McNamara  <caolanm@redhat.com>  [354849e0af51767433b1c3ad417e857d5c84e2b4]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I23310b8b5adbe7c84d0b9d30a227619c1e9a6960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126803
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a5167ae1d69dc6c9a88807113c9315860048f462]

        tdf#81146: try to make saving registrymodifications.xcu more robust
        
        ... by use of osl::File::replace, which is "atomic" on Windows, instead
        of osl::File::move.
        
        Change-Id: Ia49212f0d1cc75292f72ce219aee513e2d250ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126801
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-14  Mike Kaganski  <mike.kaganski@collabora.com>  [40c1db47ee701da5a9d2c81ad3d13bb7c8179787]

        osl_replaceFile: fallback to osl_moveFile in more cases on Windows
        
        E.g., calling it with files residing on different volumes, ReplaceFileW
        will fail with ERROR_UNABLE_TO_MOVE_REPLACEMENT. Handle that error, and
        also the two other error codes specifically described at [1], to allow
        more universal use of osl_replaceFile / osl::File::replace, which is
        "atomic" on Windows, since it uses ReplaceFileW that is suggested as a
        replacement for Transactional NTFS [2].
        
        [1] https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-replacefilew
        [2] https://docs.microsoft.com/en-us/windows/win32/fileio/deprecation-of-txf
        
        Change-Id: I501c267e5bdd88a33560d2bb916db1a0b6e01831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126800
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-14  Miklos Vajna  <vmiklos@collabora.com>  [64fcf278830a33114f0fa5884767f24edf32cb12]

        sd: add initial theme UI for master slides
        
        Click Sidebar -> properties -> slide -> master view, then launch the
        Slide -> Slide properties menu item, this adds a new Theme tab page
        there.
        
        This is just an initial UI, only the theme name can be edited as a
        start.
        
        Change-Id: Ia2faa828c57a0e858881fb8640431f046b5739a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126798
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-14  Justin Luth  <justin_luth@sil.org>  [aed4c2d80c2f11b82631c097ed0b15a5cb52283d]

        tdf#62032 xmloff: list-level is positiveInteger, impl is 0-based
        
        Thanks for catching this Regina.
        
        Change-Id: Iaf6a0c9161378934818e392126a4437e55f5ddf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126743
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-14  László Németh  <nemeth@numbertext.org>  [95c003d75e0f8b255344715a35358072b5eba99d]

        tdf#146145 sw: 1-click Accept/Reject of table row changes
        
        Now context menu of a changed table row shows Accept Change/
        Reject Change menu items, which accept or reject
        the deletion or insertion of the table row.
        Also Accept Change/Reject Change icons of the Track Changes
        toolbar are enabled, and do the same, if the cursor is not
        before or in a tracked change.
        
        Add the following labels to the Undo actions:
        
        "Accept change: Row Inserted"
        "Accept change: Row Deleted"
        "Reject change: Row Inserted"
        "Reject change: Row Deleted"
        
        Change-Id: I12ae0158d059b044e430cc0ab86f0cf8931eadd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126770
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [089ecba05dbe502709209829385c34a2e492ed6f]

        lokit: add env. var to set the certificate database dir
        
        This adds to LOKit a way to set the certificate database dir with
        a env. var. - LO_CERTIFICATE_DATABASE_PATH, which is used for
        signing and encrypting of documents.
        
        Change-Id: Ieb7725d41893212d962c8b9e32f9607d0ba10397
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126553
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 03f177d22873069e8e2e520c98f05ebfcc1b063c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126807
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [355878558967ef5a94c73f2ad92d26f62bd703f4]

        A more expressive CPPUNIT_ASSERT_MESSAGE
        
        Change-Id: I65d64002e5021c84af9ad7b8f5b693f04d79d4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126797
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Gabor Kelemen  <kelemeng@ubuntu.com>  [ad56717ed85d271616e102540a2e20e3cf7a887c]

        find-unneeded-includes: add exception for boost/shared_ptr.hpp
        
        * as seen in vcl/inc/skia/salbmp.hxx
        * also remove earlier exception from ucb modules file
        
        Change-Id: Ie0ad46048147916b615f74d8eab6e033c2020565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126739
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-14  Miklos Vajna  <vmiklos@collabora.com>  [8963dbab857cf8a2f5ff8c75846a686f26303d72]

        sw layout xml dump: handle SwGluePortions
        
        E.g. tab portions.
        
        Change-Id: I6b30a379b2378f81a816011bcb8f27e2717a8876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126746
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-14  David Tardon  <dtardon@redhat.com>  [c74d59a8b47bb8228c297a60e6b5b0cc5e08aa53]

        upload libmwaw 0.3.21
        
        Change-Id: Id28cd361237ce67b76a865ad4291ccece521af85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126768
        Tested-by: Jenkins
        Reviewed-by: David Tardon <dtardon@redhat.com>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [65c0887bca2909b2046eb5aa4aaace0cc320c3f2]

        Allow for conditional parts of component files
        
        1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built
        components" had moved parts of svx/util/svx.component and sw/util/sw.component
        into additional, conditionally included component files (and which this commit
        moves back into the original component files).  But that lead to multiple
        <component> elements for a single library in service rdb files, which was
        unfortunate for several reasons:  For one, while the code in
        cppuhelper/source/servicemanager.cxx happened to support that, it was not
        guaranteed to support it, so this relied on an implementation detail of that
        code.  And for another, for that to work, all the component files for a
        library had to provide identical environment, loader, and prefix (if any)
        attributes, but which was not verified and thus was brittle.
        
        Instead, introduce a CONDITION attribute for the <implementation> elements in
        the source component files, which decides whether or not such <implementation>
        elements are passed through (after dropping the CONDITION attribute) into the
        processed component files (in workdir/ComponentTarget/).  (The attribute
        is spelled all-uppercase to make it more obvious that it is special syntax that
        is not simply passed through to the output component file.)  For now, such a
        CONDITION attribute must have a value that matches BUILD_TYPE:x for some
        feature x in $(BUILD_TYPE), but the syntax can be extended if the need arises.
        
        (gb_Library_set_componentfiles is thus no longer needed and has been removed
        again.)
        
        Change-Id: I360cf4cc0f3a2a738113d430891500715a8fe3a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126560
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [28ff78c950e3480077145f15e7cff36c375a689c]

        Build services_constructors.list from target component files
        
        ...rather than from source component files, so that
        <https://gerrit.libreoffice.org/c/core/+/126560> "Allow for conditional parts of
        component files" (which adds further processing to the translation from source
        to target component files) will also affect the contents of
        CustomTarget_postprocess/components's services_constructors.list
        
        Change-Id: Ie5ef42b91b09f5be0d8d512093a6b7e60aee5b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126644
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Stephan Bergmann  <sbergman@redhat.com>  [daa8e90fc919dd8150c819e342b3f96739d94ca2]

        Revert "add stagingcheck target for unstable/failing tests"
        
        This reverts commit c1f47481eb78df3d73bed1da5020ed6ea565a999.
        Conflicts:
        	solenv/gbuild/Module.mk
        	solenv/gbuild/gbuild.help.txt
        
        It has apparently never been used.
        
        Change-Id: I18a47d740c0a78ae295a60257207ecce66f38a8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126741
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-14  Kohei Yoshida  <kohei@libreoffice.org>  [e9fdfd353f163bd327af5666adb64ab35922a7db]

        Update mdds to 2.0.1.
        
        Change-Id: I7d5e5432d75caf671434977b48b415839cbf90b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126795
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-12-14  Jan-Marek Glogowski  <glogow@fbihome.de>  [250e4886d85a7e131da76f181b3fa7be02d1a76d]

        Fail module-deps.pl on more errors
        
        * Fail on the error code returned from make
        * Collect dependency errors in the tree and fail and print them
        
        The "perldoc -f open" has an example in the "Opening a filehandle
        into a command" section, which uses waitpid in the parent. Since
        we parse the pipe output, there seems to be no need for waitpid,
        because we end when the pipe is closed by the writer.
        waitpid always returns -1 at this point and since there aren't
        any zombie processes, it seems to be fine to ignore.
        Additionally strace shows, clone, execve and waitpid calls, so
        the explicit exit in the example seems bogus, if the process
        is actually overwritten.
        And the pipe is just open in the parent process anyway.
        
        Change-Id: I2e77aa33a0eaa5d6d3e06904bb0af53f4b66ef91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126789
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-14  Jim Raykowski  <raykowj@gmail.com>  [9e046e43fc6d3fecd193da076c0871a458ba71dd]

        tdf#134960 List drawing objects in order of appearance in document
        
        in Writer Navigator drawing objects content type member list
        
        Current code seems like it should work but GetFrameOfModified doesn't
        provide layout position for drawing objects like it does for table and
        frame objects. This patch gets position of drawing object in document
        directly from SdrObject.
        
        Change-Id: I501757900f265370d8e3b606cb4b3a81464e73f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126627
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [98c3dd1b7147ea9c235a65c276e9005290fe108b]

        Fix typo
        
        Change-Id: I848271a9dee0f74c77acf7b311616d11f21d1bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126744
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-13  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5d1f9b98e2c5e42aeef99529409d3b0b9727548d]

        Fix typo
        
        Change-Id: Ie9c1b805578db394ae900560bd5bfe2251161dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126745
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-13  Justin Luth  <justin_luth@sil.org>  [b2fb1631ab5b3c1d9d09aefa0d3a81307e7ffa35]

        related tdf#92010 sc autoformula: ensure proper sorting order
        
        When typing "=a", autoformula was suggesting
        ACCRINT,ACCRINTM,ACOS instead of starting with ABS.
        [This has been true since these 3 suggestions started in LO 5.2.]
        
        Prior to this patch, the very first item in the sorted list
        (ABS) was placed at the end of the suggestion vector.
        That is because the loop immediately increments.
        Since the given initialization value is end(),
        it set begin() as the starting loop value and then
        immediately incremented to item 2.
        Item 1 was finally evaluated last, putting ABS after ZTEST.
        
        The backwards loop handled this properly,
        so do the same thing for the forward loop.
        
        Change-Id: I539c749ea43140a1480d74471787bc886dda671e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126723
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-13  Justin Luth  <justin_luth@sil.org>  [b93a6964e0466c1b67d2c233040357a8f6c75214]

        tdf#92010 sc autoFormula: prefer MRU formulas
        
        Prior to 4.3, only MRU formulas were auto-completed.
        Then it changed to suggest all formulas - alphabetically
        for the most part.
        
        That 4.3 commit 5b0b7553241bb5150b12bbf7625b4b0b36970272
        completely removed all reference to MRU.
        But it makes sense to prefer an MRU over a strictly
        alphabetical match.
        
        This patch depends on LO 7.4 patch
        "new ScTypedStrData: typically missed argument in CTOR"
        
        Change-Id: Id5d860d1401693f43833719977d1c1e4c386385c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126499
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-13  László Németh  <nemeth@numbertext.org>  [6a9cf64ea7509aac258f290cc1f204fd1ce1f974]

        tdf#146208 sw DOCX: fix crash at Redo of tracked table changes
        
        Importing DOCX tables with tracked row deletion and insertion,
        accepting them, Undo, and accepting them again (or Redo)
        crashed LibreOffice, related to the missing Undo support
        of deletions in SwExtraRedlineTable.
        
        SwTableRowRedline is not used for DOCX export since
        commit dbc2bdffbec9b3f7eba485652cdd43634458b5a6
        "tdf#145091 DOCX: don't export obsolete table row change data",
        so it's possible to switch off deletion of row changes
        in SwExtraRedlineTable to fix crashing, keeping SwTableRowRedline
        only to fix the round-trip of the original row change Date
        temporarily.
        
        Change-Id: I6ac571656e45c4299a07a63646bb28d6d1fcd081
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126662
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-13  Justin Luth  <justin_luth@sil.org>  [6a7daa7ece8442e70351eea071bddbe0d24803de]

        NFC simplify sc: !(!A() const || B)  is  !B && A()
        
        Not new AND Is the same tab
        is much easier to wrap your mind around than
        Not (Not the same tab OR New)
        
        Plus it allows avoiding a (trivial) const function call.
        
        Change-Id: Ie0d8a1e490fc3dffe6fc87c9b4d9bd1c41d34dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126733
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [186a275ffb1309fac9c4ef36d5b3126f0350760f]

        gbuild: forward / set linktargetmakefilename
        
        Unfortunatly RepositoryExternal.mk ais generally not forwarding
        this info. It's also not really documented.
        
        Change-Id: I7920f7442521ab06f18c16397a13615e4517d053
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126730
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [f7da3a4ba0a779c4bfa02b867b857f6ca7dcd104]

        Respect verbose setting for module-deps.pl calls
        
        Can't use $(gb_VERBOSE), as this runs pre-gbuild.
        
        Change-Id: I7343ede538a246d54f3ce9fcaf104dfbdea08653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126729
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [17608c5718dbebfaf301b3a00d735161f66b1a69]

        Refactor some buildsytem stuff (mostly whitespace)
        
        Change-Id: Idfca786ecc7251e08525bd5b45936143727c43d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126731
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-13  Stephan Bergmann  <sbergman@redhat.com>  [4fcbf4df8effc91b08d83922bfe0033f43aaa1f6]

        Adapt CompilerTest_compilerplugins_clang
        
        ...to Clang 14 trunk
        <https://github.com/llvm/llvm-project/commit/53219009aaebd2c26028c1df05550183a94c489c>
        "[clang][clangd] Desugar array type."
        
        Change-Id: I6b7e09e4789aa68a679affd7b3c6342409e66af8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126740
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [67763e3c45ff3a1f9df8edecf16c691ff8a053bd]

        Drop desktop_detector from mergelibs
        
        Jenkins lo_callgrind_linux job failed with:
        
        .../vcl/Library_desktop_detector.mk:22: \
           *** Plugins can't be in mergelibs.  Stop.
        
        Regression from commit b2882faf43ea1fa473621d0378c5d87ae3b3d5a2
        ("desktop_detector is also a vcl plugin").
        
        Change-Id: Idc6d867e38d68006b6e1d8a44746085f36ebc5d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126738
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-13  Stephan Bergmann  <sbergman@redhat.com>  [ae6f41424608b349b45eb3f18ee8c7cff5d6c182]

        Revert "Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, too"
        
        This reverts commit 6cb20e0b298f41fe88984aebfe5454f936a0ae3a, now that the test
        failures have been identified as caused by -ffp-contract being enabled, and have
        been addressed with 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a
        presumably more precise result of BESSELY(80,9)",
        04215f03492f6fce83d6bc64491749bf803c389a "Allow for presumably more precices
        results of some more Calc function calls", and
        72b25619960cdaa829c8ea10e27d9c0b20a2c26f "For now, disable tests giving dubious
        results on AArch64".
        
        Change-Id: I78f9ddb04362d4026a272db0b8bbf4717fd75093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126737
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [29bbed22e404700f9538e244df6e02681da1fc1b]

        Remove dubious code in ui file
        
        Introduced in f773e7aa8c96e070085ece95889f02590ed65f89
        < Resolves tdf#144227 - Default command to switch UI >
        
        Change-Id: I1975d6d61a2fd225e87dffe65708a1f5e531f106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126735
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [d8a4713e57bcb2b243743c03f3a5fc735c5e636c]

        ofz#42330 Use-of-unintialized-value
        
        Change-Id: I7281aa335ebeb86afb47aeb31da30933ada7d4bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126732
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [9ba8aec3e6c0872215dc581712f8447c7886d680]

        wwExtraneousParas doesn't have to inherit from anything
        
        Change-Id: Ida6268c29efe501b165c20f7912deee2ddee4685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126726
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Stephan Bergmann  <sbergman@redhat.com>  [f3031ebe98e09d5cebed89ab33480a8e129a02cc]

        Use default gb_COMPILEROPTFLAGS -O2 for LINUX_AARCH64_GCC
        
        235fa0334e0b45c736b636ba1689e2f8c7458697 "Linux AArch64 port" had presumably
        cargo-culted the -Os value (under the name gb_COMPILERDEFAULTOPTFLAGS back then)
        from some other file like solenv/gbuild/platform/LINUX_ARM_GCC.mk, but for no
        apparent reason.  Lets rather use the -O2 default value, as on other 64-bit
        architectures like LINUX_X86_64_GCC.
        
        Change-Id: I21a4c69a6c4339114871be29235f60836798f256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-13  Heiko Tietze  <tietze.heiko@gmail.com>  [e843cb4d7f44302cfeeaed75151943a82d62f217]

        Resolvces tdf#133265 - Mandatory save status
        
        Fine-tuning of Writer's status bar
        
        Change-Id: Iefa60b19c7694e99f0a72205ece68056594c1526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126724
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-12-13  Mike Kaganski  <mike.kaganski@collabora.com>  [620d05c7c8afc286b2a7095c1a79fe4439fb850e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fdedbc8b2e7f9bc4a2bb1620841819bc1cdf7292
          - Make it clear that "compatibility" is a name
            
            Users did not see what they should look for in the dialog,
            and actually searched for "Microsoft Office" since it was
            highlighted.
            
            Change-Id: I7ef8ad3686d7e111a380ba69a7ddf19c1c45eec6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126684
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-12-13  Stephan Bergmann  <sbergman@redhat.com>  [72b25619960cdaa829c8ea10e27d9c0b20a2c26f]

        For now, disable tests giving dubious results on AArch64
        
        when built with -ffp-contract enabled (-ffp-contract=on default on Clang 14
        trunk since
        <https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918>
        "Making the code compliant to the documentation about Floating Point", cf.
        19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably more precise
        result of BESSELY(80,9)"; and -ffp-contract=fast default when building with
        optimizations on GCC) on both Linux (with
        6cb20e0b298f41fe88984aebfe5454f936a0ae3a "Disable
        CppunitTset_sc_*_functions_test for linux_aarch64 for now, too" reverted) and
        macOS.
        
        Change-Id: Ie867d999173410ec9868bd14c0ee04bbba371920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126727
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [beddd069ca6f99536a5e2527a726ac42c7abe40e]

        remove unused forward declare
        
        Change-Id: I5001795a17d6d28e2343ec17f2f368c0b0bf16cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Miklos Vajna  <vmiklos@collabora.com>  [ad7efe4c336dc4c4883cfc3fa74bb4951b92767c]

        sw: prefix members of SwColExample, SwColMgr, SwPageGridExample and ...
        
        ... SwTOXMgr
        
        See tdf#94879 for motivation.
        
        Change-Id: I98968dd8119f005b96eb273c016e7ab3e006a4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126721
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-13  Miklos Vajna  <vmiklos@collabora.com>  [7d1e4d12baa85d47f5945872a3bc186dd6ce1889]

        ODP import/export: refer to theme from shape text color with effects
        
        Handle luminance modulation and offset (i.e. lighter and darker colors).
        
        Change-Id: I536bbca1ed994e991c7ceac153d6a47cb6ef35f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126722
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [416e38c589635b6817a550cb9272e68ddc9bc9e9]

        remove newly unused Menu::InsertItem variant
        
        Change-Id: I796bc10d96ebf0b2269f313a700146c68956dcf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126712
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [984ad86e71a5abb0df7a2c14c61a270e956cba0f]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I486e24b0b85357b43213443c1a9b71206b8f441a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126711
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [9f326792c165ab1bcec7ccb6a3afad1c2b01f7b2]

        only use css::awt::XPopupMenu methods
        
        Change-Id: Icab3bc855e92c5f6389ee8129bcaaa1308619ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126710
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [74094ffd2a138e9776b6a8cc70e64e5f794773ae]

        prefer css::awt::XPopupMenu api
        
        Change-Id: Ibb5984a588e21f9b761b6f56933394874c09dd88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [5ae0a6026c66632e3f6958dd70d785865be2f81c]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I81c892d946965f779d982194efd6b32d6493143e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [843f140289f46bb702674a3875311ef6189d22cb]

        prefer css::awt::XPopupMenu api
        
        Change-Id: Ib52e4091d6a4e0d01aece3eb5f541cd29187a983
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126707
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [cf3bbe3a753ae9246f0ac98f5a8554aa76216eaf]

        only use css::awt::XPopupMenu methods
        
        Change-Id: Ib8e14af038fccd43e79f12b6a5f9371be6a29c43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [604c3140d1efe58177468e96d69e8a1d09d94da5]

        prefer css::awt::XPopupMenu api
        
        Change-Id: Ibf34e33715a86a09ec49495b1049a60e1403a6af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126705
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Caolán McNamara  <caolanm@redhat.com>  [5cbddfc617699e91673ca9a006fc427a37a03a94]

        use XMenu::enableAutoMnemonics instead of Menu::SetMenuFlags
        
        Change-Id: I4d3d8234bb2e643067bed68595a4b22198e38fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [b2882faf43ea1fa473621d0378c5d87ae3b3d5a2]

        desktop_detector is also a vcl plugin
        
        Change-Id: I71445c16744674f75fed190911749f38226169e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126715
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [1aa0a43d60336eb1f0e51805939a7cc00b377a2b]

        tdf#145764 - Change behaviour of BASIC IDE Home Key
        
        Pressing the Home Key moves the cursor to the first non-space character
        in the line, whereas pressing it at the first non-space character moves
        it to the beginning of that line
        
        Follow up of: I8eabb6d01b1a4de0d24bf064f82c83342ca91396
        
        Change-Id: I9f4f0b2b602fa0158488959c2e2029f5da315771
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126702
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-13  Dennis Francis  <dennis.francis@collabora.com>  [93389ff481297540378238891867df08a0c8e2be]

        lok: paint the inputwin directly to the device...
        
        ...using the correct map mode with twips instead of using DrawOutDev()
        to scale what was drawn in a temporary vdev back to the original device.
        
        This fixes the issue:
        
        When window width is large (>3.5k pixels) the text in the window is not
        visible. This was because of the incorrect limiting of the paint area
        width to the paper-width of the editengine.
        
        Change-Id: I46a5c219a6ef07437789fe3de3cbaa245c0e7d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126626
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [5242061cca5332ec15cce8c76f070d16e857445d]

        only use css::awt::XPopupMenu methods
        
        a working example smart tag extension can be found at
        https://forum.openoffice.org/en/forum/viewtopic.php?p=387917#p387917
        
        Change-Id: I2b6232542b27ff7286aa6d4e9bff177e47729954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [7390401fa21d9ebf35d9473bef6b44b42ea7475d]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I29b91b97e36682473241f3d7ab9cde46765830f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126700
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [44680910c15223c83f3681f282475e54f134cbdd]

        only use css::awt::XPopupMenu methods
        
        Change-Id: Ibd3c54b91e757dbca17a4b95462cbd0b7fa16f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126699
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [4304856bfbc7f2a1a5f609b90e404e103268598f]

        these aSolarMutexGuard calls are redundant now
        
        Change-Id: Ic167b8d40c1c93f5e6f4408d260c4e70b4017fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126693
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c0874fcb20b238283d096fc2f22f886c040713cf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d0774bb418359c1135dab327cbc21b32d9513d02
          - Mute l10n for BASIC variable types
            
            Change-Id: I096e41267dfbfa167409b91657c8b2ea015bab1e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126701
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-12  Julien Nabet  <serval2412@yahoo.fr>  [a5f2f989a0a7a5b602b7f3e39e99d7f4c2342cee]

        tdf#146179: fix Dev Tools crash when inspecting object in special file
        
        0  0x00007f3177297361 in SvxUnoTextBase::createEnumeration() (this=0x313ba98) at editeng/source/uno/unotext.cxx:1911
        1  0x00007f317729751d in non-virtual thunk to SvxUnoTextBase::createEnumeration() () at editeng/source/uno/unotext.cxx:1918
        2  0x00007f31755c2a7b in (anonymous namespace)::GenericPropertiesNode::fillChildren(std::unique_ptr<weld::TreeView, std::default_delete<weld::TreeView> >&, weld::TreeIter const*)
           (this=0x7ffee92c8140, pTree=std::unique_ptr<weld::TreeView> = {...}, pParent=0x0) at sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:719
        3  0x00007f31755c15f1 in ObjectInspectorTreeHandler::appendProperties(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
           (this=0x8e499d0, xInterface=uno::Reference to (SvxPluginShape *) 0x313b8e0) at sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:1270
        4  0x00007f31755c0e85 in ObjectInspectorTreeHandler::NotebookEnterPage(rtl::OString const&) (this=0x8e499d0, rPageId="object_inspector_properties_tab")
           at sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:1154
        5  0x00007f31755befa0 in ObjectInspectorTreeHandler::LinkStubNotebookEnterPage(void*, rtl::OString const&) (instance=0x8e499d0, data="object_inspector_properties_tab")
            at sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:1129
        ...
        (gdb) p GetEditSource()
        $2 = (SvxEditSource *) 0x0
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=176872
        
        Change-Id: I1f3f48c742a2a3c6a2abcb2ed06d8f60e6f7a77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126666
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [afa35742a4633db31b6d6c72cf45741506e9edfb]

        prefer more css::awt::XPopupMenu api
        
        Change-Id: Ib008281d63071ea79935af83cbe434be66155455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [569de88e9c7eda964252518282d26a8f7d059718]

        prefer css::awt::XPopupMenu api
        
        and using GetXGraphic will return a vcl unographic::XGraphic which
        also supports XBitmap as well as XGraphic so we can check if
        the XBitmap we're passing around supports XGraphic and use that
        if it does and drop the imagewrapper in favor of doing that
        
        Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [73e9e027e9978cf5136731118f18b832bd361181]

        remove menu "Change id" hack
        
        this was introduced with the cryptic:
        
        commit e52717eefb2cbf94b70e4620652c1e8848a30c82
        Date:   Mon May 26 07:30:41 2003 +0000
        
            INTEGRATION: CWS fwk03 (1.34.20); FILE MERGED
            2003/05/16 09:58:43 mba 1.34.20.1: #109534#: change in unoctitm.cxx revealed another problem - after ContextMenuInterception slotids might have vanished, so no Controllers can be created
        
        in the two remaining uses currently in.
        
        sw/source/uibase/docvw/edtwin.cxx and
        sw/source/uibase/uiview/viewling.cxx
        
        I can't see that this could do anything useful anymore. There were other
        uses in the past however.
        
        Change-Id: Ic707566e603bb3b3f6e70bf3fc2581e799828253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [0785b76c0060055413ee18842a82649a35277449]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I880a5561ad0b1c41fc171f3dff0475d25704172b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126690
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Caolán McNamara  <caolanm@redhat.com>  [40a382a8e49d544be7accee6cc846de96c3d36e6]

        cid#1399158 Uncaught exception
        
        and
        
        cid#1495379 Uncaught exception
        
        Change-Id: I8ec5ca64c3dda79c72bb91ba4651134fe9c4ffc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-12  Mike Kaganski  <mike.kaganski@collabora.com>  [89070c8021d483ec84a3b6f465543c733208b1dc]

        Small simplification
        
        Change-Id: I9a6d134b9af46e84560a9f6160c4f9fa1d2631ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126696
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-11  Eike Rathke  <erack@redhat.com>  [06ac18e6302d666c363740644a7976e8c22d1113]

        Update reference links for ISO 639 and 3166
        
        SIL has restructured their site, and ISO either moves things
        around or doesn't make them available at all. For 3166 use
        Wikipedia if ISO doesn't want to be a reference..
        
        Change-Id: I2f906376c081667f57d48fa0386015a90857aae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126689
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-11  Caolán McNamara  <caolanm@redhat.com>  [b31e525bc210c6e9168d67d5ea8c53206974f196]

        prefer css::awt::XPopupMenu api
        
        Change-Id: I1d930c1c7ea06d066f3ae35eb0535290a02a2f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126663
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-11  Julien Nabet  <serval2412@yahoo.fr>  [41200eb5f542f5aa744f90cbd56d614b02e1ee47]

        Fix regression in connectivity/evoab2
        
        Regression from 46d3e84d7a131f7c72cb536ab2f314cb55ffc155
        Directly initialize vector in connectivity (part 2)
        
        Pinpointed thanks to this log:
        warn:dbaccess:612118:612118:dbaccess/source/core/dataaccess/connection.cxx:344: DBG_UNHANDLED_EXCEPTION in OConnection exception: com.sun.star.sdbc.SQLException message: Invalid descriptor index. /home/julien/lo/libreoffice/connectivity/source/commontools/dbexception.cxx:365 SQLState: 07009 ErrorCode: 0
            wrapped: void message: /home/julien/lo/libreoffice/tools/source/debug/debug.cxx:104
        when launching Base then connecting to Evolution local.
        
        Change-Id: Id4cb0fc322b0df24ed2b2d89a5595f4841db1845
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126664
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-11  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [809236ed826b67328409e008313dea87de6d5243]

        tdf#145764 - BASIC IDE Home Key: move cursor to the beginning/first character
        
        Pressing the Home Key moves the cursor to the first character in the
        line, whereas pressing it at line start moves it to the first character
        in that line.
        
        Change-Id: I8eabb6d01b1a4de0d24bf064f82c83342ca91396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126548
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-12-11  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0040076af3e1f45f43435d83335ef8cee8e6ab0c]

        Fix typos
        
        Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [ecdb4b347014ed38a5e069fb802b5cb8cfd42a70]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fa7fd622849d9e31d3f27e3762b0a0e578838cc0
          - Silence strings for l10n in sbasic/shared (Part 2)
            
            Change-Id: Ia14a0773d1dc13eaf8737eca3f68594eb1bb8054
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126670
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-12-11  Caolán McNamara  <caolanm@redhat.com>  [277a5ac359801712d4b8448ae096d45a6522228b]

        update sw pches
        
        Change-Id: I61fe51e95c629adcf90a9ea3d1783380039fdd5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-11  Caolán McNamara  <caolanm@redhat.com>  [49528082f2070268c0b1507ce6e63aa7e5794467]

        keep as css::awt::XPopupMenu through another layer of api
        
        Change-Id: I36e98e45d7d8ea092b1c58aea83652fe5df7bb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-11  Mike Kaganski  <mike.kaganski@collabora.com>  [21154ea8c450f9f5568b32123d34a20e498a9290]

        tdf#146173: combine non-BMP characters' surrogates correctly
        
        Change-Id: Ib3af1f9e461f133d2f5b09b9db4fb87c1ede0b9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126658
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-11  László Németh  <nemeth@numbertext.org>  [692bc46b25db61176b4ced7b7beffeca7d55068e]

        tdf#146140 sw DOCX import: fix moveFrom regression with broken text content
        
        (Also a small clean-up: increase the character limit for tracked text
        moving detection: Only 2 or more (non-whitespace) character deletions
        are checked for it, because single characters are often typos or some
        control-like characters, e.g. soft hyphen, not real text movings.)
        
        Details of the regression: commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be
        "tdf#123460 DOCX track changes: moveFrom completely" fixed
        the missing redline import of the end of the moved paragraphs,
        but paragraph end was imported as w:del, not w:moveFrom explicitly.
        From commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving"
        this resulted two deletions (a moved one and a plain one) instead of
        the previous single one.
        
        Moreover, exporting these double deletions at the same position to
        ODT, raised a back-compatibility issue with broken text content, see
        tdf#107292 (solved recently, but not in older LibreOffice versions).
        
        Removing the explicit w:del code path in writerfilter, it solved
        the regression from commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving".
        
        See also commit 9e1e88ad5cf2dc0e9b188c60930445652a6c7519
        "tdf#145720 DOCX export: fix loss of tracked moving".
        
        Change-Id: I15bfc83b87dd42a762ff84edf5bae765fe02a5ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126631
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-11  Luboš Luňák  <l.lunak@collabora.com>  [b9e1d9fac994754e775899889cf601d303dba688]

        explain the intent of HasDrawTransformedBitmap() better
        
        Change-Id: I32d6cfb7358dae25109de4db3332797763abc7d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126506
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-11  Luboš Luňák  <l.lunak@collabora.com>  [68ad2dd46dd42d81b576b3e61659c39f381790b6]

        don't duplicate SalGraphics docs in SalGraphicsImpl
        
        It's incomplete anyway, and it's annoying to do it twice. Simply
        refer to SalGraphics.
        
        Change-Id: I6a28709e2e68ba565176ea3ddf67bd17ecf3d1e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126505
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-11  Justin Luth  <justin_luth@sil.org>  [297ab561c6754f89326a1e8ce1751233669578d7]

        tdf#128895 sc xmlimport: create enough dynamic cols if props
        
        Since LO 6.3, only 64 columns are created by default,
        where previously it was a fixed 1024.
        
        A common user practice is to hide all columns not used,
        but this collapsed property was lost because
        only part of the columns were actually created and thus exported.
        
        In this example, import specifies 1017 hidden columns (H-AMJ),
        but since only 64 columns are created, export only specified 57.
        
        So ensure that on import, any column with defined properties
        is created - even if they don't contain any content.
        
        Change-Id: If928880baf5585613715a1f4361a9059584d1ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126540
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-12-11  Hossein  <hossein@libreoffice.org>  [489d7298d2e609ee5900f05ba0064845a7a551ce]

        Use g_get_real_time instead of g_get_current_time
        
        g_get_current_time() which is deprecated, is replaced by the newer
        function g_get_real_time() in which is available since glib 2.28.
        
        Function GLib > get_real_time
        https://docs.gtk.org/glib/func.get_real_time.html
        
        Change-Id: I371c2efc290e70410b84346ed47d721ae9547273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126374
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [29db6dc9fbeb8314553d02a9519a4cb8161256f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bba53dc2eb06941ab4e9b9c22722b22c19cd3698
          - Silence strings for l10n in sbasic/shared (Part 1)
            
            These strings are appearing for translation in Weblate
            but they're pure Basic code/syntax that does not need translation.
            
            Change-Id: I8a3f16fcb23f18a2b2b46eb7eaf8bbf74023dd84
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126606
            Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-12-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0e0c15f45a5667814b31ad5f792caf1a0a91308]

        tdf#102506: sc: Add UItest
        
        Change-Id: I3b104623289bb18d13f75b90bffcda4e65c6707d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126653
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [93388cca19810b41cb45b3770dd6212345e65a14]

        cid#1485150 suppress Uncaught exception
        
        Change-Id: I3baac0b02a3d1eef150cb78873ffbee51282b0db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126654
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [bff9f1719a230d031f4914d3412d69701fcaf3d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6fa6b45d603d01cb30549cdf9d1c56fa9376aa67
          - tdf#144133 Fix help target for Expert Config Edit dialog
            
            When the user opens the "Expert Configuration" dialog, selects a preference and double clicks it, another dialog is opened to edit the preference value. Clicking "Help" in this second dialog leads to a 404 page not found error.
            
            This patch changes this behavior so that clicking the Help button opens the "Expert Configuration" help page.
            
            Change-Id: I0104617153f710b09c7436b7f5e3faa78cddb2bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126507
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-10  Stephan Bergmann  <sbergman@redhat.com>  [ccce752f42adbabe04e221452ceb287b12b678e3]

        Allow for presumably more precise results of some layout calculations
        
        ...similar to 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably
        more precise result of BESSELY(80,9)", where at least on macOS ARM64 Clang 14
        trunk (defaulting to -ffp-contract=on now) started to produce values that caused
        CppunitTest_chart2_xshape to fail with
        
        > Test name: Chart2XShapeTest::testPieChartLabels1
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
        > - Node: /XShapes/XShape[2]
        > - Attr: positionY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels2
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-2.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: positionY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels3
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-3.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: positionY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels4
        > double equality assertion failed
        > - Expected: 3892
        > - Actual  : 3893
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-4.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: positionY
        
        and
        
        > Test name: Chart2XShapeTest::testPieChartLabels1
        > double equality assertion failed
        > - Expected: 9723
        > - Actual  : 9722
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
        > - Node: /XShapes/XShape[2]
        > - Attr: sizeY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels2
        > double equality assertion failed
        > - Expected: 9723
        > - Actual  : 9722
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-2.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: sizeY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels3
        > double equality assertion failed
        > - Expected: 9723
        > - Actual  : 9722
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-3.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: sizeY
        >
        > Test name: Chart2XShapeTest::testPieChartLabels4
        > double equality assertion failed
        > - Expected: 9577
        > - Actual  : 9576
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-4.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]
        > - Attr: sizeY
        
        and
        
        > Test name: Chart2XShapeTest::testPieChartLabels1
        > double equality assertion failed
        > - Expected: 9724
        > - Actual  : 9723
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[2]/Transformation/Line2
        > - Attr: column2
        >
        > Test name: Chart2XShapeTest::testPieChartLabels2
        > double equality assertion failed
        > - Expected: 4861
        > - Actual  : 4860
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-2.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column2
        >
        > Test name: Chart2XShapeTest::testPieChartLabels3
        > double equality assertion failed
        > - Expected: 4861
        > - Actual  : 4860
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-3.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column2
        >
        > Test name: Chart2XShapeTest::testPieChartLabels4
        > double equality assertion failed
        > - Expected: 4788
        > - Actual  : 4787
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-4.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column2
        
        and
        
        > Test name: Chart2XShapeTest::testPieChartLabels1
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-1.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[2]/Transformation/Line2
        > - Attr: column3
        >
        > Test name: Chart2XShapeTest::testPieChartLabels2
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-2.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column3
        >
        > Test name: Chart2XShapeTest::testPieChartLabels3
        > double equality assertion failed
        > - Expected: 3819
        > - Actual  : 3820
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-3.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column3
        >
        > Test name: Chart2XShapeTest::testPieChartLabels4
        > double equality assertion failed
        > - Expected: 3892
        > - Actual  : 3893
        > - Delta   : 1e-08
        > - Reference: chart2/qa/extras/xshape/data/reference/tdf90839-4.xml
        > - Node: /XShapes/XShape[2]/XShapes/XShape[3]/XShapes/XShape[1]/XShapes/XShape[2]/XShapes/XShape/XShapes/XShape/XShapes/XShape[5]/Transformation/Line2
        > - Attr: column3
        
        Change-Id: Iae3b53c2b8149c78f525ed403b7fe2a20f837427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126641
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-10  Stephan Bergmann  <sbergman@redhat.com>  [04215f03492f6fce83d6bc64491749bf803c389a]

        Allow for presumably more precices results of some more Calc function calls
        
        ...similar to 19559ebbee160d1625d06feec7e6566772dad231 "Allow for a presumably
        more precise result of BESSELY(80,9)", where at least on macOS ARM64 Clang 14
        trunk (defaulting to -ffp-contract=on now) started to produce values that caused
        various CppunitTests to fail (and only one of which had been addressed in
        19559ebbee160d1625d06feec7e6566772dad231, for starters).  The discrepancies
        addressed by this commit are:
        
        * CppunitTest_sc_financial_functions_test:
        ** sc/qa/unit/data/functions/financial/fods/rate.fods:
        *** row 23: actual 0.250000095659014 vs. expected 0.250000092908987
        
        * CppunitTest_sc_statistical_functions_test
        ** sc/qa/unit/data/functions/statistical/fods/chisq.test.fods:
        *** row 10: actual 1.66789802691648E-016 vs. expected 1.66789802691649E-16
        ** sc/qa/unit/data/functions/statistical/fods/chisqinv.fods:
        *** row 58: actual 3.00000000000001E-001 vs. expected 0.299999999999999
        ** sc/qa/unit/data/functions/statistical/fods/chitest.fods:
        *** row 10: actual 1.66789802691648E-016 vs. expected 1.66789802691649E-16
        ** sc/qa/unit/data/functions/statistical/fods/forecast.ets.mult.fods:
        *** row 79: actual 268.59802115122 vs. expected 268.598021151221
        
        Change-Id: I4439f59394feadd2d6406dc4c4f985f479cd8fe0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126640
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [69c62b009d220b7553374151f81149f8eec16f42]

        merge fixes to zxing's copy of stb_image
        
        see: https://github.com/nu-book/zxing-cpp/pull/269
        
        CVE-2021-28021 CVE-2021-42715 CVE-2021-42716
        
        though it's unclear if there is any relevence to our usage of zxing-cpp
        
        Change-Id: I30fa7682af56c432b651d8c0385f1b85c3582101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126647
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [a298718eb807c1857cb488a2915126de331ccafa]

        Related: tdf#146018 constrain submenu to window like toplevel menu
        
        so under wayland it not go off-screen
        
        Change-Id: I69f4f71cffaf4e4ac4def87d71b947e2dd903a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126643
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [f40390d98f45e6cb19ad896dc30eff07f746942f]

        Resolves: tdf#145974 reduce the papersize by scrollbar thickness
        
        if scrollbar required and scrollbar isn't an overlay one
        
        Change-Id: I839fd8c214febadb80f692b53dc156e251f506ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [70591eb5efb9f4e5596b32d1e3c9368b9e9726a4]

        ofz#42182 oss-build failure
        
        since...
        
        commit 47aabde053a1472dc32770da29d68c8de5bd7919
        Date:   Thu Dec 2 12:37:07 2021 +0200
        
            Make the tdf#97983 changes to BASIC optional
        
        where LibreOffice6FloatingPointMode is called from
        code not inside !HAVE_FEATURE_SCRIPTING
        
        [LNK] Executable/pptfuzzer
        basic/source/sbx/sbxvalue.cxx:1343: error: undefined reference to 'LibreOffice6FloatingPointMode()'
        basic/source/sbx/sbxvalue.cxx:1328: error: undefined reference to 'LibreOffice6FloatingPointMode()'
        basic/source/sbx/sbxvar.cxx:456: error: undefined reference to 'LibreOffice6FloatingPointMode()'
        basic/source/sbx/sbxvar.cxx:441: error: undefined reference to 'LibreOffice6FloatingPointMode()'
        clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
        make[1]: *** [/src/libreoffice/vcl/Executable_pptfuzzer.mk:13: instdir/program/pptfuzzer] Error 1
        make: *** [Makefile:170: Executable_pptfuzzer] Error 2
        
        Change-Id: I8e635df26f30edf8acd9c148590d034e8b13c056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Armin Le Grand  <Armin.Le.Grand@me.com>  [2c6e2fa596d4ecb22adb062a837f1bbf4384fed2]

        Revert "Re-Enable DrawTransformBitmapExDirect for render backends"
        
        This reverts commit 7e5af164b7d293dd410710bed411e1ca64bbecf7.
        
        Reason for revert: Not the best/effective way to clear out the stuff remaining to be done, would need additional stuff
        
        Change-Id: Ia6ab90384da29a5e34eff0ab8881bad2ab49c58c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126601
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [6494fba15ea93283b625bf6bdb4666709f22439f]

        more ofz#42182 oss-build failure
        
        Change-Id: I8960db6c013911df26b35623814c5586ce8c3d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [3392f567be8d52804b187b0bced47204ef38fa3c]

        tdf#146048: detect UTF-16 without BOM
        
        Change-Id: I3c1742cdf88dfa08cf35d9f95875d4d3d6af09db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126596
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [ecd8f448327fbdfcef86e8706ee8b74e3b886dce]

        ofz#42182 oss-build failure
        
        possibly since:
        
        commit db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3
        Author: Stephan Bergmann <sbergman@redhat.com>
        Date:   Thu Dec 9 10:15:05 2021 +0100
        
            Generally determine Rdb content from gb_*_set_componentfile calls
        
        (?)
        
        Change-Id: I947b0dff174ef437750889fb6cc84c8dfa54e7f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126638
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [a25a573d5714ab196bbcdbd3a8dcb6d6d7814882]

        Related: tdf#146018 allow user to grow/shrink autofilter checklist by a row
        
        Change-Id: If337f62032a8db6d1d01c66ae851a1111ad8b0bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126636
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [0f17661e045e3e3732cec6e493cd20ac65dbe451]

        add resize_to_request to popover
        
        Change-Id: I4bd549efd934946f355f06645ed816acd370a51d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Julien Nabet  <serval2412@yahoo.fr>  [e369efa01183b4c304b49603628a7393aeb9ced0]

        [loplugin:external] in vcl/skia/SkiaHelper.cxx
        
        Following 2c86b79e87bc8579f5213708954d5c85fe231407
        cache Skia drawing based on checksum of bitmap content (tdf#146095)
        
        Change-Id: I184a7d96988b7a52100de026c13f422590755ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126635
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-12-10  Mike Kaganski  <mike.kaganski@collabora.com>  [1f1ce06a185abcbf0c533cb3aa288418ecaa5ef4]

        Make BOM detection slightly more straightforward
        
        Without taking system endianness and current stream endianness
        into account - just read and check single bytes.
        
        Change-Id: I9273d8f403caad7adb5e11cecc04e326919dad1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126595
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-10  Justin Luth  <justin_luth@sil.org>  [16376cae68f4406ef9440bdcb7b9617de6a6f998]

        tdf#144680 mailmerge toolbar: disable all icons if no resultset
        
        followup to my previous patch. I had played with this,
        and do to poor testing or some residual effect,
        I thought this wasn't necessary to disable the
        movement buttons specifically. But in renewed
        testing it is clear that it isn't magic that
        causes the disabling at the proper time.
        
        Change-Id: Ic57dba42d649e79bd1db2b95f8f4316e772ccaeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126628
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-10  Julien Nabet  <serval2412@yahoo.fr>  [b60bc1e597032e598caf43d1a13409068b800f57]

        Related tdf#102506: make Find Bar Ctrl+F searching by value by default
        
        Change-Id: I4c001b60eecbcdae95cde6d79cc91bb887d7a742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126490
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-10  Luboš Luňák  <l.lunak@collabora.com>  [2c86b79e87bc8579f5213708954d5c85fe231407]

        cache Skia drawing based on checksum of bitmap content (tdf#146095)
        
        Previously the caching was based on SkImage's uniqueID(), which
        detects whether it's the same image. For caching to work based on
        this it is required that the underlying image does not change,
        which generally means using the same Bitmap(Ex) for repeated drawing.
        But e.g. in tdf#146096 canvas (AFAICT) tries to cache bitmaps
        by copying them around, which generates so many bitmaps that they all
        do not fit in the cache (helped by the fact that the edit window
        still animates them too, and bitmap caching in canvas being broken).
        
        It feels kinda lame and unnecessary to checksum pixels of many bitmaps
        to be drawn just to find out whether their drawing can be sped up,
        and it really should be fixed higher up wherever it's broken, but
        I've already failed several times trying to fix this in canvas,
        so let's just roll with this.
        
        This is done only for raster-based images, because GPU-backed drawing
        is fast enough to deal even with expensive drawing (and fetching
        GPU-backend pixels would be expensive).
        
        On my machine this changes showing the slide from not being able
        to quite keep up to about 20% CPU usage.
        
        Change-Id: I25a362a02dc61e99b391cb305e2fdcd2feb67879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126613
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-10  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [110d3504c1f738a1d7f740cc212064dafa4fb224]

        tdf#127341 Do not activate TextEdit at right-klick on URL in calc
        
        Change-Id: I1881c007a05f56d5cb7914da56243f551c2da1cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126618
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-10  Luboš Luňák  <l.lunak@collabora.com>  [5b0e9e8c18205dd9b06cbcec146cefa1acef4f32]

        return value by simply returning it
        
        Change-Id: I0c3443f182db697d12fb8bc8a356d989b62847df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126610
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-10  Luboš Luňák  <l.lunak@collabora.com>  [63b8d83fd0d135af4ac04f78d26bfd3322ab65f6]

        make sure Skia bitmap checksum is invalidated properly
        
        Change-Id: I85e81b730dcb0fdc7728d5a956974ef09a73de87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126585
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-10  Luboš Luňák  <l.lunak@collabora.com>  [a78040cabc6878e06e7519d6d53a0ef6e5c4d658]

        don't use 32bit Skia bitmaps if not configured so
        
        Change-Id: Ic7781f799d0d4baef01955f03ace8428b6d9f229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126584
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-10  VaibhavMalik4187  <vaibhavmalik2018@gmail.com>  [6565f0d23737868fbbd1aa78c08223dd255e1924]

        tdf#143148 Use pragma once in vcl
        
        Change-Id: Iffad4effaeef46663d8a57110bf2d560e81d0d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126629
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [d8aae8057d76743cfc1591cbffda2f54c338a213]

        Related: tdf#146018 move Top10 below empty/not-empty add add Bottom10
        
        Change-Id: I3333c44b84dea8f8b1e61872606b50e9a384d8c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126621
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [f38d7a7c1abdfb59fbbdf4d9bbc8e06fbed77887]

        restore autofilter to a row taller, now it has less menu items
        
        Change-Id: Id6f8b5648eb10d8f44ed3c76836d3b96fd86103e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126533
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [e2d498b778a3dac70a7faee4d1bbabb50cdcc103]

        tdf#146018 group filtering options under a single dropdown
        
        Change-Id: I91afb746485654ed8e1418d17d4b172332b3f1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126532
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [9e8789f2186d16a895cd659b321e5001ea239658]

        remove use of non-existing slot:6661
        
        seeing as this call does nothing since ~2006
        
        see:
        commit 01552f1e77c67f70ffd879294288612f9ab64e3b
        Author: Stephan Bergmann <sbergman@redhat.com>
        Date:   Fri Oct 17 16:58:26 2014 +0200
        
            SID_TOGGLE_MENUBAR (aka slot:6661, .uno:MenuBarVisible) is dead
        
            ...since introduction of XLayoutManager's private:resource/menubar/menubar in
            3fb2acf5b77bff59909f616c44c7de17048b64d7 "INTEGRATION: CWS layoutmanager
            (1.52.10); FILE MERGED" etc. and final removal of SID_TOGGLE_MENUBAR bits in
            f605b16e395e8ccc3d1aba7907b0792039016f69 "INTEGRATION: CWS sfxcleanup (1.119.8);
            FILE MERGED" etc.
        
            What still needs fixing are
        
              extensions/source/activex/SOActiveX.cxx
              odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java
              odk/examples/OLE/activex/SOActiveX.cpp
        
            in a similar way as e.g. 0273d3d81d29d5c1f6c387cca633cd99722c100e "INTEGRATION:
            CWS jl18 (1.6.8); FILE MERGED."
        
        these uses remain outstanding:
        odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/CustomizeView.java
        odk/examples/OLE/activex/SOActiveX.cpp
        
        Change-Id: Iad43b5adc6ae24e6d794ebef10ed7df476b4e5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126622
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [b4f5dc552ae8fefa9fee0381399696e2c68bdec0]

        rename SwAnnotationWin::mnEventId to SwAnnotationWin::mnDeleteEventId
        
        because its solely used to track if an event was posted to delete the
        annotation
        
        Change-Id: I7c6458475e967b8f313f1a770946c0db65561434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126624
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Caolán McNamara  <caolanm@redhat.com>  [7c11589b54cfe212dfa90e5c3c29000c0c503748]

        Resolves: tdf#146141 don't double delete comments
        
        which can happen because empty comments are deleted automatically
        on losing focus back to main document, so explicit delete of an
        empty comment resulted in a double delete
        
        Change-Id: I30390995a260235ed8702b0a088c05e91c953b3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126623
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-10  Michael Weghorn  <m.weghorn@posteo.de>  [8e586c366d0b27646c5bbe7623b6e9bfc4df0e14]

        sc a11y: Handle FOCUSED state for cell
        
        Implement handling for the FOCUSED state of a cell, similar to
        how 'ScAccessibleSpreadsheet::IsFocused' does for a
        spreadsheet.
        
        (The fact that the state was not handled before turned out
        to be the cause for the NVDA and Orca screen readers no longer
        announcing the focused cell with some other local WIP changes to
        winaccessibility and qt5/qt6 accessibility in place.)
        
        Change-Id: I0334e98cd306189196cf3ee2e5e48f87eb3748c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126619
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-12-10  Stephan Bergmann  <sbergman@redhat.com>  [db3a61cd958f4a70417929cf8e1fa9bfd0bfe5a3]

        Generally determine Rdb content from gb_*_set_componentfile calls
        
        ...instead of by listing the content somewhat redundantly in the Rdb_*.mk
        files, to avoid duplication of logic for components that are only built
        conditionally (and thus should only be included conditionally in the
        corresponding Rdb).  To achieve that, add an "rdb" parameter to
        gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros
        that internally call gb_ComponentTarget_ComponentTarget), which is used to make
        the appropriate gb_Rdb_add_component call internally from within
        gb_ComponentTarget_ComponentTarget.  (As a special case,
        gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that
        has already been done by the corresponding gb_Library_set_componentfile call, so
        allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to
        support that special case.)
        
        Most Rdb_*.mk files are thus mostly empty now.  One exception is
        i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as
        needed during the build in CustomTarget_i18npool/localedata.
        
        1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built
        components" had already tried to do something similar (in addition to other
        things) under a new --enable-services-rdb-from-build option.  However, that
        approach had four drawbacks that this approach here addresses (and which thus
        partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b):
        
        1  Rdb_services shall not contain the component files of all libraries that are
        built.  While that commit filtered out the component files that go into
        Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files
        that go into others like Rdb_postgresql-sdbc
        (connectivity/Rdb_postgresql-sdbc.mk).
        
        2  The code added by that commit to Makefile.gbuild codified the knowledge that
        there is an Rdb_services, which is brittle.
        
        3  The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge
        (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle.
        
        4  Introducing an --enable-services-rdb-from-build option needlessly provided
        two different ways how the content of Rdb_services is assembled.
        
        The changes done here would leave --enable-services-rdb-from-build as a
        misnomer, as it no longer controls how Rdb_services is assembled.  I thus
        renamed it to --enable-customtarget-components, as that is apparently what it
        still does now.
        
        Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-10  Heiko Tietze  <tietze.heiko@gmail.com>  [5b0707f66e2c49a11f3a23e3ec9940b26d881165]

        Resolves tdf#145976 - Resizing issues with the macro dialog
        
        Fill attributes removes; some spacing added to be HIG conform
        
        Change-Id: Ic45bab071db23498e98df5fbed34ee5a50df1390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126569
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-12-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3d6e6ade172f90b546cab6ee7a7441080fa3a41]

        merge setUnoShape and impl_setUnoShape
        
        since the one purely forwards to the other
        
        Change-Id: I5f614cc1eb819572a55da57d9d6c9ae56b9139c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126608
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-10  Justin Luth  <justin_luth@sil.org>  [9a115a254171d702a56a93c5c7e320de755dc8e8]

        tdf#144680 mailmerge toolbar: enable icons unless no resultset
        
        This fixes a problem introduced in LO 6.3 (backported to 6.1.5)
        via commit 60714a814847f6d10f00aa6809a3896a48741e0b
        tdf#121606: displaying Mail Merge toolbar shouldn't activate connection
        
        Before 6.1, a user needed to run the mailmerge wizard
        (or start the toolbar manually) in order to have
        the mailmerge toolbar become available. In either of those cases,
        the connection to the database was attempted and thus enabled
        or disabled the various buttons based on the status. All good.
        
        In 6.1, the toolbar was started on document load,
        as soon as database fields were detected.
        Sounds reasonable - good context sensitive UI.
        
        The problem is that databases can often be password protected,
        or on slow, remote sites. Thus the 6.3 commit mentioned above,
        which disabled most buttons until the connection was established.
        
        Well, having disabled buttons isn't too helpful,
        and basically put us back to needing the extra step of
        running the mail-merge wizard anyway.
        The only problem with leaving them enabled is that we need to
        ensure that we don't run the functions with bad results.
        
        So sure - this means that a user thinks they can use the
        mail-merge, attempt it, and then may find the buttons disable
        when it won't work. That is the same as the forward/backwards
        buttons though, so no big deal. Plus it is good feedback that
        something isn't right (which will rarely ever be true).
        
        The only time the buttons disable is for non-existant resultsets.
        [Note that buttons do NOT disable for a wrong password,
        or for a remote connection that can't be established.
        And that is what we want anyway, so that further attempts
        can be made after fixing the underlying problem.]
        
        Change-Id: I3e82d2d3b35d04632650933c768cb0b5c006cb6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126625
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-10  Justin Luth  <justin_luth@sil.org>  [ac1ea5944a236efef75af7c85d0ffe10d374e7fa]

        new ScTypedStrData: typically missed argument in CTOR, tdf#142910 follow-up
        
        Pretty much any attempted use of eType was completely wrong and lost.
        
        Regression from
        
            commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
            CommitDate: Wed Jul 7 17:44:46 2021 +0200
        
                tdf#142910 sc filter: fix "greater than" or "smaller than" etc
        
        Most calls to this are missing the "rounded number" argument,
        so the enumator is actually accepted as the double fRVal,
        and the StringValue eType was left as the default value (Standard),
        instead of the intended enumerator.
        
        0.0 looks too much like 0, 0 to even notice in
        casual code reading.
        
        This had rendered the type mostly irrelevant.
        
        Change-Id: If4fa69d4b3077981244a2c3a785f80b77f9f9501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126453
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-10  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [885465bc0ae6029d8adad57015fb0ff6c26a6ba6]

        tdf#133353, Make 2nd argument optional for DCOUNT and DCOUNTA.
        
        The functions accept empty second arguments, but the function
        wizard and hints stated that it was required.
        
        Change-Id: I74fcfcc31492ed776085d1bc6ee6a9ff22a87818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126620
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-10  Stephan Bergmann  <sbergman@redhat.com>  [19559ebbee160d1625d06feec7e6566772dad231]

        Allow for a presumably more precise result of BESSELY(80,9)
        
        When Clang 14 trunk changed from defaulting to -ffp-contract=off to
        -ffp-contrace=on with
        <https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918>
        "Making the code compliant to the documentation about Floating Point" ("even
        when optimization is off",
        <https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd>
        "Making the code compliant to the documentation about Floating Point"), at least
        a macOS ARM64 build started to fail CppunitTest_sc_addin_functions_test
        CPPUNIT_TEST_NAME=AddinFunctionsTest::testAddinFormulasFODS with
        
        > double equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        > - Delta   : 1e-14
        
        because in sc/qa/unit/data/functions/addin/fods/bessely.fods, BESSELY(80,9)
        evaluates to 0.0340917220777503, so comparing it against the expected
        0.0340917220777493 with ROUNDSIG(...,12) fails.
        
        The expected value stored in bessely.fods has been like that ever since
        c3fc9ac6ef1be34e4683c0c5fb7f5f116da9c59e "add BESSELI,BESSELJ,BESSELK,BESSELY
        test case", and presumably is what Calc happened to produce for the test author
        (rather than taking the expected value from some authoritative source).  And
        Calc presumably has no authoritative idea about the expected value of
        Bessel(80,9) anyway, beyond what the C++ source code happens to produce with a
        given C++ compiler and compiler optimization settings on a given hardware
        architecture.
        
        However,
        <https://functions.wolfram.com/webMathematica/FunctionEvaluation.jsp?name=BesselY&ptype=0&n=9&z=80&digits=15>
        gives 0.0340917220777507, and julia-1.7.0rc3-1.fc35.x86_64 gives
        0.034091722077750686 (`using Pkg; Pkg.add("SpecialFunctions"); using
        SpecialFunctions; bessely(9, 80)`), which are both closer to the actual Clang 14
        trunk macOS ARM64 value than to the stored expected value, making it likely that
        the actual value is more correct than the expected one (in line with the
        observation in the Clang documentation that with -ffp-contract=on "fused
        operations are permitted to produce more precise results than performing the
        same operations separately").
        
        Change-Id: I3c3db4099c83c01d0f14e08a694fb0977cb6863c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126617
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [8409df4a29857acefb6e7d7d6f33e1011a65b070]

        sc: avoid dynamic_cast when possible
        
        After b9362e87a3646a6693b81fb0d40e28ce7813a251
        < tdf#145671 Don't open URL twice in cell edit mode >
        
        Change-Id: I7b5b00aa48092666640927d268bc9d5bde0d24e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126586
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [d601ed92689d2a353710668e23fa904d06c3610d]

        cid#1485150 silence Uncaught exception
        
        Change-Id: Ic7944a6b6a956a9b699e5743b78b98cbb522721f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [dc1589f0859d5219d6f3f67748f0f0ec9af48790]

        flush pending menu close on queuing close of another
        
        Change-Id: If57442e24336d855249413fc58587b776e251f66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [681e10eecf67a1a01bdec2cc9b834e0345e25206]

        tdf#146137 tdf#146132 image redrawing
        
        regression from
            commit fe6a140a537eda1b6703c44ff5ee49d2ba875b81
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Dec 7 14:55:13 2021 +0200
            used cache value in ViewObjectContact::getPrimitive2DSequence
        
        we need to blow away the cached data when the object changes
        
        Change-Id: I3be8d57b166b6f7e3a04bd8fc34c83eed5ff8857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [5b2164973dd09df775d7bd4fe1d97d521059fa2b]

        cid#1242728 Untrusted value as argument
        
        and
        
        cid#1494650 Untrusted value as argument
        
        where we have validated the cell address
        
        Change-Id: I924aac1e24c6577b8fa9f8fa53e6169e9143d104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Stephan Bergmann  <sbergman@redhat.com>  [b8b72fdbbba57c017fcc3bce09fe8da31826aa2a]

        Remove unused bCreateReference parameter
        
        Change-Id: Ib3656570fcefc2d29b5d363f93dbfef6ed491e3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126611
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [66b95d7117e034f63077e3ce948aa26c250e14f1]

        initially nothing is selected, so mnSelectedMenu should be MENU_NOT_SELECTED
        
        Change-Id: Ied8f139c34bb888ac763eeb5f2363255078e47c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126578
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [ecd615ab32fcacf8f8116672ebe631d1db72cb4e]

        VCL implement GetGlyphOutline fallback
        
        Change-Id: Ia0b32f7fb9f39d8bea18afd12df3cc95ba8077ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126463
        Tested-by: Jenkins
        Tested-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [8677e994d37329a28ca8278358a99d18b9cada69]

        Simplify FONTCONFIG and FREETYPE tests
        
        Add an additional option to libo_CHECK_SYSTEM_MODULE to select
        the default external lookup.
        
        Don't "if" the libo_CHECK_SYSTEM_MODULE, so the AC_SUBST are
        always run, but set the test_* flags instead.
        
        Change-Id: Ie0a1204b34d596fdd57a7ee770418f91bf8c5d00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126464
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [748b8ad4184130b74ae3fdd7178be2999948d64e]

        Make sure Python is in build for the cross-toolset
        
        Change-Id: I4c25f572cb942759990eaacb7ca261c78831ed40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116124
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-09  Jan-Marek Glogowski  <glogow@fbihome.de>  [7a4a13517dc464ed409be0b9c36b2a32a4027c98]

        Convert example document from cz to en-us
        
        Change-Id: Ia757491ce8802ec9deec9e75c65c6ae1c8ff2c79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126460
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a2bb61f8ef60c3b7a7449a5735f14f52790de232]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 074f4a0f8b985a01c970d3d0bd9329d4e3c2634a
          - Refactor database Help files
            
            + remove duplicate ID in a section
            
            Change-Id: Id398144f06a813d0ac90bf5d5a4e10bc8cd0f1d3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126612
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-09  Justin Luth  <justin_luth@sil.org>  [a99aea61c3199dc8188d4d873a10201082dff2e2]

        tdf#121699 sc: wrap LOKit stuff with isActive
        
        This is a partial revert of LO 6.1
        commit 009d2756b1678477ec23d5647bd5004c4bff3a62.
        
        It is one thing to change code that you don't really
        know why it is setup that way, but it is another thing
        to ignore the resulting regression reports for 3 years.
        Not impressed.
        
        It look me only 1 hour to work through this,
        and this is completely outside of my normal
        line of programming.
        
        Change-Id: I8671677f38cc1332c6c5a76847801e2680097048
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126500
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [1aa57f44c0d37ef23551943a64211dea17903873]

        change use of wrong slot id to name of correct command
        
        slot was introduced with
        
        commit 27452a082237065ac4cf475c8398241907164b2c
        Date:   Wed Oct 10 14:32:04 2007 +0000
        
            INTEGRATION: CWS pppopt02 (1.24.74); FILE MERGED
            2007/09/28 14:52:06 sj 1.24.74.1: added slot to be able to clear the undomanager
        
        as 27115, but got renumbered to 27118 with
        
        commit 35fe915b7cf508356a88897d520b89fc986407fb
        Date:   Wed Jun 10 15:47:52 2015 +0200
        
            Fix sd ID conflicts and duplicates
        
        using its name is verified to call the expected handler for it
        
        Change-Id: I656d91937612b0807353455930328aa37d5eecb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126581
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  László Németh  <nemeth@numbertext.org>  [84fbb3398f7486f00e7b7dea415e1ea2510a9535]

        tdf#146144 sw: add tooltip to table rows with change tracking
        
        Showing "Row Deleted" and "Row Inserted" with Author and
        Date (of the associated SwRangeRedline: latest tracked deletion
        in deleted rows, and first tracked insertion in inserted rows).
        
        Follow-up to commit c6af542a31e167e5a01908d049e399ce06a5e4e4
        "tdf#146120 sw: show tracked table changes with different color"
        and
        
        Change-Id: I913e234de1a60311306fbebdfb1ae16dcea7cd8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126575
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [facbf9d86aa76ac6292ff3725f2d1e9592eac385]

        ofz#42082 OOM with embedded pict in ww6 document
        
        Change-Id: I2772e55c20d4f38d26bfe36250f4fd281d4713d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126576
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [ab79c33286602b212cdb800347f58182a84954a1]

        Stream::Tell returns sal_uInt64 not sal_uLong
        
        Change-Id: I060121b0d2b2e36cd9c5e99e3047997ed7c1d517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126571
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [f57cfddb51b7d7409b7b425dc200aa73406a13bd]

        tdf#145162 PPTX export: fix extra bullet regression
        
        Placeholders have bullet by default in MSO, so
        write <a:buNone/> for paragraphs where numbering/bullet
        is disabled to avoid extra bullets in Impress.
        
        Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e
        (tdf#111903 tdf#137152 PPTX export: fix placeholders).
        
        Change-Id: Ib4c563cba475d61bc475ca05623e7c7b20fded30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126528
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-09  Tor Lillqvist  <tml@iki.fi>  [47aabde053a1472dc32770da29d68c8de5bd7919]

        Make the tdf#97983 changes to BASIC optional
        
        If you want to keep the string to floating point conversion semantics
        in BASIC as they were in LibreOffice 6, you can either set the
        LIBREOFFICE6FLOATINGPOINTMODE environment variable to some non-empty
        value, or set the org.openoffice.Office.Scripting/Basic/Compatibility/
        UseLibreOffice6FloatingPointConversion flag in the Expert
        Configuration. (Or use a registry modification file with that effect.)
        
        Adapt the relevant unit test accordingly. Thanks to Mike Kaganski for
        showing how to access the setting in the LibreOffice registry from
        Basic.
        
        Change-Id: I13d6d5d834e1bb81ef8df489db2b1da79f01dfc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125756
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [c1916d3ab8f764e465f889334050ce7c863576b3]

        meRememberedAnimationKind is dead
        
        and removing it actually makes chart loading faster, because we now
        avoid always instantiaing the ObjectItemSet
        
        Change-Id: I48420bcc38c61e4f6b211724271bc61db0e1f0d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126572
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [0cfd60b12855bc1e40640eb2e4cd4ea87d18ff7b]

        tdf#146094 Impress refuses to go in presentation mode
        
        regression from
            commit 043ba6ddf8d90b04acfae8ec836c4b772fb36754
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Mon Oct 11 16:08:12 2021 +0200
            loplugin:moveparam in slideshow
        
        Change-Id: I8d6ec81f60e9bdba5b371b8a79abf3d07c523dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-09  Miklos Vajna  <vmiklos@collabora.com>  [91f649a119d4b7ece26f9737a38663664953a57a]

        ODP import/export: refer to theme from shape text color
        
        Refer to the 12 pre-defined colors by name + don't write the attribute
        for the case when there is no theme.
        
        Change-Id: Ib6ab5b7b34d896a36e04309bf0cb410998acce01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126566
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-09  Caolán McNamara  <caolanm@redhat.com>  [27487243c3ee31927e17a0859614ffa0df7881d7]

        Related: tdf#145786 cooperate between our own grabs
        
        Change-Id: I97a1868c3f086b7f414d18d0fb4daa1c6d09846f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126558
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-09  Miklos Vajna  <vmiklos@collabora.com>  [85bc09d05f4824929d5b1381343c3ca75e7f6006]

        svx: fix crash in ViewContact::ActionChanged()
        
        Crashreport:
        
                sdr::contact::ViewContact::ActionChanged()
                        svx/source/sdr/contact/viewcontact.cxx:197 (discriminator 2)
                SdrTextObj::NbcSetOutlinerParaObjectForText(std::unique_ptr<OutlinerParaObject, std::default_delete<OutlinerParaObject> >, SdrText*)
                        svx/source/svdraw/svdotext.cxx:1379
                sdr::properties::TextProperties::ItemSetChanged(SfxItemSet const&)
                        /usr/include/c++/10/bits/unique_ptr.h:360
                sdr::properties::RectangleProperties::ItemSetChanged(SfxItemSet const&)
                        svx/source/sdr/properties/rectangleproperties.cxx:54
        
        Change-Id: I82de3e849cef33d207c8fd5e1c225de78d5f8705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126562
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-09  Miklos Vajna  <vmiklos@collabora.com>  [fa1609be20baa2ccd3293a034e004efa1ae5b90e]

        sw: fix crash in SwFEShell::SelectObj()
        
        Crashreport signature:
        
                SwContact::GetFormat()
                        sw/inc/dcontact.hxx:112
                SwFEShell::SelectObj(Point const&, unsigned char, SdrObject*)
                        sw/source/core/frmedt/feshview.cxx:292
                SwWrtShell::UnSelectFrame()
                        sw/source/uibase/wrtsh/select.cxx:326
                SwWrtShell::DelRight()
                        sw/source/uibase/wrtsh/delete.cxx:467
                SwBaseShell::ExecDelete(SfxRequest&)
                        sw/source/uibase/shells/basesh.cxx:198
        
        I.e. it seems that in case we're in the middle of a delete, then it's
        possible that the mark list contains an SdrObject that doesn't have a
        matching SwClient anymore. Ignore such SdrObjects when looking for the
        textbox of a draw shape.
        
        Change-Id: I065b2ea44d39220184a5f604c3ea13f6a106ddb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126563
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-09  Miklos Vajna  <vmiklos@collabora.com>  [c1128c74ad6a9efdb18db897271c7f3202a8a829]

        sw: remove an unused include
        
        Change-Id: Ib7be7fac788e06ee885d0eca9c082b145c889ef9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126552
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-09  Dennis Francis  <dennis.francis@collabora.com>  [ff175d858e897964d81cf3b7edaa6ccde32e098b]

        lok: don't crash accessing an invalid ObjectContact cache
        
        Fix description:
        
        Avoid storing a reference to the object-contact
        (sdr::contact::ObjectContact) of the page-window (SdrPageWindow) related
        to ScDrawView in the "proxy" object-contact. In the current setup there
        is no way to invalidate the proxy object when the original
        object-contact and its page-window are destroyed (in this case it seems
        during a sheet-switch).  Instead query the real object contact just in
        time when the grid offsets are requested from the proxy object-contact.
        
        Performance:
        
        Behaviour of offset computation is not affected. It is still cached in
        the "real" object contact and it is only computed after it gets
        invalidated (because of change in zoom)
        
        Crasher reproduction(LOK):
        
        1. Create a spreadsheet with two sheets - one with a table of texts and
           shapes and other may be empty.
        2. In first sheet select a single row(via header) and press Ctrl+X.
        3. Go to the empty sheet, and paste (Ctrl+V) and immediately save using
           Ctrl+S.
        
        ---Relevant part of backtrace-----------------
         <signal handler called>
         0x00007ff96781cc70 in main_arena () from /lib64/libc.so.6
         0x00007ff964f2f47b in sdr::contact::ViewObjectContact::getGridOffset (this=0x6f01f20) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewobjectcontact.cxx:456
         0x00007ff95cffac5a in (anonymous namespace)::ScLOKProxyObjectContact::calculateGridOffsetForViewOjectContact (this=0x6fb00a0, rTarget=..., rClient=...) at /opt/libreoffice/co-2021/sc/source/ui/view/gridwin4.cxx:1315
         0x00007ff964f2f493 in sdr::contact::ViewObjectContact::getGridOffset (this=this@entry=0x5e0c5e0) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewobjectcontact.cxx:459
         0x00007ff964f30732 in sdr::contact::ViewObjectContact::getPrimitive2DSequence (this=0x5e0c5e0, rDisplayInfo=...) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewobjectcontact.cxx:364
         0x00007ff964f30a82 in sdr::contact::ViewObjectContact::getObjectRange (this=0x5e0c5e0) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewobjectcontact.cxx:198
         0x00007ff964f30d00 in sdr::contact::ViewObjectContact::ActionChanged (this=0x5e0c5e0) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewobjectcontact.cxx:220
         0x00007ff964f20294 in sdr::contact::ViewContact::ActionChildInserted (this=0x5dd83a0, rChild=...) at /opt/libreoffice/co-2021/svx/source/sdr/contact/viewcontact.cxx:180
         0x00007ff96506628a in SdrObjList::impChildInserted (rChild=...) at /opt/libreoffice/co-2021/svx/source/svdraw/svdpage.cxx:288
         0x00007ff95c808bcd in ScDocument::CreateAllNoteCaptions (this=<optimized out>) at /opt/libreoffice/co-2021/sc/source/core/data/document.cxx:6614
         ...
         0x00007ff95cbedcc5 in ScXMLImportWrapper::Export (this=this@entry=0x7fff5432f110, bStylesOnly=bStylesOnly@entry=false) at /opt/libreoffice/co-2021/sc/source/filter/xml/xmlwrap.cxx:730
         0x00007ff95ccfd896 in ScDocShell::SaveXML (this=0x5c4c330, pSaveMedium=<optimized out>, xStor=...) at /opt/libreoffice/co-2021/sc/source/ui/docshell/docsh.cxx:556
         0x00007ff95cd009c7 in ScDocShell::SaveAs (this=0x5c4c330, rMedium=...) at /opt/libreoffice/co-2021/sc/source/ui/docshell/docsh.cxx:1801
         ...
         0x00007ff95d081af4 in ScTabViewShell::ExecuteSave (this=0x5e9b100, rReq=...) at /opt/libreoffice/co-2021/sc/source/ui/inc/viewdata.hxx:354
        -----------------------------------------
        
        Change-Id: I00eac440546624bc448dcd30499957dea7c1de87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126471
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [bf38dd800e6e4e820a0cef84e082d9bcee8e8133]

        Simplify some Optional handling
        
        Change-Id: I2ba326faa47531c1d7c71ac05a8dd211cebac199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126513
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-08  Mike Kaganski  <mike.kaganski@collabora.com>  [eee091a91cbf9e490d12c07befd16df2fdbf5f29]

        Fix wrong missing variable check
        
        ... ever since commit 0aa1eda1a2af438d7061ba2a6d53866141f5fda6
            author	Behrend Cornelius <bc@openoffice.org>	Fri May 04 14:15:30 2001 +0000
        
            ## several changes
        
        Change-Id: I97a761919b3f3faabc87b1804ef10a231ad1df96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126512
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-08  Luboš Luňák  <l.lunak@collabora.com>  [1da003fed409d0a94410bcd93fe110322a50f6f8]

        do not repeatedly create a framework::AddonsOptions temporary
        
        They are actually internally refcounted, so this doesn't make
        a difference, but it was confusing when profiling and seeing
        that it's a noticeable cost in SfxLokHelper::setView().
        
        Change-Id: I6330fbdd2bc02718e633c3f7ab5c3da12039677e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126486
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-08  Luboš Luňák  <l.lunak@collabora.com>  [34a285a05f7f4a315661c1267515effb8c0c812a]

        do not unnecessarily lock XLayoutManager for menubar changes
        
        The XLayoutManager documentation says that lock() prohibits layout
        updates until unlock() is called, so it's not any kind of mutex
        or anything, it just allows grouping updates. Which means it's
        useless to put around a single call to change menubar visibility.
        To make things worse, unlock() will always trigger a layout,
        so even if nothing changes, it still does an unnecessary layout
        update. And since this gets called from SfxLokHelper::setView(),
        it may get called often and it's rather costly.
        
        Change-Id: I3e3e37b6763b15d454e76b4bef0b22f84cf479d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126483
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-08  Justin Luth  <justin_luth@sil.org>  [ab99d16e21e56596803b7d9a28af0895b435ef3e]

        tdf#123139 sc oox: CellXf should default to applyAlignment
        
        Since the same logic applied to applyProtection
        I tested and changed that one too.
        
        No documentation was found to support the comment
        (which was probably taken from binary import)
        that applyAlignment had a context-dependent default value.
        
        Testing on the other hand suggests that applyAlignment
        is always considered true in the case of CellXf
        and only matters for CellStyleXf.
        The unit test tests for this - confirmed on Excel 2003/2016.
        
        No existing unit tests where found with an
        assert(rXf1.maModel.mbAlignUsed ||
        (rXf1.maAlignment.getApiData() == rXf2.maAlignment.getApiData()));
        
        Change-Id: I47d8dded93335092c93e75b4c18b798569da77f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126177
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-08  Jean-Pierre Ledure  <jp@ledure.be>  [408838e52900c26824a3e7ace5e4e08982686404]

        ScriptForge - (SF_Utils) language may have a length > 2 in locales
        
        The vaste majority of language codes are 2 characters long.
        However it is not the norm.
        A length of 3 is admitted for less spread languages
        
        Change-Id: Iabdf6a6cf453169419d0a4a7a3ab6ea80ae4753e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126531
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [4586a09c8b12e5a185f022b059f2b9b1ba79d5bb]

        Related: tdf#144410 excessive "resize" triggered
        
        so changing cursor pos becomes hit or miss in the dropdown arrow
        shown case
        
        Change-Id: I6e08a022041667fe8368b2cb09289a598957eb87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126551
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [f68ee0c6fca2d0d1be0c9409ae89e46736190d9c]

        only autopopup on mouse hover, not keyboard traversal
        
        Change-Id: I4ec5c5c1d5a450a0d8531907da85216000cd6c4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c92c0776829aaa04b924bf970396a312994af8d0]

        use more OUStringLiteral in various
        
        and remove some unused defines
        
        Change-Id: Ie560fccb674568ba88175d2e68ca83b92cfcf312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [56ff330b101e28fedae4dad0b08ebfca3bbd72d4]

        loplugin:stringliteraldefine in sw
        
        Change-Id: I583f2a23b7912e48889b49a0dce0f4681ef45566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [35417853a27a53070cd5de74b41a2b8ff98b5d25]

        keep as css::awt::XPopupMenu through another layer of api
        
        Change-Id: I750279bbfa67be442546b20e0e8315d595b6ea8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [b6e08b6a02a5ec7ff711fdbb2a5a43eb8b90580f]

        ScHeaderControl::GetMousePos only needs a Point, not a MouseEvent
        
        Change-Id: I458b3199e1d882c6cd20f5ef5a783afded626a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126541
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Miklos Vajna  <vmiklos@collabora.com>  [fcd05ee5e08063b7368473f590b43a3d4350d2de]

        officecfg: link the file format spec in the README
        
        It is not easy to find the original URL, and surprisingly achive.org
        doesn't seem to have it.
        
        Change-Id: I69ecbee27e24df33524e16908ca01e37175544cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126536
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-08  Tor Lillqvist  <tml@collabora.com>  [16072fc3eaf222d59e7bf156174f49d829b79e86]

        Bin pointless comments telling where some settings were in ancient times
        
        And some of the comments didn't even tell that, but were just idiotic
        copypasta, as in: <!-- OldLocation: --> .
        
        Change-Id: I71b889d1905f9291f920e8219f5648e63da3586e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126530
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-08  László Németh  <nemeth@numbertext.org>  [f348440e17debacbcba9153e238e010e8c020bdc]

        tdf#146120 sw: show tracked table changes with different color
        
        In Change Tracking, show deleted table rows in cyan and
        inserted rows in pink. In this case, don't show original
        table row or cell background.
        
        Follow-up to commit f481c2c8e74bded11fac754e493560391229dbcd
        "tdf#144057 sw track changes: hide deleted table rows".
        
        Change-Id: Ib9cc411b62b92bc8a83dda7589f3e798f7e96f41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126482
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-08  László Németh  <nemeth@numbertext.org>  [76784f2dbf6d8641cfb6bf5d24e37521d6c806df]

        tdf#107292: ODT import: fix order of deletions at same position
        
        Tracked deletions at the same position were loaded in reverse
        order, resulting broken text content.
        
        Note: FODT format is not applicable for the unit test document,
        because it's not affected by the problem.
        
        Change-Id: Id13f8d23ae5964cbf82095a3d1ce2f6c9fdd59e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126529
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-08  Eike Rathke  <erack@redhat.com>  [155024040de888270bf90bdd200799cea7d73e4e]

        Related: tdf#132466 Relative address parsing needs current position
        
        For the bug doc example the #C target lead to always column 1
        (A,0) being selected. Instead, the column of the current cell
        cursor position should be selected as C is the short notation for
        C[0] in R1C1 address syntax.
        
        This does not "fix" the alleged bug but would yield the desired
        behaviour if there was no sheet C where the intention was to jump
        to.
        
        Change-Id: Ibaed0250b9fb2cbc7f15a4b22404c48b39d41ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126496
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [829510594b394d00ca2b4acb0ed64c6bda0f311c]

        tdf#146108 Calc slow to change cell focus..
        
        in a document with a big background image
        
        Revert "tdf#136058: remove some caching"
        This reverts commit 57c40329a2b469813a1f357de355a37c8e3077ae.
        
        And add some comments for future would-be optimisers.
        
        Change-Id: Ie8686edc38dcdbe7d9e78599c1a259aab68278a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-08  Jan-Marek Glogowski  <glogow@fbihome.de>  [556062749651d332cc3c744649b158a3ccc2cc18]

        services.rdb: use i18npool/util/i18npool.en
        
        oss-fuzz failed with .../solenv/gbuild/ComponentTarget.mk:53:
        *** No LIBFILENAME set at component target:
        /work/workdir/ComponentTarget/i18npool/util/i18npool.component.
        Stop.
        
        oss-fuzz uses --with-locales=en, so actually include the
        i18npool.en.component file in the services.rdb generation.
        
        Regression from commit 1c9a40299d328c78c035ca63ccdf22c5c669a03b
        ("gbuild: create services.rdb from built components").
        
        Change-Id: Ica250403b687f636880bbc066e83b9ffe9689c5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126495
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [8d3107f16d32fd0b582a0a5557691296791327f3]

        tdf#146018 merge autofilter color dropdowns into a single dropdown
        
        Change-Id: Ie900ed2ebade82198928b3dc2e90ab7aa7f0edd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Miklos Vajna  <vmiklos@collabora.com>  [26c8e266e1ae267fd15878057a92340078136140]

        ODP import: handle theme of master pages
        
        This is just the theme itself, we don't refer to this theme from e.g.
        shape text color yet.
        
        Change-Id: I0d8f4b06217fb491e47d775628fde742d8ff104d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126502
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [a61f4cb34d3ff2b6e4fd9533f7eb2c9daac85bb5]

        remove an oss-fuzz workaround with upstream merge of better fix
        
        Change-Id: I8a89b80f804bbcf4606d55dcecf44e44095112eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126504
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Caolán McNamara  <caolanm@redhat.com>  [1361d656675c534638aa78c9decffae9e38127fa]

        gtk3: GtkTreeView::gtk_widget_get_preferred_size can return a poor height
        
        if GtkTreeView's internal do_validate_rows hasn't been run yet,
        guarantee that's called by calling gtk_widget_get_preferred_width.
        
        this is noticable in the calc autofilter color dropdown on getting
        its preferred height right after inserting rows into it
        
        Change-Id: I6dcef6ddfb462bcd9ff31ac797862804661f46fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-08  Miklos Vajna  <vmiklos@collabora.com>  [307a181254ad5e7b3ee52a4fcfae654a34281fbe]

        CppunitTest_sw_rtfexport: avoid DECLARE_RTFEXPORT_TEST() for export-only tests
        
        Convert just one test before mass-converting all such tests in this
        suite.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I9eb0a6458ae9ea31608dcb5e02f6ba59d3f2a669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126488
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [732ff8540e308aad8a6852e90712b26464c66d27]

        use the cached object range
        
        rather then recalculating it
        
        Change-Id: Ia7338799a283e65d1575fce937f0600e1bd58bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [61470af0c78a8f01377e8d5001bbf2362a87e687]

        remove some unnecessary copying
        
        the method returns a const&
        
        Change-Id: I2b031b930c6a1280d25eab2d6a659102d2e28972
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe6a140a537eda1b6703c44ff5ee49d2ba875b81]

        used cache value in ViewObjectContact::getPrimitive2DSequence
        
        I'm not sure why we don't rely on this, it seems pretty obvious, we even
        has an explicit flush method to invalidate it.
        
        This takes the load time of a spreadsheet with a large chart from 40s to
        20s.
        
        Change-Id: I731246abb5e0c118116b70a0386b652798555503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-07  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [7e5af164b7d293dd410710bed411e1ca64bbecf7]

        Re-Enable DrawTransformBitmapExDirect for render backends
        
        Unfortunately the add/usage of HasFastDrawTransformedBitmap did disable the
        system-dependent implementations/fast-path for DrawTransformBitmapExDirect
        and it's implemenations, except for Skia.
        
        This means that the current backends for Windows/Mac/Cairo/headless/Qt5
        have to do expensive pixel operations when a Bitmap is 'really' transformed
        (rotate/shear) since some time.
        
        The nine implementations using ::hasFastDrawTransformedBitmap (grep for it)
        all return false, except the Skia one.
        
        Since HasFastDrawTransformedBitmap() uses that and itself is used in the very
        central mehod OutputDevice::DrawTransformedBitmapEx(...) to decide if that
        fast-path shall/can be used at all, it was *no longer used* - except for
        Skia - what makes Skia definitely performing better with transformed Bitmaps,
        or the other way around - the others worse.
        
        HasFastDrawTransformedBitmap() is used in only two places, the second is in the
        canvas helper to decide if to try to use that fast-path for presentation
        rendering.
        
        A method at OutputDevice to see if that fast-path is implemented is therefore
        currently needed, but for the canvas helper only. Since this will/should be
        converted to primitive usage (hopefully) anyways, nine impementations calling
        these virtual functions often and the danger to produce a mismatch/
        error beween implementations of hasFastDrawTransformedBitmap and
        drawTransformedBitmap (as happened here, but can also happen when someone
        adds or removes an implementation) I looked for a way to solve that differenly
        and more safe.
        
        Since SalGraphics::DrawTransformedBitmap anyways returns a bool to signal it's
        success I take this as base to implement a buffered test directly at
        SalGraphics, also directly set a local flag to detect that functionality if
        DrawTransformedBitmap is used anyways before the test is/would be needed.
        Combined wih that small test to check only if this was not yet used and thus
        tested by DrawTransformedBitmap anyways I can offer a reliable non-virtual
        method at OutputDevice called ImplementsFastDrawTransformedBitmap() that will
        be used at the single necessary location - in the canvas helper.
        Since that small test direcly uses one of the nine implementations of
        hasFastDrawTransformedBitmap it is fundamenally more reliable and probably
        the copy bitmap/writeBack never really used (I tested that it works) due
        to an earlier use of DrawTransformedBitmap did the check potentially already.
        
        I also took a look at the cairo version (since I had this one running here)
        and ensured that the buffering of the system-dependent form of the Bitmap
        as cairo surface still works. Regarding the newly introduced fAlpha
        parameter I want to add some remarks:
        - It should be called fOpacity to make clear that it describes opacity,
          defining that if 1.0 == fAlpha means *no* transparency. That word is
          used in other graphic systems and makes more clear what function it has.
          It is the opposite of transparency, but works the same.
        - Currently all implementations of ::drawTransformedBitmap - except Skia
          where it was implemented - do not use it, but return false. It will in most
          cases not be too complicated to add/implement it, e.g. for cairo anyways a
          transparency surface will/is created, fAlpha can just be merged in, and the
          criteria for buffering that may be extended to remember for which value
          (if at all) of fAlpha that was prepared. I strongly recommend implementing
          these for our main graphic backends.
        - The primitive renderer uses another more general way to add an extra alpha
          channel to paint when needed - it draws the content (any content) that needs
          to be transparent to a buffer and then that buffer using the intended
          transparency. This is discussable since may be more expensive, but more
          general and keeps the interface less complex. We can see here that adding
          that complexity to the existing interface at OutputDevice makes the
          implementations more complex what might be the reason his was only
          implemented for one of nine backends. When adding something like this and
          extending the complexity I would prefer that at the same time it gets
          also *implemented* in all or most or at least most used cases. I want to
          make clear that from my POV in those cases choosing possible runtime speed
          over complexity is not always preferable.
        
        Change-Id: I5bab59f59fca878a7b11a20094e49e8b50196063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126480
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-07  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [8995bc21ee570c9a914df71817a132c3b3637059]

        tdf#48622, tdf#145828 use correct default for border line width
        
        Use correct default to create the intended 0.75pt cell border
        using the border formatting tool in the standard toolbar
        
        Change-Id: I8e95a7ab888cdc1b04929fd41753e550b96f3de4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126484
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-12-07  Julien Nabet  <serval2412@yahoo.fr>  [dd4120ce811b8530505650d481514009a441234f]

        Related tdf#145910: relax a bit more denylist about OpenGL
        
        tdf#99919, tdf#100243, tdf#117477 and tdf#115092 are not related to slide transition
        
        Change-Id: I41e80a6b1d025adbde7bccbedb7235d4c3c8b281
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126462
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [5de20e45e48f7654d288f26f768fabddad133bfd]

        improve loplugin:cow_wrapper
        
        to find my previous attempt at this, which only obscured the problem
        
        <noelgrandin> I'm such an idiot
        <noelgrandin> I changed a whole bunch of code to avoid calling const
        methods on a non-const object
        <noelgrandin> from p->foo() to std::as_const(*p).foo()
        <noelgrandin> can you spot the mistake?
        <bubli> Is this a job interview question? :D
        <vmiklos> noelgrandin: you did the opposite, now you always call const
        member functions, while you wanted to always call non-const member
        functions?
        <noelgrandin> more like a "why didn't the smart people on this channel
        tell me I was an idiot" :-)
        <noelgrandin> in this case, we have o3tl::cow_wrapper, which overrides
        operator* and operator->
        <vmiklos> ah, and by the time you would add/remove the const,
        cow_wrapper already did the expensive task of copying based on
        const/non-const
        <noelgrandin> exactly
        <thorsten> heh
        
        Change-Id: I5366e6a87c414b862668b61e6adfbccfdd9d3b04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-07  Stephan Bergmann  <sbergman@redhat.com>  [7e8e57a456f2b946631eecefd163cb4ff3a3d603]

        CppunitTest_xmloff_draw needs the ASan LD_LIBRARY_PATH hack now too
        
        ...for CPPUNIT_TEST_NAME=testThemeExport::TestBody introduced in
        c95288aec4eb4d92a5ccfb9d8fc02a0185d8e8d0 "ODP export: write the theme of a
        master page",
        
        > warn:test:3875202:3875202:test/source/bootstrapfixture.cxx:240: /home/sbergman/lo/core/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng[-1,-1]:  Error: Can't find bundle for base name com.sun.msv.reader.Messages, locale en_US
        > /home/sbergman/lo/core/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng[-1,-1]:  Fatal: Can't find bundle for base name com.sun.msv.reader.Messages, locale en_US
        > /home/sbergman/lo/core/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng:Schema has validation errors.
        > Validation aborted.
        >
        > /home/sbergman/lo/core/test/source/bootstrapfixture.cxx:241:testThemeExport::TestBody
        > forced failure
        
        Change-Id: Ib028d1449a9b878aea3b073de6388fb3bb6d590c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126485
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-07  Pesi Taototo  <pipapipapibo@gmail.com>  [47503fce3ebc0874534175c0d9ea40d3a5bbffde]

        tdf#145614 Convert #define to 'enum class'
        
        Change-Id: I991cd44b13465e63c5adc1aed3cfbc038847c0f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126396
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-07  Caolán McNamara  <caolanm@redhat.com>  [5120fe8f2929d9f4464aff26f266198bff038606]

        cid#1202917 Uninitialized scalar field
        
        since...
        
        commit 4c00e8fb10437fcaefe8635ef390b78376938d15
        Date:   Fri Dec 3 20:52:12 2021 +0100
        
            Add image preffered DPI document setting, use it in Writer, Impress
        
        Change-Id: Ie8c8bc568c483b790b2360162aedcf8ab6e48cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [9cd2b1015ce94c7ca649c98f0bb970aa6396ec5a]

        lock model while building chart
        
        reduces the amount of broadcasting we do
        
        Change-Id: I29ebabfcd255a96381d75b2b013f4a1abfb8ee08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-07  Luboš Luňák  <l.lunak@collabora.com>  [12ad13f35bffc2f22f6f7385b2e426c20ea91bd8]

        make sure vector elements are initialized properly
        
        Change-Id: If18268a26118ea587f474c21b7ca0f1fa4622744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126469
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-07  Mark Hung  <marklh9@gmail.com>  [6720e9569d7ab6c20616ec6b97e5d4a56948908b]

        tdf#145322, tdf#144378 fix printing for vertical writing
        
        Printing still uses ExTextOutRenderer to render text because
        Skia haven't yet support printing and DWriteTextRenderer can't
        bind the printer DC.
        
        ExTextOutRenderer uses win32 API ExtTextOutW. In order to
        renderer upright CJK text in vertical writing with that API,
        the HFONT created with CreateFontIndirectW needs a font name
        prefixed with '@'. OTOH, use '@' prefixed font with Skia break
        the vertical writing unit test.
        
        - WinSalGraphics::ImplDoSetFont: use '@' prefixed font name
        if the requested font is vertical and is for printing.
        
        - ExTextOutRenderer: use SetTextAlign and text metric tmDescent
        to adjust vertical glyphs. It's not consistent with Skia or
        DWriteTextRenderer, and is still incorrect in many cases.
        
        The patch is adapted from reverting
        
        commit 5686c1aca40beb9514d40c86b4a3780a8a1334ba
        Author: Mark Hung <marklh9@gmail.com>
        Date:   Sun May 2 14:45:45 2021 +0800
        
            vcl: use DWriteTextRenderer for vertical writing.
        
        Change-Id: Ib2d3df8b68cad4bebe0672c9da0a16b62aed99e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125978
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-12-07  Miklos Vajna  <vmiklos@collabora.com>  [c95288aec4eb4d92a5ccfb9d8fc02a0185d8e8d0]

        ODP export: write the theme of a master page
        
        Which requires describing the schema, which is really just a new
        <loext:theme> element, the rest reuses the color-table markup, which
        wasn't used in ODF so far (but was used in our .soc files).
        
        Also make sure that we only do this in ODF extended mode (which is the
        default).
        
        Change-Id: I90eaad30f63946c441fe0c53caf6a47caf1714d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126466
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-07  Miklos Vajna  <vmiklos@collabora.com>  [68c15984ea17354c03e5ddf03e0c0b4214999659]

        sw layout xml dump: handle SwFieldPortions
        
        This is the case where the field has a single placeholder character, but
        it typically expands to more characters at a view level.
        
        Change-Id: I5f11b29772697dbca3475aa53cf9301b67e64452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126459
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cad267240a11daa0be76077f858f37679f330d7]

        loplugin:unusedmethods
        
        Change-Id: Ic1ba90447575278d854af85312271c41766b776b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126422
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [3efde47ec9ee091479c04129696f99dc934c3f64]

        loplugin:unusedfields
        
        Change-Id: Id39c3f484a364fb5163444febe99aee79daf1a76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbc5519e9d4b36a6c48b14d83c8d813d5156433f]

        loplugin:unnecessaryvirtual
        
        Change-Id: I231195c36d620254cbcd2f4d7bbb9044f7887fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126413
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Julien Nabet  <serval2412@yahoo.fr>  [3a61cce54277fd12570103a191c50d9b37ef3dd3]

        tdf#145910: relax a bit denylist about OpenGL
        
        since we don't use OpenGL anymore for rendering,
        only for slide transition (and some canvas part but it doesn't work)
        
        Change-Id: Ia891915fcc10c0817a79e30fa59605a9681b6536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126461
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [f8ffc971545bb54aaebd227fa841f83660dba99c]

        fix overflow in cairo downscaled bitmap cache (tdf#137719)
        
        In my system, sizeof(long long) == sizeof(long) == 8, so multiplying
        by LONG_MAX overflows long long.
        
        Change-Id: Ieb9613ef05916ef24a64db69f698036ecaf194e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126456
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [70fc728ceef4dcf45dd97dc9051ddb73ff734169]

        signed-integer-overflow
        
        ...after 8406139062d9ffe1daed32aefe4e261c6c55d63e "process broadcasts for
        adjacent cells together (tdf#119083)" during CppunitTest_sc_bugfix_test,
        
        > sc/source/core/tool/grouparealistener.cxx:340:72: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
        
        Change-Id: Ica29fc4c204cd6fd5c52c61271ebfcc9691f7f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126458
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [8bc85cd8a6a9a879c143d8defacc45967a0ac99e]

        signed-integer-overflow
        
        ...after 8406139062d9ffe1daed32aefe4e261c6c55d63e "process broadcasts for
        adjacent cells together (tdf#119083)" during e.g.
        CppunitTest_sc_ucalc_copypaste,
        
        > sc/source/core/data/documen7.cxx:143:59: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
        
        Change-Id: If848747f6b004219475b39b48c6a3de086bd1ae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126457
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [243c05ac27e3ffd94343630e668a53cf3ad18744]

        Retire build-nocheck
        
        Build target was kept for backward compat in 'rework the default make
        target', so lets retire it after 1.5 years.
        
        Use 'make build' instead (which is since the default target anyway).
        
        Change-Id: I93d5237dce2abf2536a4d847d79d33d5b6d6cec9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126362
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-06  Caolán McNamara  <caolanm@redhat.com>  [d47628f287f4377394c4ff488c433bfe254b6abe]

        don't want to link to system static libs for DISABLE_DYNLOADING
        
        since...
        
        commit 4250958a492b300a52a83e68dd599f9c36c5086e
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Fri Aug 20 14:31:36 2021 +0100
        
            ofz: prep for allowing oss-fuzz msan
        
            dependencies need to be built with the msan flags so undo the
            --with-system .a usage now that trying to squeeze into the 12 hour build
            window isn't critical because the afl 6-8 hour build+check is disabled
        
        dropped the use case for that
        
        Change-Id: Ic525c9e0a948195cc823d904ba5a0d80b3aff668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126455
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-06  Caolán McNamara  <caolanm@redhat.com>  [0559e7e183dcdcdb3e39870eb3354e51c876f2b7]

        ofz: Use-of-uninitialized-value
        
        since...
        
        Date:   Wed Jun 2 17:01:55 2021 +0200
        
            WMF: add more SAL warnings in case record was not implemented
        
            Change-Id: I1d58c4093817403caa5f1112b5d4d5a4e638b799
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116618
        
        Change-Id: Ib82efbc93405b7fafb661f698a772593d2495bd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126454
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c067552caa38882b250279c1f9475a5537c4333f]

        Fix typos
        
        Change-Id: I16d59aa3a3f17764a848428a2e6b206dc57a480a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126325
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-12-06  Noel Grandin  <noel@peralex.com>  [d2b03c4bfa284efbb45cb4904122e97439d3ee06]

        Revert "lose the caching in ViewObjectContact" because it breaks...
        
        bitmap caching. Added some notes for future would-be optimizers.
        
        This reverts commit 7f02cb80ac2075b65ee1adee4e29d1d5c4819424.
        
        Change-Id: I39c41ea95d23d4a65edd3cef46a5d86fab48a044
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126425
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [1c9a40299d328c78c035ca63ccdf22c5c669a03b]

        gbuild: create services.rdb from built components
        
        ... and introduce the --enable-services-rdb-from-build option.
        
        Currently the build handles global build options redundant
        in a few places:
        
        * in Repository*mk + modules - the "real" build dependencies
        * the full services.rdb generation
        * the static UNO constructor map generation
        
        Also the component files don't reflect the really built components
        and so the RDB services generation must handle the whole options
        to select the correct components.
        
        So this optionally replaces the latter two by generating the list
        of components and it's constructors from the build itself. As a
        consequence, component files must now be split, so they reflect
        the real components in the libraries, otherwise the static
        constructor list will have missing symbols. IMHO this is more
        natural, as it happens in the same place already handling these
        build options for the sourcecode.
        
        This also adds a convenience helper to add multiple component
        files: gb_Library_set_componentfiles
        
        This is WIP and currently just works for the stripped WASM build,
        which introduces many more split component files in later patches.
        
        It also explicitly filters the gb_Rdb__URECOMPONENTS and the
        CppunitTest related components from the services.rdb. Maybe there
        is a good way to do this properly.
        
        Change-Id: I1b38a6f2c1e5221f18d7e5e756c30263b555d962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126185
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [ba8b3751fa184c04b9dde4c371b7902e0a9271ff]

        Better workaround for ASan use-after-poison
        
        ...than ae36ee4f3aa544e53e2edad93d6d79160b27bc9d "Work around use-after-poison"
        for
        
        > ==1922539==ERROR: AddressSanitizer: use-after-poison on address
        > 0x61d00190fab0 at pc 0x00000026aaa9 bp 0x7f422ee84b80 sp
        > 0x7f422ee84348 WRITE of size 192 at 0x61d00190fab0 thread T44 #0 in
        > memset at
        > ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:800:3
        > (instdir/program/soffice.bin +0x26aaa8) #1 at <null>
        > (/lib64/libnsspem.so +0x15f3d) #2 at <null> (/lib64/libnsspem.so
        > +0x16185) #3 at <null> (/lib64/libnsspem.so +0x8a9b) #4 at <null>
        > (/lib64/libnsspem.so +0xe13b) #5 in secmod_ModuleInit at
        > workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
        > (instdir/program/libnss3.so +0x4ad372) #6 in secmod_LoadPKCS11Module
        > at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10
        > (instdir/program/libnss3.so +0x4b1fca) #7 in SECMOD_LoadModule at
        > workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10
        > (instdir/program/libnss3.so +0x50de92) #8 in SECMOD_LoadUserModule
        > at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28
        > (instdir/program/libnss3.so +0x50e9a9) #9 in nss_load_module at
        > workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12
        > (instdir/program/libcurl.so.4 +0x4fdd25) #10 in nss_setup_connect at
        > workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12
        > (instdir/program/libcurl.so.4 +0x4eeffb) #11 in nss_connect_common
        > at workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14
        > (instdir/program/libcurl.so.4 +0x4ee237) #12 in
        > nss_connect_nonblocking at
        > workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10
        > (instdir/program/libcurl.so.4 +0x4ebe4a) #13 in
        > Curl_ssl_connect_nonblocking at
        > workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12
        > (instdir/program/libcurl.so.4 +0x514039) #14 in https_connecting at
        > workdir/UnpackedTarball/curl/lib/http.c:1591:12
        > (instdir/program/libcurl.so.4 +0x2f29ce) #15 in Curl_http_connect at
        > workdir/UnpackedTarball/curl/lib/http.c:1517:14
        > (instdir/program/libcurl.so.4 +0x2f23d5) #16 in protocol_connect at
        > workdir/UnpackedTarball/curl/lib/multi.c:1696:16
        > (instdir/program/libcurl.so.4 +0x3b8620) #17 in multi_runsingle at
        > workdir/UnpackedTarball/curl/lib/multi.c:1997:16
        > (instdir/program/libcurl.so.4 +0x3a2232) #18 in curl_multi_perform
        > at workdir/UnpackedTarball/curl/lib/multi.c:2568:14
        > (instdir/program/libcurl.so.4 +0x39dc5c) #19 in
        > http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&,
        > http_dav_ucp::CurlUri const&, curl_slist*,
        > com::sun::star::uno::Reference<com::sun::star::io::XOutputStream>
        > const*, com::sun::star::uno::Sequence<signed char> const*,
        > std::pair<std::__debug::vector<rtl::OUString,
        > std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&>
        > const*, (anonymous namespace)::ResponseHeaders&) at
        > ucb/source/ucp/webdav-curl/CurlSession.cxx:880:14
        > (instdir/program/../program/libucpdav1.so +0x5aad30) 0x61d00190fab0
        > is located 48 bytes inside of 2048-byte region
        > [0x61d00190fa80,0x61d001910280) allocated by thread T44 here: #0 in
        > malloc at
        > ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3
        > (instdir/program/soffice.bin +0x2d3c7e) #1 in PR_Malloc at
        > workdir/UnpackedTarball/nss/nspr/out/pr/src/malloc/../../../../pr/src/malloc/prmem.c:448:55
        > (instdir/program/libnspr4.so +0x123629) #2 in PL_ArenaAllocate at
        > workdir/UnpackedTarball/nss/nspr/out/lib/ds/../../../lib/ds/plarena.c:134:27
        > (instdir/program/libplds4.so +0x9a32) #3 at <null>
        > (/lib64/libnsspem.so +0x15f77)
        
        during UITest_sw_options:
        
        That --with-system-nss workaround for <https://ci.libreoffice.org/job/lo_ubsan/>
        had caused CppunitTest_desktop_lib to start to fail there, presumably "caused by
        --with-system-nss on the CentOS7 baseline", see the mail thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2021-December/088136.html>
        "Re: [global-libreoffice-ci] UBSAN Linux Build - Build # 2217 - Still Failing!"
        
        And while I had initially not been able to reproduce the use-after-poison during
        UITest_sw_options with my local ASan+UBSan build (on Fedora 35), I now found out
        that that was just because my machine happened to not have an nsspem library
        installed in the system (the nss-pem RPM on Fedora).  With that system library
        installed, my local build failed UITest_sw_options in the same way as the
        Jenkins tinderbox.
        
        Which lead me to the idea of avoiding the whole mess by avoiding that CUrl loads
        the (apparently optional) nsspem library in ASan builds altogether.  (Another
        approach might have been to disable the __asan_poison_memory_region
        functionality in workdir/UnpackedTarball/nss/nspr/lib/ds/plarena.h, but the
        chosen approach nicely makes us less dependent on accidental differences in
        build-time execution environments, at least for ASan builds.)
        
        Change-Id: I8fd2ff255771622f26ad666ca78a6d9ded0af2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126451
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [ea0d55fa45173a5fa5f53f421615298f80b42a78]

        Work around two -Werror=implicit-fallthrough=
        
        ...that started to crop up with recent GCC 12 trunk (where it expanded
        the ENSURE_OR_THROW macro, but apparently didn't take into account that its
        
        >    97 |     if( !(c) ){ \
        >       |     ^~
        
        will always be taken in these cases where the c argument is false), and
        can easily be avoided by getting rid of those uses of
        ENSURE_OR_THROW(false, "...")
        
        (And while at it, move the default case to a more reasonable position in
        mtftools.cxx, obsoleting the FALLTHROUGH comment in any case.)
        
        Change-Id: I8189d98b361e6725096d0968f3e0e604fb84e591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126452
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [478dfbd29748855512dd6ab81fd61b0cb573a27f]

        Revert "cid1494597 silence Uncaught exception"
        
        This reverts commit 96e9eb56f0f76590ccc46a6948ae00803a92f113, as it should no
        longer be necessary with the more general
        0a710c5c4475b593428c6d90e791ef2ccc880062 "cid#1494595,1494597: Silence
        UNCAUGHT_EXCEPT" (which I had created without being aware that this commit
        already existed).
        
        Change-Id: Iabf20626577af251e2e5bb146ad37c2a6ed7e3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126428
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-06  Caolán McNamara  <caolanm@redhat.com>  [4f41fb1cba455db617d7fb68450ea1e38ac9cb0d]

        tdf#138999 only grab keyboard and not pointing devices
        
        this way scrolling in a combobox dropdown and moving the mouse outside
        the widget doesn't cause the scrollbar to jump to the top. No ill
        effect seen in
        
        a) autofilter dropdowns in calc
        b) color dropdown in writer main window or sidebar and clicking on
           combobox subwidget to launch its popup and select an entry to
           return to color dropdown
        c) submenu popups from style combobox dropdown
        
        Change-Id: I6ad445a6fab899d52907237e1f5506cce31b1f48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126408
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-06  Caolán McNamara  <caolanm@redhat.com>  [8d69c36ff9297fd5477bfb13faf787538772183d]

        an empty $LOCKFILE means build our own
        
        Change-Id: I93fd08b3b106e461f402446bd4dbbe78b8f06849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126450
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2021-12-06  Jun Nogata  <nogajun@gmail.com>  [53d5555f13371252874ec962dee4643168d26780]

        tdf#143422 Hide "Hyphenation data not found" in Japanese
        
        When I open a document with mixed English and Japanese, I get a warning
        "Missing hyphenation data Please install the hyphenation package for locale "ja"".
        English needs hyphenation, but Japanese does not need hyphenation. However,
        the hyphenation check only checks for unknown language or no language.
        
        Change-Id: I559e1b1eec8089f50aadad2710a33d0268ab13f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120497
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [c5785d3ccccbd0ff575df08a1192f4e7f736750e]

        a large but clipped image may still be cached from a previous call
        
        Canvas apparently likes to redraw only small parts of the background,
        which means that there may be repeated scaling of clipped parts
        of a large background image that are considered too clipped to be
        cached, but even the drawing of the clipped part may add up to be
        costly in the end if done often. Refusing the caching only after
        checking whether the image is possibly cached may avoid some
        of the drawing in case there was an initial drawing that wasn't
        clipped and thus generated the cached image. Helps a bit with
        e.g. tdf#136223.
        
        Change-Id: I4de6164940ec7a06fb6ae2f504907b4fa076f1d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126412
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [d519d0a434310c0ee7cc4a1c04a6ff7c59f87f53]

        Adapt CppunitTest_cppcanvas_emfplus CPPUNIT_TEST_NAME=testFdo77229::TestBody
        
        ...to 374e261ad1ea8b41f5ecdd850c27fdc961c4868b "increase maximum document
        thumbnail size from 256 to 512" (which wasn't caught by Jenkins due to
        bcd243793ee4174d71b5e61c88d2bc79fd0d7f1d "CppunitTest_cppcanvas_emfplus: disable
        this in case there is no display to use")
        
        Change-Id: Ibe3dc93401e237c37b4823f0393746b1e8b569bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126424
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [8406139062d9ffe1daed32aefe4e261c6c55d63e]

        process broadcasts for adjacent cells together (tdf#119083)
        
        The problem in tdf#119083 is that it sets up listening for the range
        of cells used by VLOOKUP, and when adding a new column changes all
        those cells, it results in repeated SfxHintId::ScDataChanged
        broadcasts to the cells with the VLOOKUP formula. This commit
        makes ScHint include a row count, making it possible to group
        adjacent rows for SfxHintId::ScDataChanged together and send
        notifications just once for the range.
        
        Change-Id: Ib3439de58a2b1e5e8f01b037a62608e38b8e9125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126395
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [e55723c0ba4172bf6ee80fda49b069fd441a0c90]

        try to broadcast in bulk (tdf#119083)
        
        This somewhat improves the situation, but still a lot of time is spent
        repeatedly making the same cells dirty.
        
        Change-Id: I3444ca6dac4b3a40c6ac40a0b70cf5baeefa2f09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126391
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [1390bc84e259b1ebc19020db9dd913566ebffc39]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 73228ff72af0e4f8ca7e29b4dca388741804cb06
          - Document new TableControl methods and properties
            
            Change-Id: I8623a11f5fb710332765b8db3914a36b51285b7a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126294
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-12-06  Noel Grandin  <noel@peralex.com>  [04e3424f49b85b98d244cf7953a1736614b75f46]

        map->unordered_map in PropertyMapper
        
        a little bit faster
        
        Change-Id: I11e756e65a76fedeca2525edf37a04b34ac6aeda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126407
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [fb14f0af6a0bb13aadb7ecfbd13a9479355eaa3d]

        Drop ENABLE_FUZZERS from config_host.mk.in
        
        ... and just convert the last user to $(BUILD_TYPE).
        
        Change-Id: Iaf6361b0be47594e5c1ac08a8183460b7ada92f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126410
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Caolán McNamara  <caolanm@redhat.com>  [d4b6c35eeba661f721d0204d4a2c581913fc38b7]

        tdf#145892 disable failing assert in additional icu khmer patch
        
        Change-Id: I8507c101544fcdcdc6e75c853c44e04e97a96d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126411
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-06  Stephan Bergmann  <sbergman@redhat.com>  [0a710c5c4475b593428c6d90e791ef2ccc880062]

        cid#1494595,1494597: Silence UNCAUGHT_EXCEPT
        
        ...after aa5ee0085c7d8b8713f4dbed0009b38b9fabb281 "Stop swallowing exceptions in
        ~ScopeGuard" had dropped the catch blocks from ~ScopeGuard to make it usable in
        Library_salhelper in 0c1c300ed7ce168755ae945822eb7a1c610cfa25 "Rather use
        ScopeGuard to prevent catch and rethrow".  But using the original
        suppress_fun_call_w_exception, which used css::uno::Exception, would have caused
        the same circular-dependency issue again that
        aa5ee0085c7d8b8713f4dbed0009b38b9fabb281 had solved, so drop the use of
        css::uno::Exception (and SAL_WARN, which triggered a number of missing #include
        <sal/log.hxx>) also from suppress_fun_call_w_exception.  After all, that was
        __COVERITY__-only code that wasn't meant to be actually run, so it shouldn't
        matter if we just catch everything and silently terminate.
        
        Change-Id: If28a214709e4636e1c23a49f2d95d87c91492f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126404
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4519a0e204928e0951bea047fd4a2644af2c615]

        loplugin:stringliteraldefine in sd
        
        Change-Id: Ie03e3d06a608ee89484a07439bd6deeb1679aade
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [507cfec89e0addfe4a9bf410c0abe08820e31734]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b7bdb8a47c81ed94509777b12d2706a36ad18add
          - Fix a "D'oh you found a bug"...
            
            Change-Id: I7261546457c0d128bef55cb8be7737cb6b70d22a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126417
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b9362e87a3646a6693b81fb0d40e28ce7813a251]

        tdf#145671 Don't open URL twice in cell edit mode
        
        Change-Id: I8a324d6a037c8a5c0efc0b2825657513c2f9841c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126159
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [8368f48df8d67f6c712534647f4d375bf219ae99]

        Limit static system library linking to fuzzers
        
        When building a static LO on Linux, I get a lost of missing
        symbols for binaries, like oosplash. In that case we just link to
        Xinerama, but this has obviously other X11-based dependencies,
        and there is no real way to fix this.
        
        According to caolan, this was just added in commit
        7a3eaef6dd707781c2f4e341aebb9d4c42df780f ("for DISABLE_DYNLOADING
        support linking to static .a system libs") to support instrumented
        static libraries used for the oss-fuzz runs (see
        https://github.com/google/oss-fuzz/issues/608).
        
        So actually limit these flags for FUZZERS only.
        
        Change-Id: I7eaa81c46fab040848fdf4dbe100a6e634f54446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126409
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fe1a3c479d4aeaeb3a378aaceb77f72edcfb7c8]

        skip some intermediate results in tryToGetChartContentAsPrimitive2DSequence
        
        Change-Id: Idf3179c97fe40da1ff41100fc7e7a0b80ee1ca73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [19eaf859670b6f22cb89f854316ed0673dacbaa9]

        only collect hitstack if we actually need it
        
        Change-Id: I95f04b05c431f0009c5a843626c397e1dbc3f39e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Tor Lillqvist  <tml@collabora.com>  [d2ca15952de167b6236139d53f6757a7c0d22d0a]

        Revert "tdf#145354: Ensure displayed paper name matches displayed paper ..."
        
        It causes tdf#146045.
        
        This reverts commit 65081542d2dabdf17820d62abdc5a22d3734e52d
        
        Change-Id: Id980701b1a823c8bf7cfb57e0b32cf5d672c3bfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126373
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-12-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4c00e8fb10437fcaefe8635ef390b78376938d15]

        Add image preffered DPI document setting, use it in Writer, Impress
        
        This adds a "image preferred DPI" document setting, which is used
        as a suggestion of the DPI that an image should have in the
        document. This is currently used when the image is inserted into
        the document (Writer, Impress/Draw) to resize it to the preferred
        DPI value.
        
        Change-Id: I3ee9d409257e3c6aa2ead05144ecbba7b3b916f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126334
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [30d6787b98131fce5a280f005b75e9d496f21573]

        configure.ac: tabs to spaces
        
        Regression from commit 214fa233338c09156c67f85818b6a2ea6b3235bd
        ("add with-system-abseil/with-system-openjpeg for pdfium").
        
        Change-Id: I218cd4762f295c8d253afb670d3f3ebd5e104c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126398
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [63cc9fc463fbf182bcf93651420e0adc6180f2aa]

        loplugin:stringliteraldefine in starmath
        
        Change-Id: I539dbb8eaa21604401709d3b6e19433474056902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126406
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [a4c9664532329d7143aabdacf22b1cab662f77c4]

        make it clearer that ScHint is modified
        
        It's somewhat confusing that an accessor is provided to give
        a reference to internal data and then the object is modified
        indirectly using the reference. It appears to be only for
        performance reasons, so I thought that inlining the ctor and
        ctor could help the compiler to optimize this, but apparently
        it can't move this outside of the loop, so at least make it
        clearer.
        
        Change-Id: I72cf15d1446daa559ac4079b9478e53694d7d198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126394
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [0ca559cb8cc3b1af6c59066713bbed8e3ee76514]

        use sc::AutoCalcSwitch
        
        Change-Id: Idea2206ace5c40b2b7c38b949f9d20feb4513974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126390
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [8b0287ae7275681c28cc278ecdb448d80c223d89]

        slightly simpler Intersects() check
        
        For two ranges to intersect, both start points must not be larger
        than the end points.
        
        Change-Id: I69d1c548ff1bac90baea0767e92ca86458808c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126393
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Luboš Luňák  <l.lunak@collabora.com>  [9809441f05e4dbac8e12b042fd4391f1a7580643]

        rename In() to Contains()
        
        Similarly to b22d4785310eac35696d, 'A.In(B)' makes it unclear
        whether the check is for A in B or B in A, as it's actually
        the latter.
        
        Change-Id: Iaccc41d40f4bb105a44c1bb8d9211c06d1a3c127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126392
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-06  Pesi Taototo  <pipapipapibo@gmail.com>  [5bd9ded5f01c39f201d21a90541aecb6dba80fad]

        tdf#143148 Use pragma once instead of include guards
        
        Change-Id: Ia1c309425e64449679d6948b5e9e595fe421cfa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126378
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-12-06  Urja Rannikko  <urjaman@gmail.com>  [7fa9b09bc271d91792fe78c5cb03430bf38155a8]

        tdf#128715 fix tools::Time::GetMonotonicTicks() on 32-bit linux
        
        Since time_t and thus tv_sec is (still, for now) 32-bit on these
        architechtures, the multiplication of seconds to microseconds
        happened in 32-bit thus causing a rollover roughly every 4295 seconds.
        Fix by casting tv_sec to sal_uInt64 before the multiplication.
        
        Also fixes tdf#144975.
        
        Change-Id: I829d3406208545a816979cb58daaeb99ec2d5294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126379
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Mike Kaganski  <mike.kaganski@collabora.com>  [5e5138db9fa4f8fb995808a4895e6ce6f7629783]

        Add a bit to the WEEKS comment
        
        Change-Id: I8d409149710d25aa93e33f3c46723239156f4d1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126304
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [cef1740a0369e7c7873b6c4772e2bc371c6e2093]

        VCL always use nullptr terminated plugin lists
        
        ... and respect more defines. Almost just a refactoring.
        
        Change-Id: I5d9dce742b2ef69f7f27af1970af1f8c019abfc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126401
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [4415d2410cae282da8f8970c393561ec67fc5171]

        concat-deps: ignore /./ segments in input paths
        
        concat-deps detects relative path segments (AKA /../) and
        removes these in cancel_relative(...) to save space (by removing
        the preceding path segment from the output path). But that logic
        doesn't account for preceding /./ segments, resulting in paths
        to non-existing files. This then resulted in mysterious, unneeded
        compiling of seemingly unchanged files for my incremental
        cross-toolset builds.
        
        I actually assumed some error in my complex gbuild static changes,
        which are already driving me crazy...
        
        "make -d" showed these wrong paths, but inspecting the ".d" for
        the actual files (from gcc output), they were ok; took me a while
        to realize the problem were LO's concat-dep files for libraries.
        
        But instead of complicating cancel_relative(), this just jumps
        over /./ segments in the input path. cancel_relative() works on
        the &cursor_out copy anyway.
        
        Change-Id: I2a8ecd04fdfa790859668d690a102cfb156aa649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126345
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-06  Miklos Vajna  <vmiklos@collabora.com>  [51c3d8d7f6a2a3b95e97b9a151df0e63ff09cb74]

        PPTX export: handle theme color of shape text with effects
        
        Handle luminance modulation and offset (lighter and darker colors in
        PowerPoint); not handling tinting/shading for now, as that seems to be
        not used in DrawingML (only in WordprocessingML), and this code is for
        shape text only at the moment.
        
        Change-Id: I5e97f890d3072c7ef282ed4fb971362b3ddaaa4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126400
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-06  Miklos Vajna  <vmiklos@collabora.com>  [f72bb33e78ac9eb7d9f21b61bd89b186547993dd]

        sw: prefix members of SwAnchorMarker, SwEditWin, SwShadowCursor and ...
        
        ... SwSrcEditWindow::ChangesListener
        
        See tdf#94879 for motivation.
        
        Change-Id: Idd3aba48ca7329b6df2e52fff73eca360aa76be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126399
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-06  Jan-Marek Glogowski  <glogow@fbihome.de>  [f989406acd1726606def5ea0e19bd2399116ae83]

        Fix lockfile compiler warnings
        
        Now that we've patched the source for typos in commit
        921c2059f9a85ab5ad26463e864e49d4e7b48d9e ("Fix typos"),
        also fix the compiler warnings.
        
        Change-Id: I0e1f1bfe19a475c431d2244257e245482950a843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126380
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-05  Johnny_M  <klasse@partyheld.de>  [b2e3cfb19e7dd3e2986ff0fb3e0bc38d19a37ac2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2088858faca938ef6ff18cb5f018094e2545eb74
          - tdf#132643 Translate German section IDs
            
            Change-Id: I49df2a5e5673f96c90f6954ab8945802fb45a091
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126361
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [66d77b95129ac121a0114ebc2b8c33f14b535e06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13390f6d56ae6af400f11861282dbb51c1cb622d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I336c4ee96f10e0be15a89f7702d13d2f5f9dc005
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126360
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [991d417f4dfaff0917795599b959689d5b212431]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c9719cb965b25a0f98af2265d512f17988ffe255
          - tdf#132643 Translate German section IDs
            
            Change-Id: If17f9b0756705357bd3e9ea7288a144ea8f69d29
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126359
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [df33620de3d45124053e48398c27a9a2430c3798]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4141c8abee3b6e2cd71d285cd1690d40b932c2a
          - tdf#132643 Translate German section IDs
            
            Change-Id: If5d40269f1404cdaabcec40458229b125932308d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126358
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [3f4ad867fa5338d4e42793cb7a5f9bafa4a44fd7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f7a6029fcf3753fd8fc4a644879050c79401369
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id2bc5f6edecdfba927e73b70376e7b5c5d7e3781
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126357
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [0e2303bdeef4582cde1099125c91aee6aece7cde]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89b9bbf278ce42a5c4088de7758efd17de9843a8
          - tdf#132643 Translate German section IDs
            
            Change-Id: If86699638a4c8252e09bc202204804b9be1ed186
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126356
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [c30bc77079b7d764eae065bb527d4c3ba1905a21]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 63edcccd65a660f52765b6a62570342aa5ab0350
          - tdf#132643 Translate German section IDs
            
            Change-Id: I325086af8d6a4d0ea831596a23a846aad1dc148e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126355
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [914986101f986ec96e371b65999306fcfd01a2f6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2a258fe05759e8cdec8ea6bab1b31b0d19211ec2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I17a89c39168eef190e4c4182d40ebbd7076daec2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126354
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [865675a9a9e74d71e9c91b85dc8891d9094ebd44]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce82c31bde650b363d2170eeba5217ea1cbb3f1d
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibd0f57eb0676f699c1ca3d56f4e42420c2ef1f12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126353
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [4ea208040c736a11df92b939ec08dbc85fe75595]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b88a7d768dd2eaf95a9ca9ad75f98be8c470ed15
          - tdf#132643 Translate German section IDs
            
            Change-Id: I23f5d13712314ad647163c7d7cae3e5f7540dfc0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126352
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [b8e0b95b5fe76ae4eb442dac28ef4438ca75c7d2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f0f2c703b70316bb4b11493015823d7f5647efc5
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie4775e2745c5e84c1b8316b5ef93336554236d63
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126351
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Johnny_M  <klasse@partyheld.de>  [71933f22248f17e3d3926332d3998913138afd62]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9eff72927e896aef13253f4e63d6adb4499f0da8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I820b6f53cad68e1576227bd7c5a1362ba2b9c3e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126350
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-05  Noel Grandin  <noelgrandin@gmail.com>  [c8fbbc26e0d94c4c556a9a5e3cb94b796b7bca1b]

        remove OMultiTypeInterfaceContainerHelperVar2
        
        superceded and replaced by OMultiTypeInterfaceContainerHelperVar3
        
        Change-Id: I46ad14bcc9bfcfe1a5279414e72d9356ddb02329
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [20e991f0269adc49b790fcabdc3ad31af4f03de5]

        cid#1494630 in the end bMirrored -> SetMirrorFlags(BmpMirrorFlags::Horizontal)
        
        no matter whan else
        
        Change-Id: I0b645f787f294a3ba21a4e4dad4da37e7baaa4c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126389
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [87f370f1f7c84d4d7d8fc004f0d4a8a3986e02e3]

        cid#1494630 #5 rearrange to demo Logically dead code
        
        Change-Id: I96a8cde9c8886c2d962ff1053607810bc457cb88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126388
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [2340639df07755a1d67fb59b52a9ece65f279f4a]

        cid#1494630 #4 rearrange to demo Logically dead code
        
        Change-Id: I3d7efa59ecaf21a582644594f26a1d2116d1965c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [50b8dacd0b53b694e14b2982968e3eebd0d5cbb6]

        cid#1494630 Logically dead code
        
        Change-Id: I02022ee4a0524accbe33fd2da3dc971f434b0d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126386
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [0f976bdb7b7735b4364ae6f3a84a950ab07822bb]

        cid#1494630 #3 rearrange to demo Logically dead code
        
        Change-Id: I263ce873a2a308a1a986fd09310b691d9c6525fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [b8e36ff21c50985d56ec499211302586bc451891]

        cid#1494630 #2 rearrange to demo Logically dead code
        
        Change-Id: Ie94429f2d8c8c05780c53b223b7d5bf20d63a522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126384
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [ba14600d900656461f79b20ccd407f67fd2d3562]

        cid#1494630 #1 rearrange to demo Logically dead code
        
        Change-Id: Ia5be7432f6972135bcb792f29221f75eff8f66dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126383
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Caolán McNamara  <caolanm@redhat.com>  [a64a41e8bd33a84156daf34b2f3b7f40cbc99b26]

        don't build lockfile if using external LOCKFILE
        
        Change-Id: I99f1f6c95f11a2d8f7b57b20965a35066bb1bbee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126381
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-05  Noel Grandin  <noel@peralex.com>  [cba21368d8297e4039c907ff847a3074ece09599]

        speed up property access in charts
        
        uno::Any copy and assign is fairly hot, so try and do those operations
        in one step
        
        Change-Id: I110566ba98788d5a658d229433de291c8cdf146c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-05  Luboš Luňák  <l.lunak@collabora.com>  [374e261ad1ea8b41f5ecdd850c27fdc961c4868b]

        increase maximum document thumbnail size from 256 to 512
        
        It's 2021. Something's telling me people now care more about
        document previews not being blurry than an insignificant size
        increase of documents. See e.g. comments #21,#25 in the HiDPI
        bugreport tdf#144214. It also doesn't make much sense for the
        thumbnail creation to try hard to make the image smooth and
        then downscale it too much.
        
        Change-Id: I8df778dda05cf42cd27adf8f7757097fc7650acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126376
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-05  Luboš Luňák  <l.lunak@collabora.com>  [1ceb4f36a7cabe7a0fb2b0c2e36079389d6a69b2]

        generate a thumbnail to save without a metafile
        
        This is similar to 59cca1a28df4cdc94450d68cc1e247a8fb5ff6f3,
        if the wanted result is a bitmap, there's not much point first
        converting to metafile and then to a bitmap.
        
        Change-Id: I594e1e47bc499acf42f6a551f4114091dcf75b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126375
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-05  Laurent BP  <laurent.balland-poirier@laposte.net>  [19c8404ff66e259787ec28e067c2a5828b7df3be]

        tdf#143956 Remove page size of Writer templates 4
        
        This patch concerns "styles" templates:
        - Default:
          - remove some styles without specific behavior
        - Modern:
          - remove some styles without specific behavior
        - Simple:
          - remove lang tags
        
        Change-Id: I04690ef9d6db3c1296b3c870e03c8915c5c85260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121610
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>

2021-12-05  Laurent BP  <laurent.balland-poirier@laposte.net>  [ec25082ca76b5342a5be29cc9dc7cf7d0ad40b4e]

        tdf#143956 Remove page size of Writer templates 2
        
        This patch concerns "offcorr" templates:
        - Modern business letter sans serif:
          - use predefined style names to have them automatically translated
          - use automatic date format according to locale settings
        - Modern business letter serif:
          - use predefined style names to have them automatically translated
          - use automatic date format according to locale settings
          - update preview
          - reduce green rectangle to fit Letter format
          - left align text to fit with A4 and Letter (instead of Tab)
          - remove unused styles
        
        Change-Id: Ieedeec05050509f5ec82ce97b9b9483c239e87d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121175
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>

2021-12-05  Laurent BP  <laurent.balland-poirier@laposte.net>  [87882007a1dd90a8f88b06ee20068b413b8ff0fe]

        tdf#143956 Remove page size of Writer templates
        
        Removing page size force LibO to automaticaly choose page size according
        to locale settings (instead of fixed size in template).
        Remove unused styles. They will be defined by LibO according to locale
        settings
        This patch concerns "personal" templates:
        - CV
        - Resume1page
        
        Change-Id: I107d914a5dedffacf6ec080eebf910fbd8333d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121130
        Tested-by: Jenkins
        Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>

2021-12-05  Luboš Luňák  <l.lunak@collabora.com>  [9d08f3363188d446b287c445f1ab09339c65d208]

        fix caching of ScQueryItem values for multiple entries (tdf#146037)
        
        The code assumed that there would be only one ScQueryEntry.
        
        Change-Id: Idf4cc6bdbbf1edad7d13eb9a9643bb67e199dd01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126368
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-05  Luboš Luňák  <l.lunak@collabora.com>  [9e0d471466997fce4b59ac88d6bd8ad0108b8974]

        move entire ScTable::ValidQuery() into (Sc)QueryEvaluator
        
        This reduces the number of arguments passed around, removed the need
        for ValidQueryCache (as the data can be now cached in the class
        itself), it'll allow even more optimizations, and it also makes
        the by now rather large (almost 1000 lines) helper class a proper
        class instead of tons of inline code.
        
        Change-Id: I585cf580b3e7b2d4512aa535176e97c0abfd547a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126367
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-05  Noel Grandin  <noelgrandin@gmail.com>  [8206a8ef2fbf2de9cca6fb360707fb9b50e6a92c]

        use visitor in ViewObjectContact::createPrimitive2DSequence
        
        to reduce intermediate object creation
        
        Change-Id: I03d34d15e88f82027f865868aca08503e38fd6ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126372
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-05  Noel Grandin  <noelgrandin@gmail.com>  [422b407290fe082adea9067835521da8c067743d]

        improve ViewContactOfGraphic::createViewIndependentPrimitive2DSequence
        
        no need to create a temporary intermediate container
        
        Change-Id: Iaa87011ff007c313a2b223eb95133b5cb626b468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-05  Noel Grandin  <noelgrandin@gmail.com>  [7c52337f9517135db13d75ecbbc10d7e26e01489]

        updatePathFromSdrPathObj can just call getRange
        
        no need to extract the list of drawing primitives
        
        Change-Id: I70fbf1ac69c923fdbeaa00c885404b599f6fa2b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-05  Noel Grandin  <noelgrandin@gmail.com>  [b22a0178530f5b41e40b2cc2719d9e6062ea9d1a]

        improve ImpConvertContainedTextToSdrPathObjs
        
        no need to create a temporary container
        
        Change-Id: I60eceec1800ff57c0a600c2b049c157d94aef3b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Stanislav Horacek  <stanislav.horacek@gmail.com>  [2934472ab888ebfe64a153984af2902fac63a7a0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 32b4e8c9931810bf55bacc2c029e711d82b8c42f
          - localize proper strings and fix example result for StrConv function
            
            Change-Id: I6bd2b9fda9217c589f6e53b0341d8028a6ca44c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126348
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [07777befa3789a9314a9a5c836f9d4f6c54a0f9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 43abde3c6b788ec7ac5384e7a6601bfac1cfc744
          - Remove avail_release <notes> from SF documentation
            
            Change-Id: Iab4c6ecba7f4db57bed82a29c5c4b9434b4efbb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126295
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-12-04  Caolán McNamara  <caolanm@redhat.com>  [96e9eb56f0f76590ccc46a6948ae00803a92f113]

        cid1494597 silence Uncaught exception
        
        and
        
        cid#1494595 Uncaught exception
        
        Change-Id: I2433b777c15703c441142c2102e5d71f7dfc18ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126366
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-04  Caolán McNamara  <caolanm@redhat.com>  [bbb09ebda08fec0702de0fb50dbe630acf73af2f]

        cid#1494598 Uninitialized pointer field
        
        Change-Id: I80d64bd321af2cbc800a6b6c1d560d0b6b42fd97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126364
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-04  Caolán McNamara  <caolanm@redhat.com>  [695b570c505d4e977d77dea9d69f62ffdce16611]

        ofz#41602 fix more build failure in ubsan build
        
        Step #30 - "compile-libfuzzer-undefined-x86_64": instdir/program/libsvxcorelo.a(viewobjectcontactofsdrmediaobj.o)(.data..L__unnamed_6+0x18): error: undefined reference to 'typeinfo for sdr::contact::SdrMediaWindow'
        Step #30 - "compile-libfuzzer-undefined-x86_64": clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
        Step #30 - "compile-libfuzzer-undefined-x86_64": make[1]: *** [/src/libreoffice/vcl/Executable_pptfuzzer.mk:13: instdir/program/pptfuzzer] Error 1
        Step #30 - "compile-libfuzzer-undefined-x86_64": make: *** [Makefile:170: Executable_pptfuzzer] Error 2
        
        Change-Id: I5e19ad82e376a84e90dd9ebe90806903d995ccbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-04  Caolán McNamara  <caolanm@redhat.com>  [dfe3c23c790a2917d01d8f3dd74a6b6448e9b476]

        use --with-system-lockfile for coverity build
        
        we don't care about that tool
        
        Change-Id: Ifc0910a77177e504a35fcf35efad92d6ede63507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126365
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [921c2059f9a85ab5ad26463e864e49d4e7b48d9e]

        Fix typos
        
        Change-Id: I9f7d185d7d9ac0b90473464932103a7c5545fdc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126260
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a1686ba9e51027463733086a62ded7b0641f61a]

        use more OUStringLiteral in dbaccess
        
        and remove some dead defines
        
        Change-Id: I432cfbac954ae6798813ca5a31684e66f772acb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f1ca4727d517fc49a8fdbdc49629865c51f296ab]

        Fix typo
        
        Change-Id: I16dc352088252805a2d398620b3bbfe040a87a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126259
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-12-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [d0efe32523572547890d98e0ce4f554acf2117b5]

        Remove merged gie library from install set
        
        Removed in commit 2270a58d7b25e683449c180576b7647f8d5256f4
        ("Move GIF writer from filter module into VCL"), but accidently
        re-added (at least to the install set in commit
        ed583bf8d553b145f83b66118253aaf7ac94fa1a ("gbuild: introduce
        plugin + loader concepts").
        
        Change-Id: I6ed9ab5aeab6a2ecc8dd169f0d8ddfb42b334b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126347
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-04  Luboš Luňák  <l.lunak@collabora.com>  [050c51d55b77a5f8a66d1da6a74d741d81510b21]

        resurrect description of the "super" scaling algorithm
        
        Commit 53d51dbee6d4037c4cfc3fa743de8dac76da48c6 described it
        only in the commit message, but that's hard to find if I want to
        know _now_ what the thing does.
        
        Change-Id: I012ead2aa9d81ce1287da3a32e43a038cd9ba18d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126316
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-04  Mike Kaganski  <mike.kaganski@collabora.com>  [fb37997ece889d9a90bb5de600fcb763d339734c]

        Small refactor
        
        Change-Id: I9487c32a1482da24e7b656141b116e7c5ca6d2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126297
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [4539ffe350ebe28ff6d0f5cd4a6c3d45c1424fba]

        use OMultiTypeInterfaceContainerHelperVar3 in Interceptor
        
        Change-Id: I58707ce88ccea1df3c11a5c07e1c72c68bf6c249
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126344
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [3b34255a63bf6dbbf669e951df898b37cfd48650]

        use OMultiTypeInterfaceContainerHelperVar3 in SwXMailMerge
        
        Change-Id: I6d02ff1133db770025151ab1af3cea2a62261d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126343
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noel@peralex.com>  [68723d543d37e42546aa42af8a855f96a5a70b5c]

        use OMultiTypeInterfaceContainerHelperVar3 in embedserv
        
        Change-Id: Iafb936ae3ba23c0c16c2da8538f8da29688df692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126346
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [4a1e9a911e62f0421b7ed67603091d49d30f7b4b]

        use more OUStringLiteral in sc
        
        Change-Id: I6d9547bd15fa255253e1309fc3f83b4f0ed6491e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126349
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b20ab49eeb703c755f3ac51ca12214fb4a2b6f63]

        sw: just use o3tl::toTwip for 1cm instead of the magic number 567
        
        Change-Id: I19c1cc2abc8af8d5bd58b2cb4ed096d02e277408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126333
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [79824cea8add8dfd69a284800f5b365fc20bece9]

        use OMultiTypeInterfaceContainerHelperVar3 in PropertyChangeNotifier
        
        Change-Id: I861bb71702a56997ce5b28bca7750dba6a11f9c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [e782eefb2610af6d412d91d1a94dafaf53806f89]

        use OMultiTypeInterfaceContainerHelperVar3 in ContentResultSetWrapper
        
        Change-Id: I50d79f400833987b5f5050826c7901c4fc22386e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [9f636b5ee56e552e19a23a553cb034c76407a662]

        use more OUStringLiteral in reportdesign
        
        Change-Id: Ic5b7ab4cf672a964c3f74570a9ec4191b20372ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [b739bdaba8064ae8b428cfa1c7c6010d662539a3]

        use visitor in getViewIndependentPrimitive2DContainer
        
        to reduce intermediate temporary data creation
        
        Change-Id: I3f13b0e02c1fa374e8d70768ae47c7f6da254462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2219d37896ee4a8662d9dccc06a73302f8ac6c7c]

        loplugin:stringliteraldefine in sc
        
        Change-Id: I49159fa9b525ced9423c9a37d8a31b15cc8b1e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [a469d1353f4efd2c22d2fd8497a0d456e11760ad]

        use OMultiTypeInterfaceContainerHelperVar3 in PersistentPropertySet
        
        Change-Id: I4bb884fc76f766d58afec3632c7443e348ea5342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [962c9cb5cf9127ccad2c9d947ea03d40e4e556ce]

        use OMultiTypeInterfaceContainerHelperVar3 in SfxStatusDispatcher
        
        Change-Id: I79beb9ab22184176c67555d8742c01c11c9e6f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [5aac0725c79d21dba11c03d3c39ccb986a5e7cca]

        use OMultiTypeInterfaceContainerHelperVar3 in LinguProps
        
        Change-Id: If996b6de42d12bd336c941bd7b63e5ce39e582fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noelgrandin@gmail.com>  [a14b4e1d8a6ae8af24feb0e29b75d0e8996f974e]

        use OMultiTypeInterfaceContainerHelperVar3 in SortedResultSet
        
        Change-Id: I371dc8d97a4d6cb24c69e97b874bb50384df7526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca05d480bd4456342f290f975a7353b7d9a63e95]

        rename Primitive2DDecompositionVisitor methods
        
        from "append" to "visit"
        
        The current naming comes from when I created this class as replacement
        for passing Primitive2DContainer around and the naming was meant to
        reduce code churn.
        
        But now that I'm using it more, the naming is an impediment to
        understanding the code.
        
        Change-Id: I4ee0156c7ffb534eac64f1c05eac6b8c67c25ab9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  Luboš Luňák  <l.lunak@collabora.com>  [0a596fbd94e1750e9d1f5cdab624c719b33c3ab4]

        only bilinear+mipmap for Skia/raster to-screen drawing (tdf#146024)
        
        The code already tries to hide the cost of the high-quality bicubic
        scaling by caching, but there are still cases where there's too
        much scaling done. Since this is only drawing to screen, use
        only bilinear+mipmap scaling in raster mode, which should be good
        enough (it's what the "super" scaling VCL algorithm for
        BmpScaleFlag::Default does as well).
        
        Change-Id: I75c86932e097411422dc1ef5e0534059dbf11ff8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126326
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-04  Stanislav Horacek  <stanislav.horacek@gmail.com>  [42bf88831dbaa4ad22ab8e1e03b375ad520fd2f7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 676c20ccd9f5cb6e3fd9d882e39a02028c1f0340
          - use proper angle units in Cos and Sin description
            
            Change-Id: I318e1a20ee220fc306f2f4af2e61cc5c1b7237b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126205
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [2e5d18127f3be6741677bb567f9db37e2f4a9908]

        Fix cairo function pointer usage
        
        WASM strictly checks function signatures, so forced wrong
        casting of function pointers compiles, but any call will
        generate a runtime error, even if the argument is actually
        ignored.
        
        So this adds a bunch of wrapper functions to pass instead.
        
        Change-Id: Id976ea3ca81a792c8af539884ef741f5d23fc2c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126317
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [885d9427045bb35df842600b060da4ddc4791429]

        loplugin:stringliteraldefine in reportdesign
        
        Change-Id: I9e685bb6650517a6f73b6978e448b4fc0242e2ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126307
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-04  TheRock Builder  <libo@therock>  [35cc52f77804eda54d4e466da1b2afbdc1555ef3]

        Fix --disable-(avmedia|scripting)
        
        So it's not a good idea to change the patch without testing it
        again. I'm still hoping for a better usable MediaItem then the
        previous dummy. The ODF stores a preview image and it should
        allow to export the media.
        
        The scripting fix feels like a workaround. somehow the final
        class specifier triggers something that makes the linker fail
        with missing destructors for all std::unique_ptr objects
        derivated from SbxFactory. Implementing these as virtual
        overrides didn't help, neither as {} or = default. So this
        removes them in the  !"#if HAVE_FEATURE_SCRIPTING" case.
        
        Change-Id: I9f6751f44e0247ed31c27be0ee816239795e9372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126330
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-04  Julien Nabet  <serval2412@yahoo.fr>  [33f3470474dd79a3a0eae1f6cb369e6400b58b6a]

        Related tdf#132145: fix Print/Size NoSuchElementException
        
        warn:unotools.config:1167538:1167538:unotools/source/config/configitem.cxx:423:
        ignoring XHierarchicalNameAccess Print/Size: com.sun.star.container.NoSuchElementException
        message: Print/Size: /home/julien/lo/libreoffice/configmgr/source/access.cxx:437
        
        Regression from a5808c6446f6de536c44cf5bfba6566ad398fb8c
        tdf#132145: Synchronize SmMathConfig with configuration
        
        Change-Id: I472bd3dc2d4bf76700c2b9e1df9148737dfaa1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126335
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-03  flywire  <flywire0@gmail.com>  [cf04ff456858702e5d661c465d31a54587010af3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4156bb3b6cfcecb9ccce1ef5c7656d67df93b5c9
          - Consistent ScriptForge Examples Variable Names
             - ui for UI service
             - bas for Basic service
            
            Change-Id: I0eb4fbdd021db1149985bb37ba8b29a57297a6eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126092
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-12-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [deea6377737349080361b85ff4f6b7c5ea670ffa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7566aae37b2c20ef155ac0fec53eac393fc288c4
          - Document new methods in SF Session service
            
            Change-Id: Idd2d0674aea815d7fb6743a92e348b58865ab09c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126145
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [ee5ed29991bf9de1111a8313d7c22560b26a56af]

        ofz#41602 fix more build failure
        
        [LNK] Executable/fodsfuzzer
        workdir/LinkTarget/StaticLibrary/libfuzzer_calc.a(native-calc.o):native-calc.cxx:lo_get_constructor_map::map: error: undefined reference to 'com_sun_star_comp_framework_SoundHandler_get_implementation'
        clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
        
        Change-Id: Id22e52491bf95eff7b72ac1fc9e2c63f3dfb30b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126332
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9f5c9f0d6af2cb2f39d5bc1513216b8d892977c]

        replace comphelper::OListenerContainer with OInterfaceContainerHelper3
        
        OInterfaceContainerHelper3 is in wide use and can do the same thing with
        less ceremony
        
        Change-Id: I5252738d6b7bda6245c66da46352944ead79bd52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [ff2068892d88091b26f3a3c034bcca49727d5840]

        Resolves: tdf#140254 don't expand the column with buttons if dialog expands
        
        Change-Id: Ic7ca17bb2df6de2107ddb7a2a935bf8b81d58607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [ff25d6a123beb42476bf42d189b3033a86835b2a]

        ofz#41602 fix more build failure
        
        since...
        
        commit 8b9f8f0f9d38cc64f742fe5358fce88d0f82391a
        Date:   Sun May 30 13:23:16 2021 +0200
        
            libxml2: use xml2-config dummy for internal build
        
        added -lm for all DISABLE_DYNLOADING targets which results in link time
        failure of:
        
        [LNK] Executable/cgmfuzzer
        /usr/bin/ld.gold: warning: Cannot export local symbol '__asan_extra_spill_area'
        /usr/lib/x86_64-linux-gnu/libm-2.31.a(s_atan.o):function __atan_ifunc: error: undefined reference to '_dl_x86_cpu_features'
        /usr/lib/x86_64-linux-gnu/libm-2.31.a(s_ceil.o):function __ceil_ifunc: error: undefined reference to '_dl_x86_cpu_features'
        /usr/lib/x86_64-linux-gnu/libm-2.31.a(s_floor.o):function __floor_ifunc: error: undefined reference to '_dl_x86_cpu_features'
        /usr/lib/x86_64-linux-gnu/libm-2.31.a(s_sin.o):function __sin_ifunc: error: undefined reference to '_dl_x86_cpu_features'
        
        like https://bugzilla.redhat.com/show_bug.cgi?id=1433347
        
        because we end up with -lm inside the -Wl$(COMMA)-Bdynamic group of
        solenv/gbuild/platform/unxgcc.mk
        
        Change-Id: I080bbe462c9fcf0129ca3d4c3c764aa42eee9774
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126331
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [a08089b8ead3c6b2f87d0a9da2be5c30df81347e]

        flatten ImplB2DPolygon data a little
        
        Change-Id: I64860888bf23a11e8dfaf1fc72132b6fadc526ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [f869f3cb773de041b5bf7162ed1afac88c902061]

        some translations are searched for in the wrong .mo
        
        since...
        
        commit c895a6d8298a349784cd0aafff4bf518ac8d0a7d
        Date:   Fri May 15 10:51:10 2020 +0200
        
            Resolves tdf#132799 - Deleting of colors unclear
        
            Tooltips added for disabled states
        
        those ones are in cui.mo (CuiResId) not svx (SvxResId) which
        is more obvious now we only SVXSTR for strings in svx
        
        Change-Id: I595bd5aadd8ead18291ff818405bec594c8d32db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126318
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [335ffc0f7bff71112a336e803ab5e0857f1f3771]

        don't use SVXSTR for translation ids that are in cui.mo
        
        use that just for the ones in svx.mo. This just changes the
        programmer-level #define and keeps the translator-level message context
        the same to avoid triggering any retranslations.
        
        Change-Id: I3ca90618e27c4d7abbc77de1096e67bafe49e7ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [42387cd10802912891fc2b7554e92d5c0c79b0f1]

        improve member field name
        
        Change-Id: Ib4e3bda523364a3f8f0d95a764833765ac8c3f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b0202bf43133fd440fae62ccb4727dafb2da211]

        loplugin:stringliteraldefine in xmloff
        
        Change-Id: I9216c18d3ba4a4a528a49198fdfe547a66c06b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [30f41d99af6cf84b5993d5c5c24fc49ef39bd756]

        ofz#41602 fix more build failure
        
        since...
        
        commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
        Date:   Tue May 18 01:11:41 2021 +0200
        
            Fix --disable-avmedia for DESKTOP build
        
        Change-Id: I31404c1a4c2ba71fb47388d87b59ecbee87ff603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126324
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Justin Luth  <justin_luth@sil.org>  [3c10bb151e5864c0ff532910b9f81185aa49c21f]

        tdf#129629 sw UI: Find/replace - stop popping open MORE section
        
        This was a regression from LO 6.1, where it would always
        show the "more" options if one of them was enabled.
        
        That might be fine for the dialog initialization
        (and that is how I implemented it)
        but even that is a bit much. Perhaps it should be a
        search option that is remembered while the application
        is running. Is that what pSearchOptions holds?
        
        Anyway, this much I can easily figure out.
        Someone who knows more about these things
        can enhance it further if they want.
        
        Change-Id: I8288bea514840f4ea06deb00a3603aa9568a75b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126226
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-12-03  Tibor Nagy  <nagy.tibor2@nisz.hu>  [fc1e5202cbfb36b28b0e597811f39895c19ae6ba]

        tdf#129430 PPTX export: fix workaround for "At least" line spacing
        
        to avoid bad overlapping lines.
        
        PPTX does not have the option "At least", so line spacing
        with this setting is converted to fixed line spacing.
        Improve this workaround to use single line spacing, if the
        "At least" value is lower than the size of the characters,
        like "At least" is handled by Impress.
        
        Change-Id: I29b41225d48fd9a447e7f6ef3a8a7cc7ba9ef354
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125553
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [41f736f9bea66657bde2f41afe506e376fe8548e]

        tdf#145604 indicate the row as the target when dropping in a visual tree
        
        and indicate between rows when dropping in a visual list, which is what
        we are doing for the gtk version.
        
        a visual list case is tools, customize, menu and drag and drop the
        assigned commands around.
        a visual tree case is tools, macros, organize dialogs, use libraries
        to create two libraries, and move to dialog and create a dialog in
        one library, and drop it onto the other library to move it between
        libraries.
        
        Change-Id: Ia8dc944c1f411b1f072ad1c8dcc755a1e44e3b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Jean-Pierre Ledure  <jp@ledure.be>  [88c82f10280a3de773091ddc41983c6d2f8ee157]

        ScriptForge - (SFWidgets) new SF_Menu service
        
        Display a menu in the menubar of a document (form document to be done)
        After use, the menu will not be saved neither in the application settings,
        nor in the document. The menu setting does not affect the modified status of the
        document.
        
        The menu will be displayed, as usual, when its header in the menubar is clicked.
        When one of its items is selected, there are 3 alternative options:
          - a UNO command (like ".uno:About") is triggered
          - a user script is run receiving a standard argument defined in this service
          - one of above combined with a toggle of the status of the item
        
        The menu is described from top to bottom.
        Each menu item receives a numeric and a string identifier.
        Each menu item may be decorated with a tooltip and/or an icon.
        
        The AddItem(), AddCheckBox() and AddRadioButton() methods, when
        coompared with their equivalents in the SF_PopupMenu service,
        receive 2 additional arguments: Command and Script.
        
        The various document services receive 2 additional methods:
           CreateMenu(), returning a Menu service instance
           RemoveMenu()
        
        Very short example:
           menu = doc.CreateMenu("My menu", Before := "Help")
           menu.AddItem("First Item", Command := "About")
           menu.AddItem('2nd Item", Script := "... URI notation ...")
           menu.Dispose()   '   Once set the menu object may ve erased, listeners stay tuned
        Later in the lifecycle of the document, one may run:
           doc.RemoveMenu("My menu")   '  doc.RemoveMenu("File") works as well !!!
        
        All the functionalities are available both in Basic and Python user scripts.
        
        Change-Id: Iabd157573693e9648fcb06d36c90af9a22b17a6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126309
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [4321fb516f4a65b047b182c4cb6f9c9a232efd85]

        Resolves: tdf#145959 menu pos should be relative to SmCmdBoxWindow
        
        Change-Id: Ie8da9bbb4385b3315fd62e6f2dc8ab394ea3709f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [47b088e2c7917762f96c44346931cc40d56b2efa]

        Fix --enable-mergelibs plugin dependency
        
        Not sure why I didn't use gb_LinkTarget_use_libraries instead of
        the internal version.
        
        Regression from commit ed583bf8d553b145f83b66118253aaf7ac94fa1a
        ("gbuild: introduce plugin + loader concepts").
        
        Change-Id: I600aee16c0c7296e14435c20ef4f47123db93a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126268
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-03  Miklos Vajna  <vmiklos@collabora.com>  [9ebf7034c9cd3a0601542397254ebc97647a862e]

        svx: consider color effects when updating objects for theme changes
        
        This builds on top of commit 48f0c5f73f99c919ec24deadc96c3cf5483c9314
        (svx: update objects of pages of a master page when the theme changes,
        2021-11-30), but now not only plain colors with colors with effects are
        also considered. The luminance modulation / offset is what PowerPoint
        uses the generate lighter / darker variants, tinting / shading is what
        Word uses.
        
        Change-Id: Ibfafb9be9986645117015bf3b05491daec8914be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126270
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e2fe1bb107c263cd3a0b04c14fc0267b3df2380]

        loplugin:stringliteraldefine in dbaccess
        
        Change-Id: Ic7c2d23747d56432037f145b7ce9a5b6cf3724cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  László Németh  <nemeth@numbertext.org>  [9e1e88ad5cf2dc0e9b188c60930445652a6c7519]

        tdf#145720 DOCX export: fix loss of tracked moving
        
        of documents created in MSO to keep interoperability.
        
        Export moved redlines as moveFrom/moveTo instead of
        del/ins elements (also for newly created tracked moving).
        
        Export "MoveBookmark" elements moveFromRangeStart,
        moveFromRangeEnd, moveToRangeStart, moveToRangeEnd, which
        imported from DOCX documents created in MSO. Without them,
        moveFrom/moveTo elements were imported as plain deletion
        or insertion in MSO.
        
        Note: MoveBookmark elements were imported and exported as
        collapsed plain bookmarks. Now keep their ranges, also store
        the information of moveFrom/moveTo for correct export.
        In the export filter, mandatory author and date of the tracking
        information restored from RedlineData of the first redline
        within the MoveBookmark, if it's possible.
        
        Follow-up to commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving".
        
        Change-Id: I54242453a7f7d8f73ea074fc74e8e7bc86d07d01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126258
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [7563216425c1a43166db083d809073b268f7884f]

        sal_Int32 is sufficient for svx::frame::Array
        
        Change-Id: Icc1ebf769796d23e226b72a3decf74ab15e09e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126274
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Stephan Bergmann  <sbergman@redhat.com>  [7485e13b6a99eedc8730d1a3eb72599213208f26]

        CppunitTest_oox_export needs the ASan LD_LIBRARY_PATH hack now too
        
        ...for CPPUNIT_TEST_NAME=testReferToTheme::TestBody introduced in
        f36767fde87191258ea21f3faac0be6ad79328e0 "PPTX export: handle theme colors from
        the doc model for shape text",
        
        > /home/sbergman/lo/core/test/source/bootstrapfixture.cxx:248:(anonymous namespace)::testReferToTheme::TestBody
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 256
        > - failed to execute: sh /home/sbergman/lo/core/bin/officeotron.sh /home/sbergman/lo/tmp/libtest_oox_export.so1a9v6q.tmp > /home/sbergman/lo/tmp/_anonymous_namespace___testReferToTheme__TestBody_1a9v6u.tmp 2>&1
        > Exception in thread "main" java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-11-openjdk-11.0.13.0.8-2.fc35.x86_64/lib/libsystemconf.so: /home/sbergman/lo/core/instdir/program/libnspr4.so: undefined symbol: __asan_option_detect_stack_use_after_return
        
        Change-Id: If241bc3aa727c56ae7fa69744957690c722fbb1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-03  Mike Kaganski  <mike.kaganski@collabora.com>  [f586839956d6937920aa377fe95854c1a0518d96]

        Windows format name is FileGroupDescriptorW for Unicode strings
        
        See also commit 5fb9f4ffa9284c7248e2e82210506babaad4044d
            tdf#145964: Windows format name is FileNameW for Unicode strings
        and commit 52e1d0ca6ad38b4b4fdc77b0951ad26f0ac18ec5
            Windows format name is UniformResourceLocatorW for Unicode strings
        
        We don't use other standard clipboard formats which have W variants.
        
        Change-Id: I45afac76fe3db406c8a761f48eee9e931fd50d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126276
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [f0877e314ef28db2ff4d42706e2bc897acd96379]

        bodge installation of lockfile-progs for now
        
        Change-Id: I1f7395fd12539d936f3651e5e173799a7c61e14e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126286
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [566b086ae056b479e9560ad742303431230dae60]

        ofz#41602 Build-Failure
        
        can't use the internal Executable_lockfile because it needs itself to
        link
        
        Change-Id: I51e3a910bedc038bb6776cd67d16ea706fbc071f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126285
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Stephan Bergmann  <sbergman@redhat.com>  [0c1c300ed7ce168755ae945822eb7a1c610cfa25]

        Rather use ScopeGuard to prevent catch and rethrow
        
        ...than 6bc5d6cac2fd9e029357c618510a3b5f3aa7c085 "remove counter-productive
        catch-all blocks"
        
        Change-Id: I07fe5821ef5bf60f74f5ceb5feedd7dc79e73dfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126275
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [7f02cb80ac2075b65ee1adee4e29d1d5c4819424]

        lose the caching in ViewObjectContact
        
        we reload the data every time anyway, so the caching is useless
        
        Change-Id: I575cc2fbe5a2fe9f42c58894f471cabb842cdd46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126273
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [3337d210f3121559afc3574a41d821bb2283d773]

        avoid some copying in ViewObjectContact
        
        Change-Id: I0d55bffca9d526b97edd9ea5283d0420e675236d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126272
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [8ef60f89bae290d8c38acacfc792b32176f9afa9]

        use OMultiTypeInterfaceContainerHelperVar3 in OContentHelper
        
        Change-Id: I04e8c5fd38618689ad148ba6fbe823971881cbb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126194
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Michael Stahl  <michael.stahl@allotropia.de>  [2b256c84aa4c063c8161b32a7b424daa28b5741b]

        tdf#136452 sw_redlinehide: fix crash in undo of delete across sections
        
        The problem is that on the first SwUndoDelete, the m_nSectDiff branch
        MoveNodes() creates a top-level SwTextFrame for the node "Korean", then
        the m_nReplaceDummy branch does another MoveNodes() to move the same
        node into the section, but its frame remains outside the section.
        
        Generalize fix 55576842ec72a748d0bad123d41fa03c89fc136d for tdf#131684
        to check the last SwTextNode inside the section if it has a frame
        outside the SwSectionFrame.
        
        (regression from 6c7245e789f973cf6dad03f7008ab3f9d12d350c)
        
        Change-Id: I30495d8f3d8fc0d70cb20df44409174edc2d4a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126257
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-03  Michael Stahl  <michael.stahl@allotropia.de>  [c9267ca4fa7fa94a1bf79320bec54428a6ad4804]

        gdb: BigPtrArrayPrinter gets confused by libstdc++ std::unique_ptr
        
        It looks like this in libstdc++:
        
          <BigPtrArray> = {
            m_ppInf = {
              _M_t = {
                <std::__uniq_ptr_impl<BlockInfo*, std::default_delete<BlockInfo* []> >> = {
                  _M_t = {
                    <std::_Tuple_impl<0, BlockInfo**, std::default_delete<BlockInfo* []> >> = {
                      <std::_Tuple_impl<1, std::default_delete<BlockInfo* []> >> = {
                        <std::_Head_base<1, std::default_delete<BlockInfo* []>, true>> = {
                          _M_head_impl = {<No data fields>}
                        }, <No data fields>},
                      <std::_Head_base<0, BlockInfo**, false>> = {
                        _M_head_impl = 0x567fd20
                      }, <No data fields>}, <No data fields>}
                }, <No data fields>}
            },
        
        Note there are 2 _M_head_impl members, and somehow gdb 11.1-2.fc34 picks
        the wrong one.
        
        A manual cast to std::_Head_base<0, BlockInfo**, false> seems to help.
        
        Change-Id: I1332c2fc6eb2661d417fd92a73aed977bbb1dcea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126220
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-03  Michael Stahl  <michael.stahl@allotropia.de>  [e58583e70b3434a158a3902cc7ae81d0b3bdfc49]

        tdf#145062 sw: deal with failing insertion of field in SwWrtShell
        
        Change-Id: Ic0c479e97b7a5f6fcc7f7eb454eb77a5c47de9db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126191
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-03  Michael Stahl  <michael.stahl@allotropia.de>  [89eb90ceea414974289b57f15e769d08b80fe9a3]

        tdf#145062 sw: really destroy text attribute when insertion fails
        
        SwTextNode::InsertHint() is documented to destroy its argument
        SwTextAttr in case insertion fails, but it doesn't do it on all
        branches.
        
        Change-Id: I270df9acf36993d894899c20c86a6bc43d782001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126190
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-03  Caolán McNamara  <caolanm@redhat.com>  [b01e7dec34e92a46add83de503c086ba12a3ab51]

        Related: ofz#41376 reuse ScExternalRefManager ScDocument in ScExternalRefCache
        
        Change-Id: Iaed5b7929411dc938fe19df02905a9c9faa52051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126256
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-03  Stephan Bergmann  <sbergman@redhat.com>  [aa5ee0085c7d8b8713f4dbed0009b38b9fabb281]

        Stop swallowing exceptions in ~ScopeGuard
        
        ...and rather assume that m_func() is implicitly noexcept.  (Catching exceptions
        had been done ever since the class' introduction in
        7d1c1393eecf0cfcce06f35b0b18311f1e887aee "INTEGRATION: CWS presfixes01: #i37777#
        new scopeguard" and looks more like a general safety measure rather than
        catering for m_func() that deliberately throw exceptions.  This change is in
        part a prerequisite for using this inline-only class in salhelper, where use of
        css::uno::Exception would cause a circular dependency.)
        
        Change-Id: I00f885a4a6e18f3ce77e84d53e96f00c49708cdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126202
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-03  Mike Kaganski  <mike.kaganski@collabora.com>  [ba7db98cca3d8516697c94ef0d6af27db9e1655e]

        Use strncpy to avoid overflow and fill the rest with nulls
        
        Change-Id: I29c427b87aa87af3236bd6e1a7e9e08e6f470bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126227
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-03  Stephan Bergmann  <sbergman@redhat.com>  [5c7c54332f779afb847ece6396637e17957fc0d1]

        UBSan still needs RTTI of some types to be exported
        
        ...for which it had been removed with e10e5c15cc51d3b2a5e4b699c5f381aa92a17c4e
        "improve the script for reducing symbol exports",
        
        > [LNK] Executable/vcldemo
        > ld.lld: error: undefined symbol: typeinfo for BitmapReadAccess
        > >>> referenced by vcldemo.cxx
        > >>>               workdir/CxxObject/vcl/workben/vcldemo.o:(.data+0x1ADF8)
        > >>> referenced by vcldemo.cxx
        > >>>               workdir/CxxObject/vcl/workben/vcldemo.o:(.data+0x1AE68)
        > >>> referenced by vcldemo.cxx
        > >>>               workdir/CxxObject/vcl/workben/vcldemo.o:(.data+0x1AEB8)
        > >>> referenced 7 more times
        > clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
        > make[1]: *** [solenv/gbuild/LinkTarget.mk:833: workdir/LinkTarget/Executable/vcldemo] Error 1
        
        > [CUT] writerperfect_stream
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_writerperfect_stream.so
        > workdir/LinkTarget/CppunitTest/libtest_writerperfect_stream.so: undefined symbol: _ZTIN13writerperfect16WPXSvInputStreamE"
        > warn:unotools.config:545145:545145:unotools/source/config/configmgr.cxx:147: ConfigManager not empty
        
        > [CUT] dbaccess_empty_stdlib_save
        > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_dbaccess_empty_stdlib_save.so
        > instdir/program/libdbalo.so: undefined symbol: _ZTIN7svxform19OSystemParseContextE"
        > warn:unotools.config:550847:550847:unotools/source/config/configmgr.cxx:147: ConfigManager not empty
        
        Change-Id: Ifbaaa64881bcfd5befdefbadb51948d06b92ca63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126201
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [085f15acfdb96155011d60b6127ea6f6e4a9a263]

        no need to create Primitive2DContainer here
        
        we can just use the visitor API and skip a whole bunch of object
        creation
        
        Change-Id: If3dfa2fc1811e708963b8e6ecf4af6508b9f2a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126216
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [95266ea93458644c89f1ac7bf924c5323ed64544]

        use OMultiTypeInterfaceContainerHelperVar3 in framework
        
        Change-Id: Ia2f59322511ed85492708262f90de26b33275105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [cd888e4c04d209a8d436906369c13d6206c176f4]

        use OMultiTypeInterfaceContainerHelperVar3 in SbaXVetoableChangeMultiplexer
        
        Change-Id: I60088bdf046659ca94a2aa9c09a3091e2dd03945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126196
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [c67e6db61c4abc0f63221ef324408080a6ebf4f1]

        use OMultiTypeInterfaceContainerHelperVar3 in SbaXPropertyChangeMultiplexer
        
        Change-Id: I744a3e5a7c7f4172bd4619647fb6decc6cd8e132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [0edde043a03cb7c6b6123d79700bfcdff9882f88]

        use OMultiTypeInterfaceContainerHelperVar3 in GenericPropertySet
        
        Change-Id: I8ce94a11b632f51086480acef8dcfc3e8bea1b65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126193
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Miklos Vajna  <vmiklos@collabora.com>  [f8fa0d27074ec1af450196efa1be14ae1dda9314]

        sw: remove useless debug code in SwWW8ImplReader
        
        One can check the value of addString in a debugger without this code.
        
        Change-Id: I863b3c70e741f270b5aac07ba2c0fa5186daeaa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126261
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-03  Mike Kaganski  <mike.kaganski@collabora.com>  [52e1d0ca6ad38b4b4fdc77b0951ad26f0ac18ec5]

        Windows format name is UniformResourceLocatorW for Unicode strings
        
        See also commit 5fb9f4ffa9284c7248e2e82210506babaad4044d
            tdf#145964: Windows format name is FileNameW for Unicode strings
        
        TODO: replace one remaining format from CFSTR_* family that we use (see
        https://www.codeproject.com/Reference/1091137/Windows-Clipboard-Formats):
        FileGroupDescriptor -> FileGroupDescriptorW. That one needs more complex
        handling.
        
        Change-Id: I4d4ad83099854768cf36c7b3d89059d79c8e77f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126213
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-03  Stephan Bergmann  <sbergman@redhat.com>  [74895bf55846c56cebbd927817b8b9756ed800d0]

        distclean generated solenv/lockfile/autoconf.h
        
        ...introduced with e050b09c7ef193da9da4441d9984c793e35b5a8a "gbuild: serialize
        dynamic link for static builds"
        
        Change-Id: I31410cfe2291d51a860d33fed1861eb933bbb10e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126264
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-12-03  Noel Grandin  <noelgrandin@gmail.com>  [cd96af570352ff19b1f1a3d006750237eba8ca5c]

        create OMultiTypeInterfaceContainerHelperVar3 template
        
        to supercede OMultiTypeInterfaceContainerHelperVar2 and add
        (a) type-safety
        (b) skip the need for doing UNO_QUERY when firing events
        
        Change-Id: Iaeb2421da5d92d2d4fd4feb45ab5019ca85d0d7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126192
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [6e334850104b2fe5d325328e64e08c190027f8d9]

        Normalize --disable-scripting handling
        
        Just add the default value to the platform section and handle the
        AC_ARG_ENABLE action-if-not-present accordingly.
        
        Change-Id: I050ace4b20808cedcc4b8ab92f8766c5b5d49d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126266
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [fb308c193bc9f0d07ad2cccd5a0b239f86cbe442]

        Fix --disable-scripting for DESKTOP build
        
        Unfortunatly we cannot add --disable-scripting to
        sub_conf_defaults, because Java currently has no
        equivalent to the PYTHON_FOR_BUILD setting.
        
        Change-Id: I89938a17307a363f5de808200914940503312829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126186
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [6ac1e9e7f0be23b529992c268d2c563fe40fff76]

        Disable the xmlCleanupParser test in a static build
        
        Linking the static soffice.bin results in a failure, because
        of the duplicate xmlCleanupParser symbol. I don't think there
        is a sensible, alternative runtime test for a static LO build.
        You could analyse the static binary itself...
        
        Change-Id: Ib871e378a28affca24c4285d396d8bcae478f1f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126198
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-03  Jan-Marek Glogowski  <glogow@fbihome.de>  [8b9f8f0f9d38cc64f742fe5358fce88d0f82391a]

        libxml2: use xml2-config dummy for internal build
        
        When building a static LO with --disable-dynloading on Linux,
        --without-system-libs failed for me. And it left me really puzzled:
        raptor configure failed and claimed it couldn't link libxml2.
        
        raptor's config.log showed missing math functions. xml2-config of
        LO's build is patched and it includes a -lm. The xml2-config in my
        chroot doesn't. But we explicitly pass the xml2-config for
        non-system-libxml2 build. Reading the configure from raptor didn't
        reveal a way, that it could somehow pick up the xml2-config from
        the chroot, but that code is autoconf-complex...
        
        When running "sh -x configure", it turned out the configure script
        actually picks up the LIBXML_* flags from the environment, which
        are set by LO's config_host.mk. These just add -lm for Android.
        
        So this adds a xml2-config.in "dummy", which overwrites the one
        from the libxml2 source and just echos LO's LIBXML_* values and
        it adds -lm for all DISABLE_DYNLOADING targets.
        
        Change-Id: Ia713cf80c8e7dc989cf23c224e7a0f7ea1210a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116409
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [29145df0977baa866e7da94d1d385b772ae1e6ce]

        Resolves: tdf#144811 use the hover-style menu for color submenus
        
        Change-Id: I8653c36d084f9df5a4d34baf7d88e2f2b5f1609b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126209
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [5346168fa919ad98224c4d2079e738a4d0b8d164]

        undo "allow vcl gen menus to have non-square images"
        
        This reverts commit 06f36cc7ca8fc056dd8cf4d8cdbe682f9a003cef
        
        ended up not using this so don't need the extra complexity
        
        Change-Id: I64a2d6f620cc864a75523be6612c5cf2086f7a00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126210
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Miklos Vajna  <vmiklos@collabora.com>  [37892b97d00de29a86c735aaaff47c12e66e78ad]

        sw: update previews of OLE objects on "update all"
        
        Charts were already updated, it was not consistent that other embedded
        objects are not updated.
        
        This is especially useful if an ODT file is manipulated by a 3rd-party,
        then loaded into Writer just to update the previews of OLE objects.
        
        Change-Id: If61aa037739c593abade933dcdd5474ad566b3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126253
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [d6c3a3116648415dd324b139ade99f5fb4e46379]

        apply ui-rules
        
        Change-Id: I118f3b3a7cf6ed2b1315cbb0db75a512a44e3f77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [66e4ffd27fae894ae67ee7337a490aab18e56562]

        Related: tdf#144410 submenu indicator misplaced under x11 gtk
        
        so drop the GtkTreeViewColumn expand and go back to setting the size via
        the size-allocate, but for wayland launch it in a callback because
        setting the column widths during the size-allocate callback doesn't work
        as hoped for and the indicator is misplaced.
        
        Change-Id: I58a7a11cb1a1c065cee364f932cebddfb9ea453c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126203
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [3f48954724242352d606e0ac2091afc049580c86]

        ofz#41591 if only recording to metafile, don't convert tools->basegfx->tools
        
        just record the tools::Polygon so the copy on write shared polygon
        is stored rather than a new instance
        
        Change-Id: Ia2061365351457e0f0eec3be42c62063e64fdc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126247
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [24db04bbe09f19a49733699e42d0e095eb417fed]

        Related: tdf#145901 use x11 popover replacement for all non-menubutton cases
        
        replacement from inside real popover under x11 as in autofilter case
        doesn't work.
        
        Change-Id: Ie4ba95645a8094732b9bad9829426e77375d63ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126204
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [d606853593a737c28c23a8a9cd47c00dcc17d517]

        ofz#41591 reject incomplete polygon records
        
        Change-Id: I4761c2ae76463ad2441abf2599b69f35dc572a5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126249
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [c3e1c1c5509f6ca9abe786bcc2dabf542a7f0ec1]

        ofz: Executable_lockfile needs Executable_concat-deps
        
        Change-Id: I4cb2b1aa2b923884f4a2af23d69ff71c66ecef81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126262
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [41a9ff8d9ef6e0dbb4a71b0f923079eb8ffd1851]

        sw: support for other sdt attributes roundtrip in datepicker
        
        Word Control Field with datepicker is implemented with LO datepicker,
        but during this conversion we lose some field data, like control
        color, data mapping, etc. This data is already retrieved and stored
        in grab bag, so we need just to keep this grabbag in field and use
        it again on export.
        
        Change-Id: I6af8204fe1a7d2f9081d83372a6786b2f86260d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125486
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-02  Miklos Vajna  <vmiklos@collabora.com>  [cd9bb2dfcf07e5274be85e6a8906056ab08a1ca3]

        editeng: avoid non-ascii characters in the source of ContentInfo::dumpAsXml()
        
        And map ^A to &#1;, the &#9; was a copy&paste error.
        
        Change-Id: I4e9af635dda83530ba53fa58f0140465b7cbd4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126248
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [dfdf33a34729de7f256ed396be93fb96b4844404]

        tdf#124412 - Set actual condition for an inactive date entry
        
        In the conditional format screen, set the actual condition for an
        inactive date entry instead of "Date is today" in all cases.
        
        Change-Id: I3d3f05c35a9830a1e82d68521e80e88c99b43a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126059
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-12-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [92af2ac089ae37a6367f09622b24c6546b8ba6de]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b63a6a4d3e61d57c552051037f69b8cdbac167b
          - tdf#141474 CBool, CByte, CCur function signatures
            
            Change-Id: Icd8febb66930020e39d310c7604a0419dccc9f0c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125137
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [adb3ba5432af64fe5c65c766ea78630ac96b6448]

        use smaller squares for smaller checker patterns
        
        Change-Id: Ib46b0906a0adf52f3806b269976ad15d280a28e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Miklos Vajna  <vmiklos@collabora.com>  [f48a9cc5371bb5d318af929ad9f7157a8b3f88aa]

        sw: remove DECLARE_ODFEXPORT_EXPORTONLY_TEST
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I6dddee7211f49d0e6fd9095465449deb90a6f8ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126200
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [4fc44b5f911e6518fc9e8a315531ca852d19c642]

        uilogger: Adapt code to the new syntax of uitests
        
        also fix the license header
        
        Change-Id: Icc759c695f192e1768210f66bff57a936df5fc4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126219
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-02  Miklos Vajna  <vmiklos@collabora.com>  [f36767fde87191258ea21f3faac0be6ad79328e0]

        PPTX export: handle theme colors from the doc model for shape text
        
        As a start, do this only in case there are no effects used. If there is
        no theme color or there are effects, fall back to the old code.
        
        Also move parseExportStream() from SdModelTestBaseXML up to MacrosTest,
        so oox/ test code can use it as well.
        
        Change-Id: Ia76581dcef110341f6c3e60f22c34818ed0dcabc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126215
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-02  Michael Stahl  <michael.stahl@allotropia.de>  [c8e21d246bcb4289cb25c82be440cd07b7418436]

        nss: upgrade to release 3.73
        
        Fixes:
        CVE-2021-43527 Memory corruption via DER-encoded DSA and RSA-PSS signatures
        
        Change-Id: I5c3f169c57fc2763029b07ad7e325b2f53b7e28f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126218
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-12-02  Johnny_M  <klasse@partyheld.de>  [e9f3a5dcca93d2b53d291587600fb460665ff46b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58f4a36a64ef30988de8f3fef9b8b291de011f8a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0c961f94e82041f8bb5030f15141f08bd8e7bb3e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125966
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f0ee569b15a56a925cd0bd53b9582f189011e67d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to a5785431526070d60f2391d3248a01d81079ac0d
          - More pt-BR thesaurus cleanup
            
            + typos fixed (more to fix)
            
            Change-Id: I23c7b5d47fdca3e03c302332576917f8004e937c
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/126223
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c0313b98028132729a22ce586047f158bd980980]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 27015f7cdd33f759bcd29f27ceb8077322da353f
          - Cleanup of pt-BR thesaurus (part)
            
            - Removal of words with 0 synonyms
            - fix some typos (many more to fix)
            
            Change-Id: Id3b7d73aab421274c745e7695748bed8396ae7be
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/126221
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-02  Jim Raykowski  <raykowj@gmail.com>  [ac21d937690c1ef995df22e11384e0fab226472e]

        Check pointer to prevent crash
        
        Prevents crash when postit is in a hidden section or folded outline
        content and SwPostItMgr::Hide function is called. In these cases the
        pointer to the postit annotation window could be nullptr.
        
        Change-Id: I16d08504cdd89bdb136f8a0d2615cf3028ca8ece
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126175
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-02  Eike Rathke  <erack@redhat.com>  [31d038966de5db78bd31dfd1008ee02c050d510a]

        Call CountNonFilteredRows() only if necessary, tdf#124103 follow-up
        
        i.e. only for different row selections or the first time.
        
        Also const as const can and reference rRange vs aRange naming.
        
        Change-Id: Iee926eeefa7ae5db1e6b8cff768a0c7c106c3476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126189
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-12-02  Caolán McNamara  <caolanm@redhat.com>  [76f2f1c5d2ed38b4fbca03ddc47640ca6e0145f8]

        ofz: fix build failure by building Executable_lockfile first
        
        Step #3 - "compile-honggfuzz-address-x86_64": [build LNK] StaticLibrary/libdtoa.a
        Step #3 - "compile-honggfuzz-address-x86_64": /bin/sh: 1: /work/workdir/LinkTarget/Executable/concat-deps: not found
        Step #3 - "compile-honggfuzz-address-x86_64": make[1]: *** [/src/libreoffice/solenv/gbuild/LinkTarget.mk:833: /work/workdir/LinkTarget/StaticLibrary/libdtoa.a] Error 127
        Step #3 - "compile-honggfuzz-address-x86_64": make: *** [Makefile:170: StaticLibrary_dtoa] Error 2
        
        Change-Id: I2dd48297f321b72bb28f993041d5728fd6c68a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126217
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-02  Tor Lillqvist  <tml@collabora.com>  [d37341ea988a8e213d7acafdeef0d6af76ba8b58]

        Bin pointless comment
        
        Change-Id: I173dbfc93fabbacacc1a68189b7a50cd993f1caa

2021-12-02  Stephan Bergmann  <sbergman@redhat.com>  [45d93ea9273a59053f60471ee82bb9fbd2d46c97]

        Fix clang-cl -Zc:dllexportInlines- build
        
        That flag is only supported by clang-cl, not by MSVC, and
        c7c9f3f57a2feae5d3bc3c47104786883ed09e44 "use clang-cl's -Zc:dllexportInlines-
        for clang-cl builds" apparently naively assumed that it would work to build LO
        with clang-cl and that flag without actually trying it out, and
        1040228c356d75c5228cde4d6103f9b446848e4b "My clang-cl build does not work with
        -Zc:dllexportInlines-" effectively disabled it completely.
        
        The way to avoid unresolved external symbols during linking of URE libraries
        (see the 1040228c356d75c5228cde4d6103f9b446848e4b commit message) is apparently
        to also build libraries that the URE libraries depend on with the flag, hence
        the change from gb_Library_set_is_ure_library to
        gb_Library_set_is_ure_library_or_dependency.  For now, I only marked those
        additional libraries (unoil and xmlreader) that actually caused issues when
        linking the URE libraries.
        
        Change-Id: I3a85c73246250981cd86b7ee41f87b41f393a4b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126012
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-12-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6052d7b6e488250545653adcec541095a3d33300]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b127658216cdbac1becdba794ea97f8f8b219e15
          - tdf#145617 break dense paragraph in bullets for CInt
            
            + refactor headings
            
            Change-Id: I4c01861f41fd545f63b12e50a9829f97fc9ff4cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126199
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [f1512321581e0e605582018395ab91f04a2da8fe]

        uitest: fix consistency of footers
        
        According to TEMPLATE.SOURCECODE.HEADER
        
        Change-Id: I50b9d5e65c5da654914ba42d0688a2acbda1d2cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126187
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins

2021-12-01  Jim Raykowski  <raykowj@gmail.com>  [f53dd906e79ab77f0ab4a421e47650a9cc4ce1d6]

        SwNavigator: make comment tracking work in content navigation view
        
        and respect comment tracking setting
        
        Change-Id: I93c50cd5e022512bd092fed0922e8a22bdc7b665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126085
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-12-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bffeb5e351b8b52fb2215ce35a455465337a45fe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4973d1a792d20d77e7401c1d2b1fe9821695297d
          - tdf#117868 Help contents for sep= in CSV files
            
            Change-Id: I6ac919fd95b9c30be3f1f2aa7bc18efd40b6d2d7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126188
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [ed583bf8d553b145f83b66118253aaf7ac94fa1a]

        gbuild: introduce plugin + loader concepts
        
        This introduces two concepts: a plugin and its loader (library)
        
        LO currrently has dependency cycles for some libraries. There is
        scui, which depends on sc, while sc dlopen's scui. There are the
        various vclplug_*, i18npool plugins, filters/gie, acc, etc.
        
        Usually these plugins link to their loader library, because they
        use its symbols. But as a result there is no sensible way to
        express the runtime dependency of loaders on the plugins.
        
        In GNU libtool plugins are called modules and they are implemented
        in an IMHO more sensible way by allowing missing symbols at link
        time. This way you can have a dependency from the loader library
        to its plugins, as the plugins don't depend on the loader, but you
        lose the link time detection of missing symbols.
        
        While this is in theory possible in LO too, LO currently has
        plugins, like acc (accessibility), loaded by tk (toolkit), which
        depends on svt (svtools), which itself depends on tk, so dropping
        the tk dependency for acc on its own doesn't help :-(
        
        And while the dependency of the plugins on their loader is fine
        for the shared / DYNLOADING build, for the "static" builds you
        must (somehow) link the plugins into the executables.
        
        I also codeified a few rules into the build system along with it:
        * just plugins are allowed to depend / link other plugins
        * plugins aren't allowed to be linked into the merge lib
        * plugin loaders are "limited" to libraries
        
        At the high level, this is implemented via new gbuild calls:
        * gb_Library_set_plugin_for,lib,loader: declare a library to be a
          plugin of a loader library and add a dependeny from the plugin
          library to the loader library
        * gb_Library_set_plugin_for_nodep,lib,loader: ^^^^ without adding
          the library dependeny
        * gb_Helper_register_plugins_for_install: "plugin" replacement for
          gb_Helper_register_libraries_for_install to implement some
          additional checks in the build system
        
        In the end this patch just adds a bit syntactic sugar and nothing
        changes for any build.
        
        Change-Id: I7b01d9c384cbc5838bd2cc93aff18e4868939d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126163
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [b9c106d491d2c13d74760a47e424192a3291860a]

        Disable avmedia/util/avmedia component without GUI
        
        Regression from commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
        ("Fix --disable-avmedia for DESKTOP build").
        
        Change-Id: Iac995b1e02463adfcd56761eeb822bd3a367ddde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126184
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Caolán McNamara  <caolanm@redhat.com>  [df9e8c1553090d42cb3c9f391532629286ec1104]

        fix indent
        
        Change-Id: Ie51ad19b3d1f0c184c0bffeddd0204fad3a15070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126178
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b71bc7ec704301325752ba9d0efd0b75663349b]

        uitest: fix license headers
        
        Change-Id: I6b1a2808af9e6bb4d3240a83798c3c5958ef38e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126183
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-12-01  Gabor Kelemen  <kelemeng@ubuntu.com>  [970cbb120a62e952e80348b8e94478600241273a]

        tdf#145819 Revert logic of the image-with-rotation dialog: sc & sd
        
        Change-Id: I906e83ada98fd7a583872a2eaa76d7fd04a5401b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126110
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-01  scito  <info@scito.ch>  [6382f51d2a4d9a3ec8eef2471467ab0dbf7a8294]

        tdf#124103 count non-sequentially selected rows or columns in statusbar
        
        Count non-sequential cells if either rows or columns remain the same and are
        sequential.
        
        Examples:
        A1, A2, A4 -> 3 rows, 1 column
        A1, A2, A4, B4 -> do not show any count (as before)
        A1, B1, D1 -> 1 row, 3 columns
        A1, B1, D1, D2 -> do not show any count (as before)
        
        Change-Id: Ib8f20d560e4dc4a2b673c6e0962397563d803519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125979
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [42e56a3b4fd8372fae2bc6d768383ba1edf69918]

        loplugin:stringliteraldefine in editeng
        
        Change-Id: Ie8f4c338f1636945f61ec139706353df88a81087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126171
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [f9e79a91f15e10ededad0f103c4ffe0ca38fcb31]

        Fix --disable-avmedia for DESKTOP build
        
        Probably additional bits can be removed, but this now passes.
        
        Change-Id: I366bec43cfd6fb02e914c85c711b3b19586d534d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126161
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [b8084b0dee7d28f4fc8fa92eae6171880ac3a9c8]

        tdf#144244: sc_uicalc: Add unittest
        
        Change-Id: I4445152d8bcba0b571873a39c98936a4fcd207f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125872
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [59a90439a4e1d26e53008451237388fd26a8adf6]

        Simplify ImpStrChr and ImpScan
        
        Change-Id: I8c752a7838ded7f3783982411ec937f46224d522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126172
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-01  Julien Nabet  <serval2412@yahoo.fr>  [1d45f84bd08c8d196fcf3c9baaf2cad010884e5c]

        tdf#144244: fix crash when FILESAVE a calc file after delete some columns
        
        see bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=176507
        
        Regression from 3238606c8470f3eaeada3fc601e186ec5cfac925
        tdf138138 Apply shape shift also to NoRotatedAnchor
        The 'normal' anchor (as on screen) is connected to the snap rectangle,
        the NoRotatedAnchor is connected to the logic rectangle. They differ,
        if the shape is transformed, e.g. rotated. Error was, that values of
        the 'normal' anchor were applied to NoRotatedAnchor instead of
        calculating the shift of NoRotatedAnchor independently. The error
        becomes only visible on save, because there the NoRotatedAnchor is
        used. Effected shape types are legacy shapes, text boxes and
        transformable OLEs.
        I have not tested, whether this fix would work for LO 7.0 too.
        
        Let's apply the same controls as we do with ScDrawObjData retrieved with GetObjDataTab
        
        Change-Id: I73cb3dd3c47a7ec55667e498d4a62842ce63d861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125852
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0d2c2ab55a20bfebd87f2296bb8b2d79508de082]

        tdf#145964 related: also drop special-casing in TransferableHelper::SetString
        
        Follow-up to commit 5fb9f4ffa9284c7248e2e82210506babaad4044d
        
        Change-Id: I46d5ea404f77ac5ff67b6ee6a42afee13274a481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126174
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [0b35970ffb46075d19f1a65391dde8182f322ef0]

        webdav-curl: just mask CURLE_QUIC_CONNECT_ERROR
        
        ... obviously we still need the throw...
        
        Change-Id: Ia7960ce2296e196be600f6b9a8139bc261fd2159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126170
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  gulsahkose  <gulsah.kose@collabora.com>  [7b3be7f6f3d800e2ad86f5a043e6e9b21ed4409f]

        tdf#140912 Better handling of the picture placeholders.
        
        To see icon and placeholder text at the center of picture
        placeholder shape, we set the TextContourFrame and GraphicCrop
        properties.
        
        Change-Id: I49e3d08c9020e593232c60c97af3f45fb620075e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126165
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [c28a13b9e2bd864e8c574d604bcd6da9e93fb476]

        Unify and simplify floating-point-to-integer conversion
        
        * Round the number once, to avoid doing it three times for a successful conversion.
        
        * Round to nearest before convertsToAtMost/convertsToAtLeast, to handle cases like
            Dim n As Integer
            n = 32767.4
          which should succeed.
        
        * Add overflow checks to Hyper (U/Int64) types.
        
        Change-Id: Ib10837e6df3cc1e3aba7a657e882bd40e344fd3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126173
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-01  Michael Stahl  <michael.stahl@allotropia.de>  [25a368c30acb54e0819d2b2b890a3fd1530d8a76]

        tdf#145928 svx: fix undo of sorting shapes
        
        The problem is that in sw there are these obnoxious virtual SdrObjects
        that are created and destroyed by the layout.
        
        0  SdrObject::~SdrObject()
        3  SwVirtFlyDrawObj::~SwVirtFlyDrawObj()
        5  SwFlyFrame::FinitDrawObj()
        12 SwFrame::DestroyFrame(SwFrame*)
        13 SwFrameFormat::DelFrames()
        14 SwUndoFlyBase::DelFly(SwDoc*)
        15 SwUndoDelLayFormat::SwUndoDelLayFormat(SwFrameFormat*)
        16 SwHistoryTextFlyCnt::SwHistoryTextFlyCnt(SwFrameFormat*)
        
        This misdesign means that SdrUndoObj::pObj may point to a deleted
        object.
        
        Commit 9bc6160e0acbc78be998129ea55ed7e4529959fa may create SdrUnoObj
        when saving the document, so that is now an additional way to introduce
        the problem.
        
        Try to work around it by not using a SdrUndoObj subclass in this case,
        but create a new SdrUndoAction subclass that uses SdrPage::sort() and
        stores no pointers.
        
        There is still the problem that changes in the layout or view settings
        like "Hide tracked changes" could cause different virtual SdrObjects to
        exist between when the Undo was recorded and when it is activated, in
        which case nothing is done.
        
        But that really requires a larger refactoring such as having a SdrPage
        for the model that never contains virtual SdrObjects, and another
        SdrPage for the view that does contain virtual SdrObjects to fix.
        
        Change-Id: I4cf5d4eb8bb24a51730c55ff34a043b8a88fdb52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126153
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-12-01  Luboš Luňák  <l.lunak@centrum.cz>  [9425ea3f8f5622e857dc1e860b151fd94323de0c]

        apparently link.exe -dump is a short for dumpbin.exe
        
        So use the latter, in case we'll want to use lld-link, as that one
        doesn't know -link.
        
        Change-Id: I35e05064da06741cae1aa267b455e22741fef090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126157
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-12-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [fe1da0ce2e097e5b8db6be9c141f2615b45ea8e7]

        writerfilter: extend SdtHelper for better support control types
        
        There is much more different controls which must be supprorted
        in future. So approach with isInsideDropDownControl() and
        validateDateFormat() is not sufficient. Use enum to determine
        and store control type.
        
        Change-Id: Ibea7fde117c059053195be213a3ae821644f277c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125471
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [4437071c3f7c0b51881b0b1a5d5a68bdd100328b]

        Qt fix non-X11 build and introduce CHECK_* macros
        
        Explicitly uses ANY, so it's hopefully easier to read then QT,
        QT5 and QT6 in the otherwise same macro names.
        
        Change-Id: Ie9bbbc858f5f9db5c8b429c7b0d8a897ac6159fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126168
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Miklos Vajna  <vmiklos@collabora.com>  [5b253b2197e957fb5e42e3d0e233c10ac83afc10]

        PPTX export: write the theme for the master pages from the doc model
        
        The instant benefit is that now the name of the theme and the color
        scheme are preserved, but this will also take changes done on the UI
        into account (which is not true for the grab-bag).
        
        Change-Id: I162eb7275d5a69d66db71fc5cd6e2e3ec94725bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126164
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [e050b09c7ef193da9da4441d9984c793e35b5a8a]

        gbuild: serialize dynamic link for static builds
        
        This is a hack, because make has no way to serialize processing
        of a target (just .NOTPARALLEL for the whole Makefile).
        It uses the lockfile tool / liblockfile 1.17. Since that polls
        the file, I adjusted the poll timeout to 5s max, because I found
        the 60s wait much too long. Guess even 1s would be ok...
        
        Since it's just a small build tool, I simply copied and patched
        its source, instead of creating an external project. And there
        is --with-system-lockfile=... to use an external binary instead.
        
        Change-Id: I16bc4579a273dcf1aac811ae4723ca325a0b9eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126152
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Noel Grandin  <noel@peralex.com>  [47cdd3ba605324072db617c6ae2d1a647b8bdce6]

        revert part of "remove counter-productive catch-all blocks"
        
        as sberg points out, this rethrow will not necessarily crash
        the process
        
        Change-Id: I0ced6c102d1c0c1bf680b0903fcb232cc891bf92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126167
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [90243614b253bc2d6b3d12930f111eab5491316a]

        Distinguish between --disable-gui and --without-x
        
        For the static WASM build, we need to build with GUI but without
        X11, as this just includes a static Qt backend.
        
        We already have USING_X11, which indicates that the platform will
        use X11 as a backend, so we can match --without-x to USING_X11=no,
        independent from the --disable-gui setting.
        
        Fitting all this into vcl/Library_vcl.mk was originally getting
        quite complex, but by moving the logic into configure.ac in a
        previous commit, the branching becomes way easier.
        
        Change-Id: Ia2ddba3400b4306b609a1f64823cca75061e0593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116125
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [301443e6bebd9c68a0229df832ddcb3188b575d3]

        m4: Add test flag to libo_CHECK_SYSTEM_MODULE
        
        Automatically adds an ENABLE_* AC_SUBST and test for a disabled
        test via test_*, like ENABLE_EPUBGEN and test_libepubgen.
        
        Change-Id: Ifaf27d4d1193f41de6291ab70d973fe151f36b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126169
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e10e5c15cc51d3b2a5e4b699c5f381aa92a17c4e]

        improve the script for reducing symbol exports
        
        And apply some of the results
        
        Change-Id: If555476fdd951cbc1d01fb3ef3ab1cbca2b64960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  Noel Grandin  <noel@peralex.com>  [fabce43fe1caf3a59a7d9dc1074a74b704f9fa24]

        fix thinko in OMultiTypeInterfaceContainerHelperVar2 change
        
        in
            commit d8a526eabe3a7256c1637307e8de74c54e5df4eb
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Tue Nov 30 21:36:08 2021 +0200
            improve OMultiTypeInterfaceContainerHelperVar2::disposeAndClear
        
        spotted by sberg
        
        Change-Id: I45316c29d82c5ece4c0ff9faa40f656b5aab3c0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  4k5h1t  <ask160203@gmail.com>  [e01854cd8f0c20c57d7e78103834bd806ead3cd9]

        tdf#132293 removed some unused imports from uitest
        
        Change-Id: I491b08dd8af69083a13c4dc00223314a6203e2d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126160
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-12-01  Dennis Francis  <dennis.francis@collabora.com>  [307c1f13821386687b8cf3c560ff2570b89ac3a9]

        tdf#144107: fix incorrect conditioning on bGrid...
        
        introduced in 3092322bb83998397b09d3f34b6d04b5e5c1da50
        
        The intention was to avoid the default line drawing in the original else
        branches to be conditional on bMergeCover. The previous patch used
        'bGrid' as a surrogate for the original 'else' case - which is wrong.
        
        Change-Id: I7c6b49fa9c21064312273b1051ffc7f81de3fef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126076
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-12-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [26f976aad49683f18e62219a2b5c0efcb38090d4]

        tdf#145826: sw_layoutwriter: Add unittest
        
        Change-Id: I1fc5f2f05080afcca1e6b1e04a363add811c8dbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126150
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-12-01  Noel Grandin  <noelgrandin@gmail.com>  [74d827c1757b991f926df80d30a8d2549201d0b9]

        use more OInterfaceContainerHelper3 in sw
        
        Change-Id: Icb194de0521bf60f3db623c35e695afc3a3edbcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125982
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [70a479abe267c0bd4c0c0fd1e945d8e6e4856af2]

        CURLE_QUIC_CONNECT_ERROR requires curl >= 7.69.0
        
        This new error code replaced several CURLE_FAILED_INIT in curl
        commit cbb5429001084df4e71ebd95dbf748c3c302c9f7 ("ngtcp2: Add an
        error code for QUIC connection errors").
        
        Instead of escalating the curl version further, just mask it with
        CURL_AT_LEAST_VERSION; this way my Ubuntu 20.04 schroot can still
        use the system CURL for the build...
        
        Change-Id: I24afd32737e2ab74d9e4ce1722012d522ae010bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126158
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-12-01  Miklos Vajna  <vmiklos@collabora.com>  [9d3b636466ba113fa769cca786b8f70fe2a70789]

        sw doc model xml dump: show the format of section nodes
        
        The SwSectionNode has an SwSection, which is registered in an
        SwSectionFormat, which finally tells us if it's a protected one.
        
        Change-Id: Ie46c516f900f1c479c11cbbaf061973400614a2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126151
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-12-01  Noel Grandin  <noelgrandin@gmail.com>  [d8a526eabe3a7256c1637307e8de74c54e5df4eb]

        improve OMultiTypeInterfaceContainerHelperVar2::disposeAndClear
        
        no need to create an array, just move/empty the map in one step
        
        Change-Id: I6480d671ca0542c4a871756df1eeee257087db5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126154
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-12-01  Mike Kaganski  <mike.kaganski@collabora.com>  [5fb9f4ffa9284c7248e2e82210506babaad4044d]

        tdf#145964: Windows format name is FileNameW for Unicode strings
        
        Otherwise SIMPLE_FILE clipboard format arrives encoded in ACP,
        and fails for any characters not representable in ACP.
        
        Change-Id: Ice8cfd98955e3ef49682aa21b41a313786b291f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126131
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-12-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0ce6e166a46565b1f4abd237d4b67f646a465c63]

        Fix typos
        
        Change-Id: I5e41be3f7e650db0019bcd42a3c1c2cb3bc5dd0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126155
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [4ac9032163cf55c160145373e7c41741c9c339ca]

        don't disable Skia tests on Mac
        
        MACOSX is now not just the aqua VCL backend, and the Skia backend
        can actually handle tests in HiDPI mode too.
        
        Change-Id: I38ce9b7ed0a9a3a5f02a25223582bfde7b56ab9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126148
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [cdebd76284204f6a34df2a01d4eaedbd540c5fe6]

        fix Skia copyArea() not coping with coordinates outside (tdf#145811)
        
        Apparently the call is expected to handle even copies that are
        partially outside of the area, e.g. window scrolling seems to do
        this occassionally.
        
        Change-Id: I9a06c047f00d6b5b920d61f577baa9181bdc5a2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126147
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Luboš Luňák  <l.lunak@centrum.cz>  [a49cd1cebde3853aca839dc6dc0df7845585480f]

        fix clang-cl build with -Zc:dllexportInlines-
        
        This hack causes undefined references to those dllimport symbols,
        and it doesn't seem to be necessary for clang-cl (I've checked
        both normal and mergelibs build with -Zc:dllexportInlines-).
        
        Change-Id: Iaa336989507344442b59cec2e6c5078f91a42980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126149
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [5fbc7ab55a119504fc484cef28de52b6d5cf8b12]

        svp: normalize DoYield
        
        I somehow missed / forgot, that SvpInstance::DoYield was now also
        yielding on the main thread and doesn't try to do "funky" multi-
        threaded event processing anymore (because it's no GUI), since
        commit 0efd06de8fca4036c4132b2745a11273b1755df2 ("vcl: fix hangs
        in SvpSalInstance"),
        
        So this just moves the main thread part into ImplYield and
        implements DoYield like on all other architectures, as described
        in README.scheduler.
        
        I've tried to fix the LOK poll to be more sensible.
        
        Change-Id: I4323685aa250e9d62a2f448cef358a7aa8ae862c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117899
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [2a323bbbfa8c64bd6f8c30922f11e16a4d85756c]

        ofz#41510 make sure BackgroundColoredObjects doesn't contain dead objects
        
        Change-Id: I42a96a998736b9921c6416eb76b39029279c8bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126107
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [d02a6e62a934887fdc325c3bc02a8a0072db011a]

        color column missing in chart color options treeview
        
        since...
        
        commit c1eb680261107877bf2cea9339e89e23a0a29371
        Date:   Thu Jul 30 21:53:18 2020 -0300
        
            tdf#118148 All extended tips for shared/optionen
        
        Change-Id: I20d1c97a76eda924de95c3aa66e5027dfc1d02d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126125
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [9ec87a52bd4c72ff9d0048bb9ba3e79d45e87162]

        gtk[3|4] calculate row height closer to what gtk appears to do
        
        we're getting slightly more lines than requested visible in f.e. the
        calc autofilter drop down
        
        Change-Id: I9ca16eb5ec6848499997a6fceec1d0ead693efce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [327f2c85beb2c90d2ccdedbffe57c0831ebf16d6]

        tdf#145952 don't crash with LO_COLLECT_UIINFO set in autofilter
        
        Change-Id: I27c474c522554c825c0296cdf711d481d22fd024
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Miklos Vajna  <vmiklos@collabora.com>  [3625dd33be6cc23b663c50f0c1794ceb1e14b921]

        sfx2: OSL_FAIL -> SAL_WARN in viewfrm2
        
        Change-Id: I1411073d80f3753b06a02c618ad09bb7acacb9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126124
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [b612951a0c9554ab92dd7a32fa73af3d67bac209]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b838d04091f125a13302519807040ce43652d5ba
          - Document new SF_Calc methods
            
            This patch documents the following new methods:
            - OpenRangeSelector, Printf, ShiftDown, ShiftLeft, ShiftRight, ShiftUp
            
            The following new properties were added:
            - FirstCell, FirstColumn, FirstRow
            
            Change-Id: I9803252ec0594bd202fc689dd16ca57541e94e62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125890
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [c12da12f37bd3a386ad75d7ae34e7a8aa5923082]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 51f94e35a9b401f2cbc59e57221ce1a4f2edc639
          - Document ExportAsPDF method from SF Document service
            
            Change-Id: I00421d36f7315ec7ec62eac39c44ea4433078685
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126091
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [0cda0b47b171671b2d4d081c02e039dfda89839b]

        tdf#144308: sc_uicalc: Add unittest
        
        Change-Id: Ia37d19722fc7a4ef46cf6f17fa0e45a12db0e7b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126111
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [40d2324081941fb5d093ea72d5c459cacc7028bc]

        gtk[3|4] allow anything that would enable positioning onscreen
        
        Change-Id: I68a96c4ae860c705108f4aaaf23e4bd05badf849
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126122
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [75517c177755268a9f3894c371cf81bf0bd0ebf2]

        make autofilter a row shorter, now it has extra menu items
        
        for the filter by color options, which have pushed its height up taller
        than it used to be.  I think it would be better to make more submenus
        here to shrink its height down further, but that's not attempted here.
        
        Change-Id: Idb484bd77d2cca6e175d997955b0967720d94ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126121
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [9944abbba3d70874d4a8051ac99566510f3facaf]

        tdf#145901 constrain gtk autofilter within calc window
        
        so its all visible as much as possible under wayland
        
        Change-Id: Iad82f9ab63d57a93361e773a159c2716e13d59f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Stephan Bergmann  <sbergman@redhat.com>  [33a7e65502857687e778444c9b55500b40b4df19]

        Improve an snprintf printing css::util::DateTime members
        
        ...to avoid GCC 12 trunk
        
        > extensions/source/logging/csvformatter.cxx: In member function ‘virtual rtl::OUString logging::{anonymous}::CsvFormatter::format(const com::sun::star::logging::LogRecord&)’:
        > extensions/source/logging/csvformatter.cxx:241:70: error: ‘%02i’ directive output may be truncated writing between 2 and 5 bytes into a region of size between 0 and 14 [-Werror=format-truncation=]
        >   241 |             snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i",
        >       |                                                                      ^~~~
        > extensions/source/logging/csvformatter.cxx:241:44: note: directive argument in the range [0, 65535]
        >   241 |             snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i",
        >       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > extensions/source/logging/csvformatter.cxx:241:44: note: using the range [-2147483648, 2147483647] for directive argument
        > extensions/source/logging/csvformatter.cxx:241:21: note: ‘snprintf’ output between 30 and 49 bytes into a destination of size 31
        >   241 |             snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i",
        >       |             ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   242 |                 static_cast<int>(record.LogTime.Year),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   243 |                 static_cast<int>(record.LogTime.Month),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   244 |                 static_cast<int>(record.LogTime.Day),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   245 |                 static_cast<int>(record.LogTime.Hours),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   246 |                 static_cast<int>(record.LogTime.Minutes),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   247 |                 static_cast<int>(record.LogTime.Seconds),
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >   248 |                 static_cast<int>(record.LogTime.NanoSeconds) );
        >       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I426fd6c54b69c7dcc2153167961295c3bc5cf91f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126116
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-30  Stephan Bergmann  <sbergman@redhat.com>  [9a681101543f9c60112dfc0d04309be7dc50b61d]

        Silence loplugin:badstatics
        
        > /Users/stephan/lo/core/vcl/osx/a11yfocustracker.cxx:40:33: error: bad static variable causes crash on shutdown [loplugin:badstatics]
        >     static AquaA11yFocusTracker SINGLETON;
        >     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
        > /Users/stephan/lo/core/vcl/inc/osx/a11yfocustracker.hxx:85:35: note: ... due to this member of 'AquaA11yFocusTracker' [loplugin:badstatics]
        >     std::set<VclPtr<vcl::Window>> m_aDocumentWindowList;
        >     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I7fd0b1808e5433bab6e1436c345044a5ce804f4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126115
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-30  Luboš Luňák  <l.lunak@centrum.cz>  [da2d40bb2b0b81cb891e2a334d672bb2790a7c23]

        use -fno-pch-timestamp also with clang-cl
        
        Change-Id: Ib985a22040a3cebea5ccb303576065a48f73d3ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126112
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [afdfc9bb5d56fde866882e7d87869ecafed1e3d0]

        handle Skia not drawing GPU-backend shader to a bitmap (tdf#145797)
        
        https: //bugs.chromium.org/p/skia/issues/detail?id=12685
        Change-Id: I4de51b154e270df470102c357c25bdfa430a4488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126118
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [c30bad79fad6b7d046b71fc35bc9ecc03b590bce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 053d65c6f001c97da41cc8fc43f9e55915c9c3ca
          - Document new methods in SFL10N and SF_Dialog
            
            Change-Id: I02fa64860982969b5d7580d11781906ec354502d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125829
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-11-30  Miklos Vajna  <vmiklos@collabora.com>  [09732cec4cf09b215784d140c37d3cfbc5b5b1ff]

        sw, viewing OLE objects: provide an 'Open' context menu
        
        The menu items of the OLE object were disabled in protected mode. Allow
        the menu items in protected mode, now that commit
        32842d4bf250bcab281eb71a218d618485c60290 (sw, viewing OLE objects: also
        protect "common" embeded objects, 2021-11-26) made sure that launching
        an OLE object in protected mode is only viewing, not editing.
        
        Note that the actual menu items are returned by IOleObject::EnumVerbs()
        as documented at
        <https://docs.microsoft.com/en-us/windows/win32/api/oleidl/nf-oleidl-ioleobject-enumverbs>,
        i.e. application-specific. MS Paint provides Edit=0, Open=1, so would be
        nice to filter out 0 to only show Open. But then e.g. PowerPoint
        provides Show=0 and Open/Edit is provided as 1/2. So don't filter out
        anything to be on the safe side when the editing application would only
        provide a single verb.
        
        Change-Id: Ic452cec40d2dd978edfb661f049d7f55dbd2fb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126108
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-30  Stephan Bergmann  <sbergman@redhat.com>  [4ed5fc68374a1ca0901c6fc4acc366b198918608]

        loplugin:stringview
        
        Change-Id: I941fc246211968f14654a9ee3540d2ed9bf13221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126113
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6da12ca82d7bdcbe6f83e9cc46fdb560f729bd63]

        loplugin:stringliteraldefine in various
        
        Change-Id: Ib482e3982128dc47d88a79478d80eef43745d1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Stephan Bergmann  <sbergman@redhat.com>  [81b3619fb59b617cda7335b5d6de32c5abf4e554]

        loplugin:simplifyconstruct
        
        Change-Id: I280b668e40d800ecd6eb03ddcda3c2ebd2dd0254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126114
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-30  Noel Grandin  <noelgrandin@gmail.com>  [75a1a63108d39eab905058d1bd295b74ecf34663]

        use more OInterfaceContainerHelper3 in PropertyListeners
        
        Change-Id: I44b06c1ab469e99a9d3b8f4e2b0f3058959fc202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [53486d831784285b42860882a6b270eb847ff7aa]

        use DrawGradient() instead of doing it manually (tdf#145796)
        
        Change-Id: Ib771eb2ae35f68c81ef1fdcb1e4e3bf5d24a0dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126109
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [a5808c6446f6de536c44cf5bfba6566ad398fb8c]

        tdf#132145: Synchronize SmMathConfig with configuration
        
        Change-Id: I690aa2f47afcd45eda3fb74ecead970b9e1513c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126095
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-30  Hossein  <hossein@libreoffice.org>  [20d5e320801606856c1d05c4f34d9fa82371aac8]

        tdf#145873 Fix FILEOPEN: EMF file not displayed #2
        
        The previous patch 149bd802623d6d83ec9aa04514b938494f7f01f6 only
        partially fixed the problem, and the size of the graphical objects
        was wrongly calculated. This patch fixes this problem.
        
        The fix can be tested with:
        
            make CPPUNIT_TEST_NAME="testTdf145873" -sr \
                 CppunitTest_vcl_pdfexport
        
        This test exports the PPTX to PDF and checks the size of the objects.
        The previous test for this issue which exported to SVG is removed, as
        it could not test the current situation.
        
        Change-Id: I97bed99811eaf8236ded84ffe0c1a7d3d1b5bad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125924
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [cab4a0166a81749ba025be6e1ab39203bdee1e10]

        workaround gcc bug #55776 about enum class shadowing a global
        
        GCC warns that 'enum class XorMode { None }' shadows 'constexpr int
        None = 0' for a workaround for X11 headers, even though there's
        no case for confusion here. So instead of a workaround for X11
        headers work this around by placing the enum first, and then GCC
        does not complain.
        
        Change-Id: I3e7cfaced957d47dee8cc4f10ee74e8dd97a5cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126083
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [64ed0dcf6dbd9567ec33cd07ca8a15c63e86b9df]

        use more XPopupMenu methods over PopupMenu ones
        
        Change-Id: Ib60ae5db7097cd92cc7971fd8227b8753391da26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126073
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Luboš Luňák  <l.lunak@collabora.com>  [93b04984518dbfed9e39d093b844113e81fda735]

        remove unnecessary virtual inheritance
        
        SvLockBytes is only inherited by UcbLockBytes, and that one is not
        inherited by anything, so there's no diamond inheritance, so there's
        no point. Probably a case of somebody not really understanding
        virtual inheritance and using it "just in case".
        
        Change-Id: I2c01f29634c4f1ff2b55d7552fc571b653878ace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126074
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Luboš Luňák  <l.lunak@centrum.cz>  [8883fd63e2b5a4bd5d3c8a364c0fa725db5920cb]

        remove duplicated VCL_DLLPUBLIC
        
        The class itself is already VCL_DLLPUBLIC.
        
        Change-Id: Ic1c352ebce8fbee4602ddc84b2db22eb0038b5e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126075
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Luboš Luňák  <l.lunak@centrum.cz>  [c73aa8bd54ca5d1aba5fa0c1e15837b77c673861]

        try to find clang-cl also in C:/Program Files/LLVM
        
        That's where the LLVM installer puts it by default.
        
        Change-Id: Ia20979a4ae97eca8686b7a82a372264750066f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126081
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-30  Jim Raykowski  <raykowj@gmail.com>  [cb14adfd8cd593da4c429fcefba48531c10e47ac]

        SwNavigator: keep entries selected on right-click
        
        when click position is on a selected entry unless root is in the
        selections then select root entry only
        
        Fixes regression from commit c4016f246fde835c0cfdabbb7cc35bc6dd48fb24
        
        Applies to root content navigation view for content types where multi-
        selection is possible.
        
        Change-Id: I3eb3b3f1eaaee39543700b8b7e3087d2795b3cdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126017
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-30  László Németh  <nemeth@numbertext.org>  [47e65fc0baf8f671733fbf9b5ce8d735328cfb44]

        tdf#30709 sw Style Inspector: show section and parent metadata
        
        Show text:section RDF metadata under the node "Sections"
        in the Style Inspector. Also show parent metadata of nested
        annotated text ranges (and sections) at the cursor
        position, not only metadata of the innermost.
        
        Show metadata fields (text:meta-field) and annotated text
        ranges (text:meta) under the new category "Fields" instead
        of at "Character Direct Formatting".
        
        Put section and other metadata in front of the other style
        settings text. Hide their empty categories "Sections",
        "Bookmarks" and "Fields", if there is no associated RDF
        metadata.
        
        Follow-up of commit db7ef0a9ed21b0271345249b97a7a10d60d259e6
        "tdf#30709 sw Style Inspector: show bookmark data".
        
        Change-Id: Ibfd2c5dfb1597afaa8038b497977505914bed76d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126065
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-30  Noel Grandin  <noelgrandin@gmail.com>  [b6f35f5db701fbd31852fad937a38f81c5c817f0]

        use more OInterfaceContainerHelper2 in ucb
        
        Change-Id: I81300a707c81a011f29bd6b63794e1abd472a015
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126062
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Gabor Kelemen  <kelemeng@ubuntu.com>  [cda9a5af36977420bae34737cd7b52cddb3226ef]

        tdf#145819 Revert logic of the image-with-rotation dialog
        
        Change-Id: Ibca1092699e3a7edd37161f421f3d369a4eb49a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126070
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-30  Noel Grandin  <noelgrandin@gmail.com>  [557beef6a958f9fa67123ad5a8a232b467039030]

        use more OInterfaceContainerHelper3 in xmlhelp
        
        Change-Id: I6271459b655d09cff595e7e6eb604d5e16a8ccc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126064
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [a12b14c1806609fbf31ec9ff37c794e7acb5fe99]

        drop unneeded include
        
        Change-Id: Iea28a59086d23c4edd91d0c531bf3a1337b5da78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126071
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [1fbbfc24199f8d46e7b28b77cb9deb003708512c]

        remove out of date comments
        
        Change-Id: If1fb6c86b04d559eabb5b35fa35f09408a90522f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126069
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Caolán McNamara  <caolanm@redhat.com>  [3bd7c79abe83efa66c4dd70834b6a3b3e9eb6b0a]

        drop unneeded include
        
        Change-Id: I3eba0020edefcc92bc612eea1f388f17b9a45022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a945e22ee5d51faf3e0ff1acabe79ad615e76bc]

        disable test under gcc 11.2.0
        
        Change-Id: Ic0d19cf827bc04026b5adf88bd5eb0a84e9dc270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Miklos Vajna  <vmiklos@collabora.com>  [48f0c5f73f99c919ec24deadc96c3cf5483c9314]

        svx: update objects of pages of a master page when the theme changes
        
        Only text color as a start, and without effects.
        
        Change-Id: I52b1c110870605134c414bcc94b50871cd49975b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126082
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [5bba732060a947541f07fc9c87df8ac7a1f8c4f7]

        loplugin:stringliteraldefine in unotools
        
        Change-Id: If89dd3f6a81cac216fe2fafddf515ab4f3735726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-30  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e983cb3508e3735b28a5985e62b97e3bdc64fa88]

        Document SAL_NO_MOUSEGRABS
        
        Change-Id: I8c94f358111be231ae96a81da264a999c18a0a3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126079
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-30  Miklos Vajna  <vmiklos@collabora.com>  [3944dba0700bfbd2eb6184c279fbeef73891c675]

        vcl: document ToolBox
        
        ToolBox is what other toolkits call a toolbar, it seems to me.
        
        Change-Id: I8230570c4275625d1515ec6bbde1121d40c5d33f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126066
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e79b8c933516daed62382d0d60c34653ebedc4d]

        fix mysqlc test after Sequence::operator[] change
        
        Change-Id: I247aeceaa4100295beec8107385d2ae28765dde8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126054
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-30  Mike Kaganski  <mike.kaganski@collabora.com>  [28eef82cb16faef0b8ddc9912560efb779baa9f9]

        tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListener
        
        It abused XEventListener, and created a DocumentEvent object from
        the incomplete data passed to notifyEvent in EventObject. That way,
        the data initially created for the document event (in Supplement)
        was lost on the way.
        
        Change-Id: I409611482ce2323a3192c68f3525f450a9395815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126090
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-29  Luboš Luňák  <l.lunak@centrum.cz>  [e9332dcdc8f2ea268d1b17c73d43a8834cf75365]

        explicitly check also for -fno-pch-codegen
        
        The catch is that clang-cl does not know it, it only understands
        -Xclang -fpch-codegen. On Linux -fno-pch-codegen is handled by
        the driver, but clang-cl doesn't know the options, so we pass
        to the backend using -Xclang, but that one understands only
        -fpch-codegen. So if not found, do not use that option, the cost
        is only that compiling precompiled_skia.cxx will take longer.
        
        Change-Id: Ie307f96b381b732517a5ab574c742a2ee0bfb687
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126067
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Mike Kaganski  <mike.kaganski@collabora.com>  [84783cc90b504b114f9adc94955253a5cf382abb]

        A small simplification
        
        Change-Id: I222cb2cfcbd9d82c78fc17936f35ced0b21691b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126089
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-29  Luboš Luňák  <l.lunak@collabora.com>  [f7a628f8efe037c1fd7e594eb4b8fc6a44573384]

        implement xor drawing directly using Skia (tdf#141090)
        
        Up until now this has been implemented like in almost all other VCL
        backends by manually xor-ing pixel values. But that required fetching
        pixel values from the GPU in Vulkan mode, which is relatively slow.
        Since some time Skia now has supported writing custom blending modes
        using the SkBlender class, so it's now possible to drop the hack
        and support xor drawing directly using a blender that does
        the operation. This should be both faster and simpler.
        
        Change-Id: Id751d0ed4034852ce68697ecf56cc6dfac95307f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126051
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Luboš Luňák  <l.lunak@collabora.com>  [4a11c85baeb4998e12bc2ab45b0c23d7203bd5b0]

        remove Skia kDifference workaround
        
        I thought it was a driver problem, but now I'm actually not sure,
        as I cannot reproduce it anymore and I don't know if it was a driver
        update or Skia update. Either way, this works now.
        
        Also switch to kExclusion, because the end result is the same,
        but this formula is simpler (to understand primarily, the performance
        is going to be probably the same).
        
        Change-Id: I6ced098ca4a3361cf98d3f9b32968c128eb9f299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126050
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Mike Kaganski  <mike.kaganski@collabora.com>  [7a2616501bba1225df3f6bc0225c3d5a7a692002]

        tdf#144308: don't cache DoAutoComplete/AutoInput in ScInputHandler
        
        The setting from /org.openoffice.Office.Calc/Input is already cached
        in ScModule::m_pAppCfg; synchronizing the two mentioned places was
        done in commit 8810812e58f1b014d3156235c1ab5a2d6c73c828.
        Another existing cache in ScInputHandler only complicates things,
        making the behavior inconsistent when configuring through registry,
        com.sun.star.sheet.GlobalSheetSettings, and menu.
        
        So just read the setting when needed from ScModule in methods of
        ScInputHandler.
        
        For lok, use ScModelObj::initializeForTiledRendering to set it up
        (as was done in 65990058f041c3f1d280a69d411eb4ceacf5a721).
        
        Change-Id: I102d3360aeb45b301f04f4c8bbee1191c23fe0e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126002
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-29  Andras Timar  <andras.timar@collabora.com>  [c395be2cce7030506b0913a139a4e9a5677f5753]

        typo fixes in license text
        
        Change-Id: I27e1baa2fd5d19546afc7bce30758b3442bd8ed3

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [0c756e86e3a9b2a249d20e1dc6b96b5bbe39b7ab]

        close menu a followed by open menu b should not cancel open menu b
        
        Change-Id: I9c708811d9eea04a2421c97a97d7dce14fdc8e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126058
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [f08ef920b744b5eb41ac96ab3dc58a23c27e3ab9]

        center vertically so if there is only one entry it doesn't looks
        
        Change-Id: I97ae6145d0139bd33f33d298803c7e787fd717a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126061
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [88b69059c34a6ff85f1e61d9bc8906bfd8e432aa]

        use more XPopupMenu methods over PopupMenu ones
        
        Change-Id: I54acdcb82b90d363e48543de99c75adea8fceb2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126047
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [67df0664609336faf205f80fdb5115d9edb985c3]

        nothing consumes this value set with SetUserValue
        
        the GetUserValue was removed in...
        
        commit b90296a32bc97bd5038ee2dd262c1d1ee63f3c96
        Date:   Mon Jun 19 10:42:18 2006 +0000
        
            INTEGRATION: CWS warnings01 (1.13.32); FILE MERGED
            2006/05/29 07:55:08 sb 1.13.32.5: #i53898# Made code warning-free and/or compile at all after resync to SRC680m170.
            2006/05/23 16:14:01 sb 1.13.32.4: RESYNC: (1.14-1.15); FILE MERGED
            2006/01/25 17:36:29 sb 1.13.32.3: RESYNC: (1.13-1.14); FILE MERGED
            2005/11/16 15:20:46 pl 1.13.32.2: #i55991# removed warnings
            2005/10/28 14:48:46 cd 1.13.32.1: #i55991# Warning free code changes for gcc
        
        Change-Id: If2519a7826ab5fa9dd605218a51b2f7622231d1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126046
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [99eb1ede7d68091cc35ad2473d7d3f9893833448]

        use css::awt::XPopupMenu::setItemImage instead of PopupMenu::SetItemImage
        
        Change-Id: I414a98a2d8a9e9a2995811e95b2db1f66ac87d5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126043
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [484fe977fd5d0aea1ba5a99e69e6225e2629502c]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface
        to support set/get commands/help URL
        
        Change-Id: I0cf0beaa300331c2d221a60b91a855b1bd47c7c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126041
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [f416f480ebe13e33021c75bf13002e447d8dbde1]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface
        to support set/get commands/help URL
        
        Change-Id: I4e78ad66771562ab80b8aad91347c1b99dccb1a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126040
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [b7d12aab92b919e3b8a68be2ce2c7599f1d9dc7f]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface
        to support set/get commands/help URL
        
        Change-Id: I3ec9126aa601a30bf6376a18659c81198b78c4d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [d521438710cf977b21dcec71d78bbfac966a1061]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface
        to support set/get commands/help URL
        
        Change-Id: I527d2ad2a12f7933d5e2cd892b26e96e284a0631
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126038
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Luboš Luňák  <l.lunak@centrum.cz>  [b2c5944d38f107d77d647bca114fae4e940edcbf]

        fix shared PCH with clang-cl
        
        clang-cl does not understand -include CLI option. It also warns
        about #define's differing in the shared PCH that do not matter,
        so disable that.
        
        Change-Id: I9f6d7a8a28a8d290a8bf783f68c629c06cefbf41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126053
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Luboš Luňák  <l.lunak@centrum.cz>  [973cf26280f80177f5e78d828ddf0cf69ce6a3a1]

        clang-cl: do not complain about precompiled_xxx.hxx include
        
        It was complaining about the header being found using non-standard
        Microsoft seach rules.
        
        Change-Id: I1872515b638f4181b32126c8a932105fdcbdb9f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126023
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [a5792c32f342b3d5087c62c7a65deed4c1d1dc1c]

        use css::awt::XPopupMenu api instead of PopupMenu
        
        Change-Id: Iedd1e2a7db826bdf876f4b6ed0535882b9460c12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126037
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [50dc11ef9b0d5e3e2e08ecc1a2267c79f6ef8fb2]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface
        to support set/get commands/help URL
        
        Change-Id: I11fde1ec8928e7a331200be9182e465798a75965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126036
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [cca776d83a8e32c3501e6c00cf6f4e1fa73401b5]

        use VCLXPopupMenu directly, don't extract underlying PopupMenu*
        
        Change-Id: I7fb25ca34e6439020b00d0266453668df38efe6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126035
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [7e40111f3c5258cbe884c19bcb6617ad342aa5f3]

        pAry is always FontList::GetStdSizeAry()
        
        so the other branch is bogus, this is (more obvious) since...
        
        commit f5a81a119cb63152c2c2e2473a1ea183a30c8db9
        Date:   Tue Sep 21 07:19:15 2021 +1000
        
            vcl: remove OutputDevice's GetDevFontSizeCount() and GetDevFontSize()
        
        Change-Id: I587f4b0ee33129b611ff00265a835071a8332b8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126034
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [20685a37e53bbe82bf4d3d6b0b7d94b104dfdfb9]

        m_pHeightArray can be a std::vector
        
        Change-Id: I406aadb0a907fc2ac554c88ce8dc60c4d444a1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126033
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [68f8aff762b36816a5d2ef1a692fd5b58983c592]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL
        
        Change-Id: Icef85cc5583f2c2677dd8b7ad8dc095f5d604272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [5a12283fb04b17c4df6d1929da2b29b90df1adec]

        use VCLXPopupMenu directly, don't extract underlying PopupMenu*
        
        Change-Id: If26c7e61e4c7203d2d4266f49149ebaf053dfdf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126030
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a2352ca8abbdcd6a6376144e6dd185ffeaef5d0]

        loplugin:stringliteraldefine in i18nlangtag
        
        Change-Id: Ibc4758235ad15858d288e6f3015e2dfcb1650a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126042
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [cdbfb27c5e96c08deb8757f33ac2885b24be303f]

        use css::awt::XPopupMenu api, don't need to tunnel to get VCLXPopupMenu*
        
        Change-Id: I6b6b09ded063a5c1f2e561fffcb8fb2214d35a56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126028
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [896c2d247d43135c12f5bb0d3921ae741f1c5960]

        can use css::awt::XPopupMenu::setCommand
        
        instead of PopupMenu::SetItemCommand since...
        
        commit 9aa4101c53e483be1d25c1e5aaad2cf542540a56
        Date:   Wed Feb 25 16:57:46 2004 +0000
        
            INTEGRATION: CWS layoutmanager (1.3.146); FILE MERGED
            2004/01/19 10:03:03 cd 1.3.146.2: #111899# Added new interface to support set/get commands/help URL
        
        Change-Id: I2bf9aa64b8c1dcd3bc7356adbfaf5592910eb851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126029
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [3e8bfde1e1dd859d4c09337605f92db24a142e44]

        move PopupMenu::IsInExecute out of vcl/include/menu.hxx
        
        Change-Id: I01af38dd57a645ea0afeaff033ce6d07dfe09535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126026
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Julien Nabet  <serval2412@yahoo.fr>  [774c6a6e1603bf3f12f1573b0778e0f0f9783169]

        tdf#117280: fix multiple Macro execution when triggered by Document print event
        
        Change-Id: Ibfebcc1a31464b2610afea2035e3d723a0c79167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126018
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [015512c0d85fb38c2c3482f0fb9890cc52bfb58a]

        use VCLXPopupMenu directly, don't extract underlying PopupMenu*
        
        Change-Id: Ide78849af0731c68bfff1a8faba3d81100644eb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [14d380f64a0e61ff46203752b6d4208b125db811]

        ofz#41460 ubsan Bad-cast
        
        Change-Id: I0352bce1c699bfa6b7fdd5c3f04e46cc7599ce91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [a4691c7d5eb494c242305936428086940f90d83a]

        these are pdf export tests, move them to vcl_pdfexport
        
        Change-Id: Ic9412e86f9256f8e2ca6823d8b5b8757c4273025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126025
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-29  Michael Stahl  <michael.stahl@allotropia.de>  [2fae5ab2a8cefa758c631d6ae23847089b68800d]

        ucb: webdav-curl: don't read from XInputStream during upload
        
        Nextcloud will reply to a PROPFIND request with "100 Continue" and then
        after the data is uploaded it will send a "401 Unauthorized" if the
        auth header is missing in the headers to which it replied with "100
        Continue".
        
        In the next call to ProcessRequestImpl(), reading from the stream
        returns no data because it's at EOF, and because of the Content-Length
        header the server will hang forever waiting for data.
        
        So copy the stream to a temporary buffer and use that for multiple
        calls to ProcessRequestImpl().
        
        Change-Id: If5943a32c4cf50259fe1f84013141765cb5bd891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125923
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ac52c6b58d30e0124b27a5b928261db5a4592c28]

        loplugin:stringliteraldefine in hwpfilter
        
        Change-Id: Ibdd479533a8dc17df4fa2116299d81468f641a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-29  Luboš Luňák  <l.lunak@centrum.cz>  [c00b2c43c8f10755b1e7bfb32766e384d8964b3d]

        clang-cl says it doesn't know -Zc:inline
        
        Change-Id: I2ace3011a533978d995898ed2dd588c728bac233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126022
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Luboš Luňák  <l.lunak@collabora.com>  [d4f1531b6d37153384e5a439dab6ab11ae3022ef]

        store ScQueryEntry simply by value
        
        There's not much point in complicating this by allocating them
        dynamically if they're always treated by value anyway.
        
        Change-Id: I8325829201c0ad6c95858916a94c5b4d1d208b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126024
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d7f9079c2877cd712132e71f80e49fd08f6e73d1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5735b8715ec8e86033fa9bf826829235bd69018
          - tdf#125636 (part) Include Help for "Start Certificate Manager"
            
            + some refactor
            
            Change-Id: I7d15ece2c87ab32568f9d40a7dfff8349d45a31e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125969
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-11-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [42c6e2eb529ec7ca66684bbf4603bace95d33556]

        docx export: preserve spaces in field instructions
        
        MS Word is putting spaces between field mark and field instruction
        text. Writer preserves these spaces, but without xml:space="preserve"
        they are not displayed by Word later.
        
        Change-Id: I480e6febf0ee278b56e9dfc6e0430c5fd5bdfd71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125875
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-11-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d16a2c3aed633bf594675e116327e09fe4d898d]

        loplugin:stringliteraldefine in ucb
        
        Change-Id: I3b2e01b482f7f4dbceea090b9586cdb4eee4e703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125869
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [5f3af56b2c0ef6c628a7cfe5ce6e86f8e1765f5f]

        sw: refactoring for docx sdt blocks output
        
        Previous approach with almost duplicate storage and processing
        for paragraph-level and run-level sdt blocks was very bulky.
        Especially this became visible once supported std elements list
        start to grow.
        
        Paragraph-level sdt block and run-level sdt block data are almost
        identical, so they can be kept in one standard class
        (SdtBlockHelper) and use the same methods for collecting data
        from grabbags and writing to output without passing huge amount
        of parameters.
        
        Change-Id: I4e1183eddf20317e954cb8aca72e97a4fc45ac68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125372
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-11-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [7db38a496a5e458ec12888ddbf63c603706ae3fc]

        tdf#137466: docx: support w:placeholder & w15:color in w:sdtPr
        
        Content controls in Word can contain some other elements which
        are not supported by Writer. Put them into grabbag and write
        back to DOCX on save to avoid losing quite sensitive data.
        
        Test testSimpleSdts is modified: testcase is actully containing
        4 sdt elements with ids in input and output.
        
        Change-Id: I1f9addd03ed828bf375ccac5188a004f011e8a0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125271
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-11-29  Tünde Tóth  <toth.tunde@nisz.hu>  [7b8ae6f90c37c18ff724c0751b5f73cca6ae02ac]

        tdf#97899 DOCX import: allow character formatting only of numbering
        
        After the DOCX round-trip of a numbering created in Writer
        using direct formatting (e.g. using Toggle Ordered/Unordered
        List icons), it was not possible to format only the numbering
        or bullets, e.g. selecting and formatting them by positioning
        the text cursor on the numbering. Set CharStyleName property
        during the DOCX import to allow this formatting.
        
        Note: default list styles of Writer is still not supported,
        resulting missing numbering after DOCX import.
        
        Change-Id: I6f2c5d6e0d63b15e9c28367181af1e9e083ae68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125649
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-29  Miklos Vajna  <vmiklos@collabora.com>  [26bd14e43d7d5e81c97085f12abf1523d03bdf9a]

        sw: prefix members of FieldDocWatchingStack, NaviContentBookmark, ...
        
        ... SwTransferDdeLink and sw::sidebarwindows::SidebarWinAccessible
        
        See tdf#94879 for motivation.
        
        Change-Id: I4aba516260ad1f55081c91d8812ca9060ad11bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126010
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [aad27c0316b710a1506e068c3f58d44388388ae9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fe3d13ce1750ba2cd5bc64ff76d20a11e93e446e
          - Related: tdf#145728 Update help strings for QR and Barcode dialog
            
            Also, I removed the Wikipedia link. Besides having grammatical problems,
            I don’t think these links are a fit for our documentation.
            We would do a bigger service for our readers having all the needed
            information right into our pages, where we can control it better.
            
            Change-Id: Iaf96727ae5127ad622a2887aeea4c81b262d4ede
            
2021-11-29  Noel Grandin  <noelgrandin@gmail.com>  [6bc5d6cac2fd9e029357c618510a3b5f3aa7c085]

        remove counter-productive catch-all blocks
        
        There is no point in these - the rethrow will crash the process
        anyway, so trying to recover anything is a waste of time.
        
        And they very unhelpfully obscure the stacktrace of the actual
        underlying problem.
        
        Change-Id: I8e4439e5e2c517aa80a1750a05c207d274c73012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125980
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-29  Caolán McNamara  <caolanm@redhat.com>  [53f90ba47376aac928c6666d34ef62473052bf6d]

        gtk3: set anchor_hints for gdk_window_move_to_rect
        
        Change-Id: Id7d79e0b505cfaadf1dbae770b69eea46b43157c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-29  Miklos Vajna  <vmiklos@collabora.com>  [8662293d17a875f4389ea21be00e768e3de3d048]

        tools Color: implement MSO-style luminance modulation/offset filter
        
        To be used when a filtered theme color will be applied on the UI, and
        not at PPTX import time.
        
        Change-Id: Ifb56e38e59b529ef436063c407ee156d76a77f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126011
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-29  Attila Szűcs  <szucs.attila3@nisz.hu>  [41cc1d2c0c0c3bfa5ba341311f68df05375859fb]

        tdf#54465 tdf#139336 sw: add compat. flag for footnote in column
        
        Add compatibility option FOOTNOTE_IN_COLUMN_TO_PAGEEND to keep layout
        of old ODT files, where multicolumn sections have footnotes in columns,
        growing sections to the full page.
        
        Note: Multicolumn page styles or not evenly distributed multicolumn
        sections, or footnotes not collected at the end of the sections still
        use footnotes in columns, so they don't need this compatibility option.
        
        Follow-up to commit 4c31b4ef2083087a822c3ae648fd09acc67d2f88
        "tdf#139336 sw: fix extra pages of multicolumn sections with footnotes".
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I7d6a1f804b555dc5372767014b8fb5e3fa57ba9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125442
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-29  Miklos Vajna  <vmiklos@collabora.com>  [d9105d434ac6127f151843c7a7dbcd16257fcc0b]

        cid#1494452 sfx2: fix null ptr deref in SfxInPlaceClient_Impl::saveObject()
        
        Null-checking "this->m_pClient" suggests that it may be null, but it has
        already been dereferenced on all paths leading to the check. Add the
        missing check at a previous usage.
        
        Change-Id: I8ebb4f41b9c83d59e65563c26729e899d45881b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126013
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-29  Winfried Donkers  <winfrieddonkers@libreoffice.org>  [105196aa00bc0d3e426796f6729a8e7e51271e56]

        tdf#145578, tdf#145587 revise calculations for WEEKS Add-In function
        
        The calculations now follow the documentation for WEEKS in
        https://wiki.documentfoundation.org/Documentation/Calc_Functions/WEEKS.
        
        Change-Id: Ifede6e2ec2d9cfb7301fd5eb53bf7b6f187053bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125319
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [5db7694a6377d32bdef293b4ece27b471c3ea427]

        tdf#118045 PPTX export: fix proportional line spacing
        
        If line spacing differs from the default 100%, export it
        as direct paragraph formatting (similar to the
        other paragraph style properties).
        
        Change-Id: Id5db9ae36018c8a20b832470685bdfbba19d80f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125438
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-29  Noel Grandin  <noelgrandin@gmail.com>  [17aa192818caeb9af1381051a2dfda9568f7ce07]

        OInterfaceContainerHelper3 needs to be thread-safe
        
        Change-Id: I11b84917033073d29268e61175faf43cbd5b1168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125986
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-29  Mike Kaganski  <mike.kaganski@collabora.com>  [8810812e58f1b014d3156235c1ab5a2d6c73c828]

        tdf#132145: Synchronize ScAppCfg with configuration
        
        Change-Id: Iadf5ff86d043f63355fd30816a9e2011479465c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125990
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [b2c56ac95b15b675b9fabed889e7f9709bdc793f]

        Refactor ScInputCfg a little
        
        Make ScInputOptions a private ancestor. This allows to drop
        OptionsChanged, and avoid potential way to change settings
        without committing to configuration.
        
        Drop ScInputOptions::SetDefaults, and use ctor for that.
        
        Change-Id: I8abb7309a72e84ac7c83592f3758f0264cd1cc4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125905
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [134cbe4c3b94a5ec46849abd1eef2c3acb5f789e]

        use more OInterfaceContainerHelper3 in SvxShapeCollection
        
        which requires adding a getInterface method to OInterfaceContainerHelper3
        
        Change-Id: I0962aa42c19859d7b78c998b8b4448a7ebfc19e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125981
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [6762aff78bd346ebf816ead77e73b6fa9d8ea7d8]

        use more OInterfaceContainerHelper3 in toolkit
        
        Change-Id: If91b208db7fa59bc626293c0a868ac490a8d2d70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125983
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Ming Hua  <plateauwolf@qq.com>  [cf6823ea07047ad7681262e94721f88e768f5845]

        tdf#145728 Update UI Strings about QR and Barcode
        
        In commit d37a44a9ebdafec1435f98194417a1d8cc8208b5 (tdf#141193 Added
        support for bar codes in qrcode dialog box[API Change], 2021-10-29)
        which added support for one-dimensional "CODE_128" barcode in addition
        to the previously supported 2D QR code, the various labels and tooltips
        in UI were not fully updated accordingly.
        
        This commit should update all QR and barcode related UI strings to match
        the new status, mentioning both "QR and barcode" where emphasis or
        detail is desired, and just "code(s)" where brevity is desired.  Also
        use one-word "barcode" instead of "bar code" everywhere for consistency.
        
        Change-Id: I4530e4ffee5155b12551d7b819031c3869d7ab2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125925
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [aa25ddc572493c85320ddee439013321f67544d0]

        use more OInterfaceContainerHelper3 in sfx2
        
        Change-Id: Ia14f70bf4b09109e987fd7b432dcc1a5a9b10ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [786edb0fd0588147c58b3fbad1d936f0b2a26c6e]

        use more OInterfaceContainerHelper3 in svl
        
        Change-Id: I93443f87fe9b68157cc9a126f2c31f917a016a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125975
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [ba8e7113fa8172533be736a25f936fc52f96e6a4]

        use more OInterfaceContainerHelper3 in slideshow
        
        Change-Id: I8f098b57411758cfbb5d5f41e319cf085a23f66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [8d9c4792129e3dcf263ffffe39324c94b2ffe2bf]

        use more OInterfaceContainerHelper3 in sot
        
        Change-Id: I4d8fbb90a9850199caa29e97f2080fd49c48bcef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [9622b62f1bc181f3841f0e730fb212bfd40758b8]

        use more OInterfaceContainerHelper2 in scripting
        
        and remove unnecessary guards, OInterfaceContainerHelper3 will
        already take the mutex
        
        Change-Id: I951d9e02582768c5da9a7a3cc8412381f9f7e9fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125970
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [d9bda6f84c5f8c0f87545de22014ee64fbdf0c2f]

        use more OInterfaceContainerHelper3 in svx
        
        Change-Id: I409872c4484748d9e4dc1a2c64d3ccabfc3fb550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [4c8aba408c806830fd2f3fba5181469257d264c9]

        use more OInterfaceContainerHelper3 in sd
        
        Change-Id: Id981ff73b5c386652a312de73df1684a273b389c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Stephan Bergmann  <sbergman@redhat.com>  [4fb7967fb2e67717f79eb87519c1444a82350a83]

        Revert "tdf#129183 sw: textboxes in group shapes - part 3"
        
        This reverts commit eabcfb3f18a6944d9ad89cecd3eb3ca7a2259cf3.
        Conflicts:
        	sw/source/core/doc/textboxhelper.cxx
        
        It caused UITest_writer_tests4 to fail in an ASan build with
        > ==2987325==ERROR: AddressSanitizer: heap-use-after-free on address 0x6130000e5048 at pc 0x7f20cb3112ac bp 0x7f1e62de92d0 sp 0x7f1e62de92c8
        > WRITE of size 8 at 0x6130000e5048 thread T47
        >  #0 in SwFrameFormat::SetOtherTextBoxFormat(SwTextBoxNode*) at sw/inc/frmfmt.hxx:106:77
        >  #1 in SwTextBoxNode::~SwTextBoxNode() at sw/source/core/doc/textboxhelper.cxx:1680:30
        >  #2 in SwFrameFormat::~SwFrameFormat() at sw/source/core/layout/atrfrm.cxx:2564:9
        >  #3 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3455:1
        >  #4 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3453:1
        >  #5 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9
        >  #6 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28
        >  #7 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9
        >  #8 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19
        >  #9 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16
        >  #10 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5
        >  #11 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1
        >  #12 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1
        >  #13 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29
        >  #14 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36
        >  #15 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5
        >  #16 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15
        >  #17 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4
        >  #18 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2
        >  #19 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6
        >  #20 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11
        >  #21 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31
        >  #22 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9
        >  #23 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:757:13
        >  #24 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19
        >  #25 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1482:5
        >  #26 in SwXTextDocument::close(unsigned char) at sw/source/uibase/uno/unotxdoc.cxx:562:19
        >  #27 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:718:13
        >  #28 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19
        >  #29 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
        >  #30 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
        >  #31 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
        >  #32 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:235:13
        >  #33 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:78:26
        >  #34 in request at binaryurp/source/reader.cxx:85:9
        >  #35 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100:17
        >  #36 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:164:31
        >  #37 in threadFunc at include/osl/thread.hxx:189:15
        >  #38 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:264:9
        >  #39 in start_thread at <null>
        >  #40 in __GI___clone3 at <null>
        >
        > 0x6130000e5048 is located 328 bytes inside of 376-byte region [0x6130000e4f00,0x6130000e5078)
        > freed by thread T47 here:
        >  #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
        >  #1 in SwFlyFrameFormat::~SwFlyFrameFormat() at sw/source/core/layout/atrfrm.cxx:2912:1
        >  #2 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9
        >  #3 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28
        >  #4 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9
        >  #5 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19
        >  #6 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16
        >  #7 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5
        >  #8 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1
        >  #9 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1
        >  #10 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29
        >  #11 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36
        >  #12 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5
        >  #13 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15
        >  #14 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4
        >  #15 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2
        >  #16 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6
        >  #17 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11
        >  #18 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31
        >  #19 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9
        >
        > previously allocated by thread T10 here:
        >  #0 in operator new(unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3
        >  #1 in SwDoc::MakeFlyFrameFormat(rtl::OUString const&, SwFrameFormat*) at sw/source/core/doc/docfmt.cxx:756:33
        >  #2 in SwDoc::MakeFlySection_(SwPosition const&, SwContentNode const&, RndStdIds, SfxItemSet const*, SwFrameFormat*) at sw/source/core/doc/doclay.cxx:171:33
        >  #3 in SwDoc::MakeFlySection(RndStdIds, SwPosition const*, SfxItemSet const*, SwFrameFormat*, bool) at sw/source/core/doc/doclay.cxx:337:19
        >  #4 in SwXFrame::attachToRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, SwPaM const*) at sw/source/core/unocore/unoframe.cxx:2821:29
        >  #5 in SwXFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3115:9
        >  #6 in SwXTextFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3346:15
        >  #7 in SwXText::insertTextContent(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, unsigned char) at sw/source/core/unocore/unotext.cxx:615:15
        >  #8 in SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx:1472:5
        >  #9 in non-virtual thunk to SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx
        >  #10 in SwTextBoxHelper::create(SwFrameFormat*, SdrObject*, bool) at sw/source/core/doc/textboxhelper.cxx:100:29
        >  #11 in SwXShape::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) at sw/source/core/unocore/unodraw.cxx:1165:25
        >  #12 in SdXMLShapeContext::SetStyle(bool) at xmloff/source/draw/ximpshap.cxx:701:27
        >  #13 in SdXMLCustomShapeContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/draw/ximpshap.cxx:3545:5
        >  #14 in SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/core/xmlimp.cxx:805:15
        >  #15 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) at sax/source/fastparser/fastparser.cxx:468:27
        >  #16 in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:1304:21
        >  #17 in (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:331:18
        >  #18 in xmlParseStartTag2 at workdir/UnpackedTarball/libxml2/parser.c:9658:6
        >  #19 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11453:14
        
        Change-Id: I752190e05fc3c282b75021724527f623f56ee6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125977
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-28  Johnny_M  <klasse@partyheld.de>  [0d678951df5bb5daa2d77600f5f8682a55d6f00e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ae6c12d33c4723126cfca2009fa00382db1ba5c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2a442e77bcdea9f56cee52761ce8a2252015028d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125968
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [6cf761462210bc8cf5ab6205b06286807ea5d4a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f9f53420a043e6e8df1e3d458fb26c1a4dafacb
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie5b4776a3a964d266d9e011bd10a17603880ab0c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125965
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [7bcfa613fc883e65c6a39a4ba223678477d340d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b97a5ec31227cdcba2df0669bf8ac691203cccf
          - tdf#132643 Translate German section IDs
            
            Change-Id: I786b333ea9e3522201ae775b781675e6900d7138
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125961
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [c56a8645f02152f06a7be71a7771f8da76f4fcd8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c1e774335eff3398bff674f08601ed4b5f88eece
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4518fd34162567e1bb429e79e6df91ba7eb29ff3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125967
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [2c4570f832d6a5bd44181802ae1f95a6c6319e81]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9d4d2755356e1fb1dc1d0c39d72417ce9c20f7e5
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia88762ccd31319ed93998a0e84ad21c5cf00d84e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125964
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [5deaa6df361a2b497486e3b8121d6fab8237389f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 399a3e03e37f357dbc2ffc2722391fab8a0435c9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7087a6d908445b886a47251e35f19f22ecdb9a07
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125963
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [96e2c3d5f8a870ee416856334037accfa6effb5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1b88c34dcbd17abf96bbbb8cdb762152ede0f7d1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I65bab929469387fab1c784eae20ae94277372e04
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125962
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [4938ca3ab819a35ea5e2e05530540959c92eda66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a9d5b3e1afa967c7213d20be1db0b5958bf33944
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6c7721b5dc3b4ebcc51a26d97b14c6b16068140d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125959
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Johnny_M  <klasse@partyheld.de>  [ce8ff0dadc1cb8ef34babbb7d46a5ff8383b5ba7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 86eeb36ad85e418352529ce9a83e6bd151a64250
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3e1b9056afaadebce0293597ea5f675448edaf54
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125960
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [d2e28fe1f9e3c7eb5ec3d50880a4421367ef5b92]

        use more OInterfaceContainerHelper3 in dbaccess
        
        Change-Id: I03d75ff508ba8f9904e0ed30cff15e91f82b3300
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125957
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Mike Kaganski  <mike.kaganski@collabora.com>  [6c09362c257b26ebf26fea0168f7db752212da70]

        tdf#132145: Synchronize ScPrintCfg with configuration
        
        Change-Id: I903e8277fea5c223081244ae30dff31bbda7d554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125904
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-28  Noel Grandin  <noelgrandin@gmail.com>  [9f18e327a1a51316ea5bc9f3997d83f657032226]

        use more OInterfaceContainerHelper3 in forms
        
        Change-Id: Ie4a6124beccb55c983b8d4f63c86ec5f2869e9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125956
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-28  Caolán McNamara  <caolanm@redhat.com>  [50cec31d5fa77ebc04f35e57718a02d328562417]

        weld Snap Line context menu
        
        Change-Id: Ic4ea546f66eae7acb0427686be8981e2e8231c77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-28  Caolán McNamara  <caolanm@redhat.com>  [b98ff21fa7132a3eb606a6441f5ebd0162453baa]

        don't need to include vcl/menu.hxx from vcl/menubarupdateicon.hxx
        
        Change-Id: Iefb4e08ebf0c2c15b11cfc1d807ae9dc50326923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-28  Caolán McNamara  <caolanm@redhat.com>  [bc4e3a1ef4df033a7a5e3526de4edf51dacdb839]

        don't need to have a specific mbCanHaveSubMenu mode anymore
        
        since the gap in the vcl treeview separator problem is fixed
        
        Change-Id: I105167127588c11895d81dd2aea3c9e119170069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125952
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-28  Caolán McNamara  <caolanm@redhat.com>  [800cb441d644a1c14b226154680553a6e56f47bc]

        drop unneeded include
        
        Change-Id: I5feae2a17eb1ac647f2be4c6936e3a9b0706a333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-28  Caolán McNamara  <caolanm@redhat.com>  [1a2f6ea66e2ca7aaa1ba4db52961f061f8488bf9]

        gtk[3|4] move the indicator to the edge
        
        Change-Id: I79e4f404f85846ef85886f8bdbe3d4ba3114a091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-27  Caolán McNamara  <caolanm@redhat.com>  [d272bf4f8f3a083b8c37f7b10f89cd2bf76b7d21]

        Resolves: tdf#144410 show submenu indicator for color filtering options
        
        do it as an easily backportable change
        
        Change-Id: Ib92e8f1e35e6465b52a69f3a8513068668dc6953
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-27  Caolán McNamara  <caolanm@redhat.com>  [d0a99c25a2e3ff1bc355444a8877166b82d85366]

        Resolves: tdf#145863 crash on click after quick double click
        
        Change-Id: I18862328a3239424de80b478a09f568b5dcef1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-27  Caolán McNamara  <caolanm@redhat.com>  [f28ef77210b1a3cc737689c7a4ae099419cb0493]

        Related: tdf#144410 we don't want a gap in a multicol spanning separator
        
        we would need another column to show a drop down indicator, and we don't
        want the separators to have a visible gap in that case
        
        Change-Id: Ib45b4cda41a09b631f3ea4d4427a8073a9e243d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [d510a9783d59acdc94b06257a0f0b5f03a10dab4]

        use more OInterfaceContainerHelper3 in sc
        
        Change-Id: I27df936f95ac7727b58ad196201df6d56bceeca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125943
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [f5e9012dcf2ad14a82a879beed645f83439d08bf]

        use more OInterfaceContainerHelper3 in SvxUnoTextContent
        
        Change-Id: Ibef254a6391fb93d4ecfa91ef3ef3a31b4e146a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Stephan Bergmann  <sbergman@redhat.com>  [e6376eaa83637f50ec236f239306248b8f92caee]

        Library_msword needs sw::LegacyModifyHint RTTI now in UBSan build
        
        ...since 7d3aadce8d184f72e4785827ad706d27c31a2edb "ofz#41398 drop a para
        scheduled for deletion if something else deletes it", causing e.g.
        CppunitTest_chart2_export to fail with
        
        > [_RUN_____] Chart2ExportTest::testStockChart
        [...]
        > warn:sal.osl:1981149:1981149:sal/osl/unx/module.cxx:155: dlopen(/home/sbergman/lo/core/instdir/program/libmswordlo.so, 257): /home/sbergman/lo/core/instdir/program/libmswordlo.so: undefined symbol: _ZTIN2sw16LegacyModifyHintE
        > warn:sfx.doc:1981149:1981149:sfx2/source/doc/sfxbasemodel.cxx:3147: Storing has failed, no error is set!
        > unknown:0:Chart2ExportTest::testStockChart
        >
        > An uncaught exception of type com.sun.star.io.IOException
        > - SfxBaseModel::impl_store <file:///home/sbergman/lo/tmp/Chart2ExportTest__testStockChart_4rivgy.tmp> failed: 0xc10(Error Area:Io Class:Write Code:16) /home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:3194 /home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:1775
        
        Change-Id: I47ce1c10b7757b27e4279f35d59e34d5312c8b07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125945
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [99d2ee15ad6fae7073a53f7df8868300328a36e7]

        blind fix for UITest_impress_demo failures
        
        Change-Id: Ia26c5a15fa4487c68cf6d4bc2aee41a3ded7f6a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Caolán McNamara  <caolanm@redhat.com>  [1e396675d81b740a6c04afed58eed6468e5c249a]

        set png filter for import dialog in a more robust way
        
        Change-Id: Iec25e214b19e5a2ab8a7305aad307c3f03e67401
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125913
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [aa0a2266f0fd9f53b50944aa183b7e78fe675300]

        fix header include guard
        
        was overlapping with the header it was copied from
        
        Change-Id: I84d15a6ce59949e04de4f738c730642b633135aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125944
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [bec2de27f676092bffdf8a639497602a9d13f675]

        tdf#64991 speed up loading large RTL documents
        
        takes load time from 20s to 17s for me
        
        Several loops are very hot, so store the count()/size() value,
        instead of calling it on every iteration.
        
        
        Change-Id: I8c0b01721d27e4335dd613cf276dcdd0103633ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120945
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [e7f2dcf29ba3d726549c38060723d8ae5f443c88]

        use more OInterfaceContainerHelper3 in reportdesign
        
        Change-Id: I742f8a684bb689af8593c3ad5d8918b30c6a7ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [fdae440a4d877f93bee430a03dd55841ccbe7876]

        use more OInterfaceContainerHelper3 in connectivity::sdbcx::OCollection
        
        Change-Id: Idf3313b374eae05c4a65c101e1e7ce91c743b420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [88ff4e9624940aa596bf415cd443b144332091b3]

        use more OInterfaceContainerHelper3 in linguistic::PropertyChgHelper
        
        Change-Id: I6c1570ffd76b6558baa88bad7822cda8ac89f00d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Jean-Pierre Ledure  <jp@ledure.be>  [ec18e2545c752c2d33e16f23de6b2dfd6a04e0e7]

        ScriptForge - (SF_Calc) fix ShiftXXX() methods with negative offset
        
        Example:
           oCalc.ShiftDown("A10:D15", , -1)
        gives an "Objectvariable not set" Basic runtime error.
        
        Fixed by replacing 4x '= 0' by '<= 0' test in If statements checking
        the argument value.
        
        Change-Id: I272112a1addd303b7b38d3d9eb2ef73034e28727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125939
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [770cb7825b772366ab61d4f6f7a98de30b5cd80a]

        use more OInterfaceContainerHelper3 in lingucomponent
        
        Change-Id: I4ad7c868815d7f6b8982dd192bc74b0b07a438f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125935
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [1fcd79fb083a2db9cb56f09e0c7407f437177b0c]

        use more OInterfaceContainerHelper3 in FmX*Multiplexer
        
        Change-Id: I0e3a081b79dcdc3ffd298a03c31b71052b6a0cb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125932
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [1a122a5bce95bb0e6f5c776abd10c0288b48e126]

        use more OInterfaceContainerHelper3 in package
        
        Change-Id: I4a9f0f4ae95ec236ef32462c1aaa8d774be15378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [d448b16d811593f0c8e8f2e60e957a83390c4b99]

        use more OInterfaceContainerHelper3 in linguistic
        
        Change-Id: I0b6a80bb317035327b98217d7a7cadfec08fe7ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125937
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Stephan Bergmann  <sbergman@redhat.com>  [1298a6ae9ac2e3cbe4f387a70a47c7fcf491a773]

        Fix typo
        
        ...in 2132da5066143d7828984bc1aa42d10223bc5824 "loplugin:stringliteraldefine in
        package", which caused CppunitTest_xmlsecurity_signing to fail with
        
        > [_RUN_____] testODFEncryptedGPG::TestBody
        > librdf error ¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾¾ - XML parser error - Document is empty
        > warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
        >  ~/lo/core/sax/source/fastparser/fastparser.cxx:609
        >     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
        > warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
        >  /home/sbergman/lo/core/sax/source/fastparser/fastparser.cxx:609
        >     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
        > warn:sw:113776:113776:sw/source/filter/xml/swxml.cxx:214: SAX parse exception caught while importing: com.sun.star.xml.sax.SAXParseException message: [ line 1]: Document is empty
        >  /home/sbergman/lo/core/sax/source/fastparser/fastparser.cxx:609
        >     wrapped: void message: /home/sbergman/lo/core/tools/source/debug/debug.cxx:104 PublicId:  SystemId:  LineNumber: 1 ColumnNumber: 1
        > warn:sfx.view:113776:113776:sfx2/source/view/frmload.cxx:489: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.task.ErrorCodeIOException message: SfxBaseModel::handleLoadError: 0x0x11b /home/sbergman/lo/core/sfx2/source/doc/sfxbasemodel.cxx:2787 errcode: 283
        > warn:fwk.loadenv:113776:113776:framework/source/loadenv/loadenv.cxx:202: caught LoadEnvException 6 "interaction request", com.sun.star.task.ErrorCodeRequest "/home/sbergman/lo/core/sfx2/source/doc/objmisc.cxx:1698" while loading <file:///home/sbergman/lo/core//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt>
        > /home/sbergman/lo/core/unotest/source/cpp/macros_test.cxx:67:testODFEncryptedGPG::TestBody
        > assertion failed
        > - Expression: xComponent.is()
        > - loading failed: file:///home/sbergman/lo/core//xmlsecurity/qa/unit/signing/data/encryptedGPG.odt
        
        for me
        
        Change-Id: I0326d5ab33a9cfe9c23aab4120b49f37548aea39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125936
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [60bff7546fb8e35e5b0cebdeb767a41a6398f828]

        loplugin:stringliteraldefine in ucbhelper
        
        Change-Id: I5fb7ffed1e29ff494e09cf048bee9ceb0f8262c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125870
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [218adeb2afb0fb22b7e3ea34ab7b98f7a2f6acce]

        use more OInterfaceContainerHelper3 in UnoControl
        
        Change-Id: I701822285acbd0edb47aaf80c8f26541abfcd53b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125933
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [976847e25c8160dcbfe895cfa7945ac990494e1e]

        use more OInterfaceContainerHelper3 in FmXGridPeer
        
        Change-Id: I6545b2a8ae750b0480da84a09f803be0151f85d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125931
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [481236a6f726cb4c6b2e09cba8182636fa4de4b7]

        use more OInterfaceContainerHelper3 in UnoControlListBoxModel
        
        Change-Id: I102c6fb50506f70911456e8efd36f79969ae631a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125934
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [203ba801eee12f9d6bffb2ae49ad82ba7bf191c1]

        use more OInterfaceContainerHelper3 in dbtools::ParameterManager
        
        Change-Id: Ice607fb67468484e98c94e4f41c3e249639e1edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [27651c72f2beb3574efcf240e8472a6f441476a8]

        use more OInterfaceContainerHelper3 in AnimationNode
        
        Change-Id: I619582287d3ce1712921782d47cc722deeb1e0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125918
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [d7cd65577d9b5209e4bd2334e2d63f12c4831143]

        use more OInterfaceContainerHelper3 in ModifiableHelper
        
        Change-Id: I8d959e365f995d48a6105fac3ed0f84c7cc1d86b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Mike Kaganski  <mike.kaganski@collabora.com>  [2b95775b0dd20e90bb6ec6925a6745b27cf032e6]

        tdf#132145: Synchronize ScInputCfg with configuration
        
        Change-Id: I45cc9b6c8cbd9205e185bebff97644f53f5cf0af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125896
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [87a399a74cba1f4111fa326a1c8769d0ea9f8954]

        use more OInterfaceContainerHelper3 in UndoManagerHelper_Impl
        
        Change-Id: I9076f35366de690cca84361695d45ad3ffc31089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125917
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [14d2b32a462be277038f6a3dbb056d267c3413a3]

        use more OInterfaceContainerHelper3 in ImplEventAttacherManager
        
        Change-Id: I5c73d61a5b7a0a7fcc218e0ee839be5b9fdbb987
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [7d30094766d6ef0f1084c42993dd2eb6b413cac7]

        use more OInterfaceContainerHelper3 in OPropertyBag
        
        Change-Id: I915614c8e70a0f179655530b2c8822fa06c21386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125915
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [2958109df0d2901b59748c3028e5df7a2c5b2481]

        use more OInterfaceContainerHelper3 in chart2
        
        Change-Id: Icff667a11f1798e29c732c13b5739a4f7b581999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-27  Noel Grandin  <noelgrandin@gmail.com>  [11599f6f00bbcad78ad7c3f563606616e8506ea8]

        use more OInterfaceContainerHelper3 in NameContainer
        
        Change-Id: I75cb302156ea93fe0b545b22ca85a0c537cce760
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [ae36ee4f3aa544e53e2edad93d6d79160b27bc9d]

        Work around use-after-poison
        
        > ==21930==ERROR: AddressSanitizer: use-after-poison on address 0x61d001aa0eb0 at pc 0x0000004398b4 bp 0x2ada81952e60 sp 0x2ada81952610
        > WRITE of size 192 at 0x61d001aa0eb0 thread T42 (utl::Moderator)
        >     #0 0x4398b3 in __interceptor_memset.part.43 /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:773
        >     #1 0x2ada82e404ae  (/lib64/libnsspem.so+0x154ae)
        >     #2 0x2ada82e405bf  (/lib64/libnsspem.so+0x155bf)
        >     #3 0x2ada82e331b7  (/lib64/libnsspem.so+0x81b7)
        >     #4 0x2ada82e386c1  (/lib64/libnsspem.so+0xd6c1)
        >     #5 0x2ad58dccdafc in secmod_ModuleInit /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
        >     #6 0x2ad58dcd3027 in secmod_LoadPKCS11Module /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10
        >     #7 0x2ad58dd37e20 in SECMOD_LoadModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10
        >     #8 0x2ad58dd389b9 in SECMOD_LoadUserModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28
        >     #9 0x2ad54cea71b1 in nss_load_module /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12
        >     #10 0x2ad54ce969ae in nss_setup_connect /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12
        >     #11 0x2ad54ce95a5a in nss_connect_common /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14
        >     #12 0x2ad54ce9320a in nss_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10
        >     #13 0x2ad54cebfa5a in Curl_ssl_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12
        >     #14 0x2ad54cc6929e in https_connecting /workdir/UnpackedTarball/curl/lib/http.c:1591:12
        >     #15 0x2ad54cc68c74 in Curl_http_connect /workdir/UnpackedTarball/curl/lib/http.c:1517:14
        >     #16 0x2ad54cd42aac in protocol_connect /workdir/UnpackedTarball/curl/lib/multi.c:1696:16
        >     #17 0x2ad54cd2a3dc in multi_runsingle /workdir/UnpackedTarball/curl/lib/multi.c:1997:16
        >     #18 0x2ad54cd25704 in curl_multi_perform /workdir/UnpackedTarball/curl/lib/multi.c:2568:14
        >     #19 0x2ada803a8d54 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&, http_dav_ucp::CurlUri const&, curl_slist*, com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const*, std::pair<std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&> const*, (anonymous namespace)::ResponseHeaders&) /ucb/source/ucp/webdav-curl/CurlSession.cxx:918:14
        
        during UITest_sw_options (<https://ci.libreoffice.org/job/lo_ubsan/2210/>) after
        bdef11f5337ecc87556a92693f6b7b5e200eb29e "configure: default to
        --with-webdav=curl", apparently caused by a mixture of external/nss built with
        ASan and system /lib64/libnsspem.so not build with ASan.  (And this commit may
        become obsolete with <https://gerrit.libreoffice.org/c/core/+/120388>
        "configure: default to --with-system-nss on Linux".)
        
        (The last time that use-after-poison in /lib64/libnsspem.so hit
        <https://ci.libreoffice.org/job/lo_ubsan/>, I could work around it with
        db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download
        https files".)
        
        Change-Id: Ic5ed4e60a577a65c71084e97b3fb3afd03266bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125912
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [fcee6b02ebfcb82f3c191b1e6ef12ef9a3487711]

        tdf#118063 - Writer: Deselected line spacing items remained checked
        
        The state of the attributes for line spacing within comments and
        textboxes are now read and set correctly.
        
        Line spacing menu items were removed from Calc in Bug 136071
        (ce9e965b3fc3744b99afee07f6d56860852af5e4).
        
        Change-Id: Ie20a8529d84a14d549e1985471f684b88e21819b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125880
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-11-26  Eike Rathke  <erack@redhat.com>  [324e5c3942870749fae0e62c1c11a1400b772584]

        Regression Statistics: use cell reference, not fix row to calculate offset
        
        The INDEX() offset was calculated with a fix row number derived
        from the initial output position, like 35-ROW(). That fails if the
        range later is moved or rows inserted/deleted.
        
        Instead, use a cell reference of the cell's current column and
        end row, like ROW($A$34)+1-ROW(). 34+1 to not have things shifted
        if a row is inserted before 35.
        
        Change-Id: I11276c4acb35505576daa1a20ad49a4fcdbaba49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125914
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [93663a64e1a436eddcbaefd4bb0a8f83a925cdb4]

        tdf#145831: fix typo in PNG
        
        Change-Id: I206ac72d56409b3516f49798fb7f10b3a4c3d721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125680
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [7d3aadce8d184f72e4785827ad706d27c31a2edb]

        ofz#41398 drop a para scheduled for deletion if something else deletes it
        
        Change-Id: I0b7d7f5224b78658951c7d0b71eb793057059bca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125886
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [b03e070420606d407df2ec5e9dfa7043ecc46177]

        ucb: webdav-curl: fix CurlUri::CloneWithRelativeRefPathAbsolute()
        
        Change-Id: Idf1d75817009286cd79a00c0ba154cea70e2ffda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125908
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Justin Luth  <justin_luth@sil.org>  [bed6b7356e4bba1604ee5f760c80acc16ae54bae]

        tdf#126356 partial Revert "sc tiled editing: Mapping has to be
        
        turned off after drawing the buttons."
        
        This partially reverts LO 5.0
        commit 342d84218c17da40d0a4f96bc3b07b536d64517a which comments:
           Also - we are actually never call with something else than MAP_PIXEL,
           so let's kill the resetting of the mapmode;
           let's see if some obscure corner case bites us here.
        
        Several bug reports have indicated artifacts on screen,
        all coming from the use of autofilter,
        and in these cases the map mode is 0 (Map100thMM),
        so I restored the whimsically removed logic.
        
        Change-Id: I9bb5d7418fc4083ed71139a64329b11fa1e4cc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125879
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [8d436e68a6f4d81a98a2059bc185ed86197272c4]

        Adapt distro-configs/LibreOfficeFlatpak.conf
        
        ...to 214fa233338c09156c67f85818b6a2ea6b3235bd "add
        with-system-abseil/with-system-openjpeg for pdfium"
        
        Change-Id: I5956b2710e3c3aa02285224e9d5799ef2da91270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [bdf2628013f58ca20260de597f12f8e8ba83e5ed]

        --without-system-cuckoo missing in distro-configs/LibreOfficeFlatpak.conf
        
        ...for 3749d9af3745c0eaff7239e379578e4e2af89e9d "tdf#130795 use concurrent
        hashmap in SharedStringPool"
        
        Change-Id: I1f8d224cc412ff3e8ad819b018aea6cc1829faca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125884
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [78d14ff6ef230ba3433d50ba8ded1a7cd2689b0f]

        ucb: webdav-curl: don't use chunked encoding for PROPPATCH
        
        Sharepoint 16 has the same problem with this as with PROPFIND.
        
        But this still doesn't work, trying to add dead properties results
        in HTTP/1.1 400 BAD REQUEST now.
        
        In fact, it has additional problems: request 3 properties Foo, Bar, Baz
        with one PROPFIND and it complains about Foo, FooBar, FooBarBaz...
        
        Change-Id: Ia0ce0f7b9422e0751839151a4c964f0437282c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125907
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Noel Grandin  <noel@peralex.com>  [bf74eb1d1623a51805f91a973bc9f726d14dd7a8]

        tdf#133996 speed up opening of ODS with autofilter + conditional formatting
        
        inline some hot methods, and use OUStringLiteral to avoid repeated
        construction of an OUString, saves about 3%
        
        Change-Id: I6d09ade4e08a94ed5dd49a8882e26bb5786409d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125873
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Noel Grandin  <noel@peralex.com>  [05766922e7e4262b98e9c3f8d83cdfdaa49d3f7a]

        speed up Fraction::operator*= a little
        
        for my test spreadsheet this reduced the time spent
        in Fraction by 30%
        
        Change-Id: Ib14a93284dbd6c6ea2349c1754979135463ca61b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125878
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [26643b50a29cb25f4827aebbccc72beddeac7a69]

        use more OUStringLiteral in svx
        
        Change-Id: Ifdcfa4e1f9a42618061642ffe05eaa2a32e1010e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125882
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [59b602dcdb445116dde3e50dce45974eec0e043b]

        remove unused defines
        
        Change-Id: I96f224c9afae857c0b37ec91c523e41afdc9db05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125881
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [94960a5594f932a2ba767db21bdf803180a8c761]

        tdf#145814 fill format mode is mostly disabled
        
        when it shouldn't
        
        Change-Id: Ic282c313a6986d7d08f54b475c5d2ce32098ada1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125851
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [cb699fd9c749d5fe621406918fa6458896c09239]

        tdf#49033 Honor Selection When Applying Sentence Case Format
        
        Prevents Sentence Case formatting from occuring outside of a user's
        selection.
        
        This commit does not prevent Title Case formatting from
        adjusting the first letter of a word, even if the selection does
        not include that letter.
        
        Change-Id: Id3f1a5b0da973d24ef73f1e640306a65e1b4c561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121966
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [224026a38ddc4008d1c73fa1ba95f672f03fac63]

        tdf#119190: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I5ba98b3651470f7c86b9aca9359d563e64058552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125874
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-26  Heiko Tietze  <tietze.heiko@gmail.com>  [f82f6a2714fbf7882eb1d77351574392ae8e4c27]

        Reverts tdf#144247 tdf#101217 - 4 digits in row height/col width
        
        Reverts patch I29d90b413e6f6f6e8b73d30ac47d644a69d15046,
        ad8edac43e73555bc2055514300c5b81a1bb04ea and partially
        Ibdee348d84a8b96d8f698e7fc6db89eb24422f5d
        
        Change-Id: Iba5fd2d2a65d813c2d5ba85e66a7c3e07b726ca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125871
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [95bd1f66f879caa13484c408b05d05d1e42075ca]

        loplugin:stringliteraldefine in svx
        
        Change-Id: I2375ebfe9791c43063ffbc8ddbe1bd365499a576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Tomoyuki Kubota  <himajin100000@gmail.com>  [d9796e597329849a6d360f205c5d36f7838884d8]

        floatingnavigation.ui is no longer used
        
        since 
        https://gerrit.libreoffice.org/c/core/+/87005/9/sw/source/uibase/utlui/navipi.cxx#b393
        and
        https://gerrit.libreoffice.org/c/core/+/87005/9/sw/source/uibase/ribbar/workctrl.cxx#b310
        
        Change-Id: Id95f73d782f8d785b26ee6739014314c4d1a6fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125831
        Tested-by: Jenkins
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [547cb22e1a4ad5c39f116eb74b74baf7a729d2e9]

        loplugin:stringliteraldefine in stoc,svtools
        
        Change-Id: Ifd583582fa7bf7366a1f8d482eefd64b30228ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125867
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [91ce3455cfe1c850dd9780c41e6253cb940af1e9]

        cid#1494447 ucb: webdav-curl: Logically dead code
        
        Change-Id: I98a99ddc287fd83ff95e9a1b3851a9888dd6ef5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Hossein  <hossein@libreoffice.org>  [149bd802623d6d83ec9aa04514b938494f7f01f6]

        tdf#145873 Fix FILEOPEN: EMF file not displayed
        
        EMF can have WMF embedded inside it. The sample PPTX file contains an
        EMF file consisting of several GDIcomment records in which embed a
        Placeable WMF file without some records related to the size of the
        WMF. It reaches pStm->SetError( SVSTREAM_FILEFORMAT_ERROR ); in
        emfio/source/reader/wmfreader.cxx:1982 which causes to the problem
        in loading the file.
        
        With this fix, the EMF file will be displayed. Without the fix, the
        EMF file will be displayed as blank.
        
        Regression from
            commit 5e4e1cdb1e14354b42838e1dfcf82873b3071896
            tdf#88163 Fix font size for placeable wmf files
        
        The fix can be tested with:
        
            make CPPUNIT_TEST_NAME="testTdf145873" -sr \
                CppunitTest_sd_svg_export_tests
        
        Change-Id: I04babd5029ba123fdd03758eef2be69faf45fda8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125796
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [00455b22f0544159e60e9f9f9fd1a7c41855fb58]

        cid#1494445 silence Data race condition
        
        Change-Id: If1037293058812d6800646a2a0399a59f356d098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125865
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab1a7b5242c3d5e0b86601073fb4ff4750f7f0d3]

        loplugin:stringliteraldefine in sfx2
        
        Change-Id: I45ccf6b1841024db7406b910a28dff054f67464d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125862
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [9f94ea12c7d919441ccbb8ebc99adff11a2e6fd1]

        ucb: webdav-curl: remove useless assert in getLockTokenForURI()
        
        Change-Id: Ia27acf55bd7baf70c0b57e0922a62b1d9680c5b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125848
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [f50d0ca0978d8c6b8dff5ce680bce9fe71c0a7dd]

        ucb: webdav-curl: don't use chunked encoding for LOCK
        
        Sharepoint 16 produces exactly the same error HTML as for PROPFIND.
        
        Change-Id: Idd3862456c4efbb9eb0533298dcd93711b30faae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125847
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [403d3e057575825f86ff97bf9e277feafa69362e]

        ucb: webdav-curl: avoid pointless HEAD requests for DAV resources
        
        Content::getPropertyValues() has a funny conditional which was changed
        in commit a86bc34ddcff6b04bb9fdb8c960bbf2c49540da1 "Resolves: #i121922#
        Fix wrong condition".
        
        But the new condition also appears wrong, there is no need to do any
        further requests if all properties have already been retrieved, so the
        check for m_bDidGetOrHead could just be omitted.
        
        There is a surprising result in the Remote Files dialog when connecting
        to a Sharepoint 16 server: all properties have been retrieved from the
        directory given as Root, but because of !m_bDidGetOrHead the branch is
        taken anyway.
        
        The HEAD request results in a "HTTP/1.1 302 Redirect" to
        $ROOT/Forms/AllItems.aspx, HEAD on this URL gives a "HTTP/1.1 200 OK"
        and then subsequently a PROPFIND on that very same URL results in
        "HTTP/1.1 404 NOT FOUND".
        
        Physics claims that a single observation should be sufficient to
        determine whether an URL exists or not, but Sharepoint is apparently
        able to maintain this quantum superposition indefinitely, hence the
        Remote Files dialog doesn't display anything as the 404 causes an exception.
        
        Try to fix this by requiring a missing property again before initiating
        the HEAD request for DAV resources.
        
        Change-Id: I1239762948b6abd1f8fc097edd4a16cb6b75ca7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125826
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Michael Stahl  <michael.stahl@allotropia.de>  [8bb183f133202ebb687e0b56cc5a2938354506f7]

        ucb: webdav-curl: don't use chunked encoding for PROPFIND
        
        Sharepoint 16 responds to PROPFIND with "Transfer-Encoding: chunked"
        with "HTTP/1.1 200 OK" and this body:
        
          <HTML><DIV dir="ltr"><H2>Microsoft SharePoint Foundation Error.</H2>\n\n<P>\n<B>User:</B> please report details to this Web site's Webmaster.\n<P>\n\n<P>\n<B>Webmaster:</B> please see the server's application event log for more details.\n</P></DIV>
        
        Understandably, WebDAVResponseParser barfs on this:
        
        ucb/source/ucp/webdav-curl/webdavresponseparser.cxx:405: Parser destructed with existing content (!)
        ucb/source/ucp/webdav-curl/webdavresponseparser.cxx:942: WebDAV Parse error (!)
        
        Apparently setting Content-Length works better.
        
        Change-Id: If3eae8c2f8b9f1e1bb4ed4fc67a79a682d7d0050
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125825
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [f8760d18b274cc7c943921d61c49c99176cd22b8]

        cid#1494446 Uninitialized scalar field
        
        Change-Id: Ib8e1d0e691772e822f81afafbd47ba33698b592e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125863
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [563ca64b09ec853a0cd75b2512a2046950b17822]

        Fix typos
        
        Change-Id: Id23e40de23de829e42b984d74be8bb0e632112d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125855
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [8e1768551643420addbfb4349e838579380bfa01]

        cid#1494444 silence Dereference null return value
        
        Change-Id: I7c6c60489a58378238ff63ff9c6b45f3a7aa4bf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4253900e26e0c1434c19f6af74930a8b5b470b9]

        remove unused defines
        
        Change-Id: I299486e00e027299b571fdeb3846a74830511ce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125861
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [5db9b33dadda67c7f97d8c23df17211fae380919]

        tdf#144940 sc: fix disabled header/footer regression
        
        Setting "Same content on first page" in the Page Style
        dialog on either the Header or Footer tab resulted
        disabled header/footer after reload. This was due to
        flawed logic when assigning SC_UNO_PAGE_HDRON/FTRON
        value: "leftness" was checked for but not "first pageness".
        
        Regression from commit b9993369b4011cd8f367e439f5248096827f1efc
        "tdf#121715 XLSX: support custom first page header/footer".
        
        Co-authored-by: Daniel Arato (NISZ)
        
        Change-Id: I8ee4c9f8145913d9dc5f4b66cdbc2352f2e405f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125367
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [b18c2a0024c6d33cdf142ed2adf0d127483411e8]

        -FIIntrin.h in CC/CXX is no longer needed for my clang-cl build
        
        ...at least with Clang 14 trunk now (but I didn't check which llvm commit would
        be responsible for that, and which version of LLVM that appeared in first).
        
        That also means the -D_CRT_RAND_S hack in CXX is no longer needed either.  (See
        the mail thread starting at
        <https://lists.llvm.org/pipermail/cfe-dev/2015-November/046012.html> "[cfe-dev]
        clang-cl question".)
        
        Change-Id: If1b1b4fa17782161c3b72ac68fdef28b0e044a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125859
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [8ae97ead49b31899c194e6086bd0e53be17da62e]

        Drop support for poppler w/o cpp/poppler-version.h
        
        Seems the first poppler including poppler-cpp.pc.in and also
        cpp/poppler-version.h.in was 0.14.0.
        
        So this also increases the minimal system poppler dependency from
        * poppler 0.12.0 (Wed Sep 9, 2009)
        to
        * poppler 0.14.0 (Tue Jun 8, 2010)
        
        Compiling the internal poppler, we're up-to-date anyway.
        
        Change-Id: Iee07cfeb43f4320fd596c772eeb26662505d0daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125778
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [18a66c788983115a37bb02112d3dba8935a4ce97]

        m_xTreeBox is always true
        
        this has evolved from an optional m_pTreeBox widget to an always present
        widget that's optionally visible and this case wasn't updated somewhere
        along the line. Use "IsSafeForWaterCan" which the other cases of this
        pattern were merged to
        
        Change-Id: Ia20327ade5378bbdfa9fbfecbfa9705a33555f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Caolán McNamara  <caolanm@redhat.com>  [23662e4ca69386c14425798f1e9d80ff803fb7cc]

        tdf#139102 Erase with COL_TRANSPARENT doesn't do what it should
        
        lets not fight that here, just provide a simple backportable fix to 7-2
        for now.
        
        Change-Id: I77ceb7ccace08041a42b51e1b028ebe2d6a03e51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [c4499bef94845176b53bbe9678d242638d86040c]

        loplugin:stringliteraldefine in framework
        
        Change-Id: I8bdda62c232b8f20aa6bb1e5e7ad303d6ffa47ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125809
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [2132da5066143d7828984bc1aa42d10223bc5824]

        loplugin:stringliteraldefine in package
        
        Change-Id: I91ce2f65513ea9ae74841c6b0286c01d4e6dd82f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [a916adba23e81c8c661369d2c06fbe9c6714d9c2]

        loplugin:stringliteraldefine in l10ntools..oox
        
        Change-Id: Ia19d247f3cf439405c05a53c4cf2c9d0e7344560
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125811
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [6dfcabf54a86f7204b4924718a930be5d13b1eeb]

        loplugin:stringviewparam
        
        Change-Id: I8a4c310e3a963362bff390e93ca39a7583e83e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125857
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Miklos Vajna  <vmiklos@collabora.com>  [32842d4bf250bcab281eb71a218d618485c60290]

        sw, viewing OLE objects: also protect "common" embeded objects
        
        Commit 4f9f1ac33366817df61c488a9f36b09c592ee939 (sw: allow viewing OLE
        objects in protected sections, 2021-11-25) allowed launching OLE objects
        in protected sections, and then made sure that changes done in "real"
        OLE editors (on Windows) are discarded: both the native data and
        preview.
        
        Extend this mechanism to also handle common embedded objects (i.e. when
        we load the data into an own document model, like Calc-in-Writer on
        Linux): there we can simply load the data read-only, so there will be no
        need to discard anything.
        
        This requires some way to pass down the read-only flag from sw/ to
        embeddedobj, implement XInitialization on OCommonEmbeddedObject to do
        that.
        
        Change-Id: I7b32d7514a6b0a40b4f58bed57879d292daa4ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125858
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-26  Noel Grandin  <noelgrandin@gmail.com>  [0600affd91ca799c75354a8c63d2b40373b08996]

        tdf#133835 speedup calc autofilter (10)
        
        Remove more temporary buffers in INetURLObject::setAbsURIRef
        
        Change-Id: I3c5430937e3365a15b396504226d3bbdd39c4cc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125668
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-26  Stephan Bergmann  <sbergman@redhat.com>  [c1d0b2ec10ee10127409a6e085b26fdc86d426ad]

        -Werror,-Wreorder-ctor
        
        Change-Id: Ie0a1036f57bc1449dda324b99fd83170969958a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125856
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  mwarner  <michael.warner.ut@gmail.com>  [f32b7faf33778282a9519d75fc0a130aa93b3144]

        Unused Import of Carbon.h in macspellimp.hxx
        
        The macspellimp.hxx file was needlessly importing Carbon/Carbon.h
        
        Change-Id: I22ee6bf5c39b52fb09409983f52803e58459f2e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125853
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-26  Miklos Vajna  <vmiklos@collabora.com>  [b30c68faacd8f970a8df8cd4283a3121f5d7fe53]

        sw: remove remaining uses of DECLARE_OOXMLEXPORT_EXPORTONLY_TEST
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I45ca8709afb434cbd0c093a105fa560d0175f8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125849
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b8ddfc8424149e96bf7ddc8b183e01c782822f55]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4de0e64acce71f06fe07dbe989f77a2aedb4e7d6
          - Fix typo
            
            Change-Id: Ibebb1d297c72c1a48191b5c875c9e9c9dd465054
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125854
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-11-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ddc57169ac8d1de00403dbb09fef5221beaa0f3d]

        Removed break; after return
        
        Change-Id: I14e12fee4b86ba2fadeefddef5de086e85d4bb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125729
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [e95a808020de12351714965f5656e893d94d50f4]

        update Skia to chrome/m97
        
        Change-Id: I55ab0b25389dcce3263b38a2de12c437b47751c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125821
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bd0fb2d95a2a30abd8e215e7e1715fbf6cc69dd3]

        bump product version to 7.4.0.0.alpha0+
        
        Change-Id: Id53d388b35843b395f5a768c8a81fe7d746a25ad

2021-11-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [229123ccc6f90ebf66b3e659bebbd53f8a9bdd3a]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9658a28df4b4c0eb79a9635221bab10ee09fed61
          - update translations for 7.3.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: Ibe869de5bcee1affe91172648c8a21ad9943f54a
            
2021-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [4e9c1938df3fb13c73910ac4019b66a1924b6d5f]

        ucb: webdav-curl: NTLM is both system and not-system authentication
        
        Leave it to libcurl collapse the wave function.
        
        Change-Id: Idb51ebaec8b68a7c7fadcae2ae13b3b63ba1db79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125788
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-25  Michael Stahl  <michael.stahl@allotropia.de>  [97af6ccd95b9548723c2baa4b051c049c47bc8ea]

        ucb: webdav-curl: Sharepoint returns redirect urls that curl can't parse
        
        Encode them just like in WebDAVResponseParser.
        
        Change-Id: I7f0ee1d42df356fdd585d1f6e0f39e4094701a2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125787
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-25  Eike Rathke  <erack@redhat.com>  [a8ae1ffffa3d2621a3e7d3fa538a2b98e2ad7a12]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c8e8358756f7e5f62e5b6fd24410e59797bdf05
          - Fix MATCH() Type=-1, index of last >= value is returned
            
            Change-Id: I8b84e60cb626ee3b0df334cb1b41d3ef9da4e209
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125824
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2021-11-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [4b681f0652fa97de65b47ae4ff2d341c27d7446c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 856c215166a7fa14cd5788842068862925d22a4b
          - Document Locale / PythonVersion properties in SF_Platform service
            
            Change-Id: I141b31e9398e39d968197b11e4b8aa2ceda99480
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125827
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-11-25  Jean-Pierre Ledure  <jp@ledure.be>  [6983e9e0a299d3645a1eaaad9ff1b0a79ea2d207]

        ScriptForge - (SF_Platform) fix Locale should return the OS locale
        
        So far it returned the LO locale.
        Discussed on Telegram
        
        Change-Id: I2cf66ca3acebe695354de9185e0698ffa4d8cf05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125820
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [a0e27322bebf5443ef895cb4c43d9288bcf13f9f]

        use even hyper-thread cores for Calc threading
        
        I assume the threading was originally limited only to real cores
        because that's how many FPUs there are in the CPU. But Calc
        dynamically allocates many data structures (ScFormulaCell most
        notably), which means they end up scattered all over the memory,
        and processing them often stalls on memory reads, leaving time
        for other HT core to run. For data-heavy documents (such as using
        VLOOKUP) using HT cores saves 30%, but I can see 10+% gains
        even for compute-heavy documents.
        
        Change-Id: I302b17e55f27541606d922a1f0b27005ce0f0ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125801
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [89f64b9f0dcdc27fdc6827b5aca42af1b38ede25]

        uitest: blind fix for UITest_writer_tests7 failed
        
        Traceback (most recent call last):
          File "/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/sw/qa/uitest/writer_tests7/forms.py", line 76, in test_tdf140239
            self.assertEqual("true", get_state_as_dict(xURL)['Enabled'])
        AssertionError: 'true' != 'false'
        - true
        + false
        
        Change-Id: I535f1dd5d755b5896faa55651f5a1ff6c58cec4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125814
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-25  Caolán McNamara  <caolanm@redhat.com>  [3057538549fb30a0f5312653a97216ba93f126a2]

        Resolves: tdf#145863 crash if popup closed before becoming truly visible
        
        the timing has to be just right to get this to happen
        
        Change-Id: I1ae81bf5c79b7f8b3fdf82b3fab94d5a3b6076cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125816
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-25  Jeff Huang  <jeff@mail.ossii.com.tw>  [7b0e0409c3f24dfe37d9c43ffa439b56ea719868]

        tdf#145539 const OUString -> constexpr OUStringLiteral
        
        Convert string literals defined as const char[] in header files
        to constexpr OUStringLiteral
        
        Change-Id: I69fdc34cfb663ff87fabc8efc72d6563aa23465b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124724
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-25  Miklos Vajna  <vmiklos@collabora.com>  [4f9f1ac33366817df61c488a9f36b09c592ee939]

        sw: allow viewing OLE objects in protected sections
        
        The problem was that we don't allow even opening embedded objects in
        protected sections, which means the content of multi-page embedded
        objects can't even be viewed in protected sections, which probably goes
        too far.
        
        Fix this relaxing the condition in SwEditWin::MouseButtonDown() to allow
        launching the OLE object on double-click, and then make sure that the
        native data is not updated in SfxInPlaceClient_Impl::saveObject() and
        the replacement image is not updated in
        svt::EmbedEventListener_Impl::stateChanged().
        
        This is complicated by only the Writer layout knowing if a given OLE
        object is anchored in a protected frame, so pass down a callback to
        sfx2/ and svtools/ to check if the OLE object is protected.
        
        Not copying the protected bit has the benefit of behaving correctly if
        the section turns into non-protected: copying would not work properly,
        as SfxInPlaceClient is created on demand, so not re-created when the
        protectedness of the section is changed.
        
        Change-Id: Ib3a8f2092d27dc1ebd3ef355c95a4a473988b163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125815
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [9bc77b5107917ffe96b7ddf2c4d6d739a5e60c5b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ac2801c1df75bd6dc1699d1774c8ed53ca7df54
          - Fix example in EqualUnoObjects help page
            
            Change-Id: Iefea00251c858eb6fe98fe2220b24b3e35907c92
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125721
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-25  Martin Srebotnjak  <miles@filmsi.net>  [f234bea67195ee2b9c80ba0b4a18b4a81cf57cfb]

        Update git submodules
        
        * Update translations from branch 'master'
          to e2ec5c1a4e906baa55408deed5378268a6c80587
          - Updated Slovenian translation
            
            Change-Id: I403c800898f348b46aaf5f17ca96c2341409b7ba
            
2021-11-25  Caolán McNamara  <caolanm@redhat.com>  [d69b3007b6417395ac726c1c3ef1466f7cb2f829]

        Resolves: tdf#145786 get the correct bounds with window scaling enabled
        
        the per-window/app scaling as opposed to the global desktop one which
        wasn't affected.
        
        the menubutton thought it saw the mouse release happen outside the
        window it popped up when the combobox inside it was clicked, so popped
        down the popup from underneath the combobox.
        
        Change-Id: Iace9538073bb2380443d87600a872e88885934d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125807
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-25  Caolán McNamara  <caolanm@redhat.com>  [70dd00f23ee53ea5ae7f3c292906335fb6000ab4]

        required curl_multi_wakeup is only in >= curl 7.68.0
        
        Change-Id: I53878de49549098ff90ef1f68f88880a6eb5bf55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125797
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [7b0aabe71d2455f6f643553a07f1056935cf190f]

        sort, cache and binary search query items if they're many (tdf#136838)
        
        This makes autofilter even with tdf#136838 almost instanteous.
        
        Change-Id: I94b4b6d6ab6f8e73312d88c8b88c0f393707f117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125795
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [c41b0bf4c32e1934021d2d607f3f2fe7bc755cc8]

        fast query item searching also for ByValue with string
        
        The tdf#136838 comment #2 document has MaterialNumber column
        that is actually strings (even though they look like numbers),
        but autofilter creates ByValue query items (for whatever reason).
        So extend the conditions for fast searching to include this case,
        otherwise it'd be handled by the generic slower code.
        
        Change-Id: I0fe192b99cd2999282db53ba98587b712c42c762
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125794
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [7270f6f485f7b1308992bda059b3f874705c38db]

        avoid repeated checks with same result on fast lookup path
        
        Change the compareByString() function to a template with a bool
        parameter that will disable all the checks, allowing the compiler
        to effectively generate just a small inline function. And then
        compute the bool value once and call the fast version if true.
        With comment #2 in tdf#136838 this actually saves 40% of time.
        
        Change-Id: I5a5190f19a1df163b28e527090ec880e6de5bbda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125768
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a96b1b5158428e4b1925816932d6d0060e6c3d6]

        remove unused defines and convert some to OUStringLiteral
        
        Also remove the associated links.txt entries
        
        Change-Id: I5028fab2feb828875a0b772418fc29cbdfe4ce72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [1d0cdc461c43f0ce0eda4961311a972edf9e78e2]

        try to search efficiently with a query with many items (tdf#133867)
        
        Autofilter with large documents can create queries that have thousands
        of items. Searching all of those for every cell using the generic
        algorithm can be quite slow. First try an optimized search for this
        case that skips most of the complications and just tries to find
        in the query items an exact match for the cell. This significantly
        speeds up tdf#133867 or attachment from comment #2 in tdf#136838.
        
        Change-Id: I2bba18da6a101c76398d8c42c4306c53682899c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125746
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Luboš Luňák  <l.lunak@collabora.com>  [02f3157f75b654ef7648efdc3004b3f326d5af40]

        don't fetch cell string content for each query item (tdf#133804)
        
        When using autofilter, the query entry can have thousands of items,
        and fetching of the cell string value is not trivial in some cases.
        
        I'm not doing this for numeric values, as those depend on query
        items and also seem fairly fast.
        
        Change-Id: I01fa2e0cbce8f770d1ed079c0dba74830402a895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125735
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [98acc3d926571c13305501806ebc1b8be85e8960]

        loplugin:stringliteraldefine in desktop
        
        Change-Id: I36025f17dc6c47710d6cd299f0349b5be227c21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-25  Luboš Luňák  <l.lunak@centrum.cz>  [b041897b767ea4d6c64f4d22036d23f61d6907f5]

        fix windows ccache support
        
        I accidentally pushed an older version of the commit.
        PCHs work fine with ccache, so no need to disable one or another.
        And $COM is not set yet at the time when ccache is detected, so
        use $os instead.
        
        Change-Id: I1802684d6bbdee940b7062be0b8010a887216834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125800
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [fabed8f7b9a5e57cbb62e6570349c33f000c2291]

        tdf#128914: sc_uicalc: Add unittest
        
        Change-Id: I80d5a9c1ac9b05273f0237b966ad23a11a17a0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125798
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-25  Caolán McNamara  <caolanm@redhat.com>  [5274554148af5be90935df8ca3f2bb2751e95bfc]

        stldebug assert in bad sort of postgresql schemas
        
        /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/debug/safe_iterator.h:305:
        In function:
            __gnu_debug::_Safe_iterator::reference
            __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<rtl::OUString
            *, std::__cxx1998::vector<rtl::OUString>>, std::vector<rtl::OUString>,
            std::forward_iterator_tag>::operator*() const [_Iterator =
            __gnu_cxx::__normal_iterator<rtl::OUString *,
            std::__cxx1998::vector<rtl::OUString>>, _Sequence =
            std::vector<rtl::OUString>, _Category = std::forward_iterator_tag]
        
        Error: attempt to dereference a past-the-end iterator.
        
        Objects involved in the operation:
            iterator "this" @ 0x0x7fffffff75a8 {
              type = __gnu_cxx::__normal_iterator<rtl::OUString*, std::__cxx1998::vector<rtl::OUString, std::allocator<rtl::OUString> > > (mutable iterator);
              state = past-the-end;
              references sequence with type 'std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >' @ 0x0x7fffffff7d10
            }
        
        Thread 1 "soffice.bin" received signal SIGABRT, Aborted.
        
        a problem since...
        
        commit 5cbb6631e6d4c1000bff936712b4bd4aafbe04d5
        Date:   Fri Mar 4 13:01:57 2016 +0100
        
            pgsql-sdbc: factorise common code
        
        Change-Id: I7f7794e93224dfa946a7b5970c458fc3030fab73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125799
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a029e07ffbd6ea4a4a191188c5be2eca7e10066d]

        loplugin:stringliteraldefine in cui
        
        Change-Id: I3b0c8811b583d6edf48ccd7e368e50228e70c362
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125480
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-25  Gabriel Masei  <gabriel.masei@1and1.ro>  [3eb9eb9906c93fd7b1d1d8461bd34ea5a1ef2fa3]

        lok: add pdf version option for export
        
        Change-Id: I02c1edecd291309bf028e6e5a0f04a578ac1b639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125255
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [260933744fe4572dae61c43467c7fb06fa5f888a]

        loplugin:stringliteraldefine in extensions
        
        Change-Id: I9599fb3ca2fdcb30d8e1a52ecbfd954329762eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed355acf3f7bff30494f1936563fecb9008aa4be]

        loplugin:stringliteraldefine in forms
        
        Change-Id: Ia26f0c767030db0361758d2be37f01d30c7e1df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125763
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-25  Caolán McNamara  <caolanm@redhat.com>  [8c66455df8f6a26c314290f252bedbc19db6b327]

        Related: tdf#145842 fix a crash after deleting an entry
        
        delete an entry in remote files dialog and go one level up and crash,
        ownership of the SvtContentEntry is not with the entry, but belongs
        to mpImpl->maEntries
        
        Change-Id: I4a052ada1fd4f5e8142ac4396877b15ac49149b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-25  Miklos Vajna  <vmiklos@collabora.com>  [3134d9c0ff6ff86a797d6b7faa49d71367177d66]

        vcl: pInputElement is never nullptr in PDFObjectCopier::copyRecursively()
        
        Change it to a reference to make that more obvious.
        
        Change-Id: Ie1da9982ee2d54a5d68d393a04643d1684521ef5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125786
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [515682539623c9d61921c4f89302ffa0a4cb8d24]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c80b0e8b7341e9880080767dcaf4722de694b858
          - Fix Direct Cursor mode help page
            
            The help page lacks the information about how to access the feature using the menu bar.
            
            Also, icons are not properly aligned. This patch organizes them using an icon table.
            
            Change-Id: Ic0308fecc68bbb2d72052fcb371a7859b91d7dce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125719
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [a2691e46ee37f1a73e14bbf6f0af6a940b88f103]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0e031e14e258d11234dfef5e97245829fad9af49
          - tdf#145398 Adjustments to the Writer tree
            
            Change-Id: I05b5d9bcf871725ecbca594f0f3c0936b94bd691
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125717
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [a2dcc6be0377bf36124a2a7a976562822df3a0c9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f0f2cba1d40a248f3cc24ecaa60d403586894780
          - tdf#143846 Separate help pages for ASC/JIS text functions
            
            Change-Id: I9b5ae9b14ea98fe9edbf84a433ad4b7ed3bfcf39
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125720
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e0a512da826e2856e7d36200a878b64907816c8]

        tdf#104418: sw_ooxmlexport10: Add unittest
        
        Change-Id: I3e7b1913edbdcb14da4ceb962879b67f69fb2345
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125777
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Julien Nabet  <serval2412@yahoo.fr>  [5461ed9828b48f947f99a034d7e3d8072157c58d]

        tdf#145874: fix "Drop deg2rad/rad2deg conversions" for gradient export in a pdf
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc0ab08634f59e1a1814e575fe6ad5e50bf1aee1
        Drop F_PI1800/F_PI18000, and unify deg2rad/rad2deg conversions
        
        Change-Id: I40089b166242d06e417b1877146d43df192d6225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125791
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8ac6ba98674652bd0ca317da4a0606da5adce85]

        td#f145621: sw_uiwriter3: Add unittest
        
        Change-Id: I5f9584309c7ad42f43110d11d6fb3d34d8fb9898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125770
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Eike Rathke  <erack@redhat.com>  [89c4bc5220810dc3684a473f87d001f2c55438a1]

        Resolves: tdf#128914 Create copies for non-shareable token arrays
        
        Change-Id: I59fdcf48fb0da9d944b00a140e043e4ea5fb1ae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125789
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [b6b7fb3d0a46a2d41fcd8f2319077fe280ff12f1]

        tdf#145842 canceling remote file delete makes file disappear from treeview
        
        we remove the selected entries from the treeview, so the user cancel's
        the deletion of an entry we should unselect it from the candidates to
        remove.
        
        Change-Id: Ieb2258960fc647ad15d8f315a18454a0dae8a420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125790
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e6f75af74c7f35feb8a22959a2f876af7f385ca2]

        Remove break; after return
        
        Change-Id: I0690bcf0740842abde7268d99ab791163262945f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125766
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-24  Julien Nabet  <serval2412@yahoo.fr>  [ae6b3cf568157ec37574fdc8491e5d385a88cd94]

        Convert sal_IntPtr into int + use constexpr int in sfx2/dinfdlg
        
        Change-Id: I39ab8370f0d01441d59e12fa120bbef4d767c2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125747
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-24  Julien Nabet  <serval2412@yahoo.fr>  [be31a1de5c53e997ea6af5af51baa28e1e183733]

        tdf#145833: Remove ITEMVALMEASURETEXTTYPES part in SdrMeasureTextHPosItem (svx)
        
        There's no need to use translations since it's only internal use
        See comments in the bugtracker to read the discussion
        
        Change-Id: Ic249081630640ad3ac306babe943f43ef8163901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125785
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [e0fb00bbf821a842c2747060cc60b5a7e58e5775]

        ofz#41274 use FrameDeleteWatch to update if SwFlyFrameFormat is deleted
        
        Change-Id: I105b5a384ff2310f15e9718cfbaacaee3b57118a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [cd198a34113e8fa8d1060c815b0320a52b089059]

        ofz#41345 Negative-size-param
        
        Change-Id: I7398fc39c84670f455993c80ea6c9defbcf911d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125752
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [51c735d5109c487fcb876379a16f170c19a98f93]

        Resolves: tdf#145840 call ToggledDavsHdl on setting checkbox state
        
        Change-Id: Ia2a735255b94fd3a097081950e2145e07b4b3b63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125783
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [bb1a4397dcb347b1f7bf300a0252afe1a66e6da8]

        gtk3: I don't think it makes sense to claim a crossing event is consumed
        
        if it does, then we should use the return of m_aMouseMotionHdl.Call()
        
        Change-Id: I9f04fcba1ef1d9768c3ce3b042884110a63f26a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125781
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [da5b1e251ee58eca7a971a3c9312bb9d8bdf7bc4]

        Resolves: tdf#145864 we should only return true if we consume the motion event
        
        and false if we want it to continue to be passed on to other handlers
        
        Change-Id: Ie237f890e3d065949dcfedb08b9f6c804643b4b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125780
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [84f8613cdd9d494c7f376420520e186b4d4ea8a1]

        uitest: remove print leftovers
        
        Change-Id: I9b0cef7a8a536a8db7d0b840dfe69714fdbf2cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125779
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ec5788d893e3939bd1d911575a974674f2142b8b]

        Fix typos and translations
        
        Change-Id: Ic358f008e09718b6f726a55edfe3a3f78bba2942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125728
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [36a005bb546e5ba68d2e7a57e0453999c7167e41]

        tdf#145621 sw: fix crash pasting paragraph with cross-reference mark
        
        At last, a case where copying a mark fails for legitimate reasons.
        
        (regression from 4bf04dea9afb30a9395e80b07a81d1908937ee8b)
        
        Change-Id: I7a318e03c0b0d30e204eadb5012f190edbbba486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125767
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [3d09becf194bf1702a389ee59a7d6df899a570dd]

        ofz#41250 use more SwUnoCursors
        
        Change-Id: I6bcfa71a140b048c74861cc9f344f456ed4a38f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125774
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2f43d95a0fb4bdd7121968ff9f365ffc325e5647]

        tdf#145828 Sidebar line styles: Default to "thin" width
        
        Change-Id: I78d754d36c7ea41f7e3259be331d23b8a25c480f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125771
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [4b98cdc9ed51186cd0a7ef5041bf8e8e29420289]

        tdf#122788: sd: Add UItest
        
        Use exisiting test for it and while at it, simplify the test
        I found tdf#145868 while working on this UItest
        
        Change-Id: I942e4c09f57e0641d4d69f2c990a958b709bcec1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125769
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7614a8cf6e9d46b5bae13507c433f3d799a99711]

        Fix typos
        
        Change-Id: Ibc2eb80d7cc0cfc22c7fea0dc7ebe495ae0927c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125765
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [f4eb555ff5294db037ea6e4d9510d0ca11276fa7]

        Border tab page: Use 'thin' width
        
        instead of random number
        
        Change-Id: I89f3be2d6bba02f1fbe52065fab81caded2656f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125699
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [0abde637728e53883939f028551c6de5aa215d50]

        loplugin:stringliteraldefine in formual,fpicker
        
        Change-Id: I663a31ff6b207f43dd6f1c8240a341845b9e20b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125764
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe9ff3b21f92a023da9364d2f45590b5832f70d0]

        loplugin:stringliteraldefine in filter
        
        Change-Id: I5c38448a9ec9d21bb2b012dd9d85facd759ac447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125761
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-24  Tibor Nagy  <nagy.tibor2@nisz.hu>  [98fedbc8501b53a199afa4a879707bf89a7f84e5]

        tdf#124781 PPTX export: fix superscript and subscript positions
        
        "Raise/lower by" character settings were saved incorrectly when
        the automatic checkbox is checked.
        
        Change-Id: Ia7260504cde85e14867936c83eaf8735142e2c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125302
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [bf0e6dbaf3cb288f08bb2d0226d73a0c20f0e154]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9ae4ee41e475d51f22122596c1f0bf4931232864
          - Refactor help tree files
            
            This patch applies "xmlling --format" to all *.tree files in helpcontent2/source/auxiliary.
            
            The reason for this refactoring is that these files' indentation is very messy and it makes it harder to maintain and update the files. Also, the indentation used here relies on Tabs whereas XHP files use two blank spaces as indentation.
            
            So this refactoring also applies 2 blank spaces as indentation to the tree files.
            
            Change-Id: I54366d6efd011a09baf45c3b74c089bd9b0401f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125718
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [b551c9e24a51b9443f3b0c17d354eed4f4953403]

        uitest: use execute_dialog_through_action in these cases too
        
        Change-Id: I899cdbe24b4277623f72b23a8c877feed867a594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125753
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc4ee83823d6cb94a507e2ebb9cc8eb56a6a3fa6]

        loplugin:stringliteraldefine in connectivity
        
        Change-Id: I6b2528c684fe56a114959a1d26101a882eee2106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-24  Johnny_M  <klasse@partyheld.de>  [1f106552e07dfdaf6262cef731ff301683a43570]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0578fd92eb320b70a0cf1bfd44799f6b1e45e402
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie57a80b8a7b98cd65e23e03523b14b1db11a4fe5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125594
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [da4b873245b9f5a096048e2370041c6278ebaf4a]

        tdf#114309: sw_rtfexport: Add unittest
        
        Change-Id: I78d05afa5d7fb18a4728330b769bb5e96c2ffd62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125758
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Johnny_M  <klasse@partyheld.de>  [0b7974c4b3b90428d452505d1c8f7dd2ab68b727]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76c44eafa48b328904ab7674f111abd5f65c82c4
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icaa6c6a47f6e99e352fdc46849ca7aa4bd9738a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125610
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a069fac4a08f93db74799d00f047e04f1a0735cd]

        loplugin:stringliteraldefine in comphelper
        
        Change-Id: I60ccd6049db65fef2397798ab916b0d1e24c0fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d9c85f5059000b129ca627df9f971396e4ee30d2]

        Update git submodules
        
        * Update translations from branch 'master'
          to 43a347a994090bf64fb97da9d9c7cafa4a74f392
          - update translations for master/7.3.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I38a315bbb47e60f4dc2a2268d3ec993d27cd8c46
            
2021-11-24  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [eabcfb3f18a6944d9ad89cecd3eb3ca7a2259cf3]

        tdf#129183 sw: textboxes in group shapes - part 3
        
        Grouping/ungrouping nested groups works now.
        
        Manual test:
        
        1.  Insert Shape.
        2.  Right-click on selected shape, Add Text Box (and some text).
        3.  Insert a new shape.
        4.  Select and group the two shapes.
        3.  Insert a third shape.
        4.  Select and group the shape and the previously grouped shapes.
        
        The text box remains in the nested shape group.
        
        Details:
        
        1) tdf#144271 memory leak of SwTextBoxHelper, by replacing the
        textbox structure vector with std::unordered map, and rethinking
        of the ownership of the objects. If a SwFrameFormat dies, and that
        is a FLYFRMFMT, it will be deleted from the textbox node and the
        FrameFormat table in the doc too, and the drawing will be stay as
        it was before. If the dying format is a drawing, all the textboxes,
        and the node will be deleted.
        
        2) Introducing the new UNO property TextBoxContent, which is needed
        for writerfilter/xmloff later to set a new textbox for the shape
        via UNO.
        
        3) Missing parameters are present now for syncing the textbox
        parameters.
        
        4) Introducing a new function namely the handleGroupTextBox() to
        do the tasks simply with all textboxes in a group shape.
        This can handle nested groups as well (group in a group).
        
        Known issues: now copy of nested group objects is implemented
        but not enabled, because it causes an assert.
        
        Change-Id: I931886eda01c7a3db93098de10f5e5f48f2f217b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124657
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-24  Tor Lillqvist  <tml@collabora.com>  [becd76743fd7a3ae84404f26b1afb60b923cabb2]

        Add source files from basic/source/sbx
        
        Change-Id: I00bafec0f3caef86fa886dc4331e5d38e9fa1766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125755
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d256707293706e2252f1e94bfb91fc84c34e5fae]

        border tab page: Explain how thick lines are
        
        Change-Id: I802c0736dde6d87c8548968cfa9ce0481aba4f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125700
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-24  Tor Lillqvist  <tml@collabora.com>  [3a6b9e3bc1a2854783811f1cfa86db6592685930]

        tdf#145354: Revert "tdf#91362: Use document paper size for printing slides"
        
        Reverting it has been suggested a couple of times over the years, for
        instance in
        https://bugs.documentfoundation.org/show_bug.cgi?id=91362#c23 and in
        https://bugs.documentfoundation.org/show_bug.cgi?id=145354#c41 .
        
        The paper size for a presentation document is typically just made-up
        dimensions with no connection to any actual paper size. (Or
        transparency size.) What matters is the aspect ratio.
        
        This reverts commit 57991f885e60d04e93bf5004d4fdceee7d29f3d8
        
        Change-Id: I5099039f5fdb836694f2b100fb28093584e8294b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124989
        Tested-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [e196c127c7e107a1dd0dbf9a28d4a4286129fbb9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89f81cf2f81e2594a68956755114c733aeb041c5
          - tdf#145617: Mention an alternative exponent notation
            
            And add date to the possible argument types.
            
            Change-Id: Ie818c219e57cf706fdee278d54db1774a67e5d39
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125716
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [dc9f248d7561003edf127442401137fbed73432d]

        ofz#41299 add testcase
        
        cp workdir/LinkTarget/Executable/fftester instdir/program
        LD_LIBRARY_PATH=`pwd`/instdir/program valgrind instdir/program/fftester `pwd`/sc/qa/unit/data/slk/pass/ofz41299-1.slk slk
        
        ==805505== Conditional jump or move depends on uninitialised value(s)
        ==805505==    at 0x1D66BAA5: ScRawToken::CreateToken(ScSheetLimits&) const (token.cxx:354)
        ==805505==    by 0x1D30D115: ScCompiler::CompileString(rtl::OUString const&) (compiler.cxx:4831)
        ==805505==    by 0x1DC68FE0: ScImportExport::Sylk2Doc(SvStream&) (impex.cxx:2174)
        ==805505==    by 0x1DC654E4: ScImportExport::ImportStream(SvStream&, rtl::OUString const&, SotClipboardFormatId) (impex.cxx:390)
        ==805505==    by 0x1DB84091: TestImportSLK (docsh.cxx:3404)
        ==805505==    by 0x406657: sal_main_with_args(int, char**) (fftester.cxx:485)
        ==805505==    by 0x40389D: main (fftester.cxx:97)
        
        Change-Id: If0cbab2b1b41dacba3b2871b09e31e2d8675ba82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125677
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Michael Stahl  <michael.stahl@allotropia.de>  [c3db9d7a440f34f3faffee6583da5381a59d5c2a]

        ucb: webdav-curl: properly reset CURLOPT_INFILESIZE_LARGE
        
        If the value is set to 0, then the next PROPFIND after PUT will not
        append the "Expect: 100-continue" header, and hang without uploading.
        See Curl_http_bodysend() which checks for != 0.
        
        Unfortunately with different default values for "long" and "curl_off_t"
        CurlOption becomes a little more complicated.
        
        (regression from 8e34fe50412fd58a600ba1b8238b80444aec02e5)
        
        Change-Id: I55ea02659f7a64f373e89a6d02d6865c158fd0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125742
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-24  Caolán McNamara  <caolanm@redhat.com>  [07941bfa4844f794a1e50a28c3eb28b24ad94a41]

        gtk[3|4] don't need the ifdefs if only using the dlsymed functions
        
        Change-Id: I2c3b7a19f047d341467f9c66ef93e3185330854d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125744
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-24  Miklos Vajna  <vmiklos@collabora.com>  [a557a1c4ac0b73668452f80169870bdfb204aeb6]

        PPTX import: implement native handling of a color's luminance offset
        
        This was already handled in oox/ at import-time: this adds it to the doc
        model, including UNO API and PPTX import.
        
        This is a dependency PPTX export and UI, and also the last transform
        which is easy to generate from the PowerPoint UI and we didn't import to
        the doc model.
        
        Change-Id: Ica4e738d8dc8e0409160ceab941a82f2475ddc68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125749
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-24  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ecfce0ff23d9f1ed5a51b29b14a7043dce87b300]

        tdf#145852 Revert "Make "uno:Printer" actually work"
        
        This broke a macro (see tdf#145852)
        
        This reverts commit 3f4d96767fb510f07577ba4f28e60f05a370a5b2.
        
        Change-Id: Ic3b4f31182e2f4e13d33f2b7711fec9ae62b1fd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125704
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-24  Tünde Tóth  <toth.tunde@nisz.hu>  [04e279007272de286be31152d01e9cb45c9bd3e3]

        tdf#145511 PPTX: export the password for editing
        
        The password for editing wasn't exported in PPTX
        documents.
        
        Test: Edit->Edit Mode doesn't change to edit mode
        any more without asking the password for editing.
        
        Follow-up to commit 5697e09b3e726a38b58ce31ac0c3a97e7871c74a
        "tdf#144943 PPTX import: fix permission for editing".
        
        Change-Id: I1a9de511cf8b79224d8ac0a9aa0bf860b87bf184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124651
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-24  Miklos Vajna  <vmiklos@collabora.com>  [0bd2f13c653057433b6cb31059c1ac01636e71f0]

        CppunitTest_sw_ooxmlexport16: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Idd45484981ae90afbed0c324e29cad27ba871ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125740
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-24  Luboš Luňák  <l.lunak@collabora.com>  [071a3894013ea2281c157ba0a786e205c1119bba]

        remove superfluous code that has a TODO note about it
        
        The commits introducing this part of code have tests attached,
        so it's fairly easy to check that this part of code is in fact
        not necessary, but if in doubt there's the option of simply asking
        the author of the code.
        
        Change-Id: I3b754090ac462d3ae8e4676fc1643570ec53aac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125695
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-24  Justin Luth  <justin_luth@sil.org>  [b7a46259eba35257291fe00851252c18ffb4fc90]

        tdf#130131 UI: add back "Split" to draw/impress popup
        
        This is a partial revert of LO 6.2
        commit cf8b3a74e8c093dd0ffc7e2f431a26864958f6fb
        
        I have no idea why uno:Dismantle would have been
        removed in this commit, since it wasn't
        added back anywhere else, and seems to be
        unrelated to anything else in that patch.
        
        Change-Id: I1fbed2b3a58aee733c41c7a4817b215e4bec6061
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125681
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-11-24  Mike Kaganski  <mike.kaganski@collabora.com>  [e41024bc9a693164ffc64048046469aaa81a07d4]

        Rename o3tl::underlyingEnumValue to o3tl::to_underlying to match C++23
        
        Change-Id: I1597a8e77199445bf377dbe54adc3134bb04fd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125748
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-24  Marco A.G.Pinto  <marcoagpinto@sapo.pt>  [ef37f8b9208d7e4f386afbac02cb3efaf283d6e1]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 96310b850fb350cde8611429292a03ae9167cfa8
          - Updated the British dictionary, based on the wordlist of Oxford Professors and checked one by one
            
            Change-Id: I17306b06107e0ef5aa3fd9562b833f28fdb9b57d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/124317
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            Tested-by: Aron Budea <aron.budea@collabora.com>
            
2021-11-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [06bcff6649be811cf7eacf971e84a0f4ac029b04]

        tdf#84283: vcl_pdfexport: Add unittest
        
        Change-Id: I56f50dcd93ef196d2261be924e004b9981d405dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125741
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-24  Johnny_M  <klasse@partyheld.de>  [43ee84e390a28a04c00b3fe9f5fadbf0a63245e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b57f294095c78e68a7b5f795163b8a75ac06198e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I61813aff00920e52489c6d108da9f2bcc5b54c03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125606
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-23  Eike Rathke  <erack@redhat.com>  [51a0a85247fab56040416e40b7c7d878689acb26]

        Resolves: ofz#41299 Rewind also on last resort #REF! IsReference()
        
        Otherwise for #ref!e:o NextNewToken() bailed out with an
        uninitialized maRawToken.
        
        Change-Id: I8b3b399a5a3636ccda3104ba2a5971e5e9a8fc02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125736
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-23  Johnny_M  <klasse@partyheld.de>  [52e6d37facdf430d35138f288e2d77f366390aab]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71c450376a4702a94902f15e4099d5925e22f842
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iade16c27ffcd392edee10300fcdc8c8ad2738b0f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125592
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [ed9eff7d91dcf7ffb87906422be61606e3117fae]

        short-circut SC_AND lookup if left side is known to be false
        
        Change-Id: Ia1badb975f4effca668a5c2a41cfef3beccf8e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125739
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [990d32dad6bdf5d92a14d8bc02ae2853facd9097]

        allow matching of empty cells as svl::SharedString (tdf#133804)
        
        This may speed up some lookups.
        
        Change-Id: I13a39abc43c64eb758fa55a6cdbda3e83e179121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125743
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Mike Kaganski  <mike.kaganski@collabora.com>  [758ff97066652fbdd960121d42e659d3ab90e7d4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 03e4103f0ac0d4203d5d3e7ea2946611ed04799a
          - tdf#145617: clarify help for CInt a bit
            
            Change-Id: Ie3a110ddc7ce2fcfbb75377d9426c2772eeffbad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125708
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [83f82cb6efa3ae40fe04f1180a3da64abe92980c]

        set empty value if not returning a shared string
        
        This is strictly speaking not necessary if callers would always
        initialize to nullptr, but I guess this is better.
        
        Change-Id: Ica88395e0f615afbd58efa71e5d64bfdd2a37319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125734
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [978b9b10d09f90ba390ce2dd38210b9501b9168c]

        CppunitTest_vcl_pdfexport: factor out common code
        
        Change-Id: I4e25906f2b63b36d31e08282ec72921fe10f08b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125738
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-23  Henrik Palomäki  <henrik.palomaki@yandex.com>  [e8ef9c403f6ceb7b3fbe8d9b3c9622963a7f7a34]

        tdf#114441 Change use of sal_uInt32 to sal_Int32
        
        This patch fixes my previous commit. It changes use of sal_uInt32 to
        sal_Int32 as it suits better here.
        
        Change-Id: Ia92e5eee70dbf00009321481e8be8ddd7c9b138e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125737
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [2e0d5203b0b8133ebc2e6f90c0e0a24962f144f2]

        do not wait for condition that's not needed
        
        When not querying for the test equal condition, it's pointless
        to keep searching for it to become true only to throw it away.
        
        Change-Id: Ie861bac141f80025e95753fb8b1202498df17383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125733
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [f606ddd86ba402661e4989718e8b8b8e6e2c2f65]

        move code to a separate function
        
        To be extended in following commits.
        
        Change-Id: I09eaf0f5cfdbbe0aff254231dbb983fd7f72cc5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125732
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [9f4934c6682697fa7e77953d9b0e558e1a88d017]

        do not fetch cell data if ScRefValueCell can tell that
        
        Change-Id: I2910231c9cf205ce697616e660e49056c221e89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125731
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Caolán McNamara  <caolanm@redhat.com>  [88afa134df87119fb23793543a15c23432b94cb2]

        Resolves: tdf#145804 show "Chapter Numbering" as (uneditable) list style
        
        Change-Id: I394d1e7d51a5008c1cc02e0c65df28df6acbe98c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Caolán McNamara  <caolanm@redhat.com>  [62924b92d6737579cc4709b410d311251d4e5517]

        fix configmgr --enable-dconf build
        
        error: no viable conversion from 'const char [1]' to 'std::u16string_view' (aka 'basic_string_view<char16_t>')
        and
        warning: instead of an 'rtl::OUString' constructed from a 'char16_t', pass a 'std::u16string_view' (or an 'rtl::OUStringChar') [loplugin:stringview]
        
        Change-Id: I0e611606190f063227c5467dc5a082277cebaaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125706
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Michael Stahl  <michael.stahl@allotropia.de>  [bdef11f5337ecc87556a92693f6b7b5e200eb29e]

        configure: default to --with-webdav=curl
        
        Change-Id: I00842dec9512a8fe0d68a507e8a1467df97709f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123461
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-23  Jan-Marek Glogowski  <glogow@fbihome.de>  [c2a581ffc1f4e3888c5c243932b71c3d96e8ba8f]

        tdf#62812 WIN use a compatible DC for font funcs
        
        All these function work on a temporary font. It's not clear, if
        the CreateCompatibleDC is actually needed and if the ScopedFontDC
        could actually just use the SalGraphics DC and restore its HFONT,
        but this at least now works as expected.
        
        A later patch can just drop the CreateCompatibleDC and DeleteDC
        calls.
        
        Change-Id: I6e86d660e69a58fa2eab89ece80c61e2635fc792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125652
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-23  Heiko Tietze  <tietze.heiko@gmail.com>  [90db4351138dec97f8dd2ebc350e8aef18a5358f]

        Resolves tdf#145801 - Uniform height for sidebar's panel titles
        
        Set height of all panel titles to the maximum height a panel title could need
        
        Change-Id: I1c023224fbca09b8f73151126b25df5f438260ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Michael Meeks  <michael.meeks@collabora.com>  [365b3f1f21cc799b5a8ab7be63a5725abf6baed9]

        Crash around help-windows.
        
        Seems a popular way to crash:
        	vcl::Window::ImplCallMove()
        		vcl/source/window/event.cxx:555
        	vcl::Window::Show(bool, ShowFlags) [clone .localalias]
        		/usr/include/c++/10/bits/unique_ptr.h:173
        	vcl::Window::Show(bool, ShowFlags)
        		vcl/source/window/window.cxx:2345
        	HelpTextWindow::ImplShow()
        		vcl/source/app/help.cxx:371
        	Scheduler::ProcessTaskScheduling()
        		vcl/source/app/scheduler.cxx:495
        
        Change-Id: I33ca0059844395c41f4d76619cca22aec81df207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125710
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-11-23  Caolán McNamara  <caolanm@redhat.com>  [2acdb3e617658ca19de26e8928e42b4955622feb]

        tdf#139460 improve autofilter sub-menu interaction under gtk
        
        so the submenu pops down when the mouse moves back into its parent.
        
        This removes layer of InterimItemWindow and for gtk (under wayland) the
        autofilter and its submenu can use native GtkPopovers
        
        Change-Id: I4c8c3d2087566f508d75eda72e272d9f7fba2f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125428
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Caolán McNamara  <caolanm@redhat.com>  [f5137ed5453661d21e85ecb94a08cfccae899ca1]

        only call signal_closed from Popdown dtor if it is still open
        
        Change-Id: I251239a6ebbd3f55b68a0c2cb15b4bd6728e19c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125703
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Hossein  <hossein@libreoffice.org>  [90ce07f5afcf52fc1ad7a9e636c8409af2d05913]

        Remove unused header file lwpresource.hxx
        
        * Removed unused header file lwpresource.hxx which contained
          symbolic constants of type 'const char[]' that were no longer in use
          - STR_WORDPRO
          - STR_IMPLEMENTATION_NAME
          - STR_SERVICE_NAME
          - STR_WRITER_IMPORTER_NAME
        
        Change-Id: I4f1293a83c4058d7d01a98454a673ac88bd35b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125701
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [3bb2507a44ef57e02bb6008206ca29c57fb87048]

        do not try to read table cell again on ScRefCellValue::isEmpty()
        
        The ScRefCellValue is always initialized to point to the relevant
        cell. Originally there used to be a cell pointer that could be
        null, but since 43e50ec759200fe166dba59d3ff76af2a2e148c8 it's been
        always set and so checking again is pointless.
        
        Change-Id: Ib661ec5de73891ed3a5cd0346287324183721806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125687
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [3f66e00c937f787129bac034798b74d5b72ef76f]

        make a bunch of svl::SharedString functions inline
        
        They are tiny and they are used in performance-critical parts
        of Calc.
        
        Change-Id: If227b11ac7929dd1369545a590d8ef1a977185f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125698
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Stephan Bergmann  <sbergman@redhat.com>  [a884f0596cf4d519f2e8e75737a108d134185f9b]

        Use proper type for OUString length variables
        
        Change-Id: Id116ed42c553bb6524876288ca0066be4a4a1820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125694
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-11-23  Harjot  <harjotsingh20022001@gmail.com>  [34a0f7023aad59bc054385f0593606d5d602e052]

        tdf#145538 Use range based for loops in EnhancedShapeDumper.cxx
        
        Change-Id: I111f6c7ab5ab2033c08683a16adaf388eeabc9ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125577
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f47da03b885b80966d65a4cf1146f059e054e8a4]

        Removed break; after return
        
        Change-Id: Ib712072deec9368a3a580562dd1fc3bc28e86e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125679
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-23  Luboš Luňák  <l.lunak@collabora.com>  [1728367684602bb897fd9a8518c40b071cb55a22]

        avoid only painting to windows in LOK mode, not invalidations
        
        9b73d3e8926d5f9b10464d19b539eef3eb088f50 disabled painting
        to windows in LOK mode, because it doesn't make sense as
        those windows are not even visible, but it tried to do it
        by avoiding even invalidations. That can trigger problems
        because some dialogs actually are forwarded to clients in LOK
        mode, and apparently they need the invalidations to proceed
        normally (the Format->Cell dialog in Online didn't repaint
        scrolling of the Date listbox, I don't know what exactly
        the actual problem was, but mnPaintFlags were different
        than when not avoiding invalidations).
        
        So revert most of the relevant commits and keep only avoiding
        actual drawing, which is what 057968bbce406efe6564347329df45b7e
        did.
        
        Change-Id: I4e212966830f4c690e6143b9d5fedbc24619e1ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125674
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-23  Henrik Palomäki  <henrik.palomaki@yandex.com>  [5d01e747270722ad9216ace8e782c7dfac5d744e]

        tdf#114441 Convert use of sal_uLong to sal_uInt32
        
        The suitable type for variable nIndex is determined by knowing that
        the return type of the detectNumberFormat() is sal_uInt32, and the
        second parameter for the getNumberFormatType() is also sal_uInt32.
        
        Change-Id: I6578eba05f151ee31eb8eb8142d70f8f5c7c702b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125696
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-23  Stephan Bergmann  <sbergman@redhat.com>  [792cd487831b1f731b6fb2fc2d0f39ef60a63534]

        Add test for INetURLObject::changeScheme
        
        Change-Id: I84497ee93e30b639199bbbb958ac1b2c758db50c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec1c4c49301758c54394f9943252e192ad54638b]

        O[U]String::replaceAt overloads that take string_view
        
        which results in lots of nice string_view improvements picked up by the
        plugins
        
        Change-Id: Ib0ec3887816b3d4436d003b739d9814f83e244b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-23  Gabor Kelemen  <kelemeng@ubuntu.com>  [db0f2c29bf3a6ad5a08f8524ea0e65aa90792bb2]

        tdf#144769 Properly encode file name in error dialog
        
        Change-Id: Ie8f0b57c33fff787735b09ecf8308f86b56d8bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125121
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>

2021-11-23  Henrik Palomäki  <henrik.palomaki@yandex.com>  [6f435016092953478b5636fe9078866500fc7b90]

        tdf#145538 Use range based for loops
        
        * Used range based for loop in fillhatchprimitive2d.cxx
            + Goal: Better readability of the code
        
        Change-Id: Ie8ddaa9960e714b161ec530961b36a9935055ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125413
        Tested-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-23  Noel Grandin  <noel@peralex.com>  [da6ac377c6a4bb84ba4bdcc41e73c9079b009039]

        avoid OUString temporary in INetURLObject::changeScheme
        
        Change-Id: I8a97c1d89770fe2c0ba0d3f75ce9f3fec0df2e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-23  Noel Grandin  <noel@peralex.com>  [7566479a7a049d0e65d7506bc563e4d1c664b16d]

        tdf#133835 speedup calc autofilter (11)
        
        Size the buffer at construction to avoid realloc
        
        Change-Id: I7fed6e345104fe9d4192aaa9664e7fe2662218bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9c8ac3632bcc3499cb0e6fe1b4a358ecb4a41b6]

        remove ORowSetValue implicit conversion methods
        
        in favour of the existing get*() methods.
        The get*() methods 0 or false or empty in the case of "null", which
        is exactly the same behaviour as the conversion methods.
        
        These implicit conversion methods cause lookup problems when combined
        with some upcoming OUString changes.
        And the code looks cleaner this way too, and has less magic when calling
        methods.
        
        Change-Id: Ieb4756bf693e83b996a32667fc1b955f89193496
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-23  Michael Stahl  <michael.stahl@allotropia.de>  [fa54bca695f6d17e871e43db75f06a63aec7b739]

        tdf#145769 ucb: webdav-curl: stop returning IsDocument=true if it doesn't exist
        
        Content::getPropertyValues() has no less than 2 fallbacks that cause it
        to return property values IsDocument=true and IsFolder=false in case
        there is an authentication failure or server connection failure.
        
        Change-Id: Iddcda6420c517f522d98e58b12a7e19247ff2d1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125667
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-23  Michael Stahl  <michael.stahl@allotropia.de>  [e4ff5b1fbabb538356053383a3491e3e986d1164]

        tdf#145769 fpicker: RemoteFilesDialog: don't use FStatHelper
        
        FStatHelper doesn't use an XCommandEnvironment and is thus unsuitable
        for remote access as it can't even authenticate with the password
        container; it should only be used for local access.
        
        Due to this problem, the ContentIsDocument() would always return a
        hard-coded "true" value from the webdav UCP, causing a spurious dialog
        that an existing file would be overwritten in Save Remote.
        
        (regression from 67fa088be7db1df661188ef4bab490a76fb06b85)
        
        Change-Id: Ibe667f2012e261b84d4c69c84fdd499b7276e64b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125666
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-23  Michael Stahl  <michael.stahl@allotropia.de>  [014336e8d45fc192960b9240d362604577e78553]

        ucb: webdav-curl: fix some issues caused by missing authentication
        
        * DAV_HTTP_NOAUTH wasn't actually handled anywhere; treat it the same as
          DAV_HTTP_AUTH for now
        * Content::getResourceType() would just determine that the server
          doesn't support DAV if there is any authentication missing
        * Content::getResourceOptions() would cache authentication error that is
          caused by executing the command without any XCommandEnvironment and
          therefore no XInteractionHandler
        
        Change-Id: Ie319a505da4b0f6bde01d6611262b8b1dad33d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125665
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-23  László Németh  <nemeth@numbertext.org>  [7bc57e698910e24495605bd197a6d3ab5e0be5b8]

        tdf#145719 sw: track moved text in import and ChangesInMargin
        
        Recognize moved text by accessing to the hidden redline content
        pContentSect during ODT import (in the case of Delete redlines)
        and ChangesInMargin mode (Delete or Insert redlines depending on
        Deletion in Margin or Insertion in Margin modes).
        
        Fix Undo and redline stack handling by moving IsMoved bit to
        SwRedlineData from SwRangeRedline.
        
        Note: .fodt format is applicable for the unit test document,
        because it's not affected by the problem.
        
        Change-Id: Ifd4f993520bec4b845d978a844c465509ea87b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125552
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-23  Justin Luth  <justin_luth@sil.org>  [87fafdb9dc045735e235cbba2ef37198043422c7]

        tdf#131150 sw menu: use nSlotId=0 to avoid adding to set
        
        This fixes a regression in LO 6.4 caused by
        commit 86cb2a1f98c0585d2121e6ae34fe62f072ef9a63
        
        Not surprisingly, adding a new condition that multiple
        other items match on caused a regression.
        
        bFlag is always set to false at the top of the loop.
        In the above commit, bFlag was not set to true,
        and so thus it would always be false.
        So just set the SlotId to 0
        to avoid rSet.Put - like so many other cases already do.
        
        Change-Id: I02e9ca9d8dd75db519e801ad0e86fc8d541ae20a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125688
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-11-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [acd820a47e90ceb9404f05dbc9f6c040bd7a9fee]

        Add more beanshell samples
        
        For Writer & Calc
        
        Change-Id: I85815acf11b750ec76d138ff8fe72cc4791e9038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125689
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-23  Justin Luth  <justin_luth@sil.org>  [324daa38a823477e1d1b650b5d91f3dc91c6a9af]

        tdf#129638 print preview: use new paper size after switching page
        
        This is a partial revert of LO 6.3
        commit 2c23a96f7b6888c0e05fdc2aba57f03cd797b647.
        
        Change-Id: I17525d06d96779671caaa84e1e48629289453ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125685
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-11-23  Caolán McNamara  <caolanm@redhat.com>  [1f99fc7f94a27da5e8a00da7e74dc155780a139b]

        gtk3: reuse popover replacement as mouse event widget
        
        Change-Id: I99aa1f1843c5ff6e4c76716178e721a96ae284fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125676
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-23  Stephan Bergmann  <sbergman@redhat.com>  [1040228c356d75c5228cde4d6103f9b446848e4b]

        My clang-cl build does not work with -Zc:dllexportInlines-
        
        Lots of
        
        > [build LNK] Library/cppuhelper3MSC.dll
        > servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl xmlreader::Span::Span(char const *,long)" (__imp_??0Span@xmlreader@@QEAA@PEBDJ@Z) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
        > servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl xmlreader::Span::Span(void)" (__imp_??0Span@xmlreader@@QEAA@XZ) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
        > servicemanager.o : error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl xmlreader::Span::equals(char const *,long)const " (__imp_?equals@Span@xmlreader@@QEBA_NPEBDJ@Z) referenced in function "public: __cdecl `anonymous namespace'::Parser::Parser(class rtl::OUString const &,class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> const &,struct cppuhelper::ServiceManager::Data *)" (??0Parser@?A0x40CCA2FC@@QEAA@AEBVOUString@rtl@@AEBV?$Reference@VXComponentContext@uno@star@sun@com@@@uno@star@sun@com@@PEAUData@ServiceManager@cppuhelper@@@Z)
        [...]
        
        Change-Id: I2cf96b8ce52027fa3c307a0973cdfb91fa990763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125683
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-23  Stephan Bergmann  <sbergman@redhat.com>  [780d786d721674f35efe867b1e5cd5b405dfb63d]

        Fix test for clang-cl with the MSVC template instantiation model
        
        (Otherwise, the FunctionDecl's body was null and all the error and note
        diagnostics were flagged as expected but not seen.)
        
        Change-Id: I32acb6e0028433c9b40545cf91d8fe1acd19a77a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125682
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-23  Miklos Vajna  <vmiklos@collabora.com>  [ed662bcc20804e8b8d5946904f1b577a825f09de]

        PPTX import: implement native handling of a color's luminance modulation
        
        This was already handled in oox/ at import-time: this adds it to the doc
        model, including UNO API and PPTX import.
        
        This is a dependency PPTX export and UI.
        
        Change-Id: I5d875b53d715beb10c13ef616d06cf958d43f70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125684
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-23  Miklos Vajna  <vmiklos@collabora.com>  [cea0b1f894bfd29af5a4f9392d4fb45db9a1a938]

        cui, editeng, sw: WrdStt -> WordStart
        
        Because I'm unable to remember if Stt is Start or Stat.
        
        Change-Id: Ie853c6e94e45c3e14e002a0218d11c61905a3180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125672
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-23  Michael Stahl  <michael.stahl@allotropia.de>  [6c9d853edcb1f76468bc96b2e8d7e60dcfa72c7e]

        tools: fix INetURLObject::changeScheme()
        
        (regression from dc2010964fb8d18d5c4fe96172ee082276a1e587
         which broke JunitTest_ucb_unoapi)
        
        Change-Id: I14a79c3b7d1161234da64822186bcf97d4022264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-23  Justin Luth  <justin_luth@sil.org>  [283586c89a0542efb2d57a36ee3aad7cc5153ed5]

        tdf#138223 oox: don't set highlight color if it is transparent
        
        Probably when this was first implemented in 6.4,
        it should have set a transparency threshold of when to accept
        the color as the background (perhaps at 50%).
        But since this has already been running for a while,
        I only cancel it if it is fully transparent.
        
        No existing unit tests matched this scenario.
        
        I'm not making a unit test because the color really
        ought to be set - it should just be transparent.
        LO doesn't seem to have a character highlight
        transparency capability, so this needs to be emulated.
        
        Change-Id: I7b295894e529f8345cadc9b30bc43598a9a02e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125670
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-11-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e2e7e217e99c3fcb86faeb378849f350a08e21d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2cbbd18d34a7fb8ece9c774cdcb5a2e38fac957
          - tdf#145831: fix typo in PNG
            
            Change-Id: If393a87a9e17615e65b93852c41f0aeb0c9b55c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125678
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-11-22  Caolán McNamara  <caolanm@redhat.com>  [dcc890e3b00ec174f4c752199ec54a8d873aaf8e]

        remove an ugly coverity warning suppression
        
        Change-Id: Id67530f1a7c91e3e4e29974b7b9050c7b1fc159f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [5a00326951690d820d8ea5412a93aadf3da42dc1]

        tdf#143316: sd_export_tests-ooxml2: Add unittest
        
        Change-Id: I7d045d439226c67f479643c71f632a760ad3c2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125664
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [59e70256a358db136f5fd23651aea96d218b1a64]

        tdf#145207: sw_uiwriter3: Add unittest
        
        Change-Id: I1a904f4261f80c2ce709a6e97767c9ba6a71b8f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125662
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [e29d89545eb4c714e6e7c82dbfb780097ee6745d]

        improve method naming
        
        Change-Id: I9a45839f6566caf41ccee2f8d149b4d0c60c3503
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125663
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Luboš Luňák  <l.lunak@collabora.com>  [1a32af4192291ea5cfe7c4c143144a5dab1f156e]

        cache error strings for ScTable::validQuery()  (tdf#133835)
        
        Avoid calling SharedStringPool::intern() on values that are
        repeatedly the same.
        
        Change-Id: I094f2e777a4ca24536e0c25e6a1c6358ccf49f61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125660
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-22  Luboš Luňák  <l.lunak@collabora.com>  [2de99501b7d7b32867d23d4089197e132c6a0526]

        Revert "cache FormulaError::NoRef error string (tdf#144249)"
        
        A more generic fix coming.
        
        This reverts commit b4c1bb2f91e9ae47820c289e2c08f640a958cf05.
        
        Change-Id: Ia7821f1c8585506556708f1bf8526e7f509aafd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125659
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [7ead98eec843e68dcec6c4d5c97a577be7adec4c]

        Use less DegreeN::get()
        
        Change-Id: I97b8d6282c72307cc29a913af221d283523f2fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125653
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-22  Miklos Vajna  <vmiklos@collabora.com>  [2eaf79131dab04acce1411fed1d8ac8ab5c51575]

        PPTX: implement native handling of <a:clrScheme> children
        
        This was already handled by converting them to raw colors at import
        time. This commit imports the color scheme contents (the 12 colors) into
        the doc model.
        
        This is a dependency to export them back to PPTX and to be able to
        update these colors on the UI by picking a different theme.
        
        Change-Id: I177de4f15d5f0e628669998d1cda7db24220b2eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125651
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [5c6c3c0b75a3584258b786c7e9bf8789d31847e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 023b21a704bf0bae904b87907dd72d48d518ac09
          - Document ScriptForge Dispose() method
            
            Change-Id: Ic2ff80cfc2dc987ea7e62d7c216358af279712a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125452
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-11-22  Heiko Tietze  <tietze.heiko@gmail.com>  [899e8f813c559384ba11eb1d4ceafaf29b5e73a9]

        Resolves tdf#145684 - Sort sidebar decks in a more natural way
        
        Effects and Shadow went down, Line and Graphic aka Image up
        
        Change-Id: Ifb921e8b84d6fd18926c3249891c76c61ee6626f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125661
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [c19b6a80da0ba15a53a599732c45faf0bd5a7f3f]

        loplugin:noexceptmove
        
        Change-Id: I2ba1ebb161f4004b819fd106c090fefd8d8af8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Sarper Akdemir  <sarper.akdemir@collabora.com>  [d3651f96d45405d6d142bf97084c377e395945c3]

        tdf#143316: fix datetime footer regression on mso2010
        
        Exports language in run properties of the datetime footer.
        And also overrides the placeholder "Date" text with formatted
        datetime text if the datetime footer is a nonfixed one.
        
        Fixes regression from: 166671f4aa19deec47c10a220ae1d29fa57faa93
        (tdf#59323: pptx import: import footer fields as properties)
        
        Change-Id: Ib888e5cf51ea7e14fb13278e96610051e1e5fe5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124123
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [23a6b9bd988fabeceb58c5367bbb0b11bac1cb9a]

        uitest: sw: make test more precise
        
        and no need to use the for i in range(90) loop
        
        Change-Id: I9b039d49dc74f61289ad11979da1f244ec59903f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125655
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-22  Luboš Luňák  <l.lunak@collabora.com>  [6b2d8e2d88a67d446827ed0ab968f0a06e297d18]

        handle filling and stroking at the same time if possible
        
        All tests still pass, so the end result should be the same, but
        this way it's done in one call.
        
        Change-Id: If5da34837a45ad600ae30568e4ba7651ac5838bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125644
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-22  Luboš Luňák  <l.lunak@collabora.com>  [53ce0e3af4dcb1c70380016b3824da71548cdc60]

        move code to helper functions
        
        I'll want some common extra functionality there later.
        
        Change-Id: I249f9ca4662fc8e8d52c58b1bd33293f363464d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125643
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-22  Noel Grandin  <noel@peralex.com>  [1b327e4a33a2a2c575c247ea90365652d6549852]

        tdf#133835 speedup calc autofilter (9)
        
        Remove the temporary buffer in INetURLObject::setAbsURIRef,
        and just write directly to the main buffer.
        
        This is a behaviour change since we are "committing" bad data to the
        buffer if the URL is incorrect, but since it that case we set the
        whole object to be invalid, that should not matter.
        
        Change-Id: Ic8e7d4027bcb927005edd7de4098f4f525412869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125648
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noel@peralex.com>  [a70bd820da49401e7c233ae254ce954954344d33]

        tdf#133835 speedup calc autofilter (8)
        
        Add move operator to OUStringBuffer to avoid copy
        
        Change-Id: Ifef326449d87aac79f4b1142db7a53faad427580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125626
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [8e34fe50412fd58a600ba1b8238b80444aec02e5]

        ucb: webdav-curl: don't use chunked encoding for PUT
        
        What happens with Nextcloud:
        
         CURLINFO_HEADER_OUT: 0xa028408: PUT .../testB.odt HTTP/1.1
        User-Agent: LibreOffice 7.3.0.0 curl/7.79.1 NSS/3.71
        Accept: */*
        Accept-Encoding: deflate, gzip
        Transfer-Encoding: chunked
        Expect: 100-continue
         debug log: 0xa028408: STATE: DO => DID handle 0xa028408; line 2077 (connection #0)
         debug log: 0xa028408: STATE: DID => PERFORMING handle 0xa028408; line 2196 (connection #0)
         debug log: 0xa028408: HTTP 1.1 or later with persistent connection
         CURLINFO_HEADER_IN: 0xa028408: HTTP/1.1 100 Continue
         debug log: 0xa028408: CURLINFO_DATA_OUT 8357
         debug log: 0xa028408: Signaling end of chunked upload via terminating chunk.
         debug log: 0xa028408: CURLINFO_DATA_OUT 5
         debug log: 0xa028408: Mark bundle as not supporting multiuse
         debug log: 0xa028408: HTTP 1.1 or later with persistent connection
         CURLINFO_HEADER_IN: 0xa028408: HTTP/1.1 201 Created
         CURLINFO_HEADER_IN: 0xa028408: Date: Fri, 19 Nov 2021 16:27:47 GMT
         CURLINFO_HEADER_IN: 0xa028408: Server: Apache
         CURLINFO_HEADER_IN: 0xa028408: Content-Length: 0
        
        ... yes, "201 Created" a 0 byte file.
        
        https://github.com/nextcloud/server/issues/7995
        
        Apparently this doesn't happen with header Content-Length: 8347
        
        Change-Id: I3f38d50530a8b6430b27de2525370e1d95705da6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125579
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-22  Mike Kaganski  <mike.kaganski@collabora.com>  [de4cb026b5fe3ecd1c9557817565cff4ca4e8408]

        Generalize DegreeN
        
        This potentially allows to introduce other degree fractions easily,
        like Degree<sal_Int64, 60000>, with automatically defined conversion
        functions.
        
        Change-Id: Id1c32d9e029943844bdc833178c1f99387ff87fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125640
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-22  Heiko Tietze  <tietze.heiko@gmail.com>  [003b2d0c36c62800257c688c65109bf2fc7d4f32]

        Resolves tdf#145821 - Layout inconsistency on paragrapgh dialog
        
        This reverts expanded controls from patch Icb22f2a9f24852898ab4550bc0cec32732ad32dd
        
        Change-Id: Iac9a0d920193d47976d6a2fc9305c43b09447019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125642
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [4f8fd72846f23688a3d6824cbfba9117a26e9463]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 957baaaa79fc771842444d2fd5df6c9f9383f6d7
          - Document Duplicate/Rename sheet shortcuts in Calc
            
            Based on Regina's comment on bug tdf#145745 there are quick ways to duplicate and rename Calc sheets. This patch documents these shortcuts.
            
            Change-Id: I887018cec48b829b73edd3c593d32f2044d60778
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125450
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [b56e7a74a134aa4e4bd27fe22c1f6ab60c95b08a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e03ef6d09a95251a7e31c03c4df183d80de2f73f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I02ddd433b92c1948b53442dba46480010b275d12
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125614
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [6c377dc4a3eaa5384204af1344006257d1c9e59a]

        ucb: webdav-curl: log headers in debug_callback
        
        Change-Id: I40ed170c2ae8bc769372fa2269dcf1f1643000de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125580
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-22  Johnny_M  <klasse@partyheld.de>  [acee9aa28e93945aa5f9b1a8497f296a53b3a72f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b0391082f22e06d38c17beb241852f7f6dc1ceb4
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibff67e3a6e819d998acd81d48cc8487423912df8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125612
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Michael Stahl  <michael.stahl@allotropia.de>  [4d75e29b3bba8a4002231dbc507f79ea63dccd82]

        Revert "The CurlOption curl_off_t case appears to be unused"
        
        This reverts commit 20168b1f09b4d2aa8643dc7d4a16d8a1dd1008a6.
        
        Change-Id: I3ac7bdeece94ec2a0e01d67f2788874b3f286fe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125578
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-22  Johnny_M  <klasse@partyheld.de>  [3c62f72d7eda7a2d377cf45490c8c67403d8d745]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4f86b98f4852a3590208a5ba0183b0767b2340b0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I43001aefdeec0ac4f43f1b0a7274116dbc87b76a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125613
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [f1c0f123c3e98cbe01d2f79ffdc5b2bbe30a8de4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f3dfd46d61bd8ee5ae04b35056f95117cc472c5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I544d292737aff83158bcfe46cdbef715e4a5ca33
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125609
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [2aba4fb6bbe4030724feb4cd8bf266f4ebd31eda]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cb389072da48f9712f8100ac8e88656604106ab5
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Idced60ec26d33644833e758886da95b9b12596eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125611
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [186cdc22eee94a6f9ed9c7c2b8b0a7f6657ac5bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 649d6ca20c8e574e86a25318510b4ba611da94c3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2c676d21d8b78ca1f5307904508bbd620724ddfd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125608
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [d09492732e6b814b5d777b990461049ea08c6ada]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 430875f024037702e09291ee48c6dec481ad40c5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I10ce80babf0e191f854f151a480d3340bf2eef0f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125607
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [916fec758b6ccf34fb9cad91ee6cc1686497c1c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 598bf0b1deb8a4e0795a79c78001a10d3b262e87
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1e582772a69cca77716f270b243bf8f73b173dcd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125605
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Johnny_M  <klasse@partyheld.de>  [adb5ab8fbefcd851ae1f897ff8c2bf51b21a30d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a6e8b1dcb95877d2d03586482e70e96f276961da
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6ec193b5e751a9f1ceab602ef88582d01457fbb3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125604
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-22  Justin Luth  <justin_luth@sil.org>  [fbda2f3b7b47021a140cbfd3288aa7de1b42e1fd]

        tdf#132470 tabbar: revert back to bold font on visible tab
        
        This is a partial regression to LO 6.3's
        commit fad98c8641342a77241124dd98e0cb781daef4ad.
        
        The current sheet is always selected, which is fairly
        distinctive. However, it is possible to select
        multiple sheets, and the current one should be
        distinctly marked to differentiate it from
        the other selected sheets.
        
        Change-Id: Ib160535cccebcfcabee94d17e5941cc3cd23bb15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125601
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-22  Dr. David Alan Gilbert  <dave@treblig.org>  [4c577a0ada8c47483fb8a80a97478ffd3e2b37d3]

        pszctrl: cppcheck undefined shift
        
        cppcheck noticed that the shift in:
        
            for ( sal_uInt16 nCheck = 1; nCheck < 32; ++nCheck )
                if ( nCheckEncoded & (1 << nCheck) )
        
        is undefined since 1 << 31 is implementation defined.
        Make it 1u, and the others around.
        (Not that we define bits that high, but we are explicitly checking it)
        
        Change-Id: Ieb780ac999af71df2b48ce64daaf4b2878162e35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125016
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [626296cb6cb1e81d40b9554fb6f15b8912d410ff]

        osl::Mutex->std::recursive_mutex in LanguageTag
        
        Change-Id: I75e2d0b78ebf4390ed67d94eb1021145f245fe50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125631
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [ef1e087dc94cf83b293e05e2cacbac69fa92bbdc]

        osl::Mutex->std::mutex in MimeConfigurationHelper
        
        Change-Id: Ib9a628d42448aea858271094ef5bdaac022b0f21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125633
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [2d073a759f77f80b44180eea32ba7131ad37b0bd]

        osl::Mutex->std::mutex in OPropertyArrayUsageHelper
        
        Change-Id: I4fd784f291fd6606b25520e3f08aa8692132e997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125634
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noel@peralex.com>  [a6ed7588114c643a4d4821201e81b149e3429f2c]

        tdf#133835 speedup calc autofilter (7)
        
        vcl::Font avoid allocating a new instance if the setter doesn't
        change anything, saves 5%
        
        Change-Id: I461a2a8e3709b3f3f20e431cb3b976ad47bed0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125625
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Caolán McNamara  <caolanm@redhat.com>  [131c1c7da8c567636ca55751e49d24cb6d6c9b9e]

        Related: tdf#145786 cooperate between our own grabs
        
        don't try to workaround a grab if the grab is done by another
        of our own popups, and on tearing down one of our popups, restore
        the grab of its parent if that parent was one of our own popups.
        
        This typically matters on X where we don't use GtkPopovers (unlike
        wayland, where Popovers can escape the parent window). Things to test
        are:
        
        writer's watermark dialog: click the color button to get the 1st level
        popup, then click the combobox to get the 2nd level one, select an entry
        to return to the 1st level.
        a) Clicking a valueset element should select that color, not dismiss the
        popup without selecting a color.
        b) Clicking the combobox to get the popup again should result in a popup
        where the focus still follows the mouse (i.e. the 1st level popup
        doesn't try and steal away the 2nd level grab)
        
        sidebar: same scenario as above, except a color popover parented to a
        sidebar pane and not a dialog.
        
        Change-Id: Ib5d765b22b8a9b6b1a7806676c8fe3cfb7709734
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125638
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-22  Caolán McNamara  <caolanm@redhat.com>  [873e4d30e37a23da74b2bab7914196d1f0a9a772]

        gtk3: popover replacement for GtkMenuButton has to be modal
        
        Change-Id: If1b18c4b39fbe82fd613ff0f62f0ff60fdaeeed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-22  Miklos Vajna  <vmiklos@collabora.com>  [e6b75a22dfbf81b6eca628384ae1c4bc499c50a3]

        sw: prefix members of SwDBManager, SwWebGlosDocShell, SwWordCountWrapper ...
        
        ... and SwZoomControl
        
        See tdf#94879 for motivation.
        
        Change-Id: I74f31e45a8c215d406371a23b64d548fbb851d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125641
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-22  Hossein  <hossein@libreoffice.org>  [7b0f5178d81e2673345f88abec2e5656f841627e]

        Cleaning up math in SvgNumber
        
        * Simplifying math expression
        
        Change-Id: Ie67874eb79879186a1b971fbdc2c02945bae9191
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123092
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-22  Michael Meeks  <michael.meeks@collabora.com>  [4eb4057ab3b960767d7d6cf8208ecf4edf734324]

        Crash when fetching clipboard data.
        
        Seems like some unusual corner-case around HTML export.
        
        	sw::DocumentContentOperationsManager::CopyImplImpl(SwPaM&, SwPosition&, bool, SwPaM*, bool) const
        		/sw/source/core/doc/DocumentContentOperationsManager.cxx:5068
        	sw::DocumentContentOperationsManager::CopyImpl(SwPaM&, SwPosition&, bool, SwPaM*, bool) const
        		/sw/source/core/doc/DocumentContentOperationsManager.cxx:4609
        	sw::DocumentContentOperationsManager::CopyRange(SwPaM&, SwPosition&, bool, bool, bool) const
        		/sw/source/core/doc/DocumentContentOperationsManager.cxx:1936
        	SwEditShell::CopySelToDoc(SwDoc*)
        		/sw/inc/pam.hxx:193 (discriminator 2)
        	SwFEShell::Copy(SwDoc*, rtl::OUString const*)
        		/sw/source/core/frmedt/fecopy.cxx:224
        	(anonymous namespace)::lclOverWriteDoc(SwWrtShell&, SwDoc&)
        		/sw/source/uibase/dochdl/swdtflvr.cxx:413
        	SwTransferable::GetData(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&)
        		/include/sfx2/objsh.hxx:866
        	TransferableHelper::getTransferData2(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&)
        		/include/com/sun/star/uno/Type.h:121
        	TransferableHelper::getTransferData(com::sun::star::datatransfer::DataFlavor const&)
        		/include/rtl/ustring.hxx:438
        	getFromTransferrable.isra.0
        		/include/com/sun/star/uno/Any.hxx:151
        	encodeImageAsHTML
        		/desktop/source/lib/init.cxx:4382
        	doc_getTextSelection
        
        Change-Id: I1af52d827ebdc9bbc5278f56547d1b3fd1b87e7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125454
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [c36a21e4a3ee788b14b6925de585805556959800]

        osl::Mutex->std::mutex in WindowCommandDispatch
        
        Change-Id: Ia89f4a7b1f444a031e8f58f644ba9129f8c48942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125622
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [16289b6de6ba37c7008fb198260517f3bc505bf4]

        osl::Mutex->std::mutex in XFrameImpl::windowShown
        
        Change-Id: I1e56d0931a6e814cb9a4faa6a06e70b3740cb728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125628
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [9b0ea78959f6bcbc1a776c505352ab37e91381ad]

        use more OInterfaceContainerHelper3 in ContentImplHelper_Impl
        
        Change-Id: Id4e4fca8a5a4e2d050752e666a843e7d8661ec0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125635
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [b67257c5dc54b37495a755005192e4cf186aef25]

        osl::Mutex->std::mutex in GlobalSettings_Access
        
        Change-Id: I5162a157fd07870bf768947b32e8afe8f1fb0a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125629
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noelgrandin@gmail.com>  [60e185446eef9c4084b22901f1ffb41b36628b6e]

        osl::Mutex->std::mutex in TransliterationImpl::loadBody
        
        Change-Id: I15441110bf27c3f2ad9a61389339c55b9c4c3bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Noel Grandin  <noel@peralex.com>  [7805a224b96897807e49fd49dd5276d6089b0b5c]

        tdf#133835 speedup calc autofilter (6)
        
        INetURLObject::SetPort Avoid allocating temporary string on heap,
        saves 20%
        
        Change-Id: I61ba4bd80c561266341143e35650b54b9d70f1d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125624
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dc50ac6f7179e1c447a43de256e6ffcf8694c06f]

        Removed duplicated entry in Korean autocorrect
        
        Change-Id: Ibc640574517da486af8b35e736a45c1adcf78434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125639
        Tested-by: Jenkins
        Reviewed-by: DaeHyun Sung <sungdh86+git@gmail.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-22  Hossein  <hossein@libreoffice.org>  [6e7f06c297b3bd7f57797158c55ed0e11fe14317]

        Convert #define to enum
        
        * Converted multiple symbolic constants using #define in wmfreader.cxx
          to enum
        
        Change-Id: Ie55f27414c230cd624cacb805897933707244ed6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122734
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7b73163e6d8aca1b4a55547a4f337f36b9697b87]

        Removed break after return
        
        Change-Id: I0ad0ae7074905075cdff46ded69eaaa07570f0ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125075
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-21  Caolán McNamara  <caolanm@redhat.com>  [2221c6ffb3e8fffb090d1d1a666571c3c7d05de7]

        gtk3: consider replacement for popovers visibility when queryed for it
        
        Change-Id: I4ca71f8544720e99514abe78717dcd07617c00cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [449977192b04878a2e3ea0ce1ff3445d02f084ce]

        osl::Mutex->std::mutex in ActionLockGuard
        
        Change-Id: I8081d017f8a03be94b60011fcd4eb34eba786aa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125623
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [d54a1380d13d8d832841cdc33440aac2e14d3300]

        osl::Mutex->std::mutex in ConfigurationAccess_FactoryManager
        
        Change-Id: I0e7a6eb4700e1108b31dfdf8681e8f4743ab7c5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [c33b0e928e07387bf60708be3f3dc07d9840663c]

        osl::Mutex->std::mutex in ConfigurationAccess_ControllerFactory
        
        Change-Id: I2e526ff2dc9f02850bd9fc510c63b5d9db24af58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noel@peralex.com>  [dc2010964fb8d18d5c4fe96172ee082276a1e587]

        tdf#133835 speedup calc autofilter (5)
        
        Tweak INetURLObject to reduce the number of
        OUString and OUStringBuffer we create,
        saves 5%
        
        And add a asView() method to OUStringConstExpr,
        to make it easier to pass to OUStringBuffer::insert
        
        Change-Id: I115ec2398cfc8df39bd1efbbd5f0d5cc9712dba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125600
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [efd95650cba2460bc153de00f8eb27785ad0e18a]

        osl::Mutex->std::mutex in framework::ConfigAccess
        
        Change-Id: I44d41db2498ea39fca309785278c1fe50d7ae8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [c3b968a2f1e8e824ace86c37d0e500440374bd09]

        osl::Mutex->std::mutex in StatusIndicatorFactory
        
        Change-Id: I2365e172ef8d631f30cfffdb650ebcb3035f77f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Harjot  <harjotsingh20022001@gmail.com>  [805fd18d934c7323f678eb4df2f4b770ea8184f1]

        tdf#143148 Use pragma once in i18npool
        
        Change-Id: Id67d8926fdc1616add1bd9de051911b2aae030e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125419
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [7ef421dbfbfd486f235a7c5bdbd856b8ee9d62ea]

        osl::Mutex->std::mutex in configuration_registry
        
        Change-Id: If5561d6532716bfe3151f555a691aa5188264a1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noelgrandin@gmail.com>  [b28fdd1a15b4c7325d760e613bdf67c4cdd77605]

        osl::Mutex->std::mutex in OLockListener
        
        Change-Id: I391de15296932ea65f2335b0df7a76e2f77a1a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Noel Grandin  <noel@peralex.com>  [0b46361ef84a61100a0274a007062317607d097a]

        tdf#133835 speedup calc autofilter (4)
        
        Tweak INetURLObject::parseHost so it doesn't need its own
        OUStringBuffer, and can just use the callers'
        Saves 5%
        
        Change-Id: I481fabd4272bc9f172dd751a7019090b95a65e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-21  Jim Raykowski  <raykowj@gmail.com>  [437d5a446733aca0a485218f29d8d7dcea4d3999]

        tdf#145207 Check for drawing object before Table to handle Tab key
        
        to fix crash that can occur if done the other way
        
        Change-Id: I378aa8444906d56647ab4fdde26d4ff1c9f511f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125435
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-21  Ming Hua  <plateauwolf@qq.com>  [52b9a1fdbbd829604b483881fb23ce30251f806c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bff7df37fa8a6303ef5fe4f10085ef635be3a95
          - Related to tdf#141869: Update help for inserting cross-reference
            
            ...to match the UI changes made in commit
            81472692c4ee0b12c6d2184823faefa7a53431e6.
            
            Change-Id: If09e850fe769a1475e92f7605399316d74af95df
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125534
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-11-20  Kevin Suo  <suokunlong@126.com>  [918b62bea6cf82ce952c8d225dcabd4d08a2abf7]

        Change aboveWord and belowWord for Simplified Chinese locale
        
        Per Wechat discussion by our Simplified Chinese l10n team.
        
        上方 and 下方 are written languages which are more suitable for
        cross-reference context, while 上面 and 下面 are spoken languages.
        Also in this way they are consistent with MS Word.
        
        Change-Id: Iccf8c330b2e5a04be3916b810a29ea0d62f26225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125533
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-20  Mihail Balabanov  <m.balabanov@gmail.com>  [7193ed4401e98a6b5154d4718a3ca4761fe28c45]

        Fix the above/below words for Bulgarian
        
        Change-Id: Ib81da535411b07596785b06d7a5dac36a8a2ee28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124704
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-20  DaeHyun Sung  <sungdh86+git@gmail.com>  [69db2d21a71c1851b93ced42d663d409dc3039ed]

        tdf#135727 add autocorrect lists for Korean Language
        
        Add autocorrect lists for Korean Language.
        Submit the Korean autocorrect lists as the result of Hacktoberfest 2021.
        Link: https://github.com/libreoffice-kr/autocorr_kr/blob/master/DocumentList.xml
        
        Change-Id: I6d0ca38581a21c59b98e96045bb6d091c8c89bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125548
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-20  Caolán McNamara  <caolanm@redhat.com>  [0cc2a8e89372e6a2c7e05b8a18a9fd2b2c71483b]

        cid#1494386 Dereference null return value
        
        Change-Id: I3dee29c68166c88bce30d2c88a6684be43f8e717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-20  Johnny_M  <klasse@partyheld.de>  [15595966321c0d09929d85acf772e30bd007b300]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 45533ee580bb1dae59847fdce7ff269b4b7b3709
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9ff9645bb3283ac824bc663897d40d2fbe43a931
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125596
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [1e151da05ae09ca66878289934a4c94f1ff23f28]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c7ee29857fd322080dac8e99151d31be991d0b3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I71d7f73845bc57e3a1bc9acdaa8a8aa630e8351e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125595
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [a870bab1bd91b34150647a88eb6f1595c79035ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3fcc169054a340ed3dbea4cd8905b2015417a23
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1a45b29e40b1b1ba90258e20a2d909688bd0e302
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125593
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [a1c8ad8ded838ea0a22e637eecf05a6d4995133d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2667e50e6435579443057d55cc7a57f674f543ae
          - tdf#132643 Translate German section IDs
            
            Change-Id: I13bcfce76d858630b40c6c39566c0015c3ee470a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125591
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [21e4e5fa68c5610fe3d2e11ac62d86c616341e85]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f0c493cddde7a30c5af42a1d895d05c1efed9d2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4a2f4422276d2944dcffcce597c7a4a013c3af6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125590
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [d63f182977e0b3495132d4dc262e75369987f341]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5628bb0f03d71e6a30ce93ce966962c42d0abc76
          - tdf#132643 Translate German section IDs
            
            Change-Id: I019ee515a93f3c9159a4b5d40b46a3568d72c61c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125589
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d88bd04812f298fe9da6be1de60bb23ee64f0832]

        Fix typos
        
        Change-Id: I21161022d1b1e09eeccd39169577992c2ec2d47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125586
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9b431a9b5532448765908c192225556b16a5d79f]

        Fix typos
        
        Change-Id: I3db97c20af3815a366d93454c8fc66cf8bdd848e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125207
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-20  Johnny_M  <klasse@partyheld.de>  [0b505dfff45c1fafc5b8894916e9a611cc5155f7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a4d192693f92434fe8f92c745a15afc1e09b77d9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8fea2f205848348c38e507b9169dc7ca434b3b7f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125588
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Johnny_M  <klasse@partyheld.de>  [59b133f4a1a8bbeaad3debcab9ff9f39e5264518]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aec63dfd1ff1016d64554ab7e804fa1580a71f77
          - tdf#132643 Translate German section IDs
            
            Change-Id: I753cfdd055ec5ef372c0ec3f7f7d015b487dbc50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125587
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [93bfbc10ce93e5b9c581897d331fcfb060ff112f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a28022898ba228175a451c17a42f65cce039235
          - Fix typo
            
            Change-Id: Idb3cc8605c7d9a4e8c2ab6eed54805cf52850595
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125585
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-11-20  Caolán McNamara  <caolanm@redhat.com>  [61b806b28b6c7e49fb5e153e0ea589a020191f25]

        gtk3: don't double close popover replacement
        
        Change-Id: Ibdd7de56ab1cadd76748422c08e21904f912532a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125567
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-20  Jim Raykowski  <raykowj@gmail.com>  [d3adc15ba3091fea5a90b654ee667b25797501db]

        SwNavigator: Check for graphic, frame, or ole types before entering
        
        the block that handles these in UpdateTracking
        
        Change-Id: I4b435351133b28f1fc34e2733a9d453de5c117a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125508
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-20  Justin Luth  <justin_luth@sil.org>  [823a351adb0384598304d597ae7f637079ca6175]

        tdf#118776 drawingml: treat XML_nofill as (mostly) transparent
        
        100% transparent typically ends up as COL_AUTO which
        certainly doesn't do what is intended.
        So set as 99% transparent to get effectively
        the same invisible effect.
        
        Adapted patch and re-used unit test from an earlier
        commit authored by Xisco. This depends on tdf#137438
        not spamming the text properties with outline props.
        
        Only one existing unit test that matched this condition:
        -export-tests-ooxml1.cxx customxml.pptx
           -empty textbox - text entered here SHOULD be invisible.
        
        Change-Id: I077b748e500713188421f0eeefdfd85c46555e84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125301
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Justin Luth <jluth@mail.com>

2021-11-20  Julien Nabet  <serval2412@yahoo.fr>  [2d445f90dbecf8d2240474dcb06084868ceb921a]

        tdf#145714: teach "mediumblob" to Mysql/MariaDB part in LO
        
        also teach about:
        TINYBLOB + LONGBLOB + TINYTEXT + MEDIUMTEXT + YEAR + BIT
        
        Taking a look at libmariadb, I see in libmariadb/mariadb_stmt.c:
            535   case MYSQL_TYPE_SHORT:
            536   case MYSQL_TYPE_YEAR:
            537     int2store(*p, (*(short *)buf));
            538     (*p) += 2;
            539     break;
        
           1208       case MYSQL_TYPE_SHORT:
           1209       case MYSQL_TYPE_YEAR:
           1210         stmt->params[i].buffer_length= 2;
           1211         break;
        
           1313     case MYSQL_TYPE_SHORT:
           1314     case MYSQL_TYPE_YEAR:
           1315       *stmt->bind[i].length= stmt->bind[i].length_value= 2;
           1316       break;
        
        Change-Id: Id72056429d5d2f2741063ee28b2d2e3c75e378a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125472
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [653c5d2ca1cc777d3556348b65ded0eaae95a414]

        tdf#121546: sw_uiwriter3: Add unittest
        
        Change-Id: I10d1d9a06c04e810b90da9184d5a52f278015fee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125566
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-20  Hossein  <hossein@libreoffice.org>  [9f3271297e7ce980fdb09a063ce51435314066f6]

        Use C++17 hexadecimal exponent floating point literals
        
        Using new syntax for the power of 2 exponent instead of using shift left (<<) operator
        
        Change-Id: Iaa627800fb35af37a6b0efcd939f1d5f78f70e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125458
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-20  Mike Kaganski  <mike.kaganski@collabora.com>  [6d528515c5ed809da7ecfe27d105cfb173c9f768]

        Don't loose scanned image's resolution precision
        
        Change-Id: I526dcf8db880615308cfb228eaa06d1a5a0e5cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125584
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-20  Mike Kaganski  <mike.kaganski@collabora.com>  [867abf5b8eff8733dd7ad020d16724ed8eda3885]

        Drop unused variables - again
        
        This re-instates commit a339ebca55f53db5f0b72b26fcfbb3aaa2b2a825
        "Drop unused variables", that was accidentally reverted in
        commit 1b6e3efe964eec9110e656a8242f6f4d8b5e7f7e "Simplify
        m_aAppId initialization".
        
        Change-Id: Ib65500cc0b0b5c27425f76e358f2d786a7faac09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125583
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-20  Jim Raykowski  <raykowj@gmail.com>  [40b40b74aae7e2a98dc964286baf499ecd1ae10b]

        SwNavigator: fall thru to outline tracking when section tracking is off
        
        and the last GotoContent is not the current section
        
        Change-Id: I762163f82f2a376f04ce6fcb1c001fde6544e84d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125510
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-20  Noel Grandin  <noel@peralex.com>  [2aa7aa564f8c8f7d1cd520b3e2d198a17e423a37]

        tdf#133835 speedup calc autofilter (3)
        
        Tweak INetURLObject::parsePath to avoid an OUStringBuffer copy,
        saves 5%
        
        Change-Id: I49eff3443f34971b8ce15f4c1ab6c9395ee0690f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-20  Hossein  <hossein@libreoffice.org>  [aadb472a6d37d57279f91038f28047af4278bbbc]

        Use o3tl::convert
        
        Used o3tl::convert on nXRes and nYRes to calculate biXPelsPerMeter
        and biYPelsPerMeter for the bitmap information header structure pBIH:
        https://docs.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-bitmapinfoheader
        
        The values of biXPelsPerMeter and biYPelsPerMeter are always ignored
        by the GDI when loading the bitmaps, but in theory they can be
        recommendations for the pysical size of a bitmap in some applications.
        https://devblogs.microsoft.com/oldnewthing/20130515-00/?p=4363
        
        Change-Id: Ia40f17b7d1c27c094158af89bf15ed2f11bdfc05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125109
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-20  Noel Grandin  <noel@peralex.com>  [23886b0e023bc27e9ba89f9ab6d1bdf36da022ab]

        tdf#133835 speedup calc autofilter (2)
        
        Tweak ImpEditEngine::SetRotation to avoid doing work when
        nothing has changed, saves 10%
        
        Change-Id: I10db2415278908e9e36491950a5f4826e01f42fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-20  Noel Grandin  <noel@peralex.com>  [66317d3aa5ada5b7c5ea317590730f563bebb77c]

        tdf#133835 speedup calc autofilter (1)
        
        avoid a copy in INetURLHistory::QueryUrl, saves 10%
        
        Change-Id: I662a4e48f198e61f1cef52b1e920613bce9c9766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125563
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-20  Noel Grandin  <noel@peralex.com>  [b692c8a2809666012084b9e25242c382d7323f72]

        small optimisation
        
        avoid malloc in the common case
        
        Change-Id: I3820065c2b070eddf7cfcba117ec1be73735957f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125562
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Rene Engelhard  <rene@rene-engelhard.de>  [214fa233338c09156c67f85818b6a2ea6b3235bd]

        add with-system-abseil/with-system-openjpeg for pdfium
        
        Change-Id: I270cbb75cde2a44416b61978b8eefdf267720031
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125559
        Tested-by: Jenkins
        Reviewed-by: René Engelhard <rene@debian.org>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [04c5aef876dc4dbeff96f772254b6a7edb6d8433]

        add placement to Popover popup_at_rect
        
        Change-Id: Iaa12a48f62037dd985d526993a07762b10bd0cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Rene Engelhard  <rene@rene-engelhard.de>  [2ed0c2f7ce1ac80dd0315043eb656fff41f24bfc]

        fix gtk4 build
        
        res is only defined if NDEBUG is *not* defined. So it doesn't exist in a
        "standard" build using -DNDEBUG and shouldn't be used.
        
        Change-Id: Iebae9898d50030f994a7289e2bc3fe3052172dee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [13ff493f1d7bf9ba4681ff62f7f7020925306a2d]

        Use toRadians on Degree10
        
        Change-Id: Ib0a53f1dd9c7dd2011041c1c8a6923a64ff6d0f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125581
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [2a605bdd156ff047d722abeef0dcdf029f36ed30]

        uitest: sc: Add UItest for the Save to CSV dialog
        
        Change-Id: Iddf617a02697c30e195d1de94fa064adf5b2d7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125560
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [7ff2c9cfc5fa8c261b1f7f959172f60255fcf617]

        Use more basegfx::deg2rad<N> and basegfx::rad2deg<N>
        
        Change-Id: I9dc57628b98f67994d546f6887e96389be1efe62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125568
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [f8790b1d586b3865cfdc56e8f4cdab55a8617769]

        uitest: better use execute_dialog_through_action in these cases
        
        Change-Id: Ic2317db908afc12973624034f29c1de6f4efd60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125561
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [e3c8de29dd9e947599a8f8991c1597b8fe263d1a]

        Use more precise value for M_PI in OpenCL
        
        No idea if that would make actual difference, but it simply looks
        odd that we use such a value, in view of all other efforts to improve
        accuracy of rad<->deg conversions.
        
        The value is used that is already present elsewhere in the code, e.g.
        in sc/source/core/opencl/op_statistical.cxx.
        Change-Id: I098f2bf748670e3250035d74d1bf7d1e224dd66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125557
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-19  Heiko Tietze  <tietze.heiko@gmail.com>  [1833cb7aa9d8cc3e172c59f8dc25cd4ca6622a50]

        Resolves tdf#130895 - Edit Bookmark Entry dialog too tall
        
        Introduced a scrollwindow behind the fields
        
        Change-Id: Ic32d85d196a73594868f4268a76f783e3d0bea07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125551
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [50affeebd9e631a63708e55674ca2e16ae568178]

        gtk3: treat standalone GtkPopover similarly to the GtkMenuButton managed one
        
        so do the same replacement with GtkWindow under X11 for gtk3 that we do
        in MenuButtons for the popover with direct popovers when the constraint
        is GTK_POPOVER_CONSTRAINT_NONE
        
        Change-Id: Ia903b24c54e6d3acc18df1ab912600e07b7f844d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125543
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [bc0ab08634f59e1a1814e575fe6ad5e50bf1aee1]

        Drop F_PI1800/F_PI18000, and unify deg2rad/rad2deg conversions
        
        Change-Id: Ib89b00c3dc8cd440e8a88906eea133becd1cef64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125509
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-19  Stephan Bergmann  <sbergman@redhat.com>  [168ae4c00a86b7534dedd303f9ef008e19822b99]

        Fix --enable-online-update
        
        ...after 4bc44490f51f7cc4a36cc7131137018da986c293
        "loplugin:stringliteraldefine in tools"
        
        Change-Id: I0ec1e07b151e853be8a795c7135aecf5c6957eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125556
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-19  Michael Stahl  <michael.stahl@allotropia.de>  [a8beb8c08886ac6eef7fcc6a8881a77156e05d4e]

        sw: DOCX export: use list's indent if paragraph is not counted
        
        Writer/ODF has a feature to have paragraphs in a list without having a
        list label, but they do take the indent of the list level into account.
        
        Word doesn't appear to have this feature, so the export forces such
        paragraphs to refer to a non-existent numId 0, so they are not part of a
        list.
        
        Take the left indent from the list level and write it into the pPr.
        
        Change-Id: I8ad56e51e2d4dfd691e3c38532f1a824f5276fd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125555
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-19  Miklos Vajna  <vmiklos@collabora.com>  [32ae1ed7504d58f9216593cb87f25c480a0e623b]

        PPTX import: handle <a:clrScheme name="...">
        
        We had doc model for this, but the UNO API and the PPTX import was
        missing.
        
        Change-Id: I199e9cc235a783d91700ce74f17d442f41d3c3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125532
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [13aa5081793f133077610cd01b7f01ee765b4add]

        remove unused defines
        
        Change-Id: I1140d7dc2f40dafcba6a314c7a641c3b2d886af4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [52d199b364bf65168e5e43b039e6036b87d37403]

        gtk4: GtkPopover parent must be set before its shown
        
        Change-Id: I6184422b92d3629f31141215bed588400b30289c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125542
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [a59b5f9e80c382a74085f93601de3cb0a6b9e174]

        gtk3: use GtkPopover default for selected cases that are within a document
        
        and where inability to escape window under X11 hasn't been a problem to date
        
        Change-Id: I14aa5fe2cf443b6214aed48266d5bd32b8b9c700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125541
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [fae7fd3d193393e4e75ed426b9198925490dc3e4]

        gtk3: default to an explicit constrain-to for Popovers
        
        with the intent to do the same replacement with GtkWindow under X11 for
        gtk3 that we do in MenuButtons for the popover with direct popovers when
        the constraint is GTK_POPOVER_CONSTRAINT_NONE
        
        Change-Id: I629c30b44a9e362ba0d924bb229930b5f0dc7ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125540
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [2337bd5f0d9977a0ecd110abdebea7f331d360df]

        tdf#136551: sc_subsequent_filters: Add unittest
        
        we can use the file from tdf#134867 to test tdf#136551
        although one bug is in calc and the other is in writer
        In the end, the problem is in the sax parser when dealing
        with files bigger than 10Mbs so the problem is not
        specific to one component
        
        Change-Id: If366626b386c592a0b780692a951b27a3e5cdbe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125538
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-19  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [8c715d513eefaf619bf366add8aaf7f6dca15615]

        Qt set QPainter AntiAlias hint from SalGraphics
        
        Change-Id: I1a9e6014ead24b6edff1dbb41b70c809204d01cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125549
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-19  Justin Luth  <justin_luth@sil.org>  [894a01640a838c9affed7cccccc7378a452139b5]

        tdf#137438 drawingml: separate outline from text import
        
        By ignoring the a:ln group, the contents in that group
        (like transparency) were being applied to the text.
        Well, it should only apply to a line around the text,
        which LO isn't doing.
        [Well, LO can do this as Fontwork, but perhaps that
        doesn't match so well with text in shapes generally?]
        
        At any rate, don't allow one group's settings
        to override the others. Keep them separate and then apply
        a bit of merging logic to try to achieve the best look.
        
        So emulate a little bit. If the outline is not very
        transparent (less transparent than the main text)
        then it may (if thick or opaque enough) dominate
        the text.
        
        For simplicity (and because there is no right answer overall)
        I just compared transparency and used the more opaque colour.
        
        Unit tests potentially affected:
        -export-tests-ooxml1.cxx: tdf100348_FontworkBitmapFill.odp -> PPTX
           -now imports black instead of yellow (MSO sees gradient colors)
           -so previously completely wrong, and now perhaps even more wrong?
        -export-tests-ooxml3.cxx: tdf114848.pptx
           -shows blue text regardless - defined by area.
           -can't see where this is set in MSO2016. Perhaps illegal?
        -  : tdf125573_FontWorkScaleX.pptx
           -no visual difference. Same as tdf100348, but with black outline.
        -  : tdf119087.pptx
           -should be green, not purple. [Added test for that.]
        -  : tdf143315-WordartWithoutBullet.ppt
           -no visual difference (COL_AUTO outline?)
        -import-tests2.cxx: tdf129686.pptx
           -poor test usage (but also weird transparent default).
           -no visual change.
        -ooxmlimport2.cx: tdf143476_lockedCanvas_position.docx
           -no visual difference. Irrelevant since we can't RT
        
        Change-Id: Iff0d95506dd64825444a99e62a6c2bd5e1dc122f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125300
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [31ed4c70b027848710a3dc911ff5a7ac18a97047]

        loplugin:stringliteraldefine in vcl
        
        Change-Id: Id14cc8613fdfb67790efd6c33ee243f6bdb522f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [5078e83d88a08881661a18636f38e8951cdda676]

        loplugin:stringliteraldefine in svl
        
        Change-Id: I49a8062c30bdce5b0d9bd27e421d85ba61d5592e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [7e21785380f39f0fe53e06bafa3e5395f7f6e8b6]

        Change About LO dialog to run async
        
        Change-Id: I7255a8510e4cf983ebab477cbdb7cdcf00dabc98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125512
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-19  Jan-Marek Glogowski  <glogow@fbihome.de>  [de5bf7f88026310866a5a4901ac1b46424a73571]

        Reuse macros for AbstractDialogFactory_Impl
        
        Now that all the abstract dialogs are welded, update and rename
        the existing boilerplate macros, to cut down the C'n'P code size.
        
        Change-Id: Iff8f452ca3dfce9a63c4fb73ab3a5025566810e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125511
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [2fe77d0ed8c7c6f2ea0374e0c003ae6280fd591c]

        rtl::Static->thread-safe static in unoxml
        
        Change-Id: Icb458f9ba38225aef17a2421533be79c6d9445d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [4bc44490f51f7cc4a36cc7131137018da986c293]

        loplugin:stringliteraldefine in tools
        
        Change-Id: I348b9a844c009f9c19301baa76d31b12f67c6130
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125535
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [d7dbc5fd426a7f2dfda74e281bef7d3a87598203]

        gtk3: take default modality from the popover it replaces
        
        Change-Id: I0404dc17bd816a7dd403c50692f4f5325aacaf31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125503
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Tor Lillqvist  <tml@collabora.com>  [c5a72ac64ff11d245f80bee2e743548d10319e04]

        Upgrade to un-deprecated API and fix a crash in the pasteboard.mm helper tool
        
        Change-Id: Ic0b839df686fb93c64ef844848028ded39225ced

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [c705a5a65c88f11c197af19a6586175dc7ddc3c6]

        gtk4: remove constrain-to property
        
        Change-Id: I18f0b72fff31f555873a0808f171e4c1746a4411
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [addf580c2846e8de6457c9e710faedd3f0a7a7de]

        loplugin:stringliteraldefine in linguistc
        
        Change-Id: Id347daab7aa21ce8756dbc2d139ac022fc22be3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [bcf601f53ca50460e973a7ad8725aeed33170b2e]

        rtl::Static->thread-safe static in vcl
        
        Change-Id: I748c3b5608b76b4b847273856f6b1c66b53aced1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [38ef2cb092100d03fbef2c05a36526802d06ebaf]

        loplugin:stringliteraldefine in i18npool
        
        Change-Id: I8a56d5d6d201ac5ae65dc46ef4838a0e41af587e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Hossein  <hossein@libreoffice.org>  [9cad66da644e1721f9a49c2b5fffd86da08f78c5]

        Cleanup locally used variables in Calendar_hijri
        
        * Some variables that were only used in the calendar_hijri.cxx
          are now moved out of the header file, and they are no loner
          member variables of the the class Calendar_hijri. They are now
          placed in the the i18npool namespace.
        * Removed unused variables SynMonth, EveningPeriod and LeapYear
        * Moved a global variable definition to the member function that was
          the only place it was used. It is now a local variable.
        
        Change-Id: I8a8b25765bd8ed5640b1a0cfa46ec9903b460a53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125433
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [96d19777abfdf74c9776470e39ee3ec7e1b2e256]

        refactor for potential reuse outside MenuButton
        
        Change-Id: I36729364550dc7c505fdc396442f51809fc58073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Caolán McNamara  <caolanm@redhat.com>  [d9c6fa0c31e25268829ec83d8d7a304abceeaaba]

        crashes seen in WriterInspectorTextPanel ctor
        
        null DocSh is likely
        
        Change-Id: I5aeb81ef01795b896ad594d7eb7f0cd657f5a690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [10d172747ba44b405e4bf4cfe7142a23a51bb94e]

        loplugin:stringliteraldefine in accessibility
        
        Change-Id: Ie27c32ea51ebcc9ad0d0d5a1d160d55c23727cd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125274
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [1cc6fca4927b9684b1f5acedee7b60c0c7518e25]

        Drop F_2PI
        
        Change-Id: Ie98606607b2ce262e4eed76bb8cd86fbfe846f76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125506
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-19  Mike Kaganski  <mike.kaganski@collabora.com>  [37429f2690a96491ad0e4fa2a04f2fa88a66da87]

        Use M_PI* instead of F_PI*
        
        Change-Id: Ie2b7a1c74fc516781a17a20157b8217bc41e383d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125504
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-19  Justin Luth  <justin_luth@sil.org>  [0afd2d3bfa9d55249ffd1408681ff04decf2d8fa]

        tdf#135906 docxexport: set serializer before writing
        
        This fixes a 6.3 regresssion from
        commit aafaf1f55fa413ad49d4556cf7c0a713dd206ae4.
        
        Change-Id: Ia2d3d26fe2cfa2b213326021f6b97f8d40c6e98c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125441
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-19  Michael Weghorn  <m.weghorn@posteo.de>  [dc0016bc8d7e6c4456f4442c7ccf287bfc0c2e9b]

        tdf#137924 qt (>=5.14): Use proper DPI without requiring window handle
        
        For Qt >= 5.14, don't require a window handle to retrieve
        the screen and then the associated DPI value from that one,
        but directly use 'QWidget::screen' (introduced in QT 5.14)
        to retrieve the screen.
        
        Previously, no DPI values would be set in case there was
        no window handle.
        
        This makes UI scaling work without having to manually set
        'SAL_FORCEDPI' on Wayland.
        
        While various UI elements (like e.g. the "Help" -> "About LibreOffice"
        still look quite broken with the qt5 and kf5 VCL plugins
        in a Plasma Wayland session (at least on my Debian testing with
        Qt 5.15.2 and Plasma 5.23), they look OK
        when using the qt6 VCL plugin with a custom build of qtbase
        and qtwayland from Qt's "dev" git branches.
        
        Change-Id: I5feae46ed86a8b7d3cf92d4a973f7a0f9a9f95de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125507
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [f3a0e8ba28d2a6e70d2ce9d4af1a9f823fec884f]

        rtl::Static->thread-safe static in xmloff
        
        Change-Id: I5fa1f0a2b5336508841ef841bb56e2edb25e4ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [8b1399cbb76b2f8b1722cb6a4a77b391f5af0862]

        rtl::Static->thread-safe static in sw
        
        Change-Id: Ic69883c66a08654b9c86ca87a640f5070312fa83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Miklos Vajna  <vmiklos@collabora.com>  [339405818c9c31a3ba29f406afca36568c378fb2]

        sw: enable warning in XMLRedlineImportHelper::InsertIntoDocument()
        
        This one looks useful, so why hide it behind dbglevel=2.
        
        Change-Id: I424808ae8ccd2ab7edcd1a75cd7c4479a0ec3b13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125501
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [f7a8c3cc4dc9a316b39e8680a2af330d8f8ba296]

        rtl::Static->thread-safe static in unotools
        
        Change-Id: I2a8c9ca7c45a8e20f3d114722a0677b856a13d8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125495
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [4d3e4c1cf3f117b8abd8dd67843864bb4c2e5a2f]

        rtl::Static->thread-safe static in tools
        
        Change-Id: I6c45fc533ec6281d011282bf2e8d49f23e2c29e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125494
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [6f3c6b12eaf0466827c9ec6b84c2516e38061b04]

        rtl::Static->thread-safe static in svx
        
        Change-Id: I743d252befd948580a1b3619f51d3f0343cb469d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-19  Noel Grandin  <noelgrandin@gmail.com>  [79db82976e3070b7889d2ec350dde3eff703ebe4]

        rtl::Static->thread-safe static in svtools
        
        Change-Id: I437259b4a70ec575e937821b9b1adc001723f29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125492
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [11800469cc7b3a40c42410be93a12e5107db0efb]

        uitest: sd: the redo action fails at times ...
        
        ... to add back the animation to the list in the sidebar,
        and thus the test fails.
        Remove it for now. At least the undo part of tdf#135033
        is still tested
        
        Change-Id: I7dc416645db53ec3f08376d04de9be036ce53fdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125505
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [7bcc18ac67181d10d3479b3100647aceddd86750]

        Qt implement QtFont::GetGlyphOutline
        
        Fixes FontWork with QFont based rendering.
        
        Change-Id: I294fe89d2753b6e82a559ff847b44126f9ea3bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125500
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [b8ef63c9fb3a1d4fb4a5549d28067cde07a8ab13]

        Drop F_PI180
        
        Change-Id: I36783d6fd6f439a71bc46959cd859b48d65ee30f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125449
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ca476ce3bc76b9a6073bcd587eceb30115ce103f]

        Drop obsolete comment
        
        Change-Id: Iee729890771376192c547b96c59f5e0086782219
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125448
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-18  Michael Stahl  <michael.stahl@allotropia.de>  [dd43c74ee5778109f860e18419fc37fd9ab1c7dd]

        tdf#140086 svl: restore PasswordContainer to single-instance
        
        (regression from 7256ff08bc46840bb85fa255ace6541dca91329e)
        
        Change-Id: Ib640dea001fc787279761ca72bbc3db46d0102c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125485
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-11-18  Caolán McNamara  <caolanm@redhat.com>  [966c9af081d1c8296026c1ca3564869362de45ab]

        drop unnecessary TODO
        
        Change-Id: Id906f7a6bf806d5c102f8653b1174aaa47e8bb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [badbacff3e124d6dcb2e656c97dc25a3d9ae5761]

        uitest: sc: remove duplicated test with the same name
        
        In the file, there are two test_tdf91305_sort_text_cells_rows
        so this one is never executed.
        
        Just remove it because it's quite a basic test
        
        Change-Id: I255b4202359e20744845fbdcbf963e74b9ee0710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125490
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [0011ed25344673d441e2ac59f455428b27fea9d3]

        loplugin:stringliteraldefine in basctl
        
        Change-Id: Id9f1d2932b5f602602d0229b8dc9794c01f5cbb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Jim Raykowski  <raykowj@gmail.com>  [a1b1f5a472497e04d315323e429f06fa55c19c71]

        SwNavigator: Track drawing objects before other content
        
        Do this to prevent other trackable content from being tracked before
        drawing objects when Navigator is used to go to drawing objects.
        
        Change-Id: Ib9d322208a2e358140bfb8c80ad94b4e0084f06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125437
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f326714ffbed94a4107b1e896898c1be89ca938]

        tdf#76836: sc_ucalc: Add unittest
        
        Change-Id: I62d4325dcaee19188529bb749801dc945c060572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125487
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [99e860b5231f86600ebb63b73d6ee557acc44ac8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04bef9c48889b4da6f332b1b31a9b45227b52c32
          - Refactor database help files
            
            Change-Id: Ie8f983d2c49f61084c456f8c7e91b41a6b5ac22a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125491
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-18  Michael Stahl  <michael.stahl@allotropia.de>  [92dbabbafb25b24bc8c621d4fc516eadb53ff5c9]

        ucb: webdav-curl: don't assert on valid URL
        
        If you put an URL into the host field of the remote files dialog,
        it will gladly create silly urls that start with "https://https://"
        - these are syntactically valid because ":" may occur without port
        number path segment may be empty, so don't assert.
        
        Change-Id: I29b6317daeb76d8f2fd4a22c0908ad2366c36297
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125484
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ea765fd2f9a357ffb95c4e5e7826426614d0670]

        remove some unused defines
        
        Change-Id: I4424329c1b803ccdd901f1428d332a6c56652100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Caolán McNamara  <caolanm@redhat.com>  [9ef696ff1594a2e3c6ef2185b27c8e67f6592b33]

        when color menu popdowns only popdown the autofilter if something was selected
        
        so the color menu can be dismissed without dismissing the autofilter
        
        Change-Id: Idb44f40a599382f86ffa9519910c37e64a56820c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125439
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-18  Sarper Akdemir  <sarper.akdemir@collabora.com>  [6ce8066af743b172d36046a8dc8b17ebe010b6cf]

        import pptx color schemes as color sets
        
        initial import work for color sets.
        Themes (which we get the color schemes from) in MSO can
        be different for each master - will need to support that too.
        
        [ Miklos: actually added that per-master-page support. ]
        
        (cherry picked from commit 3b21d166f585dcdf8d576d166aeff3cfd4694aab,
        from the feature/themesupport2 branch)
        
        Change-Id: Ia06d2645018e6bfa70817bbddba2374641ae13dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125477
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [f4d59ec73682f06fff9f718b3347726f1d53d263]

        make Jenkins dev builds use --enable-dbgutil, not just debug
        
        It's the "more debug" option that each developer ideally should
        use unless binary compatibility is wanted. Jenkins builds done
        with these settings are reportedly not published, so this is
        just tinderbox builds, and there's it's better to verify
        the extra dbgutil stuff too.
        
        Change-Id: Ia2f86ff9394e155b247a6e5e1583d0681399b99b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125381
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [a7a700de4b6191d97c9addf528dce218b237e868]

        draw symbols using polygons instead of raster of lines
        
        On HiDPI those lines become obvious.
        
        Change-Id: I2b0cce3950abb4d06a56ba022100bc74026b5de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125481
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [899deee84589306764a19383e3518e66714ca5e5]

        add an extra margin to native control drawing on Skia/Mac
        
        Some controls draw outside of their given area, which would get cropped
        when first drawing to a temporary context limited to just that size.
        I haven't managed to find a way to calculate the proper marging, so
        just add something that's hopefully enough but not too big.
        
        Change-Id: I1a15a3ab8cbd26cbe4fb52628b300ee70c8d51ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125469
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [5a76ae27a90fcb7e170a1cdd822a4bfd260e03a3]

        fix background color of some native controls with Skia/Mac (tdf#145748)
        
        Some of the control drawing calls use CGContextFillRect() to draw
        background for controls, so since we use a temporary context, set
        up colors for such drawing.
        
        Change-Id: I41cfa29e29fcf86598d49fbbed0b159c48c63d6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125468
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [07a9d2f60dabac5b8f9d10acb73a8eade1593aae]

        draw Mac widget controls at proper size when HiDPI
        
        This code was drawing them at non-HiDPI size and then scaling up.
        
        Change-Id: I90abfd36adaff4e7c4929cd28d0aa50d919449a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125467
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [23ad6c5d98e47310703de69506afe89883a75818]

        tdf#145731: sw_uiwriter3: Add unittest
        
        Change-Id: Id605ebee7145eaeb9ec5a533b7e72a0378d6bb7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125470
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [16031da61bdd7cc9b29e47bf98c6e411175afc7f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c580a172f699ab665b609896ac7c12a8990ee5b
          - Use embeded contents for experimental features.
            
            Change-Id: I3a02faeb85a9739a2ea425c8f3c4159b64df0ec0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125478
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-18  Caolán McNamara  <caolanm@redhat.com>  [c548e149d776d84ab480766f4664155ca1a7b526]

        resave with latest glade
        
        Change-Id: I151ae11d722881b21aeb9b88716c8be963e43056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [25cb40bd7a0e02adb1a1f219662242e104f9abfd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ce3e1b6c32f59175c76e6dbadb871cba0068262
          - Create PopupMenu service documentation
            
            Change-Id: I511221e68e9504a5c9e5e6c00bb31047a6ccf11b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124982
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-18  Caolán McNamara  <caolanm@redhat.com>  [5bc345a1624315c55b8ed1316d530d3943f96227]

        menu placement is a little off
        
        its relative to the treeview, not the floating window
        
        Change-Id: I70c15231eb61d5b8da3bbf473db39489b4544f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125473
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [187b28063fa9b908f5324ed345ba223d8f6168a2]

        Fix typos
        
        Change-Id: Idd21ee0026d8a36653f0fb25b350dae37315f603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125336
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e04ef6eda7d632ad39b3938ab864417303c8368]

        tdf#135033: sd: Add UItest
        
        Change-Id: Idc3cb84972d01496e378e224d65cd4db71648c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125446
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Noel Grandin  <noelgrandin@gmail.com>  [ed6651ec3b5dafed759cb602ad25e150592693a9]

        rtl::Static->thread-safe static in svl
        
        Change-Id: Idadc4dc77eb681a8b8923ffacf37ddbe1d8245e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125425
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Noel Grandin  <noelgrandin@gmail.com>  [3f12e3e992ae307886bc73ff37f07b270701730e]

        rtl::Static->thread-safe static in sot
        
        Change-Id: I208b4feff95013a787f3ca7828c88c9457e78ba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125424
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Noel Grandin  <noelgrandin@gmail.com>  [4d45eacd5485a756584fc7edecce8c821d4b7123]

        rtl::Static->thread-safe static in sfx2
        
        Change-Id: I8074494094f561c5ff21d13c68430798dc242604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  László Németh  <nemeth@numbertext.org>  [a478ac0f0a1eda92d35477462f70412bc65f9d36]

        tdf#145721 sw: add 'moved text' icons to Manage Changes
        
        For Moved (deletion) and Moved (insertion) text changes,
        add new Action icons to Manage Changes dialog window
        (Edit->Track Changes->Manage...), re-using existing
        Cut and Paste icons.
        
        Follow-up to commit 970f8ec7c8eb6007181ce55d885eef771dd49cc6
        "tdf#145721 sw track changes: sign text moving in redline tooltips".
        
        Change-Id: Ic202538ec31963e5e27170c7e5ea819a7f2bde9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125445
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-18  Caolán McNamara  <caolanm@redhat.com>  [06f36cc7ca8fc056dd8cf4d8cdbe682f9a003cef]

        allow vcl gen menus to have non-square images
        
        for the color menu in the calc autofilter
        
        Change-Id: I90a4ccefa9c44f5c9d0b0e49dd8c254d13be0fe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-18  Mike Kaganski  <mike.kaganski@collabora.com>  [fffc6b40b933f640a412233988bbb74bf6138af4]

        Drop unused argument names, and (void) noise
        
        Change-Id: I75f313924db7d6a0658f9d7cc1d571767cec3144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125364
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e634c893fbe388ad3978aaaa00db7fe0df280078]

        tdf#78897: sc_pdf_export: Add unittest
        
        Change-Id: I943f6ee26101006c128dfd78c8915d73a4911e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125443
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f95bdd424760f759dcc7197d004d98bf20f056d3]

        loplugin:stringliteraldefine in chart2
        
        and drop namespace declarations that were surrounding the #define
        - namespace decls have no affect on #defines
        
        Change-Id: Ic66ba7837ba3a5c48a0cf414af30985c480d73af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125278
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [258dc1f332155cd565d34b1ce3b51edc3c2fbf64]

        tdf#139612: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: Ic1467cfc50ce40951677a73ab3c43df6c33467fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125440
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-18  Julien Nabet  <serval2412@yahoo.fr>  [6bb6e59ca2b40958504ac176cab448de3fe0a2a9]

        tdf#145205: Mysql/MariaDB, display BIT instead of DATE when its a BIT field
        
        Beware, we just want to display the right info here, BIT management in Mysql/MariaDB
        needs some work
        
        There are 2 parts in this patch:
        1)
        -    if (sType.equalsIgnoreAsciiCase("bit") || sType.equalsIgnoreAsciiCase("bool")
        -        || sType.equalsIgnoreAsciiCase("boolean"))
        +    if (sType.equalsIgnoreAsciiCase("bit"))
        +        return css::sdbc::DataType::BIT;
        +    if (sType.equalsIgnoreAsciiCase("bool") || sType.equalsIgnoreAsciiCase("boolean"))
        allows to display BIT instead of DATE when editing the table
        
        2)
        -            return css::sdbc::DataType::VARCHAR;
        +            return css::sdbc::DataType::BIT;
        allows to show a checkbox instead of a field where you can type anything when opening the table
        
        Change-Id: Id50882bfab97cc43a1904bfc6eb7256904732bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125429
        Tested-by: Jenkins
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>

2021-11-18  Hossein  <hossein@libreoffice.org>  [dd8b064af0b4cb44575eb4f3482db18485bfc8d3]

        Cleanup Calendar_hijri
        
        * Removed the static member variable SA_TimeZone, which is not used
          elsewhere
          * It is write-only according to the clang compilerplugins output:
            compilerplugins/clang/unusedvarsglobal.writeonly.results
          * Time zone should not be allocated as a constant
        * Removed unused local variables commented out 15 years ago to avoid
          warnings in: 4170cbdbdfc9ceb282d25e1e19cd7b4d178436bf
        
        Change-Id: Ifc24651ae0aee33dd6a01c77c919ce0cb0426366
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125432
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-18  Julien Nabet  <serval2412@yahoo.fr>  [ccfeef1a48f5add83e443afd6664f40df59381b4]

        tdf#145725: document about VBASupport+RGB (no bug here)
        
        Change-Id: I1a90509b7e5481bcf811f19889688c767c32e46b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125430
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-18  Stephan Bergmann  <sbergman@redhat.com>  [af9ae2d6a968656208528144e5f01b17b383126c]

        There was a typo in the AdoptOpenJDK java.vendor property value
        
        ...ever since 61c4f96d6ae6a80370774e53287edb27cbce8067 "Support AdoptOpenJDK":
        At least the old AdoptOpenJDK 1.8.0_275 I had lying around on macOS reported it
        as "AdoptOpenJDK", not "AdoptOpenJdk".  But instead of fixing all occurences of
        "AdoptOpenJdk", we can just as well get rid of that vendor listing completely
        now after 3d27b2fa9c5a03f78e5145377402f8a88e3da1be "tdf#124503: Support JRE
        installations with unknown java.vendor property" and
        3460c16d7f749d8d2a59d8b927df5ec31f64a083 "Make getVersionInformation always
        return a VersionInfo ...even for JREs not listed in javavendors.xml, making it
        default to a VersionInfo with sMinVersion = "1.8.0".  (For a rationale for not
        updating the <updated> elements of the modified
        jvmfwk/distributions/OpenOfficeorg/javavendors_*.xml see the commit message of
        95c38f6d77f1cb6ff3dc229c5e7130b2e732891d "Drop support for dead GNU Java".)
        
        Change-Id: Iea34914201f604a0665a86dd07724628fa021c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125402
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-18  Sarper Akdemir  <sarper.akdemir@collabora.com>  [cd5c8e5a99f56d5af53b69dcb925f3aed77a815d]

        introduce XColorSetsManager interface
        
        [ Miklos: rather go with a beans::PropertyValues-based interface to
        allow extending this incrementally, without an API change. This allows
        getting / setting a per-document theme via the UNO API, but the concept
        from the original commit is unchanged. ]
        
        (cherry picked from commit 3f1bca8b4f451fa30bf341116390738c456d651f,
        from the feature/themesupport2 branch)
        
        Change-Id: I24be34a5a7b68549b21a6cd55144901d4fe2c5f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125436
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-18  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [75a49947c2eeb831a8e02192f1c4856eac62a743]

        tdf#81507: word content control support for w:multiLine
        
        <w:text multiLine="1"/> is now supported for import/export
        to DOCX. Like other content control items it is stored in
        grabbag.
        
        Change-Id: Id6f1aa0072dc5db980d0fa43cab4b38a0aa047fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125024
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-11-18  Miklos Vajna  <vmiklos@collabora.com>  [1d80f90afb479227044bdf0876c5576007abfdce]

        sw: remove useless debug code in SwEditWin
        
        The IsCursorInProtectedArea user pref flag can already toggle this, so
        this is not needed.
        
        Change-Id: I67fef0ee208f916e3af98a4215287d5c79908434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125427
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-18  Sarper Akdemir  <sarper.akdemir@collabora.com>  [3ed69deb04cca67e377c15956679f7bb9794e4ff]

        implement color tint or shade import for pptx
        
        [ Miklos: althought the PowerPoint UI doesn't seem to have a way to
        generate this markup. ]
        
        (cherry picked from commit de40c940c3a94588d44a3d1f6d8cd4191cca4f73)
        
        Change-Id: Ibf98ba335b10859e4d6d702263f09e6ba2033bff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125426
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-18  Luboš Luňák  <l.lunak@collabora.com>  [5e6e45eb4247bf8bd57d157b44f49577dde38716]

        handle also curved lines for nojoin skia polylines (tdf#143837)
        
        Change-Id: I2f5aa12eb656f6b337843d81a2a30de277dff7b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125410
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-18  Heiko Tietze  <tietze.heiko@gmail.com>  [f0334d62da608e140073e8831fdbbd0b5e4b1e39]

        Resolves tdf#143462 - Fixes black row number on dark backgroud in Basic IDE
        
        Using WindowColor for background and WindowTextColor for font color now
        
        Change-Id: Ie7bcb66d43673722ac882ac3cd59c7d9106f3020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125403
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-18  Jim Raykowski  <raykowj@gmail.com>  [4be0ae19065b1b50870bc0b2a28189ad39c96a8a]

        SwNavigator: Improve which entry is selected in the content tree
        
        after the tree is updated and when current document cursor position is
        at content that is set to not track
        
        Intended behavior when the content tree display is updated is for the
        selected entry before update to be reselected after update if the entry
        is still in the tree. Currently, if the selected entry before update is
        a content type, the selected entry after update is the first entry in
        the tree. If the selected entry before update is not present, e.g. the
        selected entry is the only member of a content type and is deleted, the
        first entry in the tree is selected. In these cases, this patch changes
        the selected entry after update to be the content type entry.
        
        Instead of reselecting by entry name, which can result in incorrect
        selection when non unique entry names are possible, as in Headings,
        this patch improves entry reselect by comparing unique entry user data.
        
        Content tracking is improved by not falling through to other tracked
        content, e.g. when tables are not being tracked and sections are being
        tracked, clicking in a table in a section will not select the section
        in the content tree, the selected entry in the content tree will be
        unchanged.
        
        Change-Id: I8d82059db8688c31c7c0d705445c1d8b4272bec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125176
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [96e9dad60bf82153bf678a15f93fb77c8cafcf43]

        uitest: sw: I don't think this time.sleep is needed
        
        Change-Id: Ic3f5ebb8e41a7f392385e01c9d7f0f89810ca194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125399
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [69cc5b565d38eb4b50be3b6540138bb1ec880ea4]

        uitest: sc: remove sleep
        
        Change-Id: Id1f3eb0ce1dbf9409ef005a01b2fe3bb1e453ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125400
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Julien Nabet  <serval2412@yahoo.fr>  [ae22b5c49c1c0c56cea2022c2979568b7fa4871e]

        tdf#145731: fix crash closing document
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=73334560b2dd2d60ac58d2cc2b1a5295490b03e1
        author	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 15:40:37 +0100
        committer	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 21:58:53 +0100
        commit	73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch)
        tree	b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e
        parent	6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff)
        Replace some macros in forms part 16
        
        Thank you Xisco for having spotted it!
        
        Change-Id: Ie0eb2a7e0e9f4c4fc12b83a233553a8713d6a6f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125420
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-17  Michael Weghorn  <m.weghorn@posteo.de>  [4180b2f7855479f9187cd259d57c06e9fedfb802]

        sc: Drop 'typedef std::vector<ScMarkArray> MapType'
        
        Its only use is in the next line, and it's not even
        a map anymore, but a vector.
        
        Change-Id: Ib7920c420f5e3e18658f3530244097a4b1633951
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125411
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-17  Chris Sherlock  <chris.sherlock79@gmail.com>  [4c3c94704704e5090c0382476251caee7a904454]

        vcl: split GetGradientSteps() into Get{Complex|Linear}GradientSteps()
        
        Change-Id: Ieb0d5d6f1a7c9fff3671ef74ffac9eaf37dcb0e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123060
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [b5c22a9371e22162ff7305ffaa393ed908eee610]

        use ListBoxPreview size for the color shown in autofilter color list
        
        it's used for a similar case in the color button,
        GetToolbarIconSizePixel is relatively narrow and we have a hectare of
        space available here.
        
        Draw a border around the color as we do for the similar color button
        case.
        
        Change-Id: If0b24a142d47038d02a977ed88281b2de0b529fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125418
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [c3c526e0192b9cf429d326b129ce9e94ec9e346b]

        weld colormenu
        
        Change-Id: I6feef72cf924865e2407a96cdd0b6e60c835dbc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125417
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [6b4b82626a30418c2d566c4fc1ecfe559557bf2b]

        allow menu placement either under or at end
        
        Change-Id: Id76cbe69464f439eec900bf9b80b0c63d99b6597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125416
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [9f68cc110c16cc096f5549a4a0812cee56cb09db]

        drop unused PopupMenuFlags::NoHorzPlacement
        
        Change-Id: Ic279160f96e5aa2a37690f987c2323b91b2ec49c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125415
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [2b3cc82b88d0c6508e9c0c6ccc53e0f9bfb4069e]

        tdf#142420 color menu should be a child of the autofilter, not a sibling
        
        which is why it doesn't appear at all under wayland. This should also
        get it positioned better rather than using a fixed pixel offset.
        
        Change-Id: I9a4193c27b4172469cea3d980c86cff9ca701ca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125409
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [3c4c98784d352c6edeae598233fd46775373d332]

        wrong function name in comment
        
        Change-Id: I80f7f8cbf17bea0de770eb590ade6bbdb2fc7ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125406
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  László Németh  <nemeth@numbertext.org>  [970f8ec7c8eb6007181ce55d885eef771dd49cc6]

        tdf#145721 sw track changes: sign text moving in redline tooltips
        
        Write "Moved (deletion)" and "Moved (insertion)" instead of
        "Deleted" and "Inserted" in tooltip of tracked text movings.
        
        Follow-up to commit f51fa7534421a195a58b4a737a2e836d8c25ba81
        "tdf#145718 sw, DOCX import: complete tracked text moving"
        
        Change-Id: I5db3025ddb7b4758e3699c10971a765784555a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125405
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-17  László Németh  <nemeth@numbertext.org>  [f51fa7534421a195a58b4a737a2e836d8c25ba81]

        tdf#145718 sw, DOCX import: complete tracked text moving
        
        Add IsMoved bit to SwRangeRedline, and keep it in both
        parts of a split Delete/Insert redline. Set this bit
        during DOCX import, fixing incomplete import of
        moveFrom/moveTo elements.
        
        Details:
        
        - Search text moving only at redline Insert() and AppendRedline()
          instead in the layout code (which was much slower, because
          triggered by also mouse hovering):
        
        - detect text moving in Hide Changes mode, too;
        
        - Insertion inside or directly after tracked text moving keeps
          "moved text" layout of the original moved text parts (before
          and after the insertion).
        
        - at detection of text moving, invalidate (update) layout of the
          redline pair, too.
        
        - fix DOCX import: extend makeRedline() with property RedlineMoved
          to keep all moveFrom/moveTo stored in DOCX instead of
          losing them (joining them with normal redlines) in the case
          of missing Delete/Insert pair (see unit test document);
        
        Follow-up to commit ec577f566fa3e6d2666069180f8ec8474054aea9
        "tdf#145233 sw track changes: show moved text in green color",
        commit bcdebc832b272662d28035007a4796e42d1305ae
        "tdf#104797 DOCX change tracking: handle moveFrom and moveTo"
        and commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be
        "tdf#123460 DOCX track changes: moveFrom completely".
        
        Change-Id: Iaca80e5e326a172bc7ba5fec64b63668b9378e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125317
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [9acb80943da5aaaf5d515a794f8a825d88bda430]

        rename getSchemeName getSchemeIndex to remove ambiguity
        
        [ Miklos: i.e. index could be a theme index or an index into a color
        set, this one is the later case. ]
        
        (cherry picked from commit aef22c3bbf1b4bb8ab9ba2bccb7005e0d0c75cb3,
        from the feature/themesupport2 branch)
        
        Conflicts:
        	oox/source/drawingml/shape.cxx
        	oox/source/drawingml/shape3dproperties.cxx
        
        Change-Id: I495e4b39975f1483607972ccbcc9348021710519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125414
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [fe1121cb8c79b0843b26331325332c3953049a92]

        tdf#84012: sc_pdf_export: Add unittest
        
        Change-Id: Ibdbf9cff1afe63eb2263d54d23996efcee22337a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125412
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [82067a6e996c197d84394a82aa0adef243ed8f69]

        CppunitTest_sw_uiwriter3: simplify test a bit
        
        Change-Id: I18a34239d2b62b698b145c9a29b0617dfbc79098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [2678f500fa4cf20a83c29fc28969efa71027b1ec]

        tdf#143978: sc_pdf_export: Add unittest
        
        Exporting to PDF is the only way I could find
        to test this issue
        Change-Id: I05da96cadc2785d31a9a63925ee072456ec72a93
        
        Change-Id: Ic31e1eb37f78451c4e34d91f9dd240716b94f973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125407
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Mike Kaganski  <mike.kaganski@collabora.com>  [b254ecc2bbc716343fccf303f58dfb034b487bca]

        Use C++17 hex-exponent floating point literals
        
        ... instead of some calculated/hardcoded decimal literals.
        The new syntax represents the power of 2 exponent directly.
        
        Change-Id: I826bda6e06ec77f0706bb48abe2934f7289fddc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125359
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [f394e2519c99cd1514c859cda67b1c09e68e6c19]

        implement initial pptx theme color import
        
        [ Miklos: this only handles colors as-is, without any effects. ]
        
        (cherry picked from commit ec68ca0b5fb6773f42600f6a5825b4794cdb0990,
        from the feature/themesupport2 branch)
        Change-Id: I89890cf7ba6ec758698011752b63d7a60872bef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125404
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [de4c17e7a7af37196dd36bb62967b557f9aa84f7]

        uitest: sc: use existing tests to test SetOptimalColumnWidth...
        
        ... and SetOptimalRowHeight dialogs
        
        Change-Id: Ibdee348d84a8b96d8f698e7fc6db89eb24422f5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125392
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [041379f6420f6d67bfd2bb952968e8c183f13a9d]

        tdf#137637: sd: Add UItest
        
        Change-Id: I5c0b3e85977b0e795a57e23dea0f7c8252777ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120652
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d98c34e647edb44457bcc4ac2d6ff7ec237f556]

        tdf#144247: sc: Add UItest
        
        Change-Id: I0e05c9e13bda04ebbbef3f2cf99c86697de5a4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125382
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Stephan Bergmann  <sbergman@redhat.com>  [f05a42ef8c8192186f91a169047742e5c3ae9b9e]

        tdf#144695 VendorBase::isValidArch also for macOS
        
        Lets extend it only to macOS (where there is some confusion now with Rosetta-
        translated vs. native processes on Apple M1 machines), not to all Unix-like OSs:
        The comment that it "is not defined what the exact [os.arch] values are" is
        still relevant.  At least for OpenJDK, while Windows has a hardcoded list of
        possible values in GetJavaProperties at
        <https://github.com/openjdk/jdk/blob/9604ee82690f89320614b37bfef4178abc869777/src/java.base/windows/native/libjava/java_props_md.c#L568>,
        the corresponding non-Windows code in GetJavaProperties at
        <https://github.com/openjdk/jdk/blob/319a3b994703aac84df7bcde272adfcb3cdbbbf0/jdk/src/solaris/native/java/lang/java_props_md.c#L175>
        uses ARCHPROPNAME which, via
        
        > -DARCHPROPNAME='"$(OPENJDK_TARGET_CPU_OSARCH)"'
        
        at
        <https://github.com/openjdk/jdk/blob/c363db8ed00ff27eadf06294364d908d6a7d03a6/jdk/makefiles/CompileNativeLibraries.gmk#L185>,
        appears to somehow come out of Autoconf at
        <https://github.com/openjdk/jdk/blob/228c21635b011fbf956b83a0b07fc297e9a34c46/common/autoconf/spec.gmk.in#L93>,
        so probably can show some variance in actual values being used.
        
        Change-Id: I16725cd9365f6bd034372c653aa43ab84d487b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125401
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [f3bd9ef889d1834f7b1feb49197a58e679826c00]

        Qt resolve native winId() on demand
        
        As for gtk3 in commit ac9789dbb36f45dcc1caf7dd2951353b1574c8ea
        ("tdf#139609 avoid fetching unnecessary xid under gtk3").
        
        Change-Id: I82b2c22437e5ab957706c25fcc118b28abb07242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125395
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2021-11-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [76611452da46aec18ba14954671beee4f6dacf49]

        Qt refactor SystemEnvData setup
        
        Change-Id: I900d1079c9a832a9b5170e58ce4e7a8b81d7d01b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125393
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Tested-by: Jenkins

2021-11-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6d0d4d943f3b63ef45160b2c0f77c2bb0ea3428c]

        update credits
        
        Change-Id: I0012889f2018c40479bd22c9d34848a6e70ee041

2021-11-17  Stephan Bergmann  <sbergman@redhat.com>  [b9ecede5762831ff590a33cd04dc7cb381307000]

        Don't fail jfw_findAllJREs for just one JRE of WrongArch
        
        ...otherwise if one such JRE had found its way into a user's configuration,
        "Tools - Options... - LibreOffice - Advanced" would no longer show *any* JREs.
        
        Regression introduced with 9143dd4ebe37b608e43d04434cf831624bf55b65 "Related
        tdf#54443 List only matching JREs", which added WrongArch to the javaPluginError
        enum.
        
        Change-Id: I51fd47e585c6686be7a9282615c0978e4f6c460b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125396
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [013ec5ef7ac038b6b1b8b937e81880f30434098a]

        expose the SvxColorItem theme related uno for draw/impress
        
        [ Miklos: added the missing SvxShapeControlPropertyMapping entries,
        breaking tests. ]
        
        (cherry picked from commit 88b6801ff2aa61ed2f0d64cef94fe6a9c09f3a35,
        from the feature/themesupport2 branch)
        
        Change-Id: Ifdcde6c4643eb9ac1c36040f5ccb490b9d900efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125394
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [192a16d6b0bad2d312b244a5576dfce3f4b05c36]

        uitest: sw: Use execute_dialog_through_command and remove sleeps
        
        Change-Id: I5b14248bedc595092729c2c36cefb936ca9d33f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125397
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-17  Luboš Luňák  <l.lunak@centrum.cz>  [c48a5f2653f7e76421c140cbd6018deffefccaf9]

        support ccache for MSVC too
        
        There's no official MSVC support in ccache yet, but there are patches
        in progress of getting upstreamed. So right now it's necessary
        to get a patched ccache.
        Ccache cannot work with -Zi option, since sharing debuginfo in a .PDB
        cannot be cached. Added --enable-z7-symbols that gets enabled
        by default if ccache is detected.
        It works even with PCHs enabled, and externals seem to work too.
        I get almost 100% hit rate on a rebuild, although such a rebuild
        is slower than on Linux.
        
        Change-Id: I1d230ee1fccc441b9d9bec794cc2e1ec13161999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125179
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [938fbac669bc59cf0b388bd0d21a2f14c4399757]

        SCSTR_FILTER_TEXT_COLOR is used in two different contexts
        
        in the autofilter popup and the standard filter combobox.
        
        In the autofilter we want title case to match the other
        entries there, for the standard filter we need the same
        text as appears in the combobox list
        
        Change-Id: I693d3fa8a9fa1bac0803971be593f107d5817e74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125371
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [6a5c8d9609d2d3b1dc4b7f67ea41fb43add9a993]

        ofz#41081 divide by zero
        
        and
        
        ofz#41088 divide by zero
        
        Change-Id: Ic545271709257fe5f676446e82b9638b84867195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [b4f03a95db84c1d18c9435d13f41787596d34b12]

        stop vclcanvas from ruining alpha of bitmaps in Skia mode
        
        According to the comment and tdf#45219 vclcanvas deliberately forces
        alpha to be 1bpp because of poor performance. But that's not the case
        with Skia, alpha is always 8bpp there, so all the hack does it make
        animations look ugly and it also breaks caching capabilities of the
        Skia backend because the hack always generates a new bitmap.
        
        I don't know which VCL backend the original problem was related to,
        so at least disable the hack for Skia.
        
        Change-Id: I8a90c32dbe911cb79b617c0c447f3e9ced05f746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125373
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [23b17e409976f3c106028cc6617ca3a841eb839d]

        Skia dumping is no longer dbgutil-only
        
        This is a mistake from f33b76b4e675818deae244427cef84c576a1a1f8.
        
        Change-Id: Iae69ae0099a62451d156c80255f55b1f6aad4725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125370
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [75450b3affc424cccfc68eae13a3271204108b09]

        disable split debug if --enable-lto
        
        https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88389 is right that
        split-debug doesn't make sense with LTO. Without -ffat-lto-objects
        or with Clang .o files aren't even really object files that
        would be normally usable. Since gcc complains if the combination
        is used, explicitly avoid it.
        
        Change-Id: I76992e94f4790238e5aaee691b5cec54fd0ef3a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125379
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [32aa44e928ceb5194e37ad0a4fb2f38f1c7371c2]

        use title case for "No Fill" like "Not Empty"
        
        Change-Id: If044b8de9a5400b6db61537519afcf5f18dd1cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125321
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [037d5454a39260635aeb7064ac32c7a485af8197]

        crashtesting: crash on passing null to std::string_view
        
        with many documents, e.g. moz377878-1.xhtml
        
        https: //gitlab.com/orcus/orcus/-/merge_requests/113
        Change-Id: I085543ebb28c02a1c0ec487b357f6e0a83004363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125378
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [753f5d65b4a91e179c61eeea2645ae190eb80155]

        don't attempt to set cursor to first entry if there are no entries
        
        avoids gtk warning of:
        gtk_tree_view_scroll_to_cell: assertion 'tree_view->priv->tree != NULL
        
        Change-Id: Ie2c22a02d795591600a7f6da2e11741ba084a81f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Sarper Akdemir  <sarper.akdemir@collabora.com>  [3171d185f8c17799f0b85f5931aa59101cbc6b4e]

        make colorsets work outside of styles and with direct formatting
        
        [ Miklos: picked only the document model bits, now in SdrModel, next to
        styles. ]
        
        (cherry picked from commit 1647d34d8573f4940c0cbb7fb6cd9c6b4e5a4a15,
        from the feature/themesupport2 branch)
        
        Change-Id: I80f9e0b205b8b4a6914f851bdc63e3e0ca6706e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125313
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [eb515f11caae5d1b30f7c306fc32111a0cf617b2]

        retire loplugin:simplifybool
        
        The plugin was originally written to rewrite dumb old OOo code
        like 'variable != 1 ? true : false'. All that code has already
        been rewritten, and now this plugin just enforces matter-of-taste
        stylistics on new code.
        
        Change-Id: I8cd2accd7c0ac365b75dcba51a9049bf9e293869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125346
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [bfe589d13fafc0801d709a79144114d289958cae]

        remove loplugin:finalprotected
        
        It just forces a custom rule that serves no real purpose. There's
        no technical difference. If one day a class gets inherited from
        then this information will be lost/incorrect. And mixing access
        on a virtual function is poor style.
        
        Change-Id: I0c27db8d694ad191a118d4e1d3d4a240e00456fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125337
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [d72237ff21db37f0d8c97f47c8583cba99f141df]

        fix system pch breaking after f22e5078cfac93c50ae5169f6545091
        
        Change-Id: Ie7f63b52b77e821b92fcf6b09af6c8bf43ca9e9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125377
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Stephan Bergmann  <sbergman@redhat.com>  [b2065d0ef6ee90387759fdd952fc4e509f264ed3]

        Remove newly redundant break
        
        ...after 0047e38da8bdfe09360cc2a658283ad5e18986e7 "svtools: HTMLParser: don't
        insert EOF into strings"
        
        Change-Id: Ib7d47030f215504a86bbfc10d9c35b5a19a7314b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125375
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [05fd1abb06821be51a6a23a1c8953dfaf24e1187]

        loplugin:stringliteraldefine in avmedia
        
        Change-Id: Ie34a45a745ac9546208444b2e499b581e18d449f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125275
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8405b8cde173d60c62faae728ec572c383f3af5b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 890b11c7e389bff4b177beaf79461a6d6cc8ba1c
          - Add Development Tools icon to Help page
            
            Change-Id: I619e94f6c9c58285781cd6635398b4a807d20f55
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125335
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-17  Mike Kaganski  <mike.kaganski@collabora.com>  [a664d4d44ce66db8d60d8c0ebf8bb793ecf2c462]

        Fix the calculated constant
        
        rtl::math::isValidArcArg's comment talks about 2^64 = 1.844e19; but
        the calculation resulted in 2^63.
        
        Unfortunately we can't use C++17 hex-exponent notation in published
        API header.
        
        Change-Id: I1dd6e754431ad028982623ff5de4c6329fd6c2ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [22b930fefa68db0c581068045c68cad71879b901]

        fix SkiaTest::testDrawDelayedScaleImage() with GPU+HiDPI
        
        Change-Id: I0bdaf2679f1f20f6ba0c28641cd8cc6756e4316b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125369
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [46520710560e53c6d488d71824694bf5e460ee07]

        avoid a PCH build failing because of a directory missing
        
        Change-Id: I3ff3c255d5707b6a802940bc4d96e1a729f1fcc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125368
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Matt K  <mattkse@gmail.com>  [f9ab31366dbe466ef739015734bb5b6a1a0deca4]

        tdf#143971 Removes pop-up dialog for read-only documents
        
        No longer does the user get a pop-up dialog when opening
        documents that are read-only, asking whether they want to be
        notified when the document becomes editable.  The change
        removes some of the functionality introduced in commit
        95eb088802562b75f8b299908160145c7e88d763 "tdf#47065 Add new
        file open UI options and implement a new thread".
        
        Change-Id: Ic25e8e293e7224fb5086249a9d4814914fa961d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125340
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-17  Luboš Luňák  <l.lunak@collabora.com>  [8dec2a98ce29251936cd45ebf864a89ff767ee50]

        revert "vlookup - optimize SC_EQUAL and NOT_EQUAL." (tdf#139612)
        
        That commit breaks lookup when the  "Search criteria = and <> must
        apply to whole cells" option is disabled, as it enforces whole cell
        checking regardless of the option. Given that the option is enabled
        by default in LO ('SearchCriteria' in Calc.xcs) and it's what
        MSOffice does as well, and this default gives good performance
        regardless of the option, I don't understand the purpose
        of the commit. Possibly it was based on a document where somebody
        disabled the option and then indeed got worse performance.
        Solution: Don't do that :).
        
        This reverts the code parts of a953fa1c0f6a40a08859570516c511f3a841 .
        The test I've kept but switched to ensure that partial matching
        does work if the option to match whole cells is disabled. I've
        also changed the tooltip for the option to mention performance
        and not suggest that off is the default.
        
        Change-Id: I56d7b6e7b8e9f0622f7ad6d447daf56c3b705a7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125267
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-17  Caolán McNamara  <caolanm@redhat.com>  [fcad2503ede92b515076f9bb3162855dcc2c575d]

        replace an ugly coverity warning suppression
        
        Change-Id: I320d84901368f0586a113fd2afe1cb6a5eb19b11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125320
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-17  Martin Srebotnjak  <miles@filmsi.net>  [a120bb3caa286edfcaf7a8d78d1250f131156ccf]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2bc84baf3c71752347f44eebba769f4adadd6e8b
          - Updated Slovenian translation
            
            Change-Id: I845c6b76ed9acf375b573b92e56c7960210579b6
            
2021-11-17  Stephan Bergmann  <sbergman@redhat.com>  [8ab30014e4e098e202b3bee571aa9d6bcdfa1c70]

        loplugin:simplifybool
        
        Change-Id: Ifb7c6d8a4506808b5f56492e692ef7172a367e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125344
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-17  Miklos Vajna  <vmiklos@collabora.com>  [a36a2c33c60d5d379d4db5c1727c8c47504cc828]

        CppunitTest_sw_ooxmlexport15: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ibae84ac39947ce02b19a026daf0f39ab27fa0ee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125325
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [8a323e6904beba41dfdf054fcbaeac1d44fabc1e]

        Sifr: tdf#144036 add UNO Object Inspector
        
        Change-Id: Ibfdf0572c20e1ada6a8e09e1303fb14c13bd0089
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125343
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-17  Heiko Tietze  <tietze.heiko@gmail.com>  [e396017b598e6ef161e71f18638b4d94cd92e6ee]

        Resolves tdf#144247 - Change display precision of row height / column width
        
        Use 2 digits by default but 4 in case of user-defined values
        for row height and column width.
        
        This partially reverts ad8edac43e73555bc2055514300c5b81a1bb04ea
        as the optimal width is back to 2 digits
        
        Change-Id: I4cb53071783c76d9fbea0cc2feaa0b860c73c647
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123802
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-17  Julien Nabet  <serval2412@yahoo.fr>  [8ee18d0bb587a30d53e2f1e3cf277d9b18da24ae]

        Clear also m_aDestTypeInfo in dtor like m_aTypeInfo (dbaccess/WCopyTable)
        
        Change-Id: Ia73503628451a3e5ee5121022545c92b50d12b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125261
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-17  Mike Kaganski  <mike.kaganski@collabora.com>  [f007f32958a7c875db6cb2e79c09ab0965477a2a]

        tdf#145711: filename may be 1-character, and must not contain path separator
        
        Surfaced after 6ea7ca45782a7e1b46e18e994534ec0a7c71951b
        
        Change-Id: I4975f51a7a0ca73eccfd17338abc122254b57113
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125338
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-17  Eike Rathke  <erack@redhat.com>  [eec32be26d5d5805c1cb8cb53ce9702c04829819]

        Add script codes to standalone {mis} tags
        
        Also, mis-Medf is dmf-Medf.
        
        Change-Id: I5d0766d63effb985a94355a95cfb6c447362051f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125339
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-16  Stephan Bergmann  <sbergman@redhat.com>  [696e60427e6c355cfaca35f7b93d2001f0a12604]

        loplugin:finalprotected
        
        Change-Id: I16d32d51266fc32e8ee37f9e1deed4c9577764b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125316
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-16  Caolán McNamara  <caolanm@redhat.com>  [d5811039430e5a76643491c68fed75691969afbd]

        WrtStt->WrdStt for consistency with the other word start abbrevs
        
        Change-Id: I4ec773b5867d804d9c293c4c89cb9be4acb017b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [e36fddde8ab87fae6f3428d58a8e890c2b2c798c]

        uitest: sw: ExportToEPUB is already tested
        
        Change-Id: I3c125a9193f7d38d30c0c0ab76296c80c46e4245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125323
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-16  Eike Rathke  <erack@redhat.com>  [263961306ede0656ebb7904034a2172615ce81d0]

        Update to ICU 70.1
        
        Unicode 14, 5 new scripts, 12 new Unicode blocks.
        
        In i18npool/qa/cppunit/test_breakiterator.cxx
        TestBreakIterator::testLao() had to be disabled/adapted.
        Needs to be investigated, see comments there.
        As is, Lao script word break has regressions.
        
        Correct UBLOCK_TANGUT_SUPPLEMENT Unicode range endpoint to
        0x18D7F, see
        https://www.unicode.org/versions/Unicode14.0.0/erratafixed.html
        for which ublock_getCode(0x18D8F) now returned UBLOCK_NO_BLOCK and
        thus luckily the assert in svx/source/dialog/charmap.cxx hit.
        
        Change-Id: I4bad16ecfab3f44be365b8f884c57f34af68218e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125322
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-16  Noel Grandin  <noelgrandin@gmail.com>  [a2bb4fc9174637c065364f9740f164b27172d1f3]

        rtl::Static->thread-safe static
        
        Change-Id: I0f39dea1392eb2ba11881615aedbe386870282ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-16  Mike Kaganski  <mike.kaganski@collabora.com>  [ae8802cef10c40a40df8f783e724d70618539126]

        Drop redundant 'using rtl::OUString'
        
        obsoleted by 6080259862ee9886d1dabcb7c06132268a398cc6
        
        Change-Id: I246dc6050fe7adf60ab3c836db3cfa781578d483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125142
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [837bb7370b702399562a3b0b4e444237c66879a8]

        tdf#139922: sw_uiwriter3: Add unittest
        
        Change-Id: I4401ba7d00dae654a6e3c897719e5f1a112a9abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125318
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [09dfad9565b37353acc0b31054639134f1a85ab9]

        fix drawBitmap() unittests with Skia/HiDPI
        
        Force non-smooth scaling to get exact pixel values. Introduced
        in 6792e6e5e49d11a54256b75c4c5a476bb2f10b4a.
        
        Change-Id: Iec2633e9ef8e930688c95ceb1037696456f344f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125312
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [a0a4709eb4226ae15931999fc17afe5b5b9f8081]

        try to avoid scaling bitmaps twice in Skia when drawing
        
        The scenario is that something scales a bitmap and then asks for it
        to be drawn (possibly drawn scaled again). One example is
        OutputDevice::DrawBitmap() subsampling the bitmap that according
        to c0ce7ca4884f7f6d1 is supposed to improve quality with headless(?)
        backend, but with Skia it's pointless and it breaks things like
        caching during repeated drawing, because then GetSkImage() will need
        to generate a new SkImage each time.
        Since Skia backend uses delayed scaling, these cases can be sorted
        out by checking the stored SkImage and using it if suitable, as
        the original image is as good as the rescaled one, but often
        it's better - it may be cached, sometimes the scaling operations
        cancel each other out (often the case in HiDPI mode).
        
        Change-Id: I0af32f7abdf057a3bdda75247d2dc374eaf1bc4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125311
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [f33b76b4e675818deae244427cef84c576a1a1f8]

        make SkiaHelper::dump() available also in non-dbgutil builds
        
        They are just a set of small functions, and I sometimes need
        to debug optimized builds too.
        
        Change-Id: I6350476e8c7fef85460a88b9e3d56d02213764ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125310
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [f22e5078cfac93c50ae5169f65450918b34b0e99]

        do not rebuild PCHs on icecream/ccache change, take #2
        
        It turns out $(gb_SPACE) is not just one space.
        
        Change-Id: I8f5cd13d14d71f0a6dd7d8b89ee857f983d27d20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125309
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [71b9369f1cc40143108e3f2189d96e402895e315]

        postgresql: upgrade to release 13.5
        
        Fixes CVE-2021-23222.
        
        Change-Id: I4e16fcc60c634382a864f66b211d0e0170a06db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125308
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [0047e38da8bdfe09360cc2a658283ad5e18986e7]

        svtools: HTMLParser: don't insert EOF into strings
        
        It's not a valid Unicode code point.
        
        Change-Id: I96103f4c505047bdf0451619937b8e1b2efb127f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125307
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [a7116b890ccd6dd1721413b4de6591a8057668ef]

        ofz#40766 svtools, sw: HTMLParser: really stop inserting control chars
        
        35d248cab1f0d4800f72abb5cb6afb56f40d9083 forgot to fix one place where
        control characters were in a presumed XML declaration.
        
        Another place looks missing where comments are handled, but it's not
        clear if these can be passed on to Writer.
        
        Revert the previous fix from commit
        b3325ef8cdfc2c82eec34e747106f75a9fccb7e4.
        
        Change-Id: I11ad13de9122533626e512ce0384051e3e5bd97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125306
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-16  Caolán McNamara  <caolanm@redhat.com>  [75a14a1e962793de1483ceea1bc36cc78144e386]

        Related: tdf#142719 first time undo adds an exception it gets lost
        
        Change-Id: Ie963e92a15ddd45316f999e950fff359d7dd6f5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7a2d8ee2b45b8dd0f614614368ae90878e51a645]

        tdf#142781 - Calculate width/height keeping aspect ratio
        
        Importing an HTML file including an image conserves the aspect ratio in
        Writer.
        
        Change-Id: Ia31b36884daf2728b0989ae7c1e6ece683543d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125170
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-11-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [2f5657ca8e54e2e49b6ad801a06d7d58fc725630]

        tdf#116640: sw_uiwriter4: Add unittest
        
        Change-Id: If201d0825dc9ad6f6ed15d2367f1f717ec9dd1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125297
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-16  Michael Stahl  <michael.stahl@allotropia.de>  [3f54dc746936c5a4cc4aeba7e7a7ef1d95b62037]

        svl: fix misleading comment
        
        Change-Id: I41406200aa953081c2e2a6ab9cbe8c404d8b5d86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125305
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-16  Justin Luth  <justin_luth@sil.org>  [59dc5d00b04927d07df2dcc3c17acfdc760d8765]

        tdf#139922 sw autocorr: don't return GetPrevPara if isEmpty
        
        This fixes a LO 6.2 regression caused by
        commit 4cf5a46f16dec8ce16c6662ce5c17903e28b8fa3.
        
        Change-Id: I4aee8f4e79a40a8b8f82faa3e62dead80a952510
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125037
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <jluth@mail.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-16  Hossein  <hossein@libreoffice.org>  [b0ce4e848f786a2f452a6a6e426df4b95af4da3c]

        Use basegfx::deg2rad instead of *0.01745329251994
        
        * Replaced multiplying by magic number 0.01745329251994 with
            basegfx::deg2rad() which is equal to M_PI/180.0
        * Instances of this could be found using:
        
           git grep 0.01745329251994 *.cxx *.hxx
        
        Change-Id: Ib813251f6223e4218fe977c0211732c22199295d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125294
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [84b817130a1b19591c3add9af5db0f42af64be68]

        Support reading back theme color from an ooxml document
        
        ooxml supports theme colors and tint/shade value that additionally
        changed the theme color. Read back which theme color + tint/shade
        value was applied in the resulting color and add this attributes
        as properties to be used by writer.
        In sidebar theme panel the changing the theme colors now doesn't
        takes this into account and changes the colors correctly.
        
        [ Miklos: left out the Wrtier bits for now, focusing on Impress first. ]
        
        (cherry picked from commit 16a0a2089e8572a35a36a7e649703893ecd06299,
        from the feature/themesupport2 branch)
        
        Change-Id: I8e0d62ec8c0534e603fb1e5fb000dcf84aea5da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125304
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-16  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [fcbf3841c534aa7a96e0ff893ecc1c1c4af961e5]

        Related tdf#139031: add missing colons
        
        Reporter mentioned a bunch of missing colons across the UI.
        
        Change-Id: I278d0ad7073fb399c979f0fc52adc306f51ae49d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125147
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [ae4a9d5cc50d94f3180ce3e5d3793c0a403074cd]

        add a vcl backend test that draws a sheared bitmap
        
        Change-Id: I06838e01ed41ac41c8b578fd6c7d984f1c073e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125298
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [5006dfcbc370e80bd159a9e957254b0ce09a6cdd]

        Theme color and tint/shade attribute for SvxColorItem
        
        To support theme colors the SvxColorItem must be extended with
        an optional attribute theme index to define the index to which
        theme color current color belongs and an optional tint/shade
        attribute define how much the color ha been additionally tinted
        or shaded.
        
        [ Miklos: left out the potentially breaking svx/sdi/svxitems.sdi
        changes. ]
        
        (cherry picked from commit ccdbf815e00dbe2ba21f7e86b6743df100b7401f,
        from the feature/themesupport2 branch)
        
        Change-Id: Ifb0481770be675181dafa94cd2778f374fcf3c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125296
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-16  Alain Romedenne  <alain.romedenne@libreoffice.org>  [e73e45e0ff14f4b0fe443d95937cc5f5a166feb4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb45e7df8aeeab7791876038c16345d5321e49b1
          - tdf#141474 Asc, AscW function signatures
            
            Change-Id: Ia85bf08bb1e5cb0e7db5717caec01e7e50c3b106
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124853
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Caolán McNamara  <caolanm@redhat.com>  [7fdcc2d3f218def3b3166cdbfa83154e68e00b4b]

        Related: tdf#142706 mask with GDK_MODIFIER_MASK to ignore unwanted bits
        
        Change-Id: I6d3f6fb6e9385b8077c23d5b7f78c43d9fb7b9d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-16  Caolán McNamara  <caolanm@redhat.com>  [af1b9bf6e1a5d9622faa81ae2e2ddb1cf26153f8]

        avoid using always-show-arrow in gtk4 < 4.4
        
        Change-Id: Ie2df9cd91a5ea857965d24dc669a6c1d94c965a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [eda22714fd83a8b2ace0369b0a71825f11fbf85a]

        Update git submodules
        
        * Update translations from branch 'master'
          to a692f49808bffb7f402cd88cbf48e32b2044d111
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I93c02cdd542eb2c42765f65e9e78f2dc8f339005
            
2021-11-16  Luboš Luňák  <l.lunak@centrum.cz>  [a0f35cd270fa486deb75e1c2c0516d55723cd04a]

        hard-require Clang for Skia also on Mac
        
        Since Skia is now the default on Mac too. Clang on Mac should
        be the given, but check for consistency.
        
        Change-Id: I490d5434374d98b1d7a219c2bca48747e31eecac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122337
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [7ee24b7358295bf9be323ad177ea00aa8b1588a7]

        make Skia the default now on Mac too (again)
        
        This is a re-land of commit 2489edcbe0f5dc77649fc2e801c1bbffb71692b8,
        now that HiDPI support (tdf#144214) has been implemented properly.
        Originally coming from the ESC decision from Aug 26th.
        
        Change-Id: I4d397282adeeac50ff19ba651b920c73080d3dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125273
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Noel Grandin  <noelgrandin@gmail.com>  [1170db278db9f1067c05d5df95faf81c1ce861bc]

        rtl::Static->thread-safe static in jvmfwk
        
        Change-Id: I049148d82eb306e8ba7fdc9f0cc650f45b05da0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-16  Noel Grandin  <noelgrandin@gmail.com>  [2d2dc141f6d0eaa1e4737450fac707c67c05387c]

        rtl::Static->thread-safe static in oox
        
        Change-Id: I4436188aa52766a07dadc1accb52c524666ae2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-16  Caolán McNamara  <caolanm@redhat.com>  [0659c488efb00e2a87fa98edf498288470688a9a]

        Resolves: tdf#143511 SysObj is clipped out if the widget is out of view
        
        so the sizes and relative positions are invalid under gtk, unclip
        the SysObj when using get_extents_relative_to
        
        Change-Id: Ibdaff20531a2a40b3b9b7dc9ac880d014db07d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125272
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-16  Katarina Behrens  <bubli@bubli.org>  [71a186aedc6060bb4fb834c847f74c657d700f1e]

        tdf#135033: Make undo of adding and editing animations possible
        
        weird this somehow sneaked out when converting custom animation
        pane to sidebar when undoing other operations (delete etc.) stayed
        in place
        
        Change-Id: I6287682839d0e0401cc60bf82257d86765f3a858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125110
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-11-16  Szymon Kłos  <szymon.klos@collabora.com>  [1430d7670070606de41bd954835e55a71d88875b]

        tdf#145694 sidebar: add glow and soft edge panel for fontwork
        
        Change-Id: Ia501a0f1084e4b6d5ca2052a0241ee7675cd2f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125270
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [621430208d29e40ab95509a4e94da6e8313ed389]

        optimize Skia's copyArea() to copy less data
        
        Change-Id: Ia1cd0522643b58ea1be3ad974c1fc5f7fed657d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125268
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [adba50494e11ca799ce6a794195ff844dfac7cd3]

        log also whether SkiaSalBitmap has any pending scaling
        
        Change-Id: I09a1921e203e1088577abf75350c8b41e4c78381
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125265
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [07e5e9f4c4318c19dd553459132efa71d456eaef]

        don't bother caching bitmaps that prefer shaders
        
        Change-Id: Ibc78371f9e2ba92470714847bb6a5b8b96d1037f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125264
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [6792e6e5e49d11a54256b75c4c5a476bb2f10b4a]

        when caching bitmaps in skia, take into account HiDPI
        
        Since the image will be actually eventually drawn twice as big,
        cache an image that is twice as big.
        
        Change-Id: Iea0340cd92c102e453330723c797659c742feb63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125263
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [29a2120fcf56ef7fcdb5c95e896e4366454b63bf]

        apply SAL_FORCE_HIDPI_SCALING on X11 even while drawing
        
        It'll draw double-sized 1/4 of the content in the topleft corner
        of windows, but it's still useful for some tests.
        
        Change-Id: I20c6d2382d704ddcd67b8cb81eb7abf37b57a92f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125262
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Luboš Luňák  <l.lunak@collabora.com>  [b5983dbe2c41f38e653201574cf20cd4bd76e950]

        implement HiDPI support for Skia/Mac (tdf#144214)
        
        The basic idea is the same as the 'aqua' backend, simply set up
        a scaling matrix for all drawing. That will take care of the basic
        drawing everything twice as large, which is twice the resolution.
        And then blit this data to the window, which expects data this way.
        
        Converting back from backing surface needs explicit coordinate
        conversions, and when converting to a bitmap the bitmap needs
        to be scaled down in order to appear normally sized. Fortunately
        I've already implemented delayed scaling, which means that if
        the bitmap is drawn later again without any modifications, no
        data would be lost (to be done in a follow-up commit).
        
        Unittests occassionally need special handling, as such scaling
        down to bitmap not being smoothed, because they expect exact
        color values.
        
        Change-Id: Ieadf2c3693f7c9676c31c7394d46299addf7880c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125060
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-16  Johnny_M  <klasse@partyheld.de>  [67669707e0c6c8a390d352e7060ad5862d727433]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bcc3ccc059f426ef2d79295338e50bb7b7a6642a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I19a2a9073c17b4785f1d76bdd073ef1248c567ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125192
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [0dbc6368695198f01d2a19fc934f2365f7d45a92]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ecaae4914ab0d7cea926c64407637ea6b05723d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0bfd3e56449f87f90b20d083b15b885d18a889e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125190
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [f7d02c3a66a83c1d9af392374d67b8258e175e89]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 88f6c6a5b87012345a2b5a06cfce640513a57106
          - tdf#132643 Translate German section IDs
            
            Change-Id: I77e097bc550945e9f55d0b14b028261b503301aa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125191
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [e8b667f7ec28d28ed228bcccc25dbf77cb161abe]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1aa8bf640c894799bfd3c1ece4df34cbb5c29a6d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9e03d674b96a857255f6f34c87a4ceff2b16969c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125189
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [09cfd99b85029d9e348a3dad012cb2e739431d31]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e713d1e606f3e87692bcbe629a6427a706859152
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2371a142bd3f7c088acc402ebb3d3f21d376e485
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125187
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [0abf9d62c2f12c87e746a5d63d1c6d67d82d2bb6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2ee280bfb365d3cee940f96a93957360a6025eec
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ic6458663921fa886780b84180ad1239fe9ee3896
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125188
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [3aa7b95e8e5865d4aea465cf48dbff87f337aff2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 940b048a9561b5919348a98dabbc3335119557a2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I61eb8c27657cbacfac50d446bffd5715ac36ee53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125186
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [c400c407b2318de2942f678cc899a49b9d42bfc5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2d633cea28e9f266cd9c9a712c97eb9e2b83c8eb
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idd605a7b145e5cd0428ebcf84214b3f2907d6c71
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125185
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [3af71aad987cf9f2175af87814c019ad61cb2b04]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f78f0eda70965f9d7e146bac44bee2d3ad634b5a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5189b5de232eafaa1a12fff0be358ebcdeda8a70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125181
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [277e7129355ec8358acc1d0bb9d47aa5697a4181]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cae9563ec5539c55f82562adb4971a5dba93535
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic1dbe2444c17b9440a39dae8a95b7b5d11df5f4f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125183
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [b401b501996d1892e1f08ceda7d84083fcd00a96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e775ecf573c86ea404f68466a3ac748c5f8988c3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I793fc7e9be89985c700ef39cab72f651b1468e01
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125184
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [614c7bd5df979b5653377074afe6eb5ca4687a32]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ca7212f47d3a3a457556db80a9c7da48a714853
          - tdf#132643 Translate German section IDs
            
            Change-Id: I780358fcc99a9f59c6ba0f5eacbc65fd39c16b14
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125182
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [d92a9cde10c49879f7c9d52807e92956b3bc93aa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fd8a89b227489f8f8d005025b6984b952a4b57aa
          - tdf#132643 Translate German section IDs
            
            Change-Id: I761bd3bff8d8094f1fac6dee0c2a9cb5bac85cbd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125166
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [d76200e028f69a77a55fe5fbda5c7a5ab251e9bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 388680327e1628a289a726d9c23a51f0456e6a26
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8344b8cc9ceb0b3e223ee0782a40c729134ba9e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125162
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [852ba60ff1dffe812661aa3ec9c76ca768892b2d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7713a240a73b3ac5cc369d53cc6c968b7f669a16
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id411b83ff1633c0c0122611ae2acc51f88b6e6a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125164
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [a0e1b5d7c7771c943dbf64a6e0602b6778571bff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f04dd65cd08f3ee1319d2722816ff88d75d42b68
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifd576cabd0d11d5bad40e6ef31073b4100e7591e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125163
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [fde191ace343016159b4b297fce4697ce361fefd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 598c978c1f38096a7e67f71b069a013f35e93980
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib6614f8ea98fcb5e8590197495f7237c9e04e5ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125161
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [a57643c7a5c024f6fa5be8eea82218ec8d9b8f9c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2fb3a91cc9369a5a40c5387b23a3a95d956d2d96
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie5d6781051dc00f7ef93c4ef84675a47dfddc072
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125159
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [46b13b8c332dfdeb439771473fb5adc987c40e0c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 086870afe01341a5b71b76493f121032caac15c0
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib472c56cfb4c2dea3f2a54fd4e193013de5cd5d2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125160
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [39a368444dda67482b3d882b46b591bdf1498aac]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 58bf1935c2cc586f37b3b4d1ba8d458c9c163288
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7e5e46d2dd06bfea39605fae84c8f735bdfd9a41
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125158
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [9af6403ee5ed87c49925d25f6601ace963cb3070]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc921ffa9a0c4647f535be7e9f5aab81bc0fd343
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2b2a38f3577c9365b917c65b61cf7d0b92e649bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125157
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [20fd474174d7505bbbeddf2e3d2f1faa1a2872df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4868cff6a92de396f6e1646586baa7eb35eb0218
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8c939f682ae369a2ecb33203d02f232809b918e2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125155
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [037330d335d82185b2955665667cf7797af8fbc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c64b2a06c838d9c61f1b5f8671c6cba86ee2aad
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ice5d40af063bb08c19325037978650c065a745e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125156
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [61314aab68ce8eda063d5850b0ebd3eb82d850ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30b7eb57f1b9c038246ad2b974d39827ae1e45d8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1d6856648fa36c3146a6ca0b1f5659f8850d28dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125154
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [cc41d279a0a1cc55bd2bea23511eeb6956d53e14]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b1d979528aed9b69555b715fba626d2f9c7f910
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icae59f764548a91846727a609f9c263765cd70d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125152
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [70727dbc7d603915a0a231d95cfadb324bea3a55]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8914c4e02e47eba452bc8a3f56fe7976e0cb7d11
          - tdf#132643 Translate German section IDs
            
            Change-Id: I081fc3c5f0dc980c2d0166572d71a3592382a41c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125153
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [4af3e944359524dba149eb21c6e8623e2cdcbd8e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37961398df8cba86eda93ee45eec0811f07ce33b
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iae810efb5bd81798c83f06d30ceed5d133c2b210
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125151
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [7bea7d2fb151bf19f03a26bc1f56cb9a02051227]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 05811f86df828b84d6ec8eefbed023e419ceb1df
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia0dce805a0f874521aa3886a3814ee50573bdc58
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125148
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [e5bf2ae4c3904a7accb07e0ae8103b4d6d16905d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c8f4d6dc1d7ca2b6d1b6f1585b2e55a6c1e68af
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibd18d6e89066d7d6190f5ccd3733653d55109277
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125150
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [51447de533b50621889e24e5cba4e90d0284d56f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d2e52d5d059ef739ae6dd358f3af9d0dc287bf65
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8fc287bda183edb4b70f8c18caf1cbe6f88db85b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125165
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [c203c9382050ac878ee708daa685750e5d6354da]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4dbf7fe3c1fa86b9a3073e3d972b737f9dafccf0
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iedcdf99beb067b94d27d9af47181a9b336d5fb93
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125167
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Johnny_M  <klasse@partyheld.de>  [45fd52e57f05f16eeebb333f3e5c64d0995638e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 38e770261da31bdacfa3981952e7bdf150590868
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic1e168e203be83709ea0f9010caec11826842329
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/125149
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-16  Miklos Vajna  <vmiklos@collabora.com>  [1c90d26f455cf5f7a066eeb4fdcbd6fca2cf60cd]

        chart2: disambiguate ShiftedCategoryPosition
        
        There are two of these: one sal_Bool in a .idl file and a bool in a .hxx
        file. They need to be printed differently with SAL_DEBUG(), so rename
        the C++ one to avoid confusion.
        
        Change-Id: I0f79908a7b74742410813166370cb8ba3017e727
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125256
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-16  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [b40877d31e8d7d0102ac7dedc67eb6e91067d27d]

        Colibre: tdf#144036 add UNO Object Inspector
        
        Change-Id: Ic753ee4d3f4d23bc08b299dba2b6edd43bc0162f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125266
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [35d9d085436e159bdeb6cba9c94865d6346af530]

        uitest: sc: add support for pivot table popup
        
        Change-Id: Id990178051e81a81bf6f6a0fb920473d3ee21fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125259
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-15  Michael Stahl  <michael.stahl@allotropia.de>  [d405d73c60d9a86631f592ba4b4cc97ee43fec38]

        tdf#121546 sw: don't use undo array's m_pOutlineNodes
        
        It's pointless.
        
        Change-Id: I304c123bffc16e6133d2953bc9a4f7a3afad14ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124999
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [2429b8f17ed1d1eb77e314e4bd0b3aae6d4f9acf]

        cid#1401328 silence Uncaught exception
        
        Change-Id: I872a765d570b6c854a8c28c224d23eab05e3538a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125220
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [b947e1899e8c3bacd134418870a0fd6bee4101bc]

        use OUStringLiteral in SVGFilter
        
        Change-Id: Ib01737e8d679ae69612e6612cc39337681953fee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125250
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe65c692cfbf128d55c75207f6d1452713fd72f6]

        OUStringConstExpr should convert to 'const OUString&'
        
        to avoid creating unnecessary temporaries
        
        Change-Id: I222789a4ffba67eaf7e297ecb2a91c3da95f5499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e84592e551d27d5f09e2db26b1495ba2e4069c96]

        Fix typo in code
        
        Change-Id: Idf4fcf16a11f62334ad77db05974a55b5de5d718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125206
        Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [584934b70de97dcbbb91c5a30a5401f6ed57f29b]

        qt6: Fix crash on exit
        
        Extend the solution from
        
            commit fd4bcd5f33fed46cacaa00f90a271b18b6355345
            Date:   Fri Jun 11 11:50:39 2021 +0200
        
                qt5/kf5: Fix crash on exit
        
        to qt6 as well, after seeing equivalent crashes there.
        
        Change-Id: If135a60ed4e6302e9ff4fa51cbc12f8b45b797e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125254
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-15  Julien Nabet  <serval2412@yahoo.fr>  [b6f8611cf9ae565d4cdf8b6d41f444ad63e3502f]

        loplugin:simplifyconstruct/elidestringvar/stringviewparam in scperfobj.cxx
        
        make sc.perfcheck
        =>
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:212:24: error: simplify [loplugin:simplifyconstruct]
            table::CellAddress aBaseAddress = table::CellAddress(0,0,0);
        
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:222:29: error: simplify [loplugin:simplifyconstruct]
            table::CellRangeAddress aCellRangeAddress = table::CellRangeAddress(0,1,0,2,999);
            ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:192:83: error: replace single use of literal 'rtl::OUString' variable with a literal [loplugin:elidestringvar]
            uno::Reference< sheet::XNamedRanges > xNamedRanges(xPropSet->getPropertyValue(aNamedRangesPropertyString), UNO_QUERY_THROW);
                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:191:14: note: literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]
            OUString aNamedRangesPropertyString("NamedRanges");
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:217:40: error: replace single use of literal 'rtl::OUString' variable with a literal [loplugin:elidestringvar]
            xNamedRanges->addNewByName(aName1, aContent1, aBaseAddress, nType);
                                               ^~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:214:14: note: literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]
            OUString aContent1("B4999");
            ~~~~~~~~~^~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:217:32: error: replace single use of literal 'rtl::OUString' variable with a literal [loplugin:elidestringvar]
            xNamedRanges->addNewByName(aName1, aContent1, aBaseAddress, nType);
                                       ^~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:215:14: note: literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]
            OUString aName1("single_added");
            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:244:25: error: replace single use of literal 'rtl::OUString' variable with a literal [loplugin:elidestringvar]
            xSheets->copyByName(aSourceSheetName, aTargetSheetName, 70);
                                ^~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:240:14: note: literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]
            OUString aSourceSheetName = "aSheet_2";
            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:244:43: error: replace single use of literal 'rtl::OUString' variable with a literal [loplugin:elidestringvar]
            xSheets->copyByName(aSourceSheetName, aTargetSheetName, 70);
                                                  ^~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:241:14: note: literal 'rtl::OUString' variable defined here [loplugin:elidestringvar]
            OUString aTargetSheetName = "aCopiedSheet";
        
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:110:67: error: replace function parameter of type 'const rtl::OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
        uno::Reference< uno::XInterface > ScPerfObj::init(const OUString& aFileName)
                                                          ~~~~~~~~~~~~~~~~^~~~~~~~~
        /home/julien/lo/libreoffice/sc/qa/perf/scperfobj.cxx:59:60: note: previous declaration is here [loplugin:stringviewparam]
            uno::Reference< uno::XInterface > init(const OUString& aFileName);
                                                   ~~~~~~~~~~~~~~~~^~~~~~~~~
        
        Change-Id: I99a067e94d4eff228f87b41a38e3749400762fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124793
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-15  Stephan Bergmann  <sbergman@redhat.com>  [b56ff590a3bd2d09b8f72f0ec1030505e59f9008]

        fix typo in comment
        
        Change-Id: I267390e6d7251ec59c6374ca904ccba16f2a94bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125253
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2021-11-15  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [a2f6043f26e8b4025c2143972fbe533b17c40257]

        Just remove these pointless apostils
        
        None of the other items in the list have “Upper” or “Lower” [sic]; the strings
        are self-explanatory.
        
        Follow-up of commit 3165f0ff32b002a6efbc61af4f778ba4075b496e
        
        Change-Id: I3ba88cfca080708daeb76ba3af0a1ae196b2fd85

2021-11-15  Luboš Luňák  <l.lunak@collabora.com>  [b90a5d0f23ffdf1b43c752db424c65bec6f0e8f1]

        Revert "improve performance of cell equality comparisons)" (tdf#139612)
        
        This reverts commit 5e9c2677e8fcd19b289d947b94ceba52b138728b.
        
        Reason for revert: I based this on code that tdf#139612 talks about, and which is possibly incorrect.
        
        Change-Id: Ie9e46a19ac8fe10bbf6cf6f429741200684d5bfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125138
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-15  Luboš Luňák  <l.lunak@centrum.cz>  [f0b745e59f150ea33fc09eb88d682f8cbc085f7c]

        build all solenv build tools always as optimized
        
        Because they are tools used during the build.
        
        Change-Id: I66ef65c16551a5242dcc687e200c81cdab7b463f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125251
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [82dab2e8c72c024794862b487d6988ad576e57d6]

        gtk4: complete do_collect_screenshot_data
        
        Change-Id: I6bb13ca5d174d8a5cccff24953bc2b3057769c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125243
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [acb3638afd79472851bdf111192a2c023f44bf67]

        replace an ugly coverity warning suppression
        
        Change-Id: I73921e43e7e955793493e2accab4e3799cfd121c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125221
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Luboš Luňák  <l.lunak@collabora.com>  [8cfc86c652bc02eca2733498d4459bd24de2158b]

        disable Writer shadow hack in LOK case
        
        LOK redraws always with new content, so there's no need to rewrite
        any possible previous content, and this breaks transparency in LOK
        case.
        
        Change-Id: I1df3fe738f5ac1290720f0e18d6d391e220eb8ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125133
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [499b6d679866a952e40e16ce16f997ecb5ec5853]

        tdf#145640: sc_uicalc: Add unittest
        
        Change-Id: Iba1723704b3fafdd52e32ae0f5f2cc986ba2ba16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125245
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-15  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [6ea7ca45782a7e1b46e18e994534ec0a7c71951b]

        tdf#141709 Register poppler_data for install
        
        Added call to gb_Helper_register_packages_for_install to RepositoryExternal.mk
        for poppler_data.
        
        Change-Id: Ie65ff0083d2c731486254066db2034e3bd4a99a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125108
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [c2cdae9c87cead2a7901b0c173a9561e24162678]

        Resolves: tdf#145663 nL is the index of the light to set to the model
        
        don't reuse the variable in another loop before its finally set to the
        model
        
        Change-Id: I336d8c0f3ce612448dd639e939e65fb434da1513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125208
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [4836e15ba980ea3bdccd3c063eb94f52e35646b0]

        gtk4: implement CreateChildFrame
        
        which gets the extension options tab pages working, e.g.
        "English Sentence Checking"
        
        Change-Id: Ib98f366fdcc7c51f4399372a78f78a655b3c0b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [a63dbd76888043bc12ae1b3b6780a10291a34b38]

        gtk4: fill in more of the assistant code
        
        Change-Id: Ibcc4eca0abd37c733d60042025c0688a3932002b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Stephan Bergmann  <sbergman@redhat.com>  [829ea811e19fead7ad35049342136b592077674b]

        Avoid some -Werror,-Wdeprecated-copy-with-user-provided-dtor
        
        ...after e6968f0485cfb2f6c941d11c438386e14a47095d "PPTX import: fix handling of
        theme overrides in the chart import" introduced a use of std::make_shared<Theme>
        
        Change-Id: I5f6384b81e02034b6b2fdf3a3bad0148de4eb584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125228
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-15  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e140caf2638b7718cd0bebdaaf86373f0828cbf4]

        UITest: refresh fields for test to ensure we check calculated value
        
        Change-Id: I696d24ba087c2e7d19e9818f4f653e09eca7f32e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125222
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-11-15  Dr. David Alan Gilbert  <dave@treblig.org>  [a00fab4e6b7b62a2d9447127a0454da06c83ed54]

        test_corefl: Fix OSL_ENSURE bracketing
        
        cppcheck spotted a couple of misplaced brackets where the
        error text was ,'d after the end of OSL_ENSURE
        
        Change-Id: I5ab2c79b2438b764956e8064df95e713997ad2c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125018
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-15  Jean-Pierre Ledure  <jp@ledure.be>  [6b4f02396b1c0e113be88c82126e23099dc78737]

        ScriptForge - (SF_Calc) new OpenRangeSelector() method
        
        The method activates the Calc document, opens a non-modal dialog
        with a text box, let the user make a selection in the current
        or another sheet and returns the selected area as a string.
        This method does not change the current selection.
        
        Arguments:
         Title: the title to display on the top of the dialog
         Selection: a default preselection as a String.
           When absent, the first element of the current selection is preselected.
         SingleCell: When True, only a single cell may be selected. Default = False
         CloseAfterSelect: When True (default-, the dialog is closed immediately
           after the selection. When False, the user may change his/her mind
           and must close the dialog manually.
        Returns:
         The selected range as a string, or the empty string
         when the user cancelled the request (close window button)
        
        Example:
         Dim sSelect As String, vValues As Variant
         sSelect = oDoc.OpenRangeSelector("Select a range ...")
         If sSelect = "" Then Exit Function
         vValues = oDoc.GetValue(sSelect)
        
        The implementation requires a new module: SF_DocumentListener.xba
        
        The method is available for Basic and Python user scripts.
        
        Change-Id: I2d67a9c900ea8ac661cd6b6fb43bb4a34e6abd8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125201
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [97c59688a074dc24092c2887ed665b6940f4c97f]

        gtk4: fill in some missing parts of Widget::draw
        
        Change-Id: I43af62289369b846f332d350a1a8caa56b6cbe20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [e3f9e4beae47a168416f032f1354a26cb2be0d67]

        gtk4: implement screenshot
        
        Change-Id: I4d9e01a246a6cd7296b405cb6d5424137f4faacf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125226
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [28fc57ee7dcd26284649c5fefbf5d06abd9b70ca]

        gtk4: implement something meaningful for get_monitor_workarea
        
        Change-Id: I3f107f591ebdcaad2f4e986a665b132ccfb78f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125224
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Michael Weghorn  <m.weghorn@posteo.de>  [5470514db7993b4c9f079a961adc30d70fb77fba]

        tdf#139031 Better align dropdowns in PDF export dialog
        
        * set "hexpand" to True for the "PDF/A version"
          and the "Submit format" comboboxes (and relevant
          containers) and add a 6px margin for the parent container
          ("frame4"), so the comboboxes expand to the right
          and still have a proper margin at the right
        
        * Set "halign" to "start" for the "PDF/A version" label,
          as is the case for the "Submit format" one
        
        Change-Id: I2651da2770134aae8d6a494e9de3ec8184664b3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125104
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [90705b67729c849acc7cf196fffa8a2d3c86dc13]

        add a rule to enforce not sharing adjustments between widgets
        
        Change-Id: I44e9548c41de2ea4816d5b87d7491ad06a46f111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125204
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Miklos Vajna  <vmiklos@collabora.com>  [2a8506c2f20f18c948fb4dc5beb42b1010ad6999]

        svl: use std::rotate() in SfxUndoManager::ImplUndo()
        
        Instead of manually moving out, moving a range and then moving in.
        
        Change-Id: Iaff461e1fcee3936c8ddc02bf471a804e7881aef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125219
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-15  Miklos Vajna  <vmiklos@collabora.com>  [c858a59158ed638642139aeda3a720b6a847ff95]

        sw: prefix members of SwInsertIdxMarkWrapper, ...
        
        ... SwLinguServiceEventListener, SwTemplateControl and SwTypeNumber
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia76bd27b6ae361dbeb03d2cdab5b95bd0033460b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125217
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [fcf0d983801603250aa7ce4539951c6b049ad079]

        add a rule to enforce always-show-image of True if an image is used
        
        If not set, then gtk3 will show the image if there is no text, but only
        the text if there's an image. For simplicity sake just enforce it as
        true if an image is referenced.
        
        Change-Id: Id4bb9140ba83e7e07e0d8ec5e3c29aece49b9087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125200
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Caolán McNamara  <caolanm@redhat.com>  [093eb46aea59c2359d122bc8d2c2a7411e9b8a23]

        Resolves: tdf#140250 don't share adjustments between differerent spinbuttons
        
        Change-Id: Ib684c746ff3176cf45ea9364efc12f2d6dde1f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125199
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-15  Stephan Bergmann  <sbergman@redhat.com>  [32334811f09592d669576de00af778c86f637f3e]

        loplugin:fakebool
        
        ..."use "bool" instead of 'gboolean' (aka 'int')" after Clang 14 trunk
        <https://github.com/llvm/llvm-project/commit/4d8fff477e024698facd89741cc6cf996708d598>
        "[clang] retain type sugar in auto / template argument deduction".  Arguably,
        the plugin should not warn about uses of `auto`, but then again there is a very
        similar case a few lines above that already uses `bool` instead of `auto`, so
        clean this one up as well.
        
        Change-Id: I62afa5ed30c192df7fa45aeb7d4a160712fa3794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125215
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-15  Miklos Vajna  <vmiklos@collabora.com>  [e6968f0485cfb2f6c941d11c438386e14a47095d]

        PPTX import: fix handling of theme overrides in the chart import
        
        A problem since commit 08818d8a45e034ad825c7fafbb76766f106f1d1d
        (bnc#882383: Do not ignore themeOverride for charts in .pptx,
        2014-07-04), an override for one chart should not affect later drawingML
        objects.
        
        Change-Id: I22b70c8c82e8e8520179c628f566d7f6663c887f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125218
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c45639a19b277eaaeb1be3798574f91aac5b022]

        move xmloff chart tables into cxx file
        
        instead of playing games with #define
        
        Change-Id: I3f15745b5e107b1e83b97a905cc05fc57f8369bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-15  Hossein  <hossein@libreoffice.org>  [3780e283f47159b078f332604a3914efcc2a73e8]

        Remove unused header path: vcl workben makefiles
        
        Removed boost and other unused header paths from vcl workbench
        makefiles.
        
        Change-Id: Ie8a3abdf599c397a8a75c251a4e530d34e5bb806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125175
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-15  Stephan Bergmann  <sbergman@redhat.com>  [71ac0dac9a585b4383460c4f34314a6083a87685]

        Adapt CompilerTest_compilerplugins_clang
        
        ...to Clang 14 trunk
        <https://github.com/llvm/llvm-project/commit/4d8fff477e024698facd89741cc6cf996708d598>
        "[clang] retain type sugar in auto / template argument deduction"
        
        Change-Id: I3f106eeedf00e622c294c4e4c8326cf3a5e418cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125214
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-15  László Németh  <nemeth@numbertext.org>  [dbc2bdffbec9b3f7eba485652cdd43634458b5a6]

        tdf#145091 DOCX: don't export obsolete table row change data
        
        Rejection of table deletion or accepting table insertion
        imported from a DOCX document kept row changes in DOCX export.
        Use SwExtraRedlineTable/SwTableRowRedline data only if it's
        not obsolete.
        
        Follow-up of commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I247e13e86c0115604079e4852aa8663f1bfead91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125114
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-15  Noel Grandin  <noelgrandin@gmail.com>  [1badef89c0794167b9b84ea44d4a7df5645de8a7]

        rtl::Static->thread-safe static in linguistic
        
        Change-Id: Ie028e0d93f4dec4974d357900a2d5d84275a9a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-15  Noel Grandin  <noelgrandin@gmail.com>  [92857b181a715de08bd4264f4dc4161367d2b3c7]

        tdf#145323 reportbuilder Moving a field corrupts the field
        
        regression from
            commit 09cb778b6eb7d3a5b9029965a1320b49c90e7295
            clean up SdrObject cloning
        
        Change-Id: I7f234dee1dca704195eeebba874c80e73c7abe91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125196
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-15  Hossein  <hossein@libreoffice.org>  [b56abc20eb198057d65ff40575a53cf1e29cf086]

        Clean C++ SDK example "counter"
        
        * Use <iostream> instead of <stdio.h>
        
        Change-Id: I5cc70613c0b183c24bfa73b779dac3b382b31c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123328
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-15  Hossein  <hossein@libreoffice.org>  [52ad81c74887e5c4d9a8c0a3cc8a11e3785cb72c]

        Use basegfx::rad2deg() instead of *57.29577951308
        
        * Replaced multiplying by magic number 57.29577951308 with
            basegfx::rad2deg() which is equal to 180.0/M_PI
        * Instances of this could be found using:
        
           git grep 57.29577951308 *.cxx *.hxx
        
        Change-Id: I0ae99a5d63d104b79c6df2dc88e9dda6973a1d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124226
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-15  Hossein  <hossein@libreoffice.org>  [7a0d3ed55c5b6ebda129d66574d78168ca29135b]

        Fixing the license statement for the Convertor C++ example
        
        Fixing the license statement for the 'Convertor.cxx' and 'Makefile'
        according to the '/TEMPLATE.SOURCECODE.HEADER'
        
        This example was added in 83b529d88388c7c8e0563242a030063bd95c4bed
        
        Change-Id: I654d641999aab6951ad21f84fd75e080bb709ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125128
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-15  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [6f3f033f91a2debe064d4cd127e9f31cf2518db1]

        KJ: tdf#144036 add UNO Object Inspector
        
        Change-Id: I8465b3c2d13210d01f3742cd8bcc40b5692528ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125210
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [abe18bae182fd43d16a6371d2df061565dadcd8a]

        elementary: tdf#144036 add UNO Object Inspector
        
        Change-Id: I944e666905de6d6ca51c8439ca40a687ed8c3e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125205
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-14  Noel Grandin  <noelgrandin@gmail.com>  [864cbd8b2216c043db42351beac3538b4d51adcd]

        rtl::Static->thread-safe static in sal
        
        Change-Id: I04f8a05aaa078642ee5e55c777b9b259c089695b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-14  Caolán McNamara  <caolanm@redhat.com>  [c77a881ee3d9846376f9544c15acbba083cda3be]

        tdf#145655 toggle on always-show-icon for animation panel 'add' button
        
        Change-Id: If50d88f9c4a491f747ab0b39b50823cec92ccb27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-14  Luboš Luňák  <l.lunak@centrum.cz>  [63bb32dff8a5cd469a6e86fa7eb9119d4c40dcfa]

        clang-cl requires -Xclang for -fpch-* options
        
        Change-Id: I96fb0ffaf66476a605966df3f2bde3756ae67ec8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125198
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [28d43b69651289dca7b62341726ae9771ba30e2c]

        tdf#145672 All icon themes except Colibre Export Preview PDF icons
        
        Change-Id: I6e078c16a0033c200012415ee28a86af8e0ea876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125180
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-14  Henry Castro  <hcastro@collabora.com>  [a0c778cda76b765b0bed0795c3779f548f15f1bc]

        lok: sw: remove database tab
        
        It is not functional the database feature yet.
        
        Change-Id: Iea073512424a738dc2d789923740b837d6f3d691
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125113
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit ead2aa7a7088aa2b41a90746351fdf74822dbbe0)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125130
        Tested-by: Jenkins

2021-11-14  Caolán McNamara  <caolanm@redhat.com>  [ec4b6f6b9984f7d6ed50ccb7799a592c593d32c4]

        remove an ugly coverity warning suppression
        
        Change-Id: I243638e242f68d61b639d4afbcb5d65575cc46e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-14  Caolán McNamara  <caolanm@redhat.com>  [d9faec292239a978881c395dce2970176994a614]

        cid#1421164 Uncaught exception
        
        Change-Id: I1268249349e4817c2ebade909b4ce8fa65365407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125171
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-14  Julien Nabet  <serval2412@yahoo.fr>  [29f5bad823016a5d016c3f3012e3c2dc41736303]

        Replace GET_PARAM in ado/ACallableStatement.cxx (connectivity)
        
        Change-Id: I01b7992a5e53dff324208353d8a5196bd16ab0ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125194
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-14  Julien Nabet  <serval2412@yahoo.fr>  [1ba3ab4f7d0b68a584e785de5f9df42e169bce16]

        Replace VISIT_PARAMETER in commontools/parameters.cxx (connectivity)
        
        Change-Id: I4d6bcac319a318623837994ec7942ea49ffa125a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125195
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-14  Julien Nabet  <serval2412@yahoo.fr>  [b99dfd34f5edc2fcb50a491314c486a8bd084259]

        Replace SYM_MAP in evoab2/EApi.cxx (connectivity)
        
        Change-Id: I4df5e2db1c94e5cd29b11d960e3f37dfac3b7ac2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125193
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [574694a9473a1dd40348ede5206a7527900236ad]

        tdf#145670 Breeze & Sifr: Add missing 1.15 line spacing icons
        
        Change-Id: I3620e5fd14e167e6841c58de4d831955bffca23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125178
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [82eda057eb34081c03a75f287e2d735ed9b258a7]

        tdf#145670 Colibre,elementary,KJ,Sukapura: Add missing 1.15 line spacing icons
        
        Change-Id: I2ab7e47063eac4e6e2026346746d6f87062c1669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125177
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-11-14  Hossein  <hossein@libreoffice.org>  [35c85effecb5a615a361c1b7d92d08447bc83423]

        Use M_PI instead of defined value; use rad2deg()
        
        * Replace defined values of PI with M_PI defined in <cmath>
        * Use M_PI_2 instead of PI / 2.0
        * Instances could be found with:
        
            git grep 3.14 *.cxx *.hxx|grep define
        
        * One instance is ignored:
        
          sc/source/core/opencl/opinlinefun_statistical.cxx
        
        * Replace *(180 / PI) with basegfx::rad2deg()
        * Replace 2*PI/360 with basegfx::deg2rad()
        * Use atan2 instead of atan where it was more appropriate
          + atan2() handles all 4 quadrants
          + Extra conditions for different quadrants are removed
        
        Change-Id: I083ee2e1427cd36ba0b8c38e4fe5f782d6486075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124229
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-14  Jim Raykowski  <raykowj@gmail.com>  [4d4278b1403d38b34ff80ca2a92164f40abd9c36]

        SwNavigator: Fix expanded Headings/Outlines not staying expanded
        
        Fixes expanded Headings/Outlines in the Navigator content tree
        collapsing to first level children when a change to the document causes
        content tree update or when Headings/Outlines is toggled between root
        content navigation view.
        
        Change-Id: I473782ad46c52cc40c1994860be7288b1c03c623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125083
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [7b8f630db30ee0066a9f4b6e540368d2fcad7fa8]

        Use o3tl::convert
        
        Change-Id: I78db3001d602ec1a0847785b3c127b9d345f5af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125173
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-13  Regina Henschel  <rb.henschel@t-online.de>  [44f20abf66ce3f9806ad95522d7d9ae698350499]

        use new method too in existing unit tests in svdraw.cxx
        
        Commit 87e5cac has introduced a local method for a common part of the
        new unit tests. Identical parts are used in two existing unit tests.
        The patch replaces them with calls to the new method.
        
        Change-Id: I2945add642ac38048dd1fab4ffc3f2649a261650
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125168
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-11-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [97ef7881cec4f7baa1ef8e7b6b84b6848f8c5f4a]

        tdf#144961 vcl: test PhysicalFontCollection::FindFontFamilyByAttributes()
        
        Note there are missing tests that I will add in the next patch
        
        Change-Id: I98bfb27c424c615f240c687cb5251fe958b4a032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123308
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-11-13  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [a323857126dd420f73492a82f31bb7c8d5400ffb]

        No auto-usage of [s]ccache on Windows for PCH builds
        
        Since that's a pessimisation. Any manual override
        (--enable-ccache, or --disable-pch) will again make configure
        auto-enable [s]ccache if binaries are found.
        
        Change-Id: I4c0773300c792ebb1807d092d3622d90dfac7d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125073
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [39f4fd491ca5abaa8a01b75eb500bb82248ff4aa]

        rtl::Static->thread-safe static
        
        Change-Id: I3010494a750eee70ffe9c24c10417d0a3730dbd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [1b6e3efe964eec9110e656a8242f6f4d8b5e7f7e]

        Simplify m_aAppId initialization
        
        Change-Id: Ib760edab95e988b78505de256aba1b09213600fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-13  Luboš Luňák  <l.lunak@collabora.com>  [359b53acdb14f1661e35c75d8c17fcac9b59faea]

        do not rebuild PCHs on icecream/ccache change
        
        We turn -Wunused-macros on or off depending on whether icecream/ccache
        are used, and since now PCHs rebuild on CXXFLAGS changes, a plain
        temporary 'CCACHE_DISABLE=1' caused a rebuild.
        
        Change-Id: I63d539ac037d595f76a39e585011d1fde54f7f20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125125
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-13  Julien Nabet  <serval2412@yahoo.fr>  [7dc558c29841b9934d1fcadc19fa155b38374feb]

        loplugin:conststringvar
        
        [CXX] vcl/source/window/keycod.cxx
        /home/julien/lo/libreoffice/vcl/skia/SkiaHelper.cxx:664:21: error: variable is only used as rvalue, should be const [loplugin:conststringvar]
                const char* diff = R"(
                ~~~~~~~~~~~~^~~~~~~~~~
        1 error generated.
        
        From https://cgit.freedesktop.org/libreoffice/core/commit/?id=110fa313628c55fef1d35830358aea7e27c1e3ee
        get rid of Skia's 'rasterhack' for Invert()
        It seems that manually writing a shader that does the same
        as SkBlendMode::kDifference works fine even though the blend mode
        crashes e.g. on Windows/AMD. So get rid of the memory<->GPU
        conversions and use the shader as a workaround.
        
        Change-Id: I721d88664f9cb03529ec6e9244424d8e3ed4d156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125126
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [bf2048b1d242c6d5b242f18903612cedf8eaef8e]

        rtl::Static->thread-safe static in StaticNamespaceMap
        
        Change-Id: Iea6f7f96685e332407288af7ada36527acc83a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125119
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a339ebca55f53db5f0b72b26fcfbb3aaa2b2a825]

        Drop unused variables
        
        nWidth/nHeight (1) are irrelevant here (we get the correct pixel size
        right in the hDIB), and (2) should not be -1, because we don't use
        ICAP_UNDEFINEDIMAGESIZE capability [1].
        
        [1] https://twain.org/wp-content/uploads/2017/03/TWAIN-2.4-Specification.pdf#page=268
        
        Change-Id: I8cb20087944536552326b3e1582e8ef12dcc0d32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124986
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-13  Luboš Luňák  <l.lunak@collabora.com>  [9af1dc8a03958c32d4bd56804166293cc1031828]

        add more tests for OutputDev::DrawOutDev()
        
        Test also copy to self and clipped copy.
        
        Change-Id: I3f741e5035fe1f4fb224dc7fe4ba7aa5b4860dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125122
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-13  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a4485bd8e03ad4487fe47a4480a9aacfbaf61980]

        tdf#145610: lists should not have includeUpperLevels < 1
        
        Unlike its name, this variable stores *total* amount of levels
        to includes, so during conversion even empty list format to
        prefix/suffix/includeupperlevels we should keep last one above
        zero so list even in future will not have issues with levels
        to display.
        
        Change-Id: I4992c1ac0194f381df9f7b965ecdb2d688892b30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125022
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [ec1a54ca6033533a20309f3df5b8b5353bb2b509]

        rtl::Static->thread-safe static in OPropertyArrayUsageHelper
        
        Change-Id: I389aed33ec3f814c30fca438ac36af4292b30388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [e6f2736be82559c513aa07c765e9f6c0dd72072b]

        osl::Mutex->std::mutex in OIdPropertyArrayUsageHelper
        
        Change-Id: I19bad304c5c8099fd24be77ec7251e837b513c81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [f4a2c9e91e6b12d4d66b35146ec87b15b365f57d]

        rtl::Static->thread-safe static in OIdPropertyArrayUsageHelper
        
        Change-Id: I21ef0fdc1bf83e313d5dd1079167df0ba59aeed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125116
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Noel Grandin  <noelgrandin@gmail.com>  [98a2cef1ee9c76897af64ff0a1e1efd280796f36]

        modernise IdPropArrayHelper a little
        
        Change-Id: I73bbb59d41ba752e5bbb798ae590e60fdb550d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125115
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [0dbde576f57395c9315e5da8c43e9aedf9094953]

        make SwNodeOffset operator+ and operator- inline
        
        forgot to do this
        
        spotted by llunak
        
        Change-Id: I5e8c723850f77346789ea0b1fb364f5e0d44ae42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125097
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-13  Eike Rathke  <erack@redhat.com>  [79589afe173ba8f17bfbbc6b38f0dfbc5fd9e0c9]

        Resolves: tdf#145640 MoveReference...Reorder() there are RPN tokens as well
        
        Change-Id: I03fdf8f9d94e7a499e995b900bba564cd054bd2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125123
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-12  Caolán McNamara  <caolanm@redhat.com>  [ae73f0f05aa32f2afc737ab9d4a3e028f7647363]

        call GetGetSpecialCharsFunction just once
        
        Change-Id: Ia2ea7b234216408f3209139fa57be8d6a0794ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-12  Caolán McNamara  <caolanm@redhat.com>  [3509a42a042db1628acc59dfc13298639745f62e]

        Resolves: tdf#145645 pivot table popups don't dismiss when item activated
        
        Change-Id: I5a68a08600b7792d924ec77694a60651df5d9c83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125112
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [110fa313628c55fef1d35830358aea7e27c1e3ee]

        get rid of Skia's 'rasterhack' for Invert()
        
        It seems that manually writing a shader that does the same
        as SkBlendMode::kDifference works fine even though the blend mode
        crashes e.g. on Windows/AMD. So get rid of the memory<->GPU
        conversions and use the shader as a workaround.
        
        Change-Id: I971deeeb98f40e5ffa90f6a8dd7b0b21ec491c1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125101
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [754697f0dcd63e1f0ce2edd70ab8b42b1b4d4484]

        revert part of 'loplugin:flatten' in Skia code
        
        The automated code flattening may make sense in old spaghetti code,
        but this is new code, and it's structured the way it makes sense.
        Both those if's are logically just a part of a larger function
        and bailing out sooner is at least conceptually wrong (and the moment
        I add more code there, I'd need to revert anyway).
        
        Change-Id: Iddbd22166159429636196eb1545b008ef576036b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125054
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4d4286a6ae5ad7f57db4f34380ed170b92ced06]

        introduce OUStringConstExpr
        
        so we can declare compile-time constant arrays and structs
        containing OUStringLiteral
        
        Change-Id: I51fd743f2e461a36bb4a0a17c6ff107f86096895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [16be302fededaf2cc6e82701bda6dcba6e3fa4d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79548b2894c85265f0e4cb9ec74c761c1f5955ed
          - Improvement in  English
            
            Change-Id: I9b7da83ad12b20e01499f46667f42e63548f3d58
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124984
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-12  Julien Nabet  <serval2412@yahoo.fr>  [02244b3b651465e65ce192c6e82e91aba44dcd6e]

        Replace REGISTER_PROP in connectivity/evoab2
        
        Change-Id: Icdadadcaa4c6ee9bdaeb6105a33cf1891279781f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125107
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-12  Julien Nabet  <serval2412@yahoo.fr>  [d2fa58b628b3f48c1c8941dbbd9d2faadddeef99]

        Replace some macros in dbaccess part 9
        
        Remove IMPLEMENT_LISTENER_MULTIPLEXER_CORE + BEGIN_DECLARE_LISTENER_MULTIPLEXER
        + END_DECLARE_LISTENER_MULTIPLEXER + DECLARE_MULTIPLEXER_BOOL_METHOD + DECLARE_MULTIPLEXER_VOID_METHOD
        + STOP_MULTIPLEXER_LISTENING + START_PROPERTY_MULTIPLEXER_LISTENING + STOP_PROPERTY_MULTIPLEXER_LISTENING
        + START_MULTIPLEXER_LISTENING
        
        Change-Id: I23dfa9d71b8ae84b9c4ff5e55145e8b350a1eeba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125105
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-12  flywire  <flywire0@gmail.com>  [5f8dc0a2e1ff065978881913156b3ba451231793]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d3d8f1f5279595d78267ed830cc0abb6babccb3
          - Simplify location description
            
            Change-Id: I943bdd1ab68d0f73f3e7735b62c8ef228eecd72a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124700
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-12  Caolán McNamara  <caolanm@redhat.com>  [942c8654648ab18a32b00eb686ce04d9ee668617]

        insert special character in sql view in dbaccess using an arbitrary font
        
        The font to use in the editengine is set with the fallback list notation
        "Font1;Font2;Font3" and while SvxCharacterMap::SetCharFont explicitly has...
        
        {
            // first get the underlying info in order to get font names
            // like "Times New Roman;Times" resolved
            vcl::Font aTmp(m_xVirDev->GetFontMetric(rFont));
        }
        
        which is supposed to resolve to what the physical font is, it appears
        that since the ancient merge of:
        
        commit 2f382d6c2579a25c68dbd121af7f1f5dc7ec9852
        Date:   Thu Mar 27 16:59:30 2003 +0000
        
            MWS_SRX644: migrate branch mws_srx644 -> HEAD
        
        a change was included of:
        
        -    // Fontdaten ermitteln und setzen
        -    aMetric.SetName( pMetric->maName );
        +    // set aMetric with info from font
        +    aMetric.SetName( maFont.GetName() );
        
        which means that font names like "Times:Times New Roman" appear in the
        FontMetric for the font and not the font name of the physical font that
        the metric describes.
        
        That doesn't look right to me, but rather than get bogged down in
        changing that and the undoubtedly infinite chain of knock on problems
        that will trigger just start with a simple font name here not the
        fallback list.
        
        The font is "Liberation Mono;etc;etc" so the first one is certain to be
        available.
        
        Change-Id: I58809be8edb515d9823867c7a0bce5931dccbd27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [3e8214734f9695d7f16c4a37f1a497aeb229d677]

        Add a comment clarifying intended replacement for non-const operator[]
        
        Change-Id: Ib6cd01e1da3e23521e2ae385b8f50046000da410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125103
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-12  Regina Henschel  <rb.henschel@t-online.de>  [87e5caca7d3133a32d92503bfa8e5a1409545187]

        tdf#143021 unit test enable 'matte' extrusion surface
        
        This adds the missing unit test for commmit
        70a4cb766ed356bc17433ac1673e977bb0bf3d2f.
        
        Thanks to Tomaž for extending the test framework to 3D.
        
        Change-Id: Iffaa163c3d453318bc0ed7f8703af15bd20c8966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125013
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-11-12  Attila Szűcs  <szucs.attila3@nisz.hu>  [9fdb9c5fd71e61ae673c79064e3249ce7207031a]

        tdf#145611 sw: fix regression: undoing page breaks
        
        at pages with endnotes.
        
        Added a nullptr check for section to avoid crash on Linux.
        It seems, SwSectionFrame::m_pSection can be nullptr at that point.
        
        Regression from commit 4c31b4ef2083087a822c3ae648fd09acc67d2f88
        "tdf#139336 sw: fix extra pages of multicolumn sections with footnotes".
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Iec4ff93df6720d0e62af59117cd03bd3902c0f64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125095
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e3f2699eb402164391776851a9dd95026ef40032]

        Fix typo
        
        Change-Id: I45cff1f3182fd17776281d1daf49477077779ebe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125099
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [e410094c1c0565cbff335c71cc5ebb2ea4e706e2]

        tdf#126605: sd: move UItest to CppUnittest
        
        Change-Id: I6c7da3f903199027cd7cb446bdc559fcc27b3828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125096
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-12  Heiko Tietze  <tietze.heiko@gmail.com>  [4141c13da8245b5ed46be3b7034d014d75f433f9]

        Resolves tdf#70519 - Make wavy lines depend on zoom factor
        
        Solves accessibility issue of too faint spellchecking indicators
        
        Change-Id: Ic5bc9e205981e90c8f4ee12aa52dde723da1e7aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125038
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-11-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e9577ef8265ec579066b2daa7de3f1b15044b2b7]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5cf23af85b47be6e398add826da1a02175be4238
          - Add "exrtudir" to spell check for pt-BR
            
            Refactor by PTG tool
            
            Change-Id: I78d0caffbbe04d1d0b75ae1dab95470452692550
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/125106
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-12  Hossein  <hossein@libreoffice.org>  [d49807bb277f69cfd494f10399e59bd9947a9d29]

        Add error handling while creating absolute url
        
        * Added error handling while creating absolute url from file name
        * It was reported as ofz#1493240 Unchecked return value
        * It has been silenced in 30f1617bd873d9ccf343a280ba27f476d4c7726e
          and b7c8e4f8ae5402eb665f758f75123e9fe1514d01
        
        Change-Id: Idb8116a5805be38cc37ec1ba28ef226ba160e25b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124214
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [5e7421b3895aa69ea874fc2ccf0f615b1163fbda]

        rebuild a PCH when the flags it was built with change
        
        We already store the flags in a .flags file for another use, so just
        handle the file as another make rule before the PCH rule and
        if the file changes then the PCH rule will depend on something
        that has changed.
        
        Change-Id: Ic43068273a40c0337b77221660f370780a21340c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125094
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [7a65f43709b2945cca935158c72c28dc77ba65b2]

        adapt to Sequence::operator[] non-const removal
        
        5054202e71605cb4f10c798be76679 passed Gerrit before the changes
        and I submitted it only later after the changes.
        
        Change-Id: I251f50f417964f23e5e91aae6696df609fee9e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125098
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Caolán McNamara  <caolanm@redhat.com>  [e467d936452bd428fe71339803fa22eb0a5f31e2]

        Resolves: tdf#145582 modify called too often
        
        a problem since:
        
        commit 5b98dd53c7dc101d3a5ff693d3f0520ec1abd3d1
        Date:   Tue Aug 3 12:28:23 2021 +0100
        
            tdf#143657 'execute' button doesn't get enabled when contents changed
        
        which was a fix for the problem since:
        
        commit 73c9ef661d9ef6237d3fd3c259fd040a545b44cf
        Date:   Tue Jul 6 18:51:38 2021 +0200
        
            tdf#132740 don't broadcast if modified status has not changed
        
        Change-Id: Ibae42251ce04229283283407bc2ab986272e945d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125090
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-12  Stephan Bergmann  <sbergman@redhat.com>  [7b26ac7e8eba298ba173c682bbd952f60a59c5f3]

        Fix HAVE_CPP_CONSTEVAL check for MSVC
        
        For one, it always trivially failed with
        
        > LINK : fatal error LNK1104: cannot open file 'LIBCMT.lib'
        
        because of a missing LIB env var expected by cl.  (Rather using LDFLAGS with
        something like
        
        > LDFLAGS="$LDFLAGS -LIBPATH:$COMPATH/lib/$WIN_HOST_ARCH"
        
        instead of prepending LIB to $CXX via env wouldn't work, as AC_RUN_IFELSE puts
        LDFLAGS too early on the compiler command line, causing "cl : Command line
        warning D9002 : ignoring unknown option '-LIBPATH:...'".  And just using
        something like
        
        > CXX="env LIB=$COMPATH/lib/$WIN_HOST_ARCH $CXX"
        
        instead of the full $ILIB would cause "LINK : fatal error LNK1104: cannot open
        file 'kernel32.lib'".)  This means that the HAVE_CPP_CONSEVAL check had to be
        moved past setting up ILIB.
        
        But for another, detection of HAVE_CPP_CONSTEVAL under --with-latest-c++ would
        trigger MSVC bug <https://developercommunity.visualstudio.com/t/1581879> "Bogus
        error C7595 with consteval constructor in ternary expression (/std:c++latest)"
        at
        
        > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression
        
        (and see also f8a30a87a9d0c68dc16d5fa2ca63f687b1d90da1 "Fix (mis-)uses of
        temporary O[U]StringLiteral") so add a test for that bug to the checking code.
        
        Change-Id: Iedf793f388fc190555a71ed3ab63e87a77ad4828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125093
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [309bffba603ae65e76148dff3add1a541a2b5d81]

        make it explicit whether to ignore the result of getLOKPayload()
        
        Returning an empty string to signify 'ignore' was a poor design,
        as some messages types actually may have valid empty messages.
        
        Change-Id: Ia82d3d97d150bc5ef412a1bd4b1091d9b2d84385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124979
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Miklos Vajna  <vmiklos@collabora.com>  [39f231360013e944a8713248359662b9f282d902]

        sw, out of order undo: allow multiple actions from other views
        
        Previously we assumed that the action to be executed is always exactly
        the top of the undo stack minus 1 element.
        
        Extend this, so that in case an other view appends two or more elements
        to the undo stack, we still find our undo action. Obviously only do this
        if all those undo actions are independent from us.
        
        This requires replacing the swap in svl/ with a move-out + move a range
        down + move in construct.
        
        Change-Id: Ic12d32d6eb5e77618d99eddb4fa096802f32d655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125076
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1a9d507d92cc793f7f10f87cdd7a5534faa5759]

        uitest: sd: Add UItest for .uno:ExportToPDF
        
        Change-Id: I9ec7fd16c51c0240d041784d03aba687e07656ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125092
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3076ba858509756d8e69000632b41e06d14043e]

        uitest: sc: Add UItest for .uno:ExportToPDF
        
        Change-Id: I73b1ed04edb883c78316e10650da30e81eac78df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125088
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [5054202e71605cb4f10c798be766798d99cb1b6a]

        make it possible to find out what fonts are actually really used
        
        A document specifies which font each text is supposed to use,
        but we still need to map that to a real available font, which
        includes also font fallback in case the font selected doesn't
        cover all glyphs.
        
        This commit adds API to track this font mapping, first
        StartTrackingFontMappingUse() will make VCL record this
        information, and then FinishTrackingFontMappingUse() will stop
        and return all the information, as a listing saying that
        a requested font got mapped to a list of fonts and the number
        of times this took place. This can be useful to find out
        what actually gets used for a specific document, or compare how
        changing fonts available affects a specific document.
        
        Change-Id: I6426ecef354166bef337b1dc9b9007fda148d5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123051
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2247f86e42c05991165834ff5d63731b0da2b3b]

        improve mergeToSinglePolyPolygon
        
        spotted by llunak.
        
        No need to take param by &&, since mergeToSinglePol does not
        actually need to modify it.
        
        Also flatten it a little.
        
        Change-Id: I2f5ade347db756e21ecb0a88c3935805268f5072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125086
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [67c541621b701a6873f4e507ad9cc4119b2985bf]

        uitest: sw: Add UItest for .uno:ExportToPDF
        
        Change-Id: Icb28ec46e2db5c67f105a61a79e65edfde1df6a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125081
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0a4aa475e29bd030313c1a17e962386e6d063ca]

        tdf#145584: sw_uiwriter3: Add unittest
        
        Change-Id: I2713a6563542307e8103a88301bb623bd8da11d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125079
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-12  Michael Stahl  <michael.stahl@allotropia.de>  [bb58293296f843654045d7b0eba6899d11533a4a]

        rhino: unbreak build on Fedora 34
        
        Sometime during the Fedora 34 lifecycle, ant started to put
        /usr/share/java/rhino.jar on the classpath used to invoke javac,
        which results in:
        
            [javac] workdir/UnpackedTarball/rhino/src/org/mozilla/javascript/optimizer/Codegen.java:202: error: reference to Hashtable is ambiguous
            [javac]         Hashtable possibleDirectCalls = null;
            [javac]         ^
            [javac]   both class java.util.Hashtable in java.util and class org.mozilla.javascript.Hashtable in org.mozilla.javascript match
        
        Indeed /usr/share/java/rhino.jar contains a class
        org.mozilla.javascript.Hashtable, while it doesn't exist yet in the
        older rhino1_5R5.zip that is bundled.
        
        The problem is that the package ant-apache-bsf contains the file
        /etc/ant.d/apache-bsf which references the system rhino jar.
        
        It turns out that reading the /etc/ant.d/* files in the shell script
        /usr/bin/ant can be suppressed by setting the variable OPT_JAR_LIST to a
        non-empty value, which is documented as "A user should
        request optional jars and their dependencies via the OPT_JAR_LIST
        variable", but which is sadly ignored if set to an empty value.
        
        Another way to fix the problem is to patch the property
        build.sysclasspath to "ignore" in build.xml.
        
        http://ant.apache.org/manual/sysclasspath.html
        
        Change-Id: I6d82eb226e5d01d094ebe044dbdada85b8687814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124934
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-12  Stephan Bergmann  <sbergman@redhat.com>  [f8a30a87a9d0c68dc16d5fa2ca63f687b1d90da1]

        Fix (mis-)uses of temporary O[U]StringLiteral
        
        ...as sub-expressions of ternary operators, which happened to keep compiling
        after 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a
        consteval'ed, static-refcound rtl_String" and
        e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a
        consteval'ed, static-refcound rtl_uString" because both branches are of the same
        type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling
        pointers to those temporary objects escaped the surrounding full expressions.
        
        This was found with an experimental build with VS 2022 with
        --enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking
        fix in the configure.ac detection code (which is forthcoming in a later commit)
        and flagged all these uses in ternary operators as error C7595 "call to
        immediate function is not a constant expression".  That error looks bogus (and
        it also caused a false
        
        > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression
        
        so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that
        compiler bug is fixed), but it nicely found all these cases that should arguably
        be cleaned up.
        
        Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-12  Tor Lillqvist  <tml@collabora.com>  [9c8076f438dfac311a9c7dce559e8ab3ea4fd6e0]

        Include <cstdint> in fxcodec/fx_codec.h
        
        Fixes the build of Pdfium on Fedora 34 for me. No idea why it wasn't
        needed on other platforms.
        
        Change-Id: Id0d6172383970b289b6b3b7f6b5c0da998167796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125084
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [897130541646a37e358463cb76aa505b66a1d7ac]

        fix assertion with scaled alpha image in SkiaSalBitmap
        
        The size of the alpha image does not really depend in mPixelsSize,
        it's created on demand and it's just necessary to check if it
        has the right size.
        
        Change-Id: Ic16c7c2b202be31c22b21b0c5ee720bda955bbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125059
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [a8ea76779f8c0ab52f0200249a4a5cc279b914b3]

        log also whether SkiaSalBitmap has a pixel buffer
        
        Change-Id: Ib78c661ec82456386d79680f106b6d14b66f450f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125058
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [1008f2a06e43c19b7d8b95427198bd691eed5992]

        clean up SkCanvas before using the bitmap it's painted to
        
        I think this is not strictly needed with raster bitmaps, but still,
        this is the proper way.
        
        Change-Id: If6ccf82cf633afefa5c043096ec01b5f3891dc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125057
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [b11a510541f3758e1769f75b34cf27e70b846923]

        drop usage of SkSurface::draw()
        
        It causes so many problems that it almost doesn't get used in practice
        anyway.
        
        Change-Id: Ie11042749d0cca998af45be1daee6f14bf9531f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125056
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [5fe5ded723b2bea0c88ebc7647284dc0ade97ee3]

        simplify construction of XMLPropertyMapEntry
        
        so we don't have to pass in the size of the string literal.
        
        This is mostly a preparatory change, to make an another
        patch of mine less noisy.
        
        Change-Id: Idafcd68586b8b465e63dc89e4a4180d2e70ac3a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-12  Julien Nabet  <serval2412@yahoo.fr>  [6bd74e49f8a99f14a7d8bdc005e2fd50e773841b]

        Replace some macros in dbaccess part 8
        
        Remove DECLARE_PROPERTY_MULTIPLEXER + IMPLEMENT_LISTENER_MULTIPLEXER_BOOL_METHOD
        + IMPLEMENT_LISTENER_MULTIPLEXER_VOID_METHOD + IMPLEMENT_LISTENER_ADMINISTRATION
        + IMPLEMENT_PROPERTY_MULTIPLEXER + IMPLEMENT_PROPERTY_LISTENER_ADMINISTRATION
        
        Change-Id: Ib0522fc895166489c70c163b9d6c0f65cd9a3d59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125078
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-12  Noel Grandin  <noelgrandin@gmail.com>  [2811d0a20e038f6fd573f31eff8d485bd16c81ce]

        rtl::Static to thread-safe static
        
        Change-Id: I6390d1811bad59c09a074039c635710d25a660d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124886
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [00d74a5e0291a40e532b2a0f51fdd5a3e1f487ed]

        Use more o3tl::convert in sc
        
        Change-Id: I624b6c570eff8b6cdc83ffcb2d0dbadf848715b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120330
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-12  Caolán McNamara  <caolanm@redhat.com>  [9871789e0f9256ac27ea7bc4590ba910d6e4c373]

        coverity: annotate with markup so they will stay silenced
        
        Change-Id: I8ac0ae4cd64d8171eebd98d89d1fe954280987b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125072
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-12  Luboš Luňák  <l.lunak@collabora.com>  [0bd7dcf09d1801b03367ecbfd388c5940081d483]

        reduce copy&paste
        
        Change-Id: Ie37f96755f348316bb8d5129df925134943e7ace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125055
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-12  Miklos Vajna  <vmiklos@collabora.com>  [d4f0281f3127255b792a9ec492ba4a14d5ee64c2]

        external: update pdfium to 4699
        
        Change-Id: I545adce0491e48fad2bfc4003695bd96cc911f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125068
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [de7ebc3b545408692bf9563e8b490b7b822fe3de]

        Fix typo
        
        Change-Id: I52608622b775c12c08497f05fffd7639f2543a34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125074
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-12  Mike Kaganski  <mike.kaganski@collabora.com>  [5b160c734fa3f7ab0ef235e99480ce7d14e20224]

        Add a bit of info to the test failure output
        
        Change-Id: I94950217aa979805e3080b4ab9230a799dcab7ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124977
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-11  Stephan Bergmann  <sbergman@redhat.com>  [c36fa9f86e54afa4e1876a9d296ebcbfcbd3a0ad]

        external/poppler: Avoid missing typeinfo in UBSan builds
        
        After 03bc0f97205593547ddf1fc8d4fb396479bcab6d "poppler: upgrade to release
        21.11.0", my Linux Clang UBSan build started to fail to link
        Executable_xpdfimport with
        
        > ld.lld: error: undefined symbol: SplashOutputDev::SplashOutputDev(SplashColorMode, int, bool, unsigned char*, bool, SplashThinLineMode, bool)
        > >>> referenced by PSOutputDev.cc:3197 (workdir/UnpackedTarball/poppler/poppler/PSOutputDev.cc:3197)
        > >>>               PSOutputDev.o:(PSOutputDev::checkPageSlice(Page*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*)) in archive workdir/LinkTarget/StaticLibrary/libpoppler.a
        >
        > ld.lld: error: undefined symbol: SplashOutputDev::startDoc(PDFDoc*)
        > >>> referenced by PSOutputDev.cc:3206 (workdir/UnpackedTarball/poppler/poppler/PSOutputDev.cc:3206)
        > >>>               PSOutputDev.o:(PSOutputDev::checkPageSlice(Page*, double, double, int, bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*)) in archive workdir/LinkTarget/StaticLibrary/libpoppler.a
        >
        > ld.lld: error: undefined symbol: typeinfo for SplashOutputDev
        > >>> referenced by PSOutputDev.cc
        > >>>               PSOutputDev.o:(.data+0x16208) in archive workdir/LinkTarget/StaticLibrary/libpoppler.a
        > >>> referenced by PSOutputDev.cc
        > >>>               PSOutputDev.o:(.data+0x162A8) in archive workdir/LinkTarget/StaticLibrary/libpoppler.a
        > >>> referenced by PSOutputDev.cc
        > >>>               PSOutputDev.o:(.data+0x16348) in archive workdir/LinkTarget/StaticLibrary/libpoppler.a
        > >>> referenced 6 more times
        
        because external/poppler/StaticLibrary_poppler.mk apparently only builds a
        curated subset of poppler source files, but in a UBSan build the implementation
        of
        
          GfxFontLoc *GfxFont::locateFont(XRef *xref, PSOutputDev *ps)
        
        in workdir/UnpackedTarball/poppler/poppler/GfxFont.cc (being the only place in
        Executable_xpdfimport that mentions PSOutputDev, i.e., which is
        apparently never instantiated in Executable_xpdfimport, and that ps argument is
        apparently always null) needs the PSOutputDev typeinfo, thus pulling in
        PSOutputDev.o from StaticLibrary_poppler (which contains the virtual PSOutputDev
        dtor and thus its typeinfo), which in turn needs the SplashOutputDev ctor and
        SplashOutputDev::startDoc from within PSOutputDev::checkPageSlice.
        
        The obvious fix would be to extend the curated list of source files to
        include the missing SplashOutputDev symbols, and any symbols recursively needed
        by those, but that would quickly lead to inclusion of
        workdir/UnpackedTarball/poppler/splash/SplashFontEngine.cc which would fail to
        compile due to a missing
        
          #include <ft2build.h>
        
        from FreeType.  So instead of going down that road of adding in ever more stuff,
        lets try to leave out the problematic definition of
        PSOutputDev::checkPageSlice (which is apparently never called anyway, see
        above).  But leaving that virtual function out completely would cause missing
        symbols in the PSOutputDev vtable emitted alongside the PSOputput dtor, but also
        leaving out that dtor (which is apparently never called anyway, either) would
        then suppress emission of the PSOutputDev typeinfo, which started this whole
        exercise.
        
        So, just for the UBSan builds, define PSOutputDev::checkPageSlice (never called
        anyway, see above) with an empty body, as the least invasive approach to avoid
        the missing typeinfo symbol.
        
        Change-Id: Ifcb80501b71f22d8f14ee29fd8e4480871ee36d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125071
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-11  Caolán McNamara  <caolanm@redhat.com>  [c39749b1472f2719c6de59debd40e793550b5f46]

        remove an ugly coverity warning suppression
        
        if the warning reappears o3tl::suppress_fun_call_w_exception is
        my intended weapon of choice given the now commonplace use
        of std::optional which doesn't have a deleter arg when the same
        problem arises there
        
        Change-Id: If843173a45f50a266fe7a79126bd2892f7686a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125043
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [06ca3d89f4b9761f1bfea66a93f0fc7e0bab71a6]

        Drop ScGlobal::GetEmptyOUString() and EMPTY_OUSTRING
        
        OUString default ctor already uses a static instance
        (through rtl_uString_new), no need to have another
        module-specific static.
        
        Commit d8037ae18a297229d1b79f8f76331abfd548350d had
        removed its sw counterpart some time ago.
        
        Change-Id: I140fe13bc1f6b0cbe188e83e602fdebe995e467a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125061
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-11  Julien Nabet  <serval2412@yahoo.fr>  [be73c64d11fd330f76b08fc75354164aba3ecc88]

        Replace some macros in dbaccess part 7
        
        Remove FIRST_USER_DEFINED_FEATURE and LAST_USER_DEFINED_FEATURE + GRANT_REVOKE_RIGHT
        + ALL_STRING + ALL_INT
        + NSQLAllocHandle + NSQLFreeHandle + NSQLSetEnvAttr + NSQLDataSources
        + LbText + LbPos + CHECK_INVARIANTS
        + OUT_LF + TAG_OFF_LF + TAG_ON_LF + TAG_OFF + TAG_ON
        
        Change-Id: I07261ea0eafcc9f0630f92e47bf5c2f694661933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125065
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce64e3feb72dbe8f14a5b22a6a02722b02b391b0]

        CppunitTest_sc_macros_test: simplify test
        
        Change-Id: Icefb1de06f26b2e0d0b20920fdfef7947cfed964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125067
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-11  Michael Stahl  <michael.stahl@allotropia.de>  [29f08453059c308e3ce076c8689e48b19f84c026]

        sw: the RedlineComment property is settable on SwXRedline
        
        ... but not SwXRedlinePortion.
        
        Change-Id: Ic186e2af76942a796b440c6346dc9443e71438a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125035
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-11  Julien Nabet  <serval2412@yahoo.fr>  [196ac5f5435dfba5bb93e1728c38eb7fa847876d]

        tdf#145584: fix crash on exporting as PDF with Selection rRange
        
        Regression from 20ddabc88b6b45ea3efcc44ede5244ea526b09c4
        tdf#144989 sw: disable idle jobs during printing or PDF export
        The problem is that (with the kde5 and WNT vclplugs) the idle jobs
        update fields and un-hides every section, which destroys the layout
        that SwXTextDocument::getRendererCount() finalised with great effort
        
        bt:
        0  0x00007f773af65dfa in SwXTextDocument::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x66e4980, nRenderer=0, rSelection=
          uno::Any("com.sun.star.uno.XInterface": {_vptr$XInterface = 0x9579020}), rxOptions=uno::Sequence of length 8 = {...}) at sw/source/uibase/uno/unotxdoc.cxx:3012
        1  0x00007f76ff5f2832 in PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) (this=0x7ffc7ee0e990, rPDFWriter=..., rRenderable=uno::Reference to (SwXTextDocument *) 0x66e4c38, rSelection=
          uno::Any("com.sun.star.uno.XInterface": {_vptr$XInterface = 0x9579020}), rRangeEnum=..., rRenderOptions=uno::Sequence of length 8 = {...}, nPageCount=1) at filter/source/pdf/pdfexport.cxx:218
        2  0x00007f76ff5f787e in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
            (this=0x7ffc7ee0e990, rFile="file:///tmp/lu4uimg.tmp/lu4uimk.tmp", rFilterData=uno::Sequence of length 54 = {...}) at filter/source/pdf/pdfexport.cxx:949
        3  0x00007f76ff60a4a8 in PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x71798a0, rDescriptor=uno::Sequence of length 14 = {...})
            at filter/source/pdf/pdffilter.cxx:161
        4  0x00007f76ff60a7fe in PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x71798a0, rDescriptor=uno::Sequence of length 14 = {...})
            at filter/source/pdf/pdffilter.cxx:224
        5  0x00007f7755e60218 in SfxObjectShell::ExportTo(SfxMedium&) (this=0x66d2a30, rMedium=...) at sfx2/source/doc/objstor.cxx:2468
        (full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=176170)
        
        Valgrind:
        ==619070== Invalid read of size 8
        ==619070==    at 0x19227A60: SwXTextDocument::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (unotxdoc.cxx:3012)
        ==619070==    by 0x7403: ???
        ==619070==    by 0x1C4A8B57: ???
        ==619070==    by 0x1C4A8BFF: ???
        ==619070==  Address 0x1ed27e08 is 328 bytes inside a block of size 880 free'd
        ==619070==    at 0x483C71B: operator delete(void*) (vg_replace_malloc.c:923)
        ==619070==    by 0x188EC5CC: SwDoc::release() (doc.cxx:118)
        ==619070==    by 0x1902B92C: clear (ref.hxx:196)
        ==619070==    by 0x1902B92C: SwDocShell::RemoveLink() (docshini.cxx:444)
        ==619070==    by 0x1902B622: SwDocShell::~SwDocShell() (docshini.cxx:372)
        ==619070==    by 0x1902BC07: ~SwDocShell (docshini.cxx:362)
        ==619070==    by 0x1902BC07: ~SwDocShell (docshini.cxx:362)
        ==619070==    by 0x1902BC07: virtual thunk to SwDocShell::~SwDocShell() (docshini.cxx:0)
        ==619070==    by 0x18EFA411: ~SfxObjectShellLock (objsh.hxx:863)
        ==619070==    by 0x18EFA411: SwRenderData::~SwRenderData() (printdata.cxx:48)
        ==619070==    by 0x19227A2B: operator() (unique_ptr.h:85)
        ==619070==    by 0x19227A2B: reset (unique_ptr.h:182)
        ==619070==    by 0x19227A2B: reset (unique_ptr.h:456)
        ==619070==    by 0x19227A2B: SwXTextDocument::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (unotxdoc.cxx:3009)
        ==619070==    by 0x21566DB5: PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) (pdfexport.cxx:218)
        ==619070==    by 0x2156BB83: PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdfexport.cxx:949)
        ==619070==    by 0x21572A05: PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:161)
        ==619070==    by 0x21572F65: PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (pdffilter.cxx:224)
        (full Valgrind trace here:
        https://bugs.documentfoundation.org/attachment.cgi?id=176173)
        
        Change-Id: I03a7ec45a62be2729273111a37c1daaaa3bdf664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125014
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd06044c0178bb7724a735c233aa698e2dcea096]

        tdf#142986: sc: Add UItest
        
        Change-Id: I8469056b0b38b1d714ffdc1cc006beacae6ea3c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124956
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-11  Nnamani Ezinne  <nnamani.ezinne@collabora.com>  [c3773aaf627dda07125358c77f767ac1fe4fa755]

        Impress- Correct commands mentioning Page instead of Slide
        
        Replaced UNO commands that have similar implementation but their labels bear Page instead of Slide
        
        Change-Id: I5fb24493478b0a8fdd4e324066d8112497fc9eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124888
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125047
        Tested-by: Jenkins

2021-11-11  Szymon Kłos  <szymon.klos@collabora.com>  [4fc8c453da759b34e7460da6338a5c2d80e3d3c4]

        Handle UNO command aliases in ToolBoxes
        
        This allows to use ".uno:InsertSlide" which is an alias for
        ".uno:InsertPage"
        in the notebookbar.
        
        Change-Id: Ia52488b65e308a62b686e77b38cba3675deece73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124952
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125046
        Tested-by: Jenkins

2021-11-11  Noel Grandin  <noelgrandin@gmail.com>  [8b98f44b9643bdd873919185a617f530c04203e1]

        rtl::Static to thread-safe static
        
        Change-Id: I98909614d4a8d4317867036678c7202e28dcf285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-11  Dr. David Alan Gilbert  <dave@treblig.org>  [f75974f95f04efef92c2a17eed498d9dd189c7a0]

        ooxmlexport test: fix ?: identical values
        
        cppcheck spotted a pair of:
        
        CPPUNIT_ASSERT_EQUAL(sal_Int32(mbExported ? 11331 : 11331), xChildGroup->getPosition().Y);
        
        where the ?: has the same values; from https://gerrit.libreoffice.org/c/core/+/115668
        
        squash the ?:
        
        Change-Id: I3c1756bd63699408f722824684d71b74c6ea9b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125017
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-11  Julien Nabet  <serval2412@yahoo.fr>  [f1dbe5fdb68b72c4fedd43ddab9cffcf44c9d9b0]

        Replace some macros in dbaccess part 6
        
        Remove DECL_PROP_IMPL + ELEMENT_COUNT + HANDLE_SQL_ERRORS + DO_SAFE
        
        Change-Id: I2208a22329f7611a7fdc896e25bb0ef0bb378abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125050
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-11  Luboš Luňák  <l.lunak@collabora.com>  [9b96b748f324294cdf4b2d60bcea689757e08334]

        do not draw "desktop" (=surrounding background) in Writer in LOK mode
        
        It's meant to stay transparent.
        
        Change-Id: Ia6264c44f369e80092f78a6a6674857460cd7c04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124716
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 7f88f47bb9995eaf4d9cc169788e9fe2006af1ad)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124971
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-11  Jean-Pierre Ledure  <jp@ledure.be>  [bef0b6dfef69472098aa11f4235ddef34d10cd35]

        ScriptForge - (SF_Calc) new Printf() method
        
        Returns the input string after substitution of its tokens by
        their values in the given range
        
        This method is usually used in combination with SetFormula()
        
        The accepted tokens are:
           - %S   The sheet name containing the range,
                  including single quotes when necessary
           - %R1  The row number of the top-left part of the range
           - %C1  The column letter of the top-left part of the range
           - %R2  The row number of the bottom-right part of the range
           - %C2  The column letter of the bottom-right part of the range
        
        The default token character (%) may be modified.
        
        The method is available both for Basic and Python user scripts
        
        Change-Id: If9c3a042abf22ba760d1410b105b04716d092418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125044
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-11  Michael Stahl  <michael.stahl@allotropia.de>  [03bc0f97205593547ddf1fc8d4fb396479bcab6d]

        poppler: upgrade to release 21.11.0
        
        The changelogs tend to mention "crash in malformed files" a lot.
        
        Change-Id: Iadc1d9cc23abd09a8fff58ba0cb7a7803236a542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125034
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-11  Justin Luth  <justin_luth@sil.org>  [eb50d356ffbe5bd2e3de9ac574ddf28ce4e034ad]

        tdf#142986 sc sampling: allow more than default (100) samples
        
        The default maximum for a spinbutton must be 100.
        For some reason, the previous setMax to maxint was removed
        in LO 6.3 in commit 2c5c20b19c349a4b7f6d78d69d8d57f9af5c351c.
        
        Change-Id: I846c1ce037db6ef3b8d48975e24b748cad0394d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124948
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-11  Luboš Luňák  <l.lunak@collabora.com>  [871d5fe3ae531f8849908e50bf87c2848f0b9068]

        do not use grouped cell calculation for just a single cell
        
        We do threaded calculations per row, so there's no point in setting
        up all the thread stuff effectively just for a single thread (all
        but one would be called to do nothing). No point in setting up
        OpenCL in this case either.
        
        Change-Id: I91ea5a7f219f8518a934ecbb04667fa7fba1cdff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125026
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [092e99d5335ffd471dfa6dc75dd42e526e43098e]

        Use o3tl::convert
        
        Change-Id: Ia64ae3445a4aea3be3044e2345e432e839d9a0f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125027
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-11  Julien Nabet  <serval2412@yahoo.fr>  [8770656bfe32d3e89acb6d6da5bda261f2051193]

        Replace some macros in dbaccess part 5
        
        Remove BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER
        + BEGIN_PROPERTY_SEQUENCE + BEGIN_PROPERTY_HELPER
        + END_PROPERTY_HELPER + IMPLEMENT_SERVICE_INFO_IMPLNAME
        + IMPLEMENT_SERVICE_INFO_SUPPORTS
        
        Change-Id: I44499ba68a162b01a9dd5192228b8190b1f40c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125028
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f8e4bd8501e9bb9e286cffed5f35d0f0075e9b8]

        tdf#143128: sw: Add UItest
        
        Change-Id: Idc9584c856382a4e0f9dbd70dbd45d018f8f83e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125006
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-11  Jean-Pierre Ledure  <jp@ledure.be>  [760fc80d167a6bc63305fe3a45dd4df6f87d9f68]

        ScriptForge - (SFWidgets) fix New PopupMenu without event
        
        Invoking the service without an event object was supposed to work.
        
        For instance:
        
           Dim myPopup As Object
           Set myPopup = CreateScriptService("PopupMenu", , 300, 300)
        
        This would create the PopupMenu in position (300, 300)
        without an event object... however this does not work.
        Getting an error saying that "Event is EMPTY"
        
        => Add an IsEmpty() test.
        
        Change-Id: I86a1baf83264921088facbd35bf8fa299a5aa132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125005
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [4cdca3702cda246ecc490c65973e525ff5cf25ab]

        Use o3tl::convert
        
        Change-Id: I62239252efed514de7db88b4bea6f4d4d719fb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125021
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-11  Stephan Bergmann  <sbergman@redhat.com>  [1ef0261539ca6ee8ad9f43d91536c9caa4f7ea53]

        Drop the OUString vs. OUStringLiteral comparison operator overloads
        
        ...which can be subsumed by their OUString vs. OUString counterparts now that
        conversion from OUStringLiteral to OUString is cheap since
        e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a
        consteval'ed, static-refcound rtl_uString".  (The only place that needed
        adaption was the dubious use of temporary OUStringLiteral instances in
        sal/qa/rtl/strings/test_oustring_stringliterals.cxx, which now caused "error:
        conversion function from 'rtlunittest::OUStringLiteral<6>' to
        'const rtlunittest::OUString' invokes a deleted function".)
        
        Change-Id: I4f0f96efa2d5331ed5cbc9a29bdfdf3c0f4148a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125020
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-11  Miklos Vajna  <vmiklos@collabora.com>  [2875c65946e59f5dd7968155463bf00bd71d440b]

        sw, out of order undo: allow a subset of a non-empty redo list
        
        Specifically, we used to not allow out of order undo at all if the redo
        list was non-empty. This relaxes that condition a bit. Out of order undo
        is OK with a non-empty redo list, in case all undo actions in the redo
        list are either
        
        1) owned by the current view or
        
        2) independent from the undo action to be executed
        
        I.e. if view1 has lots of type undo actions and an view2 adds a
        single type undo action on top of it, then allow view 1 to execute
        multiple of its typing undo actions, not just a single one.
        
        Change-Id: I2f5d9404a9994ed74b65233d2a315976c27b28b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125023
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f69ce5f15e7fcae0b595e90631fd5ae2c76ed750]

        Fix typo in comment
        
        Change-Id: I3eddb816734cd31f0d60344b51e8386c9a551ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124969
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-11  Julien Nabet  <serval2412@yahoo.fr>  [c9c9b8ec542d3c491159f23d0deb5358d4142486]

        Replace some macros in dbaccess part 4
        
        Remove DECL_PROP0_BOOL + DECL_PROP1_BOOL + DECL_PROP0/1/2
        
        Change-Id: I422d3dc4c09b5f8a88c8992de187458d74dc3d50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125015
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-11  Michael Weghorn  <m.weghorn@posteo.de>  [f029fb6262b9a001e6cbfd60565b01a7b99ea627]

        qt (>=5.14): Don't create native window for QWidget in QtFrame::screen
        
        For Qt >= 5.14, directly use 'QWidget::screen' (added in Qt 5.14)
        to retrieve the screen that the widget is on, rather than first
        retrieving a window handle, which forces a platform-native
        window to be created.
        
        Due to QTBUG-75766 [1], forcing the creation of
        native windows also leads to mouseMoveEvents
        not being reliably emitted by Qt, s.
        
            commit 0e3c3b842e14b9646d3697cf1266be21359e0f13
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Sat May 11 21:31:33 2019 +0200
        
                tdf#122293 qt5: Use "alien widgets" by default on Wayland
        
        for more details.
        
        The behaviour described in tdf#122293 started showing
        up again after
        
            commit b00a68a8e19370e106cd76258a3c1825f43613ee
            Date:   Sun Oct 31 02:33:46 2021 +0200
        
                tdf#145363 Qt reparent modal dialogs on show
        
        but that just seems to have been a side-effect of
        'QWidget::screen' now being called in different ways
        than previously.
        
        [1] https://bugreports.qt.io/browse/QTBUG-75766
        
        Change-Id: Ic11923cef5e704c09494f96b19157372a869ae40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124997
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-11  Miklos Vajna  <vmiklos@collabora.com>  [84991e145c9e735240114e6ec4b94993060fb6c4]

        external: update libxmlsec to 1.2.33
        
        Change-Id: I42c6ff24237614b2c0d5dc2aa0bcfd9bf7ee89e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125010
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-11  Jim Raykowski  <raykowj@gmail.com>  [cf636b3f5b033d1f1bf511958df96391d81b04df]

        SwNavigator: account for footnotes separator line in initial count
        
        The separator line needs to be accounted for in the initial footnotes
        members count to be shown without delay on first footnote insert and on
        first display of the content tree when there are only footnotes, no
        endnotes, in the document and also for the last endnote to be shown
        without delay on first display of the content tree.
        
        Change-Id: I09a5ad8a0cb4463518a91d680741b49b572cadc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125019
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-11  Jim Raykowski  <raykowj@gmail.com>  [11d3ff1b64424d4f2c660539872f981ab3ed80c8]

        SwNavigator: use stored root-type setting for both Navigator types
        
        Currently the RootType setting stored in Navigator configuration is
        used only by the floating Navigator to restore the root type setting on
        program start to the setting at the end of the previous session. This
        patch makes the sidebar Navigator use this stored setting.
        
        Change-Id: I654f4eb4890351196e64796e4a48031424259a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124456
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-11  Jim Raykowski  <raykowj@gmail.com>  [40fa74fc468ba18c75e8547faff41710ae6fbbef]

        SwNavigator: Don't include Postit fields in Fields member count
        
        To determine if the Navigator content tree needs refreshed, content
        type members arrays are filled with current document content and
        compared with content in the Navigator content tree. If the member
        count between the members in the content type array and the members in
        the content type in the tree differs, the tree is updated and
        redisplayed.
        
        This patch fixes a bug that the Fields content members array count
        includes Postit fields but Postit fields are not included in the tree
        members for the Fields content type. This causes the count in the
        Fields content type members array to always be different than the
        number of members in the Fields content type in the tree when there are
        Postit fields in the document.
        
        Change-Id: I399619f78ee1fc91729a47d403ae403cda9f95cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124894
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-11  Eike Rathke  <erack@redhat.com>  [07a2afa4904ac51c9c61aaf41a9d6c7d41126531]

        Resolves: tdf#110003 tdf#143128 handle lowercase ß vs uppercase ẞ folding
        
        Change lowercase ß U+00DF LATIN SMALL LETTER SHARP S from
        LowerToUpper, ToUpper: SS
        ToTitle: Ss
        FullFolding: ss
        to
        LowerToUpper, ToUpper: ẞ  U+1E9E
        ToTitle: ẞ  U+1E9E
        FullFolding: ss
        
        Add uppercase ẞ U+1E9E LATIN CAPITAL LETTER SHARP S
        UpperToLower, ToLower: ß  U+00DF
        FullFolding: ss
        
        Adjust BASIC Collection test to new reality.
        
        Change-Id: I198e06985b81a71e5de94bf7fab7a0dbaf10baef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124988
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-10  Julien Nabet  <serval2412@yahoo.fr>  [f47a91cc6f1678604c5694ca3987c2f848193b09]

        Replace some macros in dbaccess part 3
        
        Remove IMPLEMENT_SERVICE_INFO1 + IMPLEMENT_SERVICE_INFO2
        + DECLARE_PROPERTYCONTAINER_DEFAULTS + DECLARE_PROPERTYCONTAINER_DEFAULTS
        + IMPLEMENT_PROPERTYCONTAINER_DEFAULTS2
        + DECL_PROP3 (unused)
        + DECL_PROP2_IFACE
        
        Change-Id: Idf18179218b9b1f2da8e4354d8e4909edc925143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125011
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5ae675d3da0ec92ca3929c6078d8fd5c7d3167f1]

        Removed useless semicolons
        
        Change-Id: I787150a7374ac116b3540788cbfa504ee0269a6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124942
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c57865d249a7d9760f4147e3a2379c9ca5a82a96]

        Fix typos
        
        Change-Id: I697591f867fee5332913ee534b9f0ba754239e58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124943
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0ab209bf29e2e6a250a2f65cf9ffe7e07e58eeaa]

        Fix typo
        
        Change-Id: I907bf195997df7aab8679193512bc76d6be46cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125009
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-10  Caolán McNamara  <caolanm@redhat.com>  [c45ec648dc4cbb28643b4d80ad3361eea7234d6c]

        just call erase directly rather than look up index and delete via index
        
        Change-Id: I93f7f43098544ba23a31a985e5b3c07286d8bc1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125008
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9a04e8a2352d2e6290299fb6416f0bdc0c90756]

        tdf#119162: sc: move UItest to CppUnittest
        
        Change-Id: I2e5467e92a4ebbaf2d028dd733d2f4a75eb03bb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125003
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [7930ad202edb8e7af2946fc428268b000edae23e]

        tdf#119155: sc: move UItest to CppUnittest
        
        Change-Id: Id6d162d4348caf512e78eb957034e79f0c2dbc6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125002
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [4185c33788926efe5514cca3ce64a3a8a5d89eac]

        uitest: blind fix for UITest_writer_tests7 failed
        
        Change-Id: Ib49d1ccaa6ca8c42c0ef9caa6ad9acaf41babc3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125007
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [25bc00b4d34edec90217a63904969f3d1943084d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b902fbcc87b0baf76b3dd501f0feff40bb1f3711
          - tdf#141474 Atn, Cos, Sin, Tan function signatures
            
            xxx(number As Double) As Double
            
            Change-Id: Ibf1020ba6027d0f30b3c0a5609c407bbef6660d2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124967
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [eaeca6056c86b4072b49d8687aa44980860702a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 858f7cac7f8fc3ec21c2273c21f7a4b34c608d62
          - Fix caseinline in some Help pages
            
            Change-Id: I67472c239abdb425ad5787bb854638566b29b4f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124847
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9444c925b254cca32c08c473cc294a5f0e90881a]

        new loplugin:stringliteraldefine
        
        look for
           #define FOO "foo"
        that can be converted into OUStringLiteral.
        
        This is the first pass of this plugin, only doing those #define which
        are local to a single compilation unit.
        
        Change-Id: Ic8610e29ec42c36d03db5014a93c244315d5bbea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124962
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-10  Caolán McNamara  <caolanm@redhat.com>  [6610bfdd8c8923e85b30e364c6ea5c7abf218367]

        use a less tortured syntax for the check
        
        Change-Id: If526f187d855760c0462f6573d1f2e42418d9094
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124996
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-10  Stephan Bergmann  <sbergman@redhat.com>  [6334f7dc43f69ada4341d5f0dd1a0f1e13113b4f]

        initialization-order-fiasco, again
        
        ...after b5758cb2729236d9eaf52bd25b1b113a3ff06b4e "rtl::Static to thread-safe
        static" (which this partially reverts again), like
        71d0c43fb4cf535239cb41baf7b6e03de765ce7a "initialization-order-fiasco" in the
        past
        
        Change-Id: Ie3f352a63ee3939b1727faf6cf11b2768173437c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124998
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-10  Stephan Bergmann  <sbergman@redhat.com>  [0ac45af39c534ce17a4a76a370add4ffa4fa92f9]

        Avoid unhelpful loplugin:stringview from implicit conversions
        
        > compilerplugins/clang/test/stringview.cxx Line 149: instead of an 'rtl::OString' constructed from a 'const rtl::OStringLiteral<4>', pass a 'std::string_view' [loplugin:stringview]
        > compilerplugins/clang/test/stringview.cxx Line 150: instead of an 'rtl::OUString' constructed from a 'const rtl::OUStringLiteral<4>', pass a 'std::u16string_view' [loplugin:stringview]
        
        (see the discussion at <https://gerrit.libreoffice.org/c/core/+/124950>
        "operator==(OString, OStringLiteral)")
        
        Change-Id: I5481bef8b8bad7bf9bdf4fff29161f0809051f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124990
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-10  Caolán McNamara  <caolanm@redhat.com>  [48ae3cc1af37271e3ad6ef15a603b1d1add6a69b]

        use tarball names from download.lst for oss-fuzz-setup.sh
        
        Change-Id: I6534e8c81a6598e49de99b08bae80657e1355965
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125004
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-10  Caolán McNamara  <caolanm@redhat.com>  [e03a30925e418db99f5c39920d8f8a1b6d49f20e]

        bump oss-fuzz-setup requirements
        
        Change-Id: Ifda2cd08776a30c83cd1e52a4f0d6d1200d4cb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125000
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-10  Stephan Bergmann  <sbergman@redhat.com>  [0aea45001b73d76fa9b3185ad60df1ac6d2d9b12]

        Only try -prerelease as a fallback
        
        Otherwise, --with-visual-studio=2022 picked the Preview version for me when I
        have both Preview and Current installed.
        
        Change-Id: I1c53a28877a6de80db54ed9b17b1eee0eae923c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124963
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-10  Julien Nabet  <serval2412@yahoo.fr>  [10649a5b3a3813915969ace07ac4ddaafe709718]

        Replace some macros in dbaccess part 2
        
        Remove MAP_CONST_TEXT + MAP_CONST_ROW
        + IMPLEMENT_SERVICE_INFO3 + IMPLEMENT_GETTYPES3 + IMPLEMENT_GETTYPES2
        
        Change-Id: I56e96a782eda1e570a43cb6bad3fa5e52bc08d2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124960
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-10  Caolán McNamara  <caolanm@redhat.com>  [a9232ed3d76e98ca962217e8aff48b165a604188]

        add placeholder labels for gtk
        
        Change-Id: I108816d264affff973d12428cad135edbf8fd7c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124957
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-10  Andras Timar  <andras.timar@collabora.com>  [453363ae1384a6d6f2c77052170b39a1ebf567a6]

        tdf#136111 fix scaling problem on chart driven by a macro
        
        Change-Id: I9a55bcfceb9259f0d5dc944c00a34b3e4a891e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124940
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 0644f44daef7caa8a246221d762fbc0f6af3672c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124864
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-11-10  Tor Lillqvist  <tml@collabora.com>  [34b586dc84b810eece7ae08b4028caba78db319f]

        Add forward declaration to openldap to fix compilation with current Xcode
        
        For some reason the warning about this undeclared function is treated
        as an error by the Clang version in current Xcode, at least for me,
        even if openldap isn't compiled with -Werror.
        
        Change-Id: Ic8479ca63031319ce55c6fb9d95132019ae82cae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124959
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [373b27e7038cf4010a04163861ebec48984b4353]

        tdf#145508 Qt NONE-frames should still be windows
        
        This drops the newly "&& (nStyle != SalFrameStyleFlags::NONE))"
        introduced in the regressing commit
        e4abf879f4a24258bcc560eb58ca78b147768d46 ("tdf#145363 Qt popups
        actually are windows").
        
        A GtkBox based UI snippet, like vcl/uiconfig/ui/combobox.ui, IMHO
        shoulden't be represented as a Qt::Window, but a Qt::Widget. But
        there is no real way to identify it, so lets keep the old, working
        code.
        
        Change-Id: Ic41ff15ab651b422ee95c906cac67e37be8d8a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124958
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-10  Stephan Bergmann  <sbergman@redhat.com>  [8e08fb9476c1b13937ac6d1148b7f675a2e327ad]

        Avoid -Werror=maybe-uninitialized
        
        ...with recent GCC 12 trunk,
        
        > libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx:194:31: error: ‘unoParam’ may be used uninitialized [-Werror=maybe-uninitialized]
        >   194 |     gchar* pPath = g_strconcat(unoParam[1], "/", "type", nullptr);
        >       |                    ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        Change-Id: Ia7ac20ac63b995e8f4a8b4c79447799972639588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124961
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [358754cc5d36eaecda7c704d588b33a3fdf7803c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60560093b76da08195ad1b1dc7bbd17ee2cfb333
          - New methods in sf_Base, (sf_Calc,) sf_Doc. and sf_Writer services
            
            - PrintOut
            - SetPrinter
            
            Change-Id: I809797247ce50c9a74ec8c1c703722911c687993
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124194
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0e4496292f0d67709340879180393c573aeebf93]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a75eb717488b9b5ca9612342e62e4af43aa50a4b
          - Fix path in link for func_sum.xhp
            
            Change-Id: I9ed44d1d28c8c437d5e20448fe0f389e6940b015
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124866
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [b3e3bcb49d7c378deb389e33d568bc3443810004]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49c7e92b634f2bb9d054bd791a1317b9699c093f
          - New method in sf_Calc service
            
            - PrintOut()
            
            Change-Id: Iff97f5fb8585b8c70d4837bdba5eb5ee30852b4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124484
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-10  Stephan Bergmann  <sbergman@redhat.com>  [13e0b122f100a17fa54757e40dd8b334559522a6]

        Upgrade external/boost to latest Boost 1.77.0
        
        <https://dev-www.libreoffice.org/src/boost_1_77_0.tar.xz> has been generated (on
        Fedora 35) with
        
        > $ wget https://boostorg.jfrog.io/artifactory/main/release/1.77.0/source/boost_1_77_0.tar.bz2
        > $ printf 'fc9f85fc030e233142908241af7a846e60630aa7388de9a5fafb1f3a26840854 boost_1_77_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_77_0.html>
        > boost_1_77_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_77_0.tar.bz2
        > Unpacking boost_1_77_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_77_0.tar.xz ...
        > Cleaning up ...
        > 9b334d6c6d7af5a0687280788cd84444398b8e0b472cd88e52bbc3c3ef11d98e  boost_1_77_0.tar.xz
        > Done.
        
        Change-Id: I527cad7eb2f311d968da371f268644bdd31f6462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124947
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-10  Steve Fanning  <stevemfanning@yahoo.co.uk>  [c88c22530eb2ef87986a7c3c8f0f21ac16e508fa]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 99120cbfb9b5c0c75bc1b3317fa87ecab58d170a
          - Update help page for Calc's Mathematical Functions to remove detail about SUM() function.
            
            Leave just a link and a one line overview. This is a follow-up to change https://gerrit.libreoffice.org/c/help/+/124696.
            
            Change-Id: I31898c9f8d1fc0dca83a7d3fc12d466a3d50928c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124865
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-10  Noel Grandin  <noelgrandin@gmail.com>  [b5758cb2729236d9eaf52bd25b1b113a3ff06b4e]

        rtl::Static to thread-safe static
        
        Change-Id: Ie4c26b0b2c0880bcf6ec6d786b219f142d715af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124930
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-10  Noel Grandin  <noelgrandin@gmail.com>  [c606d330864a10caba6e0f9600db56ae445999c1]

        osl::Mutex->std::mutex in TubeBuffer
        
        Change-Id: I3e2ef9f8b34cbc5befe8b19fa2d68dfd518090c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124929
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-10  Tor Lillqvist  <tml@collabora.com>  [b287e9bb4bf60fb49c2832eba0afd85102b84823]

        Add SAL_INFO of what paper sizes the printer (driver) advertises
        
        Change-Id: I9598a829c22cc4d02244fff6616584aa6dbac68e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124916
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e65f21b286a7de1c459761243432e4bbbcd4713]

        inline INIT macro
        
        which is not adding to readability at all
        
        Change-Id: Ib52ff43790a72adb9229d648472a91ee1ef48563
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-10  Michael Stahl  <michael.stahl@allotropia.de>  [c5f620f9f6abae0213fdda17fae10f281b7bdf9f]

        add generate-flatpak-manifest.sh to generate FlatPak manifest
        
        Duplication of external tarballs in flatpak-manifest.in is a maintenance
        nightmare.
        
        The only difference between the current flatpak-manifest.in and the one
        generated from:
        make -s cmd cmd='${SRCDIR}/solenv/bin/generate-flatpak-manifest.sh master' > org.libreoffice.LibreOffice.json
        
        ... is that the current one contains an outdated reference to
        zxing-cpp-1.1.1.tar.gz which was upgraded to zxing-cpp-1.2.0.tar.gz
        in download.lst.
        
        Change-Id: I98ab9346244f2c0d788da391928fcb4ffebbe23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124891
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-10  Miklos Vajna  <vmiklos@collabora.com>  [8e8e72f08b01a284cf1a90b888d48acfb6a33d2e]

        sw: allow undo of typing in 2 views independent from each other
        
        Undoing out of order is dangerous by default, so limit this to a very
        specific case as a start, that allows growing in follow-up commits.
        
        For now, allow out of order undo if:
        
        1) redo stack is empty
        
        2) we're in LOK mode (different views represent different users)
        
        3) we undo a single action (count is 1)
        
        4) the top undo action doesn't belong to the current view
        
        5) the top and the previous undo actions are independent
        
        Which only requires that SwUndoInsert::UndoImpl() is independent for two
        different paragraphs, which seems to be the case.
        
        Independent undo actions opt in for this, currently the only such
        allowed undo action is SwUndoInsert ("typing"), which adds characters to
        a single text node. Even those are only considered independent if they
        operate on different text nodes.
        
        On the positive side, this allows out of order undo in the frequent case
        where two users collaborate on a long document and they just type some
        new content into the document at different paragraphs.
        
        Change-Id: Ibb4551e8f7046b4947491b8bf751eaa0cbb2d060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124949
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-10  Miklos Vajna  <vmiklos@collabora.com>  [cf2d88b8a44ac9e8b37954fc2cc4b52d719cc035]

        CppunitTest_sw_ooxmlexport14: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I7b592b1438d92aa597db1f21294308703c93c6a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124935
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-10  Dennis Francis  <dennis.francis@collabora.com>  [c8af39955e2210c81882ae0676ec32a42fff7898]

        sc: EMBED_SOURCE: extend copy to clip area...
        
        to include the draw objects in the sheet read from system clipboard.
        
        This is needed because GetCellArea() computes the "last row" and "last
        column" only based on the cell contents and not the drawing layer
        contents.  So copying a "empty cells" range that has images in it and
        pasting it will not include any images without this fix.
        
        Change-Id: I56ffb14e881a1aecc5b43590ea4fb3fc1c35ace8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124629
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 789d19776ab451a6118b938830d488961b42dae5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124673
        Tested-by: Jenkins

2021-11-10  Dennis Francis  <dennis.francis@collabora.com>  [3b229856b2f09c496dc0800f8a4efac9fcebda91]

        sc: EMBED_SOURCE: also include objects on copy to clip
        
        This is to match the behaviour of copy-pasting with the internal
        clipboard. If user copies a range that contains some images then on
        pasting these images are also included when using internal clipboard
        document.
        
        Change-Id: I61a6e71bd6afcace51230d1e7e7539e88404cbe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124628
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 430a3e123c24ba2e87d89dddebb4fda4d3ff2e93)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124672
        Tested-by: Jenkins

2021-11-10  Dennis Francis  <dennis.francis@collabora.com>  [42df36429bbb32cd75fa1661a31821a9446ef648]

        sc: fix clip cell range for clip with no content
        
        The problem was observed in LOK mode with the following step:
        1. Select and copy a sheet area with no content.
        2. Paste this into another document.
        => You get an error dialog saying "Protected cells cannot be modified".
        
        The issue here is in ScViewFunc::PasteDataFormat, rSrcDoc.GetDataStart()
        gives the correct cell indices of the clip selection, but GetCellArea()
        truncates the range to empty range as there is no content. Since these
        functions are used in many places which might depend on this behaviour,
        it seems right to fix it just for this usecase.
        
        Change-Id: Ibc85a8d7dd33b377a37298ea9a2a7ebb55eccf1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124627
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 4ff08a1332e5150d7ef978572e747ac8da3a0820)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124671
        Tested-by: Jenkins

2021-11-10  Mike Kaganski  <mike.kaganski@collabora.com>  [40e6ae66b893b86bdda7d414b4bd58bfc612566f]

        Simplify MtfTools::ImplMap
        
        Use o3tl::convert instead of homemade constants; unify logic and
        move common code out of the switch.
        
        Change-Id: I31e53d04017aac7d6a2f435adb9233b9c0e3ba6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124939
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [41b4053d7a395146a488c4aba0bc17b98b0a9502]

        Fix typo
        
        Change-Id: I1ab712c8bea7083e0f32c647d783d12a770322a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124941
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-11-10  Eike Rathke  <erack@redhat.com>  [a0a38b88dc3a61d212d784f41a27f97d9c2d7f32]

        Change CaseMappingExtra commented hex offsets to four digits and uppercase
        
        ... to be able to quickly find corresponding
        CaseMappingValue.value if CaseMappingValue.type is address, and
        vice versa.
        
        Change-Id: I54d86c8f484641af48b6245c17e1f5f8c164c277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124938
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-09  Caolán McNamara  <caolanm@redhat.com>  [098df4ac7e3c8e13c892a324587f8ebdbce273cb]

        Resolves: tdf#142706 ctrl+shift+s to launch insert special characters dialog
        
        there's a touch of xkcd#1172 about this
        
        Change-Id: I2c0a87a4e2190dd0879966c03bf2dac15feef0a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-09  Noel Grandin  <noelgrandin@gmail.com>  [151316b6010c45078e0a031f0ba07d6117c0109d]

        rtl::Static to thread-safe static
        
        Change-Id: Iff3489ee171cf2eaecbd1aad6f942a1468f76512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124928
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-09  László Németh  <nemeth@numbertext.org>  [2fe0881906462cbcbe8baf81068010310fb1c97a]

        tdf#145089 DOCX export: fix track changes of table row insertion
        
        Newly inserted table rows lost their change tracking during
        DOCX import, i.e. rejection didn't remove the rows.
        
        Note: start to clean-up DOCX export and SwTableLine::IsDeleted(),
        preparing the fix for tdf#145091.
        
        Follow-up to commit dbc82c02eb24ec1c97c6ee32069771d8deb394f9
        "tdf#143358 sw: track insertion of empty table rows".
        
        Change-Id: Ib90b745632ec4aeb30651fbff209ecef69657f4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124922
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-09  László Németh  <nemeth@numbertext.org>  [83490dc97ca76c64a7d46839f4dbb8b1610f169f]

        tdf#124904 sw: don't show deletions in referenced text
        
        In fields, strikethrough/underline formatting of
        track changes is not available. If the referenced
        text of the fields contained partial deletions,
        the field showed them as normal text, e.g. mixing up
        the text of a heading with its removed typos.
        
        Now these deleted parts are removed, except in the
        following case: if the referenced text was completely
        removed, show the whole deleted text in the reference
        field, adding strikethrough to its tooltip text to help
        the review process.
        
        Note: this allows to handle both use cases, i.e. when
        only a small part of a heading was modified (e.g. removing
        typos), and 2) removing whole chapters with headings,
        where the fields in the deleted text are more readable
        with the text of the deleted headings, showing the
        original text content.
        
        See also commit daf2a7d957c829c551754871a3545495c0f76bc0
        "tdf#61154 sw Table of Contents: remove tracked deletion".
        
        Change-Id: I98bd8ded1591ae3c84957998e65f3cccac2a7884
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124843
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [87b74da15d2de7c6a8569ede8f2fc6abec7dbcb4]

        uitest: pos must be of type str
        
        Change-Id: Iea469066b11abefd889143d11f86c4cdcb5e03ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124923
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [32fe60e489a6d5192c17ca534c1e19f84681c7cc]

        One LogicToLogic less
        
        And move some variables out of from loop, or into the usage scope.
        
        Change-Id: I74c76a4a16a9ab4b42e1ecce1d195dc496d4cd72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124920
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [631aa91185ce4787da39386b13b714176fd5bee2]

        simplify makefile
        
        put all of the exception objects into one list
        
        Change-Id: I34ad6b5d4f1495ecb3da79540a6a3ec6dad9d16a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-09  Tor Lillqvist  <tml@collabora.com>  [4e01639f2ce64f3f6c3281ef526b3e4645566b6b]

        Add DC_PAPERSIZE_array_to_string
        
        Change-Id: I04a16294321f092a3aebe45735266d4ae34d51dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124915
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [9393325c1db9fa25037d208607b71adb567a8bbc]

        openldap: upgrade to release 2.4.59
        
        Fixes CVE-2020-36230 and CVE-2020-36229 in libldap, plus lots of
        other CVEs that affect only the server.
        
        Unfortunately it looks like NSS support was removed in release 2.5.0.
        
        Change-Id: Ie43d7da1b9e92b5712f9cd22c4613648394c696f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124914
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [b9ec28535df9b94fa65e7ba6cfe7ccbd1e15f5a4]

        Fix --enable-ext-numbertext build
        
        ...by partially reverting 9ba2231084fb788c66a3bbc16cab7c02f35b41a2"download.lst:
        define OPENSYMBOL variables like everything else", which caused
        
        > Makefile.fetch:102: *** "fetch_Download_item: no checksum found for b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt. Please define NUMBERTEXT_EXTENSION_SHA256SUM in download.lst.".  Stop.
        
        Change-Id: Ib9e2032ab3cbb825863d9b5c7744ba7bdad0e1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124927
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [cf41b69356672dcedc4448661547c10dbe03f98a]

        tdf#142033: sc_macros_test: Add unittest
        
        Change-Id: Id569c3f020c50a30f4c55fecdaa3f7849e1cbb47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124917
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [3187e75adc67f76724848e00a8cff6974ee9c8e4]

        remove misleading reference to obsolete build.sh
        
        Change-Id: Idb60619db72c4535abdae8cc3357fad3c06026be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124890
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-09  Michael Stahl  <michael.stahl@allotropia.de>  [9ba2231084fb788c66a3bbc16cab7c02f35b41a2]

        download.lst: define OPENSYMBOL variables like everything else
        
        No reason why the filename should be defined in configure?
        
        Remove unused NUMBERTEXT_EXTENSION_SHA256SUM.
        
        Change-Id: I3d3084e2052cb98ddbe2c1cf10691dcc5d716d19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124889
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [14dbf91aade4798d6369bb993687ae9e9d54e484]

        tdf#145158: sw: Add UItest
        
        Change-Id: I942be9bc342a8a2a1b2f4c526b101e6d446c70fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124912
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-09  Steve Fanning  <stevemfanning@yahoo.co.uk>  [b31e280b3b502ad16ac0ecf2c644a7d040710897]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9077a2887221677690282917c66c7af8e3e37121
          - Improve Example section of help description for Calc's SUM() function
            
            The ability to use SUM in an array formula is important but the help description of an example array formula is uncharacteristically long. Now that the wiki has a more specific example, it is appropriate to shorten the Example section of this help topic.
            
            Also moved SUM description to its own XHP file.
            
            Change-Id: Ic062686c53a1ae8b81100e2b49781aaa79e6ee50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124696
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [a1dd01fd8c2ec5ec320f093da18f99186fb3031f]

        simplify init in action_wrapper_get_name
        
        Change-Id: Ie73f5fc096b918a7cb8a9342b33fab60806c77b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [20168b1f09b4d2aa8643dc7d4a16d8a1dd1008a6]

        The CurlOption curl_off_t case appears to be unused
        
        ...at least for my clang-cl Windows x86-64 build (see comments at
        <https://gerrit.libreoffice.org/c/core/+/124452/5#message-10cc4dfb88a258e59f09c5fbf413052aa9ddd49c>
        "ucb: webdav-curl: rewrite authentication loop for reentrancy")
        
        Change-Id: I4f6b255c6a9acb26844b7ef5c11f0f1fcf06b3df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124907
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-09  Tor Lillqvist  <tml@collabora.com>  [9a8dcf797dd277079e5b58947d7281645aa0389e]

        tdf#145354: Don't let an arbitrary paper size match any other arbitrary size
        
        Don't preselect whatever random paper size the printer driver offers
        last if the document is asking for some other random paper size.
        
        Change-Id: I57af245f28f0d61541da698844f2527be5ec004e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124911
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-09  Tor Lillqvist  <tml@collabora.com>  [1134aad621a96a23af88aaa50e10e328ea58a502]

        Add Printer::GetSizeOfPaper() with semantics to match GetPaper()
        
        Will be used in follow-up commits.
        
        Change-Id: I18b167a217a4f82d8b6605e2ba14f1ddc6e98324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124910
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-11-09  Jean-Pierre Ledure  <jp@ledure.be>  [754247fe3fb1c8baa8f37f7ea1eb74aa3f0bcd57]

        ScriptForge - (SF_Calc) First/Last * Row/Column/Cell accept sheets and ranges
        
        The methods
           FirstCell
           FirstColumn
           FirstRow
           LastCell
           LastColumn
           LastRow
           SheetName
        accept uniformly either a sheet name or a range name.
        They return a single cell as an absolute address (First/LastCell),
        a String (SheetName) or a Long.
        
        The range name is to be understood as the extended notation for ranges.
        
        FirstCell/Column/Row accept sheet names. However they will then always return
        either the "A1" cell or the value 1.
        
        The LastCell/Column/Row return the real last xxx for ranges, and
        the last USED xxx when the argument is a sheet.
        
        The A1Style() method surrounds from now on sheet names
        with single quotes only when necessary.
        
        The GetRangeAddress() method has been dropped as redundant with the actual
        methods. (Was new in 7.3 => no effect on upward compatibiity)
        
        Change-Id: Iff1ce437ee27dfb8481361f648b3f7a33ae2c4b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124904
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [a14b783bbe8eda32b4b79530d85ffc48b6ed0305]

        Drop global -D_HAS_AUTO_PTR_ETC from Windows build
        
        ...which had been added with 61c88ae6945c241f5f2aeb844eeca0776b487132 "gbuild:
        always compile as C++17 with MSVC 2017" but appears to be unnecessary now that
        becbabbb785545af6a1799f5ecd445785534d478 "external/clucene: Remove unnecessary
        uses of obsolete std::binary_function" removed code that relied on it.
        (There are still a few targeted defines of _HAS_AUTO_PTR_ETC sprinkled across
        the code where necessary.)
        
        Change-Id: Id57d24a0e01272864df36cd2ed1cb31c59c30d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124903
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [0a5388fab08474bade08be838f5749f2cae452d5]

        Address of dllimport function isn't considered constant expression by clang-cl
        
        ...causing the (mis-)use of std::integral_constant to fail with
        
        > In file included from ucb/source/ucp/webdav-curl/CurlUri.cxx:20:
        > In file included from ucb/source/ucp/webdav-curl/CurlUri.hxx:24:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\memory:11:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\exception:12:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\type_traits:12:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\xstddef:11:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\cstddef:13:
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\xtr1common(22,26): error: constexpr variable 'value' must be initialized by a constant expression
        >     static constexpr _Ty value = _Val;
        >                          ^       ~~~~
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\xtr1common(28,16): note: in instantiation of static data member 'std::integral_constant<void (*)(void *), &curl_free>::value' requested here
        >         return value;
        >                ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.307/Include\memory(3195,13): note: in instantiation of member function 'std::integral_constant<void (*)(void *), &curl_free>::operator void (*)(void *)' requested here
        >             _Mypair._Get_first()(_Mypair._Myval2);
        >             ^
        > ucb/source/ucp/webdav-curl/CurlUri.cxx(49,25): note: in instantiation of member function 'std::unique_ptr<char, std::integral_constant<void (*)(void *), &curl_free>>::~unique_ptr' requested here
        >     CurlUniquePtr<char> pPart2(pPart);
        >                         ^
        
        etc. as the involved functions like curl_free are defined as
        
          CURL_EXTERN void curl_free(void *p);
        
        in workdir/UnpackedTarball/curl/include/curl/curl.h, where CURL_EXTERN expands
        to __declspec(dllimport)
        
        Change-Id: Ib278cd9e97260b588144d81dba344ccbb5309608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124899
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-09  Szymon Kłos  <szymon.klos@collabora.com>  [2219c329b89882c0bf1167795dd0264db2e1c56c]

        Check pOutWin before use in ImpEditView::DeselectAll
        
        Change-Id: I47e417d61093f1845a1541a65d2047ab8dc0b7d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124325
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        (cherry picked from commit e62b40b056120bb5eebf00fc88f58fe042356520)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124486
        Tested-by: Jenkins

2021-11-09  Kevin Suo  <suokunlong@126.com>  [1798edc6bacf678aef20f9cff46c26acb93abb66]

        Remove this hard-coded "Default" style name in Calc
        
        Replace it with the defined SC_STYLE_PROG_STANDARD macro.
        
        Hard-coded style names can cause problems such as tdf#134161.
        
        Change-Id: I27b5dfd3a4f60785622d51fe903484982f51f803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124644
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [becbabbb785545af6a1799f5ecd445785534d478]

        external/clucene: Remove unnecessary uses of obsolete std::binary_function
        
        ...which has been removed from C++17.  libc++ and libstdc++ still silently
        support it, but MSVC needs an explicit -D_HAS_AUTO_PTR_ETC, and this change is a
        prerequisite to drop that global define again from
        solenv/gbuild/platform/com_MSC_defs.mk (it had been added there with
        61c88ae6945c241f5f2aeb844eeca0776b487132 "gbuild: always compile as C++17 with
        MSVC 2017", but code including external/clucene, like
        helpcompiler/source/LuceneHelper.cxx, appears to be the only code relying on
        that global define)
        
        Change-Id: I512d56f833c516dba3874cb0b4ef5190a88d3faf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124900
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-09  Stephan Bergmann  <sbergman@redhat.com>  [615930949304104933d38f0394ef26e104ecaedc]

        Adapt test to clang-cl on Windows (sal_Int32 typedef int vs. long)
        
        Change-Id: Ic3a27643bd3d5ca3a25449171a3a59140b915769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124901
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3746379f251091696b73463f7b27e8ef732dd20b]

        tdf#48622 Fix layout issue when "Custom" was selected
        
        Change-Id: Ie32a763b88cfc26b61d942214b16e008179d410c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124898
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-09  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8292a950912c66a312210328eda424a2afc46280]

        Save with Glade 3.38.2
        
        Change-Id: I238f8a5adee999fcaad09e8813742fba37a30396
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124897
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-09  Noel Grandin  <noelgrandin@gmail.com>  [f381c353b4b24f185c6517593e78671b33d64baa]

        BaseList doesn't need set member after the constructor is done
        
        Change-Id: Idc174a0cd53c45beba3100b1f8258e6839291be8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-09  Mike Kaganski  <mike.kaganski@collabora.com>  [d55b2631342bc7babf3709f2f83e0e502ebe4014]

        tdf#145158: pre-multiply the value by factor before conversion
        
        Otherwise it is rounded before multiplying. Prior to the regressing
        commit cfff893b9c82843a90aac4ecdb3a3936721b74a0, it was calculating
        in twips, and was only converted to points by dividing by 20 in the
        end, which allowed to keep some precision.
        
        Change-Id: I142371dc630584f3fe64b5bfd5b592d46226ce32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124895
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-09  Noel Grandin  <noelgrandin@gmail.com>  [b3c6b3a274b4c89d3572010794897c65b26571aa]

        rtl::Static to thread-safe static
        
        Change-Id: I35e2a252708228bdbeaee557ef35763c64608653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-09  Miklos Vajna  <vmiklos@collabora.com>  [926ac3c5e4b8eb425bc2db0366594acc0cf2c1ed]

        RTF import: handle \snext
        
        I.e. pressing enter at the end of a heading 1 paragraph should switch to
        body text.
        
        Change-Id: Idde9da3e2c058869a2ae4a9c61b3b43165121f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124883
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-09  Hossein  <hossein@libreoffice.org>  [2f590d0b66eddc53abe775ab344a195489d0a031]

        Simplify conditions for EMR_STRETCHDIBITS (EMF)
        
        The variables xSrc, ySrc (x/y positions) and cxSrc, cySrc (x/y size)
        come from [MS-EMF] documentation, "EMR_STRETCHDIBITS Record" section.
        
        By calculating the difference between Bitmap x size and cxSrc (called
        nWidthDiff), and also Bitmap y size and cySrc (called nHeightDiff),
        the conditions used to test if it is OK to crop are simplified, and
        are better readable.
        
        Redundant checks (nWidthDiff >= 0) and (nHeightDiff >= 0) are removed
        because it is now obvious that when they are bigger than non-negative
        xSrc and ySrc, thus they themselves can not be negative.
        
        Change-Id: I8e82c3d469377f21d34b57f3d50f977cf71004ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124096
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-09  Hossein  <hossein@libreoffice.org>  [83b529d88388c7c8e0563242a030063bd95c4bed]

        Add Convertor C++ example
        
        * Add Convertor.cxx
        * Used Makefile from DocumentLoader with some changes
        * Updated odk make files
        * output.pdf is generated from the input odt file
        
        Change-Id: I3e46f2895443f75b2f3815280b0f793bca5138e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123736
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-09  Jim Raykowski  <raykowj@gmail.com>  [d4c56284813c1e38a2fb46e9a52c5350d1ba3cef]

        SwNavigator: Restore content tree settings before showing
        
        Content tracking by the Navigator content tree and outline levels
        displayed currently do not use the stored Navigator settings when the
        tree is initially shown. This can cause content to be tracked and
        outline levels to be shown that are different from the stored settings
        when the tree is initially shown.
        
        This patch fixes these possibilities by changing when the stored
        content tree settings are applied to before the tree is initially
        filled and shown.
        
        Change-Id: I5443788c3fbacb36695cfc56163f217408254fd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124831
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ccf3d9140a24d767003c08cd0247e6ee6fd12fe0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 02f148c4a8486dcb0ceb2d2d4891a19e132821a0
          - tdf#140395 Update font effect screenshot in Help page
            
            Change-Id: I1ee93b072ccdf750147bb44dac27e9233edaae49
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124893
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-08  Julien Nabet  <serval2412@yahoo.fr>  [e21ebb0a98e81a9591918f3794ece75fb1df7ab1]

        Replace some macros in dbaccess part 1
        
        Remove NOTIFY_LISTENERS_CHECK + CHECK_MATRIX_POS + REGISTER_PROPERTY_BV + REGISTER_PROPERTY
        + MAP_END + MAP_CONST_COLUMN + MAP_CONST_CELL
        
        Change-Id: I3cd32059aef6787c0e5f8338320d7e924199830c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124892
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b9e2c5d2a36fbd189c20448cadf4212edf02914d]

        tdf#142033 - Handle embedded newline set via SetDataArray
        
        Change-Id: I798f9a2a2ce599ba8ca3ef1f5ae91801d8f1b138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124681
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [140b90d30b30bddfda44b81e26284807807ab518]

        Fix typos
        
        Change-Id: I945c72ce9065d0c59e7ebcb96c70995d5333b67f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124841
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-08  Kevin Suo  <suokunlong@126.com>  [4024673d69475191ba221fd0db2e595bf796d4fd]

        tdf#139205: Keep hierarchical structure of localized default styles in Calc
        
        The default cell styles (when creating a new Calc document), as returned by orcus
        parsing, are built-in English names, as defined in sc/res/xml/styles.xml. These
        names can be localized. On non-English UI, all these (localized) styles names
        will be forced to use the localized "Default" as their parent because there is
        no such non-localized parents in the localized style tree on UI.
        
        In this patch, I added SC_DLLPUBLIC to ScStyleNameConversion::ProgrammaticToDisplayName,
        then used this function to convert the parent style name to the (localized) UI name.
        
        Change-Id: I3689211a10c60a5e7b2b273b6c15a4da92f0d633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124556
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-11-08  Luboš Luňák  <l.lunak@collabora.com>  [5e9c2677e8fcd19b289d947b94ceba52b138728b]

        improve performance of cell equality comparisons (tdf#139444)
        
        When comparing cell and a string for (in)equality, that means
        comparing the whole cell, even when not explicitly asked for.
        Whole cell comparison is simpler and faster.
        
        Change-Id: Ic7a79b20f710f2a5d84f62c714d67c088a22d449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124881
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [4a355b6683977053ce9eb65ff29768e2ccd622c2]

        fix sha256sum
        
        Change-Id: I0abca87c983a431c4ee8c9c117d54480e3f4df75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124887
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [136aca03c7bf33e2fd7b72e1af1d16432804635d]

        gtk4: implement GtkPaintable::get_flags
        
        Change-Id: Iaa8071a37d583c4a16632e3f8e98a7bf50709991
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-08  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [7db51fdbd8c06192941666ad8f444079c334fdef]

        Add an Intel Iris driver to Skia/Vulkan denylist
        
        From off-topic comments in tdf#144923
        
        Change-Id: I1f91622c29d2f8e1b0acd88b6e6fe1c2d5429466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124845
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Luboš Luňák  <l.lunak@collabora.com>  [ec0edb0969c23b25576f4d1b3b2ee5d3f21990ad]

        optimize VLOOKUP by returning SharedString if possible (tdf#139444)
        
        Profiling shows that the slowness mostly comes from converting
        the cell's SharedString to OUString and then the comparison
        converts it back. To improve performance, return the SharedString
        if possible and ignore the OUString.
        
        Change-Id: Idb190bd0354cea3185e5ff9ebaf92cab63f23f70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124880
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Luboš Luňák  <l.lunak@collabora.com>  [1a588c71a0b60d200077138eaff54fced14c4fe2]

        make a number of Calc functions return value by actually returning it
        
        All these returned their value using a reference argument, for
        apprently no good reason.
        
        Change-Id: I6a33417e7df2aac67427c16e5003dfaaa1a814d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124872
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Miklos Vajna  <vmiklos@collabora.com>  [4d66721962f60a9c8b4653dc724f163c45e6ddd9]

        sw: document SwUndoInsert
        
        I.e. there is no starting and ending paragraph in this case, just a
        single m_nNode offset. m_nLen refers to the length of the typed
        characters.
        
        Change-Id: Ia4d14aa54559f5f192141ebee04a5315532d7ad7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124876
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [e269146b14b53e380c3cde79ec323c461e97fe23]

        use label preferred heights to calc required size
        
        drop the "classic" height calculation for 7.3
        
        Change-Id: I514470d32fab4d2afc1999181ac313809e782752
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124868
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-08  Tor Lillqvist  <tml@collabora.com>  [9c5acc28ce828751185382972b6421451bf5630c]

        Add DMPAPER_to_string()
        
        Change-Id: I44f69e8b1f48e8288691790c142f2fcfebd2d142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124867
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-08  Miklos Vajna  <vmiklos@collabora.com>  [4a9ccc24b65070729720bc121cdc281fff96c302]

        libreofficekit: fix lokdocview crash on startup
        
        Regression from commit 1597cc5b3e07dd24cb4cb10b35b1e93545e4b929
        (convert #defines to OUStringLiteral, 2021-07-29), the problem is that
        this the new path was
        
        instdir/programhandle_image_middle.png
        
        instead of the old:
        
        instdir/program/../share/libreofficekit/handle_image_middle.png
        
        This is external code, just revert back to the old code.
        
        Change-Id: I816e67091a2cd6bf07138a5166363803022bab8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124869
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [7e8dcf8b054cb8028f2a1256dae474c4d2ea9c4f]

        upgrade to libexttextcat-3.4.6
        
        Change-Id: I8302f4fed3f7c9a1c2a1b374114066b1327f34c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124844
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [17224bb22dadb8c6fa1dad32e2d1028bf356f485]

        tdf#145258 comments cut-off in writer under windows with 125% scaling
        
        Change-Id: Ic255681075e3ff2d80723071d78bdcc64a8d9bb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124829
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-08  Eike Rathke  <erack@redhat.com>  [74afdccae5c4ee0f59f1313ea232ac2719e22ac7]

        Convert erroneous kw-UK language tag to kw-GB when encountering
        
        Change-Id: I67a79dab3fac36b494ebc66b81d6d571e2486b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124842
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a2fa768b73d96352ffafd166564d2c1cb2e140c3]

        extend XML dumpig for primitives to support fontwork objects
        
        This adds support for 3D drawinglayer primitive XML dumping and
        adds dumping support for many more primitives and attributes that
        were missing before. This is needed to be able to check the
        fontwork objects, which can be rendered in 3D.
        
        Change-Id: I0e78be4d4030a0cae3d2b952a1a38de8940ee310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124804
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-08  Caolán McNamara  <caolanm@redhat.com>  [750d64ce68ecbbf7013e498836c90e3c1ac1b371]

        The country code for the United Kingdom is GB not UK
        
        e.g. see gd and cy
        
        Change-Id: Ic2f9746dc1fc2b08f000f8efff113f5981e427f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124839
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8ae857370192e0b2490d88b54751641073ccee6f]

        Drop code that modified type for no good reason
        
        The code was there at least since 3381981e76873304b171f7df900561dac681d2af.
        Alteady there it was wrong, relying on the order of the properties in the
        aGeoPropSeq: if "Type" appeared prior to "AdjustmentValues", the type name
        was changed by this code; otherwise, "AdjustmentValues" was modified, and
        the sequence set as xPropSet's "CustomShapeGeometry" value. Also the code
        relied on the detail discussed in fb3c04bd1930eedacd406874e1a285d62bbf27d9,
        and the "Type" was not updated when appeared after "AdjustmentValues" only
        because of accidental use of non-const operator[] in another place.
        
        Then in commits starting from 226ff96a88876d34f7fa30148150b6aa5a7f5a7c,
        a new code for presets, including their types, was introduced before the
        loop (see GetConnectorShapeType and maPresetDataMap uses). This presumably
        has obsoleted this code setting "Type" completely.
        
        This change drops this obsoleted code.
        It reverts part of commit fb3c04bd1930eedacd406874e1a285d62bbf27d9 in
        oox/source/drawingml/customshapeproperties.cxx.
        
        It is possible that we should write "ooxml-CustomShape" type in some cases
        when there's no type yet - but that should be done when the conditions for
        that are clear.
        
        Another possible TODO is to move the code defining "AdjustmentValues" up,
        set in in aPropertyMap before writing it into aPropSet.
        
        Change-Id: Ib22a838ca8008b181b3eee2dabdbbc14861a0f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124749
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ab40e9ecc9092e2227a30e43a7fc319f8632a17]

        use more OUStringLiteral in MediaDescriptor
        
        Change-Id: I0567d103db8db401c737fed98483912a39352929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-08  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7cbc8a8d866225f513b90b69bcc29cb6f230d65b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b8dedffddfa520de8801845a360727da3b4c698
          - A possessive pronoun isn’t a contraction; you don’t put an apostrophe to it
            
            Change-Id: I9dd5c0228abbee872714e0654443b238966750ce
            
2021-11-08  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [cd116a1b6775777f393990cc3419733164dee52f]

        tdf#48622 Adapt sidebar line styles to new defaults
        
        Change-Id: I81287d90c2250838391fa79d2f6455219ea822c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124680
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-08  Andras Timar  <andras.timar@collabora.com>  [6fb9bf718121d92b5e1d14218267d4d4bb5b4cb6]

        hdiutil flatten/unflatten was removed in macOS 11
        
        Change-Id: If5a1a70f8a7428d81668704f93fa7a1f45058b68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124825
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-11-08  Miklos Vajna  <vmiklos@collabora.com>  [4280fd3082b22f3ef79101c31d742c282162cf91]

        sw: prefix members of SwGlosDocShell, SwInputChild, SwInputWindow and ...
        
        ... SwInsertAuthMarkWrapper
        
        See tdf#94879 for motivation.
        
        Change-Id: I4547c51afb5a63781105d2a5ebe0b6ed6245428b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124833
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-08  Gabor Kelemen  <kelemeng@ubuntu.com>  [a2f0d457c8addeeef768a93f6a174617094a0254]

        tdf#145128 "Perform file extension check" should be disabled if finalized
        
        Change-Id: I7181ab8dde28fd5580a90fb267b31eaffd6a9878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124567
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-11-08  Miklos Vajna  <vmiklos@collabora.com>  [6680e51716e383c68bb1ec9cc0a05d698d3b6a3d]

        sw: try grouping undo actions of IME-edited text
        
        This is a problem since commit e7760d428bc82ccfcae14f1907b78f9f1013b88c
        (Fix tdf#87500 - Freeze with English/Japanese mixture undo.,
        2015-09-08), that started not grouping IME-edited text completely.
        
        This means that in case you go via SwEditWin::Command() instead of
        SwEditWin::KeyInput() to type a 4 characters word, then it'll create 4
        undo actions.
        
        Fix the problem by tracking who was the last caller of
        sw::DocumentContentOperationsManager::InsertString(), so we can only
        disable grouping switching between IME and non-IME, and we can have
        grouping for a series of IME input.
        
        Change-Id: I31bd02db4fe653ab63e41a77c75b8bebfc749ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124766
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-08  Luboš Luňák  <l.lunak@collabora.com>  [033aea780cc8315979b6de2692f5f7aeb6a0e99b]

        actually check for -isystem
        
        When I added this in 151abb8b2b9d3a22229b98cec12e29484d1210 I made
        a copy&paste mistake that I corrected in a follow-up commit
        by removing the incorrect option without introducing -isystem
        into the check. Not that it matters in practice, apparently.
        
        Change-Id: I64d9ce34dcbaf9acdd8c794aed9fd84bae776d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124828
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Luboš Luňák  <l.lunak@centrum.cz>  [69ee81cc3947a91efb03eb10a117a3f1de5b92ad]

        set up gb_COMPILER_SETUP also for gbuild's ExternalProject
        
        It's used to set up various ccache variables, which without this
        aren't applied to builds handled by other build systems.
        
        Change-Id: Id1157b5a02d607651ba18b249375da6e1fa13cd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124826
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-08  Noel Grandin  <noelgrandin@gmail.com>  [a75324ccabcf09c0f1bc7a1a43256aa37f0da751]

        rtl::Instance->thread-safe static in PropertyNameVector
        
        Change-Id: I3f595585b78c9e5ac32d9fc345c55a4eb14101c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124824
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-08  Julien Nabet  <serval2412@yahoo.fr>  [01878ce321dbbffbc877fbe9eb399dec95f99755]

        Replace some macros in forms part 17
        
        Remove FRM_RES_STRING + PROP + PROPERTY_FLAGS
        
        Change-Id: I11befedbe83ad9d7c3f3f4d689230ffe422c0770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124830
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-08  Hossein  <hossein@libreoffice.org>  [6b4730f5649c9d028b140168f92f1fc12c2fb2cb]

        Make usage of ETO_PDY flag more visible (EMF)
        
        * Make usage of ETO_PDY flag more visible with introducing nBytesEach
          variable
        * Add comments for reading OutputDx
            ETO_PDY flag indicates that we should read twice values
            compared to the number of characters in the output string.
            Values are stored in an array of 32-bit unsigned integers called
            OutputDx, so there will be either 8 bytes or 4 bytes each
            depending on ETO_PDY is set or not.
        
        Change-Id: I3892c95bd9ad80b3c414e2556f91bd5218b22c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124097
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-07  Julien Nabet  <serval2412@yahoo.fr>  [73334560b2dd2d60ac58d2cc2b1a5295490b03e1]

        Replace some macros in forms part 16
        
        Remove DEFAULT_DECLARE_SUBTYPE + EXCEPT + EXPAND_PROP_INIT
        + DECLARE_DEFAULT_CLONE_CTOR + DECLARE_DEFAULT_LEAF_XTOR + FORWARD_TO_PEER_1
        + IMPLEMENT_DEFAULT_CLONING
        + ADD_ENTRY (include removing:
        /home/julien/lo/libreoffice/forms/source/xforms/convert.cxx:56:14: error: unused function 'lcl_toXSD_bool' [-Werror,-Wunused-function]
            OUString lcl_toXSD_bool( const Any& rAny )
                     ^
        /home/julien/lo/libreoffice/forms/source/xforms/convert.cxx:60:9: error: unused function 'lcl_toAny_bool' [-Werror,-Wunused-function]
            Any lcl_toAny_bool( const OUString& rStr )
                ^
        /home/julien/lo/libreoffice/forms/source/xforms/convert.cxx:67:14: error: unused function 'lcl_toXSD_double' [-Werror,-Wunused-function]
            OUString lcl_toXSD_double( const Any& rAny )
                     ^
        /home/julien/lo/libreoffice/forms/source/xforms/convert.cxx:80:9: error: unused function 'lcl_toAny_double' [-Werror,-Wunused-function]
            Any lcl_toAny_double( const OUString& rString )
                ^
        )
        
        Change-Id: I1e6923922b7037e8d1e9d009b05a27111c94b6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124827
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-07  Jim Raykowski  <raykowj@gmail.com>  [6be03ac71e0d4927612b4a57ead3d0b245c29c77]

        SwNavigator: Don't update content tracking after toggling root mode
        
        UpdateTracking after toggling root mode was put in commit
        b43ab86df783c7816deb5810d89d52e2c3a93b5a by mistake. This patch removes
        it.
        
        Change-Id: I25958c90621ac8c34f85933328e4e4bef83100f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124805
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-07  Eike Rathke  <erack@redhat.com>  [0f3c19ee61ec371aa32d9f51c3555d3ea8ae9eeb]

        Resolves: tdf#145386 Use "Default" for LANGUAGE_PROCESS_OR_USER_DEFAULT
        
        There's no, specifically not in Writer, handling of the LCID
        0x0400 LANGUAGE_PROCESS_OR_USER_DEFAULT language/locale concept
        other than the number formatter mapping it to LANGUAGE_SYSTEM.
        
        Use the LANGUAGE_SYSTEM "Default" string in UI (status bar, status
        menu, language list) but keep the LCID, and don't append the
        resolved locale string as it is also displayed both in the Font
        Western and CJK listboxes.
        
        This ends up as two list entries, like
        * Default - English (UK)        first entry
        * Default                       last entry
        of which the second would be selected.
        
        Change-Id: I8d9e4171bee6bbe9d1c9dcfb7a5fa8fc92ea1a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124449
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-11-07  Noel Grandin  <noelgrandin@gmail.com>  [4f6f70d9f418593fd64788bb204e6f6f36674fce]

        add more comment
        
        Change-Id: I4b19e7f62a70d795071c3a45e3f1c148f509bc53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124823
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-07  Noel Grandin  <noelgrandin@gmail.com>  [a0e0575dcf4fede5c6e20636c63042d8c62ecf77]

        forward decls go after #include
        
        Change-Id: I54c33508639044092356eed5144720261b4f65db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [efd2510e225232ac35707a3ed55b83be9fa046af]

        crashtesting: assert on re-exporting ooo25141-1.doc to doc
        
        since...
        
        commit e0b41fcb56e51f20684da4ba44d7ed6e0e1a3234
        Date:   Thu Oct 28 13:36:50 2021 +0300
        
            tdf#144668: docx export: simpler way to create lvlText in numberings
        
        Change-Id: I40b3cdf5e15d3a4dacc50bd46a5bbca84e6fac03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124822
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [0d4c1cc6ea39404c4ad1c8abe0d70dabcac1e017]

        use a std::vector
        
        Change-Id: I186f34025863882951aaa70f94ea21b8ac556dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124821
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [f163ab3c911018fb79d11bacc561a6efd50cee73]

        ofz: Use-of-uninitialized-value
        
        Change-Id: Ic96e20570f0aae9a7fab66fd39d0fadc0b72d3f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124820
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [b159912cae69dd4ae4f2cae89fcbf5de106f8d41]

        these are the only calls to memset that explicitly ignore its return
        
        it seems hardly necessary to be weird here
        
        memcpy likewise
        
        Change-Id: I57df9ffd92b4e1d1ebff281498832250f4e1caf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [ad9496d43cb0b967dfb47cedb515b885d6f5b575]

        cid#1493474 Arguments in wrong order
        
        Change-Id: I6738acf5e48b914491af64377b00f09fc87e8a80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124818
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [3e511ac5b44e860a30cbf6d1d22e467b813bc04b]

        cid#1493476 Logically dead code
        
        Change-Id: I179e61b84a43c9ff43ff70de8b8f020682a53686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Caolán McNamara  <caolanm@redhat.com>  [6645dfedef841a78d65202e9f0008f0a384e5e44]

        Resolves: tdf#145567 restore focus to the usual frame focus widget
        
        when tearing down the start center. Don't leave the focus in an
        arbitrary widget.
        
        Change-Id: I82c30c94121dc43b2ea1b4fbc66a0a3e79f7e664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124803
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-07  Julien Nabet  <serval2412@yahoo.fr>  [f63cf9e83a944306ad8564e4ce9b98f92fae666e]

        Replace some macros in forms part 15
        
        Remove REGISTER_VOID_PROP + REGISTER_BOOL_PROPERTY_RO + REGISTER_PROPERTY_RO + REGISTER_PROPERTY
        + PROPERTY_RO + PROPERTY + REGISTER_PROPERTY_BOOL + REGISTER_BOOL_PROPERTY
        + REGISTER_PROPERTY_API
        
        Change-Id: Ia38d75e89aafc5788bc143aae864eac9ad5bb86d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124815
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-07  Julien Nabet  <serval2412@yahoo.fr>  [f23a4e6d46cb7802d248984bc82ae6247cffd855]

        Typo: implemnented->implemented
        
        Change-Id: I3171c95523408b69587aaa2bb064c750bc56c55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124809
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c1f37355bdbdd144cffaa3d2c0bf24bae826a385]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 982f985d2a8e8f429d147eb158b89c73bd60f2ae
          - tdf#140781 Add PDF + XSLT import API names for CLI
            
            * amended python script
            * regenerated convert Help page
            
            Change-Id: I4891491d87b4b21c2d103b9df2adb03a21aff790
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124787
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Julien Nabet  <serval2412@yahoo.fr>  [39e1d23982c1f080da79d4a46056ae6dc49888a5]

        Replace some macros in forms part 14
        
        Remove DEFAULT_IMPLEMNENT_SUBTYPE + SET_PROPERTY
        Change-Id: Ic1ab69076017eeb58cefb3dbecd385f1b862c031
        
        Change-Id: I91230d25e8eb11c6c0dd6cec920c6bd5ec958bb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124808
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-07  Johnny_M  <klasse@partyheld.de>  [b383c3b8a6ba405c9073a5ba67ee757ffc59ed7c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5ee4d72936eff5346ed85ccb4958801a44f712f0
          - tdf#132643 Translate German section IDs
            
            Change-Id: If48434cb30d46b4cc7a5d1dcf7e1c9112e75aae8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124812
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [a72080f3e44538efbe9718ed7467be844a3ff4c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 964617bdd9e75ad6a6ecb4c549c53776ff8d973c
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic665b9ec63d2c59aade61648f2a5a79729412cf3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124814
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [bfec1d710d3cfb19f5ce3db3939583d6917360c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3ae4d8901912b649aedbeedc907c117409fa2ef2
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idac11dadcb74de868d9fae27a571a66d0da7e862
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124813
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [c07e64af957d9ae5c2df5dcb1e87fe0c44d71c11]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 977d1c9044ef41391b9fa3ccc5244cd206623a30
          - tdf#132643 Translate German section IDs
            
            Change-Id: I11f0723a02ed0861ae8cb8d372e19267803ea948
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124810
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [f3a12a7f84057e143c198dd96db0556f33eccfc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c4ba4d4ba96ae6cc27aed0719efa80a67e7a3f02
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibad45c90138e05fea58b73e05c4b056d377abfb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124811
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [3cbb3d21e51d50027e2c50f8408082f538c7da60]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d55f7694f6a490649f9318de2fca1efcbc85f11
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0270586e9ade893b26338a1a9dc9f0bb5d4482c0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124799
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [6e41a452c1d150b3bac38414d9dc838994376617]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f0e247ba0f835b39e21d0bffd77ec7b83c0c3122
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1ece2fe7408cc64d93f6b58a7744acaf06fd4f5f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124798
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [d77d3b5ecad30144e0eaf67a552caf3a94df4121]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1ffd51ac1318d250e3f462a28804545deef0790b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I46dc72453686d590c4ad58dd2c7de84659815c54
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124797
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [bccbc816dac97f138d097ea5bedd6da56e42c1f0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0cf80abe2d2e49937e06d2d516348c7a12d816ee
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: I7317f4692628cb2845cdb32c84391541c6754014
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124796
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Johnny_M  <klasse@partyheld.de>  [9860b10ff72bfb3150564b418a80614f64093293]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37ded3c73f7a54b03ce1fc7b427cd612086e3e7d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5e1d2ef92b75b3c4547fbb04ba40fd8c2f43c81a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124795
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-07  Julien Nabet  <serval2412@yahoo.fr>  [a2222061223af8946a9ddb6d52f62c912f892356]

        Replace some macros in forms part 13
        
        Remove DECLARE_DEFAULT_CLONING + IMPLEMENT_DEFAULT_TYPED_CLONING + DECLARE_XPERSISTOBJECT
        
        Change-Id: Ib874cadcfd30c3ac9e2d12036482868c19a2d98b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124807
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-07  Noel Grandin  <noel@peralex.com>  [7a61256f9e68201ef7b331ca3e1b4c3302104631]

        return XShape from SdrObject::getUnoShape
        
        instead of XInterface, to make it obvious what the reality of the
        requirement is
        
        Change-Id: Icdd4113f2a0ece930305f4d8ba010b81d24f43c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124802
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-06  Caolán McNamara  <caolanm@redhat.com>  [b3325ef8cdfc2c82eec34e747106f75a9fccb7e4]

        ofz40766 Null-dereference
        
        Change-Id: Ie9df072747311791ac04699cb8c3101a03da7431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124801
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-06  Caolán McNamara  <caolanm@redhat.com>  [2576f08b3b29f460378a6c3b306cc2dfb8b1c638]

        ofz: fix build
        
        Change-Id: I0be535097cb7e2c8fa2346843592945db981dad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124800
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-06  Julien Nabet  <serval2412@yahoo.fr>  [278f91d9611dfe21fa03ee348aaab2bb1b6f5e3c]

        Replace some macros in forms part 12
        
        Remove IMPL_COLUMN
        
        Change-Id: I7446b1146853c7a3b0820a681793e0146921da0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124791
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-06  Regina Henschel  <rb.henschel@t-online.de>  [70a4cb766ed356bc17433ac1673e977bb0bf3d2f]

        tdf#140321 enable 'matte', 'metal' extrusion surface
        
        The patch makes extrusion surface presets 'matte', 'plastic' and 'metal'
        look different from another. That has been broken from the beginning of
        custom shape extrusion in OOo2.
        To get 'matte' ODF conform, property first-light-harsh is enable.
        To keep smooth rendering set by PowerPoint, forcing shade mode 'flat'
        is removed.
        
        For more details about the change see comment in bug tdf#140321.
        
        Change-Id: Idd1e0af19ea3f7e604da7f10330c6f9e640d08f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124720
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-11-06  Julien Nabet  <serval2412@yahoo.fr>  [32c01c6653b85082e2d5e03ab3095768402834eb]

        Try to fix Jenkins_Callgrind
        
        Change-Id: I9e099c7ab59fc8db1deaae454b413f3b5dc62b55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124790
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-11-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [03cdfce99afd5daef1385f132e41d27dfe04e96f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c845d15fbff54fce2abb4a402cc3f565e84c5f43
          - tdf#140111 Add "Comments" to View menu description
            
            Change-Id: I1cb5399e47d2726c318f9ebf35c8fff4f8720d69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124789
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-06  Julien Nabet  <serval2412@yahoo.fr>  [91131f92dcead3c5c08fe720af8d9a9cd187bb39]

        Replace some macros in forms part 11
        
        Remove DECL_COLUMN
        
        Change-Id: Ie7533f8a52e7365215fbd878385f2bed0113b5aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124788
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-06  Julien Nabet  <serval2412@yahoo.fr>  [40a5ba66a8b92898d4a933064b9eab4267388f45]

        Replace some macros in forms part 10
        
        Remove DECL_PROP_IMPL
        Change-Id: I4ba5e3252058b137cd314f0aed0caf60bb347852
        
        Change-Id: Icfda67a31f465ebfe0c13761bdbdf9b024605dc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124785
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [6ca3347985745b89594d0855f6004fd41d604f56]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8278dc648a49ae83fac8208fbe0ac6041cef56e4
          - Fixing links
            
            Change-Id: Iaffff844cfa18b2d3a8715e01d236e2d49ebe74a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124702
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-11-06  Justin Luth  <justin_luth@sil.org>  [0ce586e1e50deeaf2ba210acc4fea08058f8b15c]

        related tdf#136472 writerfilter: only copy even pages if used
        
        Allowing the use of Even pages is a document-level setting.
        So if the document does not allow the use of an even page,
        although we will read it in once (in order to preserve the contents)
        there is no point in copying it to every inheriting page style
        (especially if it contains large items like images).
        
        Change-Id: I22ccb16e29c5335e50010f8a334494aaa1d45785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124437
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-11-06  Julien Nabet  <serval2412@yahoo.fr>  [b4c4ca39d7cd4cc59e01bceeb31dc75097b67acb]

        Replace some macros in forms part 9
        
        Change-Id: I3bd6e118455c8ce86650797e05b7e40ca066eb53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124784
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-06  Justin Luth  <justin_luth@sil.org>  [a2d322c02af05db1b785633ea398fe0b62b67605]

        NFC writerfilter: m_bDiscardHeaderFooter = false in both cases
        
        Change-Id: Ie16100c10fce6366659be17261a97795d372ff11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124754
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-11-05  Julien Nabet  <serval2412@yahoo.fr>  [742b8befecbcfc0cfab87cfcd87c83b7d8ef32ab]

        Replace some macros in forms part 7
        
        Remove BEGIN_DESCRIBE_PROPERTIES
        Change-Id: Ic1f52f21037e890c4f7143a1283f34101dbb737a
        
        Change-Id: I1bd902af7f634bb70313dda72b7a008bdda38f75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124782
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-05  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d84849c5d1fc927d3ce14b81f6c875f3f4223ce6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ea8bee81962bf4a1fa053578c3a21cf55715d483
          - Close navigation menus when clicking outside them
            
            Change-Id: I6d567d7978ed5997b4ca9bf865e9e54d6c67a3a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124718
            Tested-by: Jenkins
            Reviewed-by: Ross Johnson <ross.johnson@homemail.com.au>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-05  Julien Nabet  <serval2412@yahoo.fr>  [642a03393580f142ef4b703b0164b8142c780129]

        Replace some macros in forms part 8
        
        Remove END_DESCRIBE_PROPERTIES
        Change-Id: I844b71cd74f2b2c5306d0ad979ed56480892268c
        
        Change-Id: Ia0aa75a3042ecc47bf434afb0de971d35ab78dfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124783
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-05  Stephan Bergmann  <sbergman@redhat.com>  [09584411ec13f353032c903b20937919987b8d51]

        DECL_DLLPRIVATE_LINK doesn't make sense in a non-DLLPUBLIC class
        
        ...and causes "declaration nested in DLLPRIVATE declaration redundantly marked
        as DLLPRIVATE [loplugin:dllprivate]" from within the macro expansion, so revert
        that part of 54435d56051e19a408a1fcce16a3e4add185c018 "use more
        DECL_DLLPRIVATE_LINK"
        
        Change-Id: I51043214963176a761c784651224f84412777e36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124780
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [5e5420f9ea1a46d17305f5a5513a588364963ed2]

        resave with latest glade
        
        Change-Id: Ide678707e48edac2647de5120dcac0da250c2947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124764
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f5348e47d56a16c2691d0dffa45bbaf970092ca]

        tdf#121260: sc_subsequent_export_test2: Add unittest
        
        Change-Id: I18d96f41dca5072359fdf325cc37dea84de5838a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124770
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [7e33e24181ffaddcee4bc1358650a0bac48f8ebd]

        webdav-curl: there's no non-const Sequence::operator[]
        
        ... since commit fb3c04bd1930eedacd406874e1a285d62bbf27d9
        
        Change-Id: Ib56e854206074dd247dcd0f876a8a92b3f9af7ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124763
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Michael Stahl  <michael.stahl@allotropia.de>  [35eef8ec9b122a761400f3c6590ca1f9a187d772]

        icu: add patch for CVE-2021-30535
        
        Change-Id: I398596f77aa47ab6d4db01b94422262048cffd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124779
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Julien Nabet  <serval2412@yahoo.fr>  [7b6554851fb4cc620f4720f6ad3f394fa0a8995f]

        Replace some macros in forms part 6
        
        Remove DECL_BOOL_PROP_IMPL + BEGIN_DESCRIBE_BASE_PROPERTIES
        
        Change-Id: I1a55c9de46ae741045002241a2b0f5dfa32db8c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124777
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-05  Julien Nabet  <serval2412@yahoo.fr>  [5bfbaf3c80987d1f7e6b3d7ffe6896b9bc3687e6]

        Replace some macros in forms part 5
        
        Remove DECL_IFACE_PROP_IMPL + DECL_PROP0 + DECL_PROP2
        
        Change-Id: I8bd0222244a4cb0db33fa890056bf00e240fb4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124769
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [94df9426f557e49c8241fb2f5351a8d4ee801af6]

        tdf#111785: sd_export_tests-ooxml2: Add unittest
        
        Change-Id: I70bcc1855fc33ee3e6254ad620502bb4e72409d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124767
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [371a91aaae0500f60f73968ff90a3d61e21b6d1d]

        Werror=nonnull in SbaXFormAdapter::cancel
        
        ever since
            commit 38d78d3c30183b11f5b643c147667b1d30325784
            Author: Ocke Janssen <oj@openoffice.org>
            Date:   Thu Oct 26 13:46:14 2000 +0000
            new datasource browser
        
        spotted by new gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
        
        Change-Id: If054b949f4b4f93e785d315ddeb3423b52d1f55b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e495d0e5614e08f0eacdb5ea5deb0c1e0a0f3db4]

        update diagnostic ignore
        
        problem still present in
           gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
        
        Change-Id: I5bc2115be0cda4a444f493645b86e60290c9d0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Michael Stahl  <michael.stahl@allotropia.de>  [b22f665e2337ab019ec727f6d4a4d4c3e7b9453b]

        sw: ~SwDoc: delete TOXTypes after TOXMarks
        
        warn:sw.core:24584:24584:sw/source/core/attr/calbck.cxx:156: lost a client of type: 9SwTOXMark at 0x57728d0 still registered on type: 8SwModify at 0x55a9c70.
        soffice.bin: sw/source/core/attr/calbck.cxx:159: virtual SwModify::~SwModify(): Assertion `!hasListenersOnDeath' failed.
        
        Change-Id: I118426e802e7f7346e579b807a4d8c85252ffeb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124757
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Justin Luth  <justin_luth@sil.org>  [74723bbe6b860e54c26711c108f1e2d2388e8feb]

        NFC writerfilter: simplify logic
        
        if (!A && !B || B) is the same as
        if (!A || B)
        
        and the ELSE is also by definition A && !B now.
        
        Change-Id: Ie797976423bb910386a26e96692c43faf0344132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124753
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-11-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b893f5f637306b991f89caa9959b50286b1fd378]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 12c4f7058e7b2d2861ed870ca4c7b46fe3e1f63a
          - Add pt-BR thesaurus collateral information
            
            Change-Id: I85d008af2a584ce10459407ce9e99fe01f354276
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/124768
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [58adc139aa5385a07e28c28cbd9317f4cd8aa4d4]

        tdf#93747: sw_uiwriter2: Add unittest
        
        Change-Id: I622cb779549dea729dbe7c8474b5f25034b97278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124761
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [315e3af84ff5d101abbeb6746f249fcf4b720fe9]

        set placeholder image
        
        Change-Id: I9f20c7cc6aeb37609160808eac96cb23b5f6c36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Luboš Luňák  <l.lunak@collabora.com>  [c1c88bad3e99dd3740b7833d81350e8dd6e39649]

        Revert "disable SkiaTest::testMatrixQuality because of tb68"
        
        This got handled properly by 12c6b1ef6a824b09778163ec83fc44bb .
        
        This reverts commit 734f37aaf6027ef2d989b6440370dee46bac0df7.
        
        Change-Id: I5debb99293ce5b70f112a61f8959a10046926294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124748
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [71b270fc3fb9c5f5f08cc340e83a3077cae427fd]

        fix --enable-gtk3-kde5 build
        
        Change-Id: Ib8967575c8f94436255be3145fb74af6741cad26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124765
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Michael Weghorn  <m.weghorn@posteo.de>  [324e2a5c3e6355e6b38db0add100465224841364]

        tdf#144994 QtInstance::CreateMenu needs SolarMutex
        
        It can be called from extensions (as is the case e.g.
        for LanguageTool, s. tdf#144994 comment 19; assertion
        is hit after clicking around in the menu a bit) and
        'RunInMainThread' requires that the SolarMutex
        is held.
        
        Change-Id: I282ef6a21e60b636abb27aeba332ae3a634ce680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124750
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-11-05  Michael Stahl  <michael.stahl@allotropia.de>  [1289125532a029dc80e4ee3d0a49dca253f51888]

        bzip2: upgrade to release 1.0.8
        
        Fixes CVE-2019-12900
        
        Change-Id: If3fcfff78a61c60014ba6d96f1ee0c432ccc52a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124758
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [1e5992c1059866186b5e75a0beb7dd7b892352cf]

        gtk[3|4] do the same thing to set/get buttons labels for both gtks
        
        Change-Id: I0046f4221ab73d9f9b6801e3794410d88a6887fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124744
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [95b283da72eb0cbf85d379bced053e1890d7fabe]

        prepopulate numberingwindow.ui with a placeholder image
        
        Change-Id: Ic30ab5a8400fffbe62ce368279066e706a59d0e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [137e3c89de08d42c97c5675cf3c98011398bccf3]

        gtk[3|4] update an existing image on changing button image
        
        instead of throwing away all contents and replacing it
        
        Change-Id: I9bc10e5224ab4797eaaf7856acaf5ee0888ae5c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124746
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [69cc0fb6884e8a2324e0605137c41c072522e5cc]

        add use-underline to label
        
        Change-Id: Ibf532754664c36e8d97fad41227bebf9b80d956a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124743
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [bd150e7a8602b58bddca5e1277220e67a7ad5dcd]

        resave with latest glade
        
        Change-Id: I2175c3e6b4e7ab1ff2d34b03aaeedda072ecd695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124742
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [b820e4fe9ea0be0c2e1a1af19ad7e5f2cf6588df]

        Refer to TLS/SSL in options
        
        Change-Id: I07bddadd9421ee5584f8d978c5c43eab067414af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124745
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ae0767b0fbe5d5b56ebe406bf1ee7aca4aaa909f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 60f4a1dd6b3e8ea15f65488b02487ea95fd1f8e6
          - Cleanup pt-BR thesaurus (part)
            
            Current thesaurus has many typos and truncated words but cleanup
            is a long process and will be carried in chunks.
            
            Change-Id: Idb4da711b3829fefa81bc744ca1a772471edc0a5
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/124756
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [ffd0453810cff76aebb8b0c9e2a5d5fb18ac2591]

        use more DECL_DLLPRIVATE_STATIC_LINK
        
        to avoid unnecessarily exporting symbols
        
        Change-Id: I224848cea217977088fe0643511660a7c99b7277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124733
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [848eb0ddecd4ef4c8da06624a5479efd3d73cf64]

        crashtesting: downgrade assert on bookmark missing from input docx to a warning
        
        The docx bugdoc is "generated by ComMA version 3.3.0" and has a pair of
        bookmarkEnd/bookmarkStart in a non-conformant order, like so...
        
        <w:bookmarkEnd w:id="23"/>
        ...
        <w:bookmarkStart w:id="23" w:name="_Toc483311613"/>
        
        both bookmarkStart and bookmarkEnd are mapped to the same
        DomainMapper_Impl::StartOrEndBookmark
        (without a distinction made between begin/end) which assumes the first
        time it's called for an id that it's a bookmark start, and the second
        time for an id that it's a bookmark end and that there will have been a
        w:name seen between the 1st and 2nd calls to be used as the name for the
        bookmark to use at the 2nd call.
        
        That there is no bookmark name is a problem in the input docx rather
        than the import logic so turn this assert into a warning
        
        $ wget https://bugs.documentfoundation.org/attachment.cgi?id=157489 -O tdf130241-1.docx
        $ ./instdir/program/soffice --headless --convert-to pdf ./tdf130241-1.docx
        
        https: //dev-builds.libreoffice.org/crashtest/b6ef68cdaa51ca5c9fdab40ade97f4a0f18da51b/backtraces/task815-core.backtrace.txt
        Change-Id: Id389d186ea825f515c2638a76c9bba00666e0686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124734
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [3032fc36eaca2840a9e42207b5e8e88e248a439d]

        Simplify oox::PropertyNameVector ctor
        
        Change-Id: I800da7546a88e173e1b68041ce967795a4a3c9d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124699
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [8bd46187e355f2da76812d38d0fa36cc255a841b]

        gtk[3|4] add find_image_widget
        
        Change-Id: I13aa94c66d54a99ecd4cbe410360ff61b4762c34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [d13712200e2c0cfee56afb6796f35e0fd15186e1]

        gtk4: move find_image_widget into utilities
        
        Change-Id: I9a0187ff26171eb2133ea7b46f3638729198c869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124740
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [55bdb61f5219ea93dee00ab1a8a9735ca2ea7976]

        gtk[3|4] merge label search code
        
        Change-Id: I90454bea86178c1fa6f6698593253b99e1871d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124739
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [97cc576a4aebd9b0c0b34b62f562f0386a137332]

        Drop code that modifies unused variable
        
        aPropertyMap is not used after line 154
        
        Change-Id: Id593d44c327d30e3074dee3430eb551160ad18fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124697
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [b6c3adf356ca5f7b6f3d80e6062b58c92e6e2a11]

        gtk4: return existing label widget text on querying button label text
        
        Change-Id: Ic8a544eae09c80b172340b4c3abe00244fe7a711
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124738
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [9cfa15e06ed6d6c5c555fa5623c0d962bceee30e]

        gtk4: update an existing label on changing button label text
        
        instead of throwing away all contents and replacing with a label e.g.
        for color selector keep the optional image in "automatic"/"no fill"
        
        Change-Id: Ifb29f83d5a5b95c91050c28f1d5bedaafba42d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124737
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Caolán McNamara  <caolanm@redhat.com>  [85676ff5ba14832f10613aa74528f402d65974e4]

        gtk[3|4] set button text via the same function
        
        Change-Id: I75bee3e0bdbd1e26177f864fd4ad5e11d0e2cf2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124736
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-05  Mike Kaganski  <mike.kaganski@collabora.com>  [fb3c04bd1930eedacd406874e1a285d62bbf27d9]

        Drop non-const Sequence::operator[] in internal code
        
        This makes all non-const operations on Sequence explicit, to avoid
        repeated COW checks in loops. Generally it would be desirable to
        replace uses of Sequence with general-purpose containers wherever
        possible, and only use Sequence for UNO API calls.
        
        This change uncovered a very serious pre-existing problem inherent
        to the Sequences used e.g. in range-based loops in our code: taking
        a non-const reference to elements of a sequence, and then modifying
        them at some later stage, brings a danger to also modify copies of
        the Sequence, that were created between the points of taking the
        reference and modifying it. This caused the change to
        oox/source/drawingml/customshapeproperties.cxx, where
        CustomShapeProperties::pushToPropSet took begin()/end() non-const
        iterators to aGeoPropSeq at the start of the loop, and then in the
        loop modified its elements and copied the Sequence passing it to
        XPropertySet::setPropertyValue. This was the same also prior to
        2484de6728bd11bb7949003d112f1ece2223c7a1, and only happened to not
        cause problems because of *accidental* use of non-const operator[]
        on the copy of the Sequence inside SdrCustomShapeGeometryItem ctor,
        which *inadvertently* triggered COW, detaching the two copies one
        from another.
        This only emphasizes that we should minimize use of Sequences in
        the codebase. I anticipate other similar problems uncovered by this
        change, that happened to not break existing unit tests.
        
        Change-Id: Id691d994a06eb14297c487ebb84d8e062e29fd47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123725
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-05  Stephan Bergmann  <sbergman@redhat.com>  [1a62041a44be435b2588680c94294c0f0cbf13c8]

        Missing test dependency
        
        > sw/qa/extras/uiwriter/uiwriter4.cxx:3453:SwUiWriterTest4::testTdf133524
        > equality assertion failed
        > - Expected: »word« „Sentence and »word«.” →
        > - Actual  : »word« „Sentence and »word«.” -->
        
        Change-Id: I922d62984e3d8421e0fa1897fd031cece3ef548f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124735
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-05  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e0b41fcb56e51f20684da4ba44d7ed6e0e1a3234]

        tdf#144668: docx export: simpler way to create lvlText in numberings
        
        Oldr approach with populating ListLabelString with some predefined
        values and than replacing them by placeholders is not so good. It
        can lead to collisions if we use numbers in format string.
        
        Anow with support of list strings in core we do not need this: it
        is enougth to replace LO placeholders %1%, %2%, ... by MS binary
        placeholders \0, \1, ...
        
        Additionally added support for list level initialization in DOC
        import: that case was still setting just prefix/suffix leaving
        list level uninitialized.
        
        Change-Id: Ia85551f46b4e229dea93c663459ec1a8715c8a23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124326
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [4a7022c199addb1fbc7445708c0f4801fbf1e47f]

        tdf#134294: fix Chapter heading updates
        
        A quick manual recheck seems to confirm, that this does not regress
        tdf#118735, tdf#118049. I couldnt quite recheck tdf#118833, the "steps
        to reproduce" dont quite work on master -- but I did find any obvious
        regression there.
        
        Change-Id: I407ac8c0a8222e3f8c74449a4ec2b9b27e8a3a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124532
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ffbbd9dba5f12be2914ebbf01ebdd303b695e46]

        flatten PopupMenuDispatcher::queryDispatch
        
        Change-Id: I8dce031913a4ed40faa8d7994b1da8990d684091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124732
        Tested-by: Jenkins
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [03b476c0da596545bd9b99cc744a5fb56bfb797a]

        [-Werror=nonnull] ‘this’ pointer is null
        
        gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
        is now complaining about a double-unlock
        
        Which has been there ever since
            commit fb6c93aed8d3d7468e4c9b412e432633c36e68fc
            Date:   Wed Dec 13 14:05:51 2006 +0000
            INTEGRATION: CWS fwk54 (1.1.2); FILE ADDED
            2006/11/10 12:54:27 cd 1.1.2.1: #i65187# Protocol handler for
        vnd.sun.star.popup URLs to support dispatch by popup menu controller
        
        Change-Id: I87206bb7313b69babb16859808868ffa00707faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [54435d56051e19a408a1fcce16a3e4add185c018]

        use more DECL_DLLPRIVATE_LINK
        
        to avoid unnecessarily exporting symbols
        
        Change-Id: I6855894d0166c300ced169e36861f38811baa48d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Stephan Bergmann  <sbergman@redhat.com>  [d7f64593db4afdf2a7e77ca9147f6495e69912fd]

        The std::auto_ptr workarounds should only be necessary for Boost < 1.67.0
        
        ...see the commit message of f8b10b76bc3000eab3269de4472d6c28bd308059 "The
        std::auto_ptr workarounds should no longer be necessary" for details.  (The
        removed settings in 52a26b146542526dc4f6bb193ffb4fd95e4f79fd "fix
        unotools/source/i18n/resmgr.cxx build with PCH on Mac" might still theoretically
        be necessary for macOS and Windows builds against the baseline Boost 1.66.0, but
        it is unlikely that anybody does such builds against anything other than our
        Boost 1.76.0 exteranl/boost, anyway.)
        
        Change-Id: I7a5cdc72e76c695b220353b02368623383dcd8a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-05  Stephan Bergmann  <sbergman@redhat.com>  [7190e6f114eccd921e6cb6beef793b053cf50856]

        Remove conditional code for Boost < 1.56.0
        
        ...after 0b9a6cfc443d84158fb0db6f40b953e1410178d8 "Set Boost baseline to 1.66,
        and enforce it"
        
        Change-Id: I3cb2c7916983c185298d4221b06f268ae70ed6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124727
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [8dcdad359207c237155292b74b2db77365a3c8ff]

        rename mxTextEditObj -> mxWeakTextEditObj
        
        because it helps me keep the referencing counting strategy in my head
        when reading the code
        
        Change-Id: I8f0362b08e8ebdbe4194f29ecfd89d3ca29c961c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [02ff8b2fbf1c3d47a08e6a6da4e301d304c15b31]

        rename mpTextObj -> mxWeakTextObj
        
        because it helps me keep the referencing counting strategy in my head
        when reading the code
        
        Change-Id: I6363b688c8f5e649c82dec02e21498bcb961bd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-05  Stephan Bergmann  <sbergman@redhat.com>  [9ee124ac454177c85d7e928a35d2b533dac33d9c]

        Simplify code checking for Boost < 1.50
        
        ...after 0b9a6cfc443d84158fb0db6f40b953e1410178d8 "Set Boost baseline to 1.66,
        and enforce it"
        
        Change-Id: Ia3b1c453872cdcf4830160de4bbd500b178b7834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124726
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-05  Miklos Vajna  <vmiklos@collabora.com>  [5ce91c5efb73c2d9be809fa82425ae8f2048d7a5]

        sw: remove useless debug code in SwLangHelper
        
        Looks like leftover throwaway debug code that was committed by accident.
        
        Change-Id: I9f713da9a560164096c83406c5bd96f13be3e773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124722
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-05  Julien Nabet  <serval2412@yahoo.fr>  [9776087faf8ea0107481dbd32ec74058301280fe]

        Replace some macros in forms part 4
        
        Change-Id: Ic9310fcfa4fb3b1b7e64eaa2be3839ba89949a3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124723
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-05  Kohei Yoshida  <kohei@libreoffice.org>  [23214f1c14c4d3981dad90b6e3ba6e4ca2c8c30e]

        Blind fix for ubusan error
        
        from https://ci.libreoffice.org/job/lo_ubsan/2189/
        
          [_RUN_____] Test::testCellBroadcaster
        [...]
          ==24129==ERROR: AddressSanitizer: heap-use-after-free on address 0x61700006c470 at pc 0x2ab6e05145e4 bp 0x7ffecaa28d70 sp 0x7ffecaa28d68
          READ of size 8 at 0x61700006c470 thread T0
              #0 0x2ab6e05145e3 in sc::CellStoreEvent::element_block_released(mdds::mtv::base_element_block const*) /sc/source/core/data/mtvelements.cxx:47:13
              #1 0x2ab6de749427 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreTrait>::delete_element_block(unsigned long) /workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:403:17
              #2 0x2ab6de74921b in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreTrait>::delete_element_blocks(unsigned long, unsigned long) /workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:412:9
              #3 0x2ab6de733225 in mdds::mtv::soa::multi_type_vector<mdds::mtv::custom_block_func3<mdds::mtv::default_element_block<52, svl::SharedString>, mdds::mtv::noncopyable_managed_element_block<53, EditTextObject>, mdds::mtv::noncopyable_managed_element_block<54, ScFormulaCell> >, sc::CellStoreTrait>::clear() /workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector/soa/main_def.inl:1088:5
              #4 0x2ab6df024987 in ScColumn::FreeAll() /sc/source/core/data/column3.cxx:161:13
              #5 0x2ab6decff134 in ScColumn::~ScColumn() /sc/source/core/data/column.cxx:97:5
              #6 0x2ab6decf708a in o3tl::default_delete<ScColumn>::operator()(ScColumn*) /include/o3tl/deleter.hxx:55:38
              #7 0x2ab6decf5999 in std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> >::reset(ScColumn*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4
              #8 0x2ab6decf4c8e in ScColContainer::Clear() /sc/source/core/data/colcontainer.cxx:42:21
              #9 0x2ab6decf4a84 in ScColContainer::~ScColContainer() /sc/source/core/data/colcontainer.cxx:33:5
              #10 0x2ab6e070e3c6 in ScTable::~ScTable() /sc/source/core/data/table1.cxx:344:1
              #11 0x2ab6df50abba in o3tl::default_delete<ScTable>::operator()(ScTable*) /include/o3tl/deleter.hxx:55:38
              #12 0x2ab6df4c3483 in std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >::~unique_ptr() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:268:4
              #13 0x2ab6df4dc87c in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:98:19
              #14 0x2ab6df4dc7c6 in void std::_Destroy_aux<false>::__destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*>(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:108:6
              #15 0x2ab6df4dc744 in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*>(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:136:7
              #16 0x2ab6df4dc488 in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:206:7
              #17 0x2ab6df50df73 in std::__cxx1998::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::_M_erase_at_end(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:1513:2
              #18 0x2ab6df70f5b0 in std::__cxx1998::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:1248:9
              #19 0x2ab6df70b5d4 in std::__debug::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/vector:699:9
              #20 0x2ab6df704cb2 in ScDocument::Clear(bool) /sc/source/core/data/documen9.cxx:506:12
              #21 0x2ab6df490652 in ScDocument::~ScDocument() /sc/source/core/data/documen2.cxx:363:5
              #22 0x2ab6e363315d in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2925:1
              #23 0x2ab6e363333b in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2894:1
              #24 0x2ab6e3633514 in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2894:1
              #25 0x2ab6de4f105d in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29
              #26 0x2ab6de4a6259 in tools::SvRef<ScDocShell>::clear() /include/tools/ref.hxx:64:22
              #27 0x2ab6de2b1aaa in Test::closeDocShell(tools::SvRef<ScDocShell>&) /sc/qa/unit/ucalc.cxx:365:18
              #28 0x2ab6de2b2102 in Test::tearDown() /sc/qa/unit/ucalc.cxx:380:5
              #29 0x2ab6de543787 in CppUnit::TestCaller<Test>::tearDown() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185:15
              #30 0x2ab69335765a in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
              #31 0x2ab6ae4f3957 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:46:14
              #32 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              #33 0x2ab6a2974ff7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:78:12
              #34 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              #35 0x2ab69f4479c2 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:62:16
              #36 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              #37 0x2ab6932bfff4 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
              #38 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              #39 0x2ab69332272c in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
              #40 0x2ab6933c1b39 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28
              #41 0x2ab693356092 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:95:11
              #42 0x2ab693359af2 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
              #43 0x2ab693358cea in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
              #44 0x2ab693359af2 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
              #45 0x2ab693358cea in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
              #46 0x2ab6933ef6ce in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
              #47 0x2ab6933c059e in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9
              #48 0x2ab6933f062b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
              #49 0x4ff1d5 in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:329:20
              #50 0x4fbbc5 in main2() /sal/cppunittester/cppunittester.cxx:478:16
              #51 0x4fa052 in sal_main() /sal/cppunittester/cppunittester.cxx:614:14
              #52 0x4f9e9e in main /sal/cppunittester/cppunittester.cxx:609:1
              #53 0x2ab69517d554 in __libc_start_main (/lib64/libc.so.6+0x22554)
              #54 0x425894 in _start (/workdir/LinkTarget/Executable/cppunittester+0x425894)
        
          0x61700006c470 is located 752 bytes inside of 768-byte region [0x61700006c180,0x61700006c480)
          freed by thread T0 here:
              #0 0x4f7548 in operator delete(void*, unsigned long) /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_new_delete.cc:172
              #1 0x2ab6decf709b in o3tl::default_delete<ScColumn>::operator()(ScColumn*) /include/o3tl/deleter.hxx:55:38
              #2 0x2ab6decf5999 in std::unique_ptr<ScColumn, o3tl::default_delete<ScColumn> >::reset(ScColumn*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:376:4
              #3 0x2ab6decf4c8e in ScColContainer::Clear() /sc/source/core/data/colcontainer.cxx:42:21
              #4 0x2ab6decf4a84 in ScColContainer::~ScColContainer() /sc/source/core/data/colcontainer.cxx:33:5
              #5 0x2ab6e070e3c6 in ScTable::~ScTable() /sc/source/core/data/table1.cxx:344:1
              #6 0x2ab6df50abba in o3tl::default_delete<ScTable>::operator()(ScTable*) /include/o3tl/deleter.hxx:55:38
              #7 0x2ab6df4c3483 in std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >::~unique_ptr() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:268:4
              #8 0x2ab6df4dc87c in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:98:19
              #9 0x2ab6df4dc7c6 in void std::_Destroy_aux<false>::__destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*>(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:108:6
              #10 0x2ab6df4dc744 in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*>(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:136:7
              #11 0x2ab6df4dc488 in void std::_Destroy<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > >&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_construct.h:206:7
              #12 0x2ab6df50df73 in std::__cxx1998::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::_M_erase_at_end(std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:1513:2
              #13 0x2ab6df70f5b0 in std::__cxx1998::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_vector.h:1248:9
              #14 0x2ab6df70b5d4 in std::__debug::vector<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> >, std::allocator<std::unique_ptr<ScTable, o3tl::default_delete<ScTable> > > >::clear() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/vector:699:9
              #15 0x2ab6df704cb2 in ScDocument::Clear(bool) /sc/source/core/data/documen9.cxx:506:12
              #16 0x2ab6df490652 in ScDocument::~ScDocument() /sc/source/core/data/documen2.cxx:363:5
              #17 0x2ab6e363315d in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2925:1
              #18 0x2ab6e363333b in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2894:1
              #19 0x2ab6e3633514 in ScDocShell::~ScDocShell() /sc/source/ui/docshell/docsh.cxx:2894:1
              #20 0x2ab6de4f105d in SvRefBase::ReleaseRef() /include/tools/ref.hxx:163:29
              #21 0x2ab6de4a6259 in tools::SvRef<ScDocShell>::clear() /include/tools/ref.hxx:64:22
              #22 0x2ab6de2b1aaa in Test::closeDocShell(tools::SvRef<ScDocShell>&) /sc/qa/unit/ucalc.cxx:365:18
              #23 0x2ab6de2b2102 in Test::tearDown() /sc/qa/unit/ucalc.cxx:380:5
              #24 0x2ab6de543787 in CppUnit::TestCaller<Test>::tearDown() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:185:15
              #25 0x2ab69335765a in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
              #26 0x2ab6ae4f3957 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:46:14
              #27 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              #28 0x2ab6a2974ff7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:78:12
              #29 0x2ab693328cd7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
        
        during CppunitTest_sc_ucalc
        
        Change-Id: I778984beb9d1e355d3b8f9617b193424f332a32e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124709
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-11-05  Jim Raykowski  <raykowj@gmail.com>  [5c5f36aa73b11356a3bff0a9cc8b5fe8d1a776b9]

        SwNavigator: Improve detection of when the content tree needs refreshed
        
        Makes the check that determines if the content tree needs refreshed be
        done only when the content tree is visible AND (the document has been
        modified since previous check OR an action has been made within the
        content tree that requires the tree to be refreshed) AND there is no
        writer shell action pending AND the content tree is not in a DnD.
        
        Change-Id: Ie67472d44573df6afafb08b7b3229a4e07fc9db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124036
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [31550585970b9425215863d5ede94425328355c9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 03457ee108d22cf4eabf657de3c67968c8f93f36
          - Fix bookmarks in Collection help page
            
            Also fixes an extra "." in sf_session.
            
            Change-Id: I59aa5542e72b17658f494ee41b30f5475fa45872
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124690
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-04  Michael Stahl  <michael.stahl@allotropia.de>  [20ddabc88b6b45ea3efcc44ede5244ea526b09c4]

        tdf#144989 sw: disable idle jobs during printing or PDF export
        
        The problem is that (with the kde5 and WNT vclplugs) the idle jobs
        update fields and un-hides every section, which destroys the layout
        that SwXTextDocument::getRendererCount() finalised with great effort.
        
        This doesn't seem to happen with gtk3 or gen vclplugs.
        
         6  SwSectionNode::MakeOwnFrames(SwNodeIndex*, SwNodeIndex*)
         7  SwSectionFormat::MakeFrames()
         8  SwSection::ImplSetHiddenFlag(bool, bool)
         9  SwSection::SetCondHidden(bool)
         10 SwDocUpdateField::MakeFieldList_(SwDoc&, int)
         11 SwDocUpdateField::MakeFieldList(SwDoc&, bool, int)
         12 sw::DocumentFieldsManager::UpdateExpFields(SwTextField*, bool)
         13 sw::DocumentTimerManager::DoIdleJobs(Timer*)
         14 sw::DocumentTimerManager::LinkStubDoIdleJobs(void*, Timer*)
         15 Link<Timer*, void>::Call(Timer*) const
         16 Timer::Invoke()
         17 Scheduler::CallbackTaskScheduling() ()
         18 SalTimer::CallCallback()
         19 QtTimer::timeoutActivated()
         20 QtTimer::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)
         21 void doActivate<false>(QObject*, int, void**) ()
         22 QTimer::timeout(QTimer::QPrivateSignal) ()
         23 QObject::event(QEvent*) ()
         24 QApplicationPrivate::notify_helper(QObject*, QEvent*) ()
         25 QCoreApplication::notifyInternal2(QObject*, QEvent*) ()
         26 QTimerInfoList::activateTimers() ()
         27 timerSourceDispatch()
         28 g_main_context_dispatch ()
         29 g_main_context_iterate.constprop ()
         30 g_main_context_iteration ()
         31 QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) ()
         32 QtInstance::ImplYield(bool, bool)
         33 QtInstance::DoYield(bool, bool)
         34 ImplYield(bool, bool)
         35 Application::Reschedule(bool)
         36 framework::StatusIndicatorFactory::impl_reschedule(bool)
         37 framework::StatusIndicatorFactory::setValue()
         38 framework::StatusIndicator::setValue(int)
         39 PDFExport::ExportSelection()
         40 PDFExport::Export()
        
        Reportedly this started to happen with commit
        4184569b963877c2a488ff05766654b9db194798 - presumably before that the
        word counting was so slow that the idle didn't progress to updating
        fields.
        
        There is little point in running idle jobs during printing anyway as in
        the best case it will just slow down the process.
        
        So temporarily disable the idle jobs in getRendererCount() and
        enable it again in render() with "IsLastPage" set.
        
        Change-Id: I6359592aefeec298c5e58d44bef5ef16c583ddac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124721
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-04  Arnaud Versini  <arnaud.versini@libreoffice.org>  [b439832fc36a05e4423f480f7a312428f2449cc6]

        comphelper : use std::mutex in enumhelper
        
        Change-Id: I871c406e8ff94e646545cb82e0d1e2e2ec80c6e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [4acc39564e7bf6051b851d533d67d1c31a4a19ea]

        tdf#114613: sd_uiimpress: Add unittest
        
        Change-Id: I8bace97c83f97a4b2aed8ca7fb99e51e06995b8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124719
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-04  Stephan Bergmann  <sbergman@redhat.com>  [f8b10b76bc3000eab3269de4472d6c28bd308059]

        The std::auto_ptr workarounds should no longer be necessary
        
        ...with the bundled Boost 1.76.0, as boost/locale no longer uses it since
        <https://github.com/boostorg/locale/commit/322437a485c63d9fce4dc620597b6c75b6396daf>
        "Adding dual auto_ptr/unique_ptr support" in Boost 1.67.0 in combination with
        BOOST_NO_AUTO_PTR being set automatically when building for C++17 and beyond for
        both libc++ (via
        <https://github.com/boostorg/config/commit/0df7552f38cc059defa4189d7a36101925559eb8>
        "define BOOST_NO_AUTO_PTR when building with libc++ and C++17" in Boost 1.65.0)
        and MSVC (via
        <https://github.com/boostorg/config/commit/776bc8ac107e864fc4c51d6aee0e532026a50281>
        "Update for MSVC14's _HAS_AUTO_PTR_ETC" in Boost 1.60.0; if we didn't globally
        set _HAS_AUTO_PTR_ETC in gb_COMPILERDEFS in
        solenv/gbuild/platform/com_MSC_defs.mk since
        61c88ae6945c241f5f2aeb844eeca0776b487132 "gbuild: always compile as C++17 with
        MSVC 2017" anyway)
        
        Change-Id: Idd9d44c8350217f19ad2fa6749b90a9ffce38511
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124712
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [e54aa9fe665b5e065c86bd7564156cac262f9c02]

        tdf#91060: sd_export_tests: Add unittest
        
        Change-Id: Idb9156fb1ab1cc9c9a59a50af85db174eeefc3b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124717
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [9158d2d2f19cf7bccba12d2ad4cb340e882b51cc]

        blind fix for UITest_impress_demo failed
        
        Change-Id: I66dcc0d260585e5f44410a16bc25a32d8d373ae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124715
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-04  Caolán McNamara  <caolanm@redhat.com>  [4ab908e94da9305d6800c82b5d753c26193aa96b]

        Resolves: tdf#138826 adjust the aTmpMtf to get drawn at maPos of Action
        
        see also #i112076#
        
        Change-Id: I9c3eea3d5d518da164821bfcf494292dccb69e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124714
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-04  Caolán McNamara  <caolanm@redhat.com>  [1ba97706372fce487bead27ab69bb2e4bc3062e3]

        drop commented out code
        
        Change-Id: If7af5805b6e41a291216c773b6d105ce6802d903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124713
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-04  Julien Nabet  <serval2412@yahoo.fr>  [a11425579127502f4ee0972cc9fef09894e64a0d]

        Revert "tdf#132499: first stab to remove old stuff from ODBC ver < 3"
        
        This reverts commit 55133fc5fc499f6266f75ad3df77106f12333201.
        
        Reason for revert: this kind of change should be done upstream.
        
        Change-Id: I4051d13fe290bc750dbab820e1af68827eb9bfff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124692
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-04  Julien Nabet  <serval2412@yahoo.fr>  [88982b04ae2c451a5af62f7fc6c9502414590f92]

        Revert "tdf#132499: consider ODBCVER >= 0x0300 and remove tests about it (unixODBC)"
        
        This reverts commit 0464b86787da269be7b16a6f1f124d774f78fa97.
        
        Reason for revert: This kind of change should be made upstream
        
        Change-Id: I0dfe9ec198f826f636a7b2b2ba593b66c7e14c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124691
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7019c6999efa9bc42bfd931bfc001b175511d56b]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c3133e367000907747960c73ed372ecba249e3b1
          - Add thesaurus to pt-BR
            
            https: //pt-br.libreoffice.org/projetos/vero
            Change-Id: I8a5349b8cbabfc305c11368f1aac64fd08322820
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/124710
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-04  Jean-Pierre Ledure  <jp@ledure.be>  [393d8629be64fc01271fd746938bb822020f64b9]

        ScriptForge - (SF_Calc) _ParseAddress() reuse last parsed address
        
        Implementation to improve performance of a simple
        cache of the last already parsed range.
        
        The address is reused when the sheet name is explicit and that
        the range to parse, as a string, is identical to the
        previous parsing request.
        
        Change-Id: I0137689e9697686e76e07e037129983baba6ecfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124711
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [a04d60ca5af1b794c190fa9d5a0fb7506755f27d]

        use more DECL_DLLPRIVATE_LINK
        
        to avoid unnecessarily exporting symbols
        
        Change-Id: I4c9c7c86f288ba9655a8b919387e30f3096ccfb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124667
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-04  homeboy445  <akshitsan13@gmail.com>  [f90159697506e28ebbfb436047e52db1b65bd9a7]

        backendtest: Open Cubic-Bezier Curve Draw Test
        
        Change-Id: I1f41ab6d9dca4589da466caca1dfcbfdd15a5b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120425
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-04  Stephan Bergmann  <sbergman@redhat.com>  [7d4ff76868901fabd5a53ec951bbe1f05843960c]

        Fix check for libstdc++
        
        ...now that we have HAVE_LIBSTDCPP since
        7158acde7756a264c09e24e1cfe4c81db700b920 "Consolidate -D_GLIBCXX_DEBUG for
        --enable-dbgutil builds against libstdc++".  HAVE_LIBCXX was only ever defined
        in config_host/config_libcxx.h (since 90d2155912bcee40377620d4836726041a72d537
        "Work around latest Boost 1.65.1 still using deprecated std::auto_ptr"), never
        as a makefile variable, so this check (introduced in
        b1141fa61073b3f24e1a3574afa55a954e5a153d "Cut down on -pthread/-lpthread
        proliferation") always succeeded, whether libstdc++ or not.
        
        Change-Id: If71615b0ae2c6d3765eb538857f36bb1d23a667a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124683
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-04  Caolán McNamara  <caolanm@redhat.com>  [fe5dbd90cd5a39b5130f7c962cc6c7dee1c80f8f]

        Resolves: tdf#143643 ensure relayout on undo of insert comment
        
        Change-Id: I732e23b8ff7c17abf4b5b9b7c7964fca6069543c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124685
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-04  Caolán McNamara  <caolanm@redhat.com>  [039615e70d03f5e1abfe52dd7fe63d98d56377c1]

        their->there
        
        Change-Id: Ie78007226fa4ee96e5b5af472e1c95d12ba2e079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-04  Mike Kaganski  <mike.kaganski@collabora.com>  [706c7161fa1dd001c658bd1837e2b8e366693641]

        Simplify SvtCompatibilityEntry::setValue
        
        Change-Id: Ic891c31298bc68ede4a01134c2e9d3c95a78fe84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124689
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [01cbdcc6dd0cf575997e9899496115ac41ab4be1]

        tdf#119206: sw: Add UItest
        
        Change-Id: Iaf0e3be8a43eaaa4abb1efff9bc844ff38602d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-04  Stephan Bergmann  <sbergman@redhat.com>  [c218614ffa95ec62c0a0ad31583282d287042890]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 15deec972f2ea1e2076a74c4d206b49967c68844
          - Adapt helpcontent2 to var2file rename
            
            ...in core commit 3829c0c7db8768ca05f148e8f5c271ddb56d5bae "Resolves: tdf#97046
            ensure build system variables start with gb_"
            
            Change-Id: I2d9f579921843dbfb55efde492ea19abb3c6782e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124682
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2021-11-04  Stephan Bergmann  <sbergman@redhat.com>  [7158acde7756a264c09e24e1cfe4c81db700b920]

        Consolidate -D_GLIBCXX_DEBUG for --enable-dbgutil builds against libstdc++
        
        (this was meant as a prerequisite for enabling its -D_LIBCPP_DEBUG=1 counterpart
        when building against libc++ on macOS, but which got stalled for now after
        running into the issue described at
        <https://lists.llvm.org/pipermail/libcxx-dev/2021-October/001222.html>
        "[libcxx-dev] Building a program with -D_LIBCPP_DEBUG=1 against a libc++ that is
        not itself built with that define")
        
        Change-Id: If466dce595a9311b2afbae41d5ddcaecc6f3c57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124678
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-04  Miklos Vajna  <vmiklos@collabora.com>  [995a6b38d5b8ac8aabca54f991caaaf35e6db395]

        RTF import: fix too small graphic size when both picwgoal and picw are provided
        
        The original document provided \picwgoal and \pichgoal, stating the
        desired size of the image in twips. \picw and \pich is not provided, but
        we write it on export. The value of \picw and \pich is ignored by Word
        (it can calculate both the current and the original size from picw/hgoal
        and picscalex/h), so it displays the document correctly.
        
        Use the same trick in our RTF import: picscalex/y has a specified
        default value (100%), so if we have picwgoal and pichgoal, then we can
        also ignore picw and pich.
        
        This is needed, otherwise the much smaller size from picw/pich is used
        as the original size, so the layout "zooms in" so much that only a small
        white rectangle of the top left area is visible, as if the images would
        be all lost.
        
        Change-Id: I924e5f8b68613c654c857a57561c8a2e3a6db2f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124679
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8b7dbd220dbdfd286de2d770503dae8bf6d2e53e]

        sw: Wrong ZOrder after import for images anchored to non-1nd page
        
        Importing a document that has images anchored to the non-1st
        page, can result in images having the wrong the wrong Z index
        (ZOrder). If there are overlapping objects in the document,
        this can become a problem.
        
        The issue is with the call to SwRootFrame::RemoveMasterObjs,
        which removed the "master objects" - SwFlyDrawObj* castable
        objects. Normally the SwFlyDrawObj* objects on the page are wrapped
        and replaced by SwVirtFlyDrawObj*, but when the call to the
        RemoveMasterObjs was made, this hasn't happen yet to all the
        objects (objects that were not on the 1st page).
        
        The fix is to move the RemoveMasterObjs call to a different place,
        where we processed all the pages, so we can safely remove the
        remaining master objects on the page.
        
        Change-Id: I7d2f31614d269c22a82e7e5dea960f3d0844a5d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124597
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-04  Jean-Pierre Ledure  <jp@ledure.be>  [4d52e5a013d4315c14b741bb09b40d01b8846df7]

        ScriptForge - (SF_PopupMenu) Fix com.sun.star.awt.MenuItemStyle.AUTOCHECK
        
        To have checkboxes displayed correctly in KDE, it is necessary
        to use
          com.sun.star.awt.MenuItemStyle.CHECKABLE
        instead.
        
        No regression in behaviour observed so far in other environments.
        
        Change-Id: If15b2ff597f1cdffe2df65fe2352ffef0f770cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124639
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-04  Tibor Nagy  <nagy.tibor2@nisz.hu>  [cec1f712c87e557e1b7313e0dbef4a635f69d953]

        tdf#144918 PPTX import: fix internal hyperlink on shapes
        
        Slide names in internal hyperlinks of shapes could be replaced
        with the placeholder name 'Slide n', resulting non-functioning
        hyperlink during the slideshow.
        
        Follow-up to commit 83d92437e05a9ec872d9303953fa408dd4dcbcde
        "tdf#144616 PPTX import: fix hyperlinks on shapes".
        
        Change-Id: I733ddcdcdf92b32c4e6272d3cf48da872a63cd47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124135
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [60b9c16bd482e43cfc5d70d807b84df442707a83]

        fix potential out-of-bounds access in LocaleDataWrapper
        
        after
            commit 86b345a963a64fd9b9a3cab522b3ac2e909977fd
            Date:   Sat May 1 08:30:46 2021 +0200
            tdf#79049 speed up OOXML workbook load (4)
        if the number of reserved words returned by the locale is not correct.
        
        Change-Id: I1c709060a5f4e24c4278f3c36310364d10545f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124677
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-04  Sabyasachi Bhoi  <sabyabhoi@gmail.com>  [3829c0c7db8768ca05f148e8f5c271ddb56d5bae]

        Resolves: tdf#97046 ensure build system variables start with gb_
        
        Change the variable name: var2file to gb_var2file
        
        Change-Id: Ib7d64b76cfe10e6c2df1a176674a360b28704070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124666
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-04  Caolán McNamara  <caolanm@redhat.com>  [c0597c3126d6be683bd2085d1213b8b47f431558]

        Resolves: tdf#144686 set the initial "papersize" to the sidebarwidth
        
        this is the width it is eventually set to, setting that when constructed
        makes more sense so text height calculations for the annotation window
        are always sane for sidebar layout.
        
        Change-Id: I159255cd877478902599fc4e62b3f6c7df70abb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [64f0ca93871d11f5938d5c6844bb28d2ae32f546]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7488c63b40d151384e8aae67f78d804962e99c99
          - Add 12th param description for Calc CSV import
            
            Change-Id: I4aeeaabe4f3894dac067556824a8c3762c273dbe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124250
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-04  Stephan Bergmann  <sbergman@redhat.com>  [e5ba7ef1b89a9dcc48509c9bf7d6059dc8aa7ae3]

        libstdc++ bug 103022 is fixed in GCC 12
        
        (<https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html> states that
        _GLIBCXX_RELEASE "first appeared in the GCC 7.1 release and is not defined for
        GCC 6.x or older releases", leaving it a bit unclear what the status is for our
        GCC 7.0.0 baseline, so play it safe and assume it can be undefined)
        
        Change-Id: Iae10060bdab88e2e6df3954c2b6806534a761b31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124675
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-04  Hossein  <hossein@libreoffice.org>  [1edae86c729b66813aa81b531e196f493b766571]

        Change git.freedesktop.org -> git.libreoffice.org
        
        Replace git.freedesktop.org with git.libreoffice.org in the docs
        gernerating scripts. The output will be visible at the
        https://docs.libreoffice.org or the local docs folder.
        This completes the "Use LO repo for mkdocs git link" patch
        e62c4241093409583c913165ddc1e4c300c6218c
        
        Change-Id: Id38d86821cd1c4edb16edd760087c8361e221de3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124674
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [41b99644e8913dd4797775f4931382e93fa12a00]

        tdf#48622 Add new border line width defaults
        
        * Hairline (0.05pt)
        * Very thin (0.5pt)
        * Thin (0.75pt)
        * Medium (1.5pt)
        * Thick (2.25pt)
        * Extra thick (4.5pt)
        
        This unifies the default border line widths throughout the program.
        
        Users can still set any line width they want by chosing "Custom" in the "Border" tabpage.
        
        Also, existing documents won't be changed. The new defaults are just for newly added borders.
        
        Change-Id: I7af85dc189a688a749812824508c33c7814b50f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122683
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-04  Kevin Suo  <suokunlong@126.com>  [b9e43ab25fe2d93c2487fd33ed3c0f583009b968]

        Move these SC_STYLE_PROG_* and SC_PIVOT_STYLE_PROG_* constexpr to header
        
        so that they can be reused in other parts of the code base.
        
        Need to change them to inline to avoid "defined but not used" compiling error.
        
        Change-Id: I44de7c2ebbc9ae57c229f89faf69a788013d7816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-04  Tünde Tóth  <toth.tunde@nisz.hu>  [85a86ba6ba34ff0dfc92c3ce38cba86daf547121]

        tdf#145079 XLSX export: fix regression of internal hyperlinks
        
        Hyperlinks with internal named range targets didn't work.
        
        Regression from commit 3c3b9ad8886da916027f0fb940a2df822d63d4d7
        (tdf#143220 XLSX export: fix hyperlink to sheet target)
        
        Note: original test case of the unit test document
        of tdf#143220 wasn't changed. It's only extended with
        two new test cases for verifying the fix for the regression.
        
        Change-Id: I8128ebb977dba7304bc9c69e45f6c55c71f800cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123816
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-04  Miklos Vajna  <vmiklos@collabora.com>  [61be5d41e80cbce8e382cb468eb340a97bb4f508]

        vcl: remove not needed pObjectStream in PDFObjectCopier::copyExternalResource()
        
        The last usage was removed with 92134462f19ff234ce7615df34cc1fff6502727a
        (pdf: Improve dict and array format when copying with PDFObjectCopier,
        2020-11-12), now number elements write their parsed double value instead
        of copying a span from the original byte array.
        
        Change-Id: I344c9a9fc124a34a9db9c2747345b4b901f3e8b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124660
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [23255d395f40f6a20635b6f1c39e9d59a2047586]

        elide unnecessary UNO_QUERY_THROW calls
        
        Change-Id: I0d0fc57f352e9717e721416c8941cfcf48af24c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124650
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-04  Jeff Huang  <jeff@mail.ossii.com.tw>  [3165f0ff32b002a6efbc61af4f778ba4075b496e]

        tdf#143254 Replaces "Greek Upper Letter" with "Greek Upper Numerals"
        
        Change-Id: If32102394ca4630d8c3d7aa32e45f7770db008d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124665
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-04  Julien Nabet  <serval2412@yahoo.fr>  [3c1bd037802f5fbad9f43566a33500e54a6b9de6]

        Replace some macros in forms part 3
        
        Remove DECL_BOOL_PROP1 + DECL_BOOL_PROP2
        
        Change-Id: I8a07ac7b2b8ab724d5277a11b37cf10a6711fdb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124664
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-04  Justin Luth  <justin.luth@collabora.com>  [bac1b748f5b600952b9bf3eaaaf5a4bb8342fe59]

        prelim tdf#136472: adjust implementation specific unit tests
        
        Using a "First Page" style before a "Default Page Style"
        in order to apply a different header to the first page
        is an implementation specific detail.
        As of LO 4.0/4.1, we have the ability to set a different
        first-header (different even-odd were already available).
        
        So remove any dependency on "First Page".
        
        4-inheritFirstHeader.docx: just test the actual layout
        8-n777337.docx: margins must match both page styles.
           -First and Standard are defined from the same settings
        8-n779642.docx: reverting the patch breaks unit test: GOOD
        8-n780843.docx: export of footer works now - so test that.
           -PROOF: CONTINUOUS BREAK - SHOULDN"T SHOW FIRST PAGE - so turn off.
        9-headerfooter-link-to-prev.docx: a real thorn test.
           -happy it still passes after making this logical-seeming change.
        15-tdf135216_evenOddFooter.odt: is first of odd in ODT.
           -when first is shared, it still works to check first.
        
        Change-Id: Ice54ef9626f851f9154f3c274ffbe39455538589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124591
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-11-04  Johnny_M  <klasse@partyheld.de>  [c7500945fc5d5bd2130a2d38be0bd4b15445cd90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 887b0f6e0980f42d44b2fc79c4ae15f15e2603e2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I42d011f599c4fdc8c82d30d304273b7fb8ef3579
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124523
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-04  Johnny_M  <klasse@partyheld.de>  [90bfc16ca2252f217568c3875ad7223aa00387e3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b691161320fa8e5704183acfb15b19a07f2ff85
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2faf5b4da2dddf5736686cf6c7f03cdd3cc67ea2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124519
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-04  Johnny_M  <klasse@partyheld.de>  [6822081e66944084f0c38c8a5ce29c35f7397acd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a24b727eac86d93cd779b44bdcd046f6eceb0266
          - tdf#132643 Translate German section IDs
            
            Change-Id: I88e9ad41b88861fc22183cfb812bae652e3b2ff3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124515
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Stephan Bergmann  <sbergman@redhat.com>  [a5d3a3446832a7761584a00f7d2bc76ee713eb64]

        external/nss: Silence invalid-null-argument
        
        ...that happens now with --with-webdav=curl,
        
        > libc.c:107:21: runtime error: null pointer passed as argument 1, which is declared to never be null
        > /usr/include/string.h:65:33: note: nonnull attribute specified here
        >  #0 in nsslibc_memequal at workdir/UnpackedTarball/nss/nss/lib/base/libc.c:107:14 (instdir/program/libnss3.so +0x68cdb7)
        >  #1 in nssItem_Equal at workdir/UnpackedTarball/nss/nss/lib/base/item.c:185:12 (instdir/program/libnss3.so +0x68f59c)
        >  #2 in find_object_in_collection at workdir/UnpackedTarball/nss/nss/lib/pki/pkibase.c:714:18 (instdir/program/libnss3.so +0x63a72c)
        > [...]
        >  #49 in (anonymous namespace)::UpdateCheckThread::run() at extensions/source/update/check/updatecheck.cxx:534:48 (instdir/program/../program/libupdchklo.so +0x2235de)
        >  #50 in threadFunc at include/osl/thread.hxx:189:15 (instdir/program/../program/libupdchklo.so +0x251c74)
        >  #51 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:264:9 (instdir/program/libuno_sal.so.3 +0x65689f)
        
        The topmost nsslibc_memequal itself appears to be modeled after memcmp and not
        be intended to be called with null pointer arguments even if the size argument
        is zero, see its leading
        
          #ifdef NSSDEBUG
              if ((((void *)NULL == a) || ((void *)NULL == b))) {
                  nss_SetError(NSS_ERROR_INVALID_POINTER);
                  if ((PRStatus *)NULL != statusOpt) {
                      *statusOpt = PR_FAILURE;
                  }
                  return PR_FALSE;
              }
          #endif /* NSSDEBUG */
        
        in workdir/UnpackedTarball/nss/nss/lib/base/libc.c, so rather put the check for
        zero into the calling code in nssItem_Equal.  However, it is unclear to
        me whether one->data can legitimately be null there (and the patch is thus
        correct) or not (and the patch would thus silence a bug elsewhere; esp. given
        that nsslibc_memequal would return false instead of true in this case when
        compiled with NSSDEBUG.)
        
        Change-Id: Ie7556283cda500130dfcd1cfd315294277573b7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124663
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [ba72fc10571a0987b181564a2fc6395165ed6805]

        oss-fuzz build will need new mdds too
        
        Change-Id: I9ad34b6a5fe4dc5bcc79d949241739771ddadf75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124662
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Kohei Yoshida  <kohei@libreoffice.org>  [eb07a0e76fe240a184348d96a6cebf7c0a229ac0]

        Upgrade mdds and liborcus to 2.0.0 and 0.17.0, respectively.
        
        Change-Id: I9e856fc2d61f1789a6f1702514837860539a0f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124573
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-11-03  Johnny_M  <klasse@partyheld.de>  [9b9f4a4487e9ada1885d45a8b1ba0234a4a9fc26]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 937d0e7439564f46f8627032314878a6fefbd195
          - tdf#132643 Translate German section IDs
            
            Change-Id: I28cd7d852ed5260811f6388904c5b658be89b5d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124522
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Stephan Bergmann  <sbergman@redhat.com>  [ff22a3ff99da3abc0531c5a4eeccc25d45b61adb]

        Add back `== 2`
        
        ...that got lost in 23c8da878529f85ba5045db6f7ea7956a64dfc72 "put the message
        into static_assert" (causing a loplugin:consttobool warning)
        
        Change-Id: I8f2a97bd61edbfad0c871c0d2d0e25f1ce9f9f98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124658
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-03  Johnny_M  <klasse@partyheld.de>  [913c9aa8f5bb681b3437d21b0d18c02627e99ad6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d267338da14c3d505dcb2245e4fd4501b3351963
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ib70cf57c351c2342a3cebdd9052b42d134bb9e53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124516
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [29b39dfb667d330fbf6ce5be76adc845ee73df98]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a6242adb760c8f8603d9dd4af880e5a9ebae2a0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8a6f2d4b515337a8526ca5d09ab81b576edbd89f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124521
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [317100ad1d227a0508f8347b6787950c9e4d6025]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eb6bd3da8ce0678b5e5327fce347e68f90d2ff5f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie0c4bfb8006124b68b4928286c8b3a20423ea2eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124520
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [0c67012a1886189fec58de4dbace57d79979713b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2babd3eab5f8215751ad247ce153b9d140b95b1d
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id84cb4ee46cbd2cf9ec36bdddb64b5941364152b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124518
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [c587ac9e944925f48e84434531ab4fb934aaf128]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b87b645b2ebfa735b80b914cb797a3f32a48560
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7a8b06fb9d62a86bde0e868e61fba14209da2c09
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124517
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [05a57cee0123a87b5166645744bfb0cb28b9703d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c40485ef4bbc51aedc0418b76396624974089c2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I59dd1c081e4e8ba3933dbecfc74e4c61b167ee53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124514
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [5340ba24dda5414d5575e6a8a03680835f59d7ff]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93ffd5de051e831a94f5aa9cd3c19ff496a86370
          - tdf#132643 Translate German section IDs
            
            Change-Id: I23a1fbf80ae1e97677cb099645f87395a008ebcb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124492
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [cbe437ea1e5a8884051c71ef51f88b468b822361]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8cdfcc1ff2220e55fe74ed9889608406bc30d985
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6023ca2ccd54dd59e5e46d641fdb7a519a5333a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124491
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [2aef034db2108d178f711cb27a1e33d84f9ca361]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2809c7aea1e3c56369060756c245895d60dc2c50
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7b2c360e9ebc3e6a1a4863366c76164018d72c2d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124490
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [0481ed9e138187c36eb60158673287821629d60d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bf6321ea5344eeac7ce34453d776fe1bcf18468
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icbd1b5cbbd7aca5601464fe26964e9215b5686e6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124464
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [f6435fed1192d0f2f607c192db07f7f43d2b069b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bbde73f9f1d9bf847d9c9bdeb5e4bcbf44ee4fa3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3e318c60dd8913e48fa4d35a555d2bdd74b9f99e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124465
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [6d93317ab62f6f1e503aaa25f44470cbed5c6314]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f6ba20dac0a91953eef9b008fd7812af37f577b8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8f0341c0c04d9b0a67b02814a5b69128652e4029
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124466
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [4ed4f18d62c142fee6a9cef2c2f4c387315d630f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d7c59ba2fa33b3181d2b655a96555290142c8bff
          - tdf#132643 Translate German section IDs
            
            Change-Id: I86542dc4a1e981a151a66eb63114e14e03ab9003
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124487
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [7fed1b6be186780ff09310b2ec56d66543fb646f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f834fa449f14ef92b081ef07382e4104cfeff4c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I794daaf1c9394a01ff2be5fdce4e10f87c0e64fa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124488
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [adea4657391dc703246537350f6efdc9587eb685]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3aafea5d3bffa40b1ea4f3c6c756f1e0e2ff16f2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0e721bef0778f93e0277e26d13b969909c694ea0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124489
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Johnny_M  <klasse@partyheld.de>  [02d8b43827adf842fc869f7eaf979385c59576a2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66fbab252d3df0b9af39940ad66bfc264b97421b
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Icd333dbd67fbba8e1ff46cc4b78c78a4b29a2018
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124463
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b64efd7b291cfb231ab511ec80db2d12b30ac05d]

        Revert "loplugin:finalclasses"
        
        This reverts commit 9ce9011230a97f3fe4fcd2f8d761781c4300772b.
        
        Reason for revert: see comments in https://gerrit.libreoffice.org/c/core/+/124632
        
        Change-Id: Ibc8b7a8c190e7a8afec793c1202dba97ac6909bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Julien Nabet  <serval2412@yahoo.fr>  [0464b86787da269be7b16a6f1f124d774f78fa97]

        tdf#132499: consider ODBCVER >= 0x0300 and remove tests about it (unixODBC)
        
        Change-Id: I47eb05309ac7569e1e89a93d3b482c7bff97c159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124611
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-03  Julien Nabet  <serval2412@yahoo.fr>  [d33613c067c198c2a6ef30fb56bcc0cce7565c9b]

        Replace some macros in forms part 2
        
        DECL_PROP4 + REGISTER_PROP_2 + REGISTER_PROP_3 + REGISTER_VOID_PROP_2
        
        Change-Id: Ib7fdfed9f94fe0bb2c3f4f1398bc058af84823d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124615
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-03  Luboš Luňák  <l.lunak@collabora.com>  [b33bd288111fc07177b3dc36c3b2f8d60a5dec19]

        PCH for external/poppler
        
        Change-Id: Ic534528d9aeab103d93dc2a627e15460766aec2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124653
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-03  Luboš Luňák  <l.lunak@collabora.com>  [c51e5ac229d79040c5a556945f6522fc2f6da778]

        PCH for external/zxing
        
        Change-Id: Ia4bfa53ff56f64c7ba8fa068bbbe9dff2c4a84fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124652
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-03  Stephan Bergmann  <sbergman@redhat.com>  [8d95452f66c01187c4b05a30061300125042cf46]

        Avoid false -Werror=array-bounds
        
        ...with recent GCC 12 trunk,
        
        > svx/source/unodraw/unoprov.cxx:904:28: error: array subscript 25 is above array bounds of ‘const SfxItemPropertyMapEntry* [25]’ [-Werror=array-bounds]
        >   904 |     if(!aMapArr[nPropertyId]) {
        >       |         ~~~~~~~~~~~~~~~~~~~^
        > In file included from svx/source/unodraw/shapeimpl.hxx:22,
        >                  from svx/source/unodraw/unoprov.cxx:45:
        > include/svx/unoprov.hxx:86:37: note: while referencing ‘SvxUnoPropertyMapProvider::aMapArr’
        >    86 |     SfxItemPropertyMapEntry const * aMapArr[SVXMAP_END];
        >       |                                     ^~~~~~~
        
        Change-Id: I60e5352aff0d0aed3056bc484fb1491626761051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124655
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-03  Jeff Huang  <jeff@mail.ossii.com.tw>  [95e7a57df68c9d631bfce0460b44b9ed966cd5bd]

        tdf#143548 Add 3 dots after Select Macro and Select Module strings.
        
        Change-Id: Ifc3ea0652b3bda1f8671d88d9b6f7d28a87c53f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124625
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [5e01f82b0918d2b54acee36f8d47de18d9340a53]

        Resolves: tdf#143443 size of comment box too tall after cut/paste
        
        a problem since...
        
        commit 69c546e1e7a697217f273baa7c1729ff823efd76
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Fri Dec 4 16:30:31 2020 +0000
        
            weld annotation window
        
        this sidebar case assumes that the papersize of the underlying
        editengine is initially unlimited in size
        
        Change-Id: I127f249158deecef3e2c6874982b4e7cc78e69fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124656
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [42f106cdab59c2659b1637cc51660487863f475f]

        tdf#117895: sw: Add UItest
        
        Change-Id: I252af7af5aa8bea20f959cf3c868fa73cd538749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124648
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff6bd3c61fc514658b87cd572f6dc4d7e67f75c4]

        tdf#145326: sw: Add UItest
        
        Change-Id: If18f1011745143349c2793a4baa8c6bf6a0879c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124647
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-03  Tor Lillqvist  <tml@collabora.com>  [5f8b834eef1565a0523aabd6dd8af5f1b0fd4c75]

        tdf#145354: Don't claim random paper sizes from the system are "User Defined"
        
        For instance, the driver for my printer (or maybe Windows itself, no
        idea where the list of sizes comes from originally) says it supports
        215 x 345 mm. Which apparently is an obscure paper size called "India
        Legal". It is confusing if the Print dialog claims that it is "User
        Defined" when I have never even heard of such a size, and the document
        does not specify it either.
        
        Change-Id: I44196fd21fd83a94d255ebb909e5d63e35c5d1e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124649
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-11-03  Tibor Nagy  <nagy.tibor2@nisz.hu>  [4bfe8304a5600e236043e4ad7c6dc75fd05c937b]

        tdf#144914 PPTX export: fix interactions and hyperlinks on shapes
        
        Follow-up to commit 83d92437e05a9ec872d9303953fa408dd4dcbcde
        "tdf#144616 PPTX import: fix hyperlinks on shapes"
        
        Change-Id: I56538da8d97e052af03c78e8d7eaa16c5c2fde1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123748
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-03  Kevin Suo  <suokunlong@126.com>  [ac3266cccc3b65d1bfc1319d55fb0d1b35e96f65]

        This aParentName can be const
        
        Change-Id: If3d94b7b8e9b10934b1be0771c4c85536bc750f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124642
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-03  László Németh  <nemeth@numbertext.org>  [643bbf9e47e909b2d4acefaee791c9dd7d9e4a8d]

        tdf#145311 sw track changes: fix moving over empty list item
        
        which was changed to tracked insertion.
        
        Follow-up to commit 4c982dbafdac900e233d7b68d95c9c99244defc1
        "tdf#145225 sw track changes: fix bad insert at moving".
        
        Change-Id: If3d70da71188e95b5aeea9b72e7c9de22d7c7150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124645
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e72bbb8d41cdf3eec86804afa1a6dd527925be04]

        Silence spurious Werror=maybe-uninitialized in transliterateImpl
        
        only seen in optimised build
        
        Change-Id: Ibf344efa034feefdc6e03d489a0a6b28461b76e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Rishav Chattopadhya  <rishavchatterjee1546@gmail.com>  [7a8cbfafca1906baad2bcbf8aa6717d197ae423a]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: Idb078379c4388d7dd9525500e18064f2f873e6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124091
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-03  Felipe Lema  <felipelema@mortemale.org>  [8b1318324e574e510adb0c39fd744de360dd19b3]

        tdf#97667 Add XML Dump methods for Calc Pool Items
        
        Continuation of https://gerrit.libreoffice.org/c/core/+/88475
        
        Change-Id: Ic41ae7df362a796c56e95b38ccb534bbe045ead7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113497
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [950483343d2f8218ac886aac27e1072bfec304bf]

        Related: tdf#143443 remove PANGO_ATTR_ABSOLUTE_SIZE and PANGO_ATTR_SIZE
        
        when setting a new size because an absolute size set by gtk itself seems
        to be not overwritten by pango_attr_size_new so sometimes the size of
        the font in the annotation window label is too large
        
        Change-Id: Ib69eec2111336cc27d1571babcc891f16cae2f01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124641
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Stephan Bergmann  <sbergman@redhat.com>  [487acc0c42984199be603df68f1a6df02849e527]

        Silence loplugin:toolslong in ucb/source/ucp/webdav-curl/CurlSession.cxx
        
        ...similarly to how it was already done for its
        ucb/source/ucp/webdav-neon/NeonSession.cxx cousin
        
        Change-Id: I78124f45d4cb08131ee5d6e8c2606b38407c0668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124637
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [7e23fec4b72a3512b898a84dd07fb89f6a6af25a]

        Introduce 'scale' to Point/Size/Rectangle, to simplify anisotropic scaling
        
        Change-Id: I12c25838e8eec8d05e43b593790847c626edde31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124638
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-03  Tor Lillqvist  <tml@collabora.com>  [9c6aa26092c509ec11be686451c77033e3474b33]

        Drop the --with-macosx-sdk option
        
        The help message for that option even said "With current Xcode
        versions, only the latest SDK is included, so this option is not
        terribly useful". And that was written in 2016. So by now, the
        --with-macosx-sdk option surely has outlived its usefulness.
        
        Change-Id: I467194c96c571822c08ea82bb7e62f0e2a2d332b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124549
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-03  Tor Lillqvist  <tml@collabora.com>  [0f1155503e17a78fc5b4afb51a7afff365ecd1f0]

        Bump minimum macOS to 10.12
        
        Change-Id: I1a4af1af2eb95cb182491b2de2ac05dc3a1cb0c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124547
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-03  Tor Lillqvist  <tml@collabora.com>  [65081542d2dabdf17820d62abdc5a22d3734e52d]

        tdf#145354: Ensure displayed paper name matches displayed paper dimensions
        
        I could not reproduce it now but at least in some slightly older
        version of LibreOffice, it could happen that at the top of the print
        preview image was displayed "143 mm (A4)" which is silly, as neither
        side of an A4 paper is 143 mm.
        
        Look up the matching paper size from the dimensions displayed. Use the
        "sloppy" match function to allow for sub-millimeter rounding errors.
        
        Change-Id: I6320798061246101c6fc78baf841b71b32b25833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124612
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [23c8da878529f85ba5045db6f7ea7956a64dfc72]

        put the message into static_assert
        
        and use more static_assert where its obviously possible
        
        Change-Id: I9466130809acab12505f0760f970793991564165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124633
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [7ab9d4caddcf3e2b4e1f5541ebd85f4559bff615]

        tdf#145361: sw_xhtmlexport: Add unittest
        
        Change-Id: I4bbbdfa71f69ae2659922dce4b7445bcadc7d73a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124636
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c47f33a640816ef1859e6f3b53aaafcdbce5e5c]

        improve find-can-be-private script
        
        add progress display and cleanup child processes
        
        Change-Id: I86cc13dee17f6d1ea2874f0ebe178426fbc82076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124634
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ce9011230a97f3fe4fcd2f8d761781c4300772b]

        loplugin:finalclasses
        
        Change-Id: I72ffe7dbeb1558820ac4368ef551611096da0104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a4bcae71053b2db33d80036a0707edbe1ddb270]

        loplugin:finalclasses
        
        Change-Id: I80ac98249f8ef6b24939de59e32eda4fa2e79fba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124631
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [68cea95423818f6ae19b735e2029284c5fc9397b]

        tdf#145326: fix breaking DDE links
        
        Change-Id: Ib80a83ed1e4c87ee6af2f8ef55309ad9779aac66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124455
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-03  Natalia Gavrilova  <nataligavrilova8@gmail.com>  [0a059912bae4e3bc0b2640efb4e163d79f54a5d7]

        tdf#114441 Convert use of sal_uLong to sal_uInt32, int
        
        * Changed moduldlg.hxx, moduldl2.cxx
        * Changed res_DataLabel.hxx, res_DataLabel.cxx
        
        Change-Id: I845c9fb7b60b5a8f898aaac433c0b5e520c58678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123360
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [4ed359093c991291216c39cffe14a60e607ec551]

        fix misplaced line
        
        Change-Id: I6c3aea554787b30a8ffa3bc61ab6597d8b755881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Caolán McNamara  <caolanm@redhat.com>  [1a8ac2e1004f1753f117982aca8baa1512b11522]

        can use static_assert for compile time check here
        
        Change-Id: Ib1b350068bf80431bf0be3263a1a87523066996b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124621
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-03  Michael Stahl  <michael.stahl@allotropia.de>  [895918b07da8fbe5603b3a96b3c58a8dc2d066e5]

        ucb: webdav-curl: consolidate unit tests
        
        1 CppuniTest makefile should be sufficient, particularly since all 4
        of them used gb_CppunitTest_use_library_objects so this should reduce
        wasted space.
        
        Change-Id: I485f0af0aee2b265b56c505ced44257834784e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124608
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-03  Michael Stahl  <michael.stahl@allotropia.de>  [5a44e3772adb281d16757cdac3120d56565a96e5]

        ucb: webdav-curl: convert webdav unit tests to curl
        
        There's no point in building the tests for neon any more, just build
        them only if curl is used.
        
        This finds a bug in CurlUri::Init() where query and fragment separators
        need to be added manually.
        
        Change-Id: I3dcd1512450522df2c2a7d223b2e29b6c0e794fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124607
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [17dface79321c87b2d30a53a67aeda2e9f9dfff6]

        Drop TWIPS_PER_PIXEL and use o3tl::convert
        
        Change-Id: I8ee3fddaccf6809c95319db1da9a1d2897d00c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124626
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-03  Miklos Vajna  <vmiklos@collabora.com>  [996ca8ecfde2c9aa2f8b188f1f8eec3a912b2cd2]

        CppunitTest_sw_ooxmlexport13: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I08a4ba4a1219b90a3652ae63c1e3a11dd9fa1208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124614
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5da6c31a76a95a19bd15ebdb0d1321b7d1240cc7]

        loplugin:finalclasses
        
        Change-Id: I10ff73f89c965beb3cfb5fc3a40dd959d8f77aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124600
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [6299c8cae923198c55d47320fa8a89bbcd5b0f2b]

        loplugin:constparams
        
        Change-Id: Iebeb531fad5cc819b536788925cf8508737198b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124599
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-03  Stephan Bergmann  <sbergman@redhat.com>  [de39e35b21134e9a0f946aabe4859b16a62b248d]

        Avoid float-cast-overflow
        
        > Testing load file:///~/lo/core//sw/qa/core/data/html/pass/ofz40593-1.html:
        > sw/source/filter/html/svxcss1.cxx:2869:44: runtime error: 1.70141e+38 is outside the range of representable values of type 'long'
        
        during CppunitTest_sw_filters_test with test file newly added with
        2f01faaf88b6d172d7293f0c9e2a061d99b8ceb5 "ofz#40593 remove Objects from
        m_xResizeDrawObjects if deleted during parse"
        
        Change-Id: Ida97b886c254272fd2a506a8d7ad2319fed72dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124623
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-03  Luboš Luňák  <l.lunak@centrum.cz>  [9b9a8f47894760e7a95ed276feeef00d3b1c94d1]

        fix gcc-wrapper for ccache.exe
        
        This reverts a part of 18cc01b63996f81b284e3bc827d1be7f3da8983a .
        
        Change-Id: Ib7abbc41eeb6abd573f540ae2d0d2822e68b9abb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124613
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [33db559089fcf5ff9f6e0e5bb4e41fce969cbdad]

        Fix typos
        
        Change-Id: If203853359b1c30c6cb6feea6c1ff718bcaa0188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124622
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-03  Justin Luth  <justin.luth@collabora.com>  [1891061f0b99c8a7c5d9983b925efcf401c958fd]

        prelim tdf#136472: remove implementation specific unit tests
        
        These test documentations are completely pointless.
        They test something implementation specific without
        anything to actually test for accuracy.
        
        4-test_segfault_while_save.docx: pseudo-preventative test.
        8-fdo49940.docx: an empty page with no header/footer enabled.
          Who cares if it is called Default style or First Page.
        
        Change-Id: I4a9a6fcfe3621eaa745470487b32b2cbd66f0973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124590
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-11-03  Mike Kaganski  <mike.kaganski@collabora.com>  [e25be4fb3aa5e8ebc25d7685d83abac765f9e644]

        Prepare for removal of non-const operator[] from Sequence in testtools
        
        Change-Id: If67f845a0350766c7d098a399bd2fae6048c9100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124400
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [8fbd4a5f6850ed94169f50617dc97c5fb054504b]

        ofz#40625 avoid Integer-overflow
        
        not much else can be done as far as I can see except to saturate
        
        Change-Id: Ifb7e47b03c76eca26b7340b047032e971401e86b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [7a52e06ea062549d385270b368d549c92fbad841]

        cid#1493241 Wrapper object use after free
        
        unclear if this is the right fix here
        
        Change-Id: I6910ff405c2acb03fadd8e751e971d9b010b7d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124620
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Stephan Bergmann  <sbergman@redhat.com>  [6f26a7246456d8989e83d658a211b5d2608568f5]

        Tweak loplugin:implicitboolconversion to allow some more bool -> sal_Bool
        
        ...in templated code, to cater for the needs of
        <https://gerrit.libreoffice.org/c/core/+/124400> "Prepare for removal of
        non-const operator[] from Sequence in testtools".
        
        For one, by defining ImplicitBoolConversion::TraverseInitListExpr, make sure
        that Clang versions before and after
        <https://github.com/llvm/llvm-project/commit/0a42fe70a566f22599e04a6f1344ca2dc5565e17>
        "[AST] Treat semantic form of InitListExpr as implicit code in traversals"
        behave the same.  Old versions of Clang would have erroneously reported
        
          Sequence<Sequence<sal_Bool>> s2{ { false } };
        
        (and reported
        
          Sequence<Sequence<sal_Int32>> s4{ { false } };
        
        twice) in compilerplugins/clang/test/implicitboolconversion.cxx when one of the
        four combinations of syntactic/semantic visit of the outer/inner InitListExpr
        defeated the intended suppression logic in
        ImplicitBoolConversion::TraverseCXXStdInitializerListExpr.
        
        And for another, ImplicitBoolConversion::TraverseInitListExpr can subsume the
        exising ImplicitBoolConversion::TraverseCXXStdInitializerListExpr.
        
        But for a third, that would still make
        
          Sequence<Wrap2<sal_Bool>> s6{ { false } };
        
        in compilerplugins/clang/test/implicitboolconversion.cxx emit a false warning,
        so add a cheesy "TODO" chicken-out special case to
        ImplicitBoolConversion::checkCXXConstructExpr for now.
        
        Change-Id: Ib9a1b78a7812feb98c673b75a357af7737168342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124583
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [c9b100df77331ebe1f5e66b9dd248c8cc43a885f]

        Drop char*-based API from NamedValueCollection
        
        Change-Id: I87f339b348580e256a8d65470ad15cbdabf2c9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124609
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b0e574a8be2a080f5039e968f4f32ce4b8fa2b26]

        xmloff: Prevent gutter margin xml property to be deallocated
        
        Previously we stored a pointer to the gutter margin XMLPropertyState
        so we could read it later. The problem with this is that in between
        when we storing and reading the property state, we add elements
        to the rProperties vector, where the XML properties are allocated.
        
        Adding new elements to the vector can cause that the internal
        array is reallocated to a bigger size and elements copied to the
        new array, so our pointer shows to a invalid (deallocated) memory
        address.
        
        This issue is fixed by moving the code up to before we add new
        elements to rProperties vector and a big warning is written to not
        use XMLPropertyState* pointers after the code adds to the
        rProperties vector.
        
        Change-Id: I24b0285d49e678fcb3b333bf4054f5cef4207003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124572
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-02  Jim Raykowski  <raykowj@gmail.com>  [1441b4e83337fe2389eaae146b43a8e7c036a85d]

        SwNavigator: correct outline level comparison used in determining
        
        outline content type member count
        
        Outline content type member count can be less than the number of
        outline nodes in the document model if the outline level setting is
        less than outline level maximum, MAXLEVEL. Currently, the outline node
        count is incorrectly compared to the outline level maximum in
        determining the outline content type member count. The member count is
        compared against the old member count to determine if the member array
        needs to be cleared and filled when a member in the array is wanted by
        a call to the GetMember function. This patch changes the outline level
        maximum to be compared to the set outline level.
        
        Change-Id: Ie1348575becbbc14446b417bcd568f158330cf9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124537
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-02  Tor Lillqvist  <tml@collabora.com>  [ae6f7eecfc62442584473034853539706b03f7af]

        Add comments to two arrays mentioning that they must match the enum Paper
        
        At least I think they must. Also add a comment to the enum pointing at
        those arrays. There are now four different places in four files that
        must be manually kept in sync. Quite possibly more. This stinks.
        
        Change-Id: I7b5c721329c69a16b8cdf07390d481ec77c7b5ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124610
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-11-02  Julien Nabet  <serval2412@yahoo.fr>  [de9f8683234ea2187f650210b7c3e66818778e9f]

        Replace some macros in forms
        
        DECL_IFACE_PROP2 + DECL_IFACE_PROP3 + DECL_IFACE_PROP4
        + DECL_BOOL_PROP3
        Change-Id: Ibfe652001f4e914cad364222bcaf38dec69298e5
        
        Change-Id: I432e045b9d071d61cd142bca66f40233cd59ef0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124564
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [39994c43bf6610f2a8fde55f54ed9a7e279935b4]

        Resolves: tdf#119206 run properties sync when launched during save
        
        use (abuse?) a SynchronMode of true, which will become
        SfxRequest::IsSynchronCall of true in SfxObjectShell::ExecFile_Impl to
        request that we do not want the properties dialog to be run async. It
        looks impractical to rearrange all the post-dialog-call close code to be
        part of some callback executed when the dialog completes.
        
        Change-Id: Id2bde24986204dea3d312c0b4a91bf5c0a6f7916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124606
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [688489959e69994d455f36f3e9bb4c0ba3ee87aa]

        Revert "tdf#117895: "Edit document properties before saving"..."
        
        This reverts commit 3add3e5b70ad991c8351a54b0da62d05e977458f to try
        and alternative approach
        
        Change-Id: Ieb36b78246586cc7f1977c67eab130d2ae025988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124605
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [fffd76195e0701cf774e36963105cd63a2e65a26]

        Revert "tdf#120343 show pdf in async pdf export dialog callback"
        
        This reverts commit 9df8a2eb8c216b16927aac2182b881b21d8b2d14 to try
        an alternative approach.
        
        Change-Id: I2f1e2cd28cbaee5ab3d7a3cec808ec5bb7777cb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124604
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [8423861a74d7c6425ed2c3699806dd97415a04e1]

        drop PendingDrawObjectsInPaM in favor of detecting draw objects removal
        
        Change-Id: I9f24f16ae47c8c178259650944bd80e19d6a887d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124568
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Julien Nabet  <serval2412@yahoo.fr>  [55133fc5fc499f6266f75ad3df77106f12333201]

        tdf#132499: first stab to remove old stuff from ODBC ver < 3
        
        Change-Id: I683d4933fe4a2453b8ac5e9e8aa61946c4173bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124566
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [2f01faaf88b6d172d7293f0c9e2a061d99b8ceb5]

        ofz#40593 remove Objects from m_xResizeDrawObjects if deleted during parse
        
        Change-Id: I11fa665175ef067a36f4822676c02d4df1e1e250
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Jim Raykowski  <raykowj@gmail.com>  [edfb9ddb55d2959b8d05366233183306d19b3780]

        SwNavigator: fix two uses of UpdateListBox
        
        1) UpdateListBox only needs to be called in the CommandHdl function
        when the content tree displayed is changed using the context menu
        Display submenu.
        2) When content is deleted it is unnecessary to call UpdateListBox.
        
        Change-Id: I69679b4b074932dff5d594217e456ca818971032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124578
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-02  Jim Raykowski  <raykowj@gmail.com>  [7826ed1b4a4f1424f7425037da4ecec86ab24d46]

        SwNavigator: Track frame content before other content
        
        Do this to prevent other trackable content from being track when a
        frame is selected. e.g. a hyperlink is at the start of frame content
        and the frame is selected. Without this patch the hyperlink is
        highlighted in the Navigator content tree instead of the frame.
        
        Change-Id: I0adac6659de6a5698b50a887052cc6aaffee578d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124577
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [0f684565d9246ccc39766289e9a5c383e8f9d838]

        extract a ReorderingDropTarget for reuse
        
        Change-Id: I0ae69bbf644e220e1bf3352d98eb4fd735167416
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Jim Raykowski  <raykowj@gmail.com>  [e0fa72a714c1992370f023308814acf96763e2c9]

        SwNavigator: Make list of open files in Display sub menu consistent
        
        with list of open files in open files list box
        
        This patch makes the display format used for the list of open files
        in the content tree context menu 'Display' sub menu consistent with the
        display format used for the list of open files in the open files list
        box by adding '(inactive)' after the file name of an inactive file and
        removing the space after the open parenthesis and before the closing
        parenthesis surrounding the word 'hidden' for the hidden shell file.
        
        Change-Id: I91670377fae576cab6f013ed6f2eb3d0e6a88eaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124580
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [2aed402cf922479813ac1ce048c8ed276407401c]

        Resolves: tdf#136945 fix custom slide show dnd to reorder pages
        
        Change-Id: Ib28d6779e772fd8ad30899354cde2c281085b328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124593
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Jim Raykowski  <raykowj@gmail.com>  [60d51a43d4fb047ae814ef5296ffb8031080262a]

        SwNavigator: Disallow going to content when content is not visible
        
        Change-Id: I3644956866b562118fcb4610bce0b977cab29dce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124576
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-11-02  Henrik Palomäki  <henrik.palomaki@yandex.com>  [0935a53a1ef70d0cbaef5fbfe2a0bc2f3ddfeafd]

        tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I0b95ad5d1e46ed04717d7dccec7c6621b5d4d1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124595
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-11-02  Henrik Palomäki  <henrik.palomaki@yandex.com>  [1637f4449c10ec1f8869498ba0cafc61a8a77bbf]

        tdf#141908 replace usage of sal_Int32 with colors in htmlexport
        
        Change-Id: I0403ccdb875f5372a13ebdc0fdf0f4ed396af773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124436
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [49e087ef44d3b7b26baf71469621c0a2135e00a9]

        vs-ide-integration: make projects' GUIDs stable
        
        Use uuid.uuid5 with a custom URL to generate stable GUIDs. This avoids
        glitches in IDE when re-opening the solution after its re-generation
        makes some previously opened files to show duplicate entries in IDE's
        tabbed UI.
        
        Also drop the UniqueIdentifier elements from .vcxproj.filters files,
        which are optional and only used in VS automation [1], so are useless
        with randomly-generated GUIDs.
        
        [1] https://docs.microsoft.com/en-us/cpp/build/reference/vcxproj-filters-files
        
        Change-Id: I91dae730286b3187a6ceffcb9ae3afc2b479f4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124594
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-02  Attila Szűcs  <szucs.attila3@nisz.hu>  [4c31b4ef2083087a822c3ae648fd09acc67d2f88]

        tdf#139336 sw: fix extra pages of multicolumn sections with footnotes
        
        Adding footnotes to multicolumn sections resulted page-long
        section layout, not regarding to the amount of its text content.
        E.g. a page with n multicolumn sections and footnotes could load
        as n (mostly empty) pages. The problem is related to the footnotes
        showed under columns of sections, which can be ambiguous at different
        column number of the different sections on the same page.
        As a workaround for interoperability, show footnotes per pages to
        remove the extra pages, e.g. allowing to show the separated sections
        on a single page, like MSO does.
        
        Note: a compatibility option will be added to avoid regressions.
        
        Note: This fix doesn't change multicolumn page styles or not evenly
        distributed multicolumn sections or footnotes not collected at the
        end of the sections.
        
        Test: choose Edit Section... in local menu of the sections of the
        unit test document. In Options..., see checkbox "Evenly distribute
        contents to all columns" on page Columns, and Footnotes/"Collect at
        end of text" on page Footnotes/Endnotes. To see the result of the
        new settings, save and reload the document. Note: DOCX format doesn't
        support "Collect at end of text", only OpenDocument.
        
        Note: In MSO, it's possible to set multimulticolumn footnotes
        separately from section column number. It's column number can
        be 1–4, or "auto", which uses the column number of the first
        section of the page.
        
        See also tdf#138508 (Single column footnotes on multi-column pages).
        
        Change-Id: I6a3534ac043971479275a3e8bb0713bd3d8ceaa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121822
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [83298077a4cd577860e2114b429a2d413c3ea10c]

        tdf#136945 use ListStore instead of TreeStore to avoid dnd creating subnodes
        
        because this just wants a flat list and a drop "on" a row shouldn't
        create a child of that row, but a sibling
        
        Change-Id: I0a6b360ffe13018d6878bd4bc3012ee3f5807a1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124589
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [be507ca6acc91c10e4be812d626bbf5eab807f73]

        vs-ide-integration: create folders for Executables/Libraries/Tests
        
        This makes the solution more manageable - one can collapse unneeded
        categories.
        And put LibreOffice.natvis to Utility folder, to move it to bottom.
        
        Change-Id: I869faaf5756c65e6812b58627acd03bf816dea2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124588
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [b6ef68cdaa51ca5c9fdab40ade97f4a0f18da51b]

        keep showing focus rect on the first element during highlight
        
        for the case nothing is selected but non-hover shows the bare focus
        rect to indicate focus is in the valueset though nothing is truly
        selected
        
        Change-Id: Ibe7fa38711f935126e1c0803c395b43b9720ca6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [5fbc81640770dfe11907b2f92f3ae455e582a302]

        mbDrawSelection is always true when evaluated
        
        Change-Id: I043e68d5a5a6af8814f1db0f61f1cd95078ad11c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124570
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Caolán McNamara  <caolanm@redhat.com>  [6896eb8dc44069808f5fef452c9802eaf0c51501]

        crashtesting: ended up using the wrong strerror_r
        
        since...
        
        commit bbab833bd956e220db3548ddd0a00dfd30836de1
        Date:   Thu Oct 28 10:07:00 2021 +0100
        
            endian check in internal neon looks dubious
        
        Change-Id: If96bb1bc1dda70f25fa49b3c68ee8993db7d9017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124587
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f2e1e4ff085962a08a5d7738325b383c07afcbbd]

        xmlsec: fix OOXML signing with multiple certs, extend the test
        
        Signing OOXML with 3 or more times didn't work as other ids
        ("idPackageObject", "idOfficeObject", ...) were not uniqe. This
        change makes those ids unique by appending the signature id. The
        signature ID is now generated for OOXML too, while previously it
        was a hardcoded string ("idPackageSignature").
        
        The test for signing multiple OOXML was written before, but didn't
        catch the issues because it didn't assert the status of the
        document after loading it again. This is which is now fixed (and
        also added changed for the ODF test case).
        
        Change-Id: Ifa20ea17498b117a4c57f6eddf82f8e83bc640bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124571
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-11-02  Miklos Vajna  <vmiklos@collabora.com>  [1076f634c19527770a2e465ea0d8c561c8491f26]

        sw: prefix members of SwAnnotationShell, SwBaseShell, SwContent and ...
        
        ... SwDrawTextShell
        
        See tdf#94879 for motivation.
        
        Change-Id: Icaa59a07dcc680a9f2f167165c89fec72e99d92b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124582
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-11-02  Justin Luth  <justin_luth@sil.org>  [f5c618f4e5d3ef2a33301d5f20035bb8bc213a38]

        tdf#145317 sw ms export: handle First Page with a first header
        
        partial revert of LO 5.2.4's tdf#101814.
        
        Just because the page style has a first doesn't mean that it
        should not check if it is also a first-follow that could be
        merged into a single ww8section.
        
        In this case, the follow page-style's H/F definitions were
        lost, because only the First Page style was considered.
        
        No existing unit tests matched these conditions.
        
        I did test bug 101814's CAFCA - Modèle feuille A4 - v2015-2.odt
        and it still shows the same H/F.
        
        Change-Id: I7389f8d85ba24a3f9c6487efe4acd27d96b0869c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124213
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-02  Steve Fanning  <stevemfanning@yahoo.co.uk>  [04d43efa04f06ed5679ed0ced584c1c008784150]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5f532332487c5c57eecb949d0d83fdf2c5f4e7ac
          - Update help to explain that CONVERT_OOO
            
            Change-Id: I6f981b70f98c95cef510a60f4791336446db8648
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124193
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ac33c213216d3c62360050fb7495a741aa8c90d6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95f006af3ffbe256ebf095db8be2ebd1321e673e
          - Refactor database files
            
            Change-Id: I97f41e7a5268ee307e3e0b051abebb35b917ed73
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124565
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-11-02  homeboy445  <akshitsan13@gmail.com>  [ab32d1c01814d576b0b82c99e1849a8a71b12188]

        tdf#145486: Prevented crash by not updating readOnly value
        
        Change-Id: I88c2b8a9a05335a16154a23a541882a3ca6de3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124555
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-11-02  Mike Kaganski  <mike.kaganski@collabora.com>  [509b2039f72ff35c79bb6ff2f49525b9d1e9226c]

        Use braces to workaround a strange GCC bug
        
        Using gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04):
        
            [CXX] ucb/source/ucp/cmis/certvalidation_handler.cxx
            In file included from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/converter_lexical_streams.hpp:62,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/converter_lexical.hpp:54,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/try_lexical_convert.hpp:44,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast.hpp:32,
                             from /home/user/core.git/external/boost/include/boost/lexical_cast.hpp:30,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/format_date_parser.hpp:14,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/date_generator_parser.hpp:20,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/date_facet.hpp:25,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/gregorian/gregorian_io.hpp:16,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/gregorian/gregorian.hpp:31,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/posix_time/time_formatters.hpp:12,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/posix_time/posix_time.hpp:24,
                             from /home/user/core.git/external/boost/include/boost/date_time/posix_time/posix_time.hpp:30,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time/local_time/local_time.hpp:11,
                             from /home/user/core.git/workdir/UnpackedTarball/boost/boost/date_time.hpp:15,
                             from /home/user/core.git/external/boost/include/boost/date_time.hpp:30,
                             from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/object.hxx:40,
                             from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/document.hxx:39,
                             from /home/user/core.git/workdir/UnpackedTarball/libcmis/inc/libcmis/libcmis.hxx:34,
                             from /home/user/core.git/ucb/source/ucp/cmis/certvalidation_handler.hxx:19,
                             from /home/user/core.git/ucb/source/ucp/cmis/certvalidation_handler.cxx:23:
            /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp: In member function ‘CharT* boost::detail::lcast_put_unsigned<Traits, T, CharT>::main_convert_loop()’:
            /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:149:17: error: this ‘while’ clause does not guard... [-Werror=misleading-indentation]
              149 |             inline CharT* main_convert_loop() BOOST_NOEXCEPT {
                  |                 ^~~~~
            /home/user/core.git/workdir/UnpackedTarball/boost/boost/lexical_cast/detail/lcast_unsigned_converters.hpp:150:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘while’
              150 |                 while (main_convert_iteration());
                  |                 ^~~~~~
        
        It surfaced after commit 00a76942e423589e3fdd4e059be753eab3393344,
        apparently showing some version-specific compiler bug.
        
        Change-Id: I92a989726cea5eafd762f724cfc0b3c1f986824c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124474
        Reviewed-by: Aron Budea <aron.budea@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [f4b353c1f52fc78a102413cac94c7fb24292bec6]

        Related: tdf#145363 provide an explicit parent for page format
        
        when launched from another dialog let it take that as the parent
        
        Change-Id: I07bfe03717cbe140301060e6e85bdbdef953bf5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124560
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [e78a519285a5d2ca5ccc9ae6a5fda81975fa38d7]

        tdf#145363 provide an explicit parent for numbering-style dialog
        
        when launched from another dialog let it take that as the parent
        
        Change-Id: I64247b0b670c3e44176b6323c074cfd0711feefb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124558
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Stephan Bergmann  <sbergman@redhat.com>  [d1ff9c1d650ada0049c867d76ba38890633a444c]

        loplugin:unusedmember: Work around more cases not marking an enum as referenced
        
        ...similar to the "For some reason..." workaround already present in
        VisitElaboratedTypeLoc.  (Thanks to mst for finding this.)
        
        Change-Id: Ic682e8290efa64093d3c4a831dfb4d23091b6056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124559
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [34f5a5a5e482f47476f1a37684d837c1d21d79b0]

        ucb: webdav-curl: remove SerfLockStore::getLockToken()
        
        Looking rather obsolete, plus NonInteractive_LOCK() can just get
        the token as a parameter since it's called only by LockStore.
        
        Change-Id: I4c5c84135592fbab20f36c93d0c99b80fccb0976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124453
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [a6c21346d4374ea9a0c1e4e1b05e443f48cef65b]

        ucb: webdav-curl: fix MOVE/COPY/DELETE crash
        
        These need "nobody"; some errors like 401 will return a body that should
        be ignored.
        
        Change-Id: If2f726aa34d4d3fae1bd61bc87b62e2d55a7ff26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124561
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [d4acfea2fed8f999347e49ed76c3f5115952df5c]

        ucb: webdav-curl: rewrite authentication loop for reentrancy
        
        Surprisingly calling authenticate() can lead to a reentrant call
        via event loop, which fortunately deadlocks with non-recusive mutex,
        or we'd have a much more difficult to debug problem:
        
         5  std::unique_lock<std::mutex>::unique_lock()
         7  http_dav_ucp::CurlProcessor::PropFind()
         8  http_dav_ucp::CurlSession::PROPFIND() (this=0x391fe80, rURIReference="/testL.odt", depth=http_dav_ucp::DAVZERO, o_rResourceInfos=std::__debug::vector of length 0, capacity 0, rEnv=...)
         9  http_dav_ucp::DAVResourceAccess::PROPFIND() (this=0xab3bb00, nDepth=http_dav_ucp::DAVZERO, rResInfo=std::__debug::vector of length 0, capacity 0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578)
         10 http_dav_ucp::Content::getProperties() (this=0xa8ba9a0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578)
         15 SfxBaseModel::isVersionable() (this=0x7159c90)
         19 SfxBindings::Update_Impl(SfxStateCache&)
         24 Timer::Invoke() (this=0x7394708)
         30 g_main_loop_run ()
         35 (anonymous namespace)::executeMasterPasswordDialog()
         40 (anonymous namespace)::UUIInteractionHandler::handle()
         41 PasswordContainer::RequestPasswordFromUser()
         42 PasswordContainer::GetMasterPassword()
         47 PasswordContainer::find()
         48 uui::PasswordContainerHelper::handleAuthenticationRequest()
         57 ucbhelper::InterceptedInteraction::handle()
         58 http_dav_ucp::DAVAuthListener_Impl::authenticate()
         59 http_dav_ucp::CurlProcessor::ProcessRequestImpl()
         60 http_dav_ucp::CurlProcessor::ProcessRequest()
         61 http_dav_ucp::CurlProcessor::PropFind()
         62 http_dav_ucp::CurlSession::PROPFIND() (this=0x391fe80, rURIReference="/testL.odt", depth=http_dav_ucp::DAVZERO, o_rResourceInfos=std::__debug::vector of length 0, capacity 0, rEnv=...)
         63 http_dav_ucp::DAVResourceAccess::PROPFIND() (this=0xab8c060, nDepth=http_dav_ucp::DAVZERO, rResInfo=std::__debug::vector of length 0, capacity 0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578)
         64 http_dav_ucp::Content::getProperties() (this=0xa8ba9a0, xEnv=uno::Reference to (class ucbhelper::CommandEnvironment *) 0x390b578)
         67 ucbhelper::PropertySetInfo::hasPropertyByName() (this=0xa8d7a20, Name="TitleOnServer")
         68 SfxBaseModel::getTitle()
         74 framework::TitleHelper::impl_updateTitle()
         75 framework::TitleHelper::documentEventOccured()
         78 SfxBaseModel::postEvent_Impl() (this=0x7159c90, aName="OnModeChanged", xController=empty uno::Reference)
         79 SfxBaseModel::Notify()
         80 SfxBroadcaster::Broadcast()
         81 SfxObjectShell::SetModalMode_Impl()
         82 SfxViewFrame::SetModalMode(bool)
         83 SfxFrameWindow_Impl::ModalHierarchyHdl()
         86 SalFrame::NotifyModalHierarchy()
         88 SalGtkFilePicker::execute()
         92 ModelData_Impl::OutputFileDialog()
         93 SfxStoringHelper::GUIStoreModel()
        
        Need to move authentication loop to the outer function, so that all the
        option guards in ProcessRequestImpl() are reset/set again, and also
        delay setting the option guards from the various callers so they can be
        reset in ProcessRequest() before authenticate().
        
        Change-Id: Id697b1459f94f80fc58cee7768c2bd388369b29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124452
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [4b7f8f7cf3146317ae2770a766efe48f7a295f72]

        curl: build with zlib on WNT
        
        Change-Id: I53eb6ed41fb8a17a79f72807df15822e9c1c6e88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124290
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [5d845fd02700c43352740cc9e675c91a6876e7d9]

        ucb: webdav-curl: implement CurlSession::abort()
        
        It looks like libcurl has an API to wake up a transfer in another
        thread, but have to use curl_multi_poll() instead of curl_multi_wait()
        to enable that.
        
        Change-Id: I728416eba45eb6665b0041955cdce8bee07e845e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124220
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [eb7fecd8ef3c0507ac6f9f60cc25161d84349e93]

        ucb: webdav-curl: escape broken SharePoint 2016 URIs
        
        [ reimplement commit 069aa870aadb9f9069e8715c8be30394410f0288 ]
        
        Change-Id: I01a93e3a448e6dc921d1e0471ae01c8ac8feea11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124218
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [a1ce00dad942b459dc145d4ac5ab1d02893fff0b]

        ucb: webdav-curl: tdf#82744: fix WebDAV lock/unlock behaviour - part 4
        
        [ reimplement Sharepoint 2013 workaround from commit
          fed2984281a85a5a2f308841ec810f218c75f2ab ]
        
        Change-Id: Ib7f5a66e32d630e900f5f77c882ba791a9ab7aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124217
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [ebe2050da7f04e0e4b3c7d27ec25379604fc86da]

        ucb: webdav-curl: use curl_multi API to support read timeout
        
        This enables passing timeout to the curl_multi_wait() function.
        
        Change-Id: Ic0ab9afe955b3625be0a44304c69882eb896abf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124219
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [791f94a967560fb36cce06e673b115f3ffc707ae]

        ucb: webdav-curl: remove locks from LockStore after AUTH error
        
        [ reimplement commit 94e4695bcfcb9356d37942c47359b94531ef7b95 ]
        
        Change-Id: I15d1a95074dcad3f2c642bb0819741a2b0f734c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124216
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [7cd5647b9d02be7527f78a08d49c742be4c34c34]

        ucb: webdav-curl: convert hrefs in PROPFIND response to URI
        
        curl_url_set(..., CURLUPART_URL, ...) doesn't work with relative URLs
        that are absolute paths.
        
        Change-Id: Ic67c99262fe5b399511f7a2e7b8592d7e065b2c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124451
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [68627126454762ddfb4605c0e58c634b54937ad0]

        ucb: webdav-curl: implement dead properties in PROPFIND/PROPPATCH
        
        And delete a bunch of ghastly code.
        
        Change-Id: I1a01bfda5f86202d537f87b97d83cc5c0a65ed0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124079
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [7110271f6a47dd19648864ad9e83e87a90f2d4fd]

        ucb: webdav-curl: clean up CurlUri m_Path mess
        
        Fix the confused nonsense and add GetRelativeReference() for the cases
        where the path+query+fragment is needed.
        
        Change-Id: I663d20a686dcc787171ae7702d2a64451fa53807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124078
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [cd3daf7f6e7842e96f60a85cb791b18bfcc0d7b3]

        ucb: webdav-curl: convert URI reference to URI as early as possible
        
        Ensure that LockStore uses the full URL as key, not just the path.
        
        Change-Id: I84caf0d22e8c0ba176c19d004ee8ffcd2fdd05c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124077
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [3f2c3acfac2c699820f1a7e66a485ad98d5d92ab]

        ucb: webdav-curl: handle "depth" in WebDAVResponseParser
        
        Also remove a spurious fall-through that probably doesn't matter in
        practice because the "status" element follows the "prop" element that
        contains "activelock" in the schema so at that time maStatus should
        always be empty for a valid response.
        
        Change-Id: If4cc8dbc75391d76ff497b83dd0f7fd00eb34a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124076
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [f529a81a6158de68c0a244640f8ee6434e6e79a6]

        ucb: webdav-curl: Don't crash when accessing WebDAV resource after auth failed
        
        [ replicate part of commit 162a472d55cf9fb9aaa6d5eae625b3da2273a516 ]
        
        Change-Id: Ia48b95d27cc9da8688104a05a758f82415a2d2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123506
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [06985b1024c2272c7bbfb26dd252a3be48e5d3d8]

        ucb: webdav-curl: loplugin:constfields in ucb
        
        [ replicate commit d8f8b4375998b62431c8605004e7c7d5c921ccc9 ]
        
        Change-Id: I720fdfbeab13e9dd210f11a613cb606e946d68e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123505
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [cf64fe2d02dcb7f3126026dc1face21ce3562392]

        ucb: webdav-curl: tdf#106955: Open WebDAV resources on which PROPFIND fails
        
        When PROPFIND fails on a WebDAV resource, its IsDocument property
        stays undefined, and so stream creation fails. Proposed solution
        is to default to IsDocument=true for all WebDAV documents where
        we cannot get the property from server.
        
        Such resources also fail to return their locking options, so
        defaulting to server properties. When later locking is attempted
        on it, the attempt fails with user notification (a dialog saying
        that getting information from server failed). Proposed solution
        is to check Content-Disposition header in such resources, and in
        case it's attachment, disable lock on this resource. The rationale
        for this is that "In a regular HTTP response, the Content-Disposition
        response header is a header indicating if the content is expected
        to be displayed ... as an attachment, that is downloaded and saved
        locally" (see MDN:
        https://developer.mozilla.org/en/docs/Web/HTTP/Headers/Content-Disposition
        
        Also, Content::getProperties wasn't ready for PROPFIND returning
        empty result.
        
        [ port of commit fbc04c97231d629c1b5e9e57203dbe8d8eb06714 ]
        
        Change-Id: If0b4c10ef7b7b108a8779c773c65e25973d32b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123504
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Stephan Bergmann  <sbergman@redhat.com>  [71a016b6db2c409730594d59c565f5ad4e99eb8b]

        ucb: webdav-curl: const-ness fixes
        
        [ port of commit 95cfef300eb1a32d700479d2cefddc3fc4d0b37c ]
        
        Change-Id: Ic57525aa9a56c3d2f7f9cc5f0ca038bbfa8853a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123503
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [62069267024a35e323e8685c3808bf80d64ddb5c]

        ucb: webdav-curl: tdf#102499 (9): Fix eXo Platform WebDAV on 'Save Remote File'
        
        [ port of commit 59d6d5579528a66e55b75987d2d959968db485a8 ]
        
        Change-Id: I32c2bb8c3985ce8d8cf8cd0aeae513815ed40b6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123502
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [3665527ea9f003830eb47ecd221a950c35caf731]

        ucb: webdav-curl: tdf#102499 (8): Return empty property when not present.
        
        [ port of commit bb27b2ff87e534b6f4fb9583271db29d6bbae8b6 ]
        
        Change-Id: I3375aff7e3b82bb41917b1d87432fd48af41a05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123501
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [09e159ba18989f8b5720205f0bdebdb277c5d067]

        ucb: webdav-curl: loplugin:unusedmethods
        
        [ replicate commit 292560a957498bed70b625c992ec6bcf631dceb3 ]
        
        Change-Id: I17a719756423f57a847d5c2f6833ac4d7033f5f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123500
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [2346a19dfeba7f0f2082888ab76c1c731e9e591c]

        ucb: webdav-curl: tdf#102499 (7): Caching connect timeout or cannot connect.
        
        An unofficial HTTP response status code is defined and used
        internally in LibreOffice WebDAV ucp provider in order to
        catch either the DAVException::DAV_HTTP_TIMEOUT state or the
        DAVException::DAV_HTTP_CONNECT state.
        
        [ port of commit 97cc70d7285526ae2ee3b3bac425eb031c4c0321 ]
        
        Change-Id: Idd5d412dd10131199f34a047055d098a0f74cf7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123499
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [805a4e9d3e03e1339e9149fa745ac14fe334ccdf]

        ucb: webdav-curl: tdf#102499 (6): Cache OPTIONS if not present or if lifetime different
        
        Add the OPTIONS information and response status code into the cache:
        - if the OPTIONS information is already cached, update the cache only
          if the lifetime is different;
        - if the OPTIONS information is not cached, cache it.
        
        Add some new functions in DAVOptions to support the change and remove
        a function no longer used.
        
        [ port of commit 1ca68d386bc0345240bf288bec023faaba2e07af ]
        
        Change-Id: I9c06e06ba807eff393052dc706cb45b2dfcef105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123498
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [2afb51076c3f766ab39cbfc66d8469889a2b0a5c]

        ucb: webdav-curl: tdf#102499 (5): Deal with HTTP unofficial response status codes
        
        A reference can be found here:
        <https://en.wikipedia.org/wiki/List_of_HTTP_status_codes>
        (retrieved 2016-09-13).
        
        Changes done:
        Add set of 'HEAD method not available' before using fall back GET method.
        Add new method in OPTIONS cache.
        Add response status code if fall-back GET didn't succeeded.
        Add copy-assignement operator to DAVOptions.
        Fix behaviour of GET fall back when HEAD missing.
        
        [ port of commit 16df731a30917a426df81d751a0bfd0ae5fcdd45 ]
        
        Change-Id: I4dbf4ead49f72617fad0a13f75b8e361d1a8dba7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123497
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [e3c2294c351892ca864f7dd5827dbe04cfcc8021]

        ucb: webdav-curl: tdf#102499 (3): Change caching model for HTTP response status code
        
        Instead of caching only a single status flag, now both the HTTP
        response status code and the message accompanying it are cached.
        
        [ port of commit f423a9d695814b1babf5f2c3f42821190adc7e53 ]
        
        Change-Id: Ia77dc1d7575fc9d5517733687b8d3a1fdf9429dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123496
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [acc8ba867692c4ab426daed5414f1e9fdd90ba4a]

        ucb: webdav-curl: tdf#101094 (36): Fix behaviour of GET in fetching Headers only
        
        Implement a better way to GET only headers, as HEAD method
        substitute.
        
        Wrote a new version of GET, specifically for 'no payload' service
        because sometimes neon was returning an internal error about:
        'Compressed response was truncated' but without a specific error
        state.
        
        [ port of commit f7697a633cd56003fcb1d86bee7eb658020af506
          - omit the actual change in NeonSession because it's not obvious
            if it is needed/was a neon-specific problem ]
        
        Change-Id: Ic6afe37d0e010745091301fd9647fc1b3b9e378d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123495
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [8683c862ba6f7897e5f41294394f5f3bb18fcf16]

        ucb: webdav-curl: tdf#101094 (35): Add OPTIONS as pre-check in direct WebDAV open() method
        
        The function call will act as a precheck on Web resource access
        error when accessing the open directly without the normal file
        open procedure, e.g. accessing Web resource property values first.
        
        An example of this direct open call are the extension fetching and
        the extension update check.
        
        [ port of commit 909b6b84944e17141109272d917dcf4887483e5a ]
        
        Change-Id: Ic04903cfc1b056e150a080fc32428d43e3f842e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123494
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [c7d95240b90001c7e253aa65ed8dc804a2719849]

        ucb: webdav-curl: tdf#101094 (34): Fix test and missing field value in comparision operator
        
        [ port of commit d751af3f84909996d44b9354ce9ed34891d374e1 ]
        
        Change-Id: I2b425741672e09eec3e42eb7af34cac9c20164eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123493
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [b3fc6caf392809d844e84f6a36db6a0fe3111c39]

        ucb: webdav-curl: tdf#102499 (2): Refactor the WebDAV resource access retry
        
        [ port of commit ac060f97cc937787b4079e435c5b312f6894c277 ]
        
        Change-Id: Ib8cb79ddc67a486b067d3187a965ac55ae698fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123492
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [2785402a4b47cb4d5764d0ad9f1554b579a9e5d2]

        ucb: webdav-curl: tdf#102499 (1): Add WebDAV test to check HTTP reponse status  codes retry
        
        [ replicate commit e62c02a089e454eeea472e758e113e7e28568a02 ]
        
        Change-Id: Ie8bd0d0363ae3564f3287e928d36277ca48b17de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123491
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [08bbf853d52a4a36a223ebbe751bffd7000180ca]

        ucb: webdav-curl: loplugin:unusedmethods in sc..vcl
        
        [ replicate commit c4cd079b8f613084a99a83b95c3968b65cbd8900 ]
        
        Change-Id: Ifdd0c5823c02102fc84019912fbb9e8098ecc8db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123490
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [9dc9201c6eee6ffb8d547752dd6193a270fa85fb]

        ucb: webdav-curl: loplugin:unusedfields
        
        [ replicate commit b18e1bc61ccba9d0c74274e2fe45b2b422c601cf ]
        
        Change-Id: I8458dce0ae9e71daebda708697501dd5ead5ae55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123489
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [00fbb60bfecb8ef52b61f1720017106addf6c14d]

        ucb: webdav-curl: tdf#101094 (32): Use a partial GET as a fall-back for HEAD...
        
        ... partial GET means a GET with no data returned, to test for
        resource 'real' availability in case HEAD fails or is disabled.
        At  the same time disable use of HEAD method on the resource
        for the whole access procedure.
        
        This change is needed to manage web servers that don't permit the
        use of either HEAD or OPTIONS methods.
        To accomodate pure web sites that enable only GET to fetch contents.
        
        [ port of commit 2a148e2b5ea11fd371042e836fa95438ffa738e7 ]
        
        Change-Id: Ie0e2b6edd0860cbf704082500b91631543e7da38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123488
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [df2a39fc61ad33d1c5cd81141c4c4f76a493dc9d]

        ucb: webdav-curl: add additional comments from commit...
        
        ... 827cc09948c09d934dd32ca1867252618f761eab - the code was already
        there.
        
        Change-Id: I90b0c617bf060adffd6912529b8fff7897069162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123487
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [6e423be3a811bd44902290b0db48754ef1a59f1b]

        ucb: webdav-curl: tdf#101094 (30): Better explanation of OPTIONS errors in debug build
        
        [ port of commit e137caed30052359783f2b112eee72553be1bd4f ]
        
        Change-Id: I758ce62c8e87407bab783c75fb8c9218dccc3f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123486
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [dad80891bfd5050024c6dd4fbb558d1a5d6fe474]

        ucb: webdav-curl: WebDAV: Make some SAL_WARN log wording a bit better
        
        [ port of commit 4a70eac6045c4d3d5773ad0807dcde5a25391836 ]
        
        Change-Id: Ie0ec0bea4f1f482c2f80899c45c95ee6c0c70795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123485
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [9703240ea9c8932b32f16fd30c059d5e034fe9a0]

        ucb: webdav-curl: tdf#101094 (29) Fix for IIS 10.0 disabled OPTIONS method
        
        When OPTIONS methods (or verb) is disabled (or denied) on a IIS 10.0
        web server, error 404 (e.g. 'Not Found') is emitted, so we need to deal
        with it.
        
        [ port of commit e0d0d87257d62ac61377a73909e17753f96e7aaa ]
        
        Change-Id: I67309f1bce20bba1399a9a3c22568291d095ac69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123484
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [1cb59f9187f6dfd255bb0d47bdb5ca8be09ea47e]

        ucb: webdav-curl: Related: tdf#82677, remove cached element when appropriate
        
        [ port of commit 90ded4cbf1ffbde2ef7926fb225759896ef075bf ]
        
        Change-Id: I7ffe75dc7a85088086f33b22eb1338ea22c1f363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123483
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [e384a009c35542c51e0f991466af40b70a4fdb33]

        ucb: webdav-curl: Related: tdf#82677, add cache use in Content::getProperties()
        
        [ port of commit 00e1f840be4a1ff202d82377b3cbf233b352b1c3 ]
        
        Change-Id: I8c7f372404239276101fb7f64ba3415ef922e7e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123482
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [7541727dfc5938910ce58c73c4dfbcd727dcb7f1]

        ucb: webdav-curl: Related: tdf#82677, implement a PROPFIND 'propname' request cache
        
        PROPFIND 'propname' is the special usage to retrieve all the
        properties available on the URI resource, their names only.
        
        See <https://tools.ietf.org/html/rfc4918#section-9.1> for
        PROPFIND 'propname' definition.
        
        Add cache usage in Content::getProperties as well.
        The caching model is simple: a simple lifetime limit of 10 seconds
        to declare the property name list stale and request another list,
        accessing the Net.
        
        This should reduce the number of PROPFIND calls on the Net.
        
        [ port of commit 98bd24f8b479132ca3f2d884749b738e9e6203e3 ]
        
        Change-Id: I48ae38f706370557698dd80e31840b44e05bfef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123481
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [ee7a590994c3853945fd7fa0c41e4755e741f2b9]

        ucb: webdav-curl: tdf#101094 (26): Fix possible early relase of cache mutex
        
        [ port of commit 6431e91eca9e44684066a32ed3d6411509dac781 ]
        
        Change-Id: I90391c38bf9d0f4acf68ce29b2382ad855aa56ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123480
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [be53d60f85706eeae3a9300e75cae6ed1cd4e642]

        ucb: webdav-curl: tdf#101094 (25): Make a std::less explicit, add/remove TODOs...
        
        ... and a bit of function member signature change.
        
        [ port of commit 5300b55a1dbcbea6ea244e66e3bc91a0218db5c9 ]
        
        Change-Id: Ia9d8f78c2fb39bd0943d4c2fb7d9b11cbee1034a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123479
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [f157d2de9f241ecc56a00f58bb5ea0b8205e53f9]

        ucb: webdav-curl: tdf#101094 (24): Simplify cache removal: DESTROY, PROPPATCH, MOVE
        
        Plus another PUT forgotten on a previuos commit.
        
        [ port of commit 1ed01e1bcc929d363ad5f3c4d2cf262a20134412
          plus move Uris back into try block ]
        
        Change-Id: Ieda94cc855f8a6b648dda404dfad411795c3dc33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123478
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [57777bce551ffe4cf1292e05ec3fe7f8c92adb38]

        ucb: webdav-curl: tdf#101094 (23): Simplify cache removal: MOVE, COPY
        
        [ port of commit 63af1c52c534840d1f55e3041351d24b85edcaa4
          plus move Uris back into try block ]
        
        Change-Id: I8cc7f6e14fcac294531b5be8fdbaf78610a3adfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123477
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [0e9cea7ccdac443a51c81ce6ec3e1115a09b00be]

        ucb: webdav-curl: Related: tdf#99499, add a limit to the number of http redirections
        
        Check for maximum number of redirections according to
        <https://tools.ietf.org/html/rfc7231#section-6.4>.
        
        A practical limit can be 5, due to old RFC:
        <https://tools.ietf.org/html/rfc2068#section-10.3>, this limit is
        reported also in more recent RFCs, see final paragraph of RFC7231, 6.4.
        
        [ port of commit 18009fe8fbe3982141ddca3f1fcd0900a63150a6 ]
        
        Change-Id: I3a6d1510627434cdff9e4f0af8194a8e6a33c28b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123476
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [928fbadb267be88cc558b55ddb33ec151be6e222]

        ucb: webdav-curl: tdf#101094 (22): Simplify cache removal: MKCOL, PUT
        
        [ port of commit 8ff5e67dea29d9ceb100a67a69f6deb4c6f18e13 ]
        
        Change-Id: If24272566bfb5fba32b9df9bd0f8e1c7fe18c585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123475
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [ccbb358db241b8b2564f3d5ac2991ffff5d3deeb]

        ucb: webdav-curl: tdf#101094 (21): Simplify cache removal: LOCK, UNLOCK
        
        [ port of commit 508f78298833f45fd9e2e789aa26cca125719baf ]
        
        Change-Id: I81185c11ed3ad216b13fcbafee45ea3a48cf0a12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123474
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [a10851aca6e14a00b892c78d1cc51476547acf29]

        ucb: webdav-curl: tdf#101094 (20) OPTIONS: Check for Class1 DAV before unlock
        
        [ port of commit d14977d33bc3edb6a2c41db4d685d099bfe8d51e ]
        
        Change-Id: I559d71f49e582af50ef88ea42beba48d38180134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123473
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [944853b03bc5a03ee424354669addb4fa9925fbe]

        ucb: webdav-curl: Related: tdf#96410 eXo Platform WebDAV: where lock fails...
        
        ...because apparently eXo Platform WebDAV does not support or supports
        poorly this section <http://tools.ietf.org/html/rfc4918#section-7.3>
        of RFC4918.
        It returns HTTP error 404 instead.
        
        [ port of commit 4475c191de479e7a5ddb20d14bc3aa32b0ab84d3 ]
        
        Change-Id: I58c91330806abbde5968ed22e98b9ff80c98c505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123472
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [6ac3bf96d5c1676810b31d56f9d6eca7512b9026]

        tdf#145496 Add dropped nLineWidth from refactoring
        
        Regression from commit 4fc1b3fb659be916167518b49ffe8193e9033f30
        ("flatten ImplGetTextLines").
        
        Change-Id: Ib9f086243b4e3ae245263492e714de6f81b89ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124557
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [044bcca725f07058127fb35e9d3bddada364ff84]

        ucb: webdav-curl: tdf#101094 (19) OPTIONS: Add mechanism to manage not found Web URL: GET
        
        [ port of commit 7f32fddb445ef1c1e17f9028f252c21dd83e03af ]
        
        Change-Id: Ie1412f849df0b9da76ccc41309e8e587c8f36c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123471
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [567f8f716bb644494fa74b9a5030c5a047c8a189]

        ucb: webdav-curl: tdf#101094 (18) OPTIONS: Update OPTIONS cache lifetime if not found
        
        [ ported from commit a5fc27e0575eab115de3714ae07fcac7481f4daf ]
        
        Change-Id: I61d06051a4526676fc4ab80d653ab7c2a9e4c209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123470
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [43c1de58c3115dd0495d0326975d520a333845b8]

        ucb: webdav-curl: tdf#101094 (17) OPTIONS: Options cache removal: COPY
        
        [ port of commit bedae6b06c51c641c38fa7dd3e25dd2aaafb30cf ]
        
        Change-Id: I1618a7a5ec4e52fdd9e99b17b2b36e5ef77decae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123469
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [dbe4b01ca7d0069f45d655c04ca595b42b71c631]

        ucb: webdav-curl: tdf#101094 (16) OPTIONS: Options cache removal: MOVE
        
        [ port of commit 2359e5a002f4df58548803320991064e6a6d968c ]
        
        Change-Id: I27a68855198fe220a1f4141bb89673992c12e1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123468
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [8c4302a503053251b6360c128a1dcd556f09c5df]

        ucb: webdav-curl: tdf#101094 (15) OPTIONS: Options cache removal: MKCOL
        
        [ port of commit 1596379bc00a32bc3b4e76a53aa884112b21764b ]
        
        Change-Id: If217fde550ef55375e4743de00dcb325a89674c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123467
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [c155b4137678455294db605e0332b097ef51dc1a]

        ucb: webdav-curl: tdf#101094 (14) OPTIONS: Options cache removal: PUT
        
        [ port of commit e0eb85785b68867f1476553723dbfc6dc407106b ]
        
        Change-Id: I2c4109b44ba291fdc01289b2706f746512d7e3e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123466
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [ae8528e4b7c219411e4fa6f33fc693479bb5ce56]

        ucb: webdav-curl: CurlSession OPTIONS() lock cache
        
        Change-Id: I3a815e70db04439dc33d57ce9e214d52a7f0e08d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123465
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [51579e00fef7baf5e248b1e9a2bf0e9fa8ef1a60]

        ucb: webdav-curl: tdf#101094 (13) OPTIONS: Options cache removal: LOCK, UNLOCK
        
        [ port of commit dfb714183f31d8a235797ef1ad3c517966ed4985 ]
        
        Change-Id: I1cf4689847f4f033d6f8cc40265b98b9614363e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123464
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [1f783d3e5e734dbdef2ec39f1ff1370dad4f332b]

        ucb: webdav-curl: tdf#101094 (12) OPTIONS: Add options cache ctrl in getResourceOptions
        
        [ port of commit 37ada6f457e19b6ee2d2adb0b0ab3acb20705b51 ]
        
        Change-Id: I3cfd71c0c90b828de7d953d5ff3f0e445b3f156f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123463
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [7f5f568b9c31df2391dabd4abb5711a109e5480a]

        ucb: webdav-curl: tdf#101094 (11): Add WebDAV options cache configuration param.
        
        Added in officecfg five new properties to be able to set
        cache lifetime if needed.
        
        The new properties are available in advanced, expert configuration only,
        in org.openoffice.Inet.Settings.
        
        Default values are as follows (value is in seconds):
            OptsCacheLifeImplWeb = 300
                when the web resource is Web only, implementing OPTIONS.
                Min. 0 sec (no caching) max. 3600 sec (1h).
        
            OptsCacheLifeDAV = 60
                when the web resource is WebDAV.
                Min. 0 sec (no caching) max. 3600 sec (1h).
        
            OptsCacheLifeDAVLocked = 600
                when the web resource is WebDAV and it's locked by
        	this LO instance (e.g. lock store has a lock to it).
                Min. 0 sec (no caching) max. 3600 sec (1h).
        
            OptsCacheLifeNotImpl = 3600
                when the web resource does not implement OPTIONS method.
                Min. 0 sec (no caching) max. 43200 sec (12h).
        
            OptsCacheLifeNotFound = 15
                when the requested web resource is not found on server.
                Min. 0 sec (no caching) max. 30 sec.
        
        [ port of commit 2c0b4ff238f39b5fcce09c7d36e80ac1e7cb713e ]
        
        Change-Id: I5a4c44449c91b7d3a8840bfaf8326e35f86415dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123462
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [e329cda88021fe7c540a6050a654aee7491d0975]

        ucb: webdav-curl: tdf#101094 (10) OPTIONS: Add a simple options cache class
        
        Added behavioral unit tests as well.
        
        [ port of commit b641d83bb9f8adba1a487ca0e04d7151f96c3eea ]
        
        Change-Id: Ie8867aeb45dcc8d343b156608e8a30970f76f6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123292
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [78992a2b63cdfbc278a104973c22b1e707ecfd12]

        ucb: webdav-curl: tdf#101094 (9) OPTIONS: Add options check in Content::getProperties
        
        [ port of commit be47f60b51c053c6329637e829ce16e2e90610fe ]
        
        Change-Id: I8fd0dbc1f9847e799c244821bfe4e628c39c2017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123291
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [cb0681be80bd4423475149e05eaff180887936c8]

        ucb: webdav-curl: tdf#101094 (8) OPTIONS: Add options check in Content::resourceTypeForLocks
        
        [ port of commit 6ab2cabeae02b6beb3c33238773ba075f41c4bb9 ]
        
        Change-Id: I10f928fb5484738553769f54353ca7637e0780ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123290
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [8ce2732f0a867807a9d0e70ec0966e7779d13412]

        ucb: webdav-curl: tdf#101094 (7) OPTIONS: Remove resourceTypeForLocks before unlock
        
        Not needed, unlock() checks if a lock is present first.
        If present, it means that LOCK is available, inferring the presence of
        UNLOCK availability.
        
        [ port of commit fd586445a47d50ebfff67a7d5e4a329cf064cb92 ]
        
        Change-Id: I639c558c6e6f322f37d267bbc31309504745e02c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123289
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [9eb6733c8fa9d69d3f2314fc1a3f510c324bd663]

        ucb: webdav-curl: tdf#101094 (6) OPTIONS: Do not retry on HTTP error 501
        
        HTTP error 501 the server tells us the used method is not
        implemented, non need to retry.
        
        [ port of commit 6dcd231892d80d2f130d1b9ebb9cf7dfa1115df1 ]
        
        Change-Id: I5325f6527c7bb5c8f87d4301fd13eb6c71a318f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123288
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [70f197cc6728482b0a42f4b1e90c55879346fdfb]

        ucb: webdav-curl: tdf#101094 (5) OPTIONS: Add options check in Content::getResourceType
        
        Added some verbose SAL_INFO to detail server responses to PROPFIND.
        
        Corrected a wrong comment and beautified a bit code I introduced
        in commit 3b26a2a403ca5e99b0dd07d042d47501c091af16.
        
        [ port of commit 211cb2dec3501a9ea224512ebedbc7cd1c46cd45 ]
        
        Change-Id: I7917408dcc09e42cb23d29b28e02904594023dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123287
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [dac69982586001cb42af900382c544f052820913]

        ucb: webdav-curl: indent that temporarily
        
        Change-Id: I8cd3373b64c29d1f76c19a8f229cda0060cc79cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123286
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [2b0c3c6c83f630f0bde1866b368dced7489a2d2f]

        ucb: webdav-curl: tdf#101094 (4) OPTIONS: Add member function getResourceOptions
        
        [ port of commit 2777b6380c17bad8a966454947b9d991f9592224 ]
        
        Change-Id: I8c54b564a8c92dcd395e104976f7a7071b5264eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123285
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [59ed56fd299a0ef5e67aaba4c704262481355f43]

        ucb: webdav-curl: implement DAVResourceAccess::OPTIONS()
        
        This is just a copy of DAVResourceAccess::PROPFIND() and trivially
        adapting 4 lines to call DAVSession::OPTIONS() with required arguments.
        
        Change-Id: If2ac8e4a465d0f09b7cf02647ac4c8e4860c45b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123284
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [1a7c877f51f3f6325b67d5250253efc36c3d4549]

        ucb: webdav-curl: implement OPTIONS()
        
        Change-Id: I601a161c3e6c4b7e741a79bfd15510bb40b5d81c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123283
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [f472792a3ec03797b55e83d2de759caba3e57f79]

        ucb: webdav-curl: tdf#101094 (1) OPTIONS: New class to store retrieved OPTIONS
        
        This class describes the DAV options useful to LO.
        Added behavioural unit tests as well.
        
        [ port of commit f950b49393ee6539f2a7b3c306aa4fc119f24a84 ]
        
        Change-Id: Idfcd66229a2bbbdf4452da731a5b921527447358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123282
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [59508791aa4f30e1c4f0a61f55e19d839d8a4c30]

        ucb: webdav-curl: loplugin:unusedfields in ucb/
        
        [ replicate commit 00bb8141beee7088625992a046e94c6f8da8da83 ]
        
        Change-Id: I8144eca6b27fda799a8e875b568a3bcf6b974d96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123281
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [e1bb4425e442eacdc1ca3518d62116e739ba7eb0]

        ucb: webdav-curl: In case of Web site access, add Content-Type to HEAD request.
        
        This remove a necessity for another HEAD request when MediaType
        is requested while accessing a Web site, a cleaner implementation of
        d61352f58a7f750d3b0b0a9c2d6498fbb7a6e10d.
        
        This behavior is active only on a standard Web site, when PROPFIND
        failed earlier on the program flow, without retrieving the property
        DAV:getcontenttype.
        
        [ port of commit 9325c18044a8adc852e2d1b42a5a479ab6195da8 ]
        
        Change-Id: Iebdae815d096be8ef45b969d7c4d84acc26694b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123280
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Noel Grandin  <noel@peralex.com>  [14c7381438a4d0f2cd6b660c72f4ff8d03834fba]

        ucb: webdav-curl: loplugin:unuseddefaultparam in ucb
        
        [ port of commit 83911dd753fbfd0328bae2dfa37d19f514d4b2f9 ]
        
        Change-Id: I5a57b7af9cd231e89fc93cc1a5f277cae23a1427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123279
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [09730ea0ccfe63982cdb869d5eaa906982283bf1]

        ucb: webdav-curl: Related tdf#95217: Force HEAD method in Web access if PROPFIND failed
        
        [ port of commit d61352f58a7f750d3b0b0a9c2d6498fbb7a6e10d ]
        
        Change-Id: Id945be7a1f71c830f3ab15c54fbf65a32be71a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123278
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [a50dbf49906f4aab367b2556be99779b2b05866d]

        ucb: webdav-curl: Related tdf#95217: Http header names are case insensitive
        
        [ port of commit e973b342826e54f147251b132c3325d30749e312 ]
        
        Change-Id: I7473625894c023c526a8ffeccd7ec6d67629ff76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123277
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [6c0c0ce22e8b9085ed0993a2445560206b05724e]

        ucb: webdav-curl: Related tdf#90700 Add configuration for web connection timeout.
        
        Currently the connection timeout is governed by operating system
        default.
        
        LO timeouts will be used in place of the TCP socket operating
        system ones, only in operating system where this is currently
        possible.
        
        The timeouts to use can be changed in LO configuration:
        'Tools > Options > Advanced > Expert Configuration'.
        Propriety names are ConnectTimeout and ReadTimeout.
        
        ConnectTimeout contains the timeout (in seconds) used when
        making a connection (max 180 s, min 2 s, default 20 s).
        
        ReadTimeout contains the timeout (in seconds) used when reading
        from a socket (max 180 s, min 20 s, default 60 s).
        
        [ port of commit 14220052ef2b8675ee12aad63b0402f023d9760a
          omitting Session change which isn't directly possible ]
        
        Change-Id: I276851958f587346a36ee5f173b3e4fb88a944b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123276
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [11a457538a300d8df0c5c03d3cb590e94e6d99fa]

        ucb: webdav-curl: tdf#95792: fix saving file the first time on some WebDAV servers.
        
        Some WebDAV servers don't implement section 7.3 of RFC4918:
        <http://tools.ietf.org/html/rfc4918#section-7.3>
        
        This lack of implementation breaks 'Save As...' functionality
        when the target is a WebDAV server, by not locking the URL
        ('reserve the name for use', in RFC4918 parlance).
        
        The server not implementing this usually answers with one of
        '405 Method Not Allowed', '501 Not Implemented' or
        '412 Precondition Failed' http error codes.
        
        The fix should manage this lack of implementation.
        
        [ port of commit 4c82edfb3a9286a0bfef3f006e468e5c331987eb ]
        
        Change-Id: I343368bb91bdffff143aa26d8449b48f3b5300d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123275
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [96b1a6878cbcb05f962abe5c9bb073f4dff6f4dc]

        ucb: webdav-curl: Fix tdf#90700 Notify connect timeout early.
        
        Throws exception to manage timeout early in the first connection
        sequence.
        
        [ port of commit 95958755cbbf8c6026b878703400d5d9ec1e6c98 ]
        
        Change-Id: Ib6d306100ab04a3a21c37108d5c88185acf2524a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123274
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [97a22b7a584ae6f5237e18be3265e1a72705d773]

        ucb: webdav-curl: Add/change some logs in WebDAV ucb.ucp layer.
        
        [ replicate commit dd9c15b36f69bec4d4fc9b0049f7e496e5eb9e9d ]
        
        Change-Id: I9eb87ea7216c83ce1ac63f65dd96ebe6760a50a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123273
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [98c05dd05318e6c8a77801d85c015539d933ffa6]

        ucb: webdav-curl: tdf#83531 Opening WebDAV URL WebDav fails if write is restricted
        
        Happened because LOCK method was not allowed without credentials.
        
        [ port of commit 0326352470aee1a774bb5aa314c4f3625c1372b3 ]
        
        Change-Id: Id94b96856737e50715c2a18427ba22c3776a8da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123272
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [b5d91ff10fda72bc9758e7087f8a1a24d2d27022]

        ucb: webdav-curl: tdf#82744: fix WebDAV lock/unlock behaviour - part 3
        
        Changes done to the code in sfx2, ucbhelper, ucb, unotools in no particular order
        
        - add method helpers to call the ucb lock/unlock
        
        - add lock/unlock 'real' management
        
        - make DateChange property retrieval working for WebDAV as well
        
        - add check for changed content of a WebDAV file, in order to reload
        it correctly when 'Edit Mode' command is activated from GUI
        
        - Unlock WebDAV file while saving only if explicitly enabled
          Needed in order to avoid the small window of file unlocked state that
          opens while saving a file.
          When saving LO actually does as follows:
          - unlock the prevoius version of the file
          - prepares operations to save the modified version
          - lock the new file
          - save the new version
        
        - the lock method is enabled if the DAV resource supports it.
        In case the lock is not supported, for example example DAV with lock
        disabled, the lock method is disabled.
        
        Exception: when the resource is first created and the lock is not
        supported: a lock command is sent anyway, because if the resource is not
        yet present, there is no method to detect the lock/unlock availability
        in this case.
        
        - cppcheck:noExplicitConstructor
        
        [ port of commit b4576f3da4d90139fc5140962d13cb91dab98797
          excluding the obsolete FTP scheme thing ]
        
        Change-Id: I16bb4e2fa9899fd31af7c223390f3fb213330fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123228
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [028a6932a697c3f8087cf6a32ce39bde9b945b39]

        ucb: webdav-curl: Remove redundant comparisons, copy properties unconditionally
        
        [ replicate commit 39bbfa61653ba7c3cca0aed739559914c78edc89 ]
        
        Change-Id: I28730c1fc7f6808bf9657855cf1d65369b695c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123227
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Giuseppe Castagno  <giuseppe.castagno@acca-esse.eu>  [115edb7a91f0c1c9b2aeb343680f47924730d121]

        ucb: webdav-curl: tdf#82744: fix WebDAV lock/unlock behaviour - part 1
        
        There are some areas in ucb outside the issue scope that should later
        be addressed, among them:
        
        - in ucb/webdav make flag m_bTransient working right, currently lock
        option for WebDAV server not supporting it is suboptimal: there are
        not needed lock requests;
        
        - change the method the modified file is checked against the old
        one, using DAV:etag instead of the DateTime;
        
        - some http status code returned by the server don't seem to be
        managed;
        
        - during WebDAV operation some redundant request of properties is
        carried out.
        Probably some clean up to remove these not needed transactions
        is to be done.
        Accessing only those really supported by the referenced href would
        be better.
        
        Changes done to the code in ucb, in no particular order
        
        - remove current WebDAV lock management
        
        - have the lock/unlock working correctly when the webdav resource
        is first created: in the case of creation is the first lock on
        the non existent resource that actually creates it
        
        - fix a problem while fetching WebDAV properties.
        If a single WebDAV non-cached property was requested, it would
         not be fetched from the server without this fix.
        
        - change the lock owner name.
        This should probably be different. Something to be discussed.
        This same string can be read by all the applications accessing the
        lock.
        
        Spec reference is:
        RFC4918 [2007]: '14.17.  owner XML Element'
        link (as of 20150713):
        http://tools.ietf.org/html/rfc4918#section-14.17
        
        - manage WebDAV locked file exception directly while locking.
        The ucb::InteractiveLockingLockedException is thrown directly
        when detected by the lock command, to avoid the user interaction
        activated by the cancelCommandExecution method.
        
        - terminate gracefully if WebDAV lock/unlock is not supported
        
        [ port of commit 26e6d4b05ab444e6a7529ffcac7fbe592fc94833 ]
        
        Change-Id: I0a4c926dc1e32cc620ad6e9acfc9c9c56928fa49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123226
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [24adc72f80e1fe33654be103097271eda623f551]

        ucb: webdav-curl: remove unused LOCK() overload
        
        Removed from neon in commit 9d7727737b067c5228f129737046f718d5965659
        
        Change-Id: I1df14d8e05e50a6a0ce7af4f6079f11be6628903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123225
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <mstahl@redhat.com>  [21a1267b15724fcadb089065f57c5daf0fd6ba26]

        ucb: webdav-curl: NeonLockStore::stopTicker(): really avoid deadlock
        
        Follow up on 68ba2785c55eaa1ea70ce135bdad5322b0e04ed7, which missed the
        sad fact that m_aMutex is locked recursively.
        
        Avoid that by passing a ClearableMutexGuard to stopTicker() and
        unlocking that.  Also lock m_aMutex in the destructor while at it.
        
        [ port of commit 13b60fd80a7adfb0ef81a818917cfec5edfc6edc ]
        
        Change-Id: I65bb4ec98f13d28089c3b2eb3300074944024188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123181
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <mstahl@redhat.com>  [d2e66d2c10b624033520a0c734851b9bed9a902a]

        ucb: webdav-curl: NeonLockStore::stopTicker(): avoid deadlock
        
        Tor reports that NeonLockStore::stopTicker() m_pTickerThread->join()
        can deadlock with TickerThread running NeonLockStore::refreshLocks().
        
        This can be avoided by copying m_pTickerThread to the stack, and
        releasing the m_aMutex before calling join().
        
        [ port of commit 68ba2785c55eaa1ea70ce135bdad5322b0e04ed7 ]
        
        Change-Id: I6d2d993fd5315f27e6559a1e9034e961303fe894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123180
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [ad85d647a3d501f9a3208d082b6bdbc371942053]

        ucb: webdav-curl: adjust some trivialities to match...
        
        ... commit 0c3500115c4fd86284a027fc32be704afcf77061 - turned out there
        wasn't a substantive difference to the existing code after all, except
        for the FTP URL scheme check, which i don't miss.
        
        Change-Id: Ie24988a4117445cf729515958dea88d17627859a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123179
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [44f246d122d2bac3f47d855957c809d7eb5768f1]

        ucb: webdav-curl: use std::unqiue_ptr in ResultList
        
        This reimplements commit 7ff650a6fe405c98d182c6cabbb46217b56bb0c6
        and commit fc90cf2af58dc8d551c39ba37d3a44597aa11e44.
        
        Change-Id: I517ce2a4eeda75c25b7a7f7debee8904b454a144
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123178
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [44c58b178206ba9926b76b7eb47253e0c906ee1c]

        ucb: webdav-curl: fix exception in Content::queryInterface()
        
        This was refactored in webdav-neon by commit
        c2ca6fabd1afc3fc07001721c2069d3c8db7000a but it turns out that here the
        m_xSMgr doesn't exist anyway since commit
        317b5bdadebc5560d38da4c9dd6d68c64a93b9a8 so just use m_xContext.
        
        Change-Id: I5c190d6e562ddd095fd6f8c8400ee4a7b7d5a5a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123177
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [d43d90347261e57b33fa932e8869184337bc0017]

        ucb: webdav-curl: add documentation from "rhbz#678440: Always ...
        
        ... include User-Agent to avoid 403 from picky servers",
        commit 4d0e3127ed2def7212bc05aa860cd06704bb1efe.
        
        Change-Id: Ie20def64b7fd1a4f523db84f42d83037bbf88856
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123176
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Stephan Bergmann  <sbergman@redhat.com>  [394a4947d663f36226d8dfbfdf4e190f373742e3]

        ucb: webdav-curl: Adapted TickerThread to safer-to-use salhelper::Thread
        
        [ port of commit f7afe3b7b07800d130b4d9102f2a94ccac0ebc52
          and c58882fda80b63baac3360001b0fdf251d96e0eb "fix msvc2005 build" ]
        
        Change-Id: I7173a99aaebd01535971d25350d00923c6607c5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123175
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [d80ad1370b65987505fd5aedd3ac17ff8b1ee0ed]

        ucb: webdav-curl: add OpenCommandArg3 "KeepAlive" support
        
        This is based on the following commits, which conflict everywhere,
        except the code in CurlSession.* is new.
        
        commit 09954fc863c8ee900f157cab4458e1dcf51493d3
        Author:     Thorsten Behrens <tbehrens@suse.com>
        AuthorDate: Tue Jan 17 04:59:56 2012 +0100
        
            Fix UpdateCheck clog up server by keeping connection alive
        
            The update check protocol uses the webdav ucp, which uses neon,
            which in turn defaults to keeping the connection alive. this is nice
            for webdav, but disastrous for millions of clients phoning home to
            the same server.
        
            Using neon directly in updatefeed.cxx is not an option, due to the
            thread safety problems around that (see e.g. rhbz#544619) - so we
            had to extend it to accept connection options, and reuse the
            existing webdav provider.
        
        commit 29bd62fdc2792e215999e9dd0ec9a4bf1102201d
        Author:     Thorsten Behrens <tbehrens@suse.com>
        AuthorDate: Tue Jan 17 11:41:14 2012 +0100
        
            Switch flag sequence of OpenCommandArg3 to NamedValue.
        
            Based on feedback for 09954fc863c8ee900f157cab4458e1dcf51493d3,
            using the less-bulky NamedValue type instead of PropertyValue.
        
        Change-Id: I48e07dd4c3f189eb4445ed95a67011131d7b49f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123174
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [244a64ae7461a19383c81bc3fefebb5b40900c18]

        ucb: webdav-curl: callcatcher: remove unused methods
        
        [ replicate commit af6752b88e34df05449a4237d9be0fac509c227c ]
        
        Change-Id: I608798e95297642fe768d7ad66d524f084fa83d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123172
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [e668c2a88f0edb41169a76d9c6203227cd436559]

        ucb: webdav-curl: catch exception by constant reference
        
        [ replicate commit e4ce7225dd987f9b2f250f055d9688de79931444 ]
        
        Change-Id: I9727af7b85a7f4c0a821a41856d72644b306ba29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123173
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [66515820d050b4f56d30856b0e7223fa7e697b58]

        ucb: webdav-curl: fix init of SimpleAuthenticationRequest
        
        The parameter was removed in c158c00489d35af7f5f9278b8ee545678d6a42e5
        so "true" was erroneously passed as bCanUseSystemCredentials.
        
        Change-Id: I98d3b554a787c7200337735d5fde13b7db43a832
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123121
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [33fb5accfa38fa6ae739ed20d807bf1980eb4b59]

        ucb: webdav-curl: handle additional HTTP status codes
        
        Refactor a little to prevent recursive calls of ProcessRequest(),
        to ensure the libcurl options set by the previous call are reset before
        the following call.
        
        Change-Id: Iba2ff695385c554058ac5a743c204224ca09ac57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124059
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [ff2bcefa5266ba2b7c4128fdc25245348dee0bd9]

        ucb: webdav-curl: try to prevent acquiring a lock that we already have
        
        This was done for webdav-neon in commit
        b4576f3da4d90139fc5140962d13cb91dab98797 but without checking that the
        requested lock isn't "stronger" than the one that was already acquired.
        
        This is currently not a problem because there is only one caller of
        LOCK() and it passes a hard-coded ucb::Lock argument, but not sure if
        that would change in the future, so try to check for it.
        
        Change-Id: I7a703197208979c330212288c323877a326dd7de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123229
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [d024b594e556ff9061930389230dba4625bd5405]

        ucb: webdav-curl: implement CurlSession
        
        Change-Id: Ib99ccc517f36db1bf98900a79685d510f2940e5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122269
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [ba2ceafa145880002b43c1807fae48fb66e883c6]

        ucb: webdav-curl: add CurlSession boilerplate
        
        Amazingly it even builds, with warnings.
        
        Change-Id: I1f89a8a7de0c37a8908f530d46e275282cdc33de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122047
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [617fbb5fd39e668453588d1b72bfc92a9c648552]

        ucb: webdav-curl: implement CurlUri, partially based on SerfUri
        
        The curl_url* functions exist since 7.62.0 and CURLOPT_CURLU since
        7.63.0.
        
        Change-Id: I8bc766221636eb3ff0d33ae5a90d00c1bc7ecd7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122046
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [a48ccb4c14664e23fbb2c8c1603c82772e5e476e]

        ucb: copy SerfLockStore class to webdav-curl
        
        Change-Id: If7b12af542a369c0179ff3460f64ece61a63c1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122891
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [dca684d8f87e766c91de2dec0f9ac0d2822f4217]

        ucb: webdav-curl: fix [loplugin:*]
        
        Change-Id: I357f8594a404eb17a0126359bdc5b2b4c6543de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122045
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [3afa1858a8a3d00ab6e03367f8cdf6cef2b511b2]

        ucb: copy upper level code of serf webdav ucp to webdav-curl
        
        Change-Id: Ia621e504d234d0904b40c7cd9aba49849c2ee859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122044
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [b0e0fa1d2aee653586e1803bc30447b066e6cc66]

        configure: add --with-webdav=curl
        
        Change-Id: Id5cbeb9924b8e80b3b88f77fee2efd8457b5c302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122043
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [1a3b3eda6ca1c8e063ba6db9e9f34f999ec92c49]

        comphelper: fix SequenceOutputStreamService::getWrittenBytes()
        
        With com.sun.star.io.Pipe, you must call closeOutput() or reading from
        the other end will block forever.
        
        If you use com.sun.star.io.SequenceOutputStream, you can't read the output
        after calling closeOutput() on it because for no good reason it throws
        a NotConnectedException.
        
        Let's just fix it so that a sequence of closeOutput() then
        getWrittenBytes() returns the finished buffer.
        
        Change-Id: Ia6ce28ec05e00e5f1c703dea8669e0271c0b9c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123057
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Michael Stahl  <michael.stahl@allotropia.de>  [68a3df2f1282f40fa4accaed21a69a84d76be37d]

        curl: patch invalid format string in debug log
        
        This causes:
        soffice.bin: sendf.c:243: Curl_infof: Assertion `!strchr(fmt, '\n')' failed.
        
        Change-Id: I5a78b2225f6769cc49025e1e73ce72cd3d6bec16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122963
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-11-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd3c70cea6d4577d2cd01285c8b5c635a89b7e90]

        Fix typo
        
        Change-Id: Ida6978ed843615504fac7ce0a0a6a08a66f10367
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124320
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [428385fb870eefe5584dd9c59c0df077369759eb]

        Removed duplicated includes
        
        Change-Id: I5414710ceee7a572173eae43c906e91e86b7a01f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124433
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [32ecb028dc7c803750eabaa27ffd1257e3f53eb2]

        multiline calc inputbar not redrawing and adjusting scrollbar on delete of text
        
        backspace is ok, but with delete when a line is deleted the scrolled up
        lines are visually duplicated at the bottom
        
        Change-Id: I22e91aa3c3213876d36c593cae7989e8913bffc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124548
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [2bd6876f0f4596eb4ffad1109ca0c2896f9bda84]

        tdf#138698 remove/ignore 'distributed' if feature is unknown
        
        which it is in dbaccess. Its is a calc feature added at...
        
        commit 755ad6834625488c5d31d4bacc9370eae7ffd8f3
        Date:   Tue Oct 5 11:15:56 2010 -0400
        
            Ported calc-distributed-cell-text-*.diff from ooo-build.
        
        Change-Id: I1e8856e2ab635d270a487f5a68ac5c386f46a080
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124552
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Jean-Pierre Ledure  <jp@ledure.be>  [59372ead7ee158cdc6f2f08e4008c06697e91139]

        ScriptForge - (SF_Calc) new GetRangeAddress() method
        
        The GetRangeAddress() method accepts 2 arguments:
          GetRangeAddress(Range, AddressItem)
        
        - a range as a string, to be understood as the extended definition
          described in the help pages
        
        - the item to be extracted from the given range, either:
            firstrow
            firstcol
            lastrow
            lastcol
            sheet
        
        The returned value is either:
        - a Long
        - a String when sheet is requested
        - an array of all these values when no item is given
        
        The method is available for both Basic and Python user scripts
        
        Change-Id: I6156b176e29cf47207a079d10552443467dd2f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124551
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-11-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ccf6075b39c754c1efbdb5fb141f4fda8b460536]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ddbff6c13a02f9b58d0274c2215adfbdd3020fad
          - Fix typo
            
            Change-Id: I9dc167e31f706ba8769147fcdb6e10c21ae71a31
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124554
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-11-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0c55ea82aadbccb667e436ea9f44f4796991ae01]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 236b3987893c6a9e6c78f2efee411a18d4c85a7e
          - Fix typo
            
            Change-Id: I3694de1a379960fd2c927d0f80e512c42d3fd6d6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124553
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [7624730e3d0197071fe4f904900fecedf8140d67]

        Resolves: tdf#144793 add scrollbar to sql editview
        
        Change-Id: I23126a89c136a134590900c38ccd589fb4ea29a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124546
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [96ba1a40037b75ebe43daccaf4f4d7849cf02fa3]

        drop unused suppression
        
        Change-Id: I7486a3998e998382565ba454d4262584233777fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [65eb101e23a740657f1d2c9c7dc0b7ac6453998b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 94e3719169db094d5efd3a952461bd08a806f0f7
          - Update SF_Calc service help page
            
            This patch documents the properties "Region" and "XSheetCellCursor", as well as the new methods "A1Style", "CreateChart" and "Charts".
            
            Change-Id: Ia3a5be356271ac0bb1d298de31f1d3d270f9382e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124199
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-11-01  Kevin Suo  <suokunlong@126.com>  [3b977328dfbe613d925dc52c22e36b7e15a34ada]

        tdf#138475: also set font size/weight/posture for CJK/CTL languages...
        
        when parsing the default Calc styles.
        
        As an initial matter, orcus currently does not support XML_font_size_asian,
        XML_font_size_complex, XML_font_weight_asian, XML_font_weight_complex etc in:
        https://gitlab.com/orcus/orcus/-/blob/master/src/liborcus/odf_styles_context.cpp#L128
        
        While this need to be improved by Orcus, actually in Calc we provide
        the default font attributes in sc/res/xml/styles.xml and it makes no
        sense to set different font size/weight/posture for each language type.
        As a result we apply the same font attributes of latin to all these
        languages.
        
        Change-Id: I1b105fecce45aa22c6b72e15305e25dc6669d2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124536
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-11-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [b34a8f977cf043153dd56a7f83b25e0b11b7a523]

        Group per-locale functions instead by type
        
        ... and also sort them.
        
        Gets rid of a lot of #ifdef cpp macro lines.
        
        Also unifies the macros as "MACRO( id )" for easier readability.
        
        Additionally drops the "// add here new services !!" comment at
        the end of the transliteration instance list, as items were added
        all other the place in various patches.
        
        Change-Id: I040b3b0952ec2aef2d1d10e7282cfd11afa6b702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124441
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [ed1ac6bb6660b5f84e184ed3571c8b25596e8631]

        add a comment referencing gcc#103022
        
        Change-Id: Iccb7d5dccdd77563244e2262834274a548b369bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124544
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Julien Nabet  <serval2412@yahoo.fr>  [11db4fa6227a721b483d35f939dc2425c09a42c8]

        Provide values for debug in cui
        
        Change-Id: Ifda9ddae8c7ee946f01dfa0b6fc0bba59a9c8a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124538
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [b424e32afe7e9ef72373bc4e0b9c65a9bbddbd70]

        use freeze/thaw around a potentially long sequence of insertions
        
        Change-Id: I151d172d65d4a74b57a64c4b5d904ef18145aede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124543
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [2ed921b0a56961c6937661258b44e1690c5f98d1]

        Resolves: tdf#145391 insertion code assumes unsorted treeview
        
        so assumed row index doesn't match real insertion point
        
        presumably a problem since...
        
        commit e8b3df5b9b0eb0a93c25b6dc2e445ae44a7e3f78
        Date:   Fri Aug 2 14:57:49 2019 +0200
        
            tdf#93476 Sort Macro library list after creating/importing a macro
        
            Only set the widget as sorted in the ctor, it remains sorted
        
        Change-Id: I6cefc43357f3215a49b33ff18befdc679c1749bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124542
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [c8c11b55456df5b418848ac3159b9f370215bc09]

        Add SAL_DEBUG_IF
        
        Change-Id: If2452cd4bad7266e7e07baaea26c58ef26ead5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124509
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [fa9b28c781d4d3e97f7dcf150a0e22e70289c228]

        Qt picker: implement XAsynchronousExecutableDialog
        
        FWIW: most places still call FileDialogHelper::Execute instead of
        StartExecuteModal. I tested with "Insert >> Text from File...".
        
        Change-Id: I303cc89c97c8fc17015ab7831e6a324ef16a6a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124512
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [a2bc467b4c0c0da71a8c213ac61477cd7697cdc0]

        ofz#40404 try smaller documents to avoid timeouts
        
        Change-Id: Iac495993a219507fe2b6d50b11973ad8d078497e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124540
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [9948e9e736d005f1a5a5ad4955e55aefddc8ef54]

        ofz#40575 Integer-overflow
        
        Change-Id: I4b6b6f2ba0c4dd013489b334822e6639f265c6b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124539
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Stephan Bergmann  <sbergman@redhat.com>  [7d936a98cd8f44e3a99f121b610b9040ae2e8381]

        Fix more misuses of NULL across Windows-only code
        
        ...that had inadvertently been missing from
        a5cea74034a8e029bfdf0f2b82ea8800bf5bd206 °Fix misuses of NULL across
        Windows-only code"
        
        Change-Id: I8f60cd6114ceb7c6413fb099778bfb06407bbb24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124431
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d12f25905c3d7e474b603a716669b12143b6c34a]

        Prepare for removal of non-const operator[] from Sequence in xmlsecurity
        
        Change-Id: I7cfcf9f9ea307bd737292e6f4f37a29f453167c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124418
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [f16f35d40948bd4bbe835e0ba3c2f75aa0de23f7]

        Related: tdf#145464 pass an explicit DocFrame for SID_SIGNATURE
        
        Change-Id: I352e0d92720cd002cbe3f25d4fa0c07b69c88cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124535
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Caolán McNamara  <caolanm@redhat.com>  [1e3cc6d8dfe95f9f4c37f583c3de582464159698]

        Resolves: tdf#145464 ensure the SfxViewFrame is activated
        
        before dispatching SID_SIGNATURE, its normally activated on getting
        focus, but its possible to move focus into the button of the infobar
        without the frame getting focus.
        
        Change-Id: Id353e23b595e14614361c0c25976c788940c67eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124534
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-11-01  Luboš Luňák  <l.lunak@collabora.com>  [fef55498e05717c51c3b3a9222fa460d609a9d3d]

        remove unused gb_CObject__command_pattern parameter
        
        Usage removed in bc39f6b0e62b0a54500bf3986f971a43fe8f843d .
        
        Change-Id: Ie2d8782f84ae39360698885d238ec2154a5b0d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124533
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [5e7e62b937721850ff762c063e9e58c58ce2fb80]

        Prepare for removal of non-const operator[] from Sequence in ucb
        
        Change-Id: I16f3de8398323a308e20d04643a11dd9c3ec59f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124404
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [cae7b855a5fd479e6df822f974870f42e91ce068]

        Prepare for removal of non-const operator[] from Sequence in xmlhelp
        
        Change-Id: I58c6fd9abf53a9ce3b16a31e7452bb5cb895e669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124415
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [38979c6abd4bcac13e9674187e73ccf675fbaf55]

        Prepare for removal of non-const operator[] from Sequence in xmlscript
        
        Change-Id: I166e51e13974154dba4749568b1232eecd2fb8cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124417
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [8cb57be792e6991c38cf5d4434569dc118dd0ed4]

        Prepare for removal of non-const operator[] from Sequence in xmloff
        
        Change-Id: I7ea7964f76f0a5db678510ac3533003726dc49fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124416
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [34d0dd41e1e7bb69d6c4f817b39da26bcd33831f]

        Prepare for removal of non-const operator[] from Sequence in writerperfect
        
        Change-Id: Ifaa868e8e68be474c1e8b961b325ce2a7382650e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124414
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [2b9bd1031cc4f627f83b62288a57b27e6cb9bc3e]

        Prepare for removal of non-const operator[] from Sequence in writerfilter
        
        Change-Id: I4002bc1ca227726bf1c36ecdb657175a42c2d9be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124413
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ac31338c19c1d4843ffb66bac41feaad97d6e988]

        Prepare for removal of non-const operator[] from Sequence in winaccessibility
        
        Change-Id: Ib689146520a99bbdaa7020583a4f34603c26ca19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124412
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [951c4ceb2e86c52cb6549afadbe4d3148e1c808c]

        Prepare for removal of non-const operator[] from Sequence in vbahelper
        
        Change-Id: I2450faf4b3e093b2046034e2a5e5657ff5144d98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124410
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [2e29906567cef053e608588830ddfb013cb53682]

        Prepare for removal of non-const operator[] from Sequence in vcl
        
        Change-Id: I65f411affcf0340c054d09426483d57c530edb0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124411
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-11-01  Mike Kaganski  <mike.kaganski@collabora.com>  [1be268f3ec7661be232b8f5dc18546d1410dfd52]

        Prepare for removal of non-const operator[] from Sequence in unotools
        
        Change-Id: I720d1c1e4a8d32e8a7c7ac62ab9cf988bac31d01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124406
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [b8d17d754830ab57099dcdfa72a96bfad404ab1a]

        Prevent many -Wunused-function in i18npool service
        
        ... registration.
        
        Change-Id: Ice406aa6e8817b4281cc3905d2ba2703ce482c18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124440
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [c0c937d1ff2a47c55b597e10c0f0055e5bfda7e0]

        Echo cross-toolset configure options
        
        ... just like autogen.sh does.
        
        Change-Id: I30ee6b4043c138d7c1e8de154b33fbc7528c34dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124439
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [359a17d0215d36a441688ac3261af04f20a03c6c]

        Prepare for removal of non-const operator[] from Sequence in unoxml
        
        Change-Id: Ie7738eb599ac2ae98618e258786b2a0d956cb9dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124408
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [db149ba9801f57c2e737dec893965f880fa04700]

        Prepare for removal of non-const operator[] from Sequence in uui
        
        Change-Id: I3b4ddb7c371c5a01c561e4b45f3c181b5d9e2a11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124409
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [51b75b2eae36272289230bd63b546d527c18df19]

        Prepare for removal of non-const operator[] from Sequence in ucbhelper
        
        Change-Id: I06b04e3eed46aba8aac528b2c394d60e733533a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124405
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [82047d042e9d5d24b334eba63fd7e4c5bbbb022e]

        crashtesting: assert on conversion of fdo67521-1.odg to pdf
        
         #4  0x00007fffcb03c5d9 in std::__replacement_assert(char const*, int, char const*, char const*)
             (__file=0x7fffcb4fbb03 "/usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray", __line=586, __function=0x7fffcb4fbd8c "const _Tp &std::valarray<double>::operator[](std::size_t) const [_Tp = double]", __condition=0x7fffcb4fbb95 "__i < this->size()")
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/x86_64-redhat-linux/bits/c++config.h:2660
         #5  0x00007fffcb3b4b54 in std::valarray<double>::operator[](unsigned long) const (this=0x7ffffffefea8, __i=0)
             at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:586
         #6  0x00007fffcb3b4a79 in std::begin<double>(std::valarray<double> const&) (__va=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/11/../../../../include/c++/11/valarray:1225
         #7  0x00007fffcb3b49ac in comphelper::containerToSequence<double, std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:192
         #8  0x00007fffcb3b4963 in comphelper::containerToSequence<std::valarray<double> >(std::valarray<double> const&) (i_Container=...) at include/comphelper/sequence.hxx:200
         #9  0x00007fffcb3aaa83 in chart::(anonymous namespace)::lcl_ValarrayToSequence<double>(std::valarray<double> const&) (rValarray=...) at chart2/source/tools/InternalData.cxx:72
        
        where begin() is implemented with return std::__addressof(__va[0]) and
        that operator[] (for arg __i) then has __glibcxx_requires_subscript(__i)
        which asserts if there is no index __i which is the case for 0 when
        the valarray is empty
        
        Change-Id: Idc2c185cbfb3806764c3071ecee302dc823b4660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124529
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [c08d8be8f96a69c5ca3d768789d7c0aa594619c0]

        Support system async file pickers
        
        Query XAsynchronousExecutableDialog and don't depend on the
        "com.sun.star.ui.dialogs.SystemFilePicker" service for the
        decision.
        
        Change-Id: I199ab55a40afaeca7870513829105e47d258420d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124511
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [b00a68a8e19370e106cd76258a3c1825f43613ee]

        tdf#145363 Qt reparent modal dialogs on show
        
        Simply said, one can't have two modal dialogs open at the same
        parent in Qt. All modal windows must open as a stack, each
        parented to the previous one. This is kind of logical.
        
        Unexpectedly Qt totally breaks, if you open two modal dialogs on
        the same window. This happens, because the existing paragraph
        style dialog and the "sub" "list style" dialog are both children
        of their Writer window.
        
        I'm not sure the additionally introduced QWidget-based parent
        handling is strictly needed. It seems Ok.
        
        So for every visibility and modality change, we reparent the
        Qt widget, either on top of the modal stack or restore the
        original LO-based parent. The LO hierachy is never changed!
        
        Change-Id: Id209c9aa67774440089dc50a6648ac293950087a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124500
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [e4abf879f4a24258bcc560eb58ca78b147768d46]

        tdf#145363 Qt popups actually are windows
        
        An other patch in the whole Qt popup handling saga. At this point
        it mainly exists as a prerequisite for the real tdf#145363 fix. I
        just wanted to keep it separate. Maybe it also helps Qt Wayland.
        
        Change-Id: Ib76e9919398bdd5fa7d6239ddb126859f0c0edbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124525
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [eafa99c6c4904bce9bf692eca97562af92cd633e]

        Prepare for removal of non-const operator[] from Sequence in test
        
        Change-Id: I9f2c0deda676b10377b0a4572d26422cb0d8b807
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124399
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Luboš Luňák  <l.lunak@centrum.cz>  [bc39f6b0e62b0a54500bf3986f971a43fe8f843d]

        fix usage of MSVC's -debug:fastlink
        
        Using /link while only compiling does nothing (and MSVC apparently
        doesn't bother to warn). Fix gbuild to pass -debug:fastlink
        when linking, and limit it to dbgutil builds, since pdb files
        cannot be moved elsewhere if the option is used.
        
        Change-Id: I0325c55ddea1ce881b60b1373c81019d154ef672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124526
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-31  homeboy445  <akshitsan13@gmail.com>  [3eeb77ece8db11e6c57864c507af5d24253a6276]

        backendtest: Drawing Open Polygon test
        
        Change-Id: I57af3232ad5e83b649fdfac719dc2359e1bbb412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120171
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [a8bf972230545cd0c0e5dcacb73f5fff804d22de]

        Prepare for removal of non-const operator[] from Sequence in toolkit
        
        Change-Id: I10b3f696fdb0bff1781fb22ec560e1c6dfc10b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124401
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [20354bce87305a274c046cca39ffe8f16add2322]

        Prepare for removal of non-const operator[] from Sequence in tools
        
        Change-Id: Ifff56df8da9b0b9e4d4e96d6b09f490807e96f52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124402
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Jean-Pierre Ledure  <jp@ledure.be>  [020967fde86d77c362658e49e256add265806292]

        ScriptForge - (SF_Calc) new ShiftDown, ShiftLeft, ShiftRight, ShiftUp methods
        
        ShiftRight()/ShiftDown() insert empty cells at the left/on the top of
        a given range and move all cells at the right/bottom of the range
        accordingly.
        They are similar to the Insert Cells ... menu commands
        
        ShiftLeft()/ShiftUp() delete cells at the left/top of a given
        range and move all cells at the right/below the range
        accordingly.
        They are similar to the Delete Cells ... menu commands
        
        The insertion/deletion may be done for a whole column/row.
        
        The number of columns/rows to insert/delete may be chosen.
        
        All methods are available in Basic and Python user scripts.
        
        Change-Id: I14555a3966c26054925dd71b0696f3dfc773fc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124530
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-31  Julien Nabet  <serval2412@yahoo.fr>  [9afbe4178e3d32e0e50eb98357dcedc0d0c11558]

        Fix OSL_ENSURE in ucbhelper
        
        Following:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=6d200d8e739595bd4c6310bede7d66e3c05fbb85
        loplugin:moveparam in ucbhelper
        
        Change-Id: I90bf228932887f66b7f9d2e61d2d17bfa91d1935
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124531
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [0a53b7be5975b474a6fafd2c6dc8280431551d94]

        Qt de-obfuscate the aWinFlags assignment
        
        The aWinFlags assignement is an obfuscated case statement, so this
        explicitly defaults to Qt::Widget and drops the whole or'ing.
        
        Change-Id: If6ac1817d1e600a174c1308a3bad0af5f3f9c30b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124524
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [2023a5291984438de52a95e5bc560a82d69eaca1]

        crashtesting: failure on conversion of fdo74498-1.doc to pdf
        
        noticable since...
        
        commit 894b4911ffb96ff667fdeb3aec7922316ab7230a
        Date:   Thu Oct 28 09:27:29 2021 +0200
        
            pass DX array around using o3tl::span instead of pointer
        
        but presumably a problem since...
        
        commit 793905906980e77a9853a8dd01fab95b65ca4f02
        Date:   Tue Sep 14 15:28:33 2010 +0200
        
            filled-tab-editeng.diff: Filled tab wasn't filled in shapes
        
            n#564454
        
        here I assume the right fix is to extend the DXArray (if non-empty) to
        match the new length using the value of the initial entry of the old
        DXArray
        
        Change-Id: I36a6040c2d05e108c7c6f9cdab9a33557036cd22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124528
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Jim Raykowski  <raykowj@gmail.com>  [f3d16ef054acd8c98559716e48b4cd84078c6a4c]

        SwNavigator: Improve tracking on showing
        
        Currently, tracking is not updated when the List Box mode is switched
        from Off (content tree hidden) to On (content tree shown) and is not
        immediatly updated for the sidebar version on showing. This patch fixes
        these cases by making tracking update on show.
        
        Change-Id: Ic7c4ba2ddad70e469ecfed97c656fd83b59584d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124499
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [786524fc4bbc914cdeeefa97cc5c3c7b9124c0bb]

        ofz: build failure
        
        Change-Id: I4595bb2345db025b04073538ae680bd74696260e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124527
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Luboš Luňák  <l.lunak@collabora.com>  [b5e701d36ec16776e01597fd250dbde2e73fad3a]

        add o3tl::span ctor from std::vector
        
        Makes code simpler, and std::span can be constructed from std::vector
        too.
        
        Change-Id: Iae26b53c52148c19d9068a63126a7393d098d654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124507
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d4b63c4562ec4c612df675502fd35c7c88bc432d]

        Prepare for removal of non-const operator[] from Sequence in svtools
        
        Change-Id: I614a97e5e2328c787ce19612a88839e234d54382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124396
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [1a5ddf061ef53fb9feda0ee319fa36cadef020da]

        Prepare for removal of non-const operator[] from Sequence in stoc
        
        Change-Id: I2aabd9a1c764ae69a933bdb4df635ebb0c91f0cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124393
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [5b54ba7084d6b575814af26be30cf5af5dfca12c]

        Prepare for removal of non-const operator[] from Sequence in svx
        
        Change-Id: Ib5fda9469f9a1987cf9071c0e228c582cfb3dfa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124397
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [3d469248ada8632a9d86efc80f2ac97dcb617c27]

        Prepare for removal of non-const operator[] from Sequence in sw
        
        Change-Id: Ie9530262e4addec01091cc1147e68be5b5a782f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124398
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [e5876404a3a70754b8a49aa0f405847b3fad96d8]

        uniformly allow focus into GtkToolbar
        
        Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [912bc5d73736a90b108fc4c72eb64ad70845ce30]

        gtk[3 vs 4]: remove can-focus from GtkToolButton
        
        so tab-cycling inside sidebar panel toolbars works as wanted
        
        It needs to be false for gtk3 and true for gtk4, leaving it unspecified
        gets a desired working default.
        
        Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Caolán McNamara  <caolanm@redhat.com>  [b73bf4a5fca4fcfff24b234a7337c7a25d75887d]

        pass an explicit parent to use for any warning dialogs
        
        Change-Id: I7909775b63dfe830e5f0e5b024fa6b47a074736a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124457
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-31  Luboš Luňák  <l.lunak@collabora.com>  [5f909fb33210f98905d5ef37d9176fecf4ba5c29]

        do not mix bitmap read and write access
        
        Change-Id: Ic479c467f2dcb85c5c786e90a0dcaf48b7d39505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124508
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [118aa4b843eff3d48ff877f2e3b63de554c70ea4]

        tools::Long->sal_Int32 in bitmap filters
        
        Change-Id: Ic37f238824e1af11c924d3bccc4933cee364d798
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124505
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Julien Nabet  <serval2412@yahoo.fr>  [4de865e3b0771b864beafa74baced87125e87c25]

        Unused TOOLBOXBUTTON_DEFAULT_LOCATION in fpicker
        
        Change-Id: I6da38e7585a2e607e407e5f829b64fc5498d04d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124506
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [2d43223403aca309a051275159fdde2a084a8e51]

        Prepare for removal of non-const operator[] from Sequence in svl
        
        Change-Id: I6b71a075de5d5ac002dc48cd2bb21ff5bf5dd072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124395
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [c981ac598ab46eb3ab7d244bf07fdcbb691438b2]

        Prepare for removal of non-const operator[] from Sequence in svgio
        
        Change-Id: I2ae44fc1016b062b574b3aa1e25f5b59b18e2fe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124394
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [6f17715a4fb93b1094e037872395ca9732278f43]

        Prepare for removal of non-const operator[] from Sequence in sot
        
        Change-Id: I5d6da6ce158fb29ff37452281d28c297795b4cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124391
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [baf1b02b49e92e71490e22f0ed39beb152d99085]

        Prepare for removal of non-const operator[] from Sequence in starmath
        
        Change-Id: I0ac241a5849a5c7d2726ceb0084612a7a1070b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124392
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [b3fe9d6206a5e25fe18c20314960599db05c53ee]

        tools::Long->sal_Int32 in Bitmap::Dither
        
        Change-Id: I8cc4d6d964946e1f5fce4ae5b0bdc08b98ce8e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124504
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Julien Nabet  <serval2412@yahoo.fr>  [f0e8fa40f2620a1deeb7eff1c14a3256ab24a574]

        Typo: TOOLBOXBUTOON->TOOLBOXBUTTON in fpicker
        
        Change-Id: I7110afbdd554b180c368894b9aa6b3b79a8fb2b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124498
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [364c2838bae8ce7e58c92b348e83e24d03bc6334]

        tools::Long->sal_Int32 in ImplExpand
        
        Change-Id: I9f57bf3b67b71aece6e595e83f70a3dff4ec3d71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124503
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [936d5b409f29e9f986c2fa46e4659ef6cccae02b]

        tools::Long->sal_Int32 in StretchAndConvert
        
        Change-Id: Id8ceb7042cf28e9130986393aff52bc29920b51a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124502
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [c7a4aed8d908fda1465c4b39003e910770c62cae]

        tools::Long->sal_Int32 in OutputDevice::Blend*
        
        Change-Id: I26ad2727dbc258a49e7f370167b80e98438a50e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124494
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Noel Grandin  <noelgrandin@gmail.com>  [d57617b79db35b1005007a16b84f17e699d59022]

        tools::Long->sal_Int32 in Toolbox
        
        Change-Id: I1f337558e6fcd6ea552814611cd6fb8a4f3b2f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [d07c4fe7681d90f20c4c0dafefc3439e8265e734]

        Prepare for removal of non-const operator[] from Sequence in smoketest
        
        Change-Id: Ica192dfb16716b4fb38d59eee0a39c6dd411b6a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124390
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [df16e70378cdc80b3e4c1327704a2781a4c57992]

        Prepare for removal of non-const operator[] from Sequence in slideshow
        
        Change-Id: Ic3d4835a6153ce3451e5ddf7a74310ea2b70da2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124389
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [8b9e502480812f61a1c8d37c465aaf93763fe156]

        Prepare for removal of non-const operator[] from Sequence in sdext
        
        Change-Id: I1992d1ffbbc80efe9749ebd254971a0a92a10019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124386
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-31  Mike Kaganski  <mike.kaganski@collabora.com>  [ce22935a8586eda71fd29d4ff969d9cd7a2ec15b]

        Prepare for removal of non-const operator[] from Sequence in sfx2
        
        Change-Id: I0cdce64983901a6cc3b50dc9873a370ff08b9eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124387
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [c6af59b234e8eb8182dc7f686290524feafd6ed6]

        Prepare for removal of non-const operator[] from Sequence in shell
        
        Change-Id: Ie7792d0aa3f404d9177a1eb6f75569577fc3d6a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124388
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [94f34c57be79187c7108eea845e1303ddc6319e5]

        Prepare for removal of non-const operator[] from Sequence in sd
        
        Change-Id: I82dc012188f846161beeb54901c2f5d298e5c3b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124385
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Caolán McNamara  <caolanm@redhat.com>  [2afbef0037f022a59ed1198f1f84e454d070df92]

        Related: tdf#145377 call select handler if restoring previously selected script
        
        Change-Id: Ibab3e920e6830c86bb6bfba070f14ca8a153c25f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124429
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [b9f098c5a2223417af89d69fd8c0548570fd3a9d]

        Another tools::Long->sal_Int32 in the DX array
        
        A leftover from commit bc413e15fae3672f580894a3cd7b077d533d8e6c
        
        Change-Id: Ibacdf71f608657a4488c84b88ef54fb52d3e8439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124496
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [22ba855d1a2317361c6ad8b631ae1bd707887435]

        Prepare for removal of non-const operator[] from Sequence in scripting
        
        Change-Id: Ia85fe6de38674c7982b0f983a798a4d99ec1fb70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124384
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [f528fff9b58e95ed572b226c0fec29f9a0464725]

        Prepare for removal of non-const operator[] from Sequence in sc
        
        Change-Id: Ic49c0fda3e98aeda471e674b68d40464ddac1ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124382
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [9a668129259eeba1a05745b7cd820fccf3043f45]

        Prepare for removal of non-const operator[] from Sequence in opencl
        
        Change-Id: Id58484eb9b955948a8edb48000b86cec3b721060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124377
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [881ea76399a76599e17688f335f4f164d4d29413]

        Prepare for removal of non-const operator[] from Sequence in sccomp
        
        Change-Id: Ic55d553c85dd0abb92b6b7f223a437c8c2ca0700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124383
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [83f50dee5b4add87cf30903aeb0e44e0d4f04682]

        Prepare for removal of non-const operator[] from Sequence in sax
        
        Change-Id: I9df7229f55347bd4477626595cab459065cc4bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124381
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [c5196e281f51b2894aa903469ba8c15a6723eb4c]

        Prepare for removal of non-const operator[] from Sequence in reportdesign
        
        Change-Id: I7631aeb90bf224ba7a00025df6e3fa444b216a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124380
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [7ddf23d19439b9aa569ae35bbac41079203b9f84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 081aa4f6de2c2f6388267883e68966b9da02981f
          - BASIC syntax error
            
            Change-Id: I6ed5bb2541ce6ad6e2bc4f877a093ea5f9cb7aa5
            
          - Since Windows 8, “Run” isn’t a clickable Start option
            
            Change-Id: I1e02547fbe6042e47c028062ea43375cb3ebd0a4
            
2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [d0a8d4a973b5ae395b6fa925e27c7a120a324f4a]

        Prepare for removal of non-const operator[] from Sequence in package
        
        Change-Id: Ib5d7fa143c4c5e3b4862ed4b91acf1e2dfc4d8bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124378
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [ce9611d13ff69306f8c44ac53110cc2cb4116e85]

        Prepare for removal of non-const operator[] from Sequence in pyuno
        
        Change-Id: Ifea4a6baa5fd3878e807ffde6b3fd2e2794312f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124379
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [3c1085fcdd8814180507d8ea1aa6e75d4f94f14f]

        Prepare for removal of non-const operator[] from Sequence in oox
        
        Change-Id: Iee1e16c516547e8f23631b33c928ac6637050f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124376
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  homeboy445  <akshitsan13@gmail.com>  [d53340b2253537104abe6f95c8c63cc74487c3ec]

        Switch to a newer version of ZXing library
        
        Change-Id: Ib2b919bb7545f05631aed2e6176a97aeb866ee84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122772
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-10-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [27d96bfaea5f7967a11dc3a7e2bc9d88dd6f5666]

        tdf#145371 - Delete array variable only before ReDim
        
        Otherwise, global array variables don't maintain their state.
        
        Change-Id: I10dafd9e2946630c5476c9858f765d67ef2f6d6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124368
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [8d1ebf5336c8194977d807e43c46b41b0cbcf88d]

        Prepare for removal of non-const operator[] from Sequence in linguistic
        
        Change-Id: I6eda1416ca0421a48bf9811343850aa504019d57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124374
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [6d4a6abab3bc610c8bceb9e7d322565f5614c3c5]

        Prepare for removal of non-const operator[] from Sequence in lingucomponent
        
        Change-Id: Ibce58dc277a703881de91bebdfd8b328c820a28e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124373
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Noel Grandin  <noelgrandin@gmail.com>  [91399f5d9d9990d2e249155f4810cdaa5051e72b]

        tools::Long->sal_Int32 in GetCaretPositions
        
        Change-Id: Id3f037e132a4d07cb2b68dbb93dd24f7f6b33ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [471f5ab323c5676ca22358ca67f4e6820b7e071c]

        Prepare for removal of non-const operator[] from Sequence in desktop
        
        Change-Id: I76959f62d46e12d984fe4c7be74e5857399e9126
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124358
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [7ba7c1128f469ee5631f3221f6c468ed24c04b98]

        Prepare for removal of non-const operator[] from Sequence in lotuswordpro
        
        Change-Id: Id71f7a16d5ba0b47676d11136ef327205c370aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124375
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Noel Grandin  <noelgrandin@gmail.com>  [bc413e15fae3672f580894a3cd7b077d533d8e6c]

        tools::Long->sal_Int32 in the DX arrays
        
        Change-Id: I36ddc11b39763dc77086591fe9bb756195b4294f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-30  Eike Rathke  <erack@redhat.com>  [70db0942c3f63bed8c2ff517e80c06cef9b52267]

        Add comments for defaults of bEvaluateFormulas
        
        The default is "true" if not present at all for compatibility of
        older filter options strings. The default is "false" if present.
        
        Change-Id: I79383e6fcf211fc8b8f933ae93f6d53ec084d551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124454
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [fbb4c0955d8c346c385e2ad72b061572475cb1fc]

        Prepare for removal of non-const operator[] from Sequence in hwpfilter
        
        Change-Id: I43690203f91cc9bc575470de58c7d1198d2ee7c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124371
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Caolán McNamara  <caolanm@redhat.com>  [1635f94ad500bc323c04738d62a7af0e64034221]

        add SfxUnoFrameItem arg to indicate what frame sent this SfxRequest
        
        Change-Id: I35b581e1ab66a5fbd9bd9c1034a5c8f22c0294e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124442
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-30  Caolán McNamara  <caolanm@redhat.com>  [d33703e26a926507637733612ef169b3f3e05002]

        Resolves: tdf#145377 don't use dismissed dialog as parent for error dialogs
        
        the script dialog is dismissed before the error dialogs get executed
        
        Change-Id: I9e143a7e65077d09f436c4744759c78a9970f1d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-30  Caolán McNamara  <caolanm@redhat.com>  [1295f497e0cc7fc7cfcb66182496a4d29aa701b3]

        upgrade libjpeg-turbo to 2.1.1
        
        simd enabled for x86_64 and x86, arm/aarch64 might be worth exploring
        too
        
        Change-Id: Ic2726ee8c6b6e59ca983b977ee2731f5b78b97d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [45de43ce9f1441735817fa82924ddc4508d221cd]

        Prepare for removal of non-const operator[] from Sequence in i18npool
        
        Change-Id: Ib4c59c45098376f2e0a610a8ffefb4af5306bd6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124372
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [b3bf75786f6cfd3feae735ae705e87f48d8059ed]

        Prepare for removal of non-const operator[] from Sequence in fpicker
        
        Change-Id: I918b785082b89833839fc0a7eeb7cb36a91f897a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124369
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [f662ba95361ba6b8eb49e0acd98bf28bc5f21100]

        Prepare for removal of non-const operator[] from Sequence in framework
        
        Change-Id: Ied2683a0b8a1bab1a7594da1e9bdbd3cb753552c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124370
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [bddfc920220b712c08eda96ac320a274e4bfcee6]

        Prepare for removal of non-const operator[] from Sequence in forms
        
        Change-Id: I2b7bd7935d7e620b9f283ec7c0548beeb97c140d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124366
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [3797007c2fe143dc3c83c72eeb5cc6d1cb401792]

        sw: uitest: test "save to ODT as read-only with password protection"
        
        Similar to the UItest added in 1b53c1dfc76f08ca7df40a0673aa50eca700d072
        < tdf#144374 DOCX: export the password for editing > for the DOCX format
        
        Change-Id: Ifceab6bfb683a42db28e1836b173a850a342515a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124444
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [8565e4ef18e96b9a68a4b75d551a80ce52128bd5]

        Prepare for removal of non-const operator[] from Sequence in formula
        
        Change-Id: I9baa0ac24865d54503c21545109163bde11eac47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124367
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [7233e65db1a78f4764a05d4eb53c1df9e9bc9da6]

        Prepare for removal of non-const operator[] from Sequence in filter
        
        Change-Id: I3296bf6dbacfc47a7e51afe88082c4801ea28ea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124365
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [9265b53978e1ed5a61db9941b5661b88d0efd31b]

        Prepare for removal of non-const operator[] from Sequence in extensions
        
        Change-Id: Id57b187aaa669d4b9a35ab726a6df1a9b4823f1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124364
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [04a2e941cf976894bb69e4d2e1d946a5e513225b]

        Prepare for removal of non-const operator[] from Sequence in eventattacher
        
        Change-Id: I017a20ac21ebd832698bce14cc7f26c0c1c16ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124363
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [00a76942e423589e3fdd4e059be753eab3393344]

        Optimize comphelper::arrayToSequence for same types case
        
        Change-Id: I4949a997f4496e20845a83825fab652089500bad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124202
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c747ccf6cbfe0dc5d591f8ce68a1ca6c63cde53]

        tdf#145361 fix XSLT for older libxslt
        
        regression from
            commit 3eb870f0843a00042ca7dd89837fbe0cc6f918c2
            Author: Noel <noel.grandin@collabora.co.uk>
            Date:   Fri Feb 26 12:45:19 2021 +0200
            fix xhtml list export in other locales
        where I used 'replace' which is not available on older libxslt, so
        switch to 'translate' which works just as well here, and is available
        
        Change-Id: Idd1224e23c0d48956d94b6fc2c2a7b1afa05fa0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [e3d1fb97fcdff75424d4a116f29e8550f94f8a42]

        Prepare for removal of non-const operator[] from Sequence in embeddedobj
        
        Change-Id: I19432a1e506526fdc1cd98625d9cfff12ea2f973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124361
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [5823c27d7fbce3e65ff8684f0a5f21d14a97ab77]

        Prepare for removal of non-const operator[] from Sequence in editeng
        
        Change-Id: Ibdf2db715cb85481342db2a72f27bea6a5b73b7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124360
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Mike Kaganski  <mike.kaganski@collabora.com>  [52f6aa4bf1047f98ab9884799baa104bca9d2a47]

        Prepare for removal of non-const operator[] from Sequence in embedserv
        
        Change-Id: Iaed5b6db7b31eadcb5f94d444ba183e943141421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124362
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e562859d597e2523159d93d04e205017da092f4]

        sc: uitest: test "save to ODS/XLSX as read-only with password protection"
        
        Similar to the UItest added in 1b53c1dfc76f08ca7df40a0673aa50eca700d072
        < tdf#144374 DOCX: export the password for editing > for the DOCX format
        
        Change-Id: I4e9349044355107bbf015fc821e330dfb8005922
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124443
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [1d09e7da3047579b394897aec4b48d8af444b05b]

        sd: uitest: test "save to ODP as read-only with password protection"
        
        Similar to the UItest added in 1b53c1dfc76f08ca7df40a0673aa50eca700d072
        < tdf#144374 DOCX: export the password for editing > for the DOCX format
        
        Change-Id: I4e6914d5224ba051d68ffebaffcadaa16c8f349b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124445
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-29  Luboš Luňák  <l.lunak@collabora.com>  [5b38b5744af1e896892df708c16b83e1b551d2c7]

        fix comparison when searching cache
        
        This made the cache always fail and re-cache, making CJK text layout
        slower over time. A mistake from ef513fd4b049b214a03fbe6e that
        converted !strcmp() to != instead of ==.
        
        Change-Id: Ib70579cd36d7b1df062e4d067e03f5c65e34b142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124432
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [e357cfdc8cda9878ebbc61645e8557a474871d47]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3445df8b3761cc8dafd0f5a275696ad54dc9bbec
          - Create help page for SF_Chart service
            
            Change-Id: Ie244e4416d2b523dfe460701297f6ecfc81f964d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124195
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d23e106b55794160aa4c45e93b125bd84da1b726]

        bump product version to 7.3.0.0.alpha1+
        
        Change-Id: I0e62ad9397ae3a9558f609afb37f44e56b0a4e9e

2021-10-29  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [47de08e518ba88b01ec7aaad5450778332048a72]

        Update git submodules
        
        * Update translations from branch 'master'
          to 327c876f4c35127cff03b26303acd4831252ce66
          - update translations for 7.3.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I9968e128a11cee0afa01bb87dc619ee180d2209f
            
2021-10-29  Julien Nabet  <serval2412@yahoo.fr>  [9117e1c291f1ed7883ad60d9d33aea1a7def88df]

        Fix macro "AC_HELP_STRING" is obsolete (m4)
        
        Change-Id: I0b19293d72f3428004ffc8fc7874420b0ff95bf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124347
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cf158b801a8d23538e339e3e1b9b571e8f1575d7]

        Fix typo
        
        Change-Id: I06cb364b31274d36a712f43db258a2421995388a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124434
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-29  Tor Lillqvist  <tml@collabora.com>  [9dd38a0b4021aa942196babdd6406691c1638a2a]

        Let's assume this is a bogus warning
        
        Change-Id: I3941d8b1811d34b2b7646b20bc7e91c9034770be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124427
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [80afffed57564e40854c1bb8a539fdc3c22b9684]

        tdf#145274: vcl_pdfexport: Add unittest
        
        Exporting to PDF was the only way I could find to test this issue
        
        Change-Id: Id2af0f98b505c49ad912e74477d7bb5246cf850c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124341
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [19c611f3275de7ffc47e517ad1f3141695fa83fb]

        Prepare for removal of non-const operator[] from Sequence in drawinglayer
        
        Change-Id: I9cea42e100de6bb05a32edbf9611fbd05d91759e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124359
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0e7ea85a0d67dcbdb6da28dcdd6d586358c50901]

        Prepare for removal of non-const operator[] from Sequence in chart2
        
        The bits missing from 5b0ae3b59cd2cccfb72d991657366eb2a69bff49, where
        explicit use of sal_Bool* was needed instead of 'auto', to workaround
        loplugin:implicitboolconversion warnings.
        
        Change-Id: I32ef417d46ceea38fbcebae053e288222179818c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124428
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ce81efa73f93afdf46f9586b7b6cecf36cf6914]

        simplify framework::TitleHelper
        
        Every callsite (bar one) calls setOwner and connectWithUntitledNumbers after construction,
        so just pass them in the constructor.
        And for that lone callsite we can just nullptr as an argument.
        
        Change-Id: If838e068bb59a407225d853a0f67983be400f2f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124426
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-29  Tor Lillqvist  <tml@collabora.com>  [2e2931ba2d5cb85d93391e68296f0b29807a0fc6]

        Split overly long line into multiple logically separate pieces for sanity
        
        Change-Id: Ic23bfba8ff9f403e49bda89e4fffe73cf11fdd70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124424
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-29  Tor Lillqvist  <tml@collabora.com>  [34327fdbc4b1d9070ff39d0a2caddad983b48385]

        Use non-deprecated names for bits and constants
        
        Change-Id: I9004aaef7b2d526ad99b316b78733671a785c847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124328
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-29  homeboy445  <akshitsan13@gmail.com>  [d37a44a9ebdafec1435f98194417a1d8cc8208b5]

        tdf#141193 Added support for bar codes in qrcode dialog box[API Change].
        
        Change-Id: I6b79ece1d5419ef92b76755d3bd921a64d6e38fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113989
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [31315fea28ad327f36c0e593156bf808c7af3467]

        tdf#143392 fix title on Base window
        
        regression from
            commit 857caa5fc69b92e781457a1b67a89aa051c2d70f
            tdf#79049 speed up OOXML workbook load
        
        Change-Id: Ia2d55386a7508dc2bbb2fa8501b45c3f30ad6a75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-29  Stephan Bergmann  <sbergman@redhat.com>  [70009098fd70df021048c540d1796c928554b494]

        tdf#128969: Let the user explicitly decide to execute an external program
        
        ...bringing up a warning dialog now in cases where it would have before only
        brought up a failure message
        
        Change-Id: I850badf5927517f16f965950df699979887dbdc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124422
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-29  Stephan Bergmann  <sbergman@redhat.com>  [a5cea74034a8e029bfdf0f2b82ea8800bf5bd206]

        Fix misuses of NULL across Windows-only code
        
        ...which defines NULL as a plain 0 integer literal instead of the GNU __null
        extension, so clang-cl's -Wnull-conversion cannot kick in.  These findings are
        from an experimental build done with clang-cl and a modified
        
        > --- a/clang/lib/Headers/stddef.h
        > +++ b/clang/lib/Headers/stddef.h
        > @@ -83,6 +83,10 @@ typedef __WCHAR_TYPE__ wchar_t;
        >  #  if !defined(__MINGW32__) && !defined(_MSC_VER)
        >  #    define NULL __null
        >  #  else
        > -#    define NULL 0
        > +#    if __cplusplus >= 201103L
        > +#      define NULL nullptr
        > +#    else
        > +#      define NULL 0
        > +#    endif
        >  #  endif
        >  #else
        >  #  define NULL ((void*)0)
        
        However, that build also ran into lots of places where 3rd-party code in
        external/ and Windows system headers caused issues when NULL is nullptr (which
        I worked around with various hacky patches for that build), so this is
        unfortunately not something that can easily be enabled generally.
        
        Change-Id: I10674464498a9bc63578d9e6cc32ddde23ab4f30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124419
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-29  Stephan Bergmann  <sbergman@redhat.com>  [2f39a7b8f90a65d0be9894a0edcf01c161289459]

        external/nss: More -Werror,-Wunknown-pragmas with clang-cl
        
        > In file included from C:/lo-clang/core/xmlsecurity/source/xmlsec/nss/ciphercontext.cxx:28:
        > In file included from C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss\pk11pub.h:12:
        > In file included from C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss/pk11hpke.h:8:
        > C:/lo-clang/core/workdir/UnpackedTarball/nss/dist/public/nss/blapit.h(66,9): error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
        > #pragma deprecated(DSA_SUBPRIME_LEN, DSA_SIGNATURE_LEN, DSA_QBITS)
        >         ^
        
        Change-Id: If84d8640d770ed20a6492678a9bc7fe4f4a547f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124407
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-29  Stephan Bergmann  <sbergman@redhat.com>  [166399c5017c05406ecae4132e817f2b206170d8]

        loplugin:indentation (clang-cl)
        
        Change-Id: If23252e7640a9cfc9dd9feab4416ae832feddaf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124403
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-29  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [3cfd63cb55ab1a7e6df53eaeb2a7623be05983d0]

        tdf#140798, tdf#143815, tdf#141659: fix fly content hint handling
        
        Also revert most of the test changes in
        188ec34cf157ffee8c63f03f420ca9daafb5ff29, except in mailmerge, where
        3bc8f90e9693f710f12632f69b9348c1c833c906 seems to have done some
        research and the old state wasnt particulary well-justified.
        
        In testSmartArtAnchoredInline the order of elements has changed.
        
        This exposes a bug in SwFEShell::Paste, which stops copying
        SpzFrameFormats (aka FlyFrameFormats and DrawFrameFormats) after having
        copied the first FlyFrameFormat, claiming other Flys will have been
        copied via FlyInFly. If there are DrawFrameFormats behind the
        FlyFrameFormats, they will be forgotten.
        
        So instead:
        - first copy the DrawFrameFormats
        - then copy the first FlyFrameFormat
        
        to not forget any Draw Formats. Also, give the format copying its own
        function, at 100 lines its annoying enough all by itself.
        
        Change-Id: I301e27ff94fb82cf0502457630acdcbfa342a566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124162
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [3412c0f091c54da74ea6964062b9be302e126fe9]

        Prepare for removal of non-const operator[] from Sequence in dbaccess
        
        Change-Id: Iddb96d39a512ef68827ecf89f3b5650950f88096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124357
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [4b2ad350213ececdbb1002b3ada87791dc126b20]

        Prepare for removal of non-const operator[] from Sequence in cui
        
        Change-Id: Ib359c029099cf86ccdebefd014d4a9bd91d57eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124356
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [4c71240a8e09f253d6156036485ed78449863f64]

        Prepare for removal of non-const operator[] from Sequence in cppuhelper
        
        Change-Id: I692f1faf0b6ebe26771f3b8c5be1aa548ebd8515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124355
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [a9d314b57b8eb897f977e4c2062f72d85d0a7964]

        Prepare for removal of non-const operator[] from Sequence in cppcanvas
        
        Change-Id: I2a16a8ea7776447592e51a23ce21aac0a156735f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124354
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [894b4911ffb96ff667fdeb3aec7922316ab7230a]

        pass DX array around using o3tl::span instead of pointer
        
        so we get bounds checking in debug mode
        
        Note that I cannot just pass around the std::vectors
        involved because there is a place in editeng which
        calls with a subset of a vector.
        
        Change-Id: I5088a139593c27bf9cbe5d843ab4b0048ac6d508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124330
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [5b0ae3b59cd2cccfb72d991657366eb2a69bff49]

        Prepare for removal of non-const operator[] from Sequence in chart2
        
        Change-Id: I71e0b458c4dd2a85e36a485e3efa72b1077b0e54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124346
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0787aeac2428bf6a2e372ed5f2eac2f079c28ba6]

        Prepare for removal of non-const operator[] from Sequence in configmgr
        
        Change-Id: Ia349292783b81f0b4eebe64ae672ea5cb6d6cd59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124352
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [089dbfda13bbc43ef2bc4b4c6f2cb06163545c2d]

        Prepare for removal of non-const operator[] from Sequence in connectivity
        
        Change-Id: If92f9af5e248f4b066359fe043adf221102e8561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124353
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [5661f257f9edd8bc80bb9dc62855d6bbe88a541f]

        Prepare for removal of non-const operator[] from Sequence in comphelper
        
        Change-Id: Ie4f3675adc888ecf175c5342c87d416f34f8dce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124351
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [da5143365264aaa4634278fe13c36ba6b3039e47]

        Prepare for removal of non-const operator[] from Sequence in codemaker
        
        Change-Id: I058cf9ff4f7ce3f49f1dc3abb6b02268d208b225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124350
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [1a58461bfa3e980f3113a8a16c09cddda0606e7b]

        Prepare for removal of non-const operator[] from Sequence in canvas
        
        Change-Id: Ifb96e496b0994b5fc66975b7aea0a60bcb4a3a03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124345
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [f6aef99057c08490af49aec0fd5f2601a83c4e76]

        Prepare for removal of non-const operator[] from Sequence in binaryurp
        
        Change-Id: Ibbe07a6de488461a99bb06d558cf740caa606bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124344
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Mike Kaganski  <mike.kaganski@collabora.com>  [81a7d46d9f89252146bf3ba4074625bdfe3345f8]

        Prepare for removal of non-const operator[] from Sequence in basic
        
        Change-Id: If048bc301c38ac5ac5412a7d8f69231705088a50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124343
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-29  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [86d11097cd4a2ae4a6b4e6b35e28a6075376d67a]

        use virtual function call for dynamic dispatch
        
        ... as it is around since the dawn of C++ and should be stable --
        certainly more stable and less errorprone that manual typetagging.
        
        Change-Id: I5dfe2ce40c2334dc8fe60705d358779fa4bf1586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124131
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-10-29  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [cae107bab822acc198569750ae5b9a272f7ae996]

        consolidate DDE updates in FieldType
        
        Change-Id: I70243dad4cd62ab1f601d010e0bcf441831ec556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124130
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-10-28  Stephan Bergmann  <sbergman@redhat.com>  [e06ba31a037ea3ff192c9a00db6152179eb298a6]

        Fix passing DYLD_LIBRARY_PATH into lldb on macOS
        
        ...making sure that the shell expands the leading
        
          DYLD_LIBRARY_PATH=${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}...
        
        before it reaches lldb.
        
        (This gets rid of gb_{Cppunit,Pyhton}_{PRE,POST}GDBTRACE again.  No idea why
        c38a4d9ce248b4b3fcc9208b25dfa599fe506ac0 "Make the CPPUNITTRACE="lldb --" thing
        work again (on macOS)" used -s with a temp file rather than -o to pass that env
        var into lldb.)
        
        Change-Id: I9ae5217a9629981c8652fc5aca8f97fa6eb99729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124331
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-28  Caolán McNamara  <caolanm@redhat.com>  [39fbcc330b20f2f4d1c93024734f1b330edd5408]

        gtk4: use a GtkPicture for arbitrary size/ratio toolbar images
        
        so the wide .uno:BackgroundColor Toolbar MenuButton in
        sidebarparagraph.ui is shown correctly
        
        Change-Id: I231145092b5444fa2c70a7b3f0d85ddd6762eac1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124342
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-28  Caolán McNamara  <caolanm@redhat.com>  [4f5b5a19f450ae0b2dcdb99d26f48cf3aea352ad]

        center the content of the underline control
        
        Change-Id: If93af6e031bd108903d9528a43bd7e06fcd8340e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [d13307b93bfc21c7e5996c43e359906c255b0830]

        XAccessibleSelection: Don't reference non-existing methods in doc
        
        There are no 'XAccessibleSelection::deselectSelectedChild'
        and 'XAccessibleSelection::getSelectedChild' methods, so don't
        mention them in the documentation for
        'getSelectedAccessibleChildCount'.
        
        First, there's 'XAccessibleSelection::getSelectedAccessibleChild',
        but not 'XAccessibleSelection::getSelectedChild', so update that
        accordingly.
        
        Second, there's no 'XAccessibleSelection::deselectSelectedChild',
        and 'XAccessibleSelection::deselectAccessibleChild' doesn't take an
        index into the selection, but a child index, s. its documentation
        and the commit message of pending Gerrit change
        Change-Id: I3c63c647e61baaa6288ffd545d8d89d8b94231de
        ("gtk3 a11y: Use correct index when deselecting child")
        on how the semantics of AT-SPI functions with corresponding
        names differ.
        
        (The comment was added in
        
            commit daacf7ed0bc8a1a2447c4b1cb340c97f82918af8
            Date:   Thu Apr 24 16:35:46 2003 +0000
        
                INTEGRATION: CWS uaa02 (1.1.2); FILE ADDED
                2003/04/02 10:06:50 obr 1.1.2.3: #108113# Renamed deselectSelectedAccessibleChild to deselectAccessibleChild
                2003/03/14 10:40:52 af 1.1.2.2: #108113# Removed references to the drafts directory.
                2003/03/11 15:00:39 af 1.1.2.1: #108113# Moved from drafts/com/sun/star/accessibility.
        
        and
        
        > 2003/04/02 10:06:50 obr 1.1.2.3: #108113# Renamed deselectSelectedAccessibleChild to deselectAccessibleChild
        
        sounds like there might temporarily have existed a draft implementation
        that actually took an index into the selection rather than
        a child index.)
        
        Change-Id: Ib8eeadd1ffe8e05b87422e3f9d5c4b3fcc6b696d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124332
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-10-28  Michael Weghorn  <m.weghorn@posteo.de>  [eec233bf33ac0d9ac1ba0ecc669a5ecf58626ef2]

        gtk3 a11y: Use correct index when deselecting child
        
        The AT-SPI selection interface provides two functions
        to unselect:
        
             gboolean atspi_selection_deselect_selected_child (AtspiSelection *obj, gint selected_child_index, GError **error);
             gboolean atspi_selection_deselect_child (AtspiSelection *obj, gint child_index, GError **error);
        
        For the first one, 'atspi_selection_deselect_selected_child',
        "child_index is the index in the selected-children list,
        not the index in the parent container." [1]
        
        For the second one, 'atspi_selection_deselect_child',
        "child_index is the index of the child in the parent container". [2]
        
        ATKSelection, on the other hand, only has
        
            gboolean
            atk_selection_remove_selection (AtkSelection *selection,
                                            gint i);
        
        where the index 'i' is "a gint specifying the index in the selection set.
        (e.g. the ith selection as opposed to the ith child)." [3]
        
        That means, the meaning of the index in
        'atk_selection_remove_selection' is the same as in
        'atspi_selection_deselect_selected_child', while
        'XAccessibleSelection::deselectAccessibleChild' expects
        an index in the parent container, not in the selection
        set.
        
        Therefore, convert the index from an index in the
        selection to a child index first before passing
        it into 'XAccessibleSelection::deselectAccessibleChild'.
        
        (For ATK, the mapping from the two AT-SPI to the
        ATK function is done in libatk-bridge.)
        
        Example to reproduce wrong behaviour without this
        change in place:
        
        1) select cells B1 to E5 in Calc
        2) start Accerciser
        3) select the Calc table in Accerciser
        4) get AT-SPI selection interface for the table by typing the following
           in the IPython Console in Accerciser:
        
            sel = acc.querySelection()
        
        5) check whether child 0 (i.e. cell A1) is selected
        
            In : sel.isChildSelected(0)
            Out: False
        
        -> OK
        
        6) check whether child 1 (i.e. cell B1) is selected:
        
            In : sel.isChildSelected(1)
            Out: True
        
        -> OK
        
        7a) try to unselect cell B1:
            In : sel.deselectChild(1)
            Out: True
        
        -> NOK: selection remains unchanged, cell B1 is still selected
        
        Alternatively, intead of step 7a:
        7b) try to unselect cell C1 (2nd item in the selection):
        
            In : sel.deselectSelectedChild(1)
            Out: True
        
        -> NOK: cell B1 gets unselected instead of C1
        
        [1] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-selected-child
        [2] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-child
        [3] https://gnome.pages.gitlab.gnome.org/atk/AtkSelection.html#atk-selection-remove-selection
        
        Change-Id: I3c63c647e61baaa6288ffd545d8d89d8b94231de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124329
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [eee0b76a8c3dab62d1751db2f29f7f075c65b0c5]

        Prepare for removal of non-const operator[] from Sequence in avmedia
        
        Change-Id: Iefa86987f6ce43610177b7c4122744d37386ad6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124335
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [ada320547db4c7ddbb05d10df4140ea988f29973]

        Prepare for removal of non-const operator[] from Sequence in accessibility
        
        Change-Id: I9454befb46767255451c490eab17e331eb8bb9dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124334
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [dd97bfce9900e6bae40eece36124f8b22e70ff47]

        Prepare for removal of non-const operator[] from Sequence in basctl
        
        Change-Id: Icc6ea4eea08a1cd3fffbfb211f420ab91602e8de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124336
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-28  Mike Kaganski  <mike.kaganski@collabora.com>  [c131f32fcfff1208adc38536839bc5168fcb7487]

        Prepare for removal of non-const operator[] from Sequence in include
        
        Change-Id: I85ca453f3add5ac5b59dc6f1ccb2cdb55f0a463c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124333
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-28  Caolán McNamara  <caolanm@redhat.com>  [a93329244a7d24b8a89d8f287b6123e56d13786d]

        gtk[3 vs 4]: remove can-focus entirely from toolbarpopover.ui
        
        so tab-cycling inside sidebar popovers work as wanted
        
        In gtk3 a can-focus of True means that tab-cycling doesn't work
        correctly as the container is seen as a candidate itself
        
        In gtk4 a can-focus of False means that focus cannot enter any
        child of it.
        
        So it needs to be false for gtk3 and true for gtk4, leaving it
        unspecified gets a desired working default.
        
        Change-Id: I423094657854ed02bc28496dfc9a30efa1e945da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124338
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-28  Stephan Bergmann  <sbergman@redhat.com>  [d9bc3affb57fa0f2d7676f02fb02d7da40365b37]

        -Werror,-Wunused-macros
        
        (when e.g. building natively on macOS ARM64)
        
        Change-Id: Ibff6f913a6251573058c52a8b4106233fad1d443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124322
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [6bbf36ff2dd0d213d5e8a374ff4138767c8d41de]

        Don't auto-enable --enable-online-update for Win/Mac
        
        newcomers will run into the need to specify --with-privacy-policy-url
        and besides that the update server won't know about the build done/will
        be useless without also using your own update-check server.
        
        Change-Id: I77ff61e55ae4a0ca387b79cc2dcfc3f3059ef962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124324
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-10-28  Jean-Pierre Ledure  <jp@ledure.be>  [4f53fc260438591467c2b9dfc13eb76abeac3d9e]

        ScriptForge - (SF_Chart) fix Resize() method must return a Boolean
        
        Change-Id: I8acccd3036c8a08d6fd52b64623f2c9ab3ded5ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124323
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-28  Caolán McNamara  <caolanm@redhat.com>  [bbab833bd956e220db3548ddd0a00dfd30836de1]

        endian check in internal neon looks dubious
        
        Change-Id: Idebe6d07e37a28c005565f1e14826756be4e3a8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124318
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-28  Stephan Bergmann  <sbergman@redhat.com>  [601d0577245e5d85211da96736609a48146c847e]

        Revert broken optimization attempt
        
        This partially reverts 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 "optimise
        find/insert pattern", which caused
        
        > ~/llvm/inst/bin/../include/c++/v1/unordered_map:1134: _LIBCPP_ASSERT '__get_const_db()->__find_c_from_i(&__p) == this' failed. unordered_map::insert(const_iterator, const value_type&) called with an iterator not referring to this unordered_map
        
        during CustomTarget_testtools/uno_test in an experimental build with
        -D_LIBCPP_DEBUG=1 on macOS.
        
        Change-Id: Id40e5eab7c3fb1f8e1bb2599c7fb84649e870ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124319
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-10-28  Stephan Bergmann  <sbergman@redhat.com>  [dfdb04938fbaa756b236f1008a7cef576225404d]

        loplugin:simplifybool (clang-cl)
        
        (not a typo according to the comment at
        <https://gerrit.libreoffice.org/c/core/+/124287/3#message-df56362ec7d674eaab3fe81bb0827be81ee5686d>
        "xmlsecurity: some Distinguished Names are less equal than others":  "i was too
        lazy to look up which integer would be returned by the function and hoped this
        would convert it to bool anyway"
        
        Change-Id: I0f4f4d19e8d382f4430023aa6f9459c66a605b04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124321
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-28  Julien Nabet  <serval2412@yahoo.fr>  [773465fb95c1be48f8fdf406d2d39caa142050db]

        tdf#141301: extrusion-skew angle value -135 is not written to file...
        
        whereas it should since not default value
        
        (Regina) Hopefully in some years missing values are unlikely and
        bug tdf#141127 can be fixed.
        (Regina) I have added a unit test to Julien's patch.
        
        Change-Id: Ia2aabd8e724e3c3db9ae8a87cb27707aa7040fb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113257
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [899434244fb8b632159a82c1f61262a15058708c]

        -flto: only use firstword of PARALLELISM
        
        jenkins agents use PARALLELISM with additional load limit, e.g.
        PARALLELISM="16 -l 24" causing the linker to complain about not finding
        -l24 when lto is enabled. So only use the first element/the number of
        jobs to use and omit the load limit here.
        
        Change-Id: Ie3e2bdbde1b89d9371d1d9b9e426f42a91d2eca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124288
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a340780962ff93b519ff5285ccacc9c52cf17ca]

        sc: split UITest_chart in two
        
        it already has 48 tests
        
        Change-Id: I8ce52b74d29d034531884f32ab965febcd9e266f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124282
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-28  Jean-Pierre Ledure  <jp@ledure.be>  [a97227aeb451fe579546427e125c5d8219eeb952]

        ScriptForge - (SF_Calc) new XSheetCellCursor property
        
        The XSheetCellCursor property requires one mandatory argument,
        a range as a string.
        
        It returns a UNO object of type com.sun.star.sheet.XSheetCellCursor.
        Such an object is designed to navigate thru the spreadsheet.
        
        After the user script has used one or more navigation verbs
        (gotoNext(), ...) the resulting range can be got back in the
        script by using the cursor.AbsoluteName UNO property.
        The new range can be given as input to further ScriptForge
        methods.
        
        XSheetCellCursor is available both from Basic and Python user scripts.
        
        Change-Id: I62fb18a6f496d81b01036aef2ca6733f07632d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124280
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e18b96188a454bcdd2f2780799c136be75606cd]

        sc: split UITest_autofilter in two
        
        it already has 45 tests
        
        Change-Id: If3ec6b77bbb48c4c6042a81e047ae0aca838cfa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124283
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-28  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fd5463343ab7f784070f1ab87a345eed20803d07]

        xmlsec: signing the document fails the 3rd time (invalid signature)
        
        Signing the document 3 or more times produces an invalid signature.
        The cause of this is that xmlsec is confused because we have 3
        signatures, which all have the same SignedProperties with the ID
        "idSignedProperties", but it expect them to be unique.
        
        This issue is fixed by making the ID unique with adding the ID of
        the Signature to the SignedProperties ID, so this makes them unique
        inside the same Signature.
        
        Also UnsignedProperties have a unique ID usign the same approach,
        but they aren't referenced - luckily.
        
        Change-Id: I53c7249a82fc0623586548db9fa25bdc0e7c4101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124278
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-28  Luboš Luňák  <l.lunak@collabora.com>  [44f5a921e5293b92ce9b6822a7fbed5d59715b7c]

        move a comment to the proper place
        
        Change-Id: I8d8b921febd0b57213bbb912a600e0c7698da555

2021-10-27  Jim Raykowski  <raykowj@gmail.com>  [fc71991510df6ac6d9de278689f2def1a5af775e]

        tdf#131755 SwNavigator: Fix drag mode configuration restore
        
        Seems extraction from the Any here needs to be to a long even though
        an unsigned short is inserted.
        
        Change-Id: I3439d4282c99d2b83d4e9e146e241db0dd41a452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124258
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-27  Jim Raykowski  <raykowj@gmail.com>  [0349c9df44896fea2c41588243a151bf594ea0e5]

        SwNavigator: Use stored outline levels shown value for both flavors
        
        Currently only the floating Navigator uses the outline levels value
        stored in the Navigator configuration. This patch makes the sidebar
        version also use the stored outline levels value.
        
        Change-Id: I6f54f92b7375e0688b29aa128008a3bd758a785a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124251
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [803ec436b13576e3f2818bb4ef6559e8f24b3d0c]

        ofz#40404 try smaller documents to avoid timeouts
        
        Change-Id: I7ac320fe062bc076cfd0e3d1b37e32154db79ad5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124302
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [aa7e489533a82135272576e06492631d8a9e3c66]

        tdf#145296 better fix to launch dialog when active radiobutton is clicked
        
        this basically reverts
        
        commit 312a32f6b6c83c5747b617249d794fc87ffd8b9b
            tdf#145296 use a 'clickable' widget for custom spacing
        commit 592235d64d6f9638a61865712ca385ec58d688c4
            tdf#145296 use a 'clickable' widget for custom depth
        
        and uses a mouse-release workaround to detect the case of clicking on an
        already active radiobutton which gives a result basically
        indistinguishable from the pre 7.2 experience
        
        Change-Id: Ic7ac6fa20843466b1d0c77586e25f4aabf814328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124285
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Michael Stahl  <michael.stahl@allotropia.de>  [e63611fabd38c757809b510fbb71c077880b1081]

        xmlsecurity: some Distinguished Names are less equal than others
        
        It turns out that the 2 backends NSS and MS CryptoAPI generate different
        string representations of the same Distinguished Name in at least one
        corner case, when a value contains a quote " U+0022.
        
        The CryptoAPI function to generate the strings is:
        CertNameToStr(..., CERT_X500_NAME_STR | CERT_NAME_STR_REVERSE_FLAG, ...)
        
        This is documented on MSDN:
        https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-certnametostra#CERT_X500_NAME_STR
        
        NSS appears to implement RFC 1485, at least that's what the internal
        function is named after, or perhaps one of its several successor RFCs
        (not clear currently if there's a relevant difference).
        
        This is now causing trouble if a certificate with such a DN is used in a
        signature, created on WNT but then verified on another platform, because
        commit 5af5ea893bcb8a8eb472ac11133da10e5a604e66
        introduced consistency checks that compare the DNs that occur as strings
        in META-INF/documentsignatures.xml:
        
        xmlsecurity/source/helper/xmlsignaturehelper.cxx:672: X509Data cannot be parsed
        
        The reason is that in XSecController::setX509Data() the value read from
        the X509IssuerSerial element (a string generated by CryptoAPI) doesn't
        match the value generated by NSS from the certificate parsed from the
        X509Certificate element, so these are erroneously interpreted as 2
        distinct certificates.
        
        Try to make the EqualDistinguishedNames() more flexible so that it can
        try also a converted variant of the DN.
        
        (libxmlsec's NSS backend also complains that it cannot parse the DN:
         x509vfy.c:607: xmlSecNssX509NameRead() '' '' 12 'invalid data for 'char': actual=34 and expected comma ',''
         but it manages to validate the signature despite this.)
        
        Change-Id: I4f72900738d1f5313146bbda7320a8f44319ebc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124287
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-27  Luboš Luňák  <l.lunak@collabora.com>  [ed43620c007e7fa8eb3a4ea49a90d2171b8de594]

        CPU-specific files should not include templates or inlines
        
        Otherwise the possible copy emitted compiled with CPU-specific
        instructions might be chosen as the copy to keep and would be
        used by generic code. See history for the Calc Kahan code.
        
        Change-Id: Ifc1bbd8d9720d9effe05b8ff8ee5e804363939df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124257
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [7ba33498303b5c9761d14feb03074d8392e15b2e]

        ofz: Timeout, clamp hyperlink range when fuzzing
        
        Change-Id: I604a20c8f239bdec00317e3e9e2a7476f5a3ee83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124281
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [fea331bd4ed15288a80c09338a5ca481f9656235]

        sw: run uiwriter tests on macOS too
        
        meanwhile, fix the following warning:
        - sw/qa/extras/uiwriter/uiwriter2.cxx:3744:22:
        error: unused variable 'pTextDoc' [-Werror,-Wunused-variable]
        Change-Id: I81befe70f48b49f92ea787ab59098525b4cc4471
        
        Change-Id: Ic6ac9b6eaa0ae7a351320540522093ad1dfcba94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124279
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [3c0d04344321db2f7dc1db13ea72590884704f9f]

        make fat valueset selection rectangles solid
        
        as used in writer's bullets and numbering valuesets
        
        Change-Id: I4ac028fa9ef71163f29024352bb4fb7aeef0865a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [e9393a27646d5d43317cbdae9785e9e0319b4cc8]

        draw valuesets with a visual difference between selected and mouse hover
        
        similar to the select a template dialog in impress use:
        * ActiveColor for selected + hover
        * HighlightColor for selected or hover, with some transparency
          for hover
        
        Change-Id: I0b6dd9ff36a51e9ce3d8bc6deac3f35794a7d429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124262
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [3529f28c679b117bf914e56a95a6e4d16cfbae4e]

        ignoring transparency for border doesn't seem to make sense
        
        If we are filling *and* drawing border then we do the border
        transparently, but if we're not filling we draw the border
        without transparency? I can't see that this is intentional.
        
        Change-Id: Idf8d84bed7f93b1fc4ee05ea56bc10c5e5c6e875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124261
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Stephan Bergmann  <sbergman@redhat.com>  [323a2a249a6c87ffde52a1e826d5d12be649e018]

        Add support for macOS SDK 12.0
        
        ...and for now just silence all the new deprecation warnings
        
        Change-Id: Ic6e04f4bade91a823872cd4e453c41ee1950bd77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124275
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [13b2d160ec41ecce118e419d3bcab8004d4d858d]

        sd: split CppunitTest_sd_import_tests in two
        
        it already has 118 tests and growing
        
        Change-Id: Ie1d657b2db245e11b147e0b7c9f83302fd3ef6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124274
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [7b6bba393066f0fe57928b74f829090a0f2326d3]

        sd_import: use a template for makefiles
        
        Change-Id: I52dcd19b6e5806cc1c0abe6ef3c78e1dce82dd68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124271
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [d0687e198342a09b944a06c5d9c707f43041bf78]

        if the mouse move is a leave event ignore the crossing position
        
        and just consider it as "mouse out of window"
        
        Change-Id: I1910804a94608952de6f646560a3104d62b5a67b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124265
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Luboš Luňák  <l.lunak@collabora.com>  [ef42ce579f0e4e4c436f70615f3adeb9f0f68217]

        fix AVX512 detection
        
        The value wasn't in config_host.mk.in, so it's never been used.
        And also fix Calc Kahan CPU-specific code yet again :( .
        
        Change-Id: Iacfd500e5a662b2b4b96a009d129a012d278a3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124248
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [56b0d05991391d7a885e6928138d5512cbbdfb47]

        remove highlight when mouse tracking is finished
        
        don't just move it to the selected element, remove it
        
        Change-Id: Iea6259d75436169a845e283fb168d4306b5eca73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [d212257f72d277f1da9fc20df0ac45f7f0060eaf]

        don't second guess the theme colors in valuesets
        
        Change-Id: I2215ad1d1d1791e27914e0f1dcec32c6827f4f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124235
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [e210c66015beed1632188764d0680247237b7707]

        dont draw highlighted value with focus, only focus the selected value
        
        Change-Id: I63dc0ffd157d79e998156439f88a87c1ecfbea3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124233
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Caolán McNamara  <caolanm@redhat.com>  [eccd817127d852df98df173513a5c8d91c68e2c8]

        don't second guess the theme colors in valuesets
        
        Change-Id: Ie13242800c9a171a93d266601fed11bf2d62f942
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124209
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-27  Tor Lillqvist  <tml@collabora.com>  [71b227dfa46fbc9fbf9b9f2046705939ab0a02bf]

        Accept macOS SDK 12.0
        
        Change-Id: I3e2b004578394e0199ac425f7b80da47a668f70d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124266
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-27  Tor Lillqvist  <tml@collabora.com>  [05bf76c00209a5a5d64f760ed242eec365bff7c3]

        Remove lines that have been ifdeffed out since 2008
        
        Change-Id: I56e17e876803a11047904187ae2fd40fbae01487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124264
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-27  Tor Lillqvist  <tml@collabora.com>  [fdc2333daa4afc44f33ebba4e06ef79c2eb52437]

        Remove line that has been commented out since 2008
        
        Change-Id: I4dc8b6c4e324a0b2ec2d3dba25cc322e0fbefa6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124263
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-27  Jean-Pierre Ledure  <jp@ledure.be>  [f73196867b069b761a2a878dc1df6e78ccedce27]

        ScriptForge - (SF_Calc) new Region() property
        
        The Region() property expects one mandatory argument,
        a range given as a string.
        
        It returns a new range as a string, including the sheet name,
        corresponding with the smallest area
        - containing the input range
        - completely surrounded with empty cells
        
        It is complementary to Offset() and A1Style() to make easy the
        definition of new ranges relative to known ranges
        
        The property is available both in Basic and Python user scripts.
        
        Change-Id: Ifc9ce07b76e72fe580baf2c8103387cab56a6ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124230
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [c4a484b09ff4dca094ad2c56fd9e519f8ff8599a]

        update credits
        
        Change-Id: Iec12f3c4f948d7e9e7991a212860e79f80750417

2021-10-27  Tomoyuki Kubota  <himajin100000@gmail.com>  [17aca0f070bebdd05855c057858ace66f331e988]

        changed description for option --with-visual-studio to indicate VS2022 is now supported
        
        Change-Id: I0f357e0e7eb1e783d2e5868fa5a6852bb0b93833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123509
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-27  Tor Lillqvist  <tml@collabora.com>  [d3c8eadb9358ecdf1eeb6b44c39279366d40231a]

        There is nothing deprecated about these calls as far as I see
        
        Must have been some misunderstanding, or temporary mistake in the 10.9
        SDK?
        
        Change-Id: I19d86c7a0e752676b317423361a18d2b156f0d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124259
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [0d4f6177c76ac2a55b469fd82282ecf4e878c21e]

        tdf#131771: sw: Move UItest to CppUnittest
        
        Change-Id: Ic24218bee76ed9b8df3169bd8e2ede6a91689770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124252
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  Mike Kaganski  <mike.kaganski@collabora.com>  [380b9a819a29a8aa0525632065006f4bd026cf96]

        Move variable declaration to its use in if() condition
        
        Helps understanding the condition more clearly.
        
        Change-Id: Ibb2b60283ea650bfac93621feb0333953cac8fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124188
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-27  Tor Lillqvist  <tml@collabora.com>  [6678b8123c9952c80a637d3a7f4e27511122009e]

        Use non-deprecated names for event types and flag bits
        
        The deprecations were introduced in SDK 10.12 and we
        require at least SDK 10.13 so this should not be
        controversial in any way. (And seriously, I doubt LO
        can be built with such an old SDK anyway.)
        
        Change-Id: I5e2b18b61fa66a6b06f2c751fc9d6ea87b6cbe47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123990
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7d27e4b0257a8a927d3b59edcd549ff9103cbaa9]

        tdf#57308 - Basic IDE: Watching of a variable does not work
        
        Watching a variable which returns a value from a function always shows
        "out of scope" in the watch window of the Basic IDE. In order to resolve
        this issue, the name of the variable being watched will be searched also
        in the current method instance.
        
        Change-Id: I5ff6ce22067e11d74275eeb82da814da1eebe3db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124239
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-27  Luboš Luňák  <l.lunak@collabora.com>  [12c6b1ef6a824b09778163ec83fc44bb196e65db]

        try harder not to mix CPU-specific code with generic code
        
        Jenkins Windows builds occassionally fails with illegal instruction
        (https://ci.libreoffice.org/job/gerrit_windows/110191/console).
        This seems to be because those AVX etc. files use std::abs(double),
        which is really just a fancy inline function calling the real
        fabs() or whatever function. And in debug builds inlines do not
        get inlined, they get emitted as copies. And since arraysumAVX.cxx
        is listed as the first object for Library_sc, apparently the linker
        likes to pick up the AVX-compiled inline function as the std::abs()
        version to use for Library_sc.
        
        Try to avoid this in two ways:
        - move the CPU-specific object files later in the list of library
          files
        - use plain C headers in those sources, no fancy <cmath>
        
        Change-Id: Ifd14076f79e9fbd7cc4c4a63a9764dff6715e63a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124249
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-27  Stephan Bergmann  <sbergman@redhat.com>  [524a0b57ace6cb663df411ab0d8298c5aff6a226]

        Fix names of function parameters referenced in comment
        
        ...after 5d5da77e82b6498dd73123ec0dc36d2315e279a1 "tdf#116305 Add timeout to
        help Windows bring browsers to the front" renamed those parameters, gratuitously
        
        Change-Id: I4d62960458ad747b3de4fd99f9bcab987d19aa9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124173
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-27  Luboš Luňák  <l.lunak@collabora.com>  [453178d33d76248ead90c3547b2f140d8e7bb998]

        remove useless check from SfxViewShell::GetFirst()/GetNext()
        
        This comes from https://bz.apache.org/ooo/show_bug.cgi?id=62084 ,
        but it's unclear to me what the steps to reproduce actually mean.
        If it's print preview, then I can't reproduce, and all tests work
        fine too. This code is called very often from LOK code in a loop,
        and this check makes it O(n^2), so remove it under the assumption
        that the problem no longer exists, only keep an assert just in case.
        
        Change-Id: I0e7ed03ef370aa32f2064c587b242e1ffaff73b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124185
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b7e88d007173e9567299226371a8efda23e7dd9]

        tdf#143244: sw: move UItest to CppUnittest
        
        Change-Id: If1a897270f2fc43cdd5b2a4560bc5d1ce4fdba35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124247
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  Stephan Bergmann  <sbergman@redhat.com>  [11ecb45eb922037082feda3fabd8d0eed3e3ffb0]

        external/breakpad: Silence some UBSan warnings
        
        ...which I happened to run into when the breakpad code kicked in due to some
        crash happening,
        
        > src/client/linux/minidump_writer/minidump_writer.cc:721:12: runtime error: null pointer passed as argument 2, which is declared to never be null
        /usr/include/string.h:44:28: note: nonnull attribute specified here
        
        > src/client/linux/minidump_writer/minidump_writer.cc:763:14: runtime error: applying non-zero offset to non-null pointer 0x000000200000 produced null pointer
        
        > src/client/linux/minidump_writer/minidump_writer.cc:772:64: runtime error: applying non-zero offset 3200848 to null pointer
        
        (Unlike the changes in the existing external/breakpad/ubsan.patch, which is only
        applied when doing sanitizer builds, these changes should be non-controversial
        and OK to apply always, so they go into a different patch file.)
        
        Change-Id: Ib1b3f87ba22f96d5fb93b8fcb9951ddc3c353697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124245
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-27  Julien Nabet  <serval2412@yahoo.fr>  [092f61bd3b1fbffd40988aa7f55f447d3d877cbe]

        Typo: pDataIgoreCase->pDataIgoreCase in sc
        
        Change-Id: I61f90680f907ee567f1af45801be3e939849d4ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124246
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-27  Steve Fanning  <stevemfanning@yahoo.co.uk>  [e1646284ef5a0367c770fa27299db64eedc30cbb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7f8b84bbf7fda91426d01bab26b5fa0d148624a1
          - Update help description of Calc’s TRUNC function.
            
            The help description for Calc’s TRUNC function currently does not indicate that the Count argument is optional. However, the help description for the ROUNDDOWN function does show the Count argument as optional.
            
            Since both user functions are implemented via one C++ function (ScRoundDown()), the optionality status of arguments should be the same for both functions. This was checked by confirming that the formulas =ROUNDDOWN(-45.67) and =TRUNC(-45.67) give the same return value (-45).
            
            This change updates the optionality status of Count for the TRUNC function and provides the additional example given above.
            
            Change-Id: I2078d068b870dd05f4c977a2f9909537ecf7f9ab
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124190
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [f222340085ee08e929efb957b0fc532c5b288fae]

        tdf#136715: move UItest to CppUnittest
        
        Change-Id: I322b2cc0bae0889e5f3aaaf0542320c9dda82079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124243
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-27  4k5h1t  <ask160203@gmail.com>  [179e0c0cc5d3fd9610574e45a5204584f0e39176]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: Ic87c8e57a6b530a742a6bf3916c7a944e1bed2b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121306
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-26  Eike Rathke  <erack@redhat.com>  [96f97eb05fc32654db4ba836c794b74d502b166d]

        Heuristic filename extension should be <= 4 characters
        
        Still unclear what exact scenario in lcl_ScAddress_Parse_OOo() it
        would positively detect, but loading broken references may be
        caught by this and just a '.' dot somewhere leading to an
        (unresolved) external and then the InfoBar triggering. At least
        restrict that to the maximum length of 4 characters for common
        filename extensions.
        
        Hit by loading a range name pointing to
        $'zens. politik hj 1'.$#ref!#REF!
        or
        $'zens. politik hj 1'.$a$#ref!:#REF!
        in
        https://ask.libreoffice.org/uploads/short-url/6jOXRPprzGPOc5y0eHkUT6y6MfB.ods
        of
        https://ask.libreoffice.org/t/69315/15
        
        Change-Id: I2191f4511cc492679259e74edd242bfced03b0fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124240
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-26  Julien Nabet  <serval2412@yahoo.fr>  [baa6f7737d2b009739a244afd641eee35425015e]

        Replace macros from reportdesign/source/ui/inspection/metadata.cxx
        
        Change-Id: I779b6a20b814815b480876d8e65ef6b8e80f9443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124241
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-26  Stephan Bergmann  <sbergman@redhat.com>  [f8799964a0d2a3cbc07c7edde6f17b57f9c93e4f]

        Fix a memory leak
        
        ...introduced with 5d5da77e82b6498dd73123ec0dc36d2315e279a1 "tdf#116305 Add
        timeout to help Windows bring browsers to the front".  (And remove a redundant
        return statement, which had originally been `return true;`.)
        
        Change-Id: Idf7fe33b25cd243e31eea460e4af325c84dae88b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124174
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [58edf898989c8cba7e05bdac90db812a52ea03f2]

        d46f659c7524625474f0bb907805e285ee27d5ec follow-up: simplify checks
        
        Change-Id: Ib95e7c562741f76a742cd31aa033956a0f0a3c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124169
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-26  Stephan Bergmann  <sbergman@redhat.com>  [3fd9f90cfa620d7148d969a41df86da9e26e43f7]

        Remove OUStringBuffer member function overloads for OUStringLiteral
        
        ...which are already adequately covered by overloads for OUString and the
        OUStringLiteral-to-OUString implicit conversion that became cheap in
        e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a
        consteval'ed, static-refcound rtl_uString".
        
        The only place where the removal of the ctor overload caused an issue for copy-
        initialization (in sfx2/source/appl/newhelp.cxx) could easily be rewritten using
        direct-initialization.
        
        Change-Id: I458fb80eebabf981633f3437e7e967caa4c50a5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124176
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-26  Stephan Bergmann  <sbergman@redhat.com>  [f1a3218a91d53ca40058598580ed0031336eb21c]

        Silence -Werror,-Wdeprecated-copy
        
        "definition of implicit copy assignment operator for 'NfCurrencyEntry' is
        deprecated because it has a user-declared copy constructor" after
        97e63ff5375d9d80d6fe5d4bd68883e35bd56d91 "Fix toolbar button's currency list's
        number format for default locale" added that user-declared, defaulted
        constructor, for no apparent reason
        
        Change-Id: I070c8189c6dae8e62eb69ce40a2a1342cf0214a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124227
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [a1c693d23f53f035771de54fb139772be91e9bfb]

        uitest: when possible, close the document before opening a new one
        
        Change-Id: Ice8ec4868baab5182957ce335e2bc2cb93822af7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124228
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [eb664612aba4d7d8d5cf8d5a448f12be55da59ba]

        tdf#142010: sc_uicalc: Add unittest
        
        Change-Id: I99676a273c7ad1dad61ba82bc538c1ee4bd35d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124175
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-26  Eike Rathke  <erack@redhat.com>  [0f4756601982da8898c9305d6d03f1dc3fa9264a]

        Restore original lcl_ScAddress_Parse_OOo() behaviour detecting external
        
        It's quite unclear why exactly this would even be necessary, but
        
            commit 296baa2fb6dd4150a7855114093a9703cdc18b09
            CommitDate: Tue Oct 5 18:14:37 2010 -0400
        
                Ported calc-extref-interpreter-rework-*.diff from ooo-build.
        
        introduced a heuristic whether a reference could be a so far
        unrecognized external reference and used String.Erase(n) to strip
        a detected possible filename extension starting from the '.' dot
        to form a sheet name.
        
            commit 6f93499b881416140c57bc86acdac0ae6e01c314
            CommitDate: Tue Oct 8 10:03:08 2013 +0200
        
                convert sc/inc/address.hxx from String to OUString
        
        then changed the String.Erase(n) to OUString::replaceAt(n, 1, "")
        which of course does not the same but just removes the '.' dot
        character. In that commit this was the only replacement doing
        that, others already used a correct OUString::copy().
        
        Just restore the original intention, whyever..
        
        Change-Id: Icc46115f9f25eaf1ed727c233fb1c69942c4b1af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124238
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [370c9d725a8b026fa6454b7ffb43dc58c868594c]

        d46f659c7524625474f0bb907805e285ee27d5ec follow-up: add unit test
        
        Change-Id: I34be2bc813bf0d62cac935a84c6371cd64ee68f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [637d29fa8e0f5b04129244f993c6bb487e8510d8]

        Drop ContainerHelper::vectorToSequence and use comphelper::containerToSequence
        
        Change-Id: I987c56feab147cdbeb4ad58bd5ebb23dce6dbbca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124215
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [277d05a7188be77162e4a388c7c825daf8d6e326]

        ValueSet doesn't use WB_NOPOINTERFOCUS anymore
        
        Change-Id: I5d1b1240518aa97d229d56545e353259d226f1e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [ff1b1e51e26ff7314e5d77db85b0541626cda4e0]

        let focus enter calc sheet bg color dialog's valueset on click
        
        Change-Id: I884c8209e6b26e6c99654c4126ba81cf7e46c69f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124236
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [49433bb67d8602898cdeaed87eb0ebfa4ec3058f]

        Related: tdf#145296 use last spacing value as default for custom
        
        so its not always 100% in the custom value dialog, but whatever is the
        current spacing value
        
        Change-Id: I7a2690b2a38d2c49652830ad65d5dcf7bc80ba90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124171
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [5714eb5fe369672cde2459e8fe4ec0169190dff0]

        grab focus if clicked on anywhere, not just on a specific value
        
        Change-Id: I03b47080707c469d49e6cd9148573522d7f79da9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124232
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [20572726601760dfc59422e25dd2e56aa4069291]

        don't do any work if we'll ignore it afterwards
        
        Change-Id: Id8a8dbeb2164e291324ddcb2409c0d7f05d5774a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124231
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Luboš Luňák  <l.lunak@collabora.com>  [f7e6153c1bcd87a7a2f2d839c49bd7615c8dca5b]

        use boost flat_map for faster map
        
        setUpdatedTypePerViewId() gets called so often that even unordered_map
        lookup and allocations show up in profiling. It seems that flat_map
        can do better.
        
        Change-Id: Id2e4f0c40d6973b51e557f84a08bf12feb58b3ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124210
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-26  Noel Grandin  <noel@peralex.com>  [95cc31f15712bcd2b9829a4f9708374647af6e74]

        tdf#144513 improve perf when breaking long lines
        
        use the clip rectangle to stop early when the text exceeds the height
        of the cell
        
        Change-Id: I63dadc5b63c1f6c0852e0ba86a58f18c2b207cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124221
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-26  Steve Fanning  <stevemfanning@yahoo.co.uk>  [b94921fb8eecbb784a6711e36f1e5b4b1a6afaf6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c94585cd933b70a844719985ea63f70928e6d365
          - Add example to help description of Calc's SERIESSUM function.
            
            Change-Id: Ie3c95990e2ec75d439405d8fb79d9fde8d852bdd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124192
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [ca74611acfef50280a2c1f785448d9a09cca5a0d]

        there is no WB_RADIOSEL anymore
        
        Change-Id: I6b6573c8d9ad09a7087ddbb5fb673265c6af456b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124211
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Justin Luth  <justin_luth@sil.org>  [546e7d14b397cfd1210b891c8dc4a195c25f3876]

        tdf#131025 swtable: don't apply number format to non-number text
        
        Applying a numbering style to text causes export to save that
        out as a number (valued as zero). That is not good because
        the ODF spec says that a number overrides a string.
        
        So don't accept a numbering format on non-number text.
        
        Why is this change good?
        -the cell previously had no direct formatting (by definition).
        -the cell's previous old format was text (tested).
        -any numbering format applied obviously isn't correct (by definition).
        -any previous formatting has already been overwritten with numformat.
        -the default numbering is appropriate for text.
        -empty cells still get the numbering format (tested).
        -odd human-designed formats are accepted as intentional (tested).
        
        What are the concerns?
        -the scope of this change is HUGE, way beyond this bug.
        -on both my dev box and patch box I saw occassional crashes.
        -the bug was "fixed" by a different import commit that ensured
         different languages were treated consistently.
         So this patch is no longer critical, just nice to have
         to avoid exporting out-of-spec content.
        
        Change-Id: Id3dc5f803c3cf4875bc0cab52d1019a18679da77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123904
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-10-26  Hossein  <hossein@libreoffice.org>  [7e53757f91a176d68cdad1dbde2ecaba1db5c764]

        Using .md extension for vcl README files
        
        * Renaming all README files inside 'vcl' to use .md extension
        * The content was previously converted into Markdown format in
          dc984e7fed26ed26a2cafecb0c5b27feca56bfe2
        
        Change-Id: If55d363b418ff14864297d02a6986c4fc3625ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113531
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-26  Hossein  <hossein@libreoffice.org>  [e57793158700c48a9a9adf9fb1201e01dc6c270e]

        Update emfio documentation
        
        * Added information about dumping metaactions using mtfdemo
        * 'sax' dependency was removed in d49900e5a3aae75a4c673f593e99fbc296f67cee
        * Listing indirect dependencies from 'emfio/Library_emfio.mk'
        
        Change-Id: I5ee7e20c872aff388424930a23c9a17614b5e3c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124180
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [2cbcef18e6b93607c6156f149f6ea1a4d7df7b8a]

        gtk4: get correct rectangle for custom renderer area
        
        Change-Id: Ic7a1bd818a308f5caff5923ff30a0741ffec7f86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124177
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Hossein  <hossein@libreoffice.org>  [e62c4241093409583c913165ddc1e4c300c6218c]

        Use LO repo for mkdocs git links
        
        * Use git.libreoffice.org instead of cgit.freedesktop.org for the git
          links generated by mkdocs scripts
        
        Change-Id: Iac6e9ea1b73dcd0155786798c0ec162865299ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124186
        Tested-by: Jenkins
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-26  Hossein  <hossein@libreoffice.org>  [f7e351d7efa66ee3a28b339a7b2f1a5089f37024]

        Add documentation for the 'svgio' module
        
        The module 'svgio' is used to read SVG. This is
        the list of topics discussed in the documentation:
        
        * Introduction
        * How does it work?
        * Known Bugs
        * Dependencies
        * Related Software
        * References
        
        Change-Id: If42e9c2e10145c12cd5d74019b36bc5d78dd5bb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124178
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-26  László Németh  <nemeth@numbertext.org>  [4c982dbafdac900e233d7b68d95c9c99244defc1]

        tdf#145225 sw track changes: fix bad insert at moving
        
        Moving up a list item over a tracked paragraph insertion
        changed non-tracked text to tracked insertion.
        
        Manual test:
        
        - Create a 3-element list;
        - switch on Record Changes and Show Changes;
        - at the end of the list item 2, press Enter to insert a
          new list item, and type some text:
        
        Item 1
        Item 2[
        New item]
        Item 3
        
          where parenthesis shows the boundaries of the tracked
          insertion;
        
        - move up the last list item over list item 2 (the unmodified
          paragraph text with a tracked paragraph insertion at the
          end).
        
        Paragraph text before the tracked paragraph insertion
        changed to tracked insertion joining its tracked insertion
        with the moved list item, resulting only 2 tracked changes:
        
        Item 1
        [Item 3
        Item 2
        New item]
        [Item 3]
        
        instead of the requested 3 changes:
        
        Item 1
        [Item 3]
        Item 2[
        New item]
        [Item 3]
        
        Change-Id: I4716b2d244b57cf86d7d14d972452191549f5fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124144
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b6839f59b5aa9bf01674862aa320259ee488f63]

        uitest: rearrange tests to avoid "close_doc: no active frame"
        
        Change-Id: I92bf81801797821c9ec4aa73c005f1d6c6f6da62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124182
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [97bf901e36f139ba16deb006ea293c20bcd8240e]

        -Wunused-but-set-variable
        
        sw/source/uibase/uiview/viewsrch.cxx:97:13: error: variable
        'textSelection' set but not used
        
        Change-Id: I67a37e9440343a34147dd5be82cfc3dfb1282419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [48f6af631887a73ea93afeb5995aefeb7a91cd13]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 18465d2e19be235388020137629ab3ed67f103fb
          - Fix typos
            
            Change-Id: I1186621eb7159896828a0fa33e12f58dd4acf598
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124207
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [a948984f5d43516a7fbe6d75bfc5382cb522898a]

        gtk4: some fonts have pango_font_description_get_size_is_absolute
        
        and are too large, convert back to points
        
        Change-Id: I34aafb0a0678397c1c3c5780d67bdcea405a3866
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [bc92028fdf7f52f555702386a6862631e08a3919]

        tdf#136715 sw: fix table Undo to update table style
        
        Applying table styles works by applying direct formatting
        on the table. Some of the built-in table styles, like
        "Box List Red" specifies boldness for the last row of
        the table. After selecting and deleting the last n rows
        of a table, which has a table style which specifies formatting
        for the last row, the new last row gets these formatting as
        expected. However before the fix, after undoing the deletion
        of the rows, this formatting were still applied on that row
        which previously became the last row.
        
        Change-Id: I3ad086dd9b5e4111b3f019ca3d23f1db8b348637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123730
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-26  Tünde Tóth  <toth.tunde@nisz.hu>  [1b53c1dfc76f08ca7df40a0673aa50eca700d072]

        tdf#144374 DOCX: export the password for editing
        
        The password for editing wasn't exported in DOCX,
        resulting unprotected documents in Writer and
        in MSO 2019 or newer.
        
        Change-Id: Ieb8a339795635bc1c4223ccbe2a40ea85222cc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123543
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-26  4k5h1t  <ask160203@gmail.com>  [31ded6f8718a90c7b3b9eb36909c2b7a0c6e9b68]

        tdf#141908 - CppUnittests: replace usage of sal_Int32 with color
        
        Change-Id: Iaff808a86a8b3ea8f760402faded81d8b8081ce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121316
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-26  Attila Szűcs  <szucs.attila3@nisz.hu>  [69424f0fd66a74dbabba66c9c7fb1420aa1ff4e9]

        tdf#145129 XLSX import: round down default row height
        
        like table layout of MSO does, e.g. 20 pt to 19.5 pt.
        
        Same as tdf#144642, but with default row height.
        
        Follow-up to commit 537cb82be8fa021fd9382cca874645c75daaef20
        "tdf#144642 XLSX import: round down row height to 0.75 pt".
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Iefb615b56e5ddc11a5e839cf6d90516b18646045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123655
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-26  Martin Srebotnjak  <miles@filmsi.net>  [aa83a2dbb727b95c3ee162d6f382a857505dea5a]

        Update git submodules
        
        * Update translations from branch 'master'
          to 569442292afe8da0847d542276cdddea3d1728a1
          - Update Slovenian translation (xml tag fixes)
            
            Change-Id: I351bd95533d1b9e2e4b369c3edb1aa34140997c8
            
2021-10-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fc1b3fb659be916167518b49ffe8193e9033f30]

        flatten ImplGetTextLines
        
        Change-Id: Iefbbcb186b2811748abf49546351a2c68e8af462
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124155
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [9142f66ec1c78292dd2b8863c622dfb705dd2db2]

        Related: tdf#145296 we have spacing images we can reuse here
        
        Change-Id: Id511f8b272f1b1460f9c6c6d5c2ed835780ee806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [312a32f6b6c83c5747b617249d794fc87ffd8b9b]

        tdf#145296 use a 'clickable' widget for custom spacing
        
        Change-Id: I7c0b609a074a68dcc7ca4f6a775743e836a6caa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124165
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [592235d64d6f9638a61865712ca385ec58d688c4]

        tdf#145296 use a 'clickable' widget for custom depth
        
        Change-Id: Ifb64e1bef2a0b216f97fe112115a997973201268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124164
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  Caolán McNamara  <caolanm@redhat.com>  [30f1617bd873d9ccf343a280ba27f476d4c7726e]

        ofz#1493240 Unchecked return value
        
        Change-Id: I17ffbd28d56513ed7b39c29f74598c7517f44190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124160
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-26  László Németh  <nemeth@numbertext.org>  [7d5703ca50d719fbd82615fb81da7949fe163ae5]

        tdf#142010 XLS import: fix bad calculation after editing
        
        Inserting a column messed up formulas in the test
        document of tdf#142010. This was a regression
        resulted by the tdf#89281 fix for a performance
        regression in XLS import related to shared formulas.
        
        Revert of commit ba686b9bd2596811141e4028947334f10799c356
        "tdf#89281 fix performance regression of XLS import - cleanup"
        and commit b18b5b7edf3d14ef5f0efe53e367f88a423088c4
        "tdf#89281 fix performance regression of XLS import".
        
        Change-Id: I96636fb1d84939385efbe7054a4271ff10b88907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124151
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [514e83a0a548e61753b1238f55ee929c3c799eed]

        Revert "tdf#57308 - Basic IDE: Watching of a variable does not work"
        
        This reverts commit f9ce4b2d04b58843d7986acd9382864b0b30d617.
        
        Reason for revert: Cast to SbxVsriable instead of SbxMethod causes the code to start over
        
        Change-Id: I8f00f8f13faef8cb8c6db4e8c2a096a921f8714b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124187
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-26  Mike Kaganski  <mike.kaganski@collabora.com>  [d46f659c7524625474f0bb907805e285ee27d5ec]

        Make sure that self-assign test checks types
        
        This may be important with static empty sequence cppu::g_emptySeq, that is
        common for sequences of different types.
        
        The changes in sd/qa/unit/data/xml/*.xml fix places where anys with empty
        Sequence<OUString> used to wrongly take 'if(aAny >>= aPropSeq)' branch in
        dumpPropertyValueAsElement (drawinglayer/source/dumper/XShapeDumper.cxx).
        
        Change-Id: I5b0544ca94b30437c01dd46f376408f91510bcb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124167
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-25  Caolán McNamara  <caolanm@redhat.com>  [d80547c7f4ddf599cce52e5c52269cb07a677466]

        resave with latest glade
        
        to normalize the property names and grid row/col comments. Taking
        care not to lose the non-standard explicitly empty labels for
        the GtkMenuButtons
        
        Change-Id: I015560f8b7eaa814e0540fbfbff9cfcb920b44b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-25  Caolán McNamara  <caolanm@redhat.com>  [53daeb9a7b1bf31484a7995114d5f85e32303550]

        Resolves: tdf#145297 assert on Docking3DEffects launch
        
        (git show -w is your friend on commits like this)
        
        Change-Id: Ie3a11986f98d196b6134fdc69e76a627e87d137b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124161
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [03f4bd06bd89eb086eeb332693d1c4e96916e2df]

        tdf#138531: sw: Add UItest
        
        Change-Id: I953948a5d10e8fbb6610ea0bf49ae7e8308e83eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124157
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-25  Caolán McNamara  <caolanm@redhat.com>  [79d27b6d6eab82d692c2b3547dacdd4e9190dc1e]

        bsd (as used by macOS) ar does not support '@' option
        
        so gb_LinkTarget__command_staticlink should use the same workaround
        for that as gb_LinkTarget__command_dynamiclink does
        
        Change-Id: Ied9d8a3b99f09d6ea1b705e0c1ce3ef3b2d14190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124156
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-25  Caolán McNamara  <caolanm@redhat.com>  [3e9da1e271c26bd17ab4fe107992e6a03fe865de]

        ofz#40305 Divide-by-zero
        
        Change-Id: Ib865d880d51d5beef1f235e4a8d5d0c17adf8499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124153
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-25  Luboš Luňák  <l.lunak@collabora.com>  [4bb6533d398cc76d7ff292a9e47dae87fac74f83]

        use pull model also for LOK text selection
        
        Make LOK_CALLBACK_TEXT_SELECTION, LOK_CALLBACK_TEXT_SELECTION_START,
        LOK_CALLBACK_TEXT_SELECTION_END and LOK_CALLBACK_TEXT_VIEW_SELECTION
        also use pull model, i.e. LO core will only set a flag and when
        CallbackFlushHandler needs the actual data it'll use getLOKPayload().
        This again avoids a large number of messages passed to
        CallbackFlushHandler only for them to be sooner or later discarded.
        
        Change-Id: Ia7528039be996a6e9e8491b4eba3f4133582fa56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124146
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9e3ec1b50052e687d6bc79db8e2ed5ebbd0eb24a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 56638af603a79cd9330752fab99a7769ace9ffaa
          - tdf#140779, tdf#140780 filter params for CSV, lotus...
            
            Change-Id: Ie439889bd8dc4bd630187e253d3689c8e644b2a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123901
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-25  Eike Rathke  <erack@redhat.com>  [97e63ff5375d9d80d6fe5d4bd68883e35bd56d91]

        Fix toolbar button's currency list's number format for default locale
        
        Always resulted in the currency's LCID being omitted in the number
        format for the default locale, which doesn't immediately harm but
        loses the context (what currency a $ sign is actually), and also
        lead to the "real" default currency format never matching the one
        being generated for the list so no entry was selected if that
        format was applied.
        
        Change-Id: I7963e4d3701092d6e227705fc0e8282448f075b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124152
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [02bd6074b00c3e4420f67ad67566c217d9341c03]

        uitest: execute setActiveFrame in load_file first
        
        In 4839b7ca3b5a730edf90ebebc749db145efec098
        < Fix UITests that use File Open dialog to load documents >
        the order of execution of load_file method was changed,
        making the code after the yield keyword to be executed
        after the test code is run, which is not what the original code did.
        We need to execute that code before running the test code,
        specially setActiveFrame
        
        Change-Id: I4ba436cbdf4fe2261589527f8d38a916d47b94aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124154
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-25  Luboš Luňák  <l.lunak@collabora.com>  [5dc3bc1e951a5e1c485db8034d691bac4d42344a]

        replace friend access with functions
        
        Change-Id: I11cb916285c72f7cd85ea5d5c943f23d0a4f6bc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124148
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-25  Stephan Bergmann  <sbergman@redhat.com>  [ece8937267a0024b209c951884f81ba2aac5792d]

        loplugin:indentation (macOS)
        
        Change-Id: I7a180a79dff11816e1504bdd1803102325aa365d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124149
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Eike Rathke  <erack@redhat.com>  [9c364847d6eae7f486f60823090cbc39fc0b1016]

        Restore behaviour SvNumberFormatterServiceObj keep LANGUAGE_SYSTEM unresolved
        
        Semantics were temporarily changed with
        
            commit bba6a4ed92a0feb288a9dedd648d623bee02a3ce
            CommitDate: Mon Oct 25 11:18:31 2021 +0200
        
                Get rid of fuzziness in MsLangId::Conversion::convertIsoNamesToLanguage()
        
        Change-Id: I8bbf77998bea81c5691ba518c7ae25093b0df421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124141
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-25  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [21bbccee8b93d02abf7b3fd310e42485a1024e31]

        Update git submodules
        
        * Update translations from branch 'master'
          to 41974fc7ebdc4d8d6d8d017a6e68753fd5a049e3
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ic6888555f22c4e961c0734fa685969b43f89c02e
            
2021-10-25  Szymon Kłos  <szymon.klos@collabora.com>  [97b15bcc2d15dd754afbfbf8709fa62a9866160e]

        tdf#145312 xmlsecurity: prevent from crash when cannot receive pdfium annotation
        
        Change-Id: I6adc2cb0a07eb08a50c610958983493f4f8031ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124021
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [d267e5a0b1a05c595d7bd90987aceae5c98d90d5]

        uitest: fix indent
        
        Change-Id: I7034ab2b7933f248a0d6929bd11497ff3098dd3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124138
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f9ce4b2d04b58843d7986acd9382864b0b30d617]

        tdf#57308 - Basic IDE: Watching of a variable does not work
        
        Watching a variable which returns a value from a function always shows
        "out of scope" in the watch window of the Basic IDE. In order to resolve
        this issue, the name of the variable being watched will be searched also
        in the current method instance.
        
        Change-Id: Id383e03925956056931d199fe86d1b352cf8e4eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124075
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-25  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3d7fcf663ceece43b4648e6adee19dc6869729af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cae1ccb6137d03cada0e187756e9197a897ba94b
          - tdf#131563 VBA color constants
            
            - VBA color constants addition
            - Aggregation of spreaded constant definitions in this page
            
            Change-Id: I5f4045256e5e03c6b11247c9bb0442e9e63d738d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124013
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-25  Eike Rathke  <erack@redhat.com>  [a6baab25b53d0a87686a5fcdabf86747e9678021]

        Introduce LanguageTag::convertToLanguageTypeWithFallback(Locale)
        
        ... with keeping LANGUAGE_SYSTEM not resolved or falling back.
        
        Change-Id: I10211c2b2140a9822f1403dc00af3ee9ded08f69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124140
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-25  Stephan Bergmann  <sbergman@redhat.com>  [98eb119fed253b0af7a3b5c9a28905d29118167f]

        Adapt to Clang 14 trunk diagnostic output change
        
        <https://github.com/llvm/llvm-project/commit/aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7>
        "Recommit: Compress formatting of array type names (int [4] -> int[4])"
        
        Change-Id: I911934a778fddde0d0022f2e2601d1f9c371fe69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Stephan Bergmann  <sbergman@redhat.com>  [eba4b90d2eba5e4dbf75c1a7fcd7ce13112d4db5]

        Missing test dependency
        
        > oox/qa/unit/drawingml.cxx:162:testPresetAdjustValue::TestBody
        > equality assertion failed
        > - Expected: 1
        > - Actual  : 0
        
        Change-Id: I3ff0707db485dce1e43c14b8d1a5828da8e14923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124139
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Stephan Bergmann  <sbergman@redhat.com>  [6bc8a1ba5151e44d2ea539fe5f6408fc3d6be02a]

        Missing `static`
        
        ...from aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve
        loplugin:stringliteralvar", similar to 8b32a3edad52f8ac5e5f0f49b4f4e80954c2fd25
        "Fix stack-use-after-scope" (though this case doesn't appear to have caused any
        actual issues).
        
        (After manual inspection, there appear to be no further missing `static` at
        least in aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve
        loplugin:stringliteralvar".)
        
        Change-Id: I2b3d0d8d2af1d65f0c5bef8a858107020a620974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124137
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Hossein  <hossein@libreoffice.org>  [68f3bf394617a7d00d920694642f5a3e37fee629]

        Converting pointer to reference in svgwriter
        
        Previously, pElementId (old name) was either nullptr or a pointer to
        OUString created from sPlaceholderTag literal.  In the methods that
        consumed it, it was checked for being nullptr. Now, this is checked
        with if the aElementId (new name) is empty or not.
        If the variable is an empty string, it implies that it should not
        be used.
        
        Change-Id: I560fd479f428341c834ee99b0f8a34e95862e3e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123439
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-25  Eike Rathke  <erack@redhat.com>  [bba6a4ed92a0feb288a9dedd648d623bee02a3ce]

        Get rid of fuzziness in MsLangId::Conversion::convertIsoNamesToLanguage()
        
        With on-the-fly LanguageTag the fuzzy fallbacks for a few
        languages aren't needed anymore. Proper fallbacks should be
        obtained when needed, like when configuring default locales, or
        configured values used after.
        
        Change-Id: I8b85b8099e085508435036ac846db6c3e516dc23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124127
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-25  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [98247b039baea4697e6c387025afcf6a2963c043]

        tdf#138531: Also update DDE tables, not only fields
        
        Change-Id: I0cbf8ce355b460b2f7ea73c8fae653641c980979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124129
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-25  Jean-Pierre Ledure  <jp@ledure.be>  [6a1feb264479f0b223305882636eed1b58c80966]

        ScriptForge - (SF_Calc) new A1Style() method
        
        Returns a range expressed in A1-style as defined by its coordinates
        If only one pair of coordinates is given, the range will embrace only a single cell
        
        Arguments:
           Row1 : the row number of the first coordinate
           Column1 : the column number of the first coordinates
           Row2 : optional, the row number of the second coordinate
           Column2 : optional, the column number of the second coordinates
           SheetName: Default = the current sheet. If present, the sheet must exist
        
        Is complementary to the Offset() method to compute ranges easily
        
        Available both from Basic and Python user scripts
        
        Change-Id: Ib9323441bbd579beb867329c8b0930653462d00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124093
        Tested-by: Jenkins
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-25  Tomoyuki Kubota  <himajin100000@gmail.com>  [bbd21f4069fd17a0f6b734b62a45f1fefc9c1f7f]

        expanding macro SCSTR
        
        Change-Id: If497954b4e70e0a4dbd7268a25727a2478b95184
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-25  Stephan Bergmann  <sbergman@redhat.com>  [8b32a3edad52f8ac5e5f0f49b4f4e80954c2fd25]

        Fix stack-use-after-scope
        
        ...during CppunitTest_svl_qa_cppunit, after
        df42cb6552b20372f62b5a361709670db80e4ed4 "Optimize assignment from
        OUStringLiteral to OUString",
        
        > ==918==ERROR: AddressSanitizer: stack-use-after-scope on address 0x2b2e203b5900 at pc 0x2b2e1b9004f8 bp 0x7ffc06726270 sp 0x7ffc06726268
        > READ of size 4 at 0x2b2e203b5900 thread T0
        >     #0 0x2b2e1b9004f7 in void rtl::str::release<_rtl_uString>(_rtl_uString*) /sal/rtl/strtmpl.hxx:1064:9
        >     #1 0x2b2e1b8d916c in rtl_uString_release /sal/rtl/ustring.cxx:1785:12
        >     #2 0x2b2e36263ec5 in rtl::OUString::~OUString() /include/rtl/ustring.hxx:493:9
        >     #3 0x2b2e3622c5ff in (anonymous namespace)::Test::testTdf103060() /svl/qa/unit/svl.cxx:553:1
        [...]
        >     [2304, 2320) 'EXPECTED_G3' (line 550) <== Memory access at offset 2304 is inside this variable
        
        (<https://ci.libreoffice.org/job/lo_ubsan/2176/>).
        (aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve loplugin:stringliteralvar"
        had failed to introduce those OUStringLiteral variables as static.)
        
        Change-Id: I59168979fcc4b055d17d1d4f315577eef1027505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124134
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Luboš Luňák  <l.lunak@collabora.com>  [95a9567051c954d5ae552077954bcde27690beb1]

        show properly gcc version in configure output
        
        $ gcc -dumpversion
        7
        $ gcc -dumpfullversion
        7.5.0
        
        Change-Id: If4f528b3ea732e405507d7563e743ba48e96f523
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124094
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-25  Hossein  <hossein@libreoffice.org>  [1fd620d06d851808dc4d8dce066387b96bf43c9a]

        Replacing std::unique_ptr<char[]>
        
        * Replacing std::unique_ptr<char[]> with std::vector<char>
          * The data bytes are read into the vector internal storage
          * Modification of the internal storage of the vector using the
            pointer returned by data() is allowed by the standard
            C++ Standard, revision n4830, section 2.3.11.4 Data [vector.data]
             Returns: A pointer such that [data(), data() + size()) is a valid
               range. For a non-emptyvector, data() == addressof(front()).
             https://github.com/cplusplus/draft/blob/main/papers/n4835.pdf
          * It could be replaced with std::string when data is not modified
              Example: 6c13e5a92ed4b6a10458cd5d5741ddb3d816df4e
          * std::vector<char> is useful when working with C functions that
            get "char *" for writing data. In this case, std::string is not
            usable, because data() method for it returns "const char *".
        
        Change-Id: Ife6013b16a1803c3ad7b0c64aa0cb4c8cf4373ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123764
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-25  Hossein  <hossein@libreoffice.org>  [4a8aed2940040e8b8f0db0f06cb06a757cd06a9a]

        Cleanup DocumentLoader C++ SDK example
        
        * Remove unncessary C-style cast from DocumentLoader.cxx
        * Remove trailing whitespaces from Makefile
        
        Change-Id: I7cff589353d3e40301cf45ce0a76e0c75beddf13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124115
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-25  Jim Raykowski  <raykowj@gmail.com>  [39bffe9ba612ce5fc8806a739ae7d960915ac31b]

        tdf#145132 SwNavigator: Add tracking option for all categories
        
        and make the setting for each category persist
        
        Change-Id: I3ca41cb860734d31fd93d0d30b37c0301bc2f7dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123960
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-24  Eike Rathke  <erack@redhat.com>  [542a38de1a071f54f61806683dafea84e43edce9]

        Return LANGUAGE_ENGLISH_US for AppleLanguageId::ENGLISH
        
        Most likely was an oversight when using LANGUAGE_ENGLISH as other
        LANGUAGE_FRENCH and LANGUAGE_GERMAN are locales already.
        
        Change-Id: Ie16395340cef9939a5397e3d10d6df6b13ac8d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124124
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-24  Caolán McNamara  <caolanm@redhat.com>  [f2ed9655b9327b9c3eb479ccc98ebb0bde4190f2]

        cid#1493243 silence Copy-paste error
        
        Change-Id: I6eeb4e2213aa5dcbae94ec7c3a14a18a986f9975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124121
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-24  Caolán McNamara  <caolanm@redhat.com>  [9efc7e6980e3ada86bfd501fc7306f596abccbf5]

        cid#1460971 Unchecked return value
        
        Change-Id: Ic60242072a0ba7037cd8094ae98633b038c6f1eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-24  Martin Srebotnjak  <miles@filmsi.net>  [8dfa16a715cf6857c834e017324e995250544ee6]

        Update git submodules
        
        * Update translations from branch 'master'
          to 26c743b6e210606f1d10d34439d2073ca2140ed6
          - Update Slovenian translation
            
            Change-Id: Ic92f48c0e8b021b0e7c1a8fb01b553bb739df2f0
            
2021-10-24  Caolán McNamara  <caolanm@redhat.com>  [a7f6d0b6990517a6fcbde7909eb5306a51d31af9]

        cid#1493242 silence Copy-paste error
        
        Change-Id: Id95cab7b70a9f97dadadb8d0cff64674ec3711b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-24  Caolán McNamara  <caolanm@redhat.com>  [2f0e8176defbac0f19c06e3ec75fb57567e8ef52]

        cid#1493239 silence bogus Use after free
        
        code was perturbed by
        
        commit 5f9ffc31cd1b5433c354c7d39ce1d80fa0e57fc8
        Author: Noel Grandin <noel.grandin@collabora.co.uk>
        Date:   Tue Oct 19 09:08:35 2021 +0200
        
            introduce SwNodeOffset strong typedef
        
        so coverity has seen in afresh
        
        Change-Id: I200f8f40e193f8725ccc1fa5fbb06e3d182bec67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124118
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-24  Caolán McNamara  <caolanm@redhat.com>  [b7c8e4f8ae5402eb665f758f75123e9fe1514d01]

        cid#1493240 silence Unchecked return value
        
        Change-Id: I3847647221cf365146c8a5f418e65e3e5798303c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124117
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-24  Johnny_M  <klasse@partyheld.de>  [1b33c023f389d66389f7d1ce6b35d5531b4f7a06]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2592de88d4e0f7c15526f08c3abab1475d697f70
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib2c5e06d6f23c7897a69a0613035a593ee3701d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124112
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [56a6b8eca5eecd3506c4f3d32114e1003c55d23d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4fb1b1412a0f1cf7626feca09881f6f630f45d2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I96c6d66f3d030e2881ddff0f0f35833f65b85cc4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124111
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [f12ceb71f256c095f4daeabbd3f75c1d5b731d37]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 005ab5fa0c87135a3e5b8f7150c67d1c47ed490b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I51c35619cc80d3c7e0dce3ea805e5afc486c8daf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124110
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [b1fda2d047dda4852f1c66955bf84f24ec3bd18e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b425e5428d61fb534a6fc02e948f7b246aaaec8f
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib099bf8474d272cbf10fad79c80b5164b5d11717
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124109
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [756ea53c6567096ff205f55f8f200f4118c2113b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d2f50f0de3075da42af1725f0061180c7ce89c0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3dc05a302194a7eff7e0776776c309afabbc731f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124108
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [61ec73e55e2339821a6678c85c3ca1970b984582]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21500a71de051f1a2046e97c7cbd1f344bb82431
          - tdf#132643 Translate German section IDs
            
            Change-Id: I59cec2f60abf1251edfc865932ace953008c57d4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124107
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [9d8432452f64b0815e4c652647480cf47a26c706]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6422afb3a6ac4ce1d5d0658f24f9cfd3d19e7d07
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3bc212d560b2838daca117bf29d5bce0293ffcb5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124106
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [da02e9bc027ae827893a87f7b262bd12d1cc2133]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bee3e08d0957c12c92934fd46d3c1ae40f564911
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ifddc735398087a7fbd39136a9bcbf5fda5c457f0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124105
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [3d18f306e2d39fc3910eae727917add298fe2a6c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9ae706191bf26ed27da4fc8ddd9ceee8c49af848
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9b32ddd9a754764d3798fadeb9c323dd1694aace
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124103
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  Johnny_M  <klasse@partyheld.de>  [5efc12c7d102bbd3fba14808a5abdaa9b97c6284]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49c732f50cc787aa1c713934a4002d5cc4186cb2
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icc84282d95c3003577bec75d130099d027d2545b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124104
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-24  4k5h1t  <ask160203@gmail.com>  [0776e75fbc09201052e27a33cbc9e8f117b43596]

        tdf#42982: improve UNO API error reporting
        
        Change-Id: I9300b4e6eb9ee3ff2b9bfd32efdf0c8ceedc9d3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124113
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-10-24  Luboš Luňák  <l.lunak@collabora.com>  [273a25c796fca9afa0dfadac57dc3f336831221c]

        change some LOK internal updates to be pull model instead of push
        
        Some LOK messages may get called very often, such as updates about
        cursor position. And since only the last one matters, they get
        generated every time, which costs some time, and then later except
        for one they get all discard again from CallbackFlushHandler queue,
        which again costs time.
        
        Change the model to instead only set an 'updated' flag, and
        CallbackFlushHandler will request the actual message payload only
        before flushing.
        
        This commit changes LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR and
        LOK_CALLBACK_INVALIDATE_VIEW_CURSOR to work this way.
        
        Change-Id: I376be63176c0b4b5cb492fbf529c21ed01b35481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124083
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-24  Mike Kaganski  <mike.kaganski@collabora.com>  [667c2499d861cfcd26935fc0512cb5aaf602c4c5]

        Use std::transform instead of loop
        
        Change-Id: I1fa2eaec67bd5e85d09d4d662deede34d3388176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124016
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-23  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b66ed4cb3707800b8bd9ab0f397c226037e10fbf]

        tdf#145215: docx: do not initialize prefix/suffix and include levels
        
        On DOCX import we do not need to provide prefix, suffix and included
        levels: these values are calculated in SvxNumberFormat out from list
        format. Moreover these values are incorrect and do not correspond
        not to DOCX data nor to internal writer representation of list level.
        
        Change-Id: I91ec9de679e67056ba3746f2e1a0bd923532d76c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124090
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-23  Mike Kaganski  <mike.kaganski@collabora.com>  [911c74d0ec05a2b216936e3f58900a4aea137146]

        Use std::size/begin/end in comphelper::containerToSequence
        
        This allows e.g. to use the function with valarrays, that don't have
        own begin/end, but has std::begin/end overloads.
        
        Change-Id: I4559180e30040ed5d42805170a02a53280fce9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124015
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-23  Luboš Luňák  <l.lunak@collabora.com>  [84a54f6c388d3abe1d6f6e04bf07441ae96f60cd]

        move access inside mutex guard
        
        Change-Id: I784fbc3b39a645c7984aa836cc32980343ddd1f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124095
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-23  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [fd7549f4c6197cdbdfc97e949487723cd00a663e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fb9c746f6aaae147aa16b1f2b682e01d07003d03
          - tdf#145232 get_bookmark.xsl: Use normalize-space()
            
            normalize-space() trims whitespace from the start and end of a
            string and collapses multiple spaces inside a string into a
            single space.
            
            This will prevent newlines in strings from breaking
            our generated bookmarks.js.
            
            Change-Id: I2a420cfd9fe13ee063151af79cb51b0ae49f5a0d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124056
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-23  Justin Luth  <justin_luth@sil.org>  [3e1d316734354c6b49696c8904e0fc431cfb5143]

        tdf#131025 ODF import: recognize SV_COUNTRY_LANGUAGE_OFFSET
        
        File import was making an exception for "float value 0"
        if the accompanying text had no resemblance to the value 0,
        but that only applied to GENERAL number format.
        
        It should apply to any language's default number format.
        
        REGRESSION warning: as we can see, this has been handled
        inconsistently in the past. But from the coding exception to overcome
        losing text to a zero (and the huge number of duplicate bugs)
        the best choice seems to be ignore the spec that says that
        a number value overrides the text value - at least in
        the case where the number value is zero.
        
        Change-Id: I701e72c6a5dad42c7799ab501255a4859adf61d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124080
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-10-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6dd75b17e084b55a8104099945bc39ef4663585b]

        Fix typo to complete commit 25278dc22ff6
        
        Change-Id: I78f0d443365e23501b43fe0f1d9e32d503c1e9f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124085
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-10-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b187189318a3d49dfa049490d214faf92dce9d86]

        Fix typos
        
        Change-Id: Iaba882b1bd000a068cfaa207c743be038d5db434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124087
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-23  Julien Nabet  <serval2412@yahoo.fr>  [4739593c39158fffd745ca6af43d41017c9cbe39]

        Prefix just nDataRowHeight in brwbox so we can fix a typo
        
        The other variable members should also be prefixed
        but I don't have an IDE to do it easily
        
        Change-Id: Ifce210a4de89ed4d7f05126e33555da231553283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124089
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-23  Jim Raykowski  <raykowj@gmail.com>  [442be5242e2f541b8ad847cd629e715f3fd84205]

        SwNavigator: Make tracked drawing object scroll into content tree view
        
        Change-Id: I948c8b38f0df86f30f9c5af56aea5103c82c661c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123966
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cc1598b806a8f63079de64512e0b322fc9b28714]

        Remove duplicated word
        
        Change-Id: Ib3815aee68fdeb8f5eef465d01c51c66378fcd1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124086
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-23  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [12cc7abbfebf3b1845ec7fa8663b8c95443cd45a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c0d02652166d4baf168f233459df09138ddc268
          - Fix typo
            
            Change-Id: I49852f6b601817fa179306896a1d0b263a8ec4bc
            
2021-10-22  homeboy445  <akshitsan13@gmail.com>  [f8bb970fd385c80b085a071da0f8acc119498005]

        backendtest:Reconfigured Rectangle tests to be Asymmetrical
        
        The tests were previously drawing squares in the middle, however,
        now the tests draws rectangle taking offset from the middle.
        
        Change-Id: I26a4af997feac9ced443d7c9b4e3541ea2ba868a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120076
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [5760cba3b276a372d6cccf3f6b6db7fb26c20351]

        tdf#64991 speed up loading large RTL documents
        
        only insert the bounds we are interested in
        
        takes load time from 1m51 to 1min39 for me
        
        Change-Id: I5a267ae3cf3fe7691481f83b591b02d939931c07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124074
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [25278dc22ff6949da442032ce2dad8638b1c8512]

        Typo: aFontHeigt->aFontHeight (starmath/smediteng.cxx)
        
        Change-Id: I8ae578350e911c69eeabbb3af41aaf9801b4ffee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124073
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [535d406854f38c717386c6ffa0f895d204ae7038]

        qt: Adapt log area: "vcl.qt5" -> "vcl.qt"
        
        And also: "vcl.opengl.qt5" -> "vcl.opengl.qt"
        
        Change-Id: I86f8a34cb8c1303a81ffbf40c801ba628f3fa0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124065
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [107f4f2a6d6a2d84ff8104b1de16b1e06c2af131]

        Rename SystemEnvData::Toolkit::{Qt5 -> Qt}
        
        It's used for the qt6 VCL plugin as well.
        
        Change-Id: I3f57258c2c8e3c12532d79b44f24105a30590675
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124064
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [3b079241da281d5e60572c8258d827af67f8f847]

        Revert partly "Simplify vector initialization in vcl"
        
        since it needs 2 allocations instead of one
        
        This reverts commit 43a9bf11203ed92096af34ab828501e0218832c7 .
        
        Change-Id: I1d8553d9c31f663dd990146e6d375bbbaf32fb27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124072
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [7b11cda2aa1f9bd069d81c30021448674a97ce30]

        Revert "Simplify vector initialization in helpcompiler"
        
        since it needs 2 allocations instead of one
        
        This reverts commit cd5ee8c7d3f06fe78e6b3993845a3c2abc7cb72a.
        
        Change-Id: I4958cacf747291c923b74fdfa49679e831d0ef1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124070
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [86430b76d5833d85f54ccfdbf933162b59a261d9]

        Revert part of "Simplify vector initialization in sdext"
        
        since it needs 2 allocations instead of one
        
        This partially reverts commit d64a6e2245169e5e4a3f8bc5388b4fff4984e5f4 .
        
        Change-Id: Iadd8193a02bd922105c082fe3bbcc6f8e9f96b22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124069
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [db43de861f7b5b66993245ab9e7719fdce61caf8]

        Revert "Simplify vector initialization in reportdesign"
        
        since it needs 2 allocations instead of one
        
        This reverts commit ac10792ed4ca8d92f60c95ab4acd5b911e42cec7.
        
        Change-Id: I5b07664b7930ae1a04a6f755ddbe5ef56a880f56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124071
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [28f245a890560ca9ce078cc286705929358258a4]

        Revert part of "Simplify vector initialization in sd"
        
        since it needs 2 allocations instead of one
        
        This partially reverts commit 5393f9a53eb8b33537aedd03b7c9efc5222748d6 .
        
        Change-Id: Ifaa1327f2da4bb98ac134ebd8ef105becbc28b5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124068
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [0922d1d2b0ba30d44eae311a8d0dc17345b8dcac]

        tdf#64991 speed up loading large RTL documents
        
        takes load time from 2min49 to 2min5 for me
        
        Use a vector for the PortionMap since
        that has better cache density, and we always add
        to the end of it, and always in the correct
        order, so no sorting is necessary
        
        Change-Id: Id28e86144a86f0f1361ef4e828f925694eb3bb11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [11dfb73eec6ae94ebb52cbbbb6bdf9267fbb717b]

        Revert "Simplify vector initialization in dbaccess"
        
        This reverts commit dfa8dbf98ee872d22bb9e2c63ab07ed76fb81579.
        
        since it needs 2 allocations instead of one
        
        Change-Id: I64d449ca885880f3e6e795168978ffa99a005c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124067
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Pranam Lashkari  <lpranam@collabora.com>  [c4b934128965cbd461f1c61255fe0c5d25cc29d6]

        LOK: maintain blocked command list per view
        
        Conflicts:
        	include/LibreOfficeKit/LibreOfficeKitEnums.h
        	include/sfx2/viewsh.hxx
        	libreofficekit/source/gtk/lokdocview.cxx
        	sfx2/source/view/viewsh.cxx
        
        Change-Id: I7c621accd84f49447ab3e08a4bb662a9b91b834a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124049
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-22  Pranam Lashkari  <lpranam@collabora.com>  [d05c69a892535b910943fe98fbce42f5cc860aa4]

        LOK: unify freemium APIs and uno command restriction APIs
        
        Conflicts:
        	include/LibreOfficeKit/LibreOfficeKit.hxx
        	sfx2/source/control/unoctitm.cxx
        
        Change-Id: I3badb038822331ab5cb30df6a66ce9a0640cf340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124047
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [6c9909dee4b06948ca6932397caa338d77ec7290]

        fix std::unique_lock unlocking
        
        std: :unique_lock::release() does not unlock.
        Change-Id: Ida5a28a8b1c275a0a702121bf00faeaf76a57426
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124063
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
        Tested-by: Jenkins

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [bb2e861827cb854dd380d2b7ac3d8907de7043d7]

        prefer llvm-addr2line to addr2line for backtraces if possible
        
        It's faster, and at least when compiling with Clang it should work
        fine.
        
        Change-Id: I474857c2a54b8032b74202ccd5c67d25f6062790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124055
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [29e200aa0af78a4589bf7e52dddfb62f3bdf4e01]

        revert part of "Simplify vector initialization in sal"
        
        This first allocates space based on the two items, and only
        afterwards it reserves space for all items, possibly allocating
        again.
        
        This partially reverts commit 8546cdb2ad25b03ac152615357cab00 .
        
        Change-Id: I8668cb03881766fc5078ab5e411efe56e6f3009e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124054
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [d6a26e26505ec1f6810c6b749129a79ba0931742]

        cache negative addr2line hits
        
        Otherwise we'd be trying to resolve unknown symbols repeatedly.
        
        Change-Id: I1c1eb9f97a1f64436ad0858ceff75fa29343979a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124053
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Miklos Vajna  <vmiklos@collabora.com>  [42865108702f80a829513aef8f45965c508d0a74]

        sw: fix crash in SwXTextDocument::postMouseEvent()
        
        From crashreport:
        
        SIG   Fatal signal received: SIGSEGV
        
        SwXTextDocument::postMouseEvent(int, int, int, int, int, int)
        	sw/source/uibase/uno/unotxdoc.cxx:3559
        doc_postMouseEvent
        	desktop/source/lib/init.cxx:4245
        
        Make sure we don't crash when a mouse event is posted on a disposed
        document.
        
        Change-Id: I3fb123460b21bf8fe21406d1745f43270102af33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124060
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [62f47c26ad096cf088b545f10e14f9d81e2f2cc1]

        properly flush LOK invalidations in tests
        
        This should be done always before doing something with a flag
        related to the invalidations. Use an idle timer for simplicity,
        tests already usually process to idle.
        
        Change-Id: I979900da28061cc690ecbcce023dbb769239f205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124003
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [9037e42ab3c3793341b583b181617185aefcbde5]

        ignore invalidations in Writer when doing tiled painting
        
        That's done by ignoreLibreOfficeKitViewCallback() called from
        SfxViewShell::libreOfficeKitViewInvalidateTilesCallback(),
        but in case Writer delays invalidations to compress them, the tiled
        painting flag may be already reset by the time
        flushPendingLOKInvalidateTiles() gets called, so handle that
        explicitly. SwTiledRenderingTest::testTablePaintInvalidate()
        would otherwise fail with my follow-up commit that makes
        TestLokCallbackWrapper flush the invalidations.
        
        Change-Id: I915ae4e40bc7a82b3e48498f7e5513420dd64522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124002
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [31b1e23e2d806f847fce21b8827f015384f20916]

        better name for a function overload
        
        It's better to add to the name what the overload does rather than
        just have a "mysterious" extra int.
        
        Change-Id: Iff89679c4a978a4596ac662ef74e934cdefefc9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124001
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Luboš Luňák  <l.lunak@collabora.com>  [a21c6a3dd36aee21bf1536183dc8ccde2ff52672]

        revert unittests to use plain text-based LibreOfficeKitCallback
        
        At least for now it seems that the more complex
        SfxLokCallbackInterface is just an unnecessary complication for unit
        tests. The performance doesn't matter, and handling all the
        specialized callbacks makes things more complicated. In the future
        it'd be also useful to make the tests (optionally?) use also
        CallbackFlushHandler as the provider of the messages, in order
        to test CallbackFlushHandler more thoroughly, so perhaps in the end
        it makes more sense to keep unit tests using the plain text interface.
        
        This reverts unittest-related parts of 3b729db05553c1a6d461fb41c89
        and adds a smaller wrapper callback class that converts messages
        from SfxLokCallbackInterface to LibreOfficeKitCallback format.
        
        Change-Id: I6c14f0be4ed7b777444b131140be54188d309cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124000
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [71a24a911bb091885fb03d124d3936d955b13399]

        no need to allocate RangeIndexMapPtr separately
        
        Change-Id: I0e2aae923530667877bfb111b006b214ca51a730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124057
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f3628260e55baf871bd29922075f1498a80e438f]

        tdf#145274 FILEOPEN: Text properties are lost
        
        Revert "tdf#135683 speedup SwAttrHandler"
        This reverts commit b62153753a9f21afb2a49110ef0459e427b0b01a
        
        SwAttrHandler::RemoveFromStack breaks the assumption I made in creating the above commit
        
        Change-Id: I20ab532e1eae98c94f7c579755285262d46f2f91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124012
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Chris Sherlock  <chris.sherlock79@gmail.com>  [82275140a56750302265a5be21236ae7a15f16e6]

        vcl: move variable declar's closer to 1st use in DrawComplexGradientToMetaFile
        
        Change-Id: Id626799d1b077e649f67a8abf335a63efd15d433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123000
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-22  Dennis Francis  <dennis.francis@collabora.com>  [9436f7e2ffb41c278107aa4e6fd6914937994cbd]

        lok: invalidate sheet-geometry sizes on clip paste
        
        Change-Id: Ie2b308f970673381dfa354620e3394acb44f971f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123869
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        (cherry picked from commit a547f8a1db3c39ad2c84a6bc11cec075ad52c268)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124011
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-10-22  Pranam Lashkari  <lpranam@collabora.com>  [8de04f459611df936c0b315b6d48cb3dbcc1d5fa]

        LOK: introduce way to restrict uno commands
        
        With this new API we can define which uno commands to restrict their functionality
        
        Conflicts:
        	desktop/qa/desktop_lib/test_desktop_lib.cxx
        	include/LibreOfficeKit/LibreOfficeKit.h
        	include/LibreOfficeKit/LibreOfficeKit.hxx
        	include/sfx2/viewsh.hxx
        
        Change-Id: I9f3fd659d373e56542c5323922a53564f1cfb27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124046
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [751fa45b1780f275a7b8fdce52a2fd722e87fcb7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69519a798132d28edb7f1cee5ef7f801b853dcba
          - Fix variable name
            
            Change-Id: I508ae24bb0a38be10eae3b88dbef060b555ef2a4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124043
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [426be29029ffec9a721f83d65d0d320455ff9503]

        return weld::Builder by unique_ptr
        
        Change-Id: Ifa4f5951d200eaad6c8aebd3f29eed053c927ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124051
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Stephan Bergmann  <sbergman@redhat.com>  [de0581c77228eb00ff84a3996bfd252d6928a056]

        Make external/breakpad/ubsan.patch apply again
        
        (It apparently silently broke with something like
        ff673ce838a5538b1432daf9007c047f6455a5ba "update breakpad to the current
        chrome_m90 snapshot" and nobody doing ASan/UBSan builds with --enable-breakpad
        in the meantime.)
        
        Change-Id: Ic955e1725d2493d849b460a09dfa0238815e2c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124033
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-22  Hossein  <hossein@libreoffice.org>  [7ec1ef958855ba7ebff4d3bc623f454015ec5a5c]

        Improve emfio module documentation
        
        * Describe how it works
        * Fix the example
        * Better formatting
        * Fix typos
        
        Change-Id: Ia568ca522453a6c3da1502bd2e7c3a8ce3a29fc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123987
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-22  Michael Weghorn  <m.weghorn@posteo.de>  [51c57b081122f82002b0cca28ccdd464e4a52a54]

        freetype: Build '--without-brotli'
        
        After
        
            commit c99b73c16b725ec2bf2f5417f28d1688c3322d7d
            Date:   Wed Oct 20 12:08:02 2021 +0100
        
                upgrade freetype to 2.11.0
        
        my local Android x86 build (using NDK 20.0.5594570) started
        failing with
        
            In file included from .../workdir/UnpackedTarball/freetype/src/sfnt/sfnt.c:25:
            .../workdir/UnpackedTarball/freetype/src/sfnt/sfwoff2.c:27:10: fatal error: 'brotli/decode.h' file not found
            #include <brotli/decode.h>
                     ^~~~~~~~~~~~~~~~~
            1 error generated.
        
        Disable the optional Brotli dependency added upstream with
        
            commit 9443a1bc3e6cfa315db976ff80f6c5e91b12b387
            Author: Nikhil Ramakrishnan (निखिल रामकृष्णन) <ramakrishnan.nikhil@gmail.com>
            Date:   Fri Jun 28 01:01:17 2019 +0530
        
                Add Brotli dependency and required checks.
        
                Brotli is required for decompressing WOFF2 font directory streams.
                The library is thus being added as an optional dependency for
                FreeType.
        
                * builds/unix/configure.raw: Add checks for `libbrotlidec'.
                (REQUIRES_PRIVATE, LIBS_PRIVATE, LIBSSTATIC_CONFIG): Updated.
        
                * devel/ftoption.h, include/freetype/config/ftoption.h
                (FT_CONFIG_OPTION_USE_BROTLI): New macro.
        
        Change-Id: Iea8d3e333cb60182026fb9fde5a0171ae197ee57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124031
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-22  Miklos Vajna  <vmiklos@collabora.com>  [cc24aca6050d723e2474871ac724d2d5b90d4426]

        sw: remove useless debug code in SwTextShell
        
        A debugger can be used to examine that temporary instead.
        
        Change-Id: I8c04144f5174564e232c5d5effe466ccf5e52468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124037
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-22  Stephan Bergmann  <sbergman@redhat.com>  [df42cb6552b20372f62b5a361709670db80e4ed4]

        Optimize assignment from OUStringLiteral to OUString
        
        ...by making the OUString's pData point to the OUStringLiteral, instead of
        copying the contained characters.  This is one of the improvements that had not
        been done as part of e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn
        OUStringLiteral into a consteval'ed, static-refcound rtl_uString":  "To keep
        individual commits reasonably manageable, some consumers of OUStringLiteral in
        rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now,
        where they don't take advantage of OUStringLiteral's equivalence to rtl_uString,
        but just keep extracting its contents and copy it elsewhere.  In follow-up
        commits, those consumers should be changed appropriately, making them treat
        OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in
        favor of an existing (and cheap to use now) OUString overload, etc."  (Simply
        dropping the OUStringLiteral overload was not possible in this case, though, as
        that would have lead to ambiguities among the various OUString and
        std::u16string_view overloads.)
        
        The now-deleted OUStringLiteral rvalue reference overload means that some
        existing assignments from ternary-operator OUStringLiteral<N> to OUString no
        longer compile and had to be replaced with uses of std::u16string_view.  Those
        had not already been replaced in e6dfaf9f44f9939abc338c83b3024108431d0f69
        because they happened to use OUStringLiteral instances of identical length N in
        both arms of the ternary operator, so did not already start to fail to compile
        back then.
        
        Change-Id: I328e25b8324d045774e811d20a639f40d6a9a960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124040
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e25b8056b25efea0094ef45c315471a7177e7210]

        Removed duplicated include
        
        Change-Id: Ie5f8e53334f060dd99bb55ea034cc0370ea7a6ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124034
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [88e78230dedb0767e2f5067961b66a3858b3b7a5]

        re-arrange BlockInfo a little
        
        so that it is more likely that the interesting data is next to each
        other and thus in CPU cache (i.e. the control fields and the first few
        elements of the array)
        
        Change-Id: I50e46df3f639899e39f1b7733cf8e754d2435b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124038
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-22  Julien Nabet  <serval2412@yahoo.fr>  [116340b2bab8365c08bec532e1a7126b5312e159]

        Use size_t instead of sal_uLong in filter/source/svg
        
        Change-Id: I741307bdecbb6e5104a8fcdf892ea609671ae6fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124032
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-22  Hossein  <hossein@libreoffice.org>  [df93cc61ebf2251b2d41d72a50d72edc2a9e1cb3]

        Remove sax dependency from emfio
        
        Module 'sax' was one of the dependencies of 'emfio'. This is also
        mentioned in:
        
           https://wiki.documentfoundation.org/Development/Build_System
        
        Previously, module 'emfio' was directly depending on 'drawinglayer'
        and 'sax'. But the build is fine when 'sax' is removed from
        'emfio/Library_emfio.mk'. Also there is no mention of sax when
        invoking 'git grep sax' inside emfio folder.
        
        With this patch, the 'emfio' dependency on 'sax' is removed.
        
        Change-Id: Ib6f9dc3df33865b6fc912d02b27b01232a6a3fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123988
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-22  Hossein  <hossein@libreoffice.org>  [dc984e7fed26ed26a2cafecb0c5b27feca56bfe2]

        Converted VCL documentation to Markdown
        
        Converted VCL documentation to Markdown format:
        
        * README.md           Main README file (Added link to other md files)
        * README.vars         Environment Variables in VCL
        * README.GDIMetaFile  GDIMetaFile class
        * README.lifecycle    Understanding Transitional VCL Lifecycle
        * README.scheduler    VCL Scheduler
        
        Change-Id: I15d973b14005a4944f7b5104c5c80184e1083203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123867
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-22  Jim Raykowski  <raykowj@gmail.com>  [58a3e2a6fad68d8d5e6091e063c0b26e3608f998]

        tdf#144999 SwNavigator: Add way to collapse all categories
        
        This patch adds a context menu item that can be used to collapse the
        content tree to the root categories all at once.
        
        Change-Id: I15274e6db838e9e8503a79384bed4ffcf983041c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123811
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-22  Eike Rathke  <erack@redhat.com>  [cb56ec6aa8f03fbc70c808bd4f519ce9d3c21f7d]

        Resolves: tdf#92015 Handle malused *:rfc-language-tag ODF violation
        
        ... and don't let it overwrite existing fo:* tags with less
        information.
        
        Change-Id: I63c223f6bccd682e4173449ddc76c36e8fac6c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124042
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-21  Regina Henschel  <rb.henschel@t-online.de>  [5ab21caf603ba0a1c95bbc94a29eebe3483d1599]

        tdf#145245 correct relative position of extrusion
        
        ODF specifies for draw:extrusion-depth, 'The draw:extrusion-depth
        attribute specifies the depth of an extrusion. It takes two white space
        separated values. The first value specifies the depth of the extrusion
        in units, the second value specifies the fraction of the extrusion that
        lies before a shape. The second value shall be in the range [0,1].'
        
        The default for the second value is 0. Because LibreOffice has no UI to
        change the value, the error becomes only visible, if you create own
        custom shapes.
        
        On import the ODF values are put in CustomShapeGeometry>Extrusion>
        Depth. Method GetExtrusionDepth() calculates from that the length
        values rBackwardDepth and rForwardDepth so that its sum is the depth.
        
        CreateCustomShapeProperties() in escherex.cxx#2699 and
        ApplyCustomShapeGeometryAttributes() in msdffimp.cxx#1684 use them in
        the same sence.
        
        But methods Create3DObject() and CalculateNewSnapRect() in
        EnhancedCustomShape3d.cxx have used these values as if they were
        coordinates.
        
        I have keept the calculation in GetExtrusionDepth(), because it
        reflects the meaning in ODF. I have corrected the signs in
        Create3DObject() and CalculateNewSnapRect().
        
        Change-Id: If275bb263b6f3d790f5893a69f38f8433acfbe7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123997
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-21  Jim Raykowski  <raykowj@gmail.com>  [827c0f9766f148520aed7fe3abe2b138a157a6d3]

        tdf#141634 Special end of para split for folded outline node
        
        After split place the cursor on a new blank line after the folded
        content and at the same level as the split outline node.
        
        Change-Id: I4073a1c0047ab8479993d8e605cc038896cd4630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123747
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0cd8050ec70a4a5f02801cc38e6486defdf83bd7]

        Fix typos
        
        Change-Id: I7e249b2fd01dac96afb03dc0ddca6a1080f190f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124035
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-21  Caolán McNamara  <caolanm@redhat.com>  [5722e85ca0e0fc24c7e9fcd252113717d69b72d4]

        ofz#40166 fix build failure
        
        Change-Id: Ie71b63cbd7e10aff6a9374dcaad24c3153db3bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124039
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [d99428453409b48e089800e4dafdff9cb65ccce2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 08d7c8f595a3d4b4736e2bc993867cbcb4fa71d2
          - tdf#144463 Fix Slide Show help pages
            
            Change-Id: I464f7c4c09bb04f484c94ff29ec1ad63c201eb3a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123515
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [31a7c16c57234e7b0f2fb2a971e8d5ffa19ac83d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2aae6a437951d1029eaeb13fdeaa70ce48ef5e72
          - Fix <embedvar> tags for better l10n (Part 2)
            
            This is Part 2 of the fixes requested by translators concerning the use of the <embedvar>.
            
            Change-Id: I4c846632ded9a7260f86818d7a0eb6257b414b19
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124008
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [e2ab8341b3bb5fc174b48da6b5a3442b82e5cf13]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c37c5f2131d0fe893d7de8995e7deb73262988aa
          - Related tdf#143846 Improve Arabic/Roman help pages
            
            Change-Id: I4be244dba35f137c1b7d356aab658c5e08604e51
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123523
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [7a2316a3d5128ceb16cd62634f110ba81d382217]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f025640e2603ee252a21e935c2790627a2e95224
          - Fix <embedvar> tags for better l10n (Part 1)
            
            This is Part 1 of the fixes requested by translators concerning the use of the <embedvar>.
            
            Change-Id: Iee5ea4289034449c33156d4e20483943eb872ae0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123782
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [79c05d3aef12a300c8d07b570f789023c107708c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 993399c7c55d58bf084234713b07ac6ef8442b03
          - Fixing L10N issues
            
            Change-Id: I45c83f083b861fbe594cb83a82b419aa51b29526
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123786
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fac487cfbb1d6c0bb1b3ccdfe44c4645c7e087e]

        use sal_Int32 in BigPtrArray
        
        now that it's only use-case is also using sal_Int32
        
        Change-Id: I9c51bb8fd6b8f5713b84b1a1f0a216e676a73299
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-21  Miklos Vajna  <vmiklos@collabora.com>  [ea5d4bab6c54432bf590f8650d9f5ea930a0daaa]

        sd: fix inteaction between multi-col shape text and automatic height
        
        Multi-column shape text works by assuming a fixed height, then flowing
        content to a next column once the current one is full.
        
        Automatic height works by first laying out the text and then resizing
        the shape to have a matching height.
        
        When both are enabled, then we used to first calculate the automatic
        height and then lay out the multi-col text using that height. PowerPoint
        takes the height from the file format and lays out the multi-col text
        using that fixed height, and only editing modifies the automatic height.
        
        Fix the problem by not updating the automatic height when we have
        multiple columns, this is meant to improve the stability of the layout
        anyway.
        
        Manual testing shows that editing the text on the UI still updates the
        automatic height, as probably expected.
        
        Based on Mike Kaganski's research - thanks! :-)
        
        Change-Id: Iaf46c6008018b4bf26310322f25788a49c1d27f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123999
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-21  Julien Nabet  <serval2412@yahoo.fr>  [086dc69449fdeb33551f65dd1c3c1c989c4a67f7]

        Typo: pragraph->paragraph
        
        Change-Id: I8363b3f9f4f11e3f7447e8bc0853fa4928f8550c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124030
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [b576cf4260f0c2999f8ef0fbc4bd5755256f2e12]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8e91b3ca199444badbbcca1bb135f30f6e434eb
          - Refactor XHP help files prior to patch
            
            This patch only refactors indentation and headings. No changes are made to help contents.
            
            Change-Id: I7cf71ab26381859d92791d95246e0bb88d8b88a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124007
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f9ffc31cd1b5433c354c7d39ce1d80fa0e57fc8]

        introduce SwNodeOffset strong typedef
        
        for indexing into node children. Replaces various usage
        of sal_uLong, tools::Long, sal_uInt32 with an underlying
        type of sal_Int32.
        
        Also add a NODE_OFFSET_MAX constant to replace usage
        of ULONG_MAX
        
        Change-Id: I2f466922e1ebc19029bb2883d2b29aa4c0614170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-21  Stephan Bergmann  <sbergman@redhat.com>  [81debfba86b1d67d1c2e0ecd9c10ca35c3e7de5e]

        Restrict macOS ARM64 to Java >= 17
        
        The commit message of e529461bcb126e0975ffa3f86e1fd5a630551de2 "Enable JVM also
        on macOS ARM64" had identified
        <https://cdn.azul.com/zulu/bin/zulu17.0.63-ea-jdk17.0.0-ea.27-macosx_aarch64.zip>
        "to work reliably now" while other (older Zulu) JVMs "have always crashed with
        SIGBUS that smelled like our uses of pthread_jit_write_protect_np in
        bridges/source/cpp_uno/shared/vtablefactory.cxx colided with corresponding calls
        in the in-process JVM".  Those observations would be in line with
        <http://openjdk.java.net/jeps/391> "JEP 391: macOS/AArch64 Port" only
        implemented for Java 17 now (see
        <https://github.com/openjdk/jdk/commit/dbc9e4b50cdda35f5712deaf440c49f50b9edc96>
        "8253795: Implementation of JEP 391: macOS/AArch64 Port").
        
        So for macOS ARM64 assume that all OpenJDK variants (i.e., providing an empty
        jvmfwk/distributions/OpenOfficeorg/javavendors_macosx_aarch64.xml) of at least
        Java 17 (i.e., building on recent 3460c16d7f749d8d2a59d8b927df5ec31f64a083
        "Make getVersionInformation always return a VersionInfo" and "change the
        hardcoded '1.8.0' to '17' for just that one platform") work.
        
        Change-Id: I11e8ba232cee066a25a49edebd0cc50e24e84124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123989
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [29489b33b435683021b72cb2bce27aba8cb7a430]

        loplugin:flatten
        
        Change-Id: I3b4226a9d089ec9aedab95d96e50a068f57a76c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123991
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-21  Mark Hung  <marklh9@gmail.com>  [a4244c0f05b95ded277a3a7ed217bf0451daa996]

        tdf#144222 fix pdf export with vertical layout
        
        Remove the offset adjustment that is no longer necessary.
        That was done in every backend before, and has been
        removed now.  We can trust what layout text provides us.
        
        Regression from:
        
        commit dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481
        Author: Mark Hung <marklh9@gmail.com>
        Date:   Sun May 2 15:12:46 2021 +0800
        
            vcl: adjust LayoutText() for vertical writing.
        
        Change-Id: I077f5a5f0711444086e56e4469dbcb3010ffe661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123682
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-10-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6772ed1dcd0a3f89f65375e10cba06544c46226a]

        tdf#144650 crash after opening of read-only file
        
        Change-Id: Ia888ae79940cbc618b2e693d0e658c152346e926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123948
        Reviewed-by: Kevin Suo <suokunlong@126.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2021-10-21  Tor Lillqvist  <tml@collabora.com>  [4a7b8a981d3155427dd669e5409b7f107c5f3554]

        Use NSModalResponseOK instead of deprecated NSFileHandlingPanelOKButton
        
        NSFileHandlingPanelOKButton is defined as NSModalResponseOK in
        NSSavePanel.h:
        
        NSFileHandlingPanelOKButton	API_DEPRECATED_WITH_REPLACEMENT("NSModalResponseOK", macos(10.0,10.13)) = NSModalResponseOK,
        
        For some reason, when as a test I just removed the
        SAL_WNODEPRECATED_DECLARATIONS_PUSH and _POP lines, I still did not
        get any depreation warning about NSFileHandlingPanelOKButton. I wonder
        if there is some problem in latest Xcode or in our build system that
        means we don't get any deprecation warnings at all any more on macOS.
        
        Change-Id: Ia61dd9f800eb7d251508dbd491a9c48c8e6118f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123964
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-21  Stephan Bergmann  <sbergman@redhat.com>  [538ba91535c9f13101c25e49a67e56559f389288]

        Mark external/cppunit/order.patch.0 as upstreamed
        
        Change-Id: Ic0bfacd74e007c979d574e65767cbfb0d40c9ef7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123965
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-21  Stephan Bergmann  <sbergman@redhat.com>  [3460c16d7f749d8d2a59d8b927df5ec31f64a083]

        Make getVersionInformation always return a VersionInfo
        
        ...even for JREs not listed in javavendors.xml, making it default to a
        VersionInfo with sMinVersion = "1.8.0".
        
        3d27b2fa9c5a03f78e5145377402f8a88e3da1be "tdf#124503: Support JRE installations
        with unknown java.vendor property", which had changed getVersionInformation to
        return an optional<VersionInfo>,  said in the commit message:  "For simplicity,
        assume that any versions of such JREs are supported.  Our baseline is Java 6,
        and there are unlikely any older versions of JREs from unknown vendors out
        there."  Our baseline is Java 8 by now, and there are still unlikely any older
        JREs out there, but for macOS ARM64 we may want to restrict to at least Java 17
        implementing <http://openjdk.java.net/jeps/391> "JEP 391: macOS/AArch64 Port",
        and this commit is a prerequisite for such a change (where we would then e.g.
        change the hardcoded "1.8.0" to "17" for just that one platform).
        
        (OtherInfo::compareVersions in jvmfwk/plugins/sunmajor/pluginlib/otherjre.cxx
        unconditionally returns 0, meaning "versions compare equal", so introducing a
        default version of "1.8.0" should have no negative effect on any JREs that use
        OtherInfo.)
        
        Change-Id: I34dc5f2b755c2254a91d42c262786ceec70c746e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123958
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-21  Caolán McNamara  <caolanm@redhat.com>  [9bf469e6e458473f6432d80b31ef76526b5aaa39]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7e8a0824ec5dba8d2c97b0963704f228f1956e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123908
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-21  Tor Lillqvist  <tml@collabora.com>  [33d5c0248039c0b24a2adb4c2d4c1606f05e6278]

        Bin dead code
        
        Change-Id: I2098172d065a195a15b7fd81a34dab25b1f38e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123956
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-21  Tor Lillqvist  <tml@collabora.com>  [f1b5443217c89a577226faa39408acdc807c4fe4]

        Add source files from fpicker/source/aqua
        
        Change-Id: I10e84beb550c9e0410c35fe85db407fa1dceb5b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123955
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-21  Caolán McNamara  <caolanm@redhat.com>  [4b1572b94e5d5b106eddabeb238f5239063e25a0]

        ofz#40166 fix build failure
        
        Change-Id: I18d7993e508763edeb428b583783584afc295efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123953
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-21  Martin Srebotnjak  <miles@filmsi.net>  [ea65215855462e5e48f7a3a78724c38b5fc0e4d1]

        Update git submodules
        
        * Update translations from branch 'master'
          to ef9ad5558c68bdcb52ac8891dc5794ee0a1f7e31
          - Update Slovenian translation
            
            Change-Id: I9063f14a9f9aed24e305f5fb1fc499bfcada5d2e
            
2021-10-21  Tor Lillqvist  <tml@collabora.com>  [ee4fb9c8eb23642a7305cc6bde08cfbe34039d52]

        Fix comment
        
        Change-Id: Ifd1068066c8711a1fa96ff4ede1fa0017a221617

2021-10-21  Hossein  <hossein@libreoffice.org>  [6b558cf6d9be835fe62912ef9f6e312dc1e61aec]

        Add documentation for the 'emfio' module
        
        The module 'emfio' is used to read and write WMF/EMF/EMF+. This is
        the list of topics discussed in the 'emfio' documentation:
        
        * Introduction
        * EMF+ Specifics
        * Limitations
        * Known Bugs
        * Dependencies
        * Tools
        * Related Software
        * References
        
        Change-Id: Iccd1269f62b8099b823d755c84e0ea51a545fae9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123846
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-21  Miklos Vajna  <vmiklos@collabora.com>  [11d2c78df73098989c8e24fcd0d68165953e6166]

        sw: avoid 'else' after 'break' in textboxhelper
        
        Avoids a not necessary indentation.
        
        Change-Id: Idc8fb511b835f93532ae732254ee7815d38c48eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123907
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [4a8184ce0cc59e4e223cf963141c16644b762440]

        tdf#145235: sc_text_functions_test: Add unittest for empty delimiter
        
        Unittest for 45f53338461ba61c53c51a04f99fa281bf5150ae
        < Related: tdf#145235 TEXTJOIN() allow empty delimiter of referenced
        empty >
        
        Change-Id: I9c23a600ebc6842cccc59c6ac15a6da9d049afdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123905
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-20  Stephan Bergmann  <sbergman@redhat.com>  [95c38f6d77f1cb6ff3dc229c5e7130b2e732891d]

        Drop support for dead GNU Java
        
        ...which no longer worked anyway at least since
        aafc10c9edb61e13ac557c7e43c8d4a31dce4f37 "Bump Java baseline to Java 8":
        According to <https://en.wikipedia.org/wiki/GNU_Compiler_for_Java>, the last
        version of GCC providing Java was GCC 6.5.  But trying to add a build of that
        ("Tools - Options... - LibreOffice - Advanced - Java Options - Add...") would
        already have failed before this commit due to a java.lang.ClassFormatError
        ("JREProperties (unrecognized class file version)") when executing the
        JREProperties code compiled with --release 8.  (Whereas now it fails because it
        cannot even determine a JRE installation there according to the SunInfo rather
        than GnuInfo rules used for the now-unknown vendor.)
        
        The <updated> elements of the modified
        jvmfwk/distributions/OpenOfficeorg/javavendors_*.xml have not been updated in
        line with the rules documented at the end of jvmfwk/README.md:  As mentioned
        above, a GNU Java JRE cannot have been selected prior to this commit anyway, so
        even though this is nominally an incompatible change of the xml files,
        actually updating <updated> would only have negative ("just annoying if an
        already selected JRE is still supported") but no positive consequences.
        
        Change-Id: Ica245677dae977360bdb3c6544897eb060c3f844
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123906
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-20  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [67c15910606575b862410179698f81e7a598aa44]

        tdf#125637 - Correctly hand names ending with an underscore
        
        If a name is ending with an underscore at the end of the line, it won't
        be recognized correctly and it will be wrongly interpreted as the
        respective name without the underscore at the end. Instead of changing
        the macro source, use a flag in order to correclty identify the line end.
        
        Change-Id: I6f933d7382b510bffed3e2692d32c232b7084624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123833
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [76513619c14ed131145f0f0440540221a00a8f39]

        make more use of SwPaM::End()
        
        instead of open-coding the same thing
        
        Change-Id: I45ddc87317569c9ad6378eab1067ebea79c583f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-20  Eike Rathke  <erack@redhat.com>  [84304ee068b36c4f545e9e7e761ecde646b02db1]

        ScRefCellValue::hasEmptyValue() already includes isEmpty()
        
        ... so explicitly checking for isEmpty() in an extra condition is
        superfluous.
        
        Change-Id: Id84099a273b80834f0cb080e86991bd67f39babe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123903
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-20  Eike Rathke  <erack@redhat.com>  [45f53338461ba61c53c51a04f99fa281bf5150ae]

        Related: tdf#145235 TEXTJOIN() allow empty delimiter of referenced empty
        
        Like =TEXTJOIN(B1;0;A1:A2) where B1 is empty, this simply
        concatenates content of A1 and A2 with an empty string delimiter.
        Previously Err:502 expected argument was raised.
        
        Also straighten array/matrix element handling and ensure all paths
        deliver a string value.
        
        Furthermore ScRefCellValue::hasEmptyValue() already includes
        isEmpty() so the extra check is superfluous.
        
        Change-Id: If761aa91df78c6b26fbfd626629e07860636e718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123897
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-10-20  Xisco Fauli  <xiscofauli@libreoffice.org>  [56d750a5c0f857aedf036f0cd49cfad2de9238ae]

        tdf#145235: sc_text_functions_test: Add unittest
        
        Change-Id: I27e04ab776923c300831062bbeede8d831a54245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123895
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [5d05355039ee11f4ba6429d4781d030900c3a829]

        upgrade fontconfig to 2.13.94
        
        Change-Id: I5914c16db85c688b38575f510a44c7ddb043d2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123888
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [6ae257e3fc7f07daab1ad8614f934f9027b0a604]

        upgrade glm to 0.0.9.9.8
        
        Change-Id: I39ca17984cc03de815386343b2f4c4fffd5c861e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123891
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Tünde Tóth  <toth.tunde@nisz.hu>  [f138cc8fff47c4bb4fc361698bc788dd360a7dd7]

        tdf#144996 XLSX export: keep permission for editing on save
        
        The password for editing lost on Save, breaking the workflow
        with newer MSO versions, i.e. after saving, it was possible
        to modify the file on its original path without password.
        
        Manual test:
        
        - Open an XLSX document with permission for
        editing e.g. created with Excel 2019 or newer;
        
        - Choose Edit->Edit Mode and give the permission for edit
          with the requested password;
        
        - modify the file, and save it with File->Save. The file
          workbook.xml keeps <fileSharing> with the original hashValue,
          saltValue and spinCount.
        
        Change-Id: I6ad96a474c8e0ede7d5994a54f017d565e0c0f94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123435
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-20  Tor Lillqvist  <tml@collabora.com>  [fd7f17ca580888044050fbf25df65354ba12d4ca]

        Run testODFX509CertificateChain first because otherwise it fails on my Mac
        
        Sure, it would be better to figure out why it fails.
        
        Change-Id: I4c9e8aa0a9a3cd421de08ec9c9ea2dcb1a242ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123875
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-20  Eike Rathke  <erack@redhat.com>  [f4f2c94513e7d06691a73d9f12707c33d131d537]

        Resolves: tdf#145235 TEXTJOIN() clear last string also for referenced empty
        
        Change-Id: If6d20a1629e001708c700c5c25bef8a75fa34e25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123889
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c175c1dc19d0edc8ca66e39f0b4b8af04e3d6c87]

        svx: Don't end text edit mode for all views
        
        This allows multiple views to not disturb each other editing inside
        a impress document. With the ending of text edit for all views still
        enabled, one view can cancel other views text editing just by moving
        or resizing a unrelated shape in the document.
        
        To make this possible we also need a view-local undo manager for
        the text edit mode, which is independent of the document undo
        manager. When the text edit mode ends, all the changes will be
        added as one change to the document undo stack. This prevents any
        conflicts in the undo stack that could be made when 2 views are
        editing the same document at the same time.
        
        This also adds the test for the new use case and changes the existing
        tests to reflect the change.
        
        Change-Id: I04edb4f91d7e111a490c946f7121cbca75f818d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123220
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [85d53dafd8332fc9c7bf71d6cc9da19ab9d8e252]

        vcl: test OutputDevice::DrawGradient()
        
        Change-Id: Ica59cdc5f9164892e390143e86946a0bebde525c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122997
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [a9dfe0187f21dce9d7cee4c4e938d8592073e09c]

        vcl: move variable declarations closer to first use in DrawBitmapWallpaper()
        
        Change-Id: I9ad0711480e9626298e643609eaeb2c9da377405
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122978
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [3667da75208e6ccc6deb927555c861ddb3d34dd5]

        upgrade liblangtag to 0.6.3
        
        langtag-valencia.patch.0 merged as:
        https://bitbucket.org/tagoh/liblangtag/commits/fe35532a0b98d5a8179b9edee0d61ea8db9b5921
        
        external/liblangtag/Wformat-overflow.patch redundant since:
        https://bitbucket.org/tagoh/liblangtag/commits/49135ef561f309078f0bfd6e1f15052769cf75b4
        
        Change-Id: Ieeb19679837f03a6938c97f069d6fb1e6dd9a30d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [283a9790bffa6536f4c26bd31d85f815bc64dd08]

        loplugin:indentation check for indent inside block
        
        look for places where the statements inside a block are
        not indented
        
        Change-Id: I0cbfa7e0b6fb194b2aff6fa7e070fb907d70ca2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-20  Stephan Bergmann  <sbergman@redhat.com>  [18bdf78e156f3cd1e6ccbb3ae28e919583bac70c]

        Azul is just another OpenJDK variant
        
        ...so there was no good reason for 0f95f8ffd7a3685ca53876005a9c96f2e2e7bc99
        "Support Azul Zulu JRE (at least on Windows)" to map it to OtherInfo rather than
        SunInfo.  (That way, it benefits from SunInfo::compareVersions's proper
        implementation, unlike OtherInfo::compareVersions which always returns 0.
        Although trying to add e.g. the too-old Java 7
        <https://cdn.azul.com/zulu/bin/zulu7.50.0.11-ca-jdk7.0.322-linux_x64.tar.gz>
        would already have failed before this commit due to a
        java.lang.UnsupportedClassVersionError when executing the JREProperties code.)
        
        This also reverts all the "needed by Azul" additions in
        OtherInfo::getRuntimePaths; it is unlikely that any of the other JREs using
        OtherInfo silently also benefited from them, and JREs of unknown vendor use
        SunInfo (which does have those two paths already, as they are not only needed by
        Azul there).
        
        Change-Id: I4af9b4b9e65cd2346011522c105cfc62ec59f552
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123874
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [c99b73c16b725ec2bf2f5417f28d1688c3322d7d]

        upgrade freetype to 2.11.0
        
        Change-Id: I794e188daf2d50c457a80bc3b12bfafd0c91c8aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123887
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [9574b70e5430b89d49e01e92e8fda0d674144706]

        upgrade lcms2 to 2.12
        
        Change-Id: I40c3239495c6050add3ce2343453241f8c825d62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123886
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Hossein  <hossein@libreoffice.org>  [40c9f83a82e45e5aa626811ce065d8b1b13b54b6]

        mtfdemo: Dump metaactions, fix problems with repaint
        
        * Now mtfdemo can dump metaactions as metadump.xml in the current
          folder if the -d option is added in the command line. For example:
        
            ./bin/run mtfdemo -d odk/examples/basic/forms_and_controls/burger.wmf
        
        * Previously, the demo had problems with display, and when a repaint
          was requested, the display was stopped. Now, each time a repaint
          is requeted, the metafile is read again, and the paint works fine.
        
        * Now mtfdemo supports relative path. Previously, file name had to be
        absolute to work.
        
        Change-Id: I01bcbd38be682a55021e787a60b4dc86f596083a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123574
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [754ab4b0653534347f647a667c8865a1ef4677a9]

        upgrade libepoxy to 1.5.9
        
        removed epoxy.pyresource-leak.patch in favor of upstream
        https://github.com/anholt/libepoxy/pull/243/commits/d0b319e27b874a13f6b41f4759c272b08d74cb8a
        
        Change-Id: I9d3545b1dcf9dbdd5e28a54e13477a027636c444
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123882
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [a08d1dc4ee904428ef6f78208cc2508d3fc3717b]

        upgrade curl to 7.79.1
        
        includes:
        
        CVE-2021-22945: clear the leftovers pointer when sending succeeds
        CVE-2021-22946: do not ignore --ssl-reqd
        CVE-2021-22947: reject STARTTLS server response pipelining
        Change-Id: I0047bdaa7e6e3aed1317eb014d2051a4d5ac5964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123883
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e735d53201da924dfafc1707a23395fad5d42ba2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9bbd8047b2f9e5b4a0ae8fdc1dab298b38c50e2
          - Break long line in table
            
            Change-Id: I89bd017d7d9070e7927f63fa85e6d17baf2ee706
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123851
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [733623d6d4de6ed3441269e3ecf3ed86066735c2]

        combine these contiguous ranges
        
        Change-Id: I5f2b4ae72599fb16d567b3500fd1a77811e708a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123881
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  László Németh  <nemeth@numbertext.org>  [ec577f566fa3e6d2666069180f8ec8474054aea9]

        tdf#145233 sw track changes: show moved text in green color
        
        and with double strikethrough or underlines during
        change tracking to speed up reviewing, e.g. re-ordered
        list elements or changed paragraph or sentence order
        is more visible this way.
        
        Note: skip terminating white spaces of the changes
        during recognition of the text movement, as a
        workaround for a typical difference resulted by
        e.g. Writer UX: selecting a sentence or a word, and
        moving it with the mouse, Writer removes a space at
        the deletion to avoid double spaces, also inserts a
        space at the insertion point automatically. Because
        the result can be different (space before and space
        after the moved text), compare the changes without
        terminating spaces.
        
        See also commit bcdebc832b272662d28035007a4796e42d1305ae
        "tdf#104797 DOCX change tracking: handle moveFrom and moveTo".
        
        Change-Id: If2a16f1f43315ecab659b24425692ac14bcda619
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123814
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-20  Tibor Nagy  <nagy.tibor2@nisz.hu>  [378e8396223a80b96262d7b638a066eb83ba88d6]

        tdf#144917 PPTX import: fix hyperlinks on grouped shapes
        
        Hyperlinks on the shapes of a group shape weren't imported.
        Now all of them are imported correctly.
        
        Change-Id: Ic42892650a3492958600232bd7038585f9aa6ae1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123127
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [649e29e53f9a79d8695b31b9a848fba14d6b583d]

        assert in math, file, printer settings, options
        
        probably since...
        
        commit 1a0fd1c1342969e5b4d08d13764483cd8bada589
        Date:   Fri May 14 13:46:41 2021 +0200
        
            tdf#130654 editable smeditwindow zoom UI
        
        Change-Id: Iead2fd9b5332a9cfead8d4e0d909746d6ed50db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123879
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [317b9f31231cadc740cf23cc4d7c8e2b24324825]

        Breeze: tdf#144036 UNO Object Inspector icons
        
        Change-Id: I4b5cf4006bb344e36911f928187729579bd86253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123873
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-10-20  Michael Stahl  <michael.stahl@allotropia.de>  [332eff5c5c4f49557427be3d6eb126a55eec343b]

        nss: upgrade to release 3.71
        
        * external/nss/nss.getopt.patch.0: fixed upstream
        * external/nss/nss-win-arm64.patch: fixed upstream
        * external/nss/nss_macosx.patch: one hunk was fixed upstream
        
        Change-Id: I2bcfbbdd29651c75537419caab9a3cce5d564131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123817
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-20  Miklos Vajna  <vmiklos@collabora.com>  [0d0439b816c05e1af9f56d545c9b5e574f4100f5]

        CppunitTest_sw_ooxmlexport12: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I329f90a6e0dfffe1d8a5d4f80b8cfa1f21e8d919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123832
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-20  Michael Stahl  <michael.stahl@allotropia.de>  [a86b0e83177f15320c4fe2906a0a02486ba60d49]

        framework: allow tests to run with read-only $SRCDIR
        
        SfxMedium constructor will call QuietInteraction::handle()
        which invokes abort(), so can't load any documents.
        
        (regression from commit 95eb088802562b75f8b299908160145c7e88d763)
        
        Change-Id: I7958ad30a06ffea299d70a9a8132eb9ffcf33f43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123834
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [569a389f977faa347ae472167769cdc1718a0118]

        gtk4: make starmath edit and math widgets visible
        
        [GtkBox's expand child property] can be replaced by setting
        GtkWidget:hexpand or GtkWidget:vexpand on the child widgets. To match
        the old behavior of the GtkBox‘s expand child property, you need to set
        hexpand on the child widgets of a horizontal GtkBox and vexpand on the
        child widgets of a vertical GtkBox.
        
        Change-Id: I72ebb77cbd92001842abee77a23dcdf6aa1b7a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123842
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Caolán McNamara  <caolanm@redhat.com>  [43b399cfa30949ec884d3bddb32f89a524e8f227]

        add suggested-action to some buttons
        
        Change-Id: Iacb477c17f1c8ac68b331705796e56b4c92292cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123835
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5c16ac64ef02481ccf19b65f5702caf4b67b888d]

        tdf#129209 Doc't XInfobarProvider.idl
        
        Add examples in .idl file
        
        Change-Id: Iea12d3088ec0006731b16e9009008fbe5793f33d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123868
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-20  Heiko Tietze  <tietze.heiko@gmail.com>  [279cc2aa9d8e5e53762352415c05c262fb1d906f]

        Related tdf#145037 and tdf#145028 - Animation sidebar usability
        
        * Splitter to resize available vs. applied animations
        * Label on the Add button
        
        Change-Id: I0321d35a4c7e796c0732560b34a0bc18fb104e6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123741
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-10-20  Jim Raykowski  <raykowj@gmail.com>  [cf8de077f885b7632967c8bdfde98279d98f4cce]

        tdf#74604 tdf#54412 Make recency work for hyperlink, field and footnote
        
        cursor position changes
        
        Change-Id: I451cb5a538fd4baf00282238741011c6d4fc17b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123793
        Tested-by: Jenkins
        Reviewed-by: V, Stuart Foote <vstuart.foote@utsa.edu>
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-19  Julien Nabet  <serval2412@yahoo.fr>  [5b20bb65363812388123d36f741e47b6195dde6b]

        tdf#145203: FIREBIRD cannot create a table
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=1cf57765dd9a66982ecf9cd33687005a70c70c3f
        2021-10-08
        loplugin:moveparam in connectivity
        
        Change-Id: Iec0fa1597e63d42ee3a905bf55eff798b3f46177
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123787
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-19  Eike Rathke  <erack@redhat.com>  [f7f1763727b23fb84717e83978c2c0b2c66b9f55]

        Resolves: tdf#145173 Add English (Israel) {en-IL} locale data
        
        Mainly inherit from he_IL but the calendars from en_US that also
        already define the Jewish calendar items with English names.
        Jewish calendar date formats also from en_US LC_FORMAT_1.
        
        Change-Id: I0907898190adcd46687ca1308fe6785fd9c9c4ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123845
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Eike Rathke  <erack@redhat.com>  [607bc9fe13741d034ed2638e70b3ea0429fff039]

        Related: tdf#145173 Sort he_IL by formatindex and split NatNum to LC_FORMAT_1
        
        ... keeping all LC_FORMAT as non-NatNum elements and separating
        all NatNum into LC_FORMAT_1, to be able to separately inherit
        LC_FORMAT.
        
        Change-Id: I42387432205862ca6416e6a3d020a923408c7b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123844
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Eike Rathke  <erack@redhat.com>  [5a92f17d293d2b0b1beee5d16d0b2b1ee7fc6ce3]

        Related: tdf#145173 Handle two independent ref=... for LC_FORMAT...
        
        Change-Id: I6313d9e573e653c9a97171ca8c2f6176d7ad6a3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123843
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Stephan Bergmann  <sbergman@redhat.com>  [905f1b2ed835b9a72905ad7326ecfd4ef1cb304a]

        Improve an error message
        
        This was useful in tracking down d425cd604cb4d30862640851b11a31e742d81336
        "Revert incompatible ScriptEditor change".
        
        Change-Id: Ifc9e262b5860663dd64e5558534170ea0a8c5562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-19  Hossein  <hossein@libreoffice.org>  [47728bb925b33a8fe536fed8c913a2669bf101b6]

        Use range based for loops
        
        * Use range based for loops where it was possible in drawinglayer
          + Goal: Better readability of the code
        
        Change-Id: I188d27ce09c0d603e39d40ea63e91a8666e5d885
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123758
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [3e6d1bfc645a3d97a7d9fac1db429cf8cc5c287e]

        gtk4: resave textunderlinecontrol.ui with latest glade
        
        to move unparented GtkImages to the top so they are where the gtk3to4
        conversion can easily find them during parse so decide whether
        GtkPicture or GtkImage is the right choice.
        
        Change-Id: I03f95befcd347c0fa77b617aa9125a6708b0090c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [ba43b65c4b414152c4663426f0e19beff3f84d12]

        emfio: remove unused file
        
        Added in e179e53e3c703153bb0bb3155c1c6e2d25577fe0
        <EMF: tdf#138467 Fix MapMode translation>
        
        Change-Id: I4f326c95f279e4e1925f3e4324f904f81a361fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123823
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-19  Balazs Varga  <balazs.varga991@gmail.com>  [0361f8620cc0c6bdc27d6f4daa9593650a755e5a]

        fix crash of OOXML export of deleted, empty range names
        
        since...
        
        commit 12ee423c7549ddd2b86dfc3fc6fed2c617dcca7f
        Date:   Mon Sep 13 12:17:37 2021 +0200
        
            tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulas
        
        Change-Id: Ib5591d2a680cb58d248cf4e8fa4a4cbe777002f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Eike Rathke  <erack@redhat.com>  [29c41568f1df622e4132a2055698255e01597902]

        Related: tdf#145173 Add English (Israel) {en-IL} 0xB409 to language list
        
        Change-Id: I0c1d89a8869e3788f18851ae004bac24275923b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123829
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Stephan Bergmann  <sbergman@redhat.com>  [4fcb64b79f89c7589c7ca2748945603877bf1770]

        loplugin various (clang-cl)
        
        Change-Id: Ib9bd9b96d28c9c4dd0fa36a82a177e119aa04e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123820
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-19  Michael Stahl  <michael.stahl@allotropia.de>  [395c0c0bbaceadf909e0189af99c6358487c7978]

        xmlsecurity: fix --without-system-nss usage of NSS_SetAlgorithmPolicy
        
        The problem with commit ff572d9222ec16ffd679ae907a0bf4a8900265e1
        is that it's using the wrong library; NSS_SetAlgorithmPolicy is actually
        in libnssutil3.so.
        
        This causes a linking problem when upgrading the internal NSS to a
        version that has NSS_USE_ALG_IN_ANY_SIGNATURE.
        
        Change-Id: I954d88062c38881bc721bdf052db4f7b55888aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123819
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [cd06fbfe4f03811b2a04e2772521bab234329b58]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 08deb44ef2fdac4a1e173da75c9cdc1dfe289c61
          - Refactor database Help files (connection wizard)
            
            Change-Id: I2d924cb3611d8749ed1e19d9321b1f230697412e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123831
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-19  Kevin Suo  <suokunlong@126.com>  [a0c23b40905d7b59caf46fc8887864ab35142522]

        tdf#96499 sc htmlimport: fix broken CSSHandler so that...
        
        ...ScHTMLStyles can handle those MSO-Number-Formats again.
        
        The CSSHandler was added by the following commit, after which the
        sc htmlimport can parse the CSS stylesheets and set number formats
        of table cells accordingly:
        
        commit 24d8e4eaf4543c5b39b9e816d8514525b098827d
        Author: Kohei Yoshida
        Date:   Thu Jul 28 00:46:55 2011 -0400
            Parse CSS in the <style> content and set number formats to cells.
        
        However, this was broken since "selector_name" does not no
        longer functions in the handler since upgrade to orcus 0.9:
        
        commit edb38d702dd5a058ae0702b73a43328318b94649
        Author: David Tardon
        Date:   Thu Jun 4 16:09:48 2015 +0200
            update to liborcus 0.9.1
        
        And further the selector_name was then removed by the
        following commitd due to loplugin:unreffun checks:
        
        commit c76a8580c62299f310e7e43927afc133e2f02350
        Author: Miklos Vajna
        Date:   Fri Jun 5 12:29:36 2015 +0200
            sc: loplugin:unreffun
        
        commit 9eeac5506bd726350b51cb0c36606646f04cbae9
        Author: Miklos Vajna
        Date:   Fri Jun 5 12:32:10 2015 +0200
            sc: another loplugin:unreffun
        
        And then this was further broken by the following commit, in which
        it removed the mrStyles of type "ScHTMLStyles" from the CSSHandler
        class:
        
        commit 5d86154f49d713dada4aaa541755076cfeefa2c6
        Author: Noel Grandin
        Date:   Tue Sep 18 09:57:26 2018 +0200
            loplugin:unusedfields improve search for unused collection fields
        
        This patch partially reverted those code, revised the
        CSSHandler member functions to make it work. More handler
        functions need to be implemented.
        
        Note that this bug is still not resoved yet because the orcus
        css parser does not accept css strings to include unquoted
        non-ascii chars as property values. This will be addressed in
        a separate patch.
        
        Change-Id: I8883f5a9362d9476dbfa9a2eed283c6f5c18305d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123715
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-19  Tor Lillqvist  <tml@collabora.com>  [dc3d2a2dcc47a1220db43f1807d234a06fb78fe9]

        Bump tolerance from 30 to 40 to make this test pass on my Mac
        
        Assuming that the original 30 was just an arbitrary number that
        happened to work on the developer's machine, and for reasons a
        slightly larger tolerance is needed on mine.
        
        Change-Id: I08fe883dbe2eb88b7903019a71b689b539b085a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123810
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-10-19  Luboš Luňák  <l.lunak@collabora.com>  [6ee4ce119b55d6e415696b23432fe65eabc94c17]

        consider font when caching SalLayoutGlyphs in calc (tdf#143978)
        
        d62ad3efe3c8778cfd added the caching, but did not consider that
        the used OutputDevice (its font) may change.
        
        Change-Id: I291999d3613b7ba161e3d82348f621aa84a93067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123809
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-19  Michael Stahl  <michael.stahl@allotropia.de>  [ff572d9222ec16ffd679ae907a0bf4a8900265e1]

        xmlsecurity: fix test failing because NSS policy forbids SHA1
        
        With Fedora's nss-3.71.0-1.fc34.x86_64 there is the problem that
        8 tests including testODFGood in CppunitTest/xmlsecurity_signing
        fail because the crypto policy disallows SHA1 for signatures.
        
        Apparently this particular policy bit was added in NSS 3.59:
        https://bugzilla.mozilla.org/show_bug.cgi?id=1670835
        
        For signatures, maybe it's not a good idea to override system policy
        for product builds, so do it locally in the tests, at least for now.
        
        Another option would be to set NSS_HASH_ALG_SUPPORT environmental
        variable to something like "+SHA-1".
        
        If similar problems turn up for encrypted documents in the future,
        that should be fixed in product builds too of course, as encrypted
        documents must always be decryptable.
        
        Change-Id: I4f634cf5da1707fb628e63cd0cdafebdf4fc903f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123678
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [e95bcf952abfcde18caca2058260e9213003df8a]

        Related: tdf#145169 missing path separator in gio create folder
        
        Change-Id: I7fa98e05261b6c1ff7c053b5f563ea97bd67ed00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123800
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Justin Luth <justin_luth@sil.org>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [67a3ea1852a73a25980250473b0fd43a8392f779]

        Related: tdf#145169 warn on overwrite from gtk "save as" for remote files
        
        Change-Id: Idb98cd13826b6a4bdcbeee4e91dc8678f148dbdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123815
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2021-10-19  Stephan Bergmann  <sbergman@redhat.com>  [5e8479a38f0c342979520018f79a6f79d40e99e3]

        Remove a std::remove_reference_t
        
        ...which is unnecessary (short of dubious explicit invocations like
        `makePropertyValue<int const &>(i)`) as T can never be deduced to be a reference
        type there.  And add some test code (that also tests the bit-field scenario
        mentioned in the commit message of 23cded985ba0131f85ee445492c04871fbfb6351
        "Specialize comphelper::makePropertyValue for arithmetic types").
        
        Change-Id: If41ce20ab643041dd9721d05373eeb32fd099ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123805
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [bc2fca254f8a9d7ca5eb156b7e3c19756a257e3b]

        Related: tdf#145169 use of freed pointer in gio create folder
        
        Change-Id: Ia5afdfb545791e143b8d34193de95e30b8f054b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123799
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [3859878f0e8c4dc212d952a156b83d1ba913f7f1]

        Related: tdf#145169 make double-click call same handler as ok button
        
        so that the user is asked to confirm an overwrite of a file
        
        Change-Id: I1340fb33559b68c28fc91e272f05e122f8c519ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123806
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2021-10-19  Miklos Vajna  <vmiklos@collabora.com>  [05f1990cbdcd99f7ba4863b91a8f1f298b56326a]

        writerfilter: give up if body text is missing
        
        Crashreport trace:
        
        writerfilter::dmapper::DomainMapper_Impl::DomainMapper_Impl(writerfilter::dmapper::DomainMapper&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, writerfilter::dmapper::SourceDocumentType, utl::MediaDescriptor const&)
                writerfilter/source/dmapper/DomainMapper_Impl.cxx:359 (discriminator 2)
        writerfilter::dmapper::DomainMapper::DomainMapper(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, bool, writerfilter::dmapper::SourceDocumentType, utl::MediaDescriptor const&)
                writerfilter/source/dmapper/DomainMapper.cxx:113
        writerfilter::dmapper::DomainMapperFactory::createMapper(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&, com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, bool, writerfilter::dmapper::SourceDocumentType, utl::MediaDescriptor const&)
                writerfilter/source/dmapper/domainmapperfactory.cxx:34
        ollaboraoffice6.4/program/../program/libwriterfilterlo.so
        RtfFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
                writerfilter/source/filter/RtfFilter.cxx:152
        
        I.e. we end up in a situation where the insert position does not have a
        containing XText. It's hard to continue from that point and this is in
        the ctor of the dmapper, so we didn't start the import. Just throw an
        exception to avoid further crashes.
        
        Change-Id: Idb5c06186a82c00b838d0b3330260340eb4218b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123795
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [8154131ca8ae47fda4928b56ba622634bae8fe01]

        Related: tdf#145169 append null on unknown property
        
        otherwise the next known property will appear at the skipped unknown
        property, resulting in "true" for IsHidden getting used as "TargetURL"
        
        Change-Id: I0797db9eab94c175b5cc32c66051a1aa35be99c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123804
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [db1a3c657ec3f9c153a9a7b2b35ac652a4f229fb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e91f2d953177c5de27081c9e4485cc08c9e69ed7
          - Remove whitespace in heading ids
            
            Change-Id: I16631a67b01e1df2567330a63a302164154b5076
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123808
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2021-10-19  Justin Luth  <justin_luth@sil.org>  [7bed55bc0b4ebb26fa8de5e3e38716d2febd0eb7]

        related tdf#145190 gio_mount: show username when requesting password
        
        It is always nice to know WHICH password you are being asked for.
        When a remote open/save service exists (without a saved password)
        then the password request immediately pops up and nowhere is there
        any indication which service / username the password is for.
        
        This still doesn't indicate which hostname/service this is for,
        but better than nothing at all.
        
        To avoid causing any regressions, this was done only when a
        username was explicitly passed along. In the case where a
        previous password was guessed, that is kept as _NA.
        
        [aMessage provides "Enter password for <user> on <host>"
        but that duplicates the label "Enter user name and password for:".
        So we don't seem to have much to work with here.]
        
        Change-Id: I0991c76ed1ce625ef354009fb416f1058cbeb313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123746
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [3b3154f6c2517155b1253ce9ff773c470bb31093]

        tdf#145216 remote open/save dialog: icon view shows nothing
        
        since...
        
        commit b004a1bd7bf3885613d52aba70dea79766eae639
        Date:   Sat Nov 23 19:14:45 2019 +0000
        
            Resolves: tdf#128940 use a normal MenuButton
        
        Change-Id: I7ba6424a2a4892e2d6bc5552105a3b1e37d21a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123798
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [414016a0d390701d6e3e0b81febaf06a1b724bca]

        can reduce scope a little
        
        Change-Id: I19f5422ad7c72b5fcd11b507e7a2e22e34dde4c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Caolán McNamara  <caolanm@redhat.com>  [f5dbf927bf44c9a1ac80eae6f72887a4f3543201]

        Resolves: tdf#136498 %PRODUCTNAME shown in tool tips
        
        Change-Id: Id9640f9b5f85a98a510307bc7debf51448c716e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-19  Eike Rathke  <erack@redhat.com>  [80b5d83f8ac858fddb32d2d72d1c2d4f3c64b32a]

        Ditch that CharClass constructing ToLower() nonsense
        
        ... and use SvtSysLocale CharClass instead.
        
        Change-Id: I300c3e8ffb1502ef4303cba859dc0b8311be54ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123788
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Julien Nabet  <serval2412@yahoo.fr>  [c1c6eea1c11d9711e101fc76efa0ec4460e8e448]

        Following 3abbb1486f09b377084c3232a921772302ab34ec
        
        Not need to use Sequences here
        
        Change-Id: I2507566f5939dbdcb5d2ab420f16a55d4cc403b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-19  Julien Nabet  <serval2412@yahoo.fr>  [b7e7fee238dc250e7ab6e8e8fef4a6b15430c90c]

        Leftover from 4477baeba5aec71098f374cf0b4bd4591e048809
        
        ... Simplify Sequences in xmloff (+ merge 2 SetError)
        
        Thank you Mike for having spotted it! :-)
        
        Change-Id: I532520aff6999a30a8b41dc95ff5eeb1086a21c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123791
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-19  Stephan Bergmann  <sbergman@redhat.com>  [af2d15a494b42faf4367096af07c7a2b2d22642e]

        Fix Windows build
        
        ...after cf3971a9414f52b116c1c21f267128ffa67f171b "Simplify Sequence in b*"
        
        Change-Id: If8650faa7a45258729e54b3df37e9084221babfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123792
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-19  Jim Raykowski  <raykowj@gmail.com>  [40458226fda358bd90c25ddfe6a9b2cf25b2fcad]

        tdf#113512 Writer: 1.15 line spacing UNO command
        
        Resolves the Writer 1.15 line spacing part of the request for 1.15,
        2.5, and 3 line spacing UNO commands.
        
        Change-Id: I2a654063df3549e8a23021bc4fc76bc17c270d69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123569
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-19  Ross Johnson  <ross.johnson@homemail.com.au>  [672b4c155766e9bf18e109e92f3e8cc71a52e21d]

        tdf#144572 - fix incomplete labeling of Pivot Table UI elements
        
        Created an additional alias of .uno:DataDataPilotRun, of which
        .uno:InsertPivotTable is already an alias, called
        .uno:InsertPivotTableNBLabel for use in the NoteBook UI styles.
        
        ContextLabel didn't appear to apply to these instances, they
        must be considered sub menus even though they appear not.
        
        Change-Id: Ic526adbf8ed4ad47524426430a47229c8ed919cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122911
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-19  Miklos Vajna  <vmiklos@collabora.com>  [63007619da7e6c4a6d0c466a8fe54324252be14b]

        tdf#144798 DOCX import: handle ZOrder of chart objects
        
        Regression from commit 10efab2b9a3cf7fc49655c90ba29db4512680c38
        (tdf#82824 DOCX import: fix at-char embedded object handling,
        2016-11-15), the problem was that if we start supporting anchor types
        other than as-char, then handling ZOrder is no longer optional.
        
        Change-Id: I605cee33180490817055978b22f3271b3c08a1c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123757
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-19  Eike Rathke  <erack@redhat.com>  [b582a76d7cc20adb8440830ffd1597258d2d6a4a]

        Use MsLangId::getConfiguredSystemUILanguage()
        
        Change-Id: Ia9344c44a71be656a731ab8735dd8e959e520592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123789
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-19  Eike Rathke  <erack@redhat.com>  [e3c3c3b84ef6b91f89a5e388e6538f18a2e8b13e]

        Use MsLangId::getConfiguredSystemLanguage()
        
        Change-Id: I298f762ac7f3298aa9cb9621ad1f8cae50527b24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123790
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-18  Eike Rathke  <erack@redhat.com>  [20081a8ea052b2f31915bd127c3b282cf5025d59]

        Introduce MsLangId::getConfiguredSystemLanguage()
        
        To be used instead of getSystemLanguage() in a subsequent change.
        For details see commit summary of
        
            commit aec5312ffab24236876693d7a8b55843847f2a48
            CommitDate: Mon Oct 18 21:14:24 2021 +0200
        
        	Related: tdf#145173 Ensure known supported system and default document locale
        
        Change-Id: I5bed125e47c2a03fe2e7a4f84988b2e8841143c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123766
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [c7f0fddb4a1a0dcc0dd21d2a27d67d4e75a8195c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic38cce29011d7cce80d84f98792c9f7147cd0dd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123763
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Eike Rathke  <erack@redhat.com>  [aec5312ffab24236876693d7a8b55843847f2a48]

        Related: tdf#145173 Ensure known supported system and default document locale
        
        For an unsupported locale like {en-IL} that could had ended up as
        language-only {en} if the aImplIsoLangEntries map contains such
        entry as obtained through
        MsLangId::convertUnxByteStringToLanguage() and
        Conversion::convertIsoNamesToLanguage(). For the system locale in
        SvtSysLocale a proper fallback is used but the default document
        language was propagated as is
        
        Other places evaluating MsLangId::getSystemLanguage() are affected
        as well, those probably will have to be replaced by a call to
        MsLangId::getRealLanguage(LANGUAGE_SYSTEM) or a newly to be
        introduced MsLangId::getConfiguredSystemLanguage() and
        MsLangId::getSystemLanguage() be made private or accessible only
        by LanguageTag.
        
        Change-Id: I87eb9456d5b4ea8d64b0c41fec6bd2739256fb56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123756
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-18  Julien Nabet  <serval2412@yahoo.fr>  [3abbb1486f09b377084c3232a921772302ab34ec]

        Fix nb of tokens in XCUBasedAcceleratorConfiguration::reloadChanged
        
        and use 4 like XCUBasedAcceleratorConfiguration::impl_ts_load
        Indeed, there can be:
        - SHIFT
        - MOD1
        - MOD2
        - MOD3
        
        Change-Id: I1e206a6cb74761165b60887e768fa9b057c4b242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123722
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [c263a01a47a0a2521f50feb9544b51e78399a78c]

        Related: tdf#145169 change to selected dir on remote "save"
        
        if a dir is selected then try to change to that dir
        when save is clicked instead of saving using that as
        basename, which is consistent with standard fpicker.
        
        don't change the contents of the Entry, leave it alone.
        
        Change-Id: Id19fbf0f3ef2b8220059a1fa166b7783feb8d57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [3c168b1dc876e4fca97f73683572462a29227523]

        Resolves: tdf#145169 only position treeview cursor at the first entry
        
        when the view is filled, don't actually select the entry.
        
        With these single selection trees the default is to select when the
        cursor is positioned, so move the unselect to after the cursor
        positioning to achieve this.
        
        Now nothing is considered "selected" in the view unless the user
        explicitly does that so the contents of the entry are used by default
        on save/load because nothing is selected in the treeview unless the
        user does that.
        
        Change-Id: I2a740616205bab35614f85f62e8240cd11df90ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123754
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [d989619895a1215d0f701247d5d8368069da8962]

        tdf#145169 have one button per response
        
        not two sharing the same response, so the other buttons response
        handler is not a candidate to be called on pressing return
        
        which is the circumstance which causes the dialog to return even
        after cancel was selected in its child dialog warning about overwrite
        
        Change-Id: I09eb0ea5e94c89ce0860be362e1c7632887e7a4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123753
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [ed92e40aea759d435ec1c05877e6480654a06ab6]

        vcl: test OutputDevice::DrawPolyPolygon()
        
        Change-Id: I166f715489ecff3095ccfb485153629050bfca20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122977
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-18  Regina Henschel  <rb.henschel@t-online.de>  [9142d19ddc751e05041471aa1bbeca2f06729522]

        tdf#125582 use TextVerticalAlign_BOTTOM for textCircle
        
        PowerPoint aligns the bottom of the text to the path for prstTxWarp
        'textCircle'. That preset type is mapped to 'fontwork-circle-curve'
        on import with additional attribute ScaleX=true. Currently the property
        TextVerticalAlign is only evaluated in case ScaleX=true. Therefore I
        have written the condition similar as the already existing with
        'fontwork-arch-up-curve'. If it will be necessary later, all those
        conditions can be changed to use rPresetType instead of rClass.
        
        The rendering is slightly different compared to PowerPoint, because
        descenders and paragraphs line-spacing are handled differently.
        
        The rendering has still the problem, that in PowerPoint the letters
        are placed without gap, but in LO they have additional distances from
        each other. The needed ODF attribute draw:text-path-mode is not yet
        implemented in LO. Its value 'normal' would be needed here.
        
        Change-Id: I1f03d4845312885eff9ee8dbe1d51ddd437ed8e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123726
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [300a743048de760e3a5456e8dce549af5f42b11b]

        make RR easier to use
        
        breaks easily without the RNG being repeatable
        
        Change-Id: Ia464a04f0623668088564c7121f39f04aa68b2ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-18  Miklos Vajna  <vmiklos@collabora.com>  [86e07d951bc4fd16648fe10befb40dd953fcc208]

        sw: avoid popup window for the EmbeddedObject property of an UNO OLE object
        
        The old behavior was that in case loading the native data of the
        embedded object failed, then we presented a popup to the user, but we
        still returned a valid com.sun.star.comp.embed.OCommonEmbeddedObject.
        
        Given that the return valid is desired even in the error case, don't
        turn the error popup into an UNO exception, rather redirect the popup to
        SAL_WARN().
        
        This is meant to be consistent with other UNO API functions that pass
        down an "is API" boolean to internal code to control if interactive
        behavior is allowed or not.
        
        One extreme would be to do this only for the EmbeddedObject property of
        frames, the other one would be to do this for more object types. Go with
        a middle ground for now, so all properties of Writer frame objects use
        this, but leave other object types unchanged.
        
        Change-Id: I655fcb3780e96cecc7ed3f01ded52948d013172e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123752
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [67fa088be7db1df661188ef4bab490a76fb06b85]

        tdf#145169 for IsDocument/IsFolder I think we want no interaction
        
        rather than installing something to sometimes disable interaction
        I think we just want to not have any interaction here at all
        
        Change-Id: Ic775f0cd88f796db873d2980bb40043caac498bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123750
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Henrik Palomäki  <henrik.palomaki@yandex.com>  [123edad21081ab45c8d83be4788f3c47c3b9a2dc]

        tdf#143148 - Use pragma once instead of include guards
        
        This patch replaces include guards with the "pragma once" directive.
        
        Change-Id: I1325488a22cca27d1f33e0191a0674a662630f66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123743
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [cc355073a9a16bcb1d1f222ef313e582fb88998b]

        tdf#144691: sw: Add UItest
        
        Change-Id: Ibd93ebf1115bbd2f7ae2f021212e0504ee3a6f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123744
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-18  Julien Nabet  <serval2412@yahoo.fr>  [bb73961ed0a5f4e09a9b761a02547490a46a06bd]

        Simplify Sequences init + remove dup block + typos in framework
        
        Change-Id: Ife80915c402ff25aa4752a5e1b68337eca3dd85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123721
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-18  Stephan Bergmann  <sbergman@redhat.com>  [d425cd604cb4d30862640851b11a31e742d81336]

        Revert incompatible ScriptEditor change
        
        ...from interface to abstract class, in 1c42afc194da2288c5a738b727952e80c323885c
        "Respect DisableMacrosExecution option in javascript editor".  It caused 3rd-
        party code like ScriptProviderForooRexx.oxt to fail to install.
        
        Change-Id: I532f27fdce806e471a8551646adbb3aecf80bcee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123745
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [15d0eec26be416e77d9b9580cf34d9a1d32a2615]

        Related: tdf#145169 unwanted dialogs on sftp save to remote to a new document
        
        which is similar to:
        
        commit f12e483589888f87843026ceff5ae3c1e615ca02
        Date:   Mon Feb 1 16:04:49 2016 +0100
        
            Fix tdf#97500 Reinstate missing file error dialog on WebDAV
        
        this all looks a bit dubious, but make a safely backportable change
        first
        
        Change-Id: Ia6dbaacf7024d05083c336135a80b5acf607dfc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123749
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb5968d199e5f185b5dbbc9be6b6bca992b94932]

        tdf#88359: sc: Add UItest
        
        Change-Id: Ia0d0a9cac9a5f04056c758c0b7c522e7c3ebe893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123742
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [631ac203b926fd92401ff305bcc0d5dde6a24a2f]

        tdf#144843: sw: Add UItest
        
        Change-Id: I28cac003af263ec9d73676adc2b0712a2b4ce4e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123738
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [851c2a68171a9fa20a952c65ca5860453c6cabf1]

        help button in built-in file dialog didn't work
        
        Change-Id: Ib37c713b926e1836bfb15dc0bb440b2e7bfc9f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123739
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Dennis Francis  <dennis.francis@collabora.com>  [4cfa840ecaa5a094a32a60a60b295858980109df]

        tdf#145198: Bash like autocompletion for Calc autoinput
        
        Refer ESC minutes section "Calc auto-complete behavior changes" at
        https://lists.freedesktop.org/archives/libreoffice/2021-October/087911.html
        for context.
        
        Consider an example of the following data in a column:
        
        ABCD123xyz
        ABCD345qwel
        ABCD123pqr
        ABCD123xyz
        PQR
        
        1. When user types A, it will show the partial suggestion BCD.
        
        2. User can accept the suggestion with the right arrow key and then the
           cursor will be placed after the letter D, waiting for more input. User
           can choose to not accept the suggestion either by typing more or by
           ending the edit mode by pressing Esc key.
        
        3. If the user accepts the suggestion BCD by right arrow key, and
           types 1, it will show a partial suggestion of 23. User can accept
           this by pressing the right arrow key.
        
        4. If the user accepts the suggestion in the 3rd step and types x it will
           show the final suggestion yz. Again user can choose to accept or decline
           the suggestion as mentioned in the 1st step.
        
        The tiledrendering test ScTiledRenderingTest::testAutoInputExactMatch()
        is amended to match the new behaviour.
        
        Change-Id: Ib2cfc16af71483790384e70eb7332f864cf744c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123578
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-10-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [b2e4123cfd597ef19eebcb1d2a98c058eea990b2]

        tdf#145085: sc_uicalc: Add unittest
        
        Change-Id: I47e0199ea2a3268697b42c26daec906a165ae3a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123734
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [f845ee17d52bca18b86bf6f28a74147085175d6a]

        Related: tdf#145169 use INetURLObject::getName and removeSegment
        
        to get the name and link for each part of the path
        
        otherwise for sftp:// clicking on the "Root" doesn't work for me
        
        Change-Id: If6f0ac8f105afd8be2d264b54f76a3d8f345ad75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [5acba60cbd97f2f181037cbd3ab049e7ebff5332]

        Related: tdf#145169 use "sftp" because that's a known Protocol
        
        while "ssh" isn't by INetURLObject. If we use sftp then
        Breadcrumb::SetURL would create legal breadcrumbs links in the "save
        remote" dialog for new "add SSH" from the manage services menu
        
        Change-Id: Ia0d5616a0a2536b93d2887ff4c0f180be6fe732c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123711
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-18  Emanuel Schorsch  <emschorsch@google.com>  [191e5fc227e40d18a1fe4563ed145517117596ea]

        Noop unify style for branches
        
        Change-Id: Ifa96b7f273f7c154fdd267efba7271765ff7ae45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123728
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-18  Miklos Vajna  <vmiklos@collabora.com>  [5eb9ad92ac6169d7aab92452ce9e1219441f4e52]

        sw: prefix members of MailDeliveryErrorNotifier, SwAddressIterator, ...
        
        ... SwAddressPreview and SwCondCollItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I6702b3d2287aa3c9df1bac8520746901ae2e2f25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123729
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-18  Arnaud Versini  <arnaud.versini@libreoffice.org>  [e0b04e19bd71ce00f81b111399dad3b9da79e224]

        salhelper : simplify salhelper::TimerManager initalization and use std::mutex
        
        Change-Id: I48c59e267683e081ef45049b280eb38ce231a39c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-18  Michael Stahl  <michael.stahl@allotropia.de>  [7d664ec788acdc378506a7ff8b1120cea24a6770]

        xmlsecurity: fix new tests on WNT
        
        Tests added in commit 40d70d427edddb589eda64fafc2e56536953d274 don't
        actually run on WNT but that wasn't obvious because commit
        149df1fec6472e30582162e17e04c75aee91d26a prevented running them in
        Jenkins on master, they failed only in the libreoffice-7-1 backport.
        
          xmlsecurity/qa/unit/signing/signing.cxx(631) : error : Assertion
          Test name: testODFDoubleX509Certificate::TestBody
          assertion failed
          - Expression: (nActual == SignatureState::NOTVALIDATED || nActual == SignatureState::OK)
          - 2
        
        This is an oddity where NSS claims the signature in the document is
        valid but CryptoAPI claims it is invalid; the hashes passed into the
        validation functions are the same.  Just allow BROKEN as an additional
        result value on WNT.
        
          xmlsecurity/qa/unit/signing/signing.cxx(550) : error : Assertion
          Test name: testODFX509CertificateChain::TestBody
          equality assertion failed
          - Expected: 0
          - Actual  : 1
        
        The problem here is that with NSS the tests use a custom NSS database
        in test/signing-keys so we need to make these certificates available for
        CryptoAPI too.
        
        The following one-liner converts the NSS database to a PKCS#7 that can
        be loaded by CrytpAPI:
        
        > openssl crl2pkcs7 -nocrl -certfile <(certutil -d sql:test/signing-keys -L | awk '/^[^ ].*,[^ ]*,/ { printf "%s", $1; for (i = 2; i < NF; i++) { printf " %s", $i; } printf "\n"; }' | while read name; do certutil -L -d sql:test/signing-keys -a -n "${name}" ; done) > test/signing-keys/test.p7b
        
        Then one might naively assume that something like this would allow these
        certificates to be added temporarily as trusted CAs:
        
        +                HCERTSTORE hRoot = CertOpenSystemStoreW( 0, L"Root" ) ;
        +                HCERTSTORE const hExtra = CertOpenStore(
        +                        CERT_STORE_PROV_FILENAME_A,
        +                        PKCS_7_ASN_ENCODING | X509_ASN_ENCODING,
        +                        NULL,
        +                        CERT_STORE_OPEN_EXISTING_FLAG | CERT_STORE_READONLY_FLAG,
        +                        path);
        +                if (hExtra != NULL && hRoot != NULL)
        +                {
        +                    BOOL ret = CertAddStoreToCollection(
        +                        hRoot,
        +                        hExtra,
        +                        CERT_PHYSICAL_STORE_ADD_ENABLE_FLAG,
        +                        0);
        +                    SAL_DEBUG("XXX hExtra done " << ret);
        +                }
        
        There is no error from this, but it doesn't work.
        
        Instead, check if CertGetCertificateChain() sets the
        CERT_TRUST_IS_UNTRUSTED_ROOT flag and then look up the certificate
        manually in the extra PKCS#7 store.
        
        Change-Id: Ic9865e0b5783211c2128ce0327c4583b7784ff62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123667
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-18  Michael Stahl  <michael.stahl@allotropia.de>  [d06f8ba07a86f95de3446c66521960d27134afdc]

        xmlsecurity: fix some obvious copypasta
        
        These 2 calls to CertAddStoreToCollection follow calls where
        m_hCertStore was already added and according to the comments they
        should add the other store instead.
        
        (regression from commit 813e1f5a8ae4800e8a11c612de4e3b0a97f1368d)
        
        Change-Id: If375f603647a702feb0ca8f272126a15d5d0e906
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123666
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-18  Caolán McNamara  <caolanm@redhat.com>  [0bc13d9b3313d424fa3f7d0a0f25eb9e30f958d2]

        cid#1492880 avoid Improper use of negative value
        
        Change-Id: Idb64ec73e6cb7f032d61b6670ed27a2418e3a6f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [c82aa206ab496248dd107c41ff5f66ec5a2399ac]

        Simplify Sequence in accessibility
        
        + retrieve a missing aKeyEvent.GetCharCode() aSeq3
        
        Change-Id: If575513996304f67b8e87a145052cb1b9279a212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123719
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-17  Caolán McNamara  <caolanm@redhat.com>  [3059d56c9d91b7450e2229b2baee0ddc2cf8fa0d]

        just do one lookup for loop detection
        
        Change-Id: I2b20c15f2e3ec3c4a23d78f6fab85db763fce033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123705
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-17  Arnaud Versini  <arnaud.versini@libreoffice.org>  [0f98bcdf4d47193fa0fe38a5fc04218bdbb7d886]

        basic: simplifiy class initialization
        
        Change-Id: I87fa2f606011aab8e34d9445d9e9299786f05747
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123324
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [1d1d0bd4d941c58306f3086cf3103b40ad0978ba]

        Simplify Sequences in xmlsecurity
        
        Change-Id: I749e19f786ad006dffcd65dd1ee60e57c428f57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123717
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Hossein  <hossein@libreoffice.org>  [fb1469ea68b8f87f17e1729e7c5d4cc8ebbb45bd]

        Use range based for loops
        
        * Use range based for loops where it was possible in svgio
          + Goal: Better readability of the code
        
        Change-Id: I6259e2391006287d5d330277dd8d700012c32932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123712
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-17  Jan-Marek Glogowski  <glogow@fbihome.de>  [a2adb7fa926c2b9ed053c65e130a9da336cc98b0]

        WIN release SalPrinter's SalGraphics borrowed HDC
        
        Regression from commit d27187b158d7e3f92180b1f2ab79b048dc5318a5
        ("vcl:use unique_ptr<SalWinGraphics> in WinSalPrinter").
        
        Would need something like Rust's Borrowing semantics to prevent.
        Ideas on IRC to make this bug more unlikely were some extra HDC +
        SalGraphics struct to pass around or something like unique_ptr
        reference passing and moving the value into a local copy.
        
        For now just add some additional comments.
        
        Change-Id: I472ee9acb4a4c02177c27ecd1c1277dfc812cadf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123440
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-10-17  Mike Kaganski  <mike.kaganski@collabora.com>  [23cded985ba0131f85ee445492c04871fbfb6351]

        Specialize comphelper::makePropertyValue for arithmetic types
        
        This allows to pass e.g. bit fields to the function, like
        
            struct Foo { bool b : 1; };
            Foo foo {true};
            comphelper::makePropertyValue("foo", foo.b);
        
        Change-Id: I8f725d0101d90fb8b6012375c085918d1cadc6f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123639
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-17  Mike Kaganski  <mike.kaganski@collabora.com>  [6f725426f75a2876b348fc2c38cb6ed30f45d565]

        Simplify comphelper::makePropertyValue
        
        Avoid default-constructing members that get immediately re-defined.
        
        Change-Id: Ib863745577983582c80e1b172060ba20ce6135a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123638
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [29a1fc0f31cf62fcb8fce388cdf6b780d2948e7b]

        Simplify Sequence in xmlhelp
        
        Change-Id: I4a7363686498151a840b1c400d466b1c2d583e7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123718
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [cf3971a9414f52b116c1c21f267128ffa67f171b]

        Simplify Sequence in b*
        
        Change-Id: I0817d9a35a9c3fc43badb6cc60727de69849b063
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123720
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Regina Henschel  <rb.henschel@t-online.de>  [3b922eb756d990c16944bbce42ae13142565a835]

        tdf#144988 correct font size in multiline Fontwork text
        
        The error happened if ScaleX in TextPath is true. In that case the
        original font size is used for rendering if possible. Only if a
        paragraph is longer as its sub-path length, the rendered font size for
        the whole text is reduced until the text fits. The error was, that in
        case the first paragraph was too long and the second paragraph fits,
        the fact that the first paragraph was too long was overwritten from
        the factor for the second paragraph. That resulted in wrong position
        and size of the text and overlapping characters.
        
        The meaning of fScalingFactor is related to the usual case, where
        ScaleX is false. Keeping original font size is not achieved by using
        value 1 for fScalingFactor (which would be obvious), but the adaption
        to case ScaleX==true is done in FitTextOutlinesToShapeOutlines() by
        tweaking the width from the text bounding rectangle.
        
        Change-Id: Icf5829018a83be0f1197304d17da10a88130f702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123714
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [4477baeba5aec71098f374cf0b4bd4591e048809]

        Simplify Sequences in xmloff (+ merge 2 SetError)
        
        Change-Id: If4055bbeb858b1b87ecb3f8c0b87da4b008e3c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123716
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [74e738827ab2c6aa08ae4858a547f5fa75acfc6e]

        Simplify vector initialization in writerfilter
        
        Change-Id: I54f6eaed64f0a4209e57ce12b5cbb38d2cf66fb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123709
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [4af72419f3e8a571d0a367c6422424fdc3ab4061]

        Simplify vector initialization in xmlsecurity
        
        Change-Id: Ia19ffa1213d578c30f35545bcca515669e7ff7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123710
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-17  Julien Nabet  <serval2412@yahoo.fr>  [43a9bf11203ed92096af34ab828501e0218832c7]

        Simplify vector initialization in vcl
        
        Change-Id: I881627313221081f72f8421c91417e4c111cfd97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123708
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [6cce3821ff14b41b704e279034680ce81d2b14ca]

        Simplify vector initialization in ucb
        
        Change-Id: I4b03ab81a17efc125bc5e3b159cf212198c43d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123707
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [e7d99ed15a33de67e436f23096fd2de2ab2e400f]

        cid#1492880 make Improper use of negative value explicit
        
        Change-Id: Ie55748f2037a320812fdf6288dd1671a39fe018b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123706
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [68314bdba8d91a7e30c0c061fd3e31847c6a8187]

        Simplify vector initialization in svl
        
        Change-Id: I8ff1eb008f3173791c7c1020db08d29451998f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123699
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [8133aa39939bd65c7c4078ff002ab88675e84ccc]

        Fix a forgotten return of the value
        
        ... ever since its introduction in commit
        5ea5c0afebd272d5f44e6524c0f67b5317639919
        
        Change-Id: Ic2f082db43c961185921137c6b64b2e1abef28e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123704
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [7422ef83a1304d34cd303a7160efd4e76cc44a49]

        ofz#40004 Timeout
        
        Change-Id: I261f6acec53936e4a644bb4b38bbc41fa9ad120c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123702
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [7528bb3c5098a67f32523c028d83dfbc79a7c6a0]

        ofz#40008 check if column exists before EndListening attempt
        
        Change-Id: Iad6a7f215aa36fb6f8bb35e14aa5b882bf9773f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [f6a5efc7cde6e7d723e05b866bc6de1bb56913b0]

        Simplify vector initialization in sc
        
        Change-Id: If5b7632cfbc81f89d68ce8fbce1fac265e8354fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123692
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [62078c534f96e859d4e8c0ead6337a876344e4ab]

        Simplify vector initialization in sfx2
        
        Change-Id: Ibff7203a86b42c58738d8b4836a61bf1c5806962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123698
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [8ec8bbcd4b1af73527859255d84af9f5990426bb]

        Simplify vector initialization in sw
        
        Change-Id: Ibded138d113e56b78b12c96c7ecd8258564627ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123701
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [9d98fadd5e943f4c3f87d0c269815c7a0feee217]

        Simplify vector initialization in svx
        
        Change-Id: I139776f74fb93f90dae787eeae18e4a2a2ed7351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123700
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [edf82470de0f7796992666a0c2b5c56dc66c94fd]

        Simplify vector initialization in filter
        
        Change-Id: I78653b32a5418e44733e3d2740a9a7dd784f17ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123686
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [ac10792ed4ca8d92f60c95ab4acd5b911e42cec7]

        Simplify vector initialization in reportdesign
        
        Change-Id: Ic1927155b23f056fc1117b7726ab4b2eff8a6da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123690
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [8546cdb2ad25b03ac152615357cab0006340d92f]

        Simplify vector initialization in sal
        
        Change-Id: Ia3e4dd8cad79b156d44eb03f1ae3d308204df2e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123691
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [e44fc2be0d9b0ed7b8983aca42471303e1fca55f]

        Simplify vector initialization in oox
        
        Change-Id: I1d7cfd157d56a501be4497e6f4e94f3f33429139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123689
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [881329a30612fb822d6c770efabc249bbefeb126]

        Simplify vector initialization in drawinglayer
        
        Change-Id: Iee9c13149d3614ecd9f812cfbb85e4534c33c1be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123684
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [cd5ee8c7d3f06fe78e6b3993845a3c2abc7cb72a]

        Simplify vector initialization in helpcompiler
        
        Change-Id: I800fa0a6ac3b0dce1e0408858646dc7db5510623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123688
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [741658c57c9653d58bd9abbe630f469ca7f64a6b]

        Simplify vector initialization in extensions
        
        Change-Id: Ia83209304a7ed889cdd643c8034420c032ccad6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123685
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [d64a6e2245169e5e4a3f8bc5388b4fff4984e5f4]

        Simplify vector initialization in sdext
        
        Change-Id: If3cebeadff5496ae214614b49116060d24b6082f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123696
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [5393f9a53eb8b33537aedd03b7c9efc5222748d6]

        Simplify vector initialization in sd
        
        Change-Id: I5f56919efeea66ce6e644f2cb123fd264edbcb73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123697
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [a8a07cea28fd79e240c3abb084b88f4e23674fd6]

        Use sal::systools::COMReference and drop ComSmart
        
        Change-Id: Ic6e0c87f607264629cdec1fdcd0c3144d8fbf8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123695
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [75fc91b143a4458403d68342c3636882f42c84ee]

        Simplify vector initialization in fpicker
        
        Change-Id: If75810cb09e13d5d9b9490b20a0a99b1745e17be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123687
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [604d464d2bdd0271ad63e5c93d4869a318eac262]

        Simplify vector initialization in desktop
        
        Change-Id: Ia7c99cb9c0e8be7299bc664b80cc8932d2766469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123683
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Julien Nabet  <serval2412@yahoo.fr>  [4fd5dc6340ecd6ac09f239507622152691911d59]

        Simplify vector initialization in cui
        
        Change-Id: I9c1b793f02eff56251cf13959e88c4648db4ab0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123665
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [17ac33abe4eb1d406da1060f772562655f973e51]

        add use-underline to spacing control labels
        
        set all entries to use the same icon-size
        
        Change-Id: Ibb949a039175ce2b93323bace7102a5f32aecfd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123676
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [507117d63f9bfa676148ed1018950dfafa6b5fc7]

        resave with latest glade
        
        Change-Id: I0fae7cd556a6158787e139b0b419e6a7ead18658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123675
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Caolán McNamara  <caolanm@redhat.com>  [171fcff4f027c620e977b60a48ac5014ac0cacf6]

        gtk4: focus can only enter popover if its parent widget can-focus
        
        even though the popover is a separate toplevel window.
        
        Change-Id: I2ff799f0070b2233953af9e96c6eafeadb58b2cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [05055f1873faa3544478908d2d877ec7f38c4a9c]

        Fix typo
        
        Change-Id: I66712db3b74e45728e3104c24823a962fd498037
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123677
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a38960757cda7da8911688154ec4852a6b3e5e1b]

        Fix typo
        
        Change-Id: I101231dc8daa99254a086bd635817e20c23a8ff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123679
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Mike Kaganski  <mike.kaganski@collabora.com>  [314fbd4cfa3a2f4125c9badc9033758b720db0f7]

        Fix the copypaste error
        
        ... ever since commit 6eea9416a3a5be2d2f6aab6c58ab4e6d4b085ea8
        
        Change-Id: Ic3f6f6876d398cd48cd480518d99a516cea95a31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123636
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-16  Tomoyuki Kubota  <himajin100000@gmail.com>  [bdb8c1796646fc89ae7e11cd0e8f3be1cbdcb848]

        adapt to the change from tools::Long* to std::vector<tools::Long>* since d4dc6b5c
        
        Change-Id: Ic2104185aec40e01b81d3559c161d894a473d3a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123631
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-16  Tomoyuki Kubota  <himajin100000@gmail.com>  [f5cffe30843b4afa81123ab972347e3142c9b87b]

        adapt to the variable name change from pPortion to rPortion since  35f03f26
        
        Change-Id: I8ed79957a464ab15e439ebfff5b7d338ed774288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-16  Eike Rathke  <erack@redhat.com>  [459f9de8a87373c826eadab142850cc3fa578fca]

        Resolves: tdf#145085 HYPERLINK() do not force a 2nd row URL cell in array mode
        
        ... but fake a 1-row result dimension instead.
        
        However, keep the behaviour that if a 2-rows array was entered the
        2nd row displays the URL and not the repeated cell text.
        
        Change-Id: I4800715a4028c647b763c6d729759ff4c099748f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123680
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-16  Regina Henschel  <rb.henschel@t-online.de>  [64bacd4f2bd9c8e10e8c9a0b7d18516c77260df3]

        tdf#145111 evaluate nVertDiff for HORZADJUST_LEFT too
        
        In case of ScaleX=true in property TextPath, SDRTEXTVERTADJUST is
        evaluated and should shift the Fontwork text. That did not work for
        'LeftTop' and 'LeftBottom'.
        Error was that in case of SDRTEXTHORZADJUST_LEFT the vertical shift
        was not considered.
        
        Change-Id: I4edb47515c4bf40e17b4054c3a10220df8468028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123613
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [7a001d3706bee453db46fb38c80c17bb84fda4af]

        resave with latest glade
        
        Change-Id: Ifbbb1e253996fdfd74ea792926b7eb9a22a5bd1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123673
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [f9d55bc472c2280e9dfaf0964a5cbc6af641049e]

        gtk4: focus can only enter popover if its parent widget can-focus
        
        even though the popover is a separate toplevel window.
        
        just add can-focus for this one example first
        
        Change-Id: I6b4b2942cdf2ed4b25b3a07d36f96c72ffc6d825
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123671
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [f4f98ac18366b604d135895a92d9d5c101e77a16]

        gtk4: gtk4 needs to have all parent widgets can-focus to allow focus into child
        
        Change-Id: Ibb8be00ffe256f744787342b1aa748a6ac580b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123670
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [de8a062253aefee12c7f65b63b1bcefc5cd99731]

        resave with latest glade
        
        only formatting changes intended
        
        Change-Id: Ifa00973dcc342e8d2adef4edb941e690384c8986
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [7d1903343f0ff8f09ffc669fc6b355b20059d4fb]

        let (Without) use-underline
        
        Change-Id: Idd5b5dc3cfadfc7e6de116c9403e214a6fb474ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123668
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Michael Stahl  <michael.stahl@allotropia.de>  [d09cbdc12ef5af6d98f62c06056f36306c247cfe]

        test: upgrade test NSS database from dbm: to sql:
        
        Fedora nss-3.69.0-1.fc34.x86_64 and Debian libnss3:amd64 2:3.70-1 no
        longer support the old BerekelyDB databases, so convert them to the new
        SQLite format for the benefit of --with-system-nss builds.
        
        This worked to do the upgrade:
        
        > certutil -N -d sql:test/new --empty-password
        > LD_LIBRARY_PATH=instdir/program workdir/UnpackedTarball/nss/dist/out/bin/certutil --merge -d sql:test/new --source-dir dbm:test/signing-keys
        
        Builds would fail running tests added in commit
        40d70d427edddb589eda64fafc2e56536953d274
        
          signing.cxx:551:Assertion
          Test name: testODFX509CertificateChain::TestBody
          equality assertion failed
          - Expected: 0
          - Actual  : 1
        
        Change-Id: I00aa20703e117ebf583c3331b84e966c2cfc78cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123586
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-15  Ross Johnson  <ross.johnson@homemail.com.au>  [e47b9d7f5693fa4764311df2f21163692208d44d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6079bc0682395542969c2a0e7e184bf89a175428
          - tdf#145135 - Writer object positioning help page fixes
            
            1) Describe relationships between anchor, reference point and
               object.
            
            2) Expand the description of "to character" to highlight that the
               reference point is the start of the paragraph containing the
               character, not the character to which the anchor is attached.
               Give examples.
            
               The Guidebook is correct but this help page wasn't.
            
            3) Attempt to explain the difference in the effect of moving the
               anchor compared to moving the object itself. Remind users that
               an objects wrap and alignment settings constrain this movement
               and final positioning.
            
            Change-Id: Ia4bfc0e7273d3d09a65cab0cec7d78bd45b7a2bf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123653
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [fd29369a9ddb1e4a277cba90384ecf5ee2de450c]

        Simplify vector initialization in cppuhelper
        
        Change-Id: I1c1e36932673fe26fdd9daf21925fb952dbbfa73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123663
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [094babdf63bff535a692f23971ddf0a77424bdd1]

        Simplify vector initialization in canvas
        
        Change-Id: Id359ec7fa58350f578f9da430c3b0536c6ff8a35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123659
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [797458374ff3919070abdaf876cebbd855ce6d8a]

        Mark external/breakpad/SIGSTKSZ.patch as upstreamed
        
        Change-Id: I895b034ecda257e1488c46054b13140196790639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123658
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [dfa8dbf98ee872d22bb9e2c63ab07ed76fb81579]

        Simplify vector initialization in dbaccess
        
        Change-Id: Iad1f84a9e81c50a007c162a5043343233fdc23a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123664
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [4079daadf85a799e7a5bf386e03f55687aab1df9]

        Simplify vector initialization in chart2
        
        Change-Id: I26dd2e0480bb60719f4f1b6dcc30cb28bb35ee09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123660
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [b695169194c671464f0fab2bc6eb9af94ca68710]

        Simplify vector initialization in connectivity
        
        Change-Id: I4eb3ca5b1a45e585f076c7e11f616be4614d972a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123662
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Julien Nabet  <serval2412@yahoo.fr>  [9615451c0bf19f0b5b46aa421a5052e1b5defedb]

        Simplify vector initialization in comphelper
        
        Change-Id: Ibcf65cbbf5c0619813bd87a6deb4b75fe524986e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123661
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-15  Justin Luth  <justin_luth@sil.org>  [b043a5b953f9da553a725606a1795d5fd0860ca3]

        tdf#93747 sw IsTableMode setStyle: don't affect unselected cells
        
        Change-Id: I88fcb97adbe790f1c2de469195818d7e27bcc41f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123651
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [59fbb0d49dc9dcdc9bb76214949ac0ab4332b9c2]

        gtk4: get toolbar popovers in sidebar working
        
        Change-Id: I7ef95a3207c3a10cd541a529c80ef70d55ea2185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123657
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [e299f1f5e6097d9e5857dba65a65c33ac31974ae]

        tdf#144843 call to GetBoxBackground requires incarnated item
        
        Change-Id: Id47f26a762804cd8c1b5742966ec54b71a26ab09
        
        Added assert/warning to SwDoc::GetBoxAttr - that is the
        method used by GetBoxBackground && GetBoxDirection
        
        Change-Id: I59e8dfb790e3872810885a8f888cea57be27e80c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [7dc2ac46be574b59cac7923ac55cf650c4fd1168]

        loplugin:unnecessaryoverride corner case is subsumed now
        
        ...by modifications done to the plugin in
        af908d9f18fbb83a5c393f856026cebefd821f18 "Avoid usage of incomplete types in
        member functions defined in-class" (if the dtor's definition is spelled
        `= default;` rather than `{}`, but which should always be possible)
        
        Change-Id: Iddce2baf3635a12131854e86a609951309ffbc26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123656
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  Jean-Pierre Ledure  <jp@ledure.be>  [78db0dcfb6f5a8d5baa2daae7e17733d4c7c0a0c]

        ScriptForge - new SFWidgets library, new PopupMenu service
        
        The SFWidgets library is intended to host the Toolbar,
        ToolbarControl (both future) and PopupMenu services.
        
        A popup menu is usually triggered by a mouse action
        (typically a right-click) on a dialog, a form, or one of their controls.
        In these cases the menu will be displayed below the clicked area.
        
        When triggered by other events, including in the normal flow
        of a user script, the script should provide the coordinates
        of the topleft edge of the menu versus the actual component.
        
        The menu is described from top to bottom with next methods:
           AddItem()
           AddCheckBox()
           AddRadioButton()
        Example:
           .AddCheckBox("View>Toolbars>Dialog")
           .AddCheckBox("View>Toolbars>Find", Status := True)
           .AddCheckBox("View>Status Bar", Status := True)
           .AddItem("View>Full Screen", Name := "FULLSCREEN")
        The SubmenuCharacter (Default = ">") is modifiable.
        
        Each menu item receives a numeric and a string identifier.
        The execute() method returns the item selected by the user.
        
        The service is available both from Basic and Python user scripts.
        
        The commit includes the review of build files to include
        the new library and the new modules.
        
        Change-Id: I2940be25313cc8fff7b337766edd348b04a20584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123654
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-15  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [463d261e3509cc857e248d8bd5787a45d385a646]

        CppunitTest_emfio_emf: add some tolerance in TestPdfInEmf
        
        Change-Id: I1fc1b3863fd5b5472e700a5432fb4f9d353a054f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123650
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [5bf4eb0f5e20a8c24e37e68f47988b3d9b29c570]

        Correctly use swap customization point in generic code (for pre C++20)
        
        (see <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4381.html>
        "Suggested Design for Customization Points")
        
        Change-Id: If641ce84b1114fbe4e9819ebf4d958130301dc13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123626
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-10-15  Michael Stahl  <michael.stahl@allotropia.de>  [62128c09237152d9e0585abe2fc88f0a13274b34]

        comphelper: fix bad error handling in CreatePackageEncryptionData()
        
        Not sure if rtl_digest_SHA1 can realistically return an error but avoid
        out-of-bounds write in this case.
        
        (regression from commit 9188ea83c346fdc2f668178ae7538665a1b09c02)
        
        Change-Id: If5f134cbcd9236338d1938242a469d7c79e87f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123649
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [27454bc5a64b5f310a53bf514ff709a5eca2320f]

        loplugin:stringview (clang-cl)
        
        Change-Id: I367bc431bfd12041b2ccb6145c11f80b545aae19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123647
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  Luboš Luňák  <l.lunak@collabora.com>  [cb60edbc2c0725f0309a5b934f41e999a1fe0c5f]

        delay, collect and compress LOK invalidations for Writer views
        
        Due the to way views are updated on any document change, invalidations
        are at least O(n^2), and since LOK may use a number of views and
        for each view the entire document is considered to be the view area,
        this can lead to a huge number of invalidations that are mostly
        the same repeated rectangles.
        
        Change-Id: I63682958d2fc388344641dcd19fa1d2b39054b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123617
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-15  Luboš Luňák  <l.lunak@collabora.com>  [3b729db05553c1a6d461fb41c89a05702f407448]

        do not use text-based LOK callback internally
        
        CallbackFlushHandler post-processes LOK messages, but for things
        like dropping useless invalidations it needs to know the rectangle
        or the view id, and since the only data it gets are string messages,
        it needs to convert those back to binary form. Which is slow
        with large numbers of messages.
        
        Add internal LOK callback variant that allows also passing
        specific data in the original binary form. And then use directly
        the binary data in CallbackFlushHandler.
        
        Change-Id: I8dd30d2ff9c09feadebc31a44d8e6a8ccc306504
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123589
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [af908d9f18fbb83a5c393f856026cebefd821f18]

        Avoid usage of incomplete types in member functions defined in-class
        
        ...that started to fail now at least with clang-cl (where the MSVC rules when to
        emit inline member function definitions are more aggressive than for other ABIs)
        with --with-latest-c++ and --with-visual-studio=2022 (where usage of incomplete
        types in std::vector now triggered
        
        > In file included from C:/lo-clang/core/slideshow/source/engine/opengl/TransitionerImpl.cxx:31:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\memory:11:
        > In file included from C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\exception:12:
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\type_traits(744,50): error: incomplete type 'Primitive' used in type trait expression
        > struct is_trivially_destructible : bool_constant<__is_trivially_destructible(_Ty)> {
        >                                                  ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\type_traits(59,53): note: in instantiation of template class 'std::is_trivially_destructible<Primitive>' requested here
        > struct conjunction<_First, _Rest...> : _Conjunction<_First::value, _First, _Rest...>::type {
        >                                                     ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\type_traits(64,44): note: in instantiation of template class 'std::conjunction<std::is_trivially_destructible<Primitive>, std::disjunction<std::_Is_default_allocator<std::allocator<Primitive>>, std::_Has_no_alloc_destroy<std::allocator<Primitive>, Primitive *>>>' requested here
        > _INLINE_VAR constexpr bool conjunction_v = conjunction<_Traits...>::value;
        >                                            ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\xmemory(934,20): note: in instantiation of variable template specialization 'std::conjunction_v<std::is_trivially_destructible<Primitive>, std::disjunction<std::_Is_default_allocator<std::allocator<Primitive>>, std::_Has_no_alloc_destroy<std::allocator<Primitive>, Primitive *>>>' requested here
        >     if constexpr (!conjunction_v<is_trivially_destructible<_Ty>, _Uses_default_destroy<_Alloc, _Ty*>>) {
        >                    ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\vector(1632,13): note: in instantiation of function template specialization 'std::_Destroy_range<std::allocator<Primitive>>' requested here
        >             _Destroy_range(_Myfirst, _Mylast, _Al);
        >             ^
        > C:/PROGRA~1/MIB055~1/2022/Preview/VC/Tools/MSVC/1430~1.305/Include\vector(583,9): note: in instantiation of member function 'std::vector<Primitive>::_Tidy' requested here
        >         _Tidy();
        >         ^
        > C:/lo-clang/core/slideshow/source/engine/opengl/TransitionImpl.hxx(74,5): note: in instantiation of member function 'std::vector<Primitive>::~vector' requested here
        >     TransitionScene(
        >     ^
        > C:/lo-clang/core/slideshow/source/engine/opengl/TransitionImpl.hxx(42,7): note: forward declaration of 'Primitive'
        > class Primitive;
        >       ^
        
        etc.).
        
        Which in turn required tweaking of loplugin:unnecessaryoverride to avoid false
        
        > In file included from C:/lo-clang/core/slideshow/source/engine/opengl/TransitionerImpl.cxx:67:
        > C:/lo-clang/core/slideshow/source/engine/opengl/TransitionImpl.hxx(389,18): error: unnecessary user-declared destructor [loplugin:unnecessaryoverride]
        > TransitionScene::~TransitionScene() = default;
        > ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
        > C:/lo-clang/core/slideshow/source/engine/opengl/TransitionImpl.hxx(81,12): note: declared here [loplugin:unnecessaryoverride]
        >     inline ~TransitionScene();
        >     ~~~~~~~^~~~~~~~~~~~~~~~~~
        
        Change-Id: Ia72fb44e6e92ff47376d7b7159c0df7cbf883b69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123648
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  Eike Rathke  <erack@redhat.com>  [99adfcad3517de6530c9a2f025c528001f543ae2]

        Resolves: tdf#88359 CSV: import strict ISO date(+time) with standard settings
        
        i.e. without having to activate "Detect special numbers".
        
        Now that we have NF_DATETIME_ISO_YYYYMMDDTHHMMSS000 for resulting
        formats this is possible without losing details.
        
        Only strict ISO 8601 extended separated format is converted, if
        date+time then the T separator must be present, a space character
        is not accepted instead.
        
        Change-Id: I6126cae743ed55fa77915c730114c3f8f5baee8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123652
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [6daf40e440e457d1560d7fb13ebda8a17efbfe84]

        vcl: test OutputDevice::DrawPolygon()
        
        Change-Id: Ic295a5ef471d1cbb05bddbc0a3757feebc9a17f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122976
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [db7676137ad91a1e9e0449afffc639ce73b40f4a]

        Value stored to 'accent_val' during its initialization is never read
        
        Change-Id: I780ffee680e52c240a1bd212f34c9c019c8b5e59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123625
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Caolán McNamara  <caolanm@redhat.com>  [13fb1defcd8bd303d3f753a5dd0f0c2281a75539]

        tdf#144691 apply the language change SYNCHRON so it will be seen during apply
        
        otherwise the restore of state from the document takes place before the
        document has seen the language change
        
        Change-Id: I08e74d99bec3d88914caa9a2c83602c32e277ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-15  Mike Kaganski  <mike.kaganski@collabora.com>  [2484de6728bd11bb7949003d112f1ece2223c7a1]

        Remove non-const Sequence::begin()/end() in internal code
        
        ... to avoid hidden cost of multiple COW checks, because they
        call getArray() internally.
        This obsoletes [loplugin:sequenceloop].
        
        Also rename toNonConstRange to asNonConstRange, to reflect that
        the result is a view of the sequence, not an independent object.
        
        TODO: also drop non-const operator[], but introduce operator[]
        in SequenceRange.
        
        Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-15  Emanuel Schorsch  <emschorsch@google.com>  [88375fd36899d21d3309cf8333712e02a87d3a91]

        NoOp refactor to make elif clearer
        
        Change-Id: I05be42fde3f2b66d20c337583d8f8f92143bcb58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123032
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  László Németh  <nemeth@numbertext.org>  [8c55fc357cf0bb0608be23098b9d3d565dae2b48]

        tdf#145068 sw change tracking: highlight numbering of changed list items
        
        Highlight the numbering of the changed list item, not the next one.
        Tracked movement of the list items is more visible this way.
        
        Follow-up to commit commit 173b7fcaae86980809889db30ddb82f8ba883103
        "tdf#42748 show changes of list numbers and bullets".
        
        Change-Id: I4c029f708eb10808f72d44892b986a8fade47f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123592
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-15  Miklos Vajna  <vmiklos@collabora.com>  [b4c84dc73b7121f6c8fd0364fce9db227e0d2dd1]

        sw: remove useless debug code in DocumentDeviceManager
        
        A gdb breakpoint can do the same.
        
        Change-Id: I2fb87c8e3ac7d576e9b3f3b29e500e3482a13910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123596
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-15  Stephan Bergmann  <sbergman@redhat.com>  [1101b3524d9d6513fe539e5365e099ebed38d5e8]

        Repurpose regcompare test as unoidl-check test
        
        532b47a650ce5189e1fb759201129d7d1f434133 "[ABI CHANGE] In SDK, replace
        regcompare with unoidl-check" had left "registry/CustomTarget_regcompare_test.mk
        around to verify that unoidl-check behaves the same as did regcompare on those
        old-format .urd/.rdb files."  Behavior of unoidl-check on those old-format .rdb
        files will become less relevant with the planned move from the old-format
        idlc/regmerge toolchain to the new-format unoidl-write toolchain also for the
        SDK.  But there appear to be no unit tests for unoidl-check, so repurpose (and
        move around) the existing test (switching it from using idlc/regmerge to using
        unoidl-write).
        
        Change-Id: I4c33e9c16aaf0f99e35d9257a40f3bc2ae2725ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121783
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-15  Mert Tumer  <mert.tumer@collabora.com>  [4c5b693267fac35c83e59f3288a1d46b99f02eea]

        lok: Fix graphicselection INPLACE msg is filtered out
        
        INPLACE message is not at the beginning,
        search it instead
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I2a09ac5a664c1ff26790aa776d871ac34c3d99dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122919
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123522
        Tested-by: Jenkins

2021-10-15  Mike Kaganski  <mike.kaganski@collabora.com>  [addf0b2abb9b78429b7b55f9463899a8ec21bf85]

        Simplify OTypeCollection ctors
        
        Change-Id: I775e0a425abcf616a6d61570edfdfd99c7b9d46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123526
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-15  Eike Rathke  <erack@redhat.com>  [9bcdfcb74dae7ccd07be7159c0e1deba110d2a6f]

        Related: tdf#88359 CSV: choose proper ISO date(+time) format if detected
        
        ... if column type is set to "Date (YMD)".
        
        Also be more strict if ISO is detected and timezone is included
        keep it as type Text instead of silently discarding the timezone
        information.
        
        Change-Id: Ia2236e87d6cf8b0ece33590a7fd99328f109d7a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123612
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [a12727702b4132bb0576062afe68e39a87a6a426]

        tdf#144840: sw_uiwriter3: Add unittest
        
        Change-Id: I6c43d5c4dbcebf9bd61ba66b37f9c872d0ea7cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123594
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [12bd8d8d50da871e8f6be57ce46083f84d493d8b]

        tdf#138873: sw_uiwriter: Add unittest
        
        Change-Id: Iebce7142f51e5a80fc1ea5e78481efeab3709c09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123595
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f9468fc29874eae5100317282ab8b395904406d]

        use std::vector::insert instead of push_back
        
        because it will pre-allocate space and often is optimised to memcpy
        
        Change-Id: I03ed7915f2762d3d27e378638052a47a28bbf096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-14  Roman Kuznetsov  <antilibreoffice@gmail.com>  [43b0d4f709a3a1446a32e36abb5deaa3bb45ddd9]

        tdf#138842 Delete Default item from Calc Comment's context menu
        
        Change-Id: I4f3b78bfdf479f96c9d8e2387c5c38446f2eaf72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123513
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-10-14  Stephan Bergmann  <sbergman@redhat.com>  [620179240670bd00f60555f1f5c5b0268492f97c]

        Enforce the UNOIDL identifier scheme
        
        ...which reserves identifiers containing underscores and starting with a
        lowercase letter for the implementation.  That TODO can finally be resolved now
        after 04af4e4f55f3ef319a78edd4d0109e2e7eba90b6 "[API CHANGE] Fix all bad UNOIDL
        identifiers across offapi".
        
        Change-Id: Id63ba96aa77f8666fbdfa90f7b260af42e6856bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122362
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [4ab6aec7062ff752a28e7c7cff0e2836460c00a1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 28499f409af62f1930f427ebf040f9a2cd6422b3
          - tdf#145067 Document the Basic Collection object
            
            Change-Id: I0ea7be144cca78b48ab3dfd07426ad679b07b26b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123398
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-10-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [672ae729c40b782024b7e4b7adf3a5a45dd4af0c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1efde59fa4d731f1fbbb1c14a647acb67d0be27a
          - tdf#143756 Update VBA Round function
            
            Change-Id: I2bab4225b618125c52fc1146140118e3bce009a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123514
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-10-14  Stephan Bergmann  <sbergman@redhat.com>  [04af4e4f55f3ef319a78edd4d0109e2e7eba90b6]

        [API CHANGE] Fix all bad UNOIDL identifiers across offapi
        
        Identifiers containing underscores must start with an uppercase letter.  (So
        that the UNO implementation can use identifiers containing underscores and
        starting with a lowercase letter for internal purposes, see e.g. the static_type
        member functions in the C++ *.hdl files.  idlc checks that with the -cid option,
        while unoidl-write silently allows bad identifiers for now, see the TODO in
        unoidl/source/sourceprovider-scanner.l, which can be dropped after this change.)
        
        All of the affected identifiers were present since early OOo times, but none of
        them appear to be used much, at least not across LO itself, so there is hope
        that we can get away with these incompatible changes.  (For the constant group
        members, we could roll this out in two steps, introducing the new members
        alongside the old ones and deprecating the old ones in a first step, then
        removing the old, deprecated ones in a second step, so that third-party code
        would have more time to adapt.  But that would not work for the enum members and
        interface methods, so just do all of this in one breaking step.)
        
        udkapi happened to not contain any bad identifiers.
        
        Change-Id: If2d4c16563606f9efb48b937c76af54746377428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [6f761939196eb0963c218b2ac9263f358f946675]

        Finish merging two identical conditional branches
        
        The code in the branches used to do different things before commit
        26e6d4b05ab444e6a7529ffcac7fbe592fc94833, which technically made
        aProperties a copy of rProperties in both cases, only in one case
        there were some checks that didn't affect the end result. This was
        progressively cleaned up in commits e06afb0c9546ddcde1cedd75f59001396ac6fdf2
        and 39bbfa61653ba7c3cca0aed739559914c78edc89, and this one drops
        the last redundant bit.
        
        The only question that remains is: did the initial change
        actually intend this result?
        
        Change-Id: Id26d50f7f7bdfed3bfb436e0c8bbbf6b3a0dbf98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123524
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [e799d70c646748b90879d7b31c2b28fe8c0853d8]

        tdf#141957: sw: Add UItest
        
        Change-Id: I5852844e27e4369271fd35e08a40258a663a5b7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123581
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [16da78d9734885aebe0a2ed93e885c811c13f456]

        sc: remove unused document
        
        This was added in bc28d51cb88c796da241d1ab914bbe6bb174cc49
        < ofz: make ValidNewTabName faster wrt collisions >
        
        <x1sc0> caolanm, I found you added a file in bc28d51cb88c796da241d1ab914bbe6bb174cc49
        but the file is not used at all.
        was it by mistake or you wanted to add it to one of these 'pass' directories ?
        <caolanm> x1sc0, I don't recall what I wanted to do there, I think its safe to just remove that doc now.
        If the slowness returns oss-fuzz will file a timeout bug for it
        <x1sc0> caolanm, ok, I'll remove it then
        
        Change-Id: I8adda62ced1a7b41f001e0ee099a75ef1bdb9ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123591
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-14  Stephan Bergmann  <sbergman@redhat.com>  [a74d15adced66dfcd63fbec0ce23bb4f7089824b]

        [API CHANGE] Remove unused css.resource.XLocale
        
        It had been present ever since at least 88c437c597b604524d50f450506285a594bd03a5
        "moved from api" from 2000, but was apparently never implemented nor used at
        least in OOo/LO itself.  It is problematic as it uses reserved identifiers
        ("getDisplayLanguage_Default" etc.) that contain underscores and start with a
        lowercase letter, and a planned change to unoidl-write will no longer tolerate
        usage of such reserved identifiers (see the TODO in
        unoidl/source/sourceprovider-scanner.l).
        
        Change-Id: I76a3a3da7b7c1f4c109ca7a12c9f07857ca1be1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123544
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-14  Luboš Luňák  <l.lunak@collabora.com>  [58c3dab9e3120fab4db2e9f3c15916a8610cc1b6]

        --enable-lto for distro-configs/* that already use --enable-mergelibs
        
        LTO should now work properly at least on these platforms, and it's
        a couple percent better performance at the cost of build time.
        
        Change-Id: I0b6103161616b730fa32a7dd3b244219dda030fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123585
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c7eef45a876740e7707548734889626727fffebd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 89ebbf38c76bc5ea6e8161adaa2c4a55772b4ecb
          - tdf#139290 Help button for Load Styles to right page
            
            Actually there are multiple Help pages for the same dialog.
            
            The Load Style (writer), Change Master Slide (Impress) and Master Page
            (Draw) all use the same dialog sfx/ui/loadtemplatedialog
            
            Switches were added to select the contents for the right application.
            
            Still, slides and pages terms are mixed in the UI.
            
            Change-Id: I2d48dd8a72fe7b43e92b57299eed1577e355c060
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123529
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-14  Luboš Luňák  <l.lunak@collabora.com>  [59fe5c0a9c3f21dbd2bae7f5886105ab9fc3727c]

        filter out also link.exe messages about LTO code generation
        
        Change-Id: I4f61bfd829429745141cd03eb0db625fe0458e32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123584
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-14  Caolán McNamara  <caolanm@redhat.com>  [6e43569fdfcb5070b6149b34f797008ff9b95809]

        ofz: leak of ScDocument
        
        since...
        
        commit 12ee423c7549ddd2b86dfc3fc6fed2c617dcca7f
        Date:   Mon Sep 13 12:17:37 2021 +0200
        
            tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulas
        
        Change-Id: I66b2d16502868b10c0c1ef59b1c13523c414b62e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [c998691e22ceda15c89d55cf7005201f0392dadb]

        tdf#119083 small improvement to large vlookup sheet insert
        
        Change-Id: Ia1742944fa42dc8a31161d10580b240b2c7c4052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123582
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-14  Noel Grandin  <noel@peralex.com>  [42da199753515584e615cdcdd8601d2ffc27245b]

        more VS2022 integration
        
        so it finds the v143 DLLs
        
        Change-Id: I2bc8b37b681e68b04868cdfe704b2f085b4ea277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [12cac92a7f803808d971071fb091ba8572db587a]

        tdf#144840 Special Paste RTF: Table with merged cells messed up
        
        Revert "tdf#135683 speed up large writer table load"
        
        This reverts commit e3ea0e32657a41b48d9d9d28f6ad15af4c2a7abc.
        
        Change-Id: If36077de62cbff8a3157b0824d4713c10e90f45e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123580
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [57cd44143f6292383020b4d95fc0743125770ebb]

        sc: move test to the right directory
        
        added in 0162cfd55f397ded2af7d32f50cb3cba763c68bc
        < forcepoint#40 null deref >
        
        Change-Id: I4cec8afe07a14ff23267267c57f4cd1478f351ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-14  Ross Johnson  <ross.johnson@homemail.com.au>  [7f5379e040221435548d9be7c8c976378c04489a]

        tdf#33749 - revised merge and unmerge cells UI controls
        
        Revert the two changes made under this issue tdf#33749:
        1) Cell context menu back to 7.2
        2) Format - Merge Cells menu back to 7.2
        3) Help pages to reflect this
        
        Moving forward with the following changes:
        1) Rename "Split Cells" to "Unmerge Cells" (Calc only) which more accurately
           describes it's function in Calc (and for consistency with alternative
           office software).
        2) Add "Merge Cells" and "Unmerge Cells" to Formatting toolbar alongside
           "Merge and Center Cells", including other available user interface
           schemes where possible.
        3) Change the Format - Merge Cells menu icon to the "Merge Cells" icon
           as less confusing than the current "Merge and Center Cells" icon.
           Re-label the Format - Merge Cells menu to Format - Merge and Unmerge Cells.
        4) Add TooltipLabel to .uno:ToggleMergeCells to clarify dual action.
        5) Add Split Cells to Table context menu in Impress (as it is in Writer).
        6) Help pages to reflect changes.
        7) Remove two duplicate entries in the sUnoCommands array in init.cxx
           (one was ".uno:MergeCells" related to this change). This is untested
           but relates to status updates sent to the headless LOK clients. I assume
           duplicate entries would generate duplicate updates, which may be
           harmless but is probably not desirable.
        
        Change-Id: I3063f871707a7286d95108d3a34a5287401baa6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122811
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-10-14  Stephan Bergmann  <sbergman@redhat.com>  [d296a0a271bcce56e15c4d8a577d4e0d368f7533]

        Use more appropriate return type for some editeng functions
        
        ...whose return values are OUString-length related:
        
        * ContentNode::GetExpandedLen from sal_uLong to sal_Int32
        * EditDoc::GetTextLen from sal_uLong to sal_Int32
        * EditEngine::GetTextLen from sal_uInt32 to sal_Int32
        
        Change-Id: Ia5156e247906728e2130b321af15cda7669108ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123576
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-14  Stephan Bergmann  <sbergman@redhat.com>  [900ba7d24e1bfa7e9a2abcb7cb410261f680155a]

        Use more appropriate type for OString-length related variable
        
        Change-Id: I7a2925116928e16381c95b59a45200fa5f05935e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123575
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-14  Julien Nabet  <serval2412@yahoo.fr>  [f28c4ae3c676554723ae5959f15b5766e322cee6]

        Directly initialize vectors in uui
        
        Change-Id: Ifca1362d8ee97640b31ce75b3dc8e819fe32588d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123567
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-14  László Németh  <nemeth@numbertext.org>  [eda5ac4a63fac6bce939b6791dec52270618dc29]

        tdf#145093 sw track changes: fix crash at moving list items
        
        over a tracked paragraph insertion (both in Show Changes and
        Hide Changes modes).
        
        Note: we needed a Python UI test, because uiwriter doesn't crash
        on Linux without this fix.
        
        Likely regression from commit a19dc0d9cc35ae1e200f51d86950595f6771e9c3
        "sw_redlinehide_3: update frames in MoveParagraph()".
        
        Change-Id: I3026c9136e2fa6dcc1f6b5bad1677846a6cfe614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123551
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-14  Justin Luth  <justin.luth@collabora.com>  [036d45b602c2f554f9bcc21fecbc3e3ac5b834da]

        tdf#134426 tdf#138873 sw:  Revert "tdf#79717 ...
        
        ...save/restore character format on selection overwrite"
        which might also fix tdf#144638 as well.
        
        This reverts LO 6.3 commit 6abed0ea006f3616e40faf2ae782cf64f8ac2914.
        
        This 6.3 fix for bug 79717 has caused too many other problems
        that are not being looked at, so it should just be reverted.
        It is spamming document with direct formatting which
        is a terrible thing to have happen by accident.
        It completely wrecks the proper use of styles.
        
        Also revert asscoiated follow-up commits:
        Revert "tdf#79717 save/restore character style on selection overwrite"
        This reverts commit 04bd1925706360414438b814046b543c5e317d0a.
        
        Revert "tdf#79717: sw_uiwriter: Add unittest"
        This reverts commit b05955b480fe4d32852e7be8a118d46ca7e6dbfa.
        
        These effectively revert 12eac5bcbc9b71bf00cb88b918988826229cca35
        but its unit test is left intact.
        
        Change-Id: Ideced4d38bfdf4c82f1744534afbaad29689fded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123566
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [22a79927eec282b65fe71fbdcb9fa2810137b17c]

        Fix memory leak
        
        Change-Id: Ib9d98fa2cb14bb8feaf53941c5b7b18e21c33c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123516
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-14  Miklos Vajna  <vmiklos@collabora.com>  [5c77f3790ff928501c31ebdce12c3a23982c6dd1]

        vcl: avoid "else" after "break" in pdfdocument
        
        Allows indenting less.
        
        Change-Id: I454eba798abdbbd18ffb9c8927ef5bb0215f133f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123565
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [f77479ab33705321db4355ff1d26a60ea777f638]

        sw: remove another unused document
        
        this was added in dc83c34989b366a9740da062e7d7bdca73fd9890
        < tdf#124770 sw layout: handle Word's take on italic formatting vs text
        break >
        but never used
        
        Change-Id: Icf97e7fc9554c0762a91e7eab0841449cdc7fd02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123564
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [02d225f2a46b3d531e187976d8f2c39ed390899c]

        Simplify JsonWriter a bit
        
        Move ensureSpace code to json_writer.cxx, and merge with reallocBuffer.
        The methods are private, and are only used in methods in the same .CXX,
        so the code will get inlined as compiler decides anyway, but becomes
        simpler.
        
        Make extractDataAs* to consider the known size of the data, to avoid
        calculating null-terminated size. To do that, the code is moved from
        extractData to private extractDataImpl, which returns both pointer
        and size.
        
        Change-Id: I7c0e425b5c584089c6e866c31d4cfdb5e242d66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123568
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-14  Mike Kaganski  <mike.kaganski@collabora.com>  [8a017d25a62e878fdd32f189f0663b05d2ffb9cf]

        Avoid COW overhead using css::uno::Sequence
        
        The scenarios are:
        
        1. Calling sequence's begin() and end() in pairs to pass to algorithms
           (both calls use getArray(), which does the COW checks)
        2. In addition to #1, calling end() again when checking result of find
           algorithms, and/or begin() to calculate result's distance
        3. Using non-const sequences in range-based for loops, which internally
           do #1
        4. Assigning sequence to another sequence variable, and then modifying
           one of them
        
        In many cases, the sequences could be made const, or treated as const
        for the purposes of the algorithms (using std::as_const, std::cbegin,
        and std::cend). Where algorithm modifies the sequence, it was changed
        to only call getArray() once. For that, css::uno::toNonConstRange was
        introduced, which returns a struct (sublclass of std::pair) with two
        iterators [begin, end], that are calculated using one call to begin()
        and one call to getLength().
        
        To handle #4, css::uno::Sequence::swap was introduced, that swaps the
        internal pointer to uno_Sequence. So when a local Sequence variable
        should be assigned to another variable, and the latter will be modified
        further, it's now possible to use swap instead, so the two sequences
        are kept independent.
        
        The modified places were found by temporarily removing non-const end().
        
        Change-Id: I8fe2787f200eecb70744e8b77fbdf7a49653f628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123542
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [17d3cacfb9675268e709cfc95771ad4ce8bde75a]

        sw: remove unused document
        
        it was added in 2211a67cc5e577f8abdcc96c9c63865be5fb988d
        < Rewrite import and export of custom dashes in ooxml filter (fix) >
        The test was later removed in f3d6c44c9cb533fe4f1cd28fc95adc36cac4bfd5
        < tdf#108064 OOXML export: keep preset dashes with any line width >
        and it fails if it's reintroduced. No explanation why it was removed
        though, sigh.
        
        Change-Id: Ie7409f64d4f8912634d3871c75d16448de0f5211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123561
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ba68eccbf1524f3d956e777d9e8988ca8514b6a8]

        sw: remove another unused document
        
        it was added in 598d8194b0ea1a64e0ebba28a86c128bafa57c7c
        < Visible function type RTTI for Clang -fsanitize=function >
        which doesn't seem to be related at all
        
        Change-Id: Id74affa131f871b047b7ac4e99964c993908c0b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123562
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-13  Chris Sherlock  <chris.sherlock79@gmail.com>  [be052cbc459266db86c7ddd8daba1d30b7e66d57]

        vcl: DrawPolyLine() did not set metaaction line join or cap
        
        basegfx::B2DPolygon version of DrawPolyLine() doesn't set the metafile
        line cap or join, this fixes this issue.
        
        Change-Id: Id5d73537b0fc5e580789a98b7c5214d586da3cc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122974
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-13  Rene Engelhard  <rene@debian.org>  [c26c9115245a7ed9a6117924d22fcd5634217b99]

        fix (cppunit test) build with --enable-mergelibs again
        
        =/home/rene/LibreOffice/git/master && I=$S/instdir && W=$S/workdir &&  /usr/bin/ccache x86_64-linux-gnu-g++ -pthread -shared -Wl,-z,noexecstack -flto=4 -fuse-linker-plugin -O2  -Wl,-z,origin '-Wl,-rpath,$ORIGIN/../Library' -Wl,-rpath-link,$I/program  -Wl,-z,defs -Wl,-rpath-link,/lib:/usr/lib -Wl,-z,combreloc  -Wl,--hash-style=gnu  -Wl,-Bsymbolic-functions -L$W/LinkTarget/StaticLibrary -L$I/sdk/lib  -L$I/program  -L$I/program  -L$W/LinkTarget/Library -Wl,-z,relro    $W/CxxObject/vcl/qa/api/XGraphicTest.o      -Wl,--start-group  -lcppunit   -Wl,--end-group -Wl,--no-as-needed -lmergedlo -luno_cppu -luno_cppuhelpergcc3 -luno_sal -ltest -lunotest  -o $W/LinkTarget/CppunitTest/libtest_vcl_apitests.so
        /usr/bin/ld: /tmp/cc9oq9Pr.ltrans2.ltrans.o: in function `VclOutdevTest::testDrawPolyLine()':
        <artificial>:(.text+0x9e91): undefined reference to `typeinfo for MetaPolyLineAction'
        /usr/bin/ld: <artificial>:(.text+0xa115): undefined reference to `typeinfo for MetaPolyLineAction'
        /usr/bin/ld: <artificial>:(.text+0xa824): undefined reference to `typeinfo for MetaPolyLineAction'
        collect2: error: ld returned 1 exit status
        make[4]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:799: /home/rene/LibreOffice/git/master/workdir/LinkTarget/CppunitTest/libtest_vcl_outdev.so] Error 1
        make[4]: *** Waiting for unfinished jobs....
        
        Change-Id: I0c22c2b2786660060e39fb272396a6d9af20433f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123530
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-13  Mike Kaganski  <mike.kaganski@collabora.com>  [aff3ce8837e00db6e91d0deb6c4f2ccb0d520c54]

        Improve JsonWriter's escapement code
        
        It should now be conformant to JSON spec; and additionally,
        it escapes two characters that are valid in JSON, but invalid
        in JavaScript (as described in [1]).
        
        [1] http://web.archive.org/web/20201203234157/http://timelessrepo.com/json-isnt-a-javascript-subset
        
        Change-Id: I1081ade89a57fefefde672f2b8fa08e97627fc50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123510
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a86f7a139012b4b49c0420041769c4b68a289eab]

        tdf#124937: sw_ww8export3: Add unittest
        
        sw/qa/core/data/doc/tdf124937.doc was added in
        96acebb72211b4718eb3038c427df37b55b17b0b
        < tdf#124937 reset m_pFirstOfBorderMerge before truncate. >
        but no unittest was added with it.
        Simplify the document and add the test
        
        Change-Id: I505df15d701c2061b33dfb9cd7cfdf95817c1f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123559
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Miklos Vajna  <vmiklos@collabora.com>  [a399b05401fc35ebba4dbd07504fae4a609b3614]

        sw: fix corrupted proxy object for SwGrfNode via the view cursor UNO API
        
        Creating an SwXTextFrame for a graphic node will result in a wrapper
        that has no underlying SwTextNode, as the downcast from SwNode fails in
        SwXParagraphEnumerationImpl::NextElement_Impl(). This is certainly not
        intended, similar code in SwFmDrawPage::CreateShape() handles the text
        node, graphic node and OLE node cases separately.
        
        To make this more problematic, this corrupted wrapper can be still alive
        by the time we try to save to ODT, but the wrapper without an underlying
        SwTextNode will be unable to enumerat the paragraphs of the text frame,
        so it throws, making it impossible to save the document.
        
        Fix this by limiting the TextFrame property of the cursor to actual text
        frames any returning an empty reference in other cases.
        
        If there is a need to access graphic or OLE frames via that API, then
        dedicated properties can be added to expose those different nodes.
        
        Change-Id: I5e97a826271b0d8a1bf262e43cd8516656b37c3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123560
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-13  Mike Kaganski  <mike.kaganski@collabora.com>  [03c474c640d63f54d520712693e2f47976d8d531]

        Unify JsonWriter::put and putRaw a bit
        
        In the process, it turned out that there was unnecessary conversion
        of OStringBuffer to OString and back to OStringBuffer when using
        putRaw, which is avoided now.
        
        Change-Id: I1e3ee685679df0b025bee8f4430624ee5bc9ccb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123547
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [c89f0cd9f6a4b3f77440dd7ea9da08f9cd327711]

        sc: remove unused documents from git
        
        Change-Id: I96590b3be7d34cd7c8f37b27dfa6620a0be335b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [8eb5e4730e5c38bc0187842808d4adeac008a813]

        sc: no reason for this test to be UNX only
        
        Change-Id: Idc61353952b1255f99af5607630c8d38fe17ae7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123558
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Attila Szűcs  <szucs.attila3@nisz.hu>  [537cb82be8fa021fd9382cca874645c75daaef20]

        tdf#144642 XLSX import: round down row height to 0.75 pt
        
        like table layout of MSO does, e.g. 20 pt to 19.5 pt.
        
        Changing table row height is only for interoperability.
        To avoid of regressions, apply this workaround only for
        documents created in MSO.
        
        Note: likely this is an old adjustment for low-resolution
        monitors, where 0.75 is the factor between 96 ppi of Windows
        resolution and (originally) 72 ppi of monitor resolutions.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Ie1e2c781d21174a877b18cd3250eb445222bd1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122428
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-13  Tibor Nagy  <nagy.tibor2@nisz.hu>  [73f26b73aaf562bf934249460480b4a60937a438]

        tdf#124232 PPTX export: fix interactions and hyperlinks on images
        
        Follow-up to commit 9bb91441b46d677860530d8bf9597c96561a1b0a
        "tdf#141704 PPTX import: fix hyperlinks on images"
        
        Change-Id: If29241ea06253e503dae27f8dc762574a5a634de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122717
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [09c988b80976533562e68ffbfaa5e0eec690073d]

        tdf#92586: restore unittest
        
        it was removed in ac84e4ff6135d51461122e0e1b5b39614b3e6eca
        < tdf#94011: load&save more border types > for no apparent reason
        
        Change-Id: I18c4c974de5e519df6f6e7539f95dfb734e4b0aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123557
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Szymon Kłos  <szymon.klos@collabora.com>  [3b84dc9474d0085606a4033db47d2d4891cf40d4]

        Revert "tdf#136141 Sidebar wrap section visible like popupmenu"
        
        This reverts commit 8280491bec32fea5bbdad23f000538d000ed2f24.
        
        Wrap options are not available for Shapes, Media files etc.
        When we insert a shape and select any wrap option from the sidebar - app
        crashes.
        This feature should be implemented first in the code before beeing
        visible.
        
        Change-Id: I1110939e9ee40509e380d003665478889e7a2c24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123374
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123448
        Tested-by: Jenkins

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [528bc20c4e2d79dc769704733f3104fa3cf5e86c]

        sc: remove unused references from git
        
        Change-Id: Ife4b0f0bf345639d927709f27cff125db77859a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123555
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [63e10579db2a77be0db00bec0359aabb30486f4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c984b1f7c6d08c21aa21413980c0bd4408a88a3a
          - Option Compatible vs. Option VBASupport
            
            Change-Id: Ia0327a4bf584b089fbe839c46cf8a6e6c6c576fb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123394
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-13  Tünde Tóth  <toth.tunde@nisz.hu>  [5697e09b3e726a38b58ce31ac0c3a97e7871c74a]

        tdf#144943 PPTX import: fix permission for editing
        
        The passwords for editing in PPTX documents
        created with PowerPoint weren't asked and verified.
        
        Change-Id: I62eb4fd68aac6422c1221a639f4815459ab556c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123130
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a3416ed058884a1fcaae0659ff6e71f5a7dff8d0]

        sd: remove another unused document
        
        Added in 817b35a9c3d69249a79ebaed291bb2d378b3a73f
        < New test files added, tests run for the 1st time >
        and commented out in 744969c4f665dcd5be7793a9b3949d4a0587a6ac
        < improved shapes-test.odp (but not finished), unlocked assertion(false) >
        back in 2012
        
        Change-Id: I8d5d7ae5e0a72c62b2ce01ea1130dc9f5825b166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123553
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [055bcb0ff6595857ee9a07cf27e4d8ee4f4cb51b]

        sd: remove unused smartart documents from git
        
        they were added in 2704821c6b6e829b5ef5c32cdc8eb2a03b6114a9
        < smartart : test documents > but never used
        Remove them until the tests are actually implemented
        
        Change-Id: I5e4f7685f782bf7e7ebae5304b9fb6292fad722c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123552
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [47ac60e223d43c19eda2d596925aafa4a7ee18d1]

        writerfilter: remove a bunch of unused documents from git
        
        Change-Id: I95d6f5780ec43787f7daa75f435f1c918de6a57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123549
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Stephan Bergmann  <sbergman@redhat.com>  [239cc612b478d82d3dd73e3a8d5be310b781a5f0]

        Extend return values < 32-bit on macOS ARM64
        
        <https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms#Pass-Arguments-to-Functions-Correctly>
        only mentions function arguments, not return values in "The caller of a function
        is responsible for signing or zero-extending any argument with fewer than
        32 bits.  The standard ABI expects the callee to sign or zero-extend those
        arguments."  But this appears to also be relevant for return values, where the
        callee apparently has to provide properly extended values:  Without this change,
        in an --enable-optimized build, e.g. selecting "Tools - Macros - Organize Macros
        - BeanShell... - LibreOffice Macros - Capitalize - capitalize.bsh" would not
        enable the "Run" button, as in SvxScriptOrgDialog::CheckButtons
        (cui/source/dialogs/scriptdlg.cxx) node->getType() (which returns a sal_Int16
        value, and which calls DefaultBrowseNode::getType,
        scripting/source/provider/BrowseNodeFactoryImpl.cxx, which in turn calls
        m_xWrappedBrowseNode->getType() on a proxied Java object via the UNO bridge)
        would return a value in	r0 with bits > 16 left with random values, while the
        calling code assumes them to be zero (and exploits that violated assumption with
        --enable-optimized).
        
        Change-Id: Ic99dd9e62b49b44e13cdde6158bef7e2296547f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123550
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-10-13  Regina Henschel  <rb.henschel@t-online.de>  [4e1f5b5eaddac6ff4b3028074edc8f6886d64c3f]

        tdf#145004 remove fontwork text padding for case ScaleX=true
        
        The setting ScaleX=true in property TextPath in CustomShapeGeometry
        is used in import of WortArt of kind 'Follow Path' from MS Office. The
        value 'true' means, that the text is not stretched to the path but its
        original font size is used as long as enough place is available.
        
        The method CalculateHorizontalScalingFactor() has increased the
        scaling factor by 10 percent to make a 'padding'. That results in a
        too short text and a gap at start and/or end. The problem is not only
        visible in imported shapes but in user designed Fontwork shapes too.
        PowerPoint has no 'padding'. Currently our own preset Fontwork shapes
        always use ScaleX=false and therefore are not affected.
        
        I have not found any reason for such padding. So this patch removes it.
        
        Change-Id: I7f2c4eb9101be1f13b006d4178ffbe75eb4ed55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123295
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-10-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [56bdc6ded08ca85d765add0378426ac4356e94d3]

        add some comment to gen-boost-headers
        
        because I can never remember how to run this script
        
        Change-Id: I7782846d192f477096fb315e0b5416d4715d319a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-13  Luboš Luňák  <l.lunak@collabora.com>  [ccf5162e448b4dc6b930ce0354a60253ff70fbc2]

        use LTO to build hunspell if LTO is enabled
        
        Without this, LTO gcc build may fail while linking libmerged because
        of an undefined reference to `std::string::append(char const*)',
        which looks like a gcc bug because std::string should be a template,
        but whatever, this makes it build.
        
        Change-Id: I173cc0c773d5957a0c4a9cecc74c1ab33afad7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123541
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-13  Luboš Luňák  <l.lunak@collabora.com>  [aeef0d4931fea1ef25e907b30e35fcd059394f2d]

        use -flto=auto for gcc if no $PARALLELISM is set
        
        I'm not sure if all gcc versions support the value, but if older
        ones do not they at least silently accept it.
        
        Change-Id: If18ce1cbf6122cf9ded00eee5c2058d70e486c0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123540
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-13  Luboš Luňák  <l.lunak@collabora.com>  [db51f08247961a9dd8d2a083f1d213b49d8ee2b7]

        do not imply --enable-gdb-index just for --enable-symbols
        
        The original idea was to enable gdb index for debug builds, but
        this by mistake enabled it even for optimized symbol builds. Those
        are presumably mostly release builds that also provide debug symbols
        for distributions, but there having a gdb index seems to be a waste
        of space.
        
        Change-Id: I585941aaed1af9e2e4ad85bb278c99c6f12cd858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123538
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-13  Caolán McNamara  <caolanm@redhat.com>  [4fed3b2ed15730fcb7a5b7e0ef09d77bd40436e6]

        ditch problematic HWPFile::Read4b variant
        
        Change-Id: Ied3603d8f96e15013f657fc5d8150969ae3b808d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123534
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec1e3c7751ae8ec8d33d536e782041b2506118d1]

        tdf#145077: sc: Add UItest
        
        Change-Id: Iec8b855f5b3f7dd478a363b1f35a85ed8f697803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123535
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-13  Caolán McNamara  <caolanm@redhat.com>  [d2cf8e960eb352e547350e5aed7a44873697b396]

        ofz: nLen should be of type 'uint' not tools::Long
        
        Change-Id: If0ea7d2156511b325e866f79bf40e32418f7d658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123533
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-13  Roman Kuznetsov  <antilibreoffice@gmail.com>  [d8a1187fc262ccb4c6489b2ca830f230400c5b82]

        tdf#143686 increase a radiobutton's area size
        
        Change-Id: Ib8b6d8b47934a7a2cf68f8977f03ced5f80f6452
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123409
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-10-13  Miklos Vajna  <vmiklos@collabora.com>  [13d1bcfa91b402e024223ebf83ca6fdf15b9ba25]

        CppunitTest_sw_ooxmlexport11: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I56fc863978ba24cd95d86cb0c5ab5d645bbc6614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123532
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-13  Stephan Bergmann  <sbergman@redhat.com>  [a60296694b3af2c18e7aa81eba8782e0ad03f7b8]

        Remove useless check
        
        ...that was introduced with b14107dd0eaf9bfc276544e1900873d36075425e "tdf#133858
        reduce the double-ref range to data content", but which can only ever be either
        true or invoke undefined behavior (as gets reported as
        
        > sc/source/core/tool/compiler.cxx:6412:27: error: comparing the result of pointer addition ‘(((ScCompiler*)this)->ScCompiler::<anonymous>.formula::FormulaCompiler::pCode + -8)’ and NULL [-Werror=address]
        >  6412 |     if (!pCode || !(pCode -1) || !(*(pCode - 1)))
        >       |                    ~~~~~~~^~~
        
        with recent GCC 12 trunk)
        
        Change-Id: I72395f1874343a047afceaa5e342e9e67a51c44f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123531
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-10-13  Luboš Luňák  <l.lunak@collabora.com>  [fb3e13cae8ab0915facaf07fe5fca177a4041a9b]

        MSVC LTO does not like mixing 32bit and 64 code
        
        So disable LTO for x64 code when building for 32bit.
        
        Change-Id: I8445d8307b3b797b78cea12e6322e0d792c71dfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123537
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ad70397c0b940ca7ec0d1de98f15628aa98abec]

        uitest: sc: fix assert
        
        Change-Id: I043c9b1807fe30b24e907eee7954e5d32c170bbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123536
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9a0335e7d2e43e46959bda16daf3fbf5944a1d9a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c0b8265b7148b1860bd47c77e072c3c605b208da
          - tdf#144924 - Change return type of array elements of the split function
            
            If VBA is not enabled, allow the assignment of variables with different data types to the individual array elements created by the split function.
            
            Change-Id: I2acd2088cb4d805c57c25acad9268cb0d703177e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123164
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [241619128c5620dbde4004c83a8d64d2a593a37a]

        gtk4: allow cursoring to move through menus
        
        oddly right arrow works, but left arrow seems to get stuck and pass
        focus into the main window sometimes, but get this partially working
        anyway
        
        Change-Id: I3aca1b8f25bdda5684ce7124b8564233e40d9f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123528
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [5c502a100476c6b57a1a9f4305195c7e2d5d5608]

        tdf#130307 - Support for each loop for objects exposing XIndexAccess
        
        Change-Id: Ib94c642e6d2a52ac7c60a8f7ae3c79d611b41614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123072
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e21f5a6b71790b3a36f67c3915b07a5f5717bcf]

        loplugin:unusedmethods
        
        Change-Id: Ifd3a1ccef68ebc4cd4e7785357e6a476f6669eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [164ec9281aa57d52763e9622adb6e2e37d14bff8]

        Fix typo
        
        Change-Id: I95bd5418d45ec4a0d0ff403244b7727e37b7d075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123443
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee49e597b23c093d25576936d34a8468cb618192]

        loplugin:unusedfields
        
        Change-Id: I5e9bb4417cf6f8e3c1de1c8570e0635fdf6364bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123453
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [738ef11520a9e0e2b7793dc7117d6540fd66db47]

        ofz#39850 remove content anchored to para being removed
        
        Change-Id: I15992b3d995b1c01827637ffb050b5db7213217d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123457
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [a975a5f80fcb6bfa5d656e5647485832bb41d49e]

        ofz#39837 avoid timeout
        
        Change-Id: Icde966364e7d79c52b01abe4c7109fbc5db38b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [bd5d16b5b3c6bdf139c04d6e8ca1310418512244]

        pass 2nd arg of lcl_MinMaxNode by reference
        
        as a pointer it was never null
        
        Change-Id: If242b2dbc39ec3dd407709714741c87c4ef53e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123459
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Eike Rathke  <erack@redhat.com>  [57f09e6f3cfdd9ad4e1673df14e6ee550d402743]

        Resolves: tdf#145077 Use position for jumping to named relative references
        
        For named ranges with relative references construct the resulting
        cell range reference to be selected according to the current cell
        cursor position, same as in Manage Names and as they would result
        if used in a formula expression on that position.
        
        Change-Id: I8362c3e38086337ad90aa84cc7c13f284b41d9fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123450
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-12  Stephan Bergmann  <sbergman@redhat.com>  [c90cb1b3c265c1f81e614e47652fe24137d7928c]

        external/breakpad: Adpat to SIGSTKSZ type in glibc 2.34
        
        <https://sourceware.org/git/?p=glibc.git;a=commit;h=6c57d320484988e87e446e2e60ce42816bf51d53>
        "sysconf: Add _SC_MINSIGSTKSZ/_SC_SIGSTKSZ [BZ #20305]" introduced
        sysdeps/unix/sysv/linux/bits/sigstksz.h containing
        
        > # define SIGSTKSZ sysconf (_SC_SIGSTKSZ)
        
        so that SIGSTKSZ would have type long, causing
        
        > src/client/linux/handler/exception_handler.cc: In function ‘void google_breakpad::{anonymous}::InstallAlternateStackLocked()’:
        > src/client/linux/handler/exception_handler.cc:141:49: error: no matching function for call to ‘max(int, long int)’
        >   141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
        >       |                                         ~~~~~~~~^~~~~~~~~~~~~~~~~
        
        when building ExternalProject_breakpad.  At least SuS4 appears to be silent
        about a required type of SIGSTKSZ defined in signal.h.
        
        Change-Id: I4d87017e10825ef051721f4e9ca751a77bb0d5c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123455
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-12  Luboš Luňák  <l.lunak@collabora.com>  [cd1b2beb0d101ba7b7b83936262c5367094e9d01]

        update --enable-lto description
        
        It's no longer broken with MSVC, and I don't what should be so
        experimental about it when it seems to work just fine.
        
        Change-Id: Ic0c28b3bc6fd2a58071621c395f04f877f862ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123372
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-12  Eike Rathke  <erack@redhat.com>  [bc553f1b52f1865df125e0aefa85d74f57bea6ba]

        Pass rDetails argument from getCellRangeByName() to MakeRangeFromName()
        
        The default MakeRangeFromName() argument ScAddress::detailsOOOa1
        is the same as the only call to this getCellRangeByName(), just
        make it explicit to clarify.
        
        Change-Id: I8eb550df95e6332a459cb9946e7c753887a1655a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123452
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-12  Eike Rathke  <erack@redhat.com>  [7cad3ed2042a17081b56fb2c4a4f4f0b785590f9]

        Construct ScAddress::Details only once
        
        ... instead of 4 times with the implicit conversion ctor.
        
        Change-Id: Ib5df0c278d5a3c7fedf9ddf1d7a52ad01fd67dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123451
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-12  Hossein  <hossein@libreoffice.org>  [9498ec72394dd2a87bde10a181587036cab7b388]

        Move README.wasm -> wasm-qt/README.md
        
        Most of the folders now have README.md in Markdown format and it is
        possible to create html docs out of them which is available at:
        
            https://docs.libreoffice.org/
        
        The content of README file was previously converted to Markdown
        format in commit d19299f579e820c34b38ee56b26125dc30f96ada, so only
        the rename of the README file was needed.
        
        Change-Id: Ib030676a70194fdb24aea066ec985c2f95ee4b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123449
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2021-10-12  Stephan Bergmann  <sbergman@redhat.com>  [fa98d2da9219a03fb1fb0f213a8bdddf5040fe60]

        Revert "Use placement new to avoid one of the allocation calls..."
        
        This reverts commit 503ab1ca9ae11978d9717557546c01ff598aaf88, plus follow-up
        17915ab5202a4d7456e9bc031c3f6a72bc861844 "fix ubsan alloc-dealloc-mismatch".
        It failed to properly destroy the object assembly, and caused e.g.
        CppunitTest_svl_items to fail with
        
        > ==850754==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x6060000024e0 in thread T0:
        >   object passed to delete has wrong type:
        >   size of the allocated type:   64 bytes;
        >   size of the deallocated type: 56 bytes.
        >  #0 in operator delete(void*, unsigned long) at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3 (workdir/LinkTarget/Executable/cppunittester +0x330ae2)
        >  #1 in SfxItemSet::~SfxItemSet() at svl/source/items/itemset.cxx:202:1 (instdir/program/libsvllo.so +0x110ccf6)
        >  #2 in std::default_delete<SfxItemSet>::operator()(SfxItemSet*) const at /home/sbergman/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/unique_ptr.h:85:2 (instdir/program/libsvllo.so +0x1142a28)
        >  #3 in std::_Sp_counted_deleter<SfxItemSet*, std::default_delete<SfxItemSet>, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at /home/sbergman/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:442:9 (instdir/program/libsvllo.so +0x12696e4)
        >  #4 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at /home/sbergman/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6 (instdir/program/libsvllo.so +0xe500b5)
        [...]
        > 0x6060000024e0 is located 0 bytes inside of 64-byte region [0x6060000024e0,0x606000002520)
        > allocated by thread T0 here:
        >  #0 in operator new(unsigned long) at /home/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 (workdir/LinkTarget/Executable/cppunittester +0x32fe7d)
        >  #1 in SfxItemSet::Clone(bool, SfxItemPool*) const at svl/source/items/itemset.cxx:1270:34 (instdir/program/libsvllo.so +0x1127854)
        >  #2 in (anonymous namespace)::Node::setItemSet(SfxItemSet const&) at svl/source/items/stylepool.cxx:65:107 (instdir/program/libsvllo.so +0x1212179)
        >  #3 in StylePoolImpl::insertItemSet(SfxItemSet const&, rtl::OUString const*) at svl/source/items/stylepool.cxx:417:19 (instdir/program/libsvllo.so +0x12103e1)
        >  #4 in StylePool::insertItemSet(SfxItemSet const&, rtl::OUString const*) at svl/source/items/stylepool.cxx:456:17 (instdir/program/libsvllo.so +0x1212ffb)
        [...]
        
        in Clang ASan builds done with -fsized-deallocation.
        
        Change-Id: I3ccba7e7d9712ecabf38a0149252d3cd70cdb446
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123446
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-12  Stephan Bergmann  <sbergman@redhat.com>  [5dd9990a12509ec9326c061544b228652e495fe5]

        Don't #include within extern "C"
        
        At least when building against trunk libstdc++ on Fedora 35 beta now, that
        caused failures like
        
        > In file included from ~/lo/core/libreofficekit/qa/unit/checkapi.cxx:18:
        > In file included from ~/lo/core/workdir/UnpackedTarball/cppunit/include/cppunit/plugin/TestPlugIn.h:8:
        > In file included from ~/lo/core/workdir/UnpackedTarball/cppunit/include/cppunit/plugin/PlugInParameters.h:8:
        > In file included from ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/deque:70:
        > In file included from ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/debug/deque:40:
        > In file included from ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/debug/safe_sequence.h:35:
        > In file included from ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/debug/safe_base.h:32:
        > In file included from ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/ext/concurrence.h:34:
        > ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/exception:83:8: error: declaration of 'terminate' has a different language linkage
        >   void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__));
        >        ^
        > ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/x86_64-pc-linux-gnu/bits/c++config.h:302:10: note: previous declaration is here
        >     void terminate() _GLIBCXX_USE_NOEXCEPT __attribute__ ((__noreturn__));
        >          ^
        
        Change-Id: I81cf87d13c16fd10ce3e2435509ab462852fce2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123447
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-12  Szymon Kłos  <szymon.klos@collabora.com>  [2ed4102a56981e5524a9992ef95e2c980db197fd]

        tdf#145016 calc: don't show selection from other split panes
        
        Change-Id: I636d98b5b95bb7ad51b39c6328440686f0bfd030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123442
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d968425f009598bca3d10964c64f093b8d785c86]

        loplugin:moveparam check for collection params
        
        Empirically, when we are passing a collection type to a constructor,
        80% of the time, we are passing a local temporary that can be moved
        instead of being copied.
        
        Change-Id: I5acc9d761c920691934a4be806a3d3ab6cdbab96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123056
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Hossein  <hossein@libreoffice.org>  [d19299f579e820c34b38ee56b26125dc30f96ada]

        Convert Emscripten README.wasm to Markdown
        
        * Converting README.wasm to Markdown
          + This file will be renamed to wasm-qt/README.md later and
            wasm-qt/README will be removed
          + Filename is preserved in order to make diff understand the change
        
        Change-Id: I908aa84b0fc5ac68e979f6182cda5ad5ef0e791d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123346
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [e0ccbbf5011703fd8f5f36d8d8c93205644a1201]

        uses of icon_filename are gone
        
        since
        
        commit e58a5f6db6d13d078f12c3496f46c227c6943c48
        Author: Chris Mayo <aklhfex@gmail.com>
        Date:   Wed Nov 11 19:27:52 2020 +0000
        
            Remove obsolete GNOME 2 MIME types files
        
        Change-Id: I31e2c8351d8893f3f0336a19b8ef9b53b8ab8555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Caolán McNamara  <caolanm@redhat.com>  [074644e2b5c0997f1b239eeb8c72712b7f01aeb4]

        document-new shouldn't get prefixed to become libreoffice-document-new
        
        seen by rpminspect as .desktop "references icon libreoffice-document-new
        but no subpackages contain libreoffice-document-new"
        
        introduced by:
        
        commit f767d5e2b017c0d0cfd23ff3318cb30901847722
        Date:   Sun Sep 1 11:30:12 2019 +0200
        
            Add icons to New Document desktop file actions
        
        in the [Desktop Action NewDocument] section
        
        Change-Id: I64ce5e2dbaca32083b2f76e960c33a815f8a3773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123444
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-12  Julien Nabet  <serval2412@yahoo.fr>  [50602fed86b2b972d49d6c6366b2a3eb406e4ed4]

        Try to fix Ubsan TB
        
        /sw/source/core/text/inftxt.cxx:651:37: runtime error: downcast of address 0x6060006542c0 which does not point to an object of type ´const SwTextPortion´
        0x6060006542c0: note: object is of type ´SwBookmarkPortion´
        3f 07 00 26  d0 ca 08 e3 2b 2b 00 00  2d 00 00 00 00 00 00 00  49 01 00 00 00 00 00 00  60 42 65 00
                     ^~~~~~~~~~~~~~~~~~~~~~~
                     vptr for ´SwBookmarkPortion´
        0x2b2bda76d6b7 in SwTextPaintInfo::DrawText_(rtl::OUString const&, SwLinePortion const&, o3tl::strong_int<int, Tag_TextFrameIndex>,
        o3tl::strong_int<int, Tag_TextFrameIndex>, bool, bool, bool, bool) /sw/source/core/text/inftxt.cxx:651:37
        
        Taking a look at some other locations in the same file, it seems we need to test "rPor.InTextGrp()" to consider rPor as a SwTextPortion
        
        Change-Id: I1739182a65f6738dad8623ec22950d797c59a6c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123356
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-12  Michael Stahl  <michael.stahl@allotropia.de>  [40d70d427edddb589eda64fafc2e56536953d274]

        xmlsecurity: add tests for multiple X509Data/X509Certificate
        
        Change-Id: If50ae8156f81c1053aa8fbfc3148da64bb8e1442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111666
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-10-12  Michael Stahl  <michael.stahl@allotropia.de>  [e5a0acda428fed64b9ba69365d6a54fbffa0727b]

        xmlsecurity: add test for timestamps
        
        Change-Id: I6ce64ca7c59639684779144ed0ed8d36c4aca32b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111665
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [224953d896a3dba5d85992394525ab8b54d8c314]

        loplugin:moveparam in various
        
        Change-Id: Ifa7c8ff2b21f63d234c29c28303d0bacd376c1e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123434
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Jan Holesovsky  <kendy@collabora.com>  [d602c433a08c6df28198ceb61b95f5c6d85d1a87]

        T602 is an obsolete format, don't assume .txt files are T602
        
        Without this, when the user tries to open a 0-bytes .txt file, they are
        asked for a Save As operation after they hit the Save button.
        
        When we remove the 'txt' from the T602 detection, it rather asks if the
        user wants to use ODT or Plain text (and lose formatting).
        
        Change-Id: Ic48fa61064a9ed78c64d56bc8864f0e12528e072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123216
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-10-12  László Németh  <nemeth@numbertext.org>  [bcc06060bb286bd71a8fd1707eb499c8d2a88b69]

        tdf#145066 sw change tracking: fix bad deletion at Move Up/Down
        
        In Show Changes mode, moving a list item over
        a deleted list item resulted the bad deletion
        of the next adjacent paragraph, too.
        
        Note: For manual testing with a non assert build,
        put cursor in list item 2, click on Move Down once,
        Move Up twice to show the bad deletion.
        
        See also b5ab4836c03e9428aff6a48843f2a054ceff0f85
        "tdf#39721 sw change tracking: fix move down".
        
        Change-Id: Ie4dd1089dea4ed7068db94b134cd31881463c9ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123378
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-12  Mark Hung  <marklh9@gmail.com>  [d27187b158d7e3f92180b1f2ab79b048dc5318a5]

        vcl:use unique_ptr<SalWinGraphics> in WinSalPrinter
        
        to replace plain SalWinGraphics pointer, and get rid
        of delete.
        
        Change-Id: If06df98a8ebfdf5797bddfefa37647522b8e711b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4913a56c07914708d8272ae211e23b73349e673]

        loplugin:moveparam in various
        
        Change-Id: I522d03ffdaafcfe364425b4135249492879e3d5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123429
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [2c596b694a641de1b18afb1e9a5b843df638af24]

        loplugin:moveparam in sdext
        
        Change-Id: I46e0f73f67cffb11ab5f1cf2453450a3066eb1fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123425
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-12  Miklos Vajna  <vmiklos@collabora.com>  [4da10f6931166ddef04aa2731c52e9b401303bb3]

        sw layout xml dump: show type even for multi-portions
        
        The old SwPortionHandler-based approach doesn't handle multi-portions.
        
        Change-Id: I2473e61c19cd7aa134614f96505e10bebf1d0017
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123428
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [5b2848413883565c48d312c96daf8fbca25405d8]

        clang does not support -flto=<number>
        
        This may happen when building with GCC when Clang is used for Skia
        and --with-parallelism is in effect.
        
        Change-Id: Ic52dbbcf53253ed73413af4ea8254b000eee72d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123430
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [9402579be9d9a8888af03291edd2478a716f901a]

        avoid O(n^2) in VclEventListeners::Call() if possible
        
        The list seems to only rarely change.
        
        Change-Id: Ib1263c696619908a2792c67ff04c5a0c5f0a7858
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123414
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [1c46d2cabfa9cffd65599e55ca4060e39dcbad62]

        loplugin:moveparam in forms
        
        Change-Id: Ib3a6058e933eb7030cd6d7aef335f12fbd4e6bd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a6bd120d8a09e6289ea372935cca40635b99b2e]

        loplugin:moveparam in svgio
        
        Change-Id: I4badd081340c9f8e8fcce97bd730f9c7da046382
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123426
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [c36f569242a116f88749f9c5e2cd449351a39ea4]

        loplugin:moveparam in cui
        
        Change-Id: I059fae3520b06bc733721fe130cf41da13803b9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [01bb611effe7de983e4872a33fe849e4d0fc7874]

        loplugin:moveparam in reportdesign
        
        Change-Id: Ifefccc5d500331960baa8a48bb9ed64c86c91f9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123424
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a514c3966381fdb13f9789745359522ef5509c8b]

        loplugin:moveparam in lotuswordpro
        
        Change-Id: I122fc96930021dd3127d9c991e7dac3140b612f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123427
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d6352b6561c50b7622cfd4314ffcd2766a31108]

        loplugin:moveparam in filter
        
        Change-Id: I4f41f834035fcefc22486723c971929890143dd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [a43b684267a42f733cb5d752cddfe307ce4a0077]

        gtk4: fix asserts and crashes on context menu popdown
        
        Change-Id: Iad87892e5e1474118138c07558dc37d793e5bfdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Michael Stahl  <michael.stahl@allotropia.de>  [c876183e4c0aff0fe95145c6ee4a84b213a54190]

        cppuhelper: suppress unhelpful warning C4996
        
        ... that happens while implementing the class declared as deprecated
        with MSVC 2019.
        
        cppuhelper/source/typeprovider.cxx(33): warning C4996: 'cppu::OImplementationId': Uses broken double checked locking
        
        Change-Id: I469fe38bd276a554b1ef006d3da270b85f26554b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123422
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-11  Miklos Vajna  <vmiklos@collabora.com>  [869e554a017d57da14b0c5b1e1f6ce742db316e0]

        sw XHTML export: fix missing <li> around nested <ul>/<ol>
        
        This was fine in practice in the HTML case, so make it conditional on
        the XHTML flag for now.
        
        Change-Id: Ie96357ba78f4a7fae125165c1c4e47c3f5686ddf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123421
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [3739253b35212f45dd1654286db5e97b70589a57]

        loplugin:moveparam in sw
        
        Change-Id: I4fa524e4abb101ed0ff1b8f97b84582b84aa1d07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123387
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [043ba6ddf8d90b04acfae8ec836c4b772fb36754]

        loplugin:moveparam in slideshow
        
        Change-Id: I67ec3e8b7f5a9b6f6463dace95ab7e4a64469d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [47331ae6f95070ff7460e541895895b59eb15103]

        loplugin:moveparam in jvmfwk
        
        Change-Id: I78970269bfd3eb7ad6b069ac99eeee707619d3e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a499b4364dfdf3f921c9ea0cca71dd7bca32cb4]

        loplugin:moveparam in framework
        
        Change-Id: I423fa6a4f4fea5a27ec69f65dac952eff42d3d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [0eb51b92e0c528b2b5c1f0d8011b70c808c81605]

        loplugin:moveparam in package
        
        Change-Id: I681a6b0b30aeff9a51e36050629d8a617797a21f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [ba535d8cbda1026823ce9796c20f97b7367d581f]

        tdf#145030 resync with empty selection if we unselected everything
        
        if we had something selected, but ended up unselecting everything then
        while the maSelectionLock is unlocked resync with the empty selection
        
        (git show -w)
        
        Change-Id: Idf3ad1ce93e4dcf94dc79332cbb431dc5d896988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123420
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [83cadf937ff9a0fd4ca24627673d45d1bab8c914]

        tdf#145033 remove old focus handler so no double-connect attempt is made
        
        doesn't hurt in this case, but we assert because it has been a fairly
        common problem in the past
        
        Change-Id: Id312c8d2693df803962c265a9a49926d8df04cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123413
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [8fb4889840a6c79f6bad7bb7a322d86b751cdd93]

        Related: tdf#145033 don't print "There is no implementation..." warning
        
        don't output "There is no implementation for QueryValue for this item!"
        for SfxObjectItem
        
        Change-Id: Ib4b944efa7e9d152d662ed447d8c02ec24d58391
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123392
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Stephan Bergmann  <sbergman@redhat.com>  [6a515900f93e46af40c7d8cc8ced6fffda1d8ffa]

        loplugin:stringview (macOS)
        
        Change-Id: Id95f0306484b18fea057553c19c6a0f08d15c784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123379
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b86c11194dcb8375de38865ec1bf54ee59bffa2]

        loplugin:moveparam in cppuhelper
        
        Change-Id: Idb6b4794e542791b5cf38b611c5d70a34fbe23b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [126510981b3a71bf0e73551938c483f14281d3c4]

        loplugin:moveparam in sd
        
        Change-Id: Ia29e29d9af21dbd9bfb846db03f0100832835352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [f477b54e01766fabc0179beec9aa3dc31b5824e2]

        loplugin:moveparam in sc
        
        Change-Id: I4b9d45a6b0231841a5fe00d0193a8530b9e05559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [071c117ba551e579962ff5b70f79cb7934d96c77]

        loplugin:moveparam in writerfilter
        
        Change-Id: Iabc09d0388da68ee5bb74c75125b8dd8d75a5a73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123386
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd5dc5fa113b2e346d18fa2edaeea2347e4eb9f9]

        loplugin:moveparam in extensions
        
        Change-Id: Ibbf0fff9a3540d4f723b91e2979e4465648ff203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123385
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebb636473f6813a151dda07e4c2ae0960e684b2b]

        loplugin:moveparam in desktop
        
        Change-Id: Ie96a3887876bf9a0bb13ae4a69d1685186a4e9b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123384
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [433492d50a1db601b0c2b7e375cead5f59910a31]

        loplugin:moveparam in sfx2
        
        Change-Id: I5408e47d6e2179bc34170c1728aa16e327ffbe56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [dc328fdfa709929377de2be5f86f2e811a5eaa21]

        valgrind: use after free on applying "default character" character style
        
        seen in writer in fresh document, type some text, right click for
        context menu, select "character" submenu, and select "default character"
        
        ==3296268== Invalid write of size 8
        ==3296268==    at 0x3E6EDE34: SwpHints::Register(SwRegHistory*) (ndhints.hxx:195)
        ==3296268==    by 0x3E6EDE88: SwpHints::DeRegister() (ndhints.hxx:197)
        ==3296268==    by 0x3E747E06: (anonymous namespace)::lcl_InsAttr(SwDoc&, SwPaM const&, SfxItemSet const&, SetAttrMode, SwUndoAttr*, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:1930)
        ==3296268==    by 0x3E74449F: sw::DocumentContentOperationsManager::InsertPoolItem(SwPaM const&, SfxPoolItem const&, SetAttrMode, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:3505)
        ==3296268==    by 0x3E9F3F12: SwEditShell::SetAttrItem(SfxPoolItem const&, SetAttrMode, bool) (edatmisc.cxx:145)
        ==3296268==    by 0x3F6F860F: SwDocShell::ApplyStyles(rtl::OUString const&, SfxStyleFamily, SwWrtShell*, unsigned short) (docst.cxx:1154)
        ==3296268==    by 0x3F6F5F94: SwDocShell::ExecStyleSheet(SfxRequest&) (docst.cxx:505)
        ==3296268==    by 0x3F983994: SwBaseShell::Execute(SfxRequest&) (basesh.cxx:1071)
        ==3296268==    by 0x3F981744: SfxStubSwBaseShellExecute(SfxShell*, SfxRequest&) (swslots.hxx:2180)
        
        ==3296268==  Address 0x4576dd00 is 176 bytes inside a block of size 192 free'd
        ==3296268==    at 0x4843669: operator delete(void*) (vg_replace_malloc.c:802)
        ==3296268==    by 0x3E76A3C3: std::default_delete<SwpHints>::operator()(SwpHints*) const (unique_ptr.h:85)
        ==3296268==    by 0x3E76A31F: std::__uniq_ptr_impl<SwpHints, std::default_delete<SwpHints> >::reset(SwpHints*) (unique_ptr.h:182)
        ==3296268==    by 0x3E76A279: std::unique_ptr<SwpHints, std::default_delete<SwpHints> >::reset(SwpHints*) (unique_ptr.h:456)
        ==3296268==    by 0x3EFE14C5: SwTextNode::TryDeleteSwpHints() (ndtxt.hxx:846)
        ==3296268==    by 0x3F028AB2: SwTextNode::RstTextAttr(SwIndex const&, int, unsigned short, SfxItemSet const*, bool, bool) (txtedt.cxx:631)
        ==3296268==    by 0x3F003D77: SwTextNode::SetAttr(SfxItemSet const&, int, int, SetAttrMode, SwTextAttr**) (thints.cxx:1908)
        ==3296268==    by 0x3E747DE7: (anonymous namespace)::lcl_InsAttr(SwDoc&, SwPaM const&, SfxItemSet const&, SetAttrMode, SwUndoAttr*, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:1928)
        ==3296268==    by 0x3E74449F: sw::DocumentContentOperationsManager::InsertPoolItem(SwPaM const&, SfxPoolItem const&, SetAttrMode, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:3505)
        ==3296268==    by 0x3E9F3F12: SwEditShell::SetAttrItem(SfxPoolItem const&, SetAttrMode, bool) (edatmisc.cxx:145)
        ==3296268==    by 0x3F6F860F: SwDocShell::ApplyStyles(rtl::OUString const&, SfxStyleFamily, SwWrtShell*, unsigned short) (docst.cxx:1154)
        ==3296268==    by 0x3F6F5F94: SwDocShell::ExecStyleSheet(SfxRequest&) (docst.cxx:505)
        ==3296268==    by 0x3F983994: SwBaseShell::Execute(SfxRequest&) (basesh.cxx:1071)
        ==3296268==    by 0x3F981744: SfxStubSwBaseShellExecute(SfxShell*, SfxRequest&) (swslots.hxx:2180)
        
        ==3296268==  Block was alloc'd at
        ==3296268==    at 0x4840FF5: operator new(unsigned long) (vg_replace_malloc.c:417)
        ==3296268==    by 0x3E76988F: SwTextNode::GetOrCreateSwpHints() (ndtxt.hxx:837)
        ==3296268==    by 0x3E747D0F: (anonymous namespace)::lcl_InsAttr(SwDoc&, SwPaM const&, SfxItemSet const&, SetAttrMode, SwUndoAttr*, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:1923)
        ==3296268==    by 0x3E74449F: sw::DocumentContentOperationsManager::InsertPoolItem(SwPaM const&, SfxPoolItem const&, SetAttrMode, SwRootFrame const*, SwTextAttr**) (DocumentContentOperationsManager.cxx:3505)
        ==3296268==    by 0x3E9F3F12: SwEditShell::SetAttrItem(SfxPoolItem const&, SetAttrMode, bool) (edatmisc.cxx:145)
        ==3296268==    by 0x3F6F860F: SwDocShell::ApplyStyles(rtl::OUString const&, SfxStyleFamily, SwWrtShell*, unsigned short) (docst.cxx:1154)
        ==3296268==    by 0x3F6F5F94: SwDocShell::ExecStyleSheet(SfxRequest&) (docst.cxx:505)
        ==3296268==    by 0x3F983994: SwBaseShell::Execute(SfxRequest&) (basesh.cxx:1071)
        ==3296268==    by 0x3F981744: SfxStubSwBaseShellExecute(SfxShell*, SfxRequest&) (swslots.hxx:2180)
        
        Change-Id: Ic76b64d106dcba34087d4effa60b0b84447168d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123376
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Stephan Bergmann  <sbergman@redhat.com>  [4f5b3e4bd53d6d61df1f65f496f7bc8dc525c8a1]

        In O[U]StringBuffer, make string_view params replacements for OUString ones
        
        ...for LIBO_INTERNAL_ONLY, instead of having them as additional overloads.  That
        way, loplugin:bufferadd and loplugin:stringviewparam found many further
        opportunities for simplification (all addressed here).  Some notes:
        
        * There is no longer an implicit conversion from O[U]String to O[U]StringBuffer
        (as that goes via user-defined conversions through string_view now), which was
        most noticeable in copy initializations like
        
          OStringBuffer buf = someStr;
        
        that had to be changed to direct initialization,
        
          OStringBuffer buf(someStr);
        
        But then again, it wasn't too many places that were affected and I think we can
        live with that.
        
        * I made the O[U]StringBuffer ctors taking string_view non-explicit, mainly to
        get them in line with their counterparts taking O[U]String.
        
        * I added an OUStringBuffer::lastIndexOf string_view overload that was missing
        (relative to OUStringBuffer::indexOf).
        
        * loplugin:stringconstant needed some addition to keep the
        compilerplugins/clang/test/stringconstant.cxx checks related to
        OStringBuffer::append and OStringBuffer::insert working.
        
        * loplugin:stringviewparam no longer needs the special O[U]StringBuffer-related
        code that had been introduced in 1250aecd71fabde4dba990bfceb61bbe8e06b8ea
        "loplugin:stringviewparam extend to new.."
        
        Change-Id: Ib1bb8c4632d99b744e742605a9fef6eae959fd72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122904
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-11  Mark Hung  <marklh9@gmail.com>  [5f84c44e3d5ff19b800b6358e61228546e318d4f]

        tdf#142407 fix incorrect number of lines in vertical writing.
        
        Wrting mode isn't read correctly. The property PROP_WRITING_MODE
        contans an Any of sal_Int16. When converting to WritingMode
        enum directly, it always get WrtingMode::LR_TB(0), hence use wrong
        side to calculate number of grid lines for vertical writing.
        
        The resulted number of grid lines are much smaller than expected,
        it ends up leaving large space between header and text.
        
        Change-Id: Ifb0ff09fe981819cc2705de8d5596190f320f79e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123223
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-10-11  Mark Hung  <marklh9@gmail.com>  [8ac8a20ed15bb458e1ee5a8df2b97aef05ca4f7c]

        tdf#141957 include the size of header and footer.
        
        Text grid dialog didn't include the size of header and footer,
        so if any of them are included, the resulted number of lines or
        chars per line was wrong.
        
        Change-Id: I09c1eed1552485adf75ad75cfaf25b99f8eec1e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123215
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [0095e0412eb4595aca548909fadeb36cd3d1728f]

        add coverity[uninit_member] to explanation
        
        Change-Id: I3aefd74b9fb940b9c7485a1c1b989a43912fdb60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123368
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Stephan Bergmann  <sbergman@redhat.com>  [57ffa96d413df2712b15355f49294e564bd0d996]

        Fix font weight comparisons
        
        ...after 2d486bac81e06c64d13c647f35d3f4affbeb183e "tdf#143959 sdext.pdfimport:
        call vcl::Font::identifyFont directly" changed the left-hand sides from
        aFontDescriptor.Weight of type float to aFontReadResult.GetWeight() of type
        FontWeight from include/tools/fontenum.hxx.  (Diagnosed as
        
        > sdext/source/pdfimport/wrapper/wrapper.cxx:624:45: error: comparison of enumeration type 'FontWeight' with floating-point type 'float' is deprecated [-Werror,-Wdeprecated-enum-float-conversion]
        >               if (aFontReadResult.GetWeight() == com::sun::star::awt::FontWeight::THIN)
        >                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        
        in a --with-latest-c++ build.)
        
        Change-Id: I0c661fc27eefa478808f796ffb9a7586e1e671c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123375
        Reviewed-by: Kevin Suo <suokunlong@126.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7c22593d16d304264d3a343b549bf188975cdd6]

        loplugin:moveparam in canvas
        
        Change-Id: I12538ca8c3578f37a4ef1e40640f5324bbdbb1d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123371
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [13fa6834c96d3607b44c48027e50b12024cc9f1d]

        loplugin:moveparam in xmlsecurity
        
        Change-Id: I3ce77ab82529f13c5e55ea30c813f66cb5180877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [819a4064ba03f230a4b2936662adbe56f478f8db]

        loplugin:moveparam in ucb
        
        Change-Id: I61a7910f3ef15b251b1763b7c56848ccbb22fe91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6a3cb1545290d822455b7c3259702a1d1afc8ef9]

        loplugin:moveparam in formula
        
        Change-Id: I358f5e8031c235be76bb96591bf33f59a39b00ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123350
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea014c324a9f5fff344c3fccdfcb0e5bcbe75d81]

        loplugin:moveparam in chart2
        
        Change-Id: I6a47abf80f0f45bbb55bc9e0fe817f3c3650aff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123351
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7f8a54e05dab430cf2f5b3e1fa90e729c7a5601]

        loplugin:moveparam in dbaccess
        
        Change-Id: Iff4c5069d25dddd58d61b2a09a57a112854144da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [2938f0956744e03ba0cc27a5b3fb1637811b267a]

        vcl: test OutputDevice::DrawPolyLine()
        
        Change-Id: Iac95e0d08043153c877c204fa40aa90b3b974156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122973
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [ef4ad5f871c6ca4cfd84504752d17ed2969ff90d]

        vcl: test OutputDevice::DrawWaveLine()
        
        Change-Id: I31391416b1633635ce7be7b4a445008d3e5ebde6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122972
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [545f993d86148f550a58e02c0bdefb04222ac5fe]

        vcl: test OutputDevice::DrawBorder()
        
        Change-Id: I627cf9a8f9f6697a7e01cef9356b298e0a2b21f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122971
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [debf76437f181e4e8aa61b0fc159738ad9312c73]

        vcl: test OutputDevice::DrawCheckered()
        
        Change-Id: Ie6e4f626954961f874cc47bfdf6434ae496e9c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122894
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [a35c63e19891a1f7cebb54746ca9793c30b16b95]

        vcl: ensure test VDevs are always bigger than operation being tested
        
        Change-Id: I4b57db489e950d75929be51210c113e6a149b534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123222
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Chris Sherlock  <chris.sherlock79@gmail.com>  [2a548383d7a8772e19652a2830db7b2ce009f0af]

        vcl: fix issue in testErase()
        
        Funnily enough, this *could* still be a valid test because
        SetOutputSizePixel() acutally triggers an Erase(). But that's not really
        the point, the test is brittle because we possibly may remove the Erase
        from that function one day.
        
        This sets the actions we test to the *second*, explicit Erase we are
        actually testing.
        
        Change-Id: Ib0bb4693a90ad2a4756f93a8933db95d337950c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123236
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [8032e4692b518a0189705f748267f08e3e412976]

        cid#1492820 WMI: Inefficient Map Iterator
        
        Change-Id: I2a220d5f8178dc96bb930600d51884c245128324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123366
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [66e5317a91475ab5f7c796f023431d6a642fd60e]

        loplugin:moveparam in unoidl
        
        Change-Id: Id3069cad0b118b5593bb7a0faa9d7e33e5bef168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [bbe9bfee56ce395c5fa1c1173e9909925a3a6393]

        fix MSVC mergelibs build
        
        Linker complains about duplicate symbols for the template, seems
        to be a case of
        https://codesynthesis.com/~boris/blog/2010/01/18/dll-export-cxx-templates/
        
        Change-Id: Iaffa3ba55edf4e54c62757c64d6b340b55a514cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123362
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [0328bd0adeafafaa79501a1cf31557fd4c7a6c2a]

        remove unused variables
        
        The if is even wrong, testing for WINNT nested inside testing
        for not WINNT.
        
        Change-Id: I797ff61099064f1b66fea34fb25a00a88df4fca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123255
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Caolán McNamara  <caolanm@redhat.com>  [5fc2ef45531cb4777712109433cc3f655a2f7b1c]

        cid#1492337 Unintended sign extension
        
        Change-Id: Ic5956d1c87a1461fcd1555767f7f83123b87b5e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123367
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [64937ff98a970050b0d5d89e3a4734d93e13ad00]

        loplugin:moveparam in unotools
        
        Change-Id: Idd014c93e2e85d2ffc7a2535a9c65cffc8a9d403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123348
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Miklos Vajna  <vmiklos@collabora.com>  [81a1691cfb1290dc7ccc274cf3abc8ea91c73d55]

        sw: prefix members of SwDLL, SwFieldDlgWrapper, SwImplShellAction and ...
        
        ... SwModelessRedlineAcceptDlg
        
        See tdf#94879 for motivation.
        
        Change-Id: I06299afbbba2a52f08526ef9e7bb9c5892c7a7eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123361
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-11  Kevin Suo  <suokunlong@126.com>  [2d486bac81e06c64d13c647f35d3f4affbeb183e]

        tdf#143959 sdext.pdfimport: call vcl::Font::identifyFont directly
        
        Previously the unittest testTdf143959_nameFromFontFile did not
        fail even if the fixing code in wrapper.cxx is removed.
        That was because the "if (xHolder.is())" condition is always false
        in the unittest run, which suggests that the calling of
        com.sun.star.awt.FontIdentificator through the uno did not work
        in some circumstances. See comments in:
        https://gerrit.libreoffice.org/c/core/+/120815
        
        In this patch, we call the vcl::Font::identifyFont directly rather
        than through the uno calling. This is proven to work in both the
        manual and unittest running.
        
        Change-Id: I6334bca2defaa27cf6ac72af3d621fbb59e57980
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123358
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Kevin Suo  <suokunlong@126.com>  [4eef83dc4a8879f21ee6c98226510ac728bc317a]

        sdext.pdfimport tdf#78427: Add support for more Font Weight features
        
        ...e.g. Thin, Extra-Light, Light, Semi-Bold, Bold, Extra-Bold and Black.
        
        Previously the xpdfimport code passes the isBold value which is bool value.
        sdext.pdfimport accepted this value from the xpdfimport output and check
        whether a font is bold or not. However, there are many other FontWeight
        features more than a "bold".
        
        This patch changes the isBold to the GfxFont::Weight type, and changed the
        sdext.pdfimport isBold bool type (in FontAttributes) to an OUString fontWeight.
        The value for the fontWeight is set according to the GfxFont::Weight passed
        by xpdfimport, and then this fontWeight is passed to the ODF xml generation
        stage and used there directly.
        
        Now the Semibold and Light (as shown in the unittest file) can be currectly
        handled. However, for other weights the parseFontFamilyName still need to
        be updated, but before doing that I plan to refector this function as the
        current logic is very difficult for maintennance.
        
        Change-Id: If2ce5f0f41c83843d8a6aeb30134b3faf99ba877
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f60214a1ad45f947d063e4cfdbeb86bd819ab87c]

        Fix gpgmepp build with glibc
        
        posix-io.c: In function '_gpgme_io_spawn':
        posix-io.c:492:23: error: void value not ignored as it ought to be
          492 |             while ((i = closefrom (fd)) && errno == EINTR)
              |                       ^
        make[1]: *** [Makefile:964: posix-io.lo] Error 1
        
        Change-Id: I0e7abc33200ca7436c72e925447e681fd241c6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123259
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-11  Balazs Varga  <balazs.varga991@gmail.com>  [12ee423c7549ddd2b86dfc3fc6fed2c617dcca7f]

        tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulas
        
        XLSX round-trip resulted corrupt XLSX with invalid named
        range, triggering Excel file repair, because of incomplete
        handling of external file reference of the named ranges
        (tdf#144636).
        
        Cache external named ranges and their formulas in case
        of updating formulas without data loss. Also we can copy
        cell formulas and we get valid results of formulas from
        the cached tables, instead of an error type.
        
        Now Calc resolves the external file reference of the named
        ranges, e.g. see "rangenameinotherfile" of the unit test
        document in Manage Names (Ctrl-F3). After the fix, it contains
        full path of the external file, and recalculating
        the sheet or changing data in the target file reveals that
        the named range works correctly (tdf#144397).
        
        Change-Id: Ic011a29290f8cabcc39fdc4b8d775ecf9d33612f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122026
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [c53a8aef805e59bbafb1943e5be49a6529645638]

        merge LD_PLUGIN use with other LTO use
        
        It seems LD_PLUGIN predates the other --plugin usage, so make
        that one use LD_PLUGIN instead of using --plugin twice.
        
        Change-Id: I00133be18e576bc9a797853621a20dd7d5245344
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123257
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Luboš Luňák  <l.lunak@collabora.com>  [cca8c5ad553e21bd55aef93757cd31626f9beba1]

        use ThinLTO for Clang everywhere
        
        No idea why it should be used only on Apple platforms and normal LTO
        elsewhere. ThinLTO should build faster and the result should perform
        roughly the same.
        
        Change-Id: Ie93cf0ba810ee5bb2309fcbd3548a4847587b3d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123256
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Luboš Luňák  <l.lunak@centrum.cz>  [d9275ea76b170e9cd74ebcd5af6255cb28e6cfdb]

        remove unused forward declarations
        
        The class has been moved to vcl::font namespace, so these are wrong,
        which means they are unused.
        
        Change-Id: Ie24dfe4afbe78f03e3aa54cf2983bd45a4735a37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123330
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [5041b1491a183366ca44380bd0f5dfb7c0acc5fb]

        Drop unused 'using namespace' here
        
        Change-Id: Iffd9e68cbefae664374ca8ad75441f899b849f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123168
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [3e11faf2d263f97a96274a8247b5a123ec8fe7c6]

        Expand some defines and simplify loops
        
        Change-Id: I5cbfa815fb2b3d92eac1959ece67160fae4cd556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123170
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [56883788d0090383dad58552f5a11044ffe64a44]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 152530c4360c80e9a052c4c883a8e4d53001f364
          - Create documentation for Basic "New" operator
            
            Change-Id: I11157f8db43811a107eb5270db5b39c351b37dcc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123159
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-11  Alain Romedenne  <alain.romedenne@libreoffice.org>  [22158900a7398d3648863e8c96d7f99960f63ad3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 79cf3e922b00a74a6a29ec324589aab7f05c5886
          - Running Python Interactive Console:
            
            - Provide a non ambiguous capture
            - Present APSO console as optional
            - Provide GNU/Linux appropriate information
            
            Change-Id: Ice7069242fc900b5c7c60a576671f62f841a313d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122732
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-11  Mike Kaganski  <mike.kaganski@collabora.com>  [782836ec8b736e5110b44016be8f73b068444911]

        Simplify one matchIgnoreAsciiCase overload
        
        Change-Id: I982a5fd893b94085d30aeb595640d46cac4acdf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123169
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-10  Julien Nabet  <serval2412@yahoo.fr>  [deae8bab12513ad09f432e5f65ea1768064b4d2e]

        Revert "Initialize nDXBuffer array (vcl/edit)"
        
        This reverts commit 00ee02ea26a070d630160ef5c51f36ab093a9b53.
        
        as suggested implicitely
        
        Change-Id: I48aed1f48dca493c486f738dca895b1c00027066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123171
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-10  Julien Nabet  <serval2412@yahoo.fr>  [00ee02ea26a070d630160ef5c51f36ab093a9b53]

        Initialize nDXBuffer array (vcl/edit)
        
        Change-Id: I2ed4e43e8bf52d980e850e61769343c6a685e74d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123355
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f67392948d625db9ce115092e4c9bfd301268a25]

        loplugin:moveparam in xmloff
        
        Change-Id: I46c1c8dc46cd2b8470b69506f6609f8bd7e42211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123347
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [210bbdead214531172d74d0d2975f47cf973bc69]

        gtk4: popdown context menu when radio/check is toggled
        
        Change-Id: I6cee9ee639b85c76c140d1ee0ad735fb57dae905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123345
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Rene Engelhard  <rene@debian.org>  [4a9ecab08c1ea6879919cb807e243ac1899f61f3]

        fix (cppunit test) build with --enable-mergelibs
        
        S=/home/rene/LibreOffice/git/master && I=$S/instdir && W=$S/workdir &&  /usr/bin/ccache x86_64-linux-gnu-g++ -pthread -shared -Wl,-z,noexecstack   -Wl,-z,origin '-Wl,-rpath,$ORIGIN/../Library' -Wl,-rpath-link,$I/program  -Wl,-z,defs -Wl,-rpath-link,/lib:/usr/lib -Wl,-z,combreloc  -Wl,--hash-style=gnu  -Wl,-Bsymbolic-functions -L$W/LinkTarget/StaticLibrary -L$I/sdk/lib  -L$I/program  -L$I/program  -L$W/LinkTarget/Library -Wl,-z,relro    $W/CxxObject/vcl/qa/cppunit/BackendTest.o      -Wl,--start-group  -lcppunit   -Wl,--end-group -Wl,--no-as-needed -lmergedlo -luno_cppu -luno_cppuhelpergcc3 -luno_sal -ltest -lunotest  -o $W/LinkTarget/CppunitTest/libtest_vcl_backend_test.so
        /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawPixel()':
        ././vcl/qa/cppunit/outdev.cxx:1091: undefined reference to `typeinfo for MetaPixelAction'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawRect()':
        ././vcl/qa/cppunit/outdev.cxx:1203: undefined reference to `typeinfo for MetaRoundRectAction'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawEllipse()':
        ././vcl/qa/cppunit/outdev.cxx:1225: undefined reference to `typeinfo for MetaEllipseAction'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawPie()':
        ././vcl/qa/cppunit/outdev.cxx:1243: undefined reference to `typeinfo for MetaPieAction'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawChord()':
        ././vcl/qa/cppunit/outdev.cxx:1263: undefined reference to `typeinfo for MetaChordAction'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/outdev.o: in function `VclOutdevTest::testDrawArc()':
        ././vcl/qa/cppunit/outdev.cxx:1284: undefined reference to `typeinfo for MetaArcAction'
        
        Change-Id: I65f79d726de553d894c848a89cf1dd97d5e45b54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123329
        Tested-by: Jenkins
        Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [e354e36c9e3f3c418973819208e0bf3e327b7c7c]

        gtk3: popdown context menus on toggling radio/check buttons too
        
        like we do for menubar menus (tdf#125803)
        
        Change-Id: Ib70b90bd9ec9b1f624b1cdff5ba6d304f75f8919
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [522983d79aa03bd5cc83a8a8b5b385f3b6cfe998]

        gtk[3|4] use set_buildable_id and get_buildable_id
        
        Change-Id: Ia3a24d80ac56bc834c11f85a98e3b9fa1a862e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123343
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [44583c313aad7076d67f868379e9b6616485b299]

        gtk4: this is fixed now by at least >= gtk4-4.4.0
        
        Change-Id: Iaff7c779917c7a1d90849d2091dd818bc0c04750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123342
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Arnaud Versini  <arnaud.versini@libreoffice.org>  [96726f4a7f2f23972c987e9a4be75539f24fb0b7]

        OSL : remove useless rtl::Static in debugbase
        
        Change-Id: I54ef4d1b492409265496c7f2b852568274bcf073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123321
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [eea7af10d9ff1407c90abc233f6ea470fa832b1c]

        loplugin:moveparam in basegfx
        
        Change-Id: I73414e94358114ff0d475f13855db8c4c493b6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123334
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4ac99f717d7365fc7d1f0adbf72a9bb4d4c8db5]

        loplugin:moveparam in xmlscript
        
        Change-Id: I8c33291dae8a4f90c02f47d823b127ca4e383d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa311ad62f935d6469b77936d477125d98dbee60]

        loplugin:moveparam in svx
        
        Change-Id: I2e422235129f810feea5c17afa1332d8b7ac14ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [6af0da482d8d387f181cb9c2cf9301859c9683cb]

        loplugin:moveparam in editeng
        
        Change-Id: I08aed09b0acd283d700bdf75f650e93dba7c7b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [e3fc69457d6b43f88c7540b39564a914648e7f3f]

        ofz: Integer-overflow
        
        seeing as GetHmmFromInch is already using limit_cast, use saturating_add here
        
        Change-Id: I3123ac15edd300f6d7d64c458ce95b20c9220117
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123340
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [c954552a8255188779b9021cc9acaa13c5e3c679]

        loplugin:moveparam in comphelper
        
        Change-Id: I109d8507890460c5a479af2a5b94f905197b08d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [d035f86de21f9508bc5ea0f35071873c0fd4c8c8]

        loplugin:moveparam in svl
        
        Change-Id: Icd45c7f693c866e7eafcf6aeb052a4d190dce38c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ff2a432f776d878fc17af5442f14844a9970bf7]

        loplugin:moveparam in ucbhelper
        
        Change-Id: Id6b03af5ecd662ce2e390bb76819cfe5d2ec05ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Caolán McNamara  <caolanm@redhat.com>  [4dc362917597f0e3b890ef7d8d190749b20abce4]

        cid#1492337 Unintended sign extension
        
        Change-Id: I6836e83ba17de646bfb661281b76c2b5e58b76c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123323
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-10  Arnaud Versini  <arnaud.versini@libreoffice.org>  [82bc337c979f6d74cb08d0332b44f26b155f9554]

        OSL : use std::mutex in backtraceapi
        
        Change-Id: I2df73d7959dd24882f75130f0fd03ff096dce8d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123322
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Julien Nabet  <serval2412@yahoo.fr>  [cf22245d49df8abab904f28b1fab514bde197f2b]

        Typo: brake(s)->break(s) (I let the right use of "brake" of course)
        
        Change-Id: I6a15f4d09c571877db22feee688b46b872eb73dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123331
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-10  Noel Grandin  <noelgrandin@gmail.com>  [dbd49cf90b175a3c3d7a4f25ad366f9bc4c716db]

        use SfxItemSetFixed in sw
        
        Change-Id: I69e188d7599b7fc439f613cec0a0967ccb748b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123313
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-10  Luboš Luňák  <l.lunak@collabora.com>  [b972aa8727da6eb2d5d9740b18450d8706df0874]

        don't use common PCH with sc_parallelism test
        
        Otherwise it duplicates the precompiled_system.o object, the second
        copy brought in by libscqahelper, making Clang LTO build fail.
        
        Change-Id: Ic6827b0745e134ab327ad18fc212ca31084ff579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123327
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-10  Julien Nabet  <serval2412@yahoo.fr>  [633e8c98cbcf8f41b8f8394a5e1f396bf6f7138f]

        Typo: CT_SytemColor_lastClr->CT_SystemColor_lastClr
        
        Change-Id: I10ebe939562097d3fc098a42c09b1e0f6e5cbd6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123315
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [d389a54e64accc3f46c1a646f947e9af9badd08e]

        tdf#144757 - fixed fonts not shown in font list
        
        When in font options, the Fonts in "Font Setting for HTML, Basic and SQL
        Sources" were not showing any fixed (non-proportional) fonts in the list
        when "Non-proportional fonts only" was ticked.
        
        The reason this was occuring was because we were not populating the
        fixed font attribute when getting the CT font descriptor.
        
        Change-Id: I06127ac48bd0f3bc9b70217b36bbf584a1b0fdc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123316
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [21b2c6b7d8f4661dcbd40df4f8b9126d331cbd7f]

        Rename bookmrk* -> bookmark*
        
        Change-Id: I9dec77b2af8abe5abb286ff76ed85d1e4078ee6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123325
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [25c9f041ad078c94321e18361d6df52894865b7f]

        Typo: *adress* -> *address* (except from not translated German parts)
        
        Change-Id: I62e12aed5bc67119433c39ff333f69b79944dca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123318
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [df0592cfb16c28b22c0c0331306dd072e7678fce]

        What's the interest to gain 1 letter? bDelBookmrk->bDelBookmark
        
        At least, it'll be easier to search bookmark in whole code if there's a bookmark pb
        
        Change-Id: I25cbfb8dae823495b87d5bfcdd41cea479230eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123319
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [84a4e281c1a552b002b3a7162adfaece47761e88]

        tdf#143148 - Use pragma once instead of include guards
        
        I changed this one only because the goal was above all to change filename
        in a following patch to put bookmark.hxx instead
        
        Change-Id: Ia224f32227404e5685e03efb134dd525a88b3917
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123320
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [6a5f4fb9f9bc6cdbf3b01cad74b6caa7b4f7f451]

        Typo: braket->bracket
        
        Change-Id: I75c8c0fc15acb7e3ae6e59de91d5d9f67a4cd1ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123317
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [70faac516e12944dfed2f8e0c5b6593435985d20]

        Typo: *Extesion* -> *Extension*
        
        Change-Id: I7c1791327bec14b1c36359d64ac905bc7b358c04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123314
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Johnny_M  <klasse@partyheld.de>  [28d057e2dd45444d5a515233ce0923104b53b9e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d155b3e2133f3eb6593d438b69dc3e42d37b11ff
          - tdf#132643 Translate German section IDs
            
            Change-Id: I69505b323ed9148e3f4560dd883753c5c728211b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122985
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [a4eecf033edad84fa01700ca1aafb9bf06890deb]

        Typos in qadevOOo/_NumberingLevel.java
        
        Change-Id: Id4ea4b27c527c34f9d4b6b4658486b189f9089c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123307
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f7a0e58a3c0670a8c3ecf03a38a821c7944b3895]

        Don't URL encode the filename in the macro security warning dialog
        
        Change-Id: Ic1243f562fa4142ffdfece7296223b693ce7fe90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123298
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [f0fd4574fff6c91dd6fe53a5dbe1ed2509b616e4]

        Typo *ropertie -> *roperty
        
        Change-Id: Id5ae03140ac4fd67bf4940569ac5cd2f15716749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123306
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Natalia Gavrilova  <nataligavrilova8@gmail.com>  [c307c34a295fbbaf0af91a17440b045133981cc8]

        tdf#142121 Cell focus rectangle does not use font color
        
        * The black square in the down right corner is also
          highlight color now
        
        Change-Id: I249872da70cde25b2d14e6fb3189a5a21e52f492
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123300
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-09  Julien Nabet  <serval2412@yahoo.fr>  [6a9efc627bd6e24bb56e6cd1e70708eee5af451d]

        Declare and initialize variable only when really needed (sw/unocrsrhelper)
        
        Change-Id: If2dafc18b404f39d42df25c5f923eba348eac907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123293
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-09  Bayram Çiçek  <mail@bayramcicek.com.tr>  [ce1902d3964414f5abf5a07ec43c19641c8752f0]

        Rename strings and change criss-cross border icon
        
        regarding 3a9167e1b8a236da2862f4377e2040a8c189c99c
        'tdf#143919: Calc: add diagonal borders in Toolbar>Borders'
        
        - criss-cross border icon replaced with a new one
        - rename -> 'diagonal left' to 'diagonal down'
        - rename -> 'diagonal right' to 'diagonal up'
        - code refactoring: large if-else blocks refactored
        as methods and called from proper cases
        - clang-format
        - "Set" word dropped from include/svx/strings.hrc
        
        Change-Id: I1284e69b9481e1a512f7cab29913bf23b6a493c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121117
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-09  Mike Kaganski  <mike.kaganski@collabora.com>  [4d82c1d8a3160719f694df98a4db6b9b8c7664bd]

        Simplify SvXMLExport::AddAttribute overloads
        
        Remove overloads taking const char* which were not needed, because
        every their use eventually took a string literal convertible to
        OUString directly.
        
        Many other literals were converted to OUStringLiterals.
        
        Change-Id: Ia1e742a8087776cd20bf5094dc415dafd9a8834a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123155
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-09  Jim Raykowski  <raykowj@gmail.com>  [a5ba8d94e6c36a7d79276416cc5acad9a1f6e54e]

        tdf#142344 SwNavigator: Keep heading selected after navigating to
        
        headings in tables and sections
        
        Currently after navigating to a heading in a table or section from the
        Navigator the table or section is selected in the Navigator content
        tree. This patch makes the Navigator selection remain on the heading
        until the cursor is moved to another outline position which then makes
        the Navigator track tables and sections again.
        
        Change-Id: Idfcfd168fbbda541d07bbcadbaad62772ef156af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123244
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-08  Hossein  <hossein@libreoffice.org>  [8fb366c13ac1b23c455c32afc085bca2edff03bb]

        const OUString -> constexpr OUStringLiteral
        
        * Defining the constant strings as "constexpr OUStringLiteral"
          instead of using macros
        * Changing "const OUString" to "constexpr OUStringLiteral" where
          possible
        * Using "inline" in the header files to avoid duplicate copies of the
          global variable inside the files that included them
        
        * Read more:
        https://learncpp.com/cpp-tutorial/sharing-global-constants-across-multiple-files-using-inline-variables/
        
        Change-Id: Ic0741c0044ff160734e641d072fef9be956815a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123104
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Julien Nabet  <serval2412@yahoo.fr>  [09d544d0c025ebbc9b0cbd77043ce4e8b4ab6be3]

        Fix iteration in sc/source/ui/docshell/externalrefmgr.cxx
        
        Like this since 2012 with:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=63ade823e2d854b60df76790e3628a5ab78f653a
        commit	63ade823e2d854b60df76790e3628a5ab78f653a (patch)
        tree	69283e660118fb534f50ea1be7ba17b24c7b1c20
        parent	51caf9b45403b92deadf934347f2d6f9ffecdf08 (diff)
        remove entry from unsaved ref container if doc is saved
        
        Change-Id: I4845c2c6b9ffd7b9f6b14276e1ca97817d584913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123233
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-08  Julien Nabet  <serval2412@yahoo.fr>  [849d879ac1805198b4714c1c5b2a75780ab86479]

        Clean up a bit iterator management in sc/bcaslot
        
        Change-Id: I2bced8cb78ccecf85798f3468aab87681d520180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123235
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-08  Julien Nabet  <serval2412@yahoo.fr>  [b0d32bfec04f4ab6181f2b329c3df82ea0e47797]

        Clean up a bit iterator management in oox/vmldrawing
        
        Change-Id: Icd4f4980332edc3fd9027cc4cace2b4a0d0c1315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123234
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1cf57765dd9a66982ecf9cd33687005a70c70c3f]

        loplugin:moveparam in connectivity
        
        Change-Id: Ie5c2f6ec1573ab2c47218dd4da8c9150b23bcd2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123247
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [36d43d4637ed6c1666617ac2d87f738bc34455af]

        remove unwanted xpad/ypad properties and replace with a margin-end
        
        the xpad didn't do anything in vcl, and is deprecated for gtk.  There
        was additional padding shown in gen anyway because a yalign of
        0.5 wrongly horizontally centering, which is now fixed.
        
        Change-Id: I546ec72b0449185217213ee1ba061dd051122880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123270
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [5649ddc290b00510fa89490661d4e9e46fc06d62]

        vertical centering is WB_VCENTER not WB_CENTER
        
        Change-Id: I75cff767008aa215ce43856da4cd31db1b6d83fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123269
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [492b4a76ee83627a653cb73dd2b7580ff0d15538]

        remove (presumably) unwanted 'Widget name' property
        
        Change-Id: Icf296074e21e02c2aeb63bc6a9d8ff0702cc4c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [2f79940bee307b34c333251a415ab5ff6b0cc91e]

        resave with glade to tidy this up
        
        Change-Id: I7b3499cc1044cb976415d3db6855283bf928c4b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123266
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [98e085b11b492a2030a5289e99b2335712ffff75]

        add mappings for emphasis property
        
        Change-Id: I1406d57a47075bfad3973c6bbb825a7754e8f279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123264
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [b94b9bae78b410d51cdcb385980133d9f6c14b84]

        fix "GtkBox does not have a child property called left-attach"
        
        on launching development tools
        
        probably since...
        
        commit 81d6ed89d1e5268c2ea4ff527f3e6087dc1d8ccd
        Date:   Mon May 17 13:59:25 2021 +0300
        
            tdf#142276 Use vertical GtkBox insted of horizontal GtkGrid for the left side.
        
        Change-Id: I6d4e4a056fb25c6ffb44e0ed734eb7a553a78ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [cab77a48da1d481ddae24c9bd273ba4e7585b81c]

        tdf#83090 - Allow any font size in the toolbar/sidebar
        
        In order to allow any font size in the toolbar/sidebar, correctly round
        the height of the font in the status listener.
        
        Change-Id: Iebd07f5e710a01c5a9be4a7dd8c950d191d5d629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122332
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [3f5fb07565d0e08773ddfcda4d5acbb1446aa2f2]

        vcl: test PhysicalFontCollection and move to vcl::font namespace
        
        - tested PhysicalFontCollection, noted odd behaviour with search names
          and normalization
        - moved PhysicalFontCollection.hxx to vcl/inc/font
        - moved PhysicalFontCollection into vcl::font namespace
        
        Note that I needed to regenerate the pch file otherwise errors were
        generated.
        
        Change-Id: Ifa0c7b871c40687bd15002565d2f7a3e408218f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122036
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [677434a572b8f07a386937b2f7edf2e9b801bbd0]

        vcl: split out outdev.h into seperate headers
        
        outdev.h is a hodge-podge of functions - font substitution and an
        internal state struct for OutputDevice. I have split these into:
        
        - font/fontsubstitution: FontSubstitution,
          GlyphFallbackFontSubstitution.hxx and PreMatchFontSubstitution.hxx
          (all three define pure virtual base classes for later reuse)
        - font/DirectFontSubstitution.hxx: incorporates FontSubstEntry and
          DirectFontSubstitution
        - ImplOutDevData.hxx contains it's own class
        
        Each fo the classes has been moved to the vcl::font namespace.
        
        As outdev.h is now no longer, this has meant that I have had to
        regenerate vcl/inc/pch/precompiled_vcl.hxx
        
        Change-Id: Iaa92fa21271faff46f2a8a0f6488e01434c142db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121997
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [49e02381a301e4634eb7077fcb08eb4e8a95fb08]

        remove GtkLabel "xpad" property
        
        Change-Id: I237eb9e35367b8b75c8e72b857620747840383cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [263d2f0b3d1143d6caa467204f187648c43b0e89]

        tdf#45525: sw_uiwriter2: Add unittest
        
        Change-Id: I266efb1fc95a782d0fd75e16bd099e5c5359f9f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123262
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [c59edf5d4dd94224b586adf03b3dcdbda4d422ab]

        gtk4: set draw-as-radio as true for GtkRadioMenuItems
        
        Change-Id: I1a49a3f44f46ed57e80fa54af0e2b6466b2a9b4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Noel Grandin  <noelgrandin@gmail.com>  [be5858089f5003db1316175941370b913d01e635]

        use more SfxItemSetFixed
        
        Change-Id: I18784bac5f7ad1d109f8a81e96084cd6e9548231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123240
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [5cd87f195624e2381489084a37dcd43fea24c7b0]

        loplugin:moveparam in vcl
        
        Change-Id: I6dea009e1031174ecb3d4371e91c9c6d26c6e514
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [953d8429c9c92ced2e3cb1222cadc29b6f1ef550]

        loplugin:moveparam in binaryurp
        
        Change-Id: Ia69e2307872813ede3339c0e9fbe1f2ae6a3508a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123246
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [e2ecb9a50acb7ab7c3287403104c6256d4369816]

        don't warn about missing TopMostParentSystemWindow
        
        Seen in tdf#144037 because the notebookbar is not a child of the
        toplevel window, but instead (like the menubar) is a child of
        borderwindow of the toplevel so from its perspective there is no
        eventual parent SystemWindow.
        
        This TaskPane thing could probably be dropped and likely no one would
        notice. But with tearable floaters like the color dropdown still a thing
        then F6 wouldn't work to move into them and someone might complain.
        
        Change-Id: I7174598a2ee01e98aca2f6e214adf94f7a555018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123258
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8e779c062a22a5755cae2c86787e16f59bfe4907]

        Centralize VS-to-toolset mapping in configure
        
        This allows to define the mapping once, and avoid modification in
        multiple places each time a new VS version support is added
        
        Change-Id: I93de4c9d78c3f67a0a2e157007e9d13b6f557937
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123163
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [27d1cc61b4f58e8ec25463275bee36c96b66b938]

        Simplify VS IDE integration generation
        
        Do not require the IDE version in vs*-ide-integration. Instead, use
        VCVER environment variable, that is set in configure, to obtain
        the toolset for the VCPROJ files. When introducing support for new
        VS version, the 'VisualStudioIntegrationGenerator.retrieve_toolset'
        method needs to be updated synchronously to list the toolset.
        
        This simplifies the make command to
        
          make vs-ide-integration
        
        TODO: also set the toolset in configure, to simplify the code here,
        and also in places like external/python3/ExternalProject_python3.mk
        (see commit c156a8c708f74dd31e1ef024edc578c3915619cb).
        
        Change-Id: I95960029a933be2cab96898eee6be6ca6bc5794a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123162
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [70138b37bb12721b8de6bf9aa42ba5c8b7546ca9]

        add 'destructive-action' style to the close button of save changes
        
        which gives a red "Don't Save" close button in the default Adwaita
        gtk theme for that undoable action
        
        Change-Id: I62b50c90ca53c8f05e656c9beaecbfb160ce5f67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123249
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [bc43f0e8643abdba19207c3c6f40d9439e971c80]

        add 'destructive-action' to the yes of delete header/footer messageboxes
        
        Change-Id: If4d22caac6d1c6ce12b22e0f3d4395f349539e36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123254
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [ec20aee719aef1ff6fec6e09685dafcfd28fb2a7]

        tdf#144970: sc_macros_test: Add unittest
        
        Change-Id: I0f44f15b7cf43d6a0cee13c427d473effc04c710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123250
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [da1e9cba89128de05b8681469cdbc154f7624aad]

        sort buttons using id instead of HelpId
        
        when created from the builder a widget's HelpId is the patch to the
        widget and always ends in the widget id so this is no change for that
        case, but when created directly by vcl for e.g. a MessageDialog while
        the id is set the helpid is empty, so this means that Yes/No
        MessageDialogs have their buttons sorted the same as if the Yes/No
        buttons were explicitly spelled out in a builder .ui
        
        Change-Id: Iee1a7146d2b6da76804856b1c4df8849ddd91a0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123253
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Caolán McNamara  <caolanm@redhat.com>  [a44c77d6548fac62f760ae152ddc09381d005129]

        tdf#144984 default edit width got wider
        
        at...
        
        commit f72013ca65c7a33991d5fb124b919fe7cde269e2
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Aug 26 15:24:25 2021 +0100
        
            use max of avg digit or 'average char' width to measure Edit space
        
        where this default was forgotten
        
        Change-Id: I50933ff5c1b8735624609a884fb9fc7701df7f97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123232
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-08  Verne-Lai  <verne@ossii.com.tw>  [457a67a5b692e79db1aea775e0a2eb48bf1dbdfa]

        tdf#143142 Solve the button cannot be used when table column is 6
        
        Change-Id: I6147c08ec36da59bb93b707fa206f9a8f681af3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123237
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-08  Mike Kaganski  <mike.kaganski@collabora.com>  [a0289052fd4f0f901ffd3698cee8669244701e5e]

        Drop vs2017-ide-integration; add vs2022-ide-integration
        
        VS2017 is not supported since 24973523ba59087185d434396fd614e73d72107f.
        
        Change-Id: I1a2af1eb8c9216eaed87d5454def2176728f719b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123161
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Jim Raykowski  <raykowj@gmail.com>  [3279092309d7968220ddf5f9265e73e5d9ec0a49]

        remove unintended blank line
        
        Change-Id: Ic7688a625d2c1be19f66e289d4517c7ce32ff4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123239
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [9fe2ead3d5355224dd94d6462b0ddc6100f6d4e3]

        loplugin:moveparam in svx
        
        Change-Id: I92fe2882c948e7297e5d54963647b4aa054f8f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123241
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Miklos Vajna  <vmiklos@collabora.com>  [0db7e46536fc23d5201ed9ff610a8ae0efd09a96]

        sw: handle mbIsLabelDoc when replacing compat options
        
        This describes if the document contains labels for printing, surely we
        want to keep that when copying the contents of the document to an empty
        document. (Mail merge scenario.)
        
        With this, finally
        sw::DocumentSettingManager::ReplaceCompatibilityOptions() replaces all
        options where it makes sense to do so.
        
        Change-Id: Ic0be340578e9a01fac7e8c08fe2e6b6ffbb30039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123230
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-08  Kevin Suo  <suokunlong@126.com>  [6b93ee72df1aa42d1a3482ffc396bd0c23134f8b]

        tdf#130104 - FILESAVE XLSX: cell indent increased on each save
        
        In OOXML, 1 indent = 3 space char width.
        
        -----
        The Old Method:
        -----
        
        XLSX Import:
        
        As per the line:
        sal_Int32 nIndent = getUnitConverter().scaleToMm100( 3.0 * maModel.mnIndent, Unit::Space );
        assume the width of space char is 88, then:
        If the OOXML indent is 1, then nIndent would be 264.5, and casted to 264.
        If the OOXML indent is 2, then nIndent would be 528.5, and casted to 528.
        If the OOXML indent is 3, then nIndent would be 792.5, and casted to 792.
        ...
        
        Also, as Mike Kaganski has pointed out, we use twips in sc indent internally, thus it is wrong to convert to Mm100 unit here.
        
        XLSX Export:
        
        As per the line:
        nTmpIndent = (nTmpIndent + 100) / 200;
        Assume we did not edit the document upon open, and simply save it. Now:
        If our indent is 264, then the calculated OOXML indent would be 1.82, and then casted to 1, while the expected value is 1.
        If our indent is 528, then the calculated OOXML indent would be 3.14, and then casted to 3, while the expected value is 2.
        If our indent is 792, then the calculated OOXML indent would be 4.46, and then casted to 4, while the expected value is 3.
        ...
        
        Then if you reopen the saved xlsx file with Calc, the increament of indent continues on each save which causes serious
        format loss.
        
        Most importantly, if you change the indent of cells using the Calc toolbar indent icon, one-click would be 10pt = 200 twips,
        see defined macro SC_INDENT_STEP. This causes a mess when you change the indent in an xlsx document.
        
        -----
        The New Method
        -----
        
        In this patch, I have changed the XLSX import to convert the excel indent unit to 3-spaces-width *in twips*.
        Then, per code advice from Mike Kaganski, as a mirror operation, I have changed the XLSX export logic to detect the width
        of the space char (which *should* be the same as the one detected at the time of xlsx import), and use this width to convert
        the indent in twips unit to excel unit. This way, the indent will remain the same on xlsx export.
        
        -----
        TODO:
        -----
        
        1. On xlsx import of the file tdf130104_indent.xlsx, the default font (i.e. font for the "Normal" style) is "Times New Roman".
        However, when the UI locale is set to Simplified Chinese and "Asian" option is enabled in Tools->Options->Language Settigns->
        Languages->"Default Languages for Documents", upon resave as xlsx, the default font for the document is changed to "Noto Sans CJK SC"
        on my system, which causes the space-width detected to be different from the width detected on xlsx import. This seems to be another
        bug, see tdf#131349. (Luckily the unit test in this patch passes, this is because the change of space width resulted from the change
        in default font is very small thus the conversion is not impacted.)
        
        2. The UI part need to be improved, so that after xlsx import, if the user hit the "Increase Indent" or "Decrease Indent" toolar
        icon to change the indent, Calc should be able to detect that we are operating in an xlsx file, thus the "increment" should
        be 3 * width of space char, rather than the current SC_INDENT_STEP. Also, the if the user changes the default font of the xlsx
        document, the Calc should recalculate the indent for each cell to reflect the possible change in width of space char.
        
        Change-Id: I5f7a4ecbcd93079d1c19db3b0b641dda949f6fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123111
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ad7e095078e09bc27608d5b1fedb8809656abbe]

        loplugin:moveparam in svl
        
        Change-Id: I58c1ef97fd6cba281c90cc7ed9917e04b7f265ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123187
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Noel Grandin  <noelgrandin@gmail.com>  [8167cc226960d635c9e68f603cb1ab2c57426828]

        use SfxItemSetFixed in editeng
        
        Change-Id: I892a69d50f7d641f9a941a55c7b3952d1c59c435
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123144
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [bd7cf3915964ba80786e2ae77b33fc654fde1f31]

        loplugin:moveparam in vcl
        
        Change-Id: Ic43e02576454e3ee174304db350659dd113a1d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123186
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [93115d2c54d645bcf2f80fde325e3ede39dee4d5]

        svx: add "m" prefix to some member variables in SdrObjEditView
        
        Change-Id: I2877f63d97ff6d15f08bd2dbaee6128b8a689cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123219
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-07  Julien Nabet  <serval2412@yahoo.fr>  [33206d7ae6e91b264087981ae2e61d9c16babfd9]

        Match order of the beginning of fldunit.hxx with FieldUnit.idl
        
        Change-Id: I5ddb120e66fed214cab484f9cd668dfa6f75d123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123231
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [b0a735eba030cf294e661cfc4c6da693ef9bfd61]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7f942a62c3e173d25ec8e3d7ee786b2087d49e42
          - Create a guide on Calc macros on reading and writing cell values
            
            This patch also creates a new entry in the Calc tree menu to store all pages about Calc macros. Currently there are only two, but in future patches new pages will be added.
            
            Change-Id: Iac55c87d1159f4163ba3150e83160b4156d0d0f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122936
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-07  Eike Rathke  <erack@redhat.com>  [9a0d52c95b6fd8639a56df2c2ceff07277253183]

        Blind fix crash in ScDBData::UpdateReference(), tdf#126926 follow-up
        
        Crash reports at
        https://crashreport.libreoffice.org/stats/signature/ScDBData::UpdateReference(ScDocument%20const%20*,UpdateRefMode,short,long,short,short,long,short,short,long,short)
        
        No reproducer yet, for a possible reproducer see
        https://bugs.documentfoundation.org/show_bug.cgi?id=126926#c12
        but creating such a scenario with 8 AutoFilters / sheets wasn't
        sufficient.
        
        However, ScDBCollection::NamedDBs (maNamedDBs) uses a std::set so after
        erase(iterator++) iterator is still valid, but ScDBCollection::AnonDBs
        maAnonDBs uses a std::vector for which after erase(iterator++) iterator
        may be invalid if vector was shrunk and reallocated.
        
        So use the iterator returning erase() instead to have a valid following
        iterator, and for consistency do that for both.
        
        A reproducer may need a bunch of sheets / anonymous AutoFilter for a
        vector to shrink and be reallocated, and it may depend on the
        plattform/compiler's implementation.
        
        Change-Id: Ib57294d8af9f486b734f4294d8d310ce0fa20551
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123224
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [c6bd2fd7c0b54b3a2c32e49db6c66fabe9db3689]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 82e70eb6efa88c3d21606292a042cd6978385480
          - tdf#143687 Document the "IS" Basic keyword
            
            This patch also improves related help pages about the functions IsObject and EqualUnoObjects.
            
            Change-Id: I5f16596ed057c1104d5fa2650299861741bd7b2e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123153
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-10-07  jucasaca  <jcsanz@libreoffice.org>  [418e56997c9e63a5bc669c1b79157b2a4dbf6a2c]

        tdf#85148 New option on database wizard to connect to Firebird Server
        
        Add a new option to the database connection wizard to connect to
        firebird database server
        
        Change-Id: Ie9c75187347a8532c1d869939c72a6f0a892d861
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122073
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c24f5e24e062ba76bc7ad94ee6f362ea1becbf59]

        svx: defining "i" variable inside "for" statement is good enough
        
        Change-Id: I30c8eb216ecde97451f2c8501424f95fee36d680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123218
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fee3bc725bffe4fe6970a3ec5eaf5efdcd53285c]

        svx: move LOKit specifics into it's own method
        
        Change-Id: I87f04d460d88c902426e881c03701b95414207d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123217
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-07  Caolán McNamara  <caolanm@redhat.com>  [97cf7321e0cddae4570c6ec4c5fb5b55764c26fa]

        ofz: Integer-overflow
        
        Change-Id: Ib0c1863c5fed92622b4bd601021a1174cf6ee68d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123213
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [d7358047d9bcee8368a940bfb75b41fb65f87514]

        vcl: test OutputDevice::Erase()
        
        Change-Id: Id15ad1419a5f9d0e628c746770f05b2983c1f65b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122893
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-07  Noel Grandin  <noelgrandin@gmail.com>  [1d4827a26a749ca704430d6aae972ee39e35ba10]

        use SfxItemSetFixed in sc
        
        Change-Id: I5b1d66adb1b9e5dd0e470403ba7095183334cc66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123182
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5a6071264d27b9dcfa47fe2f399951edd7301c2]

        loplugin:moveparam in editeng
        
        Change-Id: Id8118e5f5b7acbff4f04935560c663b36093a5fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [66b5d2117004f32d89ea10cdd7e086f9f1ff35b0]

        Add extended tooltips to new Paste Special dialog
        
        The new Paste Special dialog in Calc has 4 new presets and a new checkbox. This patch adds extended tooltips for them.
        
        Change-Id: I7d4c5fdb140a49c50b733e50b23d2618127f2c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121413
        Tested-by: Jenkins
        Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>

2021-10-07  Jim Raykowski  <raykowj@gmail.com>  [69c9237f0345c5b92792f6350771618f5c9cb8c2]

        SwNavigator: Fix crash on image select
        
        Fixes crash that occurs in update tracking test for bookmark when image
        is selected by testing that selection type is text before testing for
        bookmark.
        
        Change-Id: I53c64a71d3aff0f159bff31b98e2f453d7c2225a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123202
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-07  Johnny_M  <klasse@partyheld.de>  [8d6a72f556b532c3a289276492bf7f1e2bdd5d1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 163eaf2bf056073232a1336632e11e535c8a3000
          - tdf#132643 Translate German section IDs
            
            Change-Id: I21c6c82f5b7c5f6543ff6975243b25cea6c13234
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122988
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-07  Caolán McNamara  <caolanm@redhat.com>  [02f8dba5df5296c3b8c5d6aab46bea53235314fb]

        fix "gtk_bin_remove: assertion 'priv->child == child' failed" warning
        
        on closing a document from tdf#141633 with a combobox in the tableform.
        
        So remove the mouse event widget before we remove the combobox
        replacement
        
        Change-Id: I95395ba60bb5fe7cf0b6e25176d0556c6bcc6611
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123210
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-07  Julien Nabet  <serval2412@yahoo.fr>  [f79bdaf1fae14d7028bb1670ec8a674ff2026491]

        drop 'using namespace std' in compilerplugins
        
        Change-Id: I12b4e32b9561657bdbe062b5fb7c18e2ef6ce601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123196
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Hossein  <hossein@libreoffice.org>  [a2b1c2835733fb028bc5433eb6805820c329daf3]

        Clean StringFormatFlags() in emfpstringformat.cxx
        
        * Fix: StringFormatDirectionVertical was missing, and another enum
          was used instead by mistake
        
        * Cleaned up StringFormatFlags() method
            + There was no need to check for each flag and add ", "
            + The method is only used for SAL_INFO
            + Just adding space in the end of each flag every time
            + Goal: Making code faster and also more readable
        
        Change-Id: I4be2d291611f2b5d3c8a4490a8b273d5a4511dfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123200
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-07  Caolán McNamara  <caolanm@redhat.com>  [efcbb6d89f49079e9ca7a2b3689699ccfcb6bf2a]

        remove python make dependency from MoTarget
        
        not needed since...
        
        commit 7fdf1663ed8e689e7fb154ab22a9dcb7fc7bf43c
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Sep 14 15:57:38 2017 +0100
        
            remove interim update module for gettext support
        
            Change-Id: I05df619848cde842a5cda79d20e013914ce882d4
        
        Change-Id: I094c033db356f32b93c77f7bdbd4ce5be8b0b0ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123151
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-07  Caolán McNamara  <caolanm@redhat.com>  [21c78b4e94c6cfb9ec38fd4c94091559f8850344]

        ofz: Timeout, detect infinite loop
        
        Change-Id: I3234443e2dde9d68b7704fdd3ccf6bdeebef5ee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123205
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [946b0840a0db5aabfb0d60916abf161d755170f4]

        vcl: remove unnecessary using com::sun::star::\* and std namespaces
        
        Change-Id: Ia6e9987262e10a107a14c9fd1b9c274c34cc7d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122815
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Julien Nabet  <serval2412@yahoo.fr>  [5f91b3b6c6bf4935a5532330b0d834f6f50df32e]

        drop 'using namespace std' in extensions(ole)
        
        Change-Id: Id2bb87f792d389dd9e6eeddd17046a46cddfdb6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123192
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Julien Nabet  <serval2412@yahoo.fr>  [e4a46880debff1c594a0495d8312fa5a93c77d0f]

        drop 'using namespace std' in filter/qa
        
        Change-Id: I7b5a1a773c26e8ef0fe3dcd0a1cdf5ebba75d52f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123191
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Heiko Tietze  <tietze.heiko@gmail.com>  [1b6b2eff9ac386fd994e3ae120882f646268a80b]

        Resolves tdf#144693 - TipOfTheDay does not progress
        
        Follow-up to I94cd34aa031e133d8c229a0de78582fda1dbdf4a
        
        Change-Id: I29a91a188fb9783074491271c37b49a1f2cf13ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123206
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-07  Julien Nabet  <serval2412@yahoo.fr>  [961ebbe9ebd9becdefdeaa5fdea63cb0e7d27443]

        drop 'using namespace std' in cli_ure
        
        Change-Id: Ib439d74284d52e32162164d14ab06e4f40df884a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123193
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [2129cc20ce67606cff22e32d4ce2e658240f5cd8]

        tdf#144317: sw_uiwriter2: Add unittest
        
        Change-Id: Ie2fa7b754f117aed35238cdb67698c05af24dadb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123204
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-10-07  Jan-Marek Glogowski  <glogow@fbihome.de>  [354706e3f5c05294af6e0000d5b9f814cfe01741]

        tdf#144952 VCL fix the Printer graphics release
        
        Regression from commit 1b7c53db87bb67eeb2591fbb186f7ac20eb00c68
        ("WIN lazy init WinSalInfoPrinter graphics"), which removed the
        // HACK to fix an urgent P1 printing issue fast
        
        SalPrinter::StartPage returns a SalGraphics to the VCL Printer
        object. On Windows SalPrinter::EndPage deletes the SalPrinter's
        SalGraphics. MacOS keeps a single SalGraphics for the whole
        SalPrinter lifetime. PspSalPrinter stores it in a unique_ptr
        and always resets it in StartPage.
        
        But in any case the VCL Printer's SalGraphics reference must be
        freed before calling a function, which might delete it.
        
        Change-Id: Ice528b2bbc89eaadff576420bf210ea4ec1e58d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123199
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-10-07  Eike Rathke  <erack@redhat.com>  [852292feee08b4d256f8255926e1f84b4c6fd4b6]

        Related: tdf#144970 Make Drag&Drop of Chart range work with UI representation
        
        Drag&Drop of cell range onto an existing Chart worked with Calc A1
        but not Excel A1 or R1C1 address syntax conventions.
        
        Change-Id: I1cd1a134f284ef5b28237589c544f93cb4aca841
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123197
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-07  Eike Rathke  <erack@redhat.com>  [14f81ca6ad289bf86781f642aa129b33151247cf]

        Related: tdf#144970 == ScRefFlags::ZERO is not a replacement for != 0 ...
        
        It still worked by chance because if (!bValid) the string is
        parsed with ScRangeList, which does deliver a result.
        That will have to be adapted to the then expected UI
        representation though in which case it wouldn't work.
        
        Fallout from
        
            commit 51d0b4037b36a4a74c9181b95edb18017542ab79
            CommitDate: Sat Mar 12 00:21:29 2016 +0000
        
                tdf#84938 Change defines to typed_flags
        
        Change-Id: I9612b34829c12e59d4b390c6aa035aca84e87c73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123194
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-07  Mike Kaganski  <mike.kaganski@collabora.com>  [1ef671c5a2f4b629ba6e280c5036ba781cc8787c]

        Delete copy ctors/assignments for DLLEXPORT class
        
        Same as ee405fb2ef36337851801f1bd34411c606d55988 for
        GraphicHelper, but this time for PhysicalFontFamily.
        
        Change-Id: I7a9d6f0cdee29b754244ab6260f78bb7d8deb488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123195
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-07  Justin Luth  <justin_luth@sil.org>  [7e201916169aca254c0824fb71ed83ca69f4adce]

        tdf#144317 sw table minimize: fix signed->unsigned table growth
        
        In the case where the table was already rather oversized,
        the minimize and optimize functions would attempt to shrink
        the table to the maximum recommended size. But that was done
        without checking whether that would result in a negative
        position for the column boundary. (At least that is what I
        think was happening. This code is a bit too cryptic...)
        
        I tried to make a unit test, but the table size didn't
        grow or shrink as I expected it to (and as it seems to
        when the command is run by hand...)
        An F12 with SW_DEBUG=true ./instdir/program/soffice
        shows that the cell gains a huge width, but that didn't
        show up either in a parseDump, even after a
        Scheduler::ProcessEventsToIdle(). So I gave up (again).
        
        Change-Id: Id4b9defae718694aa76a3db01f6b02ead5f98e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123108
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-10-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e090afc29bdff4303f1235080fb169011220be4a]

        tdf#144924 - Change return type of array elements of the split function
        
        If VBA is not enabled, allow the assignment of variables with different
        data types to the individual array elements created by the split
        function.
        
        Change-Id: I7bdd432cdebbfded5f7fb3acc0216474eb6b6821
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123122
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-10-07  Miklos Vajna  <vmiklos@collabora.com>  [f78aebd4c2a2b740559e54906a26653dc89fd610]

        sw: size() -> !empty() in textboxhelper
        
        To avoid an implicit integer to boolean conversion.
        
        Change-Id: If4f91d4ebfc0c2a66e0c526d3826aed4b7558ec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123185
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-07  Justin Luth  <justin_luth@sil.org>  [f629dc8dc8b9620508b5bd8e55ddb298438c447f]

        tdf#143982 doc/x export: save automatic table as 100% relative
        
        Currently, the automatic mode is just being saved as
        "determine width from cell size" or absolute size.
        But a better match would be 100% of the available space,
        so that changing the page or margin size would automatically
        increase the table size (which is what automatic implies).
        
        It doesn't appear that MS formats really have a
        similar automatic. Their automatic just seems to
        say that the width isn't specified at the table level.
        So a percent-size seems to be the best match.
        
        RTF currently does not even round-trip relative tables,
        so I ignored that format.
        
        Change-Id: I5bfc066864ab630755046b881e98503491cfb1ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123128
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-10-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ec76fff198323122bedc63ffdfd896c2543102c6]

        tdf#140781 Update extended tip for ASCII dialog import
        
        Change-Id: I9be5573673f888e9932c114dc0018585d75d13d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123140
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-10-06  Eike Rathke  <erack@redhat.com>  [34b01c95d4cab81cb614b67c47b004ac86d266f1]

        Resolves: tdf#144970 Chart CellRangeRepresentation expects UI representation
        
        sc/source/ui/unoobj/chart2uno.cxx
        ScChart2DataProvider::createDataSource() calls
        ScRefTokenHelper::compileRangeRepresentation() with the
        CellRangeRepresentation property's string value and the document's
        grammar (and also other places calling
        ScRefTokenHelper::compileRangeRepresentation() in Chart context do, like
        ScChart2DataProvider::detectArguments()), so let
        ScChartsObj::addNewByName() generate that from the
        Sequence<table::CellRangeAddress>.
        
        Also let ScChartObj::GetData_Impl() parse a CellRangeRepresentation
        value with the current address convention.
        
        This is congruent with
        offapi/com/sun/star/chart2/data/TabularDataProviderArguments.idl that
        for CellRangeRepresentation says "The representation string is of a form
        that may be used in the user interface.  Example for OOo Calc:
        "$Sheet1.$A$1:$D$7"", which is Calc A1 but agnostic about Excel A1 and
        R1C1 address syntax. TabularDataProviderArguments is mentioned in
        offapi/com/sun/star/chart2/data/XDataProvider.idl at createDataSource().
        
        Change-Id: Ie89d9aa3d5bc3eda9a65932a445ee8a1b4b266f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123188
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-06  Julien Nabet  <serval2412@yahoo.fr>  [490479c9b6f75dd857b8b644f84f65c37c1b460f]

        drop 'using namespace std' in vcl (MacOs/ios), blindly
        
        but hopefully there's a Jenkins machine on MacOs
        
        Change-Id: If5e87d16e64f010494ca1e5751ea6873f3a21a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123190
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [080547f644017353ff3c1d8cd91076e05d2ee373]

        comphelper: remove unnecessary using namespace vcl
        
        Change-Id: I7f49f23bcfeceb01ea470287705199fc846d1cb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122817
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d200d8e739595bd4c6310bede7d66e3c05fbb85]

        loplugin:moveparam in ucbhelper
        
        Change-Id: I1b9cc0366fb8e9b2525a56816ae4f76737a31b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c3990c38ddc5e69c89d9cb0c1a521f144e852f7]

        loplugin:moveparam in connectivity
        
        Change-Id: Iaf3a64effb69fd82c6303d8fa75723ccc5ced543
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [46a2b36aefde5de7abeaca230973cf0d47b9a505]

        Fix typo
        
        Change-Id: I2f229b95c997a6e4f87f3d91fab1bf299cfe9670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123149
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-06  Noel Grandin  <noelgrandin@gmail.com>  [7c1742761317a4b074a0fba6e9d7720aba5b838b]

        use SfxItemSetFixed in svx
        
        Change-Id: I2b31d586ace6720b9bfc223f78874bf347d64521
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123143
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0117eff7f16277e7d6df18be60a6d6138b8611c]

        loplugin:moveparam in basegfx
        
        Change-Id: I68d0de099641ae5b2ae92f46e86bdf4a43c468a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f25d0deaa71f7e48f2f0255150ae62fe76ce6835]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e11fca7e6ef36de4e49473b3ff3126678fd41225
          - tdf#140781 Improve Help for Text (encoded) filter options
            
            -Regenerated convertfilters.xhp
            -Added examples from start_parameters.xhp
            -Updated pyhon script
            -refactor xml
            
            Change-Id: I730aa77b87133701c2beb3efc9559f7145ce15bd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123150
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-06  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [6da7e4de06b413a52070ac5414b7e1989eedb322]

        (related) tdf#144483 Add Range frame above range selector spinboxes
        
        to indicate better this is independent from the Save as options
        
        Change-Id: I1855c84dcb11f8db1da458eaa8f8dc4b239e31ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122164
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fd0db00ed26b9cfef9280ed8889dc3cde9756c75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 898c44caff86cd05b2e11d977d12296f644c16f2
          - Fix typo
            
            Change-Id: I25ba4f1178a02aa4337d1310261a32ed1dbfd3e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123148
            Tested-by: Jenkins
            Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            
2021-10-06  Caolán McNamara  <caolanm@redhat.com>  [50a1b6e18ee51aee479495039aba3fdede2711ce]

        Related: tdf#141633 similiarly support match spinbutton font size
        
        to the desired zoomed font size in the table control
        
        Change-Id: I9aafec5b9a236bf5d140fd9b8bfc9000c3f0bf35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-06  Luboš Luňák  <l.lunak@collabora.com>  [e7ec79fe36a0f22f10167806da80e3c1f30b36e8]

        ScRangeList::UpdateReference() join all ranges properly (tdf#140901)
        
        This is basically a revert of 6eb8634a9f62bfe486ecd2f46, which
        made this Join() just the last range, probably under the assumption
        that the function is always called with just one range to update,
        or to avoid the possibility that Join() removes several items
        from the list, breaking the next step of the loop. But DeleteArea()
        may split several ranges, so we need to make sure to Join()
        all of them.
        
        Change-Id: Iea124142335ccdc8fa578344cddce8670c27573d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123135
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-06  Caolán McNamara  <caolanm@redhat.com>  [a693009c28059435ea5bae6d89a76e2243fe7793]

        tdf#141633 use css instead of pango attribs for font size
        
        in GtkEntry. Rendering was using the font set via pango attribs, but
        when measuring the mininum size gtk will use the min size of the widget
        font so that has to change to allow the GtkEntry to fit the size of the
        desired font
        
        bundle together the setting-font-via-css as "WidgetFont"
        
        Change-Id: Ic00d8b84decf528016fe47fc3b142daf3439340d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123138
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-06  Hossein  <hossein@libreoffice.org>  [cb2739767aa1000687beb29d3a5d21ed1ec3ba4e]

        Cleanup svgcharacternode.cxx
        
        * Replacing Ternary conditional operator "?:" with "if" statements
        * Adding using "namespace drawinglayer::primitive2d;" to avoid long statements
        
            Converting this:
        
              drawinglayer::primitive2d::TextStrikeout eTextStrikeout
                      = drawinglayer::primitive2d::TEXT_STRIKEOUT_NONE;
        
            to this, which is much more readable:
        
              TextStrikeout eTextStrikeout = TEXT_STRIKEOUT_NONE;
        
          * This is avoided in the header file with only one usage of this namespace
        
        Change-Id: I0bbc80a894056806dc03f46df5b62d92c2cd4a0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123102
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e467d0e761b0158f9501041ba352d528595e3cdb]

        Bump Glade version for asciifilterdialog.ui
        
        Change-Id: I80ed80b8f639fc4a53a7ebea3222f3f2e533c913
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123139
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-10-06  Caolán McNamara  <caolanm@redhat.com>  [10ec02f6fe4cd2c29021b967c255ace3f71424b5]

        Related: tdf#141633 allow "small-button" elements to shrink further
        
        so they can go smaller to fit small zoom sizes for the table control
        
        Change-Id: I6df47ed57a511e3b00d10075dedfdd9f1edcc477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [dee282441f3483c49759caff73ed3e1cde13f58d]

        lok: fix crash on chart doubleclick in patchPaintWindow
        
        backtrace:
        SdrPageWindow::patchPaintWindow(SdrPaintWindow&) (this=0x0, rPaintWindow=...) at svx/source/svdraw/sdrpagewindow.cxx:168
        SdXImpressDocument::paintTile(VirtualDevice&, int, int, int, int, long, long) (this=0x64589d0, rDevice=..., nOutputWidth=180, nOutputHeight=135, nTilePosX=0, nTilePosY=0, nTileWidth=15875, nTileHeight=11906)
            at sd/source/ui/unoidl/unomodel.cxx:2240
        
        Change-Id: Ie5270c3cc4a40121485d5da756a498ec4fd8bf80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123044
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123134
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [07ed070307e84e9f4f42461b788e5ec62a8f5a4b]

        jsdialog: sidebar: fix master page layout value sets
        
        fixes: https://github.com/CollaboraOnline/online/issues/3322
        
        Change-Id: Iaed50c19d4a0f45b00ada305fadcb1372aa6ba63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123037
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123133
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [3b72018b3c3056d422c3474bca30b1a157ae8dc0]

        sidebar: update chart panel on checkbox change
        
        This fixes not working checkboxes for "title" and "subtitle" on mobile
        
        Change-Id: I126bb020f669c8c4a34687f750a538513cd06eae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122876
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123132
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [d25debd3c1a19c52c9d4aa4da4ce8d36de45afdb]

        Deduplicate reference marks and cell auto fill messages
        
        We use only the last value
        
        Change-Id: If3536b5b4bc67755cb7bb73850a590d37675e6a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114547
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122106
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123131
        Tested-by: Jenkins

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [927de6c264d43ae5ad4b32ea38c0d1120ba0ebe1]

        vcl: test OutputDevice::DrawArc(), DrawChord(), DrawPie() and DrawEllipse()
        
        Change-Id: Ie1513d75262b4664a3b2620fca27d805d4e780bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122821
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [f4d5be05f643e9a483fcbb8441faa4a89c0cb280]

        vcl: test OutputDevice::DrawRect()
        
        Change-Id: Ic9ed566d171b3059fbe6de9fcc32ca0af6db7a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122820
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [d4b68f063cbb3c490e1ad084c3f9eb30c6a8c93a]

        vcl: test OutputDevice::DrawLine()
        
        Change-Id: I17691623e28a75080a1a46099796ec24bab3b91d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122819
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [4fb0d442316e914d3a75e317d6756d95b920a3e1]

        vcl: test OutputDevice::DrawPixel()
        
        Change-Id: I82651c6f41f46bb1097a69f3bcddcac2486a5baa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122794
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-10-06  Aron Budea  <aron.budea@collabora.com>  [203068319e17377cafb9e298a910f42fde417a21]

        tdf#144122 Use signed type to avoid stealthy underflow
        
        301278b656e76b6f42af5cf8a6f5c6c02acfffeb and
        6fdd0a3f8b3448a9a246496191908c92156cc38b switched
        some sal_uInt16 types to sal_uInt32.
        Additional commits related to the change:
        9e075acf2bf1ce6c43fdf5b601507ee0663bd691 and
        2634bc59092b24217d984a5845365d703bdb08d2.
        
        A fallout from this change was tdf#144305, fixed via
        0c3e47cc2f0570a7cd8ff4889763991a86b29f26.
        
        Instead of adding further casts to force conversion to signed
        to avoid unsigned types underflowing into large positive numbers,
        convert these types to signed SwTwips.
        
        Change-Id: Icb7fbae79621d452cd03bb01dc620f60a26f1db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123014
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [61ecd15cc81a0d14d27e727ea0c9fe6317cc13a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8589981a5f5dbe83cff6bdc86db01e54779a4255
          - tdf#144957 Help on deleting array formulas
            
            Special thanks to Alex Sims for excellent bug report.
            
            Change-Id: I15ab6b6b8c86633a779b3f4c55f10665bdb63c62
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123137
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-06  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [da5580369bfd15857fb21a1f610e393d07abb805]

        tdf#144907: sw ui: allow closing of "Fields" dialog
        
        In some cases (described in task) dialog is not closed.
        This is happens due to not delivered request to
        SwTextShell::ExecField(). So we could just close dialog
        explicitly, if Execute() action did fail.
        
        Change-Id: I1c712295a21037bc8bb28e2a97e750299b41250c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123059
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [727bb5ed6bb53ef00b61ecdebb0b9cca50f167e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 336a1a866e9b84a929e9d4403564e37947a0eba3
          - Refactor and fix merge/unmerge Help after translation round
            
            - Remove embedvar'd text from sentence (break translation in some langs)
            - Refactor formattings
            - move bookmarks away from lists (breaks list formatting)
            - update icon size.
            
            Change-Id: I2bdd2b026ed167f42894d1cfc61c19a1617d79a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123123
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-06  Caolán McNamara  <caolanm@redhat.com>  [2dfe1726d5262820c910d810b955ea73d3c7ae95]

        CellController always controls something derived from svt::ControlBase
        
        Change-Id: I051c2d0cf134502943bda5aa0bad9b04163c221f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [0ed940e3eb87c7048a1a8e6cfda14e7cef85d007]

        lok json: write correctly formatted array for comments
        
        Change-Id: Ia9a219f867ea00444844f6854f0b6af762d4e0af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122149
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123107
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [57a628d540287c4bfa8251e50279f4879faa184d]

        calc: get rects faster for simple selection
        
        In LOK when we select the full row using keyboard shortcut
        Ctrl + Shift + right arrow we need to receive complete selection
        so we will avoid requesting it by chunks, slowly moving the
        view to the right.
        
        So - don't clip the selection rects to the visible area.
        
        It is needed only for simple selections so to avoid performance
        issues - use simpler algorithm without loops checking every cell size.
        
        Change-Id: I6ab975b6c155f3dde3014a52752ffdc79a93844f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120611
        Reviewed-by: Henry Castro <hcastro@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122107
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123099
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [8ede76d9accc8e3b1ea2c8e332cbb373a1b4d9cf]

        lok: IME: directly copy formatting for inserted text
        
        This is a fix for online where after:
        
        lok: IME: preserve formatting when inserting at the end of paragraph
        
        https://cgit.freedesktop.org/libreoffice/core/commit/?h=distro/collabora/cp-6.4&id=bf96d1f23e5c12f9263643dfdab94fd1361bb098
        
        text formatting is lost.
        
        Change-Id: I3d316f8f4c4d750eac7900228f9f2d99f70d99bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122199
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122478
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123101
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [7df324b4561a6551812bdfa5b72ba1c937148c41]

        lok: IME: preserve formatting when inserting at the end of paragraph
        
        There was a problem with inserting characters at the end of paragraph in
        online.
        When user set text to bolded, inserted few characters, then switched
        bold off.
        When trying to put another non-bolded character - the result was still
        bolded.
        
        It is caused by IME mechanics which gathers all elements for composition
        and at the end deletes these characters and inserts again but using
        document interface to keep undo records. During that operation
        formatting has been lost.
        
        This change does the same in reversed order so we first put new string
        correctly formatted at the end. Then we remove old leftovers. In result
        formatting is correct.
        
        Change-Id: Ieb498afdbe42c0080c30ea3db994cedc98e89847
        Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121774
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123100
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [d99c7586edf41e1b22f1ef363859a86bf397e35f]

        jsdialog: send full update for autofilter
        
        Change-Id: I64baa5fea03f96350fe4db86ea0e42e02d41e8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122531
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123105
        Tested-by: Jenkins

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [b8e9e1bc7713ac159c3f23f9e4be4ddb656a9d79]

        jsdialog: avoid compiler warning for plain vcl window
        
        Change-Id: Icfe5a07e74801d59d6bb0988948bdf20f22bc3e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123110
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-06  Szymon Kłos  <szymon.klos@collabora.com>  [dfff37d1d92074abbd8ad0dc5c79a4e269d09f61]

        jsdialog: weld plain widget
        
        Change-Id: I85a23a7ea14ab580d4dc222d80edfaa8423cf952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122562
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123106
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-06  Luboš Luňák  <l.lunak@collabora.com>  [e304383b88d271b0e140946af201099c8314dd0a]

        avoid repeated calls to SfxNotebookBar::IsActive()
        
        The call reads configuration, and so is a bit expensive when
        called in a loop.
        
        Change-Id: I62398bcfdc856f02f6e2d928bac2f144bc47424d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123103
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-10-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [564e12518632d937cf9e510679f33399851d8a9c]

        vcl: remove unused class ImplDeviceFontSizeList
        
        mpDeviceFontSizeList is no longer used in OutputDevice, so remove this
        member variable, and then remove ImplDeviceFontSizeList.
        
        Change-Id: I93353909485a9243ae02d44c2adc1c9c4a769cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123125
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-06  Miklos Vajna  <vmiklos@collabora.com>  [046eab181e89e6265f06a2d851a339bbef7c3ee5]

        CppunitTest_sw_ooxmlexport10: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I7a1e61775107506b9b05f5ae635f5a0afaca5ffd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123117
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-06  Jim Raykowski  <raykowj@gmail.com>  [cca6092c43e6f5ff56251b2fd43e7530b99358e3]

        tdf#144788 SwNavigator: Group footnotes and endnotes separately
        
        This is a follow-up patch to separately group footnotes and endnotes
        under the Footnotes and Endnotes category. A separator line is shown to
        distinguish between footnote and endnote entries. Entries above the
        line are footnotes, entries below are endnotes. A tool tip is also
        displayed to distinguish between them.
        
        Change-Id: I2c4c3ab074da3bd6ba60220f8e7bcc60125bf81f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123124
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf739db1d6261c43b5b28c6795a4b5b30156478f]

        loplugin:moveparam in drawinglayer
        
        Change-Id: I428116d96a011b061dda8376b6f27fb135a62964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123114
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [547d8dacffc87586597d43e0e0378b4bb86b67a8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff4b6d982cb29758b1e81e04f8e404c8ea7324c9
          - tdf#136495 Explain how to quickly switch between Landscape / Portrait
            
            Change-Id: If35934545e42f165512d4d2c1fdc84d1ea709fd6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122948
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [372005419f68eff13f526b3f1bf4a344370ef4c2]

        update credits
        
        Change-Id: I434832c8b4395e8a8e0df44ad056e07cce6585d4

2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [10ad9560fba562f494fa44fc8a7bd2388d9e8c5c]

        drop 'using namespace std' in o* r* x*
        
        Change-Id: I15d56d133cf464a3cb6483be785b1259c7f35b43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123120
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [1f90b8086fcad7ac033e76a96bf102db7c15e44f]

        drop 'using namespace std' in s* + toolkit
        
        Change-Id: Ibd0b983d46a5683df64b4de79cd444427705e9e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123118
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [3068ab9a2c9307cbea2efa2b6924ce427bb54466]

        drop 'using namespace std' in h* i* j*
        
        Change-Id: I3c28651779f17e1a410505ffaa863b4773037ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123119
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Caolán McNamara  <caolanm@redhat.com>  [b35b1dca3a734739a9780c17331b8368d7df7657]

        ofz#39150 skip detecting bidi directions
        
        Change-Id: I92eb838f0ee744902f3c358fd1627970eb548ef8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123085
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-05  Eike Rathke  <erack@redhat.com>  [ce8a7278e1304f7aaa65bce34aeeda5e83b231f1]

        Fix crash if conditional format triggers recursion with iterations enabled
        
        Could occur if a conditional format is evaluated (for example if
        row height is to be obtained) while a formula cell it references
        is still running and iterations are enabled so the conditional
        format's temporary formula cell is added to the iteration
        recursion list but iterations are not triggered if there are no
        circular references. In that case the temporary formula cell's
        pointer remained in the recursion list and it's dangling instance
        was accessed in the next round. Mark such formula cell as
        free-flying and remove from recursion list if it was added.
        
        Observed at
        https://ask.libreoffice.org/t/lo-calc-crashes-when-calling-a-macro/68800
        with the original attached file that now got replaced with another
        version that doesn't have iterations enabled so wouldn't trigger
        the bug (and apparently even doesn't if enabling iterations).
        
        Change-Id: I23a023356f920b8413874cab14acdc8b25580052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123115
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-10-05  Luboš Luňák  <l.lunak@collabora.com>  [057968bbce406efe6564347329df45b7e0f823ce]

        do not block out PaintImmediately() in LOK mode
        
        I'm not sure why I did this when disabling LOK idle painting, even
        if a window is not to be painted to, it still needs at least
        invalidating.
        
        Change-Id: Iaed6b1071d05d05d6bf5195f3803afb1fc018508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123097
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [0a78cb8eb1ebbfe55896d603e8aa94816242c2cb]

        drop 'using namespace std' in winaccessibility
        
        Change-Id: Ibb6c4b747a706e126f5469d8348cd78a70561075
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123116
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Mike Kaganski  <mike.kaganski@collabora.com>  [7e558cd5b90f45c67ffc4d03f1c54564aff54bbb]

        Optimize the whole range of getN10Exp over IEEE 754 doubles
        
        Needs 5056 bytes of pre-calculated data.
        
        Change-Id: I138d9dc80c176f675a6854fe906e235c98efcbc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [08ec94371cd2c395c0c5a157e5c6d737ecfe4f20]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a82f9c51bdb39d0a784069e2927683273c9f8ebc
          - Fix typo
            
            Change-Id: I4fa3a07e7094b4bf2a6428aa8a910c5b8d672191
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123113
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [311964173ff0591a01d81715b1cc48b1ffa14abf]

        drop 'using namespace std' in vcl (Windows part)
        
        Change-Id: I8516e48f5e4a7266aef35ba2e31ebd107bf8169b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123112
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Julien Nabet  <serval2412@yahoo.fr>  [3c51d5d80c9932e6d13dd09c8fe2ceeeeb741656]

        drop 'using namespace std' in sw
        
        Change-Id: Idb2350c32d9fba55e9ad8db7aa4c1a280f03ca6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123068
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [2c0ce0daa0a2eae87e6425793e0dfb39ac5a359e]

        tdf#143148 - Use pragma once instead of include guards
        
        Done in preparation for movement of PhysicalFontCollection to vcl::font
        namespace.
        
        Change-Id: I17f27afd3ff0763866f3b2c169f7ee100d7f26d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122406
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [46973de8b4a2de16f68053144f2a63a122ff766a]

        vcl: refactor PhysicalFontFace::IsBetterMatch()
        
        Refactored PhysicalFontFace::IsBetterMatch(), which works on a
        match weighting system to figure out if the font face is, as
        the functions implies, a better "match" than the one already in
        the collection.
        
        To refactor this I created a number of static functions that
        return a match value for specific attributes to be matched upon
        
        Change-Id: If95b4ad7c5dcfabf34469cbce1260886e4674415
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122812
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [cc81b6353ec1983b652d1c370ee80d77b5f8d1e8]

        tdf#124176 vcl: Use pragma once instead of include guards
        
        Change-Id: I0bd1384df1f022bcd03e586bd9e380e432a46313
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122909
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [c817a5a4958c323eb189e1374072998b8b13ba8c]

        vcl: test PhysicalFontFace and move to vcl::font namespace
        
        - moved PhysicalFontFace.hxx to vcl/inc/font
        - added PhysicalFontFace to vcl::font namespace
        - had to regenerate precompiled_vcl.hxx
        - tested PhysicalFontFace, with some extensive tests for
          IsBetterMatch()
        
        Change-Id: I860022ac244f8a827f6f9cb7ed9018c5d9c328cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121970
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-05  Szymon Kłos  <szymon.klos@collabora.com>  [0e736b0c20e096c5daf59f141b4509cfcc159a79]

        Check mpWindowImpl before use in Window::EndTracking
        
        Change-Id: I0a4ddd1b61f5919f346bb2f3a1e2ca9fbad958bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120860
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122108
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123098
        Tested-by: Jenkins

2021-10-05  Luboš Luňák  <l.lunak@collabora.com>  [a733c728a2e255507abf2dc7107ba730ee0f2bd8]

        remove useless '&& true'
        
        Change-Id: I7ba14695171a832bf7e858cb17160861487fb3a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123096
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-05  Noel Grandin  <noelgrandin@gmail.com>  [17915ab5202a4d7456e9bc031c3f6a72bc861844]

        fix ubsan alloc-dealloc-mismatch
        
        after
            commit 503ab1ca9ae11978d9717557546c01ff598aaf88
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Oct 2 16:28:56 2021 +0200
            Use placement new to avoid one of the allocation calls...
        
        Change-Id: I2eb85c5c1be5d2eaf757d717f03873415e49c9a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-05  László Németh  <nemeth@numbertext.org>  [74650680788dc076a37d2fe4d5f9237c450807d0]

        tdf#144748 sw: fix crash at Undo of deletion with empty table rows
        
        When a table with empty rows is part of a bigger deletion,
        Undo of the deletion resulted a crash, because the deletion
        created extra redlines for the empty rows within the bigger
        redline.
        
        Regression from commit 9994120c8d0fe8c5a029390ad7411b99c18ff5c9
        "tdf#144347 sw: fix tracked deletion of table with tracked content".
        See also commit 99059a1ececa3621c2fe46fabdd79eed9d626c42
        "tdf#143359 sw: track deletion of empty table rows".
        
        Change-Id: I0e33e169c1ffe60022a6b66a6d70fdd9c0a9332a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123091
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-05  Caolán McNamara  <caolanm@redhat.com>  [afb022f0a399799be43a3fd3a1380b6b26350ed4]

        ofz: detect infinite loop
        
        Change-Id: Ifc3134401c4ed7c4b17faf282d191ad2bb778746
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-05  Ismael Luceno  <ismael@iodev.co.uk>  [19d85ff18f3f27d68908091242eb7e22b85f9e7c]

        configure: Fix libc version check
        
        Testing for gnu_get_libc_version isn't quite right (available before
        2.1), and the feature macros were already present.
        
        The new test at least will fail for glibc < 2.1, but will pass on
        non-glibc systems.
        
        The buildsystem should be actually checking for some sort of compliance
        barrier instead, but this is a start.
        
        Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
        Change-Id: I879278c2946c1fa5416da0407a949c8c4b2a8bf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123006
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-05  Ismael Luceno  <ismael@iodev.co.uk>  [dd855b9af9b180e878c5cffa881f4f68cff4afb8]

        configure: Allow building on musl-based systems
        
        Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
        Change-Id: I64e9dea846f3753a91d87bb664af30d0790b5159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123005
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-05  Miklos Vajna  <vmiklos@collabora.com>  [2d9eddbb23625aad7a9accedbf69209a04169f00]

        sw layout xml dump: show width/height/length even for multi-portions
        
        The old SwPortionHandler-based approach doesn't handle multi-portions.
        
        Change-Id: I6702e7af3b9fe7e4c25692c22e8f35d9ab98f67a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123061
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-05  Luboš Luňák  <l.lunak@collabora.com>  [71429b93ec0687bbbedcbb776b38c981f4017177]

        try to merge rectangles already in AddPaintRect()
        
        It turns out that e.g. adding a new line in Writer results
        in a number of paint rectangles that actually often line up and
        form a large rectangle. So try to detect these and merge them
        directly, resulting in less work for SwRegionsRects::Compress().
        
        Change-Id: If89ae9463d9c80a1492431afd37bcedfd24bea2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123077
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-05  Luboš Luňák  <l.lunak@collabora.com>  [8e49016473f0142cb07a1b30f4073f3e73aa4747]

        fix broken SwRect corner getters
        
        BottomRight() wasn't equal to Point( Right(), Bottom()). Smart *sigh*.
        
        Change-Id: I0af1c018cdf10a4ff23d95752004e565b4102b13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123076
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b1488cd6f008049a9aaff7350deeb73cbbd535b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 80e65e1d4c346cde0c056a2288dfc02c5aae8f92
          - tdf#119891 Help page for scanner dialog
            
            Change-Id: Ic379a8c79504d74ea02126b96504214ee968aa1b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123081
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-05  Olivier Hallot  <olivier.hallot@libreoffice.org>  [299c9f1808c802e3a7a9e5fda1a6f9efa4207c52]

        tdf#119891 Scanner dialog has no Help button
        
        Added extended tips for the SANE dialog
        Help page will follow
        
        Change-Id: Ibf60eacb561fd65caa682bfa710e52b93b6148d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123080
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-10-05  Jim Raykowski  <raykowj@gmail.com>  [24d3e8d219ce73a2e93f207b65050078535da57e]

        Related: tdf#144817 tdf#144335 Persist SwNavigator tracking settings
        
        Add persistence to Writer Navigator Outline, Table, and Section
        tracking settings.
        
        Change-Id: If2d406d0540083d982c2e7ffb78b1a6e156817c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122874
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-04  Julien Nabet  <serval2412@yahoo.fr>  [2f54c40fc28294676a129cfa86eed39f974a9e24]

        drop 'using namespace std' in l*
        
        Change-Id: I88909cf813f39a52c70d3cbcb19ff326d9bb42d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123069
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-04  Julien Nabet  <serval2412@yahoo.fr>  [bf82274d327146ec0aa2b4f8a0e6d1bf24366cb3]

        drop 'using namespace std' in sax/sc/scaddins/sfx2/shell
        
        Change-Id: I422a6d5b0151115203fd2d7c0fc5597903d3ec8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123064
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-04  Caolán McNamara  <caolanm@redhat.com>  [b845fc51bb5c40eac121bbe52d8c77257bcbcdf3]

        Related: tdf#143391 avoid creatinging a negative height for the scroll area
        
        this is similar to the case of IconViewImpl::CursorUp so presumably
        needs the same safety check
        
        Change-Id: Id1a79c27daabbf4e2077d46c3d14324695922ca1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123066
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Caolán McNamara  <caolanm@redhat.com>  [5a930d4b33e6b5e6642c936cb643c2c5605d6110]

        Resolves: tdf#143391 scrolling by an entry height taller than visible area
        
        leads to use of a rectangle with a negative height. Drop the attempted
        optimization, of reducing the area to copy to the min required, if the
        area is already shorter than the height of the area to scroll.
        
        Change-Id: Ic17d3d017f5280d1f6b655a2fc61627f512849cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [79e6ad35d5402b6485d9776c60e20eaf236dba0f]

        Update git submodules
        
        * Update translations from branch 'master'
          to e8881fe8aa87f07547d433e9fbb82e0e768eb719
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I1658b92ce4e7a15ad5539e5dcba48bfd1951744f
            
2021-10-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [d294e3e9626983233736c80f4ddf2d4f2d5857ca]

        Bump Glade version for sanedialog.ui
        
        Change-Id: I9d787d392d5582fdfbe1928c5e3918863f178260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [36f69c61a9d7b456c9d93d371eca4b61a3a94f8b]

        Fix typos
        
        Change-Id: Id88532da843e659d337f3529333a17a0c00c8328
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123050
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [9dddc933dd1d30eec9b3696c0052f5375a9d211f]

        cid#1492313 Logically dead code
        
        Change-Id: I2e3802881e5fde178dfc2f999b2ddb35923c221b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123055
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-04  Chris Sherlock  <chris.sherlock79@gmail.com>  [b26a1185d71d30f9b9ed86f99a2fc6ee41899130]

        Add sal/config.h in preparation for patch
        
        The convention is that we need to add sal/config.h to the start of
        files.
        
        Made in preparation of movement of PhysicalFontCollection to vcl::font
        namespace and test class.
        
        Change-Id: I7768d9b4c7335f0d9feeba96f0dc67aaaaf8441e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122259
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b7a86abf28dcc2400a691200b0ea11ee5a9e537]

        loplugin:constmethod
        
        Change-Id: I56af10be5f1155db4c7f2190495fe036a9b4236a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123054
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-04  Tor Lillqvist  <tml@collabora.com>  [717dd57000212dda5f4ff5b167d3f3b0f498a98e]

        We need com_sun_star_animations_AnimatePhysics_get_implementation
        
        Fix crash in iOS app reported at
        https://github.com/CollaboraOnline/online/issues/3321 .
        
        Change-Id: I1b5fedb0d5db84cc3f6a75b52c29a39ebe7a6ed9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123046
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123047
        Tested-by: Jenkins

2021-10-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3c5afc731ef7d3aa8368b3a79bfd674cce8f85df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 54e30f4bb12626aad1d101d2de20a9b5df10770e
          - Fix typos
            
            Change-Id: I23fad13f1010360c5129358b929c4cabeab89f40
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123049
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-10-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [8a3fb8964d99c17cadb7b9f67cff3404bc41a506]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60ed9a0af0790ab7c7ed13149d6f1da200b2470a
          - tdf#105601 Update Calc's Data menu documentation
            
            This patch updates the names of items in the Data menu. It also removes
            the link for Data Provider, which was previously removed in 24939a5b43b9fe889c3aace027c668666ff61987
            
            The "Streams" page was also updated to inform that the feature is still experimental.
            
            Change-Id: Iccd6059e1c4f2203a3c64cc2b32c90eb281194dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122934
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-04  Mike Kaganski  <mike.kaganski@collabora.com>  [347e18a3e8a742dc63833bc030dcf224499853b3]

        Use isRepresentableInteger here
        
        Change-Id: I8ba202232fa42765a8b04113639fdac4b5724aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122941
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-04  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [54cc6c21c8669ce1b8e8bdaa5920a274cc8a9d4b]

        tdf#144439: generate list format string on level change
        
        Changed values for included upper levels should cause
        generation of new list format string.
        
        Same applies to outlines editing.
        
        Change-Id: I90e19d6b5169f68c83ae3e55ec41b9016623d8ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122590
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-04  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [e6bf21d2d5efb231c877eb985997b28033198600]

        tdf#144578: numbering: generate include upper levels for UI
        
        In spite of used list format in ODF for UI we still need to
        show prefix/suffix (already was there) and included upper
        levels (done in this patch) for correct visualization of
        level properties.
        
        Moved initialization of ListLevel to later steps to avoid
        overriding of generated values for prefix, suffix and
        IncludeUpperLevel by some invalid values.
        
        Change-Id: I5d132426c06021ed526d16fb09276523105aa7b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122686
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-04  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [66a7f8a49d2db1829dd533f32ae5818499f8544b]

        tdf#144609: numbering "None" should still show prefix/suffix
        
        Unlike it was implemented in tdf#143605, prefix and suffix
        should be displayed anyway, we do not display only numbers.
        
        Moreover tdf#143605 did accidentally fix tdf#135164
        in a invalid way. So this patch is also providing a better
        fix for it: untittest is already created and failing without it.
        
        Problem in tdf#135164 is inability to distingush missing level
        text (bullet char in given case) and empty ("") one. In first
        case we should use abstract level definition. In second - not.
        
        Change-Id: Ica3a714d22de4d2f14ebbcb12f0e1311dbc9b801
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122609
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-04  Andras Timar  <andras.timar@collabora.com>  [1ecc5d98aefbf1779d157aee80308d26ff28458a]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 6c9f1f6c2546d192d1a3b25d5f48d8081170e8be
          - Avoid duplicated pt_BR_pt_BR.properties in packaging's filelist
            
            Change-Id: I5ebb15f0a9f391fdf686ea7ebc7fba98c373b2a6
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/123048
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-10-04  Johnny_M  <klasse@partyheld.de>  [68135e421c930620b1703da7721d14942fb3fbc2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f49393db3d21f7de379b589c253eb4eb6252cba9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5abbe33292ea3ce25d78a7ca3bf161bd8feced38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122986
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-04  Caolán McNamara  <caolanm@redhat.com>  [952a678634461f741ee4ef2082d591a162a7f71c]

        Related: tdf#141633 similiarly support match combo/listbox font sizes
        
        to the desired zoomed font size in the table control
        
        Change-Id: Iaf3b004544fdb0311b6c67baad612ba648e8c546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123043
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Caolán McNamara  <caolanm@redhat.com>  [93d2d55b1df6bc850d6beecbabf1fb602abe9809]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: If6ebf0fb1fa0e3db830ff9d22b1a90446bd3c2d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Jim Raykowski  <raykowj@gmail.com>  [80da4d6d4bfe3607a7fd9641f83ebb49a1886697]

        Pass shell's layout to getLayoutFrame here
        
        Change-Id: Ic11d3c6105226059d79f6dd9ff4a2c117131a135
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122665
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-04  Verne-Lai  <verne@ossii.com.tw>  [dad5b69b229047e0bba921f185dddd6ce26183a5]

        [tdf#42982]Improve runtimeException's Message
        
        Change-Id: Ieb1bc302c2c1093561082704e26e3ff3b648db91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122902
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [af291666b3316aba2b35d3b8358f4cd42c553587]

        Breeze: tdf#144637 update & fix table cell border
        
        Change-Id: I84c5ff88298794b3ccbb883af1664fa93fcc9532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123034
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-10-04  Caolán McNamara  <caolanm@redhat.com>  [84096998c181c8762fccc98f0faaf48fcf12ef97]

        tdf#144674 no context menu in SQL Query
        
        Change-Id: I3c6e9e7896da171d089579165f466b4b6e59a1a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-04  Miklos Vajna  <vmiklos@collabora.com>  [410e294f8decccdfe7eded7e5a6934e7eab1b867]

        sw: prefix members of SwFieldDataOnlyDlgWrapper, SwPtrItem, ...
        
        ... SwUINumRuleItem and SwWrtShellItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I2b360aae78200fcc0a479ec76e895331c6a0e124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123035
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-10-04  Jim Raykowski  <raykowj@gmail.com>  [c8aa07cae1821560a5bc6f15168f11e2407556c1]

        tdf#144817 SwNavigator: Section tracking option
        
        Add a check button to the section context menu in the content tree to
        turn section tracking on or off.
        
        Change-Id: Ib8c49626f31f41cf85818630d126dee98e1db809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122844
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-04  László Németh  <nemeth@numbertext.org>  [05f92eb1359c399c43d3bcbe8942034408fa23eb]

        tdf#77051 DOCX: fix user index and index entry support
        
        defined by field code \f.
        
        E.g. INDEX \f "user-index" inserts only the entries
        defined by XE "entry" \f "user-index" field codes.
        
        Revert commit a7bc9c1e4977bd3430df69287fa0a8377a686c58
        "fdo#77051: Preservation of Index field flag '\f'", which
        added an undocumented UNO property only for round-trip
        support of INDEX, but not for XE index entries, so the
        DOCX export still resulted a broken index with lost
        entries, not only the import was broken because of the
        missing functionality in com.sun.star.text.DocumentIndex.
        
        Now the import uses com.sun.star.text.UserIndex and
        com.sun.star.text.UserIndexMark index and index entry
        fields, which support the requested user index not
        only during the DOCX and OpenDocument round-trip, but
        its run-time functionality, the multiple user-defined
        indices.
        
        Note: for manual testing, update the user index (the
        first index) of the left original unit test document
        IndexFieldFlagF.docx: the updated index is not empty,
        as before, but contains the user index entries.
        
        Change-Id: Ia6139bba88907051fd050cfd40809f5544b9a89e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122930
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-04  Jim Raykowski  <raykowj@gmail.com>  [f8e086f185b31f753074fd22ecc73c44b193a784]

        SwNavigator: Use select by address function for tracking Fields,
        
        Comments, and Hyperlinks
        
        Field, comment, and hyperlink tracking selection in the Navigator
        content tree is done by comparing content address. This patch uses the
        lcl_SelectByContentTypeAndAddress function to replace redundant code.
        
        Change-Id: Idb9f48c46bb432bf2405e4fb0bd8d1830f2c26e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123031
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-04  Julien Nabet  <serval2412@yahoo.fr>  [e05620e5b9326d9555497efb9be867003c5c5a83]

        drop 'using namespace std' in sd + ucb
        
        Change-Id: I7d15e9a8c37c29cd6d51c2000f72d1961cd6ff62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123029
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-04  Ross Johnson  <ross.johnson@homemail.com.au>  [b32c9fb3d10af285dc353a27b760a427e81da311]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 957430b19287e080ddf30b14643e9a653d9293ea
          - tdf#102151 - reworded the description of page style First Page Number
            
            The current description implies that numbering will start at 1
            if this option isn't selected.
            
            I think most users know what this option is intended for but
            rewording can make it unambiguous.
            
            Related changes:
            1) Translate some id's from german to english
            
            Change-Id: I4f7734e47b3708be7d1948a7a038ab564d1013e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123013
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-10-04  Jim Raykowski  <raykowj@gmail.com>  [fc44168ebe840fa2e772f034232fed15460e4977]

        tdf#144788 SwNavigator: Add footnotes and endnotes to content tree
        
        This patch introduces lcl_SelectByContentTypeAndAddress function which
        is useful for content types that can have non unique string entries
        which can be selected incorrectly by use of the
        lcl_SelectByContentTypeAndName function. Although footnotes and
        endnotes names are always unique, lcl_SelectByContentTypeAndAddress
        is used here in preference of lcl_SelectByContentTypeAndName.
        
        Change-Id: Ia118f717f72877cddb932ef19f6d155a7227845d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122970
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-10-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [47d7ce6de04625b0a9045c2ca6dd25da0e70d886]

        Add extended tips to generalpagewizard.ui
        
        Change-Id: Ib5fd25fa109a7cd949fe455701e2240a5a2bcc1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123023
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-10-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [df26f9132aecb0238d9292b1d19390c0904a00c1]

        Bump Glade release for generalpagewizard.ui
        
        Change-Id: I5fbc312316e6fa790026f0b4514cf269ad99afcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123020
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-10-03  Julien Nabet  <serval2412@yahoo.fr>  [28480639b4d2ad29d48b98ab9fb7a3755cb9d19e]

        drop 'using namespace std' in package
        
        Change-Id: Ifa9f5c310a8be988c1058644540ac52f160bc156
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123018
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [117fdcf8d37ee764ebe74a8d410ab323254d95f1]

        cid#1492280 avoid Missing move assignment operator
        
        Change-Id: I59269ea818a98b4d5a2bf476b3aff2ca4f105a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Noel Grandin  <noelgrandin@gmail.com>  [503ab1ca9ae11978d9717557546c01ff598aaf88]

        Use placement new to avoid one of the allocation calls...
        
        ...when cloning a SfxItemSet.
        
        Change-Id: I344fee3863006066eade16db9df37599fc210be3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123001
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [c0fa33a82e900558682c676243f279d267ca3eb3]

        cid#1492171 annotate Data race condition
        
        and
        
        cid#1492172 Data race condition
        
        Change-Id: I2ab0d3af626b8d8007082a3dd944149973f8b63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123026
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [4b327251f3a7969d710d5a130472dba45122e354]

        add missing use-underline to menu entries
        
        Change-Id: I86bf3b52c68e5b4de25af5724df09b817ece0f58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123028
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [d96b8df690facebc741a2d6d099d95a7b86abbea]

        unterminated call to function 'call': missing ')'.
        
        Change-Id: Ida812eb3a002da3d99ddf3179d674a653f7ed2b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123027
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Stephan Bergmann  <sbergman@redhat.com>  [ad1557f5d775739230e0e2252c293948977b42a0]

        A more lightweight O[U]StringConcatenation
        
        ...compared to a full-blown O[U]String, for temporary objects holding an
        O[U]StringConcat result that can then be used as a std::[u16]string_view.
        
        It's instructive to see how some invocations of operator ==, operator !=, and
        O[U]StringBuffer::insert with an O[U]StringConcat argument required implicit
        materialization of an O[U]String temporary, and how that expensive operation has
        now been made explicit with the explicit O[U]StringConcatenation ctor.
        
        (The additional operator == and operator != overloads are necessary because the
        overloads taking two std::[u16]string_view parameters wouldn't even be found
        here with ADL.  And the OUString-related ones would cause ambiguities in at
        least sal/qa/rtl/strings/test_oustring_stringliterals.cxx built with
        RTL_STRING_UNITTEST, so have simply been disabled for that special test-code
        case.)
        
        Change-Id: Id29799fa8da21a09ff9794cbc7cc9b366e6803b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-03  Julien Nabet  <serval2412@yahoo.fr>  [7e7dd7f152bc7457437f541e7ff88d69e9f8e765]

        drop 'using namespace std' in desktop, e*, f*
        
        Change-Id: I277dc957798093001f9a3935f97db8ac0314e6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123022
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-03  Julien Nabet  <serval2412@yahoo.fr>  [f7a456af92f3c1c47731b7ad0494e74897aea4d3]

        drop 'using namespace std' in cpputools
        
        Change-Id: Ib454519ba3fb316557dc902c3ed03f9dec9d7900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123021
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-03  Julien Nabet  <serval2412@yahoo.fr>  [db12f7a63cb663493f364535e12b670bd13fbea0]

        drop 'using namespace std' in cppu
        
        Change-Id: I1c9e6d27e47e25bc5c96ceac8d72c7c112c73d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123019
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-03  Julien Nabet  <serval2412@yahoo.fr>  [868e82d70be0921c8338ccfc49c90343f82a2dd1]

        drop 'using namespace std' in drawinglayer
        
        Change-Id: I0221a05b82494971e9c557430dc2f8fe67e494ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123017
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [a4c11b853febd073d310251a4891cdc0ac54e0fa]

        cid#1371270 avoid Missing move assignment operator
        
        and...
        
        cid#1371301 Missing move assignment operator
        cid#1371295 Missing move assignment operator
        cid#1371215 Missing move assignment operator
        
        Change-Id: Ib03cddd42128d41e99173e9673bcf6f3cb5ddcbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [56f9efdf5cc30454dd36959f9d18bf55581c9141]

        cid#1485150 silence Uncaught exception
        
        Change-Id: Ib2d10db236ff646514f9b722d1f02a1906cbb111
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [c60ab1050e901c667ab8949509eaecee7c182b49]

        cid#1492173 Explicit null dereferenced
        
        Change-Id: I482b85707894c1b749c55fe1339caa5d2a7ae444
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123009
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [2337f70a7631a5d644b123fcbbed375395daa666]

        cid#1492221 silence bogus Dereference after null check
        
        Change-Id: I4e0554d16cac67bd8d829ed5e65fd4b17f4cf1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123008
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [cb517e21f6e3728199e3ecbaf9a31fdf5316bd46]

        TODO: remove missing .po support when writerfilter .po files exist
        
        Change-Id: I8f20845fcb1fbd598cf1c1c8c8ff20b3e9c37bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123012
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Caolán McNamara  <caolanm@redhat.com>  [e69d4963c3a7b71b4dc42e2f30b5cbdc4155d594]

        ofz#39528 Integer-overflow
        
        Change-Id: If50af8538e31e4fb1ee1486ec2b91963c094e7e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-03  Roman Kuznetsov  <antilibreoffice@gmail.com>  [e7a7cfa029f8a6979179c5cf394d7eea80982ca8]

        drop 'using namespace std' here
        
        Change-Id: I6ebbd0ece563f0d877b03389fa9a96311cd207cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122867
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-10-02  Noel Grandin  <noelgrandin@gmail.com>  [9946a2fef07840ff4ca842928afbeeb52ece3603]

        fix buffer overruns in JsonWriter::put with UTF-8 values
        
        Change-Id: I694585a1a540bfefc0e59bd58d8033a96ca35acb
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122996
        Tested-by: Jenkins

2021-10-02  Noel Grandin  <noelgrandin@gmail.com>  [897192f07c1f7863a50e09cdd29e6631550b83ff]

        simplify JsonWriter::reallocBuffer by using realloc
        
        instead of malloc and copy.
        
        spotted by mmeeks
        
        Change-Id: Ibac83be597cfaf61f783a265562c5102bbaf29d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-02  Johnny_M  <klasse@partyheld.de>  [c6a7e0b1df5675bf728892176fc6c12f16804db3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 267e527513f6ab5e3095058565cbcdc05bf58454
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5bd077fbe3f5494c6b1e89081a292613b2bbcf1d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122994
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [26cafed796ab83942c04fc6036d368cfeb06254a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f6a516877e3f3cd44d6070c9a27c5ed1a6cd9b69
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifb8cf2f10281efde2c511e9418d8bd5c7d0691de
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122993
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [93117d7f02c869432e4f7d0d0025934f0c623ab4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09797c77548a61e19fc715b4119ead61729e5d7b
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id88d5ac5b5265247844dacef1ce991fa194b7605
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122991
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [1a277e60f9388ea7133267d90678e5420bcb7a66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e543ba3f73b871b82722b1cb999dff2b9a09e651
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5a837226359ee29d8e38bf461887b2e5f770dd8a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122992
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [c53de09ceb513b90bf67066767c96bfb3d3627b3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a60109536835d50667fa6eb2e87dbf99067918a7
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2f0b5f4eddc78120fbc755a8871ec71e6043ed8c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122990
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [662fc7ca0d6dd5fd9eae6be7c3b7e0ca872874bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 93f59e16ff4da02907cea4ae95ef77a2c8949423
          - tdf#132643 Translate German section IDs
            
            Change-Id: I123db5db87dd3f812827d45c8be6061a1f6821d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122989
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [e2aaab0f75cca30dc9628aa173de1e414d3189df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 90ba7aa13149949dcde8e90a4a1cbca78b357fc8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9872f2c932f99d41915e670c54bb9b393ecff09b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122987
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [b617a70742246c70e54c9beb77d4d7b126d1eb8d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 15fae2564d521d127401db812d3ff867c6d5da5e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iac233e1d7bb51869e2e49bb0a62b0198892b2e3c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122984
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [e23b78c2b8ea1462536d844507d743257f06bc7d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0747a19b955fbcebee355240b8900225d00acd91
          - tdf#132643 Translate German section IDs
            
            Change-Id: I181c159b18fb968b730f128410c76143793a1c72
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122983
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [6aa536e7344835f2de3461b5119459fd07230404]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5c03bc3060b78b29a3fccfd5f7fb96ef51f17a64
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3ecac778917b0cc505f2e0dcc1506034061866ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122982
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [6499ff1a9101b970dae87ac56f392670caf29a40]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1b9af676fcdfaf35f53f9d50a1afa9ca31841f29
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5ec9160169d6524b4967b4d86666feaf6b8f74ad
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122981
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Johnny_M  <klasse@partyheld.de>  [8afdf32782e997831ce60361057aec51f9ef45ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 001815396c3c9bb454da36aaa292292d7f93e2ac
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibca023fa97e9891e44fd39e17f8580ebbc15f317
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122980
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8a2835d2a798a62e027f16327975acde30d2457b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ad6a7c10c2684a5fbdac4bea643a215c3bcb8ab
          - Refactor database wizard help pages (part)
            
            Change-Id: Ifcd63a48ca5faa3fa55f19f2949cccc4bd4ccaf3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/123002
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-02  Andras Timar  <andras.timar@collabora.com>  [8edafda76ad63a3bcce02086f3d4d02274b9940c]

        Related: tdf#80713 add KeyIds to LibreLogo strings
        
        Change-Id: I30499a3fcae8dad5419d7bf862f2a6d0ab08a225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122967
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-10-02  Caolán McNamara  <caolanm@redhat.com>  [a6a5927eebd51204f224bac16749ca65b258f772]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I774d7da0304735907da31ca0d7b3bde85718066b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122954
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-02  Caolán McNamara  <caolanm@redhat.com>  [f96e68ea8d86c78ca94196727e24ba34e38b182e]

        ofz#39515 avoid Integer-overflow
        
        Change-Id: I8bef8e19f066883d5fc731a1c7b7cd85948ae5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122968
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [f451494e385fa63fef3ffbeec0f85cea4f3e7db3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 39a1884a024666840913646b12841a458aeb51ab
          - Update SF_Platform help page to add the new Fonts property
            
            This patch also adds a new example showing how to use the Fonts property in Basic and Python.
            
            Change-Id: Idfab1df904e69cdb8974b774be1eac52bed2aa16
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122859
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-02  Jean-Pierre Ledure  <jp@ledure.be>  [b42a94c6fdc3c1cf2b4266c3642ca20c696a9d9d]

        ScriptForge - (SF_Platform) increase speed of Fonts property
        
        Tests have proven that the use of a case sensitive search
        on long strings improves significantly the execution
        performance.
        
        The number of fonts being potentially huge (2-3K), the change
        in the InStr() Basic function of the Compare argument
        can divide the execution duration by factors in the range > 5.
        
        Change-Id: I248ff88cd2cb5a2753e7749f8d512ad44b5fc8d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122979
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-10-02  Marco Pinto  <marcoagpinto@sapo.pt>  [17653c52c3c21e2b9f064156525ed008ac8304c0]

        [pt-PT] Added ~94 words to autocorrect
        
        Change-Id: I6e0c5fe765f5a067d1cb0eaef88af064de8b258a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122290
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-10-02  Andras Timar  <andras.timar@collabora.com>  [b93186c9224ed24afb252843fc0469bab63ceecb]

        tdf#141724 package qtz properties file as well, if present
        
        Change-Id: I7e7efdf6331f36c59d4632758492bcd342db70d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122965
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-10-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [7934085eb95cc0ff39e948525f0cc2b80edc0169]

        new loplugin:moveparam
        
        Look for places where we can pass Primitive2DContainer by move reference
        and so avoid unnecessary copies.
        
        Change-Id: I1db167feba6d1a616ca6fc39778118ae20106bd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122964
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-02  Mike Kaganski  <mike.kaganski@collabora.com>  [7b31f7428a1469fa823538fe5cf9cf36bbe2df68]

        Some corner case unit tests
        
        Change-Id: I43474265a9b3e1d07394c5f7e429e081d67f2eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122935
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-02  Mike Kaganski  <mike.kaganski@collabora.com>  [d830179a072072f3cc3ea5d942189647bcb7e1c7]

        tdf#144758: default value for 'table:orientation' attribute is 'row'
        
        See [OpenDocument-v1.3-part3] section 19.690.3 <table:database-range>.
        
        Regression after commit ed88b144ce24b9a733d4a9ab6614307c96537baa.
        
        Also fixes relevant part of unit test first introduced in commit
        6069ef7976c4455c1875afecf02c41c5731f6546, which was at that time
        testing that IsSortColumns property returned false; then in commit
        fc95d20500997a1a460be6f3553727299a5080eb, the correct value was
        changed to true, reflecting the regression fixed here.
        
        Change-Id: I6a12a0ad13405bc388efb7c2c3bbf31e89905620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122955
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-02  Luboš Luňák  <l.lunak@collabora.com>  [01807ad5e04966abeb396b7599cbbbf822de6a03]

        fix SwRect::Union() with empty SwRect
        
        Empty SwRect is technically located at (0,0), so make sure
        the position of the union is not moved to include that.
        
        Change-Id: I4905c11c3d9f989d4448704e3cb8b297e45bc569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122914
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-02  Luboš Luňák  <l.lunak@collabora.com>  [6702e8a93243c4807c80b53965a4397cdbfde8b5]

        add GetUnion/Intersection() to SwRect
        
        This is a more readable and efficient way of first constructing
        a copy SwRect and then using Union/Intersection() on it. Named
        Get* because that's how tools::Rectangle names them.
        
        Change-Id: Ib3033f1900c48792b23526771a941b4d4c1c07bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122913
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-02  Luboš Luňák  <l.lunak@collabora.com>  [48895bef52bd59e30751ece0c8a8d57ef7864936]

        make some simple SwRect functions inline
        
        They are not trivial, but having them inline should still give
        the compiler more chances to optimize these.
        
        Change-Id: Ia296282b64f64c801a057332047c12576d1d9604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122912
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [d7397d36b3c801681a802f4f2f16aec0c01a76db]

        tdf#141633 use OutputDevice::DrawText for multiline text too
        
        m_bFastPaint is only false for the multiline text, where it then tries
        to use a textview widget to render the text onto the OutputDevice while
        for simpleline text it just uses OutputDevice::DrawText.
        
        This isn't working particuarly well anymore for print output and
        DrawText can be used with flags of DrawTextFlags::Top |
        DrawTextFlags::MultiLine | DrawTextFlags::WordBreak to render text
        equivalently to the multiple line textview which seems a saner approach.
        
        Change-Id: I3c96f837aaeba82ebf5956ab2ba35210c978f255
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [7abf811bcbb92562a8da965d2ff03b9d53853e09]

        tdf#144846 launch gtk3 menubar menus from LibreOffice code
        
        rather than using the builtin gtk mechanism so we can avoid
        duplicate mnemonics in the sidebar getting used instead.
        
        Change-Id: I6c761ae63ae25d835de9444b0e298c63996a83a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Andras Timar  <andras.timar@collabora.com>  [0068583984c4ff7b33857cd5f351eb8a63e6a3e7]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 6176d3f2ce67c3f897f1507fe52680ad9d9fe7fc
          - add translations of pt_BR grammar checker dialog
            
            Change-Id: Ie091c2de7365ef4d980a06b017e8771e97feca82
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/122966
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [ea8e41710045a1e20f6cc1d210f3534c4f5fe9c9]

        Related: tdf#141633 use IsMultiLineEdit instead of !IsSimpleEdit
        
        seeing as the meaning of not simple is multi line editing instead
        of something more exotic like more complex formatted text
        
        Change-Id: Ic08834eed31b35ce16ba34bbbf8ff111d1a67da0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122952
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [56665a7265b0acce2c1c4908f07604ad77c3680f]

        tdf#141633 table control expects the textview widget to word-char wrap
        
        at some point in the future
        https://gitlab.gnome.org/GNOME/gtk/-/issues/2530
        becomes available to consider using
        
        Change-Id: I7221075093f3d1712f30a0e7454ed63ddbabae55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122931
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [96d078596c4621319b355b131b90fe1291e0445f]

        bundle key forward calls together as a function
        
        Change-Id: I9f3fe4ea0ac3bd0313d76a04eb3c44ce2192aede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [aefff80c531d1fe9747157a7068b3d58b6e0349f]

        add missing use-underline for labels
        
        Change-Id: I0fceeb6d3f7111dbbf5ee5bb68cb512b24923e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122924
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [0109c2d08306b25f632030fcd1a719466eea48ef]

        resave with latest glade
        
        Change-Id: Idcb357670a49b833950f475b483e590d166635b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122923
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [581efdec36787dc5e378e54d13e7328fddcf3a50]

        loplugin:constmethod
        
        Change-Id: I3ed657c5c5e6840e38e3c8505505b4b372125df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122910
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [e512b53ef8ae7945131876d32121fdbbdeb1de35]

        loplugin:constparams
        
        Change-Id: I0d1ad95a9944c9077a1b9db11f2ae05f993c2b36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122900
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-10-01  Ross Johnson  <ross.johnson@homemail.com.au>  [397eb9155a4b3399e78374fc8561de29b3d2cee6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b955ca1d2fa8132a22be12daeb416618277905c
          - tdf#123506 - focus search results to user's current module
            
            This change focuses the search results on the module the user initially
            called help from and in addition, in the same way that the initial index
            is presented, limits the results to that module plus GLOBAL results.
            
            Explanation:
            Currently, when a user arrives at a help page from a module they begin
            with a blank search term and by default the index is focused on the module
            they came from.
            
            As they enter a search term the results from ALL modules are presented,
            paginated and either, (7.3 current) grouped by modules but in a fixed
            order of modules that often pushes results relative to the user's
            module off the first page of the index or, (7.2 and earlier)
            pseudo randomly with incorrect grouping under modules.
            
            If a user wishes to explor other module results they can choose a module
            from the Modules drop down. Their search term remains and they can
            easily search again.
            
            Change-Id: Ib10dd55d1c68a839938842fe3607a7a7619b3538
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122903
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-10-01  Justin Luth  <justin_luth@sil.org>  [57f8b90d46756c22f01961260241fd2ab4bc64c5]

        tdf#127543 add saveacopy to Save dropdown menu
        
        Why not? It usually doesn't exist in a nearby shortcut.
        
        Change-Id: I3f9f0070c05bb1ce05795cabe8db0f95593ab5cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122606
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [de80116e81a5b73215098cd0aa60ac9226905ae5]

        Simplify the code a bit to clarify the logic
        
        Change-Id: I80201148684f6e297ff0c880c0dbbc346129a557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122864
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [ff842adedb6621ff338defab3c9c4c1022ca8bdf]

        Add unit test to catch eae24a9488814e77254d175c11fc4a138c1dbd30
        
        Change-Id: I18b98f4be3212199004a1bb8fd8725fe71254ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122870
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [0471dccf9c81b4851078033d286a215954c488ed]

        Calculate buffer size correctly
        
        A mistake in eae24a9488814e77254d175c11fc4a138c1dbd30
        
        Change-Id: I0da64366e4c39b3f5559e8a1c757a94d811f041f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122869
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b7a425d48cb282e20059e78ad5216da833dec803]

        tdf#142578: xlsx export: use continuous numbering for dfx nodes
        
        Since all dxf records are stored in one place it is required
        from color filter and conditional formatting to use continuous
        numbering for dxf structures to avoid id collision.
        
        Change-Id: I91146e34d462d812b480db137cda522f6db7ef8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122915
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-01  Andras Timar  <andras.timar@collabora.com>  [2ef26ab194b0e01edd81235e86b54da534c4555c]

        mark this string explicitely untranslatable
        
        it will be localized with STR_BOOKMARK_FORBIDDENCHARS
        
        Change-Id: I31416d53987ac1ec174add3b7114b18f5d38d1f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122908
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-10-01  Tibor Nagy  <nagy.tibor2@nisz.hu>  [83d92437e05a9ec872d9303953fa408dd4dcbcde]

        tdf#144616 PPTX import: fix hyperlinks on shapes
        
        Follow-up to commit 6e200689eb309cdbe1e4f08311a400835de19bfb
        "tdf#141704 PPTX import: fix hyperlinks on images"
        
        Change-Id: Ie9f1ba56d03462bb8d7ab376e23c89c921a8bcd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122610
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [097257d5e5ccf5026db42b8bb459dc78390dc9e5]

        Resolves: tdf#140992 Paste/Cut should mark Edit as modified
        
        Change-Id: Id56b5bf2e922394da7e730f4bab652808253c54e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [6b6fde50ab6069f8f82b4666e6ac1f50db5fcf1d]

        Consider leading minus
        
        An overlook from commit be8da97976658ff19b4dd010bff328cd3f424c1b
        
        Change-Id: I2f639a9d865b43b38e19ad35a0a9e6b5bc1c1c8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122863
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Caolán McNamara  <caolanm@redhat.com>  [afb95717c2c17d6f6c54abf0a0719d082d00e7f5]

        else branch doesn't make sense, dereferences null
        
        if xModel.is() is false then xModel->getCurrentController() is just going to
        crash.
        
        like this since it was introduced in
        
        commit eafba820349005ea5426cab58911f9ff99969966
        Date:   Tue Jan 5 22:32:38 2010 +0100
        
            autorecovery: define a new css.document.XDocumentRecovery interface, implement it in both SFX and DBACCESS, and use it in the autorecovery
        
        Change-Id: I8ea43a0679d43cb9b865ecae5260129d17b6a386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-10-01  Steve Fanning  <stevemfanning@yahoo.co.uk>  [49b14589e04cd6f3970b2f9c81ff574aa702bf76]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b81bdbf9511ce46f4556582c0b971e35c509d468
          - In CONVERT_OOO help description, add pointer to CONVERT function.
            
            Change-Id: I662c6c4dcaaa622b4e9dec1b575cd488300585a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122866
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d7bd370e7ec71ae8e511c21aa1a2bb51b6c208a3]

        Use std::memmove instead of loop
        
        Change-Id: Ia88ceaaad700bf3c2c8db9bb19146b75146dad3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122861
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [6f908b48373b71d45c8119b296b0504fb586f6f8]

        tdf#143104 Fix xlsx import/export of color filter colors
        
        1. In XLSX filter colors are always stored in dxf as foreground
        colors, so Calc should keep them, if possible. So practically
        use only one color during import.
        
        3. On export we need to distinguish type of filter, this is done
        with cellColor=0 or cellColor=1 attribute of <colorFilter>.
        
        4. Since p.1 there is no need to keep on export separate dxf
        structures for fg and bg colors: we always use only foreground
        color for color filters.
        
        Co-authored-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        
        Change-Id: Iacd352ae46bf84859dc15ee695b6dc63240afe7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122593
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [7a8f7f802a342c2bc301f5d313001829a07a7c92]

        Drop static_cast syntactic noise
        
        Change-Id: I699f22aac871fdcef9ee9326ac30091239fa02be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122862
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Mike Kaganski  <mike.kaganski@collabora.com>  [eae24a9488814e77254d175c11fc4a138c1dbd30]

        Always use buffer on stack
        
        Change-Id: I39ed2485a67ec7a8b24ab90ea0d69a5982374334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122860
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-10-01  Ross Johnson  <ross.johnson@homemail.com.au>  [ab8a67e8f77269d6cdaffa67335ae21c0a3dc942]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0b9b6542a8432d8a7bb3fc8185c0937dff0329bd
          - tdf#33749 - revised help text for merge and split in Calc
            
            The earlier change (reverted) overlooked the difference between
            "Merge Cells" and "Merge and Center Cells", leaving users without
            adequate means to merge cells while retaining text alignment. This
            patch restores previous usability and moves forward to resolve the
            issues raised in this bug report.
            
            Reverted the two changes from earlier work on tdf#33749:
            1) Cell context menu back to 7.2
            2) Format - Merge Cells menu back to 7.2
            3) Help pages to reflect that
            
            Moving forward with the following changes:
            1) Rename "Split Cells" to "Unmerge Cells" (Calc only)
            2) Add "Merge Cells" and "Unmerge Cells" to the Formatting toolbar alongside
               "Merge and Center Cells".
            3) Re-label the Format - Merge Cells menu to Format - Merge and Unmerge Cells.
            4) Help pages to reflect core including fixing the duplicate entry in the
               built help/hid2file.js by consolidating the relevant Calc and Writer
               help pages together to remove the duplicate bookmark hid branch value.
               Removed the module specific version.
            5) Removed duplicate entry from helpers/unocmds.txt.
            
            Change-Id: Ica50f507eea74acd430bef3042fb9739d1cff7b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122810
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-10-01  Miklos Vajna  <vmiklos@collabora.com>  [03edb42acfceb93016decfd3adb1c9350796eac8]

        sw: simplify DocxAttributeOutput::CharBorder()
        
        pInherited is already nullptr at that point, so need to only change it
        when pPoolItem is not nullptr.
        
        Addresses
        <https://gerrit.libreoffice.org/c/core/+/122790/2#message-054924f056e40364c82cc92987cb7ca7d981c564>.
        
        Change-Id: I456d4efba5b1d621c1b31bb2a2ec834c04cc62ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122901
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-10-01  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [8da3586cff9cc11cf5db985d19851f21f0d42eb8]

        tdf#141220 sw: fix textbox popped out of off-page shape
        
        When you moved it downwards off the page it was anchored to,
        the textbox inside a shape used to appear exactly one page above
        the shape it was supposed to follow. This is hopefully fixed by
        the present commit.
        
        Regression from c9eb53f200225f2ee6ca695e1326843a487aee51
        (tdf#135198 sw editing: text box fell out of its shape).
        
        Change-Id: Ib388292ca26444daa1900417347824059ee03f07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122687
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
        Tested-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-10-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [732b3fd5bdf17f09b5f9304b470b741e5483eab1]

        tdf#144437: rtf export: bookmark position is written to current run
        
        Bookmark was written to not current position thus did appear not at
        desired place inside paragraph.
        
        Change-Id: I917f74c95666efd38c5befeb927b75783915b2e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122722
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-10-01  Heiko Tietze  <tietze.heiko@gmail.com>  [5836cd37b6d292b1b4e72d5a5a6dc9029c5cf730]

        Resolves tdf#144677 - Show bookmarks like fields
        
        Color and condition follow field shading now
        
        Change-Id: I810c90fee2663b1148c139b6e7978ba161fd37b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122829
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-10-01  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [bf4cb13c7b3b57980d8e052c1b06afc3f21b96f2]

        sc: colorfilter dangling pointer fixed
        
        Upper call to aParam.RemoveAllEntriesByField can invalidate
        pEntry, making further calls to pEntry->SetQueryBy* illegal.
        
        Anyway at this branch we are disabling color filter, so this
        is not required.
        
        Change-Id: Ia595649975b659d28056ba3f3658c306e63088f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122822
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-10-01  Stephan Bergmann  <sbergman@redhat.com>  [955ccb669c60cc29918c784d9c801ab1ac54fc22]

        loplugin:nullptr (clang-cl)
        
        Change-Id: I47ac4ff7d82eb5732ad54e3b42c18c3665c83b82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122845
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-10-01  Jim Raykowski  <raykowj@gmail.com>  [9a3d2258420c4c1cc322b4f1317317dcd7c0b1a1]

        Writer Navigator: Make fields always show in the content tree
        
        Currently, a field that is not visible, for example, when in folded
        outline content or a hidden section, is not shown under the Fields
        category. This patch changes the behavior to always show the field.
        
        Change-Id: Iea85a2c69df68bb0d37e8d94662d3ca9c81b0e41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122842
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2de581d1943df2d84f2b71817b6a8bee41f0217]

        no need to allocate ImplVectMap on the heap
        
        Change-Id: If4175ee8f0853b9ef1bb0657338116e2ee57064a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122897
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7183b3ba237dc7718501acb512d5ae1c5d0d5f6b]

        loplugin:constmethod handle more cases
        
        remove some of the naming limitations, and handle pointer parameters
        better.
        
        I only let the plugin run up till vcl/
        
        Change-Id: Ice916e0157031ab531c47f10778f406b07966251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-30  Caolán McNamara  <caolanm@redhat.com>  [b1f085d66c1d354485edec527fda6abf539af325]

        Related: tdf#141633 drawing buttons to outputdevice affects later drawing
        
        since...
        
        commit 0b76e106b8054c91a7b7d793d9219f6ee9ae7d2c
        Author: Oliver Bolte <obo@openoffice.org>
        Date:   Thu Sep 4 06:42:10 2003 +0000
        
            INTEGRATION: CWS mt801 (1.21.132); FILE MERGED
            2003/08/29 14:35:52 mt 1.21.132.1: #80064# Print button with color...
        
        In the "sample db" example (Mockup.odb) there are two buttons with a
        yellow background, when printed part of the table control is also
        incorrectly painted with a yellow background.
        
        Change-Id: I481b721801b5e1d1c78dc7a01cb20745702f5c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [f3371e92d73b86246c23534dd3731feb251e699f]

        -Werror,-Wshadow (clang-cl)
        
        Change-Id: I4bd8427dcd4cd68053fe4e607c4ba05be215ffb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [553dd28e2524603e87d65e62a819f554a9029e38]

        Extended loplugin:referencecasting/redundantcast (clang-cl): winaccessibility
        
        Change-Id: I6de94437ed00b295be1c388ac4a2c0784dd3cc6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122883
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [fd1a63089332153e7180f16961d39c9c12654ff4]

        tdf#144697: svl_qa_cppunit: Add unittest
        
        Change-Id: I7a62f7c5c8e6fceebcb9671fa28ec98dd7a312a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122878
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-30  Caolán McNamara  <caolanm@redhat.com>  [36d5e26549b273118cea8969c43ef5ad3845f8df]

        tdf#141633 multiple line entry font size/zoom not taking effect
        
        The "sample db" example (Mockup.odb) has multiline entries used in its
        "Journal Entry" column. Those are painted by taking snapshots of a
        never-really-shown textview widget.  But the textview is always drawn
        using its original default font size and changing the page zoom and/or
        font size had no effect on the size of text in the "Journal Entry"
        column.
        
        explicitly emit style_updated to get the GtkTextView to sync its font
        size from the css changed by the set_font
        
        Change-Id: Ic7d644b13c28f30a2c646b9d4098ea6e7f0dab81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [6f84a89afdb125551ac71c9ed68085588e934b05]

        vcl: initialize variables in ImplMapRes declaration
        
        Change-Id: I379a555c8e148ba0294198fb5e12582f73a51554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122771
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [89732e5bbf659694c63a2eb16019a23c7a64ba64]

        Extended loplugin:referencecasting/redundantcast (clang-cl): embeddedobj
        
        Change-Id: I345b6535df2df4770191dc1aae0ca024b747a50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122887
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Olivier Hallot  <olivier.hallot@libreoffice.org>  [75e2e19add9391533904723c55dacf60eb609425]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2d9ad5a39e416c967af625426572b68498d3c68b
          - tdf#144713 rename tab indices -> tab order in group controls
            
            Change-Id: I0e4bf13841b104b6f7f0765a933f4ba13fbdd3c1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122679
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [c047e3f98f28d1cedd0ec1c7aa4a64da68cbf2c1]

        Missing include for intptr_t
        
        ...at least when building with clang-cl against recent MSVC 2019 standard
        library:
        
        > external/clew/source/include\clew/clew.h(319,9): error: unknown type name 'intptr_t'
        > typedef intptr_t            cl_context_properties;
        >         ^
        
        Change-Id: Ib438b680964028461ac3e566410fc90259d015b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122888
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [a247d574fa32770b19875e8ca967a32a32ef0f36]

        Extended loplugin:referencecasting/redundantcast (clang-cl): extensions
        
        Change-Id: Ifd431845dc9bb53b87be400a3f5635c8fdc4b2fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [41c675fa5984659907c51abc6408ed7f9f91172c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 692cf2deaf301a4fb1bce976a9f16e28c5f3c895
          - Fix auto_redact help page for l10n
            
            Change-Id: I45a698daf4744ecffbd7178d40edb8bd70a76bbe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122852
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [4e60d1a4c94332745662cc9154e6711c0d0453dc]

        Extended loplugin:referencecasting/redundantcast (clang-cl): embedserv
        
        Change-Id: I342859fbeaffee5d396cbb6ae3e5db41f5cdbb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122886
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [bf59a45b043b4bcea276bd862f3c6e5c3175e1e9]

        Extended loplugin:referencecasting/redundantcast (clang-cl): shell
        
        Change-Id: Iee72782ca3f9e536b391cc45d910792f66ce01a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122884
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [631b3887ab417678cc993ef68c0fd7f86ac56c86]

        -Werror,-Wformat (clang-cl)
        
        > sal/cppunittester/cppunittester.cxx(553,115): error: format specifies type 'unsigned int' but the argument has type 'ULONG64' (aka 'unsigned long long') [-Werror,-Wformat]
        >             printf("\tat %s in %s: line: %lu: address: 0x%0X\n", pSymbol->Name, line->FileName, line->LineNumber, pSymbol->Address);
        >                                                          ~~~                                                      ^~~~~~~~~~~~~~~~
        >                                                          %0llX
        > sal/cppunittester/cppunittester.cxx(558,64): error: format specifies type 'unsigned int' but the argument has type 'ULONG64' (aka 'unsigned long long') [-Werror,-Wformat]
        >             printf("\tat %s, address 0x%0X.\n", pSymbol->Name, pSymbol->Address);
        >                                        ~~~                     ^~~~~~~~~~~~~~~~
        >                                        %0llX
        > sal/cppunittester/cppunittester.cxx(576,50): error: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Werror,-Wformat]
        >     printf("*** Exception 0x%x occurred ***\n\n",ex->ExceptionRecord->ExceptionCode);
        >                             ~~                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >                             %lx
        
        ...but where SYMBOL_INFO::Address is documented to be of type ULONG64, which in
        turn is documented to be a typedef for unsigned __int64, for which there
        is the MSVC-extension I64 format specifier
        
        Change-Id: Ibed1d3fa49ac6fd988174c6041071292fc66dd3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122872
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8148a46c7878158c4b701e2a5c374129e6ffdffc]

        no need to copy the name in XmlWalker::attribute
        
        sName and the parameter we pass to xmlGetProp are both null-terminated
        char strings
        
        Change-Id: Ia8cb036f33cada8fa59d1e4f05df318a9cf28115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122875
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-30  Miklos Vajna  <vmiklos@collabora.com>  [3d32baa4df8d4061efcd5c5aa0a381e9a75240fa]

        cui: better label for the OLE insert progressbar
        
        It's inserting an OLE object, not really loading a document.
        
        Change-Id: Ie33e5ef8e80acbd2bfebd68119540c6d168ab120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122877
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [e6eda8476e5df9f4c88615c6075e1635c752daf7]

        loplugin:consttobool (clang-cl)
        
        Change-Id: I8947750dbcc0cfdfd04fac3b9e22d85dc6f8da80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122873
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [348cb77fddd30944445e0c8eb4f005743b2b7542]

        loplugin:sallogareas (clang-cl)
        
        Change-Id: I6a529d2eb737d284bf1e9c1857680c33581f5e0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122846
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [471a0e328cf66f8a288ef0306decf557362c13af]

        loplugin:external (clang-cl)
        
        Change-Id: I71be097d5051d39295f9f85d3e2329564388b4c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [486e694ba3b029e32eb6647f70dd03298de50f50]

        loplugin:cstylecast (clang-cl)
        
        Change-Id: I2c68832a23d80dbe208212ce36b14b21b5312f5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122850
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [cbe233766dc4cb028446aa599609b1a7d594785e]

        loplugin:unusedcapturedefault (clang-cl)
        
        Change-Id: Ib7b3bfb7a3162e032cf6c9bf7f19576434592a00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122849
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8294268307d98d3ea04f18a2ed89212cec516845]

        tdf#143575, tdf#143974 - Remove custom precision format in BASIC
        
        Change-Id: Iefe046fa223f85204b27ebabe81523aa1a97f92f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122856
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b8e53f66ffd4d631a850fe76250124dc4a195c3]

        loplugin:constparams improve handling of pointer params
        
        Change-Id: I4c0002e72703eded435bfe4985f5b0121bf8524b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [d242a19dbdd53b7ae0b6a6ceacca6aa1b6ac54a9]

        loplugin:includeform (clang-cl)
        
        Change-Id: Ia374fe0a7a0392e91821fecd1e6ee5917864d59c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122848
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Stephan Bergmann  <sbergman@redhat.com>  [8ab6e84bf610608ccaca1546ef279179dc68477b]

        loplugin:fakebool (clang-cl)
        
        Change-Id: I48ee1c1906ab06a487059128eb1eba0d6adb068f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122847
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-30  Mike Kaganski  <mike.kaganski@collabora.com>  [0b81761c86786eeb035f857f549d75f143e491ad]

        Simplify comparisons in the loop
        
        Change-Id: I9963a527d2323f4df8c3b46c13f5b7993e22f163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122855
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-30  Caolán McNamara  <caolanm@redhat.com>  [4d445ac9aa43b3399a579e3dbb1aac94507c9520]

        Related: tdf#141633 support setting a custom font for TextView
        
        Change-Id: I4c27a21c5c682fc73c37594749627e4cc7c0822d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122833
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-30  Caolán McNamara  <caolanm@redhat.com>  [61050c6d7b8bceef2704eba0bfe4473ee75e669d]

        tdf#141633 set correct font sizes in tableview child widgets
        
        Change-Id: Ic96a0ad8203bf3903546c0c2f07d96254ca01e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [52a07baebf7d1bfeda7a74dd0eac22b9e349fb56]

        vcl: remove MetaActionType param from DrawBitmap/DrawBitmapEx/DrawMask
        
        This is needed to allow for a clean abstract class DrawingInterface,
        which I will introduce in a followup patch.
        
        Change-Id: I1bb631872e44a82094dcfff07c0f418e9a4a0224
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122614
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-30  Mike Kaganski  <mike.kaganski@collabora.com>  [23e50bc96b3244975543f9d1ffbc3610f0ac7313]

        Add a test for a negative integer
        
        Change-Id: I368123ce4ffdfb0e5c47e80cf4fece0c6ddc5f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122854
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ed166025123a403fbd679377387a45e097f09d6e]

        tdf#143575, tdf#143974 - Use rtl::math::doubleToUString to convert numbers to strings
        
        Change-Id: I1427dbd49af680a1bf386410977c9cb2b0a3961e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122831
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-30  Miklos Vajna  <vmiklos@collabora.com>  [f9b6d5c58e1e8e3e2412ff94e30eb4a21b98b099]

        sw: remove useless debug code in SwTabCols::Insert()
        
        gdb or SAL_DEBUG() is a better tool to examine the elements of a vector.
        
        Change-Id: I6ff1d3eb7fcb44654a526eb3c5d09b7e06970566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122834
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-30  Mike Kaganski  <mike.kaganski@collabora.com>  [a4d865e4d82d44cd75f24c5385d44de8f4fcc62f]

        Avoid reversing the buffer
        
        Fill it in the correct order, starting from the middle
        
        Change-Id: Id35475e391d771d6c23252124a92825b24b55e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122853
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-30  Jim Raykowski  <raykowj@gmail.com>  [cdc1f41d4530ad3ec553d90dad803bc5b940656c]

        tdf#95378 Writer Navigator: Track bookmarks
        
        Resolves bookmark tracking part of the enhancement request.
        Makes the Navigator content tree highlight the corresponding
        bookmark item of the first bookmark at the currrent cursor position
        in the document if there is one.
        
        Change-Id: Ida9f512eda9630bd6f1e5db1658715823644969d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122619
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-30  Eike Rathke  <erack@redhat.com>  [ebc454ad4eb1f4cd4d84a7db367bb71a457c4e5c]

        Resolves: tdf#144697 Format out-of-bounds date(+time) as #FMT error
        
        i.e. < -32768-01-01 or > 32767-12-31
        They couldn't be input or stored as proleptic Gregorian in file
        formats anyway.
        
        Additionally in i18npool handle the absolute year values casting
        conversion int32 <-> int16 where era 0 BCE year 32768 is fielded as
        -32768 but still is a valid year for our proleptic Gregorian, so
        it isn't displayed as --32768.
        
        Change-Id: Ifdd482f07e04c2a4296fd0556bbef7f1d3e15676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122835
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [18e49d2b998ba69d5363d25d285ee6fd188a698d]

        expand out SwNodePtr typedef
        
        instead of having a mix of SwNode* and SwNodePtr
        
        Also change the call signature of FnForEach_SwNodes - passing around a
        const& to a pointer is both unnecessary and inefficient.
        
        Change-Id: Ib2caab53071f434e85f7dc4795cbde38609c28df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [e9500a04d6aa933692d53fc429b2544f00ecf561]

        Use SetControlFont to set the font size for these controls
        
        The Control level Font overwrites the OutputDevice level Font as far as
        I can see so this is the right way to make it stick.
        
        Change-Id: I9e1442826db8d31019b1038db44156d302d96880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [4e2306a5e336e2b43759c9712535626d0f2c168f]

        Related: tdf#141633 PointFont gets overwritten by ControlFont
        
        Change-Id: I26ffffe7917d109ddc61fd2d2646db0988937c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122827
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [8d131274e7aca598a89060cb0fbf7afb239b9034]

        Use std::reverse instead of swapping in a loop
        
        Change-Id: Iee8966eeeaea461e34b5d22b80cb612dfaa57fe4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122750
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-29  Mike Kaganski  <mike.kaganski@collabora.com>  [0bc7b206c8f6e62313ae2f26211b15cac880125f]

        Simplify integer rounding
        
        Change-Id: I09ab406a8b7279801ce79b2f9c0a0011f6db05be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122749
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-29  Miklos Vajna  <vmiklos@collabora.com>  [a92ce1ed68b3f6522db76e8caa7e69cf2f66fc22]

        embeddedobj: add a status indicator for the Further objects dialog
        
        Inserting a large file can take a while, and we do it on the main
        thread, so the UI is frozen during the operation.
        
        Create the progressbar in cui, which is allowed to link against sfx2/
        and then pass it down to embeddedobj/. Similarly for the label of the
        progressbar, again because cui is allowed to link against svx/.
        
        Change-Id: I53fec4e14df647b140647d9ff5a3a37c0aa9e72e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122825
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [e9564f1d727e89e8ab7c441a80a3944de10b3d3d]

        Resolves: tdf#144783 shift+RETURN not searching backwards
        
        In gtk nothing is happening, in gen its searching forwards.  Align
        backends so that Activate is emitted only on a bare return in both and
        then handle shift+RETURN explicitly for the search widget
        
        Change-Id: I142002bbaf6b3aca83800a442096a4b1024fe097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122814
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [99983c3c0b855a3449cf974224fae338b578dbd5]

        qt: Use actual major Qt version number in toolkit ID
        
        This makes the qt6 VCL plugin actually show up as such
        instead of "qt5" in "Help" -> "About LibreOffice".
        
        Change-Id: I33804dc779c7f2692be260353dda2edc86ea8544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122809
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [2db427f9e098439ef68ce309bd8b440160ff37a0]

        Resolves: tdf#73139 text defaulted to transparent in pdf export
        
        set an initial explicit default text color to resolve this
        
        Change-Id: I875ae68a23d1768216ddf77764011f34ca70969c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122813
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [88d57cf241209ffec9eaed3e523942ab51af6db6]

        qt6: Add a qt6 VCL plugin
        
        This adds a new "qt6" VCL plugin based on Qt 6.
        
        Building the plugin is enabled by autogen option '--enable-qt6'
        (and optionally setting 'QT6DIR' as needed).
        
        Use the 'SAL_USE_VCLPLUGIN=qt6' environment variable
        before running LO to select this VCL plugin.
        
        Taking qt6 into account at all relevant places certainly
        still requires follow-up changes, but
        this builds and runs with a self-compiled
        qtbase from the 'dev' git branch as of commit
        3ce0672143d2eb3c3809f82998a4d71c5800d77a.
        I didn't see anything obviously broken
        in a quick run, but didn't test much.
        
        This reuses and shares the qt5 VCL plugin code;
        the qt6 headers and sources for now just
        '#include' the qt5 ones.
        
        Version checks are used for the code places that
        need different handling to be built against Qt 6.
        
        The build system parts in this commit were mostly done by
        copying the qt5 equivalents, then adapting as needed.
        
        Some notes on things I came across while porting
        to qt6:
        
        1) At least in my self-compiled Qt versions,
        'moc' (the meta-object compiler) is located
        in the 'libexec' subdirectory in 'QT6DIR', while the
        Qt 5 equivalent is located in the "bin" subdirectory
        of 'QT5DIR', so the configure.ac check uses the former.
        
        2) moc does not process classes from the included headers.
        Since the headers in 'vcl/inc/qt6' just '#include' the ones
        from 'vcl/inc/qt5', running moc on the qt6 headers doesn't work,
        so moc is currently run on the qt5 headers for qt6 as well
        (s. 'vcl/CustomTarget_qt6_moc.mk').
        That will have to be adapted in case the qt6 VCL plugin
        uses "own" headers instead of just including the qt5 ones
        at some point.
        
        3) QX11Extras has been removed from Qt 6.
        [1] says:
        
        > Changes to Qt X11 Extras
        >
        > The QX11Info class has been removed.
        >
        > Clients that still rely on the functionality can include the private
        > header <QtGui/private/qtx11extras_p.h> as a stopgap solution. To enable
        > private headers use QT += core-private with qmake, or add a project
        > dependency to Qt::CorePrivate with CMake.
        
        I didn't take any closer look, just dropped the use of
        QtX11Extras for qt6 for now.
        
        4) XCB_ICCCM is no longer needed.
        It is only used in qt5 to workaround a Qt bug fixed in Qt 5.12, s.
        
            commit fe2baf9e84e0ca9aeaa683e37076f57fa3f38dca
            Author: Jan-Marek Glogowski <jan-marek.glogowski@extern.cib.de>
            Date:   Tue Dec 3 08:32:58 2019 +0100
        
                Qt5 fix missing XCB_ICCCM_WM_HINT_WINDOW_GROUP
        
        5) X11-specific code is still used for key modifier handling.
        Therefore, still check for the XCB headers when 'USING_X11'
        is set in configure.ac, and use a 'QT6_USING_X11' define
        (as qt5 uses 'QT5_USING_X11').
        
        6) There's currently no Qt 6 video sink for GStreamer.
        As of today, qt-gstreamer is unmaintained and there is no Qt 6 version.
        The project's README [2] says:
        
        > 0. Maintenance Notice
        > ---------------------
        >
        > This code is unmaintained. You can use it at your own risk.
        >
        > If you want to integrate video display in your QML-based UI,
        > you should consider using 'qmlglsink', from gst-plugins-good.
        > This is a well supported video sink that uses the generic
        > gstreamer-gl stack and is in many ways superior to 'qtquick2videosink'
        > that is provided by qt-gstreamer. You can use this code as an example:
        > https://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/tests/examples/qt/qmlsink
        >
        > If you are not interested in using QML in your UI, then you
        > may use one of the other elements provided by this module
        > (see below). If you do that, it would be helpful to let us
        > know that this code is still useful to you. We may consider
        > adding these elements in one of the core gstreamer modules.
        >
        > If you are here for the Qt-style bindings, I'm sorry to disappoint you.
        > The alternative is to use the C API, or the GStreamermm C++ API.
        > Qt-style bindings are cool, but unfortunately they are very hard
        > to maintain because they are written by hand. If you are interested
        > in continuing this project, you are welcome to implement a
        > generator for them, probably based on GObject-Introspection.
        > I am happy to provide directions if you want to pursue such a thing.
        
        Therefore, the Qt video sink handling is qt5-only and the
        corresponding handling for GOBJECT (used for the GStreamer
        video sink handling) was not taken over for qt6.
        
        This presumably means that video playback in Impress presentations
        does not work when using qt6 with they Qt Wayland plugin,
        s. tdf#125219 for the corresponding bug for qt5/kf5.
        (I did not build the qtwayland module to actually test this, though.
        Video playback with the Qt xcb plugin in a Wayland session works.)
        
        [1] https://doc-snapshots.qt.io/qt6-dev/extras-changes-qt6.html
        [2] https://cgit.freedesktop.org/gstreamer/qt-gstreamer/tree/README
        
        Change-Id: Ib105ccfb2c3630ec5d5403793a3cd9ba31d85bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122808
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [51d148c748d8e23b69ba91d3c1b5a9057bd22548]

        qt5: Drop "5" from VCLPLUG_QT5_{IMPLEMENTATION,PUBLIC} defines
        
        Rename those to no more include the Qt version number,
        since they will be used for the upcoming qt6 VCL plugin
        as well.
        
        Change-Id: I49bf362b830e07193dca03524e0d6001d0d191a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122807
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [b9cd02937b358ae035ed554a28037237a6c8434c]

        qt5: Rename sources + headers according to new class names
        
        This renames the source and header files according to the
        new class names without a "5" in them, as mentioned in
        Change-Id: Idf422f82ca9dafbb70e9a64de9c8cfc4cc8c0909
        (qt5: Remove "5" from class names in qt5 VCL plugin):
        
        > Renaming the headers and source files will be done
        > in a separate commit to make tracking git history easier.
        
        Change-Id: If955e77c8ba508d0a2e01e3a9df1be6dc04c4e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122806
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [dfd3fdfe664e214ca1bba72b96d19b89ff25e7bc]

        qt5: Remove "5" from class names in qt5 VCL plugin
        
        Rename classes for the qt5 VCL plugin to no longer
        contain the Qt version number "5" in them, e.g.
        "Qt5Widget" -> "QtWidget".
        
        Also, adapt some variable names and comments
        accordingly.
        
        The code will be used for an upcoming qt6 VCL plugin
        as well, so a "Qt" prefix fits better than a "Qt5"
        one.
        
        Renaming the headers and source files will be done
        in a separate commit to make tracking git history easier.
        
        Change-Id: Idf422f82ca9dafbb70e9a64de9c8cfc4cc8c0909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122805
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [894450d6ebbb2d5e063d72b971580d1b8c10a5e3]

        Unify how Qt/KF build flags/libs are set
        
        Unify the way that QT5_CFLAGS, QT5_LIBS, KF5_CFLAGS
        and KF5_LIBS are set.
        
        RepositoryExternal.mk has entries for "qt5" and "kf5",
        and thus using the "qt5" and "kf5" externals sets
        includes, cxxflags, defs and libs for gbuild as needed.
        
        Use this mechanism consistently in all Makefiles
        for qt5-/kf5-related libraries and executables
        and drop setting flags and libs "manually".
        
        (For several targets, like 'vcl/Library_vclplug_qt5',
        flags were set both ways, i.e. they were set twice).
        
        Change-Id: I246cffdb0bf40b7ba2d694f9b868c2b8e381aacc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122804
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Stephan Bergmann  <sbergman@redhat.com>  [63c22a7c309a866c4580c2bf028a0d2ece9ee1c0]

        "is missing" has gone missing
        
        ...in 4c1bf9d7790ca037933c3c6825d48736572a1886 "Make loplugin:bufferadd look
        through O[U]String::operator std::[u16]string_view" (thanks to Ming Hua for
        spotting it)
        
        Change-Id: I0fa18b0a5c824cb77988edda1ba8971d2ab86366
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122798
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-29  Roman Kuznetsov  <antilibreoffice@gmail.com>  [4ac099d45d545ff1a233575a183953ab73e50267]

        drop 'using namespace std' here
        
        Change-Id: I314dfe1cd31ad7bf2b8fcf64f94ae5f82d24ebbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122743
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-09-29  Michael Weghorn  <m.weghorn@posteo.de>  [8728f287cd490411edc419bf39511a87e98af565]

        qt5/kf5: Drop 'qt5/' prefix from includes
        
        'vcl/inc/qt5' is in the include path for the qt5 and kf5
        VCL plugins, so there's no need for this (and it's not
        used in the other places, either).
        
        Change-Id: I1de3afd4399869e318dba2e7786711e65ef83c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122803
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [057a74c2f20256c34e97dae246e6e1867a364b84]

        this scoping detracts from readability
        
        Change-Id: I99a51bf68ef1c98e4023413b9274c4361f8a9b96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [7d21e2bc4628138bf2617a5c672c0da8d4e9e96f]

        Related: tdf#144139 use the classic size calculation
        
        Change-Id: Iac3f9fb9fd6f92f8b17b1f2822dbc9743528cea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122799
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [c039ba3d68cb6668b672c299075417f65183c65a]

        ofz#39403 avoid Integer-overflow
        
        Change-Id: I3471e2fbd2b47dbc681aa3069794184eb9ab33e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [fbfd91f2c5f4d66570c2d5a6f048b21f5d1671a4]

        Resolves: tdf#144139 checkboxs in print output shouldn't be themed
        
        Change-Id: Ibbde5d64595d2fec1fa63756d628cf295dcdbb78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122783
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Caolán McNamara  <caolanm@redhat.com>  [02268b46bcd9535c250be058f295a1c0e8a62965]

        gtk4: fix build
        
        Change-Id: Ibc4f1d69104cc84279f222743e866381634f799f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122795
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-29  Noel Grandin  <noelgrandin@gmail.com>  [00f77b86df915e675f6b0e4aa5d762fda14d9c32]

        use SfxItemSetFixed in sd
        
        Change-Id: Ia28372dbb82fdaaa282756118e0eeb207cfd5146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122789
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-29  Hossein  <hossein@libreoffice.org>  [22483334bf897160494a7223992c5f4a301c82f8]

        Use ed25519 as default for ssh key pair generation
        
        Use ed25519 algorithms as the default key pair generation algorithm
        for the public key cryptography used by ssh in order to submit
        patches via 'logerrit' script. If ed25519 is not available, RSA is
        used.
        
        List of supported algorithms in OpenSSH can be obtained by invoking
        this command:
        
            ssh -Q key
        
        Change-Id: I12ebcbb62d0752c94b8c2d5225223ceb69b7fe79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122765
        Reviewed-by: guilhem <guilhem@libreoffice.org>
        Tested-by: Hossein <hossein@libreoffice.org>

2021-09-29  Miklos Vajna  <vmiklos@collabora.com>  [d4bd8b7b182ac0a015ab0ff69101f33376ce58ae]

        sw: use StaticWhichCast() in docxattributeoutput
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: I323b522b5b69ef2c36a6f0743f9010a8f8d05409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122790
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-29  Jim Raykowski  <raykowj@gmail.com>  [38eb9a0594393e263f57701702974a030d3327de]

        tdf#144335 SwNavigator: Table tracking option
        
        Adds a check button to the table context menu in the content tree to
        turn table tracking on or off.
        
        Change-Id: I787dc2f3e3b465d7f25a9e16b5f5491dc2d933d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122218
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [a69987dfd496413792d9bef5cb071615dd7ab375]

        fix deadlock on exit (attempt2)
        
        regression from
            commit 8122c82d90117fc0c4c8ea87aa7f771d5e92bf36
            osl::Mutex->std::mutex in SfxGlobalEvents_Imp
        
        Change-Id: Ia7416520a3538dcb77d7a4573045122581730264
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [36cec4b92e8be9f47467539967672ba8906096e1]

        tdf#144139 gen backend doesn't crash but DrawOutDev is a null op for Printers
        
        Change-Id: I90be3c3343890989eefce3d6a535ffa854d77698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122782
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Stephan Bergmann  <sbergman@redhat.com>  [4c1bf9d7790ca037933c3c6825d48736572a1886]

        Make loplugin:bufferadd look through O[U]String::operator std::[u16]string_view
        
        Change-Id: I79a32f64541a90b0b824f7721e8815c1e7c873ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122788
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [858c15cf215e511e2d636c16d374c88bca96d66c]

        Fix typos
        
        Change-Id: I05fdb2378f48b7e2c7373c16c66065111c5d2f73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122716
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-28  Miklos Vajna  <vmiklos@collabora.com>  [0713d278f5bf232bad819dd46dc19d34ed807b12]

        cui: add a status indicator for the OLE insert dialog
        
        Inserting a large file can take a while, and we do it on the main
        thread, so the UI is frozen during the operation.
        
        Create a statusbar and tell the user what's happening, even if the
        underlying CreateObjectFromFile() and OleSave() functions don't report
        their progress, so effectively this is more like a spinner than a
        progressbar.
        
        Change-Id: Ib5d90e214c556b43f170538fc152a9e27193773f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122781
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d72511eda923c827a6175bec9b8f24c237f82730]

        gives names to all the Idles and Tasks
        
        enforce it by making the constructor parameter non-default.
        
        Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Jean-Pierre Ledure  <jp@ledure.be>  [0bcc4b55d723f73b2fb7a86fcfebeca49905079e]

        ScriptForge - (SF_Platform) new Fonts property
        
        The Fonts property returns the list of available fonts
        as an unsorted array of unique font names
        
        The size of the array being potentially huge, the choice
        has been made to not sort the list at each invocation
        of the property.
        To get it sorted, use the SF_Array.Sort() method.
        
        The property is available both from Basic and Python scripts.
        It is read-only.
        
        Change-Id: I49233d279dc7257d3b97e5a17be0bc8807f18d67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122780
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-09-28  Eike Rathke  <erack@redhat.com>  [df37d83500f7fe94046afb8817d29bd4ee650635]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5a4f9fe6afa18531f7403df99e555ea04d96e9b6
          - Resolves: tdf#144770 MATCH() remove plain wrong statement about unsorted array
            
            In since the initial 2004 commit. Whatever idea that was, it's wrong.
            
            Change-Id: Ic54bed36b832d223e96d42efdee1a2f8067b6c41
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122784
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2021-09-28  Noel Grandin  <noel@peralex.com>  [73c56d8c7830b800aea23ecd083194d7b6ab8a03]

        no need to allocate this on the heap
        
        Change-Id: Ie4935dbf9e5a2a9e7906839b260706a12494b610
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Noel Grandin  <noel@peralex.com>  [8156a8f87996e353f8d36935e0497624245f1ad1]

         no need to allocate SwFont separately in SwAttrHandler
        
        Change-Id: I08ef59f48b1f986854c6d194fb856b2da73c2ccd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122775
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Noel Grandin  <noel@peralex.com>  [2d45cef3cd18c9d0198b9d302016a7598ce0484c]

        no need to allocate SvxTabStopItem separately in SwLineInfo
        
        Change-Id: Ia2cbf997427a2450a576436d7c0159b7bbe34578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122774
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Noel Grandin  <noel@peralex.com>  [b62153753a9f21afb2a49110ef0459e427b0b01a]

        tdf#135683 speedup SwAttrHandler
        
        we only care about the "highest priority" attribute, so we only
        need to store a single attribute, not a whole vector worth.
        
        Shaves 5% off the load time for me.
        
        Change-Id: Ib7dc800db47502b33c69df0fe473a82bd8d93af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122773
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [082394a8ff125a7a7a009f60a0002d1d4c2ca7fb]

        make this look less like it grew organically and more like it was planned
        
        Change-Id: I944ca80e93db04389fb6fe1f88ffc70d067b78b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122768
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [a0f6d3865dd113f38fd3aa673075e9fecd06f3cd]

        tdf#144139 don't crash when OutputDevice is a printer
        
        Change-Id: Ia3843966949b8164b01cecd762ea2b5c5bf0339b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122777
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [e5d086c31e6765430f8c366196fb4a2b0c25924d]

        tdf#144740: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: Ida3de565a736ad512e0fb7e1ef78545fefaba639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122761
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [95a16f0104a9e9722937d5b2c4db45388d7a58a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a89e385e842191c215e407541a96343fbb5dc97
          - tdf#144712 Database Advanced Settings: Help Inconsistent
            
            Update and fix order of the dialog settings
            Add missing settings entries in Help page
            
            Change-Id: Ia763d1e63f286fa819fb6eadc820e788e371e921
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122718
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [78485eb52d1f10a6ba0314370288f7e747e0ec53]

        fix deadlock on exit
        
        regression from
            commit 8122c82d90117fc0c4c8ea87aa7f771d5e92bf36
            osl::Mutex->std::mutex in SfxGlobalEvents_Imp
        
        Change-Id: Ifdde340a4cb6a84b5b396d04694e856f6bdd5c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [6552ec19d1920a0c4ab074b4a16afc0fe39296f3]

        add extra timeout with higher priority to LOK flushing
        
        The normal idle has TaskPriority::POST_PAINT, which means that
        if we get too busy, the idle won't be called for a long time,
        meaning the queue will get longer and longer, making its processing
        slower, and client interactivity will be very poor, with updates
        possibly coming only when everything becomes idle.
        
        The second timeout will flush the queue after a reasonable timeout.
        I don't think there's an optimal value, so let's choose 100ms for now.
        
        Change-Id: Ia1312a690aefd2c8628c82e0f42b2993802d8b1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122728
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [eed05aae4a308224ffde7e00d347830f80bbefef]

        com_sun_star_comp_svx_CharacterSpacingToolBoxControl is duplicated
        
        com_sun_star_comp_svx_CharacterSpacingToolBoxControl_get_implementation
        is already listed under svx/util/svx.component
        
        Change-Id: I55fd0e2aff051b62b33d5b257ced8e934c9053d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122770
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [9cd4845e50efb30c14407b139ef05a891dea1781]

        avoid repeated std::vector::erase() in SwRegionRects::Compress()
        
        Change-Id: I5e646d2938dda7077e5e4ff40ab6caa847ac7a80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122676
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [fbaa1c3377f445180db2f7811b9516895b357aa8]

        optimize out a bit of Invalidate() in LOK mode
        
        Change-Id: I3c076e2506c9cade7e6bb874a2cddfa1ef0db6a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122674
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [6eac17ddcb25765f395493526e75c979049c73e2]

        do not use std::find_if() if std::find() does the job
        
        Change-Id: I94fe697e18442c1bce5e09abf82e8fe4b89cd0dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122675
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [6a1aa5ba0be05258b6375433a071389811efd405]

        do not check a const variable in every lambda invocation
        
        If the variable is false, then every call to the lambda will be false
        as well, so the entire block may be skipped.
        
        Change-Id: I8b61133d246fcfa721145f9d28c55e9afdb06e5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122678
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Luboš Luňák  <l.lunak@collabora.com>  [6e060ba9e8c4f34b5ad12908e0c0b5f65c533869]

        optimize removing from the LOK flush queue
        
        All the lambdas check for event type, so it makes sense to first
        separately check the type and only then possibly call the lambda.
        Especially since 3b3e4ee97af23f21 separated the types for better
        searching.
        
        Change-Id: I144c88f5319ac2141336e1aa3c4ffd7b38265af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122673
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [c9a405b3bcc0d3f5fdb6b4386831a4d4b2897c74]

        tdf#144532 closing mail merge wizard preview removed document's data source
        
        Filter out the "EmbeddedDatabaseName" property from the document
        settings on saving document that will be loaded by the mail merge
        preview so that when the temp mailmerge preview document is closed it
        doesn't unregister the database of the same name which was registered by
        the document this is a copy of.
        
        This looks like a similar problem to tdf#118634 addressed by:
        commit edc62adae9a354ca1305e83b10c98a545f58d341
        Date:   Mon Jul 9 19:49:34 2018 +1000
        
            tdf#118634: Don't save embedded data source to a temporary preview document
        
        Change-Id: I3fecc2ace1c9e06354b145609f0130dbbb2c036b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122763
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [6e111548d9de8eacff79d614e4400719df792228]

        flatten this in advance of additional changes
        
        Change-Id: I2169a235be83558edb1c5146e3fc8848449f55c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122762
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [3476106890ea2a00e6f949c918f6c05e17c66a36]

        tdf#144754 WIN de-assert ReleaseFonts / setFont
        
        DeInitGraphics might already have reset the default HDC font,
        while the WinSalGraphics still has a font fallback stack. Not
        sure why this didn't trigger the existing assert before.
        Quite probably there was an existing lifecycle bug.
        
        Regression from commit 42f9d4335bfa4b7299224801fd7ccdd97ae92fbf
        ("WIN always (de-)init WinSalGraphics")
        
        Change-Id: Ie5826e632310a0d69e8f9617cf6f3629bc31f152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122726
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-28  Caolán McNamara  <caolanm@redhat.com>  [a52de700a0092ac547f3cbdc3c14e77b6da37955]

        ofz: Integer-overflow in lcl_CalDate
        
        FWIW we have another similar implementation of this as
        Calendar_hijri::getGregorianDay
        
        Change-Id: I785f739d8f69ed0e596c27411cc8c7c58c631866
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122757
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-28  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [6f04952e6828cf1419b991e82070514bae24896c]

        tdf#144184 sc: fix first page footer export
        
        Due to a typical case of copy-paste oversight LO Calc used to lose
        the first page footer when exporting to ODS. With the typo fixed,
        the export now works again.
        
        Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388
        "tdf#121715 XLSX: support custom first page header/footer".
        
        Change-Id: If8f5ab4ff9a9392768789b886218d1d9c56ddbae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122455
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-28  Heiko Tietze  <tietze.heiko@gmail.com>  [ac34bafb6cad056f843ff3ff0dee293bf1e18c56]

        Resolves tdf#144735 - Access to formula edit bar via context menu
        
        * Command added to context menu
        * Label modified for more user-centered clarity
        
        Change-Id: I3da5805d881e05452c79d4f44c25d69fb4c804c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122752
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-28  Tor Lillqvist  <tml@iki.fi>  [e37c97bc1d698c94ed6736dbe4642a784e79eeff]

        Warn harder about unknown constructors and factories on iOS in Xcode
        
        Use NSLog() and not just SAL_WARN(). There are so many irrelevant
        SAL_WARN() warnings displayed that these ones that can be extremely
        relevant are easily missed. I typically run the app in Xcode with
        SAL_LOG=-WARN.
        
        (Such warnings are typically caused by something missing from the
        solenv/bin/native-code.py.)
        
        Change-Id: I4ab16f4f652ac34319021c9427e2e9f911ee29e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122721
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122756
        Tested-by: Jenkins

2021-09-28  Tor Lillqvist  <tml@iki.fi>  [10e809e1393d65f8864b6b7a5176f0b60cc1ec8c]

        More constructors needed for the DISABLE_DYNLOADING case
        
        Fixes https://github.com/CollaboraOnline/online/issues/3293.
        
        Change-Id: I3c0eaedf47321f0e81be4ac52c66f8e55381ac32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122720
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122755

2021-09-28  Roman Kuznetsov  <antilibreoffice@gmail.com>  [aeb056fb2feab4dfc5a5c4928b54fa21756d824b]

        drop 'using namespace std' here
        
        Change-Id: Ifbbd6e985fb66893dc872522ed5418453ca8e2d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122651
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-09-28  Miklos Vajna  <vmiklos@collabora.com>  [05f863844d9a5613250e8d787e32752b270ec4d3]

        sw: paragraph styles: add ODT filter for a linked character style
        
        And the same in the other direction: link a para style from a char
        style.
        
        With this, the ODT filter is on par with the DOCX one for this feature.
        
        Change-Id: Idd994b933672ab47a5f87a75c92abc137d3c73b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122753
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [4dd6af856d574ad66ebb4b822a36ba70af9945e2]

        vcl: rename OutDevState to Stack
        
        I have moved the header file to include/vcl/rendercontext as this will
        eventually be part of the RenderContext split from OutputDevice.
        
        State and associated enums have also been moved to the vcl namespace. I
        have also moved ComplexTextLayoutFlags into the vcl::text namespace.
        
        Change-Id: I0abbf560e75b45a272854b267e948c240cd69091
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121524
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-28  Miklos Vajna  <vmiklos@collabora.com>  [1734e97222324c137ecd084ad2464abdff2698d1]

        tdf#143819 sw: fix undo not restoring adjusted anchor
        
        Regression from commit 0a4d77f35e96e4dfdf69cc5ceb788ddaa849084c
        (SwTxtNode::Update: don't move anchors at insert position, 2014-10-06),
        the problem is that in case backspace adjusts the anchor point of a fly
        and undo does an insert (which now doesn't adjust the anchor point),
        then the user action and its undo is not in sync.
        
        Fix this by informing SwTextNode::Update() if an undo is in progress and
        doing the old behavior in that case.
        
        Change-Id: I0b3f3954be11420846f84287e486b993b2dc39e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122727
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-28  Mike Kaganski  <mike.kaganski@collabora.com>  [e753de4630fb74ac837d0339be23a305f18d0725]

        tdf#144732: treat invalid subtype value as worksheet
        
        Commit 9bdb1d2473510067da1ac74013595b661ac37800 for
        i51490 had introduced the same change for Bof2, Bof3, Bof4.
        
        Change-Id: I478a8611874d70fad0c83700efed5ea882d5f69f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122650
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-28  Eike Rathke  <erack@redhat.com>  [b60b6bfaafa1315e07108dba50f016975b619c59]

        Resolves: tdf#144740 Fix broken compareByValue() query, tdf#142910 tdf#144253
        
        Fix regression of a series of commits that, intended for filter
        queries, unconditionally round numeric values as shown under
        ScTable::ValidQuery() and compareByValue() without having taken
        into account that the same query and compare functions are used by
        the interpreter for all functions that use query criteria,
        possibly delivering completely wrong results including in
        backports to 7.2.0.0
        
            commit f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d
            CommitDate: Wed Jul 7 17:44:46 2021 +0200
        
                tdf#142910 sc filter: fix "greater than" or "smaller than" etc
        
            commit 51375b48378915b6e95c1ac26b2ccf8e39880f7e
            CommitDate: Tue Sep 21 11:06:35 2021 +0200
        
                tdf#144253 tdf#144324 sc filter: use formatted values in filters
        
        Several related and intertwined commits in filter context make
        assumptions about these queries always being executed rounded, so
        the only clean solution is to make that depend on the
        ScQueryEntry::Item being passed. Its mbRoundForFilter value is set
        to true for all items of all queries executed via ScTable::Query()
        and ScTable::GetFilteredFilterEntries(). It might be not all are
        necessary (or some even still harmful?) and unnecessarily
        obtaining number formats and calling RoundValueAsShown() is still
        a bottle neck for those, but that should be addressed and reworked
        independently. The important part is calculations work as before.
        
        Also, moved obtaining number formats for calling RoundValueAsShown()
        into logic that calls them only if necessary.
        
        Note the TODO in compareByValue() about suspicious rounding of
        rItem.mfVal in filter context that is to be addressed.
        
        Change-Id: Ieb178ad1ea15a635caeb1ba698c2f4b7ad676d57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122729
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [540ae5590f775a04168453f8c61a839303f598ef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4e6211e98f0f4000477ecee0783522603b3caad8
          - tdf#54854 Using Calc Functions in macros
            
            Add examples:
            
            * Assign internal Calc function to cell formulas
            * Assignd Add-In function to cell formulas.
            
            Change-Id: Ide07357a2407a4f647950c0250522d17e42e563d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122654
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-28  Jim Raykowski  <raykowj@gmail.com>  [d57ecadbbbced5ecebe6ede0ef8034d3dc3adae7]

        Outline folding: Check saved outline frame is valid
        
        Fixes crash when saved outline frame is no longer an outline node
        frame. This happens when the mouse pointer is on an outline node text
        frame and the outline paragraph gets merged with another paragraph.
        
        Change-Id: I30902bb51c938844e64169a04a62a79793ac2181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122669
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eafd23005fb5c3c30701a5f26287541ee3783ccc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 202fe13967c738a3cf6384343e62c564e6c5b158
          - Mute l10n in some strings
            
            Change-Id: I5338d523362eb8d50bdf633793a9d3d5d59999f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122446
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [2f51bf35daa7d2e1612647e1768c443028e87c39]

        vcl: move FontSelectPattern to own file and into vcl::font namespace
        
        Change-Id: I2f01a8e67c52ece9b434777203aa9fbc9ac8be02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122613
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-09-27  Hossein  <hossein@libreoffice.org>  [5e4e1cdb1e14354b42838e1dfcf82873b3071896]

        tdf#88163 Fix font size for placeable wmf files
        
        The problems in tdf#88163 can be categorized into two parts, as
        described in d25906087918c085239aac30fd72cb65aa7b9eb4:
        
        First, the problem with the wmf files without the placeable header.
        Second, the problem with the wmf files with the placeable header.
        
        The above mentioned patch fixed the first part, and this patch fixes
        the second part.
        
        The problem was that upon seeing 22-byte placeable header, the
        records related to the size of the wmf like META_SETWINDOWORG (0x20b)
        and META_SETWINDOWEXT (0x20c) and others were ignored. These records
        were read in WmfReader::GetPlaceableBound() for the wmf files without
        placeable header. Adding this method for the wmf files with placeable
        header fixed the wrong calculation of bounds, which previously lead
        to wrong size of text.
        
        It should be noted that the scale in the placeable header is used,
        but the bounds are ignored for now.
        
        A new test named testTdf88163PlaceableWmf() is added that can be
        checked with:
        
            make CPPUNIT_TEST_NAME="testTdf88163PlaceableWmf" -sr \
                CppunitTest_emfio_wmf
        
        Change-Id: I820c2e5922972cb5d555d98ef70c7581cd9f02d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122095
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [fc5856263439846c9e692e1ccaddf3312530b1a2]

        lock the combobox + spinbutton group width to its original all-shown width
        
        so the notebook page contents don't jump around when the spinbox is
        hidden/shown
        
        Change-Id: Ib6ad47644b55d857dae972340444d7bac67278e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122724
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [c156fc0b844d6d7e31dc5b6a5e12ef71d8f631c8]

        border page combobox defaults to taking up a lot of space
        
        Change-Id: I29d7debcd39a23b224c8c4660a7edf2f1e9e4a90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122723
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [1010c16c5f4c582adfa9d24036e9f98137e5ede7]

        ofz#39374: avoid infinite loop
        
        Change-Id: I0aec664279dea99df865761f34f64aa4fa3d9e0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122725
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [10c8bd1ed8fbc4cf387803fcb9b70dcfe776b4ab]

        Update git submodules
        
        * Update translations from branch 'master'
          to 0cb98568b1070b0178a398e2befd36808364e37e
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: Ib11aec7e448b083f697b9705d29795cd2e5a55f0
            
          - update translations for master
            
            and foce-fix errors using pocheck
            
            Change-Id: I12d26e666d46993fd4ff26616c09be9e5bf82fcd
            
2021-09-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1d27e06d9c1222fc7ef3d058cd78e6102aceaf47]

        tdf#144712 Add extended tips to special database settings dialog
        
        Change-Id: I897353be6b42d8d867e7cc6036b0e8555172b80e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122719
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-09-27  Mike Kaganski  <mike.kaganski@collabora.com>  [f1f4cecd269f530b08dfa445cb055e762d6c76e8]

        Drop 'using namespace std' here
        
        Change-Id: Ib403e6f80254fe0c70d6b8821c06b3597b35a052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122649
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [dda21ca52433e3899e0990d852e20af6d8a2e72f]

        gtk4: use gtk_widget_unparent to drop ref count to 0 and destroy
        
        so now gtk4 slideshow mouse input works after an opengl slide has finished
        
        Change-Id: I156d584417d12ab30551445f93e876cca8453e70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122715
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [c918afc1555149ee2e1f8e1f560f1eac3fabaa04]

        gtk3: fix fullscreen mode
        
        Change-Id: I7cfa039dfa246b5384f259a4002d30684026550c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122714
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Stephan Bergmann  <sbergman@redhat.com>  [d9d9bd65e22a3bd61cce6d88849a794bb0918d7b]

        Don't dereference empty optional
        
        ...after 183729b7bdb98561dae2a3e8c9518fe4787ee6e3 "no need to allocate these
        SfxItemSet on the heap", as seen causing SIGABRT at
        
        > #1  0x00007f5b61e6a8a4 in abort () at /lib64/libc.so.6
        > #2  0x00007f5b30a2414b in std::_Optional_base_impl<SfxItemSet, std::_Optional_base<SfxItemSet, false, false> >::_M_get() const (this=0x7f5ae4f52030) at ~/gcc/trunk/inst/include/c++/12.0.0/optional:443
        > #3  0x00007f5b30a219bc in std::optional<SfxItemSet>::operator*() const & (this=0x7f5ae4f52030) at ~/gcc/trunk/inst/include/c++/12.0.0/optional:919
        > #4  0x00007f5b30a1eb35 in FlatFndBox::GetItemSet(unsigned short, unsigned short) const (this=0x7f5b337fb730, n_Col=1, n_Row=4) at sw/source/core/doc/docsort.cxx:929
        
        during JunitTest_sw_unoapi_4.
        
        Change-Id: If409ce86863faf4617c636616f814237ff62c7ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122710
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-27  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [089c7d05fde13251eb8cd8daaf7627b6bb0072f9]

        tdf#48622 add border line thickness predefined values in UI
        
        According to multiple reports border line width selection will be
        more intuitive with some predefined values. Here is an implementation
        of this proposal: line width can be selected from combobox from
        predefined values (thin, medium, thick and custom). Classical spinner
        is right now hidden unless custom line width is selected.
        
        Change-Id: I87a6237335b79a5f5b63e109360e1ea8f12ae071
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114709
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [6e200689eb309cdbe1e4f08311a400835de19bfb]

        tdf#141704 PPTX import: fix hyperlinks on images added via placeholder
        
        Note: see "Interaction..." in the local menu of the image
        of the first slide for manual checking of the fix.
        
        See commit 9bb91441b46d677860530d8bf9597c96561a1b0a
        "tdf#141704 PPTX import: fix hyperlinks on images"
        
        Change-Id: Iba372c095f76b263575d261a7a0fc98eda449bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122429
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-27  Alain Romedenne  <alain.romedenne@libreoffice.org>  [82798029b1d89be07fb21eed081906460ba1cd08]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 62f7c4a827756af6d7cbc838a7d663ad5d962b04
          - SFDocuments.Writer new service - WiP
            
            Change-Id: Ia3da307c224aaea53d6a0e2067a78db113119b50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121770
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [118b96cd424ec4a02501852e9052131f322d0d36]

        fetch the column names once and keep it up to date as new names inserted
        
        Change-Id: Ic865c82c2bbf8cb3be730158c823bd8769038bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [ce89c11c5aa2e01f9827da199c68ab9803e6013e]

        pass the column names in as an external argument
        
        Change-Id: I14ab9e6de0a704076a1c632b6b33aaeabdfc23d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  László Németh  <nemeth@numbertext.org>  [c364532e6b06391a0584f58142c2366d28c803dd]

        tdf#144272 sw: track change of paragraph style
        
        Modifying style of a paragraph, e.g. from "Standard"
        or "Text body" to "Heading n" styles wasn't recorded
        by change tracking.
        
        Now it's possible to track and reject these changes
        also after DOCX export/import.
        
        Note: ODF track changes doesn't support format-only
        changes, so likely it will need to export the paragraph
        content two times, with the old and with the new
        paragraph styles, too).
        
        Note: selecting multiple paragraphs to modify their
        styles at once doesn't record the changes, yet, because
        multi-paragraph ParagraphFormat redline range hasn't
        supported by AppendRedline().
        
        Change-Id: I2d81fa23c59b7b75b3101dc3f2bb8c9eed8ab165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122707
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-27  Tünde Tóth  <toth.tunde@nisz.hu>  [bfd7730f4cf002a79dc9c02c23286850fee3f12a]

        tdf#89383 DOCX import: fix permission for editing
        
        w:writeProtection passwords in DOCX documents created
        with Word weren't asked and verified to permit editing.
        
        Change-Id: I53d73e3acaf0c0fd398ded2de52e1d8ef00cfd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122384
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [6db745543aa7a253c1d3a8e0ba7c2ca69bebbbdd]

        gtk4: get full screen opengl transitions non-crashing
        
        Change-Id: I8ef7f8988d42d2d90dd5ea4746f78644cc71cacc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Ross Johnson  <ross.johnson@homemail.com.au>  [891dfac4bcb600cec2c860bde6d0c8607305102e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7cf8e3f561e8b68134e46f874507fecd25b9f5b1
          - Revert "tdf#33749 - HTML Help pages - reflect changes to cell merge in Calc"
            
            This reverts commit 7a45cfda035abefcda03767a4c81f93c69d593b1.
            
            Reason for revert: Change to core have been reverted due to their regressive nature as reported. This revert is for sync. There is a new patchset coming to resolve the issue.
            
            Change-Id: I30e224b7fc79a9620058e26ee5055f9ff5ce8819
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122647
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [138c6e793882fcf8477e7e75f7f31d5327022aa5]

        split getUniqueColumnName
        
        Change-Id: Ibcac473463c02e7ce6f853ac2dcdf953c13c14e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d6063f416c78f30f1fb717f3ab05f9691bb3461d]

        tdf#131563 - Add vba color constants
        
        Change-Id: I59bcd11b5da1450fced77671c2cf6ed44e299a06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122607
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [44a3839327fe3abee4683134de0071c9aa7f5139]

        Bump Glade version to 3.38 of specialsettingsdialog.ui
        
        Change-Id: Idb638271bb5a1edfe51963e92d6a07f40a1cd779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122685
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [5bc3cc695d58848d937910bf6344af1fa6f71725]

        gtk4: get toggling into full screen mode working
        
        Change-Id: I108d994e0eb13add3e8008840f082b8fe9334f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [fefc215592ab3e11afb957e59016f1b9d6a00593]

        appendColumns is always called with m_aSelectColumns as 1st arg
        
        Change-Id: I791c0eef1fda97d21ba9efb170ef226c9a495eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Tor Lillqvist  <tml@collabora.com>  [50e98026e802d06aae055f14c762ba5c2cb97f02]

        Need a dummy AquaGraphicsBackend::drawNativeControl() on iOS
        
        Change-Id: I5264eb8dbd817cbf0e6fdc00a84d60249258d3ad

2021-09-27  Tor Lillqvist  <tml@collabora.com>  [2d91ff1c541c6c024249795cdd6adda2eb59080f]

        Need vcl/quartz/AquaGraphicsBackend for iOS, too
        
        Change-Id: I562fd9e07ce55ad8a28b8cd51f7bc1535241f5fc

2021-09-27  Tor Lillqvist  <tml@collabora.com>  [3b2e8d57ae6ad7e16d4cdee5873cb3057d9856f8]

        Match what Xcode offers as highest 13.x deployment target
        
        Use 13.6, not 13.7, for the miphoneos-version-min option.
        
        Avoids warnings when linking the Collabora Office iOS app against core
        master.
        
        Change-Id: I89b7cb37b7a66a733e4eb82a90bba08106be1163

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [b63c5ade3554a42def4bce94f9fd67ea66528214]

        setSelectColumnName is always called with m_aSelectColumns as 1st arg
        
        Change-Id: If86c4f48ed7eb6860f461fe905c0628cb9b73043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Miklos Vajna  <vmiklos@collabora.com>  [9ef18582310d6f397a811dc5cc3c2cc1c64076ac]

        sw: paragraph styles: add DOCX filter for a linked character style
        
        And the same in the other direction: link a para style from a char
        style.
        
        This gets the info out of the grab-bag, so later we can store it also in
        ODF.
        
        No new tests, the existing testStyleInheritance in
        CppunitTest_sw_ooxmlexport3 covers this refactor.
        
        Change-Id: I5ada7ea471a253204984ae0466bd0f8ad70046e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122681
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [1b7c53db87bb67eeb2591fbb186f7ac20eb00c68]

        WIN lazy init WinSalInfoPrinter graphics
        
        ... and while at it make stuff private and add _ to the newly
        private member variables.
        
        The new assert revealed a bug in the SalGraphics refcounting,
        because the virtual ReleaseGraphics is called from the
        destructor, which was probably also the reason for the HACK
        and comment in Printer::ImplReleaseFonts.
        
        Change-Id: I7af0bda19be6810dd8c0ea5b74604381e2047407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122371
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [074abfdfe446da400c43a7ff88e6d7b66edefa33]

        Fix Windows Arm64 build (Cuckoo and Skia)
        
        Add CUCKOO to the list of permitted BUILD_TARGETS for
        gb_Side=build and correctly skip Skia after commit
        9714f3348d972a179e73423c44a97954bf6cc534 ("do not
        special-case Clang for Skia on Windows Arm64").
        
        Change-Id: Ic5ec56b9525457a5455e55dd5034c03bcddf8b1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122664
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-27  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [94956d13b7b6ad1e97777e908b968b117682a8cd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e7ef99cadf81a72688dbae1f8ba9f99c3b568aa7
          - Assorted string fixes
            
            • Removed some hardcoded product names
            • Updated color palettes referred to in a string
            • Updated an option’s name I missed in d599028d4f126c8a2badc3787e3fdf8277219c96
              because I didn’t expect the Help would be inconsistent with the UI when searching.
            
            Change-Id: I75a33ae802e1baa01c99d274b8418dfe049d39c6
            
2021-09-27  Luboš Luňák  <l.lunak@collabora.com>  [26c40d37922b48b7f28953e4ab3049bafb97917d]

        do not call osl_getProcessInfo() for ProfileZone if not recording
        
        This call actually shows up as 6% for me when CPU profiling
        CallbackFlushHandler. And I assume ProfileZone is not designed
        for switching pid's or starting recording in the middle of profile
        zones, so this should be fine.
        
        Change-Id: Ibfa0ccd2d89a80c3e62d6f3c99c036df8508b44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122677
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Tested-by: Jenkins

2021-09-27  Caolán McNamara  <caolanm@redhat.com>  [89f162abb25168afe942247b77454e45145f1ab8]

        ofz#39309 collect the names just once
        
        Change-Id: Iad8a6c80ecac7b8dc380a4c16ccd82650ecc10f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-27  Aleś Bułojčyk  <alex73mail@gmail.com>  [54235fc2e2674cd3cf38dd71176efb0cd6be5ae5]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to bc821271e3bf99a4228a29f25f066fd3bac307fb
          - Belarusian hunspell dictionary update
            
            It's really new dictionary, which is based on the new Belarusian grammar
            database. This database contains ~265ths paradigm and ~4.5mln wordforms.
            It's most complete list of words of Belarusian language for today.
            Dictionary for LibreOffice doesn't include all words, of course, but
            only words from official academic dictionaries. This database will be
            officially released at the beginning of October, 2021 under the label
            of the Institute of Linguistics of the National Academy of Sciences
            of Belarus at https://github.com/Belarus/GrammarDB.
            Old dictionary doesn't contain so complete list of wordforms (there are
            many missed words) and was based on old lists of words from different sources.
            
            "Official" means official orthography. There is also widely-used
            "Classical Orthography" or "Taraškievica"
            (https://en.wikipedia.org/wiki/Tara%C5%A1kievica).
            Rules for official orthography were revised in 2008. This dictionary
            fully correspond with new (2008) rules and academic dictionaries.
            Old LibreOffice dictionary contained words by 1957 rules.
            Differences between 1957 and 2008 rules are not so big, but they exist.
            
            Change-Id: Ie55bc3a946364a13793e3b55522612c69345b57d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/121746
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-09-27  Natalia Gavrilova  <nataligavrilova8@gmail.com>  [b1c318e9f18f6a4e56d42fc7b7c5c2942b28941d]

        tdf#142121 Cell focus rectangle does not use font color
        
        * Focused rectangle uses highlight color instead of font
        
        Change-Id: I861f944b449d31183f082864e57071e401d3c451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122602
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-27  Miklos Vajna  <vmiklos@collabora.com>  [ebb4cee9b796313165e4362886516da971074556]

        sw: prefix members of SwPageFootnoteInfoItem, SwStdFontConfig, ...
        
        ... SwToolbarConfigItem and TextViewOutWin
        
        See tdf#94879 for motivation.
        
        Change-Id: I0d13d501c6a18c4f4f56d163f0065dd4eae88f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122672
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-27  Ross Johnson  <ross.johnson@homemail.com.au>  [2c5a094e8a0e78b3b2be9b7894d888c43d22619c]

        Revert "tdf#33749 - rationalise several confusing cell merge controls"
        
        This reverts commit 8010a0a32c232f06534fdd56c2227c9c00798cfd.
        
        Reason for revert: The change introduced a regression.
        
        Change-Id: I59446c62e8798cf7a6a11d916da0c1f393c87dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122450
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-27  Justin Luth  <justin_luth@sil.org>  [a0cc67350a56a77a457a1236f414a579c148194a]

        tdf#127543 add saveacopy to File dropdown menu tabs #2
        
        Invisible menu items just don't cut it.
        This adds SaveACopy also to "Tabbed Compact"
        
        Change-Id: If6e2807467e8885ab494b291e98778c7626ebe54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122605
        Tested-by: Jenkins
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2021-09-26  Julien Nabet  <serval2412@yahoo.fr>  [0dee0bdaea1ddfb72cf84b81dda0e9ff2fc58159]

        Typo: *Transparanc*->*Transparenc*
        
        Change-Id: Ia9325a397b89c09dac4b6c76e4a0521bbdbf5db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122655
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-26  Noel Grandin  <noelgrandin@gmail.com>  [92125d0d669671ca0fd21408b93f89d0e3cf860c]

        use SfxItemSetFixed in various
        
        Change-Id: Ie2472959dbab93ead20948245fca9644de834422
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Noel Grandin  <noelgrandin@gmail.com>  [adfdffa5001dd17da9ea3670a5dc23af559c17ba]

        use SfxItemSetFixed in sw
        
        Change-Id: I1b7bfe92dc4ef61b26940ed02ccd8f359e8149e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Julien Nabet  <serval2412@yahoo.fr>  [501929557800e400c9ee07d25687ee60354d74c2]

        tdf#50421: use substVariables for remaining %PERCENT% in "Check for Updates"
        
        Change-Id: I9e1094ef9a957ca1524367f985f37ffc0da5b353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122621
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [7809e2fe6cd237a547d93293d1ea434d16ccb689]

        recursive_mutex -> mutex in BasePrimitive2DImplBase
        
        Change-Id: I99e13b91afbf0d4d36b13e463fde2dec1c4d9e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Caolán McNamara  <caolanm@redhat.com>  [c92a29fd6ef341a1657f90759d20e4f052b45843]

        tdf#144729 create FrameSelectorImpl before setting size request
        
        gtk wan't to update some a11y info when we set the new size request but
        we haven't created the requirements that a11y needs yet.
        
        Just move that creation to before the set_size_request
        
         #0  std::__cxx1998::vector<svx::FrameBorder*, std::allocator<svx::FrameBorder*> >::size() const (this=0x720) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/stl_vector.h:919
         #1  0x00007fbd40f3fcc2 in svx::FrameSelector::GetEnabledBorderCount() const (this=0x91bafd0) at svx/source/dialog/frmsel.cxx:858
         #2  0x00007fbd40da76b8 in svx::a11y::AccFrameSelector::getAccessibleChildCount() (this=0x921b190) at svx/source/accessibility/AccessibleFrameSelector.cxx:63
         #3  0x00007fbd3184930e in AtkListener::updateChildList(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext> const&) (this=0x91e6200, pContext=
             uno::Reference to (svx::a11y::AccFrameSelector *) 0x921b1f0) at vcl/unx/gtk3/a11y/atklistener.cxx:149
         #4  0x00007fbd31849096 in AtkListener::AtkListener(AtkObjectWrapper*) (this=0x91e6200, pWrapper=0x91e60a0) at vcl/unx/gtk3/a11y/atklistener.cxx:56
         #5  0x00007fbd3186e9ab in atk_object_wrapper_new(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible> const&, AtkObject*, AtkObject*)
             (rxAccessible=uno::Reference to (svx::a11y::AccFrameSelector *) 0x921b230, parent=0x9299a40, orig=0x90bedd0) at vcl/unx/gtk3/a11y/atkwrapper.cxx:875
         #6  0x00007fbd318b3ded in (anonymous namespace)::GtkInstanceDrawingArea::GetAtkObject(_AtkObject*) (this=0x91e5060, pDefaultAccessible=0x90bedd0) at vcl/unx/gtk3/gtkinst.cxx:16918
         #7  0x00007fbd318b3d21 in (anonymous namespace)::drawing_area_get_accessibity(_GtkWidget*) (pWidget=0x91206f0) at vcl/unx/gtk3/gtkinst.cxx:21555
         #8  0x00007fbd30fb0bc2 in  () at /usr/lib/x86_64-linux-gnu/libgtk-3.so.0
         #9  0x00007fbd3764b65f in g_closure_invoke () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #10 0x00007fbd3765d99b in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #11 0x00007fbd37663c6f in g_signal_emit_valist () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #12 0x00007fbd376641df in g_signal_emit () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #13 0x00007fbd3764fcd4 in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #14 0x00007fbd3764f50e in  () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #15 0x00007fbd37651d4b in g_object_thaw_notify () at /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0
         #16 0x00007fbd318b86d5 in (anonymous namespace)::GtkInstanceWidget::set_size_request(int, int) (this=0x91e5060, nWidth=137, nHeight=146) at vcl/unx/gtk3/gtkinst.cxx:3475
         #17 0x00007fbd40f3fa23 in svx::FrameSelector::SetDrawingArea(weld::DrawingArea*) (this=0x91bafd0, pDrawingArea=0x91e5328) at svx/source/dialog/frmsel.cxx:833
         #18 0x00007fbd3d16d46a in weld::CustomWeld::CustomWeld(weld::Builder&, rtl::OString const&, weld::CustomWidgetController&) (this=0x90e9fd0, rBuilder=..., rDrawingId="framesel", rWidgetController=...)
             at vcl/source/app/customweld.cxx:28
         #19 0x00007fbcf08f0c4e in SvxBorderTabPage::SvxBorderTabPage(weld::Container*, weld::DialogController*, SfxItemSet const&) (this=0x91baeb0, pPage=0x90fc550, pController=0x7a4d4b0, rCoreAttrs=
             SfxItemSet of pool 0x5aea070 with parent 0x5b25658 and Which ranges: [(1, 45), (63, 132), (153, 153), (1014, 1033), (10023, 10023), (10050, 10055), (10057, 10058), (10065, 10065), (10179, 10183), (10451, 10451), (10457, 10457), (10467, 10467), (10591, 10591), (10855, 10855), (11142, 11142), (12065, 12065), (21123, 21123), (21307, 21307), (22401, 22401)] = {...}) at cui/source/tabpages/border.cxx:291
         #20 0x00007fbcf08fc77f in std::make_unique<SvxBorderTabPage, weld::Container*&, weld::DialogController*&, SfxItemSet const&>(weld::Container*&, weld::DialogController*&, SfxItemSet const&)
             (__args=@0x7ffdac0324e0: 0x90fc550, __args=@0x7ffdac0324d8: 0x7a4d4b0, __args=SfxItemSet of pool 0x5aea070 with parent 0x5b25658 and Which ranges: [(1, 45), (63, 132), (153, 153), (1014, 1033), (10023, 10023), (10050, 10055), (10057, 10058), (10065, 10065), (10179, 10183), (10451, 10451), (10457, 10457), (10467, 10467), (10591, 10591), (10855, 10855), (11142, 11142), (12065, 12065), (21123, 21123), (21307, 21307), (22401, 22401)] = {...}) at /usr/bin/../lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/unique_ptr.h:962
         #21 0x00007fbcf08f514f in SvxBorderTabPage::Create(weld::Container*, weld::DialogController*, SfxItemSet const*) (pPage=0x90fc550, pController=0x7a4d4b0, rAttrSet=0x7dca0e0)
             at cui/source/tabpages/border.cxx:592
        
        Change-Id: I7325970bf0137602007e453e8b7fc43f1e6f36c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-26  Caolán McNamara  <caolanm@redhat.com>  [619dcf67c1f770685c6b40477f15657f70c05865]

        ofz#39303 don't Abrt on missing com.sun.star.form.component.Form
        
        Change-Id: I82f6914f8dc46185c608fda6ede3074c4ee66b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122630
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-26  Hossein  <hossein@libreoffice.org>  [4fe1368f24d9f6230852fbf58b61f6c255cadb60]

        Removing unneeded check
        
        The condition nPlanes != 1 is checked in the previous if statement and if it the content of nPlanes is anything other than 1, it would have used the break to exit the switch case. Thus, there is no need to check nPlanes == 1 again.
        
        Change-Id: I1e07b48af16de40d39eabb6f2b666e41b0b0432e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122451
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-26  Caolán McNamara  <caolanm@redhat.com>  [bfc70a9f314bbb5b03247be25544e9b4cc467f8d]

        ofz#39304 short timestamp record
        
        Change-Id: I8f783473dd5d4679846c7c866cd1853ef7d919fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122628
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-26  Caolán McNamara  <caolanm@redhat.com>  [4a93b7a2f8a3fc13fed800d93e2103b785abeb62]

        ofz#39301 month has to be in range [1-12]
        
        Change-Id: I5a4ca534b24098342d8f465a32bc1887f40f5b63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122629
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-26  Caolán McNamara  <caolanm@redhat.com>  [278ea37351daa4a74705fd615ca6bacb04db5c90]

        ofz#39150 avoid Timeout with large editengine strings
        
        Change-Id: I06413377120420acf132fcbe1a6a9866bdb7ccd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-26  Noel Grandin  <noelgrandin@gmail.com>  [183729b7bdb98561dae2a3e8c9518fe4787ee6e3]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: Ic969f45ff35cdccf6603a5f9dcb94d1fdec9535c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Noel Grandin  <noelgrandin@gmail.com>  [aad712f6362378f19db2062f0499fd039c2f7114]

        no need to allocate these SwFrameDeleteGuard on the heap
        
        Change-Id: Ib8b2fe4ff1309c6fb11fa50ff24ea0dd63faf0e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122617
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Noel Grandin  <noelgrandin@gmail.com>  [a7f5225f2900fcb21ed5565de1b606b3c3e1c81c]

        no need to allocate these SwBorderAttrAccess on the heap
        
        Change-Id: I9200ff5072babf11afe37ec0fe0d7401779be7c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-26  Julien Nabet  <serval2412@yahoo.fr>  [b9789f0c7eb29a4e9d1c02855714109f5d3fa407]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5d9d7d50c9000119abd7b89fe0f48a41cc6a2502
          - tdf#144730: Replace CONVERT_ADD to CONVERT to fix metric/non metric conversions
            
            Regression from
            https://cgit.freedesktop.org/libreoffice/core/commit/?id=ced79363cc30f225e766195ace4f892754fc85a0
            author	Eike Rathke <erack@redhat.com>	2016-08-03 18:56:01 +0200
            committer	Eike Rathke <erack@redhat.com>	2016-08-03 18:57:37 +0200
            commit	ced79363cc30f225e766195ace4f892754fc85a0 (patch)
            tree	94b2554faecda3744b05dcf61b99ebc2b25be5ab
            parent	fa2fdb6607a7b961affadb6ca633b8feed828467 (diff)
            Resolves: tdf#69539 UI rename CONVERT to CONVERT_OOO, CONVERT_ADD to CONVERT
            ... with same syntax but different semantics that was even more confusing.
            
            Change-Id: I8d0badb231e58c9208f58fcbe013bbad4309ce74
            
2021-09-26  Julien Nabet  <serval2412@yahoo.fr>  [1c1b2b2f8d2abd6d179128b2fc4cb40c490566eb]

        tdf#144694: improve Direct SQL dialog command type heuristics
        
        When the SDBC driver doesn't support multiple results sets:
        
         * special-case INSERT, UPDATE, DELETE like
           SELECT already was.
         
         * for unrecognised SQL commands, take the "show output"
           checkbox as a hint whether to use executeUpdate()
           or executeQuery()
        
         + create a new var to store statement in uppercase
           instead of calling toAsciiUpperCase() repeatedly
        
        Change-Id: I9a7d1d3d93e72e0a42871c1859346c9e40de868e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122608
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-09-26  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [cbf545e0f89a64891a8f35da44f020f7400b58b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 833a936a4416be31136729594329311cabb24f7f
          - Switch from Fuzzysort to FlexSearch
            
            FlexSearch has the best performance of JS search libs at the moment.
            It doesn't have fuzzy search yet, but maybe our users don't even
            want the feature. RFE is https://github.com/nextapps-de/flexsearch/issues/118
            
            flexsearch.debug.js is used because it is the only unminified version and
            we can't use minified files in the source code as they are equivalent to
            binary files (close source). There doesn't seem to be anything that would
            make it a bad idea to use the debug version in production, only a couple
            of edge case checks that print warnings to console.
            
            This commit also makes automatic filtering work when the input field already
            has a string upon page load (functions were called in the wrong order).
            
            Change-Id: I5055f7f7f99cad92dfa3a544e5314eb85a1faced
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122566
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-25  Jim Raykowski  <raykowj@gmail.com>  [a78190da867864485b5d0a91238616bd4090b5b5]

        tdf#143268 Fix slow response after Navigator fills table members
        
        when document has many tables
        
        Change-Id: Iccf34700a3f09420f3dc3519b04351c53d1d59b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122416
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-25  Jim Raykowski  <raykowj@gmail.com>  [7c4f9a1280e5524eee81fe65bf5d76e83e68275e]

        SwNavigator: Set in content type init if delete and edit are allowed
        
        Fixes crash that occurs for REFERENCE content type 'Delete' and
        'Edit...' menu items. These are not allowed for REFERENCE content type.
        
        Change-Id: I893acd57f80c9a96637e4070f3e1ca7c29b1d7ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122559
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-25  Caolán McNamara  <caolanm@redhat.com>  [ca844cbdc3e933e3082e9cde0632445916de819e]

        ofz#39252 use safer SwUnoCursor for the pos to move back to
        
        Change-Id: Iba6f200cea92196986bd30564cf56ab5d8b954b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122611
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [737281730fed4edf44917eedb95eb234dda4da57]

        vcl: Add sal/config.h in preparation for patch
        
        Done in preparation of split of outdev.h into seperate headers
        
        Change-Id: I9183f9e10a3fd47557239b8cc9290ce8e86e614a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122255
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-25  Chris Sherlock  <chris.sherlock79@gmail.com>  [b964de6daacd583a1ae10760fe76a6cb49bd2e4d]

        tdf#143148 - Use pragma once instead of include guards
        
        Done in preparation of split of outdev.h into seperate headers
        
        Change-Id: If9c52a7cf8d401cdcf84043d27dc826cca27fea8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122405
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-25  Caolán McNamara  <caolanm@redhat.com>  [eb5de6c3620e7207e473b6e932f1902103d2a35d]

        add dbffuzzer
        
        which requires dropping ---disable-database-connectivity
        
        Change-Id: I5b3a2027916a3cf844cefd90629c3fe918ead31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [7e571e59559dcf80ee0c195533cb0895da175a07]

        WIN call RealizePalette from setPalette
        
        I have no idea, how to handle a RealizePalette error or when it
        can occur. The previous code has ignored it all together, or
        handled it as successful. This now doesn't act on GDI_ERROR.
        
        FWIW GDI_ERROR is defined a ~0 in wine, as it's an UINT.
        
        Change-Id: Ib0aaabcaa8c2d7d7ca93678b6b82db864beb8ce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122370
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-25  Noel Grandin  <noelgrandin@gmail.com>  [03998c25358f88a9fd6ac306ad1aba81fceca0fe]

        use SfxItemSetFixed in svx
        
        Change-Id: I8123b34c73a16579b59989ae31329dec378d8b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122584
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [398ae49ba337a2d2c32611f371132c978cf4db64]

        WIN handle graphics palette with deinit
        
        Manually setting the default palette of the graphics DC seems to
        be a bad idea. And I think this fixes a real bug in
        ImplHandlePalette, because that would set the graphics DC palette
        but didn't set the default palette using setDefPal.
        
        Change-Id: Ic3b176645c68fa33a020791d5b64b04c3cbaacee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122158
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [3d897530d4cd24e2739c81a39984015b192d110e]

        WIN WinSalPrinter::isValid implies a valid HDC
        
        Change-Id: I7a8bb9f6666c75165ac1dcd49f14ae983b6eefe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122372
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4af5b62a184354bf6338c4d872717ec46c86107f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 39f3c4dc011dd2cffbbd9b6eb9cea655e1e09772
          - typo
            
            Change-Id: Iae51822e330a1479aa6f5616db17c9d7552e217b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122448
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [42f9d4335bfa4b7299224801fd7ccdd97ae92fbf]

        WIN always (de-)init WinSalGraphics
        
        Originally I thought the whole (de-)initialization was some kind
        of lazy SalGraphics init stuff. But reading the existing code
        proved me wrong and every InitGraphics came a few lines after a
        setHDC call and DeInitGraphics before deletion or setHDC(nullptr).
        
        $ git grep -n "delete.*pGraph\|setHDC\|InitGraphics" vcl/win/
        
        So just make (De-)Init part of setHDC and drop all the other calls
        to (De-)InitGraphics, adding a setHDC(nullptr) to the destructor.
        
        I've also added some questionable asserts, like
        
        assert(pPrinter->mpGraphics->getHDC() == pPrinter->mhDC);
        
        As I read the code, you can have a printer object initialized with
        a DC but without graphics, which will be initialized on demand.
        
        But AFAIK it's invalid to have a printer DC != graphics DC.
        
        Then there was the hDC check in WinSalPrinter::EndPage, which is
        IMHO not needed. AFAIK there is no way the graphics DC might be
        "magically" invalidated, so restoring the old DC values should
        always work.
        
        Change-Id: I1b961cfa733263ce773575a728bcce5c7d3e97ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122157
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [384d4301797fcdb9eb9c4f378d27c21f0d759969]

        Fix typos
        
        Change-Id: I40b4efb228176891678b8560a7ee4e37e77495e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122596
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-25  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d148ed642f2aef2c2cc8615296cc648249a4878d]

        tdf#76258 Fix xlsx export of color filter colors
        
        Change-Id: I08bd46fe10a8fc35a9c2a87745ee3e8cb4c676d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116648
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-25  Justin Luth  <justin_luth@sil.org>  [360e6b8453acc26880f4f45e6792c2c0e15f0896]

        tdf#45525 tdf#64242 sw row optimize: get correct row height
        
        Optimizing is trying to find the actual height of each row
        and adding them all up together to find the total height.
        But without this fix, the height of the previous rows
        was never being reset, so the later rows were potentially
        reporting a larger height than they should have.
        
        Change-Id: I789edc0ca700d9b1448832fa9720ec7ec3b16223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122572
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [7cd5b35caa8d4fa9d0ba2b2c6ce4b88726ed2be6]

        return SwCursor from IShellCursorSupplier
        
        rather than casting it
        
        Change-Id: Ia950f521c8f73d8a0da59344db9b5aacb727aca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122576
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Stephan Bergmann  <sbergman@redhat.com>  [a93c3f2eb07fc15d1ebb0fd70ab58ecea27bd4f1]

        GError::message is UTF-8
        
        This caused CppunitTest_sw_dialogs_test to fail for LO_TEST_LOCALE=or hitting
        
        > sal/rtl/ustring.cxx:530: void rtl_uString_newFromAscii(rtl_uString**, const char*): Assertion `static_cast<unsigned char>(*pCharStr) < 0x80' failed.
        
        at
        
        > #4  0x00007fd18a844f74 in rtl_uString_newFromAscii(rtl_uString**, char const*) (ppThis=0x7ffcb73e6e90, pCharStr=0x6191180 "ସମୟ ସୀମା ପହଞ୍ଚିଯାଇଛି") at sal/rtl/ustring.cxx:530
        > #5  0x00007fd1525af9c1 in rtl::OUString::createFromAscii(char const*) (value=0x6191180 "ସମୟ ସୀମା ପହଞ୍ଚିଯାଇଛି") at include/rtl/ustring.hxx:3328
        > #6  0x00007fd1525ad026 in (anonymous namespace)::GErrorWrapper::~GErrorWrapper() (this=0x7ffcb73e6f38, __in_chrg=<optimized out>) at shell/source/sessioninstall/SyncDbusSessionHelper.cxx:35
        > #7  0x00007fd1525ad6a5 in (anonymous namespace)::request(char const*, com::sun::star::uno::Sequence<rtl::OUString> const&, std::u16string_view) (method=0x7fd1525b481d "InstallFontconfigResources", resources=uno::Sequence of length 1 = {...}, interaction=u"hide-finished") at shell/source/sessioninstall/SyncDbusSessionHelper.cxx:91
        > #8  0x00007fd1525ada9d in shell::sessioninstall::SyncDbusSessionHelper::InstallFontconfigResources(com::sun::star::uno::Sequence<rtl::OUString> const&, rtl::OUString const&) (this=0x5d22380, resources=uno::Sequence of length 1 = {...}, interaction="hide-finished") at shell/source/sessioninstall/SyncDbusSessionHelper.cxx:158
        > #9  0x00007fd178670daa in psp::PrintFontManager::autoInstallFontLangSupport(Timer*) (this=0x2e3ed90) at vcl/unx/generic/fontmanager/fontconfig.cxx:962
        > #10 0x00007fd178670cd9 in psp::PrintFontManager::LinkStubautoInstallFontLangSupport(void*, Timer*) (instance=0x2e3ed90, data=0x2e3efa0) at vcl/unx/generic/fontmanager/fontconfig.cxx:956
        > #11 0x00007fd178341e03 in Link<Timer*, void>::Call(Timer*) const (this=0x2e3efc0, data=0x2e3efa0) at include/tools/link.hxx:111
        [...]
        
        (But probably better to use the lenient OUString-from-rtl_TextEncoding ctor
        rather than OUString::fromUtf8, in case GError::message happens to not contain
        proper UTF-8 after all, which would make the latter assert.)
        
        Change-Id: I61fede4576988c5f7f35bb071ab3f2c0e7a15aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122599
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-24  Miklos Vajna  <vmiklos@collabora.com>  [e3227975c0f42ff23d528f5ab94b4538c8af764c]

        sw: paragraph styles: add doc model & UNO API for a linked character style
        
        And the same in the other direction: link a para style from a char
        style.
        
        Towards getting this info out of the grab-bag, so we can store it also
        in ODF, as currently this is only kept for DOCX -> DOCX conversions, via
        the style grab-bags.
        
        Change-Id: I21691dafce0bc216d041fc8ecb16b162d293739e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122595
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [5f19e2679c3d402fbc3de0b64d5ca3e411db711d]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I85bc4a7b9c638b928f55072e92188ee13ca9311f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [e8edc8edbf820d8358b465b92e697eb6831d23de]

        no need to allocate these SwPaM on the heap
        
        Change-Id: Ief142e6410599ea50aee4065d843d7eaea55e21c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122578
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [fb7d05f3d56c3e21ed7ba5cf8723a02801640caa]

        CppUnittest: sw: add missing asserts to odf files
        
        Change-Id: I59036904483d4ed04481b034183bf17c3ec21bdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122594
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-24  Miklos Vajna  <vmiklos@collabora.com>  [8cb779eb7f8cd9eca9fb5e40dbe37c712ee6c0aa]

        sw: document SwCharFormat
        
        What confused me is that a para style is an SwTextFormatColl, but a char
        format is an SwCharFormat, i.e. no Coll in the name.
        
        Change-Id: Ia87a7e3bbd111494457ae406a626c287c52b6097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122585
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [628f0756f1b8945cfb4d5f848125c269a2233ba1]

        disable these for fuzzing as well as !HAVE_FEATURE_DBCONNECTIVITY
        
        Change-Id: I90d9680590c9f9e36fdafaca9c98955a03654da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122589
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [0ea1911df145b86f1fadae1c0cbd9ffd030510ec]

        add a oss-fuzz-setup.sh to move setting up oss-fuzz env into our git
        
        instead of making an upstream change for each dependency change.
        
        We already download missing dependencies within our build, but in
        oss-fuzz we have multiple builds back to back in fresh environments, so
        we would do that for each build, e.g. once for asan, again for ubsan and
        again for msan etc.
        
        Change-Id: Ie810df5e84d4b265200e5c54831a4da43255af55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122598
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Miklos Vajna  <vmiklos@collabora.com>  [53947050095fd98ddf3ed88d177ae894f2a51afe]

        sw: make sure own header is the first in rtfexport
        
        So that we have a build-time test that the header is self-contained.
        
        Change-Id: I23d288dbef2baa2b277b691271592a9a17dbaa6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122586
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [e40ba5a38a183d8da91d312c1a22e61eeb9845fd]

        for fuzzing hardcode a case sensitive file system result for detection
        
        rather than throwing ucb exceptions continously
        
        Change-Id: Ia3545619fe9a7c4c8f0470179eca68f0ae4bf4de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122588
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [8792cf693dba3e05ed72a353685bc99d0d34c250]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I651d6091db543ebc958f888598edd2cdef4df43a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122574
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [e69ca434253d3278975078600f8a77291d97b9fc]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I4982d075f21f74b3d0db1c61a499dceb92e50c87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122575
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [632e7b9d43f820250acb190835f50fb50f76b725]

        check-missing-export-asserts: update path
        
        it was changed in 6353c51e8bf66fe223080db649fc07e62a3a6c97
        <sw: introduce a Library_swqahelper>
        
        Change-Id: I3acf2407504e9b8ee923037ec3b5b887112bf580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122587
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [78cee244be863a14dfc76e4540b21dd08dba5e5a]

        make it possible to build required database stuff for fuzzing
        
        The dbase filter requires dbaccess and connectivity but I don't want
        to pull in the rest of the stuff that --disable-database-connectivity
        currently disables that we still don't need for fuzzing if
        --disable-database-connectivity is removed
        
        Change-Id: Ia48d42295f9724b4dd2d3beb8e46ed23fc789f5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122579
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [b0886a4dc7e5a34ab3ee302b6ad6c30c0ce6a0af]

        use a min of 1 as 0 triggers refreshHeader to reload
        
        Change-Id: Iecc6adcce7e32a205f0c9cc6d634d703ea88de06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Michael Weghorn  <m.weghorn@posteo.de>  [8125fd6c5c3e7143704a1be281f46f42036184cb]

        qt5: Avoid calling QApplication::fontMetrics
        
        It's deprecated in Qt 6.
        
        Change-Id: Idd7e93627a0c13b89b1a271c859ce29d01e55ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122556
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-24  Michael Weghorn  <m.weghorn@posteo.de>  [d0c2e5dde094c4e18e63e665e20e5d781fd90753]

        qt5: Don't use deprecated QStyleOptionProgressBarV2 typedef
        
        'QStyleOptionProgressBarV2' is just a typedef for
        'QStyleOptionProgressBar' in Qt 5 and has been
        removed in Qt 6.
        
        Change-Id: I7ee63d0ebe6b035b6048e54a94c98ca54942a7d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122555
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-24  Michael Weghorn  <m.weghorn@posteo.de>  [8248d4cd6021614461ae79adcd447d4c35e9fa96]

        qt5: Replace use of deprecated QDesktopWidget in Qt5System
        
        Change-Id: Id6ba8dfcf2f966f0e2e224990dec0309cd4d27d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122551
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [fd5b28d4bfef32a6bd63d963d16753c7ef985ec5]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I0be145f25cfa90d52873e9baf30cbac9de9cba31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122558
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Michael Weghorn  <m.weghorn@posteo.de>  [5614c4ef4cf2b4e2f45e52541340951f12dd4f21]

        qt5: Use QString::fromUtf16 with 'const char16_t *' param
        
        'QString QString::fromUtf16(const char16_t *, qsizetype)'
        was introduced in Qt 5.3.
        
        The one taking a 'const ushort *' param is deprecated in Qt 6.
        
        Change-Id: I0f2a8ecc5e3dd16aaee55a288c27c3c1d65f87ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122550
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-24  Michael Weghorn  <m.weghorn@posteo.de>  [84c25d55fe03f693a86816ad11f614bc7d07ed1a]

        qt5: Port Qt5Frame away from deprecated QDesktopWidget
        
        Most of QDesktopWidget's methods were deprecated in
        Qt 5.11 and QDesktopWidget was removed in Qt 6.
        
        Since 'QScreen *QGuiApplication::screenAt(const QPoint &point)'
        was only introduced in 5.10, keep using
        'QDesktopWidget::screenNumber' for older Qt versions.
        
        Change-Id: I915fda0ea00b018945974ad82c1927a5fac99145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122548
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [fe040e71343cb894f97a0781f77805fd046178ca]

        we just want to append to the caught exception and rethrow it
        
        try and avoid using cppu::throwException due to asan
        
        AddressSanitizer:DEADLYSIGNAL
        =================================================================
        ==571495==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x7f0af1cee04c bp 0x7ffc0fa694f0 sp 0x7ffc0fa69298 T0)
        ==571495==The signal is caused by a READ memory access.
        ==571495==Hint: this fault was caused by a dereference of a high value address (see register values below).  Disassemble the provided pc to learn which register was used.
            #0 0x7f0af1cee04c  (<unknown module>)
            #1 0xab690cf in dbtools::SQLExceptionInfo::doThrow() connectivity/source/commontools/dbexception.cxx:240:9
            #2 0xa5e0a26 in dbaccess::ORowSet::impl_ensureStatement_throw() dbaccess/source/core/api/RowSet.cxx:1661:16
            #3 0xa5e0d80 in dbaccess::ORowSet::impl_prepareAndExecute_throw() dbaccess/source/core/api/RowSet.cxx:1667:5
            #4 0xa5d33c4 in dbaccess::ORowSet::execute_NoApprove_NoNewConn(osl::ResettableGuard<osl::Mutex>&) dbaccess/source/core/api/RowSet.cxx:1800:45
            #5 0xa5d0a10 in dbaccess::ORowSet::execute() dbaccess/source/core/api/RowSet.cxx:1556:5
            #6 0x6eae94 in ScDocShell::DBaseImport(rtl::OUString const&, unsigned short, std::__1::map<short, ScColWidthParam, std::__1::less<short>, std::__1::allocator<std::__1::pair<short const, ScColWidthParam> > >&, ScFlatBoolRowSegments&) sc/source/ui/docshell/docsh8.cxx:316:18
            #7 0x65ba78 in TestImportDBF sc/source/ui/docshell/docsh.cxx:3448:33
            #8 0x627912 in LLVMFuzzerTestOneInput vcl/workben/dbffuzzer.cxx:49:11
            #9 0x53fe23 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) cxa_noexception.cpp
            #10 0x53f61a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) cxa_noexception.cpp
            #11 0x540ccb in fuzzer::Fuzzer::MutateAndTestOne() cxa_noexception.cpp
            #12 0x5416f5 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) cxa_noexception.cpp
            #13 0x5325ce in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) cxa_noexception.cpp
            #14 0x557582 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
            #15 0x7f0af28b90b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
        
        seen in oss-fuzz build with
        clang version 14.0.0 (https://github.com/llvm/llvm-project.git 0e03450ae4358e8a8242b73d493d96efea9d3ccf)
        
        Change-Id: I0d676e10d7749ab331870b3d763e8f0bbefa18c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [fa89349b360945d726db0c5f85cd4ccb0822417f]

        make SQLExceptionInfo utilities available for external use
        
        Change-Id: I6561fa433f6619d8de97983fa962f874cbf5b536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122570
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [b71079f6e145a8916e1bc7f198e7c445a7101dc8]

        split SQLExceptionInfo::append more
        
        Change-Id: Id6dd8dfc3dc072f573e3a1a750428cb149be8e83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122569
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [6db2d41f2bc085e249282644fd7d2b1c04338a8d]

        check-missing-unittests: document the script a bit
        
        Change-Id: I5111f47e744ac18d19ed3f8e0ae1fb534ca42669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122564
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [397290489354d8ba5958d43acc58482c8115f69f]

        bin: Add script to compare the crashreport stats of two different versions
        
        Change-Id: I10103bf6a551f5dd5262ead9c6b34c8424d5430e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122563
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [38b907c8bc1cd2cfc3f57abd97c5b2befb4a6a3d]

        refactor getting the last exception of a SQLException chain
        
        Change-Id: Ia60766709e5093f5cc60d44697343e5a63f7ba03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122568
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [66636097f0464beffa678e0898bf379718494c10]

        split SQLExceptionInfo::append
        
        Change-Id: I4e86e580843042e482e8732843a45a9eedfad320
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122567
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [9df0e11c48071fb5ed98d474ea036a3f7d10e7ba]

        need connectivity_dbase_ODriver if HAVE_FEATURE_DBCONNECTIVITY is true
        
        to get calc to attempt to import a dbase file
        
        Change-Id: I22cc0b69f785f1194feabff2eb88b86cde6eb6b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [a2a3141e377efc617a12bd7591a12f4d7323e4fb]

        need OSDBCDriverManager if HAVE_FEATURE_DBCONNECTIVITY is true
        
        to get calc to attempt to import a dbase file
        
        Change-Id: I177b41504cb42e5ba3ced799698d5f77305102d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8d2fa176a15a7ae76d6a4b76aea5f108313c2ec]

        reduce copying in drawinglayer
        
        by passing PrimitiveContainer&& around.
        
        There are lots of place where we were preparing a local variable of type
        PrimitiveContainer, and then copying it someplace else, then throwing it
        away.
        
        Change-Id: Iacfd983640c9e55da25800ccc01734dfc8b4d64a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [e1600348e49e1538459a0374fd97cd3173d4a4b9]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: If398e3725b691491e51e49eadeb37a7fdaad63db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [c183a6eb292b31c7fb24f751630960f2035353c5]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I083ea9ef7b04322d60ce29b7e1610332a4709493
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122553
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [5c30291e8672cbdd3e61f3c6b18444da2d959024]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I4bca43340ab530b8d12b91968a7e7184b894776d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [abc0b90d7fe05c00e17251f3215b1f007813edb4]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iaea62f964593209e8df46127b363651737efde1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [9c04a7692bd3f7b7676b5109e949f2e8fe4297fe]

        some prerequisites to use dbase import with config unavailable
        
        Change-Id: I0a7f32a69112d7ce9ffc39481154c9da346c8d24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122544
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Caolán McNamara  <caolanm@redhat.com>  [cea0753e18171bf9bcdd857535b20e6ed02222f5]

        do some sanity checks on the number of records claimed
        
        while retaining the fix of #i83401# to recovered a broken case
        
        Change-Id: I283c45b10aaa24004a34bfe6faee517d4a443b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122543
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-24  Miklos Vajna  <vmiklos@collabora.com>  [4ff91bb2065b6a603f2fb8692c81911f0cdd58a8]

        sw: handle mbGlblDocSaveLinks when replacing compat options
        
        This controls if the content of linked sections is saved in a
        master/global text document.
        
        Change-Id: I104dfef9d16278f4cce7e6f7942c8f4b2bdd5134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122541
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [044fa30a4c77013c87a7e2a6dd9022a2f6599778]

        no need to allocate this SfxItemSet on the heap
        
        Change-Id: I973d6ef5d3ddcb1b3cd0506c59ee63411e80a4ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122539
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Noel Grandin  <noelgrandin@gmail.com>  [d21a1d999f8872f22a96ad7d1dc2f0e3b48421b5]

        no need to allocate this OUString on the heap
        
        Change-Id: Iea9afe291e9dbf964bf1577818ce1a44058eb943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122538
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-24  Jim Raykowski  <raykowj@gmail.com>  [2be1605cdab5e3662ea0180fb607f3968cc8716c]

        Fix outline folding when table or section node is the next node
        
        after an outline node
        
        Change-Id: I117b3f6253d5b64b3fc1b28f4b8a3e595c44abef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122547
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [1516711eb7861a08cc9fd19ec867360737a6d070]

        check if headersize is greater than available data
        
        Change-Id: I5d78da49436c7dfbe7cfb50e52549b61abc00ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122542
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [ebe57117c470a87a6b4201537616bd1379257c02]

        leaks of OCollection in dbase import
        
        presumably since...
        
        commit 5c7b954935369cbbd22a6f43be63ac7c0ddbbfdc
        Date:   Mon Jan 29 13:28:44 2018 +0200
        
            loplugin:useuniqueptr in OTable
        
        OCollection has a unique and nonstandard acquire/release which forwards
        to a parent cppu::OWeakObject. So when it would appear to a casual
        observer, who assumes that it has an internal refcount, that its
        refcount would drop to zero and then get auto-deleted, nothing of the
        kind occurs.
        
        Change-Id: Ic292663a61b4d7dbf7636be7ad4c00aed0b5a7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122528
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [262bfd71808b53f008b8ab3307d62ddc5e2b88a1]

        check claimed number of records against max possible with available data
        
        Change-Id: I50d9354da00137c64c83970eb66792b37d7e545a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122536
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [fe7577d0c79723cda59558522732145e8d831dc0]

        add some basic dbf files which should succeed to import
        
        Change-Id: Iedd8bd9c05dcce7e5c891664aea5d65ed408d87d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122537
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Eike Rathke  <erack@redhat.com>  [f7d0c6b42a0a5ec98876006cd5048589219be741]

        Sort ZF_STANDARD_NEWEXTENDED_DATE_... into ZF_STANDARD_DATE category
        
        The legacy of binary file format compatible internal indices is
        gone so categories can as well be enlargened. It doesn't really
        matter, just a "nicer to see" sequence.
        
        Change-Id: Id20e08e8564a281859164d44e2e863e46689b2b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122540
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [11ddd00117ad9dd4434b5e057d992f1a2eab49a8]

        EOF isn't an error from SvStream::GetError perspective
        
        Change-Id: Ib2bc2c35d78d92728d592676def300e28a8b9e2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122534
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [259a1365ff9a730b0e2929d027a81ca5ebcb3c67]

        don't looks for dbt memo files when fuzzing
        
        Change-Id: I483606a36d8a91fe7af73f1c6dba740b2475e95d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122533
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [36940a6506d72b91e6f9fc33ec42b57058ebc5da]

        dbase import seems to require that the file end in .dbf
        
        Change-Id: I7c5a3f6e9d8368e780c50626ba7457999389f19f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122529
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Miklos Vajna  <vmiklos@collabora.com>  [00fa364a2403dc23a786d3f91fde06e10b3a4a9a]

        Related: tdf#144091 svx: fix interaction of transp cell fill and transp shadow
        
        This is a follow-up to commit 37a52d30bbfcf1d073779b50139c4dafa507be4b
        (tdf#144091 svx: fix unwanted blur of shadow from table cell fill,
        2021-09-20), where it turned out that the original bugdoc was just a
        special case of almost full transparency (80%), that's why avoiding the
        blur fixed the problem.
        
        A more general approach instead is to multiply the alpha or the cell
        fill of table shapes and the alpha of the shadow itself. The end result
        is the same (80% transparency) for the first bugdoc, but this gives back
        the blur on the second bugdoc.
        
        Change-Id: I63560e3a73473c70157ecee8365ec7154217f269
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122532
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-23  Eike Rathke  <erack@redhat.com>  [c8d66a4d53acf1b0c0de45335015b72ee72cd0fd]

        Reorder the internal ZF_STANDARD_DATETIME offsets to a more logical sequence
        
        These once were to be strictly kept for the binary file format but
        nowadays only serve as a position / key index offset within the
        numberformat map.
        
        Change-Id: I7c61852cc26463b1d4d67a6152501d521440abe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122530
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [14713f91393abe4ec76ad28bdc45eaced943cd72]

        loplugin:stringviewparam
        
        Change-Id: I3fc029e2691026bcd315a807e90290d763146648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122526
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3f5610feb68fc94f9a8f58ee48fac4fbf687b506]

        tdf#143103 Fix hexpand of color button
        
        Change-Id: I6bdeb1dbe0aaa7ff2d1b65486ad326079da40e7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122521
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-23  Noel Grandin  <noel@peralex.com>  [33584bc189235b2e0f263cade9f9d759d29448c9]

        tdf#144132 Crash when insert formula object in Writer
        
        regression from
            commit ec01d43e0a8fa560d7cd8c76c0d609b18a60cddb
            Date:   Wed Jul 21 14:24:28 2021 +0200
            pass SfxChildWinFactory around by value
        
        Change-Id: I88bc6c8bfd35d0a653512b064c9ee0d59b1e8b38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122520
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [85ef14318897f6e32c4987ab9d76c38a9752da24]

        memory leak on loading dbase files
        
        see on loading qadevOOo/testdocs/BasicDB/DBTest.dbf
        
        a problem apparently since...
        
        commit a245e5c60fac58889738a9705225c6378b35eef4
        Date:   Tue May 8 12:42:55 2018 +0200
        
            loplugin:useuniqueptr in ORowSet
        
        OTableContainer inherits from OCollection which has a unique and
        nonstandard acquire/release which forwards to a parent
        cppu::OWeakObject. So when it would appear to a casual observer, who
        assumes that it has an internal refcount, that its refcount would drop
        to zero and then get auto-deleted, nothing of the kind occurs.
        
        Change-Id: Ib104415ccc13c6ed9c06f975857fcd4413e2e05d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [238b6cf0ff0d66d57bea9e8dc38d93caf4563124]

        WB_DEFAULTWIN should be sufficient to flag that no icon is required
        
        Change-Id: Ibb5d8331d5d47e2b5c163c2797b2e7b5cee4b285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [e6c1205e3e041407e875301de08a90989353cf63]

        gtk4: fix build
        
        Change-Id: I6bee4180ea2d91a2917765bc1934a8403b72c07e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122513
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [fdce0a04bd8b23200631e09979b3880adf754b2a]

        Extend loplugin:stringviewparam to starts/endsWith
        
        Change-Id: I4b8fb5e963e582836440587dcaa2922cb5d05bc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122512
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Tor Lillqvist  <tml@collabora.com>  [6b6400d72fe4112b230ffe31b9bea7d2a7f2f9f4]

        Look for the udkapi types.rdb file in the right place when cross-compiling
        
        Fixes cross-compilation to iOS on macOS.
        
        Previously is was looking for
          instdir_for_build/LibreOfficeDev.app/Contents/program/types.rdb
        
        The correct location is
          instdir_for_build/LibreOfficeDev.app/Contents/Resources/ure/share/misc/types.rdb
        
        Now it is possible to build the master branch for iOS again. (No idea
        whether it works.)
        
        Change-Id: If5b09c77601b5a5136c26e1d383654a85b6cc795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122516
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [aeda71b3cf3aa4393b8367437be29c1722f97d4d]

        Related: tdf#142704 ReadStringHook may not be set in testing configurations
        
        Change-Id: Iab2cd0cccb781a39af7b9315ccf8c242a2cc49a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Aleksei Nikiforov  <darktemplar@basealt.ru>  [9b4478e62c712ef0f75c4a001e260dfdd6b3ca4c]

        tdf#144624 Prevent infinite recursion when loading SVG icon
        
        When Generic/X11 VCL backend plugin loads SVG icon,
        it creates virtual device for rasterizing an SVG icon,
        which in turn tries to load an SVG icon,
        and thus infinite recursion happens.
        
        Change-Id: I7559b6255e6718e64ef4a6e7c79d597375e5823a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [0044349b4617d90419113d0fea6be5b53c429fc4]

        allow entry-text-column and id-column
        
        as later versions of glade write by default
        
        Change-Id: Icb26774553fb8c6bbb1399e3503bd0b6237767ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [ab6ea962bdf54d1ba7f9be368daf186f9c829ca3]

        Adapt solenv/flatpak-manifest.in to recent download.lst changes
        
        Change-Id: I3d97bbc023dee481420cc1fda8f36f4d3f6364fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122510
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Eike Rathke  <erack@redhat.com>  [cda7dff78a113a18cdcc23274454cfef982a17c2]

        Add not-quite-ISO date+time with space and milliseconds and locale's separator
        
        NF_DATETIME_ISO_YYYYMMDD_HHMMSS000
        YYYY-MM-DD HH:MM:SS.000
        
        Users may expect to see that if they enter such, instead of the
        real ISO 8601 "T" format.
        
        Change-Id: Iad81750d1c74eedd8d4360163b29ecac98ef6824
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122502
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [77b23d1b5979ce65058f845f73cb48894ba68325]

        Extend loplugin:stringviewparam to starts/endsWith: cpputools
        
        Change-Id: I016ca2ecf63d62d7799db1098ba0455e337aa3eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122507
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Pierre Marty  <pmarty@linagora.com>  [5bcced4776bb73846ef4f98795e217e4fb923e40]

        tdf#141978: corrects the value assigned to AutoLayout while loading .odp file
        
        	SdXMLPresentationPageLayoutContext::endFastElement(sal_Int32)
        	  now assigns the value AUTOLAYOUT_TITLE_6CONTENT
        	  instead of AUTOLAYOUT_4CLIPART at file loading
        
        Change-Id: Ic441d64fc62e1dd08873305a4cafd9823babe46f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-23  Julien Nabet  <serval2412@yahoo.fr>  [9f8ec7fb5751e3e120d0e09466b006085cea13fe]

        Related tdf#144618: add check in bin/ui-rules-enforcer.py
        
        + fix vcl/qa/cppunit/builder/demo.ui
        
        Change-Id: I556cf99687f138e2d9667dc742dd44cafe7b1a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122488
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9bf1d13ce76520a032b7986a3d9a31a3a6a4220e]

        Removed duplicated include
        
        Change-Id: I437754f53c45965ec6026a6ce21ea3e67528f732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122411
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2e1ea21c42df4d295f12f2c5b0c0e78afa113888]

        Removed duplicated include
        
        Change-Id: Ifa2276fae35818f759f51a22b5c873130d885459
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122495
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-23  Caolán McNamara  <caolanm@redhat.com>  [5ff06d5e385a0ea30a427e3e6ebb7c605dbf984b]

        dbf filter needs a physical file
        
        Change-Id: Ia522fee21edeafa419c173606ebaac0667d264fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-23  Noel Grandin  <noelgrandin@gmail.com>  [672dce81178dc1b4b6ad54f2b5d922ee806acf91]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: Iefa9cb88eaadb4535bbbe59a939b9773d81a438d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122487
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [bbcb3e68c75d9eb7da36788def8845a3e3e727f8]

        Extend loplugin:stringviewparam to starts/endsWith: connectivity
        
        Change-Id: I10a6f919034a83d134c92f3c510641c10c7c133d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122506
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [7c2c5400cb1726112165482cc6074a88351edfae]

        Extend loplugin:stringviewparam to starts/endsWith: cui
        
        Change-Id: I96bbf66fa62784f0a4de61b627d6e21b665a4edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122505
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [2e088bf71767849e99070d576fb300c244bd6475]

        Extend loplugin:stringviewparam to starts/endsWith: dbaccess
        
        Change-Id: I30e48b7ebf3795659638d7a2aedfb58e325cea37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122501
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [09fc31370252a09dd8affda0b0c743133e023244]

        Extend loplugin:stringviewparam to starts/endsWith: desktop
        
        Change-Id: I42fa4d25eca6b2c5d14212eca3a6ebc7146cce5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122500
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Jim Raykowski  <raykowj@gmail.com>  [e43eeac1a99ea0d70192dfd7cecf3e8f52f3e53c]

        tdf#95378 Writer Navigator: Track indexes
        
        Resolves indexes tracking part of the enhancement request. Makes
        corresponding table of content entry, listed under Indexes category in
        Navigator content tree, highlight when current cursor position in the
        document is on table of content type section.
        
        Change-Id: I8237bc55db5568e585b25f898935b4506dec5c7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122503
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-23  Miklos Vajna  <vmiklos@collabora.com>  [8cecaa622700cecb5b5776bd3e5360ac6cc3dd63]

        external: update pdfium to 4643
        
        Change-Id: I4e86b163a9abef88f26c6c0ae91ae0a4008658f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122485
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e752ce56b51c832dbea1e7f20e3b6671d99df990]

        Fix color filter popup position
        
        popup was wrongly placed when dropdown was not in the first column
        
        Change-Id: Id7170df233148564cba2fe2d498194b9e2b0161f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122396
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-23  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [0b810cc0f04241e644c82ba8bdad6a075b964118]

        tdf#144631 Colibre: sync up query/sql/report execution icons
        
        Change-Id: I52cfa4aa52f0bc03accb1030d463893ee871cdab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122504
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [4706eb93350b2613b1fe6b98afa1243415c40577]

        Extend loplugin:stringviewparam to starts/endsWith: idlc
        
        Change-Id: Ib9c97576746b6acfddeacec658a2ae994aa28516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122497
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [310d43b9a27efc36f2c9e6737a0b5ac3f211bda0]

        Extend loplugin:stringviewparam to starts/endsWith: extensions
        
        Change-Id: I29c3a09628f213d8b229a981d62421390385c54e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122499
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [047a983314b560e0f64280ae2ac7d696d90d539b]

        Extend loplugin:stringviewparam to starts/endsWith: l10ntools
        
        Change-Id: I2c8c8e0fb034f79bb844a1d09defc3227324e686
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122494
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Stephan Bergmann  <sbergman@redhat.com>  [cb3058aa4e3155d97d47d1444b808da7297b5794]

        Extend loplugin:stringviewparam to starts/endsWith: framework
        
        Change-Id: Idc92058e7d2ff63d55e97e6b2fee83314fc0334c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122498
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [84e61754bfe2f07de412c24513774900702a48a2]

        Fix typos
        
        Change-Id: I01c46b864e296d4094f0a1579fdc64066eacc386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122496
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-23  Luboš Luňák  <l.lunak@collabora.com>  [362d2271721dd19de7a7f6f2271a349272ce51d8]

        add some unittests for SwRegionRects
        
        And fix two small bugs in SwRegionRects::Compress().
        
        Change-Id: I8df7cc2e9d4d6ca78e3af711639e3fbae2e471ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122462
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-23  Luboš Luňák  <l.lunak@collabora.com>  [05f5c12da968bd53337e832805894c048aad2c6c]

        put vcl::Region operator<< in the vcl namespace
        
        Clang says it belongs there when vcl::Region is used
        in CPPUNIT_ASSERT_EQUAL.
        
        Change-Id: I457d7b35e9b2ca37909118467da8018d40ab18a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122461
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-22  Jim Raykowski  <raykowj@gmail.com>  [8644a3114d412e8de6cc6712c2f2bcad436906c9]

        tdf#95378 Writer Navigator: Track references
        
        Resolves reference tracking part of the enhancement request.
        Makes the Navigator content tree highlight the corresponding
        reference item of the reference field at the current cursor
        position in the document if there is one.
        
        Change-Id: If10d0cffbf03fcc9a61e573e967e854c428f9b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122414
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [3b6dd54994ab1e624729cb007a8e3dc2b5f3b891]

        Extend loplugin:stringviewparam to starts/endsWith: sc
        
        Change-Id: Ibda7acf66bd8382de25fae9b4385d655be6ab409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122490
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [fcdfdc21b197bb9af1a75348ce912c5d1d47dfba]

        Extend loplugin:stringviewparam to starts/endsWith: oox
        
        Change-Id: I02b4352f02fe32f40c4fe0ab198d8ac094381c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122491
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [f8b6d1a2f48ce259ba2e75d41777293dfe23ab11]

        Extend loplugin:stringviewparam to starts/endsWith: lotuswordpro
        
        Change-Id: Ia58c031d1157af271c664948946fa5d8d17a2323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122493
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [59646d3fa4fab037ccedc7ebe765de11d5016f3f]

        Extend loplugin:stringviewparam to starts/endsWith: editeng
        
        Change-Id: Ic275bbd167e69060f6442ceed6c4dd88733d5e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122486
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [2dd6c7e5d59126e28bf478439c25f9f4cbc3422c]

        tdf#142579: sc: Add UItest for cond. format background colors
        
        Change-Id: I81845c062783d59f1e3b9c612da938de42f2a50a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122463
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [0a4c883a7e0dd3ba66d8cc86c6f77bd3578a0a92]

        Extend loplugin:stringviewparam to starts/endsWith: sd
        
        Change-Id: Ie7ddfbc7984bfbff22c8c34e30f3ca690da80e7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122483
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [51c9d41ca97955dd986cd5fec1aed6fbc6ec1374]

        xtend loplugin:stringviewparam to starts/endsWith: svx
        
        Change-Id: I998b5e7ba3580aabfc454ce3354bffd3d0cb7d61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122479
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [3ead1e624514466811d451325d02acd50862c80a]

        Extend loplugin:stringviewparam to starts/endsWith: scaddins
        
        Change-Id: I4e6d9d8f429e9a9133a494790522217638ad18e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122484
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [ea29e9936a3e628f95ca4ae1d5816adfce87318f]

        Extend loplugin:stringviewparam to starts/endsWith: sfx2
        
        Change-Id: Icac2c5877059208ed348aa824071803e415f374f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122482
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [8f2f2a8d131eef60164c0586fb73b69fd950f15d]

        Extend loplugin:stringviewparam to starts/endsWith: svgio
        
        Change-Id: Ia48465b86e6b2e5362b95a2b228414bfc6ac6490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122481
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [49cee95eb4efddefde9caab33d0a639e83f05202]

        xtend loplugin:stringviewparam to starts/endsWith: svtools
        
        Change-Id: I5364107766dd77963a9a34468754c4cbcc34c8d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122480
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [27f3618a600006e59d6b45e22f0eb46457172a52]

        Adapt to Clang 14 trunk change in diagnostics
        
        <https://github.com/llvm/llvm-project/commit/131e8786640a49daf533b7ead4d3b5b82e0aea2a>
        "Print nullptr_t namespace qualified within std::"
        
        Change-Id: Idb3ebceadfa5a831429b8c3239de426e599eb9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122459
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [c9b19f69e658f1114f1b8fc0ae62b6edd6d33e3f]

        Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tips
        
        Change-Id: I61d8b83ce326816c498f54e3cfc053270d82c1a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [7885c1cb80568930270e55b3ae450eccc66aca94]

        Extend loplugin:stringviewparam to starts/endsWith: ucb
        
        Change-Id: I086d02ec4a2ea6d4b439ec34665d8271a67c63dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122472
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [d1e14030e81ff2bbe4bcb3706a9f21672a368074]

        Extend loplugin:stringviewparam to starts/endsWith: sw
        
        Change-Id: I7271bba6c61a56be15335c81d8950a29a07eb6d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122473
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [743e6aa211ccd631c811fb57e2050a5b4e8ffbba]

        Extend loplugin:stringviewparam to starts/endsWith: unodevtools
        
        Change-Id: I89e559d3956bb0b4b59314d55a3ca57d087b8146
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122471
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [924e0774a8201651a762394d51a964a4f8a0c566]

        Extend loplugin:stringviewparam to starts/endsWith: xmlsecurity
        
        Change-Id: I8a08b0382121355c70284c2e85375ba6c3671553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122468
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  László Németh  <nemeth@numbertext.org>  [dbc82c02eb24ec1c97c6ee32069771d8deb394f9]

        tdf#143358 sw: track insertion of empty table rows
        
        Insertion of empty table rows wasn't tracked, and
        inserting also text in the new rows and rejecting
        everything didn't reject the row insertion.
        
        Follow-up to commit 99059a1ececa3621c2fe46fabdd79eed9d626c42
        "tdf#143359 sw: track deletion of empty table rows".
        
        Note: as a workaround for tracking of the empty rows,
        i.e. rows without text content, add a redline with
        invisible text CH_TXT_TRACKED_DUMMY_CHAR in the first
        cell of the empty row.
        
        See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
        "tdf#143215 DOCX import: fix tracked empty row insertion/deletion",
        commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b
        "tdf#142701 track changes: fix layout regression of image deletion"
        and commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I237d566a468f61f31fa19dd1d6d9bb559be99158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122460
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [c638bcc78cfa3974b7461096b6ac521dfc5e927c]

        Extend loplugin:stringviewparam to starts/endsWith: vcl
        
        Change-Id: Ic208697fd985da223819d203e67325b03028fca5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122469
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Stephan Bergmann  <sbergman@redhat.com>  [8d65f68f98950efe7cb117d7ad228bab79ad0ddb]

        Extend loplugin:stringviewparam to starts/endsWith: unotools
        
        Change-Id: Ie8c73d187045d9def8f462ab7d37830331eabd4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122470
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-22  Michael Stahl  <michael.stahl@allotropia.de>  [805cc60039fcce2ba356430cb90811a6e300a540]

        fix crash in compilerplugins/clang/unnecessaryoverride.cxx:328
        
        Somehow the compountStmt doesn't have anything in the body?
        
        Happens in CurlSession.cxx but not sure where.
        
        Change-Id: I69bd2e694e22c891f34242b8bee28012e793f0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122457
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-09-22  Miklos Vajna  <vmiklos@collabora.com>  [4cf51357b75c254e7962dd86140c69474fff129f]

        svx: improve SdrObjEditView::DisposeUndoManager()
        
        Addresses the comment at
        <https://gerrit.libreoffice.org/c/core/+/122151/1/svx/source/svdraw/svdedxv.cxx#2765>,
        i.e. there can be the case when the undo manager is not an
        sw::UndoManager (or any other high level undo manager), but it's an
        EditUndoManager, and in that case we should not clear away the owning
        pointer to avoid a memory leak.
        
        Change-Id: I016cfad0563814d65c8523999c82be7747377171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122458
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-22  Luboš Luňák  <l.lunak@centrum.cz>  [6507eddc33332d760c8807633268558c47e8cb06]

        avoid some more D9025 warnings
        
        Change-Id: I01f8df5f399b17f46da9a59501bea28bc70cac4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122431
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [9df17d12a0e069d0a0db262368abc153b92169a0]

        fix deadlock in vcl::GraphicManager
        
        after
            commit 300753bf1d4db7eff42d707f427180f0d1d1dffb
            no need to use recursive_mutex in graphic::Manager
        
        Change-Id: I85b6f83d513ea1998e1bd7c3be5cea999c590c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122426
        Tested-by: Jenkins
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [b25beb5c331ce1eb8cc6a4ba845d480e606f9345]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d9db89cb1d9e2beb64672b55f200e24da405670
          - tdf#144559 Fix information about document encryption
            
            Change-Id: Ibadf9946d144fc9573d6cbfa2f4abdc8d56721ba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122283
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [1901cc1169660c50fc651c68861bdb022d931da4]

        don't link to vbahelper for --disable-scripting case
        
        Change-Id: I50dca4c11234677d2c6987d360b1317890b5484b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122427
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Tor Lillqvist  <tml@collabora.com>  [a542f9f4f7d1cc4a499f260209c70f086322c26c]

        Apparently we need to define gb_Library_PLAINEXT_FOR_BUILD for iOS
        
        Helps a build for iOS proceed a bit further.
        
        Change-Id: Icb0465eb204effbc0b777b5066d40d9938924eed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122421
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [454d5f846a8c5b7e87aad6000555b3066c3b4bbf]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iaa7f59fbc412f3d5e4d6e4793d7a4459f6a03c8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122424
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [6a20b266a6e2cfc46f4fd03a4955199ed16b5bce]

        lock older -> lock order
        
        Change-Id: I50d2a73e6b95516f421fb71028af67fe116949d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122425
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [d993bb6e77d9e94abeb487a24084d34b6605f730]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7c514aaa500e14794d0fc7aad2def695fb6a6420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122423
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [4e4fffb037a99bd801f26e39eabd4d3d43771638]

        drop comments about disabling optimization
        
        which are 10 years old
        
        Change-Id: I9645cd4e227d089ff97852fb18b25d5ddaf12b28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122422
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Julien Nabet  <serval2412@yahoo.fr>  [876b58e7030b2a24eca5464bb172bdd0b45c8546]

        Fix Skia/Raster description
        
        See https://bugs.documentfoundation.org/show_bug.cgi?id=144598#c16
        
        Change-Id: I5a39fbc324af0944560e91d4249ab572e5579af1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122404
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-22  Mike Kaganski  <mike.kaganski@collabora.com>  [657ec7ff6863ebc79dcea228898b619d43543a6c]

        tdf#137737: treat foot/endnote anchor as a "normal" (control) character
        
        The anchor uses Unicode codepoint U+0001 (START OF HEADING) internally.
        It was removed from start and end of the search string (but not from
        the middle) previously, and only when the character appeared inside the
        search range; before 0cd3b7926cafc01d06b589124215e9cb7c148f19, such
        anchors outside of the range were ignored in TextSearch::searchForward.
        The said change made search consider the data outside of the range for
        context (e.g., look-ahead/behind assertions), and then the asymmetry of
        removal when the range includes or excludes the character started to
        affect the "replace after find" case, when initial find searches the
        entire paragraph, and removes the anchor character, then finds '"$' and
        selects the quote before the anchor; then replace uses the selection as
        the range, does not remove the anchor, and it prevents the match.
        
        This change excludes the anchor from the set of removed characters. Now
        the foot/endnote anchors always stay in the string, and make the "find"
        consistent with the following "replace" by preventing the match when
        there's no [\p{Control}] (or [:control:]) in the regex explicitly for
        the anchor. This allows for more flexibility in search, and makes it
        more consistent in making this visible element participate in search.
        
        The other elements that are still removed:
          RES_TXTATR_FLYCNT,
          RES_TXTATR_FIELD,
          RES_TXTATR_REFMARK,
          RES_TXTATR_TOXMARK,
          RES_TXTATR_META,
          RES_TXTATR_METAFIELD
        need separate consideration. Some of them may be also excluded in
        follow-up commits; the other need more correct removal (both when they
        are inside and outside of the range; also in the middle) to create
        consistent results when searching/replacing.
        
        This change also makes sure that ReplaceBackReferences uses the same
        special preprocessing that DoSearch uses.
        
        Change-Id: I87195508695eef9fe379df369d6fef3ca1dffafb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121134
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [58418e9a85a007f550d9deb02729fc0c96cc1efd]

        reduce copying in BufferedDecompositionPrimitive2D
        
        Change-Id: I2393c45c064ea423b7ea1b70e1f16e1a4cea2bef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-22  Julien Nabet  <serval2412@yahoo.fr>  [41ccb5c63c94e54b07707eca62bed761c87b0d10]

        tdf#144618: fix Standard Filter Dialog with gtk3
        
        See bts here:
        - https://bugs.documentfoundation.org/attachment.cgi?id=175150
        - https://bugs.documentfoundation.org/attachment.cgi?id=175151
        
        Change-Id: I4954d989a25fb228624d9b4660f357219d160ead
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122409
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Tor Lillqvist  <tml@collabora.com>  [355072f973e57c6e6ebdbcc906aefe260237694c]

        Bump minimum iOS version to 13.7
        
        Change-Id: I96861e8f503c95ae3b76d5ab79a0035b5307398b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122418
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-09-22  Tor Lillqvist  <tml@collabora.com>  [1e194b878545e3a016ec7adaf9ebfc2aa86eb48e]

        Bump current iOS SDK version and drop older ones
        
        Change-Id: I1eaebcbbe3f05b0e33efa4ca3fe79ced3d855114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122417
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-09-22  Caolán McNamara  <caolanm@redhat.com>  [7f5af8272d8b10bf56b82cbe9d898e8ed0a347ca]

        add a TestImportDBF
        
        Change-Id: Iddb0d69d2ffaafd81076cd52a8424c32fe3c4114
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122408
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-22  Dennis Francis  <dennis.francis@collabora.com>  [ba0851926a9def7577dcf7b29919de0632ac31a9]

        lok-desktop: unit tests for LOK_CALLBACK_TABLE_SELECTED
        
        Conflicts:
        	desktop/qa/desktop_lib/test_desktop_lib.cxx
        
        Change-Id: I4e07ffc6f8eebbbee284d19cd9c77df13dddff3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118945
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 56795f50abad3de960f23e85b2ccfa1ba0181370)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122415
        Tested-by: Jenkins

2021-09-22  Noel Grandin  <noelgrandin@gmail.com>  [8dda0309871b371e056c0c0f308203e2a8a0306f]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: I21b34386d3f2f408da329b0e5888566cbb126d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-22  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [743057da7a20d9eebad939f2baecb1e225920b56]

        Improve UX writing on Start Center
        
        Good UX writing shouldn’t try too much to explain an UI,
        and directional language like “from the left side” doesn’t
        make sense for users of RTL languages or screen readers.
        
        Change-Id: Ibc5b6982d4686248de09ec1b2ad2a94b9b012f67

2021-09-22  Miklos Vajna  <vmiklos@collabora.com>  [b22cd6bfb10a2fe0407875e456708d6086accb81]

        sw: clean up no longer needed debug code
        
        It made sense when the perf improvement was added to see if the faster
        code indeed does the same as the old slower one, but now it can go.
        
        Change-Id: I45e05d51c2bac1e0d2df6fa1cdf1debe13dd21e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122401
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [5fc94be9d55791340a56f238ded12261f68af552]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 38c34032f737213ec166b80793fb1230e657975d
          - Fix localization in some help pages
            
            Change-Id: I59e2ea89dd81c76ee4efee6a154082a56289b524
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122289
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-22  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [1c745198ff4e84ae4ff91ba8cf571d4bb59fc9a3]

        resave with latest glade
        
        Change-Id: Iab955963735d14f97e1887cf06212b1adf3d77a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122163
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e7c83595d75d6287eff506112c1654a3a945d9a3]

        Fix typos
        
        Change-Id: Icd2f83bddcb993a6430d328d0bc51f38d70374ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122412
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-22  Jim Raykowski  <raykowj@gmail.com>  [d62f03d316fb4c60087fc2af626bbd0b35b98693]

        tdf#95378 Writer Navigator: Track hyperlinks
        
        Continued effort for request to highlight corresponding Navigator tree
        items at document cursor position.
        
        Change-Id: I21c6b45308c7de654dbf1f904c30336a6229722c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122338
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-22  Luboš Luňák  <l.lunak@collabora.com>  [bb09bfd25f25fb959123df1c01a52b8dffa97f50]

        make .pch file also depend on its source .hxx file
        
        This dependency is normally handled by either the .pch not existing
        (and so it needs building), or GCC/Clang output it in the deps,
        but MSVC doesn't seem to provide this dependency, so modifying
        the .hxx there doesn't trigger a rebuild.
        
        Change-Id: I83415d97b98b8861b3d53cba07c4ac2748e9f476
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122413
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e9b674a768fcf534335f172664aaf13dc2c79023]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77730780dfd1502994a413121842b23767882a25
          - Fix typo
            
            Change-Id: I06b1811deec9716161fe7aaf07ec31665e67fbf7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122410
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-21  Stephan Bergmann  <sbergman@redhat.com>  [b46894e7d063cc96609c8aaea76f4a7ffc5f170f]

        Some more o3tl::starts/ends_with overloads
        
        ...including ones with a rest out parameter, modeled after their O(U)String
        counterparts and not present in any C++ standard (so intended to stay in o3tl,
        even when the C++20 wrappers are eventually removed again).  Plus test code.
        
        These additional overloads will be used in forthcoming commits changing more
        places to use std string_view.
        
        Change-Id: Ifd05e0fdcb93e8751da22b8e4a59796ad00fe581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122407
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-21  Julien Nabet  <serval2412@yahoo.fr>  [58a67e6109a82a24620e179f6f660c1a231f1dd7]

        Typo: sparatorIndex->separatorIndex
        
        Change-Id: Ie43ef6b231c1cb6dd7be516f47e84c12b5684c40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122403
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [91798635258c2b1487f8265eff08633db4ec5ab2]

        qt5 a11y: Implement Qt5AccessibleWidget::is{Column,Row}Selected
        
        Change-Id: I2abfbc69a422a56dc07afd76f0c7a8ead1891830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122398
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [6735a37747a3443ebd1c29c870a5eb26990350f2]

        qt5 a11y: Implement QAccessibleTableCellInterface
        
        Let 'Qt5AccessibleWidget' derive from 'QAccessibleTableCellInterface'
        and implement the most important methods.
        This is e.g. one of the steps needed to make Orca announce
        the focused cell in Calc.
        
        Since there's no specific XInterface for table cells
        make use of the fact that a table cell's parent is a table
        and query information from there, similar to how the following
        commit does for winaccessibility:
        
            commit 97a88e30e2e084ab860635ff4e0a03442d8a12af
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Sep 8 14:37:53 2021 +0100
        
                tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell
        
        Change-Id: I160bc04f3e4fcf7b77723540aba6945b8fdf36ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122395
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-21  Michael Weghorn  <m.weghorn@posteo.de>  [0ae1c36f319b0c84d5e592f44738e67945eab3a1]

        qt5 a11y: Drop Qt5AccessibleWidget::{text,value}Interface
        
        They're unused and at first glance look like they might
        be overriding the non-virtual methods
        from 'QAccessibleInterface' with the same name that
        do something more useful (calling 'interface_cast'
        with the corresponding 'QAccessible::InterfaceType'
        param).
        
        Change-Id: I9258a5f9386f9a7d23bb35cfa33e55a169eb753e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122394
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-21  Eike Rathke  <erack@redhat.com>  [508f5b7767210318f1a23efc6db928c87a5eca6f]

        Add ISO 8601 date+time with milliseconds format
        
        NF_DATETIME_ISO_YYYYMMDDTHHMMSS000
        YYYY-MM-DD"T"HH:MM:SS,000
        
        using either ',' or '.' separator,
        '.' if Time100SecSep is '.'
        ',' else
        
        A prerequisite for tdf#88359 to not lose data when importing such,
        especially without "Detect special numbers" on.
        
        Change-Id: I02ab682636e6ddbcc4537183a3625ea61662f016
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122400
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-21  Eike Rathke  <erack@redhat.com>  [e430d82ec56f34fb5ae45a50eb12cd03c7e40ba3]

        SvNumberformat: preserve error position if already set
        
        ImpSvNumberformatScan::ScanType() may already return an error
        position in which case FinalScan() is not executed but
        nResultStringsCnt is set only there and otherwise 0, so after
        ScanFormat() force a different error position only if both are 0.
        
        This in the dialog positions the error selection correctly instead
        of after the first character.
        
        Change-Id: Icb87b212fe8465da8f885514ffa3a3ecc7cd69a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122399
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-21  László Németh  <nemeth@numbertext.org>  [915d3eebc1dc4f18d7a1992db801ee8313ee46c0]

        tdf#39828 sw: fix table formula calculation at track changes
        
        Tracked deleted cell content, e.g. removed digits
        of the numbers were used in calculation instead of
        the actual table content. (For example, if the cell
        content changed from "1" to "2", tracked cell
        text is a crossed out "1" and a plain "2", and
        Writer calculated with "12" instead of "2".)
        
        Change-Id: Iecc91585cd37be3647d85f97ba1716a5fc836242
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122393
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [eecc72b2d13c4dead2ec6289de9754542292426c]

        add comment
        
        Change-Id: I0f9627d0d573c5a5bade00f40dea2d0f1b518528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122391
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [300753bf1d4db7eff42d707f427180f0d1d1dffb]

        no need to use recursive_mutex in graphic::Manager
        
        regular std::mutex is fine
        
        Change-Id: I820bb83117a0ea920f550f6ad459a623b4939ee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122390
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [19d638eaedf84cefadf55d561c3c36df33fed6fe]

        reduce cost of BasePrimitive2D (tdf#125892)
        
        the default WeakComponentImplHelper wants to allocate two child objects
        (osl::Mutex and BroadcastHelper).
        
        So use a custom re-implemenation that does not need to allocate any
        child objects.
        
        Change-Id: I288e58558398e39daa0d4b11e0b60a924445240d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122381
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ba0460e3cf3ce33794090968fd4c906422bbd25]

        tdf#142579, tdf#143103: sc: Add UItest
        
        Change-Id: I2bc3eabeeb23534d985649c4191798ca9281b7e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122389
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e2e1da3cc89942443832ea018ced68eb41e3d75a]

        tdf#142580, tdf#143103: sc: Add UItest
        
        Change-Id: I188716de98e6a9ea1c2b97c6341d578120a242b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122388
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-21  Stephan Bergmann  <sbergman@redhat.com>  [1d4f198f176cfb5816b76ad67b6c0df39419f0cb]

        Fix splitting of "permission-for-group/-user:" strings
        
        ...that had been introduced in f5c266695a4a88da7db971a21915e2bbf758d48e
        "tdf#66398 Parse and output permissions for DOCX using bookmarks":
        
        For one, in DocxAttributeOutput::DoWritePermissionTagStart permissionIdAndName
        was left empty in the permission-for-user case.  This had already been addressed
        for DocxAttributeOutput::DoWritePermissionTagEnd in
        7f0b7410e84a222d8fbee7c4fadd3b40028a068d "permissionIdAndName is empty in
        permission-for-user case".  But from the calling code it looks like in both
        functions that permission will always start with either "permission-for-group:"
        or "permission-for-user:", so assert that rather than silently doing nothing if
        the assumption is wrong.
        
        For another, in both functions the code didn't take any precaution if
        permissionIdAndName didn't contain a colon (which would cause undefined behavior
        when OUString::copy is called with a negative count argument).  Again, from the
        calling code assume that permissionIdAndName will always contain a colon, and
        assert that.
        
        Change-Id: Ia7432413c138d47efbe8aec76f14c561ac241fb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122387
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [96ff90857a066da70b04684f71237056e12eddfe]

        reduce cost of some getProperty calls (tdf#125892)
        
        use OUStringLiteral to avoid cost of repeated OUString construction from
        ascii literal
        
        Change-Id: I4f8a4714c093e890adaa5524172bdc91231a561a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-21  László Németh  <nemeth@numbertext.org>  [9994120c8d0fe8c5a029390ad7411b99c18ff5c9]

        tdf#144347 sw: fix tracked deletion of table with tracked content
        
        When a table contained tracked content already, its tracked
        deletion (or cut) didn't work correctly, if the deletion
        contained also the text before or after the table: accepting
        the deletion left an empty table in the text, also Hide Changes
        showed an empty table before that in the place of the deleted
        text.
        
        Follow-up of commit f481c2c8e74bded11fac754e493560391229dbcd
        "df#144057 sw track changes: hide deleted table rows".
        
        Change-Id: If3294fe0316df7c065e7ff63290c1723386ec7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122382
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-21  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [504808fb5c372a94c6299eec90a281655eef47e4]

        tdf#142602 DOCX: export adjustment points of custom shape arrows
        
        When exporting custom shape arrows LO used to fall back to writing
        out their plain vertex coordinates, losing the customizability of
        the shape after loading from file. This commit changes the export
        of some of the most commonly used arrow custom shapes to proper
        adjustment value export.
        
        Follow-up to commit 63cd67e5e18f01aca303131e148c80398a181a41
        "tdf#92525 tdf#142398: fix export of simple custom shapes".
        
        Change-Id: If248556764bdb7e00cfde4ebe5b32bb380b1fa19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121901
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [e0c7d1e4cf7e6cf73211e69a91f458e6ffe303cb]

        stack allocate this TextLayoutCache object (tdf#125892
        
        Change-Id: I838543c47ec420ec3b562e0b7e8524c4b2f070a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-21  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [ca5e344aec6a5848831101bc0d623b2bac754b6e]

        tdf#127900 sd: fix regression at applying master properties
        
        Language settings of frames in slide master weren't applied
        on the slides based on that master.
        
        Regression since LO 6.3 by "tdf#126067 Fix slide scope
        feature." (commit 40bb9ac690d979ef544d5aa759bd734a176912a0).
        
        Co-developed-by: Dániel Arató (NISZ)
        
        Change-Id: I559adbe00870ed8a3d2947fef8dae435a387e34a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120993
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-21  Caolán McNamara  <caolanm@redhat.com>  [061c7e3994eb5288e95d7fb0ce7a1bc0f54205ed]

        fix !HAVE_FEATURE_DESKTOP build, IsOver->Overlaps
        
        and change some commented out cases
        
        Change-Id: Icc60b19de7d12a78e7d40e7aa94dae40dc8b60a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-21  Balazs Varga  <balazs.varga991@gmail.com>  [51375b48378915b6e95c1ac26b2ccf8e39880f7e]

        tdf#144253 tdf#144324 sc filter: use formatted values in filters
        
        if the results of formulas are values.
        
        Followed up of 40acda4e78127fa9f513646ef210b074d40cf307
        (Related: tdf#140968 avoid duplicated filter values)
        
        Change-Id: Ib396d2b7cc08ba41b5936a53a28b5e38bf678b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121715
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-21  Luboš Luňák  <l.lunak@centrum.cz>  [9714f3348d972a179e73423c44a97954bf6cc534]

        do not special-case Clang for Skia on Windows Arm64
        
        We hard-require Clang for Skia, because MSVC compiles it poorly.
        Somebody who doesn't want or can't use Clang may just as well
        use --disable-skia.
        
        This reverts commit 77ba9a095b0b3f429e006571e16f8320ba0bb61e.
        This reverts commit b36df65bb2393f8f46eea68c861d7570e7a772a1.
        
        Change-Id: If0310ce13e4023c6ae43f96447b48665ab7e4353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122336
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-21  Caolán McNamara  <caolanm@redhat.com>  [2a357832b9eedea161f593c1b3bf8dd973949c95]

        Resolves: tdf#136442 don't query siblings and parent to determine type
        
        because this is used during sorting of the tree elements so its position
        isn't necessarily meaningful during the sort. DBTreeListUserData is
        supposed to exist for elements not staged for removal and that already
        has the type as a member
        
        Change-Id: Ie1004dbcdca2fae8711941d98a084103a0b15815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122354
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-21  Caolán McNamara  <caolanm@redhat.com>  [cb889f72116250ffcb874a4c950efe3b6972f541]

        Related: tdf#136442 implAppendEntry is always passed a DBTreeListUserData*
        
        Change-Id: Idb51b28a52d79476c2897a318314d6267727e9e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122353
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-21  Stephan Bergmann  <sbergman@redhat.com>  [1281ea9176674a040ec08cf0014fdd75ca0b2fd1]

        Avoid "test: : integer expression expected" on non-macOS platforms
        
        Change-Id: I90a31483b1750c59299e9a9f148990a8a68d4860
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122377
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-21  Stephan Bergmann  <sbergman@redhat.com>  [504d2209e47ffeb223b2bcde9fc24e828cc5cd6f]

        Remove some "Attention" comments of little value
        
        ...and rather add sal/config.h includes, while at it
        
        Change-Id: I0ea917b101d89f16228bea6b3102b630c8202e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122369
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-21  Miklos Vajna  <vmiklos@collabora.com>  [7246e57216bb20c15af0ecf6a0183f5ffa81e780]

        tdf#143591 DOCX import: handle anchored objects as at-char
        
        This partially reverts cc8f8ae55f681755f5da3bf64e4c30bb713f0383 (DOCX
        drawingML shape import: wp:anchor's behindDoc attribute, 2013-11-19), it
        seems to be more important to be consistent with the DOC import than
        with the VML import which is no longer used for DOCX shapes crated with
        Word >= 2010.
        
        Change-Id: I631da010bce1b4d3c392645e0ae3797a03665a42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122367
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [f5a81a119cb63152c2c2e2473a1ea183a30c8db9]

        vcl: remove OutputDevice's GetDevFontSizeCount() and GetDevFontSize()
        
        The OutputDevice::GetDevFontSize() function is only used for
        non-scalable (bitmap) fonts. We have stopped supporting bitmap fonts
        since LO 5.3, see tdf#103514: Support for bitmap-only fonts on Windows
        has been removed (Khaled Hosny)
        
        I found the following when removing PhysicalFontFace::SetBitmapSize():
        
         1. as mnHeight and mnWidth and not set by anyone, I realized I could
            remove them, which meant removing GetHeight() and GetWidth()
        
         2. PhysicalFontFamily::GetFontHeights() populates heights from the
            collection of font faces into a sorted vector of font heights taken
            from PhysicalFontFace. As this no longer exists this function
            serves no purpose, it has been removed.
        
         3. PhysicalFontFamily::GetDeviceFontSizeList() calls upon
            PhysicalFontFace::GetFontHeights(). This function takes this sorted
            list of font heights, and then populates and returns a new list of
            sizes (or rather, heights). As the heights aren't available any
            more, this function is also unneeded, so it has been removed.
        
         4. OutputDevice::GetDevFontSizeCount() calls upon
            PhysicalFontFamily::GetDeviceFontSizeList(). This function has the
            side effect of initializing the list of fonts.
        
         5. When I checked what calls on GetDevFontSizeCount(), there is only
            one caller - FontList::GetSizeAry() in svtools. The function returns
            a standard font size list if the family name is empty, or there are
            no font sizes (via OutputDevice::GetDevFontSizeCount()). As this
            will *always* be empty (see chain above) then this function just
            needs to always return a standard font size list.
        
            Thus OutputDevice::GetDevFontSizeCount() and GetFontSizeList() are
            no longer called upon by anything, so they can be removed.
        
         6. svtool's FontList::GetSizeAry() no longer uses the FontMetric
            parameter, so this has been removed from the function signature, and
            cleanup done of the function that calls upon it in svtools,
            framework, editeng, and desktop. A number of variables that were no
            longer used due to this change were also removed.
        
         7. This change removed the need for the mpSizeAry unique_ptr in
            FontList. ImplFontListFontMetric::GetDevice() and mpDevice could
            also be removed as it was no longer used anywhere.
        
         8. After simplifying GetSizeAry(), it turns out it was the same as
            GetStdSizeAry(), so removed FontList::GetSizeAry() and used
            FontList::GetStdSizeAry() in its place.
        
         9. Changing to use GetStdSizeAry() revealed that FontSizeBox::Fill()
            no longer used the pFontMetric paramter, so this was removed, and
            call sites updated.
        
        10. Due to change to Fill():
        
            a. SvxFontSizeBox_Base::UpdateFont() no longer uses the
               const css::awt::FontDescriptor& rCurrentFont parameter, so
               removed this. This also removed the member variable
               m_aCurrentFont
        
            b. SvxCharNamePage::FillSizeBox_Impl() had a number of newly
               unused variables removed.
        
            c. SwStdFontTabPage::Reset() and
               SwStdFontTabPage::LoseFocusHdl() had a number of newly unused
               variables removed.
        
        Change-Id: If840e240155c36ed351c63e3136b5b44bb058697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121932
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [4bd09020870e708b7ff1500356952d15fb52836d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 476d099e11be81ddb1b8388fbb92bc1b7069d2bf
          - tdf#144556 Fix information on deactivating AutoCorrect in Calc
            
            Change-Id: I6cb86dbf7fec71e3b67558117be951ad64689ed6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122282
            Tested-by: Jenkins
            Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2021-09-21  Stephan Bergmann  <sbergman@redhat.com>  [7b10f119040144ff7db1da4c0a2bbdd488dcdf0f]

        Implement the SourceTreeProvider Cursor
        
        Change-Id: Ibf54bd1e852ea23fb37c7222625895d240452424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122361
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-21  Chris Sherlock  <chris.sherlock79@gmail.com>  [5c98fcffb23a9da8459e35bdd9946422fec8a320]

        vcl: add sal/config.h in preparation for patch
        
        The convention is that we need to add sal/config.h to the start of
        files.
        
        This patch is created in preparation of a patch I have queued to test
        and move PhysicalFontFace to vcl::font namespace.
        
        Change-Id: I15dd24d7f01e077d407ac192a0413d796517eb72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122228
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-20  Luboš Luňák  <l.lunak@collabora.com>  [47a8a65022e3fd7624c95d0341b4809aad11fddb]

        use MSVC's /Zc:inline option to reduce binary size
        
        If I'm getting it right, MSVC has a non-conforming feature
        that allows to declare a function as inline without defining its
        body in the header, and it'll work if the function is actually
        emitted elsewhere, and the linker will sort it out. This seems
        to be implemented by forcing emitting of out-of-line copies
        of all inline functions, which is wasteful. /Zc:inline disables
        this useless feature, which seems to save quite some space
        (optimized build, starmath's .o files 350k->220k, smlo.dll
        2.5M->2.2M).
        
        The docs don't say anything about binary compatibility,
        but treat it the same way as -Zc:dllexportInlines, just in case.
        
        This change also may help avoid the tdf#144598 problem for our
        AVX/etc. code, such as in Calc.
        
        Change-Id: I73cc5d46ba1e4245e8d3b6688804c2b9684d2f9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122334
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-20  Luboš Luňák  <l.lunak@centrum.cz>  [c7c9f3f57a2feae5d3bc3c47104786883ed09e44]

        use clang-cl's -Zc:dllexportInlines- for clang-cl builds
        
        This is clang-cl's equivalent of -fvisibility-inlines-hidden,
        and it seems to be also sort of the equivalent of MSVC's
        -Zc:inline. So it saves build time and disk space.
        
        Clang docs say that this is binary compatible in only one
        direction, so our public C++ code shouldn't be using this,
        as external C++ code could try to use exported inlines
        that are no longer there.
        
        Change-Id: Ie6217808f8ee4a15344183abfc65038e1558d1b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122352
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-20  Luboš Luňák  <l.lunak@centrum.cz>  [36f76223193fb96df7b8cbc1a1ff30f739857189]

        use clang-cl's -Zc:dllexportInlines- for Skia (tdf#144598)
        
        This is clang-cl's equivalent of -fvisibility-inlines-hidden,
        and it seems to be also sort of the equivalent of MSVC's
        -Zc:inline. So it saves build time and disk space.
        
        As an additional effect, this disables emitting copies
        of inlines functions in every .o file where the function
        is called (even if inlined), which means that it hopefully
        avoids the problem of SkOpts_avx.cpp generating a copy
        of SkRect::round() which would include AVX code, and
        the linker might select this as the instance of SkRect::round()
        to keep, thus making SSE2 code call AVX code without checking
        for AVX availability first.
        
        Change-Id: I97541ae11d05f489894bc9233271eb21fd520f43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122335
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-20  Caolán McNamara  <caolanm@redhat.com>  [c9c9d40f79f1767a0a824fc421f2e476c3f24eb8]

        ofz: can now undo temp -L/usr/msan/lib hack
        
        now that https://github.com/google/oss-fuzz/pull/6493 has landed
        
        Change-Id: I38634fec9c3e6c50499f1164d7b873dd1889efe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122368
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-20  Caolán McNamara  <caolanm@redhat.com>  [45e8b85a50bf153b6c9f627e731eecee1cf966f2]

        Resolves: tdf#144620 toolbar config item overwrites options dialog one
        
        There are two SwMailMergeConfigItem involved. One SwMailMergeConfigItem
        from the toolbar created and considered modified and with changes not
        commited to the config yet.
        
        Then the other SwMailMergeConfigItem is created by the options dialog
        and commited on ok, but after that commit at
        cui/source/options/treeopt.cxx at line 723 there is a
        utl::ConfigManager::storeConfigItems() to flush all outstanding config
        items, so the one belonging to the toolbar is now flushed after the
        options dialog one was written.
        
        The SwMailMergeConfigItem has a IsModified() of true right after ctor
        which doesn't seem intentional, there is no explicit set of Modified to
        true on setting the simple bool members, the Modified bit is toggled on
        when using the more complicated modifier methods during ctor so very
        much looks like an accidental side effect.
        
        Change-Id: If84a6f01c7bf92704dd1e175a2bd8e2ea59e157f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122364
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [e1972743d692c8d8611912c31aae2cb08ae7636d]

        be more disciplined with SetUpdateLayout on editengine
        
        save/restore in more places, and check in more places
        before doing layout, so we dont waste time on expensive layout
        
        Change-Id: I311f1f7f97a508da296078e936cb3704938dfdc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121687
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Justin Luth  <justin.luth@collabora.com>  [eb830ad284f245165b6ab5e8647d48834622f2d5]

        Revert "tdf#99492 sw layout: always paint merged cell grids"
        
        This reverts LO 7.1 commit c016fe2b5918d6e53113e100b1126076b6e1a6a3.
        
        This failed for two reasons.
        1.) If it is not a solid color (like a graphic for example)
        then the graphic is going to be repeated in each cell.
        2.) This is NOT actually repainting the visible cell's background.
        It is painting the hidden cell - which MIGHT be different
        from the visible cell (in the case of a solid color).
        
        Since this will require a completely different approach,
        I am just reverting this. Thanks Mike for finding an
        example document that shows the flaws.
        
        Change-Id: Icdc21e09118e7c33ac9f7ede23c913b95ad69c93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122366
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-20  Michael Weghorn  <m.weghorn@posteo.de>  [85b4b15bb02f8d2fdbead0c836763621096b995e]

        wina11y: Drop bool param from CMAccessible::NotifyDestroy
        
        ... and 'AccObject::NotifyDestroy', respectively.
        
        The only calling site calls it with 'true' as parameter
        (and 'CMAccessible::NotifyDestroy' was calling
        'm_xAccessible.clear()' regardless of what value the
        passed param had anyway).
        
        Change-Id: I08a24f79b50ec327ae461bd44ee6460a2d8145f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122343
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-20  Michael Weghorn  <m.weghorn@posteo.de>  [185b183a71924c84edb385ec5eb4fe6d4bfe8e05]

        wina11y: Drop AccObject::m_bShouldDestroy
        
        The getter, 'AccObject::ifShouldDestroy',
        was unused, so drop it.
        
        The only place where the 'm_bShouldDestroy' member
        was actually used was in 'AccObject::NotifyDestroy',
        where it was assigned a value from a method param that
        was then passed further right away, so there's no need to
        store the value at all.
        
        Change-Id: Id5688e9742892e345b143a8eebeed5099696a0f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122342
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [afd918a81bc2dce4830bc94cbd88b9038f5715ff]

        introduce SfxItemSetFixed and use it in DefaultProperties
        
        DefaultProperties::SetObjectItemSet is very hot when loading
        shapes, and a large chunk of that cost is allocating the pool item
        array.
        So use a template class to allocate the array in-line to the class,
        which means it can be allocated on-stack.
        
        Change-Id: Ic53b41f35784726362de38fceb35f8634cddf0a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122310
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [88b72d85ef82a5a6ca019ef9b88f5389db067c83]

        tdf#124176 - Use pragma once instead of include guards
        
        This patch is created in preparation of a patch I have queued to test
        and move PhysicalFontFace to vcl::font namespace.
        
        Change-Id: I805a8bd1fa881fc4bc6d2f26f1051b9247587701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122226
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8e2fb3b88a5ee00cb70fa7f8440b8f0b98ae4bc8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d7110084bb66a1b2d3afce9567a83be58642e8f
          - Mute l10n on Basic instructions
            
            Change-Id: I389e49ed5ca19047d13e691057bd5c5edcc30ee2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122365
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-20  Ross Johnson  <ross.johnson@homemail.com.au>  [8010a0a32c232f06534fdd56c2227c9c00798cfd]

        tdf#33749 - rationalise several confusing cell merge controls
        
        1) Replace the entire "Format > Merge Cells" submenu with the
        single "Format > Merge and Center Cells" button with all the
        same behaviour it has on the Formatting Bar.
        2) Replace the "Split Cells" button from the context menu of
        a selected merged cell with the "Merge and Center Cells" button
        showing the current merge status, as it does elsewhere.
        3) The "Merge Cells" checkbox in the Properties sidebar
        Alignment section is unchanged.
        
        Rationale:
        The current behaviour of the "Merge and Center Cells" button on
        the Formatting Bar is consistent with all other formatting buttons,
        eg, "Align Left" is still "Align Left" (but shown activated) when
        the text is currently already left aligned, and toggling it off
        reverts the alignment to a default alignment. It behaves correctly
        and intuitively IMO.
        
        The "Merge Cells" button in the "Format > Merge Cells" submenu
        should be removed as it appears to do the same as
        "Merge and Center Cells", that is, when it works correctly. It
        isn't helpful though as it has at least two problems: 1) it is
        greyed out if a merged cell is selected, unlike
        "Merge and Centre Cells"; 2) it becomes selectable when a range
        of cells is selected that includes a merged cell, but won't
        perform the merge.
        
        Removing both "Merge Cells" and "Split Cells" buttons from the
        Format > Merge Cells submenu leaves one entry, the
        "Merge and Center Cells" button, which should then be promoted
        to the top level menu.
        
        Change-Id: I2f592211f888427d5bba384c28c8c3c7d92d8de6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122293
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-20  Ross Johnson  <ross.johnson@homemail.com.au>  [f0dfc5a38816bd01389f5ac8fd46d43a201f18a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a45cfda035abefcda03767a4c81f93c69d593b1
          - tdf#33749 - HTML Help pages - reflect changes to cell merge in Calc
            
            Replaced the entire "Format > Merge Cells" submenu with the single
            "Format > Merge and Center Cells" button with all the same behaviour
            it has on the Formatting Bar.
            
            Replaced the "Split Cells" button from the context menu of a selected
            merged cell with the "Merge and Center Cells" button showing the
            current merge status, as it does elsewhere.
            
            Also, add the "Merge and Center Cells" link to the Formatting Bar
            Description Help page. It was missing.
            
            Change-Id: I8f200faa7a218adae533752def032f4b7f28eed6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122313
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-20  Ross Johnson  <ross.johnson@homemail.com.au>  [dbf3e7c400c76fa79f55e5d7026bd93f6696c6fc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a03b2a3c515c5a15cbe22a24ee436fabd9ec272c
          - tdf#123506 - HTML Help pages - group search results under module headings
            
            The "double entries" reported are because the search results
            are never grouped according to module (CALC, WRITER, IMPRESS, etc).
            Results are now grouped.
            
            The HTML Help page search function uses a "fuzzy" algorithm to pick
            matching results. This observation by the reporter is not a bug and
            so the main Help page has been updated to include an explanation.
            
            The main Help page has also been updated to draw attention to the
            highlighing of the matching characters from the search term, to show
            exactly how the match was made.
            
            Change-Id: Ibdb9ac726b36b9dd6f605c854192ec644bfe09e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122312
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-20  Luboš Luňák  <l.lunak@collabora.com>  [8a4c16916b49cc096779bb9fab86a5a90f514ae3]

        avoid division by zero
        
        A rectangle in SwRegionRects may apparently be empty.
        
        Change-Id: I0956be2921d5110e2a8b9867bebf99814dd222f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122351
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-20  Stephan Bergmann  <sbergman@redhat.com>  [9187b1a1cfe5ad0323a8523b1821831864de878d]

        Drop unused osl_FileStatus_Mask_FileURL
        
        ...in code that never called aStatus.getFileURL(), ever since the code's
        introduction in 4a25fb867f7cc0a0fc21c4079c84fadec6647ad1 "Make TempFile
        destructor remove temp directory recursively"
        
        Change-Id: I998ca23089125706b2377f192ace702a0ce804ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122350
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-09-20  Miklos Vajna  <vmiklos@collabora.com>  [37a52d30bbfcf1d073779b50139c4dafa507be4b]

        tdf#144091 svx: fix unwanted blur of shadow from table cell fill
        
        Initial render support for shadows of table shapes were added in commit
        a75bf43a8d6c5dec6dcc86908c142ceec541aa8c (tdf#129961 svx: add rendering
        for table shadow as direct format, 2020-12-02).
        
        That already noticed a trick with the shadow of table shapes: the shadow
        is generate from the cell fill and the border, but not from the text.
        
        An additional trick is that when blur is enabled for the table shape's
        shadow, then only the border should be blurred, not the cell fill.
        
        In the bug document's case, the effective cell background was gray, with
        a semi-transparent red shadow. We used to render cc0000 with blur and
        cccccc without blur, now we correctly render cca3a3, matching
        PowerPoint.
        
        Change-Id: I7326a5f6254cf19b2d05181084c78e734ff7a7b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122349
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-20  Caolán McNamara  <caolanm@redhat.com>  [1a6401578ec32510342e232699889527cca914b8]

        ofz: avoid Timeout
        
        Change-Id: I941a5b9b930248236f35b31582ee8f2c9e0be16e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [e2e43363b429b7909ed3dbe79ccab35d0274106e]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: I1703ee1d7cfc5f3f3458dce8db36fa86c578814c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122331
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Stephan Bergmann  <sbergman@redhat.com>  [1405f98b6e0fc43d41c3b8f16923589eccd08495]

        Adapt SetWindowLong call to 64-bit build
        
        This failed with GWL_WNDPROC being undefined in 64-bit builds.  See the note at
        <https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setwindowlongptra>:
        "To write code that is compatible with both 32-bit and 64-bit versions of
        Windows, use SetWindowLongPtr."
        
        Change-Id: I7abcc681b4daf459eb0c0481266949c75ecf4dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122341
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-20  Luboš Luňák  <l.lunak@collabora.com>  [80bb2ab680ea889a4bcf7104e5c8b1bdce22c9f3]

        improve the SwViewShellImpl paint region API a bit
        
        Make it clear that the region is a paint region, and make
        the ownership clearer when SwViewShell takes it over.
        
        Change-Id: I229255a8e2d07ccc228e894e85b0a47f1e2b1259
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122309
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-20  Luboš Luňák  <l.lunak@collabora.com>  [b22d4785310eac35696df771803dfba0871a50ac]

        clean up ambiguous confusing rectangle APIs like IsInside()
        
        Reading 'rectA.IsInside( rectB )' kind of suggests that the code
        checks whether 'rectA is inside rectB', but it's actually the other
        way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(),
        which should make it clear which way the logic goes.
        
        Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Tested-by: Jenkins

2021-09-20  Stephan Bergmann  <sbergman@redhat.com>  [3e2370260f2b79c43b4f8a86b123861aa95d3ef2]

        Fix type of css.drawing.FillProperties FillColor property
        
        (where css.util.Color is a typedef for UNOIDL LONG).  This caused issues on
        Windows, where in C/C++ sal_Int32 is a typedef for long rather than int.
        
        Change-Id: Ic0407674d06a219210d7f0448100005d7135eb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122340
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-20  Miklos Vajna  <vmiklos@collabora.com>  [499e4b2e56282fe2df9f6383652359206d2c9fcf]

        sw: prefix members of SwNavigationConfig, SwNumRulesWithName and SwSrcView
        
        See tdf#94879 for motivation.
        
        Change-Id: I2740ff914fe35a069ce67ad10783dadc0cfdbf74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122339
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [5b3bf3306797271c90df5a4a00463d327a65e96b]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: I5a80d85225d1e5ba98a52885a79bed5bb873243d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122330
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [dfb0c861e0d277f93482c58e607112b5e3baf5f5]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: Ia7be6c4e04f5558ed0dd53aa0df4feea1b1c556e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [a64e503b77679d60997a2b6c69b7f1cd37aba5e9]

        no need to allocate these SfxItemSet on the heap
        
        Change-Id: I2aa7f9e8f8bc93f7422acfaac2337087060d36a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122328
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Noel Grandin  <noelgrandin@gmail.com>  [494358661a05ce548d09e51703f72cd2c012437b]

        no need to allocate SfxItemSet separately in SvxOutlinerForwarder
        
        Change-Id: I6042993749b5e0b841e82e3b6930e656b88c7fd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122327
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [9819f4221ced92fced1760d75019d399c9a3383c]

        Add sal/config.h in preparation for patch
        
        The convention is that we need to add sal/config.h to the start of
        files.
        
        I have a patch queued to be able to create a FontMetric from
        a PhysicalFontFace. Submitting this patch so I can hopefully one day
        land this patch.
        
        Change-Id: I5817acd6e194da576f2c8a13539d38954a4f4e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122172
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-20  Chris Sherlock  <chris.sherlock79@gmail.com>  [73ad4bc218b5a2c3f8b25e0cf4e3858cddfb4d01]

        vcl: unneeded functions in PhysicalFontFace
        
        Nothing uses PhysicalFontFace::SetBitmapSize(), so remove it. This in
        turn meant that the class doesn't ever use CompareWithSize() directly,
        as this calls on CompareIgnoreSize() when no width or height is set I
        have removed CompareWithSize().
        
        Change-Id: I1012ffd3bc0f39f917a8b725f9985844967533dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121931
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-20  Jim Raykowski  <raykowj@gmail.com>  [f4f646eec90c44b6a7ffeaf5f6ce4c85af64eed0]

        tdf#143813 Outline folding: Make copy cut paste work
        
        Change-Id: Ib8b491fdcce1cd059c8eaf80a9c3bb2590af7c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122212
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [770dcb1f717d576facf31efed14bee403e1a7155]

        ofz: avoid Timeout
        
        Change-Id: I8c5d1e7aaf256e182c2f5dd92bb8fd4ad9bff42a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [0e74bba03fb99e276637335f0b3320419a4fe1c1]

        ofz: check radius arg
        
        Change-Id: Ife72cf379e60c96046205746c62a35ead7f09b16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Alain Romedenne  <alain.romedenne@libreoffice.org>  [614f4c1dea2a7ed88c961ae8541b7d86ea7bef5d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f514d2c1eba9998ae67a9b8fd508441b1bebbf49
          - =INFO() function also returns "ANDROID" as an OS for phones or tablets and much more …
            
            Change-Id: Iacdf3bf832bb338324b4a3598c8cf22871b1e1cc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122112
            Tested-by: Jenkins
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-09-19  Mike Kaganski  <mike.kaganski@collabora.com>  [7a4772096d307bbfa7842ad7346d63d633ba6c23]

        Fix moving temp file in tryDisableHWAcceleration on Windows
        
        In my debug build, using safe mode dialog, Disable hardware acceleration
        setting does not apply. In BackupFileHelper::tryDisableHWAcceleration,
        osl::File::move fails with osl_File_E_ACCES, and internally GetLastError
        after MoveFileExW reports ERROR_SHARING_VIOLATION.
        
        The problem is that the tempfile is still in use by xTempFile. Closing
        it, and making sure that the file doesn't get removed in the dtor, fixes
        the problem.
        
        In case something goes wrong, the tempfile would get removed in app
        cleanup anyway, when session temp directory gets removed.
        
        Change-Id: I4568f60b2b50a4038cba2e7a65033cb57e8b6edb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122274
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [adb38e36e3944b47dbf278f882dd07cbabea5ced]

        tdf#123144 - Always translate an error number to a vba error message
        
        In addition, create a meaningful error message and don't create and
        artificial error message if there exists a custom one.
        
        Change-Id: I682e497ee3fdfe4da80fb17ab41c1b4cf90eb2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122206
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-19  Steve Fanning  <stevemfanning@yahoo.co.uk>  [e29689e279442cdcaebea582a008a86861851020]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71d1c3403820c00020d9dbe17e065eef9da13a43
          - Current help description doesn't really explain what the CONVERT_OOO function does.
            
            Change-Id: I92491dc27dbadfd02b326fb01a8230f69d7e564d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122272
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-19  Stephan Bergmann  <sbergman@redhat.com>  [e6fe048ded34a322007547d4d31e32c598aa4993]

        Some more string_view use, add o3tl::starts/ends_with
        
        ...until those C++20 string_view member functions are generally available (the
        fallback implementations are taken directly from the C++20 spec).
        
        (In ParseMathMLAttributeLengthValue in starmath/source/mathml/mathmlattr.cxx,
        returning nIdx + 2 instead of nIdx + 1 for the single-character u'%' case was
        presumably a typo, but which was harmless as the return value was only checked
        for <= 0, and has now been turned into a bool.)
        
        Change-Id: Ib441e474c515f016a4d81bb39f7821dfe0356499
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122322
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [33a699c8f3605c8506cdde6918bfbb4b59ab79b2]

        ofz#38969 fail earlier
        
        Change-Id: Iae8cfe3ad8f4741be3850e5cd62787459f54c421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122320
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [ecab8f30de7d086f5b0f736e4aa77ba038b905b7]

        cid#1492159 Uninitialized scalar field
        
        since...
        
        commit c2e6a068c112f4c5866b6371d02362bd71f903a3
        Date:   Wed Sep 8 12:07:48 2021 +1000
        
            vcl: create FontMetric from PhysicalFontFace
        
        where previously we had...
        
         FontMetric aFontMetric;
         ...
         aFontMetric.SetFamilyName( rData.GetFamilyName() );
         ...
         return aFontMetric;
        
        so the FontMetric default ctor was called which initialized all
        FontMetric's members, but afterwards with...
        
         return FontMetric(rData);
        
        the new FontMetric ctor taking a const PhysicalFontFace& arg left all
        the non-inherited members of FontMetric uninitialized
        
        Change-Id: I91ee08ed1d63d15eccec44c87841884b2992eacb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122317
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6e0f3a6803c6ab8fda3578e354e1723951388a04]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 63c0bc5d25f744de978aefa6b8df2fc490738b3e
          - Refactor icon size and alt
            
            Change-Id: I54f09e8baa3f0c7c575701945934582b69e4e2e8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122321
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [91655a80a1e2530ec131bef4441f7bf1cfae67a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 875dbfa8cf894686c2ea38e36191bc189011c0d5
          - Add menu path for sheet menu - comments
            
            Change-Id: I05060c8181808527ac9d5e5690ec97d857a05326
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122319
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-19  Olivier Hallot  <olivier.hallot@libreoffice.org>  [370a2cc6a9d738a13c2d832fa933442f37dd4f59]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1b469faa018e34d110b016817a053fd3e6270ce0
          - tdf#131305 Add bookmark for .uno:EditAnnotation
            
            Change-Id: Ie0811649ff38db346ad579448fa87877da77671c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122318
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [f8e3047eec82bfcf50e0930e70ab92fceb9aa820]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic5c4e91e3712a25165e7327dbb8d377212125067
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122316
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [b092ae051549f9577c8603235515f79ca8af5156]

        cid#1492160 Dereference before null check
        
        Change-Id: If53b117a69c37907c4d3871eec6c8b3ecfc9c461
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Caolán McNamara  <caolanm@redhat.com>  [1875d8a934bb95a4fb7343dd776845c6606c74bb]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8de015f7c748de338f989a383838ce3921d176a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-19  Noel Grandin  <noelgrandin@gmail.com>  [0c7133e3ac6b0bf21c7c79e3301a530d13534530]

        allocate this SfxItemSet on stack
        
        Change-Id: Ifab3b3508de990c42ee5c8c564cbd2d535376813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122306
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-19  Noel Grandin  <noelgrandin@gmail.com>  [d3fbfa4a4b3ef80575ec5f27ca13d937d6f52bf6]

        no need to allocate SfxItemSet separately in SdrUndoAttrObj
        
        Change-Id: I32c9d79262c711a4f28c910e1b8f8ca9c1f011e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122305
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [9e7715dbc4e3c09d9be8a6f3c5ca0e4910651fec]

        vcl: test PhysicalFontFamily and move to vcl::font namespace
        
        - Adds a series of unit tests for PhysicalFontFamily
        - Moves PhysicalFontFamily into vcl::font
        - Move PhysicalFontFamily.hxx into vcl/inc/font
        
        This is part of a series of patches where I also move font files into
        the relevant font directories, and into the vcl::font namespace.
        
        Change-Id: I9e8d7ceb5ec3494bf3ab6560645e52e88223ee69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121903
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-19  Luboš Luňák  <l.lunak@collabora.com>  [a6bccaf72f69428bffd6688917491ef921383456]

        make "-external/" valid gbuild exclusion for FORCE_COMPILE
        
        Get the name of the directory extra level up, which is 'external'
        for external modules, and check that too.
        
        Change-Id: Ie9a3bffea0c64c07cf2e9dfa221fd27106a05443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122307
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-19  Luboš Luňák  <l.lunak@collabora.com>  [5a3c60f7c76fc0eca21f0fd468783e0ae48e3129]

        do not double-invert SwRegionRects
        
        The usual way to use SwRegionRects seems to be to set it to the full
        area (origin) and then use operator-= to remove parts. But operator-=
        is slower than operator+=, so if that all is followed by Invert()
        and Compress(), it's essentially inverting the operation twice,
        making it both slower and (IMO) more complicated. Make it possible
        to simply use operator+=, collect all rectangles and then
        post-process once using LimitToOrigin()+Compress().
        
        I'm not entirely happy about the SwRegionRects constructor, but
        I don't have a better idea that wouldn't silently break backwards
        compatibility for backporting.
        
        Change-Id: If3c83e32729e5d02b9d97b66c93fac04d4fb3ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122215
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-19  Luboš Luňák  <l.lunak@collabora.com>  [bc09e2c08f9db85c8f1cbd9c0e71e3e60d6d6ed3]

        optimize SwRegionRects::Compress() more
        
        Implement Noel's idea of sorting the rectangles by Y axis and then
        considering only pairs of rectangles that are close enough to
        possibly get merged.
        
        Change-Id: Iac4a94fc411237f8c0fb5812906dc832be398cfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122214
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [559850da1f48fd7ea521c78a1867255212f7aee9]

        ofz#24932 Avoid timeout
        
        Change-Id: I0bcd5490c05a28971f130b387bdc8bcd781ad441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Luboš Luňák  <l.lunak@collabora.com>  [8d8d25f5ddbe42fc5a3647ff0ad31e93311b9ed5]

        make FORCE_COMPILE_ALL more flexible than all or nothing
        
        Rename it to FORCE_COMPILE and it takes the --enable-symbols
        specification of what to include, for example
        FORCE_COMPILE="all -sw/ -Library_sc".
        
        Change-Id: I92afd8e0abc75d3566285c197d6640c26c03db36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122248
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-18  Luboš Luňák  <l.lunak@collabora.com>  [328c12a9a011c9a8ac74c89a493b1a75e853a638]

        make COMPILER_EXTERNAL_TOOL=1 work properly with generated sources
        
        The normal compile commands would fail if the tool standing in
        as the compiler would not generate e.g. the dependency files.
        
        Change-Id: I590a925d3562c9677cbd836095cd0b8cfeb9613b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122247
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-18  Luboš Luňák  <l.lunak@collabora.com>  [56c2562cc5cf33ea415ef14e4a8bfa41e44ad722]

        don't force compiler plugins when COMPILER_EXTERNAL_TOOL=1 is used
        
        Change-Id: I741d4e5450ba66d4452ee2e5398eaac0643a371f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122246
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [34fb69ce91ad43064c32f234f465db8031ae0b52]

        ofz: reduce size of hwp input
        
        fuzzer seems to hover right at the edge of an intermittent timeout
        
        Change-Id: I478c0f355ceb4d05c60834db3f2dc14a72696794
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Noel Grandin  <noelgrandin@gmail.com>  [270c04bd68cdb154ea1e74a307a5cbb6e81fb1a6]

        remove some allocations
        
        where we could be calling static methods
        
        Change-Id: I9efef083e6ff307441fb36c19eac9134d960edec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122300
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [0685678da0994103b14b9417c52310bd40e21102]

        ofz#37911 Avoid timeout when fuzzing
        
        Change-Id: I30bdcb3c267ee7e3ee0920df03ee8507d118d009
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122301
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [d3f2d1e4e3b5f75dd1288d5f352b9fa7b36369af]

        ofz#35787 Avoid timeout when fuzzing
        
        Change-Id: Ia506200f91dcf165dab951d240cb529f1a0d8034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122302
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Jan-Marek Glogowski  <glogow@fbihome.de>  [3eb58057b0a936ba76d1a5a587f9bda2dccfe862]

        URI-encode DirectoryHelper::scanDirsAndFiles result
        
        All code assumes the result is usable as URI segments.
        
        This fails DirectoryHelper::deleteDirRecursively with files
        like org.openoffice.da.hunspell.dictionaries%2Fpage1.xhp,
        resulting in an unlimited startup loop after creating a
        new user profile via:
        
        $ soffice -env:UserInstallation=file:///tmp/test --safe-mode
        $ soffice -env:UserInstallation=file:///tmp/test
        
        So just URI encode all files and directories returned.
        
        This doesn't fix the general problem handling "regular"
        DirectoryHelper::deleteDirRecursively failures on startup.
        
        Change-Id: I48aa9816118e19302eb93387bdd741bf27fa7236
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122292
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [d33338939cb46612d73e6406474006e6ae24fe58]

        result of pDest->FindRealSdrObject() is already available
        
        Change-Id: If743c9cdcaaa75fac281b8c50d3e37bfa5ecf0c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122296
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [4d34a538f1b05d994a3105f559b553af606cb89f]

        cid#1491948 Dereference before null check
        
        Change-Id: Ic1a408e464934ebd9d264de3c77bf77379c1f254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122294
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [d1fcf3d58de99e3384bd4cf2be8466b5860c96b3]

        cid#1491947 silence Uncaught exception
        
        Change-Id: I0a5e26b6f9542ec982f378d7194a6835c0ce5f53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122298
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Caolán McNamara  <caolanm@redhat.com>  [010e99c701760e78060b884676b309d5934afd2f]

        cid#1486004 silence Uncaught exception
        
        Change-Id: Id545530140c0f2ceeeaecfb0c03c94f296bdbb4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122297
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [e9f59e76292f815faefa4ca3877d3aacdad3be5a]

        tdf#124176 - Use pragma once instead of include guards
        
        I have a patch queued to be able to create a FontMetric from
        a PhysicalFontFace. Submitting this patch so I can hopefully one day
        land this patch.
        
        Change-Id: I69b980d76f3e104a1784e2bd630a710deb33f8f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122171
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [7190c6c7a01ce6bca53d4e9e61baa2631e88de2e]

        vcl: add sal/config.h in preparation for patch
        
        The convention is that we need to add sal/config.h to the start of
        files.
        
        I have a patch queued to test PhysicalFontFamily and move it to
        vcl::font. Submitting patch to update the modelines in the files
        that I will change in that patch.
        
        Change-Id: I92275250bc5e12f7e6f7c0d4b6405d6a6e8de033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122179
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-18  Noel Grandin  <noelgrandin@gmail.com>  [63fc008870c7c070c8e30b022aeb314e882ca8d2]

        cid#1491946 and cid#1491949 deference before null check
        
        after
            commit c7551e8a46e2f9f8142aa7921a0494221ae096e8
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Sep 16 10:36:48 2021 +0200
            speedup CharacterClassificationImpl::toUpper
        
        Change-Id: If09857f89a4fa7de56831ea16d0b3ec8c50cfaf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [c2e6a068c112f4c5866b6371d02362bd71f903a3]

        vcl: create FontMetric from PhysicalFontFace
        
        A FontMetric can be created from a PhysicalFontFace, so setup a
        constructor that takes a PhysicalFontFace object to instantiate the
        FontMetric.
        
        The OutputDevice functions GetDevFont() and GetDevFontCount() don't
        necessarily make much sense, so have changed GetDevFont() to
        GetFontMetricFromCollection() and GetDevFontCount() to
        GetFontFaceCollectionCount().
        
        Change-Id: I1577679b949a49a7cf1248838786d0f5e84a5245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9c289cfde6891eebac46270774ac5c16af093622]

        Fix typo
        
        Change-Id: I7ea6c37c264a90ec6dffa62aceebae9d353f7b46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122265
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [4092e253318b19b12157c1d8298b1912d81b9143]

        Fix typo
        
        Change-Id: I49c7165ecde8f652ed68ba8f8dbd9ccbf44b3756
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122266
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-18  Michael Weghorn  <m.weghorn@posteo.de>  [1b94deea2c7648255e3efac08fd352f80c2bda06]

        tdf#100086 wina11y: Return "fresh" IEnumVARIANT for get_accSelection
        
        Create a clone and reset the IEnumVariant returned
        in 'CMAccessible::get_accSelection'
        when multiple children are selected.
        
        It seems reasonable to assume that an 'IEnumVARIANT'
        retrieved by calling the 'IAccessible::get_accSelection' [1]
        method to get access to the selected children will
        start enumerating selected children at the beginning,
        not where enumeration left off with any previously
        retrieved 'IEnumVARIANT'.
        
        I came across this because a pending NVDA pull request
        to implement the announcement of multiple selected Calc cells
        mentions that "accSelection is broken in LibreOffice" [2].
        
        NVDA uses 'IAccessible::get_accSelection' and then
        'IEnumVARIANT::Next' to get the amount of currently
        selected cells.
        
        However, with the same underlying 'CMAccessible' object
        being used in subsequent attempts to retrieve the count
        of selected children and its 'm_lCurrent' member not
        being reset in between, this effectively meant that children
        considered when retrieving the selection the previous time
        were considered as "already having been taken into account"
        when (not) looping over the children to return in
        'CEnumVariant::Next'.
        
        [1] https://docs.microsoft.com/en-us/windows/win32/api/oleacc/nf-oleacc-iaccessible-get_accselection
        [2] https://github.com/nvaccess/nvda/pull/12849/commits/b9f7ee1c2a8cbb9415545dc2562901881e27f11f
        
        Change-Id: I8e6b8bffaab010a0cfa7db8d43807e7520673d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122268
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [d596eb99c887b52ab99c38665cf1cacbcd24b029]

        vcl: rename ImplDeviceFontList to PhysicalFontFaceCollection and test
        
        - renamed ImplDeviceFontList to PhysicalFontFaceCollection and moved to
          own header file
        - wrote unit test for PhysicalFontFaceCollection
        
        Note that this is part of a series of patches where I also move font
        files into the relevant font directories, and into the vcl::font
        namespace.
        
        Change-Id: I43669137bcd9a9b2a9417b2369a5cb1b93b93733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121663
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-09-18  Jim Raykowski  <raykowj@gmail.com>  [1f9a792a391f0811bbb5f570ad5c84d13312c539]

        tdf#144349 Make Navigator global tree track sub-document sections
        
        Master document relies on the Navigator listing all the sub-documents.
        However there is no connection between the currently selected section
        (containing the sub-document) and the entry in the Navigator making it
        very hard to see what file needs to be edited. This patch highlights
        the corresponding item in the Navigator at the current cursor position
        in the document.
        
        Change-Id: Iee32d1db0e40e302bfff7a879d47a5632ce4ed43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122103
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [363d0e7e2875d0f99cf0442353202c96c097f5e2]

        vcl: add sal/config.h in preparation for patch
        
        The convention is that we need to add sal/config.h to the start of
        files.
        
        <chris_wot> mikekaganski do you want me to add sal/config.h to cxx files
        <chris_wot> as well as headers?
        <mikekaganski> chris_wot: rather ask sberg :)
        <@sberg> chris_wot, always, always as first include, by convention
        <chris_wot> thanks, I'll make sure I do this on any files I touch - if that's OK
        
        I have a patch queued to rename ImplDeviceFontList to
        PhysicalFontFaceCollection, which I am adding a test to. Submitting this
        patch so I can hopefully one day land this patch.
        
        Change-Id: I9d74f850745760774a9f8050023f584cf52dc070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122167
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-18  Chris Sherlock  <chris.sherlock79@gmail.com>  [83070c694c742ef1e86e017a5e684e72b23bf3c9]

        tdf#124176 - Use pragma once instead of include guards
        
        I have a patch queued to rename ImplDeviceFontList to
        PhysicalFontFaceCollection, which I am adding a test to. Submitting
        patch to update the include guards to pragma once
        
        Change-Id: I091817905599089edec1138eeee06ba3dacd6964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122225
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [c5aef25352d20e052ec3a697f3cb979d3bbf9df6]

        Use atomic::exchange when cleaning up
        
        Change-Id: I77b8093efba3f3dfe96f6e3a4f4bfcc8dd89ccff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122273
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-17  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8aec73d7a93b37778198d416ca4ef285734f2024]

        tdf139131 - Sort page styles under Paragraph -> Text Flow
        
        Change-Id: I1bfe098ce9dd0c76c9a469f10e41f7d757e5e50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122270
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [82689553221e1f8ceab62d72a27b31902d45f436]

        create OnDemandCharClass cache
        
        and use it in SvNumberFormatter for situations where we are rapidly
        switching locales (e.g. spreadsheet with alternating locales on adjacent
        rows)
        
        Change-Id: Ic35fdbbfbdc960673e91a37efed1d0e12c1a0751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [54906a9b925dee3fd0076e9d258a82c223d62520]

        no need to allocate the cached items separately in the intl wrappers
        
        Change-Id: Ie62ab74e47af50cfa8fc5562fd0c32259282812e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [39ccb910fdc3f9212cb9a299fce5d06dc61d87ea]

        clang-format ondemand.hxx
        
        Change-Id: I7fa1c0e5832ace0c97c93a9df808b73a3f0ffc36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122262
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [661f8785e6727dca1ef23c51ae9ecf4d3da299d3]

        no need to allocate CharClass separately in SvNumberFormatter
        
        Change-Id: I79b815567c59702c2d3fe7944bb2f16bacf0e472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122252
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [b4edda1842c301a06c5528860542153590027b42]

        ofz#38652 Avoid timeout in html import
        
        Change-Id: Ic2c3b71a96749d613a3a3339824b57eaae2b63ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed9c39da0a90ecd4677a4d80a541ca64493994ce]

        no need to store a CharClass in SvXMLNumFmtExport
        
        we only use it at one site, and at that site we can use the CharClass
        inside the formatter whose locale we just updated.
        
        Spotted by erack.
        
        Change-Id: I049c6fc399e62cfe83f3ae396ea8d0e7497e673f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122250
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [0b1d1739aa2ed7e0fbdc79a1403bfdc8dad3958b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I65338d31b3b556b2ba96f592c2b12084dab87e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [44e1dbb95de4b2cf326ef5d29be6432e195dfb01]

        CppunitTest_sc_subsequent_filters_test: simplify code
        
        Change-Id: I0019a40a34c48f59af72d73f1f83f2fc18602920
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122249
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [d02f39f67539682fd6fc673796e95f935dd139f0]

        ofz: Avoid timeout
        
        Change-Id: If2ba222d5e3cb2baa692487332d6cfc28d5be532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122251
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [ac3bc06fc2da5d5ca0d5b2c64440480c7e870494]

        gtk4: fill context menus
        
        Change-Id: Ie59f569f8917dee730e79a3bea6c3e6161ae9fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122241
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [b6c5d2d2661256a7789043b133ded51c6fdad3ff]

        rather return ref from GetLocale
        
        since we never return a nullptr.
        
        Change-Id: I459acd6a25b133da5fc8516aa5e1a982df80ae8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122242
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [f9e09ba0513bbd0eaf872a60e6824a5b20229dfa]

        rather return ref from GetTransliteration
        
        since we never return a nullptr.
        Also add a new utility method to simplify the call sites that need to
        pick the right collator
        
        Change-Id: I0ecf3ad32a0bf22d9e760620524f41bc18b54fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122238
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [ce707fc2d3420be9423bb5e8d0300dbb71a5db6e]

        rather return ref from GetCollator
        
        since we never return a nullptr.
        Also add a new utility method to simplify the call sites that need to
        pick the right collator
        
        Change-Id: I5deb009cb5144fd182bbc6470ae30ea05e6979c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122237
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c67b9a4ce5ac3a09437730d8440c84159b581622]

        rather return ref from GetCalendar
        
        since we never return a nullptr
        
        Change-Id: I4cb4af99752818e323472a372330d1bc2a3df4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122236
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8226655a8d838d15af7de3ba1fa5c47546b6ada]

        rather return ref from getLocaleDataPtr
        
        since we never return a nullptr, and rename to reflect that
        
        Change-Id: I694b5198f663842d1362504d60e7191e450a08ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Chris Sherlock  <chris.sherlock79@gmail.com>  [fec9c3d6f272d45a73dd4dad390a69e444ffc9e2]

        vcl: update vim modelines in preparation for new change
        
        I have a patch queued to rename ImplDeviceFontList to
        PhysicalFontFaceCollection, which I am adding a test to. Submitting
        patch to update the modelines in the files that I will change in that
        patch.
        
        Change-Id: I3b0b022cbfa7b05dbfbb5c2d03f6d68128c0598f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122232
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-17  Mike Kaganski  <mike.kaganski@collabora.com>  [11c8109fa109ef8178679b4de6efde695b99e0a8]

        Drop this unneeded indirection
        
        Change-Id: I6b40642c7574a1863658854d206ed849517dbd0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122130
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-17  Marco Pinto  <marcoagpinto@sapo.pt>  [8c49b17e482545e3c5c67d7b4bbf452eed366695]

        Sorted the list except emojis.
        
        This will make it easier to update without inserting each word manually.
        
        Also added the two blank spaces on the start of each line.
        
        Change-Id: Ida85d28404aca759331d6089946be8dd970c79db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121414
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Tested-by: Andras Timar <andras.timar@collabora.com>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [55adeb1c3fbcf32c7c44a3f0c310b56298f551f9]

        need optional header
        
        Change-Id: Ic6515a32c2bf2ed7d287c003df154727644598b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122239
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [370577a641b77b6cf0a08fa73a1ae62fd0bea15b]

        gtk4: guard vcl calls from gtk
        
        Change-Id: Iff35ff96c5df987258979b388485af4f3d1f039e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122240
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  rocso  <ross.johnson@homemail.com.au>  [4f7560240d8a9273fd5ecbc76e7ac054b3a6e4ae]

        tdf#143550 - use the term "gluepoints" consistently
        
        Change-Id: Id10dc2ef13f54a148a800003cc4bd88ca1a0056f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122233
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-17  rocso  <ross.johnson@homemail.com.au>  [74691a6f1b4aaadfed284ba9746032e438f7468b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ee13bc67bf0a292b19985923536924f5ab1abd0b
          - tdf#143550 - make gluepoints terminology consistent
            
            Change-Id: Ief999a09cfa9b862f24f708d2e41eff398af7372
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122231
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2f7c5188a71a66f5352a8e0cdf741efdce64b63b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04b0cb75e8e2fea295159d15a101ddf9f4fdb943
          - Fix grammar
            
            Change-Id: I24b5891b3d11058189bfc5d80e91eb3d6a5e6f53
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122131
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [8ded3f9562aec04e54dd36677f5a99e0d6cbec23]

        Fix gtk4 build ('--enable-werror')
        
        Fixes
        
            [CXX] vcl/unx/gtk4/transferableprovider.cxx
            In file included from vcl/unx/gtk4/salnativewidgets-gtk.cxx:10:
            vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:364:19: error: ‘gTreeViewWidget’ defined but not used [-Werror=unused-variable]
              364 | static GtkWidget* gTreeViewWidget;
                  |                   ^~~~~~~~~~~~~~~
            vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:363:19: error: ‘gListBox’ defined but not used [-Werror=unused-variable]
              363 | static GtkWidget* gListBox;
                  |                   ^~~~~~~~
            vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:362:19: error: ‘gComboBox’ defined but not used [-Werror=unused-variable]
              362 | static GtkWidget* gComboBox;
                  |                   ^~~~~~~~~
            vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:355:19: error: ‘gSpinBox’ defined but not used [-Werror=unused-variable]
              355 | static GtkWidget* gSpinBox;
                  |                   ^~~~~~~~
            cc1plus: all warnings being treated as errors
            make[1]: *** [solenv/gbuild/LinkTarget.mk:307: workdir/CxxObject/vcl/unx/gtk4/salnativewidgets-gtk.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            In file included from vcl/unx/gtk4/notifyinglayout.hxx:13,
                             from vcl/unx/gtk4/gtkinst.cxx:14:
            vcl/unx/gtk4/../gtk3/gtkinst.cxx:4385:11: error: ‘static void {anonymous}::GtkInstanceWidget::LinkStubasync_drag_cancel(void*, void*)’ defined but not used [-Werror=unused-function]
             4385 | IMPL_LINK(GtkInstanceWidget, async_drag_cancel, void*, arg, void)
                  |           ^~~~~~~~~~~~~~~~~
            include/tools/link.hxx:45:13: note: in definition of macro ‘IMPL_LINK’
               45 |     RetType Class::LinkStub##Member(void * instance, ArgType data) { \
                  |             ^~~~~
            cc1plus: all warnings being treated as errors
            make[1]: *** [solenv/gbuild/LinkTarget.mk:304: workdir/CxxObject/vcl/unx/gtk4/gtkinst.o] Error 1
            make: *** [Makefile:288: build] Error 2
        
        Change-Id: Id570c22aa66bf134fdc4dda31a0cf1f867f3653d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122235
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [d0940e0cca552f65ea4e85d9895682afab230c87]

        gtk4: get menus attached to menubuttons after load time working
        
        run update_action_group_from_popover_model on the newly attached menu
        
        Change-Id: If871dea4833c60efc5853de19031fc6e45544170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122198
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2021-09-17  Caolán McNamara  <caolanm@redhat.com>  [b4cf6dd97837c34a3e4b754f5132026830051720]

        gtk4: listen to "toggled" so callbacks see get_menu_item_active of true
        
        Change-Id: I130ebbb6dad9c0f69667a1c95e97583183656710
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122211
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-17  Stephan Bergmann  <sbergman@redhat.com>  [061f7ba80efe621503531ca9512b194ad8cefcd3]

        Fix calculation of alloca'ed memory size
        
        ...after 16d645e5b8f11b4ddb49a2b58bde388b28960abc "speedup
        Transliteration_body::transliterateImpl", which caused
        dynamic-stack-buffer-overflow (<https://ci.libreoffice.org/job/lo_ubsan/2137/),
        
        > ==4003==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7fffe890f7d2 at pc 0x0000004b1c2d bp 0x7fffe890f490 sp 0x7fffe890ec40
        > WRITE of size 2 at 0x7fffe890f7d2 thread T0
        >     #0 0x4b1c2c in __asan_memmove /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cc:30
        >     #1 0x2b8b4222ef65 in char16_t* std::__copy_move<false, true, std::random_access_iterator_tag>::__copy_m<char16_t>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:368:6
        >     #2 0x2b8b4222eec0 in char16_t* std::__copy_move_a<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:385:14
        >     #3 0x2b8b4222d9be in char16_t* std::__copy_move_a2<false, char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:422:18
        >     #4 0x2b8b4222d2be in char16_t* std::copy<char16_t const*, char16_t*>(char16_t const*, char16_t const*, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algobase.h:454:15
        >     #5 0x2b8b4222cf43 in char16_t* std::__copy_n<char16_t const*, signed char, char16_t*>(char16_t const*, signed char, char16_t*, std::random_access_iterator_tag) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algo.h:782:14
        >     #6 0x2b8b4222b495 in char16_t* std::copy_n<char16_t const*, signed char, char16_t*>(char16_t const*, signed char, char16_t*) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_algo.h:806:14
        >     #7 0x2b8b42225872 in i18npool::Transliteration_body::transliterateImpl(rtl::OUString const&, int, int, com::sun::star::uno::Sequence<int>*) /i18npool/source/transliteration/transliteration_body.cxx:145:13
        >     #8 0x2b8b42236f35 in i18npool::transliteration_commonclass::transliterateString2String(rtl::OUString const&, int, int) /i18npool/source/transliteration/transliteration_commonclass.cxx:109:12
        >     #9 0x2b8b41fbc740 in i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/cclass_unicode.cxx:67:19
        >     #10 0x2b8b41fbc7b2 in non-virtual thunk to i18npool::cclass_Unicode::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/cclass_unicode.cxx
        >     #11 0x2b8b41ff1335 in i18npool::CharacterClassificationImpl::toUpper(rtl::OUString const&, int, int, com::sun::star::lang::Locale const&) /i18npool/source/characterclassification/characterclassificationImpl.cxx:47:63
        [...]
        
        Change-Id: I5273e234c8921f635e31c414cb0e427ee8b04a95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122234
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-09-17  Stephan Bergmann  <sbergman@redhat.com>  [a6db8971bf37b696ae7b1d0f8fb4d11a1e541da1]

        Some more uses of rtl_math_(u)StringToDouble
        
        ...to avoid construction of temporary O(U)Strings, in anticipation of using
        C++17 std::from_chars once that is available in all our baselines, similar to
        99a1290b3f2c8584db0a33fe48adf93dccce3a92 "Use existing rtl_math_stringToDouble"
        
        Change-Id: Ib92504341c3ae9dd599f91725b0af5b7219a201d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-17  Baran Aytas  <barannaytas@gmail.com>  [6184eefa835f0495ed8136471d61837f5662b6d6]

        tdf#140226: Make use of SfxPoolItems more typesafe by using StaticWhichCast
        
        Change-Id: Ideaf9ec500af7c3aecbb7086a123a3764cac54d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121956
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [dac29c278531d5474289eb54aa03987c4958ac83]

        speedup toUpperCase when called in parallel
        
        by removing locking from CharClass, which means we need to make it an
        immutable class
        
        Since SharedStringPool in sc/ stores a pointer to the CharClass in
        use, we have to tweak SvtSysLocale so that the object does not change
        location.
        
        Change-Id: I2c62d354fa542ebc04e755ce5b9b9e2ddff76a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122185
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbad565fcb5ee8d20a1a83838e66b43aeb23bfa4]

        use optional for some fields in ScGlobal
        
        Change-Id: I715b771a9c09b7bcc536ce114080e27d75c2e91c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122230
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Stephan Bergmann  <sbergman@redhat.com>  [f2111a924ac7bf654e1bf30018007140deec9d78]

        Use OUString::unacquired
        
        Change-Id: I9264291ba55accbb07401e29499b99e9765b3f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122220
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-17  Stephan Bergmann  <sbergman@redhat.com>  [d3e1d30ac7099584552ebf9c96dd21fdf7b1d9c9]

        Some test-code simplifications, using starts/endsWith rest parameter
        
        Change-Id: I3376ddc30e8ddc0e2dfc052ab47fe086108e015a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122221
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-17  Luboš Luňák  <l.lunak@collabora.com>  [e92fc5ec08563f3fdd0941008a2c97cef302afa0]

        ensure that some basic geometry classes are trivially copyable
        
        They in practice are, since they are just integers, but SwRect
        had explicit implementations of some functions that technically
        prevented SwRect from being considered trivially copyable, even
        though they were identical to default implementations.
        
        Change-Id: Ib5086dcd5279f3b4c0c530535c91524671cc6656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122213
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8930b1f69e4b1c8c02902eb447c00b1d2b420e81]

        rather return ref from getCharClassPtr
        
        since we never return a nullptr, and rename to reflect that
        
        Change-Id: I5b8f0aba6ce387bb0fe1ce6088ba2685d2ade7f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [7fd3c5e8e5897617f1e89fda26f8cdbd4092071d]

        remove GetCharClassPtr from SvtSysLocale
        
        we already have GetCharClass and we never return a nullptr
        
        Change-Id: I3cb79bc60be614c0474ecfdaad17991f2ecb6368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [388685ea72fc22bd375e9f31a339632e175f4290]

        improve comment
        
        Change-Id: I12a29b08f5807bcb6e0a5b6e8bc5fc0f08462e44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122197
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-17  Miklos Vajna  <vmiklos@collabora.com>  [70860345da26c5c0303e01f9d6fb93276b38aea1]

        sw layout xml dump: show SwMultiPortion
        
        This helped fixing tdf#144305.
        
        Change-Id: I736f12b06a69a1c11a55487dc1a3eec976250dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122207
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-17  Jim Raykowski  <raykowj@gmail.com>  [00eed7d73ba482ff3433afaeb1fb968de515c09d]

        Writer Navigator: Fix category content tracking
        
        This patch fixes a tracking bug that causes category content not to be
        tracked when field content is at the current cursor position in the
        document.
        
        Change-Id: I6fb5c4584cb05205e0c966eef079bd30ee3e6430
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122105
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [36be1ecdc8cc2ef36ff9db0ba8af78b4aeee774e]

        wina11y: Get rid of more HWND<->sal_Int64 casting
        
        ... by changing the first param for
        AccObjectManagerAgent::SaveTopWindowHandle
        to HWND.
        
        Change-Id: Ia94bd95c49a64e63b1be332bd03e83a288707d80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122204
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [2a5da1609d9d39e5b2bd80bd6af80bebcb6c1fb9]

        wina11y: Avoid some casting between HWND and sal_Int64
        
        ... by changing the corresponding params for
        AccObjectManagerAgent::InsertAccObj and
        AccObjectManagerAgent::InsertChildrenAccObj
        to HWND.
        
        Change-Id: I598bac30d827ae9166bc21cb5e8dff88a5cc99bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122203
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [6a36d9b341f647d5547027c33bf4dc7c3df12cf8]

        Drop conditional WM_GETOBJECT define from vcl/win/window/salframe.cxx
        
        WM_GETOBJECT is already defined in WinUser.h.
        
        Change-Id: I7594560698dd2a17412f5075f8b689decbd4ca49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122202
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-17  Michael Weghorn  <m.weghorn@posteo.de>  [f1c902af040eb358cc141a7a926272a25a2afba7]

        wina11y: Drop OBJID_* defines from MAccessible.h
        
        They are defined in WinUser.h, so there's no
        need to duplicate that.
        
        Change-Id: I1ab4255a8964d7822eface027d3cef7dcd6d29eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122201
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-17  Jim Raykowski  <raykowj@gmail.com>  [f11ed86c0ce8b41482ad217bb6700832ef746870]

        tdf#95378 Writer Navigator: Track sections
        
        This patch adds document content tracking of sections.
        
        Change-Id: I4355792968031f10ab0afd176aa3284e89541b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122104
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-09-17  Luboš Luňák  <l.lunak@collabora.com>  [a9cc066a86c6bd3423c5802c5a4eded55a50c754]

        avoid more window invalidation in LOK mode
        
        This is an extension of 9b73d3e8926d5f9b10464d19b539eef3eb088f50.
        If we're not painting to windows in LOK mode, then it's a waste of CPU
        time to calculate invalidations for them when it'll be thrown away
        anyway.
        
        Change-Id: I20b1064cb9e41fd6d88b8dc2ee4edb80ae0e9104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122194
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [d09770aab5b77c8f19da855855558154151ab45b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib65191933b91b74c6dd03ae3cfaa6e6cf8dd2434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122210
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [922b8420071989026bf7cc2a973714788e0211dd]

        expand out unnecessary macro
        
        Change-Id: Id812b720413bfe9ea678910fc8d9d0a64dd32d92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-16  Hossein  <hossein@libreoffice.org>  [c156a8c708f74dd31e1ef024edc578c3915619cb]

        Add preliminary VS 2022 support
        
        This patch changes the configure.ac, so that LibreOffice compiles
        with the latest VS 2022 preview.
        
        The option --with-visual-studio=2022 should be added to the
        autogen.input, in order to use VS 2022 preview.
        
        Change-Id: Ia1d9bbeabbbd44ffe82af3624151b69d36c0a45c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122133
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [bf89ac73fdb1ca8c083913f6ad8aaf8cec9114c5]

        occasionally the bg color of the deck grip is wrong
        
        Change-Id: I318e817a8e99b9f01aee90f042bfac39a1c4b5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [d16d5b0dfdd43d6dfcf8caffaede6f5cfe22af29]

        gtk4: use gtk_menu_button_set_child when available to fill in icon
        
        Change-Id: I3da421969cf1775cbf0072bf94891d883a96b70e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122193
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d9dd003f63a781e63bfbe380ea737e080c21881f]

        tdf#143103 Support Color Filter in "Standard Filter" dialog
        
        Change-Id: Ie8ffc928315b742d5b445d5fdda62cb9c2aabc0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122089
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-16  Tünde Tóth  <toth.tunde@nisz.hu>  [40f38fd16dad4374543d4a7a109b3264837ce8d1]

        tdf#115933 XLSX import: fix permission for editing
        
        The passwords for editing in XLSX documents
        created with Excel weren't asked and verified.
        
        Note: LibreOffice supports only a subset of the hashing
        algorithms specified in MS-OE376, according to
        DocPasswordHelper::GetOoxHashAsVector() and
        https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/f70a4140-340b-4e94-a604-dff25b9846b1.
        Also the documents encrypted with unsupported algorithms
        got edit protection now, but it's not possible to add
        permission to edit them (copy of these documents are still
        editable).
        
        Change-Id: Iabc90f6bba4ed071dd2c60e9dea905481816964b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121497
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [522905a0674992fe2ab52afc1415c46ad33cf7f0]

        gtk4: 4.6.0 will have gtk_menu_button_set_child
        
        which will solve the problem of setting icons and keeping the drop
        down for GtkMenuButtons used in toolbars
        
        Change-Id: I9e0632c8756e7085868541d11709aa598f738bf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122192
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [5618448b96991c3ec3dcabd8cba144f17ee1e4d2]

        gtk4: set always-show-arrow on GtkMenuToolButton replacements
        
        Change-Id: I4c1be40e40d2f1e2bcbf26cffda7a6dd52e4f731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122191
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [8087113baf9dfa346f4f8280463ca8bc16106f2e]

        gtk4: adjust to GtkMenuButton changes in 4.6 onwards
        
        Change-Id: I892aae979f8fb9b5a7c13a790905d7e7e3f2c087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122190
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [d60489cca78c91d24cf0ac7fd82e1bcccdc8d1da]

        find_menu_button only needed for gtk3
        
        Change-Id: I3eeb7dea4ff36b8c969aec210161c1729ab9b372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122189
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2315daf701847a180a5759039b4951fb4da0653]

        Revert "speedup rational_FromDouble"
        
        This reverts commit 67d83e40e2c4f3862c50e6abeabfc24a75119fc8.
        
        because it causes less accuracy sometimes, eg. see
          https://gerrit.libreoffice.org/c/core/+/122186
        
        Change-Id: I06eb4921359a8fe6689c6cfd3e2967e25b646fa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122124
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [23d7e3965efb69f4df04a930104bac36eeeb0289]

        gtk4: set can-shrink to False for GtkPicture
        
        for the icon in GtkMenuButton in the calc, insert, header and footer in
        gtk 4.6 where the MenuButton begins to support a child widget again but
        the icon while now shown in squished
        
        Change-Id: Ibc274d88b1185eee0ee61973b40b5cde2d08f554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122187
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Stephan Bergmann  <sbergman@redhat.com>  [1d4adcee1ba82cb8f02ac73be3e558d10dea8eda]

        Increase accuracy of ParseMathMLUnsignedNumber Fraction result
        
        The new test from d5e55d204b71710eb5eb5d2c683dd6698626df3c "tdf#144319:
        sw_odfexport: Add unittest" started to cause UBSan failure during
        CppunitTest_sw_odfexport (<https://ci.libreoffice.org/job/lo_ubsan/2136/>),
        
        > /workdir/UnpackedTarball/boost/boost/rational.hpp:605:22: runtime error: signed integer overflow: 1073741824 * 2 cannot be represented in type 'int'
        >     #0 0x2b450983594f in boost::rational<int>::operator/=(boost::rational<int> const&) /workdir/UnpackedTarball/boost/boost/rational.hpp:605:22
        >     #1 0x2b450982e216 in Fraction::operator/=(Fraction const&) /tools/source/generic/fract.cxx:224:7
        >     #2 0x2b45098312d3 in operator/(Fraction const&, Fraction const&) /tools/source/generic/fract.cxx:320:10
        >     #3 0x2b46066963d5 in (anonymous namespace)::lcl_CountBlanks(MathMLAttributeLengthValue const&, int*, int*) /starmath/source/mathml/mathmlimport.cxx:1497:30
        >     #4 0x2b46066943eb in (anonymous namespace)::SmXMLSpaceContext_Impl::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /starmath/source/mathml/mathmlimport.cxx:1526:25
        [...]
        
        Formula-14/content.xml in sw/qa/extras/odfexport/data/tdf144319.odt contains
        width="0.444em", which resulted in the inaccurate Fraction 476741369/1073741824
        since 67d83e40e2c4f3862c50e6abeabfc24a75119fc8 "speedup rational_FromDouble"
        (which computes dVal=4.76741e+08 and nDen=1073741824; where before that speedup
        it computed dVal=4.44e+08 and nDen=1000000000, which would have resulted in the
        accurate Fraction 111/250).  The excessively large denominator (1073741824 =
        std::numeric_limits<sal_Int32>::max()/2 + 1) then caused overflow later on, as
        shown above.
        
        Change-Id: I221549528e4fa155e10697d218ec76bf678e8b2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122186
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-16  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [ba5156abace2e41ec4d21397c0875f7e1efd2beb]

        tdf#143574 tdf#144271 sw: textboxes in group shapes - part 2
        
        Sync textboxes with group shapes, adding textboxes to
        group shapes, copying textboxes with group shapes,
        grouping/ungrouping group shapes with textboxes, removing
        textboxes from group shapes.
        
        This patch fixes a memory leak (tdf#144271) introduced
        by commit 504d78acb866495fd954fcd6db22ea68f174a5ab
        "tdf#143574 sw: textboxes in group shapes - part 1".
        
        Note: AS_CHAR anchoring is far not the best for group
        shapes and import/export is still missing.
        
        Change-Id: I7dc3b8d36c4a04f792ae4742fe4a45af9227a17e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121449
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [e58e828d4877f9068e4a69c52ac9c7fe6e65d032]

        ofz#38757 avoid config during fuzzing
        
        Change-Id: Ie56e70faf40ec63ba5b17a8a9ea5f2947bbe53e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [16d645e5b8f11b4ddb49a2b58bde388b28960abc]

        speedup Transliteration_body::transliterateImpl
        
        use alloca in Transliteration_body::transliterateImpl to avoid
        over-allocating stack-space (which tends to unnecessarily flush some
        cache)
        
        Change-Id: I1843fdcb830a3e948a8bbd0a9c7eb143b21a804c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b2db17e8c0bb64e33ecf2d074a542568fc66451a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0730e0e4e05095fba949378e2cc489f31784c7e4
          - tdf#125636 (part) GPG siging works only for ODF
            
            https://bugs.documentfoundation.org/show_bug.cgi?id=125636#c16
            
            Change-Id: If8826fd96288ac85197a2b937b5e4fdcda528d11
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122150
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-16  Heiko Tietze  <tietze.heiko@gmail.com>  [870e3cd6e34cca39fc9a9da335b9c1618ca50355]

        Resolves tdf#144442 - Rearrangement at paste special dialog
        
        Change-Id: I935b67f2159f7a35e28ea2b7b7eb707f0a1548de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121507
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-16  Rafael Lima  <rafael.palma.lima@gmail.com>  [0fe197765e489f2a8df499f8f8faf8056fc33394]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8c6952d809ccc08b89b8d5ac5e603e5ec00ec20
          - Minor fixes in help files (sbasic)
            
            Change-Id: Ifb4a91bfeb1ca8f7e67e9affa30b1e29028b4731
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122071
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-16  Heiko Tietze  <tietze.heiko@gmail.com>  [95406f2e172df13ae9c6536ca1378cd7fca3b2de]

        Resolves tdf#144523 - Update Liberation fonts to 2.1.4 release
        
        Change-Id: I25aa71d214eec3a131a7b11dfe292764061a127c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122182
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7551e8a46e2f9f8142aa7921a0494221ae096e8]

        speedup CharacterClassificationImpl::toUpper
        
        remove empty sequence creation in CharacterClassificationImpl::toUpper,
        rather pass a pointer, so it can be nullptr.
        Which results in a fair degree of cascading change.
        
        Change-Id: Ie56d49dc71480195c1807764b0d5124f0019f30b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-16  Olivier Hallot  <olivier.hallot@libreoffice.org>  [92e8706b6de54b0e2e7d5915f5f9ff299727930d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 446fbc68aaf1ddc03e3b8c176d943c5f5ca09ade
          - tdf#144332 fix bookmark typo + refactors
            
            Change-Id: I990a9edff16d1c7e1f828f291a123c3aa12f69cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122188
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [237308204b75289b7ed53ae6e394312422120368]

        gtk4: set newly available always-show-arrow property
        
        since 4.4
        
        Change-Id: I6d7d0077617077606a7ef48f22183fcd3ca69c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Luboš Luňák  <l.lunak@collabora.com>  [9c5a9ee14273593ebcc4bf0f1d42583b6f4f3c52]

        use our string->number functions instead of std::istringstream
        
        This is sort of the other side of the 417f881d20cafe88a02b6489
        optimizations. C++ streams are relatively slow.
        
        Change-Id: I295cc662ecab68eb23a6cb3a85606a4c95edeb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122159
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-16  Luboš Luňák  <l.lunak@collabora.com>  [d13b63a9859d653d1aba688a56590aa0ef24b89c]

        optimize SwRegionRects::Compress()
        
        This function gets called on modifying documents, and it shows up
        noticeably e.g. when profiling editing in Online.
        The code repeatedly restarts the whole process on most changes,
        but in practice this seems to only lead to repeated checks with
        the same outcome. So finish the whole compression and try again
        only at the end, if deemed needed. And even there I'm not sure
        if it's actually ever needed, since I couldn't trigger such a case
        in practice.
        
        Change-Id: I15b0a83c6865bad21fe60a7e9ca0b87ceea5b489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122156
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-16  Caolán McNamara  <caolanm@redhat.com>  [10a556f9e8653f5d94fba2703d8320639c64f5c7]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8867ab619acf0dcb7ba056f2b8754bd1778f1ccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122175
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-16  Johnny_M  <klasse@partyheld.de>  [81ebd481550657eb1b0d0e931388caa17a1effe9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a62af2400327a33a9e51b7d4697364ba14dfa9e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic4c682838a4e50c7d714850a57e403c60a7093e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121949
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-16  Johnny_M  <klasse@partyheld.de>  [f39219dbc92773acb0792e8cb0d04d4024476b99]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f54ef24da73bafb8da3ab5a05592c8b0e31edd4
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3d3b9bae635293c122d563c8da3d1d93d39a124a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121955
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-16  Michael Weghorn  <m.weghorn@posteo.de>  [836a226205df9e76e77d26af80f402de7b876d61]

        tdf#100086 wina11y: Don't delete a11y object for removed cell right away
        
        When handling a SELECTION_CHANGED_REMOVE event,
        AccDescendantManagerEventListener previously emitted a corresponding
        EVENT_OBJECT_SELECTIONREMOVE MSAA event with the removed child's ID
        as a parameter, then deleted that child's accessibility object.
        
        This resulted in the accessibility object no longer being available
        if accessibility tools queried for the object just received in
        the EVENT_OBJECT_SELECTIONREMOVE event.
        
        As a consequence, no 'event_selectionRemove' would be triggered
        for any table cell object on NVDA side, so an updated selection
        would not be announced for that case.
        
        To keep child objects available for such cases, don't delete the
        corresponding object in the handler for the SELECTION_CHANGED_REMOVE
        handler, but remember it for deletion and only do the actual deletion
        once a subsequent different event is handled.
        
        With this in place, the announcement for multiple selected cells in
        Calc generally works with the NVDA screen reader and a pending
        NVDA pull request [1] by Leonard de Ruijter in place
        (s.a. discussion in NVDA issue [2] for more background
        and further information).
        
        (There are still cases where events in response
        to selection changes are missing, as described e.g. in
        tdf#118508 and tdf#118748, but those are not winaccessibility-specific
        and it's the same when using the gtk3 VCL plugin with the Orca screen
        reader on Linux.)
        
        [1] https://github.com/nvaccess/nvda/pull/12849
        [2] https://github.com/nvaccess/nvda/issues/9310
        
        Change-Id: I7a46060c501ba9b8288e7c127121a535c60ce2bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122169
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-16  Miklos Vajna  <vmiklos@collabora.com>  [cf548fbcc637f2049c9c924e1ff774787cff06ec]

        sw layout xml dump: show SwLinePortion
        
        Towards showing details of multi-portions.
        
        Change-Id: If086df39127483820c245fe58f2de0ddf2c98694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122160
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [d5e55d204b71710eb5eb5d2c683dd6698626df3c]

        tdf#144319: sw_odfexport: Add unittest
        
        Change-Id: Ib3c6834150e7bc2538af413840b8b45b053af603
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122161
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-15  Noel Grandin  <noel@peralex.com>  [3372f93173b900c087073078a01d31916bf47783]

        add some logging for intermittent windows jenkins crash
        
        Change-Id: I8ad589dd8d0a64f75179d3330c80c9c43a21ff32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122155
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [afea504ad44f017f7020ed6dcc0191f7756acc93]

        loplugin:finalclasses
        
        Change-Id: I88831f290e1923db6fb5a733746bfa3bc7fbc7e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122148
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [fbb9a98a78a349aef7b69d29a7534fd35ff1aa53]

        loplugin:finalclasses in sd
        
        Change-Id: I6070a392319bdc4e04db3a36a6876c194c8a6495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122147
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [270bb6ef005c7b8932dfac0b801bfe65a2fb966c]

        loplugin:finalclasses in basic
        
        Change-Id: I3ec4ccb58dc3823eee8b6ab8bda31b128ee24569
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [20635ed31945d500685f7f667f0694410e49906c]

        loplugin:virtualdead HasExtraRedlineTable always returns true
        
        Change-Id: Ibc703b4c2adc6c6579cc4be50d274504ba957f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Michael Weghorn  <m.weghorn@posteo.de>  [ed1b10b3c0c2cab36a704dc8ffea51e387fc26d0]

        wina11y: Forward-declare XAccessible in AccObjectWinManager.hxx
        
        instead of including the header, as suggested by
        Mike Kaganski in the Gerrit change for
        
            commit 6bf771f0a5ba7be9955f05b307c190fb157adb47
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Thu Sep 9 11:36:57 2021 +0100
        
                wina11y: Use XAccessible* instead of void*
        
                Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d
                Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085
                Tested-by: Jenkins
                Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        
        (The header had actually been included previously, so
        the above commit had added it to the same header a second time...)
        
        Change-Id: Id6a6c5e2426bf07e41f29e1473ec1694970272c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122132
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [c76ed7c97f73e7d82ec337a0bc8b840346670a80]

        gtk4: remove text-button css property on setting a child image widget
        
        I suspect this happens automatically > 4.2.1
        
        Change-Id: I1b752ee5cec00005fe0f552548f38eab40249087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122144
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [aa9dd61ae0df736bbc7ef4bb0d31998d2d160de3]

        remove stray track-visited-links
        
        and add truncate-multiline for consistency
        
        Change-Id: I5a6fc0f0ac97a0f96739f2383b6d3eb474e776fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122145
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6419ecb40a025f1b4f7df5d059bfca3579dab4d7]

        No need to check if nDX is 0 for atan2
        
        We rely on IEEE floating-point arithmetic anyway, and then even both
        arguments equal to 0 do not result in an error.
        
        Even if it was different, it would be better to check id both nDX and
        nDY are 0, and return 0 early.
        
        It was so ever since "MWS_SRX644: migrate branch mws_srx644 -> HEAD"
        commit fd2cf3dc7cd9c73070fa4d70c8ca99c9fc1ce135.
        
        Change-Id: I5b8e2a359374dd1500b149d74eba4c0b0e5cd8d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122115
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Stephan Bergmann  <sbergman@redhat.com>  [7b37af5af6afe75ad952538c145a4f4e61de9a96]

        Fix broken ui file
        
        ...after 45c4caff685b15a0f1b87ef05436a7e6aca96851 "tdf#144483 sw mail merge:
        save ranges in a single document", causing CppunitTest_sw_dialogs_test to fail
        with
        
        > warn:vcl.gtk:2759211:2759211:vcl/unx/gtk3/gtkinst.cxx:21611: GtkInstanceBuilder: error when calling gtk_builder_add_from_file: ~/lo/core/instdir/share/config/soffice.cfg/modules/swriter/ui/mmresultsavedialog.ui:165:49 Invalid property: GtkCheckButton.group
        
        Change-Id: Ib846f3cb1883de50c28c13441aaf880ae1a480fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122153
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-15  Miklos Vajna  <vmiklos@collabora.com>  [f2e80f9f9b5d53ed270687f000bcb8b76dd81fb9]

        sw: add a DisableBuiltinStyles API setting
        
        The built-in Writer styles (e.g. Caption) are written to each & every
        document to help compatibility: this way if the built-in style changes,
        existing documents are not changing.
        
        While this is a good default, sometimes document conversion workflows
        want to ensure that no new styles are added to the document during
        conversion. This new settings allows to opt in for this behavior in case
        not polluting the doc model is more important than the negative effects
        of changing built-in styles.
        
        Change-Id: I43130a215ee10ee6952724dbef2caab7174ff77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122154
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [66df55d80034e924d6ca6c05b576e417873f358c]

        No need to check for x = 0 in atan2 here
        
        The guarantee is that either x or y argument is non-0.
        It was this way ever since "initial import" commit
        8ab086b6cc054501bfbf7ef6fa509c393691e860.
        
        Change-Id: I2f5ccbbc9a4f00aafef151ef3dd008eddeef0e78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122114
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [12623692b20f41cbcaf67c3cc171c95b08ef26ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 323c851c00559631e9e2ee1098d9aed89ca1d2ff
          - tdf#133851 connect help page to certificate path dialog
            
            Change-Id: I5a96785f32b81c6a8dd347b5665e1f5d0c7b84b2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122152
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-15  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [f67349bf75875e8ca2bb26f19cdfc53719483ea9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d599028d4f126c8a2badc3787e3fdf8277219c96
          - Improve another frankly inaccurate statement…
            
            ... and fix a couple of typos done in core commit 5e86949c479af5ef443f77b978fcb2b9021de848
            
            Change-Id: Ie7ed9da3a3858434ae9ff086d61587c8ffdcd02b
            
2021-09-15  Stephan Bergmann  <sbergman@redhat.com>  [485add3cd6240a0faceb7a74784d44b1c0a6705e]

        CppunitTest_sw_core_text needs some more RTTI now in UBSan builds
        
        ...presumably since 0c3e47cc2f0570a7cd8ff4889763991a86b29f26 "tdf#144305 sw: fix
        rendering of ruby portions with non-default ruby alignment",
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so
        > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI13SwLinePortion"
        
        and
        
        > DynamicLibraryManagerException: "Failed to load dynamic library: ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so
        > ~/lo/core/workdir/LinkTarget/CppunitTest/libtest_sw_core_text.so: undefined symbol: _ZTI14SwMultiPortion"
        
        Change-Id: Iaebffc3c9c0245d6092ef1dfc58213fd2d38d303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122143
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [dedb3337291c09c85262ca08bacd01e8e5901d22]

        Resolves: tdf#143487 don't draw a border at all for DrawFrameStyle::NONE
        
        Change-Id: I7794376c9475a32276d23135365c99a3f6fb7d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [5e86949c479af5ef443f77b978fcb2b9021de848]

        Fix some assorted mistakes in translatable strings
        
        Thanks Mihail Balabanov, Olivier Hallot and Tuomas Hietala for your keen eyes.
        
        Change-Id: Ibceeae6d82e39079c02140ac99729be1a1ab0407

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [7ac3ddefcfcb1d9bd29602fbf9c202da61d96f2c]

        default Aliasing of secondary mpAlphaVDev to the same as its owner
        
        when its created, as noted in...
        
        commit e1a5bcb20e15400320f926165b6d798fa36c564e
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue Sep 14 20:30:58 2021 +0100
        
            tdf#143831 fix black background appearing on spellchecking wavy lines
        
            ...
        
            OutputDevice::SetAntialiasing only mirrors its arg to the secondary
            mpAlphaVDev if it exists, and it doesn't exist until the size is set so
            move that call down a bit (this is probably another preexisting bug
            maybe worth following up on to set that when mpAlphaVDev is created)
        
        Change-Id: I8ef27aae4dcabe529327224bfc6cd7b4bb2a5af5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [c09aec4cb6e9bcbbe58999541fb2bdf7f54c3b44]

        loplugin:unusedfields
        
        m_pSoftMaskStream is dead since
            commit 581e7d7057afa87036d84e42c0e0a8a7368e20c7
            Author: Joseph Powers <jpowers27@cox.net>
            Date:   Thu Sep 1 20:51:15 2011 -0700
            unusedcode.easy: PDFWriter cleanup
        
        Change-Id: If397981fb09a7b74ba2294513c13186cc51ad5fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [a258237a3d25e704b215ef7b4d75e499abe4b20a]

        gtk4: allow combobox text width to shrink smaller than natural request
        
        Change-Id: I9648097ca9f77494ec4ddb2662dbc0372b998cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122140
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [95a6352da62725d1512c2e93e351684a89859cd4]

        loplugin:unnecessaryvirtual
        
        Change-Id: Ia7617a0fd4413cbaafaae8fbfee2b2ea819fde8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Alain Romedenne  <alain.romedenne@libreoffice.org>  [96368ad48061ba4b2d6f6b2a78a5f5ce42b67a66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ebe05a0be7226d4e35ed1cf96e60aaa2703234eb
          - extra bookmark in help
            
            Change-Id: I0f78b497a2f8921b75a73570e2799948997b48a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122113
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a1a448ac4a04137705ea0aaf0163358fd2e5549]

        loplugin:constvars
        
        Change-Id: I9b35d6333afa6b305bf73fc55a7e60c8365674e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [88a6ac9f75a4375b72111af5a3e004bef4226455]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5ae6f55789eebdc688ead4524a7af7a7739314bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122110
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Stephan Bergmann  <sbergman@redhat.com>  [bd7e394769f43c296a20c6faa48b6ae3a142c7a8]

        Uninitialized data member
        
        ...introduced in d467cd0dd9e9cf3b018859a592e2638527bc7add "tdf#135683 speedup
        DocumentRedlineManager::GetRedlinePos", causing isssues like
        
        > [_RUN_____] SwDocTest::testFileNameFields
        > /sw/inc/docary.hxx:238:50: runtime error: load of value 190, which is not a valid value for type 'bool'
        >     #0 0x2b89dcc7897e in SwRedlineTable::HasOverlappingElements() const /sw/inc/docary.hxx:238:50
        >     #1 0x2b89dcc40efc in sw::DocumentRedlineManager::GetRedlinePos(SwNode const&, RedlineType) const /sw/source/core/doc/DocumentRedlineManager.cxx:2624:25
        >     #2 0x2b89df2a4e8c in SwScriptInfo::selectRedLineDeleted(SwTextNode const&, MultiSelection&, bool) /sw/source/core/text/porlay.cxx:2653:44
        >     #3 0x2b89df285fbe in SwScriptInfo::CalcHiddenRanges(SwTextNode const&, MultiSelection&, std::__debug::vector<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind>, std::allocator<std::pair<sw::mark::IBookmark const*, SwScriptInfo::MarkKind> > >*) /sw/source/core/text/porlay.cxx:2687:5
        >     #4 0x2b89df29359b in SwScriptInfo::GetBoundsOfHiddenRange(SwTextNode const&, int, int&, int&, std::__debug::vector<int, std::allocator<int> >*) /sw/source/core/text/porlay.cxx:1917:9
        >     #5 0x2b89dfa1c1e6 in SwTextNode::CalcHiddenCharFlags() const /sw/source/core/txtnode/ndtxt.cxx:4522:5
        [...]
        
        during CppunitTest_sw_uwriter at <https://ci.libreoffice.org/job/lo_ubsan/2135/>
        
        Change-Id: I42c8801f83d2e92a826864494b1f0f4c63f30f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122109
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [2987a0f4d38463a167e23c243668974d2cb863fb]

        Related: tdf#143831 the svp aliased case ends up overly washed out
        
        as seen under gtk3
        
        Change-Id: I0bcea49f8c24e9f773b357483cea78e58bb07e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [17e22f416fde350d89b935922911f0172cdeaa8c]

        Related: tdf#143831 add guards to ImplDrawWaveLineBezier
        
        seeing as the mpAlphaVDev ImplDrawWaveLineBezier sub call is not
        protected otherwise now that it can be called from the outer case
        
        Change-Id: I66f0fea134aa177bd7493720670c4724311752a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122098
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Caolán McNamara  <caolanm@redhat.com>  [e1a5bcb20e15400320f926165b6d798fa36c564e]

        tdf#143831 fix black background appearing on spellchecking wavy lines
        
        SetBackground() doesn't fill the outputdevice automatically, Erase()
        has to be called to do that.
        
        Then the way the horrible transparency split 24bit rgb + 8bit alpha
        thing works is that the same thing has to be drawn into the 24bit
        surface and the 8bit surface with black used as the line/fill color
        in the 8bit surface.
        
        OutputDevice::SetAntialiasing only mirrors its arg to the secondary
        mpAlphaVDev if it exists, and it doesn't exist until the size is set so
        move that call down a bit (this is probably another preexisting bug
        maybe worth following up on to set that when mpAlphaVDev is created)
        
        Change-Id: I39f71def6b51d78746b41ed2e30a36dc150370bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-15  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [584b10b232faea346d135d87b2ac34560cd704e2]

        Save with Glade 3.38
        
        Change-Id: Ib32cd43d83828b6f28fc193fd77a9def742e0384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122088
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-15  Miklos Vajna  <vmiklos@collabora.com>  [e8298918ae4a71e1a00f5efc10d9e72bb34deac6]

        sw layout xml dump: show SwParaPortion
        
        Towards showing details of multi-portions.
        
        Change-Id: I3afb84731ae716557279d6253347c57fada710af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122094
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [72079bb39b7460a6aff739043e3d7f00a572847d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b8e1cd0bed6eb458e028a251408d97895e419c67
          - typo
            
            Change-Id: I906462045e1fbeb6daa4dafbdeb6d7e2ac444dd8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122070
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [96bd77de5ad7b7a13f7e48e0f95c05ef49255aa0]

        Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 5
        
        - Revise uses of getSomething to use getFromUnoTunnel
        
        Where that is impossible, use getSomething_cast to unify casting,
        and minimize number of places doing low-level transformations.
        
        The change keeps the existing tunnel references that last for the
        duration of the pointers' life, because sometimes destroying such
        reference may destroy the pointed object, and result in use after
        free.
        
        Change-Id: I291c33223582c34cd2c763aa8aacf0ae899ca4c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122101
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [3f65724ec5fc92d5a0078a99932358ef7091435c]

        Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 4
        
        - Change implementations of getSomething to use getSomethingImpl
        
        Or where that's impossible, use getSomething_cast to unify this and
        reduce number of places where we reinterpret_cast.
        
        All static methods getting tunnel ids were renamed to getUnoTunnelId,
        to comply with the convention used in <comphelper/servicehelper.hxx>.
        
        TODO (in separate commits):
        - Revise uses of getSomething to use getFromUnoTunnel
        
        Change-Id: Ifde9e214b52e5df678de71fcc32d2199c82e85cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122100
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6444b026b4039458d01ada5fee58eae98166585b]

        Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 3 [API CHANGE]
        
        - Replace all uses of OImplementationId in core with UnoIdInit
        - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>
        
        OImplementationId uses broken double checked locking; additionally,
        it uses it at the first call to getImplementationId, not when the
        object is constructed. This implementation can't be changed, cince
        it's part of published API; it can't rely on C++11, which would be
        required for use of thread-safe statics and move the initialization
        to ctor.
        
        The class has obsolete _bUseEthernetAddress member, that is unused
        and ignored since 4e9fa7e339a1cd6cb2fec643715991bcf5057cec. No need
        to implement it when replacing its uses to UnoIdInit.
        
        The deprecation is the API CHANGE. No published API is introduced to
        replace it; 3rd-party code should seek alternative solutions, or just
        keep using the deprecated functionality.
        
        TODO (in separate commits):
        - Change implementations of getSomething to use getSomethingImpl
        - Revise uses of getSomething to use getFromUnoTunnel
        
        Change-Id: I8b6e684e5389bc0d5bb3b7f21f72a4c8f684107d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122077
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [21a9ec75777f97886aa92a2a8a7c5945a8d0746f]

        Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 2
        
        Replace uses of sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation with
        respective comphelper::getSomethingImpl and comphelper::getFromUnoTunnel.
        Drop the former from sw/inc/unobaseclass.hxx.
        
        TODO (in separate commits):
        - Replace all uses of OImplementationId in core with UnoTunnelIdInit
        - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>
        - Change implementations of getSomething to use getSomethingImpl
        - Revise uses of getSomething to use getFromUnoTunnel
        
        Change-Id: I1e350a88260277a67b833af56b285ac2277f433a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122075
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-15  Mike Kaganski  <mike.kaganski@collabora.com>  [05bc93db2de56000f65764d7e394d03747cac23d]

        Use <comphelper/servicehelper.hxx> implementing XUnoTunnel part 1
        
        The header got some changes:
        1. Move UnoTunnelIdInit and isUnoTunnelId into 'comphelper' namespace
        2. Rename UnoTunnelIdInit to UnoIdInit, as a precondition to replace
           of uses of OImplementationId with it, including in XTypeProvider
        3. Introduce convenience functions 'getSomething_cast' to cast between
           sal_Int64 and object pointers uniformly.
        4. Rename getUnoTunnelImplementation to getFromUnoTunnel, both to make
           it a bit shorter, and to reflect its function better. Templatize it
           to take also css::uno::Any for convenience.
        5. Introduce getSomethingImpl, inspired by sw::UnoTunnelImpl; allow it
           handle cases both with and without fallback to parent.
        6. Adjust UNO3_GETIMPLEMENTATION_* macros
        
        TODO (in separate commits):
        - Drop sw::UnoTunnelImpl and sw::UnoTunnelGetImplementation
        - Replace all uses of OImplementationId in core with UnoIdInit
        - Deprecate OImplementationId in <cppuhelper/typeprovider.hxx>
        - Change implementations of getSomething to use getSomethingImpl
        - Revise uses of getSomething to use getFromUnoTunnel
        
        Change-Id: If4a3cb024130f1f552f988f0479589da1cd066e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122022
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-14  Stephan Bergmann  <sbergman@redhat.com>  [8cbb414ed737f9ffc76e1258e6671769bf63fc6c]

        Untabify odk/util/check.pl
        
        (trying to change the actual content of those lines would otherwise trigger our
        "indent with Tab" git commit hook)
        
        Change-Id: I97449056eb7850d3993fa5ac565e342d0bcbf200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122093
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-14  Noel Grandin  <noel@peralex.com>  [d467cd0dd9e9cf3b018859a592e2638527bc7add]

        tdf#135683 speedup DocumentRedlineManager::GetRedlinePos
        
        use binary search
        
        Change-Id: Icd442ba18cb27cdcb5955fa8bbce421b26d5ad44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-14  Stephan Bergmann  <sbergman@redhat.com>  [7469af24baeb74f171edec459d50e4502abe5017]

        Drop some useless conversions to sal_Int32
        
        These started out as sal::static_int_cast<xub_StrLen> in
        1b9a6329fcda25fd738bd0e0a36663a6e745cab8 "INTEGRATION: CWS calcwarnings",
        presumably to silence some signed-to-unsigned conversion warnings, then morphed
        into the completely useless sal::static_int_cast<sal_Int32> with the String ->
        OUString changes (where the length parameter changed from unsigned xub_StrLen
        to signed sal_Int32), which then started to hide erroneous overflow (see e.g.
        4a4be7a1edead11b48e1a8598e52a3246e6744bb "tdf#144106 Don't proceed ptrim_i past
        ptrim_f") from tools like -fsanitize=implicit-integer-sign-change with the
        OUString -> std::u16string_view changes (where the length parameter changed from
        signed sal_Int32 to unsigned std::size_t).  If there were demand to prevent
        signed-to-unsigned conversion warnings here, that should be done with
        o3tl::make_unsigned instead.
        
        Change-Id: I9b078658500b6ed5dcd0e860d2f0b725133188f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122092
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7aa9f089e2f005c41d804530612e535c372f6c8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d098ee2b7fba8b173fd718490c8e537c13d936b0
          - fix path of embed
            
            Change-Id: I99168be951490a532ca7cc0ab2be906584bd7290
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122068
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-14  Balazs Varga  <balazs.varga991@gmail.com>  [45c4caff685b15a0f1b87ef05436a7e6aca96851]

        tdf#144483 sw mail merge: save ranges in a single document
        
        In the Save mail merged document dialog, it wasn't possible
        to save mail ranges in a single document, because of the bad
        UI of the dialog window: grouping range selector as a radio
        button with the single document/individual documents radio
        buttons. Moreover, commit f3993912ec4b526aa57cb4bfb4745d7298a4da82
        "tdf#144427 sw mailmerge: fix merge all document" removed
        the hidden workaround: setting range at the third radio button,
        and selecting the first radio button. Using checkbox for the
        third option solved the problem as proposed.
        
        Change-Id: I43798fb036de07d1001bcb8d72c20de2d9c577b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122078
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-14  Miklos Vajna  <vmiklos@collabora.com>  [2bf269745bed9fefe32122fc432e239949bdf605]

        sw: fix undo manager de-registration from editeng on shutdown
        
        editeng/ asserts in the ImpEditEngine dtor that the undo manager it owns
        is indeed an EditUndoManager, and not a subclass. This means that if a
        subclass is set as the undo manager of editeng, then SetUndoManager()
        should be called in pairs: once to set it and once to unset it. The
        unset should happen before destroying the EditEngine.
        
        This normally works because SwView either has an active text edit and
        then its dtor calls SdrEndTextEdit() or it doesn't have an active text
        edit.
        
        The broken case was when the text edit was already ended, but the draw
        view still had a text edit outliner, which has an EditEngine, which
        knows the sw undo manager. The product build deleted the sw undo manager
        when deleting the EditEngine, and then later when the SwExtTextInput
        dtor wanted to access the sw undo manager, it crashes due to
        use-after-free.
        
        Fix the problem by explicitly disposing the undo manager of the draw
        view in the dtor of SwView.
        
        Also fix a couple of more places where an SdrObject* is returned and we
        didn't check if the result is a nullptr.
        
        Caught by the loolstress tool in online.git:
        
        cp test/data/hello-world.odt /tmp/test.odt
        ./loolstress ws://localhost:9980 /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-hello-shape.txt /tmp/test.odt test/traces/writer-mash-text-table.txt /tmp/test.odt test/traces/writer-mash-text-table.txt
        
        Change-Id: Ib838b2adf900b4f3bec63d2d62d432327bc0c6c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122086
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-14  Michael Weghorn  <m.weghorn@posteo.de>  [6bf771f0a5ba7be9955f05b307c190fb157adb47]

        wina11y: Use XAccessible* instead of void*
        
        Change-Id: If52de3a71af63697815e4ec6a19f9139d5a6973d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122085
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-14  Tibor Nagy  <nagy.tibor2@nisz.hu>  [9bb91441b46d677860530d8bf9597c96561a1b0a]

        tdf#141704 PPTX import: fix hyperlinks on images
        
        Hyperlinks on images pointing to the "first/last/
        previous/next" slides and "exit presentation/go to
        the website/go to the slide" weren't imported.
        
        Note: images added via the Content placeholder
        will be fixed later.
        
        Change-Id: Idda1ff6fd3243b06262637c7c8e579e78309e317
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121369
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [431c8411b446528ba45ac76e8c39726ff4c0a4df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b7491d7d5cd174d4100c3de5f46cff20d7840809
          - typo
            
            Change-Id: I1b26b14b3fdcf47351601ce5ea7bbdbadb65d887
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122067
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-14  Stephan Bergmann  <sbergman@redhat.com>  [45227d9b79dc4f2a2aa6874cd4e3c02b7934b197]

        Adapt to Bison 3.8 internal yyn -> yyrule rename
        
        see
        <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=f30067ed51f23802fc91761ede1506dfa72b2865>
        "glr2.cc: log the execution of deferred actions" including "Rename argument yyn
        as yyrule for clarity."
        
        YYBISON was defined as 1 rather than as a representation of the Bison version
        prior to
        <https://git.savannah.gnu.org/cgit/bison.git/commit/?id=21c147b6e5372563b7c4741deadaddb9354f4b09>
        "yacc.c: provide the Bison version as an integral macro", which shouldn't be a
        problem here.  And YYBISON is apparently completely undefined with
        /usr/bin/bison on macOS.
        
        (The preceding comment always mentioned "yyi" and "yyrmap" in apparent mismatch
        with the actually used "yyn" and "yyr1" ever since
        c25ec0608a167bcf1d891043f02273761c351701 "initial import", so just leave it
        untouched.)
        
        Change-Id: I4f901407aa21ed4abec84e661d813ee7599f02f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122082
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-14  Caolán McNamara  <caolanm@redhat.com>  [94e8c4a7784b296a3b80ed1cb27db321206b37e0]

        ofz: Null-dereference READ
        
        Change-Id: I4f6d93943bd0c9e5834952b56beb6bd84411a55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122084
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-14  Caolán McNamara  <caolanm@redhat.com>  [19244b9f316cbbc22d9a7b0bfa13f0ef62b947d7]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib3afba47155bc70f579284244514d745f1075f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [f09596c9dfa627f51c431dd32ae5953d55b867ee]

        tdf#143854: Revert "tdf#57585 Add new bullet behaviour to impress"
        
        This reverts commit 070a5b039b181c380b1b9724a015314ff78c30ed.
        
        Reason for revert: Many PPT files are affected when saved to ODP.
        I waited a while before reverting it but not reaction from the
        developer
        
        Change-Id: Ibfd2f508930e1a3ef56961536454ea1eda55f8c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122061
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-14  László Németh  <nemeth@numbertext.org>  [f481c2c8e74bded11fac754e493560391229dbcd]

        tdf#144057 sw track changes: hide deleted table rows
        
        and tables in Hide Changes mode. Previously it was
        possible to "hide" them only by accepting all the
        deletions, because Hide Changes mode hid only the
        cell content, but not the deleted rows and tables,
        leaving empty rows and tables in the document.
        
        Follow-up of commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: Ib0424f5a17f2213fc7466e966d8ce6812ffde5e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122079
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-14  Caolán McNamara  <caolanm@redhat.com>  [e71d011a59e12683df25c893bd0b989b5f659d79]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5906dc1f9f0295d406c01871e5fed1da0025682f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-14  Michael Stahl  <michael.stahl@allotropia.de>  [37e7398e9cb02d19a0825fe2e72f5adc2296d06d]

        configure: test_curl is always "yes"
        
        Presumably this should check enable_curl instead.
        
        Change-Id: Ifc0b871e9c34bdb43ef14b8002d4997860266a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122040
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-14  4k5h1t  <ask160203@gmail.com>  [5f4a84ce5b775eb017bd784db95857684b7e90ed]

        tdf#42982: improve UNO API error reporting
        
        Change-Id: I1252c89f23e70eb88744585bb2abd4fe3794e1d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121918
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-14  Miklos Vajna  <vmiklos@collabora.com>  [2e68bce7df95f386e5cbd5c1fd90c5baeedb9a66]

        svx: GetMarkedObjectByIndex() may return nullptr
        
        Seen in this crash:
        
        	#6  SdrMarkView::ImpIsFrameHandles() const (this=this@entry=0x7f5a310) at svx/source/svdraw/svdmrkv.cxx:594
        	#7  0x00007f9779c71058 in SdrMarkView::HasMarkablePoints() const (this=0x7f5a310) at svx/source/svdraw/svdmrkv1.cxx:32
        	#8  0x00007f9779d0c142 in SdrView::GetContext() const (this=0x7f5a310) at svx/source/svdraw/svdview.cxx:1297
        	#9  0x00007f976185adf4 in SwWrtShell::GetSelectionType() const (this=this@entry=0x7f32d90) at sw/source/uibase/wrtsh/wrtsh1.cxx:1424
        	#10 0x00007f9760e3d5b9 in SwCursorShell::sendLOKCursorUpdates() (this=this@entry=0x7f32d90) at sw/source/core/crsr/crsrsh.cxx:2055
        	#11 0x00007f9760e4046b in SwCursorShell::UpdateCursor(unsigned short, bool) (this=this@entry=0x7f32d90, eFlags=eFlags@entry=6, bIdleEnd=bIdleEnd@entry=false)
        	    at sw/source/core/crsr/crsrsh.cxx:2041
        	#12 0x00007f9760e41747 in SwCursorShell::EndAction(bool) (this=0x7f32d90, bIdleEnd=bIdleEnd@entry=false) at sw/source/core/crsr/crsrsh.cxx:276
        	#13 0x00007f976105865a in SwEditShell::EndAllAction() (this=this@entry=0x7e98ed0) at sw/source/core/edit/edws.cxx:102
        	#14 0x00007f976109f8ed in SwFEShell::DelSelectedObj() (this=0x7e98ed0) at sw/source/core/frmedt/feshview.cxx:2295
        	#15 0x00007f976184a447 in SwWrtShell::DelRight() (this=this@entry=0x7e98ed0) at sw/source/uibase/wrtsh/delete.cxx:442
        	#16 0x00007f9761680d6b in SwEditWin::Command(CommandEvent const&) (this=0x7e9ba10, rCEvt=...) at sw/source/uibase/docvw/edtwin.cxx:5483
        
        Change-Id: I916be9ce846c8750acdaf5fc791e1adb3692e002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122076
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-14  Miklos Vajna  <vmiklos@collabora.com>  [0c3e47cc2f0570a7cd8ff4889763991a86b29f26]

        tdf#144305 sw: fix rendering of ruby portions with non-default ruby alignment
        
        Regression from 301278b656e76b6f42af5cf8a6f5c6c02acfffeb (sw: allow the
        height of a line to be larger than 65536 twips, 2021-05-20), the problem
        was that changing from sal_uInt16 to sal_uInt32 broke
        SwRubyPortion::Adjust_(), which relied on integer promotion rules to
        have a negative diff.
        
        Old storage size was smaller than int, so got promoted to signed int, so
        the result could be a small negative number.
        
        New storage size is an unsigned int, so no promotion happens, so the new
        result was a large positive number.
        
        Fix this by casting to signed int explicitly.
        
        Change-Id: I8778c1bd0d62e27c99d4ceb1bb7bc6107a179803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122048
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-14  Ross Johnson  <ross.johnson@homemail.com.au>  [acfa87f58ff093cf3663cb697bf24ec187ea2c2f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 103d2d6a3525d7b4972300702bffa92aa71011c3
          - tdf#100777 - update related documentation for ctrl-UP Arrow
            
            Change-Id: Iec89eda03e243feff68e407f01ee693a5fe8ed83
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122052
            Tested-by: Jenkins
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            
2021-09-14  rocso  <ross.johnson@homemail.com.au>  [74916fc339dcd9fa343e4bd33977733092ee6ca4]

        tdf#100777 - Bind Ctrl+Up to uno:GoToStartOfPara (instead of prev paragraph)
        
        Change-Id: I87707ab2779ddbbb72a67620d3760c0a61ee7599
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122032
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-14  Eike Rathke  <erack@redhat.com>  [80a47aae1419842f4496f02028e2b49763aea25b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7fcb420ec4010eeaad4176d6df0dcc7451aa9094
          - Update ICU regexp URL
            
            Change-Id: Id64c141945e981560e01b789a3664955af923528
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122074
            Reviewed-by: Eike Rathke <erack@redhat.com>
            Tested-by: Jenkins
            
2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ed80a48d0a410b5a44ab6c82b5ff872348372490]

        tdf#144457: sc: Add UItest
        
        Change-Id: I1ad059db209a90a8cf5a78ca8cbd6eaabded8195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122039
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Caolán McNamara  <caolanm@redhat.com>  [1e531c31600a76e1d55e2f2e5abd351ff80bc4fd]

        tdf#142415 mouse events not propogated to table control event handlers
        
        handle this with explicit callbacks from the cell widget for those
        events
        
        Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122050
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a7084f156a75ab363d2562b485b240bd350563fc]

        tdf#126879: sw_htmlexport: Add unittest
        
        Change-Id: Id3abc7cf73756255d408f01cef47d02f89b79190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122051
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-13  Stephan Bergmann  <sbergman@redhat.com>  [4a4be7a1edead11b48e1a8598e52a3246e6744bb]

        tdf#144106 Don't proceed ptrim_i past ptrim_f
        
        ...which would cause p2 - p1 to be negative in lcl_appendLineData and thus
        construction of a std::u16string_view with a huge positive length of type
        size_t.  In 64-bit builds where size_t is 64-bit, that would then cause
        termination due to an uncaught std::bad_alloc.  But in (implicitly)
        --disable-assert-always-abort 32-bit builds where size_t is 32-bit, this would
        silently have worked before 1efec9ec21dba32335e311d367b636538e219621 "Tighten
        rtl_{string,uString}_newFromStr_WithLength implementation", when the huge
        positive size_t value was cast back to a negative sal_Int32 that was gracefully
        handled by rtl_uString_newFromStr_WithLength.
        
        Change-Id: I3b95a9fce62b99ffc150f76a1c6ccddcdacdae0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122038
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [079b254d2698986cde1650ff178ac3ac97caf0d7]

        loplugin:mergeclasses
        
        Change-Id: I908518ac14715f7e546a154b1d5a5ab77eeb4155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122021
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-13  Eike Rathke  <erack@redhat.com>  [37e2e99f7a3018dce0337b582b139d41e1e81a9a]

        Explicitly set cursor position for x11 'gen' backend, tdf#144457 follow-up
        
        ... (and other backends?)
        
        Change-Id: If45b83080aa2df50ef27ad282eb6fa1d4a022703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122037
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-13  Michael Weghorn  <m.weghorn@posteo.de>  [b307eee222023a2ea0f45bb0cf21db206deb52b4]

        ScAccessibleSpreadsheet: Use 2 local vars instead of class members
        
        Those vectors are only used in
        'ScAccessibleSpreadsheet::CalcScAddressFromRangeList' and cleared
        before use, so just use local variables instead.
        
        Also, use a 'std::pair<SCCOL,SCCOL>' instead of a
        'std::pair<sal_uInt16,sal_uInt16>' for holding a
        pair of column indices and drop the 'PAIR_COL' typedef.
        
        Change-Id: Iacddba03cb72a5cfb6cf3ced0001258ef9db9107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122028
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-13  Michael Weghorn  <m.weghorn@posteo.de>  [a74aeceda27879d2f441d21338e2a24a9a9957ee]

        Drop unnecessary extra indentation
        
        There's no reason to introduce extra blocks here.
        
        Change-Id: Ie3e72e8535617865646bb8161890aebfbc0db4d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122027
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-13  Eike Rathke  <erack@redhat.com>  [366b5878015b8cd75ceb7f2db00d286dafa365bd]

        Check string bounds
        
        Doesn't occur in practice because all date acceptance patterns
        start with a YMD character, enforced by the dialog, but just in case..
        
        Change-Id: I8ed43a272e9501c6977888b1f587ed14c85024ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122025
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [ded2c1eee423235bc26ff4ab467988ab286e59d4]

        tdf#144085: sc_macros_test: Add unittest
        
        Change-Id: I8f5d8fa6efebaeb686baca280c7b9850a6192aad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122031
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Stephan Bergmann  <sbergman@redhat.com>  [53165f584ff777df429fc43a451614d88914627d]

        loplugin:simplifypointertobool
        
        Change-Id: I0186e8f1566ec2e4cec768cc18bdeba0bae182b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122033
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c7c7bcdbd3e47cad5c6b94e1ed1c5314dbdbf6b]

        loplugin:cow_wrapper
        
        check the classes that use o3tl::cow_wrapper so that they
        don't unnecessarity trigger copies
        
        Change-Id: I545e627598217f3e61ba2c384adb8d4f8b404829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-13  Rene Engelhard  <rene@debian.org>  [5979076a14098f6887b61e937cfc9059ff7f2506]

        fix ccache size detection with ccache 4.4
        
        which changed format. but ccache -p has the same format in 4.2 and 4.4
        so use that one
        
        Change-Id: I4de0241109c580becb96ce0c1b461c2642a4631e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120928
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-09-13  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [2fb94b482b430a6b6b5a58a46d590847410bd8b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 74c629f13542c1ee188cd5e9723528e97536e80e
          - This statement is kinda arrogant. Explaining things is the job of Help.
            
            Change-Id: I1f6eb627ac082317cfe0f42c9d344ceac7ccac46
            
2021-09-13  Eike Rathke  <erack@redhat.com>  [eb0b4ab2d3b86d77ee0edb652d4486343e5b3b1f]

        Resolves: tdf#116184 Check that there is no trailing number behind a match
        
        ... without being separated by a blank so the match is rejected if
        it doesn't possibly form a date+time input and input can be
        accepted as decimal fraction.
        
        Change-Id: Iabd1d216366ecb8454c59822ce58f112bfa6091e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122024
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d99ae3f98f3333b0aba4f213fc40f4c22ab9cf5]

        loplugin:methodcycles
        
        Change-Id: Ia14e47b811ca56d8d4517f262e008985d6aebe35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122020
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-13  Ming Hua  <plateauwolf@qq.com>  [b641fccab785cc7dede720f7d5844e4f0cb95b91]

        CSV import dialog: fix tooltip for "Evaluate formulas" option
        
        This option was added in commit 4c29c2bfab18b25229e0bc71014fd2ca42ec5bff
        with appropriate label and extended tooltip, but the (regular) tooltip
        seems to be just copy-and-pasted from "Skip empty cells" option and not
        changed to fit the new option.
        
        Change-Id: I2425f4dc67468f152a7180d98e2e48c15de351fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121987
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-13  Michael Weghorn  <m.weghorn@posteo.de>  [cda060d6c340b3d050c823fcaa331d27f4dafb5f]

        a11y: Set new tab name in AccessibleEventId::NAME_CHANGED event
        
        The previous use of 'sOldName' instead of 'sNewName' looks like a
        copy paste mistake which would result in "Sheet %1" being
        set for the new name.
        
        cppcheck warned about this:
        "Variable 'sOldName' is assigned a value that is never used.
        
        Change-Id: I8676f42bb6548ce1618d14f84b77541f279bac58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122023
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-13  Luboš Luňák  <l.lunak@collabora.com>  [26072b8db7ba53f00c83197cb064229a76001989]

        properly separate code built with different CPU settings
        
        Trying to write smart code and mixing different CPU flags doesn't play
        nice together. Those global variables are not runtime-protected by
        a CPU check, and so may crash with illegal instruction error.
        And those inline functions may not get inlined and the compiler is
        free to choose just one copy, any of them, so it may be the one
        requiring the most demanding CPU settings.
        So use only dumb code in files compiled with CPU intrinsics.
        
        Change-Id: I8200fd4d9f991fab6fdc741120e7aa96ff9b470d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121929
        Tested-by: Jenkins
        Reviewed-by: Dante DM <dante19031999@gmail.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [f75bae7082322a2e79997d041ce5f8afd3910107]

        uitest: combine execute_modeless_dialog_through_command methods
        
        Change-Id: Idada1927f6b8b55133e1ff8c776a987699df1dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122012
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [714278ce47692d57965b06e8b83de632e6e97d2d]

        uitest: guard the remaining execute_modeless_dialog_through_command
        
        Change-Id: I239fe94cc8983e679c82aa43d74d8099b13e73b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122011
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [1301d8461ec5112ad8bc672dd1ac141238a29cef]

        uitest: guard execute_modeless_dialog_through_command in sw
        
        Change-Id: Ie3acd6eb716d6d3532bb50b5b9002f80044a2bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121913
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [47847b879bf6b5bb6e0f6117e0f9683b3a932a08]

        uitest: guard execute_modeless_dialog_through_command in sc
        
        Change-Id: Ifd03ae26659ff56d36bfe8d4938d690ada761d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121912
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [a917d4abd8577cf7d6655f0484ff55dd86a0a8a1]

        uitest: guard execute_modeless_dialog_through_command in sd
        
        Change-Id: I4d67318af30b00182253de5f6ccf9cafd7664ee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121911
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-13  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [c10c32438025edda2f3c178b47d369e7979f25a8]

        tdf#144352 Revert "Fix widget placement problem on mailmerge result dialog."
        
        This reverts commit 0a3e5ba4db254549c15e55984f1764a352c8239b.
        
        Reason for revert: Causes the dialogs bottom part to slip on top each other, most visibly on Windows
        
        Change-Id: I6e5a30fbb4611a7b1250b173adccdb47c95eea02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121879
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-13  Miklos Vajna  <vmiklos@collabora.com>  [e7a40c0ded1ba26b6b8f3da5a0b894e9c7ee7a96]

        sw: prefix members of SwChapterNumRules, SwDBConfig, SwGlossaryList and ...
        
        ... SwModule
        
        See tdf#94879 for motivation.
        
        Change-Id: I0bf6d2cf5fdaed76eadc801d654a2cea7700f046
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122018
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-13  Justin Luth  <justin_luth@sil.org>  [f76f2fc99dcb4a6a250835ec1d52e7c3f6a73321]

        tdf#137363 DOC export: don't lose sprmPIlvl of para style
        
        Move the DOCX code so that it provides the style's level
        to all three formats. (RTF just returns when no text node,
        so there is no impact in that case).
        
        Change-Id: Iadeb3e6d9f4e3f0d86222cb3f6bfef84d87d87f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121909
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-13  Balazs Varga  <balazs.varga991@gmail.com>  [f3993912ec4b526aa57cb4bfb4745d7298a4da82]

        tdf#144427 sw mailmerge: fix merge all document
        
        Not all records were merged if we selected the “From 'X' To 'Y' of the
        “Save Merged Documents” or “Print Merged Documents” or "Send to Email"
        dialog windows and write some value into them and then we switched back
        on to Save/Print/Send All record (opened via the Mail merge toolbar).
        
        Regression from commit: ec44f87d5b99a3299322d0b79abc4c6808877865
        (tdf#117212 sw mailmerge: merge only the selected range)
        
        Change-Id: I01fc664fe76f74cefe4faa81b324088ec37b9881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121867
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-09-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [29b34a06a55bbb85d84e1ca2d728f325d355f871]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9752b605c749cc617a5cda6e3430b3e87bbbdf3a
          - Mute l10n in some paragraphs
            
            Change-Id: I17e5eaa059750aa3546ff0f0fee136c6df9dbcda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121980
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2f755ae4bf69951c29ec64c5df500687051e4ee3]

        indexing: prevent crash when creting the indexing XML
        
        The pOutlinerParagraphObject can be null, so need to check for
        that or the applciation can crash.
        
        Change-Id: Icf771bb9ae2c344ed04e8ec27a22390a272ad725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121998
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-13  Eike Rathke  <erack@redhat.com>  [0a9b68c9f9880655576e3220d8b70064b367dbee]

        Resolves: tdf#144135 Rework Sort with area extras
        
        Since
        
            commit 774a61afa9fc281290e7bfad4e28c05978b82d73
            CommitDate: Wed Apr 14 08:46:03 2021 +0200
        
                tdf#126678 - Consider "Include formats" option during sort
        
        a sheet formatted with visible attributes like cell background
        colour up to the end if for Sort all columns and/or rows are
        selected lead to an excessive memory allocation and slow execution
        time if it didn't get killed by the operating system before due to
        memory exhaustion.
        
        The same could had happened already before if graphics or comments
        were to be included that could had resulted in a similar large
        range. However, cell formats across sheets are more likely.
        
        This changes the strategy how the to be sorted data range is
        determined (range only with data) and additional area extras
        ranges without data that are only to be rearranged. Those are then
        processed in chunks (limited to ~512MB per chunk).
        
        Cell formats that are identical within one column's rows range do
        not even need to be covered as they are not rearranged, in the
        best case leading to all trailing formats' ranges being excluded
        from the sort.
        
        Additionally optimize the cell gathering of formats, graphics and
        comments such that for the area extras they are only collected if
        actually requested.
        
        The overall performance gain is in an order of magnitudes even if
        some extras are to be collected.
        
        Change-Id: If3abbaeaa615aaff7d88a82a5b3fc7ac633d770d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122013
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-13  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [daa1469e3e7bfe840efb6f3fad1bac63a2577e3f]

        tdf#123642: keep last bookmark at the document end
        
        In some cases DomainMapper_Impl::RemoveLastParagraph() can also remove
        last bookmark from real last paragraph. This does never happens
        when we use xParagraph->dispose(), but pretty always during older
        way with xCursor->setString(OUString()).
        
        Unfortunately without deep refactoring of redlines, bookmarks, etc.
        I see no other way to avoid this removal except given hack which is
        trying to store last bookmark and if it did disappear restore it.
        
        Some existing unittests were adjusted: corresponding original DOCX
        files did contain final bookmarks not taken into account by the code.
        In some cases test code is modified, in some just removed final
        bookmark in DOCX: such multi-format tests as in ooxmlfieldexport.cxx
        will be more identical to RTF & DOC variants.
        
        Change-Id: Ie9948b58cda705a0b85fa8e5e08b72fbb7d682b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121409
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-09-12  Johnny_M  <klasse@partyheld.de>  [29413fca12ae2357bd684a71d354826bdd1b74bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e5a4988f74ae01c6bd8e247aaf7c709bba1c28c9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I987a7f47bed2edd46435487209d72a906cd18fbc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121953
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [fcfb62c22d7a2317e392192207fa0186aa9a54a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6027402b3676a81f53903644341d97892c704f3d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7be425ea9e8e2e5205115615639f9d18dae1562d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121951
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [fe4b8f3260373f4e2d715556a05e427cb03e09b2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 46cbff41e46e04bd8bd95743c3c8bda19fc84896
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6de8cfb1537bdff0f4d19048561d236d056826a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121954
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [47efca62f0efe6d21273297951b9eef9f74fa6b4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d2a700d9f66dfa21e387b20bb4996be1d9e49d5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I916b45d28274b3c17ac072257e6317b6f3b65e2a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121948
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [c9fdfa8110dba715b8f5d7810a6ee5ec28c22de7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1496973f17c8ff16da8b57b8353d87ffd1aea7b6
          - tdf#132643 Translate German section IDs
            
            Change-Id: I4c24a6e40c58a7437f04f6ec8951aec2161013f5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121952
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [35bc1bb2f128886a688e4a0f4c6a580a5e4893b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 797a729541791bd7e8040b20b9f81f43f8b8e306
          - tdf#132643 Translate German section IDs
            
            Change-Id: I15e4411f218b7866ae4e22db4c17e117170e387b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121950
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [b1de45332986de8a058bea3751e7888c756163a6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e899e29b59b615ff59573ba4b9bbfd97ef65282a
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Id6b6d0ba56813ad7746c21e80dac218d0d79a99a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121947
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [cc2852dc7718c81285cd10c2cc0f4d6e0c3d0bb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1d31ac0d9e24416746afdbeef04cdb4287d67d6a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib6abce134c865ec364819addf45ec1cf1e07cb0b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121944
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [22f5c4ff461980547047870febecf19aaa01d76d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8f479f59b39e68d89f312c62d1d09a1be5d012f5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5c5be4b33e90c48cbfc403f688785bf0b7dde721
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121946
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Johnny_M  <klasse@partyheld.de>  [8a8636ac8b915332bfc9d270e3818648cc31a4e2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd4f960f31f75b026b19237caf80f872d363ec32
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia198e1691360d18b9639cd62ef7a65bc3c6a568b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121945
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [78a2c0752c599d5dc951b8cf6fbe741bda0eeedd]

        ofz: better workaround for broken msan build
        
        workaround https://github.com/google/oss-fuzz/issues/6427 by
        forcing use of the libc++.a in /usr/msan/lib when compiling the
        msan version
        
        Change-Id: I4e992cd7710b5929e74034db7a49c590349149fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122014
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [34d229cecadba9d216d7b1111146a1bace84983e]

        ofz: avoid std::basic_string from boost::filesystem
        
        workaround this problem for now by skipping the problematic path
        so fuzzers don't fail immediately
        
        ==706226==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0x161c3bf7 in ~basic_string /usr/local/bin/../include/c++/v1/string:2267:9
            #1 0x161c3bf7 in ~path workdir/UnpackedTarball/boost/boost/filesystem/path.hpp:83:9
            #2 0x161c3bf7 in ~impl workdir/UnpackedTarball/boost/boost/filesystem/exception.hpp:78:10
            #3 0x161c3bf7 in intrusive_ptr_release<boost::filesystem::filesystem_error::impl, boost::sp_adl_block::thread_safe_counter> workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ref_counter.hpp:173:9
            #4 0x161c3bf7 in boost::intrusive_ptr<boost::filesystem::filesystem_error::impl>::~intrusive_ptr() workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:98:23
            #5 0x161c4c14 in boost::filesystem::filesystem_error::~filesystem_error() workdir/UnpackedTarball/boost/libs/filesystem/src/exception.cpp:79:1
            #6 0x174134a1 in __cxa_end_catch (/out/fodsfuzzer+0x174134a1)
            #7 0xf22faa1 in ScOrcusFiltersImpl::importODS_Styles(ScDocument&, rtl::OUString&) const /src/libreoffice/sc/source/filter/orcus/orcusfiltersimpl.cxx:164:5
            #8 0x8c1c64 in ScDocShell::InitNew(com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) /src/libreoffice/sc/source/ui/docshell/docsh2.cxx:77:21
            #9 0x51e73cc in SfxObjectShell::DoInitNew(SfxMedium*) /src/libreoffice/sfx2/source/doc/objstor.cxx:470:10
            #10 0x6cf506 in TestImportFODS /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:1675:13
            #11 0x698137 in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/fodsfuzzer.cxx:30:11
            #12 0x5e8603 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) cxa_noexception.cpp
            #13 0x5d54a2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
            #14 0x5daecb in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) cxa_noexception.cpp
            #15 0x5ffd62 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
            #16 0x7f15c66ee0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)
            #17 0x5b293d in _start (/out/fodsfuzzer+0x5b293d)
        
        Change-Id: Ie8a9d376f902a391551237b833236c2203525555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [38afbf56f0783d7442e63b58ffae9cf111c04edf]

        ofz: workaround more
        
        Change-Id: Ic7988757a5adc76335911f89d5de1e5a64ce7056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122001
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Eike Rathke  <erack@redhat.com>  [db90a6cedbc261ad711ff13c4f69db65946486da]

        Resolves: tdf#144457 Use weld::set_text() instead of replace_selection()
        
        ... to replace entire field with modified text, instead of
        inserting the text at the cursor position without selection, thus
        effectively duplicating it (modulo modification).
        
        Fallout from
        
            commit 08101a1ab3b5d7c41488e93a2af518462286844f
            CommitDate: Tue Jul 30 14:04:17 2019 +0200
        
                weld OfaLanguagesTabPage
        
        that did
        
             if (bModified)
        -    {
        -        // Do not use SetText(...,GetSelection()) because internally the
        -        // reference's pointer of the selection is obtained resulting in the
        -        // entire text being selected at the end.
        -        Selection aSelection( rEd.GetSelection());
        -        rEd.SetText( aBuf.makeStringAndClear(), aSelection);
        -    }
        +        rEd.replace_selection(aBuf.makeStringAndClear());
        
        replacing the workaround needed for the old toolkit with something
        similar from the new toolkit but behaving differently..
        
        Change-Id: I9ff325eecd747bbecb36eb2a1150ae4472e475e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122000
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [cdf7352136f987f44e480777d302dfce9cbe3759]

        ofz: workaround memory sanitizer failure by skipping boost::locale
        
        which seems to have started since...
        
        https://github.com/google/oss-fuzz/commit/a2be91d3f10c54f20ae651375683ae4605543a63
        
        e.g.
        
        ==3509==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0xa990506 in ~basic_string /usr/local/bin/../include/c++/v1/string:2267:9
            #1 0xa990506 in ~pair /usr/local/bin/../include/c++/v1/__utility/pair.h:39:29
            #2 0xa990506 in std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, boost::shared_ptr<boost::locale::localization_backend> > >::destroy(std::__1::pair<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, boost::shared_ptr<boost::locale::localization_backend> >*) /usr/local/bin/../include/c++/v1/__memory/allocator.h:156:15
            #3 0xa9899a5 in destroy<std::__1::pair<std::__1::string, boost::shared_ptr<boost::locale::localization_backend> >, void> /usr/local/bin/../include/c++/v1/__memory/allocator_traits.h:309:13
            #4 0xa9899a5 in __destruct_at_end /usr/local/bin/../include/c++/v1/vector:450:9
            #5 0xa9899a5 in clear /usr/local/bin/../include/c++/v1/vector:374:29
            #6 0xa9899a5 in ~__vector_base /usr/local/bin/../include/c++/v1/vector:487:9
            #7 0xa9899a5 in ~vector /usr/local/bin/../include/c++/v1/vector:579:5
            #8 0xa9899a5 in ~impl workdir/UnpackedTarball/boost/libs/locale/src/shared/localization_backend.cpp:34:45
            #9 0xa9899a5 in ~hold_ptr workdir/UnpackedTarball/boost/boost/locale/hold_ptr.hpp:36:13
            #10 0xa9899a5 in boost::locale::localization_backend_manager::~localization_backend_manager() workdir/UnpackedTarball/boost/libs/locale/src/shared/localization_backend.cpp:168:9
            #11 0x579edc in init workdir/UnpackedTarball/boost/libs/locale/src/shared/localization_backend.cpp:263:17
            #12 0x579edc in __cxx_global_var_init workdir/UnpackedTarball/boost/libs/locale/src/shared/localization_backend.cpp:264:15
            #13 0x579edc in _GLOBAL__sub_I_localization_backend.cpp workdir/UnpackedTarball/boost/libs/locale/src/shared/localization_backend.cpp
            #14 0xbe861ac in __libc_csu_init (/tmp/not-out/psdfuzzer+0xbe861ac)
            #15 0x7f1bcadc003f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2703f)
            #16 0x57c40d in _start (/tmp/not-out/psdfuzzer+0x57c40d)
        
        Change-Id: I14010df7c009b4c44943b0fd56688ed05569c1b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121999
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [96ce5bdf72fbcd4ca2907fc4ad71a038a11e2e22]

        clang:optin.performance.Padding in sw
        
        Excessive padding in 'class SwVisibleCursor' (12 padding bytes, where 4
        is optimal).
        Excessive padding in 'class SwCallLink' (10 padding bytes, where 2 is
        optimal).
        
        Change-Id: I8d23cc5f45ff5e916fa04205f4d92c4603514b1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121996
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [a7a62232f93a6383700e5473fe0a84f50e3c37b5]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6dc1f110054eefefffd7b58cafa8240a69bb176e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121995
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Rico Tzschichholz  <ricotz@ubuntu.com>  [bc1b7491436146c3c4b2b69a46bd0cd37bbbecce]

        allow build with poppler <= 0.71
        
        Change-Id: I359c8259ae402f9f22be392c4ab4a23d31a17b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [20f064c1d4d2788edbd4ed7303cf1fcc4f817be4]

        clang:optin.performance.Padding in sc
        
        Excessive padding in 'struct ScPreviewLocationEntry' (10 padding bytes,
        where 2 is optimal).
        Excessive padding in 'struct oox::xls::FormulaBuffer::SharedFormulaDesc'
        (8 padding bytes, where 0 is optimal).
        Excessive padding in 'struct ScOrcusStyles::font' (11 padding bytes,
        where 3 is optimal).
        Excessive padding in 'struct ScOrcusFactory::CellStoreToken' (8 padding
        bytes, where 0 is optimal).
        Excessive padding in 'struct TokenPool::ExtCellRef' (10 padding bytes,
        where 2 is optimal).
        Excessive padding in 'struct TokenPool::ExtAreaRef' (10 padding bytes,
        where 2 is optimal).
        
        Change-Id: Ifce31c799b0f64d3c6971279345391bb74f210c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121994
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1bd6e802a1671c4b923124b33064b7803a5dbb6]

        clang:optin.performance.Padding
        
        Excessive padding in 'struct chart::TickInfo' (11 padding bytes, where 3
        is optimal).
        Excessive padding in 'class EscherBlibEntry' (10 padding bytes, where 2
        is optimal).
        Excessive padding in 'struct oox::drawingml::ConditionAttr' (8 padding
        bytes, where 0 is optimal).
        Excessive padding in 'struct oox::drawingml::Constraint' (12 padding
        bytes, where 4 is optimal).
        Excessive padding in 'struct (anonymous namespace)::Number' (10 padding
        bytes, where 2 is optimal).
        
        Change-Id: If7573afa8a794497c9a2bf1c7c15e8f11ff11407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-12  Caolán McNamara  <caolanm@redhat.com>  [0652bc404c1a8dedda085a4753b412c8c0e9ea6c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id142604aca139f0e0a249ba32b6462a2b8db72d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121963
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [004dc53f70a3a868815556ae58b044fd0304e1c8]

        Simplify ORichTextModel's XUnoTunnel implementation
        
        Change-Id: I0d0e724c4da705f0f56dec41448a8312c4ffd37d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121975
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [6e4d8f3af4eb43bab419cae1062998f044b3f4c9]

        Simplify OAccessibleImplementationAccess' XUnoTunnel implementation
        
        Change-Id: Iad82fe1e0e524d2c33ab2165bd08353c4967c57f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121976
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [4a7984960bf7d0af8342b360510c7e4e3d7399cf]

        Simplify OFileDriver::getDataDefinitionByConnection
        
        Change-Id: Ia808f5e7867d474e36e60d163d1a556a59e2f89d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121974
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-12  Julien Nabet  <serval2412@yahoo.fr>  [ef030cd1b1eb6dd41ade808f360305cb53d48106]

        Typo STATE_SUCCESSFULL->STATE_SUCCESSFUL
        
        Change-Id: I9a9e826de17f5d42ece9e97171c441117181e769
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121971
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-12  Julien Nabet  <serval2412@yahoo.fr>  [eb848249f51323089e78a26c1a05b264eaf98c0f]

        Typo *Successfull->*Successful
        
        Change-Id: I837241da936ac013312228f774d08bb8dafa45e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121967
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8b765e6c45792bff5717cd0e0d9d42311c33461]

        tdf#144085 XUsedAreaCursor broken: the methods don't accept formatted cells as used
        
        This reverts 
            commit 61386aa03cd166473a58dbb4be0dd5e0ce82195c.
            tdf#79049 speed up OOXML workbook load (3)
        
        which caused this problem
        
        Change-Id: I19a9cf75e8b2d3b5f87e1bd324c42a1dbae8ee63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [ccc6c846eb7f6d334d0ab2e6b50c188c434caa19]

        tdf#117842: use XUnoTunnel to get wrapped connection reliably
        
        XDataDefinitionSupplier::getDataDefinitionByConnection may take
        not only direct reference to expected connection type, but also
        connectivity::OConnectionWeakWrapper wrapping it.
        
        Change-Id: I88925f9403b51f0cf13f02b5f00d3765a242230e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121890
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-12  Julien Nabet  <serval2412@yahoo.fr>  [380550fb478b20deca980e5eefd7a8ce7703263d]

        Typo: bIsSuccessfull->bIsSuccessful
        
        Change-Id: Ib811f39fea5c0e78405f805f6c278b4b529b17d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121964
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-12  Julien Nabet  <serval2412@yahoo.fr>  [f5ba9f5b7bbf74df14e5ed51af43392d6091aba1]

        Typo: SAVE_SUCCESSFULL->SAVE_SUCCESSFUL
        
        Change-Id: I4b50e1f5ca55e756f1fd0028287eeb0c9b96439a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121962
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-12  Mike Kaganski  <mike.kaganski@collabora.com>  [b733ccad171e6def8fbdb93f31875dfdea47bdc6]

        Make this instance of cppu::OImplementationId function-local
        
        Change-Id: I1feaaec9906fd06ae86226c35820072d8b19cf17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121891
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [77fca82aab16619a693d53e970ac717f54105e95]

        clang:optin.performance.Padding in svx,editeng
        
        Excessive padding in 'struct svx::SpellPortion' (18 padding bytes, where
        2 is optimal).
        Excessive padding in 'class SvxNumRule' (11 padding bytes, where 3 is
        optimal).
        Excessive padding in 'struct SpellInfo' (10 padding bytes, where 2 is
        optimal).
        Excessive padding in 'struct ImpEditEngine::LineAreaInfo' (14 padding
        bytes, where 6 is optimal).
        Excessive padding in 'class ImpChainLinkProperties' (5 padding bytes,
        where 1 is optimal).
        Excessive padding in 'class TextChainFlow' (20 padding bytes, where 4 is
        optimal).
        Excessive padding in 'class SdrObjList' (13 padding bytes, where 5 is
        optimal).
        Excessive padding in 'class SdrLayer' (12 padding bytes, where 4 is
        optimal).
        
        Change-Id: I17b1c40bfe553c7635dc6177845dc92956cd0fae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d114a341bc9e891b2e10ff60ddadb0b5f58e6381]

        clang:optin.performance.Padding in sfx2
        
        Excessive padding in 'class SfxControllerItem' (10 padding bytes, where
        2 is optimal).
        Excessive padding in 'struct SfxChildWinInfo' (11 padding bytes, where 3
        is optimal).
        Excessive padding in 'struct SfxChildWinFactory' (12 padding bytes,
        where 4 is optimal).
        Excessive padding in 'class SfxChildWindow' (10 padding bytes, where 2
        is optimal).
        
        Change-Id: I435cfcf8a199bcab4612d671e1900ba659b8e383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [580b314a797917def3ce0f52abc02700a2768120]

        clang:optin.performance.Padding in xmloff
        
        Excessive padding in 'struct (anonymous namespace)::ConnectionHint' (11
        padding bytes, where 3 is optimal).
        Excessive padding in 'struct (anonymous namespace)::XMLEffectHint' (12
        padding bytes, where 4 is optimal).
        Excessive padding in 'struct xmloff::token::(anonymous
        namespace)::XMLTokenEntry' (10 padding bytes, where 2 is optimal).
        
        Change-Id: I176378d7cd6aa441856fce1b20c3af78bd5804c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121940
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8910519f1bc5aa284a79b7d24581d087adf0c29]

        clang:optin.performance.Padding
        
        Excessive padding in 'struct ValueSetItem' (8 padding bytes, where 0 is
        optimal).
        Excessive padding in 'struct framework::CommandInfo' (12 padding bytes,
        where 4 is optimal). Optimal fields order: aIds, nId, nImageInfo,
        consider reordering the fields or adding explicit padding members
        [optin.performance.Padding]
        Excessive padding in 'class
        drawinglayer::attribute::ImpFillGradientAttribute' (10 padding bytes,
        where 2 is optimal).
        Excessive padding in 'class
        drawinglayer::attribute::ImpSdrLineAttribute' (8 padding bytes, where 0
        is optimal).
        
        Change-Id: I606f2bfc2c0c51b386182b900401dd15b5404451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-11  Caolán McNamara  <caolanm@redhat.com>  [1fcc0cb5ee5397addee2fcfbebcc2d124a82e8e5]

        cid#1491408 Uninitialized scalar field
        
        and
        
        cid#1491409 Uninitialized scalar field
        
        Change-Id: I90300f1b7ddb8e70f6b816e802a082b0518e7466
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-11  Caolán McNamara  <caolanm@redhat.com>  [6891347a3d0896918e4aec64c9d255fe6b58163a]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I55d99602316b0f7322244b70a44c4786144054e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121935
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-11  Caolán McNamara  <caolanm@redhat.com>  [650773993529aee030a0161d131a361e8e9ab227]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Idf446aaa9b29f61168e29f76382f6258d1b78276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121936
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [349e1a7ce141d11432dda730ab8d34ab123117c5]

        clang:optin.performance.Padding in vcl
        
        Excessive padding in 'class ImplAccelEntry' (13 padding bytes, where 5
        is optimal).
        Excessive padding in 'struct SalQueryCharPositionEvent' (14 padding
        bytes, where 6 is optimal).
        Excessive padding in 'struct SalFrameState' (8 padding bytes, where 0 is
        optimal).
        Excessive padding in 'struct BitmapBuffer' (10 padding bytes, where 2 is
        optimal).
        Excessive padding in 'class GraphicAttr' (10 padding bytes, where 2 is
        optimal).
        Excessive padding in 'struct ImplPostEventData' (12 padding bytes, where
        4 is optimal).
        Excessive padding in 'class TETextPortion' (10 padding bytes, where 2 is
        optimal).
        Excessive padding in 'struct MapMode::ImplMapMode' (11 padding bytes,
        where 3 is optimal).
        
        Change-Id: I41801e0fd676981cc9f386d814fe2f0ea670a673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121925
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-11  Julien Nabet  <serval2412@yahoo.fr>  [952734d4214e647110b556e962b11d192c76ee0a]

        cid#1454626: Uninitialized scalar field (oox/chartexport)
        
        Change-Id: If3c623f04cd912ea419bb720178553a43cb713e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121933
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-11  Luboš Luňák  <l.lunak@collabora.com>  [dacdcfe71e18be6493328c37b20da560f2867f7a]

        add -DSYSTEM_NSS to flags ignored for system PCH
        
        Change-Id: I4afdf324956b0280ceeaf2d18174dedbb091b5b0

2021-09-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [b573ce5683ee648ed391ea3223208e584cf2f868]

        Drop unused multiple selection from UI files
        
        The code must call set_selection_mode(SelectionMode::Multiple)
        instead.
        
        Change-Id: I2d51dd3d3182ccec25f2ec1093a3866880354371
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121915
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-11  Jan-Marek Glogowski  <glogow@fbihome.de>  [c58a1058d4868f0f704547c11da1c9d30bceba5c]

        Allow multiple selection in AutoComplete word list
        
        Before commit 9c5d20105f0b123fca724cb4845f0e7227c217d8 ("weld
        OfaAutoCompleteTabPage"), this used to be a MultiListBox.
        
        Copying in that dialog also just copies selected entries, so
        there is no usable GUI way left for a user to copy the whole
        word list.
        
        Change-Id: Ib2909642be9dd0d6ebac1648b603c7a8bde7ca5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121914
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-11  Luboš Luňák  <l.lunak@collabora.com>  [8793f3c406d5acba910fb5b819e8263cd38a3af0]

        don't include Vulkan headers for Skia PCH
        
        It's not built on Mac.
        
        Change-Id: Ica6aed9da51bb5cfd6dd1255e1231d5f0e53ba2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121926
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [84e1c79dd7394168459a3bbdea8bd94d765708e0]

        access maPalette via const BitmapBuffer* when in const method
        
        Change-Id: I7bd1fb312ef7122e25c4d19679773d0c1ccab7be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121916
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [d33f5abc4423aad4087eb77c920fcbd74e34533f]

        tdf#125286: Inform Firebird that we use UTF8 in paths
        
        Use isc_dpb_utf8_filename for that, which is introduced in Firebird 2.5.
        It is documented in Firebird's doc/README.connection_string_charset.txt.
        
        Without this, on Windows, where UTF-8 is not a common "ANSI code page",
        one would not be able to connect to a DB file that has non-ASCII chars
        in path, because its UTF-8 representation would differ from 8-bit system
        encoding used in the API used by Firebird.
        
        This still does not enable full Unicode support, because of Firebird's
        [CORE2172]/[CORE3172]. It may only improve experience when using paths
        with characters representable in system encoding.
        
        Change-Id: Ia31407b181266a2bf1b90bc8cfc71dd3f78b7cd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121886
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f46bcac09c7f1f8ef6f22ed9f366d1fd596f9d7]

        clang:optin.performance.Padding in cppu
        
        Excessive padding in 'struct cppu::IdContainer' (11 padding bytes, where
        3 is optimal).
        Excessive padding in 'struct (anonymous namespace)::ObjectEntry' (11
        padding bytes, where 3 is optimal).
        
        Change-Id: I39216b9927abeb8ec61ab590dc25bc203a112028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121921
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9490588c2460a77c16aacd52b7f449db60a6b34b]

        clang:optin.performance.Padding in tools
        
        Excessive padding in 'class tools::JsonWriter' (15 padding bytes, where
        7 is optimal).
        
        Change-Id: I7e37eec095d935a344b2e5fea7bb108ee878472a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e8c940b73840868f26a537e159047e99d7ddae2c]

        clang:optin.performance.Padding in binaryurp
        
        Excessive padding in 'struct binaryurp::OutgoingRequest' (11 padding
        bytes, where 3 is optimal).
        
        Excessive padding in 'struct binaryurp::Writer::Item' (28 padding bytes,
        where 4 is optimal).
        
        Excessive padding in 'class binaryurp::IncomingRequest' (19 padding
        bytes, where 3 is optimal).
        
        Change-Id: I43ef9c513ad2bbb1151edbf5db578d69d35ccfbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121919
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [51269c4d28c04ebd2c0047772b7373e0bebec219]

        tdf#115547: Fix DB path handling
        
        1. The code used wrong procedure to convert file URLs to local paths.
        It assumed that it's enough to just strip the leading 'file://', which
        is only sometimes true on Unix-like systems; on Windows, this converts
        a valid 'file:///C:/path/file.ext' to '/C:/path/file.ext', where the
        leading slash is then treated as a network path, resulting in errors.
        
        2. It is incorrect to assume the same length for UTF-16 and UTF-8
        encoded URLs coming from untrusted source (like user file). It may
        contain non-ASCII characters (be an IRL), and then the assumption
        would fail.
        
        Change-Id: Ie2ea6c8cb9a690975db956fa025bf926a8010984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121885
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2021-09-10  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c42eb3d3f6c8be0bb8d3d4c6955d13279c0dbcc1]

        Fix typos
        
        Change-Id: Icb9acdf67be84e3bedab53188246890b6aa82a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120286
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [7d4142269e2deb756f03774a9d6d2861fe9eba04]

        crashtesting: threaded scaling crash on re-export of ooo24840-1.sxw to odt
        
         #13 0x00007f1cb843752a in o3tl::cow_wrapper<ImplBitmapPalette, o3tl::UnsafeRefCountingPolicy>::operator->() (this=0x5596086d5968) at include/o3tl/cow_wrapper.hxx:329
                 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)"
         #14 0x00007f1cb843752a in BitmapPalette::operator[](unsigned short) (this=0x5596086d5968, nIndex=nIndex@entry=0) at vcl/source/bitmap/bitmappalette.cxx:139
                 __PRETTY_FUNCTION__ = "BitmapColor& BitmapPalette::operator[](sal_uInt16)"
         #15 0x00007f1cb849f5f5 in BitmapInfoAccess::GetPaletteColor(unsigned short) const (nColor=0, this=0x5596085989f0) at include/vcl/BitmapInfoAccess.hxx:114
                 __PRETTY_FUNCTION__ = "const BitmapColor& BitmapInfoAccess::GetPaletteColor(sal_uInt16) const"
        
        the mpBuffer member of BitmapInfoAccess is
        
        BitmapBuffer* mpBuffer;
        
        not
        
        const BitmapBuffer* mpBuffer;
        
        so mpBuffer->maPalette.foo() calls non-const variants of foo(),
        (BitmapPalette::operator[](unsigned short) in this case), which
        is presumably non the expected outcome, as the copy-on-write mpImpl of
        BitmapPalette unsafely creates a new copy its internals on the first
        dereference of mpImpl in a non-const method.
        
        Change-Id: I1ebb3c67386a9028e5b8bab4b2d1cc5862700aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121910
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [cf3002ca480cbd2365317da4e9e729265b7c05ae]

        BitmapInfoAccess::GetColorMask can return a const reference
        
        Change-Id: I84c18b1d73910aa4c5a269e122f4ae86eb765e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [3a87142bd2e810deb19c9562ba5a388fbc754c29]

        gtk4: use gtk_event_controller_key_forward to see if toplevel would use key
        
        Change-Id: Ia0074daab6528f561169ecaf5544fa1c969a7103
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [0ce5ded132342d8420caab94e7376b0f33826f28]

        gtk4: we don't need to block the drawing area as a focus candidate
        
        because we put that as a child of the overlay so its not a focus
        candidate in the gtk4 version, and blocking the FixedContainer
        in gtk4 means none of its children can have focus since gtk4 and
        that the opposite of what we want to make focus traversal work
        between native gtk widgets
        
        Change-Id: Ide59e816189b5a89d13be9205d1fc9579ae33f92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121900
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [feae69bad70d637a92e6dbb7c18b756943858379]

        gtk4: complete child_grab_focus for gtk4
        
        Change-Id: I35a19b4c95c1a57426a8fc51d4a15814ae443e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121897
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [94c9c991d1fd0991961ee7bb2fd88991fe55f2f1]

        Resolves: tdf#143777 Exclude recipient is always greyed out
        
        Change-Id: I6ce94fad6ba518457665ae6d6b473cfe6f80849f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121905
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Jan-Marek Glogowski  <glogow@fbihome.de>  [61cb81d67ebf6b342a1cdb46bf6eb25a49eb5ff4]

        tdf#144412 Qt5 reset m_nModKeyCode on key input
        
        Switching the input direction on Ctrl + L/R-Shift is actually no
        bug but a feature. It is triggered on key release, so it can be
        distinguished from / doesn't interfere with shortcut handling.
        That's what should happen.
        
        So trying to implement that behaviour correctly and seeing the
        appearingly wrong modifier events for gtk3, I found gtk3 resets
        the frames persistent mnModKeyCode for key input events, which
        also seems to fix the problem for qt5.
        
        Some additional discussion is also in tdf#103158.
        
        Regression from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747
        ("tdf#143298 Qt5 send SalEvent::KeyModChange events").
        
        Change-Id: Iafcd1db7abcdf078001ca0602ae6e374f2a169ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121858
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [ccea340276609c87384ee7fff4837e48baaba9b5]

        Clarify that css::sdbc::XClob::getSubString takes 1-based pos
        
        ... and fix connectivity::firebird::Clob::getSubString.
        
        XClob::getSubString is modelled after JDBC counterpart, that also
        takes 1-based position argument. This is also described in multiple
        places in our code:
        
        - OPreparedStatement::setClob
          in connectivity/source/drivers/firebird/PreparedStatement.cxx
        - OSingleSelectQueryComposer::setConditionByColumn
          in dbaccess/source/core/api/SingleSelectQueryComposer.cxx
        - ORowSetValue::getString
          in connectivity/source/commontools/FValue.cxx
        
        However in some places 0-based value was used (fixed here).
        To clarify, the mention that the pos argument is 1-based is put
        to the corresponding IDL file.
        
        Also the code in connectivity::firebird::Clob::getSubString had
        multiple issues:
        
        - no checks of arguments;
        - possibility to throw "nPosition out of range" when just-read
          segment has enough data;
        - wrong start position in case when nPosition is not aligned to
          segment boundary.
        
        This change fixes these, and simplifies the implementation.
        
        Change-Id: I119a62dd7f02c9569ce36395ed8cc1a98c931fcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121884
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [c9517311f4c209f549668867c9b07ffa18246dee]

        vcl: move outdevstate.cxx to stack.cxx
        
        Change-Id: I674be4eb758178468dbba70cb45d68d009952ebc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121024
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [98492e9d8169c080d224e6ee60feb3277c5b1a17]

        clang:optin.performance.Padding in sal
        
        warning: Excessive padding in 'struct ImplTextEncodingData' (8 padding
        bytes, where 0 is optimal).
        
        warning: Excessive padding in 'struct ImplByteConvertData' (10 padding
        bytes, where 2 is optimal).
        
        warning: Excessive padding in 'struct ImplDBCSConvertData' (10 padding
        bytes, where 2 is optimal).
        
        warning: Excessive padding in 'struct DirectoryItem_Impl' (11 padding
        bytes, where 3 is optimal).
        
        Change-Id: Ia19f192099c305734256103c7cdc0f64e398b6af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121902
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [57a1d8d2c3ce8741c0bfbaa66160f6091a1c7f68]

        crash in tdf132431-1.ods --export-to xls
        
        probably related to
            commit 817ef891cf2bef8fdc82852f73acb422afb89bd2
            tdf#142579 Consider color scale background colors in color filter
        
        Change-Id: I30bc477319ffc5474d9a27c4955603a183cccf12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e6a8d312d3d7e5d81c56d5ccc0508116dd283f1f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6f20e65e37295a617c4bf0f534c8a0f746d7b19
          - tdf#128018 - Adapted column/row labels to reflect the change of the descriptive statistics result
            
            Change-Id: Idc97739525180ba3acc8d1e636fe9209e4f78b67
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121881
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [aa69f2a176329795fad957ac639329307c146e58]

        tdf#123055 - Start to read unicode text in order to avoid the BOM
        
        Change-Id: Ica5a2e11b4be1764cc94aafe5366197065cf6363
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121391
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-09-10  Luboš Luňák  <l.lunak@collabora.com>  [ef6def16e8d83bd425f3613c19989a409db7eb66]

        fix Skia/Raster screen flushing on Mac
        
        There's no window context in that case, so check the surface, as
        other places do. A mistake from 234ed4bcd5c4b5b41467890b82c6ef.
        
        Change-Id: I7f9d97340ed30444cb151c1141f8cc3045bd6dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121892
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [1a5817c2fb2122e895e6ba4fd19f558fc01123d9]

        gtk4: cannot focus to toolbutton if can-focus is false
        
        which seems reasonable
        
        Change-Id: I0cc5fecaace99f612d637c39065982ad12b23b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [30f1ce53b09da60d0d43b83d676c3a01b198f133]

        drop stray fprintf
        
        Change-Id: Ide4df588f8642b3eaad6dab4c819ba1914f3e2ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121896
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Stephan Bergmann  <sbergman@redhat.com>  [cc60672058f8ea72f29e5ebc5be3439fd41a5de9]

        This example doesn't have any idl files
        
        Change-Id: Ia70268084603db3329d276533a9351e6c1eebbca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121894
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [9eaf09e363c2c1377f74aa0db4854be2f825dd23]

        uitest: sw: Close the modeless dialogs after using them
        
        Otherwise, they will remain open in the next test
        
        Change-Id: I0019a3d98b7a66d6c4ba15408047facc7093cb5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121893
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [f26af764dee862e5c9a689d242ee72d1dac8bc1f]

        tdf#142214: reintroduce unittest and adapt it to the expected behaviour
        
        The test was added in ca2ec443893731093970914feb750b31ea13e47f
        < tdf#142214: autocomplete: do not search across empty blocks >
        and later reverted in 85a46d2beefbd3d32fd221e8f9d247ff84adca26
        < Revert "tdf#142214: autocomplete: do not search across empty blocks" >
        
        Change-Id: I5ca19ea9513740bfb6a197fe0a27860fa3cb6770
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121871
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [53ebbad48c8c2a71044917a5cbac9657126e5adc]

        warning: Excessive padding in 'struct OutDevState'
        
        experiment with optin.performance.Padding analyzer and tuning
        AllowedPad to 2
        
        with clang as compiler;
        export ENVCFLAGSCXX="-Xclang -analyze -Xclang -analyzer-checker=optin.performance -Xclang -analyzer-config -Xclang optin.performance.Padding:AllowedPad=2"
        and get a report of:
        
        OutDevState (13 padding bytes, where 5 is optimal)
        UIControlOptions (9 padding bytes, where 1 is optimal)
        
        Change-Id: I174f6f62d6e32df057d5e0f21d4274166f6ed8c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121812
        Tested-by: Jenkins
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e32d864dbe086d630a8b17c2d376e320aee0253a]

        tdf#144353 - Handling of missing optional parameters
        
        Don't assign a missing optional variable to a property and don't allow
        the computation/comparision including missing optional attributes.
        
        In the previous cases a ERRCODE_BASIC_NOT_OPTIONAL is raised.
        
        Change-Id: Iab391286fcace16c271ae511304075e2a0c5c651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121794
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [66e9b77ed296bb6b0cdae22685a11525a06dcf08]

        gtk4: default GtkViewport to can-focus
        
        Change-Id: If4c730cef1782c20f6f8519e77ff336c0e9e692c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121870
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-10  Michael Stahl  <michael.stahl@allotropia.de>  [a0d28d03ff40a77a2c88704a7b2bedb68e68563f]

        xmloff: ODF export: avoid mysterious crash while sorting shapes
        
        Apparently the draw page contains a null XShape.  That sounds like a bug
        but OTOH this sorting feature from commit
        9bc6160e0acbc78be998129ea55ed7e4529959faa isn't that important so let's
        sweep the problem under the rug.
        
        0 	swlo.dll 	sw::GetZOrderLayer::operator()(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const &) 	C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\zorder.hxx:37
        1 	mergedlo.dll 	xmloff::FixZOrder(com::sun::star::uno::Reference<com::sun::star::drawing::XShapes> const &,std::function<unsigned int > const &) 	C:\cygwin64\home\buildslave\source\libo-core\xmloff\source\draw\shapeexport.cxx:1003
        2 	swlo.dll 	SwXMLWriter::Write_(com::sun::star::uno::Reference<com::sun::star::task::XStatusIndicator> const &,rtl::OUString const &) 	C:\cygwin64\home\buildslave\source\libo-core\sw\source\filter\xml\wrtxml.cxx:190
        
        https://crashreport.libreoffice.org/stats/crash_details/045adea4-c577-4164-9e69-bde5f892bd17
        
        Change-Id: I1e67dc1c354cb14717cf9667314d6752e1b4c295
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121860
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [ef3329a520b11782c441ee6c2805bed622047407]

        CppunitTest_sw_rtfexport5: simplify asserts
        
        Directly get the properties as Color
        Follow-up of 7b3a681a867eeb2d68abd4ce33b07cabfff224ef
        < tdf#141908: replace usage of sal_Int32 with colors >
        
        Change-Id: I23da21b88dad7758856c719ebebaef9ed6fe7ca9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121868
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-10  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [14d299f8f1e19b39dfa81e143762c6b277c1ae9a]

        tdf#126426: support for hyperlinks in TextParagraphContext
        
        Usually hyperlinks are processed by TextBodyContext, but
        for grouped shape we accidentaly gone into TextParagraphContext
        It has almost all possibilities to process txbxContent,
        but not hyperlinks.
        
        Additionally some hyperlink char attributes (color and underline)
        can expand to follow up ordinal text. Additional small hack applied
        to avoid this.
        
        Unfortunately this is not a final solution: such document fails
        roundtrip and hyperlinks are lost after saving to DOCX.
        
        Change-Id: Ie954f53696bd872cb1f59cb586fb55f6cd7c73bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121172
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-09-10  Caolán McNamara  <caolanm@redhat.com>  [3c02fe5ca8e12dc52531367a1ac1c0802518d133]

        --without-system-cuckoo to override --with-system-headers didn't work
        
        Change-Id: I7a516fb0b7449dd33f95724f311b63387cc42f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121869
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2021-09-10  Luboš Luňák  <l.lunak@collabora.com>  [b4c1bb2f91e9ae47820c289e2c08f640a958cf05]

        cache FormulaError::NoRef error string (tdf#144249)
        
        Those COUNTIF() may call it a huge number of times, and the translation
        of the string each time then actually is a noticeable impact. And
        ScGlobal already does one-time intialization of objects based
        on the locale, so one-time initializing a string there should be fine
        too.
        
        Change-Id: I0daeb50ccb43f780d99cf3838cfd1bf790c5f6cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121856
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-10  Luboš Luňák  <l.lunak@collabora.com>  [d0316985db22efd6708dffa173eaabb430f6b9a8]

        do not intern a temporary cell error string
        
        Interning is way more work than a simple text comparison done once.
        
        Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-10  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [e85aaaecb5479660aa0cf600564ee3caa470aa3d]

        tdf#144425 Set sane lower bounds (1) for MM e-mail output ranges
        
        Lower bounds were forgotten to be set in weld commit
        f1ca64800074530d95e507f93c764a687310b9eb
        for the new GtkAdjustments of the GtkSpinButtons
        
        This caused no visible differences until commit
        d9fa826769cd570814f3556d53493a78d2869873
        when new default values (0) were added for VCL FormattedFields
        
        This made it possible to email MM results on non-GTK vclpugs starting
        from 0th mail if custom range is chosen, which causes an instant hang
        in the sending process since there is no -1st generated result.
        The default Send all option has still worked after this.
        
        Then commit ec44f87d5b99a3299322d0b79abc4c6808877865
        started to use the default GtkSpinButton values for default
        range of result generation, breaking the Send all option as well.
        
        Change-Id: I2a9f2b0954045700f947f342e5928ef75ce23aed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121865
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: László Németh <nemeth@numbertext.org>

2021-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [ecb7289fc3091fbbb8a65f43fc649e57a9870ac9]

        vcl: move OutputDevice::SetDigitLanguage() to text.cxx
        
        Ultimately I hope to reduce outdevstate.cxx to only have push(), pop()
        and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
        the plan is to separate metafile processing from rendering.
        
        Add unit test for SetDigitLanguage() and GetDigitLanguage().
        
        Change-Id: I138d08c7d79c66d296b4c96eff644a40a379c6be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121023
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [4d1d485544ea947b71534fd96ba520cd6e1c721b]

        vcl: move SetLayoutMode() to text.cxx
        
        Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() 
        and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
        the plan is to separate metafile processing from rendering.
        
        Also add a unit test for SetLayoutMode() and GetLayoutMode()
        
        Change-Id: I92cada7bf3d57ca8b84e04308c74428a1a19e775
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [9db1e85a8da3952cefef552853753342d7147b98]

        vcl: move OutputDevice drawmode functions to outdev.cxx
        
        Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() 
        and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
        the plan is to separate metafile processing from rendering.
        
        Add unit test for GetDrawMode() and SetDrawMode().
        
        Change-Id: I63948e7e4c332c786487c18c52faa60893f672a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121021
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [af78873e2000e604c9de78280cbcfbfcf4c7e99b]

        A copy-paste message text error
        
        Change-Id: I3d6f7a968fc5fca112087212ab7730f654534dfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121876
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-10  Miklos Vajna  <vmiklos@collabora.com>  [1c75df810439c71e975b166a66087c3d5a9ecdf3]

        sw layout xml dump: show SwParaPortion
        
        Towards showing details of multi-portions, which are invisible to
        XmlPortionDumper, which uses SwPortionHandler, which was introduced for
        SwAccessiblePortionData, and is currently misused for debugging.
        
        Change-Id: Ib62df8c9338855b6f03b24ca2d83b4d0e4408761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121861
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [2752c4aaa2f9509a7c54e1814d9dee3522070fb3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3cc7fd773a5502b520f5240749420a9c63649aa8
          - tdf#144398 Fix Slide master info in help page
            
            This patch also adds information about the option "Delete unused backgrounds" that is also available in the referenced dialog.
            
            Change-Id: I25ffea0acd456174181176375e1ab5075e2a17f7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121771
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [627e8ac6313330eae892195a62d07db5b7d85a1b]

        Use std::vector instead of css::uno::Sequence
        
        This allows to avoid multiple reallocations during successive reads
        
        Change-Id: I74102d21c5dc4d1e92e27ede3490e9ed07bd568e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121873
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-10  Mike Kaganski  <mike.kaganski@collabora.com>  [541ddf4580cac8c3f9590be26a487f5fc8e2553c]

        tdf#120129: don't forget to update buffer size to actual length
        
        Otherwise extra bytes get written to the resulting string from the
        too long buffer.
        
        Change-Id: Iccde16b8002f214df6f86f484f288ec464c6b674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121872
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-09  Stephan Bergmann  <sbergman@redhat.com>  [96d1240adf946c443fb2c369a1c84e31e259c7a8]

        Fix apparent typos
        
        ...introduced with aaebbb0e597bfeb8e1c545130a0d17a55b164228
        "INTEGRATION: CWS jsc21" (but which never caused an issue as cppumaker generated
        output for all of $(COMP_RDB) anyway when the undefined $(TYPESLIST) didn't
        contribute anything to its command line)
        
        Change-Id: Ic6792ad9edc159c02d307ca72500605bc3c38077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121851
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [9819abee8b16dee4ffc47bd4a79270687a5c424e]

        a system cuckoo isn't available
        
        build without it and see what warnings there might be
        
        Change-Id: I54b4d0c784631d26f634c63157563203bc37f1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121864
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [e5ced8a0e875226152ceae2ad84bac0292e20c4f]

        crashtesting: assert making thumbnail on reexport of tdf127770-1.ods to ods
        
        convert to B2DPolygon earlier and do scaling on B2DPolygon's doubles
        
         #18 0x00007f534e1093bc in ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long) (n=<optimized out>, nDPI=<optimized out>, nMapNum=<optimized out>, nMapDenom=<optimized out>) at vcl/source/outdev/map.cxx:268
                 __PRETTY_FUNCTION__ = "tools::Long ImplLogicToPixel(tools::Long, tools::Long, tools::Long, tools::Long)"
                 n64 = <optimized out>
         #19 0x00007f534e10a4ff in OutputDevice::ImplLogicToDevicePixel(tools::Polygon const&) const (this=this@entry=0x55c3ebbb9f60, rLogicPoly=...) at include/tools/gen.hxx:80
                 rPt = Point = {x = -794275722273860480, y = 0}
                 i = 0
                 nPoints = 2
                 aPoly = {mpImplPolygon = {m_pimpl = 0x55c3e9fdc250}}
                 pPointAry = 0x55c3e9c9b970
         #20 0x00007f534e0ff4d4 in OutputDevice::drawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:251
                 nPoints = 2
                 aPoly = {mpImplPolygon = {m_pimpl = 0x7f534e0bfde8 <__gnu_debug::_Safe_sequence<std::__debug::vector<OutDevState, std::allocator<OutDevState> > >::_M_invalidate_if<__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > > >(__gnu_debug::_Equal_to<__gnu_cxx::__normal_iterator<OutDevState const*, std::__cxx1998::vector<OutDevState, std::allocator<OutDevState> > > >)+208>}}
                 __PRETTY_FUNCTION__ = "void OutputDevice::drawPolyLine(const tools::Polygon&, const LineInfo&)"
                 aInfo = {mpImplLineInfo = {m_pimpl = 0x55c3eaa4ca68}}
                 bDashUsed = <optimized out>
                 bLineWidthUsed = <optimized out>
         #21 0x00007f534e0ff3d8 in OutputDevice::DrawPolyLine(tools::Polygon const&, LineInfo const&) (this=this@entry=0x55c3ebbb9f60, rPoly=..., rLineInfo=...) at vcl/source/outdev/polyline.cxx:135
                 __PRETTY_FUNCTION__ = "void OutputDevice::DrawPolyLine(const tools::Polygon&, const LineInfo&)"
         #22 0x00007f534e1f1d56 in MetaPolyLineAction::Execute(OutputDevice*) (this=0x55c3e998e300, pOut=0x55c3ebbb9f60) at vcl/source/gdi/metaact.cxx:481
         #23 0x00007f534e1be27a in GDIMetaFile::Play(OutputDevice&, unsigned long) (this=this@entry=0x55c3e9e4c700, rOut=..., nPos=86, nPos@entry=4294967295) at vcl/source/gdi/gdimtf.cxx:371
                 nCurPos = 48
                 i = 48
                 pAction = 0x55c3e998e300
                 nObjCount = <optimized out>
                 nSyncCount = 4294967295
         #24 0x00007f534e1be4e1 in GDIMetaFile::Play(OutputDevice&, Point const&, Size const&) (this=this@entry=0x55c3e9e4c700, rOut=..., rPos=Point = {...}, rSize=Size = {...}) at vcl/source/gdi/gdimtf.cxx:512
                 aDrawMap = {mpImplMapMode = {m_pimpl = 0x55c3e9f338d0}}
                 aDestSize = Size = {width = 756, height = 1020}
                 pMtf = 0x0
                 aScaleX = {mnNumerator = 756, mnDenominator = 341, mbValid = true}
                 aScaleY = {mnNumerator = 1020, mnDenominator = 461, mbValid = true}
                 rOldOffset = Size = {width = 0, height = 0}
                 aEmptySize = Size = {width = 0, height = 0}
                 bIsRecord = false
         #25 0x00007f534e1be9c5 in GDIMetaFile::CreateThumbnail(BitmapEx&, BmpConversion, BmpScaleFlag) const (this=this@entry=0x55c3e9e4c700, rBitmapEx=..., eColorConversion=eColorConversion@entry=BmpConversion::N8BitColors, nScaleFlag=nScaleFlag@entry=BmpScaleFlag::Default) at include/rtl/ref.hxx:206
                 aAntialias = Size = {width = 756, height = 1020}
                 aBitmap = {maBitmap = <incomplete type>, maAlphaMask = <incomplete type>, maBitmapSize = Size = {width = 94299930324064, height = 139995769668141}}
                 aVDev = {<ScopedVclPtr<VirtualDevice>> = {<VclPtr<VirtualDevice>> = {m_rInnerRef = rtl::Reference to 0x55c3ebbb9f60}, <No data fields>}, <No data fields>}
                 aNullPt = Point = {x = 0, y = 0}
                 aDrawSize = Size = {width = 189, height = 255}
                 aSizePix = <optimized out>
                 nMaximumExtent = 256
                 aAntialiasSize = Size = {width = 760, height = 1024}
        
        Change-Id: I4284a7da0684845d7c0af136b25c5210d522c79b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [030bfda5ec47e28bf66aa2176ace3f626794d5b1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8eaf65fa4d1982ff60f612088adea6d636246612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  jucasaca  <jcsanz@libreoffice.org>  [34219c3cb737371afb4a29604e95f0e87966f02a]

        tdf#143905: Parse password from connection string
        
        Parse user and password, so its possible to connect to a
        firebird server more over embeded and file
        
        Change-Id: Idbfa526e2a29f6f8bed5165f57844350c8b6d127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121638
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dbd367e57669a82b7ea82f112d3d8c1a105d8d41]

        Fix typo
        
        Change-Id: I899c68cf53657eaab6a72ae36594606b31d9fb8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121859
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [905d7e3d9cff386a819faa6582cfb1700b529e34]

        tdf#144241 don't return a negative width for osx edit region
        
        instead expand the region to the min osx width
        
        Change-Id: I01dc336c97ba9573948e1ca8f3eeb3ac46008819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121857
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c50c2dd15da5e9f4a96b8bae1d337a52c71121f]

        flatten DocumentRedlineManager a little
        
        no need to allocate these things separately
        
        Change-Id: I832e77587e1272a6be5dfc8d460891564ed07517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121854
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca6e29e9fb8999fdecca5b50570be1665071a2c7]

        reserve space in vector to reduce reallocations
        
        Change-Id: I6263c0b742331138188f7b557c05b2a59188d4fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e76ea4bcc720826be457ac6ea26fba36193f006]

        fix std::move same object more than once
        
        after
            commit 8104d771b10a5c8b15eae4b67aa112ae2ef77b5b
            tdf#144052 reduce Primitive2D copying
        
        spotted by mikekanganski
        
        Change-Id: I97e4675a9042cfafa3f9f6c053ba2f50aeea2183
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [8104d771b10a5c8b15eae4b67aa112ae2ef77b5b]

        tdf#144052 reduce Primitive2D copying
        
        when creating charts, by using a
            Primitive2DContainer&&
        parameter in the GroupPrimitive2D constructor, which forces the call
        sites to pass a temporary, and at most call sites, we can std::move in
        an existing local variable.
        
        Change-Id: I531970918800c6832ab606b5a4ff5fd2d47ccf5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121844
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [ca512f301faf42b7d23675ca251b20e0ad67db1b]

        Resolves: tdf#144389 get_accessible_parent should only be called on vcl impls
        
        Change-Id: If5d8718fcd9bcccee37e162a99cc68ff4a77de8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [3c94c1c61f1e25de26dab9e63146994eb1139013]

        merge ThumbnailView and ThumbnailViewBase
        
        only ThumbnailView inherits directly from ThumbnailViewBase and it will
        simplify a11y if ThumbnailView instead of ThumbnailViewBase is available
        
        Change-Id: I715faa3f9b2cec68c1de07479b7d1dbbd9ddbcc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121846
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Miklos Vajna  <vmiklos@collabora.com>  [7a8bb65e1b8dc7fdd7f89c8c546e71e4208da574]

        ODT export: order <style:font-face> elements inside <office:font-face-decls>
        
        This builds on top of commit 92471550b8c43d8ff0cef8b414884d697edf9e63
        (ODF export: sort <style:font-face> elements based on the style:name
        attribute, 2021-03-11), the additional problem was that the style:name
        attribute already has number suffixes to have unique names for fonts
        where the style name would match.
        
        This means that even if we sort the container right before writing the
        elements, which font gets the number suffix depends on the insert order.
        
        Fix this by additionally sorting the font items before insertion, given
        that a single call-site does all the insertion, at least for Writer
        documents. This is required as SfxItemPool::GetItemSurrogates() exposes
        a container which is based on SfxPoolItemArray_Impl, which uses an
        o3tl::sorted_vector<> of pointers, so effectively unsorted, the order
        depends on the pointer address of the font items.
        
        Change-Id: I46569b40796243f7f95b92870504c2023b2ce943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121823
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-09  Noel Grandin  <noel@peralex.com>  [a9cd44f8deeccbb8afc7209fdf86fbc26ea7a464]

        tdf#144052 speedup inserting large charts
        
        we don't need to immediately re-order objects when setting the
        Z-order, just set the dirty flag and we can calculate the proper order
        layout.
        
        This takes the time for the chart to appear from multiple minutes
        to 20sec for me.
        
        Change-Id: If80569da09469423f19f9fe82b40dfbdac14f161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121806
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel@peralex.com>  [7b4b032daa2381e5c2f102d4e9619adf38968f94]

        reduce time in ResetEvent (tdf#144052)
        
        Change-Id: I3e9c906a026e7455fb775d110eca32f8533614e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121836
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [542fb709a4c26c0e5be0c09c028dc86bdd419c6f]

        loplugin:redundantfcast ignore necessary temporaries
        
        when passing data to a method that is of type
           Foo&&
        
        Change-Id: I0e6bcfb42d6ebcbc7cb19e510ab2010a2cc2bb7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [8ecfd2b84fddb37482539702208374d2af56a44d]

        don't need to explicitly call GetFocus()
        
        if GrabFocus() succeeds the GetFocus() should be called anyway
        
        Change-Id: I2a448659acd990bf570fe56907ac826138cc9938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121840
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [c36fff84afb7eaa05fa065e15009c9426a5af44e]

        Resolves: tdf#144376 focus into protected ScTextWnd shouldn't be possible
        
        the expectations are that this isn't possible and if it happens then
        under windows there is a QueryCharPosition which will trigger the
        deletion of the ScTextWnd EditView due to that expectation before it is
        then unconditionally dereferenced
        
        Change-Id: Ied5d8031ae7d74669a2958dbcdec87843a26d384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121839
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [89b8e97bf325a92f49756fe903b322653cd88266]

        workaround -Wshadow in libcuckoo
        
        that triggers with
            gcc (Ubuntu 10.3.0-1ubuntu1~20.10) 10.3.0
        
        Change-Id: I038e229890fcc3c8bb7986a747434e9e033b4f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121838
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [49297dc0b5fd4f8ef9f7b650342fe462f76d08d3]

        add assert to verify that lock() calls do not accidentally nest
        
        Change-Id: I6582de99867f98a9afaf219c3bdd53c1f5fca509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121772
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Caolán McNamara  <caolanm@redhat.com>  [b465a67e2e411f295fa8e91ee3289eda8ccba038]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iead995bc6c568c9e517c6402e875127343f30651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121837
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-09  Noel Grandin  <noel@peralex.com>  [3749d9af3745c0eaff7239e379578e4e2af89e9d]

        tdf#130795 use concurrent hashmap in SharedStringPool
        
        we are loading a spreadsheet in parallel here, but the parallel threads
        achievei very little actual concurrency because of heavy contention
        in the SharedStringPool mutex.
        
        So switch to a concurrent hash map. I looked at a couple of different
        ones (including the Folly one), and this was the one with the simplest
        resulting code.
        
        This takes my load time from 12.5s to 8s
        
        Change-Id: I04d6d8e11d613b510eb3bc981f3338819b7ac813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121717
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-09  Chris Sherlock  <chris.sherlock79@gmail.com>  [4bf266233daa7d9ed030a20fa4f487f9f5a82379]

        vcl: move OutputDevice antialiasing functions to outdev.cxx
        
        Ultimately I hope to reduce outdevstate.cxx to only have push(), pop() 
        and clearstack(), then rename outdevstate.cxx to stack.cxx. Eventually,
        the plan is to separate metafile processing from rendering.
        
        Also include unit test for SetAntialising() and GetAntialiasing().
        
        Change-Id: Ie9eefa2de17ce583ca4acd9d86df004981a0c9b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121020
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-09  Miklos Vajna  <vmiklos@collabora.com>  [1e8127dcff14e2c50c839f5d9c2969a7b21bee9e]

        sw: use more StaticWhichCast() in source/core/
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: I2214fb9a6942551088f44b1882897f7849518203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121827
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-09  Stephan Bergmann  <sbergman@redhat.com>  [7eaedc91e8284ba8555ff904eb39f0615d247eb3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab1e841eac31980f39ecfcbac897220a5d5b7c2a
          - Fix duplicate id
            
            ...apparently introduced as a (copy/paste?) typo in
            ab28d2cbdffe0e5c9a966fa5f7659a455a042663 "sf-exception.PythonPrint new method",
            causing build failures like (<https://ci.libreoffice.org/job/lo_ubsan/2129/>)
            
            > Error: Duplicated entry. ID = par_id201613654395537  LANG = en-US in File /home/tdf/lode/jenkins/workspace/lo_ubsan/helpcontent2/source/text/sbasic/shared/03/avail_release.xhp
            > /home/tdf/lode/jenkins/workspace/lo_ubsan/solenv/gbuild/HelpTarget.mk:67: recipe for target '/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/HelpTranslatePartTarget/de/helpcontent2/source/text/sbasic/shared/03/done' failed
            > make[1]: *** [/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/HelpTranslatePartTarget/de/helpcontent2/source/text/sbasic/shared/03/done] Error 255
            
            Change-Id: Ib8a773b04d8df1ed62b4d5a5780de2b9e70f88ae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121834
            Tested-by: Jenkins
            Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
            
2021-09-08  Caolán McNamara  <caolanm@redhat.com>  [5b6fcbf4a754a2699b3b865256848238f93113a2]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        sidestep the resize behaviour of SvMemoryStream by using an honest
        std::vector and make it use that buffer
        
        Change-Id: Ic5e405010ac076fc04e1ca8dc6dbb495162101ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121832
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [c07f4a7d04eb44020045859d305f4510ae9acfc4]

        no need to call expand() here
        
        we can just return the value directly
        
        Change-Id: Ia4a79ebe668dd426edbe95baee8d8cf91d4bc3f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [993ae97e38e72e9d5dabeb0f3abafdc55c73161e]

        avoid double-lookup
        
        this is hot when creating charts
        
        Change-Id: Ic096d9293a48d53fc2cadfda95b5b7a13ba16f68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [2cf4cf718165988e81b606be7fa0a4b02973a10a]

        avoid some ref-counting
        
        Change-Id: I04dfa4070b2e64c4ab7cb59d4a5c4668e98dc076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121831
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [e11386053d3c404fbeab8b66402d68f813f7dd58]

        convert some OSL_ENSURE -> assert
        
        where we are just provide checking for a following static_cast.
        
        I'd rather have an explicit assert failure than a random crash
        
        Change-Id: Iab6c6b056341018deaa74b78b075e564f72c58d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Julien Nabet  <serval2412@yahoo.fr>  [41a55bde344f924edd36dbbeead45c426ee07e4d]

        fix copy paste in assertion message (vcl/gtk3/gtkinst)
        
        Change-Id: I2603dcb809d2bf062f3b14f7c21583fde1da9f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121829
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-09-08  Michael Weghorn  <m.weghorn@posteo.de>  [97a88e30e2e084ab860635ff4e0a03442d8a12af]

        tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell
        
        Add a new class 'AccTableCell' that implements the
        IAccessibleTableCell interface from the IAccessible2 spec
        and add what's needed to expose it to accessibility tools
        via COM.
        
        Since there's no specific XInterface for table cells
        that an XAccessible's context could be queried for,
        make use of the fact that a table cell's
        parent is a table, i.e. its accessible context implements
        XAccessibleTable.
        
        AccTableCell keeps a reference to that table and remembers the
        cell's index in the parent to retrieve information
        on the cell from there.
        
        This addresses the
        
        > At least for LibreOffice Table Cells don't implement
        > IAccessibleTableCell, and therefore there's no way to get the row and
        > column span. LibreOffice itself also does not expose the merged state in
        > the accessible name of the cell.
        
        comment from [1] (which is the NVDA counterpart for LO's
        tdf#124832) and may also help for tdf#100086,
        though more work will be needed on LibreOffice and/or NVDA
        side for both issues.
        
        [1] https://github.com/nvaccess/nvda/issues/9310
        
        Change-Id: I0f53212d14ee17c760b9e6c91be2154a1b25d862
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121821
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-08  Michael Weghorn  <m.weghorn@posteo.de>  [839dbf9ecf9f8fbec7de983d1a2e16d7de6f868c]

        tdf#100086 tdf#124832 wina11y: Implement IAccessibleTable2
        
        Extend 'CAccTable' to implement the 'IAccessibleTable2'
        interface in addition to the (deprecated)
        'IAccessibleTable' interface from the IAccessible2 spec.
        
        'IAccessibleTable2::get_cellAt' and
        'IAccessibleTable2:get_nSelectedCells' are basically
        the same as 'IAccessibleTable::get_accessibleAt' and
        'IAccessibleTable::get_nSelectedChildren' under
        new names.
        
        'IAccessibleTable2::get_selectedRows' and
        'IAccessibleTable2::getSelectedColumns' are
        essentially the same as their 'IAccessibleTable'
        counterparts, except that they have the first
        param removed (which is ignored in the
        IAccessibleTable version anyway).
        
        'IAccessibleTable2::get_selectedCells' is similar
        to 'IAccessibleTable::get_selectedChildren', but
        returns an array of references to selected cells,
        while the latter just returns an array of their
        indices.
        
        Note: Just having the IAccessibleTable2 interface,
        but not the IAccessibleTableCell one implemented makes
        the experience when using the NVDA screen reader
        temporarily worse, e.g. it now only says "selected" instead of
        the name of the currently focused cell in Calc.
        Implementation of IAccessibleTableCell is added
        in an upcoming commit
        (Change-Id: I0f53212d14ee17c760b9e6c91be2154a1b25d862,
        "tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell")
        and makes NVDA announce the name of the cell again.
        
        Change-Id: I75346efc3b6e79d5ebf5e1954e9c516244efb887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121820
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [b298885ceaab0c892ffc449e09c2967a3a9e3ea6]

        Removed duplicated include
        
        Change-Id: Icc9747237c4ff23cd844f23531f0de37ca1a37d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121798
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-09-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4a07a8963a74ef1659aa3e467d9288d1e3c7b9d4]

        update credits
        
        Change-Id: Ie9a3df3c6dc8af63023e579638f13026451a346f

2021-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [708b1aa962dd667a9de6d6131cfc63937212536e]

        related: tdf#118938: simplify uitest
        
        use execute_dialog_through_command like every other test
        and remove the try/except complexity
        
        Change-Id: Ie9cb68e56174516002c15afe89e4314e4c16a755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121826
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [2c0e5d8b2e53921f09b2e5036cc25f8b0a177dd6]

        uitest: sc: factor out common code
        
        Change-Id: Iaba3b9633eac26516bbb4bb0b6baadb4c6772fa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121808
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-08  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9c2d703363798aad33a22b3b4e6ac8043dd53b95]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9088fa2a2fefecaa450cc2b9767a8d958b9e4350
          - SF_Base.CloseFormDocument() new 7.3 method
            
            Change-Id: Id58053f554c27819aa073ea8312ece8fb32710a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121762
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-09-08  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9e4bf8b36010c54a32059119ada0335857fdcd75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab28d2cbdffe0e5c9a966fa5f7659a455a042663
          - sf-exception.PythonPrint new method
            
            Change-Id: I11402201ef509816fc38665eae8d057e1761274a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121469
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-09-08  László Németh  <nemeth@numbertext.org>  [c0c0a24c7e77170622f260b194745810096bae79]

        related to tdf#132744: clean-up unit test document
        
        commit a7b12e23bf9ac8e394405a1de5835e18e40c27c2
        "tdf#132744: sw: Add unittest" added an ODT
        file with a – likely proprietary – photo in a
        *453 kB* PNG file. Replace the image with a
        *68 B* PNG in the test document.
        
        Change-Id: I684ed3494bf9e7c0489395309e39cd41e78384ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121785
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-08  Caolán McNamara  <caolanm@redhat.com>  [637068510682ec0cf63227d2f81bdcfc6598c7e6]

        ofz#27296 limit row span when fuzzing
        
        Change-Id: I3069875f64acaf394cfef7f6478abc974022d536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121819
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-08  Baran Aytas  <barannaytas@gmail.com>  [7b3a681a867eeb2d68abd4ce33b07cabfff224ef]

        tdf#141908: replace usage of sal_Int32 with colors
        
        Change-Id: I536e2c8d15db7c4973525ffc1e0abfb211228751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121703
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [939dff83ba8bc2dd124a73cc5460e52b8a642d9f]

        no need to do this dynamic_cast in a release build
        
        just make it an assert
        
        Change-Id: I6cd84c9988a3d5111d24b44aae46dc6d69ca06ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  László Németh  <nemeth@numbertext.org>  [99059a1ececa3621c2fe46fabdd79eed9d626c42]

        tdf#143359 sw: track deletion of empty table rows
        
        Empty table rows were deleted immediately during
        change tracking, or in the case of a deleted table
        also with non-empty rows, accepting table deletion
        kept empty rows.
        
        Note: as a workaround for tracking of the empty rows,
        i.e. rows without text content, add a redline with
        invisible text ZWJ in the first cell of the empty row.
        
        See also commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
        "tdf#143215 DOCX import: fix tracked empty row insertion/deletion",
        commit b50d386dfa70f7c1d4eb1a49091ec9dd782b767b
        "tdf#142701 track changes: fix layout regression of image deletion"
        and commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Note: switch off unnecessary redlining of tdf#132744 unit test
        to keep the sake of that test (i.e. cut of the selected table
        with empty rows).
        
        Change-Id: Ief59008e8714fb88afdfce867598e3dda21bfba5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121784
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [160b6db92cc94f2ec2447ae0e9c60c8c9dcf3bad]

        indexing: fix correct size and pos. for shapes + more tests
        
        Determining the position and size of the shapes (SdrObjects) was
        wrong as the assumption was the values are in Hmm but were in
        twips. Added some more tests that check rendering of SdrObjects.
        
        Change-Id: I6ef9287892d1774a1243118a5c97f58384bcfd68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121801
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [11622c2eb319bb096d4d587ea06a932ba5fceafb]

        tdf#114878: sc: Add UItest
        
        Change-Id: I4edac5f45f18e1aa85d1936a2577420ee274f43e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121804
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-08  Caolán McNamara  <caolanm@redhat.com>  [0ffb0ad7ddecae4a1271bccdc0db762649aa9269]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9117bc6b499c8f86663980c26b7247e58c9737d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121802
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [3afb514362a2ce2701628256fa96d4a5324433d6]

        simplify static_cast after dynamic_cast
        
        Change-Id: I53ae7f18519fdd878730d1d0316ebc408271c66d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121811
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Michael Stahl  <michael.stahl@allotropia.de>  [73c8bd42650dafc38c87b5e6dc1ef222d4f6175c]

        cui: fix spell check dialog pointlessly modifying text shape
        
        In Impress, closing the spell check dialog without doing any changes
        will replace the entire text of a shape, creating an
        sd::UndoObjectSetText and messing up the formatting.
        
        Apparently in commit bbb1428e3666acc7503d86704bbf1e1a4ac04795
        a check of the modified flag was removed, but it's not obvious why,
        so add it back, which appears to fix the problem.
        
        Change-Id: I8ce6c75f097baa82f11f7b1c813262845001ae7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121807
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [28ac9bd1d8ff19e1b60c64a205220167baf5085f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 4460c7babd574c5040a528d10fe51001c27680bc
          - update translations for 7.2.1 rc2
            
            and force-fix errors using pocheck
            
            Change-Id: I4b8c8e545d7aba21bf9e925bfb9018be6e4c04f8
            
2021-09-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cce5a278659b1dafacdf64da8dcfab02dba25d75]

        indexing: rename "parent" attibute and parse the attribute back
        
        Rename the attribute "parent" to "object_name" and "parent_index"
        and parse the "object_name" attribute for JSON and XML when used
        as input to SearchResultLocator.
        
        Change-Id: I46ad8d6aa14f15d1b759126af71284f7d73a7a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121797
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Tor Lillqvist  <tml@collabora.com>  [9a2d65274073c7b56f0e45f82d580e21b03968b6]

        Revert "Tentative fix for crash in the iOS app"
        
        The root cause for the problem was fixed elsewhere by
        0f65b4b6f33891a724bee5356aa5549c76fa0ce3 (and back-ports).
        
        This reverts commit 9e4c72ec7ea83aa0d023a90a6b02ddb17c6b2d74
        
        Change-Id: I0167846d2aaeacc66657b4203d0118b7847679ba

2021-09-08  Michael Stahl  <michael.stahl@allotropia.de>  [294a82dda5045ad71122f946b67ec3d1d2e278d8]

        svx: try to avoid crash in AccessibleEditableTextPara
        
        There is an out-of-bounds access to a non-existant editengine paragraph:
        
        warn:legacy.tools:40400:40400:editeng/source/editeng/editdoc.cxx:1136: Index out of range in Adjust(2)
        warn:legacy.tools:40400:40400:editeng/source/editeng/editeng.cxx:1984: Paragraph not found: GetWindowPosTopLeft
        /usr/include/c++/11/debug/vector:438:
        Error: attempt to subscript container with out-of-bounds index 1, but
        container only holds 1 elements.
        
        4  ParaPortionList::operator[](int) (this=0x6270d38, nPos=1) at editeng/source/editeng/editdoc.cxx:722
        5  ImpEditEngine::CalcParaWidth(int, bool) (this=0x6270ca0, nPara=1, bIgnoreExtraSpace=true) at editeng/source/editeng/impedit2.cxx:3307
        6  EditEngine::GetParaBounds(int) (this=0x6264a00, nPara=1) at editeng/source/editeng/editeng.cxx:646
        7  Outliner::GetParaBounds(int) const (this=0x30fb510, nParagraph=1) at editeng/source/outliner/outlin2.cxx:414
        8  SvxOutlinerForwarder::GetParaBounds(int) const (this=0x3424710, nPara=1) at editeng/source/uno/unoforou.cxx:326
        9  SvxAccessibleTextAdapter::GetParaBounds(int) const (this=0x73d7d30, nPara=1) at editeng/source/uno/unoedprx.cxx:757
        10 accessibility::AccessibleEditableTextPara::getBounds() (this=0x27c45c0) at editeng/source/accessibility/AccessibleEditableTextPara.cxx:1050
        11 accessibility::AccessibleTextHelper_Impl::UpdateBoundRect() (this=0x73d7c90) at svx/source/accessibility/AccessibleTextHelper.cxx:799
        12 accessibility::AccessibleTextHelper::UpdateChildren() (this=0x2ae5eb0) at svx/source/accessibility/AccessibleTextHelper.cxx:1658
        13 accessibility::AccessibleShape::notifyShapeEvent(com::sun::star::document::EventObject const&) (this=0x73d7690, rEventObject=...) at svx/source/accessibility/AccessibleShape.cxx:926
        14 SfxBaseModel::notifyEvent(com::sun::star::document::EventObject const&) const (this=0x2eb1b80, aEvent=...) at sfx2/source/doc/sfxbasemodel.cxx:3341
        15 SdXImpressDocument::Notify(SfxBroadcaster&, SfxHint const&) (this=0x2eb1b80, rBC=..., rHint=...) at sd/source/ui/unoidl/unomodel.cxx:408
        16 SfxBroadcaster::Broadcast(SfxHint const&) (this=0x2e6f120, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39
        17 SdrObject::BroadcastObjectChange() const (this=0x30fb190) at svx/source/svdraw/svdobj.cxx:1028
        18 SdrUndoObjSetText::Undo() (this=0x732acb0) at svx/source/svdraw/svdundo.cxx:1050
        19 sd::UndoObjectSetText::Undo() (this=0x732acb0) at sd/source/core/undo/undoobjects.cxx:204
        
        This was replaced when GetTextForwarder() apparently replaced the
        editengine object or something along those lines:
        
        5  ParaPortionList::Insert(int, ParaPortion&&) (this=0x6270d38, nPos=0, p=...) at editeng/source/editeng/editdoc.cxx:740
        6  ImpEditEngine::InitDoc(bool) (this=0x6270ca0, bKeepParaAttribs=true) at editeng/source/editeng/impedit2.cxx:241
        7  ImpEditEngine::RemoveText() (this=0x6270ca0) at editeng/source/editeng/impedit2.cxx:678
        8  ImpEditEngine::SetText(rtl::OUString const&) (this=0x6270ca0, rText="") at editeng/source/editeng/impedit2.cxx:694
        9  ImpEditEngine::SetText(EditTextObject const&) (this=0x6270ca0, rTextObject=...) at editeng/source/editeng/impedit4.cxx:1139
        10 EditEngine::SetText(EditTextObject const&) (this=0x6264a00, rTextObject=...) at editeng/source/editeng/editeng.cxx:1535
        11 Outliner::SetText(OutlinerParaObject const&) (this=0x30fb510, rPObj=...) at editeng/source/outliner/outliner.cxx:568
        12 SvxTextEditSourceImpl::GetBackgroundTextForwarder() (this=0x73d7990) at svx/source/unodraw/unoshtxt.cxx:553
        13 SvxTextEditSourceImpl::GetTextForwarder() (this=0x73d7990) at svx/source/unodraw/unoshtxt.cxx:658
        14 SvxTextEditSource::GetTextForwarder() (this=0x73c9580) at svx/source/unodraw/unoshtxt.cxx:936
        15 SvxEditSourceAdapter::GetTextForwarderAdapter() (this=0x73d7d20) at editeng/source/uno/unoedprx.cxx:324
        16 SvxEditSourceAdapter::GetTextForwarder() (this=0x73d7d20) at editeng/source/uno/unoedprx.cxx:339
        17 accessibility::AccessibleTextHelper_Impl::GetTextForwarder() const (this=0x73d7c90) at svx/source/accessibility/AccessibleTextHelper.cxx:265
        18 accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren(bool) (this=0x73d7c90, bBroadcastEvents=true) at svx/source/accessibility/AccessibleTextHelper.cxx:750
        19 accessibility::AccessibleTextHelper::UpdateChildren() (this=0x2ae5eb0) at svx/source/accessibility/AccessibleTextHelper.cxx:1657
        20 accessibility::AccessibleShape::notifyShapeEvent(com::sun::star::document::EventObject const&) (this=0x73d7690, rEventObject=...) at svx/source/accessibility/AccessibleShape.cxx:926
        21 SfxBaseModel::notifyEvent(com::sun::star::document::EventObject const&) const (this=0x2eb1b80, aEvent=...) at sfx2/source/doc/sfxbasemodel.cxx:3341
        22 SdXImpressDocument::Notify(SfxBroadcaster&, SfxHint const&) (this=0x2eb1b80, rBC=..., rHint=...) at sd/source/ui/unoidl/unomodel.cxx:408
        23 SfxBroadcaster::Broadcast(SfxHint const&) (this=0x2e6f120, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39
        24 SdrObject::BroadcastObjectChange() const (this=0x30fb190) at svx/source/svdraw/svdobj.cxx:1028
        25 SdrUndoObjSetText::Undo() (this=0x732acb0) at svx/source/svdraw/svdundo.cxx:1050
        
        So try to update the number of paragraphs when GetTextForwarder()
        was called.
        
        Change-Id: I5c0712cdf0c01d2aa0e8cd929ba51aaf1c710123
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121789
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [18d6373d3ae767d3f06d53acd3b1f88f008c4bf4]

        reduce cost of creating large charts (tdf#144052)
        
        creating a temporary SfxItemSet for each geometry object adds up fast,
        so only create the temporary for those SdrTextObj subclasses that need
        it.
        
        Change-Id: I0c03a630057718f09c12a4a2d07ad23fca46fd2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121800
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Luboš Luňák  <l.lunak@collabora.com>  [9b73d3e8926d5f9b10464d19b539eef3eb088f50]

        avoid painting to windows in LOK mode
        
        There are no actual toplevel windows in that case, and tiled rendering
        is used to paint whenever any painting is needed. The painting is
        already made useless by using (1,1)-sized Cairo surfaces for windows
        (SvpSalFrame::SetPosSize() calling SvpSalFrame::GetSurfaceFrameSize()),
        this should avoid it altogether.
        
        It is possible this commit causes regressions if some code relies
        on Paint() getting called at specific times (such as 2f961c7a811bdff66
        doing relayout there, causing geometry changes), but those should be
        fixed.
        
        Change-Id: Ie4be16301fdddb7c1b0350e6458178efca88aa4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119385
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-08  Luboš Luňák  <l.lunak@collabora.com>  [0f699173519176b9bd21761d553c34156c1ebd7d]

        patch SdrPageWindow in SdXImpressDocument::paintTile()
        
        This is based on commit 424312aa99307da9f0ee60ea6e3213b2b3dc26b4
        amd I don't quite understand everything that happens, because
        the drawing layer classes have all kinds of comments except those
        that would explain the purpose or usage of the classes. My
        understanding is that drawing layer keeps all kinds of state
        in Sdr* classes and when drawing it tries to find those based
        on the OutputDevice. But since tiled drawing uses its own
        VirtualDevice for the drawing, the search fails and a temporary state
        is used that's always setup up and cleared again. Which is wasteful,
        and not having the state around also means that e.g. when clicking
        a checkbox for impress master background, with idle painting
        disabled there's nothing to react to the event and cause a tile
        repaint.
        
        Change-Id: Ic9036680c628d67615a82dcc4f585ab827b91525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121780
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-08  Luboš Luňák  <l.lunak@collabora.com>  [b9c2207e1b5247b4d3184b137be9a75a4b8c6c37]

        avoid repeated writer layout calls with tiled rendering
        
        My next commit will disable idle paints for tile rendering, as they
        do nothing in that case (or at least that should be the case).
        But this code causes an infinite loop with idle layout timer,
        because painting resets the SwViewShellImp paint region, which is
        not performed if painting is done only later by idle rendering.
        
        Change-Id: Ic401f16254aade02ddb3e4faffd99f0ce29d4df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120201
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-08  Luboš Luňák  <l.lunak@collabora.com>  [89a282e874a706a6f7265218f476e3948dbaa10c]

        explicitly send LOK_CALLBACK_TEXT_SELECTION at the end of FindAll
        
        It normally gets emitted by SwSelPaintRects::Show(), called from
        paiting, but Online uses tiled painting and so doesn't need normal
        painting.
        
        Change-Id: If276ce176f4e65b4efe3d053941b83917df2ae1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119382
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [70cd6cac6c1fe2f13702d8ab539d56ebae93683b]

        no need to allocate this separately
        
        Change-Id: Ib92bd39d1c5057731d670a79bf788909856247be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121799
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [d70622afd96b5d1f530082c8d5dd332188937f17]

        vcl: move OutputDevice output flag functions to outdev.cxx
        
        Add unit test for EnableOutput(), IsOutputEnabled() and is
        IsDeviceOutputNecessary().
        
        Change-Id: Ic07bcdc650575c1a2788adc3c967cb02e2f68302
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121019
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [6d6c0e2c35186323bb5af35f5a58a2c9d9baa1ed]

        vcl: migrate GetDownsampledBitmap() from OutputDevice to vcl::bitmap
        
        Change-Id: Iee6caa8292472a3acca66d670a113b701f4b637e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121581
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Chris Sherlock  <chris.sherlock79@gmail.com>  [f83d1b824c1abd07d24318adda6c876b9471ccec]

        vcl: make GetDownsampledBitmap() take destination size in units of twips
        
        This removes the need to use OutputDevice functions, which means we can
        later move this function to bitmaptools.cxx
        
        Change-Id: If547563808c2656d395d4669507f5f8dcfadcabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121580
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d2440c757daa7e16e3dec607497cb7175687799d]

        vcl: remove CustomWidgetDraw as it is not needed anymore
        
        CustomWidgetDraw was the first implemetation for custom drawing
        of widgets, which was now replaced by FileDefinitionsWidgetDraw
        so CustomWidgetDraw is not needed anymore.
        
        Change-Id: I1c7a9fcf720bbfd91d9c44ad4b15a7281a0d0e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121740
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [51d4ba35dd98bf4bae798f38da1d2762f1a1d31e]

        Fix typos
        
        Change-Id: Ic3793bd77a7db52e59797cc6b2153850b1cec42e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121737
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-08  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f7df27f0a25bdc2cb15fe59a1b217b75f528e9bd]

        Fix typos
        
        Change-Id: I42d38399726acb1d044b4b9f032de96ded00e5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121542
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-08  Miklos Vajna  <vmiklos@collabora.com>  [5a10614eb46bd206e512a34aa55c38fc64a7a19f]

        CppunitTest_sw_ooxmlexport9: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ic11b52a2a54aa4865d3a9663e5aaf3ee9ac85cc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121790
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-08  Justin Luth  <justin_luth@sil.org>  [d7ead0f1f36c66f008cb4a7726fd59b9ab5a943a]

        remove unnecessary meta.xml from autotext
        
        I kept this separate to simplify spotting errors.
        
        There were about 130 unique md5sum hashes, and all were
        roughly the same size. I spot checked a few with "meld"
        and didn't see anything that seemed valuable.
        
        find . -name meta.xml  -exec rm {} \;
        git grep -l \/meta.xml *.xml | xargs sed -i /\/meta.xml/d
        git grep -l \/meta.xml ../CustomTarget_autotextshare.mk \
            | xargs sed -i "/\/meta.xml/d"
        
        Change-Id: Id11ec9973a8764ffbc809f9161868d6cacb80a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121606
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Laurent Balland-Poirier <laurent.balland-poirier@laposte.net>

2021-09-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [83da70de985e1f9f7193676bef8dc71226803bb0]

        indexing: rename "type" for prargraph an object nodes
        
        They are conflicting, so rename the one for paragraphs to
        "node_type and the one for objects to "object_type". This needs
        adusting all the tests. Also change the node_type from numerical
        value (correcponding to a enum) to string based - "writer" or
        "commom" values.
        
        Change-Id: I0465cd4c2c6989e436d5a675db20c87066d19208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121743
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eac288d02cafc49c5a14fa27bb449c33eb4b1803]

        indexing: support JSON and XML as input for SearchResultLocator
        
        JSON is much easier to deal with when using REST and javascript,
        so support both.
        
        Change-Id: I61035452d9a7ba889ac355a42201d79b9fafec6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121742
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-08  Mike Kaganski  <mike.kaganski@collabora.com>  [8151f3a1d99ab740d2affdccc7115faa156bf3ad]

        Drop unused rUsedDetectors argument
        
        ... ever since commit e4003b67062e575f9b77772488f9b9691fa9fc38
        
          Author: Kohei Yoshida
          Date:   Thu Mar 7 01:35:09 2013 -0500
        
              Make check passes.  Remove deep-only detection for real.
        
              Now the type detection process is a lot more simpler.
        
        Change-Id: Ib0c08e28edf85a3642e187798a08ed2e143bf56c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121765
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [e662e835c208481c909d8caa34fc66b6fadda3c0]

        Guard Orcus detection shortcut
        
        So that its policy matches the other places in this function
        
        Change-Id: I309441f63cf82bbae2b19c7de588d4228b988bad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121764
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [975c73fe13e743ecd922a93be190476cf250d9ba]

        Fixed typos in the description of the default case for optionals
        
        Change-Id: Ib80faf454fe4ef22b3ebb0b633769d4479cd84a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121793
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [409abb1fca4d360295304e1efff471d63a51e436]

        Fixed a copy paste error in the test cases
        
        Change-Id: Ib11b6cfe385542664b28de35897caee67099d22c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121792
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [092740eddd9d2e9b19e4c08f4980a59402e676e1]

        tdf#144245 - Added test file to automatic test
        
        Change-Id: I92b71b7e7ac8c2262d36875e4b04ed91e17bc495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121791
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [491678690b5b40f446b40c368ec4b4423ee603c1]

        unbalanced [Beg/End]Undo possible on self-dnd in impress
        
        repeatedly holding the mouse button on an object long enough to start a
        drag and then trying again will eventually result in a situation where
        View::StartDrag is called, triggering a gtk_drag_begin which neither
        fails with drag-failure or succeeds with drag-end and so no
        View::DragFinished gets called. This is possibly only an issue under
        (Fedora 34) wayland.
        
        When it happens it leaves an unbalanced BegUndo from StartDrag with no
        EndUndo which will eventually be fatal if the user uses undo.
        
        So remove the BegUndo from StartDrag because we can't be sure to get
        a DragFinished and...
        
        a) put the removal of original objects (when ACTION_MOVE) in
        DragFinished in a simple BegUndo/EndUndo block of its own. Whether the
        dnd is to another application or to ourself won't matter.
        b) in View::InsertData detect if the action is a self-dnd and if so
        put that in another BegUndo/EndUndo block and explicitly call
        DragFinished before EndUndo to put a) within that group so a drag
        of an object from one slide to the other gives a single "Drag and Drop"
        move undo action listed for the copy and delete. DragFinished will
        get called again but that's ok in this case and its 2nd call won't
        affect the undo stack.
        c) when this problem arises, later Drag attempts fail to do anything
        because View::StartDrag returns early if a mpDragSrcMarkList from an
        earlier attempt is set.  Remove that guard and allow mpDragSrcMarkList
        to be replaced after a silently failed drag attempt.
        
        Change-Id: I3933663ff74f1ca99d9410b7752227ecf8d0da46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121787
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [e812693053b18f4d0c6461c4fe8f965ba1695f76]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I07ab38df2855a55cea1993ad29c7e2b58c6a3142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121781
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Michael Stahl  <michael.stahl@allotropia.de>  [992f878e8c3424f7ce96a78ccf3a316b29ffd9ec]

        tdf#142129 vcl: add unit test
        
        Reportedly bug was fixed by commit
        5fc6a601d7a1978db291fd0f7dcec638a7c25651
        
        Change-Id: Iee32cacff0c939bdf498e9dc8102eb2d22a5a1c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121776
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [7228a2dbfa11cd846678aaacd248c68adcda5f34]

        vcl: rename PrinterOptions to vcl::printer::Options
        
        Move Options to own source and header files. Options moved to own
        source and header files, however also put Options into vcl::printer
        namespace.
        
        I have renamed and moved PrinterOptions into the vcl::printer namespace
        because the word "Printer" is redundant, and we want to organize the vcl
        namespace better.
        
        Change-Id: I2ef188af381dd65907d48f7b190e4ab69417606d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121389
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [b42516b433c1d71487db061a058887f6dd76dd74]

        dynamic_cast followed by static_cast
        
        Change-Id: If917550a1425d3ec82fcf7ad06dd9f9438fb2e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121750
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Mike Kaganski  <mike.kaganski@collabora.com>  [500f85145181ff219d801cb26b0cfd44a219598a]

        Fix typo
        
        Change-Id: Ie7481a122436ae765e36642f27afa45b8a11bba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121761
        Reviewed-by: René Engelhard <rene@debian.org>
        Tested-by: René Engelhard <rene@debian.org>

2021-09-07  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [5be9a4c470c7423956eb8d2cdaf90b4a77dd82d7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 77c10ceaaabe76f57014e53dbdd4560d988bb8a1
          - Fix typo in path to Tip-of-the-day xhp
            
            Change-Id: Id7a058cd490fcf52151e7ae8897016039d16f3d1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121786
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [b3a3cc0e260b4f0fee645910db9548b1098eb420]

        wina11y: Drop CAccTable::GetXInterface
        
        Consistently use the 'pRXTable' member directly instead
        of mixing both ways to access it in almost every
        CAccTable method.
        
        While at it, also unify code a bit which is used to check
        'pRXTable' inside of most CAccTable methods.
        
        Change-Id: Iafbff80b8304edd994507f86abd57b6dae7fe353
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121778
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [47b1bb2f66acc920a0a46cc84a32dabdd9540894]

        wina11y: Move "stdafx.h" include to headers
        
        Move the "stdafx.h" include to the MAccessible.h
        and UNOXWrapper.h headers from the corresponding
        source files, since the 'ATL_NO_VTABLE' define
        from stdafx.h is already used in the headers.
        
        (This e.g. also makes sure that the define is known
        when opening one of those headers in an IDE.)
        
        Change-Id: I3b6b7df037846daaad4d702e0e0c0bd2970dc663
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121773
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [f565adda49eae3cb2a07c3b4f2dff5c380c7a524]

        Revert: #i47175# update eventual pointer grab with cursor
        
        revert commit:
        
        commit d4f61372b23d6bb7f4df1e563f0823b3a3211c1d
        Date:   Mon Mar 5 14:25:35 2007 +0000
        
            INTEGRATION: CWS vcl74 (1.59.42); FILE MERGED
            2007/01/31 15:25:15 pl 1.59.42.1: #i47175# update eventual pointer grab with cursor
        
        this got later modified by...
        
        commit e9cb118e6e98eb13b3ad1901c8c912bed674f096
        Date:   Tue Jan 29 15:21:11 2008 +0000
        
            INTEGRATION: CWS vcl85_SRC680 (1.71.70); FILE MERGED
            ...
            2007/12/13 15:30:31 pl 1.71.70.1: #i80791# use correct owner events parameter in SetPointer
        
        but now in impress, under wayland, if I click and hold on the border of
        a textbox and then try to use SetPointer while the mouse is captured
        then the cursor doesn't change, the regrab drops the cursor.
        
        The original problem reported back in #i47175# no longer arises in gtk
        as the dialog is a native gtk one.
        
        Drop this workaround as its weird to potentially do a special grab when
        we just want to change the mouse cursor.
        
        Change-Id: Ifb7f55a17692a5e79cd4221d1e0f440dacbee0bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [a19e8ddded0aa4d1fe1d36a3c63dff43cb8ad589]

        loplugin:unusedmethods
        
        Change-Id: I6295d6ff6fb7410852351801c324244308c5c472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-07  Luboš Luňák  <l.lunak@collabora.com>  [39f88f29725a5e896bdd3dffc8957f50a19c1698]

        explain a 'not sure why' comment about cairo (1,1) sizes
        
        This is from 9090dc1f3b27195f5defd35586ac79357992be21.
        
        Change-Id: Iae98628b58022c8bb3c50eef6889923023b67319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121777
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a08130b30671c0c9865e759c19aebed76d80d186]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 280680693746332e5bf1d49f53285b29b0ae321d
          - tdf#141179 Add tip-of-the-day help page
            
            Change-Id: I0fe0a3d6615b98d943d6a4cb9f47bc255cf4eef8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121689
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [eae61be02760e6e49179552978584a949694cd5a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d883745bda47f21301f6cbf29bbd47512ef9d000
          - tdf#144339 Add Help page for ProtectFields and ProtectBookmarks
            
            Change-Id: Ib784738af17d89b356bc6954c9402b2423cfd478
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121739
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4bf69ec35cb19577319fc2fa66ca425d40b7892b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2753562419d2407c22db5af9c216f2ac00eb5000
          - tdf#137084 Update Writer Table and Tools menu Help
            
            Change-Id: I546f247253bd7c8f041342ae2cf7447be34caf38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121733
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e59d4723bb8959d1d39dccdccb66156ca68d280a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e02e75de71eed2d22a4ad4bb18bbfb1f60aa5480
          - tdf#144332 Add Help page for Accessibility Check Tool
            
            Change-Id: Ifdca4c17a5f2f97d27cd59e65b1855abb2d243f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121731
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9627b2cb9e5d53f54ec09805eadc98d247121463]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5910cbd9619da6f850da070babb75abd6d334806
          - tdf#127385 Update HTML <meta> export.
            
            Change-Id: I8c3968e89d8b919b57def783b8964efeb3d65ec1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121722
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-07  Stephan Bergmann  <sbergman@redhat.com>  [6593ebcc01a097e865a0fdc59b65604ae9cd5032]

        exernal/firebird: extern/cloop: Missing dependencies of compilations on...
        
        ...output directories
        
        Change-Id: Iaa2b750a12e3df078b46e5bb4feeafc926e11165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121741
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [5d47a0e6c0fe4c2aca0c6a6cc6a542bada977f12]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4c88389de1a7f6cf4ceac278b264a0ec71fba86d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Caolán McNamara  <caolanm@redhat.com>  [99141aea4d81d89ff5d14087e6647b25f7018e8b]

        Related: tdf#142458 don't change border size during Paint
        
        so GetOptimalSize/get_preferred_size before/after paint has the same result
        
        Change-Id: I25abe31c069561e30a9af7c4b9b81582298e0f9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121616
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [ef32c3b4f9b80918d6018e14297fa41245afd381]

        tdf#144245 - Case-insensitive operation for non-ASCII characters
        
        Support case-insensitive operation for non-ASCII characters in the
        Collection object (VBA).
        
        Change-Id: Ie17560cb9aac5bfb32aa041744445dd4839681d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121534
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-09-07  Luboš Luňák  <l.lunak@collabora.com>  [57cac3a19f5e07da137ecd616ccddf81ca185fa9]

        prepend #<num> to frames in unx backtraces
        
        To make complex backtraces readable.
        
        Change-Id: I3a95d03d97c8e6d1aa7aeab37957d3b8441c3c90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121724
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [2284be4f80664c54fa2ef8652030aa14d63c13a2]

        vcl: followup tdf#74702 vcl: remove GetOutDevType() from ImplNewFont()
        
        virtual keyword was missing on ImplNewFont(), without it the previous
        change effectively removed the PDFWriterImpl code. Thanks to Noel for
        pointing this out.
        
        Change-Id: I3148ee90e61cdb9d2d6b242ebe4964fb0394416d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [26e45694433721a8837a2133c05798776576def6]

        wina11y: Drop unused CMAccessible::IsDescendantManage
        
        Change-Id: I90aa35ec3567d720c8adbe0cfc96343bef678ba1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121730
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [c772f4458ec0ce486c8bfefecd99c37527bec732]

        Use while instead of for loop
        
        ... since only the condition and no init-statement or
        iteration-expression is set anyway.
        
        Change-Id: Icd9c5c9cf1e89f39984ed13624246731da0d7acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121729
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [8ea154ed94578cc3fa6533afa70e67e5a34e9d9a]

        wina11y: Let CMAccessible::get_IAccessibleFromXAccessible return bool
        
        ... instead of BOOL (from minwindef.h).
        All callers already assign the result to bool anyway.
        
        Change-Id: Ica29df7218815b00346474b679e7dbb180e96a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121728
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Michael Weghorn  <m.weghorn@posteo.de>  [47338aa502df2729db670586060be8667179a82e]

        wina11y: Drop unused CMAccessible::m_bRequiresSave
        
        It was already unused when it was added in
        
            commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
            Date:   Thu Nov 14 08:18:05 2013 +0000
        
                Integrate branch of IAccessible2
        
        Change-Id: I449314d1c13d27e76199e4bb753e88b58b8949d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121727
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-07  Miklos Vajna  <vmiklos@collabora.com>  [084f60a07cf5ba41d4dd8f9bb2726c78eb8a7874]

        Avoid repeating the return type from the declaration
        
        Change-Id: I0dce02d10b8c74e80f5672e2dd580b6837ba3291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121732
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-07  Chris Sherlock  <chris.sherlock79@gmail.com>  [7ccfae545d7650a7f3e6bc8a010c97cd0a60e9a5]

        vcl: move OutputDevice rasterop functions to outdev.cxx
        
        Split off RasterOp enum into own header, and also add unit tests for
        SetRasterOp() and GetRasterOp().
        
        Change-Id: I1c97e87ef2d0684cb15b6ac544597eace5adb48a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121018
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-07  Dennis Francis  <dennis.francis@collabora.com>  [e70399e5bd4a41a2989030ddfb0404b6248f655d]

        sc: lok: introduce LOK_CALLBACK_DOCUMENT_BACKGROUND_COLOR callback
        
        to send the document background color (Calc only for now).
        
        Change-Id: Ibd2f042a81c9bb714bed947c4ef92f82ff3e6f50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120524
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 5f2d669a51a91b21196eecb935aa55d3fc1aa7be)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120738
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-09-06  Mike Kaganski  <mike.kaganski@collabora.com>  [c7b5e6566d9b24a0a996c739a945004d9aadee2f]

        tdf#144340: fix FB configure on Windows
        
        ./configure runs on Windows, and sets value of FB_ALIGNMENT,
        a define that affects the layout of FB's sort memory pool.
        
        Trying to include <semaphore.h> fails on Windows; the test in
        ./configure considers error value (equal to 2) as the value of
        the alignment (which should be 4 or 8 depending on arch). This
        makes the memory misaligned, chunks overlapping and re-written
        during the sort, memory corrupt, and so on.
        
        Removing the include (which is documented in a commit adding a
        similar include [1] to be needed for m68k) fixes detection.
        
        Additionally this cleans up the code added to config.h.in from
        autoconfig_msvc.h, because the former is auto-generated during
        configure, and the values get re-written in all occurrences of
        respective defines anyway.
        
        [1] https://github.com/FirebirdSQL/firebird/commit/7ba46163c74211ce4bf1051ee9998db58cb2f396
        
        Change-Id: I8cdc5c764385a04efd130af09138149c748341fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121753
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-06  Julien Nabet  <serval2412@yahoo.fr>  [970883a85ad1d714683a1d98fb45efc89cbdeb3b]

        tdf#140951: fix crash on Base when accessibility used
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=174832
        
        Change-Id: Ia0a52b1e6aafc043f6be2d8406a98e7d4ebf55dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121735
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e83f5c04c4689f5812098e248999e7ad4e7dcbf0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f62fb28bc3aad654de660408e9215cd66abb3e5b
          - Fix typo
            
            Change-Id: I59548caf3c307d7ff95354f9d7f664112af23b21
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121736
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [81f6842a7d03f5b93ddcece64ef252cc9adf4350]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I51f4e8affac41023110042b534a915f096ccd0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121692
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8cf0d2cb4e5e18f48d6b3bfbc7d0e72e7ed5190]

        tdf#144319 fix formula load
        
        regression from
            commit 67d83e40e2c4f3862c50e6abeabfc24a75119fc8
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sat Dec 19 13:25:53 2020 +0200
            speedup rational_FromDouble
        
        Change-Id: Icb728b63f950e827f1492087114f927c2f85ddb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121719
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Caolán McNamara  <caolanm@redhat.com>  [2e4ce586f95230e1e5cffd1d3349090877ce3afd]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I979b11badd0df454aa0d344b90c809a2a3f6c392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-06  Caolán McNamara  <caolanm@redhat.com>  [5fa8ee4650962bf483b6ac034dd373b5d7b9926e]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I139458eee9176e6c86a800b5547cbd8ba80dba35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121720
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-06  Jan Holesovsky  <kendy@collabora.com>  [c6564fb00a59224b223f4bbd8e58612ab3e40b0f]

        Fix build with system boost
        
        Change-Id: I86ffabd30535b594a40d786f7c4602abbbb5a54a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121513
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-09-06  Justin Luth  <justin_luth@sil.org>  [23ec2a69123e983259b3f7fec73932270cd85e02]

        remove unnecessary settings.xml from autotext
        
        I don't think that anyone wants their document settings adjusted
        just by entering some autotext.
        [Now, it didn't seem to be doing that because I suppose that since
        the value already exists, the import won't overwrite it.]
        
        find extras/source  -name settings.xml | md5sum | sort
           //shows only a few unique entries. Visual comparing with "Meld"
           //didn't reveal any reason why the files are useful.
        
        I also removed ./autotext/lang/bg/standard/FN/Obj0012D655/settings.xml
        based on Laurent's advice, even though it contains
        <config:config-item config:name="Formula" E=mc^2
        
        Otherwise, the other 7 versions were almost identical, differening
        only in OOo version .9, or 1.1 and show redline changes on/off.
        
        cd exttras/source
        find . -name settings.xml  -exec rm {} \;
        git grep -l \/settings.xml *.xml | xargs sed -i /\/settings.xml/d
        git grep -l \/settings.xml ../CustomTarget_autotextshare.mk \
               | xargs sed -i "/\/settings.xml/d"
        
        Change-Id: I9c148bdff55e6757e6fa98401486bc7c41ebf25d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121605
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-06  Justin Luth  <justin_luth@sil.org>  [b13e8762a765b9ec619647d5f447d44156c8c5d1]

        ODT xmlimport: No need to specify the default value for LoadReadonly
        
        A document is naturally not going to be loaded ReadOnly
        so no need to "force" this to false if the setting
        does not exist in the document.
        sfx2/source/doc/objxtor.cxx:    ,bLoadReadonly( false )
        
        That's just confusing because this is in a section of variables
        that have adjusted LO's native behaviour over time.
        However, this settings is not a native behaviour change,
        and is solely handled in the writerfilter import filters.
        
        Change-Id: I0699c14da99b9926aef03cac4e3b3934c23d5e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121718
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-06  Regina Henschel  <rb.henschel@t-online.de>  [84d6d704682a4d0e037a28895356b073e4f992a5]

        tdf#144242 no width-height swap for line and pathline
        
        MS Office swaps width and height for rotation angle ranges 45..135 and
        225..315. Line and Pathline objects incorporate the rotation into their
        points, so have no rotation. Line and open Pathline objects nevertheless
        report an rotation angle. That one is used to align the text direction
        to the line. But because of this reported angle, width and height were
        swapped. The patch excludes these objects explicitly.
        
        The case differentiation for the rotation range had forgotten to
        normalize the angle. Therefore, in a reopened spreadsheet, the line was
        accidentally exported correctly without width-height swap, because in
        this case the rotation angle is negative.
        
        Change-Id: I5f698d1cc734e17bcb02ff77db5224a228392e06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121661
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-09-06  Baran Aytas  <barannaytas@gmail.com>  [aa695290263140deb24203e65148aa81fbaa6f1c]

        tdf#143549: 3 dots missing after Import/Export strings in File menu
        
        Change-Id: I03410f4a7224b7faa3f214c7ac3fad1f876e89d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121083
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-09-06  Emircan Agac  <thesadson@gmail.com>  [7a8ec6cddc9f37ba6ff1a98ad39702521c8fb36b]

        tdf#130924 : replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: Ifede38f3b19d1e5226e18dba1aa21d478a430d9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120763
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-09-06  Luboš Luňák  <l.lunak@collabora.com>  [1d021c87208c44b4943e4260ae58fb2478851d47]

        also cache addr2line results
        
        Change-Id: Ib4351ba7a585ada3887f1cbeb5d676733250598b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121585
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-06  Luboš Luňák  <l.lunak@collabora.com>  [9aa2fcb408334f48b9ba3a7525b4f20f8e0f19e9]

        group addr2line calls per binary for better performance
        
        Change-Id: Ifc655e4d5e2f3eb934b407e146ee564e3db0146b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121584
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-06  Luboš Luňák  <l.lunak@collabora.com>  [665bd649088e6dccf4d53251e10b182950259b46]

        improve sal::backtrace_get() by using addr2line in debug builds
        
        The backtrace_symbols() function provides backtraces that often
        miss many function names, try harder to resolve them, using addr2line
        is the best (only?) working solution I've found.
        
        Change-Id: Ieda06fc52735596e499fb7f9443cae13d134da5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121539
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-06  Justin Luth  <justin_luth@sil.org>  [328975ad14a8dbf5a86aacd0b0552b49b77746f4]

        ODT xmlimport: No need to specify the default value for settings
        
        sw/source/core/doc/DocumentSettingManager.cxx initializes
        mbClippedPictures(false),
        mbUnbreakableNumberings(false),
        mbBackgroundParaOverDrawings(false),
        mbTabOverMargin(false),
        so no need to "force" these to false if the setting
        does not exist in the document.
        
        That's just confusing because this is in a section of variables
        that have adjusted LO's native behaviour over time.
        However, these settings are not a native behaviour change,
        just a Word compat change, which is solely handled
        in the doc/writerfilter import filters.
        
        Change-Id: I9fc0ec89c601fbe518ec1515c7091d7820dde4df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121716
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-06  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [223f3a6fac43580114bca86abb34d7cf3219f4bc]

        Revert "tdf#142214: autocomplete: do not search across empty blocks"
        
        This reverts commit ca2ec443893731093970914feb750b31ea13e47f.
        
        Breaks user experience.
        
        Removed ScTiledRenderingTest::testAutoInputStringBlock as well.
        
        Change-Id: Id03bc645d78c29c0aa588b2133fc1cb96f3cceb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121640
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-09-06  Caolán McNamara  <caolanm@redhat.com>  [a2e64311da811d40c3d0dba578cd5395b8a628e2]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iaa51ef9f7d00de241f4d0e0564c90d6d11cc2f9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121713
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [db0a6e1bd98a9430e9ca4edfaabc3b11da986592]

        vcl: migrate ImplLayoutRuns to own files
        
        Wrote a set of unit tests for ImplLayoutRuns, and added ImplLayoutRuns
        to vcl::text namespace.
        
        Change-Id: Id6ae8882acb8e3d821bb38551e78019cbdcaa662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Chris Sherlock  <chris.sherlock79@gmail.com>  [8381242c2e0bfda1b37e7e82525926c0497c81d4]

        vcl: move ImplLayoutArgs to own header and source files
        
        Add unit tests for ImplLayoutArgs. Also add to the vcl::text namespace.
        
        Change-Id: I9fa0943548be8ca17ea3dac104e9cb609337a70e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [b0aae09e6c565f5578672f38ebb1fed36784bdff]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I706eebc3e4e2bbcb9bf250a4864937fd1447498c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Caolán McNamara  <caolanm@redhat.com>  [885ef9d4d7ab9b725317c96dc09cd3914de47929]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4a96b4e687f57ee38686dc03d87ba29de3ec0e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121708
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-06  Johnny_M  <klasse@partyheld.de>  [5a8d5729089e0614003dfad6d5041e08e7529b71]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 28b4c299d1d89b814502c9da56bf828b8808ceb0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3e4837b03f75e22b9a16c7e09f588ef41158afcf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121684
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [fdd70f5cfc28f2f46f31f6b3b433d2bb6a44dd97]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a45d5974327de9d9c19add1bb34ed7e2eb7fcfa7
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie8aac3915175120b92e27485969ac668b7f18d91
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121685
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [cae148857c9dfe076431f4ea50f288c2b582cd27]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 657e759f0e112ca52430cc1f66443a9f1db4bd55
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie11211bb128705f705f0d15f2d26c2da5246745d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121683
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [e1c12e8fa74ad2d063cbf1cbb3c65803e94295e0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a5482ae38c48102cec1146b772cbae947336fb10
          - tdf#132643 Translate German section IDs
            
            Change-Id: I413b89005ab53cac577ed9a5771aaf5908650493
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121682
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [b23dbf4dfaca50a3079aded0ad4167bc1bf020a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a64bb981511f6e49165212e90a50c026ad5c788a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib27c07414f07f4e642b664cb14f75f9a4fee9c46
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121679
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [37bd4c1e0d1236c89613ad1489df95110ac91c50]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d442cfa233db0c02a5126c70e29979aae84096a9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1da52c93b90d802b2b5f2ed1c955e24cfaf77230
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121681
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [1aed036ab09576f7728df17255dfa0670f7a86d3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 419c0979ec8d7c454a366348413f49dcab2683b8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I85a6d6242be12af6c06664cc4ddb45e8c9864da4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121680
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [72c831648f07f72074914b8398d448d45cc90d4b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f1d5d007a270371051f8a597784e5e6d20c182d3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7552e248032e18bc615679acabed6a242c84dd6e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121677
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [2566d9a0417c2e69a2c01aaeb63dc62b0402ce21]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1909fe1ddc1674f1aefca10da497c488ff87e623
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id6481f217b036d44b41baad6877229dd37c4fbc1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121678
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [10831fb7542edcfd66470550a2d062e24c65c5e1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 536fe5768bce7ac7134c7543c1c47a046a30253b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6b24d80ada49c47ef139f0c2d1d4a9722bbb9b23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121675
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [c42bcd33cc1b1fa3092c4956ee483ad9c888523d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 895629211fb1f3f58567c81a26d59d712ff630b4
          - tdf#132643 Translate German section IDs
            
            Change-Id: I76ea3b83b23d633cfbceabf0ff007838b63a221d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121676
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [a1074c8e49ab28f04486c99a1f2b493ce224b24f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c411f87cf9c8c66aff9a5f7535b4d70fd2cbeef8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I96184ead3dc22000ed5175c7a127a0907a44cc76
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121673
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [5944168f53ed84cd760d1ea07e4ee3e972102dd8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d3bbd981ecc5ab4dcc51de0357dd48c3fd5a89f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6e3dff6c566a3dab07905b4418caeb34e693bcce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121674
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d56337387dd08315410d62efd525c552569d60a]

        clang-tidy:clang-analyzer-optin.performance.Padding
        
        noting that XMLTokenEnum was already being treated as being limited to
        32-bits, we bitmask it together with namespaces
        
        Change-Id: Ic48f2a662452d1b8e022078d31a723d2ac65aef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Johnny_M  <klasse@partyheld.de>  [0219788cb57e51820d0c5ea99d570efd735cfb72]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 477f8eb481c246c93fe43b02aec322a8ae98a160
          - tdf#132643 Translate German section IDs
            
            Change-Id: I3667a035e0df4a4cc1ef58da2e6be3644b1bbbc0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121671
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Johnny_M  <klasse@partyheld.de>  [4d3ecf73c07694ac953eadf668a6b91635eee903]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8a05f40b020b5e01025d5c353801524e0ef83a6e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic0e18058ba2c0ba12f7af8f278db8de919c0177c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121672
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-06  Stephan Bergmann  <sbergman@redhat.com>  [9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4]

        Flatpak: Upgrade to 21.08 runtime, disable Skia
        
        For whatever reason, building Skia against the 21.08 SDK would fail with
        
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘void {anonymous}::colrv1_draw_paint(SkCanvas*, const FT_Color*, FT_Face, FT_COLR_Paint)’:
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:668:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’?
        >   668 |         case FT_COLR_PAINTFORMAT_TRANSFORMED: {
        >       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >       |              FT_COLR_PAINTFORMAT_TRANSFORM
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:669:60: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’?
        >   669 |             SkMatrix transform = ToSkMatrix(colrv1_paint.u.transformed.affine);
        >       |                                                            ^~~~~~~~~~~
        >       |                                                            transform
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘bool {anonymous}::colrv1_traverse_paint(SkCanvas*, const FT_Color*, FT_Face, FT_OpaquePaint)’:
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:763:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’?
        >   763 |         case FT_COLR_PAINTFORMAT_TRANSFORMED:
        >       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        >       |              FT_COLR_PAINTFORMAT_TRANSFORM
        > /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:768:74: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’?
        >   768 |                     colrv1_traverse_paint(canvas, palette, face, paint.u.transformed.paint);
        >       |                                                                          ^~~~~~~~~~~
        >       |                                                                          transform
        > make[1]: *** [/run/build/libreoffice/solenv/gbuild/LinkTarget.mk:347: /run/build/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.o] Error 1
        
        But including Skia in the Linux flatpak isn't too useful anyway (and just
        happened to be on by default):  First, it is disabled by default on Linux, cf.
        UseSkia in officecfg/registry/data/org/openoffice/Office/Common.xcu.  And
        second, on Linux it can only be enabled for SAL_USE_VCLPLUGIN=gen, but not for
        the gtk3 plugin that the flatpak normally uses, cf.
        OfaViewTabPage::UpdateSkiaStatus in cui/source/options/optgdlg.cxx.
        
        Change-Id: Ifdc9c23676280caf19db0e9f09df15aaa21eef5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121705
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [88e81b3c5f7167d7dfc93617c3f9d9d6633ba0ad]

        tdf#142579 Consider cond. format background colors in color filter
        
        In addition to color scale, consider background colors set by a
        conditional style.
        
        Change-Id: I203c4a5ae87aa7b47c2caafcac703b0a0c1a677c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121474
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-06  tobias  <tobias.schulz@hotmail.com>  [72c000a8fd28215e839a731bb00147395f35ba4e]

        tdf#138255 use GtkSpinButton in SwGotoPageDlg
        
        Use GtkSpinButton instead of GtkEntry in SwGotoPageDlg analogous to
        the widget in SwNavigationPI.
        
        Change-Id: I0ddb4433bea23d8f3d460bd69f30a10b8f7ce984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121688
        Tested-by: Jenkins
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-06  Caolán McNamara  <caolanm@redhat.com>  [07e4ec83ffbcd42264e7c1429a69048109de2182]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6db44a3a56f3eca02970bdce393355715564299e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121701
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [0f5edf0899962bc696cd1c40646c8d4b5add2208]

        tdf#142580 Consider cond. format text colors in color filter
        
        When using a conditional style to override the text color in conditional formatting,
        the color from the style overrides directly applied text color.
        Consider this in the color filter.
        
        Change-Id: Ieaa1c475d87866de1e2d497127be9d06d1f3d3f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121311
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [817ef891cf2bef8fdc82852f73acb422afb89bd2]

        tdf#142579 Consider color scale background colors in color filter
        
        When using a color scale in conditional formatting, the color from the color
        scale overrides the cell background color.
        Consider this in the color filter.
        
        Change-Id: Ifbefedbf1152165b65f8fbc3eeff29ffccf29898
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121074
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-06  Miklos Vajna  <vmiklos@collabora.com>  [0a501634786cf5fc7bec0ff2010423280db0754f]

        sw: prefix members of SwLabCfgItem
        
        See tdf#94879 for motivation.
        
        Change-Id: I00fdf912e5cacdf4152184e0164fcb25dfee575e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121704
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [a49242a7e8747a61904525bcf53d129f2f279e62]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: Ib41556edafb03c770938c91cff89bfaefa23d7cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [03d8a9209140a68d29b7441b3588f022cfcaee7c]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I8590d67f064dd74da42c0e3bf543f2aadbd2b893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-06  Dennis Francis  <dennisfrancis.in@gmail.com>  [f547cf17a179ebd7de5c2b4dd2d00d0027a25429]

        [API CHANGE] oox: fix import of chart date categories
        
        Before this fix, date categories imported in oox's DataSourceContext were
        stored as formatted strings according to number format code in <c:formatCode>
        under the <c:cat> tree. As a result chart2 could not recognize them
        as dates. This causes problems like:
        
        * The axis that is linked to date categories cannot use the
          scaling/range-selection(min/max)/increments specs mentioned as axis
          properties. This results in distorted/unreadable chart renders w.r.t
          the date axis.
        
        * No re-formatting is attempted as per the number format provided for axis.
        
        This patch introduces a role qualifer argument to the XDataProvider
        interface method createDataSequenceByValueArray to support categories of
        date type via this method.
        
        When exporting to oox, write date categories and format code under
        <c:cat>
          <c:numRef>
            <c:numCache>
        
        This patch also fixes some discrepancies in date axis interval
        computation (auto mode) found by already existing unit tests.
        
        Change-Id: Ibc53b0a56fdddba80ba452d5567ce98d80460ea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121525
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-06  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ba1e42f05e785c30d03553acd5647eebd7cdede6]

        tdf#142965 color filter: allow filtering by no fill/automatic color
        
        Change-Id: Idd0a41cea936fd19adbc07561b0d9c0cba735f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120946
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-09-06  Baran Aytas  <barannaytas@gmail.com>  [d383a70c46e0dcbe74d6765cd5a394428c198917]

        tdf#114441: Convert use of sal_uLong to better integer types
        
        Change-Id: I15dac18e25d9a0c49a3c1e7c08407d1d2b23467a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121410
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-05  Noel Grandin  <noelgrandin@gmail.com>  [4cd3ce9848aa039b8d443a1257d1298231680b01]

        no need to allocate DimensionNode with unique_ptr
        
        Change-Id: Ia832d2098b72a9e88e7a708d205c49bd3e9c82a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121652
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-05  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ee8146d431b17d6a3e3be81400c539a2347aa0f9]

        Colibre: tdf#104169 revise FatCross cursor to make it  sharper
        
        Change-Id: Ia5966c204f8001f1e7b6f5956f8541c4ecbc2901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121633
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [148d2ffe35cae2fe758a3eb68ffd3ed81e2a8dd1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3de2dd1032f0b43f484b67be0ba470ae08395e91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Stephan Bergmann  <sbergman@redhat.com>  [996a259ce73d04686fe893f62480f59a641e2a5d]

        Adapt solenv/flatpak-manifest.in to recent download.lst changes
        
        Change-Id: I88ff67fc9922adc7e6c751c76425c68701512481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121599
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [045765d8b3cd9b00a76e58dfaaffc83422f5fb28]

        cid#1491055 Explicit null dereferenced
        
        this always dereferenced pCode so it already assumes pCode cannot be null
        
        Change-Id: I19b601d7f2e089eb2037532590f727c5cd276dd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121695
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [f37ef60c19d1608f0b597d37d025e401d6c99171]

        cid#1490901 silence Out-of-bounds read
        
        Change-Id: I9a2c1fe10fc696d5392cd6c95cff11124b5fdb01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121696
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [094117fc686e7b5cf05191079f2195155fc3513e]

        ofz: fods timeout, set SAX_DISABLE_THREADS
        
        sax/source/fastparser/fastparser.cxx:857 rEntity.maConsumeResume.wait()
        seen in timeout backtrace
        
        Change-Id: Ic1ab15e06dc5ac776101715026a334957bb8e868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Noel Grandin  <noelgrandin@gmail.com>  [dbae39115963f63be1befe407ff9ed8c1c4a9b62]

        no need to allocate ColumnSpanSet with unique_ptr
        
        Change-Id: If3aaa2a4bc556dad41f56054890dc07f96d42dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121651
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-05  Noel Grandin  <noelgrandin@gmail.com>  [8a60780dddf4a2d043b7152514f251d480f3be7e]

        no need to pass EditSelection around with unique_ptr
        
        Change-Id: I4c55bfd68f35fb0a559d6a3ba3d860445fc7242f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [24edba599a71da5cec504bdeb595ee1edfd9a4da]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Idb3fdf49deb35d99284a25957892df0c761ed515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121670
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [052afc10c565940fa947e56c49e132aeb94ae03c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib63d500480a78a144b127c4230542507132d0a5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [08665e27e1d66cde90bac978eed4cee998b1d5d5]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iad99d728cea33e8a3b81ccd654258bddd3f96a13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121668
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [ce0229a9a5cb9c375c64dc4bc2bfafb5446f57c4]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Icbb4187ecc3cbb371fa7c2e6003b920be287ec6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Roman Kuznetsov  <antilibreoffice@gmail.com>  [603e34734136340e506e8f88072a30e13707d3f3]

        tdf#140725 Change a tooltip for Slide Master name field in status bar
        
        Change-Id: If54311379637ff0485477bcbb2d2d8c2d079ce7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121560
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [eca3b403293a2feb874acd7e38a79f2b60d0d266]

        ofz: Timeout, break earlier on stream failure
        
        Change-Id: If6612493224be5daa06288773c0aa1d22414c738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121654
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [c52defd21c16f2438aed56ff62652a4883682ef0]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5222e0c116d7f828539af84321dd30a71c2e14a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [6eaea5681f3332ba9557a68aa4d2089ed3fd28ce]

        move variables to where they are used
        
        Change-Id: If341e4f6cf1e83a9f28c273fee280edfc11d8a1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121658
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [af98d6ac8cd44b2a5bdb6a906eba9c7f73362f62]

        fix indent
        
        Change-Id: I04033ec4c95a352c0662e445a0d207d514696041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121657
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [fcb7a5c2781d7202f1a680ea4d6cc396ccc52262]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Icd01771dfa1ae7db94851d888ae3ce657313c67a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121656
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [740190b972c6f078f8efa1b80f2646b90b7986e6]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib8b337609afa4f588878a1e08eb74fca28fc0534
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Caolán McNamara  <caolanm@redhat.com>  [1caa289a9b7ed54b01b7a425f6e40578d9184cb1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8d35240e1fe68e364016ca46342f74c43aefb876
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121648
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-05  Mike Kaganski  <mike.kaganski@collabora.com>  [b96e84528153b8b613003a040e90acf4f5abe0f4]

        m_pInSqlda is not needed in prepareAndDescribeStatement
        
        As described in Isc_dsql_prepare [1] and Isc_dsql_describe [2] docs,
        these two take and fill a pointer to XSQLDA used for output. Only
        Isc_dsql_describe_bind [3] fills the structure used for input.
        
        Additionally, since Isc_dsql_prepare already does the necessary
        initialization, Isc_dsql_describe is documented to be not needed
        unless there is an indication that there is insufficient room in
        the output XSQLDA. Hence the change allows to avoid one redundant
        call.
        
        [1] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_prepare()
        [2] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_describe()
        [3] https://docwiki.embarcadero.com/InterBase/2020/en/Isc_dsql_describe_bind()
        
        Change-Id: Ia8ba09f079fa949e53a174f551fca6653852d31e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121563
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-05  Noel Grandin  <noelgrandin@gmail.com>  [b10bd75c9d1125ab51856b174e4052cbcd933774]

        no need to allocate NamePropsType with unique_ptr
        
        Change-Id: Ib042c481d682467620ae72a0b7e0bb2a5c8bf6ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121649
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-05  Aron Budea  <aron.budea@collabora.com>  [c36da188cc7c9d89c331deb6326f045b6e9f0ad9]

        tdf#144304 Fix crashes from "speedup dynamic_cast to SwTextFrame"
        
        Also preemptively adjust cases where FindNextCnt(true) or
        FindPrevCnt() can be null.
        
        Regressions from 426930d0c4bd6f782a04a92e8a36e92cd65e186f.
        
        Change-Id: Idb91464ecd285f6f5cf2e399c00faa2dfbbd5601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121662
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-05  Julien Nabet  <serval2412@yahoo.fr>  [37357e3cae749c54f1b9645c6670240baf860bc4]

        tdf#105689: fix path management to retrieve Emoji toolbar button
        
        On Windows console logs show:
        warn:sfx:7060:6444:sfx2/source/control/emojiview.cxx:105: Emoji config data is empty
        
        Change-Id: I85baf2fedc20ff855183147e9a178bb048ac75ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121653
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-05  Julien Nabet  <serval2412@yahoo.fr>  [c76e58ddb62c37a4091b37444939c471f9bab66f]

        Simplify a bit nOldROP management (emfio/wmfreader)
        
        Change-Id: Ia50f9def88e8435fb5ce3267cbd3fdfcaa72ef4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121646
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-05  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [180255b8fea029ac4a62b2e211afda8e52e053c1]

        Sukapura: tdf#144303 add cross cursor
        
        Change-Id: I944fff19d88b77720b363d87f4237503ae609384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121659
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-05  Chris Sherlock  <chris.sherlock79@gmail.com>  [dca138469467a7935550cf1af34b630b3dd7fd60]

        vcl: unit tests for Bitmap::Crop() and Bitmap::GetDownsampledBitmap()
        
        Bitmap::Crop() test:
        
        - If crop rectangle is fully outside of the bitmap, then return false
          and don't change the bitmap.
        - If crop rectangle is same size as bitmap, then return false
        - If crop rectangle is larger than the bitmap, then return false
        - If crop rectangle partially overlaps the bitmap, return true and crop
          the bitmap
        - If crop rectangle is fully within the bitmap, then return true and
          crop the bitmap
        
        Bitmap::GetDownsampledBitmap() tested to check when empty or not.
        
        Change-Id: Id2a6f739fdb1961748ce218862e628dfa8512122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121546
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-05  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [567aa49969e0e947f109e465c2006fa8451d7a58]

        Colibre: tdf#133038 remove remaining Catalan locale icons
        
        Change-Id: I12bcc32ff5500bf565bd076c2db803ff442519fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121660
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-04  Julien Nabet  <serval2412@yahoo.fr>  [0244dcf1725aafafc7d37f729a74b9e4b2d4ed8d]

        Fix assert in sc/undoblk3
        
        since:
        commit 0abf2ac27859f1e91a3d183b81948b1fe8f5aca3
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Wed Sep 16 11:25:25 2020 +0100
        
            AppendContentsIfInRefDoc never passed a null ScDocument*
        
            Change-Id: Ia21f8fecdf8a6aea7ea9c6ea4d579c5e53882bbd
            Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102982
            Tested-by: Caolán McNamara <caolanm@redhat.com>
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        
        Change-Id: Id699c7be3a81b251541f9a46fd3e1149c47f5df9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b3e4ee97af23f210fa39f1af3ddf1de63291371]

        speed up scanning the LOK queue
        
        we frequently scan the queue to caolesce events.
        Most of the time we are scanning based on the event type.
        So split the queue data into a compact queue that only contains the
        type, and another queue for the rest of the data.
        That makes the scanning __much__ more cache-friendly.
        
        Change-Id: I92d0b95611cd139cac8532f9297eaabda71d5fe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119996
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit acf9cf33d53e4bf598ddbdab102bfbd6bb14f8a3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121558
        Tested-by: Jenkins

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [73c5ff374629f3e6bb92fcd52ab8597d52c67af9]

        inline ScTokenArray into ScFormulaCellGroup
        
        Change-Id: I3a12566141b3243142c5e30381ac5eb3ba9c493a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121645
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [b68e82b17998ff7ce7e5b08419ecad6b54153566]

        no need to allocate RangeListType with unique_ptr
        
        Change-Id: I18681749501bb6750912c79b9ff04f5ffc4f0364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121644
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [9484b56401b6f544eabb3ab9f91d9fecf95242e1]

        flatten ScFormulaCellGroup
        
        Change-Id: Ie33a6de78bd120f143da35ffc26af94178c734c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Julien Nabet  <serval2412@yahoo.fr>  [da4c16ec008d0b21817be46396a5e5b3b509c637]

        duplicate modules/scalc/ui/ttestdialog.ui test in vcl/jsdialog/enabled.cxx
        
        Change-Id: Ic8e7ebb59cace56fdd8202b7d1c7eec7f62368a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121639
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-09-04  Caolán McNamara  <caolanm@redhat.com>  [aa07e8267d28b5d57df655f373d2bb585672bf3a]

        cid#1490901 silence Out-of-bounds read
        
        Change-Id: I4757413c80f6dc71d40c5c5525c484a54b71f676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [bcd823d31f7a2c670db81988e527d5c9682fe177]

        Sukapura:^ Superscript, Subscript, Clear Direct Formatting, Font Color
        
        Change-Id: Id2fb746dd33eb7de24539c7931221c331e47c087
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121628
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [41a46a306f40a7296c56bdeea0ba8a6d630aa15c]

        dynamic_cast -> static_cast (tdf#130795)
        
        the dynamic_cast is hot here,
        and none of these dynamic_casts are necessary, we already assert that
        they must succeed, so just use static_cast
        
        Change-Id: I88ade90431c4da4792c778b5cdab22332ed1c428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121637
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Jan-Marek Glogowski  <glogow@fbihome.de>  [50238bddf0e95169007cb90479cca86849a19007]

        tdf#144289 invert / disable default OpenGL support
        
        ... and as a result drop setting a default in SalSvpInstance.
        
        This is also more consistent: now you must explicitly implement
        CreateOpenGLContext() and set "m_bSupportsOpenGL = true".
        
        Change-Id: I591580bf134907213b8308e0843c278d2f470ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [55c676623310ab8a44e426186f4339f6efd118dd]

        no need to allocate ScMyLabelRange with unique_ptr
        
        Change-Id: I67b7b865d3c48e31e5efff5151c516ca7c51fd27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121624
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [45b17d9d5bf98aefba392da6271c7077c1363238]

        store ScTokenArray by value in SharedFormulaBuffer
        
        Change-Id: Ibff3c2fea3cadc234266953ab15ae5f25c4ac1e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121626
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [10d86d8526126956758501604f1bd2e3fe102076]

        no need to allocate ScMyNamedExpression with unique_ptr
        
        Change-Id: I853aee13d3afc25e7e1ec1aa0d1a41dba7de0fb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121623
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [5f0a01ce47133de31a7f8e43d8ef5e9851a7ceb7]

        no need to allocate ScMyImportValidations with unique_ptr
        
        Change-Id: I1f720b05834f24e395456d4e82cdf772242be7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121622
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [fd24739199fc1d5d3a0487886735737461fb5328]

        no need to allocate ScMyLabelRanges with unique_ptr
        
        Change-Id: I87564621a24737df74ad7475910250fde8dbe4fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121621
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noelgrandin@gmail.com>  [dc9f3e074b7139382500be0887caceffb646eed8]

        no need to allocate ScMyNamedExpressions with unique_ptr
        
        Change-Id: Ib82404230a0da4865c8c83087bca255811a89ed7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd10990aeb7ae2c3afb0c06a3d7b120101cd93c0]

        tdf#144193 fix import crash
        
        regression from
            commit 426930d0c4bd6f782a04a92e8a36e92cd65e186f
            speedup dynamic_cast to SwTextFrame
        
        Change-Id: If602b7166287edfe9a41ac662f1a0b03f283ca83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Caolán McNamara  <caolanm@redhat.com>  [2c4df704fa24ad04d042722e8d02fec4a5cd1def]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I53383a71b4a362409773f8f1123982e8d2c5a324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [21c3894c5cc30e511429df89edd59f413d93550a]

        Colibre: tdf#142295 clear up unsaved state icons
        
        Change-Id: I972f73dc35eda328663cdbfe1861110b4f69f8f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121630
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-04  Caolán McNamara  <caolanm@redhat.com>  [afe9c271859254025cc06f26cd565232025dbc73]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id576a38ed93b3ac0c3d1e886b65c7c13ced129aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121629
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [033b4183b33eb83fc8cd0176e6072e6805c96efc]

        Sukapura: update cell alignment icons
        
        Change-Id: I25a05a2d11e22ac1df1dcce496277ac0c872931a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121625
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-04  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [395e4a245d4236510178f352a63518f7061365e9]

        Sukapura: update checked mark icons
        
        Change-Id: I6e1f148d6fd1b6a993f6badaa6f1d27e93dac174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121619
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4dc6b5cfdb02ad00a06ad32650948648abe010d]

        use std::vector for fetching DX array data
        
        because I'm trying to track down a related heap corruption, and that is
        much easier if the access to the array is checked by the std::vector
        debug runtime
        
        Change-Id: Ia665f5cebb7f14d88942e88b4b400ad3c28ef5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121527
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [86fa9c907387e96c9c93f1e17239730271fedbfd]

        fix comment left behind
        
        in commit e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3
           use a dummy clipboard when running unit tests
        
        Change-Id: If5f57d1777dddbd70771299c8e161b33da10711d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121600
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-04  Chris Sherlock  <chris.sherlock79@gmail.com>  [5f50890d06a411323e5e60098901be4911ef1356]

        vcl: Add unit test for SetRefPoint(), IsRefPoint() and GetRefPoint()
        
        Change-Id: I4fbc85015326b03fba15daf73176826669a16210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121017
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-04  Alain Romedenne  <alain.romedenne@libreoffice.org>  [94c7e6bb3daa60757a982b92d765ee6b0d07fe30]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd31d03c6aa4b3e8422b03b9947f96b36fc30c61
          - Fix in Basic macro example
            
            Change-Id: Ia73865f59fc5b605853b5c1ff6232349fd186771
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121456
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [b9a3ab00dfe64c7bb19277dbad3545b83aacdc21]

        tdf#142458 Set correct ScrolledWindow BorderWidth in the ctor
        
        and keep it updated when the relevant properties that affect it change.
        This avoids the problem that the borderwidth can change during "Paint"
        (which is something we strongly want to avoid) since...
        
        since:
        
        commit f39f21d92ec83c3a5062f29dd26214fc83012c06
        Date:   Thu Nov 19 11:51:13 2020 +0100
        
            tdf#138010 (IV) VclScrolledWindow: Use actual border width
        
        hopefully after this we can then double-check to see if we can remove
        the potential change of BorderWidth during paint.
        
        Change-Id: I2ec317d86687fdb75e6323905f6d1c3b8fc655e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121615
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [1bfcb00aeb23efddf500e6623d36c0f816f4d2e1]

        pull duplicate field out of GlyphItem
        
        we already store it in SalLayoutGlyphsImpl
        
        Change-Id: I772c08966572e42789bcede1a148b2b7710f29d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121602
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [74260098ffcc14b4991ff424f5326a62bc003399]

        log PATH length and content when complaining about it
        
        Change-Id: I54495044f2bd487eb9315c7a974b9859b26235a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121588
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [fa387c3a99ebd033586b6f0a45276016dda56b45]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6bafceac5ebd1852aaf296abe89b49b74ad884d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [e44c97e8a8a403b8bd1e0c3e5943ebe19dec56fe]

        cgm bounding box was originally Point and Size
        
        so keep it like that
        
        Change-Id: I0392f283b79174c831d29b1895817cf6ee35ba3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [e561b8a2a2369c11c7d9ed2e82631d291c76c77d]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I95e6cb59a1f379dccd844f05648ba3652f3cb82c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121594
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [84fec37cb37371495ec540f877a7394e1300e006]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I1bd251165fb428f560a6844951e28109febeee7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [c532ee59d1fef349fc1b5afc86cfa212e9976697]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6180ebe39cb5925882071892611dd6237b426fcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121609
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [ebebb531778f57ff0fe8435023326bdc8c4ddc4b]

        pack GlyphItem struct
        
        56 bytes -> 48 bytes
        
        Change-Id: I30d9763162b701e3d07a153deae3f5e03c290393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121583
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [95dea4ab712516e4cb51dc18be9031548460a81a]

        rename NeedFallback to AddFallbackRun
        
        Change-Id: I5d91e7b28075026198444036fbfc220296deac77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2edef8b437d0d885708c7d7f6a8da07b2f1f225]

        rename NeedFallback to HasFallbackRun
        
        Change-Id: Iec45f84b330fc4e4a62b352cb007747a19a27bed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121578
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Miklos Vajna  <vmiklos@collabora.com>  [889014c9b86f35048bc00ae97c3ccba6f6989417]

        sw: fix crash in SwView::Execute()
        
        Crashreport:
        
        	program/../program/libswlo.so
        		SwView::Execute(SfxRequest&)
        			sw/source/uibase/uiview/view2.cxx:1312
        	program/libmergedlo.so
        		SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool)
        			sfx2/source/control/dispatch.cxx:263
        	/opt/collaboraoffice6.4/program/libmergedlo.so
        		SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode)
        			sfx2/source/control/dispatch.cxx:760 (discriminator 3)
        	/opt/collaboraoffice6.4/program/libmergedlo.so
        		SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short)
        			sfx2/source/control/dispatch.cxx:819
        
        Change-Id: I2e7b27f458971dbd33971589f71337c59981ee83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121611
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-03  Miklos Vajna  <vmiklos@collabora.com>  [f38406ba7905678a1cb703b8ff177e5f5008d3ee]

        tdf#62032 ODT export: handle style:list-level="..." for para styles
        
        ODT import was already working. The spec also says to only take this
        into account when applying the style, so it seems only the UI remains
        for the bug to be closed, the rest is done.
        
        Change-Id: I27da4dc171b4ced75f143bbcecb3f8c748a26b02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121607
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [cac7c02f52204eb3cea0a8594ed2d2c9313d4ede]

        remove debugging leftover
        
        from commit 8a54339fc83fe9abaaace6f9f374697e6923d684
            loplugin:referencecasting look through more clang Types
        
        Change-Id: I6a8a4bbce04d6f53d8e02961c0917bb57fb69a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121601
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [9e3cacbe9616a14e1df66c31485e3bcbfdc8fd01]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b8c44b49d1f732e51673804c28a8b606596630b
          - Create guide about Calc macros to format cell borders
            
            This patch is a follow-up to a previous revert:
            https://gerrit.libreoffice.org/c/help/+/121554
            
            This patch uses the correct path for the new file "calc_borders.xhp".
            
            Change-Id: I4eb72db1ef8f5d964905be46dcb645dbd4e28e67
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121556
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  László Németh  <nemeth@numbertext.org>  [1c0965148edb2a053e8e4a6762d917326fc332a2]

        tdf#143215 sw: test tracked deletion of empty table rows
        
        Only the test document was added to the previous fix.
        
        Follow-up of commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
        "tdf#143215 DOCX import: fix tracked empty row insertion/deletion".
        
        Change-Id: If39da56e16e56a9322a35259f5984726abe0da40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121549
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-03  homeboy445  <akshitsan13@gmail.com>  [a979f18254749acac4c71596c30dde9ad2908455]

        backendtest: Rectangle on wide surfaces Drawing test
        
        This tests draws a rectangle using all possible drawing
        methods for drawing a rectangle on a wide surface(1028x1028 and 4096x4096)
        and check it the usual way.
        
        Change-Id: I6fcf9c9b4b150cbe959b8151f327bcdce1b1139a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119464
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [e2dc002db806d76288c79c9acc30911456138289]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6546ef38c6e84193c00ea5fcac621fdec93e0ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121593
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [aeccf731466bc44ce750bbeb8a86ccf309a12027]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I626eb1847484f7bc6af7eed45b891307718c5263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [fae7e172e2f7585ed633c9c6328fd25e2f5dd6df]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I47934f5a6b34ef0f495098f78c53c088bf5152e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Hossein  <hossein@libreoffice.org>  [3b6b93e40e079d0fc93c68fbb28da0be696c2566]

        Fixing Unicode Arabic Literals
        
        Some Unicode literals are now available inside the LibreOffice code,
        so I think we can use Arabic Unicode literals directly inside
        LibreOffice code. It is more intuitive, and gives better insight to
        those who develop to understand what a foreign language script should
        look like.
        
        This patch consists of two things: First, converting a Unicode literal
        that was consisting of \uxxxx characters into an Arabic Unicode
        literal; Second, fixing an Arabic literal that was converted to shaped
        characters instead of normal Arabic characters.
        
        Change-Id: I11003cc471b2c83098cb0ebc4f4085771a132ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121164
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [5dff497309fe6034318c75efd40bb480e34f331a]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3a45c8141b9f824c985dcf1aaac5d1aa45c0f70d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121575
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [5efd4c0a78633da563468f60c36c34a375584393]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6cd0e9b518bf6f40e0221fd2e9f3c5fb6199e14f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121574
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [aa9e05236b73067e34d34d9861fc394ba854399b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9f67d463958e3b3ce88b771dd8ca0f71f7393e32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121537
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [e4b1ba9447a0a56aa56400f9f44d8eecb6c11e9c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib703febb7e632ec4ae18756065a1c60ffc75569e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121590
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [00abfe06caa489559cbda0db082f5e118a324f6c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3ea65a72567e934325e24ff658fc1b9c0468abcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121591
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [c4bc47a972383e6adc99ad1257c7a8ba207c57ba]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ibd35c1aee4324620fb7ae17e20027057f1934c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Jean-Pierre Ledure  <jp@ledure.be>  [552a1f30eca91eb647d10d77135b32a5729f11bd]

        ScriptForge - add AddTextsFromDialog and GetTextsFromL10N methods
        
        The objective is to facilitate the automatic translation of
        all fixed texts in dialogs and dialog controls.
        
        Concerned items are:
        - the title of the dialog
        - the caption associated with next control types:
          Button, CheckBox, FixedLine, FixedText, GroupBox and RadioButton
        - the content of list- and comboboxes
        - the tip- or helptext displayed when the mouse is hovering the
          control
        
        ScriptForge.SF_L10N.AddTextsFromDialog(dialog)
          store all fixed texts of the dialog in the list of translatable
          strings of a L10N object to prepare a POT file
        
        SFDialogs.Dialog.GetTextsFromL10N(l10n)
          get the translated versions of all fixed texts in the dialog from
          a L10N object and apply them on the dialog before display
        
        Both methods are executable from Basic and Python user scripts
        
        Change-Id: I3dc9fbbce287d7af4040df713f9d11e0ff928b1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121514
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-09-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [66402b476da8bcbd87f9dd7d7410ee48bfdeeadc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 844431301fc078c697a22b332531369caa00612b
          - Revert "Create guide about Calc macros to format cell borders"
            
            This reverts commit ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3.
            
            Reason for revert: new file in wrong position
            
            Change-Id: Icebc9502ad250493c704d309eefeb388f6118c11
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121554
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [3959e3b76fd03734153666299bad40995fa55f30]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ce0d3ff57a732b1f89f88b5f0c4cbb22e0d050c3
          - Create guide about Calc macros to format cell borders
            
            Change-Id: Ia7bbbf25322775e3a291fcb474079b2e2bc4e41e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121461
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [ba5efc928a3842dfdc115bc6018f00349e9573c7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5dd44ff1d347e6aea29315d4acd1f42ad08d2d4a
          - tdf#125244 Fix instructions about Trend Lines in charts
            
            In the past it was possible to add trend lines for all data series at once. However this behavior changed and documentation had not been updated.
            
            Change-Id: I8c0e93a4d8e35aadc5e2454d49adff572fdf3028
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121552
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [cfeb08efc9cdd74487917078223d208fbf7869c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff74220156e7dbf65d27d43759922c64130ee66b
          - tdf#121613 Add information about Adjacent Cells
            
            Change-Id: Ia16b0dd8c1cd7ae157b16c180fcd6737f58e7f4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121415
            Tested-by: Jenkins
            Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [104847ed014e95a915d314de7091c7d572eade67]

        simplify ApplyDXArray method params
        
        pass only the required data to it
        
        Change-Id: I849780371b71d3620dc36681453f5dbe1527b7bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121577
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Mike Kaganski  <mike.kaganski@collabora.com>  [6eee0843d4b354b849a21e6cb0978936d5f4dd01]

        No need to check DBGUTIL specially
        
        ... as discussed in comments to
        https://gerrit.libreoffice.org/c/core/+/121470
        
        Change-Id: I9be45e2157972156ab7c2aac820b69aa894cacfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121553
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [ba346227f1c4f896b717676a7eae22fea222f3e4]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: If1db8debe4f3b3dc6a8890b03ee8d2d70cc63a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121572
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [6cc1ee903544ed813402303e93753dac8226984f]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: Iede70151af052505b780c6ce708aa74d97da5c75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121545
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [65d4320110d3f6ab9242389fdc8d392de13cbb74]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I00531cdb266c4277af742cee6ce5d05f0ea3334e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121523
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [27b84d7460cbb925429826d20c4cee5439ad7053]

        cid#1490898 Unchecked return value
        
        Change-Id: I49124165e0d00d84f3ebdb0414d6db58f6da1209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [6c0c3bd74e0d94f48feda9bd7663bb9b5d9fc320]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ie4fe1a4d346d3b790349132460b9efcc448d0eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121551
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [b6e5aca3b35df4b0fd05f449435bb69bd0cea164]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I71d3b07c7ca2467b7bc1db5350dbdeb1f8910cb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [c06bc8cf1b3e1057eb846605b61570bb1f3713da]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6a8dd39528038fbcc496e56d6fcefc4ec8db68cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121536
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Heiko Tietze  <tietze.heiko@gmail.com>  [ef3dd0e04e734974ff9a6b7f30d0377ecd952842]

        Resolves tdf#120333 - Access to color palettes via tight extensions
        
        Change-Id: I3311115854a29eaddf76b847642250626b7032ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121498
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-03  Ilhan Yesil  <ilhanyesil@gmx.de>  [e72a7368b368a822d2400ee7db60312226ad3195]

        tdf#131548 Android: jump to cell
        
        Added LOK_CALLBACK_SC_FOLLOW_JUMP: fire this signal to jump to cell
        cursor in android viewer. Payload format same as
        LOK_CALLBACK_INVALIDATE_TILES.
        
        Change-Id: Ic896baccf1327d6ccdf104811446e3454a42679e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116448
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [7e48bcea73a8eceacd708cb7fdeb66264eb602d6]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I47cc5416e853260d92b8b2c57b1c223d1f21df0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f35b9909070919013a753c382bff52614403c7a2]

        indexing: add indexing xml as a format for writer
        
        Needed so we can run "convert-to" service with COOL to produce
        indexing XML documents.
        
        Change-Id: Iabb77bd562a3307d0d20769a77f069e5250028ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121540
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-03  Noel Grandin  <noelgrandin@gmail.com>  [a9a648fbf47f94151de0d525e432b45919ba7504]

        no need to allocate SeriesMinMaxType separately
        
        Change-Id: I7121375a6bf731f8d30f69aa8c90b102675a8bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [925d26257f0dac02ba5f2c684394d21e60c76fff]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ifbbfc5ea8d53fc81b22e9104cd6aea10aad12583
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [d260e5ee47d3a689ad72e274874c68e61dfd65e7]

        cid#1490899 Unchecked return value
        
        presumably we don't care about the ret value here
        
        Change-Id: I0600838fa4c50901b24dcb63d2a304a8894e6701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [c420019beadb25e3036b669562bd7ece58ecf970]

        check stream state
        
        Change-Id: Id096abd3dee2584a3afa01d7ce005ed74a224a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121495
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [05335fa0ca398b92726d5e892cc1fb156f43a014]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3eaf680052ada10b6a6e8fded6e806d6045d0fac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [2d8f0a9b1ba69e75c517252f8b72143f99570010]

        drop SwDocTest::randomTest
        
        it fails sometimes, we have a bug there of some kind, no one has fixed
        it yet in all this time and causing failures on unrelated changes isn't
        getting us anywhere
        
        warn:sw:7502:7502:sw/source/core/doc/DocumentRedlineManager.cxx:109: redline table corrupted: overlapping redlines
        cppunittester: sw/source/core/doc/DocumentRedlineManager.cxx:112:
          void (anonymous namespace)::lcl_CheckRedline(IDocumentRedlineAccess &):
          Assertion `std::is_sorted(rTable.begin(), rTable.end(), CompareSwRedlineTable())' failed.
        
        Change-Id: I90fe4b4e323a8c00285eab6739af5a6e1ece3838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121535
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Caolán McNamara  <caolanm@redhat.com>  [ce20a690c8e72b0d15ca5cfdc2241a7076dd8124]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7cd46af148471de516860046c04f71b6ae5fea89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121522
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [58364e04cc4c5451af2086bdb01145ec89da2b8e]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I6a2a36c28fafac7002fbe093b22ad186562ea5c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Hossein  <hossein@libreoffice.org>  [d25906087918c085239aac30fd72cb65aa7b9eb4]

        tdf#88163 Fix WMF font size
        
        The problems in tdf#88163 can be categorized into two parts:
        
        1. A regression which is caused by the commit
        a9020e461803964a206d5551884b70717eed165c. The font size for text is
        wrongly calculated for wmf files WITHOUT the placeable header.
        
        2. A long-lasting bug that has existed from LO 3.5 (tested with
        various LibreOffice versions from 3.5 to master). The font size for
        text is wrongly calculated for wmf files WITH the placeable header.
        
        This patch solves the first part. In this patch the way wmf is scaled
        is changed using mnUnitsPerInch as a variable that controls the scale.
        The previous method was dividing the left/right/top/bottom fields of
        aPlaceableBound which caused the bad scaling of text.
        
        The second problem still remains, and possibly can be solved by usign
        the old scaling method that was previously used here (dividing pos
        values of aPlaceableBound), but the scaling factor should be
        calculated, which varies in different wmf files. More study should be
        done to solve this part.
        
        Values used for the example "visio_import_source.wmf" used in the test
        WmfTest::testNonPlaceableWmf() are slightly changed, but the rendering
        should not noticeably change, except the fix for the text font size.
        
        A new test WmfTest::testTdf88163NonPlaceableWmf() is added which
        checks for both font height and text boxes' positions. Font height
        can depend on the exact font that is used for Roman in the platform,
        so it vary between Linux, Windows and macOS. Thus, a range is used
        for ensuring that the font height is correct.
        
        By visual inspection, it is confirmed that this fix does not affect
        fdo#74336 and the fix for it still works for attachment 93188.
        
        Change-Id: I55bf38ba4345a0aa48c3e522976a2a5c32f7ec8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121272
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [9e7f07dc1378354a5228898e339f8336bbbb41f3]

        tdf#144155: Revert "tdf#36383 sc AutoFilter: fix changing row height"
        
        This reverts commit 3678e0efcb8bedc58dd329a430da0ac3b1572df8.
        
        Conflicts: sc/qa/uitest/autofilter/tdf36383.py
        Change-Id: Ie1abd0cdea013571a27b187ffcb20125a0656442
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121512
        Reviewed-by: László Németh <nemeth@numbertext.org>
        Tested-by: Jenkins

2021-09-03  László Németh  <nemeth@numbertext.org>  [f3bec764ddbf3fd3ae986f034c89626bf22940e0]

        tdf144058 sw track changes: fix table deletion at paragraph join
        
        Tracked paragraph join by table deletion left empty
        table in the text after accepting the changes, caused
        by the non-continuous redline range over the table,
        related to the copying of the formatting of the first
        paragraph to the (wholly or partially) removed paragraphs.
        Fixed by skipping paragraph format copying in the case
        of table paragraphs.
        
        Note: this is not enough for tables with inner redlines,
        where tracked paragraph join with deletion of such a table
        still leaves an empty table at the place of the table
        (a problem inherited from OOo).
        
        Regression from commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49
        "tdf#119571 change tracking: show layout changes at paragraph join".
        
        Change-Id: Ib3ff79c766b5e6faced796b9546d332bab4e0d94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121510
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-03  Miklos Vajna  <vmiklos@collabora.com>  [fafe4a9523566654f89c3e8ea0080452ce2b0ed3]

        Remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: I62354cf2ae750a91b72e91ad838a40e205e7cd61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121526
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-03  Noel Grandin  <noelgrandin@gmail.com>  [cbd005536189a6d0e7598bf06480042017fbaf32]

        no need to allocat PptFontEntityAtom separately here
        
        Change-Id: Id0b8c919bc35bb427a88c229d024a118437785f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Noel Grandin  <noelgrandin@gmail.com>  [d2ba1d72c047a31321cf4c510c8c4a729c3706e9]

        no need to allocate BSaveStruct separately
        
        Change-Id: Id14f525e84c22caa8f974f2f1d9f398f8d8e2df8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [46cafe6c7fb9b16bc508663d775fe90deccbf460]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95e6fe8d728b7981e4262e71646fd212da1775aa
          - tdf#63175 Fix description of Calc shortcut keys
            
            This patch adjust a few shortcut key descriptions and adds two new ones. Both shortcuts were reported by the user and they do work in LO 7.3.
            
            Change-Id: Iab697f5894ceb3bb6ff62c732139f2aff2ae9ec0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121471
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6770320ab102aeecb43b3f39edb900fd9d773ba8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc703be0b95314adcf7de4c1c4a5e6e0631c2a2e
          - Fix typo
            
            Change-Id: I75613efd4b08164a495c8a5110d3cea016bc05cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121541
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-03  Justin Luth  <justin_luth@sil.org>  [1a6530787579fe466a67a98ef1f1a2087715a1b2]

        related tdf#137363: no NUMBERING_LEVEL 9(no-level) in para
        
        Remove the (fake) 9 from the direct paragraph formatting.
        Otherwise when numbering is applied it will start at level
        10 instead of the proper level (as defined by the style).
        
        Change-Id: I26fdff36e4f3d3449a259918a7c57a76bae7d486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121503
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-03  Chris Sherlock  <chris.sherlock79@gmail.com>  [a01c60927c3cedf775d3ba66d3602988c274fb09]

        vcl: Migrate OutputDevice font functions to font.cxx
        
        Add unit tests for SetFont() and GetFont()
        
        Change-Id: I5b66cd5531aa0f9fd73357dd2a168d9c5b655b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121016
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-03  Mike Kaganski  <mike.kaganski@collabora.com>  [872b77f6e8997b663fd01c9df655cd35a31ce39e]

        Make sure to use debug options for firebird in debug mode
        
        Change-Id: I358bd2013387e9fb341d92764f29767d6c0c2cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121470
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [bc7baa18435000f47f90e47d3300710bcb4cf56b]

        ofz#38011 save and restore m_pLastAnchorPos via UnoCursor
        
        when we do some operations that may delete paragraphs
        
        Change-Id: I2165dd287771f06c6d0fd061dd7659b06db4bd72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Michael Weghorn  <m.weghorn@posteo.de>  [45e7e31f328ac572d4278ea94557d92cd99a1bd2]

        tdf#35129 a11y: Let SPINBUTTON have role SPIN_BOX, not PUSH_BUTTON
        
        Change-Id: I3aaac19890a356e930203ecdb003edfbfed1b52b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121516
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [bd8e2365937f0dc58563a3a09c15078b94cd4f5c]

        do the same check on the same code pattern as was done earlier
        
        in this same function
        
        Change-Id: I03a112e3e57549ec776e99a460544b575476528d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121496
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [d98aae68810a77df399decbe09ba70f99fdb7344]

        tdf#144209: sc_subsequent_filters_test2: Add unittest
        
        Change-Id: I00a0f1efad4d003c7213117ede7f14fbdcb2c00e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121509
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [0e05ce8b9377b90cda47a76a7d0cbd1d5c65c521]

        cid#1490900 Unchecked return value
        
        Change-Id: I22ab45d8e7bc72c3cf8cf8bb8ddbefef4250fdad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [9f51d973f65e85ab01e393fc0821a0b304efbae3]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ie666d56816b5af96590d482e2af204e0f6486bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [6d4b78f143f8bea59acd9c62a92effbe6dff0bdf]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5b06808b7b676b9e7cbcea2d9330431c82055d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121521
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  rafaelhlima  <rafael.palma.lima@gmail.com>  [8447f46372f48dc6d259340fafe00d39eabd64cc]

        tdf#136610 Add Clone/Clear Direct Format to other tabbed interfaces
        
        Change-Id: I4d009de786acd2a84f698b11eb48c52222f09c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120858
        Tested-by: Jenkins
        Tested-by: Andreas Kainz <kainz.a@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2021-09-02  Miklos Vajna  <vmiklos@collabora.com>  [6d9b61c22a5b4372bf5592556d21c8417ed22bfa]

        Related: tdf#137363 ODT import: handle style:list-level="..." for para styles
        
        This is just the import side, the export side still needs doing.
        
        The used attribute was already part of ODF, and NumberingLevel for para
        styles where already imported/exported for DOCX.
        
        Change-Id: I8385ed23dc799c99e81318387236341b404d01a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121515
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [40c760ff73d9713b11b6c6b124dc27f0da17daf3]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9284239851472d6776e80d9d9c283b7f45db13c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121499
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Alain Romedenne  <alain.romedenne@libreoffice.org>  [36ac73f5dc6a23c3275bbdb0a37f8fd98e416863]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6e00ebfc8b1fb0abb3a1f4a18cbf1177f0b92618
          - sf_platform.Printers new 7.3 property
            
            Change-Id: I44841d02698568e63791a2fdba480002caa03d4e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121468
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-09-02  Noel Grandin  <noelgrandin@gmail.com>  [c1c679deca078209bc3008ccd9ccc0a8715929a1]

        rename UpdateMode -> UpdateLayout in editeng class
        
        ... because "update" is such a generic term I keep forgetting what we
        are turning on and off
        
        Also return the previous value from SetUpdateLayout to
        make the save/restore code more compact.
        
        Change-Id: Iae1764c837a92e58c9b17521f130e8fc80311d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121479
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [58da51715425d781b5b8b9b9e412c98daf80b601]

        convert malloc/free to std::vector
        
        Change-Id: Icc9bb8cd6851ee027d5a5469c78d26cf6a943708
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [65ca2be823ce29d506e9c2cb5a42b611234194ac]

        move variables to where they're used
        
        Change-Id: Iaf7e7bf1a58aedb0ad6852812f969fc7e6153a54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121500
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [13263005dc415b29a82ad12d452c313439668c3d]

        vcl: make GetFillColor() and IsFillColor() inline class functions
        
        Change-Id: I5f80765658f1c1679f56df59d4b8212caa9d1357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121486
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Mike Kaganski  <mike.kaganski@collabora.com>  [846fcc03b89a7131f565de95396757c8e0da1dfd]

        Use utl::TempFile::EnableKillingFile
        
        Helps keep temp directory clean also on exceptions
        
        Change-Id: I81c17d90d6905653db946e68faf2a7f59c17da15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121466
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [34a9f93018804044b756e0e49c7ea759a65d3dc4]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I396b83c089fef3aeb7789c17a3013ce61691504e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121489
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [c085fc7cd335e3ea50a6bbaedf2f6e8cffadf559]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I827ddc6692280dbad44b03cfa07f1f35375080c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Heiko Tietze  <heiko.tietze@documentfoundation.org>  [f773e7aa8c96e070085ece95889f02590ed65f89]

        Resolves tdf#144227 - Default command to switch UI
        
        Remaining .uno:ToolbarMode replaced by .uno:ToolbarModeUI
        
        Change-Id: Ie5afaa997dabaca0feafde41355945460f1292f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121417
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1af7083b469eec48783b7a1aaff6d080901fc7f]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I39b9ac81d65f4a269293824642c1b2ec593c0584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121490
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [a8638dc41540e00c341a82c83e5a11fae5f74c20]

        unused defines
        
        Change-Id: I494e64c69decb9fb3d5b13ffc2f18d99f6b7749f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [776a1b9b6b9c574d28b3a321a0f3f8110f34ac90]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I0a9b238c0ba551b330bee7b89eb6cd48fad1b265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121488
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [d241107b21e5d2bef3cbc408b020a0c8567b9e15]

        loplugin:badstatics
        
        whitelist another that started showing up when I built clang from recent
        trunk
        
        Change-Id: I37cb3a430a72df7e39e1ef8a5cf5f51383b4eaf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121493
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [7d0d07ed0f572c99c70d7f4384dfce644cbbf939]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I2b33dd4893bb71bd7880e068d26ebe3d31d07ab1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121485
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [0c5d9b14a8dd313247e1ed6890bb8b7a3a829b22]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic592091450d596d505b7e802cb8560be2c01cb0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121451
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  dante  <dante19031999@gmail.com>  [0c022ac0911fa1cdfcc722c875c8898a9d41d75d]

        tdf#144189 Not Precedes (U+2280) and Not Succeeds (U+2281)
        
        Change-Id: Id2d619769012a1b26415656e7793a70c6b17c298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121482
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [08ccd6d3c45c108b5188e65d328cc23173139109]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I08bffde6c08d97d140e2985876a62084035d657f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Caolán McNamara  <caolanm@redhat.com>  [5a864ebb0e18565e33e677df7987a8f94a7742ea]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        bodge dodgy SetStreamSize for now
        
        Change-Id: I4f15a2f2e196eb7b4a22331e66966f242d8968c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121483
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-02  Miklos Vajna  <vmiklos@collabora.com>  [dcf7ce2bb67620defbfcb2a4e021cb4c92e27178]

        sw: handle mbPurgeOLE when replacing compat options
        
        This is only read in SwOLEObj::UnloadObject() and the flag was there
        already with the initial import. It has no UI, so probably it's a compat
        setting.
        
        Change-Id: If776f7f86d2d2ebbc7421855e032c316e8ecacc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121481
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-02  Justin Luth  <justin_luth@sil.org>  [b87c7eb674dfc4ee76fa48af67da6cb13a8d6aa6]

        tdf#137363 DOCX filter: no NUMBERING_LEVEL 9(no-level) in styles
        
        The only real (initial) reason for setting PROP_NUMBERING_LEVEL
        in the style was to round-trip it so it didn't get lost.
        It does kinda give a nice side benefit in UI, where the style
        can now set the listLevel at the same time as turning numbering on
        (at least on the second try.)
        
        However, 9 ends up meaning LEVEL 10 in LO UI, instead of NO LEVEL.
        So eliminate that value from round-trippability,
        since LO has no correlating NO LEVEL value possible for that PROP.
        
        The UI is too broken and inconsistent for any attempt
        at a unit test.
        
        Change-Id: Ibd9cea2ec10e85651f9f6643ad1b49ebf9babe12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121448
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [0dbe108ad80e30751be584ccb0e04bbcf35bdce1]

        vcl: test bitmap color when using DrawBitmap()
        
        Change-Id: I0c4f9517ca4573300b6ef9237ac9536f19523ab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121043
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [4422ddfb0a862595a6e12caba50b28408704ba1d]

        turn on symbols for jenkins windows builds
        
        so we get good stacktraces when something goes wrong
        
        Change-Id: I1e0832b3ab0bdbbf1a76533c37fbb0a8060a0166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121266
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-02  Stephan Bergmann  <sbergman@redhat.com>  [2b5dee8ee86cf92ed613a9cde61b0871f97e5b87]

        external/cairo: Avoid UBSan invalid-null-argument
        
        ...as seen during CppunitTest_sw_uiwriter4:
        
        > [_RUN_____] SwUiWriterTest4::testEmojiAutoCorrect
        cairo-surface.c:2852:28: runtime error: null pointer passed as argument 2, which is declared to never be null
        > /usr/include/string.h:44:28: note: nonnull attribute specified here
        >  #0 in _cairo_surface_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-surface.c:2852:9 (instdir/program/libcairo.so.2 +0x9ac09e)
        >  #1 in _cairo_gstate_show_text_glyphs at workdir/UnpackedTarball/cairo/src/cairo-gstate.c:2077:15 (instdir/program/libcairo.so.2 +0x65a4af)
        >  #2 in _cairo_default_context_glyphs at workdir/UnpackedTarball/cairo/src/cairo-default-context.c:1315:12 (instdir/program/libcairo.so.2 +0x62404f)
        >  #3 in cairo_show_glyphs at workdir/UnpackedTarball/cairo/src/cairo.c:3629:14 (instdir/program/libcairo.so.2 +0xa6c77f)
        >  #4 in CairoTextRender::DrawTextLayout(GenericSalLayout const&, SalGraphics const&) at vcl/unx/generic/gdi/cairotextrender.cxx:265:9 (instdir/program/libvcllo.so +0xae46aa3)
        
        Change-Id: Ifa22046bb35a872c4db38130a7ae4c9b758ccbc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121473
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-09-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a5bb0e66492118b79da5fef31f8d2bd686947354]

        tdf#144172: patch FB to use per-process LOCK directories
        
        As discussed at https://github.com/FirebirdSQL/firebird/pull/6937:
        
        > > But as well, we may just use process id instead of session id in
        > > the ConfigStorage::ConfigStorage creating filename. That would be
        > > even better, fitting better into our per-process temp dir policy.
        > I tend to agree with you here. It looks safe assuming LO uses
        > SuperServer only.
        
        Let's not replace the session id with process id, but instead append
        process id after session id, to avoid (unlikely?) accidental overlap
        of process id and session id, which would produce the same name as
        already used by, say, isql tool.
        
        Change-Id: Ibce8a8c75d405aae3e8949e7daf2476accdff22b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121457
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [7ded01efaec8171a204a255395767432bab881b5]

        vcl: move OutputDevice line functions to line.cxx
        
        Add unit tests for SetLineColor(), IsLineColor() and GetLineColor()
        
        Change-Id: I54a6e191f9c821c258527ebf075d88ff60cc9471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121015
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Mike Kaganski  <mike.kaganski@collabora.com>  [2e5dad443a30055d93dbcb3bf9cac906e80b2e25]

        tdf#144230: sanitize string length embedded in SQL_VARYING data
        
        It is unclear why the length may be wrong; but at least be safe to
        avoid buffer overruns.
        
        Wrt the validity of sqllen here: see SQLDAMetadata::scatterData in
        firebird's src/yvalve/why.cpp.
        
        Change-Id: Icc24c1cc0db66c20732188ab0621cde53c1ba5c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121458
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-02  Chris Sherlock  <chris.sherlock79@gmail.com>  [368e21fbc34fa4104f16498a54ab77704f39e6b4]

        tdf#74702 vcl: make helper funcs for ImplDrawWaveLine() and ImplDrawWavePixel()
        
        Unit tests written for Printer and OutputDevice, note that I might have
        uncovered a bug.
        
        Change-Id: Ic8e6e02ce0df349fc6fb6a3334105c1e6dfa3f36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113563
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-09-02  Luboš Luňák  <l.lunak@collabora.com>  [11b954e4f92da7620ba2dc89430fa09d3946f780]

        Revert "make Skia the default now on Mac too" (tdf#144214)
        
        It turns out HiDPI needs special handling, and I didn't get it right, and can't find a way to set up that mode here, so I can't test. Revert the default for now until this gets sorted out.
        
        This reverts commit 2489edcbe0f5dc77649fc2e801c1bbffb71692b8.
        
        Change-Id: I6d2f09a81c1ffa1537183a834f242c4f8b29aa4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121423
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [e29f80efc826fdc8a8e4b7cbdd3becf2f074cce4]

        tdf#135588 wina11y: Map AccessibleRole::STATIC to ROLE_SYSTEM_STATICTEXT
        
        This looks like a better match to me than the previously used
        'IA2_ROLE_TEXT_FRAME' and the NVDA screen reader
        reads the text of child objects of 'ROLE_SYSTEM_STATICTEXT'
        when announcing their parent objects if they have a specific
        role (e.g. 'ROLE_SYSTEM_PANE' or 'ROLE_SYSTEM_GROUPING').
        
        Description for 'ROLE_SYSTEM_STATICTEXT' from [1]:
        
        > The object represents read-only text, such as labels for other controls
        > or instructions in a dialog box. Static text cannot be modified or
        > selected.
        
        Description for 'IA2_ROLE_TEXT_FRAME' from [2]:
        
        > Collection of objects that constitute a logical text entity.
        
        With this and an additional change to make the NVDA screen reader
        speak the children of a VclBox, NVDA reads the complete text of
        MessageDialogs as they are shown, rather than just the dialog title.
        ('AccessibleRole::STATIC' is used for the readonly VCLMultiLineEdits
        in a MessageDialog, s. 'VCLXAccessibleEdit::implGetAccessibleRole'.)
        
        The additional change needed to fix tdf#135588 when using NVDA on Windows
        is to make sure that 'AccessibleRole::PANEL'
        (used for a VclBox on Windows, s.
        
            commit 685ec1899435037205d98a102a32ca8b6a4836d0
            Date:   Mon Feb 17 16:57:44 2014 +0000
        
                Related: fdo#74284 try AccessibleRole::PANEL for VclBoxes under windows
        
                Change-Id: Ic8c743c2646c8610b3d90425024413b40dfdab13
        
        and additional information in fdo#74284)
        is mapped to something for which NVDA descends into the children.
        
        Testing this by just changing the LibreOffice side can be done
        by adapting the mapping for 'AccessibleRole::PANEL' to
        'ROLE_SYSTEM_PANE' like this:
        
            diff --git a/winaccessibility/source/service/AccObject.cxx b/winaccessibility/source/service/AccObject.cxx
            index 9e3f7d063b3b..e0ae1e2dc03e 100644
            --- a/winaccessibility/source/service/AccObject.cxx
            +++ b/winaccessibility/source/service/AccObject.cxx
            @@ -98,7 +98,7 @@ const short ROLE_TABLE[][2] =
                     {OPTION_PANE ,             IA2_ROLE_OPTION_PANE},
                     {PAGE_TAB,                 ROLE_SYSTEM_PAGETAB},
                     {PAGE_TAB_LIST,            ROLE_SYSTEM_PAGETABLIST},
            -        {PANEL,                    IA2_ROLE_OPTION_PANE},
            +        {PANEL,                    ROLE_SYSTEM_PANE},
                     {PARAGRAPH,                IA2_ROLE_PARAGRAPH},
                     {PASSWORD_TEXT,            ROLE_SYSTEM_TEXT},
                     {POPUP_MENU,               ROLE_SYSTEM_MENUPOPUP},
        
        Adapting NVDA as follows to handle 'controlTypes.ROLE_OPTIONPANE'
        accordingly might be a better approach, though:
        
            diff --git a/source/NVDAObjects/behaviors.py b/source/NVDAObjects/behaviors.py
            index e51f9e4a3..47389186e 100755
            --- a/source/NVDAObjects/behaviors.py
            +++ b/source/NVDAObjects/behaviors.py
            @@ -89,6 +89,7 @@ class Dialog(NVDAObject):
                                            continue
                                    #For particular objects, we want to descend in to them and get their children's message text
                                    if childRole in (
            +                                       controlTypes.ROLE_OPTIONPANE,^M
                                                    controlTypes.ROLE_PROPERTYPAGE,
                                                    controlTypes.ROLE_PANE,
                                                    controlTypes.ROLE_PANEL,
        
        I'll discuss that in the corresponding NVDA issue on GitHub: [3]
        
        [1] https://docs.microsoft.com/en-us/windows/win32/winauto/object-roles
        [2] https://accessibility.linuxfoundation.org/a11yspecs/ia2/archive/ia2-1.0.2/docs/html/_accessible_role_8idl.html#e37ff81431ee3762a5d41a2cb909108d73becd811853026681d0000b17da7862
        [3] https://github.com/nvaccess/nvda/issues/11687
        
        Change-Id: Ic49d49cfc2d5f01646086931f9f8a522c6f0d5fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121476
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-01  Michael Weghorn  <m.weghorn@posteo.de>  [8887979092c88139e4b950d1a75fc576853a2e2c]

        tdf#135588 a11y: Consider text as a11y name
        
        If no accessible name could be retrieved from
        a corresponding label or using the quick help text,
        take the actual text of the window into account
        for MULTILINEEDIT, etc.
        
        This e.g. uses the texts in message dialogs
        for the two VCLMultiLineEdits holding the primary
        and secondary message in a MessageDialog
        (s. vcl/inc/messagedialog.hxx).
        
        With this in place, Accerciser now shows
        the actual messages of the message dialog
        when using the qt5/kf5 VCL plugins instead of
        just empty strings, just as is the case for the native
        gtk3 variant or similar dialogs in other
        applications.
        With this on top of a WIP branch that makes
        Orca (more or less) speak for the qt5/kf5 VCL
        plugin, the whole text of the message dialog is now
        spoken as well. (Previously, only the title
        of the dialog was announced).
        
        More is needed for the case of using the NVDA screen reader on
        Windows (which is the original scope of tdf#135588).
        That will be handled separately.
        
        Change-Id: I182f3c96ce646a198b747ca8fb5c1cc1ff0d7f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121475
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-09-01  Eike Rathke  <erack@redhat.com>  [71b003a12f8afdff42a25786ad0a12ddd6609d59]

        Resolves: tdf#144209 Handle General containing formats in RoundValueAsShown()
        
        Calling SvNumberformat::GetThousandDivisorPrecision() for a
        
        "AA "General
        
        format resulted in 3000 as that was implemented for tdf#106253
        without taking into account that ImpSvNumberformatInfo::nThousand
        may be abused under some conditions, which here is having
        FLAG_STANDARD_IN_FORMAT = 1000 as nThousand, multiplied by 3 gives
        3000. Subtracted from the 0 precision gave -3000 decimals for
        which of course the new rounding produced 0 where it previously
        simply ignored the decimals and returned the original value.
        
        Change-Id: I66afaf1e2d8b2654d9f7cc8cfb66389357fb742d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121447
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [f560a3a296871084801ced75fae20fb5f1b5d7ce]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I481df54d421ad03813ba0755b735037e72d4c784
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121450
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Noel Grandin  <noel@peralex.com>  [e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3]

        use a dummy clipboard when running unit tests
        
        so the multiple unit tests don't stomp on each other.
        
        This fixes a couple of things in my earlier attempt
        (*) actually set the env variable on Windows
        (*) don't use a global variable to test the env var, because that
        variable might be initialised BEFORE the env var is actually set
        
        Change-Id: Id43a1dd2fbd324691e0b6578c9026b8a523012e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121436
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [86576cef2c77c8dc78e374aadaadf018610ed6f4]

        Simplify utl::removeTree
        
        Implement it using comphelper::DirectoryHelper::deleteDirRecursively
        
        Change-Id: I89d4e7c71b7556cb23d43fffa9b1e12df5ef8c3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121452
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [2313a43d78c9a172e709d56ed9a933f2a17c2f93]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I342465eb02709a7e07d3088ecbb427a7ae900d30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121472
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [71a8f5db9dd79ce1e023c22286a57856c4b7b3fc]

        Simplify dtor logic
        
        Change-Id: I45395f2370474487dc11a0f634c581b30bdc9a61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121427
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-01  Justin Luth  <justin_luth@sil.org>  [f73fd9918b0002128e209b0e5ba7593a05d05c88]

        tdf#137363 DOCX filter: outlineLvl not associated with iLvl
        
        Lets make sure no one gets the wrong impression that
        these are somehow connected together. They aren't at all.
        
        In order to make that work, the newly added para style
        ability to carry PROP_NUMBERING_LEVEL should not be trusted
        as an inheritance, since it can drift out of sync when
        ValidateListlevel changes the value to body level.
        
        Lets just ignore the drift for now.
        
        Unfortunately, I don't see any way in UNO to setPropertyToDefault
        or Erase or ClearProperty.
        
        Keeping PROP_NUMBERING_LEVEL in sync with 9 isn't great
        because 9 has a totally different meaning in LO UI.
        There it means the highest level 10. This can be seen when enabling
        numbering on these paragraphs - they jump to level 10 right away
        since they already have the property set to 9, the highest value.
        
        The other option would be setting to 0 (the default value).
        But that still doesn't solve the out-of-sync/inheritance problem.
        
        Thus I just ignore the problem for now, waiting for
        -PROP_NUMBERING_LEVEL to gain a NO_LEVEL value
        -uno gaining an erase ability
        -a real problem that forces some kind of solution.
        
        Change-Id: Ie6d098fa60a18ac2e3e7d1e33276ca923bfbfaa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121368
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [8ef6d40a1cdaceb3479656aa32644e8c5d2f7e72]

        ofz: set JSIMD_FORCENONE for msan to handle jpeg_read_scanlines
        
        see: https://github.com/libjpeg-turbo/libjpeg-turbo/issues/253
        
        to silence...
        
        ==255714==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0x546d121 in ycck_cmyk_convert workdir/UnpackedTarball/libjpeg-turbo/jdcolor.c:565:19
            #1 0x53d456f in sep_upsample workdir/UnpackedTarball/libjpeg-turbo/jdsample.c:98:3
            #2 0x547c7bf in process_data_context_main workdir/UnpackedTarball/libjpeg-turbo/jdmainct.c:374:5
            #3 0x5393146 in jpeg_read_scanlines workdir/UnpackedTarball/libjpeg-turbo/jdapistd.c:287:3
            #4 0x219f00d in ReadJPEG((anonymous namespace)::JpegStuff&, JPEGReader*, void*, long*, GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &(Bitmap::AcquireWriteAccess())>*) libreoffice/vcl/source/filter/jpeg/jpegc.cxx:282:17
            #5 0x219d9ad in ReadJPEG(JPEGReader*, void*, long*, GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &(Bitmap::AcquireWriteAccess())>*) libreoffice/vcl/source/filter/jpeg/jpegc.cxx:333:5
            #6 0xd1b770 in JPEGReader::Read(Graphic&, GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &(Bitmap::AcquireWriteAccess())>*) libreoffice/vcl/source/filter/jpeg/JpegReader.cxx:295:5
        
          Uninitialized value was created by a heap allocation
            #0 0x555a1d in malloc llvm-project/compiler-rt/lib/msan/msan_interceptors.cpp:901:3
            #1 0x53f0360 in jpeg_get_large workdir/UnpackedTarball/libjpeg-turbo/jmemnobs.c:56:19
            #2 0x53e99bf in alloc_large workdir/UnpackedTarball/libjpeg-turbo/jmemmgr.c:393:30
            #3 0x53ea1de in alloc_sarray workdir/UnpackedTarball/libjpeg-turbo/jmemmgr.c:477:28
            #4 0x547b422 in jinit_d_main_controller workdir/UnpackedTarball/libjpeg-turbo/jdmainct.c:451:28
            #5 0x53b1f2c in master_selection workdir/UnpackedTarball/libjpeg-turbo/jdmaster.c:569:5
            #6 0x53b0133 in jinit_master_decompress workdir/UnpackedTarball/libjpeg-turbo/jdmaster.c:735:3
            #7 0x53908dd in jpeg_start_decompress workdir/UnpackedTarball/libjpeg-turbo/jdapistd.c:47:5
            #8 0x219eaa4 in ReadJPEG((anonymous namespace)::JpegStuff&, JPEGReader*, void*, long*, GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap, &(Bitmap::AcquireWriteAccess())>*) libreoffice/vcl/source/filter/jpeg/jpegc.cxx:265:13
        
        Change-Id: I6c276a025baba0e22cbf47f102019014fc7d5a36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121477
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Mike Kaganski  <mike.kaganski@collabora.com>  [d4acc83fbca384a24404bab816c2ed1c23343171]

        Use utl::TempFile::EnableKillingFile
        
        Change-Id: If3c6f95220d3888e7ec981a7899886f5a7e00b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121429
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [17ca1c22e3526650a889daa893d34b2c66eec758]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8d581560433e555f7f26b4e24d1acd399acf4d52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [ec6578f12611546032ec788f7531dfff6eae7bc1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7f37460bd39f5d069550c0e6241fe654f8c910d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121443
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Luboš Luňák  <l.lunak@collabora.com>  [e7d2edb025b0ded69742f5e21786061ffc9f70df]

        patch Skia to search only system32/ for libraries
        
        LO on Windows defaults to Vulkan, and Skia tries to load the vulkan
        DLL, which may not be present on some systems. The library AFAICT
        should always be in a system directory, so restrict library
        searching to just there to avoid the possibility of DLL hijacking,
        just to be safe.
        
        Change-Id: I78ad3c7297e613c0316e82c5ff3c0110a02da337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121437
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [fdedc464535ea37f561b641beb4333b757ef9ecc]

        augment CFLAGS for cairo instead of overwriting
        
        so CFLAGS containing msan's -fsanitize=memory are not discarded
        
        Change-Id: Ib46d060b7542bc3e1b19cdef84ae3f8ea7099b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121440
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [7faa086071afe2638d371818d90cecc820e602ef]

        Resolves: tdf#143646 move the border from the outer grid to the inner one
        
        which is consistent with the other sidebar panels and gives the expected
        minimum width expected by the deck
        
        Change-Id: Ic9a4629bf6dc675c2a30533310512bf369c7b779
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121446
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [a49e066945e445c56471e20ba7de892155f12d0b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9ae6e92cd5677619f8604764acbbe30a7290002e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121444
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [e8cef7a93170fdca1a66f80184e7c207d3ca376e]

        tdf#138519 use gtk_adjustment_set_value instead of gtk_spin_button_set_value
        
        for FormattedSpinButton because the latter doesn't change the value if
        the new value is less than an EPSILON diff of 1e-10 from the old value
        
        Change-Id: I410ceec28e1855e53de8c2982e540c612578bf54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121438
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [d69435d357cf14f0c305825cb5122f0fd92f9634]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Idaeb060e54fcb401f483abeb17e4f40dfd7ae20d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a55297c50d26a19536c082760ec0acd52eabcfa]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I8553b1e2b1c3461fa55eb19593b1a97ed9e7ab1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121433
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c356e5e0530e609a2ae9e8b11fb3c4ed43f966d4]

        tdf#139196 - Remove local BOM logic
        
        Change-Id: Ic14d8556ab0f39b6f10619d714e1d8c5ba6c22d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121392
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-09-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [2cfcc8d7c988631333998a78b4b40cb17b025fe7]

        update credits
        
        Change-Id: I8fc0e8085dd647f3677554084a0de139a71e4367

2021-09-01  Tünde Tóth  <toth.tunde@nisz.hu>  [c082158018148be01476d5bc82c1cd71ea6541df]

        tdf#118938 XLSX import/export: fix permission for editing
        
        The password for editing wasn't asked, also wasn't
        exported in XLSX documents. Now it's exported in Calc
        using the following steps, also verified before editing:
        
        - In File->Save As, choose Excel 2007–365 (.xlsx) format;
        
        - enable checkbox "Save with password" and click Save;
        
        - in the dialog "Set password", click on "Options" and enable
          checkbox "Open file read-only", and enter a password
          for editing (i.e. skip the password for opening).
        
        Note: Excel 2016 doesn't ask password for editing, but
        Office 365 does. Passwords created in Excel haven't been
        supported, yet. Also passwords with diacritics aren't
        interoperable.
        
        Note: saving the file under a different path is still
        allowed both in Calc and Excel without asking the password
        for editing.
        
        Change-Id: Ic00d7c5a785e04d270a182a4087ea922d7d92979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121371
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [521d91bce3a88dfaf529216f19e133dea7bb5af4]

        sc: do not use dashes in the file names
        
        underscores are used predominantly
        
        Change-Id: I4a51903a2c7712f463b10a56c7466077544adfee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121408
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [ad4d09db4a359748f5ecf5e78a3513ef3878e9c1]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: Ic5abfe2d047750d8dfd3ae8cc733fa15d34ea505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121432
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [b3e7d61278701ffcc5330e8d65cf9e78991a1754]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iebbc5c690231966960a5dd00908a0a4e1bf15bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121400
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Rafael Lima  <rafael.palma.lima@gmail.com>  [3413d88ff2aff3d717ffe555ea5998b7a1c37396]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bf3053fbbf784070982cbcae793d9de2e559ae3
          - Update "Paste Special" dialog help page
            
            Since LO 7.2 the Paste Special dialog for Calc has 4 new presets that weren't documented in the help.
            
            Change-Id: I098d384bef1d8e2bf152bfe5c846a378088771a8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121412
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [75fca5341ec1e4d0a0113fce26df9992d7352591]

        tdf#42982 RuntimeException msg for SwXFrame::setName()
        
        Change-Id: I1d92730d93e71403b6d0ad97eedef4e6ba00a642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121394
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-09-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0b15f026488968885c46026966ab72c376f61313]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a2b78468e291401740dc43aafdd622d8527f862a
          - Inform that Names must be unique among doc objects
            
            Change-Id: I51fb984022e2b72611137d5860461b78351cc2a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121384
            Tested-by: Jenkins
            Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
            
2021-09-01  Balazs Varga  <balazs.varga991@gmail.com>  [9fbe0a171ece07da0d5c1e16eae23a167cb81114]

        tdf#143127 tdf#143130 ooxml export: fix lost image/shape in chart
        
        tdf#143127: Add officeRel namespace to XML_userShapes
        to fix invalid file error in MSO.
        
        tdf#143130: Add mbUserShapes variable to ShapeExport class
        to fix export of embedded shapes of charts in DOCX.
        
        Change-Id: I10c1dbf905af96d6a63a9243514b32a6440e63f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121035
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [504d78acb866495fd954fcd6db22ea68f174a5ab]

        tdf#143574 sw: textboxes in group shapes - part 1
        
        Introduce SwTextBoxNode class to support grouped
        textboxes, fixing the crash when entering a group
        shape, trying to add a textbox to one of the shapes.
        
        Test of crash fix: right click on a group shape.
        Select the menu item "Enter group". Select one of
        the shapes, and right click on it, and choose "Add
        Text Box".
        
        Note: textboxes in Writer are linked in SwFrameFormat
        class. Each textbox consists of a text frame and a shape.
        This object pair makes it possible to have complex
        content inside any kind of shape (pictures, tables etc.
        Group shapes have only one SwFrameFormat, but can have
        many shapes so that means they can only have one textbox.
        From now, each shape could have a textbox in a group.
        Please note this is only a preparation for that. Filter
        implementation and handlers are under development.
        
        Change-Id: Iae35c118f0e67697b289c30d0fad4f5e16501c02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120452
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c9ff9e89fd50223b28f327d3a7e416ab0ae831f]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I78339f1df1f0c55c7edaa552940b07d1ada3aeb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121386
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [6b851810d43e4a9ea8119d97436f658593ff8f1b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        surely a lookup of i equal to rTable.size() is bogus
        
        ==75288== Conditional jump or move depends on uninitialised value(s)
        ==75288==    at 0x1EC68C45: DelFlyInRange(SwNodeIndex const&, SwNodeIndex const&, SwIndex const*, SwIndex const*) (docedt.cxx:246)
        ==75288==    by 0x1EDE68D4: sw::DocumentContentOperationsManager::DeleteSection(SwNode*) (DocumentContentOperationsManager.cxx:2096)
        ==75288==    by 0x1FC27F2C: SwHTMLParser::DeleteSection(SwStartNode*) (htmltab.cxx:4945)
        ==75288==    by 0x1FC231EF: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5219)
        ==75288==    by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589)
        ==75288==    by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020)
        ==75288==    by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189)
        ==75288==    by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055)
        ==75288==    by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589)
        ==75288==    by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020)
        ==75288==    by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189)
        ==75288==    by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055)
        ==75288==    by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589)
        ==75288==    by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020)
        ==75288==    by 0x1FC25B38: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4189)
        ==75288==    by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055)
        ==75288==    by 0x1FC24B7B: SwHTMLParser::BuildTableCaption(HTMLTable*) (htmltab.cxx:4589)
        ==75288==    by 0x1FC23E34: SwHTMLParser::BuildTableRow(HTMLTable*, bool, SvxAdjust, short) (htmltab.cxx:4020)
        ==75288==    by 0x1FC25BC5: SwHTMLParser::BuildTableSection(HTMLTable*, bool, bool) (htmltab.cxx:4194)
        ==75288==    by 0x1FC2237F: SwHTMLParser::BuildTable(SvxAdjust, bool, bool, bool) (htmltab.cxx:5055)
        ==75288==    by 0x1FC79B2C: SwHTMLParser::NextToken(HtmlTokenId) (swhtml.cxx:1787)
        ==75288==    by 0x22060E6A: HTMLParser::Continue(HtmlTokenId) (parhtml.cxx:295)
        ==75288==    by 0x1FC745AC: SwHTMLParser::Continue(HtmlTokenId) (swhtml.cxx:683)
        ==75288==    by 0x22060CF5: HTMLParser::CallParser() (parhtml.cxx:279)
        ==75288==    by 0x1FC73F7F: SwHTMLParser::CallParser() (swhtml.cxx:607)
        ==75288==    by 0x1FC6FF90: HTMLReader::Read(SwDoc&, rtl::OUString const&, SwPaM&, rtl::OUString const&) (swhtml.cxx:238)
        
        Change-Id: I9583e5be41fe76f19c699394961ed2717a990cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121351
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [0b16224062c0434087c3b904cc57d44e5723394b]

        tdf#142458 minimal width not including extra width needed by scrolledwindow
        
        its only including the width of the panels and not the extra space
        possibly required by the container window. Which is 2x the
        m_nBorderWidth of 1pixel of VclScrolledWindow in this case.
        
        Change-Id: I56775c7183d7a8b87af263ddc8bb17373779e9ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [9e0e25c489e0ee170ef4f212efa707734f581347]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4e1a5a6254c22423d8b7e75d4afc88393fc816de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [3432bace75ba9959524ed1f7e32a833433b30046]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3b32e04f05c39871d172a35ef60af787ffb5ee87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121397
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [648d0c21a1f78074c7119dfcc672f20cc5cf03b1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I2ea2640773f7b39fac5c7c5cfe606a6ac53ae6d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [2f31978784bd142d4bb4dd50c328f6eb069ae31c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I394b84d9d83d09096932c94fb09e6d964a5aecfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [4b1edb272c029cf72681730133e3c2272068bbad]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ia1e6d4c71d4bd228f2a9bb5fd2f5dbf54b94700d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121396
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Caolán McNamara  <caolanm@redhat.com>  [0a2ab8e9310e64a2c053a700a2e5574ec11a24fc]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9e7be23fd8a52cfd0976ca358d848cbe11e84c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121355
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-09-01  Heiko Tietze  <tietze.heiko@gmail.com>  [d66ab0c7e8b0330c5c82e37e256557b1a7a6ae03]

        Resolves tdf#142116 - Respect field shading color on dark background
        
        This reverts #100366# commit ce057f404b7b39df4a9259eecd90e28cf9a75fbd
        
        Change-Id: I50872e38a154f5d24bcfaafd11488508e3c52356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121359
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-01  Dennis Francis  <dennis.francis@collabora.com>  [9d8324524bdcd1244cd6e9d93b063b981d47c9be]

        tdf#143942: oox: import/export labels from <c15:datalabelsRange>
        
        When <c15:showDataLabelsRange> boolean flag is present, the imported
        label texts are added as the first text field in oox data label model.
        The cell-range associated is also preserved. The export part preserves
        the how labels were store originally in <c15:datalabelsRange>.
        
        However in order to make the custom labels reflect the contents of the
        cells in the associated cell-range, more work needs to be done. For this
        the labels present in <c15:datalabelsRange> needs to be made available
        as a data-sequence with a new "role" like "point-labels" in
        XInternalDataProvider implementation and and make the label renderer
        read this data source rather than consulting the custom label fields
        property which is static after import.
        
        Change-Id: Ibc7045fa5ea209d463680c96efb49a06662d2500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121313
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-01  Miklos Vajna  <vmiklos@collabora.com>  [b365358075d484e034eb9cd6bceeea9d639835b6]

        CppunitTest_sw_ooxmlexport7: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Id6b673d744d5eb1249d9466feb7a4f3758802b0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121393
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [1875b3d9f2a3873b592d5d207a46a6771649ca95]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb9d34dadbf78fd09ff39ba46d0e48c6ae9f9940]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I2fc0a1f5a637b3228d8f49ecd0e0769d6872cdc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-09-01  Miklos Vajna  <vmiklos@collabora.com>  [5d0860ed0600904a03459e8bf5a6792c671463a4]

        sfx2: allow storeAsURL() on the main thread
        
        This is similar to commit b030e83fccbff8d82a4c84462075baa8442cde54
        (sfx2: allow storeToURL() on the main thread, 2019-02-05), just this
        handles the 'export' case, not the 'save as' one.
        
        Note that this already worked in some cases when impl_store() decided to
        call storeSelf(), but vcl::solarthread::syncExecute() already avoids
        dispatch when called on a non-main thread, so that is not a problem.
        
        Change-Id: Ief09ba6c60923c7f16d86f61625c0faa9a5f829b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121385
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-31  Eike Rathke  <erack@redhat.com>  [d5ade739771ddf06cc7ee6d4af15672bfcf09ed6]

        CSV/Paste: setting a text format is only necessary when using ScDocumentImport
        
        For ScDocument::SetTextCell() it is forced anyway so was actually
        done twice, in the case of Paste and TextToColumns.
        
        Change-Id: I3144e2d316810c702c5ebd84698e8611674adace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121381
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [4cfc303886bc9f863f755f8278561f9e57f9a5c5]

        tdf#117868: sc: Add UItest
        
        Change-Id: Ic8630d3497ece3903662c671878a42e448e7f553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121383
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [7a410f7ee447201dc23b31166ca9989a3c01bce7]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I0e671742043662aec27751974223b205d24508aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [aac3ef9df34b38d8fc786f13b0336c7cbe68ee51]

        fix crash in select-all
        
        <vmiklos> noelgrandin: hmm, when simply typing "a\nb\nc\d" into writer
        and trying to select-all, i get a crash from the new
        SwFrame::DynCastTextFrame(). is that something you see?
        https://pastebin.com/raw/v00ncxXP is the backtrace
        <vmiklos> sounds like the old code invoked dynamic_cast<> on nullptr
        fine, but the new pFoo->DynCastTextFrame() won't work if pFoo is nullptr
        <noelgrandin> vmiklos, doh!, thanks, will fix
        
        Change-Id: I58966512551e90ded3d3ecd65fef9f083dc6d852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c91a5c71d1696ab30632a2f093eb62ee783c4a65]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I94f8272ffbdbf5bc7a4cc31433dc547231fd4392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Xisco Fauli  <xiscofauli@libreoffice.org>  [d8a0b3030c3cf7b8883667e2140dc6cbe8eb90f9]

        uitest: sw: move find and replace tests to their own folder
        
        No need to have sw_findSimilarity for just one test
        
        Change-Id: Ifec7ee9cbc81492dcae95f330a697e03875ac3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121044
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [dfde7cef704533fa9e352225ee596da7e2e106d1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I40ab9dc8b320990abcf89630984892e040a8544d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [58da1a60424f4decffd6a946454eb8f7520ab8fb]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        test for eof condition before comparing the uninit val
        
        Change-Id: Ie27c80f6c8103af4283181c522794eb878ccf588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121373
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [312161673912bc60865493635f9820d11f2c58f3]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4298dfeafab0fe296a970fce024cc25572e3a2b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121388
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [a41cbb1212a92f525dc75e90007c6dbc998f37c5]

        flatten SfxAppData_Impl
        
        no need to allocate things separately that are always allocated
        with this object
        
        Change-Id: I6acc215fa1f86625f300cd7717ee5d40a6bc986b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [5fddc93fec46cda828595418105af3838918cb69]

        no need to allocate SfxFilterMatcher separately
        
        it only contains a single pointer
        
        Change-Id: If988f03d693d4912ce3b7a6fa5fab7cd52ab05cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [8bfb8574fe1b0bffff6ad82d469fc43247ac8c80]

        no need to allocate SfxPickList separately
        
        it only contains a pointer
        
        Change-Id: I593665314eae2c0ad02b4555c2fda0d8719f2edf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [1969673c42880419be95425eef792893692878a9]

        no need to allocate SfxDocumentTemplates separately
        
        it only contains a single pointer
        
        Change-Id: If6fc4924b7980317500a5c02e62c671f8f97aafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121338
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [b3aaa0057beb098e16976f7ec3361b5f484b28b1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ie08cae55b638be5756d801b10b4546eb6c985f7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [64ca7eeb6785d8609fc37308bd1eee729214e82f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7d17a5cad38a5af3a8b776f5cad40e63cd2b5929
          - tdf#143585 Improve example on calling Calc functions in macros
            
            Originally the example shown in "calc_functions.xhp" was embbeded from "03131600.xhp". So in this patch I created a brand new example in "03131600.xhp" and improved the example in "calc_functions.xhp".
            
            Change-Id: I758a0e5dec3e66f924415970711dfa9044396026
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121060
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [2481b38756024e32607822728ef76265a3175f4d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 329d51b5e63600b39ccb8fc95f8be84b81aaf7c3
          - tdf#105152 Update Calc AutoFormat instructions
            
            Change-Id: I8fbc4b554947f9132d7ef357f1c7b02c98250bd6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121280
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [dcb595dac4c9992e9f68ee67644be790f241bf8e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e7954968f401bf69434c1c53701da335d0a63f2
          - tdf#107290 Update "Selection Mode" help page
            
            The bug report requests to update the shortcuts for selection modes. I also fixed some inconsistencies in the text and table formatting.
            
            Change-Id: I1c210b989a5105299182b0a6599db616ea8f588d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121276
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [cb8d753674e954e6f6538ff7ffe8f58f240f39b9]

        upgrade internal cairo and pixman to 1.17.4 and 0.40.0
        
        cairo.RGB24_888.patch is split out from the rest of the unrelated
        patchfile it was in, this was introduced originally as:
        
        commit 54596087e57ea533253e19eea594d9b6c06e8d26
        Author: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
        Date:   Sat Dec 9 16:28:42 2017 -0500
        
            vcl-svp: add 24-bit (3-byte) RGB surface support to Cairo
        
        drop parts of pixman-ubsan.patch that no longer apply, which
        maybe casts doubt over the parts that do apply if they are still
        necessary
        
        Change-Id: Id1e8f112b1121b892c97ea248b101f133f03ac48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121234
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Rafael Lima  <rafael.palma.lima@gmail.com>  [c13cb72d48e71d29610c98dc02f1739a0c2be2cf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a3f7c8d5013aa8432e0e621f78426f183def0885
          - tdf#142301 Fix Cross-fading menu entry in the Help
            
            Change-Id: I5daba02bbe957bb9f594e9ff9a8a12d5fdb8ecb2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121274
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Justin Luth  <justin_luth@sil.org>  [c9639186c8a6bf594fae459b4aab478bbac8fb91]

        tdf#143793 preemptive unit test for USE_FORMER_TEXT_WRAPPING
        
        Ensure that any efforts to sort out the back-and-forth
        issue of honouring wrapping in headers, footnotes, etc
        won't break old documents without even a whimper.
        
        Change-Id: Ic12595a8e25aff176e89adfaba51991d38db516c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121377
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-31  Ming Hua  <plateauwolf@qq.com>  [e94c05078a7535c357bba3576d088fe53bd9eb9e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e595e008e1c3232dd9e3ff49a28f238413e2537
          - Database queries: fix broken links
            
            Change-Id: Ibe089725e393bfd290963e2abaf31da6d3ab0b85
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121163
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [497732b857790c57bbfc7ff1120e864f5c207d3d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac52503447d65fc400597c2c21ecef623df18b93
          - tdf#132643 Translate German section IDs
            
            Change-Id: I892369ba6b5ac07ae41482fe13f9afe5429c344a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121196
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [b6a41d3efec69ae777584d14be2eff0575311cb0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7455704da23c1098baf52273e3e765a9bbf4c855
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibbbfc3ab223813d7969479b4bbb93c3babe6bb30
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121195
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [611b09e769e0b4cf624c4f69a1c39fbd8e5af8c6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dcf8240fc1b6d2e5e51b19f37bdc273f5d78eea1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I76cd1df3e39174473e879d1f5a8d75197378223a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121203
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [0b829eb738b3b3aea2bc02499bf2a89ebdbc5f46]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b7042594a35baf6199beba8a8bc01b3a499352d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6f32f77b35033091e2a5b5a1d41a5897dd28d9b4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121202
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [60f47069858fdf2e746c3168e652d3dc5cb9d020]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f328a800e34ac8c97a0ec4988cb1c643326ca692
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9c70666cb5e40718b3bc900065c3d5e865788f52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121201
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [83cbd2235872bf34c6612da6945458eb199f6018]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d49eff7831f45d0009386fcc5482110178ab207e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia6a561687ebb55b01b3207b1b3091056046b0af9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121200
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [20aee34b83a6ab465ba82831cdb750dd8cccebef]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4b65390391b89f82aeeec75bb13e0717c6fd15ce
          - tdf#132643 Translate German section IDs
            
            Change-Id: I570647236735f9e854a9e3c44af04bd943109e6a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121199
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [56c056e0c90531db362921fcf47819d547bf7cad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1e6bae00ac5539f23f6eead9a3299fc95ec827e7
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib2f36827f9081afd41259c74a4e3c5183a83cede
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121198
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [0c35f964a154287144444e1663e02d0144658c69]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 48110c1a6d0a695283900ce38532f6a45807111d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I803cbd94433b0002ded6c622164e4d57e3b405d7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121197
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Johnny_M  <klasse@partyheld.de>  [1d0a6209c5cf85eb1c96b7ee8087a2f56c0d5063]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e010ffb9bebba9d0ba5649650318fb9b6aca3438
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib7fb870050c9b7f3ac4cbb27c4c00213fb0e8ded
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121194
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8508873a24387fefacd95e11e2ed9f2a0027ad43]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: Icaef0cca9ca7bce76a7eb7ecd54c492f9ffcaad6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [7955fe46e226d74732993454e18be6835659c11c]

        flatten SfxObjectShellArr_Impl
        
        Change-Id: I97e3ea18ce17c63ae95d7755a32c602b88373370
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Eike Rathke  <erack@redhat.com>  [8a45eac81686ccc06b7f028594770ad18ae66057]

        CSV: use target doc's formatter to determine and set forced text
        
        If text is to be forced check if the string is a number in the
        target doc's locale which then needs to be forced to text format,
        not in the input parsing locale. Also set the text format of the
        document's default locale, not the input locale's text format
        (which may or may not match the document locale).
        
        Question remains if this isn't duplicated work anyway because
        setting text at cells forces text format if necessary if
        ScSetStringParam is setup correctly. To be investigated if all
        paths taken actually do that.
        
        Change-Id: I3db3907cfe81156ccd1b0b523372dd97ee8598a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121366
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [903b232eb3b97e3557ef8c918e0a6474d197ef56]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9c7eae9b8744b946a00b6285f4f0ed83d63f4834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121333
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Chris Sherlock  <chris.sherlock79@gmail.com>  [3ab647fa6cb0587668f93bea0b8de9237b71a0cc]

        vcl: move RemoveTransparenciesFromMetaFile() to outdev/transparent.cxx
        
        Don't know why an OutputDevice function was used in print2.cxx, but
        definitely needs to be in the outdev source directory, and 
        transparent.cxx is the most appropriate place to add this.
        
        To be honest, that function only operates on metafiles, so perhaps we
        should make this part of GDIMetafile, so added a TODO.
        
        Also, a number of local header files (all to do with PDFs) needed to 
        become module local headers, so I have moved these to the vcl/inc/pdf 
        directory.
        
        Change-Id: I1feb8e5e8aedc7399740a035beacd2dad3de317f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121321
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-31  Gökay ŞATIR  <gokaysatir@gmail.com>  [643e0fe7fc16345e3f534f270f7eb5b5276e26a2]

        lokinteractionhandler: Use json_writer for JSon types.
        
        This patch is for making more use of new json_writer class.
        
        Change-Id: Ic8dd6694887635a363a74d2cf5bd1e3e2987463d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Tibor Nagy  <nagy.tibor2@nisz.hu>  [e5cfda76aefd6996813f461198816be24cd6ad43]

        tdf#142645 PPTX import: convert "ctrTitle" text to slide name
        
        (i.e. centered title) similar to <p:ph type="title"/>.
        
        See commit 7eb0e52527e729a21973e70d5be8e0a6779ec748
        "tdf#142648 PPTX: import long slide names to avoid broken link export",
        commit 253bee65bc24d999c3629a4d503d0fa01b355cfc
        "tdf#142646 PPTX import: count repeating slide names" etc.
        
        Change-Id: I5f25f04f23981ce2ff64dc792fe8464682d749a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121295
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [e822d5590e48a1100717b5d0ae2b6d72f4f936da]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iaeae1efd2da2add9729bab38137c8ff1fb9818db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [2053a545413e788f6d3fb74e0335f8f2d354a0cc]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        no idea why its like this in the first place, but I'm not
        going to change it decades later, just zero out the uninit
        bytes
        
        Change-Id: Ie5d875523999d465dc167ac4fedcb99d3825ae99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [21dbf18064480cade972f50431a7fad6505d6d43]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I95918275653714577e2d6728dd3947c7fbb66d8f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [5d64720ce7571cb491e8c477e3744e1c19894625]

        flatten SfxViewShellArr_Impl
        
        Change-Id: I781f877b0c94fdd667b4fd00342e68b35b127867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [6191fc447395e877876290eedf28019a1866958d]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I5e8baec88d5f17ddda452bd945c87769623cb4e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noel@peralex.com>  [bb5425ed3d8cc04e4242059a17912752d6b48c53]

        tdf#135683 speed up writer layout cache access
        
        can be hot, so use a std::unordered_map
        
        Change-Id: I70e34e80cad67536414c71facbe0222dd88c65a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [eae0636311d3a1b3a1af58a3e4df686b55afa3fa]

        tdf#142881 XLSX import: fix shapes rotated exactly 45°,
        
        135°, 225° and 315° by correcting their cell anchor points,
        like MSO does. Previously the XLSX export with the bad
        anchor points messed up the rotation of the shapes, resulting
        also broken text content in LO and MSO.
        
        Thanks to Regina Henschel for analyzing the problem.
        
        Co-authored-by: Szabolcs Tóth <toth.szabolcs@nisz.hu>
        
        Change-Id: Ica625545a22a74ed027ac0fa2bbf38804611c172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121307
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [a58b9010b38ca43d4b3a2b30fcd6bec28db1b344]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I63ce4b9a49988736fd6d602a49dd54495863faec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121353
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [0ec44b738b92bbf6965bf0dbe41199476673dcaf]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        check for short reads
        
        Change-Id: I1fb142e08f5664ca73dc62f6c5a5ecfd2ee1e875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121352
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [fc3bacf7e02af57781a9d63581abc96d66d6529f]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id877653f5c120f690fc3f597979de88926ec6ab0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121354
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [203cc17337702e0ae50d120aae1e18f8ce649ee7]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7d0363f67ac6f4b9bece2fb0f942a476ea203d94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121305
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Luboš Luňák  <l.lunak@collabora.com>  [234ed4bcd5c4b5b41467890b82c6efa08dec559d]

        reduce code duplication
        
        Change-Id: I31ee84be7ebee7f1644d7fd43bbc951abd2842d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121328
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [4a65109b7ab3cafddad113900754260af2dbb4ea]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9867737be62871aaa80a9ce0b51318afa62e8a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121334
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Chris Sherlock  <chris.sherlock79@gmail.com>  [f2f8445c9dca13cc343dbfb08a5ab236e25155eb]

        vcl: cleanup OutputDevice::Push()
        
        Change-Id: I705fdf35b96ab598c2ddb4e34d0a2b7d0bdd9ab4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121013
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-31  Stephan Bergmann  <sbergman@redhat.com>  [04117f78f235a60094f8d92ce983ebcc495ecc49]

        Fix UNOIDL identifiers that started with lowercase and contained underlines
        
        ...which are reserved in UNOIDL (though unoidl-write does not enforce that for
        now, see the TODO in unoidl/source/sourceprovider-scanner.l, and idlc only
        warned about it with an explicit -cid option)
        
        Change-Id: I529f385e9c263d2dab9baf3b99f0208457da04c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121346
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-31  Luboš Luňák  <l.lunak@collabora.com>  [2a0f2f074dd643b723bfbcc5c96e4f5ee8da87a3]

        fix Skia flushing to screen on Windows (tdf#144145)
        
        Should have been part of eb37b1e346f5651ce8e6848e51103a8986a57c36.
        
        Change-Id: I25c5524fcea90ccc30d880451034d0fa1716b6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121327
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-31  Luboš Luňák  <l.lunak@collabora.com>  [5e4dfd68d690f38dd87609c39fc564b92bc6a0b3]

        Skia's kDifference now seems to cause crashes also on AMD/Windows
        
        Change-Id: Ia60605407ba9f890db308301711f2d54bca92d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121326
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-31  Luboš Luňák  <l.lunak@collabora.com>  [2489edcbe0f5dc77649fc2e801c1bbffb71692b8]

        make Skia the default now on Mac too
        
        As per the ESC decision from the last week.
        
        Change-Id: I8f2fc4c7f33d4c044ac9e20df6f93eb755507efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121292
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-31  Luboš Luňák  <l.lunak@collabora.com>  [bbf7dc39abf64c314e9c43c4d0554d1d7bdef3e7]

        test at least creating Metal context when initializing Skia
        
        Change-Id: Ic00236e7876039c3f5c0c1e719e829b844d1d2e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121271
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [874bcdbd8948ca98a559d8604795ea3ee238bf15]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3be8bae46978b8641abf82acd9620c770a076a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121320
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [a412668d8d6b90d8785d1b7a98fd44ad9bfe0f16]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5a5fe3221301532a1eac3efe8779ac62e3be82be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121332
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [0aed7f60182f2d81e52555096f2a3ef5fb96e403]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I97b5552b9bfbde61ac35ad7a2a7e6dbc8bdea429
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [12b4913b86a3b9ea5882bf57272603064861639e]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3244f5c83a02f41ec379188b1fedbdd9e511967c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121318
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Caolán McNamara  <caolanm@redhat.com>  [79b58f222885cc0648ef46c7d05089f09060f793]

        reversed condition
        
        Change-Id: I5d4440ed16fe6acc21923209f94067ce7df03564
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121323
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-31  Miklos Vajna  <vmiklos@collabora.com>  [4f4452f6a74201e862971a79ba5bdcd06f3ba9ce]

        tdf#126126 ODT import: improve import of cross-table commented text range
        
        Regression from commit d4b473dd9ba77427b28d97847067b8877c2033d9
        (office:annotation-end import, 2012-07-20), the problem was that
        XMLAnnotationImportContext::EndElement() assumed that we can always call
        gotoRange() to go from the annotation start and end points, but this is
        not true: an annotation may start inside a table and end outside a
        table, which is not a valid selection, so gotoRange() fails.
        
        Fix the regression part by just creating a text range for the anchor of
        the comment, so the comment is attached to the end of the range, and
        this way the rest of the comment & the document can be at least opened.
        
        [ It seems bookmarks behave similarly: they don't block the whole
        import, but don't work cross table boundaries, either. ]
        
        Change-Id: I1b5a2e2e7501ce3054379fc79d2045c3439c52e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121322
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-31  Stephan Bergmann  <sbergman@redhat.com>  [a36d1308f946d890fcdf7887169f284704e4a5bf]

        Elide class makeOIdPart
        
        ...which is no longer needed since 00f257a7ef4f1ec52887bc379c14757e057e94c8
        "rtl::Static -> thread-safe static local"
        
        Change-Id: Ie78154c5d8b6ad8278405d1ce56c76997e0478d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121347
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [4b64d6ac2a186a68f5360d31ae21aefcceb84d12]

        flatten SfxViewFrameArr_Impl
        
        Change-Id: I1d9b0e117a08ddafe56546a58e536b76529966fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [af24eaef7a9a8b8e5adf297901d08273342e7e93]

        flatten SfxTbxCtrlFactArr_Impl
        
        Change-Id: I422aeeb446a49fa4449eabe0c3643f125856db12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121330
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [48cff413e21830e3da4df8cb55540e68a4f009a6]

        flatten SfxStbCtrlFactArr_Impl
        
        Change-Id: I1d92a41f0f1a2610930e48b5eeaa689ac47ab7fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Noel Grandin  <noelgrandin@gmail.com>  [1ff8e0a958685fbaf63fbc2d4c766a76869d4879]

        flatten SfxChildWinFactArr_Imp
        
        it's just a vector with no additional intelligence
        
        Change-Id: I91d014783e79130689b4f6eadb3ef6d8486227e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121324
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-31  Stephan Bergmann  <sbergman@redhat.com>  [d87acc9fed5fd42588f593ac5e1bfca8308499dd]

        Adapt to cppu-/javamaker's idiosyncratic relative URL notation
        
        ...which considers an argument containing SEPARATOR characters only as a
        relative URL (which it then makes absolute relative to osl_getProcessWorkingDir)
        if it starts with a dot (see convertToFileUrl in
        codemaker/source/codemaker/global.cxx).  (Which isn't an issue for now, as
        convertToFileUrl leaves the relative path unchanged, which is passed to the
        unoidl::detail::LegacyProvider ctor in unoidl/source/legacyprovider.cxx and on
        to store::FileHandle::initialize in store/source/lockbyte.cxx, which makes a
        relative pFilename absolute relative to osl_getProcessWorkingDir.  But it would
        become an issue when the given type RDBs are changed to the new UNOIDL binary
        format, as the unoidl::detail::UnoidlProvider ctor in
        unoidl/source/unoidlprovider.hxx expects an absolute file URL.)
        
        Change-Id: If9f66f3e9c20a8416d25989099e6c921520e6a94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121312
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-31  Julien Nabet  <serval2412@yahoo.fr>  [d4e4e273a5960fcf933729d153de76ecf796aca5]

        tdf#126624: do at least the generic solution
        
        Change-Id: Iae0843b7c06590191c0627bc0a4d70bb42e5b256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121325
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-31  Mike Kaganski  <mike.kaganski@collabora.com>  [638acd81979f24262c29dc12e0289d7fc38fcd8b]

        tdf#144183: restore 'erase' that was accidentally dropped
        
        ... in d47ac2ebdb495b025eb26e17cbbe2509797c31f0
        
        Change-Id: Ic4946b72a0ef599428af5b806754bda5f0906990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121282
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-31  Eike Rathke  <erack@redhat.com>  [4c29c2bfab18b25229e0bc71014fd2ca42ec5bff]

        Resolves: tdf#114878 Add 'Evaluate formulas' option to CSV import and paste
        
        ... and Text to Columns, defaulting to false for CSV import via dialog
        and stored as config item option similar to all other CSV/Text options.
        
        Change-Id: I742f447b905a07b05dcf5fc58796c46de212276b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121344
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-31  Eike Rathke  <erack@redhat.com>  [faff8fd27ac38d2001b6bf26b02381801b8844ea]

        Resave with glade 3.38.2 to convert property names with '_' to '-'
        
        Change-Id: I745fda9e2b61c15f281d7a2d8f21d8003253c6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121343
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-31  Rene Engelhard  <rene@debian.org>  [a866d63e0ac9de4ff7e59b3928f09ec21877bef3]

        fix build
        
        CppunitTest_vcl_text needs icuuc now, not only icu headers
        
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()':
        ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()':
        ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()':
        ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UMemory::operator delete(void*)'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::~ScriptRun()':
        ././vcl/inc/scrptrun.h:61: undefined reference to `icu_67::UObject::~UObject()'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o: in function `vcl::ScriptRun::ScriptRun(char16_t const*, int)':
        ././vcl/inc/scrptrun.h:116: undefined reference to `icu_67::UObject::~UObject()'
        /usr/bin/ld: /home/rene/LibreOffice/git/master/workdir/CxxObject/vcl/qa/cppunit/text.o:(.data.rel.ro._ZTIN3vcl9ScriptRunE[_ZTIN3vcl9ScriptRunE]+0x8): undefined reference to `typeinfo for icu_67::UObject'
        collect2: error: ld returned 1 exit status
        make[4]: *** [/home/rene/LibreOffice/git/master/solenv/gbuild/LinkTarget.mk:731: /home/rene/LibreOffice/git/master/workdir/LinkTarget/CppunitTest/libtest_vcl_text.so] Error 1
        make[4]: *** Waiting for unfinished jobs.
        
        Change-Id: I3e94e0f97694c99c6388f6268054fe1c57a881cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121240
        Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2021-08-30  Miklos Vajna  <vmiklos@collabora.com>  [56f593c9aa00f87fb8780060fece991b91b5c0a7]

        tdf#137310 ODF import: fix loading of images with multiple slashes in path
        
        Regression from commit 1b02ba03bd62a712e15c15384a3d105d2c088120 (shapes:
        don't use "GraphicURL" property, always use "Graphic", 2018-02-13), the
        problem was that now the loading of Models/Fallbacks/duck.png goes via
        SvXMLGraphicHelper::ImplGetGraphicStream(), which assumed that the
        directory part of the picture path contains no slashes, so can be
        handled via ImplGetGraphicStorage().
        
        That functions works with Pictures/something.png, but not with
        Models/Fallbacks/duck.png.
        
        Fix the problem by using openStreamElementByHierarchicalName() to open
        the picture stream in case we got no stream and the storage name
        contains a slash.
        
        Change-Id: I0e04fb4286777b04286c4979af31e6df19988873
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121308
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-30  Stephan Bergmann  <sbergman@redhat.com>  [be7e6940a328a5002457eb5be26836365bfe3ab4]

        Update the reference rdbs to libreoffice-7.2.0.4
        
        LD_LIBRARY_PATH=.../master/instdir/program \
         .../master/workdir/LinkTarget/Executable/unoidl-read --published \
         .../libreoffice-7.2.0.4/instdir/program/types.rdb \
         >.../master/udkapi/type_reference/udkapi.idl
        
        * no changes
        
        LD_LIBRARY_PATH=.../master/instdir/program \
         .../master/workdir/LinkTarget/Executable/unoidl-read --published \
         .../libreoffice-7.2.0.4/instdir/program/types.rdb \
         .../libreoffice-7.2.0.4/instdir/program/types/offapi.rdb \
         >.../master/offapi/type_reference/offapi.idl
        
        Change-Id: Id32b68c9bdf908d0d41bc99fd44d9c1f7820ed11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121300
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [c93f941be682d767636110ab10da9a55833370f4]

        ofz#37831 avoid Integer-overflow
        
        Change-Id: I95acce44623c6c5e48686a79314ffaf6ab402292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [31d0b43edfc304b7d69adb49ab8e5892726ed0cb]

        make this more readable
        
        Change-Id: I031054d3a6929c48b796ce527448d2c5a5099a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121319
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [03e108f27b91dddc8fabc6f52f18afd6aac8666a]

        tdf#144105 crash after closing edit address block dialog
        
        use RemoveView to call RemoveDragAndDropListeners before shutdown to
        avoid RemoveDragAndDropListeners getting called during dtor and
        calling EditViewCallbacks::GetDropTarget on the destroyed host
        widget controller
        
        Change-Id: I63841b893d37d45cc44a0ffbaa534cf87c407615
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121310
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a99294ca4ffc81aca42667a13d06ccd9ab0d098f]

        Removed executable bits on docx file
        
        Change-Id: I811055f7fc5b05c9123a1fca4118bd469515239b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121269
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [f590bb806a8b439f595b84b624971bb6c1b89e6c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9dd1d0179e6d3096bbb1030341a731c2896392e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121304
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [a0b5731dd6e8be9d61c5da2225512970f47a7c72]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iccdfb92beae8d79863d1bca3dc44c1a13bf30a67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121299
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Michael Stahl  <michael.stahl@allotropia.de>  [91b0024965908c692bea40f47c58ea9d1bf8a596]

        tdf#103612 sw: fix confusing inheritance of section hidden flag
        
        SwSectionData has 3 confusing boolean members for hiding:
        * m_bHidden corresponds to the Hide checkbox in the UI
        * m_bCondHiddenFlag stores the result of evaluating the hide condition
        * m_bHiddenFlag is the final computed result that indicates that this
          section is hidden
        
        Now, the first 2 flags determine m_bHiddenFlag = true, but there's
        another possibility: m_bHiddenFlag is also true if there is a parent
        section for which m_bHiddenFlag is true (because of course this hides
        all section content including nested sections)... the latter situation
        is apparently handled in SwSectionFormat::UpdateParent().
        
        The code in SwSection::SwSection() checks the parent's m_bHiddenFlag but
        then sets the child's m_bHidden, which looks very wrong, so remove this.
        
        Also adapt 2 other places that look like they should be checking a
        different flag.
        
        Change-Id: I58d9c878b58ad6cd878f450072178006b4c7ebb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121314
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [8b3d5a79c0f70cb3bdfa4cbe8adf91521a28d89c]

        vcl: DrawDeviceBitmap() -> DrawDeviceBitmapEx()
        
        The function actually draws a BitmapEx and not a Bitmap, so it
        was named wrongly.
        
        Change-Id: I8eb34b744a4cf48e3a07de731bd70baaa62942ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115474
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [654c1f6ebe4c0c8504e0b9a74ee48f7146cf5a43]

        vcl: move BitmapEx related functions to outdev/bitmapex.cxx
        
        Change-Id: I93d94d3043263b97ae9f9078a8afc6016c1a3531
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115472
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-30  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [84888d6bbee16978774acb5d23b1b4eb006df67f]

        tdf#142847 sw: fix textbox layout at wrap setting
        
        Setting wrap spacing of a textbox via its Wrap->Edit...
        dialog window, the textbox had fallen apart, if it
        was anchored as character.
        
        Change-Id: I6c48c7a631a93a874129f64e1bdc6b3e2051e64f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118281
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [34f54a86d02513c1859ca9529da7b2d3a3eb9bb1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I931c104c2b0072146580996b6adc0bb36f328083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121294
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [0c7b733c2b9f2454717f94e2ae3b483e1bd3e830]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I5f5cb10e7e1792caa39644fc973ba34c27d85eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121298
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [7b52dc7334c46dadf279c54486e0f07a2540d5ae]

        Update git submodules
        
        * Update translations from branch 'master'
          to 02e3dd80f5b066ff95b1769ad2a5c9651337a509
          - update translations for 7-2/master
            
            and force-fix errors using pocheck
            
            Change-Id: I76dedce86c4402c3a3cbb4ad01c3cfaba8732f43
            
2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [2e9e7438ef958a90d9dce4fe170eeac911ebf782]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9a1be351cc07b96eaf09605437c50baa98239654
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121303
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  4k5h1t  <ask160203@gmail.com>  [7970e700f86bca811508f9b229110d6ab4393d04]

        tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I7347d2c9429647e9cd87ad8147848d24f717d181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121222
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-30  Eike Rathke  <erack@redhat.com>  [158cc1d81121df12edfaf9ce80a7745e6aaad46b]

        Resolves: tdf#144059 Tigrigna {ti-*} (Ethi) is CTL
        
        Change-Id: I5fb56e039c854471ae444395feee27e820902181
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121297
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [6e4f728dc93a4e849d2396bacd672e2df3274cc1]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ifb7e4d51ee946ceb62abf7e5d30da0f04c49282e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121302
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Stephan Bergmann  <sbergman@redhat.com>  [bf82015256aa9ac7ad11d66c04c1f0ff1226b91d]

        Look through implicit MaterializeTemporaryExpr
        
        ...which gets introduced when building with recent Clang 14 trunk against recent
        libstdc++ 12 trunk (though no idea what change exactly in either of those
        started to cause this)
        
        Change-Id: Icde11e16465c0deaefe76eb8d1065362d4551651
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121296
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [ae3816bced5d39c0e28ad6fe241f529060493b30]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9c75cc5581c3babe0d56d04ced3398925fa5151c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121301
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Luboš Luňák  <l.lunak@collabora.com>  [774bc3d64b6e1149ab9607e3fd11c96eee0da59f]

        fix missing variable assignment
        
        Change-Id: Ic353aabe130dd82d4ee14208ab2c8d66fd839681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121293
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [9b8a4171c5ef9f2b88b73007e394774b4ab84a66]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5737332355e2d047e7ab6112cc4767d2b0639dba
          - tdf#65152 Improve Clone Formatting tool help page
            
            This patch improves the Clone Formatting tool help page to make it clearer that in Calc character formatting is not copied.
            
            Change-Id: Ib6d83e7266cacc05c8d86a4c13b7d5f026e84068
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121066
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [a10d8bb18e81414bf49e7ea7a04c172e4b30b9ea]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8a0a8f0bd9f55c4d0b20281205cf12f2bbcc564f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121270
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [6669c1a06bcc3ce31c9c17c714fdf2c2e0e25360]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I99d8b2a831f54e9748954bdc946f0f29b250a6a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121265
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [ba4244e834dfdac5488023cc2f62bb83fbd2d011]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic00ecbb8e482b8e666f27db73539d65e54ec7c51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121264
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [349c5cacedccbfbb71846ae3b276285d54c0d0b8]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I7e52d33f0e94f4bad03e9e3881b54e90172e12a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [4099f7102a78f552eb85fadda7851db3c73b2d0f]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ibeeef815afea9bee3cdf6b6de17de4f836b00351
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [9dc6fae25e6bf919d14b4bcb262a359893771ac0]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I50411f90940c1225b6164d4eadcb9dbd14e9e2b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  László Németh  <nemeth@numbertext.org>  [97440778670d6b471d8165eb9f86def08e1b8602]

        tdf#144173 sw track changes: keep format of hints
        
        When a text has multiple character formatting settings
        enabled and a new one is applied with tracked changes,
        only one of the former settings is restored upon rejecting
        the changes.
        
        Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892
        "tdf#143918 sw: fix reject of multiple changes".
        
        Change-Id: I6f3fb52dbd536efaf084b1fc5b8032658353af91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121012
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [89e8786f932793a9aadc7d8a7d2eec4fa2a081c4]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ie994deb224ef403a42108656c7ad142ad9447d5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Pranam Lashkari  <lpranam@collabora.com>  [e60a94f016bb26bf0b388899f6a3261ec9df5225]

        LOK: avoid writing freeze pans data to file if not set
        
        Change-Id: I9bc4023ae1673a2ae68db584357fb6c6643342a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121065
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2021-08-30  Noel Grandin  <noelgrandin@gmail.com>  [8a4df9024faf07d97185b5d609f961a381232348]

        flatten DocumentRedlineManager::AppendRedline a little
        
        Change-Id: I2801aad45f11bd9b8a97fc63c2f005f946a02bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a4b788c1b8461a83a54589fc783f7e0355e6a79]

        convert this script to python3
        
        Change-Id: I4e496ab11f4ee2576b2f7e88d02f884b3b19c91a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121229
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [38b934ad1c1184ecdea9f429866237966a694531]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ife47559f456e17175eccf4bb6509688b61972d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121235
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Miklos Vajna  <vmiklos@collabora.com>  [8940eb8d8c1f8b50eff79d3ee3847b683d6d303a]

        sw: prefix members of SwGlossaryHdl
        
        See tdf#94879 for motivation.
        
        Change-Id: I5f03b6646b77242f31a8c0c0510fe88f6f2af522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121262
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [bc262f5fb357a3b854011aabb3f86bbead25b22a]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I3ced8d55a7c725e8efb80a49b4fa7e4c84d1be5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [01542407d216a850cbd0894f025c598d2c8c40b5]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: If76fdb6d83d1d2d71baee5f892cd239806a6fd61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121236
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  tushar  <tusharrai282@gmail.com>  [a0b836f73f249138a231f01c1d0289a9b67dc62d]

        Add Swap Rows Transformation.
        
        Entries of given rows are swapped after applying transformation.
        
        Change-Id: Iac9da1b15781656b4127bf74f6a95e8cb82fa3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120556
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins

2021-08-30  Caolán McNamara  <caolanm@redhat.com>  [fa39da583f6b2daee860859cdca69cf174b2b55f]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I941bb60c1d06189491964004fb98d0d21fc75c49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [a2c8195f465a2e4346169d2b586c34e8fbed253c]

        tdf#74702 vcl: introduce GetSystemTextColor()
        
        Also rename DrawFlags to SystemDrawColorFlags, added a unit test.
        
        Change-Id: I3cb74b278e43561d1055b3b55b9730cdbdea51aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113559
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-30  Chris Sherlock  <chris.sherlock79@gmail.com>  [229136b7c9363bc758c9e925ccfd0c9bb34ceaec]

        vcl: move TextLayoutCache into vcl::text namespace
        
        Placed TextLayoutCache function into own source file and moved it into
        the new vcl::text namespace. With this patch we will have these vcl::*
        namespaces:
        
        namespace vcl::bitmap
        namespace vcl::CommandInfoProvider
        namespace vcl::detail
        namespace vcl::drawmode
        namespace vcl::fileregistration
        namespace vcl::filter
        namespace vcl::font
        namespace vcl::graphic
        namespace vcl::lok
        namespace vcl::pdf
        namespace vcl::table
        namespace vcl::test
          namespace vcl::text
        namespace vcl::unohelper
        namespace vcl::unotools
        
        Change-Id: Ia38c2d73715676a924cdbb0de6308a72a40ec3b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121206
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [d350a1364a1c34b96d00f2f716c44882b7b57fe9]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic07027c4bca00df823ac06066b25606a65fe1e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Eike Rathke  <erack@redhat.com>  [451e4abb5377f6d923860e9adfce82d46f31e049]

        Resolves: tdf#117868 CSV: support sep=; and "sep=;" separator setting
        
        When reading CSV the separator (any BMP character) is taken from
        an initial
        
        sep=;
        or
        "sep=;"
        
        single field if that is the only row content.
        The quoted form is preserved as (unquoted) cell content, of the
        unquoted form the separator is discarded as contextually it is a
        real field separator.
        
        When writing CSV an existing single top left cell's content if
        that is the only cell in the row is adapted to the current
        separator (any BMP character) in the quoted form
        
        "sep=;"
        
        (if quotes / text delimiters aren't set empty ...) and always uses
        the ASCII '"' double quote character.
        
        Change-Id: I854477bd0f9d1cafaa51a2130b616292347519cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121232
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [182971bd9fa8c9057d1478af15a14b2b6357a2a4]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: If60d289eab82ebf8be309526491182330f119a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121231
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [16b24385331d85763759291eccfb0344a65e7540]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I6d01c819766520eb5c0a8190fa2e9f6f99006548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121220
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [72da4c623baf60eb2b7073697cd36ffb3022847d]

        ofz#37796 limit to numeric_limits<int>::max
        
        Change-Id: I6e09226fad1e566ba2758d0084042b603b84d221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121230
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [9f9d075f3f814a2c6c53063cb7f3a582f6bff514]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I9f467529458e303af371a653ef6412413db2f8a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [8d07df00118b5ac82880fdea000df350c3bf379c]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ibe0f0307d939d8ce54ffdf54ae42948bfa22303a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [d9dc4071d0d4064449a6bdbfd176445abd97fc86]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ic2179724b182262c01b9e5993234b1d89ccbe49f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [11f430fd5d6b866483c8bde646f3ef2746e980c0]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id7d210c5759c117a398027b188c5e4f51667c505
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121225
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [567c6c123094bf58c14ddac94e962cc62bc839b3]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I47a7b783a28c36f516334e3d8953127d45d56152
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [53e02d723d1e91f94d6788d1b2d3c637b2e359f8]

        be a little more readable
        
        Change-Id: Ic0f7dd5ead93aa7e3178dcc5128df615d1d7a4e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121218
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [03a04f350594e3b1372acb880ca5e23ea3e48146]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8422da20656626f2512a63a8a4282b2f09c79e37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121217
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [d3581066fb0db1b9088a766d9577040ccda10021]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib1bed182b1b49076a47c7bc2bf29b9a45a21fbbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121221
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [ba367806deb5e5b63996f2965fe3d9677921af26]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I649e8b8fa0d1752f0f4b0b6b688cea8ae945bb87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121186
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [bf5fc53cf7f35f7c39d0d8d8b871096b8ca2d042]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ifecfcf3ff4c884d7bd65de7186c7d8db06b6b57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121219
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [ad33f461929e99b496869b831f83159bfb7ac40f]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I136816837eddcb1bf81c23b6f4fcfa65e9335629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121187
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [7362351b62b0f3c2967e11b96b9c55a94ee68925]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4a34981e6597743f9f3a9ad6ca063cb347a68d14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121212
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [e251bb6a6ce846944595954d38595a807689fa0b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id3acc87a697a61bcf3794745846071bc99fc8d8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121189
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Caolán McNamara  <caolanm@redhat.com>  [5ecc01990dbdd21501d49a1a5a66a2348d0e229b]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I35210b36a927b96f29d0a07a3cf63e226e4c4453
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121191
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-29  Noel Grandin  <noel@peralex.com>  [e3ea0e32657a41b48d9d9d28f6ad15af4c2a7abc]

        tdf#135683 speed up large writer table load
        
        no need to do this reregister check during import
        
        Change-Id: I254ad24f1802e9cee51786ce5e3253d62c74829f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-29  Noel Grandin  <noel@peralex.com>  [3b15eda58e11a3a46319d4e0489391cb78cec0ab]

        no need for a vector here
        
        Change-Id: Ie456abf9afeda887366b5be2f0161e3ec464e36e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121211
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-29  Arnaud Versini  <arnaud.versini@libreoffice.org>  [34cba9eefa710b053da817dd2642d2376691824e]

        basic : remove BasicManagerImpl
        
        Change-Id: Ia2b2c5fdf7d61e0853f181a38840c5ae263f5c9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-29  Noel Grandin  <noel@peralex.com>  [0d25d7418d66ce17900f68623dd69e3f6789392e]

        micro-opt: prevent some vector re-allocs
        
        Change-Id: I183af9765f5afe6c552a83e8f4fd4d7edafe0427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [17ea551989005433bab1a9351ecd6fb6c283caea]

        tdf#143919 Revise Criss-cross diagonal border
        
        Change-Id: I0c018fb74d196101d53b794e960bb446823bcada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121188
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-28  Julien Nabet  <serval2412@yahoo.fr>  [74d35e143d557a7e65c4443f5b80cb9d406b1fa1]

        No need to keep PUSH_ALLTEXT (vcl)
        
        Change-Id: Ied83de6e2768998a76aaf28972c45e82f9a95a57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121192
        Tested-by: Jenkins
        Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-28  Noel Grandin  <noelgrandin@gmail.com>  [30bd841e2d8f47e49711d928d600573339708b03]

        avoid unnecessary OString to OUString conversion
        
        speeds up loading some writer files
        
        Change-Id: Ia6dddf3a9e8990b8cd3f600c86c758573c7ea2ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-28  Noel Grandin  <noelgrandin@gmail.com>  [426930d0c4bd6f782a04a92e8a36e92cd65e186f]

        speedup dynamic_cast to SwTextFrame
        
        which is a hotspot in loading some documents
        
        Change-Id: I7f1c48305cd40bcd9bee4baf219228f10cc297b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121184
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-28  Noel Grandin  <noel@peralex.com>  [69e0567e118f00f299b6aac645c249521eb0629f]

        tdf#135683  speed up layout of large writer tables
        
        by making dynamic_cast to some SwTable* types faster
        
        Change-Id: I5c5b2525ecfcdf3c0f648f32b4ccc21ba5ac40fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121193
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [9ca9faabd4009698096ccde03c45e9c203804c80]

        vcl: move TextLayoutCache to own module header
        
        Add a unit test for TextLayoutClass - it basically tests that script
        runs work as intended.
        
        Change-Id: Ie65acf06f13c89c182d93b20fc9a28866db2330c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115470
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-28  Chris Sherlock  <chris.sherlock79@gmail.com>  [9a58ec3f6f65da27e3b26e1173b6661b743e66a4]

        tdf#74702 vcl: remove GetOutDevType() from ImplNewFont()
        
        Change-Id: I59a14b0c392098761f9304708f4859f7e2381c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115469
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-28  Caolán McNamara  <caolanm@redhat.com>  [bd555ee0ebc94bfffa41ac5d5eede580f330a7f7]

        ofz#26357 Infinite loop
        
        Change-Id: I914d5c8e53e226567f48b084b1cdb55721a58359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121182
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [a12523644802f715ca57774b75f84e327dc221f7]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: I48e6fb31df732805423b89ed91b6e4363a69b668
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121150
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [05ff3d67d0e2e436406786c949eb7cfca107ba33]

        Fix typos
        
        Change-Id: Ie4e2ef5a884b51250863d3384d5e703232f31258
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121179
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [fe6f33f7818eb8245b2b54543e96b9ff989c69b9]

        Remove duplicated include
        
        Change-Id: I139b584c374cf950d2808777f0a78dbfe99269ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121178
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [b513ecce3e00e512947cd2d9fd61d1b80ba0d4bb]

        Related: ofz#27296 OOM std::map->std::vector
        
        dbgutil massif peak of 3.1G -> 2.7G
        
            GB
        3.117^                                                                #
             |                                         :::::::::::::::::::::::#
             |                                      :::::                     #
             |                                    :@:::::                     #:
             |                                  :::@:::::                     #:
             |                                :::::@:::::                     #:
             |                              :::::::@:::::                     #::
             |                            :::::::::@:::::                     #:@
             |                           ::::::::::@:::::                     #:@:
             |                        :::::::::::::@:::::                     #:@:
             |                      :::::::::::::::@:::::                     #:@::
             |                    :::::::::::::::::@:::::                     #:@::
             |                   ::::::::::::::::::@:::::                     #:@::
             |                 ::::::::::::::::::::@:::::                     #:@::@
             |               @:::::::::::::::::::::@:::::                     #:@::@
             |            @::@:::::::::::::::::::::@:::::                     #:@::@:
             |          ::@::@:::::::::::::::::::::@:::::                     #:@::@:
             |        @:::@::@:::::::::::::::::::::@:::::                     #:@::@:
             |      ::@:::@::@:::::::::::::::::::::@:::::                     #:@::@::
             |    ::::@:::@::@:::::::::::::::::::::@:::::                     #:@::@::
           0 +----------------------------------------------------------------------->Gi
             0                                                                   116.7
        
        --->
        
            GB
        2.718^                                                :
             |                                         @######:
             |                                       @@@#     :::
             |                                      @@@@#     ::::
             |                                   @@@@@@@#     :::::
             |                                  @@@ @@@@#     ::::::
             |                                :@@@@ @@@@#     :::::::
             |                              @::@@@@ @@@@#     :::::::@:
             |                            @@@::@@@@ @@@@#     :::::::@::
             |                           @@@@::@@@@ @@@@#     :::::::@:::
             |                         @@@@@@::@@@@ @@@@#     :::::::@::::
             |                       ::@@@@@@::@@@@ @@@@#     :::::::@::::::
             |                      @::@@@@@@::@@@@ @@@@#     :::::::@:::::@:
             |                    @@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@::
             |                  @@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@:::
             |                @@@@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@::::
             |              @@@@@@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@:::::
             |              @ @@@@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@::::::@
             |           :@@@ @@@@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@::::::@:
             |         @@:@ @ @@@@@@@::@@@@@@::@@@@ @@@@#     :::::::@:::::@::::::@::
           0 +----------------------------------------------------------------------->Gi
             0                                                                   34.29
        
        Change-Id: Id56615e554d07a76a6a87476a40cc6190c0555da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [a7667f53c23bc88ed645f84a19896bc45f748f2a]

        we are going to remove the entire row anyway
        
        so don't iterate over the cells explicitly dropping them
        
        Change-Id: If0de504ac9711d1e6a757cdd15574f15585ca928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [8024118d5c9ac964e35e8c4163ca14a5cd78cc3d]

        clang-tidy:readability-redundant-member-init
        
        Change-Id: Ibeff6e5cbc20ab86b1e9cb96292acb340849ede3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121149
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [707ac13a3f700c8e4a7f08bdcd5d5321d0a28bc5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 04f49b69b26dc5d9cb2939f86b7c10653b7c36e6
          - tdf#116576 Fix the description of the PHI function
            
            Change-Id: Ia15cadc19186519767044b1d75a5e033f0096ebf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121058
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-27  Heiko Tietze  <tietze.heiko@gmail.com>  [3170799ce2506b9251609fb1e675f8ba98241cc3]

        Related tdf#119931 - Fix accessibility warnings
        
        Change-Id: I69787778f11217a55daa1489c142561db5efce19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121139
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [09156034d3fe980a62dd5bd78655e49d0566c22d]

        these checkboxes are being used as labels for the menubutton
        
        so describe that a11y relationship
        
        Change-Id: Ia48d928222159399e1f0a3cdd977447b6c861294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121176
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [05c384cc087a32b65e8ecb1bdf277f1ff063c8b6]

        change the extra config colors to match the application ones
        
        these extra ones are dynamically appended to the static set of the
        colorconfigwin.ui so adapt them to the changes of
        
        commit 2f706b1e91396cbe044c20fab79772dfc081a340
        Date:   Fri Aug 27 11:46:57 2021 +0200
        
            Improve accessibility for application color settings
        
        Change-Id: I5a458ea509dfffc147b533d38458465df18869e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121174
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [6f58624ed8e9a63de69029ba380079175ae54c87]

        these GtkMenuButtons need label properties
        
        Change-Id: If8dc1112115aa6c2f3074d826a26ff1c87568173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2a4ab5d82bb23512338386aa0207bdb5dcdd3d10]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a0c6f819af67ad51e9d6377119e6ea0d2b50e3f
          - tdf#118538 Add multivariate regression help page
            
            Change-Id: I1f9b2584475e540a70a1643023fe61243ad2c543
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120969
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-08-27  Szymon Kłos  <szymon.klos@collabora.com>  [b4d1bed49e0c262f90e9e3f720dd9816d57d3b99]

        Rename AsyncColorPicker -> AsynchronousColorPicker
        
        Change-Id: If26865ea063df3052e6ba61642fe36f5a1a47929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120735
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-27  Michael Stahl  <michael.stahl@allotropia.de>  [4bf04dea9afb30a9395e80b07a81d1908937ee8b]

        tdf#128106 sw: copy bookmarks at start if whole node is copied
        
        The CrossRefHeadingBookmarks are always at index 0 so copy them if the
        selection also starts at index 0.
        
        This happens in SwDoc::SplitDoc() for the 2nd etc. chapter.
        
        Change-Id: I4765d497e65d3c8257f7eab59b8ba2088688967e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121147
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-27  Michael Stahl  <michael.stahl@allotropia.de>  [3608de9a3647294361c64b923b1ae413ad9755df]

        tdf#128106 sw: copy bookmarks in SwDoc::SplitDoc()
        
        Change-Id: Id35b8771b456b162ca653423d02788275a79443f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121146
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-27  Jean-Pierre Ledure  <jp@ledure.be>  [e4a3c4ba511724bcc8997249a921da609345410b]

        ScriptForge - (SF_DialogControl) add management of table controls in dialogs
        
        With the method SetTableData(), feed a tablecontrol
        with a sortable and selectable array of data.
        Columns and rows may receive a header.
        Column widths are adjusted manually by the user or
        with the same method.
        Alignments can be set as well by script.
        
          oControl.SetTableData(DataArray, Widths, Alignments)
            DataArray: the set of data to display in the table control,
              including optional column/row headers
              Is a 2D array in Basic, is a tuple of tuples inPython
            Widths: the column's relative widths as a 1D array,
              each element corresponding with a column.
              If the array is shorter than the number of columns,
              the last value is kept for the next columns.
              Example:
                Widths := Array(1, 2)
              means that the first column is half as wide as all
              the other columns.
              When the argument is absent, the columns are evenly
              spreaded over the control.
            Alignments: the column's horizontal alignment as a string
              with length = number of columns.
              Possible characters are:
                L(EFT), C(ENTER), R(IGHT) or space (default behaviour)
              Default: LEFT for strings, RIGHT for numbers
        
        Impact on existing properties: ListIndex, Value
        New properties: XGridColumnModel, XGridDataModel
        
        All properties and methods are available from user
        scripts written either in Basic or in Python.
        
        Change-Id: I70582cd0ba48ee3b9b9a292d8a47dbc1229b1fe6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121148
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-08-27  Stephan Bergmann  <sbergman@redhat.com>  [d9e7a8dd1cb4859a4d2252a2baf697eea56fecea]

        loplugin:external (macOS)
        
        Change-Id: Iedf17f6e075fb06b767359ad5ffbd3cebbea3188
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121144
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-27  Stephan Bergmann  <sbergman@redhat.com>  [a398dcdcfb27e4a2eac93c66dd609ecd00d6e2b0]

        loplugin:nullptr (macOS)
        
        Change-Id: I5fc54c9005fbada4184c520d447276be2df16f0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121142
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-27  Stephan Bergmann  <sbergman@redhat.com>  [c7c2b90ad4ed88856699dae2839a3437ec3a9c77]

        -Werror,-Wdeprecated-anon-enum-enum-conversion
        
        ...similar to 5b8f505cd11517362b2c4a29c87d802a286a677d "Avoid
        -Werror,-Wdeprecated-anon-enum-enum-conversion"
        
        Change-Id: Ia9e8994cdb74ecdb078f347c864a89ad40321609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121143
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-27  Mike Kaganski  <mike.kaganski@collabora.com>  [fc87a30e64f28d5f7f19a4220910681e918244e3]

        Fix this FIXME
        
        Change-Id: I4449d3c87adbcb94c721799aa6de1d615eb7041f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121070
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-27  Rafael Lima  <rafael.palma.lima@gmail.com>  [92603fe0a0dda1bd05558f8f1b99b83038ecea8b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e447138612f8e266c8a997813f9f673efa4ebb1
          - Create help page about how to Remove Duplicates in Calc
            
            This patch creates a new "guide" page on how to remove Duplicate values in Calc.
            
            This is a question I see being frequently asked in forums and I could not find any entry in the Help that explained how this can be done.
            
            Change-Id: I6e115739752fdc1f5aa35cf45f041655b3e614be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121067
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-27  Heiko Tietze  <tietze.heiko@gmail.com>  [2f706b1e91396cbe044c20fab79772dfc081a340]

        Improve accessibility for application color settings
        
        * Lengthy grid replaced by some frames
        * Order of sections updated to show less important on bottom
        * Accessibility suppressions removed and solved
        
        Change-Id: I150603d141961cf579c1853ea3e67499da81c596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121137
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-08-27  Miklos Vajna  <vmiklos@collabora.com>  [9ea594ffcf4f807306440e4628eecca8c75be8ee]

        tdf#137363 DOCX filter: don't loose  <w:ilvl w:val="..."> of paragraph styles
        
        This adds doc model, UNO API and DOCX import/export for this feature.
        The rest is not yet implemented (i.e. no layout, UI, etc.)
        
        An alternative would be to grab-bag the list level of paragraph styles,
        putting it to the doc model directly has the benefit that this is a step
        in the right direction.
        
        Change-Id: Idf7157e8a4177b4c2286d3cfb3d5acf2df845076
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121141
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-27  Regina Henschel  <rb.henschel@t-online.de>  [c56178f0daf69abb362e6216f51b6e1f5aff1777]

        tdf#112450 correct points and size for polyline in VML import
        
        The points in file source might have units. Decode was missing.
        
        maWidth and maHeight are used in ShapeBase::convertAndInsert(), and
        moCoordSize is used in PolyLineShape::implConvertAndInsert(). So
        ShapeContext needs to provide both in case of importing a polyline.
        That was missing.
        
        Word writes the size into the coordsize attribute of the v:polyline
        element. But from VML specification it need not exist, but bounding
        rectangle of points has to be used. That is added too.
        
        Unclosed polyline cannot be filled in LO and ODF, a fill is only
        possible for a closed polygon. LO defines a sequence of points as
        being closed, if first point == last point. The import is adapted
        to that behavior.
        
        Word allows an unclosed polyline to have filling. That cannot be
        represented with a simple PolyPolygonShape but would need a
        CustomShape. Because the user cannot yet edit points in a CustomShape
        but can do that in a PolyPolygonShape, the v:polyline element is
        not converted to a CustomShape on import and not to DML on export.
        LO would first need an UI for editing points of a CustomShape.
        
        Change-Id: I23d08fda2005f8b36488e1d9ba32e565d8a0f803
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121042
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-08-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [6146409978e1a2834c85acff33485f69164ae735]

        vcl: remove unnecessary OutputDevice::GetGCStackDepth()
        
        Change-Id: I067299d028a0f25314a4312462ee8e7d0e1f92bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115464
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [ec52161eb5bd71ee5bcb1dd6cf0cb596da39fa48]

        vcl: move OutputDevice fill functions to fill.cxx
        
        Add unit test for SetFillColor(), IsFillColor() and GetFillColor().
        
        Change-Id: I64b3b15d6c6a0062af716ecc02d0414ae8a9f134
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115461
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [1864e6353179678a2ca1a175c203fd9e0cc5a580]

        tdf#116315: sw_uiwriter3: Add unittest
        
        Change-Id: I29aa953d8541d45b003703ba91c143fc9760ceac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121135
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-27  Stephan Bergmann  <sbergman@redhat.com>  [8d8e5ab9193785acc4e1cb05e0db7f97afde1e2b]

        Use PSAPI functionality directly
        
        Dynamically trying to obtain the two PSAPI functions was apparently originally
        done because "This version can fail because PSAPI.DLL is not always part of
        NT 4 despite MSDN Libary 6.0a say so", according to the comment added with
        961512bd9ae008fdd8ab5cdf1ba6b5d25ffb0429 "#94875# Added additional method (for
        NT4) to determine the module containing an address".  (That comment was removed
        again in 515d2579d305a6127c6c194319a58eac62437e33 "Replace legacy dynamically-
        loaded functions with statically linked ones", which curiously left the dynamic
        loading of PSAPI.DLL in place there, though.)
        
        <https://docs.microsoft.com/en-us/windows/win32/api/psapi/nf-psapi-enumprocessmodules>
        states that the PSAPI functionality is available in "Kernel32.dll on Windows 7
        and Windows Server 2008 R2; Psapi.dll (if PSAPI_VERSION=1) on Windows 7 and
        Windows Server 2008 R2; Psapi.dll on Windows Server 2008, Windows Vista, Windows
        Server 2003 and Windows XP".  I do not find any mention of PSAPI_VERSION across
        our code base, so assume that PSAPI_VERSION=1 would be some legacy mode that we
        do not use, so with our baseline of Windows 7 (cf. README.md), relying on the
        PSAPI functionality being available without adding anything specific to
        gb_Library_use_system_win32_libs,sal should presumably be OK.
        
        Change-Id: I55ab29be2a3ee3984c6987e953819cb2e92e4aa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121136
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [c4709b6192340a4d5a82bf156a7342aba6aa99a1]

        tdf#59820 - Search for the longest substring in a multiline string
        
        In order to determine the optimal column width of imported ASCII files
        in the simple text mode, search for the longest substring in a multiline
        string which is determined by a line break.
        
        Change-Id: I2c606dd97549455009b9f8fad2b8ec4386b7b7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120772
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-27  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [72590c55ad6c699b34dc404542abc3f60bc32a09]

        tdf#143904 fix direct character formatting copied into paragraph level
        
        Currently, Writer copied the direct character formattings, and applied them on paragraph level, when inserting a new row in a table.
        This bug is a regression from 498d2b82187ec3ff58f076e0d15741e64c0505ba .
        
        Explanation, why this regression happened:
        MSO Word uses a paragraph mark symbol (i.e the control character than can be configured to be shown), which is imported in Writer as a 0-length hint.
        To fasten up the import of DOCX tables, the core applies the formattings from this 0-length attribute on paragraph level, directly before inserting a new row.
        All in all, to solve this bug, we needed to make sure, that we only copy the formattings, if it is from a 0-length hint.
        
        Change-Id: Iba52e9318cc588feda559339e42897568d009806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120624
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-27  Heiko Tietze  <tietze.heiko@gmail.com>  [67879304f61252838a6b2e2549d7205b445776f8]

        Resolves tdf#142115 - Make color of NotesPane customizable
        
        * Color follows not Writer's section color and General's
          object boundary color for the separator line
        * Section color adjusted to Gray 1 for Dark scheme
        
        Change-Id: I5748c1ac3c0a4997edfffac786e3d247641fc637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121122
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [659d8d14037706f52ac2106113aedc27334c7e1f]

        Resolves: tdf#143159 reserve space for 6 characters/digits
        
        Change-Id: I44bcdf55a9b1d34e046b93e6a15f4019a925844d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [1748ebf646b22278a618534823a10933ce0f5fa1]

        ofz: Integer-overflow
        
        Change-Id: I4142f48db0f756872ea75e1c39cda6195bdddf43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Caolán McNamara  <caolanm@redhat.com>  [82a5d94b47b7817e93330049a5926c78900df5fb]

        ofz#37660: searching in wrong parent for table
        
        Change-Id: Ifa1b70fa0ccc706cec52b318cdfba59f5da2b4d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [7246759822aff30e4e4e1bca7949eae3b0d960ef]

        tdf#143940: the style index might be -1
        
        Similar to 52aebe6986bcec07071adb3f94d6c09fea147044
        < tdf#138466 Crash when creating different scenarios >
        
        ExportColumns calls GetStyleNameIndex which might return -1
        so check the index is different than -1 as it's already done
        when calling ScFormatRangeStyles::GetStyleNameByIndex
        
        Also move fix for tdf#138466 down the stack to be consistent
        
        Debug builds will still assert, see coverity#1438402
        
        Since 5e777f23fd0118f6649f0d9e30eb77a72f1099e4
        < loplugin:useuniqueptr in ScColumnRowStylesBase >
        where the nIndex < 0 check in
        ScColumnRowStylesBase::GetStyleNameByIndex was removed
        
        Change-Id: I084bfa04c39f37cb325c3b3df76801b3abdea994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [3cbe3a0259bea4dec70e72191ec3c03441926a07]

        tdf#101083 speed up SVG rendering with pattern fill
        
        By pushing the work down to the vcl layer, which has much more
        efficient ways of dump lots of copies of a single image
        
        Change-Id: Ie83fa56828df91a23b4b29934360ad80d1793c3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117162
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-27  Chris Sherlock  <chris.sherlock79@gmail.com>  [cab2f3790517c6f2c77686869b305d66a1e04fb9]

        vcl: SvmConverter is only used in vcl filters
        
        Change-Id: If198b143d520937193b63985b4c21da0e29308bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120834
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-27  Miklos Vajna  <vmiklos@collabora.com>  [0cb4818f079e5916e2abfb13a04599559dcfa796]

        sw: remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: I7082c51ce73b69f27154fe7308df913a38973100
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121129
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [47df2d88d3dee617d76d05e4fcf6063e57a3b199]

        Take the PDF graphic rendering DPI into account when exporting
        
        Change-Id: I1d3465fc7357e6991161d5a96bcd70c53c55f244
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121087
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-27  homeboy445  <akshitsan13@gmail.com>  [c46d2c25ee790d02a97ed6bc7403571a2a0823bd]

        backendtest: Test Drawing Bitmap other than 24bpp
        
        This test draws bitmap formats other than 24bpp -
        namely 32bpp and 8bpp greyscale.
        
        Change-Id: I1b21214429be08fc7cf1eb086c2ad8946780f481
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119371
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9ed35109abb4179a3ab77498f550b4b9868e9cbc]

        Add info on icon sizes for theming
        
        Information collected from telegram chat by Rizal Mutttaqin, andreas k,
        samuel_m, quikee.
        
        Change-Id: I0d61f6b899b261478b6d40386ac5604aa1a3cfdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121088
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [1fb4beaf16654f97b1a64cb3f01f643167b36b22]

        remove unused suppression
        
        Change-Id: Icd46ff6b6ff1ccf6be8248482d9f5fbbce073445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121120
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [02e48e4c27b2f55bd287717a12ebc68277878b75]

        tdf#143169 - Remove additional row header width
        
        If the table control has row headings, add the extra row width only at
        the beginning of each row and not at the end. Otherwise the renderer of
        the table control adds an additional column with the width of the row
        header of the table.
        
        Change-Id: I0acb67f21d0ad756ed53c56690d3f2deb50de8e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121038
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [d2015efaaaa1e98454c6e9e1b6083bd7103fbab3]

        tdf#139660 one of the group needs to be active
        
        in this case using ToolButtons instead of ToggleToolButtons will work ok
        
        Change-Id: I806a8fc409ae346dd6734be13d69c4b171e54c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121121
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  4k5h1t  <ask160203@gmail.com>  [0bae96d56134e2cd2a6fe101fc053cea48c1e017]

        tdf#143148: Use pragma once instead of include guards in compilerplugins
        
        Replace include guards with pragma once in several header files in compilerplugins
        
        Change-Id: I9cc586977dc7ade9278d93396c3efcd13acba286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121089
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-26  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [fceae764d6bb8d54b138eec79b79c71461db6c20]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 230ace24c9acaf135c5748cdda76e7bdfa0a3eda
          - Add a couple of missing definite articles
            
            Change-Id: I5b4c31b0cfc7eac0b82e45bcc8f9407df33a91fe
            
2021-08-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [a1a83b6b3b4459de353e0cdc8cdf402370c0a5c4]

        tdf#144037 Qt5 just close popup with mouse outside
        
        How hard could it be to close a popup window when losing focus or
        clicking outside of it (AKA tdf#143114 problem 3)? At least with
        Qt it feels like solving an NP problem...
        
        So don't always force-close the popup window if clicked anywhere
        on it. Seems to be consistent with gen and gtk3.
        
        Change-Id: Ia1c231c0b51a55bec2c587feffcf14bb4b4cee55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121093
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-08-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [923b30aa27ceb377d6a540c012000e89ce5db31e]

        tdf#144008 Qt5/Kf5 create frames in the GUI thread
        
        There was a 50% chance my pick would have been correct... ok,
        just half-true, as in hindsight, I should have preferred the
        secure variant using RunInMain to start with.
        
        I thought I could use some templated class functions to get rid
        of all the copy and paste, but that looked even more ugly.
        
        P.S. if you wonder - like myself - about the code formatting in
        Qt5Instance::CreateFrame: that if from clang-format.
        
        Change-Id: I3a6b0c12c9d71ad8e777ed82526d1515a249832c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121091
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [f72013ca65c7a33991d5fb124b919fe7cde269e2]

        use max of avg digit or 'average char' width to measure Edit space
        
        instead of the x-width
        
        this is similar to what gtk does
        
        Change-Id: I2806939a09b275a3060ddf693e2763238a4e075f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121118
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  DaeHyun Sung  <sungdh86+git@gmail.com>  [c216777e8add833be5ee49bc98197ea21cbb4da0]

        tdf#143526 Korean numbering import/export support
        
        add support for the new NUMBER_LEGAL_KO(korean-legal) numbering format to various import and export filters.
        fix support for the HANGUL_SYLLABLE_KO(korean-counting) numbering format.
        
        Change-Id: I7b7dafe7305da910784ae537e307f9bfd05319a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120509
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-26  Luboš Luňák  <l.lunak@collabora.com>  [2ca522fa2d3d1f80a9f12826f76028264be1dfa1]

        change some left,top,width,height usage in Skia to x,y,w,h
        
        Change-Id: I26e0f1f1c9aef795b040a191ffa9b725280eb63e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121080
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-26  Luboš Luňák  <l.lunak@collabora.com>  [55accad663d13dff73a0aa57c08ebd0297a8c0fb]

        add back getX()/getY() to tools::Rectangle
        
        581b2cf7960c48e cleaned up some usage of the class and removed
        getX()/getY(). But that means that the (probably most) common case
        of treating rectangles as x,y,w,h now doesn't work, and one has
        to use either left,top,right,bottom (which doesn't always mentally
        fit), or the IMO weird left,top,width,height.
        
        Change-Id: Ie9516f69af48490635346c76821be9a9eedd686c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121079
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-08-26  Roman Kuznetsov  <antilibreoffice@gmail.com>  [de399fdf22206f9402a0322ce4851be9cc5e901c]

        tdf#144030 Readme review
        
        Change-Id: I1500b2beacb88c0014495d98d8fb79090d7c9486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121052
        Tested-by: Jenkins
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-08-26  dante  <dante19031999@gmail.com>  [b0bf212fb90708edb8f7c092240d31eacacc8455]

        Correction on cpui flags
        
        Change-Id: I34781d98f614c1d5df97460fc2e7b59be3bb6512
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121090
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-26  Radhey Parekh  <radhey.parekh@gmail.com>  [b3f3f0cb2a5ea7873349f733b55e41c1cbc671dc]

        tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I8ccb5e43ac86ff2b8da94bd03e6fa50de0c33741
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120961
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-26  Stephan Bergmann  <sbergman@redhat.com>  [2d64e7c4de4d675a4d594e90347bead827af8500]

        Avoid OUString::createFromAscii on input containing NUL characters
        
        ...as it triggers the "rtl_uString_newFromLiteral - Found embedded \0 character"
        SAL_WARN in rtl::str::newFromLiteral (called from OUString::createFromAscii via
        rtl_uString_newFromLiteral)
        
        Change-Id: I6013062b961657561d67d8dbbf5b2a45816eed4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121086
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [0e34a52d8db3ea9c9e60af7c7348793dbc5d4d59]

        Resolves: tdf#144084 if not initialized default to FILEOPEN_SIMPLE
        
        which is a problem since...
        
        commit 43335776cfc18cdc7addf33250cffc886d384186
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue May 11 17:21:47 2021 +0100
        
            gtk[3|4] don't create File Dialog with buttons that need to be removed
        
            just create it without the offending buttons in the first place
        
        where we create without buttons because its hard, especially since gtk4,
        to remove unwanted buttons.
        
        Change-Id: Ib0337c412fa7e8210d3b1bf3261174c4ffac0a0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121075
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  Baran Aytas  <barannaytas@gmail.com>  [c7bc3f2ee22f6c5d00364947bdef7ece62a060bd]

        tdf#143148: Use pragma once in chart2
        
        Change-Id: I8ee7542d5be6839f55b3898da8bb275b3d7fe398
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120844
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-26  Stephan Bergmann  <sbergman@redhat.com>  [8ae94bafbb7405df093cfe13ebe61c0e61ea5556]

        -Werror=maybe-uninitialized
        
        Change-Id: I47d3a9327a88a75390f8bb18dfbf632ed97cac7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121084
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [46ac3dd4f3e7860d9701ff3aac12de13c243ec1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 726aca1551a75da04dfd8815947d904f96d9c37b
          - tdf#137084 Update Help Help page
            
            Change-Id: Ia86826bd87d709bec5acdaf6b0b8800f7aa9b8e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121085
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-26  Miklos Vajna  <vmiklos@collabora.com>  [5e9692564c6145a6662d49ad1735996d17bf1cd7]

        tdf#125743 sw: fix rendering of graphics bullet with linked images
        
        Regression from commit d72145f9307c732ced4a546ac1e5093ec7c1a982 (Move
        BackGraphicURL property & friends to BackGraphic + fixes, 2018-03-01),
        the problem was that now SvXMLImport::loadGraphicByURL() produces a
        Graphic that has its type set to GraphicType::Default, but when
        paintGraphicUsingPrimitivesHelper() consumes this graphic, it expects
        that the type is either a bitmap or a metafile.
        
        Fix the problem by explicitly loading the image when the default-type,
        origin-url-set case happens: this is rendering, so no problem to load
        the URL and that will give us the expected graphic type.
        
        This is also meant to keep the original problem fixed, since we only
        load images when painting, not during import.
        
        Change-Id: I951bc92d05bb8ec57d2ba6958c47947f8f9b5c78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121082
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8ced17a4f5039f8da2aecd99a9ec5acf131d381a]

        tdf#118538 Extended tips for regression analysis dialog
        
        Change-Id: Ib063540742f8fef44d2848d9cfe5f97deef072cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120971
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-26  Justin Luth  <justin_luth@sil.org>  [226ab4d444dbbf8a257b38e08b138713466fe7cd]

        tdf#135164 add unit test
        
        fixed by tdf#143605, but that was a bit different,
        so adding a specific docx unit test.
        
        Change-Id: I9f5a6b225277f1c1fdbfed7759919b3fd6e5dea5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121008
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-26  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [282b2d8bfd6fb16f58fb177910427b031dc80066]

        Sifr: tdf#143300 add diagonal border
        
        Change-Id: Ic01b845489701557d2c87e16c1c697d437fdbf1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120933
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-26  Radhey Parekh  <radhey.parekh@gmail.com>  [d27991cc8770d98c8ec2c892dd88756b1089bd6b]

        tdf#114441 Convert use of sal_uLong to better int types
        
        Beacuse EditEngine::GetTextHeight() returns sal_uInt32, this type of
        int is chosen for the local variables nWidth, nHeight and nTextWidth
        
        Change-Id: I9288946b0cb7b9227fe63371840d6bfb84ab829e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120894
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [2be207ed8969a96da8bdc0ffd7f2a2215233ee4a]

        crashtesting: crash on re-export of tdf137357-1.docx to docx
        
         #0  SfxPoolItem::Which() const (this=0xffffffffffffffff) at include/svl/poolitem.hxx:148
         #1  0x00007fff9d0454a5 in sw::util::GetPoolItems(SfxItemSet const&, std::__debug::map<unsigned short, SfxPoolItem const*, sw::util::ItemSort, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> > >&, bool)
             (rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, rItems=std::__debug::map with 0 elements, bExportParentItemSet=false) at sw/source/filter/ww8/writerhelper.cxx:411
         #2  0x00007fff9d1ceae4 in MSWordExportBase::OutputItemSet(SfxItemSet const&, bool, bool, unsigned short, bool)
             (this=0x7fffffff5348, rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, bPapFormat=false, bChpFormat=true, nScript=1, bExportParentItemSet=false) at sw/source/filter/ww8/ww8atr.cxx:351
         #3  0x00007fff9ce92a66 in DocxAttributeOutput::Redline(SwRedlineData const*) (this=0x59e44e0, pRedlineData=0x68110d0)
            at sw/source/filter/ww8/docxattributeoutput.cxx:3199
        
        starting happening at:
        
        commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8
        Date:   Thu Aug 19 11:47:53 2021 +0200
        
            tdf#143939 sw: track format changes of the actual word
        
        Change-Id: Idb2b07368233152db519e70627b43847c7392128
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [ca04310f3149e85cf4aaa0728168263f9c54f953]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I8bac670cb289d7b8636535c1b1fb2f4fc9f03afe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120965
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  Eike Rathke  <erack@redhat.com>  [61626cf179bf2166462e4e9d3222caaf388e81e0]

        Update language-subtag-registry to 2021-08-06
        
        Change-Id: I0a2b43f291ef15f0bdacfb33b5396658efd1ea2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121047
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-26  Stephan Bergmann  <sbergman@redhat.com>  [60b32d931da91a25e7f8912c36c48ba8302e6a43]

        Remove spurious odk/examples/java/MinimalComponent/BuildMinimalComponent.xml
        
        It had been added together with odk/examples/java/MinimalComponent/Makefile in
        ff4c86ff37af5136466d49a9fb394974ee62cb0f "Added an example for a minimal UNO
        component", and it apparently is an Ant build script that shall do the same as
        the Makefile.  However, it is apparently unused:  For one, it does not
        appear to get referenced from anywhere else in the code or to get mentioned at
        <https://wiki.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide>.
        And for another, it would apparently only work on Windows (using e.g.
        "${ODKPATH}/windows/bin/idlc.exe"), but would typically fail even there with
        something like
        
        > > ant -f BuildMinimalComponent.xml
        > Buildfile: C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml
        >
        > init:
        >
        > unoidl:
        >
        > BUILD FAILED
        > C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml:35: The directory D:\cvs\api\odk\WINexample.out\misc does not exist
        
        due to the hardcoded D:/cvs/api/odk paths.
        
        Change-Id: Idd020bcf1a2383295704b208d3ac2be047f270ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121050
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [ccd2de75987bae25b34a0d7d22322cada796bb3e]

        tdf#144089: sw: Add UItest
        
        Change-Id: I6ffa476180a58ba47268b4f4a8bc59f75738be29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121046
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-26  Luboš Luňák  <l.lunak@collabora.com>  [a0edcc68f94915a78fcc08e70d2cdd752abd9ebb]

        update Skia to chrome/m94
        
        Updating to m91 or newer required handling the problem with Vulkan
        crashing, but that's been finally fixed by the previous commit.
        
        This Skia version also requires at least freetype-2.8.1, so disable
        Skia if that's not available (LO's minimum is lower). Additionally
        patch out Skia's use of TT_SUPPORT_COLRV1, which seems to be
        an unstable freetype API from the git version and it doesn't even
        compile with the latest stable 2.9.11 release
        
        Change-Id: I4a17effb912468c43fc7cdb69fe453062e4d2447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120967
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-26  Caolán McNamara  <caolanm@redhat.com>  [b67f42c4c2906b7059b93d748c8efccd588b1e1c]

        ofz#35646 Indirect-leak
        
        Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-26  Tor Lillqvist  <tml@collabora.com>  [79c9d11d7ae2272f4190292757fef3803c722317]

        There is no --disable-neon configure option any more
        
        Change-Id: I8a3845ae0b811a43830c7bb166cc2092b7e163b1

2021-08-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [2694a666b62701a8c0e546151c41f9c30aba00da]

        Fix crash when drawing shape
        
        Fallout from 75cd2b0fa71c73ae815b80d8e42328024ea63555
        
        Change-Id: I455519126d11bee1b809f9fd9476b2fdd0f1a524
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121034
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-26  dante  <dante19031999@gmail.com>  [5b9cf5881ef53fac5f1d8376f687dbadf9d3cf2b]

        tdf#142307 - Upgrade SSE2 sum to AVX512 sum with Neumaier 1
        
        This part focuses on allowing it on replacing arrayfunctor
        By thefault it will try AVX512F (1,17%)
        If not available will use AVX (94,77%)
        Use of AVX2 (82,28%) has been avoided even if the code could been more compact
        Source of hardware statistics: https://store.steampowered.com/hwsurvey
        
        Change-Id: Iae737a565379e82c5f84f3fdee6321ac74f59d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115675
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-26  Miklos Vajna  <vmiklos@collabora.com>  [fb1233d77500413ba237c335a84773d8a6f8e381]

        CppunitTest_sw_ooxmlexport6: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I3f5dbe43d94eba90a44b39180239e7aed8242b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121045
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-26  homeboy445  <akshitsan13@gmail.com>  [dbca6679aa40f65a67264f416d20d1434f6a926d]

        backendtest: Intersecting Rectangles Drawing test
        
        This test intends to test the even-odd filling rule by
        testing if the intersecting rectangles have been filled
        accordingly to the rule or not.
        
        Change-Id: I0fb7f115a25476cc38e8bec5cd02737aea3c0316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119098
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Mike Kaganski  <mike.kaganski@collabora.com>  [c3a7edad85ec22fa4dac372da9e0b36d02efbfc4]

        Missing include
        
        Change-Id: Idc533f1849c8be44ed04d3ed823c7f69c12c2d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120988
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f108b53e158dcc15db1fe93a483fb573fd522274]

        vcl: move X11SalInstance::CreateSalBitmap to salinst.cxx
        
        X11SalInstance::CreateSalBitmap doesn't belong in the salbmp.cxx,
        but where other implementation of X11SalInstance is.
        
        Change-Id: Iffd66d55cec2532dfceb9b4ef8cf8ed30bc34e1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120992
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  homeboy445  <akshitsan13@gmail.com>  [2b8d3d9a209b8020dac734b96a43292332aa5d44]

        backendtest: Text Drawing test
        
        This test revolves around drawing text to a Virtual device
        and testing if it's rendered at the expected position.
        
        Change-Id: Iccfe382103632822befe84d5933d64eacefffa24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118976
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0b698aa6eb26d75ca4baf677a461aee095f69317]

        indexing: move xml parsing into SearchResultLocator
        
        Let's keep unneeded complexity out of SwXTextDocument, so move
        parsing into SearchResultLocator.
        
        As a bonus we can now test parsing.
        
        Change-Id: I944bfc43e6953523eee19b26b7f483aa401809aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121032
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Chris Sherlock  <chris.sherlock79@gmail.com>  [0484630164275e2828f1420b055f05e94b8c73ee]

        vcl: make OutDevState constructor default, no need for destructor
        
        There is no value of having the OutDevState constructor and destructor
        being in its own file, so move to header. Also, resetting the variables
        in the destructor is rather pointless as they are destroyed in the next
        step anyhow. This removes the need to define an empty destructor.
        
        Use C++11 magic to make a default constructor - many thanks to Mike
        Kaganski for the tip on this one.
        
        Change-Id: I9561b311d8752fa12802b5ae8e11123aedabe8be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115460
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Chris Sherlock  <chris.sherlock79@gmail.com>  [9ea129b49259231565d18f965a57c5fefb4ccc7a]

        vcl: partial revert of drawmode
        
        Partial revert of commit 0901297902c29c041ae944973b369e8247716893:
        
        vcl: create drawmode functions
        
        The GetBitmap() function will not work, as it doesn't add metafile
        actions.
        
        I have added a unit test to prevent this from occuring in future.
        
        Change-Id: I8c895e813f378f85ee47f85c3f867e20925bae2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121039
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [e73c3942de474004b04c1d538c89354183d44ae9]

        tdf#144089: Revert "tdf#137737 i18n search: don't expand start/end with regex ^ or $"
        
        This reverts commit a511bffd67a9cebfdc878766581ac08c79d7ff51.
        
        Reason for revert: See https://gerrit.libreoffice.org/c/core/+/120981
        
        Change-Id: If8a445448976a9963f76623d3d968b8d5e3d74dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120990
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-25  Stephan Bergmann  <sbergman@redhat.com>  [15a15c2eb07d5c0b521a03297cdb27e645063161]

        Fix corrupted odk/examples/java/ConverterServlet/web.xml
        
        Instead of just adding a license header,
        2b4fd2c89a38ccac13c72f2e94501a8702e7da4b "re-base on ALv2 code" had apparently
        erroneously overwritten this file with the content of the completely unrelated
        odk/examples/java/MinimalComponent/BuildMinimalComponent.xml.
        
        Change-Id: Iee6dcb528dbb444a132c27e7183b3957319882c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121037
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [fba08b85183ee8a71f6b7044d6fa4492c0cc1be8]

        tdf#143979: sc_subsequent_export-test2: Add unittest
        
        Change-Id: I9051187dcb252d800ba4c2f062ff18f0ed022c03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121028
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [cfa931784082d38bb6b98058c5acccbaf9870710]

        tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape export
        
        This allows to export editengine columns to ODS. Alternatively, we could
        re-introduce chaining text attributes in XMLShapeExport ctor, which was
        commented out in commit d5b1e4827f8e6e0661563ec856cd80d926ba7b58 without
        explanation; but that would affect export from other modules as well
        (e.g., SdXMLExport::setSourceDocument sets up respective chaining in sd),
        so to be on the safe side, I do it only for ScXMLShapeExport.
        
        Change-Id: Iafee77b2b57e95031cfe1bbd2d43d7361a3e8469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120958
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [aacb0f3e3755d5d2fd7489490a32d8104edb3ecc]

        Fix typo after translation round
        
        Change-Id: I2e88905f38f9fade306de064e84e0863f9eeea71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120918
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-25  Miklos Vajna  <vmiklos@collabora.com>  [c6f25506b02fbd2a087b7e790283921bf8550206]

        i#114206 sd: unshare shape properties for the same type before insertion
        
        Regression from commit 9bd99c08e8662becdd5ac8b47ef6f953c14e65fc
        (CWS-TOOLING: integrate CWS os128, 2009-06-03), the problem was that the
        SvxItemPropertySet was both used to store a property map (information
        about UNO properties) and also as a descriptor for a not yet inserted
        shape.
        
        The above commit improved performance by sharing a single instance of an
        SvxItemPropertySet for the same shape types: this works for the property
        map, but doing the same for property values is problematic.
        
        In practice, this eliminates the need for a workaround in oox/, the
        user-visible problem was that loading a document with smartart, then
        loading a document with group shapes (but without smartart) and saving
        it would copy information from the first, closed document (!) to the
        second document.
        
        Just removing the oox/ workaround would make
        
        	make -C oox -sr CppunitTest_oox_drawingml CPPUNIT_TEST_NAME="testGroupShapeSmartArt testTdf131082"
        
        fail, unsharing the descriptor piece makes it pass again.
        
        Change-Id: Icdff2108ad0da18ce0ade081b1938dd74bc0ae90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120996
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8befed1f019061cd0b0ef06f6b717f5bc77afdee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8089daeffa32ec9177187617833f592f2ffb64e
          - tdf#137084 (part) Update Writer Form menu Help page
            
            Change-Id: I875d33c7470d7e8ae4ac09b4266411ff3f94920e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121040
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ae2afd8e8b68adda9133e11f00afcf8bf936a9c5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7d86aa20fd836dd1b94dbe50d2ffb4b203ea8c1e
          - tdf#137084 Update writer View menu
            
            part A - View of comment#18
            
            Change-Id: I8ddfdc8799f499d4730b08e217b07baaa3799172
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121036
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-25  Michael Stahl  <michael.stahl@allotropia.de>  [5c391f4346e86bd5d7528fbb42a3af64f98a03d3]

        openssl: upgrade to release 1.1.1l
        
        Fixes CVE-2021-3712, CVE-2021-3711 (not obvious if any of them affect LO)
        
        Change-Id: I98652348977a5a3c728f1d4fdf7293b76a93b630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121026
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7a8b697aed6eddf1dec4d3c3610359259d4468f4]

        Fix typos
        
        Change-Id: I13c41a077cd54102010c8253dee2455f235087c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121033
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [2cdcf5805b32098e75285015b57bf0f890723e41]

        Use o3tl::saturating_cast here
        
        These were of type long previously, with corresponding limits of
        LONG_MIN/MAX; in commit 3aef606f2758172a27718a06fea0ff9080e4d80f,
        they were changed to tools::Long, but without adapting limits
        accordingly.
        
        This adapts the limits to std::numeric_limits<tools::Long>::min()/max().
        
        Change-Id: Ief4ee0a6219c837e1d971273da698ab07fa8a1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120984
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-25  Mike Kaganski  <mike.kaganski@collabora.com>  [e9ab5a5e4e725a348a4276b72fda63cdac2a131c]

        Introduce o3tl::saturating_cast for floating-point->integer conversion
        
        Change-Id: I73191e5ab25fdd9fd8a788db9858b5eb9d3ab955
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120885
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-25  Attila Szűcs  <szucs.attila3@nisz.hu>  [c1ad429d925855c1baacbdeca1ef42f4486eb9c2]

        tdf#143384 DOCX import: fix SAXException at header with table
        
        Regression from commit d656191ec308d4280b93c7169372e543a255d108
        "tdf#119952 DOCX import: fix negative page margins".
        
        Add SwXHeadFootText::CreateTextCursor(bool bIgnoreTables = false)
        (modeled after SwXBodyText::CreateTextCursor) to create text cursor
        for copying the header/footer also started with table during
        fly frame creation in convertoToTextFrame().
        
        Note: add hidden property PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF
        to use the new feature in domainmapper (followed
        commit af4e5ee0f93c1ff442d08caed5c875f2b2c1fd43
        "tdf#97128 DOCX import: fix frame direction").
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I96e2cf2dddcecd146c53c12d7fdb44fc4d90fa0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119549
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a6ec99fd13ac5b607299252588887e1e90453c9c]

        Bump ui file to latest Glade release
        
        Change-Id: I1a22cecbcf193f0617b5490e6d22a8fc6d830158
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120917
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b125af5977f41ef0d5ea8673686f2cfae208ed41]

        tdf#118538 (part) bump regressiondialog.ui to latest Glade
        
        No change in contents
        
        Change-Id: I8b9d08f9560dbc3541df8dc75b4b01a7b5feb95f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120970
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-25  Luboš Luňák  <l.lunak@collabora.com>  [148ac7de372d0af3c3d20a5c94c12ca0b9cfd4ab]

        use our own Skia surface when using GPU screen drawing
        
        Previously the code called window context's getBackbufferSurface()
        once, and the repeatedly used it for drawing and then did
        swapBuffers(). This worked until version chrome/m91, now Skia
        requires that a screen drawing pass is calling getBackbufferSurface(),
        drawing to it and calling swapBuffers(). Since we do not always
        draw full window content and instead keep previous content, use
        a separate offscreen surface for that and for actual screen drawing
        just blit that to the screen surface.
        
        Change-Id: I36a5b3bb23a085936f4473a0e00d8e04c6b40dab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120966
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-25  Luboš Luňák  <l.lunak@collabora.com>  [d5ec688e4b0aa97eed72ed56d53a5d014b59eb63]

        use prewin.h/postwin.h around a win32 header
        
        Change-Id: I45051b003defa7e48358abeff3944accf16849a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120995
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-25  Caolán McNamara  <caolanm@redhat.com>  [e73b2a8ff50829cbecb29b03aa513de5248aa8cc]

        lcl_translateTwips only needs OutputDevices
        
        Change-Id: I2c1536f062557f598aee0b0552044a7f41302b07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-25  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [4ff568e9ec56ef3cefd9265459fa9fe979d3cdcc]

        tdf#144029 Add user friendly names for UNO commands opening decks
        
        Added in tdf#84502 these commands show up in the Customize dialogs
        Keyboard tab so give them more descriptive names matching the
        deck they open
        
        Change-Id: I1fd9725e8e5fe9d97a4f33f175bf5e505b9ff211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120994
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-08-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [c6883e7a031dec5fe3a365c4fd6adccff09696e5]

        tdf#64991 speed up loading large RTL documents
        
        takes load time from 3min49 to 2min59 for me
        
        Use std::vector<bool> for RsidOnlyAutoFormatFlagMap, we
        only add values to the end so it is easy to correctly size
        this; and std::vectior<bool> is way more cache-dense
        
        Change-Id: Ia607c6a4d80a49a25d487d9ddde5041c166e966c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121009
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-25  Caolán McNamara  <caolanm@redhat.com>  [5f11e921fb878cc6fd6a15181a416e0143e389f7]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I15d68391e20fba3a8ba46621aac0c831cd0900b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120964
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-25  Caolán McNamara  <caolanm@redhat.com>  [71c4c0628570b960c9d6ba14222e1b1324447937]

        assert on calc rtf import at svl::detail::validRange(nFrom, nTo)
        
        Change-Id: I4513be06ff70605db8b386dc261c5b82509759e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-25  Justin Luth  <justin_luth@sil.org>  [a511bffd67a9cebfdc878766581ac08c79d7ff51]

        tdf#137737 i18n search: don't expand start/end with regex ^ or $
        
        If the regex starts with ^, that means that it
        matches only at the beginning of the content.
        So don't expand the beginning of the content
        or else it won't match anymore.
        Similarly, $ indicates matching at the end of the content.
        
        For the unit test I just randomly guessed at SearchItem.AlgorithmType,
        and it kinda worked. I love black boxes...
        I hope I remember what i learned about TransformParameters()
        which was parsed in sfx2/source/appl/appuno.cxx,
        splitting the "variable" into Item.PropName = PropValue.
        That is definite black magic.
        
        Change-Id: Ie1640821a7a430e78dbe72c57a92aeaa9b5272a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120410
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-25  Noel Grandin  <noelgrandin@gmail.com>  [b27ede1a629ac2b5f9e98def37326d546923edec]

        osl::Mutex->std::mutex in ResourceListener
        
        Change-Id: Ide7073273be3405a1d78687a2d6dd12369dd226d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120955
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-25  László Németh  <nemeth@numbertext.org>  [400a44261c3891c1fb99b5339ada69cbc4777dd0]

        tdf#143938 sw test: track format changes of the paragraph
        
        Character formatting changes of the wholly selected
        paragraph weren't tracked before the following fix:
        commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8
        "tdf#143939 sw: track format changes of the actual word".
        This is only an unit test to cover both fixed problems.
        
        Change-Id: Ia8ee15895fc309f4c57c54ac8e6b4265969b5256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120957
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [7bba59217430585c6cc7f88ce787b5024c6ab80f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f801beeaf39c7e7f018b655f28ba8c215ae14763
          - tdf#100480 Clarify the use of "Match case"
            
            As requested in the bug report, this patch clarifies "Match case" when there is more than one case match.
            
            Change-Id: I6c9c0b880948b319a6bbe98d00fdd46d58bd2586
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120980
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4debb7e8cc12563f46d1aaa58afdcb831f21cc83]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68a9210bb429907a26f622209414e69df3d586d3
          - tdf#113240 Fill missing entries in pdf general page Help
            
            Change-Id: I615cd45765369e57f1d3a6b85b51f3beeaca4bfa
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120962
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3d8f6f5c0ba30da100efb4eede426d2fe1f72148]

        tdf#113240 Fill imissing pdfgeneralpage.ui extended tips
        
        Address "Export pçaceholders".
        
        Change-Id: I8cfea3ea8daea948c7b4bd269d976e223ff9222d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120960
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0b570a5939af820f4ef36cb8bc99ebbe450b7ac3]

        Bump Glade release for pdfgeneralpage.ui
        
        no changes in contents
        
        Change-Id: I0adb61facad506ebfa7e0ab0bff81948d84007e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120959
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [4e86347d7ad76e16d8b0eaae5f12d1dfb763b531]

        ofz: Out-of-memory, reduce max row allowed for TableOp when fuzzing
        
        Change-Id: I6268a9974591f86c5918d1171bd8c5ae0a25a538
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120952
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [27273c2c43875acda77b3262c6a4e6138d5dacf6]

        WaE: silence -Wmaybe-uninitialized
        
        Change-Id: Iddc7fd644b2fe45a4de420b926e1270887e5001f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120956
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [cc7c11323215705c3d49acde3f8e6099f2a0feeb]

        cid#1490801 Uninitialized pointer field
        
        Change-Id: I5544b5a2337dbf0f0c1a8ec67ad169974d853aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120951
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa15b0e86a5e78a2cb56aa36f161e1b9769e3441]

        remove one of the pimpls in SvBaseLink
        
        two pimpl's and some internal fields seems a little messy
        
        Change-Id: I24f5a8e264dd98f8f74ab904ace85be1e9ff7acb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120939
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a558be2393cf05a4ccf8b4af546207e69669eba2]

        tdf#127978 - Don't URL encode filename for navigator's tooltip (D&D)
        
        Change-Id: I3a5d6404755698be81818c4636fcc505992e1a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120936
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [60e81b7ac33272a12e54c3d12dab8960ca8b071e]

        remove pimpl from WindowStyleSettings
        
        Change-Id: If230f9f166365c83d478cab6149f95efad7b15f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120954
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Michael Stahl  <michael.stahl@allotropia.de>  [ba8fe774a1cfc1cc5be05ecc5175a7d020e5bd7a]

        test: capture stderr of odfvalidator too
        
        It will be used when https://github.com/tdf/odftoolkit/pull/121 is
        merged.
        
        Change-Id: I78d2b52ffc05fdd446ea7b673c2a7ebab26efc2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120943
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [84d87ae75f5d70bfcaa3e2b124c74a8f733980a3]

        osl::Mutex->std::mutex in OInstanceLocker
        
        Change-Id: Ia92632beccac90e60bceb305a736e93ffb37d356
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120902
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3fcf7643403b331bbbf60169ac20bbf322a294f1]

        Fix typo
        
        Not so sure... anyway, just to spot it to smarter ones
        
        Change-Id: I92727072906eecb65581b214bb01efa98ac9d060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120819
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [0efa548a3f2f392581396db2c7292fdda3d954c7]

        move variables declaration to their use
        
        Change-Id: I95deffd6db252f6c2635c13814a07fa604b64789
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120950
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [566d5be0f26b83f38392a7da928ac6f6e63f0c16]

        tidy this a little
        
        Change-Id: Ifa01b39fc7aa3dfd7238b69a0a61bdf1315a3b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [ca780ad8c3a38fbfabe5ae316671a8eb30ed698d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 09301536eabd098a2e6b42f06755c939278a9521
          - Refactor "02100000.xhp" to fix indentation
            
            This patch applies xmllint --format to fix identation of the XHP file.
            
            This patch will be followed by a fix to bug tdf#100480
            
            Change-Id: I4408bbf2b9be81bc28f2bad95692008fbd3634ea
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120886
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [c3cd4863d4c693a92f0340264b893310851445f0]

        Clarify that css::awt::XDialog::execute is modal.
        
        Change-Id: I80b45918672bcc464dd5b798f81071627fe95cc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120884
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [885bddd8055c292794d38ceb232bd98c8b373452]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6f4f219c04d4bb914cd2a44e782f14ac69d0abc8
          - tdf#112057 Clarify the use of F2 in Calc
            
            In 01020000.xhp I updated the information about the F2 shortcut as discussed in the bug report.
            
            In 01060300.xhp I gave more details about the "Press Enter to switch to edit mode" option.
            
            Change-Id: Ifd554af943fb0bd0f9939c46a9393c7cb87c914e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120880
            Tested-by: Jenkins
            Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
            
2021-08-24  Stephan Bergmann  <sbergman@redhat.com>  [b0ca5311972e90f7059f55b9026584a43de49211]

        Avoid overflowing floating-point -> integer conversion
        
        ...seen at <https://ci.libreoffice.org/job/lo_ubsan/2113/> with recently-
        introduced sw/qa/core/data/ooxml/fail/ofz37458-1.docx during
        CppunitTest_sw_filters_test,
        
        > /oox/source/vml/vmlformatting.cxx:202:38: runtime error: 6.40969e+23 is outside the range of representable values of type 'long'
        >     #0 0x2b40e7a68a1e in oox::vml::ConversionHelper::decodeMeasureToEmu(oox::GraphicHelper const&, rtl::OUString const&, int, bool, bool) /oox/source/vml/vmlformatting.cxx:202:38
        >     #1 0x2b40e7a68cf1 in oox::vml::ConversionHelper::decodeMeasureToHmm(oox::GraphicHelper const&, rtl::OUString const&, int, bool, bool) /oox/source/vml/vmlformatting.cxx:208:47
        >     #2 0x2b40e7bc3bb7 in oox::vml::TextBoxContext::TextBoxContext(oox::core::ContextHandler2Helper const&, oox::vml::TextBox&, oox::AttributeList const&, oox::GraphicHelper const&) /oox/source/vml/vmltextboxcontext.cxx:190:39
        >     #3 0x2b40e7b3190f in oox::vml::ShapeContext::onCreateContext(int, oox::AttributeList const&) /oox/source/vml/vmlshapecontext.cxx:526:24
        >     #4 0x2b40e7b34ee9 in oox::vml::RectangleShapeContext::onCreateContext(int, oox::AttributeList const&) /oox/source/vml/vmlshapecontext.cxx:639:26
        >     #5 0x2b40e7b34f42 in non-virtual thunk to oox::vml::RectangleShapeContext::onCreateContext(int, oox::AttributeList const&) /oox/source/vml/vmlshapecontext.cxx
        >     #6 0x2b40e5fdae26 in oox::core::ContextHandler2Helper::implCreateChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx:100:34
        >     #7 0x2b40e5fddffb in oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx:204:12
        >     #8 0x2b40e5fdfb32 in non-virtual thunk to oox::core::ContextHandler2::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /oox/source/core/contexthandler2.cxx
        >     #9 0x2b40fe645540 in writerfilter::ooxml::OOXMLFastContextHandlerWrapper::lcl_createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:2006:38
        >     #10 0x2b40fe60a6a4 in writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:254:21
        >     #11 0x2b40fe60a942 in non-virtual thunk to writerfilter::ooxml::OOXMLFastContextHandler::createFastChildContext(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) /writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
        >     #12 0x2b40ca28e9de in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) /sax/source/fastparser/fastparser.cxx:465:44
        >     #13 0x2b40ca2899ed in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) /sax/source/fastparser/fastparser.cxx:1306:21
        
        Apparently lacking a general concept to report failure for too-large input
        values here, just silently do a saturating conversation, as seems to be the
        general approach for this kind of filter code.
        
        Change-Id: I4511a5dd63bdbc973d60a521bd3aef445dea3fb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120941
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [8122c82d90117fc0c4c8ea87aa7f771d5e92bf36]

        osl::Mutex->std::mutex in SfxGlobalEvents_Impl
        
        Change-Id: I4dae3225b961b663493ca4ea40b6bbec2439270f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [d7453ed1d3ede8c34bdd5f3bf9b642a3734de0d2]

        osl::Mutex->std::mutex in SfxViewShell_Impl
        
        Change-Id: Ic053a56f51714d7bb63009747cd93e98fcb9c438
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120906
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Anshu  <anshukhare50@gmail.com>  [ed31f9818d1c1e6ba44fa8695d215697ad27713c]

        Refactoring Patch
        
        Change-Id: Ia1fbc8cbdb1e055273e0a9058e11b43b4e0ac62f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120849
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-24  Heiko Tietze  <tietze.heiko@gmail.com>  [dd5039ceea319ebfc72a3e032753b22538add12e]

        Resolves tdf#143633 - Image size wrong after disabling relative image width
        
        Adjustments added back, missing from 3cbecf3d0d9d68de286589e153ee31f8f709be03
        
        Change-Id: Ia2f64fbf0792bd0916052c01e79b37d8820f8b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120940
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [97b7511acfd9593051a611c71d307916097256dd]

        Simplify caching in ConfigurationWrapper
        
        A follow-up to 48c2f0b4b157e133605c99549893521775ede4da
        This allows to not call createInstanceWithArguments repeatedly.
        
        Change-Id: I1893b9b1b0f952ae7c650bab4fb0dfe2f331a129
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120883
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-08-24  Luboš Luňák  <l.lunak@collabora.com>  [baed91bab05546f7f5233701bd7aaed44f25a364]

        implement explicit screen flushing also for Skia/Mac
        
        Change-Id: I29b9f54d24aece32949ac3ba916f1d6588cfd85f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120910
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-24  Luboš Luňák  <l.lunak@collabora.com>  [d4afd3aeb4ef2727986551816c1ff9ad0ed12d04]

        initial Metal support for Mac/Skia
        
        This also required changing SkiaSalGraphicsImpl to have sk_app::WindowContext
        as an internal detail inaccessible to the base class, since the Mac
        implementations cannot use it as is.
        
        Change-Id: I2424f0b887c79ee91c3bd0f1477b0745f9540247
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120909
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-24  Luboš Luňák  <l.lunak@collabora.com>  [ddcdc2077fab2b6d9c4def4e4615185411cbe80a]

        build Skia with Metal support
        
        Change-Id: I7a9abde4101164af8c47433acfa35f4f9d3b3d04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120907
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-24  Luboš Luňák  <l.lunak@collabora.com>  [4efd9f8a4bebe88841b5c3e27d2f7ef3ff10a8d0]

        remove unnecessary separate SkSurface creating per render method
        
        SkiaHelper: :createSkSurface() already handles this.
        Change-Id: I2eba5ab7f53f212ab1d5c0b9366d07543ea97fc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120908
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-24  Luboš Luňák  <l.lunak@collabora.com>  [df54ee7361b3d4eb15e5365a7487049bf247dd7f]

        don't print empty "HOST config (config.warn)" at the end of configure
        
        Change-Id: Ifad159f99a68cf06426cdd0554df1b68d71cd3fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120915
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [35fa0a7369d6ba3a051923c4f813107c16d2c617]

        reduce cost of dynamic casting to SwFlyFrame
        
        which is often hot on doing document layout
        
        Change-Id: Ie78b6a6da4dba38b4ab682f4e1b9d86cc8171918
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120938
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [1fd9116fbcd1a8d25f964087cd1d0eb15df8a2d1]

        tdf#143990: writer: default value for SetIncludeUpperLevels is 1
        
        Same as in e08fba90 for tdf#143858: zero for SetIncludeUpperLevels
        has no practical sense, since actually this value is amount of levels
        to display. Default and minimal value is 1 (current level), zero
        used only in cases when there should be no numbering.
        
        Change-Id: I303386339a9e13944e11d0287c933523c7410b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120863
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-24  Chris Sherlock  <chris.sherlock79@gmail.com>  [0901297902c29c041ae944973b369e8247716893]

        vcl: create drawmode functions
        
        Change-Id: I3cb0325dc16db84ad58de28aa9110e9c7a0b9697
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115372
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f90260701afdbeae98b18263b299c283d2a2cca]

        tdf#144022: fix bug id in unittest
        
        Change-Id: Ib7beef63e3828ca5d2cf3f9601897c6c396e89e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120937
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-24  Noel Grandin  <noel@peralex.com>  [6b2046b41719a391e758ea57055adb2e111f94c1]

        reduce skia realloc when drawing polygons
        
        Change-Id: Ide65945b2baa01b78c954112cdbf35edc41e2f8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Roman Kuznetsov  <antilibreoffice@gmail.com>  [6cf1db2907f48e8aff65f5249668ac1d44ef32f0]

        tdf#144025 Change LibreOffice to %PRODUCTNAME
        
        Change-Id: Ia5bd44cb32818a71743f6a6e028cd9f0eba9aff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120882
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-08-24  Mike Kaganski  <mike.kaganski@collabora.com>  [ae04cfdbad1f4c09b06cd2cee9d89e9909181acc]

        Introduce convertNarrowing to return smaller integer types
        
        It will use compile-type constants to clamp input value, instead of
        clamping more expensive pre-sanitized output value.
        
        Change-Id: If78f8b1b4c99bd2f16b1d8a71872e89a0dddd8d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120874
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-24  Julien Nabet  <serval2412@yahoo.fr>  [d21a9968728295736e63bfc53eb83ee162dafae7]

        tdf#144032: fix STR_ASK_DELETE_LAYER
        
        Like this since initial import
        
        Change-Id: Ie1b475e594860480159d4dea0d401f33b28adab2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120929
        Tested-by: Jenkins
        Reviewed-by: Sophie Gautier <sophi@libreoffice.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [6f790c8b31360463670439e6857ea64f418ddfbd]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I69b76dd2aed35fe2038e61eef343ee8d84f053f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120926
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [a620516fbdddc93b85430081e83fe6cecd9f8d12]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ib020053b30ee7d7c0e335afac68f3a39e891cf2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120920
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [a0e92a64a9a6069ee21336888f3781ffe144b2df]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I768cec434ee20e6e46eb3993c873bed05b3c9cc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120925
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [8351081be79d0b9d61aae2a6eb328a11e2393c92]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iaecbdaa7a7ad61f8c657b0aa04fd30ee27699b72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120924
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [4556dd0f9d154c9b71b009f6dcf9f3e54d9a4d85]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I364368cf4f5cb68c03bbff81f42002f56e3e44af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120923
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [fe90f7fc34f8a6e354abbb48c21556d018fa768d]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: I4e592de5ff830aa970b96993c79a5d957f57adfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120922
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [6097ea726dcc087694a600cf823761097e3ba13e]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Icc09937594ddc97706a63bd11afe062a854ae8ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120921
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [33c1ba1209c7ce679889270edbf42fa66b317895]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Id8fee21b23eff594c6cc13c63ec004be5d015b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120900
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [763996f29aef31f95c438738d081d9b361db36e3]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Ia7ceb0278117df6e140c04232bcfd366fbba3dd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120919
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Caolán McNamara  <caolanm@redhat.com>  [253c8adddb04529185c74aef5e5278eb71d309ab]

        ofz: cgm Integer-overflow
        
        Change-Id: I1cb1d5612f2b0b8999fed0d6c203ab24eedd4fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120898
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [39a11e3287febeb9dd56f43da6f6612afeb0f512]

        tdf#143979: sc_uicalc: Add unittest
        
        Change-Id: I0c51e69521a290bb13e39f592a45b9d94634ad3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120911
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [48c2f0b4b157e133605c99549893521775ede4da]

        cache access in ConfigurationWrapper (tdf#105575)
        
        If we repeatedly hit a config item like this:
           officecfg::Office::Common::Drawinglayer::MaximumPaperWidth::get()
        the stuff in configmgr because quite a bottleneck.
        
        So cache the access objects in ConfigurationWrapper.
        
        This change only affects the auto-generated code we use for the
        C++ officecfg:: configuration API
        
        Change-Id: Ie2adefc2319dfb362f1ef814690120e13abae6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120866
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [a19d84ca25827d1fbe0ab9b276eeff843546ec87]

        osl::Mutex->std::mutex in OFSStreamContainer
        
        Change-Id: I1402b66935c0229977357d0a6ec8ed0bc777de3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120904
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Noel Grandin  <noelgrandin@gmail.com>  [f111a887a08295d56cdc1f20bc980bedbe17c67d]

        osl::Mutex->std::mutex in OFSInputStreamContainer
        
        Change-Id: Icd6ec9e6cd47fd0396cb70d6c63c435d7370b6fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120903
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-24  Justin Luth  <justin_luth@sil.org>  [763f1e8236657a20b359991057679cf12bfac4f5]

        tdf#143692 writerfilter CN: reapply lost OutlineLevel
        
        The paragraph styles had already set their numbering-related
        properties before numbering.xml choses some styles
        to be assigned as Chapter Numbering. Part of this CN process
        in SW is to clear the inheriting styles of any inherited
        numbering properties (numId, listLevel, outlineLevel).
        
        So, we need to re-address outline levels after
        numbering has been imported, and fix up anything
        that has been cleared.
        
        [P.S. No need to do the same thing for listLevel yet,
        b/c LO does not support listLevel on paragraph styles in general.]
        
        Change-Id: Idfb4d150b94558b069dbb1a87c764460396b34d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120757
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [1044496d10f2dc5097324dd8857bc6969ac013dc]

        Karasa Jaga: tdf#143300 add diagonal border
        
        Change-Id: I851814fede4bcec1f1139b7756f44cb66504c780
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120932
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d5d97d251f779fd78490ab7723a134dda1a11960]

        Sukapura: tdf#143300 add diagonal border
        
        Change-Id: Ib2ce2e1385caeee9a312a3e513d4b4126cca5157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120934
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-24  Stephan Bergmann  <sbergman@redhat.com>  [fa2083ff5d913274c3ca30a69edadde907cb7119]

        Blind fix for false -Werror=clobbered on lo_callgrind_linux
        
        ...first seen at <https://ci.libreoffice.org//job/lo_callgrind_linux/11311/>
        
        > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/vcl/source/filter/png/PngImageReader.cxx: In function ‘bool {anonymous}::reader(SvStream&, BitmapEx&, GraphicFilterImportFlags, BitmapScopedWriteAccess*, AlphaScopedWriteAccess*)’:
        > /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/vcl/source/filter/png/PngImageReader.cxx:101:16: error: variable ‘bSupportsBitmap32’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
        >      const bool bSupportsBitmap32 = bFuzzing || ImplGetSVData()->mpDefInst->supportsBitmap32();
        >                 ^~~~~~~~~~~~~~~~~
        
        which reportedly uses
        
        > export GCC_VERSION=800
        
        Change-Id: I9ef5e1e3a735c91f63dd9f5ced05e8acaa731923
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120868
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-24  David Tardon  <dtardon@redhat.com>  [65d717368cb3ada843421700aadc00a1b71598c5]

        upload libmwaw 0.3.20
        
        Change-Id: Ia73117e06f843bcdd228da018fe3f34af6405653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120621
        Tested-by: Jenkins
        Reviewed-by: David Tardon <dtardon@redhat.com>

2021-08-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [3ee22d95d3e1e9ce1d2ff8311e51d600179370f9]

        elementary: tdf#143300 add criss-cross border
        
        Change-Id: I85460c019ba66a624ad408af67dd4e8f6c0698e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120930
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [83f5c19ae01c29bd95f605c0cf8ceb00cd1fb222]

        Breeze: tdf#143300 add criss-cross border
        
        Change-Id: Ie08e9b2eae2cf07a926767e144a69d5f4bba07e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120931
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-24  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [ddf2e96b83fc28ba6ae3f204f6eba7972c7d2f13]

        Colibre: tdf#143300 add criss-cross border
        
        Change-Id: I4e76cb873c1489c72dac8fe84479a8e1c7dbcbe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120862
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [847a8e065f0b35fdab637f6f5abfb1be82a262d7]

        rhbz#1996735 SwEditShell::GetCorrection can return null
        
        Though the exact steps to reproduce are unknown. From the text seen in
        the backtrace the language is possibly Finnish in which case voikko is
        probably the spellchecking backend in use.
        
        Change-Id: I9b3186e4699946235ccc161575bba7d4a3820565
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120893
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Julien Nabet  <serval2412@yahoo.fr>  [6effefa574e169ed875a45ed442b2798d24b71f5]

        tdf#144031: fix description of STR_DESC_MODULE_LANGPACK_PT_BR
        
        Change-Id: If12d27fba3a13a1053ac4a0a1afb891f7c2c6069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120912
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [1230e5cbadc24854993ee9bda8623cc5ff7f136d]

        update some pches
        
        Change-Id: I3f823924b276cd18eddba74f108dd577970084db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Arnaud Versini  <arnaud.versini@libreoffice.org>  [0ce90e777721f11048d366b58e760b60aabf2eaa]

        comphelper : remove useless OContextHelper_Impl
        
        Change-Id: I41fc571695a64b432d6abf4979b99ef141a12b28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [6d276cd03089219c3ad099d4683ecc0c85bd0468]

        ofz: MemorySanitizer: use-of-uninitialized-value
        
        Change-Id: Iea17e1d593f0003de3733722f619b10fbd90a303
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120899
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d5586c9dd5450c8721821ff2072ed08575d3bc3f]

        Removed duplicated includes
        
        Change-Id: I2f922fb107a6e077d005ad3459a8d39009b90d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120897
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-08-23  Tor Lillqvist  <tml@collabora.com>  [e2a54acaf123c61e3be291f8c84a88effae880a1]

        Make compilation for iOS get a bit further
        
        Note that I did not try to refresh my memory of what anything of this
        actually *means*, I just did a couple of quick edits to get past
        compilation errors in vcl.
        
        The build now proceeds until "No rule to make target
        '/Volumes/TML13/lo/master-ios-debug/instdir_for_build/LibreOfficeDev.app/Contents/Frameworks/libgcc3_uno',
        needed by
        '/Volumes/TML13/lo/master-ios-debug/workdir_for_build/Executable/saxparser.run'."
        
        Change-Id: I42e2d60bf691f99631b2700e45921824144df2d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120892
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [238951d0c539d1e294a1a12f2cf7aa806af8e116]

        ofz#37458 use o3tl::convertSaturate in convertEmuToHmm
        
        Change-Id: Ic177ca6042cbedc4cbe70e1f35ac3d85c1fa2f7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120840
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Michael Stahl  <michael.stahl@allotropia.de>  [fbe183bbb05220a4ccc51952445b1797bb498403]

        xmloff: avoid annoying warnings about bookmark conditions
        
        Change-Id: I7bb15c0ab46eee1554977b275b1dfdaff8d1b0cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120794
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-23  Michael Stahl  <michael.stahl@allotropia.de>  [43fc5f3aee4c06fb5983b625175d6991433945d4]

        sw: evaluate bookmark conditions differently
        
        Conditions may refer to database rows in mail merge, which requires a
        SwDBManager to evaluate.
        
        So do it in DocumentFieldsManager::UpdateExpFieldsImpl() where the
        similar conditions on sections and fields are evaluated.
        
        Change the meaning of the m_bHidden flag to store the result of
        evaluating the condition, instead of being always true when there is
        a condition.
        
        Change-Id: Ib8f5483e7f68fc37c650b790b70d10af3c1e6f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120793
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [8a54339fc83fe9abaaace6f9f374697e6923d684]

        loplugin:referencecasting look through more clang Types
        
        Note that because of where the fix resides, loplugin:redundantcast
        also notices a few more things.
        
        Change-Id: I0b66047fadfff2c5ceafcbd3eab085de00d861a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120865
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [d34f1df73806e9ca05fa0d07da619e2c0f01b6f7]

        enable the UI option to enable Skia on Mac too
        
        Change-Id: I3b4d96a3defaa9d6fdfba54f1da4d8be246367e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120813
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [07eab10f5795d7cd58620f0ce1dcf04f6f713c5a]

        disable vertical text test for Mac/Skia
        
        It's broken on Mac, with or without Skia, so disable the test at least
        for now.
        
        Change-Id: I93b9a8d0bcbd275bbb0d54cc412b2df13581ad41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120812
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [ab9c627bc8f16dd679a19b0946863cebab7b03bc]

        add CreateCGImage() variant for Mac/Skia
        
        Needed at least for 'recent documents' icons in the Mac menubar.
        
        Change-Id: I5a22cf64ff5c5aba2c70ca2556fd0b66c425bafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120811
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [55422ec895d3014ba0507757870ebdec9ac1a2a9]

        implement text rendering on Mac using Skia
        
        There may be still small problems (CJK needs checking), but this is
        already usable.
        
        Change-Id: Ic9381c22ca55d9e6320152ffebeae740fd90f796
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120810
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [e3a8826709430f414411d22d98c1fd5e647e1417]

        implement mac native widget drawing also for Skia
        
        Change-Id: Ie91e48cb315d8e11508f064a6dcd9fafebb39abd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120809
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [c8055fd19613a7c5cc5e39156714c781302b7841]

        explicitly force skia raster on mac for now
        
        Change-Id: I29b09b63a7d18d2e32f6310f2851aa6cd5cd7a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120808
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [830abb2437e3f150e1369816f491fb12a3db0c16]

        implement blitting to screen for skia on mac
        
        Change-Id: I01fdb57815dc3dff6d2c5757b55445f16825ed20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120807
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [09b16f9f44578182306c47cdabe92a31cc5d3b4c]

        make SalGeometryProvider available for Aqua VCL backends
        
        This is needed for the Skia backend to know the geometry.
        The Mac Skia code now passes most VCL unittests.
        
        Change-Id: I6e35764d95ce821d8e11ed9979e5be75bcf6ff49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120806
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [13acc8a5df8db5fa24d72c1d44b35e41e4ca2a7c]

        first WIP version of mac skia SalGraphics backend
        
        It doesn't yet blit to screen, but the basics should be there.
        
        Change-Id: I0f77b66756f578d84d0cee16cda00e7a2fea714f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120805
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [00083cfa840269ef5e569c7c4a6a09a34e6ce2db]

        fix skia scanline size in bitmap test
        
        Change-Id: I22a315ca56cae80d88898e2df1ed44894c9787b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120804
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [61a83cdeac14f6e5b1639e26a31145653d753785]

        fix ObjC/C++ generated sources linking on Mac
        
        Change-Id: I4d4a2abdf762e5442d89ce9b6475753e1f43f314
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120802
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Luboš Luňák  <l.lunak@collabora.com>  [44ab745e8d702b2ad0e14a023ddb7269dc6c1306]

        fix Skia linking on Mac
        
        Change-Id: I4ae0ca2baedd533ee4dc115332255e334633cecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120817
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-23  Noel Grandin  <noelgrandin@gmail.com>  [b788e6e8fd4debbb38a03c374929b6af4678d7e5]

        osl::Mutex->std::mutex in AccessibleEventNotifier
        
        which means we need a new interface container to handle std::mutex.
        
        Take the opportunity to move most of the locking outside the
        InterfaceContainer class to make it easier for other
        osl::Mutex->std::mutex conversions.
        
        Change-Id: I5dbd84aa9b7fd9c5e6058d23b993b732f61fbd20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120846
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-23  Bayram Çiçek  <mail@bayramcicek.com.tr>  [3a9167e1b8a236da2862f4377e2040a8c189c99c]

        tdf#143919: Calc: add diagonal borders in Toolbar>Borders
        
        In "Table toolbar > Borders" tab;
        
        - Borders UI column size increased to 5
        - diagonal left border icon added to 5th place
        - diagonal right border icon added to 10th place
        - criss-cross border icon added to 15th place
        
        - added diagonal left and diagonal right
        borders feature
        
        - implemented removing diagonal borders
        when set "no border"
        
        - added criss-cross line feature
        
        - added a unit test for diagonal borders
        
        Change-Id: I2dd7ab797b1a191eb650cc6340ee57d39e45a1ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118951
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-08-23  Mike Kaganski  <mike.kaganski@collabora.com>  [23c1ec0d498124fbe275145d236db455f83cd850]

        tdf#144022: make sure to create missing columns if needed
        
        Change-Id: I1a0771fbe8023859ab29d8114303b62f6a3d539c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120731
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-23  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [75cd2b0fa71c73ae815b80d8e42328024ea63555]

        tdf#143736 Load hyperlink from more shapes
        
        And limit the shape types which can have a hyperlink to those known to work.
        
        Change-Id: I3d3522bea1e756dad8ddc2041e6588a367f42a7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120861
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-23  Balazs Varga  <balazs.varga991@gmail.com>  [e701732725dd641741f39020d7dc965bc4db765d]

        tdf#142351 chart ooxml import: fix category axis cross position
        
        Set PROP_CrossoverPosition value regardless of the mrModel.mbAuto
        value, which is a different thing. This element specifies that
        this axis is a date or text axis based on the data that is used for
        the axis labels, not a specific choice.
        
        Change-Id: Ifa291aac2f4bb3981d968de3489b23f1af485104
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120592
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-23  Dennis Francis  <dennis.francis@collabora.com>  [e9f790e59eec134d6b588241d02d3c2bb82cbc27]

        cid#1490403: fix wrong initial flag bFound
        
        Change-Id: I502653985e54c82198034534bb878d06787f8c94
        Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120730
        Tested-by: Jenkins

2021-08-23  Szymon Kłos  <szymon.klos@collabora.com>  [6e6f8aab1eba3ce29516cc929e033c21fd1bf28e]

        jsdialog: weld Box
        
        Change-Id: Ideb7b7ce8d7bf2e8494f053b13d662e19060b256
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120792
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-23  Szymon Kłos  <szymon.klos@collabora.com>  [63249db11f3caff233231d7201c2ea825dc1022e]

        Move SalInstanceBox decl to header
        
        Change-Id: I945fdbb17caf417990d3531175328099f1a6c93f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120791
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [2652675c417353bd0f072bc7c2579b6d24bf3eba]

        ofz: use BmpScaleFlag::Fast when recovering from bad svm mask size
        
        this isn't supposed to happen and is an error recovery added by:
        
        commit baebeb7de4c5f9511e45c2846ec2a72861a948c0
        Date:   Fri Jul 27 14:04:19 2012 +0000
        
            Resolves: #i120165# Adapt Mask/Alpha at BitmapEx construction...
        
            when size differs from base bitmap
        
        so use the time-cheapest scaling available
        
        Change-Id: I6ea8f458681dcb69e1c128040cc550dd86ff7151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [764b4e7b42791f82237c334ab123d1ae68cec898]

        gtk4: fix build
        
        since...
        
        commit 0f6457b1e867c49bc82f2b18e2e462fb7100051f
        Date:   Sat Aug 21 17:04:39 2021 +0200
        
            don't store vcl::Font with unique_ptr
        
        Change-Id: Ib7db1a59ec328d0a387d836d813c05910a30ebc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Caolán McNamara  <caolanm@redhat.com>  [4b366aa7b21318c2dcb84e1014c59b49ed155b9a]

        Resolves: tdf#143993 don't change FolderPicker to FilePicker if init called
        
        make SIMPLE continue to map to E_CREATE_OPEN_DIALOG for a file dialog but
        map to E_CREATE_FOLDER_PICKER for a folder dialog
        
        Change-Id: I37b0cc318a06b1b16fae3c3dd99def4322f771f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120853
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-23  Pranam Lashkari  <lpranam@collabora.com>  [3527b4e4cfa23c3459c53b091ddadd93c426d0c3]

        LOK make sure single row/column table are resizable
        
        First row/column are treated as heading in the table,
        that's why need some special case handling for it
        
        First row/column are not counted in regular row/column
        
        Change-Id: If67b759911ea87f2b166a69243b85e98d90c4d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120725
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-23  Justin Luth  <justin_luth@sil.org>  [2aca75ef2ac84360d13e9000ba3063a7a42b6f6f]

        tdf#143692 writerfilter: fix outlineLevel import x3
        
        First, illegal values don't mean "use body level".
        It means "inherit the value value from the style".
        So just ignore illegal values.
        
        Secondly, styles without any explicit setting (a -1)
        where being incorrectly specified as "-1 + 1",
        i.e. body level(0) - meaning that inheritance was always lost.
        
        Thirdly, the body level value is necessary in order to cancel inheritance
        from a style. So the style must be able to set a value of 9.
        
        Change-Id: I2161085181527fb321dbcc00636513330dd8ca1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120756
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [50f0e8c7880122a05585a2233f6f35d0dfee0385]

        indexing: make indexing XML flat and use simple element names
        
        This changes the indexing XML to be flat-er and change the element
        names to just be either "paragraph" or an "object", where an
        "object" then has an attribute what type exactly it is.
        
        This makes converting the XML to an indexing engine accepted
        format easier.
        
        Change-Id: Ia8941cc9616a862c1bc980efea5ba2548217644e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120836
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0224d859b8a497779611cc15943c017ec42f9b90]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b7fa972bc76c0954479bfd7f1b77c511372c4626
          - Update topic on Draw scale factor
            
            Change-Id: Ie64a78ee22c837f0f2a9cb76ef2a45c817721e00
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120726
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-22  Eike Rathke  <erack@redhat.com>  [c6f15d228489ccfd0628ca80b45a5c2faaacc7d3]

        Resolves: tdf#143979 Write and read empty text element in number formats
        
        ... as they may be significant as separators between keywords of
        same letters.
        
        Also strip trailing empty text as meaningless, except if the only
        element.
        
        >General;General<
        earlier both General were written as
        
            <number:number-style style:name="N111P0" style:volatile="true">
              <number:number number:min-integer-digits="1"/>
              <number:text/>
            </number:number-style>
        
        for which now <number:text> is not.
        
        Change-Id: I4809b1c784667994303b49d8e4ab0e857367e2cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120856
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-22  Caolán McNamara  <caolanm@redhat.com>  [4250958a492b300a52a83e68dd599f9c36c5086e]

        ofz: prep for allowing oss-fuzz msan
        
        dependencies need to be built with the msan flags so undo the
        --with-system .a usage now that trying to squeeze into the 12 hour build
        window isn't critical because the afl 6-8 hour build+check is disabled
        
        Change-Id: I3729d37e0f028c5efe62ce5d66ea6fe636d3d0c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120788
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [054166821842de6f25c3123fcc1976b3c9d1d69b]

        no need to use unique_ptr for Sdr3DObjectAttribute
        
        it is already a COW type
        
        Change-Id: Icc4173c5a61f5d819ce908f8a38c3efb29ebb1c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120850
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [30067dafa988d4c6dd970c817eca283ac8946728]

        no need to use shared_ptr in SdrAllFillAttributesHelper
        
        these types are already COW types
        
        Change-Id: I7e4375ac50b8d887869123eeb99d3eaef0d28169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [4c5e264df432f4e6836535cbac7231ab579af424]

        no need to use unique_ptr for PolyPolygon
        
        it is already a COW type
        
        Change-Id: If28f67bff3f8df7763bf4b574b1125d568f0ee27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120821
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [008f28c9e01114e731f785e9e238236a1ed069d2]

        no need to use unique_ptr for B2DHomMatrix
        
        it is already a COW type
        
        Change-Id: Ide1dedfb8be7593bf45b0e78899450f04291f09e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [0944ef734571ae34cbecc53812e576a39b3722f0]

        no need to use unique_ptr for ViewInformation3D
        
        it is already a COW type
        
        Change-Id: Ie098bd293115650128ebb18d5c16747b519717c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120825
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [0f6457b1e867c49bc82f2b18e2e462fb7100051f]

        don't store vcl::Font with unique_ptr
        
        it is already a COW object, so just use std::optional
        
        Change-Id: I5ced54dbf3dc222316d9bcf3581b36e0f6e6e270
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noel@peralex.com>  [f30c3ff66a24d5031c077be0cb839f5f249c188e]

        speedup SkiaSalGraphicsImpl::drawPolyLine
        
        no need to convert the line to a polypoly and then unwrap the polypoly,
        just go straight to a poly
        
        Change-Id: I3f0ccfb7ce557dc4c6cd67e6e66a0562609ce736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [1706dba109533cce01eb982ef7cdedee5a20a1e0]

        osl::Mutex->std::mutex
        
        Change-Id: Id3c0660dae6dd5c6c026a26ec2ca39ccd6db210f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120845
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Caolán McNamara  <caolanm@redhat.com>  [c32c82e2e89e9efcd922da81918c6915829dc632]

        BOOST_FALLTHROUGH->[[fallthrough]];
        
        Change-Id: I7f43cbd83125ad7f2822f073dde5aa31f164832a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120841
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-22  Caolán McNamara  <caolanm@redhat.com>  [4555be3b51c7f48074441ba789df31e7920aa812]

        ofz#36673 Indirect leak
        
        Change-Id: I294dccbf4517ee7714ee9055953a45bdd630b5a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120839
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [d2bf9e56310fe40eac700afa974483d704e4c70a]

        no need to use shared_ptr for these fields in Region
        
        they are already COW types
        
        Change-Id: I8b673304452cc50c581be03a605efafa77175b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120829
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [54f6de1b07c7dc167f5013e70f49541ec505931f]

        no need to use unique_ptr for LineInfo
        
        it is already a COW type
        
        Change-Id: I32866e6741748be587cdb8af83143bc70e82318e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [d9f2486bee13cc1710ef66bf5e64e30f2f702772]

        no need to use unique_ptr for Polygon
        
        it is already a COW type
        
        Change-Id: I74ffb129aa63cd9c56794997d72e32002f8b45fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120822
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Stephan Bergmann  <sbergman@redhat.com>  [840b1714d3f00a60b81676bddf201355e3c47afb]

        Give gengal invocations their own UserInstallations
        
        Building e.g. Gallery_backgrounds tries to access a UserInstallation at various
        places, first at
        
        > #0 0x00007ffff29b0302 in EmbeddedFontsHelper::clearTemporaryFontFiles() () at vcl/source/gdi/embeddedfontshelper.cxx:60
        > #1 0x00007ffff2dd6bb4 in InitVCL() () at vcl/source/app/svmain.cxx:304
        > #2 0x00007ffff2dd66b6 in ImplSVMain() () at vcl/source/app/svmain.cxx:190
        > #3 0x00007ffff2dd6898 in SVMain() () at vcl/source/app/svmain.cxx:231
        > #4 0x000000000041215d in sal_main() () at vcl/source/salmain/salmain.cxx:34
        
        It would either access the real UserInstallation (if the bootstrap ini-file has
        already been delivered to instdir) or try to access some (typically non-
        existent) /user.  That appears to be generally harmless, but to be on the safe
        side, pass the gengal invocation an explicit UserInstallation in workdir (which
        does not exist, and does not get populated, but just prevents accidentally
        accessing a real UserInstallation).
        
        Change-Id: Idc709a4bd44ce0dddbafaac25141215730808fca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120838
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-22  Stephan Bergmann  <sbergman@redhat.com>  [0e7d4d99beda181f4e22725e4b8295d25489696f]

        gengal needs Library_localedata_en now
        
        Whatever caused that requirement, but a from-scratch build of e.g.
        Gallery_backgrounds failed for me (with a follow-on SIGABRT after
        "framework/source/services/desktop.cxx:176: Desktop::~Desktop(): Who forgot to
        dispose this service?") because it failed to load
        instdir/program/../program/liblocaledata_en.so at
        
        > #1  0x00007fffda0b9671 in i18npool::LocaleDataImpl::getFunctionSymbol(com::sun::star::lang::Locale const&, char const*) (this=0x159b630, rLocale=..., pFunction=0x7fffda136ed8 "getAllFormats0") at i18npool/source/localedata/localedata.cxx:1460
        > #2  0x00007fffda0b6a93 in i18npool::LocaleDataImpl::FormatSection::getFunc(i18npool::LocaleDataImpl&, com::sun::star::lang::Locale const&, char const*) (this=0x7fffffffc840, rLocaleData=..., rL=..., pName=0x7fffda136ed8 "getAllFormats0") at i18npool/source/localedata/localedata.cxx:857
        > #3  0x00007fffda0b6b5c in i18npool::LocaleDataImpl::getAllFormats(com::sun::star::lang::Locale const&) (this=0x159b630, rLocale=...) at i18npool/source/localedata/localedata.cxx:865
        > #4  0x00007fffda0d4815 in NumberFormatCodeMapper::getFormats(com::sun::star::lang::Locale const&) (this=0x1594fa0, rLocale=...) at i18npool/source/numberformatcode/numberformatcode.cxx:150
        > #5  0x00007fffda0d4155 in NumberFormatCodeMapper::getAllFormatCode(short, com::sun::star::lang::Locale const&) (this=0x1594fa0, formatUsage=8, rLocale=...) at i18npool/source/numberformatcode/numberformatcode.cxx:92
        > #6  0x00007ffff572a824 in LocaleDataWrapper::loadCurrencyFormats() (this=0x159b3f0) at unotools/source/i18n/localedatawrapper.cxx:544
        > #7  0x00007ffff572777e in LocaleDataWrapper::loadData() (this=0x159b3f0) at unotools/source/i18n/localedatawrapper.cxx:131
        > #8  0x00007ffff57271b4 in LocaleDataWrapper::LocaleDataWrapper(LanguageTag const&, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&) (this=0x159b3f0, rLanguageTag=..., rOverrideDateAcceptancePatterns=std::__debug::vector of length 0, capacity 0) at unotools/source/i18n/localedatawrapper.cxx:80
        > #9  0x00007ffff5766fd6 in SvtSysLocale_Impl::SvtSysLocale_Impl() (this=0x158a4e0) at unotools/source/misc/syslocale.cxx:67
        > #10 0x00007ffff5768ad7 in std::construct_at<SvtSysLocale_Impl>(SvtSysLocale_Impl*) (__location=0x158a4e0) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/stl_construct.h:97
        > #11 0x00007ffff5768b1c in std::allocator_traits<std::allocator<SvtSysLocale_Impl> >::construct<SvtSysLocale_Impl>(std::allocator<SvtSysLocale_Impl>&, SvtSysLocale_Impl*) (__a=..., __p=0x158a4e0) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/alloc_traits.h:514
        > #12 0x00007ffff57688c2 in std::_Sp_counted_ptr_inplace<SvtSysLocale_Impl, std::allocator<SvtSysLocale_Impl>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<>(std::allocator<SvtSysLocale_Impl>) (this=0x158a4d0, __a=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr_base.h:519
        > #13 0x00007ffff576860a in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<SvtSysLocale_Impl, std::allocator<SvtSysLocale_Impl>>(SvtSysLocale_Impl*&, std::_Sp_alloc_shared_tag<std::allocator<SvtSysLocale_Impl> >) (this=0x7fffffffd0a8, __p=@0x7fffffffd0a0: 0x0, __a=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr_base.h:650
        > #14 0x00007ffff57684c6 in std::__shared_ptr<SvtSysLocale_Impl, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<SvtSysLocale_Impl>>(std::_Sp_alloc_shared_tag<std::allocator<SvtSysLocale_Impl> >) (this=0x7fffffffd0a0, __tag=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr_base.h:1342
        > #15 0x00007ffff576838d in std::shared_ptr<SvtSysLocale_Impl>::shared_ptr<std::allocator<SvtSysLocale_Impl>>(std::_Sp_alloc_shared_tag<std::allocator<SvtSysLocale_Impl> >) (this=0x7fffffffd0a0, __tag=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr.h:409
        > #16 0x00007ffff5768164 in std::allocate_shared<SvtSysLocale_Impl, std::allocator<SvtSysLocale_Impl>>(std::allocator<SvtSysLocale_Impl> const&) (__a=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr.h:863
        > #17 0x00007ffff5767dfc in std::make_shared<SvtSysLocale_Impl>() () at ~/gcc/trunk/inst/include/c++/12.0.0/bits/shared_ptr.h:879
        > #18 0x00007ffff5767583 in SvtSysLocale::SvtSysLocale() (this=0x7fffffffd120) at unotools/source/misc/syslocale.cxx:122
        > #19 0x00007ffff015148f in FwkResId(TranslateId) (aId=...) at framework/source/fwe/classes/fwkresid.cxx:22
        > #20 0x00007ffff025f333 in framework::Desktop::constructorInit() (this=0x1588850) at framework/source/services/desktop.cxx:106
        > #21 0x00007ffff0265c1c in (anonymous namespace)::createDesktop(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (context=...) at framework/source/services/desktop.cxx:1764
        > #22 0x00007ffff0265ce5 in framework::getDesktop(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (context=...) at framework/source/services/desktop.cxx:1773
        > #23 0x00007ffff0265d9e in com_sun_star_comp_framework_Desktop_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (context=0x522200) at framework/source/services/desktop.cxx:1782
        > #24 0x00007ffff5a5d864 in std::__invoke_impl<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(std::__invoke_other, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__f=@0x54bb58: 0x7ffff0265d5f <com_sun_star_comp_framework_Desktop_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:61
        > #25 0x00007ffff5a551f4 in std::__invoke_r<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__fn=@0x54bb58: 0x7ffff0265d5f <com_sun_star_comp_framework_Desktop_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:114
        > #26 0x00007ffff5a4d254 in std::_Function_handler<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__functor=..., __args#0=@0x7fffffffd4f0: 0x522200, __args#1=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:291
        > #27 0x00007ffff5a3f913 in std::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const (this=0x54bb58, __args#0=0x522200, __args#1=...) at ~/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:568
        > #28 0x00007ffff5a2a396 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x54baa0, context=...) at cppuhelper/source/servicemanager.cxx:704
        > #29 0x00007ffff5a2a12a in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) (this=0x54baa0, context=..., singletonRequest=false) at cppuhelper/source/servicemanager.cxx:672
        > #30 0x00007ffff5a2d02d in cppuhelper::ServiceManager::createInstanceWithContext(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x523450, aServiceSpecifier=..., Context=...) at cppuhelper/source/servicemanager.cxx:1003
        > #31 0x00007ffff6cd9922 in com::sun::star::frame::Desktop::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (the_context=...) at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/frame/Desktop.hpp:38
        > #32 0x00007ffff6cd8c07 in SfxApplication::Initialize_Impl() (this=0x1588150) at sfx2/source/appl/appinit.cxx:182
        > #33 0x00007ffff6cb776a in SfxApplication::GetOrCreate() () at sfx2/source/appl/app.cxx:122
        > #34 0x0000000000405ecf in (anonymous namespace)::GalApp::Main() (this=0x4204e0 <vclmain::createApplication()::aGalApp>) at svx/source/gengal/gengal.cxx:254
        > #35 0x00007ffff2dd6777 in ImplSVMain() () at vcl/source/app/svmain.cxx:199
        > #36 0x00007ffff2dd6898 in SVMain() () at vcl/source/app/svmain.cxx:231
        > #37 0x0000000000410f1f in sal_main() () at vcl/source/salmain/salmain.cxx:34
        > #38 0x0000000000410efa in main(int, char**) (argc=10, argv=0x7fffffffded8) at vcl/source/salmain/salmain.cxx:29
        
        This fix should remove the need for the cross-build--only fix
        0e142fa01972ad28182ca54b855d0ecae0d5c83b "cross-toolset: gengal now needs
        localedata_en", which it reverts.
        
        Change-Id: If71b7249c19619a83911c7624e3d99077decba31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120837
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-22  Caolán McNamara  <caolanm@redhat.com>  [eb05182c68f4c6c842da216c9662fce7a6d0047d]

        cid#1490402 Resource leak
        
        Change-Id: I345fa61dddf25cadc79fae7d2edd706fd2b45eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120823
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-22  Caolán McNamara  <caolanm@redhat.com>  [8ff57504f75ddd35c3f585cf2224c6fcc3863ca3]

        WaE: protect clang diagnostic push/pop with if defined __clang__
        
        Change-Id: I8360aa96097a13b6bad1283edddc7c2fd1ed510d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120832
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-22  Luboš Luňák  <l.lunak@collabora.com>  [096e28acff82948eef6c5425593f0929c9367a6f]

        make isDebuggerAttached() work on Mac
        
        Change-Id: I1c7c2b58686e7cbb0f8f11327df7ae951226586f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120803
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [feb59fca82df3762c4eb3b9ac2c96e9fa387bed1]

        no need to use unique_ptr for XPolygon
        
        it is already a COW type
        
        Change-Id: I94370d20fbe9d7f6b1bd57f339911a75cbef6484
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120824
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [3a668a2398fdbe7cfe0176900b26ca6145fb0e8c]

        no need to use unique_ptr for B2DPolygon
        
        it is already a COW type
        
        Change-Id: I86c4be9dd83b98eedf169c3b6668a7994204bca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Noel Grandin  <noelgrandin@gmail.com>  [523bba89cd5ad6372fb0431cecabdca02ea2b9e3]

        no need to use unique_ptr for B2DPolyPolygon
        
        it is already a COW type
        
        Change-Id: Iaf8bf1671781923555df3e43b0db78e87c2c5a87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120826
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Kevin Suo  <suokunlong@126.com>  [a1759769804a7f3b9895b481229d497a9eb4c70a]

        tdf#143959 sdext.pdfimport: fix font name with subtag
        
        as returned by the font descriptor when reading the font file.
        
        Change-Id: I376b887e6356e765f669b41c43776f78f94c3623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-22  Muhammet Kara  <muhammet.kara@collabora.com>  [3748535a5739f3cb1471516b2e7ae2601575b639]

        tdf#126915: Redaction: Clarify 'Export Directly as PDF'
        
        * Add new uno command alias '.uno:RedactionPreviewExport' with the
          desired label.
        * Add a link to the icon of the '.uno:ExportDirectToPDF' command so that
          the new alias is displayed correctly on the Redaction Toolbar
        * Replace '.uno:ExportDirectToPDF' with '.uno:RedactionPreviewExport' on
          the Redaction toolbar and the Redaction menu
        
        Change-Id: I72d17cac7d570341d89d1e59776e1af25f8d8b87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120835
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-08-21  Caolán McNamara  <caolanm@redhat.com>  [10c742afd5f04c2c3a3e1f881fd6a8c61d364c03]

        arm: fix bridge
        
        which went a little wrong in
        
        commit dd91d3389c26645459d3b80649941d65efa4f63f
        Date:   Sat Jan 2 14:36:44 2021 +0100
        
            Fix some warnings for Raspberry pi 4 (part3)
        
        Change-Id: Ief7e1146b7480a1c16ec0810f991296710214332
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120830
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-21  Caolán McNamara  <caolanm@redhat.com>  [cd99b9fe6cec1fa14aba1d94228b17163cddd906]

        arm: nStackBytes was already the right amount of bytes
        
        possible regression from...
        
        commit 6e3424ca1131fe371f63e456267de476b5eb0eae
        Date:   Sat Jan 2 11:03:12 2021 +0100
        
            Fix some warnings for Raspberry pi 4 (part2)
        
        which changed that
        
        Change-Id: I9a19d7d6bc1e4115ffffbe32d8d62be5d275d500
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120747
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: René Engelhard <rene@debian.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-21  Eike Rathke  <erack@redhat.com>  [bae2fbfd341b2cb5e5053c7977176f68b5d658dd]

        Resolves: tdf#143946 Add Klingon, tlhIngan Hol {tlh} 0x06AC to language list
        
        Change-Id: Icf7452b2aef3ecae8ccdbcd4a66ab8b121a8120c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120814
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-21  Justin Luth  <justin_luth@sil.org>  [520de5a4b2a11412a41ad64b65675a9180fb97db]

        tdf#95495 writerfilter: clear obsolete hack
        
        This looks completely wrong and unnecessary to me.
        HOWEVER, at the time it really fixed a LOT of documents
        and bug reports, so definite congratulations to the
        original programmers for a successful hack in
        a minefield code-area.
        
        But it definitely seems hacky and full of wizardry.
        AFTER setting the PROP_OUTLINE_LEVEL to be the real thing,
        then we change the placeholder values to something different?
        Plus, OutlineLevel has NOTHING to do with a list level,
        so it should be irrelevant here.
        [There is a fail-safe that ensures that outline level
        matches list level for Chapter Numbering, but that is
        not a DOCX thing, but a LO thing.]
        
        Other major changes earlier in 7.3 fixed a lot of
        inheritance issues, and highly refactored
        Chapter Numbering recognition, so it is highly
        likely that this code is completely pointless.
        
        -confirm tdf#95495 examples same in Word 2010, 2016, LO
            • Windows PowerShell Language Specification Version 3.0 (confirmed)
            • 95495 Windows PowerShell - APPENDICES (confirmed)
            • 385.docx (comment 12) (confirmed)
            • numbering.docx (confirmed)
            • test1.docx (confirmed)
        
        Change-Id: I0f1ac7c9367b094a6431fe61442d3b58ffee79d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120755
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-21  Noel Grandin  <noelgrandin@gmail.com>  [5922c885a27512717080186273799dab5830ab3f]

        rtl::Static to thread-safe static
        
        Change-Id: Id63bc7dada4ba09389f5a1ebd83c00c8e55faf7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120795
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-21  Eike Rathke  <erack@redhat.com>  [05924f9b2e651f545d8ceea883d9b1729257349d]

        Use LanguageTagIcu::getDisplayName() for on-the-fly language list entries
        
        So the for {tag} entries "too geeky" argument of spell-checker
        dictionary developers and language enthusiasts will be moot in
        future and we can stop adding 100 more tags if it's not for locale
        data.
        
        Change-Id: Ic44fe5b2f794ddb258e56ec073f310ccaf6e470d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120799
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-21  Eike Rathke  <erack@redhat.com>  [6d6119bc4e4a783c76b3ae35626d6fea0de0abac]

        Unit test for LanguageTagIcu::getDisplayName()
        
        Change-Id: Ibe95fba21ed94be7fb4848f19161d492bc403e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120798
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-21  Eike Rathke  <erack@redhat.com>  [c482aefe08e4486aa35ba87edea1a341c97b8610]

        Introduce LanguageTagIcu::getDisplayName()
        
        To be used in generating display names for on-the-fly language
        tags in the language listbox.
        
        Change-Id: Ibb36fe312e550f77f1e2d3acc2dbff9e83c15f7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120797
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-20  Justin Luth  <justin_luth@sil.org>  [f4b80f4e060a68aa35a7ec678d18af989e82f055]

        tdf#142542 writerfilter: allow para to cancel style autoSpacing
        
        Change-Id: I7535e7574c3ec9a108a810ba3209074d01aa96f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120275
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-20  Alain Romedenne  <alain.romedenne@libreoffice.org>  [d7cb5461bf71a267a754f5c7dcb0d4bfc70ee844]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 374e66c1c0353e0042a70ae67d663ccb084fb39a
          - ScriptForge - (SF_UI) CreateBaseDocument() new CalcFileName argument
            
            Change-Id: I1f7005c6eb51ee9323dd2ad960c50031dfb62cf0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120642
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-08-20  Caolán McNamara  <caolanm@redhat.com>  [1727fe82330dcf67eeece4eacfd4907f85714b0f]

        tdf#142394 return to using CAIRO_OPERATOR_SOURCE in drawBitmap
        
        since
        
        commit cd09fc9451897e6efedbf9f5e1d5b9bd96e65cb5
        Date:   Mon Mar 22 19:06:15 2021 +0100
        
            do not enable mbSupportsBitmap32 for headless (tdf#141171)
        
        turned back off the mbSupportsBitmap32 support experiemented with in
        
        commit 86ea64f216819696cd86d1926aff0a138ace2baf
        Date:   Fri Feb 15 13:14:32 2019 +0100
        
            Support for native 32bit Bitmap in VCL and SVP (cairo) backend
        
        Change-Id: I818c3f11d0334278a65a0e45b61141327669121d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120709
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2021-08-20  Stephan Bergmann  <sbergman@redhat.com>  [af1b02ede015e21cdad9ad98f8f042db4f31c4ce]

        -Werror,-Wunused-private-field
        
        ...after cf66fd32ed8a31d4ca6f031a13e90caf19f40682 "loplugin:unusedmethods"
        
        Change-Id: I799eec5cf1e5ec31e8d6bb2bfefda10d8b41c699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120787
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-20  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [341f923b5e487fa596e369d2ad17daaea909d9ec]

        Enable automatic code style formatting for subsequent_export-test.cxx
        
        As subsequent_export-test.cxx code style is following  the recommended
        code style (except too long lines and minor formattings), the code
        is used only for testing and it is rarely modified (mainly adding
        new test cases), I decided to enable automatic code formatting.
        
        It is one step closer to migrate to common code style.
        
        Change-Id: Iaa6c243fab45c37cb01672633717577651916c3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120706
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-08-20  Stephan Bergmann  <sbergman@redhat.com>  [f87cbab4432f7b28016d8b934ff9c565d0cf6cc7]

        loplugin:unusedcapturedefault (macOS)
        
        Change-Id: Id5a69e1307907cebffbdf50732cb4f34868280bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120784
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-20  Caolán McNamara  <caolanm@redhat.com>  [09ecc654acfa7d09f701187d9484a36514b70100]

        augment CFLAGS for fontconfig and freetype instead of overwriting
        
        so CFLAGS containing msan's -fsanitize=memory are not discarded
        
        Change-Id: Ie213488b5e1e6e5f5aad649f2cf72a12acae9cc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120780
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-20  Caolán McNamara  <caolanm@redhat.com>  [01408f9da879f69adbfee515efb4d8a57af2460e]

        Revert "ofz#37370 Null-dereference"
        
        This reverts the code of commit 9343551f5588ffa4916e2c5d33cbd6fcf56ca99d
        but keeps the test-case
        
        No reason to have this after: 0bb3ccf9148106ce3e5d9e03c23ab5a9602e843c
        'Revert "Simplify Rect2Poly"'
        
        Change-Id: I37f363e51dc5daed3faf85f27203b2cfe09b82c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120746
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ed3aa0575d73f34d5fa666d147c569ce3d55048d]

        Fix extended tip after translation round
        
        Change-Id: Ia41bbbf470a55ebc3fda06da7f137a9594fc738b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120783
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b151d545a759dc244128af23d4c7745639f29f03]

        Bump ui file to newest Glade
        
        Change-Id: I3825eb69ab64475dfd0a152dde60c0803917a36f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120782
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-20  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8c06e8b254fbb2446fd5625e23beaed6bb567ba4]

        Fix extended tip after translation round.
        
        Change-Id: I94f5fbb35224c2b784bbab7fdbbeb52f336d0489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120781
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-08-20  Stephan Bergmann  <sbergman@redhat.com>  [2bc1a0431becd1c6d4c888a6e301237dcecefd97]

        New loplugin:unusedcapturedefault
        
        In sc/qa/unit/ucalc_formula.cxx, dropping the capture-default from the
        lExpectedinF lambda revealed that MSVC in C++17 mode (i.e., when building
        without --with-latest-c++) requires ROW_RANGE (a local const int variable from
        the enclosing TestFormula::testTdf97369) to be captured, even though all uses of
        that variable within the lambda body are constant expressions.  That is still
        true at least for the latest Visual Studio 2019 version 16.11.1.  (This is not
        an issue for the lExpectedinH and lExpectedinI lambdas a few lines further down,
        as they, in addition to using that ROW_RANGE, also use the local const double
        variables SHIFT1 and SHIFT2, whose uses are not constant expressions, so
        they are implicitly captured and loplugin:unusedcapturedefault does not suggest
        dropping those lambdas' capture-defaults in the first place.)
        
        Change-Id: Iee7efb485187cbe8eba6a2d470afca4993eb1816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120693
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-20  Marco Cecchetti  <marco.cecchetti@collabora.com>  [46d3fdeb4fa35e0575395a3a91213fd81fda0e50]

        go on switching from boost::property_tree to JsonWriter
        
        JsonWriter provides better performance than boost::property_tree and
        it is also cleaner, so we need to start using the latter in place of
        the former as much as possible.
        
        Change-Id: I8c1e910c0b3d511b89679e622e2cc5d4848a8b47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120656
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf66fd32ed8a31d4ca6f031a13e90caf19f40682]

        loplugin:unusedmethods
        
        Change-Id: I9ce1ae787b735200cd57b0f470a6e5e3146657fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120777
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  dante  <dante19031999@gmail.com>  [58a5bd793a2ed57077fc598281cc74e16373b877]

        Fine tune new sm import / export
        
        Change-Id: I7e7ec875b3d0f8f1d62f22270a306bc2f57421ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120768
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  dante  <dante19031999@gmail.com>  [4f7dd4985dd11e2e797f0ab05eaa7982b5a83b46]

        Improve code reability with different function names
        
        Change-Id: I0799cb26642197813b054c1bde39cf1ced7519a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120767
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  dante  <dante19031999@gmail.com>  [cf2082337c72eca4509fbdbb05d8c68b91fe8a69]

        Fix typo in new SmMlElement exporter
        
        Change-Id: Ia1e7963dbb2f69a8b8f43903882521da94eaffe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120766
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  Noel Grandin  <noel@peralex.com>  [720e4258ab5f00287098ff945a184bfb43911841]

        use Primitive2DDecompositionVisitor in ViewObjectContact (tdf#105575)
        
        ..to avoid container construction
        
        Change-Id: Iae7a8ea8c31b6c8bcf4d161273be7b32fe41a021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120779
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [ac586d1caecaa5be4bce05b073ce4c7bda10f13e]

        Make some scripts more portable
        
        Change-Id: Ia89059eea51ca396a7c74143625ac9a6706de198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120773
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-20  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [080e4550257a90597c241f83fd766b99c83ba6e8]

        tdf#141097 Revert "Veto process exit while an OLE client is connected"
        
        This reverts changes that were made to prevent process exit when an
        OLE client is connected. These commits had the side effect of preventing
        the use case of creating a document via OLE, and then allowing
        the user to view/edit and ultimately quit from the GUI.
        
        Revert "More hacks for quit requests from an OLE Automation client"
        
        This reverts commit 05e03911cd1f8a355b6410d3997cffc2c794a1e9.
        
        Revert "Veto process exit while an OLE client is connected"
        
        This reverts commit 89f883bd90a50587868a57397b6350ed9559a20f.
        
        Change-Id: I29a1e42a830815bc8d1ff0056c22d86b8f98cc1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118596
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [e367e59e37499d0efca381f0b41df52c7cfc2026]

        loplugin:unusedfields
        
        Change-Id: Ie27afe4c2438c44baece4b926572584c6695dc39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120774
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [02c9c9adf65883ecaeef0e86a4b0b70ee3d5cf52]

        make BitmapPalette a COW type
        
        so we can avoid copying it during rendering
        
        Change-Id: Id83d2bb2682f46188ee6ccc90c92d338a1e05b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  Bayram Çiçek  <mail@bayramcicek.com.tr>  [4bb59cd1f45133994d3d13642367470f528094f4]

        tdf#91519: prevent jump to top of the comment view
        
        In Writer,
        there are 3 issues about comment section:
        
        - comment section scrolls to top of its view
        when clicking inside a comment view.
        
        - clicking inside a comment view, scrolls the
        view to old cursor location automatically
        (if old cursor out of the visible area)
        
        - comment section scrolls automatically to the
        old *selected* text (if it's out of visible area)
        when clicking inside the Writer canvas view
        
        this commit is intended to solve these issues
        
        Change-Id: If7d62373f5215adea85512b66b78736e04e02c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118638
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-08-20  Caolán McNamara  <caolanm@redhat.com>  [fc7fbbd8ba089570c93917eedf1de0512cc0ba3b]

        allow build with poppler <= 0.82
        
        Change-Id: Ia062a788fec9c67c18382c2ff5f4b4df35bd17d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120771
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-20  Stephan Bergmann  <sbergman@redhat.com>  [af686402107a54f141eea3bb7706e3ff665178ae]

        Mark external/clucene/patches/nullstring.patch as sent upstream
        
        Change-Id: Id9e0010575110ef6fae5cf93943bb226a7727e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120770
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-20  Caolán McNamara  <caolanm@redhat.com>  [5dc9d944f1d88881b65660a5a2c347f29b99bf72]

        msan: MemorySanitizer: use-of-uninitialized-value
        
        nCheckPos is always set to something, but for nCheckPos != 0 nType might
        be left uninitialized, so test nCheckPos == 0 before nType
        
        seen in ooo76602-1.slk and ooo10703-1.html with distro-configs/LibreOfficeOssFuzz.conf
        
        ==623515==WARNING: MemorySanitizer: use-of-uninitialized-value
            #0 0x59600b4 in SvNumberFormatter::PutandConvertEntry(rtl::OUString&, int&, SvNumFormatType&, unsigned int&, o3tl::strong_int<unsigned short, LanguageTypeTag>, o3tl::strong_int<unsigned short, LanguageTypeTag>, bool, bool) svl/source/numbers/zforlist.cxx:658:72
            #1 0x8c7f72 in ScImportExport::Sylk2Doc(SvStream&) sc/source/ui/docshell/impex.cxx:2130:48
            #2 0x8bcb26 in ScImportExport::ImportStream(SvStream&, rtl::OUString const&, SotClipboardFormatId) sc/source/ui/docshell/impex.cxx:392:13
            #3 0x650f4b in TestImportSLK sc/source/ui/docshell/docsh.cxx:3360:19
            #4 0x6055a7 in LLVMFuzzerTestOneInput vcl/workben/slkfuzzer.cxx:87:11
            #5 0x555b53 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/out/slkfuzzer+0x555b53)
            #6 0x541622 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6
            #7 0x54722e in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/out/slkfuzzer+0x54722e)
            #8 0x56fa82 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
            #9 0x7fbd8b65ebf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)
            #10 0x51cc49 in _start (/out/slkfuzzer+0x51cc49)
        
          Uninitialized value was created by an allocation of 'nType' in the stack frame of function '_ZN14ScImportExport8Sylk2DocER8SvStream'
            #0 0x8c27c0 in ScImportExport::Sylk2Doc(SvStream&) sc/source/ui/docshell/impex.cxx:1837
        
        Change-Id: I0422ca34827319d1e35d453606a7afe6a9de3840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [0f7fed9249e988ca34c5401d746887822b4aa9ce]

        tdf#143957 Qt5 always create an OpenGLContext
        
        Nothing checks the result and a lot of code just uses it.
        
        Change-Id: I1a672e98d42673fd684538ead831622f6a14e9f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120761
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-08-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [9ca30cd1d04cf39411c3ede687805c28ebe2a980]

        VCL allow plugins to declare OpenGL support
        
        ... and get rid of the whole GetBackendCapabilities, which was
        just overkill. Maybe this should even be some bitmap + enum
        + set/get function, but I'm too lazy...
        
        In the end add a bool for the OpenGL support of the VCL plugin
        (or maybe sticking it into ImplSVData, which is already some
        catchall for common VCL data).
        
        Change-Id: I9f0ececac482d8e2a94ef6024628e9631b49e773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120760
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-08-20  dante  <dante19031999@gmail.com>  [3ad6d41c1c88b0549c9be0f41e02d83a582fcdfd]

        Add a SmMlElement tree to the sm document
        
        Change-Id: Ide764b512004198277baed60ac4e1a5ef0d1c2dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120765
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  dante  <dante19031999@gmail.com>  [aa232a45bc0d5daf4a0ae4b47b9459000d1ec210]

        Add security handlers to the iterators
        
        Change-Id: I0cc8dd92c7ae870e58f0f9118df76569d6deecd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120764
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-20  Szymon Kłos  <szymon.klos@collabora.com>  [e5a7a65e59fcd300834e5a7d20b797dedbeb6b69]

        Convert AreaTransparencyGradientPopup to WeldToolbarPopup
        
        Change-Id: I3cbb17de9953281e884f6c1b2984bc4865a56227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118471
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120700
        Tested-by: Jenkins

2021-08-19  Stephan Bergmann  <sbergman@redhat.com>  [d001836139b28d367cc70b64a13519d173066df1]

        Fix locking of public UriReference members again
        
        ...after 074790ad6f4e02e7aed3f9c954f0b4005b40fa21 "remove some locking from
        UriReference" (and its follow-up 0f44815ce7b2925189cd603853ce55d8363549dd
        "loplugin:constmethods"):  The m_path member is modified by
        UrlReference::setName in
        stoc/source/uriproc/UriSchemeParser_vndDOTsunDOTstarDOTscript.cxx.  Also make
        the non-mutated members (for which locking is thus indeed not needed) private
        for now.  (The original intention was that there can be further parsers for
        other URI schemes, which might need to modify further UriReference members.  If
        such further parsers are ever implemented, the relevant members can be made
        public again, and the locking be restored where necessary.)
        
        Change-Id: I80b437fe14f43294a52e465a7e1f31ddf2ab0482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120749
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-19  Stephan Bergmann  <sbergman@redhat.com>  [396c0575b2935aeb039e8da260eba739d1a0ed3c]

        external/clucene: Avoid std::string(nullptr) construction
        
        The relevant constructor is defined as deleted since incorporating
        <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p2166r1.html> "A
        Proposal to Prohibit std::basic_string and std::basic_string_view construction
        from nullptr" into the upcoming C++23, and has caused undefined behavior in
        prior versions (see the referenced document for details).  That caused
        
        > workdir/UnpackedTarball/clucene/src/core/CLucene/index/SegmentInfos.cpp:361:13: error: conversion function from 'long' to 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>') invokes a deleted function
        >                    return NULL;
        >                           ^~~~
        > ~/llvm/inst/lib/clang/14.0.0/include/stddef.h:84:18: note: expanded from macro 'NULL'
        > #    define NULL __null
        >                  ^~~~~~
        > ~/llvm/inst/bin/../include/c++/v1/string:849:5: note: 'basic_string' has been explicitly marked deleted here
        >     basic_string(nullptr_t) = delete;
        >     ^
        
        at least when building --with-latest-c++ against recent libc++ 14 trunk (on
        macOS).
        
        (There might be a chance that the CLucene code naively relied on
        SegmentInfo::getDelFileName actually returning a std::string for which c_str()
        would return null at least at some of the call sites, which I did not inspect in
        detail.  However, this would unlikely have worked in the past anyway, as it is
        undefined behavior and at least contemporary libstdc++ throws a std::logic_error
        when constructing a std::string from null, and at least a full `make check` with
        this fix applied built fine for me.)
        
        Change-Id: I2b8cf96b089848d666ec37aa7ee0deacc4798d35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120745
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [45620dc9bb3e6561fdd64e2c7d192ccae136b224]

        Revert "tdf#59820 - Adjust column width of imported ASCII files"
        
        This reverts commit aaabfc644afd57577980998c83f94a271f633c02.
        
        Reason for revert: Large csv files will not open in a reasonable amount of time.
        
        Change-Id: I7d3d3bf0341bcb83f86be88e8911879de13918ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120720
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-19  Eike Rathke  <erack@redhat.com>  [c374d8ed86262c8b09c158d22ec7e4b9dee115dd]

        Make the logic more logical.., tdf#102846 follow-up
        
        Same functionality better readable.
        
        Change-Id: Idb891a6e2f0a35528d6a1862e5743a22772eec11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120754
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-19  DaeHyun Sung  <sungdh86+git@gmail.com>  [9c13f1ad6384ee05a10ed688b93a46f6489a872a]

        tdf#143526 add Korean Numbering test case & fix Hanja number codepoint
        
        add Korean Numbering test cases
        1. koreanCounting
        2. koreanLegal
        3. koreanDigital
        4. koreanDigital2
        
        fix Korean Hanja number codepoint for Zero(0)
        Following MS Office's numFmt Strng example
        https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/a1bb5809-e361-4e49-8e16-7f1a67da4121
        
        Korean Hanja notation for Hanja is `零 U+96F6` on MS Word 2019 and that
        document.
        So, fix the Korean Hanja number code pointfor Zero(0) `零 U+96F6`
        
        Change-Id: I1a5b95640a93e7fbc3a0e724b154587877b198a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120676
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [46f4069e914b82f8295b91b57a6c7429bc2da057]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dd88f0407623a3c075727254abe5c93a88a5dedb
          - tdf#143930 update Security help page about new feature
            
            This is a follow-up to tdf#90401 that was fixed, so now the Security page needs to be updated to inform that the names and dates of comments and tracked changes are also removed.
            
            Change-Id: I6c677d197b6a770b1c36a5f40af94e40715e4a9c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120716
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [741f615268462b17f2135cb7d2adb0bf39bed7cc]

        ofz: add expat generate_hash_secret_salt to ignorelist for msan
        
        use of the return value is flagged as use-of-uninitialized-value
        otherwise
        
        Change-Id: I574a1829ea4ff0343129c1d9b6dcc74168aa6909
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120752
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2d86ec4d68ef474aab302d1209934f69b2db8952]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 76b01db756aadf10c3bcde322355c05881f40652
          - Fix typos
            
            Change-Id: I28e4e508bcedeb1da1d31f2636ed6fc66b932653
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120742
            Tested-by: Jenkins
            Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            
2021-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [977a3b5e7ddaf9b11fca8ecd4576cc86ab0eacea]

        Removed executables bits on docx file
        
        Change-Id: I9e4de09bdf39c788bd015ac84b3add89ea80f3c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120743
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6f4e2a71dacf4527abcc71f70e988400b146e9df]

        Fix typo
        
        Change-Id: I225688ee50b87c5019f83060ec8bbf614df6174f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120744
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-08-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [351a4308ba4708cf0cf9fd53d9f3dee0de1515e5]

        tdf#143624 PPTX: slideshow setting “Manual forwarding” not exported
        
        Follow-up to commit f8ddaaf0f5e1fb61e0d4404ea28757bc652ae4be
        (tdf#142915 PPTX import: support for presentation's timing attribute).
        
        Change-Id: I1b175d406d2cd0fc40ba7085517709fb477fed58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120529
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-19  Eike Rathke  <erack@redhat.com>  [ff62e0165a0add7c7e3cb606df5b24b20c822d8a]

        Resolves: tdf#102846 CSV: Detect separator, limit preview line concatenations
        
        In CSV import preview, if a line starts with a quote character and
        none of the remembered last field separators used occur in data in
        conjunction with a closing quote, then reading data tried to
        concatenate line by line to form a data field to be presented in
        the preview, worst case the entire file..
        
        For the preview, detect one possible not yet selected separator if
        used with a quoted field (similar to commit
        c807e7ea7a0725a4d8375eda07d6f70870e0d50a for tdf#56910 space
        separator) and limit the number of source lines that are tried to
        be concatenated if no separator was encountered after a possibly
        closing field quote.
        
        Change-Id: Iefd37a8301161e72cb607cea88d4faadad47b4ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120690
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-19  Stephan Bergmann  <sbergman@redhat.com>  [0d14e1251efeec9f651a28f553447c6d06b778e9]

        loplugin:sequenceloop (macOS)
        
        Change-Id: I5d004dfcce2ce1aad520f9e541432a60627161a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [602dd66fecd92f97ac9206bb90a83d0a04dc8e59]

        use sanitize-excludelist.txt for fuzzing CC as well as CXX
        
        Change-Id: Ia470dbb9ab3ce86bedbadfd69ea145806530e4dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Jean-Pierre Ledure  <jp@ledure.be>  [407b53dd2246e727d19fe94c82cb357af2e4f8ed]

        ScriptForge - (PDF Export) get/set options, export as PDF file
        
        Next methods are introduced in SF_Session:
          - GetPDFExportOptions to extract a dictionary of the
            40+ existing options for PDF export
          - SetPDFExportOptions to update the existing options
            When applied the options are permanent also for user manual exports
        Those methods are not available in Python.
        
        Next method to export a document to PDF:
          - ExportAsPDF: it uses the options set above and/or takes
            next specific and transitional options:
              pages, password, watermark
        This method is implemented for use from Basic and Python
        
        Change-Id: Ic5c4190cff579e62137930f422638aad98e61a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120740
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [0bb3ccf9148106ce3e5d9e03c23ab5a9602e843c]

        Revert "Simplify Rect2Poly"
        
        This reverts commit 5b025285b3528910a4360899abb2bbbaadc72c97.
        
        Reason for revert: the semantics change for empty rectangle is
        significant. See also 9343551f5588ffa4916e2c5d33cbd6fcf56ca99d.
        
        Change-Id: I5df0c07067840d39af0a187ca9a104963cdeefab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120651
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [0f44815ce7b2925189cd603853ce55d8363549dd]

        loplugin:constmethods
        
        Change-Id: I786096b989daa6004a6527aafbe825b6f0a22d90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120710
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9239b11cee9f02cedcb0c240637e58cc8b795086]

        Fix typos
        
        Change-Id: I45243c6312545d51409574447e27f5320d4da79c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120493
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [958854ac4c701e6b1444178514b1a6e4e03be94e]

        Avoid infinite loop in dbgutil builds
        
        As mentioned in tdf#117162 comment 13, there are cases when
        SdrObject::Free does not modify maAllIncarnatedObjects. So the
        fix for tdf#143514 needs the change to account for that.
        
        Change-Id: I249c6a3b095c5d3c644dcb1bbc900b42793ea820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120648
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [9343551f5588ffa4916e2c5d33cbd6fcf56ca99d]

        ofz#37370 Null-dereference
        
        since...
        
        commit 5b025285b3528910a4360899abb2bbbaadc72c97
        Date:   Wed Aug 18 07:35:05 2021 +0200
        
            Simplify Rect2Poly
        
        where tools::Polygon from tools::Rectangle ctor has special handling
        for an 'empty' Rectangle
        
        Change-Id: Ifb93efeee4c2c1fe1f9fe5422e0e648ad91da77a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120702
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  László Németh  <nemeth@numbertext.org>  [5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8]

        tdf#143939 sw: track format changes of the actual word
        
        If there is no text selection, character formattings
        are applied on the word under the text cursor,
        now with storing the original direct character formatting
        in a redline "extra data" for rejection of the tracked
        formatting change.
        
        Follow-up to commit ee3171adb24a3d720466fa43bec869910333f892
        "tdf#143918 sw: fix reject of multiple changes" (clean-up the
        format tracking code into the new lcl_SetRedline(), and
        applying that for the not handled case, too).
        
        Change-Id: Ie6bc4dc17dbf84cc61970cef66689aec8ddc4595
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120707
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-19  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [e3f9170c03eb9121b0c244c0e2e60d15e6920deb]

        tdf#143722 DOCX import: map using default TOC heading style
        
        of Writer ("Contents Heading") instead of "TOC Heading".
        
        This essentially reverts the fix to bug #83300.
        
        When that was added the TOC import was broken enough that
        it made no visible regression.
        
        In 6.3 the TOC import was fixed up so now it's more annoying.
        
        The unit test of bug #83300 is reused but depends on the fix to
        bug #143726.
        
        I checked the example file of bug #83300 and the layout problem
        of comment 6 that was fixed there does not come back.
        
        Follow-up to commit 5440492ff9f949ee9ed9052e8bab6f5136d78b2a
        "tf143726 DOCX: export default TOC Header style with correct name".
        
        Change-Id: Iaee73729ea46a0c36d08ccc6fc5fb04fdf592a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120092
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [ddf90ad13d1e4df45dc414d737e50f086c8737fd]

        vcl: move ImplReleaseFonts() to outdev/font.cxx
        
        Change-Id: I4bd54c24f415e28014690fd775a3a5136d2be433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115371
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [0f7401838d77172ef545e38cd07fac253869c904]

        vcl: add braces to SetBackground() function to make reading easier
        
        Change-Id: Icb91c4e8aae3f6f25515ca75a3cc230d9238dd4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115370
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-19  Chris Sherlock  <chris.sherlock79@gmail.com>  [eb1bf3c87104790fc17a71d070e570cce278c9e4]

        vcl: move background functions to background.cxx
        
        Change-Id: Iee2e42f3881512d2e779d16505c50f76731e398a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115369
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1103727fb24b368419ea0cfd2382560ef6b82f43]

        drawinglayer: split polygonprimitive2d.hxx into multiple files
        
        The header polygonprimitive2d.hxx contains multiple primitives,
        which should be independent in their own header files.
        Split them in its own file, but for now keep polygonprimitive2d.hxx
        with includes all the new headers so that compilation goes through
        with no need to change any other files.
        
        Change-Id: I5c8ea2ed0c6d38374c1b871fef562b2164b9c8fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120708
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-19  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [5440492ff9f949ee9ed9052e8bab6f5136d78b2a]

        tdf143726 DOCX: export default TOC Header style with correct name
        
        This seems to have been a typo since it was mapped to the default
        name of the Table of Authorities index's heading in Word
        which is not really supported anyways.
        
        Change-Id: I4cadce18c30c5497f27479fcc251fdf85d859145
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120091
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [b55db12f79a01ccbd3276f4a291fe20750efbaf3]

        use std::optional<OutlinerParaObject> in SwPostItMgr
        
        it is a COW object, no need to allocate separately on heap
        
        Change-Id: I9388d2a850a39a8645071dfb2907a4fe7785ac21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120703
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Katarina Behrens  <bubli@bubli.org>  [1b06e7e9e8c467de3450077fe8b90be6b7f73e4b]

        tdf#143567: Distinguish bitmap vs. pattern fill style
        
        By the time fill style state change (SID_ATTR_FILL_STYLE) happens,
        the actual bitmap fill may or may not be known. If it is not known,
        it is impossible to tell whether it is a regular bitmap or
        a pattern. That's why this toolbar sometimes incorrectly reports
        bitmap fill instead of pattern one
        
        To solve the problem, we adjust fill style listbox selection only
        later, by the time we know for sure the fill IS a pattern
        
        Change-Id: I0aa95c49601d77dca29ab54ad4c056a76a90e049
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120687
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-08-19  Michael Stahl  <michael.stahl@allotropia.de>  [97b61ea3297e04e64aab1e1a4ec50202e9f86fff]

        ridljar: check that UnoClassLoader is used for NativeLibraryLoader
        
        The native libraries are local to class loaders, so
        System.load("java_uno.so") will fail with any other class loader.
        
        Change-Id: Ifa3b1b8dfef07b64828943654e28ff1f0fb5a494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120527
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-19  Michael Stahl  <michael.stahl@allotropia.de>  [71ebb55b4e888c8d1642d52742fc6d0d11ba3b9e]

        toolkit: fix deadlock in MutableTreeNode
        
        Broadcasting may call back into this, from
        TreeControlPeer::updateNode().
        
        Release maMutex before broadcasting to fix it.
        
        (regression f7ee6baa1b14410fa79aac5dd9d6877df44a823a)
        
        Change-Id: I91a8e043aaed02422601e5d4d5253379abab5d7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120616
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [074790ad6f4e02e7aed3f9c954f0b4005b40fa21]

        remove some locking from UriReference
        
        we write these fields in the constructor and then never modify them
        again, so safe to skip locking
        
        Change-Id: I5cb5ea085ee8c2f6e4ce6417c2648265aa5a06d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120704
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Noel Grandin  <noel@peralex.com>  [60485d591882954bbec717bfc0f4ffce8c9e9d5e]

        reduce skia re-alloc costs (tdf#105575)
        
        by reserving space before building the SkPath
        
        Change-Id: Ic01f614bf574fd3252d379ed38e3039cb0c56b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120701
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Bayram Çiçek  <mail@bayramcicek.com.tr>  [966d043b631fd1e850d0eb62d657fbca8f62c033]

        tdf#143890: Show preview of diagonal borders / Calc
        
        - in "Properties sidebar > Cell Appearance",
        Calc shows preview of the selected cell borders.
        (preview is at the bottom of "Background" text)
        
        - this feature doesn't work for diagonal borders.
        
        - diagonal borders preview is now shown with
        this patch.
        
        Change-Id: I9d98b045ccef5e8469cc38f08e5f14c3199d027c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120519
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [55c4bfc5717c6f915e8760eec95be76813d5fce8]

        use std::optional<OutlinerParaObject> in SdrUndoAttrObj
        
        it is a COW object, no need to allocate separately on heap
        
        Change-Id: Ibfecb263eedb6ef5eca8122e80a564cb1e872db1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [e545598e738407019419a4c0fc252314d8f434d4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e0504d8b59b76437009203f68877a07fb9951cde
          - tdf#73359 update information about image/frame alignment
            
            Change-Id: Iecca0467229b019c9dd35589375ba269e2dcb713
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120585
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-19  László Németh  <nemeth@numbertext.org>  [ee3171adb24a3d720466fa43bec869910333f892]

        tdf#143918 sw: fix reject of multiple changes
        
        Reuse "extra data" (i.e. tracked direct character
        formatting) of the previous redline on the formatted
        text range to track all character formatting changes,
        i.e. the new and the previous ones, too. E.g. modified
        text size and color of the word are rejectable now,
        not only the last one (e.g. text color) of the multiple
        formatting changes.
        
        Follow-up to commit 0115a77eb84afb0d820d8e23f45e49b30b82a8d3
        "tdf#50447 sw: track changes of character formatting".
        
        Change-Id: I6a82603ecce9885cd06bc27bedbadaac72f97240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120668
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [68bbc75dfeb7c910de7e3d40e840c9959d6875c0]

        reduce visibility of some symbols
        
        Change-Id: I16b6be2217f56e5961e1352201a8ee4e2b033e97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-19  Szymon Kłos  <szymon.klos@collabora.com>  [f54ccf09a5073b6e544c976da68de0c9fc0bdf6c]

        Make Custom Color Picker dialog async
        
        - now supports also XAsynchronousExecutableDialog
        - inherits from SfxDialogController to attach correct LOKNotifier
        
        Change-Id: Ic21db4057b8087d74a437b1c8ec95408ade5264d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119012
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120670
        Tested-by: Jenkins

2021-08-19  Szymon Kłos  <szymon.klos@collabora.com>  [abd08d042fb397fbf97b93d8ca1a6426c1b304e6]

        jsdialog: dump id for images
        
        Change-Id: Ia25dde027f79bc9c3c22cbaccdb41c2ff1ae4214
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119504
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120661
        Tested-by: Jenkins

2021-08-19  Johnny_M  <klasse@partyheld.de>  [0ff25f803e8f1d32f5d3ca31de1e5a44233f259b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a50cd071131aaf106c24c9d3b58cb0b90e019fcb
          - tdf#132643 Translate German section IDs
            
            Change-Id: I428adb56cf10454a2737d7ce75b81fe143acdd9a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120508
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [e9528e41b266ad59eb8768fb3aac07e97b4dde14]

        augment CFLAGS for libxml2 instead of overwriting
        
        so CFLAGS containing msan's -fsanitize=memory are not discarded
        
        Change-Id: I3a6cdbe88b1aae37a48e73d5ed7ea06e92d78f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120683
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [8bfa23efcd01b06956186c416d0b3c1ae21a9e77]

        ofz#37300 Direct-leak
        
        since...
        
        commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28
        Date:   Sun Aug 15 17:35:58 2021 +0200
        
            pass OutlinerParaObject around by value
        
        Change-Id: I9e28844226184ba2f54d11888b020d080e9b57ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120631
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [403af381c39ab8045c5ff42874fc71f3d5acf8ba]

        cid#1490358 silence bogus Dereference after null check
        
        Change-Id: I58734852180f345ac2242d5d89e3d7e5da2ed6e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120684
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [72eea49fc69e38b60e1d588ab9295db273e8e6dc]

        cid#1490357 Dereference after null check
        
        Change-Id: I107dc27a4bec1794293192dea986670220989ec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120685
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Caolán McNamara  <caolanm@redhat.com>  [898b8e653824da62bbd2d34430c85901da7c5222]

        save LastTipOfTheDayShown when the dialog is shown not in its dtor
        
        Otherwise if a tip dialog is left open then its considered not to be
        have be shown and new ones will constantly open on every new
        document. Especially problematic in impress if you leave the first
        one open and select a template to open from the template dialog then
        you get two of them in the same frame.
        
        Change-Id: I94cd34aa031e133d8c229a0de78582fda1dbdf4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120674
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [0e16b40d8b68f73731b4aa9059d0f98d0489fed0]

        Drop GetSdrObjectFromXShape and use SdrObject::getSdrObjectFromXShape
        
        Change-Id: I0d233878ee49fcdc1338ec3bd700e5482d558163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120694
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [69f4abe1248f9919f242920b463c4d5f4965211f]

        tdf#143736 Add test
        
        Change-Id: I132a31f7bb06f31cabfa92b647a9e4dbdb7b4b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120692
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-19  Julien Nabet  <serval2412@yahoo.fr>  [dda0caeb5d3eae473f85b0ea14bd51be7bb806a2]

        cid#1490354/1490355: Logically dead code
        
        Change-Id: I2f20f60d01e5b5969a51041726b13cb2e1a2d0af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120682
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-08-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [da006fbe2d4c5891933390d72f6e6026b28d39fc]

        tdf#143736 Fix loading hyperlink from textbox
        
        Change-Id: I56f5aec153d9544a6c345e0cbb5857cf5d0074b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120673
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-19  Mike Kaganski  <mike.kaganski@collabora.com>  [420e834007ca654db9803030726edb32c3ba5710]

        tdf#142264: make sure to load potentially unloaded objects when saving
        
        Commit 574eec9036c5f185b3572ba1e0ca9d111eb361dc happened to reveal
        a pre-existing problem that XLSX export only saved those OLE objects
        that were kept loaded in the OLE object cache, subject to thevalue of
        org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects.
        
        Before that change, the imported charts were marked modified on load,
        and that prevented them from unloading in OLEObjCache::UnloadCheckHdl,
        because SdrOle2Obj::CanUnloadRunningObj returned false.
        
        After the mentioned change, the charts started to load without the
        wrong "modified" state, which allowed them to be properly managed by
        the cache, and the export filter implementation error surfaced. It's
        likely that commit 692878e3bb83c0fc104c5cca946c25ccf2d84ab2 tried to
        workaround the same underlying problem for charts that for some reason
        / at some point in time didn't get marked modified on load, and that
        commit converted an error shown in Excel into silently missing charts.
        
        This change makes sure that whenever a reference to chart document
        is requested from XclExpChartObj, it is actually loaded and ready
        for reading data.
        
        Possibly something could be done on the level of old reference that
        becomes non-functional (although valid) as the result of unloading,
        so that it would automatically reload on following use. That would
        make operating on the references robust. I didn't find an obvious
        way to do that.
        
        It is interesting to investigate, it the heizenbug related to images
        disappearing from documents, as users keep reporting without robust
        reproducers, might possibly be caused by a similar problem.
        
        Change-Id: I45fcdc98254157d805c7519340b5265526f27166
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120688
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-19  Eike Rathke  <erack@redhat.com>  [f58f35b2c8ca1efbacec642a8f3de5b0c499bc6b]

        Do not count pages for initial page breaks, tdf#124983 follow-up
        
        Use a loaded page size or leave it. Otherwise the previous
        implementation could had lead to tremendous waiting time blocking
        everything on large data without. See source code comment.
        
        Also trigger updating page breaks only for one grid window, not
        multiple repeating everything all over.
        
        Remove bSetup parameter that does nothing but either doing something or
        nothing, check in caller instead.
        
        Move member variables to where they belong.
        
        Change-Id: I5efc321e5bc5af075a77631aa9d94b0c50ae6b6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120689
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-18  Stephan Bergmann  <sbergman@redhat.com>  [8c717ea3854130067919658e9ec7433e0b5e2ba0]

        GCC bug 96878 is fixed in upcoming GCC 12
        
        However, restricting the workaround to GCC <= 11 then revealed that some old
        versions of Clang apparently had a similar issue, causing "error: use of class
        template 'OStringLiteral' requires template arguments; argument deduction not
        allowed here", and thus also need the workaround.  I saw the non-workaround code
        fail with a build of Clang 6.0.0 and succeed with a build of Clang 7.0.0.
        
        Change-Id: I6e4cf6c8c3a11618a578401574e5679e6b65d7f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120657
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-18  Stephan Bergmann  <sbergman@redhat.com>  [5d224d9141a07814f1e93c147de3ba03d643de34]

        Avoid LIBO_USE_SOURCE_LOCATION feature on user-facing LockFileException
        
        (see 1d0bc2139759f087d50432f8a2116060676f34e1 "use
        std::experimental::source_location in uno::Exception"), causing the unopkg
        executable to print something like
        
        > ERROR: unopkg cannot be started. The lock file indicates it is already running. If this does not apply, delete the lock file at:
        > ~/.config/libreoffice/4/.lock desktop/source/pkgchk/unopkg/unopkg_shared.h:44
        
        mentioning an unhelpful source location
        
        Change-Id: Ie9ed716c9edc6c73c173a034ce8bd9bfaf05c0c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120669
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [7bba0f12e4bb726ef29a9b7c2f862128abcaf0d7]

        UnloadObj always dereferences its SdrOle2Obj* arg
        
        Change-Id: I24f68e83c15f7fad464ad164e75e7cd49ae17b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120678
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [133352645a8c10fc0d13795480a3c2f93c36a61f]

        Teach symstore more duplicated DLLs
        
        Amending commit b4dfba947768834ffecc09056992019878711c8b with
        adding the copied DLLs here, too (symstore complains otherwise)
        
        Change-Id: If5cc155cf2fe11b0f97cd152993609fd2c835316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120686
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [2da60bb46a93a8d68111e1f18b31e8e6ddc6cc2c]

        ofz#36713 Indirect-leak
        
        Change-Id: I665d7eb66f04fd78b6345f22d5f5724e5778a211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120653
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [95f1e32a3300364a250b097b357345cfafe76d2a]

        GetObjRef already returns the needed reference
        
        Change-Id: I9f18bcb56906ee75ec015bbd38de26dcb2828d06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120639
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [1f42157e2457e30a7f18fdf9d7bb5bddfb819f04]

        tdf#143353 defer tip of the day until impress template dialog is gone
        
        wait until that dialog is dismissed before showing the tip dialog
        
        Change-Id: Id0e7e28f09c5a9727e10eda55e468adb56bfda70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [c1cd505c67a53a0a27589889b34641612d10946d]

        ofz#37322 Bad-cast
        
        use a SwUnoCursor for the LastAnchorPos around here, this is similar to
        ofz#9858 Bad-cast
        
        Change-Id: I194a39ae13c382740b0ba8145dcc33fb2107105d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120679
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [18f202011661397d10ca4c2fa28fcf57b62221b0]

        loplugin:constparams
        
        Change-Id: Ic7410f836e584df45101e78e345c8b3c8d355e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120680
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Noel Grandin  <noel@peralex.com>  [2e74c1107bc8422ee7a819722f3f0a366127330f]

        use visitor callback to avoid container construction (tdf#105575)
        
        Change-Id: I4dd3382ceca82f93664e66b32bcfa7c74eb58fdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120606
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e0dcf1a55547b124be227b6326173aa62bc2dcf8]

        remove incorrect comment
        
        Change-Id: Iafb37b52fde75fcf92341980b512c4c0c12c6f44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120681
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-18  Dennis Francis  <dennis.francis@collabora.com>  [d1d6c1535e51ef364a71d3d4c5bd331af88fce32]

        tdf#118470: unit test for escaped unicode chars in strings import
        
        Conflicts:
        	sc/qa/unit/subsequent_filters-test.cxx
        
        Change-Id: I4c4190538bdcb3292546d6d5884eb7900807060c
        Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120666
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-08-18  Dennis Francis  <dennis.francis@collabora.com>  [2d5ba784a341aea1b7b2403842d2521d1548ea8f]

        tdf#118470: sc oox: recover escaped unicode chars in strings import
        
        according to OOX open spec 2.1.1742 Part 1 Section 22.9.2.19, ST_Xstring
        (Escaped String). In this implementation, some restrictions mentioned in
        this spec are not kept for simplicity.
        
        Change-Id: If27797a9625d49be54c600c8a864965f1101ceb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120665
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-08-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3ab570d8b3e208db966865357a4f8ecae2e0afc2]

        Fix typo
        
        Change-Id: I2e1bc1530bd0a8cf6fef93dcaf8092458da79231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120598
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [719e2f34837ac54ab7d789e782d5924a72c931d3]

        Potential nullptr dereference
        
        SdrOle2Obj::CanUnloadRunningObj dereferences its first argument
        unconditionally after checking if it's XEmbedPersist2, so for null
        argument, it will always crash.
        
        OTOH, OLEObjCache::UnloadCheckHdl checks if xUnloadObj is null,
        *after* calling SdrOle2Obj::CanUnloadRunningObj with it.
        
        I don't know if it's OK to try to unload objects that don't return
        a valid XEmbeddedObject, so I decided to live dangerously and keep
        unloading those.
        
        Change-Id: Ib4901cbaf2dcd3ba4ae6fed983c09c10f1efe852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120633
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [f6a04457b8aa227deb9402e6406ea843fabfcbb0]

        tdf#137742: sw_ooxmlexport16: Add unittest
        
        Change-Id: Iefc6f78a3045ab844df5c9055379336a40ac7ae2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120671
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-18  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [eaac26c886a793dfb6c619a32a9fdeef98af3f79]

        tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton
        
        The original method SvTreeListBox::StartDrag always triggers
        a MouseButtonUp event and tries to initiate a Drag of a Line of
        a TreeListBox (on MouseMove, btw).
        
        This is not wanted if the last MouseButtonDown started a
        ButtonActive mode and activated CaptureMouse, prepared to
        trigger Action on that Button on MouseButtonUp. It leads to
        unwanted/strange behaviour of Buttons/CheckBoxes when used in
        TreeListBoxes.
        
        The behaviour is also dependent on the UI implementation used
        under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all
        (unfortunately) behaving differently, but a first suggestion/
        step to enhance the situation.
        
        Found now for gen/qt5/kf5 that when on the LineEntry, but
        not on the CheckBox, on MouseButtonUp the other line gets
        switched. Corrected that.
        
        Also moved call to base class method MouseButtonDown in
        SvTreeListBox to the end of function due to that call may
        lead to current incarnation getting disposed. That was
        the reason for the crash described in tdf#143749
        
        Note: for gtk3_kde5/gtk3 there remains the problem that the
        CheckBoxes get switched on MouseButtonDown, butt these are
        generic widgets and this needs to be solved differently.
        
        Change-Id: I9b73d9a7230469664dd6041f81b399e7d933852b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120593
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [0e88b550d79ea3346b08fe8e8276b7615d67c213]

        Do not forget to remove just unloaded object from the cache
        
        It turns out that unloading objects does not necessarily remove it
        from the cache automatically (e.g.,
        SdrLightEmbeddedClient_Impl::stateChanged is not called with
        respective change). In this case, the cache size grows, and it
        attempts to clear more excessive objects at each append.
        
        Remove the object explicitly after unloading to avoid it.
        
        Change-Id: I392c8eb6ef8e3fe89f148366021f61b9c0428a9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120637
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dbe4a9313d9844c10f71b29a77218d31bc6f3b3]

        loplugin:passstuffbyref
        
        Change-Id: I4f01eb3842ef198f02af274f54afb2760c820a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120655
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [9e1aee666fa48b768c829bbc707f47a98250df1e]

        Don't forget to break the loop early
        
        Change-Id: I56f99b976fd27c558ff4e3089b2c0f85250602f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120636
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [340bf7be0cf0453049cc0d7e1a263dde41d2a0cc]

        Remove redundant nullptr check
        
        The only place calling UnloadObj is UnloadCheckHdl, which already
        makes sure that the pointer is valid.
        
        Change-Id: I78bd89b76427d18af1f38b29a8cf93bf02592030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120634
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [d4a1aaca9fdeadcba86d7144165a691ea95ccf89]

        This check is redundant
        
        It was checked a few lines above.
        
        Change-Id: I04ae6fd34f36c54dee9097ff05aefcc9447738dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120635
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [4297f40c6ab03701ffebf670cbf1186573ba6a15]

        tdf#143778, tdf#143785: sw: add UItest
        
        Change-Id: I3a917feb4a3ea6f14e7236e1bcdbc8b9e2bcf93b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120654
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-18  Stephan Bergmann  <sbergman@redhat.com>  [65940d00f1b7788b6b4241bf33a10073993181db]

        Sync flatpak-manifest.in with Flathub
        
        ...including
        <https://github.com/flathub/org.libreoffice.LibreOffice/commit/2add5864d55a5cbe376da8a342549a8dbf46387b>
        "Merge pull request #158 from flathub/extensions:  Add an
        org.libreoffice.LibreOffice.BundledExtension extension point"
        
        Change-Id: I1a1515e8ece2d8aec83abb6c8775f784083573a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120667
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-18  Stephan Bergmann  <sbergman@redhat.com>  [4ef25107c144ea05ded1d797bf4d93f2d7044e14]

        Don't use std::ostream operator <<(char16_t const *) deleted in C++20
        
        similar to 4af56d8189012f96d0471d7f50a3e44636666516 "Don't use std::ostream
        operator <<(char16_t const *) deleted in C++20"
        
        Change-Id: Ica7b02c14b66fea64f630bed4943c04ae999485e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120662
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [83c4cdf4b8469dbe905349cc63b3b3512108e368]

        online: keep sidebar opened
        
        when we switch mode in online keep sidebar in opened
        state. For example when switching from notebookbar
        to classic mode - sidebar is set to "Tabs" what makes
        sidebar hidden in online. The same happened when
        crash occured.
        
        Change-Id: I5d0d1dba4c89b5e380a0bf717fabf4337016894c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119496
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120660
        Tested-by: Jenkins

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [358c7958b171eedac7b9b998448a27dd1b80af78]

        jsdialog: dump more options command for panels
        
        Change-Id: I04d71d318d97916f040de7a617a802dd895faed5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119104
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120659
        Tested-by: Jenkins

2021-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [e94444f8580f7e93604be816d49577a3bdf596ce]

        uitest: make use option 'Separated by' is checked
        
        Change-Id: I504e17ab015803662b051427a7e80aea2789ecf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120625
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [90cd3e13f1e4eeaf65cab75e5409169ae7e642ab]

        tdf#96561: sc: Add UItest
        
        Change-Id: I393860264a9411c503db5276c951b98124282540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120608
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-18  Rafael Lima  <rafael.palma.lima@gmail.com>  [4389c10217fd537ccc73621454bf7a280c7d0b6b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d42ad54f4c9c1b07ca851ce76ceb77f512c4f1ba
          - tdf#142574 Create help page on "wildcards"
            
            This patch creates the wildcards.xhp help page and makes the required adaptations in tree files to disambiguate "wildcards" and "regular expressions" in the help system.
            
            Change-Id: I82f1e192b6bf9e605fc3cfde50b648ce902cefdb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120573
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [19c6def56692ac23109f638f21a92c00b3d643bb]

        Fix erroneous comments
        
        At least they work symmetrically with set* counterparts,
        and seem to be used as returning radians.
        
        Change-Id: I6fedbb127ff587822dbea2351c51e2472edaa962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120591
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Yildiray  <yildiray_uskudar@hotmail.com>  [08058894d2da9e65b91a1dcdb997b70f69448fb3]

        tdf#139734:Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: Ie32c3dd5bf5fc1386cf2b480d88f97c7d11c2fcd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120325
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [e34ec3e196b3265ea640e1730c7d42dd6182e65f]

        Don't crash on SidebarController dispose when app is closing
        
        When app is closing it is possible SfxGetpApp() will return null. So
        GetCurrentTheme() cannot return reference to correct theme.
        Remember which theme has registered SidebarController to unregister when
        disposing.
        
        Change-Id: If223233f621601f445472b0413a56e9c51e59673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118970
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120630
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [f926356e1f48a461eb3157c1020de0bd48f76080]

        jsdialog: dump FixedImage
        
        Change-Id: I9803558fa19ef5e508817d5db0bdeb54827f63d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118969
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120629
        Tested-by: Jenkins

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [b0697a0501d7761a8b40cd03c6ae3c77b7d5e494]

        jsdialog: sidebar: do relayouting not too often
        
        To avoid jumping in Online avoid not needed relayouting.
        
        Change-Id: I4a59a9aa077de60ffd0486bb843fd2ce5b4174d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118936
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120628
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [88bf1749f1eb7322106da1254e349f51f5df0df5]

        undo changes to TextAlign
        
        revert commit 8689bd5490b473a7ffb149bbe5f7f0683f679c72
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Thu Jul 29 20:49:29 2021 +0100
        
            convert TextAlign to scoped enum
        
        lets leave this as it always was
        
        Change-Id: Id4d2a5644974cdd2b0ed6d361d5c52629674d057
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120626
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [821ae763cc03f69e226cdba66bb9c82c03483a23]

        ofz#37315: Invalid-enum-value
        
        Change-Id: I573ecf0cd1bd7b71ebf77a503d9937ee9f9d867c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120627
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [62d11b0e072b2f34b9f52c33a73cbb54d8112307]

        specialise std::optional for OutlineParaObject
        
        we can re-use the o3tl::wrapper pointer to indicate empty
        
        Change-Id: I26e502a7dacfb2bd3d465e71c8fdd89a6a80969b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120553
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [483ad8ac7e2374aa17dc83a4bf81fff1cbbcb98d]

        ofz#35787 skip expensive ResetAttr if the document is in dtor
        
        lets try it initially just for fuzzing builds
        
        Change-Id: I4ae08348c53756a8f3693ba7cd5c6c3e255d91bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [7bd26828933a682b7bca86e4fb26f4cf99fa33e0]

        tdf#143736 Fix loading hyperlink from various shapes
        
        Change-Id: I86de90ee605fab8f11e7c01892fbbff6acf790a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120609
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-18  Noel Grandin  <noelgrandin@gmail.com>  [392f19c957b55de1ce834cb465f51f27c2c7cf60]

        improve SvxShapeCollection::getByIndex
        
        Change-Id: I4cca7c0b6344241256d038902069a20ece314358
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120618
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [2665fe320363d03559cd29e75b78077b4a78e91f]

        jsdialog: dump selected state for toolitems
        
        Change-Id: I8c2c017168e4feae6e24118153906ee24ed90a5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118893
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120615
        Tested-by: Jenkins

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [0b538d1ca8893c0faff55e1e20e62f070fd411d6]

        jsdialog: dont use popular id for glow color
        
        to avoid confusing it on updates
        
        Change-Id: I2b19dc41a17e070ac1c8869d478c3b0b09a54223
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118692
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120614
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-18  Szymon Kłos  <szymon.klos@collabora.com>  [c2d32db5b1c401bf8412713a4416491337831f39]

        jsdialog: send type for popup messages
        
        Change-Id: Ic0f189645dc9a1164cbbc528b3a5d30d72ee3333
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118552
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120613
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [033dbb01f0688610338c80136ed73f2b412397ec]

        gtk3: fix warning about GtkBin already containing a widget
        
        Change-Id: I9df18e9cc865a8600f26605530eb99b9ba8f0d36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120607
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Yildiray  <yildiray_uskudar@hotmail.com>  [686528f3281ce60c1d5c12cb867b2b16081444af]

        tdf#114441 :Convert use of sal_uLong to better integer types
        
        Change-Id: Ifc7c1ce21f9dbaf77a0ae2ffa598e219809a250d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120541
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [aaabfc644afd57577980998c83f94a271f633c02]

        tdf#59820 - Adjust column width of imported ASCII files
        
        Don't adjust the optimal column width of imported ASCII files in Calc by
        using the simple text mode. In the simple text mode, the length of a
        column is determined solely by the length of a text and not by the
        actually needed size.
        
        Change-Id: I02a1e0fbfad88a31bd474124c2f4367b660bdfdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120514
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-18  Caolán McNamara  <caolanm@redhat.com>  [cc48aa1f852c72367b5f18d34f452629f03e4f20]

        ofz#37305: load of value 131 which is not a valid value for type 'bool'
        
        Change-Id: Icd535272bfc2ef62399fa889f73acd705b566973
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120622
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-18  Noel Grandin  <noel@peralex.com>  [f29ef71073bb31f05d6cc50f952e827134868c2d]

        avoid constructing OUString on hot path (tdf#105575)
        
        Change-Id: I7c9925fc7f68cdc9bd1a9c1834daabff09c8cf6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120604
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Noel Grandin  <noelgrandin@gmail.com>  [cc9bc379de14a5ecfcb7b510fe74beeab768f875]

        remove dead code
        
        ever since
            commit fd069bee7e57ad529c3c0974559fd2d84ec3151a
            Date:   Mon Sep 18 16:07:07 2000 +0000
            initial import
        
        Change-Id: I1fd724f2e4f31353da60d2615e6c840bbb88dfcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120619
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f46740abc225f5b4c7f604bf3ef32c503c7fc858]

        loplugin:sequenceloop also check for B2DPolyPolygon
        
        which has the same problem
        
        Change-Id: I98f9924626f26739e91d6a9d21e4276473ea314d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120620
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [ca3557bedef8dd968f6455875f574357801902c7]

        Simplify SdrTextObj::RecalcSnapRect
        
        Change-Id: Ieab3f3143e96af56c87720451de4194138f0463b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120590
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Mike Kaganski  <mike.kaganski@collabora.com>  [5b025285b3528910a4360899abb2bbbaadc72c97]

        Simplify Rect2Poly
        
        Change-Id: Ie20662c6040da8a77db8168a7aa32e001a01ae6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120589
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-18  Justin Luth  <justin_luth@sil.org>  [28a7fec1f6465f8bfee417d447eb2e684ffe040b]

        tdf#134569 writerfilter: move tableParaProps on table endLevel
        
        The end-level of a table only comes at the ::finishParagraph
        of the FOLLOWING paragraph. So for table-in-table, it is
        necessary to move the paragraph properties captured
        during the paragraph to the correct table level's collection.
        
        This fixes 7.0 regression from
        commit	81ce88aa80f8e7cde4fdc5b211e9500a3599643c
        
        and depends on prior commit
        related tdf#134569 writerfilter: negative means table end
        
        Change-Id: I83183f38e1cf68b7db09813ca1b4a2491e7b54e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120526
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-18  Ming Hua  <plateauwolf@qq.com>  [b10b26f01c241b939da9b49f22239d4fea23eb7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4f55790b32ad295322c712ed49d0349f4eea66d
          - ScriptForge Basic: fix example
            
            MB_* are properties of the service, so the service variable needs to be
            properly specified.
            
            Change-Id: I033f3e54ca69707c25030723fb5dc426a3ad6691
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120586
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [af1b2ea5a6d49ddeb376e83f8ca7d053b17afa20]

        Removed duplicated include
        
        Change-Id: I4103d44e0535b39555f2f62e36ce6109e39cabfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120595
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-08-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [4dc40659044566280c202e26cab97d682ae6ab54]

        rtl::Static -> thread-safe static local
        
        Change-Id: I9f8fe250813f4f376dc46c6f3d7e25e90fdbb50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  Noel Grandin  <noel@peralex.com>  [889df64fbb9534491b76140d63b4340091c763e4]

        reduce alloc costs for some basegfx objects (tdf#105575)
        
        we can use a default object for the default constructo case, and
        remove one malloc for each default constructed object
        
        Change-Id: I0bec37ef9161a210973abb25669a9f16a5e0ea75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120603
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  Caolán McNamara  <caolanm@redhat.com>  [3d45088a4885671a12dfa48e6c650cb896f7078e]

        Resolves: tdf#139220 with ~1000 selected shapes a11y UpdateSelection crawls
        
        so fetch the selected shapes once and sort them for quick lookup in the
        loop over maVisibleChildren.
        
        As an aside, not changed here, SvxShapeCollection::getByIndex looks
        suboptimal with a body of
        
        std::vector<Reference<uno::XInterface>> aElements(maShapeContainer.getElements());
        return uno::makeAny(Reference<drawing::XShape>(aElements[Index].get()));
        
        Change-Id: Idec7c003e7c5ee02000d4642d4fdb0d940548d97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120610
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [17f524a37c81a05e6d448a7186df858a69ada635]

        Fix o3tl::convert for Rectangle, to operate on right/bottom values
        
        ... instead of using confusing/ambiguous size having two interpretations.
        
        This reverts some of the unit test changes made in commit
        fa339b3adb53300ae68913bed87e18caf9f2e262.
        
        Change-Id: Ic56417703e32c1d92bcee76ad8ff494824bd4a1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120564
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Caolán McNamara  <caolanm@redhat.com>  [e8180aa5e7c03fe62d958e9e147136abd99ddf82]

        ofz: Indirect-leak
        
        Change-Id: Ia29c771d6dbdf37b55ce0e63cc73564bcea6f5c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120346
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3678fca9098d4e61135cc732e8e37da3e6cab626]

        Fix typo
        
        Change-Id: Ib67f29eec54557811eb1136673030249b296289e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120599
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3be26178dc29ed4f8637218e0d49d1bf77e124d2]

        Fix typo
        
        Change-Id: I8cf2ea25ee343b747497a8a83edb48c2421863bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120596
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-17  dante  <dante19031999@gmail.com>  [50f4d711337b84baf22536fac99150c116b0c700]

        Improvement to ml element exporter
        
        Change-Id: I12303add11406c0ab65ca02084945989f41380d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120549
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1e1a317be265a176fdbae171953fa8902a823eb8]

        Fix typo
        
        Change-Id: I93062ed58f820a0f88a236c4134ff9adce06006c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120601
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da9fc526f3bc84443ae37666d6775c5119b3f1e8]

        Fix typo
        
        Change-Id: I28ef5ac72fb06406d049e1076f48dcd2d06a42af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120600
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ba6b24bfea06ed10e4b9a595b424813d090b3a61]

        Fix typo
        
        Change-Id: I05739d1b82ec872cd8c7d68d3945893c9e6c3648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120597
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-17  Szymon Kłos  <szymon.klos@collabora.com>  [f5d3cfbc0b9bc34cc3297b8a1c179e4c158271b7]

        jsdialog: don't send unnecessary close message
        
        Change-Id: I4077c0871c7e6faf4917ad22a1a3aae8eb972961
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118549
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120569
        Tested-by: Jenkins

2021-08-17  Szymon Kłos  <szymon.klos@collabora.com>  [2ca212f93cb4ae1da84fa71bf70dde24784e8df7]

        jsdialog: sidebar: send message on sidebar close
        
        Revert needed code removed in 64bd4dd
        
        Change-Id: If45facbd68ea8f3af433b78e127fbb0745e62c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118483
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120565
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-17  Szymon Kłos  <szymon.klos@collabora.com>  [1692ee279c7d0a6aa8210c923a6923c6919f46d3]

        jsdialog: dump image for toolitems
        
        Change-Id: If47eb57cc18c6f04e5b2e3a14a6bcea657e03df8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118472
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120543
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-08-17  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [37dd6e18f5cf498d230ffe8a0a395cfdf9625e0c]

        tdf#143858: sw: default value for nInclUpperLevels is 1
        
        SvxNumberFormat::nInclUpperLevels (matches text:display-levels in ODF)
        bit incorrect in its name: is counts total amount of levels to display,
        including current level. So value "0" seems have no sense: display 0
        levels in total?
        
        In UI you can't select less than 1 level and ODF standard (19.797)
        using 1 as a default. This looks plausable.
        
        Change-Id: I596386c7b3cc4370910cd0ff6e927e501179fbdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120458
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-17  László Németh  <nemeth@numbertext.org>  [15f340f35cd9dc635d0507ca7de9d11227ae9922]

        tdf#143911 DOCX: export character formatting changes
        
        of text portions (instead of losing them completely,
        resulting missing rejection of tracked formatting changes
        later).
        
        Follow-up to commit 0115a77eb84afb0d820d8e23f45e49b30b82a8d3
        "tdf#50447 sw: track changes of character formatting" and
        commit 5322663f8234836a6a4aaaed025c158fd7e8b67a%5E%21
        "tdf#126206 DOCX: add rejection of character formatting changes".
        
        Change-Id: I7f00774875fe06d21865d9468fc1a63bd11d91ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120568
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [77ed538bcc9ff445462fd8c4c1c055b6e8dd2ce4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8c962ef5c3feb4f0ed970ab4c90efcace00f6e06
          - Update intro video for online Help pages
            
            The patch does not require translation.
            The videos is not loaded in offline Help
            
            Change-Id: Ia8f966d7dc48b3fe1547461a64d4430dfddf75fe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120594
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Caolán McNamara  <caolanm@redhat.com>  [1176c982d60b7e97ca063259326772495dbdde2c]

        Related: tdf#142003 add a test for this case
        
        Change-Id: I32ca1ccdcf221c0ef6933fa1018b5f2eb753fa7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [c3d71e0ab926bf5240994179f405be101cd3148b]

        Enable sd pdf import tests on Windows
        
        Change-Id: I101e59a6ce1a3467a1f743bdcc288b16307eb5a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120579
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Gökay ŞATIR  <gokaysatir@gmail.com>  [15d89ca199d78e9b3b0775c1e720c1500f514d8b]

        Use new json_writer class for json objects.
        
        Change-Id: I68b43829250201a716e2ec10968b90eadcba7fca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120567
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
        Tested-by: Jenkins

2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [6fd0d2af5069ec23b25b7e7e2e024df9e3319a0a]

        Rename SaturatingSet[XY] to SaturatingSetPos[XY]
        
        ... to align with commit 4639ca2f878b04ffc50d9c20d92e90464d2d67a7
        
        Change-Id: Ibec7a451a61ca7f2d141a9624369a6f9656ed468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120562
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Caolán McNamara  <caolanm@redhat.com>  [b5870d727685ec10447e8ae446ada895250fec2e]

        Resolves: tdf#142003 tracked changes in footnotes offset in .doc import
        
        Reverts:
        
        commit e71d05eaa9a8c9e628b256f3e889b85ac11ed474
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Fri Apr 27 15:42:26 2018 +0100
        
            ofz#8038 defer subdocument redlining to end of parse like main document
        
        Change-Id: Ie8d7a98c7927dcba53228ebcd991d715d8faabe7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120563
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [28708b5b7ad12bc30f02142c990e5ad4128af912]

        Simplify and inline tools::Rectangle::Justify
        
        Change-Id: I535fb70fa532d98542ac30e0b2053bdaa6b94383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120494
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Szymon Kłos  <szymon.klos@collabora.com>  [8e5cb2bcae998b8606de12c7bc4cde1f98346190]

        jsdialog: image for radiobuttons
        
        Change-Id: Ic6027223c5771ffb659a4503cfd305d0decc2433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118465
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119244
        Tested-by: Jenkins

2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [d3a94eeabbd33cb2bb43856f0d1d93202b204b5e]

        Make IdleFormatAndUpdate private
        
        Change-Id: Ifecc0653de27bbc0cf483147c87a11d5cd307090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120574
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [8c8d878632f4aa32a63080f6956b8cb76f48af0f]

        rename SetRectsDirty->SetBoundAndSnapRectsDirty
        
        because there are lots of things being marked dirty, and I like to be
        sure I know what the code is doing
        
        Change-Id: Ifd0380c5560adc4a054495551885fe33af4f3e5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  Caolán McNamara  <caolanm@redhat.com>  [c64f221fc2e22ffa60c4d78240893f7f04531b3e]

        tdf#143778 these async callbacks expect to have SdrModel::IsChanged of false
        
        when they are entered. They are adapted from the original non-async
        SwDrawShell::ExecDrawDlg where the start of SwDrawShell::ExecDrawDlg has...
        
        bool bChanged = pDoc->IsChanged();
        pDoc->SetChanged(false);
        
        and the end has
        
        if (pDoc->IsChanged())
            GetShell().SetModified();
        else
            if (bChanged)
                pDoc->SetChanged();
        
        and before async dialogs the start and end happened before and after the
        dialog appeared and disappeared. The intent seems to be unset the
        sdrmodel-changed and restore its original state if the dialogs caused
        nothing to happen and to explicitly set SetModified on the document if
        something did.
        
        Now the async dialogs callback happens after SwDrawShell::ExecDrawDlg
        has ended and so the callbacks start with SdrModel::IsChanged at its
        original value (restored by the end of ExecDrawDlg), not the "false"
        they were originally written to expect.
        
        For simplicity set the SdrModel IsChanged to false at the start of the
        callbacks and continue to restore to the passed in bChanged state
        if there was no changes by the callback.
        
        Change-Id: I671b35acab6d1b391fa7e6590c09f8be135449b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120548
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-17  Rafael Lima  <rafael.palma.lima@gmail.com>  [2cfb367aaf3f8b99d3abd4025ca59352fe18a652]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3a58cb35bdb6e11e7a80759b59d4c68fcd3c6be7
          - Improve VALUE function help page
            
            The help page for the VALUE function is created as a separate help page func_value.xhp.
            
            This patch also refactors related help pages NUMBERVALUE, DATEVALUE and TIMEVALUE. Their main header was <h2> instead of <h1>.
            
            Change-Id: Ic67893f0c35a58a19f13af1d34d68956e901a4a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120361
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [8f26c8db3d690f90f1e98c42f39cf6324eab9798]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 70819b10363aba5cce4c1655dae622b5e3776d51
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia985134bc5f4176d268789cb2d47c5aae3173c4c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120507
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [3f072f01c7590128c4f3101d9dc45f1869359459]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3727f5d65d1970e68afc035589d0110491b854fc
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8f35262705de1b4b36d8f08bbfa7a211021f1437
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120506
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [e499fdeea391677f35b43bb1cdaa1def4d97477a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b3f5894e07ead76b9e24f0b06ea50fb37a437181
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9074ed3ca9433a7c54112ec9d81074d78ead1c8a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120505
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [90f6d777511764ce4162cb057c04ef9b192f06d5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 403b80b8111c08a425c45e8d027db95505e1ea9c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I14799211a08b8483c7ce2c54de7627442dc306be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120504
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [0a4dbc8be3f1c1bc0287d3de6bc61ad94c3a0df2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7a0879706b5f0eca1e1b33d69b783367846777dd
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia0359785a6c5931fc30db213da9be0afe7342c82
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120503
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [68646691df1311b051df38e8bbee1e18017ab16a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 767b7b24ca43bab9bf816953194092aa6a37ac9e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic691f25163c2d877ab8caf950e6ae4173ced9fc5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120501
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [034acb5986deccc6c23ffd6bda2a65915a0f02a3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 528c80d79f1b304cd5074a1904f66cf58c8b6f75
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icd6db13fa8cf01304662535802ad938ff9e3fc77
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120502
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Mike Kaganski  <mike.kaganski@collabora.com>  [59e969def7488977be8c554d37bebe535c6511cb]

        Fix ctor taking Point and Size, to properly handle regative sizes
        
        (alinged to SetSize)
        
        Change-Id: I123a584ead91faae0fec4d25938529b2d68e4a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120559
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Szymon Kłos  <szymon.klos@collabora.com>  [615a340fcf05845397ea3c9917e2eadf074b4514]

        jsdialog: simplify popup code
        
        Change-Id: I3a84b1f7c8521b861e99384872127bb4d224c18b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118409
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120542
        Tested-by: Jenkins

2021-08-17  Hossein  <hossein@libreoffice.org>  [5a3f9ff4b6bd4a351efbdf0226aad03eba9456be]

        Converted Color type input parameters to hex values
        
        Used a script to convert Color type input parameters from base 10
        to hexadecimal values. Also, Used a script to convert them back to
        make sure the values are correct. The result of converting back and
        forth showed that the conversion is done correctly.
        Previously, some of the Color type input parameters were in hex, and
        some of them were in base 10.
        
        Change-Id: I95a465a2cb603580dee6404c53a9981f5cc5cb38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120516
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  dante  <dante19031999@gmail.com>  [6ff56167cb2e6ae6e354663c8c07810d432819c1]

        Add import for new starmath mathml elements
        
        Change-Id: Ie867cda8780747e715d642a9b007faafb33b4d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-17  Anshu  <anshukhare50@gmail.com>  [39e969ac53b7e0b2c4889a3f910d97521ec4251f]

        Refactoring
        
        Change-Id: I0863c4afb5dfce549dbcbdae4b8a63068e5d7331
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119878
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-17  Johnny_M  <klasse@partyheld.de>  [eeca6567cde1e0f6a7a6827118479d996adc1286]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab694d7b891492ba6f7c5c789b40f8e723dcffe4
          - tdf#132643 Translate German section IDs
            
            Change-Id: If8cd5ef6b3e80661b495173f8307b5fa8af6a8ce
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120500
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [22ba15fc53ee79ec207cdfafbab1afd508921873]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d279d4e95c1a27278c52c095d711b95a29e1615
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8ad927aaf3e1a677ce8ef2ae5133ec471a9be48f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120499
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  Johnny_M  <klasse@partyheld.de>  [5b3205cffb9304f2c065bd8c4785b51cad4ba21f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 063af8291cfbec87bced24279f9ec624c7682744
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: I8bb4f495667769ff5f6ee9646d0236dceac00250
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120498
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-17  tushar  <tusharrai282@gmail.com>  [77814f90aef50902383cba3aa4e37c68b6ca2b12]

        Add Delete Row Transformation.
        
        Rows having specific value in a column will be deleted.
        
        Change-Id: I0b39e1127215c59062db11351a656e75d71a04aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120296
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-08-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [aad823538b1c277a9bf5e8e82883abbd0cd66ccb]

        drawinglayer: remove recurring def. of namespace wmfemfhelper
        
        Change-Id: Ie997afa3127fce9fe9de5b0359f54b1890dd6a21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120558
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-17  panoskorovesis  <panoskorovesis@outlook.com>  [5fae719ac2b26510143a181ccbc4f943c3a72b48]

        Remove metaact::Write and metaact.hxx:Read
        
        Their functionality is implemented from the appropriate
        handlers in SvmWriter and SvmReader respectively
        Also remove ReadMetaAction, meta_action_name as they are not used anymore
        
        Change-Id: I10e846226426d40579310ea0e1bc411ac018991b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120471
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-17  panoskorovesis  <panoskorovesis@outlook.com>  [9bd336d6566897a6d2238bf38f927a20ae981da9]

        Move GDIMetaFile::GetChecksum to SvmWriter::GetChecksum
        
        Move the method and update all the method calls from
        GDIMetaFile::GetChecksum -> SvmWriter::GetChecksum
        Remove the method from gdimtf
        
        Change-Id: I68e2b3cf99178947ac4f1474810dd5568f07e122
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120414
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-17  panoskorovesis  <panoskorovesis@outlook.com>  [20d48960d7c6d1fda499983853c9c4e4c9b3f9e1]

        Remove unused methods from gdimtf.hxx
        
        Remove GDIMetaFile::Read, ReadGDIMetaFile, GDIMetaFile::Write,
        WriteGDIMetaFile. Their functionality is covered from SvmReader::Read
        and SvmWriter::Write respectively
        
        Change-Id: Id3d22e251d19c2898359a6c1dbeffbc53419540b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120409
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-17  panoskorovesis  <panoskorovesis@outlook.com>  [e7b6205bcf127d8afab8dfd015fef7573b296a22]

        Replace GDIMetaFile::Write and WriteGDIMetaFile with SvmWriter::Write
        
        Use the new write functionality. This change also sets SvmWriter::Write
        second argument as const, as it's value does not change
        
        Change-Id: I1620756542a0bc54b5f8fc7ce3f57d0243a2ee55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120408
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd3ab0fd737ff84657ff34eebafe2628f489e5a1]

        Fix typos
        
        Change-Id: I2a0a3d8eff5e6f1d456128f71519d132b8839e28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120481
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-16  Eike Rathke  <erack@redhat.com>  [7bd03074ae7362d8fffe5182529626a0b43a0ed1]

        Resolves: tdf#96561 Include embedded null-characters while assembling CSV line
        
        ... instead of prematurely ending analysis and skipping the
        remainder that is still part of data read.
        
        Change-Id: I8f34bc9672e37f9c1c1ae81ddeba464360add7c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120555
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-16  Emircan Agac  <thesadson@gmail.com>  [42f536df5c5b15d34c7c5663c6653d5bedbc2dc2]

        tdf#130924 : replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: I4ca3a3a7ced1dac90ae896cc8a0abb08f830744e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120551
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ea7b9f87556414d37b83a5dd45cd944d97597ad1]

        tdf#143896: sc_uicalc: Add unittest
        
        Change-Id: Idb8aa411a9e9d2c83346f21705ff4ae5aef74aab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120554
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-16  Caolán McNamara  <caolanm@redhat.com>  [6dc23567639bebf18ceb8d9a3721228bffe14202]

        Resolves: tdf#143785 save/restore SdrModel::IsChanged
        
        Change-Id: I253915c359cf72f80b21e21ff34e0ee406e5b3a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120550
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-16  Noel Grandin  <noel@peralex.com>  [58b2d04ddab5a678921610bf9e9a5a95ae660a17]

        do less copying when constructing 2d sequence (tdf#105575)
        
        instead of constructing a child sequence, and appending that
        a parent sequence, just pass the parent sequence down the call
        hierarchy, so we end up doing less copying.
        
        Change-Id: If39a0779e543c6aa01f5e2e3ae63d395e0c85f7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-16  Julien Nabet  <serval2412@yahoo.fr>  [faee2796e3f3d98521b4b23b167b688171560254]

        tdf#143896: FILESAVE XLS(X) 1001+ rows are lost after saving new file
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=2bf3e0d00e3bccb5b250642ee0d3fdbe6cae8ecc
        tdf#104502 sc: skip hidden columns at printing pages
        Page calculation counted the hidden columns, resulted
        printing blank pages by accident.
        
        Extend GetPrintArea() and GetTableArea() to count pages
        without the hidden columns, too.
        
        Change-Id: I77e7d6d893967a3ddac4c7c4e225769b38b44649
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120552
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [4639ca2f878b04ffc50d9c20d92e90464d2d67a7]

        Rename setX/setY to SetPosX/SetPosY, to align with SetPos
        
        Change-Id: I856194f26fefad993f416d7b92b57a9417a3c0a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120546
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [766b95d58299a1f2eb0d05d67e3afbf95bd9334d]

        remove unnecessary capture
        
        Change-Id: Ib6f4b62601c68d04269eba66f3f68a7a62022aeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120537
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-16  Justin Luth  <justin_luth@sil.org>  [33d588ab553652637e90ecd543c1ffa6301c762b]

        related tdf#134569 writerfilter: negative means table end
        
        TableManager's EndParagraph uses mnTableDepthNew - mnTableDepth
        to identify that a positive is startLevel,
        and a negative is endLevel.
        So it doesn't make much sense to have this function
        return a huge unsigned int in case of a negative.
        
        As expected, an assert proves that LN_CT_TcPrBase_tcW
        can happen for both positive and negative,
        so the equivalent test is just a non-zero.
        An assert proves that startLevel always has
        a positive difference, so that clause can stay as is.
        
        Change-Id: I1b49dfae7087258e4ceed5fb45da0e62fd1f3b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120525
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [b336dca9864390a0e19ae3f4518725eba6be2ffc]

        use tools::Json for cursor messages
        
        and tweak the JsonWriter to produce output more like the boost propertytree,
        to make the cypress tests happier.
        
        Change-Id: Ia2062508ae9f14a5f89306042c33884ff300f478
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119936
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        (cherry picked from commit d46c7bd597e51453ac420db97fd898ed2f3b26bf)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120433
        Tested-by: Jenkins

2021-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [8e63f79f0ab23013f81e54b36d1e0678e9e681dc]

        improve documentation for comphelper::OMultiTypeInterfaceContainerHelper2
        
        Change-Id: I7ac6cf075f2f143bf080d9ee2f74840c3f56d61a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120538
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [821d2f8c058f7b7f45e23203d98aa9237289e265]

        tdf#126879 - Drop obsolete DOCTYPE HTML 4.0
        
        and use the HTML5 DOCTYPE declaration
        
        Change-Id: I00a769f2c8da876fd9435343c72f4d7685bc0cb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120378
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-16  Eike Rathke  <erack@redhat.com>  [4ecb94da9fdd00f24b02020151ac4d27d5514d5f]

        Resolves: tdf#142980 Special-case the very first listener added during action
        
        Change-Id: I8bc3475581d9525db8e83bc1551326c474e752bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119275
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-16  Emircan Agac  <thesadson@gmail.com>  [617fc3a0ed28b0ccc7fa658e4ba13a0fc9fb353b]

        tdf#130924 : replace debugging printf calls with SAL_INFO/SAL_WARN
        
        Change-Id: Iafe15a9ab48f1c0e09b5e6c176ecda3d5b4ce1bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120479
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8103862e78c2bbed18f0da82231d4be576083da]

        no need to make a local copy here
        
        Change-Id: I54891bccd13ee3e63a6c737c47754ffaea354692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120539
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-16  Julien Nabet  <serval2412@yahoo.fr>  [997ff7166ceca0a5af80297a0e789af2ff0c6617]

        Related tdf#143895: Mysql MEDIUMINT is DataType::INTEGER not DataType::SMALLINT
        
        Change-Id: I324b18cc164cb2f38b7b8411c557c6c208e8d69d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120536
        Reviewed-by: Lionel Mamane <lionel@mamane.lu>
        Tested-by: Jenkins

2021-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [581b2cf7960c48e6199bd35be839424113abe533]

        Drop tools::Rectangle::getX/getY, which are just duplicates of Left/Top
        
        The change allowed to simplify many places where previously this API was
        used, to avoid inefficient calculations (e.g., moving rectangle keeping
        its size, and then immediately changing the size).
        
        Change-Id: Ica2dc594d91cae83e2c2740c1f4fb23f44998916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120461
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-16  Julien Nabet  <serval2412@yahoo.fr>  [76f89b0097c02fa68c36cfc9a31de3b2e9166abc]

        tdf#143656: Tools > SQL : add a checkbox to enable Direct SQL
        
        Change-Id: Ib3902d031777643f4814e5cfb11fdd2e0d39fce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120535
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-16  Dennis Francis  <dennis.francis@collabora.com>  [1241983ec433598e70bc422d769750bfbd094431]

        sc: lok: avoid selection jumps with multiple users
        
        In LOK case, avoid spurious "leavingwindow" mouse move events which has
        negative coordinates. We later use these coordinates to compute the cell
        address corresponding to the event to extend the selection which will be
        wrong in this case. Such spurious events occur for some reason when a
        user is selecting a range, (even when not leaving the view area) with
        one or more other viewers in that sheet. The root cause of these bad
        coordinates seems to be in vcl
        
        in winproc.cxx, ImplHandleMouseEvent() in the code block starting
        ```
        // test for mouseleave and mouseenter
        VclPtr<vcl::Window> pMouseMoveWin = pWinFrameData->mpMouseMoveWin;
        if ( pChild != pMouseMoveWin )
        {
            if ( pMouseMoveWin )
            {
        	Point aLeaveMousePos = pMouseMoveWin->ImplFrameToOutput( aMousePos );
        ```
        
        This needs more investigation. Meanwhile this interim patch fixes the
        issue of selection jump by avoiding those unhelpful mouse events.
        
        Conflicts:
        	sc/source/ui/view/gridwin.cxx
        
        Change-Id: I01fb3ae6a3903ada2a44a8b3d2b4a46b0122326b
        Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120317
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        (cherry picked from commit 7eb8a1d6c5697fd89ff75d3b116bbbf6c2de6950)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120443
        Tested-by: Jenkins

2021-08-16  László Németh  <nemeth@numbertext.org>  [0115a77eb84afb0d820d8e23f45e49b30b82a8d3]

        tdf#50447 sw: track changes of character formatting
        
        Only range of the formatting change was tracked,
        but not the original direct character formatting of the text.
        Now rejection of the tracked change of a text portion
        resets the original direct formatting.
        
        Note: nor ODT or DOCX export hasn't been supported, yet.
        
        See also commit 5322663f8234836a6a4aaaed025c158fd7e8b67a
        "tdf#126206 DOCX: add rejection of character formatting changes".
        
        Change-Id: I6e94a797605187cff232c3d7dd505c769b70601b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120466
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-16  homeboy445  <akshitsan13@gmail.com>  [e401a3385ae9dd767bc815085535cd30a658f054]

        backendtest: Asymmetrical Filled Drop Like Shape test
        
        Change-Id: Iacf121483aefa71d6f24e14782fcaf22c0d5d56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118859
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-16  Julien Nabet  <serval2412@yahoo.fr>  [183f66f79b40b6159a0edcf1b49c3aa612c90525]

        Revert "tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton"
        
        This reverts commit ca7dab5d96e73b7b4b045e2460e0b2ee150757db.
        
        It created tdf#143749 + the dup tdf#143865
        
        Change-Id: Ibd68c45213491b0df7dc36f0418de307412499c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120531
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-16  Caolán McNamara  <caolanm@redhat.com>  [017a96aeb8f597de0f739fa8ba29dc56a28c9c0c]

        ofz: log with date -u
        
        Change-Id: I9e85ee0f98c3b7cfab15db5e93f65a053996bf00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120534
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-16  Caolán McNamara  <caolanm@redhat.com>  [d1ca1f6fef89e6500ca0743e18b8f62d197bf600]

        ofz: use system curl .a and system glm headers
        
        Change-Id: Idf4aa5f8d76afb3f0842830c2c874a10241ecc3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120528
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-16  Noel Grandin  <noelgrandin@gmail.com>  [eec42f0dbcc79a4c9f456ce97fa1066b8031ea28]

        pass OutlinerParaObject around by value
        
        since it uses o3tl::cow_wrapper, so it is really just a wrapper
        around a pointer, no point in allocating it on the heap
        
        Remove assert in SdrText::SetOutlinerParaObject, which was
        bogus anyhow, because it was comparing pointers, not deep equality.
        And since we are now being more efficient and avoiding
        copying of the internal data in OutlinerParaObject, we hit
        this assert.
        
        Change-Id: I6dbfaab5ee2ca05b2001baf63110041e469df9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120510
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-16  Mike Kaganski  <mike.kaganski@collabora.com>  [a6ca6215a5ec82e833ebfcd2ebd4455cb504fd8e]

        Use o3tl::toTwips to define MINBODY
        
        This changes its value from 56 to the proper 57.
        
        See 9be17c52b7c565758088b8020a543d7b840e31a7, which had
        changed the previous 5-mm value to the incorrectly rounded
        1-mm value; and cefce1a247a4674c5726a31b61571eab16328a0b,
        which had unified the other places mentioning i19922.
        
        Change-Id: I7186320b4c1a2a65a6f728ed8bafcbf0eb45c4cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120441
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-16  Pranam Lashkari  <lpranam@collabora.com>  [f4538c29079a4a940540e5194075aaeee4d0ba3a]

        LOK: freemium: added new parameter in the API
        
        Added new parameter in the freemium API to make it consistent with other APIs
        
        Change-Id: Ieb73fd1f97e1886051b1de44a93ba87622862e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119974
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120484
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2021-08-16  Miklos Vajna  <vmiklos@collabora.com>  [085797cb5c26a274328fa639a8100bd52cd9652d]

        sfx2: fix uninitialized SfxViewShell::mbLOKIsFreemiumView
        
        Introduced in commit 1b9fe58acb7b5bbbc83ecca30e17663fff7f0db4 (LOK:
        introduced Freemium LOK API, 2021-06-02).
        
        Change-Id: Ifdd6c13a64a167fa00b0305441c52340167f3809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118632
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120483
        Tested-by: Jenkins

2021-08-16  Pranam Lashkari  <lpranam@collabora.com>  [513120d24c770079773559367202d54ff62b39b4]

        LOK: introduced Freemium LOK API
        
        also block the uno commands from deny list
        
        Change-Id: Iee994411891b73b865e6496403682f996d5e9321
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116384
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120482
        Tested-by: Jenkins

2021-08-16  Hossein  <hossein@libreoffice.org>  [f34146b7d5d0bb66c805504a691cb70d5b3da6b2]

        Cleaning up decleration and initialization of unique_ptr variables
        
        Cleaning up decleration and initialization of unique_ptr variables
        pPageSizeItem, pPageLRMarginItem, and pPageULMarginItem according to
        the request:
        https://gerrit.libreoffice.org/c/core/+/120456
        
        Change-Id: I0cf5149308fe06c10403bfb82ca6a1786096bf3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120520
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [5aac78e5fb241050a86714687e9ff8804588ae3c]

        tdf#132739: sw_htmlexport: Add unittest
        
        Change-Id: I69a5b0659d8b9a13b662ee1e7612e056f9d3ce4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120512
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-15  Caolán McNamara  <caolanm@redhat.com>  [9f84cd2766e66bf3bd7878e50a6732f8fca63ed7]

        crashtesting: failure on export tdf87915-2.odt to docx
        
        in this example ConvertToPolyObj returned a SdrObjGroup* so cast to
        SdrPathObj* goes wrong.
        
        new since
        
        commit 61ef73bb9e06ac7325abc26698314d7e35c164cc
        Date:   Sun Aug 8 01:05:09 2021 +0200
        
            tdf#143432 and more, improve wrap contour export
        
        Change-Id: I80312971fbe7e5b6e17e7ae41f2afbbb05f21d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120515
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [b338d215894b518098747caf0a03ea108bbd2fa3]

        tdf#142760: sw_ww8export3: Add unittest
        
        Change-Id: I82a1e8b8ddf5e392b9c2b578247a2364864a0970
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120513
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-15  Regina Henschel  <rb.henschel@t-online.de>  [24a8e3209b1d7c2f4f13d5cc3f69726253af9eff]

        tdf#143860 non-primitive needs custGeom not prstGeom
        
        Error was, that for a custom shape with type 'non-primitive' method
        DMLPresetShapeExporter::WriteShape() was called. For such shapes the
        method GetOOXMLPresetGeometry() returns preset type 'rect' and in case
        the shape had no handles, that preset geometry was written.
        In my solution I exclude shapes of type 'non-primitive' from using
        DMLPresetShapeExporter, because such shapes never belong to a OOXML
        preset shape.
        
        Change-Id: I714f69c98fe15c2b7e70dc0a474a7f85ad757034
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120511
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-08-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d5039e7b4c79b40cf6efb70dd703629cc367fcbf]

        Fix typos
        
        Change-Id: I3b75c0b8500bebe3025e038dba02a0d6f444bce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120181
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [00f257a7ef4f1ec52887bc379c14757e057e94c8]

        rtl::Static -> thread-safe static local
        
        Change-Id: Iac0501e6aa35cc3d8e62f6b6e68b76cf70233aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-15  Mike Kaganski  <mike.kaganski@collabora.com>  [6c12c659fb22aeab1d1d5d0e8298662e2a602499]

        Simplify tools::Rectangle a bit
        
        1. Simplify/delegate ctors
        2. Simplify getWidth/getHeight
        3. Simplify expand
        4. Simplify operators += / -= / + / -
        
        Change-Id: I023aa1bb2905394fbbd29adc7c544d629f9ae2d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120476
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-15  dante  <dante19031999@gmail.com>  [ffaaec23ad94f9bec5fd0fcb02603270eb660b81]

        Add the possibility to check if a mathml attribute is manually set
        
        Change-Id: I9c5eaee8e2cce47d9286306031e807ca2c0eed57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-15  dante  <dante19031999@gmail.com>  [73b6462b81080c63e6668979f4a9cd00242925e9]

        Add the Form attribute to mo
        
        Change-Id: I4f64460e15c707fa8ecdcfdfbea460b2f1410947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120469
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-15  Eike Rathke  <erack@redhat.com>  [6c4ff1d23ef61e708f3450d1b0ae77cc78cac731]

        Avoid computing LanguageTag fallbacks several hundred times
        
        ... over and over again even for known and present locales for
        each and every localizable config item.
        
        Change-Id: I19974c56169f45a7c53ed6b0eede47365e1365dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120496
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-15  Eike Rathke  <erack@redhat.com>  [23f17b7ea6fbd2f422c7e40192ae60e4df25224c]

        Resolves: tdf#137742 Workaround cheesy Google Docs writing language-only tags
        
        Change-Id: I2dc85abb70d53769d2e36102070e30ed71e8d888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120495
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-14  Caolán McNamara  <caolanm@redhat.com>  [c6604b69cf7f84146cae541366c023eaff4c59b6]

        upgrade to openssl-1.1.1k
        
        Change-Id: Ibd930ab4f97e2f74868b73163d7f2f46fb466749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-14  Caolán McNamara  <caolanm@redhat.com>  [175a313744e66325053f962ff7a65213e48ebb36]

        cid#1490212 silence Untrusted divisor
        
        "The divisor could be controlled by an attacker, who could cause a
        division by zero." but this division can only happen if the divisor is
        either 8 or 4
        
        Change-Id: I7cae93f48d84e023912b8613be89cf9db5589d4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120489
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-14  Caolán McNamara  <caolanm@redhat.com>  [d51c383b0204057e1b341db2d38b6d2dbb0c84e8]

        ofz: build with system libexttextcat
        
        Change-Id: I1dd2c49bfc5577a8502eb42721f3ef9b08f8fdb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120485
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-14  Regina Henschel  <rb.henschel@t-online.de>  [925fa608d65a5970f966d45e33cccf04e2318060]

        tdf#142605 use frame size in oox export of BezierCurve
        
        The export had used the bound rectangle of PolyPolygonBezier. But that
        contains control points. Use API position and size instead.
        
        I have not incorporated the changes into existing WritePolyPolygon,
        but have made an own version for SdrPathObj, because I find it easier
        to read and maintain, than having a lot of case distinctions depending
        on the shape type.
        
        Change-Id: I2e646c4f5fa37174c4979855212ca72f2dfa447e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120407
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-08-14  Yildiray  <yildiray_uskudar@hotmail.com>  [768722ea12779e5c533d691c311b63490e2279d0]

        tdf#143148: Use pragma once in sdext
        
        Change-Id: Ic626b9064d9bcd024f938bbd43375bc3fff5838f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120178
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [101b8ec5bfe458614ad50866dff9ba26f29163a4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a5ea0c841f16a2cfaa8b00ca15aecae1b59e9d1b
          - Create help page for the "Search Commands" feature
            
            Change-Id: Ic62e9671575709ca3ac788495edaf4b2753499ee
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120245
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-08-14  Hossein  <hossein@libreoffice.org>  [ba89f161432962d76a45288eb7289ffb7e128db2]

        Fixed documentation references to the custom shape generate script
        
        * Fixed references to the custom shape generation script in the
          oox/README.md to use generate.sh instead of README.md
        * Added README.md to oox/source/drawingml/customshapes folder
        * Moved documentation parts from the script to the README.md
        
        The README script was renamed to generate.sh before in the commit
        59577dbb84fae18a3216d57ffec6008af157ce9b
        
        Change-Id: Id167b32c7a101806c33126ea1642a0194d693231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119376
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-14  Noel Grandin  <noelgrandin@gmail.com>  [ecfc229b090473ad28d4b6947e2e0e0d9cd3ef4b]

        flatten svt::table::DefaultInputHandler
        
        Change-Id: Idba4039bbedd7c276505c5e9763b559d505cf7a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120467
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-14  Noel Grandin  <noelgrandin@gmail.com>  [7322fb1ed21cefe9faecc8cd5d088a3476283b5a]

        flatten OFlowChainedText
        
        Change-Id: I0836d1f850c71700f8691cf8847e4f4d30d4dbb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-14  Emircan Agac  <thesadson@gmail.com>  [d5eceef8e02886edc142267ee8d74f7adb198a1b]

        tdf#140226: use StaticWhichCast
        
        Change-Id: I5eb25fdfd629e397582cd49e3fa4acab32c05bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120456
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-14  Emircan Agac  <thesadson@gmail.com>  [1fdb3f98590532705be9972d031eb09027795760]

        tdf#140226: use StaticWhichCast
        
        Change-Id: I54f898d3341155d88b6b9599995b9e5001de71c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120406
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-14  Noel Grandin  <noelgrandin@gmail.com>  [17d2247a66b6a9e3105b0a8b8e6d6b5bea5e3ed4]

        formatter maps can use unordered_map
        
        Change-Id: I733537e98cccc1a5dcb2c275b3baeb56af5f15c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120468
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-14  Emircan Agac  <thesadson@gmail.com>  [da76d817400242934fdaebcdb226abf3d6595f56]

        tdf#140226: use StaticWhichCast
        
        Change-Id: I013b6ff371992a31a1ee11f93072eeb49566fe52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120401
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-13  Jan-Marek Glogowski  <glogow@fbihome.de>  [c820cb429fc3d3eec9bf6596f0a34995cbd93982]

        Help older linkers (Ubuntu 18.04, Fedora 31)
        
        Fixes a regression from commit 429e6e6efbfbc65d36452cbf8b3a25740a1dc8bc
        ("osl::Mutex->std::mutex in OInputStreamHelper"), which results in
        failed linking with some older toolchains:
        
        /usr/bin/ld.gold: error: workdir/CxxObject/xmlsecurity/source/helper/UriBindingHelper.o:
          requires dynamic R_X86_64_PC32 reloc against '_ZThn40_N3utl18OInputStreamHelper7acquireEv'
          which may overflow at runtime; recompile with -fPIC
        include/com/sun/star/uno/Reference.hxx:240: error: undefined reference to
          'non-virtual thunk to utl::OInputStreamHelper::acquire()'
        collect2: error: ld returned 1 exit status
        xmlsecurity/Library_xmlsecurity.mk:10: recipe for target
          'symbols/instdir/program/libxmlsecurity.so' failed
        
        Known problematic setups are my Ubuntu 18.04 build schroot and
        Caolán's Fedora 31 VM to run Coverity.
        
        Change-Id: I40f0734a0cb9131193abf21ba95dc63816b5c1d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120426
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [6f986e881c551ae218b95c162de67433901df85f]

        let return in java param dialog entry 'add' when possible
        
        Change-Id: Idfa2283dde0596db5c7fe2b56e8db761a5c75fc9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120465
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [e7fe47fdea4ab7d226e752b11e21b178060ac870]

        cid#1490212 try and silence bogus divide by zero Untrusted divisor
        
        Change-Id: I132d01c6007cd1da47f7dc405cfc3c4967757241
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120464
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [9b564e8b32be960b1be2caa377a52e84606270bb]

        cid#1490210 silence Arguments in wrong order
        
        Change-Id: I8767fe556142ec7e3254eaff56bbb1b4eb8322e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120462
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Miklos Vajna  <vmiklos@collabora.com>  [f966b9e8bb2b5e7e563807d16088a9f3784f01fe]

        bibliography, local URL: better starting directory when picking a new file
        
        Improve the case when we have no old file, so we can't take its old
        parent directory as a starting point in the file picker, opened by the
        browse button.
        
        It turns out both places that open that file picker have access to the
        base URL of the current document, so can open the directory of that
        instead.
        
        Change-Id: I4db84b6036771f48962d49ae5e4c46a99c306def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120455
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [c69aadfec031535c5b6266dcb97d40225f40eb9b]

        pre-select todays's date if the date is empty
        
        Change-Id: If34dbb31d14512b7a7c2a76a3adeb99882a8c60c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120457
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Emircan Agac  <thesadson@gmail.com>  [ca7e81099b65a72762699791fe114df4743fca13]

        tdf#143148:Use pragma once instead of include guards
        
        Change-Id: Ib3c0d6c158e5efbbca55e03f189dccaf67832a96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119888
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Jenkins

2021-08-13  Andreas-Kainz  <kainz.a@gmail.com>  [3de5092b1583cfeead53825df2686df154646ce5]

        tdf#127543 add saveacopy to File dropdown menu tabs
        
        Change-Id: I19dc3e298f3199823224dab9796faee67307b494
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120298
        Tested-by: Jenkins
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2021-08-13  Emircan Agac  <thesadson@gmail.com>  [5d99a63fec50acca62fc9365708fc18bdcfedd68]

        tdf#141908: CppUnittests: replace usage of sal_Int32 with colors
        
        Change-Id: I7df5ec2eac7339e27f03ce8756522756b2fc80da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120184
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-13  Mike Kaganski  <mike.kaganski@collabora.com>  [a6ade09983dd95d6ebbd1ecfda564f645629ce34]

        tdf#143852: Revert "Move ActionLockGuard up a bit"
        
        This reverts commit b791974837a99ead793b4ead6760b2f4e5237de2.
        
        Change-Id: I4bb95c915aa27b509ea2a41602ba2198c2f20cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120370
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [cdc94cad88ffcfb73a4468b7b4b2dad5438d5980]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 12f1ebf5f989b60ec2c2470e79fbeabf8247f483
          - sf_base review
            
            - typo in Python example
            
            Change-Id: I43c6125b20b0c5a4b94c3160e8157eb094bd7a78
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120434
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-08-13  Alain Romedenne  <alain.romedenne@libreoffice.org>  [6c4f63dece42cd3e93895e85741b8653ffad6f2f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f6422656f4d6d5432cf18fab6a104a75d369662f
          - Document sf_string Python support
            
            - Typo in FindRegex
            
            Change-Id: I7b2f98140585f7ff0ff04f9c4855deb299664592
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120432
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-08-13  Regina Henschel  <rb.henschel@t-online.de>  [61ef73bb9e06ac7325abc26698314d7e35c164cc]

        tdf#143432 and more, improve wrap contour export
        
        tdf#143432 The example document triggers the case, that there is no
        own, no from docx imported, and no from customShape generated wrap
        polygon. In that case WrapTextMode_LEFT and WrapTextMode_RIGHT were not
        evaluated and default bothSides was written. The patch moves
        evaluation of WrapTextMode up and out of individual cases, so that
        result can be used in all cases.
        
        tdf#142433 The previous solution has written the enhanced-path of a
        customShape literally as wrap polygon. But it might contain references
        to equation or modifier. The patch uses the polyPolygon, which you
        can get from the customShape.
        
        tdf#143760 The previous solution took a wrap polygon, which was
        imported from docx unconditionally. So it misses the case that the user
        has changed the wrap type. The patch reorders it so, that first the
        current wrap type is evaluated and then a wrap polygon is determined
        if the wrap type needs it.
        
        tdf#136386 The previous solution wrote for shapes not imported from
        docx a wrap polygon only in case of customShapes. So for other kind
        of shapes contour wrap was lost. The patch adds wrap polygons for
        other kind of shapes too. Default is a rectangular wrap polygon. That
        is used too, if a shape type would need an individual wrap polygon,
        but that is not yet implemented.
        
        The wrap polygon for Bezier curves is correct, but the curve itself
        is wrongly exported. That is bug tdf#142605.
        
        The previous solution misses to normalize the wrap polygon to range
        [0..21600; 0..21600.] In case there was no contour wrap in the
        imported docx and the user sets a contour wrap, the wrap polygon
        had wrong range, because the enhanced-path of an ooxml-foo shape
        is not in range [0..21600; 0..21600].
        
        Change-Id: Idc678fd385b705e66b7d5cb02a7dea5925f2ada1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120169
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-13  dante  <dante19031999@gmail.com>  [d3ff1aa10839be41a419d5a1004a50915182d163]

        Include the starmath version inside the configuration
        
        Change-Id: I4492fad6eb498e0c8c9a53b2096f538f2916d843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9753428dfc2bf038188c9a59af7fd2d789b46517]

        rtl::Static -> thread-safe static local
        
        Change-Id: If5b7181fb1bb3f3f21ec3742680e5a3e12b21b73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120431
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [53b8fcbd3f81903b171fd59478abf0283c6feb24]

        ofz: use system .a curl, fontconfig, freetype
        
        Change-Id: I2d0fcf28aa8d2fe937f850a2a54125073a6913d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120423
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [20bc07707949508f029da5e523fedda3cd64ccc8]

        tdf#143357 use a DateFormatter and a separate Calendar menubutton
        
        similar to what we ended up with in DateControl in
        svtools/source/brwbox/ebbcontrols.cxx
        
        Change-Id: I37c843ff7e1e8e39b318db80fe590ce5f796f46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119082
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Miklos Vajna  <vmiklos@collabora.com>  [282ddcf0bf0893f9a71eef2b1fea3db86b1c3292]

        extensions bibliography: sync the bibliography database window with sw/
        
        That one has the browse button and page number widgets removed for URL
        (keeping them only for local URL), do the same in extensions/ to be
        consistent.
        
        Change-Id: I519b2d82ddbb88d2b63f599094c23783c6d719cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120424
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-13  Noel Grandin  <noel@peralex.com>  [d29eb3d715a2bfd37c37e098d4f1c4600332487d]

        no need to lookup window if cursor has not moved (tdf#105575)
        
        use a single-item cache to avoid calling WindowFromPos
        
        Change-Id: I0d42c9572d28363949e38f3e052973727a44fb4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120419
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [a334112b44cb1ace8911c93323921510ccd0864e]

        Resolves: tdf#143795 trigger layout when content changes
        
        Change-Id: I9ec19b55f2b46ac8dd1415f45d5e0368fa52fbfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120421
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Paul Menzel  <pmenzel@molgen.mpg.de>  [33c96dcef9a729625d091d28db493318b7e21590]

        nss: fix build on ppc64le Linux
        
        Change-Id: Id67afe505e97a4e2ac8502d32d9cdda475234b64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120386
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [4b41880be6894aaa2d2392554e858631278ba320]

        ofz#37114 avoid config when fuzzing
        
        Change-Id: I0d0143453d99b6a27267835f7149b3bb1989080d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120415
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [2ab71cb4fdbaff8c3f891aa8522cdc5bb55a9512]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 71310fc95c2eed25eb8fa8c16953fe6e0c735b74
          - Related tdf#128590 Update Tools menu help page
            
            Change-Id: I63429e76a548d17aad160a59c91d24e876154ced
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/120365
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-08-13  Noel Grandin  <noel@peralex.com>  [fa01f5a1feeb93a88a330daeec8177a39916e6a3]

        tdf#105575 Slow rendering when using a Logo command
        
        Remove dynamic_cast'ing to Primitive2D, expensive and unnecessary
        
        <quikee[m]> noelgrandin: nobody is using XPrimtive that is not
        derived from BasePrimitive2D in an extension ... mainly as it is
        not even possible
        
        Change-Id: I68224021f0fbc35fe2a973198ba78d2b41ea172d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [e463cc0c8e2582e2cb57ab64a74a6a5cdd9b9787]

        less OUString construction on hot path (tdf#105575)
        
        Change-Id: Ieb13bf771b238ed022f1d6164f2e40f92f03af66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120418
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Caolán McNamara  <caolanm@redhat.com>  [ebe01a5f019c6da1aa0dcb46213055f9f8cfdb7b]

        tdf#139811 trigger layout when content changes
        
        in writer styles panel of page deck which is similar to the draw case
        of tdf#143795. Doing this always in PanelLayout::queue_resize might
        make the most sense rather than these manual triggers, but do it this
        way initially for a safe backport.
        
        Change-Id: I4bd2e9cb9d52b66a73cd0615406052e19e6e8b51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120422
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-13  Miklos Vajna  <vmiklos@collabora.com>  [59f3db1763e1ffb85e7b5d01b051a27a388281e2]

        sw bibiliography: limit browse button / page number widgets to the local URL
        
        The normal URL is typically a HTTP resource, so the browse button is not
        helpful there after all. And if the URL is copied in manually anyway,
        then the dedicated page number widgets are not that helpful, either. So
        remove all this, and only keep it for local URLs only.
        
        Change-Id: I25733810cf38981c50014e06201555d98fd9f77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120420
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-13  Noel Grandin  <noelgrandin@gmail.com>  [ef38b9af0abd4a38bb9025a38f21442ebe11238d]

        split SvNumberFormatter into it's own header
        
        so I can make changes without running into cyclic dependencies
        between header files
        
        Change-Id: I98a91c7cc66002ba745cdb8239e5cc267922a45c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  Michael Stahl  <michael.stahl@allotropia.de>  [27864eb5b085d4f7a881e24d1e4509f18c320849]

        xmlsec: add XSLT safety warning label
        
        Change-Id: I8d5ac40ec0c0b0a9fb3fb369578ff1f14b512254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120387
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-08-13  Emircan Agac  <thesadson@gmail.com>  [c7685f030fe39ff25c4ad30bc94e28ead7476934]

        tdf#114441:Convert use of sal_uLong to better integer types
        
        Change-Id: I14cfc4113e9aff0fcff3b2d3c2b0444aad8934ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120332
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-13  dante  <dante19031999@gmail.com>  [b8a4eeb24a037d338a61eb4b76acc9fad52fa5c3]

        Export Math ML from new mathml nodes
        
        Review tip: thanks for your help
        Code heavily based on: mathmlexport.cxx mathmlexport.hxx
        https://opengrok.libreoffice.org/xref/core/starmath/source/mathml/mathmlexport.cxx?r=e271fce8
        https://opengrok.libreoffice.org/xref/core/starmath/inc/mathml/mathmlexport.hxx?r=10d29c39
        
        Change-Id: I798d0e207b844240f4b25720ee37c394eb4c2e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120188
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-13  KaranAbrol  <karan.abrol1@gmail.com>  [c9bcbebe34c8d0e3edab520ace15c4d367aef62f]

        tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: I9a183ed9046ab0610a538c74e3ff8b327a6f6e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-13  Miklos Vajna  <vmiklos@collabora.com>  [5f080fc69c7c9748591db29e5e7be317bf48b427]

        sw: handle mbKernAsianPunctuation when replacing compat options
        
        This is a compat setting in Word documents as well.
        
        Change-Id: I69f80ffaff00564fd6e09c5ca7495fa718ba6528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120411
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-13  Miklos Vajna  <vmiklos@collabora.com>  [13f95baecb012b05f070c519410291f3c020a122]

        sw bibliography: fix missing identifier + local URL in biblio reference
        
        Regression from commit 5fd2f212a1db9e061fb3a886810b427251e8a6bf (sw
        bibliography, local copy: handle the bibliography database window,
        2021-07-27), the problem was that the newly added LOCAL_URL column
        affected BibliographyLoader::getPropertyValue(), which was not adapted,
        done now.
        
        Change-Id: Id3bd95bdd5c692048a50ce7ba2e5cdf16e824bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120400
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-13  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [adf65471e889676a600a9c6d0454c75cbd549ad3]

        indexing: allow for multiple entries in search indexing data
        
        Change-Id: Idb9bbbaa940b7cd48423c6cc65b9c7d0b94f57dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120396
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-13  panoskorovesis  <panoskorovesis@outlook.com>  [be710c72a6302829bf7f632c8ad6dc72be51fd95]

        Replace ReadGDIMetaFile with SvmReader::Read
        
        Use the new Read functionality
        
        Change-Id: Ied997377fda8793422b1c8877ece705e4a9b6dbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120376
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [18771471f75685a6d3838a22d16dcff5c398e652]

        tdf#143809: sc_subsequent_filters: Add unittest
        
        Change-Id: I5e2729edbf46128195c441459970c5946cd2ad17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120403
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [8383e25bf9e2b284f7dfb7ed234dec8d46c7a8cc]

        use --with-idlc-cpp=cpp instead of --with-system-ucpp
        
        for these special targets now where we want to avoid building ucpp
        
        Change-Id: I9ffa6f4148e8b5cafd7d34df4f2e18ec6f6c75c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120413
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0febae7a407364f1d565f4d1ce2ac1a55ca02876]

        disable gcc warnings when using boost::make_shared
        
        Change-Id: I02a54d9ab9c1faf36ce0b03b6ca42b3708f02667
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [b0c4ca9e088cbff5a5dbc5e95486397041a51d4a]

        make --with-idlc-cpp=cpp work for gcc cpp as a ucpp replacement
        
        e.g. the example of
        https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1524638
        has the same output .urd using cpp with these flags as ucpp created
        
        Change-Id: Iadfd2deba7d365c66c3260fd6736c031987e107c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120347
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [dd76c656017b11d30b48a2df6c20e4b42f35a23c]

        ofz: use system .a libs when they aren't c++ ones
        
        Change-Id: I12e44bf2dbeebc0d18e48a22831099c3dad7b12d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120402
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [6833e0c0af09637bb410dc800435dcc6c8333680]

        Resolves: tdf#132739 two style tags where there should be just one
        
        Change-Id: Id9c8c8cc8c5ffdd21ba79ff39a6279cf2ddc8025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120393
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [ea42621c6e8f4147827828c871046cf47ef76de8]

        Resolves: tdf#143843 disable the recently-used widget during load
        
        We show a busy-cursor but the widget can still be interacted with so
        another document can be launched by clicking on another recently-used
        item while the first one is still loading, and the recently-used widget
        isn't prepared for this scenario so the second to complete load will
        crash.
        
        Disable the recently-used widget when its cursor is set to busy, and in
        the (unlikely) case that the load doesn't complete normally (missing
        document or load filter error) and the recently-used widget still exists
        and its cursor is unset from busy then reenable it for user input at
        that point.
        
        Change-Id: I8f4487f3dbede14c9778e49442366bd9445f1d63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120399
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Zeynep Yavuz  <zeynepyavuz2001@hotmail.com>  [d55de29c165e34b8a9ccb7ebf79f76a601103977]

        tdf#88205: Adapt uses of css::uno::Sequence to use initialize_list ctor
        
        Change-Id: I3c01bb8abeee949bcd1aae861aeb1b1ac516ec58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120299
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [1aed4ae13d511de38bd9d350a75b917546617891]

        SfxModule optional fields might be empty, cannot unconditionally deref
        
        fallout from
            commit 9ce7ada4530074d95d05efdc89a7eba1032d99e0
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Wed Aug 11 20:47:36 2021 +0200
            flatten SfxInterface_Impl
        
        Change-Id: Ib57dd89903ec7f3c73a8466e33e47c4184962620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120397
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [bdec6b189510743bea74ad85b4abff09336a547c]

        cCSS1_style_opt_end is '\"' so these two lines are the same
        
        Change-Id: I20974698706a6b64fe6a60030364c7a8b91415a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120392
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Stephan Bergmann  <sbergman@redhat.com>  [3e8231ddce6193e40026364ec7ad5fcfab86846c]

        Remove unused, obsolete checknewapi tool
        
        ...that had been introduced with bbdd3fe352b320e7183ae18449e15ac517269b55
        "INTEGRATION: CWS jl31" ("2006/02/17 14:26:14 jsc 1.1.2.1: #i62141# new script
        to prepare some uno type statistics")
        
        Change-Id: I7d738311da73390d29ee1b25e90f58d007cf4cca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120395
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [df6a8b15a67baa6e2717a7de7755ac93fdb46723]

        tdf#95549 speed up xls open
        
        Remove the m_wThis field, and instead just check the ref count to know
        if we are being called from our own destructor.
        
        Also re-order ScCellRangesBase::Notify so we do the cheap checks first.
        
        This shaves 2% off the load time
        
        Change-Id: Ie95a4ff46bacba583ec4b3a934f98a9aac3551b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120385
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a72f2dcf73df9b9f4420cc93aa57a77c165a0fcb]

        tdf#129270: sw: do not copy list level on paragraph cut
        
        Current list level (RES_PARATR_LIST_LEVEL) is initialized
        before, but current value can overwrite it with invalid
        in given context. So we could have mismatch of outline
        style (which are not overwritten) and actual list level.
        
        Change-Id: Ibf34a6f35b922493c4a1477326ea6c1599b4938f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120212
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [38027099e773403ffd3314a5b54493adc65150ec]

        tdf#95549 speed up navigator tree load
        
        (*) inline the load loop
        
        (*) remove Refresh call from ScNavigatorDlg constructor, the SetListMode
        call at the bottom will trigger a load of the tree content
        
        Change-Id: I27f1d1bde89d8dcb5cc111ae132fbb05abc2fc7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2a1c29d5958e0cc6d8f0e68c11121131dfa1513]

        tdf#95549 speed up load of xls
        
        we don't need to perform layout during load, so disable a few places
        that do that
        
        reduces load time by 50%
        
        Change-Id: Ie746ca0b46de3b76ca1b7291e0528b525333278f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120384
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6c287cbd8cc81ccdff3a70e09022eb21af063e5]

        s/mpEdtOutl/mpEditingOutliner/g
        
        Change-Id: I5eb188cc1808055857f95c73ab838251cd93e4b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  homeboy445  <akshitsan13@gmail.com>  [260ebddf284b34336d6ab82b1726d01b2bacd66c]

        backendtest: Closed Bezier loop test using various drawing methods
        
        Change-Id: Ib2ddc8475e2476ce377f3541caa0d48e7c57241a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118783
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [25b4e39309814325224193f3192e6e2d83e5f141]

        include optional header for std::optional
        
        Change-Id: I5e2c42498691d1fccf5122720e56bf44462ce21d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120382
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [a5642b8b9690f835cbd07ce3278e425b7aa7b9ff]

        ofz: liberation-fonts-ttf alone is sufficient
        
        Change-Id: Ifa6938c759c0c1036120da2eeadefbe00ae96f0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120381
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [422150be82ed892ecf31a8ab76c1d1ca801dcda8]

        Capsulate TableBox<>TableBoxFormat relation in a function
        
        Change-Id: I731e9bae04147f7453721661228e78a16ed585db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120160
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-08-12  Emircan Agac  <thesadson@gmail.com>  [56ace1c8728ffc9f34901497fa907818412046ea]

        tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctor
        
        Change-Id: Ifce4c42df52ce03ed1c509d9fc28de79f5b3426c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120199
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [a129b138043ee167f1043725f5d918bb8535a292]

        Add Handler for TextLineColor Write
        
        The handler separates MetaTextLineColorAction::Write from metaact.hxx
        Remove default case as it's not needed anymore.
        Write implementation is now in SvmWriter.hxx'
        
        Change-Id: If0c23649d9fef49e07c558c8f7fddb028d5da9ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120372
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [7ce78320b7bcf60ec2a2d661f3d91ab5ee89622e]

        Add Handler for TextFillColor Write
        
        The handler separates MetaTextFillColorAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I9f67def86f0c189bed880f790760c18098611c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120351
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [e1806bc9bb1704f9ee969271417a0cae98285fcd]

        Add Handler for TextColor Write
        
        The handler separates MetaTextColorAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I58f7102edeae6f9a712a79ed5de8ce9b3e27510a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120350
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [54edce8503deeef41e712cf75ef975884389105e]

        Add Handler for FillColor Write
        
        The handler separates MetaFillColorAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I324b1a41f1be122367a69b8ac601bd12ca8401fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120349
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  László Németh  <nemeth@numbertext.org>  [afc0c718ec9ca6a4fbe1324f68eb292d9a67b058]

        tdf#143318 DOCX import: fix missing redlines in flying tables
        
        makeRedline() exceptions (in the case of already existing
        redlines) skip the creation of the next (not existing yet)
        redlines in tables inside fly frames. Here: a tracked table
        moving revealed the problem, with the missing rejection of the
        new position, i.e. the "new" (second) table of the document.
        
        Note: fix also collecting redlines within tables: IsInTable()
        isn't true in the first cell of the table, losing the
        redline here, so it's replaced with m_nTableDepth > 0.
        
        Follow-up to commit 7f3c0bbc174b9b0316991c174ca3b407c0e3d141
        "tdf#143510 DOCX import: fix tracked table drag & drop".
        
        Change-Id: Icf6dd62eb950e5af6a75353dffabb9e9433c1b44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120333
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-12  Tibor Nagy  <nagy.tibor2@nisz.hu>  [569cb54f1d82e993dcf1fd11d92d4cbd4f224a2d]

        tdf#143129 PPTX: custom slide show use as default is not exported.
        
        Follow-up to commit 11ef976624dce8a8e50a1eb20e9c586519fd7ec8
        "tdf#142590 PPTX import: fix custom slide show use as default"
        
        Change-Id: Ie8a53a79bd531cfe2c3b3559b70d28770ca8b960
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119564
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-12  Caolán McNamara  <caolanm@redhat.com>  [a8699f7cce501ddff999c3596e337e173a567ee7]

        add some --disable-scripting fixes
        
        Change-Id: I94523d4323544fe6c475f0c5cf4113e6d783939e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120374
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-12  Emircan Agac  <thesadson@gmail.com>  [ee0cf03dc4a551b1cd03ee438b83fd7eea628fc5]

        tdf#114441:Convert use of sal_uLong to better integer types
        
        Change-Id: I0642261314f9b04fb38b68afd44d879c1e83c830
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120300
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [9ce7ada4530074d95d05efdc89a7eba1032d99e0]

        flatten SfxInterface_Impl
        
        Change-Id: Ic66ed6d9738ee6fbbc2dc0b5a572e1ea57092b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [4cd64dcd4857eafbe3146df287b517d8e5e455c0]

        flatten SfxFoundCacheArr_Impl
        
        Change-Id: Ie2b29b041bb0f678494126b21df651371a40dbda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120344
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [498d2b82187ec3ff58f076e0d15741e64c0505ba]

        tdf#131546 DOCX import: fix performance regression at tables
        
        Commit 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 "tdf#90069 DOCX:
        fix character style of new table rows" caused ~20% slowing down
        in loading time of documents with huge tables, related to the
        extra processing of the redundant w:rPr of table paragraph runs.
        (In DOCX tables, MSO exports the run properties into the run and
        paragraph sections too, probably because of compatibility or
        usability reasons.)
        
        Theoretically in this case, the run properties which are under the
        run section win. On the other hand, because LO copies the props
        which are applied on paragraph level, and only them, when copying
        a row (e.g. upon inserting a new one), it was needed to apply the
        mentioned run props not only as direct character formatting, but
        as a direct paragraph formatting too. This way, the support of
        copying of rows are solved. Unfortunately, this "double" applying
        was done for every single paragraph, which quite slowed down the
        opening time. This patch gives a workaround, which completely removes
        this double applying functionality in the writerfilter by reverting
        commit 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 (except its unit test),
        and copy the mentioned run properties into paragraph level, when its
        needed: upon inserting a new row before/after. This way we spare a lot
        of cycles, as most of the original applies had no real use whatsoever.
        
        Change-Id: Ic24d0d1830e9ec43323e5e213d6481ec28e9abe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118985
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-12  Dennis Francis  <dennis.francis@collabora.com>  [9d23cc663a1f14c960ebe05059cb520cb41dc01c]

        lok: sw: avoid duplicate LOK_CALLBACK_TABLE_SELECTED msgs
        
        Alternate approach is to track changes in the active table in each view
        but it needs a bigger change and run the risk of overlooking cases
        where table dimensions and position changes, which is possibly why this
        message is created from UpdateCursor() in the first place.
        
        Change-Id: I06643e2a7416d6c0fe2b0dc5c9b4adcd45fa50c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118001
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        (cherry picked from commit 34ade20a09a1c3fe08daec2b276a06a1f895bd5a)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120354
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-08-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [d89a9d72cbbcf6bd7e1c5a4f3f00db5122e36707]

        Fix typo
        
        Change-Id: I22b6912d2d26c26447fbddefcf15fc6dea8e8717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120228
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-08-12  Miklos Vajna  <vmiklos@collabora.com>  [2fca9476ab3b3e38fb285dcd3b927223e8008b3f]

        sw: remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: I4931ac951e4051fb02e44868a9743bf6bb73d645
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120336
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [c6a0fff5e8ef321767abd2012324e90b31660fdf]

        tdf#126961 link to macOS address book - crashes and restarts
        
        completely untested, but highly plausible
        
        Change-Id: I107978aa6bf8b77cee06ffc5be6bff8b651b11f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120287
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [aa063443de8a4ef18ccb5ebc939183fae2b58688]

        flatten SfxModule a little
        
        Change-Id: I6620e9d6d6d4b0a1b39f6d98acb0e72621f853a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120343
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [49f7d5cba44a14f168f26a9f1ade12618ff32d77]

        flatten FastSaxParserImpl a little
        
        The EventList instances are movable (and are really just pointers
        to buffers of data), so no need to use unique_ptr
        
        Change-Id: Ic3e13e949f5a61ee9cc5fcf8da9e22094e8ab9da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120342
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [7bdb3a77d06664a500c2ed2f3464cd56647ce089]

        flatten OZipFileAccess a little
        
        Change-Id: Ib03dadcd69a65493ddd9c0437fc654beef039ad8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120341
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [b4376538d9d3dcae062d05765150a40a62be3e29]

        flatten ZipPackage a little
        
        Change-Id: I0295bd8d72686996afb9d361db12b6014594b402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120340
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Noel Grandin  <noelgrandin@gmail.com>  [f9871d218bcae184a5845d63366175ea2df2086a]

        flatten LngSvcMgr
        
        Change-Id: I757cf9512fc3b87dd826eb39c2bbe456dc14d097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120339
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-12  Mike Kaganski  <mike.kaganski@collabora.com>  [5351e837a11fb9d19759cd1b91ca4b5d43e2f75a]

        Unify and simplify tools::Rectangle methods returning Point
        
        Make the methods use Left()/Top()/Right()/Bottom(), allowing to
        avoid explicit checks for emptiness.
        
        Also do not use std::min/max in *Center(), so that e.g. TopCenter
        returns top value the same way as TopLeft and TopRight do.
        
        Change-Id: Ie1edd7a0ab7e32b4f98d0c2fb3917ce2902bdf7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120353
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [7ddf7375fb5a8c6699d4128a80b9f24ec6b914ae]

        Add Handler for LineColor Write
        
        The handler separates MetaLineColorAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Id308ce7c1b2efc7c58caf8e492eed242ccfb5c66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120313
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [9c0b114d1487868f4af189838c3136ce0cc6b751]

        Add Handler for MoveClipRegion Write
        
        The handler separates MetaMoveClipRegionAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ida80faec0c2389b267d77d5d12e4bde5ece24de8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120312
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [d7fc4cfb90d688ff2b5a774f60f87d8d120ddb1e]

        Add Handler for ISectRegionClipRegion Write
        
        The handler separates MetaISectRegionClipRegionAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I734e574c9a292fd44f36c155ba976908512ee588
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120309
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [526646cb631bf56fc0fae25499a867399db81b02]

        Add Handler for ISectRectClipRegion Write
        
        The handler separates MetaISectRectClipRegionAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I999fa1baa4e3c34f3f83dc1d3973f961857f89d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120308
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [b0d1f39266ec0a3bef63e66c8d97ba1d6652734b]

        Add Handler for ClipRegion Write
        
        The handler separates MetaClipRegionAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: If3f4682dbdef6a2a0bd11a51c4a4eb3a6ab8b0d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120307
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  panoskorovesis  <panoskorovesis@outlook.com>  [f6032e23bbedebcbf32eeb56627d89489b52f024]

        Add Handler for Wallpaper Write
        
        The handler separates MetaWallpaperAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Icfbb4ab5cf3d7ea803cb55405e82dc262f3958c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120306
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [3c0c1b79b689775f09b3bff75bb01118b380f41f]

        tdf#76310: subsequent_filters: Add unittest
        
        Change-Id: If39bb4e3c7e767f273351cb381ea055e3934de2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120338
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-11  Eike Rathke  <erack@redhat.com>  [b37fd7f38165dadc5b1a674b73f4b18824e4789e]

        Resolves: tdf#143809 "INF" may be a named expression or DB area name
        
        ... to not be caught by rtl::math::stringToDouble() handling
        XMLSchema-2 "INF" and "NaN" and set as error.
        
        Change-Id: I9bf7aad416a69d4c3c0d49d6c80168097040a3e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120337
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [2316e21b2c6f3d1f18613408a8deb41af17c03bb]

        tdf#44278: sw_ooxmlexport16: Add unittest
        
        Change-Id: I31de23db13083ce98e75d3ec1d65d970161b3b92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120335
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [59c9274ec408ec074d4b4b9e4645b0787312a370]

        gtk4: add a separator between toggle and menu buttons
        
        Change-Id: I00e9245801529ce817781e65fb75fa59cd3d7f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120331
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Michael Stahl  <michael.stahl@allotropia.de>  [4db18506b43a63af36767d609a762f8d2e3b7634]

        xmloff: work around LD_LIBRARY_PATH breaking odfvalidator
        
        Validator calls ResourceBundle.getBundle("com.sun.msv.reader.Messages")
        which can't find the com/sun/msv/reader/Messages.properties in its jar.
        
        bootstrapfixture.cxx:241:Assertion
        Test name: testBibliographyLocalUrl::TestBody
        forced failure
        - /lo/master/schema/libreoffice/OpenDocument-v1.3+libreoffice-manifest-schema.rng[-1,-1]:  Error: Can't find bundle for base name com.sun.msv.reader.Messages, locale en_US
        
        This is triggered by gb_CppunitTest_CPPTESTPRECOMMAND.
        
        No idea how this happens, or why it started to happen sometime during
        the last ~4 weeks, but propagating the same workaround of commit
        e854abe076155fc085b56549ced50b3ee9a095d2 to more tests seems to fix it.
        
        Change-Id: Iaef2b41f81c4a659e66cfb7a40f7b1a4517552c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120322
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [ad1ba0f58ee5cb7db3a856d49f73e3b543a497aa]

        gtk4: fill menu MenuToggleButton menu
        
        Change-Id: I512846cda2c8f06838a499043a4cd08314fd7b97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120329
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [2ece952c4ae1c65975a4e80645719ad14daa95da]

        gtk4: get startcenter MenuToggleButton menu appearing
        
        though still without contents
        
        Change-Id: Ieb7048a74f33fe65ededd1ff8730b2d061ae325f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Karan Abrol  <karan.abrol1@gmail.com>  [7b21c25354d16b9d9e04f36c1370b9a2edfe09fc]

        tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktop
        
        Change-Id: Ia1b63a38b6522ecf52cc2e923e93d6bf0a41ea86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120319
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [3ad8347f25935d60e55ff12fd1844001a50bedc4]

        add some --disable-scripting fixes
        
        Change-Id: I28c4d38a035201acc2b0e5acc5908c4e74ae80e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [54c2de7e77dad1a1151c074f2ec5bfe1527d4d12]

        gtk4: get startcenter MenuToggleButton working
        
        the button parts, not the menu part yet
        
        Change-Id: I016d2c2160a4e8c0c4d1e096f49d0e518b89a55b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [ebf494123720806a99e12001bdee9cae4a86c44f]

        gtk: use explicit GtkBox instead of generic GtkContainer
        
        cause gtk4 doesn't have GtkContainer anymore
        
        Change-Id: I32893716654ba308277ee34ecd8c3c944a9bc575
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Zeynep Yavuz  <zeynepyavuz2001@hotmail.com>  [b0a75847738060266ed1b0d5c046132b97e4e158]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I483d494a11b951fd415a314fddd4823db11dcb44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120295
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [749a14a7cee3ef6353b99d25422f996518c2284c]

        sw: fixed regression from [1] - OLE height in mm instead 100th mm
        
        OLE height is 3cm, but converted to 30 (mm) where the Size is
        expected to be in 100th mm. This uses the correct value of 3000,
        which correcponds to 30mm and the expected 3cm.
        
        [1] 0d356f93e4d5ca073a6e866168f76103c60c6a45
        
        Change-Id: I77cab1641b948a8839da543c12835c5c64825a5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120316
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [bfed58821fc3a83fec4a985087cd45fa963bed3e]

        Drop convertMm100ToTwip in favor of the new o3tl::toTwips
        
        Step by step, duplicates from <tools/UnitConversion.hxx> may go
        
        Change-Id: Id4c03ff8adc120ae06dbfdbdfb4f5ff0bb51f489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120315
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-11  László Németh  <nemeth@numbertext.org>  [c46950fee11f5207fb8324947280cd565ae483e7]

        tdf#143583 DOCX import: fix lost empty paragraphs of footnotes
        
        Last empty paragraphs of footnotes were removed (except
        in the case of the first footnote), related to the double
        call of RemoveLastParagraph() during footnote load and
        later during its copying.
        
        Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357
        "tdf#76260 DOCX import: fix slow footnote import".
        
        Change-Id: I61d9aa6765f3af1893451684dde12c199251d06b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120270
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-11  Noel Grandin  <noelgrandin@gmail.com>  [d39d87bbffe8e731bad92f2fe90526c3610689f5]

        no need to allocate KeyedValues separately
        
        Change-Id: If28471436d224e88dfee07f3b8465648867197fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [56ba9c544d2e5dce9022a245a6835d79bbf0f31d]

        gtk4: use monitor size for workarea
        
        which is better than nothing now that gdk_monitor_get_workarea is gone
        
        Change-Id: I8e691f733ec05d981a621f17efa5c968fd078193
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  Noel Grandin  <noelgrandin@gmail.com>  [5ef182586ae2019fa6f6a59dae1b41b2225665bf]

        no need to allocate the lookupTableItem separately
        
        Change-Id: I43919a002df01c6329ee483bf69f04669cdce1f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120293
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-11  Noel Grandin  <noelgrandin@gmail.com>  [da40449dc5f1841ac3e6f6aa1194834a363455b6]

        no need to allocate changedValue_ separately
        
        Change-Id: Ibda7c7a055790f6eb87ac6bd62554e745181cea7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120292
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-11  Caolán McNamara  <caolanm@redhat.com>  [0c4cdfa9c9ba9548a61c7314858eae01f90f2782]

        tdf#143769 don't crash on null XFillColorItem
        
        use same solution as:
        
        commit 5ee0e6ab93ad791f5e79506efafd16cb7364ffb1
        Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Date:   Tue Jul 21 19:01:26 2015 +0200
        
            avoid crash with color listbox for now
        
            Change-Id: I36ac6513546961ec8d8d1e9437a8ef88574acbf4
        
        Change-Id: I46c55461e5867431a6e9c838b5ef462f9581eb28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120297
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-11  homeboy445  <akshitsan13@gmail.com>  [fc8c97f55c509a75ee18de3d9d5e793e37bb0c36]

        backendtest:Irregular HalfEllipse test via various drawing methods
        
        Change-Id: If1a6f224f6ff4118617128630077a81da4c469a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118656
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2021-08-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [67329f8b75101a78a00bf646bb2c3b9f4575aa5a]

        tdf#135247: sw_uiwriter3: Add unittest
        
        Change-Id: I4f78b42600c0b7316aee9e6c106a25cc8cff983a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120285
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [b50ea6333e31757ab7fb365299351d6aabe4c101]

        Add Handler for Hatch Write
        
        The handler separates MetaHatchAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I29587d4a9e9129c5425792e2f8873ee7414bdaa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120264
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [79522b8e63c6435331f3cbf623c25f0849d7fd43]

        Add Handler for GradientEx Write
        
        The handler separates MetaGradientExAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I984e21b7d4b19b16432cabe9709d41f07187f268
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120263
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [33243f20831f6efac14047f38d3e7d987aa632e0]

        Add Handler for Gradient Write
        
        The handler separates MetaGradientAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I31ae5f5331f780e095caaf200ea289332233fb52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120259
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [1f875634f8edaf40dcf083024f03e6a623e48599]

        Add Handler for MaskScalePart Write
        
        The handler separates MetaMaskScalePartAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I3c881495c013e6827c91027319a9cedcea7f96c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120258
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [dc23042b6adb62eb5b0963be04aa121d0cd66ff5]

        Add Handler for MaskScale Write
        
        The handler separates MetaMaskScaleAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I1fee84e7c79da96755d20611a36b58f92349585f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120257
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  panoskorovesis  <panoskorovesis@outlook.com>  [86433ad00e5ac0133e0657f335b08931784b7f34]

        Add Handler for Mask Write
        
        The handler separates MetaMaskAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I8c204d767e8474fbf67fc5b8f610f4b8e5244903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120256
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4cb9b2b3e9bd61ab630aa16d9e382a3b90deb77d]

        svx: cleanup formatting of svdglue.hxx
        
        Change-Id: I4aa4d25a5097813feeb7d6ebb654b9b0ce0c1c14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120302
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0d356f93e4d5ca073a6e866168f76103c60c6a45]

        sw: preserve the value in original units to minimize conv. error
        
        Not really an big issue but let's preserve the values in original
        units as long as we can without conversion so that the error is
        minimal.
        
        Change-Id: I96981eaecac74b591803dbc93e487c1d106ab23c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119490
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  Noel Grandin  <noelgrandin@gmail.com>  [5433564debb280949afcaa92dc3f9faf59765e65]

        no need to allocate AllSettings separately in ImplSVAppData
        
        Change-Id: I16b21d2bec8de9e5f4e8402c838c99d73637fe99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-11  Miklos Vajna  <vmiklos@collabora.com>  [7b57a96673e9a78a65f2e442a8b04fa393871c39]

        CppunitTest_sw_ooxmlexport2..5: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I7b48ff2427b8c544db07323a98a236cfd8904df8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120284
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-11  Mike Kaganski  <mike.kaganski@collabora.com>  [84bf981a4fdf94cae40dd199762dc03d681618fe]

        Deduplicate number read/write
        
        Change-Id: I58808e208ac8b3406497a4e512ec3372434d2ed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120246
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-11  Jim Raykowski  <raykowj@gmail.com>  [0ff5eb97b89f89e770d4397bf76f24fb7cd76b57]

        tdf#143577 check node is a text node before use as such
        
        Change-Id: I337c94aa90ed906c5b744171728022ba5f9c64b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120191
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-08-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fa339b3adb53300ae68913bed87e18caf9f2e262]

        convert some LogicToLogic calls to use o3tl::convert instead
        
        If a LogicToLogic uses fixed units, we can use o3tl::convert
        instead. We can also do the same for all other cases where
        LogicToLogic is used, but that needs additional investigation to
        determine if it is safe to do so.
        
        Note:
        MapUnit::Pixel is converted to o3tl::Length::pt because it assumed
        72 PPI for a logical pixel, which corresponds with the conversion
        rate of a point (72 PPI).
        Today, 96 PPI is standard, which is also used for o3tl::Length:px.
        
        Change-Id: I29126df38bfcfda74b5d83d4cb880a378aecd18b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120230
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-11  Eike Rathke  <erack@redhat.com>  [e89404f00b25cfddd4098b4b2cf900d190617221]

        There is no LANGUAGE_ENGLISH {en} locale but LANGUAGE_ENGLISH_US {en-US}
        
        The known fallback locale is en-US so this worked by chance..
        
        Change-Id: I81ee2aff0cc35b4c8d501dfb6846f0709f1417ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120301
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [736ef4ab060255b223324b73259af88b9c30f537]

        No need in this function
        
        Change-Id: I391183753e4fad800b7c69aef2e76a3780ce52a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120244
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [73fc697d5aac06938cc78f51b4e0d6f3d615447c]

        tdf#136610 Add Clone/Clear Direct Format buttons to LO Draw tabbed interface
        
        Currently LO Draw only shows the "Clone" and "Clear Direct Format" buttons in the tabbed interface when a text object is selected (in the Text tab).
        
        With this patch, LO Draw will now show these buttons in the "Draw" tab when shapes are selected, as well as in the Home tab (as it is shown in Impress).
        
        Change-Id: I9acf577cc5322d43c18acc366788a5eadda67ff6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119183
        Tested-by: Jenkins
        Tested-by: Andreas Kainz <kainz.a@gmail.com>
        Reviewed-by: Andreas Kainz <kainz.a@gmail.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [c54da86b850e079b4d6f0249fe7c5956ed5c400a]

        add some --disable-scripting fixes
        
        Change-Id: I45f08bce8e067ead82f4c73c8150b7027c083172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120288
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Yildiray  <yildiray_uskudar@hotmail.com>  [ab0bb71280999ef7c11c341f5269ea98019fe4c3]

        tdf#143148 Use pragma once in sdext
        
        Change-Id: I0ba29599509b875494f4021948192d2d447b9e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120277
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-10  Miklos Vajna  <vmiklos@collabora.com>  [15a524a1ed2bf464b0b727e628bb5af9685f49b9]

        embeddedobj: implement XServiceInfo in the various embedded obj implementations
        
        This gives UNO clients a reliable way to detect e.g.
        OSpecialEmbeddedObject, where it's expected that double-clicking on the
        object doesn't do anything.
        
        Change-Id: I595453490b157b64214cd7359da1e3a3c959191d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120274
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [7bae79e234b12c56ecb11e10cb6318be873be846]

        Use boost::make_shared
        
        Change-Id: I2c842d6198d79dcc3f5c85ab65c8f57357aa2a79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120289
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [eb8ce706d41fcf23333af3b0eec5cee2a12075f0]

        Clean up remaining uses of boost::logic::tribool
        
        obFitShapeToText and obRelFlipV can just as well be modelled with
        std::optional<bool>, and obFlipH and obFlipV apparently only need two states
        anyway (as for a boost::logic::tribool x, bool(x == true) is true iff x has the
        value true)
        
        Change-Id: Ic35e33ffa4ee30d1c2cdf9f8d4aa3bae29ece2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120281
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Emircan Agac  <thesadson@gmail.com>  [1788dbb32fd212a716ffca4facfc421c59f9ef5a]

        tdf#143148:Use pragma once in store
        
        Change-Id: Ia12dd3d7b69a8fdfbdfa6503e1ce2ee46c9446d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120075
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [e510b3089024e451b57d6150f6f1a5a34594e376]

        Use nStringSize instead of nStringOff
        
        nStringSize is the actual size of the string block, and is the correct
        end position to use to calculate last string length. nStringOff is not
        updated during load, so using it makes no sense here.
        
        It was this way ever since 039dbbcb9688971a85b1791f60a55693ff3ba261.
        
        Change-Id: I4fad1bdd6ed4af9dd7d29b5438ec23db0b815806
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120243
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [958a39425faa7c5ec3c422ac0de9fac7f79cad8e]

        gtk4: remove training wheels
        
        Change-Id: Ib52a4cc56fafc23ced1ce4f27d2c69977471d1d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118491
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [ad09c49b34f78770fa2510381dbc8b555baf05a1]

        use o3tl::hash_combine
        
        Change-Id: I0d6cd4313652669939cdbdc8e4ae7c62dae3022b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120280
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [83000b23e3e5817e0d3b44caf775edc3c5c97082]

        boost::make_tuple->std::make_tuple
        
        Change-Id: I3c4fb707aace43c1ea75a313fcdef6df17e007c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120279
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [626cf243134961511b71351d65e4161d7c25c45e]

        drop final boost::noncopyable use
        
        we replaced all the others, so replace this one too
        
        Change-Id: If744a834e754126921e392d32af44797bd5d634d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120278
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [e229547eb02ab6c9a1fe6abdfc42ce970cedc733]

        Simplify init-/deInitSysTray even further
        
        7e8d46b8988527967825fbb7210747e625ba1975 "INTEGRATION: CWS gtkquickstart" had
        originally introduced the [m_]p_[De]InitSystray function pointers, for dynamic
        loading of libqstart_gtklo.so on UNX.  But
        3e9c908b73f0fe0978c9980750a06bbc9e02295e "remove Linux ('UNX') systray
        'Quickstarter'" removed that again, leaving behind the no longer necessary
        function pointer machinery.  And 0a666480276f704d5127f578333659893517abe7
        "Replace a use of boost::logic::tribool with std::call_once" tried to clean up
        that unnecessary machinery a bit, but failed to grasp the bigger picture.
        
        Change-Id: I370a6b212b1f25ea1e3ef5a250be72bfe509dd5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120282
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Ankur Khandelwal  <khandelwalankur176@gmail.com>  [19b3b3b8a516fd7e76fba72ced43be539d01209a]

        tdf#143148 Replaced #include guards with #pragma once.
        
        Replace include guards with #pragma once in header file.
        
        Change-Id: I078f97ef5f7ab44ee915c78ab5f4569bde9f6640
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120208
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [6f151d719ad0b4f0ee6e7a460f6b4af212df3bb2]

        use rtl::math::expm1 instead of boost::math::expm1
        
        similar to:
        
        commit 1a1dbff33db8a6f2f55a5d92483a03670a610f6a
        Date:   Mon Feb 13 18:22:28 2017 +0100
        
            get rid of boost::math::log1p() and use rtl::math::log1p()
        
            ... which in turn uses the compiler's std::log1p()
        
        Change-Id: I1a09b790345f4da37d86ab7deba09fa20c5f648b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120276
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [6b8df9d79f89242a503b93b3c9e9f279eeda2105]

        pAvailGrammarSvcs can never be null here
        
        Change-Id: Ib4de13bb513235d8f865f00a10920d11ca9c5763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120272
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [c23730471c487b8f01eddfa3845b49316c0db94d]

        can return OInterfaceIteratorHelper2 by value here
        
        Change-Id: I32e94473667a734e582dad0a9785c8e9cfbc8cff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [45aaabbdfb7968d222d88b1b56788c0bd4c5b27d]

        flatten ImplImageTree a little
        
        Change-Id: Ibf67c85f4af80e5420b017a1a1f89e3eac8a3118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120219
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [0a666480276f704d5127f578333659893517abe7]

        Replace a use of boost::logic::tribool with std::call_once
        
        Change-Id: Ifff3fc422719c55d8cb560e679f2585036350aa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120268
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Noel Grandin  <noel@peralex.com>  [4d50939a7b37cbaeceeddebabfc435190e079781]

        tdf#136991 Open RTF with colored text
        
        We spend most of the time in MergePortions, and the resorting is
        a significant part of that, so only resort if we actually have to.
        
        This shaves 10% off the load time for this document.
        
        Change-Id: I2380c5aa744f6d9c82195bb2a17ced2ce7616e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120269
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [eeda1b35a6e87d5349545464da33d997c52f15e3]

        Revert "tdf#58521 DOCX import: enable ContinuousEndnotes compat flag"
        
        This reverts commit f9982c24066d6dd2f938cc20176af0f196bc018f.
        
        Reason for revert: tdf#143456 shows there are layout problems with this compatibility option
        
        This was reverted in libreoffice-7-2 branch only. See 43d2b3bbacdd6bbe24149ed33c54a180d74c77e4.
        Instead, this should have been reverted in master first, and the
        cherry-pick the revert to libreoffice-7-2
        
        Change-Id: I3a29b77289ef1445fdf4886b32861f6d8e79de21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120150
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [53e09765fe19be5f53852e793219d0af687d9795]

        Revert "tdf#58521 Enable ContinuousEndnotes compat option for RTF too"
        
        This reverts commit 892488b64f09190896d5a14e3f555ca91b3449e3.
        
        Reason for revert: tdf#143456 shows there are layout problems with this compatibility option
        
        This was reverted in libreoffice-7-2 branch only. See 43d2b3bbacdd6bbe24149ed33c54a180d74c77e4.
        Instead, this should have been reverted in master first, and the
        cherry-picked the revert to libreoffice-7-2
        
        Change-Id: I3c06001f3f3faeaa4a05a7c9ebd2e175e88ededa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120232
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [447cec188191e77c09ffc51cc42549def277255b]

        no need to use unique_ptr for SvxRTFStyleType here
        
        Change-Id: I2af75b594096c54403af34d20303fbf3ff79a5f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [f989bd22cc3c80d3c5119e3de1a269ab9a80bd78]

        Catch exceptions when setting up linguistic extensions
        
        ...not only from the createInstance calls, but also from later calls like
        XSpellChecker::getLocales.  At least when installing
        <https://www.puimula.org/htp/ooo/voikko-win/5.0.2.20170827/voikko.oxt> (which
        only contains native code for macOS and Windows) on Linux, that getLocales call
        would cause a RuntimeException, but which was effectively left uncaught and thus
        caused a crash.
        
        Change-Id: Id06760cb91b9aef2f3bbfe94213e40146214903d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120260
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [7a3eaef6dd707781c2f4e341aebb9d4c42df780f]

        for DISABLE_DYNLOADING support linking to static .a system libs
        
        Change-Id: I0b7e07c93f7314506c5b99847b53c09f4fc6d31c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [afbade63e0cfbd4f39a3558f31049328c06ea82e]

        flatten Accelerator a little
        
        Change-Id: I188a9ce69a89958f776f696f1da2f96b82a7f6da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [41bca9976de53c9e013438118381a646530c5365]

        flatten ImpGraphic a little
        
        Change-Id: If7d7462571cbee1c54965678fab790959c6e3f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [555366667c9a62f366230843c1727b0643a06b1a]

        update credits
        
        Change-Id: Iad0175ccc7a1ee903812f34bcacb86e3f90e58b3

2021-08-10  Mert Tumer  <mert.tumer@collabora.com>  [81055959e06848c917c4df1e4f19e1e5c6e70684]

        lok: Avoid redundant call to UpdateConfigurations
        
        We call doc_setView each time we send an event to LOK such as keystroke
        and SidebarController::notifyContextChange event is triggered after that
        UpdateConfigurations() call causes layout reallocating for whole sidebar
        and we end up keep doing it. It takes significant amount of cpu time for
        lok case for no reason.
        
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Change-Id: I8f456156af841fdeaba1934498863a07a7d4554e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120112
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        (cherry picked from commit b606764ce2a042f2a38c98820d7236661149d20c)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120138
        Tested-by: Jenkins

2021-08-10  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [3bcfb1aac1f43f16c579486264103ebd4f3f829b]

        tdf#143707 - Change strategy to support suffix type characters
        
        In order to support the correct data type of numeric constants,
        booleans, and default values for strings, the strategy to transport the
        data type character to the runtime has been changed.
        
        The type character will be added after the literal and the string
        termination symbol in order to keep compatibility. This allows to
        retrieve the correct type in StepLOADNC and in StepPARAM.
        
        Any legacy written images are still possible to process, since if there
        is a suffix type character where the data type character was directly
        written after the numeric constant, it will be processed in StepLOADNC.
        
        Without this fix, an optional parameter of type Variant, would still
        include the suffixe type character, and will not be converted to the
        correct type in StepPARAM.
        
        Change-Id: I86c8192c6dc28457053fa7b23a073420e45407b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119945
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [d5c8684c05e33e87033d595c98fb50acd42d56a8]

        flatten PropertySetInfo a little
        
        Change-Id: I46bc0dc2da9b52d5a2cb1e415328ab1f13a96ff3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120216
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [51d8845959c75f8c8a3795e7601f947841d0fa60]

        Update git submodules
        
        * Update translations from branch 'master'
          to 2ec580d39ac7950b584fde730d22fa4f09dd8399
          - update translations for 7.2.0 rc3 / master
            
            and force-fix errors using pocheck
            
            Change-Id: Ifd8f486c7c40d1b9f5e78313bc94496f86698681
            
2021-08-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [95d619f92b32a576b0e0417508b66147b7f05afd]

        tdf#143759: sc: Add UItest
        
        Change-Id: Ifb64e4930e17d10d44867317075878db5427f1ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120255
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-10  Mike Kaganski  <mike.kaganski@collabora.com>  [3f40147a1cf1a76d69a491989f2ef87b150ec7fa]

        Delete copy ctors/assignments for DLLEXPORT class
        
        Same as ee405fb2ef36337851801f1bd34411c606d55988 for
        GraphicHelper, but this time for OpenGLContext.
        
        Change-Id: I8822f7bffa543ca7b9d0ef541acd0cbdc2b3c46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120239
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-10  Caolán McNamara  <caolanm@redhat.com>  [f74ad471eee76ecb30f6ec41141c35242426e3be]

        oss-fuzz: can use system ucpp
        
        Change-Id: Ie78fa4442ec2d9b33e85d378f2df16f9f1696dd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120227
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [d2d22b506c14176b01e09899bcbb1975f292a1c7]

        Add Handler for BmpExScalePart Write
        
        The handler separates MetaBmpExScalePartAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I5afead72ae5c9c96c78ca915617bd2138458aaed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120158
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [640508cb3783fa9ba8ecf8acd257356c68b9cf48]

        Add Handler for BmpExScale Write
        
        The handler separates MetaBmpExScaleAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ie00f4a4d886c9c01a00c963b97dd905e05851b94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120157
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [23bb4465057ff71e3042fdb10d3a722ff54b861f]

        Add Handler for BmpEx Write
        
        The handler separates MetaBmpExAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Iee5fb4f2745feedffd96a00f4b233deb64d50de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120156
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [80a3d51f8c09d4c2aaabee95ee134fdd13cac5d2]

        Add Handler for BmpScalePart Write
        
        The handler separates MetaBmpScalePartAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I8d7f6eb8ee7b7f62190f3d4517ef62df7c0a2b15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120155
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [8d73346ae2afa31c4d954843c71d2eb1c2faef5e]

        Add Handler for BmpScale Write
        
        The handler separates MetaBmpScaleAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I653cde9fd306ba052326db0884010a6ea3b48306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120154
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  panoskorovesis  <panoskorovesis@outlook.com>  [b7aaa928e019eb71f41f9a4413b785b86719f7c5]

        Add Handler for Bmp Write
        
        The handler separates MetaBmpAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ic1a34231128fd3562f627afdc8d09ff5ab79bfef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120153
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  Noel Grandin  <noelgrandin@gmail.com>  [0ae13b5df161ec7e12477d5818c70909575c0aa7]

        no need to use unique_ptr for NamespaceDefine here
        
        Change-Id: I61ac177fab102c83d72337f608dc5ca8238e7819
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [1f6851c6f6d6fee67c56dd4e6e6013ba000eaf84]

        Upgrade external/boost to latest Boost 1.76.0
        
        *  <https://dev-www.libreoffice.org/src/boost_1_76_0.tar.xz> has been generated
        (on Fedora 34) with
        
        > $ wget https://boostorg.jfrog.io/native/main/release/1.76.0/source/boost_1_76_0.tar.bz2
        > $ printf 'f0397ba6e982c4450f27bf32a2a83292aba035b827a5623a14636ea583318c41 boost_1_76_0.tar.bz2' | sha256sum -c # cf. <https://www.boost.org/users/history/version_1_76_0.html>
        > boost_1_76_0.tar.bz2: OK
        > $ external/boost/repack_tarball.sh boost_1_76_0.tar.bz2
        > Unpacking boost_1_76_0.tar.bz2 ...
        > Removing unnecessary files ...
        > Creating boost_1_76_0.tar.xz ...
        > Cleaning up ...
        > adfa0ca971c56006a8304b6146d1382e6369815d568f6e6a7440fe29995d51b8  boost_1_76_0.tar.xz
        > Done.
        
        *  external/boost/0001-Fix-include-inside-boost-namespace.patch.2 is necessary
        to fix
        
        > checking for boost/math/constants/constants.hpp... no
        > configure: error: Required boost headers not found.
        > make[1]: *** [external/libzmf/ExternalProject_libzmf.mk:28: workdir/ExternalProject/libzmf/build] Error 1
        
        with recent libstdc++ 12 trunk (presumably since
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=261d5a4a459bd49942e53bc83334ccc7154a09d5>
        "libstdc++: Reduce header dependencies on <array> and <utility>", and with other
        standard libraries <utility> was likely already included indirectly earlier, so
        the include nested in namespace boost::math::tools::meta_programming in the
        middle of workdir/UnpackedTarball/boost/boost/math/tools/mp.hpp didn't cause
        harm).
        
        Change-Id: I1eee23915fea48bbb383cbeefc4ddfdeaac63e14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120253
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [29e5fad7ed64459d04df61b57ecd8eaba6d8bfae]

        sw: removed unused NO_NUMLEVEL
        
        NO_NUMLEVEL is not used in code for a while.
        
        Change-Id: Ia39879723455dbe5cc13b20042e930088618588d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120113
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7da5537f6a43c1b82afc5e0c8d18b8d847293fda]

        indexing: use XML as input that is identical to indexing XML
        
        Change-Id: I2242b4bd77220b55e67c2e0f0fe54f008759d282
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120194
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [fa5202f746b25ea444d120d746a0dc35b8f8cca5]

        give SwTableBoxFormat::TableBoxAttributeChanged its own function
        
        - ... because at somewhere around growing past 100 LOC it deserved that.
        - also make the box a reference there as it should never be a nullptr
        
        Change-Id: Ia14cfb7a88e14fdd02f6011a745c2b008d94bc10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120159
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-08-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [df3d733724de84a2b54398434b621049a326c4d8]

        indexing: add "type" to the xml for paragraph nodes
        
        The type is either WriterNode (1) or SdrObect (2) as we need to
        know for which one the index is refering to.
        
        Change-Id: I0f4bc95d91e37cf75db5ed49cd14df61133f5f19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120193
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ea1818b8ba34378b777b8706069d28fade2cc924]

        indexing: add support for SdrObjects in SearchResultLocator
        
        Also add (node) "type" parameter because we need to differentiate
        between Writer nodes and SdrObject nodes.
        
        Change-Id: I590695ae71781f64c22bdd7e1df01d69e3376e67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118671
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-10  Miklos Vajna  <vmiklos@collabora.com>  [fc4c0747e97bb997cc37263b3e86b07dab21fe25]

        tdf#142845 editeng: don't update selection when formatting before sd paste
        
        Regression from commit f0c25c751cf8e166a84b289746bce6202a40391d
        (tdf#115783 sd: fix lost char attributes during in-table copy&paste,
        2018-02-16), the problem was that the formatting before paste also
        created an undo action, and executing it alters the selection, which was
        not intended.
        
        So in case the textbox contains "world" and we paste "hello", then the
        undo will set the cursor at the end of "world", while the expected
        result is to just undo the paste and the formatting of "world".
        
        Fix the problem by not altering the selection in the undo of
        Outliner::SetCharAttribs(), which is only called by sd/ in the
        before-paste case, not anywhere else.
        
        Change-Id: Ie4a08f57d22cd1862c02987a5f86089fda8a5d9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120220
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [34574d2094650673fb2f29e342eb259494088d1c]

        Mark external/harfbuzz/negativeadvance.patch as sent upstream
        
        Change-Id: Ia12ea1fce7a994b519e743edbc18cbd27ccb78bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120210
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Stephan Bergmann  <sbergman@redhat.com>  [43542cc07ee110abe25a1e176238fd6d921d593b]

        Missing include
        
        (for std::unique_ptr, with recent libstdc++ 12 trunk)
        
        Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9da7b1592e010928c26c43ee93b91cdd66403985]

        sw: remove all uses of MM50 with (added) o3tl::toTwip
        
        MM50 constant is the number of twips for 5mm. This is (ab)used as
        a "shortcut" to set or compare various variables through the code
        and also to set a multiplied value (like 1cm, 2cm, 4cm) or divided
        value (2.5mm, 1.25mm). The problem with this is that converting the
        5mm to twip doesn't round up exactly and multiplied and divided
        values increase the error even more.
        
        Instead of basing it from MM50 constant, it is just better to use
        our o3tl::convert (or the added variant o3tl::toTwip), which can
        actually calculate the conversion at compile time, so there is no
        added complexity at runtime and we get a more readable code with
        more exact result.
        
        i.e.
        o3tl::toTwip(4, o3tl::Length::cm)
        instead of the more cryptic
        MM50 * 8
        
        In addition also sanitize and comment the values of the constants
        in sw/inc/swtypes.hxx.
        
        Change-Id: I85c306c36207d47ac3dc207094b68d0fb1ca5b70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119397
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [eeeef98796df322d89912070c8e431c5f6d1283f]

        return true to indicate event was consumed
        
        noticable as a problem in gtk4 with repeat button in calc tabbar
        not seeing the release
        
        Change-Id: I22fe296d8935e8fe5be0df043a80ec116f4d5cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120206
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  Miklos Vajna  <vmiklos@collabora.com>  [82a444eabc38b74d762debb6f1af50e93e5b74f1]

        sw HTML export: avoid writing EMF data with JPG extension
        
        Regression from commit f3b2fc2276ee8a7f64e73d9975d0143d1696362c (sw
        XHTML import, improved <object> handling for images: support more
        formats, 2021-07-20), the problem was that now an EMF image was written
        with the JPG extension in the HTML export.
        
        Solve the problem by making the "use emf as-is" check more strict in
        XOutBitmap::WriteGraphic(): that will be still true in the XHTML case
        when the source image is EMF, but the filter name will be JPG in the
        HTML case, so that will avoid the unwanted EMF data in the HTML case.
        
        Change-Id: I7bced482d677cf121be1ed494a3aaeb319e1c5b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120209
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-09  Balazs Varga  <balazs.varga991@gmail.com>  [233286df08aeedb4e228fd523365b94543b16fca]

        tdf#64086 tdf#143623 tdf#66250 XLSX: fix named ranges in charts
        
        tdf#64086: fix broken XLSX import of named ranges in charts
        
        Do not create inner data table in Calc for charts, if the
        data source contains named ranges. Use the named ranges
        (local sheet names and global names) to find the data
        source of charts, so it will be updated correctly if we
        modify the values in cells.
        
        Second part:
        
        tdf#143623: chart OOXML, offapi: export the named ranges in charts
        
        with the proper special (non-ooxml-standard) Excel syntax.
        We need to add "[0]" characters before a global named range
        for proper refreshing of chart data. Also we have to add the
        sheet name to the local named ranges even if it's on the same
        sheet, but only in case of charts. Because of this, add property
        RefConventionChartOOXML to com::sun::star::sheet::FormulaParser,
        which specifies that use special OOXML chart syntax in case of
        OOXML reference convention, when parsing a formula string.
        
        Third part:
        
        tdf#66250 ODF chart: export the reference of named ranges
        
        in case of charts, if the named range contains a valid reference.
        
        Note: maybe export the name of named ranges would be a nicer
        solution in the future.
        
        Follow-up of commit 3c766512984feff739377d0f0af46558ee7139fd
        "Related: tdf#64086 Add FormulaGrammar::isRefConventionOOXML()".
        
        Thanks to Eike Rathke for his help.
        
        Change-Id: I10d8563fb436092e833682f331c25b0c0829ef86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118862
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-09  dante  <dante19031999@gmail.com>  [e8d8dad6bba2bd0a4307ee3c1fc40f117680c1f3]

        Add an iterator for the new starmath matml elements
        
        Change-Id: I7b57951795e8acd704f418d10e5fd0aded3f2b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120187
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [ccb1d71fe4c0585a42721f09d984fb699ff8f081]

        tdf#143664: svl_qa_cppunit: Add unittest
        
        Change-Id: If62da781bffc2480fd81dd6aaf28db69b46a0e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120198
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-08-09  Stephan Bergmann  <sbergman@redhat.com>  [73b492255e4268aa4003bc3e68be4cd2a27a6ce2]

        Guard read of rCont_.bIsList with rCont_.rMutex
        
        ...as had been the case prior to 12dce07aec980562fa449fa1884e0e8379d680fb
        "loplugin:unusedfields - look for fields that can be const, in comphelper"
        (which this commit partly reverts; the const'ness of
        OInterfaceIteratorHelper2::bIsList had already been reverted, but for no
        apparent reason, in 31b0be0f21479323408e128f2e8a1a795e037e74 "improve pahole
        script and pack a few classes").
        
        That may or may not have been the cause of the apparently-sporadic
        UITest_sw_table failure at <https://ci.libreoffice.org//job/lo_ubsan/2096/>,
        
        > /comphelper/source/container/interfacecontainer2.cxx:54:29: runtime error: member call on address 0x606000ed5d20 which does not point to an object of type 'com::sun::star::uno::XInterface'
        > 0x606000ed5d20: note: object has invalid vptr
        >  22 04 00 14  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  01 00 00 00 be be be be  b0 11 46 00
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               invalid vptr
        >     #0 0x2ab564a71e15 in comphelper::OInterfaceIteratorHelper2::OInterfaceIteratorHelper2(comphelper::OInterfaceContainerHelper2&) /comphelper/source/container/interfacecontainer2.cxx:54:29
        >     #1 0x2ab57614588f in void comphelper::OInterfaceContainerHelper2::forEach<com::sun::star::document::XDocumentEventListener, comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper2::NotifySingleListener<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> const&) /include/comphelper/interfacecontainer2.hxx:261:31
        >     #2 0x2ab576144a95 in void comphelper::OInterfaceContainerHelper2::notifyEach<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) /include/comphelper/interfacecontainer2.hxx:279:5
        >     #3 0x2ab57613b277 in (anonymous namespace)::SfxGlobalEvents_Impl::implts_notifyListener(com::sun::star::document::DocumentEvent const&) /sfx2/source/notify/globalevents.cxx:505:26
        >     #4 0x2ab576131faa in (anonymous namespace)::SfxGlobalEvents_Impl::documentEventOccured(com::sun::star::document::DocumentEvent const&) /sfx2/source/notify/globalevents.cxx:256:5
        >     #5 0x2ab575f4abfc in (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const /sfx2/source/doc/sfxbasemodel.cxx:3200:13
        >     #6 0x2ab575f002ec in void cppu::OInterfaceContainerHelper::forEach<com::sun::star::document::XDocumentEventListener, (anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> >((anonymous namespace)::NotifySingleListenerIgnoreRE<com::sun::star::document::XDocumentEventListener, com::sun::star::document::DocumentEvent> const&) /include/cppuhelper/interfacecontainer.h:292:17
        >     #7 0x2ab575efdd37 in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&) /sfx2/source/doc/sfxbasemodel.cxx:3234:14
        >     #8 0x2ab575efa257 in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) /sfx2/source/doc/sfxbasemodel.cxx:2883:9
        >     #9 0x2ab57a796d83 in SfxBroadcaster::Broadcast(SfxHint const&) /svl/source/notify/SfxBroadcaster.cxx:39:24
        >     #10 0x2ab6010f0e1f in SwLayIdle::SwLayIdle(SwRootFrame*, SwViewShellImp*) /sw/source/core/layout/layact.cxx:2375:24
        >     #11 0x2ab60385d4e2 in SwViewShell::LayoutIdle() /sw/source/core/view/viewsh.cxx:723:19
        >     #12 0x2ab5ff549ffa in sw::DocumentTimerManager::DoIdleJobs(Timer*) /sw/source/core/doc/DocumentTimerManager.cxx:177:42
        >     #13 0x2ab5ff54552a in sw::DocumentTimerManager::LinkStubDoIdleJobs(void*, Timer*) /sw/source/core/doc/DocumentTimerManager.cxx:157:1
        >     #14 0x2ab599cf5f41 in Link<Timer*, void>::Call(Timer*) const /include/tools/link.hxx:111:45
        >     #15 0x2ab599cf5498 in Timer::Invoke() /vcl/source/app/timer.cxx:75:21
        >     #16 0x2ab599b388ea in Scheduler::CallbackTaskScheduling() /vcl/source/app/scheduler.cxx:471:20
        >     #17 0x2ab59ad34490 in SalTimer::CallCallback() /vcl/inc/saltimer.hxx:54:13
        >     #18 0x2ab59ad2785c in SvpSalInstance::CheckTimeout(bool) /vcl/headless/svpinst.cxx:215:53
        >     #19 0x2ab59ad2e67c in SvpSalInstance::DoYield(bool, bool) /vcl/headless/svpinst.cxx:460:21
        >     #20 0x2ab599c35aa9 in ImplYield(bool, bool) /vcl/source/app/svapp.cxx:465:48
        >     #21 0x2ab599c34c67 in Application::Yield() /vcl/source/app/svapp.cxx:532:5
        >     #22 0x2ab599c348ae in Application::Execute() /vcl/source/app/svapp.cxx:444:9
        >     #23 0x2ab55d699b4b in desktop::Desktop::Main() /desktop/source/app/app.cxx:1603:13
        >     #24 0x2ab599cde4e9 in ImplSVMain() /vcl/source/app/svmain.cxx:199:35
        >     #25 0x2ab599ce7510 in SVMain() /vcl/source/app/svmain.cxx:231:12
        >     #26 0x2ab55d890775 in soffice_main /desktop/source/app/sofficemain.cxx:98:12
        >     #27 0x4efc6c in sal_main /desktop/source/app/main.c:49:15
        >     #28 0x4efc46 in main /desktop/source/app/main.c:47:1
        >     #29 0x2ab55f48e554 in __libc_start_main (/lib64/libc.so.6+0x22554)
        >     #30 0x41b5c1 in _start (/instdir/program/soffice.bin+0x41b5c1)
        
        Change-Id: Iaa930f1612a3bb6ad0bcad12f3995b7dbb2e5fa7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120205
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [5ba46ce92810f0cf868e50fa4440500c91acbea5]

        enforce no image-position in GtkCheckButton/GtkRadioButton
        
        Change-Id: I686d0f3f66209a0e173065a2c28e7cf1960a28e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120203
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [b2130ad3fda841c68a0436fbddf29bcedede0af5]

        stray unwanted and unneeded image-position properties
        
        Change-Id: I094132890dd735c0941d5de87677c0290efe37f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120204
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [9834978391309818ffe28eb6efa3f7de04f426c9]

        change image-using RadioButtons to ToggleButtons instead
        
        Change-Id: I893ccdacfc76ecd9a3d83101f3b6f2e5f97fdb70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120202
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  Noel Grandin  <noelgrandin@gmail.com>  [2c9ead762dce6f75350f71e6418a81afe0d89092]

        can pass PropertyChangeNotifier around by value
        
        Change-Id: I0e88d5d9dc8dcfdf3310311038104fed2895119a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120195
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [5470cc97d84a51dd4e541a8647ffe093bc4aa221]

        remove unneeded -ldl for DISABLE_DYNLOADING
        
        I think we only had -ldl in here for -lpthread which is gone now
        
        Change-Id: I8a52a5cd4aeae8aff793c98b7f55d7a73e068b9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  Stephan Bergmann  <sbergman@redhat.com>  [6e53e03f752c2f85283c4d47efaaf0683299783c]

        external/harfbuzz: hb_graphite2_cluster_t::advance can apparently be negative
        
        ...as seen with `instdir/program/soffice --headless --convert-to pdf` of
        doc/abi6073-2.doc from the crash-testing corpus when run under UBSan,
        
        > hb-graphite2.cc:361:15: runtime error: -1024 is outside the range of representable values of type 'unsigned int'
        >  #0 in _hb_graphite2_shape at workdir/UnpackedTarball/harfbuzz/src/hb-graphite2.cc:361:15
        >  #1 in _hb_shape_plan_execute_internal(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, hb_feature_t const*, unsigned int) at workdir/UnpackedTarball/harfbuzz/src/./hb-shaper-list.hh:38:1
        >  #2 in hb_shape_plan_execute at workdir/UnpackedTarball/harfbuzz/src/hb-shape-plan.cc:453:14
        >  #3 in hb_shape_full at workdir/UnpackedTarball/harfbuzz/src/hb-shape.cc:139:19
        >  #4 in GenericSalLayout::LayoutText(ImplLayoutArgs&, SalLayoutGlyphsImpl const*) at vcl/source/gdi/CommonSalLayout.cxx:495:23
        >  #5 in OutputDevice::getFallbackLayout(LogicalFontInstance*, int, ImplLayoutArgs&, SalLayoutGlyphs const*) const at vcl/source/outdev/font.cxx:1232:21
        >  #6 in OutputDevice::ImplGlyphFallbackLayout(std::unique_ptr<SalLayout, std::default_delete<SalLayout> >, ImplLayoutArgs&, SalLayoutGlyphs const*) const at vcl/source/outdev/font.cxx:1300:48
        >  #7 in OutputDevice::ImplLayout(rtl::OUString const&, int, int, Point const&, long, long const*, SalLayoutFlags, vcl::TextLayoutCache const*, SalLayoutGlyphs const*) const at vcl/source/outdev/text.cxx:1332:22
        >  #8 in lcl_CreateLayout(SwTextGlyphsKey const&, __gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<SwTextGlyphsKey const, SwTextGlyphsData> >, std::__debug::map<SwTextGlyphsKey, SwTextGlyphsData, std::less<SwTextGlyphsKey>, std::allocator<std::pair<SwTextGlyphsKey const, SwTextGlyphsData> > >, std::bidirectional_iterator_tag>) at sw/source/core/txtnode/fntcache.cxx:233:33
        >  #9 in SwFntObj::GetCachedSalLayoutGlyphs(SwTextGlyphsKey const&) at sw/source/core/txtnode/fntcache.cxx:257:12
        >  #10 in SwFont::GetTextBreak(SwDrawTextInfo const&, long) at sw/source/core/txtnode/fntcache.cxx:2551:58
        >  #11 in SwTextSizeInfo::GetTextBreak(long, o3tl::strong_int<int, Tag_TextFrameIndex>, unsigned short, vcl::TextLayoutCache const*) const at sw/source/core/text/inftxt.cxx:450:20
        >  #12 in SwTextGuess::Guess(SwTextPortion const&, SwTextFormatInfo&, unsigned short) at sw/source/core/text/guess.cxx:205:26
        >  #13 in SwTextPortion::Format_(SwTextFormatInfo&) at sw/source/core/text/portxt.cxx:305:32
        >  #14 in SwTextPortion::Format(SwTextFormatInfo&) at sw/source/core/text/portxt.cxx:456:12
        >  #15 in SwLineLayout::Format(SwTextFormatInfo&) at sw/source/core/text/porlay.cxx:260:31
        
        (where in frame #4 GenericSalLayout::LayoutText, pHbBuffer->props.direction is
        HB_DIRECTION_RTL, in case that is relevant).
        
        It is unclear to me whether it is sufficient to only change
        hb_graphite2_cluster_t::advance from signed to unsigned int, as there are other
        unsigned int variables (like curradv in _hb_graphite2_shape) whose value depend
        on hb_graphite2_cluster_t::advance, and which thus might also become negative.
        But unlike the float -> unsigned int conversion that UBSan warned about here
        (where gr_slot_origin_X() and xscale are float), those are signed int ->
        unsigned int conversions that do not cause undefined behavior.  At least, with
        this change, the above --convert-to pdf and a full `make check screenshot`
        succeeded for me under without further UBSan warnings.
        
        Change-Id: Ifa6fa930da162b986d3f536f8b3613790b3f19c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120192
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-09  Caolán McNamara  <caolanm@redhat.com>  [c97bdca2d7abf30a99c45192b8f49c5bf76ca035]

        gtk4: g_menu_item_set_detailed_action aborts with ids with spaces in them
        
        Change-Id: I6f421811f95add6ac0226a9043586f01cf45e8b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120180
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-09  dante  <dante19031999@gmail.com>  [6daf48b50e1ff3bdd6a9f948c3e267e76b8a89d3]

        Corrections to starmath mathml definitions
        
        Change-Id: I6f545ced857190ed4b0f4090c0d47611ff475b57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120183
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-09  Miklos Vajna  <vmiklos@collabora.com>  [6d90916793ddd12dc2eade8fc1bac907dde07326]

        sw: prefix members of SwXMLDDETableContext_Impl, SwXMLTableCell_Impl, ...
        
        ... SwXMLTableRow_Impl and SwXMLTableRowsContext_Impl
        
        See tdf#94879 for motivation.
        
        Change-Id: Ibff24ae9b6470069ceebaa5d133b8bdf0ee4e70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120190
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-09  Eike Rathke  <erack@redhat.com>  [1c5b3cb3dd4dab6b0db409b6cc75b3111103820f]

        Related: tdf#143759 Display results of find empty or replace to empty
        
        Searching for empty cells or replacing to empty cells didn't list
        the results because ScCellIterator iterates over cells with
        content only.
        
        Change-Id: If6ea65f853cae621e54ce545fe7fbed2b445fd14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120189
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-08  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [d1f1f546b212ecd651146addeb328806bb270d5f]

        sw: numbering rule is not constructed for numbering type "None"
        
        Previously during refactoring this condition was lost. And it
        is possible practically that we have all format for numbering
        (prefix, suffix, format string, etc) but numbering is disabled.
        
        Change-Id: I0c8ab446753308ad80b8d133824a936dacf6cc82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120082
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-08  Noel Grandin  <noelgrandin@gmail.com>  [2c1ae17421af0fc0e398b66bc2a07f27977a5bf0]

        no need to allocate ControlLayoutData separately
        
        Change-Id: I239befdaa05beea5200c81f23d0af861c9fc3baa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120177
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-08  Jim Raykowski  <raykowj@gmail.com>  [12dd1ce1dddc4ebad6be94ddec167cc7f6c45fe3]

        tdf#138960 Check if tree entry has children before attempting to expand
        
        or collapse
        
        Change-Id: Icbfc50dda35bb6027c12a42b5e8f79da165888e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120129
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-08-08  Jim Raykowski  <raykowj@gmail.com>  [18004b707d2cb92ab88923138d72c5ca1b03301c]

        tdf#143572 Restore enable undo setting immediatly after object name
        
        is set each time here
        
        This prevents a crash when an object is in text edit mode and a
        different object is selected in the navigator to jump to.
        
        Change-Id: I7c0eaa7770f0e3f23e6a62780f18e0a973019c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120170
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-08-08  Noel Grandin  <noelgrandin@gmail.com>  [ec867a13baaa43791d8bacf4e8c1b96aadb6aa8a]

        tdf#143534 Crash in Calc NLP Solver
        
        prevent dialog from being deleted out from underneath
        the code handling the dialog.
        
        Change-Id: Ib1ef05f897901089708188820a3330dbeabc24c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120175
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-08  Eike Rathke  <erack@redhat.com>  [15960931988cfd898e14a12d6b9cddaf6d8b0ade]

        Resolves: tdf#143759 Limit empty search's empty column to actual search range
        
        ... instead of the non-/filtered last row.
        
        Change-Id: I9b941af688a8083d472a793a6bc6b6dbb7b916ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120176
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-08  Caolán McNamara  <caolanm@redhat.com>  [360b9c7d6ee29943475e706582ad1e3d923b592d]

        oss-fuzz: drop more_fonts build step and just install the min wanted
        
        Change-Id: I7e03be4c0137f49b8822991f91fdfe4367653c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120172
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-08  Caolán McNamara  <caolanm@redhat.com>  [98f125ecbb2a80c34213f7e86a417f74ee7e13a1]

        use some forward declares
        
        Change-Id: If7f726e8dddb63c8a566f9aa208cd317213d5eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-08  Caolán McNamara  <caolanm@redhat.com>  [c7a708f8c38f47b8c0f74c87b2cb3889cafd4473]

        cid#1489971 silence Arguments in wrong order
        
        Change-Id: Ib4bb02a152443ba83b5019ea618265a9363363a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [9104017e1bf76857d2b9686363013e1e7c49e355]

        create comphelper:OMultiTypeInterfaceContainerHelperVar2 and use it
        
        based on OInterfaceContainerHelper2 which is considerably
        faster than the original OInterfaceContainerHelper
        
        Change-Id: Ia8cdbc5ef877a7af3d9193e1bb2faf1595c15470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120165
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-08  Eike Rathke  <erack@redhat.com>  [5e69c5fbdb44cd782080e7f4d9ad89dc48b2d1b1]

        Year without leading 0 if era code is also used
        
        YYYY GG or GG YYYY
        shall display 1 BC not 0001 BC, or AD 1 not AD 0001
        
        Change-Id: I1955f55d37a4af5075c9cfc20c3ea200ba340765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120174
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-07  Caolán McNamara  <caolanm@redhat.com>  [ac0db5736a53a4887cebbacc59026cecb7c44c66]

        disable scripting for fuzzing
        
        Change-Id: I67c1c00fa716242336bbad1dd3df079e277ea776
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-07  Caolán McNamara  <caolanm@redhat.com>  [b793a22aba36f77085ca699966bf9472a7342173]

        log when fuzzing build starts and ends
        
        Change-Id: Id5db6c6dc799c03013576e0d041ab180ea4ac77f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120168
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-07  Caolán McNamara  <caolanm@redhat.com>  [60afbaf1616ed56247340837449ab580e54310a6]

        explicitly disable ldap for fuzzing
        
        though its already implicitly disabled
        
        Change-Id: Ia896ee187cae9e7bae6569559f5ceb824c8c86ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120167
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-07  Noel Grandin  <noelgrandin@gmail.com>  [86abf3a682b424dc0fcbccf030f5a0b9bfb81d8c]

        create comphelper::OMultiTypeInterfaceContainerHelper2 and use it
        
        based on OInterfaceContainerHelper2 which is considerably
        faster than the original OInterfaceContainerHelper
        
        Change-Id: I9c8b6d0e5382018824bf7188a26343703abf2d51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120161
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-07  Caolán McNamara  <caolanm@redhat.com>  [2cd1442f83d41af1f2b663ccb8bfab6a954009f1]

        cid#1489785 Dereference after null check
        
        Change-Id: Ia6b3ef68582ced9628e99bc5717e0a1563323f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-07  Caolán McNamara  <caolanm@redhat.com>  [6e29949de67a73782a137f341db5ade89ae99e50]

        cid#1489784 Dereference after null check
        
        Change-Id: I100125d12e6a649633356f19efa8895968236a08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120162
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-07  Eike Rathke  <erack@redhat.com>  [51406e88a93008458cf4a7d4f84aa0b169cb7d0b]

        Create destination directory also for non-empty sourcepath directory
        
        Do not attempt to copy anything. This can happen with
        instdir/share/extensions being populated from some build (e.g. by
        dictionaries) but no extension to be installed.
        
        The result was
        ERROR: Can't copy file: /build/core/instdir/share/extensions -> /build/usr/opt/core/lib/libreoffice/share/extensions
        Is a directory at /build/core/solenv/bin/modules/installer/worker.pm line 350.
        
        and the copy() created the destination as 0-length file instead.
        
        The recent changes not copying extensions/packages.txt anymore and
        related may have triggered this:
        
        6c487d2d7e8aa5cdef55cbd7bc78058184671d82 Fix and simplify "any bundled extensions installed" check
        626050e86b7d5ca0c3bfc265cc33ce8e9d1bf195 gb_Package_Package must specify a directory
        f267340d300da6318435ed1b2ae48b9f4275e2c4 Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txt
        
        Change-Id: I93c1b0867bf234255fdef9d31c447b9b20011e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120164
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ca481ac2ec7e89b1be4c5a7f14ef242a77cf24cb]

        Removed duplicated include
        
        Change-Id: I393ac16eae024cacf75039109680a978019a1a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120130
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-07  Noel Grandin  <noelgrandin@gmail.com>  [773a7b57fa99bdda9cde59937cd1987384ae533a]

        no need to use UNO_QUERY here
        
        Change-Id: I1bfe8238d7c08f27d2b21f9fe79712aba045c812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120152
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [e20d997eb3eb5c81af907718989aba4a6f9fc950]

        address some review comments
        
        from
           https://gerrit.libreoffice.org/c/core/+/77824
        
        Change-Id: I0e8d6958512a6063a3232136b6a61a865a0e6abf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [e54c167de6a15adc61dea8a1ac3a31e202573afa]

        address some review comments
        
        from
           https://gerrit.libreoffice.org/c/core/+/21643/6/
        
        Change-Id: I6df2de42e99b30b5a9c9d098b0873d2390fe5e8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120118
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-07  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bb5d2ef28be74356f966cc9534480f59153c7107]

        Fix typo
        
        Change-Id: I4fa33b3c1cc9e1dc666777dd2ceaf2432f2374b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120131
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-07  homeboy445  <akshitsan13@gmail.com>  [3c2cf76892890051e27e0e0798b7a06fc3acccd8]

        backendtest: drop like shape test for polygon / polyline
        
        Add a test for drawing a drop like shape using polygon and polyline
        drawing code-paths.
        
        
        Change-Id: Ifee7b978009d66af01ccbfc92b36d1423084ed48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118278
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [dded839196aa8ed20253025dd8200fb2ee50bcea]

        Add Handler for TextLanguage Write
        
        The handler separates MetaTextLanguageAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I1671a299e84f5575359474e0fc4f9128c738b1e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120111
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [0eb1b82dbc2dbaeefa06f42f4fc376b54d99bd1c]

        Add Handler for LayoutMode Write
        
        The handler separates MetaLayoutModeAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I63b045cb9bdb40e1b6c961d30df8bcfbe1b8129b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120110
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [f41a03960933fba0e3177ea0463c5c9ec361bc96]

        Add Handler for Comment Write
        
        The handler separates MetaCommentAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I2967b1f66c2467b622980ba3b65199ff8045d1b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120109
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [1a04ee2643ba970ededf1259918dea0122b9166c]

        Add Handler for RefPoint Write
        
        The handler separates MetaRefPointAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I04e666748ff75a145af8e3c1e44ae4f119cc1b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120108
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [3d1a4caf4062b906aaeab38f0b841dcacdc22c50]

        Replace ReadGDIMetaFile with Svmreader::Read in fftester.cxx
        
        Use the new read functionality in vcl/workben/fftester.cxx
        
        Change-Id: I8ece06ba143f5ae86fae05d43e3e3b325e20ddb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120107
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-07  panoskorovesis  <panoskorovesis@outlook.com>  [ad982bc87f96c31af6fa3e81d33af29b991199ce]

        Replace ReadGDIMetaFile with SvmReader::Read in svmfuzzer.cxx
        
        Use the new read functionality in vcl/workben/svmfuzzer.cxx
        
        Change-Id: Id8cc57bda70109f2ddbf81354f8d37d187f0f8d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120106
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-06  Eike Rathke  <erack@redhat.com>  [46131c5f8238bc3dca9a8d4eb097ad07f2d46fe0]

        Adapt LCIDs and language tags to [MS-LCID] rev.15
        
        See
        https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f
        https://winprotocoldoc.blob.core.windows.net/productionwindowsarchives/MS-LCID/%5bMS-LCID%5d-210625.pdf
        
        and
        
            commit 402dab839b2e451dec81bfb83dadbe0d5a231db2
            CommitDate: Wed Aug 4 21:21:51 2021 +0200
        
                update list of [MS-LCID] from 6/25/2021 15.0 rev.
        
        Change-Id: I44db2bfaf894ead119c7014e3770fc44be537148
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120128
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [56be83fbb9ac5bb1407f763588a04a6239e0bcd4]

        Move variable definition to usage site
        
        Change-Id: I3d95551cb72b867e19a1a2bf75c73d1c3422a984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120132
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-06  Noel Grandin  <noelgrandin@gmail.com>  [6af2e7d21ce050758ad07fbb951a38b2da2b6c4c]

        use more comphelper::OInterfaceContainerHelper2
        
        Change-Id: I255133e1823fd63620f27421b69cd23d75ebb6fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120127
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [26cfb57abfc037752bc02dae043f08ac7b2bc711]

        use Helper_optional SCRIPTING for libs that don't exist if --disable-scripting
        
        Change-Id: Iec65d6395b903e13f788fe8322b60aac5b974cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [245d73fa13bcb2b453308c304b215b9de4ae2602]

        disable a few more things when fuzzing
        
        Change-Id: Ia2180b532c6c6cf2d6a735f3a8607c200ca786f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120124
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [bd0c058811538a646196b479a8ce8d94a64763aa]

        fix --disable-avmedia clang-plugins warnings
        
        abandoned getting this to work because not sure what this should
        look like, seems caught between two stools as to what it wants to do
        
        Change-Id: Ica0d1e25f2a19dfee0fe40d3e106d05e1f861c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120119
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [cc21480a25f1a289c7dd1bc536699fcae1457fc8]

        make --disable-scripting compile
        
        Change-Id: Ie2be232e062389b74408dd9f001b1cf4db7db7d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120123
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Miklos Vajna  <vmiklos@collabora.com>  [030cdbc7f8782eb196f09661bc2f116d790de9be]

        tdf#132696 PPTX import: fix missing SmartArt when it's part of a group shape
        
        Regression from commit e9986153e44d7ec6ca9c5f1373971de74dcbacda (PPTX
        import: import SmartArt drawing into single GroupShape, 2019-03-14), the
        problem was that oox::ppt::PPTShape::addShape() and
        oox::drawingml::Shape::addShape() were not in sync.
        
        PPTShape unconditionally maps SmartArt to shapes, while the shared Shape
        class defaults to converting it to a non-editable metafile. The above
        commit changed the handling of in-groupshape SmartArts to go via
        Shape::addShape() instead of PPTShape::addShape(), which exposed the
        underlying problem that the convert-to-metafile mechanism is currently
        only working in the DOCX case.
        
        Fix the problem by again ignoring the convert-to-metafile flag for the
        PPTX import case.
        
        This also exposed a previously hidden problem:
        
        	make -C oox -sr CppunitTest_oox_drawingml CPPUNIT_TEST_NAME="testGroupShapeSmartArt testTdf131082"
        
        started to make testTdf131082 fail. The tweak in
        Shape::createAndInsert() fixes the testcase failure, but likely there is
        a deeper problem there, unrelated to the regression.
        
        Change-Id: I4e1e9645eaa266d0d7560767c3c59ba9549ccdb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120122
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [0ec10cff008eb2d8b2c4f5b5fa35b25162081e9e]

        template dialog starts in thumbnail view without thumbnail shown toggled
        
        and only toggled thumbnail toggle to on if it wasn't already in that
        mode, so default it toggled on in the .ui so it matches the initial
        setting
        
        Change-Id: I8c64014880d6f7ca4d6043bfef32b90040745dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120117
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [5c299f0112441ca095276376a9973cb4ff0fda02]

        cid#1489772 UR: Uninitialized read of field in constructor
        
        pass in SearchPoint to initialize pbest_t before it is then
        passed to setMemPoints
        
        setMemPoints sets the pbest_t variable of AbsGTBehavior so
        calling setPbest on AbsGTBehavior subclasses after calling
        that doesn't do anything so drop it, and then DEPSAgent.setPbest
        isn't needed anymore
        
        Change-Id: Id4fdc770cefc0f801218dc9bf51a6dc5b1e25d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120115
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Vert D  <devoptmsoi@gmx.com>  [8d8450f0c14db26fb8eb44677c2887e619200904]

        tdf#139647 refresh renamed items
        
        *Update templates names after rename (faster than reload).
        *Fix some warnings.
        
        Change-Id: I47387af91964afae8de8753289d49d19e6080863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119919
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Mike Kaganski  <mike.kaganski@collabora.com>  [b791974837a99ead793b4ead6760b2f4e5237de2]

        Move ActionLockGuard up a bit
        
        Change-Id: Iaa1f3a5e2b9ad0605c53efa6a17d467159597927
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119991
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-06  Stephan Bergmann  <sbergman@redhat.com>  [6c487d2d7e8aa5cdef55cbd7bc78058184671d82]

        Fix and simplify "any bundled extensions installed" check
        
        First, Extension_nlpsolver is not unconditionally covered by --with-java, but by
        a dedicated --enable-ext-nlpsolver (which requires --with-java).  (I had
        overlooked that the whole Module_nlpsolver is conditional in
        RepositoryModule_host.mk.)  So the check for Extension_nlpsolver should instead
        check for NLPSOLVER in BUILD_TYPE.
        
        Second, the check for --enable-ext-numbertext could check for NUMBERTEXT in
        BUILD_TYPE instead of checking for NUMBERTEXT_EXTENSION_PACK, as
        --enable-ext-numbertext sets both (cf. m4/libo_check_extension.m4).
        
        And third, any --enable-ext-* will set WITH_EXTRA_EXTENSIONS (cf.
        m4/libo_check_extension.m4), so all those various BUILD_TYPE checks can all be
        subsumed by a single WITH_EXTRA_EXTENSIONS check.  (Which nicely reduces the
        maintenance burden mentioned in the commit message of
        f267340d300da6318435ed1b2ae48b9f4275e2c4 "Remove unused
        $(LIBO_SHARE_FOLDER)/extensions/package.txt.")
        
        Change-Id: Ifdf8b59febd49661500292ab2003c792d8cb60a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120104
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [5ba792bdda1db0561d6bdbb5deea37a1954cf257]

        oss-fuzz: disable some more features we don't need
        
        trying to squeek this build under the unknown upstream TIMEOUT
        
        Change-Id: I77e65f2124ae09ff11209c2631437f3b77013290
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120114
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [105b3756d88944172d241be316a2207028f2cf20]

        cid#1489780 Explicit null dereferenced
        
        Change-Id: Ia6e34b48cdcc4b011c46c576269cdeffab4821ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [413b80ed1a9d29f394d0746106f5698e65fe23dc]

        return a reference instead of a pointer
        
        and remove redundant nullptr OSL_ENSURE check
        
        Change-Id: I19e202c3786386ed6f094504a0e1eb6928aa423a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120105
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [6189a79cd3a589a403415d288389780167133797]

        elide some ctors
        
        Change-Id: I1cf5260ec57442e7c82b92db89227c08c943f689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120103
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [fb41deb8b86a48d9dbfbd2e65ee342e39a94f4d9]

        cid#1487034 Untrusted value as argument
        
        Change-Id: I7f50e8b1676d36a3675657d160c10196c08c26d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [1ee8da1d118fcb12752ba10e4bc58737fddeac64]

        cid#1487034 use rtl::Reference from the start
        
        Change-Id: I8db3aa83f02941bc630203383b2e05d3b6471e8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Miklos Vajna  <vmiklos@collabora.com>  [068be2699e992a571f8851e7db6362dee8746ee3]

        sw: fix footer for new file
        
        And a tab in makefile where surrounding code uses spaces.
        
        Addresses
        <https://gerrit.libreoffice.org/c/core/+/120077/2#message-980569fcf06d57af04db12f1f8d96e805336c902>.
        
        Change-Id: I4a4e5fd5c989cbce5fa0602484eb6bba21c19851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120096
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [1aee8678c83c637a2d5c1e0a716528b0bcf11de0]

        drop intermediate vcl::Window from Application::GetDefDialogParent
        
        Change-Id: I96be984cbefeb8e45bf49de4c50a225a46fbefb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120089
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  Caolán McNamara  <caolanm@redhat.com>  [373da7a00986ea95ce959242c0876a5eaf18a1b6]

        cid#1489779 Uninitialized pointer field
        
        Change-Id: I3a9405ff1ed161a02b590d2ac996d88b5fb1978d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [1f4986d178e9bab1be48e0c0a393271598e31eee]

        Add Handler for EPS Write
        
        The handler separates MetaEPSAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ib9866966ba067223860ddfd2b48880f6e83fe537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119968
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [49a2a16c6186d372afd66b6630c813e33448b3e4]

        Add Handler for FloatTransparent Write
        
        The handler separates MetaFloatTransparentAction::Write from
        metaact.hxx. Read implementation is now in SvmWriter.hxx
        
        Change-Id: I77755cc6c9337903808ade7b367d32d89f35a6a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119967
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [9eae429060cd968026834943f26f04a567f33e04]

        Add Handler for Transparent Write
        
        The handler separates MetaTransparentAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I8ae0e9341f2319126afc64cb633a0199d2496976
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119966
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [fba03519001f606f5ed5e7ae892dd76f004931b2]

        Add Handler for RasterOp Write
        
        The handler separates MetaRasterOpAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I80647d924f978b15682c18f8a27eff5e58b0fdd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119965
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [bb2828cebf05467d2c301a476b2d485467de0c51]

        Replace GDIMetaFile::Read with SvmReader::Read in linkmgr2.cxx
        
        Use the new read functionality in sfx2/source/appl/linkmgr2.cxx
        
        Change-Id: I25632dc11f50c0d16b2505acf2b4c271ef0a8775
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119964
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  panoskorovesis  <panoskorovesis@outlook.com>  [478a1ca5b169889cea0c09c2e18970223312ea2e]

        Replace GDIMetaFile::Read with SvmReader::Read in svgexport.cxx
        
        Use the new read functionality in filter/source/svg/svgexport.cxx
        
        Change-Id: I798bd35df9f7f15c5f802b8a6b2f5af2136ce0d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119963
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-06  Stephan Bergmann  <sbergman@redhat.com>  [626050e86b7d5ca0c3bfc265cc33ce8e9d1bf195]

        gb_Package_Package must specify a directory
        
        ...even if unused, as otherwise a minimal --without-java build (i.e., where the
        ifeq in setup_native/Package_packinfo.mk actually triggers) failed with
        
        > setup_native/Package_packinfo.mk:18: *** gb_Package__check: Package setup_native_packinfo has not been defined.  Stop.
        
        Change-Id: I0fa3640448da333294ee2ab25183df1ffee22533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120094
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-06  Noel Grandin  <noelgrandin@gmail.com>  [43d6a33dddd339b0bc8d42fece9e22dc44c9da57]

        osl::Mutex->std::mutex in DAVSessionFactory
        
        Change-Id: I1fa55f09e3a9d398a61856986cb0a91e225c7b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-06  Noel Grandin  <noelgrandin@gmail.com>  [cc6701f9e58f4b655313fa75da8980bb93ae545e]

        osl::Mutex->std::mutex in ParentStorageHolder
        
        Change-Id: I01cd21cddc10b09ea8026e84fa64331067b38db0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-06  Miklos Vajna  <vmiklos@collabora.com>  [1dd1cf97392f336c05ea76ccda273bb15f2e0b4e]

        sw: handle mbMathBaselineAlignment when replacing compat options
        
        This is on for new documents and off for old ones.
        
        Change-Id: Ia96fd1901ddb5872730716824096509a80b0b9c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120083
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-05  Zeynep Yavuz  <zeynepyavuz2001@hotmail.com>  [e642179f466c899365fc9539a8aca66b39fea39a]

        tdf#143148: Use pragma once instead of include guards (Episode 2: Endgame)
        
        Change-Id: I049bd94eaaa771584d18859903ef75e4319494b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119893
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [f376d68736d9a0f08b2a6ae5c126b0bb5570ff4b]

        osl::Mutex->std::mutex in InteractionSupplyPassword
        
        Change-Id: I98d54c8ab1c193a3eb43898a7be68986dd581447
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [dfed833ff3ef1532b18745df5ac0909d4e09028e]

        osl::Mutex->std::mutex in OfficeDocumentsManager
        
        Change-Id: I4de3e5ea25614bb032d68476c76f32d03d6e40b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [949e6d0a6f2024a9d864fe1ed2d0d1d34838bde6]

        osl::Mutex->std::mutex in fileaccess::FileProvider
        
        Change-Id: Ie110938cc7673739cc31588508987ca18617e5c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120026
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [417f881d20cafe88a02b64894ba4483875fb9460]

        improve LOK notifyInvalidation
        
        (*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger,
        so we avoid the cost of a resize&copy
        (*) use our optimised OString concatentation instead of going via
        std::stringstream
        (*) pass down a pointer to rectangle, instead of a string. later we will
        use this to avoid doing the stringify until later
        
        Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120072
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [466d464a7f31f10475c14260c6b0f11f1cb5a931]

        osl::Mutex->std::mutex in StdInputStream
        
        Change-Id: I85f7a67732d7739baa8b20d8e5df884080d31467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120019
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [85d8b2f34bbb50288217fae395f72e1d1df7f4d6]

        osl::Mutex->std::mutex in StdOutputStream
        
        Change-Id: I32f9366eef17f213d6b3dc9b5c0b6ba7ff9e7d83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120020
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  oguzbalkaya  <oguz.balkaya@gmail.com>  [ae1ac7eaf14a78bff050b90daaf7a9996cfc2f9a]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I036dd26b2e70c12896afcef2ce25586e8db3098c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119959
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [c4127ca194a20aa81da6fb09d765f353cadd6eb8]

        make Dialog::GetDefaultParent private
        
        Change-Id: I47d8e125646ee72aa6a9c12bbfdf09a784769d85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120080
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Stephan Bergmann  <sbergman@redhat.com>  [f267340d300da6318435ed1b2ae48b9f4275e2c4]

        Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txt
        
        There had originally been some back-and-forth among
        134ae5da1cc6a5dfa4432063f930235c1a872bc0 "jl154 #162868# remove
        basis/presets/bundled/bundled.ini, and create always share/extensions folder",
        4c333e8ac7f6135fb4e62e4960c826b278e8cc63 "jl154 #162868# removing the
        package.txt from the extensions folder. Extensions folder will be created in a
        different way than installing a dummy file", and
        8f4cf9a16eb9936ef1e862ecdec7d30c9e240987 "jl154 #162868# guarantee existence of
        extensions folder" whether or not that dummy file was necessary to ensure
        creation of the (otherwise potentially empty) $(LIBO_SHARE_FOLDER)/extensions/
        directory.  That is no longer necessary with gb_Package_add_empty_directory
        (though the logic that had to be added to setup_native/Package_packinfo.mk now
        is a bit unfortunate, and will need to be updated whenever the list of potential
        bundled extensions changes).
        
        (And that dummy package.txt file is apparently not used to track whether per-
        user extension information needs to be updated when the contents of
        $(LIBO_SHARE_FOLDER)/extensions/ changes.  That is rather done by
        comparing the status of the $(LIBO_SHARE_FOLDER)/extensions/ directory itself
        against user/extensions/bundled/lastsynchronized in the UserInstallation, see
        needToSyncRepository in desktop/source/deployment/misc/dp_misc.cxx.)
        
        Change-Id: I5b9956c508288945f32a88afaef57ac0b63dc27f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120081
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-05  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [6e879d5f142766c941d1c3bafd17f67b78c1c9f4]

        tdf#99932: sw: fix for invalid anchor location for FLY_AT_CHAR mode
        
        In such case anchor position depends on LastCharRect which can be
        invalid because of happened frame movement, resize, etc.
        
        Change-Id: I3d3c6318ee1ce5f4043e21ab091417d283c4260c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120059
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-05  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [4edf3a964e764dcc40be729b8305476c5b968f1c]

        sw: undo/redo for outline modification
        
        Outline changes done via "Tools"->"Chapter Numbering" were
        not tracked by undo/redo before.
        
        Change-Id: I764dda526d2b17ecbb62eca0d6a9fb0b368c4a69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119405
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [3487d85ea384f74c096499cfea8e565e778f8408]

        osl::Mutex->std::mutex in fileaccess::XStream_impl
        
        Change-Id: I0cf23f83ae66669c4bbd17f68992126143756b27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120025
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [c0ab666edcd3507961eda47d80efaba4f4da129d]

        osl::Mutex->std::mutex in HierarchyDataAccess
        
        Change-Id: I267c4efcedba5904b3b373f0b9ff3460731b7011
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120027
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [0494ad3495efe9f72809f18abe3ca95d49d7412f]

        osl::Mutex->std::mutex in SidebarWinAccessibleContext
        
        Change-Id: Ic8cba9d900f74511ad721085f9d728b43c1be3c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120018
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [2f2616a886cbf7bc06816d6b4a6f6b991f896d51]

        osl::Mutex->std::mutex in SwSendMailDialog_Impl
        
        Change-Id: I81ad469f8cb45d7ece97a256301e7ea71683d2ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120017
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [d43c1b9b88eeb800eaff4d63605892dc859d4f72]

        drop unneeded forward declares of Control
        
        Change-Id: I033fabfc0e40ddac093c3cae34fccea0647ebd24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120071
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [3fbae5dc7e7b200776bbc8a7c2a43e1e04f15a2b]

        gtk is the only case auto-accel is true, and the menubar is native gtk there
        
        so this special case handling can go now
        
        Change-Id: I98675b084fbef463d7ee4ee452eb57d1d4ff20c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120074
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Miklos Vajna  <vmiklos@collabora.com>  [746d95bb4067943679f0fe3b8bf91269debf519b]

        find-unneeded-includes: remove leftover debug print()
        
        Change-Id: I738d191415db130d875d5b7139ff768ad389dd93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120070
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [63773ac90ed83987063077184e48b526f70216eb]

        tdf#143728 Certain presentation crashes Impress after starting slideshow
        
        Revert "osl::Mutex->std::mutex in EventQueue"
        This reverts commit c0ce120b55ba389729e97babf80f2cb39ce38e9f.
        
        because we try to take the same lock twice
        
        Change-Id: Ie62659ec3407089f616d1ea950a3755300d68eef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119988
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [e05e05d26ea1421c919a789c9c1afd393e0c19b2]

        osl::Mutex->std::mutex in fileaccess:XRow_impl
        
        Change-Id: I197c35b8405db418870354b0d0791dad6d5ea6d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120024
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [5d5bea3a816794cf176ffee582b9f19684ad745e]

        remove pimpl in hierarchy_ucp::HierarchyResultSetDataSupplier
        
        Change-Id: Ifb9f3ea211ebbc45c7aa1713456bcbc5587ee3ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120023
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Miklos Vajna  <vmiklos@collabora.com>  [39392ee94c78692a9179f7face15af0c9e74e492]

        sw: fix assert fail with ShowRedlineChanges=false and para format
        
        It fails like this:
        
        	loolforkit: sw/source/core/layout/wsfrm.cxx:4551: void UnHide(SwRootFrame&): Assertion `rLayout.GetCurrShell()->ActionPend()' failed.
        	#4  0x00007f98e9f8c198 in UnHide(SwRootFrame&) (rLayout=...) at sw/source/core/layout/wsfrm.cxx:4551
        	#5  0x00007f98e9f8c839 in SwRootFrame::SetHideRedlines(bool) (this=0x7f98c40f7bd0, bHideRedlines=false) at sw/source/core/layout/wsfrm.cxx:4664
        	#6  0x00007f98e9b18afd in sw::DocumentRedlineManager::SetRedlineFlags(RedlineFlags) (this=0x80a4120, eMode=49) at sw/source/core/doc/DocumentRedlineManager.cxx:1097
        	#7  0x00007f98e9cfa503 in SwEditShell::SetAttrSet(SfxItemSet const&, SetAttrMode, SwPaM*, bool) (this=0x8885840, rSet=
        	    SfxItemSet of pool 0x808fd10 with parent 0x0 and Which ranges: [(63, 64), (120, 120)] = {...}, nFlags=SetAttrMode::DEFAULT, pPaM=0x0, bParagraphSetting=true)
        	    at sw/source/core/edit/edatmisc.cxx:187
        	#8  0x00007f98ea995f07 in SwTextShell::ExecParaAttr(SfxRequest&) (this=0x8bd0820, rReq=...) at sw/source/uibase/shells/txtattr.cxx:451
        
        Fix it the same way commit dd489bc01adc22fc5015ea56b61d66104af184a8
        (tdf#125754 sw_redlinehide: avoid recursive layout in SetHideRedlines(),
        2019-06-19) did: make sure that SetHideRedlines() is called before
        EndAllAction().
        
        Change-Id: I6304abec2e2e2967a8369b0219492bebcd606d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120069
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [69624a9dc7c5211a747ede3688004ad330498960]

        remove pimpl in ucb::ucp::ext::DataSupplier
        
        Change-Id: I441ae86314b0b69e8c116baf861e3801f55f4b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120021
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [991c871ddd25915fd385254405c7ec70757c5102]

        Remove commented out code
        
        Change-Id: Idcf0794c8ee7118c6804945753f1f1b33152657c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120064
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [890086d292798c20134e6ce78e913ced6b25a913]

        remove pimpl in package_ucp::package_ucp
        
        Change-Id: I066ecaffa32aa010effd6f9a27b7cd98cc098c2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [4e7212c4a341eef0521c4c6300c65bf42d756fd1]

        Resolves: tdf#143720 treeview not resizing to fill available space
        
        Change-Id: I041c3a743b8624f49bfe57e8a4469535e334e5dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [28ddcd59fab3c4994a5e4e94f05e21ad94664a76]

        move RequestHelp into layout.cxx
        
        Change-Id: I6b0642a77ffd247f9a77d5a4bdd0b593025a7797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120066
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [423c177d58e04af027379159b856c9b817d56488]

        drop unneeded forward declare
        
        Change-Id: Ifc7eab2bed8bfa55bf7d4dc6d56dac8ccfdf5642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [94b45e3b74e889a65fc619d1132cfa6e4af44ba7]

        Format ShapeInteractionHelper::PopulateShapeInteractionInfo
        
        It has weird intentation, 2/3 spaces instead of 4.
        Apply clang-format just to this method.
        
        Change-Id: If976ef9701e17448c7f527e1792a85dcaad8fa07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120063
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3d75afe9cc89d4c00d224f08331ceaea21214e95]

        Use SdrObject::set/getHyperlink
        
        Change-Id: I00e6962450689b2c0d215e52beb4e9d1524179d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120062
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3169a559505f911fb30580ed34ddfe0a36f2a17]

        more TSAN suppressions
        
        Change-Id: Ia6233812551211f837384751b043e3823cd29843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [c376b2428718a48ce4283fe002c0d493bfe1232e]

        fix --enable-online-update after
        
            commit 14cfff500e93f0d6cbf8412065feea85c01ea81d
            Pass context and resource string down to boost::locale separately
        
        Change-Id: I10336d0081c03090d63f48636ee8283b327304aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120058
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a5ba0a0096334b5097fd6aeec54c18c876e94d4]

        tsan:data-race in ScTable::bStreamValid
        
        which is touched from multiple threads when doing formula groups.
        
        WARNING: ThreadSanitizer: data race (pid=837458)
          Write of size 2 at 0x7b5800031aa8 by thread T17:
        /media/disk2/libo-san/sc/source/core/data/table1.cxx:379:22
        (libsclo.so+0x5b4f5d)
        /media/disk2/libo-san/sc/source/core/data/document.cxx:927:23
        (libsclo.so+0x443220)
        ScFormulaCell::ScInterpretTailParameter)
        /media/disk2/libo-san/sc/source/core/data/formulacell.cxx:2266:23 (l
        ibsclo.so+0x550fc4)
        long, unsigned long, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/colum
        n2.cxx:2998:15 (libsclo.so+0x375bb3)
        short, int, int, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/table1.cx
        x:2555:24 (libsclo.so+0x5c095b)
        ScRange const&, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/documen8.cxx:4
        21:11 (libsclo.so+0x436cef)
        ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&,
        bool&, bool&, int, int)::Executor::doWork()
        /media/disk2/libo-san/sc/source/core/da
        ta/formulacell.cxx:4875:29 (libsclo.so+0x55e869)
        /media/disk2/libo-san/comphelper/source/misc/threadpool.cxx:314:9
        (libcomphelper.so+0x1480ff)
        /media/disk2/libo-san/comphelper/source/misc/threadpool.cxx:83:24
        (libcomphelper.so+0x1480ff)
        /media/disk2/libo-san/salhelper/source/thread.cxx:40:9
        (libuno_salhelpergcc3.so.3+0x5350)
        /media/disk2/libo-san/salhelper/source/thread.cxx
        (libuno_salhelpergcc3.so.3+0x53b9)
        (libuno_salhelpergcc3.so.3+0x565e)
        /media/disk2/libo-san/sal/osl/unx/thread.cxx:264:9
        (libuno_sal.so.3+0x68325)
        
          Previous read of size 2 at 0x7b5800031aa8 by thread T18:
        /media/disk2/libo-san/sc/inc/table.hxx:315:71 (libsclo.so+0x443175)
        /media/disk2/libo-san/sc/source/core/data/document.cxx:919:30
        (libsclo.so+0x443175)
        ScFormulaCell::ScInterpretTailParameter)
        /media/disk2/libo-san/sc/source/core/data/formulacell.cxx:2182:48 (l
        ibsclo.so+0x550c03)
        long, unsigned long, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/colum
        n2.cxx:2998:15 (libsclo.so+0x375bb3)
        short, int, int, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/table1.cx
        x:2555:24 (libsclo.so+0x5c095b)
        ScRange const&, unsigned int, unsigned int)
        /media/disk2/libo-san/sc/source/core/data/documen8.cxx:4
        21:11 (libsclo.so+0x436cef)
        ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&,
        bool&, bool&, int, int)::Executor::doWork()
        /media/disk2/libo-san/sc/source/core/da
        ta/formulacell.cxx:4875:29 (libsclo.so+0x55e869)
        /media/disk2/libo-san/comphelper/source/misc/threadpool.cxx:314:9
        (libcomphelper.so+0x1480ff)
        
        Change-Id: Iae65982248a468e25eab8c8ecefb551a87d202d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [377a318dcfe4021eadde0e8cd922a4e42040b355]

        drop unneeded forward declare
        
        Change-Id: I858d4a43690bd37385eb6f48945c05dd9c2a6182
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120031
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [1a5bee9d18c9d7a8db0f9f011a0d2224d687e327]

        vcl::KeyCode::GetName doesn't need a specific vcl::Window
        
        any will do
        
        Change-Id: Ice1875d9b9e1cd46ecbc6e306c77768dc0b07dbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120029
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [7a8d7c9bd97dd52bde2182e395167f2e3cc9fda6]

        merge accel.h and accel.hxx now both are vcl internals
        
        Change-Id: If73604d1e329f089a357021bdce2163f6f059160
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120014
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [fbbe7c9e3ef9e09d4ddf9f0d1f54843294643620]

        vcl/accel.hxx is not used outside vcl
        
        Change-Id: I6b3debabe2c927f5ce3962fe97d944c07153028b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120013
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [fe0c93b7526ba6bab98d3f12f16c0b863a82fa9c]

        No need for extra uno commands for shape hyperlinks
        
        Change-Id: Ibf5987f543d4e1a767a7a5ae6a855f7eb883bfae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120056
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-05  Stephan Bergmann  <sbergman@redhat.com>  [0dab89d88f6b42065033f64b69a6e04a31d477d6]

        Remove harmful static_cast<int>
        
        ...that were present ever since the code's introduction in
        c6df405c6c5e41212d69282d4f632893f108fda2 "#i39532#", but cause
        `instdir/program/soffice --headless --convert-to pdf` of doc/abi5309-1.doc from
        the crash-testing corpus to fail under UBSan with
        
        > drawinglayer/source/processor2d/vclhelperbufferdevice.cxx:278:64: runtime error: -3.77964e+18 is outside the range of representable values of type 'int'
        
        Change-Id: Ieff00d6fe91e2ffef46876ef308351d3689c5ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120055
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-05  Stephan Bergmann  <sbergman@redhat.com>  [2030e380cfcade7ca8c18da67d9703b78959be0a]

        Avoid ODR violation, consistently define ZLIB_CONST
        
        At least my --enable-lto --enable-mergelibs build diagnosed
        
        > [build LNK] Library/libmergedlo.so
        > workdir/UnpackedTarball/zlib/zlib.h:86:16: warning: type ‘struct z_stream_s’ violates the C++ One Definition Rule [-Wodr]
        >    86 | typedef struct z_stream_s {
        >       |                ^
        > workdir/UnpackedTarball/zlib/zlib.h:86: note: a different type is defined in another translation unit
        >    86 | typedef struct z_stream_s {
        >       |
        > workdir/UnpackedTarball/zlib/zlib.h:87:20: note: the first difference of corresponding definitions is field ‘next_in’
        >    87 |     z_const Bytef *next_in;     /* next input byte */
        >       |                    ^
        > workdir/UnpackedTarball/zlib/zlib.h:87: note: a field of same name but different type is defined in another translation unit
        >    87 |     z_const Bytef *next_in;     /* next input byte */
        >       |
        
        (And ZLIB_CONST then required a small adaption in
        tools/source/zcodec/zcodec.cxx, plus some loplugin:redundantcast.  And
        gb_PrecompiledHeader_ignore_flags_system had to be updated to avoid errors like
        
        > Error reusing pch/inc/pch/precompiled_system by Library_wpftdraw.
        >  precompiled header flags : -DBOOST_ALL_NO_LIB -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_MEM_FN_ENABLE_CDECL -DBOOST_OPTIONAL_USE_OLD_DEFINITION_OF_NONE -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=msci -DDBG_UTIL -DEXCEPTIONS_ON -DINTEL -DNOMINMAX -DOSL_DEBUG_LEVEL=1 -DPCH_LEVEL=4 -DSAL_LOG_INFO -DSAL_LOG_WARN -DWIN32 -DWNT -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NON_CONFORMING_SWPRINTFS -D_CRT_SECURE_NO_DEPRECATE -D_DEBUG -D_DLL -D_HAS_AUTO_PTR_ETC -D_MT -D_REENTRANT -D_SCL_SECURE_NO_WARNINGS -D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING -D_SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING -D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING -D_WIN32_WINNT=0x0601 -D_X86_=1 -EHs -GR -GS -Gd -Gs -Gy -MDd -Od -W4 -Wv:18 -Zc:__cplusplus -Zm500 -bigobj -nologo -permissive- -std:c++17 -utf-8 -wd4127 -wd4201 -wd4244 -wd4250 -wd4251 -wd4267 -wd4275 -wd4505 -wd4611 -wd4706
        >             object flags  : -DBOOST_ALL_NO_LIB -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_MEM_FN_ENABLE_CDECL -DBOOST_OPTIONAL_USE_OLD_DEFINITION_OF_NONE -DBOOST_SYSTEM_NO_DEPRECATED -DCPPU_ENV=msci -DDBG_UTIL -DEXCEPTIONS_ON -DINTEL -DNOMINMAX -DOSL_DEBUG_LEVEL=1 -DPCH_LEVEL=4 -DSAL_LOG_INFO -DSAL_LOG_WARN -DWIN32 -DWNT -DZLIB_CONST -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NON_CONFORMING_SWPRINTFS -D_CRT_SECURE_NO_DEPRECATE -D_DEBUG -D_DLL -D_HAS_AUTO_PTR_ETC -D_MT -D_REENTRANT -D_SCL_SECURE_NO_WARNINGS -D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING -D_SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING -D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING -D_WIN32_WINNT=0x0601 -D_X86_=1 -EHs -GR -GS -Gd -Gs -Gy -MDd -Od -W4 -Wv:18 -Zc:__cplusplus -Zm500 -bigobj -nologo -permissive- -std:c++17 -utf-8 -wd4127 -wd4201 -wd4244 -wd4250 -wd4251 -wd4267 -wd4275 -wd4505 -wd4611 -wd4706
        >  reason :    -DZLIB_CONST -DZLIB_CONST
        > Incorrect precompiled header setup or internal gbuild error.
        > make[1]: *** [C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/writerperfect/Library_wpftdraw.mk:31: C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/workdir/PrecompiledHeader/nodebug/Timestamps/Library_wpftdraw_reuse] Error 1
        
        with --enable-pch.)
        
        Change-Id: Iadd3c90a65993ebef98190458762b1c86d425c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119961
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-05  Caolán McNamara  <caolanm@redhat.com>  [3609814db3542a281358fab5c57d27681a2974b8]

        remove outdated comments
        
        Change-Id: I4038327d0af5ad03b72b3053e9c2b3955b5d42e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120030
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [14cfff500e93f0d6cbf8412065feea85c01ea81d]

        Pass context and resource string down to boost::locale separately
        
        because this is often on a hot path, and we can avoid the splitting and
        joining of strings like this.
        
        Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Noel Grandin  <noelgrandin@gmail.com>  [d924ce30e0ca260682bd2aed192b8b1b2ca3e7c0]

        osl::Mutex->std::mutex in UcbContentProviderProxy
        
        in a couple of spots I dropped the lock guard because
        it was only calling a method that already takes the lock.
        
        Change-Id: I7ac57008f92e8aeff60407b064901d0e439e2fdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120015
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-05  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e12d4c7e361f449fcf143a61caed92129aca3468]

        tdf#123643 Import/Export for hyperlinks on text boxes
        
        Change-Id: Ied436c4a619985f27e5854369d319d76c05890d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120028
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-05  Miklos Vajna  <vmiklos@collabora.com>  [13377fd2e1d6e00597bb23a480ed9ad0aa9a563c]

        sw: use more StaticWhichCast() in source/core/docnode/
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: Id3ca7f0796a9afdccd7211a2ceec19e476647612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120010
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [41f1d389d4b513a7f616542d00fd58268ab5ea07]

        GenerateAutoMnemonicsOnHierarchy is no longer used outside vcl
        
        This effectively reverts commit 76be678e7478e4863a8360e26425a39afa5af4fb.
        "rename ImplWindowAutoMnemonic and expose"
        
        Change-Id: Ibeeeda68d96286e74113a7567ef12dae3a80cf48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120012
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [83b729f7ab05c55865ba2dc05af8dedff50ed3de]

        ToggleMnemonicsOnHierarchy can be a private symbol now
        
        Change-Id: I667454c62592f7a29d9175a50c7bde9e55895d2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120011
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  DaeHyun Sung  <sungdh86+git@gmail.com>  [402dab839b2e451dec81bfb83dadbe0d5a231db2]

        update list of [MS-LCID] from 6/25/2021 15.0 rev.
        
        update list of [MS-LCID] from 6/25/2021 15.0 revision
        
        see [MS-LCID]: Windows Language Code Identifier (LCID) Reference
        Link: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-lcid/70feba9f-294e-491e-b6eb-56532684c37f
        
        Change-Id: I8264a246d3a0f34a19f35684bdb987565f37e69d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119772
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [c74c5a79f138dfba6a63aa8bbecf6f9d01443cee]

        osl::Mutex->std::mutex in PropertyNamesCache
        
        Change-Id: I985f9174ea1c6b88e02298f030a81a021c0b1ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120008
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [cc4951d4042b7dd7635ec77c972350b59d609afc]

        AutoAccel is only true for gtk and there BackingWindow doesn't use vcl widgets
        
        so we can remove Accelerator::ToggleMnemonicsOnHierarchy here without
        any effect
        
        Change-Id: Ie7e8373c110216294dc4087d6ca1913bf8b25404
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Roman Kuznetsov  <antilibreoffice@gmail.com>  [af0437d7b1d9cc5a00b7d01a6510e5ba40ca1a12]

        tdf#143686 Increase a width of the label
        
        Change-Id: I71d7994ad7ed4506c1514cf417a535caff20b05f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119869
        Tested-by: Jenkins
        Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>

2021-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f343f09b4adaed1fe7286dfc8ba73bdb13eeabf]

        tsan:datarace in o3tl::ThreadSafeRefCountingPolicy
        
        Because we a non-atomic read of the reference count.
        
        Which we shouldn't be doing anyway, or the ref-counting is broken.
        
        WARNING: ThreadSanitizer: data race (pid=121172)
          Read of size 4 at 0x7b100027ba38 by thread T5:
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:54:17
        (libvcllo.so+0x7ee40d)
        o3tl::ThreadSafeRefCountingPolicy>::release()
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:208:29
        (libvcllo.so+0x7ee40d)
        o3tl::ThreadSafeRefCountingPolicy>::~cow_wrapper()
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:260:13
        (libvcllo.so+0x7ee40d)
        /media/disk2/libo-san/vcl/source/gdi/mapmod.cxx:97:19
        (libvcllo.so+0x7ee40d)
        /media/disk2/libo-san/vcl/source/bitmap/bitmap.cxx:166:1
        (libvcllo.so+0x92b175)
        /media/disk2/libo-san/vcl/source/bitmap/alpha.cxx:49:23
        (libvcllo.so+0x946475)
        GraphicFilterImportFlags, vcl::ScopedBitmapAccess<BitmapWriteAccess,
        Bitmap, &(Bitmap::AcquireWriteAccess())>*,
        vcl::ScopedBitmapAccess<BitmapWriteAccess, AlphaMask,
        &(AlphaMask::AcquireAlphaWriteAccess())>*)
        /media/disk2/libo-san/vcl/source/filter/png/PngImageReader.cxx:383:1
        (libvcllo.so+0xb67860)
        vcl::ScopedBitmapAccess<BitmapWriteAccess, Bitmap,
        &(Bitmap::AcquireWriteAccess())>*,
        vcl::ScopedBitmapAccess<BitmapWriteAccess, AlphaMask,
        &(AlphaMask::AcquireAlphaWriteAccess())>*)
        /media/disk2/libo-san/vcl/source/filter/png/PngImageReader.cxx:479:9
        (libvcllo.so+0xb69139)
        namespace)::GraphicImportContext&)
        /media/disk2/libo-san/vcl/source/filter/graphicfilter.cxx:586:14
        (libvcllo.so+0xac3a2f)
        /media/disk2/libo-san/vcl/source/filter/graphicfilter.cxx:574:5
        (libvcllo.so+0xac3a2f)
        /media/disk2/libo-san/comphelper/source/misc/threadpool.cxx:314:9
        (libcomphelper.so+0x1480ff)
        /media/disk2/libo-san/comphelper/source/misc/threadpool.cxx:83:24
        (libcomphelper.so+0x1480ff)
        /media/disk2/libo-san/salhelper/source/thread.cxx:40:9
        (libuno_salhelpergcc3.so.3+0x5350)
        /media/disk2/libo-san/salhelper/source/thread.cxx
        (libuno_salhelpergcc3.so.3+0x53b9)
        (libuno_salhelpergcc3.so.3+0x565e)
        /media/disk2/libo-san/sal/osl/unx/thread.cxx:264:9
        (libuno_sal.so.3+0x68325)
        
        Previous atomic write of size 4 at 0x7b100027ba38 by main thread
        (mutexes: write M7453640868405680):
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:57:24
        (libvcllo.so+0x7eebc9)
        o3tl::ThreadSafeRefCountingPolicy>::release()
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:208:29
        (libvcllo.so+0x7eebc9)
        o3tl::ThreadSafeRefCountingPolicy>::operator=(o3tl::cow_wrapper<MapMode::ImplMapMode,
        o3tl::ThreadSafeRefCountingPolicy> const&)
        /media/disk2/libo-san/include/o3tl/cow_wrapper.hxx:269:13
        (libvcllo.so+0x7eebc9)
        /media/disk2/libo-san/vcl/source/gdi/mapmod.cxx:124:45
        (libvcllo.so+0x7eebc9)
        
        Change-Id: I6334b748b91bf414168c05d90fc5bd6d7dfe3dda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [ee04805e513b0f804408697fc4b93e3c025d2329]

        Resolves: tdf#143023 explicitly connect to ControlBase focus-[in/out]
        
        instead of listening to the generic vcl::Window/Control focus events.
        The thing which really gets/loses focus is now a Widget hosted inside
        the ControlBase.
        
        Change-Id: I012d0bea687aa6d5965a4e2f6ce3899bfc629f1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120003
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fc0d2136aee6c1749d780de09df025251703b59e]

        tdf#142532 search string at any position not just start
        
        In the first implementation, we check if the search string is at
        the start of the command string. Mainly this is done to find the
        right command with a better accuracy. The problem with this is
        that it discards other hits where the search word occurs at an
        other position in the command text.
        
        This change adds the command where the search string doesn't occur
        at the start of the command string, but it adds those hits to the
        end of the list, so the best matches are still added at the
        beginning.
        
        Change-Id: I44a15400c84d45b0c8d3b65ec0e1ffee10686e72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119962
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b6f8991d88e75f11811de502b4285aa23cd0d4e]

        osl_createThreadKey->thread_local in IdContainer
        
        Change-Id: I5989610bd49597259d387b81dd7e8c63738255a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120000
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [f234fe77a0070927b8ae2ba3309f63aa718624f5]

        SdStyleSheet: implement XMultiPropertySet
        
        Reduces broadcast frequency
        
        Change-Id: I25f4281e792aa6bb42a11d3566e7d4e64e833f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119992
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [d406404c798c4686c8f765927a68bee3f445805d]

        Log unhandled exceptions
        
        Change-Id: I1674730620b9c130b5a640bc0e67b72394752a22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119980
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-04  Mike Kaganski  <mike.kaganski@collabora.com>  [96256693d647b17513e08929e612466c88afef53]

        Duplicating checks
        
        Change-Id: Ie4df9a0287876d12d320060468f635cea759d305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119978
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [f5ed9f47b6443dbf365a07b9c2adc4caadb80e26]

        EventWindow is always a svt::ControlBase
        
        Change-Id: I85220b91f23154c6480e7007eb24986c972ad8cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f4da631ce0d27fdff0b034a79ee2fd35c9d6a18c]

        Update git submodules
        
        * Update translations from branch 'master'
          to 879d0acff38f25a4219a9da35bda3ead3f8b4b63
          - update translations for 7.2/master
            
            and force-fix errors using pocheck
            
2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [5a925ea8bb0cb305ac05a4f39113465295d1c600]

        establish that DbCellControl Window member is always a ControlBase
        
        and remove resulting known redundant dynamic_casting
        
        Change-Id: I5f098ef1adee3ad5d2a2bc5fcd30523f980df2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119999
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [0330b1a591be25b857af65606f9b2db328e93580]

        fix comment
        
        Change-Id: Ia1783aff3fded7fd73de2b04b9aced647771a92c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Miklos Vajna  <vmiklos@collabora.com>  [aff28c59816d046d9b74460c1b17101b99b9514e]

        sw lok: avoid expensive DLPre/PostPaint2() around InvalidateWindows()
        
        This shows up on profiles and it's not needed. It was only there,
        because Online always needs an invalidation to have updated tiles, so
        there the paint was replaced with an invalidate. And then the
        drawinglayer setup/teardown was not made conditional by accident.
        
        The PaintTile() case goes via Paint() -> PaintSwFrame(), which still
        calls these functions; this commit only speeds up
        SwViewShell::ImplEndAction(), which is called synchronously e.g. on
        every keypress.
        
        Change-Id: I6c362f148bc2837bd842602754770c5267e16afd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119997
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-04  Regina Henschel  <rb.henschel@t-online.de>  [4fb5817ecb614bd0c83afb3627d7caadbfe8c082]

        tdf#143476 improve import of lockedCanvas
        
        A lockedCanvas is used in Word 2007 to include dml-shapes. It is
        treated similar to a group, only that its content is not editable.
        
        This patch changes the implementation so, that the lockedCanvas is
        imported as group. Prior only content was imported in the case the
        content was a single custom-shape or a single group.
        That has resulted in these errors:
        Image or line in a lockedCanvas were not imported at all.
        Only one of several shapes in a lockedCanvas was imported.
        
        I have changed mpShape to mpShapePtr to reflect the data type and be
        consistent with ShapeContext.
        
        The patch changes GraphicImport so, that lockedCanvas as special
        version of a group is detected and handled. That solves regression
        from commit 3262fc5ef3bde5b158909d11ccb008161ea95519
        
        Change-Id: I57005e64ff073bca6ebb46a404486203fb6802ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119684
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [71b3d7392bd3d0871c7383748d49ae5d46c80e51]

        osl::Mutex->std::mutex in VCLXPointer
        
        Change-Id: If96f20d8ce8c893ece59e9278aa79dd1a8f8223f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119953
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Caolán McNamara  <caolanm@redhat.com>  [36efb384a66b6dd645e0ae80fd7df68370a9dc8b]

        tdf#143499 don't search entire tree looking for insertion point
        
        keep a short insertion candidate vector up to date as the tree is
        populated
        
        for gen takes time from ~310ms to ~45ms
        
        Change-Id: I70e6c0243771cef39e54f4d039069cf54aa6d41c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119956
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-04  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [da36d655608c3da39fd79d95974e1f7404a27aa0]

        Always provision PATH the cygwin way under Windows
        
        With PATH essentially serving the role of LD_LIBRARY_PATH under
        Windows, there was the notion that this needs to be provided in
        Windows notation, for win32 gnumake.
        
        That was perhaps once true; currently we're always evaluating PATH
        inside a shell, not the Makefile. So this since a while only worked
        accidentally, due to cygwin transparently converting between DOS and
        UNIX PATH vars. It did break though for corner-cases, e.g.
        SRCDIR!=BUILDDIR, and BUILDDIR e.g. D:\FOO.
        
        With that simplification, also GNUMAKE_WIN_NATIVE can go.
        
        Change-Id: Ied5a0443dc70e7dc629c0c0620e6ce911d9a73d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119941
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [330ba10a212f007babb2f3d27de88197936291dd]

        osl::Mutex->std::mutex in VCLXRegion
        
        Change-Id: I8110539975721f515707f42f29dda94346805f93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119952
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [48c5ba19e4f4a1ad5a88b5e6f0816c080e1253ec]

        Fix alternate JREs missing bin/ directory on java.library.path
        
        Exception looks like this:
        
        java stack trace:
        java.lang.UnsatisfiedLinkError: zulu11\bin\fontmanager.dll: Can't find depende
        nt libraries
                at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native Method)
                at java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442)
                at java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498)
                at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694)
                at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2648)
                at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830)
                at java.base/java.lang.System.loadLibrary(System.java:1873)
                at java.desktop/sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:57)
                at java.base/java.security.AccessController.doPrivileged(Native Method)
                at java.desktop/sun.font.FontManagerNativeLibrary.<clinit>(FontManagerNativeLibrary.java:32)
                at java.desktop/sun.font.SunFontManager$1.run(SunFontManager.java:279)
                at java.base/java.security.AccessController.doPrivileged(Native Method)
                at java.desktop/sun.font.SunFontManager.<clinit>(SunFontManager.java:275)
                at java.base/java.lang.Class.forName0(Native Method)
                at java.base/java.lang.Class.forName(Class.java:398)
                at java.desktop/sun.font.FontManagerFactory$1.run(FontManagerFactory.java:82)
                at java.base/java.security.AccessController.doPrivileged(Native Method)
                at java.desktop/sun.font.FontManagerFactory.getInstance(FontManagerFactory.java:74)
                at java.desktop/sun.java2d.SunGraphicsEnvironment.getFontManagerForSGE(SunGraphicsEnvironment.ja
        va:189)
                at java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron
        ment.java:223)
                at java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron
        ment.java:251)
        
        Change-Id: I7a16bb5813d4c089ddb4de34a250280cf6fee137
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119880
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [ee6835950908708872cdf47a33656ea40e3532ad]

        inline some typedefs
        
        Change-Id: I83cc2baf7df3f30b73b70caf1c6d0c0e79417fc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119949
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Miklos Vajna  <vmiklos@collabora.com>  [50b8c9d81efb9e2fedbf54c340aae1f39d503738]

        CppunitTest_sw_ooxmlexport: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ic3e15bff48d56349cead8391d32db92418c305a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119942
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [854ba4bf47f713f5c82525a9000439c5c44e66b2]

        getReference is unnecessary
        
        Change-Id: I156c2e6dc714468f6af42f5c0f7cae923aec175c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119948
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [f7ee6baa1b14410fa79aac5dd9d6877df44a823a]

        osl::Mutex->std::mutex in MutableTreeNode
        
        Change-Id: Iee3a1cfb70b99132810324177ab8e77b478e0c50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [e643f8703b85668a396676e99ec7e9ee2133368c]

        osl::Mutex->std::mutex in VCLXBitmap
        
        Change-Id: I436f9079468a365622a91d015fddbe5f8fa923d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [e8d4f0df075a7033dffa9f6a255d99cf595d1ad3]

        osl::Mutex->std::mutex in SimpleNamedThingContainer
        
        Change-Id: I051cd746cc44cc0929ccd0d43934ae3f16bdafc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119951
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Noel Grandin  <noelgrandin@gmail.com>  [1082943bd8ab8174f0256f41b0d417950060e240]

        osl::Mutex->std::mutex in getDefaultFormats
        
        Change-Id: I884416cae7d968f1869fb949eb81ab378573a4dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119950
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-04  Stephan Bergmann  <sbergman@redhat.com>  [fba874c162bcb78f2979f4da57ccd4c384c71d72]

        Fix ambiguous calls in C++20
        
        ...which added a
        
        > template<class It, class End>
        >   constexpr basic_string_view(It begin, End end);
        
        ctor, causing
        
        > vcl/source/window/builder.cxx:2966:35: error: call to 'get' is ambiguous
        >                     sFinalValue = Translate::get({sContext.getStr(), sValue.getStr()}, m_pParserState->m_aResLocale);
        >                                   ^~~~~~~~~~~~~~
        > include/unotools/resmgr.hxx:67:33: note: candidate function
        >     UNOTOOLS_DLLPUBLIC OUString get(std::string_view aId, const std::locale &loc);
        >                                 ^
        > include/unotools/resmgr.hxx:69:33: note: candidate function
        >     UNOTOOLS_DLLPUBLIC OUString get(TranslateId sContextAndId, const std::locale &loc);
        >                                 ^
        
        etc.
        
        Change-Id: I638be4a3d310179ee73866c4a70b20c49925ede6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119957
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-04  Stephan Bergmann  <sbergman@redhat.com>  [4115ad1035cb13e06ed00791415a4258767b8808]

        Remove harmful static_cast<int>
        
        ...that were present ever since the code's introduction in
        1ced26e19d769e2ac6ca83f57f82cddbd2cfd061 "INTEGRATION: CWS vcl15", but cause
        `instdir/program/soffice --headless --convert-to pdf` of doc/abi11923-2.doc from
        the crash-testing corpus to fail under UBSan with
        
        > vcl/source/pdf/Matrix3.cxx:30:35: runtime error: 2.14749e+09 is outside the range of representable values of type 'int'
        >  #0 in vcl::pdf::Matrix3::transform(Point const&) const at vcl/source/pdf/Matrix3.cxx:30:35 (instdir/program/libvcllo.so +0x94098c5)
        [...]
        
        Change-Id: I3855027effa09c592345a9c85a9d5dee38d7c992
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119955
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-04  Justin Luth  <justin_luth@sil.org>  [d03aaef3dcb5d142955457ae9b8ca4469cfafa38]

        Revert "tdf#104254 sw DOCX import: fix text wrapping in headers"
        
        This reverts commit 798b69087119c01a3b51e0bb3240ef35cfededeb.
        The change affected not only DOCX compatibilityMode 15,
        but also DOC and ODT and older versions of DOC
        and everything else which should not have been affected.
        
        This reverted change of course affected layout.
        Some bug documents didn't loop after this layout breakage.
        That doesn't mean that those bugs were fixed.
        So just revert the tests:
        
        Revert "tdf#96840: sw_ww8export3: Add unittest"
        This reverts commit 975488594fc88aaba7298448e0ff727ebca7fe85.
        
        Revert "tdf#64997: sw_ww8export3: Add unittest"
        This reverts commit 02af9b8ef1f87bb6bc5fee22ad184681b20f201a.
        
        Change-Id: I54f7b801199bba45d8ca6f82f77e7060c7b3fcf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119887
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fc0a31f30154c7c5aabb9f0367a10ee14c82821a]

        tdf#143388 rebind command search from CTRL+F1 to SHIFT+ESC
        
        CTRL+F1 is reserved by the OS.
        
        Change-Id: I7b5804fc3c65edc8279559635f33ff932bf6ae45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119960
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [e58348e73b5f3f6eb8fd68eb50c1bc4b58f32104]

         Add Handler for Pop Write
        
        The handler separates MetaPopAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ifd6768f74b503bfd2831b6b595e442727cfa2eac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119925
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [ca6e32efb563490a2c18599ee483c796fc5b159a]

         Add Handler for Push Write
        
        The handler separates MetaPushAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I60d3b618ccb14e82b195c84271921189fe41b904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119924
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [e31b6f6aced8588cefe5d72292403a87c6dd2a73]

        Add Handler for Font Write
        
        The handler separates MetaFontAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ib80f60afc355fd38729eb2505069851d26328101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119923
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [c7dbab2d5e254bc38204b62a15d129be66417799]

        Add Handler for MapMode Write
        
        The handler separates MetaMapModeAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ic0a2691eabb96a88ceafbe63af08566a38c6e469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119922
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [e76a3e759454f1e2d1987fe983cd7286b9156be0]

        Add Handler for TextAlign Write
        
        The handler separates MetaTextAlignAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I464389a0c1e4e5867759174e8580be9e0c239408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119921
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  panoskorovesis  <panoskorovesis@outlook.com>  [afef5aece1424be8b3e186ae28fb2c26ffcad0ea]

        Add Handler for OverlineColor Write
        
        The handler separates MetaOverlineColorAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I928af66b250d5f898303fad46c6a7a7339ec0e69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119920
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [4d5c96be4362902144c83708f40f77766244ca06]

        tdf#123919 - Sort custom document properties
        
        Sort custom document properties on opening the dialog under File >
        Properties > Custom Properties. The sorting order in the document's xml
        still depends on the generated handle of the document property itself.
        
        Change-Id: I12c4f641d22ca0a3db2f4c6ef54f41c113aeeaa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115780
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [24d24debef4cda7de702c4b470a3707f1aae3ea3]

        tdf#143582 - Clear return value of the method before calling it
        
        Otherwise the function keeps a copy of its return value, which may be
        used in an upcoming call.
        
        Change-Id: I4977c39e1ce48cfd5ab067a4df4783f10505a9ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119905
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [58f0eb6ddba26705535d07b07a17f5cf141cf3da]

        Related: tdf#143499 lookup id just once
        
        instead of twice
        
        for gen takes time from ~400ms to ~310ms
        
        Change-Id: Ic5e11e889c10fa90b23165aabdca751436ecf55c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [fcc0e6983f2e736022ecf22726cc34e50bd53f24]

        Resolves: tdf#137637 keep user selection during initialization
        
        Change-Id: Ibef83d132ce951393a996aae94b8cdee51da1a64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119940
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-03  Michael Meeks  <michael.meeks@collabora.com>  [ab281c561f7fa7a3512875a22423693dca84316a]

        vcl: avoid native widget pieces for disposed BorderWindow.
        
        Fixes crash around help windows:
        	vcl::Window::IsCompoundControl() const
        		vcl/source/window/window2.cxx:1200
        	vcl::Window::Show(bool, ShowFlags)
        		vcl/source/window/window.cxx:2243 (discriminator 3)
        	vcl::Window::Show(bool, ShowFlags)
        		vcl/source/window/window.cxx:2298
        	HelpTextWindow::ImplShow()
        		vcl/source/app/help.cxx:371
        	Scheduler::ProcessTaskScheduling()
        		vcl/source/app/scheduler.cxx:495
        
        Change-Id: Ia0205813f3e9d306314577d59d6cdd1bdfa0ee71
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119854
        Tested-by: Jenkins

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [5b98dd53c7dc101d3a5ff693d3f0520ec1abd3d1]

        tdf#143657 'execute' button doesn't get enabled when contents changed
        
        since...
        
        commit 73c9ef661d9ef6237d3fd3c259fd040a545b44cf
        Date:   Tue Jul 6 18:51:38 2021 +0200
        
            tdf#132740 don't broadcast if modified status has not changed
        
        now we only get a notification on transition from unmodified to
        modified. So continue to launch a timer on transition but clear
        modification on firing so we will get notified on the next change
        and move the modify callback to the timer.
        
        modifications are now deferred until the timer fires, so reduce
        the timer to make it smoother
        
        Change-Id: I27980be54de20bb516b1f106c3ed1b303e2a4014
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119933
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-03  Miklos Vajna  <vmiklos@collabora.com>  [c88ff9298b25132fc34102230cef0263f045a523]

        tdf#142436 svx: fix handling of linked background images
        
        Regression from commit 9fb7aaf570c03c8a26d763f1205fb8c890e8211a (Make
        linked graphic register into LinkedManager again, 2018-04-13), the
        problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic
        that has its type set to GraphicType::Default, but when
        drawinglayer::primitive2d::createNewSdrFillGraphicAttribute() consumes
        this graphic, it expects that the type is either a bitmap or a metafile.
        
        Fix the problem by explicitly loading the image when the default-type,
        origin-url-set case happens: this is rendering, so no problem to load
        the URL and that will give us the expected graphic type.
        
        This is also meant to keep the original problem fixed, since the Graphic
        that is part of the doc model is unchanged.
        
        Change-Id: If5bba09faa23ef35f99152d4b5d30cd9cf67ace8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119935
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [e6671ea1ceb9e6925ef396156c922a62ded19461]

        fix enable-gtk3-kde5 build
        
        Change-Id: I020e6e74f800e58bee71674d2219a89c40a70eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119930
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [742b5f0e75cb00f9e14b11343a9c29f241179ca9]

        Fix typo in code
        
        Change-Id: I0ceb5910fec2dfd4ef5d360b47ae4e147eabec35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119931
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-08-03  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3e21ee215d0cda14725133e7c33b974b2290f2d3]

        Fix typos
        
        Change-Id: Ie4809d5367d15dc155033db034d86aaa75cb5abe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119932
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [dd44857ab403f3ee3f4271a1d22906d04a05ea7c]

        tdf#143626 "protect" always shown checked for sections linked to file
        
        Change-Id: I8a403a25ae5c5e3b6183ba559b0224f2886eb925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119928
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [86143150ac287d497d7b887435de580cfb8486b9]

        osl::Mutex->std::mutex in TemplateFolderCacheImpl
        
        Change-Id: Iaec29ac3706cac485032840776ba3a63b3727905
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119896
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [5891746d5cf459ea87ad79ea231f2aedaafb7b39]

        osl::Mutex->std::mutex in UriReference
        
        Change-Id: Ic5fb97774821be582af62e74bd2e00fca503b8f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119889
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [a172ad38f39acfef38f8f84398ec231c2f498e64]

        simplify lookup maps in EnhancedCustomShapeTypeNames
        
        simplify initialisation, and use OUString as the key to avoid
        conversions during lookup
        
        Change-Id: I0b1f1f461a4d2375cd92d13bb3333c8e0b887ee7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119897
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Caolán McNamara  <caolanm@redhat.com>  [16b98ec93e2c04f511ea7fb25777331e48aa580c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6ca79c5a1a97b43676bb8de4ac37389f69aec307
          - Resolves: tdf#143131 fix shortcut documentation
            
            Related to tdf#82969 add global shortcut for autospellcheck
            
            https://gerrit.libreoffice.org/c/core/+/13088/ changed the key combo
            from Shift+F7 to Shift+F9, update the help to match
            
            Change-Id: I3d4e0204dc59e44bc512a4459935f5e7f10982b7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119929
            Tested-by: Caolán McNamara <caolanm@redhat.com>
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2021-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [05ab38359ae72f2a54dc0b5f1b84ac5f649c507a]

        Consolidate on C++17 std::scoped_lock instead of std::lock_guard
        
        as in commit 9376f65a26240441bf9dd6ae1f69886dc9fa60fa
        
        Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [5afdcad4c0e7850b18996c549892b9360cd8973f]

        Pass context and resource string down to boost::locale separately
        
        because this is often on a hot path, and we can avoid the splitting and
        joining of strings like this.
        
        Change-Id: I2a24a123a64b762fd0741c45eaca3ad4bdd5580d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119884
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Stephan Bergmann  <sbergman@redhat.com>  [39d364958447cd33a6e30dc9d2904ad94fd40aba]

        Avoid unsigned integer subtraction causing wrap-around
        
        ...to a too-large positive value, causing `instdir/program/soffice --headless
        --convert-to epub` of cloudon/File_1149.docx from the crash-testing corpus to
        fail under UBSan with
        
        > writerfilter/source/dmapper/GraphicImport.cxx:562:27: runtime error: 7.73093e+11 is outside the range of representable values of type 'int'
        >  #0 in writerfilter::dmapper::GraphicImport::lcl_correctWord2007EffectExtent(int) at writerfilter/source/dmapper/GraphicImport.cxx:562:27
        [...]
        
        (where sal_uInt32 m_pImpl->getXSize() was 3731 and sal_uInt32
        m_pImpl->getYSize() was 10583)
        
        Change-Id: Id0ae9d6e46c977753d11cc2496ba5d240d3102bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [9c7e8b416d5555718f9d12fb89668a1fe7234c01]

        osl::Mutex->std::mutex in SwAccessibleContext
        
        Change-Id: Ieba232c5b4a337c126a760760c9eaa153a9c8607
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119914
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [d596bedd1c4aa27549fe9dda5112c67bdfc8c7fb]

        tools::Long->sal_Int16 in FmXFormShell
        
        m_arrRelativeGridColumn is set from FmFoundRecordInformation.nFieldPos
        which is sal_Int16
        
        Change-Id: Ifd3d72f8aa34d0d574d1b9fc2cbe755c32952b4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119911
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [dbca83e5b90a25be0841a1f4b4ff45b4e5f818cc]

        osl::Mutex->std::mutex in CancelJobsThread
        
        Change-Id: If986577e4aff53080300c13c8586702f24699eb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119915
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [db9d23d71978e32213234a9402798719f1872400]

        osl::Mutex->std::mutex in OutputStorageWrapper_Impl
        
        Change-Id: Idb5e46d91cd933e4dcc1b3cd751c65d9ddd9e077
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119913
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [567ceb70388296521095c63280c79a522e74fae2]

        osl::Mutex->std::mutex in createDefaultCross_3x3
        
        Change-Id: Icdb311f855ddd2fe2ca2f66f14df8934332e6ef3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119912
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Noel Grandin  <noelgrandin@gmail.com>  [883a208bf4a705fde50e51428a8c8e5685ab91d4]

        osl::Mutex->std::mutex in OParseContextClient
        
        and remove the atomic, we don't need an atomic if we are using
        a mutex
        
        Change-Id: I4d3107111b92ebdaa1fe0c1182cdc532f60bc51b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119910
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-03  Miklos Vajna  <vmiklos@collabora.com>  [c5c996578a62afda92fbf6211e9c9169167cc410]

        Fix 'make test-install' on Linux
        
        Regression from commit af70b5b8aa7b9dac3b64ef58968208475f673f5c (Allow
        --enable-macosx-sandbox without the codesigning identities, 2020-11-19),
        which started to assume that non-Windows means macOS for test-install
        purposes.
        
        Change-Id: If3c281b330363eb9c853ce6193e09698835ed765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119908
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [0c7cc718cd952e39957037e7fda3ac96e32b6d61]

        Add Handler for TextLine Write
        
        The handler separates MetaTextLineAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Iff1f22618d60f8f037a820ea2a03082b3a3bc926
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119903
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [4dad280b76853956d44d301c60c48f032fda0831]

        Add Handler for TextRect Write
        
        The handler separates MetaTextRectAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I4827df579bb866dcb3f40d22387a1c0a24fde210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119902
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [04073bc1b53a8e2b7376c1a40c02c60adc69fde0]

        Add Handler for StretchText Write
        
        The handler separates MetaStretchTextAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I1e5df474921796c064aa83406356b38bd2431451
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119901
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [46377cb8abcc20fd083c981b2e14ebc4ba78804a]

        Add Handler for TextArray Write
        
        The handler separates MetaTextArrayAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I5543957d01c5f2c7d2bf4a56a8a51f9d0330e07d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119900
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [e3e0efb732b1f17ca9db50809d39eecc68961e0b]

        Add Handler for Text Write
        
        The handler separates MetaTextAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ibc2b83802e74a2d7923ebfb45036751e9f012ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119899
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  panoskorovesis  <panoskorovesis@outlook.com>  [a3848e4e6b433e251c5e51f1e29d3c28d54a257c]

        Add Handler for PolyPolygon Write
        
        The handler separates MetaPolyPolygonAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I95b68a4ea561bf80fbe83363743ea91e3f973f7b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119898
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [cd3289e3878f35ba66e0f0b7d62e3cbcb6e53f4b]

        tdf#143696 rename Properties tree view column from Object to Name
        
        Change-Id: I600d0bf7c9dc2c6c934e1f6faaed00e296b1d042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119918
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-03  Rafael Lima  <rafael.palma.lima@gmail.com>  [ad1b12686da88bea57582df10fa85268ada209b8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0b7cde3aabef66890ebeb3ab8581d2104473214a
          - Create help page for the Development Tools feature
            
            Change-Id: Ib392399fa71c27ce6be7fca8c55985d75519ea87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119855
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-08-03  Eike Rathke  <erack@redhat.com>  [400a44f9ac7792ffe3665f70507324e4a64dca2b]

        Related: tdf#143664 Change {de-*} March "Mrz" to "Mär"
        
        Change-Id: Id4a4ebe432bf5badae96eadb723336648d2ce690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119917
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-03  Eike Rathke  <erack@redhat.com>  [4961dbaecc9e5cac57d99d2ea9d265a90daa4a8b]

        Resolves: tdf#143664 {de-*} accept "Mär" and "Mrz" for March
        
        Change-Id: I82c094687137995a634450cb4f617909859d1688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119916
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-02  Caolán McNamara  <caolanm@redhat.com>  [dcf61567600251aa239010ad287e1551a181431a]

        more ofz#36727
        
        Change-Id: Idaf189a6d78e06fb4c4615819b06ff1b3c8d57cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-02  Caolán McNamara  <caolanm@redhat.com>  [8753431292376540eeb25d3980960632dd5fd78b]

        ofz#36727 Abrt
        
        Change-Id: I3bc881846174f5a206c191cdeea8344809080e43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-02  Caolán McNamara  <caolanm@redhat.com>  [7f0e8d54c159290f0d62f269cc386480422e883f]

        ofz#32766 Abrt
        
        Change-Id: I333e1571c68e62b209dce008edc1ab4d40b01f8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-08-02  Noel Grandin  <noelgrandin@gmail.com>  [e01df5ad80cd8f34a781631da6f24f38bce613c4]

        osl::Mutex->std::mutex in SvtMatchContext_Impl
        
        Change-Id: Id9612600b3514df10cd5311cf60b6704596ed118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119895
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Tünde Tóth  <toth.tunde@nisz.hu>  [a07351e8181353c0c0b6df5d2ccbad4615c6706b]

        tdf#115520 sc UI: Define Database Range dialog disappeared
        
        if the name of the database range was invalid.
        
        Change-Id: If0eb08d35b2187f04ef93136acd6f7eafa3b588a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119652
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-08-02  Noel Grandin  <noelgrandin@gmail.com>  [c4ff09fc8c55af1f5fadb452eef16b15be8e202a]

        flatten SfxUndoManager_Data a little
        
        no need to allocate the SfxUndoArray separately
        
        Change-Id: I5866ee1382d0be22b71a7322fe4379d3e159f488
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119894
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ed2207983c6d96e8866bd81e53097cb798436e8]

        more suppressions for TSAN
        
        Change-Id: I96072bdacb805135f0c267a878181035c4b0d810
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Regina Henschel  <rb.henschel@t-online.de>  [0cff1aa48453ee0c05bafcac5360329fb6bf9557]

        tdf#143619 validation circle anchor is special
        
        For usual drawing objects, maStart in its Calc user data means the
        cell address of left/top of snapRect/logicRect. For validation circle
        it means 'address of cell to be validated'. Thus corrections might be
        needed, if a general method is used for validation circle.
        
        Here the method SetLogicRect() calls via broadcast
        ScDrawLayer::SetCellAnchoredFromPosition(), which calculates maStart
        from snapRect/logicRect. Because the circle is extended to cover a
        larger area than the to be validated cell, maStart got the cell address
        of the cell one left and one above of the to be validated cell.
        
        Now the old, correct address is backuped and restored.
        
        Change-Id: I9646da3f22fef45a6e47e59ef55a70307e2f9cc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119715
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-08-02  Stephan Bergmann  <sbergman@redhat.com>  [d5a100f59467d94945656b54563e5ecdde2ca724]

        tdf#143450: Special integre+fp struct return case needs a fix too, of course
        
        ...similar to ca344be7aabf88dddde38841e6af6292ece6829b "tdf#143450: Fix special
        fp+integer struct return case for gcc_*_x86-64"
        
        Change-Id: Ia8110d632a1c5f328822c434efc5b09bd53ec9e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119883
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-02  Justin Luth  <justin_luth@sil.org>  [a6555eb809e2580562cd431085e35a23b7d47f9a]

        tdf#65535 sw spell: ignore comment marker when checking spelling
        
        A comment in the middle of the word should not render it as
        a misspelling. So strip it out when checking - like hidden or redlines.
        
        One existing problem is that if the word is STILL misspelled,
        then replacing it will remove the in-word comment.
        That was true before this patch, so it is just another
        deirable enhancement to try to avoid that.
        
        Change-Id: Ic69385d5bbeca2d17b1969211c118d4d38e6a22f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118972
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-08-02  Stephan Bergmann  <sbergman@redhat.com>  [71d0c43fb4cf535239cb41baf7b6e03de765ce7a]

        initialization-order-fiasco
        
        ...after a943936eeff04b60ebd0b2552bc18b42606f3321 "rtl::Static -> static local"
        (and the relevant static isn't even local), when building e.g.
        Gallery/backgrounds, see <https://ci.libreoffice.org/job/lo_ubsan/2090/>:
        
        > ==26993==ERROR: AddressSanitizer: initialization-order-fiasco on address 0x2b52e50be408 at pc 0x2b52e4d32753 bp 0x7fff5670f090 sp 0x7fff5670f088
        > READ of size 8 at 0x2b52e50be408 thread T0
        >     #0 0x2b52e4d32752 in std::_Rb_tree<rtl::OUString, std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> >, std::_Select1st<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > >, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::_M_begin() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_tree.h:737:64
        >     #1 0x2b52e4d355f3 in std::_Rb_tree<rtl::OUString, std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> >, std::_Select1st<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > >, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_tree.h:2523:37
        >     #2 0x2b52e4d3507d in std::__cxx1998::map<rtl::OUString, std::shared_ptr<LanguageTagImpl>, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/stl_map.h:1164:21
        >     #3 0x2b52e4cf116c in std::__debug::map<rtl::OUString, std::shared_ptr<LanguageTagImpl>, (anonymous namespace)::compareIgnoreAsciiCaseLess, std::allocator<std::pair<rtl::OUString const, std::shared_ptr<LanguageTagImpl> > > >::find(rtl::OUString const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/debug/map.h:561:32
        >     #4 0x2b52e4d00dcd in LanguageTag::registerImpl() const /i18nlangtag/source/languagetag/languagetag.cxx:888:50
        >     #5 0x2b52e4cdf693 in LanguageTag::getImpl() /i18nlangtag/source/languagetag/languagetag.cxx:1004:18
        >     #6 0x2b52e4cdf3fd in LanguageTag::LanguageTag(rtl::OUString const&, bool) /i18nlangtag/source/languagetag/languagetag.cxx:489:9
        >     #7 0x2b52b9aed628 in __cxx_global_var_init.2 /sfx2/source/view/lokhelper.cxx:77:13
        >     #8 0x2b52b9aed75e in _GLOBAL__sub_I_lokhelper.cxx /sfx2/source/view/lokhelper.cxx
        >     #9 0x2b52b4f069c2 in _dl_init_internal (/lib64/ld-linux-x86-64.so.2+0xf9c2)
        >     #10 0x2b52b4ef8179  (/lib64/ld-linux-x86-64.so.2+0x1179)
        >
        > 0x2b52e50be408 is located 40 bytes inside of global variable '(anonymous namespace)::theMapBcp47' defined in '/home/tdf/lode/jenkins/workspace/lo_ubsan/i18nlangtag/source/languagetag/languagetag.cxx:93:10' (0x2b52e50be3e0) of size 72
        >   registered at:
        >     #0 0x43f4c8 in __asan_register_globals.part.13 /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_globals.cc:362
        >     #1 0x2b52e4d4031b in asan.module_ctor (/instdir/program/libi18nlangtag.so+0x16831b)
        > LLVMSymbolizer: error reading file: No such file or directory
        >     #2 0x7fff567143b7  ([stack]+0x203b7)
        
        This is a partial revert of a943936eeff04b60ebd0b2552bc18b42606f3321
        "rtl::Static -> static local".
        
        Change-Id: I5d6803d217d4e8927b5864b2392f3ddd18310a5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-02  Stephan Bergmann  <sbergman@redhat.com>  [0f3497ea6080df72d479a405886316da21e35885]

        Fix --enable-online-update build
        
        ...after 1597cc5b3e07dd24cb4cb10b35b1e93545e4b929 "convert #defines to
        OUStringLiteral" (partially reverting that commit),
        
        > extensions/source/update/check/updatecheckconfig.cxx:68:17: error: expected '}'
        >     RELEASE_NOTE"1",
        >                 ^
        > extensions/source/update/check/updatecheckconfig.cxx:62:47: note: to match this '{'
        > const char * const aUpdateEntryProperties[] = {
        >                                               ^
        
        etc.
        
        Change-Id: I3cebb3dbc74adaeeefc14c11986ee4c8817b31b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119886
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-02  Stephan Bergmann  <sbergman@redhat.com>  [d2aeb7b8f52ffb2c6699099880250960cc2a800c]

        Mark external/libodfgen/ellipticalarc.patch as reported upstream
        
        Change-Id: I76f8cab70d4c1a5b98bb5ba1608676d34570694b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119879
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [41ac0abb3b100a49490ee5df2f5a74a7a4606e56]

        Replace GDIMetaFile::Read with SvmReader::Read in svmtest.cxx
        
        Use the new read functionality in svmtest.cxx
        
        Change-Id: I86b81c56d754962e51da76690378b62e6c7e3498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119846
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [86fcdf240ccdbecd051498d0b1e76a698aab5e89]

        Add Handler for Polygon Write
        
        The handler separates MetaPolygonHandler::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Iffc665603db1bf1eea6b201e8975900a65f28a33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119738
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [940ef7d652f0916adf7c3499682e6f81b86404c8]

        Add Handler for PolyLine Write
        
        The handler separates MetaPolyLineAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I62a3d6d70b33966f0096260aa01f3790a3e87e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119737
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [cada12ebaf09ed764ca9762949cd05c42f162d23]

        Add Handler for Chord Write
        
        The handler separates MetaChordAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Ifea8783a4cf6494440b4905563165af62276b1f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119736
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [7f8f8163a2cc0ee0a0c08d3c915a8627908d5862]

        Add Handler for Pie Write
        
        The handler separates MetaPieAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I3ef877eea9fbd5c615a871c021ec600d6ab12e63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119735
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [c878a2227192021eeabb1143b0f374df43d32a56]

        Add Handler for Arc Write
        
        The handler separates MetaArcAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I141ba52e591ba38880f67669a2fb38e8c3e57f45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119734
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [8de81db4e3fca488d50db2d74734109b31541a6f]

        osl::Mutex->std::mutex in DNDEventDispatcher
        
        Change-Id: I95e4dc636fc16095044d01e1c1e1314f107b23b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119850
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  panoskorovesis  <panoskorovesis@outlook.com>  [76b619cca484fb681a8f3c175337fda3aabe3c0f]

        Add Handler for Ellipse Write
        
        The handler separates MetaEllipseAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: Iad944c41a88b2303abbdba8ce53528895773b01c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119733
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-08-02  Noel Grandin  <noelgrandin@gmail.com>  [11c2aa79bd80a05cd77eafe5cb1a60db1f4f0742]

        no need to use sequence for this data
        
        Change-Id: I14ddf0399a52a153931142401cf3f1ce8bea8161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119827
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [1597cc5b3e07dd24cb4cb10b35b1e93545e4b929]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel@peralex.com>  [0e883d6dbee8d72257f77605ae0c8a1d5bfbf044]

        display stack trace on assert for windows jenkins builds
        
        Change-Id: I1c23fda56c013eeeaf4ad1099c164d6d1146f68b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [914762f837cd4c1ff3a2d55284fdd631993e5e92]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: Ie80ce34d2c7d2726a04b8758903329854fdeeb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [dabf9afa5ac1d53c4b785ae6e10535f762ce599d]

        osl::Mutex->std::mutex in JSDialogNotifyIdle
        
        Change-Id: I1c172273e14d3bd2cd973abb38bf19be144ef210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119849
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae29e471ca0f8ccdd7a1906ce200dd24d96d2a5d]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: I63a4b050f220f0a61749892cd47fb91813f7d088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119844
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [287680683ca266f1fb4f447ac9bdaf76669d559d]

        osl::Mutex->std::mutex in ScRefreshTimer
        
        Change-Id: I64cac28e15edc90a8456e99c22e78cc84750eebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119747
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Miklos Vajna  <vmiklos@collabora.com>  [c1f16d3882c60f4a9ffccfc69003e09f19b99abe]

        sw: prefix members of SwXMLTableColsContext_Impl, ...
        
        ... SwXMLTableFrameFormatsSort_Impl, SwXMLTableLines_Impl and
        SwXMLTableRowContext_Impl
        
        See tdf#94879 for motivation.
        
        Change-Id: I2a9d92d469e79ff0ca4af4ae9d631479a8080673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119845
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-08-02  Jean-Pierre Ledure  <jp@ledure.be>  [ef08207a290c0dc537c698ec3389779a27085c04]

        ScriptForge - (SF_Chart) new service to manage Calc charts
        
        New methods in the SF_Calc service:
          Charts(), to list charts or to instantiate a chart service
          CreateChart, to create a new chart in a given Calc sheet
        
        The SF_Chart service has next properties to parameter the type
        and the characteristics of the (new or pre-existing) chart
          ChartType, Deep, Dim3d, Exploded, Filled, Legend, Percent, Stacked,
          Title, XTitle, YTitle
        Next methods are available:
          Resize, to move and resize the chart shape
          ExportToFile, to export the chart as a graphical object
            Supported: gif, jpeg, png, svg and tiff
        
        New error messages in SF_Root and SF_Exception.
        Corresponding labels are integrated in the POT file
        
        Full support under Basic and Python
        
        Review of make file of the SFDocuments library
        
        Change-Id: Id8db3098ff24fbf2efcbdd9c6dcd4f02ff5972af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119824
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [5f74a9c6b50b5689996ff93c95701eb4fc45b50f]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: I140932a94914d3870f0d92e11a6ada2b42359e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119842
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noelgrandin@gmail.com>  [0b5869d9f898ad8533a7c49a135efa739b8c465e]

        osl::Mutex->std::mutex in SimpleRegistry
        
        Change-Id: I92d76187ec9f487aaf43cbf19f3911110ddd8d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119833
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [47b16450f85ebe327e925682ed60bf811534eab7]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: I6f1c2ebafa056b3159315e75cf3682c8d889123c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119843
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [9c5744adbd97821b5574d55266f8a4e60fd925da]

        convert #defines to OUStringLiteral
        
        mostly by doing
        
        $ git grep -l '#define.*\"' -- *.cxx
            | xargs perl -pi -e
        's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
        u\2;/g'
        
        Change-Id: I7467f9067085ac89b98a0398811396c448339b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119840
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Todor Balabanov  <todor.balabanov@gmail.com>  [559b342a62901754222723ee522f5ae80e4d40f5]

        The null pointer bug should be fixed now.
        
        Change-Id: I8278bfed8170907a958396839d0997fc127f4b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119744
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-02  Noel Grandin  <noelgrandin@gmail.com>  [e98f04cedff85fd6a355a67cabd507782e2f693b]

        osl::Mutex->std::mutex in LRU_Cache
        
        Change-Id: Ia84cef550412540aa511f917198712add32fc7ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119831
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [7c38362dbe1922c9825dffb463072030948d406b]

        osl::Mutex->std::mutex in InteractionRequest::RetryContinuation
        
        Change-Id: I36a238f9b61471266b8fbc81c8e159a0e36182da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119832
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [983d0898b25f195258bb4934a62ae196d436fb0a]

        osl::Mutex->std::mutex in FileStreamWrapper_Impl
        
        Change-Id: Id4488b7722c9cf14157ed9333a0eb74de96834d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Eike Rathke  <erack@redhat.com>  [55abc3eb93fb8314b413453e384261cb00fde087]

        Consolidate link update handling
        
        Have it at one central place and identical for all document
        loading paths.
        
        Change-Id: Ib00153a9f5831e223d0129df0538353a7e20961e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119835
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [c0ce120b55ba389729e97babf80f2cb39ce38e9f]

        osl::Mutex->std::mutex in EventQueue
        
        Change-Id: Ia936a28dd2ae5b5cb1797a0e703e9d96841a1f3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119829
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [ee57ac14739f6bb03b1fd2031f547859c578f7ec]

        osl::Mutex->std::mutex in SfxURLRelocator_Impl
        
        Change-Id: Ifda4e66599e1de1e511b5733ccba50317f578444
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119828
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [0b9649e287abe80870a8caa0e40fdb591e22ef4d]

        osl::Mutex->std::mutex in ThumbnailViewItemAcc
        
        Change-Id: I9667e378542e7254c52fd57e379ae19a69ff08b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119825
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [1c6382b2564fbf19f8ee99e11021dff2ce19ed6f]

        xmlsec: handle missing EqualDistinguishedNames
        
        This is just a hack. A more correct fix would be to condition
        the whole xmlsecurity support in the various LO modules.
        
        The non-NSS build now fails, because it misses the
        EqualDistinguishedNames, which is non-trivial to implement.
        
        This is the consequence of commit
        1d3da3486d827dd5e7a3bf1c7a533f5aa9860e42 "xmlsecurity: add
        EqualDistinguishedNames()" and commit
        5af5ea893bcb8a8eb472ac11133da10e5a604e66 "xmlsecurity: improve
        handling of multiple certificates per X509Data".
        
        FWIW: one could also use OpenSSL i2d_X509_NAME and X509_NAME_cmp
        to implement this functionality, but it looks like it requires
        some ANS.1 input to begin with (maybe i2s_ASN1_* can be used).
        And then you would still miss some certificate store integration.
        
        Change-Id: I0600f76a5cb4379db428f67cb136b8567dfcc51e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116123
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [c1f2e972a758ba51a5c3e94f6c498f84766f586d]

        osl::Mutex->std::mutex in QueueProcessor
        
        Change-Id: Iebbfa22f90ea686cf4a38a0b76b5bbe2db838a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119823
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [e5d3ea2531210219cf5cd10a861aed0ad93ba07f]

        osl::Mutex->std::mutex in ResourceFactoryManager
        
        Change-Id: I8d332dde02c953b59c4bd26e3d31505c9677d546
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119822
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [933cf264b29307ce5cdf489ff89f5da889f5d298]

        osl::Mutex->std::mutex in ProviderCache
        
        Change-Id: Icf3afc783804c376fae94d0132e5040453e0d47a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119820
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [86d66c60043f97fcdeb7cabd40fe86c03216655a]

        osl::Mutex->std::mutex in MasterScriptProvider
        
        Change-Id: I40c2add3863ba284e6436a81424e3bbc7d501116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119819
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [ddc3e75845613a84b236229222e3a9b092a78861]

        unordered_map is better for pointer keys
        
        Change-Id: I0cb9e65efdeedafe87b4e32d01738943cc14d265
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119818
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [fba13b3b52b22eea0000b25faf31a57b642d0ce7]

        unordered_map is better for pointer keys
        
        Change-Id: I6d731ca2a312ea3fd00334f3135d15af6dcf637b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119817
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [303aa36685f2d52cff6004f9b41b90629c26f978]

        unordered_map is better for pointer keys
        
        Change-Id: Iaef42c9cc3526d1daa9ad6aaa840ea5a449173be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119816
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [5678db6ff2d8d1e1bc73972b8af8e6d063d499ad]

        o3tl::sorted_vector is better for small sets of pointers
        
        Change-Id: Ice284159b1666d930903eb53315e8a3c777c2a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119815
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [d3a297110a1948ebc417717c78c489ddb58e2002]

        o3tl::sorted_vector is better for small sets of pointers
        
        Change-Id: I6f67cf1ec02095c3953853d53f8750a97369fbcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [2bbb7b94b2cf7b0d4723e8a00a9d9705bc443acd]

        o3tl::sorted_vector is better for small sets of pointers
        
        Change-Id: Ieffb65301b83c03fd690e7269c3b326abcfe9b8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [34617c92805bc413dc464cdadf8ed17861a95f75]

        unordered_map is better when using pointers as keys
        
        Change-Id: I0d423dc2cafb3f7cbd41fd884ada252a86b8da86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119812
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Stephan Bergmann  <sbergman@redhat.com>  [fa759359587808f5e74217e558ee3dd9143710f7]

        external/libodfgen: Avoid division by zero for empty elliptical arc
        
        ...as seen when running under UBSan `instdir/program/soffice --headless
        --convert-to epub` of caolan/libmspub_icu_global_buffer_overflow.sample from the
        crash-testing corpus.
        
        <https://www.w3.org/TR/SVG11/implnote.html#ArcImplementationNotes> specifies:
        "If the endpoints (x1, y1) and (x2, y2) are identical, then this is equivalent
        to omitting the elliptical arc segment entirely."  (And getEllipticalArgBox's
        xmin, ymin, xmax, and ymax out parameters are pre-filled with suitable values at
        the call site in getPathBBox, so that we can return here without setting those
        out parameters.)
        
        Change-Id: I6b0b693354648f4015cec2395737fb9abe5ae956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119680
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bf4ebb17c09d6e78e0f6676a127aecf67a817982]

        Removed executable permission on source file
        
        Change-Id: I8c00d4fe1409b4f7f9b6c8a6b6358676bdd0d91b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119793
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6bb3a9dde89a11553cc7d9dde13e1390b591a7d5]

        Fix typos
        
        Change-Id: Ib48f6c8e0424e6843d2b3a7b3558d1d8714a80ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119792
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [e5982d9148d84874237470102e804c52432aa502]

        osl::Mutex->std::mutex in ODigestContext
        
        Change-Id: I168750490f2c60f8c93aef630949acb4e29734b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119750
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [e698cbd8f860ba6f483f1476e694706717451d2f]

        osl::Mutex->static local in EnhancedCustomShapeToken
        
        Change-Id: I436df7f8088c6f5f9376ca9d45d9ce4b7de06069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [a32af6867b7fdc6dccf78ffbb63573fd4224883b]

        osl::Mutex->std::mutex in SvXMLExport::SetError
        
        Change-Id: Ibc72ed31df8291587d39dd46f604572b7ca1a147
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [5b5d3d90f3d91f94b50a9c6a98bece0fd7e6593c]

        osl::Mutex->std::mutex in SecurityEnvironment_NssImpl
        
        Change-Id: I4b00afbe71b5459a9b1b8e612e44af71616a9b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119749
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Noel Grandin  <noelgrandin@gmail.com>  [499adc4cc3597486a49b3781ba21e3c216668ea4]

        osl::Mutex->std::mutex in XMLBasicExporterBase
        
        Change-Id: I5178e6bc6566186081e7a21e91cd8ca221b74cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-08-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [246f24ebc8227345f13784d9e2f055d813f3d24f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e9915d1db36ed686095e9f1c095423455b5bd151
          - More refactoring of dict_pt-BR lightproof
            
            1) revert soft-hyphen to \xad
            2) concatenate strings that were previously escaped (accented chars)
            
            Change-Id: If11072e994d0b6287e786cf87454bdbb1637b581
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119764
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [93e90309b36faa384eeebfaa6d685073c26a1975]

        Use ZLIB_CONST to avoid const_cast
        
        It is available since 2011 [1]. CentOS 7, which is the baseline,
        included zlib 1.2.7, which was released in 2012, and included [1].
        
        [1] https://github.com/madler/zlib/commit/5ab9f47745fe9353291b217f705086b6070575d5,
        
        Change-Id: Ie6cf2e934579620787426d95380f8ff6d6423b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119627
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-31  Caolán McNamara  <caolanm@redhat.com>  [748e3efcfe4c7298545ab8230118f90b1b9f30a7]

        cid#1489714 Unused value
        
        Change-Id: I265946afb52e20f0eac0348fdb692b6e38f0f90a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119763
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-31  Caolán McNamara  <caolanm@redhat.com>  [f27b24837af2bc8ff080375929a9a6f32d26c5dd]

        cid#1489715 Uninitialized pointer field
        
        Change-Id: I4275e2b79eab63a805a0263edba2997b5966483e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [23071f68eaba463e9c1a00270e82ef51dcdcfce8]

        osl::Mutex->std::mutex in CXPathAPI
        
        Change-Id: I008e9d660b1c245aea57ebef02ab651d435a90d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119757
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [26f7e6320942890ff0b916d37cde02270475ae16]

        osl::Mutex->std::mutex in InputStreamTransformer
        
        Change-Id: I64344b890c35d35b3d1b481436eb624183febec6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [7a4a107283dd43a35434f73cd7fbf291c8837b6d]

        osl::Mutex->std::mutex in TreeFileIterator
        
        Change-Id: Ie4e102c03aef8ded29561359c58e6c78cfebbdc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119755
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [e66fdb597b30fc701bb068824d0ae4d89fecd55f]

        osl::Mutex->std::mutex in CDocumentBuilder
        
        Change-Id: I4ffd2c1d5a28a692e94b8dfa6e468c297789ef63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119760
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [5a882b83dfe1483883a5d112ae1aa6d685d7334f]

        osl::Mutex->std::mutex in CSAXDocumentBuilder
        
        Change-Id: Ib50ca1070d9b0999795c73fcd85fe8e2e1aabc8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [f7b530736869461ed1f0548a1424d240c1a756ea]

        osl::Mutex->std::mutex in librdf_Repository
        
        Change-Id: Iceec0138a05e914935e3b6df2044a40cb76d10b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119758
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [2b525409ffd97f534114089aa73d0a931ba49c48]

        osl::Mutex->std::mutex in ScEditUtil
        
        Change-Id: I9bc69b24b9ced4b41d12263d3515538b6a02e79d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119748
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Julien Nabet  <serval2412@yahoo.fr>  [a72f7ad1563e9b46d5fe15ef2531d9681b0218a9]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 9a771d3d10ef796086d8c2d618dd2528ce4245b1
          - Fix Flags not at the start of the expression in ru-RU
            
            Thank you Mike for the suggestion!
            
            Change-Id: Id8850677458b602a1823d96f0f8af93a0c86146f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119761
            Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1eb4056b3c95dd62f242532b1b5e53b2a8139e36]

        osl::Mutex->std::mutex in ScPoolHelper
        
        Change-Id: I85b8bdf80e97e7588db811c1bdf71cc2346d3245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [f146cb69eb2a2cc0bffb0e76dbccbcdf942d5f7e]

        osl::Mutex->std::mutex in Entity
        
        Change-Id: Ia9201dc4998a592ef4adaa39666f67a0935e8161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119745
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Rene Engelhard  <rene@debian.org>  [299b72e4c9ad239d747e47eaf004400f5a590695]

        fix install with  --disable-cmis
        
        Change-Id: I51430a860a0b5047b566ed8184f0f563ec54f288
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119661
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [9ae4f8b5bf70a693ffb60ceac4f9625cf15b1181]

        getArray->getConstArray
        
        Change-Id: I951dd4a02c9ead98e7eb13ae2995ba2e1e57b38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119740
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [ca7dab5d96e73b7b4b045e2460e0b2ee150757db]

        tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton
        
        The original method SvTreeListBox::StartDrag always triggers
        a MouseButtonUp event and tries to initiate a Drag of a Line of
        a TreeListBox (on MouseMove, btw).
        
        This is not wanted if the last MouseButtonDown started a
        ButtonActive mode and activated CaptureMouse, prepared to
        trigger Action on that Button on MouseButtonUp. It leads to
        unwanted/strange behaviour of Buttons/CheckBoxes when used in
        TreeListBoxes.
        
        The behaviour is also dependent on the UI implementation used
        under Linux (gen/gtk3_kde5/gtk3/qt5/kf5) which are all
        (unfortunately) behaving differently, but a first suggestion/
        step to enhance the situation.
        
        Found now for gen/qt5/kf5 that when on the LineEntry, but
        not on the CheckBox, on MouseButtonUp the other line gets
        switched. Corrected that.
        
        Note: for gtk3_kde5/gtk3 there remains the problem that the
        CheckBoxes get switched on MouseButtonDown, butt these are
        generic widgets and this needs to be solved differently.
        
        Change-Id: If4cfe894b716185293beff64fc7e482d6f6313d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119644
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-07-31  Noel Grandin  <noelgrandin@gmail.com>  [95f5c4fb555407461fc1ab41aedbb9043105b9d6]

        getArray->getConstArray in package
        
        so we can avoid the const of making the Sequence singular
        
        Change-Id: I939d573c0f1e7a5d3b09a8589c0fda1e9ea38208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119739
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1d9de5a91a21060d151f68ae8ee1d79cf04aa8f]

        osl::Mutex->std::mutex in DocumentOpenedGuard
        
        Change-Id: Ie92a65e82fdd5493088aa08264e26df9b3992127
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119731
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  DaeHyun Sung  <sungdh86+git@gmail.com>  [9a873383868814e18de8d205a03c0824c74b6d56]

        tdf#143295 fix DateAcceptancePattern in Korean
        
        In Korean, both "YYYY-MM-DD"(ISO8601) and "YYYY. MM. DD."Hangul orthography(한글맞춤법)" are public and usually use in Korean.
        
        So, I fixed DateAcceptancePattern elements in Korean  on i18npool/source/localedata/data/ko_KR.xml
        
        Change-Id: Iae3dfc63f4c67f4e1a74df7686daf2c2187c0b35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118708
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [352b052ed859366a5100147cf7b98fccb8cfd18e]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 70533d899bad9163a528279a5f078ffaf5af72f0
          - Refactor lighproof_pt-BR impl script
            
            1) convert escaped char to true UTF-8
            2) concatenate strings
            
            Change-Id: I3e04989b578ec4221929e8afed81b21ab441c16f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119743
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [0d76bc20c48dbec111fe6da07f7c23d0d73d807b]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to f206a4b5a330778ff3eb41deb13fbc3397e5701e
          - "троеточие" is vernacular
            
            Change-Id: I1fe88cd8bda8368a91c466af99fecc1fc53f9d0f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119624
            Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [89149b7013c91a46f05b547d41761768f8eb070c]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to f8f892099e37a3e2d5d0196cec4786746e5901d2
          - Add regex checker for pt-BR LightProof
            
            Many thanks to Mauricio Baesa "El Mau"
            
            Change-Id: I9e65247a9edd47611d43debfa83a025c2c23bc98
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119742
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-31  Julien Nabet  <serval2412@yahoo.fr>  [85952f1a8ecad0fc9ded32fd4e00bea19b953262]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 8167fb5ecbd98d8e2ae63b612fcdb7ca009a3120
          - Reformat lightproof_ru_RU.py to have 1 expression per line
            
            Change-Id: I1eef05082fee8207d157ef72cb99f2c47be6efd1
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119702
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-07-31  Olivier Hallot  <olivier.hallot@libreoffice.org>  [890515a415def34d39276aec14de6de0f149c8c2]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to d280ecd7d75a5be4f2a2238570238a3bb5e4e214
          - Refactor and fix pt-BR Lightproof rules
            
            1) convert to UTF-8
               escaped characters replaced by UTF-8 equivalent
               except some typographic quotes
               remove u' and u" prefixing UTF-8 strings
            2) fixed broken rules (unbalanced parenthesis)
            
            Improves readability of the rules
            Many thanks to Mauricio Baesa "El Mau" for the support on Python
            
            Change-Id: If62464633725401ed510dfcfcc907c8c7ad32d1d
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119741
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [f883bf8b655569b9897a4a237b52d424b2550cf8]

        osl::Mutex->std::mutex in NumberText_Impl
        
        Change-Id: I9903a2717fe9019c45c4ecc3e7dcaed7e1a9d9f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119730
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [e81be03d9f2c952da0516be0f42fd2dbe6f6d4a4]

        osl::Mutex->std::mutex in LangGuess_Impl
        
        Change-Id: If2ea21cd52ddae821598398524c84b5b22817c33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119729
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8adf13fe66e1bdc30e3390f59c9fb33269f4b9dc]

        osl::Mutex->std::mutex in DropTargetHelper
        
        Change-Id: I7a8e58cb023576d671a8b39082f00029d784cc65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119728
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [95e7f977acc81555525565853e42e9df9ff5ebad]

        osl::Mutex->std::mutex in DragSourceHelper
        
        Change-Id: I886300dc65542f5e716fa970a9804c6084419515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119727
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Eike Rathke  <erack@redhat.com>  [f1f15123bb6af38866b40f8e0d0b6530f69e1eca]

        Check nNextPageBreak for ScRowBreakIterator::NOT_FOUND, tdf#64703 follow-up
        
        Change-Id: Ifa0fd1b53da70018d8d14abd4f8ba347908d5ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119732
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-31  Mike Kaganski  <mike.kaganski@collabora.com>  [ff1fdf19c44835071916d20e879c383d1513265e]

        editengine-columns: number of columns is sal_Int16
        
        Change-Id: If0e46614a398a1b2fe93eb1bfa25b5670be3511b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119725
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc0aebfb6a199761134d372f42401b81b37ca102]

        osl::Mutex->std::mutex in OInputStreamWrapper
        
        Change-Id: I59dbb1d5d3aea9b94959d26e544eddfb600e9fa1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [429e6e6efbfbc65d36452cbf8b3a25740a1dc8bc]

        osl::Mutex->std::mutex in OInputStreamHelper
        
        Change-Id: Ia6aa6541474e0e4c190ab805a931d74c8a598baf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119723
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d78d98e62255238d4ae6060b2a57ae37dbabb4e6]

        osl::Mutex->std::mutex in ItemHolder2
        
        Change-Id: I6e21d6b8b582d4793f64b04183edcfcb3b178f1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119722
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d088493a47654e7f6239e8743bd8b2382754212a]

        osl::Mutex->std::mutex in ItemHolder1
        
        Change-Id: I778450e986ec93f020ef594fe79bc65673ae78be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119714
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c636f233fc0cd4f7c9000901fd006aa7823ade55]

        osl::Mutex->std::mutex in CharClass
        
        Change-Id: I8f8873edbbc3974c38fe51ea1c65f93c22570891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119713
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [421c3c9ca4ad01540838cbe4ecb89e353a70e14c]

        osl::Mutex->std::mutex in AccessibleStateSetHelper
        
        Change-Id: I20baf32570eef64e8288bb82804c2530f2c6a96b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119712
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [049732b2190ee24b11a71f9236d597a37b54ea77]

        osl::Mutex->std::mutex in AccessibleRelationSetHelper
        
        Change-Id: Ib7f44b7bd4b500960f771210177bcfc9476f36be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119711
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [a943936eeff04b60ebd0b2552bc18b42606f3321]

        rtl::Static -> static local
        
        in a handful cases, like a map or a vector, we don't need init on demand
        at all, the default constructor can be laid out at compile time
        
        Change-Id: Ifa3188af7a65cd475ce0f603d15a8c26bcda7e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119710
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [620f9649ae55e01700419876ce25ab4e45ed859f]

        Add Handler for RoundRect Write
        
        The handler separates MetaRoundRectAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I2f0a25386d9d0de72469878199fa3cc5cc67e41b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119594
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [78b74ddc3da9dbc4d728b71f93626b0528870f31]

        Add Handler for Rect Write
        
        The handler separates MetaRectAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I67a1728b2e9c3fdac727345007ee9b2e4448674a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119593
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [dd8c7dc5083c83e5b3ad6fb19905c6187af14260]

        Add Handler for Line Write
        
        The handler separates MetaLineAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I34f7781426177b5a1d36260df55128591db4a894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119592
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [7c18bfa1709147562ad045729d8a0a1a9b1f67ab]

        Add Handler for Point Write
        
        The handler separates MetaPointAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I771f7abbcf21ec34aae46d7232ca352de4ba75a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119591
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [858176c120b82f626aa8625fbb87dd23c4391c03]

        Add Handler for Pixel Write
        
        The handler separates MetaPixelAction::Write from metaact.hxx
        Write implementation is now in SvmWriter.hxx
        
        Change-Id: I042bc7ae50319c7bf2a75716b4cf968675670e70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119580
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  panoskorovesis  <panoskorovesis@outlook.com>  [5e020c43668c9e11188ba48bf57de4bd7e9cc501]

        Create SvmWriter class
        
        This class will separate Write functionality from metaact.hxx with
        the use of handlers for each metaact subclass
        
        Change-Id: I7c74ec183f08b62d713457e4e971ea5b0b67cde2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119541
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d5765ae2f9236c8ce32d61f05f46d9d76b991544]

        drawinglayer: extract Prop. Value conversion from ViewInformation2D
        
        ViewInformation2D doesn't need to know anything about the Sequence
        of PropertyValue that is used for parameters when constructing it
        through UNO API. This can be done outside of ViewInfromation2D and
        it doesn't need to be responsible for that internally inside the
        ViewInformation2D. With this we get ViewInformation2D, which is much
        simpler and isn't prone to YAGNI.
        
        Change-Id: I3836237a1d26e38145b52136c3204931ae7c6b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119721
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [13efd364c046b8064f03cb23bb232f42a892d601]

        drawinglayer: remove extendedInformation from ViewInformation2D
        
        We actually never use extended information when normally using
        the ViewInformation2D. The exception here is when we construct it
        from property values, where the unknown property values are then
        stored into the extended information sequence and then later
        reconstructed when we convert it back to a sequence of property
        values. Just for that case we don't neeed to expose the extended
        information to the outside and create it, as that is then a
        implementation detail for the UNO use case.
        
        I am also not convinced we need it when creating ViewInformation2D
        with the sequence of property values - it certantly not expected
        that we need to preserve the property values at all, but that is
        something that needs to be checked.
        
        Change-Id: I3b8d533cd412aac8b89ca2921738d6487be5cf45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119720
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ea269c0a04ede8206ba15fd77d26bbd99ec44c75]

        svx: cleanup some forward decls, unneeded pragma once, whitespace
        
        Change-Id: I26cd723e0ffe907a7aa8cb4f73ba6bfbd6db5fbc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119719
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-30  Caolán McNamara  <caolanm@redhat.com>  [4677345e3695bac158bb04048b4d5c608ed764b4]

        cid#1489568 Dereference null return value
        
        Change-Id: I1e200d119c1b12266e69c21c2b94e83c1943b84d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119703
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-30  Julien Nabet  <serval2412@yahoo.fr>  [c694d9029b33cc574abd6b2cce8842d70d46cf5f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 8cd20580b995fc6d93fbb1cdabd329a26c6ec85c
          - tdf#139523: LightProof makes Python complain on FutureWarnings for pt-BR
            
            Deal also with deprecated + fix some regexps
            
            Change-Id: Ifd5bfed9a1f256bd357d29bac46ea51515b522f0
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119693
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-30  Noel Grandin  <noelgrandin@gmail.com>  [942dcd6d8684ffdbc9bc67030c502e9db1965eb5]

        flatten vcl::ImplControlData
        
        the struct is already visible in the headers, so it's not a pimpl
        pattern, and it's only two pointers, so no point in allocating
        separately.
        
        The tdf#91081 bug comment I removed is no longer relevant,
        this general class of problem was solved with the introduction
        of VclPtr.
        
        Change-Id: Ie5d896baf0167273f8936930dd65891919c5bf7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119679
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [9dcf5816c90e9819861332f11e014ef7b78e2fe7]

        tdf#143580 Qt5 don't use Qt::Popup for FLOAT wins
        
        Main problem is, that Qt::Popup grabs the focus and therefore
        generates a focus-out event for the combobox, which then closes
        the just shown popup window. The grab happens inside QWidget
        private code and there is no way around it. But instead of
        "faking" Qt::Tooltip, this uses Qt::Widget with additional flags.
        
        Regression from commit 7e6fee830116823b9cd8e46d6962df4ea2bc1ea6
        ("Qt5 fix Qt::Popup window handling").
        
        Change-Id: Ia1f8e33d98f7ec36cf1ebc350886121dfaadd658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119691
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-30  Tünde Tóth  <toth.tunde@nisz.hu>  [0c0444c44107f1a18f23dd0833d462d8dbf56569]

        tdf#126926 sc DBData: delete the database range
        
        if some part of the reference became invalid.
        
        Change-Id: I4b10af46e92a0a1ba9b6eb5e49df1d3f9a4be6a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119354
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [4bf1fbc9572741c665ae200303e929d908896820]

        tsan:data race in XBufferedThreadedStream
        
        cannot read from maInUseBuffer without holding the lock
        
        Change-Id: I4244e1132595a18c1a7ab33803e10b6c29684bf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119707
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1600c169bd2114505344a100cdc383539f76dbc]

        TSAN suppression file
        
        Change-Id: I07a56a4dd7543ca3faf265110bcf02aaafec1b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119708
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [9edb0f8641b5c01fff57cb5b5c492f3f525d49c8]

        osl::Mutex->std::atomic in FmSearchEngine
        
        Change-Id: Ie056215227ce19efcb28518f6a510bed5b15b93d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119705
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Mike Kaganski  <mike.kaganski@collabora.com>  [1119f5fb482c82124f99bbeffe6b507a377247de]

        Use u16string_view here
        
        Change-Id: I2841f16c359fab1d5a50c1a056cb913770beb3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119619
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-30  Caolán McNamara  <caolanm@redhat.com>  [b7322c23a69d0727d0ecb3185d6516ca457e2f14]

        cid#1399290 silence Uncaught exception
        
        Change-Id: I1fecdb09374c3631e005039d38dfd852a7b4b671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-30  Caolán McNamara  <caolanm@redhat.com>  [8689bd5490b473a7ffb149bbe5f7f0683f679c72]

        convert TextAlign to scoped enum
        
        Change-Id: Id2c466eacb44f0ea6adba75a0ac0be8be8e7ed4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119682
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-30  Caolán McNamara  <caolanm@redhat.com>  [d4d8fb12e81152ad75d1ab4cabfa300aa982e589]

        cid#1489551 silence Uninitialized scalar variable
        
        and
        
        cid#1489552 Uninitialized scalar variable
        
        Change-Id: I056cfd95d34f2163e68b83cce21bce70ccf5fc8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119701
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-30  Attila Szűcs  <szucs.attila3@nisz.hu>  [8b2a2de2481843502f0566e773ed11532520bc70]

        tdf#64703 sc: fix regression of printing page breaks
        
        After hidden rows or rows hidden by Autofilter,
        printing removed the page breaks between the visible
        rows, too. Now Calc supports WYSWYG: it prints all the
        visible page breaks, which includes the page breaks
        between the visible rows, and page breaks between the
        hidden rows (multiple page breaks of a hidden row
        sequence converted to a single page break).
        
        This was a regression since LO 3.6, introducing
        Autofilter with multichoice.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I87858d36fc62b8a5952cfd5bc39dbe90f1452ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118984
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [350f994d43660b75bfd21990edabdb1c8adb839e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1951014d9e7c5270904789c2964d35fca8487134
          - Rewrite SF_Services with Python support focusing user scripts only
            
            Change-Id: Ib3748c3fbe43e25e3a9aa895519f08ec3b11b953
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119612
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [66fceca24ee0fccd03f23afc689d82c794a2d57e]

        osl::Mutex->std::mutex in FmXDisposeListener
        
        Change-Id: I213499d4c707194c516cafe2ee323e61566cac71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [7b5922eb666e5f153060468b271d99510adb422e]

        osl::Mutex->std::mutex in DispatchHelper
        
        Change-Id: I6443f604f7f5cacc4b3d67bb6dab07706c82a9a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Gopi Krishna Menon  <gopi.menon@collabora.com>  [74f4a1796f94477d459c71d0a0aaa8f4a430e208]

        Fix Nesting Level Bug in ProfileZone
        
        Moves the profile zone global nesting variable into the source from header and makes it threadlocal
        
        Change-Id: I97751f5c532d8e0e36adb7d9d383bd88f752953f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119662
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-07-30  Anshu  <anshukhare50@gmail.com>  [172f589471edcac9a4974132a3145b721942879a]

        tdf#38194 related: introduce StylesList control
        
        Change-Id: I31202c213e034ab96f28e16d1f6a59b52f47507d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117918
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-30  Caolán McNamara  <caolanm@redhat.com>  [5c9001acf25bf1795f683fc1a43dc6ec0ba6ced9]

        drop FontAlign alias of TextAlign
        
        Change-Id: If69ce85482fdb7d33d00fb0cf9b4d4609bb92cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8618707dd9d7de2a439ab361d7ff6bca373670c4]

        tsan:data race in ThreadPoolTest::testWorkerUsage
        
        Change-Id: Id63b9f1dd7ed163236837258e8dbad2feb9f1c5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119695
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [bb2470ffb749ed95e77cc112ee08a46c8b99be36]

        osl::Mutex->std::mutx in OSequenceOutputStream
        
        Change-Id: I1924cc0910c5dfb431b676a0f50f922779920594
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [957a66e58444a2ac4bb77d978fd08e84fceffc38]

        osl::Mutex->std::mutex in SequenceInputStream
        
        also
        (*) check params before taking mutex to minimise the time holding the
        mutex
        (*) some methods were missing a lock_guard
        
        Change-Id: Iac35328e67f81b38c896f7c1e2a3514b813656c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119696
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [f107e6893491bdf9e9bd1a8620218640ea76095a]

        osl::Mutex->std::mutex in OAccessibleKeyBindingHelper
        
        Change-Id: Ib308ede9561a3ff26cfc43bee202f3151fa07392
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119694
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Noel Grandin  <noelgrandin@gmail.com>  [b595a93f3022badf4f8a1e0edd19475778b0fddc]

        use less GetOutDev()
        
        Change-Id: If6a528a5ff18e23226d5ec371a040cd994f1d384
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119678
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e1511ce551f27a5560600029193f076fd65ece17]

        indexing: add LOKit API to render the search result into a bitmap
        
        This adds a new LOKit API to render the search result into a bitmap
        buffer. It combines the SearchResultLocator to get the location
        inside the document of the search result (a series of rectangles)
        and the existing LOKit paintTile API to render the result into
        a bitmap (byte) buffer.
        
        It also adds a LOKit test to show how the API is used and to render
        a search result of a example document.
        
        Change-Id: I4284d90188777fd28158d029daa04151e71022bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118670
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eb31491b2a419ba7e67cc0a59a9b295fe49526e5]

        tools: use upper case GetWidth/GetHeight for Rect for repr. string
        
        When a rectangle is written to a string stream (usually used for
        representation string in CPP unit tests) we used getWidth and
        getHeight. It turns out that this methods don't return the correct
        value for width / height (off by one) in many cases so instead we
        need to use the upper-case variants GetWidth/GetHeight.
        
        Change-Id: Id655236155f94e092d9e9c24f9bd6857e9b0a558
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119489
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-30  Huilin  <lynntang12138@gmail.com>  [151237558c3da083a45b29a98523366a8d438aeb]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I769206b581dd056d2b8cd2c0b20bab0e48af68cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119578
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-29  Eike Rathke  <erack@redhat.com>  [ac80ec817eb07c77a51bc0729985a473c734182e]

        Make duplicate generated numbering identifiers unique, tdf#143526 follow-up
        
        Change-Id: I28366c4e868e97b70e016b056b73b88b4cc8b812
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119677
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1009cb94ba8d5adbe0b37f05c5eecf43d6cab60c]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 67fc52d45b9c5e965f176eb917428c724c076ba0
          - Fix typo
            
            Change-Id: Ic16067f805346e2a019855c1b1fff4905cc52d57
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119683
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [88d6e6873fe05ada6ee7178811b0b6f0a3f14635]

        lok sidebar: remove unused code
        
        Change-Id: I88325246d4997d44b4a1ca681627ca00ade1f030
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118285
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119664
        Tested-by: Jenkins

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [63ed9fe32c849901af2624d59c49ddd42c70217a]

        jsdialog: sidebar: enable fontwork popups
        
        Change-Id: I12002874a06ca2dc96c6dc3dc0ef3d5004c45f5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118251
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119663
        Tested-by: Jenkins

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [d22299918b5969fe2c08747fb7e7e55d52e9151b]

        jsdialog: sidebar: dump expanded state for panel
        
        Change-Id: Iffd4570a512d20229c20c0c7bbb113eaf456bcba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118250
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119660
        Tested-by: Jenkins

2021-07-29  Katarina Behrens  <bubli@bubli.org>  [6146b185ab2a335de39d0562a8d34e53d3e742e0]

        tdf#142817: Correctly replace animation effect that comes with a command
        
        As effect1 with command (e.g. the one from misc/MEDIACALL category)
        is created, 'mnCommand' member var is set.
        
        But when it is replaced by command-less effect2 via
        CustomAnnimationEffect::replaceNode, this var is never reset (simply
        because the relevant if-else branch is never hit) so it looks as if
        the command was still there. This causes UI glitch in sidebar:
        setting incorrect category of the next selected effect
        
        To fix that, we reset 'mnCommand' in ::setNode function, just as
        it is done with resetting audio associated w/ the effect
        
        Change-Id: I86016dd1acadfb31f460bde749bbe15164f1eb81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119492
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-07-29  Julien Nabet  <serval2412@yahoo.fr>  [5aa8ff21a01b8d5eb5acacb182fff976317f4991]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 1787948f9a80e7f39c0d67869ff56d22223df584
          - Portuguese Brasil lightproof: fix "Flags not at the start of the expression"
            
            Change-Id: If1888a167f2efe6ee54e72e4adf6ee9ab851b590
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119569
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [f186149acd5018c66b9d11c8e3f30dda51b8e895]

        osl::Mutex->std::mutex in OSLInputStreamWrapper
        
        Change-Id: Id67cf7989a47f73b62e48b88c3e6f51efc2ccc46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119674
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Mike Kaganski  <mike.kaganski@collabora.com>  [adeaa3a2cf31478c15147afe1303b77f8949293a]

        Update VS natvis for recent WhichRangesContainer changes
        
        Change-Id: I2171e88ca4d3404d35fe669c3c7af6ccd817b254
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119617
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [acb38a86b2b1d43b2a8d4405a0af90a2387e6142]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 60ac0c9c796fd0c09b0482baa7878399a9c2e75a
          - Fix typo in "Expressão arcaica"
            
            Change-Id: I513054881a967c0b3c3e5451f1f8134506156d66
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119646
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e15586246b94815de2004a6f73fdbd3473e62525]

        osl::Mutex->std::mutex in OSeekableInputWrapper
        
        Change-Id: Ib6cc0a6b1fcc4685f2ac8c120c86ce79f3036535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [720ddd9c132928192df907886cf8dec64a311833]

        osl::Mutex->std::mutex in FormulaBuffer
        
        Change-Id: Idef0cddac54da4794553394f48d3006b8145b291
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Eike Rathke  <erack@redhat.com>  [c186d09f88d6a4992382a1d15b60db6dbed3a91b]

        Add NumberingIdentifier unit test, tdf#143526 related
        
        Change-Id: I9d4df6f63dc9ebc90e99fecce14b3551c74f7f1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119675
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-29  Stephan Bergmann  <sbergman@redhat.com>  [8ede3362a2a32c7f74e73265599429840544029d]

        Fix --enable-mergelibs `make check`
        
        > LNK] CppunitTest/libtest_basegfx.so
        > include/basegfx/tuple/b3dtuple.hxx:92: error: undefined reference to 'basegfx::B3DTuple::getEmptyTuple()'
        
        and
        
        > [LNK] CppunitTest/libtest_svx_removewhichrange.so
        > svx/source/core/extedit.cxx:65: error: undefined reference to 'FileChangedChecker::FileChangedChecker(rtl::OUString const&, std::function<void ()> const&)'
        > svx/source/engine3d/scene3d.cxx:221: error: undefined reference to 'B3dTransformationSet::SetDeviceRectangle(double, double, double, double)'
        > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)'
        > svx/source/engine3d/scene3d.cxx:175: error: undefined reference to 'B3dCamera::B3dCamera(basegfx::B3DPoint const&, basegfx::B3DVector const&, double, double)'
        > svx/source/engine3d/scene3d.cxx:243: error: undefined reference to 'B3dCamera::~B3dCamera()'
        > svx/source/engine3d/scene3d.cxx:355: error: undefined reference to 'B3dTransformationSet::SetRatio(double)'
        > svx/source/engine3d/scene3d.cxx:364: error: undefined reference to 'B3dViewport::SetViewportValues(basegfx::B3DPoint const&, basegfx::B3DVector const&, basegfx::B3DVector const&)'
        > svx/source/engine3d/scene3d.cxx:367: error: undefined reference to 'B3dTransformationSet::SetPerspective(bool)'
        > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)'
        > include/tools/b3dtrans.hxx:120: error: undefined reference to 'B3dTransformationSet::SetViewportRectangle(tools::Rectangle const&, tools::Rectangle const&)'
        > svx/source/engine3d/scene3d.cxx:186: error: undefined reference to 'B3dCamera::B3dCamera(basegfx::B3DPoint const&, basegfx::B3DVector const&, double, double)'
        > svx/source/engine3d/scene3d.cxx:179: error: undefined reference to 'B3dCamera::~B3dCamera()'
        > svx/source/engine3d/scene3d.cxx:210: error: undefined reference to 'B3dCamera::~B3dCamera()'
        > svx/source/gallery2/galctrl.cxx:213: error: undefined reference to 'avmedia::MediaFloater::setURL(rtl::OUString const&, rtl::OUString const&, bool)'
        > svx/source/gallery2/galtheme.cxx:745: error: undefined reference to 'VersionCompatRead::VersionCompatRead(SvStream&)'
        > svx/source/gallery2/galtheme.cxx:757: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()'
        > svx/source/gallery2/galtheme.cxx:757: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()'
        > svx/source/gallery2/gallerybinaryengine.cxx:774: error: undefined reference to 'VersionCompatWrite::VersionCompatWrite(SvStream&, unsigned short)'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'VersionCompatWrite::~VersionCompatWrite()'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'VersionCompatWrite::~VersionCompatWrite()'
        > svx/source/gallery2/gallerybinaryengineentry.cxx:115: error: undefined reference to 'VersionCompatRead::VersionCompatRead(SvStream&)'
        > svx/source/gallery2/gallerybinaryengineentry.cxx:123: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()'
        > svx/source/gallery2/gallerybinaryengineentry.cxx:123: error: undefined reference to 'VersionCompatRead::~VersionCompatRead()'
        > include/editeng/editund2.hxx:29: error: undefined reference to 'vtable for EditUndoManager'
        > /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
        > include/editeng/editund2.hxx:29: error: undefined reference to 'vtable for EditUndoManager'
        > /usr/bin/ld.gold: the vtable symbol may be undefined because the class is missing its key function
        > svx/source/svdraw/sdrundomanager.cxx:30: error: undefined reference to 'EditUndoManager::EditUndoManager(unsigned short)'
        > svx/source/svdraw/sdrundomanager.cxx:72: error: undefined reference to 'EditUndoManager::Redo()'
        > svx/source/svdraw/sdrundomanager.cxx:46: error: undefined reference to 'EditUndoManager::Undo()'
        > workdir/CxxObject/svx/source/svdraw/sdrundomanager.o:sdrundomanager.cxx:typeinfo for SdrUndoManager: error: undefined reference to 'typeinfo for EditUndoManager'
        > svx/source/svdraw/svdedxv.cxx:97: error: undefined reference to 'EditViewCallbacks::~EditViewCallbacks()'
        > svx/source/svdraw/svdedxv.cxx:87: error: undefined reference to 'EditViewCallbacks::~EditViewCallbacks()'
        > workdir/CxxObject/svx/source/svdraw/svdedxv.o:svdedxv.cxx:typeinfo for SdrObjEditView: error: undefined reference to 'typeinfo for EditViewCallbacks'
        > svx/source/svdraw/svdfmtf.cxx:1206: error: undefined reference to 'MetaMapModeAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.cxx:1239: error: undefined reference to 'typeinfo for MetaGradientExAction'
        > svx/source/svdraw/svdfmtf.hxx:139: error: undefined reference to 'MetaLayoutModeAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:136: error: undefined reference to 'MetaTextLineColorAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:135: error: undefined reference to 'MetaRefPointAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:115: error: undefined reference to 'MetaRasterOpAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:117: error: undefined reference to 'MetaPopAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:116: error: undefined reference to 'MetaPushAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:112: error: undefined reference to 'MetaFontAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.cxx:1206: error: undefined reference to 'MetaMapModeAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:113: error: undefined reference to 'MetaTextAlignAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:111: error: undefined reference to 'MetaTextFillColorAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:110: error: undefined reference to 'MetaTextColorAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:118: error: undefined reference to 'MetaMoveClipRegionAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:120: error: undefined reference to 'MetaISectRegionClipRegionAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:119: error: undefined reference to 'MetaISectRectClipRegionAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:114: error: undefined reference to 'MetaClipRegionAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:140: error: undefined reference to 'MetaTextLanguageAction::Execute(OutputDevice*)'
        > svx/source/svdraw/svdfmtf.hxx:141: error: undefined reference to 'MetaOverlineColorAction::Execute(OutputDevice*)'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()'
        > svx/source/svdraw/textchainflow.cxx:274: error: undefined reference to 'OFlowChainedText::RemoveOverflowingText(Outliner*)'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()'
        > /usr/include/c++/12.0.0/bits/unique_ptr.h:85: error: undefined reference to 'OFlowChainedText::~OFlowChainedText()'
        > svx/source/svdraw/textchainflow.cxx:101: error: undefined reference to 'UFlowChainedText::UFlowChainedText(Outliner const*, bool)'
        > svx/source/svdraw/textchainflow.cxx:96: error: undefined reference to 'OFlowChainedText::OFlowChainedText(Outliner const*, bool)'
        > svx/source/svdraw/textchainflow.cxx:123: error: undefined reference to 'OFlowChainedText::GetOverflowPointSel() const'
        > svx/source/svdraw/textchainflow.cxx:123: error: undefined reference to 'OFlowChainedText::GetOverflowPointSel() const'
        > svx/source/svdraw/textchainflow.cxx:159: error: undefined reference to 'UFlowChainedText::CreateMergedUnderflowParaObject(Outliner*, OutlinerParaObject const*)'
        > svx/source/svdraw/textchainflow.cxx:202: error: undefined reference to 'OFlowChainedText::RemoveOverflowingText(Outliner*)'
        > svx/source/svdraw/textchainflow.cxx:227: error: undefined reference to 'OFlowChainedText::InsertOverflowingText(Outliner*, OutlinerParaObject const*)'
        > svx/source/svdraw/textchainflow.cxx:239: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const'
        > svx/source/svdraw/textchainflow.cxx:235: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const'
        > svx/source/svdraw/textchainflow.cxx:235: error: undefined reference to 'OFlowChainedText::IsLastParaInterrupted() const'
        > svx/source/tbxctrls/tbcontrl.cxx:2747: error: undefined reference to 'SfxStatusListener::ReBind()'
        > include/svx/tbcontrl.hxx:175: error: undefined reference to 'SfxStatusListener::ReBind()'
        > svx/source/tbxctrls/tbcontrl.cxx:2697: error: undefined reference to 'SfxStatusListener::UnBind()'
        > svx/source/tbxctrls/tbcontrl.cxx:2493: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)'
        > svx/source/tbxctrls/tbcontrl.cxx:2493: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)'
        > svx/source/tbxctrls/tbcontrl.cxx:815: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()'
        > svx/source/tbxctrls/tbcontrl.cxx:815: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:typeinfo for SfxStyleControllerItem_Impl: error: undefined reference to 'typeinfo for SfxStatusListener'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::dispose()'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::dispose()'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/tbcontrl.o:tbcontrl.cxx:vtable for SfxStyleControllerItem_Impl: error: undefined reference to 'non-virtual thunk to SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > svx/source/tbxctrls/StylesPreviewWindow.cxx:63: error: undefined reference to 'SfxStatusListener::SfxStatusListener(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, unsigned short, rtl::OUString const&)'
        > svx/source/tbxctrls/StylesPreviewWindow.cxx:65: error: undefined reference to 'SfxStatusListener::ReBind()'
        > svx/source/tbxctrls/StylesPreviewWindow.cxx:409: error: undefined reference to 'SfxStatusListener::UnBind()'
        > svx/source/tbxctrls/StylesPreviewWindow.cxx:413: error: undefined reference to 'SfxStatusListener::dispose()'
        > svx/source/inc/StylesPreviewWindow.hxx:32: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()'
        > svx/source/inc/StylesPreviewWindow.hxx:32: error: undefined reference to 'SfxStatusListener::~SfxStatusListener()'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:typeinfo for StyleStatusListener: error: undefined reference to 'typeinfo for SfxStatusListener'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::dispose()'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::disposing(com::sun::star::lang::EventObject const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::statusChanged(com::sun::star::frame::FeatureStateEvent const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::dispose()'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::addEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > workdir/CxxObject/svx/source/tbxctrls/StylesPreviewWindow.o:StylesPreviewWindow.cxx:vtable for StyleStatusListener: error: undefined reference to 'non-virtual thunk to SfxStatusListener::removeEventListener(com::sun::star::uno::Reference<com::sun::star::lang::XEventListener> const&)'
        > svx/source/unodraw/unoshap3.cxx:324: error: undefined reference to 'B3dViewport::SetViewportValues(basegfx::B3DPoint const&, basegfx::B3DVector const&, basegfx::B3DVector const&)'
        > svx/source/xml/xmlxtexp.cxx:92: error: undefined reference to 'XMLMarkerStyleExport::~XMLMarkerStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:102: error: undefined reference to 'XMLDashStyleExport::~XMLDashStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:113: error: undefined reference to 'XMLHatchStyleExport::~XMLHatchStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:123: error: undefined reference to 'XMLGradientStyleExport::~XMLGradientStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:454: error: undefined reference to 'XMLHatchStyleExport::XMLHatchStyleExport(SvXMLExport&)'
        > svx/source/xml/xmlxtexp.cxx:432: error: undefined reference to 'XMLMarkerStyleExport::XMLMarkerStyleExport(SvXMLExport&)'
        > svx/source/xml/xmlxtexp.cxx:443: error: undefined reference to 'XMLDashStyleExport::XMLDashStyleExport(SvXMLExport&)'
        > svx/source/xml/xmlxtexp.cxx:465: error: undefined reference to 'XMLGradientStyleExport::XMLGradientStyleExport(SvXMLExport&)'
        > svx/source/xml/xmlxtexp.cxx:438: error: undefined reference to 'XMLMarkerStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)'
        > svx/source/xml/xmlxtexp.cxx:92: error: undefined reference to 'XMLMarkerStyleExport::~XMLMarkerStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:449: error: undefined reference to 'XMLDashStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)'
        > svx/source/xml/xmlxtexp.cxx:102: error: undefined reference to 'XMLDashStyleExport::~XMLDashStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:460: error: undefined reference to 'XMLHatchStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)'
        > svx/source/xml/xmlxtexp.cxx:113: error: undefined reference to 'XMLHatchStyleExport::~XMLHatchStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:471: error: undefined reference to 'XMLGradientStyleExport::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&)'
        > svx/source/xml/xmlxtexp.cxx:123: error: undefined reference to 'XMLGradientStyleExport::~XMLGradientStyleExport()'
        > svx/source/xml/xmlxtexp.cxx:482: error: undefined reference to 'XMLImageStyle::exportXML(rtl::OUString const&, com::sun::star::uno::Any const&, SvXMLExport&)'
        > svx/source/xml/xmlxtimp.cxx:220: error: undefined reference to 'XMLMarkerStyleImport::XMLMarkerStyleImport(SvXMLImport&)'
        > svx/source/xml/xmlxtimp.cxx:221: error: undefined reference to 'XMLMarkerStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)'
        > svx/source/xml/xmlxtimp.cxx:222: error: undefined reference to 'XMLMarkerStyleImport::~XMLMarkerStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:233: error: undefined reference to 'XMLDashStyleImport::XMLDashStyleImport(SvXMLImport&)'
        > svx/source/xml/xmlxtimp.cxx:234: error: undefined reference to 'XMLDashStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)'
        > svx/source/xml/xmlxtimp.cxx:235: error: undefined reference to 'XMLDashStyleImport::~XMLDashStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:259: error: undefined reference to 'XMLGradientStyleImport::XMLGradientStyleImport(SvXMLImport&)'
        > svx/source/xml/xmlxtimp.cxx:260: error: undefined reference to 'XMLGradientStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)'
        > svx/source/xml/xmlxtimp.cxx:261: error: undefined reference to 'XMLGradientStyleImport::~XMLGradientStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:246: error: undefined reference to 'XMLHatchStyleImport::XMLHatchStyleImport(SvXMLImport&)'
        > svx/source/xml/xmlxtimp.cxx:247: error: undefined reference to 'XMLHatchStyleImport::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&)'
        > svx/source/xml/xmlxtimp.cxx:248: error: undefined reference to 'XMLHatchStyleImport::~XMLHatchStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:273: error: undefined reference to 'XMLImageStyle::importXML(com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&, com::sun::star::uno::Any&, rtl::OUString&, SvXMLImport&)'
        > svx/source/xml/xmlxtimp.cxx:222: error: undefined reference to 'XMLMarkerStyleImport::~XMLMarkerStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:235: error: undefined reference to 'XMLDashStyleImport::~XMLDashStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:248: error: undefined reference to 'XMLHatchStyleImport::~XMLHatchStyleImport()'
        > svx/source/xml/xmlxtimp.cxx:261: error: undefined reference to 'XMLGradientStyleImport::~XMLGradientStyleImport()'
        > include/vcl/vclptr.hxx:129: error: undefined reference to 'svt::MultiLineTextCell::MultiLineTextCell(BrowserDataWin*)'
        > include/vcl/vclptr.hxx:129: error: undefined reference to 'svt::MultiLineTextCell::MultiLineTextCell(BrowserDataWin*)'
        > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()'
        > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()'
        > include/svtools/editbrowsebox.hxx:246: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()'
        > include/svtools/editbrowsebox.hxx:234: error: undefined reference to 'svt::IEditImplementation::~IEditImplementation()'
        > svx/source/form/fmshimp.cxx:3919: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)'
        > svx/source/form/fmshimp.cxx:3919: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)'
        > svx/source/form/fmshimp.cxx:2342: error: undefined reference to 'comphelper::IndexAccessIterator::Next()'
        > svx/source/form/fmshimp.cxx:2437: error: undefined reference to 'comphelper::IndexAccessIterator::Next()'
        > svx/source/inc/fmshimp.hxx:544: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > svx/source/inc/fmshimp.hxx:100: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)'
        > svx/source/form/fmshimp.cxx:3092: error: undefined reference to 'comphelper::IndexAccessIterator::Next()'
        > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > svx/source/inc/fmshimp.hxx:100: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)'
        > svx/source/form/fmshimp.cxx:3212: error: undefined reference to 'comphelper::IndexAccessIterator::Next()'
        > svx/source/inc/fmshimp.hxx:97: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::IndexAccessIterator(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)'
        > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > svx/source/form/fmshimp.cxx:1636: error: undefined reference to 'comphelper::IndexAccessIterator::~IndexAccessIterator()'
        > workdir/CxxObject/svx/source/form/fmshimp.o:fmshimp.cxx:typeinfo for FmXBoundFormFieldIterator: error: undefined reference to 'typeinfo for comphelper::IndexAccessIterator'
        > workdir/CxxObject/svx/source/form/fmshimp.o:fmshimp.cxx:typeinfo for SearchableControlIterator: error: undefined reference to 'typeinfo for comphelper::IndexAccessIterator'
        
        Change-Id: I9911219083676cd10f5ccfc067655252eb172a3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119676
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [de7db883479bdeb44efc2caa6b8f7cfd3865d114]

        loplugin:unnecessarymethods
        
        Change-Id: I1d7a9c2ca91816c9e550cd673e04599f5efcf5ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119668
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [85141c9175af90511e3cb5c134dfbbc63961cd39]

        no need for this map to be optional
        
        an empty map is a very small object
        
        Change-Id: I9153c3dfbbdb8f6781cbba2c8067d4cac5372578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119667
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [0be7fdfa86208d74ccbd1289ebc9f2cd03c8ae84]

        osl::Mutex->std::mutex in ColumnBlockPositionSet
        
        Change-Id: Ib9232f3b8f78a0a72a2eb1e743451a9f66e80979
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119671
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [27457150b1c85cbf7c084b0930a71b0106b8278b]

        return by const& in LocaleDataWrapper
        
        Change-Id: Id5075424867ae1017df9fa0cd2df802d529e32d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119666
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [52b8697a1f6af99061984140ecbca36808ae4a55]

        rtl::Static -> static local
        
        Change-Id: Ib8d9a24659a37e6b94237d98f030cd2be00bcb39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119665
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [962b6307da5d1248481bf9efa534a7bbd37f3a41]

        jsdialog: use original container type for popups
        
        Change-Id: I6cffa33d7bfbc9087b8fff08b993c2a87b8811c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118080
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119659
        Tested-by: Jenkins

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [56e8d9dbbfb1915e8599f7b1bb24ba502e862198]

        jsdialog: sidebar: don't close popups when first time used
        
        Change-Id: I9a4f96acf44f3503f7bd978883d9d20de528b7bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118073
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119658
        Tested-by: Jenkins

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c7d6924511f3006f64fb9d3eadd289778098571]

        rtl::Static -> static local
        
        in a handful cases, like a map or a vector, we don't need init on demand
        at all, the default constructor can be laid out at compile time
        
        Change-Id: I2d404584b5aa23db7b1f779e160e04e72dd2aa74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119656
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  Caolán McNamara  <caolanm@redhat.com>  [2e894d5053dccadc41f4c449e8fbdd3ada0c5bdc]

        drop some unneeded includes
        
        Change-Id: I200d2936e97475dedc67801631222da12c777729
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119649
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-29  Caolán McNamara  <caolanm@redhat.com>  [a57ec3ca97b587c76dc082b75532cc62d423cc8d]

        use the parent as available from HangulHanjaConversion
        
        Change-Id: I9b8e34f4358620f2bc3c510ea3d581be8f87bb97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119648
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-29  homeboy445  <akshitsan13@gmail.com>  [3e35fb78ac577d6bca9a05276f50ab98a8b6425f]

        Intialize the VCL test dialog directly instead of dispatching command
        
        Change-Id: Ia24c97b12266dac3a6f315993558f3cdac8a4652
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118124
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-29  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [27612dc0d3afad4f7eec7109a09262e877c63399]

        Revert "cid#1486241 'Constant' variable guards dead code"
        
        This led to an exception when activating a page via UNO (seen in WollMux):
        
        warn:svtools.uno:211417:211417:svtools/source/uno/wizard/wizardshell.cxx:120: DBG_UNHANDLED_EXCEPTION in enterState exception: com.sun.star.uno.RuntimeException message: [jni_uno bridge error] UNO calling Java method onActivatePage: non-UNO exception occurred: java.lang.ArrayIndexOutOfBoundsException: Index 2 out of bounds for length 1
        java stack trace:
        java.lang.ArrayIndexOutOfBoundsException: Index 2 out of bounds for length 1
        	at de.muenchen.allg.itd51.wollmux.dialog.mailmerge.MailmergeWizardController.onActivatePage(MailmergeWizardController.java:170)
        	at com.sun.star.bridges.jni_uno.JNI_proxy.dispatch_call(Native Method)
        	at com.sun.star.bridges.jni_uno.JNI_proxy.invoke(JNI_proxy.java:185)
        	at com.sun.proxy.$Proxy118.execute(Unknown Source)
        	at de.muenchen.allg.itd51.wollmux.dialog.mailmerge.MailmergeWizardController.startWizard(MailmergeWizardController.java:199)
        	at de.muenchen.allg.itd51.wollmux.sidebar.SeriendruckSidebarContent.lambda$new$5(SeriendruckSidebarContent.java:468)
        
        This reverts commit 23c2c3433dc6bbfff2e1b590b1a89ee7f9c155c0.
        
        Change-Id: I6344a83eaa37b58c46a8b576c65bb15b11855c9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119655
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [a30e71bc1184d30bc9c95c2e02779660d58e3be9]

        sidebar: unify LineWidthPopup with other WeldToolbarPopups
        
        Change-Id: I9dd0d2b223972683a9066f0069e055175349526f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118023
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119654
        Tested-by: Jenkins

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [b206dda731e7c4390d6c9fe9c66feb8e903d3786]

        jsdialog: enable line end style popup
        
        Change-Id: I6c9bc4bf651ba130ec87348ac0e12cbe0265b3e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118006
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119653
        Tested-by: Jenkins

2021-07-29  Stephan Bergmann  <sbergman@redhat.com>  [202bdf0673964bb405a9677ea6c0b4cfec9479cd]

        Adapt again to C++20 char8_t
        
        ...after 53840ffd9755bbf2965676136c9772089891bfe8 "Pass context and resource
        string down to boost::locale separately"
        
        Change-Id: I3c010a00d66b9831e3f29581c56390b312dbe04c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119651
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [77c39371e3c2965982006f3d060148d05839e95b]

        jsdialog: handle toolbox menus toggling
        
        Change-Id: I85881531f041cbd5402ac8de2a96b2c7150cbba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117839
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119609
        Tested-by: Jenkins

2021-07-29  Szymon Kłos  <szymon.klos@collabora.com>  [cf9baa91a3c15fb798639c96f2fee6a5bd4975ff]

        jsdialog: toolbox popups
        
        unify menubutton popups and toolbox dropdowns
        
        Change-Id: I61c0c33a17d96f03d6513507bda6d5c8edbc55dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117786
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119608
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-29  Stephan Bergmann  <sbergman@redhat.com>  [e1fe04f117030400f07d207e0a3e35161ac464fa]

        Avoid some division by zero
        
        The first of which was seen when running under UBSan `instdir/program/soffice
        --headless --convert-to pdf` of caolan/id:002485,src:002216,op:havoc,rep:8.jpg
        from the crash-testing corpus.  The second one (when computing nGrfDPIy) was not
        observed, but lets assume that it could happen just as well, and keep the code
        symmetric.
        
        Change-Id: Idf9f9a84f3b05c7cfe3c66db753c73d2cbf812be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119650
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6f8f757c7338dd890273235bae6917b3175e2f86]

        Fix typos
        
        Change-Id: I0430fe4bc3107b321e7b7ab84cbc3e6afff97372
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119647
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [53840ffd9755bbf2965676136c9772089891bfe8]

        Pass context and resource string down to boost::locale separately
        
        because this is often on a hot path, and we can avoid the splitting and
        joining of strings like this.
        
        Create a new small index type TranslateId for some type-safety.
        
        This change only updates accessibility to use the new API, other modules
        will follow in stages.
        
        Change-Id: I289245ad34fda775812302ca7ac1588710167b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-29  DaeHyun Sung  <sungdh86+git@gmail.com>  [4598a385ffaaf8fdc124962d347fead994450bea]

        tdf#143526 fix and add Korean numbering
        
        fix Korean NumberFormat, compare with MS Word
        change mapping of style::NumberingType::NUMBER_HANGUL_KO,
        from "koreanLegal" to "koreanCounting"
        "koreanDigital" add new reserved words "일, 일영, 일영영, etc"
        - style::NumberingType::NUMBER_DIGITAL_KO
        "koreanLegal" is new reserved words "하나, 둘, 셋, 넷, 다섯, 여섯, 일곱, 여덟, 아홉, 열"
        - style::NumberingType::NUMBER_LEGAL_KO
        "koreanDigital2" is new reserved words "一, 一零, 一零零, etc"
         - style::NumberingType::NUMBER_DIGITAL2_KO
        
        Reference:
        1: "[MS-OE376]: Office Implementation Information for ECMA-376 Standards Support"
        https://docs.microsoft.com/en-us/openspecs/office_standards/ms-oe376/a5deef83-bb01-410f-bde0-9c35abe4ca52
        2.1.350 Part 4 Section 2.13.5.30, numberingChange (Previous Paragraph Numbering Properties)
        
        2: "[MS-DOCX]: Word Extensions to the Office Open XML (.docx) File Format" shows example of not only Korean Numbering also others Numbering examples.
        https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/b839fe1f-e1ca-4fa6-8c26-5954d0abbccd
        2.4 numFmt Extensions
        https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/a1bb5809-e361-4e49-8e16-7f1a67da4121
        
        Change-Id: I535b2aa3cf4111d86b9b7b788afe4aa64e8e4545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119518
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-29  Miklos Vajna  <vmiklos@collabora.com>  [ff1d4168dd8620431a4f9da64c8d25a7c8f69693]

        sw: use more StaticWhichCast() in source/core/txtnode/
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: I16c65845cdeabbd0a73f52b14dfbd1e29c7cf24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119645
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-29  Dennis Francis  <dennisfrancis.in@gmail.com>  [4c93b0eff4cd993adfd178b904eb05b3979b066a]

        lok: sc: unit test for non existent tab view data fix
        
        Conflicts:
        	sc/qa/unit/tiledrendering/tiledrendering.cxx
        
        Change-Id: I7c0ea95118448a49288ff70c8e7bcddc379df5ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119605
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-07-29  Justin Luth  <justin_luth@sil.org>  [fb0628b5ffe2571af3fb811c5c5109698b1bf773]

        tdf#91083 sw layout: don't emulate table keep when already set
        
        EmulateKeep is intended for interoperability with MS formats.
        But if an MS format is saved in ODF format, it can once
        again have the real table keep-with-next-paragraph property.
        In that case, we shouldn't try to emulate what is explicitly set.
        
        This is based on a code-read and debugging of tdf#143468.
        However, I don't have any examples or proof docs
        that show this actually caused any real problems.
        However, clearly there is no need to emulate in this
        particular situation, so best to make that clear ASAP.
        
        Change-Id: I1cd6af4a89c50f2d3ae60fcbf07bf604e1976c5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119575
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-29  Justin Luth  <jluth@mail.com>  [82b14219969c4f80d421015c9e89e8d3db4650d8]

        crashreport writerfilter: findColumn(unsigned long,unsigned long)
        
        Although the crash reports don't show getRow as a separate
        item in the list of functions leading to the crash,
        it just CAN'T be a problem with mTableDataStack.empty()
        or !mTableDataStack.top() because they are unconditionally
        used or popped later on in endLevel().
        
        So I resisted the urge to test everything, and just verified
        that the row (which exists for m_aCellProperties) actually
        exists in the table manager - similar to getGridBefore().
        
        Change-Id: I5a27dc40db18f05ad4656789d3e61ec1ff4de471
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119420
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-28  Stephan Bergmann  <sbergman@redhat.com>  [99fa607245332d687d494d8d4404cf067ca21fb3]

        Annotate the .eh_frame data
        
        ...to convince myself that it is only about the initial %rsp/%rbp fiddling, and
        is not affected by the ca344be7aabf88dddde38841e6af6292ece6829b "tdf#143450: Fix
        special fp+integer struct return case for gcc_*_x86-64" changes to later parts
        of privateSnippetExecutor
        
        Change-Id: I7bfad4cb5e1c2208e29c73a70874b6e9eff29eb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119610
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5aa74aa1e6fac571f99146ebcb6adc9feb1459ad]

        Removed executable bits on source file
        
        Change-Id: Ib9d8c713e6bc673e806ee8e2e9afea65a5ad83ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119565
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-28  Caolán McNamara  <caolanm@redhat.com>  [387eaa2f6efe0277c28f12abc72febf73d07462e]

        Related: ofz#36348 ubsan runtime error: value outside representable range
        
        Change-Id: I0dbbba2c4020d7fc7e6f12aba4bfcb003fa13893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119611
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2021-07-28  Eike Rathke  <erack@redhat.com>  [56cebfdbce89e7400a89678d14b847243e88f971]

        Keep ScParameterClassification sorted, tdf#76310 follow-up
        
        Change-Id: Ib1441b0668abbf50a46416b32292160eb8995ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119636
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [968e758f163ef5a6c8c46e3427fccae32958b6db]

        XAccessibleValue::getMinimumIncrement: Add "@since" annotation
        
        Add "@since LibreOffice 7.3" annotation for the method added in
        
            commit b5ada12ffd0b6b8677430fce117c4c1e38cc9159
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Wed Jul 28 11:26:16 2021 +0200
        
                a11y: Add XAccessibleValue::getMinimumIncrement method
        
        Thanks to Stephan for pointing it out in above commit's Gerrit
        change. [1]
        
        [1] https://gerrit.libreoffice.org/c/core/+/119596
        
        Change-Id: I416653ea5ebf3a09effead2d132db340d08e6c53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119634
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Stanislav Horacek  <stanislav.horacek@gmail.com>  [72773c8e547ee42922bf32a861bb4ae13858169d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to b3a1c0be50d1ad0b404070124463fb4af90bbe39
          - Czech Hunspell: add several word forms
            
            Change-Id: I227d4fe75539691c75323ffcc822545081ced9ae
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119637
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-07-28  Eike Rathke  <erack@redhat.com>  [516318113f0bd2b3c658aba9b285165e63a280e2]

        Resolves: tdf#76310 Preserve whitespace TAB, CR, LF in formula expressions
        
        Allowed whitespace in ODFF and OOXML are
        U+0020 SPACE
        U+0009 CHARACTER TABULATION
        U+000A LINE FEED
        U+000D CARRIAGE RETURN
        
        Line feed and carriage return look a bit funny in the Function Wizard if
        part of a function's argument but work. Once a formula is edited, CR are
        converted to LF though, probably already in EditEngine, didn't
        investigate.
        
        Change-Id: I6278f6be48872e0710a3d74212db391dda249ed2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119635
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-28  Noel Grandin  <noel@peralex.com>  [24b06b9c6bdb777dff385b0fbfc81d55d3d013a1]

        log access violation on windows tinderboxen
        
        where we currently have no good feedback when something
        goes wrong.
        
        Credit: Exception printing code written by
          msdn-whiteknight
        as seen at
          https://stackoverflow.com/questions/22467604/how-can-you-use-capturestackbacktrace-to-capture-the-exception-stack-not-the-ca
        
        Change-Id: I44c65b10c0b0151c3236521d62a824570d4cdccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119561
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [67faef71f937a14799fd551a2751c3b61dd7a94f]

        A typo
        
        Change-Id: I5b9635381c43d34a16fb2443c4ca3621ff0d9a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119613
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [be3764070655afb438ac4d09a73175ebcbc8fea2]

        Minor fix in comment for XAccessibleValue::getMinimumValue
        
        This looks like a copy-paste error.
        The *upper* bound is relevant for 'getMaximumValue', the *lower*
        bound for 'getMinimumValue'.
        
        Change-Id: Ibe707fde6185c0fa757741683f046393e2003eb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119600
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [f62cbfed55099170ae6f9c006c36bca3420424e3]

        qt5 a11y: Implement Qt5AccessibleWidget::minimumStepSize
        
        This makes use of the newly introduced
        XAccessibleValue::getMinimumIncrement method,
        s. Change-Id: Ie148a4e1cedbdbb5964f8565c81611d3480465cb,
        "Add XAccessibleValue::getMinimumIncrement method".
        
        With this in place, Accerciser now shows the correct
        "Minimum increment" and the exact decimal value instead
        of a rounded integer value for FormattedFields, s.
        note in commit message for
        Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634
        "a11y: Expose FormattedField as spinbox" for more details.
        
        Change-Id: Ia9d07552197357c81ae8ea3b62e2de07e82148bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119597
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [b5ada12ffd0b6b8677430fce117c4c1e38cc9159]

        a11y: Add XAccessibleValue::getMinimumIncrement method
        
        Add a method 'getMinimumIncrement' to the XAccessibleValue interface.
        The method returns the minimal increment by which the value represented by
        the object can be adjusted.
        
        The main motivation is to expose this to AT-SPI, so it can be retrieved e.g.
        by libatspi's 'atspi_value_get_minimum_increment' function [1],
        s. the note in Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634
        "a11y: Expose FormattedField as spinbox" for more details.
        
        The implementation relevant for the 'FormattedField' class is in
        'SVTXAccessibleNumericField::getMinimumIncrement', which returns
        the spin size.
        
        While at it, also move the comment in sw/source/core/access/acccell.hxx
        mentioning what methods are overriden for the 'XAccessibleValue' interface
        to the right place.
        
        [1] https://developer.gnome.org/libatspi/stable/libatspi-atspi-value.html#atspi-value-get-minimum-increment
        
        Change-Id: Ie148a4e1cedbdbb5964f8565c81611d3480465cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119596
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [349a8801b9ee98f4f9ee1d35f7d28e17baedf7cc]

        a11y: Expose FormattedField as spinbox
        
        This adds a new accessibility class 'SVTXAccessibleNumericField'
        that implements 'XAccessibleValue' and reports having an a11y
        role of 'AccessibleRole::SPIN_BOX'. An object of that class
        is returned by 'SVTXNumericField::CreateAccessibleContext'.
        
        Create an 'SVTXNumericField' XWindow peer for windows
        of type 'WindowType::FORMATTEDFIELD'
        (instead of a 'VCLXNumericField' one), so the
        newly introduced accessibility class gets used for
        'FormattedField'.
        
        This way, FormattedFields are now exposed to a11y tools
        as spinboxes.
        
        Previously, since no specific accessibility class
        had been implemented for VCLXNumericField (then used as
        XWindow peer class for FormattedField), the
        one for VCLXEdit, i.e. VCLXAccessibleEdit, was used.
        
        While VCLXNumericField implements XNumericField
        and thus in general offers the relevant methods to implement
        an accessible class that implements XAccessibleValue as well,
        it uses the Formatter from the VCLXFormattedSpinField base class
        to get/set values. However, that doesn't work for the FormattedField
        case, since FormattedField has its own formatter of a different
        type and the 'mpFormatter' member in the VCLXFormattedSpinField
        base class is a nullptr, resulting in the corresponding
        getter methods always returning 0 and the setters doing nothing.
        
        With this commit in place, Accerciser now reports role
        "spin box" instead of just "text" for FormattedFields
        and displays the current value as well as allows to change
        it via the "Value" interface when using the qt5/kf5 VCL plugin.
        
        Note: For non-integer values, Accerciser doesn't show the actual
        decimal value, but an integer, e.g. when the value for "Height"
        spinbox in Writer's "Page Style" -> "Page" dialog (section "Paper
        format") is set to "29.70cm", Accerciser shows "30" instead of
        "29.70", despite 'Qt5AccessibleWidget::currentValue' returning
        the exact value. This is because Accerciser appears to rely
        on the value for the minimum increment being reported (as a
        corresponding decimal value) by a call
        to 'atspi_value_get_minimum_increment', s.[1].
        However, there is currently no corresponding method in the
        'XAccesibleValue' interface for that at-spi method which
        'Qt5AccessibleWidget::currentValue' could call to retrieve
        the value.
        
        The NVDA screen reader on Windows now also says e.g.
        "Width: (Type = 344)  spin button  editable  Alt+W  selected 8.50″"
        instead of "Width: (Type = 344)  edit  Alt+W  selected 8.50″".
        
        [1] https://developer.gnome.org/libatspi/stable/libatspi-atspi-value.html#atspi-value-get-minimum-increment
        
        Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119590
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Michael Weghorn  <m.weghorn@posteo.de>  [9ceb47ce712157019ca06ee11c66515ea7cc16ec]

        Move SVTXNumericField and parents to public toolkit header
        
        This is in preparation for the creation of a new accessibility
        class for 'SVTXNumericField'.
        
        Change-Id: I41e04c71b951832e4e264a271a3d66be7b6d6ce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119589
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-28  Dennis Francis  <dennisfrancis.in@gmail.com>  [c4bcdb3ec8952fd2a2838629702dd7a00e104f63]

        lok: sc: avoid crash on non existent tab view data
        
        ... when accessing position helpers.
        
        Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119604
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [cc7ff6d890ab2cacc7f0273039b15689dad5e0dd]

        Three identical functions for a class is a bit too much
        
        Change-Id: Ia949f3fe2cbbc8aa524347854faa23807d58e252
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119606
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [96c8255875c0ce45c6621999cc1bc4d9a429cb16]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a07d8d492c50f0e2db3200790f92e9e18bb5144
          - Adapt SF_String to new method signatures and add Python examples
            
            Change-Id: Ifd9fa48fcb34ca8469581b8f3d8aac29f51b8414
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119438
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [90f9a35319b3fc5db3fb4714a4b78f2c46fb4f28]

        Don't steal focus from popup in online
        
        To avoid closing the popup when it is first time activated.
        
        Change-Id: I23abd691ecc271b46f1bfba041f247208200ba7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117595
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119599
        Tested-by: Jenkins

2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [333f0cb495c64439ebd77e86a58297d455b71a13]

        jsdialog: handle popover close
        
        Change-Id: I8b5afe7438c57cfe0553475131bed1e3c4921f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117373
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119598
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [79eab8450b3a9db343a082e6d450764643340a3e]

        jsdialog: dump and activate popup windows
        
        Change-Id: I4eb49a81d12ac37f50c6595eeec6d472fdbe6d82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117251
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119581
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ed7511eca99819012fc1baa490ef85963a9472e]

        simplify SvtOptionsDialogOptions
        
        Change-Id: I8977c92897757bc62cdc93de98bfa05a00355f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119555
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-28  Stephan Bergmann  <sbergman@redhat.com>  [ca344be7aabf88dddde38841e6af6292ece6829b]

        tdf#143450: Fix special fp+integer struct return case for gcc_*_x86-64
        
        For one, the loop in x86_64::fill_struct was backwards.
        
        And for another, privateSnippedExecutor does not need special handling of FLOAT
        and DOUBLE return values (they can simply be moved to %xmm0, as covered by the
        general case), but rather for those small structs where floating-point member(s)
        in a first eightbyte (targeting %xmm0) are followed by integer member(s) in a
        second eightbyte (targeting %rax).  Extended testtools to cover two such cases.
        
        Change-Id: I8e775a1d1ce2312610f265bcc8e40b09bdac56df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119576
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [f7709a6594753b99973258d33ce3b901ed24df85]

        Update git submodules
        
        * Update translations from branch 'master'
          to a2b54ae27fac12ee3aee478872632c377e1843f9
          - update translations for 7.2.0 rc2/master
            
            and force-fix errors using pocheck
            
            Change-Id: I7b7bd01e640b88e6e81140686a68f72592e5a25d
            
2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [10926dd227d366b25bf79cffcbf8628355be250c]

        Move SalInstancePopover decl to header file
        
        Change-Id: I58d021d3e4a3f5d4b8b805380526c1d32b782674
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117345
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119563
        Tested-by: Jenkins

2021-07-28  Eike Rathke  <erack@redhat.com>  [6eb9fde88af245a00247fca8a592ed08ee4b8bbe]

        ODFF: eliminate spaces between function name and initial opening parenthesis
        
        Same as for OOXML, they are disallowed in ODFF as well.
        
        Change-Id: Iff78a901838092a3ee32221fdaadd28ee50f7646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119577
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-28  Stephan Bergmann  <sbergman@redhat.com>  [5a9d7625d215d9f9417a2207327a741618d3de82]

        ZipPackageHelper is now used in Library_cui outside Library_merged
        
        ...since 6cb3c79b84e396959a982070f6fc4d439a9c396d "Added the feature to store
        VCL test results as a zip file", see e.g. failed
        <https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1627450201.2981>:
        
        > 61078         /tinderbox/buildslave/build/workdir/CxxObject/cui/source/dialogs/GraphicTestsDialog.o: In function `GraphicsTestsDialog::HandleDownloadRequest(weld::Button&)´:
        > 61079         /tinderbox/buildslave/source/libo-master/cui/source/dialogs/GraphicTestsDialog.cxx:87: undefined reference to `utl::ZipPackageHelper::ZipPackageHelper(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&)´
        > 61080         /tinderbox/buildslave/source/libo-master/cui/source/dialogs/GraphicTestsDialog.cxx:88: undefined reference to `utl::ZipPackageHelper::getRootFolder()´
        > 61081         /tinderbox/buildslave/source/libo-master/cui/source/dialogs/GraphicTestsDialog.cxx:88: undefined reference to `utl::ZipPackageHelper::addFolderWithContent(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&, rtl::OUString const&)´
        > 61082         /tinderbox/buildslave/source/libo-master/cui/source/dialogs/GraphicTestsDialog.cxx:89: undefined reference to `utl::ZipPackageHelper::savePackage()´
        > 61083 NEXT    collect2: error: ld returned 1 exit status
        > 61084 NEXT    make[1]: *** [/tinderbox/buildslave/source/libo-master/cui/Library_cui.mk:10: /tinderbox/buildslave/build/instdir/program/libcuilo.so] Error 1
        
        Change-Id: Ia7af3bd4ed23adb8cadd66fb20ce8914040eb901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119582
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-28  Stephan Bergmann  <sbergman@redhat.com>  [8112bcae289fcc2210c7286d7b4bc141d8f6a1c0]

        Clean up bridges/source/cpp_uno/gcc3_macosx_x86-64/abi.cxx
        
        same as 5411aafbfd8656f043bcf30588bc41b061f1b60b "Clean up
        bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx"
        
        Change-Id: I25ba66f2d666ef108265d308b7cc9badba60ae2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119579
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-28  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a330732cf8aaa5770bef0b49c113a57ca5e85e10]

        tdf#107953 - Extend significant digits
        
        According to
        https://randomascii.wordpress.com/2012/03/08/float-precisionfrom-zero-to-100-digits-2/
        show at least 9 / 17 significant digits for a single / double data type
        in order to identify the contained value.
        
        Change-Id: Id2833fc51ca005bc78b68d6b4cca28f2d95f5a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119526
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [1ec5a1300632a5455416b6cbb090d8c48353d939]

        jsdialog: dump internal image for buttons
        
        Change-Id: I53687f67042490c19d1056c74619d43566bf1289
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117132
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119562
        Tested-by: Jenkins

2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [2cb0ebaff2896feafc1f574ca8fb1f13a11f5401]

        jsdialog: sidebar: fix closing
        
        revert change done by mistake in:
        64bd4dd2f80b247cb5df3f3e6c54bf2d47bc41a7
        
        Change-Id: I740d5970c713053c7f8a4c880776a1056d132e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119553
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-28  Szymon Kłos  <szymon.klos@collabora.com>  [a72b7e2f38cc8c7372f24365a8458528205b09e4]

        jsdialog: weld MenuButton
        
        Change-Id: I79b753e070183daa809b23dbb7d3052000ebecd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116995
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119552
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-28  Mike Kaganski  <mike.kaganski@collabora.com>  [44a4b028d094dda4dc4886a4670371175da8024f]

        Consolidate saturating_(add,sub) for signed and unsigned
        
        Compiler would optimize away the branch that is unreachable
        for current operand type anyway.
        
        Change-Id: Iac84057c1716990d107529d52dba1dd7603c5a32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119448
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8fec570c21c5e45ba593ee96cc1ba5d45d77fc8]

        use officecfg for SvtCJKOptions
        
        and remove some unused options
        
        Change-Id: I487a233de4f7414012e5405f2c2e1f9c8b8fb4f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119554
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-28  Miklos Vajna  <vmiklos@collabora.com>  [3808418e38fe9540a286ad48f1c3eaed2706f78c]

        Add SwModelTestBase::loadAndSave()
        
        Allows one more removal of DECLARE_OOXMLEXPORT_EXPORTONLY_TEST() in
        CppunitTest_sw_ooxmlexport3. That conversion in testCalendar1 now looks
        like a good candidate for mass-conversion purposes.
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I096b87ede4417976e5348399e631814ca103bdc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119573
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-28  Julien Nabet  <serval2412@yahoo.fr>  [3bd2f04d59acfd1eb954042bd485858cdf0fd670]

        Just to fix a warning
        
        /home/julien/lo/libreoffice/instdir/sdk/include/uno/data.h:40: warning: argument 'pTypedemanded' of command @param is not found in the argument list of uno_QueryInterfaceFunc(void *pInterface, struct _typelib_TypeDescriptionReference *pType)
        /home/julien/lo/libreoffice/instdir/sdk/include/uno/data.h:44: warning: The following parameter of uno_QueryInterfaceFunc(void *pInterface, struct _typelib_TypeDescriptionReference *pType) is not documented:
          parameter 'pType'
        
        Change-Id: I5b6606749329eeacf868105e0a730df4999b6d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119571
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [73041de9563c9a973d1b5394c6e5520a7d799980]

        tdf#101630 - gdrive support w/oAuth and Drive API v3
        
        LibreOffice is only using drive.file scope, so can only see files it
        owns/that were created by LibreOffice.
        
        In addition, also store the refresh token in LO's password-store if the
        user enabled persistent storage, removing the need to to the
        copy'n'paste dance to grant access each time LO is launched.
        
        related tdf#115643 also store the refresh token for onedrive
        consolidate the fallback-auth provides for onedrive/gdrive into one,
        they are all the same login in browser, then copy code method that
        ultimately should be changed to having LO listen on local port for the
        code
        
        Change-Id: I97e3843682c302d2884e35ece6e72bc3a07e2539
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119572
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [5411aafbfd8656f043bcf30588bc41b061f1b60b]

        Clean up bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx
        
        ...without any intended functional changes, in preparation for actual fixes for
        tdf#143450 "Data corruption when returning small structs containing a double
        from C++ via IPC".
        
        Much of the code (apparently originally copied from some other project,
        according to the comments) was too generic for our specific needs here.
        
        Change-Id: Iddcb58fa0999d10dcf716dd2af7dab1620839bce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119570
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [1940ffc5347768fdc4d2bba636b40d451a274f1e]

        ofz#36348 Integer-overflow
        
        Change-Id: I7c6020e94c9ec9d002e66d0ad83426c062ebd5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119574
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [bc06fee6924419a8324145b09df54c15a07e1a76]

        MetaTextArrayAction version 2 string discarded
        
        since...
        
        commit 58a064595e43428f7d74341aff38df40fec0c8b3
        Date:   Thu Jul 8 12:51:11 2021 +0300
        
            Add Handler for MetaTextArray Read
        
        Change-Id: I0c35bb92d3e61d8d2158e3a51e3661373e5cb6aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119501
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [32baf8361a48f5238256acc101241d42c245a711]

        cid#1489549 Uncaught exception
        
        no need to check if mpPolygons is in use before deleting it
        
        Change-Id: Ie4fdc35ca70fcef6985268dd317e34dde1ccc950
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [db392a8a255326b7a094daeabd7fba195db6a9a5]

        [API CHANGE] Drop obsolete osl_demultiplexSocketEvents et al
        
        ...which were deprecated in 0a126b4c661d65860fd2de92f8cc49bdb65a957c "Deprecate
        osl_demultiplexSocketEvents et al" towards LO 7.2 (and leave aborting stubs in
        place for backwards compatibility)
        
        Change-Id: Ice6032eb2f351af87dd56eecb002aa2a91e79373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119560
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [89e3cf8f67d04fc8beff571aec8da130eccd7689]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 748ec6b4e01e0bc17f05b3171abb02d61401c096
          - Bump pt-BR dict version to 3.2.15
            
            Fix typo in pt_BR_en_US.properties
            
            Change-Id: Iaaf3c5c3eab220c1a9d41b7fbf73540fbdde07fd
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119445
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [9a9f8f8f85cd079911f39cde6dcae6d73a609cdc]

        cid#1489430 Big parameter passed by value
        
        Change-Id: Ib40bda812872c9421948bc9a1e131ab3f95a0ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119557
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [87b51aa7b83987894dfbbba08c19cb6bccb7e8a7]

        ofz#36586 Abrt failed throw
        
        Change-Id: I6ef391b5b96995db121fc52181b65e21fdc0d688
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119546
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  Julien Nabet  <serval2412@yahoo.fr>  [76f5155b6892dd6199bccc2206e716d473151cf4]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 7b0daded304d2d56c0f8035602a8480eec86d40d
          - Portuguese Brasil lightproof: numsep=>gerund since it concerns gerundismo
            
            Change-Id: I339f284e03004fe4fec2397844c9f53f3b3c2e10
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119567
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ef5edcfb02c6522af6f6621b5a9deae253755206]

        Fix typo
        
        Change-Id: I1267160a9e30b28a62017ae4d149253563849c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119566
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3c6b0322e2dc897bdd986afe0fe876a5d429528a]

        tdf#123626 Add "Open hyperlink" context menu to hyperlinked shapes
        
        Was missing in a23b44fd9f0119f7ea3523e32875f55c1a07c1cd
        
        Change-Id: Ifcee4af79a00c77206be4c2d5ff621f56f2d0018
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119551
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-27  Luboš Luňák  <l.lunak@collabora.com>  [cec95cd93ce002ff57e9a530ee920170f5d36e38]

        GooString::append(const std::string&) is new in poppler 0.83.0
        
        Change-Id: Ib3324c393c195526160eddbdfc83a688e6f66dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119534
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-27  Miklos Vajna  <vmiklos@collabora.com>  [d422512a5c9afc3b309442ba1cbd4405afab96c8]

        sw bibliography, local copy: handle the column mapping dialog
        
        This allows mapping the LocalURL database column to the LocalURL
        property of a bibliography reference field.
        
        Change-Id: Ic8793561e0242964c8a8313b230f6e13dda31dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119558
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-27  Julien Nabet  <serval2412@yahoo.fr>  [0e5146aa61e5487b042ed067c49f858c099fa746]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 6770a120c62386af493aacd4f16600d8cfaff1b0
          - tdf#143559: save the changes in options of Portuguese spellcheck
            
            The keyid is "malmau" not "mmalmau"
            
            Change-Id: I9ba651abe0a4c062f811ee61da1b9f45621a5f02
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119556
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-27  Julien Nabet  <serval2412@yahoo.fr>  [784c9d76f8dd13a4595246f1f58623312096c9ef]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 66dd2540ba4e4a6442de40edf6b27895f94d9958
          - tdf#143507: localize Grammar Checking (Portuguese) settings page
            
            Thank you Olivier Hallot for the translation!
            
            Change-Id: Iadd88379db040cf0743248b8169625102a4ebdec
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119540
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-27  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9a04703b22f9ffb11256d715f65e79a6a2417e18]

        tdf#123626 Allow opening shape hyperlink with Ctrl-Click
        
        Change-Id: I43201cd1fb7022fe5ff1479c66916c65adc554fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119550
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-27  Julien Nabet  <serval2412@yahoo.fr>  [76eb2c9b4a96a6495f08bf6d7b6270ed93b53765]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 30dd499a102c930b6386d9b0b44ed13e9d4cf8d2
          - Related tdf#138369: Remove spurious CR (ctrl-M) in ru_RU.dic
            
            Change-Id: Ia67007ad29497024b3186c1b466ccc987c08c60b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119488
            Tested-by: Julien Nabet <serval2412@yahoo.fr>
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-27  Mike Kaganski  <mike.kaganski@collabora.com>  [b24a1bcab389c0aefc1ddea9a1b81880f699df56]

        Drop redundant check
        
        If value is not approximately equal to zero, its square root also is not
        
        Change-Id: I0a2c30a8a85c64406e3a8ea8cff2315f25c2226d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-27  Caolán McNamara  <caolanm@redhat.com>  [da10cc990980f2f54b40f3165a6df3d0701cc958]

        cid#1489502 Big parameter passed by value
        
        etc
        
        Change-Id: I1242b26fa7e08c1818a0d5d5519e1220fbfb07bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119533
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-27  dante  <dante19031999@gmail.com>  [fcca4644d8676cace61fef84663566e9b1480067]

        Towards tdf#103740
        
        U+E... does not have the same spacing as U+0...
        So can't copy them.
        Plus and less signs are now less wide.
        
        Change-Id: I761a6a37e3130e5425148a5a102b7e6343217985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108526
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [48383d59f49d00dc27797d58472c90382c2244f7]

        simplify SvtViewOptions
        
        Change-Id: Ib1f42d7322d105337554848bc40726be00533843
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119548
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [71123e5749879ecf5cb7458df10be60c16255279]

        Move SalInstanceMenuButton decl to header
        
        Change-Id: I5f5f0ceb58925874c6878760a99179a4936198fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116991
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119543
        Tested-by: Jenkins

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [af0786c3d7e22e961a92e0ccb2fc2c6f504e576e]

        jsdialog: sidebar: remove code for tunneled one
        
        Change-Id: Idb60fdfc03729dd3755d5ef1ba61b2f9376e9556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116965
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119542
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-27  homeboy445  <akshitsan13@gmail.com>  [6cb3c79b84e396959a982070f6fc4d439a9c396d]

        Added the feature to store VCL test results as a zip file
        
        The results can now be downloaded as a zip file, which would
        consist of the test log and all the resultant bitmap images produced
        by the tests compressed as png stored in the user directory folder.
        
        Change-Id: I8a6098a7454a621bbb9cafa7b6f2cafaa5503522
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117937
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [a66dc788d92d9ef0ab6a5a0339f02df0c39b97fb]

        Add Handler for MetaAction Read
        
        The handler separates MetaAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx In this case the
        handler doesn't read anything. It creates and returns a MetaAction
        
        Change-Id: I01b23bd836c88f07dc9adde90a7e2da322b832f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119539
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [d2e47f496da7871e2f714bd39e7dc0b7428752bc]

        Add Handler for TextLanguage Read
        
        The handler separates MetaTextLanguageAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I9862c21ab2f75a1365bdbc609e4c399694d0a9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119538
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [b4a46b47b6c1eab5c293648f5d89e61dd4639213]

        Revert "osl::Mutex->std::mutex in bridges/except"
        
        This reverts commit 739aaf02db3353fac8490272cab0c9486570f76d.  At least in
        bridges/source/cpp_uno/gcc3_macosx_x86-64/except.cxx, getRTTI can call itself
        recursively, causing a deadlock on RTTI::m_mutex.  In
        bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx that has been addressed with
        RTTI::getRTTI_NoLock, but other implementations have not been modified.  Avoid
        regressions, esp. on more esoteric platforms, by reverting the change.
        
        Conflicts:
        	bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx
        
        Change-Id: I08b57b0561923bdbe191c8e93f8f400e0e4df337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119442
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [0aea34da123edc8e1be8626769f0ab83b6d0cab8]

        -Werror=maybe-uninitialized
        
        (at least with recent GCC 12 trunk and --enable-dbgutil --enable-optimized; see
        the discussion starting in the comment at
        <https://gerrit.libreoffice.org/c/core/+/109930/11#message-4375e529ca6a843e3560facc591368bf2f36a755>
        "tdf#114567 tdf#138934 Hyperlink-Target in Doc Headings expand/collapse" for the
        use of o3tl::doAccess here)
        
        Change-Id: I8ecc624488afa8825fe9c60bb07ca7079c398340
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119547
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  dante  <dante19031999@gmail.com>  [3ba06d93a90c7c97dbb7648931bbb2014b3cf784]

        Removing script we don't need for our purpose
        
        Change-Id: Ic5900e697f90f703431968b98addf768faac9736
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108363
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Miklos Vajna  <vmiklos@collabora.com>  [5fd2f212a1db9e061fb3a886810b427251e8a6bf]

        sw bibliography, local copy: handle the bibliography database window
        
        - update generalpage.ui to have the same widgets for both the URL and
          the local URL
        
        - extend BibGeneralPage to map LocalURL to m_xLocalURLED
        
        - get the usual browse / page number handling buttons working
        
        - introduce a separate GtkAdjustment for the additional spinbutton,
          which seems to be necessary for gtk3, but not for gen (otherwise
          increasing the value sets a new value for both spinbuttons)
        
        Change-Id: I9ea616102cd6a8a060217a4e404a8eb93a0c2a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119545
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d2c2985024ee085796a21ef9c3226dde10311c80]

        tdf#143126 PPTX: slideshow setting “Start from” not exported
        
        Follow-up to commit 3d55149dcf19cffefcc19c16a3abbe8851453c5e
        (tdf#142913 PPTX: slideshow setting “Start from” not imported).
        
        Change-Id: I4124e528f8af61c3b87978c2f3d2b96d983ec056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118648
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5db72ef0b381671b7867bda759098a92909e06d8]

        drop SvtLanguageOptions class
        
        since it is just a wrapper over SvtCJKOptions and SvtCTLOptions.
        Later I will replace those two with the equivalent officecfg calls
        
        Change-Id: I61c5667a05f75d42643175f2c28c29d7a590b15c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119516
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Tibor Nagy  <nagy.tibor2@nisz.hu>  [f8ddaaf0f5e1fb61e0d4404ea28757bc652ae4be]

        tdf#142915 PPTX import: support for presentation's timing attribute
        
        See Slide Show->Slide Show Settings...->Change slides manually,
        which is disabled by default. Now <p:showPr useTimings="false">
        is imported correctly, i.e. with enabled "Change slides manually".
        
        Note: it seems, com::sun::star::presentation::IsAutomatic
        UNO attribute has got a bad name and documentation: if it's
        value is TRUE, "Change slides manually" is enabled, and vice versa.
        Check with the following Basic code:
        
        ' show presentation-level automatic transition (IsAutomatic = False)
        print ThisComponent.getPresentation().IsAutomatic
        ' show slide-level automatic transition (Change = 1)
        Dim oDrawPages as Object, oDrawPage as Object
        oDrawPages = ThisComponent.getDrawPages()
        oDrawPage = oDrawPages.getByIndex(0)
        print oDrawPage.Change
        
        Change-Id: Ie4a687a29077cad89f11e77b856c28a1fe09376b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119321
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-27  dante  <dante19031999@gmail.com>  [543f50fb37648bf4eec5fe04ac76b260f36b02b0]

        Correct wrong direction for section symbol
        
        For our use python embed scripts are useless and can have unexpected behavior.
        
        Here is some useful documentation:
        https://fontforge.org/docs/techref/sfdformat.html#font-header
        
        Change-Id: Ieb2eb26bbc19cd59c37da986ea001915ad970201
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108314
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [6cb0afa58048773bf3c3f6bbd28496e44e7d12c5]

        Add Handler for LayoutMode Read
        
        The handler separates MetaLayoutAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Idd9e8f2db42b0fc6028c192f3fcba11c59917e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119537
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  Tor Lillqvist  <tml@collabora.com>  [3acb69e376f36952cc07827214b048d2d6196632]

        Try without --disable-database-connectivity when building for iOS
        
        This at least makes the configure script succeed again for iOS.
        
        See ffc6d564b91692cd9d99a0eb3b1ceaf54f7db89e.
        
        Change-Id: Iad7a1561bea09ea0315bb0079af55aad63befc23

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [08c7b311852d899d71e5bdea09a396f1b6dc44f4]

        jsdialog: hide adv search options on mobile
        
        Change-Id: Ide206d602992c49a3a54c8635d97a1ce43cc216e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116912
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119524
        Tested-by: Jenkins

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [e9aaab806d54d021801e86dc699642c0dc3fb1b0]

        jsdialog: weld frame
        
        Change-Id: I863022b0b1efc741626b0ba4a8a6183c169eaa85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116891
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119523
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [7d6a6e340e7d44fd74487e74d76a65992f097dc7]

        Move SalInstanceFrame decl to header file
        
        Change-Id: I43b10e2314b81dc490714ad9fb809c1324fe17c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116890
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119512
        Tested-by: Jenkins

2021-07-27  Szymon Kłos  <szymon.klos@collabora.com>  [457649d02f23446ed2d28433a5aedecf6a49aed7]

        jsdialog: sidebar: send sidebar Panels
        
        Change-Id: Ia5a936c44e5d83fd4626098bcc027b0382523231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116098
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119511
        Tested-by: Jenkins

2021-07-27  Luboš Luňák  <l.lunak@collabora.com>  [b17180a84cb4561b8a7bbf9e2281c91fffd56f87]

        write out image size in html export for 'keep ratio' images
        
        Without this the code was leaving out writing any size to the html
        output. Which means the size was the original image size, which may
        not be the size used by Writer.
        
        Change-Id: Ia249035a604f0f51f59b3190ebb8975a686533c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119498
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-27  dante  <dante19031999@gmail.com>  [efad5d95cd1952d09354650699b5c2daf07aa573]

        Copyright notice updated:
        
        - Font name: OpenSymbol Math
        - Font version restarts on 0.1
        - Copyright notice added
        - Licensed under OLF
        
        I can't correct the merge error because the file is too big.
        I need the previous patch merged first.
        
        Change-Id: Ia97d8c8ef99c9fbb49e2f268fd6cb52d5db257e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Noel Grandin  <noelgrandin@gmail.com>  [ae34c3fe49267be34f9fb055ea1cb92240796a26]

        use officecfg for SvtHistoryOptions
        
        Change-Id: I5cfd3a51bc4026ccb66ee23eb6f49a5dff5fe042
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119525
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-27  Miklos Vajna  <vmiklos@collabora.com>  [df2b617b612f24b1dd394faf6fd605bdc69790cb]

        sw: document the last parameter of FieldVanish() where it's not used
        
        To resolve docx vs rtf/doc inconsistency.
        
        Change-Id: I349cfb4aa9575df31c29eb35a32d72474d089c6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119527
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [230125da232510fb2cc08c28fb0bc36222c7600e]

        loplugin:unreffun (macOS)
        
        ...and -Werror,-Wunused-const-variable
        
        Change-Id: I0071e08af4ec3a037fb49b9345c1f70ddcfc5ea4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119536
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1ffed1e84b89454f8104e4fc7f28bce250142721]

        Remove duplicated includes
        
        Change-Id: I545c74059e2af2308d981356a24382958105bc1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119519
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b4f7a61abe222f874b064076eaec05c371b89c5f]

        sw: disable SearchResultLocatorTest for Windows and MacOS
        
        Because of inconsistent reuslts for those 2 platforms for unknown
        issues, turn the tests off for now.
        
        Change-Id: I9b1c8a839d6765d695ed5d9b129c001ffd66ed5e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119508
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [913cb8b32eb5346699770d52d288e02cc090011e]

        Add Handler for Comment Read
        
        The handler separates MetaCommentAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ic37db0ecb30482b3503ede88cd9d72de2ed0efde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119194
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [96294b206f02c9856dbcb8a21a0b20ce1180dd8c]

        Add Handler for RefPoint Read
        
        The handler separates MetaRefPointAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I0de2cbefbb91a89e24b8c6e43fea80a7595baa5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119193
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [f8847233c5b935d7ad1ea82bd464868d2bc3f69e]

        Add Handler for EPS Read
        
        The handler separates MetaEPSAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I9a56e447865643bbd6e02f9b9da3be715172fe35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119192
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  panoskorovesis  <panoskorovesis@outlook.com>  [ffd64889f3cad4fc64d733f5ad08a5c072de7ec6]

        Add Handler for FloatTransparent Read
        
        The handler separates MetaFloatTransparentAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ie19d33570daec5a5ec34ba015cf83bffb18d250b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119171
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-27  Stephan Bergmann  <sbergman@redhat.com>  [0ea2f9a1b33b446069935913c2b3c846d79b52de]

        Avoid potential tools::Long vs. UNOIDL LONG mismatch
        
        As found when debugging tdf#143534 "Crash in Calc NLP Solver when saving
        a document in Write" on Linux x86-64 (where tools::Long is 64-bit long; while
        UNOIDL LONG is 32-bit):  These ImplSetPropertyValues cause
        comphelper::OPropertyContainerHelper::convertFastPropertyValue to throw via
        lcl_throwIllegalPropertyValueTypeException due to the mismatch---which were then
        silently caught in UnoDialogControl::windowResized resp.
        UnoDialogControl::windowMoved.
        
        Change-Id: I9793204ad49737165e69de7d5e15445ba0e82c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119535
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-27  Regina Henschel  <rb.henschel@t-online.de>  [67f2a99229101757af4f40118f4d3c83ba38648b]

        tdf#143475 consider Word 2007 rotated image speciality
        
        Usually Word relates effectExtent to a rectangle with swapped width and
        height, if the object rotation is between 45deg and 135deg. But Word
        2007 (=version 12) makes an exception for images (bug?).
        The patch determines the version from compatibility setting and
        calculates wrap margins and effectExtent values considering this
        special feature of Word 2007.
        
        I have moved the part for getting the Word version from InteropGrabBag
        from the local function lcl_getWordCompatibilityMode to DocxExport,
        because I need it exactly the same way in docxsdrexport.cxx.
        
        Change-Id: Icc2f3d0710e29207413fb3810d281a0fd7d82002
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119482
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [1dd4a80fa076bedb3a82821517036bad8dd79857]

        cid#1489541 Big parameter passed by value
        
        etc
        
        Change-Id: Id7efff454fc73ead0d404495846f7df6e7a16a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119532
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [4ce8c219fc4cc252e4f2546c2a59ee0447efa7ee]

        cid#1489423 Big parameter passed by value
        
        and
        
        cid#1489424 Big parameter passed by value
        cid#1489425 Big parameter passed by value
        cid#1489427 Big parameter passed by value
        cid#1489432 Big parameter passed by value
        cid#1489435 Big parameter passed by value
        cid#1489436 Big parameter passed by value
        cid#1489439 Big parameter passed by value
        cid#1489441 Big parameter passed by value
        cid#1489443 Big parameter passed by value
        cid#1489445 Big parameter passed by value
        cid#1489451 Big parameter passed by value
        cid#1489459 Big parameter passed by value
        cid#1489462 Big parameter passed by value
        cid#1489463 Big parameter passed by value
        cid#1489465 Big parameter passed by value
        cid#1489467 Big parameter passed by value
        cid#1489468 Big parameter passed by value
        cid#1489469 Big parameter passed by value
        cid#1489473 Big parameter passed by value
        cid#1489475 Big parameter passed by value
        cid#1489476 Big parameter passed by value
        cid#1489477 Big parameter passed by value
        cid#1489479 Big parameter passed by value
        cid#1489481 Big parameter passed by value
        cid#1489489 Big parameter passed by value
        cid#1489491 Big parameter passed by value
        cid#1489493 Big parameter passed by value
        cid#1489495 Big parameter passed by value
        cid#1489498 Big parameter passed by value
        cid#1489501 Big parameter passed by value
        cid#1489504 Big parameter passed by value
        cid#1489508 Big parameter passed by value
        cid#1489509 Big parameter passed by value
        cid#1489513 Big parameter passed by value
        cid#1489516 Big parameter passed by value
        cid#1489518 Big parameter passed by value
        cid#1489521 Big parameter passed by value
        cid#1489533 Big parameter passed by value
        cid#1489534 Big parameter passed by value
        cid#1489537 Big parameter passed by value
        cid#1489538 Big parameter passed by value
        cid#1489540 Big parameter passed by value
        
        Change-Id: If613144a64087b4e0459f5935e1adbcb0e0330b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119531
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [7e864acc8991d42013a42abe408e5260a2124595]

        cid#1489419 Big parameter passed by value
        
        and
        
        cid#1489421 Big parameter passed by value
        cid#1489426 Big parameter passed by value
        cid#1489428 Big parameter passed by value
        cid#1489430 Big parameter passed by value
        cid#1489433 Big parameter passed by value
        cid#1489434 Big parameter passed by value
        cid#1489438 Big parameter passed by value
        cid#1489442 Big parameter passed by value
        cid#1489447 Big parameter passed by value
        cid#1489452 Big parameter passed by value
        cid#1489455 Big parameter passed by value
        cid#1489456 Big parameter passed by value
        cid#1489460 Big parameter passed by value
        cid#1489461 Big parameter passed by value
        cid#1489466 Big parameter passed by value
        cid#1489470 Big parameter passed by value
        cid#1489471 Big parameter passed by value
        cid#1489478 Big parameter passed by value
        cid#1489483 Big parameter passed by value
        cid#1489488 Big parameter passed by value
        cid#1489497 Big parameter passed by value
        cid#1489499 Big parameter passed by value
        cid#1489500 Big parameter passed by value
        cid#1489506 Big parameter passed by value
        cid#1489514 Big parameter passed by value
        cid#1489515 Big parameter passed by value
        cid#1489519 Big parameter passed by value
        cid#1489524 Big parameter passed by value
        cid#1489528 Big parameter passed by value
        cid#1489530 Big parameter passed by value
        cid#1489531 Big parameter passed by value
        cid#1489536 Big parameter passed by value
        
        Change-Id: I72167511858f16f49b31fd69e39435dbdaf83196
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119530
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Eike Rathke  <erack@redhat.com>  [3c766512984feff739377d0f0af46558ee7139fd]

        Related: tdf#64086 Add FormulaGrammar::isRefConventionOOXML()
        
        ... to prepare detailed compiler scanner handling.
        
        Change-Id: I4a50491b4fa95516773adbd7b86e91ab121b1820
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119517
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [d115205bc05209a32d8d47bae853424bef4191b1]

        cid#1489450 Big parameter passed by value
        
        Change-Id: I727922562f2655ef9dcc8f9deb866e7f39765f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119528
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [f2b3256297241da458a471d591e582c14d6ab73c]

        use officecfg for SvtSystemLanguageOptions
        
        Change-Id: Icf5cf974e4235d9a961e08bfc5689ec58930236e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119515
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [78adf246d5e99d0f5d91d2e03c1379b154289d8d]

        return SvtCompatibilityEntry from SvtCompatibilityOptions::GetList
        
        instead of converting back and forth
        
        Change-Id: Iec913494ccad65ebff76bf7b6cf5b2440fbade42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119514
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d14ab85a4446279e24aa6b6d5e8bfedb48ccdfe1]

        convert these into constants
        
        Change-Id: Ie3e3b497cfeb8c9e9456fb86a04f409658116e1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119513
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [21cb6039a3320682d0b1617facd86b092fcea10f]

        tdf#143543 Fix extended tip for pdflinkspage.ui
        
        Note: E.T. borrowed from Help page.
        Change-Id: Ia4da746aa25c72a3ef1a77a52fea5034fb3a0ae6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119507
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-07-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [01600f8917e290e59a8cdd2756231281bce96493]

        Bump Glade version to 3.38 for pdflinkspage.ui
        
        No change in dialog contents
        
        Change-Id: I648ef9bda3d20782d6912e765fa4a28a68a663b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119506
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [4d85cf64bde5ad7d59deba2d8211404f1ec61fb3]

        crashtesting: assert on loading ooo127821-1.docx
        
        there is another later assert unchanged by this commit
        
        Change-Id: I1691007c27195dcb02d8db3ab903b31e0cbce1ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119127
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [8c48dd5ac555e37a1ee50f70edcb678d723e62f4]

        cid#1485150 silence Uncaught exception
        
        Change-Id: I123efe9921716dda386d78bdbcf22f9299732b9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [682df20a542e5d113eaa3111db5ff28026987861]

        cid#1489422 Improper use of negative value
        
        Change-Id: Iffa2f90724ebd84bfa00238e6148daf8b31259c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119503
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Caolán McNamara  <caolanm@redhat.com>  [3378c34287c6f02a8f75cb3a6d301cb27ac188e3]

        cid#1489523 silence bogus Out-of-bounds access
        
        drop comment referring to no longer used return value
        
        Change-Id: I3eca1294edc09fc626a8d62ff031547c2a1a5a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119502
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-26  Justin Luth  <justin_luth@sil.org>  [1441e001938d6a0b19743ef8170980238b88d350]

        tdf#143517 partial revert "tdf#141964 writerfilter CN: get para...
        
        ...paragraph and inherited listLevel
        
        IIRC, I changed GetCurrentNumberingCharStyle() on the premise that
        no matter where the level is defined (paragraph or style),
        any function looking for it should use the inherited/applied level.
        But GetCurrentNumberingCharStyle() itself looks like a bogus
        hack that probably should be eliminated completely.
        
        Unfortunately, 2123ede032ca64f696ef54af4ad3238974ca2b5d
        from 2012 which introduced it does not include a unit test,
        so there is no easy way to test whether it still has any
        function.
        [Eliminating it passes all unit tests and sounds similar to
        tdf#108518 revert OOo hack: Fix issue #i119405: Numbering text style.]
        
        In any case, just revert the changes to this function for now,
        since hopelessly faulty functions don't need to operate "better".
        
        Another alternative would be to just use GetListlevel(pEntry)
        to at least allow style inheritance, but since it seems like
        a completely faulty function to begin with, it seems better to
        leave the function completely untouched.
        
        Change-Id: I2eba777fdd68615d68b63288005a30301fa6ea2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119521
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-26  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dd43ed8610f2d3e4c90d4bfd8a6ab3c736e5b4b8]

        Fix typos
        
        Change-Id: If0c2b0df62d2f307ceaef0ea961a0ff221ba5e65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119520
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-26  Miklos Vajna  <vmiklos@collabora.com>  [a21a2bbb1c6f6a9281783bb6818cddc9075fe7c5]

        sw bibliography, local copy: extend biblio.odb with a new column to store this
        
        A new LocalURL column at the end, similar to how the
        BibliographyDataField constant group was extended previously.
        
        Change-Id: I947ddcdc97fe0cef7f402ce03119c7f09435ba95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119509
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [b199d04da2df72e700bf7086ee637e1c2f5d6f58]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4373f58e837de5fe8ae2d0650da53fa881a83f1e
          - Fix example in SF_Array
            
            Change-Id: Ib52749668ada9c1b250cb0eb5f9c530808475fd2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119439
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-26  Attila Szűcs  <szucs.attila3@nisz.hu>  [d5d9795968771651c57c661d95b6992c3c778eca]

        tdf#142693 DOCX import: fix zeroing huge page sizes
        
        which bigger than 2^15 twips (> ~57.8 cm).
        
        Regression from commit 4d1621136c464b462a598571ecdcfe2ae119d8c7
        "Fix ignoring large twips values like MSO does (cp#1000087)".
        
        Note: Writer could export page size up to 600 cm × 600 cm,
        and now it can import it back as well. It can even import
        page sizes in kilometers, and display that, but there will
        be other issues about its display. MS Word couldn't save
        page size over 2^15, but can import, and display them till
        up to 2^16 (that is about 116 cm).
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Icc1bd708d53036768a7be94cb1ebe18c1c4c8487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118940
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [264d28183e40cf35fa8351dc15503276524973b8]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c292071ca8f8dece2bf5655038cdfd4899a09fa3
          - tdf#143489: Update Galician dictionaries to version 20.08
            
            Change-Id: I95b0064894a10a47e638568f85ddf5eb97ac345e
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/119372
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            Tested-by: Andras Timar <andras.timar@collabora.com>
            
2021-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [9cf1c5c8468d0e4974fe809455713a3e8f162822]

        jsdialog: sidebar: dump all panels
        
        Change-Id: Ifa547014f6857b0c1fbdce50cba745f1bee4e975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119500
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-26  Szymon Kłos  <szymon.klos@collabora.com>  [bd96480dab1313d62d8b58f2f6cb09ea03022cf7]

        jsdialog: weld Container
        
        Change-Id: I9516538cac8d2e42e0d029feaf84c3bc3a80151a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119499
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-26  Julien Nabet  <serval2412@yahoo.fr>  [97370902a77f403c569720f30b556eaf0a4b777c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e400fba16ad40d36f2feb5f05f7d90386f091e5d
          - Fix Duplicated entry. ID = par_id291613654389792
            
            Change-Id: I72ea44bd3d61b390ded1ccdaf4dd53d192d76dc5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119510
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-07-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [b67b3e2be0c80c3667ad2cb633e7e932d51d63a8]

        sw: use followby parameter of outline in Chapter field
        
        When Chapter field with format "Chapter number and name" is used
        it does not insert any delimiter between number and name. Best is
        to use outline/list property LabelFollowBy.
        
        But since it is done inside field we are limited with supported
        characters, so practically only space and nothing are correctly
        supported. Tab and newline are replaced by space.
        
        Change-Id: I4583b7051ae5ad963132980443fa70b5a19354e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119428
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-07-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [1da91cd552d29923ab7ea8027119ff5f62103d57]

        sw: undo/redo: change undo id for numbering
        
        Instead of "Reset attributes" new undo id is "Apply attributes". Seems
        less confusing when modified numbering rule is appled.
        
        Change-Id: I0bad38475363d6e0af01597271720d71aca7722c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119401
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-07-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [965636121cb1fb09739fcbca2c85f0a07bf6bf96]

        tdf#143483: sw field edit: improved selection of format
        
        During selection of used field format do this after list
        is initialized. Otherwise selection can be lost during
        further treelist filling.
        
        Removed ancient hack which was trying to select at least
        something in field format list: it is incorrect and does
        not cover all possible fields/formats. It is just hiding
        any potenial initialization problems.
        
        Change-Id: Ibbbdd1e9a3436fec37cc49c11e6e235e8afcf4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119341
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-07-26  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [d44730148a95933f4a45a70241cb6d1d0546f626]

        tdf#143424: support for "Chapter number without separator"
        
        If LO is using list format strings (this is default behavior since
        aa5c6d12) it was not able to show just numbering without all formatting,
        as it used in some fields.
        
        Change-Id: Ib4695b8e1c2d7a451522c7e04af2216d16aceefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119309
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2021-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [da9bba7cc3c243e936daea689fea64ecaf110f35]

        use officecfg for SvxHtmlOptions
        
        Change-Id: Ie7db7d20509e45fd87d8460c7fae6c0131e0a1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119494
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Miklos Vajna  <vmiklos@collabora.com>  [6e07c40577df013dc113310b7c2b76ee2b26e158]

        sw bibliography, local copy: finish UI in the Define Bibliography Entry dialog
        
        Add the missing page check-button/spin-button, so the local copy UI is
        on par with the URL one.
        
        Change-Id: I0387ead2ad3ccdf3e36710ae23bb5e2f02e02934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119497
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-26  Noel Grandin  <noelgrandin@gmail.com>  [6ed8c5a0f19901ab413c6610649326b2475c3a8c]

        use officecfg for security options
        
        Change-Id: I9d91fd5b260b82e05aac6567143386742953ecf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119486
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a23b44fd9f0119f7ea3523e32875f55c1a07c1cd]

        tdf#123626 Allow adding hyperlinks to shapes
        
        * Support hyperlinks on Shapes in Writer
        * Add menu items
        * Add context menu items
        * ODF import/export + test
        * OOXML import/export + test
        
        Change-Id: I7269064c4cabd16fdb8259a48429c508184d3ccf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119164
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-26  Tünde Tóth  <toth.tunde@nisz.hu>  [3c3b9ad8886da916027f0fb940a2df822d63d4d7]

        tdf#143220 XLSX export: fix hyperlink to sheet target
        
        Hyperlink to another sheet didn't work in Excel.
        
        Change-Id: Ic63e581d5de8f7ff1eac50a5e56a51d7ba2e72ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118935
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-26  Arnaud Versini  <arnaud.versini@libreoffice.org>  [057191fb50ea2ae9cca42ef84329581094047db8]

        cpputools : no need to use fprintf for putting a string
        
        Change-Id: Icb7f0930713d7c9fe2553913dbdc5e36617f856a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119128
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Luboš Luňák  <l.lunak@collabora.com>  [5d051f443bcd4b79041ef379bf032b76616f9ce2]

        build Skia also on Mac
        
        This only builds the library, without using it.
        
        Change-Id: I54e940bcaa61852b831dbe7ae5660a5daf5fe609
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119356
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-26  Luboš Luňák  <l.lunak@collabora.com>  [2fb06e18ae6fcf4813d98aa3fda0bcd1c9b9a7d0]

        add gbuild support for ObjC/C++ sources from tarballs
        
        Change-Id: I49632bf9dedf9603449fb5bc9e6a819586258b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119355
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [57ee7deddd0934dab58199cb1d0b95439e2ba6b3]

        UBSAN fix
        
        after
            commit 28993c0a8d8628c650b661767fd8ab2228c507d9
            Author: Noel Grandin <noelgrandin@gmail.com>
            Date:   Sun Jul 25 15:05:51 2021 +0200
            use officecfg for drawing options
        
        I had the IsAAPossibleOnThisSystem() check inverted, and I didn't quite
        translate the existing IsAntiAliasing()/SetAntAliasing() logic correctly
        
        Fixes CppunitTest_sc_jumbosheets_test failure noted at
            https://gerrit.libreoffice.org/c/core/+/119481/5#message-747bde6ad4bdcf90d2ff51e8daa03cb0189e6355
        
        Change-Id: I5408da2e46f1f68646a74bd674b164ccfafdeb71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119495
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [7458f19a254c799612795a0cddeb0910f71948d4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cd02ab17dec63054396dfddb675334f2963a533
          - Adapt SF_Array to the new method signature notation
            
            This patch updates the syntax and arguments in all methods according to the new notation used in other SF services. It also introduces the ImportFromCSVFile method to Python scripts.
            
            This patch also updates a few examples in Basic.
            
            Change-Id: Ib565f31ad13f5455ff1df260ec60cae5d8848cd9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119437
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-26  Miklos Vajna  <vmiklos@collabora.com>  [1cca6ad35e648ba7fa9a4b5814541c3525ef3a28]

        sw: prefix members of SwXMLTableColContext_Impl, SwXMLTableColumn_Impl, ...
        
        ... SwXMLTableItemMapper_Impl and SwXMLTextImportHelper
        
        See tdf#94879 for motivation.
        
        Change-Id: Iddb5f25ba54b877be494f915ae0ae2eebc3abb3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119491
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-26  Noel Grandin  <noelgrandin@gmail.com>  [6bb901a1282373e747fcca5deaa9dbe92488812c]

        use officecfg for default options
        
        Change-Id: I5241c21fa097c104f1131db61787191d019a5de4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119485
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Miklos Vajna  <vmiklos@collabora.com>  [5e93753ca60ac52f94f9adee5c6b55a2e9387750]

        sw bibliography, local copy: add initial UI / browse button
        
        The entry was working out of the box in the Define Bibliography Entry
        dialog, add the matching browse button as a start.
        
        Change-Id: I414079f0e52bd665a8e3fd8d1ef29f06847c6507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119493
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-26  Noel Grandin  <noelgrandin@gmail.com>  [4df98358135689e1d2600819c61c6b07d8c8a722]

        simplify SvtDynamicMenuOptions
        
        Change-Id: I8892b8a51fcecd84ea1fedcd71b6d1a2febabee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119484
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Kevin Suo  <suokunlong@126.com>  [2ee3d4076481262c1e3014dc9341cdf3d1922ff7]

        sdext.pdfimport: Restore to read font file for the determination...
        
        of font attributes, as suggested by Mike Kaganski in
        https://gerrit.libreoffice.org/c/core/+/118977.
        
        This partially reverts da59686672fd2bc98f8cb28d5f04dc978b50ac13
        but did some modification of the previous code with some
        explanationary comments.
        
        Change-Id: I224d9e717bf374a90f4834cbd9e11bf1138b41ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Noel Grandin  <noelgrandin@gmail.com>  [131759a3db51140c21594308ed99c71aa7aba43a]

        use officecfg for menu options
        
        Change-Id: I94c9cf310ed6975f158548913439445faf6d178f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119483
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [6e155959de6f46afbe0b68057200c3da822d81f9]

        indexing: search result locator to return the rect of the result
        
        Returns the rectangle(s) where the search result is located in the
        document.
        
        Change-Id: Ib2333584fbc460cc16b1bf205fc3d674a1c06957
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118668
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2a151d1d5bc055d5e0011460b6ec42ea9f34f880]

        vcl: bitmap::CreateFromData add option to reverse alpha (0xff - a)
        
        Change-Id: If69225f86afb315ad432789178188a66264ab3ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118669
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-25  Stephan Bergmann  <sbergman@redhat.com>  [3f88c646a911e4b25f4866eda75ac38b978c4fd0]

        Avoid some division by zero
        
        ...as seen when running under UBSan `instdir/program/soffice --headless
        --convert-to epub` of caolan/SIGSEGV-270412-142321-SIGSEGV-150412-121455-91.pptx
        from the crash-testing corpus
        
        Change-Id: I7ce0151689f90b8cba7cd86d053f327fdccc82d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119487
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [134f40136a9bea265d8f2fedfdb41a1e65d81b49]

        use officecfg to retrieve OdfDefaultVersion
        
        Change-Id: Id54b98d978965e7ce304b83d5eff7d6c844a41d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noelgrandin@gmail.com>  [28993c0a8d8628c650b661767fd8ab2228c507d9]

        use officecfg for drawing options
        
        Change-Id: Idba40d9816f29c0e4bc4a468b8c0a2cbb74d09d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119481
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [2b71e0683cf8a34aaddce3558b941ba62b1b4ec5]

        use officecfg to retrieve LoadUserSettings
        
        Change-Id: I9680c02207ff2d21785a20061b784066ead07a8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Caolán McNamara  <caolanm@redhat.com>  [5d83e940f7636050891f52929ace29650025cd36]

        ofz#36481 Timeout
        
        Change-Id: I0de9bf0a8b83af83ba31bdb75497e13ada4f7f4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [60fc68e547cf70f82e681c9a17b4f3e5c124aa39]

        use officecfg to retrieve UseUserData
        
        Change-Id: Ic77555520f2451b12c01423179d3f201daad35b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Caolán McNamara  <caolanm@redhat.com>  [1d2fb25e268838ccc23b264330b956f1c31f25dd]

        ofz#36537 Invalid-enum-value
        
        Change-Id: I39b8350766b3585424a6d247392a30c834d01fa3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119479
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [f4fc908d00bf1fb05cdca89cdfd2f0c3b83723eb]

        use officecfg to retrieve CreateBackup
        
        Change-Id: I4aeb1224f0d42dadd5a69dd49b8df9ee2f776b04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119471
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [293c1a629a69822b4a9996d0522513bc2a0d78e1]

        use officecfg to retrieve LoadDocumentPrinter
        
        Change-Id: Ie9c164fb9c95989035ef769d0dd539521400e38e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119463
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noelgrandin@gmail.com>  [c05adac9229aad0683d2e75a8f8dcd5421c66b02]

        use officecfg for print options
        
        Change-Id: I2a85d802b9edda638da467e273ad3d24cbf2bcf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [67e47070a7580a17804adce812cc2f98bfe7b51f]

        Fix typo
        
        Change-Id: I3439e53db44ec8aade2df96375ac89379a3bea5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119285
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [be683ad84960cad35299ed06b6b47691d90e2554]

        use officecfg to retrieve WarnAlienFormat
        
        Change-Id: Id7ca2ffa237cb8fda58af60ee5d296f492c5a47e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119462
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noelgrandin@gmail.com>  [9117fb44bc7bd6b8764911c731c84a9e5dcc37f0]

        use officecfg for help options
        
        Change-Id: I2d19541cff07bf8159715d8f32d771cbf201ece4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [d5b9283985633fdb423269cab961bba2acc3539e]

        use officecfg to retrieve AutoSaveTime
        
        Change-Id: I003be64cc46d6e781ab03d83bae0a3114ab6d56e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119460
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noelgrandin@gmail.com>  [84f4f7f99f92c0ecec0dd9d754fdfa8c652a7ec0]

        simplify SvFontSubst
        
        in the process, needed to expose some functionality in ConfigManager
        and ConfigItem, to avoid repeating code
        
        Change-Id: Ic0256a010070a79cd649dfd11267bec2f77e5221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119470
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [e192e1542a84b26cb0685860b84339019021de96]

        use officecfg to retrieve UserAutoSave
        
        Change-Id: I11f45c43bed9ea9a380026d84a91f48629dffac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119461
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [6f07012a344101f2afbf9c96dc7857127f39a25f]

        use officecfg to retrieve AutoSave
        
        Change-Id: I613ca68123cfd316cd4e6384f743aa6756d9291d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119459
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [d904a21d5516ce2786f634d0bcc555c4b345e95d]

        use officecfg to retrieve AutoSavePrompt
        
        Change-Id: I918e31064064664df7364d7c3093d3cefdb4067a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119458
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [86aa626bb1c211cd21232adeebf174189078e0ca]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36052eea4f7977303088774c3299a7c721ca2608
          - tdf#95394 Help: Bitmap -> Image
            
            Change-Id: I6faefd33fe3cded67bae3a2b7d4dc7ef790271cf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119469
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [966cc80a8f45816f727d4af036c2b58fb7d82d22]

        use officecfg to retrieve DocInfoSave
        
        Change-Id: I0a9e8b21b0c5937567273155cd5b5f773fe26b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119457
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Julien Nabet  <serval2412@yahoo.fr>  [d8beefc5d351d636842d07ef3c36c4bb2f6799a6]

        tdf#143528 Use triple backquotes+xml to markdown xml part in oox/README.md
        
        Change-Id: Iee9fb4beb898f9c9fb7e95433b7aa5ff2b614742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119468
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9d340a32104c01b15d901e6328641223c74d55dd]

        Fix typo
        
        Change-Id: Ia9f0965a26defed4d68cb4fdce82ca860d36bd29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119398
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5c3128f5e65a1c1c2dd41b6d45fc59012c9d3f91]

        Fix typo
        
        Change-Id: I3b564e59f980cb6011d6a6ab5ddd143ee2a28d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119453
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-24  Andrea Gelmini  <andrea.gelmini@gelma.net>  [dbffbafe12ae2e2b3151c969496c16f7db7bca7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 65c742c487136afeb38c6d5352ba35a1d88194c4
          - Fix typo
            
            Change-Id: I6edfb252552d59aef329e071e41aa609b6339cc7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119452
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [8690061b7d2d7c50ba96b40af4c4549fd9378b80]

        use officecfg to retrieve SaveWorkingSet
        
        Change-Id: I9f4e4c2caffa828670ddedb1c6fc324e28162b9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119456
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [10277e2be5b132ea52a64ed987c23050ac74d18c]

        use officecfg to retrieve SaveRelInet
        
        Change-Id: Ife062fabdfc95253c71388ca9594b1530bc40783
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119455
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Huilin  <lynntang12138@gmail.com>  [c5dcf48789d705d1b842e45d7c22cb38e477307c]

        tdf#143148: Use pragma once instead of include guards
        
        Change-Id: I5ac5ac09474b9e05b17a9c5b191ab2808eca2660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119431
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-24  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [20c2d7deaab20deb6970cab563d4c7d88fefa53f]

        tdf#95394 ToTD: Bitmap -> Image
        
        Change-Id: Ifc0ae0719b30086febf9a203d70a55da837135f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119467
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [095e3ac51eaae12da641018e889d79e3ae029038]

        use officecfg to retrieve SaveRelFSys
        
        Change-Id: If4e943153080e1c8fea02e712038dd6dee92c5a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119454
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Andrzej Hunt  <andrzej@ahunt.org>  [4e511cc7dfbf14b6176ce352db8125c16eefeebf]

        sdremote: remove useless comment
        
        It's been there since the beginning, but doesn't help us much:
          e4239e041468 (Initial checkin of remote control., 2012-07-09)
        
        Change-Id: I57425001cd0b9d0d035916405bd6d94329964b4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119466
        Tested-by: Jenkins
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>

2021-07-24  dante  <dante19031999@gmail.com>  [2d9ca45e0e785fde968328cb44d40cd3dc113941]

        Addition of OpenSymbol2
        
        Remaining lines have been uploaded via amend.
        The other day was discussed in the IRC chat if OpenSymbol was actually removable. The actual problem with open symbol is that there are too many characters missing characters and it supposes a ballast for starmath.
        This responds to: Bug tdf#134214
        Some of the problems caused by this are WON'T FIX: mathhbb, fractur, setp tdf#49990 and much more.
        However replacing the font was actually impossible. If changed the layouts old documents may break. For that reason the new font had to support what already was implemented in a way it won't change the layout: the old symbols had to be conservated.
        Result: we are creating a new font, containing opensymbol just for personal use of starmath module.
        For now the changes with opensymbol are:
          - Reencoded as ISO 10466-1 ( unicode32 full ) with fontforge.
          - Added quadruple integral with fontforge.
          - Do not use it outside starmath. Changes will be made in private chars area. IT MAY BREAK.
        In order to complete it, characters from anothers fonts will be added. For now the best option is libertinus math. This font final name might end beeing something like LO Libertinus math.
        I have already contacted the maintainer in order to get permission and waiting for answer. In case of no will look for other fonts.
        The other option would be to make opensymbol2 a subproduct of libertinus because:
        
        2) Original or Modified Versions of the Font Software may be bundled,
        redistributed and/or sold with any software, provided that each copy
        contains the above copyright notice and this license. These can be
        included either as stand-alone text files, human-readable headers or
        in the appropriate machine-readable metadata fields within text or
        binary files as long as those fields can be easily viewed by the user.
        
        Change-Id: Ia33a0181b0d28b65680d8df9ffa3d0c37078df18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105769
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e89b710c05cd1774072575330623cb5c6b2650f]

        fix incorrect read-only check in save options
        
        ever since
            commit 14171010959a4ebf0f6373b6e7f20d1f0741d5a4
            Date:   Sat Nov 26 17:00:43 2016 +0100
        respect read-only config items in Options - Load/Save - General
        dialog
        
        Change-Id: Ib830fbee23a06e8788c9916f8d5a923139540e8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119465
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [cde00e11db2f273f4027780a4f66e40ec7c598e1]

        use officecfg to retrieve offlinehelppopup
        
        Change-Id: I2441dc1c508ceb4805a98b7e45863bbda4af0b18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [e271fce82e16359394fdeb818c2ec25a07532a8d]

        use officecfg to retrieve PrettyPrinting
        
        Change-Id: Ia815acdb8050316293e23801d3ed5bfbeb3ab386
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119417
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-24  Andrzej Hunt  <andrzej@ahunt.org>  [2855f12072023930a15ea852e40d05de4a6be164]

        sdremote: close BufferedStreamSocket on destruction
        
        This follows the pattern in osl::Socket which also cleans up on
        destruction if necessary.
        
        By closing on destruction we can avoid leaking the underlying socket or
        filedescriptor in the numerous scenarios where we throw away the socket
        without bothering to call close(). This isn't a big deal in normal
        usage - we don't use many sockets in the first place - but you can
        quickly run out of filedescriptors when running sufficiently complex
        tests.
        
        We also need to make BufferedStreamSocket final to avoid triggering
        loplugin:fragiledestructor - BufferedStreamSocket probably should
        have been final anyway, so there's no reason not to do so.
        
        Change-Id: I90c271df4b598a6c2b326fde13543e6b27d7a110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119093
        Tested-by: Jenkins
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>

2021-07-24  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [77a192aa016279acc0b0f9df584d1ce31bde41a4]

        sw: define to constexpr, use MM50 from svx and use o3tl::convert
        
        MM50 is a constant representing 0.5cm in twips. Use o3tl::convert
        for to init the constant instead. It matches the constant which I
        checked with a static_assert.
        
        Change-Id: Ib6c37a44ef5b22258e913fd3809a37ab0d18671b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119396
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-23  Julien Nabet  <serval2412@yahoo.fr>  [cb2827f5f65324f309fa0e3c30d0b19ad237410e]

        Fix SvtHelpOptions_Impl::GetPropertyNames (svtools)
        
        Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=ba4f191300779cbd9e536d11c02895541fef24be
        use officecfg to retrieve help system
        
        Change-Id: Id42c5ee06d2231dc690a4f6f81eecddb0b1a2073
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119429
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [04389e2e5563ae5d771a78e439dfe7ccdcd8b904]

        use officecfg to retrieve SaveDocView
        
        Change-Id: I1a758137000359d2448f8c5877d7b2e75f3869b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7a7f2b237d9b64399d97fd776f343e9ee35d1b2]

        use officecfg to retrieve help stylesheet
        
        Change-Id: If2a233d44315a2d263671468e4671e0996d315d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119414
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Mike Kaganski  <mike.kaganski@collabora.com>  [64a55fe5f457e4b3d5222deb560f6d5072696160]

        tdf#143515: avoid memory leak in ScDrawLayer::DeleteObjectsInArea
        
        ... and in ScDrawLayer::DeleteObjectsInSelection.
        We are calling SdrObjList::RemoveObject, which orphans the object.
        Let the undo object own the SdrObject, and dispose it when needed.
        
        Was that way ever since d0484bcdcbffd42d242647a2fdc1a203d176b775
        "initial import".
        
        Change-Id: I5f2cb9d8ed0e02d45d2699af4a228c7fd097008c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119435
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ba4f191300779cbd9e536d11c02895541fef24be]

        use officecfg to retrieve help system
        
        Change-Id: I09f7a3a91ed63bab28c20984fa80d4d392e9d092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119413
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [05773428c51c82a365e16589a1f8ca45823c6403]

        use officecfg to retrieve GetIsForPagePreviews
        
        Change-Id: I9c7666a4456821e3a2051c8d645183f4e1c5eb55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119412
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Mike Kaganski  <mike.kaganski@collabora.com>  [6362c905cf19f2f6cb67bf634091b14c2a8e90ec]

        tdf#143514: Avoid double-free in dbgutil code
        
        SdrObject::Free may start a chain of deletions, removing more
        than one object from maAllIncarnatedObjects. Trying to free
        them for the second time after that would lead to crash.
        
        Change-Id: I8648b05d167acecb2799ecf165c387721528a11a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119433
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-23  Mike Kaganski  <mike.kaganski@collabora.com>  [51371d7e652366b3967d1b5ab6b6217d1ade78d2]

        Use vector instead of unique_ptr
        
        Change-Id: Iea1fb26d9e176283a96d6f0d18dae5b58e55602e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119432
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-23  Jean-Pierre Ledure  <jp@ledure.be>  [1908717ff7610ab57bd19b4225571637ecad11a3]

        ScriptForge - Change copyright dates and names
        
        Change-Id: Iac45dca972c294ed3772bcdcd0b3f05484ce912a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119418
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-23  László Németh  <nemeth@numbertext.org>  [7f3c0bbc174b9b0316991c174ca3b407c0e3d141]

        tdf#143510 DOCX import: fix tracked table drag & drop
        
        Accept or reject of tracked drag & drop table (row)
        move weren't handled, resulting an extra empty table
        (rows) instead of removing the deleted or inserted
        table (rows).
        
        Note: tables moved by drag & drop with track changes use
        w:moveFromRangeStart/End and w:moveToRangeStart/End
        bookmark-like elements to sign the boundary of the
        moved text. Now moveFrom/moveTo import is handled by
        tracked table (row) deletion and insertion.
        
        Change-Id: Ie382645fef28f57b30d3504fb28ac08489f705c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119406
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [12a184c3fd96a4f64f5926e78a0da321f71c3d07]

        uitest: sw: Add comment about how the test would have failed
        
        Change-Id: I249f3f3672c2770b516d704b74146ea017af528a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119409
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-23  Regina Henschel  <rb.henschel@t-online.de>  [17cfd3d3e2e6f807eb1faf07436c7e96e15157a7]

        tdf#143455 exclude diagram from pos and margin adaptions
        
        The current implementation of diagram (SmartArt) uses a SdrGroupObj,
        but it is actually not a group of the diagram parts. Currently the
        group's object list contains only one, dummy object. Therefore it
        works not well with the code parts used for groups.
        
        Because we will have (hopefully) the tender 'Dynamic Diagram feature'
        I have done nothing on diagrams, but as workaround only excluded
        diagrams from these code parts. That way the rendering is same as
        in LO 7.1.
        
        This part of code needs to be touched again, when diagrams are
        implemented in a different way.
        
        Change-Id: Ife4bb495c96fb1dd57663f28409dc2bb456282ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119344
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-23  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [9b09e862558caf1aa6c71b11c8f4b7f873c12b7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6797558a82f83a50b469f38897ffe3b04218cb45
          - Help: tdf#140107 drop usage data; tdf#107471 describe crash reports
            
            Change-Id: Iebcdc8bff69b6194a6fc73347635c83d005b894e
            
2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [44f32fc9c1cf95c77b725a4aa0ab405330135ad6]

        use officecfg to retrieve SidebarIconSize
        
        Change-Id: Id1cc4b8e3e28d942b44deacafbc514bbcd95874c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119411
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Michael Stahl  <michael.stahl@allotropia.de>  [44cc59db6f4f4f8b2ce5c993a31b5a019a8d7e97]

        sw: layout: fix red triangle problem with text frame in sections
        
        First, a document is loaded, then about 4 pages of content are pasted into
        it, in about 6 paste operations.
        
        In an idle layout action, a page's worth of content moves forward; the
        text frame at the bottom was split previously, and is joined.
        
        The follow has the same upper as the master text frame, so this causes
        the upper section frame to shrink:
        
         SwRect::operator=(const SwRect & rRect) Zeile 256
         SwFrameAreaDefinition::FrameAreaWriteAccess::~FrameAreaWriteAccess() Zeile 112
         SwSectionFrame::Shrink_(__int64 nDist, bool bTst) Zeile 2327
         SwFrame::Shrink(__int64 nDist, bool bTst, bool bInfo) Zeile 1562
         SwContentFrame::Cut() Zeile 1339
         SwTextFrame::JoinFrame() Zeile 677
         SwContentFrame::MakeAll(OutputDevice * __formal) Zeile 1310
        
        The ToMaximize(false) check doesn't help because the section frame
        doesn't have a follow (or footnotes).
        
        Then the text frame is formatted, resulting in one line but no height
        for it, and a split after the one line.
        
        The split causes a follow section frame to be created, calling
        SwSectionFrame::SimpleFormat() on the master's upper:
        
         SwFrameAreaDefinition::FramePrintAreaWriteAccess::~FramePrintAreaWriteAccess() Zeile 120
         SwFrame::SetTopBottomMargins(__int64 nTop, __int64 nBot) Zeile 175
         SwRectFnSet::SetYMargins(SwFrame & rFrame, __int64 nTop, __int64 nBottom) Zeile 1405
         SwSectionFrame::SimpleFormat() Zeile 1192
         SwSectionFrame::SwSectionFrame(SwSectionFrame & rSect, bool bMaster) Zeile 110
         SwFrame::GetNextSctLeaf(MakePageType eMakePage) Zeile 1781
         SwFrame::GetLeaf(MakePageType eMakePage, bool bFwd) Zeile 879
         SwFlowFrame::MoveFwd(bool bMakePage, bool bPageBreak, bool bMoveAlways) Zeile 1977
         SwContentFrame::MakeAll(OutputDevice * __formal) Zeile 1349
         SwFrame::PrepareMake(OutputDevice * pRenderContext) Zeile 286
         SwFrame::Calc(OutputDevice * pRenderContext) Zeile 1794
         SwTextFrame::CalcFollow(o3tl::strong_int<long,Tag_TextFrameIndex> nTextOfst) Zeile 281
         SwTextFrame::AdjustFollow_(SwTextFormatter & rLine, o3tl::strong_int<long,Tag_TextFrameIndex> nOffset, o3tl::strong_int<long,Tag_TextFrameIndex> nEnd, const unsigned char nMode) Zeile 608
        
        Now the upper has space but at this point the master text frame is valid
        and not invalidated, so it never grows into the available space.
        
        There is a check to format again in case additional space is available
        in SwTextFrame::CalcFollow() but peculiarly it's disabled if the upper
        is a section frame since initial CVS import.
        
        Removing this check appears to fix the problem.
        
        Change-Id: Ifad545f7e79675af6e33d68c7fcdbc82bd4f8f57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119419
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-23  Mike Kaganski  <mike.kaganski@collabora.com>  [612d5b1a04fe022a34018d901bb9b052791d54e5]

        We already have this value
        
        Change-Id: I1d94986acaa9bcd559e34ba1af880c4a06772c38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119271
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [afff3bf81f1908b2d4a7068b4862fd1f19440383]

        use officecfg to retrieve NotebookbarIconSize
        
        Change-Id: I1e76e8369b4a0448a62cd72bc9a1ee492fae91b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Miklos Vajna  <vmiklos@collabora.com>  [ee3d408fd6c909556d1671d28591cde4c0122979]

        sw bibliography, local copy: add ODF filter
        
        Map it to <text:bibliography-mark loext:local-url="...">.
        
        Note how this can be a relative URL, while the text:url attribute is
        typically a http(s) URL.
        
        Change-Id: If16171c9761221841ff07824cb0466fd42911480
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119407
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-23  Stephan Bergmann  <sbergman@redhat.com>  [daffec714ef28f52ae2d70e5553500046b8b26c2]

        Avoid strtol on non-NUL-terminated input
        
        ...as could be observed with ASan and ASAN_OPTIONS=strict_string_checks=1 during
        e.g. UITest_conditional_format.
        
        strtol supports leading spaces, sign, and "0x", but none of that appears to be
        relevant here, so readInt32 doesn't support that.
        
        Hdf::m_pItData was redundant and always pointed at m_aItData.data(), and has
        been elided to make it more obvious that the places that used it, which now also
        need to use m_aItData.size(), actually use m_aItData.
        
        Change-Id: I3d4f625cd5836438271d7c1a8d2ae06f0a45a37c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119403
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [252e403213bf2a1c1b1f7b07f1dd647b450cb312]

        use officecfg to retrieve DisableUICustomization
        
        Change-Id: I87b3019c8e10eb2453746340beea4c4623dc65e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Jeff Huang  <jeff@mail.ossii.com.tw>  [2c0b84dc65739bfc47dca684e819717eb9cce387]

        tdf#140107 Remove all collect usage data code.
        
        Remove all collect usage data code because we
        don't really use them.
        
        Change-Id: I8d83d57220bed8f8c15bd012584943cd0913500d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119166
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-23  Stephan Bergmann  <sbergman@redhat.com>  [badc5a7ac8dda3c7b991c671776d2d41a5b7ea26]

        -Werror=maybe-uninitialized
        
        (at least with recent GCC 12 trunk and --enable-dbgutil --enable-optimized)
        
        Change-Id: Ie16260267b70c9e887c0342a09875e8d0a6a5eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119402
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [27bb16a920d461f25d9ea69a0b515f6b85aff5b6]

        sw: get rid of MmToTwips function and use o3tl::convert instead
        
        It's used in 1! place only (but could be others have been coverted
        already).
        
        Change-Id: I6ba9dbaf00afe7662321fa202eaaaa652d16e0b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119395
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [590f67e0c746aacca30a80da8de1956dbc0d8768]

        expand out contractions in PasswordContainer
        
        Change-Id: I884356fe9f0081b13dfd47c1ecbd581adf25ebd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119387
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [2b2374c963bc660d8866bc17f701046ac0a03a3c]

        simplify AsynchronLink
        
        Change-Id: Ia13e256fcd0f332c4509ea4a9b47e1b050b56443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [0de7513cd73f1f35265e42f9a2b9befe81302c2c]

        osl::Mutex->std::mutex in AsynchronLink
        
        and inline the mutex since the only two users of this class both
        want the mutex
        
        Change-Id: I7821d67ad77e08059ef2fe6ccc6cc06570e8070b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e512171c21a193027c35d19a5273507a2725596]

        no need to allocate these static vars on demand
        
        the constructor can be laid out at compile/link time
        
        Change-Id: I377a537e15199ae81394d76ac662576280a25c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119362
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Stephan Bergmann  <sbergman@redhat.com>  [58ddacdb4be78dd00e05a46459ed0bcbe7531632]

        loplugin:noexceptmove (macOS, libc++)
        
        Change-Id: Ic587957fe0bf871b587375a68758a537de910de5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119399
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-23  Collabora  <l.lunak@collabora.com>  [2d04d7cc559445d8c1559af6af6d981d9f682db4]

        do not use "using namespace std" in headers
        
        It's a bad style, doing that in headers can affect many source files
        (especially with PCH used).
        
        Change-Id: Ic9091a1d018e74606c9fa95df71a55faaa93d4ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119011
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-23  Collabora  <l.lunak@collabora.com>  [a470d97f2ddcb3607ae9d1df871a59f04d823564]

        workaround accumulate() ambiguity on Mac with PCH
        
        The PCH brings in <numeric>, which has std::accumulate(), which also
        gets considered for whatever reason.
        
        Change-Id: I69f375c871034e156598c8886822279f78c7f73f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119010
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-23  Collabora  <l.lunak@collabora.com>  [6192fca42aec2db25f6dade632fd0e50eded5d0e]

        workaround for apple clang sometimes not generating PCH
        
        Change-Id: I50a215e0cf3bf7f6f6d6dc86cf89355e2de19c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119009
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-23  Rafael Lima  <rafael.palma.lima@gmail.com>  [6031dfd615373ad3ed8086a8da0cba3251a51cc6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a1682e126278705cad6bf437f0237474234aaa86
          - Python examples in SF_TextStream help page
            
            Change-Id: Ibd1ea64557c97511b7c15944344b3d92e1dd2cca
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119258
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [ff61ec1ef2e408bb758bbce91d0d1840ef2b2883]

        osl::Mutex->std::mutex in AsyncEventNotifier
        
        and use a vector instead of a deque, becuase then a std::swap makes a nice
        way of ping-ponging a data buffer back and forth between the
        producer and consumer sides
        
        Change-Id: I11f491b9fde87f0a495df05d306ccee57dcfc6da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [19d01fae16f4f7b46c168b983960547f4dd2c2aa]

        no need to allocate the StorageItem separately
        
        Change-Id: I941404fcc2ded3568afe4818c4851a1bd72e30b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119386
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [2d98ee5f14a3343a9103771861d26920a7109b30]

        osl::Mutex->std::mutex in ValueItemAcc
        
        Change-Id: I8b0315b9e496b930bf312d7d2565727777c70985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119389
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [1fd35c6d0058e33694721a962f1fe5c0489d4336]

        remove pimpl from ScZoomSlider
        
        Change-Id: I446a73b3a07818927b69d93cfc41bca12858b169
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Noel Grandin  <noelgrandin@gmail.com>  [da340c48ecd67e1b97546842dae013306caa6ace]

        osl::Mutex->std::mutex in SvtLanguageOptions
        
        Change-Id: I5b24c729f63f2f51b2a2bebc8539e8c61cf77bee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119388
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-23  Miklos Vajna  <vmiklos@collabora.com>  [240bb9e223a7c22c02e8821d47f15b793f02e5a1]

        sw: handle mbStylesNoDefault when replacing compat options
        
        This is off by default and it may be in for Word documents.
        
        Change-Id: I5f350f42d795c4272e8b11fcc28a65265eff7243
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119381
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-22  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [ee5a1b61b4460b965413a3f7ed4f9152322f1c02]

        Fix subtle grammar error
        
        Change-Id: I566b7c8af667f646fee88e47b97acf24d2e70112

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [71477a3be1c64e5351894d9ef797feeee6b9eeeb]

        OPropertySet doesn't need a pimpl
        
        also inline some of the standalone lambda/functor classes
        
        Change-Id: I0a19a1d3cb7f5b3d02348f1ab57bae08b3ab089a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [66578750d187d6ec048889ba6aca2e2decd07225]

        no need for pimpl in ObjectHierarchy
        
        also convert some methods to return
            const tChildContainer &
        instead of copying a container
        
        Change-Id: Ie56451a7ee2b8ac25f21b781b97b0c7fe485b940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Luboš Luňák  <l.lunak@collabora.com>  [2f961c7a811bdff66a94c20573798d58b565195a]

        do not use delayed layout in TitledDockingWindow
        
        The layout is only performed in Paint(), so if something uses
        geometry before that happens (may happen with tiled rendering),
        then is not up to date. I don't see why delay it anyway, there
        seems to be usually just one resize, and only during init I see
        two of them, which can presumably be fixed if needed.
        
        Change-Id: I7133f3c6be41bc6480f86d1053b455d42c40b9ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116529
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-22  Luboš Luňák  <l.lunak@collabora.com>  [3bbe38a60b4a9ae50b59e41a02292e639ec28c09]

        set size properly when setting embed size from fallback graphic
        
        When loading e.g. OLE from ReqIF, the file contains object tag
        for the OLE and then as a fallback also an image. This loading
        code apparently sets the OLE geometry to the same as the image,
        for whatever reason, but if that's to be done, at least do it
        consistently, the same way it's done when reading the OLE. Otherwise
        e.g. relative width is ignored.
        
        Change-Id: Ifeafaefa4274db9ddffc6ff16210f7ecc2301a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117464
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [55d47fd99c673ecb9830e9a60c55a3cc0d008b28]

        Revert "simplify locking in configmgr"
        
        This reverts commit 7f7dad7018c874542e0ab6a0fb0f05f21d112b53.
        
        And add some comments to the definition of the lock, to make
        it purpose obvious.
        
        Change-Id: Ib1a0b6345efab0febe9191341ce264c8d6070932
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119366
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noelgrandin@gmail.com>  [9ca9d364581e64b8e7ba9b4cd8d745ba22b2a2d8]

        osl::Mutex->std::mutex in StatusIndicatorFactory
        
        Change-Id: I23c6765e5932288ce439273c600bdbf5017266ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ae3c5ef23b8b91c97cfe99adbcd831ee34f9dbf3]

        Fix typos
        
        Change-Id: I38c7fda55f7d24f7265b58d56222187f2aa1e5d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119286
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-07-22  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [80a1c6ea4771cd9620addde2640d3c4d6276a5de]

        elementary tdf#143300 add diagonal border line icons
        
        Change-Id: I5379c2a27d792c9f9e62ddf624fd85fde2243786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118882
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-07-22  haru-02  <rahulbalaji78@gmail.com>  [8580f2d5c8fef0c3c3ff1e92da09e13ec2158bea]

        tdf#95394 - ui fill dialog from (bitmap -> image)
        
        Change-Id: Ib30eb0489e8cad2d417bc8638204b95f4acee936
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119115
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-22  Jan-Marek Glogowski  <glogow@fbihome.de>  [22997c4777eeb424493d1259b72db9a15ff37069]

        tdf#143493 Qt5 key modifier events don't have text
        
        Regression from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747
        ("tdf#143298 Qt5 send SalEvent::KeyModChange events").
        
        Change-Id: I6981af06e3a73dee45ed10416f5d3b17b860a73b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119375
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1296ded169adaa93d943eeb0273bf16835f7eb35]

        fix the mutex locking in impl_searchTopic
        
        you cannot take a pointer to something inside a guard and then use that
        data outside the guard.
        
        So remove the broken locking here, and make sure the call sites hold the
        lock.
        
        Change-Id: I37cc363ff937243d7965844e8bcda0018085c656
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Michael Weghorn  <m.weghorn@posteo.de>  [0f15f1ec7c7b9ed7abf4a40b9b9c2f3876ce3e5f]

        qt5 a11y: Always query the XAccessibleContext for a11y interfaces
        
        The accessibility interfaces are implemented by the object
        implementing 'XAccessibilityContext' which is often the same
        as the 'XAccessible' (in which case the corresponding
        'XAccessible::getAccessibleContext()' call just returns a
        reference to self), but it doesn't have to be that way.
        
        From offapi/com/sun/star/modules.idl:
        
        >     /** UNO Accessibility API
        >
        >         <p>This modules contains the basic interfaces of the UAA (UNO
        >         Accessibility API).  Services that describe how these interfaces are
        >         implemented can be found in other modules.  The services in this module
        >         describe only what every accessible object has to support.</p>
        >
        >         <p>Making a class accessible starts by supporting the
        >         ::com::sun::star::accessibility::XAccessible interface.
        >         This interface's only method returns the actual accessibility object, an
        >         instance of ::com::sun::star::accessibility::XAccessibleContext.
        >         These two interfaces may be implemented by the same class in which case
        >         a call to ::com::sun::star::accessibility::XAccessible getAccessible()
        >         returns the same object that is
        >         called.  Alternatively the implementation of the
        >         ::com::sun::star::accessibility::XAccessibleContext
        >         interface can be done by another class.  This makes it possible to put
        >         all accessibility implementations into their own library which has only
        >         to be loaded when necessary.</p>
        >
        >         <p>Note that all other interfaces have to be implemented by the same
        >         class that implements the
        >         ::com::sun::star::accessibility::XAccessibleContext
        >         interface.  Note also that there is no way back from an accessibility
        >         object to the object from which it has been obtained by means of the
        >         UAA.  If you need such a back-link you have to provide one on your
        >         own.</p>
        >     */
        >     module accessibility {};
        
        This e.g. makes Accerciser show the correct values of the "URL" and
        "Text" controls in Writer's "Insert" -> "Hyperlink" dialog.
        
        Change-Id: I909b1fdf5e1e7ca50db5d5191ae69cb558a49dc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119364
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-22  Michael Weghorn  <m.weghorn@posteo.de>  [b216a87d7a0956cbb864e73ec4fc5557ae93f64b]

        qt5 a11y: Improve Qt5AccessibleWidget::attributes
        
        * handle case where out params are nullptr
        * set fallback values for out params at the beginning
        
        This e.g. makes Accerciser show '-1' for both,
        startIndex and endIndex for the text interface of the
        "URL" and "Text" controls in Writer's "Insert" -> "Hyperlink" dialog
        along with no text. Making the actual text show up
        if there is any will be handled in an upcoming commit.
        
        Change-Id: Ie864f729ad06e28684bd426e4ba37b8a9d4d4634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119363
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-22  Miklos Vajna  <vmiklos@collabora.com>  [3957ffb88f9856f2288b5f390609207b2e9c4c2b]

        sw: document SwArrowPortion
        
        One would assume it's just a painted indicator, but no, it has its own
        portion.
        
        Change-Id: Iddd93541766cb13600a978465937b1ef7d7e6200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119374
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [d1cbd25ebcf90b3302497987c0cf4a0b15163121]

        Make static_casting to the only derived class less verbose
        
        ... and assert on correct derived type in debug builds.
        
        Change-Id: Iedd37b3ad4139ab1eb1a0a321e3ebd0018ecde99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119360
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-22  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [689b5a4862ead541e54e83cb14067cfaa691e2ab]

        tdf#143244 sw: fix redo of adding table rows breaks table style
        
        This fixes a bug, which caused the break of table style when redo of inserting table rows, Normally, upon inserting a row, the formatting of the table is updated by the UpdateTableStyleFormatting() function.
        In certain situations (e.g in the description of the bug) this update wasn't successful. This was beacuse, the update function didn't know which tableNode needs to be updated.
        As the proper tableNode we need is already calculated in the SwTable::InsertRow function, we simply had to pass this argument too.
        
        Change-Id: I81ebd7bb37eebc9be8974f3f7a1adc5ad4ba1e7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119249
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-22  Sabyasachi Bhoi  <sabyabhoi@gmail.com>  [cf717f6d41dd3a2a582ee1478e83c281b18b9c3f]

        tdf#143148: Use pragma once instead of include guards
        
        Replace include guards with pragma once in header file
        
        Change-Id: I8f845a3eb563ab3e6d5ce57b3b411a46bce54889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119368
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-22  Miklos Vajna  <vmiklos@collabora.com>  [b85becd0d427c7375f1d8e6309f348304b6ebbac]

        sw bibliography, local copy: add context menu
        
        This way in case a bibliography entry (field) has both a URL and a
        LocalURL, it is possible to choose which one should be opened when the
        context menu is used on the field. This is meant to be the primary way
        the user consumes this information.
        
        Change-Id: I21b72505f8387943424665bff70905f774771d4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119373
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ea426bfa978d338683bf4c715d358187a527ccd]

        no need to allocate the error separately in GraphicFilter
        
        Change-Id: I26c43cb72580d9cc384b3c4b70e43f47d3db0198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119367
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [d1099ec6220e098b9d7e263c9b7f873997ea9e30]

        tdf#124708: sd_uiimpress: Add unittest
        
        Change-Id: I31544dfbec9cfb60fbf8ef2e5859e9c7f3efb1a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1de326b0b2a1208969e36f19010fdd8ee2a4fb7]

        no need to use unique_ptr here
        
        for such a small object
        
        Change-Id: Idbcad7469b3871c05226e90b8d46223fe746cce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Julien Nabet  <serval2412@yahoo.fr>  [717ec99667f5a9ab570f1c8581e2d7a0241c32f6]

        tdf#143464: fix SmartTag management
        
        by putting back missing information in lcl_FillRecognizerData
        
        Regression from e98711c14db9348f4d3f7d0f5bbde9276a3e73bc
        loplugin:unusedfields in sw (2018-12-12)
        
        Change-Id: I2e99df1a712915851c30c018a1f7279756da72de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119346
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1400274aa4157fd92e708324a46d1633723f00fe]

        osl::Mutex->std::mutex in GraphicFilter
        
        Change-Id: Ia7d81ad0eaeab4f6ecf89b555da26e42a27bf80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [a9bba3827888b290c435a3b0e5cdf50846d08bd2]

        Simplify EditTextObject's pool initialization
        
        Old scheme (ever since commit fd069bee7e57ad529c3c0974559fd2d84ec3151a
        "initial import") was that when source EditTextObject was owner of the
        pool, the copy created a new pool; and when source was not owner, the
        copy just re-used existing pool.
        
        It made no sense since commit 1545949690c750d7b512000723b564e69cf3c3a6
        where pools were made ref-counted using rtl::Reference.
        
        This also simplifies the only place which used the EditTextObject ctor
        taking pool by making the related ctor to take all necessary arguments
        instead of calling setters after constructing the object, which allows
        to drop a couple of setters.
        
        Change-Id: I843e154dd57f33f7c037063b4a0fcc0ac5a33cd2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119358
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [da2746382a4e02d1cf88d72ec51f24c86230e295]

        BinTextObject was renamed to EditTextObject long ago
        
        ... so update comments accordingly
        
        Change-Id: I5fe423c510912dc3bc3e113afcd5c5daaba3d717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119357
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-22  Jean-Pierre Ledure  <jp@ledure.be>  [2d7c0af3c36c6613e4028ed44484f5f021f85deb]

        ScriptForge - (scriptforge.py/CreateScriptService) allow keyword arguments
        
        For Python scripts only:
        
        the CreateScriptService() method accepts now both positional
        (as before) and keyword arguments.
        
        The impacted services are:
        - l10n
        - timer
        
        Done with the ReviewServiceArgs() class method that returns the
        input arguments as a tuple in the correct sequence. This method
        is inserted in each of the impacted service definitions.
        
        Implied a review of the creation of the L10N service to
        replace absent arguments by zero-length default arguments
        
        Change-Id: I3cc3b98847a395a2fd9f5e5bb15f45b398858b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119359
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-22  Noel Grandin  <noelgrandin@gmail.com>  [7f7dad7018c874542e0ab6a0fb0f05f21d112b53]

        simplify locking in configmgr
        
        if we are going to have a shared lock, just use the instance of the
        shared lock instead of taking a shared_ptr to it.
        
        Change-Id: I00f74815426fcf971ff8e12734fc4566aa6ad5f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119343
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [bebb1a3f2dc3e131f95a078f8a9c40d0491af7cd]

        pass SvXMLNamespaceMap around by value
        
        in SvXMLImport.
        
        Remove an assert in XSecParser because std::move on std::optional
        does not make the optional empty, unlike it's effect on std::unique_ptr.
        
        Change-Id: Ie94d01423bf694a37e4bd7f2c0235c5f79a44efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119302
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [88c85c8aa377ccc017582d8a08e5f73391b5a446]

        flatten vcl::LazyDelete
        
        we can allocate the stored value in-line and avoid some pointer-chasing
        
        Change-Id: I828814b127923cdcec1bf57b3b64dffab4cffaaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119298
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Armin Le Grand (Allotropia)  <Armin.Le.Grand@me.com>  [0bac5c7e7d71658c5056c4bf0b71fbfb51b92ca0]

        tdf#139426 Supress AssertFlyPages in Tabe re-layout
        
        The current code tries to on-demand create content in
        form of a SwBodyFrame at a SwPageFrame. That
        unexpectedly and unfortunately leads - when done
        during a Table re-layout action - to an endless
        layout loop.
        I tried quite some solutions, but the simplest and
        safest is to just supress AssertFlyPages in that
        specialized TableLayout. Other solutons may break
        MailMergse, so CppunitTest_sw_mailmerge needs to
        be checked with any fix in this area.
        
        For more details, see tdf#task comnments.
        
        Change-Id: I02de9ee72848061497678936aa1d0c492694bfc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119324
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-07-22  Miklos Vajna  <vmiklos@collabora.com>  [580194ec22841b915fb90cba63072bc781c3859a]

        sw: use SfxPoolItem::StaticWhichCast() in InitCore()
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: I292e1e8ec4f2536b213d76fdc1f45d3298c3fe03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119340
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-22  Michael Stahl  <michael.stahl@allotropia.de>  [946f457c885bd10ff1a7281c351f3981f035f5a7]

        curl: upgrade to release 7.78.0
        
        * Fixes CVE-2020-8284 CVE-2021-22924
        * Also fixes these which don't look relevant to LO:
          CVE-2020-8231
          CVE-2020-8285 CVE-2020-8286
          CVE-2021-22876 CVE-2021-22890
          CVE-2021-22897 CVE-2021-22898 CVE-2021-22901
          CVE-2021-22922 CVE-2021-22923 CVE-2021-22925 CVE-2021-22926
        * disable some new protocols and dependencies
        * remove curl-ios.patch.1 as the code no longer exists upstream
        
        Change-Id: I12d5f87f4d503a5f9859226a05cfe2a07e46d993
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119313
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [5feb7230bf4a06290d0972dc5bf6dd4108e7edbb]

        flatten GraphicObjectImpl
        
        no need to allocate the GraphicObject separately
        
        Change-Id: I71f13792dfd45e47d835ad1e3627a559044346a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119337
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8c6d90bc5b344e65cf0ae6cdd028956bb31dbe4]

        remove pimpl in AnimatedImagesControlModel
        
        Change-Id: I34ffaca1c5d109a28b75730bd7634e244b8bf31b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119327
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ccb60734bd30115affa835cb189fcd3ca21306a9]

        no need to allocate ScTokenMatrixMap separately
        
        Change-Id: I2345b7b5c9b21aac06b557658906e8028fadec0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119333
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [ceccfbb7e81edea31d7cc792b1a31473f9d9feee]

        osl::Mutex->std::mutex in GraphicObjectImpl
        
        Change-Id: I4c62d4b105425d4fb39eefdb7117299488af47dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119336
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [58c6fad213024ef8f162984a66af565ac9ad4b97]

        tdf#143412 CRASH: converting images
        
        Revert "use unique_ptr in SdrEditView::ImpConvertOneObj"
        This reverts commit 2ec1dab4693cd45b475f02452114dd96ec0bda1b.
        
        I was wrong, we are no returning ownership here.
        
        Change-Id: Ib3b3b32248d4b56f0a48c658db5d6431b26fc352
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119335
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-22  Stephan Bergmann  <sbergman@redhat.com>  [505fb3f952106d6fafd300097cce83c2050fbc60]

        -Werror=maybe-uninitialized
        
        > registry/source/reflwrit.cxx: In member function ‘sal_uInt32 RegistryTypeWriter::getBlopSize()’:
        > registry/source/reflwrit.cxx:1332:33: error: ‘size’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
        >  1332 |     return ::getBlopSize(m_hImpl);
        >       |                                 ^
        
        at least with recent GCC 12 trunk and --enable-dbgutil --enable-optimized
        
        Change-Id: I17abbb55ba31458147afd486a17e8455ede39b32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119338
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-22  Mike Kaganski  <mike.kaganski@collabora.com>  [0d4cbdbc9cd4ab06056cec66cffd292b41615b6e]

        Dereferencing uninitialized pointer
        
        SfxItemSet::GetItemState returns SfxItemState::DEFAULT without
        resetting the passed pointer.
        
        Regression after commit dd5bf12193471f064bf7f581dd1b21783390e735.
        
        Change-Id: I1e427a05f8e5b375f50d81b51d32e78fca83eb42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119348
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [697e9f3cc9cb3309bf7e22bc39057ff720f1d1b3]

        pass sc::ColumnIterator by value
        
        no need to allocate on heap
        
        Change-Id: Ie0f3fa39092083b9c30f3e769bb65fa975150021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119312
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [603552c209f8652aa23a688b36d4a2abac933717]

        remove pimpl in AnimatedImagesPeer
        
        Change-Id: Ia9109fb0b68a28612129e4f2fc3eae0f92a4dabd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119326
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [1c7a9ac8594f12329dcba0516071e9562ee8df70]

        Use Append here instead of Insert
        
        The containers are filled after resetting them.
        
        Change-Id: I6cd17fd47a84e755788a3b58fe72b451d6267e99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119323
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [dca1ed757674ad9b32ded6ab92b6fe85c7890005]

        flatten SwShareBoxFormats a little
        
        Change-Id: I1ddbc0d2d9969597491f47ddbabd99badfee78a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119334
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7f05c009aad9fb8c8872312929c473b55cb1454]

        flatten vector in ImplMultiTextLineInfo
        
        Change-Id: I30f40c3906c38d29bab7aeef0a9562bd96934a72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec01d43e0a8fa560d7cd8c76c0d609b18a60cddb]

        pass SfxChildWinFactory around by value
        
        no need to allocate on heap
        
        Change-Id: I7410a6c9cb434b18ed6f7ae1dc0ccea34151921c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119331
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [df157d5291ba3531d2c79539addfd0dbff48ac67]

        no need for FormControlFactory to have a pimpl
        
        Change-Id: Ia5dcccafffe69eac3369a0f2923b9aa526d68cbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119332
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [c060ec59866ced50ded6c19a39119292548f844c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 08af5ea8348ff994b650ee8f5c9404af4c06bc4f
          - Python examples in SF_Timer help page
            
            This patch also adds a <variable> tag and refactors the file 03030303.xhp (Timer function) to ease x-ref.
            
            Change-Id: I90f26234a9632b9d8220cca94fe2ab11fb4f8fa2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119256
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [9a2d08cf16d4e0b2b45e9b687884acb729739608]

        flatten ImplListBoxWindow
        
        no need to allocate ImplEntryList separately
        
        Change-Id: I276e92895a00ebccff60f5067567a0ed066d4e66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119328
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [19654ca9de6ff221337e8ec82307611c311c4e57]

        flatten ImplToolBoxPrivateData
        
        Change-Id: Ia3c0d6624ccf2d3c6189064ab7c8b07dc0734c5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119330
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [71a7440c745fc7f16c726571453b6dd7dad2ac80]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e9a241713198c414360ecc6204028c1cafcd2fc8
          - Fix typo
            
            Change-Id: I03e831f5172f77e2fac56ea15358c4660007ce70
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119339
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ce2ba98aa3bde5dc91b00753b11d0add69925af]

        flatten aCatLists in ScFunctionCategory
        
        no need to allocate the vector separately, they are always there, and
        initialise once
        
        Change-Id: I92c735502d26dc4ff9ab138e5086d74db3afb138
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119311
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a4fafab70dccd4df47166428b6e05d52d9bbdf3f]

        improve the comments of the number conversion functions
        
        For the
            rtl_str_to<NumberType>_WithLength
        category of functions, the string does not need to be null-terminated
        
        Change-Id: I1971c8c10b760743633523e6f680366eafdfc685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119325
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [462f9d1f589a7afd66d3fc61925467d3b68e5b31]

        tdf#142600 - List tables in order of their appearance
        
        Change-Id: I1e653bf3a646161825b465ea2fc20ab48308f0ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116767
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [bdf14fd8ea18b94cdcdf2b194d6644f87d69d96b]

        qt5 a11y: Implement Qt5AccessibleWidget::cursorPosition
        
        Use 'XAccessibleText::getCaretPosition', similar to
        how 'Qt5AccessibleWidget::setCursorPosition' calls
        'XAccessibleText::setCaretPosition'.
        
        Change-Id: Ic9e4533d6a39de90fee7ec2e8e0bd3fc6a69bba0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119320
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [96869931e35fa4fbc779755e89207062648ed58d]

        qt5 a11y: Implement Qt5AccessibleWidget::textAtOffset
        
        The Orca screen reader uses
        'IAccessibleText::textAtOffset' e.g. in
        order to retrieve the text of the current Writer
        paragraph on cursor movement.
        
        With this and various other WIP changes
        to qt5 a11y on top which are required to make Orca
        speak at all (well, at least sometimes...), Orca
        now also speaks the text of paragraphs that contain
        more than just a single character.
        The single-character case was working because
        Orca has a special handling for this; a comment
        in the source code says:
        "We do this because Gecko's implementation of getTextAtOffset
        is broken if there is just one character in the string.")
        
        This implementation is inspired by the
        corresponding winaccessibility one,
        see 'CAccTextBase::get_textAtOffset' in
        winaccessibility/source/UAccCOM/AccTextBase.cxx.
        
        Change-Id: I67775a03c6e4384f410e1e9d727d7a412ba4112e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119310
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [cd2b5168e8ef1cb6e721bc5220421464ed723096]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2612264b78199fc343f7dabfca8a1dc44d2f10fd
          - Python examples for SF_Session service
            
            Change-Id: Ic1024b6237b26ff558099aef5774588f2f3148d0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119254
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [37d786050919031d5bcbd394fbef6c1f4847e379]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to daea8c54614d4dd489fb66adbadec58d6d17cfea
          - Python examples for SF_Dictionary help page
            
            This patch also fixes identation in in the entire file.
            
            Change-Id: I409523f253d2dec657f35561b48352333693feb6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119179
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-21  Miklos Vajna  <vmiklos@collabora.com>  [3b2b2eae863d1082a36c02851190e0846f90cdd1]

        sw bibliography, local copy: add document model & UNO API
        
        The idea is that a bibliography entry (field) can have not only an URL
        (which might be unavailable due to lack of network connectivity,
        paywall, etc) but also a local copy, which is also a URL.
        
        The local copy doesn't replace the original URL. The local copy is
        stored part of the document, since it may be a relative URL, e.g. ODT +
        several PDFs copied around in the same directory.
        
        This commit just starts this feature, up to the extent that read and
        write of the new property works.
        
        Change-Id: I3c4df2be3a1f3b02a87c097f8a0630951def09d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119322
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-21  Stephan Bergmann  <sbergman@redhat.com>  [37247ffb6f255ca7f96c6110149bcf85a2cddd44]

        Avoid deadlock between osl global mutex and cppu::getTypeEntries mutex
        
        ...as seen at least once during UITest_calc_tests9, with thread 1 at
        
        > Thread 1 (Thread 0x7f2c48958fc0 (LWP 439791) "soffice.bin"):
        > #0  0x00007f2caa2b17b0 in __lll_lock_wait () at /lib64/libpthread.so.0
        > #1  0x00007f2caa2aa553 in pthread_mutex_lock () at /lib64/libpthread.so.0
        > #2  0x00007f2ca399275b in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x7f2ca40ce020 <cppu::getTypeEntries(cppu::class_data*)::aMutex>) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/x86_64-pc-linux-gnu/bits/gthr-default.h:749
        > #3  0x00007f2ca39948cb in std::mutex::lock() (this=0x7f2ca40ce020 <cppu::getTypeEntries(cppu::class_data*)::aMutex>) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_mutex.h:100
        > #4  0x00007f2ca39940eb in std::lock_guard<std::mutex>::lock_guard(std::mutex&) (this=0x7f2c4752d820, __m=...) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_mutex.h:229
        > #5  0x00007f2ca3990fdb in cppu::getTypeEntries(cppu::class_data*) (cd=0x7f2c3eda4640 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>, com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:71
        > #6  0x00007f2ca398c616 in cppu::queryDeepNoXInterface(_typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x60f00020ec60, cd=0x7f2c3eda4640 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>, com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x60e0002a2960) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:155
        > #7  0x00007f2ca398ea93 in cppu::WeakImplHelper_query(com::sun::star::uno::Type const&, cppu::class_data*, void*, cppu::OWeakObject*) (rType=invalid uno::Type, cd=0x7f2c3eda4640 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>, com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x60e0002a2960, pBase=0x60e0002a2960) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:283
        > #8  0x00007f2c3ea61105 in cppu::WeakImplHelper<com::sun::star::i18n::XCollator, com::sun::star::lang::XServiceInfo>::queryInterface(com::sun::star::uno::Type const&) (this=0x60e0002a2960, aType=invalid uno::Type) at /home/sbergman/lo/core/include/cppuhelper/implbase.hxx:111
        > #9  0x00007f2c7c491500 in com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&) (pInterface=0x60e0002a2960, rType=invalid uno::Type) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:59
        > #10 0x00007f2c7c8a1165 in com::sun::star::uno::Reference<com::sun::star::i18n::XCollator>::iquery(com::sun::star::uno::XInterface*) (pInterface=0x60e0002a2960) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:74
        > #11 0x00007f2c7c8a015e in com::sun::star::uno::Reference<com::sun::star::i18n::XCollator>::Reference(com::sun::star::uno::BaseReference const&, com::sun::star::uno::UnoReference_Query) (this=0x7f2c47447020, rRef=...) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:176
        > #12 0x00007f2c7c89ebaa in com::sun::star::i18n::Collator::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (the_context=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/i18n/Collator.hpp:38
        > #13 0x00007f2c7c89c324 in CollatorWrapper::CollatorWrapper(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x60200097c0f0, rxContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/unotools/source/i18n/collatorwrapper.cxx:30
        > #14 0x00007f2c14889098 in ScGlobal::GetCaseCollator()::$_6::operator()() const (this=0x7f2c470e74a0) at /home/sbergman/lo/core/sc/source/core/data/global.cxx:1044
        > #15 0x00007f2c14886efc in comphelper::doubleCheckedInit<CollatorWrapper, ScGlobal::GetCaseCollator()::$_6, osl::Guard<osl::Mutex>, osl::GetGlobalMutex>(std::atomic<CollatorWrapper*>&, ScGlobal::GetCaseCollator()::$_6, osl::GetGlobalMutex) (pointer=..., function=..., guardCtor=...) at /home/sbergman/lo/core/include/comphelper/doublecheckedinit.hxx:53
        > #16 0x00007f2c14886d1c in ScGlobal::GetCaseCollator() () at /home/sbergman/lo/core/sc/source/core/data/global.cxx:1041
        > #17 0x00007f2c1627adde in ScTypedStrData::LessCaseSensitive::operator()(ScTypedStrData const&, ScTypedStrData const&) const (this=0x7f2c471eab20, left=..., right=...) at /home/sbergman/lo/core/sc/source/core/tool/typedstrdata.cxx:26
        > #18 0x00007f2c13ad7750 in std::sort<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<ScTypedStrData*, std::__cxx1998::vector<ScTypedStrData, std::allocator<ScTypedStrData> > >, std::__debug::vector<ScTypedStrData, std::allocator<ScTypedStrData> >, std::random_access_iterator_tag>, ScTypedStrData::LessCaseSensitive>(__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<ScTypedStrData*, std::__cxx1998::vector<ScTypedStrData, std::allocator<ScTypedStrData> > >, std::__debug::vector<ScTypedStrData, std::allocator<ScTypedStrData> >, std::random_access_iterator_tag>, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<ScTypedStrData*, std::__cxx1998::vector<ScTypedStrData, std::allocator<ScTypedStrData> > >, std::__debug::vector<ScTypedStrData, std::allocator<ScTypedStrData> >, std::random_access_iterator_tag>, ScTypedStrData::LessCaseSensitive) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/stl_algo.h:4873
        > #19 0x00007f2c13ab544d in (anonymous namespace)::sortAndRemoveDuplicates(std::__debug::vector<ScTypedStrData, std::allocator<ScTypedStrData> >&, bool) (rStrings=std::__debug::vector of length 1, capacity 1 = {...}, bCaseSens=true) at /home/sbergman/lo/core/sc/source/core/data/documen3.cxx:86
        > #20 0x00007f2c13ab6bc9 in ScDocument::GetDataEntries(short, int, short, std::__debug::vector<ScTypedStrData, std::allocator<ScTypedStrData> >&, bool) (this=0x61e0000505c0, nCol=0, nRow=1, nTab=0, rStrings=std::__debug::vector of length 1, capacity 1 = {...}, bValidation=false) at /home/sbergman/lo/core/sc/source/core/data/documen3.cxx:1650
        > #21 0x00007f2c1708a56e in ScInputHandler::GetColData() (this=0x614000068840) at /home/sbergman/lo/core/sc/source/ui/app/inputhdl.cxx:1943
        > #22 0x00007f2c1709e132 in ScInputHandler::StartTable(char16_t, bool, bool, ScEditEngineDefaulter*) (this=0x614000068840, cTyped=66 u'B', bFromCommand=false, bInputActivated=false, pTopEngine=0x0) at /home/sbergman/lo/core/sc/source/ui/app/inputhdl.cxx:2501
        > #23 0x00007f2c17057bc0 in ScInputHandler::DataChanging(char16_t, bool) (this=0x614000068840, cTyped=66 u'B', bFromCommand=false) at /home/sbergman/lo/core/sc/source/ui/app/inputhdl.cxx:2605
        > #24 0x00007f2c170ad948 in ScInputHandler::KeyInput(KeyEvent const&, bool) (this=0x614000068840, rKEvt=..., bStartEdit=true) at /home/sbergman/lo/core/sc/source/ui/app/inputhdl.cxx:3714
        > #25 0x00007f2c1723ac2b in ScModule::InputKeyEvent(KeyEvent const&, bool) (this=0x616000223880, rKEvt=..., bStartEdit=true) at /home/sbergman/lo/core/sc/source/ui/app/scmod.cxx:1356
        > #26 0x00007f2c19ce48c9 in ScTabViewShell::TabKeyInput(KeyEvent const&) (this=0x61e000051080, rKEvt=...) at /home/sbergman/lo/core/sc/source/ui/view/tabvwsh4.cxx:1278
        > #27 0x00007f2c196183ce in ScGridWindow::KeyInput(KeyEvent const&) (this=0x618000ee6880, rKEvt=...) at /home/sbergman/lo/core/sc/source/ui/view/gridwin.cxx:3414
        > #28 0x00007f2c775e963f in WindowUIObject::execute(rtl::OUString const&, std::__debug::map<rtl::OUString, rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, rtl::OUString> > > const&) at /home/sbergman/lo/core/vcl/source/uitest/uiobject.cxx:357
        > #29 0x00007f2c186a5929 in ScGridWinUIObject::execute(rtl::OUString const&, std::__debug::map<rtl::OUString, rtl::OUString, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, rtl::OUString> > > const&) at /home/sbergman/lo/core/sc/source/ui/uitest/uiobject.cxx:317
        > #30 0x00007f2c7766d9ba in UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0::operator()() const (this=0x603000f61240) at /home/sbergman/lo/core/vcl/source/uitest/uno/uiobject_uno.cxx:137
        > #31 0x00007f2c7766d0dd in std::__invoke_impl<void, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&>(std::__invoke_other, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&) (__f=...) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:61
        > #32 0x00007f2c7766cf8d in std::__invoke_r<void, UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&>(UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0&) (__fn=...) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:111
        > #33 0x00007f2c7766ca9d in std::_Function_handler<void (), UIObjectUnoObj::executeAction(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)::$_0>::_M_invoke(std::_Any_data const&) (__functor=...) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:291
        > #34 0x00007f2c744b3c22 in std::function<void ()>::operator()() const (this=0x6070001d4d80) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:560
        > #35 0x00007f2c7766c35c in (anonymous namespace)::ExecuteWrapper::ExecuteActionHdl(Timer*) (this=0x6070001d4d80) at /home/sbergman/lo/core/vcl/source/uitest/uno/uiobject_uno.cxx:100
        > #36 0x00007f2c77668e29 in (anonymous namespace)::ExecuteWrapper::LinkStubExecuteActionHdl(void*, Timer*) (instance=0x6070001d4d80, data=0x608000148e20) at /home/sbergman/lo/core/vcl/source/uitest/uno/uiobject_uno.cxx:95
        > #37 0x00007f2c76c645de in Link<Timer*, void>::Call(Timer*) const (this=0x608000148e40, data=0x608000148e20) at /home/sbergman/lo/core/include/tools/link.hxx:111
        > #38 0x00007f2c76c63b7d in Timer::Invoke() (this=0x608000148e20) at /home/sbergman/lo/core/vcl/source/app/timer.cxx:75
        > #39 0x00007f2c76abfd6c in Scheduler::CallbackTaskScheduling() () at /home/sbergman/lo/core/vcl/source/app/scheduler.cxx:471
        > #40 0x00007f2c77b9a1a4 in SalTimer::CallCallback() (this=0x6030002f0bc0) at /home/sbergman/lo/core/vcl/inc/saltimer.hxx:54
        > #41 0x00007f2c77b8dda1 in SvpSalInstance::CheckTimeout(bool) (this=0x611000001bc0, bExecuteTimers=true) at /home/sbergman/lo/core/vcl/headless/svpinst.cxx:215
        > #42 0x00007f2c77b949a0 in SvpSalInstance::DoYield(bool, bool) (this=0x611000001bc0, bWait=true, bHandleAllCurrentEvents=false) at /home/sbergman/lo/core/vcl/headless/svpinst.cxx:460
        > #43 0x00007f2c76bb2462 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at /home/sbergman/lo/core/vcl/source/app/svapp.cxx:465
        > #44 0x00007f2c76bb1588 in Application::Yield() () at /home/sbergman/lo/core/vcl/source/app/svapp.cxx:532
        > #45 0x00007f2c76bb11bf in Application::Execute() () at /home/sbergman/lo/core/vcl/source/app/svapp.cxx:444
        > #46 0x00007f2caae21016 in desktop::Desktop::Main() (this=0x7f2c472b8080) at /home/sbergman/lo/core/desktop/source/app/app.cxx:1602
        
        having locked the osl global mutex in comphelper::doubleCheckedInit in frame 15
        and trying to lock the cppu::getTypeEntries mutex, while thread 4 at
        
        > Thread 4 (Thread 0x7f2c275b6640 (LWP 440147) "InitUpdateCheck"):
        > #0  0x00007f2caa2b17b0 in __lll_lock_wait () at /lib64/libpthread.so.0
        > #1  0x00007f2caa2aa5d0 in pthread_mutex_lock () at /lib64/libpthread.so.0
        > #2  0x00007f2cabc21967 in osl_acquireMutex(oslMutex) (pMutex=0x604000090d50) at /home/sbergman/lo/core/sal/osl/unx/mutex.cxx:100
        > #3  0x00007f2bf58684da in osl::Mutex::acquire() (this=0x7f2cabe45c60 <osl_getGlobalMutex::g_Mutex>) at /home/sbergman/lo/core/include/osl/mutex.hxx:61
        > #4  0x00007f2bf586694a in osl::Guard<osl::Mutex>::Guard(osl::Mutex*) (this=0x7f2c262d7420, pT_=0x7f2cabe45c60 <osl_getGlobalMutex::g_Mutex>) at /home/sbergman/lo/core/include/osl/mutex.hxx:135
        > #5  0x00007f2bf58762f9 in com::sun::star::lang::cppu_detail_getUnoType(com::sun::star::lang::XServiceInfo const*) () at /home/sbergman/lo/core/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XServiceInfo.hpp:73
        > #6  0x00007f2bf5875f09 in cppu::UnoType<com::sun::star::lang::XServiceInfo>::get() () at /home/sbergman/lo/core/include/cppu/unotype.hxx:300
        > #7  0x00007f2bf5875ce9 in com::sun::star::lang::XServiceInfo::static_type(void*) () at /home/sbergman/lo/core/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/lang/XServiceInfo.hpp:145
        > #8  0x00007f2ca39913be in cppu::getTypeEntries(cppu::class_data*) (cd=0x7f2bf58c73a8 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>, com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:78
        > #9  0x00007f2ca398c616 in cppu::queryDeepNoXInterface(_typelib_TypeDescriptionReference const*, cppu::class_data*, void*) (pDemandedTDR=0x60f0001cf420, cd=0x7f2bf58c73a8 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>, com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x60e00022e7c0) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:155
        > #10 0x00007f2ca398ea93 in cppu::WeakImplHelper_query(com::sun::star::uno::Type const&, cppu::class_data*, void*, cppu::OWeakObject*) (rType=invalid uno::Type, cd=0x7f2bf58c73a8 <cppu::detail::ImplClassData<cppu::WeakImplHelper<com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>, com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>::operator()()::s_cd>, that=0x60e00022e7c0, pBase=0x60e00022e7c0) at /home/sbergman/lo/core/cppuhelper/source/implbase_ex.cxx:283
        > #11 0x00007f2bf58629e5 in cppu::WeakImplHelper<com::sun::star::deployment::XUpdateInformationProvider, com::sun::star::ucb::XWebDAVCommandEnvironment, com::sun::star::lang::XServiceInfo>::queryInterface(com::sun::star::uno::Type const&) (this=0x60e00022e7c0, aType=invalid uno::Type) at /home/sbergman/lo/core/include/cppuhelper/implbase.hxx:111
        > #12 0x00007f2c3015cf60 in com::sun::star::uno::BaseReference::iquery(com::sun::star::uno::XInterface*, com::sun::star::uno::Type const&) (pInterface=0x60e00022e7c0, rType=invalid uno::Type) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:59
        > #13 0x00007f2c302419c5 in com::sun::star::uno::Reference<com::sun::star::deployment::XUpdateInformationProvider>::iquery(com::sun::star::uno::XInterface*) (pInterface=0x60e00022e7c0) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:74
        > #14 0x00007f2c3024010e in com::sun::star::uno::Reference<com::sun::star::deployment::XUpdateInformationProvider>::Reference(com::sun::star::uno::BaseReference const&, com::sun::star::uno::UnoReference_Query) (this=0x7f2c262bd420, rRef=...) at /home/sbergman/lo/core/include/com/sun/star/uno/Reference.hxx:176
        > #15 0x00007f2c3023e98a in com::sun::star::deployment::UpdateInformationProvider::create(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (the_context=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/deployment/UpdateInformationProvider.hpp:38
        > #16 0x00007f2c30235e85 in dp_info::(anonymous namespace)::PackageInformationProvider::PackageInformationProvider(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x607000afd3e0, xContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/desktop/source/deployment/manager/dp_informationprovider.cxx:92
        > #17 0x00007f2c30235932 in com_sun_star_comp_deployment_PackageInformationProvider_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (context=0x611000005e50) at /home/sbergman/lo/core/desktop/source/deployment/manager/dp_informationprovider.cxx:336
        > #18 0x00007f2ca3c92795 in std::__invoke_impl<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(std::__invoke_other, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__f=@0x612000035088: 0x7f2c302357f0 <com_sun_star_comp_deployment_PackageInformationProvider_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, __args=@0x7f2c25ecd960: 0x611000005e50, __args=empty uno::Sequence) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:61
        > #19 0x00007f2ca3c9248d in std::__invoke_r<com::sun::star::uno::XInterface*, com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&>(com::sun::star::uno::XInterface* (*&)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__fn=@0x612000035088: 0x7f2c302357f0 <com_sun_star_comp_deployment_PackageInformationProvider_get_implementation(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>, __args=@0x7f2c25ecd960: 0x611000005e50, __args=empty uno::Sequence) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/invoke.h:114
        > #20 0x00007f2ca3c91ebd in std::_Function_handler<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&), com::sun::star::uno::XInterface* (*)(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::_M_invoke(std::_Any_data const&, com::sun::star::uno::XComponentContext*&&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) (__functor=..., __args=@0x7f2c25ecd960: 0x611000005e50, __args=empty uno::Sequence) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:291
        > #21 0x00007f2ca3b7d419 in std::function<com::sun::star::uno::XInterface* (com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&)>::operator()(com::sun::star::uno::XComponentContext*, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&) const (this=0x612000035088, __args=0x611000005e50, __args=empty uno::Sequence) at /home/sbergman/gcc/trunk/inst/include/c++/12.0.0/bits/std_function.h:560
        > #22 0x00007f2ca3b30861 in cppuhelper::ServiceManager::Data::Implementation::doCreateInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x612000034fd0, context=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/cppuhelper/source/servicemanager.cxx:703
        > #23 0x00007f2ca3b30394 in cppuhelper::ServiceManager::Data::Implementation::createInstance(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, bool) (this=0x612000034fd0, context=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50, singletonRequest=true) at /home/sbergman/lo/core/cppuhelper/source/servicemanager.cxx:672
        > #24 0x00007f2ca3b6bb9c in (anonymous namespace)::SingletonFactory::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x60700003a4e0, Context=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/cppuhelper/source/servicemanager.cxx:532
        > #25 0x00007f2ca3b6c0af in non-virtual thunk to (anonymous namespace)::SingletonFactory::createInstanceWithContext(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) () at /home/sbergman/lo/core/cppuhelper/source/servicemanager.cxx:541
        > #26 0x00007f2ca38c5545 in cppu::(anonymous namespace)::ComponentContext::lookupMap(rtl::OUString const&) (this=0x611000005e00, rName="/singletons/com.sun.star.deployment.PackageInformationProvider") at /home/sbergman/lo/core/cppuhelper/source/component_context.cxx:300
        > #27 0x00007f2ca38ae9ab in cppu::(anonymous namespace)::ComponentContext::getValueByName(rtl::OUString const&) (this=0x611000005e00, rName="/singletons/com.sun.star.deployment.PackageInformationProvider") at /home/sbergman/lo/core/cppuhelper/source/component_context.cxx:374
        > #28 0x00007f2ca38b279f in non-virtual thunk to cppu::(anonymous namespace)::ComponentContext::getValueByName(rtl::OUString const&) () at /home/sbergman/lo/core/cppuhelper/source/component_context.cxx:266
        > #29 0x00007f2c2791c7e0 in checkForPendingUpdates(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (rxContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/extensions/source/update/check/updateprotocol.cxx:289
        > #30 0x00007f2c277d3db3 in UpdateCheck::initialize(com::sun::star::uno::Sequence<com::sun::star::beans::NamedValue> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&) (this=0x6130001c9dc0, rValues=uno::Sequence of length 8 = {...}, xContext=uno::Reference to (class cppu::(anonymous namespace)::ComponentContext *) 0x611000005e50) at /home/sbergman/lo/core/extensions/source/update/check/updatecheck.cxx:776
        > #31 0x00007f2c278acd2a in (anonymous namespace)::InitUpdateCheckJobThread::run() (this=0x608000163d20) at /home/sbergman/lo/core/extensions/source/update/check/updatecheckjob.cxx:143
        
        having locked the cppu::getTypeEntries mutex in frame 1 and now trying to lock
        the osl global mutex.
        
        Of the many functions in sc/source/core/data/global.cxx that (implicitly, by
        default) use the osl global mutex in comphelper::doubleCheckedInit, change at
        least those two that call a CollatorWrapper (and are thus susceptible to the
        described deadlock).
        
        Change-Id: Ie41a1116518146bffcefab2373f1386afc03e544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119319
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-21  Julien Nabet  <serval2412@yahoo.fr>  [73503ce975ce0923bfe2cfd075ac8b91de20f29e]

        tdf#143452: make 2 buttons in the date form control translatable
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd50ee06d982e19d54fae0f9d8f968a2dedbd4
        weld DateField Calendar floating window
        
        Change-Id: I43c108908c6e802f3a8014ccf3fa243bebcae0ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119293
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-07-21  Stephan Bergmann  <sbergman@redhat.com>  [99a1290b3f2c8584db0a33fe48adf93dccce3a92]

        Use existing rtl_math_stringToDouble
        
        ...like it is also already done in LineParser::readDouble in
        sdext/source/pdfimport/wrapper/wrapper.cxx (esp. since the code should be
        changed to use C++17 std::from_chars once that is available in all our
        baselines), reverting again the introduction of rtl_str_toDouble_WithLength in
        b1df9c67349cf4cc5be4128d797aefb87f50e38f "[API CHANGE] reduce cost of numeric
        conversion"
        
        Change-Id: If7e3a15649f80093d3407157412fd3deb3a38b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119318
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-07-21  Stephan Bergmann  <sbergman@redhat.com>  [e854abe076155fc085b56549ced50b3ee9a095d2]

        Avoid external processes picking up instdir/program/libnspr4.so
        
        ...which is a problem in ASan builds, as seen with a failing
        CppunitTest_sd_import_tests (among lots of other similarly failing tests):
        
        > Exception in thread "main" java.lang.UnsatisfiedLinkError: /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-5.fc34.x86_64/lib/libsystemconf.so: ~/lo/core/instdir/program/libnspr4.so: undefined symbol: __asan_option_detect_stack_use_after_return
        > 	at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native Method)
        > 	at java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442)
        > 	at java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498)
        > 	at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694)
        > 	at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2648)
        > 	at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830)
        > 	at java.base/java.lang.System.loadLibrary(System.java:1873)
        > 	at java.base/java.security.SystemConfigurator$1.run(SystemConfigurator.java:67)
        > 	at java.base/java.security.SystemConfigurator$1.run(SystemConfigurator.java:65)
        > 	at java.base/java.security.AccessController.doPrivileged(Native Method)
        > 	at java.base/java.security.SystemConfigurator.<clinit>(SystemConfigurator.java:65)
        > 	at java.base/java.security.Security.initialize(Security.java:208)
        > 	at java.base/java.security.Security$2.run(Security.java:93)
        > 	at java.base/java.security.Security$2.run(Security.java:91)
        > 	at java.base/java.security.AccessController.doPrivileged(Native Method)
        > 	at java.base/java.security.Security.<clinit>(Security.java:91)
        > 	at java.base/sun.security.jca.ProviderList.<init>(ProviderList.java:176)
        > 	at java.base/sun.security.jca.ProviderList$2.run(ProviderList.java:94)
        > 	at java.base/sun.security.jca.ProviderList$2.run(ProviderList.java:92)
        > 	at java.base/java.security.AccessController.doPrivileged(Native Method)
        > 	at java.base/sun.security.jca.ProviderList.fromSecurityProperties(ProviderList.java:91)
        > 	at java.base/sun.security.jca.Providers.<clinit>(Providers.java:54)
        > 	at java.base/java.security.SecureRandom.getDefaultPRNG(SecureRandom.java:264)
        > 	at java.base/java.security.SecureRandom.<init>(SecureRandom.java:219)
        > 	at java.base/java.util.UUID$Holder.<clinit>(UUID.java:101)
        > 	at java.base/java.util.UUID.randomUUID(UUID.java:147)
        > 	at org.probatron.officeotron.sessionstorage.Store.putZippedResource(Unknown Source)
        > 	at org.probatron.officeotron.CommandLineSubmission.<init>(Unknown Source)
        > 	at org.probatron.officeotron.Driver.main(Unknown Source)
        > warn:svl.items:1258842:1258842:svl/source/items/itempool.cxx:358: old secondary pool: EditEngineItemPool of pool: XOutdevItemPool must be empty.
        > ~/lo/core/test/source/bootstrapfixture.cxx:232:SdImportTest::testDocumentLayout
        > equality assertion failed
        > - Expected: 0
        > - Actual  : 256
        > - failed to execute: sh ~/lo/core/bin/officeotron.sh ~/lo/tmp/SdImportTest__testDocumentLayout_16w8dw.tmp > ~/lo/tmp/SdImportTest__testDocumentLayout_16w8dy.tmp
        
        The solution reuses the arg-env bootstrap variable already used by
        test::OfficeConnection::setUp (unotest/source/cpp/officeconnection.cxx) and for
        that makes test::getArgumnet available outside Library_unotest.  (For
        simplicity, it adds the relevant gb_CppunitTest_add_arguments calls
        unconditionally to the various *.mk files, even though the data is only used
        conditionally for non-_WIN32 in test::BootstrapFixture::validate in
        test/source/bootstrapfixture.cxx, at least for now.)
        
        Not sure what exactly started to cause this issue now for my ASan builds on
        Fedora 34.
        
        Change-Id: I7a4d6c0e36b94935442c6c91d5ee967fcad61763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119317
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [6fcb7ca818ebf819008cac55f08fe0e6c310d8cc]

        remove obsolete comments
        
        Change-Id: Ie2ceb7abb9bef5e84e740fba32f30697144f1c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119303
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [4ef0af9c14fa5242d3650728947c451493646e03]

        wina11y: Deduplicate mapping for IA2TextBoundaryType
        
        Add a local function 'lcl_matchIA2TextBoundaryType'
        that returns the UNO equivalent for the boundary
        type and use it from all 3 places that previously
        did the same mapping. Also, use the constants defined
        in the 'AccessibleTextType.hpp' header rather than
        hard-coding the values here again.
        
        It is unclear to me what the
        
            // In New UNO IAccessibleText.idl these constant values are defined as follows:
        
        comment refers to, which has been there since commit
        
            commit a18bdb3bc05e761704cc345a66a9d642bc4f4a0a
            Date:   Thu Nov 14 08:18:05 2013 +0000
        
                Integrate branch of IAccessible2
        
                Just the winaccessibility directory initially.
        
                Change-Id: Ia21abb8d7088646ad6c1f83b3a03e7add716b0c0
        
        (I don't see any IAccessibleText.idl anywhere. Maybe that was
        meant for some follow-up change that never took place
        in the end?)
        
        Change-Id: I6b8af2215948e8d0241e6f438c0f8cc00adc800f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119316
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [1cfa72a83101d7ea1f89b2c20a6c29d12e8da933]

        IsVertical->IsEffectivelyVertical, GetDirectVertical->GetVertical
        
        Before commit 653b53287ca09a9ffe3f5ce0242919e719c1086c, editengine
        objects had a pair IsVertical/SetVertical, which queried and set
        a boolean flag (and SetVertical also had a second argument to set
        another flag).
        
        The mentioned commit had introduced an inconsistency, changing
        SetVertical to only set a single flag, but at the same time making
        IsVertical to return a synthesized result from two values: vertical
        and rotation. Additionally, GetDirectVertical was introduced to
        complement SetVertical.
        
        In many places, the use of synthetic IsVertical looks suspicious,
        especially where it is used in combinations with SetVertical. But
        here I don't change existing logic, and only rename the methods,
        so that in case someone sees an actual problem, it would be easier
        to spot the method mismatch.
        
        The end result is that now we have a proper getter/setter pair
        GetVertical/SetVertical, and also IsEffectivelyVertical, named to
        reflect that it calculates its return value.
        
        Change-Id: I38e2b7c5bd7af0787dd7a1c48e1385138dac80b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119315
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [99cd1d8834bb708afc81c825ff2b7992b7acb37d]

        flatten TableType in ColumnSpanSet
        
        Change-Id: I66c8a1ac022da0f64dc16fdda364da6402d3db30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119307
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [159b8fb14f3577812819508f4160c37414cce6da]

        flatten vector in BaseContainerControl
        
        no need to allocate the entries separately
        
        Change-Id: I00c4abe75701685689eb7d09a97c349cb0271f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119304
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Stephan Bergmann  <sbergman@redhat.com>  [9230c189ebc5bcfd6303bfa7eebcd35488037d00]

        Use existing rtl_str_toInt64_WithLength
        
        ...like it is also already done in LineParser::readInt32 in
        sdext/source/pdfimport/wrapper/wrapper.cxx (esp. since the code should be
        changed to use C++17 std::from_chars once that is available in all our
        baselines), reverting again the introduction of rtl_str_toInt32_WithLength in
        b1df9c67349cf4cc5be4128d797aefb87f50e38f "[API CHANGE] reduce cost of numeric
        conversion"
        
        Change-Id: I2789f8ec55c8d89150d1c68e6b353a1d2e1d1703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119301
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [5baa40802960eac5c6df897fdbbd59c5e479fca4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aad9b295eab6bb3b6126ebda8e0b62b848369701
          - Python example in SF_Platform help page
            
            Change-Id: I3889815d7eb2e653f307e9853649e395f4f2e2fb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119175
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [c1204533375742b216feb029cd0b7f2c75f16e02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd9131a3c09e8bd80820d923e73dc9daa247a1e1
          - Change examples using "~" (tilde) shortcut in SF help files
            
            Change-Id: I462e9a79a1776c0bc6acb67a8d5b08b85c2ae106
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119178
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0c3da17e4190f9fd7038d1d52a92e0748396c1d8]

        pass ZipEnumeration around by value
        
        Change-Id: I8418bd3eb6a8013f55f4283c7d96755d95a60c1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119305
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [794be42bcc89460371d950f1c2922801dcb431f9]

        flatten maTables in ColumnSpanSet
        
        Change-Id: Ic32e0aa40cd678a7b0b28a7a6d7478250b3b7b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119306
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f974eceb0e49f5e8cdbc8b9990a74811feb1927]

        flatten ScDetOpList vector
        
        Change-Id: I08256d2e4631fe4a2134da37892a50f8b0579834
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119308
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Attila Szűcs  <szucs.attila3@nisz.hu>  [ad4e6f8c8f3d9d96586967f8e9a813bf29c3033a]

        tdf#142854 XLSX import: fix grid visibility in headless mode
        
        Fix regression from commit 759103fd65f82fc131679eba0de05f2ddc7294c8
        (tdf#126541 XLSX import: fix View grid lines).
        
        Sheet based grid visibility shouldn't overwrite the
        global grid visibility, except for headless mode (i.e.
        for command line batch mode, see --convert-to in ./soffice
        --help, otherwise we could get a regression here:
        The sheet based grid visibility (bShowGrid) is stored
        in view settings. Headless mode means not to export view
        setting, including sheet based grid visibility.
        As the old workaround, use global visibility to keep the
        losing sheet visibility.
        
        FIXME: headless mode only works correctly if all sheets
        have the same grid visibility. The sheet based bShowGrid
        should be moved to another location, which is supported
        by the headless mode, too.
        
        Note: now the modified tdf#126541 unit test checks the
        fix for the regression of the headless mode, and the new
        Python UI test checks the (now improved) fix for tdf#126541
        on the desktop.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I93551d22cc5d858dc64f93a46cd8aa202b4b2df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118599
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [94449b59061457cfb4321a2dadaeee15f8b7922b]

        Use MapUnit directly here
        
        Change-Id: I745503ca1cae88519ac32e946849302b46e0ccb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119297
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-21  Mike Kaganski  <mike.kaganski@collabora.com>  [42de48d099d6cb5cf8507385d50328f20034c08e]

        Prefix members of EditTextObjectImpl
        
        ... and re-arrange them a bit to optimize memory layout
        
        Change-Id: Ia543a68b446b9d9e49828112f3aa0054607cb2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119296
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [4ea92c9a591825b2b1f6ebe5c1fc9d00e75e2e5f]

        flatten data in SdrGluePointList
        
        no need to allocate SdrGluePoint separately
        
        Change-Id: I7cc6bc22a1d43da8fdd2a4c951246955b96a7c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Dennis Francis  <dennis.francis@collabora.com>  [4eaf7e4bf2bd1b1b3d3e7b0c987c472cdd836dc6]

        lok: fix incorrect multi-view table selection updates
        
        Use the correct writer shell to fetch selected table info, else the
        active view's table selection data is sent to all views which is
        incorrect.
        
        Also avoid interference from draw empty table updates in
        SdrMarkView::SetMarkHandlesForLOKit() if we are in writer.
        
        [tml: In this branch, this commit also includes a fix from Miklos.]
        
        Change-Id: Iff8181a7d43712e3c9a23cee43a8b6b98ba032d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119299
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-21  Szymon Kłos  <szymon.klos@collabora.com>  [0acac258be8c07dbea5579561ead2c6e093fd441]

        jsdialog: don't send unnecessary show/hide messages
        
        Change-Id: Ie37503b5964606a2b3e5b305c949f570616dc1cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117070
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119243
        Tested-by: Jenkins

2021-07-21  Szymon Kłos  <szymon.klos@collabora.com>  [65dc2a8948fb24bd82470ea40820c6183e479c43]

        jsdialog: send GlowColor state updates
        
        Change-Id: I27e14610d7df231f05bd27ad3ce121361e198c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118693
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119245
        Tested-by: Jenkins

2021-07-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [70b7bbc41299b65560f3339adc6a15fa9152f635]

        can pass SfxItemSet around by value in SfxShell
        
        Change-Id: I80ee25c56da437d778e11f2dab3d07845ebd9597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119274
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-21  Miklos Vajna  <vmiklos@collabora.com>  [8286014d9d3b96cd69e462a19d666488f66a89c9]

        CppunitTest_sw_ooxmlexport3: 1 removal of DECLARE_OOXMLEXPORT_EXPORTONLY_TEST
        
        It shows that this is doable, but it also shows that we probably need
        some kind of loadAndSave() oneliner before a mass-conversion.
        
        Change-Id: Ia37423a2d84b4a155cfd5fa57b14b11f25fdd3eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119291
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [add4f7732840d362cb703ee3a894edfe2fd0eac3]

        qt5 a11y: Handle AccessibleStateType::MULTI_LINE
        
        This addresses warnings like
        
            warn:vcl.qt5:53343:53343:vcl/qt5/Qt5AccessibleWidget.cxx:639: Unmapped state: 17
        
        seen e.g. when navigating to a Writer paragraph in Accerciser when
        using LO with the kf5 VCL plugin.
        
        With this in place, the "multi line" state is correctly shown in
        Accerciser.
        
        Change-Id: Ib38a7374d9c81f2d5c361809583f711f4eadccba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119295
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [7be0f62de07aa3a046f0996eeb673d9a4d7c9672]

        qt5 a11y: Handle AccessibleStateType::MOVEABLE
        
        This addresses warnings like
        
            warn:vcl.qt5:151782:151782:vcl/qt5/Qt5AccessibleWidget.cxx:636: Unmapped state: 31
        
        which I started seeing when running LO with kf5 VCL plugin and Orca
        enabled after
        
            commit ddbc111555607e62b94b74aacadd6a964b9fe4a5
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Mon Jul 19 17:13:04 2021 +0200
        
                qt5 a11y: Set proper a11y states
        
        had fixed handling of a11y states.
        
        Change-Id: I00b8f2f75954fbd7d9e5f0807b51e5632d1a8035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119248
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [6c88244908409e1d5a4ffe5fffbad35f9892b9fa]

        qt5 a11y: Skip attributes without value
        
        Skip attributes with empty string value in
        'Qt5AccessibleWidget::attributes'.
        
        Besides not being a useful value, I also
        got a crash using Accerciser to navigate in Calc's
        "Format Cells" dialog -> "Font Effects" -> "Text Decoration"
        -> "Overlining" -> "Overlining".
        
        'Qt5AccessibleWidget::attributes' had returned
        "font-family:;font-size:0pt;font-weight:normal;"
        and 'AtSpiAdaptor::getAttributes' (from the Qt library)
        aborts, since it splits the "font-family:" part at the colon,
        then expects two substrings: one for the attribute name, one
        for the value - but there was no value set:
        
            QString joined = interface->textInterface()->attributes(offset, &startOffset, &endOffset);
            const QStringList attributes = joined.split (QLatin1Char(';'), Qt::SkipEmptyParts, Qt::CaseSensitive);
            for (const QString &attr : attributes) {
                QStringList items;
                items = attr.split(QLatin1Char(':'), Qt::SkipEmptyParts, Qt::CaseSensitive);
        ->      AtSpiAttribute attribute = atspiTextAttribute(items[0], items[1]);
                if (!attribute.isNull())
                    set[attribute.name] = attribute.value;
            }
        
        The IAccessible2 spec for the "background-color" text attribute [1]
        doesn't specify any default value to be used.
        
        Backtrace:
        
            Thread 1 received signal SIGABRT, Aborted.
                __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
                50      ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
                (rr) bt
            #0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
            #1  0x00007f4dcd0bd537 in __GI_abort () at abort.c:79
            #2  0x00007f4dba7fd810 in qt_message_fatal(QtMsgType, QMessageLogContext const&, QString const&) (context=..., message=...) at global/qlogging.cpp:1914
            #3  0x00007f4dba7f9d48 in QMessageLogger::fatal(char const*, ...) const (this=0x7ffc30a4a6b0, msg=0x7f4dbab9ebb0 "ASSERT failure in %s: \"%s\", file %s, line %d") at global/qlogging.cpp:893
            #4  0x00007f4dba7f1484 in qt_assert_x(char const*, char const*, char const*, int) (where=0x7f4db778eb36 "QList<T>::operator[]", what=0x7f4db778eac8 "index out of range", file=0x7f4db778ea90 "../../../include/QtCore/../../src/corelib/tools/qlist.h", line=579)
                    at global/qglobal.cpp:3366
            #5  0x00007f4db7736a65 in QList<QString>::operator[](int) (this=0x7ffc30a4a730, i=1) at ../../../include/QtCore/../../src/corelib/tools/qlist.h:579
            #6  0x00007f4db773017e in AtSpiAdaptor::getAttributes(QAccessibleInterface*, int, bool) const (this=0x557748f27800, interface=0x7f4d8c07cc30, offset=9, includeDefaults=true) at atspiadaptor.cpp:2059
            #7  0x00007f4db772cd74 in AtSpiAdaptor::textInterface(QAccessibleInterface*, QString const&, QDBusMessage const&, QDBusConnection const&) (this=0x557748f27800, interface=0x7f4d8c07cc30, function=..., message=..., connection=...) at atspiadaptor.cpp:1802
            #8  0x00007f4db77274f8 in AtSpiAdaptor::handleMessage(QDBusMessage const&, QDBusConnection const&) (this=0x557748f27800, message=..., connection=...) at atspiadaptor.cpp:1286
            #9  0x00007f4db7fe4d04 in QDBusConnectionPrivate::activateObject(QDBusConnectionPrivate::ObjectTreeNode&, QDBusMessage const&, int) (this=0x7f4d8c014b00, node=..., msg=..., pathStartPos=27) at qdbusintegrator.cpp:1458
            #10 0x00007f4db7fe58ca in QDBusActivateObjectEvent::placeMetaCall(QObject*) (this=0x557753615310) at qdbusintegrator.cpp:1617
            #11 0x00007f4dbaab3c66 in QObject::event(QEvent*) (this=0x557748f27800, e=0x557753615310) at kernel/qobject.cpp:1314
            #12 0x00007f4db96be845 in QApplicationPrivate::notify_helper(QObject*, QEvent*) (this=0x557747e30970, receiver=0x557748f27800, e=0x557753615310) at kernel/qapplication.cpp:3632
            #13 0x00007f4db96bbcfb in QApplication::notify(QObject*, QEvent*) (this=0x557747f1d8b0, receiver=0x557748f27800, e=0x557753615310) at kernel/qapplication.cpp:2972
            #14 0x00007f4dbaa70aba in QCoreApplication::notifyInternal2(QObject*, QEvent*) (receiver=0x557748f27800, event=0x557753615310) at kernel/qcoreapplication.cpp:1064
            #15 0x00007f4dbaa71452 in QCoreApplication::sendEvent(QObject*, QEvent*) (receiver=0x557748f27800, event=0x557753615310) at kernel/qcoreapplication.cpp:1462
            #16 0x00007f4dbaa7213a in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) (receiver=0x0, event_type=0, data=0x557747eff460) at kernel/qcoreapplication.cpp:1821
            #17 0x00007f4dbaa71acc in QCoreApplication::sendPostedEvents(QObject*, int) (receiver=0x0, event_type=0) at kernel/qcoreapplication.cpp:1680
            #18 0x00007f4dbaaff079 in postEventSourceDispatch(GSource*, GSourceFunc, gpointer) (s=0x557748056a30) at kernel/qeventdispatcher_glib.cpp:277
            #19 0x00007f4dbfe4ce6b in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #20 0x00007f4dbfe4d118 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #21 0x00007f4dbfe4d1cf in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
            #22 0x00007f4dbaaff7a2 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x557748062a70, flags=...) at kernel/qeventdispatcher_glib.cpp:423
            #23 0x00007f4db76af8fc in QXcbGlibEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) (this=0x557748062a70, flags=...) at qxcbeventdispatcher.cpp:143
            #24 0x00007f4db9255353 in Qt5Instance::DoYield(bool, bool) (this=0x557747f22580, bWait=4, bHandleAllCurrentEvents=2) at .../libreoffice/vcl/qt5/Qt5Instance.cxx:400
            #25 0x00007f4db9255465 in Qt5Instance::AnyInput(VclInputFlags) (this=0xd87f0c9bbde3ed00, nType=(VclInputFlags::PAINT | VclInputFlags::TIMER | VclInputFlags::OTHER | VclInputFlags::APPEVENT | unknown: 0x7fc0))
                    at .../libreoffice/vcl/qt5/Qt5Instance.cxx:422
            #26 0x00007f4dc594b64a in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:465
            #27 0x00007f4dc594be0b in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:532
            #28 0x00007f4dc594b357 in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:444
            #29 0x00007f4dcd2c4226 in desktop::Desktop::Main() (this=0x7ffc30a4c540) at .../libreoffice/desktop/source/app/app.cxx:1602
            #30 0x00007f4dc5967cc6 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:199
            #31 0x00007f4dc5967de7 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:231
            #32 0x00007f4dcd324e9f in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:98
            #33 0x000055774613895d in sal_main () at .../libreoffice/desktop/source/app/main.c:49
            #34 0x0000557746138943 in main (argc=2, argv=0x7ffc30a4c8b8) at .../libreoffice/desktop/source/app/main.c:47
        
        [1] https://wiki.linuxfoundation.org/accessibility/iaccessible2/textattributes
        
        Change-Id: I5e9d5121e69340ff728a87b4a6cb5c182d9ad11b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119247
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Michael Weghorn  <m.weghorn@posteo.de>  [a440bea2f96f4dccfaf40ef223986c386b6b34f7]

        qt5 a11y: Adapt loop for string construction here a bit
        
        Behavior should be unchanged.
        This is in preparation of changing handling for empty
        values in an upcoming commit.
        
        Change-Id: If913680ea544c24fea6e418fb27ccdcb396920cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119246
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-21  Eike Rathke  <erack@redhat.com>  [0cda081c9aa3b3dcb363f97bac60c845ce9a13e0]

        Related: tdf#135762 Suppress cout if not command line
        
        Change-Id: I9431221aadf97739bb197871f25fa151ef4c391c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119294
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [07bd6ccf98e2062739beed84e64345918546c64a]

        Use some forward declarations in <editeng/editobj.hxx>
        
        Change-Id: Ic6c36d4e0da53324ada9ff8a91e715d52ac24394
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119292
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [a85dfb250ec983b5e325ccd0e0dbef27a75f47ce]

        Use standard algorithm here
        
        It also compares sizes, so no need for duplicating check.
        
        Change-Id: Ica08af55da2ec8acfbeca333d32fe03929ee2cac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119189
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [8e8d3f4db94e0069a1d84378d295268f5037b016]

        EditTextObject: use virtual interface instead of pimpl
        
        Makes it simpler, and avoids extra allocations
        
        Change-Id: I301f628a2898f6421242808cbf8ce36c5acf9b0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119241
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [a11a06d38e145139a2a1c7d51510b4fc2222c3e1]

        osl::Mutex->std::mutex in AccessibleTextHelper_Impl
        
        Change-Id: I263295c817a188d1d499a8c92eb7f6f7be64ea79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119284
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [5dcdfa148f6def1cdee628e6f7f1ec2421f45e82]

        osl::Mutex->std::mutex in DisplayConnectionDispatch
        
        Change-Id: I590595adbd89fa3d4833de2743b71168448d4c2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [0f580560e917f37df94ed2e7ddff59661ae93d79]

        osl::Mutex->std::mutex in StarOfficeSHA1DigestContext
        
        Change-Id: I924796823230151a3edde2ead875cfc5bc5072d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119282
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [0c14226903804065bf6d6f52a05c2907b8c5a973]

        osl::Mutex->std::mutex in CorrectSHA1DigestContext
        
        Change-Id: Ia81e8edd84080a2cb750e2dce7b2e8879b66498e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119281
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [9bae1f1ad6be4d942c73cfbdd7b3ba55eb3fb983]

        no need to use a pImpl in CorrectSHA1DigestContext
        
        Change-Id: If7404f63833373c5ac2954c4aac129c52582989c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [42f5b019dd508be71545c54e00b860f3a2b6c7fb]

        no need to allocate the selectionOverlay separately in SvxTableController
        
        Change-Id: Ifa4696991c79c9fa56aa4ccbb264c7c34110b85e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [b285ea8606b99e2b85125ddf84af0e5e634bdd86]

        flatten the vector in NfCurrencyTable
        
        Change-Id: I4a024e2d8c9743374e58836f95aa1fcbdc406b5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119288
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [966ae2345ce09b73c2d8ea47abb983030cc580bf]

        osl::Mutex->std::mutex in BlowfishCFB8CipherContext
        
        Change-Id: Id70ec156ab9e06a48a5a2571fc0186bd63b280a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [d9f92805f15cf71f53a6a93f81805e088daca3d2]

        osl::Mutex->std::mutex in SwitchablePersistenceStream
        
        Change-Id: I4f34f9df3f760f112244845688b34663e5febb79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119278
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [a4a023f7f441d2d6281d06ec6293c583ebea4ab0]

        osl::Mutex->std::mutex in ByteGrabber
        
        Change-Id: I96ea49da6708041ac19e147f192c7e996d44b8ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ebde17fec5fa991bd211c56ca93b7e528eea5b8]

        no need to allocate child array separately in SvxRTFItemStackType
        
        Change-Id: Ie40cc3b2d05bbb16a2b33a6beb4fdb804454333e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119250
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Miklos Vajna  <vmiklos@collabora.com>  [f3b2fc2276ee8a7f64e73d9975d0143d1696362c]

        sw XHTML import, improved <object> handling for images: support more formats
        
        This was working for only png and gif in the past, handle more formats:
        
        - bmp
        - jpg
        - emf
        - svg
        - wmf
        - tif
        
        Change-Id: I2af42157428550977f0abab88f2ed728636d2a02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119287
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [3077399b156477963a22c6c89c432ff49583e2c3]

        no need to store data separately in SvXMLAttrContainerItem
        
        Change-Id: Idea4289c600a81f5c8dbb389343ef57a9623d11d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119251
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noelgrandin@gmail.com>  [afc9c4454f7bab73087c28ed454d1fd00968e124]

        osl::Mutex->std::mutex in OChildDispListener_Impl
        
        Change-Id: I0aa9e24d3ebcb5f89f2bf5b5759fa44985495b6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Tibor Nagy  <nagy.tibor2@nisz.hu>  [7eb0e52527e729a21973e70d5be8e0a6779ec748]

        tdf#142648 PPTX: import long slide names to avoid broken link export
        
        PPTX import renames the slides using their short title text.
        Apply this for the titles with 64 or more characters, too,
        abbreviating the title text instead of using the default
        slide name "page1", "page2" etc., because the default slide
        names result broken hyperlinks during the PPTX export.
        
        To test the fix manually, create a new hyperlink
        using text selection and Insert Hyperlink (Ctrl-K),
        clicking on Target in Document button on the Document pane,
        and selecting a slide name.
        
        Note: the problem still exists for the duplicated
        or newly inserted slides, which get default slide names.
        
        Change-Id: Iec1fab5a2ee862353766ed7e13b1501b3a325d0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118548
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-20  Julien Nabet  <serval2412@yahoo.fr>  [ed29da546754d0d11aa0cffd4dfe649cc95df722]

        tdf#143429: update harfbuzz to 2.8.2 version
        
        Change-Id: I263dc6da5be3ea55205076a1f4e263fe5bba31fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119232
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-20  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [6128e2d55f0d0c68d3c7f6fb69539ec800637947]

        tdf#142763 sc UI: add first page header/footer options
        
        Add checkbox "Same content on first page" checkbox
        (similar to the existing "Same content on left and right
        pages) to the Page Style dialog window, on the Header
        and Footer panes.
        
        Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388
        (tdf#121715 XLSX: support custom first page header/footer)
        and commit 52beb3907dd3c7e6ae112e263def1005272cecd8
        (tdf#142764 sc: import "Same content on first/left page").
        
        Note: to set different header or footer on the first page
        of the spreadsheet, disable "Same content on first page"
        on Format->Page Style...->Header (or Footer), and choose
        the "Edit..." button.
        
        Change-Id: I3348fde216424b8d2c662956eab27cbe5880fc1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117316
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-20  Heiko Tietze  <tietze.heiko@gmail.com>  [427d4b30a66bade5a9f3b0da337e1644f5dd7c8a]

        Resolves tdf#143048 - Make autofilter popop resizable
        
        Change-Id: I007b36c10f506d8df633664f3aa4831a13fa3225
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119242
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [63f92f185b78db5a575da58efac3f94a8cb5a5f6]

        Qt5 fix Qt::Popup window handling
        
        I guess to get popup windows somehow working, they were matched
        to Qt::ToolTip. Fixing that by removing SalFrameStyleFlags::FLOAT
        from the tooltip check, resulted in rather bizarre bahviour. The
        Qt::Popup window is modal, as documented, but wouldn't close when
        clicked outside, like normal popups. And I neither got any mouse
        button or focus events, just some leave or enter. The only way
        to interact with anything again, was by clicking somewhere on the
        popup where it can't take focus... and it has nothing to do with
        the transition setting either.
        
        In the end it turned out that Qt::StrongFocus prevented the mouse
        events to happen. Even without it the widget accepts mouse and
        keyboard focus, so nothing seems lost by omitting that for the
        Qt::Popup case; hopefully...
        
        Change-Id: Icda7bbe87268293a400fe0da551d2804675d4c2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119236
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [862fdb98ca271b60a831cd5420fd16d5f9c1c747]

        tdf#143298 Qt5 send SalEvent::KeyModChange events
        
        I originally omitted this in the Qt implementation, as I couldn't
        find any non-working use case.
        
        The implementation got a bit hacky, because Qt doesn't have a non-
        native way to identify different L/R modifier keys, so we must
        process the X11/xkb keycode ourself, which obviously won't work on
        Wayland... but most times this is not relevant, so the default
        modifier notification may be good enough.
        
        P.S. it's basically the same code then X11 and Gtk...
        
        Change-Id: I37fbfde4a33a966b6017f3e0c280e2c7ea91e4db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119235
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-20  Tünde Tóth  <toth.tunde@nisz.hu>  [d824db8ee208cff8029752ca753815be8ca2fff4]

        tdf#46184 sc AutoFilter: reset filter options to default values
        
        when the old filter entries are removed in auto-filter rules,
        because these options are not visible from the AutoFilter.
        E.g. now using AutoFilter doesn't apply copying of the
        previous standard filtering, changing also the active sheet etc.
        
        This fixes regression from LibreOffice 3.5 or more.
        
        Change-Id: I26b272dc738f3918ff5b2ca7e8fee3481d21460a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118603
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-20  Jan-Marek Glogowski  <glogow@fbihome.de>  [ec77a2ed0283cb3446f6e352fc329afd3dfb785c]

        tdf#143334 Qt5 don't reset buffer on style change
        
        This bug was "unveiled" by commit
        963f252cd1ea9c268a6ced68a3454b10cbee1a89 ("Qt5/KF5 get rid
        of unneeded own grahics handling"). I'm not sure why I ever came
        up with that code. Eventually we would need a paint event, but at
        least changing the theme correctly updated LO UI, so that seems
        to be handled correctly.
        
        Change-Id: I528b551180be184427eeeeeb2977e2b7da073ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119237
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [6c294343edc283aed0af392c09779fee572c0c4c]

        no need to allocate Sequence separately in CommandProcessorInfo
        
        Change-Id: I7f423dbbe9d7251a99397f1293239333fe7b0cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119216
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Tünde Tóth  <toth.tunde@nisz.hu>  [15684e5d595289e0a94efd80bbe203ca133845f2]

        tdf#123598 sc UI: don't show autofilter dropdown arrows
        
        on the result area when the "Copy results to:" option is true.
        
        Change-Id: I3da4a1098d8c7c0be6604451b7485312043c5ede
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118484
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-20  László Németh  <nemeth@numbertext.org>  [732b08b22eee2682351a9295be29188852fb0489]

        tdf#143399 DOCX import: fix lost endnotes or footnotes
        
        in a document containing both of them.
        
        Regression from commit 7dd8f8aace536a8e60e87e61ee1d90d61fba15eb
        "tdf#120351 DOCX import: fix slow endnote import".
        
        Change-Id: I0fe764f3b48dd2688afa4b7cf0ee6658737ef9fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119239
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [1688af45e37144991eb09664a17b01d6be8f4792]

        no need to allocate Sequence separately in PropertySetInfo
        
        Change-Id: If4843c3f419fac59ae8ce52b4004ce2dbb736f6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119215
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [650818bf8387636afce9af3672abb84f29b99ee2]

        no need to allocate Sequence separately in PropertySetInfo
        
        Change-Id: Ibe558facd380e832faaf450a36249620b98ee786
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119217
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Michael Stahl  <michael.stahl@allotropia.de>  [7d1175c46588c246c455cd7c8874136bf61197fd]

        framework: fix multiple-free in VclToolBarManager::Destroy()
        
        Multiple ImplToolItem with mnId 1000 are inserted in the same ToolBox
        and the problem is that only the first one gets its mpUserData set,
        because setting and getting that is based on the assumption that mnId is
        unique per container.
        
        So in Destroy() for every item with mnId 1000 the same AddonsParams
        object is deleted.
        
        The problem is that in ToolBarManager::FillToolbar() the local nItemId
        is copied, so its value never changes when iterating the loop because
        only its copy is incremented.
        
        (regression from ac1aefd5174258d9bcb41465ce566ed1a0819f3d)
        
        Change-Id: Ica47051f9447c2b9d1981f8373d754874f0f31b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119228
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-20  Katarina Behrens  <bubli@bubli.org>  [c1a8ff837e3e369561150c0022c6ab02aab27c2c]

        tdf#128612: Support applying pattern fill from toolbar
        
        List available pattern fills and add 'pattern' case to state and
        execute functions
        
        This is likely not perfect and there's still boatloads of code
        duplication that should be cleaned up eventually, but hey, it fixes
        the bug
        
        Change-Id: I3381a4271bb32a63c048cbecb0b54ebabe12ef51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119229
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [37d5cdef8d4678eed03909bd5459d52cd0a19ed7]

        no need to allocate Sequence separately in FilterPropertiesInfo_Impl
        
        Change-Id: I8a10d2c0a31624cfefa485ae1a7d080f96d2b83e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119218
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [4f025026a995eaf91c288d0698a998ed2b515dac]

        no need for a pimpl in ResultSetDataSupplier
        
        Change-Id: If2354e7a902bc4faf4a3870d12571c9049d7798f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119214
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Szymon Kłos  <szymon.klos@collabora.com>  [af0cc133129d18fae86b603b4af3e196af57f664]

        jsdialog: remove UITest based events execution
        
        Change-Id: I393893389d82a54a8d689caba3f2acb10cff533a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116930
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119199
        Tested-by: Jenkins

2021-07-20  Szymon Kłos  <szymon.klos@collabora.com>  [e5bfb1f0c4c29e34cf4647557230e740692efb43]

        jsdialog: sidebar: dump visibility state for widgets
        
        we need this to build all the widgets on the client side
        and alow then show/hide widgets
        
        Change-Id: Ib3d8fc673cc787925e19a6e9df673e923ed7ecef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116841
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119198
        Tested-by: Jenkins

2021-07-20  Szymon Kłos  <szymon.klos@collabora.com>  [002cd0c0c7a80a5ad488e40d3601b8e9d6aa5b19]

        jsdialog: don't send update if not changed checkbox state
        
        to avoid infinite updates in find & replace dialog
        
        Change-Id: If9d26cec66f2b4475c89ba394b9597bc23881341
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116886
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119197
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2cdfcbcf503b8eecd97877b1ecd24276e2b3534]

        no need for pimpl in HierarchyEntry::iterator
        
        Change-Id: Ie238c2c8278fea9aa95f35bf61065426f8431c7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119219
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Hossein  <hossein@libreoffice.org>  [bda4d7a7c3fcc259e023f568606be5dcba818db9]

        tdf#123321 Fix DOC/DOCX export bug which made some lines disappear
        
        * Fix the wrong calculation of SdrPathObj (line) extent while exporting
          to .doc and .docx formats. This resolves tdf#123321 which cause some
          lines to disappear after save and reload. This fix does not break
          tdf#91687
        * added tests to make sure this does not happen again, based on the
          .doc file provided in Bugzilla
        * Loading the bad exported file in MS Word is OK, but it does not work
          in LibreOffice, and some of the lines will be hidden. This needs
          additional work.
        
        The regression came from d72e0cadceb0b43928a9b4f18d75c9d5d30afdda
        
        Change-Id: Ic5a7af4d29df741204c50590728542e674ee9f91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119116
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [1738f106bd73fa2cf153905fc28b198d6f0cf211]

        Simplify SfxItemSet ctors and TotalCount using delegation
        
        Change-Id: I6f40cf80bcd6c8a53f5d25f99688526d4b946bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [59f2d8be6d43a57049db6ea3e425d49b5a3794e8]

        no need to allocate Sequence separately in DataSupplier_Impl
        
        Change-Id: Ibc66a88472051621262de87458f04b138a76d54f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119213
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-20  Miklos Vajna  <vmiklos@collabora.com>  [8e6e32ace693f0ca8a1b6fefd81832c4c7e7d5af]

        vcl: update outdated comments in pdfread
        
        These fake named arguments are useful when a function takes a lot of
        boolean args, but the comments didn't match the function declaration
        anymore. Fix that.
        
        Change-Id: I660bf2d496c463e1a027e5d3bdb8d6d7f07d0f55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119231
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-20  Stephan Bergmann  <sbergman@redhat.com>  [313513da3c75b290f5f77a7e47ce9a32980fbb5a]

        -Werror,-Wunused-private-field
        
        introduced for no apparent reason in d157c1bd70d630a58db33910d550bb8dee9fe62e
        "tdf#126665 Remember last used file picker directory"
        
        Change-Id: Iceb26e5bbbb0cad4acccce9489593aef322c14b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119234
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-20  Heiko Tietze  <tietze.heiko@gmail.com>  [137a1d5380e310a43d36932c643e1331a94fd70d]

        Resolves tdf#143066 - Language set to None for indices
        
        Disables spell-checking on ToC
        
        Change-Id: I6601d8c54974fcc70564292176a71a80d91020e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119222
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [c5ca46e75e28ba4245d8544ca53c71fea87d1bbd]

        Drop BuildWhichTable and avoid reinterpret_casting a struct to array
        
        Change-Id: I9312282fb2959d3b0e2ccdac32c97c65555a82c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119224
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Mike Kaganski  <mike.kaganski@collabora.com>  [d24ee3af9eeed6da3ba7f226dd93fbb721087a53]

        Use WhichRangesContainer::MergeRange instead of SfxItemSet::MergeRange
        
        The former is cheaper: it does not need to recreate item array each time.
        
        Change-Id: Iab65929b4f1a1325ebe572b37503b041371998ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119225
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-20  Johnny_M  <klasse@partyheld.de>  [92c586cecfb48e4054be575e087cd656c0f8778b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 17c560682a20858b0860796165806116f8152c64
          - tdf#132643 Translate German section IDs
            
            Change-Id: I927b90eadc2eb0102e942b1ff50803cfb2e552b9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119058
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Stephan Bergmann  <sbergman@redhat.com>  [cfab695d0e3bd5889cfa4b6e81300dd11d4eef72]

        Avoid bash'ism (comment in line continuation)
        
        bash appears to remove comments only up to the next line-continuation
        backslash/newline pair, while SUS mandates that the "<backslash> and <newline>
        shall be removed before splitting the input into tokens", and at least zsh 5.8
        follows that interpretation and thus complained about a `then` not followed by a
        `fi`
        
        Change-Id: Ifedb002f133a7bc4f79bb9bec3e8c97ccc704aaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119227
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [a541e611127f01f0aa96361df589fc588b2687f1]

        Using empty which range makes no sense here
        
        This is this way since initial implementation in commit
        6cd37e708c588c2a0a1a31e1ae4d35e11450fea4; still, this
        makes no sense, since this means that the property set
        is unused, and nothing gets stored in the set.
        
        Let's use a 1-element range here, matching the property
        set returned by corresponding GetPropertySet call.
        
        Change-Id: I6107e5144913a1776a79cdceb22c537629d7115c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119182
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e65f6e87b1eb97a4a639c37fbe49997d18fd994a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cb504dc5f92e4e7cd6264ef0d0dec65c26dfcb7f
          - Fix typos
            
            Change-Id: Ifdcc3bcff41f82e994ac9c77b2b083573b30ed80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119233
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [e1af6fefa0f0b919ccdacc9edfbae034e6347d46]

        offsetof is only guaranteed to work with standard layout types
        
        Change-Id: If9ba41a219d3c3b5bff838104b9a0df53030b8f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119181
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e397cd3ee1dc2720a380a9945f5d5d295997e9b]

        no need to allocate Sequence separately in CommandProcessorInfo
        
        Change-Id: I325e63f822af1d9a0213837f40e9cc2b3e466c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [323b26e119672f1468fbdcbb7c2578465e562094]

        sw: fix indentation for better readibility
        
        After 9a8c8053b4fb322edb1e45b891307cdad1f3d41f
        < Resolves tdf#113171 - Text box must not toggle command >
        
        Change-Id: I867a012f18634ee8f83bfa2899f97eec1fae4630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119202
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-19  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [214a738528780f308c00ef4d4953b57fd84c2c41]

        tdf#129571 Change translation context for one time unit dropdown
        
        Change-Id: I8e7b81557c5552a1406adc6e89bbbc707cff6ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119102
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [17c626e347377c586eccb8b007a1edc35b5a7824]

        Fix updating WhichRangesContainer using MergeRange
        
        I forgot that MergeRange is not modifying its object, but returns
        a modified copy. Added SAL_WARN_UNUSED_RESULT to it (but it seems
        to not have effect on Windows).
        
        Change-Id: I919146fc25a0992d543890464ccac75737647ee5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119230
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [a77cbb3148d2f16b765108e2d8ff5cf20e1aee58]

        Use reference to WhichRangesContainer instead of pointer in sw
        
        Change-Id: I8e6418ce08f339824433e9af52259b2a8f3bb71d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119226
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-19  Michael Weghorn  <m.weghorn@posteo.de>  [ddbc111555607e62b94b74aacadd6a964b9fe4a5]

        qt5 a11y: Set proper a11y states
        
        Set the states actually set in the
        'XAccessibleStateSet', rather than setting states
        0 to n-1, with n being the number of states present
        in the state set.
        
        With this commit in place, Accerciser now e.g.
        initially correctly shows the 'checked' attribute
        for checkboxes only if they are actually checked.
        
        (Better handling of updating states still needs
        to be implemented separately.)
        
        Change-Id: Idbc84f5754eae65cee471834c322b8ddfdb0bb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119223
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [1bfe0e67dd3e341c416ec49310668419d6afe1ad]

        no need for pimpl in PersistentPropertySet
        
        Change-Id: Ib5328b4d8e67c69f8dff1fc6406a9447d83a667e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8836f1f423aa9edefeedfbdec32ff15b84afc651]

        no need for pimpl in PropertySetRegistry
        
        Change-Id: I3186a4d6df95679ebb1ad3f127c01cd1dca8c94b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3cbdff0a01aa353f281e8d05277b52c09444944f]

        Fix typo
        
        Change-Id: I8babf7975eb3b8f3e43f72572e75cbf46f510b20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119147
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [711269c61ade941fd2e58c85f3ec7a4225d0a2ee]

        OStorage can be final
        
        Change-Id: I8c55993040245c51cd499d00757065e9914a18fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [b462867b420f42ac2d1bcf0e313d2085478dc30b]

        no need to allocate FetchResult separately in CCRS_Cache
        
        Change-Id: Ia4d85bd6f7c667a612b247178e4f1a2321f7940c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119211
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [09394e0d6987345f30b316ff44cf007199ec8f09]

        no need to allocate Sequence separately in CCRS_Cache
        
        Change-Id: Ia433c56f512f70f92926de851363d95071a760f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [37259db1518135af5f85171e0c9c1b1d5475970e]

        no need to allocate Sequence separately in CCRS_PropertySetInfo
        
        Change-Id: I8d3ad7909793cbd757b4cef34f363c17f45889cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7fa55386d0bcc7941b382658a7ace7017014e31]

        no need to allocate separately in PropertySetInfo_Impl
        
        Change-Id: Id5d4f360efd4e583557ba9d61544d34d895e0dcc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Miklos Vajna  <vmiklos@collabora.com>  [87f6a73fd136ae3d342d09426a27fbde7dbe0fce]

        sw XHTML import: improve handling of <object> with images
        
        The reqif/xhtml export can map images to a pair of <object> elements:
        the outer one contains the real image and the inner one contains a PNG
        fallback.  We used to import this back to OLE objects, except for PNG,
        which has a single <object> element.
        
        Improve this by allowing the pair of <object> elements as well: if the
        outer type is GIF, then map this to an image and ignore the inner PNG.
        
        Change-Id: I5c56720cf6a054208cd0478a54bdac15ffece9aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119221
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [e4f804852279006934731008a1b37aa674dcbe97]

        jsdialog: sidebar: avoid duplicated widget ids
        
        all controls for sidebar goes to the same window id
        we need different names for every widget so
        create valuesets with different name every time
        
        Change-Id: I69074e607bfe5fa6db665c0dbcae1f029d13a161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116836
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119196
        Tested-by: Jenkins

2021-07-19  Julien Nabet  <serval2412@yahoo.fr>  [695d926248acf6e26222b26242f95fb46066aae6]

        AbsGTBehavior should implement ILibEngine
        
        so we're sure all derivatives will have to
        
        Change-Id: I4e62d02f01382dbc95b28ffcb3d278aa31427f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119145
        Tested-by: Jenkins
        Reviewed-by: Todor Balabanov <todor.balabanov@gmail.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [1e0d4f454202ed19147715be6efba431719f4142]

        no need for pimpl in UcbStore
        
        Change-Id: I2cb101a9bbb01a5d48d6eeb3aca08a2befa89133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119205
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [5d4a59fd1e14e07d06f560a353e59df14dec5dd4]

        no need for pimpl in ScCellRangesObj
        
        Change-Id: If5f32a3d0eebf739187f3ce2efb69198e8baf8a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119203
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [bda0ea24f83ab5c8a6215f594d99ea680af55e5b]

        flatten RTTI code
        
        Change-Id: If56de2708254348b6b759ecdd2b1fb259562af69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119169
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [4f2b7a74b065d3f548c47429d38a280264e49e27]

        Add Handler for Transparent Read
        
        The handler separates MetaTransparentAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Icd044f6c4422222323a9898ef5d7f67732fbbc2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119170
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  Sarper Akdemir  <sarper.akdemir@collabora.com>  [ee922e67097c094293f6012e8cf35acce8317ebf]

        tdf#59323 pptx export: test for datetime footer backwards compatibility
        
        Extends the existing pptx export slide footers test to make sure
        exported datetime footers will be importable by previous versions
        of Impress.
        
        Change-Id: I0026860adb9bebdacc5b2b10fe5d0bf9d7ab419f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118028
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-07-19  Sarper Akdemir  <sarper.akdemir@collabora.com>  [888a71bc9253bd309d78b3affbed6fdd5ecd7bd8]

        tdf#59323 tdf#142228 pptx export: fix datetime footers backwards compatibility
        
        Versions before 166671f4aa19deec47c10a220ae1d29fa57faa93 do not
        import the datetime field as expected if there's no text in the
        datetime field.
        
        To compensate that, added placeholder text "Date" inside them.
        
        Fixes regression from: 25ae0de974befb9c279936046056a850d77e0dca
        tdf#59323: pptx export: add support for slide footers
        
        Change-Id: I8e35102bc0bb9a2e540cfdd59fb0dc2a0b23f185
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118008
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-07-19  Sarper Akdemir  <sarper.akdemir@collabora.com>  [7ec4a0872d16eb20d790eb8079ba538898fd2ff6]

        tdf#59323 tdf#142221: fix pptx datetime import export format
        
        fixed some problems from the original implementation of
        pptx datetime field formatting
        (2b0669eec0d86e973a7d8def8744c522bbf8af8b)
        
        also the comments on tests seemed to be based on en-IN which
        seems to differ a lot for SvxDateFormat::StdBig. So converted
        them to en-US's StdBig.
        
        expanded the tests, so it covers previously poorly imported
        types. Also made them use the SvxDateFormat and SvxTimeFormat
        
        Change-Id: I675c482d3095b5373975abb2e6e7eca2d353243d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118135
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-07-19  Mike Kaganski  <mike.kaganski@collabora.com>  [b1668edf7fa3ad8c32bcc4d73821770f2df011ca]

        Move svl::Items to include/svl/whichranges.hxx, and unify its usage
        
        ... in WhichRangesContainer and SfxItemSet ctors. Now it's not needed
        to explicitly use 'value' in WhichRangesContainer's ctor, or create an
        instance for use in SfxItemSet ctor (svl::Items is already defined as
        a template value of corresponding type).
        
        Instead of
        
          WhichRangesContainer Foo(svl::Items<1, 2>::value);
          SfxItemSet Bar(rItemPool, svl::Items<1, 2>{});
        
        now use:
        
          WhichRangesContainer Foo(svl::Items<1, 2>);
          SfxItemSet Bar(rItemPool, svl::Items<1, 2>);
        
        Change-Id: I4681d952b6442732025e5a26768098878907a238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119157
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b3c530016927d3e91e3124e124f7b428ab285ac]

        uitest: sd: put similar tests in the same file
        
        Besides, self.ui_test.close_doc() is already called within
        the create_doc_in_start_center context manager
        
        Change-Id: Ic5bb4cfa55fb3892172a073a1f40b8e916802c0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119167
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-19  Johnny_M  <klasse@partyheld.de>  [7cd43c743cb96ed6305f05e26a6c4bfb0bf87f4d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 66f80c13fa59a7c6d02470c8bcaaa11af7cc2c42
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id2ebf1ae3753e1bd2473a2ec8c9fcdbdaf5a68b6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119059
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [75ba272c9c0a5e8e334faa56d8a30fa0f18867df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 480cbadb642932d29b6ffe602ac1bb84a3edc333
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ibb2f0fc3af3b987ed19be43db2e11ee56ddaedbe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119057
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [5df9c1a918f89a3de4e087efff98ea044c7a047a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to decea6cf1217df3b62aa780087f483777876c06e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie2d8ced954d7b49d67a097da06037d0d6c57ad80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119056
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [c31b5b300fe72351847883ea59ed4f3b21d806bd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 30aa68716f23a5bcdd0476ce676faf1674bc42f8
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: I075a27bf7d60809770970b52487fe7b96e6e4b94
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119052
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [18911cc8c0486f5d30a9372cb2ebd4f0e7818560]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4bc45fb43ee33c82fb8f4c8cf55928827d937f0e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I74da86977b01fc4d90cdb3e9da6a1b5590c04355
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119055
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [a7bd115fe7fb2e75e748b08c052832e182d62835]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dae7cea036b324f41fc2d230fb79114b49d12fc5
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7153df88f46e51da0458ac5136a2c5cf9ec448be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119054
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [3cf6edb9a409a041255d5585d34a210721d17b44]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7abf32e2ba0775448b94e6a2770fe5d08cfda1c1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I132207aa2f2afb55d109a1281e5929710c69cf1a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119053
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [b0b15a077c48a3bfb816e9b8e8e059b4c20d6158]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab07ab3a351ec70f5561bd959cce02fa02e2487b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I08f8757bc0308084de4d68efbbfb633c7bf83323
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119031
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [b780903e0cd24f9c8809c1023591d1460b1b42ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5d2c62b18ac9c553c53f28a83beaa484ff4339be
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0d7cc4572918ee0ad759a9a8d6a94bce2806ad4d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119030
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [0495a2639cb5b1dea2211fc9c30225269be2f803]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9b9111bc680a5e5a23e5fe6c6db98532430eb2c9
          - tdf#132643 Translate German section IDs
            
            Change-Id: I234fc5c3533b5f52ee0a4fc601517589319546d2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119029
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [b8f5cebba68e2d7d93b62ff4d4828c0bfe40145f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b328960e2e09bba428a8f62a1b0926f006b0404e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7e011dcf8e6ba82a28ac3868c817320b538fbec3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119028
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Johnny_M  <klasse@partyheld.de>  [443fe6bb795822f9c34c7a42890e07770cdfad5c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e43bde91ae0080f71c6871bdd2f7e62873be9bca
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iee18a847073c19c8b2ad6442306f45f5f581737c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119027
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [9bd487c43e72186d3d9023d5fa90da0398811947]

        jsdialog: allow fraction numbers in spinfield
        
        Change-Id: I9849c6a798f0ade60606be75125fde98362d26b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119162
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [c3158c6a11fa1d79bce36789768f6811a5a82623]

        jsdialog: normalize value for spinfield
        
        Change-Id: Ia65b1342222952cbec1ddfba4b7464172fd2b40c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119161
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [9518eaf9db7f0de14401489170fad7408cfd127b]

        jsdialog: execute value action on spinfield
        
        Change-Id: Iee0a5c90ebbd9ca96a60e70678f2b20c32d1bb28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116137
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119160
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [35c4cc15f1cb02b437bc9cd6dd5593aae2b86042]

        jsdialog: send action event on show/hide
        
        This fixes non working comboboxes in the sidebar in online.
        Where we simulate picking from the list.
        
        Change-Id: Ie78e461b2bce7fa0ccd68731e76d0c721242b98e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116097
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119155
        Tested-by: Jenkins

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b018077789797490786f854fd725a4955715d6f]

        no need for pimpl in CellValueConversion
        
        Change-Id: I4d01fa33a8d9c4cf5610f25890ee6df9bca061bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119158
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [f5e030a343bec9f0f2c7b30e2dfb21ba5c94e5e8]

        tdf#143332 - Use utl::TextSearch to implement the InStrRev function
        
        Change-Id: I2dae038d061f036b3b7c0fbbcb6a821305d4839e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119094
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [903f7dd825caca1af15d985658043ec055c4eb45]

        Make obvious that this is in a try/catch block
        
        Change-Id: I1118ef026730481eeef127b570bfd59de4434455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119163
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-19  Noel Grandin  <noelgrandin@gmail.com>  [739aaf02db3353fac8490272cab0c9486570f76d]

        osl::Mutex->std::mutex in bridges/except
        
        I changed all the bridges to keep them in sync, but only
        tested on the LibreOffice CI machines.
        
        Change-Id: Id8fef017cc6c99c60d64b8f849220d5336abc5d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [0067c3bd377bea366cd61cc06bba3b8d521401d4]

        no need for a pimpl in BulkDataHint
        
        Change-Id: I82c1d61b79d6486f20e51a8814b08149765861d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119159
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [ef19c82f6ade323e2708b93d77cf50ffe8b9fcfd]

        merge ModuleImageManager into ImageManager
        
        they share an underlying impl, so no need to have separate classes
        
        Change-Id: I1093f72265f67c7ccf3c2a064c86441d792512d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Miklos Vajna  <vmiklos@collabora.com>  [7d1259319931eaa045198d55ce25bf2e1b27c806]

        sw: prefix members of SwXMLConditionParser_Impl, ...
        
        ... SwXMLItemSetStyleContext_Impl, SwXMLTextParagraphExport and
        SwXMLTextStyleContext_Impl.
        
        See tdf#94879 for motivation.
        
        Change-Id: Ia48f9840dde06531c2178ddf5c8ee5457b3706cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119152
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [5ae7cd1d9d40585602d69b5800cbb58795a733bb]

        jsdialog: early return if welded widget found
        
        Change-Id: Ib06b8dd6614bc6085ccf19f947b2c1f6e2d239c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119154
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [3a84543c9b52f681304564ebfb00db8da6a1d407]

        LOK: inform when input bar has cursor and focus
        
        Now the cursor is rendered on the Drawing Area so
        we need to send special message to inform that
        cursor is shown. This fixes bug in online where
        without cursor instead of sending character to
        formula bar is was send to the spreadsheet and
        formula bar was loosing focus at that time.
        
        Change-Id: I0b1e03900bec855b1378da364f0391f50dbceccb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115310
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119153
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [4bd116b28e8266558e40a8e7bf303a53da6a5730]

        LOK: Render correctly sized input bar
        
        Change-Id: I7c319be56ba59a002207a631f2b81136f806f84e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115243
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119018
        Tested-by: Jenkins

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [14c778017f79370e07b8acb5b801980ae9c7af02]

        Add Handler for RasterOp Read
        
        The handler separates MetaRasterOpAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I6beb3c546775c70b0f6a7fdcb9ca3e589bda099f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119092
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [ce0f7ae74e64d496f689c263a22776c5efc5ab3b]

        Add Handler for Pop Read
        
        The handler separates MetaPopAction::Read from metaact.hxx
        Read implementation is now in SvmReader
        
        Change-Id: I831ac97d29554e90773a939dcfedb383974e2495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118981
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [4c525a0ec8734c09474395f887e7f58d0410605f]

        Add Handler for Push Read
        
        The handler separates MetaPushAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I16a36af9dfea7526d429675b7b0d39d1bd1d6dcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118980
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [e6773aaa82a11485bf07c1e960f8c1df5f7f02d5]

        Add Handler for Font Read
        
        The handler separates MetaFontAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Id301813ceb29e13488a472ab8e3b2dfd9287d624
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118979
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  panoskorovesis  <panoskorovesis@outlook.com>  [a452a9180e5cdecf6fe4cb59c8658e11640bbb6e]

        Add Handler for MapMode Read
        
        The handler separates MetaMapModeAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I514fc1927705ae0e2ca870ad39af845e3d9285cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118968
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-19  Miklos Vajna  <vmiklos@collabora.com>  [801b607fc6b3890eb36d310074f1a68db9ae1f5e]

        sw: xDictionary may be an empty reference in SID_SPELLCHECK_IGNORE_ALL
        
        Seen in a crashreport:
        
                handleFatalSignal
                        ./common/SigUtil.cpp:255
        /lib/x86_64-linux-gnu/libpthread.so.0
                __restore_rt
                        ??:?
        program/../program/libswlo.so
                SwTextShell::Execute(SfxRequest&)
                        sw/source/uibase/shells/textsh1.cxx:1496
        
        Change-Id: I709f361a1396abbb07cea06509afc41bb5f5c9a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119067
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-19  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d7dff57384126e50b75c95e84fd3081db2f326a1]

        tdf#143125 sd: fix crash when closing Custom Slide Shows dialog
        
        regression from commit I6e97a69c546870199d5a45d9a6ad102e30d820c2
        
        Change-Id: I760dabeb024413f1a2aeb57434f63adedb4246f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118231
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [6c5c657ada6eb6b3f25509384e2de4c456ec0b78]

        Calc input bar add missing InitControlBase
        
        This allows to render correctly the widgets in
        InterimItemWindow in LOK
        
        Change-Id: Ie6a1a1570730ecb73f8a5377fa86c1a3c3355fbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115180
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119017
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [9dd28785c7d0d1604c85e00247782e1ebd2d69f8]

        jsdialog: dump toolbox item's window if present
        
        Change-Id: Ia882bcadb844993f2b761bd91c6f6f60c9e1b2ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114807
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119016
        Tested-by: Jenkins

2021-07-19  Szymon Kłos  <szymon.klos@collabora.com>  [37192a6f87a82e83eab03c06258d455f16694154]

        notebookbar: fix welded controls in online
        
        Additional parameter was introduced for InterimItemWindow
        and value for it was missing.
        
        Change-Id: I9dad0e4d60205db0c8cabfcf5c98fabc2d8fdefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114801
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119015
        Tested-by: Jenkins

2021-07-19  Noel Grandin  <noelgrandin@gmail.com>  [7712eb23bc97090fdd655a36dfca0019d43799e6]

        tdf#143409: fix Translation is not applied in some UI
        
        regression from
            commit 0771ac00acc8730f77db76b901724f1513a32723
            Author: Noel Grandin <noel@peralex.com>
            Date:   Tue Jun 15 21:12:25 2021 +0200
            use string_view in the Translate API
        Because I mixed string_view with C-style null-terminated
        strings.
        
        We are using string_view.data() to pass stuff to boost,
        but of course, doing that loses the fact that the string data
        has associated length, as it finds the length by looking for
        a terminating NULL.
        
        Change-Id: Ia0eb7be5621506dfe0a40a21f360da1b446f5591
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noelgrandin@gmail.com>  [4408001f5c0a76107d8fe01053a0e6348100a878]

        osl::Mutex->std::mutex in MappingsData
        
        Change-Id: I12f46a5468e7d7dde9bfde977adf4ea13eb89ae3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noelgrandin@gmail.com>  [e9570e324a750d103d0116a2e3495306757f1a64]

        osl::Mutex->std::mutex in ImplementationEnumeration_Impl
        
        Change-Id: I4bb9c6dc7efd76b730e2c8acf824b1e29bca8df5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119134
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Noel Grandin  <noelgrandin@gmail.com>  [d67cf46ba862ecdd8bdce451a996e64e2a86cd43]

        remove unnecessary rtl::Static
        
        no need to delay-init something we always need, and laying
        out a std::unordered_map is something we can normally do at
        link time anyway.
        
        Change-Id: Ide791d20394580bca615aa3ad564c154037e0816
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119137
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-19  Rafael Lima  <rafael.palma.lima@gmail.com>  [062bed270b30468437bf2dc6c092be7c724e4e83]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ae3eb149da355d5f65b638dcfb5332bd88983f6e
          - Python examples in SF_FileSystem help page
            
            This patch also adds a <variable> tag to 03160000.xhp to enable embedding in the "relatedtopics" section.
            
            Change-Id: I796753e0449fcf0141e5996ed709130716aea53b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118914
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-19  Jim Raykowski  <raykowj@gmail.com>  [c4016f246fde835c0cfdabbb7cc35bc6dd48fb24]

        tdf#128814 sw navigator: Make right-click select entry
        
        before context menu is shown
        
        Change-Id: I890efd794aaa88ac6bde6bf41b3976b8c27a3273
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118709
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [3d18cae102e16b85fb8787f5ec3b086bfa2bd7b8]

        osl::Mutex->std::mutex in ServiceEnumeration_Impl
        
        Change-Id: I3d754006c7c2766281d924253f2caa0ff4963fea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [b1d2383a3311811a283bea720d3f0f1bfcb0fc3c]

        osl::Mutex->std::mutex in GenericPropertySet
        
        Change-Id: Iee437489d40d038349f9faf860f2eca971932c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119142
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [48d60a717a588d93e82268dc80018ea9970c4e0e]

        osl::Mutex->std::mutex in NativeNumberSupplier
        
        Change-Id: I5430636438723f99b584dd95be9d7cb5264a5af9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119131
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [4799ee69d7193fcb1e8c105ef6c8b4ddc5e6721b]

        osl::Mutex->std::mutex in NumberFormatCodeMapper
        
        Change-Id: I79d95ca1e5aa29d0a416d8870430062fd2b9936a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119130
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [2b9afb52a96b86cb6f1aab2bdccca3b19566a8c7]

        osl::Mutex->std::mutex in linguistic
        
        Change-Id: I9cbd3da16fa122de2f1087be11969cb204aef020
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119141
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [4ab57949a2cbaacba33375ea33dc896205eac6c9]

        osl::Mutex->std::mutex in VtableFactory
        
        Change-Id: Ie973ef2923c1c725ee740000ebd1eacf671a5bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [6db41dd2649a9ddaf32fc779bed07dc7d61c1154]

        osl::Mutex->std::mutex in EnvStack
        
        Change-Id: I1339a362046c96d9056f70cd687d023a055b4cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119136
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [896e213395bdbd5adb3a62ece67fb28b4d78d6c9]

        osl::Mutex->std::mutex in NamingService_Impl
        
        Change-Id: Ief6cf9df4caafcf72e31394488c407acb5d545fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119132
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [198102e986d4db9067cc93e013c04cf3c96d227b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8e69592bb5095501ace05f4d231781d1bf420706
          - Refactor Help pages
            
            Change-Id: I4e08e55d279f48e59b2274e33d92aae7747f2eb4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119129
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-18  Caolán McNamara  <caolanm@redhat.com>  [f497a4e9da5d2375e428b03c423cc2d2e9995c4a]

        Related: tdf#143357 restore focus to MenuButton when popover pops down
        
        which already happens for ComboBoxes but not always for MenuButtons with
        popovers with widgets in them
        
        Change-Id: If2ab1934f582b01327f910a578b80e9462d3daa0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119078
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-18  Caolán McNamara  <caolanm@redhat.com>  [c85557c924ee83f9a29c07520c83d308ff5a4c79]

        poppler 0.73 doesn't have GooString::append(const std::string&)
        
        don't know what version is appeared in
        
        Change-Id: Ia1fff05aa58990e631d63a2e694be47a4b74e24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [8b69e7b26cb9812cc2ad778077db750260969a9a]

        osl::Mutex->std::mutex in EventAttacherImpl
        
        Change-Id: I44f23fd464479d2b89469179cefff50fc6defff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119125
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [e62e6b6d018e70bcb1f0486dd72e756b17861b0a]

        osl::Mutex->std::mutex in NameContainer
        
        Change-Id: I4d4e8eab2fb281c5ca330c82f2f5fa5d5e18463a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [ee652592142a063de6d3dd3369f488025c5aad8e]

        osl::Mutex->std::mutex in SequenceInputStreamService
        
        Change-Id: I3f47f4fbe6d2d65728af7d4715ae8f91c86c5532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119122
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Caolán McNamara  <caolanm@redhat.com>  [f69b4226579e8ead5e2501262af927d8c08ea1cf]

        cid#1487495 Division or modulo by zero
        
        the width of zero isn't going to end up as 0 in any real world situation
        
        Change-Id: I28eca0b495b139c4b2d70497a9c15898547d85fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119114
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e6af563b99b415b3188e3e11956c24d68e27930e]

        Fix typos
        
        Change-Id: I0a8ce634944df4af5c9e2000af5f6429b4e40b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119097
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-18  Arnaud Versini  <arnaud.versini@libreoffice.org>  [3785f97ec18feba9c5508559e5aed6d25cfc3aed]

        binaryurp : use std::mutex in outgoingrequests
        
        Change-Id: Ib0670af4596c5a40da27138d62b78df69bb77b9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [e0ba91b7e8a2f0d949677db1708bb0e6d8534389]

        better to use a std::vector here
        
        Change-Id: Ibd875907bc0618df3b27ed77625ff62c352019ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Julien Nabet  <serval2412@yahoo.fr>  [371ae1cf2307e5585f4f66f001c97d464cf44429]

        nlpsolver: DEPSAgent doesn't implement ILibEngine
        
        Fix this error:
        /home/julien/lo/libreoffice/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine
        public class DEPSAgent implements ILibEngine {
               ^
        1 error
        
        (on pc Debian testing x86-64 with master sources updated today
        openjdk 11.0.11 2021-04-20
        OpenJDK Runtime Environment (build 11.0.11+9-post-Debian-1)
        OpenJDK 64-Bit Server VM (build 11.0.11+9-post-Debian-1, mixed mode, sharing)
        )
        
        Change-Id: I1ce2d1a9ddee1020889f1a7a8fcd3387980b241f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119119
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [e2a3e483844e84445c316cad35fdfcaf3b18198d]

        osl::Mutex->std::mutex in Enumeration
        
        Change-Id: I1f4e99e4a3619b1381d01a16b98128ae9bbbce07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4b99e377473e74160627d3b257fec7b3bc8e7763]

        Revert "Some lower objects coupling."
        
        This reverts commit 7b93bae224c7c2c49b105ef97304bb46f8b68da5.
        
        Reason for revert: Does not compile
        /home/tdf/lode/jenkins/workspace/lo_ubsan/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java:45: error: DEPSAgent is not abstract and does not override abstract method setLibrary(Library) in ILibEngine
        public class DEPSAgent implements ILibEngine {
               ^
        1 error
        
        Change-Id: I72f2a22ab1f4119178f8002c21ba0845c4cd1bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119040
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [bd90d1c630c93cf39f9bd83fc69c568c9d7eb35a]

        osl::Mutex->std::mutex in ContentEnumeration
        
        Change-Id: I79457a4ffc957f6de47880fdc888648ab69d1349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119107
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [5db3a12dffd6edc96474a470728c1b89e129ca36]

        osl::Mutex->std::mutex in CachedTextSearch
        
        and drop an rtl::Static
        
        Change-Id: I17bd6ad0b81ecb947e4306819ddc7d83f8a51dba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119112
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-18  Noel Grandin  <noelgrandin@gmail.com>  [5060c0c8b9070c3093bf036de31c551ceb109ca7]

        osl::Mutex->std::mutex in ModeratorsActiveDataStreamer
        
        Change-Id: I9ea32f7f843a0255ce37de8b95d9fc9d29c43157
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Caolán McNamara  <caolanm@redhat.com>  [e6597ab3db99b70ea35ab071bc8634db63890224]

        make calendar button small-button style so it fits in limited height
        
        Change-Id: I1997ae2a3916372ded3d4120e4510144c6700777
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119081
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-17  Todor Balabanov  <todor.balabanov@gmail.com>  [7b93bae224c7c2c49b105ef97304bb46f8b68da5]

        Some lower objects coupling.
        
        Change-Id: I0a7c658d830f82d627d20b9ed7000f3c5b8f1f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119105
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [5be9e0760ed74906c27b484e0d3235e70ea6f1c8]

        osl::Mutex->std::mutex in SequenceOutputStreamService
        
        Change-Id: I1aaa9ebd76e2376be82b25f2659d4b0f22dc14e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119113
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [2f8635fc919906fe8238fa5ef9e77cfe2f23df83]

        osl::Mutex->std::mutex in ModeratorsActiveDataSink
        
        Change-Id: If1e4af0d9acf75bd0f2744f134a42c29e41d56f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [5962431c3d380f97f76c31869a1098e3efaa8b43]

        osl::Mutex->std::mutex in PropertySetMixinImpl
        
        Change-Id: I45ae292e95efc57a125807d15c6c259533dd5f92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119106
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Caolán McNamara  <caolanm@redhat.com>  [ecf901685ac0c6c7b27b81096bea96cdc3d2c2ca]

        Related: tdf#143357 set blank label for no date
        
        instead of current system date
        
        Change-Id: Ic504b34990a8ea5151ec653de2db860c1cd4b8ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [9e626a6d2a55a7159e4fd05d72275c7fe8bb0380]

        blind fix for ubsan div/0
        
        Change-Id: I0ee929c79d5ac94299adc84ba91d6b0683a8193d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119095
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Arnaud Versini  <arnaud.versini@libreoffice.org>  [bd4ee5ea9b0b79cfb8c03aa1f1d6008565b71bff]

        cppu : use std::mutex in DisposedCallerAdmin
        
        Change-Id: I3db567a9aed42167ea24eebcf673f19106595f83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117948
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2021-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [3581de4d1d7dc3910b4642a2baef534dcd882597]

        drop sal_uInt16* constructor in SfxItemSet
        
        Change-Id: Ifb283a49b01c9c6421e385f697e749439db6a53f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119008
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [3fec689480644c274501740013ff83388cb24245]

        use WhichRangesContainer in sw
        
        Change-Id: I8662b2e03b0dbe3a7206d8b59ae3556e3b2e75a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Szymon Kłos  <szymon.klos@collabora.com>  [18387b547ffbab2d19ab4968ea8194f7aee07192]

        Revert "Notebookbar: skip early init in all apps"
        
        This reverts commit 6af0a488a059982a8b5d72fe399c7e8841a2e9b4.
        
        Delayed notebookbar init in Calc causes "number format" combobox
        to not work. (it works after some number is typed into document only).
        Original problem fixed by reverted change doesn't exist anymore
        because new shortcuts for paste special and paste unformatted text were
        introduced
        
        Change-Id: Ie112ae0df7b6d3782916b98c96f1a17b15396115
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118771
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119101
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-17  Steve Fanning  <stevemfanning@yahoo.co.uk>  [6657a8714091e5acbff4ebe4ffe3a84269956a2a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b31f5bed5155ffcda336c3e7a1e18e60a7382228
          - Add example to help description of Calc's ROT13 function.
            
            Change-Id: I32c654dd8f86f508fce8555f033faa34b81b3e6c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119038
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-17  Szymon Kłos  <szymon.klos@collabora.com>  [6b1434529231f422deab2129639b16f3cd17f129]

        jsdialog: move list of enabled dialogs to separate file
        
        Change-Id: I98c92b336fbf76f3dc94265a408c9b3b46fcea08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115453
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119014
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-07-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b00e2abb633e2ce7c807d72a9ec93b1d3da2eee7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2271ad00c7e0312071b78706da40a778171bfb9a
          - Refactor database files
            
            Change-Id: I10909197c08cec40819658d2d0951800133409da
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119099
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [1b80998025e13fbf71017ac08fa607737e716429]

        move BuildWhichTable and simplify
        
        move it to the only place using it, and simplify
        
        Change-Id: I4a46b5d01f042e7b2e99b7dd1d28f67feda037d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119086
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noelgrandin@gmail.com>  [960ad8037275d86f15e0177f52a1d0dac25319e4]

        osl::Mutex->std::mutex in SharedStringPool
        
        std::mutex is slightly faster
        
        Change-Id: I0741cd1ed0a011d5e8d6099c189c85f50060a326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119087
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Andrzej Hunt  <andrzej@ahunt.org>  [137744a25b26d86b9be16a107b3bd011f6ab4b07]

        sdremote: introduce early return to improve handleAcceptedConnection
        
        This should make it easier to understand the handshake sequence.
        
        Change-Id: If06e98cdfe7295ed00efae61815a8696a90e9533
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119085
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Andrzej Hunt  <andrzej@ahunt.org>  [d6078e02832d13054e6552c6e20277fd1f3e83f6]

        sdremote: clean up now-unneeded "found" flag
        
        Since ???, this code now lives in a standalone method, allowing
        us to return as soon as know that the handshake is complete. This
        lets us remove aFound and simplify the code a little.
        
        Change-Id: I51d5281492d2e4280a101e67d606073f4d064c29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119084
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Andrzej Hunt  <andrzej@ahunt.org>  [fcc4d8e01360baa9ba0bf20eb5e7a1c9af793a02]

        sdremote: avoid infinite loop if client disconnects during handshake
        
        The following loop can turn into an infinite loop if the client
        disconnects at the wrong point in time, because pSocket->readLine()
        returns 0 (indicating disconnection), aLine remains empty (no data
        was read), and we just keep looping because we never bothered to check
        the return value:
          do
          {
              pSocket->readLine( aLine );
          }
           while ( aLine.getLength() > 0 );
        
        Aside from spinning unnecessarily, this infinite loop also stops the
        server from being able to accept any new incoming connections - in
        effect this causes a DOS of the server.
        
        Hence we need to start checking readLine's return value, and break out
        of this loop - and in fact break of the surrounding outer loop too
        (because we discard this connection and want to wait for another
         connection to arrive).
        
        Because of the nested looping it's hard to come up with a clean solution
        that only involves changing this loop - we'd probably need to introduce
        a temporary to remember that the client has disconnected, and check that
        temporary after the do...while - letting us 'continue' the outer loop.
        
        Therefore we first extract the code that handles newly accepted clients
        into a separate method, which then lets us simplify the implementation
        by returning at those points that we know a client has disappeared. That
        unfortunately makes this bug-fix patch a little more noisy than
        expected, but it is a refactoring that we'd want to make anyway.
        
        (There are further improvement we can make here, but I'll put those in a
         separate commit to simplify cherry-picking of just this fix. Examples
         include moving to smart pointers instead of new/delete, introducing an
         early return instead of the really long if statement, etc.)
        
        Change-Id: I13c6efa622a1b1de10b72757ea07e5f4660749fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119083
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Andrzej Hunt  <andrzej@ahunt.org>  [34309e232c13017c9d178627c652ebbbb5ffdeb3]

        sdremote: remove commented out experimental check
        
        The entire if statement was introduced only to check for experimental
        mode in the following commit - the xContext check is seemingly only
        needed for null safety:
          79c1b16a96a6 (sdremote: make it possible to have only bluetooth enabled, 2012-11-27)
        
        Later, the epxerimental mode check was disabled in:
          b9d2671ae11d (merge WiFi support into remote control feature toggle, 2013-08-01)
        
        Given that the remote is clearly no longer experimental, it's
        time to remove the commented code entirely - and I think it's also
        safe to remove the xContext check too. (Note: the remote IS still
        controlled by the EnableSdRemote option, and IS disabled by default.)
        
        Change-Id: Id118924021d5029b4f15df9cbb3eba28f3b902c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119091
        Tested-by: Jenkins
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>

2021-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [b1df9c67349cf4cc5be4128d797aefb87f50e38f]

        [API CHANGE] reduce cost of numeric conversion
        
        on a hot path, since we already know the length of these strings.
        
        Which requires adding some new variants of our string conversion
        functions
        
        Change-Id: I1877f8f3c72934c07f14eec7e73bbe8d7b0f1808
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119065
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [3545caa5aac59022d5c00d4a0c2a74657cbcae8d]

        osl::Mutex->std::mutex in OWeakConnectionPoint
        
        it is at least a little bit cheaper than osl::Mutex (since it's not
        recursive)
        
        Change-Id: I4ecbbf33045888b9f5111c4224346341e71d4b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119066
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-17  Julien Nabet  <serval2412@yahoo.fr>  [4a096b9c787fa2079ef1c8f00fed91d432d46fae]

        tdf#143400: fix query with most functions could not be created in GUI
        
        Regression from:
        https://cgit.freedesktop.org/libreoffice/core/commit/?id=04aafba860f613c20e7078d038cc83eb02de0b54
        loplugin:stringadd simplify some *StringBuffer operations
        pulled from a larger patch which I created with a more permissive
        variant of this plugin
        
        Specifically here:
        -------------- dbaccess/source/ui/querydesign/QueryDesignView.cxx --------------
        index 22408bbc58aa..63c5d07998ec 100644
        @@ -658,11 +658,10 @@ namespace
                             if  ( field->isAggregateFunction() )
                             {
                                 OSL_ENSURE(!field->GetFunction().isEmpty(),"Function name must not be empty! ;-(");
        -                        OUStringBuffer aTmpStr2( field->GetFunction());
        -                        aTmpStr2.append("(");
        -                        aTmpStr2.append(aTmpStr.makeStringAndClear());
        -                        aTmpStr2.append(")");
        -                        aTmpStr = aTmpStr2;
        +                        aTmpStr = field->GetFunction() +
        +                            "(" +
        +                            aTmpStr +
        +                            ")";
                             }
        
                             if (!rFieldAlias.isEmpty()                         &&
        
        Change-Id: Ib0b57e6c44a58a6a5f9c98aebc6a1213b35108d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119088
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-17  Tor Lillqvist  <tml@collabora.com>  [40556642e1f1e497251ec697a41cc67de3ace181]

        Bin useless comment
        
        Change-Id: Ifc7e36aa1df56cf532b698c8671cabbb35061bac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119076
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-07-16  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [113d308155e4b6a67a8510098a7db5f4a6632bdc]

        update credits
        
        Change-Id: I1a09193e888318084a7d9b3c76c049e373db545b

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ec78de2322f781a98802acc77cfb3e71a08eb3d]

        tdf#142923 Deleting comment in Writer leaves visual artifact behind
        
        Change-Id: Ia2e55886513e81847dd0ac6c697e7cea34e01bdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5636b633b4fcaf610426136c73dc3d1ede991030]

        Removed executable bits on source file
        
        Change-Id: I540ce9b69fcae15f12ac11ca6f66bb8fc7459985
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119073
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-07-16  Caolán McNamara  <caolanm@redhat.com>  [94d5fd4a948cb9fbe4d5260db30d20bae1d3177f]

        fix svl::detail::validRanges2(m_pWhichRanges) assert seen in dbaccess
        
        Change-Id: I4328d0eae0030d6455b80d8506496fe44cf02195
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [199f4827c293b70165d35d1161959004bcaf6f74]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ac68c2a4c5efff2c13ae474b37d12fb08be691ff
          - Fix typo
            
            Change-Id: I687dab780da7bcb3379cd2e2e52c1a5b47e98923
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119071
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-07-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e41077178a4e96f4c97af7d5e68abbdef34ff72d]

        Removed executable bits on source file
        
        Change-Id: I37cf25d37b8b3e5a7c7c1dd2f54bbcc2c9d77a65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119072
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-16  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1ae182f2503199f86ed9ec5690ca41e4b7213a91]

        Fix typos
        
        Change-Id: Iae3eec214849676be51ded133c1ffd9cf2e56ef0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119074
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-16  Michael Stahl  <michael.stahl@allotropia.de>  [86c0f58b6f9f392865196606173d1b98a6897f32]

        tdf#92796 ODF import: remove unused bitmap fills
        
        With CWS impress64 a partial fix for this was implemented to drop
        unreferenced named items including all non-color fills after ODF import,
        but this is only done in sd so move the code that does that to svx and
        call it from sc and sw as well.
        
        Implement some UNO interface for this, it's at least better than a magic
        string, and not obvious how a better solution would look like since it's
        known only at the end of the import if a bitmap is used or not.
        
        Another problem: when the Area tab is used to change to a different kind
        of fill, the items with the details for the previous fill aren't
        cleared, and so they are written to ODF files.  Hence bitmaps in the
        file can be referenced even if they aren't actually used, and bloat up
        the files.
        
        Fix this by dropping all unused draw:fill-image-name attributes in ODF
        import.
        
        Also do the same for Gradient and Hatch fills; Transparency gradients
        can be combined with anything so leave them as they are.
        
        Change-Id: I0b591fd9f963d974d0c3e7208b99621ad61dd93c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118950
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [4461e14d08c7d1c1c43b136a5a8e3acb868c0b51]

        avoid a map lookup on a hot path
        
        Change-Id: I4e514c7212c0b349796f3791b4c7f3f06d3fa22a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119064
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Caolán McNamara  <caolanm@redhat.com>  [a36447215fa13f3ca92b22ac63e8164859ddb8ef]

        Related: tdf#143357 explicitly set the default of focus-on-click
        
        this should already be the default according to
        https://developer.gnome.org/gtk3/stable/GtkWidget.html but it's
        apparently False nevertheless, so make it explicit here for these
        widgets where there is a focus watcher to commit their changes and the
        absence of this is non-cosmetic. Just these initially for a small
        backportable change.
        
        Change-Id: I96442b4e844ce0446f56276c1b648ca5ce57b740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119077
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-16  Caolán McNamara  <caolanm@redhat.com>  [ceb32f59d96a17c3007ed883fb44bc880673c8e0]

        crashtesting: UaF on layout of fdo53985-1.docx
        
        Change-Id: Id8ca0d277f485347e21bd8d6d68de2a7de13de48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119060
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-16  Caolán McNamara  <caolanm@redhat.com>  [3a5383892e1f0e22558cd56cb77d56a09c515b7a]

        Only change SwLayAction::m_bAgain via SetAgain
        
        no logic change intended
        
        Change-Id: Ib0174f8040faa3efde7b9c5ba9b062bac5a35da3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118983
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-16  Michael Meeks  <michael.meeks@collabora.com>  [c7b9f477f69c317e0482aeee79b1c2f070a1b981]

        vcl: check mpWindowImpl for nullptr.
        
        Crash in calc's mouse capture / end tracking.
        
        Change-Id: If5b4cded8ebfc04d1fcf645a7b74184532ab2338
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119034
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-07-16  Eike Rathke  <erack@redhat.com>  [75b789a8f542e729e9e5e21031b7baf452a8c174]

        Output proper language tag instead of Language+Country concatenation
        
        Change-Id: I83d7f94cf304a58f2ff68b2a667ba66de262f4f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119070
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-16  Eike Rathke  <erack@redhat.com>  [627a069822c8bd106fc05e1549997179143c6916]

        Output proper language tag instead of Language+Country concatenation
        
        That way also for more complex tags with 'qlt' language you get a
        meaningful output. It's only stderr, but..
        
        Change-Id: I3c6e2451ace5ac9f192a11c97e95376c17046f17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119068
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-16  Hossein  <hossein@libreoffice.org>  [ff93afcc76d5f82e74174825173075cd938a230c]

        Porting C++/Java DocumentLoader example to Python
        
        * Using UNO for Python
        * Opening the file in LibreOffice if it is listeing on port 2083
        
        Change-Id: I14b1a38da5d66dd2ee8c859071c148ce08a080d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118142
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [892bc8a15a09081b3de0afb9420abb5c2d110ea4]

        -Werror=class-memaccess
        
        gcc doesn't like memcpy here
        
        error: ‘void* memcpy(void*, const void*, size_t)’ writing to an object
        of type ‘struct std::pair<short unsigned int, short unsigned int>’ with
        no trivial copy-assignment; use copy-assignment or copy-initialization
        instead [-Werror=class-memaccess]
         1459 |         memcpy(p, other.m_pairs, m_size * sizeof(WhichPair));
        
        Change-Id: I44055d0d4dec589af7f98d62f106b701f1f5a4cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119063
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Eike Rathke  <erack@redhat.com>  [d019d044baa9ee798f8f9977ab5f89513dce5d23]

        Clarify that SvtLanguageTable::GetLanguageType() expects the UI name
        
        Apparently several places get that wrong and pass a
        lang::Locale.Language instead.. to be investigated.
        
        Change-Id: I7f20ae2b66de6527b70f9936ef8216ddc5dac835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119062
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-16  Miklos Vajna  <vmiklos@collabora.com>  [1e2420e7add9ca78e5f4de095dac2cef5c0f5940]

        extensions: bibliography database window: add UI to set a page number on a URL
        
        Again, to be consistent with the Define Bibliography Entry dialog which
        already had this.
        
        Change-Id: If43506a3c2cb105551df7ec8198a749315458409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119021
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-16  Eike Rathke  <erack@redhat.com>  [64f885a6c9d51999b737c0f61bc3a7fa311a5a94]

        Fix lang::Locale.Language usage, tdf#128191 follow-up
        
        Using plain lang::Locale.Language is always wrong, it may even be
        'qlt' for a more complex language tag. As the InfoBar message is
        "Please install the hyphenation package for locale “%1”."
        actually use the BCP 47 language tag of that character/paragraph
        attribution.
        
        Spotted in
        https://ask.libreoffice.org/en/question/280102/install-the-hyphenation-package-for-locale-ka/
        https://ask.libreoffice.org/en/question/238764/error-message-reads-install-the-hyphenation-package-for-locale-zh/
        
        Change-Id: I5805d4d711989a9d0260940666d3eb33eae830af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119020
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-16  Mike Kaganski  <mike.kaganski@collabora.com>  [caac77e62fe44aa8d5ef282b63765ae05148548b]

        Use WhichRangesContainer in editeng
        
        Change-Id: Ia6516df33341181990c2b8b8affa859395831007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119013
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-16  Caolán McNamara  <caolanm@redhat.com>  [cf480f81cb68de1f4cc9877c11b56bd5d4802a77]

        Resolves: tdf#143398 mouse event processed twice
        
        this is a problem since:
        
        commit 67b157e994d9bef01f6117b53fc29e1fee538715
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue Jun 29 13:00:45 2021 +0100
        
            tdf#143088 multiple Application::EventListeners is expensive
        
        turns out that AddChildEventListener is sufficient to get events
        for the widget and its children so the widget-only AddEventListener
        isn't needed or wanted
        
        Change-Id: I635419df10fce1d4441b2d85627a6cbe99adb6aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119019
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-16  Regina Henschel  <rb.henschel@t-online.de>  [4f93234639101fd018aba3f6e6f091f0470e0407]

        use common unit converter in docx import of wrap contour
        
        This is a follow up to commit af99c01570adc0c9205e1650d10866f80bb8118a
        to address the review comment.
        
        Change-Id: Iac0a6cf9cb29273229833465cd2d84cdbcc4a3d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119004
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-16  Mike Kaganski  <mike.kaganski@collabora.com>  [476d8b4088b723df883a8d33d018da68c6b03933]

        Drop unused ctor
        
        Change-Id: I5144d23d4e6f8e01035ef88a222f609184043c6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119005
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-16  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [afddd56a8049957b9c0e025992d47c04342dbb88]

        tdf#139840 - Use utl::TextSearch to implement the InStr function
        
        In addtion, fixed a crash if the start position is greater than the
        length of the string being searched.
        
        Change-Id: I9bcda1131324bdfac6957018e91b3a36dd2dc3d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118996
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [e7b632bc727413f399a4d0cbc2e92d90b04a3bf7]

        use WhichRangesContainer in sd
        
        Change-Id: I528905c14f40bee85689f24ebaef8e8fde1b107b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Kevin Suo  <suokunlong@126.com>  [07087041610ca8351d764c838ae07fa58f3bdf9e]

        restore compatibility with older popplers
        
        with poppler 20.09:
        
        /home/rene/LibreOffice/git/libreoffice-7-2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx: In member function 'int
                         pdfi::PDFOutDev::parseFont(long long int, GfxFont*, GfxState*) const':
        /home/rene/LibreOffice/git/libreoffice-7-2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:438:39: error: 'class
                         GfxFont' has no member named 'getNameWithoutSubsetTag'
        
        https://www.google.com/search?q=getNameWithoutSubsetTag&oq=getNameWithoutSubsetTag&aqs=chrome..69i57.784j0j7&sourceid=chrome&ie=UTF-8 suggests it was added in 20.12
        
        Change-Id: I4eacd2d740cb689ff9b3c6cab59376e01b1ba162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118977
        Tested-by: René Engelhard <rene@debian.org>
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Deb Barkley-Yeung  <dbarkleyyeung@gmail.com>  [44db9f08077f388306ef0bf7277c93a1e5cd89b8]

        tdf#139654 Font feature sensativity
        
        Disable font preview's "Features..." button if there are no features
        
        Change-Id: Ibcf6b34abe55818a3b938a65f4fd720ed724c8ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118965
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-16  Justin Luth  <justin_luth@sil.org>  [fce76110e02409b67ad977ae0077adf55ca58065]

        tdf#82111 rtf import: ensure CR before section break
        
        In other places, there were caveats for applying a CR
        when inserting instead of importing, or when in a header,
        but none of those seem to apply in this case.
        A section cannot occur in a table, and anytime a
        section occurs, it ought to finish off the paragraph.
        So a simple clause seems good enough here.
        
        There were basically two different existing unit tests
        that match this condition, and neither of them
        were currently mis-handled. I safely adapted one of them
        to imitate the error condition I was addressing.
        
        Change-Id: Ie8ccd3978276bf10321e0bf80141572f40102874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118819
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-16  Miklos Vajna  <vmiklos@collabora.com>  [b42fe2e2653775743d20f02356a73aa8e3c2696a]

        sw: handle mbProtectForm when replacing compat options
        
        This is off by default and it may be in for Word documents.
        
        Change-Id: I5f694bb505c2b43bea67712a2076dc5f370d03b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118994
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f8095a1b412f8f57d02a9b1c2e2dcd382585143]

        use WhichRangesContainer in sc
        
        Change-Id: Ie14250245aa2a8618b3ad6b7a355942621b40833
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118998
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [8b08529d6506bfcba9b5658429a1cf4f59c5fbcd]

        use WhichRangesContainer in reportdesign
        
        Change-Id: I8ae7e48a1fd0bd5504d68b04ee0af3b3d51d58cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118997
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-16  Andrzej Hunt  <andrzej@ahunt.org>  [f4ea1e6095ff751cbecf10061c4eff9934ffd520]

        sdremote: Transmitter: s/mQueuesNotEmpty/mProcessingRequired/
        
        Make mProcessingRequired's name a bit more self-explanatory to make it
        clear what we're actually using it for. See also a 8e6cdb0 which
        fixed a race condition caused by incorrect use of this Condition.
        
        Change-Id: I6ad63dbd5ae8ed767f42ea22e568ac47a4d08642
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118752
        Tested-by: Jenkins
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>

2021-07-16  Mike Kaganski  <mike.kaganski@collabora.com>  [01c0cf63be7155531e1240d79e3936f8c4600864]

        Move validity check to svl::Items, to avoid invalid WhichRangesContainer
        
        This uncovered lots of pre-existing invalid ranges, e.g. introduced
        in commit 6dbfbebad37fd84208e4c336f0864d26019db153, or in much older
        commit 46952138c938730afcc3607e1a524bb590b0e30e.
        
        Also this makes the static in svl::Items to be array of WhichPair,
        to avoid questionable reinterpret_cast in WhichRangesContainer ctor.
        
        Change-Id: I86030b2a2ac0a6d98870f8f7f5cc83e071c6597c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119003
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-16  Eike Rathke  <erack@redhat.com>  [da13b76e07231131cb951868a314ee6f51c0f254]

        Resolves: tdf#143372 Exclude {qtz} KeyID from SvxLanguageBox list
        
        Change-Id: I3e52407a33f79713635063ff4ba374267eb98005
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119002
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-15  Steve Fanning  <stevemfanning@yahoo.co.uk>  [ce609485630427ed30a8e6e4d3c6d16c4033b519]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 435e1e0e429e9d743cf11d08cb10f9f25b83e3b3
          - Delete erroneous statement from help description of Calc's REPT function.
            
            Change-Id: I5958f787798d309a7896ac47e1caa5eeeefbef96
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118926
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-15  Steve Fanning  <stevemfanning@yahoo.co.uk>  [082599db722fc662b9c235d618d4787708c09a96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 11c68842e216735f261fd065750a91ba98b42be1
          - Correct misleading descriptions of parameters passed to Calc's REPLACEB function.
            
            Change-Id: Ib145bf71a258f5f58fac4ed90a7a3e3ff509a454
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118925
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [ecd6e3ac757575deb3162b3bdd470b6a74f5dd70]

        use WhichRangesContainer in chart2
        
        Change-Id: Iedb30b5dae868953517c0bb87fcfc91d747ae65f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118995
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-15  Eike Rathke  <erack@redhat.com>  [92d7ab0f9822bad7b003b317b6f08b7f84441ff0]

        Keep ScAsciiOptions in sync with ScImportOptions, tdf#135762 related
        
        Change-Id: I9b8689e9d91c4ce35c0069209a79b639bb0b8509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118989
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d1692179e7cdca19ab34fdc9701512656f01861]

        drop the Pair constructor from SfxItemSet
        
        just so we have one fewer odd constructors here
        
        Change-Id: I81278e9436747a4eb46a33da9bfec7a8b30079b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118982
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-15  Caolán McNamara  <caolanm@redhat.com>  [a449b624b24515764a2a494e831583218ee54097]

        crashreporting: Crash seen in CachePreview from Idle UpdateHdl
        
        the intent here is regenerate the previews if font settings changed
        which should mean that we restart at index 0 and not continue from
        the old index
        
        https: //crashreport.libreoffice.org/stats/crash_details/a01c5fcd-983b-40ab-b90a-8ee90286e5b8
        
        Change-Id: I9604ad96cf6cc757d2d33469827d1295d309454d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118987
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  Caolán McNamara  <caolanm@redhat.com>  [b8b27b7c4baaf7554a28383e0f66eabc6dd03dca]

        the freetype font cache mentioned in this comment no longer exists
        
        Change-Id: Id9821a37d5b737b67b4ac631e04880b32ebf3a9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118986
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [554c3692b7e3b51ce6ce7772509ba7a2e8777d3a]

        tdf#134452 sw: fix page break disappears after applying table style
        
        After setting the break and pagedesc property of a table, applying a table style (autoformat) caused the loss of these settings.
        This was because, when applying a table style, the SwTableAutoFormat::RestoreTableProperties() overrid these settings with its own default settings.
        As the autoformats can never be modified, and they don't really use these two props, the easiest way to prevent any problem was to completely remove these properties and its uses.
        Unfortunately, m_aBreak couldn't be removed entirely, as the autoformats are stored in a binary file, and to be able to read and write these files the offset of the subsequent items must not be changed.
        
        Change-Id: Ieba439d3ba5da892b39f00f8b61c5c8467306635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118662
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-15  Henry Castro  <hcastro@collabora.com>  [0e7021de592b07894c57ab920acb40e10be8b26e]

        lok: include the label of the status indicator
        
        Change-Id: Ib2714e3d2b6add54ffba753d3519aeba7a3f1959
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118658
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-07-15  Caolán McNamara  <caolanm@redhat.com>  [03ec34f3a556f67c6cf812e9543c15fb1f618383]

        resave with latest glade
        
        Change-Id: I76a4d8f77b39563d1f7c0a1b0387b69764437ad1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118975
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  Julien Nabet  <serval2412@yahoo.fr>  [48b6f94fa2fb533b9c5becb348a1433fc6b4175b]

        tdf#143355: fix crash with .uno:FontWork
        
        with gen rendering part of bt:
        2  0x00007fbfb39f440f in __assert_fail_base
           (fmt=0x7fbfb3b5d128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=<optimized out>) at assert.c:92
        3  0x00007fbfb3a03662 in __GI___assert_fail
           (assertion=0x7fbfac2531b0 "!w || dynamic_cast<T*>(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=0x7fbfac3ad73e "T *VclBuilder::get(const rtl::OString &) [T = VclBox]") at assert.c:101
        4  0x00007fbfabb27ace in VclBuilder::get<VclBox>(rtl::OString const&) (this=0x6e07e70, sID="DockingFontwork") at include/vcl/builder.hxx:438
        5  0x00007fbfabb065e5 in SalInstanceBuilder::weld_box(rtl::OString const&) (this=0x6ce97c0, id="DockingFontwork") at vcl/source/app/salvtables.cxx:6811
        6  0x00007fbfb07d3fe9 in SfxDockingWindow::SfxDockingWindow(SfxBindings*, SfxChildWindow*, vcl::Window*, rtl::OString const&, rtl::OUString const&) (this=
           0x6e37c90, vtt=0x7fbfafd55730 <VTT for SvxFontWorkDialog+8>, pBindinx=0x34f62b0, pCW=0x6e39c00, pParent=0x34f6f40, rID="DockingFontwork", rUIXMLDescription="svx/ui/dockingfontwork.ui")
           at sfx2/source/dialog/dockwin.cxx:774
        7  0x00007fbfaf7c3be8 in SvxFontWorkDialog::SvxFontWorkDialog(SfxBindings*, SfxChildWindow*, vcl::Window*) (this=0x6e37c90, pBindinx=0x34f62b0, pCW=0x6e39c00, _pParent=0x34f6f40)
           at svx/source/dialog/fontwork.cxx:179
        8  0x00007fbfaf7c728c in VclPtrInstance<SvxFontWorkDialog>::VclPtrInstance<SfxBindings*&, SvxFontWorkChildWindow*, vcl::Window*&>(SfxBindings*&, SvxFontWorkChildWindow*&&, vcl::Window*&)
           (this=0x7ffc6e31bf70, arg=@0x7ffc6e31bf78: 0x34f62b0, arg=@0x7ffc6e31bf68: 0x6e39c00, arg=@0x7ffc6e31bf80: 0x34f6f40) at include/vcl/vclptr.hxx:279
        9  0x00007fbfaf7c1dcc in SvxFontWorkChildWindow::SvxFontWorkChildWindow(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*)
           (this=0x6e39c00, _pParent=0x34f6f40, nId=10256, pBindings=0x34f62b0, pInfo=0x7ffc6e31c230) at svx/source/dialog/fontwork.cxx:169
        
        See full bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=173585
        
        with gtk3 rendering, no crash but:
        (soffice:33916): GLib-GObject-WARNING **: 20:40:33.018: invalid cast from 'GtkGrid' to 'GtkBox'
        
        put grid into a toplevel box (git show -w to see minimal diff)
        
        Change-Id: I05f9a295cd839f782467b85d6bafd652a405b14d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118953
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  Caolán McNamara  <caolanm@redhat.com>  [2cd936a882418b6babd8f37a83077e1bab5fb934]

        tdf#143327 keep selection bounds on replacing color
        
        so select-all and type 'a' will retain cursor at position 1
        
        and
        
        delete/backspace keep cursor position in a semi-rational way
        
        Change-Id: I802f132e58cea9f111deb1c6d157706d08cb5b81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118978
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  Noel Grandin  <noelgrandin@gmail.com>  [5d0a231b29dfd4d587c7a4d1bbda6a511f94ec77]

        WhichRangesContainer, reduce malloc in SfxItemSet
        
        SfxItemSet shows up in perf profiles frequently,
        and the hottest part is the malloc of the two arrays we need.
        But most of the time, one of those arrays is a compile-time
        constant.
        
        So this change introduces
        (*) WhichRangesContainer, which manages whether the SfxItemSet
        owns the array it points at or not.
        (*) a static const member in svl::Items (idea from mkaganski)
        to store the data.
        
        Change-Id: Icb8cdbc4d54fd76739565c575e16a744515e5355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118703
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-15  panoskorovesis  <panoskorovesis@outlook.com>  [df9ca514d4e9ea87bbf0a96d99181ed8965cd45a]

        Add Handler for TextAlign Read
        
        The handler separates MetaTextAlignAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I71953850d7bde50a552e0dc0a568175f15746e00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118967
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  panoskorovesis  <panoskorovesis@outlook.com>  [f07e428f76c3498583cf4870e96a3b759bcc364c]

        Add Handler for OverlineColor Read
        
        The handler separates MetaOverlineColorAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I3d713e7579e45efd49249425108b74ca1d54eb0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118957
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  Eike Rathke  <erack@redhat.com>  [fda91f8be16ba760e360940ebafd6244c648cb8c]

        Related: tdf#135762 Allow --convert-to csv to specify 1-based sheet number
        
        Same multifile mechanism as for -1 all sheets is used, so
        
        soffice --convert-to csv:"Text - txt - csv (StarCalc)":44,34,UTF8,1,,0,false,true,false,false,false,2 sample.ods
        
        writes a file sample-Sheet2.csv
        
        Change-Id: Ib9248c9561e4e340c88458ac5dfd159e443a4cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118971
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-15  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [246c766cadcafc5d26f39f832a683a13f2dfe40b]

        find-unneeded-includes: Add --headers option
        
        so that --recursive checks only header files.
        if omitted, --recursive checks source files.
        
        Change-Id: I7406e90dc4df4603b62d23751d3c78a1fdedec38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118959
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  Caolán McNamara  <caolanm@redhat.com>  [2d496c3b1c0912c747bf7a83a4a982fd2dc3a801]

        tdf#119695 only add word to autocomplete suggestions when the cursor leaves it
        
        so that incomplete words are not added as autocomplete candidates even
        if they form a legal word. This is similar to what we do for marking
        words is misspelt
        
        Change-Id: Ib6b209b68bbcf51fa24ea5c4d995579acf682e52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118974
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-15  panoskorovesis  <panoskorovesis@outlook.com>  [ac42d6d01fcb64e8093d7f7b2833e9f9e3538369]

        Add Handler for TextLineColor Read
        
        The handler separates MetaTextLineColorAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I30848cea0d4f22f8d9fe327dc74f9ef16ae45d09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118956
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ce3a9dcc071094121252a286aa88529ee09a4eb]

        tdf#111313: basic_macros: Add unittest
        
        Change-Id: Id6f8bc0998d4f79434d46017b998917dcc53ac6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118949
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-15  Miklos Vajna  <vmiklos@collabora.com>  [c6695a4aabeaae99174b7658f2b813788ecff7f0]

        writerfilter: improve comments around compat flags
        
        Make it more explicit which list is shared and which list is DOCX-only.
        
        See <https://gerrit.libreoffice.org/c/core/+/118960/3#message-09a4a96aa2d09e2182dac80bb4857a875155fff9>.
        
        Change-Id: I287dfe799eb8597ca0a8ad65ec677d8da79bf1e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118966
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-15  panoskorovesis  <panoskorovesis@outlook.com>  [eea6033404aebcba6f6473dda6c6d435bd31e831]

        Add Handler for TextFillColor Read
        
        The handler separates MetaTextFillColorAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ifbd9fc21090d02cf4acba48482089ccaa245ff91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118955
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [892488b64f09190896d5a14e3f555ca91b3449e3]

        tdf#58521 Enable ContinuousEndnotes compat option for RTF too
        
        Now it's used in RTF, DOC and DOCX import consistently.
        
        Change-Id: I062a5fbbdf6ee0ef4d3c86a09ce50ac3d588fae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118960
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  Miklos Vajna  <vmiklos@collabora.com>  [43f11dfb6674bb1e8a52ffba0682d692da8d45b2]

        sw: use SfxPoolItem::StaticWhichCast() in RtfAttributeOutput
        
        See commit 0025e80ba6d882f6f885499efaf37ab0e2ed699d (sw: use
        SfxPoolItem::StaticWhichCast() in SwTextBoxHelper, 2021-07-07) for
        motivation.
        
        Change-Id: Ifb3e2466dd25ad554b81cdac63742230072e64a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118952
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-15  YakovlevAl  <sanya89_muravlenko@mail.ru>  [2a31c5dd37012de5a52dbbc08937401fc38434fb]

        tdf#143148 Use pragma once instead of include guards
        
        Switch to #pragma once
        
        Change-Id: Id5436aee3398fe2ee0fecd125cb1e7f71e587c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118962
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [798d19c80853166042ce8a14edf4a25cd491d6aa]

        Fix UB calling operator<<(std::basic_ostream) with nullptr
        
        This resulted in segfault instead of a useful test failure message.
        Was this way ever since 548b360c0e4693aac0cbdd2fcc1aab433fc54010,
        and before in 6e31cbb4eaea3c6600248ba59a22853acc1d6606 and
        9791453283407a0a129a71767a290058ac759da2.
        
        Change-Id: I498d1c84a4eaf3e8180dedd67d1176cf6f8c1a60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118916
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-15  Mike Kaganski  <mike.kaganski@collabora.com>  [717dc8e3575a18e1e18dc446031e6db4e60a873d]

        tdf#143315: restore the stylesheet after clearing outliner object
        
        Prior to commit c4f615b359be56e88e4fbf9aaaf30affb29d57e2, pObj passed
        to SvxMSDffManager::ReadObjText was not initializing its properties
        (no call to AttributeProperties::GetObjectItemSet() happened) until
        call to CreateParaObject in the end of the function. Then it finally
        initialized, and called applyDefaultStyleSheetFromSdrModel, which
        applied the obtained stylesheet to the nodes of the outliner object,
        and resulted in OutlinerParaObject having correct style name in its
        ContentInfo structures, which then went into pObj.
        
        The mentioned commit added calls to SdrTextObj::GetTextColumns* in
        SdrOutliner::SetTextObj, called by SdrTextObj::ImpGetDrawOutliner
        indirectly. These calls initialize the object properties, and the
        stylesheet gets applied to the SdrOutliner and its empty node early.
        Then the call to Outliner::Init and Outliner::Clear resulted in the
        node being destroyed and re-created without stylesheet info. Then in
        AttributeProperties::GetObjectItemSet called from CreateParaObject,
        re-initialization does not happen, because the item set exists.
        
        When exporting to OOXML, the missing stylesheet required to use pool
        default value, which led to bullet being exported.
        
        The previous behavior relied on fragile and unspecified assumption.
        Instead, now we call SetStyleSheet after all operations, to make sure
        that the stylesheet information is present in the final data.
        
        Change-Id: I14de9017e4af92a2eaf12b3a0e090b0db7fcc759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118961
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-14  Caolán McNamara  <caolanm@redhat.com>  [9e2b0a7399bb53cba9ae4cdb3b0e2cbbe04d602d]

        cid#1487034 Untrusted value as argument
        
        Change-Id: I2c0edac58b92b9d828c62ff3b8859f23ed1d3c85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118954
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [8b6bcdcddbf76e256b142408c855889414a4dd33]

        Remove unused file
        
        Change-Id: Iac67ca026fd0463da67cef7838f9a36da04f3378
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118937
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-14  Andrzej Hunt  <andrzej@ahunt.org>  [8e6cdb02450a876b5c684eb621e1c9383fb1c428]

        sdremote: fix race condition in Transmitter shutdown to plug leak
        
        We need to acquire the mutex in notifyFinished() to avoid a race between
        notifyFinished() and the loop in run(). And we also need to check
        mFinishRequested) while holding the mutex to avoid the same race
        condition. While we're here, rename the mutex to make it more obvious
        that it's not only protecting the queues.
        
        The race can happen because the loop in run() blocks until
        mQueuesNotEmpty is set. It also resets mQueuesNotEmpty at the end of
        each iteration if the queues are empty. So if someone sets
        mQueuesNotEmpty in the middle of an iteration, and the loop later resets
        it, the loop won't continue iterating. But we're actually using
        mQueuesNotEmpty to indicate either that the queues have data OR that we
        might want to finish transmission.
        
        And the problem is that notifyFinished() sets mFinishRequested, followed
        by setting mQueuesNotEmpty in an attempt to get the loop to process
        mFinishRequested (at which point the loop should finish and return).
        But as described above, we can easily get into a situation where the
        loop resets mQueuesNotEmpty again (at least if there's no more pending
        data in the queues). In this scenario, the loop blocks forever
        (we won't receive any new messages after notifyFinished()), causing a
        leak of both Transmitter and any resources it's using - e.g. the
        StreamSocket.
        
        The easiest way to fix this is to make it clear that the mutex protects
        all internal state, followed by using it to protect all internal state.
        
        This issue is not a big deal in normal usage - it's a tiny leak, and
        users won't connect enough clients for accumulated leaks to pose
        any issues. But it's ugly, and potentially problematic for long-running
        tests which could run out of filedescriptors because of the socket leak.
        
        I will rename mQueuesNotEmpty to something more obvious (possibly
        mProcessingRequired) in a separate commit.
        
        Change-Id: I2e22087054f3f6a02e05c568b1832ccc5a8b47a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118751
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>
        Tested-by: Jenkins

2021-07-14  Caolán McNamara  <caolanm@redhat.com>  [12fe411cffb4cb7088f6af096b858e0c6c091c54]

        gtk4: add SolarMutexGuard on entering vcl from gtk
        
        Change-Id: I1f380c5f700b77520ce548963195ce30059f0633
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-14  Caolán McNamara  <caolanm@redhat.com>  [03f1d66a57e7093c85a906bc08e3ce3ee74f81e4]

        gtk4: convert GtkSeparatorToolItem to GtkSeparator
        
        Change-Id: I24c0e3b515df505085ae77c350eb6aecfc0db003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-14  Caolán McNamara  <caolanm@redhat.com>  [b8903bc106dad036acb3d117e5c4fc955697fe02]

        rhbz#1980800 allow --convert-to csv to write each sheet to a separate file
        
        Related: tdf#135762 except only currently implemented for command line use
        
        sample usage:
        soffice --convert-to csv:"Text - txt - csv (StarCalc)":44,34,UTF8,1,,0,false,true,false,false,false,-1 sample.ods
        where the new (11th!) final token ("-1") enables writing each sheet to a
        new file based on the suggested target name so output in this example
        is files sample-Sheet1.csv and sample-Sheet2.csv
        
        Only -1 for 'all sheets' vs 0 for existing 'current sheet only' (which
        is always sheet 0 from the command line) are currently options but the
        token could be expanded in the future to select specific sheets to
        export.
        
        Change-Id: Ib99a120f1a2c8d1008a7a3c59a6b39f572fb346e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118850
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [6c94eeb92fa0ea14814175276f35a25512cc6f2b]

        Fix typo in code
        
        Change-Id: I9e92dcee5f49f81aeadf9e2baa504a247bece33b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118948
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [f7d128f1223a28d5fdae53ceaad55bf3166a9036]

        tdf#98778: basic_macros: Add unittest
        
        Change-Id: I35468fb35f5c24af2138688d99af0e41ba672334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118944
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-14  Arnaud Versini  <arnaud.versini@libreoffice.org>  [c82914912f73f1fc9912d53fb60ca7a66379c560]

        cppuhelper : use std::mutex and remove useless rtl::Static
        
        Change-Id: Idb272e664c4b745c4db96e505b60905c93937900
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116746
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Kevin Suo  <suokunlong@126.com>  [12b57e43563a643dd653d78f3e2877ef75998d82]

        tdf#78427 tdf#81481 sdext.pdfimport: added unittest
        
        Change-Id: Ia112762f0ece1be589997f6b9be336424603a1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118947
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Kevin Suo  <suokunlong@126.com>  [b1ca6d3aae3b75ec3e5c1ef17d582bcec01fc7eb]

        sdext.pdfimport: <text:s> and <text:tab> don't have "text:style-name" attribute
        
        Per OpenDocument specs:
        * The <text:s> element only has a "text:c" attribute.
        * The <text:tab> element only has a text:tab-ref attribute.
        
        seen in the SAL_WARN message:
        warn:xmloff:221658:221658:xmloff/source/text/txtparai.cxx:137: unknown attribute urn:oasis:names:tc:opendocument:xmlns:text:1.0 text:style-name value=text13
        ...
        
        Change-Id: I02a29ac2c9f9db026caec19238cd97111ce587c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118946
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Kevin Suo  <suokunlong@126.com>  [6a1de4f74e2510029313771d2751b6cd59141acf]

        tdf#78427 sdext.pdfimport: more bold/italic/Oblique fixes
        
        e.g. the PDF in tdf#107812.
        Also added notes to the fontAttributesSuffixes list.
        
        Change-Id: I4a4dcba2d9369c6b09168a18784d2f6e7d08793d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118832
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [c3fc5aaa654b649be9adec8904f76272cd50bb16]

        tdf#114011: basic_macros: Add unittest
        
        Change-Id: Ib9a7e87b4c8159fd5fbaaaa66705cddae138fcdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118942
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-14  Miklos Vajna  <vmiklos@collabora.com>  [3be01c11e87f6989f75cc5d000afb3c4fe50b3ab]

        extensions: bibliography database window: add browse button for URLs
        
        To be consistent with the Define Bibliography Entry dialog which already
        had this.
        
        Change-Id: I1f2eda189ae594dbef9c7fd4f0f1a1d12dc6ad5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118939
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-14  Justin Luth  <justin_luth@sil.org>  [6d81084e4f5100b1c8204f30a91d7a5b79998508]

        tdf#141964 writerfilter CN: numId0 has different meaning for RTF
        
        For DOCX, numId means turn off numbering.
        
        RTF probably doesn't have numbering as part of paragraph styles,
        so it doesn't need a numId 0 to cancel existing numbering.
        This numbering is applied directly to the paragraph during import.
        So, for RTF, numId 0 needs to be treated just like any other numId
        (except for -1 through -5 although currently
        we only import positive numbers).
        
        The statement "if pList and numId > 0" is basically redundant.
        pList will not be exist for an invalid numId.
        Since numId can be zero for RTF, just get rid of the clause
        to avoid any misleading conclusions.
        
        And that is all that this patch is doing. It doesn't really fix
        anything, it just changes code that gives out the wrong impression.
        AFAICT, RTF never uses styles, and therefore it is always
        isNumberingViaRule and so is almost untouched by finishParagraph.
        
        Change-Id: Ibc89d00ce69ad09208254ed85710f1f1aed18074
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118910
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9a55b97e980bbf2a0ce12841f6168f1f7545ac96]

        tdf#40068 Remember last directory for basic/dialog import/export
        
        Change-Id: I9dee98a2018beb0b8d5a0e57b66dbd9d5390c71c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118883
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [e49ffd9ea4f3e183004f9f4aa4749f8fec46eb7f]

        Add Handler for TextColor Read
        
        The handler separates MetaTextColorAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ibff3c33b273efb581b8dbb03bddef9fd7c64f7fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118896
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [8f00b018cd035db040ec18bff5c53571e3f86f93]

        Add Handler for MoveClipRegion Read
        
        The handler separates the MetaMoveClipRegion::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I12f987a2887060b30ae0496a5785baffe8550dfa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118895
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [ce30918cfe59a702dfe5f69ed84d13a0cc3de4bc]

        Add Handler for ISectRegionClipRegion Read
        
        The handler separates MetaISectRegionClipRegionAction::Read from
        metaact.hxx. Read implementation is now in SvmReader.hxx
        
        Change-Id: I49f6667f2e439c18ec4bc0cbc8d74b8203fc1472
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118894
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [8a13231580a806e3ee9b2d197d4cc118f30ab157]

        Add Handler for ISectRectClipRegion Read
        
        The handler separates MetaISectRectClipRegionAction::Read from
        metaact.hxx. Read implementation is now in SvmReader.hxx
        
        Change-Id: I5db6d405ac926d8881acbb17b47610f24ce77994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118892
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Heiko Tietze  <tietze.heiko@gmail.com>  [9a8c8053b4fb322edb1e45b891307cdad1f3d41f]

        Resolves tdf#113171 - Text box must not toggle command
        
        Change-Id: I1985a377c9b299dce7d3e01d4e67099562008d22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118888
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-14  Johnny_M  <klasse@partyheld.de>  [cf168442ae74837e61939981475068a628fd21ad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5314f2bf56153760b4d704eb971b41638fc4c4d1
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic431c8645a11f1b9bc4fdfe1e7d2fbe051df4d65
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118907
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [5ea19e2dfbfa7517aff3b7bc38242506c7c41858]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4aa4029c1daf5a5137befc6a52dfa2c666a47b24
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: If36ee8cac32e1d5b9ef85e35ac7b7f7510ceb527
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118906
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [073e7b0ce56456187e87b8a13846ba853a4cf10b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3a55b50e0ca48b1904f625f7041d30830d2e9c65
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0a51b1c2b2503fb8c07a63a806bddd7345be1f7e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118905
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [9188dd9ad99baa5dcd6e9b1b3ec01c27ca1322df]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 17ccb362fcbd6a54600232b63b554c5f5ae7345b
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8298819cbb9ce2d7d973742592dc4299e4488dbf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118901
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [8d5622efa9a78d4d5798045f4c5131bd7753af51]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6df4a20a56da69912d321950d2d32db8e49897a
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie3a867a7bcda9edc66327ef2c5413a6faee8a7fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118904
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [6130f18980ef898923d0cf0c22834f5114d12bdd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fca292b94b832ad2de0609dd98ebdb45a53ca94e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I768845ed90efe57c11522759bae5a1da6fe99901
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118903
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [148508090f24c1e560b88e6ceb31c04cc1a2afc1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 95b36f942f0e9f7130dec40af7a471a392d7deb4
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie92420fa13971bd11451ecf1c10089c7713dca7e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118902
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [c31e741c562fa6607c9bd8c8b2ff4ba0ffa394b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4d648ad8464957732ea905672546d348ae279b13
          - tdf#132643 Translate German section IDs
            
            Change-Id: I8730d353f578caa2a9ecb392819f7e957030db16
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118899
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [3ab7ca478b65c019863929b2932474c092041f7e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f88bb249fc86e1d381b6e7551999ea084aadd142
          - tdf#132643 Translate German section IDs
            
            Change-Id: I595af96cd8c7847387a11d300fb85bd8a8313fba
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118900
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Johnny_M  <klasse@partyheld.de>  [2ee3c34aac9fc1ab0ad3ffe6ab11e4fd3684381b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d55f1498b49ddeedad84b5f79012fc80fb4e6c75
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idd1c44b507aa4a739d58659504fb6bacd3add879
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118898
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [81697ca63d47decf165420c4373b2b53d7eab385]

        new loplugin:weakobject
        
        find classes with more than one copy of OWeakObject in their inheritance
        hierarchy, which is dodgy
        
        Change-Id: I4e31bd6db03d25d934b736bd6a9c1b665f976ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118855
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [03cdb7392bc79476f1725df6160e196497057882]

        check-missing-unittests: only care about FIXED bugs
        
        Change-Id: Ifc13149acce6baa9e107e819b97ab879ff99d2d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118887
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-14  Julien Nabet  <serval2412@yahoo.fr>  [32b820b7ac299de66965857a86feed895f91c4d5]

        tdf#143342: fix crash when using "Search Command" feature
        
        Error: attempt to subscript container with out-of-bounds index -1, but
        container only holds 0 elements.
        
        Objects involved in the operation:
            sequence "this" @ 0x0x85b1d50 {
              type = std::__debug::vector<CurrentEntry, std::allocator<CurrentEntry> >;
            }
        
        4  0x00007fe75d569357 in CommandListBox::RowActivated(weld::TreeView&) (this=0x85b1d30) at sfx2/source/commandpopup/CommandPopup.cxx:202
        5  0x00007fe75d569649 in CommandListBox::TreeViewKeyPress(KeyEvent const&) (this=0x85b1d30, rKeyEvent=...) at sfx2/source/commandpopup/CommandPopup.cxx:222
        6  0x00007fe75d569170 in CommandListBox::LinkStubTreeViewKeyPress(void*, KeyEvent const&) (instance=0x85b1d30, data=...) at sfx2/source/commandpopup/CommandPopup.cxx:209
        
        Change-Id: I62923ce106da62e3d7d7572536f5e065773683ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118891
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [2575f9757126228ba43f382a419b92e71ee5b608]

        tdf#143320 Crash at paste/undo paste again
        
        revert
            commit 790135003b03b38a14efb7e0d345188607020a99
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Wed May 19 20:03:07 2021 +0200
            fix leak when removing PageDesc
        
        Change-Id: Ia6a03dec2db8f68c5c0c34d6ee9fb1889151f29d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118885
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Miklos Vajna  <vmiklos@collabora.com>  [19d473da14ac877cb0721063c7b18e16cb6f2b76]

        sfx2: handle OnMainThread=true in SfxOfficeDispatch::dispatch()
        
        This is needed when an out of process Java UNO client registers their
        command dispatch interceptor, Windows OleInitialize() has been called
        already on the main thread and then dispatching e.g. uno:Paste (which
        would interact with OLE) would call OLE functions on a thread, which
        would fail with RPC_E_CHANGED_MODE.
        
        In other words, a situation similar to commit
        22aa6508e0a65e65a6f9410b498fe4fd6c236639 (framework: allow dispatching a
        command on the main thread, 2019-01-29), but that one was for
        DispatchHelper, this one is for XDispatch implementations.
        
        Change-Id: If5a80fe36962e014e781d2a8c156055f127e69a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118886
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [686b2d70fe6361835a9c549ca13ecf0837b82296]

        use ImplInheritanceHelper in SwXTextFrame
        
        so we avoid having two copies of OWeakObject in it
        
        Change-Id: I1c3de4873a25e9cfb1a4bf67c369d9ecce0129d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118854
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Regina Henschel  <rb.henschel@t-online.de>  [af99c01570adc0c9205e1650d10866f80bb8118a]

        tdf#143219 improve docx import/export of contour wrap
        
        The current solution has some problems:
        (1)
        Currently effectExtent is used on import to increase the wrap margins
        for fat stroke and effects like shadow and glow in case of contour
        wrap.
        Problems:
        Word writes these values, but actually the wrap polygon is authorative
        and third party applications might not write these values at all.
        The wrap margins were increased on import, but not decreased on export.
        The effectExtent values by Word contain in addition the amount for
        rotation as needed in wrapSquare. That part was not removed.
        (2)
        To avoid negative values in dist* values they were compensated with
        effectExtent. For that, the complete effectExtent was shifted to dist*
        and effectExtent was set to zero.
        Problems:
        Contour wrap does not use effectExtent but a wrap polygon. This is set
        by Word in a way, that it includes the effect extents. LO uses the
        original wrap polygon if available. So moving the effectExtent values
        to dist* gives too large 'distance to text' in case of contour wrap,
        because effects were considered twice.
        
        The solution here replaces the way, how the margins are calculated in
        case of contour wrap. Now the range used by the wrap polygon is
        compared with the range used by the shape geometry. The difference is
        added to 'distance to text'. To be able to remove these values on
        export, they are put into the InteropGrabBag.
        
        LO and Word use different concepts for contour wrap. Any solution gives
        only an approximation. But adapting 'distance to text' brings
        rendering in LO nearer to the way Word renders contour wrap.
        
        Change-Id: Ic3c1c075fedfa7f79e4fe1f3c095da12cf274e36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118538
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [3f618170b8474b4a4e97aa7685daf064d0413a57]

        find-unneeded-includes: add --recursive option
        
        so that f-u-i will be able to find files to check on its own.
        
        Previously you had to find foo -name "*cxx" | xargs bin/f-u-i
        
        Now its a bit easier to mass-check files.
        
        Change-Id: I2823832ce8335a30493cf9f538f6fc5baec42dde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118875
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [98042f96c8d6806c9ce01c13b6b75cebfb8405de]

        Add Handler for ClipRegion Read
        
        The handler separates MetaClipRegionAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I14c7bb721defea8d18305e7cc24facf3d7e6e05c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118845
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [250ac047f5aef05738600457354d4998a0456a51]

        Add Handler for Wallpaper Read
        
        The handler separates MetaWallpaperAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I5878eb3c789dfa46ec6dbef358d26e69abc9e705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118837
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Miklos Vajna  <vmiklos@collabora.com>  [7707339a7d10225ff2503a852f68427519ae26f6]

        external: update pdfium to 4568
        
        Change-Id: I2bfd5f806281e747702d423b7e59b5f88a7bea9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118868
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Jean-Pierre Ledure  <jp@ledure.be>  [2366c24ffe564643ca616d848a477ba382e9fe50]

        ScriptForge - (SF_Base) new CloseFormDocument() method
        
        The closure of a form document is available from
        the SF_Form service.
        
        A form document is since recent commits associated with
        actions like PrintOut() that do not require to access
        its internal forms.
        
        As a consequence, the closure of a form document from
        the SF_Base service gains in relevance.
        
        Hence the actual commit.
        
        Change-Id: I9d4af078e6631d18c2d92c17249be6025ac9dfdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118857
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-14  Kevin Suo  <suokunlong@126.com>  [fe28633ee6edc5986220c934dfb04aa7b0d065ad]

        tdf81484 Draw and Writer pdf import: SimSun bold font is shown as "outline"
        
        Case 1: As discussed in the bug report, SimSun does not have a
         "bold" font. In PDF it uses fill+stroke rendering mode (i.e.,
         Text Render Mode is 2), see CoreTextStyle::CoreTextStyle, as a
         faux bold (fake bold) feature. For faux bold, the text render
         fill color is the same as the stroke color.
        
        Case 2: Also, it is noted that if you apply real "outline"
         characters in Writer and export to PDF, on Draw PDF import
         the text render mode is also 2, but the text render fill color
         is different than the stroke color.
         However, I would argue that for this case on PDF export Writer
         should set the render mode as 1, not 2, per PDF specs, which is
         another issue to be improved.
        
        The old code treated all these two cases as "outline".
        
        This patch:
        1) treats render mode 2 as faux bold if the stroke color is the
         same as the fill color; and
        2) still treat it as outline if the fill color and stroke color
         are different.
        
        This way, the real outline remains as outline characters while
         the faux bold (fake bold) becomes bold again on pdf import.
        
        This patch Also fixed some incorrect use of <style:text-properties>
         attributes per OpenDocument specification.
        
        This patch depends on change-ID I50a510ab9e5483f859ea2a767ea977ea3f065a2e
         which guesses the bold/italic if the font indentifaction had failed
         for whatever reason.
        
        Change-Id: Idabb22ea9b01ba53733c3acbd9de843790ebe8ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118156
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-14  Justin Luth  <justin_luth@sil.org>  [7c7dcdb5132b579485631e620c1a87cd9b3881e3]

        tdf#141964 writerfilter CN: only one style per outline level
        
        This really surprised me. On outline numbering, only one style
        can use the level of a numbering rule. Any other style that
        has it defined is ignored. First come first served.
        [All based on experimentation, no documentation found.]
        
        There are two ways the style can be attached.
        The highest priority is if the numbering style itself has
        a paragraph style defined (which obviously is exclusive).
        The second way is just to assign a list level along
        with a numbering rule in the para style.
        Surprisingly, this too creates an exclusive lock on the level.
        
        These are some existing unit tests that triggered.
        I forget which ones are important or valuable,
        but none of the contents were affected,
        only the UI use of the style didn't apply numbering in Word:
        
        Example1 -ooxmlexport6 fdo74605.docx RT
           pStyle not written out for numbering.
           List-number-2 gets ilvl0 before List-number-1,
           and loses pStyle for absLevel 1
           [NOT REALLY A PROBLEM.
            That is also how Word sees it. These aren't chapter numbering,
            so the pStyle settings just get dropped.]
        Example 2 - ooxmlexport7 fdo76979.docx RT:
           Bullet gets the numbering, but not Bullet2
        Example 3 - ooxmlexport11 tdf101122_noFillForCustomShape.odt RT:
           Heading 9 gets the numbering, but not Heading 10
           [Typical LO-originating document.]
        Example 4 - ooxmlexport13 tdf95848.docx RT:
           Heading 1, so not Heading 2
        Example 5 - ooxmlexport14 tdf136929_framesOfParagraph.odt RT:
           OOoNum123Start, so not the others (who inherit from start anyway)
        
        Change-Id: Ia27131ae6d31b6cff240477f3546ccf92ea69160
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118707
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Hossein  <hossein@libreoffice.org>  [59577dbb84fae18a3216d57ffec6008af157ce9b]

        Renamed bash-powered README file to generate.sh
        
        * Renamed README file to generate.sh. This file was
          both a README file and a bash script
        * Added simple instructions to run the script
        * A separate README file will be added later
        
        Change-Id: Ic2086c9af9c3497edd9cc557c1d9883b9ee0002b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118394
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [4d8262cab5537409a8cdf0b33b6d4703f7b27c9a]

        Add Handler for Hatch Read
        
        The handler separates MetaHatchActions::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: If231710b3ed776fd5ee8f63d706d8a8b3edaa5d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118836
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [d3a0c1b5d6e310d0e1ff8ffe28bb3028775813d0]

        Update Remove Formatting icons
        
        Change-Id: I80ef0c21cd37853a3758aad877a445ab10ac0045
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118881
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [9eed620ab1ea4ad67598b6026132d964e2e430bd]

        Add Handler for GradientEx Read
        
        The handler separates MetaGradientExAction::Read metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I01f0de7ab62cf658bc88cf2232622197b127cc9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118834
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [1583371d1d39c63940a3f58d3d2e940f903baa88]

        Add Handler for Gradient Read
        
        The handler separates MetaGradientAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ib8b6db1362c0ada3491e56d05409b810ac16be89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118833
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  panoskorovesis  <panoskorovesis@outlook.com>  [9256284b785b119baa2eddeab5e9c5d8e464da02]

        Add Handler for MaskScalePart Read
        
        The handler separates MetaMaskScaleAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I3642bc16d015e93a83e68e3e69cdab5da595efac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118830
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-14  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [6f926a4787f5e8f76e9efd3a564211eb65655ab2]

        tdf#58114 Remember last selected folder when saving image in Impress
        
        Change-Id: Ic095f461d794091716e7defcfd9850dd21493ba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118816
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [cfb25346ffe0ec8a65b4db2630ea615077fba277]

        Breeze: tdf#143300 add diagonal border line icons
        
        Change-Id: I8792557346406db4c66b2ad7d76fdb9303188f1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118880
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-07-14  Michael Weghorn  <m.weghorn@posteo.de>  [641c78de46d1e38eb8fe1b5f4d0cb8471934f240]

        qt5: Map AccessibleStateType::EXPANDED
        
        This addresses
        
            warn:vcl.qt5:75450:75450:vcl/qt5/Qt5AccessibleWidget.cxx:633: Unmapped state: 9
        
        seen when running LO with kf5 VCL plugin and the Orca screen
        reader enabled.
        
        Change-Id: I05e7b0cbbdce63300288ab4d74afc0933c93ec9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118847
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ee51f0ca4c1d9e8d6cecb5113508a284fe55c54c]

        Fix typos
        
        Change-Id: I809231e7e6ceaa93c2d0b523de8a4b93b07b449c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118841
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-07-14  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e0afcb6db8af493d6da9b809df14b5a07037d7e9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4a07aa673277b6769d16c968a3f868c11b6765c5
          - Fix typo
            
            Change-Id: I089cc8cbcab86673c3457e61c22ff09cde463eda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118840
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-07-14  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [08f7cdb51775dc0988d4bb9cd1d0b8f9487861aa]

        tdf#143300 add diagonal border for Writer table
        
        Change-Id: I3079243b6f420c570fd6d26cd593744bf64de3bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118821
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-07-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [213430e0bdac0786b30a76a68b43d35647e93912]

        tdf#123752, tdf#138432: sc_uicalc: Add unittest
        
        Change-Id: I9f40ab9198b52fdf3d402543d33c3043d6f45b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118789
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [91082e711db486069313260707954ea6da931634]

        Enable automatic code style formatting for EmfImportTest.cxx
        
        As EmfImportTest.cxx code style is follow the recommended
        code style (except too long lines), the code
        is used only for testing and it is rarely modified,
        I decided to enable automatic code formatting.
        
        It is one step closed to migrate to common code style.
        
        Change-Id: I1b7f980b9e68e121ba981b8a8222daa31424ac53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118864
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [2c4adcec93784d4fc42f6119d761bb23463b99e2]

        tdf#143245 activate-on-single-click only if 'up' is at active entry
        
        which is typically selected by the 'down'
        
        Change-Id: I23382fb97146820da49e570280778729a3156f03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [c6447960ce86e9c57eaff79ab44a5c442abe5448]

        Decrease line length of EmfImportTest.cxx by introducing const string
        
        Change-Id: Ie30d0246d6ca54821f00fe516ab67f803ef0d804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118863
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [3adfb2d35bb34157ce0d1344f2a28b40360728a5]

        EMF+ tdf#142941 Fixes SrcRect implementation in DrawImage record
        
        Change-Id: Ice82518d50c50fa6eff8bbcc111fcf287d34d77c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118363
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [f89de18f48724887eef6603b41a963fc222843da]

        no need to use WeakImplHelper in OTextConnectionSettingsDialog
        
        the base class already contains OWeakObject via
        ODatabaseAdministrationDialog
        
        Change-Id: Ib3de41a34cb83bf37574fac7a226a06c08d92e0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118851
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [3d49e8bfa6173cab17b8b46ad36cbfa567e0617a]

        Split the which id ranges merged in c4f615b359be56e88e4fbf9aaaf30affb29d57e2
        
        ... after specifying adjacent ranges became possible in commit
        d8bb5bb58ef62bc0e32d17f00f5fe695c81b5606. This allows to have
        the used ranges expressed explicitly, and makes it safe in case
        when new which ids potentially added between SDRATTR_SOFTEDGE_LAST
        and SDRATTR_TEXTCOLUMNS_FIRST.
        
        Change-Id: I94b75bc89e4cf2b490ffc55f692d4ebb593681a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118848
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [faf3da0a9676a82fd5dcb9e931480935cb985bc0]

        use ImplInheritanceHelper in SwXTextDocument
        
        so we avoid having two copies of OWeakObject in it
        
        Change-Id: Ia592f1d67a730da35c5d73c81c689d9da02fce1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [eb3fb2ea717f591e75b04ff828415cb9ad452dcd]

        use WeakComponentImplHelper for ScEditFieldObj
        
        so we avoid having two copies of OWeakObject in it
        
        Change-Id: I1dd789ced5552d8de4e164cd572c29022f662b74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118852
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Tünde Tóth  <toth.tunde@nisz.hu>  [0d3398e5d141b79706653c04f1ab6dc9381a5cc1]

        tdf#142929 XLSX: fix import of "Less than" filter condition
        
        "Less than" standard filter condition became <> instead of <.
        
        Change-Id: I53435590de3a03d9fcaf0359e8421ae3ef941316
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118227
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  Tünde Tóth  <toth.tunde@nisz.hu>  [d79de2a2975db6b34f47b7ccfe8d18692373d6f0]

        tdf#143068 XLSX: fix export of top10 filter condition
        
        Top10 filter condition lost after XLSX export.
        
        Change-Id: I5f9974e7d73f9ada84e284790c2928547f9ec7e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118291
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  Tünde Tóth  <toth.tunde@nisz.hu>  [1115d4d5ac63394ca0f3f1b75dc81916cdbeebe9]

        tdf#143101 sc UI: fix highlight of standard filter with logical OR
        
        The autofilter dropdown button didn't indicate that
        a standard filter in effect, when the criteria
        connected by a logical OR.
        
        Change-Id: I8f802ee3d0d03d654278693f0dcd06d7c3b67ba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118274
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  László Németh  <nemeth@numbertext.org>  [a483a44ca00f43a64ae51d62b8fbb4129a413f6d]

        tdf#143215 DOCX import: fix tracked empty row insertion/deletion
        
        Rejecting tracked empty row insertion, or accepting tracked
        empty row deletion didn't remove the line from the table.
        
        Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be
        "sw: fix crash due to redlines on tables on ooo121112-2.docx".
        
        Note: as a workaround for the empty rows, i.e. rows without
        text content, add a redline with invisible text ZWJ in the
        first cell of the empty row.
        
        Follow-up to commit 03b29d4ddb99337c4d54b241020c95e8b2a66991
        "tdf#143278 DOCX: support tracked table (row) insertion",
        commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion"
        and commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06
        "tdf#79069 DOCX: support tracked table (row) deletion".
        
        Change-Id: I8616a9d6f4a8d21e88c55d935f14a8c6a73c28ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118839
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  panoskorovesis  <panoskorovesis@outlook.com>  [c6a399ebfbb2275fa1f3b59d6d9c3a6349170944]

        Add Handler for MaskScale Read
        
        The handler separates MetaMaskScale::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I20aec9f6c767f82ba8bac0198e4e733511f33fab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118829
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-13  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [44df15bc7e5ea8e5bff2a4e45d9e8317ba0a362b]

        Related tdf#126665 Fix image select dialog
        
        Use proper default (work dir, not internal gallery folder)
        
        Change-Id: I3a7a3558274ea066219e2c9f362890d2ab12212e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118838
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-13  Miklos Vajna  <vmiklos@collabora.com>  [58aac6e941c0a84e568c14e2aa276c867f725dff]

        framework, sfx2: catch more exceptions when the object is already disposed
        
        This can happen when an out of process Java object is registered as a
        callback, then that Java process exits without notifying us.
        
        Handle this failure by just ignoring that object, so we don't crash on
        soffice process shutdown.
        
        Change-Id: I5d61e76494c62148ef0c3db24789a5ea6e5843eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118823
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-13  Michael Meeks  <michael.meeks@collabora.com>  [303c46e2394f6b744f0df5e8e55a8e1cd8e22a91]

        vcl: make get_id safe for disposed windows.
        
        crash from:
        	findChild(vcl::Window*, rtl::OUString const&, bool)      include/rtl/ustring.hxx:1744
        	WindowUIObject::get_visible_child(rtl::OUString const&)  /vcl/source/uitest/uiobject.cxx:463
        	lcl_sendDialogEvent ...
        
        Change-Id: Ic1756c7b03f2dee9780fb1a735917f1d0fc11876
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118691
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [b862ec6ac16f3e02be7845bb0db7a77250cb587d]

        merge UnoGraphicTransformer into UnoGraphic
        
        it is never instantiated by itself. And this also means it now only has
        one OWeakObject base class
        
        Change-Id: I3074130539ab023fec5537e0e7794e1c2db7e6ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118835
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Heiko Tietze  <tietze.heiko@gmail.com>  [14653f89a83982ef36346ebc15f14099fd5cf8f1]

        Resolves tdf#131233 - UX around "Missing hyphenation"
        
        SID_MISSINGHYPHENATION added and connected to a button
        on the infobar opening the wiki page via hub
        
        Change-Id: Id846e45637908abab478ba9b46e79af5d5aa33e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118230
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-13  panoskorovesis  <panoskorovesis@outlook.com>  [aa0e31fcbfbd0f143e744788ed97a335354c17f8]

        Add Handler for Mask Read
        
        The handler separates MetaMaskAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I00fb652271055d071e36f7a1bbe7a48b00f47085
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118698
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d62c0be4e61c2a8cccdb1a8bea8218327580b7ad]

        testVerticallyMergedCellBorder: increase twips tolerance to 30
        
        It was failing for me on Linux and another person on Windows, going
        1 twip over the tolerance. 30 twips translates to 2 pixels in 96 DPI.
        
        Change-Id: Ide9a29fdf3f2b4929408eb6d0d7a0792e927bb95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118778
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-13  Olivier Hallot  <olivier.hallot@libreoffice.org>  [195f7294bac6f559f6318fda3f897b8969c59966]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49699b9fb00cc35734d70390c4a2452ba90425b4
          - tdf#143319 Update Transformation Help page
            
            Change-Id: If97b222eee329168eff20fc571b729de41685ff0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118791
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [e9059584f0ead5c463a48aa68ebef334d3a02d2a]

        cid#1487472 Uninitialized scalar field
        
        Change-Id: I84333dc82904c50d887859e14490d5f38ceb2deb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118822
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  László Németh  <nemeth@numbertext.org>  [03b29d4ddb99337c4d54b241020c95e8b2a66991]

        tdf#143278 DOCX: support tracked table (row) insertion
        
        Rejection of tracked table insertion didn't remove
        the table from the text, leaving an empty table at the
        place of the insertion.
        
        Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be
        "sw: fix crash due to redlines on tables on ooo121112-2.docx".
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion"
        and commit 896c2199d9f0a28bd405dd2d1068f5e2973cdf06
        "tdf#79069 DOCX: support tracked table (row) deletion".
        
        Change-Id: I4c7242c432d1ad329a56a9a5423aa68fd7f94420
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118773
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  László Németh  <nemeth@numbertext.org>  [b50d386dfa70f7c1d4eb1a49091ec9dd782b767b]

        tdf#142701 track changes: fix layout regression of image deletion
        
        Commit d6322bcedc197a654abc7d64bfea8cf570f123bf
        (tdf#59463 track changes: record deletion of images) converted
        image anchors to AS_CHAR, which resulted loss of the original
        layout during rejecting the tracked image deletion.
        
        Now keep the original AT_CHAR (also AS_CHAR) anchorings, also convert
        the AT_PARA and other anchoring types to AT_CHAR using the following
        workaround: add an invisible text-based anchoring point with ZWJs.
        
        Follow-up to commit 8726cf692299ea262a7455adcf6ec25451c7869d
        (tdf#142700 DOCX: fix lost track changes of images).
        
        Change-Id: I29d1e161b5f24c0fed51d40c9a8db82085918d0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118747
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  Rafael Lima  <rafael.palma.lima@gmail.com>  [b966d6c8f4607b93f9c46a25c573e33fd203f9c3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3b9bcb7ae54aed523e1b0f4bce7f8f05ad64a20a
          - Improve NUMBERVALUE help page
            
            This patch improves the help page by adding some of the new contents available in the Wiki:
            https://wiki.documentfoundation.org/Documentation/Calc_Functions/NUMBERVALUE
            
            Change-Id: Icf21b924973d7e12a67e11c3c213765a3a06c0fc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118494
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [3aa1152ccee13869b2c1d64a296524cf4fb73fa8]

        a11y crash on teardown of FmXGridPeer
        
        the XAccessible is destroyed before the attempt to dispose via
        the IAccessibleBrowseBox*
        
        so call that first before the XAccessible is destroyed
        
        Change-Id: I908a3fbc05f92b5e56b8b6f2bc0b27757d39d1fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118825
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  Jun NOGATA  <nogajun@gmail.com>  [6d4a1716624a8a045ff4e90bd221b563be44be11]

        Add PowerPoint compatible screen size for Impress
        
          I realized that Impress does not have the same screen
          size as PowerPoint. tdf#142286, tdf#142288
        
          When I load a PowerPoint slide into Impress,
          it was a custom size, but when I add this screen size,
          it shows up with the screen size name.
        
          And when I load a slide with the added screen size
          into PowerPoint, it also shows up with the PowerPoint
          preset screen size name and not the custom size.
        
          The screen sizes I have added are as follows
        
          * Widescreen (Current PowerPoint default)
          * On-scren Show (4:3)
          * On-scren Show (16:9) (Google slide defualt)
          * On-scren Show (16:10)
        
        Change-Id: I33e2bbc36b2c92ecbb85c610c864f735bf540d03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116374
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Johnny_M  <klasse@partyheld.de>  [f62b88e7ccc46c77364a489c981a1024118aed7a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0abe9d6b70d4ffd02ddef31867607d67eecec41a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I24ea33b86e53b48904ec7d500f7583f58255f2dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118745
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-13  Mike Kaganski  <mike.kaganski@collabora.com>  [60ea95afb2e2ed299711d8244a2ffb1c960c7eb2]

        Avoid default argument value, and be explicit
        
        Helps seeing which element used where
        
        Change-Id: Ieb5f1ea4ca983211d995268210dc2d9b14061721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118796
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-13  Heiko Tietze  <tietze.heiko@gmail.com>  [d3228d493cd6d36972659d8700aeffc15f007dd6]

        Resolves tdf#143272 - Window text color for border lines
        
        Change-Id: If57e391328f0f49161b3ffae83a0077bc34ac10f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118820
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [960ce1ebafda0eaff0633f10c0fea7b3af703f9a]

        cid#1487034 Untrusted value as argument
        
        Change-Id: I5611098c9bd952ca2f3df7951d02de26cfec149e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118824
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  shubham656  <shubham656jain@gmail.com>  [44a783185e09dc7da374a556fad44bddf1c8a1ce]

        tdf#95554 Add UITest
        
        Change-Id: I38a9768fc94f26a593f51ce566da4111f5f3b78b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117961
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-13  shubham656  <shubham656jain@gmail.com>  [a72b6d2df5978c0f43e04432581f4bc62c2c6d8f]

        tdf#78150 Add UnitTest
        
        Change-Id: I2ec92c229fcb6d38fd78c520a48d0bd3b739a82e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118542
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-13  Regina Henschel  <rb.henschel@t-online.de>  [b33634a5c07c8f7032967d8e939100a50e0152ae]

        tdf#141786 correct position of child elements in group
        
        ...in export to docx.
        
        Rotated child elements need a correction to the position values,
        because LO uses left/top of snap rectangle as position, but Word uses
        left/top of unrotated shape. For the group itself it is done in
        DocxSdrExport::startDMLAnchorInline. But child elements' position
        is exported in DrawingML::WriteShapeTransformation. And there this
        correction was missing.
        
        Position is relative to anchor in Writer and relative to group in
        Word. The adaption is contained in WriteShapeTransformation. But
        PolyPolygon and Connector have no explicit rotation and therefore they
        do not use DrawingML::WriteShapeTransformation but call directly
        DrawingML::WriteTransformation. So they missed this adaption. I have
        added the adapation directly to these shapes.
        
        Unittest testDmlTextshapeB in sw-ooxmlexport6: I have adapted the
        values. The position of the connectors relative to the group is better
        now. You see this, if you compare it with a screenshot of the original
        file in Word. The handles of the connectors are still wrong and the
        whole group is still shifted.
        
        The patch does not fix the wrong position of rotated legacy ovals,
        because that error exists independent of groups.
        
        Change-Id: Iaf843dcf04bac596427dd35ccfa6cd20e3a4cdc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118748
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-13  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [f9982c24066d6dd2f938cc20176af0f196bc018f]

        tdf#58521 DOCX import: enable ContinuousEndnotes compat flag
        
        like Writer for DOC import and MSO do to avoid to start
        endnotes on a new page.
        
        Change-Id: I37d54f189e7aa1f4d0ac829b6af0c03aec64b9f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118541
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-13  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [d65f6ba081817772ccce79d31fcdea38da2037ec]

        Make logerrit more portable
        
        Change-Id: I4b63de105abc292dcbb461a9a6dd846523e51eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118779
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-13  Jean-Pierre Ledure  <jp@ledure.be>  [0abc993f1b6f001f6c4d643608e03c7a5a26ee46]

        ScriptForge - (SF_L10N) FIX return value of AddText()
        
        Return value should be True when successful.
        Was erroneously False.
        
        Minor bug. No correction in 7.1 and 7.2
        
        Change-Id: I71040f2ba8fec80297428b0ca317e9d67c79a25e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118815
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [2012d5b90b64cb3a28862267dafb162c2f85d832]

        tdf#143257 like graphics defer creating transfer data for drawings until needed
        
        don't create when a drawing is selected, wait until its actually dropped
        into something (I experimented with dropping into gimp)
        
        Change-Id: I3edaf79537d5723565adf8c45d6f7408026a93e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118770
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  Caolán McNamara  <caolanm@redhat.com>  [d1b034f9c480ada0bf7d5d2cfc18d1ef12409bae]

        move freeze/thaw so we don't select while frozen
        
        Change-Id: I4f4b3e5ac3e7e842726780f9c773389f7c39ce7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118787
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-13  Todor Balabanov  <todor.balabanov@gmail.com>  [a71caa79c8eb09ff0374cdaf4b081ba42d1330a1]

        Object initialization is done via a constructor with parameters.
        
        Change-Id: I66e87f7c898efb1f2c6b1d31fbd5654244e3ea82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118785
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-13  Jean-Pierre Ledure  <jp@ledure.be>  [a35b49c58519925f5b093edbc3b59180dc8a03eb]

        ScriptForge - (SFDocuments) new PrintOut() method
        
        The PrintOut() method launches the printing of a
        LO document to a printer previously defined by default,
        by the user or by the SetPrinter() method.
        
        It is applicable on any document, on a Calc sheet, a Base form
        document. For a Writer document specific arguments may
        be provided.
        
        Implemented both for Basic and Python user scripts.
        
        Change-Id: I51ce897b66d3e5624cec97a46e5eb28d9132357a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118786
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-13  Hossein  <hossein@libreoffice.org>  [02a56168ae20b575eae532d81612eeff558a7fe1]

        Ported Draw example from Java to C++ and done some tweaks
        
        * Created Draw.cxx
        * Used Makefile from DocumentLoader with some changes
        * Updated examples.html to reflect the addition
        * Updated odk make files
        
        Change-Id: I37426d63854222ef8bedb5f61edb420baec4d28a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118034
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-13  Miklos Vajna  <vmiklos@collabora.com>  [d766373f3b17d2749176f77958df793cd07ceced]

        sw RTF export: use std::make_unique
        
        Change-Id: I7cd54cbbea55b7a7fd64597c48407629f10cddd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118790
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-12  Eike Rathke  <erack@redhat.com>  [4e0a7df2dfa10bc52d5dbda34f43e0bc0df22ae7]

        Resolves: tdf#123466 Add Microsoft ill-used {x-none} to known language tags
        
        'x-none' is a private-use tag and letting it escape into the wild
        isn't such a private use..
        
        This just prevents the lt_string_value assertion that doesn't harm
        anyway but seems to confuse people and makes the tag known to
        LibreOffice with a reproducible assigned LCID instead of an
        on-the-fly generated one.
        
        Whatever it may take to actually support something tagged with
        'x-none'.
        
        Change-Id: I3f32c9ba18a2528584a112157509c1dfda75e29c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118788
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [7e016df70d4ceb6c90ec5f1b129b50a65ff07505]

        crashtesting: UaF on layout of ooo98566-1.odt
        
        in:
        sw/source/core/text/itrform2.cxx:2643 SwTextFormatter::NewFlyCntPortion
        at: pFly = static_cast<SwTextFlyCnt*>(pHint)->GetFlyFrame(pFrame)
        
        (gdb) print m_pCurr
        $2 = (SwLineLayout *) 0x55ea220a0020
        
        after calling GetFlyFrame m_pCurr is unchanged and we will call
        m_pCurr->MaxAscentDescent
        on it.
        
        But m_pCurr is deleted during GetFlyFrame by...
        
         #18 0x00007f98c5cd337f in SwLineLayout::~SwLineLayout() (this=this@entry=0x55ea220a0020, __in_chrg=<optimized out>)
             at source/libo-core/sw/source/core/text/portxt.hxx:26
         #19 0x00007f98c5cd347a in SwParaPortion::~SwParaPortion() (this=0x55ea220a0020, __in_chrg=<optimized out>)
             at source/libo-core/sw/source/core/text/porlay.cxx:2491
         #20 0x00007f98c5cd3485 in SwParaPortion::~SwParaPortion() (this=0x55ea220a0020, __in_chrg=<optimized out>)
             at source/libo-core/sw/source/core/text/porlay.cxx:2491
         #21 0x00007f98c5d05e70 in std::default_delete<SwParaPortion>::operator()(SwParaPortion*) const (__ptr=<optimized out>, this=<optimized out>)
             at /usr/include/c++/8/bits/unique_ptr.h:75
         #22 0x00007f98c5d05e70 in std::unique_ptr<SwParaPortion, std::default_delete<SwParaPortion> >::reset(SwParaPortion*)
             (__p=<optimized out>, this=<optimized out>) at /usr/include/c++/8/bits/unique_ptr.h:382
         #23 0x00007f98c5d05e70 in SwTextLine::SetPara(SwParaPortion*, bool) (bDelete=true, pNew=0x0, this=<optimized out>)
             at source/libo-core/sw/source/core/text/txtcache.hxx:45
         #24 0x00007f98c5d05e70 in SwTextFrame::ClearPara() (this=this@entry=0x55ea21302b60) at source/libo-core/sw/source/core/text/txtcache.cxx:113
         #25 0x00007f98c5d1be89 in SwTextFrame::Init() (this=this@entry=0x55ea21302b60) at source/libo-core/sw/source/core/text/txtfrm.cxx:757
         #26 0x00007f98c5d2630c in SwTextFrame::Prepare(PrepareHint, void const*, bool)
             (this=0x55ea21302b60, ePrep=PrepareHint::FlyFrameArrive, pVoid=<optimized out>, bNotify=<optimized out>)
             at source/libo-core/sw/source/core/text/txtfrm.cxx:3086
         #27 0x00007f98c5b1edb8 in SwFlyInContentFrame::NotifyBackground(SwPageFrame*, SwRect const&, PrepareHint)
             (this=<optimized out>, rRect=..., eHint=<optimized out>) at source/libo-core/sw/inc/anchoredobject.hxx:205
         #28 0x00007f98c5b261a6 in Notify(SwFlyFrame*, SwPageFrame*, SwRect const&, SwRect const*)
             (pFly=pFly@entry=0x55ea21a18d60, pOld=0x0, rOld=SwRect = {...}, pOldPrt=pOldPrt@entry=0x7ffeb50390f8)
             at source/libo-core/sw/source/core/inc/frame.hxx:1177
         #29 0x00007f98c5b2ceca in SwFlyNotify::~SwFlyNotify() (this=0x7ffeb50390d0, __in_chrg=<optimized out>)
             at source/libo-core/sw/source/core/layout/frmtool.cxx:648
         #30 0x00007f98c5b1fa25 in SwFlyInContentFrame::MakeAll(OutputDevice*) (this=0x55ea21a18d60)
             at source/libo-core/sw/source/core/inc/frmtool.hxx:419
         #31 0x00007f98c5aec3a9 in SwFrame::PrepareMake(OutputDevice*) (this=0x55ea21a18d60, pRenderContext=0x55ea212bc4c0)
             at source/libo-core/sw/source/core/layout/calcmove.cxx:375
         #32 0x00007f98c5b17ad2 in SwFlyFrame::Calc(OutputDevice*) const (this=<optimized out>, pRenderContext=<optimized out>)
             at source/libo-core/sw/source/core/layout/fly.cxx:2890
         #33 0x00007f98c5b636c5 in SwObjectFormatter::FormatLayout_(SwLayoutFrame&) (this=this@entry=0x55ea2244d150, _rLayoutFrame=...)
             at source/libo-core/include/rtl/ref.hxx:206
         #34 0x00007f98c5b6413e in SwObjectFormatter::FormatObj_(SwAnchoredObject&) (this=this@entry=0x55ea2244d150, _rAnchoredObj=...)
             at source/libo-core/sw/source/core/layout/objectformatter.cxx:296
         #35 0x00007f98c5b6705b in SwObjectFormatterTextFrame::DoFormatObj(SwAnchoredObject&, bool)
             (this=0x55ea2244d150, _rAnchoredObj=..., _bCheckForMovedFwd=<optimized out>)
             at source/libo-core/sw/source/core/layout/objectformattertxtfrm.cxx:136
         #36 0x00007f98c5b6359f in SwObjectFormatter::FormatObj(SwAnchoredObject&, SwFrame*, SwPageFrame const*)
             (_rAnchoredObj=..., _pAnchorFrame=<optimized out>, _pPageFrame=<optimized out>)
             at source/libo-core/sw/source/core/layout/objectformatter.cxx:190
         #37 0x00007f98c5d717aa in SwTextFlyCnt::GetFlyFrame_(SwFrame const*) (this=this@entry=0x55ea214d8810, pCurrFrame=pCurrFrame@entry=0x55ea21302b60)
             at source/libo-core/sw/source/core/inc/frame.hxx:1177
         #38 0x00007f98c5cb511b in SwTextFlyCnt::GetFlyFrame(SwFrame const*) (pCurrFrame=0x55ea21302b60, this=0x55ea214d8810)
             at source/libo-core/sw/inc/txtflcnt.hxx:48
         #39 0x00007f98c5cb511b in SwTextFormatter::NewFlyCntPortion(SwTextFormatInfo&, SwTextAttr*) const
             (this=this@entry=0x7ffeb503a6b0, rInf=..., pHint=0x55ea214d8810) at source/libo-core/sw/source/core/text/itrform2.cxx:2643
        
        (gdb) print this
        (SwLinePortion * const) 0x55ea220a0020
        
        The SwTextFrame of SwTextFrame::ClearPara is the same pFrame/m_pFrame at SwTextFormatter::NewFlyCntPortion
        
        ClearPara is not called if the SwTextFrame is "Locked", so try using that to protect GetFlyFrame
        
        Change-Id: Ia9dcb1f345f6953d995f2acf1ec23492d1680364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118784
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [57980fa601a868e50d6afd0ca5b5c2f15eeb9539]

        tdf#143291 the "none" item selected is distinct from nothing selected
        
        Change-Id: I2e012df85a5c28f462a6c643d7a9a88f8775e870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118776
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [6db32d598532fb0c43825fe61119d4d00f2ceb41]

        loplugin:unusedmethods
        
        Change-Id: I1e17e43bfe4a18034e9c0ff483097fe6ca0e777a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7e5c9220ef5d51ac23e618c5c9eeda9cf4339c88]

        tdf#142487 - use utl::TextSearch in order to implement the replace algorithm
        
        In the old algorithm, some special unicode characters lead to a
        malfunction of basic's replace function. For instance, replacing a
        German ß to uppercase in the insensitive case will lead to SS, breaking
        the replace positions.
        
        Change-Id: I4e6f6e5fba3d560b8cfd0786fa2439ed5174a928
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118760
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-12  Kevin Suo  <suokunlong@126.com>  [cffd97193f7468f770368559d5a5c58bd0bb2327]

        tdf#78427 sdext.pdfimport: refactor the conversion of font family names
        
        Simplify the code and hopefully improves performance.
        
        The previous code used a long for loop within which it used many duplicated parseFontRemoveSuffix. That for loop was simply intended to remove the font family name suffixes. However, the rResult.familyName is a OUString and this type already has the function of removing suffixes which is more efficient.
        Also, defined a list of suffixes to be removed in the header file. New suffixes can be easily added to this list.
        
        Change-Id: Idfa11cfe60e2e34a1f7456d29562a89eb3de7662
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118734
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Miklos Vajna  <vmiklos@collabora.com>  [a023a967978a334fd5016ab325864796def295cc]

        sfx2: fix assert failure when deleting SfxOfficeDispatch on a thread
        
        Steps to reproduce the problem:
        
        1) Start soffice with "--accept=socket,host=localhost,port=9999;urp;StarOffice.ServiceManager"
        
        2) Run a java / uno example that registers a custom dispatch interceptor
        by calling registerDispatchProviderInterceptor().
        
        3) Open a Writer document, choose insert -> object -> ole object ->
        spreadsheet (i.e. Calc)
        
        Then this assertion failure is hit:
        
        tllo.dll!DbgTestSolarMutex() Line 96
                at C:\lo\master\tools\source\debug\debug.cxx(96)
        svllo.dll!SfxBroadcaster::RemoveListener(SfxListener & rListener) Line 104
                at C:\lo\master\svl\source\notify\SfxBroadcaster.cxx(104)
        svllo.dll!SfxListener::~SfxListener() Line 54
                at C:\lo\master\svl\source\notify\lstner.cxx(54)
        sfxlo.dll!SfxDispatchController_Impl::~SfxDispatchController_Impl() Line 367
                at C:\lo\master\sfx2\source\control\unoctitm.cxx(367)
        sfxlo.dll!SfxOfficeDispatch::~SfxOfficeDispatch() Line 192
                at C:\lo\master\sfx2\source\control\unoctitm.cxx(192)
        
        Given that SfxListener wants its caller to lock the solar mutex and
        SfxDispatchController_Impl inherits from SfxListener, lock the mutex in
        the SfxOfficeDispatch dtor and explicitly delete
        SfxDispatchController_Impl while the mutex is still locked.
        
        Change-Id: Ib4201ef7866aaadedf9dfa8bd581ebe7a3bcf29a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118769
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fda7285144fcadd16cc02bf7ecaad20b7d5b971]

        loplugin:unusedfields
        
        Change-Id: I487ff0211fc1b894950bedc72cd8444c7da36ace
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [6d235b1a87c281389daad6e4c653e75810e749a8]

        try to restore SwpHints::MergePortions (2nd attempt)
        
        seems
          commit 4a93efcf6e7982146fb71e4d32760a07a0f984c2
          Author: Noel Grandin <noelgrandin@gmail.com>
          Date:   Thu Jul 8 15:16:29 2021 +0200
          try to restore SwpHints::MergePortions...
        was not good enough
        
        Change-Id: Ic5b9d9d7081ab3bc814388332672ff950fb84802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118772
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-07-12  Miklos Vajna  <vmiklos@collabora.com>  [10e36bac8dcf25372467ef97a28ad859922e6a3c]

        sw: prefix members of SwXMLAutoStylePoolP, SwXMLConditionContext_Impl, ...
        
        ... SwXMLItemSetContext and XTextRangeOrNodeIndexPosition
        
        See tdf#94879 for motivation.
        
        Change-Id: Ied25f44dd03fa7760613d89e11003028ce60982a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118764
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [48abc66ac473938d16670119e5fb0bb82f5ff8ce]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e30dc2a0cd25a3c81bfbbcd61283c67ea66e0c32
          - tdf#128590 Create Auto-Redact help page
            
            Change-Id: I16fc3db85e3d62edd8241136ff53558ba46c44a7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118727
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [f09d23f80f8f492a5cf27d3fef5b007357a585fa]

        Revert "flatten ValueSet item array"
        
        I'm seeing a11y crashes in the impress slide transition ValueSet. The
        mxAcc member contains a ValueItemAcc which has a pointer back to the
        ValueSetItem so if its std::moved into another ValueSetItem then it
        continues to point to the older ValueSetItem and not the new one
        
        This reverts commit 30aa33e6a6b9fb230af96f619db27fcaf31ef914.
        
        Change-Id: I1fd81aa81e47f2e984dd47fdc8a905e25c9f6266
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118775
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [efda4f52ea59e2d235a55be863fbffa8ca7a7874]

        tdf#92503: sc: Add UItest
        
        Change-Id: I777b78151d29624cd7f12b3b533b8044bb765a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118774
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [9a8317e609675923af785f908f63e52f4527d7f7]

        Fix extended tip after translation
        
        Change-Id: I6a999a2c20f0a90be1cde21cd27ec73f75dc4f28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118448
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [1a9ca0179e51e96e495c88f262a111a2a5f4c740]

        move the existing std::unique_ptr<tools::Long[]> rather than duplicating it
        
        Change-Id: I8686fc15254f922b1963eb86151c6aa770c2d578
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118758
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [dc56e8c2380e07deb9678d87f7eb64f18c79d0ec]

        enable -Wshadow on clang
        
        which is on for gcc, but doesn't seem to be on for clang
        
        Change-Id: If71e03511e093280db55426fd4c1d076f760b5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118768
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Johnny_M  <klasse@partyheld.de>  [aa5ae14882a0d41a60ed6b056f3a943e22cf349e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f7c998f88c2a4666f5d2a440f1449d763e05b85e
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1e6d98c57fc33dca6ff2a13baf5f6cfd53977a69
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118746
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [d157c1bd70d630a58db33910d550bb8dee9fe62e]

        tdf#126665 Remember last used file picker directory
        
        This introduces internal tracking of last used directories.
        Each caller of the file picker can pass a "context". The selected
        directory will then be saved & restored when opening the file picker
        with the same context again.
        
        After ffa636ba74b04b3258ec9a696bc4eac33581fa24 , the Windows file picker
        no longer tracks the last used directory itself.
        This is a replacement and an improvement at the same time, since there is not
        one global last used directory, but one per context.
        
        Change-Id: I10650cfb9359922690954fa65c89b4e47477e2c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118597
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-12  Johnny_M  <klasse@partyheld.de>  [c62bb20032cef7479e9293e84a8d57a2c74399d0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1831cc5a3cc0f97d2d49dfef738f7164d84e98f8
          - tdf#132643 Translate German section IDs
            
            Remove unused.
            
            Change-Id: Ia436f58a7d6edd6d8df86dd6a1cbbcd0896a501b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118744
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [6f5daa7709e15b67615ff7335d9530f085ceffad]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1a380691b716f56c1d925eb27807bb5ef8264ac0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I78b6e56e1bb70b10bed03201704d1246cf00c0a3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118743
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [f23924609b8f0c0795a2f3f4340acdf9997d20ae]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 34354f2bf896f0c7fe089d73d88380718a8318b6
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib93523c39a74ff88a6154f3111113260e59cbb55
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118742
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [49cf72facf979b04370dfd4c18fd98a34d058fcc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eabf8b0ec21993c4d622d5b7f0b929e6975c101a
          - tdf#132643 Translate German section IDs
            
            Change-Id: I69b146fa405b531e8df8b1b5b443414c13f60bcb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118741
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [f539339afdc933a3ecdabd4d3c644c5e6c685d02]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 39f2707a7720975aa6630225b17262df9a3bbcbf
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia9fd713b2239b42bae5b2248726e4ef985988309
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118740
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [a6ba9020b2bcb4d0434702f5d50f26c73c03dc01]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e4d57d47fe20e41bcf168eddaf17fde7779c2935
          - tdf#132643 Translate German section IDs
            
            Change-Id: I62a2f589f2db16547911451ac28e23d27d1c9d76
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118739
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [d134c9038e1c66378545e6cccc6030abf8c7740d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5243fe74433fd16d57d358d14c20620f690d6bb7
          - tdf#132643 Translate German section IDs
            
            Change-Id: If12cb62f686383c3e3e93c931a5a7e8556f885b4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118738
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Johnny_M  <klasse@partyheld.de>  [fae9d311075471f7c70bf578c55bf747fe57fd04]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 37dd18edf225d97136049e4d3870c0902fbaca4c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I08e4c29872fa1239109bbacc345addb32f5b07dc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118737
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Rafael Lima  <rafael.palma.lima@gmail.com>  [d3a47a78ba020eb450ca9a8d317ffcdbe98e10d6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 19c8e31a7159740f3a2048e459b0237786d0a995
          - tdf#143211 Improve macro example in Validity check
            
            Change-Id: Ic6a3db771731d21879897b2b6a45c5ce003e524e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118715
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Uwe Auer  <uwe@franke-auer.de>  [2934b4b4bcb5c155f8b41acb935f9463796933ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0c56a2a24ba95bb5a8d39b8e647f5b9a52dd5648
          - tdf#143309: Incorrect help information about toolbar "Mode" in Draw
            
            Change-Id: Ib7a5dd6a5c948abec74dd49f6358b6558561c38d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118726
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [6eedac6b19f3dcad46f2ca2b9ccb02b490b60ce9]

        uitest: sc: move textToColumns tests to their own folder
        
        Change-Id: I20742a89544859f397c8ae45db0c91f4abe1e940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118687
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-12  Hossein  <hossein@libreoffice.org>  [04c7c90fe886c5fcebd52f727ff8b4edb840ad32]

        tdf#143305 Remove remaining SID collision in .hrc files
        
        There were some SID collisions in these files that should have been
        avoided:
        
        * include/sfx2/sfxsids.hrc
        * include/svx/svxids.hrc
        * include/editeng/editids.hrc
        
        This patch resolves this problem, filed as tdf#143305
        
        Looking at b66d87086804460c1986df1b832fd6b2ea075a90 (2014-04-01) we read
        
         As commit 669ad519902e21e0cb3537fb7e203987f75a4077 (colliding
         SID_SVX_START based ids, 2013-06-24) suggests, new SID_SVX_START-based
         SID's shouldn't be added to include/editeng/editids.hrc. However, if it
         was done, at least add a comment about it to include/svx/svxids.hrc, so
         it becomes obvious that the two slots have the same ID.
        
        Also in include/sfx2/sfxsids.hrc:551
        
         slot IDs from SVX (svxids.hrc) ------------------------------------
         These SID_SVX_START entries came from include/svx/svxids.hrc, avoid
         accidentally colliding entries with include/svx/svxids.hrc and
         include/editeng/editids.hrc. Only add new SID_SVX_START entries
         to include/svx/svxids.hrc
        
        To make sure no collision is remaining, grep is used:
        
          git grep -h "SID_SVX_START[ ]*+" *.hrc | grep -Ev '^\s*\/\/' \
            |awk -F\( {'print $2'} | awk -F\) {'print $1'}             \
            |awk '{gsub(/^ +| +$/,"")}1'|sort|uniq -c|grep "      2"
        
        It searches for 'SID_SVX_START +' in .hrc files, removes comments out of
        it, extracts the parts between paranthesis, trims spaces, sorts and
        then finds the number of unique occurances and looks for 2.
        
        Change-Id: Ife9b12c72ed5141a3404a291489dc1c11f4e967d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118544
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [8de07ff2aced7ee74466ff61379e8d593bf8dc2a]

        cid#1487034 explicitly pass len of aArray
        
        Change-Id: Ia632df2967d3aa75ba0bcedcc899851dc80bab69
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118757
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Jun NOGATA  <nogajun@gmail.com>  [42e8317446bfbf545252b2143a2433bb1f620410]

        add Japanese font fallback.
        
        Change-Id: Ic15413a13a4d6989362c1a96b11cba4c7406b80c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116724
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Jun NOGATA  <nogajun@gmail.com>  [c2fb518a6889fa9beac2d7e512ce3dcbf06c6d85]

        update Japanese font order list
        
          * Fix tdf#137393 changed Noto CJK font order (Noto Sans/Serif CJK JP has priority)
          * Add Adobe Genno Kaku Gothic(Source han sans JP) and Genno minecho(Source han serif JP).
          * Add macOS version Yu Gothic and Yu Mincho fonts.
          * Add IPAex Gothic, IPAex Mincho and IPAmj Mincho.
        
          Japanese fonts are compiled in a TDF wiki.
          * https://wiki.documentfoundation.org/JA/Fonts
        
        Change-Id: I6dec9b5deba19d3272e53a4c73031acd231635f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116712
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Kevin Suo  <suokunlong@126.com>  [da59686672fd2bc98f8cb28d5f04dc978b50ac13]

        tdf#78427 sdext.pdfimport: No need to read a font file for the purpose of...
        
        ...determining the bold/italic/underline etc.
        
        The purpose for reading a font file is that in case the font attributes determined by the xpdfimport process is not enough, then we use the lo core font classes which read in the font file and then determine whether it is bold, italic etc.
        However, while this works in some cases, it does not work in many cases when the font file was actually a subset and a toUnicode map is followed in the PDF, see tdf#78427.
        In addition, in case the information collected from the xpdfimport process is enough, there is no need to read the font file.
        
        This commit removes the read of font file part. Also, this commit uses gfxFont->getNameWithoutSubsetTag() to get the font name with the subset tags removed, thus simplified the code in wrapper.cxx while also improves performace as the remove of subset tags is only run when the font is a subset (the previous code did this for all the font names).
        
        Change-Id: I94c1ad8e743abfab81cf0a46da178d4d8b212427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118733
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2021-07-12  Kevin Suo  <suokunlong@126.com>  [508ccbdb14ecdebf1aee2110e91f83768ab387f0]

        Add "--progress" agument to the ./g command
        
        Newer version of git has a --progress option to show the progress when running "git submodule update". This is useful in our ./g command expecially when we are building the code with l10n languages enabled and the network connection is slow. Without this I do not see where I am for the update process and may think it have died.
        
        Change-Id: I4c9e1e9bccbd8e6ca2ea2b44f5b6d6d90cad1506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117922
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [61618141f0204ce6653354f6424e11276d939aed]

        cid#1487032 NP: Null pointer dereference
        
        and
        
        cid#1487033 UwF: Unwritten field
        
        since...
        
        commit 822f128e734f37ee4de9bf5b62640cbec140701e
        Date:   Wed Jul 7 16:01:19 2021 +0300
        
            Polymorphism is a better approach when there are chains of inheritance.
        
        where deGTBehavior and psGTBehavior are no longer stored when set from
        DEPSSolverImpl.java:146 and DEPSSolverImpl.java:147
        
        Change-Id: If3d228bf6e5f2b1ddd119d75b55bd778bcce8b05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118759
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Caolán McNamara  <caolanm@redhat.com>  [de311257e851f1fdbc87a4df836a526220c668d0]

        a new MetaTextArrayAction already has a null DXArray
        
        Change-Id: I046263745bd5d4cc78eb3c954e42fa32ce057159
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-12  Hossein  <hossein@libreoffice.org>  [fc476804ce32722b63a27f2f7120b1f28d905fe6]

        tdf#117761 Adding extra checks for SmartArt import (Snake Algorithm)
        
        * Improved tests for tdf#117761 (Snake Algorithm)
        * Added extra checks for proper arrangement of shapes in:
          * SdImportTestSmartArt::testBase()
            * File (LTR): sd/qa/unit/data/pptx/smartart1.pptx
          * SdImportTestSmartArt::testBaseRtoL()
            * File (RTL): sd/qa/unit/data/pptx/smartart-rightoleftblockdiagram.pptx
        * To run test:
          make CPPUNIT_TEST_NAME="testBaseRtoL" -sr CppunitTest_sd_import_tests_smartart
        
        Change-Id: I72510d1d22bbaf1e9aa036d85354a71bdba4c685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118325
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-12  Hossein  <hossein@libreoffice.org>  [0fc020fb73c86a20608e8dff12af607e60327379]

        Cleaning up DocumentLoader C++ SDK example
        
        * Removing calls to C functions
        * Simplifying string usage
        
        Change-Id: Ia8ca329d7ad586d98e309809e430006eaac9eaaa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118131
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [f3cd3927eef4fd79a988cfe61494bc225488b8b6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to aa766c09c62dc1b096d98a8801cd7ce42f6de7c4
          - A typo: this tells about first *optional* parameter, not return
            
            Change-Id: Icda20a199e439af1f3b708fad80bb31a4b560716
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118718
            Tested-by: Jenkins
            Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
            
2021-07-11  Caolán McNamara  <caolanm@redhat.com>  [75e246ee9bafddbb5e48b1781b54c9e5026b9c7e]

        std::unique_ptr::reset on an empty std::unique_ptr doesn't do anything
        
        Change-Id: I3953a0e0c01a9a1a53ab37dc6aee991a635cd0f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118754
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-11  Caolán McNamara  <caolanm@redhat.com>  [4dc89ebacb655e22f2ac417c8260d4df3e845fd1]

        cid#1487030 Explicit null dereferenced
        
        if alternatively we shouldn't check for null then presumably
        ShapeContext ctor should either
        
        Change-Id: Ic61cdc21de0c878a0f3cb45cbb60743dcb400368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118753
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [83a235450e6bf3c671ab9a1710e92a356d4d2052]

        ofz#36037 Revert "pProperties in StyleSheetEntry is never nullptr"
        
        This reverts commit a7eb2f57d8e586577679ecd085b9aa90746ec36b.
        
        Reason for revert: tut tut, appears I was wrong
        
        Change-Id: Ie21db35d7809c2bc3d71c8231bf13bbdc0415b5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118716
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-11  Caolán McNamara  <caolanm@redhat.com>  [2e7c8846f806a5f26fc4fc5a60894bfa50ddde06]

        cid#1487035 Uninitialized scalar field
        
        Change-Id: I925b6efdb8d75e5960152f3758ce185aab67d206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118704
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [797b921afa056d5631ed772a110c5a3e53741bfc]

        Fix a comment copy-paste error
        
        Change-Id: I41899d0f9c04070441f8011cb667c6a8d84bf355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118717
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7eb2f57d8e586577679ecd085b9aa90746ec36b]

        pProperties in StyleSheetEntry is never nullptr
        
        so we can elide some null checks
        
        Change-Id: I6fb07daf96b76dfa9223dad64bc9690585c00b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118736
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [6b0029887edc57b51e2abd8b5c8f373f5d11418d]

        pProperties in StyleSheetEntry is always StyleSheetPropertyMap
        
        so we can avoid some dynamic casting, suggested by jluth
        
        Change-Id: I9895d16c6228e01f802b369f4bdcf1ccc9bf6bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118735
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-11  Mike Kaganski  <mike.kaganski@collabora.com>  [e09f22aa2626267e01b9e759c152f3a0d70ddc68]

        editengine-columns: tdf#143258 Fix handling rotated text
        
        This reverts modifications to existing unit tests made in commit
        d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5. My idea that those changes
        were required because of more correct calculations was wrong, and in
        fact they were caused by off-by-1 error in height calculations.
        
        Change-Id: Ib94878a911238c977c35a8f8e3e5694cedc79a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118705
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-10  Justin Luth  <justin_luth@sil.org>  [4450137924eb8626a57283e1ab4f4ad62dd2d595]

        related tdf141964 writerfilter CN: drop obsolete exception
        
        First of all, the presence of an outlineLevel is not
        equivalent to being part of Chapter Numbering.
        Plus even if it is a chapter numbering style
        it should be fine to write "Outline" as the numStyleName
        after all of the prior rework of numbering import.
        So lets not keep unnecessary exceptions.
        
        Change-Id: I89149e199eddacefd0971c805e03d3ad66a1672b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118706
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-10  Hochwasser  <oo.o+libreoffice@windbuechse.samba-tng.org>  [dabb1dc347071abb7d6a708930f5fbdb8c68c72a]

        tdf#119312 Crash in: sdext::presenter::PresenterSlideShowView::LateInit()
        
        Change-Id: I8c2eda406d8266996eaf023072cc7f4f38edc4a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102902
        Tested-by: Jenkins
        Tested-by: Andrzej Hunt <andrzej@ahunt.org>
        Reviewed-by: Andrzej Hunt <andrzej@ahunt.org>

2021-07-10  Rafael Lima  <rafael.palma.lima@gmail.com>  [be8c4a236fcc7b9a949ef2a10e8bc8c61d33a7bf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a1127fd99b849f976984e0d6844ac1e314beefde
          - Python support for SF_L10N service help page
            
            Change-Id: If6708af7c4edf21ad7f33eb549be1bbd79dbfd61
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118714
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-10  Sergey Fukanchik  <fukanchik@gmail.com>  [41c01e48f695dd41ef2f39e83b22ca7b9dbab658]

        tdf#142702 Handle STARTMODULE in SvtModuleOptions::GetFactoryShortName
        
        Change-Id: I06064eb3ff3e77cd0fcc6e211c6baf07adcc3096
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116794
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
        Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-07-10  Caolán McNamara  <caolanm@redhat.com>  [48196e2e159105216d8fdb02da5b6407895063c6]

        ofz#32582 use simple output bitmap for fuzzing png
        
        Change-Id: Ie6f03d579f3dfc92ff1d2b6242fe941f74324b41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118701
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-10  Noel Grandin  <noelgrandin@gmail.com>  [4a93efcf6e7982146fb71e4d32760a07a0f984c2]

        try to restore SwpHints::MergePortions...
        
        ... logic to how it was trying to work before I started messing with it in
            commit 568b820bc2d52c007ee08ad7a3849c94a458115d
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Tue Dec 17 15:11:34 2019 +0200
        
            tdf#119227 fix freeze when copying a large bulleted list
        
            freeze goes from 5 seconds to about 1 second for me
        
            (1) used unordered_map instead of map
            (2) don't create temporary SfxItemSet's just to check equality
        
        and then I tried to fix that in
            commit 18e4367c33f327cf09985105bde583cdcc7b2a46
            Author: Noel Grandin <noel.grandin@collabora.co.uk>
            Date:   Thu Sep 3 14:40:32 2020 +0200
        
            tdf#132688 diacritics broken in lines with punctuation
        
            regression from
                commit 4b2d4f3c4a68361a6bc03c9ab110ce9376b14b20
                tdf#119227 fix freeze when copying a large bulleted list
        
        and then Andreas tried some more in
            commit 003d65ef1305eefb43315f93bdf10cee787f90f0
            Author: Andreas Heinisch <andreas.heinisch@yahoo.de>
            Date:   Mon Jul 5 22:32:52 2021 +0200
        
            tdf#140197 - Letter cut off at certain zoom-level
        
            regression from
                    commit 4b2d4f3c4a68361a6bc03c9ab110ce9376b14b20
                    tdf#119227 fix freeze when copying a large bulleted list
        
        Change-Id: Id9d04f96ccbe496ed809cf08e7aab25d6464913f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118643
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-10  Noel Grandin  <noelgrandin@gmail.com>  [930560b8e34369d8bd1e489f78dad8b5da2fd161]

        make SwpHints::MergePortions a little easier to read
        
        by extracting the attribute to a separate function, where
        we can use early return to exit the loops more naturally.
        
        Change-Id: Ibd189065f0e435be398db232b317f025192b3ee9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-10  Justin Luth  <justin_luth@sil.org>  [11211f2ff0a4d894f889874d46c6ba8be4d3dc39]

        tdf#141964 writerfilter CN: why ignore paragraph's listId?
        
        This seems bizarre. nListId was only set when the style
        defined it? What about the directly applied rule?
        Surely that has more relevance in all the
        subsequent code that used the value in nListId,
        as borne out in all of the code that re-calculated nlistId2.
        
        Change-Id: I188e812388c706cf0e785fdede29a6d21be12867
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115260
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [4146be28450c77159ae8c7f8d4d7f471756ec14c]

        Add Handler for BmpExScalePart Read
        
        The handler separates MetaBmpExScalePartAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I22f7cec1873dedfce16ec6ea597b5113089e8ec0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118677
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [fa17410b7cad394254818ca0dfcd92673fb642d0]

        Add Handler for BmpExScale Read
        
        The hanlder separates MetaBmpExScaleAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I2736e259955f2610ee6acd4a36be5d362df57b74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118674
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [7c85ebbc1aa81f54351f82566d25a11125eaeaa1]

        Add Handler for BmpEx Read
        
        The handler separates MetaBmpExAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ia5175e824716e08df2ac42e354b337b9e15050e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118673
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [83b3c793144a1ef39edb72e8d4c438dbec13c179]

        Add Handler for BmpScalePart Read
        
        The handler separates MetaBmpScalePartAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I0c8585ca18f3904a798a51081257c238b27297e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118672
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [19441313b37eb5d0a11c8a929a38c079fa7ef291]

        Add Handler for BmpScale Read
        
        The handler separates MetaBmpScaleAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I1641d11d6fbe49d023b758d7e6aaeabbc667030b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118667
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  panoskorovesis  <panoskorovesis@outlook.com>  [10d983f57f0bc1ec665d6e2bbfa1d9038446e7f9]

        Add Handler for Bmp Read
        
        The handler separates MetaBmpAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I60b9c2fbe9c5e23e0f1a05c4aa96565e3d14c403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118665
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-10  homeboy445  <akshitsan13@gmail.com>  [3057ee8ba01535324f57978569526988664eb53a]

        Added support for viewing results in the VCL tests UI box
        
        The user can now easily view the result of any VCL test
        by just clicking on it - which would show them the resultant
        bitmap of that corresponding test.
        
        Change-Id: I57c0c2ab3662a9abec45ba7fc230c9299dcd9279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117657
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [56d7965b6c24915359f39f45f1696c6f1dc3d3c9]

        Remove some iterator abuse
        
        Change-Id: I9279a1729e1715ac44c600c930f50c6e8704e676
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118393
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-07-09  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [0c8f364421014486c4e35a78a6dabca5b6a5dd26]

        remove some SwIterator abuse
        
        Change-Id: Ic95562ebb57106c733d919059ff9d042fef28f3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118392
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-07-09  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [debfdcfc0b2c07319e4a754decab18a292dc227c]

        remove global bDontCreateObjects bit
        
        Wrapping this in a scope based helper is mostly lipstick on a pig, but
        at least one cant forget toggling back this way. Apparently, this flag
        was already toggled in recursive calls without checking previous state,
        which is likely buggy.
        
        In the long run, this should a/ never be used recursively or better b/
        not be a global flag at all.
        
        Change-Id: Id3554d2acb94d565611701c046ca4d8669594cea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118371
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [af2d477a30c197be5fbfa54022343f7a559b35cf]

        ofz: OOM
        
        these old ww7- font names are supposed to be limited to maxStrSize
        
        Change-Id: Ide316a09d97d535b6cbc2911466df12f37e703cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118689
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [43f17336db888bd5d4671325e679dc12e693b1d0]

        split out duplicated condition and test it once
        
        Change-Id: I6b64ffc85123600046355cd5c4c8830f0d8e44c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118695
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [e875df09fc230639455a7084919bacd81c18c61e]

        gtk4: use m_bPopupActive rather than repeatedly call toggle_button_get_active
        
        Change-Id: Ia6b2df875da5af6bfb2198df503d59f34a762262
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118697
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [8c9588cceaad5a9155c8d22a44a2e7dc54a56aa0]

        gtk[3|4] rename toggle_menu -> menu_toggled
        
        Change-Id: Ieee73ae5ccfe625e2aedb9c44521e1c9222be6d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118696
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [caae3b77b23c382f58c1b0dd47ce8ed5d4ccad3b]

        gtk4: disregard insert-text signal if it happens while the popup is shown
        
        otherwise we lose our selection
        
        Change-Id: I2be572262528e9bcd12fcb0bc35bf9094f91b990
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Stephan Bergmann  <sbergman@redhat.com>  [6a1ed1e5cdb9f56fc8c7278b7361c7b2aa200bb8]

        Remove redundant duplicate check
        
        Change-Id: I311496e25ac617c6b174b828978a1298231bd433
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118686
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-09  Jean-Pierre Ledure  <jp@ledure.be>  [90d33528ceb9d3a6b0edda708ca102c16c320b0d]

        ScriptForge - (SF_Document) new SetPrinter() method
        
        The SetPrinter() method is applicable to any document type,
        except Base documents.
        It is also applicable to Base form documents with an
        additional "FormDocument" argument.
        
        Implemented in Basic and in Python.
        
        The method defines next printer settings:
        - the printer name
        - the orientation
        - the paper format
        
        The settings are kept per document or form document
        
        To bypass array management troubles in Basic,
        the SF_Utils._SetPropertyValue() Sub is converted to a Function.
        (no user scripts impact, only internal use).
        
        Change-Id: I39290d924646ff3b2a65a6d9282f1265ca7543b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118685
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [e6d73df65223e738de6e707eea573b41785198fc]

        make this a little more readable
        
        Change-Id: I9e7abcbc15ecd485df510aab7fdf93cd83b2f5ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118688
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [9fb3742df0a65238197e760a85f3f4a0e58ec31b]

        use GTK_PHASE_TARGET instead of GTK_PHASE_BUBBLE
        
        so we don't get called if the event happened in another widget hosted
        inside this widget
        
        Change-Id: I77fe9250ffa45b76602dc0e77839ccff2e856de2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Michael Stahl  <michael.stahl@allotropia.de>  [addd7e7835097043efda52594f3a34219dbd1063]

        toolkit: initialise new VCLXTopWindow properly
        
        VCLXToolkit::createSystemChild() doesn't init WindowImpl::mpVCLXWindow
        and so it can happen that another VCLXTopWindow instance is created
        later for the same Window.
        
        Change-Id: I9ac654dceb15ea619597f2b8d9d1f9282aa1dfc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118684
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-09  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [830ed2e0706a38a6a5debf41a41347b1f14a1d5b]

        Update git submodules
        
        * Update translations from branch 'master'
          to 299af21d9cc4faa4606f39d897ca9b91c8fd31f6
          - update translations for 7.2.0 rc1/master
            
            and force-fix errors using pocheck
            
            Change-Id: I71c26192dc4a8508810a8fe67149ad0ec9dc2874
            
2021-07-09  Justin Luth  <justin_luth@sil.org>  [ba7dc3413388449303745fdcbaa7e4ac478cd5a2]

        tdf#141964 writerfilter CN: also insert inherited listLevels
        
        If direct formatting specifies a numId, but does not provide
        a listLevel, the listLevel can be inherited from styles.
        Since this is a NOT-OVERWRITE, it is fine to try to
        insert again even if direct formatting has already
        inserted a level.
        
        Change-Id: Id6e492c8f686949de862cb052866b824ef90d8ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115259
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [162c5c343db475d9fc930c17b3d62a84925878b3]

        tdf#143008: sc: Add UItest
        
        Change-Id: I2797d67e675d1e2a53e9ddd1c81a29947182c54b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118683
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [2dbdaa2840f9e1b176464c132465ea5bb32208f0]

        drop newly unused SetParentToDefaultWindow
        
        Change-Id: I7586924bfc44dd7d28992515291089469a723c39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118651
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [6e90aec7fdcab6740b29597a7236cc0be2129762]

        gtk4: use the FixedContainer overlay for mouse events after all
        
        Remove gtk_widget_set_can_target on the overlay so that when we put
        native gtk widgets into the overlay they get events and can be
        interacted with.
        
        The DrawingArea is 'underneath' the overlay. So just move the mouse
        event handlers to the overlay itself so we can still appear to interact
        with the DrawingArea.
        
        Change-Id: I43056c5ee6228af85a194c1baa9f83c58b3e389d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118680
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [b1b6af02465b1a20ec4f28811bc5cc6bde8417be]

        gtk4: adjust restoring focus to GtkEntry part of GtkComboBox on menu popdown
        
        the order of changed and popdown is different that in the gtk3 variant
        so protect against something (font size picker) changing the focus already
        when the ComboBox reported a change before the popdown happened
        
        Change-Id: Ie93e92685c9155b2520841ca6a436e499666adf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118679
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Stephan Bergmann  <sbergman@redhat.com>  [f020784e14a55c82418e4f231855040177ac9f82]

        Make loplugin:stringadd slightly more aggressive
        
        ...by assuming that all const member functions are side-effect free.  (This
        presumably means that some of the special cases in
        StringAdd::isSideEffectFree are obsoleted by this more general case, but any
        such removal is postponed to later clean-up.)
        
        (Came across this when idly wondering why
        8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid
        OStringBuffer style" had not been found by the plugin before.)
        
        Change-Id: I6bca10df53885b14a590543aabd61f23b3748572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [ac7bba3cc1e13824732f5ab69af602848e4ba227]

        add Scheduler::ProcessEventsToIdle() to test
        
        to see if it has an effect on intermittent error of:
        
        sc/qa/unit/uicalc/uicalc.cxx(1325) : error : Assertion
        Test name: testTdf130614::TestBody
        equality assertion failed
        - Expected: 1
        - Actual  : 0
        
        Change-Id: Icbefe0889fd4f178fd3c7d12e8c3f5c1a46c6835
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118664
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [57dfefa71070d2168df7115856f468dfc0ccaccc]

        drop some calls to SetParentToDefaultWindow
        
        when the next thing called is disposeAndClear now that
        all SetParentToDefaultWindow does it hide the Window
        
        Change-Id: Ied3200eb3656594d446d65dadcb1cf27e6a7bd15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Rafael Lima  <rafael.palma.lima@gmail.com>  [e45aa2950c1113b17fdf5adf4c67e2522514e2ed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d2a1bbcae2b2311f13bb0651a4eb36bc978b46b9
          - Add Python support to SF_Database help file
            
            Change-Id: I47b7f328569d14d543708e3534bb99744b2cc3a0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118511
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [31311b7df472903e2f16102663d5bad17d8371ca]

        Add Handler for TextLine Read
        
        The handler separates MetaTextLineAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I360fb83b6b399905d8c08c8a7cd2bc587ae093ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118653
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [c46aba4341744ce7b0bf91ba86805687898c21a4]

        Add Handler for MetaTextRect Read
        
        The handler separates MetaTextAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ifa77ced87362204f946b36f95aebd3f72705ed5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118637
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [66ac7e94ea69cd62c256cae8d3ced82678ce6992]

        Add Handler for MetaStretchText Read
        
        The handler separates the MetaStretchTextAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I3c8627aa51254e8fc12167d726066060d007ac26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118636
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [58a064595e43428f7d74341aff38df40fec0c8b3]

        Add Handler for MetaTextArray Read
        
        The handler separates the MetaTextArrayAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ie74ef5b2e44d48c8c8a6d8efe9adda956cde4d3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118633
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [1d873936b48c2f672a12b8a380860d691937b8b3]

        Add Handler for MetaText Read
        
        The handler separates the MetaTextAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ic0692799bc89b226dc8d1d8f4f97155e421ab40e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118610
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [6cd8eeb66443dda80cf88205f33f184314d85c49]

        Add Handler for MetaPolyPolygon Read
        
        The handler separates the MetaPolyPolygonAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Iad883a65c4c018c9a6852a8b05011b5609f477a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118608
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  panoskorovesis  <panoskorovesis@outlook.com>  [e9d92a40bd59954d6716e889f4925319f4ab322e]

        Add Handler for MetaPolygon Read
        
        The handler separates the MetaPolygonAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I2b186acba2ca485b664568c155268cb3921a6a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118598
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [7699d89a5e8a442a77504260d70048392110b232]

        cid#1487029 Identical code for different branches
        
        Change-Id: Icb0c555772a92654e857226087ad80cbf91e25b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [5dbcf65d6999c835ac750a216f46ffe585f9018e]

        SetParentToDefaultWindow doesn't change parent anymore
        
        but for SalInstanceContainer::move with a null destination
        we do want to move the widget out of the parent to 'somewhere else'
        and vcl (unlike gtk) will complain if the new parent is null
        so continue to use the DefaultWindow as the temporary home.
        
        Change-Id: I3d738c11c3a1c07402d1a926d890caf3e657bca2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [4c24250cd52ab36ae0a44459675752ec22530f42]

        gtk4: use gtk_widget_get_preferred_size instead of gtk_widget_size_request
        
        Change-Id: I0d739b88095a5ab7a66d5bfb93f75366427628e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118654
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Caolán McNamara  <caolanm@redhat.com>  [9f918b1dbe687e330e424413f09a0a41bac3af32]

        can avoid exporting the Compat methods
        
        Change-Id: I850139c7858d599eb60d16401fc49fba5b72f568
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118657
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-09  Stephan Bergmann  <sbergman@redhat.com>  [9d27a44e8b79373573ea038d8a44874785036fd3]

        Do not support +/-NaN with an explicit sign
        
        The code accepting "NaN" had been introduced with
        92dafe9862d693ce9d79269627c3e6832422874e "dba33h: #i112652#: rtl/math.h:
        string<->double conversion and XMLSchema-2: [...] rtl_math_stringToDouble and
        rtl_math_uStringToDouble support XMLSchema-2 values in addition to deprecated
        previously supported values."  The "XMLSchema-2" mentioned in that commit and in
        the corresponding <https://bz.apache.org/ooo/show_bug.cgi?id=112652> "ORB:
        report builder not handle correctly NULL values" presumably references
        <https://www.w3.org/TR/xmlschema-2/> "XML Schema Part 2: Datatypes Second
        Edition", where section "3.2.5 double" only supports "NaN" without a "+" or a
        "-" sign in the lexical representation.  So stop accepting those.
        
        (I came across this in the context of 2b2b6405161025678f91a5625e50d0b414597368
        "Reliably generate positive or negative NaN again", wondering whether this code
        should be updated too.  But then decided that it is probably best not to allow
        that non-standard signed NaN notation for this case, and just keep producing for
        the "NaN" representation whatever std::numeric_limits<double>::quiet_NaN
        produces.)
        
        Change-Id: I035e78ca36240317f72f117d2b456fc474d8c08a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118647
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-09  Miklos Vajna  <vmiklos@collabora.com>  [a5606b69333a6f13cc8eec8f6f47db1a2fb5fb0c]

        sw: handle mbAddVerticalFlyOffsets when replacing compat options
        
        This was added in commit 50223ea6e212b60b7d33839c2753c5601fb50f95
        (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31),
        it's off by default and is in for Word documents.
        
        Change-Id: Ie3fdd0328e285de189d32edd73ea08e0938f6887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118655
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-09  Stephan Bergmann  <sbergman@redhat.com>  [010cf46e04907fa2503477ce4c0c85f465747034]

        loplugin:indentation (clang-cl)
        
        Change-Id: Iae559ca8bee9650c01167a4d1b918e18cbf03c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118660
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-09  Justin Luth  <justin_luth@sil.org>  [a45876adc36a3764cfeadb1737e5dcfb7ffee9da]

        tdf#141964 writerfilter CN: listLevel 9 means no numbering
        
        and so does numId 0.
        
        Wow - this is REALLY FUNDAMENTAL stuff, and we weren't
        handling it? Did anyone look at any of the specs
        when they were implementing import of numbering?
        
        Change-Id: I3ea20baccfae34751328558a873ccdcfda0de0a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115258
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-08  Gülşah Köse  <gulsah.kose@collabora.com>  [92a407b7f90a98704a238c5ffa3a3491eaf3263a]

        tdf143222 Handle alternate content of graphicData element.
        
        Handle alternate content and make true choice.
        
        According to ooxml spec ole object requires exactly one pic
        element. (ECMA-376 Part 1, Annex A, CT_OleObject). In the
        current case first choice has not pic element and we should
        allow fallback processing.
        
        Change-Id: I30b7de703b8c2f00d6bf286e05eea505ac3627f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118539
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [3175a7684982e7812e8071c595395eb3da3035fc]

        make SetParentToDefaultWindow available from vcl only
        
        rechecked tdf#119390. If I tear off the color popdown in writer, click
        in the combobox and shift-tab to put focus in the button (where focus is
        more visible) and close the torn off window then focus continues to
        return to the main document as wanted.
        
        Change-Id: I1e909cdf31e9a1309475d933d0ede289a84884b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [c109e1d1f5965fe03c666fee6c0bd4dd875f29c8]

        tdf#143146 copy functor and arg before calling function that can delete this
        
        Change-Id: I4e29fe6fa4119b709e31156afc5c2a5d08cdc072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118640
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [3fa9e73a5b07c828ac6377fc3b40d3c71d4b3a41]

        tidy up comment formatting
        
        Change-Id: I706fa295f6f75ff3c80c8107ab8aa08dc3a43902
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [36e1f1f5e7da5563ba721874e15a92b874ae1c5f]

        Resolves: tdf#143153 null-deref on grouping fit-to-frame obj with another
        
        Change-Id: I134d15ac980aa34ff274abd03966cd7948390542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118642
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [321436d7bb9087a92e8f69cc948bb3ebb23049c7]

        Related: tdf#143153 these are GtkBox properties not GtkGrid ones
        
        nothing to do with the crash though
        
        Change-Id: If7645a904de9147d20f548017bf5390fc57af6cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118641
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [583291d2d8d0cc9815b144c1b02847eb29421ccb]

        pGetFormatter was already fetched via GetFormatter()
        
        so don't need to refetch it here
        
        Change-Id: I0a881c1232c5749c4558088a58111908a8c8cb17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118605
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa5acdda9a1bd05263e482c4f527be6d088edde6]

        tdf#122191: sc_subsequent_export-test2: Add unittest
        
        Change-Id: Ib71b76766f1f20d73226c6551348c623077c06a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118611
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-08  Stephan Bergmann  <sbergman@redhat.com>  [2b2b6405161025678f91a5625e50d0b414597368]

        Reliably generate positive or negative NaN again
        
        ...after e5c80bb69a30dfb0a3daf6061ab127d92f8142d6 "Purge out setNan from
        math.cxx" had dropped the use of rtl::math::setNan and sign bit fiddling, and
        relied on the implicit assumption that std::numeric_limits<double>::quiet_NaN
        would produce a positive NaN (but which does not seem to be guaranteed by the
        C++ standard) and on the expressed hope that multiplying such a positive NaN by
        -1 would generate a negative NaN (but which does not seem to be guaranteed by
        IEEE 754: while it mandates that a NaN's payload is preserved across such an
        operation, the result's sign bit appears to be unspecified)
        
        Change-Id: I12215c888a1cb8de6b3f046a836c550cb21b5a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118604
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-08  Miklos Vajna  <vmiklos@collabora.com>  [8b7f948d9d79393bc6c1b11d239706666fd5d7de]

        sc, VmlFormControlExporter: avoid OStringBuffer style
        
        It's more efficient to have just one big statement with all the + operations.
        
        See
        <https://gerrit.libreoffice.org/c/core/+/118488/2#message-425f5c995c78ed24df430154bec28d89dcef9eb3>.
        
        Change-Id: Ifc304a58f5e34e7654a800fe1163beeec3f791a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118635
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [86a8701e2eb7ac81852fab3f49372d5ab58032e4]

        SolarMutexGuard::clear called twice where the 2nd call site should undo the 1st
        
        since
        
        commit 94f8a0e60b7bc5c1176eafe9a36c3f3466bd1408
        Date:   Thu Mar 20 09:08:10 2014 +0100
        
            Use SolarMutexGuard directly
        
            Change-Id: I4b245dd68bf032a1d74fb16b910dc952fd761781
        
        seen with compiler warning of:
        
        In member function ‘sal_uInt32 comphelper::SolarMutex::release(bool)’,
            inlined from ‘void osl::ClearableGuard<T>::clear() [with T = comphelper::SolarMutex]’ at include/osl/mutex.hxx:194:28,
            inlined from ‘void framework::ImageManagerImpl::reload()’ at framework/source/uiconfiguration/imagemanagerimpl.cxx:1071:25:
        include/comphelper/solarmutex.hxx:91:22: error: ‘this’ pointer is null [-Werror=nonnull]
        
        Change-Id: Ibd074794e4556a6ff34b0dc94099e81e1ae3b349
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118634
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [17811ca444676767ec72089c9fe8fb4ccd54cfc6]

        we check pChild against null in one branch but not another
        
        presumably we don't need to check against null at all
        
        Change-Id: I3fb909c12a541d1a70e9221f98f7b9337f19a5fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118609
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Justin Luth  <justin_luth@sil.org>  [bedd73ea578ad01171536ee90d22249fa221d2d6]

        tdf#141964 writerfilter CN: get paragraph and inherited listLevel
        
        Just like numId, listLevel is inherited from parent styles.
        This was totally missing. Even the direct formatting of
        a listLevel value was ignored (although that case would
        be rare, because usually both numId and listLevel are defined
        together).
        
        It seems like the most fundamental basics of our numbering
        import are wrong. EXTREMELY DANGEROUS TERRITORY,
        although this particular change ought to be quite safe.
        
        Change-Id: Ia3cbd941a0a90a932938597e0797ee8e2b0aca6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115257
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [19e0c59a722dca6cd8b6ca61ed421c34c2773d18]

        annotate LogicToPixel etc with SAL_WARN_UNUSED_RESULT
        
        Change-Id: Id5e58e6350f463817159642d30733f0b7e43a44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118607
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Caolán McNamara  <caolanm@redhat.com>  [16121e0144fc11fc26f45ea1a7b2e1488d5267ef]

        return value of PixelToLogic ignored
        
        the other uses of SdrObjListPrimitiveHit operate in Logic Position
        
        Change-Id: Id6a834a17e6e2252bd4f58d10cd95f7425191203
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118606
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d5c64be26a3be69814097ccfce44a42150ca9d2d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 6e44dc455cecec8e0109243bf7e2398e4dc1306b
          - update translations for 7.2 / master
            
            and force-fix errors using pocheck
            
            Change-Id: I42420023bbf647224c6e216da57904cedb6b7e89
            
2021-07-08  Michael Stahl  <michael.stahl@allotropia.de>  [4c6b204fdc0cba873d33d801a9853819c09bdc6e]

        vcl: nerf Window::SetParentToDefaultWindow()
        
        There is a problem with keyboard focus in an Eclipse RCP application on
        WNT; it is apparently caused by re-parenting calling
        ImplSalReCreateHWND() and that first transfers the focus to the newly
        re-created window and when that dies shortly thereafter to the Eclipse
        top-level window instead of LO child window.
        
        Re-parenting doesn't work anyway because mpAppWin is always null outside
        of unit tests and mpDefaultWin lives outside of time and space and
        doesn't know about any window the LO window may be embedded in.
        
        Re-parenting appears to be unnecessary because if a parent dies with
        undisposed children that's considered a bug anyway nowadays.
        
        (partially regression from 8a2f7704cd0e43304e54bf2281232335cc0979a3
         which removed conditionals that limited the reparenting to floating
         windows)
        
        Change-Id: I7a3997d5e714b40918337207ec1387922f86f8e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118588
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-08  Miklos Vajna  <vmiklos@collabora.com>  [d67085cd86dc1e74941c8337d1eba39981117977]

        XSLX export, button form control: fix handling of no macros
        
        Turns out that in case there is no macro, then the attribute should be
        omitted, leaving it empty is not OK. Excel warns about this.
        
        Change-Id: I2dbc4d837bd585674e013eb3ce6b898f12498c4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118600
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-08  László Németh  <nemeth@numbertext.org>  [8726cf692299ea262a7455adcf6ec25451c7869d]

        tdf#142700 DOCX: fix lost track changes of images
        
        anchored to characters or paragraphs.
        
        Tracked deletions and insertions weren't imported,
        if they contain only images anchored to character,
        resulting loss of the document content: i.e. deleted
        images were reappeared, as not deleted images.
        
        Note: because change tracking of the OpenDocument
        and Writer supports only text range based changes,
        the fix is a workaround using zero width spaces
        to create an invisible text around the anchoring point
        of the images. This workaround is not used, if it's not
        necessary, i.e. if the image is part of a bigger
        deletion or insertion, which contains also text, not
        only an image.
        
        Change-Id: Iaae6aae2c01191512c71117a0c788a4147c4cae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118557
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-08  Justin Luth  <justin_luth@sil.org>  [e5b3f975144228d49c0bac71031fc7356fd252ab]

        tdf#141966 writerfilter CN: set minimum threshold
        
        I have found that in both DOC and DOCX numbering bugs,
        many can be fixed simply by not assigning Chapter Numbering
        at all. So set a minimum threshold to deter useless assignments.
        
        [Note that a LO round-trip should save as numId 1,
        and thus a single entry would make it qualify.
        For Word-authored documents, this threshold means
        at least 3 Heading X styles (which matches LO default workflow)
        or 6 out of 9 Levels defined for non-heading styles.]
        
        Change-Id: Ic3d1c800a703721e7ab5302e274ee1eeda496ac0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118543
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [8f962ddc45ca4f6825b41f2786f9fd219b4c1586]

        Add handler for MetaPolyLine Read
        
        The handler separates the MetaPolyLine::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ic800b13cdca5bc6ffc00f1564e5a05303c445c5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118566
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [18b8e90ec255ce5cd94fd6fd0b3dc1729043552f]

        Add Handler for MetaChord Read
        
        The handler separates the MetaChordAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Id4251e270bab9dc609c220ad0f304ee38b9ed2bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118565
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [e935e60431ab138eab044573355e2ed27bb1b8fa]

        Add Handler for MetaPie Read
        
        The handler separates the MetaPieAction::Read from the metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I7b601a6ef03f4b0e777558e36aff87cd24588573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118550
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [4fc97b63f144d2fa2eeb05f3e88b5c863fd4f12b]

        Add Handler for MetaArc Read
        
        The handler separates the MetaArcAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I2d6e6bfa53b00811ba473db7e4d2255a1ca4becf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118545
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [0fab99d596f87739a3c98776591ca4f0c51b15b9]

        Add Handler for MetaEllipse Read
        
        The handler separates the MetaEllipseAction::Read from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I40c5f7c2993dd34cb370d909e251be9a588f6168
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118473
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [3f6c589530fbe7dbc418d777bdd5a7a1804e85bc]

        Add Handler for MetaRoundRect Read
        
        The handler separates the MetaRoundRect::Read from the metaact.hxx
        Read Implementation is now in SvmReader.hxx
        
        Change-Id: Ic0b29b2119db3417c2feba8dc5fd44215256c040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118433
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [082554ee94e61008c75595c45bdcf01af989241a]

        Add Hanlder for MetaLine Read
        
        The handler separates the MetaLineAction::Read from the metaact.hxx
        Read Implementation is now in SvmReader.hxx
        
        Change-Id: I27bfcc4323e8d351e8277898334fc623d6a53dd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118403
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [e21558852131de5c6721264edd274ebbc6c72973]

        Add Handler for MetaPixel Read
        
        The handler separates the MetaPixelAction::Read from metaact.hxx
        Read Implementation is now in SvmReader.hxx
        
        Change-Id: If45e8c46c28957c4f11c95d8a0ebbaeab01894d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118399
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [c23b42ce803f58e547637100e83bb6bab2843fe0]

        Add Handler for MetaPoint Read
        
        The handler separates the MetaPointAction::Read from mataact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: Ic383be9029f5a74479c511b29cf8759815d55713
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118398
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  panoskorovesis  <panoskorovesis@outlook.com>  [7c320f2836f01f92129551f7fee4df9583d3aef5]

        Add Handler for MetaRect Read
        
        The handler separates the read method from metaact.hxx
        Read implementation is now in SvmReader.hxx
        
        Change-Id: I824a06d9018b473fd2398802d69b4952d33c4ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118396
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  Miklos Vajna  <vmiklos@collabora.com>  [0025e80ba6d882f6f885499efaf37ab0e2ed699d]

        sw: use SfxPoolItem::StaticWhichCast() in SwTextBoxHelper
        
        	case RES_VERT_ORIENT + pItem->StaticWhichCast(RES_VERT_ORIENT)
        
        is more likely to match than
        
        	case RES_VERT_ORIENT + static_cast<const SwFormatVertOrient&>(*pItem)
        
        Change-Id: If6ce65ae26b1088acb41b390a4fc8c1a69c141bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118590
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-08  Thorsten Wagner  <thorsten.wagner.4@gmail.com>  [396ceb05ef2bb75ba5c81b83f443863c485fa0b9]

        tdf#125533 Update Calc style names for style sidebar dropdown
        
        Style names for Calc are updated to current style names. As
        default styles shown by sidebar dropdown are hardcoded, styles
        Accent 1, Accent 2, and Accent 3 were added to offer a few
        more options.
        
        Change-Id: I0e4b00f7e8a64e1ded077c559ed208fe71d784ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118038
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-08  Stephan Bergmann  <sbergman@redhat.com>  [395ecf1ed3040b4eac6b1fc8d6b96ca426657321]

        Turn OSL_DEBUG_LEVEL >= 2 SelfTest into CppunitTest
        
        ...and move "10.0", "10.10", and "1.5.0_010" from badVersions[] to good
        versions[] to make the test succeed (assuming these shall indeed be classified
        as good by now, presumably due to changes to the SunVersion implementation in
        the meantime)
        
        Change-Id: Ia7cf9b0e607743a5e0534078c0221c1423f6cfb3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118570
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-08  Todor Balabanov  <todor.balabanov@gmail.com>  [822f128e734f37ee4de9bf5b62640cbec140701e]

        Polymorphism is a better approach when there are chains of inheritance.
        
        Change-Id: I2580dafcf8792bf4b11db78988db8c2976e4545c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118569
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-08  Eike Rathke  <erack@redhat.com>  [7a58221f800e215934cbcb2d3907c35b44981611]

        Resolves: tdf#122191 BOOLEAN is a keyword, treat it as such
        
        ... to not end up with "BOOL"E"AN" instead, which is a date type
        with an era year and literal strings.
        
        This never worked but only was uncovered by
        
            commit ce4fc2fc08be8ea2773194e303ed42d2579e93a0
            CommitDate: Fri Mar 2 20:27:45 2018 +0100
        
                Resolves: tdf#115351 convert boolean equivalent format codes to proper Boolean
        
        if the format also had to be converted between locales.
        
        Also preserve boolean equivalent formats during Excel export and
        try hard to convert back as much as possible if a literal boolean
        string format is a Boolean equivalent of the target locale.
        
        Change-Id: I54f65c276cbf7bb99e960b6d7053c5fa95fbccb6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118591
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [e30d71fe58a2c06143c65a34b1de8dff45054550]

        gtk4: GtkMenuButton might have no GtkPopoverMenu
        
        Change-Id: Icfc2f0c39fc223c94c1a3f038a4c186349be4fa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118587
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [f62d2de95c3553e0615d3485645bf5061b97d520]

        WaE: Wodr type 'ActionMapTypesOOo' violates the C++ ODR
        
        Change-Id: If0b83e62e6c9905b1ae391fbed7c43b379dce5db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118586
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [ed2d309b5ccdaa1a58f37f70a00ad74452e163cd]

        make code a little clearer to indicate that pAnchor isn't leaked
        
        Change-Id: I656a8c8506d7905ece3ff1b0547c82c42b234ab6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118585
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [7d180d713392b98e40bc3778d9434a9b6fd0aa8b]

        gtk4: implement Menu::get_n_children for gtk4
        
        Change-Id: I6a6202783d30da2487e4033bcbe859e72f959f12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118579
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [e3c1460462ce1fdb7073b876c1d802e4b2cb49c6]

        gtk4: implement MenuHelper::clear_items for gtk4
        
        Change-Id: I0df18e50ad8955b3e5933287cba2ddcee02fec31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118577
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [a38fc872839909774a7097671fcaefe3c9127bdd]

        gtk4: silence warnings
        
        Change-Id: I4d9d391239a57ab81ce6f513a713ac91846b61d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118576
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0db3e8a815d4008a23f19df5c89871281c698ae8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc68b55ae08e9445e3ec982b7d5e91a4b522b9a1
          - tdf#143232 Set correct name for shrink/expand in Help
            
            Change-Id: Ia95edf96335a45743fc40e253d35d4b5de7c4f80
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118580
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [c118d90e13fff1b9404e179b61cd5919115a449c]

        gtk4: add get_item_id to MenuHelper
        
        and implement for the GMenuModel case
        
        Change-Id: I57da4d984f6a743043cd82c32edff35115fe94c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118575
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [857943a0e4e75f12ffe7b1dc9d91ef88fbdb75d6]

        gtk4: move more GMenuModel/GtkPopoverMenu handling into MenuHelper
        
        Change-Id: I994a0c6aeb2bfabec01999e4722ac0f72a3f359e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118574
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e3fa55f33dde9d8890a2a318b68f9d69a5a804af]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7c10c96ab3e221764a797442b0a04e8013584815
          - Fix typo on sf_methods.xhp
            
            Change-Id: I10ac058ca55a5fd7a5b606e0ad48f28399563b5f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118578
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [4c76bcb5f35527283c6070fc8e3911a35734eba1]

        tdf#132740 avoid some WeakReference cost in accessibility
        
        reduces time by 20% for me
        
        Change-Id: Ife78248fd36099298eb2401b362f16a1ae3c0434
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118534
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-07  Balazs Varga  <balazs.varga991@gmail.com>  [f6b143a57d9bd8f5d7b29febcb4e01ee1eb2ff1d]

        tdf#142910 sc filter: fix "greater than" or "smaller than" etc
        
        Filter "greater than" or "smaller than" (>, <, >=, <=)
        conditions according to the cell number format.
        
        Regression from commit: d5c2584bf36d21580db677b231c57f99f49aa2cb
        (Related: tdf#140968 avoid duplicated filter values)
        
        Follow-up to commit: 1f755525189884e4b2824889a6b9dea8933402db
        (tdf#142402 sc UI: store formatted values in standard filter)
        
        Clean-up for commit: d5c2584bf36d21580db677b231c57f99f49aa2cb
        (Related: tdf#140968 avoid duplicated filter values)
        
        Change-Id: I1284892398c9964ca5407b4d617a617f20341107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118272
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-07  Hossein  <hossein@libreoffice.org>  [8ea9a8bc43ea054521a44dc8e3bc537110ca9e33]

        tdf#143204 svx: fix SID_ATTR_TEXTCOLUMNS_SPACING SID collision
        
        These two SIDs have the same ID, which is fixed now:
        
        * include/sfx2/sfxsids.hrc:
        	#define SID_NOTEBOOKBAR (SID_SVX_START + 338)
        * include/svx/svxids.hrc:
        	#define SID_ATTR_TEXTCOLUMNS_SPACING ( SID_SVX_START + 338 )
        
        The symptom tdf#143204 is that the tabbed interface was hidden in Impress
        or Draw, which is now fixed.
        
        Looking at b66d87086804460c1986df1b832fd6b2ea075a90 (2014-04-01) we read:
          As commit 669ad519902e21e0cb3537fb7e203987f75a4077 (colliding
          SID_SVX_START based ids, 2013-06-24) suggests, new SID_SVX_START-based
          SID's shouldn't be added to include/editeng/editids.hrc. However, if it
          was done, at least add a comment about it to include/svx/svxids.hrc, so
          it becomes obvious that the two slots have the same ID.
        
        Also in include/sfx2/sfxsids.hrc:551
        
          slot IDs from SVX (svxids.hrc) ------------------------------------
          These SID_SVX_START entries came from include/svx/svxids.hrc, avoid
          accidentally colliding entries with include/svx/svxids.hrc and
          include/editeng/editids.hrc. Only add new SID_SVX_START entries
          to include/svx/svxids.hrc
        
        Change-Id: I5e8c14bdbaa72f1b030a686dd5fffc9ae8dd1306
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118459
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [b55389c7c1bff6b555e14a3cef570fcb85091e4d]

        gtk[3|4] give signal_item_activate an ident instead of a GtkMenuItem*
        
        Change-Id: I9f762dea7f2a8daadfbe4ee693caf5a40442aabe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [dc2abe4646cbf1c867a0ecc75bcb4e6c7d1fb806]

        gtk[3|4] rename signal_activate to signal_item_activate
        
        Change-Id: Ic90bd9f87bfdb8e7de6d5546ea1f8c33236e6469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118572
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [60c89f3b2c6cdcf84274eafd345fc20ccd90d381]

        gtk4: move new GMenuModel/GtkPopoverMenu handling into MenuHelper
        
        Change-Id: I637dcc4bc8fe31e1c8832ada84f844976ee44da7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118571
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Rafael Lima  <rafael.palma.lima@gmail.com>  [b35b5e03b4ecc694d61a72bebb8621b9562f870f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b46d9178afe749e720ef1a3ba3666e153111fc32
          - tdf#143229 Remove empty paragraphs
            
            Change-Id: I4dbb2eb2cfbb140a129c02290642a777c8f9f327
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118496
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-07  Michael Weghorn  <m.weghorn@posteo.de>  [cdc752fd5e5b3bf97043b9542867d84827614f2c]

        tdf#140594 Create proper window peer for FORMATTEDFIELD
        
            commit 2a694f9e0e7789b4b3b792a9eedd29366fa10c1c
            Date:   Wed May 6 14:08:07 2020 -0400
        
                lok: fix the window type of the formatted field control
        
        had introduced the new 'WindowType::FORMATTEDFIELD' and set
        it for the 'FormattedField' control (instead of using
        the previous default value set in the 'SpinField' ctor,
        which is 'WindowType::SPINFIELD').
        
        So far, this type was not explicitly handled when
        creating the XWindow peer.
        
        Handle it just the same as 'WindowType::SPINFIELD'
        and return a new 'VCLXNumericField', which e.g.
        makes sure that a "proper" accessible is created
        and thus alues of a spin field are announced by
        the NVDA screen reader (again).
        
        (See also
        
            commit 33cac418db78f64f7fa84b8e65c01c2b02cf17a7
            Date:   Fri May 29 16:53:59 2020 +0200
        
                tdf#133498 Make native drawing of FormattedField work (again)
        
        which had fixed a similar regression elsewhere.)
        
        Change-Id: Ie8a4d279a12a1b83a9cf97f1304d84214b3a2a2f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118568
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-07-07  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [52beb3907dd3c7e6ae112e263def1005272cecd8]

        tdf#142764 sc: import "Same content on first/left page"
        
        Different header of the first page was never imported
        (related to the missing UI support), despite its working
        ODF export.
        
        This commit sets the values of those options at ODS file load
        according to the "display" attribute used to hide or show
        a particular header/footer.
        
        Follow-up to commit 19fa853ce12136b5c14e0c5a0aa906c296b75388
        "tdf#121715 XLSX: support custom first page header/footer".
        
        Change-Id: I3409ad94a4d3ff86fd7f6d8afede3e7603024515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117788
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-07  Michael Stahl  <michael.stahl@allotropia.de>  [515b72fb9275c76ff9f26b0c3c47cac706d92af0]

        Revert "I suspect that we unlikely to use JRE older than 1.3.1_07"
        
        This reverts commit b3541dea4889b9d0039554f87bd16e55189cf8b1.
        
        Reason for revert: The code did not just deal with text encoding differences, but also with properties whose value contains line breaks.
        
        For example, OpenJ9 has line breaks in "java.vm.info" and "java.fullversion", which now trigger asserts; also there is "line.separator" but this one happened not to cause problems so far.
        
        Change-Id: I3ded8e824e96b6fcf21677dd9ba72cbf58c1d261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118495
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [716c20460372e3f3543f4dc81a49368a5291cd34]

        remove [g|s]et_item_help_id for menubutton menu items
        
        a fairly obscure functionality that was used in just one menu that can
        be dropped now that the help is changed to contain references to the
        help ids the menu items already have
        
        Change-Id: I4efa2f11e7d48b398152d7308341bd3e4308c377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Jean-Pierre Ledure  <jp@ledure.be>  [f3657a886d99a56366104335b0c4939ac0d0cb57]

        ScriptForge - (SF_Writer) move Forms() method from SF_Document
        
        The Forms() method was placed in the SF_Document service
        but was applicable only on Writer documents
        
        Now it is placed correctly in the recently created Writer service.
        Effective in Basic and Python.
        
        Additionally redundant parentheses have been removed in scriptforge.py
        
        Change-Id: I0d328b40577ddf81a188fdf72611f84751bcb506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118559
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-07  shubham656  <shubham656jain@gmail.com>  [d9d86730a6acbb7fe1c94d7bf8b58b81ab51b4a6]

        tdf#126685 Add UnitTest
        
        Change-Id: I84feb90f63f947a20db06cc66dd0f610fa71e7ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117945
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [c904eb726e7261a0fcb65d8637f73e5dbc27211f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 147ed04e1bff695f9242d5991334d1c8ddd7435a
          - set the extended tooltip explicitly for each of the form 1-9 menu items
            
            in the load/save chapter (outline numbering) menubutton menu so the
            code for that can be simplified
            
            Change-Id: Id954bbe39b997b77cf5d17330a651712ea9d5fcb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118560
            Tested-by: Caolán McNamara <caolanm@redhat.com>
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [10b0bea130a18e1573f7cb5c997917442208f31a]

        gtk4: implement get_item_label for GMenuModel
        
        Change-Id: Ia8c893502c1546ae77b03a59ce2798b99340cf72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118556
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [bcd39bc1e36c06ce1221a9d981363c292b614938]

        gtk4: implement set_item_label for GMenuModel
        
        Change-Id: Iee721fa9f50b2884b2d0e726c36d6821e135a561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118555
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [5933071ec7cb34c064206c8e81998a5f99d9aa8b]

        gtk4: rework remove_id to extract a standalone find_id
        
        Change-Id: I08ce91b78a09ad2db1c8e1aa09abc50fd61e177d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118554
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [4c56e02c71cbd0aa374afb5b9f8e2540b0d1149e]

        gtk4: convert GtkRadioToolButton to GtkCheckButton
        
        Change-Id: If09508de92aba82ea414cd2fb7b7029e96aaf2f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118553
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ca614be3eb65d852b2c811c853b754e5e5ecb36]

        tdf#132740 bypass work if selection has not changed
        
        takes 10% of the time off
        
        Change-Id: Ia0a2f4469088e103f162b7d85abb7fadc5f365cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118532
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [0a32449722c38ab59845ce451c231d82dafb1b58]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 28d20be2d79c99bbfd5fedea5c4b2af9d22a29c0
          - the button in outline (chapter) numbering is now called 'format' not 'user'
            
            Change-Id: I330a8c1b179921724c9c6d427b700eafcafb7814
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118558
            Tested-by: Jenkins
            Reviewed-by: Caolán McNamara <caolanm@redhat.com>
            
2021-07-07  Stéphane Guillou  <stephane.guillou@member.fsf.org>  [c4b5cdd54d9eb70c6ae56d4148674fc07469f79d]

        tdf#133368: update extensions website URLs and use https
        
        Change-Id: Idcdb5dbb4f0754425eeca4b137fa1626bba9ef6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118340
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e942e40a6c175e4e42a16be83191bc5e01f43b9]

        tdf#132740 improve TagWindowAsModified
        
        makes a small difference
        
        (*) Use strong ref instead of weak ref, because weak ref is expensive to
        access
        (*) to make that work, fix dispose()
        (*) cache the vcl::Window to avoid expensive VCLUnoHelper::GetWindow
        
        Change-Id: Ida7a060d729633a0feb326697509d90052bca1f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118533
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [73c9ef661d9ef6237d3fd3c259fd040a545b44cf]

        tdf#132740 don't broadcast if modified status has not changed
        
        take 10% of the time off
        
        Change-Id: I75c8d5e1297de342df711d15260073db59946116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118531
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [786d4d32e139d9cab4a6b5e4a59c1cd64b4d1da9]

        ofz#35878 Null-dereference
        
        Change-Id: I21725931777ff4ce8963db3af345c574645336ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118547
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Eike Rathke  <erack@redhat.com>  [0d3ffda9615ad48679e61d606004de65154cdbfb]

        DateFormatter: use Date::AddDays(), AddMonths(), AddYears()
        
        ... that do all the checks and normalize.
        
        Change-Id: Id3ffcf5146b25020ec808aa70240953d39328a82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118540
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-07  tushar  <tusharrai282@gmail.com>  [1f88af544ffe17c58806a6b947803e1a2b3db378]

        Added Find and Replace Transformation .
        
        Change-Id: I6ba0cd27bfd8b90923fb35d019fe0223bc9f07f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118384
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
        Tested-by: Jenkins

2021-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [0ad1810a9181c5a01015cfc5206fb5870f8d6138]

        basic_coverage: use Option Explicit where possible
        
        Add missing license headers to a couple of files
        
        Change-Id: I7610f922e9ac914ae8fda0d0b6a7ca389401caca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118489
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-07  Jean-Pierre Ledure  <jp@ledure.be>  [c2d69eae17acc93775066e649a3e22d542306ef8]

        ScriptForge - (SFDocuments) New SF_Writer service
        
        Addition of the skeleton of the new SF_Writer service
        as a subclass of SF_Document.
        
        Entry points in CreateScriptService are provided
        both for Basic and Python user scripts.
        
        Full compatibility with existing user scripts.
        
        Specific properties and methods will be provided in later
        commits.
        
        Change-Id: Ib00a9ea52023707d1429e8ad9dcb4dca2ca63174
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118515
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [a99fb22b48df4979191af1ff165a668fc4992d52]

        ofz#35832 Timeout
        
        Change-Id: I3cd37d3682cf1029e652eae2f38a3dc68b73ef59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118536
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [e9c2a63031353df8c96e4dcd32723090fa6503f7]

        remove stray unused image-position of 'right'
        
        Change-Id: I6ef038841a80084fcf74a71a0cdbc005c132b0b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118535
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [c1328995c100e61c940c4c848b1e4416a2931fe6]

        gtk4: use state-flags-changed for toolbar GtkMenuButton toggling
        
        Change-Id: I71b6a3e2e99b52be0c51987f097a3487bf83fac8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118526
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [d1640dfa88652aef9cc9b85b68f34626b592c569]

        pMenuButton check against null inside pMenuButton check against null
        
        and there's no possibility it changed since the first check
        
        Change-Id: Ic32f9ef3c4659178792a35c87f13ee21b1d54228
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118524
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [5d55a804fad870621fcf0e9b2d1a060dcbd179a5]

        xalign/yalign of 0.5 for GtkButton is already the default
        
        Change-Id: I1a428a7cc0ac1a07c39416802980d7c77265f093
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118523
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [ac31428d3f4a673e4876609632c41bc218be5e4f]

        gtk4: replace GtkToolItem with GtkBox
        
        Change-Id: I02067a4b22817518451daf5d93de8d89dc8e5027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118522
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [91d971c6dc0ba4753ba3e1939b0b65b09469f739]

        gtk4: convert GtkMenuToolButton to GtkMenuButton
        
        Change-Id: I5b11e49e5eab68926b76814a07718e761fc6beda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118521
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Caolán McNamara  <caolanm@redhat.com>  [ffe05ff05cecfa38390df9b2e218b37b34324b62]

        add truncate-multiline to new GtkEntry widgets
        
        Change-Id: I02ad90061cf291571a2b424bd526384c97580c7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118518
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [eac5977bfc11797eda356560a5e45c51108ef5a1]

        tdf#140506: sw: Add UItest
        
        Change-Id: I38edc066e0ace0ce7c3ce6273cd0908ef4a9e0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118537
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-07  Miklos Vajna  <vmiklos@collabora.com>  [cd0dd53926b4d02ba84b6f9f94df91f92e55d6d8]

        sw: rework to avoid DECLARE_SW_IMPORT_TEST() in CppunitTest_sw_ww8import
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I7f2750453ca90df3b0b09f83242c309ea1adcc10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118528
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-07  Gokce Kuler  <gokcekuler@gmail.com>  [070a5b039b181c380b1b9724a015314ff78c30ed]

        tdf#57585 Add new bullet behaviour to impress
        
        Added the feature of removing bullets from
        blank lines and showing the bullet in a faded
        color on lines that have not yet added text.
        
        Change-Id: Ifb3beed7a0127d85660842555c85ceb466258441
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118450
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-07-07  merttumer  <mert.tumer@collabora.com>  [0759191e6923945469bc426b2c322ddeade12e09]

        Cache a static wavy line as bitmap and reuse it
        
        DrawWaveLine is cpu costly so render it as big as
        possible so we can only crop it
        Edit:
        1) Moved the Cache class to textline.cxx file
        as it is local to that
        2) Provided a custom hash method for the unordered_map
        to avoid double hashing the key. Used boost:hash_combine
        for hashing.
        3) changed unordered_map to o3tl::lru_map
        
        Change-Id: I0ab191f7bb72ccd5074c78858de9831c1a462b7b
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117362
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117969
        Tested-by: Jenkins

2021-07-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [ccf88845752a978ff3536c4bf66658993939caad]

        actually use CLOCK_MONOTONIC in tools::time
        
        some of the code was not copied from sal/ correctly
        
        Change-Id: I0a84b61eeab6a1b51eaa8ad303909373c52a6bb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118529
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [09a5a04628eeadaef297e1c14009939c1f5dd564]

        drop stray skip-pager-hint properties
        
        Change-Id: I54f4bba95773797f19290fb357225f9726b2ce72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [96b461c36ec9c75bb03592c78c6fa641e3105c8d]

        add window-close-symbolic to allowed symbolic icon names
        
        and for vcl use vcl/res/closedoc.png for it
        
        Change-Id: If3c31298d40e6130de415998df8840021a706a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118516
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [5733166e7aeb7c1e08a3cd785d633e1e252e9c88]

        gtk4: adapt small-button for replacement of GtkToolbar by GtkBox
        
        Change-Id: I265665f13c2a5221bd1ce1a32747acd82120c6ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118514
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5925b60ba8fc50899edf9474ee76439a4c27086c]

        Fix extended tips text after translation review for starmath
        
        Thanks to Tuomas Hietala.
        
        Change-Id: I6b031d83ae9afbecd70d9a6641a882ac6d81ac8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118445
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-07-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [4e3939654427211c42fce02095394b3fca1691f0]

        Fix extended tip after translation cycle for filter/
        
        Thanks to Tuomas Hietala
        
        Change-Id: I6cc4302c8ccd3f7ac0bd9fd6d199da34e570b6bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118447
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-07-06  Eike Rathke  <erack@redhat.com>  [5e3bfdeb5ea4878a2546a7e1e16d0f3b6482024e]

        Related: tdf#125035 Introduce LongDateOrder and handle YDM in DateFormatter
        
        This fixes also
        
            unotools/source/i18n/localedatawrapper.cxx:1473: LocaleDataWrapper::scanDateOrder: no magic applicable
            lv-LV requested
            lv-LV loaded
        
        that is the only locale with a YDM long date order.
        
        Change-Id: I776b8706bf5bd3ec11cc46d38fd3613c8df7519f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118482
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [544e279f981afee23e3c02d62adb2c377ef6700f]

        gtk4: add some more working dialogs
        
        Change-Id: I7fc4c6bfecca783a4c60c13f61c66a8a665e41a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118490
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [406ea1528d47d1ccaf64827f8ba0d24f229147d7]

        gtk4: update GtkSalObjectWidgetClip with new scrolling controller
        
        Change-Id: I729584b71cf8d0a507b97fce96add66fb22508a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118513
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [7a7dd854339eee52e290cce5b526df87e933ec1a]

        explicitly left align label in expander
        
        Change-Id: I290a73d656b833559581e02fd9fcdb83b44600ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118512
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [0195b41a0c9e81f042e5b998a3b8f8c22a6b3c5d]

        gtk[3|4]: remove some unnecessary ifdefs
        
        Change-Id: Ie74fe410ec83a5c5ac270dcff1a6821d0a75f1f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [93bda63aaadedda64dfb8f4a6f9d7f3a08d49aab]

        use box instead of grid
        
        Change-Id: I394779489c256d666e14c7c5bfe55e8ebd94e32d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Miklos Vajna  <vmiklos@collabora.com>  [7e7a871bcd4f923b015a7e040969335696b434c6]

        XLSX export: handle macros on button form controls
        
        This builds on top of commit 1e3263a677b61c718d0fd1be15c066b933f7de18
        (XLSX export: handle button form controls, 2021-07-01).
        
        The binary XLS export already had code to turn Calc macro names into
        Excel ones, reuse that for XLSX purposes.
        
        Also fix the unwanted named range on export,
        oox::xls::FormulaParser::importMacroName() mentions how XLSX doesn't
        have matching named ranges for vba macros (while XLS has), mirror this
        on the export side as well.
        
        Change-Id: I877b6ba2c2e834a2327482da5cadcddf1b4672bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118485
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3d81ae0fbe5a3a8d2b27a2e7b8c4aff2b52ba3c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6be958e9618242079c2c674297670ca5797a21c2
          - extra args for sf_ui.GetDocuments() method
            
            Change-Id: Ia991e14b5896d8c84d8e3fae115df366723d75b0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117418
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [a0ae4bb38cedf5f30a2bb6b6578024bb299112fe]

        use an explicit box instead of container
        
        Change-Id: I59a5e02ce4ff89c95c7ebdb666a6eaeea871b61f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [c420b05745a507d6649c84279b6de5455d7d6ecb]

        gtk4: insert an intermediate GtkBox as 'toplevel'
        
        so we only have to concern outselves about GtkBox and GtkGrid as
        containers
        
        Change-Id: I7154c6256d26b0bb1e13a75eb063ae86d3632bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118479
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [32196af8ef5fd6473668ad147c6bfe8c2adf7e52]

        gtk4: convert GtkToggleToolButton to GtkToggleButton
        
        Change-Id: I35b5cbc0bc4fb50f0eb763b1de1d31646bbf961e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118478
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [8eb1aeac694d3b85ca22de7fc9e14c6827063bb7]

        gtk4: get toolbar item clicking working
        
        Change-Id: I5e60a48a5e2ffeb06785ed81a8a3767cff752b1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118477
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [55eaa0a147b156e02c39a8e8194bc90a27211ec9]

        gtk4: add style of class toolbar to GtkBox replacing GtkToolbar
        
        Change-Id: I4b21fc7081f1037be610148fd032b257fdc698af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118475
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [fc98f9a0cd88543f7c053e57023c6c353a3fa429]

        gtk4: implement filling in GtkButton icon-name from vcl theme
        
        for converted GtkToolButtons
        
        Change-Id: Id6a4c91e7cc9f8dcbcecba7378768e603b5dbb2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118474
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [b06b116dfcf1f30302cbf0ee08653df2e4871c24]

        uitest: move table tests where they belong
        
        Change-Id: I2f756b3176f1f406cc659ff1c13a368906e33cbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118469
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-06  baltasarq  <baltasarq@gmail.com>  [0eacbfa75132724faaeeb9ea22a1c3e44eefb515]

        tdf#142922 fixes Round to follow half-to-even rounding
        
        The LibreOffice's Basic Round function does not return values
        that are compatible with VBA's Round. This can be easily fixed
        using rtl/round, which has a flag parameter called
        rtl_math_RoundingMode_HalfEven which rounds real numbers
        exactly in the expected way.
        
        Change-Id: I2215f08427e5777fc2d35f054b635dfa6247af8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118444
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-06  Eike Rathke  <erack@redhat.com>  [6e0b7d2aad6f1a041dd9e0e28aa4bf27eb3fc077]

        Remove now unused LocaleDataWrapper::getLongDate()
        
        Change-Id: I8e9614a4d77aa8b0c0e68a248ea57f921e3ed424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118476
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-06  Regina Henschel  <rb.henschel@t-online.de>  [72541a46aa26194b751785cd56185c8d3db0c9e9]

        tdf#143208 set property ContourOutside in docx import
        
        The property value was correctly read from wrapTight and wrapThrough
        to bContourOutside, but not added to the shape properties.
        
        Change-Id: I825ec2a652031edf69e05f611e6da0f1afd862cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118456
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [36939127391f2275cad5a676cf073cfa998c9982]

        gtk4: turn GtkToolButton labels into GtkButton tooltip-text
        
        Change-Id: I03e49b79a9a5252459315d3806ab46d4032690e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118468
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Miklos Vajna  <vmiklos@collabora.com>  [4f33e723900c280c17c75898fb7a59e2e749f93e]

        CppunitTest_emfio_emf: add some tolerance in TestDrawStringAlign
        
        Commit 574dc1e8ff6ea4214fefd91216fca5146a4ff13e (EMF+ tdf#142995
        tdf#142997 tdf#143076 Add alignment support for DrawString, 2021-06-24)
        added this test, it seems the result depends on what fonts are
        installed, so add some tolerance.
        
        Probably it fails for me (and not on Jenkins) as I have lots of
        additional fonts installed, e.g. Arial (and not only Liberation Sans).
        
        Change-Id: Ie93d1f1efe1fbbf1851ad46f33f5f83c8812e6d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118470
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-06  Caolán McNamara  <caolanm@redhat.com>  [ecb63e193e20d5a920fce637e8aa1c0acd743b20]

        gtk4: get enough of toolbar working to get spelling dialog to appear
        
        there isn't a dedicated GtkToolbar anymore, just a generic GtkBox with
        GtkButton children
        
        Change-Id: I6d67c9ffde13dc4f787804466ece498f973ba0b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118467
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-06  Mike Kaganski  <mike.kaganski@collabora.com>  [5f843dc41e42aaac362b0dc82a8344fba120e086]

        Explicitly call an operator to avoid a bogus IntelliSense warning
        
          More than one conversion function from "const Fraction" to "sal_Int32" applies:
                function "Fraction::operator sal_Int32() const" (declared at line 54)
                function "Fraction::operator tools::Long() const" (declared at line 56)"
        
        Change-Id: Id6f72c386d395509d3853ffc8e1a7852cca45e6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118429
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-06  merttumer  <mert.tumer@collabora.com>  [c18d2b46a37893acb7922c5dc49ddc4631a2c05d]

        Fix click on the drawing area of CSV dialog
        
        Change-Id: I8c13698b5e9e2e9c8869aa9094ce93c38bf2276f
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116796
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117968
        Tested-by: Jenkins

2021-07-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [faaf95859c0b6f0cea105b8a85551b8afbc56f21]

        basic: remove unneeded variable in test
        
        Kudos to M. Kaganski for spotting it
        Change-Id: I04ceea4607cf94a5a84af4f171d6f2b204ef8653
        
        Change-Id: Ie9064d3c12da657ecd82fdab6891bc8703ee6f37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118464
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-06  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [913ea7e18af9e04c82c9b33ddd34b4b5a0917f29]

        sw: test fix of tdf#131771
        
        Change-Id: I9879f13e842dd7288c996c1097130e7e7b28589c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118432
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-06  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [003d65ef1305eefb43315f93bdf10cee787f90f0]

        tdf#140197 - Letter cut off at certain zoom-level
        
        regression from
        	commit 4b2d4f3c4a68361a6bc03c9ab110ce9376b14b20
        	tdf#119227 fix freeze when copying a large bulleted list
        
        Change-Id: Ib69af488fcd30553b4aa4fd3f4b35b5a08d67adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118455
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-06  Mert Tumer  <mert.tumer@collabora.com>  [2779e669fd54695ace5a9425280d1efca93729b6]

        jsdialogs: send click pos for drawingarea
        
        Change-Id: I91aae808fe17f47fe9fa75dca069e4919c2ce4c3
        Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108685
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109216
        Tested-by: Jenkins

2021-07-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [25598c819b9a591f2fad1ec6ea2c8729027c9e3f]

        Fix typo in code
        
        Change-Id: Iabd6c07614df7b0335c1609b62116f26a1db2d06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118451
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-07-06  Justin Luth  <justin_luth@sil.org>  [3e09e0784ad7669d3e0a7655f5e604a2387b1b5d]

        tdf#141966 writerfilter CN: fix chapter number identification
        
        This totally up-ends the current way of doing things,
        but it was so totally broken, and confused us for a very long time.
        Chapter Numbering has nothing to do with "Heading X" styles!!!!!!!!
        Thus, we can clean up a lot of nonsense clauses.
        
        The existing code makes it sound like the constraints of
        "outline numbering" are an MS format thing, but actually it is
        just an implementation detail of how LO contrains styles
        and listLevels.
        
        Yes, it is still nice to be able to round-trip the
        Chapter Numbering settings, so we won't ignore it completely,
        but really, all the complexity comes from trying to cram
        the normal flexibility of inheritable, style-assignable
        listLevels into a single special-purpose numbering rule.
        
        One thing that has always killed us is that direct formatting
        could not share in this unique style. But it needs to in DOCX.
        So, the key here is to NAME-ASSOCIATE the "Outline" style,
        so that ALL references to that numId end up pointing to the
        same rule, even if it is the super-special oddball one.
        
        P.S. Chapter Numbering should have NO IMPACT on the
        import process. It should only affect UI interaction
        when a user assigns a paragraph style: whether LO can
        apply a numbering listLevel or not.
        
        THIS IS EXTREMELY DANGEROUS TERRITORY! WAIT FOR 7.3!
        
        existing unit tests that mapped to a numId other than 1:
        ooxmlexport3: tdf95495 - numId 4
        ooxmlexport4: tdf81345 - numId 3
        ooxmlexport5: tdf123262 - numId 48
        ooxmlexport8: fdo74745 - numId 6
        ooxmlexport10: tdf89165 - numId 12
        ooxmlexport14: tdf133605 - numId 2
        ooxmlexport16: tdf132752 - numId 2
        
        and one example which didn't take the first available choice:
        ooxmlexport13: tdf95848 - preferred numId 3 over numId 2
        
        Change-Id: I561cd1594f198ad402893c77c1c983f206f53c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115614
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-06  Miklos Vajna  <vmiklos@collabora.com>  [cfc677d667e118bfe7f092b584c4773476b9b906]

        sw: avoid not needed copy in SwTextBoxHelper::getProperty()
        
        Change-Id: If4b4cecf083367082542e12d57ddf16fef3c6dd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118454
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-06  Gizem Ozgun  <gizemozguun@gmail.com>  [1c8483d2174bc6419829dface97627a4304c8912]

        tdf#142459 Fixed long class names are truncated(gen)
        
        Change-Id: I9c88beb3fc83c23b2e866824985d50567b056f7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118035
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-07-05  Andrea Gelmini  <andrea.gelmini@gelma.net>  [bd2f2273d83dcca43eb6b465308707efd45e7adf]

        Removed duplicated includes
        
        Change-Id: I26af0a81f41a322239717346a47b225e2236fdbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118453
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-07-05  Eike Rathke  <erack@redhat.com>  [28859cd06cc699708bb43cb5e4ac7077d3a10f5b]

        DateFormatter: make TextToDate() long date calendar aware, tdf#125035
        
        Using number formatter to display long date now can generate any
        arbitrary date string in any calendar known to the locale. Cope
        with non-default non-Gregorian calendars when parsing such string
        back to a date and convert to Gregorian for the calendar widget.
        
        This currently relies on month names being different between
        calendars, which isn't fail-proof but at least works for the ar_DZ
        Hijri->Gregorian case.
        
        A better approach would be to remember the calendar used in the
        number formatter output, but that's not available (yet?).
        
        Change-Id: I829655275de4d1983b7e453624efca967b16a3bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118449
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-05  Noel Grandin  <noelgrandin@gmail.com>  [6cb400f41df0dd108cdb4b4d3ec6656844814147]

        store the SfxItemSet inside SfxSetItem by value
        
        rather than on the heap, avoiding an allocation
        
        Change-Id: I3f1504f9a2d4178a9ba59e98de182a0ab98cdce0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118356
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [b99e8c79bf630432fbb6a819d69da0bd2db7c80c]

        don't re-allocate ScriptRun vector unnecessarily
        
        resize() will re-allocate the array which seems unnecessary here.
        (This change eliminates reset() from my perf profile)
        
        Change-Id: I61d02ddc88ed186308d90e2c7bf8d7237194f0b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118435
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [3be3a020d4c243f9b12d90fe75be103337002be6]

        tdf#117612: basic_macros: Add unittest
        
        Change-Id: I4189b52be788deafe921c860f807ec5cee8ec667
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118443
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6cc94ea781699b899ad92ca6ceab2e8f59d1606]

        tdf#134692: basic_macros: Add unittest
        
        Change-Id: I9115eca2fce784cd55a8eb4f1cfd6e614fd3612b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118442
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [b1a171c95531bda12d43bba81fa00d02ba3146a7]

        tdf#143165: svl_qa_cppunit: Add unittest
        
        Change-Id: I34e97340f9f7607107b98f8316fb092fa805d2c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118440
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-05  Eike Rathke  <erack@redhat.com>  [0335a319c5662f0b849a2231e48338dfeb6aa845]

        Pass Formatter::StaticFormatter also from weld:DateFormatter, tdf#125035
        
        Change-Id: I8e6b0e581b9522fb04225fc945e579406a4be208
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118438
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-05  Heiko Tietze  <tietze.heiko@gmail.com>  [06e48b4beb0f898483211c77adbb2e83d8908cee]

        Resolves tdf#137160 - Thin space before f./ff. in en_US
        
        Change-Id: I3a2f2206d9784de2da6af8ea2b882e1ebe6205e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118439
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [94319445e2e5774b38805dea4cc54caf8e0a7320]

        uitest: just use UNO commands
        
        Change-Id: I54b03ef19dd295001813e2e3000c073c2771e8c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118434
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-05  Caolán McNamara  <caolanm@redhat.com>  [a58eb4ffd5e58822cf7e5bda5fd93d62ccc23918]

        ofz#35800 Timeout
        
        Change-Id: I6420e0826a2725e0964ab01b5c2117ab664ca699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118405
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-05  Caolán McNamara  <caolanm@redhat.com>  [7d37aba1185b1c2f8effe45d55e171010c0a6f31]

        ofz#35817 Timeout
        
        Change-Id: I99b3ce9189e3b76b60916482aa64cc7454ba9495
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118404
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-05  Miklos Vajna  <vmiklos@collabora.com>  [db1c8df98a23d687d6806f371bdd416dd1b84589]

        XLSX import: fix handling of named ranges referring to PathMissing sheets
        
        In case xl/externalLinks/externalLink1.xml refers to a sheet where type
        is PathMissing, then both <sheetName> and <sheetData> gets ignored on
        import. Make sure to also ignore named ranges referring to such external
        documents.
        
        The resulting named range was just a string anyway, and exporting this
        back to XLSX results in Excel marking the whole file as corrupted.
        
        Change-Id: Ifde07b5e59fba371f1f8ab3e82861c6997c6dbf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118401
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [bec391133da18e1c7c0e7f3d562bceeb6f93b497]

        uitest: sc: move pasteSpecial tests to their own folder
        
        Change-Id: I19dcb65937bb25ccc74f347788a554450fb291f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118410
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-05  Eike Rathke  <erack@redhat.com>  [89a3caee73c476133af804d9a0a650e72e711d95]

        Resolves: tdf#143165 Date input must match separator, D,M,Y not part of
        
        Change-Id: Iae464fd0fc6c480b9a16ccb2f8eb635812c6eeff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118408
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [580b5f6a3bf671f6590f40795d7cb9e46d52cf9f]

        speed up exporting very large spreadsheets to pdf(2)
        
        e.g. the one in tdf#102216
        
        instead of copying the data we want back and forth, just share it via
        shared_ptr.
        
        takes it from 6min28s to 1m21
        
        Change-Id: I44d174264baa875e1922d1d46ee07de0e8cbaf0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [8de4f0d77073a2a3850bbcdd09aa7f68c223da01]

        speed up exporting very large spreadsheets to pdf
        
        e.g. the one in tdf#102216
        takes it from 27m16s to 6min28s
        
        Change-Id: If6cf7dd49cb43f1749da29da91dab6646d4a0626
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-05  Vert D  <devoptmsoi@gmx.com>  [06d063a9de41a24922f15cd3aa47411b61d30c23]

        tdf#138906 prevent built-in category deletion
        
        *Remove category selection dialog for Delete Category.
        *Delete Category now deletes the current Category.
        *Import now imports to current category.
        *Remove Buttons, add items to menu.
        *Enable delete multi selection.
        *Change Dialog titles.
        *Remove searchview class. (I see no reason for it, it just copies code from localview and localview can handle search results on its own.)
        
        Change-Id: I5add4aa9fa68ac68c796a6b98fb54a5d0da93bd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113712
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-05  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [25e09087d8e2c5cecca1d548c69a263c7bf8b7ca]

        tdf#140506: fix repeated table header switching
        
        this fixes regression from f899c28f210c6565b7227d7665d449f194d2af8e,
        which asssumed all frames to be listening to the Notifier of the
        format. That is not (yet) the case.
        
        Change-Id: Ib684842c571823eeb72824196ccfdb1df8179e85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118370
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-05  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [ec277dfdda8acd08694b03a6b1fb88c5fede35d2]

        tdf#131771 sw: fix missing table style after copying and pasting the table
        
        This fixes the loss of table style setting when copying and then pasting a table.
        Change-Id: Ie678a269b4cdcddfd73a5d6a27ef9fcb55dcaa46
        
        Change-Id: I48208337ee14fde30417fa3999f56999cc5eda19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118336
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-05  Tor Lillqvist  <tml@collabora.com>  [bcaf8b746ab4a5f8fa08217b1081fdad4532425e]

        Simplification: Use getNow() here, too
        
        Change-Id: I0a9dc8ef9897c7b9973b42f10bcf51db27e188cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118402
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-07-05  Heiko Tietze  <tietze.heiko@gmail.com>  [21b5364ab01f0ceb9197572ff8f50d8a8cea64e1]

        Resolves tdf#143174 - UNO MoreDictionaries not working
        
        Missing exec method added
        
        Change-Id: I2272654ae6ed9d9525c98392a9f65a74a108af02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118395
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-05  Miklos Vajna  <vmiklos@collabora.com>  [a7558455f6661f370100cfee79d64b9c5fbd28d8]

        sw: prefix members of CaptionSaveStruct, HTMLTableRow, ...
        
        ... SwXMLBrushItemExport and SwXMLBrushItemImportContext
        
        See tdf#94879 for motivation.
        
        Change-Id: I502fd14d204aa9936d929c7cf8b6f0f16e8750fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118397
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-05  panoskorovesis  <panoskorovesis@outlook.com>  [882f8a34f6829bcdc113ccc96da66c376e38b437]

        Add Handler for MetaFillColor Read
        
        The handler seperates the read method from MetaAct.hxx
        Required set methods are added.
        
        Change-Id: I93bb581c6ea6b4e6171da30cfff572406e822f40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118275
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-05  panoskorovesis  <panoskorovesis@outlook.com>  [0779fd344afee8c8ea182e3f97c971663bef3632]

        Add Handler for MetaLineColor Read
        
        The handler seperates the read method from MetaAct.hxx
        Required set methods are added.
        
        Change-Id: I070af28711c111d60b3af3ae23fd8d6e93429cf7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118217
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-05  panoskorovesis  <panoskorovesis@outlook.com>  [960d8c227bf39c66b5366f6024635ee317c6b314]

        Create Separate SvmReader class
        
        Add a new class to handle MetaAcion.Read() at
        vcl/source/filter/svm/
        Modified svmtest.cxx to use the new Read() method.
        
        Change-Id: I617cb8fe14704e1303c866261ceb695238f04234
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118143
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-05  Heiko Tietze  <tietze.heiko@gmail.com>  [7c1bad415ae48635dc67041c413bb7b76a530c22]

        Resolves tdf#142938 - Clarify option to replace dashes
        
        Change-Id: I0ebc183e27a48d3c0d73a4b7954d35bae62eba61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117585
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-07-05  Justin Luth  <justin_luth@sil.org>  [3f6797c29e9672eba354400f24a669244fd746c0]

        tdf#132776 sw UI: make unique names for custom hatch and gradient
        
        This has already been done in sd, so just copy the idea
        and adapt it to fit in the sw environment.
        
        This fixes LO 6.3.4 regression from 7.0
        commit 53c474633c4e658f096669fb0225d751a5701aaf.
        
        This reason for this is noted in one of those commits:
        > However tdf#99908 shows that ODF import doesn't like anonymous
        > gradients. This is a bug in xmloff style import and should eventually
        > be fixed there. Here we implement the same band-aid solution
        > tdf#99908 implements for Impress sidebar
        
        Change-Id: I4437ac97b6aa97f2cd27a10c3d593dc97d24e9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117594
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-05  Justin Luth  <justin_luth@sil.org>  [17bc5794d6acd38304653dc78b95f9f772893ca7]

        tdf#104239 doc import CN: don't skip no-style levels
        
        The Chapter Numbering "Outline" style must copy
        the entire range of levels, not just those that have
        a paragraph style associated with them.
        
        Change-Id: I25578129e9cdbd8eb3dab710a2b26dd2764752e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118343
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-05  DaeHyun Sung  <sungdh86+git@gmail.com>  [0afa7e64d547a8f2a48402660acf5c95a468a0ab]

        Fix Line break rule in Korean
        
        I found the bug, Line break rule in Korea don't work
        using `" -U+0022: Quotation Mark` & `' - U+0027: Apostrophe`
        
        So I fixed the bug in xml file.
        `&apos;` to `' - U+0027: Apostrophe`
        `&quot;` to `" - U+0022: Quotation Mark`
        
        Because, `'` and `"` are still displayed in several other line break rules.
        such as, zh_CN.xml and zh_TW.xml, etc.
        
        Reference1: HWP Guide - 금칙문자(Forbidden Characters)
        http://help.hancom.com/hoffice/webhelp/9.0/ko_kr/hshow/tool/forbid.htm
        
        Reference2: OOXML ISO/IEC 29500–1:2016(E)
        Korean
        
        * Cannot start a line: !%),.:;?]}¢°'"′″℃〉》」』】〕！％），．：；？］｝￠
        (Unicode character values: U+0021, U+0025, U+0029, U+002C, U+002E, U+003A, U+003B, U+003F, U+005D, U+007D, U+00A2, U+00B0, U+2019, U+201D, U+2032, U+2033, U+2103, U+3009, U+300B, U+300D, U+300F, U+3011, U+3015, U+FF01, U+FF05, U+FF09, U+FF0C, U+FF0E, U+FF1A, U+FF1B, U+FF1F, U+FF3D, U+FF5D and U+FFE0, respectively)
        
        * Cannot end a line: $([\{£¥'"〈《「『【〔＄（［｛￡￥￦
        (Unicode character values: U+0024, U+0028, U+005B, U+005C, U+007B, U+00A3, U+00A5, U+2018, U+201C, U+3008, U+300A, U+300C, U+300E, U+3010, U+3014, U+FF04, U+FF08, U+FF3B, U+FF5B, U+FFE1, U+FFE5, and U+FFE6, respectively)
        
        Change-Id: I07f6afc60d0a83508a8ba971f31d2ca66846cd23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118027
        Tested-by: Eike Rathke <erack@redhat.com>
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-05  Eike Rathke  <erack@redhat.com>  [57e0b8637a0c6f53a43c987df51a00a5a0f3909f]

        Related: tdf#125035 Include day of week in formatindex="19" DATE_SYSTEM_LONG
        
        Change-Id: I3cbbda7592fede575b766f0631c5f4b42a19e03e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118387
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-05  Johnny_M  <klasse@partyheld.de>  [2ea55e2a5b5f9cb8745f3f122e92684da8476ef5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 763f9602c61ed20a748e888c5b297b7f9c0bf86e
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia6765abde226b958db7b17a50abf286545e86c87
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118349
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-05  Johnny_M  <klasse@partyheld.de>  [63c5a0761f6780fe49f3558e1d1b566778d0c46a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dabedfd9faa58db0ee3b5e22274b20f401753e12
          - tdf#132643 Translate German section IDs
            
            Change-Id: I47ac902ced473a37f1787484101d9f881ddb9228
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118350
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-05  Johnny_M  <klasse@partyheld.de>  [211deccb2008eb1f7486529e88a3b165b9a83660]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 33cc5ce335d52ea47179331cd16465842c97e1e8
          - tdf#132643 Translate German section IDs
            
            Change-Id: I04f58a66d8e2e1e47fa4b5298857aa5188ca3a03
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118348
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-04  Caolán McNamara  <caolanm@redhat.com>  [0dc7b1cbb995d5befea9ee44280b4e725f260796]

        ofz#35787 Timeout
        
        1m14.061s -> 0m3.975s
        
        Change-Id: I96e6f2c60017ba57062bd56c2e80604e117b3b99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118381
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Caolán McNamara  <caolanm@redhat.com>  [34fcf3b6e0f32f9327c905e2e2507427e7ef4f91]

        add a const SwDoc& arg for a follow up optimization
        
        Change-Id: Ib18e6c93e35fc3021a874f4313cf38fbb99d696a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Andrzej Hunt  <andrzej@ahunt.org>  [e1d3c8438ade045aab4452dd59000d27f810ca91]

        Fix LIB_FUZZING_ENGINE not-empty check
        
        Switch to '-z $LIB_FUZZING_ENGINE' to check if LIB_FUZZING_ENGINE is
        set. The previous version evaluates to false when LIB_FUZZING_ENGINE is
        not set, meaning you would not be warned at configure time when using
        -enable_fuzzers without setting LIB_FUZZING_ENGINE.
        
        Original broken version landed in:
        44b36a0602b04342566362bce3f6bed7d2b096e4
        ( https://gerrit.libreoffice.org/c/core/+/111691 )
        
        Change-Id: Ic2174777ebf724e471cd605ba54b245e4e804705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118372
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Caolán McNamara  <caolanm@redhat.com>  [c551e34018d7392f44ff8d7216dda4a480c6eea7]

        ofz#33258 don't set a replacement font if the current one is the same
        
        5.602s->4.022s
        
        Change-Id: I5983d4f51bda7249f7b37d642dd970f01b70d3aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118365
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Caolán McNamara  <caolanm@redhat.com>  [f244961d1ff2df1e50980e116f95c312089bc8ce]

        tidy lcl_swcss1_setEncoding a little
        
        no logic change intended
        
        Change-Id: Id82fb83d0947a838f2c2970a073712d221e5ed92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118364
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Caolán McNamara  <caolanm@redhat.com>  [3ebee45e504abac356d68a4a79ee7a644e6c106d]

        cid#1486703 if bUsePlaceholderIndex is true then ePlaceholder != Outliner
        
        so this is Logically dead code
        
        Change-Id: Ieede7331bf2639610ad7a3a983a87263d291c75d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118352
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-04  Noel Grandin  <noelgrandin@gmail.com>  [9f669d2271d5ac64e4cd38ba450fb4ce3dadd5f2]

        move SfxSetItem to own header file
        
        Change-Id: I77ba873ed236091443627e26e6127e89cd8e15bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-04  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [420e4544267545217d54e9acbc9dbf321d58740a]

        Remove unused includes
        
        Change-Id: I243d2998725f09ef533bd06865081d5c415f0d18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118282
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [cd0ab69d4afee0c77884ae17ab9410216695b58b]

        tdf#142464: do not escape '/' is AM/PM when importing DOCX.
        
        See also commit a2e964afc5187fc1e3b38720ec10ad9856b87020, doing the
        same for DOC.
        
        Change-Id: Ib0ddb36de8589f9264fe857b20a6ef2aa2607c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118369
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-04  Julien Nabet  <serval2412@yahoo.fr>  [0151a178d4e26b4546f7b27d569f0d94420caa9d]

        tdf#143173: fix wrong French abbr for Alphabetical Index-Grouped entries
        
        Change-Id: If478fc1127f957e05cdf7bc247881f0c59146896
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118366
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-07-04  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [965639aec1407c25bed1716a1f2c3ee19923ec1a]

        tdf#143175 - Join elements including a delimiter using a standard iterator
        
        Otherwise, the document's keywords will be duplicated since the first
        keyword is written twice. Regression from I19eba57bc6058c317473d0746f06699a09ba2830.
        
        Change-Id: I4c6f840b6e095ca9eaf5ffb53af07280b901e28d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118358
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-04  Eike Rathke  <erack@redhat.com>  [2cc8ec691cc37b07e4f134bf379164f375b8a481]

        Resolves: tdf#125035 Use number formatter for long date in DateFormatter fields
        
        Change-Id: Ib0cd55d9ad4e3abb4839d70c0086063a3f1a90f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118344
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-04  Mike Kaganski  <mike.kaganski@collabora.com>  [79d31d08146afa0861ceb1705262411449e71ec7]

        tdf100961: import fixed date/time field attribute from DOC
        
        Change-Id: Ic67e1cb2fbdb0e7efdeca67ba5cf72ff30856e80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118357
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-03  Eike Rathke  <erack@redhat.com>  [57bd9a60757a5a5d222d6e992e7f38cb3cea4bf6]

        Related: tdf#125035 en_US formatindex="19" DATE_SYSTEM_LONG with D not DD
        
        Otherwise CppunitTest_sw_odfimport testDateFormFormats fails with
        
        - Expected: Wednesday, March 4, 2020
        - Actual  : Wednesday, March 04, 2020
        
        if DateFormatter uses number formatter.
        This is also what
        https://www.localeplanet.com/icu/en-US/index.html
        lists for Date.0 and formatindex="30" has as well.
        
        This makes adapting CppunitTest_svl_qa_cppunit testNumberFormat
        necessary.
        
        Change-Id: I1c8cfd954f34f742b0397b8f922d22eb11ae19f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118361
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-03  Caolán McNamara  <caolanm@redhat.com>  [0f9b36439e33f34ac10e3ec43722e9d5c2c702e0]

        cid#1486702 Uncaught exception
        
        Change-Id: I672c406368f0fd8762349c993cd3febbe5720b2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-03  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [3128fd02c069765a4428022e84a324e991c69521]

        Purge out when safe rtl::math ( isValidArcArg / sin / cos  )
        
        /** If a value is a valid argument for sin(), cos(), tan().
        IEEE 754 specifies that absolute values up to 2^64 (=1.844e19) for the
        radian must be supported by trigonometric functions.  Unfortunately, at
        least on x86 architectures, the FPU doesn't generate an error pattern for
        values >2^64 but produces erroneous results instead and sets only the
        "invalid operation" (IM) flag in the status word :-(  Thus the application
        has to handle it itself.
        */
        
        chart2/source/tools/RelativePositionHelper.cxx
        Function name: RelativePositionHelper::getCenterOfAnchoredObject
        From here: suppose it's related to the orientation of the chart << 2^64
        
        chart2/source/view/main/LabelPositionHelper.cxx
        LabelPositionHelper::LabelPositionHelper
        Suppose: setup label position.
        There won't be angles grater than 360º.
        
        chart2/source/view/main/PlottingPositionHelper.cxx
        PolarPlottingPositionHelper::transformUnitCircleToScene
        Suppose: maybe disc chart orientation?
        Internal angle should be safe.
        
        chart2/source/view/main/ShapeFactory.cxx
        ShapeFactory::getSizeAfterRotation
        Suppose: rotate shape
        Internal angle should be safe.
        
        drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
        Constant 100% safe
        
        sc/source/core/data/documen4.cxx
        bool ScDocument::Solver
        Suppose: the tangent is being used as numerical derivative (Regula falsi algorithm)
        So no impossible angles
        
        scaddins/source/analysis/bessel.cxx
        Filtered it out as bad imput
        
        Change-Id: Ib348cca6ce13263d087b6731f93f58d8a15cc725
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118193
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-07-03  Mike Kaganski  <mike.kaganski@collabora.com>  [e732bbacbf33a3d0c08fb96a18072e5b1ca46691]

        Simplify lcl_dateTimeFromSerial
        
        Change-Id: Ifa237cde581c9b89956db104db9f87a901f84d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118306
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-03  tushar  <tusharrai282@gmail.com>  [7b4169c9d54c6e90e860141a6ced51464cf102d8]

        Implement Interface for Data Providers.
        
        Change-Id: I83ec43511d4fd9a91d7ec34e2281f80b19b4d562
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116870
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

2021-07-03  László Németh  <nemeth@numbertext.org>  [f5ff7a967b09a715c56630aff92cfb636e7c232b]

        tdf#143176 Old Hungarian transliteration: fix AutoCorrect->Apply
        
        and "Apply and Edit Changes".
        
        Transliteration worked only during typing, because
        AutoCorrect->Apply and "Apply and Edit Changes" remove
        right-to-left text direction silently, which resulted
        missing transliteration of text (with Default Paragraph
        Style and right-to-left direction) to Old Hungarian.
        
        Change-Id: I1481d958494828b6dce66f2eeecb44b327c70db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118346
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-03  Caolán McNamara  <caolanm@redhat.com>  [35dd9c4f38dd2019e18f97d8a08ce5bb9b69a4fb]

        ofz#24932 halve limit for fuzzing timeout
        
        Change-Id: Iafbf7e40867ada6918e6e6dc3e1588bb0a6756df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118333
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-03  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [4992780d2bc996c111b333549314d72f6891308d]

        EMF+ tdf#142941 Fixes for SrcRect in DrawImagePoints
        
        The SrcRect could be specified outside of source bitmap.
        In such cases the Destination bitmap should be displayed as shifted
        (eg. if position is negative), and scaled properly.
        Change-Id: Ied6d339703999faaae061802ef6a28e190d5a176
        
        Change-Id: Ia9772ced282684c2c94a261d97d30b53921d6171
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118345
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-03  László Németh  <nemeth@numbertext.org>  [ded2452a52d21131347a0dc2e25c8161f20fcfad]

        tdf#142902 DOCX export: remove personal info of comments and changes
        
        If Options → LibreOffice → Security → Security Options
        and Warnings → Options... → Security Options → Remove personal
        information on saving" is enabled.
        
        Use the same time (Unix epoch) for mandatory time stamps, and
        replace authors with "Author1", "Author2", ... and creator-initials
        with "1", "2", "3" etc., also to avoid of joining adjacent redline
        ranges.
        
        Note: to see the work of the unit test in Linux command line:
        
        (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf142902_remove_personal_info_in_DOCX" SAL_USE_VCLPLUGIN=gen)
        
        Follow-up to commit 12da70f88517bf3c053afe1c504bb70bd27573f2
        "tdf#90401 xmloff: remove personal info of comments and changes".
        
        Change-Id: Ice996f171f5d82d13ce0ea2e4833696af0aab90c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117444
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-03  Eike Rathke  <erack@redhat.com>  [56ae948b08010ed1b61be9857c8c6ae4e97e86b2]

        Related: tdf#125035 Include day of week in formatindex="19" DATE_SYSTEM_LONG
        
        Used programmatically with number formatter's NF_DATE_SYSTEM_LONG
        but quite some locales were lacking the day of week; maybe legacy
        because duplicated formats sometimes were avoided, which nowadays
        are suppressed in the number format dialog. Made the format code a
        copy of formatindex="30" explicit DATE_SYS_NNNNDMMMMYYYY.
        
        Didn't know what to do about lt_LT so kept that as is.
        
        This made it necessary to adapt a dreaded UITest_writer_tests5
        test that checks for listbox content,
        test_date_field_with_custom_format, which depends on actual locale
        data. See comment there.
        
        Change-Id: Ifc26a4a5be6bed3fb8d9cedc1afcba1225751635
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118335
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-03  Justin Luth  <justin_luth@sil.org>  [26af8b14aad463ea7f1fd22ac221269f23145855]

        tdf104239 doc import: re-arrange aPreventUseAsChapterNumbering
        
        It is better to do this more intensive check AFTER
        the "continue" clause - since both those conditions
        need to be true anyway in this section.
        
        Change-Id: I6051832c207fbfd402c00cab4ed1a8ed662c1b12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118341
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-03  Justin Luth  <justin_luth@sil.org>  [87c9940bfcbc230b5ff58dc2b1984589039151f2]

        doc import: halt earlier for non-paragraph styles
        
        related to work being done for tdf#104239.
        
        This should practically be an NonFunctionalChange
        that just avoids some unnecessary processing.
        
        Unit tests prove that these semi-defined styles
        are still necessary for inheritance etc.,
        but they shouldn't need to be used for selecting
        the outline numbering.
        
        The "continue" that I am moving was first added with
        commit d6078b0843186542398905b97c78f29d974a5d30
        Author: Caolán McNamara on Wed Aug 27 09:19:30 2014 +0100
            OutlineStyles can only be Paragraph Styles
        
        which probably just failed some automated tests,
        so that suggests there is plenty of room for improvement here.
        
        Change-Id: I5d4d6ba374f0f271b5248fef3d2d8c0ce62082cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118342
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-07-02  Jan-Marek Glogowski  <glogow@fbihome.de>  [00d0d8f58cefb76bf9a8867228af1d6c9a9a5ad3]

        vcl: drop GenericUnixSalDataType
        
        It's just used for a singke assert and SalData is generally just
        used as a static cast.
        
        Change-Id: I8d74e82e511413d940a3f200f022a9204e588cd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118288
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6bdd426777488e6a776befca0c526e6ae7f33c1]

        tdf#142932: sc: Add UItest
        
        Change-Id: Idecfa40358d13d1bc921ba7250dda56ccf5e0646
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118331
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [357c0e2a4a07aca48a69fbc2616b7002401b3267]

        Move utility code out of test directories
        
        This simplifies iteration over the test files, and avoids relying
        on file URLs being the same (e.g., having no /./ segments).
        
        Change-Id: I227785806e474a3a2dffeb46df21617eae43327e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118329
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [4f8748fc973acdb67790ff048a247717afa9b9c7]

        Revert "uitest: try harder to close the dialog when it fails..."
        
        This reverts commit ff641dc9e4d2aff1d1cbe4425cd9c03a2edc847e.
        
        Reason for revert: This patch is wrong, when close_button is set, the exceptions will be caught here so the test won't fail
        
        Change-Id: Id884abe70ab5602f914742e91bb2ed644c23b041
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118303
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-02  Rafael Lima  <rafael.palma.lima@gmail.com>  [7755b4881f7d76b6c2898fa6b9b4405378eba170]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 86d4cff5887833253bcfe95ecdb1689ef810315c
          - tdf#102523 Improve Advanced Filter help page
            
            This patch embeds the page specialfilter.xhp and 12040201.xhp into the 12040300.xhp file, which is the landing page when the user clicks the Help button in the Advanced Filter dialog.
            
            As a result, the landing page now covers all the features in the dialog and also presents a useful example.
            
            This also updates the .tree file.
            
            Change-Id: I25d31838fa2604851962fdf8200b887255489017
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118191
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-02  Mike Kaganski  <mike.kaganski@collabora.com>  [9258f7009e6ad28dc3fc06a0b66c4cd3d0f658a9]

        Rename LibreOffice Basic test files from .vb to .bas: they are not VBA
        
        Change-Id: I4ff8a8dc855da2c60084318e067d4ec8149d055e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118330
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-07-02  Regina Henschel  <rb.henschel@t-online.de>  [4d2e499994104d0d08f0efab9a51f4561ab42316]

        Change order of parameter to LTRB for better readability
        
        This addresses a comment of Jan-Marek Glogowski on commit
        3262fc5ef3bde5b158909d11ccb008161ea95519.
        
        Change-Id: I0a94ad08d035fd23c0adb5bc53fccdcbc0173e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118324
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [c3c31f4c6e3c658c05f5f6973ef54a03f2d12efe]

        uitest: LICENSE.html can be read-only, skip the 'ok' button
        
        Change-Id: Ib9c7547dac89715a4519a60d733ba03922a01231
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118328
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [79657c9f5392a9c243d3f3c14fa190b04b6806e9]

        tdf#143081: basic_macros: Add unittest
        
        Change-Id: I2d9fa23627f40a2398288b1ee7f5bfd4de4a6131
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118326
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [0b44f53d99d70e0150ee195254d6f36f80cadb56]

        stray unwanted image-position for CheckButton
        
        Change-Id: I31ca60b6b7ee953e002e074efeac9a204f2986f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118323
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [6052731835e9ec6a4c38d3727b5c9008d9a215f4]

        move preview images outside RadioButtons
        
        Change-Id: Ib754db3dddb6b69e8b61b085bbdd3c182c24a703
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118321
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [a38a3ecf62c3ceea497624e483e027ceffad90ab]

        resave with latest glade
        
        Change-Id: I0933861214b8c1f080cf63b86496cca9e5aefd56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118320
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Xisco Fauli  <xiscofauli@libreoffice.org>  [a6178d172ebc47c623b1c1435d4c2e24966fce56]

        tdf#84098 kill copy+paste in basic/qa/basic_coverage
        
        This also fix the problem of basic_coverage tests not showing
        the results when they were failing, since doUnitTest
        returned a Integer
        
        Change-Id: I637cd4cfaa34047bc99bfe6e0930f2945f1a9315
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118234
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [a43dac7964a889c8a0f01a38f0a9d178f4edb44d]

        gtk4: reenable some more working dialogs
        
        Change-Id: Iff3ac86df4b1d028500356ae744e68a0b4712aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118317
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [7ae27fd38e737ef36d8caebd9312c1907d5624a8]

        add use-underline to color picker button
        
        Change-Id: Ice9d2a155c4237b30134bd8faf7931ec980829e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118316
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [a1dd68b71831c76cfab738cdea2347c795c77cb2]

        tidy up impress bullets and numbering dialog
        
        a little but to have less arbitrary numbers in it
        
        Change-Id: Id386616a31c69ebcdea7e97a62a3067bb2fbf60b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [8046edcff0be36c5e1726b3ca53b03934cdc5bab]

        missing use-underline
        
        Change-Id: I560bb7b6942b66c0d486c1d32eac2d2c88e87eb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118314
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [0187e50a09389583609dc3c9bab6a7d1559a8dd4]

        add empty label for GtkMenuButton
        
        Change-Id: Idd15f355e695564964c84b20d7dfc205b1d7dcf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [f7498ffadc50347e95f0c828358726340d3d2b5f]

        these commands present a dialog so add ... to them
        
        Change-Id: Ic25558b1523c26b4b928b9f65c30c7241f549cb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [51f00abe7a17c91476375babaa69f4c7b1883c09]

        no need to allocate return val on heap for GetItemSetForPreview
        
        Change-Id: I261182ec2348df045171c5e1beb33579e2c0c766
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118284
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [2024780f9e169a6c1d167e494d37f46f7640dc97]

        can allocate these SfxItemSet on the stack
        
        Change-Id: I85a749429a3a14aca5c6eaeaa5da37b25eb9f730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118283
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Attila Szűcs  <szucs.attila3@nisz.hu>  [d656191ec308d4280b93c7169372e543a255d108]

        tdf#119952 DOCX import: fix negative page margins
        
        DOCX body text can overlap with header/footer, if top/bottom
        page margin is negative. To support this, convert header/footer
        text content to textbox anchored to header/footer, if needed.
        
        Note: possible improvements:
        
        1) Skip this hack, if the header is small enough to not overlap with
        the body, calculate only the height of the header at the import time.
        
        2) This hack does not fix the case when the top of the header
        is under the top of the body. (A problem in DOC import, too.)
        This could be achieved by repositioning the dummy header to the top,
        and lower the textbox by the same amount. (This would still not
        resolve the extreme situation, when the body start from 0 mm
        (in LibreOffice, header must be at least 1 mm).
        
        3) Import of VertOrientation::BOTTOM property seems to be bad,
        or at least the footer loses this property after a DOCX round-trip,
        resulting bad footer position.
        
        4) after a round-trip, the 1 mm height of the dummy header
        increases to 1 line height. Also the "Autofit height" and
        "Use dynamic spacing" settings are changed, likely related
        to their missing DOCX export.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I8319c93c6c5a980878ee9956c8ab2953da60409e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117842
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [226f7e2ab96fce33a2705ad91ef0d539a6bad7b3]

        tdf#114070 - Only show the last name of the filename without its extension
        
        In the bullets and numbering dialog, don't show the filename including
        its extension in the tooltip of the image.
        
        Change-Id: I2a37f79e8c57d3126e6607f01756771857440faa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118215
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-02  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [a646ba6e5ed042756feac16b91739203793f1742]

        tdf#141334 - Only show the last name of the filename without its extension
        
        In the bullets and numbering dialog under customize, don't show the
        filename including its extension in the context menu of the gallery.
        
        Change-Id: Ia3d4277f5b074be78244f0599883f36385a40c8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118218
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c227acea0b2b5dcdd956bf36d97e0084cb29e351]

        Removed leftover files of commit c2d73de5b5e22e20bc77ee0a27d1c381119c4c79
        
        Change-Id: I021ce03df09c7cb8e87e471b40dfeb4b51068bd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118287
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Michael Stahl  <michael.stahl@allotropia.de>  [ba7a607f79fb0288b9f5a318d84a52936f251b65]

        sw: handle RANGE_IS_SECTION in SwXTextRange::getText()
        
        It always returned null.
        
        This was missing in 6471d88cb8b61741c51499ac579dd16cb5b67ebf
        
        Change-Id: Ibf34c24fdbbbc2f65c6948f58d12f257ccf120ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118286
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-07-02  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [dbdcceb9d77c602ea1161ab0f4e3899071333a92]

        tdf#142235 PPTX export: fix styles with placeholders
        
        inserting icons and alignment.
        
        Regression from commit b6b02e0b4c9d739836e1f61a886ea45b01e6696e
        (tdf#111903 tdf#137152 PPTX export: fix placeholders).
        
        Note: in the unit test document, check fixed vertical position
        of the second text boxes of Slide 2–4.
        
        Change-Id: I3c649db69f94a2e9f49ae7aa11d9cd9d9f6d80d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116828
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-02  Steve Fanning  <stevemfanning@yahoo.co.uk>  [261a28da833c73045080e6d29d8bf87f4542fd12]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5eac8cf1a7d652c4ab41f4a39cc1095198660808
          - Fix minor typos in help descriptions of Calc's text functions.
            
            (a) Added equals sign before examples given for MIDB function, for consistency with other help topics.
            (b) Added statement of default value for Number argument of RIGHT and RIGHTB functions.
            
            Change-Id: I6de1b35ce1e78e4403f957bb32878f40598a7269
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118252
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [169b8d7e0eb0c4674ba59769a8ef54604f653680]

        convert SvSortMode to scoped enum
        
        Change-Id: Ic137e1918f8fa33fbfe6a622be20aa4001172e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118280
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [c2d73de5b5e22e20bc77ee0a27d1c381119c4c79]

        convert AccessibleBrowseBoxObjType to scoped enum
        
        Change-Id: Iaf764c905d080e4decabd853bd3847b34cb79cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118279
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [558dface96fbc5f487b16cfa1bf3c3ea20776331]

        fix potential use-after-free in SwClipboardChangeListener
        
        we think we're seeing this in COOL
        
        Change-Id: I29a287b032158076a99a836d98113d1623ebef99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118277
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e594c5e408593622bb70d54ef03ec5ca09a2d721]

        convert ScPrintSelectionMode to scoped enum
        
        Change-Id: I94d2a4e371ebd8274c5b5c3f01eea70a77780e73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118276
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  Jean-Pierre Ledure  <jp@ledure.be>  [adc0c34bcf5ccf49faf3be54fc505a4ec192fa67]

        ScriptForge - (SF_Exception) new PythonPrint() method
        
        Send from BASIC the arguments of the method to the
        Python shell (APSO) console.
        The same string is added to the ScriptForge debug console.
        
        From PYTHON use simply the builtin print() statement instead.
        
        Change-Id: Iac175b2f7c5773e0369361c3f26bbc33485848db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118225
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-02  Regina Henschel  <rb.henschel@t-online.de>  [a020f2c3993fd8b625cee07ed73949982e719fca]

        tdf#123569 correct position of rotated Writer image
        
        Error was, that the position pFrameFormat->GetHoriOrient().GetPos()
        was treated as left/top of snap rectangle and the associated left/top
        of a logic rectangle was calculated from it based on rotation angle.
        But actually it is already left/top of logic rectangle.
        Nevertheless effectExtent has to be calculated for the rotation.
        
        The fix is based on commit 3262fc5ef3bde5b158909d11ccb008161ea95519.
        A direct backport to LO7.2 is not possible.
        
        Change-Id: I8761b673d1358bb476f1678fd2a104eaec6dcb2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118243
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-07-02  Caolán McNamara  <caolanm@redhat.com>  [125500fed7ee9929ae9f94bcdc113801813dbf73]

        tdf#143149 fix crash if app exits while print progress is running
        
        dismiss the dialog if its parent goes away, but leave the print
        job running
        
        Change-Id: Ic29ee0300a7d9476ad27a2594a555312e30c74f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [29b0fa1e9cf84657abe0722d5d92d4741c9b7974]

        tdf#142923 Deleting comment in Writer leaves visual artifact behind
        
        regression from
            commit 9abedad72c73ad83b66f3f8d261efdc5ce889683
            Date:   Sun Mar 28 10:28:45 2021 +0200
            Drop Window::IsDisposed
        
        Change-Id: Ib804a1b42ea6be97b69184c76e67636f5b082974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118224
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-02  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [e5c80bb69a30dfb0a3daf6061ab127d92f8142d6]

        Purge out setNan from math.cxx
        
        Change-Id: I95f9b37b564bb733f44899a8c6c1ea3c36e35694
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118196
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-02  Miklos Vajna  <vmiklos@collabora.com>  [4d9bff6e3c7bd9361bd1516c4ff266bab07c069f]

        sw: handle FloattableNomargins when replacing compat options
        
        This was added in commit 50a1df360c907d8419ce49f098b6bc87a37a9956
        (n#775899 sw: add FloattableNomargins compat flag, 2012-08-23), it's off
        by default and is on for Word documents.
        
        Change-Id: Idc80737b63081bf366e2b4222d9383e7615961aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118242
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-02  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [557d7a8bdad148501c491a060da74a6214284ca4]

        Purge rtl::math:: ( erf / erfc / expm1  )
        
        Change-Id: Id0e0dce5f9a3bf0bb9ddc73e3aeaa8faf683ad2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118134
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-07-02  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [09218e0d4a0727bbf385f80c538da9e76e89dbc4]

        Fix code style for primitive2dxmldump.cxx
        
        Because the primitive2dxmldump.cxx file has already code style
        similar to desired (76 lines out of 631 need mofication),
        with this commit I enabled clang-format on
        drawinglayer/source/tools/primitive2dxmldump.cxx
        
        It will allow to keep the same code style in all LO components.
        
        Change-Id: I76fbd704ab51fd685bf400d71d24a7abe48049d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118247
        Tested-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-01  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [574dc1e8ff6ea4214fefd91216fca5146a4ff13e]

        EMF+ tdf#142995 tdf#142997 tdf#143076 Add alignment support for DrawString
        
        With this commit, real size of the text is used to make
        proper horizontal alignment. Additionally vertical alignment
        is added and fix for Center alignment was applied
        
        Change-Id: I17d9fd7de7f00f5e69f99c5b09061eb6059be67e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117794
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-07-01  Stanislav Horacek  <stanislav.horacek@gmail.com>  [a1e03b970f49efbfacb7888d31ecd944750a5956]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 01bb1d2c47c2c132adf6c6bef77cf7ec39d84535
          - Czech Hunspell: fix declination of some nouns ending with "-ec"
            
            changes in all three recent commits made by Miroslav Pošta
            
            Change-Id: I29ff4b6147cf8ae000c95fd1072e472bb89edec5
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118245
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [e803875fbb86b24b39fcd9adcf7df40ed255ea8f]

        ofz#34749 don't remove trailing paragraph if something got anchored to it
        
        Change-Id: Ic6eec2f9829c415abd4f2628bc51efbf98f918fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [66fc670dd3d06f58286532be2de0189ec955f476]

        GDB vcl.py: actually return a string in to_string
        
        ... and hopefully make it python2.7 compatible... definitly a
        "brown paperbag" fix... well it did work locally ;-)
        
        I just noticed, because Jenkins spilled some errors from GDB on
        hang with:
        
        Traceback (most recent call last):
          File "/.../instdir/program/libvcllo.so-gdb.py", line 23, in <module>
            module = importlib.import_module('libreoffice.' + mod)
          File "/.../python2.7/importlib/__init__.py", line 37, in import_module
            __import__(name)
          File "/.../solenv/gdb/libreoffice/vcl.py", line 101
            print('STACK', end =", ")
        
        Change-Id: I500e8fea07e9865235e37673dee6374108fefbf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118237
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-01  Stanislav Horacek  <stanislav.horacek@gmail.com>  [c7914a001b750e1b8114f98c8358ca95c3c638c7]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to c608cc40ecc81cdd6ac9000dc890e3f788f2c094
          - Czech Hunspell: fix several verbs of pattern "tisknout"
            
            Change-Id: I6d31f9658e2797ff678e36b887f1e2f03689f1c4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118239
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-07-01  Stanislav Horacek  <stanislav.horacek@gmail.com>  [e6d7112d0f90adf5a5f951537d49b02a6fc548bc]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to bcf9aa0b95ca7770c5bb74801289477214213fb4
          - Czech Hunspell: fix several nouns and adjectives
            
            Change-Id: Ifda579bcc6aec9786355837b42a74ea9b2edc1c4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118235
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-07-01  Miklos Vajna  <vmiklos@collabora.com>  [2d9580e6a65a2699ff61fc1b0e07f62b4946de84]

        tdf#142871 sw HTML export: avoid unwanted inner PNG for images
        
        Regression from commit e76471c5ce725dae9abb6f78b7674c6f77df34f4 (sw
        XHTML / reqif export: export non-PNG graphic shapes directly,
        2021-06-02), reqif wants to have a PNG fallback for non-PNG pixel
        formats, but this is not needed for plain HTML, make this reqif-only.
        
        Change-Id: I0fc1bc13ad4bf808afbe68407e7db802f910c7a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118233
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-01  Miklos Vajna  <vmiklos@collabora.com>  [1e3263a677b61c718d0fd1be15c066b933f7de18]

        XLSX export: handle button form controls
        
        This builds on top of commit 94678a7b9c6b7e577c15adacc885e03551bcf17b
        (XLSX export: improve handling of checkbox (form controls), 2021-06-30),
        so now both checkboxes and buttons are handled during export.
        
        Change-Id: I278b4925414d29399401cc15ab3d944db88ee0c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118219
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-07-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [e190196f255b7d0147d61fd967a2b2a61a932185]

        tdf#143028 DOCX export: fix RangeY regression of preset shapes
        
        Use property name "RangeYMaximum" instead of "RangeXMaximum"
        in GetAdjustmentPointYValue().
        
        Regression from commit 99a459dfdfd9f82ed3506708e131dd52a1a62384
        (tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc.)
        
        Thanks to Regina Henschel for reporting the problem.
        
        Change-Id: I2bdc4be9338d0fe4973a209ee97a4d5880aaac6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118223
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Eike Rathke  <erack@redhat.com>  [d703131d063c41b8baca01830c4c9806f99ab7d2]

        Resolves: tdf#138432 Use locale's CharClass to parse numeric i18n context
        
        Change-Id: I1828f1b6f93228cd517a6a7bd9ae36584bd801a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118226
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-07-01  Attila Szűcs  <szucs.attila3@nisz.hu>  [aa7b1f2ec7da5b94459f808e151085f4d301afd1]

        tdf#143059 sw export: fix assert crash
        
        Incomplete reset in SkiaSalBitmap::ResetAllData() was
        followed by a broken scaling of a dummy image without
        buffer/image data.
        
        SvxLineStyleToolBoxControl::statusChanged(....) creates
        a dummy image via GetBitmapForUISolidLine... deleted its
        image/buffer data immediately ("no line style" dummy
        image preview for the line style popup list).
        
        But the dummy image wasn't ready, it still needed
        postponed scaling processed by the GPU. This information
        wasn't reset by Erase, and without pixel data it couldn't
        be scaled, so this dummy image became a forever "not ready"/
        "waiting to be scaled" image. There are parts in the code
        that require that the image is already scaled... These parts
        check if scalings are ended with the assert(mPixelsSize == mSize).
        
        Note: Use the following method to start LO with Skia in Linux
        
        SAL_USE_VCLPLUGIN=gen SAL_ENABLESKIA=1 ./soffice
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: I5099eb8671a1c5d16668743f26feb47fe99cd70e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118204
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [608f273e9da412e7a2d884f2603756cb4ff4c8af]

        can allocate these SfxItemSet on the stack
        
        Change-Id: Ib2b89613ad3e8f2bcdd51bee10bab3559a64fce4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Noel Grandin  <noel@peralex.com>  [cc948b84b8550ba728b3dfbc40a9785b928910e9]

        exclude some tests for non-default DPI
        
        Change-Id: I579a25040f42fd930a59079f430423806544752b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118222
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [d9648d1cf6c4ec7407ff30cf814be98d089345d1]

        svp: a bit more correct focus handling
        
        Took me a while to realize, that the focus handling after closing
        a dialog was somehow broken. This isn't a really good solution,
        because we can still focus invisble frames, but that is at least
        needed for CppunitTest_sd_tiledrendering and the reason that
        crashes for non-headless VCL plugins.
        
        Change-Id: I272837bd965439c5c0cd9c8bcbc9d51e3018fdf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118130
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-07-01  László Németh  <nemeth@numbertext.org>  [5976b54198d24dcf1d8d1684da4da2cf334abe5d]

        sc: VclPtr, missing dispose (Page Style->Edit...->Header)
        
        Test under Linux:
        
        1) Open Format->Page Style;
        
        2) disable checkbox "Same content on left and right pages";
        
        3) click on the button "Edit..." to open the Header dialog;
        
        4) click on "Ok".
        
        Change-Id: I2ce403a7a37d71f8f6510b6ad00028bc9f7fc5a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118221
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [5021a10f75870e7fa8f34e58512fd7c027debc68]

        sfx2::FileDialogHelper allocate SfxItemSet on stack
        
        and pass around the explicit sub-type, instead of doing static_cast in
        various places
        
        Change-Id: I28ba8fd6f5c9e2a1ffbf5ec091bcf0ebdd1d18b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118210
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c23560ba39fe17c75cafe3d495af743238e4d67]

        BmpCombine::And is dead
        
        ever since
            commit ddd2639a482befb4a3bf1f75a88e66c21a691b67
            Date:   Sat Feb 27 15:50:37 2021 +0200
            drop mask from BitmapEx
        
        Change-Id: I45fae0140067e2bfe5ce1ae2f5014ce733835ef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118220
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [c94d45cd08e2d5db5c007b9a77352f7621f84a09]

        can pass this SfxItemSet around on the stack
        
        Change-Id: Ie2e67ec19cfacdfdd0a6dd85c464cfa326b6500d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118209
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [99a459dfdfd9f82ed3506708e131dd52a1a62384]

        tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc.
        
        Regression from commit 63cd67e5e18f01aca303131e148c80398a181a41
        (tdf#92525 tdf#142398: fix export of simple custom shapes)
        
        Missing property in the shape export property list
        caused an exception. The return value false led to writing
        the shape transformation again, resulting a corrupt DOCX file.
        Optional values have been introduced and if one of the
        required value is unset, writing of the transformation
        happens only once.
        
        Thanks to Regina Henschel for reporting the problem.
        
        Change-Id: Ieae69bb1d2629fdbb91a84325cb100f0ad9d3e12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117763
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [813f6e7c9de6898f42ed28ca8bf7a6fb62a4bb2a]

        ofz#30657 Timeout, ignore duplicate images when fuzzing
        
        Change-Id: I4471379ad60a96f63ff53a441b801d48197b021c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [26e2bb5c09dc8a95ffd69c666de352a8bfd965cb]

        ofz#30762 Timeout
        
        Change-Id: Iffbf89de479d1038f21a45575957ea7212d6939c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118214
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [7a1c8144ac91da056bfdc74b2f757d10b44e6f4e]

        loplugin:unusedenumconstants update results
        
        Change-Id: I6153a67cd041f7dbabb650ad0c0d30427a2e558b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118206
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [35732c84b05e4f6e50349796636beb01f2a09907]

        tdf#121509 DOCX export: fix corrupt shape anchoring in textbox
        
        MSO doesn't support shapes anchored to character in a textbox.
        Convert these shapes by re-anchoring them to the anchor
        point of the textbox (also recalculating their positions in
        simple cases), so Word can now open the exported document.
        
        Change-Id: I28b244975981d69c50e5d4a46249918af089bae5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117163
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [5827376349b01447280ee4391b03a0f149f88ce4]

        Related: ofz#33724 detect earlier if comparison shape has no cshape
        
        Change-Id: I23e2c464ffda5de892ae78a188b4c25b81b61fd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118213
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [57ad52ce8037ce24b4d0a0019e5089c03b90f3c8]

        can flatten this a level
        
        Change-Id: I71742038c2a2ac8e335a404e99f5412430c0ff8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118212
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [567922d076cfaf90c11c32c34e8a4955c9248b9b]

        ofz#33724 compareParaShape will return 0 if input shape has no cshape
        
        so return early in that case and avoid the expensive loop
        
        Change-Id: Ibdde814322c6e9c094c3652c28e0d79887d1f5bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118211
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [65af6fda33bc40670d41055f63e010c763f5b0b1]

        loplugin:unusedmethods
        
        Change-Id: I3ff5333c1e73ca61b0a7339e4b7dcfce211b88e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118207
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Jean-Pierre Ledure  <jp@ledure.be>  [28ee6bc8cf9548a6c24e68e5804077a96605a1f2]

        ScriptForge - Backdoor to alternate Python helper script
        
        While developing a new version of
            ScriptForgeHelper.py
        the dev should be sure to invoke the new version
        instead of the standard version shipped with its
        LO release.
        
        This can be done now by setting
        - in Python a specific ScriptForge class property
            ScriptForge.pythonhelpermodule2 = 'user#QA/ScriptForgeHelper.py'
        - in Basic a specific property of the root class
            _SF_.PythonHelper2 = "QA/ScriptForgeHelper.py"
        both in the test script
        
        Testing a new version of scriptforge.py can be configured
        entirely from the test script by inserting next statements
            import sys
            sys.path.reverse()
            sys.path.append('/home/jean-pierre/.config/libreoffice/4/user/Scripts/python/QA')
            sys.path.reverse()
        
        Change-Id: Iab6db518932e9dde9030b7e5bbe00a50dee31840
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118171
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-07-01  Sarper Akdemir  <sarper.akdemir@collabora.com>  [f63c56f87294d87275b409f6b39b7fcdc0b2be92]

        address style concerns and better practices for pptx footer export
        
        Change-Id: I9954141fb24022487983f2f6ed37e3df2a98c482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118072
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-01  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [5398a6e36489bd68ba31e834833d39fa7de1cbad]

        tdf#127978 - Don't URL encode filename for navigator's tooltip
        
        Change-Id: I70ea7fb739f14c5c60915acc6c66ea241f67524c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118197
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-07-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [25580a3d72f64a3cee04ef330c58caf77873ef45]

        Update documentation for uno executable
        
        After -r parameter was removed with 5a1d51139c580dc64578d36dc1b4a31a4e5e0ef8
        
        Change-Id: I1961f35ea375e7fd7426958275de0809c8fc9e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118087
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-01  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [210dd59742e9e0643325efc0dfb7678e5d79e8c7]

        tdf#123936 Add formatting commits to .git-blame-ignore-revs
        
        git log --oneline  --author Hofer --grep Formatting --pretty=format:"%H" >> .git-blame-ignore-revs
        
        Change-Id: I7fea4396274e926e7866ddb25d68fd068ce345ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118115
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-07-01  Tünde Tóth  <toth.tunde@nisz.hu>  [02809c8b53e225ea45952de66d1b634267c8f28b]

        tdf#139549 add test to commit 2ffdd37067926ddb841c6055205f267b96706945
        
        (tdf#139549 DOCX import: document got modified at import time)
        to check the fixed position of the frame.
        
        Note: to test it under Linux, use SAL_USE_VCLPLUGIN=gen:
        
        $ make CPPUNIT_TEST_NAME=testTdf139549 CppunitTest_sw_ooxmlexport16 SAL_USE_VCLPLUGIN=gen
        
        Change-Id: I13ddfd5b5b4568bc7eb164cbda23f1d99fcab443
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118074
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-07-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d8b07093873e7793b07c5cd10de2ad542d05cdb]

        avoid some dynamic_casts
        
        where we know the object must be of the destination type
        
        Change-Id: Ib5c7d1a55a89d77060e4064d3469f706f2ad7040
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [8c8f66fe54eba8ccb01759dea2fc006930c00044]

        fix indent
        
        Change-Id: I8ee2ac371be458b08993f1e197a2f78986e03545
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Caolán McNamara  <caolanm@redhat.com>  [123a3ccacdb30dce0733212f35dea738bcafb747]

        getParaShape() adds bounds checking we don't need in this case
        
        Change-Id: I02f917169fcae0dc5bdfc55653cd21fe67eac9c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118200
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-07-01  Julien Nabet  <serval2412@yahoo.fr>  [4a0b40f1be9f6773c8ebc5331c257911a76a5cee]

        tdf#143081: fix Basic Replace() function crashes LO
        
        0x00007f19c0aa6e57 in rtl::OUStringBuffer::append(char16_t const*, int) (this=0x7fff100d0748, str=0x6f6f46a u"æ™¦é¥–é¦™Â©", len=-1) at include/rtl/ustrbuf.hxx:659
        0x00007f19c0c3c8a8 in SbRtl_Replace(StarBASIC*, SbxArray&, bool) (rPar=...) at basic/source/runtime/methods.cxx:1321
        
        see bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=173298
        
        Calling xCharClass->toUpper may change words, eg: "Straße" becomes "Strasse"
        so the length of the word increases.
        In brief, we want to use the length of aSrcStr not aExpStr
        
        Change-Id: Ia291d47a2021efc7dd9162ca5cc72b7940fdd71e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118202
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-07-01  Miklos Vajna  <vmiklos@collabora.com>  [f249addd8914ffaa7e94b58419b72b290b739343]

        xmlsecurity: remove last not needed direct pdfium dependency
        
        This module only calls pdfium indirectly via vcl. This was the last
        makefile which had such a not needed pdfium dependency.
        
        Change-Id: I25ff0be285a52480d3ac60344235af520f262c16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118199
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-07-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4f42bcc9dc825cf50a40a00bb992137b6b8906b6]

        Improve preview of theme color sets - add color set name
        
        Change-Id: I1f7b3668ba9dfbab1da283741e99754de2d6be47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118151
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-07-01  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [3964e0854507b2696ae0fbe48a4fb005c779947e]

        Purge out rtl::math::setInf
        
        Change-Id: I71af8273c672a4cbcbfefafffd0003ab266dcce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118132
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [54d7fc9ea9d56ec16ec4f641a3dbf01f64233297]

        svp: add ostream<< for SvpSalFrame
        
        ... and also store the window title.
        
        Change-Id: I20d8b30f6e8e5c48740fe569d9689a117db11e6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118129
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-30  Caolán McNamara  <caolanm@redhat.com>  [ce9e6972148c657994beb74f671e51bec5be6689]

        tdf#70633 unset Alt if detected as AltGr in both KeyInput branches
        
        we are unsetting Alt if the modifier is AltGr in one SalEvent::KeyInput
        case but not in another. If I replicate the unset of Alt if AlrGr in
        the other place then both UTF-16 parts of the codepoint get accepted
        and the described input case works
        
        Change-Id: Ifa8a5afbb1853ef3d5f388fd5e7bd3bbc048e260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118170
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-30  Caolán McNamara  <caolanm@redhat.com>  [86372bf5f62aea48cb3b68d30e81597a0dac9cc2]

        tdf#143113 fix crash in dnd
        
        Change-Id: Ifab741494e4cc6e51ca4cd89b57c3600d80dca44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118163
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-30  Caolán McNamara  <caolanm@redhat.com>  [5e865370530a71eb966d2fbfc2fdfffc34d2e1b9]

        ofz#35504 clamp input values in cgm filter
        
        Change-Id: I96712b8dc8f8eaad3fb8fa6710d0f07fff61b592
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118137
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-30  Luboš Luňák  <l.lunak@collabora.com>  [8ed2142789b3db66c5ab28087040dee7c0ca6341]

        fix a size warning
        
        d7855213ae60d79f converted this incorrectly, the code right above
        may set the size as (0,0), and before the commit the invalid size
        was only negative.
        
        Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-30  Miklos Vajna  <vmiklos@collabora.com>  [94678a7b9c6b7e577c15adacc885e03551bcf17b]

        XLSX export: improve handling of checkbox (form controls)
        
        This builds on top of commit fd238380ae7820f12ac1f7c52d0f7180a93f3ba3
        (tdf#106181 XLSX export: output form controls, 2020-05-13) and adds the
        missing VML version which seems to be mandated by Excel 2019.
        
        It is not perfect (e.g. there is still an unwanted border around the
        checkbox), but the checkbox has a correct position and its label is
        readable, while it was just lost previously.
        
        Change-Id: I08198d068a0eb85061d138719cfc60d73c46398e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118168
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-30  Michael Stahl  <michael.stahl@allotropia.de>  [7cbd6d768d282077053c354254315f3dc89bf254]

        sfx2: try to fix lifecycle of SfxOfficeDispatch
        
        This can be created either from the global SfxApplication, or from a
        SfxViewFrame.
        
        Particularly in the latter case, the SfxDispatcher and SfxBindings
        members are owned by SfxViewFrame, so in case that is destroyed, the
        SfxOfficeDispatch must clear its pointers.
        
        It looks like the member pointers are checked before access already
        everywhere, so just listen at the SfxViewFrame.
        
        Change-Id: If08825734e94dd54e32cb77546684fd583c336ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [738f7a8cb971a884f74766da0cbf7e59ef8b90e7]

        reduce cost of allocating and copying SvxNumRule
        
        by using std::move to avoid copying unnecessarily
        
        Change-Id: I940b57c9a05c8d75b9a16291fc4f05756fdeea12
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118164
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [cf15c4dad74e31a035c0d1ca899dfbef4da90ad2]

        tdf#135316 optimise SwCharFormats::FindFormatByName
        
        reduces load time by 10%
        
        Change-Id: Ic5c90588825592245d09f8ebe03b13e34676496a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d2cbf5d1aba6a2a74b0e6ca99cb27242f9582a94]

        StylePresets: set bacground color for ValueSet
        
        Change-Id: Ifbaab139235dbe2fdcebf278bce2c91c2b744aa6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118150
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [4a68396d3fe055cde57d7122d6f2618b87a81e9e]

        swap text and background colors in colorsets
        
        Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118149
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [a564bb70ad6c19b28c553625f4781655adb80702]

        uitest: combine create_doc_in_start_center methods
        
        Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [95b06d3aa514ce83f82fd538d1731fc6363e4b8a]

        indexing: add indexing export as an export filter for Writer
        
        Change-Id: I26157a8ffeee80b03866569d3d3cec2a34fe377d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118144
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [a876055b6f56e838114cce041d4c49aed43693f9]

        Fix potential (but unlikely) overflow
        
        warning: assuming signed overflow does not occur when assuming
        that (X + c) >= X is always true [-Wstrict-overflow]
                         while( nPos < nLen )
                                ~~~~~^~~~~~
        
        Change-Id: I95e3bb4a131eaf4e82fbc74cc0bea92930b6afe9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118159
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [05992ce5d03aeb2db8d4fc7a68053ebd9a9aa511]

        tdf#135316 cache propertysetinfo in SwXShape
        
        shaves 3% off loaad time
        
        Change-Id: I6541f94553d862787566672d91e2a87902835664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118158
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ba64bba76ca1d23191300d1b5080cc091d432de]

        tdf#135316 make regex object static const
        
        so we only compile it once, shaves 1% off load time
        
        Change-Id: I8e6e20205659582901ffb8d4496ce44906146204
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Tünde Tóth  <toth.tunde@nisz.hu>  [67e2cc17bad3fd7aacb94da47f9024b731434a84]

        tdf#140431 XLSX export: fix double file:// prefix
        
        Regression from commit: fc58d7d65b9683db7b7632137126680b8483f6c5
        (tdf#129969 XLSX export: file URLs need IURI encoding)
        
        Change-Id: I5bfb0ef9ba7fe82cd3f4d0e0b3fdcf8f705cba64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118090
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c34ab8e41610c4bf13b9e6cbe1a3a5f6b3505044]

        exclude more UNO type and crypto leaks
        
        that I don't want to try fixing just yet
        
        Change-Id: I18fc427ef7d2ed652bb7ffb911fc892833cbefd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [3874e092da4acbaa076d885444f26f014fd781b5]

        uitest: guard the remaining create_doc_in_start_center
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I2a6149b318d1fdaa36efe5d65af4c238827eaaf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118154
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [57e8d25a40d7c053fef8ecb452e159264c659604]

        uitest: guard create_doc_in_start_center in sc
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I9392c56e6efccde958f0cdd497376b3939b75be4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118152
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [adf59322c651e8e6740a8d97d963dcf0972bdc54]

        uitest: guard create_doc_in_start_center in sw
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I513c76fe3536ce2d541b3588ce3f23990a0771be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118145
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [f7300b2f07f308118967c797206dbc4a1e9a61a4]

        uitest: guard create_doc_in_start_center in sd
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I314f3e2245bf57538073499f60528a455cba1a91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118138
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-30  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6e8c9047f4bf6194bd1423422bd2dc9f92c50725]

        tdf#132421 - don't URL encode filename for the import ASCII dialog title
        
        Change-Id: Ia2cb7b6b355f640a525c41606da25ba35771499b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118148
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-30  Noel Grandin  <noel@peralex.com>  [ecea9c42d5f1a5e63493fcd92944bd49fb91b338]

        fix failure in JunitTest_unotools_complex
        
        Temp files created from OTempFileService are always opened with StreamMode::SHARE_DENYALL.
        So normally you can't open them twice.
        
        But the JunitTest_unotools_complex unit test used to work because it exploited a pessimisation in OTempFileService,
        where that code would close the file when we read to the end.
        
        Which meant that the unit test could open it again and read it.
        
        However, in
            commit 218f36dd614cf828e949f605faaf6a6fd615da26
            Date:   Sun Jun 20 18:51:12 2021 +0200
            tdf#135316 remove OTempFileService pessimisation
        I removed that pessimisation.
        
        So make the share mode a little more permissive.
        
        Change-Id: I297a5c9c0505816b399fad29414077d03231ec72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118146
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-30  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [8b3ff370ab0fe2e7593a69513c8ff3df35810c4e]

        tdf#139301 tdf#141933 (related) Translate new preset dash names
        
        Change-Id: I9cd7ad0eca1a6fb471a284fb2828a7ad12816337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117024
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-30  Rafael Lima  <rafael.palma.lima@gmail.com>  [1b7d564ee8c75d35dc2b8cb99afcad499c9e6fb7]

        Add Portuguese support to ScriptForge library (l10n)
        
        Change-Id: I04341059becb36467795a2aa1d5c2f573fe1bc6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118092
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-30  Caolán McNamara  <caolanm@redhat.com>  [0aea0cee58fe77a9058217dfdfc3d6a02b29ee2a]

        WinFloatRound has the same content as FRound
        
        Change-Id: Iaf1565d937ded7ab675ab216aef0100dd7af92e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118136
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-30  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [7838efe4b703945ccde963f8506c8c7744e04e6e]

        Purge out rtl::math::setNan
        
        Change-Id: If8794c105e279afd4437517d3e61f2f900eb6490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118123
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-30  Tor Lillqvist  <tml@collabora.com>  [e9dc82b761a71369c4c49ae6d5fd8892f999c77a]

        Avoid accumulating a huge number of Trace Events before calling the callback
        
        Don't use only the five second timer to flush the buffer. Set a limit
        on the number of accumulated events, too.
        
        Change-Id: I075028ce653d89cf099d91ce0d4d97c1361a3bb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118089
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-30  Miklos Vajna  <vmiklos@collabora.com>  [dbbd4f356487d7d4f68cddd5a06a71f236d358ed]

        sw: rework to avoid DECLARE_SW_IMPORT_TEST() in CppunitTest_sw_txtimport
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: Ic272bbecada260d22fa30e6e39a92be3d503d403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118133
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-29  BaiXiaochun  <bai.xiaochun.mofan@protonmail.com>  [9c15dea0b2192d231b65175291a7655122c2e24c]

        Simplify expresion
        
        Reduce operation count by space / speed tradeoff.
        This expression is widely used in LO.
        Then needs to be fast.
        
        Change-Id: Ic88cf15d451ec95a8ad6da88cd9f601cf2876871
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117954
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-06-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [a40334ef4deb03c207b7f959a0a9c93ef3e5c459]

        Extend and fix Scheduler GDB printer
        
        Adds a pretty printer for the whole Scheduler context and fixes an
        off-by-one error when dumping the ImplSchedulerData singly-linked
        list.
        
        Change-Id: I94129fc164986b379f33854651ff6df766eff97f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118075
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff641dc9e4d2aff1d1cbe4425cd9c03a2edc847e]

        uitest: try harder to close the dialog when it fails...
        
        ... and close_button is None.
        
        Change-Id: I01318fd3eff5c9d8775443529ad1a7b18d537968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118117
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [b58fe9414f6303ed55f4c82bd697bd2ca35347d7]

        uitest: simplify code with execute_dialog_through_action
        
        Change-Id: I84cee48c7f7b450e00fed4f70b6c0c41e03dea9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118116
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [4809d28e6db709008b9cd6bd45bc3a0ad6a43a59]

        gtk4: add some more known working dialogs
        
        Change-Id: Ie6794832ac1c836b25761240dc4e563d896c36f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118128
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Stephan Bergmann  <sbergman@redhat.com>  [457d53b1d409f97545a9d6492efa5119de92293c]

        Drop old MSVC workaround
        
        Change-Id: Ifbbbad0bf837533d36fdeddcb0184baa5b789ca3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118118
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-29  Stephan Bergmann  <sbergman@redhat.com>  [310a1931c1087f94b4b8a8f1964189e020275286]

        Fix JavaVirtualMachine::dispose
        
        ...which must call derived-from JavaVirtualMachine_Impl::dispose (explicitly,
        when overriding it), but which got lost with
        951a9342631129832e647bd8a303a959308bad65 "use single-use attribute for
        JavaVirtualMachine"
        
        Change-Id: I0ca581ae10400f430c24a04b056afbb45a5c1445
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-29  Andrea Gelmini  <andrea.gelmini@gelma.net>  [427e3180589574a495df5a3677aedf7da97e11f9]

        Fix typos
        
        Change-Id: Ic943746614b894690768d0d6109123c1af819c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118081
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [7ffa58e3ab68c34d18f62ff29419a160f4e4c397]

        gtk[3|4] add a catch-all AnyInput for under X too
        
        which is needed for gtk4, enable it for gtk3 as well, if that turns
        out to be a problem for some reason then that's easily fixed
        
        Change-Id: Ie3a1875d7930f4db4ff03d085bae07f1646f6e36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118127
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [0f340ed4e814b445dbdd37b154015585769df589]

        gtk[3|4] AnyInput wasn't doing anything useful under wayland
        
        which is going to be the case for all backends under gtk4
        
        at least detect if there is evidence that the VCL_INPUT_ANY
        condition is true to curtail the idle spellchecking (etc)
        writer loop in favor of user interaction
        
        Change-Id: Id1cefd720a921e3a0d1d403769c544c15c6360e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118126
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [cc94c93bf2cf64ecbef835b1410ffc1a2bf40353]

        gtk3: match VCL_INPUT_ANY with or without TIMER if there's pending gdk events
        
        Change-Id: Ia3ab9993569a5eac8a1811c0187c4256dce72d50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118125
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a46a847d4298806d4e91e4665c3c1907c09a17c7]

        tdf#142589 Impress UI: fix Start button of Custom Slide Shows
        
        This button started the selected custom slide show only
        by changing the (already) selected custom slide show, and
        enabling the checkbox "Use custom slide show". Otherwise it
        started always the full show.
        
        Remove the redundant checkbox "Use custom slide show" of the
        dialog window "Custom Slide Shows" (Slide Show->Custom Slide Show...)
        to avoid inconsistent behavior of the Start button (which could
        start the full show instead of the selected custom slide show).
        
        Now Start button of the dialog starts the selected custom slide
        show only once, i.e. it doesn't modify the global slide show
        settings for all the next slide shows (that is already handled
        by Slide Show->Slide Show Settings->Range->"Custom slide show:"
        and Slide Show->Slide Show Settings->Range->"All slides").
        
        Change-Id: I6e97a69c546870199d5a45d9a6ad102e30d820c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117876
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [beaf6001c0d020f525bb99dae4a0f6cdd16b4c99]

        constructing SaveOptions just to read default version
        
        can be a little expensive sometimes, since it loads a bunch of other
        stuff at the same time.
        So create a custom method that just loads the version
        
        Change-Id: Ic480d95c4d64c68e57faf1b52f1d102141b7e246
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118047
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [67b157e994d9bef01f6117b53fc29e1fee538715]

        tdf#143088 multiple Application::EventListeners is expensive
        
        use a Window level Listener and a WindowChild Listener instead
        
        An example for the need to listener to children is the calc conditional
        formatting dialog where clicking on any subentry of an collapsed entry
        is expected to expand that entry
        
        Change-Id: Ifead2fc1b75457d3ad314fdf15d343395afae6d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118086
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [351b6b9c1fddc3cebc98036aebeeffd4dd44cc3c]

        tdf#136435 extended tips for outline folding
        
        Change-Id: I29ec108c4227a921b36f4de023a9a4e8d3ed3a99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117904
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-06-29  Eike Rathke  <erack@redhat.com>  [3d7007ef8784e92bb56a91c40e7bdff812251677]

        maShowPageBreaksTimer.Stop() in ScGridWindow::dispose(), tdf#124983 follow-up
        
        Stop this timer when the ScGridWindow is to be deleted, together
        with the underlying document. See
        https://gerrit.libreoffice.org/c/core/+/90101
        comments from Miklos Vajna on 2021-06-29 14:08/14:10 CEST
        
        Change-Id: Ia1f39c406d391abd78a57c1d92616dbff788ec63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118112
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-29  Stephan Bergmann  <sbergman@redhat.com>  [e529461bcb126e0975ffa3f86e1fd5a630551de2]

        Enable JVM also on macOS ARM64
        
        My previous attempts of `make check` and running a --with-java build against
        various Azul JDK 13--17 have always crashed with SIGBUS that smelled like our
        uses of pthread_jit_write_protect_np in
        bridges/source/cpp_uno/shared/vtablefactory.cxx colided with corresponding calls
        in the in-process JVM, randomly(?) causing some attempts of running generated
        code to SIGBUS.  (See the email thread starting at
        <https://lists.freedesktop.org/archives/libreoffice/2020-December/086490.html>
        "Using Java on macOS ARM64".)
        
        But at least with the recent
        <https://cdn.azul.com/zulu/bin/zulu17.0.63-ea-jdk17.0.0-ea.27-macosx_aarch64.zip>
        on macOS 11.4, this appears to work reliably now:  Multiple `make check
        screenshot` as well as some manual use of LibreOffice did not run into any such
        issues.
        
        Change-Id: I2b1327e7e877ed71420c174c1d88e68a96b3532e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118114
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-29  Tor Lillqvist  <tml@collabora.com>  [09e89e7282a032c4cb944a66c0ddf199b9aa4a0b]

        Enable flushing accumulated Trace Events when their number reaches a limit
        
        Change-Id: I99ecf56b0faa5c444dbe9e22b8cce035f240c35c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118088
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-29  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [33680cc4dc3a50081fc0b82fb0abf03c9744b310]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dbd32aead45fef14e81d3b1ca0a1973f1a856607
          - Minor
            
            Change-Id: I8784fd6f43f5568db739e50a421bfff8184fd5d3
            
2021-06-29  Miklos Vajna  <vmiklos@collabora.com>  [1b7fc505bdd6c3c44986221c6bbe33af1a0e3ac6]

        sc: don't require ctrl-click when clicking on internal links of shapes
        
        Excel doesn't require such additional actions, and Writer doesn't
        require ctrl-click for internal links (e.g. cross-references), either.
        
        Also suppress the tooltip hinting ctrl-click in this case.
        
        Change-Id: If2fbec533f5c2a57268a22cf96464e724922ff7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118085
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [d0bdc56da1833bc07992ddc87eb1fcffb926cee9]

        Related: tdf#143088 listen to DefaultWindow for Settings changed
        
        having multiple Application::EventListener are expensive while a
        Window::EventListener is cheap and in this document there are thousands
        of comments so having thousands of EventListeners is problematic.
        
        under gtk with start center open use gnome-tweaks to toggle in/out of a
        dark theme and the branding logo should continue to switch dark/light
        variants
        
        Change-Id: I64fd12e4bcb8e4fd131effe94e6882e54cfcaf19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118083
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [de15196a5ccc49b4daa90e3bd25b3cac441f5d2a]

        Related: tdf#143088 return early on notification from frozen editengine
        
        processing EE_NOTIFY_PROCESSNOTIFICATIONS from an EditEngine with an
        UpdateMode mode of false will just to on to cause
        AccessibleTextHelper_Impl::GetTextForwarder to throw an exception as a
        Frozen EditEngine is considered Invalid so return early instead
        
        Change-Id: I86f9647b7bf839cf3c7cf2f029be8c7c5aeef1f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118079
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [cb0991e32987108d900ec7e8fcd4ce477ebc9fb4]

        remove pimpl from SwXTextCursor
        
        this class is only included from a small part of writer, so no real need
        for a pimpl pattern, and the alloc shows up on my perf profile, so
        reduce one of the allocs here
        
        Change-Id: I2ecb1bff5c06167fce8f53ffea18cb30d8df2dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118046
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-29  Radhey Parekh  <radhey.parekh@gmail.com>  [872c54f99c7cd35697ea811b59bbcdc4b31f38d0]

        tdf#124176 Use pragma once instead of include guards
        
        Change-Id: I442b8aeac321ff2f34fc83037aff2b48197f44de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117905
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Tested-by: Jenkins

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [5b8a13486d3809066e663549879c209992d5479d]

        uitest: combine execute_dialog_through_command methods
        
        Change-Id: Iaa03d37a9ac3862b8cb08a81e37a611632433880
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118077
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Johnny_M  <klasse@partyheld.de>  [d0172f785a5973dbe5ea585eabfa7a4671b38775]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 24c249c356c67c7471476ec1bb54a68d87b196d2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I2f6b41bc9dc93a27c8e5552a51bdacb1030a2e96
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117936
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-29  Miklos Vajna  <vmiklos@collabora.com>  [f31955add694f52add574b94ab181be3d388e832]

        filter: remove rReserved1 completely in WrapOle1InOle2()
        
        The comment above already states that this the Reserved1 field in the
        spec, so there is no value in the additional reference.
        
        Change-Id: I48bdda04ab536461a1eb5818df6a610f41d5fe95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118078
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [8fe4a2cb1ad3b4819e069179cc11430c5127613c]

        uitest: guard remaining execute_dialog_through_command
        
        Mostly done with a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: Ib8e7c5f5e2c9b8a7756fe533ea4f30349dd68761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118076
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [8b961addb7887a8b8dc8dbc6758c3dc7c1068ac4]

        uitest: guard execute_dialog_through_command in sw
        
        Mostly done with a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I9def7e8fd8256c3131ca2904f78976b9cd59aa96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118037
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [279ab35ad07a958b5b8d7d593b9817e7365b9bb5]

        uitest: guard execute_dialog_through_command in sc
        
        Mostly done with a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: Id49eb66ba2827a6e2d0a737e48726a1d1c49c814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118029
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [beeb10a097cdb44af931b92d2849a7e4d09414c0]

        uitest: guard execute_dialog_through_command in sd
        
        Mostly done with a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I162dcf802474a27580cfbe9349d1a48d3a111c9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117999
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [2a1725fbc248ccaccbe754b5f62a02f99e077290]

        ofz#35504 promote to double earlier
        
        Change-Id: I20906d61f411bba5b37f7248ba9b544afa27a0a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118051
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Caolán McNamara  <caolanm@redhat.com>  [e82527d1fcee6bfb47b4e2a7bc51a7d097f662b0]

        gdk_events_pending->gdk_display_has_pending
        
        the latter at least still exists, if mostly private, in GTK4
        
        Change-Id: I0c008b505823d3f2b1ea332a9602399b77fd29c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118050
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-29  Stephan Bergmann  <sbergman@redhat.com>  [4cc1b2b55bf4efd21530632eccd9c01267a71218]

        Missing acquire in UNO constructor function
        
        ...that was lost in 951a9342631129832e647bd8a303a959308bad65 "use single-use
        attribute for JavaVirtualMachine".  (Noticed with `SDK_HOME=.../instdir/sdk
        URE_HOME=.../instdir make -f Makefile.pln test-javatest` in ure/source/uretest
        failing at
        
        [...]
        > warn:legacy.osl:1255514:1255514:cppuhelper/source/implbase.cxx:84: OSL_ASSERT: rBHelper.bDisposed
        > =================================================================
        > ==1255514==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000001740 at pc 0x7f14cbe32a2a bp 0x7fff46636a70 sp 0x7fff46636a68
        > READ of size 8 at 0x610000001740 thread T0
        >  #0 in com::sun::star::uno::cpp_release(void*) at include/com/sun/star/uno/genfunc.hxx:52:43
        >  #1 in cppu::_release(void*, void (*)(void*)) at cppu/source/uno/prim.hxx:85:13
        >  #2 in cppu::_destructAny(_uno_Any*, void (*)(void*)) at cppu/source/uno/destr.hxx:129:9
        >  #3 in uno_any_destruct at cppu/source/uno/any.cxx:131:5
        >  #4 in com::sun::star::uno::Any::~Any() at include/com/sun/star/uno/Any.hxx:115:5
        >  #5 in cppu::(anonymous namespace)::ComponentContext::ContextEntry::~ContextEntry() at cppuhelper/source/component_context.cxx:131:12
        >  #6 in std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>::~pair() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_iterator.h:2368:12
        >  #7 in void std::destroy_at<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >(std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15
        >  #8 in void std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::destroy<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >(std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> >&, std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:533:4
        >  #9 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable_policy.h:1932:7
        >  #10 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable_policy.h:1954:4
        >  #11 in std::_Hashtable<rtl::OUString, std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >, std::__detail::_Select1st, std::equal_to<rtl::OUString>, std::hash<rtl::OUString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable.h:2332:13
        >  #12 in std::__cxx1998::unordered_map<rtl::OUString, cppu::(anonymous namespace)::ComponentContext::ContextEntry, std::hash<rtl::OUString>, std::equal_to<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> > >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/unordered_map.h:791:14
        >  #13 in std::__debug::unordered_map<rtl::OUString, cppu::(anonymous namespace)::ComponentContext::ContextEntry, std::hash<rtl::OUString>, std::equal_to<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> > >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/debug/unordered_map:223:9
        >  #14 in cppu::(anonymous namespace)::ComponentContext::disposing() at cppuhelper/source/component_context.cxx:444:11
        >  #15 in cppu::WeakComponentImplHelperBase::dispose() at cppuhelper/source/implbase.cxx:104:13
        >  #16 in cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() at include/cppuhelper/compbase.hxx:90:36
        >  #17 in sal_main() at cpputools/source/unoexe/unoexe.cxx:540:16
        >  #18 in main at cpputools/source/unoexe/unoexe.cxx:358:1
        >
        > 0x610000001740 is located 0 bytes inside of 192-byte region [0x610000001740,0x610000001800)
        > freed by thread T0 here:
        >  #0 in free at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:111:3
        >  #1 in rtl_freeMemory at sal/rtl/alloc_global.cxx:51:5
        >  #2 in cppu::WeakComponentImplHelperBase::operator delete(void*) at include/cppuhelper/compbase_ex.hxx:70:11
        >  #3 in stoc_javavm::JavaVirtualMachine::~JavaVirtualMachine() at stoc/source/javavm/javavm.cxx:1122:1
        >  #4 in cppu::OWeakObject::release() at cppuhelper/source/weak.cxx:242:9
        >  #5 in cppu::WeakComponentImplHelperBase::release() at cppuhelper/source/implbase.cxx:86:18
        >  #6 in cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XInitialization, com::sun::star::lang::XServiceInfo, com::sun::star::java::XJavaVM, com::sun::star::java::XJavaThreadRegister_11, com::sun::star::container::XContainerListener>::release() at include/cppuhelper/compbase.hxx:86:36
        >  #7 in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() at include/com/sun/star/uno/Reference.hxx:114:22
        >  #8 in cppuhelper::ServiceManager::Data::Implementation::~Implementation() at cppuhelper/source/servicemanager.hxx:72:16
        >  #9 in void std::destroy_at<cppuhelper::ServiceManager::Data::Implementation>(cppuhelper::ServiceManager::Data::Implementation*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15
        >  #10 in void std::allocator_traits<std::allocator<cppuhelper::ServiceManager::Data::Implementation> >::destroy<cppuhelper::ServiceManager::Data::Implementation>(std::allocator<cppuhelper::ServiceManager::Data::Implementation>&, cppuhelper::ServiceManager::Data::Implementation*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:533:4
        >  #11 in std::_Sp_counted_ptr_inplace<cppuhelper::ServiceManager::Data::Implementation, std::allocator<cppuhelper::ServiceManager::Data::Implementation>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2
        >  #12 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6
        >  #13 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11
        >  #14 in std::__shared_ptr<cppuhelper::ServiceManager::Data::Implementation, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31
        >  #15 in std::shared_ptr<cppuhelper::ServiceManager::Data::Implementation>::~shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr.h:122:11
        >  #16 in (anonymous namespace)::SingletonFactory::~SingletonFactory() at cppuhelper/source/servicemanager.cxx:510:43
        >  #17 in (anonymous namespace)::SingletonFactory::~SingletonFactory() at cppuhelper/source/servicemanager.cxx:510:42
        >  #18 in cppu::OWeakObject::release() at cppuhelper/source/weak.cxx:242:9
        >  #19 in cppu::WeakImplHelper<com::sun::star::lang::XSingleComponentFactory>::release() at include/cppuhelper/implbase.hxx:115:66
        >  #20 in com::sun::star::uno::cpp_release(void*) at include/com/sun/star/uno/genfunc.hxx:52:43
        >  #21 in cppu::_release(void*, void (*)(void*)) at cppu/source/uno/prim.hxx:85:13
        >  #22 in cppu::_destructAny(_uno_Any*, void (*)(void*)) at cppu/source/uno/destr.hxx:129:9
        >  #23 in uno_any_destruct at cppu/source/uno/any.cxx:131:5
        >  #24 in com::sun::star::uno::Any::~Any() at include/com/sun/star/uno/Any.hxx:115:5
        >  #25 in cppu::(anonymous namespace)::ComponentContext::ContextEntry::~ContextEntry() at cppuhelper/source/component_context.cxx:131:12
        >  #26 in std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>::~pair() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_iterator.h:2368:12
        >  #27 in void std::destroy_at<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >(std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15
        >  #28 in void std::allocator_traits<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::destroy<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >(std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> >&, std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:533:4
        >  #29 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::_M_deallocate_node(std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable_policy.h:1932:7
        >  #30 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true> > >::_M_deallocate_nodes(std::__detail::_Hash_node<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, true>*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable_policy.h:1954:4
        >  #31 in std::_Hashtable<rtl::OUString, std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> >, std::__detail::_Select1st, std::equal_to<rtl::OUString>, std::hash<rtl::OUString>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/hashtable.h:2332:13
        >  #32 in std::__cxx1998::unordered_map<rtl::OUString, cppu::(anonymous namespace)::ComponentContext::ContextEntry, std::hash<rtl::OUString>, std::equal_to<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> > >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/unordered_map.h:791:14
        >  #33 in std::__debug::unordered_map<rtl::OUString, cppu::(anonymous namespace)::ComponentContext::ContextEntry, std::hash<rtl::OUString>, std::equal_to<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, cppu::(anonymous namespace)::ComponentContext::ContextEntry> > >::clear() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/debug/unordered_map:223:9
        >  #34 in cppu::(anonymous namespace)::ComponentContext::disposing() at cppuhelper/source/component_context.cxx:444:11
        >  #35 in cppu::WeakComponentImplHelperBase::dispose() at cppuhelper/source/implbase.cxx:104:13
        >  #36 in cppu::PartialWeakComponentImplHelper<com::sun::star::uno::XComponentContext, com::sun::star::container::XNameContainer>::dispose() at include/cppuhelper/compbase.hxx:90:36
        >  #37 in sal_main() at cpputools/source/unoexe/unoexe.cxx:540:16
        >  #38 in main at cpputools/source/unoexe/unoexe.cxx:358:1
        
        when presumably removing first
        /singletons/com.sun.star.java.theJavaVirtualMachine/service and then
        /singletons/com.sun.star.java.theJavaVirtualMachine from
        ComponentContext::m_map.)
        
        Change-Id: If1563e463becb4d22b754e173ebcb60386e1d828
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118049
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-29  Stephan Bergmann  <sbergman@redhat.com>  [f52fe2eb855d1233bacb97baf192a3c07fc1822e]

        Revert bogus drop of "rtl::" prefix in external code
        
        partially reverts 6f50961e69406a17d6ec998956a6b33208b1001b "remove more
        rtl::OUString and OString prefixes"
        
        Change-Id: Ic97a6029577533e539e99d64ba73a74e3246f03b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118048
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [97123add76b743013fc5c222387feb4b9c13daf2]

        tdf#135316 share themePtr and ShapeFilterBase across all shapes
        
        .. in a document.
        
        Shavves 20% off my load time.
        
        Change-Id: I8101b4d229485ebdef0c1f72f856e7cda43559d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118045
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-29  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [19fa853ce12136b5c14e0c5a0aa906c296b75388]

        tdf#121715 XLSX: support custom first page header/footer
        
        Add XLSX import/export support for a different header or
        footer (activated separately) on the first page.
        Print preview is also extended to support this.
        
        Note: only ODS export is supported, yet. Follow-up commits
        are going to add ODS import and UI support.
        
        Change-Id: Icd3a40131bdbcd5d5a42f98c86a71345a5745051
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116842
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [3d55149dcf19cffefcc19c16a3abbe8851453c5e]

        tdf#142913 PPTX: slideshow setting “Start from” not imported
        
        Note: see Slide Show->Slide Show Settings...->Range->From:
        on the UI, or press Shift-F5 after loading the unit test
        document sd/qa/unit/data/pptx/tdf142913.pptx.
        
        Change-Id: I2e10a4353c26600bf405475cb89990413c81dc1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117705
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [a63679f30a2c455fe0a6471e76a0ec8e3aecd0ea]

        remove try/catch in ShapeContextHandler constructor
        
        if we don't set mxShapeFilterBase here, we will just trigger a SEGV
        later on, rather see the error at the original site
        
        ever since
            commit a68e07b994a02ced1ee447350340d9fe25638bd3
            Date:   Wed Mar 5 17:52:58 2008 +0000
            INTEGRATION: CWS xmlfilter03_DEV300 (1.2.4); FILE MERGED
        
        Change-Id: Iacb7c757d4c9526df076e0903d4539f12f4ce968
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118043
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c3c8a7dbc4ce10156fca530a546babb0b478edaa]

        use std::optional in OTempFileService
        
        since we are always needing this, no need to allocate it separately
        
        Change-Id: Ic81aa485807dd1705fd0af2065044b4169c9cf5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118044
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-29  László Németh  <nemeth@numbertext.org>  [ad16387653f8e0d310a5eb44bce9fa8df27253c8]

        tdf#142698 sw: fix reject of deleted images anchored to-char
        
        Strikethrough of deleted images wasn't removed by reject
        of the tracked deletion, if the image anchored to character
        wasn't in same text line as the deleted text.
        
        Follow-up to commit 1610eeef6f2312616fe5d3535475f27f7896bef8
        "tdf#142196 sw: crossing out images anchored to character".
        
        Change-Id: I9c7f742942bec90d4c5c65f1bc40a7923353560b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118030
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [1524b07e690a53d1e5ffb2e334448195e91413f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8d017a90e29ece12e5a71b7e0242b5f926575cb5
          - Fix localization in SF_Form, SF_FormControl and SF_UI help pages
            
            Change-Id: I7306fbfdabf3df84028aadacb90d0502d48f5c56
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117863
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-06-29  Miklos Vajna  <vmiklos@collabora.com>  [88f003e1978c4c08c082d12e7856ac4a08710c34]

        filter: avoid unnecessary string copy
        
        Change-Id: Ie3083bfed3827b66c85946c060149531293bb813
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118033
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-29  homeboy445  <akshitsan13@gmail.com>  [df3ed584b025b8a87a8a3042a04ac8c12ebe4f26]

        Added a UI dialog box for running the VCL backend tests
        
        The UI dialog box will allow the user to run the VCL graphics tests
        and will allow them to view the results as well.
        
        Change-Id: Ice289444ff425496a3e400a4c2bc06c307168c62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117384
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-29  Mike Kaganski  <mike.kaganski@collabora.com>  [7c95c16deba975b0b282ccea1fbfcfadd7aa28b3]

        tdf#143107 related: ensure correct order of which ids
        
        ... discovered after 8aaa28ed43978a9a4a20d62368410a57ec05c23f
        
        Change-Id: I1a14d227414210393c00c395486ede6daa438218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118053
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-29  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [aa5c6d127559912ad60a63fbd972b78fb8f9691b]

        new ODF numbered list parameter loext:num-list-format
        
        Instead of style:num-prefix and style:num-suffix new list format
        is much more flexible for storing list multilevel numberings.
        Now it is possible to have not just prefix/suffix but any random
        separators between levels, arbitrary levels order, etc.
        
        Internal LO format for list format is changed: instead of placeholders
        like %1, %2, etc we right now use %1%, %2%... Reason: for ODT documents,
        having more than 9 levels there is ambiguity in "%10": it is "%1"
        followed by "0" suffix, or "%10"?
        
        Aux changes:
        * removed zero width space hack: since format string is always defined
        this hack is interfering with standard list numbers printing
        (see changes in ooxmlexport14.cxx, ww8export3.cxx tests)
        * changed cross-references values to lists: they are now including full
        list label string: previously this was bit self-contradictory (see
        changes in odfexport.cxx and check_cross_references.py tests)
        
        Change-Id: I9696cc4846375c5f6222539aeaadbca5ae58ce27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117156
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [99ef46fdb2a975e074c66a02328b86edfc05307f]

        tdf#143105 Don't export empty URLs to PDF
        
        They also won't be saved to the ODT if empty.
        
        Change-Id: I7a8480bfc12261b4904981abb75b59752e354b4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118032
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-28  Steve Fanning  <stevemfanning@yahoo.co.uk>  [f79a8f578ab56d138139b0de131a86dd5d773de7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1f77c92e446c0b66656b82ae04862528d425a30e
          - Fix minor typos in help examples for Calc's LEFTB function.
            
            Change-Id: I5d8cdf1898f9b5823acc1e3381bbe3abb06551e3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/118052
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-28  Justin Luth  <justin_luth@sil.org>  [e5ac6caf9efa3d3a8cb82dbc59ef00b193facdc4]

        tdf#104239 doc import: fix chose m_pChosenWW8OutlineStyle carefully
        
        I mis-placed the cancel test.
        In the previous place, that only worked if the FIRST instance
        of the style was bad. My intention was to prevent if ANY
        use of the numbering style could cause problems.
        
        tdf#75748 had the document I had been developing the fix for.
        
        Change-Id: I75286b943b7fca56ea43f79a49d68a351f6d0e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117966
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [4ad110677be8c9b89524a0cbe1690778b3db032e]

        UIObjectUnoObj::executeAction does not need mutable state in UIObjectUnoObj
        
        ...as none of the state (now stored in struct Notifier) needs to outlive the
        invocation of executeAction.  This change makes mReady monotonic, which makes it
        easier to reason about (and allows to substantially shrink the range of the
        mMutex lock in executeAction).
        
        Change-Id: I0a4dd4a286773fd09c469cb7fd625c1444424e98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118031
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1b052ff4ac5f5d29b69a91d4f14742e555f2a03b]

        Fix typos
        
        Change-Id: If73e9183dbf6e53291da0348a1ea112d0c669669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118012
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [3935b85163336ade4d0555a345c7ba2a9b1fc4d7]

        Remove duplicated include
        
        Change-Id: I0b92374a9d476944e88ac8d08c024f17f689d696
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118010
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [a31b7ea9e62f6d44685aff28e1412eb43b796847]

        Add URI handlers for MS Office URI Schemes on Linux/macOS
        
        This was already done for Windows in fdd8686987ca4ee693f5f194c8eb482daa69cfef
        
        Change-Id: I2fa43bf2930e9df9fbeb9169d28700ef4bdbaacc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117726
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-06-28  Heiko Tietze  <tietze.heiko@gmail.com>  [0707380f05d4cce2d17eb74c4b871dcf17d3ac1f]

        Resolves tdf#133265 - State indicator as first item
        
        Since I719f8a97a867addcd6a544567b1173e6da0f7db8 made trouble
        with unit tests this is another approach to make sure
        the document save state is always visible
        
        Change-Id: Ieb171c6f2a8bb038f86fdafac737a4e39963f03d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118022
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [64e8c2adbbe13cf082819229b8014ffb28911b76]

        Test SvpSalYieldMutex like DBG_TESTSOLARMUTEX
        
        Introduce and use DBG_TESTSVPYIELDMUTEX.
        
        Change-Id: I002fa8faf744d69ab00ceeddda4f56b46aec0b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118015
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [efab07a370c52e57c4a4adaed1ab90e232caaf0b]

        loplugin:indentation (macOS)
        
        Change-Id: Ia7b33ee93dbb4d27a2387af6e2dd247b5f0b0788
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118026
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [2cc76ffcbe1f11f3b10a1a86b00f51e5ef179ac3]

        Remove dubious lone mutex lock
        
        ...introduced with 70f89e6b9f89177fc60f9cc9b55a87fdc5c6017f "uitest: move the
        processing of actions into the idle handler", for no apparent reason.  (This
        change will allow to get rid of mMutex as a member of UIObjectUnoObj in a later
        commit.)
        
        Change-Id: I1964eb1c4a1b4f790e689e55d4af8a0390cb4d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118024
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [936298c38b6f7007097700e5862db00da89d0334]

        No need for these function arguments to be captured in UIObjectUnoObj
        
        The lambda that uses them will never outlive the invocation of
        UIObjectUnoObj::executeAction.
        
        Change-Id: Icc5098a99389f7c70b69ca790acb4709f55b4dad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118025
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [3f04160dd2b528e9d34a22c047e5f84282f77565]

        Allow headless make debugrun
        
        I have not the slightest idea, why I added this code in commit
        6cdfe5ebb4f6c06bfa8b0e67e778dd68131c14e3 ("Drop some headless mode
        variants"). This prevents running "make debugrun" headless using
        SAL_USE_VCLPLUGIN=svp. A HEADLESS variable is just referred in
        some make targets, but the environment doesn't affect them.
        So just remove that code.
        
        Change-Id: Icdf76bea6c75c7b14c3f01287ceb0fd4a11cb2d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118019
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [db1e25a0f7c4c912bcdb4ad6a98d13928f522529]

        There appears to be no reason for (DBG_UTIL-only) ~VclPtr to be virtual
        
        ...ever since it was introduced with 3ecb9b4bd7dc70664bbb8d7c957ea8dc5015223f
        "tdf#99352: assert on stray VclPtrs past DeInit"
        
        Change-Id: I4b87a6bacb53f74ff612a4193cee42145ea04fdb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117878
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [7ef1ec18089aa45e8053c0c73ad71aa3f78b9758]

        No need to Stop() a Timer before Start()
        
        Start() resets a timer per default, otherwise check IsActive().
        Also add a debug name to it.
        
        Change-Id: I1588161bb3fead42c3b26282dfa05d149aa94c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118020
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-28  Michael Weghorn  <m.weghorn@posteo.de>  [1c1aadc804f4b34b764002c23dc916530d1c7908]

        wina11y: enum XInterfaceIndex -> enum class XInterfaceType
        
        Convert enum 'XInterfaceIndex' to an
        enum class 'XInterfaceType'.
        
        Also, drop the explicitly assigned but unused numerical
        values (indexes?) and the unused 'XI_NULL' value from the enum.
        
        Change-Id: Ice6d33e6523b3885836f54bc486bbe90de4c3b95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118018
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-06-28  Michael Weghorn  <m.weghorn@posteo.de>  [620223ec2b47133db4faddd1f7cbf0294fb72fa4]

        wina11y: Convert QUERYXINTERFACE macro to template function
        
        Change-Id: Ia4ecab7ada4df83b773505561569cededef35612
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118005
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-06-28  Michael Weghorn  <m.weghorn@posteo.de>  [197d9631b3add45d294f1d7f81cee00a695f36c9]

        wina11y: Use range-based for loop
        
        Use a const reference instead of a pointer for the iteration.
        Drop the extra 'g_CMAccessible_AggMap' entry at the
        end that was only used to indicate the end of the
        array in the iteration previously.
        
        Change-Id: I411e9274d56ce0ed2658dfbe3d03670e485c4b4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118004
        Tested-by: Michael Weghorn <m.weghorn@posteo.de>
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [8a636698795431915ab1f9877a29d6683d3d9f5b]

        uitest: log the active UITEST_TEST_NAME
        
        From the original commit bff02d54960b55e16d5c1220719bb86dc1fdd205
        ("uitests - error if UITEST_TEST_NAME not set to anything
        useful"), it doesn't look like logging the test_name_limit_found
        is needed.
        
        Change-Id: Ibe1e6a5d63a968b06c4c8e8b4979d5b8caf8f54c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118016
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
        Tested-by: Jenkins

2021-06-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [3c6b33a3cf982c78b64a1a72bf9b2e7bd07495c3]

        Fix uninitialised conditional jump
        
        Since we just handle one specific case, just initialize the
        variable to something different, instead of checking the
        GetFirstRedoInfo result.
        
        From valgrind:
        
        ==10566== Conditional jump or move depends on uninitialised value(s)
        ==10566==    at 0x270E4451: SwDoc::ChgPageDesc(unsigned long, SwPageDesc const&) (docdesc.cxx:431)
        ==10566==    by 0x272E341F: SwFEShell::ChgPageDesc(unsigned long, SwPageDesc const&) (fedesc.cxx:122)
        ...
        
        Change-Id: Ib95f81297959a535a08dc399f72b68c15e621a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118017
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a4098742ae15dd575aa4f02b00d0845db3d5afb]

        Removed executable bits on doc files
        
        Change-Id: Icbf1a9a6fed698345b8faabf3443216240c65069
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118011
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6701329f5b7d9c39fbd00f2f735dcd375992aa8e]

        [API CHANGE] drop ShapeContextHandler service and interface
        
        There is zero chance an extension is using this, because it is so
        intimately tired together with the oox and writerfilter interactions.
        
        I'm removing this so I can expose the ShapeContextHandler and then
        override it's implementation in a more fashion without jumping through
        UNO hoops.
        
        Change-Id: I79ef30247f4642303dfdb92bbf8f6e6226234829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117996
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-28  panoskorovesis  <panoskorovesis@outlook.com>  [0aa7ee7827fc77b5b4c0479402bfbd9a4e5d9e84]

        Add FloatTransparent cppunit test to vcl.
        
        The test draws a transparent, along with a second metafile
        and tests their attributes.
        
        Change-Id: I42b6ff6eec29fecdafc7f634551c894a16b63173
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117694
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-28  panoskorovesis  <panoskorovesis@outlook.com>  [d1eb1e6e487fad489b7c80b68613290da6edfe8a]

        Add EPS cppunit test to vcl.
        
        The test creates an EPS along with a second metafile and
        tests their attributes. mtfxmldump.cxx was edited to support
        EPS.
        
        Change-Id: I43495304aaf191e1a8ad034b96ff59de085a0630
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117702
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [4a6ddaadd75ae21cc251f461327a5f472241a41e]

        open menu down in direction shown by arrow
        
        Change-Id: I23eb6cfcca552b66ed287f09516f3936aa975c88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [456244d885be8f66024cfc91dce56baec97d556d]

        gtk4: protect signal_selected with SolarMutex
        
        Change-Id: Ie296e3f64607bfc00dbedb204f09be97b143892e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118003
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [d647a91ac1a0f8f230dc1cbf141f1ded2cc367f2]

        drop some unneeded ifdefs
        
        Change-Id: I3e323ed5afb2245b28e42992e2ff00a153a8873c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117998
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [5d5b503c62b975af8435a7b6deb648081b561e60]

        gtk4: gtk_grab_add/gtk_grab_remove doesn't exist in gtk4
        
        in the public api anyway, fudge this for now
        
        Change-Id: I44fff4e1dffb390664234ace7337c8ffaff6df90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117997
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [2e138cfb208aba034291896149266b2f67c5654c]

        gtk4: add key-pressed/key-released support
        
        Change-Id: If06e8ce0d351a4761622d3824add29ebe9383210
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117995
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1a9c3cb443a292aec3037dad0350732c414ff35]

        store actual type in ShapeFragmentHandler::mxFilterBase
        
        instead of storing the base-class and then down-casting
        
        Change-Id: I13c600903637216abb4547433f24fc9b84afde8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [15ee306cda425323cb2d58bd88f84686ebc8848c]

        gtk4: implement focus in/out for IMHandler
        
        Change-Id: Id8183b18622a26c0b61c3165b364ecc1d3e3e5bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117994
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [f8f0e4067b09d1d8b5aebc7b28db3b7565606b27]

        gtk4: adapt to GtkCellRendererClass changes
        
        Change-Id: Id5b52f9a3502cecfe693dadea6642dbed3a18aa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117960
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Stephan Bergmann  <sbergman@redhat.com>  [76bf22074a9bb5d6ef177783e5baa41760aa27e9]

        Mark external/harfbuzz/Wunused-but-set-variable.patch as fixed upstream
        
        Change-Id: Iefc8f4f6ff93ec1a11256724b1881689d5eb56d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117992
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-28  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3c7871626186c07dcd2ad874d70ea53aa8ae29aa]

        Tabs to spaces
        
        Change-Id: I1d46cd91082549eebfafe4f7e16d3b6d4e2fe9ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117964
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [bfc1600c6ade6f006eb774bffe7caa9c948e8603]

        loplugin:indentation improve checks for brace alignment
        
        Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [f9514beb9bfed51aee69227797e74504afed31c6]

        use the standard macros to generate custom_cell_renderer_get_type
        
        Change-Id: Ie0c15c0d97616d1b5a6afcdc72cba7247e22d999
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117959
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [879fc58cd4f54e72499fedce64d23bc969f943c0]

        split out customcellrenderer code
        
        Change-Id: Ia2803f6eab14ee7aeb697fb039f4e6dbdefa25e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117958
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Caolán McNamara  <caolanm@redhat.com>  [228cb26a6a1afe668dd17471bedf0ab52f133d5a]

        ofz#35504 Integer-overflow
        
        Change-Id: I7a462b821f286411d759b5259461fcdbf1741859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117955
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-28  Regina Henschel  <rb.henschel@t-online.de>  [3262fc5ef3bde5b158909d11ccb008161ea95519]

        tdf#142304 a.o. Improve wrap margins in docx filters
        
        LO uses the bounding box of the shape in case of type 'Parallel'. Word
        uses in the corresponding wrap 'square' a box based on the full size
        of the shape. That will be very different in some cases, e.g. for an
        arc. And Word exchanges width and height in case of rotation angle in
        [45°;135°[ and [225°; 315°[. To get the same appearance as in Word,
        the wrap margins are suitable expanded on import.
        
        Word puts the additional space needed for fat strokes into effectExtent
        in case of wrap 'inline', so there is no need to add the half strokes
        width in addition. Word determines the area for the shape depending
        on rotation angle. Both are now considered. Total same appearance is
        not possible because it would need negative vertical wrap margins,
        which are currently faulty in LO, see tdf#141880.
        
        Patch solves in addition tdf#142486, tdf#142305
        
        The export to Word would require negative values in effectExtent in
        some cases. They are allowed in OOXML but not supported in Word. My
        idea is to switch to wrap mode 'Tight' if needed. But export of wrap
        has so many bad parts, that it needs separate work and is not
        included here.
        
        Handling of border width for export of own frames is missing.
        
        Unittest changes
        ----------------
        testDmlTextshapeB and TestDmlTextshape in ooxmlexport6.cxx are set to
        current values. Import and Export still have large errors with these
        shapes and correct value from file is unknown. So an exact value is
        pointless. Only the original problem needs to be still fixed, which
        is the case.
        
        testWpsOnly in ooxmlexport10.cxx. I have removed the test for
        LeftMargin equals 0. The test makes no sense, because the original
        file has distL=114300.
        
        testTdf124600 in ooxmlimport2.cxx.
        I have added a tolerance. It would fail with Expected: 2029,
        Actual:2028, likely a rounding problem somewhere.
        
        testTdf124600 in ooxmlimport2.cxx
        Word refers to outer edge of the border for align='left', LO aligns
        at snap rectangle. The different intepretations become visible if a
        thick line is used. LO needs a margin to get the same rendering as in
        Word. So an expected value of 0 is wrong and I have disabled the test
        for now. ToDo: tdf#142798. Get the correct margin and activate the
        test then.
        
        testTextframeGradient in ooxmlexport2.cxx. I didn't find any reference
        for a default value. The test is not reliable, I get both 316 and 318
        as actual value. Handling of shadow in VML shapes is buggy, the values
        for margin and shadow are wrong anyway. Reports are e.g. tdf#142486,
        tdf#142558. For now I have added a tolerance of 2.
        
        testDMLGroupShapeChildPosition in ooxmlexport6.cxx. The accuracy has
        become better. After reload we get the same values as before.
        
        testEffectExtent in ooxmlexport.cxx. tdf#142805. I have disabled the
        test, because the image is not loaded at all, and therefore it makes
        no sense to test a margin of it. And you can only test the sum of
        distL and effectExtent l, because LO has only one property
        'LeftMargin' for it.
        
        testEffectExtentInline in ooxmlexport.cxx. To get the same vertical
        alignment as in Word, it would be necessary to have negative margins,
        but those are not implemented yet. tdf#141880. Currently the patch
        contains a heuristic to detect unchanged objects and write the
        grab-Bag values then.
        
        testEffectExtentLineWidth in ooxmlexport16.cxx. I have changed the
        expected value from 508 to 506. That is still away from the to be
        fixed faulty 561. It is a VML shape and import of connectors in
        VML shapes is faulty.
        
        testRelorientation in ooxmlexport4.cxx. Changed to 8662, the original
        problem is still fixed. I don't know the reason for the difference to
        the values from file.
        
        Change-Id: I28f156637f6ae64975cf2917f0e5cc89e689aff5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115668
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-28  Regényi Balázs  <regenyi.balazs@nisz.hu>  [2ffdd37067926ddb841c6055205f267b96706945]

        tdf#139549 DOCX import: document got modified at import time
        
        Regression of bda05ba17362222b74727872579b65b3fa14e3d8
        "tdf#41466 DOCX import: fix VML v:shape/v:textbox".
        
        Co-authored-by: Tünde Tóth
        
        Change-Id: I8762aa8a710c3a37290e1db854b8cc86db6757b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109436
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-28  Miklos Vajna  <vmiklos@collabora.com>  [67a56b7159158cea076df9aa258a36b02e115ec3]

        sw: prefix members of HTMLTableColumn, HTMLTableContext, SwWriteTableCol ...
        
        ... and SwWriteTableRow
        
        See tdf#94879 for motivation.
        
        Change-Id: I74edd0d6864fd7c2731d904c8bf7cfbd309a226c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117965
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-28  Tibor Nagy  <nagy.tibor2@nisz.hu>  [253bee65bc24d999c3629a4d503d0fa01b355cfc]

        tdf#142646 PPTX import: count repeating slide names
        
        instead of using the default slide name "Slide n".
        
        PPTX slides are named after their titles. Now repeating
        titles got a number instead of using the default slide
        name "Slide n". E.g. "Title", "Title", "Title" will be
        slide names "Title", "Title (2)", Title (3)", and not
        "Title", "Slide 2", "Slide 3".
        
        Follow-up to commit I98511c3c9a59598ea113e7387db5202d7f8a7cd4
        "tdf#103347: PTX import: fix duplicated slide name"
        
        Change-Id: I449d6f7d7599291b3dae7df65ad6ff86a4269fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117317
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-28  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [1421831429056ed770a67feeec12c843f80bb006]

        find-unneeded-includes: introduce --dontstop switch
        
        ...to make it not stop after each error found.
        
        In case there are not many problems to be expected, it is faster to
        check a bunch of files and fix the problematic 5% than re-check
        over and over again the non-problematic ones after each error found.
        
        Change-Id: Iec5a2aa96ac557c0247ae2f06eb710daa75cc19b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117756
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [0171a9e2f0dc9dd2dc85b23871a8f32418b9edf2]

        loplugin:finalclasses in vcl
        
        Change-Id: I0bad93927248e5d8d19a69661a1b243e55791fd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117889
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-28  Justin Luth  <justin_luth@sil.org>  [5f9fb51ba84619c60f304afda76a013a8f3dc14c]

        tdf#104239 doc import: listLevel 9 is body text
        
        MS Word formats only have 9 list levels (0-8),
        and listLevel 9 is used to indicate body-level
        as a way to cancel the inheritance of a listLevel.
        
        LibreOffice however has 10 levels (0-9), so it was treating
        this as 10th level numbering. Nope - it needs to be
        no numbering at all.
        
        Change-Id: I3fd58ba518ba8bc7d15a08cf896fbeed8e6a38c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117921
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-27  Caolán McNamara  <caolanm@redhat.com>  [3618d847a44bb485a3564c600d5005797934b9bb]

        gtk4: restore original parent if there was one
        
        Change-Id: Ia3d8da14f545deace3024823b4cf8453937e3f82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117957
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [eef1a5f3aa0f1b11024aa6760cf92181b9bf0a96]

        uitest: remove duplicated calls to get_component()
        
        after 8298aa62726312eee6f8fbb64a9fc9b12680447f
        < uitest: guard execute_blocking_action >
        
        Change-Id: I954c11c42620660afd48a585f5c59ff2196f4b6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117738
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-27  Caolán McNamara  <caolanm@redhat.com>  [241c37a6ad2a444ddf2eb48385041318d4e7e8ee]

        rename CustomCellRendererSurface to shorter CustomCellRenderer
        
        Change-Id: I8fa2d75d0c24f4e211136c929b8fd6f8466eb311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117956
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-27  Stephan Bergmann  <sbergman@redhat.com>  [5e37a1d89dfaa12690841213bce0cb6d05faf90a]

        Silence UBSan dynamic-type-mismatch for VclPtr member in GObject
        
        ...that wasn't properly initialized (in an --enable-dbgutil build; see also
        <https://gerrit.libreoffice.org/c/core/+/117878> "There appears to be no reason
        for (DBG_UTIL-only) ~VclPtr to be virtual", but even when VclPtr has no vtable,
        it arguably is to properly con- and destruct CustomCellRendererSurface::device).
        
        For example, in Writer clicking on the "Styles" icon in the side bar:
        
        > vcl/unx/gtk3/gtkinst.cxx:15144:10: runtime error: member call on address 0x625001b42668 which does not point to an object of type 'VclPtr<VirtualDevice>'
        > 0x625001b42668: note: object has invalid vptr
        >  50 62 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  10 8a f0 00 30 60 00 00  80 f8 19 02
        >               ^~~~~~~~~~~~~~~~~~~~~~~
        >               invalid vptr
        >  #0 in (anonymous namespace)::ensure_device((anonymous namespace)::CustomCellRendererSurface*, weld::Widget*) at vcl/unx/gtk3/gtkinst.cxx:15144:10
        
        Change-Id: Ic6ab75668e5b3ecca6d1e5743ed1907c8cbdb143
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117915
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-27  Caolán McNamara  <caolanm@redhat.com>  [9d8e88aaa20ad3d184e06cd8d4f875ecdfeda61e]

        cid#1486528 silence Uncaught exception
        
        Change-Id: I03b71a11dda7b818a99525d65cbbc42f40dd2eee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [642791720622618c9b66633c3e1224a4d340b167]

        Immediately schedule Tasks on start per default
        
        While writing a new Task, I was wondering, why it didn't schedule
        immediatly after calling Start(). Turned out Start() wasn't even
        calling Task::StartTimer(...) to trigger / wake up the Scheduler.
        
        So this changes Task's Start() to call StartTimer(0) to immediatly
        trigger the Scheduler at the end of Start(), but Tasks can opt out
        of it, if they aren't ready yet (like Timers).
        
        Change-Id: Ia2fdb45f502866c83f432b045e70bf27ccb61012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117947
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-27  Caolán McNamara  <caolanm@redhat.com>  [de873f01d286d57829d8fb78d1f2748372552d37]

        ofz#30647 skip boring slow path for fuzzing
        
        Change-Id: Ifab4209e4481058046c95efc9efccf337b4badd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117939
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [770f94f4c5bedede8ee70e1f3bc1303dbace62ca]

        Revert "tdf#135316 bypass 'existing style' check when importing"
        
        This reverts commit 066c4054f4a1078602aaab5516590628eaf6a47e.
        
        As mst_ says:
          there isn't just File->Open but also Insert->Text from File...
          in that case the optimisation looks wrong to me
        
        Change-Id: I9d0b4bc748842b8fac7ea4cd58192562f8fd82f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117864
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-27  Julien Nabet  <serval2412@yahoo.fr>  [aa54071b5e6c195e3677aad2d7959a2e901613bd]

        Indicate the file in error in (vcl/UnoGraphicProvider)
        
        Change-Id: I7f379bf189071893d3b9eeb813ea9e570922fee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117946
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-27  Andras Timar  <andras.timar@collabora.com>  [c50bdcfc98776bd35b65c4f04ba7fafde451dbcb]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to bba36281a0d7af91fe65eda9140f811e28d09012
          - Fix Guarani thesaurus
            
            - dos2unix th_gug_PY.dat
            - Add missing count to 'kopia'
            - Fix makefile
            - Remove .idx, which is generated by the build now
            
            Change-Id: I8ca168d0b2710ea31c8641a5d7dd837761674ea5
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/117944
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-06-27  Julien Nabet  <serval2412@yahoo.fr>  [04ad40cb3a7edd0756dc24305bf43fae50a5023f]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 79331fd0ce1c55174534987752df49e3f0f63cc0
          - Remove .idx file, they are generated by the build
            
            Change-Id: I108bbd2149d9f0d1024ed329229bb00bae0af5e6
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/117943
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-06-27  Julien Nabet  <serval2412@yahoo.fr>  [5e24c04f67e7f6cd5ff734f4b2c709566ceb11ac]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 297baa306963dac8706e7e7c25923e18d65b58c7
          - Spanish dictionary: Package missing icon
            
            Change-Id: I7de98cda4094a7a2b219f34744e82260b32c7001
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/117942
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-06-27  Julien Nabet  <serval2412@yahoo.fr>  [5b624c6a855df38f7448f400b2353918126173f8]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 16eb021d2bb008fdef06f69f52df3b5d38c0d028
          - Esperanto dictionary: Package extension's description
            
            Change-Id: Ib080d1ad1ac4f5af6b736fd161a07871f4b1d861
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/117941
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b8b02686c8900ef9cab344480e0b0904e573c936]

        svx: adds a test for SdrRectObj rendering into primitives
        
        This adds a new test that checks how a model with a rectangle
        object is being rendered / transformed into drawinglayer
        primitives.
        
        Change-Id: I81851e122f182ebe5ed8486fdab8d04bb8c9e68a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117886
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f15d50b5ff6f0c8ed1a647a4efa92f5c67077326]

        svx: clean-up, init in constructor, rename master pages variable
        
        - maMaPag to maMasterPages
        - cleanup the constructor variable initialization
        - change degree chart from define to const variable
        
        Change-Id: Idc607b8b386855b90001ed389df2c7849969ee86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117887
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [00a658ff104623d4e7fc984b5fc82d1a7e2607f2]

        ofz#35597 Null-dereference READ
        
        add a check for null getTextBody() return
        
        unfold it a bit while I'm at it
        
        Change-Id: Ib0286048536ad576b520e1adb08fa9b36da9243f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117938
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Johnny_M  <klasse@partyheld.de>  [89251968fde77c6ddf7c95ee61da0c34dfe8ea6f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 108566a12aa32429286de6f6129b63e2d3e27e94
          - tdf#132643 Translate German section IDs
            
            Change-Id: Idbe462483dcff49d7c8d5ff3852632e3e1ec9bc6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117934
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [fa8148c372b2740bd991a757e607442e4f291822]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ee15fc4c682e5f2013dcc6c0eee0d4c173df8624
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ia41a6e287264d5b59d0a95da92e2030df7081ac1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117935
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [e89095ce32ef7c93b0064b6ac717c8822db67ced]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b4b9edbbdce1f88be5ebbaa4a3464f2900d7da42
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id281db6e24d66defdb1a1897982a002b2862a3f2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117933
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [894781f309ebf11786b3f8ef042e470eca74726f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3e0b1dd5ac8cf160686b2f7b4f61d63cefe9fdcd
          - tdf#132643 Translate German section IDs
            
            Change-Id: If05a4230bb2731cce7f412768d31dcd8339aae6f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117932
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [eb2b6f4a3d9477d1e4be1c417d3e8de2ac33946f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to dc2012560f2f32c35dcba288bd7327663d743a26
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6ba60bbca897161bdb4ceb7d92385421a2a94e24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117931
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [c7c8d4939cdee340a3ef9ecfcc96449be3c36faf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e95db54fff98b96bf281a6cffc94edb4e381b448
          - tdf#132643 Translate German section IDs
            
            Change-Id: I49a890ae317345730f14a848e4f2880f7ed4c4f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117930
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [8bba97be7e9327ddc441ae255561f1b3f08a1d0d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0fbedac2ab3856dddcc70b8dbffe5f1838075c5d
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifc6df2e1cefe7349bc24327a2456afd66d065bda
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117929
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [4979fb6ba62f1bca11e4c0a2159d326d11ac8080]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2d06125f8c6b056973081564aea9a0231084c4e0
          - tdf#132643 Translate German section IDs
            
            Change-Id: I02bedcebab5d622d7488e5b06811787f17b48c7c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117928
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [23585ffdfb2416ae39160180289b427c3310c840]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3149f4b939f620610d73ea652282204014f7fdfb
          - tdf#132643 Translate German section IDs
            
            Change-Id: I15d1939c784a1923311d5cce59ff78947e7b7b23
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117927
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Johnny_M  <klasse@partyheld.de>  [59afde29f87a616f771272e9e8295e0170c328ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 85faad16ba20244e502e6ed5b18e5ab5a744891c
          - tdf#132643 Translate German section IDs
            
            Change-Id: If653bbbe3705e939372adc34a1783439418f59b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117926
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-26  Justin Luth  <justin_luth@sil.org>  [f5394ceda7e714b87050d78a0319dc3cfab9ac99]

        tdf#104239 doc import: chose m_pChosenWW8OutlineStyle carefully
        
        Chapter numbering is a horrendous invention of LibreOffice.
        It is not at all a part of MS Formats.
        
        If there is anything that potentially can cause problems
        by choosing one style to be the outline style,
        invalidate it.
        
        We won't totally ignore CN because it has some unique
        properties in LO, and so it is worthwhile trying
        to round-trip it (alwyas LFO 0?) or populate it
        with the expected Heading styles if compatible.
        
        (I tried looping through and re-setting the
        matching styles with the "Outline" numrule first,
        but lots of unit tests prove that doesn't work well.)
        
        I couldn't believe the incredibly good effect this had on
        my torture test example document. Hurray.
        Then again, completely preventing CN at all also
        passed all unit tests, so I added a preventative test earlier.
        
        Change-Id: Iafa0d3606e558a3f17e49c3f1f6cebb7b25de962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117920
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-26  Tor Lillqvist  <tml@collabora.com>  [f877ded8654edc70e466e92de1f9c1dbe5d959de]

        Add ProfileZone to scaleDown() and scaleUp() in BitmapScaleSuperFilter
        
        Change-Id: Ibc98d1e5ba24f98c437468d3f9a469725892e7d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117768
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-26  Arnaud Versini  <arnaud.versini@libreoffice.org>  [3721f4a00e31eb1c08e492106f752db74d3daf7c]

        codemaker : remove useless includes
        
        Change-Id: Idaac78579d7845a1908bc3c02ff917432ca6a7d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117513
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [0f4b14a806b4952da79c7b5b22298e8c8306107c]

        use --disable-xmlhelp for fuzzing
        
        Change-Id: Ieb6abbf05cdd3577c1653fc0078ee2db6e840a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117925
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [532946bc3cc9f21605dfe271db292bf4ab9d6f1d]

        cid#1474269 Untrusted allocation size
        
        Change-Id: I655c86be306a0300e9ec8404040eeb58d0579cb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117916
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [f537dcc2485f6e0d577797a5850f417f180cca3a]

        gtk4: GtkPicture triggers some sort of unexplained vertical expand
        
        an intermediate horizontal GtkBox works to stop the propogation
        
        Change-Id: Idb2a059d5b2e6fa11a105cc8ca06e4f39fd4cd2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117913
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [9fdc25d730782511308eaf2635ea20245dbeb83a]

        resave with latest glade
        
        Change-Id: If4595dd10dcd6eabd15e228cf3c187f9dee4e35b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117912
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Caolán McNamara  <caolanm@redhat.com>  [101ccbd62cd076956754021901486df501aa6054]

        gtk4: reenable calc format page dialog
        
        Change-Id: Ie47c2b6be6e83f01a0c095484b65b1604db0cefe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117911
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [53e972671d9ae392f7a691f8d1d42f0d753eabc4]

        loplugin:finalclasses in toolkit
        
        Change-Id: Ib3db1d6421e6dfba57fe660174e2e4c2af0c6369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117888
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [1720bacfc0efd071ea56757b97a1bf2951f80cee]

        loplugin:finalclasses in accessibility
        
        Change-Id: Idac98767a97a150964c4c5fc736f184057b1a79a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117892
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [15faf18ddca02beb75f89dcd7887d7b8ae2a5e32]

        loplugin:finalclasses in xmloff
        
        Change-Id: I1f1e6c9bad9a2da18701a87ae4e835641a49c107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117890
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [66fec11a62b692cc00cf0c1332d841906abfaea8]

        loplugin:finalclasses in framework
        
        Change-Id: I64e7b65337d283567bb6030a626303de477346cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117891
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-26  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [922e2610a4745c6e33d9e8e808131922a3ea0dc4]

        indexing: add test case for fontworks and footer/header paragraphs
        
        Change-Id: I7b6879d0e038f8c07ae5853d66c43096c25365e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117841
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-26  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e6442b39836f9856aa7b87d1a840158f0cb7d9c4]

        tdf#110993 - Corrected spline calculation
        
        The algorithm in Numerical Recipies in C, 2nd edition in Section 3.3,
        page 166 states a division rather than a multiplication.
        
        Change-Id: I2530c506bc48726539e3de99016892e50d6bb87e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115465
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-26  Justin Luth  <justin_luth@sil.org>  [79bd4eb98535197d3177f262bce94d35badab4f4]

        tdf#104329 doc import pre-emptive unit test: ensure ChapterNumbering
        
        So chapter numbering is a complete scourge for importing numbering,
        but after many unit tests proving my attempted solutions were
        incompletely, I finally found one that worked great.
        
        Unfortunately, I made a major coding blunder, and effectively
        killed chapter numbering unconditionally. But it fixed every
        unit test problem!!
        
        So that pretty much proves that chapter numbering is trash,
        but for LO it still has some important functions,
        so ensure that at least on a clean, nice, LO-authored document
        chapter numbering still round-trips nicely.
        
        Change-Id: I37491ecb638aa79fd7c7621e9cf0ea6282397b83
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117919
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [1db375e06516d0532f01f9585986617aa3079866]

        uitest: introduce load_empty_file
        
        to make sure the documents are closed in inverse order when
        different documents are used in the same test
        
        Change-Id: I97ff33f9f91423d06f4e74bba6fc6a5312b24a17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117914
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-26  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2e781c92bb96d626cf7a75c134f339a8a95d183]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0a0327f63e2825b25c5b3a5e8c34ca97e4911ef4
          - tdf#114525 Bookmarks for Calc conditional formatting
            
            Plus some refactor
            
            Change-Id: Ib2d3740e51be437e806e199b2c3978b12d210792
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117917
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [3e2eee260b45dc69d03ce0c0d4eb6add09824bda]

        More -Werror,-Wunused-but-set-variable when catching SQLWarning
        
        ...similar to f09cb84b274edd2a27697a7dc803a7ee42946de2
        "-Werror,-Wunused-but-set-variable (Clang 13 trunk)", this time with clang-cl 13
        trunk in Windows-only code
        
        Change-Id: I6b0da5aa79de07cf7326ad6cf6649cafff3be6a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117879
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [f54cba63809c511106f291e66019ebe57eafdfe0]

        Silence -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        ...during build of ExternalProject_harfbuzz:
        
        > In file included from hb-ot-shape-complex-myanmar.cc:136:
        > hb-ot-shape-complex-myanmar-machine.rl(108,36): error: variable 'act' set but not used [-Werror,-Wunused-but-set-variable]
        >   unsigned int p, pe, eof, ts, te, act HB_UNUSED;
        >                                    ^
        
        Change-Id: Ie75a5cfa16c29c02e1b97380ebd63e7d789926f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117850
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [408be00b15ec44c9750450fc4dba70120dd0e978]

        add no max-length property in GtkSpinButton rule
        
        Change-Id: I49ef02102620d6f455758a136d980b2c39b076df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117910
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [524e2103b639831eb4b27102d4ddff3a568a1b21]

        ofz#30930 each picture triggers accumulating codesets
        
        seems to make more sense on EndPicture to return to the pre-StartPicture
        state
        
        Change-Id: I2ac2a5585f8acd5d817d083bccfd6551fb773342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117902
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [c38d0d501f5eca648bdf0fd2914b57e06f505f7e]

        new doesn't return null on failure
        
        Change-Id: I9d77274f41fe66251eeb63a8f17abb331044cd27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117903
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [bbddb67a59655660ea028bcf1ca23c0f75a29779]

        remove max-length from GtkSpinButton .ui
        
        Change-Id: Ifee61d19ca017205dd4d21de14465eda9773a750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117909
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [80b055683bd8381f78214e2310f2a703ae7638ff]

        remove stray max-length from GtkSpinButton
        
        since...
        
        commit cb553bdba77c80f323dbed1874874cf2465abd83
        Date:   Sun Mar 31 14:52:34 2013 -0300
        
            Convert Calc sheet page style to Widget UI
        
        Change-Id: Ib1efd5205f68b4db79dab2e889ee24a5f3e54028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117908
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [9e6a7c043d2b19ffc870ab283ac29850447a9cd2]

        -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        ...since 362a21d3a129b90149f6ef645c127f5e86e0ba61 "Use explicit function names
        for fooA/fooW WinAPI; prefer fooW"
        
        Change-Id: I391ae19b01625602231fbd890ee79073367cb449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117834
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [3c5ac66e21bc3b0efffe44743fbb5289da85a4f6]

        -Werror,-Wunused-but-set-parameter (clang-cl 13 trunk)
        
        ...ever since a934115b3ea90d7883681a6ca8922a4b859be36f "Initial revision"
        
        Change-Id: I8935da3ee1c78fcbe5e4858ab009ef4a387b594d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117884
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [b0eb7f3e7010539aad7c0d8496dfc539c87ed859]

        gtk4: reenable calc format cells dialog
        
        Change-Id: I512339745cb8f0e34068c38b88f1f53953ed8f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117907
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [7be06a4dce699d8216b5978155ab3e575dda0367]

        gtk3: gtk_menu_attach_to_widget to the final pWidget
        
        probably doesn't make a difference in practice
        
        Change-Id: I3a015a1585aa2a7d100acd8e6edbfa30d4549ffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117883
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [7d5346eb09a9e4acc72c646800e77f363fe10e2f]

        -Werror,-Wunused-but-set-parameter (clang-cl 13 trunk)
        
        ...revealing that these places apparently wanted to assign to *pClassID rather
        than pClassID ever since their introduction with
        b718f390bf3dcc85dc97b2ef7483d93bbe3968ec "INTEGRATION: CWS desktintgr01" and
        9b1b1b00818d177ed32f5a3d0e0d1f41b40de926 "INTEGRATION: CWS desktintgr02"
        
        Change-Id: I672684739fd2722c5e804f47790884174c576369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117840
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [c1abdd5ad801a48e104fe8596cfbde5b3d4aa453]

        loplugin:unreffun (clang-cl)
        
        Change-Id: Iee87fb5b62a5489f001890dc97a44dfe447080e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117838
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [9b2dca857efea82722f82b20de68b7dc9c439fb6]

        unused always-show-image in GtkCheckButton
        
        Change-Id: I876072cf5b4fe276959467efe9e9ee2cd66eafb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117906
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Justin Luth  <justin_luth@sil.org>  [27aedd8f7de6f94469ab515cf0ab0c7e85550efc]

        tdf#104239 doc import: use "Outline" for m_pChosenWW8OutlineStyle
        
        This looks like it was a logic error.
        Probably they were only looking at the situation where
        the paragraph style set the numbering style to "Outline".
        Well, in this case, Heading 1 is actually not part
        of Chapter Numbering, but it was the body sprm
        that set the style.
        
        In any case, whenever the LFO chosen as the outline
        style is referenced, it should apply LO's special,
        unique and extremely troublesome "Outline" numbering style.
        
        Change-Id: I354d9b9f4a48abed3453ee046ddd63cda174f25d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117746
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [a0d54088a91ec85417bf06a2fa369cf785fd9bf3]

        Missing dependency
        
        Fixes "GpgME not installed correctly" at
        'make CppunitTest_sc_bugfix_test' after 'make clean'.
        See commit 5b66a038701241e0b9fa3a339acbd74f9ca4cf92.
        
        Change-Id: Idac64821609ab07a5411489deddf551fef7fd437
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117861
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a5a501c9e1da326de1d28b10777bd74dbc35bce6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fde2f8d1b9da240726a939922cc9118d3305bb5d
          - tdf#136435 Add contents on the outline folding options
            
            Change-Id: Ib079772e9f426a2775adfa843970cbd48b133ae1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117901
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [66494118ec1ddad3af56a1ed708f0a59fe063e86]

        uitest: raise exception if timeout is reached
        
        Change-Id: Ibcde404456f5c71484d925c47eb2a0c20c601033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117785
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a2d7c797958680bcf133fef44abcf2efd1007d1]

        uitest: guard execute_dialog_through_action
        
        Mostly done with a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I8b0e4aa746f7973b1bd1343219820d8b2315cf19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117703
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [49cf5e5303d064a66e4ae97223df92238d556dd1]

        Fix misuse of volatile to avoid a data race
        
        ...introduced with 2601708e3c00092693af6dd04561125cafb21d8e "cleanup mutex and
        signalling in ExecuteWrapper"
        
        Change-Id: Iae1dda078d165355f82986f4105bd4bb53ce6e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117885
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [5caba6ebf48e1ffe3f281055ae2aff5234bd594e]

        Add back computation of excepinfo.bstrDescription length
        
        ...which had been dropped with eebd84b337506c8fff151493f9b51bd127dbc89f
        "loplugin:stringview (clang-cl)".  But as discussed in the comments at
        <https://gerrit.libreoffice.org/c/core/+/116548/2/extensions/source/ole/oleobjw.cxx#b1432>
        "loplugin:stringview (clang-cl)", that dropped support for embedded NULs ("not
        that this should matter here", though).
        
        Change-Id: Ifdb327cbe8b20b365c8174802622f83b4510d547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117836
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [5da5cb2b5e1adc955b236dfa97fadff09f03490b]

        gtk4: detect context menu trigger
        
        Change-Id: Id86015c3b7f48b97acd0094838f51eade5f7569d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117881
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [0ec9a51609b78c9aa85b01a4902711923324b025]

        gtk4 dnd into external apps
        
        It's always hard to bootstrap dnd because so much of it has to work
        before any of it works. Typically dnd and cnp are strongly related
        so getting cnp working first is the way to go before trying dnd.
        
        Change-Id: I645f56dc5f8cb0e3a31e0ff8bbaab610366b6312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117798
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [a17c4ef42c48fb19e06f1eabf4821290f6ec2c38]

        -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        ...ever since the code's introduction in
        862cac51f840df3275a4618807def6e4b4061d6b "INTEGRATION: CWS rcregression01"
        
        Change-Id: I0d7bd81cebc975b8f6054318e4f5a74f508f988f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117880
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [68b1c5544ca33fe51c4c0025960decc624e9d3b2]

        -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        ...ever since the code's introduction in
        c765b4858941f748fd5ed521e10123c505db5216 "CWS-TOOLING: integrate CWS
        buildid301_DEV300"
        
        Change-Id: I9e5ad6b8e682d50ba02b08ffcc52292f749ad27a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Michael Stahl  <michael.stahl@allotropia.de>  [a0cd270a99f43049fc099ddd463e57aa243d5b0e]

        sw: layout: fix table split loop caused by RemoveFollowFlowLinePending
        
        In no_view.odt, the table 1340 does RemoveFollowFlowLine(), then splits
        again, and by the time Split() returns, its flag
        m_bRemoveFollowFlowLinePending is set and so in the next
        SwTabFrame::MakeAll() it will do the same thing again, until eventually
        it hits
        layact.cxx:544: LoopControl_1 in SwLayAction::InternalAction
        
        The flag is set during lcl_RecalcSplitLine(), in SwContentFrame::Cut(),
        which operates under the assumption that there are no other cells in the
        follow flow line that may contain content frames.
        
        This only happens if "Verdana" and "Arial" fonts are available and not
        substituted with "DejaVu Sans" etc.
        
        (regression from c4af8b0f106f31b6e79a145bc4ab83bb6a55c808)
        
        Unfortunately this uncovers another pagination bug in testTdf88496
        which was hidden by this flag being set from text frames that shouldn't
        exist anyway.
        
        Change-Id: I3cc82c13bfc06960b827aefc64f5b5b12520955a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117851
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-25  baltasarq  <baltasarq@gmail.com>  [5eedb3beeaeed88de0d1ebd041a9f15ceea7e78c]

        tdf#142460: properly handle boolean values in string pool
        
        This makes sure that results of comparison of literals have proper boolean type,
        and that this type is properly stored to/read from the string pool.
        
        This introduces a new non-standard "type" character used in the pool: 'b'. It is
        not a proper type character used in Basic (unlike '%'/'&'/'!'/'@'), but we have
        to use this trick locally, because we need to pass the type that has no own type
        character.
        
        The change should be backward-compatible: older versions reading the value should
        just ignore the 'b', and read the value as double.
        
        Change-Id: Ibd4a70b366331342346eb171c8ed3c7026279596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117655
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-25  Michael Meeks  <michael.meeks@collabora.com>  [4c267311ed7bedfd373db2afc12cad9757922ce1]

        pdf import: handle out of memory / failure to duplicate page.
        
        Avoid some reported segv's from null pages.
        
        Change-Id: Ic336b36fb57dc70fff183cd5aa5f3f3ef4562674
        Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117855
        Tested-by: Jenkins

2021-06-25  Olivier Hallot  <olivier.hallot@libreoffice.org>  [2e8b41a0b4b96053b3b61eef90b1a136884b2d96]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a09c6d5edbbd00da7ff34685cf83bf9a6fd47af8
          - tdf#105089 explain "item status changed" and "focus"
            
            Change-Id: I8b10f71e0de80f645edcd17bcae9ad5d27093a78
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117897
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [c97eba19ebf8e94da290869f429316f80d2b21b7]

        -Werror,-Wunused-but-set-parameter (clang-cl 13 trunk)
        
        ...ever since 95117e7fefa9ae82431dcdffd1e58495730f6f54 "initial import"
        
        Change-Id: I7088801e9ad1e5190c127d01c640ded0a2b0c9d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117846
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [d2a356d2fb97654e5e87be3e3bcc07dcb2244c30]

        -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        Change-Id: Ic9727cd88faac6c6b4bc132b88ce22ad5d16ecee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117849
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [ab5ac64bdd3205ba2ba9ac038719826f703a09a3]

        tdf#135316 store stylesheets in a map
        
        for faster lookup.
        
        Shaves 3% off my loading time
        
        Change-Id: I075b42db52914988be4adef303825c211b02353f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117848
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-25  Xisco Fauli  <xiscofauli@libreoffice.org>  [027b57c606685a6111e4b3e5f5c9f51281ef1bab]

        uitest: use wait_for_top_focus_window when opening the csv dialog
        
        Change-Id: I3d37383e5cd2cc949971e9df837f32b59970de59
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117800
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [8d588425ea03cfdc93ba0028377354b23060b47f]

        -Werror,-Wunused-but-set-variable (clang-cl 13 trunk)
        
        ...ever since 95117e7fefa9ae82431dcdffd1e58495730f6f54 "initial import"
        
        Change-Id: Id1590c855a604862796549376f2c3f6d76d3cb2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117847
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [4350aafa465a0a2b1da1d8e070be8781aa4b79f4]

        loplugin:casttovoid (clang-cl)
        
        Change-Id: Ic85ec91c64df6b28ca0d6fd8103c0997f61e852c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117837
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [060bab5d3c87468d769fc0de8b2d96411414816a]

        loplugin:finalclasses in svx
        
        Change-Id: I7dd8d1a900694687fbed3f3f29b0ea4bb11b7d72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117790
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-25  Stephan Bergmann  <sbergman@redhat.com>  [fc45cc4899444c218637970ad7537fe7d92077a8]

        No need for a std::string_view here
        
        ...where proc.name is of type OString.  (Following up on
        eebd84b337506c8fff151493f9b51bd127dbc89f "loplugin:stringview (clang-cl)".)
        
        Change-Id: I9e465b431f253d316e8dbff26e6768f5544e91f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117835
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [8712d2cb78808bd17399605a70862d7920e63c9a]

        tdf#58250 - Show custom unicode separator in the csv import dialog
        
        Change-Id: I5924ba3c5b0b96a744e2c2e63632b383b371e485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117766
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [d4efb4ed4ee54bd4cd132d3f70526e9af5041f27]

        gtk4: split out clipboard_content header
        
        Change-Id: I1b820c1cef2cc76a5fc748574c36ebdd4b28eef1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117797
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [9430eef53b89bce2e43258d5c4533d655fa80453]

        tdf#143032: Check if the literal is empty
        
        Change-Id: I19a3b1abbe9cda32e012be23fc98baa20108f532
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117723
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-25  Caolán McNamara  <caolanm@redhat.com>  [8242ca4c87428b8c107f9c7ce34797a72ac45cc8]

        gtk4: use css-cursors where it seems to fit
        
        see: https://drafts.csswg.org/css-ui-3/#cursor
        and: https://bugzilla.gnome.org/show_bug.cgi?id=652085
        Change-Id: I990b807b685283e12785c90c90cd0f8e658b062e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117796
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a0e9dd75e1c266714177d1178c0a035fcc193b9]

        loplugin:finalclasses in sfx2
        
        Change-Id: I8125d5447e13a6dadfde9c19c8cab6004693589a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117789
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-25  Jean-Pierre Ledure  <jp@ledure.be>  [28c3228cf81f4cd29ed5a26a944796197298d1ec]

        ScriptForge - (SF_Platform) new Printers property
        
        The SF_Platform.Printers property returns the list of
        available printers as a zero-based array.
        The default printer is put in the 1st position of the
        list (index = [0]).
        
        The property is available in Basic and Python.
        
        Change-Id: I3f02b1b5e37aa9866491d9285683fc45d17fb664
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117776
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-25  Mike Kaganski  <mike.kaganski@collabora.com>  [8383175bd3c714c163eac40a00b1e8277d4d5307]

        tdf#143047: When no properties for command, use those from item container
        
        This allows to use the "Label" property defined by user for macro
        items, that indeed have no built-in command properties. Thus the
        resulting tooltip will be a concatenation of the label and mnemonic
        instead of only mnemonic as happened before.
        
        Change-Id: I79d933fecd09ca7d64b7a3e7db0ef194e42c1c55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117787
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-25  Harshita Nag  <nagharshita16@gmail.com>  [9a94680d6b9f441167644b98c307da3a89963a32]

        tdf#124176 Use pragma once instead of include guards
        
        Change-Id: I5f0342f07f9227e45ef12c3c76015aeee4c2a0c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117833
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-06-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [c22fc8e1f60bb98a87d22e7ff9bd3290dbb9fe02]

        python3: update to 3.8.10
        
        So we don't build 3.8.8rc1 anymore. I didn't look into 3.9.
        
        Change-Id: Ife7d898c913b9b164168b0ef23a055deea55815f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117757
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-25  Heiko Tietze  <tietze.heiko@gmail.com>  [0fd2012dcedc8f98b14dc478c71f9312d4c26c85]

        Resolves tdf#125868 - Insert dialog text in case of RTL
        
        Change-Id: I28725b2ec685b320fd68117109bdeaa00db55a35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117740
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-25  Justin Luth  <justin_luth@sil.org>  [cd09753cb04a0649dfa9d3cb73ad7514af2d03bd]

        NFC: cleanup unnecessary variables, reduce scope.
        
        This function look a LOT different
        way back at original import,
        and some of the refactoring since then
        left things a bit messy.
        
        The impetus for changing this was to see how m_nListLevel
        was being used, and having it assigned to a temporary
        const variable for no reason was annoying.
        
        Change-Id: Ia25397dbe4bce2fd7bdfbb1b3053bd271c08212a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114404
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [709a40e86734a4cbf67b65222e79db76aae56981]

        cross-toolset: fix real cross help building
        
        Regression from commit 14069d84174ca7a4e60db4d75912903e9679b643
        ("configure: Improve help-options handling").
        
        We now must forward the help and extension configure options, as
        this is needed by the cross toolset to know, if it needs to build
        the HelpIndexer and HelpLinker executables.
        
        Also get rid of gb_Helper_optional_for_host. While it's in theory
        more correct, it makes gb_Helper_optional more complex, so we now
        rely on the fact, that the config_build.mk BUILD_TYPE is a subset
        of the config_host.mk BUILD_TYPE.
        
        This should fix the Windows Arm64 build, which currently seem to
        be the only cross-build including help.
        
        Change-Id: I8b90923c891b43cd2655b2578015c9bd579aae7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117758
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-24  Jan-Marek Glogowski  <glogow@fbihome.de>  [4abd2598f7816891af3bd462ffaee57f3423b9f9]

        Revert: svp: always release SolarMutex on yield
        
        Keeps the SolarMutexReleaser replacement. Seems a real fix for
        the original busy-lock problem needs further investigation.
        
        This reverts commit b9ea3467383ccdfe4be842e61267256f281487ee.
        
        Change-Id: I4bf6157e7236c30ecbf0b710d8bf9dc39d9ae5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117795
        Tested-by: Eike Rathke <erack@redhat.com>
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [66617557476e7275fdb5ef3a7f46df89027cda4e]

        uitest: sc: move csv dialog tests to their own module
        
        Change-Id: Ib8456cb77b1c147856f378eb6198f69d380e18c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117775
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-24  Justin Luth  <justin_luth@sil.org>  [4493f2191d95a35f8a29cd16912a1378d3c21ced]

        tdf#120629 ms formats: better exporting of hindiVowels etc.
        
        The big problem was that hindiVowels was imported as
        CHARS_NEPALI, but CHARS_NEPALI was not exported in DOCX.
        
        Another easy win was to DOC export both LO forms of russianLower
        and both forms of russianUpper - just like DOCX.
        
        The page number field only allows a subset of formats.
        LO doesn't have support for Hex or DollarText formats.
        The Ordinal/Cardinal formats were an easy win
        for export, even though they don't import.
        [Import seems to be in ww8par5.cxx's GetNumTypeFromName(),
        except that is being passed an empty string.]
        
        Change-Id: I176a70e0e05967414337c17d8b4acc87e20ead73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117793
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [ab25ca5f2fddf07a5790fc4a397ef758bbc31c62]

        gtk4: track underlying surface state for maximized/minimized
        
        Change-Id: Ia62d12f367555b409cb2a6ed491f65dca34baed3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117784
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [149f5e398c77b17c23941042c859264e322fbc2a]

        gtk4: start with initial window state of all unset bits
        
        Change-Id: I36fd31253a61308b2cf84d48d3e963af6c49118f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117783
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [344f8a96fda5880dfe812e3ae28cc943102d7779]

        gtk4: finish dnd target
        
        we want to work with a GdkDrop not GtkDropTargetAsync to get the
        behaviour we expect
        
        Change-Id: If1f0904fec3a0bfd6dfba770db6c11774e4d23a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117774
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [5536224038fc95369be7f9a7240ec12e3d0be5c3]

        gtk4: gdk_drop_get_actions is a better match
        
        Change-Id: I3442f3498f83da8d4eef3004b79925099dd1306d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [31eed60da71f42fe232be1c4877056c0dc9f777a]

        gtk4: unhighlight the parent like gtk3
        
        Change-Id: I47a7a6f8e42d9032a9acfdda9376ef05e30e3e73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117771
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [a73ace0a50ac497de8d5a9559aafd7e77df6af8a]

        gtk[3|4] set what widget to highlight during dnd
        
        Change-Id: Iba808b2f11615a25463c2739e6347f3cc2a91bc2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117770
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [1f8095ad5f073c14b9e604d02dda4435eb23fefa]

        gtk4: merge some common dnd and cnp blocks
        
        Change-Id: I195eb7ae3fda492a36423f57139550cb7fef9b2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117765
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [c83a9ef419ac9bde61d0ebafa3692c8e43374d49]

        drop text_transfer_result and merge dnd and paste logic
        
        Change-Id: Ia91e961d2d94bbd4baeb81647438a4026a4fce60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117764
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [dcecb57d94fa1d4dc0b9f2449974936a40e6ba7d]

        gtk4: reuse read_block_async_completed from dnd for cnp
        
        Change-Id: I1acfa4c48ee59fd79b4a4b32afa732feef6348c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117761
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [af77818e8a37eb53fa868250366a44327b63b406]

        gtk4: simplify dnd "drop" signal
        
        Change-Id: I2d4714194516c6b8270fa96c8c5a6b75d2d10b86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117760
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [bf7c5127d3ff8d699f2b44e6c3011209cf7848e0]

        gtk4: unref stream when done with it
        
        Change-Id: I3cb11918f0e85fcbc9557dc0211bc10f819f9064
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117749
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [8c276412c9cd8e12d88f4349f5fba19651161886]

        gtk4: get dnd drop into LibreOffice from another app working
        
        Change-Id: I9519af009b479e51a3da556f26f3950c4930d618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117611
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ccc85290ea66ac69a609ef2345aea48605cefba]

        BmpScaleFlag::Super is dead
        
        ever since
            commit 2269ac65de127d33d41843ae15f6bece5bc778bc
            Author: Michael Meeks <michael.meeks@collabora.com>
            Date:   Fri Nov 7 05:42:51 2014 +0000
            icontest: remove hand-coded opengl path.
        
        Change-Id: Ida030be0e087353e20897a9e961c9ce1134b21e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [350fe112c20106e9a53fec4c2f3c0f7fdc496e3f]

        remove uno::Type move constructor
        
        not necessary for the optimisation I was going for, and actually less
        efficient than just using the copy constructor
        
        Change-Id: I0f2019a0bf032283fb6c8d5d834603ea7a5ce3c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [1bc454a2c0cb0dd69512d69ddd2123a44814197e]

        Handle fancy webdav URI schemes on all platforms
        
        Change-Id: I5cc16b0fdaf032e90aa0361df6f33c04a615abab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108016
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-06-24  Justin Luth  <justin_luth@sil.org>  [8bfa14e831f31f372b98d7283fa4abc73bcb5532]

        tdf#104239 doc import: accept outlineLvl0 == (listLvl = MAXLEVEL)
        
        If listLvl is undefined, it is treated as level 0,
        so when testing that outlineLvl is equal to listLvl,
        then consider MAXLEVEL to be equivalent to zero.
        
        The opposite is not true. An undefined outlineLvl
        is not considered to be level 0.
        
        This doesn't fix bug 104239, but it is one step
        in the right direction.
        
        Two unit tests followed this path,
        (transparent-text.doc and tdf80635_pageLeft.doc)
        but neither one sets a numbering style,
        so they don't make good unit tests.
        
        Change-Id: I62cd7f5500fcd6dc06327900c33f12c129610a04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117745
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-24  Jim Raykowski  <raykowj@gmail.com>  [f446a203fa2897bab8ae7686c948a8bf060675c6]

        tdf#46626 Don't include footnote numbers in Navigator headings
        
        Change-Id: I8c655c6ed1e1d05407dac27ef19f26c6ca8d8d54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117692
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-06-24  Balazs Varga  <balazs.varga991@gmail.com>  [3af7001d0a04fdbcb38a35d0841d7d186beeb57f]

        tdf#142793 chart UI: fix option "Secondary Y Axis" on sidebar
        
        Attaching a data series to the secondary axis didn't enable
        the secondary axis at the right side of the chart using the
        sidebar (unlike in data series local menu -> Format Data
        Series... -> Options).
        
        Test: Click on the chart, select one of the data series, and
        enable Data Series -> Align Series to Axis -> Secondary Y Axis.
        
        Change-Id: I2cb99458af724471d4d04cac8c2c9013f41634fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117048
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8042e4f910bd9686f74e069e9978bfd47460c96f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 491af494a983aea54a24d68ff1bc1703d21f0a6c
          - update translations for 7.2 / master
            
            and force-fix errors using pocheck
            
            Change-Id: I5f3256dc0a6c1ada3a9a2358b3d4aba8f84b7252
            
2021-06-24  Stephan Bergmann  <sbergman@redhat.com>  [4feb8e557815151601228bdf0dde01099534b3db]

        Fix presumed race between executeAction and following asserts in UITest
        
        ...where I had observed UITest_calc_tests failing at least once with
        
        > ======================================================================
        > FAIL: test_delete_more_sheets_at_once (calcSheetDelete.calcSheetDelete)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 107, in test_delete_more_sheets_at_once
        >     self.assertEqual(document.Sheets.getCount(), nrSheets)
        > AssertionError: 7 != 1
        >
        > ======================================================================
        > FAIL: test_tdf105105_delete_lots_of_sheets_at_once (calcSheetDelete.calcSheetDelete)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 130, in test_tdf105105_delete_lots_of_sheets_at_once
        >     self.assertEqual(document.Sheets.getCount(), nrSheets + 100)
        > AssertionError: 100 != 101
        >
        > ======================================================================
        > FAIL: test_tdf114228_insert_and_delete_sheet (calcSheetDelete.calcSheetDelete)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 37, in test_tdf114228_insert_and_delete_sheet
        >     self.assertEqual(document.Sheets.getCount(), nrSheets)
        > AssertionError: 2 != 1
        >
        > ======================================================================
        > FAIL: test_tdf43078_insert_and_delete_sheet_insert_text (calcSheetDelete.calcSheetDelete)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/calc_tests/calcSheetDelete.py", line 62, in test_tdf43078_insert_and_delete_sheet_insert_text
        >     self.assertEqual(document.Sheets.getCount(), nrSheets + 2)
        > AssertionError: 2 != 3
        
        Change-Id: Id757571c153b3305644f8e4a099c4dc31bca3c52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117767
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [3b655ae8314ab4dc5ab56f933231a7ecbcb33238]

        should be using upper_bound here
        
        after commit 1feb59c3dd9e5f714ce894f8de31bbb6869c9f3b
        
        Change-Id: I5dde1a776c11b9755e33cd7ccae54f29045b5ea1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117697
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [b8fbb46b0d65cdca007a200c4a882030c2bf8dc9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 01e2e91dcfb2a6d07eec0f9188189213fa464592
          - Fix localization in SF_Calc help page
            
            This patch silences a few strings for translantion. It also rephrases the first 2 paragraphs of the Calc service that were inaccurate.
            
            Change-Id: Ic2ce5e2c5e53134d80717cd97f63bec4bd726a9b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117641
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [52955244be35ce4465294cfb742bd6a524e5e49e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 00086866ecd2de7434f851bc4f5fdc8195b5f262
          - Fix localization in SF_Base and SF_Basic
            
            Change-Id: Ibcd3826af1a89704bf32db833af63fb0b9564cb1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117568
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [b4777e8839899f439f5497550fe733dfe208e287]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a97fbc6bbfbfa214083615868ffccd3ccebf5d37
          - Fix localization in SF_Document help page
            
            Change-Id: Ie1fb122ca7574aa28ab199ebebbba76975389fa2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117722
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-24  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [47282cc577eda78b9cceff0860e74ce7b3f121cd]

        breakpad: don't include the users's env in linux dumps
        
        Change-Id: I004b862295686789c0a88dc678bd098d81c76421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117503
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [066c4054f4a1078602aaab5516590628eaf6a47e]

        tdf#135316 bypass 'existing style' check when importing
        
        trust the import filter to have already de-duplicated styles
        
        Shaves 5% off my load time
        
        Change-Id: I36b5196762483f629a38e00156d2fe9a1cb28c97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [6d30c51f1f69d8c31b30b4e08a97222363852b17]

        tdf#69207 - Use selected text delimiter to parse the provided csv data
        
        Change-Id: Ie260cb57956cd450398746c7f51629d37d14a324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117750
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [29c429e636a94cd07117bffd40c25b114d2e620f]

        rename read_paste_result to read_transfer_result
        
        we'll reuse what worked for clipboard for dnd
        
        Change-Id: If8accc2d236253a734f48929e231bcecbb00741f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117744
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Caolán McNamara  <caolanm@redhat.com>  [ff74a6eb3b4656e396368a41552699c6b642cfa4]

        error: unknown type name 'OStringBuffer'
        
        Change-Id: I28a4a2581e6afb02aeb137932fbf884b109e4b5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117748
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [dd2d82cfb7c2f3fc5300bc6164608beaf7c3d0ba]

        uno::Type needs a move operator
        
        speeds up some operations where Type is stored in a vector
        
        Change-Id: Id7112e51d4e4707bc6d261313e994c6ffef54d31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117693
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [888d1e2a41d27eecf0064d4cd987a8e7ac32aacb]

        SAL_WARN -> SAL_INFO
        
        calling code is quite happy with this function returning a nullptr
        
        Change-Id: I79e6be31b6c30ee103a8dd0cba9e652ba93b744b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-24  Justin Luth  <justin_luth@sil.org>  [b8727666969156534c05b54a1addb54046969a50]

        tdf#123405 doc import: inherit from all Outline styles
        
        Good - an example document that proves that inheritance
        needs to happen with more than the first 9 items which
        contain the Heading styles that are most often
        associated with Chapter Numbering.
        
        Change-Id: I69ab1dd3fdab4d54695d9b321b0d2970509090a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114403
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-24  Mike Kaganski  <mike.kaganski@collabora.com>  [01ffaa6e02ebb0fc3aba75aafc56988127ade3ab]

        Delete copy ctors/assignments for DLLEXPORT class
        
        ... instead of including <vcl/window.hxx> where it is not directly
        used. For details, see commit ee405fb2ef36337851801f1bd34411c606d55988.
        
        This reverts commits 6aa6b6c814b0353768fa7276d1f11d69a0ebedba and
        beeb19b361213d22247e5cb776dc522cbf190ca8.
        
        Change-Id: Ia91f3c303e1df0a698d06cdef1d8e64e99d781ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117751
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [9a89eea4c3c58d2efce8afe709c0317869839ff9]

        Revert "uitest: guard create_doc_in_start_center"
        
        This reverts commit 374baf308979306aa35575118c40ccd7caae1e29.
        
        Many uitests are failing randomly in jenkins for no apparent
        reason
        
        Change-Id: I5960330fab4967518bfeea32b3b8c5f8bfbea57e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117752
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-23  Xisco Fauli  <xiscofauli@libreoffice.org>  [6805efdecb240fad8c82a5c1756a2a0e92f12b7d]

        uitest: blind fix for failure in slow machines
        
        Change-Id: Iea1648d34f1aa169ca01e7f523c480c8f795de88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-23  Stephan Bergmann  <sbergman@redhat.com>  [39605d175bc0fe52c904d4b41a184d7e2691f2dc]

        Introduce wait_for_top_focus_window to fix UITest_calc_tests9
        
        ...which I had seen hang at least once, and after a manual `kill -9` of the hung
        soffice.bin process (still yielding in UI loop from within executing a dialog),
        it failed with
        
        > ======================================================================
        > ERROR: test_tdf57841 (tdf57841.Tdf57841)
        > ----------------------------------------------------------------------
        > Traceback (most recent call last):
        >   File "sc/qa/uitest/calc_tests9/tdf57841.py", line 27, in test_tdf57841
        >     self.assertEqual('true', get_state_as_dict(xDialog.getChild("tab"))['Selected'])
        > uno.com.sun.star.uno.RuntimeException: Could not find child with id: tab vcl/source/uitest/uiobject.cxx:467
        
        (The subtle difference in naming is that wait_for_top_focus_window waits
        indefinitely, while its sister wait_until_* functions (like
        wait_until_child_is_available) can time out.  There is no good reason here to
        allow for timing out.)
        
        Change-Id: I3e4dc68871f42d64160d8e411fe9a661bbaec192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117739
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-23  Eike Rathke  <erack@redhat.com>  [d81775f5b12080676ebaf659c5a4c10d64a9074b]

        Resolves: tdf#143008 Evaluate AM/PM for type date+time text-to-column and CSV
        
        Change-Id: Ib760b9a103ab4b8ce7f5a158b09fbe11c6617f2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117747
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-23  Heiko Tietze  <tietze.heiko@gmail.com>  [bd549d04f924355b1f33e953241b7effc8731b6c]

        Resolves tdf#121158 - Placement issues on page sidebar
        
        Change-Id: I4e13ca9eac9c86f08c869c8fa9d3fb346c2aa2d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117710
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-23  Justin Luth  <justin_luth@sil.org>  [8d248914f13b3b665431c70f0192fa967e0b7717]

        tdf#106541 doc import: allow listLevel to be inherited
        
        RegisterNumFormat always ran earlier since it forced
        the listLevel to be in the valid range.
        So that can automatically be simplified.
        
        Secondly, just because the listLevel was not specified
        doesn't mean that it will be a level 1. It could
        inherit a listlevel from the style. So just leave
        it as undefined here, and let it be handled later on.
        
        ww8export's testListNolevel already ensures that
        SetStylesList must handle unspecified listLevel.
        
        chapterNumberingTortureTest21.doc matches the assert,
        so I have found my document, but this already works.
        
        Change-Id: Idf8850980b92054104c16200b2dea6bd7dde1f46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117481
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-23  Justin Luth  <justin_luth@sil.org>  [1d50b8a7e93178e1ceec0bf95ed6794f73e2f184]

        tdf#120629 doc {im,ex}port: accept known numberingTypes
        
        I cross-checked with what was imported via DOCX
        and took inspiration from tdf#141341 to consolidate
        these two nearly-identical functions that otherwise
        would need to be kept in sync (and never are)..
        
        Change-Id: I7e021d7c9d68597da5b0ce1311ae243fc003e4f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117736
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-23  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [9e8c35cc3f1f5e1c08afd46e0d0fbc07f1ff21f9]

        EMF+ tdf#142975 Add brush support to DrawString record
        
        Change-Id: Icfcb4199dcd755fb20e14a8166571b6d6e763f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117671
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-23  Michael Meeks  <michael.meeks@collabora.com>  [177167dcff92a48ca7fcf66d8cf20f38e560c5b3]

        lok: allow .uno:JumpToMark.
        
        Change-Id: I0cd3173c94c6952bd5cf81474a7cc31b1585e50e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117646
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-06-23  Caolán McNamara  <caolanm@redhat.com>  [d8836d491a6fdf85d4b8df4952962fc6395f02c3]

        ofz#35502 Indirect-leak
        
        Change-Id: Ib5bb8e39821cab4f398389971a6296885e2fa4bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-23  Caolán McNamara  <caolanm@redhat.com>  [623b633f1145466e8d60fff3255f476e6001297b]

        ofz#35504 Integer-overflow
        
        Change-Id: If8c460a4890ad23c2656c3b677b6c2ad8d46fb2a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-23  Caolán McNamara  <caolanm@redhat.com>  [e33742b64ab325dbc596b4fbdaf229ff91e11e93]

        cid#1401328 Uncaught exception
        
        Change-Id: Ie3c938992a5c1e7aab3d7ae32f4169d04225195a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117707
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-23  Ilhan Yesil  <ilhanyesil@gmx.de>  [86e300df241312f6152da1cfa3cb2b8c668d1df5]

        tdf#124983 In calc make printable page borders initially visible
        
        If option "LibreOfficeDev Calc/View/Page breaks"
        is enabled, breaks should be visible. But if the document
        is opened the first time or a tab is opened the first time,
        the breaks are not calculated yet and therefore not visible.
        To avoid calculations during the load of the document, a
        timer will be triggered to calculate the breaks after loading
        is finished.
        
        Change-Id: I87219c62e20882b19d36042692efd2e6a8d8190a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90101
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-06-23  Steve Fanning  <stevemfanning@yahoo.co.uk>  [d3d15db10a4d75c48c57b3026376626dbd343c4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a79ac40adfad119a8957200defabe16282ea5204
          - Document how to escape double quotes in help for Calc's text functions (TDF#113976)
            
            Change-Id: I14c4afc919343dda2e1f30c49c69f434cf1104f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117717
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-23  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e987e50aee4a28f4067717811661e410f3fc3c62]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ecfb0b34517530a35194221909750eafd23f4314
          - Add precisions to RAWSUBTRACT after 7.2 rel notes.
            
            Change-Id: Id0db2b64e0dd4b89089a6610930dd84e71cf9067
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117467
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2021-06-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [639e52064260bc47698078a4319e59fe4b54db62]

        simplify SwFormatsModifyBase::ContainsFormat
        
        can just call IsAlive
        
        Change-Id: I7cd3b33520261b68d549783cabd5cf3f6f4847a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117696
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-23  Noel Grandin  <noel@peralex.com>  [9815bf197c27afdfeccf967898c3a000bcf7b256]

        tdf#135316 add SvFileStream::SetDontFlushOnClose
        
        if we're going to be deleting a temporary file, there is no point
        flushing it on close, which has a measureable cost
        
        This takes my load time from  17s to 16s
        
        Change-Id: I2fce7eeaf0ce9fef826b4ce9a1a4d4c8114cac76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117607
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-23  Tor Lillqvist  <tml@collabora.com>  [90df123cd9ff9fc1c7b991d9ae9a1ed8c9e9f0de]

        The Chrome Trace Event viewer doesn't support nested async events
        
        Instead of nestable b(egin) and e(nd) events, generate the allegedly
        deprecated S(tart)' and F(inish) events.
        
        Makes the code simpler. (And AsyncEvent is still unused. Unclear
        whether adding it was based on a misunderstanding.)
        
        Change-Id: Ic029b67e0951dda775c0d0af009f2e431ae55e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117700
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-23  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [63cd67e5e18f01aca303131e148c80398a181a41]

        tdf#92525 tdf#142398: fix export of simple custom shapes
        
        Most of the custom shapes were exported with DrawingML custom
        geometry instead of DOCX preset shapes, losing their preset type,
        adjust handles and text position. Add a preset exporter class to
        handle all possible preset shapes later, and fix the export of
        the following shapes now: "bevel", "blockArc", "bracePair",
        "bracketPair", "hexagon", "octagon", "parallelogram", "plus",
        "roundRect" and "triangle".
        
        tdf#92525: keep text position in triangles with different
        adjustments, too.
        
        tdf#142398: part 1: export simple shapes as preset shapes.
        
        Change-Id: I6aee74f7670bea8c1fe5909cbf307778ea728669
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115606
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ae31c8503c568171cadc87a0b3de0ca23619afdd]

        Removed duplicated include
        
        Change-Id: I5c82c0b216dd680d5cbac154a276bbd09fa32477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117667
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-23  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a951ad1e5062b06dcd7d8d11d5d85f4b7bf720da]

        Fix typos
        
        Change-Id: Ia1d0c358868e899e121b8331fad17ce36d454f10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117668
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-23  Michael Warner  <michael.warner.ut+libreoffice@gmail.com>  [648e4106cc002ff5b8184a8c104f93cb06e4b540]

        tdf#141709: Use poppler_data
        
        Bundle the files from poppler_data and provide the path to them to
        poppler when the bundled poppler library is used.
        
        Change-Id: I13a2ef861303a0be17aa0a861ef8ac96ed8a93be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117523
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-23  Caolán McNamara  <caolanm@redhat.com>  [388d52a9193d89058f27b3efd48ab3cd5dedf0a7]

        disable ligatures for monospace fonts
        
        we don't want e.g. a ffi ligature for Courier/Nimbus Mono PS
        
        Change-Id: I292c6e2ea217b511b4affcd8dab4a4bda85ab5da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117669
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-23  Noel Grandin  <noelgrandin@gmail.com>  [1feb59c3dd9e5f714ce894f8de31bbb6869c9f3b]

        optimised FindFormatByName for SwFrameFormats
        
        by re-arranging the boost::multi_index key, we can re-use
        that index to find all formats matching a name
        
        Change-Id: I3b3b6ceb7137926be3981578a64052f47f279af0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117676
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-23  panoskorovesis  <panoskorovesis@outlook.com>  [bc4cea4943c9189b92f51aacf097549023398b2e]

        Add LayoutMode cppunit test to vcl.
        
        The test sets two LayoutModes (using ComplexTextLayoutFlags)
        and checks their attributes.
        
        Change-Id: Id765c150485c6f06c1326498a7f1b40b8f9c12fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117575
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-23  panoskorovesis  <panoskorovesis@outlook.com>  [659c6af5338e1a6d6ff7715f20fa992b62c48ce5]

        Add TextLanguage cppunit test to vcl.
        
        The test sets two languages for the metafile and checks their attributes.
        
        Change-Id: Ibb23c03af48af5c40ea65593917a40a928fd1280
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117368
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-23  panoskorovesis  <panoskorovesis@outlook.com>  [2ab2f24951c7f490cc170533c1e08a61a8dc3104]

        Add Font cppunit test to vcl.
        
        The test creates a Font, sets custom attributes for it and then
        tests them.
        
        Change-Id: Ib1427392674c7728180e1ad00621e56950d495ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117155
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-23  panoskorovesis  <panoskorovesis@outlook.com>  [e10df88b8ae4138862d4dd25c221189878641aa4]

        Add Comment cppunit test to vcl.
        
        The test creates two MetaCommentActions from the GDIMetafile and
        checks their attributes and contents.
        
        Change-Id: I748a6fa5dcf0dc09359fb48ea0bf3d7ceef3dbcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117245
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-23  Stephan Bergmann  <sbergman@redhat.com>  [a344462ccb324b14dbf17391146f78d84307cbec]

        Remove unused DOCTYPE from odk/examples xcu file
        
        The declared entities have apparently never been referenced ever since the
        file's introduction in 9fa09d43d0dc0ec0ac71bad31b85ce7fc302ee90 "INTEGRATION:
        CWS sdkinspector2".  (And at least xmlreader skips and ignores the content of
        such document type declarations anyway.)
        
        Change-Id: I8263200f52bb5f1692090995574619f9c0ec478f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117658
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-23  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f6b9f671d128c989ce223d61d0d5d43ff1dc9fcb]

        move BufferedDecompositionPrimitive2D impl. into its own file
        
        Change-Id: I180ed5378765237f69ccf721448dd799df2b457b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117666
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [374baf308979306aa35575118c40ccd7caae1e29]

        uitest: guard create_doc_in_start_center
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I75ef7712af3676363a9a464acf83f6f68ffc4f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117617
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [b2331179fc508fd6bc37355e5c3c5a5ee54557c4]

        Move SwDoc::FindFormatByName to SwFormatsBase
        
        in preparation for adding optimised implementations of it for subclasses
        
        Change-Id: I6d8ff54864d2d3c605a1cd0b4da2c6136e2a21cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-22  Noel Grandin  <noelgrandin@gmail.com>  [c85d8b23c2339958f59dbc66a9ba4ec114125514]

        SwFrameFormats::rangeFind does not, in fact return a range
        
        because the index it relies on, is a unique index.
        
        So make this explicit in the method call by returning a normal
        iterator.
        
        Change-Id: I428d1b14d1274079955eb4f893ca91d1745264e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [5ce23ef129182e670ba2c16b65cc44510086b591]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a8dd66b4bf752c09980dbffcbbc8a055432d28ed
          - Mute l10n and small cosmetic changes
            
            Change-Id: Id20d7dbba5a835f713945a1d994739dc116cdcef
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117642
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [647623db579b0e7b176f9cbfa24bf8444cfd94d4]

        uitest: fix build
        
        regression from 1e7bf688967dc39540d24070c70c73b06bd1347f
        < tdf#142851 Chart UI: fix empty Chart Type dialog >
        self.ui_test.load_file was changed in
        be0a41679fea524e0935dc6617b5e65349812dd1
        < uitest: guard load_file >
        
        Change-Id: I00cb5dc6e1213403f2eba5bc4b9dc0e876118536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117670
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-22  Jean-Pierre Ledure  <jp@ledure.be>  [8467a8e0587011269e376a65a0e397e096a36cc5]

        ScriptForge - (SF_UI) CreateBaseDocument() new CalcFileName argument
        
        Syntax of CreateBaseDocument() becomes
           FileName, [EmbeddedDatabase=HSQLDB|FIREBIRD|CALC],
           [RegistrationName=""], [CalcFileName]
        
        Only when EmbedddedDatabase = "CALC", the new argument CalcFileName
        represents the file containing the tables as Calc sheets.
        The file must exist or an error is raised.
        
        Example:
            Dim myBase As Object, myCalcBase As Object
            Set myBase = ui.CreateBaseDocument("C:\Databases\MyBaseFile.odb", "FIREBIRD")
            Set myCalcBase = ui.CreateBaseDocument("C:\Databases\MyCalcBaseFile.odb", _
                "CALC", , "C:\Databases\MyCalcFile.ods")
        
        Both Basic and Python are supported.
        
        Change-Id: I9912b110dcec12fe451a47abb61ab143fb543b94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117665
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-22  Justin Luth  <justin_luth@sil.org>  [ce20614b630e50fbfcc82e4cd2f565b04dfb788e]

        tdf#106541 doc import: prevent inheriting when LFO == 0
        
        When LFO == 0, that is a special case that means that
        numbering should be disabled. (This can similarly be
        accomplished by setting Lvl to 9 - Body text,
        except doing so here could mess up Lvl inheritance).
        
        If the LFO is a negative number, that indicates something
        different with formatting that we don't currently handle,
        but it still means cancel numbering. So at this point
        just treat them all the same as if they were LFO 0.
        
        Change-Id: I1bab06c6b766175a3982bf3a7b19f7b321df807e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117480
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-22  Mike Kaganski  <mike.kaganski@collabora.com>  [f2ea39c70da3f82bb39f8b51b5484172360b1fc2]

        Avoid crash getting default item for OWN_ATTR_TEXTCOLUMNS
        
        ... as seen in https://dev-builds.libreoffice.org/crashtest/89459662bf2684a07596d4132c84e5da7e0af8d4/backtraces/task908-core.backtrace.txt
        
          ...
          #8  0x00007fb81c9674f2 in Application::Abort(rtl::OUString const&) (rErrorText="") at /home/buildslave/source/libo-core/vcl/source/app/svapp.cxx:274
          #9  0x00007fb8226aa127 in desktop::Desktop::Exception(ExceptionCategory) (this=0x7ffdf0d856d0, nCategory=<optimized out>) at /home/buildslave/source/libo-core/include/rtl/ustring.hxx:181
                  bInException = true
                  nOldMode = <optimized out>
                  rArgs = <optimized out>
                  bRestart = <optimized out>
                  bAllowRecoveryAndSessionManagement = <optimized out>
          #10 0x00007fb81c97ca5a in VCLExceptionSignal_impl(void*, oslSignalInfo*) (pInfo=<optimized out>) at /home/buildslave/source/libo-core/vcl/source/app/svmain.cxx:169
                  nOldMode = SystemWindowFlags::DIALOG
                  pSVData = 0x7fb81d423300 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance>
                  aLock = {m_isAcquired = true, m_isChecked = true, m_rSolarMutex = @0x5612f7423da0}
                  bIn = true
                  nVCLException = <optimized out>
          #11 0x00007fb82282d1a7 in callSignalHandler(oslSignalInfo*) (pInfo=pInfo@entry=0x7fb80a196af0) at /home/buildslave/source/libo-core/sal/osl/all/signalshared.cxx:59
                  pHandler = 0x5612f826c2d0
                  Action = <optimized out>
          #12 0x00007fb82289e5a8 in (anonymous namespace)::signalHandlerFunction(int, siginfo_t*, void*) (signal=6, info=0x7fb80a196cf0, context=0x7fb80a196bc0) at /home/buildslave/source/libo-core/sal/osl/unx/signal.cxx:451
                  Info = {Signal = osl_Signal_AccessViolation, UserSignal = 6, UserData = 0x0}
          #13 0x00007fb8224d6840 in <signal handler called> () at /lib/x86_64-linux-gnu/libc.so.6
          #14 0x00007fb8224d67bb in raise () at /lib/x86_64-linux-gnu/libc.so.6
          #15 0x00007fb8224c1535 in abort () at /lib/x86_64-linux-gnu/libc.so.6
          #16 0x00007fb8224c140f in  () at /lib/x86_64-linux-gnu/libc.so.6
          #17 0x00007fb8224cf102 in  () at /lib/x86_64-linux-gnu/libc.so.6
          #18 0x00007fb81f72434c in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x5612f8e2ec00, nWhich=<optimized out>) at /home/buildslave/source/libo-core/svl/source/items/itempool.cxx:728
                  __PRETTY_FUNCTION__ = "const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const"
                  nPos = <optimized out>
                  pDefault = <optimized out>
          #19 0x00007fb81f724326 in SfxItemPool::GetDefaultItem(unsigned short) const (this=0x5612f8869790, nWhich=4006) at /home/buildslave/source/libo-core/svl/source/items/itempool.cxx:727
                  __PRETTY_FUNCTION__ = "const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const"
                  nPos = <optimized out>
                  pDefault = <optimized out>
          #20 0x00007fb80de6cc2e in SdStyleSheet::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) (this=0x5612f89d3940, aPropertyName=..., aValue=uno::Any("com.sun.star.text.XTextColumns": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x5612f89006c0}, <No data fields>})) at /home/buildslave/source/libo-core/include/svl/style.hxx:257
                  aGuard = {<osl::Guard<comphelper::SolarMutex>> = {pT = 0x5612f7423da0}, <No data fields>}
                  pEntry = 0x7fb80e7252e8 <GetStylePropertySet()::aFullPropertyMap_Impl+1992>
                  rStyleSet = SfxItemSet of pool 0x5612f8869790 with parent 0x0 and Which ranges: [(1000, 1012), (1014, 1033), (1047, 1056), (1068, 1091), (1093, 1124), (1174, 1229), (4007, 4058)] = {1000 = 0x0, 1001 = 0x0, 1002 = 0x0, 1003 = 0x0, 1004 = 0x0, 1005 = 0x0, 1006 = 0x0, 1007 = 0x0, 1008 = 0x0, 1009 = 0x0, 1010 = 0x0, 1011 = 0x0, 1012 = 0x0, 1014 = 0x0, 1015 = 0x0, 1016 = 0x0, 1017 = 0x0, 1018 = 0x0, 1019 = 0x0, 1020 = 0x0, 1021 = 0x0, 1022 = 0x0, 1023 = 0x0, 1024 = 0x0, 1025 = 0x0, 1026 = 0x0, 1027 = 0x0, 1028 = 0x0, 1029 = 0x0, 1030 = 0x0, 1031 = 0x0, 1032 = 0x0, 1033 = 0x0, 1047 = 0x0, 1048 = 0x0, 1049 = 0x0, 1050 = 0x0, 1051 = 0x0, 1052 = 0x0, 1053 = 0x0, 1054 = 0x0, 1055 = 0x0, 1056 = 0x0, 1068 = 0x0, 1069 = 0x0, 1070 = 0x0, 1071 = 0x0, 1072 = 0x0, 1073 = 0x0, 1074 = 0x0, 1075 = 0x0, 1076 = 0x0, 1077 = 0x0, 1078 = 0x0, 1079 = 0x0, 1080 = 0x0, 1081 = 0x0, 1082 = 0x0, 1083 = 0x0, 1084 = 0x0, 1085 = 0x0, 1086 = 0x0, 1087 = 0x0, 1088 = 0x0, 1089 = 0x0, 1090 = 0x0, 1091 = 0x0, 1093 = 0x0, 1094 = 0x0, 1095 = 0x0, 1096 = 0x0, 1097 = 0x0, 1098 = 0x0, 1099 = 0x0, 1100 = 0x0, 1101 = 0x0, 1102 = 0x0, 1103 = 0x0, 1104 = 0x0, 1105 = 0x0, 1106 = 0x0, 1107 = 0x0, 1108 = 0x0, 1109 = 0x0, 1110 = 0x0, 1111 = 0x0, 1112 = 0x0, 1113 = 0x0, 1114 = 0x0, 1115 = 0x0, 1116 = 0x0, 1117 = 0x0, 1118 = 0x0, 1119 = 0x0, 1120 = 0x0, 1121 = 0x0, 1122 = 0x0, 1123 = 0x0, 1124 = 0x0, 1174 = 0x0, 1175 = 0x0, 1176 = 0x0, 1177 = 0x0, 1178 = 0x0, 1179 = 0x0, 1180 = 0x0, 1181 = 0x0, 1182 = 0x0, 1183 = 0x0, 1184 = 0x0, 1185 = 0x0, 1186 = 0x0, 1187 = 0x0, 1188 = 0x0, 1189 = 0x0, 1190 = 0x0, 1191 = 0x0, 1192 = 0x0, 1193 = 0x0, 1194 = 0x0, 1195 = 0x0, 1196 = 0x0, 1197 = 0x0, 1198 = 0x0, 1199 = 0x0, 1200 = 0x0, 1201 = 0x0, 1202 = 0x0, 1203 = 0x0, 1204 = 0x0, 1205 = 0x0, 1206 = 0x0, 1207 = 0x0, 1208 = 0x0, 1209 = 0x0, 1210 = 0x0, 1211 = 0x0, 1212 = 0x0, 1213 = 0x0, 1214 = 0x0, 1215 = 0x0, 1216 = 0x0, 1217 = 0x0, 1218 = 0x0, 1219 = 0x0, 1220 = 0x0, 1221 = 0x0, 1222 = 0x0, 1223 = 0x0, 1224 = 0x0, 1225 = 0x0, 1226 = 0x0, 1227 = 0x0, 1228 = 0x0, 1229 = 0x0, 4007 = 0x0, 4008 = 0x0, 4009 = 0x0, 4010 = 0x0, 4011 = 0x0, 4012 = 0x0, 4013 = 0x0, 4014 = 0x0, 4015 = 0x0, 4016 = 0x0, 4017 = 0x0, 4018 = 0x0, 4019 = 0x0, 4020 = 0x0, 4021 = 0x0, 4022 = 0x0, 4023 = 0x0, 4024 = 0x0, 4025 = 0x0, 4026 = 0x0, 4027 = 0x0, 4028 = 0x0, 4029 = 0x0, 4030 = 0x0, 4031 = 0x0, 4032 = 0x0, 4033 = 0x0, 4034 = 0x0, 4035 = 0x0, 4036 = 0x0, 4037 = 0x0, 4038 = 0x0, 4039 = 0x0, 4040 = 0x0, 4041 = 0x0, 4042 = 0x0, 4043 = 0x0, 4044 = 0x0, 4045 = 0x0, 4046 = 0x0, 4047 = 0x0, 4048 = 0x0, 4049 = 0x0, 4050 = 0x0, 4051 = 0x0...}
                  aSet = SfxItemSet of pool 0x5612f8869790 with parent 0x0 and Which ranges: [(4006, 4006)] = {4006 = 0x0}
          #21 0x00007fb81945d8eb in SvXMLImportPropertyMapper::FillPropertySet_(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySetInfo> const&, rtl::Reference<XMLPropertySetMapper> const&, SvXMLImport&, ContextID_Index_Pair*) (rProperties=std::__debug::vector of length 3, capacity 4 = {...}, rPropSet=uno::Reference to (class SdStyleSheet *) 0x5612f89d3ad0, rPropSetInfo=uno::Reference to (class SfxItemPropertySetInfo *) 0x5612f8938ed8, rPropMapper=rtl::Reference to 0x5612f89a1900, rImport=..., pSpecialContextIds=pSpecialContextIds@entry=0x7fb80a1978b0) at /home/buildslave/source/libo-core/include/com/sun/star/uno/Reference.h:384
                  rProp = @0x5612f8497590: {mnIndex = 54, maValue = uno::Any("com.sun.star.text.XTextColumns": {<com::sun::star::uno::XInterface> = {_vptr.XInterface = 0x5612f89006c0}, <No data fields>})}
                  nIdx = 54
                  rPropName = "TextColumns"
                  nPropFlags = 201342976
                  i = 1
                  bSet = false
                  nCount = <optimized out>
          #22 0x00007fb8194650c6 in SvXMLImportPropertyMapper::FillPropertySet(std::__debug::vector<XMLPropertyState, std::allocator<XMLPropertyState> > const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, ContextID_Index_Pair*) const (this=0x5612f8fa4960, aProperties=std::__debug::vector of length 3, capacity 4 = {...}, rPropSet=uno::Reference to (class SdStyleSheet *) 0x5612f89d3ad0, pSpecialContextIds=pSpecialContextIds@entry=0x7fb80a1978b0) at /home/buildslave/source/libo-core/xmloff/source/style/xmlimppr.cxx:466
                  xInfo = uno::Reference to (class SfxItemPropertySetInfo *) 0x5612f8938ed8
                  xMultiPropSet = empty uno::Reference
                  bSet = <optimized out>
                  xTolPropSet = empty uno::Reference
          ...
        
        Change-Id: Icdb32ff5383a8073f525aad1a39ff1dcc70559f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117661
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-22  Tünde Tóth  <toth.tunde@nisz.hu>  [1e7bf688967dc39540d24070c70c73b06bd1347f]

        tdf#142851 Chart UI: fix empty Chart Type dialog
        
        Chart Type dialog was empty, when the chart type of the chart
        was unsupported.
        
        Regression from commit: 4ff983b930dc15658aa531759d3f1e5b9586aeab
        (Related: tdf#142049 restore some elements default visibility
        in the ui)
        
        Change-Id: I057e6b9218edee398af8311c46b922ca76a9bcb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117173
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-22  Stephan Bergmann  <sbergman@redhat.com>  [fb3027544fd6ff6bc089d1e24d4f8dd2a0ee1fce]

        Clarify no loplugin:overridevirtual with templated base class
        
        Change-Id: I4128b43f2a928fa5465991cc92b2d62e54e2cfec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117662
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [d9a5302ca8bef90914539c12adb6c81496c28504]

        Resolves: tdf#140361 use the DisableEditHyperlink state as of menu launch time
        
        at context menu popup time set if the EditHyperlink entry should be
        disabled and use that state if queried about it if EditHyperlink is
        dispatched from the menu. So ignoring where the mouse currently happens
        to be when the menu was dismissed.
        
        The dispatch is done async, if at all, so also trigger an async Query
        with Invalidate so at least one Query is ensured to reset the stored
        state
        
        similar to tdf#137445 which was for impress/draw
        
        Change-Id: I43a144f1ac0a4db89cc5ab0ebeeae744719f5958
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117653
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Noel Grandin  <noel@peralex.com>  [a1cb4c7665f474c9099c734ad3e6a16c9079a6af]

        reduce allocation in ZipContentInfo map
        
        This is a small struct, no sense in allocating it separately
        
        Change-Id: I709daebbde648a79f175f74c207bdf4871ae6ff1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117604
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [be0a41679fea524e0935dc6617b5e65349812dd1]

        uitest: guard load_file
        
        Mostly done by a script
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: Ia924293dc2a12230fd13f69fd734875ced86be8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117593
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-22  Jan-Marek Glogowski  <glogow@fbihome.de>  [14069d84174ca7a4e60db4d75912903e9679b643]

        configure: Improve help-options handling
        
        This patch includes:
        
        * A README.help.md as a general documentation for the different
          help types, the LO code and help-related build options.
        * Adds --disable-xmlhelp for removing the xmlhelp support from the
          build. Disable for iOS, Android and Emscripten. This was partly
          included in HAVE_FEATURE_DESKTOP before.
        * Rename WITH_HELP define to WITH_HELPPACKS, which reflects the
          actual usage AFAIK.
        * Depend --with-omindex on --with-help=online and don't override
          the --with-help setting. Error out on conflicting options.
        * Depend --with-helppack-integration on build help variants, which
          actually result in help packs.
        
        Kind of reverts commit 2c38ea6d16b910294220cefaf8ae6a0683e6405a
        ("Building without --with-help is not supposed to disable help
        functionality").
        
        Change-Id: Ie4cb73905b3ed94e991d9f1bd75cfbd6de9da385
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116222
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [75c42c1f3ba6d40d518a4da400a84015d30240c0]

        fix indent
        
        Change-Id: I0a7e43906522462c6bbf9aaec89d296e5017a3a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117652
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Rafael Lima  <rafael.palma.lima@gmail.com>  [b428eed256341e4c220aef91651ece8ed871f3f8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3c0fb9a710915c30adf5287a734a185696fa0b76
          - Add note about Python support availability on some SF services
            
            Change-Id: I226b0b92fcc2b380fa6687cba87276b485009151
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117567
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-22  Jan-Marek Glogowski  <glogow@fbihome.de>  [e09bd4a994e9d4e471da540d9c85ec3afe5d0ca5]

        configure: make OpenLDAP test independent from X11
        
        I missed that PostgreSQL can be build on MacOSX with OpenLDAP
        support. Stephan had an incremental build failure because of it.
        
        But instead of opting-in using test_openldap=yes on MacOSX, like
        on Haiku, this drops the using_x11 dependency and defaults to
        "yes", like it was before. This was more of a convenience then
        reality anyway, and it makes really not much sense to disable
        OpenLDAP in case of --without-x.
        
        Change-Id: I959a3b30f1c369264174302f18267a4eb40a3a52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117046
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-22  Steve Fanning  <stevemfanning@yahoo.co.uk>  [e759f8ddab7f767d23f07e6ee5e50ee8ee51bba9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 26fad1c72fdc6a72b455c44e57b5738ee6d1a61d
          - Provide a correct example within the help for Calc's FINDB function.
            
            Change-Id: Ibff7dd5bf47f26c431b1ce49e6ac5250f6192176
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117569
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [c5d984b840db595796051bc2bf37d1c2179157e3]

        crashtesting: assert on export of tdf105134-1.docx to odt
        
        when interactively saving on creating preview for recently used
        
        Change-Id: I9d859cf404c34659653a14f8c2a94f867c704b7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117616
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Jan-Marek Glogowski  <glogow@fbihome.de>  [b9ea3467383ccdfe4be842e61267256f281487ee]

        svp: always release SolarMutex on yield
        
        Always give other threads a chance to acquire the SolarMutex, if
        we yield.
        
        Change-Id: I77d93374ea606acd1f7820755197a27655418639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117454
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [054d6598b29171c3719d7144efe77a408fc4e716]

        cid#1486261 Dereference before null check
        
        since...
        
        commit 2e6e87decdb87221a7b832958e03195b1d8fc133
        Date:   Mon Jun 21 13:18:00 2021 +0200
        
            replace dynamic_cast<SwLayoutFrame> with cheaper check
        
        Change-Id: I4623e3eca5a82fa37f52697c189310a835fc76e0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [fd8cdc426e3b1fcf3619311fbd586be9323825c7]

        cid#1486260 Uncaught exception
        
        Change-Id: I12613ed381e961fd36348eabd543b11a1960337d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117613
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Caolán McNamara  <caolanm@redhat.com>  [6632bc699b1b57b2e5d8c0bd647aca16dcdcf31e]

        cid#1486241 'Constant' variable guards dead code
        
        Change-Id: Ia90e8ad537fccdf38ed0bf0e9f963033c69ec202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-22  Julien Nabet  <serval2412@yahoo.fr>  [a6d269ed9478b20f611912bf9711c2683e7bc924]

        tdf#142932: fix crash when pasting cells with comments+"skip empty cells"
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=173011
        
        4  0x00007fc4b0cdbb3d in ScColContainer::operator[](unsigned long) (this=0x872e1e0, nIndex=64) at sc/inc/colcontainer.hxx:43
        5  0x00007fc4b120d82b in ScTable::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScTable const&, sc::ColumnSpanSet&) (this=0x872e1e0, rCxt=..., rClipTab=..., rBroadcastSpans=...)
           at sc/source/core/data/table7.cxx:118
        6  0x00007fc4b0e42939 in ScDocument::DeleteBeforeCopyFromClip(sc::CopyFromClipContext&, ScMarkData const&, sc::ColumnSpanSet&) (this=0x3bffa60, rCxt=..., rMark=..., rBroadcastSpans=...)
           at sc/source/core/data/document10.cxx:75
        7  0x00007fc4b0e0b67b in ScDocument::CopyFromClip(ScRange const&, ScMarkData const&, InsertDeleteFlags, ScDocument*, ScDocument*, bool, bool, bool, bool, ScRangeList const*)
           (this=0x3bffa60, rDestRange=..., rMark=..., nInsFlag=7, pRefUndoDoc=0x0, pClipDoc=0x7d3bb40, bResetCut=true, bAsLink=false, bIncludeFiltered=false, bSkipAttrForEmpty=true, pDestRanges=0x7fff4a3da4b0)
           at sc/source/core/data/document.cxx:2916
        8  0x00007fc4b2412dc3 in ScViewFunc::PasteFromClip(InsertDeleteFlags, ScDocument*, ScPasteFunc, bool, bool, bool, InsCellCmd, InsertDeleteFlags, bool) (this=
           0x41a29e0, nFlags=7, pClipDoc=0x7d3bb40, nFunction=ScPasteFunc::NONE, bSkipEmpty=true, bTranspose=false, bAsLink=false, eMoveMode=INS_NONE, nUndoExtraFlags=InsertDeleteFlags::NONE, bAllowDialogs=true)
           at sc/source/ui/view/viewfun3.cxx:1312
        
        Change-Id: Ic119cb5d414a35a9ba18b0564d7adf83154eb9d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117497
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-22  Noel Grandin  <noel@peralex.com>  [c0643239a536ea2adc1876ef85591bb1b27abcef]

        no need to make copies of these map entries
        
        Change-Id: Ie65cbacd2806a2c030b682f8cfd473676c4f95c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117605
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-22  Stephan Bergmann  <sbergman@redhat.com>  [6b975a48e8b6dba2853e8d7eb03fbd6f8aa1aad8]

        Adapt compilerplugins to llvm::sys::fs::OF_None rename
        
        ...from F_None, which happened with
        <https://github.com/llvm/llvm-project/commit/1f67a3cba9b09636c56e2109d8a35ae96dc15782>
        "[FileSystem] Split up the OpenFlags enumeration" towards LLVM 7, originally
        leaving the alternative F_None spelling in for compatibility, but which was
        finally removed now with
        <https://github.com/llvm/llvm-project/commit/3302af9d4c39642bebe64dd60a3aa162fefc44b2>
        "Support: Remove F_{None,Text,Append} compatibility synonyms, NFC".
        
        Change-Id: Iea1192b5ee351c13ea5d6701887f3aba62133c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117609
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-22  Noel Grandin  <noel@peralex.com>  [990b2cb056788f7f412656a303456d90c003cf83]

        simplify and improve Wildcard
        
        it is faster to just process OUString data, rather than perform
        expensive conversion to OString and back again.
        
        Change-Id: Ie007b872ee507ac5c6e8b55cc0a49ef3ac1f0139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117608
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [949658028e722e5d2657b503eb20e16e41dbd8cf]

        gtk4: some initial dnd effort
        
        Change-Id: I964afbf30c75b6d8e0c31ce7fcb536814acf05b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [fde49b6c80b1f16b626554ec39da79e7bc186c87]

        gtk4: reenable some more working dialogs
        
        Change-Id: I373b9260287b229f4f3092b4c27199c2a55ea23d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [75b6ef164bac9543bdcf91f14f583a936ec43f6a]

        gtk4: GtkPicture triggers some sort of unexplained vertical expand
        
        an intermediate horizontal GtkBox works to stop the propogation
        
        Change-Id: I9fd51c3968c463c7b872b7a12bc3960602d0b025
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d3e95415e218dfe44ab85d9df501ce9fcd86ccb]

        loplugin:finalclasses in sc/.../filter/inc
        
        Change-Id: Ibaaff4cf3c7a60714f73c7f1b40a5e857060f26c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117589
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [1549a6be37f5b054c276d85c45b3fcf6a5214c20]

        loplugin:finalclasses in sc/inc
        
        Change-Id: I818a5dda788fd15a718914fb05f23e5225dce1c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d188fe4639717df47e2ff72d8c1295e23862ef9]

        create SfxHintId::SwLegacyModify id
        
        to avoid expensive dynamic_casts in writer
        
        Change-Id: Ic73ae7d4af985043f8533913b33939e3445ec7de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [612db1ec6b74bf10df8d8ce1740a8a10602f0722]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 23b0b440515592c9b9ed2fe8e64783ea55375375
          - tdf#140446 VBA constants for variable type
            
            see  /core/oovbaapi/ooo/vba/VbVarType.idl
            and comment#3 in tdf#140446
            
            Change-Id: Ib2a9743cfb1b636d1c016c8707872c291ef685f6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117598
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-21  Alain Romedenne  <alain.romedenne@libreoffice.org>  [785feddde7683a74c95d9942fb67292b6c8ae467]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff452e27c1c7f420d8a0cf8a9d82d1d318225d46
          - ScriptForge method signatures
            
            Change-Id: I5c29d5c08a8c5bd46ca45dc1d17449a0ae4789b8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116910
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-21  Justin Luth  <justin.luth@collabora.com>  [8259a221e0d090a00eb5f102406626dcc7beeb25]

        related tdf#81705 doc export: eliminate duplicating OutlineNumbering
        
        It just looks redundant. And all three formats
        handle it very different.
        RTF - never writes RES_PARATR_OUTLINELEVEL
        or RES_PARATR_NUMRULE in styles,
        only via this OutlineNumbering.
        
        DOCX does nothing. That's because there always
        seems to be a RES_PARATR_OUTLINELEVEL and
        RES_PARATR_NUMRULE.
        
        DOC does BOTH. It writes RES_PARATR_NUMRULE
        (and now also writes RES_PARATR_OUTLINELEVEL)
        and also writes them via OutlineNumbering.
        
        So OutlineNumbering seems to always have
        been partially redundant and now is fully
        redundant. Thus it can be treated like DOCX.
        
        Change-Id: Ib9fd32c440e0151b462d6499a60952f120887082
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113452
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b4ffe68dd2fc7e2f2c36bf41dd3409f000cb42ad]

        replace dynamic_cast<SwCellFrame> with cheaper check
        
        Change-Id: I672be703fb097c71303434127d832681843607e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117580
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel@peralex.com>  [218f36dd614cf828e949f605faaf6a6fd615da26]

        tdf#135316 remove OTempFileService pessimisation
        
        Closing the temp file when we read to the end, and then opening
        it again later actually is quite expensive, just leave it open.
        
        This takes my load time from 22s to 19s
        
        Also clean up the unit-test that failed, so that I can get
        a useful stack trace out of it when something fails,
        specifically
        (*) throw an exception when something goes wrong, instead
        of just writing a message to stdout
        (*) don't catch exceptions and write useless messages - just
        let the exception flow up to the JUnit handler, which will log
        a nice stacktrace with line numbers.
        
        Change-Id: If55c997f91eea4e703e92c632961d68b3453076d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117517
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [ee405fb2ef36337851801f1bd34411c606d55988]

        Delete copy ctors/assignments for DLLEXPORT class
        
        Their default definitions may create/destroy temporary OutputDevice objects,
        which requires that the class is defined at the site of instantiation of the
        implicit definition.
        
        The solution is to delete these unused methods. If they would happen to be
        needed, then move the default definitions to the correct place.
        
        This reverts commit 30a17b05fb8a860c1e53cb7cfc405b1cea0a9d15.
        
        Change-Id: I43f4e76763ff4409e9527f44cd2d8e227982257c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117574
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [a41c71838d4662adf1ada9d46ec6e070cae7e695]

        sw: add BIRT layout test document
        
        This nested table is an example that was broken by commit
        91b2239783dc716bd71ce7962bfd7e341dfe4175 - if loaded with a wide window,
        it goes into layout loop; if loaded with a tall window size where page
        2 is visible, strangely it doesn't loop.
        
        Change-Id: I5e73cfcd928ff1a321667c1a75b0ba7f348d4b77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117587
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [e3086b58eb5427d520b86c185f9d911bb6f7a3a0]

        use FileDialogHelper to set file picker parent
        
        Change-Id: I970b34fd3da12a1051343bdc26afad411121e672
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117584
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [ca2515bab1b25fc7e6a703aca1e501656a963da4]

        use FileDialogHelper to set file picker parent
        
        Change-Id: Ibca7a7d275773b816d125c38f87e902de7a5db4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [203d96787969f707c78101be18d51b44ace98f93]

        give folderpicker an optional parent
        
        so, like a file picker, it can make its parent modal while its
        operating. Otherwise its possible to interact with the parent dialog in
        undesirable ways, e.g. file, export as, export as epub, the folder
        picker of 'media directory'
        
        Change-Id: Ib61f8e630e176b6d81e80798fd0d282d16e8c086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117582
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [a8f97e5fca148804056295db2e3910aaa5c68ce8]

        bundle the FolderPicker instantiations behind a single call
        
        in prep to add parent support
        
        Change-Id: I2aa4b9343f895ae866f600dd3260b7fdc4e1efec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117579
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [efacb4bc357761f5d849a4905eff981aa14eb366]

        replace dynamic_cast<SwFlyFreeFrame> with cheaper check
        
        Change-Id: Ia84984e47c60eb8407bbddaf9e3365d9f7f52311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117581
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [2e6e87decdb87221a7b832958e03195b1d8fc133]

        replace dynamic_cast<SwLayoutFrame> with cheaper check
        
        Change-Id: I2102d27fe2b38e3787e39a2b7234991a57c30d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117578
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [3ffb7efa95d900db6fdd7d8443535988adb2be70]

        remove some unnecessary OUString::intern
        
        Change-Id: Ia0f41dfc8a00c115ad544b8236d751e6b2dae5ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117577
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [75c3fa3cfc6da7721f81c96c43e7f020346f196a]

        gtk4: set file dialog explicitly modal
        
        Change-Id: I88427abcde6c88b08c013a2502c0c25a84b970c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [f1439db62eb36ef5fbc9111b87dc4e0f24b3cb86]

        tdf#116501 sw: layout: check for flys in SwTabFrame::ShouldBwdMoved()
        
        On loading, this hits loop control
        
        warn:legacy.osl:580715:580715:sw/source/core/layout/layact.cxx:543: LoopControl_1 in SwLayAction::InternalAction
        
        This is because there's a fly frame 404 anchored at the last text
        frame 353 on page 2 inside the nested table 347.
        
        ShouldBwdMoved() sees that there is space on the bottom of page 2 and
        hence the follow flow row joined, but then it immediately splits again
        in the same way as before due to the fly with WrapTextMode_NONE.
        
        But then the outer table's cell 273 (upper of 347) is invalidated
        again, hence the loop.
        
        Try to check for overlapping flys in SwTabFrame::ShouldBwdMoved()
        by reusing CalcFlyOffsets(), which is ... not quite ideal, but perhaps
        better than copy-pasting half of it to a new function.
        
        This should have less side effects than the previous fix, but a problem
        remains that clicking on the shape on bottom of page 2 causes the layout
        to go wonky, but that was also the case with previous fix.
        
        Note there's a check of SwLayouter::DoesRowContainMovedFwdFrame() there
        already, but that doesn't help because it will only detect when the fly
        itself was moved forward, but in this case the fly remains on the page.
        
        Also likely it wouldn't be a good idea to move a text frame forward if
        the only thing of it that fits on a page is an anchored fly (i.e. its
        follow has mnOffset=0) because that can be intentional.
        
        Change-Id: I0376f7dcb784c006990336233c97f5093aaccb77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117473
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-21  Michael Stahl  <michael.stahl@allotropia.de>  [ee042a371e98cdcc59848f0b953f1ce545e18e31]

        Revert "tdf#116501 fix freezing at embedded text tables"
        
        This reverts commit 91b2239783dc716bd71ce7962bfd7e341dfe4175.
        
        This breaks documents that have many nested tables.
        
        For example Eclipse BIRT generates reports with tables nested 8 levels
        deep, they run into the counter in no time and, ironically, one goes
        into a layout loop because of this counter.
        
        Change-Id: I7451d01787903bbc60b305da3dc72f8259175e97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117472
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [46d6942bc16fb291f37b0700bb531a3e0d2d11f6]

        tdf#135316 add small cache to rtl_bootstrap_args_open
        
        Filesystem access is quite expensive on Windows, so add a small
        cache for the filepath/name normalisation.
        
        This takes my load time from 19s to 18s
        
        Change-Id: I4410d066b8a4d2fd2eb746a5dd8f4ee763a8aa3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117549
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Tibor Nagy  <nagy.tibor2@nisz.hu>  [8bf44b9cdceb7926fe52ef0bd4a38af24e7c700a]

        tdf#142590 PPTX import: fix custom slide show use as default
        
        If the PPTX file contains a custom slideshow, which set by
        default and opening in Impress, this setting wasn't imported.
        
        See also commit 312334f8488a668e9b5302959b60292ce151e4fc
        "tdf#47365 PPTX export: support loop attribute" and
        commit a4b66458a7b8da2f5580014813e5dabe3fa670b6
        "tdf#125071 PPTX: fix missing custom slide show export".
        
        Change-Id: I9c2b3773f6883ee795f119df5b8534fcdfa6618f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117172
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [9d8954197cc2b6e57db56abe18bfc782a1a715a6]

        cid#1486007 establish that SwFootnoteFrame::Paste doesn't delete itself
        
        Change-Id: Ifbc1fc73be6824917dfe91811ecb5b58409f042e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117551
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [804f4e8ae071c7a73c64b6327f251c6a649468f0]

        cid#1486243 'Constant' variable guards dead code
        
        Change-Id: I1bc2a7555f6d129526cabbebb8b88190e3ec3a4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117545
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [23c2c3433dc6bbfff2e1b590b1a89ee7f9c155c0]

        cid#1486241 'Constant' variable guards dead code
        
        Change-Id: Iec41990bbf076c0f8aaeda36ac56d3ac7ebc81d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117544
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5e9cde9f9abe3ee4e5fa0cf921d53a8cd7cb1d2]

        remove now unnecessary comment
        
        Change-Id: I0297f299c42a5ce5485cdcdebfbd1597969c907c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Mark Hung  <marklh9@gmail.com>  [10ea27faec115d4cffd6f66cee8f688399e1e0b2]

        tdf#142560 handle cached glpyh items in ImplGlyphFallbackLayout
        
        Fallback layout beyond level1 isn't generated because pre-caculated
        glyph items does not contain glyph items that needs to fallback, i.e.
        when calling ImplLayoutArgs::PrepareFallback. Hence it produce no
        maFallbackRuns and maRuns. The patch changes
        ImplLayoutArgs::PrepareFallback so that it use pre-caculated glyph
        items in the next level to create maRuns to ensure the same fallback
        layouts are genrated as layouts generated without pre-caculated glyph
        items.
        
        Change-Id: I672f3be6c4915892792b3cb968ad4a325465ccc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117105
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-06-21  Szabolcs Toth  <toth.szabolcs@nisz.hu>  [20d2c2fe481eb66f518c554f8588ec87e0ee125a]

        tdf#137000: clean-up "XML shape export: fix upright"
        
        See commit ff5ca4e5fc6a9fb24b0eb6eb629210b024473f67
        "tdf#137000 XLSX shape export: fix upright".
        
        Change-Id: Ie050da66f1eef4fc325b2acfd0a97d299c268153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117135
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [c8644ab3fcc9a911a9182a1b6a24a17610a2105d]

        make SvFileStream::FlushData __actually__ flush to disk
        
        which I noticed while debugging another change where I need
        the flush to actually do something useful.
        
        Change-Id: I61621cbfe68a404c7fae851760154b398997fe61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117548
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Balazs Varga  <balazs.varga991@gmail.com>  [11cc770ad2af1f31c1e5c9512e5688dff38f009b]

        tdf#142607 XLSX export: keep formatted dates in standard filter
        
        Do not convert the formatted string filter criteria values
        to 'double' if they are numbers (dates). Also export the equal
        relation criteria into XML_filters tag instead of
        XML_customFilters.
        
        Previously the formatted dates replaced with numbers in
        standard filter criteria, first during the export, and after
        the import, in the standard filter dialog window.
        
        Note: fix and optimize also filtering by formatted dates by
        allowing CanOptimizeQueryStringToNumber() to create double
        values for them. This unifies the same dates with different
        date formatting.
        
        Follow-up to commit 1f755525189884e4b2824889a6b9dea8933402db
        "tdf#142402 sc UI: store formatted values in standard filter".
        
        Change-Id: If4c22e8b0142720ccfda038f89367061058693aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116566
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [b30e329bfac7279d888908273baec8c7d8dd32ee]

        merge SwList and SwListImpl (tdf#135316 related)
        
        to reduce allocations when loading large documents
        
        Change-Id: I734aec4b22844e999d19f649e8e9cd5949a7cbfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117543
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [8298aa62726312eee6f8fbb64a9fc9b12680447f]

        uitest: guard execute_blocking_action
        
        so even if an assert fails, the dialog is closed afterwards
        for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac
        < UITest: introduce guarded context managers >
        
        Change-Id: I9a3adb52546238d960eeaaaf03b6bdbbd5718cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117392
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-21  Gülşah Köse  <gulsah.kose@collabora.com>  [e837f50313a703b6b26abb78f224472c1e4734ea]

        tdf#142716 Update selection after any text is inserted.
        
        When we don't update the selection after insertion of new text
        SvxUnoTextBase::createEnumeration knows old selection and losts last part
        of the text.
        
        Change-Id: I20f6530f34097ff213ff00cff617139887fd287a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117409
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-06-21  Caolán McNamara  <caolanm@redhat.com>  [09c58a90693dca506a17c93bccb292349bb20d28]

        ofz#34898 Timeout
        
        we expect the editengine to be able to select a preexisting range
        of text to convert into the symbol char, typically range is of length 1
        
        Change-Id: I13f56e716a00e243bf1c578580dc0ba31755e581
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117522
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-21  Radhey Parekh  <radhey.parekh@gmail.com>  [54170057d54e08369ca2d753df48443ac8d5c5b6]

        tdf#141908 replace sal_Int32 with Color in sc_subsequent_filters-test2
        
        Change-Id: I45e8825c6ba90b1800d656820fd9f3cbb3c13d58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116749
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-21  Todor Balabanov  <todor.balabanov@gmail.com>  [89459662bf2684a07596d4132c84e5da7e0af8d4]

        Global optimization metaheuristics sometimes are sensitive to the quality of the random numbers.
        
        Change-Id: Ibc1e95736c5f9355e67f2129a7804064e329da89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117510
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Noel Grandin  <noel@peralex.com>  [2e3046cc6fdebb52cfb1cdc114a9c2cd26bcc178]

        simplify bootstrap_map (tdf#135316 related)
        
        No need for this indirection
        
        Change-Id: I87c90c9f1a7904f5a506acac631fe5a1f52f9190
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-21  Mike Kaganski  <mike.kaganski@collabora.com>  [16231fc68973ec36c7f1e4ba5e6bef7059f9ee25]

        Replace these defines with constexpr
        
        Make CH_HYPH OUStringLiteral, because it is converted
        to OUString in ImpEditEngine::ImpBreakLine.
        
        Make WRONG_SHOW_MIN tools::Long, to match the type of
        nHeight which it is compared to.
        
        Change-Id: I5198da4134f1edf28d47f2fc060af482572f5f89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117430
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-21  Justin Luth  <justin_luth@sil.org>  [10dbee56f7cf9a19b04f484b8a4b2465323ec622]

        tdf#106541 doc import: always register listLevel
        
        LFO and listLevel are NOT a required pair.
        
        The path on the Paragraph side is safe to re-enter.
        This patch makes the style side safe to re-run
        with partial information.
        
        If we don't register immediately, then a non-existant LFO
        means that we totally lose the provided listLevel.
        So just RegisterNumFormat even though it
        likely will be run again by Read_LFOPosition.
        
        Change-Id: Iad10cdd1ff7e6fc0a77b01849b3b157703945556
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114400
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ed50df6d17d1f24ee575a9d3bac5c4a5cbf18d5f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8ac5aa2d78a907f03a19a1843ceb96f6828689fb
          - Mute L10n of code statements samples
            
            Change-Id: Id3ec35a2006614bc195812ca4ec25c8eaad85f38
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117500
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-06-21  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7e478166361248c3f3c923b9f0d18dc25d30ef15]

        drawinglayer: put BufferedDecompositionPrimitive2D in its own file
        
        And fix includes all over the place...
        
        Change-Id: I6e2696bbeeac6ab7467cac70545fa7209aa981a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117528
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-20  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2a7e64da7f385de8dbba1802530e251cf29259fb]

        Fix typos
        
        Change-Id: I70d723ea2d0cad5a28840e250ae261aab6a08bfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117514
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [e59ab5306e308ccf44ba1a3f39ec73c34b3d387d]

        ofz#34221 avoid OOM
        
        Change-Id: I1987d39ea8ff195b397b0ee3fb0e45f9bfbfb572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117515
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [f2bcf8f5b383232a4f9f345b94f4b40b646edb22]

        ofz#24932 Timeout
        
        Change-Id: I3251824ac2613ac7fd994f66effb8be26aa8a7ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117512
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Mike Kaganski  <mike.kaganski@collabora.com>  [30a17b05fb8a860c1e53cb7cfc405b1cea0a9d15]

        Include the header to workaround MSVC bug (shows with disabled pch)
        
        https://developercommunity.visualstudio.com/t/error-c2027-use-of-undefined-type-with-declspecdll/1455069
        
          [build CXX] oox/source/core/filterbase.cxx
          C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'OutputDevice'
          C:\lo\src\core\include\oox/helper/graphichelper.hxx(50): note: see declaration of 'OutputDevice'
          C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)'
          with
          [
          reference_type=OutputDevice
          ]
          C:\lo\src\core\include\vcl/vclptr.hxx(216): note: see reference to function template instantiation 'rtl::Reference<reference_type>::~Reference(void)' being comp
          iled
          with
          [
          reference_type=OutputDevice
          ]
          C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled
          with
          [
          reference_type=OutputDevice
          ]
          C:\lo\src\core\include\oox/helper/graphichelper.hxx(140): note: see reference to class template instantiation 'VclPtr<OutputDevice>' being compiled
          make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:301: C:/lo/src/build/workdir/CxxObject/oox/source/core/filterbase.o] Error 2
        
        Change-Id: I50ee1bf97b7075224525525ef074c0ffcc168485
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117507
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [6a1dea1d7a1c7ede887c66e6fd2ddecedf5404b9]

        Revert "ofz#33769 Integer-overflow"
        
        now fixed at an earlier stage so NaN isn't imported from dxf
        
        This reverts commit 71fe0aeee20640c57816dc45010d32dac9afeaaf.
        
        Change-Id: Id2689e33f89deb08e1bcd39a6d4ba38fb4663681
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117511
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Sarper Akdemir  <sarper.akdemir@collabora.com>  [0dfbdb1201c533a8fe2951cf3faf2a88f3855244]

        cid#1486005 Uninitialized scalar field
        
        since...
        
        commit 2cfccfba09faa5c3bb973136ffe99d534d09c881
        Date:   Sun May 9 20:56:41 2021 +0300
        
            tdf#59323: ooxml import: hasListStyleOnImport
        
        Change-Id: Ib5d557bc0037bb72e9635391d6991fc1d8e5f2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [6c7075ee60e799db8b8f94a6d0317ad9bcb75b5d]

        cid#1485150 suppress Uncaught exception
        
        Change-Id: Ic1b2a44afd15e0720edd48f3502dd2799795551a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117508
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [92741976101e8224291cf9af492209ff5412ca7b]

        cid#1486006 help coverity see that pGlossaries won't be null
        
        Change-Id: I0f0e8e5ac0169090cd1f99c8aa6bf16b1edf8a85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117506
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Caolán McNamara  <caolanm@redhat.com>  [999136c0d0a9964b4db40123e81aaf78229d10c3]

        cid#1486008 Explicit null dereferenced
        
        since...
        
        commit 0771ac00acc8730f77db76b901724f1513a32723
        Date:   Tue Jun 15 21:12:25 2021 +0200
        
            use string_view in the Translate API
        
        Change-Id: Icb069f3662f5899e404784909d06088d88eabd78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-20  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [81e3d9daed06c0f1153d4d18181cf986a7f82fca]

        drawinglayer: remove ImplPrimitive2DIDBlock macro
        
        We can just implement the simple getPrimitive2DID method in all
        primitives. The ImplPrimitive2DIDBlock macro doesn't save us
        anything.
        
        Change-Id: I02f44d4891d7b340220890bf52a7ebfc8e41850a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117509
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-20  Todor Balabanov  <todor.balabanov@gmail.com>  [ffef53274b44bfe77128ba400845f4c4ce70893e]

        It is a good practice single source of random numbers to be used.
        
        Change-Id: If76e247461288a9ed938b4f6cb592c814b8bbe2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117406
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Noel Grandin  <noelgrandin@gmail.com>  [4668e7e7a6322cfda854ab07eabd4322c86de980]

        use more unique_ptr in WW8Export
        
        Change-Id: I4fb6f4d42be350df5c1ccc0c87b779224000325d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-19  Noel Grandin  <noelgrandin@gmail.com>  [5c59e061c6271cfe2f8ec12ba21de50e71bd9ef4]

        SvMemoryStream::GetSize can be more efficient
        
        Change-Id: I6d60d6549089e049d730c1000ab7ec592924c685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-19  Justin Luth  <justin_luth@sil.org>  [b85491e40ccb83ff78c7c4b2c0d535eafa5d23ed]

        tdf#142404 DOCX c15: handle remaining TabOverSpacing tabs
        
        The previous commit handled the case where a non-first
        LEFT tab was beyond the text area. But the remaining
        cases were still being (mis)treated as automatic tabs.
        
        We won't worry about the impact where compatibilityMode
        is less than 15/2013+ since Word is absolutely goofy,
        and LO doesn't even come close to matching it.
        
        But in compat15 mode, the end result of having a
        non-LEFT tab over the margin effecively means that
        the text will flow backwards from the right margin,
        just as if it was a RIGHT tabstop. So treat all of
        the remaining tabs as a right-tab at the end of
        the paragraph-area.
        
        Change-Id: I43a38516c0639c56341bdba0213ffb4a7d5cbf3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117340
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-19  Justin Luth  <justin_luth@sil.org>  [ce762a7ab170aa1115cfb0dd68f1c50abf5a86f3]

        tdf#106541 doc import: inherit style numbering from parent
        
        This patch depends on FOLLOWUP patches.
        I thought the best way forward is to break
        the existing unit tests, and then fix
        them with followup patches. That best proves
        the validity of each follow-up patch.
        
        This patch is especially needed for Chapter Numbering.
        In LO, Chapter Numbering is treated uniquely with its
        own special rules that run counter to all other
        conventions. So special handling is needed to
        import styles that in MS Word would inherit,
        but which don't in this special case.
        
        Change-Id: I06b737ad96ff73dbd09bef252d09aa42adf2dc76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114401
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-19  Jean-Pierre Ledure  <jp@ledure.be>  [8be08b6d1f53136d899a8aac3ccd401eb18990e9]

        ScriptForge - (SF_Exception) Fix signature in error messages
        
        Basic use ProperCased arguments, Python lowercased ones.
        The error messages always displayed the ProperCase notation.
        
        Example:
        
        BEFORE: called both from Basic or Python:
        Library :   ScriptForge
        Service :   FileSystem
        Method :    OpenTextFile
        Arguments:  FileName, [IOMode=1], [Create=False], [Encoding="UTF-8"]
        A serious error has been detected in your code on argument : FileName
        The given file could not be found on your system.
            FileName = /...
        
        AFTER: called from Basic, as above, and from Python:
        Library :   ScriptForge
        Service :   FileSystem
        Method :    OpenTextFile
        Arguments:  filename, [iomode=1], [create=False], [encoding="UTF-8"]
        A serious error has been detected in your code on argument : filename
        The given file could not be found on your system.
            filename = /...
        
        Minor user visibility. No need to cherry-pick to 7.2 branch.
        
        Change-Id: I6938c3149fe883ded97051897c19aca23eadcc58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117501
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-19  Noel Grandin  <noelgrandin@gmail.com>  [7af0f1514407660a43cde90320bbe00c36c3be28]

        use more TellEnd()
        
        which has the potential to be more efficient than STREAM_SEEK_TO_END
        
        Change-Id: I64d84632bc4751e07309332c9dff7a02bcd507fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8fa14ac550ddc43790b65858f18d23f522aff1f2]

        fix loading calc files with embedded form macros
        
        GraphicHelper was trying to use the current frame/
        window to convert values, but during initial load
        there is no current window.
        
        Change-Id: I8a79501df1d2e83a13d3cfb64ae8e66152c60561
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117470
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [e3077168072452fb8f1c0a8afb2992877cb96d1c]

        loplugin:finalclasses
        
        improve the plugin to detect more cases.
        
        I only apply the new final changes to classes in /include here.
        
        Which reveals that
            RoadmapWizard::getPageController( TabPage* _pCurrentPage )
        will always return nullptr
        
        Also needed to sprinkle some
           SAL_DLLPUBLIC_TEMPLATE
        around to workaround Visual Studio linking problems.
        
        Change-Id: Iadb7d46a9e0e73dabce562375ca013c0fea6690c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-19  Jean-Pierre Ledure  <jp@ledure.be>  [e48dd86341fff8a010f514bbcd818468f3a92815]

        ScriptForge - (SF_PythonHelper.xba) fix signature of PyInputBox()
        
        The last 2 arguments have resp. XPosTwips and YPosTwips
        as names.
        
        The signature in Python is correct.
        The signature in Basic still used the XPos and YPos names.
        
        No visibility towards users.
        No need to cherry-pick to the 7.2 branch.
        
        Change-Id: Id93de702cbcb0f3ae72a1f95247189299cb7cf30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117482
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-19  Kevin Suo  <suokunlong@126.com>  [5d4b54a7e1b78598501ad86c855d662652be7c8e]

        Update of TSCP example file for Simplified Chinese (zh-CN)
        
        See l10n discussion in:
        https://listarchives.libreoffice.org/global/l10n/2021/msg00193.html
        
        Change-Id: I8ced7f4128b6e633d35770759fa4b82e03356084
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117285
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-06-19  Johnny_M  <klasse@partyheld.de>  [99f86f684668e58288a309ea4c19194a45ea7f8f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6d1742d64d55f6c17d534736d2a3a246a8cb586b
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib0b47a24b5a00817c362a00c2d012e2f016c48a9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117494
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [cc85b8dd0a5c4ebf66260c109263aed88e688960]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a266b7f4792c4e9d1395a42dd21de65a7da126ef
          - tdf#132643 Translate German section IDs
            
            Change-Id: I9e7c85119e976ca50c0eba0222da7b59decaf95b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117493
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [bfa8ead3a6fdd705708391b9ad4e815ddf4a8c84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2c1e086cb2c4826b6c467aa47764558252b0f201
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifc33de45cbafddc888b6b110faca31ed4bb4973f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117492
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [067733420616368c94ee0a648d766ccd33f8d8d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6766947a3c6364d28f6869d33e5d64575572591c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I334f06af676139fbee080dd069d06b42405e127b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117491
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [3d52d6dd8cd9df456a1ff29ba929a08b39728324]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8357e8f9d823baeb287b333e711aa184c4a794dc
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ic9dc645c15d57e99a8eb737b89631f570124eefb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117490
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [8642530da07ce9624f6d082dbedfcad1a3722dc6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 664d9f3313c80b50b33a2e4b40d8ddc117156e99
          - tdf#132643 Translate German section IDs
            
            Change-Id: I98bb4c457b8436e76f2acb17dceb9b3906c37e9e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117489
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [9c94d3a5b2110abd1ff13b9f19f3c56c0e3260b5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 10cb0bf55cacce740d62a5c6786b1e3b11f4f865
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifd14ec7f7efc1dcacd5f8c266f33823521fcb7c6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117488
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [f8b5194a5546a532f2c7e969146b99624f332071]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c9762d21f1e509da34ad98cd02d8d541ce9ef9b
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie3c785d133cc23d5300134923c53ea9905e0dc8e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117487
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [d982592c29316f76e6d581a3038e13385e01d814]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ffac115a446056f3df4ab44694052ba050e9d8f3
          - tdf#132643 Translate German section IDs
            
            Change-Id: I5e90b17cb74fe61b62296ba6cba946d6cf921cae
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117486
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [8ce0e7f44475904e0617b1c794073b0f8d058bcb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 28f2b50aabb1dc3407db1208c4c60b8d9102d789
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7a0f5d39d3440d84bffb8a734d6868fcf39656fd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117485
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [770726b7c8dc3b5c751ee7e319edea33f398ad7b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e3bf73d11f3cf22f2529daa4daf2f7b0412fe478
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1774f47b3e2e64ff9dc86279368be4606e820a52
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117483
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Johnny_M  <klasse@partyheld.de>  [685cd3b2a2a372d637fa7e9ac30011a4cdcc456f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 14865d1d877ecd5c15dcf68ff9312d7321714d89
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0e0c3c23cb70b01cbf6dd0bc6dd46a12fd721d3f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117484
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2ce10eedfb1de8beef8ddfa457f1e19545846f86]

        indexing: indexing sections for the IndexingExport
        
        Adds handling of sections to the IndexingExport. SectionNode also
        derives from StartNode, so we handle it similar as the tables.
        
        Change-Id: I5eb8d599bdf680144b161aa93295ea3d360eb5c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117452
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [705fe1c44b41cd11518069e0627d0f48a65a7dfc]

        indexing: write parent index to paragraphs if possible
        
        When writing paragraphs from a table we want to associate the
        parent table to the paragraphs so we also write the parent index.
        
        Change-Id: Idf9c285f08481ed0556700e92adda27027b91408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117451
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b3a62ab0a43510cf43c88aa4d6e145e46db7e7e5]

        indexing: indexing tables for the IndexingExport
        
        Adds handling of tables to the IndexingExport and also handling
        of the end node (as table node is also a start node), so we know
        which paragraphs belong to a table.
        
        Change-Id: I624ce12a3e810797a37ae2efe5baa552828f75dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117450
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c23408aeafc1f2ce3f7dde685d0b519d8e2daff7]

        indexing: indexing shapes/text boxes for the IndexingExport
        
        Adds handling of shapes and text boxes to the IndexingExport with
        exporting the the name, alt text, description and paragraphs of
        the inner shape text to the indexing xml.
        
        Change-Id: I3db68078b7e793cab552b4f7f8e8ddf9bfd1a6f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117359
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [37cd5bd4fdf2317709882c933844c4cc67e4cee4]

        indexing: indexing OLE objects for the IndexingExport
        
        Adds handling of OLE objects to the IndexingExport with exporting
        the alt text and the name to the indexing xml.
        
        Change-Id: Ie357f55195cda864ee12d6b120babd106eff6179
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117358
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f81115740bac985cad3cd15348f75c2c78b8843a]

        indexing: indexing graphics for the IndexingExport
        
        Adds handling of graphics to the IndexingExport with exporting
        the alt text and the name to the indexing xml.
        
        Change-Id: I20344dd04c5da4668c8eafbf1f863a26357ad616
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117357
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [686c35a3c37674d08c1f8585a621143c959b3f29]

        indexing: indexing paragraph text with the ModelTraverser
        
        This adds the basic paragraph text export for indexing, which uses
        the new ModelTraverser, which is inspired by AccessibilityCheck
        (and in the future it will be changed to use the ModelTraverser
        too, when it matures). ModelTraverser implements traversing through
        the model and executes a handler for a element of a model (which
        can be various things).
        
        IndexingExport class implements indexing export that uses the
        ModelTraverser to write into the indexing xml document, that uses
        the tools::XmlWriter.
        
        Change-Id: I7a6a5de332534270fe894a881131e5eb5ea9d881
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117356
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e6cb7f9ab25bca32dc85aef8ff127e070cd109b6]

        svx: prefix member variables for SdrTextObj and others
        
        All classes in svdotext.hxx
        
        Change-Id: Ib15deca2a625d8352a2572d9fc3e15188b4e718a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117478
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [39a3c0bd8007917d42a58d9337b4d06590bcf306]

        svx: use constexpr instead of a define for a constant
        
        Change-Id: Ie2fdd0dbe2c6d8e5c9ff406af5d2be20383fe62b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117477
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ffe4538fe4e59e31994511b1117dcd5967f2e2b0]

        svx: prefix member variables for SdrCreateView
        
        Change-Id: I4fb067201d3285b8aad8877bba2f018aab41c026
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117476
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-19  Jean-Pierre Ledure  <jp@ledure.be>  [6de7707236ea918d94f321587cb1a728a42e0892]

        ScriptForge - (SF_UI) GetDocument() accepts component object
        
        SF_UI.GetDocument() has 1 argument.
        Before, must be a string designating an open window
        Now, also a UNO object of types
           com.sun.star.lang.XComponent or
           com.sun.star.comp.dba.ODatabaseDocument
        
        Typical usage: pass ThisComponent or ThisDatabaseDocument
        as argument to create a new SFDocuments.Document/Base/Calc service.
        
        Change-Id: Id9e0a40425dc3ce5e83953af5da4fb7ef8dd6f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117442
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-19  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d32a9f90e85a5cfa9ffd629494de3c291282454e]

        svx: remove whitespace in member variables
        
        Change-Id: Ie841bd3c9449ac7b227ae6adc4df49ad452b59ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117475
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-18  Stephan Bergmann  <sbergman@redhat.com>  [5fb7f66d240fec32a4751d331a215307ad994cbb]

        Simplify a OUString construction
        
        Change-Id: Ie7bf010f6864db19b7cc64761b34e203ce70784d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117458
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-18  Stephan Bergmann  <sbergman@redhat.com>  [90f872b4c9eac6ea1955876ff292a962f95577dd]

        Simplify a std::string_view construction
        
        ...and combine three calls to SvStream::WriteOString into one.
        
        Despite its name, SvStream::WriteOString takes a std::string_view, but which
        cannot be constructed from a u8"..." char8_t string literal.  Besides the
        OStringLiteral detour, other fixes could have been a
        reinterpret_cast<char const *> (but which would have defeated constexpr'ness of
        the std::string_view construction) or a plain "..." char string literal with
        the UTF-8 encoding of \uFEFF spelled out as \0xEF\xBB\xBF.
        
        Change-Id: I029f061134381a67516cbc4b0479942684c80c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117461
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-18  Stephan Bergmann  <sbergman@redhat.com>  [568fba4a439f39aadeeb1bcd3603ef4efe9700da]

        Simplify some OUString construction in test code
        
        Change-Id: I1891f5e676818b5657b7ee7a7563f217a1af65cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117457
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-18  Stephan Bergmann  <sbergman@redhat.com>  [25ba5f75a273540ce5e21fc0f14ea1a7b997888d]

        Workaround only for GCC 10
        
        Change-Id: I7425dfd674149b33e069bf20c1ff6a4ca622db20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117453
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [d95e400b5fffb10e716f5b27caebb4eae5fd5cc7]

        gtk4: implement removing an entry from MenuButton menu
        
        and enable a bunch of now working dialogs
        
        Change-Id: I42d6731cf4535e4a4867d4177590939a1cc395f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117468
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [8e54bc168f828a243919b9f22338e8369ddbb2fc]

        move the explanatory image outside the RadioButton
        
        Change-Id: I90425bec7418a26959241b670f63a5f4a4bb0fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117460
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [86dba4704c416a63ec2015e9d4240fc058642768]

        resave with latest glade
        
        Change-Id: I4c576eb1bdd8476f5bd4de4c5cd0be0af3817fe2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117459
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [929575f56b665ee212bb4e7cf29ecf78ed8cc461]

        help button should be packed as 'secondary'
        
        Change-Id: Ia5f2e0c6c8d818e6d0e80acde2c518da30371eec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117456
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [c04c904905de9099b9fc06b7ef4c9111acd6a83c]

        resave with latest glade
        
        Change-Id: I4c817f06c69f2442b0b0ecb63d42c87db439751f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117455
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [216a43bc1799221d53e1f3a590309aaa63b6c9dd]

        tdf#142852 forward surrounding-text requests to an active drawing editengine
        
        when present.
        
        As we do for related CommandEventId::[StartExtTextInput/EndExtTextInput]
        
        Change-Id: Ie5b57c8a8a1a258efc2be079a2674b1ca620dc9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117465
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Justin Luth <justin_luth@sil.org>
        Tested-by: Jenkins

2021-06-18  Julien Nabet  <serval2412@yahoo.fr>  [c21398066b6bf630070ed291456f2663e06d94b9]

        tdf#142873: Fix print preview zoom-out zoom-in buttons
        
        .uno:ZoomOut has been renamed .uno:ZoomMinus
        .uno:ZoomIn has been renamed .uno:ZoomPlus
        
        Change-Id: I06e7e66550399e53032a0df39a98846982acba48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117279
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-06-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [47ad429645c63a8d5c88c2827aa90a27c8aa3e1b]

        Fix typo
        
        Change-Id: Ibcbd13ccc4e257e8b1777bd362279211d4a2a0db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117471
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-18  Justin Luth  <justin.luth@collabora.com>  [83dc9d3b77f9f6b03af0e7a4be4805e4ecf12145]

        related tdf#140336 docxsdrexport: always clear vmlTextFrame attrs
        
        Blind fix - it just doesn't look right, and caused troubles
        when making a patch for bug 140336. When the VMLTextFrame is
        written out, surely the collected attributes for it should
        be cleared instead of spilling over into the next
        non-textbox-only VMLTextFrame.
        
        I expect the textbox-only frames never have any gradients or
        SOLID fills, so it has never been a problem yet.
        
        Change-Id: I3aa23aadf9ab5a0be54ffbd7ea114f94c48aaddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113206
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-18  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [840095f417af6619977f688f421e449273c26cae]

        tdf#109083 sw table styles: fix missing format update of tables
        
        at table (cell) selection.
        
        Table styles (implemented as table templates yet) allows
        to format all tables (with the same table style) at once.
        Unfortunately, this worked only without table selection,
        putting the text cursor in a table cell. But if a table
        cell/row/column or the whole table was selected (e.g. after
        changing its format), Manage Styles(F11)->Table Styles->
        Style actions menu (see top-right corner of the pane)->
        Update Selected Style updated only the style, but it
        doesn't propagate the changes to the other tables with
        the same table style. This patch removes the selection to
        fix the problem in the same way, as the proposed workaround.
        
        Note: this fixes the usage of the user-defined table styles,
        too (created by Style actions->New Style from Selection).
        
        Change-Id: I58d01036d5a11e522407405e9ebc16c2c3c83e9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117079
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-18  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [e48463e81c7eb9a3938128b642d153917fcbbdae]

        Resolves: ofz#34920 allow displaying only one text string
        
        Change-Id: I8bc4ed015dfad4fd99ca8cfce7fca0e7b411edf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117443
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-18  Rene Engelhard  <rene@debian.org>  [51754ca5349d7bf655d57ded37381188d0bc4bcf]

        more 32bit build fixes
        
        Change-Id: I5906ef714a482afffe40e59e90fd709fe857d3ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117404
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: René Engelhard <rene@debian.org>

2021-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2488a301621fadee7713f3e886dc6f756f745bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8123db33c8086173ff601019b26cab5881d435d7
          - tdf#123803 Add Available/Supported since version to ISO.CEILING
            
            Change-Id: I2a91274ca1d3f64850a45c32b47b52e02feb92d7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117466
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [cbb742672ba61b5b06d2cba18dceeae728e55463]

        gtk4: use state-flags-changed for gtk4 GtkMenuButton toggle also
        
        Change-Id: Ib953d9d01482bedff62f11a18e69268e34099dc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117438
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [95a327846aa12474cc982b275a9ad7dec16841b5]

        tdf#142924 "toggled" is too late to use to populate changes to the menu
        
        so use "state-flag-changed" on GTK_STATE_FLAG_CHECKED instead which
        happens before "toggled"
        
        Change-Id: I3a68212ce4bec2cda49d8bcaf3db864cb34013cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117437
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [7d1e91f43f8f5963475dcac954e47b35efb00e20]

        hold SvtSysLocale for lifetime of returned GetUILanguageTag reference
        
        Change-Id: I36b01e6b4827aceca95502386ab1abc4cf0baaea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117449
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [53fa4f61820e3fa9a92c5874ea641b54fe564f02]

        gtk4: enable some more working dialogs
        
        Change-Id: Icc5d42c55763ed937d8b25dd89ae33e1a85b5a39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117448
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [a8db26a6795703e48c34f9edbb09fdf6fe279f6d]

        ofz: fix use-after free
        
        https://oss-fuzz-build-logs.storage.googleapis.com/log-380241bb-ed71-4d4a-93d3-00473e186d65.txt
        
        since...
        
        commit 2bccb7e67b637c6312a0df610f870c8621eb296f
        Date:   Tue Jun 15 09:02:59 2021 +0200
        
            remove some unnecessary LanguageType copies
        
        reproducible with:
        
        LD_LIBRARY_PATH=`pwd`/instdir/program valgrind instdir/program/fftester ~/demo.html html
        
         Invalid read of size 8
            at 0x1CC35A38: rtl::OUString::OUString(rtl::OUString const&) (ustring.hxx:191)
            by 0x1CC60F37: com::sun::star::lang::Locale::Locale(com::sun::star::lang::Locale const&) (Locale.hdl:17)
            by 0x1CD5AF77: LanguageTag::LanguageTag(LanguageTag const&) (languagetag.hxx:113)
            ...
            by 0x1D195944: SwStyleNameMapper::GetChrFormatUINameArray() (DocumentStylePoolManager.cxx:2683)
          Address 0x261e5d38 is 136 bytes inside a block of size 240 free'd
            at 0x4843669: operator delete(void*) (vg_replace_malloc.c:802)
            by 0x4BE7F8C: __gnu_cxx::new_allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> >::deallocate(std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) (new_allocator.h:145)
            by 0x4BE7F64: std::allocator_traits<std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> > >::deallocate(std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> >&, std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>*, unsigned long) (alloc_traits.h:492)
            by 0x4BE7A43: std::__allocated_ptr<std::allocator<std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2> > >::~__allocated_ptr() (allocated_ptr.h:73)
            by 0x4BE7D40: std::_Sp_counted_ptr_inplace<SvtSysLocaleOptions_Impl, std::allocator<SvtSysLocaleOptions_Impl>, (__gnu_cxx::_Lock_policy)2>::_M_destroy() (shared_ptr_base.h:538)
            by 0x4B0A5D3: std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_weak_release() (shared_ptr_base.h:207)
            by 0x4B105B0: std::__weak_count<(__gnu_cxx::_Lock_policy)2>::operator=(std::__shared_count<(__gnu_cxx::_Lock_policy)2> const&) (shared_ptr_base.h:808)
            by 0x4BE7FF2: _ZNSt10__weak_ptrI24SvtSysLocaleOptions_ImplLN9__gnu_cxx12_Lock_policyE2EEaSIS0_EENSt9enable_ifIXsr20__sp_compatible_withIPT_PS0_EE5valueERS3_E4typeERKSt12__shared_ptrIS6_LS2_2EE (shared_ptr_base.h:1662)
            by 0x4BE6EC0: _ZNSt8weak_ptrI24SvtSysLocaleOptions_ImplEaSIS0_EENSt9enable_ifIXsr13is_assignableIRSt10__weak_ptrIS0_LN9__gnu_cxx12_Lock_policyE2EERKSt10shared_ptrIT_EEE5valueERS1_E4typeESD_ (shared_ptr.h:733)
            by 0x4BE5A64: SvtSysLocaleOptions::SvtSysLocaleOptions() (syslocaleoptions.cxx:544)
            by 0x4C54323: SvtSysLocale_Impl::SvtSysLocale_Impl() (syslocale.cxx:63)
        
        Change-Id: I95dfd56c5d445220918e4bfa9216a72317fd8421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [e8dac3bd339383876bbe42f3e9559df4b13b6d91]

        tdf#142925 render the button arrow like it used to be
        
        in 7.1
        
        Change-Id: Ibbe4b7dd2212d1bc28bad7588672bb37c8259605
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [94d552f94b427f884c004dba5d4619ecf729d605]

        rename signalToggled to signalMenuButtonToggled
        
        Change-Id: I10a4d08d2c4cc7482e0a46a4a1039918ef4dc51f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117436
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [2b360084eea51024dcc40c214d0d4f684e981496]

        rename m_pToggleButton to m_pMenuButtonToggleButton
        
        Change-Id: Ief2f877e563e43c55a72578b7ea968de3ad38253
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117434
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [e8c4e392890989028859cd158b82769ae808bf8c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36f11255d965e5e2c4dd1d9fd06ca3a9f0874f16
          - Fix typo
            
            Change-Id: I210bbae510357b463c6f7972dc754fd227d0a705
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117401
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-18  Katarina Behrens  <bubli@bubli.org>  [7a717c8b9319edcc12e50ab78554b8e0e7049cbf]

        tdf#141311: Rotation spinbox in sidebar used to have 2 decimal places
        
        regression from weld-ing (c85fcc6e1994eb8e079aaca85066ab4d67149c15)
        
        Change-Id: Iad0725fd4542ecdddb65092846dbf9d103016d9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117408
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [f11195aa32035ceeb1271667f5ad5e35847acd0e]

        avoid maybe-uninitialised in FontConfig
        
        triggers inside the std::optional<PrintFont> with gcc 10.2.0
        
        Change-Id: Id34e46ddfff447cb48b886003f04203979c30732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [af8bf1b96ac1d994fd0376cc1047febf29c0c33f]

        remove translation from SfxStyleFamily to char
        
        which seems unnecessary and just makes the code harder to read.
        
        This goes as far back as the 2001 "initial import" commit
        
        Change-Id: If98ce4da15e57ead9714a0796bfd8c182b9ca49a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117407
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [4ba3abf003c195831c7100a89762e501b99888ff]

        rename m_nSignalId to m_nToggledSignalId
        
        Change-Id: I8340eeb222cca00b1d9133f0313a264abe2d3227
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [cbe51e9f023c9f25833e16add1bfd738db5cade8]

        resave with latest glade
        
        Change-Id: Iaf01858e74cecea966da4c81d060419b9d16c3e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117432
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Caolán McNamara  <caolanm@redhat.com>  [552ec69c9ed8ec44a90f1f387773d0229c4d623a]

        gtk4: submenu-action should be good in 4.3.1
        
        which fixes this problem and the greater problem of toplevel
        menubar menu items never changing state to become active
        
        https: //gitlab.gnome.org/GNOME/gtk/-/issues/3721
        Change-Id: I72c13c1ad1089c8b2ca48bdb6c35748c756bc931
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117411
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-18  Jean-Pierre Ledure  <jp@ledure.be>  [7c0d8c646b8fd3e31c325ac4dd6636a2ce684be2]

        ScriptForge - (scriptforge.py/CreateScriptService) allow keyword args
        
        For Python scripts only:
        
        the CreateScriptService() method accepts now both positional
        (as before) and keyword arguments.
        
        The impacted services are:
        - database
        - dialog
        - document
        - base
        - calc
        
        Done with the ReviewServiceArgs() class method that returns the
        input arguments as a tuple in the correct sequence. This method
        is inserted in each of the impacted service definitions.
        
        Change-Id: I545ca5ef0a4e7946d598eed07a2122885e4f864a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117387
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-18  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d50501d1b4c015232c31c75a16b96143d43f7a3f]

        tdf#127864 - Export custom document properties using utf8 text encoding
        
        Change-Id: Iaca1f9251e87ec199b55888c1ab6421a654d1f9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117071
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-18  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [04cd6749177f886f382e8bcd026f95112ee22473]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        Rename ::StateChanged methods using SfxItemState to allow
        better analysis of SfxItemState/SfxPoolItem usage(s),
        discussion see tdf#130428 comment 30
        
        Change-Id: I736be0160ad7a9b7882c1c8a4cc05d9396ee3305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117366
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-18  Christophe JAILLET  <christophe.jaillet@wanadoo.fr>  [6317f8cc83ec92b8700785ab67c4c66ed1aa8fb2]

        Re-add a removed mutex
        
        In commit b33fbd55d630, many getMutex() have been replaced by an equivalent
        maMutex.
        Only in place, the use of a mutex have been simply removed.
        
        Restore it as done in all the other places
        
        Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
        Change-Id: Id85e74e166ec57dd37f8913f8ecf19e2b6465f8f
        ---
        This patch is completely speculative. The removal of this mutex was maybe
        done on purpose.
        This only looks spurious to me.
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117402
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-18  Gopi Krishna Menon  <gopi.menon@collabora.com>  [781c70a8c87878ac0e53c9c4619a4d19d3d737de]

        Add Last 4 UNO Commands To CrashReport Dump
        
        Adds last 4 uno commands executed in CrashReport to assist in investigating the crashes
        
        Change-Id: Ib7307ffc62d6d51d52f9d5e7fabefc2eaf858e5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117388
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c24e7ed972ae2fc431365e4884e27c0b243c905]

        avoid maybe-uninitialized in PowerPointShapeExport
        
        /home/noel/libo3/sd/source/filter/eppt/pptx-epptooxml.cxx: In member
        function ‘oox::drawingml::ShapeExport&
        oox::core::PowerPointShapeExport::WritePlaceholderReferenceTextBody(oox::core::PlaceholderType,
        PageType,
        com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>)’:
        /home/noel/libo3/sd/source/filter/eppt/pptx-epptooxml.cxx:1715:31:
        error: ‘nDateTimeFormat’ may be used uninitialized in this function
        [-Werror=maybe-uninitialized]
        1715 |                 SvxTimeFormat eTime =
        static_cast<SvxTimeFormat>(nDateTimeFormat >> 4);
              |                               ^~~~~
        /home/noel/libo3/sd/source/filter/eppt/pptx-epptooxml.cxx:1707:36:
        error: ‘bIsDateTimeFixed’ may be used uninitialized in this function
        [-Werror=maybe-uninitialized]
         1707 |             if(ePageType != LAYOUT && !bIsDateTimeFixed)
              |                ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
        
        Change-Id: I7f622321680705fb0b0fa42630949c8d6af8488e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117398
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [4968b6484707cb40b70a3115084e19433d1fec7f]

        loplugin:finalclasses in sw
        
        Change-Id: I5f228e839e0d5a51ece868b55715b04f0affc28d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117397
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-18  Gopi Krishna Menon  <gopi.menon@collabora.com>  [a3d89265e0be3f9ee8ae813e4aeaa90af1714348]

        Add Active Sfx Object Name To CrashReport Dump
        
        Adds Active-SfxObject field in CrashReport to assist in investigating the crashes
        
        Change-Id: I08637a66ae95977e7afe4f5dce634b46c928a423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117318
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-18  homeboy445  <akshitsan13@gmail.com>  [07e269f2596756bf841bbc380929bcffc3ca6bc6]

        VCL graphics rendering tests that a run on LO version change
        
        This commit includes the implementation of graphics rendering tests
        which would be automatically triggered at first installation or upgrades
        of LibreOffice.
        
        These tests check the graphic rendering interface of LibreOffice
        by drawing and checking various graphical rendering tools (eg:. by
        drawing lines, polygons etc.). After the successful completion of
        tests, their results are stored in the user folder for future
        reference.
        
        Change-Id: I59c94b57a1f3f3a9cba55af1067a9702b6da98d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116779
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-18  Mike Kaganski  <mike.kaganski@collabora.com>  [3fc41a91ce3bd9d6756905809e261499a51d9774]

        Use std::fesetround / std::nearbyint for half-to-even rounding
        
        C++ floating-point environment has thread storage duration, so
        std::fesetround call is thread-safe.
        std::nearbyint uses half-to-even rounding with FE_TONEAREST,
        as specified in ISO/IEC 9899:1999 F.3, and in Appendix to
        ANSI/IEEE 854.
        
        Change-Id: I26995842c30e2663b40af5b5314791c1328037d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117307
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-18  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a78510ab673dd0d827efeb00873d5d9137813be7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f46ebea0276ae94bc299cb4c2bbf4a5b3d69173b
          - Mute l10n on some internal field names
            
            Change-Id: Ie794e15c31def6111eccd83f3e7a744984045cf6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117403
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-17  Stephan Bergmann  <sbergman@redhat.com>  [a07339b108275dde1769f86404515b0f19e98f2d]

        Add RemoveWhichRange unit test
        
        ...following up on the TODO in the commit message of
        541f94df85756d3a383b1f9ba49841ca0011b52e "memcpy-param-overlap"
        
        Change-Id: Ib1f73b867eb3625e66a5040122e53a4a6e486802
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117385
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-17  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [960b2878cb504f10a27b24714d3c81bba6f48634]

        don't ignore dump_syms errors during symbol extraction
        
        also fix the file filtering in case directories are passed for recursive
        traversal (pdb files are not created in instdir, so that never really
        matched our build-env)
        Pass a directory to the invocation to make use of that filtering, and
        also add a retry in case dump_syms segfaults during processing
        (see also 73299faa75a4974eb49c93ffdfb2d6329cb4e519)
        
        Change-Id: I8989c3fd72de0b18eecce490fac81db956f87515
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117386
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [b5eb15a21d89d5c4bb45122f68e68944ab8ffe42]

        gtk4: reenable a cluster of working dialogs
        
        Change-Id: Ida6e77c17681d9b1b5c0b7d6f6641974e097edbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [c88e44e5c2d6a3cfc8752295c48809c97ad5c53f]

        drop the bare set_busy_cursor, the scoped WaitObject is enough
        
        to set it back to its default on leaving the scope
        
        Change-Id: I303c201a1830ef24955fe35ad1058d6d88067f4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117394
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [560492cf578182df083fb8906a20994b3182a980]

        gtk4: get the cairo_font_options from widget pango_context
        
        in the absence of gdk_screen_get_font_options
        
        SalEvent::FontChanged is successfully firing for me on changing hinting
        in gnome-tweaks font section.
        
        Change-Id: I035a07d585b59822b08c801283321ab2582649aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117393
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [3a2d142b99cbd57bacda8746541d4cdb4216adeb]

        gtk4: listen to display's setting-changed
        
        in the absence of style-updated
        
        e.g. changing theme to a dark/light should change the brand image
        in the start center
        
        Change-Id: I7242019069b13093fee1430ade816a48fc0687f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117390
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Justin Luth  <justin_luth@sil.org>  [7d186c0510b18d12267fc9d930298eadd1cadb8e]

        NFC sw PropagateOutlineRule: early exit if no outlineRule
        
        There is only one outline rule, and we are just getting
        a pointer to it, so there should be no reason why
        this is retrieved for every style defined on the system.
        
        Just get it right at the beginning, and exit if there is none.
        
        Change-Id: I09d122481623dd4667e3f67c5de98164ff106a27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115615
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2fad86dea0075a98d2d34bf43780611dd986dc68]

        Fix typo
        
        Change-Id: Ia84c47ea309734f27fd492ba791d88200408f105
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117361
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [73db169bf3ce6596ce9eaff4ee99e90dbfc3010a]

        Removed executable bits on pptx file
        
        Change-Id: Icd927660130f72a077c12a38914b3fe8d0ab7d28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117360
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-06-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [3620fda235e8b02dea8e225215d53f4c64d1348e]

        tweak tools::Color::IsDark so it triggers on Ubuntu
        
        in dark mode, otherwise some of the UI elements e.g. the start centre
        brand image, do not display the right version
        
        Change-Id: I3bfdc597324b564a9dbd47174332bb5f21b6a052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-17  Noel Grandin  <noel@peralex.com>  [ecbdb403d16f6b0aeb8b543e069e9d82adf10437]

         tdf#135316 docx open performance, cache next character style name
        
        so we don't have to scan the list repeatedly, which is O(n^2)
        
        This takes my load time from 37s to 22s
        
        Change-Id: I0df2f2ace82f5cd6287c7ded796b02c5242269ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117396
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-17  Todor Balabanov  <todor.balabanov@gmail.com>  [72cd9250a80bc2db61b1f90217f2f7fdc0d51bcc]

        A separate function for getting a random search point is a little bit clearer.
        
        Change-Id: I2d7471440cdee096b09ce704cbea3d5311f984c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-17  Mike Kaganski  <mike.kaganski@collabora.com>  [59611f7b6acbf643bde0e0121ee51e2df53e7d50]

        tdf#142839: do not forget to initialize *pHeightNTP
        
        Regression after commit d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5
        
        Change-Id: Iaa8f67e0c7e3d99b057294717d24ffac4ad3534c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117389
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [2176084192dc46a1ef5d6dd79effa5cd5d1dcca2]

        fix potential write-after-free in RecentDocsView
        
        spotted while running a valgrind session
        
        Change-Id: I32c55ae2cc4b2d5abedca24c2f747aaa4183b3d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-17  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [befa3f75fd7bf5ef35741d099ab18e94f10e4e1d]

        EMF+ WMF Update the variable names and add additional TODO warnings
        
        Change-Id: I78b05fe3c293494195bdd37c3030147b1f21228e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117148
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [86df3a49f339a38d839f2ddedafa862031ca759d]

        stray always-show-image properties in random checkboxes
        
        Change-Id: Ida0132cba449fb098415b26e59ee31643518af0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117378
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [c5d5885d2a4bb08c056d9d18ac8b9a18f55692ff]

        gtk4: reenable paragraph dialog
        
        Change-Id: I25cb4ddd5f566892e11b600910b4691e4d46008a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117381
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [e5e928d5fb9db23e21fbf0d9e5529bce308db531]

        gtk4: extend workaround for ampersand in paragraph dialog notebook labels
        
        Change-Id: Ib165f1ab1173f7bb6500d5dfff5f82e4216d9f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117380
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [a73969240d49b745359dcafdd7719bff0f4f4871]

        gtk4: no need for ampersand workaround in an empty label
        
        Change-Id: I7e1327303589cc9c2bb24b72d5cac92ff0fc0bfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117379
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [1442ab9c7d57de2242ff1a690c4fa7bcb3c1f757]

        remove 'relief' from CheckButtons
        
        Change-Id: I8a17c36489946327113e63f80b952525ae4201a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117377
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [9ef167c38495a67639366357833041b33be3f978]

        tools: handle special chars correctly in XmlHandler + test
        
        Add the char encoding handler when calling xmlOutputBufferCreateIO
        so that special chars are handled correctly. Previously we just
        set nullptr.
        
        Change-Id: I7ef44130869625cc4662bf168550a3f987390287
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117355
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1da7d73eeaaff43e4f3e8a61ad77fcec3c7aaed8]

        indexing: remove indexing changes from html export
        
        Turns out that reusing HTML export wasn't the best way to generate
        output XML that can be used for indexing, so reverting those
        changes.
        
        The IndexingExportTest and the test file has been moved out of
        html to its own folder, so it can be reused.
        
        Change-Id: Ie2b34285775133322c16c05eee9c0e9712c86c3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117354
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [41ef183bbfcf569eb5995c5436edca3d00050385]

        gtk4: reorder the cell renderers in the comboboxes
        
        as used in format, character for the the tickboxes for spellchecking
        support
        
        Change-Id: I7b7b60455beb0f262b2e4c40286dcaec26eb42dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117375
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [f60b29636ee332d144b8f92fdd30fccd9b0d4d47]

        gtk4: implement setting grid row/col/width
        
        as used in e.g. font features dialog
        
        Change-Id: I558e52b2a1ccc471673613b63b42599db7c00ac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117374
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [28bcd06b161bbeebd7701c51c7473aed7662ada7]

        there is no such thing as a 'margin' property
        
        added in:
        
        commit e97bccdba42b464e2df8d5996d4cdc9b03b6c243
        Date:   Wed Dec 9 00:44:10 2020 +0530
        
            tdf#128176 Add a vertical scrollwindow to fontfeaturesdialog
        
        there is a deprecated 'border' property and various
        margin-start/margin-end/margin-top/margin-button properties
        
        Change-Id: I4528106a6cd51a9feede471cd8a47b81cf0df49a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117372
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [5383f219253eb5d7c0eeee2570187e4369987d23]

        split SurfacePaintable out
        
        Change-Id: I07d2109080f19fb7cf95bc439e5d99ba3247c2bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117371
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Jean-Pierre Ledure  <jp@ledure.be>  [2a38a064dfcb56cd887dc672b4d3bd260570ef13]

        ScriptForge - Comments in code: pointers to help pages
        
        Insert in each service module a pointer to the
        help page on https://help.libreoffice.org
        containing the user documentation of the given
        service.
        
        Example:
        SF_Array.xba contains a pointer to next help page
        https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03/sf_array.html?DbPAR=BASIC
        
        Only addition of comments lines.
        No code change.
        
        Change-Id: I83899d9fab247d23e2d5123378e2fb3fd0ade60e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117370
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-17  Noel Grandin  <noel@peralex.com>  [0771ac00acc8730f77db76b901724f1513a32723]

        use string_view in the Translate API
        
        Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0d97abc8ef890b2e2ead34c449f2a140e22dd5ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21d0197b3705212a22b9e221ac1f624049516d9a
          - tdf#114930 Clarify associativity and precedence of operators to the help
            
            Change-Id: Ib55f0901235c082e88b49d1526b1123cd036f875
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117347
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-17  Stephan Bergmann  <sbergman@redhat.com>  [21da7d80aa1ee0f9661dcde37bc4629d5eb9d50e]

        Adapt o3tl::temporary to C++23 P2266R1
        
        With the recent implemenation of
        <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1:
        Simpler implicit move" in Clang 13 trunk as
        <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f>
        "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build
        started to fail with
        
        > In file included from sal/rtl/random.cxx:25:
        > include/o3tl/temporary.hxx:21:62: error: non-const lvalue reference to type 'double' cannot bind to a temporary of type 'double'
        > template <typename T> constexpr T& temporary(T&& x) { return x; }
        >                                                              ^
        > sal/rtl/random.cxx:97:37: note: in instantiation of function template specialization 'o3tl::temporary<double>' requested here
        >     return std::modf(random, &o3tl::temporary(double()));
        >                                     ^
        
        etc.  (And fixing that by adding the recommended static_cast then triggered a
        false loplugin:redundantcast warning.)
        
        Change-Id: I222429e9872afdedf77a07014c0a2e9e06c60b50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117335
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-17  Olivier Hallot  <olivier.hallot@libreoffice.org>  [12ad78492e06cfece2b166ed67630f30a439b452]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ae00877c467d6ceee7b5c84ba3be99f0cb1468a4
          - Mute l10n
            
            Change-Id: Id49c3b5c606c98bbc58d9c06245e2cebf8296676
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117300
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [013bbc129774686d959878fb27d851bf2ea129b4]

        split NotifyingLayout out
        
        Change-Id: Ib706331f9e6b3749559a0b78f1a07d442a674829
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117369
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [f252223140b040a1ad76f87fce27448bd24848b8]

        gtk4: undo overflow notebook insert in dtor
        
        Change-Id: I2a051486346d4afabbf7f0f6f3b9683c8e0c9e62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117367
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Caolán McNamara  <caolanm@redhat.com>  [de74235388015673f32f9fb0bfdcf95071c7ba0e]

        gtk4: restore double-decker notebooks
        
        add a 'NotifyingLayout' to find out when the size of a widget
        changes now that size-allocate has been removed
        
        Change-Id: Iae55b7fafd2fd26c62afaedd777ae40e84fbb964
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-17  Tor Lillqvist  <tml@collabora.com>  [1394bfba870a38d7d4edbd3c387b5e87182bc90f]

        Drop the "console" functionality of ProfileZone
        
        It was not used anywhere and had not been cherry-picked to the
        relevant vendor production branches so apparently it was just some
        temporary experimentation? It is good to reduce complexity and
        increase code similarity between branches.
        
        Change-Id: Ib6717063f96d901d65ec36d65f3683af31065f2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117364
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a572acc3dd5c0bd173ff2881b239be98f4b6ecb4]

        svx: prefix member variables SdrViewEvent SdrView SdrObjGroup
        
        Change-Id: Ic20c9dc7b8109cb095a883f2dfcec3e4f10b2428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117352
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  László Németh  <nemeth@numbertext.org>  [12da70f88517bf3c053afe1c504bb70bd27573f2]

        tdf#90401 xmloff: remove personal info of comments and changes
        
        If Options → LibreOffice → Security → Security Options
        and Warnings → Options... → Security Options → Remove personal
        information on saving" is enabled.
        
        Use the same time (1970-01-01T00:00:00) for mandatory
        time stamps, and replace authors and creator-initials with
        "1", "2", "3" etc., also to avoid of joining adjacent
        redline ranges.
        
        Note: to see the work of the unit test in Linux command line:
        
        (cd sw && make UITest_writer_tests7 UITEST_TEST_NAME="tdf90401.tdf90401.test_tdf90401_remove_personal_info" SAL_USE_VCLPLUGIN=gen)
        
        Change-Id: I3b4d710dbeeee12177aff378597cd2b683ca6c25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117319
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [68eb62b9bf8a64d892b3cfa58447e7c890ed3ec4]

        svx: pragma once for some SdrObject subclasses
        
        Change-Id: Ibbadf5069fbf5327a8a5964a3003bf6e258fd00b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117351
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  László Németh  <nemeth@numbertext.org>  [3bae5216881a2b8d84066a81b5e2f728675000f0]

        tdf#115281 sc Windows: fix shortcut text Ctrl+` in View menu
        
        In View->Show Formula, shortcut text was only "Ctrl" instead
        of the complete "Ctrl+`".
        
        Follow-up to commit 3f9fcf0e7f154e49bbffeaea925edb6055add494
        "tdf#103388 Show the backtick used in shortcut in Calc View menu".
        
        Change-Id: Icef8904bac0b663d9702e62fcdc0ab1f0f4bd1ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117332
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-17  Jean-Pierre Ledure  <jp@ledure.be>  [ed7f1a6fb45502275b0975e0333ba4c63008d5b4]

        ScriptForge - Increment version number
        
        Increment the versioning constants from 7.2 to 7.3 in next files
        	modified:   wizards/source/scriptforge/SF_Utils.xba
        	modified:   wizards/source/scriptforge/po/ScriptForge.pot
        	modified:   wizards/source/scriptforge/po/en.po
        	modified:   wizards/source/scriptforge/python/scriptforge.py
        
        Change-Id: Iba78215cea9c16f3e7dd9302b84c90815c7a9e68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117258
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [270c5ba6f573f3b45828694149a6574d363b2094]

        basegfx: change template param to use int instead bool - Tuple2D
        
        Change-Id: I82bf089ea95fc3b2b527aa55cc8c9f09aa684502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117353
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  Justin Luth  <justin_luth@sil.org>  [3f5311271ea6e41583c581b8a0172e322f5a179a]

        tdf#142404 DOCX c15: fix centering when TabOverSpacing
        
        I didn't notice the need for making the same
        exclusion that TabOverMargin made for centering
        when 7.2 got the new TabOverSpacing compat flag.
        But now I see it is still needed.
        
        Change-Id: Ia8069b5566eaf6dcdac6ff10ee0c60b849c5fa2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117339
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c703b2d22c3f45825d9c9d790c3b5a4b6f97e776]

        basegfx: generalise tuples with template class Tuple2D and Tuple3D
        
        B2DTuple2D, B2ITuple2D and B2I64Tuple share a lot in common so
        we can generalise it as a template class. The same goes for the
        3D variants - B3DTuple and B3ITuple.
        
        This is the initial attempt, but doesn't yet generalise all that
        is possible.
        
        Add some tests for the tuple variants that test the behaviour of
        overloaded operators and other common methods.
        
        Change-Id: Iee5ed15d58ea88e65ee7854bd05a87ceab22023d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117104
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-17  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e337b9d92c6d5184e160df66885f53ebc4835218]

        basegfx: change template param to use int instead bool
        
        Change-Id: I5e0f52ba9b9a82ad702204a2d35ea49a8d74aa55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117326
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-16  Stephan Bergmann  <sbergman@redhat.com>  [433ab39b2175bdadb4916373cd2dc8e1aabc08a5]

        Adapt implicit OString return value construction to C++23 P2266R1
        
        With the recent implementation of
        <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p2266r1.html> "P2266R1:
        Simpler implicit move" in Clang 13 trunk as
        <https://github.com/llvm/llvm-project/commit/bf20631782183cd19e0bb7219e908c2bbb01a75f>
        "[clang] Implement P2266 Simpler implicit move", a --with-latest-c++ build
        started to fail with
        
        > comphelper/source/xml/xmltools.cxx:103:20: error: no viable conversion from returned value of type 'char [39]' to function return type 'rtl::OString'
        >             return str;
        >                    ^~~
        [...]
        > include/rtl/string.hxx:277:5: note: candidate constructor [with T = char [39]] not viable: expects an lvalue for 1st argument
        >     OString( T& value, typename libreoffice_internal::NonConstCharArrayDetector< T, libreoffice_internal::Dummy >::Type = libreoffice_internal::Dummy() )
        >     ^
        [...]
        
        etc.
        
        Change-Id: If34f143a1855fdd7cd22ea3d7594f9381d50a7ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117336
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [cb636701881df38f3092d499142acbf62f4eff3c]

        gtk4: redo theme unwanted active tab in overflow notebook into invisiblity
        
        don't quite see why this doesn't work out of the box in gtk4, but
        putting it into the application-level style provider and using it via a
        style class works and probably makes more sense anyway.
        
        Change-Id: I4de196e462d7440174a0d67be25923bddab68197
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [f81c1414c0e30713b5fea544cae5f50a330b99e3]

        gtk4: partial restoration of double-decker notebooks
        
        there isn't an obvious candidate as to when to do the split though
        
        Change-Id: Iee6d74015263b180470fc0c90924617bcde14421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117334
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [04895980c096826a63b10ec648627b5007b0a884]

        gtk4: Notebook label is now inside another widget
        
        Change-Id: If1f37959603dbe10e01d492321e9324ab55f10d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117333
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [e3a7d0152518d5de99d61f61bed77b59987d03d2]

        gtk4: add some working dialogs
        
        Change-Id: Iac09640fe05110ef01cd7e4645b5a9e0ea8eb48e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [0f8c44ce269f8f2a8563bd3682349ebfb2db1f70]

        remove SpinButton input-purpose properties
        
        Change-Id: I68629d4350c43c80fdd00f9fcb8af3733753fe43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117327
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7c49bd291ce1c77cbbf793d728cd2bafe90d8591]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 8cd38fb5138f2e456506aaa889ec2b7042a7439e
          - Czech Hunspell: fix word "třídička"
            
            Change-Id: I36236d34249e9a8c5e8bfa48b30a26cf595d309b
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/117343
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-16  Stephan Bergmann  <sbergman@redhat.com>  [d32d2fd301357df94d1930420b89415e1fe69688]

        Move enable_if from dummy template parameter to return type
        
        ...and drop the no-longer necessary loplugin:implicitboolconversion exclusion
        (which had been necessary to avoid
        
        > [CXX] vcl/source/window/dockingarea.cxx
        > In file included from vcl/source/window/dockingarea.cxx:26:
        > In file included from vcl/inc/svdata.hxx:26:
        > include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion]
        > template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false>
        >                                                                              ^~~~~
        
        etc.)
        
        Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [c9ba420bfe5c31e67a7555c8f4a16d0bd7954a51]

        cid#485150 silence Uncaught exception
        
        for the record
        
        coverity[foo] defect is marked as intentioanl
        coverity[foo : FALSE] defect is marked as false positive
        coverity[foo : SUPPRESS] detect is not saved at all
        
        Change-Id: I1277c4426b5fa9efde8a9227c2813d53deb56555
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117325
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [899737e6e4fca537e7352a9cd11e161328800b83]

        stray unwanted 'relief' property on random checkbox
        
        Change-Id: Id942f88780d4f697df44433180343ca3c763ed67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117321
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Justin Luth  <justin_luth@sil.org>  [c54de8cca177154d267238ed6d0b6cb4f3f86c8d]

        tdf#142404 DOCX c15: line full before out-of-bounds TabOverSpacing
        
        MS Word 2016 does something very weird. It attaches a
        TabOverMargin to the previous word, and pulls it down to a new line.
        Well, I don't think we want to attempt anything silly like that,
        but at least we can have the tab itself start on the new line
        (and thus take up the whole line).
        This seems to be true only for a left-tab.
        The other tabs have a different kind of strangeness
        that I haven't identified yet.
        
        In order to do that, when we request a tabstop position,
        we must query a tabstop beyond the end margin.
        So modify the GetTabStop function to allow for
        not checking against an nRight position (when passed a zero).
        
        This is complicated by the function's ability to ALWAYS
        return the first tabstop - even if it is past the given
        right-most edge. So I made nRight modifiable,
        so that in this case, it isn't considered to be past
        the right edge. That is fine for both cases where
        this function is used.
        
        It is a bit ugly, but I don't see how to make it cleaner,
        when these inherent complications are already built-in.
        
        This also has an impact on older DOCX, but the impact
        is still valid. (In those, the entire paragraph
        extends past the end in Word. With this patch, at
        least the first line becomes more than just an
        auto-tabstop.)
        
        Change-Id: I42791a959aea2932b5776789ba45307fbca41a5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116878
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [18f1199f4b99e644e4aea50eb17e409110a0d6c7]

        xalign of 0.5 is already the default
        
        so no need to make it explicit
        
        Change-Id: I933fd914a3a7c408b836a85fee7acb39e731990f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117320
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [2305f8fcf69b35f2d2e68eb20172af13ce0792d2]

        Resolves: tdf#142874 missing translation property
        
        since...
        
        commit 15664117ef4db51bdcabb46b7990573509da0d73
        Date:   Thu Jul 25 21:40:48 2019 +0300
        
            tdf#125923 Fix reset button.
        
        Change-Id: Ib589aa32221eaa33a13a17a00c2edb51866a5daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117315
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [ce0aebb7bd9bf37e67111cf2a425ba7a3aee57fe]

        resave with latest glade
        
        Change-Id: I1fac93fc43c80fb986e5b09b497c644be6852b52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117314
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Noel Grandin  <noel@peralex.com>  [e52bbca626e2cbe2f4d13632f65967604abb0abc]

        tdf#135316 docx open performance
        
        avoid unnecessary SwNumFormat creation
        
        Change-Id: I62a16fdeb1225606a54f384e5196e5137e8d2139
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117271
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-16  Georgy Litvinov  <git@litvinovg.pro>  [736a2db98bbf7222bfec3dcff89999ccb71b576e]

        tdf#38187 Create back link from footnote text to anchor in text
        
        Change-Id: I1ddf447975872a45447bfa86d050c886f4191962
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117205
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [f283ec0bf68734558e903339f2f0d86633cc9a62]

        tdf#59323: pptx export: slide footers roundtrip unit test
        
        Roundtrip test that checks the slide footers, and their placeholder indexes.
        
        Change-Id: I9c4b819092ac6699617d71538c35b066d6e6f974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117013
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [25ae0de974befb9c279936046056a850d77e0dca]

        tdf#59323: pptx export: add support for slide footers
        
        Adds support for exporting slide footers to PPTX.
        
        Slide footers are exported as shapes that use placeholder indexes to refer to
        the shapes on master.
        
        To make the references work they are exported to layout slides too.
        
        Change-Id: I8bfde520b0aec66405523c719844e69c6fc15b79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117012
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [fc3c92c82198e7ab56d21fbc896f4153bc8628c1]

        both children are at position 0
        
        instead of one at 0 and the other at 1
        
        Change-Id: I1943d2e68f39fb463d76237d6eb0bffe800a6b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117313
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [6c4e61fcc73574eb5d55cc0bcb3c6ff8d69debc6]

        gtk4: reenable some more working dialogs
        
        Change-Id: Iaa8d77b231f8366ff4c33221691e9a3cadb73fa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [0f9dc676eefce79ea63218edd910af486a09a52b]

        tdf#59323: pptx export: add initial support for lstStyles in textboxes
        
        Adds initial support for writing lstStyles that are specific to a shape.
        
        Current implementation only writes first paragraph and first textruns properties
        in it.
        
        Made WriteParagraphProperties return a bool that determines whether or not it
        wrote a pPr tag. Needed this since lvl1pPr tag should be started even if there
        was no paragraph properties since run properties also written inside it.
        
        Change-Id: Ie0cfc9b9f221093db3a1111ca29140a6dfb5e8ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117011
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [560eea7be7668af90e75c4dee2a2f16cbdbf0945]

        set default width/height of minimum for dialog
        
        Change-Id: I25ea3a44f7bda7916bb129e7642150c80b9dab11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117291
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [e7185e1994055672ff338974fe8ccb98daa947dd]

        resave with latest glade
        
        Change-Id: I736005e7a6d669dea75347bddcd8114ceea4fe33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117290
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [3b8fb0ba187ad8b0a5eb6102dcfd982aee6db9f5]

        gtk 4.3.2 will have a fix for this
        
        Change-Id: Idae818c0d7220d0fbe08462eff1654c22d24310c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117284
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [1178d2978d3328de0bf0bccb9920fbc8b9a3a414]

        tdf#59323: pptx export: add placeholder index to master footer placeholders
        
        OOXML uses placeholder index to determine from which layout placeholder it
        should be inheriting styles, position etc.
        
        Added maPlaceholderShapeToIndexMap that stores corresponding Placeholder index
        for a Placeholder XShape on the master slide.
        
        Right now only used for placeholder types Footer, DateAndTime and SlideNumber.
        
        Change-Id: If788f235d00b6d1cde7194d9e4a0789e019432c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117010
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Gopi Krishna Menon  <gopi.menon@collabora.com>  [4b925781760ba84e62cb847ddfe8f8c667a44c95]

        Add Active App Name Field To Crash Report
        
        Adds a Active-App field in Crash
        Report to assist in investigating
        the crashes
        
        Change-Id: I30e5f307045b8e5def9986447551f39e70b94edc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116786
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-16  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [3f9fcf0e7f154e49bbffeaea925edb6055add494]

        tdf#103388 Show the backtick used in shortcut in Calc View menu
        
        as Ctrl+` instead of "Ctrl+grave" (see at View->Show Formula).
        
        This affected only gen backend on Linux (SAL_USE_VCLPLUGIN=gen),
        gtk3 and qt5 are handling this correctly.
        
        Change-Id: I2bebcf68118642e6c12cf2c5d4392f2ca423665b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116742
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [ba66d49db89678628975b29612c0caab49457adf]

        tdf#59323: pptx export: add datetime field type helpers
        
        Creates helper functions to convert from LO time and date formats to datetime
        fields on OOXML
        
        Change-Id: Ibbfefa18d0422eddb6c37539294ed23e77fe5f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117009
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Sarper Akdemir  <sarper.akdemir@collabora.com>  [166671f4aa19deec47c10a220ae1d29fa57faa93]

        tdf#59323: pptx import: import footer fields as properties
        
        Makes footer, slidenum and datetime placeholders that are inserted to
        the slides themselves on pptx files imported as slide properties if it
        is possible to do so without losing information (style, position etc.)
        
        If that is not the case and the footers have some special style applied
        to them that isn't inherited from master slides, fallbacks to the current
        implementation importing them as shapes.
        
        Also since the default way of displaying slide footers in LO use the
        respective text fields on master slides, information in master/layout
        slide datetime and footer placeholders respectively get replaced with
        <date/time> text fields and <footer> text fields.
        
        Change-Id: Ib2f7d18103b62c0c9a8453e01cfd2fd1aa1d39af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117008
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  Miklos Vajna  <vmiklos@collabora.com>  [3c46fd3d727e4885fedef7c9f3fcd6f4c9a9ebb9]

        sw HTML export: allow larger bitmaps for shapes than the vcl default
        
        VCL default would be 500k pixels, i.e. a 2" x 1" shape at 600 dpi would
        be already truncated from 1200 pixels width to 1000 pixels. That's a bit
        too extreme, use a larger limit in the sw HTML export.
        
        Change-Id: I52b85d77cd27410d53c700a89190c99348de5e19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117287
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-16  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e838c1b9e9031de742deeff763c06b1d39f399ef]

        basegfx: use namespace for "ftools", make sure input is FP number
        
        Don't use empty class with static methods for ftools, but just
        use namespace instead. Also make sure it works with any floating
        point numbers (float and double) and don't allow input if it is
        anything else than a floating point number
        
        Change-Id: I94b964291b3999d38ae13afe6ddfdbe6d891d410
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117154
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-16  Gabriel Masei  <gabriel.masei@1and1.ro>  [bf6dabe0ebad3cc5bc0edc04ae74fba0190b6203]

        vcl: check mpWindowImpl for nullptr
        
        Change-Id: I492c7d5c1846df7507b1f043b80de4e61ff8ca86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117282
        Tested-by: Jenkins
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [01e4acd1dc3bfedb9c37b4b9bb93be1201b475a5]

        gtk4: use xalign to position replacement box
        
        insert, section the "pick button" in color subtab of background as an
        example of a horizontally centered case
        
        and
        
        format, watermark, color dropdown "custom color" as a left aligned
        example.
        
        Change-Id: Id318b5acec44ceccaed5875e4f747968225bdd78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117278
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [ecdb4b2ca8a55b8b2d077cabd930964a41624736]

        gtk4: use image-position to position elements within replacement box
        
        enable insert, section with pick button in color subtab of background
        tabpage as example usage
        
        Change-Id: Ie972e2de9181888b59159a7a12651e6f7f7dec26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117275
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [72e0b04d23857f873855073605314c912f449801]

        replace deprecated GtkButtonBox
        
        replace the ones outside action-area of dialogs
        
        Change-Id: Iec0edfc675057f994c188e12dbacbb0f2126dbd6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117274
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Caolán McNamara  <caolanm@redhat.com>  [5ea407ff526c914d83e40f61021a69ad3567f7d9]

        resave with latest glade
        
        Change-Id: I53a401a096e171b0955303396eccda18e1b8002a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-16  Miklos Vajna  <vmiklos@collabora.com>  [7ed6fc47dc029fcf077d3d389f806e41f5c7427e]

        sw: rework to avoid DECLARE_SW_IMPORT_TEST() in CppunitTest_sw_htmlimport
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I0f4d978f6ebb713d472d5d5741369b031e67e0f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117269
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-16  panoskorovesis  <panoskorovesis@outlook.com>  [4550170f7bfb115876e1ac9758864040aba5cd21]

        Add MapMode cppunit test to vcl.
        
        The test creates multiple MapModes (relative and non-relative) with
        custom and default attributes, which then checks.
        
        Change-Id: Iaed461ece9cc044b5b271456a6bac10b1533062a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117232
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-16  panoskorovesis  <panoskorovesis@outlook.com>  [240c6557898de6a7777b2b2055d1c133a803b396]

        Add MoveClipRegion cppunit test to vcl
        
        The test creates two MoveClipRegions and checks their attributes.
        mtfxmldump.cxx was modified to support MoveClipRegion case.
        
        Change-Id: Ibfabf9d4048cf94e43c259e411a6c59b73baff34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117153
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-16  Eyal Rozenberg  <eyalroz1@gmx.com>  [81472692c4ee0b12c6d2184823faefa7a53431e6]

        Partially resolves tdf#141869: Rephrase of strings in the Cross-Reference dialog.
        
        Change-Id: If7379c549739c88149a1229e048d7fb0d0147edd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116164
        Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-15  Julien Nabet  <serval2412@yahoo.fr>  [b89ebf135818ccaa45bbfb164099a6e199bd7d11]

        tdf#142860: fix crash: press Page Columns Button on Tab UI
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=172924
        
        Change-Id: I477ad78e943934d83cf48620f5ed2573558901e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117268
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-15  Stephan Bergmann  <sbergman@redhat.com>  [2435a238ee4e58f6360541756f50173767803084]

        Adapt to flatpak-builder 1.0.14 split "dest" + "dest-filename"
        
        see <https://github.com/flatpak/flatpak-builder/issues/399> "flatpak-builder
        1.0.14 breaks build of org.libreoffice.LibreOffice, empty
        /run/build/libreoffice"
        
        Change-Id: I7f7d3f655ccf5078cc8827e4088b331477ed8086
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117262
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [ce37a53c58e278fc9d330e70ab13533a94f73270]

        uitest: sc: use guarded wrapper in test
        
        maybe it helps to know why it's failing on amd64
        Change-Id: I6f3e4747393c823c4f1f98fc9208ed2ab16c270c
        
        Change-Id: Ie804b0485dc3cf4206bfe88884d1c1a420cee593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117247
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [32b61e99dfd8d2c50dec1cddfb27c4e5e7083d2d]

        tidy up .ui
        
        Change-Id: I7400a4994c57e4652daca6215385bfd8e4d46369
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117266
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [0632d9a93fe34128628b3e93c85c943a9c7c919b]

        move unique use of primary-icon-tooltip-text to tooltip-text
        
        there are no "secondary" or "primary" icons for the tip to be
        relevant to. I imagine this should be for the whole widget.
        
        Change-Id: I3509000ae3d8a9ce3eca3549a76b0fe9222fb319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117265
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Stephan Bergmann  <sbergman@redhat.com>  [541f94df85756d3a383b1f9ba49841ca0011b52e]

        memcpy-param-overlap
        
        At least UITest_impress_tests started to fail at
        
        > ==608818==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x6020000ef270,0x6020000ef276) and [0x6020000ef274, 0x6020000ef27a) overlap
        >  #0 in __asan_memcpy at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3
        >  #1 in RemoveWhichRange(unsigned short const*, unsigned short, unsigned short) at svx/source/svdraw/svdetc.cxx:413:17
        >  #2 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) at svx/source/svdraw/svdedxv.cxx:2222:19
        >  #3 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) at svx/source/svdraw/svdcrtv.cxx:883:29
        >  #4 in SdrView::SetAttributes(SfxItemSet const&, bool) at include/svx/svdview.hxx:193:96
        >  #5 in sd::View::SetAttributes(SfxItemSet const&, bool, bool, bool) at sd/source/ui/view/sdview.cxx:488:28
        >  #6 in sd::DrawView::SetAttributes(SfxItemSet const&, bool, bool, bool) at sd/source/ui/view/drawview.cxx:288:27
        >  #7 in sd::TextObjectBar::Execute(SfxRequest&) at sd/source/ui/view/drtxtob1.cxx:819:21
        >  #8 in SfxStubTextObjectBarExecute(SfxShell*, SfxRequest&) at workdir/SdiTarget/sd/sdi/sdslots.hxx:17883:1
        [...]
        
        (followed by
        
        > ==647521==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000258856 at pc 0x0000002f7b0a bp 0x7f7f7a69fdb0 sp 0x7f7f7a69f560
        > READ of size 6 at 0x602000258856 thread T9 (cppu_threadpool)
        >  #0 in __asan_memmove at /data/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:30:3
        >  #1 in RemoveWhichRange(unsigned short const*, unsigned short, unsigned short) at svx/source/svdraw/svdetc.cxx:413:17
        >  #2 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) at svx/source/svdraw/svdedxv.cxx:2222:19
        >  #3 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) at svx/source/svdraw/svdcrtv.cxx:883:29
        >  #4 in SdrView::SetAttributes(SfxItemSet const&, bool) at include/svx/svdview.hxx:193:96
        >  #5 in sd::View::SetAttributes(SfxItemSet const&, bool, bool, bool) at sd/source/ui/view/sdview.cxx:488:28
        >  #6 in sd::DrawView::SetAttributes(SfxItemSet const&, bool, bool, bool) at sd/source/ui/view/drawview.cxx:288:27
        >  #7 in sd::TextObjectBar::Execute(SfxRequest&) at sd/source/ui/view/drtxtob1.cxx:819:21
        >  #8 in SfxStubTextObjectBarExecute(SfxShell*, SfxRequest&) at workdir/SdiTarget/sd/sdi/sdslots.hxx:17883:1
        [...]
        > 0x602000258856 is located 0 bytes to the right of 6-byte region [0x602000258850,0x602000258856)
        > allocated by thread T9 (cppu_threadpool) here:
        [...]
        
        if the memcpy were replaced with memmove) after
        8aaa28ed43978a9a4a20d62368410a57ec05c23f "Assert on valid order of which ids in
        ranges on SfxItemSet creation":
        
        Where in the past it had called
        
          RemoveWhichRange({10951, 10951, 4007, 4007, 0}, 4007, 4062)
        
        and
        
          RemoveWhichRange({10950, 10950, 4007, 4007, 0}, 4007, 4062)
        
        on wrongly sorted ranges, for which the implementation of RemoveWhichRange
        happened to work, it now calls
        
          RemoveWhichRange({4007, 4007, 10951, 10951, 0}, 4007, 4062)
        
        and
        
          RemoveWhichRange({4007, 4007, 10950, 10950, 0}, 4007, 4062)
        
        on correctly sorted ranges, which uncovered the broken implementation.
        
        Given that RemoveWhichRange is presumably not hot (e.g., being called just two
        times during UITest_impress_tests), turn it into a less sophisticated, but also
        likely less error-prone algorithm.
        
        (Leaving unit tests as a TODO, given that RemoveWhichRange is not
        currently exported from Library_svxcore, and the existing CppunitTest_svx_unit
        links against Library_svxcore rather than using
        gb_CppunitTest_use_library_objects.)
        
        Change-Id: I8a1c1d5db8073928ad2f6e88d581f24a0e882925
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117264
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-15  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8f42a944700c18abf7d47292a477eeb306ad2203]

        Update TSCP config for pt-BR
        
        Sample file updated
        
        Change-Id: I5fc8e6f65d13e44e8ebaacbb049cf997e839241f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117267
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [49849a09e2823ac6edb42693daf7eac5312f2eb9]

        fix some 32-bit compile errors
        
        Change-Id: I7ce0e71a51709b0ae90b7e509f00f608fffad47d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117233
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-15  Regina Henschel  <rb.henschel@t-online.de>  [58eeec036c3780188feccb0e1a752cfdee90a49b]

        tdf#142361 export: prevent shadow to rotate with shape
        
        OOXML has the feature to rotate a shadow together with the shape. The
        associated attribute rotWithShape has the default value 'true'. So
        if this attribute is missing, MS Office shows the shadow rotated. As
        LibreOffice never rotates a shadow, we need to write this attribute
        always. Because LibreOffice cannot rotate shadows, the error is only
        visible in MS Office.
        
        Here the attribute is added for the case of documents, which have no
        InteropGrabBag or no effects in it.
        
        When a shadow is generated in MS Office, MSO adds the attribute with
        value 'false' (0) to the file. MS Office has no UI to set this
        attribute. Problem is with cases, where the document comes from
        MS Office, has effects in InteropGrabBag, but the shadow was set in
        LibreOffice. To add the attribute in such cases too, bug tdf#142858
        has to be fixed.
        
        Change-Id: I5f1df416bca8ea15a305242afb140d852cfd84c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117206
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [93e2cc6d5d3408a4d480ac9a44e6adb0060965bf]

        gtk4: use GtkPicture for view, user interface
        
        Change-Id: I6677233dc0594d6b2e9ea4b8f901550dbff46361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117261
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [d00a65466346b47645faf5826f8c8eb5a91f031b]

        gtk4: support moving children in and out of GtkGrid
        
        Change-Id: Ia90b9586ff39f0a668da4e0f9beef7ed26626ebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117260
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [4364dc21ee184da9f773efbf7b9177d59f5096f1]

        gtk4: double-encode ampersand if use-underline is used
        
        as seen in calc paste special dialog
        
        see https://gitlab.gnome.org/GNOME/gtk/-/issues/4041
        
        Change-Id: I5425d1f5b5474fc6cda949e8fcb76b734ab893e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117259
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [7ed44a440da563974b0ed6d1bf9ded5d69f9a276]

        gtk4: don't convert generated button image-child
        
        its already convert, so don't double convert to remove e.g.
        already converted icon-size in calc paste special
        
        Change-Id: Id87ca7a6dfecdca102e1a12a37eed90b0e40e48c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117250
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [ae2948516305415cf48ba43f2412e0d7a9b5d73e]

        gtk4: further disambiguation of Image/Picture
        
        examples of GtkPicture wanted:
        a) math, format, spacing
        b) all, help, about
        
        examples of GtkImage wanted:
        a) writer, format, columns, next/prev
        b) writer, insert, hyperlink
        c) calc, paste special
        
        Change-Id: I53ad0a40f30a4963a8490c4e76fa50c463de0903
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117249
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [7099902bc9ebdc5407d7cd917a57188bb575dd66]

        gtk4: convert all the larger old icon sizes to GTK_ICON_SIZE_LARGE
        
        Change-Id: I88921495e60f47b54e4d473315ee953872e61891
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117248
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Justin Luth  <justin_luth@sil.org>  [39251e461bfe628da875bb17e91dc374f137eec5]

        tdf#142404 DOCX c15: allow autoTabStop after TabOverSpacing
        
        I said I wasn't going to do anything about tab-after-tab,
        but this time around I'm not seeing any problems,
        and some minor benefit, so lets go ahead anyway...
        
        Obviously we do not want an autoTabStop by itself to go
        over the margins. However, if we are ALREADY over the margin,
        then MS Word 2013+ (compatibilityMode 15) does allow them.
        [This already happened with TabOverMargin for the most part,
        but I don't know what TabOverflow accomplishes,
        so to be safe and cautious and mysterious, I limit it to
        only benefit the new TabOverSpacing.]
        
        The only unit test that had this condition was ooxmlexport13's
        tdf121374_sectionHF2.doc, but I don't see any impact there.
        
        Change-Id: I67fb35b9ae4a6cfc50ccf76aa082d2b2f9683c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116877
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Miklos Vajna  <vmiklos@collabora.com>  [fdf1db0010104294c01c7780d9daba5adf38450b]

        sw XHTML / reqif export: handle multiple lists when detecting header-only lists
        
        The case when the list was at the end of the text node section (body
        text, table cell, etc) was already handled, this handles when the list
        is followed by a different list.
        
        Change-Id: I131402cb577bd16814f56a5bd6bcad7c99947dbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117246
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [bbd6def8df823fcc2f5c6aef4dce775d87eef59f]

        gtk4: support image at top in button with vert orientation of child box
        
        Change-Id: I87b7c2752120d272eb176307465d658f4a980170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117244
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [a870f90800041d108078642ece84bacebd1dc794]

        button text should be Yes not yes
        
        Change-Id: Ib92a1119046c79ce36968ad0814161ef7c4b0982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117237
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [c613eae96815e41a00b8dd63e4422c85ed849b71]

        rework paste special a little
        
        to avoid GtkButtonBox, it appears a little cramped under gtk
        otherwise
        
        Change-Id: Ie80a0474f6bc246de7b673e255434071bafcfbeb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117243
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Heiko Tietze  <tietze.heiko@gmail.com>  [10ff27cc4f01693865599d24caf7ab80d95232e0]

        Resolves tdf#142499 - Make fat cross cursor optional
        
        Change-Id: I9a9182f8783f951e49cdb8f897578f99281c25d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116858
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [3ac07d7f1bcce4a9ff0d989381a0a3443fe0a5c8]

        drop height-request that appears on just one of four buttons
        
        Change-Id: Ib3d197886a10a0acfe8f856d10dc5e33be8fd72d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117242
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [f748157e61180cab3afc06a0a541b0e89fe77a8b]

        make the 4 buttons have the same packing properties
        
        Change-Id: I526d5adaaee1601690151bea90780fc02996c804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117241
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [639d3764f9f22c247dff3f2c80841a7ae8f05dd0]

        resave with latest glade
        
        Change-Id: I820a121c92ae3279267a725fcf8f710737d6ea26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117240
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [d21682a1328af7183ebcf723d7287d74a8424d6e]

        only three of four of these buttons have always-show-image
        
        Change-Id: Ic4bb951d0a7800b5d920a3b40c2bb4b06ecbc629
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117203
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [d2f0a09c39f87a85a49844edefe304a5cdb9f0dd]

        gtk4: leave Help button unchanged if its in a GtkMessageDialog
        
        as opposed to a help button which will be relocated to the titlebar
        
        Change-Id: I2053ad05025cce9e0a894b555160b56eb5bc2f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [f1f431b9884dd50353e12af8759b160d70e418dc]

        gtk4: support moving between containers
        
        just GtkBoxes for now
        
        Change-Id: I2247661649c67944290451de98e80db7faf41648
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [a2f42f37a0dcc584a54aaf21d3deaf98a664fad7]

        Split CppunitTest_chart2_import into two
        
        Change-Id: I1a9b98b9e20fd6e097bc8fd68958b7feb66991f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117236
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-15  Noel Grandin  <noel@peralex.com>  [9966345f4faebb447d353ce68cee5765863273a2]

        tdf#135316 docx open performance
        
        don't translate back and forth between two representations in
        SwPoolFormatList
        Shaves 2% off load time.wq
        
        Change-Id: I098c15b92d5bc89fe1631edaed6827931cde5895
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117235
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [9265b268595b814b173cd0481ad5cbe4ce2a66e6]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b5bc9b53c30eb97f9fb0b9bba677c5d7549d8251
          - Use <emph> instead of <keycode> in sf_intro
            
            Change-Id: I12a5a853f29f800abf9703da8f6c62ae247446af
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117215
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-15  Noel Grandin  <noel@peralex.com>  [ed1ef5f0aa3391d4e46f03adc6f40bb80db00309]

        remove some redundant lookups
        
        Change-Id: I4668087a0a6373049b29db6f2ffb770023c58c64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117211
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [dd5bf12193471f064bf7f581dd1b21783390e735]

        editengine-columns: add sidebar property panel
        
        Change-Id: I90aefc10f9ddddeb64a65799480777bc4287abae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117107
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-15  Noel Grandin  <noel@peralex.com>  [2bccb7e67b637c6312a0df610f870c8621eb296f]

        remove some unnecessary LanguageType copies
        
        Change-Id: Iec4374627c931ccecf05a712682ed18ef90bf359
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117208
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [86dc8e1f6273354eaf663299a028d896ad88cc9b]

        fix big-endian code
        
        after the transparency->alpha changes in ::Color
        
        Change-Id: Ifbac6c8f37f18e8acaef0602ef414ae39449ad3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117209
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-15  Sarper Akdemir  <sarper.akdemir@collabora.com>  [2cfccfba09faa5c3bb973136ffe99d534d09c881]

        tdf#59323: ooxml import: hasListStyleOnImport
        
        Introduces hasListStyleOnImport to determine whether or not the textbody had a
        non-empty lstStyle tag in it on import.
        
        Change-Id: Iccb8cfb20e4402e7cadb8e2f2b9a1f6fa178ade4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117007
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Sarper Akdemir  <sarper.akdemir@collabora.com>  [7882f2425499e6d12894a74696f30b718468c4a4]

        tdf#59323: ooxml import: hasNoninheritedBodyProperties
        
        Introduces hasNoninheritedBodyProperties.
        
        Change-Id: Id108f692005455376537e515f41528cc66a8c25c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117006
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [f581874672d4c5f2e51c02e03c55c937449ac05f]

        gtk4: add more working dialogs
        
        Change-Id: I0a31192fcfc175e0db509e8061e7980127cb50ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117202
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [977d64a7ad204288736af48495f2d0636b2bb4b7]

        call close button "close"
        
        Change-Id: Iefa08a1c1887e3d5148d8925cefcd9451eea5d02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [b8d129bbf743dd09371d3c1ae454e0af2889b9a9]

        gtk4: add more working dialogs
        
        Change-Id: Id17952c6915b2c15b7b443c5d4bd5fb6ac55c150
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117200
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [a1ab9329bc15df3d3e0cac813784f83bea9aface]

        remove deprecated Expander spacing property
        
        which is the spacing between expander indicator and expander label
        
        Change-Id: Ib840cec6744bd7f0714d38b8296d2f17dc9a916d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117199
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [bec4a20182abc643f2a02dc725b605493b4ec9b0]

        we don't pack ok/cancel with 'secondary' that's for the help button
        
        Change-Id: I3b6484f4b362c718fb3abb3584d426a4c0f0cecf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117198
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [f5fbbe49d6963cb5e3c486518366a4f89dc97038]

        resave with latest glade
        
        Change-Id: Ib9eb3b74114ee70dd8111bd56e373996d044356a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117197
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [f9537ce5020af3a5f321df1647c93a227eed87ec]

        gtk4: add more working dialogs
        
        Change-Id: Ife00799a8eab3d73a635ed6c2bd31cfb6e5d2d91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [7ab63329db5ffa3f7a6ff8c2990582acf7495743]

        be consistent wrt help with 'secondary' packing
        
        Change-Id: I442d29123f286795744e767c2d020532993643f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117195
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [d7b7ce12ddc41fe3f5193f691c29523fd8eb6641]

        resave with latest glade
        
        Change-Id: I0c62277013afd4e6ba8ac09776420a359a5ac399
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117194
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Caolán McNamara  <caolanm@redhat.com>  [da3b88b0430851327043f5d23a14f20ec5b14f80]

        gtk4: add more working dialogs
        
        Change-Id: I5950424b16a4aabd8a4e15b912bb5b3b178c4052
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117183
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-15  Sarper Akdemir  <sarper.akdemir@collabora.com>  [b187c36e019f773a71687c819c3cf6a2c3fd2b89]

        tdf#59323: ooxml import: hasParagraphProperties
        
        Introduces hasParagraphProperties to determine whether or not there was a pPr
        tag in the textbody on import.
        
        Change-Id: I3c6815e8405b0087f64520ee4e0e39297b3b4548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117005
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Sarper Akdemir  <sarper.akdemir@collabora.com>  [4a3b9d2092ff5ce8336cc87cacbdc421f3d26ea7]

        tdf#59323: ooxml import: hasVisualRunProperties
        
        Introduces helper functions to determine whether a shape has non inherited run
        properties that change it visually.
        
        mbHasVisualRunProperties is set on import if there was a run property that
        alters visual appearance.
        
        Change-Id: Ie1e8e22d2757dc8594e7c6c3b8fc1dd7973c92af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117004
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Chris Sherlock  <chris.sherlock79@gmail.com>  [21405a65c3056fe8c827f3999e5c79f6083d8229]

        vcl: outdevmap.hxx -> rendercontext/ImplMapRes.hxx
        
        Change-Id: I96e191999e43e1a4203d548eeacd386ed883cd8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115368
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-15  Miklos Vajna  <vmiklos@collabora.com>  [4bb8c8c41f95383839a3d532e39c2353a3d8d275]

        Remove some unused includes
        
        See tdf#42949 for motivation.
        
        Change-Id: I559eb3b41a5a0fdb37db6c45d73211ca223384fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117193
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-15  Mike Kaganski  <mike.kaganski@collabora.com>  [3c472ffe90bf5c496411c6d37ae832d9181c4ec9]

        Revert "tdf#142832: a blind fix - calculate rectangle size properly"
        
        This reverts commit 57d122258437c0a14b303a8d961aa5e8f6f67f57.
        
        Reason for revert:
        As mentioned in https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindowrect,
        
        > In conformance with conventions for the RECT structure, the bottom-
        > right coordinates of the returned rectangle are exclusive. In other
        > words, the pixel at (right, bottom) lies immediately outside the
        > rectangle.
        
        So it was incorrect change.
        
        Change-Id: I2b29871a5d9b944ce2f9119edb2e87c53d9ae298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117212
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-15  Todor Balabanov  <todor.balabanov@gmail.com>  [b3bf90ec5fb3d4c6379288081e63d944cda8d5a4]

        Fewer array reference calls make the code more readable and more efficient.
        
        Change-Id: I7416633a735078a4e0e857f050ea7bfaadba310c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117158
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2021-06-14  Rafael Lima  <rafael.palma.lima@gmail.com>  [de7356c2e0cb099fac396808b5a86a0393b48e5f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 693c6bf5faf43f8ae9a0eb72ee9ae7244161b363
          - Add SF services to the Help tree
            
            Change-Id: Ifbd98abbfde88ea293bd920cbcd0f12c8b399a91
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117131
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [28fb60fe9094f9f88c196dad8429258c38e660ad]

        sw_core_accessibilitycheck: remove duplicated createDoc method
        
        Change-Id: Icdd1cded776544b5d2f4b7c3335f235aca490726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117187
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [3a907c593fe623b28670f32df75c7d96c6b2905b]

        sw_uiwriter: use createSwDoc
        
        Change-Id: I0fbdf08400850c647e8af1dc5fc689f85cd02311
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117192
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-14  Julien Nabet  <serval2412@yahoo.fr>  [bc63b8a94d95cf86da142bfd4f8d0a6b3ba3d83f]

        Fix Exception from PutProperties in unotools
        
        Launch Impress, click on "Animation" icon and check/uncheck "Automatic Preview" checkbox (at bottom right)
        Close Impress and notice this twice:
        warn:unotools.config:9155:9155:unotools/source/config/configitem.cxx:487:
        Exception from PutProperties com.sun.star.lang.IllegalArgumentException message:
        configmgr inappropriate property value /home/julien/lo/libreoffice/configmgr/source/access.cxx:1497 ArgumentPosition: -1
        
        Investigating a bit, I noticed:
        officecfg/registry/schema/org/openoffice/Office/Impress.xcs
            673         <prop oor:name="Width" oor:type="xs:int" oor:nillable="false">
            680         <prop oor:name="Height" oor:type="xs:int" oor:nillable="false">
        
        officecfg/registry/schema/org/openoffice/Office/Draw.xcs
            429         <prop oor:name="Width" oor:type="xs:int" oor:nillable="false">
            436         <prop oor:name="Height" oor:type="xs:int" oor:nillable="false">
        
        sd/source/ui/app/optsitem.cxx:479:        "DefaultObjectSize/Width",
        sd/source/ui/app/optsitem.cxx:480:        "DefaultObjectSize/Height",
        
        Change-Id: I608b882cdff03e464fdb9886d5ba28dd33bfe229
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117095
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [1e01325b95db73ffb8d773573a89e1ba9e5deb18]

        sw_uiwriter4: Unify code and use createSwDoc everywhere
        
        While at it, use 'reload' instead of 'save' + 'loadURL'
        Change-Id: Ib8ecdade1384f7ab17cb85cedd5d5d563ae217db
        
        Change-Id: Id51ea2dd0d2078d3fc114b6af90c3aa092542215
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117186
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [57d122258437c0a14b303a8d961aa5e8f6f67f57]

        tdf#142832: a blind fix - calculate rectangle size properly
        
        The size was calculated wrong - it needed a "+1". But a rectangle
        constructor taking L, T, R, and B is actually simpler.
        
        Change-Id: I4152f9b43f0ae8f1829038645fcf83bae156c618
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117129
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [b525bc62357282743808758005874d27d87c95b4]

        we don't put images into these checkboxes anymore
        
        Change-Id: I9bf0ba8dabdd6bbff2a88191f87452a213b39178
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117182
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [890ee2a7ab4929cdd5664db12e4d5498be77b723]

        remove unexplained caps_lock_warning/shadow_type ComboBox Entry properties
        
        Change-Id: Id1b0ff8845c03d95651aece905459609edfa090b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [2452a8caac6dbec2cf3d140c67a59f78a0b48404]

        gtk4: create separators on menu import by appending a new section
        
        where we have established that we always have a section in a menu
        to close when opening a new one
        
        Change-Id: I8af90dd89281dd0f10bcec5665d96412108cb5d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [01251c89a15116776e7f5bea93c706443b40c4da]

        gtk4: supporting hiding menu items by moving actions out of actiongroup
        
        and using hidden-when of action-missing and keep the hidden items in
        a different actiongroup
        
        Change-Id: Idaa4f1762c4df2700827fd45527027cc48415548
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117178
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [92849346ba281595cf9cb33cc9197404c95570ba]

        gtk4: add hidden-when of action-missing to menu items
        
        Change-Id: I054f3573c8a251c605ab1f3a426f6a905a908851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117177
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [661e1cc00e4d53459d63a5db8a7142874c7efedd]

        gtk4: connect to underlying ToggleButton "toggle" of MenuButton
        
        e.g. writer, tools, autotext, autotext menubutton
        
        Change-Id: Ie29078eee4daff032421f8838ed2215101eb21e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117171
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [e7d4f3c4dac6f48c87013b7196c1cd466502a350]

        gtk4: reenable a cluster of working dialogs
        
        Change-Id: I11c86ab60354259c8dc98c974d313efe8f8d5acc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117170
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [b1d6c3921002a15a8a34f7725b73ebaaa5bafe48]

        remove double-buffered properties
        
        these are all fat fingered in somehow or another
        
        Change-Id: I0864a5622a244d5e60b368ddc425fc5a9b019060
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117176
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [06b68ee5c14885ced8bc084ddf616de60468e757]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2f5c748e452e2eeb45a71bc7d8b42e7a50ced70f
          - tdf#136435 Update Outline Folding commmand name
            
            Change Ooutline Content Visibility to Outline Folding
            
            Change-Id: I89a9223466d1091386e78218b61a248447099791
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117185
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [8a776fecda43db0bebf5f0028adacce8c2c6afd2]

        sw_uiwriter2: Unify code and use createSwDoc everywhere
        
        Change-Id: Idde2bc4141f33f08ba94cc7498b107e4028f29a7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117136
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [60d83762eb89905f31ca961eb7a54fca15955a8b]

        Use FontList::GetFirstFontMetric instead of custom iteration code
        
        Besides code deduplication, this takes care of case-insensitive search.
        Also fall back to a default font in case of no match in doc_renderFont*.
        
        Change-Id: Ica45ca10c374cf6581ba2f6b60563d6a1447232a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117121
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-14  Stephan Bergmann  <sbergman@redhat.com>  [d3e51bce28a759916e9a3988172ba02b1db66641]

        global-buffer-overflow
        
        ...down in svl::detail::CountRanges during e.g. CppunitTest_sd_tiledrendering,
        after 8aaa28ed43978a9a4a20d62368410a57ec05c23f "Assert on valid order of which
        ids in ranges on SfxItemSet creation" and
        90cb57eb53e28ecb983001bf8f018577abb6d145 "Workaround internal compiler error on
        tb77"
        
        Change-Id: I8ff49384a86676a97ec876ef08426b978e39f6d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117168
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [abced4a161d0502878b2f305cecabf6efca00b21]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b43e4b646206385e20c9d2c6d7a0d80be54d0ad
          - remove duplicate makefile line erroneously introduced with 9fffc3e
            
            breaks the help packaging on windows when creating the msi packages
            
            Change-Id: Ie3c54b4a2ee2cc1168af584c82aabac804f0fee5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117175
            Tested-by: Jenkins
            Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
            
2021-06-14  Stephan Bergmann  <sbergman@redhat.com>  [b33fbd55d63042725ff9a014642f7c6bb02231f7]

        Elide trivial TypeDescriptor_Init_Impl::getMutex
        
        ...after 859978445daeb848d033f64736709503ec44a7bb "flatten
        TypeDescriptor_Init_Impl data-structure"
        
        Change-Id: I6a7484dbbb93e7097edfb01db4f41d37fc4dc4b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117165
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [c3a57aef1fe358dc7ac7df3593eaa0349a3c21a1]

        Resolves: tdf#142767 cannot use itemid of 0 in ValueSets
        
        Change-Id: I2c2b655b512e4e7869fe3784f1b073ecdbd0dac9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117166
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Stephan Bergmann  <sbergman@redhat.com>  [beb9932893b7c4f0b442f807361e1d411511ab51]

        stack-use-after-scope
        
        (Graphic::GetGfxLink returns a temporary GfxLink object---whose lifetime thus
        ends at the end of the full expression---and GfxLink::getDataContainer returns a
        reference into that temporary object---which thus became dangling at the end of
        the full expression.)
        
        Change-Id: I1b84088a74c8c9efb5502f3b3917252858c01557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117159
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c0938c9bb63fa65ea44439b4e838ed0d9fa1260]

        tdf#142393 crash on filter by color dropdownlist (gen)
        
        the frame/window can become disposed during the early stages of this
        method
        
        Change-Id: I974cbeefa75a3b5274e397a6da70db8b7cf73528
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117157
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [bf0a90f80a2c573d65d4795a07bd0b78be7a62e7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 910495baeaf7e845102bc896dc4848f750384244
          - Fix link between Help pages
            
            Change-Id: Ib2c75038c3eb06e9643821705252fe162d95badd
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117167
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [6a71ee9555af6eac4fba78cd94abcd2760ae9870]

        Only look for semicolon if colon is found
        
        Change-Id: Iddc7dc11fe6633b6e7134c5b2e20fc522d0fc0cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117120
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [0e81b8ecbb61572ae50321801c26c2df1eb95ee4]

        Revert "no need to init this on-demand"
        
        This reverts commit c71520d7e7d8e9c669411d6a1beb788e1cba43a1.
        
        Reason for revert: to fix AddressSanitizer: initialization-order-fiasco
        
        Change-Id: I637dfdca4fc51415000f31e658d79a4ec8c17677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117117
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [a21fa7312c45b7b0eb331593f1a6fbeb4d27666f]

        We only support ICU version 4.6 or newer, so drop these checks
        
        The minimal ICU version check is in configure.ac.
        
        Change-Id: Ib6480cd3290dabb45d87c6dcbcc9b5513d172e21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117119
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-14  Stephan Bergmann  <sbergman@redhat.com>  [900506c9060415ab890a9169c4cb7997d0ba8217]

        Adapt compilerplugins to LLVM 13 APSInt::toString change
        
        <https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29>
        "[ADT] Remove APInt/APSInt toString() std::string variants".
        
        TODO:  While most uses of compat::toString should be harmless performance-wise,
        as they are either in error reporting code or in plugins that are not run by
        default, some calls like the one in compilerplugins/clang/staticconstfield.cxx
        might benefit from moving them away from using std::string.
        
        Change-Id: Icfac7d6d4a0a4a4edeb5c8bdcdbc13b73e20a5e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117152
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-14  Johnny_M  <klasse@partyheld.de>  [2bc78bb5b49c9bb78e65c33c905029b22f29de82]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0f05f0f82791941177326fdc3867595f1bf82039
          - tdf#132643 Translate German section IDs
            
            Change-Id: I068f2ae0cb5507c1e324df6d02d49f05269db508
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117087
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [97eb905d9444df8c1c42ef09e95e65a980e73118]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0d763a3b6f9f9f2c665901143f7bc66ea9f8ed34
          - tdf#132643 Translate German section IDs
            
            Change-Id: I652383b613ae36d29ecbc2ebe72d14a7a4ba6541
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117093
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [400abb56cc120ee21fc855ed4fc10d7b6d50e6ed]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 117eb798aa2b07b2c89714fcdcda65af1c96aca9
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ieb84ed0f835b11102e9519cbe348244ef2a89a5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117091
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [44e1fa82488348c16257128b0e6408c34aff64d8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to eccd279e155c167293ae87b098fa1fef0623fb5d
          - tdf#132643 Translate German section IDs
            
            Change-Id: I318584f815048b10c244cd637e741a76d1c37f54
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117092
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  panoskorovesis  <panoskorovesis@outlook.com>  [fff9163cd8ad27d251c06d0e903a71e185009d80]

        Add ClipRegion cppunit test to vcl
        
        The test creates multiple ClipRegions with
        different shapes and tests their attributes.
        Makefile was edited to support basegfx::B2DPolyPolygon
        
        Change-Id: Iabdf744e1749627b2bc4cbc0c8e933b38552e785
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116959
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-14  Johnny_M  <klasse@partyheld.de>  [10c630aabe7d777cb8e7f91ec8c93480128ac53f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 3fe720f7bf761debfe798510728661b4eccfe150
          - tdf#132643 Translate German section IDs
            
            Change-Id: I369080b47e506a890d2a750606cc9c3f95139938
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117090
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [4c3ba67321cc135529c3e4c0eb1fa755d25e59e8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bef511309c6bc73660737a5efbe95480f0e70de1
          - tdf#132643 Translate German section IDs
            
            Change-Id: I69149458178c9f99328a5414ec119664c4f0ac24
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117089
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [58ae9963cc6e14a2475a65a569b1be7a19e30c50]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 015d40f2bba6e8cd417c6e9a8c3aff0fab25d2f0
          - tdf#132643 Translate German section IDs
            
            Improve earlier translations.
            
            Change-Id: I79749cb0aaf0c352c9b493d65558e22b27463a50
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117088
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Johnny_M  <klasse@partyheld.de>  [a20771d184354bffdf24590e80e9b53bac8f2b55]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f6ae0a84932e5a73ad576fc54a288ec29fb4cf17
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ifec93507b6ecce1ffe18daaa5edf0ab0d9e598ff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117086
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-14  Sarper Akdemir  <sarper.akdemir@collabora.com>  [cc7c0387506b546333d5951af98dcfb0fbf75c55]

        tdf#59323: ooxml import: hasNonInheritedShapeProperties
        
        Introduces hasNonInheritedShapeProperties helper to PPTShape.
        
        If the shape has something imported from it's spPr tag
        mbHasNoninheritedShapeProperties set to true.
        
        Change-Id: I0529f1def8d2c32d5bf06172ce44facdde92893c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117003
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-14  Miklos Vajna  <vmiklos@collabora.com>  [547386eef9b1723812dfdab5aed33e9025a372c6]

        sw XHTML/reqif export, OLE data for transparent images: avoid black background
        
        Once a semi-transparent images is exported to reqif in OLE mode, the
        native data is 24bit BMP. This needs some solid color as a background
        for the transparent pixels. The OLE presentation data had white, the OLE
        native data had black, so this was inconsistent.
        
        Fix the problem by going with white for the native data as well.
        
        Change-Id: I1b5e9ed37369b541425cfcd7f690e1b0bba97ddc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117144
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-14  Miklos Vajna  <vmiklos@collabora.com>  [02eea6593e3394ca8020dc3774e8432df10bee67]

        sw: prefix members of HTMLAttrContext_SaveDoc, SvxCSS1Parser, ...
        
        ... SwHTMLImageWatcher and SwWriteTableCell
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib5810ac4de8e8f71410d6800e08755f38d80ee8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117108
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [af8a4e83e316d8085f97c668f880f465d7067dcb]

        enforce RadioButton active within group consistency
        
        make group leader (the one without a group set) always
        active and make the group followers always not active
        
        Change-Id: I8a9ec45e93bf0786ab2895278521027b428c8403
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117143
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [95e986d6fae4e99ac3f1c66911279ab59a7ac1df]

        only one of the radiobuttons in a group should be active
        
        Change-Id: I0475bdd0633b54a644e205628577fac18a3af974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117142
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [1166d8b60ec0bc26a5a1b08e19ec35e6f518df1c]

        if active is set group shouldn't be set
        
        Change-Id: I26db5a96f176df7bd2ef6ef83c40150856845383
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [6aad0ea517ae890ca402ac9d642fd75da68650f5]

        group leader should be active
        
        Change-Id: I79cc2032c8641288ec6def4aaee32cb67e2da915
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117140
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [d1ea8ec1bb4540129a045f6a882a633d3883ae0c]

        set the active button as group leader
        
        Change-Id: Ia3c99d03a9affec493e445bc7edf83be4d333677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117139
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [533549294f93e3a530facef038bbae130afce783]

        move comment to the line above the referenced line
        
        so pretty-printing doesn't afterwards change this file
        
        Change-Id: Id581d837013973045a0984484deea22a27db09a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117138
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Mike Kaganski  <mike.kaganski@collabora.com>  [90cb57eb53e28ecb983001bf8f018577abb6d145]

        Workaround internal compiler error on tb77
        
        As reported in https://ci.libreoffice.org/job/gerrit_windows/98360/console :
        
          C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2639): fatal error C1001: Internal compiler error.
          (compiler file 'msc1.cpp', line 1591)
           To work around this problem, try simplifying or changing the program near the locations listed above.
          If possible please provide a repro here: https://developercommunity.visualstudio.com
          Please choose the Technical Support command on the Visual C++
           Help menu, or open the Technical Support help file for more information
          C:/cygwin/home/tdf/jenkins/workspace/gerrit_windows/svx/source/svdraw/svdedxv.cxx(2631): note: while evaluating constexpr function 'svl::ItemsArray'
          INTERNAL COMPILER ERROR in 'C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1427~1.291\bin\Hostx64\x86\cl.exe'
              Please choose the Technical Support command on the Visual C++
              Help menu, or open the Technical Support help file for more information
        
        tb77 uses VS 16.7.7 (cl.exe is under Tools/MSVC/14.27.29110); tb68 with
        cl.exe under Tools/MSVC/14.28.29910 has no problems compiling this.
        
        Let's make the code simple for now, until we upgrade the tooling on CI.
        
        Change-Id: I10aaf289454c89b2f49b4be947627a9a3be30fde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117137
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-14  Sarper Akdemir  <sarper.akdemir@collabora.com>  [c5676a08eb57d30c11bd201f8d2c328165c8143f]

        tdf#59323: ooxml import: hasShapeStyleRefs
        
        Helper function to determine whether the shape has style refs or not.
        
        Change-Id: I57b244b4af5b9e3abba90f0e4e25a35da27e3409
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117002
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-14  Sarper Akdemir  <sarper.akdemir@collabora.com>  [b2869ca51c2e30128456cbdee7e526bacd9cc905]

        tdf#59323: ooxml import: add OOXML to LO datetime helper
        
        Added static helper functions getLOTimeFormat and getLODateFormat to
        TextField class for mapping datetime field types to SvxDateFomat and
        SvxTimeFormat.
        
        Change-Id: I9c1553cc89d47855dc7af06a8ea995de01692ded
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117001
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [c71520d7e7d8e9c669411d6a1beb788e1cba43a1]

        no need to init this on-demand
        
        we ~always need it
        
        Change-Id: I94ea47ed75478ecc7c78e89c0209a22d21be2b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117133
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-14  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [f420528eaf7b02cf755a1a61f41aa98bd9bb2f32]

        pragma once - BackendCapabilities
        
        Change-Id: Id37ea7e70a81afbe2c4f3590569af863e0f7824f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117103
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-14  scito  <info@scito.ch>  [213a6792990daab666856a532f8212b2601bd28a]

        ucalc_copypaste: improve readability and shorten
        
        The tests are written in a simpler and shorter way. (The same, but 858 lines
        less.) I've transformed the code with several regex in VSCode. I've
        made a manual clean up at the end.
        
        The regex are listed below in the form
        
        ***
        
        search regex
        
        replace regex
        
        ***
        
        aString = m_pDoc->GetString\((\d+,\s*\d+,\s*\w+)\);
        \s*CPPUNIT_ASSERT_EQUAL\(OUString\("(.*)"\), aString\);
        
        CPPUNIT_ASSERT_EQUAL(OUString("$2"), m_pDoc->GetString($1));
        
        ***
        
        m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\);
        \s*CPPUNIT_ASSERT_EQUAL\(OUString\("(.*)"\), \w+\);
        
        CPPUNIT_ASSERT_EQUAL(OUString("$2"), getFormula($1));
        
        ***
        
        m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\);
        \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", OUString\("(.+)"\), \w+\);
        
        CPPUNIT_ASSERT_EQUAL_MESSAGE("$2", OUString("$3"), getFormula($1));
        
        ***
        
        ScAddress \w+\((\d+, \d+, \d+)\);(\s*//.+)?
        \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\);
        \s*\w+->SetText\(\w+, "(.*)"\);
        
        setNote($1, "$3");$2
        
        ***
        
        ScAddress (\w+)\((\d+, \d+, \d+)\);(\s*//.+)?
        \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\);
        \s*\w+->SetText\(\w+, "(.*)"\);
        
        ScAddress $1 = setNote($2, "$4");$3
        
        ***
        
        ScAddress (\w+)\((\d+, \d+, \w+)\);(\s*//.+)?
        \s*ScPostIt\* \w+ = m_pDoc->GetOrCreateNote\(\w+\);
        \s*\w+->SetText\(\w+, "(.*)"\);
        
        setNote($2, "$4");$3
        
        ***
        
        m_pDoc->GetNote\(ScAddress\((\d+, \d+, (\d+|\w+))\)\)
        
        m_pDoc->GetNote($1)
        
        ***
        
        "There should be(\s+\w+) note on (\w+)
        
        "$2:$1 note
        
        ***
        
        HasNote\(ScAddress\((\d+, \d+, (\d+|\w+))\)\)
        
        HasNote($1)
        
        ***
        
        ASSERT_DOUBLES_EQUAL\((-?\d+),
        
        CPPUNIT_ASSERT_EQUAL($1.0,
        
        ***
        
        \w+ = m_pDoc->GetString\((\d+, \d+, (\d+|\w+))\);
        \s*CPPUNIT_ASSERT_EQUAL\(EMPTY_OUSTRING, \w+\);
        
        CPPUNIT_ASSERT_EQUAL(EMPTY_OUSTRING, m_pDoc->GetString());
        
        ***
        
        \w+ = m_pDoc->GetString\((\d+, \d+, (\d+|\w+))\);(\s*//.*)?
        \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", EMPTY_OUSTRING, \w+\);
        
        CPPUNIT_ASSERT_EQUAL_MESSAGE("$4", EMPTY_OUSTRING, m_pDoc->GetString($2));$3
        
        ***
        
        fValue = m_pDoc->GetValue\((\d+, \d+, (\d+|\w+))\);(\s*//.*)?
        \s*ASSERT_DOUBLES_EQUAL_MESSAGE\("(.*)", (-?\d+), fValue\);
        
        CPPUNIT_ASSERT_EQUAL_MESSAGE("$4", $5.0, m_pDoc->GetValue($1));
        
        ***
        
        fValue = m_pDoc->GetValue\((\d+, \d+, (\d+|\w+))\);(\s*//.*)?
        \s*CPPUNIT_ASSERT_EQUAL\((-?\d+(\.0)?), fValue\);
        
        CPPUNIT_ASSERT_EQUAL($4, m_pDoc->GetValue($1));$3
        
        ***
        
        m_pDoc->GetFormula\((\d+, \d+, \w+), \w+\);(\s*//.*)?
        \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.+)", OUString\("(.+)"\), \w+\);
        
        CPPUNIT_ASSERT_EQUAL_MESSAGE("$3", OUString("$4"), getFormula($1));
        
        ***
        
        aStr = m_pDoc->GetString\((\d+, \d+, \w+)\);(\s*//.*)?
        \s*CPPUNIT_ASSERT_EQUAL_MESSAGE\("(.*)", OUString\("(.*)"\), aStr\);
        
        CPPUNIT_ASSERT_EQUAL_MESSAGE("$3", OUString("$4"), m_pDoc->GetString($1));
        
        ***
        
        m_pDoc->GetNote\((\d+, \d+, (\d+|\w+))\)->GetText\(\)
        
        getNote($1)
        
        ***
        
        Change-Id: I4000b7f89a0bee1d2d52abfd6c1b055470e39d02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117085
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-14  tobias  <tobias.schulz@hotmail.com>  [62503c3acde8eab0ca198f66519270761f64d56d]

        tdf#142669 Assert data alignment in unit test
        
        The alignment of a pointer size was not checked in unit test
        txtexport.cxx. This could have caused errors in future test cases.
        
        Change-Id: If0af5c75a9fc5c757cab6ac900b685d3c70fca8b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117026
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-14  Justin Luth  <justin.luth@collabora.com>  [343d4d32f00053bd72cfe240125835fe25ce264f]

        tdf#108518 revert OOo hack: Fix issue #i119405: Numbering text style
        
        ...changed after importing the *.doc
        2012 commit 1c22545edf9085b9f2656ca92781158b6b123db3
        
        This hack has been made irrelevant by layout support for
        copying paragraph CR formatting to the numbering.
        It can be improved even more for DOC by supporting
        RES_PARATR_LIST_AUTOFMT.
        
        The OOo guys who made this knew it was a hack.
        They document in https://bz.apache.org/ooo/show_bug.cgi?id=119405#c11
        > Negative Impact:
        > Although most common user scenarios can be met by the solution,
        > there are still negative impacts. Because the attributes of
        > paragraph end mark(0x0D) will be set to the character style
        > binding to the given level of a number rule,
        > it will have the global impact.
        > Other paragraphs that are applied with the same number rule's
        > level will also be changed.
        > Generally, MS Word users will have their numbering/bullets
        > the same attributes/style when using the same level's
        > of number rule, correspondingly,the impacted scenarios are rarely.
        
        So, the bad thing that was happening was that any paragraph's
        CR formatting could change every instance of the numbering level's
        formatting - not just that one paragraph's number.
        The first instance of the defined formatting won.
        
        tdf#133410: Also, it spammed a new char style
        for every numbering level.
        
        This patch depends on an earlier commit. The unit test ensures
        that this earlier commit exists. It was the only example I found
        where reverting the hack failed.
        
        Change-Id: I43b88b8219c9dbc882f57d1a282749d7c0ab2a19
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112320
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [859978445daeb848d033f64736709503ec44a7bb]

        flatten TypeDescriptor_Init_Impl data-structure
        
        avoid unnecessary pointer-chasing for something we are going
        to use ~always
        
        Change-Id: I9e1ae0c5b1754fca2e7e1c26441c598dd0eea5dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [f17b8b7b57de5f78b4e92f762ae389eb6cebc016]

        only one of the radiobuttons in a group should be active
        
        Change-Id: I7283e257e44f755e5bb3d6612be625a6f680edb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117102
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [2e7e471b99d3c5a5c0ee4bf58306d05292569769]

        gtk4: reenable pdf export dialog and pages
        
        Change-Id: Ie9c1846343bf74b25e33f79f31b9eee8631fab9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [f7d3a9bd9293007868316194364beaf0966fbcec]

        spurious image position of right in CheckBoxes that don't use images
        
        Change-Id: Ib175c267a9d5e7dd7987e34f7f4b7477595c5adc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117100
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [0b7bcd870e5849650d1cc182b4fe30ddbc2bb208]

        gtk4: reenable some more working dialogs
        
        Change-Id: I857d96cfdf17accdcfd973ea04c51a34a3b68863
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117099
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-14  Caolán McNamara  <caolanm@redhat.com>  [f408713503a6c03427f8736c2bb2216cd151b2a5]

        ofz#33769 Integer-overflow
        
        Change-Id: I6b76ab866cc843f52b3c0994e9812a0f1b87270c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117098
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-13  Michael Weghorn  <m.weghorn@posteo.de>  [6bfa94398a0ea501fce7634ab0ae9ce35c442043]

        tdf#142618 android: Don't crash when passed MIME type is null
        
        Change-Id: I5fb532b36fe650596f25a1ba8b7dc56e21292dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117053
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-06-13  Caolán McNamara  <caolanm@redhat.com>  [d5823a0dc5e75b2d6440bdc64c934648b2657244]

        drop some unused suppressions
        
        Change-Id: I1c9223f811e4d28150c10af46a6d43d1f09c9a8e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117097
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-13  Caolán McNamara  <caolanm@redhat.com>  [2ebf40bc1d721467f2441bf83aa7d47bc12b0434]

        ofz#34297 Indirect-leak
        
        this is similar to the memory leak fixed by
        
        commit d6e752d5ebfaf66d1c9b0694f9c8582311d6151a
        Author: Jian Fang Zhang <zhangjf@apache.org>
        Date:   Mon Jun 18 12:26:30 2012 +0000
        
            i#113608#, memory leak in animations: newly exposed crashed problem
        
        where the parent node holds a reference to its children and the child
        held a reference to its parent.
        
        Change RandomAnimationNode to use a WeakReference to its parent like
        the other AnimationNodes do
        
        Change-Id: I251a6127c301d1fb7e51397d8f05db4020bc612c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117096
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-13  Mike Kaganski  <mike.kaganski@collabora.com>  [8aaa28ed43978a9a4a20d62368410a57ec05c23f]

        Assert on valid order of which ids in ranges on SfxItemSet creation
        
        This allows to make sure we actually use sorted which ranges,
        and then it's safe to call SfxItemSet::MergeRange when needed.
        
        Also this change relaxes the previous requirement that ranges
        must be separated by at least one; this allows to have adjacent
        ranges, like in
        
            RES_FRMATR_BEGIN, RES_FRMATR_END-1,
            RES_GRFATR_BEGIN, RES_GRFATR_END-1,
        
        where RES_FRMATR_END is equal to RES_GRFATR_BEGIN. Allowing this
        makes possible to (1) self-document the ranges, so it's clear
        which ranges are included; and (2) be safe in case when these
        constants would change, so that the one merged range would not
        unexpectedly contain everything inserted between RES_FRMATR_END
        and RES_GRFATR_BEGIN.
        
        Change-Id: Iaad0f099b85059b3aa318a347aa7fbd3f6d455c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116909
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-13  Mike Kaganski  <mike.kaganski@collabora.com>  [f7c7e4c63f5479de66d2fbed9db34972a5bd05aa]

        Avoid [-Werror=redundant-move] in GCC 9.3.0
        
        Change-Id: I5ef8e094de76673c53b989fd659597b38c3f8d50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117112
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a565968c2d5c7822f99266b36631e073234d48ab]

        bump product version to 7.3.0.0.alpha0+
        
        Change-Id: I22adfa913dad2a4ae5d6fbeab87daf22f5545282

2021-06-13  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ff2ba77f22b2e96f96f5537aec1705956b47583d]

        Update git submodules
        
        * Update translations from branch 'master'
          to 47d2e3a3e6f9d4e2b17ff79b3a9cbdbe4619af16
          - update translations for 7.2.0 beta1
            
            and force-fix errors using pocheck
            
            Change-Id: I7ed5a77fb3ccb004ba1b79c55ae56a84c82f2803
            
2021-06-13  Georgy Litvinov  <git@litvinovg.pro>  [51d1952cf05381a48e6b0797d5e001452181b1ec]

        tdf#142741 and tdf#38187 Set valid pages for footnote links PDF export.
        
        Change-Id: I7c00e1a522a51796c9f543a74bd8abcee6792faf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117078
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-13  Noel Grandin  <noelgrandin@gmail.com>  [07021596acb3d104ba129d371b1ae0b79f67a6a4]

        tdf#142242 Forename imported with trailing space
        
        Fix the case where there is only a name, and no surname.
        
        Change-Id: If11078364924c8332b113e5650e7ea2b262a357a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117080
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [93a3e2f86c27b06062708fe788963a0e49f3a90b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 390d5cf871798108c4a45b78dfcdb22bbd4667cc
          - tdf#126507 Add help page for Combine Text in Draw
            
            Change-Id: I8fc7b9fa152d732486ac59c3d9544ac12a39e5e7
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117082
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-12  Olivier Hallot  <olivier.hallot@libreoffice.org>  [90b570fd7f53b32052e0bbc2578eeaf87fd800b7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 94dc2e8bcf072bf62af674603cd9a5bc1a5d91bd
          - Fix embed links
            
            Change-Id: I5241d5b8e1417708bd8e4dfdee522cf6f5f6ccc9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117083
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-12  Martin Srebotnjak  <miles@filmsi.net>  [a4bcf86b3ab3ccbbaff89c3b5d3c1fa426bb01e0]

        Update git submodules
        
        * Update translations from branch 'master'
          to 9b5d7036b809fb61a73e6a5b86bd3fcfbcda81f7
          - Update Slovenian translation
            
            Change-Id: I0b057409ee977097fd4020cd5cc606b5d4da1e63
            
2021-06-12  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [e0237886450dcd3e6d3200ef533d2b3d7f0f8c19]

        tdf#128018 - Add column/row labels to the descriptive statistics
        
        Change-Id: I22840433954a217ef5b5c1d3ea20e935d322e767
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116852
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-12  Mike Kaganski  <mike.kaganski@collabora.com>  [01de216daf6dda0fb809bfa1919fcd13e6953ee9]

        Current baseline Clang 5.0.2 is able to upcast std::unique_ptr
        
        Change-Id: I5ede872a6a629be1bcbd4d3e6fbd604cc76f1d77
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116911
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-12  László Németh  <nemeth@numbertext.org>  [eeee19b3fcf8b0374c361c7f6c285fd5c89b5a2f]

        tdf#142387 DOCX track changes: export w:del in w:ins
        
        by processing stack (revision history) of redline ranges,
        see GetStackCount() and GetRedlineData().
        
        Change-Id: I7a9085bc1598f0a5e3ab4de6887a12e81738d4f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117069
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [7811a31df77db992e666363aa0bd12e5ea32629d]

        Fix typos
        
        Change-Id: Ibd4f8ac232eddad2b8a6c970999f0adf61a07acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117077
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2021-06-12  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0c8fa16c78e6887d6d3a6041166d388e266bbce7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c13c0567cc458e30b2947110f5a76015f52b4200
          - Fix typos
            
            Change-Id: If1fce3d46d1b26408fc4557c426c18ace6c07277
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/117076
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-06-12  Noel Grandin  <noelgrandin@gmail.com>  [715797bc2b361960d70095d6e6d289de063e1d5c]

        Backgrd -> Background
        
        Change-Id: I55bccacfe6c6b44570a24e9f5125e40a1a83d6ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117073
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Luboš Luňák  <l.lunak@collabora.com>  [6b349bcc32336664a31deed3f4463e40dd028f63]

        when converting WMF to WMF, simply do a direct copy
        
        Actually, if we have the graphics data, just copy the graphics data,
        that'll keep both the EMF+ and non-EMF+ content.
        
        Change-Id: Ia14df0ba2a94d4310ee745b49de1d2190e425f05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117063
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-11  Luboš Luňák  <l.lunak@collabora.com>  [b342a445cd8b115e76d261860088b012b74c0b0e]

        drop EMF+ also when converting WMF, not just EMF
        
        A WMF may have EMF with EMF+ actions embedded. When we read that,
        we drop drawing non-EMF+ actions if we use EMF+. But EMF+ actions
        are stored as MetaCommentAction in the metafile, and WMF writer
        (unlike EMF) writer simply ignores comments. So when writing WMF,
        make sure to read non-EMF actions so that something is written.
        
        This is an extension of 295626a0bd39540544b774094a63df23e5376839.
        
        Change-Id: I37355f694fe656b661abe54274ea203934e68151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117062
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-11  Eike Rathke  <erack@redhat.com>  [381bc9d9acd461415cf81eef71ec3dd935a07b62]

        Related: tdf#127013 Check loaded separators for validity
        
        ... not only if something is present at all.
        That way future restrictions can reset separators.
        
        Change-Id: I738bcb9e052e8dbecb0a6cd07bbae8f4a8ea1c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117072
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-11  Rafael Lima  <rafael.palma.lima@gmail.com>  [6804eb2c740d2b2310399ae14bfa0bb2e6e24a91]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 38ce99f8010aed59242b817b866055407f22cefb
          - Create introductory ScriptForge help page
            
            Change-Id: I5fd00cc05b0c28b600974c005a81804c1c6d5e74
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116906
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-11  Eike Rathke  <erack@redhat.com>  [bb54d6d8241a06a6772052b77b67d6a4f686426c]

        Resolves: tdf#127013 differentiate non-/array separators and restrict
        
        Change-Id: I9ff6b816b0c7af9081954fa407a4d516a576a338
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117068
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [37ddff25a67aa0b858da0e56fe7263a537002f7b]

        gtk4: starting point for welded menus
        
        submenus will need a rethink I guess
        
        Change-Id: I6d2a645267146c537fe7ba62d8be2501855e7f62
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117067
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [0df9c8c3cd16d6485c4486d9c983715b647e7090]

        gtk4: build deeper levels of GMenuModel
        
        Change-Id: Ia2cbe4fdc583d272152b4eaa9da9f9d2ff4af550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117066
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Luboš Luňák  <l.lunak@collabora.com>  [2020fc9c7d2c778e8206dcc891d5a77f92ac951c]

        MetaAction::Clone() -> const
        
        Change-Id: Ie5785127a1fb202b146710dfedf3838d2a607670
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117035
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-11  Olivier Hallot  <olivier.hallot@libreoffice.org>  [b682c8c62b2bd6bd66b22c872a2b65b67892c1fa]

        Add extended tips to bulletandposition.ui dialog
        
        Change-Id: Ibb6c4013c587cc89b1438c264554d9e356467680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117060
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [c384c7d7ae39495a9cfd55c3d610133f97db1304]

        Simplify Sequence/vector initializations
        
        Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [8d3e7b2f5836106eac5172d8f4868bb540d652e6]

        EMF tdf#59814 tdf#142567 Align RestoreDC record with MSO implementation
        
        Some of WMF and EMF behaviours are undocumented.
        In that case, we are implementing the behaviour, observed in MS Office
        or MS Paint.
        
        With this commit the behaviour of import EMF RestoreDC records,
        will be the same as for MS Paint and MS Office.
        
        Change-Id: I73b65d14018f2667ffd59daf16ecc6d7ce9c1870
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117052
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-11  Miklos Vajna  <vmiklos@collabora.com>  [a73e8f1111f4baa8073c998ad84783dd5fc6b7bb]

        sw define bibliography entry dialog: unconditionally allow the browse button
        
        This eliminates the "Local file" type, arguing that regardless of the
        type of the bibliography entry, it may make sense to associate a local
        URL with that.
        
        Additionally, this allows using the file picker with non-HTTP URLs, like
        webdav.
        
        Change-Id: I315facdcf292f439765c420e5368a99267fe1a98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117059
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-11  Jean-Pierre Ledure  <jp@ledure.be>  [af3f99dd1f42cb57d8a50b444ab303b5eb81527a]

        ScriptForge - (scriptforge.py) add reference to SF/Python help page
        
        Change-Id: I68ec6c53bbf9f6631f33192776b154936c1b721e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117065
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [b49fce18d0b05a8b5f462ba9bf6c84f0bb107d93]

        Simplify vector initializations
        
        Change-Id: Icf8972be204799e9b3b3824ab18d8584911fe1c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117061
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [513b54df70b5b9cde8d6ca2304378949256eea1d]

        gtk4: support separators via manipulating menu sections
        
        Change-Id: Iaade04dd5a4fa89ef74a22a19ebe5e37655fc61a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117058
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [73299faa75a4974eb49c93ffdfb2d6329cb4e519]

        use freshly compiled dump_syms.exe on windows for symbolinfo extraction
        
        while self compiled one still segfaults frequently, it is a tad better
        than the included one (and compiling froms source instead of using
        precompiled binaries is a net win in any case)
        
        Out of 50 attempts with the mergedlo.dll, the new compiled dump_syms
        succeeded 11 times, the shipped one succeeded 7 times - so could still
        be regular variance in that small sample size, but at least not
        significantly worse either.
        
        Change-Id: I86c213fe6aece58f1391d4c2bf9906b85eee9c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117056
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [3b46c3068af26d6be65cfe309c751e310a22d129]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        Another place where SfxItemState was used as placeholder
        
        Change-Id: I54e549db50b7485024a305eb39fda848cbed6b78
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117036
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [eb0222e80ba6f5b7b11f1e43f3723162beb2ba71]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        The mechanism around NUMRULE_STATE does only do something
        when the SfxItemState is actually SfxItemState::SET, so this
        can be reduced to use a valid Item shared_ptr when this is
        the case
        
        Change-Id: I973648abff3696057f2ca21608ed64570742dddb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117043
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [64378ded7b87fa785f13b998e006d87f44a2776d]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        Another place where SfxItemState::UNKNOWN was used as placeholder
        
        Change-Id: Ie2757e8356bfea7010b0442d72ef7865cbb18d5d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117034
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2021-06-11  Michael Weghorn  <m.weghorn@posteo.de>  [fd4bcd5f33fed46cacaa00f90a271b18b6355345]

        qt5/kf5: Fix crash on exit
        
        This extends the solution from
        
            commit fa8db25af6218262b3dab2e93b76464975889ceb
            Date:   Thu Jun 3 20:47:10 2021 +0100
        
                gtk4 crash on exit
        
        to cover the qt5/kf5 cases as well, after seeing
        equivalent crashes with kf5 VCL plugin
        (e.g. when starting Writer and no profile exists) after
        
            commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
            Date:   Wed Jun 2 13:06:54 2021 +0200
        
                fix shutdown leak in CppunitTest_sw_filters_test
        
        Change-Id: I4ef25bac0891c059588dbc8e6abe50db14230dea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117042
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [57796f2724f004679f78eb144a93b9a03968317c]

        Simplify Sequences initializations (writerfilter/writerperfect/x*)
        
        Change-Id: I1bd31fe6cf0f8aaf4f2cfe1d3d49e61a0633f361
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117057
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [92889bc98f4e822715874cb80346d8370e9da8e6]

        Simplify Sequences initializations (vbahelper)
        
        Change-Id: I9bbcf97acd59e7430758e05ae949f7e494afc704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117051
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [771c8282aadb45373fc6348cc70f4cd75a43a396]

        Simplify Sequences initializations (vcl)
        
        Change-Id: Id93bde17dbc4c71ad93bc094b94408fc9e39ec98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117055
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [430fffdd64af4ae09bbc49328c5188fc2dd4e185]

        loplugin:unusedmethods improve filtering
        
        Change-Id: I75771dbcecd58259bffdd2ddb0df631205aa8d93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [39b8ce7081888b5d5e73ba0b49396b09ca7f3b61]

        Simplify Sequences initializations (unotools)
        
        Change-Id: Ibc5deee4b69213310a75c2a74a800d99bc451424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117047
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [a75596f3f8d3660bd96a107eb13a2ea210be5b66]

        Simplify Sequences initializations (ucb)
        
        Change-Id: Idd38076a40b1177253719c01c1928da4c903151c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117017
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [f676b194faf2805529556c2f1da0578b58bf37de]

        Simplify even more initializations in svl/passwordcontainer.cxx
        
        Change-Id: I42cb919a8853df050d71b97f86abd20fdfccb5a6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116978
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [76a69fb0bb1d849a2a7e76e209a30db149d79cdd]

        Simplify Sequences initializations (sw)
        
        Change-Id: I02647bdb720620afe20284a069a71c19dbfcea05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116944
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Julien Nabet  <serval2412@yahoo.fr>  [b1fe17f280b24e78e7ee55d4762dc64a98d6f302]

        Simplify Sequences initializations (sc)
        
        Change-Id: I0c581b3a900a6b89c0f4e203310d65600545987f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116929
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [51178765e8afe33ebbb2016219cff869d88ca07f]

        sw_uiwriter3: Unify code and use createSwDoc everywhere
        
        Change-Id: I8054b4a9661e1873fa30390b7f7c85bd654343ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117049
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [0dd193126a60be3324673fdd3992013fc8c42b9e]

        gtk4: process sections and submenus of toplevel menumodel
        
        and place initial contents into a section by default
        
        Change-Id: I1e7bb20bf5efb481e4f7ed0f38c8b46c06f7a7d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117050
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [8ce77cbd706ffd60dfcd79d82779025ef8d6782c]

        cid#1473844 Untrusted loop bound
        
        and
        
        cid#1474351 Untrusted loop bound
        cid#1474118 Untrusted loop bound
        
        this time without second guessing the original intent
        
        Change-Id: Iaa6b636a08ed29feaf709fbcbac7deac761a0fc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117045
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Alain Romedenne  <alain.romedenne@libreoffice.org>  [3914dd55c45bef6b0dbfd7c6eba1f0b4b43743ba]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab81b6bfa02cd89c244bc55148486324863844f8
          - sf_form(control) Python support
            
            Change-Id: Iad14d1c5c7d353e50aba84d0cfa461e56f69f4ef
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115969
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [b1d19950d3f89460109dfc0e3720ac22d4307ff8]

        Resolves: tdf#142758 Revert record parse misunderstanding
        
        of 'Related: cid#1474351 Untrusted loop bound'
        
        and add in documentation for the records
        
        This reverts commit 2134d83b8d6e73ca8eacd812eb3431bff38c74f6.
        This reverts commit 7c2e6058439da9d061e5e0bbd07c8b6d4f2ffcbf.
        This reverts commit 3748fe3e4fc22a400b3120010192b75754e38b17.
        
        Change-Id: I5b407eb4388a8d67fc863cc6070fbbf8b15321d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117044
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [4fbc246c7021248e4e9689f59b030b4b8f526954]

        loplugin:unnecessaryreturn in SvxColorValueSet::layoutToGivenHeight
        
        Change-Id: Ia42158597588fe802a2f06a6e8e59f372c62c022
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117031
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [eea9224017d282324bdced180f8e13249da1f5bd]

        uiwriter: use createSwDoc instead of loadFromDesktop for empty docs
        
        Change-Id: Iacfda21398bfd920c5e0be62893ba723ee99d738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117041
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [066599203ce143b3614e0fa298a05ed28ba2ca63]

        no need to make a copy here
        
        Change-Id: I47d51d3d372403f30ab38697037cdb205839df44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117030
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Miklos Vajna  <vmiklos@collabora.com>  [7413cc96d239f5fd5a588f13784ccb82b6968bac]

        sw image anchor type: consider a style-based custom value
        
        The anchor type is determined during insertion, it's stored as direct
        formatting after that.
        
        We used to have a user-profile default for the anchor type. This commit
        allows customizing the Graphics or OLE styles: if they specify a custom
        anchor type, then that is user instead of the user profile setting.
        
        This allows creating templates where the default depends on the used
        template and not on the user profile.
        
        The UI for this was added in commit
        5951da5175b9d7e5b3b47bd0d90989d2ef528c79 (sw image anchor type: add
        style UI for this, 2021-06-10).
        
        Change-Id: Id05342a5f38dc6267cdbe68b248dc50b87854ce2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117040
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [79260c7cd80107f223e0f9bcf4bd91ae40566cbe]

        ofz#35150 crash in Bitmap::Crop from wmf load
        
        which is a problem since...
        
        commit 33d2cf7008de79106b5da4bba0241aa14d81d88f
        Date:   Sat Jun 5 19:30:46 2021 +0200
        
            WMF Change the sign of read fields in BITBLT and DIB records
        
        Change-Id: Iea1261a52866d691435f0612f672636009c00355
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117039
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [54344deb66b2aca47bfcc9cadcbc0262fc4c138b]

        ofz#35149 crash in vcl::bitmap::CreateFromData from wmf load
        
        which has started since...
        
        commit 01ded1e6d362dbcd7148334c6965d6ad00981d4a
        Date:   Tue Jun 8 23:07:28 2021 +0200
        
            WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt
        
        Change-Id: I5bbde55dbd9e239c05544ac4a21e2758770245d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117038
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [cabb9f5c8e22a23a453559636d9c9b3c2b0a5984]

        WMF/EMF tdf#59814 tdf#142567 Fix RestoreDC record
        
        With previous implementation, the RestoreDC index argument was skipped,
        and always the last entry was taken.
        
        With this commit the support for reading SaveDC by specific index
        was added. The SaveDC/RestoreDC index support was added for
        both EMF and WMF, according to [MS-WMF] and [MS-EMF] documentation.
        
        Change-Id: I9b8a1a41462ae01de25ac3c85e453bcd80e05537
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117033
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [2e415a90958bb00f460dccb303bc22853244292b]

        Related: tdf#139447 DBTreeViewBase ctor takes a bool if its a sqltype or not
        
        Change-Id: I7924dfb3dc15e34fae93b435e1a9e76f3da29463
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117037
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [36b33c50bd620a0879bf5c8b29de3ac2dada19d0]

        loplugin:unnecessaryreturn in sw/
        
        Change-Id: Iaca3f5385fd2c763cd1121ae50624aaa4a1f6165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117029
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [02a5c22e8e4f91b6a8522126b8086520ebb78284]

        loplugin:unnecessaryreturn SwWrtShell::Toggle*
        
        Change-Id: I221dca35df23205023cf675b83c94c83178217d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117028
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [2df2ce1b51d13bc9e203fab1b7eb3c88c906588c]

        math.desktop include "Spreadsheet" category
        
        but it's not a spreadsheet
        
        since...
        
        commit dad7fe7227fb80a32d3c2c777584dc9d74b9e929
        Date:   Thu Jan 2 16:16:55 2014 +0100
        
            Fix math categories to make SUSE rpm check happy
        
        Change-Id: I0397ea12cd7f29f4b0c1f0e0ad76a3429b55c455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116884
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-06-11  Luboš Luňák  <l.lunak@collabora.com>  [f62a353a7f8fa2cad365a47fc763781a86425e87]

        "drawinglayer" -> "drawinglayer.emf" log area for some emf code
        
        Change-Id: I83fa2d40225f83b82cea7f8934f4afdee181abe3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117000
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-11  Caolán McNamara  <caolanm@redhat.com>  [3c325bd525d7726395db733e684b84b1659bd41a]

        tdf#139447 crash on dragging query/table from explorer to calc sheet
        
        Change-Id: Ic827cb967a9a9cb78f28a23707813aeec8381cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117018
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-11  Miklos Vajna  <vmiklos@collabora.com>  [3514b18f173c1ed7ab32e9d8820a588ba0d880d7]

        CppunitTest_vcl_svm_test: add missing basegfx link
        
        Missing probably because
        https://gerrit.libreoffice.org/c/core/+/116967/1 was merged before its
        https://gerrit.libreoffice.org/c/core/+/116959/4 parent.
        
        Change-Id: I0c6304c98f27e1f24ee615e4580c8ad7458bf79b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117027
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [2baf6f654244a67715e4b3d86c49144ce6b5dd13]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        ParaLineSpacingControl::Initialize() is another place where
        SfxItemState::UNKNOWN was just used as a placeholder for
        a non-set SfxItemState (aka could not be queried)
        
        Change-Id: I95ad01579e5aa4c86ace619e2201481742297c2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117016
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [552ceeb5c6ccf2573adfd092cc4b2ce214a9c2df]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        FontworkBar::getState does not need to check for SfxItemState::UNKNOWN
        at all, actions solely depend on FontWork object being selected.
        This also greatly simplifies that method. Also, the optimization
        by passing in a variable to checkForSelectedFontWork and remember
        if already computed can be removed - also in other places where
        it had to be given, but was not re-used at all
        
        Change-Id: I35b1f36195feb1d645619665d2dd65a84b75b118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117014
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-11  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [5c3ad59612697cf0afee0f836e9ee77f0920356b]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        In this case SfxItemState::UNKNOWN was used as boolean
        state to decide to keep extracted value or replace. First
        method even throws an exception when SfxItemState::UNKNOWN
        should happen.
        I tried to be very careful in changing these methods, so
        another look/check from reviewers will be welcome. I think
        that code was unnecessarily complicated, too, butz hope to
        not have touched semantics (behaviour) at all
        
        Change-Id: Id213fedcafcfb655749caf2659f9a15b240ec27d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116999
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-11  Stephan Bergmann  <sbergman@redhat.com>  [d4a478af9cb3154ca1a2179240750865ee3ede91]

        Remove duplicate code
        
        The two
        
        >             aSet.Put( aAnch );
        
        had been like that ever since at least 84a3db80b4fd66c6854b3135b5f69b61fd828e62
        "initial import", but only now aa9cb8e14749e7fb7a83b55a2bb095501f731a18
        "-Werror,-Wunused-but-set-variable (Clang 13 trunk)" removed the lines of code
        between them (and which should not have changed neither aSet nor aAnch as a
        side effect, which could have explained the putative duplication), making the
        duplication stick out.  Lets assume this was an error ever since, and that just
        one call is enough.
        
        Change-Id: Ie1ad54fb31212849f242eea77bc9e436b6fd92f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116980
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-11  Miklos Vajna  <vmiklos@collabora.com>  [2f6f533b76d6dd12a8d8356eedbb3f497be41739]

        sw: handle InvertBorderSpacing when replacing compat options
        
        This was added in commit de0866b507e259f1726d1015293aad8fcadd763a
        (sw-invert-border-spacing.diff:, 2010-09-14), it's off by default and is
        on for Word documents.
        
        Change-Id: Idf1999dbe9e641259e09eaafbebd347199cd5db4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117015
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-11  panoskorovesis  <panoskorovesis@outlook.com>  [794eda02133699830913b37e094a07edeaeff22d]

        Add IntersectClipRegion cppunit tests to vcl
        
        Two tests where added, IntersectRectClipRegion and
        IntersectRegionClipRegion, along with their .svm files.
        The tests create mutliple IntersectClipRegions and test
        their attributes.
        
        Change-Id: I33b7b13b4f3eef1de07cc063ef22fea034d65cfc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116967
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-11  Jim Raykowski  <raykowj@gmail.com>  [239b4bb27fd8db26e8416045b3015688a8b1b0ae]

        Resolves tdf#142651 Writer: Next Change stopped working
        
        by normalizing copy of PaM instead of reference
        
        Change-Id: If2c8664de18eb9473151c5961ad7654932ca37e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116875
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [b0712101351b084e5073d41052a0abc4f36f4789]

        sw_uiwriter: remove duplicated createDoc method
        
        Change-Id: Ie29cd4aa6907018d1bfe492c22ac1d431d0331ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117020
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [9cfb555bb4f985ec3b759291721f0f7a2e4c355e]

        sw_layoutwriter: remove duplicated createDoc method
        
        Change-Id: I25f995f06ce56ecec3411007bfd4f381cc7af207
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117021
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e1bc19044dc154fee30263951e1122028b22b5b]

        loplugin:unnecessaryreturn SotStorageStream::Commit
        
        Change-Id: Icfd32ea8b29aa544b71d0c4fc6bc67c06f81e327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Michael Stahl  <michael.stahl@allotropia.de>  [7f3c9da5a0a8f27e3fe63c39a30fc08e34246420]

        schema: update to ODF 1.3 OS
        
        Change-Id: I97e28612aeeebed709da9ad621250c6b26e55f92
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116734
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-10  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [363b98b268f317e7f2f9af392085856b938fb5f9]

        EMF tdf#142745 Improve performance of FILLRGN, PAINTRGN, EXTSELECTCLIPRGN
        
        With previous implementation, during reading of rectangles
        the optimizations were made after reading every single
        rectangle. This was causing performance issues, with many
        rectangles (eg. 2500 rectangles).
        
        With this commit, the optimization is made after reading all
        rectangles. It is improving performance of FILLRGN, PAINTRGN and
         EXTSELECTCLIPRGN records.
        
        Change-Id: I1b8b844efddd08e9bf6f6726c3fdf213a629883f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116996
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [da905b57745a343aa922a4e9fb513b121cd6ad8b]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code's introduction in
        4e386a897cd43aae3664ce68e47dd46b271de780 "INTEGRATION: CWS macosxspellchecker"
        
        Change-Id: I932b7ff4cc8aabf2e70379ed9ebe361881246c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116997
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [72bc2412db4f621d2c08e9b539fc9b9f441065e3]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code block's introduction in
        14bc62ad0d9e0179f4178d2913ebba7abf99755e "INTEGRATION: CWS
        aquafilepicker02_DEV300"
        
        Change-Id: Id4cda7ed087b350361b0207034fc31819d65efad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116992
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [e97a9211c08fe28d2b46d0a1371f0b391b5343b2]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code's introduction in
        adf0066a17538a394550237a54f6fc0027f6ed29 "#i91478# aqua implementation
        (continued)"
        
        Change-Id: I2dd7bbaba9e8068929f4792b7f953cbf01e03a7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116989
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Miklos Vajna  <vmiklos@collabora.com>  [5951da5175b9d7e5b3b47bd0d90989d2ef528c79]

        sw image anchor type: add style UI for this
        
        A frame style contains RES_ANCHOR, and SwFormatAnchor::m_eAnchorId
        already describes an anchor type. This is even exposed on the UNO API as
        the AnchorType property and its ODF import/export is also implemented.
        
        Enable UI for this, so that templates can decide the default anchor type
        when inserting images. Still keep the "to frame" anchor type disabled as
        its meaning is unclear for frame styles.
        
        Change-Id: I5d8ef63af9c8f2efa6485c4ec827ba9aef9b8956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116990
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [71070e7df254ffdcf57f4c82b1597d9855218f23]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 2b074d47c5f66d96576df2003b29d3cf09b4702a
          - tdf#130063 Add Help page for revamped B&N dialog for Impress and Draw
            
            Change-Id: I770a45ff062056ee38d904324e1f0148a7eec9da
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116945
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [57b80927410a2020c34ff0775931b08b2f7dfffd]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to db2d4a1373cc1a025888c4ef0359620eac3f88f6
          - tdf#112685 Advanced TSCP classification help page
            
            * Refactor TSCP pages
            * Add help page for Classification dialog
            * Add Help page for Classification Toolbar
            
            Change-Id: Id11c15d6937400b7cd28a5d80c4e9438693b28a1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116874
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0c8e119c9732e21b9391a4751200988b08594138]

        Add extended tips to document classification dialog
        
        Change-Id: I41ffe5c66e56ec7add2d4fcbb129ae2e3ff13b20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116915
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c56ee765c570b31b0820ea1a228a0166b84843a]

        loplugin:unnecessaryreturn AddonsOptions_Impl
        
        Change-Id: Ic2adf9467af7118e8efbbae2132912f3cc3d6943
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116988
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [9614c3c97bdc544e358ac9979b5a1f2681cfa8d6]

        small optimisation in SvtListener::EndListening
        
        erase immediately after find so we're working with cache-hot data.
        
        Instead of calling something else, which will load other stuff, then
        reload the data to do the erase.
        
        Change-Id: Ibbcca584b488ec3edc5b271efbd15d9a9ea2213f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116986
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [67cadbe2a9165f99de7d47a861954c6bc6c5f216]

        loplugin:unnecessaryreturn SvtListener::EndListening
        
        Change-Id: Ifa7092b31b6027eeb5d7df67ac8b7de9337faf66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116985
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [893c8fa232b0c78c5f390f7d35b6e1a7f6538ed1]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        all three variables were unused ever since the code's introduction in
        229a0de9c81554dfe6c96a0095a582476abc87ba "CWS-TOOLING: integrate CWS
        appleremote01"
        
        Change-Id: Ib755b86c81a6823c440f9f6a392b8f4b7de973ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116984
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [3732bba5e2b5ca5890be1fc3d09455248b81c763]

        Adapt compilerplugins to Clang VK_RValue -> VK_PRValue rename
        
        <https://github.com/llvm/llvm-project/commit/aef5d8fdc7d0d348125d5ecf4a13be5888eb1654>
        "[clang] NFC: Rename rvalue to prvalue"
        
        Change-Id: I237e8a491465500e35637f8dae400402bcd9411d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116983
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [a774d3295f84c5c4df26274edec2778ea3c3dc59]

        drop firebird test of initial experimental period fdb-only format
        
        Initially when the firebird embedded database support was first
        experimental we saved the fdb firebird file format.
        
        A test was added by 3f114eb4a2f3994b980aa607f2d4afc58e5aaa1d around then
        (2013) to test loading firebird odbs
        
        Then with
        
        commit de899f0b350e51b1932fa4674f7ce2ae386cd1ce
        Date:   Thu Jun 2 11:56:10 2016 +0200
        
            connectivity: firebird: use ODS12 test database for Firebird 3
        
        if building with firebird 3 a replacement odb was created in firebird
        3.X ODS12 format to use instead of the 2.X ODS11 file.
        
        Those fdb file formats were endian specific and database version
        specific. Which was a well known problem documented in tdf#72987 and a
        blocker for leaving 'experimental' at that point in time.
        
        So finally with
        
        commit 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
        Date:   Thu Aug 11 12:02:56 2016 +0200
        
            tdf#72987 GSoC Use Firebird backup format
        
        the save was changed to save the backup fbk file format and load
        restores the database from that fbk file format (2016) when available.
        
        later in
        
        commit 860ecb9e583627ab43097784ad98b41afd983ff6
        Date:   Thu Jan 5 12:58:26 2017 +0100
        
            require firebird 3.0 for build (don't allow 2.5)
        
        the firebird 2.X (ODS11) test of loading the fdb format was
        dropped leaving just the firebird 3.X (ODS12) fdb case because firebird
        3.X cannot directly load the ODS11 format
        
        Now with the appearance of firebird 4 the same problem arises that
        firebird doesn't load older binary formats directly.
        
        In the end all we established here is that an odb containing only a fdb
        is endian and version specific and a bad idea wrt compatibility so we
        shouldn't do that. But we knew that, so embedded firebird databases were
        an experiemental curosity until 0cc1ddf2d8d6bc7df74fdd8f8f97381df681177d
        enabled use of the fbk format.
        
        We're not gaining anything with the test of loading the binary only case
        because we know that's an unsustainable route we abandoned.
        
        Change-Id: I9f1715a817392de9f3f6e891966bbd838a9ce933
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116981
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [eee3b63561a9f1a8ed3d05e9e7a060344878ffd4]

        drop unused dbaccess/qa/unit/data/firebird_integer_le.odb
        
        Change-Id: Ic8ab7db1a0b2fd3425caf4714d26207ea2c35db8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116979
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Mike Kaganski  <mike.kaganski@collabora.com>  [01379acedcdad4fc08c61b73b8500e758b88d5ae]

        svxcore: provide UNO constructor for com.sun.star.text.TextColumns
        
        This allows to create it e.g. in Basic macros using CreateUnoService
        
        Change-Id: I949d3b92c83cd9e763244f70b22f0f367b93cb48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116970
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [d693223b84b518701d308678801ccc50877490dc]

        tdf#136766 Zoom slider in calc print preview has white background
        
        I cannot figure out any way to make transparent stuff on the toolbar
        behave under all rendering backends, so just revert this
        
        this reverts
            commit 00cffc20e40b2412c7e9867eed24c9834504e24f
            Date:   Mon Sep 7 13:28:33 2020 +0200
        tdf#135181 Calc print preview zoom slider print preview not
        transparent (gen)
        
            commit 444c7c736be7545344298a9cbb3a69886edc5ecb
            Date:   Mon May 18 18:23:13 2020 +0200
            tdf#125538 fix background of zoom control
        
        Change-Id: I7c351796b2c0778c1520fc8177d05567b2ae8a48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116982
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Alain Romedenne  <alain.romedenne@libreoffice.org>  [0963d6b25e6861591805c0d6ae8c0476adf177c0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e5ac483bab252537ccbd087e6a133230cb8bae70
          - tdf#141474 tdf#124066 Basic keyword arguments explanations
            
            Change-Id: I9f05990a9c3513d171b7ae94e8d60e5d0d1ced2f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116468
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-10  Tünde Tóth  <toth.tunde@nisz.hu>  [c9f071ff49bace0809d3a55d4d4b76a26d933f9c]

        tdf#139658 OOXML: fix broken chart import at labels with quotes
        
        During the import of the internal data table, incomplete
        parsing of category labels with escaped quotation marks
        resulted broken category labels and charts.
        
        Change-Id: If5af3d527b80d1e055562f589bdaf17096ad49f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116714
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-10  Tünde Tóth  <toth.tunde@nisz.hu>  [6185d1ff0130b3d178d5e50eeb6944ab70db41f9]

        tdf#140623 Chart OOXML import: set text overlap to false
        
        of category axis label unless the rotation is 0 in xml.
        
        Regression from commit: 21620f9d2f50e66dffc45a5afb539edb8d54434c
        (tdf#138194 Chart OOXML import: set text break to true)
        
        Change-Id: I18db7483f49c84a83760200037f8858a3b471994
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116575
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [ff44c5f6bc6a3ca71c87cced03b0cb8ca3c889d6]

        loplugin:unnecessaryreturn FontTable::addEmbeddedFont
        
        Change-Id: Ib64799f06ee1fbcc43132df6ad44975a0dff347e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116973
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [b5e6a478e88f45bd690045aaf12f664c4d1daa10]

        HAVE_FIREBIRD_30 is not used anymore
        
        Change-Id: If318cd33356c0082a63cbd941cdfc753c9d800e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [5d684acf33b6244c5eba332da7419e20126f1a08]

        fix firebird Cppunit targets
        
        so
        
        make CppunitTest_dbaccess_firebird_test
        make CppunitTest_dbaccess_firebird_regression_test
        
        work
        
        which is presumably a problem since...
        
        Commit 36befb3aca96907a14e71e82497dbb8f03ead5ab
        Date:   Sun Sep 23 19:40:59 2018 +0200
        
            tdf#72987 split firebird test into a regression test and a "new" test
        
        Change-Id: I3509364ba496c01c4a8a53674ec1c65495210274
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116969
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [0dbe3845bc3583dd6a8e285a8bdfd5b3939bbc6f]

        firebird support accidentally defaulted to disabled
        
        since...
        
        commit ffc6d564b91692cd9d99a0eb3b1ceaf54f7db89e
        Date:   Tue Jun 1 07:40:12 2021 +0200
        
            configure: Refactor disabling DB drivers
        
        Change-Id: I94e5e0aca54e1d6d0355d63b27d8fd73dd433083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116964
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Olivier Hallot  <olivier.hallot@libreoffice.org>  [7930a1c5de1dfea458ba52502259b4ff702fd3f4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fded06f95f73fd0bfb27d861843c2f317db83d29
          - tdf#132906 Update Sampling statistics dialog
            
            Change-Id: Ibe4132cfb80455dfc3338b17155bf449aad6e840
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116925
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2021-06-10  Balazs Varga  <balazs.varga991@gmail.com>  [3b4c11350a631e27345e87ecfe258d12983cbfbc]

        tdf#142713 OOXML: export secondary axis of all chart types
        
        where the secondary axis is supported by the chart model
        and OOXML.
        
        Change-Id: Ifbcc905139487965510063aa87991ce6f8df73ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116809
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-06-10  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [8d2d627a13de56bb95802d8ca1086933314fee46]

        tdf#142257 Add Word-compatible secondary shortcuts for Grow/Shrink
        
        Only for Hungarian, so we are not clashing with /
        wasting precious combinations for other languages.
        
        This would provide UX-interop with Word, yet the new default which
        is consistent with Impress is kept so it's the best of both worlds.
        
        Change-Id: Ia74c570bb94835d4a173a536f49d5a4f50e23542
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116418
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [3455c3efff86b12835261e2165ec563b2e0df2d3]

        loplugin:unnecessaryreturn RoadmapWizard
        
        Change-Id: I269fd92a6076fe9ebe18646e537e7031aec47fef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116976
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [3882a1811155415cba63ffc08f0f4863c0dbb3b7]

        tdf#142612 Replace Show Formula command shortcut for Hungarian
        
        Use the Excel-compatible shortcut that can be entered with
        Hungarian keyboard layout on Windows. Backtick is AltGr+7
        which does not work correctly when combined with Ctrl.
        
        Change-Id: I9f5da857a041733c63c124b3aff3d1834f8405f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116562
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [5bd31b7116abbb61f330783ab12aa302f9e8c43c]

        cid#1485166 silence Uninitialized scalar variable harder
        
        Change-Id: Ic9d841109cbcc1201e13cebea423139fd760c680
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116966
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [02af9b8ef1f87bb6bc5fee22ad184681b20f201a]

        tdf#64997: sw_ww8export3: Add unittest
        
        Change-Id: Iba81551157484274f90fea3e9f9f2c34c1daeaf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116968
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [0098d36c07d8a6cd4ad59bf4f4c7ad69fdaf6dfd]

        loplugin:unnecessaryreturn SvImpLBox::SetMostRight
        
        Change-Id: Id556d8c86c1229a51bd600da433d564979c1cd40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116975
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [7ad41a7767c666f6707adb1449e501f8581d0d3b]

        loplugin:unnecessaryreturn SalX11Display::Dispatch
        
        Change-Id: I270f6538d921ad2116cc29ada3e4543027531764
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116974
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [e2644dc93e0c9577e3d6d1e8c4918481165d1378]

        loplugin:unnecessaryreturn SalFrame::SetPluginParent
        
        Change-Id: If927a834f5b5d722fc36cce40e161597af6234ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116972
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [cea5df84466fb7cbecada6840b918d736f9b89c3]

        loplugin:unusedmethods
        
        Change-Id: I2890e29b3e18cdf7822bf93ee7c17cd8221497a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116971
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [5de138edf041ea56652f8a41471f63859ef3318a]

        update firebird modelines
        
        with solenv/bin/add-modelines -p connectivity/source/drivers/firebird
        
        because a bunch are missing the trailing ones
        
        Change-Id: I168c22586744cd666e6c18a569e143b6caccd421
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116963
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [266a3bad6d0537e309922ddafe3a6d4119e2c50c]

        tdf#142629: vcl_filters_test: Add unittest
        
        Change-Id: Id0397bc8e16eb22853ce3388f8ef3cc8f8558692
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116961
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-10  Caolán McNamara  <caolanm@redhat.com>  [76e2c20876319cbeea24d40104fac1ba7d6b5278]

        update add-modelines to the TEMPLATE.SOURCECODE.HEADER pattern
        
        to match
        
        commit f75cd22118a58c8a8827723c890885a500562465
        Date:   Tue Nov 8 14:51:20 2016 +0200
        
            Add fill-column: 100 to the Emacs mode line
        
        and
        
        commit 6a0081642633eb406059295b90fd0c9b0cd1130f
        Date:   Wed May 18 20:00:00 2016 +0200
        
            add Vim C-indent options to C/C++ template modeline
        
        changes to TEMPLATE.SOURCECODE.HEADER
        
        Change-Id: Ic323cd7dcce9ece23325a23160b0936819bb634b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116962
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-10  Luboš Luňák  <l.lunak@collabora.com>  [11925224a53a46837d3a32b126ff2be55c96fb13]

        avoid possible repeated cairo surface creation
        
        Doing the frame size adjustments only after the if condition meant
        that in headless mode the surface could be destroyed and created
        again for the same size. Also AcquireGraphics() passed different
        frame size to SetGraphics() than SetPosSize().
        
        Change-Id: I9d6884a3917dfbd7b2cfe4fcd4e350c8bc9f4305
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116272
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-10  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [a292fb847dade1912d281adc44c92a9ba3e8b61d]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        In this case, avoid single, re-used local variable. It gets
        newly processed at locations used anyways.
        
        Change-Id: I89463736cbc28925adc304adb4624ab2740bdfbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116936
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-10  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [e11c3740845959ab25f9b644681c97a7ded24d1c]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        No need to check for SfxItemState::UNKNOWN, all states depend on
        selected SdrObejcts/E3DObjects anyways
        
        Change-Id: I13be6494229c18f514da3e0229d0896b237508c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116939
        Tested-by: Jenkins
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [105ad5dc174d9e894b0c4f9e24d068090ca8c3aa]

        external/mdds: Mark patch as upstreamed
        
        Change-Id: Id61fbaafb575a8c745e5b3cc5b2ff8ae4526d94c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116960
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  Stephan Bergmann  <sbergman@redhat.com>  [19885d9395a8481f93ca667c07a306368f2cab79]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        26ee34d1332e164cf938fcf78902df7d0cc3fe8f "uitest: add logging for UI actions"
        had added the original
        
        >     return "Action on element: " + mxWindow->get_id() + " with action : " + aActionName;
        
        That commit had stated
        
        > The long term goal for this logging is that it generates content in a
        > DSL for the UI testing. The generated file can then be interpreted by
        > the UI testing and replay the interaction with the UI.
        >
        > For now the plan is to have a readable output of what happens in the UI
        > layer that allows to quickly transform it to a UI test.
        
        Later, 5578bc99542953b6318a117a4e4b99f12964d9d2 "uitest: Some new features in
        ui_logger project", apparently as part of working on such a Python-from-DSL code
        generator, commented out the original return statement.  The comment at
        <https://gerrit.libreoffice.org/c/core/+/116811/
        1#message-867650d186ade924cd38240ebbf8603222adac6d> "Lets assume this was
        commented out in error" has instructions how to test that (the generated
        test.log is in the UserInstallation rather than in instdir, though), and the
        comment at <https://gerrit.libreoffice.org/c/core/+/116811/
        1#message-36bf2eab1110bf51ccaaa1014188b841beb32041> suggests returning just
        aActionName instead of the dressed-up, human-readable "Action on element ..."
        
        However, when I tried out those instructions, the dsl_core.py generation failed
        (with an arpeggio.NoMatch exception) both when just returning aActionName and
        when returning the full dressed-up, human-readable "Action on element ..."  But
        it also generally failed if WindowUIObject::get_action returns an empty string
        (i.e., the status quo), with e.g.
        
        > AttributeError: 'CloseDialog' object has no attribute 'uno_command_name'
        
        apparently due to some
        
        > Close Dialog
        
        lines in my generated test.log.
        
        So it appears that dsl_core.py is unfinished work in progress, which does not
        work properly regardless of what WindowUIObject::get_action returns.  Coming
        back to the original commit that produced "readable output of what happens in
        the UI layer", it is thus probably best to leave it at that output for now, and
        reinstate the original full dressed-up, human-readable "Action on element ..."
        That addresses the -Werror,-Wunused-but-set-variable.  If anybody wants to fix
        that dsl_core.py generation, that can happen in later commits.
        
        Change-Id: Ie1123df53d9505fc5f039405f666977550f967d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116811
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-10  László Németh  <nemeth@numbertext.org>  [68b6004fe9df184bcbaf46dd53abfec228219df6]

        tdf#141994 track changes: record insertion of images
        
        by adding a SwRangeRedline to the anchoring point of
        the image inserted with Insert->Image... or
        "Insert Image" of the Standard toolbar.
        
        Note: Only images anchored as characters can be
        recorded this way, so change the default to-character
        anchoring at enabled change tracking. (In other office
        suites, as-character insertion is the default anchoring
        for inserted images with disabled change tracking, too.)
        
        Follow-up to commit d6322bcedc197a654abc7d64bfea8cf570f123bf
        "tdf#59463 track changes: record deletion of images".
        
        Change-Id: I593abbdb6f9f2b1a5265f112103479c1833166af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116924
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-10  Miklos Vajna  <vmiklos@collabora.com>  [2693ef720d9aaabe4fca0183f0c91ab34cf47fb4]

        CppunitTest_xmlsecurity_signing: remove not needed direct pdfium dependency
        
        This test only calls pdfium indirectly via vcl.
        
        Change-Id: I37ba3f9803d5dd0ead9e3614f3c899d6029107d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116940
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-10  Julien Nabet  <serval2412@yahoo.fr>  [159030991c70fc3c4018ef28abf1814902a0aebb]

        Simplify Sequences initializations (sot/stock/svl/svtools/svx)
        
        Change-Id: Iec21851d69f4a8d5f557e9ed2d30e5f680cd62c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116943
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-10  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [36db408b9027da01464927e5853950435596ae05]

        sd: ubsan - fix heap-use-after-free in SdOutliner
        
        OutlinerView can change (old one deleted and new one create)
        so we can't store it in a local vairable and need to always
        fetch it.
        
        UBSAN Error log:
        ==21484==ERROR: AddressSanitizer: heap-use-after-free on address 0x606000af7d28 at pc 0x2ab7c5979405 bp 0x7ffcd1a3d1a0 sp 0x7ffcd1a3d198
          READ of size 8 at 0x606000af7d28 thread T0
              -0 0x2ab7c5979404 in std::__uniq_ptr_impl<EditView, std::default_delete<EditView> >::_M_ptr() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:147:42
              -1 0x2ab7c59792ea in std::unique_ptr<EditView, std::default_delete<EditView> >::get() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:337:21
              -2 0x2ab7c59791d9 in std::unique_ptr<EditView, std::default_delete<EditView> >::operator*() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/unique_ptr.h:322:2
              -3 0x2ab7c59725da in OutlinerView::GetEditView() const /include/editeng/outliner.hxx:209:46
              -4 0x2ab7c70e36bb in SdOutliner::SearchAndReplaceOnce(std::__debug::vector<sd::SearchSelection, std::allocator<sd::SearchSelection> >*) /sd/source/ui/view/Outliner.cxx:903:21
              -5 0x2ab7c70dcb32 in SdOutliner::SearchAndReplaceAll() /sd/source/ui/view/Outliner.cxx:622:29
              -6 0x2ab7c70da81b in SdOutliner::StartSearchAndReplace(SvxSearchItem const*) /sd/source/ui/view/Outliner.cxx:478:28
              -7 0x2ab7c61e4fc5 in sd::FuSearch::SearchAndReplace(SvxSearchItem const*) /sd/source/ui/func/fusearch.cxx:128:44
              -8 0x2ab7c5c61fc5 in sd::DrawDocShell::Execute(SfxRequest&) /sd/source/ui/docshell/docshel3.cxx:228:36
              -9 0x2ab7c5cac074 in SfxStubDrawDocShellExecute(SfxShell*, SfxRequest&) /workdir/SdiTarget/sd/sdi/sdslots.hxx:18384:1
              -10 0x2ab7cd885d8f in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:253:9
              -11 0x2ab7cd89bd8f in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
              -12 0x2ab7cd89ccd6 in SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short) /sfx2/source/control/dispatch.cxx:811:9
              -13 0x2ab7cdd11d76 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:738:46
              -14 0x2ab7cdd15135 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:243:16
              -15 0x2ab7f54b25d7 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:159:30
              -16 0x2ab7f54b1531 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:117:16
              -17 0x2ab7f54b2d17 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
              -18 0x2ab7e63c546f in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:85:22
              -19 0x2ab7b1a9ac2d in testSearchAllInDocumentAndNotes::TestBody() /sd/qa/unit/uiimpress.cxx:715:5
              -20 0x2ab7b1b43f84 in void std::__invoke_impl<void, void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>(std::__invoke_memfun_deref, void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14
              -21 0x2ab7b1b43b5e in std::__invoke_result<void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>::type std::__invoke<void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>(void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14
              -22 0x2ab7b1b439b2 in void std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11
              -23 0x2ab7b1b43612 in void std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17
              -24 0x2ab7b1b426a1 in std::_Function_handler<void (), std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2
              -25 0x2ab7b1aec1f1 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14
              -26 0x2ab7b1b41984 in CppUnit::TestCaller<testSearchAllInDocumentAndNotes>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
              -27 0x2ab765f655ba in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
              -28 0x2ab780dd0937 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:46:14
              -29 0x2ab765f36c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              -30 0x2ab775453fd7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:78:12
              -31 0x2ab765f36c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              -32 0x2ab771f47962 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:62:16
              -33 0x2ab765f36c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              -34 0x2ab765ecdf84 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
              -35 0x2ab765f36c47 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25
              -36 0x2ab765f30697 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
              -37 0x2ab765fcfa79 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:28
              -38 0x2ab765f63c21 in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13
              -39 0x2ab765f67a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
              -40 0x2ab765f66c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
              -41 0x2ab765f67a52 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30
              -42 0x2ab765f66c4a in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
              -43 0x2ab765ffd60e in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27
              -44 0x2ab765fce4de in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:9
              -45 0x2ab765ffe56b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14
              -46 0x4ff42e in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:324:20
              -47 0x4fb90c in sal_main() /sal/cppunittester/cppunittester.cxx:474:20
              -48 0x4fa40e in main /sal/cppunittester/cppunittester.cxx:381:1
              -49 0x2ab767c44554 in __libc_start_main (/lib64/libc.so.6+0x22554)
              -50 0x425e04 in _start (/workdir/LinkTarget/Executable/cppunittester+0x425e04)
        
          0x606000af7d28 is located 8 bytes inside of 56-byte region [0x606000af7d20,0x606000af7d58)
          freed by thread T0 here:
              -0 0x4f75f0 in operator delete(void*) /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_new_delete.cc:160
              -1 0x2ab7c70c42b1 in SdOutliner::Implementation::ProvideOutlinerView(Outliner&, std::shared_ptr<sd::ViewShell> const&, vcl::Window*) /sd/source/ui/view/Outliner.cxx:1988:17
              -2 0x2ab7c70c1302 in SdOutliner::SetViewShell(std::shared_ptr<sd::ViewShell> const&) /sd/source/ui/view/Outliner.cxx:1743:17
              -3 0x2ab7c70ed9f4 in SdOutliner::SetViewMode(PageKind) /sd/source/ui/view/Outliner.cxx:1571:5
              -4 0x2ab7c70f309e in SdOutliner::SetObject(sd::outliner::IteratorPosition const&) /sd/source/ui/view/Outliner.cxx:1720:5
              -5 0x2ab7c70f3db6 in SdOutliner::PrepareSearchAndReplace() /sd/source/ui/view/Outliner.cxx:1507:13
              -6 0x2ab7c70d4b3f in SdOutliner::ProvideNextTextObject() /sd/source/ui/view/Outliner.cxx:1302:33
              -7 0x2ab7c70e30f0 in SdOutliner::SearchAndReplaceOnce(std::__debug::vector<sd::SearchSelection, std::allocator<sd::SearchSelection> >*) /sd/source/ui/view/Outliner.cxx:892:17
              -8 0x2ab7c70dcb32 in SdOutliner::SearchAndReplaceAll() /sd/source/ui/view/Outliner.cxx:622:29
              -9 0x2ab7c70da81b in SdOutliner::StartSearchAndReplace(SvxSearchItem const*) /sd/source/ui/view/Outliner.cxx:478:28
              -10 0x2ab7c61e4fc5 in sd::FuSearch::SearchAndReplace(SvxSearchItem const*) /sd/source/ui/func/fusearch.cxx:128:44
              -11 0x2ab7c5c61fc5 in sd::DrawDocShell::Execute(SfxRequest&) /sd/source/ui/docshell/docshel3.cxx:228:36
              -12 0x2ab7c5cac074 in SfxStubDrawDocShellExecute(SfxShell*, SfxRequest&) /workdir/SdiTarget/sd/sdi/sdslots.hxx:18384:1
              -13 0x2ab7cd885d8f in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:253:9
              -14 0x2ab7cd89bd8f in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
              -15 0x2ab7cd89ccd6 in SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short) /sfx2/source/control/dispatch.cxx:811:9
              -16 0x2ab7cdd11d76 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:738:46
              -17 0x2ab7cdd15135 in SfxOfficeDispatch::dispatchWithNotification(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:243:16
              -18 0x2ab7f54b25d7 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatch> const&, com::sun::star::util::URL const&, bool, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:159:30
              -19 0x2ab7f54b1531 in framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx:117:16
              -20 0x2ab7f54b2d17 in non-virtual thunk to framework::DispatchHelper::executeDispatch(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /framework/source/services/dispatchhelper.cxx
              -21 0x2ab7e63c546f in unotest::MacrosTest::dispatchCommand(com::sun::star::uno::Reference<com::sun::star::lang::XComponent> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /unotest/source/cpp/macros_test.cxx:85:22
              -22 0x2ab7b1a9ac2d in testSearchAllInDocumentAndNotes::TestBody() /sd/qa/unit/uiimpress.cxx:715:5
              -23 0x2ab7b1b43f84 in void std::__invoke_impl<void, void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>(std::__invoke_memfun_deref, void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:73:14
              -24 0x2ab7b1b43b5e in std::__invoke_result<void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>::type std::__invoke<void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&>(void (testSearchAllInDocumentAndNotes::*&)(), testSearchAllInDocumentAndNotes*&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/invoke.h:95:14
              -25 0x2ab7b1b439b2 in void std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()>::__call<void, 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:467:11
              -26 0x2ab7b1b43612 in void std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()>::operator()<void>() /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/functional:549:17
              -27 0x2ab7b1b426a1 in std::_Function_handler<void (), std::_Bind<void (testSearchAllInDocumentAndNotes::* (testSearchAllInDocumentAndNotes*))()> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:316:2
              -28 0x2ab7b1aec1f1 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/gcc-7.3.0/lib/gcc/x86_64-pc-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_function.h:706:14
              -29 0x2ab7b1b41984 in CppUnit::TestCaller<testSearchAllInDocumentAndNotes>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
        
        Change-Id: I0b4616cd3813565bc58b7a84320cbf52dd654a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116879
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [aa9cb8e14749e7fb7a83b55a2bb095501f731a18]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        For both aRelNullPt local variables in SwFEShell::ImpEndCreate and
        SwFEShell::CheckUnboundObjects the (only) reads were removed with
        5f7d6695ab561758acb27a93f14e08ee960324d5 "INTEGRATION: CWS swdrawpositioning".
        (And nIdent in SwFEShell::CheckUnboundObjects thus becomes unused, too.)
        
        Change-Id: Ifb4851b4e10b7370f2fc2f25bcdba77d532e77a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116845
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [17694c906f94a195a2d5086e0e87afa1c852107b]

        tdf#66553 - Add file/product name to title bar for password managers
        
        Change-Id: I6a16e654edcbc3511ee8cbea0889d858e22f2a2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116782
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-09  Luboš Luňák  <l.lunak@collabora.com>  [2aa2d03ec4e775d9399420c21cd1f2e972984154]

        do not draw directly in SwViewShell in LOK mode
        
        Online mode draws tiles as necessary, so there's no need to care
        about flickering, and this drawing is in fact not needed at all
        for Online.
        
        Change-Id: I19d981ad6ab6890ada1f415dc251a3492fd054ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116920
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [58d218df8c5e36468183ebae666120a6d5d0a4f7]

        Simplify Sequences initializations (sfx2)
        
        Change-Id: I1384dd80e910ba1c55ec7481ab481bc48740fc5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116937
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [da44de883f205736fffeacc148c32dcfd638ad66]

        Simplify Sequences initializations (sdext)
        
        Change-Id: Ide9a3ddd4f6915f45b02353293236988bff51eba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116935
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Luboš Luňák  <l.lunak@collabora.com>  [53dd6aa5f3817d42bf676980f980051c3b7cdb03]

        scale VCL's scale cache according to the number of Online views
        
        If a document is opened in several Online views, each of them using
        a different zoom, then the scale cache is used for the scaling,
        and each view is sent updated tiles, so if there are too many
        views, the cache is not large enough.
        (Collabora T28503)
        
        Change-Id: I3fa719b0515064773fe4584fedbc8aff98e6e213
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116928
        Tested-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-09  Luboš Luňák  <l.lunak@collabora.com>  [62b58e88d897f51a7c4e12b41d14121ab8d3396f]

        allow altering the max size of o3tl::lru_cache
        
        Change-Id: Id119b70275e1c88a8c57f89d915241427be9dbf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116927
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [e9838a1d1de8d9d44fd1bac603a1d29ff97a12ff]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...since the (only) read of sXmlId got removed with
        c50357ff625972464d1a591afe4198d3f6f42a39 "loplugin:unusedfields in sw"
        
        Change-Id: I609eae60eb0e1d440a47f97b6387c833c1404518
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116855
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [a74dab375e894c3b87f5279cd7c43c26e4c79bb4]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        Since 20e5f64215853bdd32c5f16394ba7f2f36745904 "loplugin:unused-returns in sw"
        removed
        
        >     return bChanged || bTabChanged;
        
        from the end of SwLayAction::FormatLayoutFly, bTabChanged is effectively
        completely unused (and now gets warned about by Clang), and the update of
        bChanged is apparently no longer used, either.
        
        Change-Id: Iab180e83070c45531aecf46d85a030463cf7b22d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116853
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-09  Justin Luth  <justin_luth@sil.org>  [aa39400c73fac4b0430ee47a0d18bf4978f7f2d0]

        NFC compat cleanup: no need to specify default TabOverflow
        
        This really confused me because it lead me to think
        that this was something done for MS compatibility.
        
        Well, that is only true in an off-handed way.
        LibreOffice itself was changed to work similarly
        to MS Word. So there is nothing special about how DOC
        or DOCX/RTF are handled.
        
        Since the compat settings are not saved or loaded
        into MS Formats (i.e. it just takes the default value),
        and since on an ODT save it also will just save
        with the proper default value, there is no need
        to specify "TabOverflow = true" in non-ODT import filters.
        
        Only ooxmlexport16 has a unit test that reacts if
        tabOverflow is false. That one is mine and it indicates
        that the document would be better if tabOverflow was off,
        so there are no examples of how tabOverflow improves a doc.
        
        Change-Id: I97c25154108bc1ca0fcd3dfcff66fea0ea2bca7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116741
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [3bcb8c3d6d028f76817039f2aad57cab5a6e524b]

        tdf#142721 restore SwShellTableCursor if the orig selection was a single cell
        
        where the previous attempt of
        
        commit 4d52d2bc81f9d27472fe368785912a530489d046
            tdf#142165 restore a SwShellTableCursor if the orig selection described that
            so that we are operating on the same selection that existed when the
            dialog was originally launched
        
        wasn't sufficient to restore a single cell selection.
        
        we continue to need to avoid the assert of
        
        commit 6db71f70a3b200d4074f6cda8ce445e9861d3296
            tdf#140977 drop possible table-cursor before setting the new one
        
        and support the multi-selection of
        
        commit e08b446e46f56e15af58fdd4396afba1a316f9e5
            tdf#140257 duplicate entire PaM ring when making copy
        
        and support not scrolling to a different location on changing a table
        page break style of
        
        commit 9c61732677d038e32b73fc9fb883aced14c0febf
            tdf#135916 just set the target table as selection
        
        and keep making it possible to remove a page break on a table of
        
        commit 81f91196b98af38e29af451b86c26a893a109abc
            tdf#135636 the selection at dialog-launch time is lost by dialog-apply time
        
        all of which is necessitated by
        
        commit c3a085d22742f88e91ff92f319a26d6e8d1d9a98
            lokdialog: Convert the Table -> Properties... to async exec.
        
        Though; since 4d52d2bc81f9d27472fe368785912a530489d046 where we started
        using rSh.GetTableCrs if IsTableMode() then in practice
        6db71f70a3b200d4074f6cda8ce445e9861d3296 probably cannot arise.  The
        scenario of rSh.IsTableMode() changing between launch of the dialog and
        applying the result of the dialog is presumably maybe theoretically
        possible in e.g. an online scenario, but not in the normal user case,
        but handled here anyway.
        
        Change-Id: I12f0b6bc7e0e2f5bad45a88007bf6fe2cd3d3b0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [01ded1e6d362dbcd7148334c6965d6ad00981d4a]

        WMF tdf#55058 tdf#142722 Add implementation of BitBlt and StretchBlt
        
        With previous implementation, only BitBlt record with 1 bit color depth
        was supported and StretchBlt was not implemented at all.
        
        With this commit the support for 1 bit, 24 bit and 32 bit,
        for both BitBlt and StretchBlt were added.
        
        Change-Id: I061b2beae8c2f143ddff9c8c8bb64bf52f4cf502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116873
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [fca7d50b17fae217bd34e9e6f5e3a8b0fda93833]

        Simplify Sequences initializations (sd)
        
        Change-Id: I968f1209961ba30ad0837846ae1ba4a9249663c8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116934
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [5897a97bb53bcbf2283161cc22f43d87f575f3d6]

        Simplify Sequences initializations (sccomp)
        
        Change-Id: I6316e1318ae1ee68e5d4e4529731bca0d1860b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116932
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  sarynasser  <sarynasser1@gmail.com>  [8ed68179e2eaf07289663c64d923d8b5dd8b25c9]

        tdf#139734 remove redundant asserts after loadFromDesktop
        
        Change-Id: Ibabb1775ea86a6dd548ee718ed1dede6ffc60be9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113898
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-09  Miklos Vajna  <vmiklos@collabora.com>  [4895a92e67ffbbee87ec5ee1e2394cdc5b833fcb]

        sw keep aspect ratio: add style UI for this setting
        
        It's a per-document setting, but it was only possible to set/get this for a
        direct formatting dialog. Allow it for styles as well.
        
        Change-Id: Iafe1cab37be1eb741b895fe3c6613c21bc63f0d5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116931
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [520bb32555985c12642b40fad3b7dcac7a940585]

        tdf#142629 import psd image with transparent background
        
        regression from
            commit 2168d709805a847ac012ff87b06e081ca139d064
            Date:   Mon Feb 12 15:29:10 2018 +0200
            use RawBitmap in PSDReader
        
        Change-Id: I8d547d3cca7fb8fc90a8d9382e054b4d4b2f3519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116916
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [e6aecfeea18a5b98ec724e6229295170ec75c936]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        > svl/source/misc/adrparse.cxx:639:30: error: variable 'aTheRealName' set but not used [-Werror,-Wunused-but-set-variable]
        >                     OUString aTheRealName;
        >                              ^
        
        since 334644bad9e325d5b23b4416cdc3d22dce5141bf "loplugin:unusedfields in svl",
        plus removal of further newly dead code
        
        Change-Id: I24b4b63a8b625422c898d14ef9a0d304b828d6b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116926
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [842a5504119c49edf368b94889f098e76f5fb80d]

        drop unnecessary pWin arg to InitAcc
        
        on the only path InitAcc has a non-null pWin arg the caller ctor
        has already set mpWindow to pWin which is also all that InitAcc does
        with its pWin arg
        
        Change-Id: I668232117be41fd33bf9ca41db882b5124d61ff0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116923
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [a5d6dc7ac82cf6f527a47bf67f976f982c2c0015]

        ScTextWnd is set since the ctor now so drop from InitAcc
        
        Change-Id: Ia1ccf9393f229d13fde23f2e425ff1cf169ebd9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116922
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [cb8d6ebfb5b5512c32027708859251fae8c2fcae]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        The "INTEGRATION: CWS sheetzoom: #i24372# allow separate zoom per sheet" commits
        0846c467a921a27ebd3691e4bc187ece8d0ae7aa (sc/source/ui/inc/viewdata.hxx) and
        8d808f64ed32d55adc7af34c3615993ada02f117 (sc/source/ui/view/viewdata.cxx) had
        moved the aZoomX, aZoomY, aPageZoomX, aPageZoomY data members from ScViewData to
        ScViewTableData (and added aDefZoomX, aDefZoomY, aDefPageZoomX, aDefPageZoomY
        data members to ScViewData in their place), and introduced the local variables
        
        >     Fraction aZoomX, aZoomY, aPageZoomX, aPageZoomY;    //! evaluate (all sheets?)
        
        into ScViewData::ReadUserData, so the pre-exisiting assignments to them in that
        function, which used to assign to the ScViewData data members, now started to do
        dead assignments to those local variables.
        
        (8d808f64ed32d55adc7af34c3615993ada02f117 had similarly added local variables
        
        >     Fraction aZoomX, aZoomY, aPageZoomX, aPageZoomY;    //! evaluate (all sheets?)
        
        to the top of ScViewData::ReadUserDataSequence, but they have already been
        cleaned away by 305bf19e390aebdf2d20ea052a92f782e8d1185c "loplugin: unused
        variables".)
        
        Change-Id: I0053ba85b3e33fc515cf4724655baa3c5063826d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116818
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [85582c40bca587017611bb332d1c9997c687cdfe]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        The (only) use of lineColor at
        
        >         //m_pImpl->bUseGridLines ? _rDevice.SetLineColor( lineColor ) : _rDevice.SetLineColor();
        
        had been commented out in 8578ba4dc736b53c3ca8461516e4024d276b3b05 "gridsort:
        consolidated and fixed table cell rendering" and then cleaned away completely
        with f4147a39374c7692728e8506961f23e59a069c45 "refactor TableControl to use
        RenderContext"
        
        Change-Id: I817800b26f4996a73a38fece22149ae87c2f9c01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116824
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [1541ac50819c59923e100e297fa7b4d4a3316126]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        > sd/source/ui/dlg/BulletAndPositionDlg.cxx:707:14: error: variable 'sSelectStyle' set but not used [-Werror,-Wunused-but-set-variable]
        >     OUString sSelectStyle;
        >              ^
        
        ...ever since the code's introduction in
        e3015d7021e689c71c2ed8e5dd01a74d832c84f0 "Add new customize and position merged
        dialog", and which means that SvxBulletAndPositionDlg::m_sBulletCharFormatName
        and second parameter of SvxBulletAndPositionDlg::SetCharFmts, both also
        introduced in that commit, were equally unused
        
        Change-Id: Id07c05777817298073d85719689b391bda533221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116821
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [97654133f64eed1c1e6d35188315f5fb22f2d936]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...after e79e8117dcc7475d8d90afeaaac9eb7050ff244e "loplugin:unusedfields in
        sfx2" had removed the (only) read of sPattern
        
        Change-Id: I2413af34b15dec45c46df0ffabf1d910f92dd695
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116822
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [1269ea3586cb902a790f721810fbe93647cfd491]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...after 096168cacc574a71482520e5c3fbd79f975dc6ad "loplugin:writeonlyvars" had
        removed the (only) read of sFirstCharFmt
        
        Change-Id: I8b59f54b2bb8669c66a14df80c4c74fceb56b1c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116820
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [bcc28948d0fd7b4f005a13db923c3e853d74817c]

        tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
        
        See task, slowly trying to reduce usages of that flag
        
        Change-Id: I50dc8e21e2f5e82e21bf335d63d07cee1ee18d01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116913
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Jenkins

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [33b4198735af8d9398e63887187b86b4176cac82]

        allow system firebird 4
        
        Change-Id: I330065f61d2d0fdfeeaeba4ee2e739e222d1c665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [acf565ea13204479f215ca597a432d69dac4290d]

        Add an SvAddressParser unit test
        
        Change-Id: I7d08528f455bb7849e0b62da16c5387b1812ccb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116919
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Tor Lillqvist  <tml@collabora.com>  [0fa2bb31b53c2b9114480ab77e0db4e011691440]

        Avoid empty std::map constructor
        
        Change-Id: Ie1bc333409fb201d82dd2cff7597e281600f01db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116449
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116849
        Tested-by: Jenkins

2021-06-09  Alain Romedenne  <alain.romedenne@libreoffice.org>  [4b8ead440a6216e42596333b0837854c923e25a9]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9fffc3e09d2cddfc614e5520d8d33942572dd5a5
          - ThisDatabaseDocument new help page
            
            Change-Id: I9ad35913bbc5fef9208b3a9ea5eb9be01f882131
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116463
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [ff72a7db944651c81ff32ad33d6f6b7502448c4e]

        tdf#141769 ScTextWnd has to be available before the editview is created
        
        Change-Id: Iec3b4180c4dc83723224b7122a1513cb8fe3ea0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116917
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [94fdd0191fe30e193aea19f365397074a816fbe6]

        Split CppunitTest_chart2_export into two
        
        it already had 148 tests
        
        Change-Id: I83e0055bcf1449cd48a28149a6ef0b149a1d6901
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116914
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-09  panoskorovesis  <panoskorovesis@outlook.com>  [dbd86edb55de543d9b0b88bca1d43676da88215a]

        Add GradientEx cppunit test to vcl
        
        The test creates two GradientEx and checks
        their attributes. In mtfxmldump.cxx the
        case regarding GradientEx was completed
        
        Change-Id: I52f2303fa3123b97fb8a4b0783610c0bae300fc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116819
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-09  panoskorovesis  <panoskorovesis@outlook.com>  [1adbb3e00593af8eed5baf7019fa9b177186567c]

        Add RefPoint cppunit test to vcl
        
        The test creates two RefPoints. A default one and one
        using a Point. Then checks their attributes
        
        Change-Id: I7ae3d6498f776d00dee3d084d13f0764942af5c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116780
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-09  Heiko Tietze  <tietze.heiko@gmail.com>  [e0900c497a65af2e45c7cff3211b340bf14c4324]

        Resolves tdf#142513 - Order of ZoomIn and ZoomOut at Print Preview
        
        Change-Id: I630e11bdbf4604b779756a6169e4a777c5baeba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116888
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [f09cb84b274edd2a27697a7dc803a7ee42946de2]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code's introduction in
        c25ec0608a167bcf1d891043f02273761c351701 "initial import".  Lets assume that the
        accompanying comment, also present since the "initial import", describes what
        was actually intended, and augment it with a "TODO".
        
        Change-Id: If94a3b72533459d02b1155653b5093c32f034e27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116834
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [24d22a76f9a0ad9ef5a45d1478002362ff50335f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ed18f8e4f9fc516d1a9e117e983cdc8006838ad1
          - Refactor some database help files
            
            Change-Id: Ia9f3e2844cdf4ac16d7ee3ba70d64415c2bf964d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116837
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-09  Tor Lillqvist  <tml@collabora.com>  [f0a8d47aecf42b64f576601a947b1904b78b94de]

        Fix syntax error in the "arguments" of a TraceEvent
        
        Change-Id: I68f94311d3e0527955b6ad8d5b49e4e564329e1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116054
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116848
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-06-09  Tor Lillqvist  <tml@collabora.com>  [6038c9125bcb9f6d5dc2b998f2bef476ba1b1f98]

        Add the possibility to include a set of arguments in Trace Events
        
        Change-Id: I55720baf64bd9b719026c94e4373b6368a1a7106
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116847
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-06-09  Tor Lillqvist  <tml@collabora.com>  [e4f5705b91ecacdfc84e564e116dfe812fd96b61]

        We must collect the Trace Events when recording them is turned on
        
        Recording them can be turned on and off on-the-fly.
        
        Also rename the class from ProfileZoneDumper to TraceEventDumper as
        ProfileZones are just one special case of Trace Events.
        
        Change-Id: I4928397937963c83ffe8022ba4fa941f81119e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115332
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115593
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116846
        Tested-by: Jenkins

2021-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [1c01bdd6c1fabf301218560d7d1d26dea6915827]

        sw_layoutwriter: split tests evenly
        
        Before sw/qa/extras/layout/layout.cxx had 23 tests and
        sw/qa/extras/layout/layout2.cxx 124. Now they have
        81 and 66 respectively
        Change-Id: Ib28824b4cbe6467c1e66ed29c99a3467dd9943f4
        
        Change-Id: Ic561b2a2e5d6d33e24a4d0a73508fb3cb7284ea9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116889
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [160a4852f1d7487154d8cdd8881acd287d481b7f]

        dtd files are not xml files and shouldn't have xml headers
        
        so rpminspect is correct in complaining that they are not valid xml
        on inspecting files claiming to be xml
        
        Change-Id: I70379989326c2ea63e6a54b3658ebea4684fa5df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116887
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [5f9a90a939de600952707edeeb309c6badd757c6]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        The only read of aParamterName in the OOperandParam ctor had been commented out
        and marked "todo" ever since at least 8b1efd34bf563a1a8de9d7e78e52cdab8086cb38
        "moved from ..\..\parse", so lets clean all of that effectively dead code away
        completely for now, and just leave a comment for later.
        
        Change-Id: Ia5ee51cd6c45e8bc50bdd4e892ed0a4dfdc690a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116839
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [c3325e8d7eae59ba1064546038ea2c6abeed9db6]

        xmllint: Namespace prefix menu on menuseparator is not defined
        
        xmllint --noout dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml
        dbaccess/uiconfig/dbapp/toolbar/formobjectbar.xml:24: namespace error : Namespace prefix menu on menuseparator is not defined
         <menu:menuseparator/>
        
        should be a toolbarseparator here
        
        a problem since...
        
        commit 4f810905fa74128871f2fe924a3d28a79f4e4261
        Date:   Tue Mar 5 15:42:19 2019 +0100
        
            sync dbaccess ui files with swriter ui file structure
        
        Change-Id: I000efac56a0af10bca7c22fba6f88f469ae9b272
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116885
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [975488594fc88aaba7298448e0ff727ebca7fe85]

        tdf#96840: sw_ww8export3: Add unittest
        
        Change-Id: I9bac18844bded21ecf16c040c78b52a6eedeafc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116883
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-09  Oleg Shchelykalnov  <olegshtch@yandex.ru>  [b5e07b1339f73841664b28c65639f1638bd7edf4]

        tdf#137469 Implement and test excluding hidden text in text filter
        
        Uses filter options to manage whether hidden text output to file.
        Fixes filter options usage in test.
        
        Change-Id: I12a234438730795df6dd11bd6707dfa1fbfa4740
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105631
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-09  Oleg Shchelykalnov  <olegshtch@yandex.ru>  [c96b61f86ef3f4cdc34f84043fed2724b6d9732b]

        tdf#137469 Prepare tests for encoded text filter
        
        Change-Id: Ifba71748cc389544bfb64e225a7020de8261967b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105621
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [7af40a445551a07c6918f835da20ca461a6bd4ee]

        Simplify Sequences initializations (i*->p*)
        
        Change-Id: I6bf0eaa2233de2487d90a2f9ae7de263b4ddf1bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116865
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [07a09195adc65722207390e355a202100bc608ff]

        external/pdfium: Latest MSVC now needs the GCC workaround, too
        
        ...or else a build with MS VS 2019 16.10.0 and --with-latest-c++ would cause a
        stack overflow during CppunitTest_xmlsecurity_pdfsigning in the same way as
        described at 6391e3c4dcd4d61c2f95f996e797e49b5586dbd1 "external/pdfium: Work
        around GCC C++20 recursive comparison issue".  Interestingly, builds with recent
        Clang (on various platforms) and --with-latest-c++ do not run into that stack
        overflow issue, so it appears that Clang implements subtly different rules for
        C++20 and beyond here than do GCC and MSVC.  (The GCC issue
        <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94141> "c++20 rewritten operator==
        recursive call mixing friend and external operators for template class"
        mentioned in external/pdfium/UnpackedTarball_pdfium.mk may not be the most
        accurate description of the precise issue at hand here, but lets keep it at that
        for now.  Its comments do mention "that some people are going to try and change
        the rules to avoid breaking code like this.")
        
        But regardless of what the exact rules are for C++20 and beyond, these
        problematic overloads are only needed for C++17 and earlier anyway, as C++20 can
        cover them with automatic rewrites of other operators.  So lets generally
        disable them for C++20 and beyond.
        
        Change-Id: I99033d6f09f069f00a6916ef40fd03dd4962a5c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116882
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [92556e330ede97e11ae2cbc487bb298e6bbcb6bf]

        Even more simplification in initializations (reportdesign)
        
        following https://cgit.freedesktop.org/libreoffice/core/commit/?id=bd536744ec947090819d59e0f0ec9f2c454aa428
        author	Julien Nabet <serval2412@yahoo.fr>	2021-06-08 22:00:41 +0200
        committer	Julien Nabet <serval2412@yahoo.fr>	2021-06-09 07:43:32 +0200
        commit	bd536744ec947090819d59e0f0ec9f2c454aa428 (patch)
        tree	c970950805e3953e5b7c663fa8095cbd20beb737
        parent	96f8ed6619a73655f9c3b94e6a4a3979cc67f551 (diff)
        Simplify Sequences initializations (reportdesign)
        
        Thank you Mike!
        
        Change-Id: Ib1dbcb3def89c2060534e30304cd8f35e5486efd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116880
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [49dfd2245b58c5b7e2c2115bb68d5f40289d40fb]

        gtk4: implement some more of the menu requirements
        
        just give each radiobutton its own group
        
        Change-Id: I0239a3f1364cde91a668fe890a4178e4ce73f78b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116864
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Caolán McNamara  <caolanm@redhat.com>  [80f37b8fdc9b3bf39abe437b016cdc69f836058a]

        gtk4: default that empty button labels are invisible
        
        Change-Id: If64e9592b48ac376933aac1e30ef76b096a3a0ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116859
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-09  Miklos Vajna  <vmiklos@collabora.com>  [6fdd0a3f8b3448a9a246496191908c92156cc38b]

        sw: allow the width of a line portion to be larger than 65536 twips
        
        The line portion width can be quite large if the line contains an
        as-char image.
        
        Found by asking -fsanitize=implicit-unsigned-integer-truncation
        -fsanitize=implicit-signed-integer-truncation to flag the problematic
        conversions.
        
        Change-Id: I303b9c71dcd979d79b9c9aee5283b268cc4e3b8c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116835
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-09  Dennis Francis  <dennis.francis@collabora.com>  [214e6b15de5f0704b063310ca667d8798b272a79]

        unit test: lok: text selection message test
        
        Change-Id: Ie551461e323a2705c5b0b159dd50e8a1eef7d364
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116429
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 42b08e239983063e559af8bd249213bba79eee48)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116543
        Tested-by: Jenkins

2021-06-09  Dennis Francis  <dennis.francis@collabora.com>  [299227ad81d4a44556fda8cca7b8b79219ba7e6c]

        autocomplete: allow cycling through possible matches
        
        Conflicts:
        	sc/source/ui/app/inputhdl.cxx
        
        Change-Id: I4a4b11312f36885d1c6fbe43c4850d55293b2557
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115859
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit ccbbd6bac6aaf5691a66a56b82d2592153336191)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116539
        Tested-by: Jenkins

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [10f501dec737f3c3da21d9df2b204d0385290477]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...since the (only) read of sText got removed with
        4e6be990eaf6a524740299e8d00fb5401c1a21c0 "weld SwTOXEntryTabPage"
        
        Change-Id: I24bceb37c106cc840cef60d6a08953ca25cc3d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116854
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [dfafa053945aa9ffea347c4b9a98f255b15016bf]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        The only read of nChgFormatLevel (spelled "nChgFmtLevel" back then) back at
        84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import" was in a
        
        > #ifndef NUM_RELSPACE
        
        block that was removed with f917bb6900bad2c9382374a2cbc5678b278dde2e
        "INTEGRATION: CWS swnumtree".  It apparently was dead code, as sw/inc/sw.mk had
        included
        
        > CDEFS+=-DNUM_RELSPACE
        
        ever since at least 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import"
        (which was later removed with 58003f28fc09cb2021e145afa0d0d692a7a402a7
        "INTEGRATION: CWS writercorehandoff" when all its remaining uses were also
        removed in that CWS writercorehandoff).
        
        Change-Id: I5972e2c949d21970e7f3f98a0a61600265ccb66b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116844
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-09  Miklos Vajna  <vmiklos@collabora.com>  [6cd8dd2123354578a1499a1e85e268f702f38954]

        CppunitTest_sw_ooxmlimport: rework to avoid the FailTest hack
        
        Change-Id: Ic59398c15f4caa04191dbf4d6252361a330fc8c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116863
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-09  Stephan Bergmann  <sbergman@redhat.com>  [13666bb9e5d5a45210322c339efef776dbc59f3f]

        external/mdds: -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        > In file included from svl/source/misc/gridprinter.cxx:16:
        > In file included from workdir/UnpackedTarball/mdds/include/mdds/multi_type_matrix.hpp:37:
        > In file included from workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector.hpp:1358:
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector_def.inl:851:15: error: variable 'start_pos' set but not used [-Werror,-Wunused-but-set-variable]
        >     size_type start_pos = m_cur_size;
        >               ^
        > workdir/UnpackedTarball/mdds/include/mdds/multi_type_vector_def.inl:3926:15: error: variable 'start_row_itr' set but not used [-Werror,-Wunused-but-set-variable]
        >     size_type start_row_itr = start_row_in_block1;
        >               ^
        
        Change-Id: I1f5e7e1f6a2b8457eb6d65dbd65336d3684c2b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116808
        Tested-by: Jenkins
        Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>

2021-06-09  Julien Nabet  <serval2412@yahoo.fr>  [bd536744ec947090819d59e0f0ec9f2c454aa428]

        Simplify Sequences initializations (reportdesign)
        
        Change-Id: I06f2675ee1270f04c6107761fbfc26a5570cc9c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116866
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-09  Andrea Gelmini  <andrea.gelmini@gelma.net>  [96f8ed6619a73655f9c3b94e6a4a3979cc67f551]

        Fix typos
        
        Change-Id: I3539edf26a793f89d38f3df376002f4ed4295343
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116869
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-06-09  Mike Kaganski  <mike.kaganski@collabora.com>  [31ed81ea71a20ec119805f66a42f99b3f80d2dc5]

        Missing include
        
        Change-Id: I020424db94a6fbdba22ff887b912d3f7bb459502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116709
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [3bcaa4ba79477a21251ddaa06e0ea159196a7ffb]

        Unset TZ when starting UITests on Windows
        
        This workarounds a problem that some tests in trackedChanges.py fail on Windows
        in specific time spans, at least in Europe/Moscow time zone: the change date in
        the dialog is reported according to local system time, while the expected date
        string is created in Python wrong, likely because datetime.datetime.now in the
        native Windows Python takes into account both system timezone data and the TZ
        environment variable coming from Cygwin (or some other kind of Python bug). The
        time reported by datetime.datetime.now was off by -2 hours, and resulting date
        string was wrong from 00:00 till 02:00.
        
        See upstream bug at https://bugs.python.org/issue44352.
        
        Change-Id: Ife3bcf000acac37f624a1065512513cc41dae596
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116862
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [dac70b9debb7c68def456ae90463ef6ced44c07d]

        fix packaging on mac/linux re cairo/pixman
        
        1193c331945481dd155a55c6695ff6fd88bd3d10 tried to simplify the makefiles
        for the Android case, but removed the conditional that would skip
        registering cairo/pixman for install for mac/windows (USING_X11,
        ENABLE_CAIRO_CANVAS & DISABLE_GUI all unset)
        
        Change-Id: I21509aaa1b2b1bffb583885148190b28fb097ecc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116860
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-06-08  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [b6a30a9db00f92eec7387a577321d65d47ff4af5]

        WMF tdf#142625 Refactor Bitmap records, to better handle missing features
        
        Change-Id: If3334158e6e0ef9bc3aa33656ad0ee45cf460dbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116827
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-08  Bayram Çiçek  <mail@bayramcicek.com.tr>  [59aed1d334de21270628c784920c61f2b8eb1da0]

        tdf#104995: Fix opposite cropping issue on flipped images in Writer
        
        In Writer, cropping an flipped image crops the
        opposite side of the image instead of the
        selected side.
        
        Fix: update crop values after the flipping(mirroring).
        
        Change-Id: I55cfed086bbf63b0c516e1cb6b2624c02b04a6da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116770
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [6d843855c3d71a214f869ca873362675071bbda5]

        set entry to expand and combobox to fill its assigned space
        
        Change-Id: Ia70513d3d6d6fa5ce69936231202f3a52fc56fe8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116857
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Bayram Çiçek  <mail@bayramcicek.com.tr>  [fae6f9fc498e1ac258844ee2712888710d530d0f]

        tdf#109388: Mouseover effect added to palettes in the Area tab
        
        In 'Format > Page Style... > Area' Tab,
        Mouseover effect added to the palettes on Color, Gradient,
        Bitmap, Pattern and Hatch sections.
        
        Change-Id: Idf036adc01b6b2ef6d62d2dd670ed6fb432bfbf9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116395
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [f06811e86d6ff208da79676d82109ddf1fc30710]

        resave with latest glade
        
        Change-Id: Ia2aa23dfa82728ac38e18bcc15e20ad72b35aa6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116856
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [130d097df4b324e3465723192833aaa68cc00a10]

        gtk4: expand the first child of the end group
        
        if there are start group entries
        
        Change-Id: I91188b0e5961a53730f6e157e8ea9be6b69ff92d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116851
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [803caf2882025e72d1834374d594dff0b4605e57]

        gtk4: reverse the order of the pack-type=end widgets
        
        Change-Id: I912dfa86f1f3cdb03c523530d8c3df510241831c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116850
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [7782f9fd753845a02fef90e89b50323c561f9118]

        sd: split CppunitTest_sd_export_tests-ooxml2 into two
        
        Change-Id: Ida23d59cd010d6fb9bf4fb8b5f82d2d764281773
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116826
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [25bd0c7ddf0b45c8628f0c7b1b57d3eb428bf1e5]

        This API change is since 7-2.
        
        Change-Id: I5ca672a9c67f9a7082ef72c63b388c953d77c22c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116843
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [c7a9a1dbe2b30afb564953ce1e856b95e3ec9436]

        Simplify Sequences initializations (desktop/e*/filter/forms/formula/fpicker)
        
        includes removing of unused TOKEN_SEP
        
        Change-Id: Ic72d9d94bd8d07232699ee4d948f3b203d524491
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116833
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [af8dc07bfdf5d6e7bd2278305cd39ed269e50ed7]

        Simplify Sequences initializations (dbaccess)
        
        Change-Id: I38ecf7f13a853909fc746ee9bf1167f9c15cbc5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116832
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [b32520f3e6b4ec4868d6e94d6fc20abb283c8308]

        Simplify Sequences initializations (cui)
        
        Change-Id: Iaf6a27f3a8dd156e91751a2fe242e8388f8d6b6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116829
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [b60a9bec769339f5f0fe008ef4985263d0cf689e]

        Addendum to: Remove SfxItemState::READONLY
        
        unfortunately forgot to remove some of the out-commented
        lines in f3b737ab76efaf1a70dfb22c6b60b08b340cf343, thanks
        to Julien for hinting me to that. So this is no semantic
        change at all, just syntax.
        
        Change-Id: If45b0cf1aeed870723914c2c02f6060d8f1bbfb4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116838
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Tibor Nagy  <nagy.tibor2@nisz.hu>  [312334f8488a668e9b5302959b60292ce151e4fc]

        tdf#47365 PPTX export: support loop attribute
        
        Follow-up to commit ad2809b4b6dc4837b0c1cadd89a14a234d995fb2
        "tdf#47365: import support for PPTX presentation's loop attribute".
        
        Change-Id: I7f75acc2bbd6301384883691d5ef4069b1757a05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116560
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [92d731d256d8a030ee1a150b04f0a7597171fb52]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8459f8839e7fc029963d35c81cf6768777209fa0
          - Python support for SF_Document service
            
            This patch also adds the Forms method to the SF_Calc help page.
            
            Change-Id: I317378db271c60ab97ac44e293aa7cbb54c81d0e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116696
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-06-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [1ad6c926cc5ff441d7b887678b505e1de7bb3408]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fa92861a200b3716202bb859b6e5b7f116e59501
          - Python support for SF_Base service
            
            Change-Id: I4175aecd307d70367eea49cc7a8407d2bca60634
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116707
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-06-08  Xisco Fauli  <xiscofauli@libreoffice.org>  [6e1758e5d852820b626d99b2208157ce7caeaca2]

        chart2: use registerOOXMLNamespaces and registerODFNamespaces
        
        Change-Id: I2ee15ec29fbf5fc4fcaea035a9cd99ba49453a4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116831
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-08  Heiko Tietze  <tietze.heiko@gmail.com>  [086fa727cabf46eacfec1a0fd4f6dfe916aa2f04]

        Resolves tdf#131817 - Option to globally switch toolbar locking on/off
        
        Reverts 6993d5d0f1079fe720a7da004b70b57361c99fc6 and
        sets Locked in GlobalSettings to true
        New UNO command ToolbarLock to toggle the state added to
        the toolbars menu
        
        Change-Id: I246280b2b7930f2bf686e6fc26383da4799b5028
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115797
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-08  Justin Luth  <justin_luth@sil.org>  [a2d8a737f41cbb0ed8a51a99b1c233b25e433d1c]

        tdf#142404 DOCX c15: add compat flag TabOverSpacing
        
        DOCX in 2013 (compatibilityMode 15) no longer supports
        TabOverMargin (i.e. the text margin),
        but it does a similar kind of thing if the tab goes
        into the spacing-after of a paragraph.
        So add a compat flag to handle this in-between
        kind of situation.
        
        I grepped -i "tab_*over_*margin" to see if I was missing
        anything. Decimal/Center proved to be only tabOverMargin.
        IsInSect shouldn't matter since it fits inside the printing range.
        The other places where I didn't insert TabOverSpacing
        didn't seem relevant based on a code read.
        
        Tab-after-tab still doesn't work great, but what we have is
        already a massive house of cards that will just collapse if changed.
        No real provision for handling tabs-over-paragraph-end.
        -auto-tabs are created instead of "beyond nMyRight" tab,
         unless it is the first tab defined.
        -doesn't allow auto-tabs to fill the remaining space.
        
        But on the other hand, MS Word's implementation of tabs
        follows some kind of incomprehensible bizarre logic,
        so just ignore the tabs completely, please.
        
        Change-Id: I3723107b29ec3e287ea8661544711c13eee3ca48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116667
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-08  Rafael Lima  <rafael.palma.lima@gmail.com>  [c4c8202359e574bce784f6b40ce95e49e983c7bb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 55408cd1b3e29b3706c2cb8b44dd55284f3c3fff
          - Update SF_Basic service help page
            
            Adds the following methods:
            - CDate
            - CDateFromUnoDateTime
            - CDateToUnoDateTime
            - GlobalScope.BasicLibraries
            - GlobalScope.DialogLibraries
            - ThisComponent
            - ThisDatabaseDocument
            
            Change-Id: I963ad0d850987b1047b28b34b9a1e264b2414eff
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115965
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [486a11ad6fdae1714200229462b69f328be06b5a]

        editengine-columns: PPTX support (tdf#118458)
        
        The unit tests that used to check the workaround using tables to
        emulate columns (implemented in tdf#120028) are changed to test
        import of the columns.
        
        This reverts some commits related to the mentioned workaround,
        namely aef569ed83a3ccc02639e5b2a1c7cc131ba262fc,
               c50ae6a282ed83762bf634fed5c91033eb305c88,
               7b64bd90637a6722438bf873b1ded74ab3424c46,
               33696b2820ce3c8b21b753d2c2bf92345ecb9276,
               99dff69b561a8fe2d9437e6aa67a9581a6666f41.
        
        Change-Id: I97693ad4a981780e822070938992f274920df5a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116738
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [d0a1616ccad0dd5f5a02c1b0204f537b57d0b4b5]

        editengine-columns: Implement layout
        
        This changes the way how different parts access positions of lines and
        paragraphs. Now there is ImpEditEngine::IterateLineAreas, which performs
        uniform iteration over all ParaPortions and lines in order, calling a
        user-provided callback function for each portion and line; it passes
        all information about current portion, line, area, and column to the
        callback, and checks the return from the callback, to decide if it needs
        to continue iteration (in case when callback indicated that if doesn't
        need further data), and if it needs calling the callback for the rest of
        current portion's lines.
        
        This allows to have the code that calculates and iterates dimensions of
        lines in one central place, without the need to have duplicating logic
        in several places.
        
        One important exception is ImpEditEngine::Paint, which iterates without
        ImpEditEngine::IterateLineAreas, because it does many atomic paint
        operations in different points of iteration process, and implementing
        ImpEditEngine::IterateLineAreas to call callback in the required places
        would require increased complexity, which is left for a future change.
        To make that possible, ImpEditEngine::IterFlag should be extended to
        indicate additional requirements.
        
        Note that in fact, ImpEditEngine::Paint was taken as the model for
        implementation of ImpEditEngine::IterateLineAreas, with its detailed
        handling of all the vertical offsets like additional line spacing and
        interparagraph spacings that depend on context.
        
        The notable result of the centralization of the iteration code is slight
        change of heights reported by ImpEditEngine::CalcTextHeight. Previously
        it simply added all pre-calculated heights of portions, and not taking
        into account all the spacing handling that ImpEditEngine::Paint did,
        which was inconsistent (calculated height was different from painted
        height). Now ImpEditEngine::CalcTextHeight should provide more accurate
        results, which required small changes in the unit tests.
        
        Change-Id: I33cbb978deb974b314d36fda8674186a03991107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116034
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [95ebd24a629b4c8cd62cc20c0701683512cc8fa0]

        editengine-columns: ODF support [API CHANGE]
        
        This uses existing ODF markup, as used by Writer's text frame:
        style::columns child element of style:graphic-properties, its
        fo:column-count and fo:column-gap attributes. No ODF extension
        is required.
        
        Since currently only columns with same width and spacing are
        implemented, without additional settings, style:column child
        elements are exported, but ignored on import.
        
        This adds new property to css::drawing::TextProperties service:
        TextColumns (of type css::text::XTextColumns).
        
        Change-Id: I7e63293e5814b281ceec8a9632e696322d3629e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116035
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c4f615b359be56e88e4fbf9aaaf30affb29d57e2]

        editengine-columns: Create document model and dialog page
        
        Change-Id: I056aad9474ca18134d1f1686a53618cc9ab3d525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116038
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-08  Stephan Bergmann  <sbergman@redhat.com>  [064a13e94e9b38bc88381b5c497cf6c9ddbe93e4]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code's introduction in
        ea1ca189b561e47d3b872f40628e6af224355626 "added api for glue points"
        
        Change-Id: I221632d243c8c778c711c3f001676ff26043d0fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116825
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-08  Alain Romedenne  <alain.romedenne@libreoffice.org>  [73edebb5ad8f8583367199bc7a48fd98a0147371]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cfd0aa4ba18b58179724d50d7d1ac4f500ca1db4
          - Remove literals that prevent proper L10N
            
            - extra index
            - index relocation
            
            Change-Id: Ia52c0db88406dd5b24514280c663cfb5de157091
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116169
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [6ef69234cf9138000a1dcf483114ea7c792fe3ed]

        Simplify Sequences initializations (comphelper+connectivity)
        
        Change-Id: I8a91f4bd2a1117acb571f1058af18071bc058c9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116815
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [de9b6e3deeeffa2405fe890946714c2e439e1583]

        cid#1485166 silence Uninitialized scalar variable
        
        seeing as there are no warnings about
        SvxRTFItemStackType::SetStartPos
        try that pattern
        
        Change-Id: Icad28503047323b01d8e048061c6b037bcdcb83c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116817
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Caolán McNamara  <caolanm@redhat.com>  [1e56a952cecabcaa04fa442c7891ca67e9d4601a]

        cid#1485887 Unchecked return value
        
        Change-Id: Ie7cf188ef4aa72ea5266b0925363c904b4a7812c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116814
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [46ea7c5d8be6b3e9436a44240117f83808d9d4c1]

        Simplify Sequences initializations (cppcanvas)
        
        Change-Id: If2d882060422b4e450de9ddda28d8d5c624c8e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116816
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Stephan Bergmann  <sbergman@redhat.com>  [7d9781367133f8d79bbd96e638be51119702930a]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        ...ever since the code's introduction in
        59560e4c13de5787a586ea643f6e58371ecf4c14 "INTEGRATION: CWS dba22"
        
        Change-Id: Ic8acc06c85a3f82d24467cb403250df095c6b869
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116812
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-08  László Németh  <nemeth@numbertext.org>  [16eda7db38e978a178b161cff7715ee4a32f1493]

        tdf#142128 sw: set author-color strikethrough for AS_CHAR images
        
        (anchored as character) during change tracking instead of
        using always the same NON_PRINTING_CHARACTER_COLOR blue one.
        
        Follow-up to commit 76dc21860ce185bd5495adde8858d2f23284c78e
        "tdf#142128 sw: set author-color strikethrough for deleted images".
        
        Change-Id: I3fa02f6ec6cd1f71ae3b3c06644dd24f6c684f6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116795
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-08  Stephan Bergmann  <sbergman@redhat.com>  [489102d28e9c67773d72eedfc4e663f51fe331ea]

        Silence -Wunused-but-set-variable (Clang 13 trunk) on volatile variable
        
        (see the comments starting at <https://reviews.llvm.org/D100581#2795966>
        "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable" that warning
        on volatile variables is intentional)
        
        Change-Id: I2f9d0ed4a7f11f0bc2bdea57c0434654cd9fdf95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116813
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-08  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [93605ab85a8b62dbfb59a9181a26b75a032b9a94]

        Use containerToSequence for Sequence of dynamic size
        
        Instead of set of conditions to detect size of resulting Sequence
        this should be shorter and cleaner.
        
        Change-Id: I52c87ecf3f21f40a52be5ac180a14499f4512072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116772
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [2d5fb75274fc34f71c45b8e483684086bb50c686]

        Simplify Sequences initializations (chart2)(part 2)
        
        Change-Id: If03d2f7f22c65aaebe236d9b33e6609d31660387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116810
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  Armin Le Grand  <Armin.Le.Grand@me.com>  [f3b737ab76efaf1a70dfb22c6b60b08b340cf343]

        Remove SfxItemState::READONLY
        
        As I experimented with redesigning the whole
        Item/ItemSet/ItemPool paradigm, I alredy checked that
        SfxItemState::READONLY is not used (and no one
        really knows what it should do or stands for).
        Since a removal of complexity is needed to get forward
        with that redesign and I already made some experiences
        in branch item_refactor2, I propose to remove this
        state. It is not really used (gets never set).
        It is mirrored/used in the UNO API in
        css::frame::status::ItemState as 'READ_ONLY', but also
        not used in the office's code. ItenmState itself is
        used in three places, but all set the Item involved
        by using a SfxVoidItem to state SfxItemState::DISABLED,
        which I described in ItemState.idl. This means that
        no state of READ_ONLY in UNO API is ever imported
        to office code as DISABLED state at all, so not
        used.
        I also marked it as deprecated in the *.idl file.
        
        I think - including the experimenting in the
        mentioned branch - that this is safe for now. I
        already run a full 'make check' on the changed stuff.
        
        Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-06-08  Heiko Tietze  <tietze.heiko@gmail.com>  [8fee41f75c5da6c6e7df34a9b4f73ddf59944446]

        Improvement of variable description
        
        Making it more clear that MinimumWidth is a boolean value
        
        Change-Id: Ifcf08dcc42001ca6fd81ae8649e9726746bccdb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116776
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-08  Julien Nabet  <serval2412@yahoo.fr>  [5895be734d1872c9c014aca5fe77813dd78cfd14]

        Simplify Sequences initializations (chart2)(part1)
        
        Change-Id: I97ddde9659f337932b4165b794a769b83882126d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116802
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-08  László Németh  <nemeth@numbertext.org>  [76dc21860ce185bd5495adde8858d2f23284c78e]

        tdf#142128 sw: set author-color strikethrough for deleted images
        
        anchored to character during change tracking instead of
        using always the same NON_PRINTING_CHARACTER_COLOR blue one.
        
        Follow-up to commit 1610eeef6f2312616fe5d3535475f27f7896bef8
        "tdf#142196 sw: crossing out images anchored to character".
        
        Change-Id: I267a492dc6bb75327fb96ccdb51b784d00ba7a41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116785
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-08  Miklos Vajna  <vmiklos@collabora.com>  [46cc1c79485f81f2e657c226de44d68cec752e6f]

        tdf#141805 sw: hide rtl gutter UI for ODF documents
        
        ODF doesn't track RTLness of the gutter explicitly, it infers this
        setting from the writing direction. This means that in case the UI is
        used to set it explicitly to a custom value, it'll be lost after
        export + import.
        
        Fix the problem by hiding the widget in the ODF case, so it doesn't
        confuse users; it's still visible for Word formats which store this
        explicitly.
        
        Change-Id: I1316dcf461429af72498957c9b3eebcbdac794bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116799
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-08  Dennis Francis  <dennis.francis@collabora.com>  [2881b2fa25bfe1933857738b0b551ebb6c687bdc]

        unit test: lok: edit cursor invalidation message
        
        Conflicts:
        	sc/qa/unit/tiledrendering/tiledrendering.cxx
        
        Change-Id: I255e3b637329fc1fb41d24e79a770051ee827162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116428
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit d1a1b8ac3d7eea4b571d8015e31549f39a0b20ed)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116542
        Tested-by: Jenkins

2021-06-08  Dennis Francis  <dennis.francis@collabora.com>  [c844aa36cc4268f182ec4f6627fb2b8f4cce7b15]

        sc: lok: apply the previous fix for selections too
        
        Conflicts:
        	editeng/source/editeng/impedit.cxx
        
        Change-Id: Ic1f6c1642da71e0ef8c23831786ae405dda21133
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116427
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        (cherry picked from commit c5e249877b93e9d11788ec04fffee1dcb142a0e5)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116541
        Tested-by: Jenkins

2021-06-08  Dennis Francis  <dennis.francis@collabora.com>  [eed212b1cc03b8f131e5c28730b0e6a55c3e22af]

        sc: lokit: fix wrong edit cursor coordinates for numeric cells
        
        The cursor coordinates returned by editengine implementation is computed
        with respect to document-visible-area in "display" hmm and not "print"
        hmm. For numeric cells, the visible top-left is always non-zero, hence
        triggering this incorrect "refpoint" subtraction to compute "relrect".
        
        The fix is to calculate the correct "relrect" by subtracting the display
        hmm version of "refpoint" from the edit cursor rectange and then convert
        to twips.
        
        Change-Id: I4b663edcb1f74e1bdcc300788769d580fcfe7e17
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116426
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        (cherry picked from commit 77704022556bb97a64ef47666230a2c0232d45d3)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116540
        Tested-by: Jenkins

2021-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b7bfe009ac35cb5fda9ca14404fea924acb54fa]

        sd: use registerOOXMLNamespaces and registerODFNamespaces
        
        While at it, fix incorrect r:Relationships with
        rels:Relationships
        Change-Id: Ia8e6556b0e7d3839e00936626627471a7a276071
        
        Change-Id: I77f950dabd4d2131256673e517625d31ade9aa76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116800
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [039180f8255b6356cb89b1777e4e53323541898d]

        Revert "improve logging message"
        
        This reverts commit 9f0484c2bca8e7ec5e0d83289fae9b474b8598e0.
        
        Reason for revert: this patch was unnecessary, the operator<< for css::uno::Exception alreadys logs the message, I got confused
        
        Change-Id: I45932be060059eac92d460a70c944e1b19b5c375
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-07  Caolán McNamara  <caolanm@redhat.com>  [01c20a75b388ded73a4f220970cf3c2e95f83dff]

        ofz#35033 missing components
        
        Change-Id: I5b0322d026f819dde0a1a2473087e56ebb75008a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116801
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-07  Caolán McNamara  <caolanm@redhat.com>  [f9b721bb6fb243465029273265b757288cf391c9]

        gtk4: convert pack-type to child type
        
        Change-Id: Id72572b1b97917b9cf3816b1abaa1e412ed028a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116766
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-07  Henry Castro  <hcastro@collabora.com>  [7f49c4eea51c6c84ee7adacd5ba45e1e0fc4c1f7]

        sw/qa/uitest: close the dialog if thrown an exception
        
        if a unit test opens a dialog and exception
        is thrown if does not exist a control, the
        terminate() method fails, the unit test will
        wait indefinitely for the subprocess to terminate.
        
        Change-Id: I6dc77b2db8ce042ead78d13ce57e91892cd2db90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113896
        Tested-by: Jenkins
        Reviewed-by: Henry Castro <hcastro@collabora.com>

2021-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [6004f17ae68cc6c15ef9cc96cc502dd4a09d6cf1]

        sd: Use template for export test modules
        
        Change-Id: Ib604d0ad64dc16dbf9c0115a0fb30a8e3c6da337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116787
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3893b54e3656c07e182947a4fd5ef1b0be82bd2e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 68a8e252d2600cabc694d9c489ec641dbd3c902a
          - tdf#124066 Help for VBA StrConv function
            
            1) LCID codes linked to LibreOffice internal LCID file
            2) Examples borrowed from QA tests
            
            Change-Id: I1b00a1901f32de0243b518de39abd633ba08eadc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116684
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [a50f482fa1b2239f317add1b83ffeb08b14a44a8]

        Move PPTX testdoc to respective directory
        
        Change-Id: I020998c8e8b2a715a7f0a924bd24e09082599a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116788
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-07  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [629fe3a8e6fdf1602add0803b7d06e70215cda33]

        tdf#132667 - Grab focus on the last inserted property
        
        On removing/adding custom document properties, grab the focus on the
        last empty shown name box.
        
        Change-Id: Ifd66566d4ae9fa57b9f1a9aae5f9cb93dbb74070
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115872
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-06-07  Miklos Vajna  <vmiklos@collabora.com>  [02c435082058ecf7f9d4d73cb47d31d0218dc10d]

        sw keep aspect ratio: add filter for this setting
        
        SwViewOption::IsKeepRatio() was only in-memory, so ticking that checkbox
        and restarting soffice disabled it again.
        
        Handle this similar to e.g. the zoom factor which is mapped to a
        view-specific settings.xml key.
        
        Change-Id: I8d2de7d2c7ae0dbf34230e2011f6b07f63e02fbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116791
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [a0bbeef0a8d9eeccc9ab9857851e0658139f2e1c]

        sw_uiwriter: split uiwriter into 2
        
        it already has 230 tests
        
        Change-Id: Id06ffb791cf65342676e6d7076105773c8137685
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116784
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [95f40ec1cdfe5c9db3e86c1092538dba8a129a72]

        uiwriter: keep CPPUNIT_TEST_FIXTURE tests together
        
        Change-Id: I19162c6e6868dc9eb57444f5b33dc2bad299c230
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116783
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [9f0484c2bca8e7ec5e0d83289fae9b474b8598e0]

        improve logging message
        
        Change-Id: Ib8f4fdbe3d644c035a125f7ae0a035a95bcafc76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ddfec46bcebc36fdf0191d46bd3bcce6ae7cfa67]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 84d49dae2c041fa294415d4deba31f4477a663a3
          - Add link to half-width / full-width glossary entry to search&replace dialog help page
            
            Change-Id: I54d892b1112375c6dce64904df61ffffa79c37f4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116705
            Tested-by: Jenkins
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-07  Ming Hua  <plateauwolf@qq.com>  [4642cddcc54c352e26272dab3099f0fe65bd170e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 47df6ad11ac2e9c8c8d1f6e9c1049acbb56785e1
          - [WIP] tdf#142652 Add glossary entry about half-width ...
            
            ...and full-width characters
            
            Change-Id: If12dbc28de60fa7430d02530cf2d7fa7900c6675
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116771
            Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-07  Eike Rathke  <erack@redhat.com>  [8e7a9b0243a4a63841d1cb1faba118274d574053]

        Resolves: tdf#142216 Fix {hu-HU} AM/PM words, default time without leading 0
        
        Change-Id: Ief925b01a882bd59807b7e6e8c84b77b5ca3485f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116713
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [d161c4de0b145b975bc90ce4b0a1ff7c234b676e]

        tdf#142483: sw_xhtmlexport: Add unittest
        
        Change-Id: Ie22d23a49e4e1f352cec5ef32c2b0545b50f5aa5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116777
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [6bebaddb39849422dffa16316c543fc69305f31a]

        WMF tdf#142625 Continue read records if unimlemented features found
        
        Most of DIB records (DIBCREATEPATTERNBRUSH, STRETCHDIB)
        are implemented partially. If the unimplemted feature are inside
        WMF, then the whole reading steam is interrupted and nothing
        is displayed.
        
        With this commit if DIB record used missing feature,
        then the warning is displayed, and the displaying continue.
        
        The fix allows for displaying WMF image from tdf#55058
        
        Change-Id: I6cc88d41486c52a2b1a6ec0b89166460a78ce7d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116763
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-07  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [3ffc5df4e17068319bd6ed0c854d92a702ef326a]

        sw: WriteLong/Short -> SvStream::Write[U]Int[16|32]
        
        Change-Id: I1c09a3bbf301166ccab16ecf0b57f22a335e0791
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116778
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
        Tested-by: Jenkins

2021-06-07  Julien Nabet  <serval2412@yahoo.fr>  [87e8d5ec6bb2fa332d2c374040d39ca18462cb6f]

        Simplify Sequences initializations (canvas)
        
        Change-Id: I651858d71e378341205d6a785bd97f294664a439
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116737
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e9a824dd6c1c33777461874d9892343d193c867d]

        tdf#127028 "bpmn" template should have ext. otg instead of ott
        
        "bpmn" is an template for draw documents and not text documents
        (writer) so it should have the extension otg and not ott. This is
        also important for the template manager as it categorises the
        templates based on the extension, so the bpmn was not categorised
        correctly.
        
        Change-Id: I503b972711830dc3c5ab98d9c24f974862ffc540
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116775
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-07  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [996694d78641df4b2adb5357e6e274a9f9e8ca46]

        find-unneeded-includes: fix YAMLLoadWarning on newer systems
        
        After upgrading to Ubuntu 20.04 I got this warning:
        YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
        
        Change f-u-i per instructions on website above to fix this warning.
        
        Change-Id: I4424b0ced49d81dceb33131e1df150387a89df4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116748
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-07  Miklos Vajna  <vmiklos@collabora.com>  [cc99d43295322a2d6b4abc9b9a8f2e03e3db89f2]

        sw: prefix members of CSS1Selector, HTMLStartEndPos, SvxCSS1MapEntry and ...
        
        ... SwHTMLPosFlyFrame
        
        See tdf#94879 for motivation.
        
        Change-Id: I4d1a427653aea5c6414f79c8eaea71336150bab7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116773
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-07  scito  <info@scito.ch>  [eb5e2e70ab4eaab9fea555160e61b24bd9941a63]

        move remaining copy/paste tests from ucalc to ucalc_copypaste
        
        MixData test cases test the special paste with operations such as ADD.
        
        testCopyPasteMatrixFormula belongs also to the copy/paste tests
        
        Change-Id: I2b142b3f95edbc740dd8c8a00de9a00bcf8a22d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116743
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-07  Jim Raykowski  <raykowj@gmail.com>  [ec629c5ee22d02f99d66a5cf975ce239876b7f4d]

        Resolves tdf#142513 fix zoom caller handling
        
        Calling ZoomPlus has always executed shell SID_ZOOM_OUT case handling.
        ZoomMinus, which replaced ZoomIn, does SID_ZOOM_IN case handling.
        
        This patch changes ZoomPlus to do SID_ZOOM_IN case handling and
        ZoomMinus to do SID_ZOOM_OUT case handling and makes appropriate
        changes required by these name changes to provide expected zoom
        results in all module shells that have handling for these calls.
        
        Change-Id: If148f4f7866bfc8fc6452ad1c1dace723a125ef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116287
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-06-07  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7f059ce157da0de40a98f63f61d923cc67d93884]

        tdf#142478 add test that triggers find all and crashes
        
        String "Crash" in document and notes, then trigger "find all",
        which produced a crash without the fix in-place.
        
        Change-Id: I8e6e4a9da1afc85643648aee36a03c1fb39ca16d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116769
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-07  Noel Grandin  <noelgrandin@gmail.com>  [a288585ecab5acebbb95bd86c125ad5294a5c031]

        pass -enable-symbols down to libxml
        
        Change-Id: Iceef587366bebe6007f40e100f19e6a2f048adda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116764
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-07  Heiko Tietze  <tietze.heiko@gmail.com>  [f43fdcad400b6ff51f0810d923fe75d5a2cfde0c]

        Resolves tdf#140360 - Provide option to turn off sidebar's minimum width
        
        Boolean option Sidebar:General:MinimumWidth introduced defaulting
        to true; if false the sidebar width is under full user control
        
        Change-Id: Iab1413a83adf90461feb5d6416aad174439392ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116715
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-06-07  Martin Srebotnjak  <miles@filmsi.net>  [c617b11ff37a18225f9666b7d028a734d12b360a]

        Update git submodules
        
        * Update translations from branch 'master'
          to c856f9a26324096ca38ffea04bd282e37ec661ea
          - Update Slovenian translation
            
            Change-Id: I02198f187bd48f4f3d7ce6cda65a0389d210d606
            
2021-06-07  Mike Kaganski  <mike.kaganski@collabora.com>  [76ce593d2bbb1fc7e242db564f301d6721ba8e45]

        Restrict test a bit to verify that there indeed is scaling
        
        ... just to make sure that changes like a1ae30166e92a0a40dff06740f0bb8e9ee63f70a
        don't break the test.
        
        Change-Id: I4d9f8a6a85fc155c2b67c76152b1aaa7df384a38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116701
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [a1ae30166e92a0a40dff06740f0bb8e9ee63f70a]

        Fix and unify the two methods that get scaled text size
        
        GetTextFitToSizeScale and SdrTextObj::GetFontScaleY both didn't
        initialize outliners properly, and thus returned wrong results.
        
        Change-Id: I6fe63c51ed838a0d0fafdfa03597cac97ce29831
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116765
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [2671476e7c8acc6569840e66e6d306b890b431fd]

        gtk4: don't need to 'formatMenuButton' anymore
        
        Change-Id: I84e53f23986d15dde571c6bc7559ef68be345d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116762
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [a134845061b16e43d192feaceac3ecb8f4a51cdb]

        gtk4: convert MenuButton "image" to "icon-name"
        
        Change-Id: Ic290b6008739a729b786562affb72d26da2191d3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116754
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [e2e89bb4187e08c4b6052f535d80886e198051c8]

        enforce indicator consistency
        
        so there is either a standard indicator shown or one of a small subset
        of named icons
        
        a) adds an indicator to show the MenuButton provides a dropdown to the
        spelling dialog when there are multiple user dictionaries the word could
        be added to
        b) use open-menu-symbolic instead of gear icon for the sidebar menu
        
        Change-Id: If4f0842fb0f805dde45e375061f23d2aaea0990c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116757
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [3f59f4a7e667b571640572f9316216ec73aeca7d]

        add x-office-calendar to allow symbolic names
        
        for gen map to existing sc/res/date.png
        
        Change-Id: Id85f5df27fd93deb7d1e653ae6cac1fb471d3470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [b97cc798c468c8936f78453b3330806eff481828]

        use open-menu-symbolic where sfx2/res/menu.png was previously used
        
        Change-Id: I5030afe7d370b49b24f6a590bf9ce6e2a7a428e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116756
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [81b07aeaf4b917825af81b1a8b9c006b3fc416ca]

        use sfx2/res/menu.png for open-menu-symbolic
        
        which we do already in additionsdialog etc and is a better
        match for open-menu-symbolic
        
        Change-Id: I5b466945b9f045cc2bdf122b05ae4e85485bbef6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116755
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [baab429763bef88c22d5c6656197ff28a7d6134f]

        use open-menu-symbolic for menubutton gear menus
        
        https: //wiki.gnome.org/Initiatives/GnomeGoals/GearIcons
        Change-Id: Ia95451f950728c4174887a042a6666e1dd7cc1ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116753
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  Caolán McNamara  <caolanm@redhat.com>  [d125024874da5d22abf0d60b8a13c355effff495]

        gtk4: set same use-underline on inserted GtkLabel as parent GtkButton
        
        Change-Id: I6618433faf2379bfadf7a257e394785360d07526
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-06  tobias  <tobias.schulz@hotmail.com>  [162f5a20095c6937030d23ee03fb8f72c51eefa1]

        tdf#142669 Consider BOM on text encoding detection
        
        Return a flag if the auto detected text has a BOM.
        Save the flag in SwAsciiOptions so that BOM gets set correctly when
        file is written.
        
        Change-Id: I358c3ba243bc326a552c2dc24773c94f8319c700
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116759
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-06  Mike Kaganski  <mike.kaganski@collabora.com>  [89aaa17a0a4413f07da2bc5084b0164f15dc01ac]

        UITest: introduce guarded context managers
        
        They should be used wherever we need to make sure to execute
        some action in tests regardless of the assertion success. They
        follow their plain counterparts, and execute finalizing code
        at all outcomes. This e.g. allows to assert when a dialog is
        open, and have it properly closed on failure, so that the test
        is not left in hung state.
        
        Only two wrappers are implemented now: load_file and
        execute_dialog_through_action.
        
        sc/qa/uitest/chart/chartLegend.py is updated to use them.
        
        Change-Id: Ib9cf44304f0d3ab8fa3377922ed36d2d866031b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116692
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-06  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [3b75f9add7ed80e803b0771d86892d6ca0f47e71]

        tdf#142478 fix crash when searching and a viewshell change occurs
        
        When searching a impress document for a word, and the word is in
        notes as welll as in the document, a crash happens (only when
        searching with "find all"). The regressing commit changed that the
        search is now bound to a view (and to a viewshell). When searching
        for words in notes and document, at the transition from "standard"
        to "notes" page kind mode, the view and viewshells are destroyed
        and the new one created again. The problem lies here as when we
        destroy the viewshell, we also destroy the search context and
        FuSearch objects, but we are still executing the search -> crash.
        
        The solution for this is that when we change the page kind,
        we take the FuSearch object from the old viewshell and put it
        into the newly created viewshell, so that we keep the FuSearch
        object alive and don't throw away the search context too.
        
        Change-Id: I50931cca2a20c5704f7450e3cc8b3466af4c5a3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116758
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [e99f1824af658e899d7584bb2beb8bba4c2a135d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 096e8e98912ae2d7eee5975e7e2beb4d5883180b
          - Use %PRODUCTNAME
            
            Change-Id: I73d62b9dfa8a70faf473dbd54a5b066edc028bf0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116700
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-06  Olivier Hallot  <olivier.hallot@libreoffice.org>  [58e9f18e72fdd0dde2a3fdba9a70c4043d68827e]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9de52c620aece66d6cb97e23301cbbb884d19615
          - Tiny table formatting fix.
            
            Change-Id: I0ed3b2ee3bb3788688e81b15cb19b9d41d98de13
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116699
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-05  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [33d2cf7008de79106b5da4bba0241aa14d81d88f]

        WMF Change the sign of read fields in BITBLT and DIB records
        
        Additionally the names of variables were improved,
        and additional checks were added for unsupported cases
        Change-Id: Id84ef1218c5c2a40c8d01f2d40857d892badbb9f
        
        Change-Id: I1b8571d0a627827bc1e67c2bfc6c1932d58c5233
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116744
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-05  Julien Nabet  <serval2412@yahoo.fr>  [399a6472f666ae6c3e20b6f8367f9fd089c15605]

        Potentially uninitialized local variable 'aEvpMd' used
        
        Seen on Win10:
        cd C:/cygwin/home/serva/lode/dev/core/oox && C:/cygwin/home/serva/lode/opt/bin/make -j 1 -rs build
        [build DEP] LNK:Library/ooxlo.dll
        [build CXX] oox/source/crypto/CryptTools.cxx
        C:\cygwin\home\serva\lode\dev\core\oox\source\crypto\CryptTools.cxx(122) : error C2220: the following warning is treated as an error
        C:\cygwin\home\serva\lode\dev\core\oox\source\crypto\CryptTools.cxx(122) : warning C4701: potentially uninitialized local variable 'aEvpMd' used
        C:\cygwin\home\serva\lode\dev\core\oox\source\crypto\CryptTools.cxx(122) : warning C4703: potentially uninitialized local pointer variable 'aEvpMd' used
        make[1]: *** [C:/cygwin/home/serva/lode/dev/core/solenv/gbuild/LinkTarget.mk:301: C:/cygwin/home/serva/lode/dev/core/workdir/CxxObject/oox/source/crypto/CryptTools.o] Error 2
        make: *** [Makefile:122: oox.build] Error 2
        
        Change-Id: Id9409c95aa3edf866671ef8418e7ade3cbc1e718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116740
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-05  Caolán McNamara  <caolanm@redhat.com>  [c0a7b479aff23c887d23ca550c048f184eda7853]

        gtk4: MenuButtons can have images too
        
        Change-Id: Ib6a7eed8036273d5e31ddff5611ec42fb45ffa4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116751
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-05  Caolán McNamara  <caolanm@redhat.com>  [2614ca783d3fa181a8a3a00c38103abc54cac56c]

        psp::PPDParser::getParser deadlock on launch
        
         #3  0x00007fef4e844945 in std::mutex::lock() (this=0x7fef4f817640 <psp::PPDParser::getParser(rtl::OUString const&)::aMutex>)
         #4  0x00007fef4eb2da43 in std::lock_guard<std::mutex>::lock_guard(std::mutex&) (this=0x7ffc2f47a2a0, __m=...)
         #5  0x00007fef4eb1dd12 in psp::PPDParser::getParser(rtl::OUString const&) (rFile="SGENPRT") at vcl/unx/generic/printer/ppdparser.cxx:535
             ^^^second reentry^^^
         #6  0x00007fef4eb76f3b in psp::CUPSManager::createCUPSParser(rtl::OUString const&) (this=0x329c0e0, rPrinter="CUPS:MP230-series") at vcl/unx/generic/printer/cupsmgr.cxx:533
         #7  0x00007fef4eb1e4fa in psp::PPDParser::getParser(rtl::OUString const&) (rFile="CUPS:MP230-series") at vcl/unx/generic/printer/ppdparser.cxx:565
             ^^^first entry^^^
         #8  0x00007fef4eb7815d in psp::CUPSManager::setupJobContextData(psp::JobData&) (this=0x329c0e0, rData=...) at vcl/unx/generic/printer/cupsmgr.cxx:566
        
        since...
        
        commit 80255dcde14755bb4a342b7392fb26d27580ff6d
        Date:   Sun May 30 19:29:07 2021 +0200
        
            vcl unix : use std::thread in PPDParser::getParser
        
        Change-Id: I3c66e23568e388425de9ee07f2d7606f4df0cfd3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116750
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-05  Mike Kaganski  <mike.kaganski@collabora.com>  [cb90eda86544fdda9bd49f394b7a286fa355ce90]

        Blind fix for sporadically failing UITests
        
        Attempting to avoid this problem:
        
          ======================================================================
          ERROR: test_tracked_changes_acceptall (trackedChanges.CalcTrackedChanges)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "C:/lo/src/core/sc/qa/uitest/calc_tests4/trackedChanges.py", line 127, in test_tracked_changes_acceptall
              gridwin = xCalcDoc.getChild("grid_window")
          uno.com.sun.star.uno.RuntimeException: Could not find child with id: grid_window
        
          ======================================================================
          ERROR: test_tracked_changes_reject (trackedChanges.CalcTrackedChanges)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "C:/lo/src/core/sc/qa/uitest/calc_tests4/trackedChanges.py", line 173, in test_tracked_changes_reject
              gridwin = xCalcDoc.getChild("grid_window")
          uno.com.sun.star.uno.RuntimeException: Could not find child with id: grid_window
        
          ======================================================================
          ERROR: test_tracked_changes_rejectall (trackedChanges.CalcTrackedChanges)
          ----------------------------------------------------------------------
          Traceback (most recent call last):
            File "C:/lo/src/core/sc/qa/uitest/calc_tests4/trackedChanges.py", line 239, in test_tracked_changes_rejectall
              gridwin = xCalcDoc.getChild("grid_window")
          uno.com.sun.star.uno.RuntimeException: Could not find child with id: grid_window
        
        The problem looks unexpected, since UITest.create_doc_in_start_center
        waits for "OnNew" event, but who knows...
        
        Change-Id: I38207944f0f2fb67cf6e97ee1c220bbd95dc7047
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116698
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-05  Caolán McNamara  <caolanm@redhat.com>  [d6eb61707c15cda590cd16e9cbdce2b193889ff0]

        cid#1485166 silence Uninitialized scalar variable
        
        the markup in the other case seemed to work
        
        Change-Id: I2276f370b3f696082fd4ebfcbd29a13e2bea85ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116747
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-05  Julien Nabet  <serval2412@yahoo.fr>  [3e8e5f079e032a2b7b709bc01113f14da893263c]

        Simplify Sequences initializations (accessibility/binaryurp)
        
        Change-Id: I4b388b7faa1dc47f27d29aaaff9041fe81a29f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116739
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-05  Caolán McNamara  <caolanm@redhat.com>  [a3d2d01f55260ad422e07d4f326fc01f0414bd1d]

        gtk4: ToggleButtons can have images too
        
        Change-Id: I1319ed84daa5d0d7d6a49887ad3ccc5b4c2fc3bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116736
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-05  Caolán McNamara  <caolanm@redhat.com>  [ff169611987501baa12a4614656e2049fd133d02]

        gtk4: silence some warnings
        
        Change-Id: Idd19191b6b2e18069d88a35e6cfd2d0f5023affa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116735
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-05  Arnaud Versini  <arnaud.versini@libreoffice.org>  [80255dcde14755bb4a342b7392fb26d27580ff6d]

        vcl unix : use std::thread in PPDParser::getParser
        
        Change-Id: Iff31fbdec6516b490590e31db6915397033c1027
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116413
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2021-06-04  tobias  <tobias.schulz@hotmail.com>  [cb490979ac238011efa27e0fb18fe62c13329d1f]

        tdf#120574 Store Ascii Options for Later Saving
        
        store auto detected/configured ascii options in medium.
        use stored ascii settings for saving and text encoding
        settings dialog.
        
        Change-Id: I88e2d54923bfcf5d7c460ef3b89c36fc002c5097
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116678
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [5bb06ea6931c0c72df6b0f164bac1c8d00c51bb6]

        Fix UITest
        
        The test had previously raced between the effect of
        vnd.sun.star.findbar:FocusToFindbar, typing, and pressing
        the "Find All" button. If typing happened before focusing,
        then focusing selected the already typed text. If button
        was clicked before focusing, it found the edit unfocused,
        and grabbed the focus, selecting its content.
        
        This adds "HasFocus" property to WindowUIObject::get_state.
        
        Change-Id: Ib277bd70508a3c1e86e1668afb7592d7a1523947
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116697
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [fe66c4e2ac43ca0bef04ede7250848dd37c35a45]

        fix leak in solver test
        
        Change-Id: I676b22a59f057a18d44a561f632803283cbe9b6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116720
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [b68be8c7286b3168468414ec0106c610582f9d6f]

        gtk4: undo bootstrapping conditional page removal
        
        now menubutton is available again
        
        Change-Id: If3112cde3e5231245088740ab0217a0e61b3579c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [63f9e6d0f2596e5481e34573664d358fb61b9d9f]

        gtk4: don't want normal case to have a radiobutton
        
        Change-Id: Icbd21ca39856374e1b95e5d34ac0793f24619a46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116732
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [26b4c13a73584e71930549cc0a65eccfdd258a96]

        gtk4: reeenable the rest of the math dialogs
        
        Change-Id: If18f5f0e5b47deefae8c55d296fa5ef3d5f312ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [cf495c580d19bc43ff7860ccc9e84159e0d44edf]

        move unique use of secondary-icon-tooltip-text to tooltip-text
        
        there are no "secondary" or "primary" icons for the tip to be
        relevant to. I imagine this should be for the whole widget.
        
        Change-Id: I6186499a9f981ab910e79970419e7cb5f0f02db5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [b9959364cbdbf8a17d977717522e57187f82730f]

        gtk4: experiment with GtkPicture for all our theme resources
        
        math, format, spacing for an example where GtkPicture is wanted
        writer, format, columns for an example where GtkImage is wanted
        
        Change-Id: Ib7acfc242d93e8b3f23687e7e5483aedd5cc4a45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116727
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [bc8e1acfaddea5f0ea3e607fc4d8f7953795f06c]

        swap orientation of container from vert to hori
        
        we only show one child at a time so this should make no difference in
        theory, and that's the case in gen and gtk3.
        
        But tweak it because in gtk4 right now the height gets strangely
        too tall when vert while its width doesn't when hori.
        
        Change-Id: I6a35385bdfe73eb21f8c72085de3ca7408e0602d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Michael Stahl  <michael.stahl@allotropia.de>  [452bf1359dab3cfab9fd6007d68592e9c96382b3]

        tdf#142483 filter: xhtml: fix substitution of fo:border attribute
        
        This worked with Saxon but not with libxslt.
        
        (regression from 9d3b39cf9fed9a305ac23d1ecaaafc8f7caaeeb0)
        
        Change-Id: I18e66e6136e4fc73718bbe9c7c4c66fb76be31c3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116728
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-04  merttumer  <mert.tumer@collabora.com>  [720438d2c43ee676af9002b92f97d650f45184e7]

        lok: Hide file name from Text Import Dialog (csv)
        
        Change-Id: Id496ce68030a471ac73556f52bcd808d79d34589
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116173
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116302
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [73c37ef7595cde0a9b46681106672170e3eb6ffb]

        lok: Re-Enable AnchorToPara context menu item
        
        Change-Id: I0f1f4121c06b8f628f4fe49284737cea3d28e4b8
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116141
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116301
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [fe634a991bd94f9f1f0f9ef5c401648b8dd85f6c]

        sd: Unit test for Table deletion with Delete Key
        
        Change-Id: I9849f55a143007b49bdcaac392dd84e32d610998
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116069
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116300
        Tested-by: Jenkins

2021-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f52376f167840cee4896f71b17bb8c760c23d5bb]

        loplugin:unusedmethods
        
        Change-Id: I79bd2f0eaa7287f0568366ee5627e11a65d2aec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116717
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [752e23f3cfb161f3eed72f3cd1104310b1b1ddba]

        loplugin:virtualdead
        
        Change-Id: Ic2e18f9088e7427f0679dab27f0d3acb6f2bb240
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116716
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [d0b2e85e87ea47ba80f11a1b3d26a9f8d16f9579]

        resave with latest glade
        
        Change-Id: I9f590dbe91bc69587e0a497eb2c0403c1dd02b3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116725
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [b32582d4bc21953a43c469872d58445ee1a5ff2b]

        gtk4: support radio groups in GtkMenuButton menus
        
        Change-Id: I4e6b61e2c16b208a91490cfbaf5dc933d45c1df0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116718
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Miklos Vajna  <vmiklos@collabora.com>  [04716690f6c5193f15868bc71e7d17c53e085a54]

        sw HTML export: allow custom DPI for the bitmaps of shapes
        
        But leave the CSS pixel size of them unchanged in the HTML markup.
        
        Also add some documentation on the various options, so one doesn't have
        to dig them out from testcases.
        
        Change-Id: I6c6ee4e9c98d674f44e7c5835f2e6a6737e13f34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116722
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ffcf2fa69aa6c79b07b1cf04c8cf6c85c5f6b83]

        uitest: one more fix for File Open dialog
        
        Similar to 4839b7ca3b5a730edf90ebebc749db145efec098
        <Fix UITests that use File Open dialog to load documents>
        
        Change-Id: Ia848ba8129c7e99dc8ea610033e5c22809db7b43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116723
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [2a06d2ebd09ba0c8bf2e29d5c4060ce415964f86]

        Explicitly set ForceFocusAndToFront to false for unit tests
        
        It defaults to true on Windows (see
        officecfg/registry/data/org/openoffice/Office/Common.xcu),
        and may affect UITests, which are interactive there.
        
        Change-Id: Iad51b0a628deced1e90636d07040596a899b53ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116695
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [01ff7460b83da265a0c68fa01cf2282f4e7dd72e]

        Fix UITest
        
        It needs to wait until vnd.sun.star.findbar:FocusToFindbar does its
        magic, which was racing with Python executing its typing.
        
        This adds "SelectedText" property to ComboBoxUIObject::get_state.
        
        Change-Id: I30faab2cc36a3cde59cf72ae5a383738a3ad4738
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116694
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-06-04  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [0d42ca4f39160bdc28a5855261c227c63161dd8a]

        update credits
        
        Change-Id: I46f39d507cc96cbcd0d59b4edfcbb109efefdb69

2021-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4514e65399a1e0398ef94efed6fa1774cff7ea6]

        tdf#142638 crash leaving embedded object (GTK3)
        
        regression from
            commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac
            Date:   Sat May 29 08:34:28 2021 +0200
            IsDisposed->isDisposed in vcl/../window
        
        Change-Id: I9bca182d7d7c4abf4c308bad44c0a3a0bb04a716
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116690
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-04  Miklos Vajna  <vmiklos@collabora.com>  [26d2b19d4e9388072b8dae574efdf00d7f7a0f2f]

        sw HTML export: fix pixel size of shapes
        
        - the twips logic size was set, but it was consumed as mm100 logic size,
          so the pixel size was about half of the correct one
        
        - the HTML export didn't write a logic size ("CSS pixels size") for
          shapes
        
        Change-Id: I37f6b4acde9d1298fae81f9975e9db95485631ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116691
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-04  Mike Kaganski  <mike.kaganski@collabora.com>  [4839b7ca3b5a730edf90ebebc749db145efec098]

        Fix UITests that use File Open dialog to load documents
        
        It relied upon the component being loaded before the next
        Python code line is executed. OTOH, UITest.load_file uses
        EventListener to wait for the OnLoad event, which should
        be reused in all such cases.
        
        This moves the waiting code to a dedicated context manager,
        and modifies UITest.load_file to use it. Respective tests
        using the File dialog also use the new manager to wrap the
        action starting the loading process.
        
        Change-Id: Ic6eb0533b06e0ccc63dffc2ddc0e91d8159cae4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116693
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [191a5bc8bce278d93d8e52d83771fcf59a0fbe9f]

        gtk4: convert GtkMenu into GtkPopoverMenu
        
        and hook it up for GtkMenuButton
        
        Change-Id: I79efe7e25693deb40b59e960abc21807c9269172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116687
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [da8970034d1db518ed2225b7e6046cafb788d26d]

        Fix typo
        
        Change-Id: Ib2045fb0aa2a4ea2556590337ab7de36360c60b1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116689
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-04  Andrea Gelmini  <andrea.gelmini@gelma.net>  [8a850eed3bc1a25731a03e64a734a2d50963ba87]

        Fix typo
        
        Change-Id: I4dcb23dc5773c4ea198d1327f88d931afb1f3483
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116688
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-04  MIhail Balabanov  <m.balabanov@gmail.com>  [b3540898464d8eff745c564a66077f67199223e0]

        Fix the <FollowPageWord> entries for Bulgarian
        
        Change-Id: I349a5a1fc9a93225f6129bd26f0387a3681f08ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113860
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-06-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [2b62ead4dab909438a1d68f879f6f0329ca9291d]

        sc: use XmlTestTools::registerOOXMLNamespaces()
        
        after 1ba1bb1cacdc8825d01559859100a2b575967e55
        <test: introduce XmlTestTools::registerOOXMLNamespaces() to reduce
        copy&paste>
        
        Change-Id: I5f8fcb977233c30bae74e7cc9fde45d41a523b85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116686
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-04  scito  <info@scito.ch>  [c82d96da1c9a03e1742f2f5a7a93b9993c96a0a0]

        tdf#68976 fix paste transposed regression for notes/patterns
        
        Starting position was not correctly taken into account for notes/patterns in the
        initial fix. It worked only for source range starting in A1 (0/0), i.e. a
        special case. The unit tests tested only this special case.
        
        The unit tests are generalized: Starting in B2 instead of A1, i.e. the source
        range was shifted. The paste destination results remain the same, except
        absolute references.
        
        Change-Id: I2f7bfa9e559d99b173ff833fed3cff21658e0e31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116501
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-06-04  scito  <info@scito.ch>  [940dad058c199c6b6990ad313db5a17758a19c65]

        tdf#141683 fix missing flag in multi sel pasted transposed as links
        
        For transpose, the links for option 'as links' will be set during
        TransposeClip(). Thus, formulas will be created. So, the formula flag must be
        set for subsequent copying to the document. This flag must be set in the multi
        range selection code path for transposed as links.
        
        I've adapted the tests. Unfortunately, this fix cannot be tested directly with
        automatic tests. However, the same behavior is applied in the unit tests.
        
        Change-Id: Ia16a8371894a784fc7fcfa1c7b5242f552bef956
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116332
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-06-04  merttumer  <mert.tumer@collabora.com>  [6c879cd2dc4517c8ee9dbff0f228f95702e7f88b]

        Extended MoveShapeHandle command for Anchors as well
        
        Change-Id: I0e2811802f17831097a86103571b505a7557717a
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116040
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116299
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [13f981e262b04f40c377d0e4fff717b57855d8a3]

        Implemented Delete key deletes the table when all the cells are selected
        
        Change-Id: I8a17c73781a3399b214d5655b83036652933a90a
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115689
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116298
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [67277595902dd22c68d9db1f7cf94f53447b237a]

        Unit tests for .uno:MoveShapeHandle command
        
        Change-Id: Ia1049325bf26fbe6a3c8ac77c873d1af010d3581
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115541
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116297
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [19b9da3e1f67611a3ec34cd5a8af508db4c05a4e]

        Enable PdfIum for android build
        
        Change-Id: I58d09db362f0de991eab3920683530e1ec43e2bc
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115373
        Tested-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116296
        Tested-by: Jenkins

2021-06-04  Jean-Pierre Ledure  <jp@ledure.be>  [0dd002a5f1d8c67792dbbc788d3c888d8c000d6c]

        ScriptForge - (scriptforge.py) ThisComponent, ThisDatabaseDocument
        
        Addition to the Basic service for Python scripts
        of 2 Basic builtin objects:
        - ThisComponent
        returning the current component
        - ThisDatabaseDocument
        returning the main Base component when a subcomponent is active
        
        Both are implemented as properties of SF_Basic.
        
        The behaviour can be slightly different versus native Basic when
        the Basic IDE is involved. Read comments in code.
        
        Change-Id: I5d59b0ae0bae026f9b7e4c1d7068e84958aab56d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116674
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [b6e4e3ac36e1b25afd0a2c71a549357b5928a47c]

        gtk4: strip use-popover from GtkMenuButton
        
        Change-Id: Ib9d74ebb69246c2e505d576733b5c34959f9666f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116683
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [c91d5847276394114a534387ca32a99bda36bc28]

        gtk4: add some spacing between elements of menubutton
        
        Change-Id: Ibaf1a46a79a66a26b6552392abb4f052a84483e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116682
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [0579d9c5e5723a0de587a4aac834757041d5eeb0]

        ditch old stop-timer warning which has become visible
        
        Change-Id: Id267a0478712dce097a450fff8a9b2ae0462109e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116681
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Caolán McNamara  <caolanm@redhat.com>  [fa8db25af6218262b3dab2e93b76464975889ceb]

        gtk4 crash on exit
        
        since...
        
        commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
        Date:   Wed Jun 2 13:06:54 2021 +0200
        
            fix shutdown leak in CppunitTest_sw_filters_test
        
        the vclplug .so is dlclosed and the GtkSalData dtor
        subsequently crashes. gtk3 doesn't crash because its not
        dlclosed.
        
        for a simple life add gtk4 to the list here, probably
        moving delete pSVData->mpSalData before the DestroySalInstance
        or making it part of that is the right way to go
        
        Change-Id: I683fdc217cb3486e3e9029817c8d6207f27bcd6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116680
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-04  Miklos Vajna  <vmiklos@collabora.com>  [1ba1bb1cacdc8825d01559859100a2b575967e55]

        test: introduce XmlTestTools::registerOOXMLNamespaces() to reduce copy&paste
        
        sc/ could potentially benefit from this as well, that's not yet done
        here.
        
        Change-Id: I03d0b4afa21a02c74d34aab6e03ab53991df29dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116679
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [fa6e97f08a656a7093f6d9c5ecdb2bdc081b7116]

        fix SAL_WARN_IF check
        
        Change-Id: I434eadb8f7a10406dc8d9fc4d880fd5b2f2f179d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116669
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-04  merttumer  <mert.tumer@collabora.com>  [50b640a298604ecd10ce095a005cd8eaaf82fc14]

        android: Fix DrawingArea inside CsvTableBox is shrinked
        
        Change-Id: Ia722297051eb3413b9db17024173c9eb596d8e7a
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115235
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115276
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [437facda5898b476f6b4a6baaf4c3e22c5eb1e35]

        Add missing FilterOptionsDialog constructor for android
        
        Change-Id: I8bdd44e1b2f45a6d62e6b7220762da62787e04fa
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114830
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116295

2021-06-04  merttumer  <mert.tumer@collabora.com>  [8c26772822e2f768e48be72feb29ec06f00d9cf2]

        lok: Interaction handler for FilterOptions
        
        This will enable Text Import Dialog to be executed
        before the document is loaded
        
        Change-Id: I263e69f0739f4971f4c4eec032ebf22ffbdeebb7
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114638
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116294
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [790f7deb17cede31c780b3e296672bbe7577763c]

        lok: add global notifier to the "Text Import Dialog"
        
        This dialog is displayed before the document is loaded
        so no way to get access to the view shell notifier
        when model/view/controller are not created yet.
        
        Change-Id: Ic9259b0b1d72b2c4f29b7265742136e650c7b67b
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114637
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116293
        Tested-by: Jenkins

2021-06-04  merttumer  <mert.tumer@collabora.com>  [a4b5170eeb134ae5b838f480db1ac5d64dafceac]

        Added Text Import Dialog to JSDialogs list
        
        Change-Id: I8da4c929ebe7b93fe9211ba432ce321e31482a8f
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114636
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116292
        Tested-by: Jenkins

2021-06-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [ed984f8e68996bcbdcf590814c41479ba76907f2]

        indexing: start of Indexing Export impl. based on (X)HTML export
        
        This adds a indexing output/export to HTML code, which will output
        a xml document that will be used for indexing of the document. It
        is based on HTML to reuse the traversal through the doc. model.
        
        It is enabled by setting the "IndexingOutput" export parameter.
        
        This commit only adds in the groundwork, but the output is still
        more or less the same as html and the follow up commits will
        add more indexing specific changes. The only change is to use
        "indexing" as the top level element and the document is a valid
        xml (has the xml header).
        
        Also add basic test that the indexing output/export works and
        can be parsed as an xml with "indexing" top level element.
        
        Change-Id: I153b1a70da7cbcf0d33b8610d962e6b7ae23ad23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116631
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [abcfae0b64e6733b1de469414fe3c73f94f9a39a]

        calc: clean up HTML export - don't use chaining
        
        Change-Id: Ic8daf74dd50572e484c0c7a9ac658ff8eb572e53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116630
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [685c8db519b022f879cf575ec763d00de98906a3]

        HtmlWriter: add end tag checking and helper for attribute writing
        
        Added an input variable to end to enter the name of which variable
        is ending. This is to check that the expected end tag is actually
        written.
        
        Added writeAttribute, which is independent from HtmlWriter and just
        writes the HTML attribute format to the stream.
        
        Change-Id: Ib00a4a37354cd1cb1781ba729ed4046a966e1eb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116629
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [774be6d793203183fe1856ffb8b720f00b48c2bb]

        split .ui conversion code into its own file
        
        Change-Id: Ie27990a497e39ab2fd82a711fa4ec49b472616f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116677
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [4ac6cea4be724ade2e3ab672ff7443af82174ea0]

        gtk4: transform always-show-image into a GtkBox child for the GtkButton
        
        and append a GtkLabel child in the GtkBox and move any existing label
        property into it.
        
        Change-Id: Icb5da08409155894d63adde6eb4ce552c1dd7553
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116676
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [641bfc7a09ea3b11cd9164a597ef52917d11e3a8]

        gtk4: don't call gtk_widget_destroy on a GtkPopover
        
        Change-Id: Ia65218a231796cb128a95f7bfa1a04dfd769f55a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116675
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  László Németh  <nemeth@numbertext.org>  [896c2199d9f0a28bd405dd2d1068f5e2973cdf06]

        tdf#79069 DOCX: support tracked table (row) deletion
        
        Only DOCX round-trip was supported for tracked table and
        table row deletions. Now change tracking of newly
        deleted tables and table rows is exported in DOCX.
        
        Also the DOCX import is handled by Manage Changes now:
        accepting the deleted ranges of a deleted row removes
        also the table row, not only its text content.
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: Ic02e0adbda11032acb9616c262c2fce134f6b07c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116652
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [06a983b213b8fb71fdac1004868d7b4fdd6a9833]

        tdf#142546 broken formulas in .FODT files
        
        regression from
            commit 81fe31d2c8977791f9b90ab1da4fbb1a778f87fb
            Date:   Tue Nov 3 18:25:10 2020 +0200
            use fastparser in XMLEmbeddedObjectImportContext
        
        Change-Id: Ib5bae81001ae97c574c078c979484f016c7d4323
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116664
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-03  Mike Kaganski  <mike.kaganski@collabora.com>  [5ff18d90fda5cda1d06176adac134e6b41f4f393]

        Fix UITest
        
        Don't use "Default" entries in the test - it would break on any system
        with different default locale.
        
        Wait until the change takes place.
        
        Change-Id: Ia3740c65f83c2cbc097a1d86572d381c9d5f8200
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116469
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-06-03  Stanislav Horacek  <stanislav.horacek@gmail.com>  [bbb167de2a3d9396ee94574c63e8a5822cb0c0be]

        Related tdf#126496
        
        rename "page fields" to "filters" in pivot table extended tips
        
        Change-Id: Ic9720377112f267ca3547e84fbe49085eb03fbee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108446
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-03  Miklos Vajna  <vmiklos@collabora.com>  [c8a9396e5695675ffe92935a9ba40354fc76ed79]

        sw XHTML / reqif export: fix PNG export of shapes
        
        image/x-vclgraphic is not something anybody else will understand.
        
        Change-Id: I5a5b37b7f769de351bd3dfc38ccd57381bc43319
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116673
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [988175a5111d214aee6c52be8065b1b79be26497]

        gtk4: get mouse motion events
        
        Change-Id: Ief3f34c6e1ad33201324940557020c9748784e22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116670
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [c567806c23aeaa361662f58c261093950ea40b99]

        sw_rtfexport: use a template for makefiles
        
        in order to remove duplicated code
        
        Change-Id: Ic1e7d331b14f74051ed23bf6c7e64016eca61206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116651
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-03  Stephan Bergmann  <sbergman@redhat.com>  [268f27f6623334b81762b068f842c944a7541f25]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        sLanguage and sTmpStrVal are unused since
        c9611c5e6465948de029e9c2fbd17e75ee07d31f "loplugin:unusedfields in
        l10ntools..sax".  Simplify the for loop now that it only checks for a single
        item, and expand the ID macro at its last remaining use.
        
        Change-Id: I3cf6692fc5a4efd58d0df1dbc24b3610916b2fd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116665
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ac8d986655f5eb9c4b92ba56c779e036485525dd]

        Change 'Background' -> 'Area' in Insert Section dialog
        
        The term background is deprecated in several dialogs, e.g.
        page style, paragraph and paragraph style in Writer and other
        modules.
        
        This patch changes the term 'Background' to 'Area' in the Insert section
        dialog.
        
        Change-Id: I6424517f8e3c6d8d8975c8dc62f905a3508aba55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116580
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [db033fc1d148d55d9678b2915d7589a814e22732]

        fix crash in GtkSalData destructor
        
        which had never been called until....
            commit 556243467a0ac3f647de75bf3fb6c9f3b72466a4
            Date:   Wed Jun 2 13:06:54 2021 +0200
            fix shutdown leak in CppunitTest_sw_filters_test
        
        Can't call Yield at this point in time, the SalInstance is already gone.
        
        Change-Id: Id196d7c2de69121dca447d845ed0aff3d8a7acfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116668
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [8da12900319696519564d4ae3764d063e94901f8]

        gtk4: get basic menubutton popovers working
        
        Change-Id: Id205761521d9eda50bb858d86e7235e273691568
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Mike Kaganski  <mike.kaganski@collabora.com>  [8d98dd8b3896c14af057e90e3a327172a9262e03]

        tdf#142635: skip UITest for now
        
        Change-Id: I84f5c8b2dd3f18456e61e8f9de90371d1a7601e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116467
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [f13efe0199f8a879ba148f3db760fd288407d932]

        gtk4: get menubutton picture aligned nicely
        
        Change-Id: I4df3bfee7256a92e37d6bc887fa21ed74b615a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [e8990b36358cec3ed5123dc3a8468600c184e08d]

        gtk4: align menubutton label to start
        
        Change-Id: I6ea62b3b66ec18d478fcadd132b9b86387c9db48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116658
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [bb2dc32009311ced381695a13111353dae68f8c0]

        gtk4: use a GtkPicture instead of a GtkImage in MenuButtons
        
        because GtkPicture retains the aspect ratio
        
        Change-Id: I8d9383532cacd4711f9452cb8fba0af48d9a3d5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116657
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [e96554b67b17f9d3d91b0bb1f29ab0b9cdc43dcb]

        merge duplicate functions
        
        Change-Id: Icf0633ebfd668d19f5cbba5a07ec24ed5c65decc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116656
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Stephan Bergmann  <sbergman@redhat.com>  [067603dbda470f4333979ad7027458fc22d6d403]

        -Wunused-but-set-{parameter,variable} in CompilerTest_compilerplugins_clang
        
        ...new with Clang trunk 13.  As a rule of thumb, this change adds explicit
        cast-to-void silencing in those .cxx that already contained other such silencing
        casts and adds wholesale #pragma clang diagnostic ignored in all others.
        
        Change-Id: I1884496ee1aa81aaf3c8b3533534a4b69b185e9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116660
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-03  Stephan Bergmann  <sbergman@redhat.com>  [a19062084bcc71ff1690f799a2379fe60bdb8c37]

        -Werror,-Wunused-but-set-variable (Clang 13 trunk)
        
        > unodevtools/source/skeletonmaker/skeletoncommon.cxx(47,13): error: variable 'shortfilename' set but not used [-Werror,-Wunused-but-set-variable]
        >     OString shortfilename(filename);
        >             ^
        
        Change-Id: I18510a5c2d2ceca4eab3ef93c0a32a1bffafac6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116661
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-03  Miklos Vajna  <vmiklos@collabora.com>  [22681004895467fe9bb36c08591eb2ab18481334]

        vcl: fix clang7 build
        
        vcl/backendtest/outputdevice/line.cxx:126:17: error: no viable constructor or deduction guide for deduction of template arguments of 'vector'
        
        Change-Id: I8009637caaba460f9b5ea256f782517e4f1a4be7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116639
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [340a285d925d8bef2b9d1c19f2744dbb14823c77]

        gtk4: GtkMenuButton doesn't inherit from GtkToggleButton anymore
        
        Change-Id: Ia5175502e04d821097c38981e1ea6fabb5673f04
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116655
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [bb0f5c8b50c12488c809640dc2dbc0938fc0e67d]

        gtk4: reenable partial Popover
        
        Change-Id: I51e40842fa2dd614f64cafb12271a41aac8122a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116654
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [b30839cecd25b9f6f56fcf4b3d3e90ab23a3d0b7]

        use std::make_unique instead of new
        
        Change-Id: I267b82dd573fc8bd30e1c5d47e9b1f2e98c2b412
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116645
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [9e6a2a6eb3c959bd9ca3fc3a24ae089489383a69]

        cid#1485165 avoid Missing move assignment operator
        
        Change-Id: I9113e589f74a119fc24e174e7e35036beb0d7acd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116643
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Julien Nabet  <serval2412@yahoo.fr>  [f790fb5172bddba854448799081116aff96f2a42]

        Simplify some initializations in connectivity (2)
        
        Change-Id: Iacbd1ccc58ebe6ef0a434e7334bc393d3457f889
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116638
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [22bae1d412e241870d835c827abd6df5f9ac6ff8]

        fix leak in SwRedlineAcceptDlg
        
        Change-Id: I9d9f02af7708043fbf80eb04dd12ea57cb4aa628
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116653
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [71fe0aeee20640c57816dc45010d32dac9afeaaf]

        ofz#33769 Integer-overflow
        
        Change-Id: I2f158b1f7c3fdaea00c4334cf3889e0f38674e8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116650
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [4d2a8d50ecb2fdf282bbaf3b5f3509e72ca604fc]

        sw_ww8export: use a template for makefiles
        
        in order to remove duplicates code
        
        Change-Id: Ie107d953d2e7ab4624edccd58fd8637349b9e098
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116649
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [254952c15a80f63db0b0f54c79d8e2e9e083a8f3]

        cid#1485166 try and suppress bogus Uninitialized scalar variable
        
        Change-Id: I250bb79534610952cc78bb5ab3fc8ab5862723c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116646
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [d09ba873adb58ca76b02fe852b31b6a8ca9591a4]

        sc: split subsequent modules into smaller parts
        
        Change-Id: Iee175a064714fa1c7b40c1c450c2fffb59f4fd7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116625
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [4bd56577ec4a3da5dae151ff82d957673fc8031d]

        use std::make_unique instead of new
        
        Change-Id: Icc5cb2f5fa5720eb9f6e22ec380397bb88542689
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116644
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Miklos Vajna  <vmiklos@collabora.com>  [027c7b411389127d77a271e53922edb4d7095a2e]

        sw XHTML / reqif export: implement OLE wrapper support for shapes
        
        ExportImagesAsOLE=true was only handled for Writer images, not for Draw
        shapes, fix this.
        
        Change-Id: If5018ff4b7c8b303d63a862f7428aa4e8b77d498
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116641
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-03  Gabriel Masei  <gabriel.masei@1and1.ro>  [71888075c160d97855f35b306bd6eb01a2922d1f]

        vcl: check mpWindowImpl before referencing it
        
        Fixed some cases generating crashes because mpWindowImpl was not checked for nullptr.
        
        Change-Id: I5540f9f21a870b02655b5bf2afdbf3a8153c1519
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116330
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-06-03  MarcoFalke  <falke.marco@gmail.com>  [ae837fc93d326919c5003876186d7bce1dae6bce]

        Avoid timeout in bin/oss-fuzz-build.sh
        
        This may fix https://github.com/google/oss-fuzz/issues/5855
        
        A similar recent fix was https://github.com/google/oss-fuzz/pull/5858
        
        It is assumed that the oss-fuzz builder HDD is too slow, leading to a
        timeout. Fix that by breaking the bash wildcard expansion into a for
        loop.
        
        I did not test this change.
        
        Change-Id: I3db367d604c46b3d15c91f530fb103ca005b0bc0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116642
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Caolán McNamara  <caolanm@redhat.com>  [e33290f3ea2b347683912ff89615ba3ae6298dde]

        ofz#34867 Timeout
        
        Change-Id: Ia07b8b4c41233c0f66239d2f37833ddecc0dd278
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116640
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [e83b5f6a015269ed7e5407a8440c0fc99fcfa397]

        no need to allocate these on the heap
        
        Change-Id: Ic4b16e776a731e5e9bea61e99acb7257c5220322
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116585
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-03  Stephan Bergmann  <sbergman@redhat.com>  [f5e1314ffa564077c27fb9c954c792b498bcae12]

        external/cairo: Fix previous -fsanitize=alignment fix
        
        13f6d80330208eeb45fe9a03bb462941fb4eda2a "external/cairo: Support building with
        ASan/UBSan" had added the src/cairo-image-source.c blob to
        external/cairo/cairo/san.patch.0 to fix
        
        > > cairo-image-source.c:512:10: runtime error: load of misaligned address 0x6180037aee6f for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment
        > during UITest_writer_tests7
        
        I had created that patch attempting to do a faithful emulation of the original
        code (which I had naively assumed to be correct, modulo the alignment issue),
        reading four consecutive bytes and interpreting them as an uint32_t in the
        system's byte order.  I had not noticed back then that all that
        CAIRO_FORMAT_RGB24_888 was added by external/cairo/cairo/cairo-1.10.2.patch,
        introduced with 54596087e57ea533253e19eea594d9b6c06e8d26 "vcl-svp: add 24-bit
        (3-byte) RGB surface support to Cairo".  Its
        
        > + * @CAIRO_FORMAT_RGB24_888: each pixel is a 24-bit quantity,
        > + *   with Red, Green, Blue taking 8-bits each, in that order. (Since 1.1x)
        
        and
        
        > + * Need this until CAIRO_FORMAT_RGB24_888 is in some official release.
        > + * Otherwise we can't reliably check if this is available or we should
        > + * convert from 24-bit RGB to 32-bit RGB before passing to Cairo.
        
        comments make it sound as if this code might come from some official cairo
        upstream branch, but I cannot find anything at git.freedesktop.org/git/cairo.  I
        have no idea about the provenance and quality of that code.
        
        However, I now (a) from the above comments naively assume that the intent of
        CAIRO_FORMAT_RGB24_888 is to store R, G, B in that order in three bytes with
        increasing addresses (i.e., independent of the system's byte order for larger-
        than-byte words); (b) thus consider the original src/cairo-image-source.c code
        in external/cairo/cairo/cairo-1.10.2.patch broken (as it attempts to read all
        three values in one read, in system byte order, which would fail for big
        endian); and (c) thus consider the faithful emulation code in
        external/cairo/cairo/san.patch.0 to be broken, too.
        
        Based on the above, I here fix at least the external/cairo/cairo/san.patch.0
        code (which is applied unconditionally, even for non-ASan/UBSan builds, thus
        always overriding the original external/cairo/cairo/cairo-1.10.2.patch code).
        The following line
        
        >  	pixel &= 0x00ffffff; /* ignore next pixel bits */
        
        should no longer be necessary now, and it is probably better to directly fix the
        original code in external/cairo/cairo/cairo-1.10.2.patch, but I'll leave that
        for a potential follow-up fix, once the provenance and assumed quality of that
        original CAIRO_FORMAT_RGB24_888 code is clarified.
        
        (I came across this code now with a --without-system-cairo ASan/UBSan Linux
        build, where JunitTest_toolkit_unoapi_1 failed with
        
        > ==1060406==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60300146fb48 at pc 0x7fff9b45b338 bp 0x7ffffffef1d0 sp 0x7ffffffef1c8
        > READ of size 1 at 0x60300146fb48 thread T0
        > Detaching from process 1060652
        >  #0 in _pixel_to_solid at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:515:207
        >  #1 in _pixman_image_for_surface at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1309:22
        >  #2 in _pixman_image_for_pattern at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1574:9
        >  #3 in _cairo_image_source_create_for_pattern at workdir/UnpackedTarball/cairo/src/cairo-image-source.c:1619:2
        >  #4 in composite_aligned_boxes at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:678:8
        >  #5 in clip_and_composite_boxes at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:882:11
        >  #6 in _cairo_spans_compositor_mask at workdir/UnpackedTarball/cairo/src/cairo-spans-compositor.c:999:14
        >  #7 in _cairo_compositor_mask at workdir/UnpackedTarball/cairo/src/cairo-compositor.c:106:11
        >  #8 in _cairo_image_surface_mask at workdir/UnpackedTarball/cairo/src/cairo-image-surface.c:952:12
        >  #9 in _cairo_surface_mask at workdir/UnpackedTarball/cairo/src/cairo-surface.c:2247:14
        >  #10 in _cairo_gstate_mask at workdir/UnpackedTarball/cairo/src/cairo-gstate.c:1136:11
        >  #11 in _cairo_default_context_mask at workdir/UnpackedTarball/cairo/src/cairo-default-context.c:993:12
        >  #12 in cairo_mask at workdir/UnpackedTarball/cairo/src/cairo.c:2283:14
        >  #13 in SvpSalGraphics::drawAlphaBitmap(SalTwoRect const&, SalBitmap const&, SalBitmap const&) at vcl/headless/svpgdi.cxx:745:5
        >  #14 in SalGraphics::DrawAlphaBitmap(SalTwoRect const&, SalBitmap const&, SalBitmap const&, OutputDevice const&) at vcl/source/gdi/salgdilayout.cxx:832:16
        >  #15 in OutputDevice::DrawDeviceAlphaBitmap(Bitmap const&, AlphaMask const&, Point const&, Size const&, Point const&, Size const&) at vcl/source/outdev/bitmap.cxx:704:29
        >  #16 in OutputDevice::DrawDeviceBitmap(Point const&, Size const&, Point const&, Size const&, BitmapEx&) at vcl/source/outdev/bitmap.cxx:516:9
        >  #17 in OutputDevice::DrawBitmapEx(Point const&, Size const&, Point const&, Size const&, BitmapEx const&, MetaActionType) at vcl/source/outdev/bitmap.cxx:391:9
        >  #18 in OutputDevice::DrawBitmapEx(Point const&, Size const&, BitmapEx const&) at vcl/source/outdev/bitmap.cxx:292:9
        >  #19 in OutputDevice::DrawTransformedBitmapEx(basegfx::B2DHomMatrix const&, BitmapEx const&, double) at vcl/source/outdev/bitmap.cxx:1315:9
        >  #20 in drawinglayer::processor2d::VclProcessor2D::RenderBitmapPrimitive2D(drawinglayer::primitive2d::BitmapPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:394:21
        >  #21 in drawinglayer::processor2d::VclPixelProcessor2D::processBitmapPrimitive2D(drawinglayer::primitive2d::BitmapPrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:524:5
        >  #22 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:252:13
        >  #23 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25
        >  #24 in drawinglayer::processor2d::VclProcessor2D::RenderTransformPrimitive2D(drawinglayer::primitive2d::TransformPrimitive2D const&) at drawinglayer/source/processor2d/vclprocessor2d.cxx:912:5
        >  #25 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:317:13
        >  #26 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25
        >  #27 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:46:13
        >  #28 in drawinglayer::processor2d::VclPixelProcessor2D::processBasePrimitive2D(drawinglayer::primitive2d::BasePrimitive2D const&) at drawinglayer/source/processor2d/vclpixelprocessor2d.cxx:434:13
        >  #29 in drawinglayer::processor2d::BaseProcessor2D::process(drawinglayer::primitive2d::Primitive2DContainer const&) at drawinglayer/source/processor2d/baseprocessor2d.cxx:69:25
        >  #30 in sdr::contact::ObjectContactOfPageView::DoProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:279:31
        >  #31 in sdr::contact::ObjectContactOfPageView::ProcessDisplay(sdr::contact::DisplayInfo&) at svx/source/sdr/contact/objectcontactofpageview.cxx:116:21
        >  #32 in SdrPageWindow::RedrawAll(sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/sdrpagewindow.cxx:353:28
        >  #33 in SdrPageView::CompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpagv.cxx:239:18
        >  #34 in SdrPaintView::DoCompleteRedraw(SdrPaintWindow&, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:606:21
        >  #35 in SdrPaintView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at svx/source/svdraw/svdpntv.cxx:519:5
        >  #36 in sd::View::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/sdview.cxx:475:17
        >  #37 in sd::DrawView::CompleteRedraw(OutputDevice*, vcl::Region const&, sdr::contact::ViewObjectContactRedirector*) at sd/source/ui/view/drawview.cxx:520:21
        >  #38 in sd::DrawViewShell::Paint(tools::Rectangle const&, sd::Window*) at sd/source/ui/view/drviews5.cxx:420:17
        >  #39 in sd::Window::Paint(OutputDevice&, tools::Rectangle const&) at sd/source/ui/view/sdwindow.cxx:212:22
        >  #40 in PaintHelper::DoPaint(vcl::Region const*) at vcl/source/window/paint.cxx:313:20
        >  #41 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:616:17
        >  #42 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30
        >  #43 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1
        >  #44 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30
        >  #45 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1
        >  #46 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30
        >  #47 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1
        >  #48 in PaintHelper::~PaintHelper() at vcl/source/window/paint.cxx:552:30
        >  #49 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) at vcl/source/window/paint.cxx:622:1
        >  #50 in vcl::Window::PaintImmediately() at vcl/source/window/paint.cxx:1325:24
        >  #51 in vcl::Window::PaintImmediately() at vcl/source/window/paint.cxx:1269:39
        >  #52 in SvImpLBox::MyUserEvent(void*) at vcl/source/treelist/svimpbox.cxx:3063:18
        >  #53 in SvImpLBox::LinkStubMyUserEvent(void*, void*) at vcl/source/treelist/svimpbox.cxx:3057:1
        >  #54 in Link<void*, void>::Call(void*) const at include/tools/link.hxx:111:45
        >  #55 in ImplHandleUserEvent(ImplSVEvent*) at vcl/source/window/winproc.cxx:1991:30
        >  #56 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) at vcl/source/window/winproc.cxx:2561:13
        >  #57 in SalFrame::CallCallback(SalEvent, void const*) const at vcl/inc/salframe.hxx:306:29
        >  #58 in SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx:312:22
        >  #59 in non-virtual thunk to SvpSalInstance::ProcessEvent(SalUserEventList::SalUserEvent) at vcl/headless/svpinst.cxx (instdir/program/libvcllo.so +0xae7a222)
        >  #60 in SalUserEventList::DispatchUserEvents(bool)::$_0::operator()() const at vcl/source/app/salusereventlist.cxx:119:58
        >  #61 in SalUserEventList::DispatchUserEvents(bool) at vcl/source/app/salusereventlist.cxx:120:13
        >  #62 in SvpSalInstance::DoYield(bool, bool) at vcl/headless/svpinst.cxx:461:19
        >  #63 in ImplYield(bool, bool) at vcl/source/app/svapp.cxx:465:48
        >  #64 in Application::Yield() at vcl/source/app/svapp.cxx:532:5
        >  #65 in Application::Execute() at vcl/source/app/svapp.cxx:444:9
        >  #66 in desktop::Desktop::Main() at desktop/source/app/app.cxx:1587:13
        >  #67 in ImplSVMain() at vcl/source/app/svmain.cxx:198:35
        >  #68 in SVMain() at vcl/source/app/svmain.cxx:230:12
        >  #69 in soffice_main at desktop/source/app/sofficemain.cxx:98:12
        >  #70 in sal_main at desktop/source/app/main.c:49:15
        >  #71 in main at desktop/source/app/main.c:47:1
        >  #72 in __libc_start_main at /usr/src/debug/glibc-2.33-8.fc34.x86_64/csu/../csu/libc-start.c:332:16
        >  #73 in _start at <null> (instdir/program/soffice.bin +0x251acd)
        >
        > 0x60300146fb48 is located 0 bytes to the right of 24-byte region [0x60300146fb30,0x60300146fb48)
        > allocated by thread T0 here:
        >  #0 in operator new[](unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:102:3
        >  #1 in ImplCreateDIB(Size const&, vcl::PixelFormat, BitmapPalette const&) at vcl/headless/svpbmp.cxx:126:24
        >  #2 in SvpSalBitmap::Create(Size const&, vcl::PixelFormat, BitmapPalette const&) at vcl/headless/svpbmp.cxx:156:13
        >  #3 in Bitmap::Bitmap(Size const&, vcl::PixelFormat, BitmapPalette const*) at vcl/source/bitmap/bitmap.cxx:135:15
        >  #4 in Bitmap::Crop(tools::Rectangle const&) at vcl/source/bitmap/bitmap.cxx:489:20
        >  #5 in BitmapEx::Crop(tools::Rectangle const&) at vcl/source/bitmap/BitmapEx.cxx:360:25
        >  #6 in drawinglayer::primitive2d::DiscreteShadow::getLeft() const at drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx:148:61
        >  #7 in drawinglayer::primitive2d::DiscreteShadowPrimitive2D::create2DDecomposition(drawinglayer::primitive2d::Primitive2DContainer&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx:251:72
        >  #8 in drawinglayer::primitive2d::BufferedDecompositionPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/baseprimitive2d.cxx:122:9
        >  #9 in drawinglayer::primitive2d::DiscreteMetricDependentPrimitive2D::get2DDecomposition(drawinglayer::primitive2d::Primitive2DDecompositionVisitor&, drawinglayer::geometry::ViewInformation2D const&) const at drawinglayer/source/primitive2d/primitivetools2d.cxx:48:47
        
        trying to read the fourth byte of a presumed uint32_t starting at offset 21 of a
        24-byte buffer.)
        
        Change-Id: Ibe8bc39e3736c64ace61af2217100c9d8bb96d5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116637
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-03  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [91c23f55bb795156c2ea3b2c4458e70758a425c4]

        sw: rename some variable/method names in html import/export
        
        Rename to "default" instead of "dflt", "start" instead of "stt",
        "content" instead of "cnt",....
        
        The shorter names are a product of utter laziness.
        
        Change-Id: I5f5c8f6504e788395db495c000c098401767f8a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116628
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-06-03  Julien Nabet  <serval2412@yahoo.fr>  [23390e3096c2db2526cbc0867e3b2063e06f6150]

        Revert "Initialize vector directly with the already known count number"
        
        This reverts commit da9fe0da11687bfc4c0eff2197286da67d6206c2.
        
        Reason for revert: wrong result since there'll be first 4 by default initializations then an extra reserve allocation.
        
        Change-Id: If480243e81db405d6a984b8450a219e486f1a1ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116465
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-06-03  Miklos Vajna  <vmiklos@collabora.com>  [c6595e781cf20ab2825e9a2bd8592688f26448e3]

        svx: remove pdfium dependency
        
        This is no longer needed, we only call VCL functions in svx/ today.
        
        Change-Id: I741ed9bc4c66067ea423211b8f16305b0e4099fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116622
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-02  Julien Nabet  <serval2412@yahoo.fr>  [da9fe0da11687bfc4c0eff2197286da67d6206c2]

        Initialize vector directly with the already known count number
        
        instead of initializing an empty vector then reserve a fixed value
        
        Change-Id: Iccddda05b3dd98aa9c25a61637ece7af4d42d72f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116624
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [a24be9600c1b305b00d177a8f9bc777719cc1fd8]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 29eb2930309a484a6090c474353f99a2c01d1703
          - Czech Hunspell: remove confusing surname
            
            Change-Id: I5ac78be61cacdf05dd804240355ea828de722f24
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116626
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ce12fc66f533c39c07a23e65eeebc9d1fd0a4610]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 412f5dd223df85956dc38f429733e7972d496391
          - Czech Hunspell: remove rule based on circumfix and make other updates
            
            the rule does not produce correctly capitalized results
            minor updates of word list
            all changes suggested by Miroslav Pošta
            
            Change-Id: I1ecfd7ea6daaf155228bd2405708fb097fa07997
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116281
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [9c108bef17e003f4abf46076e045b38cc5dea7fb]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 5ae65ee9e7f1dac860be57901c62d97d887a9564
          - Czech Hunspell: use KEY and update TRY in .aff file
            
            for TRY character frequencies were employed
            
            Change-Id: I46a1680c10dd49af2f15984bafe686ff69757071
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116280
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [f49fe6e3a65835bae06cba23da6881ff9fd3f52d]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 27e7425c295cb84a18e4d0d2711ef4f96ee7551f
          - Czech Hunspell: remove duplicates
            
            Change-Id: I90ca35378ad60768d6636193462fa307e9ac91a4
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116279
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [ceeaec98dfe5ed4187343ec12f789f8dc0ed33da]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to ab4b942707da889d30cea157838ba90fb114e5f5
          - more updates of Czech Hunspell
            
            done also by Miroslav Pošta
            
            Change-Id: Ie08fb39f7252d1473bd27c55f90c1d765d1abf8e
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116278
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Stanislav Horacek  <stanislav.horacek@gmail.com>  [025a9be2fef04cfb2ebfa3c18b3bf4392f76add4]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to cd451382d714a202638fcb9f0687d6d1b52a212d
          - update Czech Hunspell files
            
            both word list and affixes improved significantly by Miroslav Pošta
            details added to readme
            this version corresponds with the version published
            at translatoblog.cz
            
            Change-Id: Ie9c137c3c652a29648177ed0d88a918acb2bbad8
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116277
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [1afbc98428f7f8cb93a269eeaacc20fc0fa22b96]

        gtk4: get fancy blue "suggested-action" button for Print in print dialog
        
        Change-Id: I60edccc6bb1a5cbbb615ad7be221158ee243f37b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116623
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [4390f2330cb3da79530d544807eca330d89bf0c0]

        Re-enable part of testTdf108963 on Windows
        
        This partially reverts a2c665e4dd73007fe7f0eda2de31db8b768f1df9,
        the expectation is that following pdfium updates have fixed the
        problem that caused failures workarounded by that commit.
        
        Change-Id: Ia2633f966f77c1e9e51f2f8595d7ca62bae78dec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116464
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [f9e87fa1330d15e83d730665e7a4f6701a969ae4]

        gtk4: supplement GtkEntry width-chars with additional max-width-chars
        
        Change-Id: I69b51be8d565636618ab8fb9fd254adb3b4def10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116621
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [cf97d730d60eb3c26adc4e060050e4ba402417f6]

        gtk4: adjust print dialog to position page navigation buttons as wanted
        
        Change-Id: Ifbd69faa0e69831ad93a2393234e2d97bdd6f4e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116620
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [efdce9e2ac63503ed448565827f499c46a1b2082]

        add explicit expands
        
        Change-Id: Ic62c05487bd77831b1a15e8601c6ba5bb1c7e001
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116619
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [556243467a0ac3f647de75bf3fb6c9f3b72466a4]

        fix shutdown leak in CppunitTest_sw_filters_test
        
        of GenericUnixSalData
        
        Change-Id: I4201d617fa4618fc0be58dcf4d1279e0b60e2dcf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116582
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Eike Rathke  <erack@redhat.com>  [b9aefcb99c9be0530856d1e4139ccc96d71fa5b9]

        Merging an unsupported formula grammar is worth a real assert()
        
        Change-Id: I9bce5bc590e3348d1fb0c81a9ec74cec2944d38a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116617
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-02  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [ff53b249885d788fa0539a0f7d5a9879d031d2ee]

        WMF: add more SAL warnings in case record was not implemented
        
        Change-Id: I1d58c4093817403caa5f1112b5d4d5a4e638b799
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116618
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-02  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [3afac9467936fb3a5ae314878686c0f66ee7784f]

        fix: extend the primitive dump, with information about line cap and joint
        
        Change-Id: I5c67d360236ec67c41bc45a9018f0ff0d0ec1d3d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116611
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [e3c2da6d4ba774d7eb1463103969b21fbf4243c6]

        gtk4: reenable cluster of working printing related dialog
        
        Change-Id: I8f6b2403475ada04432f4f6e27fcf537e116033c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116616
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [6a8e7beef4f75e348536f971254fd4fd23c1806e]

        uniformly remove label-fill from GtkExpanders
        
        Change-Id: Ife68cef7eeab0010c4d233c81e3bee808c2c1c28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116615
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [64f7cda6e66de8e2e9af3c5f69fd13126681291c]

        only one of the group should be active
        
        Change-Id: Ibbd8d5e3a1ca78c632997e1372eb0c88ff0cd954
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116614
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [a31108871047a3815c5156b8eca2734dd0f54c64]

        we always pack help button as secondary
        
        Change-Id: Ib16661ea9d5f28bc4855b7b8b34f620a64c33475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116613
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [93cb07910f8f97ca5ae32f48eeec3906f71461e4]

        resave with latest glade
        
        Change-Id: Ia623b9bd51aad6772f3c109eb22e8388c5ca1cfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116612
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [6783afe24d43a1bfd0b0239d3ebb97046177111d]

        no need to allocate these on the heap
        
        Change-Id: Ie11353c8711e970cc20059227d8283c79e4b126d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116586
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d9bf9eea5803184da8e5e11477b6eb2f55aff3f]

        no need to allocate these on the heap
        
        Change-Id: Ie7b8a5ee280da5dfcb15d217a4daccaf485cfbe1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116588
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [3a9436ef7786a6b96bf73328795029a047abe827]

        gtk[3|4] sort close like cancel
        
        and tweak gtk4 Headerbar rules to put close on the left if there is
        some other buttons (ignoring help) that will occupy the right
        
        Change-Id: I54923a85dfb081e38d66c8f3e2686505ca522b9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116610
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [ceaa9a36a1073167819ffff55fba4a990556387c]

        resave with latest glade
        
        Change-Id: Ia69d4feb059ece2068d0229887749e258bcacf70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116608
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [3f01481e1fb79a1148e375bd19db7ab0b6d484c0]

        gtk4: we want to give parentless widgets a parent
        
        Its unknown why I didn't use gtk_widget_get_parent in the first place
        but lets leave it alone for the gtk3 case
        
        Change-Id: I71f933753983ecb0d702975d6822f0ba265d4622
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116599
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [4d85cc9e067ddab5c9014e5d4f1cb022b2c76238]

        gtk4: add some more working dialogs
        
        Change-Id: I6cf7c7aff816f0206c330db408ff6881cc57bffe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116598
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [1213e59401b696cad862745cdefd2963b41af166]

        gtk4: add SolarMutexGuard to focus handlers
        
        Change-Id: I0dee71c310a44701d041b3677e9a3e1aa180f4b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116597
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [f7e88346115111112981466f46a533e7aee5f6ff]

        gtk4: GtkExpander label-fill was removed
        
        Change-Id: I8f14df63d80b650583f9389355c0dcd455a5061d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116596
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [9f940e28eb75559595f6b4fc5d1b7d21faba6e81]

        gtk4: reenable some more working dialogs
        
        Change-Id: I9ab46c8cb1557ba5327dcb5bb8e744a9f894bdf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116595
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [21c87b0dfa9b8f672af9f7ca2b012ba211956c5c]

        tdf#142609 Assign shortcut key to Calc Autofilter command
        
        Same as in Excel for compatibility
        
        Change-Id: I792d61e12339bba1d082049478fa752d1a558b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116561
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-02  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [78dd457b778428c1c65820c7c3d06634da0ac9ef]

        tdf#115282 Add KEY_QUOTELEFT entries to the Shortcut keys list
        
        Change-Id: Id9667a8191c3ccaaad5b1a2f72f0a1f57721bec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116563
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-06-02  Muhammet Kara  <muhammet.kara@collabora.com>  [487dbbb69bfcf7c0368e9dc17e5aae1f17f8187f]

        tdf#116491: Customize: Add indication for experimental commands
        
        Change-Id: Id485f86598aa89cbce6d742c0207c178e5208ee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116014
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [89c01a87d55596f9c3b3c1ccabf7ef307edd9436]

        gtk4: add in the rest of the working autocorrect pages
        
        Change-Id: I9e3841b5bc84d55e80aa2c8286b789af5a460e7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116592
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ef0d150675687469ca85de62b67e34c1e3daa176]

        s/irc.freenode.net/irc.libera.chat/ in README.md
        
        see also https://tdf.io/ircmigration
        
        Change-Id: I468f450649b352489b9651ebbb34f04eddb87af9

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [71b704d6809166b56804b8dc843431215af0490b]

        gtk4: replace 'help' button text with a 'help-browser' icon
        
        seems to fit the aesthetic a bit better
        
        Change-Id: I689eb3d8928bff1531758d3ab0e3e62ebb8a37d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116589
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [0993bb4af8cdd7b032cc924e1f36e592e185291f]

        gtk4: remove unneeded ifdefs
        
        get "Reset" in properties dialog working as expected again
        
        Change-Id: If21edc04f71aa805c6019b35cae65e240c1bca96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116587
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [4b22d3ad90fbade4467337d8157abe19899618b3]

        gtk4: make an effort at better button ordering
        
        Change-Id: Ie11dbdb7a1d723c850af2622b49519833d7302a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116584
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [a5eba5fef0b6eade2c0a39f8e8fc90bdeb08dff2]

        Make optional use of SetThreadDescription in osl_setThreadName
        
        ... so that thread name could appear in crash dumps, and be
        potentially available for logging on Windows 10 version 1607
        and later.
        
        Change-Id: I176ca1fce57e0532a226f85836b3889a8ffb2984
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116462
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [f1be88688cf1ca4ab14f93ae1a75e0331a6577cb]

        Revert "sb138: #i115619# fix for MinGW"
        
        This reverts commit 6727dc5d9414e77975b9fd765993c6e207f872f3.
        We now don't support compiling using MinGW.
        
        Change-Id: I0dee00780bfb4b7deceddd8cd30af03b7f7ed212
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116591
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-02  Gizem Ozgun  <gizemozguun@gmail.com>  [c10df6edb8a48b4a57f73ccb6155d051a8cfb5d0]

        tdf#113646 Add missing test for exporting conditional format font size.
        
        Change-Id: I46b5ccd032fbf292c6e4dd19ec8a6a153b6c892e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116571
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [e4e24a2f996989c3e7969aab71a9db78f1b41889]

        accept help-browser-symbolic as well as help-browser
        
        Change-Id: I8024410b1d259cc12e0fa25a009a51589640835e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116583
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Miklos Vajna  <vmiklos@collabora.com>  [e76471c5ce725dae9abb6f78b7674c6f77df34f4]

        sw XHTML / reqif export: export non-PNG graphic shapes directly
        
        But non-PNG needs a PNG fallback, add logic similar to how we already
        handle this in the Writer image case.
        
        Change-Id: Id853a7072878cada4a6e1e9367443f869028aa1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116581
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [08b7529f628eda1d209cf27f9bbe52ee336fef62]

        gtk3: workaround missing gdk_threads_enter calls in external code
        
        with gtk3 file dialog. file, open, +other locations,
        type davs://somewhere + return
        
         #0  0x00007ffff7a6e2a2 in raise () at /lib64/libc.so.6
         #1  0x00007ffff7a578a4 in abort () at /lib64/libc.so.6
         #2  0x00007ffff7a57789 in _nl_load_domain.cold () at /lib64/libc.so.6
         #3  0x00007ffff7a66a16 in  () at /lib64/libc.so.6
         #4  0x00007fffd9be7672 in GtkYieldMutex::ThreadsLeave() (this=0x513480) at vcl/unx/gtk3/gtkinst.cxx:354
         #5  0x00007fffd9be6a53 in GdkThreadsLeave() () at vcl/unx/gtk3/gtkinst.cxx:116
         #6  0x00007fffd947ac2d in gtk_dialog_run (dialog=0xa984310) at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkdialog.c:1397
         ^^^ this also (see #30) calls gdk_threads_leave before g_main_loop_run, but no gdk_threads_enter has been called, presumably emit_show_error_message should have called it (?) ^^^
         #7  0x00007fffd94a6dc6 in error_message_with_parent (detail=0xa97f9b0 "HTTP Error: Error resolving “nowhere”: Name or service not known", msg=<optimized out>, parent=<optimized out>)
             at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkfilechooserwidget.c:763
         #8  error_message (impl=<optimized out>, msg=<optimized out>, detail=0xa97f9b0 "HTTP Error: Error resolving “nowhere”: Name or service not known") at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkfilechooserwidget.c:786
         #9  0x00007fffe996ec2f in g_closure_invoke () at /lib64/libgobject-2.0.so.0
         #10 0x00007fffe998aea6 in signal_emit_unlocked_R () at /lib64/libgobject-2.0.so.0
         #11 0x00007fffe998c76a in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0
         #12 0x00007fffe998c983 in g_signal_emit () at /lib64/libgobject-2.0.so.0
         #13 0x00007fffd9561fc7 in emit_show_error_message (secondary_message=0x7fffbc0566f0 "HTTP Error: Error resolving “nowhere”: Name or service not known", primary_message=<optimized out>, view=0x900a240)
             at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkplacesview.c:171
         #14 server_mount_ready_cb (source_file=0x7fffbc05b4c0, res=<optimized out>, user_data=0x900a240) at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkplacesview.c:1232
         #15 0x00007fffe9a64a7a in g_task_return_now () at /lib64/libgio-2.0.so.0
         #16 0x00007fffe9a64c7b in g_task_return () at /lib64/libgio-2.0.so.0
         #17 0x00007fffd80653b8 in mount_reply () at /usr/lib64/gio/modules/libgvfsdbus.so
         #18 0x00007fffe9a64a7a in g_task_return_now () at /lib64/libgio-2.0.so.0
         #19 0x00007fffe9a64c7b in g_task_return () at /lib64/libgio-2.0.so.0
         #20 0x00007fffe9acd2dd in reply_cb () at /lib64/libgio-2.0.so.0
         #21 0x00007fffe9a64a7a in g_task_return_now () at /lib64/libgio-2.0.so.0
         #22 0x00007fffe9a64c7b in g_task_return () at /lib64/libgio-2.0.so.0
         #23 0x00007fffe9ac4c34 in g_dbus_connection_call_done () at /lib64/libgio-2.0.so.0
         #24 0x00007fffe9a64a7a in g_task_return_now () at /lib64/libgio-2.0.so.0
         #25 0x00007fffe9a64abd in complete_in_idle_cb () at /lib64/libgio-2.0.so.0
         #26 0x00007fffe987074b in g_idle_dispatch () at /lib64/libglib-2.0.so.0
         #27 0x00007fffe98744cf in g_main_context_dispatch () at /lib64/libglib-2.0.so.0
         #28 0x00007fffe98c84e8 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0
         #29 0x00007fffe9873a93 in g_main_loop_run () at /lib64/libglib-2.0.so.0
         #30 0x00007fffd947ac37 in gtk_dialog_run (dialog=0x1604460) at /usr/src/debug/gtk3-3.24.29-1.fc34.x86_64/gtk/gtkdialog.c:1398
         ^^^ this will call gdk_threads_leave before g_main_loop_run, (gdk_threads_enter has been called earlier, and gdk_threads_enter will be called after g_main_loop_run) ^^^
         #31 0x00007fffd9bdbd96 in RunDialog::run() (this=0x9134f00) at vcl/unx/gtk3/fpicker/SalGtkPicker.cxx:199
         #32 0x00007fffd9bbf23f in SalGtkFilePicker::execute() (this=0x9004690) at vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx:953
         #33 0x00007ffff474741a in sfx2::FileDialogHelper_Impl::implDoExecute() (this=0x1667470) at sfx2/source/dialog/filedlghelper.cxx:1279
        
         #14 presumably server_mount_ready_cb of gtkplacesview.c should protect its gtk
             calls with gdk_threads_enter/gdk_threads_leave like enclosing_volume_mount_cb
             of gtkfilesystem.c does.
        
        Seeing as gdk_threads_leave/gdk_threads_enter is gone in gtk4 I doubt
        there's any point looking for a fix in gtk3 and we should just try and
        survive the problem.
        
        Change-Id: I007be4dee4f615d4431e27034dcf7f3d446c3e9a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116559
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [6dc3db49265ba087f45f06d8baa85251ff0348e0]

        make this warning fire less often
        
        Change-Id: Ie7eb634ce75b8156fae02f48429deca6d63c0251
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [54bd274fe66cdc11cac1dd9f767579f065787cd5]

        fix message
        
        Change-Id: I537d32f01da3ad33be0f021917d9dea67c083b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116577
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [46a662ea56db5b466b15004a6e68148561d4a649]

        improve exception message
        
        Change-Id: I8ce4e6afff2dd7b029c7e557739a3c3e0b361c98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116578
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [f421c3fa72d85f484f136264917e8d482339150e]

        this is not worth warning about
        
        calling code seems to think it's quite fine to do, and is
        happy with a nullptr return
        
        Change-Id: Ia003364ad91a56f2f80ada3076a69d79b30e9c35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116573
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [0806a753c7cb35507f5a76004515eb9031c49725]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to fae02ffb2a2372e00ea776e22966f0cbacbd4497
          - Fix some texts, incl. Lionel’s proposal for tdf#132720
            
            Change-Id: I2c28331ab2077b9d8585b4571d836b46e41eb454
            
2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [de82849f2475b7626df19c0d29758d95388af1b2]

        ofz#34847 Integer-overflow
        
        Change-Id: I45e27efbceff76456f6c22a256a5fce1310272c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116567
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [168c1df143ac493d554ea4c2bff5314b67581b51]

        SAL_WARN -> SAL_INFO
        
        Change-Id: Id3402c4413589b5e82f5754810716a2a171ef6f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116570
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [8771f48512ed19197c17506f522578f43b092b21]

        quieten down this warning
        
        Change-Id: I92c27cd332e20aa4c7bc208b85b571e99668e6dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4cf357a2e5d6506e4f9ff8d03edb53b699967f6]

        SAL_WARN -> SAL_INFO
        
        Change-Id: Iec6d2db5eee35c2973e366153217063e902d1475
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116569
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-02  Miklos Vajna  <vmiklos@collabora.com>  [4da0de52bbd9a2f53ce0e838f7b22c228e510f97]

        sw XHTML / reqif export: export PNG shapes directly
        
        The old markup was:
        
        <object data="draw-png_xhtml_89305eb5d44b6428.gif">
        
        The new markup is:
        
        <object data="draw-png_xhtml_89305eb5d44b6428.png" type="image/png">
        
        Which now passes the validator.
        
        Change-Id: Ibcdac7aeef0e39c926176bf8852cffe17a137fa2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116565
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [edfd864ab45c029bb590ab34c711cd269e140f09]

        make --enable-gtk4 work again
        
        missing $ for test_gtk4 in...
        
        commit 3d1f28dd1fbb2fe3f5b933a9d692fb4d033f08b6
        Date:   Sun May 30 18:19:40 2021 +0200
        
            configure: Refactor platform defaults
        
        Change-Id: I8f08ab5945fbd98e2ff9eeede83bfad324b1c44a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116558
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-02  Mike Kaganski  <mike.kaganski@collabora.com>  [559fe86c12065fc697e36cacb7074d46e46c1e3d]

        Use CPPUNIT_ASSERT_DOUBLES_EQUAL, which fits the task
        
        Change-Id: Ifbb49ea89ecd9c07b02df6aa2fb3b3f7e98b79af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116460
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-02  Julien Nabet  <serval2412@yahoo.fr>  [7e9c3569f9258877b5303f041283d4882d1290fe]

        tdf#92917: fix crash in Impress in viewmediashape (slideshow)
        
        See bt here:
        https://bugs.documentfoundation.org/attachment.cgi?id=172527
        
        I thought about this patch comparing with OGLTransitionerImpl::initWindowFromSlideShowView in:
        slideshow/source/engine/opengl/TransitionerImpl.cxx
        
        304     /// take the XSlideShowView and extract the parent window from it. see viewmediashape.cxx
        305     uno::Reference< rendering::XCanvas > xCanvas(mxView->getCanvas(), uno::UNO_QUERY_THROW);
        306     uno::Sequence< uno::Any > aDeviceParams;
        307     ::canvas::tools::getDeviceInfo( xCanvas, aDeviceParams );
        ...
        317     OutputDevice* pDevice = reinterpret_cast<OutputDevice*>(aVal);
        318     vcl::Window* pWindow = pDevice ? pDevice->GetOwnerWindow() : nullptr;
        
        Change-Id: I183cc8271f75fb145c27688c5594805792c1fdaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116551
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-02  Caolán McNamara  <caolanm@redhat.com>  [a3a203b7c697a38d4f79877d6b5c1423fa52f2d8]

        enabling gtk vclplugs is supposed to enforce requiring system cairo
        
        dropped by...
        
        commit 3d1f28dd1fbb2fe3f5b933a9d692fb4d033f08b6
        Date:   Sun May 30 18:19:40 2021 +0200
        
            configure: Refactor platform defaults
        
        so cairo and pixman get downloaded and built out of the box with --enable-gtk3
        
        Change-Id: I5f0b05ccaca008b9a36c6456811c9e105f13e334
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116550
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-02  Miklos Vajna  <vmiklos@collabora.com>  [566370dc3754ed3f858f1617e776ec0bc3399499]

        sw: rework to avoid the DECLARE_OOXMLIMPORT_TEST macro
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I60c819f4e3ca511a109afaf4c22bf2ece8aa2cf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116553
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-02  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [a153dcefae06b2592803e1449c6db2a58e0765ce]

        Sifr: Update extra large paste icons
        
        Change-Id: I858e8d80f96fe29dc1eff10b91cc22b9748bbec3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116545
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-06-02  Eike Rathke  <erack@redhat.com>  [0b4f7f5c8579cedb48c2ea56fced795b80d454fd]

        Fix tinderbox, remove Sesotho {st-LS} from solenv/inc/langlist.mk
        
        This just lead to
        '/tinderbox/buildslave/source/libo-master/translations/source/st-LS/readlicense_oo/docs.po',
        needed by
        '/tinderbox/buildslave/build/workdir/CustomTarget/readlicense_oo/readme/readme.xrm'.
        
        Change-Id: I197cbade4aa8fe1e7f42cc073443f7c430b78e49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116564
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-01  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [82bde77366e8d92a791ca629df02026bfa5efe21]

        tdf#142566 EMF Add support for EMR_POLYTEXTOUT records
        
        With this implementation the support for EMF records:
        EMR_POLYTEXTOUTA and EMR_POLYTEXTOUTW were added.
        
        Change-Id: I39580d051ae73bed88e04a34d97b797b6d468dc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116556
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [5c76a19342f06615f5722a558556fc7b760f7174]

        This intermediate variable is redundant
        
        Change-Id: I856aab424bd4378d8c115e36971fd76fe7a7feed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116458
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [eebd84b337506c8fff151493f9b51bd127dbc89f]

        loplugin:stringview (clang-cl)
        
        Change-Id: Id1f8f24fec638efcdf5a04ca7253e6f401afd2fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116548
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [1193c331945481dd155a55c6695ff6fd88bd3d10]

        cairo: just register and use external fontconfig
        
        Except for the pixman include, the ANDROID cairo external is the
        same then the other OS use. It also builds fontconfig, so there
        is really no need to depend on the source (ok, this way it can
        be a bit more parallel, if nothing is generated). But the build
        nevertheless always sets includes for fontconfig anyway. And the
        code implied you can build Android without --disable-dynloading.
        
        Change-Id: I9970dc5c052b6fa80588233244c6828079d8277e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116554
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [017bc462b0af467ca89653266674302a9821db5e]

        cairo: Drop config for WNT and MACOSX build
        
        It's not used on these platforms since a long time.
        
        Change-Id: Idac41f1be0a546fd8aa0dd88709ebfa3255a104e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116555
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [b3a56273a388c44d0fcf0aff0d06b5414f2e3397]

        xmlsec: rename xmlsignaturehelper2 files
        
        Change-Id: I1fe7b2f3e265f05c795689bf4e98e7005ef42cfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116557
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-01  Eike Rathke  <erack@redhat.com>  [75458bfab180a57597e674d38e2953c440cf118d]

        Add Sesotho {st-LS} 0x8030 to language list
        
        Change-Id: Ifb304fb1a5ed05e79bcaaaf96e12171377973222
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116552
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [c3858276077d5b1941d2645919c2a6e583c6052a]

        flatten function a little
        
        Change-Id: Iae4d7cbb3722716d18f50e6b0979cdf5fea9fd45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [ffc6d564b91692cd9d99a0eb3b1ceaf54f7db89e]

        configure: Refactor disabling DB drivers
        
        Disabling the DB connectivity is incomplete. We can't generally
        disable it for the cross-toolset, because svx / gengal then fails
        to build. But at least we can always disable most DB drivers in
        these cases and just use --disable-database-connectivity in the
        cross-toolset when building without galleries (which also gives
        this flag some testing with the Android cross-toolset).
        
        This also moves the DB modules in the registry generation target
        into a common DBCONNECTIVITY block, to prevent build failures.
        
        Change-Id: Ib98e1e8918cccc3caf9bc04185bac533509329a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116511
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [7cdf74b305be14825c615b2abe6ab8d79fe858ff]

        gtk4: don't abuse gtk_widget_unparent to remove from container
        
        as seen by assert on closing address template dialog
        
        Change-Id: I6d05d2d162e8e53f740ea7dc4f16879da35293ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116538
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Ilmari Lauhakangas  <ilmari.lauhakangas@libreoffice.org>  [1add28ba7eed357e47394bfe31f08b25e7fae01d]

        logerrit: drop some subcommands in favour of Gerrit defaults
        
        submit-wip and submit-private don't really add value
        
        Change-Id: I4e30b213f5d6317538aad73fcb68e14e7cbb5032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116198
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [fca96bf4b21ca47a98a2bd0114f7c22935acc54b]

        loplugin:noexceptmove
        
        (not sure exactly why this started to only hit me now on macOS against LLVM 13
        trunk libc++)
        
        Change-Id: Ib2ea5b52061a870a5eaa4e5c680d19b87831b87c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116536
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [c275617a9d547e13def33e3d06068c08bf492f78]

        Avoid -Werror,-Wdeprecated-copy
        
        ...at least on macOS against LLVM 13 trunk libc++,
        
        > In file included from ~/lo/core/editeng/source/rtf/svxrtf.cxx:35:
        > ~/lo/core/include/editeng/svxrtf.hxx:66:5: error: definition of implicit copy assignment operator for 'EditPosition' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
        >     EditPosition(const EditPosition &) = default;
        >     ^
        > ~/llvm/inst/bin/../include/c++/v1/optional:790:27: note: in implicit copy assignment operator for 'EditPosition' first required here
        >             this->__get() = _VSTD::forward<_Up>(__v);
        >                           ^
        > ~/lo/core/editeng/source/rtf/svxrtf.cxx:86:22: note: in instantiation of function template specialization 'std::optional<EditPosition>::operator=<const EditPosition &, void>' requested here
        >     mxInsertPosition = rNew;
        >                      ^
        
        21ad3e6cbdf9568c1152a2eab8178e4219e40c33 "EditPosition does not need to be
        allocated separately" had introduced the defaulted copy ctor, for no apparent
        reason.
        
        Change-Id: If61743c4e873a5ac95ba72a4ae24160f8713205f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116535
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Miklos Vajna  <vmiklos@collabora.com>  [3fe661041aadbfd945a20afe2310a19f5e76976e]

        sw XHTML / reqif export: write PNG fallback for non-PNG images
        
        - split up OutHTML_Image, so it's possible to write
        
        <object type="image/jpeg">
            <object type="image/png"/>
        </object>
        
        - write PNG inside the original image
        
        - disable this when the original format is PNG already
        
        Change-Id: I3ad40089ee2b02b8850823dd536c58ac59af37f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116544
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-06-01  Julien Nabet  <serval2412@yahoo.fr>  [e45575443ca5e4b6683e81e1c2e8e4a543b506fb]

        Reduce scope (slideshow/viewmediashape)
        
        Change-Id: I3190aa77c5a13c6a6d1cf484b63916784954ea87
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116533
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-01  Jan-Marek Glogowski  <glogow@fbihome.de>  [3d1f28dd1fbb2fe3f5b933a9d692fb4d033f08b6]

        configure: Refactor platform defaults
        
        The main idea was to move complexity from source (and Makefiles)
        into configure.ac, because otherwise these must replicate the
        "same" branching, often resulting in diversions. Better to keep
        the logic in one place (configure.ac) and set additional variables
        to be used directly by source code and Makefiles.
        
        Notably this introduce the "using_*" platform flags, which should
        be considered constants. There is USING_X11, which actually tells,
        if the build uses the platform's X11 (and I opted for the removal
        of HAVE_FEATURE_X11). I also consider variables constant, after
        they have been exported by AC_SUBST, which should never be
        conditional, or some AC_DEFINE set them for a config header.
        
        A large block of defaults depends on $using_x11, so we set them to
        the same value, but just if the platform doesn't set it.
        
        The other important flag is $using_freetype_fontconfig, if the
        platform uses freetype and fontconfig. The headless plugin uses
        cairo for its drawing operations and freetype+fontconfig for text,
        so $test_cairo = $using_freetype_fontconfig. This is independent
        from a the cairo canvas!
        
        The OpenGL X11 code now depends on USING_X11, but it doesn't yet
        reflect the filter in Library_vcl.mk protecting glx. I don't know
        how correct this glx filter is, seeing that the source code just
        checked for "UNX - some  non-X11 targets".
        
        Change-Id: Id1ba1a967a5d8d10ee217458be879ed00459f7e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116440
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [159666084a28ab3591b96cdd390f8fa0ac62bf3c]

        gtk4: GtkButtonBox homogeneous isn't the same as GtkBox homogeneous
        
        Change-Id: I9dec7259b2dcbe4d7ea0143eaa33509e2a39d912
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116534
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [2907f7d97a3dabe1179f0251791fcee336b26a22]

        cid#1485150 Uncaught exception
        
        remove the reported exception path from the dtor call
        
        Change-Id: I438a9c3de41d516e1994aeb1509bb8ee333bf23f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116532
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Justin Luth  <justin_luth@sil.org>  [29bd00f7628e7a54e69cabcc7e2a1792c24aa55c]

        tdf#142404 DOCX c15: TabOverMargin no longer true in 2013+
        
        When compatibilityMode is 15, TabOverMargin no longer
        seems to apply. This is a dramatic visual change in docx
        that I didn't find any documentation about,
        but the visual change is obvious enough proof.
        
        LibreOffice started saving DOCX as c15 mode in 7.0.
        
        [P.S. related TabOverflow also seems to be false with c15,
        but it acts differently than what LO's tabOverflow
        code does. That was discussed in a different patch
        and seems to be a dead end, so I'm ignoring that aspect.
        Way too many complications and effects on LO native mode.]
        
        Change-Id: I5a0a6d695d6825444cf6a362a81803f306e6c6e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116337
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [de68b6ecaacee80b87f8884d24c45bf9a610f2a0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 21cf37e87fc662ede68f96efa9d13a412430ef96
          - Mute l10n on embed
            
            Change-Id: Ie43588bd08c7ff46b57424d20af4301f414b91c9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116537
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ab23779456df511a4e869ee4dc48584d297effd]

        fix leak in CppunitTest_sw_filters_test
        
        Change-Id: I4d6166f86d896a30b997f8cf9e9f30b34caefc4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116530
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [d5133826621709cf201a128961f54a2c91090d03]

        Add sd/source/ui/inc/MediaObjectBar.hxx back to clang-format excludelist
        
        ...which 2e30d16bb945042b5c033dc9bdba690ee4a08fed "Refactor module media item
        handling" had removed, apparently erroneously
        
        Change-Id: Ib4f21325c20abd1cfb095c8f8a63dd307f5c8d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116526
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f2f116a3de45a961b3849474daf0024fc05b9380]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 027ea0f2535143df97c7f5664669eb4e7920efab
          - tdf#132720 Clarify 'whole sheet expport' for calc PDF export
            
            Change-Id: Icac720987f6bd94ac7ce26cce57b9555628b5f17
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116531
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [00dac9306480cdca9be4e19ae3ff248df8b59c45]

        cid#1485154 try moving initialization into member init list
        
        see if it has an effect on bogus "Uninitialized scalar variable"
        
        Change-Id: I68d6a466f7fc9aa3412d50223dc53d6b60b721c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116527
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [e7afd6407401014f9eee6cbce0f80da7c0491a4e]

        use std::make_unique instead of new
        
        Change-Id: Idb9dc1897b5617a6e12110638857e153e2ba56dd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116525
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [2f78b2c4e8f82d9b5eb6fb5985a3f5e298b28499]

        ignore crypto leaks for now
        
        Change-Id: I5cc1d8730378c709582ee9927f63c13f0795866b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116523
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Tünde Tóth  <toth.tunde@nisz.hu>  [361b95b39c0ad3028f82b9893bb3c84dcbd1932f]

        tdf#140745 sc AutoFilter: fix placing of "(empty)"
        
        Show entry "(empty)" on top of the checkbox list
        in the Autofilter dropdown (instead of between the
        numerical and string values).
        
        Change-Id: I5b6d339d07b886bd52d24c7d900b53c6f921c2ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116439
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [25a648541a423b794b5827552e03fba1084b3792]

        fix leak in CppunitTest_framework_services
        
        Change-Id: I522e3e9b57668d7a8d1df10f4520045a3a3553dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116524
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [460b70779e5b88fcb021bf3f6ea1d682e1d6e0f3]

        fix shutdown leak in CppunitTest_sc_pdf_export
        
        Change-Id: I83a1f35d91c1843fa9500d18b7fc5b010201617c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116522
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [b05090e9d8765e964d939ee5cdd743fc7f463acd]

        gtk4: try gtk_window_get_default_size as replacement
        
        Change-Id: I24585f19037910d868e9dcc19440cee4a3375761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116520
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [9ed7d6241ce7f0b818c8eec43d2b7db1537047a4]

        gtk4: use gtk_window_is_active for has_toplevel_focus
        
        Change-Id: I1a49ee4aed6751bee0a26f8a0e2a3dc2bc87be3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116519
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [9fb1d5c7265f25ab80873a21e78bc842bd6ddf61]

        drop unused Widget::set_secondary
        
        Change-Id: I63e69ca9daa8a452eee28333d8639d1db093e826
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116518
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [40b45db8117735b41802a1bfe487f33164a4a1ff]

        gtk4: adapt to gtk_icon_theme_lookup_icon changes
        
        Change-Id: I32b99c29b68c4aaaa892b2ce4e51953efe8c3388
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116517
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [9e37f53874d4e36e3529345ffe7a5721e6a4c751]

        no need to allocate these on the heap
        
        Change-Id: I3ff875f8cf6f8b32bdf1c8b066f5f80dbff4aa64
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116521
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [313eaf979ea2d69e4ffa88a5e87cc09ffe0ff088]

        fix leak in SocketTest
        
        Change-Id: I8c5e2d4c4687beab08876fe3e945d19a1629bc36
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116514
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [63b00ec7d8d140853feb7108a788bfc4f0c79db6]

        no need to allocate these on the heap
        
        Change-Id: I6eb3853883c724b5cb28bbf4debf6f56a587ff88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116515
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Mike Kaganski  <mike.kaganski@collabora.com>  [21d14c51c2f07b795ba286430eb96cca0085f627]

        GetSlotServer can modify pImpl->pCaches
        
        Change-Id: I39810a7f827f3624e26763f3e81eae2c64e656e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116455
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [f3e1cc6eb5bf2f12c1783890bcd2be7d4aeb0abf]

        Remove config.warn during `make distclean`
        
        57f7b8f86bcd29b71e6d5f2990536eec64beeb05 "configure: Keep warnings file and cat
        build ones" insinuates that it shall no longer be removed during configure, so
        at least remove it during distclean
        
        Change-Id: Ic74aa0f2ca26887f90fea70d764b89b85a1cb01d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116513
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Attila Szűcs  <szucs.attila3@nisz.hu>  [5ead135faaee76bea78f481d7c63d54f56e9098c]

        tdf#126540 sc: toggling grid lines sets document as modified
        
        View->View Grid Lines modifies a sheet-level option which must
        be saved in the document.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Ifcee59d27fbe0bb50b9fe99e16c70e2062a714f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115711
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [26d755840c318b7296276bdc526e1c860c3406ac]

        gtk4: restore pixbufs to TreeView
        
        Change-Id: Ic12de1d245be1336e83b137d2d0f5e2efbd3d57d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116505
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [3199e5e8002453e00cc54c338a1f198f2c405968]

        gtk4: reenable a cluster of macro organizer dialogs
        
        Change-Id: I244cbbc0f9e5a6f134f9a720ee4332f0f02ec0fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116504
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [96c327049e5c012746c991d16042423b99624f50]

        gtk4: enter/leave signals are on the event controller, not the widget
        
        Change-Id: I44bc2e494183de35b5f1f25813af2a5e51cbc69d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116503
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [53ea95aec4e1bcdcbf50bdd6fd2e5761c26db184]

        gtk4: reenable a cluster of xml filter settings dialogs
        
        Change-Id: Iaeb359f1ab306b3264b81c7ec11328de1385b892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116502
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [f1ef0fe2b906188ad5245d04881fb6cc78dad616]

        gtk4: restore ComboBox row_separator_func
        
        Change-Id: I1aaa06ca3de9f45e6773ca103570fa06c00df1c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116500
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [8cd23766ac55470664e3e08d549a5591c9d34789]

        gtk4: restore focus handlers for ComboBox Entry
        
        Change-Id: I0a53a22efa3329cf248eae8784352b955e8cf0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116498
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [fe533ea89352dace57751c92065ed623612334c5]

        gtk4: reenable sort_native_button_order
        
        for whatever it might still be worth
        
        Change-Id: Iaf8ecdf3bca7245cdd3c2af6d22f2f9afbe9a8ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116497
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Caolán McNamara  <caolanm@redhat.com>  [23ad55d391b50ded2612316ff05ea9034e5dff33]

        gtk4: remove some unnecessary ifdefs
        
        Change-Id: Ie68b1c581979c32f83dcf0ca9a46c10b7afdec70
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116496
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [6e1bdeed547fdc1ae70fa3614b4583d31d831998]

        no need to allocate these on the heap
        
        Change-Id: I46de98204ec705bd2f6a618cb0cfae5149cea84e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116475
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [aaa3e5f722e693ebc5dd925b7ce35dce1753e810]

        no need to allocate these on the heap
        
        Change-Id: Iddbc48638fbd1326df79b59080132280029c5d46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  László Németh  <nemeth@numbertext.org>  [6a4409647519e0466896fae4ffe2dc64edd53d9a]

        tdf#60382 sw: fix tracked row deletion at rejection
        
        At rejection of a tracked deletion in a table row,
        set HasTextChangesOnly property of the row to true.
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: Iea78f8394890995cbc06209abd4bf5ea4ceb7357
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116446
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-06-01  Xisco Fauli  <xiscofauli@libreoffice.org>  [e1908f9e2345d9aebc28d93a8c647f0ed69b360e]

        check-missing-unittests: add changes in svl/source/numbers/
        
        Change-Id: Iabbde5976380c9e39590ad25ed4359f21290485b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116494
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [c2096ecb244cd70736e1e3be02e856a6d9ef57b5]

        Better keep these $(BUILDDIR)/config.* lines sorted lexicographically
        
        ...after 16b48021e12641fbba4320f70e06ae0462f1995f "Fix cross-compilation 'make
        distclean'"
        
        Change-Id: I544f43adf5603cfd6f704429abad7055e7061058
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116510
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Stephan Bergmann  <sbergman@redhat.com>  [e6c25186c8584f68b5f8074004556bd855200fff]

        Adapt to hamcrest-2.2-3.fc35.noarch.rpm
        
        Change-Id: Ibddfc30a5f0828ab77235ec1155f1c2e1eef24ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116506
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-06-01  Noel Grandin  <noel.grandin@collabora.co.uk>  [d95e54676039a593b797455674863ccd9a902d52]

        no need to allocate these on the heap
        
        Change-Id: I912b1aafcc615efb87455fa9ba02caf7bef044cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116480
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-06-01  Miklos Vajna  <vmiklos@collabora.com>  [6fc8a6b0b52509d735971f079d7b1660559d475d]

        tdf#142325 RTF import: tolerate invalid hex markup like "\'3?"
        
        The RTF spec says \'hh is the expected form, where both "h" are 0-9, a-f
        or A-F. But Word accepts the bugdoc, so don't reject this input, handle
        \'<number><junk> as \'0<number>.
        
        At least the current case ignores the actual value, as it's a single
        character to provide a non-unicode value after \uN for old readers that
        don't support Unicode.
        
        Change-Id: Ib61247ab08278ca5012cc887cee26c7571c29fc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116499
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-06-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [f535acdab1ae90ea326393c0ff419ee6ece6f627]

        Fix typo
        
        Change-Id: Ibf234bc3dbbd448cef2d4537289eddf713dbdba9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116508
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-06-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [2752a0a7e72b1d7e5f8bf22a3b4f17c69fdd7a48]

        tdf#142243 actually call toLower not tuUpper when calling toLower
        
        But it doesn't have an effect as both uppercase or lowercase work
        as long as it is used consistently.
        
        Change-Id: I898cdc7946732f1a504d902f38ae84565c95a0c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116430
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-31  Stanislav Horacek  <stanislav.horacek@gmail.com>  [3b57ebb445df8a2bc3d916ea79f8af45e20e4e62]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 19a842695c9bca652718e6ea3808a8f995164ef4
          - Czech Hunspell: sort words in .dic file
            
            Change-Id: I1e3fef34b64bd358d16880795acab6d9b71ad7dc
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116276
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-05-31  Stanislav Horacek  <stanislav.horacek@gmail.com>  [2fc300a8b7b36421b6260a419215690500dfb205]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 48a66dd55f3e76556f73779ab121feefcd07d3fe
          - Czech Hunspell: use UTF8 encoding
            
            Change-Id: I97e274fe4611cf1a2669e6c73950faed8f1f5bfd
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116275
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-05-31  Stanislav Horacek  <stanislav.horacek@gmail.com>  [7d4b63047cd7ca5927789471e31f86d939944d68]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to e7a4c67cdc491548388b43175741ee6e933fdde3
          - restore more advanced Czech Hunspell dictionary
            
            which used to be in LibreOffice till commit
            b31244205066114f5721beef118be7f9e518cd22
            
            Change-Id: Idd856ff4caedb1d8e7b4f0c42231014bd956da7f
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/116274
            Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
            
2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [1abd712e337909fe6c10930b16998eed0f50ae17]

        fix leak in SwFieldDlg
        
        Change-Id: Iedca9c7bab2973740bb8428b1cbf9cd852ebf69a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116482
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [a8c4db643eb4c332f2e8f25b2fd8c84401a847ac]

        flatten vector
        
        Change-Id: I7459bcc499d6734328b5be63a4bebd2102d52e0f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116481
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1dfb7d56137ea62d6f3cdfb07f3ee841eb28f9e]

        no need to allocate these separately
        
        Change-Id: I9464fbcc1af966755cc4eb8fe0beead4638848ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116479
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fa764925185a8a7836967b62ea89b17e60cf45c]

        no need to allocate these on the heap
        
        Change-Id: I05c00d0a4f077594d91b05698a1c04922f06a1cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116478
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [486d3dd4f68dd4f93d2f5c94d5cce3112ddf6d40]

        gtk4: reenable Box reorder_child
        
        Change-Id: I5705941e1459a7d2045223eefcfe0a9a09b3648f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116493
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [140f4f6d1d74debd3dda209e6f554ed9c102aa2e]

        gtk4: reenable event dialog that now works again
        
        Change-Id: Id0060447bc3931fbb77b9db2fee0f35c69f2bf30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116489
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [87fe3110bb74df751985ef6c68d98493ff8c0451]

        GtkLabel:track-visited-links was removed
        
        but we have some uses of it, which all look accidental
        
        Change-Id: Iccb12d904e8dc7410205735e49526b73bb81083e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116488
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [a8ba9ce02f8d2b1fa5639a5bcc77693652152813]

        gtk4: we definitely want large icons where we were using GTK_ICON_SIZE_DIALOG
        
        e.g. in the hyperlink dialog
        
        Change-Id: Iecc6f3accde0ed56352dacdf423520565b6419c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116485
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [ceb1d69eda4c7351e64cb92d40d7c48f3790f83b]

        no need for always-show-image if there is just an image and no text
        
        and reenable hyperlink dialog for gtk4
        
        Change-Id: Id7e487dd64e102af80bb90279682a0636b887f85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [f30fae2a910188b741ac7f346e1bad04656128bd]

        gtk4: gdk_clipboard_is_local can replace our hack for that
        
        and detach_clipboard for our purposes is equivalent to the old
        ClipboardClear case. Listen to "changed" for the owner change
        replacement instead of notify::formats
        
        Change-Id: If87f87800fd4449ce33eccb8ab819bc20e1c49be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116483
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [af83bf98b2ea907437edf964cf7af50a5bc66096]

        fix leak in redaction dialog
        
        Change-Id: I1e918259757021a7c702196be73468d91b244e61
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116451
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec49596a3e66163ce811e8b64808df249a5cf637]

        flatten SfxDocTplService_Impl a little
        
        Change-Id: Id3344141e4b65855717d4d480ab1a3a498fa2a1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116476
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [760933de5ab47f6313f93e28e31829e627b48b21]

        fix leak in JunitTest_sc_unoapi_2
        
        Change-Id: I97d4be24c06dcb6c069380de357dcebe86dd176f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116450
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Miklos Vajna  <vmiklos@collabora.com>  [e1546b790763c1004dc2e2e3581c666466d7cf9c]

        sw XHTML / reqif export: export PNG images directly, without an OLE wrapper
        
        Do this by default and add a ExportImagesAsOLE=true option for those who
        want the old behavior.
        
        Adapt existing tests to ask for the old behavior and add a new one that
        depends on the new default.
        
        Change-Id: If863215ce267d6accc85b5c8f7bdbd3f2b1e9187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116486
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [2efe1e8977a83143696b8db49c7c26bbff91c04c]

        no need to allocate EditNodeIdx separately
        
        it is just two pointers
        
        Change-Id: I80a9206b9f94fb4a4401352b93fcd727f787f52d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116474
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [21ad3e6cbdf9568c1152a2eab8178e4219e40c33]

        EditPosition does not need to be allocated separately
        
        it's just two pointers big
        
        Change-Id: Ie2d71f4530fa92a3d125446a6c45035e88617b97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116473
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [962bc9059e875f98e244b584c582f5b1674106b9]

        no need to allocate these on the heap
        
        Change-Id: I189f04c14a7ab7fbc1feba423efda88f3f811efc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116472
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Kevin Suo  <suokunlong@126.com>  [c4809b7c4e7f198464293e36d7f04cafe93597fc]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to e36e33937f9cda7fde9ab56f9eb25f6f549700c7
          - tdf#142531: fix help css for Simplified Chinese display on Linux
            
            The font "system-ui" may cause trouble in some system, although it may look good in several systems.
            See e.g. https://infinnie.github.io/blog/2017/systemui.html.
            
            This change removes the "system-ui" font from the list, still put "Segoe UI" before any others, but moves "sans-serif" forward so that it falls back to the UI font in most linux distros.
            
            Tested on Win10 and this does not impact the display for English or Chinese, but really improves a lot on Linux (Fedora 32 for me).
            
            Change-Id: I1cba731cb846d1dc8c708b12510167c48de539e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116487
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-31  Mike Kaganski  <mike.kaganski@collabora.com>  [0f5eb62300255d60d144cdf5dfe90f754cca15ed]

        Enable -bigobj on MSVC
        
        This fixes this error:
        
          C:\lo\src\core\sc\qa\unit\ucalc_copypaste.cxx : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj
        
        According to [1], it is enabled by default in all UWP projects, which
        presumably means there's no harm in enabling it (other than some
        compiling overhead, which impact is unclear at the moment).
        
        Enabling it unconditionally, it would not create a mismatch like in
        7788e87ce25183c1d6f92a3b972b8dd8c88e58e3.
        
        [1] https://docs.microsoft.com/en-us/cpp/build/reference/bigobj-increase-number-of-sections-in-dot-obj-file
        
        Change-Id: Id176add21fec2a6084149e9ff23bdafb10b3d579
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116454
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-31  Kevin Suo  <suokunlong@126.com>  [cfca68e0f70f6b9fa54f32cc21585c073677229b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 226a545d33667a0c9526593a5182ac0a849933e2
          - tdf#142417: Improve convertfilters.py and add API Names column
            
            This commit involves two parts:
            1. Improved the convertfilters.py helper script to make sure
             the generated convertfilters.xhp file is complete, accurate
             and containing no duplicated entries, and also add codes
             to also generate API Names column, as discussed in tdf#142417.
             Importantly, the code is modified to generate fixed IDs,
             rather than the previously random IDs or sequential IDs which
             may make the PO translation strings to show fuzzy when the
             file is re-generated.
            2. This helper script is run and the convertfilters.xhp is
             updated.
            3. The default css is modified to better display the page.
             There is no need to set overflow=auto for the DisplayArea,
             otherwise the scrollbar goes to the bottom of that area which
             is not visible. Also added a css class to display smaller
             fonts for the table.
            
            Change-Id: I8a5c73c9d6a0c0b44fc7db6cb67b140bfeb8b4be
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116405
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [cf23ebbbc356aa676077494585781ba6e8f937ba]

        Update git submodules
        
        * Update translations from branch 'master'
          to 387ea1005f554dadedc7073e947bbd93dfa38c25
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I5a54db2572738c26858f69eba71239fa9474f0a4
            
2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [057b25c04ea1032c20d99fc3eda88680cd0b9e54]

        crashtesting fix
        
        when doing
            soffice --convert-to ods tdf96952-1.xls
        
        after
            commit 5c79032077d387053c62829d62518695f68555c1
            Date:   Tue May 25 09:32:58 2021 +0200
            fix leaks in loading xmlscript
        
        Change-Id: I55c1e95a09db937604f62a5b33e56349512ff8ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [5b8729a741bd65c2f61ae9caba7ea15a139835e5]

        no need to allocate SvxNumRule separately in SvxNumBulletItem
        
        Change-Id: I7903565a468fc0fbec603c88b92cca6560a86728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116424
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Stephan Bergmann  <sbergman@redhat.com>  [68a6c70f25762374f7aed0d4d755345c6f37c78d]

        Simplify construction of a hardcoded IPv4 address
        
        Change-Id: I822313ee708935dd4ecb636c13a961fdd054d660
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116434
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-31  Stephan Bergmann  <sbergman@redhat.com>  [1fef071c01caf6c293dd941ee7c8340e6894afc3]

        Replace inet_addr with inet_pton
        
        ...as inet_addr is deprecated (it does not allow to distinguish successful
        return for "255.255.255.255" from -1 error return); and update tests
        
        Change-Id: I605cb2ba18fe9bd11d2d68c8f1c94271c4503509
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116441
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-31  Arnaud Versini  <arnaud.versini@libreoffice.org>  [d220fc00c2c3d7a2a24fd762599d1bfcc27f34d5]

        sdext : use std::mutex when possible
        
        Change-Id: Ia610c0c46e017452db71945f6f53fedbcb6d1198
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116415
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Arnaud Versini  <arnaud.versini@libreoffice.org>  [39aa29712fe4c7a1c432cecf03d9d491537c02e6]

        canvas : use std::mutex in CanvasFactory
        
        Change-Id: Ic492f6b398ace3796d4b2cd45455d9ddec6cd728
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116416
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel  <noel.grandin@collabora.co.uk>  [9abedad72c73ad83b66f3f8d261efdc5ce889683]

        Drop Window::IsDisposed
        
        in favour of the isDisposed in the VclReferenceBase base class,
        so we have one flag for this instead of two.
        
        Change-Id: Ib3d6ba750f95f21996bab2838af4c56295a13f4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [6034b642581803e2cb2566abe0a0cab0cbfeb50a]

        properly fix leak in ScAcceptChgDlg
        
        Change-Id: I4b6bb075c6511ac8ab8ab6f274977fd140925c41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116442
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [bf571610d34111198b98bae30042fb23a4c0f4a4]

        gtk4: enable cut and paste into other applications
        
        Change-Id: I9924a9af10532254dc368e274e4a20c6706e4239
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Steve Fanning  <stevemfanning@yahoo.co.uk>  [48f7f5d0543eedc0d8c85ccef7233b58f49beb8a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8ca38307bd81fbb37a664dd848fd1fda2c2b4181
          - Clarify example in help description of Calc's DOLLAR function.
            
            Change-Id: Iab2333cbd98bd4bb13ba35a07d4dbcd66fc840a6
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116166
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-31  Ming Hua  <plateauwolf@qq.com>  [6e99e299a6e50bc054304077096d7c20e66fff65]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d0fc1c87094067bc528cac5a66fd667dc41af125
          - Use UI term "Impress" instead of "SIMPRESS"
            
            Change-Id: I0ddf013795df105c4d7a7dcddede03bc374f069d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116167
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-31  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [447d13023dcba333d34aba315e9093d1c82b8912]

        vscode: tell gitlens how to linkifiy our buglinks in commits
        
        Change-Id: I7cc8efa94f75581d30047abf5c401b68741fb2a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116342
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [57f7b8f86bcd29b71e6d5f2990536eec64beeb05]

        configure: Keep warnings file and cat build ones
        
        Re-cat's the build / cross-toolset warnings file at the end of
        the host configure run and keeps them.
        
        Change-Id: If46fa3660dbd04cd5a23a4d9cd79fd19067dcfbe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116437
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [7efb6328cb5e43d87afbbd81cf0165683e9fd4c3]

        gbuild: implement gb_UnoApi_get_target_for_build
        
        Change-Id: Iaee243510023bf935097914fd6c4fcb701d35c13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116438
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-31  Jan-Marek Glogowski  <glogow@fbihome.de>  [af281d5bc2fb3f2c31f1718b711b32213a12219c]

        no-zxing: Unused GenerateQRCode function
        
        ... and while at it fix (new?) [loplugin:stringviewparam].
        
        Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-31  Balazs Varga  <balazs.varga991@gmail.com>  [e8bba8229080f873b89b39551e924d1c8609fc07]

        Related tdf#68113 sc autofilter: clean-up for
        
        commit: e6431d55bff7ae09c8b0708a0876c699bacca644
        (tdf#68113 sc autofilter: fix not empty button unchecks all entries)
        
        Change-Id: Id7cff40ae48dd09b44b0b553f50e379ecbb472f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116431
        Tested-by: Jenkins
        Reviewed-by: Tünde Tóth <toth.tunde@nisz.hu>

2021-05-31  Balazs Varga  <balazs.varga991@gmail.com>  [1f755525189884e4b2824889a6b9dea8933402db]

        tdf#142402 sc UI: store formatted values in standard filter
        
        value list and filter by formatted values later, just like
        we do in the autofilter.
        
        Follow-up to commit 4fd1333ba4bb4f2311e9098291154772bd310429
        "tdf#140968 tdf#140978 XLSX import: fix lost rounded filters".
        
        Change-Id: If26f4c0abd54de05b497861f2c278972bd8072de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116115
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [9bf1089965672d3825b587cbd888093ac362013e]

        crashtesting: use after free on export of tdf122510-1.xlsx to ods
        
        and also tdf95549-3.xlsm
        
        related to:
        
        commit f8c1048eb437b1e685b76198165844e2ecc97a56
        Date:   Wed May 19 19:04:02 2021 +0200
        
            fix leak in oox import
        
        and:
        
        commit 3cd6402c5443c8069c07d9e420d5ef5b43af6bef
        Date:   Thu May 6 18:47:30 2021 +0200
        
            tdf#127301 XLSX import: hide hidden named range of autofilter
        
        clearly this is fragile so just explicitly return who owns the
        ScRangeData*
        
        Change-Id: Ic3210bb8788bbbc85609bb384fa4a4625c15e487
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116432
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [8acc6bc43e0334157b97b36f570987a49c5febdd]

        tdf#142537 PPTX export: fix placeholder style export
        
        Regression from: b6b02e0b4c9d739836e1f61a886ea45b01e6696e
        (tdf#111903 tdf#137152 PPTX export: fix placeholders)
        
        Placeholders lost the formatting, which has been fixed.
        (fill, effects, and outline)
        
        Change-Id: I2b9300b85cf3641d89d748a03377f950e668a2af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116113
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-31  Gülşah Köse  <gulsah.kose@collabora.com>  [936af331ba6f5073aeaa0f10f5f2af1def1d74c6]

        Clean redundant SvxBackgroundColorItem and use SvxColorItem instead.
        
        SvxBackgroundColorItem is just copied from SvxColorItem. There is
        nothing special to SvxBackgroundColorItem class. SvxColorItem is a
        generic item and it's used on many places related with colors. We can
        use SvxColorItem for background colors too.
        
        Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Tested-by: Jenkins

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [7d34a7777cfeec112ab5cdabba059d01d8876be4]

        flatten SvxItemPropertySet a little
        
        Change-Id: Icb76ae5d0ebb0397bc1a2ea3c7d713a56d5ae477
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116422
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Stephan Bergmann  <sbergman@redhat.com>  [33bf4f0bcf941ee4609f558442035514f54cbc8a]

        Replace inet_ntoa with inet_ntop
        
        ...as inet_ntoa is potentially not thread-safe; and add a test
        
        Change-Id: I9df945b006ba7194c3b1444c4886101c08339ad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116425
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7f484eb774fc90cf8e1540a703c5c3856312ef2]

        no need to allocate this separately
        
        std: :vector is only 3 words big in it's empty state
        
        Change-Id: I5d7630f0ded1ace284c0a4441230bf672f4639be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116398
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [8371ae143ef31c332bdcf753ca1dff722a531229]

        vcl::Font is already a copy-on-write structure
        
        with an impl pointer, no need to use unique_ptr when storing in a map
        
        Change-Id: I9fa13133df4a8acfb7fd973509ec2b0e194fc5d6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116423
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [288a3c2dde611086e6aa5d7a7a15729e027ae75f]

        no need to allocate this separately
        
        Change-Id: Ia6ed82b67a412841e1559f385afec17da3852d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116399
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Miklos Vajna  <vmiklos@collabora.com>  [efc3412b1a86dfff56c49364efb36256d057a1e1]

        sw: prefix members of HTMLEndPosLst, SwFltStackEntry, SwFltTOX and ...
        
        ... SwHTMLNumRuleInfo
        
        See tdf#94879 for motivation.
        
        Change-Id: Ie091511f7b2fff3949295c310045631676879655
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116421
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-31  Stephan Bergmann  <sbergman@redhat.com>  [6cb1745c24c7651050e30216860c539fa13cc0e2]

        tdf#142467: Update comments with GCC bug ID
        
        Change-Id: I71052f8db941733ab4e4b1b36cbf1fcb28eac9d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116420
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-31  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [7db006c1b1601533bfc7c361af69800a8b17979e]

        tdf#142257 (related) Replace Ctrl+[] shortcuts in Calc for Hungarian
        
        To mimic Excel shortcuts and make them work on Windows+HU keyboard layout
        
        Change-Id: I3525a8c9e370ff240105c8f1495f1abde539eee3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116242
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [50fa8ea7406c5ac94f54c497e43f2489a7af24c8]

        cid#1476301 Dereference null return value
        
        Change-Id: Ibbaa99c28bee97b5194f1a8d396730b7fcc02930
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116407
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Caolán McNamara  <caolanm@redhat.com>  [55cc7b0d96bb2e21ff101cde9ea08e9b0091147a]

        cid#1485136 Structurally dead code
        
        Change-Id: Ic02110bd0e4387ed41b2852cba7d070fb7014bd9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116406
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-31  Justin Luth  <justin_luth@sil.org>  [f49e5902a3737c02fabf5bec23243ccb126426c4]

        tdf#138302 partial revert tdf#108496: DOCX: redesign of override in lists
        
        LO 6.4.5 commit	cf13fe3e6f6a40f6db064d65d4514d13a23a31f0
        was only concerned about DOCX, but just elinated shared code.
        So restore the shared code and just don't execute it for DOCX.
        
        It doesn't look like RTF was working before this,
        but this does fix DOC format.
        I looked for existing unit tests in rtf and doc,
        but none were found that hit this code.
        
        Change-Id: Id624f73181384f38e1ef9f27575e0fb82eea19c7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116349
        Tested-by: Jenkins
        Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>

2021-05-31  Noel Grandin  <noel.grandin@collabora.co.uk>  [d1a74a44d7d818c7613bf02a52345c7f39b56a17]

        no need to allocate these vectors separately
        
        Change-Id: I015df0308696da3c4fe1ed45afd01185d0ce7d76
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-31  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [f275c4b31f095193b80cb756f8610c16282fb8f4]

        tdf#53004 tdf#142495 WMF EMF Always display Text rectangle
        
        In previous implementation if BKMode was set to Transparent,
        then both Background of Text and Rectangle was not drawn.
        
        It was wrong, and Rectangle should be always drawn.
        
        This commit fix that issue and allows EMF images
        exported by LTspice to be rendered correctly under LibreOffice.
        
        Change-Id: I03801d35d92eb2a3fdc175ca1d5b348a2aa30842
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116394
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-31  DaeHyun Sung  <sungdh86+git@gmail.com>  [363cf231c73673e8daf766aa6b24498f3e913e21]

        add & mod  words in Korean Autocorrlist
        
        1. modified wrong Korean autocorr word in DocumentList.xml
        2. add some autocorr words(Korean word `ㅎ` order.
        It origin from Open-source Korean text processor `open-korean-text`.
        
        Link: https://github.com/open-korean-text/open-korean-text/blob/master/src/main/resources/org/openkoreantext/processor/util/typos/typos.txt
        Change-Id: I3df6e60f756a8b74192192cef3ab8847301ad15e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116371
        Tested-by: Jenkins
        Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>

2021-05-31  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a39947102bac8430b13b10b3f11c34b5ebf576b0]

        tdf#142243 HUD - Use XCharacterClassification to convert case
        
        This should use international case conversion, not just ascii one
        that was used before.
        
        Change-Id: Id01d3d0d30a846f02f97d081491b0de2c0d6ffef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116419
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-30  Arnaud Versini  <arnaud.versini@libreoffice.org>  [e718f0e703c0fb33a0b1b5efe7b13b02c25f3335]

        sw : missing std::optional include
        
        Change-Id: Ia5973a0ffd43962ef2391f431d3d6b544fe19879
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116414
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Caolán McNamara  <caolanm@redhat.com>  [bc18682b598f1f1c071af8e70c1788352d96695d]

        frequent recent CppunitTest_sw_uiwriter failure
        
        since...
        
        commit 66438a0ad5a3c6d2792f4c6c04c2d2405b5679cb
        Date:   Fri May 28 15:35:25 2021 +0200
        
            std::unique_ptr->std::optional
        
        Change-Id: I8feefa8787ebf82c1afd8109c6e4fa30f726d6da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116417
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Caolán McNamara  <caolanm@redhat.com>  [156fad36377ba369065bacad863a31c808314069]

        crashtesting: on export of fdo84621-4.ods to xls
        
        Change-Id: I0553a7584347e0fc3ebcba6f99e974b9b1d341a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116412
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [039c7999d4b92122cb4a356a1e65f62026c04173]

        no need to allocate this separately
        
        Change-Id: I78260d3e6ad8ce96db4353fede18d5e3a6808402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116400
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [3a90121c460f3832966773c3341708f77e5e0474]

        loplugin:stringview
        
        Change-Id: I4a6345db1ff379dedc540ceaf295968689b1d0c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116410
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Jan-Marek Glogowski  <glogow@fbihome.de>  [3fc89330a976cb2221a579ccc6d7230b9d20691b]

        Drop GtkSalPrinter bits from option dialog
        
        After commit ed07ec7606cb24cccaf6b7b81b2bd308debaa2e6 ("drop
        never completed GtkSalPrinter"), there is still the experimental
        option left, depending on ENABLE_GTK3.
        
        We can't drop the whole PrinterCapType::ExternalDialog, because
        the osx code actually uses it.
        
        Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [33cacd2f3e06921e0d4d591b93febecc4afd4fbb]

        no need to allocate this separately
        
        an empty vector is only 2 words
        
        Change-Id: Ie9b6b8e97a9781916250cdc1b6b29406fe27d6b8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116401
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Caolán McNamara  <caolanm@redhat.com>  [a7779c6dd428bb9997aaf3c43e6a4258223c751e]

        gtk4: inch towards providing clipboard content
        
        inheriting from GdkContentProvider and implementing a replacement
        get_value like gtk_text_buffer_content looks the way to go.
        
        Change-Id: Ic376a586b77b7f00385e5744c0bc2923f2a72c94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116397
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Caolán McNamara  <caolanm@redhat.com>  [f781691a6e35923acf64e11e082c4173fcf9d5e6]

        tdf#142549 Assertion failure when closing LO in gtk a11y
        
        since...
        
        commit d90aa314961ea4a6893144cd6be66dd71cc2cca1
        Date:   Fri May 28 20:39:00 2021 +0200
        
            IsDisposed->isDisposed in vcl/../app
        
        revert the offending hunk for now.
        
        maybe final fix is to special case VclEventId::ObjectDying or convert to
        !xWin->mpWindowImpl or something.
        
        Change-Id: I6987aeb753181fa2eb705fa0535c092e51587a9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116396
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Caolán McNamara <caolanm@redhat.com>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea1daffc097025c9969f76119d3864cbef203c34]

        no need to allocate this separately
        
        Change-Id: Iae6b212c9114c0a5384fc8b7033fa80fa687c638
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116402
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e9e9b796bf597a7ceedb608e3fbb0c1480b0633]

        don't check isDisposed inside dispose()
        
        my fault, from a recent commit. besides defeating the dispose(), it
        should also be checked from the call sites.
        
        Change-Id: Ia09580d4224bcf78e5684015c747105fa6606878
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116383
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [1d641424d2591c3e221d0bd6a203f46e5c4352fe]

        std::unique_ptr->std::optional
        
        Change-Id: I674ef2bccaa56d1435b821e3e161f7c47340202f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116380
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [8ee22cb0bd6e741a553ef7d5b78cedc7ca669939]

        std::unique_ptr -> std::optional
        
        Change-Id: I78e5995b1a5cccff9c632ef4bcf75ea3ec01ff65
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [c78fa391c99885492d50de12b7a6b5912229061f]

        std::unique_ptr->std::optional
        
        Change-Id: I7a10e9bf14d45d1fe958dc33fe96ebb8318b3bec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116393
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-30  Muhammet Kara  <muhammet.kara@collabora.com>  [e98b0891d6e0f1d6be4e4a4761bd1ab16bfab85c]

        tdf#136292: Fix crash on invalid JSON from the extensions API
        
        Change-Id: I91ed555f93173dee10e87025b231560693be50b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116390
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-05-30  Steve Fanning  <stevemfanning@yahoo.co.uk>  [0d4e5630ac638e555a4a3261b3baa6d271cf5a70]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d443ebed5df323aa13c2f5fa505b98366d8a4f9c
          - Fix help description for Calc's TEXTJOIN function.
            
            Change-Id: I91bb809ab41c0299c65236a0091c2da288a47b31
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116163
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-29  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [9bf4e0d8f538cb0b51d2e803156301a956deaac3]

        tdf#127484 - Use HTML caption tag to name externally linked tables
        
        Change-Id: I0abca8e1966e93337c16609211c146c0ed97c62f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114743
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-29  scito  <info@scito.ch>  [bda9929821de620f1f85528abd1c4bba46d937d6]

        tdf#142201 tdf#142065 fix cut paste transpose references, incl. undo
        
        For cut paste transposed, references are not anymore updated during
        UpdateReference(), but all these references will be updated during
        UpdateTranspose(). In previous implementation, some references were moved (i.e.
        updated). This caused problems in UpdateTranspose().
        
        A transposed flag is added to the clipparam. This flag is checked during
        UpdateReference().
        
        UpdateTranspose() must only operate on (i.e. transpose) references pointing to
        the source area. That's why updates must not be made during UpdateReference().
        Otherwise references pointing to the destination range will be transposed
        wrongly during UpdateTranspose().
        
        References in formulas as well as in named ranges are fixed and tested.
        
        I've added unit tests for all these cases and I've enhanced my previous
        copy/paste test framework (6491c205acb3c166d93ef6a41199d344e21d98ac) for
        cut/paste tests, incl. undo.
        
        Before LibreOffice 7.2, adjusting of references in cut paste transposed was
        completely broken (tdf#71058, tdf#68976, tdf#142065 and tdf#142201).
        
        Change-Id: I8a8d295f1cc683572905ae9633e16d010cfb8792
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116073
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-29  Mike Kaganski  <mike.kaganski@collabora.com>  [e0c4cdf9a874bb40f028a26562e6399d39cb2c0f]

        Missing include
        
        Change-Id: I0b818b5bad00006e3577b65fe7bccc7a258cbf54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116165
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [782b189045b571c841d7124a8d753797a108a6f5]

        gtk[3|4] make LocalizeDecimalSeparator take just a keyval as arg
        
        Change-Id: Id37a275d56fdbcc0f18f6a322810966f4269f501
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116392
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [b825a7e3068c2983cbb753a4ad43acc3bd363c2b]

        gtk4: get GtkComboBox menu keyhandler with Entry case working
        
        Change-Id: Ibcdd82088bb6969353ad6017bc53f06cf12dd283
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116391
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [c83615f8c61b14bd842faffabc4c2965ca78571a]

        no need to check IsDisposed here
        
        the call site does that
        
        Change-Id: I8373eb4a6b87e96b211dd6bacea051d43b7ae8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116178
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [66438a0ad5a3c6d2792f4c6c04c2d2405b5679cb]

        std::unique_ptr->std::optional
        
        Change-Id: Ie09ede2ce21c206ca158a5a89d50143cdde45e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116381
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [397ba047c941eb7d77a15a8de72e20ace4744da1]

        std::unique_ptr->std::optional
        
        Change-Id: Ie01aec182ad361522f6ebc00e2f2e47d0fc38d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116378
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d32dfd9e955cdc893aa21ab8e870d217d1628ad3]

        std::unique->std::optional
        
        rather than having a pointer to a pointer (which is what Sequence is)
        
        Change-Id: Ieb7b9995f6a25022fe2401adc3c38124edb83506
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Radhey Parekh  <radhey.parekh@gmail.com>  [307ee1357cf2c4acd2f3e5a90285e8cb7c4c14e2]

        tdf#120801: The background colour is active when inserting a header
        
        In this patch, the active background colour is disabled by passing null value as default to the FillStyleItem.
        
        Previous Result: Background colour was still active even after inserting a header.
        
        Result after applying this patch: Background is now remain disabled/inactive.
        
        Change-Id: I5e8d22af338ef8ec93aa0e93d338ab8129fdc893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113468
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [d47ac2ebdb495b025eb26e17cbbe2509797c31f0]

        flatten TabBar item list
        
        Change-Id: I75a57ffdd55de61cf6acc0e562e4ae76f0065585
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116373
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [3823e81c25ba6f0f9b6a67d77e585426905e1b19]

        std::unique_ptr -> std::optional
        
        Change-Id: I15779eca607f27a758575f4f095910277aa85eda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ee50d4152cc4a06367d66808ceba1e74e62f3ed8]

        no need to allocate these on the heap
        
        Change-Id: I58847f8eb2c8dc17ca393a758d122cd3929deeb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [f57c2e65a50585ef4a282549c13655d9afc83d86]

        std::unique_ptr->std::optional
        
        Change-Id: Ie3e0eb7cb7ca25536e825e30c53e112bf537b325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116379
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [b3cd042285af08a0bdc5dea608d131424d850f9c]

        resave with latest glade
        
        Change-Id: I1f951aa3a776b624a01526ff4767ea50ffce420e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116387
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [e9301742254b85f4c6fbfd9378b365c76f5ff367]

        gbuild: implement gb_Library_get_target_for_build
        
        I was wondering why removing instdir stuff forced a rebuild of
        the cross toolset. Turned out some cross-toolset bits were wrongly
        depending on host build stuff. It even had FIXME...
        
        As a consequence, gb_CPPU_ENV was replaced by config_host.mk flags
        to provide an CPPU_ENV_FOR_BUILD and also uses the correct
        OS_FOR_BUILD.
        
        Change-Id: I50e8e8dca50ab1ad3164948a585a792a52e4a39a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116359
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [8196c0a0a532dc1b8577d1aa530c8f9f47fc3e61]

        fix coverity build failure due to --with-privacy-policy-url=...
        
        Change-Id: Ic94cd5fd7aa472c58ff3e95e2b1759d4219ede21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116389
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [be6111c0679b9c5249250ada2814b1a00c8d8c0a]

        ofz#34763 missing components
        
        Change-Id: I6a27f7412975694f3b710e66b4eb5358279bc132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116388
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [0e142fa01972ad28182ca54b855d0ecae0d5c83b]

        cross-toolset: gengal now needs localedata_en
        
        Looks like some dependency changed, because now gengal aborts with:
        Fatal com.sun.star.uno.RuntimeException message: \
           i18npool/source/localedata/localedata.cxx:1469
        
        Fixes the Windows Arm64 cross build for me.
        
        Change-Id: Ie243da90d15fe06527830a31ca1ad519d7caebba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116386
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [b6518bebc5fc82c88a455c6b22023e6392483e14]

        vcl: Implement static vclplug usage
        
        .. and convert Android to it. Will also be used by WASM.
        
        It's also kind of a followup on commit
        f5af2104fc490b90510e36bbf1d2adec8017c594.
        
        Change-Id: I3a1b5bc2eae2692e706da10c6352534433c61e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116385
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-29  Caolán McNamara  <caolanm@redhat.com>  [1d15f180a6e6a45b74b602402176f0d6e4372cc6]

        gtk4: reeable some more newly working dialogs
        
        Change-Id: I751b7192a61e2bf5c28559429d89fc219b0efca0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116356
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac]

        IsDisposed->isDisposed in vcl/../window
        
        Change-Id: Ic1c8bb6bb9a45d4e91c997b752e23aed35767f42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116364
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [30aa33e6a6b9fb230af96f619db27fcaf31ef914]

        flatten ValueSet item array
        
        and change mrParent to mpParent in ValueSetItem because references
        preclude copy construction and assignment
        
        Change-Id: Iabb0c6ccfa4eed645cf6ee75d7ff83f9c4ec5a1d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116372
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4b5aaade285ecad39332ad8b195738feb51151a]

        no need to allocate this hint on the heap
        
        Change-Id: I6321d03cb5786aa0c17705cc8c8bcf1f85326f44
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116369
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [1df758fce8ac23b54f96f2c0f3dd608bb1da024a]

        remove IsDisposed check in sw
        
        already checked by call sites
        
        Change-Id: Id03d07b7aebd36e891f831ff4bdab7e63a7c4ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116345
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4c365618fca79aeb6f3c87bb1cd47b1809dfbc6]

        no need to allocate these on the heap
        
        Change-Id: Ia839a25cb75782b7b92372d876a41a7fd2e830d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116370
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [14e52313e4d350d9960cdd972e87b7f206ee4e2d]

        no need to allocate these on the heap
        
        Change-Id: Ie4077a86523d623e1913c4f97971ab81d04abd4f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116368
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [ca37f29421927d8f2d2b8fe2208649d6dad13011]

        no need to allocate these on the heap
        
        Change-Id: I07a1fd5833bc61eb97649ac5d85b1b0eb3054baa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116367
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [0bb2985071780ab3c83e576b1f57841fd037eaba]

        no need to store SwSortKey separately on the heap
        
        Change-Id: Ib05e02a6c9c239f590508c7e71667d7ecca64f79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116366
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [bc86f6d3583965dd369d0ae73a5d647c43ae38e9]

        no need to allocate these on the heap
        
        Change-Id: Id82625ec95720d92353804d1b503b8f71e1db91e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116365
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-29  Jan-Marek Glogowski  <glogow@fbihome.de>  [cb48b1524ca875bcd521465b7dbdbcbe4eb670ee]

        configure: Fix typo in CRYPTO_* selection variable
        
        s/BUILD_TARGET/BUILD_TYPE/g
        
        Probably just passed build, because default TLS is NSS, which
        includes the same externals.
        Thanks Caolan for catching that.
        
        Fixes regression from 07556be594c77f9b7886ff31c2e1752f937cacd4.
        
        Change-Id: I4fa2f2b53c1234bd1612966151792ae7b33358be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116362
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [75b6b7f66b6ff66f8d9945bccdef71952db2d966]

        IsDisposed->isDisposed in vcl/../control
        
        Change-Id: Icd5fb88f3827eddb307f5fe6b46667a72062e408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116358
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [078b052e11f0652ed393b809a7d4a03b1feb58d9]

        IsDisposed->isDisposed in vcl/../uitest
        
        Change-Id: Icaa60c6b7629781fdde8bd0cc49859d0ffe6f06a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116360
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [8d83093e36e973f4d188682ac2bfa9a6d80622f3]

        tdf#142547 Crash when adding comment in a table in Writer
        
        regression from
            commit 819b30e937d227d1458ecc22b09ef994ebe7e17e
            Date:   Wed May 19 14:47:19 2021 +0200
            tdf#142367 Writer crashes when opening docx
        
        Change-Id: I47050391e36c4fa40519f029171e663a456fcb25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116361
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [3a9027609e7ee0c7af457b06426093782ca295a8]

        tdf#53004 tdf#142495 WMF EMF Fix displaying Text with OPAQUE and CLIPPED
        
        With OPAQUE option enabled, the rectangle need to be drawn,
        before drawing text.
        
        With CLIPPED option enabled, the text needs to be drawn
        only inside rectangle.
        
        In previous implementation, the rectangle read was skipped and
        it was not drawn (for OPAQUE).
        
        For CLIPPED the rectangle was read but Clip was not applied
        to text drawing
        
        This commit fix that issues, and allow to draw rectangle correctly,
        with BGColor (background color), and add support for Text Clipping
        according to [MS-WMF] and [MS-EMF] specification.
        The fix applied to EMR_EXTTEXTOUTW, EMR_EXTTEXTOUTA and EXTTEXTOUT records
        
        Change-Id: I0f6248bb9465e6d5f797cddb53f058afb0815a2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116072
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [d90aa314961ea4a6893144cd6be66dd71cc2cca1]

        IsDisposed->isDisposed in vcl/../app
        
        Change-Id: I1fee7893c5ee67d4ad4f51bf6ce45fe80531cd34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116357
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [e608ecf9a9e218739f88edbd96c00631eb9e610b]

        set one of the RadioButtons explicitly active
        
        Change-Id: I5bd185b8b4eb05993137942c80f304b6b108a2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116355
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [d77ac6f9d25a1ec2ef04cffa6748c95411706947]

        resave with latest glade
        
        Change-Id: I0c706b44c6c73834b91a38f6c79a8aca2d6b17b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116354
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [fb08aedb6c2bf0c4eda720451970568533a3c5c1]

        gtk4: restore 'return' in combobox to active default dialog/assistant button
        
        Change-Id: I540d8d6461470bf784c3cade909c4d4cd68d0854
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116353
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [284739963674f018cb946b3d2ab855afb498c87e]

        gtk4: restore typeahead in ComboBox dropdown widget
        
        Change-Id: I851c4b3d43ae0b12055f3c76c8e7f7d78c9f1b75
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116352
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [f8788a30653bff30f13d40c5e8a3115b6112243a]

        gtk4: restore typeahead in ComboBox widget
        
        Change-Id: I87a129748f54692add0e047ccdebf71c8b5075e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Miklos Vajna  <vmiklos@collabora.com>  [5fbd20682f34c817359156889ecbc3ad8290d72c]

        sw XHTML / reqif export, RTF markup of images: write OLE1 presentation data
        
        With this, images are exported as PBrush OLE objects, to please some
        consumers (e.g. IBM Doors).
        
        Change-Id: I89805cd66709d96cbe71853d65671f76a3fc871f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116348
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [473337a03f8261eee454d84d252fcf85193dc137]

        IsDisposed->isDisposed in toolkit
        
        Change-Id: Iad56b2b265f83f73f75086aafeb1696c8a8ab5fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116346
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Jan-Marek Glogowski  <glogow@fbihome.de>  [07556be594c77f9b7886ff31c2e1752f937cacd4]

        Select svl crypto backend in configure.ac
        
        And define USE_CRYPTO_* macros to select it in code. This way we
        can get rid of all the HAVE_FEATURE_NSS and _WIN32 variations.
        
        This also reverts 1f6b98f21495f0ecc5ded493cb3273da03852191.
        
        Change-Id: I101e4ae2f49cdb127d59bd49a4f1c86304ca2238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116338
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-28  Mike Kaganski  <mike.kaganski@collabora.com>  [af00f50211c9e3f13c4a6d8f0a8f0fabf377c56a]

        Missing include
        
        Change-Id: I7a0c1d49da993f5f9da80df5cb6b0667775c1261
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116162
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f58e7483d10db24c02a28cf05d7402c7f44be014]

        IsDisposed->isDisposed in winproc
        
        Change-Id: I8700f211190c55ba1a5a23ecaed12a57f6617a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116347
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [bd88d5a7919672e89e57a31bf4262aab676e0195]

        gtk4: renable autocorrect options dialog and pages
        
        Change-Id: I47dda59977fa5002dbdf572046734d60b1c6eb68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116344
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [e2788d9365954a4ec91e23c3ef2b44f6c7c57eee]

        image-position set, but there are no images for this button
        
        Change-Id: Ida66830d992d4b779994b745def0c380d02263da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116343
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Justin Luth  <justin_luth@sil.org>  [a771262cfcfc358269dc50dfa10f9e497e7d8deb]

        fix build
        
        Change-Id: I6d0bfca4b66b02b4724885afc4c8d15a40a74e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116351
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [9b81036c87b52edc2ce44813b31be425bc12ee1d]

        no need to allocate these on the heap
        
        Change-Id: I55ecf6b8d9df2078f9bc81f54dbabf425c300643
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116320
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [af8d12bd3a73381dfdfad92b63306369a665a2d7]

        gtk4: insert propagate-natural-width on seeing hscrollbar-policy of never
        
        and likewise the vertical equivalents
        
        Change-Id: I28bb5de334aafc96de78c7d03c69f8df66e6a4ab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116341
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Justin Luth  <justin_luth@sil.org>  [89e7341025b607491c90efdb74708e63d875c1e5]

        tdf#142404 sw compat layout: ignore blank size only on one-liners
        
        If the paragraph is longer than one line,
        then do not IgnoreBlanksAndTabsForLineHeightCalculation,
        which was introduced in LO 4.0.
        
        This is a preliminary step for fixing bug 142404.
        
        I found a few pre-existing unit tests that triggered this,
        but none were good examples to use as proofs.
        
        ooxmlexport7: 77219 - not sure where - no visual difference.
        ooxmlexport10: 92157 compatibilityMode15, but visual too little.
        ooxmlexport11: 88496 - not sure where.
        ooxmlexport13: 121374_sectionHF2.doc -tabOverMargin in header
        
        NOTE: This patch could be seen as a BAD THING in the case where
        tabOverMargin normally hides EVERYTHING. We don't handle
        that situation yet, so a very long series of tabs could
        take up several lines of space (which isn't done in Word).
        Now with this change it could take even more space.
        
        Well, the proper fix would be to not show any of those.
        Perhaps we could just set the width of the portion to
        zero if it sails past the end of the page?
        Anyway, the point is that this it-isn't-right-anyway
        situation should not block pushing this patch through.
        
        Change-Id: Iaea8e0edf78c8fbe319aadbc6d62fc0bdd180814
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116317
        Tested-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [7a9a1ca7a0a82407b869b76d96d820864d98dcad]

        gtk4: remove 'homogeneous' on conversion to GtkHeaderBar
        
        Change-Id: I5dcf6a186ecf22b0a0d7ba624c2adf737d0a7852
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [b7ed08d590507d8a3107fcdb692ca951c7c66466]

        gtk4: add working titlepage dialog
        
        Change-Id: I7f7bdad8794a40d47477da591d988f1e11d16717
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116334
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [572fb7ca5c03a5e2716eb8e3bba727bd96cd3517]

        gtk4: remove some unused ifdefs
        
        Change-Id: I1035efdc3bd19dc04ae81d781d07626be9b6b4fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116331
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [e27bdc568a77f45f691d784f2c162341407794ba]

        gtk4: collect GtkCheckButtons explicitly
        
        seeing as they no longer inherit from GtkButton so their labels
        are collected for mnemonics or expanded with string-hook via the
        GtkButton handler
        
        Change-Id: Ie0b2b6e6b57c518bbd2035a846088c11d45bd107
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116335
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [000f4c983d1b6c1bbaff3998494dabbb44a64120]

        IsDisposed->isDisposed in sfx2
        
        Change-Id: Ie717cd4ad051facdf2bcee3e521cd6e42f59003f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116328
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6641682ee9a62a1d8929b1f243f856494678dcdb]

        IsDisposed->isDisposed in svx
        
        Change-Id: I986cf078004a292eb3560857274e5542330d203d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116329
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [2659a8685ae55c95aeaaca288caeed253274c853]

        gtk4: restore double-clicks in DrawingArea
        
        Change-Id: I8bdbba3148bb7447f511938d79b878cf1626dd37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [b8fff7f442f5ddeb83d9bcb9f48e402954a4ab45]

        gtk4: reenable DrawingArea mouse clicks
        
        Change-Id: If2985a28365da472111877b45c20fb880b818c89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [c8e716d67c83a59be81777512bb08ca70df8678a]

        gtk4: restore combobox set_active
        
        Change-Id: Ia8d7d8c52568d1d1fd72bd450f2a707a14bc610a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116324
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [76507ce885893dff1d39945a204cffa4ab5fd3cb]

        gtk4: 'events' property is redundant now
        
        Change-Id: I1819dcaec3835a6e1ca2c54f7ac14804b407c613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116323
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [93eb2ce1cc440d2d972dd700a0051838fe8b78a0]

        gtk4: default converted GtkComboBoxText to can-focus
        
        this was always a quirk in gtk3 so explicitly strip can-focus
        from GtkComboBoxText
        
        Change-Id: I86a475fa81cf9d6361caadfbd9ad1361a7aeb797
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116322
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [b184d39e212a4af6fcec723cfec58af61da121e0]

        tdf#125268: sw_ooxmlexport15: Add unittest
        
        Change-Id: Ide709668ce88345ff01c2945f28ceca164faf17d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116325
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [baa666654327425ceb3cf93ad2dc27fd7bcb8abd]

        no need to allocate these on the heap
        
        Change-Id: I5ed00fe80e96e9d07d56eb7841a66ba98f328a91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116318
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [0b212dc041c96e706b1b3321fcb9151d20d5dd1c]

        gtk4: reenable ComboBox
        
        lets find out if we can return to using the real GtkComboBox
        instead of a look-alike replacement.
        
        Change-Id: I28d005b37835f09ace095a3642f7c06be6f1e27b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116321
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [3e0c39f9aeaa5c8791df94418ab8b4b78e005ac1]

        no need to allocate these on the heap
        
        Change-Id: I0f477edb666ff2c6dc9def45ec68c4ce1a34634a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116289
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [6eb3d37fdc75537aa94144eef97493ec6192792f]

        no need to allocate SfxStyleFamilies on the heap
        
        Change-Id: Ibedb36dec14c61927ef594ddf47fda94728530a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116319
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Tibor Nagy  <nagy.tibor2@nisz.hu>  [a4b66458a7b8da2f5580014813e5dabe3fa670b6]

        tdf#125071 PPTX: fix missing custom slide show export
        
        Follow-up to commit ecf48b2d4f3e54dbb2c1e295120d73e7b7a11338
        "tdf#131390 PPTX: fix custom slide show is not imported".
        
        Change-Id: I2a85e2ea08f6a70cd5f26cfb99a0ff1add2c296a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116177
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [83fb7db6911aa77d713f3da0391b680e55563181]

        no need to allocate these SfxItemSet on the heap
        
        use std::optional where the code needs to control the lifetime of the
        object explicitly
        
        Change-Id: Ia550ce051360f68911abc68c945a97d62a637b06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116291
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Balazs Varga  <balazs.varga991@gmail.com>  [fbfb57635b602b50cb22465047ae5bcdbef3dd0a]

        tdf#138438 sc: fix "Top 10" autoFilter in multiple columns
        
        Check all QueryItems instead of just the first one. Now
        top 10 values are visible (except the values hidden by the
        filters of the previous columns).
        
        Change-Id: I317d0c6843e568f8645b744968352a0e895a42dc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115267
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [7f60fafe3b54e2cc86d996b3211be7e82fb478a2]

        crashtesting: backport assert downgrade
        
        Change-Id: I6d813cd9996633b207e30c2f1fff707810396153
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116315
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Linus Heckemann  <linus.heckemann@sphalerite.org>  [85462ef7aed85bcfb0e0628c5252a07c369ff606]

        tdf#108591 Don't hardcode xdg-open path
        
        Change-Id: I6f32433284948e42798c3535db64b4ad48295d35
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110530
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [6ca67de9426602234914ca0237083f57944f5764]

        gtk4: reenable some already working dialogs
        
        Change-Id: I95fa4f6fc0f51bc1036271cdf697c5fdc85a6d8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116269
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  dante  <dante19031999@gmail.com>  [1a0fd1c1342969e5b4d08d13764483cd8bada589]

        tdf#130654 editable smeditwindow zoom UI
        
        Change-Id: Ibedf060ea838876e3598ff449e6f200119570cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115605
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-28  Caolán McNamara  <caolanm@redhat.com>  [e2970060121824650f95421d8d2411840a40311f]

        tdf#142150 nothing already selected on MouseUp without previous MouseDown
        
        if mouse down was on tooltip (possible on macOS)
        
        Change-Id: Icb4328fa6977356c3bac5f37d42e99ae8d4e4b98
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116273
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [164fecadfde2569cb5324017d9bf22e2963008b3]

        no need to allocate these on the heap
        
        Change-Id: Ic1a1577ed837d3fa2b7b99474f4cee30300628f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116290
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [726d0a2d54da3e97de242c2c10be3afd2aedf943]

        tdf#137199: sw: convert list format string to prefix/suffix for ODF
        
        Since internally LO is able right now to use list level format strings
        and prefixes/suffixes only for backward compatibility, there is a need
        for conversion from format string (like "%1.") to prefix ("") and suffix
        (".") still used by ODT.
        
        Change-Id: If4b459e1b25b7f0ce511e6ac2de0824bb2c43d05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116288
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-28  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [9864fbc9d5f532d9aa4742968886b3f94bc44dbc]

        tdf#117957 WMF Replace ellipses with rects to fix tests on arm64
        
        The issue is caused by floating numbers,
        On x86_64 it is:
        
          338.499728160392-445.269903703769
        
        on arm it is:
        
          338.499728160392-445.26990370377
        
        As in test files, we have two ellipses (which are made from small lines),
        which points rounds differently on different architectures
        
        Change-Id: I44dd5c7b3b13f3b1680d5a3a8348d6f467cb2f7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116270
        Tested-by: Jenkins
        Tested-by: René Engelhard <rene@debian.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-28  Balazs Varga  <balazs.varga991@gmail.com>  [00e13be1c3dd45597237f805a06b3e8a74187125]

        tdf#68113 sc autofilter: fix not empty button unchecks all entries
        
        Instead unchecks all entries, unchecks only empty entries.
        
        Change-Id: I6f0d6432151ad2c65871dc5f1dd206883994217a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115562
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-28  Miklos Vajna  <vmiklos@collabora.com>  [b24861a988fc2311cd873aa74d63afac9c5859ab]

        Replace magic numbers in SwContentFrame::UpdateAttr_()
        
        By using the same SwContentFrameInvFlags constants that
        SwContentFrame::SwClientNotify() already does.
        
        Change-Id: Ic22d53c886bb9d28d0250ed5e43d804417d516f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116271
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [f1d68d82ae5a2de18708bf71a93e4d4a42dfa45b]

        no need to allocate these on the heap
        
        and remove ByteEncoder because loplugin:unreffun
        complains about ByteEncoder::EncodeByte
        
        Change-Id: Iebc531fb7748cb9c6a83a8b4a574167a5aac58b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116257
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-28  Mark Hung  <marklh9@gmail.com>  [8a65d3e9ceb268f785c5b2b77e126bd62af567a3]

        vcl: handle fallback glyph offset for vertical writing.
        
        When GenericSalLayout::MoveGlyph() is called from
        MultiSalLayout::AdjustLayout(), new position is calculatd
        by adding glyph advances ( i.e. glyph items' m_nNewWidth ).
        
        To move the glyph, the moving offset should be calculated
        based on the corresponding position, i.e. m_nXOffset v.s.
        m_LinearPos.X().
        
        Change-Id: I912d499f49f69f68d8388bc8677e6b47bfb6f066
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115926
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [187136265d26c014e842550c2f1fc5997736e4fa]

        flatten EventList data a little
        
        no need to allocate the ListAction objects separately
        
        Change-Id: I02a591265c0da64d94a118b29bd0c4960d19a763
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116264
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c1dbb665a3eb7859164dbf83c245b7f450c9028]

        no need to allocate PrintFont separately
        
        Change-Id: I8bc213e096ad6ae83d88c548ff8685a872c5ea91
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116258
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [98a8d8bc15018576e1312493425d7bb3725be735]

        gtk4: reenable EntryTreeView
        
        Change-Id: If1b953f231199fe132783dafb0e26641b7b14d45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [d132982667d0e8112e7cf9f5cc39323ec7be5068]

        gtk4: continue to provide Paintable via cairo surface
        
        instead of squeezing through a GdkTexture and losing hidpi surfaces
        
        Change-Id: I1ee75ff804d1d769273e2f80335bfdf528ae8039
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116267
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [0fd545eed33e85544065a383e3beace5401e870e]

        no need to allocate these on the heap
        
        Change-Id: I6933260f589c67f463ee60572a31c52c6be7eb66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116262
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [211b13725152d3af49f28a88b3dc260c923377aa]

        TETextPortion can be allocated inside the vector
        
        Change-Id: Ib54b94f5dcb2a9cf422ef30db99926f200b749c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116261
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [cd023b8f8383aae3fbb053c40949843c8a50514b]

        no need to allocate ListenerMap on the heap
        
        it is a movable type
        
        Change-Id: I2b5c8524115016b53ec5cb28312ff4d749e27368
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116263
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd7787b6f0f082db320ebe7b29fc5333587b5d2e]

        no need to allocate these on the heap
        
        Change-Id: I0740f7194c589d6949a816f365cd54403be72118
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116260
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [832f04d1f78e54bb84c641c11cf90aa2f953fc17]

        IsDisposed->isDisposed in sc
        
        Change-Id: Ie08509df7481a9128c865f19d2b45694b19d9f38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116179
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [f682ff1b5502fc3c5f8003d57466795bf795d524]

        IsDisposed->isDisposed in dbaccess
        
        Change-Id: I7a113dc01f76d53126b414cf132404ed8ef8db4a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116180
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [a04bb13513ea64fef867365d6eb0264970d58182]

        installer-code: remove some unused or pointless subs
        
        of course just the very tip of the iceberg, but you gotta start
        somewhere…
        
        Change-Id: I24ef6a51ec70c70418368da54595637283055d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116255
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-27  Noel Grandin  <noel@peralex.com>  [cb7bf2ce168bc262d324e62888934cdf4113170d]

        VisualStudio 16.10 doesn't like this construction
        
        Change-Id: Idfef618b43735c48c9132d2fb932bc3bcb2ffe9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116250
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Miklos Vajna  <vmiklos@collabora.com>  [ff1f80e025a7c235e3960affe1b9db844c89c214]

        sw XHTML / reqif export, RTF markup of images: write objdata
        
        The native data is BMP, presentation data is not yet done.
        
        Change-Id: I30ef9f0c3b4dc7801e600ac751c32179372d5e4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116266
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [0344ee3f72fe6d155933b609d2963cf3f4bf4d7e]

        gtk4: old GtkImage can be new GtkImage or GtkPicture
        
        change to GtkPicture under some circumstances. GtkImage will
        force a square image so try and use GtkPicture for the non-icon
        case.
        
        The About dialog shows the need to use unscaled image if using
        GdkTexture.
        
        Change-Id: Iceb1e7dee5b53c93ceb432618fdda5650863029f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116256
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [816a181086e75506bca34797429057fca5f2b0d5]

        configure: drop --disable-neon
        
        Use --with-webdav instead, which supports neon, serf or no and is
        available since commit dcae0509135c2067635ae3cf84b05dc9fb3d2d02
        ("Build webdav based on serf if neon is disabled.") from 2014.
        
        Change-Id: I4b329b9c1d28e88961e86272a5554bfa4481f01e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116142
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-27  tushar  <tusharrai282@gmail.com>  [0643e5a3accc01e0ee7a2359ec283ced8d0cf0ab]

        tdf#135332 Return MAXROW/MAXCOL for rows/columns out of range.
        
        *Also change the number of rows to MAXROW in Row Header Control.
        
        Change-Id: Ie34361442a0944f62abbc9bb273a9efe72773c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115642
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [8596312d8f298cfddb6dda11a25669fb78372d4f]

        gtk4: reenable menubutton
        
        not really expected to work yet
        
        Change-Id: I27fe5ecd8f78017dd669aeba0c1d8db797e91e3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116237
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [356628a18e44574810ebad27dc2d499b718094bc]

        tdf#34724, tdf#91420: svl_qa_cppunit: Add unittest
        
        Change-Id: I81f784fb66b80ab0933047aa81d90aff1eec7971
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116246
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b80add7d54298b98cc3d38919fa30f44eb23d60]

        sw_uiwriter2: this is basically a export test
        
        Change-Id: I5b87f52ec4f905df1ae2e9175ac3807171614bdf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116244
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-27  László Németh  <nemeth@numbertext.org>  [48898a72066ff9982feafebb26708c4e779fd460]

        tdf#60382 sw xmloff: import/export tracked table/row deletion
        
        to OpenDocument format using
        
        <style:table-row-properties loext:text-changes-only="false"/>
        
        Rename also com::sun::star::text::TextTableRow::IsNotTracked
        to com::sun::star::text::TextTableRow::HasTextChangesOnly.
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "tdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: Iefb0d4095af0983fdd15697d5b80073d18d21bd7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116212
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-27  Justin Luth  <justin_luth@sil.org>  [f3e4c05ce6feaebebb269f1c984a92c1175061a4]

        tdf#94628: sw: allow setting for bullet style for outline paragraphs
        
        Since LO 7.0 commit cad788328ec6ef4b3071cf9002dfac12347562da
        allowed bullets in the outline, I think you also want to be able
        to set the character style, wouldn't you?
        
        In any case, isOutlineNumbering is basically a meaningless
        and inaccurate concept anyway, so just get rid of that
        ancient clause.
        
        Change-Id: I2e40a3749b4a18864585c309349ea0e4ba73a9da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115613
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6c23065efd223ae7041c8706f5106959057cd4c]

        no need to allocate this on the heap
        
        Change-Id: Ief47dc18f858d4f90a537622c06f3df8e9f72fff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116249
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [a76ae1c3d1076cbcb58d3fc27723e4eefffac0a3]

        no need to allocate Style objects separately
        
        Change-Id: I88e4642a81b18c41216784332cc4a37a3bde9d95
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116247
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [2d0eea0a79df9bc54e075c90ee7d6134b03250c0]

        we can search std::set without allocating on the heap
        
        we just need to add some overloads to UniquePtrValueLess
        
        Change-Id: I91c395393a2de609c8f442de605d1dd2098dfae0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116248
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Andrea Gelmini  <andrea.gelmini@gelma.net>  [01df224f574c5a7788df0f2aea3345166d6ce250]

        Fix typos
        
        Change-Id: I9a4ba6b6369da0bac489718230880b04912bd1d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116214
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [f3988265c906005fea1534fa382d90e14cfc211f]

        add missing xmlns:loext to example_sl-SI.xml
        
        added to example.xml by
        
        commit 71ee09947d5a71105d64fd225bb3672dfa7ce834
        Date:   Tue Sep 19 15:37:04 2017 +0200
        
            TSCP: add advanced classification dialog
        
        but not to example_sl-SI.xml
        
        Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116245
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [cef8d2d1ea9ac8709b343b0e9d269ab1cbc44a7e]

        gtk4: strip accelerator tag
        
        unclear yet if there's another way to do it
        
        Change-Id: Ic3355d45bb3bb73c446b576b9cc65204cd39d180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116238
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [5a0be5e55914d5aba197170894bfed1b6be8b876]

        no need to make copies here
        
        Change-Id: If3cd60bd48f640c353fd4c28449faed2cdcebdda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116243
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [9cc47eda70025c6bccfad1cfc45d30b7ecd2fc19]

        tdf#117957 WMF Fix failing tests on arm64
        
        So the issue is caused by floating numbers,
        On x86_64 it is:
        
          338.499728160392-445.269903703769
        
        on arm it is:
        
          338.499728160392-445.26990370377
        
        As in test files, we have two ellipses (which are made from small lines),
        which points rounds differently on different architectures
        
        Change-Id: I10efe80fea0944cf957e949c8c209c94fd588702
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116234
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-27  Balazs Varga  <balazs.varga991@gmail.com>  [6a2060cef22b19dbe04676c8c16776c4693b4dd8]

        tdf#141309 tdf#142215 OOXML import: fix double conversion in autofilter
        
        resulting missing selection of filtered time values
        and numbers ending with zeroes.
        
        No need to convert the filter values from string to
        number and back at OOXML import, because we'll do that later
        in the model by filtering with the formatted cell values.
        
        Follow-up to commit d5c2584bf36d21580db677b231c57f99f49aa2cb
        "Related: tdf#140968 avoid duplicated filter values".
        
        Change-Id: I75e5b2391624ff85a8ed545926ec519355a356bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115473
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec50b9e5eaec7c94df35617676077ef0d65cecc7]

        no need to allocate Sw2LinesPos separately on heap
        
        Change-Id: I39dec50f491a313ac188bb2f73073ecc32ebfc21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116240
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [1b82b81cd1f3377591068dea7b9a648b04370bbf]

        sw_ooxmlexport: just use exportonly here
        
        Change-Id: I37fe18528dbe821eb60c7b1d6c65039e2ae91b7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116236
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [0ce42c18e19396e66c70631f8a87072424a5d5c6]

        fix leaks in ScAcceptChgDlg
        
        Change-Id: Idaa946f06fdfdc1f908cff02cab542b64066763c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116241
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-27  Matt K  <mattkse@gmail.com>  [95eb088802562b75f8b299908160145c7e88d763]

        tdf#47065 Add new file open UI options and implement a new thread
        
        Add new UI options when opening a locked or non-writeable document
        to allow the user to be notified when such a document becomes editable
        .  If the user selects "Notify", then that document is added to a list
        of open documents to be checked by a thread every 60 seconds for
        read/write access and whether lock file is available/obtainable. If
        access is allowed for a document, then show UI dialog to the user
        asking to Reload that document.  If Reload is selected by the user
        then that document is reloaded with read/write access.  The checking
        thread is spawned only once no matter how many "Notify" documents
        there are.  The thread is spawned if not already running when a new
        "Notify" document is opened, and it terminates when all "Notify"
        documents have been closed or the application terminates.
        
        Also update badstatics clang plugin to ignore new global variables
        introduced.
        
        Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [ee1407608c0d228e4705215e9700af3200511cc8]

        sw_ooxmlexport14: simplify code
        
        Change-Id: I2e52a042b514e6724dbd282a41a4ca7f66981f2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116233
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [237eb44e0397f90c733c98f3680d63c0a9d7645e]

        gtk4: drop can't focus from GtkBox and GtkGrid
        
        it used to be that can-focus of true in a child with false in the
        parent allowed focus in the child, that's no longer true. We're
        already clearing can-focus of false from a widget if a child has
        can-focus but we build notebooks (especially) with separate .ui
        files each page so can't tell that there will be contents inserted.
        
        Plenty of ways to target just the case for notebook contents, but seems
        easiest to just clear can-focus of false from all GtkBoxes and GtkGrids.
        
        Change-Id: I460f3d5990a5df7b8b8e7d37ce592a5731794f31
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116226
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [8f91b089e9b011a4793e26151cbfa3c824ee3584]

        gtk4: apply 'border' to dialog content child widget if it exists
        
        and if it doesn't apply to the object itself
        
        Change-Id: If73e1e78ddc7945480bb2c2e59bf50350ba53e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116225
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Miklos Vajna  <vmiklos@collabora.com>  [fe32d1bd154e6ef93522d7ed18f1c2e88c0e14e8]

        Introduce SwContentFrameInvFlags to replace magic numbers in ...
        
        ... SwContentFrame::SwClientNotify()
        
        SwContentFrame::UpdateAttr_() is not yet updated to produce these.
        
        Change-Id: Iccb1a9a5cfea967dfd9ca68d25dd9dccb6cc6fe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116229
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [eeee3b18c22c4d5a2dbe4bd2b4f4e92fbd222011]

        expand frames horizontally to fit
        
        Change-Id: I2c2fc8a726c279583ef9aa3d51eebe7f28164684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116224
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Caolán McNamara  <caolanm@redhat.com>  [e6f07761615c16bc0798ece6c94493fea1a1e9d6]

        resave with latest glade
        
        Change-Id: I91a3836e02cf3ed1cfdcea93f8812dcecc43afcb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116223
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-27  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [46e924ac80a4abd7f48bd2df34ea4c38738fd745]

        tdf#139196 - Import/export macros using utf-8 including BOM
        
        Moved import logic to a local function, and during the import of a *.bas
        file, check if it starts with BOM in order to detect the correct
        charset. If there is no BOM, use the default charset of the system, since
        after the change in 178adcd8459af63ddb48927207baa5b4efbfda12, all the
        newly created *.bas files have a BOM and are written using the utf-8
        charset.
        
        Change-Id: Iefdecb5762d896ce3e52fd6d212de42cf417ddac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116186
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-05-27  Stephan Bergmann  <sbergman@redhat.com>  [4141febf7984c938b67f93d7c568d908d2ebfc45]

        osl::Module::loadRelative against symbol from executable is unreliable
        
        It turns out that c8976bdfdfa361fec9e1e5ff342094e409981fad "tdf#137208 Assume
        that dladdr provides an absolute pathname" is wrong with glibc if the requested
        address is in the executable itself, not in a dso.  In that case, glibc
        just returns argv[0] as Dl_info::dli_fname (see
        <https://sourceware.org/git/?p=glibc.git;a=commit;h=b8565e7817d7c6afd8eac804867b88c9bad1c9f1>
        "Fill in correct information if symbol is in main program"), which need not be
        absolute.
        
        With
        
        > cp workdir/LinkTarget/Executable/fftester instdir/program/
        
        that causes
        
        > LD_LIBRARY_PATH=`pwd`/instdir/program instdir/program/fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm
        
        to crash (cf. comment at
        <https://gerrit.libreoffice.org/c/core/+/111004/2#message-239c434e95f6fee5f5232e32f731595f56116aa3>
        "tdf#137208 Assume that dladdr provides an absolute pathname"):  The call to
        osl::Module::loadRelative dlopen's instdir/program/libsdlo.so with a
        relative pathname containing at least one slash, which in turn causes dladdr
        with an address from libdlso.so to also return a relative pathname, which
        causes osl_getModuleURLFromAddress on such an address to fail, which causes the
        CGMPointer ctor in sd/source/filter/cgm/sdcgmfilter.cxx to set m_pPointer to
        null, causing SIGSEGV when TestImportCGM dereferences it.
        
        (Whereas e.g.
        
        > (cd instdir/program && PATH= LD_LIBRARY_PATH=`pwd` fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm)
        
        would dlopen libsdlo.so with a relative pathname consisting just of a filename
        without a slash, so dlopen would search for the library, record its absolute
        pathname and return that from dladdr, and the program would have worked.)
        
        Change-Id: Ifa23124090275a397d4a9b0672ab845af23cf4d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116194
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-27  Miklos Vajna  <vmiklos@collabora.com>  [0b38c00f4ad143455fc92b3aff278a153ad05b00]

        sw: rework to avoid the DECLARE_ODFIMPORT_TEST macro
        
        See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd
        (CppunitTest_sw_rtfimport: convert one testcase to use
        CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.
        
        Change-Id: I7a6de527c28c543d7b622398dab406e2bfb80805
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116216
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-27  Jan-Marek Glogowski  <glogow@fbihome.de>  [61ebe104cd0cdbf19d5cbdb4d50cab8e0f88beb3]

        cross-toolset: explicitly add Python
        
        It's needed for the build and it was at least missing on Windows
        when building without galleries.
        
        Change-Id: Ibfcc6f0159e17d69755b230767b64b03dc5537a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116227
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [033fdd5aab3c44af26c7b53393afd2a7a8a056cd]

        Cleanup Library_vcl.mk
        
        Merge a few duplicate calls and generally prefer inline $(if ..)
        over extra ifn?eq lines.
        
        There are minimal changes:
        * Move X11 settings from !DISABLE_GUI to USING_X11
        * Move the vcl_opengl_denylist from WNT+!DISABLE_GUI to WNT only
        * SkiaHelper compiles to "isVCLSkiaEnabled() { return false; }"
          without the enabled feature, so move code to the general list.
        * Move the SKIA library to !DISABLE_GUI, where the code is
        * Move PDFium source + external to generic lists
        * "extract" common ${vcl_headless_freetype_libs}
        
        Change-Id: I9836ab3c1791b6406984ec4d4c27a8924faffdca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116220
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [1d895208e0dc03185b4ff6f5cad4e0a4833a74c3]

        configure: internal OpenLDAP depends on NSS
        
        So we need either NSS or a system OpenLDAP.
        Also add the $test_openldap flag.
        
        Change-Id: I134d1ed3a0a9654e264ccc66cdbe993a355620cb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116109
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [c22f23556d03e1ac0c8be7a79597c822b7e29fc9]

        gbuild: Handle glxtest + vclmain usage via macros
        
        Use a macro to do the same checks for all Executable with glxtest
        or vclmain usage. Both are static libraries, so every user has the
        same dependencies. Introduces:
        
        * gb_Executable_use_vclmain
        * gb_Executable_use_glxtest
        
        Change-Id: Ib80b4e7c6f5078d47ad8f1ec5708a7174415f705
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116145
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [ca242dfefa03016a9b0f675cb91b4605ce80875d]

        gtk[3|4] gtk_widget_get_root returns null when no root
        
        unlike gtk_widget_get_toplevel which returns itself if that is the
        case
        
        Change-Id: If977440265bd8ae2c892ee5d52091ebf16ad03cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116218
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [7768abbf86731a1105fcebe7c2557cb9ac5ba86a]

        gtk4: add parent-less widgets to default container
        
        Change-Id: Ia0c06db5a4f1c4ce453c424835d032ebb021f40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116217
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [e38db47fdb50db812d5f0088a5fd394bdd98da38]

        gtk4: wrap gtk_buildable_set_name/GtkBuildableIface::set_id
        
        Change-Id: Ia19179bc5879218495184dcec80fd96eb375bc00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116209
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [9b547bb233d13ec7db4f0e7962f9c8702c37b75c]

        gtk4: wrap gtk_buildable_get_name/gtk_buildable_get_buildable_id
        
        Change-Id: Iadafc7a7b4eb49bd15c22f006955003554cd7079
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116208
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [089e65a157ff252e4d404adf3e0f580a6617d31f]

        configure: Remove kde5 compatibility option
        
        Change-Id: Idce493e5f5ac045f7e977b4073152c2fe2668b56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116111
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-26  Attila Szűcs  <szucs.attila3@nisz.hu>  [759103fd65f82fc131679eba0de05f2ddc7294c8]

        tdf#126541 XLSX import: fix View grid lines
        
        It was not possible to enable the disabled grid
        with View->View grid lines, as intended, because
        document-level grid visibility was set to the
        visibility of the actual sheet's grid (which already
        imported correctly) instead of keeping its default true
        value.
        
        Note: document-level or global grid visibility is
        unknown for XLSX, but handled by Writer/ODS, see
        Tools->Options->Calc->View->Grid lines.
        
        Co-authored-by: Tibor Nagy (NISZ)
        
        Change-Id: Iccab3e2b9f617cdcd678071f73c7c2d6db0bc161
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116096
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [b5af95a4d5c59094aa9fbdf35e49962f605f8dee]

        log what page id is missing if this happens
        
        Change-Id: Ie279350446ef1892d5bb145e58b9f0d9dba683f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116206
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [7f63c6b2f614710d6bb9c3d2e2db94b5e37c7417]

        gtk4: "focus" signal is gone
        
        its not clear yet if there's another way to do what we want here
        
        Change-Id: Id9e54a481ac33038d605b0488315e73fd5b5a310
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116205
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [b56f32b235124f8afa2942cd97ebe2f7d434fef7]

        gtk4: reenable Notebook
        
        Change-Id: I5342e5ef35f9d270d8ac51c3d696beddc8b67529
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116203
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Miklos Vajna  <vmiklos@collabora.com>  [9c787b1e5ad517476a26fc9735ac63b54bfa28a4]

        comphelper: fix the "console" use-case of ProfileZone
        
        m_nCreateTime was changed to NS, nEndTime was still MS, comparing the
        two is not a great idea.
        
        Change-Id: I102990838d1e3d543a356b5ad2d3f68ce1d20623
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116210
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-26  Miklos Vajna  <vmiklos@collabora.com>  [0e459bb3eb840ac1cab14c070973fb3b79bc13d8]

        sw XHTML / reqif export, RTF markup of images: write WMF in \pict
        
        Some consumers (e.g. IBM Doors) can only consume the RTF snippet if it's
        an OLE object and can't deal with plain images.
        
        Wrap \pict inside \object and unconditionally use WMF as the RTF-level
        preview format. The actual \objdata is not yet written.
        
        Change-Id: I203fcd8709b25a4dd543047bd804af8181df9940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116207
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [f75549b4169f327faca88d5ce9d544bc6885bef1]

        don't need always-show-image if there's just an image and no text
        
        Change-Id: Ic3a1aad525af39b723e71f579fba40157cb15ac7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116202
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [f3f6b68629656d488550fb82898e40fcad61c271]

        gtk4: restore Container
        
        Change-Id: Ide82777fadbee2c644c3a19d418c3683f6ff2c11
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116201
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [05064808c90ce5598c3cfe47dd284388908d4553]

        gtk4: strip GtkLinkButton xalign
        
        Change-Id: I44065da82f577e226ee1c52f858917a1d825d9ce
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116200
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [60b98189281524c85b559ee3b6adc1381b793b9d]

        tdf137314 Add margin to CppunitTest assertions
        
        The test had multiple failures on Windows with:
        
        oox/qa/unit/vml.cxx(79) : error : Assertion
        Test name: tdf137314_vml_rotation_unit_fd::TestBody
        equality assertion failed
        - Expected: 1490
        - Actual  : 1491
        
        So add a 1px margin to all value checks.
        
        Change-Id: I70298db253299a57cc37eed482c0816d902fbeab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116192
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [0d3dd9d9f6f0e6236c8db8ebdea44c78854639a8]

        tdf#142467 crash on calling 'getInfoHelper' in final class
        
        IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when
        CandleStickChartType is final for unknown reasons. I see this with
        gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora
        libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem.
        
         #1  0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549
         #2  0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219
        
        Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116196
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [05ffc50f78e9d44c4beeee312a59f677f26defff]

        tdf#100122: svl_qa_cppunit: Add unittest
        
        Change-Id: Ie0a7ea6ae08ea96b04019148f80ee94ef22ef1bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116187
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-26  Xisco Fauli  <xiscofauli@libreoffice.org>  [70dfe58b8b45a7221a1f6e335d0d4afcf0c1c026]

        tdf#52510: svl_qa_cppunit: Add unittest
        
        Change-Id: I18a7000104add044ba59381c201cb5aff9fb459d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116184
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [ea4b99c294aa4ad975a8374f317b09f743aa173e]

        fix another leak in SwInsTableDlg
        
        Change-Id: I743a3231ef62e30242e54315bc3d3183f691f13d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116191
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [965bc6843e24e45165bab810c34b672a97a99630]

        fix callgrind job by providing dummy privacy-url
        
        Change-Id: I786c14c19f1ac74e424be869771440c55be08877

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [2e30d16bb945042b5c033dc9bdba690ee4a08fed]

        Refactor module media item handling
        
        Move common functionality into svx::MediaShellHelpers.
        
        Change-Id: I6f5db59bdcff7cad00a64e76f6aad7b8ecb4ffa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116126
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [456b87b6b188984579c1d809aab805f6f324ea53]

        loplugin:includeform (clang-cl)
        
        Change-Id: I12632b72c8e4e95bef24c8c26bee5887f9695d66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116143
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [e608a95752692dfa1195917d4b252731bd4632b5]

        fix leak in SvxConfigPage
        
        Change-Id: I6b95d33cfbad455692c8047968a2581fe4610260
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [085c97c986336bc622d6b3d72e6a587e1ae4b844]

        fix leak in SfxAutoRedactDialog
        
        Change-Id: I5ebfe5eba77de3380e991ced26f396821613b7f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116189
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [90da191bc937eedd2a7fda4ac41fbe6a53356842]

        fix leak in SwInsTableDlg
        
        Change-Id: I1d4b4f5098eeec7b0042f3ffd457566ecb3e31de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116188
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [c8ec727f12bf9a43f22983a2c7ff1189461cc250]

        gtk4: convert old default invisibility to explicit invisibility
        
        Change-Id: I7aeab1a0857ffdf3990ecf69f5de1f6041fa562e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116181
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [4d3038415a2e69ec4369f60fe14d0acab60ded6a]

        gtk4: reenable TreeView
        
        Change-Id: I9797e789b9af1985b1a78e00e68a23b7fd048d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116175
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Miklos Vajna  <vmiklos@collabora.com>  [2f21e4f357ec60450df84ddd858c3cf0a4711b02]

        tdf#139915 DOCX import: fix anchored obj position with to-char and TEXT_LINE
        
        There were multiple problems here:
        
        - commit 8f1a1092d47947847e1d888b0284e8364c663d1f (tdf#97371 DOCX
        import: fix text covered by shape, 2016-01-28) disabled to-char
        anchoring for TEXT_LINE (e.g. "alignment top, relative to line") because
        changing the anchor type of a TextBox could not be changed, but this has
        been implemented in sw/ in the meantime, so it can be dropped
        
        - Now that the anchor type is to-char, we can set the vertical relation
        to TEXT_LINE, but Word's positive value is "below line", and ours mean
        "towards the top of the page, from the bottom of the line", so we need
        to drop the workaround of commit
        3303a4c5f21874453e634d84408c50e7a0055a4d (tdf#135153 DOCX import: avoid
        line-of-text relation with to-para anchoring, 2021-01-18)
        
        Once these are in place, we can fix the remaining problem by inverting
        the vertical position of the shape, which instantly fixes the
        overlapping textboxes in the bugdoc.
        
        Change-Id: I895abb76d3bd3bbe3a84e5c27a77df722b96226a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116182
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-26  Stephan Bergmann  <sbergman@redhat.com>  [9ac3b599e65669380ab346cb2bb135a6edc3273a]

        Fix documentation comment
        
        Change-Id: If62135c82d8ab8faba0681302accf8f328e2eb3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116148
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [62946de9671d718d4033cd2662107020e65368b3]

        fix leak in SvxLineTabDialog
        
        Change-Id: I4cbf0990fcc8db63f1160f1997d425c5681c47c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116150
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [d86889978d7caa4ac82eb4ede226c7f2561c8607]

        fix leak in ScAcceptChgDlg
        
        Change-Id: I51636d04389c8493377fe906314ef5d8f5c372d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116140
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [20e9f32c7d93dc33e58ab991dd4cc8f83ca529d0]

        fix also the Win64 tinderboxes
        
        they were using manual configuration instead of the distro-configs
        
        Change-Id: I82a690986e24e704c66297c9bc4c3d3d1e70b636

2021-05-26  Rafael Lima  <rafael.palma.lima@gmail.com>  [709f720a84d091ce39c07127686353661169637f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 96e26682870d3032dc0cccc6ed0a580f22111998
          - Fix SF_UI ShowProgressBar description
            
            Change-Id: Ib8b0b89511c1bb04acb7e79064ae5c9d8678b71d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115970
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [6f39a29d93b533c5020e8bad0f3518f1b4fa928f]

        gtk4: GtkSpinButton has a GtkText not a GtkEntry now
        
        so can't call gtk_entry_set_icon_from_icon_name on it
        
        Change-Id: I596a37ec935240b9ed92361e428e398010911b28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116174
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [294eaac1113aa24ac65c254058007a9a489b28e6]

        fix leak in BuildMultiPortion
        
        Change-Id: I267d59bdc8ac2f17d223d0345c4bcb4ea40a8704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116149
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [284eb63624d2822f12e9216171da3c479e95f2d9]

        fix leak of SwCompareLine in CompareData
        
        (*) store the SwCompareLine as a vector, SwCompareLine contains a
            single pointer, no need to allocate separately on heap
        (*) which means we need to convert SwCompareLine::m_rNode to
            m_pNode in order that SwCompareLine can have an assignment operator
        
        Change-Id: Idafba6f6384f36c9d048169e793db2d50c6d8bc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116151
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [31589c106fe83a74560adcc6396d70687ca352cb]

        fix leak in SwRedlineAcceptDlg
        
        Change-Id: I905d394db9339efda77e4f014e795c4f2d5f4584
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116138
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [b161daeccf299afefeaf319ee9b6f50e6f888eff]

        configure: merge extra test for $enable_cups
        
        Change-Id: Ic98a6db70355aa24e29590bb9cb1416c15852090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116144
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Gülşah Köse  <gulsah.kose@collabora.com>  [1cd26a9ab64482daf4de08f5bb7730d0a991bbce]

        tdf#96061 Unset the highlight property
        
        When we have highlight property on specific part of the text
        the following texts were highligthing. To prevent this we unset the
        highlight property when we have not highlight property anymore.
        
        Change-Id: I802cde1c784afe47201a9ba4f41827dd0c705035
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115800
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-26  Jan-Marek Glogowski  <glogow@fbihome.de>  [39276660f862b8d534db971d53490450f8ec5d9e]

        Fix DISABLE_DYNLOADING unused variable
        
        Change-Id: Ie8305364971f324bd834ae6bec851637ca60b9e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116118
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [c37d81ac2765e14f1dfc6124082ed62909422c31]

        supress leak checking in JavaVM
        
        Change-Id: I82cb41518524949bbd578778724b92d9ebcecad4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116139
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [aad00c7279edbe8bb59394d59db28c2a8ec47d37]

        ofz#34602 missing a component
        
        Change-Id: Ib2f281579af58f536f1291866c9990e8fc9e8cef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116146
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Caolán McNamara  <caolanm@redhat.com>  [c57959a8efadf5c6a4a6c9a4f1fa4e482a45919c]

        gtk4: reenable Image
        
        this is possibly wrong wrt scaling/hidpi, something of a stopgap
        for now anyway I feel
        
        Change-Id: Ia0e4bbdf760d7577c304f489795005f7252eb57b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116131
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [8ee7e8dfa9fbbd2207764fc8df05bbeaf09e8a0b]

        fix jenkins tinderboxes config after 15ab55c092e0b474827abe104b73c5bfab6ef28c
        
        Change-Id: I108536fbcd557ed899e1b6fda2316c9d89249681

2021-05-26  Miklos Vajna  <vmiklos@collabora.com>  [1eac49c595505dbadeac3db4ec7cd686afca6d87]

        tdf#115088 convert UITest to CppunitTest
        
        So that when it fails, it's easier to debug because it's in-process.
        
        Change-Id: Ia7d12291b25304967a22e546b12803864a713541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116127
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-26  Szabolcs Toth  <toth.szabolcs@nisz.hu>  [f2c9da1ef662d10726a2dc709b46722ec7d4a016]

        tdf#142231 sc odf: fix export of single date filter value
        
        by export the sting value of the filter condition, if its
        filter by date.
        
        Change-Id: I537fbd43810c78c0834480c9f1a480481aedd742
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115775
        Tested-by: Balazs Varga <varga.balazs3@nisz.hu>
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-05-26  Gülşah Köse  <gulsah.kose@collabora.com>  [350d40417fe2cb56e16116f12216d08b9f2705b0]

        Seperate SvxBackgroundColorItem from SvxColorItem
        
        SvxBackgroundColorItem derivated from SfxPoolItem instead of
        SvxColorItem.
        
        Casting is common usage to control if object is this or not.
        When we can cast SvxBackgroundColorItem to SvxColorItem we can not
        seperate them anymore.
        
        eg: Char color is a SvxColorItem and char background color is a
        SvxBackgroundColorItem. They can be hold together and we should
        understand they are different types.
        
        Change-Id: I7b1879a1b00de26c0b8a2d9f8d658aa3aef75ecb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116135
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-26  Stephan Bergmann  <sbergman@redhat.com>  [3b3ba7065acd3ba783e56b568d67ace7dc352371]

        Improve error diagnostic
        
        Change-Id: I1d7b82da3d0597aa6c5ffb251b9ad08bf464d2e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116136
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [56d7c40e87076fbce0a402dc56ed5a3d536c36a9]

        CoreToPixel should take a SwRect argument
        
        Change-Id: Idbed2a8fc6b4bc289c3bb0e761931f0b3d672620
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116121
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Noel Grandin  <noel.grandin@collabora.co.uk>  [399149155cf4f882541848ea53bfa5c9806b23f8]

        make SwRect(Rectangle) constructor explicit
        
        Change-Id: I715aa9499598c483ccf907f829c9ba3540edf216
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116120
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-26  Stephan Bergmann  <sbergman@redhat.com>  [581f12c0bdfb718379c16bef01d71ee9e45a5b5a]

        Replace a use of select with poll
        
        ...to avoid undefined behavior with file descriptors >= FD_SETSIZE (cf.
        0a126b4c661d65860fd2de92f8cc49bdb65a957c "Deprecate osl_demultiplexSocketEvents
        et al")
        
        Change-Id: I168072b50efc5d50ee3767d0b56be4a8ffa12924
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116119
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d4f5299fd2806d8f5dcd467742effeaa0dee8863]

        remove obsolete/duplicated entries from openoffice.lst.in
        
        The xml configuration related stuff is no longer (since 2013, with
        89ac3c4acae1f0ffe3e96933d3449749ddf86847) done in installer code, but by
        postprocess/CustomTarget_registry.mk
        
        openoffice.lst is only used for package generation itself, and by
        extension for the replacement of values used in scp2 (those are replaced
        by "replace_all_ziplistvariables_in_file" (for the ${NAME} style ones) in
        solenv/bin/modules/installer/scpzipfiles.pm and (for the <name> style) by
        replace_setup_variables in solenv/bin/modules/installer/scriptitems.pm
        
        the files that would be created by scp2 in case for an installation set
        (e.g versionrc, bootstraprc) are created by
        instsetoo_native/CustomTarget_setup.mk for plain instdir
        
        Change-Id: I761ea25aa98bbdcc310836257e288322fbfc437b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116128
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [15ab55c092e0b474827abe104b73c5bfab6ef28c]

        add privacy URL to crashreport dialog & updatecheck tab in options
        
        Change-Id: I35cda87c35876469bf581be223bc608e29f07b09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116105
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-26  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [4d800dd7b58291386850d69570d027192419c5a0]

        clang-format crashreportdlg
        
        Change-Id: I58031cafaa9481ba6e8d77a7106485d8274e5bc6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116104
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-25  scito  <info@scito.ch>  [0563867d60ad477235bb5595c895a4f1e06a53b1]

        tdf#116413 keep AttachNewFormulaCell methods together
        
        Add public block instead of moving method to a public block.
        This was suggested in
        https://gerrit.libreoffice.org/c/core/+/114641/11/sc/inc/column.hxx#724
        
        Change-Id: I30fd8f3348cdcc047d5b0d8856920b6e4e4a0c63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116076
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-25  Eike Rathke  <erack@redhat.com>  [807f3508c9319d7f94820ea1282e306594418fce]

        Related: tdf#81757 Do not even try to re-enter ScDocShell::Do*Recalc()
        
        That happened when loading bug doc
        https://bugs.documentfoundation.org/attachment.cgi?id=103462
        where form selection events fire asynchronous recalcul() and
        BASIC Main also calls recalcul.
        
        Change-Id: Ic27fb340c7b5019453723c7cabe2122905d400f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116133
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [178adcd8459af63ddb48927207baa5b4efbfda12]

        tdf#139196 - Import/export macros using utf-8 including BOM
        
        In addition, try to detect the charset during the import of a *.bas
        file.
        
        Change-Id: I0dfe7f1b5349db409d90ed92b2e19c9946ae50cc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116004
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [60d216ed1a5ad74a93edfb288206ce9ae20380a4]

        ofz#34602 missing a component
        
        Change-Id: Id069c3718a632046fa9df59ee145e0c904aaf718
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116129
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [0eecca25109472586ae0380f9290bec7503460e6]

        ofz#34601 teardown crash under oss-fuzz
        
        Change-Id: Icbb1500a85f956c8100878d6a0bef30b98440c32
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116114
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [62be589df821687b36188e977b163fd58599c9ff]

        Don't ignore GCC warnings for static builds
        
        Instead simply (and correctly) test the function pointers in the
        static build case.
        
        Change-Id: I01b3397f40671464b1d2cb472447d8530b996d21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116117
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [70e4c65058a76131235cd04b64231c403cbe74f3]

        Install GDB pretty printers into cross-toolset
        
        Change-Id: Id42dd694514e104d03c649a19788b5c192ec35a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116116
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [a2a98f62182561444d7841f0908d7423ab595675]

        fix some crypto leaks
        
        Change-Id: I8f0eddd5ec82200dca374c2191ed5ac28c66089a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116100
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [3ed71a09af4de19ac00b3b944b8db667e6613c92]

        configure: Replace tabs with spaces
        
        Change-Id: I417c734484481223f1779e0c555b4f3e16e10b23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116112
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Stephan Bergmann  <sbergman@redhat.com>  [81fdfa4dbfaaae322da5c3896f1f46aa6606ce14]

        Add forgotten io/Executable_io-testconnection.mk
        
        ...missing from ef88aa5e7400769c0a17c28e66b1ee957c2f667e "Resurrect io
        testconnection executable"
        
        Change-Id: I4a41088f1c27cfbc1275a9c00f8c59ec60898ec2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116106
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [42a99a175581936b45d1c8d752b853c9ffa6da9b]

        configure: Add gen to VCLplugs output
        
        And move all the output handling into a single place.
        
        Change-Id: Ia75440fc12a435b92239d7ec144be3d58e45d7d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116110
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Rafael Lima  <rafael.palma.lima@gmail.com>  [2d2eb0d4f4bd099368ed6147ce4fa486a5ab86f1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 0251fd88ce51f96284f471ad4adbc67fd468aef9
          - Python support in SF_Exception help page
            
            Change-Id: I9100e1b61aca23fbb104c449272da95bd60fd813
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115521
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [58d5f74a7b8634919d4842e623c582c570997952]

        postgres: fix internal linking with WITH_GSSAPI
        
        Change-Id: If5a741cfe5863d0cad09463ba7e958ac0f3bb24d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116108
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Jan-Marek Glogowski  <glogow@fbihome.de>  [29d4e83313de5ac75712f7598dc341664601d6cf]

        gbuild: make pre_BuildTools.mk better readable
        
        Change-Id: I6c4e35fcfaf853c83f91b505e9b6308b844c37ca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116107
        Tested-by: Jenkins
        Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [2b838b3b6aa5a014591e86b1736f82908076ff65]

        tdf#142479 on 'return' select the entry the cursor is in before calling Select
        
        Change-Id: Ic11f8a12c93d1999dd6fbe555b9823660eb703d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116101
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Stephan Bergmann  <sbergman@redhat.com>  [ef88aa5e7400769c0a17c28e66b1ee957c2f667e]

        Resurrect io testconnection executable
        
        ...which appears to be the only code that exercises osl's socket (rather than
        named pipe) connections, so lets have that available at least for manual
        execution.
        
        Addresses various compiler and loplugin warnings, and extends a wait time to
        more reliably have the MyThread instance already accept when the second accept
        (on the main thread) is done.
        
        Change-Id: I761d747b08ab45f1ac03dad8b4197fae63228e16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116103
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-25  Tibor Nagy  <nagy.tibor2@nisz.hu>  [ecf48b2d4f3e54dbb2c1e295120d73e7b7a11338]

        tdf#131390 PPTX: fix custom slide show is not imported.
        
        Change-Id: I62e1bfaae23d1b18e71a2c16651d01144a26907c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115475
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [63ce1ca6d7c802ab68295cf2364840959c829557]

        gtk[3|4] reimplement ImmobilizedViewport without access to opaque GtkViewport
        
        Change-Id: Ia7c15c57d399a05f8c94b739a2d64b1cb16735bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116091
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [c55e7bd903d4879acd8c982874effb8fca8bf103]

        upgrade to Expat 2.4.1
        
        drop ubsan patch in favour of fix applied as
        https://github.com/libexpat/libexpat/pull/398
        
        Change-Id: I59eb9e24206b9a4cf323b7f7d48d8df0792a1c46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116092
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [f6083a5d5c5513af63a43d58da5f3cdeb7597861]

        gtk4: enable some more working dialogs
        
        Change-Id: Ia6c5137ca09629919d593f636eaebb5a28a1aa05
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116095
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Caolán McNamara  <caolanm@redhat.com>  [7b2b740ae59a8bc8c2b0d611d2907119adda5ed9]

        gtk[3|4] finish rename to immobilized
        
        Change-Id: I829ad504b791894259b94c8d015795a0dedce449
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116088
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [aba5d639c4b674d7fd1771bf553518913cec4499]

        fix leak in toolkit test
        
        Change-Id: I6d3aa0fca6f48145c9c3b4e7d41a486fae026f06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116099
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-25  Szabolcs Toth  <toth.szabolcs@nisz.hu>  [b2190523e0b226bcae19cc8c3ce8a83855c7f009]

        tdf#141644 OOXML shape import: fix upright text rotate angle
        
        Text rotate angle was not imported correctly with
        "upright" setting, e.g. resulting horizontal text
        in shapes of XLSX documents instead of vertical.
        
        Change-Id: I2ad9ba3465278220e64123c4400acff4125310d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115777
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-25  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [4c1bab94d7c113f2fcb5458809fe8ec0683be951]

        tdf#142257 Replace Ctrl+[ / ] shortcuts for Hungarian
        
        Had to remove secondary keys for full effect.
        Those made little sense anyways.
        
        For text document this uniformly sets the Ctrl-Shift+,. too
        unlike Word which goes with Ctrl+Shift+8 / 9 but that's
        harder to reach IMHO so I chose not use that for now.
        
        Change-Id: Ib49823afcf405ed5ed4a2cf6ef4d2836f7b0747e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115772
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-25  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [0e6d963fbca16f98a3dbb6ef2fee3736a89d055b]

        tdf#138141 sw: fix textbox z-order
        
        Textboxes are implemented as loosely connected
        shape-text frame pairs. Missing synchronization
        of their z-orders resulted e.g invisible or
        only partially visible textbox content using
        Arrange options with textboxes (see in local menu
        or on Drawing Object Properties toolbar).
        
        Note: because it's not possible to send frames
        to the background, Arrange->To Background hasn't
        supported, so likely it's worth to remove that
        option later from local menu of textboxes.
        
        Change-Id: I1aa50903ba55dd5b9e72ef203c4e30218bee68fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115227
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-25  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b2f7187e04a6b6c6183b42230a0119569f069dcf]

        tdf#118129 - return only the caption property of the frame
        
        Change-Id: I3dc875d54c49f233e2784dcd778c2b6fc42e59cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108958
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-25  Stephan Bergmann  <sbergman@redhat.com>  [0a126b4c661d65860fd2de92f8cc49bdb65a957c]

        Deprecate osl_demultiplexSocketEvents et al
        
        The oslSocketSet/osl_*SocketSet/osl_demultiplexSocketEvents functionality is
        based on the POSIX fd_set/FD_*/select functionality, which suffers from the
        issue that it has undefined behavior for file descriptors with numerical values
        greater than or equal to FD_SETSIZE.  (And this can be a real issue e.g. on
        Linux, where tools::extendApplicationEnvironment in
        tools/source/misc/extendapplicationenvironment.cxx bumps the soft RLIMIT_NOFILE
        to the hard limit---so that file descriptors can likely have large values---,
        but where the GNU C library sets FD_SETSIZE to only 1024 and ignores larger
        descriptors.)
        
        This functionality is unused at least by LO itself, and also likely unused by
        third-party code.  So instead of fixing the Unix-based implementation in
        sal/osl/unx/socket.cxx (by e.g. switching it from select to poll), just mark the
        functionality as deprecated (with the option of eventually removing the
        functionality completely from sal/osl/{unx,w32}/socket.cxx, leaving just stubs
        in sal/osl/all/compat.cxx).
        
        Change-Id: I2b97f8a37b45f298da9328660006f3c14361c9a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116089
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [5c79032077d387053c62829d62518695f68555c1]

        fix leaks in loading xmlscript
        
        Change-Id: I18e663a6da34ef34630272819420ead6f3b8389d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116087
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-25  Vasily Melenchuk  <vasily.melenchuk@cib.de>  [a4e7df83fcac6c68f110f89f41d5eb623038410e]

        tdf#132752: docx import: improvements for first line indent in lists
        
        As far as I see, Word is using lists with id=0 and no list definitions
        to reset list numbering used in this paragraph. At the same time Word
        is still using some of default list properties. For example in this
        scenario parent style has defined first line indent, but in paragrath
        it is overwritten by "not existing" list=0 without definitions.
        
        To this moment I know about only first line indent behavior, but
        probably some other properties are also affected.
        
        Change-Id: I344c907bb7a7b83a91f5727e13ad184fb44137b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115795
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-25  Noel Grandin  <noel.grandin@collabora.co.uk>  [4632f935951584826d18f04939cf6c809fd370cc]

        fix leak in CppunitTest_dbaccess_macros_test
        
        Change-Id: I722ea80688f19cc7f5d60cf3fa08f42dc6b35a16
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116090
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-25  Regina Henschel  <rb.henschel@t-online.de>  [a312837a1a4d0b9628d5c587c8ab5ec68179a051]

        tdf#137314 apply conversion from vml angle unit 'fd'
        
        Fixes wrong rotation in tdf#109129 and tdf#142432 too, but they have
        further, unrelated errors.
        
        Change-Id: I7bd56876bb42b261fe425f80cf9beb639c3ac276
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116078
        Tested-by: Jenkins
        Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

2021-05-25  Miklos Vajna  <vmiklos@collabora.com>  [76ae0359f35baeb4f8adf1d121c0f974c9024997]

        sw: prefix members of SwApplet_Impl, SwFltAnchor, SwFltControlStack and ...
        
        ... SwFltRedline
        
        See tdf#94879 for motivation.
        
        Change-Id: Ib70ed34b46f68650fbb3f1fa01cb2232a1909fa8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116080
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-25  Andrea Gelmini  <andrea.gelmini@gelma.net>  [a02d9e8de07de4ab9f586f82aed7a2e0413520cd]

        Fix typo
        
        Change-Id: Ie75d4521aabc42cc57cccec5f77ec9147aca180d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116074
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-05-25  Jun NOGATA  <nogajun@gmail.com>  [02181b90af46a4736502318a36a5ca8630de09a1]

        Removed 1/2, 1/4, 3/4, and 0.5 from autocorr/lang/ja/DocumentList.xml
        
          Reason
          * The character such as a ½ are not used in Japan
             * Many people complained that the date is converted by itself
               http://www.fujisekkei.sakura.ne.jp/ooo/?p=435
             * In a survey, many people said they wanted it removed
               https://twitter.com/LibreOffice_Ja/status/1345602562678931457
          * Can be substituted by typing :1/2:
        
        Change-Id: Ifab7fcc9f164f1db2c3546eaf8e9ae40271c0455
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116011
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [08e99279226206db8ce83cdebc4cf2994739e90b]

        gtk4: restore collapse/undo_collapse for calc cell reference dialogs
        
        hide the entire titlebar for now, maybe we should just hide the
        action widgets and keep the titlebar.
        
        Change-Id: I81667ac0d5edbf4f5c7e12909672fa0de84c059a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116071
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [811c9ca5747c8144ffa4ff327d0e4238f4197033]

        tdf#100834: svl_qa_cppunit: Add unittest
        
        Change-Id: I14896935a4735d3719b385e8e7b70094e3d68904
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116067
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [ccbd6b4592cbc688122feafda64b10353da7264c]

        tdf#100755: svl_qa_cppunit: Add unittest
        
        Change-Id: I350148d788ff1bf9dd1c5ccf97aeaad04f975634
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116062
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-24  Julien Nabet  <serval2412@yahoo.fr>  [706d423bb12c79f0e6c71b7e38d092d1bdf1c259]

        Teach ScOutlineCollection to return an iterator when calling erase, then use it
        
        Hoping C++11 erase method std::map which returns an iterator is now known
        for compiler of every env.
        
        Change-Id: Ie4f87ce234228209257f7025e197fdf53ea7e69d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116066
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [dc657964f1674c7ba36c3e844968ac97c7848433]

        gtk4: reenable some working simple calc dialogs
        
        Change-Id: I328d5b36dbc0a856cbad21cc57c37d3600072875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [d2a8cd8333e07f681a42093f5d694107516a1d46]

        gtk4: restore IconView
        
        sans popup-menu for now
        
        Change-Id: I5708b8f11d8ee50bba974174a2e3cfdb128d0486
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116068
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [39bfafa73a327da2f9fc753e7f4dc10eca2dec78]

        no need for an image-position if the button only has an image
        
        and no text for the image to be relative to
        
        Change-Id: Ic06dfe6451708590d08a3d2b6821f68a67048de7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116065
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [8e34098774a002a8734d9d03d1ba7cb445b815c4]

        gtk4: always transform internal-child GtkButtonBox to GtkHeaderBar
        
        except for GtkMessageDialog ones
        
        Change-Id: I7bb1ff1533ebc07872342fdf632f5a950bf73d88
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116064
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [761c10bdf310fef2879874b6d5057fc51f54c0ca]

        tdf#94962 - Fixed german text:p of type boolean
        
        Change-Id: Iccee4e85b12a0277f9b6975ce16137327250c8f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116047
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [0c31dd6f4ee14a8dc41159ce4e18a7d299d0a341]

        gtk4: transform GtkScrolledWindow shadow-type to has-frame
        
        Change-Id: Ib9970bad9fbf32def0bcea6ffde42e4204dd4a06
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116063
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [ed52d1eb0aaceed3aae1c182091401f9c433acdd]

        adapt oglcanvas::SpriteDeviceHelper::getDeviceHandle
        
        to match the other implementations that return the OutputDevice*
        
        I tried enabling SpriteCanvas.OGL in
        
         officecfg/registry/data/org/openoffice/Office/Canvas.xcu
        
        with
        
             <node oor:name="com.sun.star.rendering.SpriteCanvas" oor:op="replace">
               <prop oor:name="PreferredImplementations" oor:type="oor:string-list">
                 <value oor:separator=",">com.sun.star.comp.rendering.SpriteCanvas.DX9,
        -                                 com.sun.star.comp.rendering.SpriteCanvas.Cairo,
        +                                 com.sun.star.comp.rendering.SpriteCanvas.OGL,
                                          com.sun.star.comp.rendering.SpriteCanvas.VCL
        
        but it crashes before it gets very far and before it gets to this
        method. I tried in 7.1 and 7.0 but the same result so I can't tell if
        this fix is needed, but they surely should be the same as the others.
        
        Change-Id: I4f3715568eb0ec3a3bc57f6e6bdf158ff530ca5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116061
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Julien Nabet  <serval2412@yahoo.fr>  [a0f6319ca5bb0fb19e7de59cafe7e7a7d47a1006]

        Fix documentation of SfxItemPool ctr
        
        Change-Id: Ieead093b16c073e8b4b10d785c880287fa1994d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116056
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [175a039fe70ab33fc1a68e21043b086b67d602e4]

        gtk4: make opengl slide transitions work again
        
        Change-Id: Id64d8759d1c98a973445f52ccfc5df9f0e084743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116060
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [5ca3dd6b9e531421bc7d3e66109e27e8df15b1e6]

        gtk4: restore GtkFixed container for SalObjects
        
        put the DrawingArea into an Overlay so the overlay will take the size of
        the DrawingArea. Put a GtkFixed into that overlay which will then also
        mirror the size of the DrawingArea. Keep that GtkFixed because the
        SalObject stuff is set up to use a GtkFixed and its just easier to do it
        this way than use the overlay directly.
        
        Change-Id: I937b3740fd809660ee0edef56d5cf036f2503892
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116059
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [cb5e49907a2970f6d2820bbc6061ccc7ed0bea93]

        gtk[3|4] separate the idea of a drawing widget and a container widget
        
        which were the same thing in gtk3, lets try an overlay for now as the
        gtk4 container
        
        Change-Id: Id368ddf5ef80a17453ea7fb5662b23897975d21e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116058
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [7da5a688f47574f2e55c57d8efba5640bbc4e14f]

        gtk[3|4] add a queue_draw to avoid GtkFixed cast
        
        Change-Id: I093b62f9530b28ae932338163606e78fca5752d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116057
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [7f6f57fe93cef0482e1e8b352987f185c56e2d64]

        crash on launching opengl slide transitions under gtk3
        
        since...
        
        commit 9090dc1f3b27195f5defd35586ac79357992be21
        Date:   Mon Jan 18 18:27:19 2021 +0200
        
            split OutputDevice from Window
        
        note SpriteDeviceHelper::getDeviceHandle seems to return a vcl::Window
        and not an OutputDevice like the other ::getDeviceHandle so that
        probably needs changing too, or the others need to return the owner
        window.
        
        Change-Id: I84da379e680d3da5775855a16dc716decef22bbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116052
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins

2021-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [4c5bbb25d215b618c38e2fec58d0cc2f16af3f18]

        tdf#136794: sc_mathematical_functions: Add unittest
        
        Change-Id: I2254007a2746acc41fd7e51a9a2630f7009a85e6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116043
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [af10eb1207c83b1c794da74ef48f5c3345669a17]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 67083387c1b82f17f7027ad53c9438766c0c41f3
          - Python support in SF_Calc help page
            
            Change-Id: I0b7a83fdd49dd4cf5fb1682b193a61ceef5bbe55
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115956
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-05-24  Rafael Lima  <rafael.palma.lima@gmail.com>  [d53c06ea9202c076feabc3113e4861f664184ee7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ad23b45f6804a44ff768cb971ce34915de3df1da
          - Fix broken link in SF_String
            
            The IsIBAN link was incorrectly pointing to IsIPV4
            
            Change-Id: Icd2cb3a5e0ca884afd3edbd3d2a721817d0817f9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115963
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-05-24  Jean-Pierre Ledure  <jp@ledure.be>  [024a11fee38492b8e76917ad5e9f5b0b26f46313]

        ScriptForge - (scriptforge.py.SF_Basic): methods in alphabatical order
        
        GetSystemTicks() and GetPathSeparator() are inverted
        
        Change-Id: I7e5c14041d6c70fe0a47519c93a24360ccc2d162
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116048
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [0a3aa3f3c9b8b160dedd678dcfbca38b2f128c38]

        tdf#137063: sc_ucalc: Add unittest
        
        Change-Id: Ib9025784aac5742976a0e23c5cd7d64154925ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116049
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [a68c96f63be186a3319b8266318e21c9b9f73b9c]

        fix leak in SfxTabDialogController
        
        Change-Id: I98a459d0b6173d367bbe596bcbf25501612ff032
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116051
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [004ddb8fdb7baca7cd2e43ebd21bc7c957f35895]

        fix leak in dbaccess
        
        when loading form controls
        
        Change-Id: Ifa731ca1c7bc16579ce03d256691a50ccfbeb82b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116050
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [97b2ad3681ca13d936f7ba04c8da5025b53464c3]

        gtk[3|4] wrap gtk_im_context_set_client_[widget|window] variants
        
        Change-Id: I939786e45929ca81dcda479d0fc897f449f890ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116046
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [8719c42ebab0b135b50d559830bfe2c2e0e8debb]

        gtk[3|4] wrap surface_create_similar_surface variants
        
        Change-Id: Iaa101b1d691fa84693b350460a4c69a1f5aad245
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116045
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [d4bae3c10e8f9ccafcc911a677093101eaed3ad1]

        gtk[3|4] wrap gtk_widget_get_window/gtk_native_get_surface
        
        Change-Id: I21c1cf9ab65e056242f09c8c2bbd84afa9ac42e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116044
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [a798bf1ade3582fb38af4a23174d42ebdaeafaf2]

        gtk4: get DrawingArea working enough for tip of the day dialog
        
        Change-Id: Ifd2f4029b521d8f513f4fa738e4ce1e59c0ade0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116042
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [bb68b8fa3982297897c5ec18a64aad41cec4231b]

        gtk4: background colors have to be solid for themeing
        
        Change-Id: I3a644c5674897ef6994d15ec0de614993d65d9d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116041
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Mike Kaganski  <mike.kaganski@collabora.com>  [abfa48b54307d659dc2f6f890c9855d06f1cbf7d]

        tdf#142390: fix fatcross cursor on Windows
        
        Make it 1-bit cursor resource instead of 32-bit icon; and add it to
        the appropriate makefile.
        
        Change-Id: Icd140f7065f6ec94683e94201d96187f38ab683b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115962
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [69a86a65191f7cc62d995ca9677fb344697b6457]

        fix leak in conditional format
        
        Change-Id: If44615016ab22f4d9e57845c4b0c9fc90b6d91c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116032
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-24  Luboš Luňák  <l.lunak@collabora.com>  [ae38f1dff768e3582464f34ec4cd89b8133e8423]

        add vcl unittests for basic text rendering
        
        These just check rendering of one character (normal or vertical)
        both in horizontal or vertical orientation, and with scaled width.
        It'd make sense to add more tests, apparently we almost do not have
        unittests for text rendering.
        
        Change-Id: I279314f0e946731dd38261ea030ea42be9fad572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115621
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-24  Luboš Luňák  <l.lunak@centrum.cz>  [b60cf60000c7a85d2fa8ea5b17851407417be7a6]

        fix Skia Windows text rendering
        
        This is quite some trial and error, but now it seems all CJK text
        rendering works properly. I tested tdf#136081, tdf#137907, tdf#103785,
        tdf#106295, tdf#114209 and tdf#141715.
        
        Change-Id: I40e893f66281b0a1a0e814feec3f782ceeb0c535
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115620
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-24  Luboš Luňák  <l.lunak@collabora.com>  [1b97f8010bc3e7af1aadc19a29a621aa5a3bb986]

        disable AA in Skia/Windows text rendering if asked to
        
        Change-Id: I8bff295277c623125d81de7804b43f91f680df4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115619
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-24  Luboš Luňák  <l.lunak@collabora.com>  [d3772e26c077686fc5ca0a8ba526df7d104ada5c]

        fix font scale width handling for Skia/X11 (tdf#136081)
        
        We get width+height, for vertical text width is the font "height".
        This means we need to use two different fonts, one for "normal"
        glyphs and one for vertical glyphs.
        
        Change-Id: I9d190fc28286055a18c3d5c3ec75515c7c1d4373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115618
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-24  Luboš Luňák  <l.lunak@collabora.com>  [2dc3097702c3b0b9225b5abadc94b90d63e628e7]

        fix skia/x11 text artifical italic
        
        This is supposed to be floating-point division. Also, the 0x6000
        value comes from cairo text rendering, but it seems to be too much,
        0x4000 visually seems to give a better result (and also avoid
        clipping in some cases).
        
        Change-Id: Idd99c64ba897eed211e227a88a40b06dbdfd5614
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115617
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-24  Xisco Fauli  <xiscofauli@libreoffice.org>  [27192c82ab143287327367d6165737086613021f]

        tdf#134675: sc_uicalc: Add unittest
        
        Change-Id: Ie76152ca1b1b80d60fcd891548c5eb4f32bcb40c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116033
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-24  Gülşah Köse  <gulsah.kose@collabora.com>  [5ef0461b647dbb01a037459b39b47240abb85fca]

        Mail Merge: Remove the missing data source warning on load.
        
        User can easily forget that they (or somebody else ) added a
        data source to document. This warning is only useful for the
        user that plans to use mail merge wizard. When they don't plan
        to use mail merge wizard and see that warning on infobar they
        can confuse. We already have the same warning on mail merge
        dialog itself. We don't need on load warning anymore.
        
        Change-Id: I8d80148a9637ee66cc35e2ef583fff51a04386eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116029
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [f47dbc7e12f0bab7bcbae487460ccbdc2f5c171a]

        gtk4: reenable FormattedSpinButton
        
        Change-Id: I16718d614cebc15104a5cde66af238245147e759
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116026
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [08dcfe0cf28339e4dab74e7542516fabf482dacb]

        gtk4: make generic paste work again
        
        Change-Id: Ic78a674f8cb0bf846a5cd90bb1b2cd27c7cb2151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116025
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [4bc36fd91b4d1fa933bdaf8b46a48f59a0d83c0a]

        rename m_aMimeTypeToAtom to m_aMimeTypeToGtkType
        
        Change-Id: I91d1031ec2feb2c434bb7c2fa18e632738a315b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116024
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Caolán McNamara  <caolanm@redhat.com>  [a02b9277a354922d4dc887d72349af9e4573c025]

        gtk4: make basic text pasting work again
        
        Change-Id: I23b029f7accb7ee65f1dfdf1eaa2643faafff14a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116023
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-24  Noel Grandin  <noel.grandin@collabora.co.uk>  [42d2b2d55a27f11153ea1713737d93540a19211d]

        fix leak of wronglist in SwTextNode
        
        Change-Id: Ib388575d60d7cc32829108f70d7900d95fc34121
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116022
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-24  Eike Rathke  <erack@redhat.com>  [fddef05ea72db3450f95570a17511350cc46016b]

        Resolves: tdf#134675 Allow unrestricted pastes of same size in one dimension
        
        So copy-paste of for example one entire column onto more than 23
        columns is possible as that does not create multiple repetitions.
        
        Change-Id: I2b035afa1c04522db55569396a36b1bac57c590c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116031
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-23  Caolán McNamara  <caolanm@redhat.com>  [0bcc06b0a563da08ccf1704b2f51376f27f51f62]

        gtk4: implement basic text paste
        
        not used yet
        
        Change-Id: I7d7877e66976732356ef7541fce33fc9455fdb0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116020
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-23  László Németh  <nemeth@numbertext.org>  [a8a9b4f4635bff3f1b7ec63b62f661bc15196cd6]

        tdf#142448 sw offapi: add custom color metadata field shading
        
        using the new com::sun::star::rdf::URIs::LO_EXT_SHADING
        URI (modelled after odf:prefix and odf:suffix).
        Custom color field shading of text:meta annotated text
        ranges and text:meta-field metadata fields allows
        quick visual check of metadata categories.
        
        For example, RDF triple
        
        content.xml#id1753384014 urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0odf#shading FF0000
        
        sets red (FF0000) shading color for the text span
        with xml:id="id1753384014".
        
        Pressing Ctrl-F8 or View->Field Shadings can disable
        custom color metadata field shading on the UI.
        
        Note: neither LO_EXT_SHADING, nor odf:prefix and
        odf:suffix changes invalidate the View (MetaPortion),
        but run-time update of shading color can be triggered
        without save and reload of the document e.g. by using
        (temporary) bookmarks on the annotated text spans.
        
        To run unit test with enabled visibility, use
        
        (cd sw && make UITest_sw_styleInspector UITEST_TEST_NAME="styleInspector.styleNavigator.test_metadata_shading_color" SAL_USE_VCLPLUGIN=gen)
        
        in Linux command line.
        
        Change-Id: I5de93cfa32ac6793d7dbdc7b64e6f4beacb2e8d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116015
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-23  Eike Rathke  <erack@redhat.com>  [a04ac0ecea9468cedea3bba85fb65cad5f911a2a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9bf3dff6c45faa6ee5a6e8f923ae5d13178c1263
          - Add NatNum12 MMM=upper and MMMM=lower examples
            
            Change-Id: Ice7a6d45db2373b78e6442e08a3ac647887e43bc
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/116021
            Tested-by: Jenkins
            Reviewed-by: Eike Rathke <erack@redhat.com>
            
2021-05-23  Eike Rathke  <erack@redhat.com>  [f613caedb14fb514c9ef26c42830f8a6c12c53ef]

        Resolves: tdf#136794 Unlimit decimals for ROUND()
        
        Change-Id: I8a00cbea0fab3ef301def81f52febd4ad03bd3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116018
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-23  Eike Rathke  <erack@redhat.com>  [172d5649106d8602ee258b7002b78459edd4855c]

        Resolves: tdf#137063 For General format start exponential display at 1E-10
        
        ... instead of 1E-05, if not too many significant digits.
        
        Change-Id: I66cca1bdd2742526e4ade08a691e6d43b2eb439e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116016
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [ae829001fbc9dddb2b4774dcfb9a7fe8e930d335]

        fix some starmath test leaks
        
        Change-Id: I99ad6330b7b727f6d5416afe466a8defacd14180
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116013
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-23  Muhammet Kara  <muhammet.kara@collabora.com>  [0253457e130442423210f99004d4c685fbff288f]

        stlFindInsert: No unnecessary search before insertion to map
        
        Change-Id: I7d1dc5d524a8a6f43f8371250d9e6f3c9c7a2589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115995
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-05-23  Caolán McNamara  <caolanm@redhat.com>  [e85c7952845a8b64af1104f279c0d2bb045270db]

        gtk4: add clipboard_get for differing ways to get clipboards
        
        inch a little closer to cut-and-paste
        
        Change-Id: I1e334a0ef4dca274e619376bad8eef7d9caa2cee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116007
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [b3ec639a017d189b2327230b9d3f9f19d634d36a]

        fix leak in ScRangeTest
        
        Change-Id: I48ca0486d7e31b9d111b7ca675a84a826db21b1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116012
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-23  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8ffedfd3c05b7526d934f53f7f5f0ee2dd4fb78]

        fix leak in SwUndoFormatCreate
        
        Change-Id: Ie6f67c71fa87c78ea57c70f765024b76be1b0a0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115991
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-23  Joshua Williams  <joshmackwilliams@protonmail.com>  [6cdfd89413eab85dba7b975199358cb8fae44661]

        tdf#142180 Swapped comparison operators for static strings
        
        It seems that, for some reason, the comparison operators for
        strings in basic were swapped in the code that evaluates
        string comparisons at compile-time. This is what caused
        bug #142180. This commit simply swaps the operators and
        should fix the bug.
        
        Change-Id: I14f90db8598f2f7f8b709e26902986e1f64af576
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115983
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-23  Eike Rathke  <erack@redhat.com>  [49af7e22e61c2e5d440ad55cd362388983e128ae]

        Related: tdf#136794 tdf#137063 Unlimit decimals in rtl_math_round()
        
        Change-Id: I7f9fb45824458d578ee302a668386fe0c3c80974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116010
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-23  Muhammet Kara  <muhammet.kara@collabora.com>  [60cba23bc0f5e8eafecc03c437f1133b62569fa6]

        tdf#116491: Customize: Hide experimental commands when not in experimental mode
        
        Change-Id: Ibc88e9c90b261b5294fab8041e0b530016f45f33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116006
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [127da6671cdbdbfb2e7fa1479d9671e1311a8cd2]

        gtk[3|4] there's only two options, 'clipboard' or 'primary'
        
        Change-Id: I70d8426a3864551b7632d535864e3639065d0be1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116005
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [0b4a6e71545a9590e42629d2b66ce81f6bcdf1fb]

        gtk4: reenable TextView
        
        assume for now that old workarounds can remain disabled
        
        Change-Id: I64a566985f227db9a2c2d3ef760b4fc324815b2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116003
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [43110924e78bd18ec4fce89036a0174b8dec8a83]

        gtk4: reenable paned
        
        Change-Id: Iccda840da791b38b9a8287492f02348b9036de9d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116002
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [7f9d4ad337ca988545f96cc75bd925a5d0aa8a75]

        gtk4: reenable Frame
        
        Change-Id: Ic9ce49da26c6ca673ac0980ab32895d8eda8da54
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116001
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [978765903973fe4dcd0c711eceef5bd0eac9f0e3]

        gtk4: reenable ScrolledWindow
        
        Change-Id: I2c6029e46ae18945bd6acfa3fc7552842790d573
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116000
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [a197ad20a8b4511f710b0f6f9d1d7f0ccf4de0aa]

        gtk[3|4] get class size from g_type_query of viewport type
        
        Change-Id: I7121159b600b9be6e3b80364ada1f145226c26da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115999
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [4f521ac7a362f0dc32898c2372efd8aa84f548de]

        gtk[3|4] rename to immobilized
        
        Change-Id: I06c8fb88afa7e10b2d03601f52cc2345bb2ab170
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115998
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [4f4c5b43f0c69385aa2738cbac7f7c898af1972f]

        tdf#55007 EMF Allow negatives values for Start Point and End Point
        
        With previous inplementation, the ARC, ARCTO, CHORD and PIE
        records were get Start Point and End Point only with
        positive values. It was causing display issues.
        
        This patch fix that according to [MS-EMF] specification
        
        Change-Id: Ie1d90a904e840674380b81af0dfe21260374587d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115994
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [90818a8704daece65fad2e41aed0fc17e5a8cf13]

        gtk4: reenable Calendar
        
        assume for now we don't need the old workarounds
        
        Change-Id: I15bc9e562577dd1f9c0395d86cd497835e45aebf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115993
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [e2d1ddd671f41b560aa262202e5325ac3c0657ac]

        ofz build fix
        
        Change-Id: Ia8c0aacc57a6aa2dd1ba591fd3a95c61d84e617b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115990
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Muhammet Kara  <muhammet.kara@collabora.com>  [4b5d046ca33b2fc62dd16284c030234df62e7276]

        Upgrade .gitpod.dockerfile to Ubuntu focal
        
        and add vnc support
        
        Change-Id: Ibf037eb8fb4f3c2b9389d60d675728f57c994373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115992
        Tested-by: Jenkins
        Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

2021-05-22  Thorsten Wagner  <thorsten.wagner.4@gmail.com>  [2cce064e6bb570361c845f7b3d82960f89c70bb1]

        tdf#142061 Add window scaling to XOR emulation on macOS
        
        Window scaling for retina displays on macOS has been added to fix
        tdf#138122 in commit 1a167625314bf36b735176ed488e6ba9b5e9b675
        
        Missing window scaling for XOR emulation is added by this change.
        Code modified for macOS is moved from quartz/salgidcommon.cxx to
        osx/salmacos.cxx while original code is copied to ios/salios.cxx
        to prevent modifications for iOS.
        
        Change-Id: Ia8c52f9045379cc37d5aff1279650db0dddee8c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115816
        Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [77b505b0b9fd86d2bd8e82f2be7d40307dfd1493]

        document how the on-demand treeview entries work
        
        Put the expand related methods beside eachother and give a hint how
        to avoid placeholder inconsistencies
        
        Change-Id: I798e5e69d5a7a1c5e30e5b77b9bcfbfe731a0536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115951
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [1a0ff2476622d10167997939b66262ec674cbd10]

        gtk4: use gtk_window_is_active instead of gtk_window_has_toplevel_focus
        
        Change-Id: I0ff19754e4a4505a73ece999d16ec981e5616e42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115982
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Caolán McNamara  <caolanm@redhat.com>  [9e9aebcf8db7934bb4026d18590b8336d9f2fea7]

        gtk4: reenable Expander
        
        assume for now we can drop the older workarounds
        
        Change-Id: I75baabcb00addd3cebb5cca8bd472544cd029218
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115944
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-22  Jean-Pierre Ledure  <jp@ledure.be>  [14d62503e951bd26ae531071b031ee362ac7307a]

        ScriptForge - (SF_Basic) Add new CDate() method
        
        The CDate() method replicates in Python the behavior of the Basic
        builtin function with the same name, except that it returns
        its unique input argument when it could not be recognized as
        a valid date, while Basic raises an DataType error.
        
        The method is introduced to make it easy to Python devs to
        convert numbers stored in Calc cells and representing dates
        to their corresponding datetime.datetime instance.
        
        Change-Id: Ifd8fbd4bf7a97bf6b91cf481c09d75ec14159916
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115989
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-22  László Németh  <nemeth@numbertext.org>  [c1bf2a3751b6a602f2571f8642b36504b04ca3fd]

        tdf#60382 sw track changes: add test for Undo of IsNotTracked
        
        TextTableRow property. Remove also maybevoid from
        com::sun::star::text::TextTableRow::IsNotTracked.
        (It's possible to add it later, if needed.)
        
        Follow-up to commit 05366b8e6683363688de8708a3d88cf144c7a2bf
        "itdf#60382 sw offapi: add change tracking of table/row deletion".
        
        Change-Id: I4854dcda827cc8d5b1d0ec8bba381458b3ab17b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115988
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-22  Xisco Fauli  <xiscofauli@libreoffice.org>  [f4a9dcc471f5cefb2c16e104a270339afa88b4d7]

        tdf#142395: sc: Add UItest
        
        Change-Id: I428b77283a9828bd3902702fb23b3acc560dea94
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115947
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-22  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0a307d085468a2e8e252ef73304f83dafc8c4a75]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6a10fe0b51b53d9dc097e420c65f86590800ca22
          - tdf#142389 (final) update autofilter Help
            
            - Add definitions for each autofilter command
            - Add info on fitering by color
            
            Special collaboration by Steve Fanning.
            
            Change-Id: I51e8e6e495736d0d5e1b5d40e74a926c813fb49a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115895
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f85d178f2e9f7a61f35c8ef6feb1592b5002403]

        fix shutdown leak in ScCreateDialogFactory
        
        Change-Id: I7be0fa457fb11dbc1096042636b641cd09df8b4e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-22  Noel Grandin  <noel.grandin@collabora.co.uk>  [d4661d66f5735a80613d5e7dcffdd01d7e18d896]

        fix leak in desktop test
        
        Change-Id: I6d6ae4a59777b17fda39b81ce867c2ee4a753a43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115986
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-22  Tünde Tóth  <toth.tunde@nisz.hu>  [451b9802dd708e646273839829845800e13db47e]

        tdf#141559 sc UI: add Clear Filter to Autofilter widget
        
        Implement Clear Filter menu item in the Autofilter
        dropdown that can remove standard filter conditions
        and autofilter conditions too.
        
        Change-Id: I7521379955d3f38076c3129273629222412d9ed4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115609
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-22  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [b7c9ce6c86a11c6cacfa190b99052da388887c49]

        tdf#127145 WMF Fix displaying line width in ROUNDRECT record
        
        The EDGE optimization shouldn't be used for curves,
        otherwise strange issues appearing.
        
        Change-Id: Id677fc9002f0f79913ae756f0e456af7c9f7e507
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115984
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [4a9eef7849a75ba91806886ea9c96d114c8d56f9]

        tdf#106893 android: Show whole doc when closing soft keyboard
        
        When closing the software keyboard after typing,
        a black area instead of the doc content was shown
        in Android Viewer.
        This looks related to the fact that a SurfaceView
        is involved, s.a. [1] which suggests two potential
        solutions to fix the issue, but none of them really
        works well. (Setting a transparent background didn't
        have any effect when I tried. Using
        'android:windowSoftInputMode="adjustPan"' in
        AndroidManifest.xml would work in general, but trigger
        the  problem described in tdf#96789, namely the
        software keyboard would be shown on top of the
        document and the last part of the document would
        not be visible with the software keyboard enabled
        any more.)
        
        Rather, make sure an 'LOEvent.SIZE_CHANGED' is
        triggered when the software keyboard is enabled or
        disabled, in which case 'LayerView#onLayout' is called
        with a 'changed=true' parameter.
        To avoid resetting zoom and position of the document
        for this case, call the 'redraw' function with param
        'false' when processing this type of event in
        'LOKitThread#processEvent'
        (s.a. Change-Id: I8ba6a7cd8d984ad99654e188e00144e1edf407ed,
        "android: Don't reset zoom and position on refresh event"
        that did a similar thing for 'LOEvent.REFRESH').
        
        This adds a 'force' boolean parameter to
        'GeckoLayerClient#sendResizeEventIfNecessary', which
        interestingly had been there before commit
        
            43bbf53bbad4623355e6344094573f8efca01df2
            Date:   Tue Jan 27 13:01:53 2015 +0900
        
                android: remove unneded code from GeckoLayerClient
        
        but I didn't further check whether it had been used
        in any way that would have been useful for this
        scenario back then.
        
        Stackoverflow article [2] was quite helpful.
        
        [1] https://stackoverflow.com/questions/2978290/androids-edittext-is-hidden-when-the-virtual-keyboard-is-shown-and-a-surfacevie
        [2] https://stackoverflow.com/questions/52223095/how-to-detect-redraw-of-screen-has-completed-after-soft-keyboard-closes
        
        Change-Id: If3fdd1335468fc50901fc6c1982c1463c7804309
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115973
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [817c89fa456917fd9993ae226e8e932fe90ee1d8]

        android: Inline 'LayerView#setViewportSize' to only call site
        
        It doesn't override any parent class methods and was
        only called from here.
        
        Change-Id: Iccfacb42e8d5514994eafac841c0ec55be65b062
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115972
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [1cfc6c545cd979eff04e38b2998c40e25106faf2]

        android: Don't reset zoom and position on refresh event
        
        Don't call 'zoomAndRepositionTheDocument' for a REFRESH
        event. The only two places sending such an event are in
        'LibreOfficeMainActivity#onStart' and in
        'FormattingControler#sendInsertGraphic'.
        
        I don't see any need to reset the zoom and position in
        any of those two cases. Doing so had the effect that any
        manual zoom changes would be lost when e.g. switching
        between the LibreOffice Viewer app and another one,
        after a "Save As" or when inserting a picture.
        
        In my opinion, it's desirable to keep the view
        the user had before doing any of those actions and
        just rendering the document anew.
        
        To do so, add an extra bool parameter
        'resetZoomAndPosition' to the relevant methods
        in 'LOKitThread' that says whether a reset
        should take place.
        
        Change-Id: I8ba6a7cd8d984ad99654e188e00144e1edf407ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115950
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-21  Michael Weghorn  <m.weghorn@posteo.de>  [a3f682f90f85d69270f4d10ee1d661f25257bf21]

        tdf#106370 android: Make inserting pictures work
        
        Instead of just setting LibreOfficeMainActivity's
        'pendingInsertGraphic' member when inserting an
        image, call the method responsible for asking what
        compression to apply, doing the actual compression
        and sending the event so the picture is actually
        inserted right away.
        
        'LibreOfficeMainActivity#pendingInsertGraphic' is
        (by now) only evaluated in 'LOKitTileProvider' when the
        document is initially loaded, therefore just setting
        it had no effect.
        
        The more complicated handling used previously instead
        of just inserting the picture right away was probably
        necessary/used because 'LibreOfficeMainActivity#onStart'
        used to reload the whole document before
        
            commit 1bc42472200c32c9a0a10dd1c3cd6c6a8a5d47d2
            Author: Michael Weghorn <m.weghorn@posteo.de>
            Date:   Fri Apr 9 13:59:43 2021 +0200
        
                tdf#95517 android: Rework app/doc lifecycle handling
        
        and that was called when returning to the main activity
        from the picture chooser. (That is just a guess, I didn't
        actually verify this).
        
        While this fix probably doesn't have much to do with what
        caused that functionality to not work back in 2018,
        when most of the feature was introduced but it did
        not yet fully work as mentioned in
        
            commit 8d977511e3ab755da65d34a0bd618ef3c9db90c7
            Date:   Mon Aug 14 11:41:30 2017 -0500
        
                tdf#106370 Android: add ability to insert pictures
        
                Added ability to insert pictures to Android Viewer.
                You can take photo or select photo from device or
                the cloud (Google photos, Dropbox). You can also
                compress the picture before inserting it with multiple
                compress grades. So far, inserting doesn't work for
                Writer due LO native library issues (I think).
        
        it still makes inserting pictures "just work" by now.
        
        Change-Id: Idad9dcbba177ea12f056bc31bd6b9c08621062cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115932
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-21  Miklos Vajna  <vmiklos@collabora.com>  [2634bc59092b24217d984a5845365d703bdb08d2]

        sw: replace most static_cast<sal_uInt16>() calls with o3tl::narrowing()
        
        o3tl::narrowing() is a better way to handle this, as that way the
        integer conversion is still implicit, which allows detecting integer
        truncation at runtime (with suitable compiler flags).
        
        Change-Id: I499abda3be6943e8c111c56df390e72939586221
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115948
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [c912c4b02b2dc4cd5aa62d77e92e1731c6cbde65]

        gtk4: reenable Spinner
        
        Change-Id: I76eae250038e6c7adc927f1dfc9ff5a926716e15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115943
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [fd805bc577d55113db1c9c125e00e4d4bd687e4d]

        gtk4: reenable ProgressBar
        
        Change-Id: I8bf7de16c81de3cd7a978e2c92c59c50a78bb120
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115942
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [5c4c3e776d702932099a1d510db0c92d795080ec]

        gtk4: reenable Scale
        
        Change-Id: If9ebeb540a87f81bd48a121ecbf674dd8f636f71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115941
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [69ad56b8281bbf4bbf4935cc2ac10b9719869afa]

        gtk4: renable LinkButton
        
        Change-Id: Ifdb49a52c08ac78a48aa37c00041b8714bcd0206
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115940
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [4cd4946b7c04e192d2f2fa164eae87224f4d0b5d]

        gtk4: reenable ToggleButton
        
        Change-Id: If6458ef0a5ad21532c9aa96ed52779993353b572
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115939
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [89cc421a6b246df36415fc3fbbec00435ffc5a85]

        tdf#142294 drop placeholder on-demand node on directly populating node
        
        Initially there's a <placeholder> entry to indicate the load-on-demand
        state.  It needs to be there for the expander indicator to be
        drawn/shown when there are no "real" entries yet.
        
        Typically the user clicks on the expander, the expansion remove the
        <placeholder> entry and calls the provided expander-callback which has
        the change to populate the node.
        
        Here RequestingChildrenHdl is the expander-callback (set via
        connect_expanding) and populates the node like it should.
        
        But then there are two places where it is called directly outside the
        expander-callback so it merrily appends entries into the node, but
        because it's called outside the expander-callback the <placeholder>
        entry was never removed which is then a problem because of the resulting
        inconsistency.
        
        Change-Id: Ie7d034e3f41832591438127c82eba85deb610952
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115949
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [318c48205cf598ee6c2312e5b4d0ae7fc1ee6c36]

        fix SwDoc leaks in CppunitTest_sw_macros_test
        
        Change-Id: I488c722fcba553f8784a1b14d841128cbda77934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115924
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Mike Kaganski  <mike.kaganski@collabora.com>  [70f3327e4ad0267c8e5e711e2b55e30a71ef5452]

        Simplify GetModuleFieldUnit a bit
        
        Change-Id: I34ed20387104cbfa0e9b894a5862d7f0543adfd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115849
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Mike Kaganski  <mike.kaganski@collabora.com>  [134d59017fa61afff4248d1eeebb24ba336add07]

        Don't upcast only to downcast immediately
        
        Change-Id: I6d331708c281851f28e9800b7deeaee634310c21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115848
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [cc614f87afb38a8342dccfe4ad1b1d6ad7d4f955]

        fix leak in SwHTMLPosFlyFrame
        
        affects html export
        
        Change-Id: I10b33a27e18eabf36a1a8566c3b90f2f7c760f0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115922
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [dea9c444ab139dd53d44203bbcb88b29c95ceb96]

        gtk4: reenable CheckButton and RadioButton
        
        Change-Id: I29dc430222bb6dcb44bca0c2f26939a925c69c60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115787
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [3fdf145e699c5b639c6da722ec4de2d0ed49cfec]

        inherit CheckButton from Widget instead of Button
        
        seeing as GtkCheckButton no longer supports Button-alike features
        
        Change-Id: Ic7c882c68fa2d6d2b5bdd0dcca7d27e4b39daf46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115934
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [9940f077fdfc0c271aa66ad64578ae2236a2ca81]

        add Toggleable as a separate thing to a Button
        
        and inherit ToggleButton from both it and Button
        
        Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [f19a599f6911f5ccd1049228454b6c6c8fd6d5cb]

        drop unused suppression
        
        Change-Id: Ibdeb08817e5731a9165751c70466ffaf7ecf7875
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115933
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Jean-Pierre Ledure  <jp@ledure.be>  [4cb73b7a5792b6c8fabacc1e29d67e9f254144e8]

        ScriptForge - (scriptforge.py) FIX stdout redirection in PythonShell()
        
        Previous behavior:
          After a PythonShell() statement that opened the APSO shell console,
          subsequent print() statements executed in the same macro
          run were not displayed in the console.
          They were only from a next macro run.
        
        Solution:
          Force a brief suspension of the Python process by inserting
          a call to a Basic routine (IPC) immediately after the launch
          of the shell console.
        
        Result: The redirection of STDOUT and STDERR happens normally inside
          the APSO code, as expected.
        Change-Id: Ifbf267a898d45a97c346f0f3ea824edd4e6045ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115930
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-21  Tünde Tóth  <toth.tunde@nisz.hu>  [45a49b7a1b552f204e7b417cfbe2d86e4b169993]

        tdf#142350 sc AutoFilter: fix (empty) entry checking
        
        When a column was filtered for values that included 0,
        but not the (empty) entry, the (empty) entry also
        was checked in the Autofilter dropdown.
        
        Regression from commit 4fd1333ba4bb4f2311e9098291154772bd310429
        "tdf#140968 tdf#140978 XLSX import: fix lost rounded filters".
        
        Change-Id: Ic2595c707bd43f1a19c86d2ee796f06d9b1af1e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115755
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [185f3e3c382e93be4e0588ac8a927ea3140bce91]

        fix leak in XSLTFilter
        
        Change-Id: Icae17e964df944391fddb47e4b0758ca89e299eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115917
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  scito  <info@scito.ch>  [de4c23fb38a7848e1030075b9c15cbb5c558694c]

        tdf#68976 cut paste transposed: fix wrong position in clipdoc
        
        The transposed cells were written always in A1 of the transposed clip.
        This is no problem for copy paste transposed. However, this is an issue for
        cut paste transposed as references of formulas pointing to cut cells are
        adjusted according to position changes.
        The solution is to write the transposed cells in the same top left
        corner of the transposed clipdoc as in the original non-transposed clipdoc.
        
        There are still issues with cut paste transposed: Formula references are
        not updated correctly in some cases (tdf#142065, tdf#142201).
        Comprehensive unit tests will follow with fixes for tdf#142065 and
        tdf#142201.
        
        Change-Id: Id691fabf89d7f25e05182b20bd379299fc18fbb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115535
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  scito  <info@scito.ch>  [2eb95408912f2292e2c7e8634c628a29f6c241b7]

        tdf#116413 after Paste Special with ADD and As Link attach dest cells
        
        Change-Id: Icc039a4ea1c02d81d282cb43e7cf40279bea3342
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114641
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Luboš Luňák  <l.lunak@collabora.com>  [9bf9fea0afadef0912d38f0d08b2bf2959569100]

        properly draw only parts of FillGradientPrimitive2D (tdf#139000)
        
        The size of the whole gradient is getDefinitionRange(), while
        getOutputRange() gives the area of it to draw.
        
        Change-Id: I85dd7fe51bcc9c332a6fb0e6748d5ac89266b910
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115923
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [f63054cf249a6bddd3e7e2ef69eeb7aabaec76cc]

        move hangul/hanja previews outside radiobuttons
        
        not possible in gtk4 to put an image in here anymore AFAICS,
        this was always an odd case anyway
        
        Change-Id: I0525720f53046bf8d234e4beb85096c90235ea10
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115920
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [841ee616a5e5d191365c82359943a0171956e03a]

        tdf#126342: sc_ucalc: Add unittest
        
        Change-Id: I81afb8e513821253bc11e07d4bbac3a1abae2f90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115905
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e8b2849f2d336e903992ff7a3483364085594d12]

        tdf#142186: sc_ucalc: Add unittest
        
        Change-Id: I376cb9d6853eb89ca35875d66275b5e534eec013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115904
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [62728a315b762440f76477e036a8dacc5bb6d12d]

        sc_ucalc: combine header and implementation files
        
        Like the rest of Cppunittest files do
        
        Change-Id: If0ffaf3736066a34e6cd274e7fa42dc8b091f59d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115902
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Michael Stahl  <michael.stahl@allotropia.de>  [bf0c6a98ae38cd2188d7f7e94f1563e5ce6a8ce4]

        libxml2: upgrade to release 2.9.12
        
        Fixes:
        CVE-2021-3516 CVE-2021-3517 CVE-2021-3518 CVE-2021-3537 CVE-2021-3541
        
        * external/libxml2/ubsan.patch.0: remove, fixed upstream
        
        Change-Id: I347dc854b862e78bde87d3e57cf5fdb584ca5673
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115913
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [2f3a89c2e5d3c420e22e4a3a7319cc4e3bd789a4]

        resave in latest glade
        
        Change-Id: I8c734b808b9b62cffa5b18455672c8f7b183f45d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115919
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [064c3756fc691a5a36f26a8fba1c1be5ce7eb449]

        we want the max width here, not the sum of widths
        
        Change-Id: Ie17c062a3e031b85a5784176895c08c9a1638bea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115918
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [cae01a2e6b0186f0d44cb114e08e3ca461558989]

        gtk[3|4]: fix infinite toggling in draw
        
        regression from...
        
        commit 1815aa9472080b9dac263d393b9c922dd16351fe
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Tue May 18 20:44:56 2021 +0100
        
            GtkCheckButton no longer inherits from GtkToggleButton
        
        Change-Id: I933c2fb0ea39b0a650ec57031ddcc2b61250d0d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115915
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Stephan Bergmann  <sbergman@redhat.com>  [12362fc496102b344dedef0a6ba130ba80b94149]

        LineParser::readNextToken gets called with m_nCharIndex==npos after all
        
        eca89ece45ede76605a6102c94b3b67e1f8ff5aa "Replace rtl_string_getTokenView with
        o3tl::getToken" had erroneously assumed (from a succeeding `make check`) that
        the only problematic call to o3tl::getToken with position==npos would be the one
        in LineParser::readPath (and which had been addressed in that commit).
        
        But e.g. loading ooo29794-4.pdf from the crash test corpus would also run into
        that situation via LineParser::readNextToken,
        
        > warn:legacy.osl:3090875:3090875:sdext/source/pdfimport/wrapper/wrapper.cxx:259: insufficient input
        > soffice.bin: include/o3tl/string_view.hxx:34: std::string_view o3tl::getToken(std::string_view, char, std::size_t &): Assertion `position <= sv.size()' failed.
        
        > #3  0x00007ffff7a67a16 in __GI___assert_fail (assertion=0x7fffb39ea58c "position <= sv.size()", file=0x7fffb39f2a7f "include/o3tl/string_view.hxx", line=34, function=0x7fffb39ef3a9 "std::string_view o3tl::getToken(std::string_view, char, std::size_t &)")
        > #4  0x00007fffb3b60131 in o3tl::getToken(std::basic_string_view<char, std::char_traits<char> >, char, unsigned long&) (sv="eoClipPath", delimiter=32 ' ', position=@0x7fffffff29e0: 18446744073709551615) at include/o3tl/string_view.hxx:34
        > #5  0x00007fffb3b5aa9f in pdfi::(anonymous namespace)::LineParser::readNextToken() (this=0x7fffffff29d0) at sdext/source/pdfimport/wrapper/wrapper.cxx:260
        > #6  0x00007fffb3b5b2fa in pdfi::(anonymous namespace)::LineParser::readPath() (this=0x7fffffff29d0) at sdext/source/pdfimport/wrapper/wrapper.cxx:323
        > #7  0x00007fffb3b59eb3 in pdfi::(anonymous namespace)::Parser::parseLine(rtl::OString const&) (this=0x7fffffff2d28, rLine="eoClipPath") at sdext/source/pdfimport/wrapper/wrapper.cxx:859
        [...]
        
        so better guard there.
        
        Change-Id: Ibfd53fd9d3be0a3548d60cb26d59bb5966c5bc2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115916
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-21  Michael Stahl  <michael.stahl@allotropia.de>  [95a716f12a0dacdd5d80a6f3d98eadcc2f079fcf]

        sw: layout: fix footnote UAF on tdf132248-3.odt (also, tdf134127-1.odt)
        
        Text frame 12 gets a follow 137 which gets a follow 138, and there's
        a footnote at index 95.
        
        When 138 is created, its mnOffest is 63 in SwTextFrame::SplitFrame()
        so 138 gets its mbFootnote set and the footnote frame mpReference points
        to 138 but then SwTextFrame::FormatAdjust() moves one line back and sets
        the offset of 138 to 96.
        
        Then SwTextFrame::CalcFollow() clears 138's mbFootnote due to lack of
        footnotes starting from 96.
        
        Later frame 138 is joined, but because its mbFootnote is false, the
        footnote's mpReference continues to point to it, which leads to UAF in
        SwFootnoteFrame::GetRef().
        
        What's missing is that at the time when the offset of 138 is adjusted,
        RemoveFootnote() must be called, as is already the case in another
        branch of SwTextFrame::FormatAdjust(), since CVS initial import.
        
        Not sure why this started to crash in crashtesting relatively recently.
        
        Change-Id: Ic46019d34ff90d24d0f23effe8a6d54d6f197a71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115910
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [634e98e767928806852aee6653a6fb6f35328eea]

        fix shutdown leak VbaGlobalsBase
        
        Change-Id: I12e81cd8374eaf15b4891d90a787e4184575486c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115912
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0d0e6123db5f73aff1b203224609148b37194b71]

        suppress more leaks in external libraries
        
        Change-Id: Ia69ce6a7be9f995dc919b91e4a3a56375e1c4c96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115908
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Noel Grandin  <noel.grandin@collabora.co.uk>  [0820a4c7ac12e6fc2cc683f8a07c99a11d40e30e]

        fix leak in some tests
        
        this situation only really happens during shutdown, when some of the app
        events are dropped
        
        Change-Id: If327daf1be243a603669f624b49917a73ddfd0fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115909
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [f654af56695197d11c277c424b0dd2b93195add9]

        move wrap icons outside radiobuttons
        
        not possible in gtk4 to put an image in here anymore AFAICS,
        this was always an odd case anyway
        
        Change-Id: Ic9415cd0c91a7f006231d786f2a3a22b8f97af6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115907
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [9ae02c9e5ce44173f042abcf3d644fb65d1d91b9]

        resave in latest glade
        
        Change-Id: Iaf6a18c236ed83bf92e1fee122fcaa0486328101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115906
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [958f79cd25a6bd03891d45410c1d71cb27bf43ba]

        Removed executable bits on source file
        
        Change-Id: If37a1fd4dad10767804fe7c925c048a1b81b59f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115911
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-21  Andrea Gelmini  <andrea.gelmini@gelma.net>  [cb6a45653795f8de296aa793328472c9c2906731]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 5990e7b3b300642d8551f202bcd1b9312f426677
          - Fix typo
            
            Change-Id: I0b5ce0a4c6adc339c14a65bd9a8f9b8f3eb8979a
            Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
            
2021-05-21  scito  <info@scito.ch>  [fd0779f6a0fd04263155d293320546ce7cbae84b]

        tdf#71058 cut paste transposed: use correct clipdoc
        
        ScDocument: :UpdateTranspose() operated on the wrong clipdoc
        Change-Id: I10fb010c7b6a1d523a1af92d67fc127957f9d17f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115901
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Miklos Vajna  <vmiklos@collabora.com>  [9e075acf2bf1ce6c43fdf5b601507ee0663bd691]

        sw: eliminate recently added static_cast<SwTwips>() calls
        
        This was added in commit 301278b656e76b6f42af5cf8a6f5c6c02acfffeb (sw:
        allow the height of a line to be larger than 65536 twips, 2021-05-20) to
        fix -Werror,-Wsign-compare problems, but o3tl::narrowing() is a better
        way to handle this, as that way the integer conversion is still
        implicit, which allows detecting integer truncation at runtime (with
        suitable compiler flags).
        
        Change-Id: I2f62420457e3d053e6fbc3b787b3c224c6f0586c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115903
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [a6241e3f7585c3c1806df64d4c485afb47da68c4]

        tdf#129878: svl_qa_cppunit: Add unittest
        
        Change-Id: I61ad886f4fc79ae6c4a71bcd331adbd7a8e9d966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115900
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e95bafd4bf9e8159d5d58af413848c64aeed571a]

        tdf#122991: svl_qa_cppunit: Add unittest
        
        Change-Id: I94fdab71acbbaf768f5151c642527d61728dfc7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115899
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [d35e71409fac3d6054f2acb71a96e84888763f32]

        use toggle instead of click for RadioButton
        
        Change-Id: I57cd1c074e4c4fc48ee83ac63a7c0ec5bcae5ae4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115890
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [fa3266f9bf00b5858f36ae37e5720026a1ed40cc]

        use toggle instead of click for CheckButton
        
        Change-Id: Iec5139cc2b739a624db7f10854a29e191b509286
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115889
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Caolán McNamara  <caolanm@redhat.com>  [d16ceda55b145cb31882bbf504924aa9103278aa]

        use toggle instead of click for RadioButton
        
        Change-Id: Ic246c68749f79cc1b25fed08a66fd8a0d57495f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115884
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [e8578423e9390a07419066d6c350c34fa254095d]

        tdf#123748: svl_qa_cppunit: Add unittest
        
        Change-Id: I55b3ad930f39f955b5c1f326a12c20af5fc46a1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115896
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Oleg Shchelykalnov  <olegshtch@yandex.ru>  [aafe21d8765158d223dd359e6737b64ed1b34549]

        tdf#137469 Add option to disable hidden text in text filter
        
        Adds sixth filter option to text filter.
        If true (default) filter save hidden text to output file.
        
        Change-Id: I71202653b3cc4e50ddd06a665f5a718f875f6d79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105579
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Aritz Erkiaga  <aerkiaga3@gmail.com>  [c8598f28db8ef5ab5f695cf1af645bb43dbc264d]

        tdf#138556 Don’t add Open Values to stock chart types 1 and 3
        
        A new function was defined, XdataInterpreter::getChartTypeSpecificData.
        Being 100% chart-type-agnostic when retrieving chart data is impossible;
        candlestick charts can have different numbers of sequences per series,
        and this information is not present in any other chart type.
        
        Change-Id: I0f54b09202c42667331b083d54d90e4ceee81083
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113075
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  Vert D  <devoptmsoi@gmx.com>  [9431984f8d39a4d7fb9428138ecc6971c212c122]

        tdf#132042 fix nItem id when creating region
        
        Change-Id: I5f2d00dd58580922119b30aafce6695bacb6e2f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113331
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-21  scito  <info@scito.ch>  [0ae3cf8d0f9d882011a120bb9955951f838c3534]

        tdf#102255 tdf#90101 remove trailing space in labels
        
        Change-Id: I8d2fe3889fec802eb48eb2e7cc2564c55772146d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115633
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d8f77408ad3b7918096ad2818db266074c66061]

        tdf#76441: sc_ucalc: Add unittest
        
        Change-Id: I39743a3d5100dd598e8af94c2bdd61b03dc68e57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115894
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-21  Miklos Vajna  <vmiklos@collabora.com>  [db8db4732cd50342139c1d2c358a4ce260c4b4f3]

        Replace magic numbers in SwTabFrame::UpdateAttr_()
        
        By using the same SwTabFrameInvFlags constants that
        SwTabFrame::SwClientNotify() already does.
        
        Change-Id: I308219262d9d18c41e38290fa2e43bf90ba77b5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115887
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-21  Stephan Bergmann  <sbergman@redhat.com>  [e9da22d3308557640e0edc45f72b1897f016d19b]

        Lets assume general availability of POSIX poll.h
        
        ...which should have been first released in SuS Issue 4, Version 2 in 1995.
        
        If there should still be any relevant platforms that provide the functionality
        only in a non-standard header, please add back the relevant #if'ery.
        
        Change-Id: I0f55341d24b905161ec38ed0d52602c6b6dfac46
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115888
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-21  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [798b69087119c01a3b51e0bb3240ef35cfededeb]

        tdf#104254 sw DOCX import: fix text wrapping in headers
        
        Text wrapping around shapes and images used to be
        turned off in header and footer frames. This commit
        simply reenables that feature for headers/footers
        (to avoid also regressions related to the fix i13832).
        
        Change-Id: I46ca112f36e0c0c86342fa34fdb7cb7502745731
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113098
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-21  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [fb5247bf587518eaa01cf5d54dceddf73827d740]

        tdf#55007 tdf#142263 tdf#142268 EMF ARC, PIE, CHORD allow to draw circle
        
        In Metafile specification, if Start Point is the same as End Point,
        then the full circle should be drawn.
        
        Unfortunately with previous implementation, if Start Point is the same
        as End Point, nothing is drawn.
        
        This patch fixes that and removed EDGES optimizations, which causes
        display issues.
        
        Change-Id: I16a1b98f10378d57bed59696db6cc9f228044292
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115891
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-21  Mike Kaganski  <mike.kaganski@collabora.com>  [6155689bb6f1d72f29b43ac5ae94b32522ef9b42]

        tdf#142395: properly handle "no string delimiter" case
        
        In this case, the delimiter character value would be '\0'.
        
        Change-Id: Idb0f01756991b3ea35a92f11b78fddd56c25265a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115839
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-21  Steve Fanning  <stevemfanning@yahoo.co.uk>  [eda109d5d91e82adb675ebf6db952bf6d82b3391]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ab50f2ccc57ebe577cbdad4afa29b66317b87bcc
          - Fix text in 2nd example given in help description of Calc's EOMONTH function.
            
            The statement that the date MUST be in ISO format is not quite correct.
            
            Also add link to updated wiki page.
            
            Change-Id: I20158373f8a67ae90cd1bfccb9fbe1d7c011077f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115838
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-21  Steve Fanning  <stevemfanning@yahoo.co.uk>  [235f570cdc9e57d32257b5c1e599eec24f89836f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 44bd3d8205dd9020b9725a03518cb1316d3062fa
          - Add example to help description for Calc's CLEAN function.
            
            Change-Id: Iae7a1f0b8b84be33f5f54a9a7116c0c48670f917
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115833
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-21  Rafael Lima  <rafael.palma.lima@gmail.com>  [0e503761df294f7a33eeba99a15f03125be97906]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 774b852c14a4a8df49c9ad35e609d8060b9b46a1
          - tdf#141929 Improve CONVERT help and move to a separate file
            
            Updates the content of the CONVERT help page to better match the description in the wiki, focusing in unit measurement and prefix tables.
            
            Also moves the CONVERT help page to a separate file and removes it from the original location 04060116.xhp.
            
            Change-Id: I591ce3d2cd36e224daf5d00593418cba7832e574
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115209
            Tested-by: Jenkins
            Reviewed-by: Steve Fanning <stevemfanning@yahoo.co.uk>
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-21  Olivier Hallot  <olivier.hallot@libreoffice.org>  [ccbadd6c90c63b06534602eccdbb339f4f574217]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 975230c5cd9402e1da8ef50ce31a4682306bfbf8
          - tdf#142389 (part) Fix link to autofilter help
            
            Change-Id: I689ab1d93242a74da72f1792965399f74fbb2f5a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115885
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-21  Xisco Fauli  <xiscofauli@libreoffice.org>  [aa6e9cceddfb154c2207ab316cb7625655452953]

        tdf#142157: sw_uiwriter: Add unittest
        
        Change-Id: I2dbc2f09d61220100fb616c28a8f2557c84f460f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115871
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-20  Miklos Vajna  <vmiklos@collabora.com>  [301278b656e76b6f42af5cf8a6f5c6c02acfffeb]

        sw: allow the height of a line to be larger than 65536 twips
        
        The line height can be quite large if the line contains an as-char
        image.
        
        Found by temporarily changing static_cast<sal_uInt16>() in sw/ to a
        template function to make these conversions implicit (excluding cases
        where the input and output types can't convert implicitly), then asking
        -fsanitize=implicit-unsigned-integer-truncation
        -fsanitize=implicit-signed-integer-truncation to flag the problematic
        conversions.
        
        The first hit was in SwFlyCntPortion::SetBase() (that's where 67408
        turns into 1872), then the same pattern at many other places.
        
        Change-Id: Ie12f490ed8dd5c531f11506c97598ce4f7610e2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115873
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [6cc4750f36fb505e1d7b8d1406f170807fa55644]

        ofz: fix build
        
        Change-Id: I2875536139397070f7e99f1f621d8212687dee47
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115886
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [bb166403ef1026e3665b2d60810c71955d7402c0]

        use toggle instead of click for CheckButton
        
        Change-Id: I7196581a8b7c307d531f6995e1c24db746afdb26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115883
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Rafael Lima  <rafael.palma.lima@gmail.com>  [27c89d6db49855ffad5ec38bb4842f5d30b42a05]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to bd3e4888b2b47d022871218f210b290b7d046288
          - Related tdf#128784 X-ref ChDir, ChDrive and CurDir with SF_FileSystem
            
            The Basic functions ChDir, ChDrive and CurDir are DOS-specific and have limited functionality.
            
            Hence, it's important to introduce the FileSystem service (from ScriptForge) for users that wish to write scripts that need to handle folders and files.
            
            Change-Id: I33e24669083887b540cf44711ec5114e6ae5c521
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115513
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-05-20  Tünde Tóth  <toth.tunde@nisz.hu>  [a2c4a033d49c23d20761b2881135ec3a72f25b01]

        tdf#57351 sc UI: fix disabled Insert Columns options
        
        In a sheet with active autofilter or standard filter,
        Insert Columns Before/After weren't available in the
        context menu of the column header and in Sheet->Insert
        Columns...
        
        Change-Id: I746d7d5a451848306d67d57e42d3981c471c66f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115400
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [f7aca9ed4533f202e87141ca7a65d9949a36c9a1]

        HeaderHdl only does something for the m_xCbTableHeadon case
        
        drop the others
        
        Change-Id: Ibc07996ada54437c44201cb32f70bd594dd4a202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115878
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [253f7af7bcd2337a06c027852286616ff91d2e3f]

        use toggle instead of click for RadioButton
        
        Change-Id: Ia43c3ccae0dcbfb0c522a8c13db6fbfb72bfa4f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115877
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [48182506886230a70cfa2ce3c61470701cb1138e]

        use toggle instead of click for CheckButton
        
        Change-Id: Ic8957a59addbf08f2b2e4e84167991f00048c6a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115876
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [3cf28a1ab93515739e9fd20ffb3a575017ac9e69]

        use toggle instead of click for RadioButton
        
        Change-Id: Icacf5444d65fb5bac4a6c85d9e5c36b98da3e57a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115867
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbd45a00db54af7d960654932ef17eba4ef457ca]

        fix VCLXWindow related leaks
        
        Change-Id: If2c0a599bdfed4c5390c4d3628157c7d942d5cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115870
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [157fb80b9c147c2ab18cb81ee48eab0c8e54b36a]

        split handlers into button click and radiobutton toggle
        
        Change-Id: I375d75518b09a14dd3a5033f2be394fb3e891838
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115866
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [92ed4d92fa2ff02a4c1f168aa17cf871a49c3633]

        use toggle instead of click for RadioButton
        
        Change-Id: I4f91a6f0fb1628a8907848d9d8dffd92d382ecaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115865
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [e292aa04980d0eac776619c9d37812ebff0a333c]

        use toggle instead of click for CheckButton
        
        Change-Id: I6a80946481ee6fc40b2ee207a64287d1a5f96110
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115864
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [f180554caf7d6088d3fc0da805f5c195f8972e6b]

        use toggle instead of click for RadioButton
        
        Change-Id: I2a01d78e2e98b35d2cd24dd7d7d2efda41e35ca8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115863
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [3f8e50f9b2fb35db190ce0204981f3f02d1d5ae6]

        merge handlers into single toggle handler
        
        Change-Id: Ic168e3e0d06d732642dc222f5a3dd056fdb74b6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115862
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [256c834c30c400034ce35744b74dfea7cf70069c]

        Simplify a bit: use one minmax in place of 3 min + 3 max calls
        
        Change-Id: Ief2d8d049d2e05ee762e6855514f75be2f053836
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115835
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [3c41913181f8663f9f1970b13ee038386016d22e]

        move some headers inside modules
        
        Change-Id: I2baa9e9334850cf72e8ea1e96a2177a1c052e589
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115868
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [17085c3072deaf6a44246d6d4be1d7022e0f09cd]

        use toggle instead of click for RadioButton
        
        Change-Id: Ib256324f9d14cc2473e62ec4ffe0a18431e2c9cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115861
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [12bd5e0ae116c0f18c980f3b2ce515432545d0c4]

        use toggle instead of click for RadioButton
        
        Change-Id: Ice24a1b823301834a6bf7d7956df2e804657f6e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115855
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [a8f9b351fe331785823d2bc7ffd3ebec7a0cb1fa]

        only the listbox handler does anything, remove the others
        
        Change-Id: I7c63b21c0902edd4586e6f249d50e6f0d475a851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115860
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [9d146b9418c66d1fd21fe0eb74f1b4daef30a31a]

        fix crash when del in textbox in draw
        
        regression from
            commit 9090dc1f3b27195f5defd35586ac79357992be21
            split OutputDevice from Window
        
        Change-Id: Ib0df6b691f2281c366126c3a0cf3aae985e706be
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115857
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [2601814987fdac8d0b1d655d40987c331f3e51f4]

        fix leak in CppunitTest_oox_crypto
        
        Change-Id: I41d4fe581842cb7822ae899dc6ee6a43e485d211
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115856
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [39001d0ad8de4aa0b8f643aeadc1ec415e1d66e2]

        use toggle instead of click for RadioButton
        
        doesn't seem sensible to listen to the prop checkbox in this handler
        
        Change-Id: If514b5a9072e789b6b2cbfc990714e236335d99c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115854
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [5792b08d3762117dfa28ea08638d79a5b01957ad]

        use toggle instead of click for CheckButton
        
        Change-Id: I73ffd66a6e5eed1f95882e874d9319ecad5550f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115853
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [304b74784297df7cbd0762a2f468ba13b33402bd]

        use toggle instead of click for RadioButton
        
        Change-Id: I8de3daf3799a78c63be2c560afa4a7cc02d63daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115852
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Arnaud Versini  <arnaud.versini@libreoffice.org>  [7a4fffb19fb3d573d9afd3f7136cd0e5b545b706]

        shell : use std::mutex in CmdMailMsg
        
        Change-Id: I2aac780ce17e327a2f5ddbc835583bad1056bfc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114244
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-20  Mike Kaganski  <mike.kaganski@collabora.com>  [825673eac77e2ccef29cfe2d9a1f375c6f5606d7]

        This check is redundant here
        
        The check immediately above this guarantees that
        !rParaPortion.IsInvalid() may only be true when
        rParaPortion.MustRepaint() is true.
        
        Change-Id: Icedeac87b3b8125997640d330b9612eed2cb5095
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115834
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-20  Noel Grandin  <noel.grandin@collabora.co.uk>  [a25385e0d8027d7257ab95a4b787404dfca59913]

        simplify some XMLPropertyState memory management
        
        which fixes a leak if some of the code throws an exception
        
        Change-Id: Ic89060e7951060458ffe7ee5b6fe51cd076ef19b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115830
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-20  Caolán McNamara  <caolanm@redhat.com>  [a69cc693fee8581d1612e79be13e0234ad72cd6e]

        use toggle instead of click for RadioButton
        
        only listen for one toggle for the button grouping
        
        Change-Id: Ie977045288906791319d7df30b3d7737253e3671
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115828
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-20  Miklos Vajna  <vmiklos@collabora.com>  [4e4e02904fdff021631e7758a277b7c1c7b9378a]

        Introduce SwTabFrameInvFlags to replace magic numbers in ...
        
        ... SwTabFrame::SwClientNotify()
        
        SwTabFrame::UpdateAttr_() is not yet updated to produce these.
        
        Change-Id: Ifb534f7ac2b01f7752aace8a57686228d36edbb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115825
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-20  David Tardon  <dtardon@redhat.com>  [5471dc3238e8005fa146cfa0a81c5784ea018e95]

        upload libetonyek 0.1.10
        
        Change-Id: Iad586802e89b19701a20bebff06b238b617af2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115769
        Tested-by: Jenkins
        Reviewed-by: David Tardon <dtardon@redhat.com>

2021-05-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [ade343ea8b498efb88473a0a3879c2711d7dd33c]

        tdf#76258 Skip automatic colors in color filter popup
        
        Change-Id: Ic8ed4b2a503c347895668b18744c9fee02d92e81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115815
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-20  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [9964531fbe6c5805ef823ca3eeb7080e4d42c333]

        Add FIXME for dxf import
        
        Change-Id: I57348aef8a9728d73c5b9d2337f41eb2f9310ba8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115809
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-20  László Németh  <nemeth@numbertext.org>  [05366b8e6683363688de8708a3d88cf144c7a2bf]

        tdf#60382 sw offapi: add change tracking of table/row deletion
        
        This is a minimal extension of the text range based change
        tracking to record and apply table row and table deletions
        with full Undo/Redo support.
        
        Add property IsNotTracked to com::sun::star::text::TextTableRow.
        
        During recording of track changes, deletion of table rows wasn't
        recorded: the rows removed completely with their text content.
        Now the deletion deletes the cell content with change tracking,
        setting also IsNotTracked property of table rows to FALSE. If
        all tracked deletions were accepted in a row, and the result is
        an empty row, the row will be removed, if its IsNotTracked
        property is FALSE.
        
        Note: Deletion of empty lines isn't recorded (they are simply
        deleted). Hiding deleted rows hasn't been supported yet in
        the Hide Changes mode.
        
        OpenDocument supports only track changes of text ranges, but
        not changes of the table structure, e.g. deletion of table
        rows. For the native export it needs to extend ODF, and
        depending on this future extension, can be based also on
        SwExtraRedlineTable (which lacks of recording and Undo/Redo,
        but supports OOXML round-trip of tracked table changes).
        See also commit d688069023959ab97d14eb1dbfd5bf6ad3c1b160
        "Add support for 'Table Row Redlines' in SW core" and its
        follow-up commits.
        
        Change-Id: I2e3807cf8ae8212bd51c210ef1c20c85878d0da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115804
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [cfe0e7dc4d32117ba604e713b8a70eb6576a1fa2]

        ofz: need vbaobj now as well
        
        Change-Id: If06bc0481f91818200b13ad122b08e4fdc09110c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115827
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [feb17e47bc04e2af6b4ecf7202764ce980f83242]

        tdf#142364 exception thrown during destruction
        
        Change-Id: I4e06ac82108e5381cd11fbd6407e1ce1e85c3ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [9e27ac3ed8f2405a94bf07519ca7941731025e37]

        use toggle instead of click for RadioButton
        
        Change-Id: I8fb4a28f4be701858af0ae8e95ff0f45a5401490
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115821
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [14d03bf37063fcf5f0641989b1d0c06c49fe75c2]

        use toggle instead of click for CheckButton
        
        Change-Id: I26e2c0b77e95c99176daf830909824833453ce5c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115820
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [0ab9c2f1d763dd805eb63ba3a5ffa16e63bf7734]

        use toggle instead of click for RadioButton
        
        only listen for one toggle for the button grouping
        
        Change-Id: I4c7f84eda2dfdb873371ae7ba8ede710f373dbda
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115819
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [6815067b75ab79c050d07693a9a1b7e306a4af1b]

        use toggle instead of click for RadioButton
        
        only listen for one toggle for the button grouping
        
        Change-Id: I0c1866c25793ffce50bcf5f5a07fcdc98f64aacc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115818
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [3de15e365d120c92147f79dab082cca395abf75e]

        use toggle instead of click for RadioButton
        
        only listen for one toggle for the button grouping
        
        Change-Id: I937331aebc2391e4026f69f16f9c7c9216981d0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115817
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Andrea Gelmini  <andrea.gelmini@gelma.net>  [c4adc2cffe5758b45633522b2ac42948b54f93c8]

        Fix typos
        
        Change-Id: I800e966cee8343099fb79f08959ba246a831aee0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115826
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [790135003b03b38a14efb7e0d345188607020a99]

        fix leak when removing PageDesc
        
        m_PageDescs owns the SwPageDesc entries, so when we remove from it, we
        need to delete that entry
        
        Change-Id: Ib6dbba227ec64c2d6cfc310b93e1d11397648847
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115824
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [f8c1048eb437b1e685b76198165844e2ecc97a56]

        fix leak in oox import
        
        Change-Id: I5ff21841480d11c4bfae3c34fd12a6fb32e250e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115823
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6989c3df0facf3a5cb373942c337cbc7879fc0db]

        fix crash in X-Ray extension
        
        caused by
            commit 883b7a34d288410ac6f820e91d9eaa65ba2b9cb1
            DBG_ASSERT->assert in UnoWrapper
        
        No idea why X-ray is triggering this, but it seems to work when I dial
        it back to a SAL_WARN again
        
        And also caused by
            commit 5aa60be574ece81b27c8f63e6e809871c694dba0
            fix leak in VCLXWindow
        
        So disconnect the toolkit-window-peer from the vcl::Window before
        disposing the peer.
        
        Change-Id: I3310b76c1affc13c53c1e23810e383a8d2152ec7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115806
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3f72d4d68817210ef6852e83d6d4bbdb540cea18]

        mac packaging: don't throw away codesign output for langpacks
        
        The change to use backticks to capture the output was already done for
        the main package in 6c4cb4e7e0afce2989c9fe596fd74a35eece6206, this
        change now also fixes it for the langpacks
        
        Change-Id: I26dcfb56342b9c3fc7b9c93f7d586c5c899b7232
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115808
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [7bce577cca9e6ca24879affa6398f8fda840d921]

        use toggle instead of click for CheckButton
        
        Change-Id: I0cbe6cd1b93557ceba535a835c4a199761ca5f00
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115812
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [819b30e937d227d1458ecc22b09ef994ebe7e17e]

        tdf#142367 Writer crashes when opening docx
        
        regression from
            commit 5aa60be574ece81b27c8f63e6e809871c694dba0
            fix leak in VCLXWindow
        
        Make SwAnnotationWin follow the same pattern as all the other code and
        return a custom accessibility object instead of trying to override the
        toolkit peer object.
        
        Change-Id: Ifa3a5da2fbbf082e6bb05281cc9d354d6ec3ba03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115805
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [928ce6043523a70d056d15210296d627d6223c2f]

        fix leak in verifyCertificate
        
        Change-Id: I49dd9e0de9b3e44186ed90f00aeb88dad4736374
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115814
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [585948aadf10f6eab7d716857fc671da2d421318]

        flatten SecurityEnvironment_NssImpl
        
        Change-Id: I89e098c7ff913dfbc2cafbf0cdbabfbbca69110a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115813
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [07174ebe5bb5351f19d57ec5123a0efdfb6f5539]

        Sukapura: Update Undo & Redo, Repeat icons
        
        Change-Id: I142d4f49882fcb98bbf6502d0e4a96d212b58e2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115793
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [747394659c5f0aa71053d84fc9fc4bee75fc34ef]

        use toggle instead of click for ToggleButton
        
        Change-Id: I8a1c6620cf009807cc43766b0cc972523e87e9c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115811
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [749be84cefbce1c24b46ab8cc296064216087312]

        use toggle instead of click for ToggleButton
        
        Change-Id: Ia2382e030bb668528e0ad56fd91b19e8621531f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115810
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  U-DESKTOP-042UROI\dhsung  <sungdh86+git@gmail.com>  [be622ccf9b60290d0577314ac9d76fbcf1cce636]

        Delete duplicated item in Korean autocorr list
        
        Delete duplicated item in Korean autocurr list (DocumentList.xml)
        
        Change-Id: I3cfaf27abb859dbcfc849082932006d20d0b22ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115799
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [b8cfea65ddcba33572e9687022de3c813711e298]

        tdf#76258 Add OOXML export for color filter
        
        Change-Id: I4c0e2fbe27de6d48a33aba230c35d3b74854e27e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115789
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-19  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [faf4dbc1aa97ffdfa7f610974b68975d2559884b]

        tell vscode to treat our patch.<level> files as diffs
        
        Change-Id: I770d97b409cd42b4ef697fbde352cb147fa3a995
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115807
        Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-19  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [950eb673b9ad4bc380b13281af577fc8c6842007]

        tdf#76258 Fix color filter popup position
        
        Should be next to autofilter popup
        
        Change-Id: I2ca00fd078d18f8f5c7318115789ffe633a87dc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115803
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [d79b3317d267ffc13da05d08239dd7c8754468b6]

        use toggle instead of click for CheckButton
        
        Change-Id: I914941ff2161688e9c9f1388b42b17523a197a26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115802
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [52aae0c8cd63cf68976bb1c464049cf00d3f942e]

        pass CheckButton argument instead of its Button baseclass
        
        Change-Id: I76f446266fcc74ba2db928ef1c5e764eead57997
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115801
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [5d8ac801c00fbf1dc16ee8dbfe8167baf7ea0ce0]

        SetPhysFont always dereferences its OutputDevice* arg
        
        which is also the case for
        ChgPhysFont and GetTextSize
        
        Change-Id: I7e6a1a7eaa77646c53506a73d8946f8df7593e72
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [457fabbc358930b71884a97ba9ade4bd26310ce0]

        use toggle instead of click for print dialog CheckButtons
        
        Change-Id: If15c354bd54523b5c1cf93a93f8b39382190aa79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115792
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [33972c49d59b3dd7bb8c361e1099cf457194ce93]

        Revert "fix leak when LOK not active"
        
        This reverts commit fd6bdd1a3ec7925b7208a0341248e09b02800795.
        
        I was mistaken, the caller is responsible for freeing the memory
        of the payload.
        
        Change-Id: I0f140640cfa03a3ef626704ae60783f46a661186
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115798
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Alain Romedenne  <alain.romedenne@libreoffice.org>  [7db660de3a1c56aeaece6c88b5c4be5f3c167f4b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6eca503da7d03e8446f2ea9477fd6cdca735f6f1
          - sf_Dialog(Control) Python support - part 2/2
            
            - lowercased arguments reflect Python conventions
            - supplemental Python code snippets
            
            Change-Id: I8a8b10c3b56f539b5f7d75c389654a6772b0b659
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115083
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-05-19  Justin Luth  <justin_luth@sil.org>  [f22d838e03c2ab11d1f408cf86f79f1f5ee75d45]

        tdf#142317 chardlg UI: show approx auto-esc % based on EscProp
        
        Subscripts and Superscripts normally have "automatic" enabled.
        The value shown (in the greyed out raised/lowered by field)
        was showing 8%. Well, that value is true only for default
        nProp of 58%. If nProp is a non-default value, it is better
        to show (an approximation) of the actual percentage that
        is used to raise/lower the character.
        
        [Note: this only affects the initial view when the
        dialog is first opened. After any changes, it will
        show the value in the saved user settings.]
        
        Change-Id: Ife26e0c4f99a41e7568591f0a60cc7068dc3fd90
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115739
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [e179de871b09cc2242e998fde8387cd666f1e9f6]

        Remaining loplugin:noexcept in URE include files
        
        This file is only included from CppunitTest_odk_checkapi.  As that is
        compiled with $(gb_CXX03FLAGS), loplugin:noexcept hasn't caught these on Linux
        or macOS (see the comment in Noexcept::run, compilerplugins/clang/noexcept.cxx).
        And while the plugin could have caught them with clang-cl on Windows (cf.
        95d109fd5f254f694684c0effe447f133872f40d "Document that setting gb_CXX03FLAGS
        for clang-cl doesn't work", all the instances are in macro definitions that are
        never expanded by any LO code.
        
        Change-Id: Ia3f3a0cd89df15bee517cd3a91a2a12a15a7a279
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115794
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [ae8ae3a7fe64db2d309773cd645d9ac5c52bfee6]

        update printer dialog once on radiobutton toggle
        
        just once on a toggle event, not twice for each button of the group
        
        Change-Id: I8586ad5d9127349dce28cb5a9b66dbe0f803164c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115791
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [c4242a448229425e1d432483274d7402f9252396]

        move toggle handlers into ToggleHdl
        
        no logic change intended
        
        Change-Id: I1d6e565f5ed27125d1b455e82bb99e4b0040c7f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115790
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [90e645d4340b110f03dff78dbe35593946948cba]

        tdf#142370 a null response callback should be acceptable
        
        commit 7f032b2f16fad56beea1df826eb59c6f85c71268
        Date:   Sat Apr 3 01:24:30 2021 -0500
        
            tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to open
        
        calls StartExecuteAsync(nullptr) so there is no callback function for
        the response which is a little unusual.
        
        The generic backend protects against a null callback hidden behind
        maEndCtx.isSet() before calling aEndCtx.maEndDialogFn() where isSet()
        checks for a null maEndDialogFn() so do the same for the gtk backend.
        
        Change-Id: Ib5346be37bfba035a00649ff7fb1d66532739721
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115786
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ea4e63248e2400abd71684cf11af2714cb9890a]

        fix free/delete mismatch
        
        Change-Id: I8400e33292605058d1d3f238eae1508528d624c1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115781
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Xisco Fauli  <xiscofauli@libreoffice.org>  [0655560f1b8aff45954682bb92498570f2000014]

        tdf#118637: sw_xhtmlexport: Add unittest
        
        Change-Id: I110404a73ccdbffed788009730967b0efbbaf51f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115785
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-19  Miklos Vajna  <vmiklos@collabora.com>  [1dcd3f1b9fc0d888e047e854a20e9ab2e0afd544]

        sw: fix not needed invalidation of custom field on each keypress
        
        And do the same for modification fields (e.g. modification date) and
        subject fields as well. In all cases the layout already reacts to the
        doc model change via normal notifications, no need to force anything.
        (Confirmed with manual testing.)
        
        This builds on top of commit 0a32630d11ebdb8b8218faa066c72582ef2f300d
        (sw: fix not needed invalidation of title field on each keypress,
        2021-05-18).
        
        Change-Id: I8015b33a6680d75cd5b6446eb9275bb018ea7613
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115784
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [8356700d3a2d8be9c42c8d23247930ecadbb723d]

        fix leak in SwWW8ImplReader::Read_GrafLayer
        
        Change-Id: I898c2380f1b7505c608ef0a865e1b7ca6c6dce25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115778
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Noel Grandin  <noel.grandin@collabora.co.uk>  [419907270821c7bcbaa2b0a4925194a95705c624]

        fix leak in SwCommentRuler::NotifyKit
        
        Change-Id: I8da926f2d2556beed81b4d9e42f9ea57286f6f18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115782
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-19  Edward Lynch  <lynce9956@gmail.com>  [1da19c31d3b8f8e0eba1ffcffe7b89f90c4171d4]

        tdf#108450 and tdf#134665 Fix Impress Grow/Shrink Animation Scaling
        
        Also, change typo from 'veri' to 'vert' which was preventing the selection of
        the vertical option in the 'Size' drop down menu
        
        Change-Id: Ied568a607ca0ac70b481842eee33d54805685116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106815
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [613d3c0bd6e95e777a34d1c7881902e27ec53eeb]

        ImplInitDigitMode never passed null OutputDevice*
        
        Change-Id: I3bfd250015866e056ce789d772c9a41bbae76ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115761
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [5aa4139416d6417564e38e9db0f0062e72ce6130]

        ImplInitLayoutMode always deferences its OutputDevice* arg
        
        Change-Id: I3a0041c702690c495d3f245c4ac00a2f4adf3988
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115760
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [692c5df18ec1f558abe1a3a658c9881cfb7210a9]

        ImplPlayWithRenderer never checks its OutputDevice against nullptr
        
        just pass a reference instead and spread that around to some similar
        cases
        
        Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Caolán McNamara  <caolanm@redhat.com>  [1815aa9472080b9dac263d393b9c922dd16351fe]

        GtkCheckButton no longer inherits from GtkToggleButton
        
        Change-Id: If99a65b19ec04ba4be69730b2c60f53edac9c684
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115771
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-19  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [b238522ca121ca8f863fe4d3394ade088a65ad01]

        tdf#124295 - Always select a 3D scheme in the chart wizard
        
        Change-Id: Ic0a39b4cb6f7af6fbdd99fc93677a0c2d966234d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115671
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [95d109fd5f254f694684c0effe447f133872f40d]

        Document that setting gb_CXX03FLAGS for clang-cl doesn't work
        
        Setting it to
        
        > gb_CXX03FLAGS := -Xclang -std=gnu++98 -Werror=c++11-extensions -Wno-c++11-long-long -Wno-deprecated-declarations
        
        similar to the solenv/gbuild/platform/com_GCC_defs.mk setting would cause lots
        of errors like
        
        > In file included from <built-in>:1:
        > In file included from C:\llvm\inst\lib\clang\13.0.0\include\Intrin.h:33:
        > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/Include\setjmp.h(168,11): error: expected function body after function declarator
        >         ) noexcept(false);
        >           ^
        > In file included from C:/lo-clang/core/odk/qa/checkapi/checkapi.cxx:22:
        > In file included from C:/lo-clang/core/workdir/UnpackedTarball/cppunit/include\cppunit/plugin/TestPlugIn.h:8:
        > In file included from C:/lo-clang/core/workdir/UnpackedTarball/cppunit/include\cppunit/plugin/PlugInParameters.h:8:
        > In file included from C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/Include\deque:11:
        > In file included from C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/Include\xmemory:11:
        > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/Include\cstdint(55,11): error: expected identifier or '{'
        > namespace _DEPRECATE_TR1_NAMESPACE tr1 {
        >           ^
        > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/Include\yvals_core.h(611,5): note: expanded from macro '_DEPRECATE_TR1_NAMESPACE'
        >     [[deprecated(                                                                                                 \
        >     ^
        
        (where the first one comes from -FIIntrin.h that needs to be part of $(CXX) to
        have the intrinsics available in all compilation units)
        
        Change-Id: I1e8f135dd429dd18deb6df33dfa71e2fcbefa9f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115776
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Miklos Vajna  <vmiklos@collabora.com>  [5eaba9431a930a9237904cf356090c04eda81928]

        CppunitTest_sd_pdf_import_test: remove pdfium dependency
        
        This is no longer needed, we only call VCL functions in the test today.
        
        Change-Id: I86257acf6864f672e81b60cec6bd0f90dd89b373
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115770
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [4bea7449711f1832c1db0e9b5447fb2c3415c068]

        loplugin:noexcept (clang-cl)
        
        Change-Id: Ife669f959358992b547b408ab5d1f6bf1c1d14bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115744
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [290dd9379e3f219f140ad6fca1fc01a3cecb6612]

        Adapt solenv/flatpak-manifest.in to recent download.lst changes
        
        Change-Id: I52003259b6ce1a1b11d952204ec84d41de2c965b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115774
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [50b9dcff911e735215a2ad083ecebff5f93cbed6]

        Adapt Flatpak build to switch from qrcodegen to zxing
        
        Change-Id: Ifcaa703d18a5bae03d389ca2fd69924c4c6ec0e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115773
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Jim Raykowski  <raykowj@gmail.com>  [aa56f1338450b2362ce0191b0107d512ebb497c9]

        tdf#137741 tdf#142258 Improve naming of Sw Navigator Field entries
        
        Change-Id: Ibdfe2797f67e30e590b4d1b0b12e9e5639dacba6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115669
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-05-19  Jim Raykowski  <raykowj@gmail.com>  [d8813b799343ae846a320d829e20e3f5f4ecb3a4]

        tdf#137741 Tooltip enhancement for Navigate By next prev 'Field by type'
        
        This patch includes the current field type name in the tooltip for
        Navigate By next and previous buttons for 'Field by type' navigation or
        '[NONE]' if the current cursor position is not at a field.
        
        Change-Id: I0894aeed0f20e2844b413ee399d65978f31fb758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115451
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [128f67e0efa02294205a1abe1be874557ecdcecd]

        tdf#142348 android: Avoid extra refresh after loading doc
        
            commit 1bc42472200c32c9a0a10dd1c3cd6c6a8a5d47d2
            Date:   Fri Apr 9 13:59:43 2021 +0200
        
                tdf#95517 android: Rework app/doc lifecycle handling
        
        changed activity lifecycle for Android Viewer's
        'LibreOfficeMainActivity'. It moved sending an event to
        trigger loading of the document from the 'onStart' to the
        'onCreate' method and added sending a more lightweight refresh
        event the 'onStart' method instead.
        
        However, since a refresh is already done when loading the
        document, there's no need to do another refresh when the 'onStart'
        method is called right after the 'onCreate' method.
        Therefore, set a flag in the 'onCreate' method and use that
        to skip sending the extra refresh event for that case. This
        not only avoids doing unnecessary work but also avoids that
        the two could get into each others way, resulting in Calc
        documents sometimes not being rendered on initial load.
        
        Change-Id: I5c47e1b5f7a42a49fb903891aa84585b36994a4b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115750
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-19  Michael Weghorn  <m.weghorn@posteo.de>  [e96f72184ecdb589bbed6b3b30c7be3bfd726edc]

        tdf#142348 Use transparent background for Android Viewer, too
        
        After
        
            commit e0094d6fe58eaa9a79b546149cf67db521cd1230
            Date:   Mon Apr 26 10:43:11 2021 +0900
        
                lok: add rendering and input for form controls in Calc
        
        instead of properly rendering Calc documents, Android Viewer was
        only showing a blank area instead of the actual doc content.
        (In case of a Calc doc containing form controls, they were
        visible on top of an otherwise white background.)
        
        Using a transparent background by default in Android Viewer
        as well, just as is done for all other scenarios already,
        makes this work as expected again
        (except for another issue introduced with
        
            commit 1bc42472200c32c9a0a10dd1c3cd6c6a8a5d47d2
            Date:   Fri Apr 9 13:59:43 2021 +0200
        
                tdf#95517 android: Rework app/doc lifecycle handling
        
        that will be handled in a separate commit).
        
        The comment already mentioned that it was unclear why
        that should not work for Android Viewer and I did not see
        any apparent problem when testing a bit, so just drop the
        special handling for Android Viewer here.
        
        Change-Id: I3005c5517ce1198af99b27af541fe59eaa896da2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115749
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [92511657969ff93abd31a1368082d3c4dc42d479]

        Adapt loplugin:noexcept to system macro BEGIN_COM_MAP (clang-cl)
        
        ...to silence warnings like
        
        > In file included from C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.cxx:27:
        > C:/lo-clang/core/extensions/source/activex/SOComWindowPeer.h(57,1): error: Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept]
        > BEGIN_COM_MAP(SOComWindowPeer)
        > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > C:/PROGRA~2/MIB055~1/2019/COMMUN~1/VC/Tools/MSVC/1428~1.299/atlmfc/include\atlcom.h(2204,130): note: expanded from macro 'BEGIN_COM_MAP'
        >         static HRESULT WINAPI _Cache(_In_ void* pv, _In_ REFIID iid, _COM_Outptr_result_maybenull_ void** ppvObject, _In_ DWORD_PTR dw) throw()\
        >                                                                                                                                         ^~~~~~~
        
        Change-Id: Iee2619e000963a419b757235d86d7f87944ed46a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115748
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [95e26d3dce4f5a3b2d010d5ca47b4e450905a100]

        tdf#142326: Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams"
        
        ...for libstdc++ 11.2, similar to 1f3dddd6f21d91c429190ae314dadeec409f35f4
        "Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams" for libstdc++ 12.
        The libstdc++ change referenced there has been backported to the releases/gcc-11
        branch past the releases/gcc-11.1.0 tag (i.e., only towards libstdc++ 11.2) as
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=ca7d2f2ec9142995179a5d832a946b50de05e659>
        "libstdc++: Implement LWG 1203 for rvalue iostreams".
        
        According to
        <https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html>,
        <https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html#abi.versioning.__GLIBCXX__>,
        and <https://gcc.gnu.org/develop.html#timeline>, the right __GLIBCXX__ value for
        libstdc++ 11.1 should be 20210427, but at least
        libstdc++-devel-11.1.1-1.fc34.x86_64 defines it as 20210428 while not including
        the above "libstdc++: Implement LWG 1203 for rvalue iostreams" commit, so use
        that value here.
        
        Change-Id: I4e2c6d6ad8156a83f5c4bc861e4a118271928a20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115738
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
        Tested-by: Jenkins

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [4bc32d5a1b236c12d8133782314fe61c6c037cdb]

        loplugin:external (clang-cl)
        
        Change-Id: I0bd38acd8c562f4478831f278e7cfda54268849d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115747
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-19  Stephan Bergmann  <sbergman@redhat.com>  [674e4b01b0d95dc4fe364ee483693557a71ae9ef]

        -Werror,-Wunused-function (clang-cl)
        
        ...since 5686c1aca40beb9514d40c86b4a3780a8a1334ba "vcl: use DWriteTextRenderer
        for vertical writing."
        
        Change-Id: Ia215fb10f9b39fc41f16b6568ce9f461f78f1df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115745
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [3d36ff1a1d94bcdb6facf12eec00a532b6640880]

        loplugin:unusedfields
        
        Change-Id: Ib574403a7f7f8b11c6263c9c19ec6b65c8374ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115753
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [67b5e875c65c5ed72a170a03d33992edd3802c75]

        tdf#118883: sw: Add UItest
        
        Change-Id: I38e7c1a0accf569a70d1d3bc5e04042538afadff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115756
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-18  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [39369c6e67dffe04acc4abb678c1a94526237fd8]

        tdf#55007 tdf#142263 tdf#142268 EMF Properly display ARC and CHORD
        
        With previous implementation the ARC, ARCTO and CHORD were
        not displayed if the corners of rectangle was switched.
        
        With this patch the shapes are always displayed correctly.
        
        Change-Id: Ie8ac7af812298c0b96c3b5af417117784f128ce1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115757
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-18  Noel Grandin  <noelgrandin@gmail.com>  [8cf56338a96c77f4712130cc775d57410bd9b623]

        fix some casts
        
        after
            commit 9090dc1f3b27195f5defd35586ac79357992be21
            Date:   Mon Jan 18 18:27:19 2021 +0200
            split OutputDevice from Window
        
        Change-Id: I2622c9814ec18c98364a7eb18084759f17c80f14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115762
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [c66de7079f5ad92889a28b4a3f18adc4c4cf019f]

        tdf#142337 Button::GetOptimalSize only considered image beside text case
        
        not image above/below text
        
        Change-Id: I5a8e9bfb36cee1460d43478a100e574a3bf1930e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115758
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Andrea Gelmini  <andrea.gelmini@gelma.net>  [ffc59e2b524029adbc775c0a01acc53faaf7c4d4]

        Removed executable bits on picture files
        
        Change-Id: Id9f8297ef6b98630f30d2808e535410360bfc285
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115754
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [81def52473d8de50f7b0570c9867573256b8afa7]

        loplugin:unusedmethods
        
        Change-Id: I8191f4a9eb25b12242354813303fb7d30489d2c4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115752
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [b7c44d7a34027210c06c9936f273fb1a3523a81a]

        loplugin:unnecessaryvirtual
        
        Change-Id: I1c6c4741680d5b49c4e1445d0f4ca7a01fd7e192
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115751
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [12b6cd0233173323ba0a8dbbc3e1197b92336124]

        cid#1484905 Dereference before null check
        
        Change-Id: Ia69cb70cda1ba5bc56bec7d480db1f89b7b9200d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115734
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Miklos Vajna  <vmiklos@collabora.com>  [0a32630d11ebdb8b8218faa066c72582ef2f300d]

        sw: fix not needed invalidation of title field on each keypress
        
        Type a character, SwDocShell::DoFlushDocInfo() is called because the
        number of characters changed, and that rapaints all title fields.
        
        This happens as SwFormatField::UpdateTextNode() calls
        SwTextField::ExpandTextField() with bForceNotify=true, because that was
        needed for conditional text in commit
        cd94a84b89c476760ad74bf088a5d6f8ba4ce209 (125044: - use field's content
        cache on <SwTxtFld> construction only, 2014-06-13).
        
        Fix the problem by not forcing notifications for title fields in
        SwFormatField::UpdateTextNode(): SwTextField::ExpandTextField() will
        send a notification if the expend result differs without forcing as
        well.
        
        Change-Id: I5e46ab6aef33ff5e348d40b8644bcc9cf353c326
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115743
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [acf309d7e45aeae87d8dee0dd2af3c9a86b9f652]

        cid#1484904 Dereference after null check
        
        Change-Id: I4680b1d45eb9770b1891fa23e88be0d18ba47658
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115741
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [c02295e5c4026e3093612a93fb4a28d94755c55f]

        loplugin:logexceptionnicely (clang-cl)
        
        Change-Id: I56a944dbc13d4f2d4ce5b691789e6144a3e13945
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115746
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [eca89ece45ede76605a6102c94b3b67e1f8ff5aa]

        Replace rtl_string_getTokenView with o3tl::getToken
        
        ...to not needlessly extend the sal ABI.
        
        At least for now, o3tl::getToken has a simpler interface than its
        OString::getToken counterpart (driven mainly by how it is used for now): it does
        not support a `token` argument, and its `position` argument must not be npos.
        To meet the latter requirement, the check for "subpath" in LineParser::readPath
        has been reworked slightly.
        
        Change-Id: I4428fe2d9aa03ca83a436fc6493fbc34665a8033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115742
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Justin Luth  <justin_luth@sil.org>  [2f9d909a01f90197c3029a446f8aac8135f53f48]

        tdf#76817 tdf#141966 ooxmlexport: write OutlineRule if not inherited
        
        The previous LO 6.1 version of this patch was fine in practice,
        but in theory the special "Outline" numbering style COULD be
        applied directly to a paragraph - especially during import
        since "Chapter Numbering" is a LO invention, not a DOCX spec.
        
        So, ensure that both the listLevel and the numId match
        what is inherited from the style before deciding that
        writing out the numbering is not needed.
        
        This patch will be needed for tdf#141966.
        
        Change-Id: I9ec4477ed18f84c22a0b5941d0d218186ab6875b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115612
        Tested-by: Jenkins
        Reviewed-by: Justin Luth <justin_luth@sil.org>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-18  Michael Weghorn  <m.weghorn@posteo.de>  [46c71f04c9e1fa9d257c26dd8a8f5e99bbbb1575]

        Drop assert checking address of reference is not nullptr
        
        It was introduced in
        
            commit 9090dc1f3b27195f5defd35586ac79357992be21
            Date:   Mon Jan 18 18:27:19 2021 +0200
        
                split OutputDevice from Window
        
        and caused my GCC 10 '--enable-werror' build to fail with
        
            In file included from /usr/include/c++/10/cassert:44,
                             from .../include/tools/ref.hxx:23,
                             from .../include/vcl/outdev.hxx:24,
                             from .../canvas/source/vcl/impltools.hxx:25,
                             from .../canvas/source/vcl/canvas.hxx:39,
                             from .../canvas/source/vcl/canvas.cxx:22:
            .../canvas/source/vcl/outdevholder.hxx: In constructor ‘vclcanvas::OutDevHolder::OutDevHolder(OutputDevice&)’:
            .../canvas/source/vcl/outdevholder.hxx:38:16: error: the compiler can assume that the address of ‘rOutDev’ will never be NULL [-Werror=address]
               38 |         assert(&rOutDev);
                  |                ^~~~~~~~
            cc1plus: all warnings being treated as errors
            make[1]: *** [.../solenv/gbuild/LinkTarget.mk:301: /home/michi/development/git/libreoffice/workdir/CxxObject/canvas/source/vcl/canvas.o] Error 1
            make[1]: *** Waiting for unfinished jobs....
            In file included from .../include/comphelper/solarmutex.hxx:25,
                             from .../include/vcl/svapp.hxx:29,
                             from .../canvas/source/vcl/impltools.hxx:24,
                             from .../canvas/source/vcl/spritecanvas.hxx:44,
                             from .../canvas/source/vcl/spritecanvas.cxx:28:
            .../canvas/source/vcl/outdevholder.hxx: In constructor ‘vclcanvas::OutDevHolder::OutDevHolder(OutputDevice&)’:
            .../canvas/source/vcl/outdevholder.hxx:38:16: error: the compiler can assume that the address of ‘rOutDev’ will never be NULL [-Werror=address]
               38 |         assert(&rOutDev);
        
        Change-Id: I9e8ef7e91dba847f4894124348f13755fc620fac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115737
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-18  Xisco Fauli  <xiscofauli@libreoffice.org>  [329cc83324f8f361a5383bf7dac2c9c21799dcdc]

        tdf#128985: sd_export: Add unittest
        
        Change-Id: Id6cfeaeaf8484787705f06b7b1acc9a75287546d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115735
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [6f954416bbbf11293d3dc91e534e1b41c4157325]

        gtk4: adapt to new focus controller
        
        Change-Id: I94949f674f98dad218636e191cee11c0fe2bc4d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115733
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [66b4852551aa1838009fac72dc6453bf94de2dd8]

        Use some more std::string_view
        
        Change-Id: I7d4039e87fda447b1d2087b2430a3544e9a1eb14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115732
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Georgy Litvinov  <git@litvinovg.pro>  [f5ac56c9f7f54bb6603f6f1e8dba06da20f7e0a4]

        Don't remove section at the end of inserted text tdf#142157
        
        Change-Id: Ie52721a480e0bbc76d00f0cc5c9182be6476d939
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115643
        Tested-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [ac5b355f7afae4eaddb9e11ead95dfad63fe2b97]

        gtk4: convert width/height to column-span/row-span
        
        Change-Id: I312fa611e125334981a505dd0cc0008f26c0c1d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115731
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Noel Grandin  <noel.grandin@collabora.co.uk>  [7462343cb9c7a61cd28c7eae245f21b6bfc56b40]

        update "add OString::getTokenView"
        
        update
            commit 3669d4ec43a6aa2d410d8351d631548db45a5302
            Date:   Fri May 14 15:51:38 2021 +0200
            add OString::getTokenView (tdf#42374 related)
        with suggested changes from gerrit review
        
        Change-Id: I861d960deaa010740a4aa964e402c4c76a85cbc7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115706
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [5c5b058c83e31e798a63a96d0e16b35927ce519f]

        gtk4: relocate GtkButton image to be a child of the GtkButton
        
        Change-Id: Iaf63de3eeebd575bc664d07b0254577219bf1bde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115730
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [f80c4bfab668f9f72495526fa438f33b11ccaa7a]

        Move per-Parser::parseLine state into its own LineParser class
        
        (together with the member functions that operate on that state).  That reveals
        that Parser::m_nNextToken was always 0 when used, so can be removed.
        
        Change-Id: Iaf27d0503efcc8c7628f2f5f99f6e380c91a3893
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115725
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [0e2389ee8df51c388fa2db441b5b45cdaf6e3417]

        gtk4: use gtk_text_set_activates_default on GtkSpinButton
        
        so it continues to activate-default like it did in our gtk3 usage
        
        Change-Id: I6ef5eacf54faea4fb4985545461ea617db29296f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115729
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [2dc55603806dc9e508eb0d70ddc311a85613ef22]

        gtk4: enable SpinButton
        
        inherit from GtkInstanceEditable instead of GtkInstanceEntry
        
        Change-Id: If0ddb9b36bfbc6c21edd2119c1c1cff0a7285b89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115728
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [c808d2aa92265687827f7890a88cb0d989c31a36]

        gtk4: use GtkText delegate in GtkEditable
        
        so we will be able to reuse it for GtkSpinButton
        
        Change-Id: I4cbb9dd6d15a91b717e1251ceff74502595bc1bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115727
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [90d8186009386dbc6b896ae6041842534805181f]

        gtk[3|4] refactor GtkInstanceEntry
        
        no substantial change intended in this commit
        
        Change-Id: I7f6cd929fdf1e17933cc2a38da8184bcad7eff9e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115726
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [8d56760cb71229b157db0249991a30c1a8cf6e21]

        gtk[3|4] these provide a GtkEditable* arg
        
        Change-Id: Ic4a537389da8397de72e50dd623decee045a7257
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115721
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Caolán McNamara  <caolanm@redhat.com>  [31b44b80c0344d385358614836c73967220bf8a0]

        gtk[3|4] operate on prefetched GtkEditable
        
        Change-Id: I346349957d8d17a7abd5505a0ca284b84a45a427
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115722
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-18  Julien Nabet  <serval2412@yahoo.fr>  [816c2bb27bde42700fd0154cc250e9dcfd5d744e]

        Typo: solt=>slot
        
        Change-Id: I742060932f3408bd40921d91e062a7acee0832e3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115719
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-18  Miklos Vajna  <vmiklos@collabora.com>  [592d7252402048691a1f3e65fa25c059c1b87e6d]

        Related: tdf#138604 sw: advertise AT_CHAR as "to char"
        
        Change-Id: Ia657a590dfc4471e3ad54f1168a257e5f6fc1424
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115720
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-18  baltasarq  <baltasarq@gmail.com>  [43b985b35be324b3398d48585d943f6fb64ae066]

        tdf#112369 allow to disable the add command button in menu customize
        
        Instead of showing an alert dialog reporting that a command is already present
        in a given menu, enable or disable the add command button when needed.
        
        Change-Id: I52b9477896d4775ae2033c057fa1b5bfccb6a749
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115057
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-18  Matt K  <mattkse@gmail.com>  [7f032b2f16fad56beea1df826eb59c6f85c71268]

        tdf#127533 Make Tip-of-the-Day dialog non-modal and allow multiple tips to open
        
        The Tip-of-the-Day dialog is made non-modal and stays on-top of the main window
        while allowing the user to interact with the rest of application.
        
        Change-Id: I51e1a3488ab74d8371b71a8585d1512ce051f637
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113782
        Reviewed-by: Matt K <mattkse@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-05-18  Julien Nabet  <serval2412@yahoo.fr>  [2c4dd73c4c9f471fa2083f9f99dd27a7148f3175]

        tdf#142335: fix bashism in configure.ac
        
        Thanks to Matt Whitlock!
        
        (also reported in https://bugs.gentoo.org/show_bug.cgi?id=780432)
        
        Change-Id: I38fec6faf9a929adf1f300b8c369ec6c16a91ed8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115716
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-18  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [f96bb05489fc6398be5a6f4c574fab5c2c65bdf5]

        tdf#142252 Reorder navigation commands of Calc Print Preview toolbar
        
        Change-Id: Ifd6c1a72b8788a42e47ad9ef83a905d555ef4aa9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115574
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-18  Heiko Tietze  <tietze.heiko@gmail.com>  [a7be44be49ddc0a501f31f13e545a921a3dcc5c4]

        Resolves tdf#142041 - Hyperlink to file location
        
        Follow-up fix to 334838efc12cd1e4a451a8dd7542b93fdaf30bb9
        
        Change-Id: Ic63edcc88401d3db8f3a7737f562deb328485fab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115710
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-18  Noel Grandin  <noelgrandin@gmail.com>  [b0228e4d39656c487300a607117a9e1c6c14620b]

        make --disable-odk the default
        
        Because developers (especially new ones) don't need this, or the
        extra dependencies it tends to trigger
        
        Update distro and jenkins configs so that the ones that were building
        ODK before, are still building it after this.
        
        Change-Id: I5dc71e70dc457b7921a146008d7d2317b199caab
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115647
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [13c1e3d1e13eb0eabccf29dbd57ae9995b805096]

        loplugin:stringview (--enable-breakpad)
        
        Change-Id: I5d260c2bbb875aa57a7eb8e3f80cfc9fc6376804
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115724
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Sarabjot Singh  <saini.sarabjotsingh@gmail.com>  [40e85aadbff8eaeba20ee6a39ca669d282d91005]

        tdf#104169 - Change mouse cursor to FatCross in calc spreadsheet
        
        Added new cursor FatCross to calc. Change mouse cursor to
        FatCross while hovering over the spreadsheet in calc instead
        of earlier Arrow.
        
        Co-authored-by: Mesut Çifci <mesutcifci97@gmail.com>
        Change-Id: I672a058cc702eab0cba6ac953534def915766859
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114679
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-18  Stephan Bergmann  <sbergman@redhat.com>  [2b3879c748adb8d48606339cecaf81a12c19f697]

        Use implicit conversion from OStringBuffer to std::string_view
        
        ...instead of going via raw `char const *`.  (This changes the code's semantics
        if buffer can contain embedded NULs, but it is unlikely that the original code
        using getStr() was even meant to stop comparison at the first embedded NUL.)
        
        Change-Id: I00a0a08b3ba8c318e3b898548ef185efa3f93ef2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115713
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-18  Gülşah Köse  <gulsah.kose@collabora.com>  [81d6ed89d1e5268c2ea4ff527f3e6087dc1d8ccd]

        tdf#142276 Use vertical GtkBox insted of horizontal GtkGrid for the left side.
        
        Keep the layout as simple as possible.
        
        Change-Id: Ie4e77e76dccd4f0a6f41e646ba819dba161b3cc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115701
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-17  Gülşah Köse  <gulsah.kose@collabora.com>  [b1c0734ffe0f395757b6e0cea7830d820231afeb]

        tdf#141677 Make columns sortable
        
        Change-Id: Ib4cb8aaba4c59a7afa347f8010deef41477b77f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115688
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-17  Noel Grandin  <noelgrandin@gmail.com>  [50d8a8c321b17cf5311029467a37e5e163f2bf9c]

        fix is_double_buffered_window
        
        after
            commit 9090dc1f3b27195f5defd35586ac79357992be21
            Date:   Mon Jan 18 18:27:19 2021 +0200
            split OutputDevice from Window
        
        Change-Id: I495d12f2ce499efbc3a3b4a993066860d22690a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115718
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [870f8bef3c52cca36afe4fcd48c1beec104082cb]

        dont leak slot-list in updateSlots
        
        Change-Id: I8882dbd2b5ad7656ec5ff7d47fb2e3dcbcceb5e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115700
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [eb510f21572a35c89ae57ca060a02439e572cbd0]

        gtk4: reenable button
        
        rename label_line_wrap to label_wrap while I'm at it
        
        Change-Id: I3964c4b40d86fb6ef1fd3733088ffd80e57415ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115714
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [47ecc718e466db4d3976b697002f5d0a34b1a885]

        fix some leaks in Signing
        
        Change-Id: I1104e0611dbfbf18858cbae64bfbbbcd03d176f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115717
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [192d7614b41dfeff4e6a507243f3a2948589ba8b]

        don't leak on error path in Coin solver
        
        Change-Id: Ice460975511dbdfcfcde9a829283d2abac14c263
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115698
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [901b05e9fc852333824b6e58d0a30834b1211acd]

        don't leak ICU transliterator
        
        Change-Id: Ib2c09c6c63b94d078ddde15585caa59710953bba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115702
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Julien Nabet  <serval2412@yahoo.fr>  [08ffd34d5274e745a1400c70f94fc297f5ad8569]

        Simplify some initializations in connectivity
        
        Change-Id: I980b59f06fb6004ba23279c8364cb0587e7ac8fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115679
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [4d52d2bc81f9d27472fe368785912a530489d046]

        tdf#142165 restore a SwShellTableCursor if the orig selection described that
        
        so that we are operating on the same selection that existed when the
        dialog was originally launched
        
        we need to avoid the assert of
        
        commit 6db71f70a3b200d4074f6cda8ce445e9861d3296
            tdf#140977 drop possible table-cursor before setting the new one
        
        and support the multi-selection of
        
        commit e08b446e46f56e15af58fdd4396afba1a316f9e5
            tdf#140257 duplicate entire PaM ring when making copy
        
        and support not scrolling to a different location on changing a table
        page break style of
        
        commit 9c61732677d038e32b73fc9fb883aced14c0febf
            tdf#135916 just set the target table as selection
        
        and keep making it possible to remove aa page break on a table of
        
        commit 81f91196b98af38e29af451b86c26a893a109abc
            tdf#135636 the selection at dialog-launch time is lost by dialog-apply time
        
        all of which is necessitated by
        
        commit c3a085d22742f88e91ff92f319a26d6e8d1d9a98
            lokdialog: Convert the Table -> Properties... to async exec.
        
        Change-Id: Ide5f953e63da46a8750e85d623310af0062b048b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115709
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [c29f91f3d7a0deb902b900ff07e6c32632b8c958]

        sc_ucalc: move formula tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        Now, we can change CppunitTest_sc_ucalc.mk to
        use the template
        
        - Enable testExternalRefUnresolved on Linux/Mac
        - Remove testFormulaHashAndTag. it was disabled in
        f4dc8a869ac49f19c20fc5fa606448e9103726bd
        < the idea behind the test can't work right now >
        
        Change-Id: I864341442ccd321c8ef4f7147db4512bcc7a6b21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115595
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [9bbf8057d9d92857aa3c693c1387589ad378695d]

        sc_ucalc: use DoLoad instead of DoInitNew
        
        In 145b2d8ee131dca592a41f7b26341a542a23845b
        <sc_ucalc: restore formula options after using them>
        I wrongly assumed that the formula options have to be reset
        back to default after using them.
        Later, I realized that was not the reason why some tests didn't
        fail when executed individually but failed when the module
        was executed as a whole.
        After some investigation, it turned out the problem was caused
        by DoInitNew changing the defaults separators.
        Why? I don't know, but using DoLoad seems to fix this problem
        
        This change revealed that Test::testMatrixConditionalBooleanResult,
        Test::testFormulaWizardSubformula and Test::testTdf93415
        were relying on other tests and failed if executed individually.
        Adapt them to use the default separators.
        
        Change-Id: I08c1d88d7c6411592cc9a5779bfaa2b3bb6429ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115704
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-17  Eike Rathke  <erack@redhat.com>  [def94a6b50f02682c3f04ce3171665c703c47b2c]

        Resolves: tdf#128314 Use GenitiveMonths name also if comma is following
        
        So 'D MMMM,' works the same as 'D MMMM '.
        
        Change-Id: Id910c67174260401b9c37672f189d550480793a4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115708
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-17  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5c682a5e24337ac022fb3eba585583b16718d246]

        Fix types and order
        
        Change-Id: Icd98c02a3bdc361423f668173bf6feb5f5b11e4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115703
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-17  Andrea Gelmini  <andrea.gelmini@gelma.net>  [817b438ef587d79350963738619d8669dffbccd7]

        Fix typos
        
        Change-Id: I4be77bf074f93fc978e34e5ba4c4693896e4c467
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115645
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [c781776f3c79bbe3175b1452d26c79ebb931a500]

        dont leak NSS Arena in svl::crypto::Signing::Sign
        
        Change-Id: I0c94c4f6035c1346468bbe78e94faea0cc714da8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115699
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Miklos Vajna  <vmiklos@collabora.com>  [d7d43cf460d66354a40ffa3b34c0f9efcd42d0be]

        vcl PDF export: fix re-exporting PDF images with arbitrary page-level rotation
        
        Building on top of commit bd520b177637d4b7d9d93733103cff17a3c91b0a (vcl
        PDF export: fix re-exporting PDF images with page-level rotation,
        2019-11-06), this was already working for 90 degrees, now generalize
        this to work with 180 degrees as well.
        
        Change-Id: I5a5d51662399814d5554d7c2cb86a6c9a2974012
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115705
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [6aec5d5a3a26bd973e46b6c593373e2f03f51a37]

        small perf improvement in checking for note
        
        Change-Id: Ib92e04da47d910662eb765c9c68b561647570ecd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115673
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [a78770c1935cabaafbb1d0bec258095b8899d25d]

        sc_ucalc: move copypaste tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        
        While at it, fix the clang-format issues in
        sc/qa/unit/ucalc_copypaste.cxx
        
        Change-Id: Ifd3af351f4b880da29e1f48c4852ac65fcd3276e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115696
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-17  Noel Grandin  <noelgrandin@gmail.com>  [9090dc1f3b27195f5defd35586ac79357992be21]

        split OutputDevice from Window
        
        as part of a longer-term goal of doing our
        widget rendering only inside a top-level render-
        context.
        
        I moved all of the OutputDevice-related code that existed in vcl::Window
        into a new subclass of OutputDevice called WindowOutputDevice.
        
        Notes for further work
        
        (*) not sure why we are getting an 1x1 surface in
            SvpSalGraphics::releaseCairoContext, but to fix it I clamp
            the size there
        
        (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice
        
        (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code?
        
        Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Julien Nabet  <serval2412@yahoo.fr>  [c8cf2e0e088b74afa52564945a9c005b3b86bf7e]

        Directly initialize maps in ADatabaseMetaDataResultSet.cxx
        
        Change-Id: I40d88f6b538c1c38589b8cadc8c174ffa6754940
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115599
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [eafad0719f50e34dadf9a32c2fb24cf00047f6eb]

        tdf#142303 connect adjustments to spinbuttons
        
        missing since
        
        commit 87e21946fa9a81c403a146d03579691537c1352c
        Date:   Sat Aug 17 20:41:26 2013 -0300
        
            Convert text animations tab page to widget UI
        
        Change-Id: I8eba96030a1f5060ba60166d462130eb2cef1298
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115694
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [89613ba316f271d3d742757692d5c3d802a39c0a]

        remove some unused suppressions
        
        Change-Id: I0e427fe61eb1986de7118561c7efc4a5eabeb868
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115693
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Noel Grandin  <noelgrandin@gmail.com>  [dd5666a0425935f2389811abf750f435411e3fe0]

        fix leak in CommandDispatch
        
        Change-Id: I0249b18fd40f4f5ef95e2101286dc25782c42eb5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115684
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [d8d15656817a58a5e9c6a6ebc88038ba4e5ef865]

        small perf improvement in readMemberValues
        
        Change-Id: I5d5973401a87b69dd54721d16ed19e227a6c2ac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115674
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [cfb9fb3c8ab861e53306f1a2362784446abe903a]

        cid#1465676 Unchecked return value
        
        presumably unchecked return is ok in this case
        
        Change-Id: I2aee2714e924d496ea54b2b02019dd12becc1c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115685
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Miklos Vajna  <vmiklos@collabora.com>  [b9496faebcdf8827864636803101c6a9a88b6155]

        EPUB export: make sure txtparai.hxx is self-contained
        
        txtparai.hxx was the first include in txtparai.cxx to make sure the
        header is self-contained, restore that. (Ignoring sal/config.h.)
        
        Change-Id: I430e1bef12191e15f416381cd8d83c503b284851
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115692
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-17  Noel Grandin  <noel.grandin@collabora.co.uk>  [fd6bdd1a3ec7925b7208a0341248e09b02800795]

        fix leak when LOK not active
        
        Change-Id: I7124adfdc4e877fc63805956b3d0c087b1ffb5f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115681
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [49fd5ed7f040eaa2352b2e684c1349f42db3ac66]

        cid#1484877 Unchecked dynamic_cast
        
        Change-Id: I17e93665482a401bb9ffe489f0f9d35302675adf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115686
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Miklos Vajna  <vmiklos@collabora.com>  [44c5a8977aa77d99abc0c179a4f5b9df55c17ec6]

        sw: prefix members of SwASCIIParser, SwASC_AttrIter, ...
        
        ... SwTableProperties_Impl and SwViewShell
        
        See tdf#94879 for motivation.
        
        Change-Id: I7c8fe1f95d9ff1dbd7b9980845ff7fdfb36d1e26
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115691
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [9836a4796a3afacd96dff4be53dc4db527fbd3dd]

        cid#1484879 Uninitialized pointer field
        
        Change-Id: I8ad6984faa52aa262a78bc9e9a47c9b19d30214e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115683
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [6e0d2738a5df0e16ebf343f44ef858aa81c18ab8]

        cid#1484878 Uninitialized scalar field
        
        Change-Id: If7ed90b34a44f73e35080d4967618af3c215b50b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115682
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Caolán McNamara  <caolanm@redhat.com>  [921f770d8980dc0dbc70efee0db872e329f99565]

        gtk4: put cancel at start of GtkHeaderBar
        
        Change-Id: I606a7467529fbe9921702476d2aa4277a0b19580
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115666
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-17  Tor Lillqvist  <tml@iki.fi>  [7527afeb305bb01340461f6fddf6d13a5acca3e3]

        Don't use the macOS system German spelling dictionary for Swiss German
        
        The system German dictionary accepts 'ß' which is not used in Swiss
        Standard German but completely replaced with 'ss'. We assume that the
        LibreOffice German dictionary is installed, too. It has correct
        spelling for de_CH.
        
        It would be good if we knew in the macosxspell code whether the
        LibreOffice German dictionary installed, and act correspondingly. But
        figuring that out seems more complicated than what I am willing to
        spend on this for now.
        
        Change-Id: I380d7734cea34a2408d9ed20a8c3d9efe6a8fea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115690
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-05-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [277df648f44221d35e2acbbb9bda604e5b121b47]

        Sukapura: tdf#141885 New Paste As Link icons
        
        Change-Id: I77dfd53908dfc32de51997a0db8f7df5eb366795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115658
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-05-17  Xisco Fauli  <xiscofauli@libreoffice.org>  [91330c503b7eb91d777978018b66890af87cf8f5]

        sc_ucalc: simplify code
        
        Change-Id: Iabe0cae921023e76a02ce6a479e58eb51dcf237b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115687
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [2dbf8d8cceebde01d3113f7cf44d133c3c8c90e2]

        elementary: tdf#141885 New Paste As Link icons
        
        Change-Id: Id6addc87da51e50c374eba3d8b7b373b83379324
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115657
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-05-17  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [4783f249c9b1dcc072d9ebc9aed18d885c23c35d]

        Colibre: Update Calc MIME Types icons
        
        Change-Id: If419aa61f80b775dd39526318f71f0d6fe9875f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115680
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [39270f32a2d93df691f61ed6a38854d611196e87]

        sc_ucalc: no need to have one cxx file for just 3 tests
        
        Change-Id: Ib56e14735e575606519b60d73ec539be86b01cc5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115678
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-16  Xisco Fauli  <xiscofauli@libreoffice.org>  [ff2e562cd2ef8f6c08180bce16d2c4000a8aa841]

        sc_ucalc: move conditional format tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        
        While at it, remove testCopyPasteSkipEmptyConditionalFormatting
        it was added already disabled in 5915d38e84c7a7861c169bea18c63824bcfdc470
        <add disabled test for conditional formatting with skip empty cells>
        and it fails if it's enabled
        
        Change-Id: I6222849b38ab288b24432dc00698d72f5bcc5c2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115677
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-16  Caolán McNamara  <caolanm@redhat.com>  [27db3bfede6a74a00da20062db6fd6c47d4d9df1]

        gtk3: remove fallback now all dialogs are complete
        
        Change-Id: I02c1e435819b704d5849bcb27097dae7f1ba03f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115667
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [1070cd26d80399036ae11d81ddb62c0c5601b315]

        speed up package test
        
        Change-Id: I9e0e2520a9851923d2910a2e487dab589b23eafd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115672
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [203288c830041b41268f23b9aed5ad786a8e7ae6]

        fix leak in ScSubTotalParam
        
        Change-Id: If839585931fc90b9910f6b95338d59ba48a1a78f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115676
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-16  Noel Grandin  <noel.grandin@collabora.co.uk>  [a0796ca91174e317cdf280a35fb6a5dad2aef66f]

        fix leak in ScFiltersTest
        
        Change-Id: Iff8c913b93bdd03c26f6f639922e23d33e4a7839
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115670
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [58b0c95ad50139a62bddb348d10f94053c09cd5b]

        gtk4: reenable Entry
        
        cut/copy/paste is speculative
        
        Change-Id: Ib5ce57eef5c260aea10cc3d57e3d3ac84db5d00a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115665
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [e3fa56977c585e5f354319ac70b15d42e9a84f74]

        inherit ComboBox from Widget instead of Container
        
        Change-Id: I7f6b6e90e08c710672335ddffaa41e385d33611f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115664
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [609416ca21aa2912908ef46d1129deec3cd24bae]

        inherit LinkButton and Notebook from Widget instead of Container
        
        Change-Id: Ie3940d712e2e60a59234aff34daaf6003301fd15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115660
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [82b08515fafea688001ec3b77e0874ee87e44ac2]

        inherit Button from Widget instead of Container
        
        Change-Id: Ic4f444d615e732f5d87ccde0cf10484d2ab679d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115661
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [20e76b48b93a57043721abdaa498bc2bf334e041]

        sc_subsequent_filters: remove unneeded code
        
        Change-Id: Icd6b69df505abbb6178a57b15d898351f6c530da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115663
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [65d6dc999c3e453498a007273cea26290c720f4c]

        inherit Expander from Widget instead of Container
        
        likewise TreeView and IconView
        
        Change-Id: Ic51b88ba9a63706443e8a34a971168702ddce418
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115659
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [e923f752a3adfe1a941dcbc2fdffc626a569d59e]

        tdf#117957 WMF Add support for selecting colors from palette
        
        Change-Id: I8f995dab566d9fae79d87fe13741b8ea9658b408
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112998
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-15  Johnny_M  <klasse@partyheld.de>  [c1903d286febb512e06783c4e8b46a38a2567cbf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7f646d0dacc492439ab58f584c2b65b05cba9694
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icc11f2359f7e1f862223e6ff6ff08ec54af78edf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115656
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [2cdfbc37316ae79dba2bd235504678e9c40ac42b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 575f66844eebc769d783156312c34022617c98bc
          - tdf#132643 Translate German section IDs
            
            Change-Id: I7548928ccb4c771193ea33ace6a717a20c554bc4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115655
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [918f6614077c8839a89f2daf7d608404854872ee]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b59e280a25ac2146d4b349b17e5b84f583d42d3f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I03d68fc6338bbc3ca3a92f2a3c001df44eab5288
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115654
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [cefbccddb4e715ac88ee61b4612badd791f64339]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c1229f0e2d1f0efca59d14ce47fc949d943e69f
          - tdf#132643 Translate German section IDs
            
            Change-Id: I72e43458a3af0af9ae417db081fee8d0f0890ae2
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115653
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [eae1015e6dc546cfeaa24ab8cbb7ae25f994e257]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6c7e4b98f967fafed9ce95c57c728468a4151eec
          - tdf#132643 Translate German section IDs
            
            Change-Id: I636ad9fcee5ce790234b41cfa078d9c1175d3b0e
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115652
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [e86c1701120e9bc8888d341712d7f9ad77174b81]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 13a43eef6b8452f3f13e3d3b5f0266cf7ca141e7
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iab660ef9810902be11dd51c830e1a6f537352427
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115649
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [db61bed81372fabc1b74e8e3144b17a609c53863]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1110a8df87c91d368792cf5130c1b5f3a1604c55
          - tdf#132643 Translate German section IDs
            
            Change-Id: I87a9d0e09239fc3e6c696f348457c59aff681886
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115651
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [94d483f5872ed74938514bdd2bcbd30e4d70eaa4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f2b6511ca116fd17c8e48902ea1a671697976fbf
          - tdf#132643 Translate German section IDs
            
            Change-Id: I92d9f5801502c97a947400e7644b1c36b6fc3dc9
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115650
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [8fd967fbe4f9d1f97f1c10a1e5a00f8996305147]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7ec8660d3e02830b06b04718a399d81d7d0738d2
          - tdf#132643 Translate German section IDs
            
            Change-Id: I1b4dd524f22d5a84dafcadae97b7f52edf42cc6f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115648
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Noel Grandin  <noelgrandin@gmail.com>  [3662b0c6b734f0725cecdc49b355d853287e2dd6]

        improve FmXGridPeer::dispose
        
        (*) make the logic more explicit, the existing logic would try and
        do stuff at dispose() time that was potentially problematic
        (*) dont dispose the superclass in the middle, that means various
        things might go away before we're done with our own logic
        
        Change-Id: I9581ea5044b0e1822c235e85cf5827ff61ea7a3c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115646
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-15  Johnny_M  <klasse@partyheld.de>  [d935af8f3ef029e91f37605fa65b6ca51e4b1c55]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6fc8af50dab46c8f961a0f5c0d78cba334290130
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iebd7e96b4f3040e289dce3e9871a5395ab1fbafe
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115557
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [1b6e369bfb07641783a9537b1ed71a0ea3b1ecb7]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 69e8428e576fc3abd231a7d9b7ee30b466669ff5
          - tdf#132643 Translate German section IDs
            
            Change-Id: Icccc6bba110c5fa51f12136e4fbc9d81280ad3c8
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115556
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [763144852e38c1a981bdf3a6286d6accda9ce389]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f3d189e26d6e2b7b5a1009d6b111467677935c92
          - tdf#132643 Translate German section IDs
            
            Change-Id: I0f0beecd3735a71a892e88b39820b742466a02e5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115555
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [ef1222ea00a22421e010bb487e96b460d444a864]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 465271d61bd2283f1c94401f32ebaeb178eced97
          - tdf#132643 Translate German section IDs
            
            Change-Id: I84632d58ddbaa850545cc869e1cf73b5d5070e0a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115554
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Johnny_M  <klasse@partyheld.de>  [bb93237fe3d64e79fd7ea5c5183bd0aaec2700f3]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 9978369f6bff46c4ad81f1613d8e0868b5790f35
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ib6cd1b3d8fde7b33d1c99403dd74a71b3e1c39db
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115553
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [5b0deaba0067143b20948b8efe0eea5937aaa3df]

        inherit TextView from Widget instead of Container
        
        Change-Id: Ic8ad23beaa6a3c2de74cb554f9b9c5aea6a78639
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115637
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [e920e6d600a4c4504cbc04b89d4078dd49e2df66]

        gtk4: strip GtkSpinButton properties that don't exist anymore
        
        presumably due to de-inheritance from GtkEntry
        
        Change-Id: Ibbe7f4c05025123f2ebd594ed157bd346e3a237a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115636
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [67942980133c11b8aa99b9687df7599d4e718659]

        gtk4: allow querysavedialog too
        
        Change-Id: Icedf5e355839239dd4957714a49b3705b2aaf4e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115635
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Caolán McNamara  <caolanm@redhat.com>  [7354ae9449bf9e325eb96eaa18d35ee68d304295]

        gtk4: get cursor size and text selection color
        
        Change-Id: Ic24b5bdce9a868dc5e00da4ad2431108c5b0aceb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115634
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-15  Xisco Fauli  <xiscofauli@libreoffice.org>  [9b4a3fb16f2db09a61a4b53f40f1b3c15540b123]

        sw: split CppunitTest_sw_layoutwriter into 2
        
        It already has 2 cxx files
        
        Change-Id: I74aeea953568b82aff3130b20547a7c207783431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115628
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [549cb9eb369b25b3f5ff638cb47c6eccd3c414e9]

        Fix typos
        
        Change-Id: Ib14daf2abf02c7deae0090f73130eee0f5720ad3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115459
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-15  Andrea Gelmini  <andrea.gelmini@gelma.net>  [0e99a5703eaae89dafe24fc03fd177794ae0bd1b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 60d3be1783a2a2aca54600037238c26e26876888
          - Fix typo
            
            Change-Id: I20b2de6acdf4a065958c887b97e718001e9389e1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115644
            Tested-by: Jenkins
            Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
            
2021-05-15  Noel Grandin  <noel@peralex.com>  [3669d4ec43a6aa2d410d8351d631548db45a5302]

        add OString::getTokenView (tdf#42374 related)
        
        small improvement to PDF import
        
        no need to construct temporary string objects when we are just to
        going to convert them into int/double.
        So use a view and convert the data through the view.
        
        Change-Id: I824fe88bf17142b48fe6032e10c0f3a111927e96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115616
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-15  dante  <dante19031999@gmail.com>  [63b897c36afbfb85e0dd45907f76727f7dee494e]

        Use less memory for ScMatrix::Collect
        
        The old definition would have unused mnCount s.
        The template has been modified to expand functionality.
        Redefined operator for sum and sum square.
        
        Memory usage change explanation:
        
        The old code would use an array of IterateResultMultiple.
        Then use them to iterate.
        The count is stored in a last IterateResultMultiple.
        
        So if we are inputed N operators we are:
        Wasting N counters.
        Wasting 1 accumulator.
        
        Solution:
        We move the array to the accumulator place (inside the structure).
        Then we use only N accumulators.
        The structure with the array has only 1 counter.
        
        
        Change-Id: I76de74214d9bcb245f009e1226020bfe4dce40d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115542
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-15  Rafael Lima  <rafael.palma.lima@gmail.com>  [7e8e7bdd5ee037d6ce627a941bc25561bbaf0584]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c998e3e9419895a15c87412b5bd8efdbb18e0c0c
          - Python support in the SF_UI help page
            
            Change-Id: I3d5614d7f2ae24a15718237d817527a4d7421aa0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115199
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-05-15  Julien Nabet  <serval2412@yahoo.fr>  [2668f93205e5c006d1f8228aaef8dda0403bc08a]

        Fix regression in "Directly initialize vectors in sfx2/ObjectInsp..."
        
        Change-Id: Ibd975c4da8ccfd44f5c2b779774a3834918603b0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115591
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-15  Jean-Pierre Ledure  <jp@ledure.be>  [1054cad056cc4f8f1823c81ec340b468024eb78c]

        ScriptForge - (scriptforge.py) None as default value
        
        CreateScriptService() does not accept keyword arguments.
        
        In Basic positional arguments may be skipped, not in Python.
        This makes
            CreateScriptSevice('Dialog', '', '', 'myDialog')
        rather inelegant.
        
        Only for the Dialog service, None is accepted as default value
        i.o. '' for the Container and Library arguments.
        
        Change-Id: Ib96e23373140264c7100f174c7704ed32351f124
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115629
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-15  Noel Grandin  <noel.grandin@collabora.co.uk>  [d7bc3b5d3a55f621ee7eea2bc89ce1234b0b9db4]

        unnecessary cast
        
        Change-Id: Ib08132199c343a057a398a50dc09ccab92ab944d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115632
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-15  dante  <dante19031999@gmail.com>  [112c9d4b2d8a6393f52697c928e8ace06782b6e0]

        tdf#137679 Use KahanSum for Taylor series
        
        Change-Id: Ic399616e0af45443e54c708d2a5b7326a6bbd06e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115389
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-15  dante  <dante19031999@gmail.com>  [7beb507edbf94627c639483175be730f38f90dcd]

        tdf#130654 editable smeditwindow zoom
        
        Setting only accessible from advanced configuration.
        Access: org.openoffice.Office.Math.smeditwindowzoom
        
        Note that the change won't take immediate effect.
        LibreOffice has to be restarted to the change to take effect.
        Math configuration entries are not synced correctly.
        More detailed explanation can be fond in tdf#132145.
        
        Change-Id: I0017ddda73ab2916c6ad1fa238265d57a2a3020e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114616
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-15  Eike Rathke  <erack@redhat.com>  [cb63fad5a1967d20d067cd4ee2c8ddc7ba8ff1ea]

        Related: tdf#128314 Add unit test for NatNum12 lower names
        
        Change-Id: I909a730111985905e2054b03dbc26e9bab7df92c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115641
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-15  Eike Rathke  <erack@redhat.com>  [e8c373d1da87256933ece80b896ecd0f03c8cb43]

        Related: tdf#128314 Add NatNum12 modifier 'lower' attribute
        
        Similar to capitalize, upper and title.
        
        Change-Id: I5933362e69ebbc3cf31de4258aceec5677b76653
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115640
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-15  Eike Rathke  <erack@redhat.com>  [eb7a2bd2f1efa587fe0ebeff86e5e18760b9b465]

        Related: tdf#128314 tdf#137349 Add unit test for NatNum12 upper names
        
        Change-Id: Ib71b6bc12471322f0a66eced2258045a563cbb07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115639
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-15  Eike Rathke  <erack@redhat.com>  [84df9a567aa35ff84b2bd6f53432cf8ea9f4b218]

        Related: tdf#128314 tdf#137349 Support NatNum12 for all day and month names
        
        Specifically capitalize, upper, lower, title.
        (Of which lower is still to be added).
        
        Change-Id: Ic3c44606b0fa6a39c332ab6a448c8d2280df877e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115638
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [141f3e101508e7d0a83bd34a5cf48673fe91e44c]

        Directly partly initialize vector in access.cxx
        
        Change-Id: Iac19920caf0a9bdfa07b025c19c7659b96374c7e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115590
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [e01786898406130aa81eadc32f7bc2fad65c5344]

        Directly initialize vector in connectivity (part 3)
        
        Change-Id: Ie7f74a3f0fa865994057575b3dfac2bc209c6793
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115631
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [be96aa21aed3069775609780566541b3631cbbe1]

        Simplify a bit initialization in sharedresources_test.cxx
        
        Change-Id: I5c3fb9fffc9ac541536a8e9cf824789d9c107b3e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115597
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [3adfa35cacdbf3063b45b486995dbe1cb103d0b4]

        bump product version to 7.2.0.0.alpha1+
        
        Change-Id: I77c77c88eac413649279d104fecea0799f5046d0

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [ad875b928780885a762e91af9b91768882616eaa]

        gtk4: advertise as gtk4 not gtk3
        
        Change-Id: I7f38238109f79cc8b87d41999a8355879761a894
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115626
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [79ca3d06eff77229ce5227113a510e8153afb5f4]

        gtk4: get some theme settings, colors and some default sizes
        
        Change-Id: I6497de11b1b8bb32b679cd74a866fc001567d815
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115625
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [8e6417164d1fc2ef51e8eb703d8395de464c9111]

        gtk[3|4] wrap gtk_style_context_get_margin for different num of args
        
        and similar
        
        Change-Id: Ie432e75658769fbd9cbecd2108d3f3a996bf6afd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115624
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [e2b6143c0942f49bbc41861b353efb5dba9a7467]

        gtk[3|4] wrap gtk_style_context_get_state
        
        and provide a feeble gtk4 fallback
        
        Change-Id: I99fd965ff661d299b6f0cdfc17aab135faadffdc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115623
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [d77851db98a5f1f02122255ec9f8e955887c76a3]

        gtk[3|4] wrap gtk_style_context_get_color for different num of args
        
        Change-Id: Ib1bc35b2edca9e1e841cec11bc7c0347b983296a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115622
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [2d616d49a0108d06fb972442e15589db9da1681d]

        gtk4: clear parent widget can-focus of False if child has can-focus of true
        
        Change-Id: I44e069f65ca52897f1ca97ab77644cda1a6cea2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115604
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Martin Srebotnjak  <miles@filmsi.net>  [a1555567bf564c4b3cca2dd54b768be9460dec2f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 48ffdf216a07738135223c4f95e9f942be8a5dd9
          - Slovenian translation fixes
            
            Change-Id: If37efb1022635028ec8e9d1a66d20d3c6d8ebccc
            
2021-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [233fa432256603812454cbdc372059afade50942]

        Revert "improve perf of xmlreader::Pad"
        
        This reverts commit de5af8315e014ce3408f66c6de3c9c4e841f8437.
        
        Reason for revert: this commit needs bounds checking before it can reland
        
        Change-Id: I686a533cc27fc4644cce918ca64bd168bba19617
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115518
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [46d3e84d7a131f7c72cb536ab2f314cb55ffc155]

        Directly initialize vector in connectivity (part 2)
        
        Change-Id: I4dc9862a30fc584e600d2952d1110a1ebbcd160d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115611
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [2d41535a89f2540800494cee339da2c71cdb9666]

        Directly initialize vector in connectivity (part 1)
        
        Change-Id: I3b0bf1ca710aba58d7d649687b5d791374be8d6e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115610
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [6aca0107c25b2cf0b26ed09c6ea3917e85542d54]

        Directly initialize vectors in baside2b.cxx
        
        since we've got all the information from the beginning.
        
        Change-Id: I58dff3fea715af09f3027d92c0504c3e27015f1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115584
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Noel Grandin  <noel.grandin@collabora.co.uk>  [ec996f7fc26601a6b5bf2ea12890316905662e40]

        tdf#142255 Crash when trying to insert a shape
        
        regression from
            commit 5aa60be574ece81b27c8f63e6e809871c694dba0
            fix leak in VCLXWindow
        it's too dangerous to dump the Impl during dispose(), because if I do,
        the Impl is removed while we are iterating over listeners.
        
        So just be check mbIsDisposing more heavily to prevent new references to
        the VCLXWindow being added after it is disposed.
        
        Change-Id: Ibb00a289440d24f531072ef5809613d5e8a0a98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115598
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-14  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [d8b0cae3b23a6a8b0c884f6022cedaa7270f50cc]

        Update git submodules
        
        * Update translations from branch 'master'
          to 8b7f5b16e211c9309c744b041802d371306bb7b0
          - update translations for 7.2.0 alpha1
            
            and force-fix errors using pocheck
            
            Change-Id: I9e0690c94cd2181567a33621278f7b94b9cc2313
            
2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [23b39541ddab1bcbeeea9cb6ecb7b5f18d4220a3]

        Directly initialize ODatabaseMetaDataResultSet in CDatabaseMetaData.cxx
        
        Change-Id: I32af6d9c699689b688d996c56fd5f64c5ed2f71d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115608
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [b6d6a3f34163eba45691387dfe2748f7a1788f6a]

        Directly initialize vectors in VCartesianAxis.cxx
        
        since we've got all the information from the beginning.
        
        Change-Id: I4045c8fd5ab5653cd390ceb29cfef76bd6c520a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115587
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [ee2199a4356c9a74b4a3e817f7aef268efba5123]

        Directly initialize vectors in ogl_spritedevicehelper.cxx
        
        since we've got all the information from the beginning.
        
        static_cast were needed to avoid this kind of error:
        /home/julien/lo/libreoffice/canvas/source/opengl/ogl_spritedevicehelper.cxx:305:36: error: non-constant-expression cannot be narrowed from type 'sal_uInt32' (aka 'unsigned int') to 'double' in initializer list [-Wc++11-narrowing]
                                           mpTextureCache->getCacheMissCount(), mpTextureCache->getCacheHitCount() }
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/canvas/source/opengl/ogl_spritedevicehelper.cxx:305:36: note: insert an explicit cast to silence this issue
                                           mpTextureCache->getCacheMissCount(), mpTextureCache->getCacheHitCount() }
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                                           static_cast<double>(               )
        Change-Id: If2705251cc4a246c2b8cb0bf873d413b3c572880
        
        Change-Id: Ie1ce45cb6518fe97442ec5f3f05d34bae586b417
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115585
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [f6b8e813e2a33221c400a050b183eb33b9237618]

        gtk4: move has-default has-focus to toplevel equivalents
        
        not sure how far that'll get us for the general case, but fine
        for simple dialogs
        
        Change-Id: Iab65af6454701a62f426bced52de1425b0abc536
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115603
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [823de05dc830a362ad29e143ec7b399198a35e7f]

        gtk4: transform dialog action-area GtkButtonBox to GtkHeaderBar
        
        Change-Id: I107afa64289442dda3e7f92fdf48237a4390109c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115602
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [b5f5b178dd542a2b4fcb20b664ee1b7bad151976]

        gtk4: fix border-width
        
        Change-Id: Id20baca2aa264024ab6d19c520685415bccf4d27
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115601
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [adfd3919837c8e213165015ef289c2b45073fac4]

        add SolarMutexGuard to asyncresponse
        
        Change-Id: I40063c65e2af9766c2373d74ae861de5ae8eccee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115600
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [c060e6752575ec6a9166c9e3e3e0b9fd919fab31]

        fix ofz build
        
        Change-Id: I6a413c8bec2ac3b22936b429072bcd1558682c6d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115607
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Stephan Bergmann  <sbergman@redhat.com>  [af16aa625682b649e8843237652b9246d519cbae]

        Improve loplugin:stringview
        
        Issue the "instead of O[U]String, pass [u16]string_view" diagnostic also for
        operator call arguments.  (The "rather than copy, pass subView()" diagnostic is
        already part of handleSubExprThatCouldBeView, so no need to repeat it explicitly
        for operator call arguments.)
        
        (And many call sites don't even require an explicit [u16]string_view, esp. with
        the recent ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator
        += overloads".  Just some test code in sal/qa/ that explicitly tests the
        O[U]String functionality had to be excluded.)
        
        Change-Id: I8d55ba5a7fa16a563f5ffe43d245125c88c793bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115589
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [f40cbba63f13e7081fc5901769651fd4d43ea34d]

        Directly initialize vector in sharedresources_test.cxx
        
        Change-Id: I5341272a33127a7cb19d477593d906ebd0c6bdec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115592
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [f2736a462ea764e6f5abc95747c52e48d507b345]

        sc_ucalc: Use a template for makefiles
        
        Change-Id: I2146ded4c8c0eb8ba7814f76f3ec5d9030a67857
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115578
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [08905cea24f8f60f7774f10a7877a6311ff0001d]

        sc_ucalc: move pivot table tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        
        Change-Id: I5fa1b9b7366c45414d26804a09d1b78aebc83e2d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115568
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [9da5f12be26d1420c65b172af728f47347a6ce2d]

        sc_ucalc: move shared formula tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        
        Change-Id: I399daeb57dd5fba7077fef6584b0a3772df84d84
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115559
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-14  Xisco Fauli  <xiscofauli@libreoffice.org>  [1f23231c56cf33deacab3083f1ed771f10f91b00]

        sc_ucalc: move sort tests to their own module
        
        in order to split sc_ucalc monster into smaller
        modules
        Change-Id: Ib041d1fbce51230dcc46320939257771eac0faea
        
        Change-Id: Iae19af01de63346b2bf951ed935fccbd6bfb9d15
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115558
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [5449a798d1e676ce8bef876270226eaea602f258]

        Avoid temporary var + directly initialize vector in VDataSeries.cxx
        
        Change-Id: Ief280ca4cb2cdadfc41f7c98bdec4044475c7daf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115588
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [43f81f1ed3e98202d440f17509b8d008fab51ce3]

        gtk4: vexpand internal dialog vbox child
        
        Change-Id: I9c08fa885ddfb22e154909a66e6a70d8293879d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115583
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [6b58816d17957536a2875cbbed0d270451ff25f7]

        Directly initialize vectors in common_functor_test.cxx
        
        since we've got all the information from the beginning.
        
        Change-Id: I37098766967968f0db722c8998158d626792545e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115586
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-14  Mike Kaganski  <mike.kaganski@collabora.com>  [9e5ed5c3ef64934c410ad561c3862dc03e757cc7]

        Typos in comments
        
        Change-Id: I6d421f007f6a4b1550e0c8c907feea2472216502
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115517
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-14  Tor Lillqvist  <tml@collabora.com>  [0a930b7516e7f018b131963e05b857e68a8c6ccc]

        Change one more <Carbon/Carbon.h> to <CoreGraphics/CoreGraphics.h>
        
        Change-Id: Ib8ed1e4270b18de4761155f9aa7d536faaf7bd38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115581
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [c76e184ca1448c15f2f5fb059a51c2b483d0e387]

        Directly initialize vectors in sfx2/ObjectInspectorTreeHandler
        
        since we've got all the information from the beginning.
        
        The static_cast is to fix this error:
        /home/julien/lo/libreoffice/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:976:39: error: type 'float' cannot be narrowed to 'int' in initializer list [-Wc++11-narrowing]
            std::vector<int> aMethodsWidths { nMethodsDigitWidth * 30, nMethodsDigitWidth * 15,
                                              ^~~~~~~~~~~~~~~~~~~~~~~
        /home/julien/lo/libreoffice/sfx2/source/devtools/ObjectInspectorTreeHandler.cxx:976:39: note: insert an explicit cast to silence this issue
            std::vector<int> aMethodsWidths { nMethodsDigitWidth * 30, nMethodsDigitWidth * 15,
                                              ^~~~~~~~~~~~~~~~~~~~~~~
                                              static_cast<int>(      )
        
        Change-Id: I7d59d947bd54bf97dd559b6813cabd3ea4216efe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115582
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-05-14  Miklos Vajna  <vmiklos@collabora.com>  [9837d3b51557955b2a2b7e66c2bdcdc706474704]

        sw XHTML export: fix <blockquote> with no-margin to not have character children
        
        This is building on top of commit
        f2eae41e9a85cd1df4190160b7453d3e12b8ccbd (sw XHTML export: <blockquote>
        can't have character children, 2019-11-07), which handled this in
        general, but only worked in case the Quotation style had a non-zero
        bottom margin.
        
        Change-Id: I4008ee964d9a87a6cf409a63affce8e44d63b602
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115580
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [6a3989b74a9fbdae5a9e60328a969a9e2cf55350]

        gtk4: add margins to ButtonBox replacement
        
        Change-Id: I635fb7251f1a2f2c7c5caadc90d029f1fd50b9ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115573
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Caolán McNamara  <caolanm@redhat.com>  [738a39c175f46d62102556423349e416f01c7993]

        gtk4: move border width down to first child as margins
        
        Change-Id: I7bd1df9abd047780e6fe52c9a2acd56f5df25e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115572
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-14  Stephan Bergmann  <sbergman@redhat.com>  [cbacdfd886e3556f7b02bc5165f76d4af97b6dfe]

        Improve loplugin:stringview diagnostic output
        
        Say what the O[U]String is constructed from (to make it easier to decide on an
        optimal rephrase of the whole surrounding expression), and find more cases that
        could use O[U]StringChar.
        
        Change-Id: I64a3851544498c26ca3f46f5df7f593d2fdcb0ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115579
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-14  Gülşah Köse  <gulsah.kose@collabora.com>  [b1099568ffe9ad199c3bf8f279bbac4d7ba445bb]

        tdf#141458 Set inital column width of Properties and Methods tabs.
        
        Change-Id: I60a51de849d332bbf4579eac3d60834f17cb4fb8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115482
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-14  Julien Nabet  <serval2412@yahoo.fr>  [10bacbcc5ed91a195c74140e05b953f62e46afe7]

        Fix assertion in vcl/texteng
        
        Insert macro from https://bugs.documentfoundation.org/show_bug.cgi?id=94024 and start
        I got this bt:
        0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
        1  0x00007f39e2b61537 in __GI_abort () at abort.c:79
        2  0x00007f39e2b6140f in __assert_fail_base
           (fmt=0x7f39e2cca128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7f39db29740e "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x7f39db27f997 "/home/julien/lo/libreoffice/include/rtl/ustring.hxx", line=794, function=<optimized out>) at assert.c:92
        3  0x00007f39e2b70662 in __GI___assert_fail
           (assertion=0x7f39db29740e "index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())", file=0x7f39db27f997 "/home/julien/lo/libreoffice/include/rtl/ustring.hxx", line=794, function=0x7f39db2bada5 "sal_Unicode rtl::OUString::operator[](sal_Int32) const") at assert.c:101
        4  0x00007f39da1fe3c4 in rtl::OUString::operator[](int) const (this=0x846da80, index=-1) at include/rtl/ustring.hxx:794
        5  0x00007f39da59acdc in TextEngine::GetWord(TextPaM const&, TextPaM*, TextPaM*) (this=0x8901e80, rCursorPos=..., pStartOfWord=0x7ffd1f0b7360, pEndOfWord=0x0) at vcl/source/edit/texteng.cxx:2375
        6  0x00007f39c4ac5c5c in basctl::EditorWindow::RequestHelp(HelpEvent const&) (this=0x8581060, rHEvt=...) at basctl/source/basicide/baside2b.cxx:370
        7  0x00007f39da3b8f91 in ImplHandleMouseHelpRequest(vcl::Window*, Point const&) (pChild=0x8581060, rMousePos=Point = {...}) at vcl/source/window/winproc.cxx:181
        
        (gdb) frame 4
        4  0x00007f39da1fe3c4 in rtl::OUString::operator[] (this=0x846da80, index=-1) at include/rtl/ustring.hxx:794
        794	        assert(index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength()));
        (gdb) p this
        $1 = (const rtl::OUString *) 0x846da80
        (gdb) p *this
        $2 = "\t\t"
        (gdb) frame 5
        5  0x00007f39da59acdc in TextEngine::GetWord (this=0x8901e80, rCursorPos=..., pStartOfWord=0x7ffd1f0b7360, pEndOfWord=0x0) at vcl/source/edit/texteng.cxx:2375
        2375	        if (aBoundary.endPos < pNode->GetText().getLength() && u_charType(pNode->GetText()[aBoundary.endPos - 1]) == U_CONNECTOR_PUNCTUATION)
        (gdb) p aBoundary.endPos
        $3 = 0
        (gdb) p pNode->GetText()
        $4 = "\t\t"
        (gdb) p pNode->GetText().getLength()
        $5 = 2
        
        Change-Id: Ic94362b26cb0ebb0975c42fe5a31724ff485aad0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115546
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-14  Miklos Vajna  <vmiklos@collabora.com>  [2a60c2b7d0f126841420aa6b23dde5b9a795d4fa]

        Replace magic numbers in SwSectionFrame::UpdateAttr_()
        
        By using the same SwSectionFrameInvFlags constants that
        SwSectionFrame::SwClientNotify() already does.
        
        Change-Id: I538737b59fe732045ea82097ac93580cf795f975
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115571
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-14  Jim Raykowski  <raykowj@gmail.com>  [6b09276d157abada74e1a4989700139167207778]

        Outline folding experimental feature rehack
        
        * Changes the way the outline content visibility button is shown to
        similiar how the table un-float button is shown.
        
        * Toggle function is replaced by an invalidate function that makes
        outline content visible or not visible only if needed.
        
        * Removes the left and right arrow keys restrictions of cursor movement
        in and out of an outline node paragraph having outline content
        visibility attribute set false (folded outline content). These were
        prevented due to causing an assert in txtfrm.cxx
        SwTextFrame::MapModelToView but seems to do no harm here if allowed.
        
        * Makes a selection read-only if it spans an outline node that has
        folded content and disallows actions that would cause loss of folded
        content.
        
        * Adds RestoreSavePos when Move fails in SwCursor::LeftRight to fix a
        bug that occurs in documents with outline content folded at the end of
        the document. When the cursor is at the end of the visible document and
        right arrow key is pressed Move fails after moving the cursor to the
        end of the document model, which doesn't have a node frame and causes
        wierd numbers to be displayed in the statusbar page number count. Left
        arrow, when in this state causes a crash without the added
        RestoreSavePos.
        
        * Addresses tdf#141390 concerning position of view when feature is
        turned off and on.
        
        Change-Id: I0430f73643201aa08ffc347c1597b44b1de290e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114255
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-05-14  Olivier Hallot  <olivier.hallot@libreoffice.org>  [6c8ca02c5935a800cff70f3c173319b454b63c41]

        Add extended tips to print dialog
        
        The extended tips were not imported for the print dialog
        in the firts round.
        
        Change-Id: Ie4e5282720d927fec51a823bb43c1617349105bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115576
        Tested-by: Jenkins
        Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [9ca8a4e229d270fe7ec16f3aa7b5cb2e1f8a522f]

        tdf#141571 Base crashed on creation of user function
        
        Revert "reportdesign/core: create instances with uno constructors"
        This reverts commit 79c1d1234bdac0d41109930529f42d39c70b0f7b.
        
        I have no idea what is causing this. Something is stomping
        on memory belonging to something else, but why?
        
        Change-Id: Ieb758e5788f07e3f477063274ccd0721e3bf7726
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115567
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [699295ca7cab3a4f4e801a14496f202c05d18899]

        tdf#142014 Fix displaying strokes when line width is 0
        
        Change-Id: I80e05ff2f24f5da2f5c124c0ee1b302a1c8226ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115570
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [5846f376b7e2fecc6b7fc5315095234b7aeed6c5]

        gtk4: add default spacing in GtkBox GtkButtonBox replacement
        
        except for message dialog which are left at whatever default they
        want
        
        Change-Id: I0e5a63a909f3e4bf1800868e8c14dcc71147f5b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115561
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [883b7a34d288410ac6f820e91d9eaa65ba2b9cb1]

        DBG_ASSERT->assert in UnoWrapper
        
        Change-Id: Ibc6b489f12c2734869bd45f93f946a53e3015226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115564
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [4e869ad7367a74489938da5c7287cbf52c0a30e4]

        can pass by const& here
        
        Change-Id: I1984e3efd8fbd8400e15e82042b9c75b748a46fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115563
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [f23bc008aefe7d5ab2da8a283fe899798d15a2fa]

        fix leak in VCLXWindowImpl
        
        where the manual acquire() was not matched by a release() if we disposed
        while an event was in progress
        
        Change-Id: I307997772ccdfc912a16f0fb233f4e933f95cfbf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115566
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [951c998ea27211f587e363d8aee70963177bdf05]

        dispose component in test
        
        probably not strictly necessary, but lets err on the side of safety
        
        Change-Id: I1b4b7381eca0af83434fdc925a0a5d09733b4ee8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115565
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [698e27d29cf0612634720c818ee773bfac6c40d1]

        tdf#132389 - Case-insensitive operation for non-ASCII characters
        
        The replace function should depend on the application locale, instead of the UI language.
        
        Change-Id: I1582db07a1560da9ea87c0b127cf92611c8544bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115540
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-13  dante  <dante19031999@gmail.com>  [c9de441f84ad4641662f2ce510868f3e3164a22f]

        Use double to iterate products in scmatrix.
        
        Change-Id: If094c33d396dc5aba31b37a3042add72076f344f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115468
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-13  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [7a578c06352328799c644e0399f14d58b05246f9]

        tdf#139840 - Case-insensitive operation for non-ASCII characters
        
        Support case-insensitive operation for non-ASCII characters in the
        InStr function in Basic.
        
        Change-Id: Idb2b8e128adf3596fa49e3e86365d5724ea3e11c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115538
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-13  Maxim Monastirsky  <momonasmon@gmail.com>  [a796aa9d65e3d4292232820d424b3f62c673fa07]

        tdf#112559 sc: Expose font height via the Defaults UNO API
        
        This fixes both ODF import and export of the default cell style.
        
        Change-Id: I776591c6ed932a136b95107d3c4a0f25c1bebdf1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110539
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [a5bdce555ad7e5bd480c7bd63159869b7a9bc3d3]

        comment on suspicious code
        
        Change-Id: I92b16c22815a755ec23503db1b8f7bb3444f89e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115560
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [601e9d4badd84c3c4824090f1bc39bef3b64cbd1]

        inline some typedefs
        
        Change-Id: I1608e03ff9f6fbc55987010e88897e034b690b3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115552
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [17d4221c047eac47e26465ddc72d13fb89284f57]

        tdf#142214: unittest:test autocomplete through numeric block
        
        Change-Id: I4a44fb85dfdfdd9aa5f18801e4e2b215ee188e45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115346
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115551
        Tested-by: Jenkins

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [ebff4e5181b102e5184277f57fda32fcce60431f]

        tdf#142214: autoinput: remove search/entry count limits
        
        Change-Id: Ib41f7c04b9a3802982105cbbfef3ae638bdb286f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115345
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115545
        Tested-by: Jenkins

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [06c360d4d27ab0dadfdcd5f9d4f0c87288d3cb75]

        tdf#142214: unit-tests for new behaviour of auto-complete
        
        Change-Id: I1255c50c33f4001a7d9932e0178b6539653eb61d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115133
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115467
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [ca2ec443893731093970914feb750b31ea13e47f]

        tdf#142214: autocomplete: do not search across empty blocks
        
        Change-Id: Ia5b0be1eed2bf645fa1e53d71abc7b2e67dfaa0a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115458
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [f8039c6d645acb015a6c4e45000bbfd1311bfea3]

        tdf#142214: show autocompletion only if there is...
        
        ...exactly one match
        
        Picking one from many matches by any logic requires the user to pay
        attention to the auto completed match and see if it the one they wanted.
        Instead show autocomplete only when there is exactly one match with what
        the user has already typed.
        
        Change-Id: If8f7e59fe905d3d472a5a5795f96374ec2d1a6e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115457
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-05-13  Dennis Francis  <dennis.francis@collabora.com>  [e2f771ffe8e82ba5a5001a71601abf3c45c56192]

        lok: Enable the "AutoInput" again.
        
        This partly reverts commit 65990058f041c3f1d280a69d411eb4ceacf5a721.
        
        Change-Id: I494e3ffa3c9824fd6668b1c7322b9cf08accac21
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115456
        Tested-by: Jenkins
        Reviewed-by: Dennis Francis <dennis.francis@collabora.com>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [6ba2260591633749144e4bf451046fe0c4352b55]

        make some classes private
        
        Change-Id: I14b2c27a99e76b1141c7a7bd3d0edaf57737bee2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115544
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [fb7cb76df84c7f5c5adbef20a4ddf9b5ed4af24d]

        gtk4: get word count dialog visible
        
        Change-Id: I96d061198c54f623c366916f78655b716e1a2698
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115550
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [8ccabd1c4e7263b3eb28eebed3d4fcc184b477e0]

        gtk4: add a mechanism to support reusing the same .uis for gtk3 and gtk4
        
        well, a base so experiment on anyway
        
        gtk4-builder-tool simplify --3to4 isn't sufficient to do what we need
        
        Change-Id: Ic5f5be90f9b9775eadecc7eaa6881c75cc2041ef
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115549
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [4f757de6fe5e070cadf5516ef349af8080235a40]

        gtk4: skip gtk_widget_get_root if pWidget is null
        
        Change-Id: I3ac47e67b1b16728a448ff8341f31c107d38556f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115548
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Noel Grandin  <noel.grandin@collabora.co.uk>  [32b09faca508ae4aac7e100c98a2fe56d3302eef]

        Revert "simplify the vcl<->toolkit connection"
        
        because it introduces a link-time dependency of vcl on toolkit,
        and toolkit already depends on vcl
        
        This reverts commit f7a86c5cdf4323c99d26512bf78de7f7c380667d.
        
        Change-Id: Ibdd4f3e8221d70e2abd8fcbda67f85af3ac0396e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115547
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-13  Miklos Vajna  <vmiklos@collabora.com>  [013a4f1f5c9ea5fb511568c53a7e76d1b365a65d]

        sw XHTML export: fix handling of list labels
        
        This is building on top of commit
        119b6876c92e4cdae44583c4b1b1419d3533e3ee (sw XHTML export: properly
        write <li>...</li> around multiple paragraphs, 2020-05-21), but the
        use-case here is a numbering with list labels only.
        
        The first problem was that the list label had its <li> suppressed, but
        not its </li>.
        
        The other problem is that <ul> can only have <li> child elements, so at
        least fix the case where the list only has list labels, in which case
        even <ul> and </ul> should be omitted.
        
        Change-Id: Id38978a40d8618f483e3e9d499f75838d5b2adb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115543
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-13  Caolán McNamara  <caolanm@redhat.com>  [54387d1d35cb79a30be208052831de74efd8b2f2]

        error: use of undeclared identifier '_exit'
        
        Change-Id: I6802c8afe4b02ec8398fa9d62728694ddc6f770f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115539
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-13  Xisco Fauli  <xiscofauli@libreoffice.org>  [bb4341d76974887d473fcee1e1b1d5a9ea8f5c26]

        sw_uiwriter: Use a template in makefiles to reduce duplicated code
        
        Change-Id: I2aa29480766f943ad24d97635c50eb8b49ca8795
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115536
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-13  Miklos Vajna  <vmiklos@collabora.com>  [f970338902f6ebeebdf125833fad814dca7f8a24]

        Introduce SwSectionFrameInvFlags to replace magic numbers in ...
        
        ... SwSectionFrame::SwClientNotify()
        
        SwSectionFrame::UpdateAttr_() is not yet updated to produce these.
        
        Change-Id: I2eba563916420fa78d77b9656898ce333abce6e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115507
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [dbd4110cc36011042c98549d997daa79e8065aba]

        fix leak in canvas test
        
        Change-Id: I01d52e67711b0201bbabb8c36e990f494466ae55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115499
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [16a17fc0951e77af357591deae71f8da50c03cae]

        suppress more basic leaks
        
        Change-Id: I283457e47b919411455afac209e78e508139f9af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115498
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [512649f2fbaaa72d42d9a94ac5c414d2c37b36ec]

        unused include line
        
        Change-Id: I6a41cfa184a653f1b84cf6f33c391ccd531ffc2c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115494
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [2b4b532179725e69c8df7deceae9158b9beed560]

        rename ui-converter-skeleton to ui-rules-enforcer
        
        Change-Id: I1cc0fd704be075a7c387363a49bd84b159831aca
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115493
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [f99404da8b38955b4c1b99f76cfaefd0c19d5348]

        add truncate-multiline for uniformity
        
        Change-Id: I731b2427b49586ba06e83ce36a13e3508caa3119
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115492
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [b5ece3fbc7f878846298fd9196e5a30ba50e0dc2]

        tdf#112603 tdf#142014 tdf#142139 WMF/EMF Fix line width
        
        Previosly line width was always 1, and changing width do not affect
        line.
        
        Change-Id: I462096b915e053fa089e85860f124466b650558a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115497
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-12  Xisco Fauli  <xiscofauli@libreoffice.org>  [145b2d8ee131dca592a41f7b26341a542a23845b]

        sc_ucalc: restore formula options after using them
        
        Otherwise, it might affect other unittests
        
        Change-Id: I0750979742e6193f627a1eaf9b1e35f97976278b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115490
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f7a86c5cdf4323c99d26512bf78de7f7c380667d]

        simplify the vcl<->toolkit connection
        
        No need to store two different pointers and hide the
        underlying class behind an UNO interface
        
        Change-Id: I72c55e912caa9eae1cffa6c9d1b1d480e5668d40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115496
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-12  Michael Stahl  <michael.stahl@allotropia.de>  [c5e5467f6a13aba68b4706a4d7feb130e824bcc6]

        tdf#137810 sw: fix SwXNumberingRules setting CharStyleName
        
        During ODF import, due to removal of the pDocShell parameter, this hits
        
                    else
                        rCharStyleName = sCharFormatName;
        
        while setting the "CharStyleName" property and later
        GetNumberingRuleByIndex() prefers m_sNewCharStyleNames over the
        format set in the SwCharFormat??
        
        Also, "BulletFontName" has a similar problem; otoh "HeadingStyleName"
        only makes sense on chapter numbering.
        
        The m_pDoc and m_pDocShell members are such a WTF.
        
        (regression from ae0e4a6ba9be2fa99ac2be8e20157806e36209b2)
        
        Change-Id: I9d4d4cd7aeb7e6e29221d53facaff213fd4e35a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115495
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [f02a56b0f2a66b583e52dd91b548c666b3d4693c]

        fix ubsan use-after-free
        
        after
            commit 2ed8c34bca56c1a30d727b21d9096cb77e88197a
            Date:   Wed May 5 10:54:44 2021 +0200
            use a single global item pool for chart2 draw model
        
        Change-Id: I5f6b1b1917f60c9a8603b58368da8b34f174f7db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115478
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [aaeb94cb055d5daad9bd98c5ec435d1234c75eb7]

        gtk4: add a typedef for different gtk_widget_translate_coordinates arg type
        
        Change-Id: I07c514309d1c687361609818d1d16e808e8b4a56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115487
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Bjoern Michaelsen  <bjoern.michaelsen@libreoffice.org>  [b0ae5aaaafd236663f7e81af06a567ade8a2a745]

        tdf#141307: adapt null-check
        
        - if we check pNd for nullptr, we need to expect it to be nullptr
        - in that case we shouldnt use the pointer before the null check
        
        Change-Id: Ia9d11abe32fac10f36fdbfcefeadd51891f1834e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115264
        Tested-by: Jenkins
        Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [b5c21b95e4b9801902ef9ed3464d09d70d7d1dcf]

        gtk4: add widget_get_first_child to wrap gtk_widget_get_first_child
        
        and equivalent gtk3 calls
        
        Change-Id: Iab6801466d6677ae5a7419470ce3bb32e16e68ac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115486
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [59ab855cdac009ea3b52fbdbabf110658e89c16d]

        gtk4: wrap gtk_image_get_icon_name for different version args
        
        Change-Id: I38f2c11309965b08a5c85f543127f3c8b6720e08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115484
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [b2fefcad3236970284e559ba8cd018511a8cacce]

        gtk4: enable CreateBuilder but forward to generic one still
        
        Change-Id: Ifba5d0de1606ed238a3e71c4149baf1c97848b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115483
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [346abdee0c61612c2a7639a7fea28313f8a7742b]

        gtk[3|4]: drop m_xFrameWeld before gtk_window_destroy invalidates m_pWindow
        
        for gtk4
        
        Change-Id: If9446411bd5dde1ad1b0d5d02bd0354b63f5c3c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115481
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [47cb7376447b35ae6e235a147dfe558390484efb]

        gtk4: renable providing parent to native dialogs
        
        Change-Id: Ic21d57d8c58db855d80cb905e45a3cd37985ca0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115480
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [dad39d0022ed267ede3e8e589854f7eb73e602f3]

        fix some VirtualDevice leaks
        
        Change-Id: I645543fa27ca8b75b36ed7798f0af7b81fd09f49
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115477
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-12  Marco Pinto  <marcoagpinto@sapo.pt>  [6a6225cea84b43ac0231333afbde89b399984322]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 4fa94195b8136364dd40bf2b0366a0fe32058899
          - Updated the English dictionaries: GB+US+CA+AU+ZA
            
            Change-Id: I0bc59f1c11ef10ff597ab2d7c18fcdbc648a472a
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/114824
            Tested-by: Aron Budea <aron.budea@collabora.com>
            Reviewed-by: Aron Budea <aron.budea@collabora.com>
            
2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [77cbb5b05c973323802a23c153100ef6cdb8868c]

        gtk4: reenable gtk message dialogs
        
        Change-Id: I115901d5e86be7aee261df4d548b8b660e904f9c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115476
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Eike Rathke  <erack@redhat.com>  [c2a3a1f1ad3b48b294203da6b4aff125d2cee229]

        Update to ICU 69.1
        
        Change-Id: I32836175a877349777dcbb6eb7b0d813aa31199a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115479
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-12  Miklos Vajna  <vmiklos@collabora.com>  [6b1d5bafdc722d07d3dc4980764275a6caa707ba]

        vcl PDF tokenizer: fix EOF position when \r is not followed by \n
        
        Otherwise this would break partial tokenize when we only read a trailer
        in the middle of the file: m_aEOFs.back() is one byte larger than
        rStream.Tell(), so we reader past the end of the trailer, resulting in a
        tokenize failure.
        
        What's special about the bugdoc:
        
        - it has 2 xrefs, the first is incomplete, and refers to a second which
        is later in the file
        - the object length is as indirect object, triggering an xref lookup
        - the first EOF is followed by a \r, but then not with a \n
        
        This results in reading past the end of the first trailer and then
        triggering a lookup failure.
        
        FWIW, pdfium does the same in
        <https://pdfium.googlesource.com/pdfium/+/59d107323f6727bbd5f8a4d0843081790638a1dd/core/fpdfapi/parser/cpdf_syntax_parser.cpp#446>,
        we're on in sync with it.
        
        Change-Id: Ia556a25e333b5e4f1418d92a98d74358862120e2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115466
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-12  Stephan Bergmann  <sbergman@redhat.com>  [21f92ce72ada2ea92ef4997a7a0fae986f023b6c]

        Guard against isCXX11ConstantExpr on dependent expression
        
        > Assertion failed: (!isValueDependent() && "Expression evaluator can't be called on a dependent expression."), function isCXX11ConstantExpr, file ~/llvm/llvm-project/clang/lib/AST/ExprConstant.cpp, line 15540.
        
        ...as would have hit with a preliminary version of
        ad48b2b02f83eed41fb1eb8d16de7e804156fcf1 "Optimized OString operator +=
        overloads"
        
        Change-Id: I652063b4eebd076973eaa57219df91cd1fbef312
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115462
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-12  Gülşah Köse  <gulsah.kose@collabora.com>  [b2f8032c43e298525ab7897f13baad9017a969ff]

        Fix broken TOX in Online.
        
        1. Open a German file in the Online
        2. Insert a new paragraph, and change its style to "Ueberschrift 1"
        3. Go to the Table of Content, and choose "Update Index"
        4. See the index got destroyed, and when you look at the list of
           styles, the "Ueberschrift 1" has disappeared, and "Heading 1"
           appeared instead.
        
        This reverts part of:
        commit ca435be45f316120b9df6c9d547b781ed975817d
        writer: handle styles in multiple languages for online
        
        Change-Id: I82e46b3cf7824df6efdbb4b2a16716153ddae0df
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114683
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115273
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-12  Noel Grandin  <noel.grandin@collabora.co.uk>  [5aa60be574ece81b27c8f63e6e809871c694dba0]

        fix leak in VCLXWindow
        
        which is a little tricky because dispose() can be called from either
        side (vcl::Window or VCLXWindow)
        
        Change-Id: Ifc380feec6bec84b2cf7d903d42db00755d4cd97
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115441
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-12  Gülşah Köse  <gulsah.kose@collabora.com>  [db35b9086476259fa2c047f2e4dfe7862d026530]

        tdf#141426 Remove GtkPaned struct unnecessary tabs.
        
        In development tool we need GtkPaned for only properties tab.
        Unnecessary hide() show() calls for the other tabs(Interfaces, Services,
        Methods) causes complex problems about inital height of the second pane
        with gen plugin.
        
        Change-Id: I7523ef0bc425d7fc97ec5bd9e30e874f88e354f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115450
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-12  Gülşah Köse  <gulsah.kose@collabora.com>  [95a1ccff3a252315e1c2499331ded4bc2e660d54]

        tdf#141426 Fix VclBox inital size allocation.
        
        Change-Id: If7380c9dbbcda091a2de93b722bf90182677af6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115295
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [addb261c7a93f16b3be84d1e67994cecdb53de77]

        gtk4: wrap gtk_widget_get_root vs gtk_widget_get_toplevel
        
        Change-Id: I416b157defd927e7c2fa828c5d3b3ba2a5e20c5a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115448
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [4aa86bcde7faa27155e34caf9ac30367e9efa786]

        gtk4: wrap gtk_css_provider_load_from_data for arg difference in gtk versions
        
        Change-Id: Iabbf7f6a746efae2ec4abecfb27b4b097ce822ed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115447
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [0cf318d119682eebb655c0cbab648628dcefc1d1]

        gtk4: unset gtk_popover_set_has_arrow for popover menus
        
        which is what I see in e.g. the gtk file dialog so lets follow
        that pattern.
        
        Change-Id: I505318c0e1e12ea8c75d2960184092927fd2f744
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115446
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Caolán McNamara  <caolanm@redhat.com>  [0f76fccf16ed865c5af97082c1bc9c36eba986ad]

        gtk4: improve gtk_dialog_run replcement to not crash on ESC
        
        e.g. open/save file dialog
        
        Change-Id: I71813125589866affc2313c72e44159c15501ec4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115445
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-12  Stephan Bergmann  <sbergman@redhat.com>  [ad48b2b02f83eed41fb1eb8d16de7e804156fcf1]

        Optimized OString operator += overloads
        
        ...similar to how OUString got an operator += overload for std::u16string_view
        with c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make the OUString ctors taking
        raw sal_Unicode pointer/non-const array explicit".  In this case, though, we can
        easily add enough overloads (which forward to the one taking std::string_view)
        to avoid any ambiguities at call sites.
        
        We had left this out in the past as there is no suitable rtl_string_newConcat*
        function to use in the implementation, but we already had inline implementations
        of OStringConcat/OStringNumber overloads, so stick to that pattern here with the
        new std::string_view overload.
        
        Change-Id: I329036ea2b62cb921b4dbc1eef7c45a9cdb56e13
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115452
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-12  Miklos Vajna  <vmiklos@collabora.com>  [de16265f55ff2e4e1beb574fcb5b7b894df234f9]

        external: update pdfium to 4500
        
        Change-Id: I38c85fb3e30ffd1f7fc0a11948fc01338f7bb205
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115444
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-12  László Németh  <nemeth@numbertext.org>  [1610eeef6f2312616fe5d3535475f27f7896bef8]

        tdf#142196 sw: crossing out images anchored to character
        
        Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d
        (tdf#78864 sw track changes: cross out deleted images).
        
        Change-Id: I3daa772ac80f777e1badc58a424f98b1d655acba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115442
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [5d7251c7121cee8885fa9f2387c4a0625dd4ecee]

        sc_ucalc: remove duplicated method
        
        Change-Id: I720c40bfc218b3f442217d3bb7189fce1baaf4a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115449
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [2009af1c0fb4fead653dd7688347c15d74eaa1b0]

        Revert "tdf#141015: Show Mail Merge toolbar when DBData has data source"
        
        This reverts commit 346153f08c907739ca310934ad45814379971027.
        It seems to create more problems than expected, and there's no
        way to remove DB association other than editing document XML.
        
        Change-Id: I93171f17c01e231abbcfa9a816fdadce83c983ec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115283
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [af691db0dadaed984cae206f895075b0313758c0]

        fix leak in SwUndoInsSection
        
        Change-Id: I68e0c0570ac7b6f5ebce06900947fa296cbedd03
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115403
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [05f8f239d49bd66145e736b4e2e28ad073ef6f2f]

        tdf#139241: partially revert 059f07f9f33460c809a93e0fda1165f5c6f6d805
        
        And instead normalize the start and end values before creating
        rectangle.
        
        Change-Id: Ib9921f1a537ca88a70cedf989d2f696180ad68e7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115284
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-11  Adolfo Jayme Barrientos  <fitojb@ubuntu.com>  [b74fe262d889705ea6c27267bd7e6d57279367b9]

        There’s no need to SHOUT to the user
        
        Nowhere else in LibreOffice’s UI are keyboard shortcuts
        indicated in all-caps. Don’t do it; we’re not in the ’90s.
        
        Change-Id: Ieb8aa32797d422c2ac067fab5d061de6d2176908

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [dd29ce678ad76019886cb24c1492c57388733aee]

        ofz#32899 missing scripting_BrowseNodeFactoryImpl_get_implementation
        
        Change-Id: Ifd7d40f67234bc852776cde8d7855f86f73a8fb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115440
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [43335776cfc18cdc7addf33250cffc886d384186]

        gtk[3|4] don't create File Dialog with buttons that need to be removed
        
        just create it without the offending buttons in the first place
        
        Change-Id: I0708e69a82e8fbabf149b64186a9d20cfd011cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115439
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [f11ed681df15728abe6a0b6b7b1612f190aa1707]

        tdf#141982 tdf#142139 Add rotation and line width support to ROUNDRECT
        
        With this commit the ROUNDRECT is able to change line width and
        transformation (including rotation) is supported.
        
        Change-Id: Ic303a74adf0fd0dd452353f250a13140603d492e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115429
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [a9a9d66ec8fb07df7d5b08d94b6e0878006b6004]

        gtk4: replace gtk_dialog_run
        
        with effectively the same thing, so still a loop within a loop.
        
        File Dialog now appears and is semi-functional
        
        Change-Id: Ibd7584c5e41b5de84975c3cb7886fe97a74d8587
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115438
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [87d795a7a25934b11095f401c3bda73056f4f3d6]

        gtk4: incomplete GetDisplayBuiltInScreen implementation
        
        only x11 possible as far as I can see, maybe we can assume index 0 is
        built-in otherwise. We like to default to put the presentation console
        on the built-in laptop monitor and the presentation on the external
        projector.
        
        Change-Id: I5d17403032b04750a5fb4d52904db0a81a6234c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115436
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [a7a1b836e55cda808472ade322b93a56ab82c40b]

        gtk4: reduce ifdefs
        
        Change-Id: Ibfbc5a37666c233590cf2d4169730a89d37ff7f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115435
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [8f03cf64ecbf026111cc4c506b1bb021a11187b7]

        gtk4: have just one way to determine if its an X11 Display
        
        Change-Id: I59e2cd44252616e93c8781ffa9a916f846b24b80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115434
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [2f26a3323dc0cf2975351774f2f1ffc60930fda6]

        gtk4: drop unneeded ifdef
        
        Change-Id: I85180b68ee2db3469ea93f14c73e9b325e3d948d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115433
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [3f4400f1ac9185b7b123585deafef04a3d91bc66]

        gtk4: flatten this method
        
        Change-Id: I4dfceaf70a2be541b7ed750e47e3565e3341b32e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115432
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [8fb62def894ce6ea37ade9fc20e3cdad5562d0aa]

        gtk4: drop unneeded ifdef
        
        Change-Id: I6bc4c95b1eebaec6362ce852a76ae8d947b81199
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115431
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [07d235414f95a74561204a3643975590cde89299]

        gtk4: tidy up messy xid/native handle behind GtkSalFrame::GetNativeWindowHandle
        
        Change-Id: Icefbfe3922b46de8da54a8117709e3a01b4b21db
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115430
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [3cc2ea2da2dad635e7e0d4375668c55b16bada55]

        gtk4: rename ensure_dbus_setup to attach_menu_model
        
        Change-Id: I26b657aaad0dfbdbe6917815a8a4c5ca2d3bf4f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115426
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [72f52efe861ff2a85d26a7cf6d8301af1c5ec2a2]

        gtk4: trim ensure_dbus_setup down to the minimum needed
        
        Change-Id: Ic74ae09ca36ec110c67718fdb3de0513ef36d387
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115425
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [da6c8343993c4d5c0e7b60eebe27a611def7f250]

        don't leak when the SfxHintPoster is disabled
        
        Change-Id: Ia445feb93b7e65e1b64c69efded9a3e779cb578e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115405
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Regina Henschel  <rb.henschel@t-online.de>  [36499d8bf6cd5c6af7b2ceb6071baf5c7421bd0a]

        tdf#141463 avoid skew in shape group in ooxml import ..
        
        and implement special resize handling for rotation angles larger 45deg.
        This solves tdf#93952 and tdf#141953 too.
        
        Change-Id: I798f6d2cea29c4a5285f530e9cf7bb10e7f6c41d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115296
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [919260f73be652195d228d78ed519d46e59e6f8b]

        gtk4: drop no-op filterGdkEvent
        
        Change-Id: Ia94f7f70be9b2ac21608d97095a76624cad78aac
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115407
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [1821241f7c7c90784662be54dc3b42e4f9ca3ca3]

        gtk4: listen to monitors changing the new way
        
        Change-Id: Iab483c86a0d9810e801a19a9daf3cb9cc1632608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115406
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [27f2084cbe0f505e59420e90235bfd7a668ae96e]

        gtk4: style provider is at GdkDisplay rather than GdkScreen now
        
        Change-Id: I9ae0d2e306c7470237ab16436dd80518c911deb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115401
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Mike Kaganski  <mike.kaganski@collabora.com>  [b4c6fe22e2f91f33ce3705f01ef35b46e980b926]

        Missing include
        
        Change-Id: Icd36de153a89893d09d74df6c33aa5a2b98f0d7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115280
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-11  Heiko Tietze  <tietze.heiko@gmail.com>  [8fa4371664108560dda438be8fc997d9cfe4bb6e]

        Resolves tdf#127406 - Font name and style name not readable
        
        Font name dropdown made 5 chars larger, style name +3
        
        Change-Id: Ia37af6742cf7b754b25b9af18d7b29858634e5a8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115234
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [83d91ebbbda2204af9a09a921055a850a16911e0]

        tdf#91874 Command Popup - HUD to search and run LO commands
        
        This adds Command Popup functionality, which is a HUD like pop-up
        window, which can be used to search and run commands presented in
        the main menu (but not limited to that only).
        This is the initial version, which has limitation in searching
        and running the command (doesn't work for some currently).
        
        Change-Id: I92cdd3130b8de42ee0863c9e7154e7c7246d9377
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115380
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Robert Campbell  <robert.rcampbell@gmail.com>  [0409c4f5de99a125865af0323036516eb62c5a73]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to 4d00eb0e60d4d1e89c1f50cd97b44e44abe26517
          - Update lo_LA.dic with new data
            
            Change-Id: Id3975f55c62b256b85ecee78a679a51c22f6e5c9
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/114928
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a9435ac284f9f0a4d374ab891833fbf737d2898b]

        fix leak in SvxHpLinkDlg
        
        Change-Id: Idefd194a81585efc09d38593a6e40f77733d06ff
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115382
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [a5c37adc47d91176bdd64250a1f44f26b36215ac]

        loplugin:implicitboolconversion workaround
        
        after
            commit eb6819e74a66750235d3a4a894479faeee8146e2
            Date:   Sat May 1 22:13:37 2021 +0900
            change usage of boost::hash_combine to o3tl::hash_combine
        
        Change-Id: Idc70726f7e762b49111e6505ba3f978370d7cf7c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115399
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Tested-by: Jenkins

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [948066dba3556598337b3b5db75f77439627f94f]

        gtk4: enable svg pointer cursors
        
        Change-Id: I15086c16733b862dfea7dc9be621a527000b97cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115398
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [31d3f7c7e571acbce0b4da98e6a240ecdc8ea014]

        do not leak on error path
        
        Change-Id: Iba675c7465b1850e154152d86141947c4779952b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115394
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [a161d8c2c7322cda720ec487cd31baae23f16546]

        gtk4: add basic scrolling support
        
        Change-Id: Ibe492ad1589d6ffeb8e8f18958e2b9cb2f0f9761
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115397
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [d19397ea3fe742d81251382c61608ea93a42ce74]

        gtk4: add basic Input Engine support
        
        old hack to emulate single key press events not supported (yet?)
        
        Change-Id: I0de44fab76d0fa82f7586a6712b1f4a469550c45
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115395
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [0064b47ee1ea9e8c7a63497889d2aa7e0126b95d]

        gtk4: add initial keyboard event support
        
        basic typing works now
        
        Change-Id: Iee248855c44151a9418818081910f748ff911755
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115391
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [9267e9fbd2ad1a05986f7ce16d4fef28cf7f08fb]

        fix leak in RtfExport
        
        Change-Id: I6e1059cef9032de36cf8e1ac56eefecc4e417337
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115384
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [38f3bd349586ecae867c74b746fd3db7c6104d70]

        tdf#127363: svl_qa_cppunit: Add unittest
        
        Change-Id: I23f792b33ac7147007980e9af38afeb61fd28165
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115388
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [518d0d8283b6d732cffa102c6b7c2fe01d1ec348]

        tdf#76258 Skip color items in filter dialog for now
        
        Change-Id: Iada39f065dbb9b975ada90bcc4135c39b9710def
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115393
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [0111565f560a4978ee664403ba86af1e72a2ba05]

        loplugin:noexceptmove
        
        after
            commit adfd91d24678053b9a1475ad6985eb1fc548706a
            Date:   Mon May 10 20:17:11 2021 +0200
            fix leak in SalLayoutGlyphs
        
        Change-Id: I495106d9930ce6f2dad8e62fd89bc2970f747088
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115392
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [5ed6aae8b572fd2b7623454acbb1de791f166c45]

        fix leak in LOKPostAsyncEvent
        
        Change-Id: I0bae5c59d75b315c1c086640a8a9bb638a82923d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115381
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [eb6819e74a66750235d3a4a894479faeee8146e2]

        change usage of boost::hash_combine to o3tl::hash_combine
        
        Change-Id: I840518a36ac43d36c95f38e09c7bfcfe1a25a525
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114984
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e6c0c282be59a5198932604d6c40de837b7cb548]

        add o3tl version of hash_combine to not depend on boost for this
        
        Change-Id: I081f8d116ef811baa8aa5de35a6cb51fa4de7d56
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114983
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [57ed14b5c52c6a3504a7af8359dec436fcdf54f2]

        fix leak in ZCodec
        
        Change-Id: Ifec23a2e83a4327d954a9978ee3885a1f0889d6a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115377
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [1965bd9645777d94d93d4caae799577af71039f8]

        gtk4: gtk_widget_set_focusable needed for GtkEventControllerFocus
        
        worth mentioning in the docs
        
        Change-Id: I635bff1e7cf416796f78173ce719ce01f6cf1e5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115386
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [71dd1d72358a862b4cf36d5014624ab9d8c8a402]

        gtk4: current-folder-changed removed without replacement
        
        since...
        
        commit e31bacf7be3dcc5295c89f8e929b53636976ebaa
        Date:   Thu Jul 9 01:48:33 2020 -0400
        
            filechooser: Drop the ::current-folder-changed signal
        
            This signal does not work on native file choosers,
            and it exposes internals of the widget that should
            not be public. And it is just not very interesting.
        
        Change-Id: I170f91b6dc87965248e206c2b1a2863448e5c976
        
        and selection-changed removed without replacement
        
        since...
        
        commit 2746a2d929615231af10f221fc2ab416537285f3
        Date:   Thu Jul 9 02:06:31 2020 -0400
        
            filechooser: Drop the ::selection-changed signal
        
            This signal does not work on native file choosers,
            and it exposes internals of the widget that should
            not be public. And it is just not very interesting.
        
        which doesn't bode too well.
        
        Change-Id: Ib8657afbbc23bf921c0bfad037d7cdb0bc490790
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115385
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [a76834dc31247a26c409a7bcc7586de32782f9bb]

        gtk4: GtkCheckButton no longer inherits from GtkToggleButton
        
        Change-Id: I7bbf97b6a4a076d2cbc77e03bd21ecdf9b194c82
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115383
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Noel Grandin  <noel@peralex.com>  [de5af8315e014ce3408f66c6de3c9c4e841f8437]

        improve perf of xmlreader::Pad
        
        Change-Id: I83cc88977e7c287b0f428a3e01f289179b6dbad9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115353
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [8f3b80f5c58e1f22db68be0f109eb06d2b054688]

        vcl: Popover - signal "closed" when calling popdown()
        
        Change-Id: Iabb5c7441560f1f9fa5a25cd87075f1b15e1fd51
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115379
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [351875e5662ee2c2bd45750cb2dd8fbac65bf728]

        gtk4: menu item text seems to be parsed as xml now, so escape the basics
        
        "Zoom & Pan" in impress causing trouble
        
        Change-Id: If738eebaa3d9fd9abdd09a4fba4abce600c28743
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115363
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [48b2d74b1d68523253368bd0ba23dec26ad6ad8c]

        gtk4: have to explicitly ask to listen to all buttons
        
        right click works now
        
        Change-Id: I35326a7adab6287644ab9059fdf6ecbb66959346
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115364
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [c600f7566319974323d718773a01082da078ad91]

        suppress some leaks I don't want to deal with
        
        Change-Id: I66d39f3c4500ca75da62f023c80c8fe2851636a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115376
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Noel Grandin  <noel.grandin@collabora.co.uk>  [adfd91d24678053b9a1475ad6985eb1fc548706a]

        fix leak in SalLayoutGlyphs
        
        we forgot to delete the extra impls vector
        
        Also make more use of std::unique_ptr
        
        Change-Id: I2c745c0ad2b7ad62d368e9702bd2c32c734442fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115375
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5b01ad53aba40956a164500c4267990f7d2d8dd7]

        tdf#76258 Use correct icon size for color filter popup colors
        
        Change-Id: Icda5ee2cc4c02d6da5cc3f45c30416ad503eaa20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115378
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-11  Michael Weghorn  <m.weghorn@posteo.de>  [55c17dff49166e8ad036f02fc97db40137158d43]

        android: Don't crash trying to process non-existing file from recents
        
        When the "Recent files" list in Android Viewer contained an entry
        for an Uri that was no longer pointing to a valid file, a
        SecurityException was thrown trying to query the display name
        from it.
        
        Catch the SecurityException that is thrown and just return an
        empty string, the document is then not displayed in the
        "Recent files" list.
        
        One scenario:
        
        1) open file located in the "Download" directory from within the app
        2) close the app
        3) delete the file
        4) open the app again
        
        -> crash, with this backtrace in ADB log:
        
            05-11 08:37:14.230  3892  4707 E DatabaseUtils: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:804)
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:670)
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.content.ContentProvider$Transport.query(ContentProvider.java:238)
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:106)
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.os.Binder.execTransactInternal(Binder.java:1138)
            05-11 08:37:14.230  3892  4707 E DatabaseUtils:         at android.os.Binder.execTransact(Binder.java:1102)
            05-11 08:37:14.230  6981  6981 D AndroidRuntime: Shutting down VM
            05-11 08:37:14.231  6981  6981 E AndroidRuntime: FATAL EXCEPTION: main
            05-11 08:37:14.231  6981  6981 E AndroidRuntime: Process: org.libreoffice, PID: 6981
            05-11 08:37:14.231  6981  6981 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.libreoffice/org.libreoffice.ui.LibreOfficeUIActivity}: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3333)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3477)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2043)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:106)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:216)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7464)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:955)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime: Caused by: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.os.Parcel.createExceptionOrNull(Parcel.java:2285)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.os.Parcel.createException(Parcel.java:2269)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.os.Parcel.readException(Parcel.java:2252)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:188)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:140)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.content.ContentProviderProxy.query(ContentProviderNative.java:472)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.content.ContentResolver.query(ContentResolver.java:1112)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at org.libreoffice.ui.FileUtilities.retrieveDisplayNameForDocumentUri(FileUtilities.java:137)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:206)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.Activity.performCreate(Activity.java:7990)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.Activity.performCreate(Activity.java:7979)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3308)
            05-11 08:37:14.231  6981  6981 E AndroidRuntime:        ... 11 more
            05-11 08:37:14.233  2293  3174 W ActivityTaskManager:   Force finishing activity org.libreoffice/.ui.LibreOfficeUIActivity
        
        Change-Id: I7a8e824e557dba8771cf1f210ae89d6f60498737
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115374
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [3478c3ca5c2383c5340d1deaa22099d93bb2972f]

        gtk4: use GTK_POPOVER_MENU_NESTED to avoid crash on submenus
        
        gtk_popover_menu_new crashes on submenus with:
        "signal 'action-added' is invalid for instance  of type 'GtkActionMuxer'"
        
        Change-Id: I5d66b727dc45ac539b11e08665d69e019f5dded6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115362
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [65543a53c4058a6e491bc3ef8ca71970a1bc50b7]

        gtk4: centralize g_main_loop_run ifdefry
        
        Change-Id: I1a984783cf4c39500ab6dfdb59e5d1c604de4b5b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115361
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [e104d1ee6918d9143d5d91ac46bbe3da6c6df1c5]

        gtk4: avoid gtk_widget_show_all
        
        Change-Id: Ib7151175e8f80def3d869330e1e6560e28e4c818
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115360
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Caolán McNamara  <caolanm@redhat.com>  [18b27b017ea8221b33f7e169f7725d3b9fc13c53]

        gtk4: get context menus working
        
        Change-Id: I14fe637ce3539196cffba90851f57193afc9b76b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115359
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-11  Miklos Vajna  <vmiklos@collabora.com>  [89b1c955c182a14de6a044b4db90b085d5bcddf9]

        Related: tdf#138604 sw: don't advertise AS_CHAR as "to char"
        
        Change-Id: Iff6726ef7b7f483e2bb407e9c2cd67427470645a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115358
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [3c8b248b5a7395b174fc265e3237bd79aeb2455f]

        tdf#76258 Add OOXML import for color filter
        
        Change-Id: I74cf4f56e0adf1cb8af8e6e932c14b30cce67c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115168
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-11  Szymon Kłos  <szymon.klos@collabora.com>  [3595670c9082639b3efcd8d9426e4909b8fa212a]

        Fix style previews widget with multiple languages
        
        Broadcast also universal name (English identifier) for styles
        on change. This allows to select correct style without knowledge
        about all languages that other users use in other views.
        Fixes style previews widget in online with multiple sessions in
        different languages
        
        Change-Id: I9b9bcc92d96b5a5482a97a5947f148a638f257d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115093
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115298
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-05-11  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [69b376d21dfe43482f67ece137421a7487f0cbae]

        tdf#76258 Various fixes for color filter
        
        Change-Id: Ifb4114597efcb7a957d2e42867d1bdc8abfe7730
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115340
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-11  Jim Raykowski  <raykowj@gmail.com>  [a80eefb7413245f81692c443b06f7d3a6a92f28c]

        tdf#84502 CuiConfigGroupListBox Macros,Styles like category for Sidebar
        
        Decks
        
        Change-Id: I4d41952547c98ba66c40c1aa1e9776cdf31304c9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100455
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [b137ff671f25a605334083c0f87ada84eaa0fcf2]

        vcl: Don't just return OK when executing a dialog in Android
        
        This was probably "ifdef-ed" out for Android because of some old
        assumptions and isn't true anymore today. This has prevented that
        the dialog for macro execution shows up on Android when the
        document is loading.
        
        Change-Id: I662d2deb1520f9a3b421dac05f858488aef825fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115307
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [7aacb991f4777e9bcb5bf70a9259887d8dc6d8da]

        lok: move handleMacroConfirmationRequest to its own method
        
        Just refactor to make it similar to other requests.
        
        Change-Id: I1a76d3d4ecc02b0a223ab8e44b11047455280142
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115306
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d7f734db2c078ced3ce08ad58cd816a79abe3bcf]

        lok: enable macros by default for Android
        
        This enables macros execution for Android, so the user will be
        asked to execute macros (assuming the security level is set to 1,
        which is the default) if the document contains any macros to
        execute.
        
        Change-Id: I34dbd123c5b4ea7386096fd3a21766da3479be6c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115305
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1bcad85a5d48cc38ced5883de364f2c66ada273e]

        drawinglayer: move converter.hxx to public include
        
        Change-Id: I71a15c532ba161d69585bd47631b3a8e2f6ddd66
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115304
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-11  Xisco Fauli  <xiscofauli@libreoffice.org>  [2d7db1f688fc3b7e7ce9276776a40d6d8db8d536]

        tdf#134490: sc_ucalc: Add unittest
        
        Change-Id: Iac75d72506eceb6d1104f607d32cdf82c68fb566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115365
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-10  Noel Grandin  <noel@peralex.com>  [1820db814909643df22bcb24ba28495adb87fe70]

        speed up SfxExtItemPropertySetInfo
        
        Change-Id: I7fdf0395c40f1932cfa1fc6ada91accc1912851a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115352
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Mark Hung  <marklh9@gmail.com>  [68c1682929d5b8af95e299a2cfb3fdbb4f97e5ed]

        tdf#105650 different strikethrough offset for vertical writing.
        
        Change-Id: I7f1a8753bb00972865625628baeff76ff5dc4699
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115015
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-10  Mark Hung  <marklh9@gmail.com>  [5686c1aca40beb9514d40c86b4a3780a8a1334ba]

        vcl: use DWriteTextRenderer for vertical writing.
        
        It's really not possible to support vertical writing with old
        ExTextOutW API, use DWriteTextRenderer in this case. This also get rid of
        the hacks to prepend '@' in front of the font name when it's for vertical
        writing.
        
        Change-Id: Icf594dd248be35fb101d6c1e296971f1acf56e39
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115017
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-10  Michael Stahl  <michael.stahl@allotropia.de>  [16de54a5c47fbc4691ee099c1f7bb559a8fe11ac]

        tdf#138209 ODF export: work around forms problem in LO < 7.0
        
        LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess
        when storing form documents it has loaded from ODF 1.3 documents: the
        XML parts are stored as ODF 1.2, but the storage (and therefore manifest
        entry) keeps version 1.3.
        
        To avoid this, store form documents as ODF 1.2 extended by default.
        
        Unfortunately a bunch of ODF export code accesses the global
        SvtSaveOptions variable; with this version override, only
        SvXMLExport::getSaneDefaultVersion() must be used.
        
        Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [d9a6e0c8b74522fca7ff008a13184e479efd1ba0]

        gtk4: GtkPopoverMenu doesn't have "deactivate", try "closed"
        
        Change-Id: Ia14944468ebe743999d8c283b96f60352589f82e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115351
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [60ed173e04838c57c1a73279d01fdad9bdd1575e]

        gtk4: use gdk_wayland_toplevel_set_application_id for dynamic icon changing
        
        Change-Id: Ie1f903a9fa8bfdb94ec3fc0409b350a3e73c444d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115350
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [40b7d4b26fa6696db11e6f65b4d340f317f03b9a]

        gtk4: gtk_im_context_set_client_window->gtk_im_context_set_client_widget
        
        Change-Id: I21d3cd5daf77264f08c6864425c6d9ff37404325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115349
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [4e5f2861154e6bccb7a77356c76c5327d8bda6c4]

        gtk4: use gtk_window_minimize to replace gtk_window_iconify
        
        Change-Id: I6c50e6f60e24dd5bd93e1ef5f62f3cd3845f9194
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115348
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [f1311618e29315526565797f6edf2918d58f0fe4]

        gtk4: GDK_WINDOW_STATE_WITHDRAWN is gone
        
        Change-Id: Ibeca97ca0ac849d69b3b32db6d6f27da7cf551b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115347
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [34715eac43604ca9460ec731964f553a4507b285]

        gtk4: add some degree of support for minimized/maximized/default size
        
        so we start up maximized instead of just a titlebar that needs to
        be expanded
        
        Change-Id: I60c8cdd22c5b2bb659ae10806ccde27e964d6733
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115342
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5aa48d61f82b2cbaa8995350e8c8d448d300c264]

        reduce frequency of dynamic_cast
        
        by checking cheaper things first
        
        Change-Id: I0c93021966ee09967f0ce2e265adafb279b669bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115356
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Noel Grandin  <noel@peralex.com>  [e368cc61fa715e98fbc448c5b0edc781915f8385]

        reduce cost of locking in SvtModuleOptions
        
        Change-Id: If9e0c275822b733d339845d16edfbc5942b4aa6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115354
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  David Tardon  <dtardon@redhat.com>  [158737c2aa29904b726829399f9f5b24345dd013]

        upload libmwaw 0.3.19
        
        Change-Id: Ibb26390e6cc13c925f499bf95cfc6177d8c9b735
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115355
        Tested-by: Jenkins
        Reviewed-by: David Tardon <dtardon@redhat.com>

2021-05-10  dante  <dante19031999@gmail.com>  [9c9f3ae5d8d6aedd71cae5a292bc55ae42eacd1d]

        Test Kahan Sum. Will check Kahan sum stills work properly.
        
        This test file contains summations wich won't work with a raw sum.
        However Kahan Summation can give a correct output.
        
        Change-Id: I6fb3ded287414e8a99964b838c63f52f9262576e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115256
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-10  Eike Rathke  <erack@redhat.com>  [3561978410579c5222889eb7dce68f917b550334]

        Resolves: tdf#142186 Accept 123.45 fractional input on weird formats like 0"."
        
        ... or 0"."0 where the literal "." is also the decimal separator
        but can only occur in the integer part.
        
        Change-Id: I95093fdddf7759346f2869ee322222de3d130e55
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115338
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [06ae35e5e26bf5054598e002cfc6639d844346ab]

        update leak-suppress
        
        with some CPPUNIT stuff that is being deliberately leaked
        
        Change-Id: I7e3e3090877394f05e5bc9f270c456de7e7c57f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115333
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [eabdf3bfce20513b3650766836f7d141fa088bfd]

        gtk4: add focus-in/out
        
        Change-Id: Ia954b2b1cc0ea368a318549f39e2efab42a0ebb2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115339
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [2947ae712ff0e21fd9c1c32a0926284f2b87d4a7]

        gtk4: get the event state into the button press/release
        
        Change-Id: I85b7e64cf8216a7abf18432bbf7bf659876ee07a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115337
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [b3f9975c763a1430c052d7a75d572d8f47cfd1fa]

        gtk4: add crossing events
        
        Change-Id: I80adcb946a3f76b7a20fad381667a445e5927566
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115336
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [6c6b2fcdf34d9463aeb6d9b94474b5334f5fc20a]

        gtk4: get motion events
        
        Change-Id: I44f28891015cadf3714dbecd48bad73296d78b53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115335
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [bd0968922f214663e2e376c9429db2d8f942631f]

        gtk4: add gesturePressed/gestureReleased support for basic clicks
        
        some unknowns here still, but gets some clicks working
        
        Change-Id: Ib97a3b70baba5bcce70b71b6d030a1ad2a591724
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115331
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [819b575037abc479a0eb34afb15a2a1e846e40b2]

        gtk4: enable the existing longpress and swipe gestures
        
        for what limited amount of use they have
        
        Change-Id: I86f35fde191c0864cdfe9b56176bd71bd488bc1f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115330
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [62414237e04d16ffe69ed460d336ebc7a6f4bf5f]

        gtk4: new close-request looks equivalent to old delete-event
        
        Change-Id: I4176de9e8eb2029979f478e4a32e25e0314c7d99
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115329
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [7db0efb7a318d8628168d3ca7bab1690f15828e2]

        gtk4: use GDK_ALT_MASK
        
        define GDK_ALT_MASK as GDK_MOD1_MASK for gtk3
        
        Change-Id: Iff6340956b83403af37b0416a234b6937f1bea18
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115328
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [0cd000bb83719982c1fd2265ea040c82af5bf98e]

        tdf#141613 sw: avoid possible crash when undoing header creation
        
        Move the ClearRedo() call to the very end of the undo process in order to avoid heap use after free.
        
        We still need to call ClearRedo() because there's no mechanism in place to Redo a header/footer change.
        
        Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104
        "tdf#141613 sw: fix crash at header/footer undo".
        
        Change-Id: Ibd4604379c9791e85aef3d4dc6c29c9e3ecd5a28
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115275
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [2436ed69a9dec1432117e894cba8ed693960f581]

        gtk4: enable signalTooltipQuery
        
        Change-Id: Ida3593b1e6ecc98425342f9059f0dcd65901823c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115327
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [fdb44082252bfbb6a174216be43746421a312180]

        gtk4: enable signalMap and signalUnmap
        
        Change-Id: I614296cfc2ccf78e45a9b9df04977c938e47dff4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115326
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [9837e74c2a4ea95cf38c65c76a81c405f256dda8]

        gtk4: enable partial signalRealize
        
        Change-Id: I17bc5d5c0250aea6852e9e82e3742fece4966b34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115325
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Miklos Vajna  <vmiklos@collabora.com>  [014f33066a99488c52d10d8f5ff470ca6e2242f6]

        svx: fix crash with active text edit vs slide delete
        
        The problem is that SdrObjEditView::HideSdrPage() may delete
        SdrPaintView::mpPageView when it calls SdrGlueEditView::HideSdrPage().
        
        But SdrObjEditView::pTextEditPV is a non-owning reference to that.
        
        GetTextEditBackgroundColor() in svx/ calls
        SdrObjEditView::GetTextEditPageView(), so in case
        SdrObjEditView::pTextEditPV is not cleared, we would access a deleted
        SdrPageView.
        
        Change-Id: I948bae8e0e8d557e38aa8f243e9eea522b21a043
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115324
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [0afb2b63b38dff138e66f4ac8afed60911cb6aad]

        fix some leaks in basic
        
        Change-Id: I52c10cdbe9661974c908ee052336c779a40de402
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115323
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Mike Kaganski  <mike.kaganski@collabora.com>  [b3541dea4889b9d0039554f87bd16e55189cf8b1]

        I suspect that we unlikely to use JRE older than 1.3.1_07
        
        ... and so possibly can rely on -Dfile.encoding=UTF8 now.
        
        This reverts 79ac0685de0b19d856db70a208a8372cb589646c
        and 3428bace79d64a10cfcabb79e4caa608ee5db233.
        
        Change-Id: Ia9e09025691b200c0f79427e0f4efe500f9c81f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115272
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-10  László Németh  <nemeth@numbertext.org>  [b11287cda0ce308f5fddac4c0877718fec7c70a5]

        tdf#142130 sw track changes: fix crossing out of neighboring images
        
        Normal images got crossing out from the next deleted images.
        Fix it by using only the start position of the image in CheckLine()
        instead of the 1-character length range of the anchor point.
        
        Note: add unit test also for tdf#78864.
        
        Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d
        (tdf#78864 sw track changes: cross out deleted images).
        
        Change-Id: I8894e625d479adea4b1003f55f24f292064ed7ba
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115255
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [0038386cdecc3856da5f1d9696cc13713f0e206d]

        gtk4: enable signalDestroy
        
        Change-Id: Idd15db9c8666887818a6a119ee796db86fd1482f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115320
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [b03af6e223b95f047f50018c3b1b1eac6dfe6091]

        gtk4: implement drawing and resizing
        
        now we can see something
        
        Change-Id: I428354ce382bb4dbf163309b80316488436b027c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115319
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [e79599b936d0113f95464455e8719c592d0f814e]

        gtk4: fill in getXScreenFromDisplayScreen
        
        for whatever that's still worth
        
        Change-Id: I0be6ccfe6260b9b9f07922293a6654a12a181cdd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115318
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [603c959482ae89c16240b07bd1698d060cdf7a87]

        gtk4: implement GetDisplayScreenCount
        
        Change-Id: I23cb4607da4ec4bbe1a8dac0484b269a919011a0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115317
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [cbfeec278196f2083db52cb6b1eb627b624b44aa]

        gtk4: get monitor size
        
        Change-Id: I833fbb041c97b10cdca57b21aa7c467a7add646a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115316
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [6bab3e80deb7733d2b2d4802a65430f541b86782]

        change <No selection possible> to avoid getting identified as an xml tag
        
        Failed to set text '<No selection possible>' from markup due to error
        parsing markup: Error on line 1 char 23: Odd character “p”, expected a
        “=” after attribute name “selection” of element “No”
        
        Change-Id: I8567862cb0f746529bcaa370e61a423dc9f646b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115313
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [b9b7f6b36af919c1e99a8918986d22a58a9fb95c]

        gtk4: get toplevel menubar and menus working
        
        with gtk_popover_menu_bar_new_from_model
        
        doesn't look great, long menus don't seem to scroll
        or anything like that, but the entries do work
        
        Change-Id: I69d6c324b9fe556067ded9acdf1af574ed784a09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115312
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Balazs Varga  <balazs.varga991@gmail.com>  [3cd6402c5443c8069c07d9e420d5ef5b43af6bef]

        tdf#127301 XLSX import: hide hidden named range of autofilter
        
        Create but not insert/add hidden FILTER_CRITERIA (_xlnm._FilterDatabase)
        to ScRangeName, because no need for them, so avoid of creating
        extra named ranges by autofilter re-range (shown in Sheet ->
        Named Ranges and Expressions -> Manage...).
        
        See also commit 3a2263a20629b0a3e9b4935dd43dc59817d0241c
        "mib17: #163146# XLS import: do not skip hidden names[...]".
        
        Change-Id: Ibfd86942a99b251a59394955bc890e6dbe0390f3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115189
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-10  dante  <dante19031999@gmail.com>  [a25c9a2925e64f3adb46a749ce18393aa01b1870]

        tdf#137679 Use KahanSum for SSE2
        
        Change-Id: I97970cbb7a9562081f9a84b1d81423c80ed7f7f7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115113
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [bdba387bad9dea718e21326ddf025be7af383cfd]

        sc_mathematical_functions: Add test for 9a71644aa475a6090f6
        
        Change-Id: Ibf4b5b163b9b9ec123597cf99395a02e25a56be5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115315
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-10  Tibor Nagy  <nagy.tibor2@nisz.hu>  [c89a7e2d900da5a6bded573f6dcff04c7be98339]

        tdf#124457 PPTX animation: export repeatCount
        
        Aanimation timing property "repeatCount" wasn't exported.
        
        Note: PPTX uses a 1000 multiplication in repeatCount to
        support fractional movement of animated objects, e.g.
        1500 means one and a half steps.
        
        Change-Id: Iac0dd10007c3e48f06c131d61671e1f78cad45a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115138
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-10  Miklos Vajna  <vmiklos@collabora.com>  [7ef207a79e13cbb3a98b03d7370e741f5796186c]

        sw: prefix members of SwAutoStylesEnumImpl, SwXRedline, ...
        
        ... SwXRedlineEnumeration and SwXRedlineText
        
        See tdf#94879 for motivation.
        
        Change-Id: I58a7077522264856e84ae53fe9134509b6640690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115308
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [5def21945183b9e4cd86f6c941873a7e5d5d5f67]

        gtk4: start without crashing
        
        toplevel empty frame now appears
        
        Change-Id: I755525ab5af7a2e532686e8633feafeb7f16f81e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115311
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [4c8e2b47cb81a8b582d71db927682753c6d12ad9]

        bodge a gtk4 starting point into existence
        
        this is not supposed to work or anything even close to that
        
        Change-Id: I46b4fed6a1e6cfc885cb4f7c24660bb6438d5101
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115293
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [bc4e15d23cbcaf0a1bff32d4d5d9079805e298e5]

        rename GtkDropTarget and GtkDragSource to avoid conflicts
        
        Change-Id: I7a51cb6939204105cf49c91c92fdf33f9cb7cc42
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115292
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Caolán McNamara  <caolanm@redhat.com>  [2dbf36132a8886b94c5fbb2255dfae9e6028a5bd]

        rename to remove the gtk3 prefix
        
        Change-Id: I219798ed42aff11d09fd45c26ca1a018c2d22c08
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115239
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-10  Balazs Santha  <santha.balazs@simonyi.bme.hu>  [e9f9e2315ba5a4f10ac0d3a6a6a6cca711d49b6f]

        sw: test fix of tdf#140731 (freezing with track changes)
        
        Follow-up to commit e463d239555d3a4dc61797eeb8c638b6442112a3
        "tdf#140731: sw transliteration: avoid too many redlines"
        
        Change-Id: I49d80d6fa5744797b7bb56d470ebc6f3b5f898d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113402
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-10  Xisco Fauli  <xiscofauli@libreoffice.org>  [eef7fab8962b74da7e6bb1d4fee8a54f95e6594b]

        tdf#120761: sw_ww8import: fix typo in unittest
        
        Change-Id: Ia8fef7dea598cd2ea1513908f69e0176c057900b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115309
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [d4f116d9576453f5974eb63db37a33c59ac53bc9]

        vcl: move outdev.hxx flags into own headers
        
        Change-Id: I550a0b374736b25d972d356ddbe62942590cfa1c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114992
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2021-05-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [1dc6221a237aa6960b94c322c2f947db85caa661]

        vcl: move DrawImageFlags to own header
        
        Change-Id: I461c7db931a2011f1b7618159a8863db46c03601
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114991
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
        Tested-by: Jenkins

2021-05-10  Chris Sherlock  <chris.sherlock79@gmail.com>  [efd1d047a70a8e1b78ab75cedda688eaa8d1537f]

        vcl: move DrawTextFlags to own header
        
        Change-Id: I02b40dbb901c07f8049249dbb42dae75a476dd9f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114989
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-10  Szymon Kłos  <szymon.klos@collabora.com>  [804f15e8bd129a7458416d3373142581b032d956]

        Invalidate inputbar after size changed message
        
        when canvas is resized the content is cleared
        
        Change-Id: Iee51583cd74d15add70e8c5cdf0a4fb00d8b6efb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115119
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115297
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [5295bc11e41166258fde5dc57b60f9677b5956e1]

        do not leak SdrObject global pool on shutdown
        
        Change-Id: Id2948f044edc7a4c9497ece5fe7d497e826bc04b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115237
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Noel Grandin  <noel.grandin@collabora.co.uk>  [47a9ee003ceb18ba9f26d2e0035d3faf1779ab05]

        simplify DefItems
        
        Change-Id: I90d5f3f77532f9e6dbbc0b2b87b5a52f4ac27ce6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115270
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-10  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [80c9e7fe5360e3262ec49e174afc3133fbdb88e0]

        Some more vtables are still needed outside mergedlib
        
        Fixup 99af09bf36ffab37ac5ca19c8cc03b741525021b with a few more
        methods - otherwise BColorModifierTest.cxx doesn't link for
        release builds.
        
        Change-Id: I13f0d57e56ba4344564e2534c0ee4e4883ec4d23
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115294
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [1675a68526c43c6c6e4dc850ee911f0c1de75c88]

        tdf#97066 - When using CTRL-A in a listbox, update selected items
        
        Change-Id: I4f20b8e744bf99edd0677839654aa78aadcbfc85
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115169
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-09  Caolán McNamara  <caolanm@redhat.com>  [1a47606374d7bc490da36e0fd9bb59bcb7c091d0]

        fix fuzzer build
        
        Change-Id: I22cad5a2679e68159790fd614c9d33b20f99349f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115271
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-09  Caolán McNamara  <caolanm@redhat.com>  [72ebbea09644568837853198dd83aae1ab33036c]

        cid#1401328 silence Uncaught exception
        
        Change-Id: I7cd29462586b1dfe6fb7268ec3225317c1d2d782
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115268
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-09  Martin Srebotnjak  <miles@filmsi.net>  [898a6881ea8fe6bc05f4ef68554d594bae42bf3f]

        Update git submodules
        
        * Update translations from branch 'master'
          to 25d2fa3ee286cd1713b440f984c37a729a2c6cb7
          - Update Slovenian translation
            
            Change-Id: If447a7b6ce01b64ce36336d08fe542b9a90e5378
            
2021-05-09  Olivier Hallot  <olivier.hallot@libreoffice.org>  [210b54e3fd1eeb265df5bed3618c78b656a5bdd0]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cc7f7b0547c5d6904908d3ef194b3c33ca6cd4f6
          - Fix =FIXED() example
            
            Change-Id: I45a820aa6967756e9554aeec7c2c7ee7437a11df
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115211
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-09  Xisco Fauli  <xiscofauli@libreoffice.org>  [55fc9ea0f40fced82d71379b535fc0c4a24061b0]

        tdf#43175: sc: Add UItest
        
        Change-Id: I1a327038769102ce377136bf0598b1340a0068d4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111808
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [bada120310281bd0993309f4482f0a51dcf44973]

        clang-tidy Undefined or garbage value returned to caller
        
        [clang-analyzer-core.uninitialized.UndefReturn,-warnings-as-errors]
        
        Change-Id: Idc8f2f4a3189a3a65c95740a12387d5df7c0bea6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115266
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-09  Noel Grandin  <noel.grandin@collabora.co.uk>  [9dcd07b6be5739eecb8d8435e8130b20d4d568f0]

        clang-tidy error: Returning null reference
        
        [clang-analyzer-core.uninitialized.UndefReturn,-warnings-as-errors]
        
        Change-Id: Idfb848f343d9c71655848a32a19c03c0e6893b7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115265
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-09  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [d55bf8aab008d84fac673f3cd907f5199347ce77]

        tdf#43175 - Adjust chart references on every copied sheet
        
        Change-Id: I92fcfeecb9aa10bf8974de953399d780ffe02176
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115058
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-08  Caolán McNamara  <caolanm@redhat.com>  [92c047486ee3dc8f327e1de858b206a38e921883]

        cid#1482285 silence Uncaught exception
        
        Change-Id: I0550dadd2990cb0d93b51570b2cc3136afb50907
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115263
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-08  Johnny_M  <klasse@partyheld.de>  [4cc8406abaf8acd5dc2bdba8d46d6c3c44fbc985]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 8b131bb728653d553cc82c565d6addaaaa12468e
          - tdf#132643 Translate German section IDs
            
            Change-Id: If1e007f4b050c705dd708945bf7de9677fccd12c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115251
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Johnny_M  <klasse@partyheld.de>  [c9ee42099554a9a2cfcae7d94130e40001fc3e9b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 975dfeba1f85c1b2f15afc77039970741572ade9
          - tdf#132643 Translate German section IDs
            
            Change-Id: Iae83e3e20f54c4bc444eead9d89f51c872c97e56
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115253
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Johnny_M  <klasse@partyheld.de>  [0b84689b930d48fb55a997a992c7ab7caee53118]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 956d5d9eae5791a69dd08c626c3354566a4b8de2
          - tdf#132643 Translate German section IDs
            
            Change-Id: Id2a94f3a1399285053487dc7386831772dd8a3eb
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115252
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Johnny_M  <klasse@partyheld.de>  [8d9d413ec524b099e200f4f9b1b378050575ebd2]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 118d7ec30411912e5a7804f1050c126ef62eb2c8
          - tdf#132643 Translate German section IDs
            
            Change-Id: Ie729107d1d2badd756b52a2e5d24aa40f537b381
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115250
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Johnny_M  <klasse@partyheld.de>  [ca4dfae2d1a1cf06492cae297d044ef7da867f9c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 592e4a94b8fa8d3b522e8f66167336bf6b8c7181
          - tdf#132643 Translate German section IDs
            
            Change-Id: I601a1350f4481e972f5ebe1537cf08ec50aaff5b
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115249
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Johnny_M  <klasse@partyheld.de>  [da4bb26825bbcac294568fcfcd5a2148ecd0f6f5]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 41f852563103450b4b2c452a173d786a4052d28c
          - tdf#132643 Translate German section IDs
            
            Change-Id: I6649822006bb27286830021158f1b85a66b531e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115248
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-08  Noel Grandin  <noel.grandin@collabora.co.uk>  [1545949690c750d7b512000723b564e69cf3c3a6]

        ref-count SfxItemPool
        
        so we can remove SfxItemPoolUser, which is a right
        performance hog when we have large calc spreadsheets
        
        Change-Id: I344002f536f6eead5cf98c6647dd1667fd9c8874
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115247
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-08  Mike Kaganski  <mike.kaganski@collabora.com>  [c10ce2698a3b001d22db3d33f2f43513cc49ebda]

        Simplify multiplication and division
        
        Use operators that take double for unification
        
        Change-Id: I5ef6f8a684f35dffbd639435415547d6dc96ed58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115208
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-08  dante  <dante19031999@gmail.com>  [e5750bacf680177447134ca6409967ed4b00e434]

        Review of the code affected by KahanSum
        
        Change-Id: I96fd479eeae287ef5c7a8615856631d4ba9b02f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115238
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-08  dante  <dante19031999@gmail.com>  [5545d8f515a2f7af45f0d2ab3ee40dfbde7fa20f]

        tdf#137679 Use Kahan summation for interpr3.cxx (2/2)
        
        Change-Id: I64113449f70d300feace6663c670db3448f43acf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114970
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-08  Mark Hung  <marklh9@gmail.com>  [f0653d01e15ed9f0e0e862a0679ae6ac88a2cb07]

        vcl: vertical writing in WinFontInstance::ImplGetGlyphBoundRect.
        
        Identity matrix isn't enough for vertical writing. For those glyphs
        that is vertical, they have to be rotated 90 degrees.
        
        Change-Id: Ia5f1f8ac9cea89aec2c98b88058ec79f733fc238
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115148
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-08  Mark Hung  <marklh9@gmail.com>  [b35b8079b3f03b93efdaf2d54b4a515df296e71d]

        vcl: Rotate glyph in DWriteTextRenderer for vertical writing.
        
        - This is part of the work to make all the text renders
        consistently use the positions created from harfbuzz.
        
        - Rotate 90 deg if the glyph is vertical.
        
        Change-Id: I0ef6569cf019ed2cfeec0b7e7b9709a7e8cf8021
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115016
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-07  Noel Grandin  <noel.grandin@collabora.co.uk>  [2ed8c34bca56c1a30d727b21d9096cb77e88197a]

        use a single global item pool for chart2 draw model
        
        which exposed a bug in SvxUnoNameItemTable::replaceByName
        
        Change-Id: If3207df6d46a2185b78ea5c3e1c145527b42d7cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115126
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-07  Noel Grandin  <noelgrandin@gmail.com>  [ea67083cf5b8bceeab7d521663c768b59dd49d1d]

        simplify SwAttrPool code
        
        Change-Id: I1bf94fb65f75e80641df7485b228bd1c80870482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115245
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-07  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [1ef26ffe39618a745d3367310565e7eeb184a4c2]

        tdf#55058 tdf#141982 EMF: Add rotation support for INTERSECTCLIPRECT record
        
        With this commit the rotation support was added
        for INTERSECTCLIPRECT.
        
        Before that change rotation was not applied to these CLIP rectangles.
        
        Change-Id: I3da66790e0aeeaaeeb28d2fc30780cba8dbda390
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115102
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-07  Noel Grandin  <noelgrandin@gmail.com>  [13ce37a85ac73a88567c2066fac694e4fc02a6f8]

        add utility method to get last pool in chain
        
        Change-Id: If21defdf1b59219e3b81d803423713972412da7a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115244
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-07  dante  <dante19031999@gmail.com>  [a2729787d9bf29f9c5c05137fe016407ab596b92]

        Use prefix increase operators in ScInterpreter::ScOdd
        
        Change-Id: Ic1542e2667f7683cf222ab6794b348de396e6c20
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115157
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-07  Michael Stahl  <michael.stahl@allotropia.de>  [59d96acec8c4d9e472daa3e2c287b3a754e01817]

        tdf#138518 sw: layout: unbreak fdo80206-1.doc
        
        The 7 flys on the para on page 3 create ~15 extra pages with one
        paragraph each.
        
        Argh! One of the bPageHasFlysAnchoredBelowThis checks was inverted.
        How dumb of me.
        
        (regression from c799de145f7e289f31e3669646e5bd12814e6c5e)
        
        Still doesn't look good but now it looks same as in 7.0.
        
        Change-Id: Ib10c46f48746362d8d679c147ddc8b85157be508
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115242
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Tested-by: Jenkins

2021-05-07  Michael Weghorn  <m.weghorn@posteo.de>  [bcd7a7244208a15e36a724270c72b496e77f84bf]

        tdf#142153 android: Delete unused textures immediately
        
        Don't delay the call to 'glDeleteTextures' but
        always call it immediately via 'TextureReaper.get().reap()'
        in 'Subtile#cleanTexture'.
        
        Delaying it appears to sometimes cause it to be called
        "at the wrong time", resulting in black areas being
        shown instead of properly rendering/displaying the document
        content in the corresponding tile.
        
        This fixes the issue also mentioned in commit
        1bc42472200c32c9a0a10dd1c3cd6c6a8a5d47d2
        ("tdf#95517 android: Rework app/doc lifecycle handling"),
        which was present before, though:
        
        > (Well, sometimes there is an issue with
        > invalidation/repaint and single tiles remain black,
        > but that happened previously - when the whole doc
        > was loaded anew - just the same way).
        
        Change-Id: I5f18dbe3133d9d00a76b129fd119c2e80441e531
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115241
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-07  Olivier Hallot  <olivier.hallot@libreoffice.org>  [60f7fe618a93818ffd08d2b950d4dfa2dde6a47b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f928f353880c4b327765902d5d130496fef0158a
          - fixes in help pages
            
            Change-Id: I42107565a6aa22b97d5dbfa8a026ed8ee4b8a2e0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115205
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [0b6a70c3d945a9bc34f8ac4970a1b80fbbbcc08a]

        tdf#115022: sc_subsequent_filters: Add unittest
        
        Change-Id: I29c633f991231af6b71a7c6e1565c9fdd1604a25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115233
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-07  Arnaud Versini  <arnaud.versini@libreoffice.org>  [b30170661fb3a87d6b0491d748b8eb0d8f3dc99e]

        presenter : use std::mutex
        
        Change-Id: I53e081fd6c52fc040b29fad18dc3a758310f943a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114259
        Tested-by: Jenkins
        Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>

2021-05-07  Luboš Luňák  <l.lunak@centrum.cz>  [ec73a21bccf4a055ae9dc575dbad3d67c91f481e]

        set also dashing cap style for directx canvas (tdf#136957)
        
        Change-Id: I7022ffba519faad5a333d7ef6eabf1ba5f0ae3bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115232
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-07  dante  <dante19031999@gmail.com>  [38c88aca77f8c8ef47470723557ddf9e5d9d7b66]

        tdf#137679 Use Kahan summation for interpr8.cxx
        
        Change-Id: Id43765f7d8f51066da4bbebcfc175a0e69a58fde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115127
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-07  Miklos Vajna  <vmiklos@collabora.com>  [d5cd62164d32273a25913c93aa04be9f7f3a4073]

        embeddedobj: handle getting the visible area on a thread
        
        The Windows OLE2 implementation of the embedded object interface assumes
        that the same thread is used for loading and saving the embedded
        objects.
        
        This means that in case the main thread is used for loading (e.g. from
        remote UNO, but with OnMainThead=true), but a
        thread is used for storing (without an explicit OnMainThead=true), then
        the underlying win32 API call failed and we returned a fixed size in
        EmbeddedObjectRef::GetSize().
        
        Fix the problem by explicitly checking for RPC_E_WRONG_THREAD and adding
        error handling for that case.
        
        Change-Id: Icf1e7722d33a809fa671d1505b2a0155af040c71
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115236
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [5ed1e84ce2acbcc8700a49549b68fe7be19f94d0]

        cid#1482086 silence bogus Double free
        
        Change-Id: I7567ce468f94c9565d2d6fd88a051383dae41013
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115231
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [13aaeb5d148c1ea5163eecaa176fac4a67689277]

        cid#1401328 Uncaught exception
        
        and
        
        cid#1401334 Uncaught exception
        
        Change-Id: I609ec44bf28db28e69533d7b795f705fa8a330f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115228
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [c56b5f9758c942ff5ccaaff5632fbe4ace8c3cbb]

        cid#1474072 silence Untrusted loop bound
        
        Change-Id: I2f966440b59c61bfd692c0e63bdffc37eafdb7a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115229
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Stephan Bergmann  <sbergman@redhat.com>  [37dd4cb99bf44e57cca0272ed6de8c8156f35efa]

        loplugin:noexcept (macOS)
        
        Change-Id: I7eede75da6b81777661e0e5b76c8877e122f941b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115224
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-07  Noel Grandin  <noelgrandin@gmail.com>  [cc8144faafa0518334075090b0c8f90d0b2a2fde]

        convert sal_uLong in sot
        
        Change-Id: I51027e731ce6581ebea08b1f5eb88472c3c27550
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115190
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-07  Michael Stahl  <michael.stahl@allotropia.de>  [533a998e540b0f04068c876dde0e74adc3f79c93]

        tdf#138518 sw: layout: fix assert on ooo43913-1.doc
        
        Assertion `rAnchoredObjPage.GetPhyPageNum() == _nFromPageNum' failed.
        
        Because not only the fly's anchor frame moves forward in
        FormatAnchorFrameForCheckMoveFwd(), but also the fly itself,
        apparently because it's in a table:
        
        0  SwAnchoredObject::SetPageFrame(SwPageFrame*) (this=0x5a1d3d8, _pNewPageFrame=0x8cfbeb0) at sw/source/core/layout/anchoredobject.cxx:162
        1  SwPageFrame::MoveFly(SwFlyFrame*, SwPageFrame*) (this=0x8cbd8c0, pToMove=0x5a1d280, pDest=0x8cfbeb0) at sw/source/core/layout/flylay.cxx:985
        2  lcl_ArrangeLowers(SwLayoutFrame*, tools::Long, bool) (pLay=0x8cf80c0, lYStart=179488, bInva=false) at sw/source/core/layout/tabfrm.cxx:5000
        3  SwCellFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x8cf80c0, pAttrs=0x8ce78c0) at sw/source/core/layout/tabfrm.cxx:5359
        4  SwLayoutFrame::MakeAll(OutputDevice*) (this=0x8cf80c0) at sw/source/core/layout/calcmove.cxx:1036
        5  SwFrame::PrepareMake(OutputDevice*) (this=0x8cf80c0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:375
        6  SwFrame::Calc(OutputDevice*) const (this=0x8cf80c0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792
        7  SwFrame::MakePos() (this=0x8cebdb0) at sw/source/core/layout/calcmove.cxx:627
        8  SwTextFrame::MakePos() (this=0x8cebdb0) at sw/source/core/text/frmform.cxx:340
        9  SwContentFrame::MakeAll(OutputDevice*) (this=0x8cebdb0) at sw/source/core/layout/calcmove.cxx:1412
        10 SwFrame::PrepareMake(OutputDevice*) (this=0x8cebdb0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:286
        11 SwFrame::Calc(OutputDevice*) const (this=0x8cebdb0, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792
        12 SwTextFrame::CalcFollow(o3tl::strong_int<int, Tag_TextFrameIndex>) (this=0x5ae2c60, nTextOfst=...) at sw/source/core/text/frmform.cxx:279
        13 SwTextFrame::AdjustFollow_(SwTextFormatter&, o3tl::strong_int<int, Tag_TextFrameIndex>, o3tl::strong_int<int, Tag_TextFrameIndex>, unsigned char) (this=0x5ae2c60, rLine=..., nOffset=..., nEnd=..., nMode=1 '\001') at sw/source/core/text/frmform.cxx:611
        14 SwTextFrame::FormatAdjust(SwTextFormatter&, WidowsAndOrphans&, o3tl::strong_int<int, Tag_TextFrameIndex>, bool) (this=0x5ae2c60, rLine=..., rFrameBreak=..., nStrLen=..., bDummy=false) at sw/source/core/text/frmform.cxx:1166
        15 SwTextFrame::Format_(SwTextFormatter&, SwTextFormatInfo&, bool) (this=0x5ae2c60, rLine=..., rInf=..., bAdjust=false) at sw/source/core/text/frmform.cxx:1613
        16 SwTextFrame::Format_(OutputDevice*, SwParaPortion*) (this=0x5ae2c60, pRenderContext=0x5b7fcf0, pPara=0x8d07490) at sw/source/core/text/frmform.cxx:1720
        17 SwTextFrame::Format(OutputDevice*, SwBorderAttrs const*) (this=0x5ae2c60, pRenderContext=0x5b7fcf0) at sw/source/core/text/frmform.cxx:1910
        18 SwContentFrame::MakeAll(OutputDevice*) (this=0x5ae2c60) at sw/source/core/layout/calcmove.cxx:1525
        19 SwFrame::PrepareMake(OutputDevice*) (this=0x5ae2f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/calcmove.cxx:321
        20 SwFrame::Calc(OutputDevice*) const (this=0x5ae2f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/trvlfrm.cxx:1792
        21 SwObjectFormatterTextFrame::FormatAnchorFrameAndItsPrevs(SwTextFrame&) (_rAnchorTextFrame=...) at sw/source/core/layout/objectformattertxtfrm.cxx:905
        22 SwObjectFormatterTextFrame::FormatAnchorFrameForCheckMoveFwd() (this=0x8ce5720) at sw/source/core/layout/objectformattertxtfrm.cxx:919
        23 SwObjectFormatterTextFrame::DoFormatObjs() (this=0x8ce5720) at sw/source/core/layout/objectformattertxtfrm.cxx:368
        24 SwObjectFormatter::FormatObjsAtFrame(SwFrame&, SwPageFrame const&, SwLayAction*) (_rAnchorFrame=..., _rPageFrame=..., _pLayAction=0x0) at sw/source/core/layout/objectformatter.cxx:160
        25 SwContentFrame::CalcLowers(SwLayoutFrame&, SwLayoutFrame const&, long, bool) (rLay=..., rDontLeave=..., nBottom=192048, bSkipRowSpanCells=true) at sw/source/core/layout/tabfrm.cxx:1534
        26 lcl_RecalcRow(SwRowFrame&, tools::Long) (rRow=..., nBottom=192048) at sw/source/core/layout/tabfrm.cxx:1653
        27 SwTabFrame::MakeAll(OutputDevice*) (this=0x8cf5f80, pRenderContext=0x5b7fcf0) at sw/source/core/layout/tabfrm.cxx:2425
        
        It looks like the _nFromPageNum is always from the
        SwObjectFormatter::mrPageFrame anyway because that's a precondition of
        the mpPgNumAndTypeOfAnchors->Collect() being called, so just rely on
        that to get the correct page.
        
        (regression from c799de145f7e289f31e3669646e5bd12814e6c5e)
        
        Change-Id: Ibdffb2121cffbc04320d17a29ab2e160dec4250b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115188
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-07  Stephan Bergmann  <sbergman@redhat.com>  [d0b343a781ff792f5acbfafc671970cd48a18da8]

        external/python3: Mark configure part of darwin.patch.0 as reported upstream
        
        Change-Id: Ibf9fb088eb1d7e11582518aeafa233dfa7c56bf6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115223
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [148ad7cf92b216351fce464528af8db0111157f4]

        remove an intermediate layer of widgets
        
        Change-Id: I4fe23f87d997057a2cb061110c8e325c8322b95e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115187
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [8d45e67fe97773666cb5e2db04822476872fa84f]

        preserve comments before root entry
        
        Change-Id: I5fc789258e605b2d74c6697dedd824d722ad53bc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115217
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [d64192e72e76142097ca20f3df8a99373c792f81]

        add missing truncate-multiline properties
        
        Change-Id: Idbb227185806f97e00e99faa88a3fc6818e75513
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115216
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  Caolán McNamara  <caolanm@redhat.com>  [c97fa85d138492c92bc87ec2838a5d1b11d07cea]

        add glade header for uniformity
        
        Change-Id: I8422fb76a14ce4d1bf3ca91072cf9853701f5809
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115215
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-07  dante  <dante19031999@gmail.com>  [a0c7001b0e5ffb66ee1822b9fd8225977e4f0b73]

        Simplify PushDouble by PushError for ScInterpreter::SumProduct
        
        Change-Id: I0e9f5ebe12710008a13961be41ba454c1cd2f978
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114946
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-07  Miklos Vajna  <vmiklos@collabora.com>  [e23200dcb47ee64589e464b1c03a6f2ddc2d5ee5]

        desktop, lokclipboard: avoid repeating the return type from the declaration
        
        Change-Id: I8c3d5f4dcd442c680823a60d6b5b93137a7adc7f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115213
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-07  scito  <info@scito.ch>  [b37cb3e5dbb145c5a5fed094f02c1bc6dc1d31f8]

        tdf#90101 add .uno:PasteAsLink
        
        No attributes or notes are pasted, i.e. only the links.
        Links to dates loose the date formatting currently, see tdf#142093.
        
        Paste As Link is only added as command.
        No entries to menus or context menus are made
        as this functionality is not widely used, see tdf#102255
        
        Icons are added with tdf#141885
        
        Change-Id: Ifbdaa076045b5f10073a658115fea211bb30e6a1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115137
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-07  scito  <info@scito.ch>  [7b450b6ccd9f9bee0bb47500e7bf71f9ba641e36]

        tdf#102255 improve test and docu of .uno:PasteTransposed
        
        check that relevant types, notes and attributes are pasted,
        i.e. the uno command sets the right parameters
        
        Improvement of my former commit
        02b72784e5601636d26c8e4592958c262efb1a7d
        
        Change-Id: I1d8e7d09a867bbabe719bcdd8c7e908ab100aa4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115191
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-07  Xisco Fauli  <xiscofauli@libreoffice.org>  [5ea814f33a137b4adddfd2a0b66272385401bec5]

        tdf#113571: sc: Add UItest
        
        Change-Id: I0f60ea96bdd7b9d73ed9a4d714b42185e69849c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115221
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-07  Stephan Bergmann  <sbergman@redhat.com>  [b0a4b49a88aacfbc127965c0c6fe50a065eb3a0f]

        external/python3: Clang 13 trunk implements --print-multiarch now
        
        ...since
        <https://github.com/llvm/llvm-project/commit/a921d2d2fb46b898794091e7410426c518a4f0cc>
        "[Driver] Add -print-multiarch", which causes an issue when building
        ExternalProject_python3 on macOS:
        
        > checking build system type... x86_64-apple-darwin19.6.0
        > checking host system type... x86_64-apple-darwin19.6.0
        [...]
        > checking for the platform triplet based on compiler characteristics... darwin
        configure: error: internal configure error for the platform triplet, please file a bug report
        > make[1]: *** [/Users/stephan/Software/lo/core/external/python3/ExternalProject_python3.mk:80: /Users/stephan/Software/lo/core/workdir/ExternalProject/python3/build] Error 1
        
        as workdir/UnpackedTarball/python3/configure.ac computes PLATFORM_TRIPLET as
        "darwin", and instead of computing MULTIARCH as empty (as `$CC
        --print-multiarch` used to just print
        
        > clang: error: unsupported option '--print-multiarch'
        > clang: error: no input files
        
        to stderr), it now computes it as e.g. "x86_64-apple-darwin19.6.0" (or whatever
        -target is explicitly set to in $CC), so the check that they have equal values
        if they are bot nonempty fails now when building against Clang 13 trunk.  (This
        is not yet an issue with any Apple Clang version, though.)
        
        Until this is eventually fixed upstream at <https://github.com/python/cpython>,
        just keep pretending that `clang --print-multiarch` would cause no stdout output
        on macOS when determining MULTIARCH.
        
        Change-Id: Ic1b27c6791b327d5709a9d61a6d675c3fa8989bf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115219
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-07  Stephan Bergmann  <sbergman@redhat.com>  [30b6b43bcb8fb772f535be9fd6538465b080fe7a]

        external/python3: First removeunnecessarystuff, then fixinstallnames
        
        otherwise, we could get issues like
        
        > error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: can't open file: /Users/stephan/Software/lo/core/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.8/lib/python3.8/lib-dynload/_curses_panel.cpython-3.8.so (No such file or directory)
        > error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: can't open file: /Users/stephan/Software/lo/core/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.8/lib/python3.8/lib-dynload/_curses.cpython-3.8.so (No such file or directory)
        > error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: can't open file: /Users/stephan/Software/lo/core/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.8/lib/python3.8/lib-dynload/_testinternalcapi.cpython-3.8.so (No such file or directory)
        > error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: can't open file: /Users/stephan/Software/lo/core/workdir/UnpackedTarball/python3/python-inst/@__________________________________________________OOO/LibreOfficePython.framework/Versions/3.8/lib/python3.8/lib-dynload/_dbm.cpython-3.8.so (No such file or directory)
        
        when the two jobs run in parallel
        
        Change-Id: I6db18d7a6fa0ce177e88f8f714434acf9afe3ea5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115218
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-07  dante  <dante19031999@gmail.com>  [2b90807fd474cb4e26c80ba5407aca4b66f6d3a2]

        tdf#137679 Use Kahan summation for interpr5.cxx
        
        Change-Id: Iefd09f2af4c77a464e47367c75b9e7e303f2c2a9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115128
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [52ffeb5eec8fd1f00cde59af173f40ef55099c53]

        tdf#57841: sc: Add UItest
        
        Change-Id: I584883f152041be7e241047dcc5c084dd784260f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115220
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [d6375dcd1db6ce7e1bae8297949801f7d4249e52]

        loplugin:unusedmethods
        
        plugin code needed some updating because it was interacting badly with
        PCH code in pluginhandler::ignoreLocation
        
        Change-Id: I228f94a4e285747bd1d5b8536010f8617118cafa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115212
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [48969e9f578c16ff4142b2911746212044cbce61]

        ofz#33899 basprov also now needed
        
        since...
        
        commit a52590d76b89dc75be2aa87f4287624c89f1e82f
        Date:   Fri Apr 30 22:01:24 2021 +0900
        
            update native-code.py with services for vba scripts in Calc
        
        Change-Id: I56d071786b85491a833d75a573b95c166e57b24c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115214
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [7dc277c97491887c7f6cf2bb24e55596740ba7b5]

        release mouse before showing context menu
        
        otherwise math loses focus due to the mouse release
        
        Change-Id: Ie50cfde6a9f13d87efba2f6ec4830b9730f6e938
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115186
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [6bf2239a189423d087b2536dd7054b21df58ddc4]

        tdf#55058 tdf#141982 EMF: Add rotation support for ARC, ARCTO, CHORD, PIE
        
        Change-Id: I5d9b76f0ddd2b7f12604f472986dd95976a8b04d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115185
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-06  Mike Kaganski  <mike.kaganski@collabora.com>  [ef5b56123701b62b7fabeb1d1d9a7d1a4aa00d97]

        Limit scopes of some variables
        
        Change-Id: Ia8b2aae8953e2543b5c49a2cd7ddc4e84ba46f4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115197
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [a7ff945ca031324f060b0d989f7a89594fcfe9fe]

        add SfxItemPoolDeleter utility
        
        add use so we can hold the pool with std::unique_ptr
        
        Change-Id: I685fbc37c0ae145a5b48a66a88eab9fb29a0fc0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115174
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [6668b112b341edd24ca77ba88b834108d67b0602]

        Resolves: tdf#138855 crash on use of Outliner freed by GetFocus
        
        probably since...
        
        commit 3a662445a0e3666637e5eb140b106a1347f050eb
        Date:   Sun Jun 23 17:54:49 2019 -0800
        
            tdf#126061 Make text edit outliner view show cursor
        
            Change-Id: Ic4e8b5984d5b21c3b789eba943d35d4cad1ba867
            Reviewed-on: https://gerrit.libreoffice.org/74676
        
        Change-Id: Ibd6cf9e6f539e651d6e98f2af4a2eba55f081b58
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115184
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [47c0cea5aae8f1ac5c8d79fc09a30c8c5f14af64]

        tdf#126226: sw: Add UItest
        
        Change-Id: Id236fa585ae02cb0282a7d6179b9cb2d779dfdf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115182
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [473c68d0f8014c1f594e6f4c683594024a307007]

        crashtesting: failure on export of ooo26119-1.sxc to xlsx
        
        since...
        
        commit 3a24211a1d49f33ca52e4fb2c927d50304f005df
        Date:   Thu Apr 29 17:26:59 2021 +0200
        
            tdf#54037 PPTX export: fix internal hyperlinks
        
        calc XDrawPage doesn't support XNamed apparently
        
        Change-Id: I796b65682f099deebee0da2e84bfbe391108c4cf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115181
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Eike Rathke  <erack@redhat.com>  [cb9aa621a683a254e5df6e8016fcf2755c2def5b]

        Add English (Denmark) {en-DK} locale data
        
        Using ',' comma decimal separator and '.' dot group separator.
        ISO 8601 date(+time) formats.
        Inheriting calendar from {en-GB} (week-1stweek=4 first_weekday=2).
        Currency DKK 'kr.' symbol.
        Secondary currency EUR '€' symbol.
        
        See also https://lh.2xlibre.net/locale/en_DK/
        
        Change-Id: Idcf1e52af0ac20412efa42d3873ab1e34a2f1eaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115177
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-06  Alain Romedenne  <alain.romedenne@libreoffice.org>  [89d1c83502aa3b8cfb90a15f23a04608f0df5c4a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 605791780909d8dd5e4c36663def5c0c9c3bbdb0
          - sf_Dialog(Control) Python support - part 1/2
            
            Change-Id: I204a78557c607708870a51699af140e13ff2c0e4
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114724
            Tested-by: Jenkins
            Tested-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            
2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [130486015f03087aa4c2c43709ce95fb494df44b]

        use Widget::get_clipboard
        
        there's no different from GetSystemClipboard except potentially for
        the libreofficekit case where per-frame clipboards are possible
        
        Change-Id: I3173e39f81a03a7cbe114ebca6020d5ed36a659a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115179
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  László Németh  <nemeth@numbertext.org>  [ed7271d9d44fe1a0195ae669644f23c01b6960d8]

        tdf#128913 DOCX: import track changes of inline images
        
        Deleted images were imported as not deleted part of
        the document. Both deleted and inserted images lost
        their change tracking.
        
        
        Change-Id: Ia273d307d01c5ea535889bc9951084e96cd7fc50
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115178
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [1ff996e5e720d77ce32b8c44d4c29569ddbc113a]

        add get_clipboard to widget
        
        Change-Id: I9a623e558bc18286af773e0aa3120185a30baa52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115172
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [e30b4b641a4828c834e387181c9ea05f9bf6f936]

        cid#1482085 Uninitialized scalar field
        
        Change-Id: I1836b7df127e6e858e5fced679b0fc3754665daa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115171
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-06  Xisco Fauli  <xiscofauli@libreoffice.org>  [ae5e62ee70ca22e3bf89becd01f6067bfaa81921]

        tdf#125440: sc: Add UItest
        
        Change-Id: I24b1cf0c7d19d9314fcdbeefb9082fc9c227b98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115165
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-06  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [b6516acdb96a7417f0d58749723750d83547f98a]

        update credits
        
        Change-Id: Ifa86e93a66d54d5ad8f288ba111cbe4ca1695415

2021-05-06  Jean-Pierre Ledure  <jp@ledure.be>  [53230b495407ea7e26cd3c01509bc773dad0bc7a]

        ScriptForge - (scriptforge.py)Non-modal dialogs and OK/Cancel buttons
        
        In the SFDialogs.SF_Dialog class:
        - Fix the comments describing the behaviour of non-modal dialogs
        - Add the OKBUTTON and CANCELBUTTON definitions
        
        Change-Id: I2d3abc1c610b0c60949987feb1a9d66e21abfdc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115152
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-06  Andras Timar  <andras.timar@collabora.com>  [645cb7eda4fbe83ed748aafa41d210db274e22fc]

        pdfium build fix with Android NDK 19
        
        Change-Id: I618095efab0a7ed7babdabc36db6a473b1af78da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115161
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>
        (cherry picked from commit 01765acee6b4931b6c69252b8357f81fd26e33bd)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115090
        Tested-by: Jenkins

2021-05-06  Attila Szűcs  <szucs.attila3@nisz.hu>  [f05c57b96293c80825be66162ca7bf3e4dbc8ea2]

        tdf#121659 DOCX import: fix lost column break at shapes
        
        The column break was moved into the neighboring shape during
        the first import, and eliminated during the second import,
        losing the 2-column text layout. As a workaround, split the
        paragraph moving the column break into a new paragraph.
        
        Based on the patch written by Justin Luth.
        
        Co-authored-by: Justin Luth and Tibor Nagy (NISZ)
        
        Change-Id: Id4042a92b09aa55952bc0ea02319d5e588f77d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114904
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [0664228c1648a6f88ccf251ccc0bdda57b2717a9]

        cid#1482086 silence bogus Double free
        
        Change-Id: I54bd03f6a46f894b729d3977057f0729640db49a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115175
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [d7e948938367048a4e408c30f2efb927e76a604e]

        use Label::set_label_type to designate a label as a warning/error
        
        To be consistent with other cases. weld::LabelType::Error is another
        option. What colors, if any, it results in isn't cast in stone, but be
        consistent in that all warnings (or errors) use the same ones.
        
        Change-Id: I6943aa6370cf6cead60cd404987e8211532143eb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113529
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [500e59e4825c0a140ed4bb4576ddb6a46f08c860]

        cid#1401334 silence Uncaught exception
        
        Change-Id: I7d0d9324afdfd5e06e2def62919dbefb78abdb3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115173
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [1a1754b7ab47eba74ad86197c327f304c5b0deb8]

        Fix typo
        
        Change-Id: I646f74fd79d48ab906f9b9c2588c800f301ccac6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115124
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-06  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [761fdaf26dc9ed7cd0d25a7630576e7800813e2f]

        tdf#142004 tdf#141982 EMF Import: Add rotation and path support for EMR_ELLIPSE
        
        Previous implementation of EMR_ELLIPSE, doesn't support rotation
        and EMR_ELLIPSE was not work with EMR_BEGINPATH, EMR_ENDPATH and EMR_ABORTPATH
        
        The EMR_BEGINPATH opens path bracket construction.
        
        Once path bracket construction is open, an application can begin specifying records to
        define the points that lie in the path. Path bracket construction MUST be closed by an
        EMR_ABORTPATH or EMR_ENDPATH record.
        
        With this patch all these issue was resolved for EMR_ELLIPSE
        
        Change-Id: I6d352e0ff0326dd788d43272bf1330fa6c777df4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115101
        Tested-by: Jenkins
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>

2021-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [5f10242591d88f6627d7cd82172551879168f9be]

        Fix typos
        
        Change-Id: Ibc86f8a76080b55dd7c5a458e2b8fa7ce534a4b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115164
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-06  Tarun Sharma  <starun.1998@gmail.com>  [2e417a09b5497bb8aa86727a280960aeb5023af0]

        tdf#97087 Give unique, comphrehensible names to idles
        
        Change-Id: Id146a5a89c9189285409641494badf3d49931a0b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115064
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-06  Caolán McNamara  <caolanm@redhat.com>  [de1c3bd004b069cd1796423e796999cf0737f823]

        allow ctrl+A to select all in calc header/footer dialog too
        
        Change-Id: Ie3142ced5ddf80a9dd49774d26e450318f18b641
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115170
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-06  Michael Stahl  <michael.stahl@allotropia.de>  [dc8c8a4aa20ddd3139a25d5c052cac9bae944cb8]

        gbuild: work around GDB 10 bug with DWARF5 in split debug info
        
        GCC 11 defaults to -gdwarf-5 and GDB can only read it if
        -gsplit-dwarf isn't used.
        
        Dwarf Error: wrong unit_type in compilation unit header (is DW_UT_split_compile (0x05), should be DW_UT_type (0x02)) [in module /workdir/CObject/desktop/source/app/main.dwo]
        
        https://sourceware.org/bugzilla/show_bug.cgi?id=27354
        https://bugzilla.redhat.com/show_bug.cgi?id=1956475
        
        Change-Id: Ie2ac7193a29a8f257cf6f1d711f9fa6941df48ad
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115054
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-06  Luboš Luňák  <l.lunak@collabora.com>  [32f2d2f7f99f73203294a91a9b432fd0c3fc7f99]

        a unittest for my cairocanvas fix for tdf#134053
        
        Note that even though the fix is for cairocanvas, the unittest
        currently really checks only vclcanvas, because tests for cairocanvas
        do not work.
        
        Change-Id: I2c34822126c93460971c34932d5bdf3fe2d698b5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115146
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-06  Luboš Luňák  <l.lunak@collabora.com>  [7603d51e7747a0ea2e628bd467af7d17597a9b10]

        add a unittest for impress drawing a dotted line in tdf#136957
        
        Change-Id: Icabe039df29e9b3b9155656863120e3df7ef650b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115118
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-06  Luboš Luňák  <l.lunak@collabora.com>  [402acbcfadbc8fd9f45330b46a4bfaad3e02eb39]

        make it possible to write canvas unittests
        
        One of the problems is that canvas apparently works only with windows,
        but tests obviously need an offscreen surface. This patch moves
        Window::GetCanvas() to OutputDevice, and makes vclcanvas capable
        of working with OutputDevice classes that are not windows. Other
        canvas implementations still don't work, but presumably at least
        cairocanvas could be fixed too.
        
        This commit adds a "simple" test that just draws a line and tries
        to verify it's been drawn properly. Adding another test should
        be a matter of basing it on this existing one, and then copy&pasting
        the complicated UNO way of drawing using canvas from somewhere,
        such as canvas/workben/canvasdemo.cxx.
        
        Change-Id: I42db12b09433763cd31c3dd497c10157424b8598
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115117
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-06  Luboš Luňák  <l.lunak@collabora.com>  [834822413d687572691753c33d837ffdb5064f2b]

        transform by vector length, not just X
        
        I missed this one in b71d9a6d15cfb8a50afdea5ac064f40d84c561f8.
        
        Change-Id: Ibbfd6ed1e064030a6a2818df94d7d61dd2b92caa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115116
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [31072493884f9df025befd1744f2e5eec940ff00]

        Removed duplicated include
        
        Change-Id: I8bcbbcff598ea472f9476c0d5e57fbfc0a9dcc0d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115162
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-05-06  Andrea Gelmini  <andrea.gelmini@gelma.net>  [2335afc8f1d15e7b0a7a242fbceacb8b9f98a7a8]

        Removed executable bits on pptx
        
        Change-Id: Ifbe14a29ac80143c23c189c80599e38816cc6b1a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115163
        Tested-by: Jenkins
        Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>

2021-05-06  Noel Grandin  <noel.grandin@collabora.co.uk>  [1f6b98f21495f0ecc5ded493cb3273da03852191]

        replace SVL_CRYPTO_MSCRYPTO with _WIN32
        
        just to reduce the number of different #defines at work in this
        file.
        
        Change-Id: I586b09a3c3c4c8eed4971a0e89d8def9d848b9fc
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115166
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-06  Heiko Tietze  <tietze.heiko@gmail.com>  [6dfc49bb6a72bf6bb79167b12f0d2d0c5a155d06]

        Resolves tdf#141986, related tdf#141566 - Dark theme
        
        Introducing dark color set
        
        Change-Id: I21d37e191c8a58468daa881f35ab847216493bb1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115042
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-06  Miklos Vajna  <vmiklos@collabora.com>  [5f51b6f08c6ed6fb135b8d4999d6fb6a51fafa89]

        Replace magic numbers in SwPageFrame::UpdateAttr_()
        
        By using the same SwPageFrameInvFlags constants that
        SwPageFrame::SwClientNotify() already does.
        
        Change-Id: Ic07ce518901890367ce95080bf2a588697b8990b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115156
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-06  Gülşah Köse  <gulsah.kose@collabora.com>  [6af7691518f24835d600c692bff1dcd66f5e0ced]

        tdf#141424 Include the margin sizes while calculating width of window.
        
        Follow up development f61fcf6fe6b9f54dd57ca5d868b1b0436e9cec61
        First one fixed only horizontal panes. Apply the same fix to vertical
        panes (eg: sidebar->gallery)
        
        Change-Id: I7e5e1bb7bf559741dd265a8bbc6f845a2f31efde
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115151
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-06  Eike Rathke  <erack@redhat.com>  [9df3aa7ea72d61462e430643f2a80906dce4e15b]

        Change en_GB calendar StartDayOfWeek to Monday and MinimalDaysInFirstWeek to 4
        
        Inherit day, month and era names from en_US but with proper
        values. See https://lh.2xlibre.net/locale/en_GB/
        - Week definition (week)
        - First day of week (first_weekday)
        
        or
        
        % LC_TIME=en_US locale -k LC_TIME
        week-ndays=7
        week-1stday=19971130
        week-1stweek=1
        first_weekday=1
        first_workday=2
        
        % LC_TIME=en_GB locale -k LC_TIME
        week-ndays=7
        week-1stday=19971130
        week-1stweek=4
        first_weekday=2
        first_workday=2
        
        This makes it necessary to adapt basic/qa/vba_tests/weekdayname.vb
        because basic/qa/cppunit/test_vba.cxx sets LANGUAGE_ENGLISH_UK
        
        Change-Id: I752bf0e59396f0cbd601beb596c07e77e4e4cfaf
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115160
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-06  Rafael Lima  <rafael.palma.lima@gmail.com>  [e76292edc1d7e70ffa3f3940dc635581eb1a121b]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f9a2226309678e6a8769af6d312f796bb6835c4b
          - tdf#131368, tdf#141474 Document WeekDay Basic function
            
            This patch updates the WeekDay documentation to explain the use of the second (optional) argument, that refers to which day of the week should be considered to be the first day of the week.
            
            This patch also refactors the Now function help page and adds a variable for x-ref.
            
            Change-Id: I4bfc9070fc93593217c3c9086935dfc728adee3c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114868
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-06  Eike Rathke  <erack@redhat.com>  [581ac7e27ae6f8faf197c4f6962e05e9bed37351]

        Derive en_HK calendar from en_US instead of en_GB
        
        Reason is that en_US start day of week is Sunday and en_GB is to
        be changed to Monday but en_HK is to be kept on Sunday.
        See also https://lh.2xlibre.net/locale/en_HK/ that does not
        override First day of week (first_weekday).
        
        Change-Id: I7f1b4059a23c8a6cdf6e30a3a6d18e2b911f4974
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115159
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-05  Eike Rathke  <erack@redhat.com>  [75aa541d6a7c15f6e79b29c0a1b6e813cebc1ac3]

        Move en_KE to lcl_DATA_EN where it belongs
        
        Comment en_IN and en_MY why they should / have to stay.
        
        Change-Id: I816741324bfc328ec4e0bf269ec27f65fe79f3f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115154
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [223e6484b5147464ae684fa520004316b4ec031c]

        loplugin:unnecessaryvirtual
        
        Change-Id: Iedb9586fcf34dc172b93f0a246b1c1e1c9033376
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115153
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [51b6b12195d77631ca94d4c85b429dace8e3b173]

        add io libraries to fuzzer-common
        
        since...
        
        commit a52590d76b89dc75be2aa87f4287624c89f1e82f
        Date:   Fri Apr 30 22:01:24 2021 +0900
        
            update native-code.py with services for vba scripts in Calc
        
        Change-Id: I38c5e25cfdd24b0e9f2046795c5b2572c1eb880a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115155
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Noel Grandin  <noelgrandin@gmail.com>  [eff90f57b75c5aa0c18f0c87aa7bce36e414a68e]

        convert sal_uLong and tools::Long in vcl/settings
        
        Change-Id: I69711b791884218f4a14c85fe69072b9ea06dc79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115109
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [27cc1d10421777469c89cd1ec30229643b1a03ea]

        Add --enable-wasm-strip
        
        Will just set enable wasm strip for cross-target
        
        Change-Id: I0840b843794e4fab694df26608619a7bf06f5e5f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114981
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Thorsten Behrens  <thorsten.behrens@allotropia.de>  [d7e5d19e4617e41765db758778503501bfa8fdcf]

        WASM: add distro config, amend readme
        
        Let's move common configury to distro config, so people get
        necessary changes across updates w/o manual intervention.
        
        Change-Id: Ic27db86e7681bcef0632ed6b5fdd2fe8df0fdba3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114629
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [3dd7e77fa8b37ed85515bc64b8803d9ee1ee1fb5]

        WASM: add readme with build howto
        
        Change-Id: I2ce1787abfaa2cf6990d71e88de2d027b08f1489
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111129
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [f90c68316c622971706568303a025bbc58351df3]

        WASM: add Emscripten demo application
        
        Change-Id: I31297142761255b1f357fc9677a644b7a93c921a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111128
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [8a4173987edfeeb7e49c70617d43e3adc911d333]

        WASM: add initial support for Emscripten cross build
        
        - configure with:
        - --host=wasm64-local-emscripten
        - had to make a few externals optional, so adding:
          - --disable-nss
          - --disable-cmis
          - --disable-curl
        
        Change-Id: I48d1c73d2675ad2e2beaf2c341578199efbd24ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111130
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [013ddc4f5307df512767ca23b3922540b2b36d52]

        Switch OPENSSL config var from negative to positive
        
        - align with most of the rest of config_host
        - rename DISABLE_OPENSSL to ENABLE_OPENSSL
        - make this configurable
        
        Change-Id: Ic3b41fcdda38db66134939f12265e0da24833d60
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114564
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Jan-Marek Glogowski  <glogow@fbihome.de>  [983c41278899674028040c70c6e6415574b701f1]

        Run checks also on cross build toolchain
        
        - certainly those can break subtly too
        
        Change-Id: Iade2b8d78c1ffe43cfb260e4cdbe15adb4332765
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114563
        Tested-by: Jenkins
        Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>

2021-05-05  Luboš Luňák  <l.lunak@collabora.com>  [3a1d150eb99b5875e6e86117029a72e4c87b0547]

        scale stroked line properly in cairocanvas
        
        - Line width should be scaled by the scaled vector, not just its X
        component (see VclMetafileProcessor2D::getTransformedLineWidth()).
        - Lenths of dashes should not be scaled by the scaled line width,
        but by the scaling.
        Testcase document sd/qa/unit/data/pptx/tdf134053_dashdot.pptx .
        
        Change-Id: I4116f82e91620f5612f5e4e187468508f683b93e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115147
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [e859bf8c4da78698b820d13af1a2fdee3602f5b4]

        loplugin:constmethod
        
        Change-Id: I7913fd8144d521b8293ac43036d0fad82e457cd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115145
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [ae1d21ae69b0522cbbe67abeb2f5c5ba7ca2c33b]

        Update git submodules
        
        * Update translations from branch 'master'
          to dddf75c6f2e8840ed6966fa73989485db7c6b10b
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I5b89ae56a22a53d2975d3f3f34f7b854b5a0151a
            
2021-05-05  Michael Weghorn  <m.weghorn@posteo.de>  [70554d74a602c5cbeb5a3830898f644becf507ba]

        tdf#135136 Android: Don't hardcode height of TextViews
        
        Otherwise the text gets cut off when using a large
        system font size.
        
        Change-Id: I265d57ae310e39e9e452f6e744f17ed4807a00b2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115134
        Tested-by: Jenkins
        Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

2021-05-05  Gülşah Köse  <gulsah.kose@collabora.com>  [f61fcf6fe6b9f54dd57ca5d868b1b0436e9cec61]

        tdf#141424 Include the margin sizes while calculating width of window.
        
        Change-Id: I0863dc62f1ade6cc07835e83eb242f3d5a9906bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115068
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-05-05  Michael Stahl  <michael.stahl@allotropia.de>  [ed12269c42f75f553bb8a8770923406f7824e473]

        tdf#142080 sw: layout: fix infinite loop in CalcContent()
        
        On page 9, SwSectionFrame::Format() calls CalcContent() and that formats
        all its content frames, then on SwTextFrame 91
        SwObjectFormatter::FormatObj() fails becuase it moved forward.
        
        With commit c799de145f7e289f31e3669646e5bd12814e6c5e this now sets the
        o_rbPageHasFlysAnchoredBelowThis to true, which prevents a call to
        SwLayouter::InsertMovedFwdFrame(), and the flys anchored in next frames
        aren't moved off the page at this time.
        
        Then the loop starts over at the beginning of the SwSectionFrame, and
        frame 91 will be formatted again because the loop tries to format the
        first frame on the next page to see if it will move back; now the
        MoveBwd() isn't prevented any more so the result is the same failure
        in SwObjectFormatter::FormatObj().
        
        Fix this by ignoring the bRestartLayoutProcess in case the current frame
        was originally on the next page and didn't move back (or, as is the case
        here, moved back and then forward again); it should just be formatted
        again on the next page.  Once that happens, it will eventually be
        entered into SwLayouter::InsertMovedFwdFrame() too.
        
        This happens to fix another problem with this bugdoc too: the first
        column of the section on page 9 is empty.  This also happens in LO 6.4
        but not LO 6.1.
        
        An alternative would be to move the flys anchored below off the page as
        is done in SwLayAction::FormatContent() now but sections can be in flys
        or footnotes or headers so perhaps it should be done only at the
        top-level.
        
        (regression from c799de145f7e289f31e3669646e5bd12814e6c5e)
        
        Change-Id: I0965aebb4e3cec687f4e70f8d5e3aa8a55da3393
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115144
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-05  Xisco Fauli  <xiscofauli@libreoffice.org>  [c6d0986acb50941d30257cb497466066badfcaa1]

        tdf#141973: sc: Add UItest
        
        Change-Id: I06d8da1e2336a93cbd974b817afa21f830bd2ff7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115125
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [21f53f55f82f12fbee4e0d93ff26d3bb05ec3c55]

        Resolves: tdf#142049 expand widget to use unused extra space
        
        Change-Id: I7ff6aa4feeccd790b6176cb60b6adb9b21db0f63
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115135
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [4ff983b930dc15658aa531759d3f1e5b9586aeab]

        Related: tdf#142049 restore some elements default visibility in the ui
        
        these defaulted to not visible before...
        
        commit ec548bce309d965a25e807ae79432114926e06f3
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Mon Oct 15 11:14:02 2018 +0100
        
            weld ChartTypeDialog and SchLayoutTabPage
        
            Change-Id: I101c56b855d0bdc43559ca4561d298fa4ad92572
            Reviewed-on: https://gerrit.libreoffice.org/61797
        
        Change-Id: I424368e108726376140a0e83e085fe5ab01c497f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115129
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Mark Hung  <marklh9@gmail.com>  [6c9948d80aaa1d4827ccf741d900093abe7a973e]

        vcl: adjust cairo text renderer for vertical writing
        
        , remove extra matrix translation and use the positions
        from Harfbuzz more directly.
        
        Change-Id: I2eb337b7f3bd70f4726f56d85a38f4a1f0931155
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115018
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-05  Mark Hung  <marklh9@gmail.com>  [dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481]

        vcl: adjust LayoutText() for vertical writing.
        
        Revert 58af692e2814 "tdf#111967 translate offsets
        so it is relative to vorigin", which use
        hb_font_add_glyph_origin_for_direction to change
        the origin for vertical writing. This caused major
        problem in Y-axis.
        
        For X-axis, align the baseline of the vertical run
        to the center of the rotated horizontal run,
        by adding "(ascender + descener) / 2.
        
        Besides the alignment mentioned above, underlying text
        rendering code should be able to render properly based
        on the positions that Harfbuzz API creates.
        
        Change-Id: Ic1ef1f734686d0e61c4b2a6bf7feb7c870bba84f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115014
        Tested-by: Jenkins
        Reviewed-by: Mark Hung <marklh9@gmail.com>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [bb9a3f1cd2912b836deb9f73c2010bf03a1438c9]

        factor in treeview borders for get_height_rows
        
        as seen in tdf#142049 for format chart type where the scrollbar
        appears in gen when that's something it tries to avoid
        
        Change-Id: I494114078603797b0450363816823e5898a3ef01
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115141
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [122ceeff4c8d04bedb3fc4c9dd811c6005ee5104]

        factor in borders regardless of WB_BORDER
        
        Change-Id: If6321b3c903212b6b1b68c028a2c5aa4f9a59a3a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115140
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [0f7a09cda38c08d79ef94dcadcb83e038dbebcb1]

        the border size SvTreeListBox uses is not StyleSettings::GetBorderSize
        
        so use the actual border sizes in use
        
        Change-Id: If6d1032936565c199332522a31a1bc984f126547
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115139
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Stephan Bergmann  <sbergman@redhat.com>  [1f3dddd6f21d91c429190ae314dadeec409f35f4]

        Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams"
        
        <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=aa475c4ac80733f85ba47b109fc1900f05e810e2>
        towards GCC 12, so that now "the return type is the original rvalue stream type
        not its base class."  (And which would thus have caused issues like
        
        > sfx2/source/control/bindings.cxx:1323:19: error: dynamic_cast from rvalue to reference type '::std::ostringstream &' (aka 'basic_ostringstream<char> &')
        >                 ? SAL_STREAM("File: " << pFile << " Line: " << nLine) : ""));
        >                 ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > include/sal/log.hxx:198:6: note: expanded from macro 'SAL_STREAM'
        >     (dynamic_cast< ::std::ostringstream & >(::std::ostringstream() << stream).str())
        >      ^
        > include/sal/log.hxx:341:20: note: expanded from macro 'SAL_INFO'
        >         SAL_WHERE, stream)
        >         ~~~~~~~~~~~^~~~~~~
        > include/sal/log.hxx:155:68: note: expanded from macro 'SAL_DETAIL_LOG_STREAM'
        >                 SAL_DETAIL_LOG_STREAM_PRIVATE_(level, area, where, stream); \
        >                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
        > include/sal/log.hxx:133:45: note: expanded from macro 'SAL_DETAIL_LOG_STREAM_PRIVATE_'
        >             ::sal::detail::StreamStart() << stream) == 1) \
        >                                             ^~~~~~
        
        now.  While the issue with old libstdc++ that originally prompted the
        dynamic_cast was
        
        > sfx2/source/control/bindings.cxx:1323:19: error: no member named 'str' in 'std::basic_ostream<char>'
        >                 ? SAL_STREAM("File: " << pFile << " Line: " << nLine) : ""));
        >                 ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        > include/sal/log.hxx:194:40: note: expanded from macro 'SAL_STREAM'
        >     (::std::ostringstream() << stream).str()
        >                                        ^
        > include/sal/log.hxx:336:20: note: expanded from macro 'SAL_INFO'
        >         SAL_WHERE, stream)
        >         ~~~~~~~~~~~^~~~~~~
        > include/sal/log.hxx:155:68: note: expanded from macro 'SAL_DETAIL_LOG_STREAM'
        >                 SAL_DETAIL_LOG_STREAM_PRIVATE_(level, area, where, stream); \
        >                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
        > include/sal/log.hxx:133:45: note: expanded from macro 'SAL_DETAIL_LOG_STREAM_PRIVATE_'
        >             ::sal::detail::StreamStart() << stream) == 1) \
        >                                             ^~~~~~
        
        .)
        
        The libstdc++ macro _GLIBCXX_RELEASE is reportedly available since GCC 7.1.
        
        Change-Id: I1ee6eabb66355c1f28b9d305cbd85bac50d6b0e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115121
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-05  Mike Kaganski  <mike.kaganski@collabora.com>  [7b506496fdff341d2288fa36bd4300a92cf979a9]

        Don't initialize variables only to reset later
        
        Change-Id: I38d618216099e218827d205e8acaab3aef0c744c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115082
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-05  László Németh  <nemeth@numbertext.org>  [134fb0fdecb898b1568f57e8c9dc8c3528b0d1e0]

        tdf#141935 svx cui: apply line cap setting of line styles
        
        Only line dash pattern of the selected line style
        was applied on the selected line or shape using the
        1) Line Style popup menu of Drawing toolbar and
        sidebar pane Properties and 2) Style popup menu
        of Line pane of Line setting dialog window.
        
        Now both line dash and line cap settings are applied,
        supporting the usage of the new "rounded" preset
        styles and the old not "rounded" versions.
        
        Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac
        "tdf#141933 add preset dash styles with round cap".
        
        Change-Id: Ib3f64afcdcb50545166d40476a03a4b45f7d0b8a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114461
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-05  László Németh  <nemeth@numbertext.org>  [b8c5236b444a9fbb1d419b95faf2ab2a71913efe]

        tdf#141934 svx dialog: fix missing dots in line style preview
        
        Line styles with dot-like dots (e.g the new
        "rounded" preset line styles) got bad preview
        with missing dots in the line style popup menus.
        
        Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac
        "tdf#141933 add preset dash styles with round cap".
        
        Change-Id: I0d18feb2772a47588b41dea2138cdcb14332c8b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114460
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-05  László Németh  <nemeth@numbertext.org>  [b9b2c6a98fec798fc0ec76ec3cd407724f19dcac]

        tdf#141933 add preset dash styles with round cap
        
        New OOXML-compatible preset styles weren't recognized
        on the UI, including the Drawing Object Properties
        toolbar and Line Style settings, if the preset styles
        use round cap, e.g. line styles with dot-like dots (i.e.
        not tiny squares as dots).
        
        As a workaround for interoperability and access to
        the line styles with dot-like dots, add "Rounded"
        version for every OOXML-compatible preset styles with
        round cap. This allows to apply dot-like dotted lines
        to new shapes, too.
        
        Background: round cap modifies the DotLen and DashLen
        values of the LineDash struct during the OOXML import,
        using ~zero values to get dot-like dots. For the details,
        see commit 3f3b50015e4fd9efc3459612a70409fca49cf390
        "tdf#134053 tweak dash and space length for ooxml" and
        commit 24d770799660d3ec94ee7add435645794426042b
        "tdf#134128 Use Gdiplus::DashCapRound for round dash or dot".
        
        Follow of commit 183c06fc02a50fb117bb6162e4d6e56cdd34fad1
        "tdf#139301 fix OOXML-compatible preset dash styles".
        
        Change-Id: I4f3173579964b2c00618ada475b012c85320f758
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114459
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-05  Miklos Vajna  <vmiklos@collabora.com>  [92cba30d5ce45e4f4a9516a80c9fe9915add6905]

        vcl pdfium render: handle widget annotations for form fields
        
        Note that we render the bitmaps without FPDF_ANNOT, so comments are not
        rendered into the bitmaps, rather we create them on top of the bitmaps
        in Draw, explicitly.
        
        FPDF_FFLDraw() draws content which is already an annotation, but not yet
        interactive content; so this just fixes "missing text", as far as the
        user is concerned.
        
        Verified that e.g. vcl/qa/cppunit/data/PangramAcrobatAnnotations.pdf
        indeed still doesn't render comments into bitmaps after this.
        
        Change-Id: I2b74d585729305cc1d3a9fefa258d4d76d1bd038
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115122
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [17bf458c86a9130cc56fad035f81558fd91ed974]

        inline SdrModel::ImpCtor
        
        since it is only called from one spot
        
        Change-Id: Ib94bc364c57ed0d36dc99f56f026cd44f27258ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115123
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Bartosz Kosiorek  <gang65@poczta.onet.pl>  [24e71494d7d1a68b2cb5f5d34083ab02009e0982]

        tdf#55058 tdf#141982 EMF: Add rotation and path support for RECTANGLE record
        
        Previous implementation of EMR_RECTANGLE, doesn't support rotation
        and EMR_RECTANGLE was not work with EMR_BEGINPATH, EMR_ENDPATH and EMR_ABORTPATH
        
        The EMR_BEGINPATH opens path bracket construction.
        
        Once path bracket construction is open, an application can begin specifying records to
        define the points that lie in the path. Path bracket construction MUST be closed by an
        EMR_ABORTPATH or EMR_ENDPATH record.
        
        With this patch all these issue was resolved for EMR_RECTANGLE
        Change-Id: Ic51442df8905e47c92eed811cc776762c9752af2
        
        Change-Id: I111f183e509f03c0b276a038680f61156b37b235
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115065
        Tested-by: Jenkins
        Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
        Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-05  Noel Grandin  <noelgrandin@gmail.com>  [c0771af1b35269b58b35df52004604b20971c6ae]

        sal_uLong->Color in BitmapDuoToneFilter
        
        Change-Id: I3f57d9b21d439fa8449579d9cdaac9377ac80934
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115110
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Caolán McNamara  <caolanm@redhat.com>  [75b3cf4ee12f9552e47b1f4ce87a642a4a3d7d25]

        rhbz#1956977 crash on switch from active comment to slide sorter
        
        Change-Id: I2b5a5cb8b0631971b775a70d96f2cbf0c118c090
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115115
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-05  Noel Grandin  <noelgrandin@gmail.com>  [1a99b4e44190e182d56a04678850d62635d74c65]

        sal_uLong->sal_Int32 in BitmapMosaicFilter
        
        Change-Id: Iefef4deb6a9b6e1ca1c111dd4b1f294129a505f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115111
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Noel Grandin  <noel.grandin@collabora.co.uk>  [7c4a4652595d6e738bcc5a38060cc1754ab35520]

        don't leak editengine pool on shutdown
        
        Change-Id: I585953c26ed40acc51853b9ed5cd398b84472056
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115099
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Noel Grandin  <noelgrandin@gmail.com>  [53e720708b9d027a7df9908c75b1b82c8aca3c6a]

        sal_uLong->sal_Int32 in Bitmap
        
        Change-Id: I267fbdb8946d307440cb675f6ff985bf58db5e4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115108
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-05  Miklos Vajna  <vmiklos@collabora.com>  [c01e7f199bf0ed8e01f596034df79c5c16df69e5]

        Introduce SwPageFrameInvFlags to replace magic numbers in ...
        
        ... SwPageFrame::SwClientNotify()
        
        SwPageFrame::UpdateAttr_() is not yet updated to produce these.
        
        Change-Id: Id45162b11ca9bf60f0f0ae43fc22cc2086e0fd67
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115114
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-05  Jim Raykowski  <raykowj@gmail.com>  [b43ab86df783c7816deb5810d89d52e2c3a93b5a]

        tdf#140969 Select in Navigator all document selected drawing objects
        
        when in Drawing objects content navigation view
        
        Change-Id: If5d78453f36f035a93936490ab8c2cd4223f1feb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114811
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-05-05  dante  <dante19031999@gmail.com>  [36f35bd823ef9af454f1d4609ad302acbef0709b]

        Use kahan Sum for ArraySumFunctor
        
        Change-Id: I2f00d3c4c04f1c65083137d36772728a1eae0bed
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115112
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [ef78c7d93e4f170ac7a7f0307a8305052524eb53]

        restore focus to the GtkEntry of GtkComboBoxText on menu popdown
        
        the font size/name dropdowns in the document toolbar should continue
        to restore focus to the document directly while typical ones should
        vcl-alike select the GtkEntry contents
        
        Change-Id: Ic6c6cd48362dac6e4476c42a4070a83cd50faa2b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115104
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  dante  <dante19031999@gmail.com>  [94977bb43d8dc91023bee7afa037f6319c36ccc3]

        tdf#137679 Use kahan summation for ScInterpreter::lcl_IterateInverse
        
        Change-Id: I02e108ac70ddd4ea8d8d97eb4f5fbc8996dd4bd1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114966
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-04  Mike Kaganski  <mike.kaganski@collabora.com>  [a9f46b72df15c3540044a4441b926a1de9df5d2f]

        Unify some code managing coordinated depending on text direction
        
        Change-Id: I12163e83a6a4d4e7cb85eed690b787c47ee2e7e5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115107
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [f5f5d7476885fe6107cb9f39504078e833bfb27d]

        messing with UNOMINMAX no longer seems to be necessary
        
        and it sometimes causes trouble when including o3tl/strong_int.hxx
        
        Change-Id: I2957dc5c0159e1a9ab61681953023f6850de0125
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115098
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Noel Grandin  <noelgrandin@gmail.com>  [e20254da3bf67d298b262066ea9c8bb376623ca1]

        sal_uLong->sal_Int64 in Bitmap
        
        Change-Id: Ia9796cca66f405c38545a5ba3aab7c76a465a0d7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115106
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [5812fb81013cc124a9b6a0b9912a34cc715fc495]

        tdf#138782 DOCX import: fix frame positions of old docs
        
        by limiting AddFrameOffsets compatibility option
        for docs created by MSO 2010 or older.
        
        Likely regression from commit 355d25eac764713f4d52eac801ade6e2ff1deab0
        (n#779627: added quite some compat options from the ww8
        filter on writerfilter).
        
        This patch fixes several bugs, which were
        collected as duplicates by Gábor Kelemen.
        
        Change-Id: I106e90c4bf00bb0b6a8986615cb3ad9c4828d5b3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114476
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [88e6a1bfeac86e0c89d2ff08c908c2b5ae061177]

        tdf#69635 DOCX: export hidden (shared) headers/footers
        
        Exporting to .docx used to lose all header and footer
        content that was not visible in the document at the
        moment of saving. This commit forces the DocxExport
        class to output all headers and footers even when
        the "Same content on left and right pages" option
        is turned on.
        
        Change-Id: I6a52f216f1e1b386d887ec614198766670b5bce3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113158
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Michael Stahl  <michael.stahl@allotropia.de>  [30512746c182b52f37f9a818d4e206c98e715cb7]

        tdf#141945 sw: layout: check master frame when moving fly forward
        
        The problem is that in the finished layout the fly frames are
        positioned on the first page but are in SwPageFrame::m_pSortedObjs
        of the second page.
        
        Don't use FindPageFrameOfAnchor() because that looks up the follow-frame
        that contains the anchor position.  This was unintentional; the idea
        was to get flys anchored in subsequent paragraphs out of the way.
        
        This situation where it's on a follow-frame of the same paragraph is
        more complicated and less obvious, so don't try to solve it now.
        
        (regression from eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf)
        
        Change-Id: Ic6809a43c467955368807ccc82a7873c29fbfc2e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115100
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ade38b97f8c22061b612bac81f5dcd3cfb83547]

        tdf#141613: sw_uiwriter3: fix unittest
        
        The original test added in sw/qa/uitest/writer_tests7/tdf46561.py
        doesn't fail without the fix in place.
        While at it, move the UItest to CppUnittest
        
        Change-Id: I254c4ed042b14adee8c702d4c047572e69040887
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115103
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-04  Tibor Nagy  <nagy.tibor2@nisz.hu>  [3a24211a1d49f33ca52e4fb2c927d50304f005df]

        tdf#54037 PPTX export: fix internal hyperlinks
        
        exported as external by accident: after reloading the bad
        export, clicking on the hyperlink opened the same file
        in another document, because the exported link contained
        also the full file name reference instead of the slide name,
        according to the OOXML Relationship TargetMode="External".
        
        Change-Id: I08cf1537cd307b0b6f51ba1c3f61d89e220d44fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114891
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Tibor Nagy  <nagy.tibor2@nisz.hu>  [cfa672013a1a75ff53993084ae5e69fcd985d010]

        tdf#103347 PPTX import: fix duplicated slide name
        
        PPTX import uses title text as slide names, but this resulted
        duplicated slide names in the case of repeating title
        text, which forbidden by UNO API:
        
        == GenericDrawPage.idl ==
        
            /** Gets or sets the name of this page.
        
                <p>Duplicated page names inside a document are not allowed.
             */
            [optional] interface com::sun::star::container::XNamed;
        
        Now the import code skips the duplicated title text,
        resulting default numbered slide names instead of the
        duplicated title names.
        
        Note: it seems, this hasn't fixed the jumping slide selection,
        e.g. sometimes pressing Shift-F5 still presents the first slide
        instead of the actual one.
        
        Change-Id: I98511c3c9a59598ea113e7387db5202d7f8a7cd4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114810
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [84b4bca314ded015911ab986e8f999518616b248]

        Resolves: tdf#141857 update background to current theme
        
        Change-Id: I1004bd9944f382ca66e48575b81170cf3314845f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115092
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [c43398c2a455d32660650bbf876099d0b8554b68]

        Add proposal link
        
        Change-Id: I7887a3ac088c21e93ee9b7214827c71b52a321c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115094
        Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-04  Jean-Pierre Ledure  <jp@ledure.be>  [f38c39534ffc9f33bfa4a588624c35b662b55b62]

        ScriptForge - (SF_TextStream)FIX raise error when end-of-file
        
        Error was announced with a message box.
        Error message was not translatable.
        
        Managed with standard exception handling.
        
        Change-Id: I10d67985ec4bdebce5bda9123caddb4134646b48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115095
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-04  Noel Grandin  <noel@peralex.com>  [30312222e5f7de5ebbabbf8ad33e373a53385971]

        speed up saving large ODS a little
        
        by looping over the sections only once, and
        moving the vector containing the borders outside
        the loop.
        
        Change-Id: Icf68ced94aa45a4737fb7d5a3fe076ab2931034e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115059
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [8db72947d7bd6eda08b95a13b63a5f0503564639]

        Related: tdf#141857 send style-updated after app settings are updated
        
        so the libreoffice settings are updated before the widget updates,
        otherwise the app settings are the old settings when the widget updates
        
        Change-Id: Id32dd55a1e5102cc707d6ee74eddfae2247e105a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115070
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Daniel Arato (NISZ)  <arato.daniel@nisz.hu>  [65e52cb61d74b0c71b45b63b2da131bc6b621104]

        tdf#141613 sw: fix crash at header/footer undo
        
        Undoing the creation of a header/footer used to leave their
        corresponding document nodes intact, causing the node index
        of a previous undo entry to point to the wrong node.
        
        We now force the destruction of the header/footer nodes manually.
        We also cut the redo chain which loses the redo history, but solves
        another crash for now (when redoing the creation of the header).
        
        The proper solution would be to create a new SwUndo* derived class
        from scratch to represent the creation of a new header/footer section
        in the document.
        
        Regression from commit 8d8486f43c1a8a51157bfc3e0b87090b05a9229e
        (tdf#46561 sw: fix lost undo stack setting header/footer)
        
        Change-Id: I97188aa8ded802bc6b6fa88ddd83a95c40de8bc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114667
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Mike Kaganski  <mike.kaganski@collabora.com>  [7f0b5f8eb234d2e1cc40055b275799df503ea736]

        Use sal::systools::COMReference and drop dxcanvas::COMReference
        
        Change-Id: I352147dd86d8ba73da1706c42c885bef0f11b2cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115071
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-04  Katarina Behrens  <bubli@bubli.org>  [c46a231b987b92bd866b415d1a0ba0d3a26a2457]

        tdf#139329: Shift widgets down and make hatch&bitmap list visible
        
        regression from commit cbe86ee37018dc4bf04783ecf70fef2863e61ad7
        which inserted additional gradient colour picker but didn't
        adjust the positions of widgets below accordingly so in effect
        there were 2 widgets at position y=4
        
        Sad that neither glade nor our own code detects this condition and
        e.g. asserts or warns this is the case
        
        Change-Id: I4c635eeb8b740765542631a5f0319bfe1a5d94d0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115056
        Tested-by: Jenkins
        Reviewed-by: Katarina Behrens <bubli@bubli.org>

2021-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [7f1315ca929c0c8e888e5d1fb7987ba7d7ce395a]

        uitest: sd: simplify code
        
        Change-Id: If4a3b1d5613e239a967b70309779dbdb6632e6ae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115067
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-04  dante  <dante19031999@gmail.com>  [021ec9bb9ffa6ae8fbb73c2f6ea4bc0b8df9ddef]

        Algebraic simplification
        
        Change-Id: I695419778e378eb4bd0eac70930b41d6e668033c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115066
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [dc4b4137520645495d1a7ead9744f515f53e5c84]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to ff83d0de608e66bcb5d5023c65a50e0e2b2cbf2b
          - Add suggestion from translator
            
            Change-Id: Ieb06c42eafcab9b1c6e1d1e02ae1ccc3fe118773
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115051
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [a4157dbee1adbf8e05696cbaeb6d1ccb97bb0697]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c47162423fc56e3de60e9f5bb3390be8113e7664
          - Improve wording on database tables
            
            Change-Id: Icd72638445d9da7c50370e70fabfe2f0ad52a061
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115050
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-04  Olivier Hallot  <olivier.hallot@libreoffice.org>  [c4207f50996dc9461936478616bd18f21d75f189]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c58bc852cc03d5f4ec6cd0caf08370b443956dee
          - Fix syntax description for COUNTIFS
            
            Change-Id: I6ff42f1d64da095c2d4db96339be3ba62a23064d
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114927
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [da55e2a11376da54be3159742e3c11018b3250bc]

        tdf#142017 set default focus widget
        
        Change-Id: I5befe345d9c6ec499efdc1cf8305513ee8a53690
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115062
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [35f03f26799747894d1534796b6cb227bd4f233b]

        speed up loading large ODS a little
        
        by flattening the ParaPortionList, which reduces allocations
        
        Change-Id: I7b350335e336f92bb048905c2b2f06378c8a3423
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115061
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [e2bdd31c0231444f1ba1463bffb5656c230c3073]

        tdf#76258 Add ODF import/export
        
        XML looks like:
        <table:filter-condition table:field-number="0" loext:data-type="background-color" table:value="#ffd7d7" table:operator="="/>
        <table:filter-condition table:field-number="1" loext:data-type="text-color" table:value="#3465a4" table:operator="="/>
        
        Change-Id: Idcddf0ce436da69567e5a7e9dfd7d796dc872586
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114812
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-04  Noel Grandin  <noel.grandin@collabora.co.uk>  [e23436d347bb44a720932a2e7badc56147f5b167]

        speed up loading large ODS a little
        
        by flattening the XEditAttribute list, which reduces memory allocations
        
        Change-Id: Iae913a6aac3e438ea1e00f19556f6a75713cd4fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115060
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [9fed7b07af44792012028eb57900640a5ee833cb]

        tdf#141930 document set as unmodified if editengine didn't modify on keyevent
        
        this appears to have always happened for cursor keys, and since
        
        commit 0154f04e8c64df937b793c73ac58d553637f324f
        Author: Caolán McNamara <caolanm@redhat.com>
        Date:   Wed Feb 24 14:32:21 2021 +0000
        
            Resolves: rhbz#1931423 start update timer in IM events as well as keyevents
        
        also happens on Input Engine events which don't cause changes
        
        Change-Id: Ic5cdd9ef4f1bed1cc2b2c17fc847f196a9c6e23a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115055
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [7b7d280912f90149ba5512c13b9132cf524974e4]

        tdf#141202 Set "Ctrl+Alt+=" as the default shortcut to insert Math objects
        
        Change-Id: I8a0dcfcac1f7e6d5d5efdec8091dadf3b3c098c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112962
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-04  Ayhan Yalçınsoy  <ayhanyalcinsoy@pisilinux.org>  [1cf47d932580a58a7855fe29ac39d17cdd79ae01]

        tdf#140296: Added Edit Fields(context menu) inside of tables
        
        Change-Id: I22b6a179c1575171315d9eb40cd4895c35d77b6f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114986
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-04  dante  <dante19031999@gmail.com>  [862cd47d230e40ed7d1581a0db57f8db479dff8b]

        Compress code in interpr2
        
        Write some parts of the code in a more compact syntax.
        Prioritize cmath over mathm.h .
        
        Change-Id: I22e9afb819ab1a396cd7db575cc12dc03b3de473
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114741
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Ayhan Yalçınsoy  <ayhanyalcinsoy@pisilinux.org>  [42db696496c8e95ee7489d2800bd6a5400391959]

        tdf#139713:Renamed Footnote/endnote settings dialog caption
        
        Change-Id: Iacaf7637e53fbbfe9dd683c8991b543ba3763d33
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114985
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [61dbc8791b8d3afa524bfe89ebc99eca3a5c2030]

        cid#1478174 Uninitialized scalar field
        
        Change-Id: Ib17e55b600012ef5f6a26d01e9d54aa7be9c590d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115052
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Rafael Lima  <rafael.palma.lima@gmail.com>  [61b652a1ebe72986d606b68b32387ccf0594d5c4]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 1cffc3bf789fa475b7fd41724bba5f2ba03d9e36
          - Fix <literal> tag in sf_formcontrol Help file
            
            Change-Id: I7c59c9925a869244dc223d4088176ef73be49c85
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114926
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-05-04  Balazs Varga  <balazs.varga991@gmail.com>  [d5c2584bf36d21580db677b231c57f99f49aa2cb]

        Related: tdf#140968 avoid duplicated filter values
        
        Group and filter based on the actual cell format,
        like MSO does, to simplify filtering of values rounded by
        the cell format (e.g. selecting the single AutoFilter condition
        "1.0" to filter both 1.01 and 0.99).
        
        Followed up of 4fd1333ba4bb4f2311e9098291154772bd310429
        (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters)
        
        tdf#141916: odf export: Indicating the formatted filter values,
        by export the XML_DATA_TYPE with XML_TEXT, to avoid bad filtering
        of formatted filter values.
        
        tdf#141775: fix regression of 4fd1333ba4bb4f2311e9098291154772bd310429
        (tdf#140968 tdf#140978 XLSX import: fix lost rounded filters)
        
        tdf#141915: fix OOXML import of 0.0 filter values of filter conditions
        by setting it byValue filtering in datauno.cxx.
        
        Change-Id: I1c840249ee1ef95aff33a4740b8bf2ebc47f2325
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113314
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-05-04  Caolán McNamara  <caolanm@redhat.com>  [d78f9b5cca2415c0d3bc4d081dec19a0ce976cb7]

        final 'next incompatible build' TODO
        
        from
        
        commit 22ff1aff328874d0d42875552f9a3d2db37b83fb
        Date:   Thu Sep 9 14:12:47 2004 +0000
        
            INTEGRATION: CWS toolbars2 (1.47.22); FILE MERGED
            2004/08/24 13:53:25 ssa 1.47.22.2: #i32185# prepare removal of useless interface
        
        just mark as deprecated in the .idl and leave the stubs alone
        
        Change-Id: I0c0c4dccccb1b35add82306870519e2e94c044d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115010
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-04  Miklos Vajna  <vmiklos@collabora.com>  [ece86ef173cbc070c76f180d02ac80c65e07fff9]

        tdf#139500 svx: fix crash on changing table properties during active text edit
        
        Regression from commit fdeb04f7c59cf8032fe17072ed779e70505cc6ab
        (tdf#129961 svx: finish UI for table shadow as direct format,
        2020-12-15), the problem was that the BegUndo() / EndUndo() pair can be
        only used if we know that the text edit of a cell of a table shape is
        not started or ended in-between.
        
        The bugreport scenario was an active text edit, where setting attributes
        on the shape ends the text edit:
        
            #9 0x7f6dbb417121 in SdrEditView::EndTextEditAllViews() const /svx/source/svdraw/svdedtv.cxx:1079:20
            #10 0x7f6dbb466798 in SdrEditView::SetAttrToMarked(SfxItemSet const&, bool) /svx/source/svdraw/svdedtv1.cxx:1095:9
            #11 0x7f6dbc34b0af in sdr::table::SvxTableController::SetAttrToSelectedShape(SfxItemSet const&) /svx/source/table/tablecontroller.cxx:2738:12
        
        Which also means that the underlying edit engine is deleted. But then
        undo/redo would still reference that edit engine:
        
        ==31830==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0001fc300 at pc 0x7f6dd73a9cb9 bp 0x7fff788db4b0 sp 0x7fff788db4a8
        READ of size 8 at 0x60c0001fc300 thread T0
            #0 0x7f6dd73a9cb8 in EditUndo::GetComment() const /editeng/source/editeng/editundo.cxx:147:34
        
        Fix the problem by not grouping in case there is an active text edit,
        that's not something I considered when I added the original grouping.
        
        Change-Id: I4f3583e21a27f8380c35b3f4563ce496819bcb81
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115049
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-04  Noel Grandin  <noelgrandin@gmail.com>  [5c6db303f5b7692c8e0e4bed5fa42a1303b71e7c]

        sal_uLong->sal_Int32 in PointerState
        
        Change-Id: I5b3ea673d1b89d6584ad4e4cc5ada927791eeb29
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115048
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-04  Stephan Bergmann  <sbergman@redhat.com>  [564ba9278189607b228e6545b8bbcb64eeba85ce]

        loplugin:redundantstatic
        
        Change-Id: I933a51e9107d8f7dff5eeb03f9aba14dff534574
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115046
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-04  Stephan Bergmann  <sbergman@redhat.com>  [04fce09a82dd2c2371dc6a203fd310ac04a8ebb7]

        loplugin:finalprotected
        
        Change-Id: I57e70a5a6432f721952d412e14270ae22b4d7a4c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115045
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-04  Stephan Bergmann  <sbergman@redhat.com>  [0d913b281d3b59b7411b2bd0d348be2d15539569]

        loplugin:noexcept (macOS)
        
        Change-Id: Ib8951e9590d70ffecf8fd6af3070ef9c6d4ae151
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115044
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-04  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [40b833351e4ffd7608ac82e79e21d189de2171ff]

        svgio: instead of assert(false && ...) rather use SAL_WARN instead
        
        Previously OSL_ENSURE was changed to assert(false && ...) which
        wasn't a good idea as now we hit asserts in some cases, so rather
        than that, use SAL_WARN instead.
        
        Change-Id: I69740d71ae97a79ece56d77c3dd7d0ce83c9bb34
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115040
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-04  Pranam Lashkari  <lpranam@collabora.com>  [931e264590100c555580c413556e229a0f03316a]

        LOK: calc: allow image selection on insertion
        
        in calc online, image was not selected by default when inserted
        
        problems:
        it was inconsistent with writer and impress/draw
        it caused problem in cypress testing
        
        Change-Id: Ic18b7a918c485a1cd384694d72fbb0a598d26ba2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114922
        Tested-by: Jenkins
        Reviewed-by: Pranam Lashkari <lpranam@collabora.com>

2021-05-04  Xisco Fauli  <xiscofauli@libreoffice.org>  [4ee58a0dedc5160551260793e5fed9e6c3842976]

        tdf#60468, tdf#142040: sc: Add UItest
        
        Change-Id: I44eb029087708d85fa1f3712cd40bebb6174c58e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115034
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-03  dante  <dante19031999@gmail.com>  [45b952f64755a1ae34a8bb432b4909c5b91da474]

        Prioritize cmath over math.h in interpr3.cxx
        
        Change-Id: Ifdc50beed9d1b2bae8cd4f512183912366eb4604
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114967
        Tested-by: Jenkins
        Reviewed-by: Eike Rathke <erack@redhat.com>

2021-05-03  Caolán McNamara  <caolanm@redhat.com>  [2de0eaf467715662e68b9429c9d5050f65ffcec9]

        There's no longer a purpose to the math horizontal scrollbar
        
        since...
        
        commit f89860807baaa901629ce2a814b7a6c994318fe5
        Date:   Sat Feb 13 16:43:01 2021 +0100
        
            Resolves tdf#140221 auto-adjust Formula Editor width
        
        so remove that.
        
        And merge the starmath Resize logic into the baseclass, and emit
        EditViewScrollStateChange from there.
        
        The goal is that resizing the starmath window does not visually
        horizontally scroll content negatively outside the widget
        
        Change-Id: I1a79a0d5a194e8cfb0d2d2cb07b0b80172f1f66c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115012
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-03  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9b1b29325ba988e5307a34d234cf6ba17e4350ec]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c5a46fef4b734a0f3a9754d0e158fd322db44ff6
          - Fix Typo
            
            Change-Id: Ia9ede74f44fb9bc500916c7bbd2a66e51b7685d5
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114923
            Tested-by: Jenkins
            Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [6ba33f724986752ceffa27b4928d140a4b948ca7]

        tdf#48731: sc_subsequent_filters: Add unittest
        
        Change-Id: I8d3804d78f6005a594937fbdc92fa99dae70a3f8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115043
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-03  Eike Rathke  <erack@redhat.com>  [9a71644aa475a6090f60a8b90665116b98851b9c]

        RAWSUBTRACT() process arguments from left to right
        
        RAWSUBTRACT(1;2;3;4) calculated 1-4-3-2, popping from stack.
        Reverse stack to calculate 1-2-3-4 in "natural" left to right
        order.
        
        That may make a difference like in
        
          =RAWSUBTRACT(0.3;0.2;0.1;-0.1;-0.2;0.3)
        
        where the result was 2.77555756156289E-17
        (0.3-0.3--0.2--0.1-0.1-0.2) == (0.0--0.2--0.1-0.1-0.2)
        same as =RAWSUBTRACT(0;0.2;0.1;-0.1;-0.2)
        
        and now is 0
        (0.3-0.2-0.1--0.1--0.2-0.3)
        
        but =RAWSUBTRACT(0;0.2;0.1;-0.1;-0.2)
        now is -2.77555756156289E-17
        
        Change-Id: If00d88e3d3d1944a3d9a6b4576b773afe9cbd294
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115047
        Reviewed-by: Eike Rathke <erack@redhat.com>
        Tested-by: Jenkins

2021-05-03  Mike Kaganski  <mike.kaganski@collabora.com>  [dff586735b6618d9b011823594a33287d8f7f223]

        tdf#123476: also use filter by extension when its service is the same
        
        ... as passed explicitly in the media descriptor, for 0-byte files.
        This makes proper handling for such files when passing module name
        in command line, like --writer for DOCX.
        
        Change-Id: If8fd51e65dcf8a67b2653026f5fc1d5c964074af
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114924
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-03  Xisco Fauli  <xiscofauli@libreoffice.org>  [9f89ee7c5076f700589d3b07f3d6a50f9af7d13a]

        tdf#80149: sc_subsequent_export: Add unittest
        
        Change-Id: Ic4a8f50a398a2a87e6850c80dbb9ed7eb70eca68
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115041
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-05-03  Olivier Hallot  <olivier.hallot@libreoffice.org>  [1d2ff6b86bd404a7a9ca3ae22709a79b2edb1d4c]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to f8bb58500148b126c2730977d566e7fa315439b0
          - Refactor more database help files
            
            Change-Id: I1384c2d3d0090ce15fc5088bff4bfdb07fa7cdbf
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114995
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-05-03  Jean-Pierre Ledure  <jp@ledure.be>  [cec00cd70aa3899244106fcb3958b19c88e6db98]

        ScriptForge - (scriptforge.py) Fix dates transfer Basic <-> Python
        
        Strings in CSV file recognized as dates are passed via
        their ISO format, not in the default com.sun.star.util.DateTime
        format. This required a fix in Basic ImportFromCSVFile().
        
        Errors in user scripts can be announced to users from Python
        with the same interface as from Basic: SF_Exception.RaiseFatal().
        Error messages become translatable.
        
        Used by SF_Exception.PythonShell(), display of APSO console,
        when the APSO extension is not present.
        Addition of the PYTHONSHELL error message in the po files.
        
        Review of typos.
        
        Change-Id: I52a19faa3773904bd37505fee780d517436485f2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115032
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [c5a0b7af847a71fd50f713934b29305f8ce96c6b]

        loplugin:stringadd improvement for appending numbers
        
        I was wrong, the Concat framework already optimised appending
        numbers by stack-allocating small buffers, so include
        them in the plugin
        
        Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Chris Sherlock  <chris.sherlock79@gmail.com>  [d19dbcc139d18771e5e20e82a694f1512476e41c]

        vcl: remove MetricVector
        
        Change-Id: Ib700887ca79f423c65dfb75eea36bbfd808fa172
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114976
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-03  Chris Sherlock  <chris.sherlock79@gmail.com>  [8c756af15e967fca3b6cc08be9a57f6d249a27b7]

        vcl: move SalLayoutFlags to own header
        
        Change-Id: Ia1cefb6e0759404cb63cf1ccf6190931047bac79
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114973
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [7cc1d3437a48140382773bf41401a46a3ced4706]

        loplugin:unnecessaryparen small improvement
        
        when calling a function, and passing only one arg, but the
        function has defaulted args, we were ignoring this case.
        
        Change-Id: I86517f18e30531127664088ddc09ef96dbd8bdf5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115033
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [b912eafa33227a5622c5a4310948cfa07c984726]

        fix use-after-free
        
        after
            commit deac5c84732c3491a0ef5bf7f8c1552e6def4fc0
            tdf#79049 speed up OOXML workbook load (2)
        when updating the iterator, I forgot to update the variable
        we are using to point into the vector.
        Rather just use the iterator to access the element.
        
        Change-Id: Iac8b6b7cdd945b2ccd261b0edc2ea8a563a10b1b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115028
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  dante  <dante19031999@gmail.com>  [040451e19087d8cb8ff4376166ca8248f909a4e0]

        tdf#137679 Use Kahan summation for interpr3.cxx (1/2)
        
        Change-Id: I8b07af0ad71f2be5acc8a660b93a48b9db6728f9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114964
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-03  dante  <dante19031999@gmail.com>  [9d7db2b4f09e08a607c8f07db38afa722d98a84f]

        tdf#137679 Use kahan summation for ScInterpreter::CalculatePearsonCovar
        
        Change-Id: Ia268415c0fa5c26476cdf328e2f8863e97600167
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114951
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-03  Michael Stahl  <michael.stahl@allotropia.de>  [1e7a8b7ff63a425de9ba631e44bfa6b8cca76e04]

        liborcus,zxing: add link to GCC bug
        
        Change-Id: I9420e786c4050a9ae79f1deab76a43e62c3b15fa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115031
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-03  Luboš Luňák  <l.lunak@collabora.com>  [90224afea1b1e51fb5a27cbbc9249b8ac7026abe]

        const Point& overloads for some BitmapReadAccess functions
        
        Change-Id: Ic33a42d94c1e3cd1022e4d4cda710eeade08e479
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115029
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [165b7b76e6ca1d66d765b4910b2be75384845f41]

        tdf#142040 CSV import broken in master
        
        regression from
            commit 75997f13ee3a71d6c994392264b0190bd7bb6756
        no need to create temporaries when appending number to
        O[U]StringBuffer
        
        Change-Id: Iacd74475ef7e9a70f60cedf80d3dfe4f1350f40c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115024
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Noel Grandin  <noel.grandin@collabora.co.uk>  [ed33d1d4928dc9886eaace62d3c62ea4305efdac]

        clean up some Java warnings
        
        Change-Id: Id54e8fd6803c3a6c0d924338d1781679ed0b1bfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115025
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Luboš Luňák  <l.lunak@collabora.com>  [ff673ce838a5538b1432daf9007c047f6455a5ba]

        update breakpad to the current chrome_m90 snapshot
        
        We've been using a version from 2015. And it appears that most (all?)
        crashreports generated on Windows have unusable backtraces, so maybe
        this update helps with that.
        
        Change-Id: Ied4a7943e6023c625bcd9060f18b4b90c00ad29b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113750
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-03  scito  <info@scito.ch>  [02b72784e5601636d26c8e4592958c262efb1a7d]

        tdf#102255 add .uno:PasteTransposed
        
        The transpose uno command is added to the same places as .uno:PasteOnlyValue:
        - menubar
        - cell
        - pagebreak
        
        The icons are added with tdf#141866
        
        Change-Id: I35a54390ee82ab1059007545188e9d175c3ea750
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114911
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-05-03  Andreas Heinisch  <andreas.heinisch@yahoo.de>  [357b36c7797ca7ac249714e5ddca1f04e0228c0e]

        tdf#90278 - Set the vba border to the default border
        
        The default border width in calc is 0.75[pt] * 1/72[inch] * 2.54[cm/inch]
        = 0.0264[cm] set in 2f527738ea4f8e93acafdd7f0ae06de1678cfdd8 which
        contradicts the border setting of OOLineThin used in order to parse vba
        borders. The latter was set to 1.00[pt] * 1/72[inch] * 2.54[cm/inch] =
        0.0352[cm]. This mismatch leads to an exception when the corresponding
        weight of a cell is parsed.
        
        Change-Id: I945d8aecdf31e5ad76d0d04e76eaaf4668e3d8ea
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114980
        Tested-by: Jenkins
        Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>

2021-05-03  Stephan Bergmann  <sbergman@redhat.com>  [0d18b90b75c074c0cca4d12a6468f2397909b886]

        throw() -> noexcept, part 3/3: New loplugin:noexcept
        
        Change-Id: I3ce3fab3e8047be14e003f1f3096b4e2745534e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115026
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-03  Noel Grandin  <noelgrandin@gmail.com>  [d417d25f417cc79b480bdfa4b2776562ee10f8c1]

        sal_uLong->sal_uInt32 in SvTreeList
        
        Change-Id: I0f543c6b2ce246cf603a3ccebfa6b815e7c2545c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115007
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Noel Grandin  <noelgrandin@gmail.com>  [5e66cb1cfc747b118d480194d88737d54197a800]

        sal_uLong->sal_Int32 in IMapCircleObject
        
        Change-Id: I47f4901d38cfb14011a0b7db4cc38203e3e14e30
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115009
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Miklos Vajna  <vmiklos@collabora.com>  [8c3ba8ac759e661f9402e0b5651d7e1914e72b66]

        sw: prefix members of BaseFrameProperties_Impl, SwDocStyleSheetPool, ...
        
        ... SwShapeDescriptor_Impl and SwStyleSheetIterator
        
        See tdf#94879 for motivation.
        
        Change-Id: I5602b7e94da0e5b004a45bed56d8c231b11004f5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115023
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-05-03  Samuel Mehrbrodt  <samuel.mehrbrodt@allotropia.de>  [5a4bd9bfbdb881368c202bc766f893a5c672621e]

        tdf#76258 Filter by colors
        
        UI/Logic implementation
        
        Change-Id: If7b48219caa466d8a3341bdc4e104d696e8988c5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114385
        Tested-by: Jenkins
        Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>

2021-05-03  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [95d8eb87eb20351a2e5795fc8c16653c0f58d6b4]

        tdf#141995 Remove uno:Flash command from Customize dialog
        
        Change-Id: Ie94e24a3f8ba518dde509c3cfa6d98e542074e3f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114988
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-05-03  Gülşah Köse  <gulsah.kose@collabora.com>  [4a39bfc7a94e45682d69cc126bef5bf763d6afe0]

        tdf#141678 Set class name alignment.
        
        Change-Id: I402e28903ec0bef10ad9fd2e74178b615af07c37
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115022
        Tested-by: Jenkins
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>

2021-05-03  Noel Grandin  <noelgrandin@gmail.com>  [5dad1d93a938cf995fd533b0c6a5cb7b0284f5c0]

        sal_uLong->sal_Int32 in Button
        
        Change-Id: Ib2a9f8eecbeee4de1ac8f0fc1a5bfa93f6746d48
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115008
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  Noel Grandin  <noelgrandin@gmail.com>  [13e49b4690f873b06175fe7b15454cba3c1e7a67]

        sal_uLong->sal_uInt32 in HTMLOutFuncs
        
        Change-Id: I112ac7c3eedcab912e54fb226c6253d88d64b6fd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115003
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-03  merttumer  <mert.tumer@collabora.com>  [6f35a3a7c0549fc5803522a3fdd02da97276fadc]

        lok: Edit the click selected cell on table selection
        
        for LOK case, it should start editing when table is selected
        from the cell that is under the cursor instead of selecting the
        table object.
        
        Change-Id: Ibb3fa41377b76edcdcc2be7419838a151ff765fe
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114386
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114646
        Tested-by: Jenkins

2021-05-03  merttumer  <mert.tumer@collabora.com>  [4603627360eae1bd42d3dda5348abe11d79b261d]

        Fix Row size change is not updated
        
        Row size is not taken into account when there is a change
        Only if column size/position changes, it starts updating
        
        Change-Id: I99f3aa9fe0e7f3428234062a2520ca8a61984067
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114130
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114645
        Tested-by: Jenkins

2021-05-03  merttumer  <mert.tumer@collabora.com>  [45602eb63bcea8e0fe084690144b6aba45f0a56a]

        Implemented CTRL + A selects all the cells
        
        When the table is selected, ctrl + a should select
        all the cells unless text editing is enabled.
        The previous behavior was deselecting the table and
        marking all the objects. However, for table it should
        select all the cells instead.
        
        Change-Id: I9fb512618a61a96ff21daa74c5a4ae9b31e3906e
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114129
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114644
        Tested-by: Jenkins

2021-05-03  merttumer  <mert.tumer@collabora.com>  [3ba86ee82a2d0c2d8cac3c7ee83e2c5f0a3c291e]

        Fix ESC key selects all the cells of the table object
        
        Selecting the table should not necessarily mean
        selecting all the cells. If all the cells are selected
        which ESC key does the same thing, it is impossible to
        delete the table with the delete key,
        only after an input following by an ESC
        deleselects them and deleting becomes possible.
        
        Change-Id: I33f182d330f1cbc411d47b86098a4aea544a90ae
        Signed-off-by: merttumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114128
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114643
        Tested-by: Jenkins

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [9c930c4f3109d123c0831d0fcecf9c8b32e5bbc7]

        sal_uLong->sal_uInt32 in SvxFontHeightItem
        
        Change-Id: Id9bec39765d504d787e5421bf40e88e09c5f180d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115006
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Caolán McNamara  <caolanm@redhat.com>  [2223b657c60b91f8f2bef05ec18c42bbe6106a71]

        drop unneeded temporary
        
        Change-Id: If9c774ccee4855e16e985332d9f2574403497ff2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114978
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-02  Caolán McNamara  <caolanm@redhat.com>  [f4c8a7d47398f353f26828d049aec29e5738750d]

        finally 'Change return value to Rectangle in next incompatible build'
        
        Change-Id: I8d301857a2529125c6dab43e3969aa61909537b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114977
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [85af593eac9d40cc715f87a94d390e9e8f48b880]

        sal_uLong->sal_Int32 in SvxNumberFormat
        
        Change-Id: Iaacef8d6b12f7d4257455e920a798b5cc2499d3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115005
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [f52d165c887076d6f6ccf928c2be585cfc06058a]

        sal_uLong->sal_Int32 in TextHint
        
        Change-Id: If8125e1343b74c2216fb8e9f9e1e16669062de14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115004
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [6549aa9afa7f39b45a0d402d83f4975f37bcc2fb]

        sal_uLong->sal_uInt32 in SvParser
        
        Change-Id: Ibe5599e1cc136330a8e9c089c7cc66d0ef4bc966
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115002
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [211a63a780659b404541cae619d10f204a8bfe65]

        sal_uLong->sal_uInt32 in ImplFontAttrs
        
        Change-Id: If0f9304eee98b442a5d3b4cdbf71230461e830bd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114994
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Noel Grandin  <noelgrandin@gmail.com>  [5c5aaf2b0907006334942fa178a8a254ac2f789c]

        sal_uLong->sal_uInt32 in Outliner
        
        to match the underlying call to EditEngine.
        
        Change-Id: I3e28cffdd121fa8e54f011e806b72e9a7e72f70f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114993
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Stephan Bergmann  <sbergman@redhat.com>  [10d29c390dd58ed629dd27fe5ed35fae28eceec3]

        throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewrite
        
        Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-05-02  Julien Nabet  <serval2412@yahoo.fr>  [a9243e626193ab4efe3a618413886773336a38e6]

        SAL_INFO we want to display nVersion not nSignature (emfio/emfreader)
        
        Change-Id: Idc40ac8bc0adc2f22b4ff140a563d6f63814f2f1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115001
        Tested-by: Julien Nabet <serval2412@yahoo.fr>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-02  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [d6b189bb4231d3500ba05437566f6daa7f0ce716]

        GraphicAttributes: put const. and op. '=' into the header file
        
        Change-Id: I1bc38f89457c3593673b445e7571a4fd82d5960b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114982
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-02  Noel Grandin  <noel@peralex.com>  [ffde7949ab6bd434b0f086d1a3bdf83f31aeda48]

        tdf#79049 speed up OOXML workbook load (5)
        
        Sc::NumUtil::isLatinScript is pretty hot, so add a small
        cache to ScDocumentImport.
        
        This takes my load time from 27s to 18s.
        
        Change-Id: I51fa891836d678f0d8700653e3a3a095297aeae7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114987
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-02  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9a02976a0738f077859f4afc5829388f35f4c103]

        Remove duplicated include
        
        Change-Id: Ib26ae0e3e1b1b1721f426b3f9967d97baf4f982c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114903
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-05-02  Noel Grandin  <noel@peralex.com>  [86b345a963a64fd9b9a3cab522b3ac2e909977fd]

        tdf#79049 speed up OOXML workbook load (4)
        
        Optimise LocaleDataWrapper for reads by initialising the
        data we in the constructor, so we don't need any kind of
        locking
        
        Reduces load time from 34s to 28s.
        
        Change-Id: I4bd3bddb30b70ba015fe5b1372534f9507762b74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114960
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-01  Michael Stahl  <michael.stahl@allotropia.de>  [aa38eede9d340cbb11a792ab1ebbe681521a4489]

        liborcus: newline problem with GCC 11 -E -fdirectives-only
        
        ooxml_tokens.inl:3524:32: error: stray '#' in program
        
        Change-Id: Ib7f50e1798e8c985f31a0338944ae1e9b439e98f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114975
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-01  Michael Stahl  <michael.stahl@allotropia.de>  [d1604a37295644f1393e46bba0bb20471128bb33]

        zxing: newline problem with GCC 11 -E -fdirectives-only
        
        KRHangulMapping.h:38:55: error: stray '#' in program
        
        Change-Id: I81e15f524c68da6bd5271a89035857f5e3c2ebc3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114974
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-05-01  Jochen Nitschke  <j.nitschke+logerrit@ok.de>  [ce7729ab473b971164822338661d1a4828d860d2]

        remove superfluous loop variable
        
        Change-Id: I418ea4b1770b82541bae8901d8d1b78d36cfb5d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114920
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-05-01  Caolán McNamara  <caolanm@redhat.com>  [c2678fb0b409eb75b15e056ba7c91a4320550e4a]

        tdf#141973 create the text column to insert into
        
        Change-Id: Ie5a09e7cd45ecbd1a9fd552c251538b2eeaccfb0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114972
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-01  Caolán McNamara  <caolanm@redhat.com>  [3d65c10f39e191b7e1ceb6fc94fed9e6196de0aa]

        Related: cid#1478001 CreateVirtualDevice never passed a null pGraphics arg
        
        Change-Id: I0701b15a28ab3583586c0c8018c511e100b41a93
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114948
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-01  Caolán McNamara  <caolanm@redhat.com>  [e3ffbd80413b27b11c43bfce6cd9753a95e5e8f3]

        cid#1478001 Dereference before null check
        
        Change-Id: I86fe97280c62bf871b23ea2e9274439bab7af929
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114947
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-05-01  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [07f1ec0af02a9ab6c1bf6e6478092ee50495afa7]

        avoid windres preprocessor quoting-messups with current cygwin
        
        apparently fresh installs of cygwin behave differently with the windres
        command's quoting and treats --preprocessor='cpp foo bar' as a single file
        "cpp foo bar" to run instead of running "cpp" with the arguments "foo"
        and "bar".
        (-D and -I options are passed to the preprocessor automatically, so no
        need to prefix those with --preprocessor-arg)
        
        Change-Id: I711e968206f0769ff07152ebb9572e8b71c30cec
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114965
        Tested-by: Jenkins
        Reviewed-by: Georgy Litvinov <git@litvinovg.pro>
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [afad6ba0f841985ee87a0a0871e10cda5d8913cc]

        svgio: add test for SvgNumber::solve
        
        Change-Id: I38aa58f9be104754d32ca985022947c3c7225f0c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114963
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0acc9af66dd2d35c8335291ff3e72d98e4359bd5]

        svgio: refactor SvgNumber::solve and SvgNumber::solveNonPercentage
        
        Change-Id: I9eefe4e6d2edf9891dc20f451230aedd44592732
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114962
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0919f55512b20eb508f697f904a38b84d93aa5f9]

        svgio: move SvgNumber methods to its own SvgNumber.cxx file
        
        Change-Id: I2b52eaf83162b80ccc6f656a5808e8b2aa6c2541
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114961
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  tushar  <tusharrai282@gmail.com>  [6fecdeac5d81a60a479195a62cdc174b919f763b]

        tdf#124184 Fixing StrConv VBA Function
        
        * vbUnicode/vbFromUnicode considers optional third LCID argument.
        * LCID is also used for other conversions.
        * The encoding is decided based on the language defined in LCID,
          or on program locale when LCID is omitted, using MS default
          ACP mapping for languages.
        * Unit testis for vbWide / vbNarrow are changed and enabled.
        * Unit tests for vbKatakana / vbHiragana are changed and enabled.
        * Unit test for vbFromUnicode / vbUnicode is changed to rely on
          en-US locale used in testing, and is enabled.
        
        Change-Id: Iabd4153db311cd02c3f3e7247f9fc71ad9f5f682
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112539
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-05-01  Andrea Gelmini  <andrea.gelmini@gelma.net>  [746016f9ab2cd72a49484c25ab18dad3f9c39a90]

        Fix typo
        
        Change-Id: I1edc4bf2ff17c259ce654bba953c0e4705de35c2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114950
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
        Tested-by: Jenkins

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fe2f5f99636d938d57c1880c37d54c1b796f06f1]

        svgio: covnert enum to enum class in svgtools.cxx
        
        Change-Id: Ib442bfc60d16021f314a063643e199a776afa10f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114959
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fd32860c303061a4df4981c0c1fd7a87af792bf2]

        svgio: convert enum to enum class in svgstyleattributes.hxx
        
        Change-Id: I97ac8922f4d6b921c2ef862f2168d14b66d8fc53
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114958
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [c70b342d6c903839528947be9885d9cbedf36d41]

        svgio: use pragma once in the header files
        
        Change-Id: I781e2083f4aab2e11bf78c3b941701ff7dd35772
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114957
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [e61cbca254fb0c060d06abbea669822f0a8582ad]

        svgio: add test for svgtools starting with SvgNumber
        
        Change-Id: I1f903a947fb1c338cf62980256c5369fefb7740e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114956
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [0d62ee66d6c02f0b3c38d1d0fa52f9cd86207a98]

        svgio: move isPositive to the SvgNumber header file
        
        Change-Id: I05c7d59000ac7f14a5d34ed30273379f6fc31677
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114955
        Tested-by: Tomaž Vajngerl <quikee@gmail.com>
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [fd50995350e613796794593cd216b7432fed98b6]

        svgio: move SvgNumber to its own header file
        
        Change-Id: I3f65b73cf0dd21e9818fa3596664662e1aa52c8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114954
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [83ff99bae3034e6ae029475dd0cf0ecc64756f6a]

        convert enums to enum classes in svgnode.hxx
        
        converted XmlSpace, Display
        
        Change-Id: I4aced2d7c2f6fcb4adc59949a6ac22d4ddd375a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114953
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [bd0c965b1ba9a15497f92102d5d11c84df091b2f]

        convert enums to enum classes in svgtools.hxx
        
        converted SvgUnits, NumberType, SvgUnit, SvgAlign
        
        Change-Id: I703b1d9396f42b3af1a36c683628e90161f2717d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114952
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [a52590d76b89dc75be2aa87f4287624c89f1e82f]

        update native-code.py with services for vba scripts in Calc
        
        Change-Id: I54eb60d3be2717c17daa6b7634ccee3e099cbb7d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114932
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-05-01  Luboš Luňák  <l.lunak@collabora.com>  [565824df07913f47851804daed9efa28a4a95e9d]

        fix dashed line info conversion for metafile (tdf#136957)
        
        My previous change had two problems:
        - It didn't handle correctly the case when something repeated,
          such as dash-dot-dot.
        - The rounding when setting lengths was a left-over from my first
          attempt when LineInfo used integers and not floats.
        
        Change-Id: I914241590b1ddec22df04c05dfe65e76e921ee52
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114940
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-04-30  dante  <dante19031999@gmail.com>  [4283fb9d4a6152643364bfe1f98ee1f36aabbb78]

        tdf#137679 Use kahan summation for ScInterpreter::CalculateSkew
        
        Change-Id: Ib9e34fd14d9968a5a8c79805da4f12d9a3422de8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114818
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-30  Stephan Bergmann  <sbergman@redhat.com>  [6a113a4f14808ac7f4bbdb4a5baff9383541d49a]

        throw() -> noexcept, part 1/3: Manual scaffolding
        
        The legacy `throw()` dynamic exception specification is gone for good from C++20
        (even if compilers typically still accept it, but e.g. Clang has
        -Wdeprecated-dynamic-exception-spec to at least warn about it).
        
        Introduce SAL_NOEXCEPT for use in URE interface include files.  (For both the
        existing SAL_THROW_EXTERN_C and the new SAL_NOEXCEPT, base usage of `noexept`
        not on LIBO_INTERNAL_ONLY, but on the actual compiler C++ version, so that e.g.
        building CppunitTest_cppu_any-external, which uses
        gb_CppunitTest_set_external_code but not gb_CXX03FLAGS, will not potentially
        complain about those macros expanding to the legacy `throw()`, like when
        building with Clang -Wdeprecated-dynamic-exception-spec manually enabled.)
        
        Change-Id: I7e5c7f8d5f0fd622cfc9987d656b1f68541375aa
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114908
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-30  Alain Romedenne  <alain.romedenne@libreoffice.org>  [f4880d0804478ba1edcb9f676278b77bd2bd7343]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6b24e1b46b633ccbbf65159f858c9a496479e426
          - sf_basic.xhp pt. 2
            
            Change-Id: Icb81fca7bdea283d3da6c113d1305d47c5bc6ff3
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114867
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-04-30  dante  <dante19031999@gmail.com>  [296367e0a91d0e6169da280d6a5efa83ae56de5d]

        tdf#137679 Use kahan summation for ScInterpreter::SumProduct
        
        Change-Id: Id0ef5b30a01054337f0ad3afd8c71311e6b2b469
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114888
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-30  Caolán McNamara  <caolanm@redhat.com>  [0527539a8d228daadcd30428553bff7d96bf8434]

        don't grab focus if we already have focus
        
        for cases like the combobox of tdf#138281 so we don't end up
        selecting the content if we already had focus
        
        Change-Id: I2294b2d17d56e5282d7d84859eb9002ebb3b9ada
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114938
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-30  Noel Grandin  <noel.grandin@collabora.co.uk>  [25b0f8787946b1627ea6ac0324d871a70cc5d9dd]

        simplify Wallpaper
        
        All of it's member fields are already COW types, so it doesn't need the
        complication
        
        Change-Id: I44e402e8e80fe96462fc4e1aa06b9ec6815e3cd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114933
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-30  Noel Grandin  <noel@peralex.com>  [61386aa03cd166473a58dbb4be0dd5e0ce82195c]

        tdf#79049 speed up OOXML workbook load (3)
        
        Exit this loop early if we aren't going to make progress
        anyhow.
        This takes the load time from 40s to 34s for me.
        
        Change-Id: I31887442cde6e3fc05f1fce10bb3dde9c2b88bf2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114942
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-30  Noel Grandin  <noel@peralex.com>  [deac5c84732c3491a0ef5bf7f8c1552e6def4fc0]

        tdf#79049 speed up OOXML workbook load (2)
        
        the allocation of memory and pointer chasing was
        slowing things down in the styles conversion.
        So switch to more cache-dense data structure,
        and re-arrange the loops to be more cache friendly.
        
        The takes the time from 1m9 to 40s for me.
        
        Change-Id: I876580adc7823313b0cdb067f2f6b3e61c39ecf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114941
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-30  Michael Stahl  <michael.stahl@allotropia.de>  [c926974ec1a4dbb72f273927fed0bc2f5e19c374]

        sw: add some SAL_INFO on DoIdleJob interrupt
        
        Change-Id: I44df06ab4bad1a5e0aaf5409590f5d7869f33482
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114937
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-30  Michael Stahl  <michael.stahl@allotropia.de>  [4184569b963877c2a488ff05766654b9db194798]

        sw: speed up DoIdleJobs(WORD_COUNT)
        
        SwTextNode::CountWords() has early returns that don't clear the
        WordCountDirty flag, for nodes that don't contain any plain text.
        
        This speeds things up considerably for tdf135116-1.odt, which didn't
        finish the idle jobs after 5 minutes in an optimized 7.1 build, because
        the time slice tends to expire iterating nodes in word-count before it
        can make progress.
        
        With this it does ~25 WORD_COUNT pages and then ~90 AUTOCOMPLETE_WORDS
        pages per idle, sending OnLayoutFinished after 13-14 seconds.
        
        jmux just pointed me to commit 0fedac18214a6025401c4c426466a5166553e8ec
        which is not in 7.1 today and may have improved the performance here.
        
        Change-Id: I5e9651da3a173649c49fc36edefb23298dfd6bc4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114936
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-30  Andras Timar  <andras.timar@collabora.com>  [0acf7e55df1098a406316d03de4725c16a27d138]

        serf should use bundled openssl headers, not system openssl headers
        
        Change-Id: I4431e5141a80394950f5711051065df42fe85f8d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114934
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-04-30  Jim Raykowski  <raykowj@gmail.com>  [d813620196646bebecd91536d47da67b725fdb95]

        reinterpret_cast to SwPostItContent when field type is postit
        
        Change-Id: I4ed914479c07c786fdc3401c56f7d793777df751
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114897
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-04-30  Caolán McNamara  <caolanm@redhat.com>  [c90792cf4309557981d1f89febeff9157fd93b0c]

        Related: tdf#138281 move grab_focus to ActivateFind
        
        and remove the explicit KeyInput callback handling of "KEY_RETURN" in
        favor of the ActivateHdl callback which Entry emits from its built-in
        KeyInput handler
        
        Change-Id: Ie6ddc8d73345400586418f2495958b14ab61c7d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114907
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-30  Noel Grandin  <noel@peralex.com>  [857caa5fc69b92e781457a1b67a89aa051c2d70f]

        tdf#79049 speed up OOXML workbook load
        
        we spend a lot of time in ScAttrArray::GetLastVisibleAttr
        which appears to be very expensive for this worksheet.
        
        This is re-computed every time we enter SfxBaseModel::getArgs
        
        Reduce the recomputation by introducing a new method which
        only retrieves specific SfxBaseModel arguments.
        
        This takes the load time from 5m9 to 1m9 for me.
        
        Change-Id: I605fae0faa94760c7d6993877c9559ea5dc813cd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114905
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-30  Xisco Fauli  <xiscofauli@libreoffice.org>  [b9097800f4f997de2325bc9e588e6caea7a563c7]

        tdf#137945: sc: Add UItest
        
        Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114900
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-30  László Németh  <nemeth@numbertext.org>  [d845b91bcc6eb885c55494d4d4fab4ec09577e1d]

        tdf#78864 sw track changes: cross out deleted images
        
        Show Changes mode shows deleted images with crossing
        out to allow differentiate deleted and inserted images
        during change tracking.
        
        See also commit d6322bcedc197a654abc7d64bfea8cf570f123bf
        (tdf#59463 track changes: record deletion of images).
        
        Change-Id: If9bc2252c6cdd06cbe267fe130023c416aa53ce7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114906
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-04-30  Tünde Tóth  <toth.tunde@nisz.hu>  [4b8459e86c7a411d8f02fc5480033cb031a941f2]

        tdf#141946 sc: fix broken filter criteria when inserting column
        
        The autofilter criteria weren't remain with the filtered column
        when we inserted a column left of the filtered column.
        
        Change-Id: If366d9de9518da3d13ec2ba6b1b36e4f98c76019
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114881
        Tested-by: Jenkins
        Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>

2021-04-30  Caolán McNamara  <caolanm@redhat.com>  [1320afe376bc52bc64995ba976391ec21db6ccde]

        allow dnd into weldeditview
        
        Change-Id: I42fafed01a3884279781642154656f0ee32ad431
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114846
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-30  Caolán McNamara  <caolanm@redhat.com>  [5f89b8cc5521b683a519b93bbc3da739ed0fd795]

        extend the selection range so adjacent lines are considered one block
        
        and so we get one border around multiple lines of an editview
        selection
        
        Change-Id: Ic641035da1c7d2b891cd6e6193b524e6b581e76f
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114895
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [29016704108165371da9e2392d6ee28939ca46ce]

        svgio: change some OSL_ENSUREs to (std) assert
        
        Change-Id: Ie7e7e6276e5a528fb99a6dfda00e9826c5245fb7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114899
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [91daf2c6b1661f27df6ee41f7395ed0fcb677cf0]

        svgio: change SVGToken enum to enum class
        
        Change-Id: Ic2618c91b1793463b7ce0a42ec1db100d11acfa4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114898
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-04-30  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [560c9ec9e27e771d61f1396a1c87dd38e29099c1]

        vcl: iOS/macOS - move graphic render func. into AquaGraphicsBackend
        
        This change moves graphic rendering function under AquaSalGraphics
        into a new AquaGraphicsBackend, which inherits from SalGraphicsImpl.
        This is part of the refactoring to make it mandatory that a
        SalGraphics always has a SalGraphicsImpl associated, which will
        make it possible to simplify the SalGraphics interface and enable
        the posibility to implement alernative graphic backends (Skia).
        
        Common variables and attributes are moved to AquaSharedAttributes
        and are shared between SalGraphics and SalGraphicsImpl.
        
        Change-Id: Ie48da87002ec8e4011ba92fdc9170f3a86761517
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114701
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-04-30  Luboš Luňák  <l.lunak@collabora.com>  [6b7c2fa65eb68be520ed4135cc245e33fa22e8bf]

        allow utf-8 in xml names (liborcus) (tdf#141672)
        
        Change-Id: Ib150d55b588a572e4352396f18de2331983b2aae
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114892
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-04-30  Caolán McNamara  <caolanm@redhat.com>  [23e99c75ee5e3b8d15e041cefab0e99e384442bd]

        drop DropTargetHelper from SmEditWindow
        
        dnd into its child always worked while the inheritence from
        DropTargetHelper began in
        
        commit daf3e2909104fcb4c0a36d6e1fd6f44e1b61c980
        Author: jp <jp@openoffice.org>
        Date:   Thu Jul 5 09:58:51 2001 +0000
        
            Changes for TFD636
        
        but always returned DND_ACTION_NONE for the parent window
        
        Change-Id: Ida1ae0f8e68ba04452ed952c4eca3ac66f240132
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114847
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-30  Stephan Bergmann  <sbergman@redhat.com>  [ce5702d3c27e2a9de253ee29e02c7f494ba2a2b8]

        Reshuffle code a bit
        
        Group the various SAL_THROW_EXTERN_C macro definitions more closely together,
        and the C++ SAL_THROW_EXTERN_C and COVERITY_NOEXCEPT_FLASE macro definitions do
        not need to be inside an extern "C" block.
        
        Change-Id: I8c56f5c2efd287934cc75b20e79c27769e887e24
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114845
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-30  Miklos Vajna  <vmiklos@collabora.com>  [b5586bd42a35d294e014d665bc47c49ae4dfbde5]

        external: update libxmlsec to 1.2.32
        
        And drop the 2 upstreamed patches.
        
        Change-Id: Ia821023d9cc06df5e9e7aef82c070ad1c98b67e4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114894
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-04-30  Stephan Bergmann  <sbergman@redhat.com>  [c112868f6cc6a3ba937778435dcca1fe986bf124]

        loplugin:stringadd (clang-cl)
        
        Change-Id: I132643eb73129e1319af36b7c8aac36a516714b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114896
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-30  Jim Raykowski  <raykowj@gmail.com>  [18e5e948dd66e41f17b0a63bf631d98aee84a03b]

        tdf#137741 SW: Add fields content type to Navigator
        
        also makes Comments category be tracked
        
        Change-Id: I038ba87d6ae0b96bae2d7a213ec5df92ac7d566d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112560
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-04-30  Jim Raykowski  <raykowj@gmail.com>  [43c47f0cc133782ed6c4037df38df0d0c82123b8]

        tdf#133548 don't change outline level attrib and list style attrib
        
        when a new paragraph style is created based on a "to outline style
        assigned" paragraph style
        
        Change-Id: Ia757ca375e0e8749a24c27ad8e3f40daff7ef55d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112255
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-04-29  Miklos Vajna  <vmiklos@collabora.com>  [58607e1c410ee89ddfd47dcd128abfa00e0ac839]

        sw html/reqif export: fix size of presentation data for "real" OLE2 embedding
        
        InsertOLE1Header() can either take its OLE1 presentation data (preview)
        from OLE2 or from RTF (SwOLENode). The presentation data size we wrote
        was incorrect in the OLE2 case case: nPresentationData is the RTF size,
        nBytes is the actual buffer size.
        
        In practice this made the embedded object non-editable in Word (when
        trying to edit the RTF fragment).
        
        This went wrong in commit 0d027abbc5609b096d2a954e77aa7354a55928ab (sw
        reqif-xhtml export, embedded objects: take OLE1 pres data from rtf if
        needed, 2020-09-02).
        
        Change-Id: I89019202c9a8b40c1b9a21f611f1190fd50073a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114889
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [b96797dd2e6578e8e1a4cea0fa2f3a17bc194a1c]

        tdf#141963 put focus in vcl parent during Function key processing
        
        Change-Id: Ib63567c9ce208cb7dd522a1bce9d99fa44a72554
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114883
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Gülşah Köse  <gulsah.kose@collabora.com>  [3c6692f88df3f7447138fc953f11d8587d51f093]

        tdf#141422 Set inital height of the develepment tool window.
        
        Change-Id: I703edc227ee163e2a7b8fb9b03c71f055c6e0a3b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114775
        Tested-by: Jenkins
        Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>

2021-04-29  Julien Nabet  <serval2412@yahoo.fr>  [d2b5e49c0b114fdf973e51b4387e232bd71f3838]

        Can use stack instead of heap (desktop/lockfile)
        
        Change-Id: I31f53436e31ca0dfe7de34bb252f104d4a1b34f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114885
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
        Tested-by: Jenkins

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [04aafba860f613c20e7078d038cc83eb02de0b54]

        loplugin:stringadd simplify some *StringBuffer operations
        
        pulled from a larger patch which I created with a more permissive
        variant of this plugin
        
        Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [76c793d2acf66f46e9edcda43d2f4327e8374841]

        rename A field in ::Color to T
        
        because it's actually transparency, not alpha, and having proper naming
        helps my limited brain keep track of stuff better when debugging
        
        And have both the stream operator and the debugging printer print out
        alpha values, for consistency.
        
        Change-Id: I9bc9ffcb71d554603591935e4043a3fb14646ebd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114886
        Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  Alain Romedenne  <alain.romedenne@libreoffice.org>  [debac7777007038aeebd395119ba2ad4a9cc5d88]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 4ee2f0f82f99a865e765309eda367d5fc016674b
          - sf_basic py2bas bridge
            
            It includes Basic functions rework in order to
            - share content,
            - correct Basic keywords argument names tdf#141474
            - accommodate Python lowercased arguments.
            
            Change-Id: If59a82444a8e001b02d085f5e10e0053666f8485
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114008
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [04f72656705905be13a006004dc18ac6cff4832b]

        tdf#141967 bail early in Activate if disposing
        
        because focus bounces around the dialog as its being torn down widget
        by widget
        
        Change-Id: I2afd094bb13929c25268168175c142ca8e0074e1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114880
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Jan Holesovsky  <kendy@collabora.com>  [0dc9da5df470b9c345e78dbe9553d81b9e4a7435]

        lok: Disable the "AutoInput" again.
        
        This partially reverts "lok: sc - suppress LOK editengine events for the calc input bar."
        
        The feature itself is very problematic in Online:
        
        1) causes unwanted jumps to other cells,
        
        2) causes the selection blinking in the cell when typing, and
        
        3) it is very annoying in the form that in which it is implemented
           in LibreOffice anyway, compared to other office suites.
        
        Let's disable it, and enable again when we address the above issues.
        
        This (partially) reverts commit 91319ad56887f932b2da334db560d5d0a79a0280.
        
        Change-Id: I2234455c29069f74d13896474f3499035935931b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113047
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Jan Holesovsky <kendy@collabora.com>
        (cherry picked from commit 65990058f041c3f1d280a69d411eb4ceacf5a721)
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113112
        Tested-by: Jenkins

2021-04-29  Xisco Fauli  <xiscofauli@libreoffice.org>  [e53ac4207d2f9e53f7bfe4f927961ebe2bd17182]

        vcl: print dialog: remove broken code
        
        This was introduced in 149807eb6100090e178505ba4a264bb38eba1e0c
        < Resolves tdf#127782 - Print dialog height >
        trying to fix the problem of the window size not being remembered
        after reopening the dialog, however, the problem is still
        reproducible in master with GEN, thus, remove this code
        
        Change-Id: I65f327fa692cd3e2b5597d04e9e15abc952fe6d9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114874
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [aa096331ba468f19951e43e2550105d4dcf50053]

        tdf#141970 Revert "tdf#129606: Round the mean of the two subtractions"
        
        This reverts commit d5ebe7c3089ab9f4d3fe0707169fc1ce024cdb70, and
        brings number of inexact values in testing back to lower numbers
        (see test document in the bug).
        
        Change-Id: I5cfb34b7260fc6e4866585af6a2a50e79696eea2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114861
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-29  Rafael Lima  <rafael.palma.lima@gmail.com>  [a7520ce3b4dacf8e3f3ca88110783c5419095a1d]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to c8cf56ede34cc13a90a930aab505828ee196005c
          - Create SFDocuments.Base service help page
            
            Change-Id: I2bf6bb4e28ed4390c26f9409dddd2aabd1dc878a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114509
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            
2021-04-29  Luboš Luňák  <l.lunak@collabora.com>  [b71d9a6d15cfb8a50afdea5ac064f40d84c561f8]

        do not apply line dashing in drawinglayer (tdf#136957)
        
        basegfx::utils::applyLineDashing() is not as good as the actual
        VCL backend dashing, and there are some rounding errors because of
        all the canvas transformation matrices or whatever, which leads
        to the drawing problem. So use LineInfo to carry the dashing
        information.
        As a part of this change, also make LineInfo use doubles instead
        of ints. The use of transformation matrices means that the values
        may be fractional and less than one.
        
        Change-Id: Ia5ac7d266cab344b7137052c81fbd96c1ce28003
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114710
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-04-29  Luboš Luňák  <l.lunak@collabora.com>  [5d4e450a7d64d3dc1caf34544dbfa35f4641d5c3]

        Revert "tdf#136957 Use bigger dots for better handling in presentation mode."
        
        This change was a workaround and a follow-up commit will handle the problem
        in a better way.
        
        This reverts commit 5d80f679e1891f98ef964efa1166c90d001c5806.
        
        Change-Id: I24a98a0828d3b6fbd014d58f37bf4da40d7dfdfd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114711
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [1d036d1a58a46d46ca38eaa8ba438015a54008f6]

        reuse SmEditWindow already present in SmCmdBoxWindow in tests
        
        Change-Id: I48f15d584e15269336b289c8204588384f2f6998
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114838
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [41dbc48a71717d3d4703c707a4491020ecc12b1a]

        can stack-allocate this
        
        Change-Id: I53de9926bb3eb662ab6f9065bf1d9190df76c0c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114879
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [610d8d3ca470d13159c017cdc3f86310bf5cd1ef]

        use unique_ptr in TextEditOverlayObject
        
        Change-Id: I0deb52ee36a16aad91a5f945a6d92c1aa18a58a3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114878
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  Alain Romedenne  <alain.romedenne@libreoffice.org>  [9224109de3cf2b620ff1165d31e9fb2a4cd680cf]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to a4aacdb16a5c386147c6e7a2c1c1f47843b3a805
          - document SF_String isIBAN() 7.2 method
            
            Change-Id: Icdf0bdc74ea5deced0f31ee01061e46ff8b805f1
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114713
            Tested-by: Jenkins
            Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-04-29  Olivier Hallot  <olivier.hallot@libreoffice.org>  [8bde607cae2d9c0edb013aae975bde1ddba388a8]

        tdf#141954 Enable l10n in Formatting bar customization
        
        Change-Id: I3683b947ca9c431febb18fd01ea4a13660e4e07d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114825
        Tested-by: Jenkins
        Tested-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
        Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [e4fdf7f5bf40ee289ac3441eb8b8963c10caf6a1]

        rename ECKEN -> CORNER
        
        Change-Id: I24438213431bd2866e2bcefc8a054a03bc975ef4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114841
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  Julien Nabet  <serval2412@yahoo.fr>  [5e58cc6fa84ba77b948cd603e83ad817cedfeb03]

        Fix typo SID_TEMPLATE_ADDRESSBOKSOURCE->SID_TEMPLATE_ADDRESSBOOKSOURCE
        
        Change-Id: I6a23cdd71dc3476c415e710dad4a33c9d0c20202
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114839
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-04-29  Tünde Tóth  <toth.tunde@nisz.hu>  [edb64cc363e782470870089041c48993d7c34de5]

        tdf#48025 sc: fix broken filter criteria when deleting columns
        
        The autofilter criteria weren't remain with the filtered column
        when we deleted a column left of the filtered column or
        the filtered column itself.
        
        Change-Id: I0eb103ea5569d82eac4d81bce1b31b0c3bbcbf41
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114483
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-04-29  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [b49eca55210d3f7e731f32f2f20bd12bfd729ec6]

        tdf#131162 Rearrange Impress/Draw General settings page
        
        so that checkbox labels fit in languages where they have long
        translations such as French, German, Hungarian
        
        Change-Id: I44107df00fbd969cd3afca016c96e4a1af86842d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114445
        Tested-by: Jenkins
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [b550d72293582e37112dcc1349e845a69bfe1414]

        cid#1473812 Untrusted value as argument
        
        Change-Id: I95877c014d16426622e7114384c8e189c140943c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114836
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [857dee030f0a45cb3e28a0f3870b02a97fd8e280]

        Let's call it "traceeventrecording" and not "profilezonerecording"
        
        It is not just ProfileZone events any longer that are recorded.
        
        Change-Id: I9c2b5817fca8f8a23ebd571cbaccb9ac063ec73b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114848
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [c1c4d50d08eff7a38617839a896392a34c5183a2]

        cid#1477405 Initialize members
        
        Change-Id: I6e546875cf61394e0001000994fccbd8d6626428
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114837
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [e0d0399da64021b6029618371d816bcbfd874f01]

        KJ: tdf#141885 New Paste As Link icons
        
        Change-Id: I3022897dcdc4ce50c44f483a688787ec47b9b8b9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114827
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [7e8960caa8b49c75e4f1d21ebffe2378359fee69]

        Add SAL_WARN in case ProfileZones are overlapping and not hierarchical
        
        Change-Id: Id09904db762b6d931ab23cce16e55d5213079516
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114834
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Tibor Nagy  <nagy.tibor2@nisz.hu>  [d0550d1c5d0e27b8fe9d93e2c7a6dc7ffc4f8c21]

        tdf#65724 PPTX import: fix internal hyperlink to slide
        
        Internal hyperlinks were lost, if they refer slides
        using their names.
        
        Change-Id: Ic464300adb1e6e50bd4d61d957306592b7b22b14
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114139
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-04-29  Jean-Pierre Ledure  <jp@ledure.be>  [225ee785520bbbee5b2d9bd63915db7197ee7ccc]

        ScriptForge - (scriptforge.py) dates passed as UNO dates
        
        In replacement of the ISO format, to avoid any
        misinterpretation of strings containing accidentally
        a date,
        from now on, dates are exchanged between Basic and Python
        as com.sun.star.util.DateTime structures.
        
        The year boundaries are [1900 - 9999].
        
        The code managing the Python-Basic protocol has been changed
        on both sides.
        
        The Basic service receives the
        - CDateFromUnoDateTime()
        - CDateToUnoDateTime()
        methods, equivalent with their Basic homonyms.
        
        Change-Id: Ib6ded20c24ff71d3349d242f72bd7b88f69a2661
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114815
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [5753386c2353ad4866e7c5dd9e8751ccaa58e93c]

        allow push/pop multiple levels of freeze/thaw
        
        so can freely protect a block with freeze/thaw regardless of current
        freeze/thaw state
        
        Change-Id: I1bd60bfc02fe784e36ae371a737f4fdfb15a0888
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114615
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Attila Bakos (NISZ)  <bakos.attilakaroly@nisz.hu>  [b6b02e0b4c9d739836e1f61a886ea45b01e6696e]

        tdf#111903 tdf#137152 PPTX export: fix placeholders
        
        Empty placeholders were exported as white empty
        custom shapes, losing their visibility and usability.
        
        Note: export of properties hasn't been implemented, yet.
        
        Change-Id: Ie8bd6a611f5fb43bcaa55f6b2f5b07daf731b163
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114331
        Tested-by: László Németh <nemeth@numbertext.org>
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-04-29  Caolán McNamara  <caolanm@redhat.com>  [80d7bedee20eb191b1f5a6b2767630eb823d63b2]

        freeze without thaw
        
        which was already SetUpdateMode(FALSE) without matching
        SetUpdateMode(TRUE) in:
        
        commit d32b3a714fe55892bdead03502c5a9b0e77fa61d
        Date:   Sat Oct 31 00:36:06 2009 +0100
        
            #i106421#: move svx/source/cui to cui
        
        and then remove the outside freeze/thaw pair, which may in practice
        have worked around the unbalanced inner freeze/thaw, from
        SvxEventConfigPage::SelectHdl_Impl in favour of the inner
        freeze/thaw so the select can work on a thawed treeview
        
        Change-Id: I6dbcfd000f717047354e7cdcfb9b3a502e1fbbe5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114822
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-29  Rizal Muttaqin  <riz_17_oke@yahoo.co.id>  [78ad3fe28321a9e2e4eaa0dcc8f1ccdaed0b1f79]

        Sifr: tdf#141885 New Paste As Link icons
        
        Change-Id: Ibc53c19f2b57dec500fbb74dd5c097b01664171e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114828
        Tested-by: Jenkins
        Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [724fc62e9288f26428274977614948fee0bc2000]

        Make the nested AsyncEvent work more reliably
        
        We must take into consideration that somebody might hold on to a hard
        reference to such an object. Thus it is not enough to drop the
        references to it from its parent, that is not necessarily enough to
        make it destruct. Instead have the parent explicitly cann a function
        on the children than generates their end events.
        
        Also add some documentation.
        
        Change-Id: I38180c85072c76af8964c48fa19132b8e1178ee1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114813
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [2cc42f656b24b6e506fecb61f0fc58f5f8a98e6a]

        Add AsyncEvent::finish() to end a nested AsyncEvent before its parent ends
        
        Add unit testing of that, too.
        
        Change-Id: Iae5fb6da0b7fcabe8f555d800f065b6f5b4b9982
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114771
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [0e383fa31da530161263ef02f4e7c464f4d7b53e]

        Fix syntax error in generated JSON
        
        Change-Id: I035a86aa587302985416e65dc6063090f99b49b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114770
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Tor Lillqvist  <tml@collabora.com>  [89c0d087c657c31a3198c481a63ca0549b8a4503]

        Introduce Async trace events and a unit test
        
        Async events are ones that emit separate 'b' (begin) and 'e' (end)
        traces. (Compare to the Complete event that emit a single 'X' trace
        that contains both the start timstamp and the duration.)
        
        There are two kinds of Async events: Freestanding ones that are not
        related to other events at all, and nested ones that have to be nested
        between the 'b' and 'e' events of a parent Async event.
        
        Still needs some work, at least a way to end a nested AsyncEvent
        (cause it to emit the 'e' event) before it gets destructed thanks to
        the parent being destructed.
        
        Change-Id: I3721fa701ad32639b1edc1cfa8db7acde5caf9b4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114756
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-29  Miklos Vajna  <vmiklos@collabora.com>  [896586e91a2b0b3437ff1c9ad1d72fbce04a7fed]

        Replace magic numbers in SwFlyFrame::UpdateAttr_()
        
        By using the same SwFlyFrameInvFlags constants that
        SwFlyFrame::SwClientNotify() already does.
        
        Change-Id: Ib0775c34cb4b1c6bec4455216ebb2dea3976d007
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114820
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-04-29  Noel Grandin  <noel.grandin@collabora.co.uk>  [b153d147c9d813f78dd551fc186c261f52c929a1]

        remove support for BITMASK in vcl backends
        
        Rather use a proper alpha channel if we need transparency.
        
        This is another small step towards merged alpha in our vcl
        layer.
        
        I suspect the intent in a lot of this code was to save memory.
        Which have been a thing way back then, but these days our
        backends mostly end up doing a copy-and-convert to a real
        alpha channel anyway, so the existing code is actually
        now a pessimisation.
        
        Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-29  dante  <dante19031999@gmail.com>  [bd944fe3812fd9fa5a90e98cdac4a77f1a4e6865]

        tdf#137679 Use Kahan summation for interpr2.cxx
        
        The changes in the text files are in the latest decimals.
        Those should be more accurate now.
        
        Change-Id: I3814e1939f71debd5ddde9408a025af7a0a2cac5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114737
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-29  Jim Raykowski  <raykowj@gmail.com>  [4bc0af27204f099f14cb4c97611089643cbe271c]

        tdf#137741 Add ability to navigate by fields from Navigate By control
        
        Change-Id: I3cc464a3d5097b4e0438ea22ebf6daad5a2f2a86
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112144
        Tested-by: Jenkins
        Reviewed-by: Jim Raykowski <raykowj@gmail.com>

2021-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [b6ab5914d8b2fc7041430796890f086f8e3e6369]

        tdf#135997: make sure that the two lists are same length
        
        This fixes the strange assumption that when searching the two
        lists (character names and font names) independently, the two
        found positions will necessarily correspond to each other.
        
        Instead, the positions of the match must be the same, which is
        implemented now. Also the input from configuration is sanitized.
        
        Change-Id: I920de7414387e181e11183b8a22776a72b6be419
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114722
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-29  Mike Kaganski  <mike.kaganski@collabora.com>  [b27de500b1412bacefc7144b5222c307ca1ae0fe]

        tdf#135997: fix toolbar control
        
        This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7,
        just for the toolbar control (the older one was for special
        character dialog).
        
        The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11.
        
        Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-29  Rico Tzschichholz  <ricotz@ubuntu.com>  [f616d96bd8ce8986e4cc204953db0467e6060b5c]

        apparmor: Fix "oopslash" typo
        
        Change-Id: I8b355bceadeebebc9e6fedbf92a35aa44a356e09
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114819
        Tested-by: Jenkins
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-04-28  Luboš Luňák  <l.lunak@collabora.com>  [56c450a9e9e12ba55ce8f62de546000df146052d]

        Skia understands that linewidth == 0 means hairline
        
        Change-Id: Ic5aea464d6414fc2218179143d16121ef293bdfe
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114816
        Tested-by: Jenkins
        Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [c33f08ca36084643e6eed20c18f151cf75045c62]

        createPixelProcessor2DFromOutputDevice won't return null
        
        nor will createProcessor2DFromOutputDevice
        
        Change-Id: I1e0359ef2f94eeaf2da9a89d9e9dfb615587d3da
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114814
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [9f46ae1ab572b62af01119dcd473f99184e4760c]

        tdf#116384 only drag hyperlink if user's not currently setting the selection
        
        which is what writer does for normal text.
        
        Under gtk it's common on selecting by dragging the mouse over a hyperlink
        for one or two letters of the hyperlink to get selected before that
        selection then gets dragged as dnd.
        
        Under gen StartDragWidth is 2 by default so the drag kicks in before
        enough text has been selected for writer to select anything, but under
        gtk gtk-dnd-drag-threshold is used for StartDragWidth and that is 8 by
        default making it easy to select one or two characters before the
        gesture is recognized as a possible drag.
        
        it seems sane to do the same as for normal text and not dnd if the user
        is still using the mouse to set a selection
        
        Change-Id: I971d429acaf8a5a656c5ce58f52632979b94e40a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114817
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  tushar  <tusharrai282@gmail.com>  [6e66b30d9287b418bed35400c77b257b97cf26ec]

        tdf#141904 Blue row number for autofilter only when pTab is not NULL.
        
        Change-Id: Ibdf1efbff34bc58912a5a776d47ccfd784d3111e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114647
        Tested-by: Jenkins
        Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [99668e79c13fee09f8d776dbcd28e7667d7f68fe]

        Related: tdf#130326 skip calling Refresh if its already just called
        
        Change-Id: I80d3ae7f10b56dfe53a4ab5101ae771b47848092
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114651
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Olivier Hallot  <olivier.hallot@libreoffice.org>  [39619da47e029afd3e8be5c2a558683237d94ecb]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 914fe5ffbb1a3fde750cf37cbc44008994cf3b42
          - Improve link
            
            Change-Id: I209a986ce8a6b7ff995724eec0de55393f518050
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114723
            Tested-by: Jenkins
            Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
            
2021-04-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [20d768d022915d23f652435fe5c3bd712fbbfd1f]

        Fix typos
        
        Change-Id: Ide3cd321f756cc685f50b6572de446da56ab5072
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114809
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-04-28  dante  <dante19031999@gmail.com>  [b9b744babd4d2eac73ef3684c28cfefd5b842c11]

        tdf#137679 Use Kahan summation for interpr1.cxx
        
        Includes changes for using kahan sum in ParamIfsResult.
        
        Change-Id: Iedfdd867e316d6c99146450cc3f7ac1d855b33e9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114676
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [93a90a5b0558aeac847aefe06f49f68c00a26678]

        update credits
        
        Change-Id: Idd3d14c272c1eebca7207054dccbeae4632c51cc

2021-04-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [8c8979468835694de949c044bb698c6d5ae10d19]

        tdf#105688: sw_ooxmlexport16: Add unittest
        
        Change-Id: I3da5f4416f1833389691787d205a89f3005f746e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114773
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-28  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [bf02dfd6ccae832723da81f96f1f2e4bf6174e45]

        Update git submodules
        
        * Update translations from branch 'master'
          to 926713ac8f969ab8b246090eb8f3c4c48bead223
          - update translations for master
            
            and force-fix errors using pocheck
            
            Change-Id: I088f31a9fb757c6d1455f87c292e550b46532a30
            
2021-04-28  Miklos Vajna  <vmiklos@collabora.com>  [6002014ce0a5c9cea22c14b2437b7a508b2c72cb]

        framework: allow loading a component on the main thread, using XDesktop
        
        This is similar to commit 2dc3a6c273cb82506842864481d78df7294debbf
        (framework: allow loading a component on the main thread, 2018-12-19),
        but that focused on the special case when loading happens via XFrame.
        
        The more frequently used XDesktop way now supports the same flag,
        allowing correctly loading "real" OLE objects on Windows.
        
        Change-Id: I059ea143c91894508d8264084094eefc2bff24e8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114805
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [041a22ec9e7789f93a8dacbc7e7f0b1fb630e6fb]

        replace old-school RasterOp::Invert selection in weldeditview
        
        with the prettier semi-transparent selection used elsewhere
        
        affects e.g. math command window, writer comments, calc input bar, calc
        Headers/Footers dialog.
        
        Change-Id: I35f8211f6e86c4278db84a6b6aa5306d5b1df468
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114804
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [9e5b04d1e8c49d5f95173b5074368b1aa24a1e64]

        Introduce a new class NamedEvent to be used by the upcoming AsyncEvent, too
        
        Don't use the term "profile id" as what we mean is the event *name*
        (as used in the Chrome Trace Event format).
        
        Change-Id: Id58a10f4c5f8a095ae75b9bf74131b70659ee701
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114755
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [92c37610fa6e9fdeebee33a8baf0faf0bb731101]

        Enable turning on trace event recording in a dbgutil build with an env var
        
        Change-Id: Ie0efdd2d5da0a45ba5e82be455d36dc777b5efb9
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114736
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [969ddb6899b453194001e6743cc4d8003d5b050a]

        Re-think what the nesting means in ProfileZones
        
        The "Complete" type of Trace Events should be properly nested. Use the
        nesting counter to verify that. Add a nesting level indication to the
        ProfileZone object. Assert that it is used properly.
        
        Change-Id: I3a1f0e55ea6054dab9baf8550097446f07b0fbf3
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114735
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [d57ac8ff9c0b4ec8706d1d64c4a0ee9eb23de66c]

        Make the console logging in ProfileZone work more sanely
        
        Do not re-assing a value to the m_nCreateTime if bConsole is true.
        Just use the same code that sets it in the constructor as in the case
        when recording is on.
        
        Change-Id: I1ca3c5aa00e2f8f0faa7ca3433e1eb066413c2a2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114734
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  dante  <dante19031999@gmail.com>  [fd4df675dfe1012448285134082f61a0c03a7d15]

        tdf#137679 Use Kahan summation for scmatrix operations
        
        May also want implement Kahan sum in there:
        sc/source/core/tool/arraysumSSE2.cxx
        sc/source/core/inc/arraysumfunctor.hxx
        Under some conditions the sum of a pointer type vector
        may be perforemed by arraysumfunctor on NumericCellAccumulator.
        arraysumSSE2 implements part of it.
        This code has been left unmodified.
        
        Why the test has been modified:
        The error was: 238.89000000000001 != 238.89
                                        |
                                        17 th digit
        IEEE 754 double-precision has 53 log10(2) ≈ 15.955 digits.
        So it's just noise.
        
        Change-Id: I6f84826bf3875be4f444f5eb61854bc1f95769bb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114627
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
        Tested-by: Jenkins

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [bc7c37f2f67ace27196a46c62c2d568501e9f796]

        ofz#33769 Integer-overflow
        
        Change-Id: I067db0452650cf3e8bc887abac74c4ff796d4ad2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114768
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [d6605cc5f4e2b2cc52e2f2c9645a09171529d9d0]

        disposed window accessed during UITest_sw_navigator
        
        Change-Id: I476c7cda4a9997b4c0a04a0838d608bf78b495d1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114778
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [39c3574b799690d4405d9318a5ba221b5feaccbe]

        use string_view in INetURLObject::encode
        
        Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-28  Rafael Lima  <rafael.palma.lima@gmail.com>  [9658115370bf33c2fdb68a3b759cf2f9d9e7c6c1]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 49937bb740e70e6a244f9f4e9a30b7541815e62e
          - tdf#132325 Improve Variant/Any documentation
            
            This patch improves the help page "Using Variables":
            - Adds to the "Declaring Variables" section an explanation that variables of unspecified type will be considered as Variants
            - Creates a new section "The Variant type" to provide a brief overview of the Variant data type
            - Explains the Any data type
            
            Change-Id: Iaf076ad3ef22d24fb1aa4cfa089ed9d2a1bcf57c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114717
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-28  Tor Lillqvist  <tml@collabora.com>  [843db78050bb44db2839c1bd7f765a5b258ba4da]

        Move some static functions from ProfileZone to TraceEvent where they belong
        
        Change-Id: I35f3d5d8c0a69a224cf7d3a2decba9c8e13c7dc1
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114698
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [2d867eff480c03ab125f4c0149dd73afee08db85]

        Make ProfileZone non-copyable
        
        Change-Id: Ia1fe5311751bcb2b2f2bde3408aac836db75e98a
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114697
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Caolán McNamara  <caolanm@redhat.com>  [898a74af8270547d35504ce478613787530eba6a]

        WaE on g_object_ref case, seen in Fedora 34 with glib2-2.68.1
        
        vcl/unx/gtk3/gtk3hudawareness.cxx:95:24: error: redundant static_cast from 'typename std::remove_reference<decltype(connection)>::type' (aka '_GDBusConnection *') to 'GDBusConnection *' (aka '_GDBusConnection *') [loplugin:redundantcast]
        cast<GDBusConnection*>(g_object_ref (connection));
        vcl/unx/gtk3/gtk3hudawareness.cxx:95:24: error: static_cast from 'typename std::remove_reference<decltype(connection)>::type' (aka '_GDBusConnection *') prvalue to 'GDBusConnection *' (aka '_GDBusConnection *') prvalue is redundant [loplugin:redundantcast]
          handle->connection = static_cast<GDBusConnection*>(g_object_ref (connection));
        
        Change-Id: I7460ea60b22aa50d4bd7b10f2e12980d1f80778e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114772
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-28  Miklos Vajna  <vmiklos@collabora.com>  [b73c6c8e53cf944848cdb3a79371703de99a8710]

        sw bibliography: fix warning when de-selecting a biblio entry field
        
        De-selecting a biblio entry field resulted in this warning:
        
        warn:sw.core:3311:3311:sw/source/core/fields/authfld.cxx:104: SwAuthorityFieldType::RemoveField: pEntry is not my field
        
        But this was even an assert before commit
        64ffabbdb2725e93de997171708bb31c33c93a55 (sw bibliography, refer to a
        page: make the biblio field clickable, 2021-03-12).
        
        It seems the root of the problem was:
        
        - SwAuthorityFieldType has a list of SwAuthEntry instances that its
          SwAuthorityFields may have
        - when the field is selected, we copy the selection to a clipboard
          document, using SwFEShell::Copy()
        - this calls SwAuthorityFieldType::AppendField() to register the
          SwAuthEntry, but that registers a copy instead
        - SwAuthorityFieldType::RemoveField() then asserted that the original
          SwAuthEntry is part of SwAuthorityFieldType's list, but it was not
        
        Fix the problem by returning a reference to the copied SwAuthEntry in
        SwAuthorityFieldType::AppendField(), that fixes the warning and then we
        can turn this back to an assert, to detect problems where an
        unregistered SwAuthEntry would be de-registered.
        
        In practice this caused a problem in the Insert Bibliography Entry
        dialog: bibliography source = document content case uses
        SwAuthorityFieldType::GetAllEntryIdentifiers() to provide a list of
        sources, and this way sources were not removed from that list when
        deleting biblio entry fields.
        
        Change-Id: Iea4fa44302aaac0daa122bbf227888d1dbb06597
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114765
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-04-28  Xisco Fauli  <xiscofauli@libreoffice.org>  [ecd8508eaf8a3eb064b26c5c80cd2930fe6e7555]

        git pre-commit hook: fix typo
        
        This code was copy&paste from bin/ui-checkdomain.sh in
        f3665d2a42b39814764f3eb9e20498b8a4be1d00
        <Check UI interface domains in the git pre-commit hook>
        and it was already wrong there.
        
        Kudos to Julien Nabet for flagging it
        
        Change-Id: Id2b16cf76f6e4f983dc59673b67ce369a84cffd5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114762
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-28  Szymon Kłos  <szymon.klos@collabora.com>  [4a7daba508c39e9e535c1c456f82b03f3097513f]

        Revert ScInputWindow::setPosSizePixel() early returns
        
        Revert changes that were introduced to fix CollaboraOnline/online#1988
        because it should be fixed in online
        
        The root cause was that online was sending "resizewindow"
        even when size was not changed what was triggering many times
        ScInputWindow::setPosSizePixel(). (before online fix "resizewindow"
        message was sent on every sidebar refresh)
        
        "Fix early return in ScInputWindow::setPosSizePixel"
        reverts commit a9e0bbadb151d6cfe652fad1d49147f559a6d83c.
        
        "Early return from ScInputWindow::setPosSizePixel() if no-op"
        reverts commit 0ad467d9abd27197bc5f7f22db5a25b3246e6808.
        
        Change-Id: Iad1c3d427a5feefdbb2bac912710847addf4ee02
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114745
        Tested-by: Jenkins
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [f0b4eecdba71f8bce8466b580971cdeea7514c22]

        Extend the trace event API with instant events
        
        Change-Id: I3a93c79f46ffc5768ddaf338789fe2daa225ef4d
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114696
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [9fa66a3de4d6d14f91af8064f0af510070f65567]

        g_nStartTime was unused
        
        Change-Id: I2f4371825f7c528a081e42ee157b21b7fd73b2f6
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114660
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114665
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114672
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Michael Stahl  <michael.stahl@allotropia.de>  [ca19177728c66d913996a48c91a0ba47d08825d6]

        sw: layout: let nested table move forward
        
        The problem is that a nested table at the bottom of the page doesn't fit
        into its cell, but it is split and its first row still remains on the
        page where it doesn't fit.
        
        The outer table 3 tries to split with bTryToSplit=true.
        
        In SwTabFrame::MakeAll(), first a split of the nested table 435 with
        bTryToSplit=true is attempted; this fails and is partially undone -
        the follow flow line is removed, but the last 2 rows remain in follow.
        
        The bTryToSplit=false is skipped because there's only one row now.
        
        Then MoveFwd() is tried, but it fails because the top-level table
        doesn't have a previous frame.
        
        Then bTryToSplit=false is tried, and succeeds, again leaving row 436
        on page 1 and other 2 in follow.
        
        Now another attempt with bTryToSplit=true is made, failing again, not
        effectively changing anything.
        
        During all of this, growing of the outer cell frame 434 and row frame
        433 is prevented by the outer table 3 having a follow flow line, see
        SwRowFrame::GrowFrame().
        
        The result is that cell 434 has content area height 190 but the table
        435 with its single row is all valid with height 406, so it's cut off in
        the rendering.
        
        This doesn't happen for SwTextFrame inside table because that one does
        the MoveFwd().
        
        Plausibly it's the inner table's responsibility to finish with a valid
        state that fits the constraints of the current page; there are some
        checks in lcl_RecalcSplitLine() to check for no content frame in the
        row but none for the row being too small to contain the content that
        was formatted.
        
        So the only valid results for the inner table are that it either moved
        forward, or it left behind a row containing no content (such as that
        produced by its own failed attempt to split with bTryToSplit=true),
        which could be handled by the outer table split code - but the latter
        could be insufficient in case the outer table is itself a follow, or at
        least would require further changes in lcl_RecalcSplitLine().
        
        So fix this by removing a condition in MoveFwd() that doesn't make any
        sense to me - why is it relevant for an inner table during a split of
        the outer table whether the outer table itself can move forward?
        
        Change-Id: I1e01ce233383cc70b9aea72d25369b7278eb75f0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114760
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-28  Michael Stahl  <michael.stahl@allotropia.de>  [c06f05e28cb66bd2aac5ea65bcfa3732808c51c6]

        svl: fix crash in SfxItemSet::dumpAsXml()
        
        Change-Id: I64cb14a740d6874ce288f249953984116648a470
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114759
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-28  Michael Stahl  <michael.stahl@allotropia.de>  [d12acfa1405fa5b7c11d2a517286da68b3fd2eff]

        sw: fix crash in SwFormatAutoFormat::dumpAsXml()
        
        Change-Id: Ib2d723b34d8e6f1254f5a9b0d0be509daf24ce43
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114758
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-28  Michael Stahl  <michael.stahl@allotropia.de>  [569a06656e926dfb26d55958ee0f696aa9e5b7b0]

        sw: fix crash in SwAnchoredObject::dumpAsXml()
        
        SwAnchoredObject::GetObjBoundRect() is const, so it's only idiomatic
        that calling it reformats everything.
        
        Change-Id: Id57472ae3041c7264bc904e1a68907c48e60ac96
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114757
        Tested-by: Jenkins
        Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>

2021-04-28  Noel Grandin  <noel.grandin@collabora.co.uk>  [2a33a16253d4f7c6ef989cc3a65ef5bd552ac48b]

        loplugin:stringadd
        
        Change-Id: Iacb72f10f5306143390774e0a3ef30f5a5bf5c57
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114761
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Tor Lillqvist  <tml@collabora.com>  [41ff704cc49b7097b717882616011962ecd7198f]

        Add API to LibreOfficeKit to set arbitrary run-time options in core
        
        Add setOption(const char*, const char*)
        
        At the moment this enables starting and stopping the ProfileZone event
        recording and overriding the SAL_LOG environment variable.
        
        Change-Id: Ic3a934bb4246c755a91eee8a8343fafc15815116
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114439
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114559
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114656
        Tested-by: Tor Lillqvist <tml@collabora.com>

2021-04-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [9bfe083adf1fd9d470b600d0a801d144db24474f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 6890ffec515115d253b8c452251fc5d393e47ca7
          - Fix typos
            
            Change-Id: I01373966d3299e42b768b0f21067be8c71d9d227
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114746
            Tested-by: Jenkins
            Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
            
2021-04-28  Miklos Vajna  <vmiklos@collabora.com>  [79dbcc09844d815fbd7361c954eb04ce6c6acda0]

        Introduce SwFlyFrameInvFlags to replace magic numbers in ...
        
        ... SwFlyFrame::SwClientNotify()
        
        SwFlyFrame::UpdateAttr_() is not yet updated to produce these.
        
        Change-Id: Ie29d900c1796c868d051ffd9c28600e44ff3b704
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114752
        Tested-by: Jenkins
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2021-04-28  Andrea Gelmini  <andrea.gelmini@gelma.net>  [91fa87e99f5f01b92451b875c72741775c92247b]

        Fix typos
        
        Change-Id: Ic73ee21dea2bc99c5fd8af857a9793782d7c3301
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114747
        Tested-by: Jenkins
        Reviewed-by: Hossein <hossein.ir@gmail.com>
        Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

2021-04-28  Stephan Bergmann  <sbergman@redhat.com>  [c0aede431fd641ea9b92aa145db69a6d45c5bf9c]

        loplugin:stringviewparam (clang-cl)
        
        Change-Id: I3cf85911785f2c03255869f505e5b86ad2fd9c74
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114690
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-28  Miklos Vajna  <vmiklos@collabora.com>  [d524f5b28e2b9bcf7ab681eb6ad93a4da3f5663d]

        sw bibliography, refer to a page: add insert/delete UI
        
        If the toggle button's activate state changes, adapt the sensitivity of
        the next spinbutton, this way a new page number can be added and an old
        one can be deleted.
        
        Change-Id: I97067182e8cd42a02b164ac941598bada2630e07
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114750
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-04-28  Heiko Tietze  <tietze.heiko@gmail.com>  [c9c6b0d75bcbb6ff3343502a19fb3448d361d335]

        Resolves tdf#141553 - Update David CLM font
        
        Culmus font 0.131 updated to 0.133
        
        Change-Id: Icd79dbef8dc350362ea4c4a7ed2ff05a1b95a1a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114738
        Reviewed-by: Hossein <hossein.ir@gmail.com>
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Tested-by: Jenkins

2021-04-28  Mike Kaganski  <mike.kaganski@collabora.com>  [974a8e0f94e6d7cd949cac7cba720a34d3fad53e]

        Change scope of some variables
        
        Change-Id: Ieb504e248a6f2065efdd4b758faf821ac71f0544
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114716
        Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [1325d8161a74a3cedc169952eca10f4343e700c4]

        loplugin:moveopt
        
        An attempt that did not find anything convincing enough to finish it up
        and make it permanently active.
        So just leave it in /store for now.
        
        Change-Id: I1750e177655a4a510da100f880ba81bf762be277
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114742
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-27  Christian Lohmaier  <lohmaier+LibreOffice@googlemail.com>  [452fcbe0792aa10042bb8cd2cfd6cd29ca754be5]

        tdf#137470 use a more proper URL for the extensions
        
        also hide the download-count, since those numbers are completely made up
        by the script
        
        Change-Id: I15b53a8a023c34ecc6a544b88ad35800891e4327
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114740
        Tested-by: Jenkins
        Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

2021-04-27  Andras Timar  <andras.timar@collabora.com>  [c889431df7e77c68fe7ead9aa235a5b2f586a4c6]

        Add Mongolian dictionary
        
        Change-Id: I4613d2e5b77374cbc8fb72033b3dfcd8e2702712
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114733
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [48e279c6748bf023fba12fdc3f4cee402f611c6e]

        use string_view in INetURLObject::decode
        
        Change-Id: I10e04970ceac33c9c3fbfd0182dd2140e06cb80b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114658
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [f3665d2a42b39814764f3eb9e20498b8a4be1d00]

        Check UI interface domains in the git pre-commit hook
        
        This will prevent bugs like tdf#141902 to happen
        
        Change-Id: If81164c704ec17d3fee044aaa0ec9c16d474009e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114705
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [707db60df761a98cfdbd771fdc85979084be0b33]

        Small refactor
        
        Change-Id: I987cd80bb485d3d811c0932c0822efc5d572dfd0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114712
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

2021-04-27  Caolán McNamara  <caolanm@redhat.com>  [aea139c440d7c7a3683fcbbc48799bc79ba590e7]

        tdf#141854 Resize called during dispose
        
        Change-Id: Ie5eaafa95704f9567b8bb9881865571a39bb2f6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114708
        Tested-by: Jenkins
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-27  László Németh  <nemeth@numbertext.org>  [d6322bcedc197a654abc7d64bfea8cf570f123bf]

        tdf#59463 track changes: record deletion of images
        
        Instead of deleting the image object without
        recording the deletion, delete the anchor point
        in the text to record the deletion, if Record
        Changes is enabled.
        
        Note: only images anchored as characters can be
        recorded this way, so change the anchor before
        the deletion, if needed. This less problem, than
        hidden, i.e. non-tracked deletion of images.
        
        Change-Id: I7e4bee82b76b4a26e6482a678a2a1ce432980271
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114671
        Tested-by: Jenkins
        Reviewed-by: László Németh <nemeth@numbertext.org>

2021-04-27  Miklos Vajna  <vmiklos@collabora.com>  [f6b419b8946c5fc2dafa8f4201a4c7379148f306]

        sw bibliography, refer to a page: save edited page number
        
        This is the writing side of commit
        e920406994dd2b880d4b752e3ea4e09e4a8f97cc (sw bibliography, refer to a
        page: add dedicate widget to show the page number, 2021-04-21).
        
        Change-Id: If47932eedd689ca474bfdf44613d0c30087053b7
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114664
        Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
        Tested-by: Jenkins

2021-04-27  Szymon Kłos  <szymon.klos@collabora.com>  [8ff946045138fde19c0656129da611729aa98cb1]

        jsdialog: handle response buttons
        
        Change-Id: I4e8efc4ef2d27e655208ff505167da8360f91a6b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114379
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114597
        Tested-by: Szymon Kłos <szymon.klos@collabora.com>
        Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>

2021-04-27  Armin Le Grand (Allotropia)  <armin.le.grand@me.com>  [4722ad2cf3f2b91c217e3548f811f2972f2aa60c]

        tdf#141761 Enhance PrintDialog Preview for FormControls
        
        The display quality of the Preview is pretty ugly when
        FormControls are used. I made a deep-dive why this happens,
        and in principle the reason is the Mteafile::Scale used
        below. Since Metafile actions are integer, that floating point
        scale leads to rounduing errors that make the lines painting
        the FormControls disappear in the surrounding ClipRegions.
        That Scale cannot be avoided since the Metafile contains it's
        own SetMapMode commands which *will* be executed on ::Play,
        so the ::Scale is the only possibility fr Metafile currently:
        Giving a Size as parameter in ::Play will *not* work due to
        the relativeMapMode that gets created will fail on
        ::SetMapMode actions in the Metafile - and FormControls DO
        use ::SetMapMode(MapPixel).
        This can only be solved better in the future using Primitives
        which would allow any scale by embedding to a Transformation,
        but that would be a bigger rework.
        Until then, use this little 'trick' to improve qulatity.
        It uses the fact to empirically having tested that the quality
        gets really bad for FormControls starting by a scale factor
        smaller than 0.2 - that makes the ClipRegion overlap start.
        So - for now - try not to go below that.
        
        Change-Id: I540de602634c6afa697b5659d69c34159c22075c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114704
        Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
        Tested-by: Armin Le Grand <Armin.Le.Grand@me.com>

2021-04-27  Tomaž Vajngerl  <tomaz.vajngerl@collabora.co.uk>  [1e70359ac7f2e10f7cefe006557b3df8e5a46ae0]

        vcl: store XorEmulation in a unique_ptr not raw pointer
        
        Change-Id: I123c4048d333cdc761582763d6ccb9c254e32bbb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114700
        Tested-by: Jenkins
        Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [3260edbeb59d87f3f3e5c700cda4b0fd6222df0c]

        loplugin:stringadd (clang-cl)
        
        Change-Id: Id7c2db4abcf947c4efa0296df29feca2c36d3cf8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114692
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Tor Lillqvist  <tml@collabora.com>  [d02b6c1d6d2fa975df33057584a99ebaa02bbc95]

        Accept iOS SDK 14.5
        
        Change-Id: I57bfcf40e823551021b58a74ef0e78a5781f5b0e
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114703
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-27  Tor Lillqvist  <tml@collabora.com>  [bc35e5fe5922a71749c65a9b2d0412e4a3f34128]

        Accept macOS SDK 11.3
        
        Change-Id: I210ae30e51d796990f88340da8b29f4c7080f5d2
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114702
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-27  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [8ebb54c6c4937a151f2185e8f54b2c39e446368a]

        tdf#138751 Localize items in Notebookbar customization dropdowns
        
        Change-Id: Idb1483e083f7758acb83da6c3ca9403c40ac9a40
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114447
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-04-27  Gabor Kelemen  <kelemen.gabor2@nisz.hu>  [e94830c0544d18221966ec260db43bcfddf90fe6]

        tdf#140681 Translate Bullets default gallery name
        
        Change-Id: I245b36edb16440391a8b68ce036faf85f28eb140
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114316
        Tested-by: Jenkins
        Reviewed-by: Andras Timar <andras.timar@collabora.com>

2021-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [788a7df6b2d9ec99503971bcb06ac6bbfc9e4100]

        Fix domain in ui files (found with ui-checkdomain.sh)
        
        Change-Id: I6d9fe37636d56b0cd5e06c12c5b5cdbbf54e1d38
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114699
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [91f71650c0cb1ff1c6cf19371154858731b5dd3f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 36d78921fe14e1853153af422b86304c7c098c2c
          - Fix broken link
            
            Change-Id: Ibf9015ae625d0d45b4ab4d72611c7d5413467452
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114739
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [c7c6f0af6c836ebe0968967a1e7c8320b0ac17d6]

        loplugin:stringadd convert chained append to +
        
        which can use the more efficient *StringConcat
        
        Also fix a crash in stringview plugin which
        started happening while I working on this.
        
        Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-27  Vert D  <devoptmsoi@gmx.com>  [99482297c7dd497e41fad2e7193759043e305101]

        tdf#138883 Prevent renaming Templates
        
        *Disable ok button added a tooltip when renaming to an existing template
        *Check while typing.
        
        Change-Id: Iec7266940a1cde1a086ba612c0f2f42dd3e6fc73
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113719
        Tested-by: Jenkins
        Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>

2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [97ee71bfda38472b47d2add50379cd19f7ae7201]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 615a5f87d3f7137b8584d085f9693e8c92dcf296
          - tdf#141822 Rename parameter for standard compliance
            
            VLOOKUP, HLOOKUP, LOOKUP and MATCH
            
            Change-Id: I348024294f24a5190f0d5054dab2f83355d08567
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114632
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [f78a63795d22c19994c48fad8a6a3c6eabf41f99]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to cef07a72b504a83504942eb4cf5b992e1ee46775
          - tdf#131995 Be precise with Criterion in Calc
            
            + Reused and adapted definitions of  ODF 1.2 for Criterion in
            ODFF functions, as suggested in the bug description.
            
            Change-Id: I335c6b2b9bd4236071c544cc2ad7f751db75b99f
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114613
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [3176c1ab3b54da9aa9d29d85235b7661be1d3af8]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to 7d55112c83309001d9f68f6f92959911312258dc
          - tdf#141237 Make clear that security depends or PDF reader
            
            Change-Id: Icd030a91428b384d9751eac18b23e06fa0bc0b6c
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114586
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [725a752bba16ecdd1bc6b2a5b1f5f55052914d3a]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to d6a094a2fe57a7f86c2a58863bdf797562a977b9
          - tdf#113847, tdf#34902 Update print dialog Help page
            
            + refactor page
            + add application selector
            + unhide hidden <ahelp>s (not used anymore, migrated to
            extended tips)
            + Add missing information on printing selection (tdf#34902)
            + Add information on tiling and poster (tdf#113847)
            
            Change-Id: I3c5c0ddd629dfba23c96e6043b0efceddd6779f0
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114584
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Olivier Hallot  <olivier.hallot@libreoffice.org>  [0f619959d3e6025b8216aa588e7145e378491b1f]

        Update git submodules
        
        * Update helpcontent2 from branch 'master'
          to b4b146ad3d84dcf45136a7b89cab453f3afc6674
          - tdf#106195 - clarify direct formatting removal
            
            Change-Id: Iec28e28286eac9effb2512c803fdffbad204d53a
            Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114522
            Tested-by: Jenkins
            Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
            
2021-04-27  Tor Lillqvist  <tml@collabora.com>  [6aa148fd9317fc5dbcab24e3f51bd89779d3a6d6]

        Add also the comma separator between Event Trace events
        
        Change-Id: I13221b9e6437789a72b6d759de4dd0f4434e0fd8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114160
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114558
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114655
        Tested-by: Jenkins

2021-04-27  Tor Lillqvist  <tml@collabora.com>  [ccc4d32417e0683e653c315c0e695e7ccb99f1a9]

        Drop the leftover "sum time" thing from the Event Trace
        
        Change-Id: I222da50f3ad113bf3204b4d21df52c9e55cf7cf0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114159
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114557
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114654
        Tested-by: Jenkins

2021-04-27  Tor Lillqvist  <tml@collabora.com>  [8c80d6f7196ab8cd63c42f6a57b458fdc47fc203]

        Refactor ProfileZone and create Chrome Trace Event Format data
        
        Instead of separate B ("begin") and E ("end") duration events,
        generate X ("complete") events.
        
        Only the event JSON objects are generated, not the surrounding array
        or object.
        
        See
        https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview#heading=h.lc5airzennvk
        
        Online now needs work so that the events are written out to a separate
        file instead of being in the common log file.
        
        Change-Id: Ie9363b4cfda862a70e1928ed16350e50a6fee9a5
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114142
        Tested-by: Tor Lillqvist <tml@collabora.com>
        Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114556
        Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114653
        Tested-by: Jenkins
        Reviewed-by: Tor Lillqvist <tml@collabora.com>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [1d44b6e877cfc31afcfc8925866407ae8771abad]

        loplugin:staticmethods (clang-cl)
        
        Change-Id: Ib096abfeea6cefb5df562cf75448ef38e432344c
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114695
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Batmunkh Dorjgotov  <bataak@gmail.com>  [633a5386e698a7dc2b5d23c1fea8578e9f2d70c1]

        Update git submodules
        
        * Update dictionaries from branch 'master'
          to cb1b834e00bc31f668b086e547032341a0162131
          - Add Mongolian dictionary
            
            Change-Id: I5ee4dd6824d485872bcdfc2d34a33f3c84484780
            Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/112797
            Tested-by: Andras Timar <andras.timar@collabora.com>
            Reviewed-by: Andras Timar <andras.timar@collabora.com>
            
2021-04-27  Julien Nabet  <serval2412@yahoo.fr>  [45779b685b8b1e75ce750bbb20b30cee8fd40851]

        Replace "Persistant" by "Persistent"in WinClipboard (vcl/win)
        
        since now we have it in idl files with the historically wrong "Persistant"
        after these:
        in offapi/com/sun/star/datatransfer/clipboard/RenderingCapabilities.idl
        "Persistant" is deprecated since e738683f98559af330a1cc36d8d0a1be11abb355
        author	Julien Nabet <serval2412@yahoo.fr>	2020-09-12 12:00:49 +0200
        committer	Stephan Bergmann <sbergman@redhat.com>	2020-09-17 15:20:27 +0200
        commit	e738683f98559af330a1cc36d8d0a1be11abb355 (patch)
        tree	fd0e07d574d9ff7656d613f6b88f473951dd5b12
        parent	b33f22678431a57be7e77822e977b66c33680290 (diff)
        Add "Persistent", deprecate "Persistant" in RenderingCapabilities
        
        in offapi/type_reference/offapi.idl
        author	Stephan Bergmann <sbergman@redhat.com>	2021-04-13 10:14:59 +0200
        committer	Stephan Bergmann <sbergman@redhat.com>	2021-04-13 11:47:37 +0200
        commit	bce31cac427d7119cd8ccec64bdfa820706cbfcc (patch)
        tree	ed4a7e0b2aaaac406e350b18136f88add9370b98
        parent	5e5c7e10a5fde5ed93c541d439ce016e35d5d65a (diff)
        Update the reference rdbs to libreoffice-7.1.0.3
        
        Change-Id: I047dc0bc7956f3b14c6319df85f0707ec6addd9b
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114669
        Tested-by: Jenkins
        Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [2cb936a91b9d46aa4e8193a02c4917def4aa9b34]

        -Werror,-Wnon-virtual-dtor (clang-cl)
        
        (1c1226709c6be39c5462f5e6e1262ca630b30b34 "tdf#106282 Change Windows File Dialog
        to run on the main thread" had changed it to non-virtual, but for no apparent
        reason)
        
        Change-Id: I12dc3a46c5d9aad5e43471b97c9ab45ff9f309ee
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114693
        Tested-by: Stephan Bergmann <sbergman@redhat.com>
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [6fc4d07b26869bdaf7b768e4548f1a15941fdbba]

        loplugin:indentation (clang-cl)
        
        Change-Id: Idd1b0282efd1aac524067504a956f0fccdbce6d8
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114694
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [ddd9082c397b97e4aa43daf998f3fe36cb8bb724]

        -Werror,-Wunused-function (clang-cl)
        
        Change-Id: Ic5f4ca1147217d830ea3492b4f42116e15cbae80
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114691
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Jean-Pierre Ledure  <jp@ledure.be>  [cf017d0b4316f52271fe91f8c18a5e648fd5d682]

        ScriptForge - (SFDialogs.SF_Register) DialogProvider
        
        When launching a dialog from a Python script while the
        dialog is contained in a document, the DialogProvider setup
        from that context was built by the wrong method.
        
        Use createInstanceWithArguments()
        i.o. createInstanceWithContext()
        
        This caused a LibreOffice crash.
        
        Change-Id: I3615c55068134085579662004f5bb085de008cbd
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114677
        Tested-by: Jean-Pierre Ledure <jp@ledure.be>
        Tested-by: Jenkins
        Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>

2021-04-27  Stephan Bergmann  <sbergman@redhat.com>  [d507c8b3e2939f66a395f163b5f21c29ffe59d02]

        loplugin:nullptr (clang-cl)
        
        Change-Id: I3c0ee11c42a2a4a22adf894341b04a229d579226
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114689
        Tested-by: Jenkins
        Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2021-04-27  Caolán McNamara  <caolanm@redhat.com>  [c0cbd13c945c5f47057b413efc88b2e3bb72d025]

        Related: tdf#130326 drop ScContentTree::ObjectFresh
        
        this was introduced as part of the large IA2 integration
        
        commit b41332475783c31136673fb44cf4c411bb0148f8
        Author: Steve Yin <steve_y@apache.org>
        Date:   Mon Dec 2 15:54:29 2013 +0000
        
            Integrate branch of IAccessible2
        
        Both calc and writer gained the feature that "space" in the navigator
        for drawing objects selects the highlighted object, extending the
        selection if another one is already selected. (notably impress was
        left unchanged)
        
        In calc, but not writer, an ObjectFresh was added which fires
        on every SfxHintId::ScKillEditView which is broadcast on every
        exit of the cursor from a cell. Its purpose seems to be primarily to
        re-highlight the last selected-by-keyboard entry on a content refresh.
        
        As far as I can tell this doesn't seem necessary and we already refresh
        content on SfxHintId::ScDrawChanged events so we shouldn't need to
        additionally refresh on ScKillEditView and refreshing on every
        ScKillEditView is very slow on navigating through a calc document with a
        lot of drawing objects.
        
        Change-Id: I64b2840f8510d474314d108e657fc3367f8ab6c0
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114650
        Tested-by: Caolán McNamara <caolanm@redhat.com>
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-27  Caolán McNamara  <caolanm@redhat.com>  [1a891f2fadae01aca95157b09d6ea8e223bee1ea]

        Related: tdf#130326 allow bulk_insert_for_each to insert under a node
        
        Change-Id: Iad14638a33710ef0b790c702e7eab2283726f2fb
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114571
        Tested-by: Jenkins
        Reviewed-by: Caolán McNamara <caolanm@redhat.com>

2021-04-27  Noel Grandin  <noel.grandin@collabora.co.uk>  [62f6d6ee8bca918e17ae167582095f4302203bed]

        use more string_view in tools/stream
        
        Change-Id: I2a957cd72d71fea717734488cdb3670e0bcdd6f4
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114657
        Tested-by: Jenkins
        Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2021-04-27  Xisco Fauli  <xiscofauli@libreoffice.org>  [bde131ad18620dea03531c59893c99be09e3ce4e]

        tdf#141914: sc_bugfix: Add unittest
        
        Change-Id: I937b973fde43b7840e01d8ba4ce37f8e15274a89
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114673
        Tested-by: Jenkins
        Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>

2021-04-27  Mike Kaganski  <mike.kaganski@collabora.com>  [a3843f1cb0095e843bc4ee7ed20802147f63c7ba]

        tdf#141164: Add an expert config for WebDAV redirection detection
        
        Since commit 20b1e6440aacab043753e93be4499e939a80b05b, we detect
        redirected WebDAV paths, and substitute them with original WebDAV
        URLs to allow retrieving additional information like lock owner.
        
        The new officecfg::Office::Common::Load::DetectWebDAVRedirection
        allows to disable the detection, and opt to older way of use of
        Windows Redirector, taking advantage of its cookie handling until
        we implement own proper cookie handling.
        
        Change-Id: I1510a016f40dbe81dcba9aa4fd50eda73a6d9f22
        Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114686
        Tested-by: Jenkins
        Reviewed-by: Mike Kaganski <mike.kagansk